From xen-devel-bounces@lists.xenproject.org Sun Jan 01 03:45:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 01 Jan 2023 03:45:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470059.729504 (Exim 4.92) (envelope-from ) id 1pBpHC-0004SP-0A; Sun, 01 Jan 2023 03:44:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470059.729504; Sun, 01 Jan 2023 03:44:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pBpHB-0004SH-Pm; Sun, 01 Jan 2023 03:44:45 +0000 Received: by outflank-mailman (input) for mailman id 470059; Sun, 01 Jan 2023 03:44:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pBpHA-0004S7-Op; Sun, 01 Jan 2023 03:44:44 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pBpHA-00013c-La; Sun, 01 Jan 2023 03:44:44 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pBpHA-0002NI-0f; Sun, 01 Jan 2023 03:44:44 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pBpH9-0005jA-SU; Sun, 01 Jan 2023 03:44:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=RguQacY/nKjE++pQVabwjzKV2k/elA3f+unIfSSfgd4=; b=sELqmNvg1iiLjZYnOgXCQLXLCr 3ssSpNNgRYJ8IuPNvGRCh5XGsxKkUrx+LHhoMGymAyRkh6CCZwbY/MHEVngc3fiarqcXTZwPAvj8s J7D31v6itc9F0IDl9nCvFXWVeIwxP0POC8TTcN1PKjASWmr5eWVmzvDYLtgQauxkD6v4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 175539: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=e4cf7c25bae5c3b5089a3c23a897f450149caef2 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Sun, 01 Jan 2023 03:44:43 +0000 flight 175539 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/175539/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 173462 test-amd64-amd64-examine 8 reboot fail REGR. vs. 173462 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux e4cf7c25bae5c3b5089a3c23a897f450149caef2 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 85 days Failing since 173470 2022-10-08 06:21:34 Z 84 days 175 attempts Testing same since 175539 2022-12-31 19:43:50 Z 0 days 1 attempts ------------------------------------------------------------ 3254 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 496420 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Jan 01 06:15:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 01 Jan 2023 06:15:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470074.729515 (Exim 4.92) (envelope-from ) id 1pBrcS-0008Ac-Tj; Sun, 01 Jan 2023 06:14:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470074.729515; Sun, 01 Jan 2023 06:14:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pBrcS-0008AM-NK; Sun, 01 Jan 2023 06:14:52 +0000 Received: by outflank-mailman (input) for mailman id 470074; Sun, 01 Jan 2023 06:14:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pBrcR-0008AC-67; Sun, 01 Jan 2023 06:14:51 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pBrcR-0005Bi-2r; Sun, 01 Jan 2023 06:14:51 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pBrcQ-0003AD-J4; Sun, 01 Jan 2023 06:14:50 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pBrcQ-0002Fh-Fq; Sun, 01 Jan 2023 06:14:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=B6qAQVTj8LEGUumIcQN7yU9CUSdSYg5pj7zXZWPJuTo=; b=sSEcqiZrTndV9tQ3wfP9cnBjKl cs3mh3w8OBCGm/vd+d95kCRT38X+T5I/4gUc4AIUoYZbBamMlOnrKTJI0p2qSZCnIQNGRMuvdjH0B N41V+6rnd+/fVvHfbH1moOyHOV6Dc7sPt1PShnz8ozQKSTSCeDSHzDOUiCoDqdzIBF0w=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 175540: FAIL X-Osstest-Failures: linux-5.4:test-amd64-amd64-xl-credit2::broken:regression linux-5.4:test-amd64-amd64-xl-qemut-debianhvm-amd64::broken:regression linux-5.4:test-amd64-i386-qemuu-rhel6hvm-intel::broken:regression linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64::broken:regression linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:host-install(5):broken:heisenbug linux-5.4:test-amd64-amd64-xl-credit2:host-install(5):broken:heisenbug linux-5.4:test-amd64-i386-qemuu-rhel6hvm-intel:host-install(5):broken:heisenbug linux-5.4:test-amd64-amd64-xl-qemut-debianhvm-amd64:host-install(5):broken:heisenbug linux-5.4:test-amd64-amd64-libvirt-vhd:guest-start.2:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:heisenbug linux-5.4:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-amd64-i386-pair:xen-install/src_host:fail:heisenbug linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:heisenbug linux-5.4:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-vhd:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-libvirt-raw:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=851c2b5fb7936d54e1147f76f88e2675f9f82b52 X-Osstest-Versions-That: linux=66bb2e2b24ce52819a7070d3a3255726cb946b69 From: osstest service owner Date: Sun, 01 Jan 2023 06:14:50 +0000 flight 175540 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/175540/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-credit2 broken in 175407 test-amd64-amd64-xl-qemut-debianhvm-amd64 broken in 175407 test-amd64-i386-qemuu-rhel6hvm-intel broken in 175407 test-amd64-i386-xl-qemuu-ws16-amd64 broken in 175407 Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-ws16-amd64 5 host-install(5) broken in 175407 pass in 175540 test-amd64-amd64-xl-credit2 5 host-install(5) broken in 175407 pass in 175540 test-amd64-i386-qemuu-rhel6hvm-intel 5 host-install(5) broken in 175407 pass in 175540 test-amd64-amd64-xl-qemut-debianhvm-amd64 5 host-install(5) broken in 175407 pass in 175540 test-amd64-amd64-libvirt-vhd 20 guest-start.2 fail in 175536 pass in 175538 test-armhf-armhf-xl-credit1 14 guest-start fail in 175536 pass in 175540 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 175538 pass in 175540 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail pass in 175407 test-amd64-i386-pair 10 xen-install/src_host fail pass in 175536 test-armhf-armhf-xl-multivcpu 14 guest-start fail pass in 175538 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail pass in 175538 test-armhf-armhf-xl-rtds 14 guest-start fail pass in 175538 test-armhf-armhf-xl-vhd 13 guest-start fail pass in 175538 test-armhf-armhf-libvirt-raw 13 guest-start fail pass in 175538 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail blocked in 175197 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail in 175407 like 175197 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 175536 like 175197 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail in 175536 like 175197 test-armhf-armhf-xl-rtds 15 migrate-support-check fail in 175536 never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail in 175536 never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail in 175536 never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail in 175536 never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail in 175536 never pass test-armhf-armhf-libvirt-qcow2 13 guest-start fail in 175538 like 175197 test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail in 175538 never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail in 175538 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 175197 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 175197 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175197 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 175197 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175197 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175197 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 175197 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 175197 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 175197 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175197 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux 851c2b5fb7936d54e1147f76f88e2675f9f82b52 baseline version: linux 66bb2e2b24ce52819a7070d3a3255726cb946b69 Last test of basis 175197 2022-12-14 10:43:17 Z 17 days Testing same since 175407 2022-12-19 11:42:26 Z 12 days 30 attempts ------------------------------------------------------------ People who touched revisions under test: Alexei Starovoitov Andrew Morton Baolin Wang Charles Keepax Florian Fainelli Greg Kroah-Hartman Guenter Roeck Heiko Schocher Hulk Robot Jakub Kicinski Jialiang Wang Jon Hunter Linus Walleij Linux Kernel Functional Testing Lorenzo Colitti Maciej Żenczykowski Marc Kleine-Budde Mark Brown Ming Lei Paul E. McKenney Ricardo Ribalda Samuel Mendoza-Jonas Sasha Levin Shiwei Cui Shuah Khan Simon Horman Sudip Mukherjee Yasushi SHOJI Yasushi SHOJI jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw fail test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd fail test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-xl-credit2 broken broken-job test-amd64-amd64-xl-qemut-debianhvm-amd64 broken broken-job test-amd64-i386-qemuu-rhel6hvm-intel broken broken-job test-amd64-i386-xl-qemuu-ws16-amd64 broken Not pushing. (No revision log; it would be 410 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Jan 01 08:37:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 01 Jan 2023 08:37:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470088.729525 (Exim 4.92) (envelope-from ) id 1pBtq9-0002sY-8L; Sun, 01 Jan 2023 08:37:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470088.729525; Sun, 01 Jan 2023 08:37:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pBtq9-0002sR-5i; Sun, 01 Jan 2023 08:37:09 +0000 Received: by outflank-mailman (input) for mailman id 470088; Sun, 01 Jan 2023 08:37:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pBtq8-0002sH-3V; Sun, 01 Jan 2023 08:37:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pBtq8-0000qv-0C; Sun, 01 Jan 2023 08:37:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pBtq7-0000ay-1v; Sun, 01 Jan 2023 08:37:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pBtq7-000331-0o; Sun, 01 Jan 2023 08:37:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=na2H8WO1yr9+JElHKFaihx0o84md8ZQZMdA028n1+S0=; b=cCcgFGw4y2+kE69OeSdOEOEVS8 5yGoo2YTrm9W5InmyU7g7Jpnfk419H1vDb93iALEGzYMdsUtH+ycGeonss5weBE+ocvHwhHzCm1px 6EOaojoa5ah+bFZNpALKclfu7j+1MZcj9CjZpnOIIemmvW7bPLPGc3Lg4dVV/hMp2o6w=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 175541: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=7eef80e06ed2282bbcec3619d860c6aacb0515d8 X-Osstest-Versions-That: xen=7eef80e06ed2282bbcec3619d860c6aacb0515d8 From: osstest service owner Date: Sun, 01 Jan 2023 08:37:07 +0000 flight 175541 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/175541/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175526 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 175534 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175534 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 175534 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175534 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175534 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 175534 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 175534 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 175534 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 175534 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 175534 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 175534 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 7eef80e06ed2282bbcec3619d860c6aacb0515d8 baseline version: xen 7eef80e06ed2282bbcec3619d860c6aacb0515d8 Last test of basis 175541 2023-01-01 01:54:34 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Sun Jan 01 14:48:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 01 Jan 2023 14:48:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470104.729538 (Exim 4.92) (envelope-from ) id 1pBzdf-0000Pa-Dd; Sun, 01 Jan 2023 14:48:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470104.729538; Sun, 01 Jan 2023 14:48:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pBzdf-0000PT-7a; Sun, 01 Jan 2023 14:48:39 +0000 Received: by outflank-mailman (input) for mailman id 470104; Sun, 01 Jan 2023 14:48:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pBzde-0000PF-NV; Sun, 01 Jan 2023 14:48:38 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pBzde-0001Z6-L3; Sun, 01 Jan 2023 14:48:38 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pBzde-00064Y-28; Sun, 01 Jan 2023 14:48:38 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pBzde-0005XB-1g; Sun, 01 Jan 2023 14:48:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=iUGD9b/kwuM4sIt4+/IPfkt86Qh9gf6evsgMCWrsG3c=; b=na3j6fHAJ19ilOgRjjuZ4CQlkF 2SsGlsXPLMZ5mtMJwIM71XWaSibRlLBwxnNr76gfxVX6Wc2SkEcS511dG7JpLuSC4Nih/e1SQVeNd XmltDLJfpwzIbI8jj6da32XObZT/9LtIYgA5IDWOkedww0MM/we63rE2IjUTOM5+5h1w=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 175542: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=e4cf7c25bae5c3b5089a3c23a897f450149caef2 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Sun, 01 Jan 2023 14:48:38 +0000 flight 175542 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/175542/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 173462 test-amd64-amd64-examine 8 reboot fail REGR. vs. 173462 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux e4cf7c25bae5c3b5089a3c23a897f450149caef2 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 85 days Failing since 173470 2022-10-08 06:21:34 Z 85 days 176 attempts Testing same since 175539 2022-12-31 19:43:50 Z 0 days 2 attempts ------------------------------------------------------------ 3254 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 496420 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Jan 01 15:01:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 01 Jan 2023 15:01:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470113.729548 (Exim 4.92) (envelope-from ) id 1pBzpm-0001A7-FG; Sun, 01 Jan 2023 15:01:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470113.729548; Sun, 01 Jan 2023 15:01:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pBzpm-0001A0-By; Sun, 01 Jan 2023 15:01:10 +0000 Received: by outflank-mailman (input) for mailman id 470113; Sun, 01 Jan 2023 15:01:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pBzpk-00019u-T3 for xen-devel@lists.xenproject.org; Sun, 01 Jan 2023 15:01:09 +0000 Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1bc8970d-89e5-11ed-91b6-6bf2151ebd3b; Sun, 01 Jan 2023 16:01:04 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id F206132002FB; Sun, 1 Jan 2023 10:01:00 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sun, 01 Jan 2023 10:01:01 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 1 Jan 2023 10:00:56 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1bc8970d-89e5-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1672585260; x= 1672671660; bh=X7obdlIu9PYYeP+uZsieZNOt5OQU6gNv6h9CZLugzpQ=; b=E jOj39WEP4Ya9aiY5z1cNiMq59QPtZ5lSR1Fz7SKlt/qt480vfBRKFNEsItcGF31z BU9TxV7WbMyICR1unSeS/EACE/cV4CkVGKmHxAQWPQeZqIVykcGmOLgi57amXdpA hYNs3+cg8apMBM3kmtfgliJnO/TPJWxlOceYhila7CL26JMa674XNe1lB5XRtXSs OA2CDb1iEJDlc4iy5BKyqRCd8PN9zqRusraZLrrWv0L1xVK/KdY5tpcHZ4J5/Pzy DZi6Rta6MuDFvxgS3okcA/x9VHSlxSeKK3JY2RDpDUAtZyXzYHC9XAiYS3uqrXh2 9APFOUzMNRTeuDviBzx5g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1672585260; x=1672671660; bh=X7obdlIu9PYYeP+uZsieZNOt5OQU 6gNv6h9CZLugzpQ=; b=hSQokPzcSPcDKmZporw7m5E0UIGhIkehrm/AiA/nRecW oTaPm4r0UO5v8lfTGNmnLcRHmhzvzXl9Uh41y8MxCPSl3LUTI4XILY4SPUBI30z9 3qyBV/j438ksvWRxF+IHVKraC7LO/CM1k+SxxmC7MZfHYRMm3s2foaeZqFSw11jk tVemo1wsIflh/bYCJ10aG3CshRnyZSk1R6IzPD6HAb6/mjjGR4NLAYxdWV/Kzfnk 679LbJbNkwzWVTVjG1GyjK7VO36NOIITTNMp48BCKPqPyKn4gW1Fm0NA5SsIfMuk 7ICNLmMG/rd+9cBev1+4lKf2ZL+l24DBxq4uz4dM6A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrjedtgdeijecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefgudel teefvefhfeehieetleeihfejhfeludevteetkeevtedtvdegueetfeejudenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhes ihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Sun, 1 Jan 2023 16:00:50 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Andrew Cooper Cc: Xen-devel , Jan Beulich , Roger Pau =?utf-8?B?TW9ubsOp?= , Wei Liu Subject: Re: [PATCH 1/2] x86/cpuid: Infrastructure for leaves 7:1{ecx,edx} Message-ID: References: <20221231003007.26916-1-andrew.cooper3@citrix.com> <20221231003007.26916-2-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tMAtNi7zpm7M/yTn" Content-Disposition: inline In-Reply-To: <20221231003007.26916-2-andrew.cooper3@citrix.com> --tMAtNi7zpm7M/yTn Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Sun, 1 Jan 2023 16:00:50 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Andrew Cooper Cc: Xen-devel , Jan Beulich , Roger Pau =?utf-8?B?TW9ubsOp?= , Wei Liu Subject: Re: [PATCH 1/2] x86/cpuid: Infrastructure for leaves 7:1{ecx,edx} On Sat, Dec 31, 2022 at 12:30:06AM +0000, Andrew Cooper wrote: > We don't actually need ecx yet, but adding it in now will reduce the amou= nt to > which leaf 7 is out of order in a featureset. >=20 > cpufeatureset.h remains in leaf architectrual order for the sanity of any= one > trying to locate where to insert new rows. >=20 > Signed-off-by: Andrew Cooper > --- > CC: Jan Beulich > CC: Roger Pau Monn=C3=A9 > CC: Wei Liu > --- > tools/misc/xen-cpuid.c | 10 ++++++++++ > xen/arch/x86/cpu/common.c | 3 ++- > xen/include/public/arch-x86/cpufeatureset.h | 3 +++ > xen/include/xen/lib/x86/cpuid.h | 15 ++++++++++++++- > 4 files changed, 29 insertions(+), 2 deletions(-) >=20 > diff --git a/tools/misc/xen-cpuid.c b/tools/misc/xen-cpuid.c > index d5833e9ce879..0091a11a67bc 100644 > --- a/tools/misc/xen-cpuid.c > +++ b/tools/misc/xen-cpuid.c > @@ -202,6 +202,14 @@ static const char *const str_7b1[32] =3D > [ 0] =3D "ppin", > }; > =20 > +static const char *const str_7c1[32] =3D > +{ > +}; > + > +static const char *const str_7d1[32] =3D > +{ > +}; > + > static const char *const str_7d2[32] =3D > { > [ 0] =3D "intel-psfd", > @@ -229,6 +237,8 @@ static const struct { > { "0x80000021.eax", "e21a", str_e21a }, > { "0x00000007:1.ebx", "7b1", str_7b1 }, > { "0x00000007:2.edx", "7d2", str_7d2 }, > + { "0x00000007:1.ecx", "7b1", str_7c1 }, > + { "0x00000007:1.edx", "7b1", str_7d1 }, "7c1" and "7d1" ? --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --tMAtNi7zpm7M/yTn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmOxoCQACgkQ24/THMrX 1ywWTggAlO6Y2XPzgM/eZh8mSyzx8sApwoYd3Qa8kz/xV1Kj3HSX4kI6tL7z+RMH yXC6bideqATvzFRzTWWzgQ+3nwiSi/EFe0H3W4EeKy1En2SBjpVNeZDjeLk+uPj4 1cbbv61BDcBd196DLrMG71L0UTJYe+RnJPOwGPtp/gSgzy2/zqAHfsj7707qOJOe QnqxuZeP7D42+cHJ6ot8e31x7ScCL4V0Aa0LOR7svmBPHm1bPNjpjgguELfdGYQC UjmJgrAUHIL+00S4r488PeL22YuLnX3PkW8YqNjtB1awLyiOuKtSZxO9sDr5rGPy onuMim5IYhj9HkxrTWhak1vI0xxvyg== =W6fD -----END PGP SIGNATURE----- --tMAtNi7zpm7M/yTn-- From xen-devel-bounces@lists.xenproject.org Sun Jan 01 15:11:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 01 Jan 2023 15:11:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470121.729559 (Exim 4.92) (envelope-from ) id 1pBzzP-0001s3-DI; Sun, 01 Jan 2023 15:11:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470121.729559; Sun, 01 Jan 2023 15:11:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pBzzP-0001rw-91; Sun, 01 Jan 2023 15:11:07 +0000 Received: by outflank-mailman (input) for mailman id 470121; Sun, 01 Jan 2023 15:11:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pBzzO-0001rq-BO for xen-devel@lists.xenproject.org; Sun, 01 Jan 2023 15:11:06 +0000 Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 82214e8a-89e6-11ed-91b6-6bf2151ebd3b; Sun, 01 Jan 2023 16:11:04 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 312C632005CA; Sun, 1 Jan 2023 10:11:02 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sun, 01 Jan 2023 10:11:02 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 1 Jan 2023 10:10:58 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 82214e8a-89e6-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1672585861; x= 1672672261; bh=0iWt9Z2gLbDLmZ3Gl405zz+RiInR67FHrOISNpK+eQo=; b=z BE/218ltPLi/9QKJiPs+yXwfWBknaWGX3MqAinvoJJK2pbeU37HGeHnLyTRJ4Mc/ H3vIg+vnQDlkjCZvcG1TFmM+0TUOhw7WCItZwWxZXMnJLczT+Fs5s8rVoEdbVSGO 17wHZcNCbzn13vsk3C2GPnzskL4B6WxvE8X80xeA7MJsyZSZPPhIETZ0rAku42WZ UOc4cOnegc49vvJaTV+Hhy3GzwK5MrLUXAlWfcZOlAKPY/tNushsSZhljg+qaaZ8 OOjKxJzRm8OPUOf0OWb3R1fIVqXBFy7PuQ6PMn+e8jEIt2BROFHjhzG+4Tgm8Eg2 GbvNAykWufPc2fJXvoANA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1672585861; x=1672672261; bh=0iWt9Z2gLbDLmZ3Gl405zz+RiInR 67FHrOISNpK+eQo=; b=EpwVUp3YbqvO8XdwOIEzmq+pCZx/oo7PHCZB66fCSJBE 106S2UdR21RO4LhV16Q4xYCMLyq8X5PEoJCS9N/C6rZKSyW3mpGIP79szDkWQAFi jHj1s01lUfKfIalMHi1o2zQU0LQI6VbRjHbrUtcMy6N40j1DKqfE7IzAy8+AhwZG NMBHYvpGY0NyHaDyYDrDILS221SdY3tAp+sw3bEOyBX7ye6naQvQ+DXF7NnXFotx ocsPfBxTdPkcKzP5cCSU/VhvbnBHx/Ctbm9o5QEy9HUnBxawFckgANTrU+IHQgg5 aNimGPKLI4Y0xkoxkZ7WPlMY3CgMLM57JiRverxifw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrjedtgdejtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefgudel teefvefhfeehieetleeihfejhfeludevteetkeevtedtvdegueetfeejudenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhes ihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Sun, 1 Jan 2023 16:10:54 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Andrew Cooper Cc: Xen-devel , Jan Beulich , Roger Pau =?utf-8?B?TW9ubsOp?= , Wei Liu Subject: Re: [PATCH 2/2] x86/shskt: Disable CET-SS on parts succeptable to fractured updates Message-ID: References: <20221231003007.26916-1-andrew.cooper3@citrix.com> <20221231003007.26916-3-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="+a2V8WRjif75DJuw" Content-Disposition: inline In-Reply-To: <20221231003007.26916-3-andrew.cooper3@citrix.com> --+a2V8WRjif75DJuw Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Sun, 1 Jan 2023 16:10:54 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Andrew Cooper Cc: Xen-devel , Jan Beulich , Roger Pau =?utf-8?B?TW9ubsOp?= , Wei Liu Subject: Re: [PATCH 2/2] x86/shskt: Disable CET-SS on parts succeptable to fractured updates On Sat, Dec 31, 2022 at 12:30:07AM +0000, Andrew Cooper wrote: > Refer to Intel SDM Rev 70 (Dec 2022), Vol3 17.2.3 "Supervisor Shadow Stack > Token". >=20 > Architecturally, an event delivery which starts in CPL>3 and switches sha= dow > stack will first validate the Supervisor Shstk Token and set the busy bit, > then pushes LIP/CS/SSP. One example of this is an NMI interrupting Xen. >=20 > Some CPUs suffer from an issue called fracturing, whereby a fault/vmexit/= etc > between setting the busy bit and completing the event injection renders t= he > action non-restartable, because when it comes time to restart, the busy b= it is > found to be already set. >=20 > This is far more easily encountered under virt, yet it is not the fault o= f the > hypervisor, nor the fault of the guest kernel. The fault lies somewhere > between the architectural specification, and the uarch behaviour. >=20 > Intel have allocated CPUID.7[1].ecx[18] CET_SSS to enumerate that supervi= sor > shadow stacks are safe to use. Because of how Xen lays out its shadow st= acks, > fracturing is not expected to be a problem on native. >=20 > Detect this case on boot and default to not using shstk if virtualised. > Specifying `cet=3Dshstk` on the command line will override this heurstic = and > enable shadow stacks irrespective. >=20 > Signed-off-by: Andrew Cooper > --- > CC: Jan Beulich > CC: Roger Pau Monn=C3=A9 > CC: Wei Liu >=20 > I've got a query out with AMD, but so far it is only Intel CPUs known to = be > impacted. >=20 > This ideally wants backporting to Xen 4.14. I have no idea how likely it= is > to need to backport the prerequisite patch for new feature words, but we'= ve > already had to do that once for security patches... > --- > docs/misc/xen-command-line.pandoc | 7 +++++- > tools/libs/light/libxl_cpuid.c | 2 ++ > tools/misc/xen-cpuid.c | 1 + > xen/arch/x86/cpu/common.c | 11 +++++++-- > xen/arch/x86/setup.c | 37 +++++++++++++++++++++++= +++--- > xen/include/public/arch-x86/cpufeatureset.h | 1 + > 6 files changed, 53 insertions(+), 6 deletions(-) >=20 > diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-li= ne.pandoc > index 923910f553c5..19d4d815bdee 100644 > --- a/docs/misc/xen-command-line.pandoc > +++ b/docs/misc/xen-command-line.pandoc > @@ -287,10 +287,15 @@ can be maintained with the pv-shim mechanism. > protection. > =20 > The option is available when `CONFIG_XEN_SHSTK` is compiled in, and > - defaults to `true` on hardware supporting CET-SS. Specifying > + generally defaults to `true` on hardware supporting CET-SS. Specify= ing > `cet=3Dno-shstk` will cause Xen not to use Shadow Stacks even when s= upport > is available in hardware. > =20 > + Some hardware suffers from an issue known as Supervisor Shadow Stack > + Fracturing. On such hardware, Xen will default to not using Shadow = Stacks > + when virtualised. Specifying `cet=3Dshstk` will override this heuri= stic and > + enable Shadow Stacks unilaterally. > + > * The `ibt=3D` boolean controls whether Xen uses Indirect Branch Track= ing for > its own protection. > =20 > diff --git a/tools/libs/light/libxl_cpuid.c b/tools/libs/light/libxl_cpui= d.c > index 2aa23225f42c..d97a2f3338bc 100644 > --- a/tools/libs/light/libxl_cpuid.c > +++ b/tools/libs/light/libxl_cpuid.c > @@ -235,6 +235,8 @@ int libxl_cpuid_parse_config(libxl_cpuid_policy_list = *cpuid, const char* str) > {"fsrs", 0x00000007, 1, CPUID_REG_EAX, 11, 1}, > {"fsrcs", 0x00000007, 1, CPUID_REG_EAX, 12, 1}, > =20 > + {"cet-sss", 0x00000007, 1, CPUID_REG_EDX, 18, 1}, > + > {"intel-psfd", 0x00000007, 2, CPUID_REG_EDX, 0, 1}, > {"mcdt-no", 0x00000007, 2, CPUID_REG_EDX, 5, 1}, > =20 > diff --git a/tools/misc/xen-cpuid.c b/tools/misc/xen-cpuid.c > index 0091a11a67bc..ea33b587665d 100644 > --- a/tools/misc/xen-cpuid.c > +++ b/tools/misc/xen-cpuid.c > @@ -208,6 +208,7 @@ static const char *const str_7c1[32] =3D > =20 > static const char *const str_7d1[32] =3D > { > + [18] =3D "cet-sss", > }; > =20 > static const char *const str_7d2[32] =3D > diff --git a/xen/arch/x86/cpu/common.c b/xen/arch/x86/cpu/common.c > index b3fcf4680f3a..d962f384a995 100644 > --- a/xen/arch/x86/cpu/common.c > +++ b/xen/arch/x86/cpu/common.c > @@ -346,11 +346,18 @@ void __init early_cpu_init(void) > x86_cpuid_vendor_to_str(c->x86_vendor), c->x86, c->x86, > c->x86_model, c->x86_model, c->x86_mask, eax); > =20 > - if (c->cpuid_level >=3D 7) > - cpuid_count(7, 0, &eax, &ebx, > + if (c->cpuid_level >=3D 7) { > + uint32_t max_subleaf; > + > + cpuid_count(7, 0, &max_subleaf, &ebx, > &c->x86_capability[FEATURESET_7c0], > &c->x86_capability[FEATURESET_7d0]); > =20 > + if (max_subleaf >=3D 1) tabs vs spaces ... Is this file imported from Linux? It uses tabs for indentation, contrary to the rest of the Xen code base. > + cpuid_count(7, 1, &eax, &ebx, &ecx, > + &c->x86_capability[FEATURESET_7d1]); > + } > + > eax =3D cpuid_eax(0x80000000); > if ((eax >> 16) =3D=3D 0x8000 && eax >=3D 0x80000008) { > ebx =3D eax >=3D 0x8000001f ? cpuid_ebx(0x8000001f) : 0; > diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c > index 566422600d94..e052b7b748fa 100644 > --- a/xen/arch/x86/setup.c > +++ b/xen/arch/x86/setup.c > @@ -96,7 +96,7 @@ size_param("highmem-start", highmem_start); > #endif > =20 > #ifdef CONFIG_XEN_SHSTK > -static bool __initdata opt_xen_shstk =3D true; > +static int8_t __initdata opt_xen_shstk =3D -1; > #else > #define opt_xen_shstk false > #endif > @@ -1101,9 +1101,40 @@ void __init noreturn __start_xen(unsigned long mbi= _p) > /* Choose shadow stack early, to set infrastructure up appropriately= =2E */ > if ( opt_xen_shstk && boot_cpu_has(X86_FEATURE_CET_SS) ) > { > - printk("Enabling Supervisor Shadow Stacks\n"); > + /* > + * Some CPUs suffer from Shadow Stack Fracturing, an issue where= by a > + * fault/VMExit/etc between setting a Supervisor Busy bit and the > + * event delivery completing renders the operation non-restartab= le. > + * On restart, event delivery will find the Busy bit already set. > + * > + * This is a problem on native, but outside of synthetic cases, = only > + * with #MC against a stack access (in which case we're dead any= way). > + * It is a much bigger problem under virt, because we can VMExit= for a > + * number of legitimate reasons and tickle this bug. > + * > + * CPUs with this addressed enumerate CET-SSS to indicate that > + * supervisor shadow stacks are now safe to use. > + */ > + bool cpu_has_bug_shstk_fracture =3D > + boot_cpu_data.x86_vendor =3D=3D X86_VENDOR_INTEL && > + !boot_cpu_has(X86_FEATURE_CET_SSS); > + > + /* > + * On native, assume that Xen won't be impacted by shstk fractur= ing > + * problems. Under virt, be more conservative and disable shstk= by > + * default. > + */ > + if ( opt_xen_shstk =3D=3D -1 ) > + opt_xen_shstk =3D > + cpu_has_hypervisor ? !cpu_has_bug_shstk_fracture > + : true; > + > + if ( opt_xen_shstk ) > + { > + printk("Enabling Supervisor Shadow Stacks\n"); > =20 > - setup_force_cpu_cap(X86_FEATURE_XEN_SHSTK); > + setup_force_cpu_cap(X86_FEATURE_XEN_SHSTK); > + } > } > =20 > if ( opt_xen_ibt && boot_cpu_has(X86_FEATURE_CET_IBT) ) > diff --git a/xen/include/public/arch-x86/cpufeatureset.h b/xen/include/pu= blic/arch-x86/cpufeatureset.h > index 7a896f0e2d92..f6a46f62a549 100644 > --- a/xen/include/public/arch-x86/cpufeatureset.h > +++ b/xen/include/public/arch-x86/cpufeatureset.h > @@ -290,6 +290,7 @@ XEN_CPUFEATURE(INTEL_PPIN, 12*32+ 0) /* Pro= tected Processor Inventory > =20 > /* Intel-defined CPU features, CPUID level 0x00000007:1.ecx, word 14 */ > /* Intel-defined CPU features, CPUID level 0x00000007:1.edx, word 15 */ > +XEN_CPUFEATURE(CET_SSS, 15*32+18) /* CET Supervisor Shadow = Stacks safe to use */ > =20 > /* Intel-defined CPU features, CPUID level 0x00000007:2.edx, word 13 */ > XEN_CPUFEATURE(INTEL_PSFD, 13*32+ 0) /*A MSR_SPEC_CTRL.PSFD */ > --=20 > 2.11.0 >=20 >=20 --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --+a2V8WRjif75DJuw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmOxon4ACgkQ24/THMrX 1yzQ8Af/eDRIjmUkuoE9Oc63KDRB5WB+pCi8hFiwWELOfAkGpWiUVjqVtTCwIoba lZaKVgTb1tNX5FSk7BOEzngH09zATAEk4b61ZVldAq/3LLuiW2YGMAZDRDf5al7l pkMxoy+Tk9Ze+bEhawl2dC0FXzWgTXkVEUWd12AtFtImLcF8Gx4UILI8/USzi5Om V1UPMppQlI4+d9MvPw47jwnLniWqxb0235ZRQPUqZkGM10HJCtwzN1H2tXD3TgzP ANxNDptb+oEHqP4HDi5OyDanjm+ht4ARJVwq5nBJ4Rua/zYg/PK+GgxBEyFRMACe Q8m577inn76kaVNmQbPx7mgkWLCGTw== =zDH5 -----END PGP SIGNATURE----- --+a2V8WRjif75DJuw-- From xen-devel-bounces@lists.xenproject.org Sun Jan 01 15:29:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 01 Jan 2023 15:29:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470131.729570 (Exim 4.92) (envelope-from ) id 1pC0Gn-0002jW-V4; Sun, 01 Jan 2023 15:29:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470131.729570; Sun, 01 Jan 2023 15:29:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pC0Gn-0002jP-Ru; Sun, 01 Jan 2023 15:29:05 +0000 Received: by outflank-mailman (input) for mailman id 470131; Sun, 01 Jan 2023 15:29:04 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pC0Gm-0002jF-Aq; Sun, 01 Jan 2023 15:29:04 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pC0Gm-0002Qn-8y; Sun, 01 Jan 2023 15:29:04 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pC0Gl-00070F-S9; Sun, 01 Jan 2023 15:29:03 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pC0Gl-0001ET-Re; Sun, 01 Jan 2023 15:29:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=WF5lPz66X1OSwVvjX6vDFO5oUXkWeyOlgS7pUa9Q9io=; b=2fAx5kPtOHwikPgHhRAyFqoz4r 1sBnaCHIgDiC7tOIu6ydxPwkRh49S+vHlODiTQBEiNvUjiHt5fOB0P50lYEXdPybQk3gaR3oOVGt8 e/gDV6nlDMi55VwePSog4YSnbuCZix+sI0dNYj67wP8xbV3vRC9NNaR8RjAeT9wHzkR0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 175543: FAIL X-Osstest-Failures: linux-5.4:test-amd64-amd64-xl-qemut-debianhvm-amd64::broken:regression linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64::broken:regression linux-5.4:test-amd64-i386-qemuu-rhel6hvm-intel::broken:regression linux-5.4:test-amd64-amd64-xl-credit2::broken:regression linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:host-install(5):broken:heisenbug linux-5.4:test-amd64-i386-qemuu-rhel6hvm-intel:host-install(5):broken:heisenbug linux-5.4:test-amd64-amd64-xl-credit2:host-install(5):broken:heisenbug linux-5.4:test-amd64-amd64-xl-qemut-debianhvm-amd64:host-install(5):broken:heisenbug linux-5.4:test-amd64-i386-pair:xen-install/src_host:fail:heisenbug linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:heisenbug linux-5.4:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-vhd:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-libvirt-raw:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-amd64-i386-pair:xen-install/dst_host:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start.2:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=851c2b5fb7936d54e1147f76f88e2675f9f82b52 X-Osstest-Versions-That: linux=66bb2e2b24ce52819a7070d3a3255726cb946b69 From: osstest service owner Date: Sun, 01 Jan 2023 15:29:03 +0000 flight 175543 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/175543/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-debianhvm-amd64 broken in 175407 test-amd64-i386-xl-qemuu-ws16-amd64 broken in 175407 test-amd64-i386-qemuu-rhel6hvm-intel broken in 175407 test-amd64-amd64-xl-credit2 broken in 175407 Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-ws16-amd64 5 host-install(5) broken in 175407 pass in 175543 test-amd64-i386-qemuu-rhel6hvm-intel 5 host-install(5) broken in 175407 pass in 175543 test-amd64-amd64-xl-credit2 5 host-install(5) broken in 175407 pass in 175543 test-amd64-amd64-xl-qemut-debianhvm-amd64 5 host-install(5) broken in 175407 pass in 175543 test-amd64-i386-pair 10 xen-install/src_host fail in 175540 pass in 175543 test-armhf-armhf-xl-multivcpu 14 guest-start fail in 175540 pass in 175543 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail in 175540 pass in 175543 test-armhf-armhf-xl-rtds 14 guest-start fail in 175540 pass in 175543 test-armhf-armhf-xl-vhd 13 guest-start fail in 175540 pass in 175543 test-armhf-armhf-libvirt-raw 13 guest-start fail in 175540 pass in 175543 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail pass in 175407 test-amd64-i386-pair 11 xen-install/dst_host fail pass in 175540 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-rtds 19 guest-start.2 fail blocked in 175197 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail blocked in 175197 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail in 175407 like 175197 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 175197 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 175197 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175197 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 175197 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175197 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175197 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 175197 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 175197 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 175197 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 175197 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175197 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux 851c2b5fb7936d54e1147f76f88e2675f9f82b52 baseline version: linux 66bb2e2b24ce52819a7070d3a3255726cb946b69 Last test of basis 175197 2022-12-14 10:43:17 Z 18 days Testing same since 175407 2022-12-19 11:42:26 Z 13 days 31 attempts ------------------------------------------------------------ People who touched revisions under test: Alexei Starovoitov Andrew Morton Baolin Wang Charles Keepax Florian Fainelli Greg Kroah-Hartman Guenter Roeck Heiko Schocher Hulk Robot Jakub Kicinski Jialiang Wang Jon Hunter Linus Walleij Linux Kernel Functional Testing Lorenzo Colitti Maciej Żenczykowski Marc Kleine-Budde Mark Brown Ming Lei Paul E. McKenney Ricardo Ribalda Samuel Mendoza-Jonas Sasha Levin Shiwei Cui Shuah Khan Simon Horman Sudip Mukherjee Yasushi SHOJI Yasushi SHOJI jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-xl-qemut-debianhvm-amd64 broken broken-job test-amd64-i386-xl-qemuu-ws16-amd64 broken broken-job test-amd64-i386-qemuu-rhel6hvm-intel broken broken-job test-amd64-amd64-xl-credit2 broken Not pushing. (No revision log; it would be 410 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Jan 01 21:21:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 01 Jan 2023 21:21:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470142.729581 (Exim 4.92) (envelope-from ) id 1pC5lz-0000aY-Qn; Sun, 01 Jan 2023 21:21:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470142.729581; Sun, 01 Jan 2023 21:21:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pC5lz-0000aR-NU; Sun, 01 Jan 2023 21:21:39 +0000 Received: by outflank-mailman (input) for mailman id 470142; Sun, 01 Jan 2023 21:21:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pC5ly-0000aL-Fz for xen-devel@lists.xenproject.org; Sun, 01 Jan 2023 21:21:38 +0000 Received: from sonic309-21.consmr.mail.gq1.yahoo.com (sonic309-21.consmr.mail.gq1.yahoo.com [98.137.65.147]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 442f083c-8a1a-11ed-91b6-6bf2151ebd3b; Sun, 01 Jan 2023 22:21:35 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic309.consmr.mail.gq1.yahoo.com with HTTP; Sun, 1 Jan 2023 21:21:32 +0000 Received: by hermes--production-ne1-7b69748c4d-srx4j (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 7f437a9e58cf454b53c47f515b720546; Sun, 01 Jan 2023 21:21:29 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 442f083c-8a1a-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1672608092; bh=S30WlSSONBXrZ2BF/FPFcCpOU+QISMNJ7oj/4DgswUw=; h=From:To:Cc:Subject:Date:References:From:Subject:Reply-To; b=Huz+R3UeJtZmUYPS++HCKp2ESoNmFKrmWAcdYeqlOq+dRVqpqkYdvgICTnBinTh/dRLch50n7vvbSkhd12SZmXpbS0c8T7LIbqW/ktfVg8+bXzjixBE6oqYDTA/IOss1pDkGI3dWZ3lM6kPwZicZsXDcewuJTv3F9NHbkhBBAq4XEuKrhyi9Po4ky6BSXMhS39sB1zVMJuTc2iBhhsUoWiZsy2ahpDYQBiiMzXRancv9G748+pecZ9crI99U8rSa21F/HQvA2vt83sry8DjGjUfRGuqbCoNxKY65TAzFD/WSQWlkhwlEHY+nUp8YwhlLd3jsiM9V7Wz/usxcabYL8A== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1672608092; bh=r/yy/ZKK2KArZy546ewlwnBrVacT2a5OP52yPzVlDHf=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=BZ8kVUKyjl0/D637pX9LdAwQLGWUyx1Q1Rya1KgL9hMZ2lzfN+ScNMcqRf0+KMnqrdF0RNmJE+Tion5D5o3fMFk3Jd9yzg/qU7HW7wL790Koq/QVmp5HvJpcX0dxoYCYsXSnSg7aW2poRvnqTVDho648mxNKq1y8z5vhg/45lAC/L4koJIM2lXNR/aWFU1WYJ433qOl6gkj1gNng54mXmVW7+LnNoE9kpaXSzWMlOCqr+Iwo1LS1DtDp0TcJLxJNuQCSaPHsmL/aHcSTi5S6FBvxulTKX3yKVnZOjZXUbGQP/xUJ6ax8sY2mMVGB8Mzmp62G2voIMd/rQsjSaMZc8w== X-YMail-OSG: BCDhSkMVM1mJ85S6opULzSNIPRuCztzSVruPbT59egn165AIS3i4QGYt35uPTCW IFT99kYLyRzdwTdlnXJBSdu2It0yYWn30BgoBX9eOATBQzzQw00KmDvoEUM1ws66tauVgglfktd1 r0kOUE7DOiR2IjzZsD1GR_ECFHFZgUbtDj5WSz4p2zj_UWU3uVUhiHPAgY3QjoI9rtC2FLNR93am HT3wHtfk6GKw8Z1j1My01aYii8r87DXcE5EQjsFzkW6Tww_MAN5VauXBD5aevzoVnxWWQGszeujY RhU_B5oMVW5Nfh0F7TgpXwjK2CGb3W6fhbLn4cOMKqEq2_ivNBiM9SRCpYce4lS6IjntD6P7PaA9 VX1KJuR7DdegHeawktOLhkkSUh6tyKTHE4wjskptrL3pDx1uK0Om0yrDBp9UjNw.Os2cWKreVWYp 0HZ66r8GpypWmMzwfcbjy4LFE3NmU821lW7q2m3yZm9d_zPI2p9gsgfqV5gCLoXgYk5CWYr_JHPz 94djlnqQg6WV8gykzmtdCDqIbJ1DR_WtqskzE5Kj8_vSqylU76TPOb90b3MEf2agpKCoJjamGEZp 0fNdOzocqgy7dpQ9yxdg2tyZ2EJxglsFEEqy763054_w9.Y2dOvDu.lQ21s4offltFJoVrpQdhsA wgAf4R7nKH2YPULO_KbPZFWzUMd0sbOZ.Maj5jYRI1FVEnYN4CXisDGZ_b7f5X.fM5tALYbHvrDu 7BPk93JqRZqvSF.Iy_oDD8CCfM6mS3gIQCWkzfCOtuwD.wsRs6QwLs3HwVxsWHLB2Hp2BHt81M9o xQleAZsfBsYfwxvISvluAxQLiNFGk8ObZhlWo5YHQBxOdsQeQNTpKlDrseyLDfsCxZjp5UDCD2ZE apRBWRistAxqb7fSXQYu00SaVvA22.6jOAdR_k.cZV05hiCCJquABK7fbq8cC0BdIQM1Cb9MAjOc Ie8KelimQWjpLNgXXyQNayPx20cxycoPFnVDLyWb5c1ejiTpsU0twNib5bkhwV3O.Y4HBYfJXuiW b5Xk6MILzaGpKWQXzp3ikPhZZ0_p9.0tpVIKOuSVb.88HKfml6ce_d6WbnEurcYx7g_46uHIW2ds creTYERfYLhlJYrVPZ_7lUdRuy6YQYADzatmuvunUQrUXJbHefe8lnYNLDcpjsFPrcQNWmoUfkk9 wFHId_F3SFnNlU_P.lJ2tKVEGSYSa6cXFW4GmpvUEFYiTnWp3G8c2nGzrWY.2fODXt.TaqT7y3QU lgDexhh8zApNRgeVGttwNuhGrHS_NtRI4FDDjqBphr6DhULPZvaxkjoSRtsEU6wbgUpoEKN.PYPk qtScsOWYuq0UwCSSaj8PuqJ1oCgkbwvIGTNrPY27gFmPT.yDC1eHvftq_WbWyQMaEwe_BuS.D5VP DwNhMrVXDrQ6Ud6ITstP2DbaW46cTe6mZ3VmKxBEuO.QFGk45rHK1KENvG4JbbJIei4e2fIS0bOP 0qFVnPIvEMNwMr.WHY1UiMid4RfpcInzp_xGUCu3M7rcsN4BAwBMg0IffrYSLMpZXosmU8B3rCRf 5WEAu7NR5RZyoT8y_1dv.QUS_HnORYznYi90nZSAs4_VXnn5EJSUwfEA74qVBxmATzKqowxKBuks M9dGV3WuclyKjjgDDrtSqp6bjx4VW_H2_1MwIL5Edz49Xu5OgAZvsbuvmecEiuEe.eJ9gnJi0kfb r01pauFVeLNt5QyAR3l5_0KTsfManc_QvHFHtHn_3EWZNO1TfaCxWw4eFmGHxZKuAckbHGla45_2 9FUTfHHnlaEU6DaYvxPAg3dbemMOAIVrjGiJXnOmp9PFs6Lg.76ZO2QtSDf_I.1JrtWHajLWis9K 4eD8xPir6V8us9OVw1HjQ1lpTTtOTg4TfBQsMFZcJeMoRYpZwTGvthnHpHC_7jIy8act2pbb9gEq G92QNc9i5gLkgQVgFHMJEXFAJWI_lhp7aya9EW4gyIFNNZv8LQ9NzdjA9udyJqFgpbpEmV8g.0ho mn34igxj9coaUmrtMnSrOo5gRjOuj.3FH8L_wzhNtP.wc7UYvsCCouFMlPNgUzwlUV8ejC2tc.nh Rf2lNwl.YX4ipLaeOqmmwEkvG9.oEPGoyfPAUq49ZX1sfy12cl9UVoj_gSP7jtZEJYCWZ_gS0KTb nnAo7wYwNxh68MhnbZX_UR_DZCY9XBcyLYdmcHGgdbWVIz0eRjg4q6Jn1iIt8FJCVpTJlA_O.Zov Bgcc- X-Sonic-MF: From: Chuck Zmudzinski To: qemu-devel@nongnu.org Cc: Stefano Stabellini , Anthony Perard , Paul Durrant , Paolo Bonzini , Richard Henderson , Eduardo Habkost , "Michael S. Tsirkin" , Marcel Apfelbaum , xen-devel@lists.xenproject.org Subject: [PATCH v5] xen/pt: reserve PCI slot 2 for Intel igd-passthru Date: Sun, 1 Jan 2023 16:21:19 -0500 Message-Id: X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit References: Content-Length: 10830 Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, as noted in docs/igd-assign.txt in the Qemu source code. Currently, when the xl toolstack is used to configure a Xen HVM guest with Intel IGD passthrough to the guest with the Qemu upstream device model, a Qemu emulated PCI device will occupy slot 2 and the Intel IGD will occupy a different slot. This problem often prevents the guest from booting. The only available workaround is not good: Configure Xen HVM guests to use the old and no longer maintained Qemu traditional device model available from xenbits.xen.org which does reserve slot 2 for the Intel IGD. To implement this feature in the Qemu upstream device model for Xen HVM guests, introduce the following new functions, types, and macros: * XEN_PT_DEVICE_CLASS declaration, based on the existing TYPE_XEN_PT_DEVICE * XEN_PT_DEVICE_GET_CLASS macro helper function for XEN_PT_DEVICE_CLASS * typedef XenPTQdevRealize function pointer * XEN_PCI_IGD_SLOT_MASK, the value of slot_reserved_mask to reserve slot 2 * xen_igd_reserve_slot and xen_igd_clear_slot functions The new xen_igd_reserve_slot function uses the existing slot_reserved_mask member of PCIBus to reserve PCI slot 2 for Xen HVM guests configured using the xl toolstack with the gfx_passthru option enabled, which sets the igd-passthru=on option to Qemu for the Xen HVM machine type. The new xen_igd_reserve_slot function also needs to be implemented in hw/xen/xen_pt_stub.c to prevent FTBFS during the link stage for the case when Qemu is configured with --enable-xen and --disable-xen-pci-passthrough, in which case it does nothing. The new xen_igd_clear_slot function overrides qdev->realize of the parent PCI device class to enable the Intel IGD to occupy slot 2 on the PCI bus since slot 2 was reserved by xen_igd_reserve_slot when the PCI bus was created in hw/i386/pc_piix.c for the case when igd-passthru=on. Move the call to xen_host_pci_device_get, and the associated error handling, from xen_pt_realize to the new xen_igd_clear_slot function to initialize the device class and vendor values which enables the checks for the Intel IGD to succeed. The verification that the host device is an Intel IGD to be passed through is done by checking the domain, bus, slot, and function values as well as by checking that gfx_passthru is enabled, the device class is VGA, and the device vendor in Intel. Signed-off-by: Chuck Zmudzinski --- Notes that might be helpful to reviewers of patched code in hw/xen: The new functions and types are based on recommendations from Qemu docs: https://qemu.readthedocs.io/en/latest/devel/qom.html Notes that might be helpful to reviewers of patched code in hw/i386: The small patch to hw/i386/pc_piix.c is protected by CONFIG_XEN so it does not affect builds that do not have CONFIG_XEN defined. xen_igd_gfx_pt_enabled() in the patched hw/i386/pc_piix.c file is an existing function that is only true when Qemu is built with xen-pci-passthrough enabled and the administrator has configured the Xen HVM guest with Qemu's igd-passthru=on option. v2: Remove From: tag at top of commit message v3: Changed the test for the Intel IGD in xen_igd_clear_slot: if (is_igd_vga_passthrough(&s->real_device) && (s->real_device.vendor_id == PCI_VENDOR_ID_INTEL)) { is changed to if (xen_igd_gfx_pt_enabled() && (s->hostaddr.slot == 2) && (s->hostaddr.function == 0)) { I hoped that I could use the test in v2, since it matches the other tests for the Intel IGD in Qemu and Xen, but those tests do not work because the necessary data structures are not set with their values yet. So instead use the test that the administrator has enabled gfx_passthru and the device address on the host is 02.0. This test does detect the Intel IGD correctly. v4: Use brchuckz@aol.com instead of brchuckz@netscape.net for the author's email address to match the address used by the same author in commits be9c61da and c0e86b76 Change variable for XEN_PT_DEVICE_CLASS: xptc changed to xpdc v5: The patch of xen_pt.c was re-worked to allow a more consistent test for the Intel IGD that uses the same criteria as in other places. This involved moving the call to xen_host_pci_device_get from xen_pt_realize to xen_igd_clear_slot and updating the checks for the Intel IGD in xen_igd_clear_slot: if (xen_igd_gfx_pt_enabled() && (s->hostaddr.slot == 2) && (s->hostaddr.function == 0)) { is changed to if (is_igd_vga_passthrough(&s->real_device) && s->real_device.domain == 0 && s->real_device.bus == 0 && s->real_device.dev == 2 && s->real_device.func == 0 && s->real_device.vendor_id == PCI_VENDOR_ID_INTEL) { Added an explanation for the move of xen_host_pci_device_get from xen_pt_realize to xen_igd_clear_slot to the commit message. Rebase. hw/i386/pc_piix.c | 3 +++ hw/xen/xen_pt.c | 56 +++++++++++++++++++++++++++++++++----------- hw/xen/xen_pt.h | 16 +++++++++++++ hw/xen/xen_pt_stub.c | 4 ++++ 4 files changed, 65 insertions(+), 14 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index b48047f50c..bc5efa4f59 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -405,6 +405,9 @@ static void pc_xen_hvm_init(MachineState *machine) } pc_xen_hvm_init_pci(machine); + if (xen_igd_gfx_pt_enabled()) { + xen_igd_reserve_slot(pcms->bus); + } pci_create_simple(pcms->bus, -1, "xen-platform"); } #endif diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c index 0ec7e52183..7e54500b27 100644 --- a/hw/xen/xen_pt.c +++ b/hw/xen/xen_pt.c @@ -775,20 +775,6 @@ static void xen_pt_realize(PCIDevice *d, Error **errp) int pirq = XEN_PT_UNASSIGNED_PIRQ; /* register real device */ - XEN_PT_LOG(d, "Assigning real physical device %02x:%02x.%d" - " to devfn 0x%x\n", - s->hostaddr.bus, s->hostaddr.slot, s->hostaddr.function, - s->dev.devfn); - - xen_host_pci_device_get(&s->real_device, - s->hostaddr.domain, s->hostaddr.bus, - s->hostaddr.slot, s->hostaddr.function, - errp); - if (*errp) { - error_append_hint(errp, "Failed to \"open\" the real pci device"); - return; - } - s->is_virtfn = s->real_device.is_virtfn; if (s->is_virtfn) { XEN_PT_LOG(d, "%04x:%02x:%02x.%d is a SR-IOV Virtual Function\n", @@ -950,11 +936,52 @@ static void xen_pci_passthrough_instance_init(Object *obj) PCI_DEVICE(obj)->cap_present |= QEMU_PCI_CAP_EXPRESS; } +void xen_igd_reserve_slot(PCIBus *pci_bus) +{ + XEN_PT_LOG(0, "Reserving PCI slot 2 for IGD\n"); + pci_bus->slot_reserved_mask |= XEN_PCI_IGD_SLOT_MASK; +} + +static void xen_igd_clear_slot(DeviceState *qdev, Error **errp) +{ + ERRP_GUARD(); + PCIDevice *pci_dev = (PCIDevice *)qdev; + XenPCIPassthroughState *s = XEN_PT_DEVICE(pci_dev); + XenPTDeviceClass *xpdc = XEN_PT_DEVICE_GET_CLASS(s); + PCIBus *pci_bus = pci_get_bus(pci_dev); + + XEN_PT_LOG(d, "Assigning real physical device %02x:%02x.%d" + " to devfn 0x%x\n", + s->hostaddr.bus, s->hostaddr.slot, s->hostaddr.function, + s->dev.devfn); + + xen_host_pci_device_get(&s->real_device, + s->hostaddr.domain, s->hostaddr.bus, + s->hostaddr.slot, s->hostaddr.function, + errp); + if (*errp) { + error_append_hint(errp, "Failed to \"open\" the real pci device"); + return; + } + + if (is_igd_vga_passthrough(&s->real_device) && + s->real_device.domain == 0 && s->real_device.bus == 0 && + s->real_device.dev == 2 && s->real_device.func == 0 && + s->real_device.vendor_id == PCI_VENDOR_ID_INTEL) { + pci_bus->slot_reserved_mask &= ~XEN_PCI_IGD_SLOT_MASK; + XEN_PT_LOG(pci_dev, "Intel IGD found, using slot 2\n"); + } + xpdc->pci_qdev_realize(qdev, errp); +} + static void xen_pci_passthrough_class_init(ObjectClass *klass, void *data) { DeviceClass *dc = DEVICE_CLASS(klass); PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); + XenPTDeviceClass *xpdc = XEN_PT_DEVICE_CLASS(klass); + xpdc->pci_qdev_realize = dc->realize; + dc->realize = xen_igd_clear_slot; k->realize = xen_pt_realize; k->exit = xen_pt_unregister_device; k->config_read = xen_pt_pci_read_config; @@ -977,6 +1004,7 @@ static const TypeInfo xen_pci_passthrough_info = { .instance_size = sizeof(XenPCIPassthroughState), .instance_finalize = xen_pci_passthrough_finalize, .class_init = xen_pci_passthrough_class_init, + .class_size = sizeof(XenPTDeviceClass), .instance_init = xen_pci_passthrough_instance_init, .interfaces = (InterfaceInfo[]) { { INTERFACE_CONVENTIONAL_PCI_DEVICE }, diff --git a/hw/xen/xen_pt.h b/hw/xen/xen_pt.h index e7c4316a7d..40b31b5263 100644 --- a/hw/xen/xen_pt.h +++ b/hw/xen/xen_pt.h @@ -3,6 +3,7 @@ #include "hw/xen/xen_common.h" #include "hw/pci/pci.h" +#include "hw/pci/pci_bus.h" #include "xen-host-pci-device.h" #include "qom/object.h" @@ -41,7 +42,20 @@ typedef struct XenPTReg XenPTReg; #define TYPE_XEN_PT_DEVICE "xen-pci-passthrough" OBJECT_DECLARE_SIMPLE_TYPE(XenPCIPassthroughState, XEN_PT_DEVICE) +#define XEN_PT_DEVICE_CLASS(klass) \ + OBJECT_CLASS_CHECK(XenPTDeviceClass, klass, TYPE_XEN_PT_DEVICE) +#define XEN_PT_DEVICE_GET_CLASS(obj) \ + OBJECT_GET_CLASS(XenPTDeviceClass, obj, TYPE_XEN_PT_DEVICE) + +typedef void (*XenPTQdevRealize)(DeviceState *qdev, Error **errp); + +typedef struct XenPTDeviceClass { + PCIDeviceClass parent_class; + XenPTQdevRealize pci_qdev_realize; +} XenPTDeviceClass; + uint32_t igd_read_opregion(XenPCIPassthroughState *s); +void xen_igd_reserve_slot(PCIBus *pci_bus); void igd_write_opregion(XenPCIPassthroughState *s, uint32_t val); void xen_igd_passthrough_isa_bridge_create(XenPCIPassthroughState *s, XenHostPCIDevice *dev); @@ -76,6 +90,8 @@ typedef int (*xen_pt_conf_byte_read) #define XEN_PCI_INTEL_OPREGION 0xfc +#define XEN_PCI_IGD_SLOT_MASK 0x4UL /* Intel IGD slot_reserved_mask */ + typedef enum { XEN_PT_GRP_TYPE_HARDWIRED = 0, /* 0 Hardwired reg group */ XEN_PT_GRP_TYPE_EMU, /* emul reg group */ diff --git a/hw/xen/xen_pt_stub.c b/hw/xen/xen_pt_stub.c index 2d8cac8d54..5c108446a8 100644 --- a/hw/xen/xen_pt_stub.c +++ b/hw/xen/xen_pt_stub.c @@ -20,3 +20,7 @@ void xen_igd_gfx_pt_set(bool value, Error **errp) error_setg(errp, "Xen PCI passthrough support not built in"); } } + +void xen_igd_reserve_slot(PCIBus *pci_bus) +{ +} -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Sun Jan 01 23:01:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 01 Jan 2023 23:01:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470152.729592 (Exim 4.92) (envelope-from ) id 1pC7Kh-0002c0-4g; Sun, 01 Jan 2023 23:01:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470152.729592; Sun, 01 Jan 2023 23:01:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pC7Kh-0002bt-1B; Sun, 01 Jan 2023 23:01:35 +0000 Received: by outflank-mailman (input) for mailman id 470152; Sun, 01 Jan 2023 23:01:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pC7Kg-0002bj-86; Sun, 01 Jan 2023 23:01:34 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pC7Kg-0004rF-53; Sun, 01 Jan 2023 23:01:34 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pC7Kf-0007H3-Iq; Sun, 01 Jan 2023 23:01:33 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pC7Kf-0002ZQ-IM; Sun, 01 Jan 2023 23:01:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=OJR5MKPEAYB4ZBKU4sgCqFcvXAel/bhKVOsDgRFKlRE=; b=P67nSyjjCBi5lugY6tHf601M/C vPssOmn0tBB9AmJbi67w7Sm8wbFIdx8Ad5tmWEpaPapO1yVOlskW5IUrHQdq67h4g05RlzokoqO+y iDmOmVIJxaunNZWzNWn0knC4V/sFj1tgyeRpnlXy8PMViNM8ZxaqCChUXD/Ef/BfWcy0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 175544: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=e4cf7c25bae5c3b5089a3c23a897f450149caef2 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Sun, 01 Jan 2023 23:01:33 +0000 flight 175544 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/175544/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 173462 test-amd64-amd64-examine 8 reboot fail REGR. vs. 173462 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux e4cf7c25bae5c3b5089a3c23a897f450149caef2 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 86 days Failing since 173470 2022-10-08 06:21:34 Z 85 days 177 attempts Testing same since 175539 2022-12-31 19:43:50 Z 1 days 3 attempts ------------------------------------------------------------ 3254 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 496420 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Jan 01 23:25:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 01 Jan 2023 23:25:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470161.729603 (Exim 4.92) (envelope-from ) id 1pC7hj-0003TV-Ty; Sun, 01 Jan 2023 23:25:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470161.729603; Sun, 01 Jan 2023 23:25:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pC7hj-0003TO-R0; Sun, 01 Jan 2023 23:25:23 +0000 Received: by outflank-mailman (input) for mailman id 470161; Sun, 01 Jan 2023 23:25:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pC7hi-0003TI-LJ for xen-devel@lists.xenproject.org; Sun, 01 Jan 2023 23:25:23 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8d485b44-8a2b-11ed-8fd4-01056ac49cbb; Mon, 02 Jan 2023 00:25:19 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 5B4EA5C00C0; Sun, 1 Jan 2023 18:25:17 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sun, 01 Jan 2023 18:25:17 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 1 Jan 2023 18:25:15 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8d485b44-8a2b-11ed-8fd4-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1672615517; x= 1672701917; bh=/ixdKicwJ/iycAG6e0GinH8Mqtqh91IJTxQYyBrr4/w=; b=H 1pgl1lOn+0MlZV8pXl1MhvIWeD5BWbonVS7e+UQCx1ERgtgx4ZiKvJN41YZ9b0bE 0zrYBiFHHRc3KCyaHBwK9s5PeUxQLexwIM7acb2aYUmLQDSvCwmxZVAP/lxXnAoN mO5xSSZCSFiDlcLXmnFt8tdnl/oSiDINKyUwkCcR3K61Nr0d+0et3Z40UcDAzsQc UzDOfwEjhVC8QtUov0eWS5Od8TzsMwHDh8UtLzpBb2Bt+1lXu/FiQD9mScCPQf44 lQ8FVD5ja2QFhZMDE9oWW1TykTyK1YqdOyPexUYgTWT2I2pD4+xSOYPeUon+fmzg YmhOUH8Hi9Wc4mttjvIpg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1672615517; x=1672701917; bh=/ixdKicwJ/iycAG6e0GinH8Mqtqh 91IJTxQYyBrr4/w=; b=LSXapZ0UHiFYgZKAfSw5WsYsso5FM0DBX3rzu/tgHD2S q9dyt5+dzJLH3p8aWw5z74Ku8XGQF8x2i1Pbb0cy7+58D/M/U+Z2WK/RlMsb0sfI y3MtpBZvcLwiomOHVdim2RRRrwlu8dd0hT+9LyNAZwQq6duza1VhPQyZEzMOQ0Fa C0wZE/JAwsxE8JbNi8tzbjZylApBE03N8GyGCHb0OHCBUYFwd0s8VJ6cmN1InZzg 14y3AhVPkLlp354HtuF+tcLvDqV3KuX+zMO8KXFpbagG+CN/jV1Yj8tpM2tdgwY6 zPpeob7jjOJ6oPk4FuVnQc0wPo+2agGyQXnHeShFfQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrjedugddtkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeeliedu tdfggfekuefhhedtfeevhfetgfdtvdeujeeuteevtdeutdegffeguedufeenucffohhmrg hinhepqhhusggvshdqohhsrdhorhhgpdhgihhthhhusgdrtghomhdpkhgvrhhnvghlrdho rhhgpdhithhlrdhsphgrtggvnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomhepmhgrrhhmrghrvghksehinhhvihhsihgslhgvthhhihhnghhslhgr sgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Mon, 2 Jan 2023 00:24:54 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Ville =?utf-8?B?U3lyasOkbMOk?= Cc: Andrew Cooper , "intel-gfx@lists.freedesktop.org" , the arch/x86 maintainers , Lucas De Marchi , Daniel Vetter , Rodrigo Vivi , "Demi M. Obenour" , xen-devel Subject: Re: [Intel-gfx] [cache coherency bug] i915 and PAT attributes Message-ID: References: <1c326e0c-5812-083a-0739-aa20fab3efc4@citrix.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mv1JohAN8Ksm/tl+" Content-Disposition: inline In-Reply-To: --mv1JohAN8Ksm/tl+ Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Mon, 2 Jan 2023 00:24:54 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Ville =?utf-8?B?U3lyasOkbMOk?= Cc: Andrew Cooper , "intel-gfx@lists.freedesktop.org" , the arch/x86 maintainers , Lucas De Marchi , Daniel Vetter , Rodrigo Vivi , "Demi M. Obenour" , xen-devel Subject: Re: [Intel-gfx] [cache coherency bug] i915 and PAT attributes On Thu, Dec 22, 2022 at 10:29:57AM +0200, Ville Syrj=C3=A4l=C3=A4 wrote: > On Fri, Dec 16, 2022 at 03:30:13PM +0000, Andrew Cooper wrote: > > On 08/12/2022 1:55 pm, Marek Marczykowski-G=C3=B3recki wrote: > > > Hi, > > > > > > There is an issue with i915 on Xen PV (dom0). The end result is a lot= of > > > glitches, like here: https://openqa.qubes-os.org/tests/54748#step/sta= rtup/8 > > > (this one is on ADL, Linux 6.1-rc7 as a Xen PV dom0). It's using Xorg > > > with "modesetting" driver. > > > > > > After some iterations of debugging, we narrowed it down to i915 handl= ing > > > caching. The main difference is that PAT is setup differently on Xen = PV > > > than on native Linux. Normally, Linux does have appropriate abstracti= on > > > for that, but apparently something related to i915 doesn't play well > > > with it. The specific difference is: > > > native linux: > > > x86/PAT: Configuration [0-7]: WB WC UC- UC WB WP UC- WT > > > xen pv: > > > x86/PAT: Configuration [0-7]: WB WT UC- UC WC WP UC UC > > > ~~ ~~ ~~ ~~ > > > > > > The specific impact depends on kernel version and the hardware. The m= ost > > > severe issues I see on >=3DADL, but some older hardware is affected t= oo - > > > sometimes only if composition is disabled in the window manager. > > > Some more information is collected at > > > https://github.com/QubesOS/qubes-issues/issues/4782 (and few linked > > > duplicates...). > > > > > > Kind-of related commit is here: > > > https://github.com/torvalds/linux/commit/bdd8b6c98239cad ("drm/i915: > > > replace X86_FEATURE_PAT with pat_enabled()") - it is the place where > > > i915 explicitly checks for PAT support, so I'm cc-ing people mentioned > > > there too. > > > > > > Any ideas? > > > > > > The issue can be easily reproduced without Xen too, by adjusting PAT = in > > > Linux: > > > -----8<----- > > > diff --git a/arch/x86/mm/pat/memtype.c b/arch/x86/mm/pat/memtype.c > > > index 66a209f7eb86..319ab60c8d8c 100644 > > > --- a/arch/x86/mm/pat/memtype.c > > > +++ b/arch/x86/mm/pat/memtype.c > > > @@ -400,8 +400,8 @@ void pat_init(void) > > > * The reserved slots are unused, but mapped to their > > > * corresponding types in the presence of PAT errata. > > > */ > > > - pat =3D PAT(0, WB) | PAT(1, WC) | PAT(2, UC_MINUS) | PAT(3, UC) | > > > - PAT(4, WB) | PAT(5, WP) | PAT(6, UC_MINUS) | PAT(7, WT); > > > + pat =3D PAT(0, WB) | PAT(1, WT) | PAT(2, UC_MINUS) | PAT(3, UC) | > > > + PAT(4, WC) | PAT(5, WP) | PAT(6, UC) | PAT(7, UC); > > > } > > > =20 > > > if (!pat_bp_initialized) { > > > -----8<----- > > > > >=20 > > Hello, can anyone help please? > >=20 > > Intel's CI has taken this reproducer of the bug, and confirmed the > > regression.=C2=A0 > > https://lore.kernel.org/intel-gfx/Y5Hst0bCxQDTN7lK@mail-itl/T/#m4480c15= a0d117dce6210562eb542875e757647fb > >=20 > > We're reasonably confident that it is an i915 bug (given the repro with > > no Xen in the mix), but we're out of any further ideas. >=20 > I don't think we have any code that assumes anything about the PAT, > apart from WC being available (which seems like it should still be > the case with your modified PAT). I suppose you'll just have to=20 > start digging from pgprot_writecombine()/noncached() and make sure > everything ends up using the correct PAT entry. I tried several approach to this, without success. Here is an update on debugging (reported also on #intel-gfx live): I did several tests with different PAT configuration (by modifying Xen that sets the MSR). Full table is at https://pad.itl.space/sheet/#/2/sheet/= view/HD1qT2Zf44Ha36TJ3wj2YL+PchsTidyNTFepW5++ZKM/ Some highlights: - 1=3DWC, 4=3DWT - good - 1=3DWT, 4=3DWC - bad - 1=3DWT, 3=3DWC (4=3DWC too) - good - 1=3DWT, 5=3DWC - good So, for me it seems WC at index 4 is problematic for some reason. Next, I tried to trap all the places in arch/x86/xen/mmu_pv.c that write PTEs and verify requested cache attributes. There, it seems all the requested WC are properly translated (using either index 1, 3, 4, or 5 according to PAT settings). And then after reading PTE back, it indeed seems to be correctly set. I didn't added reading back after HYPERVISOR_update_va_mapping, but verified it isn't used for setting WC. Using the same method, I also checked that indexes that aren't supposed to be used (for example index 4 when both 3 and 4 are WC) indeed are not used. So, the hypothesis that specific indexes are hardcoded somewhere is unlikely. This all looks very weird to me. Any ideas? --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --mv1JohAN8Ksm/tl+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmOyFlcACgkQ24/THMrX 1ywfAgf9HICPEpdpOi9mXoYblTrjrO4RH9tA/NauSwf1bRPaDbUtVVvYhCqFJRAA bV1OFtI5TsP6Nq4jJdqMCQO39+BodGJDIeX0+gsFkhvzftL0tbf4+QNSi6jlh0Sx k8kUmMEJRy0wo49DrAg8CemdzV7AdlO6faS3OTWvrGE0bweii/Tj9VwOvzh7KGku lG/5VuTg8pxfx34re6VNKpMMqlviVkfFAkpnBz/clQrlwZJ5hrn6GApc3PmN9BXT 5XbsJOkGPdNbqSHikGIuYcqB6Xaj5adTaMVn3U0hhpLv8EJLv46NRqgk7UP3TOe5 ciqIqp8tvU/ksvdbWObDOVkgzhn8bw== =Krhb -----END PGP SIGNATURE----- --mv1JohAN8Ksm/tl+-- From xen-devel-bounces@lists.xenproject.org Sun Jan 01 23:44:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 01 Jan 2023 23:44:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470173.729613 (Exim 4.92) (envelope-from ) id 1pC80E-0004LM-Jd; Sun, 01 Jan 2023 23:44:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470173.729613; Sun, 01 Jan 2023 23:44:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pC80E-0004LF-Gv; Sun, 01 Jan 2023 23:44:30 +0000 Received: by outflank-mailman (input) for mailman id 470173; Sun, 01 Jan 2023 23:44:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pC80D-0004L0-8t; Sun, 01 Jan 2023 23:44:29 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pC80D-0005rA-42; Sun, 01 Jan 2023 23:44:29 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pC80C-0008J0-OU; Sun, 01 Jan 2023 23:44:28 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pC80C-00069A-O0; Sun, 01 Jan 2023 23:44:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=mmBCoMmO4KdCmFKGY6qOl7bSwXyhWULMUV1Ly7Vhv64=; b=uh68dHggqlTd5rzzXEKraHlvBC Uo/ki57Uup4j6sN54l9FGAuNeDNLqg9IaJUlhSPGbWn+VaLWMiEbWb/BVmGT182kBvnrh+T5zOzVi F+vLHfzO9rmgEGerNHStCFWJ6hMvcG4xF1LIomJ6WBVv/HBzNH84lBdmzY1zEqkLqcwk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 175545: FAIL X-Osstest-Failures: linux-5.4:test-amd64-amd64-xl-qemut-debianhvm-amd64::broken:regression linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64::broken:regression linux-5.4:test-amd64-i386-qemuu-rhel6hvm-intel::broken:regression linux-5.4:test-amd64-amd64-xl-credit2::broken:regression linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:host-install(5):broken:heisenbug linux-5.4:test-amd64-i386-qemuu-rhel6hvm-intel:host-install(5):broken:heisenbug linux-5.4:test-amd64-amd64-xl-credit2:host-install(5):broken:heisenbug linux-5.4:test-amd64-amd64-xl-qemut-debianhvm-amd64:host-install(5):broken:heisenbug linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:heisenbug linux-5.4:test-amd64-i386-pair:xen-install/dst_host:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug linux-5.4:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start.2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=851c2b5fb7936d54e1147f76f88e2675f9f82b52 X-Osstest-Versions-That: linux=66bb2e2b24ce52819a7070d3a3255726cb946b69 From: osstest service owner Date: Sun, 01 Jan 2023 23:44:28 +0000 flight 175545 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/175545/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-debianhvm-amd64 broken in 175407 test-amd64-i386-xl-qemuu-ws16-amd64 broken in 175407 test-amd64-i386-qemuu-rhel6hvm-intel broken in 175407 test-amd64-amd64-xl-credit2 broken in 175407 Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-ws16-amd64 5 host-install(5) broken in 175407 pass in 175545 test-amd64-i386-qemuu-rhel6hvm-intel 5 host-install(5) broken in 175407 pass in 175545 test-amd64-amd64-xl-credit2 5 host-install(5) broken in 175407 pass in 175545 test-amd64-amd64-xl-qemut-debianhvm-amd64 5 host-install(5) broken in 175407 pass in 175545 test-armhf-armhf-xl-multivcpu 14 guest-start fail in 175407 pass in 175545 test-amd64-i386-pair 11 xen-install/dst_host fail in 175543 pass in 175545 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail pass in 175407 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 175543 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail pass in 175543 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail blocked in 175197 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail in 175407 like 175197 test-armhf-armhf-xl-rtds 19 guest-start.2 fail in 175543 blocked in 175197 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 175197 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 175197 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175197 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 175197 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175197 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175197 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 175197 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 175197 test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail like 175197 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 175197 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 175197 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 175197 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175197 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux 851c2b5fb7936d54e1147f76f88e2675f9f82b52 baseline version: linux 66bb2e2b24ce52819a7070d3a3255726cb946b69 Last test of basis 175197 2022-12-14 10:43:17 Z 18 days Testing same since 175407 2022-12-19 11:42:26 Z 13 days 32 attempts ------------------------------------------------------------ People who touched revisions under test: Alexei Starovoitov Andrew Morton Baolin Wang Charles Keepax Florian Fainelli Greg Kroah-Hartman Guenter Roeck Heiko Schocher Hulk Robot Jakub Kicinski Jialiang Wang Jon Hunter Linus Walleij Linux Kernel Functional Testing Lorenzo Colitti Maciej Żenczykowski Marc Kleine-Budde Mark Brown Ming Lei Paul E. McKenney Ricardo Ribalda Samuel Mendoza-Jonas Sasha Levin Shiwei Cui Shuah Khan Simon Horman Sudip Mukherjee Yasushi SHOJI Yasushi SHOJI jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-xl-qemut-debianhvm-amd64 broken broken-job test-amd64-i386-xl-qemuu-ws16-amd64 broken broken-job test-amd64-i386-qemuu-rhel6hvm-intel broken broken-job test-amd64-amd64-xl-credit2 broken Not pushing. (No revision log; it would be 410 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Jan 01 23:52:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 01 Jan 2023 23:52:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470181.729625 (Exim 4.92) (envelope-from ) id 1pC87u-0004zO-CU; Sun, 01 Jan 2023 23:52:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470181.729625; Sun, 01 Jan 2023 23:52:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pC87u-0004zH-9d; Sun, 01 Jan 2023 23:52:26 +0000 Received: by outflank-mailman (input) for mailman id 470181; Sun, 01 Jan 2023 23:52:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pC87s-0004zB-9r for xen-devel@lists.xenproject.org; Sun, 01 Jan 2023 23:52:24 +0000 Received: from sonic309-21.consmr.mail.gq1.yahoo.com (sonic309-21.consmr.mail.gq1.yahoo.com [98.137.65.147]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 539a5eb8-8a2f-11ed-8fd4-01056ac49cbb; Mon, 02 Jan 2023 00:52:20 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic309.consmr.mail.gq1.yahoo.com with HTTP; Sun, 1 Jan 2023 23:52:18 +0000 Received: by hermes--production-bf1-5458f64d4-46wzk (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 0bf49e87fc25c8372e7b6d686a48fa29; Sun, 01 Jan 2023 23:52:15 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 539a5eb8-8a2f-11ed-8fd4-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1672617138; bh=skwhbHUkGjznop/QWhj7GG069Cfw1vyGWz5DAdkodwY=; h=From:To:Cc:Subject:Date:References:From:Subject:Reply-To; b=IEJMj5MNCJUJhzkSMnO2XnVNisG1L6mJlpp0C5gDVnxeviRF0kqvnRwxfJmLj+hC0QFBlbTcbeKhkqEkIp226t/XKrDoSsN3wDu5VrIXb2cUvH5a2Vcwyj8SgX05o06G9WgTnCGWI0B3TzLuSxxZwk5tlLxj2MD8skG8zP1PDa8RCqZpkemmac+B+Wu9oRwhBsYgBuhau0Vw0ts8RUB30xaVWBpukpOAHkMH7iXfYHs9kjWtitKFueQ/8ky0r1vX3pPMPTpu/lVuNMi4J9tT9ePilvZ0qBWVgrn6omTTOXDvowMCx2KPRenG/K1y8Lf/G56IZ06fgbJ16W2s9SgJgw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1672617138; bh=Gm5Qal8G0/XjlI2GzUDH3lY8DeAqXwfGdjCP6FAlAGr=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=MLkLtG3fDe+9QkP7XrKUzDF3W5oo2DKdXEroHJibxjdodo3SkQwi9xe91r3zpalxKtTnTLCsR+r65qUkbkr98KJ8X7z/Ihs3hS4QMmqQgG+QAn6LIQPfJLm0CztXzNlBqnbbyr5A0IPaLjuN/vgxzM5ZZc5oV1ESWBf9bQB3I5j2AcAy7HKX/2yeBZjTE8xJtQNuWk4Moc5uleMlu0icTC6mTuG4L1bQxquvoitgpY3kZb06+ebAmMIInFu6wCY0qK0FU/+NatbUhzO52O5uIdDmHSdc6GhJx+a3Q9arQjH7zgdrMFhrrbg0RHcToW7bso8tZlF6vSAM41le0Ju2tw== X-YMail-OSG: XFe56mIVM1mvJtN9hySqOXDspxB_hs1PSyXIqthm1uK3iEFtNgI8dO.eX7Sh1E. BJ1_4tOtjK7lE71x5m91dWrNder9ITw6LQQNWL1ZRh04Rkz6C9T5ZqdVzBRxGBUO8c9Bq5OBVHaG v1nSCCYiBvXZen7Tv4KLZnEkZQfTBQ56Sk6eauPerh5Qh3wFR8eIJy4VHTPQjKljBFJ1S3.HIvC0 b6s4BfbDPWb5lQOLQ0veeAFWE6MCM9Jd8OTyofW4JOrT4E8yOAOoqwNfGm2sq_29hUFkBE9DYiuy lepBR2MhcdMxJnXb4lJT6.GksxAcUKXabYXr8bzIGIIon6iWsmO9iKcB4pYR_9D_O1Gvkj4ZJRcy cDxMQpvv657LI3SbOKsg3JkWEqkEjqxZvUDH8ZiGK0dXagy4DMkS3vdjlilpNp_nLUiolcyuTKjR Y.MixgwpfhXp_AAumgfU_Wt5_LdAQuY6dz1jmDqz7XFt4y1XAhI39LsesNVCeVjhDT7hAAso5DrZ jThaK6f8.d9wUCLgv91C37kWGpliHOrOhgEDf7NQoC8hpdmTMWxuuQ4YkDTVbHDojewOHVZ6Tidt nUuANYHH1_OODqyUi5XlPs3BWwgt9f50ROmoarNuiVMUTqPhPeBL21V4bNFbNh2Br_bMNezBPGfo iJ.mb7harPCtknUJmAZVDADeOVLSmEhJ7P_cjMha5vUTRID7Z9eNaTY6WYDVG_8mLAC7EM31Betd KBTnqzCuvyBBviOTMg0Ieq3Na_mST1fyuSMFsWOufN2D38tWNjPB8EUZ4Je8JsFfwZ8gMHIcKNFv kJwQFHUd80S7N5SIN3HQ739GVfL1PcYJhkH23wWlQiS6zYglydDMBMNzXkA4aY7KB0oz2mMZok9x xiEnT66vM84_PW8FEFb9mG5eE.ZIYZXSDjG8lktttqJU_cZGuCGracGLXxPAfd6rwvkEh9fQMTDU Q0T2XlpvVv749C1piJ2RvV1uoLbXh5rWDdM8xln.BSf_hl88FPrx8Ro5WYTfU5MNVcT5vJ33dkh3 ARL1pbX12SKD5bCvTfpUqTEEpBP2XF0w34jJ.9__K.7LYyVUv66eh3n3Tqtr3xemxj0CB4bGYNJe LpPmOAvJ3HESwAQxkmjlI0F2VtJIH3vl8vWAhpLvKFJvHUzp9jciS7SZ6HdaMejHVhyEVseJ_A8B ppi9ZzQ5dEgSHrpzptAWizANlnRW8sFB_lNZfKtYIDoWGtqA0d0YFCFtmhQlYmLtdvj1VoWoROeX 2EWeSOGJMCW8HssHVG10qjOo6aVTmbdk6pfrjMJAzDPxDMwyhIev5OwnUpqlttBLrPi5oeDQ_HTA xARzA5.jBSaMan00X944tSUVHqLS_h_Qi0SnVfpTEAfnXTWH6.gRT2DUJVSXWNEo_MRnipuHUzIi PFze2H6K7kSxQIhFbynzFyZqFFHPbl5lWk3Dw703uq9c5z1kMBEAJuPFNDCFw.JiEjBQSdN0pwxH OQNJLL85254cqjFaWLNEzFkbCy1UGOXCsVX3fancVFLTjtR5yjetxo6kEaECVnec4TVSR80ZUMHG JY_t3GYE45lNfss1WXhoGd2etO9YphpQH01cWD4_XyNvFDu0hsyLtSGt._P1XizvV29ldZggSh5d O7hR4CUw3k4mUbXjf8_yEu8ijJfc1cp7UZZNO.3ya4msXawCH3DBAKxlHTkJh.WLSginWznIhOcI UAOnPePzjkVSUjsydCp3iKI51t54.BnU16MbcaR6dPlwIF4KJ91nOD8H4oKqDBDNX5fq8.rDWfzR 2Wxq7NqKa8Mg5i32Kpy_ICSx0qC0w0WJkkQDx59YmEiF7Zv0KsSjCJCUTn55VDmvV2Bk7dhhwuLE _AB6CseM_XTMQc65VW213Z8kD_6FD7ehL_00xRmHyWG6ejN.AqbKiucoRuprKE4fqbcGk0EWskfQ DYa8EqRUdEu1r9aXvjauffxqzHIp.OH9VzYQeFP8Ub7I_qKK_69Z74XKm_8HYjacNW8l8aSSKXaG P9TyD90AxMZkzfkRRbhyS7uyxQXuj_44oeTnkt7feAv_CopWlh8TzDqe05DUl4dD5G2An16DHqE0 M_tVkAgDQ4MdWGLGjsbRNWCGUI46gXip2VrPMSirQpEU9Ggrkk8k2OZQGSCGd7b4342UFBG3R.xk DnEkFEFc1s3sfbz1tc20FUwoa6AMmpMV3REHRpT6towzQjbYC_E8w0KE4fEcz.W2cTrtHROSK.db VoKP19swTfj0- X-Sonic-MF: From: Chuck Zmudzinski To: qemu-devel@nongnu.org Cc: Stefano Stabellini , Anthony Perard , Paul Durrant , Paolo Bonzini , Richard Henderson , Eduardo Habkost , "Michael S. Tsirkin" , Marcel Apfelbaum , xen-devel@lists.xenproject.org Subject: [PATCH v6] xen/pt: reserve PCI slot 2 for Intel igd-passthru Date: Sun, 1 Jan 2023 18:52:03 -0500 Message-Id: <830263507e8f1a24a94f81909d5102c4b204e938.1672615492.git.brchuckz@aol.com> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit References: <830263507e8f1a24a94f81909d5102c4b204e938.1672615492.git.brchuckz.ref@aol.com> Content-Length: 10912 Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, as noted in docs/igd-assign.txt in the Qemu source code. Currently, when the xl toolstack is used to configure a Xen HVM guest with Intel IGD passthrough to the guest with the Qemu upstream device model, a Qemu emulated PCI device will occupy slot 2 and the Intel IGD will occupy a different slot. This problem often prevents the guest from booting. The only available workaround is not good: Configure Xen HVM guests to use the old and no longer maintained Qemu traditional device model available from xenbits.xen.org which does reserve slot 2 for the Intel IGD. To implement this feature in the Qemu upstream device model for Xen HVM guests, introduce the following new functions, types, and macros: * XEN_PT_DEVICE_CLASS declaration, based on the existing TYPE_XEN_PT_DEVICE * XEN_PT_DEVICE_GET_CLASS macro helper function for XEN_PT_DEVICE_CLASS * typedef XenPTQdevRealize function pointer * XEN_PCI_IGD_SLOT_MASK, the value of slot_reserved_mask to reserve slot 2 * xen_igd_reserve_slot and xen_igd_clear_slot functions The new xen_igd_reserve_slot function uses the existing slot_reserved_mask member of PCIBus to reserve PCI slot 2 for Xen HVM guests configured using the xl toolstack with the gfx_passthru option enabled, which sets the igd-passthru=on option to Qemu for the Xen HVM machine type. The new xen_igd_reserve_slot function also needs to be implemented in hw/xen/xen_pt_stub.c to prevent FTBFS during the link stage for the case when Qemu is configured with --enable-xen and --disable-xen-pci-passthrough, in which case it does nothing. The new xen_igd_clear_slot function overrides qdev->realize of the parent PCI device class to enable the Intel IGD to occupy slot 2 on the PCI bus since slot 2 was reserved by xen_igd_reserve_slot when the PCI bus was created in hw/i386/pc_piix.c for the case when igd-passthru=on. Move the call to xen_host_pci_device_get, and the associated error handling, from xen_pt_realize to the new xen_igd_clear_slot function to initialize the device class and vendor values which enables the checks for the Intel IGD to succeed. The verification that the host device is an Intel IGD to be passed through is done by checking the domain, bus, slot, and function values as well as by checking that gfx_passthru is enabled, the device class is VGA, and the device vendor in Intel. Signed-off-by: Chuck Zmudzinski --- Notes that might be helpful to reviewers of patched code in hw/xen: The new functions and types are based on recommendations from Qemu docs: https://qemu.readthedocs.io/en/latest/devel/qom.html Notes that might be helpful to reviewers of patched code in hw/i386: The small patch to hw/i386/pc_piix.c is protected by CONFIG_XEN so it does not affect builds that do not have CONFIG_XEN defined. xen_igd_gfx_pt_enabled() in the patched hw/i386/pc_piix.c file is an existing function that is only true when Qemu is built with xen-pci-passthrough enabled and the administrator has configured the Xen HVM guest with Qemu's igd-passthru=on option. v2: Remove From: tag at top of commit message v3: Changed the test for the Intel IGD in xen_igd_clear_slot: if (is_igd_vga_passthrough(&s->real_device) && (s->real_device.vendor_id == PCI_VENDOR_ID_INTEL)) { is changed to if (xen_igd_gfx_pt_enabled() && (s->hostaddr.slot == 2) && (s->hostaddr.function == 0)) { I hoped that I could use the test in v2, since it matches the other tests for the Intel IGD in Qemu and Xen, but those tests do not work because the necessary data structures are not set with their values yet. So instead use the test that the administrator has enabled gfx_passthru and the device address on the host is 02.0. This test does detect the Intel IGD correctly. v4: Use brchuckz@aol.com instead of brchuckz@netscape.net for the author's email address to match the address used by the same author in commits be9c61da and c0e86b76 Change variable for XEN_PT_DEVICE_CLASS: xptc changed to xpdc v5: The patch of xen_pt.c was re-worked to allow a more consistent test for the Intel IGD that uses the same criteria as in other places. This involved moving the call to xen_host_pci_device_get from xen_pt_realize to xen_igd_clear_slot and updating the checks for the Intel IGD in xen_igd_clear_slot: if (xen_igd_gfx_pt_enabled() && (s->hostaddr.slot == 2) && (s->hostaddr.function == 0)) { is changed to if (is_igd_vga_passthrough(&s->real_device) && s->real_device.domain == 0 && s->real_device.bus == 0 && s->real_device.dev == 2 && s->real_device.func == 0 && s->real_device.vendor_id == PCI_VENDOR_ID_INTEL) { Added an explanation for the move of xen_host_pci_device_get from xen_pt_realize to xen_igd_clear_slot to the commit message. Rebase. v6: Fix logging by removing these lines from the move from xen_pt_realize to xen_igd_clear_slot that was done in v5: XEN_PT_LOG(d, "Assigning real physical device %02x:%02x.%d" " to devfn 0x%x\n", s->hostaddr.bus, s->hostaddr.slot, s->hostaddr.function, s->dev.devfn); This log needs to be in xen_pt_realize because s->dev.devfn is not set yet in xen_igd_clear_slot. Sorry for the extra noise. hw/i386/pc_piix.c | 3 +++ hw/xen/xen_pt.c | 46 +++++++++++++++++++++++++++++++++++--------- hw/xen/xen_pt.h | 16 +++++++++++++++ hw/xen/xen_pt_stub.c | 4 ++++ 4 files changed, 60 insertions(+), 9 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index b48047f50c..bc5efa4f59 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -405,6 +405,9 @@ static void pc_xen_hvm_init(MachineState *machine) } pc_xen_hvm_init_pci(machine); + if (xen_igd_gfx_pt_enabled()) { + xen_igd_reserve_slot(pcms->bus); + } pci_create_simple(pcms->bus, -1, "xen-platform"); } #endif diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c index 0ec7e52183..7fae1e7a6f 100644 --- a/hw/xen/xen_pt.c +++ b/hw/xen/xen_pt.c @@ -780,15 +780,6 @@ static void xen_pt_realize(PCIDevice *d, Error **errp) s->hostaddr.bus, s->hostaddr.slot, s->hostaddr.function, s->dev.devfn); - xen_host_pci_device_get(&s->real_device, - s->hostaddr.domain, s->hostaddr.bus, - s->hostaddr.slot, s->hostaddr.function, - errp); - if (*errp) { - error_append_hint(errp, "Failed to \"open\" the real pci device"); - return; - } - s->is_virtfn = s->real_device.is_virtfn; if (s->is_virtfn) { XEN_PT_LOG(d, "%04x:%02x:%02x.%d is a SR-IOV Virtual Function\n", @@ -950,11 +941,47 @@ static void xen_pci_passthrough_instance_init(Object *obj) PCI_DEVICE(obj)->cap_present |= QEMU_PCI_CAP_EXPRESS; } +void xen_igd_reserve_slot(PCIBus *pci_bus) +{ + XEN_PT_LOG(0, "Reserving PCI slot 2 for IGD\n"); + pci_bus->slot_reserved_mask |= XEN_PCI_IGD_SLOT_MASK; +} + +static void xen_igd_clear_slot(DeviceState *qdev, Error **errp) +{ + ERRP_GUARD(); + PCIDevice *pci_dev = (PCIDevice *)qdev; + XenPCIPassthroughState *s = XEN_PT_DEVICE(pci_dev); + XenPTDeviceClass *xpdc = XEN_PT_DEVICE_GET_CLASS(s); + PCIBus *pci_bus = pci_get_bus(pci_dev); + + xen_host_pci_device_get(&s->real_device, + s->hostaddr.domain, s->hostaddr.bus, + s->hostaddr.slot, s->hostaddr.function, + errp); + if (*errp) { + error_append_hint(errp, "Failed to \"open\" the real pci device"); + return; + } + + if (is_igd_vga_passthrough(&s->real_device) && + s->real_device.domain == 0 && s->real_device.bus == 0 && + s->real_device.dev == 2 && s->real_device.func == 0 && + s->real_device.vendor_id == PCI_VENDOR_ID_INTEL) { + pci_bus->slot_reserved_mask &= ~XEN_PCI_IGD_SLOT_MASK; + XEN_PT_LOG(pci_dev, "Intel IGD found, using slot 2\n"); + } + xpdc->pci_qdev_realize(qdev, errp); +} + static void xen_pci_passthrough_class_init(ObjectClass *klass, void *data) { DeviceClass *dc = DEVICE_CLASS(klass); PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); + XenPTDeviceClass *xpdc = XEN_PT_DEVICE_CLASS(klass); + xpdc->pci_qdev_realize = dc->realize; + dc->realize = xen_igd_clear_slot; k->realize = xen_pt_realize; k->exit = xen_pt_unregister_device; k->config_read = xen_pt_pci_read_config; @@ -977,6 +1004,7 @@ static const TypeInfo xen_pci_passthrough_info = { .instance_size = sizeof(XenPCIPassthroughState), .instance_finalize = xen_pci_passthrough_finalize, .class_init = xen_pci_passthrough_class_init, + .class_size = sizeof(XenPTDeviceClass), .instance_init = xen_pci_passthrough_instance_init, .interfaces = (InterfaceInfo[]) { { INTERFACE_CONVENTIONAL_PCI_DEVICE }, diff --git a/hw/xen/xen_pt.h b/hw/xen/xen_pt.h index e7c4316a7d..40b31b5263 100644 --- a/hw/xen/xen_pt.h +++ b/hw/xen/xen_pt.h @@ -3,6 +3,7 @@ #include "hw/xen/xen_common.h" #include "hw/pci/pci.h" +#include "hw/pci/pci_bus.h" #include "xen-host-pci-device.h" #include "qom/object.h" @@ -41,7 +42,20 @@ typedef struct XenPTReg XenPTReg; #define TYPE_XEN_PT_DEVICE "xen-pci-passthrough" OBJECT_DECLARE_SIMPLE_TYPE(XenPCIPassthroughState, XEN_PT_DEVICE) +#define XEN_PT_DEVICE_CLASS(klass) \ + OBJECT_CLASS_CHECK(XenPTDeviceClass, klass, TYPE_XEN_PT_DEVICE) +#define XEN_PT_DEVICE_GET_CLASS(obj) \ + OBJECT_GET_CLASS(XenPTDeviceClass, obj, TYPE_XEN_PT_DEVICE) + +typedef void (*XenPTQdevRealize)(DeviceState *qdev, Error **errp); + +typedef struct XenPTDeviceClass { + PCIDeviceClass parent_class; + XenPTQdevRealize pci_qdev_realize; +} XenPTDeviceClass; + uint32_t igd_read_opregion(XenPCIPassthroughState *s); +void xen_igd_reserve_slot(PCIBus *pci_bus); void igd_write_opregion(XenPCIPassthroughState *s, uint32_t val); void xen_igd_passthrough_isa_bridge_create(XenPCIPassthroughState *s, XenHostPCIDevice *dev); @@ -76,6 +90,8 @@ typedef int (*xen_pt_conf_byte_read) #define XEN_PCI_INTEL_OPREGION 0xfc +#define XEN_PCI_IGD_SLOT_MASK 0x4UL /* Intel IGD slot_reserved_mask */ + typedef enum { XEN_PT_GRP_TYPE_HARDWIRED = 0, /* 0 Hardwired reg group */ XEN_PT_GRP_TYPE_EMU, /* emul reg group */ diff --git a/hw/xen/xen_pt_stub.c b/hw/xen/xen_pt_stub.c index 2d8cac8d54..5c108446a8 100644 --- a/hw/xen/xen_pt_stub.c +++ b/hw/xen/xen_pt_stub.c @@ -20,3 +20,7 @@ void xen_igd_gfx_pt_set(bool value, Error **errp) error_setg(errp, "Xen PCI passthrough support not built in"); } } + +void xen_igd_reserve_slot(PCIBus *pci_bus) +{ +} -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Mon Jan 02 00:03:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 Jan 2023 00:03:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470191.729635 (Exim 4.92) (envelope-from ) id 1pC8Ij-0007AP-DL; Mon, 02 Jan 2023 00:03:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470191.729635; Mon, 02 Jan 2023 00:03:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pC8Ij-0007AI-Af; Mon, 02 Jan 2023 00:03:37 +0000 Received: by outflank-mailman (input) for mailman id 470191; Mon, 02 Jan 2023 00:03:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pC8Ih-0007A8-0L for xen-devel@lists.xenproject.org; Mon, 02 Jan 2023 00:03:35 +0000 Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e33489e9-8a30-11ed-91b6-6bf2151ebd3b; Mon, 02 Jan 2023 01:03:31 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 5C91D32002E2; Sun, 1 Jan 2023 19:03:27 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Sun, 01 Jan 2023 19:03:28 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 1 Jan 2023 19:03:25 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e33489e9-8a30-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1672617806; x= 1672704206; bh=QWrm808uO4klYg+6e3E8cUIIB4tFpjr8qW51PGfU32Y=; b=e bxkn2aTRgu0l59e/6Oqdv6szPiRBO/78w1Dd4UOM6PIZweGRHIQxl4jxuAEh4G6q h6WKeYhEXx87JPUVPW70MDZ6MwXxkpK+cuxYVvN3ErWXuGdRht8aF685LcKKPPBO WtDrSlUn4NsjCl9UEVbnzK0ZKaAY5uItq8Cdir1wNZHYOK/tksh3Z49iWoi7kcCQ srPNIJwKhcIkabtF9ru1pOXZFefD4udHeEzUR7XX582gDCYYtilPY/enYOq3ggv7 o+HRBvoaMmj5/r9aPSre1itLobIx45f+lbvYduihtnHb4btv9PmKJ6S34Qdn1RW7 NHVHx/ijWKZwAMtvmh1yA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1672617806; x=1672704206; bh=QWrm808uO4klYg+6e3E8cUIIB4tF pjr8qW51PGfU32Y=; b=GrJqyVNBo1kfGOBnftWq0Fy4NW/bcBSZWe32fh0zB0Ld +5mj0k1EGOF19qyj8UPEY1Rt3JJADs6bsVlxdSK9EbmuoI2F19fLtg85bbmld1nV ifXciu1X8CJzp4XhovimjUUvRIktBAHyZ0UzYGvp/Ev6vNjT2MvXIFVhwHZwv/+d GAo06YHHudENWVehkLtBIBzInPdWVN5CO0nrEQWuKFQjKsmF3/3kWNi83/USi1LN 5nfldfLSwVpbRVk+6fRZVfdKINXxVh6xWz8Ln5HT8ONiyyx0mxv+3AwJ27UZpmQ4 Ll5LGd83t3GNvd26+2pbr8q33VyCWkq7D/H6Yx9F1g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrjedugdduhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeffvghmihcu ofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinhhgsh hlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeetleffvdehleeffeffudffvedutdev geffvdffkeevfeevkefhjeegleduteffjeenucffohhmrghinhepqhhusggvshdqohhsrd horhhgpdhgihhthhhusgdrtghomhdpkhgvrhhnvghlrdhorhhgpdhithhlrdhsphgrtggv necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepuggvmh hisehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Sun, 1 Jan 2023 19:03:18 -0500 From: Demi Marie Obenour To: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , Ville =?utf-8?B?U3lyasOkbMOk?= Cc: Andrew Cooper , "intel-gfx@lists.freedesktop.org" , the arch/x86 maintainers , Lucas De Marchi , Daniel Vetter , Rodrigo Vivi , xen-devel Subject: Re: [Intel-gfx] [cache coherency bug] i915 and PAT attributes Message-ID: References: <1c326e0c-5812-083a-0739-aa20fab3efc4@citrix.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="sna7pTQbM0Qkvz+e" Content-Disposition: inline In-Reply-To: --sna7pTQbM0Qkvz+e Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Sun, 1 Jan 2023 19:03:18 -0500 From: Demi Marie Obenour To: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , Ville =?utf-8?B?U3lyasOkbMOk?= Cc: Andrew Cooper , "intel-gfx@lists.freedesktop.org" , the arch/x86 maintainers , Lucas De Marchi , Daniel Vetter , Rodrigo Vivi , xen-devel Subject: Re: [Intel-gfx] [cache coherency bug] i915 and PAT attributes On Mon, Jan 02, 2023 at 12:24:54AM +0100, Marek Marczykowski-G=C3=B3recki w= rote: > On Thu, Dec 22, 2022 at 10:29:57AM +0200, Ville Syrj=C3=A4l=C3=A4 wrote: > > On Fri, Dec 16, 2022 at 03:30:13PM +0000, Andrew Cooper wrote: > > > On 08/12/2022 1:55 pm, Marek Marczykowski-G=C3=B3recki wrote: > > > > Hi, > > > > > > > > There is an issue with i915 on Xen PV (dom0). The end result is a l= ot of > > > > glitches, like here: https://openqa.qubes-os.org/tests/54748#step/s= tartup/8 > > > > (this one is on ADL, Linux 6.1-rc7 as a Xen PV dom0). It's using Xo= rg > > > > with "modesetting" driver. > > > > > > > > After some iterations of debugging, we narrowed it down to i915 han= dling > > > > caching. The main difference is that PAT is setup differently on Xe= n PV > > > > than on native Linux. Normally, Linux does have appropriate abstrac= tion > > > > for that, but apparently something related to i915 doesn't play well > > > > with it. The specific difference is: > > > > native linux: > > > > x86/PAT: Configuration [0-7]: WB WC UC- UC WB WP UC- WT > > > > xen pv: > > > > x86/PAT: Configuration [0-7]: WB WT UC- UC WC WP UC UC > > > > ~~ ~~ ~~ ~~ > > > > > > > > The specific impact depends on kernel version and the hardware. The= most > > > > severe issues I see on >=3DADL, but some older hardware is affected= too - > > > > sometimes only if composition is disabled in the window manager. > > > > Some more information is collected at > > > > https://github.com/QubesOS/qubes-issues/issues/4782 (and few linked > > > > duplicates...). > > > > > > > > Kind-of related commit is here: > > > > https://github.com/torvalds/linux/commit/bdd8b6c98239cad ("drm/i915: > > > > replace X86_FEATURE_PAT with pat_enabled()") - it is the place where > > > > i915 explicitly checks for PAT support, so I'm cc-ing people mentio= ned > > > > there too. > > > > > > > > Any ideas? > > > > > > > > The issue can be easily reproduced without Xen too, by adjusting PA= T in > > > > Linux: > > > > -----8<----- > > > > diff --git a/arch/x86/mm/pat/memtype.c b/arch/x86/mm/pat/memtype.c > > > > index 66a209f7eb86..319ab60c8d8c 100644 > > > > --- a/arch/x86/mm/pat/memtype.c > > > > +++ b/arch/x86/mm/pat/memtype.c > > > > @@ -400,8 +400,8 @@ void pat_init(void) > > > > * The reserved slots are unused, but mapped to their > > > > * corresponding types in the presence of PAT errata. > > > > */ > > > > - pat =3D PAT(0, WB) | PAT(1, WC) | PAT(2, UC_MINUS) | PAT(3, UC) | > > > > - PAT(4, WB) | PAT(5, WP) | PAT(6, UC_MINUS) | PAT(7, WT); > > > > + pat =3D PAT(0, WB) | PAT(1, WT) | PAT(2, UC_MINUS) | PAT(3, UC) | > > > > + PAT(4, WC) | PAT(5, WP) | PAT(6, UC) | PAT(7, UC); > > > > } > > > > =20 > > > > if (!pat_bp_initialized) { > > > > -----8<----- > > > > > > >=20 > > > Hello, can anyone help please? > > >=20 > > > Intel's CI has taken this reproducer of the bug, and confirmed the > > > regression.=C2=A0 > > > https://lore.kernel.org/intel-gfx/Y5Hst0bCxQDTN7lK@mail-itl/T/#m4480c= 15a0d117dce6210562eb542875e757647fb > > >=20 > > > We're reasonably confident that it is an i915 bug (given the repro wi= th > > > no Xen in the mix), but we're out of any further ideas. > >=20 > > I don't think we have any code that assumes anything about the PAT, > > apart from WC being available (which seems like it should still be > > the case with your modified PAT). I suppose you'll just have to=20 > > start digging from pgprot_writecombine()/noncached() and make sure > > everything ends up using the correct PAT entry. >=20 > I tried several approach to this, without success. Here is an update on > debugging (reported also on #intel-gfx live): >=20 > I did several tests with different PAT configuration (by modifying Xen > that sets the MSR). Full table is at https://pad.itl.space/sheet/#/2/shee= t/view/HD1qT2Zf44Ha36TJ3wj2YL+PchsTidyNTFepW5++ZKM/ > Some highlights: > - 1=3DWC, 4=3DWT - good > - 1=3DWT, 4=3DWC - bad > - 1=3DWT, 3=3DWC (4=3DWC too) - good > - 1=3DWT, 5=3DWC - good >=20 > So, for me it seems WC at index 4 is problematic for some reason. >=20 > Next, I tried to trap all the places in arch/x86/xen/mmu_pv.c that > write PTEs and verify requested cache attributes. There, it seems all > the requested WC are properly translated (using either index 1, 3, 4, or > 5 according to PAT settings). And then after reading PTE back, it indeed > seems to be correctly set. I didn't added reading back after > HYPERVISOR_update_va_mapping, but verified it isn't used for setting WC. >=20 > Using the same method, I also checked that indexes that aren't supposed > to be used (for example index 4 when both 3 and 4 are WC) indeed are not > used. So, the hypothesis that specific indexes are hardcoded somewhere > is unlikely. >=20 > This all looks very weird to me. Any ideas? Old CPUs have had hardware errata that caused the top bit of the PAT entry to be ignored in certain cases. Could modern CPUs be ignoring this bit when accessing iGPU memory or registers? With WC at position 4, this would cause WC to be treated as WB, which is consistent with the observed behavior. WC at position 3 would not be impacted, and WC at position 5 would be treated as WT which I expect to be safe. One way to test this is to test 1=3DWB, 5=3DWC. If my hypothesis is correct, this should trigger the bug, even if entry 1 in the PAT is unused because entry 0 is also WB. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --sna7pTQbM0Qkvz+e Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmOyH0sACgkQsoi1X/+c IsHkExAAwPBiEG7fU2iXwJT+pGOCsgqm0InTt1WC6YwaJi/6s/0qVqm5KZx/mN2/ x/So26ifOHDD/FMfsBGbfodobx7dvLsQwujMiOWgS03p7rh9C3kyT93rlx47y4U6 QSM5JQzkiM0I/7cQw3HTYTG0bUbIIzRPN856pW/7arGXTtOmFWaqKWxPnB8fqNe1 dmpjK5Zz+MCvayA8gUvvIaQ9aFbC7k40BA/7uCKga7T3acyUAfRCVFd0+0nAnfRP hEDjlQjejLsuaKT2eLYZdweiHJZtOhYoRg8DFzam+BQaNIslI9HRZ8x3cIi+6UYQ 2oR+hTKCtgUQPd9q2aQUWMeq9BXNzfQyUTWw+Vn7fXc7awe4j7bYAfIVV6nXlk6W 6qFqHUlTcjYmmG17484RL/dHWkJPE+B3beuo8kSvXqHoyXp9z18kLLcCJocN1gkX n4TjWU7TSuOg68kwVruWsg1uOznzZTIktLw83zPmAFYJiIh83eE+yEwttCD4pogf A9oE/jMqdhoEuyZBjE3Ru8/YXoEk/h7if9wGvBUU58/jATGDMuOtbk90zptVqtcl IEeoVqLBBe5zDNW1YBlL6EpP4xfTRXbQ+diRUU2J0UhVLmMF0hGYxAPLgsUFpuE+ CtXH/JDlIUWU3up7t6yedp74exPvS5PWExWh7GJ7bGxn38G3Zk8= =7ciq -----END PGP SIGNATURE----- --sna7pTQbM0Qkvz+e-- From xen-devel-bounces@lists.xenproject.org Mon Jan 02 01:01:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 Jan 2023 01:01:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470200.729647 (Exim 4.92) (envelope-from ) id 1pC9CG-0001mP-9R; Mon, 02 Jan 2023 01:01:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470200.729647; Mon, 02 Jan 2023 01:01:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pC9CG-0001lr-6f; Mon, 02 Jan 2023 01:01:00 +0000 Received: by outflank-mailman (input) for mailman id 470200; Mon, 02 Jan 2023 01:00:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pC9CF-0001Kp-J6 for xen-devel@lists.xenproject.org; Mon, 02 Jan 2023 01:00:59 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ea054943-8a38-11ed-91b6-6bf2151ebd3b; Mon, 02 Jan 2023 02:00:57 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 5AEBF5C009C; Sun, 1 Jan 2023 20:00:56 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sun, 01 Jan 2023 20:00:56 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 1 Jan 2023 20:00:53 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ea054943-8a38-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1672621256; x= 1672707656; bh=Vkd82xk0hwXjNxZx3kuGm8JTwE53wz2kGurdp3zIabA=; b=N bWv9dVghzrn5CzYjEZ2XHjk0LiN0KaMCPktk5F+y/BdYX+CedrW8476kTChm1VRU Bb+9pQ1RwPuBT0PJiRBLpheheynP9VT059+SRlEnG7qTk7vKmBv5HdKcm8wNfZK9 puwYeGPARBbm4T1Eq+MAyXniln5vFBArd+B58ZYhpdL/nzC1RbWBlGA2VUFekdFh Iogn4XHThGCF6DjYNKCbhe/Z5rE8M9/h213Zy7rUiVihpkO/zf0qehbu+BfBRnGw MflvQTrnMc6XAaEpGp9bNw53EqbV+A2+GIO4o7nj4+Xfc/uBW16Rm2xAVsjAcWKg csaWTC/jLdRnUtQBi63Rw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1672621256; x=1672707656; bh=Vkd82xk0hwXjNxZx3kuGm8JTwE53 wz2kGurdp3zIabA=; b=JIN4Paay5P/9fIVjA2E0OUWwcjj6sD5INPL8kYNmTuND bbADh1ig1kYqiQFeUS1ovTYHryEatSx4lxOEaMFl+ZvTrG0vcha8LmtoNsYrxI9Y BbKxCEi28nS1aIik/hXqu3hc/JHgLqO9V7993fQGWAXbDqz0EKgqWG9NIsY+HUIR yraTCVbyVq1TdW1C32ACl+hetr4MEJe1fj0BE419rCgujN7naaDdIi/4SF87EMRI yTTmskVhlg1ziO22ElBcLrC7RhtJV51miwr/tlYoKvkNmo7KjhhKHbrtwOpn6NzQ BaL6SjoYnlpVkigFkdQ8YCv8wy7oSldEGXggmAC01A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrjedugddvkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeeliedu tdfggfekuefhhedtfeevhfetgfdtvdeujeeuteevtdeutdegffeguedufeenucffohhmrg hinhepqhhusggvshdqohhsrdhorhhgpdhgihhthhhusgdrtghomhdpkhgvrhhnvghlrdho rhhgpdhithhlrdhsphgrtggvnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomhepmhgrrhhmrghrvghksehinhhvihhsihgslhgvthhhihhnghhslhgr sgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Mon, 2 Jan 2023 02:00:51 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Demi Marie Obenour Cc: Ville =?utf-8?B?U3lyasOkbMOk?= , Andrew Cooper , "intel-gfx@lists.freedesktop.org" , the arch/x86 maintainers , Lucas De Marchi , Daniel Vetter , Rodrigo Vivi , xen-devel Subject: Re: [Intel-gfx] [cache coherency bug] i915 and PAT attributes Message-ID: References: <1c326e0c-5812-083a-0739-aa20fab3efc4@citrix.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ZRMbSRxQJ79m73FE" Content-Disposition: inline In-Reply-To: --ZRMbSRxQJ79m73FE Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Mon, 2 Jan 2023 02:00:51 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Demi Marie Obenour Cc: Ville =?utf-8?B?U3lyasOkbMOk?= , Andrew Cooper , "intel-gfx@lists.freedesktop.org" , the arch/x86 maintainers , Lucas De Marchi , Daniel Vetter , Rodrigo Vivi , xen-devel Subject: Re: [Intel-gfx] [cache coherency bug] i915 and PAT attributes On Sun, Jan 01, 2023 at 07:03:18PM -0500, Demi Marie Obenour wrote: > On Mon, Jan 02, 2023 at 12:24:54AM +0100, Marek Marczykowski-G=C3=B3recki= wrote: > > On Thu, Dec 22, 2022 at 10:29:57AM +0200, Ville Syrj=C3=A4l=C3=A4 wrote: > > > On Fri, Dec 16, 2022 at 03:30:13PM +0000, Andrew Cooper wrote: > > > > On 08/12/2022 1:55 pm, Marek Marczykowski-G=C3=B3recki wrote: > > > > > Hi, > > > > > > > > > > There is an issue with i915 on Xen PV (dom0). The end result is a= lot of > > > > > glitches, like here: https://openqa.qubes-os.org/tests/54748#step= /startup/8 > > > > > (this one is on ADL, Linux 6.1-rc7 as a Xen PV dom0). It's using = Xorg > > > > > with "modesetting" driver. > > > > > > > > > > After some iterations of debugging, we narrowed it down to i915 h= andling > > > > > caching. The main difference is that PAT is setup differently on = Xen PV > > > > > than on native Linux. Normally, Linux does have appropriate abstr= action > > > > > for that, but apparently something related to i915 doesn't play w= ell > > > > > with it. The specific difference is: > > > > > native linux: > > > > > x86/PAT: Configuration [0-7]: WB WC UC- UC WB WP UC- WT > > > > > xen pv: > > > > > x86/PAT: Configuration [0-7]: WB WT UC- UC WC WP UC UC > > > > > ~~ ~~ ~~ ~~ > > > > > > > > > > The specific impact depends on kernel version and the hardware. T= he most > > > > > severe issues I see on >=3DADL, but some older hardware is affect= ed too - > > > > > sometimes only if composition is disabled in the window manager. > > > > > Some more information is collected at > > > > > https://github.com/QubesOS/qubes-issues/issues/4782 (and few link= ed > > > > > duplicates...). > > > > > > > > > > Kind-of related commit is here: > > > > > https://github.com/torvalds/linux/commit/bdd8b6c98239cad ("drm/i9= 15: > > > > > replace X86_FEATURE_PAT with pat_enabled()") - it is the place wh= ere > > > > > i915 explicitly checks for PAT support, so I'm cc-ing people ment= ioned > > > > > there too. > > > > > > > > > > Any ideas? > > > > > > > > > > The issue can be easily reproduced without Xen too, by adjusting = PAT in > > > > > Linux: > > > > > -----8<----- > > > > > diff --git a/arch/x86/mm/pat/memtype.c b/arch/x86/mm/pat/memtype.c > > > > > index 66a209f7eb86..319ab60c8d8c 100644 > > > > > --- a/arch/x86/mm/pat/memtype.c > > > > > +++ b/arch/x86/mm/pat/memtype.c > > > > > @@ -400,8 +400,8 @@ void pat_init(void) > > > > > * The reserved slots are unused, but mapped to their > > > > > * corresponding types in the presence of PAT errata. > > > > > */ > > > > > - pat =3D PAT(0, WB) | PAT(1, WC) | PAT(2, UC_MINUS) | PAT(3, UC= ) | > > > > > - PAT(4, WB) | PAT(5, WP) | PAT(6, UC_MINUS) | PAT(7, WT); > > > > > + pat =3D PAT(0, WB) | PAT(1, WT) | PAT(2, UC_MINUS) | PAT(3, UC= ) | > > > > > + PAT(4, WC) | PAT(5, WP) | PAT(6, UC) | PAT(7, UC); > > > > > } > > > > > =20 > > > > > if (!pat_bp_initialized) { > > > > > -----8<----- > > > > > > > > >=20 > > > > Hello, can anyone help please? > > > >=20 > > > > Intel's CI has taken this reproducer of the bug, and confirmed the > > > > regression.=C2=A0 > > > > https://lore.kernel.org/intel-gfx/Y5Hst0bCxQDTN7lK@mail-itl/T/#m448= 0c15a0d117dce6210562eb542875e757647fb > > > >=20 > > > > We're reasonably confident that it is an i915 bug (given the repro = with > > > > no Xen in the mix), but we're out of any further ideas. > > >=20 > > > I don't think we have any code that assumes anything about the PAT, > > > apart from WC being available (which seems like it should still be > > > the case with your modified PAT). I suppose you'll just have to=20 > > > start digging from pgprot_writecombine()/noncached() and make sure > > > everything ends up using the correct PAT entry. > >=20 > > I tried several approach to this, without success. Here is an update on > > debugging (reported also on #intel-gfx live): > >=20 > > I did several tests with different PAT configuration (by modifying Xen > > that sets the MSR). Full table is at https://pad.itl.space/sheet/#/2/sh= eet/view/HD1qT2Zf44Ha36TJ3wj2YL+PchsTidyNTFepW5++ZKM/ > > Some highlights: > > - 1=3DWC, 4=3DWT - good > > - 1=3DWT, 4=3DWC - bad > > - 1=3DWT, 3=3DWC (4=3DWC too) - good > > - 1=3DWT, 5=3DWC - good > >=20 > > So, for me it seems WC at index 4 is problematic for some reason. > >=20 > > Next, I tried to trap all the places in arch/x86/xen/mmu_pv.c that > > write PTEs and verify requested cache attributes. There, it seems all > > the requested WC are properly translated (using either index 1, 3, 4, or > > 5 according to PAT settings). And then after reading PTE back, it indeed > > seems to be correctly set. I didn't added reading back after > > HYPERVISOR_update_va_mapping, but verified it isn't used for setting WC. > >=20 > > Using the same method, I also checked that indexes that aren't supposed > > to be used (for example index 4 when both 3 and 4 are WC) indeed are not > > used. So, the hypothesis that specific indexes are hardcoded somewhere > > is unlikely. > >=20 > > This all looks very weird to me. Any ideas? >=20 > Old CPUs have had hardware errata that caused the top bit of the PAT > entry to be ignored in certain cases. Could modern CPUs be ignoring > this bit when accessing iGPU memory or registers? With WC at position > 4, this would cause WC to be treated as WB, which is consistent with the > observed behavior. WC at position 3 would not be impacted, and WC at > position 5 would be treated as WT which I expect to be safe. One way to > test this is to test 1=3DWB, 5=3DWC. If my hypothesis is correct, this > should trigger the bug, even if entry 1 in the PAT is unused because > entry 0 is also WB. This looks like a very probable situation, indeed 1=3DWB, 5=3DWC does trigger the bug! Specifically this layout: WB WB UC- UC WP WC WT UC --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --ZRMbSRxQJ79m73FE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmOyLMMACgkQ24/THMrX 1yzksAf+LbWU8vxaEkf4STfhncM6CbXghzbFswKWaKDltJdvfXQ20ZmeXTb3nWLe Mi2+HcNdl2niQVEgZB+qXyp5AJIhnTIhsF5X+zvh3a1MQsOtILZx2wwCDqbXezTv 9OQ55kx2z3ujhAgIme/pxQOQRZWum9+luspCL7lNJFRwwBdhSE1eQAHGqaHsBdtr ytPO6ZODN5Fb7q5aCZ4WNzsKFQ2wsROzmVO14opSpyE2YgaKFjQfTpevhin/gnYz pGkuDWRFGURry8WJcwhpI6e009Gf8Kz7rt7+oW0z+IxxT3zS1q2x+xZ2vY6+S8uQ qQdv9UjlUOkFXqK79ZNfy1WOmSkF3Q== =K+CU -----END PGP SIGNATURE----- --ZRMbSRxQJ79m73FE-- From xen-devel-bounces@lists.xenproject.org Mon Jan 02 01:18:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 Jan 2023 01:18:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470208.729658 (Exim 4.92) (envelope-from ) id 1pC9St-0002CD-KZ; Mon, 02 Jan 2023 01:18:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470208.729658; Mon, 02 Jan 2023 01:18:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pC9St-0002C6-Hp; Mon, 02 Jan 2023 01:18:11 +0000 Received: by outflank-mailman (input) for mailman id 470208; Mon, 02 Jan 2023 01:18:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pC9Ss-0002C0-At for xen-devel@lists.xenproject.org; Mon, 02 Jan 2023 01:18:10 +0000 Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4ee087d1-8a3b-11ed-91b6-6bf2151ebd3b; Mon, 02 Jan 2023 02:18:06 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 23C7832006F5; Sun, 1 Jan 2023 20:18:03 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sun, 01 Jan 2023 20:18:03 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 1 Jan 2023 20:18:01 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4ee087d1-8a3b-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1672622282; x= 1672708682; bh=yVoTWhV9NOKPo4v/n3sT/VMH9GHO2ZdiZBvPkH9zdC8=; b=B vMoYz9Mhi9YgxkkD3IIl5q0kG4dW8IaCqWvko7S1VMASUN7f88iKJRsEvT/bFxJ/ m26ip5/42bqXaNAtxLqWebGyk+qWgv6BjAeJWMxd6viebeIdSLT5pAIgN3wWiRyW XywzNeCGT6D2BXAJ8TXz5jXrH6v3UeRi1RxgcEpOfaz8QryIo9lsoqC+Pv1CfskK RVyCZkZrt0qoq0q+Dq77ZmDQImvafYJzFBZb4oszMVZ5cHLMekMUa892VVZ1M6mH 210ErWh7zE5Hlzl5w2m7/2d9rKPCTYlTp4AlA38pqJYDQTA4tSpdxbG0i+EFBm9J Rgo9biNVcWIvomPQTPC/A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1672622282; x=1672708682; bh=yVoTWhV9NOKPo4v/n3sT/VMH9GHO 2ZdiZBvPkH9zdC8=; b=laMRUKP7nV5k4DmVETxqR13hJI8RB0akL2mRwZWmzr47 bpqo/s/VgAhLqew5gfWIZL5j/09kJT2k2sY0/uThi6YqBXl5R93Q5mjy3tpam9iP hRFFCKe5o7HJNnL2b3D9XLlsez1o6NNFxtuSCPhP/SZTcxJ9r5iNMyWFsX5fEb3y RQ3gC1P8Z+qyeVPq07pm0cpfXw2z20ycksnF5Ul08czz6+b8M0H381KyqhEOOfNC w5J/KUYP7A6BdOSNd2eP6uP7/r6Je4lFmfcVE8INpfIrqxWb/HxcrDNmaB97+cUX uriLyiscHnjVs9GaDQ8V+RlbpJ2WVro13xGJfivOEg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrjedugdefudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeffvghmihcu ofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinhhgsh hlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeetleffvdehleeffeffudffvedutdev geffvdffkeevfeevkefhjeegleduteffjeenucffohhmrghinhepqhhusggvshdqohhsrd horhhgpdhgihhthhhusgdrtghomhdpkhgvrhhnvghlrdhorhhgpdhithhlrdhsphgrtggv necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepuggvmh hisehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Sun, 1 Jan 2023 20:17:52 -0500 From: Demi Marie Obenour To: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= Cc: Ville =?utf-8?B?U3lyasOkbMOk?= , Andrew Cooper , "intel-gfx@lists.freedesktop.org" , the arch/x86 maintainers , Lucas De Marchi , Daniel Vetter , Rodrigo Vivi , xen-devel Subject: Re: [Intel-gfx] [cache coherency bug] i915 and PAT attributes Message-ID: References: <1c326e0c-5812-083a-0739-aa20fab3efc4@citrix.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2tpZ6p+tZudaMPXj" Content-Disposition: inline In-Reply-To: --2tpZ6p+tZudaMPXj Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Sun, 1 Jan 2023 20:17:52 -0500 From: Demi Marie Obenour To: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= Cc: Ville =?utf-8?B?U3lyasOkbMOk?= , Andrew Cooper , "intel-gfx@lists.freedesktop.org" , the arch/x86 maintainers , Lucas De Marchi , Daniel Vetter , Rodrigo Vivi , xen-devel Subject: Re: [Intel-gfx] [cache coherency bug] i915 and PAT attributes On Mon, Jan 02, 2023 at 02:00:51AM +0100, Marek Marczykowski-G=C3=B3recki w= rote: > On Sun, Jan 01, 2023 at 07:03:18PM -0500, Demi Marie Obenour wrote: > > On Mon, Jan 02, 2023 at 12:24:54AM +0100, Marek Marczykowski-G=C3=B3rec= ki wrote: > > > On Thu, Dec 22, 2022 at 10:29:57AM +0200, Ville Syrj=C3=A4l=C3=A4 wro= te: > > > > On Fri, Dec 16, 2022 at 03:30:13PM +0000, Andrew Cooper wrote: > > > > > On 08/12/2022 1:55 pm, Marek Marczykowski-G=C3=B3recki wrote: > > > > > > Hi, > > > > > > > > > > > > There is an issue with i915 on Xen PV (dom0). The end result is= a lot of > > > > > > glitches, like here: https://openqa.qubes-os.org/tests/54748#st= ep/startup/8 > > > > > > (this one is on ADL, Linux 6.1-rc7 as a Xen PV dom0). It's usin= g Xorg > > > > > > with "modesetting" driver. > > > > > > > > > > > > After some iterations of debugging, we narrowed it down to i915= handling > > > > > > caching. The main difference is that PAT is setup differently o= n Xen PV > > > > > > than on native Linux. Normally, Linux does have appropriate abs= traction > > > > > > for that, but apparently something related to i915 doesn't play= well > > > > > > with it. The specific difference is: > > > > > > native linux: > > > > > > x86/PAT: Configuration [0-7]: WB WC UC- UC WB WP UC- WT > > > > > > xen pv: > > > > > > x86/PAT: Configuration [0-7]: WB WT UC- UC WC WP UC UC > > > > > > ~~ ~~ ~~ ~~ > > > > > > > > > > > > The specific impact depends on kernel version and the hardware.= The most > > > > > > severe issues I see on >=3DADL, but some older hardware is affe= cted too - > > > > > > sometimes only if composition is disabled in the window manager. > > > > > > Some more information is collected at > > > > > > https://github.com/QubesOS/qubes-issues/issues/4782 (and few li= nked > > > > > > duplicates...). > > > > > > > > > > > > Kind-of related commit is here: > > > > > > https://github.com/torvalds/linux/commit/bdd8b6c98239cad ("drm/= i915: > > > > > > replace X86_FEATURE_PAT with pat_enabled()") - it is the place = where > > > > > > i915 explicitly checks for PAT support, so I'm cc-ing people me= ntioned > > > > > > there too. > > > > > > > > > > > > Any ideas? > > > > > > > > > > > > The issue can be easily reproduced without Xen too, by adjustin= g PAT in > > > > > > Linux: > > > > > > -----8<----- > > > > > > diff --git a/arch/x86/mm/pat/memtype.c b/arch/x86/mm/pat/memtyp= e.c > > > > > > index 66a209f7eb86..319ab60c8d8c 100644 > > > > > > --- a/arch/x86/mm/pat/memtype.c > > > > > > +++ b/arch/x86/mm/pat/memtype.c > > > > > > @@ -400,8 +400,8 @@ void pat_init(void) > > > > > > * The reserved slots are unused, but mapped to their > > > > > > * corresponding types in the presence of PAT errata. > > > > > > */ > > > > > > - pat =3D PAT(0, WB) | PAT(1, WC) | PAT(2, UC_MINUS) | PAT(3, = UC) | > > > > > > - PAT(4, WB) | PAT(5, WP) | PAT(6, UC_MINUS) | PAT(7, WT= ); > > > > > > + pat =3D PAT(0, WB) | PAT(1, WT) | PAT(2, UC_MINUS) | PAT(3, = UC) | > > > > > > + PAT(4, WC) | PAT(5, WP) | PAT(6, UC) | PAT(7, UC= ); > > > > > > } > > > > > > =20 > > > > > > if (!pat_bp_initialized) { > > > > > > -----8<----- > > > > > > > > > > >=20 > > > > > Hello, can anyone help please? > > > > >=20 > > > > > Intel's CI has taken this reproducer of the bug, and confirmed the > > > > > regression.=C2=A0 > > > > > https://lore.kernel.org/intel-gfx/Y5Hst0bCxQDTN7lK@mail-itl/T/#m4= 480c15a0d117dce6210562eb542875e757647fb > > > > >=20 > > > > > We're reasonably confident that it is an i915 bug (given the repr= o with > > > > > no Xen in the mix), but we're out of any further ideas. > > > >=20 > > > > I don't think we have any code that assumes anything about the PAT, > > > > apart from WC being available (which seems like it should still be > > > > the case with your modified PAT). I suppose you'll just have to=20 > > > > start digging from pgprot_writecombine()/noncached() and make sure > > > > everything ends up using the correct PAT entry. > > >=20 > > > I tried several approach to this, without success. Here is an update = on > > > debugging (reported also on #intel-gfx live): > > >=20 > > > I did several tests with different PAT configuration (by modifying Xen > > > that sets the MSR). Full table is at https://pad.itl.space/sheet/#/2/= sheet/view/HD1qT2Zf44Ha36TJ3wj2YL+PchsTidyNTFepW5++ZKM/ > > > Some highlights: > > > - 1=3DWC, 4=3DWT - good > > > - 1=3DWT, 4=3DWC - bad > > > - 1=3DWT, 3=3DWC (4=3DWC too) - good > > > - 1=3DWT, 5=3DWC - good > > >=20 > > > So, for me it seems WC at index 4 is problematic for some reason. > > >=20 > > > Next, I tried to trap all the places in arch/x86/xen/mmu_pv.c that > > > write PTEs and verify requested cache attributes. There, it seems all > > > the requested WC are properly translated (using either index 1, 3, 4,= or > > > 5 according to PAT settings). And then after reading PTE back, it ind= eed > > > seems to be correctly set. I didn't added reading back after > > > HYPERVISOR_update_va_mapping, but verified it isn't used for setting = WC. > > >=20 > > > Using the same method, I also checked that indexes that aren't suppos= ed > > > to be used (for example index 4 when both 3 and 4 are WC) indeed are = not > > > used. So, the hypothesis that specific indexes are hardcoded somewhere > > > is unlikely. > > >=20 > > > This all looks very weird to me. Any ideas? > >=20 > > Old CPUs have had hardware errata that caused the top bit of the PAT > > entry to be ignored in certain cases. Could modern CPUs be ignoring > > this bit when accessing iGPU memory or registers? With WC at position > > 4, this would cause WC to be treated as WB, which is consistent with the > > observed behavior. WC at position 3 would not be impacted, and WC at > > position 5 would be treated as WT which I expect to be safe. One way to > > test this is to test 1=3DWB, 5=3DWC. If my hypothesis is correct, this > > should trigger the bug, even if entry 1 in the PAT is unused because > > entry 0 is also WB. >=20 > This looks like a very probable situation, indeed 1=3DWB, 5=3DWC does > trigger the bug! Specifically this layout: >=20 > WB WB UC- UC WP WC WT UC What about WB WT WB UC WB WP WC UC- and WB WT WT UC WB WP WC UC-? Those only differ in entry 2, which will not be used as it duplicates entry 0 or 1. Therefore, architecturally, these should behave identically. If I am correct, the second will work fine, but the first will trigger the bug. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --2tpZ6p+tZudaMPXj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmOyMMcACgkQsoi1X/+c IsFgvA/9FmiZPls9UyctSYLzjz5C03aRvLIN/oFqAo/laqzBcDPHVJeCLWr39qy6 hUoXgzqIGISsDyAmzAgX3+fdd7WkNRjqworEjRdtYRFu7hGkzbPkFd7oa7Ty+CCk QUy7oZo8u/UEjiBfTctO5P/YZaKFIqZyLFeVRRZp3kZUS+pk35IJ4EE7n7bm7duH HHGvrptmL8u2KpPNlPLKQamQYHDVemsf6q5MJQ7HdL6ouD3+bv/DFqxxeYECNhiP XiJ3lyZdbgrzoRGFGTM7MzxHZkG3agWcE4tz6s4owEYUxdkUb4YX4Kr8Nd9SK00F hy3l266Auwi1s6NZfXx3IA4zLwlII+7UmBhUai42dKSNVX0+8lIDt7wYArVoW2f+ wXlZk8fDxr/tqx/wzCj1thWIdcue10TB/xPFXmSdcW0zDz82rU6xg0aLg8OWlKR7 ssGUl28ApVPgD95u+xONhGvWegD7N1TjUGVTTPMwHh12308h8T9sze//53ws5Jjy yv6si59zBe2qN2RroSBtcAM9qX+yrTovpY38V8sde+sIPIXLOrLdRNekpQK9AbsE Gbxg+02/9Exq0KKgS/6KmbUUD/NRpK+Q/gHAWPAS5uU9QmOhIs6OGiQ3Ni1Z4uvy e0lpaiLd3TTfrY1U0Z/4dmBsqbZHCHw+L6B75y8ZsTcN4EIS2vE= =rum4 -----END PGP SIGNATURE----- --2tpZ6p+tZudaMPXj-- From xen-devel-bounces@lists.xenproject.org Mon Jan 02 01:48:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 Jan 2023 01:48:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470218.729669 (Exim 4.92) (envelope-from ) id 1pC9wF-0005Xz-4T; Mon, 02 Jan 2023 01:48:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470218.729669; Mon, 02 Jan 2023 01:48:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pC9wF-0005Xs-1D; Mon, 02 Jan 2023 01:48:31 +0000 Received: by outflank-mailman (input) for mailman id 470218; Mon, 02 Jan 2023 01:48:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pC9wD-0005Xm-OI for xen-devel@lists.xenproject.org; Mon, 02 Jan 2023 01:48:29 +0000 Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 89498e70-8a3f-11ed-8fd4-01056ac49cbb; Mon, 02 Jan 2023 02:48:22 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id B0AB532003CE; Sun, 1 Jan 2023 20:48:22 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sun, 01 Jan 2023 20:48:23 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 1 Jan 2023 20:48:20 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 89498e70-8a3f-11ed-8fd4-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1672624102; x= 1672710502; bh=cIx24x0KYrdmbF9rhXPF+ueoJK5CbFbBsixsjiFIyTA=; b=y quWpo9NWEUD6eKxRWXmnIVtM4n1mdref6I1rw1vi3SaylcPkrtFECZq8N8Z5LoHo jpX17cTglH0HN3XiI86ffSzb5GhzpeQUAJnN+Vvx9bo2lD0WDSInB1GUXaRf0vwb MhRHuhb4mXrKBAOlXlEKN9yf9/jotECUSw0WeWDDNA1PngumefSC1yU6VTW+NTZh 2AXd3vVH2f8FU2PbNEcv1qygf++Pvl5vE/6U7wGNGQBU69KFwpmI5QjQXGKFvzZm 7RiUXmnJQ0aPUIl8lBX9MkhwG7WjGtvkKPk79yL0aylQnW+CNMgbFQtCof9FYFV3 Em1OC3HV5XDLgweSVWteQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1672624102; x=1672710502; bh=cIx24x0KYrdmbF9rhXPF+ueoJK5C bFbBsixsjiFIyTA=; b=rmzK1e6jYgwQ5/iS+ionKPE3u/6AWuKeL+rpsvlNuv4O j9kEUf6/NSR/m0ci7xJ+s6fkpJv4mryQ+ENDXkJXVV1+QK30Y8dnoBEyOI4a2fSZ 0r3KtmXyTm01Meo+bZjPEAgMWFdNXOaxOkDfXu6G7BDMgXdP6XjYdmINBo76B4Qc U7cii1udF4zGU/Edz0cQq2WMQtOKJoCyjyp9vVOK0zfXNOxIsa4X0wHkBbivvTPE p+70JoKth6owmn2GxHarEPYSUxylTb5B71DePVF0H7sskOYYDpQG+6Vuotc+nEpe WOdFVyCOzH0QRMEwG0x3pNeJ6COIJi3zXCMD19AYIg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrjedugdefjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeffvghmihcu ofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinhhgsh hlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeetleffvdehleeffeffudffvedutdev geffvdffkeevfeevkefhjeegleduteffjeenucffohhmrghinhepqhhusggvshdqohhsrd horhhgpdhgihhthhhusgdrtghomhdpkhgvrhhnvghlrdhorhhgpdhithhlrdhsphgrtggv necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepuggvmh hisehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Sun, 1 Jan 2023 20:48:13 -0500 From: Demi Marie Obenour To: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= Cc: Ville =?utf-8?B?U3lyasOkbMOk?= , Andrew Cooper , "intel-gfx@lists.freedesktop.org" , the arch/x86 maintainers , Lucas De Marchi , Daniel Vetter , Rodrigo Vivi , xen-devel Subject: Re: [Intel-gfx] [cache coherency bug] i915 and PAT attributes Message-ID: References: <1c326e0c-5812-083a-0739-aa20fab3efc4@citrix.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="hSJ/g7c8/Ke3ldGo" Content-Disposition: inline In-Reply-To: --hSJ/g7c8/Ke3ldGo Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Sun, 1 Jan 2023 20:48:13 -0500 From: Demi Marie Obenour To: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= Cc: Ville =?utf-8?B?U3lyasOkbMOk?= , Andrew Cooper , "intel-gfx@lists.freedesktop.org" , the arch/x86 maintainers , Lucas De Marchi , Daniel Vetter , Rodrigo Vivi , xen-devel Subject: Re: [Intel-gfx] [cache coherency bug] i915 and PAT attributes On Sun, Jan 01, 2023 at 08:17:52PM -0500, Demi Marie Obenour wrote: > On Mon, Jan 02, 2023 at 02:00:51AM +0100, Marek Marczykowski-G=C3=B3recki= wrote: > > On Sun, Jan 01, 2023 at 07:03:18PM -0500, Demi Marie Obenour wrote: > > > On Mon, Jan 02, 2023 at 12:24:54AM +0100, Marek Marczykowski-G=C3=B3r= ecki wrote: > > > > On Thu, Dec 22, 2022 at 10:29:57AM +0200, Ville Syrj=C3=A4l=C3=A4 w= rote: > > > > > On Fri, Dec 16, 2022 at 03:30:13PM +0000, Andrew Cooper wrote: > > > > > > On 08/12/2022 1:55 pm, Marek Marczykowski-G=C3=B3recki wrote: > > > > > > > Hi, > > > > > > > > > > > > > > There is an issue with i915 on Xen PV (dom0). The end result = is a lot of > > > > > > > glitches, like here: https://openqa.qubes-os.org/tests/54748#= step/startup/8 > > > > > > > (this one is on ADL, Linux 6.1-rc7 as a Xen PV dom0). It's us= ing Xorg > > > > > > > with "modesetting" driver. > > > > > > > > > > > > > > After some iterations of debugging, we narrowed it down to i9= 15 handling > > > > > > > caching. The main difference is that PAT is setup differently= on Xen PV > > > > > > > than on native Linux. Normally, Linux does have appropriate a= bstraction > > > > > > > for that, but apparently something related to i915 doesn't pl= ay well > > > > > > > with it. The specific difference is: > > > > > > > native linux: > > > > > > > x86/PAT: Configuration [0-7]: WB WC UC- UC WB WP UC- WT > > > > > > > xen pv: > > > > > > > x86/PAT: Configuration [0-7]: WB WT UC- UC WC WP UC UC > > > > > > > ~~ ~~ ~~ ~~ > > > > > > > > > > > > > > The specific impact depends on kernel version and the hardwar= e. The most > > > > > > > severe issues I see on >=3DADL, but some older hardware is af= fected too - > > > > > > > sometimes only if composition is disabled in the window manag= er. > > > > > > > Some more information is collected at > > > > > > > https://github.com/QubesOS/qubes-issues/issues/4782 (and few = linked > > > > > > > duplicates...). > > > > > > > > > > > > > > Kind-of related commit is here: > > > > > > > https://github.com/torvalds/linux/commit/bdd8b6c98239cad ("dr= m/i915: > > > > > > > replace X86_FEATURE_PAT with pat_enabled()") - it is the plac= e where > > > > > > > i915 explicitly checks for PAT support, so I'm cc-ing people = mentioned > > > > > > > there too. > > > > > > > > > > > > > > Any ideas? > > > > > > > > > > > > > > The issue can be easily reproduced without Xen too, by adjust= ing PAT in > > > > > > > Linux: > > > > > > > -----8<----- > > > > > > > diff --git a/arch/x86/mm/pat/memtype.c b/arch/x86/mm/pat/memt= ype.c > > > > > > > index 66a209f7eb86..319ab60c8d8c 100644 > > > > > > > --- a/arch/x86/mm/pat/memtype.c > > > > > > > +++ b/arch/x86/mm/pat/memtype.c > > > > > > > @@ -400,8 +400,8 @@ void pat_init(void) > > > > > > > * The reserved slots are unused, but mapped to their > > > > > > > * corresponding types in the presence of PAT errata. > > > > > > > */ > > > > > > > - pat =3D PAT(0, WB) | PAT(1, WC) | PAT(2, UC_MINUS) | PAT(3= , UC) | > > > > > > > - PAT(4, WB) | PAT(5, WP) | PAT(6, UC_MINUS) | PAT(7, = WT); > > > > > > > + pat =3D PAT(0, WB) | PAT(1, WT) | PAT(2, UC_MINUS) | PAT(3= , UC) | > > > > > > > + PAT(4, WC) | PAT(5, WP) | PAT(6, UC) | PAT(7, = UC); > > > > > > > } > > > > > > > =20 > > > > > > > if (!pat_bp_initialized) { > > > > > > > -----8<----- > > > > > > > > > > > > >=20 > > > > > > Hello, can anyone help please? > > > > > >=20 > > > > > > Intel's CI has taken this reproducer of the bug, and confirmed = the > > > > > > regression.=C2=A0 > > > > > > https://lore.kernel.org/intel-gfx/Y5Hst0bCxQDTN7lK@mail-itl/T/#= m4480c15a0d117dce6210562eb542875e757647fb > > > > > >=20 > > > > > > We're reasonably confident that it is an i915 bug (given the re= pro with > > > > > > no Xen in the mix), but we're out of any further ideas. > > > > >=20 > > > > > I don't think we have any code that assumes anything about the PA= T, > > > > > apart from WC being available (which seems like it should still be > > > > > the case with your modified PAT). I suppose you'll just have to= =20 > > > > > start digging from pgprot_writecombine()/noncached() and make sure > > > > > everything ends up using the correct PAT entry. > > > >=20 > > > > I tried several approach to this, without success. Here is an updat= e on > > > > debugging (reported also on #intel-gfx live): > > > >=20 > > > > I did several tests with different PAT configuration (by modifying = Xen > > > > that sets the MSR). Full table is at https://pad.itl.space/sheet/#/= 2/sheet/view/HD1qT2Zf44Ha36TJ3wj2YL+PchsTidyNTFepW5++ZKM/ > > > > Some highlights: > > > > - 1=3DWC, 4=3DWT - good > > > > - 1=3DWT, 4=3DWC - bad > > > > - 1=3DWT, 3=3DWC (4=3DWC too) - good > > > > - 1=3DWT, 5=3DWC - good > > > >=20 > > > > So, for me it seems WC at index 4 is problematic for some reason. > > > >=20 > > > > Next, I tried to trap all the places in arch/x86/xen/mmu_pv.c that > > > > write PTEs and verify requested cache attributes. There, it seems a= ll > > > > the requested WC are properly translated (using either index 1, 3, = 4, or > > > > 5 according to PAT settings). And then after reading PTE back, it i= ndeed > > > > seems to be correctly set. I didn't added reading back after > > > > HYPERVISOR_update_va_mapping, but verified it isn't used for settin= g WC. > > > >=20 > > > > Using the same method, I also checked that indexes that aren't supp= osed > > > > to be used (for example index 4 when both 3 and 4 are WC) indeed ar= e not > > > > used. So, the hypothesis that specific indexes are hardcoded somewh= ere > > > > is unlikely. > > > >=20 > > > > This all looks very weird to me. Any ideas? > > >=20 > > > Old CPUs have had hardware errata that caused the top bit of the PAT > > > entry to be ignored in certain cases. Could modern CPUs be ignoring > > > this bit when accessing iGPU memory or registers? With WC at position > > > 4, this would cause WC to be treated as WB, which is consistent with = the > > > observed behavior. WC at position 3 would not be impacted, and WC at > > > position 5 would be treated as WT which I expect to be safe. One way= to > > > test this is to test 1=3DWB, 5=3DWC. If my hypothesis is correct, th= is > > > should trigger the bug, even if entry 1 in the PAT is unused because > > > entry 0 is also WB. > >=20 > > This looks like a very probable situation, indeed 1=3DWB, 5=3DWC does > > trigger the bug! Specifically this layout: > >=20 > > WB WB UC- UC WP WC WT UC >=20 > What about WB WT WB UC WB WP WC UC- and WB WT WT UC WB WP WC UC-? Those > only differ in entry 2, which will not be used as it duplicates entry 0 > or 1. Therefore, architecturally, these should behave identically. If > I am correct, the second will work fine, but the first will trigger the > bug. Also worth testing: WB UC- UC WB WB WP WT WC WB UC- UC UC WB WP WT WC These differ only in (unused) entry 3. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --hSJ/g7c8/Ke3ldGo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmOyN+MACgkQsoi1X/+c IsF4eBAAm/8NuQ6F7sPJh36pPa13o66PgJLeu7Ncoe34u5rWemIwVj5vZ9dei7SP hbcl8frTWIs3ay7mvpg4FJFn7foLzk9LbTQJyimBUqGU2Q9B2nIqiSgZN8VEZyHR STe6XMIFnREbln6YT8eg4DJesTE4yVXeDJgojpQm1WaaTof3mmtyLpsPNEZ2BBl5 lZRwIHtgcHNmQyJxG1pNU5lGwrvXrOMJVneuMYUabr/2xpcYGWMXpwrvBdPHoGtD tMwKIqvF69R2GmYspp3omVURtBhMYwfzrcHKyhouNTy/y8hCI25Ov0DHqUWGzQYP 0KUOhyqAVKw0TGGRfkdcBhd40DDlGShNx2MxFySDzcfAz+C3T9Xtup9oYVj0t9pH btU8+6zF7Ko2McdFFeZiNPZFq8j2SntnDwqDemqIgp3OM5gEw2fa+nTRlYgtOGoS v3p/iixJi3tlgW3Chs9AB8tim+zWt8cJjKQifpvUWw9Zi05Ca7myzAXi9NRXHiqg 0BuhLLN08079RdkLKWOqj0aTkyrbjTy2bKH8+/sxFCggdVCZSiJzv91uyGTleK7m SeH2Kwi0fPVX2Jik5SVHyLCyyJ2ICgqSbE4Ya9/3OBa3nCeKm97t/DDaZjMsY8MO OTe4QlRyZKge/3rNkFK39y7TQ6gZd3MAakQIKuYfkherQqpPC2E= =cznL -----END PGP SIGNATURE----- --hSJ/g7c8/Ke3ldGo-- From xen-devel-bounces@lists.xenproject.org Mon Jan 02 01:58:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 Jan 2023 01:58:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470226.729679 (Exim 4.92) (envelope-from ) id 1pCA5x-000723-Tl; Mon, 02 Jan 2023 01:58:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470226.729679; Mon, 02 Jan 2023 01:58:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCA5x-00071w-RC; Mon, 02 Jan 2023 01:58:33 +0000 Received: by outflank-mailman (input) for mailman id 470226; Mon, 02 Jan 2023 01:58:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCA5w-00071q-KT for xen-devel@lists.xenproject.org; Mon, 02 Jan 2023 01:58:32 +0000 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f1810f9c-8a40-11ed-8fd4-01056ac49cbb; Mon, 02 Jan 2023 02:58:26 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 7573B5C016C; Sun, 1 Jan 2023 20:58:28 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sun, 01 Jan 2023 20:58:28 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 1 Jan 2023 20:58:26 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f1810f9c-8a40-11ed-8fd4-01056ac49cbb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1672624708; x= 1672711108; bh=SkyBYYpMMvL3uEm5eSua/6wIi9ndNHC5rn4cANOE338=; b=R vee3pGnzlD3J8m018uX/+iSyU3O/8VMJvJU/pm2BLIlXNDO/81yA9k48+b1k8HzG ndmCGnLQkhBWQgeif0jeuKqG0aJf1PiefKC8BwRNlgdYqw/gKh70DX3JK2A+pRF9 YcDOJ3ZQipjC4X5bKdRe2bVlUYlZFdSAKmTI+0n76vTkccDeLjT7Ok6AKaRm22/h 7BLLyPoh17o23UOLS5cz8GzA6DbL74+ofSuVXsEdTdRMbxMikKet76Z3HZdmwcqz sRSQUFnAxqqVVQiTnw/2As5Ath4GxE0oKxSPJMPEoF4Ve0UW1mxuaXMD/NvuGy2H 7tWthK1zAnilsL/93Mxbg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1672624708; x=1672711108; bh=SkyBYYpMMvL3uEm5eSua/6wIi9nd NHC5rn4cANOE338=; b=N+BkGOOEgKU/A5Fcz3XDri2ZgFHi3ZwmcdzBvbvIf+mx 0OlZSPHqz8NfymsIbkBnBZPPGpcQI2ev9w1YvPSG7LqxQJpeBG0pylDtJbrK1V9n bW5wEWm5yN+vfQzuMavxtOjyRMm/Xt1YssPMeEdpDERJrBZ8R7/Lm9GkSydGpTns ZTfGtl7h2JkzpV3S+ciENBSJKw4uj2GubaSeCycbKCoabvRRZrKjxU/EzeNi1iE9 7jApf0ro+d8ukNKaP4b2865DcyVwUoSw9BdOwr6VtfFgUMOLo95eWz1kbTHIMlf0 OsiCyob8GsMxP+CaK4FqdZE/Vlv1mY6uZNT9I7UCvQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrjedugdeflecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeeliedu tdfggfekuefhhedtfeevhfetgfdtvdeujeeuteevtdeutdegffeguedufeenucffohhmrg hinhepqhhusggvshdqohhsrdhorhhgpdhgihhthhhusgdrtghomhdpkhgvrhhnvghlrdho rhhgpdhithhlrdhsphgrtggvnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomhepmhgrrhhmrghrvghksehinhhvihhsihgslhgvthhhihhnghhslhgr sgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Mon, 2 Jan 2023 02:58:23 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Demi Marie Obenour Cc: Ville =?utf-8?B?U3lyasOkbMOk?= , Andrew Cooper , "intel-gfx@lists.freedesktop.org" , the arch/x86 maintainers , Lucas De Marchi , Daniel Vetter , Rodrigo Vivi , xen-devel Subject: Re: [Intel-gfx] [cache coherency bug] [hw bug?] i915 and PAT attributes Message-ID: References: <1c326e0c-5812-083a-0739-aa20fab3efc4@citrix.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="FiKZDM0ecfbmwtbS" Content-Disposition: inline In-Reply-To: --FiKZDM0ecfbmwtbS Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Mon, 2 Jan 2023 02:58:23 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Demi Marie Obenour Cc: Ville =?utf-8?B?U3lyasOkbMOk?= , Andrew Cooper , "intel-gfx@lists.freedesktop.org" , the arch/x86 maintainers , Lucas De Marchi , Daniel Vetter , Rodrigo Vivi , xen-devel Subject: Re: [Intel-gfx] [cache coherency bug] [hw bug?] i915 and PAT attributes On Sun, Jan 01, 2023 at 08:48:13PM -0500, Demi Marie Obenour wrote: > On Sun, Jan 01, 2023 at 08:17:52PM -0500, Demi Marie Obenour wrote: > > On Mon, Jan 02, 2023 at 02:00:51AM +0100, Marek Marczykowski-G=C3=B3rec= ki wrote: > > > On Sun, Jan 01, 2023 at 07:03:18PM -0500, Demi Marie Obenour wrote: > > > > On Mon, Jan 02, 2023 at 12:24:54AM +0100, Marek Marczykowski-G=C3= =B3recki wrote: > > > > > On Thu, Dec 22, 2022 at 10:29:57AM +0200, Ville Syrj=C3=A4l=C3=A4= wrote: > > > > > > On Fri, Dec 16, 2022 at 03:30:13PM +0000, Andrew Cooper wrote: > > > > > > > On 08/12/2022 1:55 pm, Marek Marczykowski-G=C3=B3recki wrote: > > > > > > > > Hi, > > > > > > > > > > > > > > > > There is an issue with i915 on Xen PV (dom0). The end resul= t is a lot of > > > > > > > > glitches, like here: https://openqa.qubes-os.org/tests/5474= 8#step/startup/8 > > > > > > > > (this one is on ADL, Linux 6.1-rc7 as a Xen PV dom0). It's = using Xorg > > > > > > > > with "modesetting" driver. > > > > > > > > > > > > > > > > After some iterations of debugging, we narrowed it down to = i915 handling > > > > > > > > caching. The main difference is that PAT is setup different= ly on Xen PV > > > > > > > > than on native Linux. Normally, Linux does have appropriate= abstraction > > > > > > > > for that, but apparently something related to i915 doesn't = play well > > > > > > > > with it. The specific difference is: > > > > > > > > native linux: > > > > > > > > x86/PAT: Configuration [0-7]: WB WC UC- UC WB WP UC- WT > > > > > > > > xen pv: > > > > > > > > x86/PAT: Configuration [0-7]: WB WT UC- UC WC WP UC UC > > > > > > > > ~~ ~~ ~~ ~~ > > > > > > > > > > > > > > > > The specific impact depends on kernel version and the hardw= are. The most > > > > > > > > severe issues I see on >=3DADL, but some older hardware is = affected too - > > > > > > > > sometimes only if composition is disabled in the window man= ager. > > > > > > > > Some more information is collected at > > > > > > > > https://github.com/QubesOS/qubes-issues/issues/4782 (and fe= w linked > > > > > > > > duplicates...). > > > > > > > > > > > > > > > > Kind-of related commit is here: > > > > > > > > https://github.com/torvalds/linux/commit/bdd8b6c98239cad ("= drm/i915: > > > > > > > > replace X86_FEATURE_PAT with pat_enabled()") - it is the pl= ace where > > > > > > > > i915 explicitly checks for PAT support, so I'm cc-ing peopl= e mentioned > > > > > > > > there too. > > > > > > > > > > > > > > > > Any ideas? > > > > > > > > > > > > > > > > The issue can be easily reproduced without Xen too, by adju= sting PAT in > > > > > > > > Linux: > > > > > > > > -----8<----- > > > > > > > > diff --git a/arch/x86/mm/pat/memtype.c b/arch/x86/mm/pat/me= mtype.c > > > > > > > > index 66a209f7eb86..319ab60c8d8c 100644 > > > > > > > > --- a/arch/x86/mm/pat/memtype.c > > > > > > > > +++ b/arch/x86/mm/pat/memtype.c > > > > > > > > @@ -400,8 +400,8 @@ void pat_init(void) > > > > > > > > * The reserved slots are unused, but mapped to their > > > > > > > > * corresponding types in the presence of PAT errata. > > > > > > > > */ > > > > > > > > - pat =3D PAT(0, WB) | PAT(1, WC) | PAT(2, UC_MINUS) | PAT= (3, UC) | > > > > > > > > - PAT(4, WB) | PAT(5, WP) | PAT(6, UC_MINUS) | PAT(7= , WT); > > > > > > > > + pat =3D PAT(0, WB) | PAT(1, WT) | PAT(2, UC_MINUS) | PAT= (3, UC) | > > > > > > > > + PAT(4, WC) | PAT(5, WP) | PAT(6, UC) | PAT(7= , UC); > > > > > > > > } > > > > > > > > =20 > > > > > > > > if (!pat_bp_initialized) { > > > > > > > > -----8<----- > > > > > > > > > > > > > > >=20 > > > > > > > Hello, can anyone help please? > > > > > > >=20 > > > > > > > Intel's CI has taken this reproducer of the bug, and confirme= d the > > > > > > > regression.=C2=A0 > > > > > > > https://lore.kernel.org/intel-gfx/Y5Hst0bCxQDTN7lK@mail-itl/T= /#m4480c15a0d117dce6210562eb542875e757647fb > > > > > > >=20 > > > > > > > We're reasonably confident that it is an i915 bug (given the = repro with > > > > > > > no Xen in the mix), but we're out of any further ideas. > > > > > >=20 > > > > > > I don't think we have any code that assumes anything about the = PAT, > > > > > > apart from WC being available (which seems like it should still= be > > > > > > the case with your modified PAT). I suppose you'll just have to= =20 > > > > > > start digging from pgprot_writecombine()/noncached() and make s= ure > > > > > > everything ends up using the correct PAT entry. > > > > >=20 > > > > > I tried several approach to this, without success. Here is an upd= ate on > > > > > debugging (reported also on #intel-gfx live): > > > > >=20 > > > > > I did several tests with different PAT configuration (by modifyin= g Xen > > > > > that sets the MSR). Full table is at https://pad.itl.space/sheet/= #/2/sheet/view/HD1qT2Zf44Ha36TJ3wj2YL+PchsTidyNTFepW5++ZKM/ > > > > > Some highlights: > > > > > - 1=3DWC, 4=3DWT - good > > > > > - 1=3DWT, 4=3DWC - bad > > > > > - 1=3DWT, 3=3DWC (4=3DWC too) - good > > > > > - 1=3DWT, 5=3DWC - good > > > > >=20 > > > > > So, for me it seems WC at index 4 is problematic for some reason. > > > > >=20 > > > > > Next, I tried to trap all the places in arch/x86/xen/mmu_pv.c that > > > > > write PTEs and verify requested cache attributes. There, it seems= all > > > > > the requested WC are properly translated (using either index 1, 3= , 4, or > > > > > 5 according to PAT settings). And then after reading PTE back, it= indeed > > > > > seems to be correctly set. I didn't added reading back after > > > > > HYPERVISOR_update_va_mapping, but verified it isn't used for sett= ing WC. > > > > >=20 > > > > > Using the same method, I also checked that indexes that aren't su= pposed > > > > > to be used (for example index 4 when both 3 and 4 are WC) indeed = are not > > > > > used. So, the hypothesis that specific indexes are hardcoded some= where > > > > > is unlikely. > > > > >=20 > > > > > This all looks very weird to me. Any ideas? > > > >=20 > > > > Old CPUs have had hardware errata that caused the top bit of the PAT > > > > entry to be ignored in certain cases. Could modern CPUs be ignoring > > > > this bit when accessing iGPU memory or registers? With WC at posit= ion > > > > 4, this would cause WC to be treated as WB, which is consistent wit= h the > > > > observed behavior. WC at position 3 would not be impacted, and WC = at > > > > position 5 would be treated as WT which I expect to be safe. One w= ay to > > > > test this is to test 1=3DWB, 5=3DWC. If my hypothesis is correct, = this > > > > should trigger the bug, even if entry 1 in the PAT is unused because > > > > entry 0 is also WB. > > >=20 > > > This looks like a very probable situation, indeed 1=3DWB, 5=3DWC does > > > trigger the bug! Specifically this layout: > > >=20 > > > WB WB UC- UC WP WC WT UC > >=20 > > What about WB WT WB UC WB WP WC UC- and WB WT WT UC WB WP WC UC-? Those > > only differ in entry 2, which will not be used as it duplicates entry 0 > > or 1. Therefore, architecturally, these should behave identically. If > > I am correct, the second will work fine, but the first will trigger the > > bug. Bingo! This also behaves as predicted. So, it indeed looks like the _PAGE_PAT bit is ignored by the hardware, even though set in relevant PTEs. > Also worth testing: >=20 > WB UC- UC WB WB WP WT WC > WB UC- UC UC WB WP WT WC >=20 > These differ only in (unused) entry 3. I'll skip this, as I think it's pretty clear what will be the result. But if somebody else think it's worth testing anyway, let me know. --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --FiKZDM0ecfbmwtbS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmOyOj8ACgkQ24/THMrX 1yzWTAf+Nm62uwMkKfko7fNV0IB2LOSKLMk8dRIQAOk4ah3LCtiGYJBfYuxsb2EP luPaltO3LnmfKR+iiRckJXR/7Z+wCfks0yiYEdqa+GxkNlZtZd4XNuUHhKJQBi1j JKrjweJDftepahzDEFfdNyFfTxegeRHnzPvhYAprZJ1NT83bo4hqvF5ghBoPcRPy YILB76OXUlO315IqJ9sZUJHeSJTcJHgif/ZMF+lkYRfy0pIGrKCEWyZTUKv0ygB4 L/EU0U4AL2OJNX0Wt77XRW+b1v/quVm1aswCVks4a6Y32E9bCNR6ATCk4Cspz2p+ ZRojW+IfIUYtT+qnW3aJasLmp0NyIA== =yf4Y -----END PGP SIGNATURE----- --FiKZDM0ecfbmwtbS-- From xen-devel-bounces@lists.xenproject.org Mon Jan 02 07:56:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 Jan 2023 07:56:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470242.729691 (Exim 4.92) (envelope-from ) id 1pCFg5-0000bk-Ob; Mon, 02 Jan 2023 07:56:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470242.729691; Mon, 02 Jan 2023 07:56:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCFg5-0000bd-Lq; Mon, 02 Jan 2023 07:56:13 +0000 Received: by outflank-mailman (input) for mailman id 470242; Mon, 02 Jan 2023 07:56:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCFg4-0000bT-HI; Mon, 02 Jan 2023 07:56:12 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCFg4-0006NJ-Et; Mon, 02 Jan 2023 07:56:12 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCFg4-0007Xr-09; Mon, 02 Jan 2023 07:56:12 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pCFg3-0003Z2-Vu; Mon, 02 Jan 2023 07:56:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=O131MNS9aTUiwP9GuA5C+apYE1zZk9p1Ah3gyFgix3s=; b=AN2Q0ju214ogQkSy7XNHkElAPN kvDi5PKWYcOdwZspUNmz28lGTBuvZ4gIzqyka9Sd3T1aHRRGtvY/CK5KatXML0KiruplWfGaCjn/o pnVq3CS7F05VlgDp4cDOahDFW/m/G0FWf+a01MKk6C9Sp49CfEscJstJ9GYRwFoRpaEc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 175547: trouble: broken/fail/pass/starved X-Osstest-Failures: linux-5.4:test-armhf-armhf-xl-credit1::broken:regression linux-5.4:test-amd64-i386-qemuu-rhel6hvm-intel::broken:regression linux-5.4:test-amd64-amd64-xl-qemut-debianhvm-amd64::broken:regression linux-5.4:test-amd64-amd64-xl-credit2::broken:regression linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64::broken:regression linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:host-install(5):broken:heisenbug linux-5.4:test-amd64-i386-qemuu-rhel6hvm-intel:host-install(5):broken:heisenbug linux-5.4:test-amd64-amd64-xl-credit2:host-install(5):broken:heisenbug linux-5.4:test-amd64-amd64-xl-qemut-debianhvm-amd64:host-install(5):broken:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:host-install(5):broken:heisenbug linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug linux-5.4:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:heisenbug linux-5.4:test-amd64-i386-xl-vhd:guest-start.2:fail:heisenbug linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=851c2b5fb7936d54e1147f76f88e2675f9f82b52 X-Osstest-Versions-That: linux=66bb2e2b24ce52819a7070d3a3255726cb946b69 From: osstest service owner Date: Mon, 02 Jan 2023 07:56:11 +0000 flight 175547 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/175547/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit1 broken test-amd64-i386-qemuu-rhel6hvm-intel broken in 175407 test-amd64-amd64-xl-qemut-debianhvm-amd64 broken in 175407 test-amd64-amd64-xl-credit2 broken in 175407 test-amd64-i386-xl-qemuu-ws16-amd64 broken in 175407 Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-ws16-amd64 5 host-install(5) broken in 175407 pass in 175547 test-amd64-i386-qemuu-rhel6hvm-intel 5 host-install(5) broken in 175407 pass in 175547 test-amd64-amd64-xl-credit2 5 host-install(5) broken in 175407 pass in 175547 test-amd64-amd64-xl-qemut-debianhvm-amd64 5 host-install(5) broken in 175407 pass in 175547 test-armhf-armhf-xl-credit1 5 host-install(5) broken pass in 175545 test-armhf-armhf-xl-multivcpu 14 guest-start fail in 175407 pass in 175547 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail in 175545 pass in 175407 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail in 175545 pass in 175547 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail in 175545 pass in 175547 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail pass in 175545 test-amd64-i386-xl-vhd 22 guest-start.2 fail pass in 175545 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail blocked in 175197 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail in 175407 like 175197 test-arm64-arm64-xl-seattle 15 migrate-support-check fail in 175545 never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail in 175545 never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail in 175545 never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail in 175545 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 175197 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 175197 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175197 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 175197 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175197 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175197 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 175197 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 175197 test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail like 175197 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 175197 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 175197 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 175197 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175197 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 3 hosts-allocate starved n/a version targeted for testing: linux 851c2b5fb7936d54e1147f76f88e2675f9f82b52 baseline version: linux 66bb2e2b24ce52819a7070d3a3255726cb946b69 Last test of basis 175197 2022-12-14 10:43:17 Z 18 days Testing same since 175407 2022-12-19 11:42:26 Z 13 days 33 attempts ------------------------------------------------------------ People who touched revisions under test: Alexei Starovoitov Andrew Morton Baolin Wang Charles Keepax Florian Fainelli Greg Kroah-Hartman Guenter Roeck Heiko Schocher Hulk Robot Jakub Kicinski Jialiang Wang Jon Hunter Linus Walleij Linux Kernel Functional Testing Lorenzo Colitti Maciej Żenczykowski Marc Kleine-Budde Mark Brown Ming Lei Paul E. McKenney Ricardo Ribalda Samuel Mendoza-Jonas Sasha Levin Shiwei Cui Shuah Khan Simon Horman Sudip Mukherjee Yasushi SHOJI Yasushi SHOJI jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 broken test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-armhf-armhf-xl-credit1 broken broken-step test-armhf-armhf-xl-credit1 host-install(5) broken-job test-amd64-i386-qemuu-rhel6hvm-intel broken broken-job test-amd64-amd64-xl-qemut-debianhvm-amd64 broken broken-job test-amd64-amd64-xl-credit2 broken broken-job test-amd64-i386-xl-qemuu-ws16-amd64 broken Not pushing. (No revision log; it would be 410 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Jan 02 09:26:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 Jan 2023 09:26:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470257.729702 (Exim 4.92) (envelope-from ) id 1pCH5N-0001fa-RF; Mon, 02 Jan 2023 09:26:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470257.729702; Mon, 02 Jan 2023 09:26:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCH5N-0001fT-O8; Mon, 02 Jan 2023 09:26:25 +0000 Received: by outflank-mailman (input) for mailman id 470257; Mon, 02 Jan 2023 09:26:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCH5M-0001fJ-3A; Mon, 02 Jan 2023 09:26:24 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCH5L-0000R8-U1; Mon, 02 Jan 2023 09:26:23 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCH5L-0003EE-C3; Mon, 02 Jan 2023 09:26:23 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pCH5L-0005q9-BZ; Mon, 02 Jan 2023 09:26:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=hDvuI+E2CeBN0YTN+eIuSe1htPbueljzw1Tq2gzEsFo=; b=NbbRAaW7Nf0QiDS7/vlcQdHFpn pEalFfwNqSGx/Gd2XSZ9JnlCnxJbLC09OTtedxA363BtMI4HIaGDfoG4/ez0bglYwYde/DfXSr7Ax W2gF8mbP7zf0jlKhqWslCmjOZWpHrnq8luT8PamKcJURdlXN4NOg6dIQwmMVrcpEDm/o=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 175546: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=88603b6dc419445847923fcb7fe5080067a30f98 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Mon, 02 Jan 2023 09:26:23 +0000 flight 175546 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/175546/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 173462 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine 8 reboot fail REGR. vs. 173462 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux 88603b6dc419445847923fcb7fe5080067a30f98 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 86 days Failing since 173470 2022-10-08 06:21:34 Z 86 days 178 attempts Testing same since 175546 2023-01-01 23:13:03 Z 0 days 1 attempts ------------------------------------------------------------ 3255 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 497012 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Jan 02 10:08:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 Jan 2023 10:08:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470266.729713 (Exim 4.92) (envelope-from ) id 1pCHjq-0005zy-1S; Mon, 02 Jan 2023 10:08:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470266.729713; Mon, 02 Jan 2023 10:08:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCHjp-0005zr-Tj; Mon, 02 Jan 2023 10:08:13 +0000 Received: by outflank-mailman (input) for mailman id 470266; Mon, 02 Jan 2023 10:08:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCHjo-0005zh-Ud; Mon, 02 Jan 2023 10:08:12 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCHjo-0001SM-S6; Mon, 02 Jan 2023 10:08:12 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCHjo-0005vg-4O; Mon, 02 Jan 2023 10:08:12 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pCHjo-0000gO-3u; Mon, 02 Jan 2023 10:08:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=2LvjWK3IGqL/Bb5c+K2iyJINb+Qfm0zRQLtCPPuyinI=; b=NtjE/Lg5GNHkV8wVi41X/7pwvX P77P71K4AVs3DnNM9k6S8BiZtBmahbcfmcHjZ6YicSSKaiK7KejEbVW6UKKMbqeh1q+oLkStDCaNV B3E2Lh13EA3Z8mQ3E6U/GDz+08zO9WR6YAYHMCrVtPujN+0G38kArdv3bPmVwpqYgN7A=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 175548: trouble: broken/fail/pass X-Osstest-Failures: xen-unstable:test-amd64-amd64-libvirt-pair::broken:regression xen-unstable:test-amd64-amd64-libvirt-pair:host-install/src_host(6):broken:heisenbug xen-unstable:test-amd64-i386-freebsd10-amd64:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-livepatch:xen-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=7eef80e06ed2282bbcec3619d860c6aacb0515d8 X-Osstest-Versions-That: xen=7eef80e06ed2282bbcec3619d860c6aacb0515d8 From: osstest service owner Date: Mon, 02 Jan 2023 10:08:12 +0000 flight 175548 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/175548/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-pair broken Tests which are failing intermittently (not blocking): test-amd64-amd64-libvirt-pair 6 host-install/src_host(6) broken pass in 175541 test-amd64-i386-freebsd10-amd64 7 xen-install fail pass in 175541 test-amd64-i386-livepatch 7 xen-install fail pass in 175541 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 175541 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175541 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 175541 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175541 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175541 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 175541 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 175541 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 175541 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 175541 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 175541 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175541 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 175541 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen 7eef80e06ed2282bbcec3619d860c6aacb0515d8 baseline version: xen 7eef80e06ed2282bbcec3619d860c6aacb0515d8 Last test of basis 175548 2023-01-02 01:54:04 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch fail test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair broken test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-libvirt-pair broken broken-step test-amd64-amd64-libvirt-pair host-install/src_host(6) Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Mon Jan 02 10:58:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 Jan 2023 10:58:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470277.729725 (Exim 4.92) (envelope-from ) id 1pCIW9-0002kx-TB; Mon, 02 Jan 2023 10:58:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470277.729725; Mon, 02 Jan 2023 10:58:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCIW9-0002kq-Op; Mon, 02 Jan 2023 10:58:09 +0000 Received: by outflank-mailman (input) for mailman id 470277; Mon, 02 Jan 2023 10:58:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCIW8-0002kk-34 for xen-devel@lists.xenproject.org; Mon, 02 Jan 2023 10:58:08 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCIW5-0002ro-8k; Mon, 02 Jan 2023 10:58:05 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pCIW5-0007Wf-2q; Mon, 02 Jan 2023 10:58:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=ObKuiq2kyQgt9UlGOidlvxa/0ITGglmtp5rnTLQ3o8c=; b=OBjT2xDwb5x/plFAci6CErolg3 8MgG/EfJYMhCSfktf3dbPZispRk4mKQt/YFq0vyqyWv66UUiZ9JzuohnrtKt5YA7te2V2Tge4ycw4 BxuUFOda0NNLOIFoGyg+FsHMuP3nr04aIIQyCVQ73jfh411E4HTLdkl1LSRR0f2rEO9Q=; Message-ID: <6c46401b-9fbd-b7e0-5f09-cdaec92beead@xen.org> Date: Mon, 2 Jan 2023 10:58:02 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [XEN PATCH v1 1/4] arch/riscv: initial RISC-V support to build/run minimal Xen To: Oleksii , Julien Grall Cc: Alistair Francis , Andrew Cooper , Anthony PERARD , Bob Eshleman , Connor Davis , Gianluca Guida , Stefano Stabellini , xen-devel@lists.xenproject.org References: <5d5ec5fbd8787ed8f86bf84a5ac291d07a20b307.1671789736.git.oleksii.kurochko@gmail.com> <3343c927-0f27-e285-5b6e-281c61939bb4@xen.org> <43d726761900ba3d8b4919fc29fe7cb1991ac656.camel@gmail.com> <540787f539e2620951ebbc7d0aa6767588e0e3ab.camel@gmail.com> From: Julien Grall In-Reply-To: <540787f539e2620951ebbc7d0aa6767588e0e3ab.camel@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 29/12/2022 08:45, Oleksii wrote: > Totally agree then. > I missed that there is .bss.*. > Actually I reworked a little bit xen.lds.S. As a basis I took xen.lds.S > from ARM and removed all arch specific sections. So xen.lds.S contains > stuff which isn't used for now (for example, *(.data.schedulers)) but > will be used in future. > Would it be better to go with the reworked linker script or remove > unneeded sections for now and make it get a linking warning/error when > sections will be used? I don't have a strong opinion either way. I would say what's the easiest for you. In the long term, we will want to have a common linker script. But that's a separate discussion and not a request for you to do it. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Jan 02 13:42:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 Jan 2023 13:42:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470286.729735 (Exim 4.92) (envelope-from ) id 1pCL4t-000219-PW; Mon, 02 Jan 2023 13:42:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470286.729735; Mon, 02 Jan 2023 13:42:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCL4t-000212-M0; Mon, 02 Jan 2023 13:42:11 +0000 Received: by outflank-mailman (input) for mailman id 470286; Mon, 02 Jan 2023 13:42:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCL4r-00020m-Oq for xen-devel@lists.xenproject.org; Mon, 02 Jan 2023 13:42:10 +0000 Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3f199e71-8aa3-11ed-91b6-6bf2151ebd3b; Mon, 02 Jan 2023 14:42:07 +0100 (CET) Received: from pps.filterd (m0174682.ppops.net [127.0.0.1]) by mx0b-0039f301.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 302Bx46E011991; Mon, 2 Jan 2023 13:41:52 GMT Received: from eur04-he1-obe.outbound.protection.outlook.com (mail-he1eur04lp2054.outbound.protection.outlook.com [104.47.13.54]) by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3mtd0uv746-3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 02 Jan 2023 13:41:52 +0000 Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23) by DB9PR03MB9709.eurprd03.prod.outlook.com (2603:10a6:10:459::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Mon, 2 Jan 2023 13:41:49 +0000 Received: from PA4PR03MB7136.eurprd03.prod.outlook.com ([fe80::2da6:6d63:389b:3552]) by PA4PR03MB7136.eurprd03.prod.outlook.com ([fe80::2da6:6d63:389b:3552%9]) with mapi id 15.20.5944.019; Mon, 2 Jan 2023 13:41:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3f199e71-8aa3-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QxO5o76k7CjUEU6rKKrq5RwfzDgbpnnwrNT6z5k537oR14SrE8C61Oycz18oAseHvZ5mfJVPJWAiqGbzvAf6WtNKcqLto4f8HZ9QWw0Aa1Xyay7WuO5n2azLMPYE5n+up7JuVXh61z1ntQL7NpDN1dRN8uX8z99LefuygMdoyhVSSkrOuEFl8PPx58VfIdoQD/PgyTze/YMO4G1TqX9pumEtbErIdRFjYc9tln8xP92nSfCi7ygEVvm44G/zF30Go8W5eS1hLo8dNblHsLBCd3ihFUxweQyzGpTB2r75WciMOaoqm2oe0ET/vo7c5bJ2Rdr3fCIhTrx+IBjaHdtmiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cIV9qnXRfvVgBfrc0HVcsMdFAbZxe0DZ7oyvFfhKedY=; b=OyKgCuMQiWAlZ80MzuCxTb5BV5m7N6DxFVfVmJcnrVuzV7yPFAR2DNZg98UNuLIu6II7/bqX78wXnGwAdkqwI3sLPDi8wyrrhLfcpXhKIBjIvZnvlAyqw1E70WsOPMyjP8qFB15hIf/AvEi3SSydbz0Q0qJ08rtBu26mMHaJ42lrFPyuCmJMOlmoc73cDiD7KEoyWm/ZkNXpS0bctlQpUFIqkFsA+dcKbUTeruuz2M3quMg5wH0UHkm422fc9mcSMl7eRRiiXj6j6wpj73+tgciZDtakctFbVGXLkpsGuJcdIlTm6jH5w/LKE/F55yfuY4axoZIQurkYogZ8YG8PTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cIV9qnXRfvVgBfrc0HVcsMdFAbZxe0DZ7oyvFfhKedY=; b=lm6SXYlSebGIE4OJ9EN9GySexcKaGRBtdfEQ/x13J2lS+m1haBrn9HM+JRVBdHcFmMi9NgfCnCYkwS4oRsmfjgM/Pp/BhL9+bl9/+2xRhKX8NbkBQ2JpNT8rEK52Dh9zCo1scOxpA5kSjNzXzOdZbhQmADgvRTNTYZ+c9g9JIwT5De9jwft0GVJmeX+ond7HcQVe++B1jVYDyUQOm3PwBEl8I0rfXIatq82OzrqiGt+1MEV41xJ8vDc/6Yuc7rWpHCYI7z5k2uGGTWFYpbyazqDQCyefpdTl4NBcT1QpxfL44hZyX/0Gzl1wYVxwh4tiIloMJ/CyhIMDW0pDD9Xccg== From: Oleksii Moisieiev To: "jgross@suse.com" CC: Oleksii Moisieiev , Stefano Stabellini , Oleksandr Tyshchenko , "xen-devel@lists.xenproject.org" , "linux-kernel@vger.kernel.org" , Sumit Semwal , =?iso-8859-1?Q?Christian_K=F6nig?= , "linux-media@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linaro-mm-sig@lists.linaro.org" Subject: [PATCH v1 2/3] dma-buf: add dma buffer release notifier callback Thread-Topic: [PATCH v1 2/3] dma-buf: add dma buffer release notifier callback Thread-Index: AQHZHq/2iAqVu94bUUyzCrbXi66OTA== Date: Mon, 2 Jan 2023 13:41:48 +0000 Message-ID: <835ecf35d2d2d1ea763fe25837f52297c83c511f.1672666311.git.oleksii_moisieiev@epam.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PA4PR03MB7136:EE_|DB9PR03MB9709:EE_ x-ms-office365-filtering-correlation-id: 6a772b46-7aa1-4f3f-dd01-08daecc71919 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: I6xZItbt6oR7HVPauOPDvu99ZgGdQHMCdkGOIK7Kf9Q67OhE2zJOil5CfaljTx7dGNpXpOL7iVBxiNA6cDipi83qifFGwuURzg0ogrKgNTtcaPFHeFUrFc308gr41XBMdaR6o5qI3hFXm0QxX6MMOsXkeg3gdozFIGVtyQ21cL9HCBlItZUcTbzFk5xzmK4xTrpy3evhOWQ6u/pjRS9jRApRLS3wPXK5VWRQuFeoRYB66LUvwCwsoWPwttdan2jw7GFgsJSwe5C2FLyPsXJVEChGO8Fby4TJFfND2Hos1MYb49wG8v5SRWwlm7Ye1qaW8HyvmG6o1+WdZrNm+u8K/X/wDWoLtrlCgQZTYO3dJ7w9HNUMHSfSQA76KMjqiKzjwVa75kDB0339uWOrRQH9uqhKdkm17k3p0lElizw/IeD6j8ZcJ6TtW9Ip1Bqki0aE1DgMHnf/K/xvdAVIwCnrhbeSubHqL1I+n/CtdxYAW6zIo4k4vSeGkqubyzuqKMVlxPBGTVYIv3PCDwDmXnNvPCEs4vgXXG2dEevKtpgdq9Hx8jBAUR1u1hN1wkW3HeUGnL47AhPZVSjbh2Z82WJ0vIydhVjQQo0HDzzbKCG9wuNr6TLWNkY/fSlr33cstWE2qjLGIfR/fPP6+PIyH35CP/ZHcLlHkol+qxAnqJzRHO0R5QUiu0hwzWP5zpsw3FZq6FBDj/GLll8rrIWm8aHqp2jRryQgsZ8t4zXmPuWzv9o= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(136003)(376002)(39860400002)(366004)(451199015)(38100700002)(122000001)(86362001)(8676002)(38070700005)(66476007)(76116006)(66946007)(64756008)(66446008)(66556008)(6916009)(91956017)(4326008)(41300700001)(54906003)(316002)(2906002)(5660300002)(8936002)(2616005)(83380400001)(6512007)(478600001)(71200400001)(6486002)(6506007)(26005)(55236004)(186003)(36756003)(22166006);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?ZSgpoXOX/ZZA1Vgo0MZN1aN//8+zLiN43kF69YgxoeR8frlg8vwJu7x+fX?= =?iso-8859-1?Q?xSVVGWVO+q9rOqDQ9N4W9nEqQNi2I9DBQGEKkGFY8lAvbuko1m+1Gx5nOz?= =?iso-8859-1?Q?3crIq0sE206KoIUQn0Gcbiw227Jw/43zylM2WeSxpdk6zwcRcJnD0STJav?= =?iso-8859-1?Q?d/srqcdvx+np25XIsevDxDjp870UXFPTrf3IRdhamWSbZwn9pgYQ0oT+1M?= =?iso-8859-1?Q?LET6oOcFfHtashYQ5Ng8LTGXAvTg/w/wIg7iYFJ1valtosgTq75RFPu+92?= =?iso-8859-1?Q?IIszRPLSm4D91jgr7DjKgKv/9HG6Lg9ybkjaHxqhb3gLBMpdkw0dd0XqHT?= =?iso-8859-1?Q?NTQKTXDjW3FlDAtpd5+4XcJZN5wduuVwzxyoGekNeWG2OO9/l4kZGi98JD?= =?iso-8859-1?Q?vhr3wvyfwqQzsRM9uZaMd/uxb6J5zNpUoL1xB+ZhaoZ3k1NElO7VKihYXy?= =?iso-8859-1?Q?fWDVlte/YoQvR8qFxGBDpemv1eDSLI4Re20GqnMbZdxSlLWmi74SuUnRKe?= =?iso-8859-1?Q?v5xBmPRUYMWPoCuV90hoUTsUI8mcxYsbkXd4DD9slIZCXeeSqHCjl15nZV?= =?iso-8859-1?Q?GB3bo4PcmzpxcilJ+XCBDaxaRXge5YFVfEPqaYRq1bjDAZn+r6cJNuORoe?= =?iso-8859-1?Q?bjHEWBPyYuKKjqtiuGQIggyAJFzcImJgGATOGwTGAk8WE1z2CACo1yzYm0?= =?iso-8859-1?Q?TyC9xvxMFRFUApNvf8KzQEb9h++X1yaF2QgM+KNdzTq2UtW0WeiuOx8b9g?= =?iso-8859-1?Q?iW26H4jd29TMsxLttDkCPzvAkLfth484McHNtMx/+KDocsuFCzGMM6osmW?= =?iso-8859-1?Q?rUnNVTgAww+E+CLXCezs+SXKFtpGPib4fV9kOIQBVN0QKmspbCo3+wiy1p?= =?iso-8859-1?Q?CuYE/FmvVd65LYXWy46+nHpljHzWQ1cc6T09tMUM1+OT0W/dyuvbUkveRR?= =?iso-8859-1?Q?SsFMhvX1Od9GbwHyYkoH7f53dOQNk9xlNsa9rXM8OxCRsuB/fAGnJUcvky?= =?iso-8859-1?Q?sU2DkExSpeJ8pYZl1lJtpZT2Qd4jdHxy2aSgjxME/UEMH9krvlW10q7a0q?= =?iso-8859-1?Q?5x+y3o0nZQUysNTjISbrddrugIr8UWRiPI+ftxgTG/zc5g3ch69oq43157?= =?iso-8859-1?Q?kvQGca/mbT46Lc1zuM8vLC/B5HwRv0Hwx6l6a707EGl6chP7GbF0wHULp/?= =?iso-8859-1?Q?wbwK+THDjqzspYRZWtguxMKTZGLCvj7uP0vJ2rJQl6Oq1quyMsT4Baf0ik?= =?iso-8859-1?Q?PtZkubNMOn7EXCY8t+v3DzH/Y3bBoBOQsQQwpsx3Wt/hxUx2u9oj2aOoSn?= =?iso-8859-1?Q?nUoVeI+uEXZ6ifqg73aVy7Fs4lkz1VtJ2h3TqukUoS3zJnOGGcKX2Q/FYE?= =?iso-8859-1?Q?Ry0RQA83pZWnjqGrODWrhSPtD15MVFqEmiaFC0pQnWQ0710f5gxDNITEQk?= =?iso-8859-1?Q?GK71JA9yeagTmfH2B47Anu1Pigjzi0q9+Nxc+thr52VW2ZuFlFNDUNT4DW?= =?iso-8859-1?Q?70JOX5LB9vjGFeuefKeoxBKBMe8okVWvG/S58DURQwul6XywvvH7nIPbEe?= =?iso-8859-1?Q?d3ynZ5XCGF/MuTDMJxaE4OSoFgQ9CxfJhEe3jHmzo8JGW/y+L/EGeEj77W?= =?iso-8859-1?Q?DzrgnbHaz9y2LKMm61n4Q3bHmF5Pe19SL0jC32gwVMOlRULlCDYWk3vA?= =?iso-8859-1?Q?=3D=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6a772b46-7aa1-4f3f-dd01-08daecc71919 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jan 2023 13:41:48.9962 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: TQbH5ZtPMRkf5Lq6Jdo1NpaaN0V7CSgdcxJfYDDOXQM4wc1apBGOrkf7D/qZ/5DSjk5C2bFAufoxpe7okefYoO8K7PdqQLH7QRo332Az9W8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR03MB9709 X-Proofpoint-GUID: OvaobUQFU99AdHxtz2tas7SLtdW6NrxG X-Proofpoint-ORIG-GUID: OvaobUQFU99AdHxtz2tas7SLtdW6NrxG X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2023-01-02_08,2022-12-30_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 phishscore=0 lowpriorityscore=0 bulkscore=0 impostorscore=0 spamscore=0 priorityscore=1501 adultscore=0 suspectscore=0 mlxscore=0 malwarescore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301020124 Add posibility to register callback on dma-buffer which is called before dma_buf->ops->release call. This helps when external user of the dma buffer should be notified before buffer releases without changing dma-buf ops. This is needed when external dma buffer is used as backing storage for gntdev refs export and grant refs should be unmapped before dma buffer release. Signed-off-by: Oleksii Moisieiev --- drivers/dma-buf/dma-buf.c | 44 +++++++++++++++++++++++++++++++++++++++ include/linux/dma-buf.h | 15 +++++++++++++ 2 files changed, 59 insertions(+) diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c index efb4990b29e1..3e663ef92e1f 100644 --- a/drivers/dma-buf/dma-buf.c +++ b/drivers/dma-buf/dma-buf.c @@ -25,6 +25,7 @@ #include #include #include +#include #include =20 #include @@ -57,6 +58,46 @@ static char *dmabuffs_dname(struct dentry *dentry, char = *buffer, int buflen) dentry->d_name.name, ret > 0 ? name : ""); } =20 +int dma_buf_register_release_notifier(struct dma_buf *dmabuf, + ext_release_notifier_cb ext_release_cb, void *priv) +{ + int ret =3D 0; + + spin_lock(&dmabuf->ext_release_lock); + + if (dmabuf->ext_release_cb) { + ret =3D -EEXIST; + goto unlock; + } + + dmabuf->ext_release_cb =3D ext_release_cb; + dmabuf->ext_release_priv =3D priv; + unlock: + spin_unlock(&dmabuf->ext_release_lock); + return ret; +} +EXPORT_SYMBOL_GPL(dma_buf_register_release_notifier); + +void dma_buf_unregister_release_notifier(struct dma_buf *dmabuf) +{ + spin_lock(&dmabuf->ext_release_lock); + dmabuf->ext_release_cb =3D NULL; + spin_unlock(&dmabuf->ext_release_lock); +} +EXPORT_SYMBOL_GPL(dma_buf_unregister_release_notifier); + +static void dma_buf_call_release_notifier(struct dma_buf *dmabuf) +{ + if (!dmabuf->ext_release_cb) + return; + + spin_lock(&dmabuf->ext_release_lock); + dmabuf->ext_release_cb(dmabuf, dmabuf->ext_release_priv); + spin_unlock(&dmabuf->ext_release_lock); + + dma_buf_unregister_release_notifier(dmabuf); +} + static void dma_buf_release(struct dentry *dentry) { struct dma_buf *dmabuf; @@ -75,6 +116,8 @@ static void dma_buf_release(struct dentry *dentry) BUG_ON(dmabuf->cb_in.active || dmabuf->cb_out.active); =20 dma_buf_stats_teardown(dmabuf); + dma_buf_call_release_notifier(dmabuf); + dmabuf->ops->release(dmabuf); =20 if (dmabuf->resv =3D=3D (struct dma_resv *)&dmabuf[1]) @@ -642,6 +685,7 @@ struct dma_buf *dma_buf_export(const struct dma_buf_exp= ort_info *exp_info) init_waitqueue_head(&dmabuf->poll); dmabuf->cb_in.poll =3D dmabuf->cb_out.poll =3D &dmabuf->poll; dmabuf->cb_in.active =3D dmabuf->cb_out.active =3D 0; + spin_lock_init(&dmabuf->ext_release_lock); =20 if (!resv) { resv =3D (struct dma_resv *)&dmabuf[1]; diff --git a/include/linux/dma-buf.h b/include/linux/dma-buf.h index 71731796c8c3..6282d56ac040 100644 --- a/include/linux/dma-buf.h +++ b/include/linux/dma-buf.h @@ -287,6 +287,8 @@ struct dma_buf_ops { void (*vunmap)(struct dma_buf *dmabuf, struct iosys_map *map); }; =20 +typedef void (*ext_release_notifier_cb)(struct dma_buf *dmabuf, void *priv= ); + /** * struct dma_buf - shared buffer object * @@ -432,6 +434,15 @@ struct dma_buf { */ struct dma_resv *resv; =20 + /** @ext_release_cb notififier callback to call on release */ + ext_release_notifier_cb ext_release_cb; + + /** @ext_release_priv private data for callback */ + void *ext_release_priv; + + /** @ext_release_lock spinlock for ext_notifier helper */ + spinlock_t ext_release_lock; + /** @poll: for userspace poll support */ wait_queue_head_t poll; =20 @@ -632,4 +643,8 @@ int dma_buf_mmap(struct dma_buf *, struct vm_area_struc= t *, unsigned long); int dma_buf_vmap(struct dma_buf *dmabuf, struct iosys_map *map); void dma_buf_vunmap(struct dma_buf *dmabuf, struct iosys_map *map); + +int dma_buf_register_release_notifier(struct dma_buf *dmabuf, + ext_release_notifier_cb ext_release_cb, void *priv); +void dma_buf_unregister_release_notifier(struct dma_buf *dmabuf); #endif /* __DMA_BUF_H__ */ --=20 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Jan 02 13:42:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 Jan 2023 13:42:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470288.729746 (Exim 4.92) (envelope-from ) id 1pCL4u-00028V-Ac; Mon, 02 Jan 2023 13:42:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470288.729746; Mon, 02 Jan 2023 13:42:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCL4u-00026Y-3h; Mon, 02 Jan 2023 13:42:12 +0000 Received: by outflank-mailman (input) for mailman id 470288; Mon, 02 Jan 2023 13:42:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCL4s-00020m-W3 for xen-devel@lists.xenproject.org; Mon, 02 Jan 2023 13:42:10 +0000 Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3fe4c446-8aa3-11ed-91b6-6bf2151ebd3b; Mon, 02 Jan 2023 14:42:08 +0100 (CET) Received: from pps.filterd (m0174682.ppops.net [127.0.0.1]) by mx0b-0039f301.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 302Bx46D011991; Mon, 2 Jan 2023 13:41:52 GMT Received: from eur04-he1-obe.outbound.protection.outlook.com (mail-he1eur04lp2054.outbound.protection.outlook.com [104.47.13.54]) by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3mtd0uv746-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 02 Jan 2023 13:41:51 +0000 Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23) by DB9PR03MB9709.eurprd03.prod.outlook.com (2603:10a6:10:459::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Mon, 2 Jan 2023 13:41:48 +0000 Received: from PA4PR03MB7136.eurprd03.prod.outlook.com ([fe80::2da6:6d63:389b:3552]) by PA4PR03MB7136.eurprd03.prod.outlook.com ([fe80::2da6:6d63:389b:3552%9]) with mapi id 15.20.5944.019; Mon, 2 Jan 2023 13:41:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3fe4c446-8aa3-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EH7Q1ygdq8hb6QLZQg+FO3oVGM0vm/dgC8rYDMaCGbqIzXkBuWvCcCjEkT9BLFqskHwaumIyq3O3nt6S5Lv7I20UGLq5EbJEuzTyi4uAGvxCefF2eJ+MLBNKzcGQCMf99/O6b+D/cvmd1SOTEBLp7S5aSdrAICK71R/mpn+6dPMsNBX9SvNqhNas0XK59rwP+6JqZz6b8q8+ito9T2Q97MSKzUYHfnpWR1KMBwizuOo6HjMPZZL6snO3eWsUlI+d3zRu+9cGTFheT0qcGXU+/YLlh1I79DJOB+VbOub05RYYlQ3TvBxRSNAp4DZQG2EoyCpsMwrK/QjvIfQcEebgkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=upLENppnbaOJqNZ7wAgRPaS772ApiRNNpeCnQADukok=; b=h+zfyrOORIykAmzlkpyogetoAix8Ex/PKUn+FKR/CFwgSrN2riv/nmkccGuDkFF3iiK9iWQe4JH40PFdW3gVJQEqnW3kaaGslapFEmRK/TraLd/VkjPYvKzhHc9aCfG7l/LljrHRLbsIZN4YNplomA3lqaUPLyMRuTyv39tjSkBm4Ko4k2vNmtjtlXIBF4EDigFUpgo5qiSl30DEz2m9ro3GF2XAHRxccHCCeMtd+eeMWzpe7xFrvksY2hejLBl8G0Lkv2341IL6xZ1hUE+aloTtaisvD3JqTfwBOK8rQ+DZVOtP83gFWo1r5OFzyV+B5k7px/Hh7RzcV7YOA9L8ww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=upLENppnbaOJqNZ7wAgRPaS772ApiRNNpeCnQADukok=; b=T3oL8E80Zu6y5uljNdl6ASKZKYjjEA7AvCxRY+i21xtxiBfvjMG6/xT7U1cxnRV8lE86tjF/e6m7K0WSOpKufW2F26xxojhuABWsRb9Rdktjhc9cFPEfgcVpTiLOWy350xpe2P9Tb2eXTIs7kvUmoOuOUXre2jiercXn7OwfUsXdDUa48eBYSKuWR4trfV7gAhRp6gSvM8JJhEtgWUpo/9Y71yLuG4xGOvkI1CvXsSA2dU0+dGAeyRGFM6zAuqb440w9PlqSo0KFmegGnGw7qbB41zxXhotEha0P45ur/8uCbWEGqGTmJVe3xyippsarZ1xnEtawF+otzRYHSeUnlg== From: Oleksii Moisieiev To: "jgross@suse.com" CC: Oleksii Moisieiev , Stefano Stabellini , Oleksandr Tyshchenko , "xen-devel@lists.xenproject.org" , "linux-kernel@vger.kernel.org" , Sumit Semwal , =?iso-8859-1?Q?Christian_K=F6nig?= , "linux-media@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linaro-mm-sig@lists.linaro.org" Subject: [PATCH v1 1/3] xen/grant-table: save page_count on map and use if during async unmapping Thread-Topic: [PATCH v1 1/3] xen/grant-table: save page_count on map and use if during async unmapping Thread-Index: AQHZHq/2VrVTMTTaekaw3MeMlNz4/w== Date: Mon, 2 Jan 2023 13:41:48 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PA4PR03MB7136:EE_|DB9PR03MB9709:EE_ x-ms-office365-filtering-correlation-id: 01aafa7a-9d3f-4d4e-013e-08daecc718ea x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qufCfaYw3n7K5GBDOfPY8lJ0s2EbpdNaaVh1FB2Pw+YoK5QwbfcpPET4AXM5Toz2dzO9dIr+DdNC4joci4/RzuhGLqi21535Yz3P3srG6Lpcnh7CUF2hJv/HHJIo0FYK7JNW0GwdhZT8nsBTZUNHceKZjm5bn/VOJRDshf278kimt9ZzSTXviP06ZWob69c/WnQGL5BMf34w91h10zbmqzZwUdRBsgn44uTXvUfabiQWwUdSUvqiZfxXh7MADOPECKVxUZpOM+ev0TJxcSh9SFuc2DE9zKdog0Ikyu9z+yKmTFvPtmmAb5B+PqNXAtO8c/7NqDZLxOjEnXUq1yJO00YW3fodzAxmUGKLwvsS0s1kIr3BsboABlbV5GsHXpJlano+8KhyfZYdjFzYqPFo21E+sg5CTewTHHOL7kLIJkwQEpAJaC4XCTxhA/SLDVpj6ZCCnAzR89BcHAbZeXMQyB2Hjwi+q+/YDnZix3Vsht6ar5afyQ0WGDdtD08a3BCnkOAZ3g+WgyqselwMRSFAVdlRLIVolZKEsWGR8iwB3eEXrak1oySjbeKAjKnaVScUQDaILO8fZ/9v6KZQz/ic05R5cFDigD6yCyMTnU6xaQWRkCEakZ/7/gyGCyVciq/zys1pLiMmM3pGFA4XlGHpy9WESyonSwVWHzF22oyBXuxZC+T/5ValxPLViewW81d699ESQS/SFiQXon855al4XyCzxm+4AUow5YOHP5/f9ao= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(136003)(376002)(39860400002)(366004)(451199015)(38100700002)(122000001)(86362001)(8676002)(38070700005)(66476007)(76116006)(66946007)(64756008)(66446008)(66556008)(6916009)(91956017)(4326008)(41300700001)(54906003)(316002)(2906002)(5660300002)(8936002)(2616005)(83380400001)(6512007)(478600001)(71200400001)(6486002)(6506007)(26005)(55236004)(186003)(36756003)(22166006);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?dANsysGQdFemPfZPLN3R5/iueQyffU7Aefc222DGZ8engqUXxDYFqDhhWs?= =?iso-8859-1?Q?klXBmUqO8vdTsG9eOYChTyQ3+PL/+hhuseX0TkGSJKfjWL5yL1FxZI3DLL?= =?iso-8859-1?Q?LNWx8q2ucibwxBygufAWID7zKm+cikKSS2rG1pejj+wR1TIuu+K4jplG65?= =?iso-8859-1?Q?gFh/+hDBrmYEOHMFr+uTX/Lh8QwwaB/6qHCUjgRwIdlHc3a3UYM96ErdWU?= =?iso-8859-1?Q?QOvxwx+ofVp73MmjqxruCfkoSXCYr6T3sXHXGJRNK6L5zKsa8qmeIqt7Zb?= =?iso-8859-1?Q?ZwrLGQMJPVB0+P6bg4yghqhyj69aQHwy0x6O94ezPzNMmQYcIMdO+ekY3u?= =?iso-8859-1?Q?TKEWrbhJMy+Smzzu52UFjuCq5NTQdEoX1mhiEvnomzVaryP9ZqHooMRPTT?= =?iso-8859-1?Q?2p9XEorxFULahLRpfxbZUE28+dnNoLxy3DwrzLfP2YecjeBmwxewRXbxMl?= =?iso-8859-1?Q?Q3g+1N68v6lKIRYINDvORC2v7aSOodhMMxcd1Fto72kkDvuQgDrnY27u55?= =?iso-8859-1?Q?8OmEd4flK0bQ2jx2sFB5LzGQFN6jUcJIKVIoUyM0lSuHQY+/6PKUKfp/IT?= =?iso-8859-1?Q?hCgXV/xWkEELFj5S8nu+/znOyxSwEWeXHshjI5VUt45VhiCvHaHNFzkoQM?= =?iso-8859-1?Q?VCcKqsJpv+w8qy4aC+O/zHSn88lQWNbMgd8YYWfRgM75keJMuZbWA1lHQr?= =?iso-8859-1?Q?DOnSVB7uyVzulo/R3rWzsTR6oXTE7k3smf49EChQUJRzono5yFwXGDKCfZ?= =?iso-8859-1?Q?Sw4/+83oz2cTfxyPYnd/AFfj+M5himSq/t282B5M00TU4Xz3b8YgeDs3Qg?= =?iso-8859-1?Q?J3ZBI/2oaAh5nWD9Y+7758VlM/ANYR9Aj46qDx+FOZzJN0cE/xwggKnVDT?= =?iso-8859-1?Q?0lX616JttIsRpZ0MYz0cDn+Z388IrOdy9tqgiGe3wvEZFujLz3XRxnyVlz?= =?iso-8859-1?Q?xRHIhUGyj6ii4r+jvD2KA8nvMV1mcxtbHkcKlzG9O5dn7+w1/pvVF8f8tI?= =?iso-8859-1?Q?nCJ/1SG18OlFiPoUQkKNXYi0gcjEdnxlIQ9Jp+Bt+NKwn9zr1VtjovfjPh?= =?iso-8859-1?Q?Rzun/CuzGk/fh2uuaVEadwIcntMwSGXrroTPLOiB17mDlUqd86F+lC/615?= =?iso-8859-1?Q?wEzM4vFGJo1gN5F/PmMfolS1kGUcXjVYdYC0wnTFtFlfW1BEZE9EW8MWmT?= =?iso-8859-1?Q?dQ/4u6JIBk/Kn8b9cXEOqmg2mcP6yGcIfARxp9CgDU9v9Zuwqe4Ut9v0iF?= =?iso-8859-1?Q?Q8QR4DIedxMgyTZPc6wfygq0+Prcu3CzYyAahoY7BAAROmXxKXvIuHxlx+?= =?iso-8859-1?Q?tWyMROlWn5GapUZEH34JKeVSD0H9TdnrT7yvsTncF5KCNdKVCtpOuoM+L1?= =?iso-8859-1?Q?PgL62+5zHNaB7PqzKmXwB0nwr9yOPIgblcWs1df9/tVt1syoCdf0YNcayZ?= =?iso-8859-1?Q?6706N9LqTL7QejzPhha14Lqym3usffPv8FSd80TdfyRJ5wv0ICxWXp8D/Y?= =?iso-8859-1?Q?gIqGHet/mIPyvNR10HTpJVUT1rXskt0g3Dc5EPWVM637dWaMp0SfhwOfT0?= =?iso-8859-1?Q?zyufy/nezBU2LaSsW2RaKNfl2Gp4tzoSSO3uoJzsHiIDy0pwY1tGcqeB1H?= =?iso-8859-1?Q?f/0OgvjdnGNOcLr6n/E1H018gdiz50V/9uefCUfa6ecGjGARXGxbNAOw?= =?iso-8859-1?Q?=3D=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 01aafa7a-9d3f-4d4e-013e-08daecc718ea X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jan 2023 13:41:48.6825 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kI1NPR1PtH+s/DzX1W50xaAwDmqfN4R/xQrpV0d+2vI3yUPaymI20bn90qI3J/4UWEJxnW+SL0clikRBIlzGek+KvB6SWXedvjDmoLuBIUU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR03MB9709 X-Proofpoint-GUID: mk6-_2x5bNgRKHNXlG71jmOCVvk0mvbE X-Proofpoint-ORIG-GUID: mk6-_2x5bNgRKHNXlG71jmOCVvk0mvbE X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2023-01-02_08,2022-12-30_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=902 phishscore=0 lowpriorityscore=0 bulkscore=0 impostorscore=0 spamscore=0 priorityscore=1501 adultscore=0 suspectscore=0 mlxscore=0 malwarescore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301020124 Save the reference count of the page before mapping and use this value in gntdev_unmap_refs_async() call. This is the enhancement of the commit 3f9f1c67572f5e5e6dc84216d48d1480f3c4fcf6 ("xen/grant-table: add a mechanism to safely unmap pages that are in use"). Safe unmapping mechanism defers page that may being use (ref count > 1). This is needed to allow to map/unmap pages, which have more than 1 reference. For example, DRM_IOCTL_MODE_CREATE_DUMB creates dma buffer with page_count =3D 2, which unmap call would be deferred while buffer exists because ref count will never equals 1. This means the buffer remains mapped during DRM_IOCTL_MODE_DESTROY_DUMB call which causes an error: Unable to handle kernel paging request at virtual address .... Call trace: check_move_unevictable_folios+0xb8/0x4d0 check_move_unevictable_pages+0x8c/0x110 drm_gem_put_pages+0x118/0x198 drm_gem_shmem_put_pages_locked+0x4c/0x70 drm_gem_shmem_unpin+0x30/0x50 virtio_gpu_cleanup_object+0x84/0x130 virtio_gpu_cmd_unref_cb+0x18/0x2c virtio_gpu_dequeue_ctrl_func+0x124/0x290 process_one_work+0x1d0/0x320 worker_thread+0x14c/0x444 kthread+0x10c/0x110 This enhancement allows to provide the expected page_count during map call so refs could be unmapped properly without unneeded defers. Signed-off-by: Oleksii Moisieiev --- drivers/xen/grant-table.c | 16 +++++++++++++++- include/xen/grant_table.h | 3 +++ 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c index e1ec725c2819..d6576c8b6f0f 100644 --- a/drivers/xen/grant-table.c +++ b/drivers/xen/grant-table.c @@ -1241,11 +1241,23 @@ int gnttab_map_refs(struct gnttab_map_grant_ref *ma= p_ops, case GNTST_okay: { struct xen_page_foreign *foreign; + int page_cnt; =20 SetPageForeign(pages[i]); foreign =3D xen_page_foreign(pages[i]); foreign->domid =3D map_ops[i].dom; foreign->gref =3D map_ops[i].ref; + page_cnt =3D page_count(pages[i]); + if (page_cnt > FOREIGN_MAX_PAGE_COUNT) { + /* foreign structure can't hold more than FOREIGN_MAX_PAGE_COUNT. + * That's why we save page_count =3D 1 so safe unmap mechanism will + * defer unmapping until all users stops using this page and let + * caller handle page users. + */ + pr_warn_ratelimited("page have too many users. Will wait for 0 on umap= \n"); + foreign->private =3D 1; + } else + foreign->private =3D page_cnt; break; } =20 @@ -1308,9 +1320,11 @@ static void __gnttab_unmap_refs_async(struct gntab_u= nmap_queue_data* item) { int ret; int pc; + struct xen_page_foreign *foreign; =20 for (pc =3D 0; pc < item->count; pc++) { - if (page_count(item->pages[pc]) > 1) { + foreign =3D xen_page_foreign(item->pages[pc]); + if (page_count(item->pages[pc]) > foreign->private) { unsigned long delay =3D GNTTAB_UNMAP_REFS_DELAY * (item->age + 1); schedule_delayed_work(&item->gnttab_work, msecs_to_jiffies(delay)); diff --git a/include/xen/grant_table.h b/include/xen/grant_table.h index e279be353e3f..8e220edf44ab 100644 --- a/include/xen/grant_table.h +++ b/include/xen/grant_table.h @@ -49,6 +49,7 @@ #include #include #include +#include =20 /* * Technically there's no reliably invalid grant reference or grant handle= , @@ -274,9 +275,11 @@ int gnttab_unmap_refs_sync(struct gntab_unmap_queue_da= ta *item); void gnttab_batch_map(struct gnttab_map_grant_ref *batch, unsigned count); void gnttab_batch_copy(struct gnttab_copy *batch, unsigned count); =20 +#define FOREIGN_MAX_PAGE_COUNT U16_MAX =20 struct xen_page_foreign { domid_t domid; + uint16_t private; grant_ref_t gref; }; =20 --=20 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Jan 02 13:42:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 Jan 2023 13:42:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470289.729768 (Exim 4.92) (envelope-from ) id 1pCL4v-0002kc-LZ; Mon, 02 Jan 2023 13:42:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470289.729768; Mon, 02 Jan 2023 13:42:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCL4v-0002kS-Hf; Mon, 02 Jan 2023 13:42:13 +0000 Received: by outflank-mailman (input) for mailman id 470289; Mon, 02 Jan 2023 13:42:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCL4t-00020m-W9 for xen-devel@lists.xenproject.org; Mon, 02 Jan 2023 13:42:12 +0000 Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3f6982ee-8aa3-11ed-91b6-6bf2151ebd3b; Mon, 02 Jan 2023 14:42:07 +0100 (CET) Received: from pps.filterd (m0174682.ppops.net [127.0.0.1]) by mx0b-0039f301.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 302Bx46F011991; Mon, 2 Jan 2023 13:41:53 GMT Received: from eur04-he1-obe.outbound.protection.outlook.com (mail-he1eur04lp2054.outbound.protection.outlook.com [104.47.13.54]) by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3mtd0uv746-4 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 02 Jan 2023 13:41:53 +0000 Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23) by DB9PR03MB9709.eurprd03.prod.outlook.com (2603:10a6:10:459::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Mon, 2 Jan 2023 13:41:49 +0000 Received: from PA4PR03MB7136.eurprd03.prod.outlook.com ([fe80::2da6:6d63:389b:3552]) by PA4PR03MB7136.eurprd03.prod.outlook.com ([fe80::2da6:6d63:389b:3552%9]) with mapi id 15.20.5944.019; Mon, 2 Jan 2023 13:41:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3f6982ee-8aa3-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NkZR2Py/TQGVGAtl5cGJv1VL4Uut2A5KCLn+PZA2+PahhoQxhJfFgBzXYobMhmnvwoQDDf1UPAPIAsKYUVz2VtVdIH28gm/63gX/KGa92kpexRt8qfbuTm34A0hcnDAxdR3W6kdBSPBZqNMgPNjRu2WYbg0v7Syvo3liHnR6TW/SE8iib0z9Sw/KFwelpQnen+080mK/wfas635JZy9b9xApywDMGlZkRkTdPYpRlX8Nm/NZaxuqr2yVOV9MmxM5C1mAOKUzmQPZl0TwKMZuWvxauR0Mfuj07U7Cojj0W3nnNCqaogfpxk4gdAMbLrJtjBAekEAGo+k1yWs189e3FA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cpM/GTVcMI8fqBjEBRN4Lty7tXpejC9G2s04LY0mrJs=; b=EEzdH3VRQ7JISgO3Pm+5rcqC6ss0N1f4FcqAxW5dcJmGSxaDB859fVc3LQ4f/Bdr/tnhen8I3FfVCcbqmj4jZcqPajiIzCpxry/oXPoEV0z5xjKCX7l14AxanffYJW4YyyyFc5GVBWXjPPe/okzQ13nsZtVgMFZLkT4Vn99ZKoslkVtzmHX4HT2psk9WzwNbrWZ8bsjeX4dXB6/EMstLiL2hL+7+PZPjMKBKcM4ziGsPKYhrIepHW4hk2BS1RHoRBE/4jhbMW8Sg6NyTh3fw6w5QTxvmQd3PBLTEmWgOKkn5syANpoOidPdWqXNii+7QS0dKLeR3Byexzhx0mamHnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cpM/GTVcMI8fqBjEBRN4Lty7tXpejC9G2s04LY0mrJs=; b=kyQSl3x6MrFAKpRga7jcWIrq4nfcd2PTWuhf4JjUdeSs3A7u8UN/ApDCsby083Ir7XLZ+4/4TJk9cCjrP/GxTX5sgqaDOnWgFWTeLQlciVCtrrIU9pCMA23IbTFnhZ1Y9G6bm/KJmVZ3iu+UpdaWL9iFvia+lrRYtvBGAO38poY+SDZbV+O3I2s+FFLzBv7h3mLk/JKYnPqFVfsjwJs3OJO+GPDZ5MHfjwP+PgouVa5bO1H+usu3J8P0l2Bb6bff0Xqpc8ACHazLsRrSugtkfpgMaEueGGmNh0ogmvkswRXcxd3Wgnmg1WTU3ZKQ80uBwG1qlMtPzVYPlhE1D5YRMw== From: Oleksii Moisieiev To: "jgross@suse.com" CC: Oleksii Moisieiev , Stefano Stabellini , Oleksandr Tyshchenko , "xen-devel@lists.xenproject.org" , "linux-kernel@vger.kernel.org" , Sumit Semwal , =?iso-8859-1?Q?Christian_K=F6nig?= , "linux-media@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linaro-mm-sig@lists.linaro.org" Subject: [PATCH v1 3/3] xen/grant-table: add new ioctls to map dmabuf to existing fd Thread-Topic: [PATCH v1 3/3] xen/grant-table: add new ioctls to map dmabuf to existing fd Thread-Index: AQHZHq/2ph/BnX8oTk+YEfKPDbopCA== Date: Mon, 2 Jan 2023 13:41:49 +0000 Message-ID: <157bd897b4dd50b3c724722090b804440914c3cf.1672666311.git.oleksii_moisieiev@epam.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PA4PR03MB7136:EE_|DB9PR03MB9709:EE_ x-ms-office365-filtering-correlation-id: 1c96edab-5a77-4b99-3495-08daecc71979 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fAYApRAI95RYBFTJ84xgUdQh8nwOqFcHmW6e4jmqZfdGqkMYneO/J61PZb2X53TTM6IsMtxHGOWXEqjpiqfknllLuklpWu8+7hYEAIReTjLzdPBw7upIOsmejItupVabytOWiyZW6TaLvjx1JDH0tZAe0l595aaVxXTGY8oWDpWF+DH94QgzqoscUNVHVEnHUkdz/xhybEd/v71F5nppfdeMgkuRe6djsWI+ApEJeTAymu9ZnmblPV7+JKY1ZdC9v62fsjVBAHoQ9tw04K3Q7JCSvkgA+E412eAh1E6Yo3tIUn6ITiNi5fGjl91fd38YanuTYZodEJ1Kvhvx57fwfs4xKi+zE1BnI6dW8qPPkyRbl5vMWmD/85BH+l7GJYhekfbTvTiGswc6TpVAL8xx8Fo5iLfe0TRK/uSR+a7pDH6cWYrCXvP24qt7DAWQSmC3C5INOs/QB3zuUHWDSIKOvQdq7eSKNzmR9LvWq/HKAZZcVWvJOsEIvb2d+UawzAr8uUrmwfu8XMIANhyFi1wqFwHwBu5FrLbNQ77b7PsiTaulriuKWMHaoX7jsdXu0l8AhhQx65Bb4zacsTMoO3KC9mN9Fb+ibKRsFXsd3AeGw/zDJJivIVsXKdmbti7VDsidzp1Z3st1VJq/VscBwS98eiQkWEC1TGm3Tvps7Fum1qqh9SklgWuLpcCNS31PfOZA5l9XgjNLuRI0xWKQYd1IN+qQEZTvASbhQPgP6eYm4J8Oi3QHsmx37Vp/EGJC+gyD x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(136003)(376002)(39860400002)(366004)(451199015)(38100700002)(122000001)(86362001)(8676002)(38070700005)(66476007)(76116006)(66946007)(64756008)(66446008)(66556008)(6916009)(91956017)(4326008)(41300700001)(54906003)(316002)(2906002)(5660300002)(8936002)(30864003)(2616005)(83380400001)(6512007)(478600001)(71200400001)(6486002)(6506007)(26005)(55236004)(186003)(36756003)(22166006)(21314003)(579004)(559001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?SiGlTnYNPDw2YpnUzSo6FpTU+eS1V6Hg5OD2RkL6vKuPrNo8IBCWnG0z7S?= =?iso-8859-1?Q?WBGx1espg5fyI3QzgfX7olheSlizTxfW5qdDpIqsJimXnwH3rfIvoNXkoy?= =?iso-8859-1?Q?XqJtIIiE/3ToUosbcI0LXN+Q5AvOheCg35ov2CL/As8sv/vvSALHr0TFnd?= =?iso-8859-1?Q?UlmStJ9KuIBsmPqwOcunDnRWvkBgUcUgZMtVKWqXMFexIhhKwQl4XjTxSE?= =?iso-8859-1?Q?r2zwAt7JGRGSx0VhqhFyd+socMt5My6h4oP07SGvxnKj7TSqym8MjXUv/+?= =?iso-8859-1?Q?DI4d69HysRmUpP0uFgfrxfVsAdbOcrDkSgSkOsURxE7SiqrFm+PWG9mNxH?= =?iso-8859-1?Q?SCPmqQOOaRLDx7sOpZ7+K9B+gvahNYRBndIht8m09aSlOPWueDGUU/4uH9?= =?iso-8859-1?Q?+XIP19g8B9ry2b83Zy6bIA3Liun1+RLJLqZ9HrZrq2rOY5E6RSVkimzM+l?= =?iso-8859-1?Q?nzHtvxx/F3OfFMbFcWEk0jDZEQcdwqFUQMFISGmU2S+kU37B98UPtBTAVD?= =?iso-8859-1?Q?4XdR2IEguZN5MBtVIXdUEpb7hNu0aB6o/9jWtA3em9NdPDionCaIw1z1Il?= =?iso-8859-1?Q?oDGQ693RDtgG7v+tsPRC96iYJkaUzqIVxz4hrDgeOcOV+CoV3bOacyrv/y?= =?iso-8859-1?Q?ylKYGU7eyVj0bbDqf46aUj2IVlq4wviiGk3fEYuCcnQbuOro+LWP2jJoYi?= =?iso-8859-1?Q?+F78DqHY8TKbvvlFTPEi4kaLysLqIMg8KRk2KQBNRGx+v94swe5jw0uebs?= =?iso-8859-1?Q?GjNsf3PG0fmBYyjT7rG9+Ya8YCKDUcUB7pm19dcg95Gi4rmiX9Yo8pkdHr?= =?iso-8859-1?Q?0sOY7Szifb2rXh5AbbhKG5bETxeamg0F/vGjgCrALjwY7A2ifW9URopXeu?= =?iso-8859-1?Q?6sBlEfCl2VwIxGmwmWUXryiZgRlklZ/VFmx9Ww0KqF9ukVWKtOnGcm6vca?= =?iso-8859-1?Q?3Xwt8TtNQQxDtWZhiUpJZvFdF4SwkCP48qmGo5DwsDL4EFzGvGvIc9/2iu?= =?iso-8859-1?Q?LrEW+9HObIFTZPLEEwX8KSXSsChpxzrKhADvZws56emjs0GieP45wR4sfu?= =?iso-8859-1?Q?0Mqr5KdqXaDg9mr9wtjpc194o7WNZqGdKADYa1yvwDGdd2mOV6AG6t3FdG?= =?iso-8859-1?Q?OOw2l9KFW4giqjZONbNPCRDdXOlQ+mBI7UyoYc5UkuE+L/1VPBvwLTniNO?= =?iso-8859-1?Q?YzJAs4W6Lf+p4zePK7D4v2AVf0Tv5HO/5Fm0hfy7a9Wm6KJ4QaVyyKa9An?= =?iso-8859-1?Q?8/mLO5BpQrzdo/9zLsTDjnoF7jZVGaPkzLQ8IBDY+nVN6xmzZFRtyq+R0j?= =?iso-8859-1?Q?pcjxgUPYZx/PieIoKhbcg8feNMUG/gk3+VtGsDsH/xXhrlEk/CCPl3+df5?= =?iso-8859-1?Q?KuAPCG4bLtvxrdnotVskz37kiofFcIhmpfbdbBjihdv2REoVwJO5CFMbRc?= =?iso-8859-1?Q?roAx6vDRp6jZ2PTddgCwlU3Lx/8G/2tibtqfLIXq5y7LDLPBeYrXEC4W13?= =?iso-8859-1?Q?qqjZ9aQhOQdlU/vGbjsjuW4PsPHIPng7Syi4Hpl92p/1P4a/RxQKSuY56M?= =?iso-8859-1?Q?UZmIBd2cDqkhqUQWFXWqcFLR2n32uaQvyG7q60eb5CEdymGDbPlYbPw3FA?= =?iso-8859-1?Q?2+SDqBbY+WHRph7Lg7/ZyTLn04nfk2kZ0IGbKXItgLvqXWr9osn9ygoA?= =?iso-8859-1?Q?=3D=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1c96edab-5a77-4b99-3495-08daecc71979 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jan 2023 13:41:49.5742 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kgZ/vtfEM6LlGzuqzZbCumY3cAdnlx9y0l19k7z+nFTx/NM3mYE1FHEWj5HVsRXv4EsKbXXLQ6aU7sRFK9pQuJq363AyXdHlrfgtaAbpv0w= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR03MB9709 X-Proofpoint-GUID: zqExVzAwob7QUgCeIbSNQg5wp2GNIpKB X-Proofpoint-ORIG-GUID: zqExVzAwob7QUgCeIbSNQg5wp2GNIpKB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2023-01-02_08,2022-12-30_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 phishscore=0 lowpriorityscore=0 bulkscore=0 impostorscore=0 spamscore=0 priorityscore=1501 adultscore=0 suspectscore=0 mlxscore=0 malwarescore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301020124 Add new ioctls to allow gntdev to map scatter-gather table on top of the existing dmabuf, referenced by file descriptor. When using dma-buf exporter to create dma-buf with backing storage and map it to the grant refs, provided from the domain, we've met a problem, that several HW (i.MX8 gpu in our case) do not support external buffer and requires backing storage to be created using it's native tools. That's why new ioctls were added to be able to pass existing dma-buffer fd as input parameter and use it as backing storage to export to refs. Following calls were added: IOCTL_GNTDEV_DMABUF_MAP_REFS_TO_BUF - map existing buffer as the backing storage and export it to the provided grant refs; IOCTL_GNTDEV_DMABUF_MAP_RELEASE - detach buffer from the grant table and set notification to unmap grant refs before releasing the external buffer. After this call the external buffer should be detroyed. IOCTL_GNTDEV_DMABUF_MAP_WAIT_RELEASED - wait for timeout until buffer is completely destroyed and gnt refs unmapped so domain could free grant pages. Signed-off-by: Oleksii Moisieiev --- drivers/xen/gntdev-common.h | 8 +- drivers/xen/gntdev-dmabuf.c | 416 +++++++++++++++++++++++++++++++++++- drivers/xen/gntdev-dmabuf.h | 7 + drivers/xen/gntdev.c | 101 ++++++++- drivers/xen/grant-table.c | 57 +++-- include/uapi/xen/gntdev.h | 62 ++++++ include/xen/grant_table.h | 5 + 7 files changed, 626 insertions(+), 30 deletions(-) diff --git a/drivers/xen/gntdev-common.h b/drivers/xen/gntdev-common.h index 9c286b2a1900..3b6980df3f9d 100644 --- a/drivers/xen/gntdev-common.h +++ b/drivers/xen/gntdev-common.h @@ -61,6 +61,10 @@ struct gntdev_grant_map { bool *being_removed; struct page **pages; unsigned long pages_vm_start; + unsigned int preserve_pages; + + /* Needed to avoid allocation in gnttab_dma_free_pages(). */ + xen_pfn_t *frames; =20 #ifdef CONFIG_XEN_GRANT_DMA_ALLOC /* @@ -73,8 +77,6 @@ struct gntdev_grant_map { int dma_flags; void *dma_vaddr; dma_addr_t dma_bus_addr; - /* Needed to avoid allocation in gnttab_dma_free_pages(). */ - xen_pfn_t *frames; #endif =20 /* Number of live grants */ @@ -85,6 +87,8 @@ struct gntdev_grant_map { =20 struct gntdev_grant_map *gntdev_alloc_map(struct gntdev_priv *priv, int co= unt, int dma_flags); +struct gntdev_grant_map *gntdev_get_alloc_from_fd(struct gntdev_priv *priv= , + struct sg_table *sgt, int count, int dma_flags); =20 void gntdev_add_map(struct gntdev_priv *priv, struct gntdev_grant_map *add= ); =20 diff --git a/drivers/xen/gntdev-dmabuf.c b/drivers/xen/gntdev-dmabuf.c index 940e5e9e8a54..71d3bfee72aa 100644 --- a/drivers/xen/gntdev-dmabuf.c +++ b/drivers/xen/gntdev-dmabuf.c @@ -10,14 +10,18 @@ =20 #include #include +#include #include +#include #include #include #include #include +#include =20 #include #include +#include =20 #include "gntdev-common.h" #include "gntdev-dmabuf.h" @@ -46,6 +50,18 @@ struct gntdev_dmabuf { /* dma-buf attachment of the imported buffer. */ struct dma_buf_attachment *attach; } imp; + struct { + /* Scatter-gather table of the mapped buffer. */ + struct sg_table *sgt; + /* dma-buf attachment of the mapped buffer. */ + struct dma_buf_attachment *attach; + /* map table */ + struct gntdev_grant_map *map; + /* frames table for memory reservation */ + xen_pfn_t *frames; + + struct gntdev_priv *priv; + } map; } u; =20 /* Number of pages this buffer has. */ @@ -57,6 +73,7 @@ struct gntdev_dmabuf { struct gntdev_dmabuf_wait_obj { struct list_head next; struct gntdev_dmabuf *gntdev_dmabuf; + int fd; struct completion completion; }; =20 @@ -72,6 +89,10 @@ struct gntdev_dmabuf_priv { struct list_head exp_wait_list; /* List of imported DMA buffers. */ struct list_head imp_list; + /* List of mapped DMA buffers. */ + struct list_head map_list; + /* List of wait objects. */ + struct list_head map_wait_list; /* This is the lock which protects dma_buf_xxx lists. */ struct mutex lock; /* @@ -88,6 +109,64 @@ struct gntdev_dmabuf_priv { =20 static void dmabuf_exp_release(struct kref *kref); =20 +static struct gntdev_dmabuf_wait_obj * +dmabuf_map_wait_obj_find(struct gntdev_dmabuf_priv *priv, int fd) +{ + struct gntdev_dmabuf_wait_obj *obj, *ret =3D ERR_PTR(-ENOENT); + + mutex_lock(&priv->lock); + list_for_each_entry(obj, &priv->map_wait_list, next) + if (obj->fd =3D=3D fd) { + pr_debug("Found gntdev_dmabuf in the wait list\n"); + ret =3D obj; + break; + } + mutex_unlock(&priv->lock); + + return ret; +} + +static void dmabuf_exp_wait_obj_free(struct gntdev_dmabuf_priv *priv, + struct gntdev_dmabuf_wait_obj *obj); + +static int +dmabuf_map_wait_obj_set(struct gntdev_dmabuf_priv *priv, + struct gntdev_dmabuf *gntdev_dmabuf, int fd) +{ + struct gntdev_dmabuf_wait_obj *obj; + + obj =3D dmabuf_map_wait_obj_find(gntdev_dmabuf->priv, fd); + if ((!obj) || (PTR_ERR(obj) =3D=3D -ENOENT)) { + obj =3D kzalloc(sizeof(*obj), GFP_KERNEL); + if (!obj) + return -ENOMEM; + } + + init_completion(&obj->completion); + obj->gntdev_dmabuf =3D gntdev_dmabuf; + obj->fd =3D fd; + mutex_lock(&priv->lock); + list_add(&obj->next, &priv->map_wait_list); + mutex_unlock(&priv->lock); + return 0; +} + +static void dmabuf_map_wait_obj_signal(struct gntdev_dmabuf_priv *priv, + struct gntdev_dmabuf *gntdev_dmabuf) +{ + struct gntdev_dmabuf_wait_obj *obj; + + mutex_lock(&priv->lock); + list_for_each_entry(obj, &priv->map_wait_list, next) + if (obj->gntdev_dmabuf =3D=3D gntdev_dmabuf) { + pr_debug("Found gntdev_dmabuf in the wait list, wake\n"); + complete_all(&obj->completion); + break; + } + + mutex_unlock(&priv->lock); +} + static struct gntdev_dmabuf_wait_obj * dmabuf_exp_wait_obj_new(struct gntdev_dmabuf_priv *priv, struct gntdev_dmabuf *gntdev_dmabuf) @@ -410,6 +489,18 @@ static int dmabuf_exp_from_pages(struct gntdev_dmabuf_= export_args *args) return ret; } =20 +static void dmabuf_map_free_gntdev_dmabuf(struct gntdev_dmabuf *gntdev_dma= buf) +{ + if (!gntdev_dmabuf) + return; + + kfree(gntdev_dmabuf->pages); + + kvfree(gntdev_dmabuf->u.map.frames); + kfree(gntdev_dmabuf); + gntdev_dmabuf =3D NULL; +} + static struct gntdev_grant_map * dmabuf_exp_alloc_backing_storage(struct gntdev_priv *priv, int dmabuf_flag= s, int count) @@ -432,6 +523,113 @@ dmabuf_exp_alloc_backing_storage(struct gntdev_priv *= priv, int dmabuf_flags, return map; } =20 +static void dmabuf_map_remove(struct gntdev_priv *priv, + struct gntdev_dmabuf *gntdev_dmabuf) +{ + dmabuf_exp_remove_map(priv, gntdev_dmabuf->u.map.map); + dmabuf_map_free_gntdev_dmabuf(gntdev_dmabuf); +} + +static struct gntdev_dmabuf * +dmabuf_alloc_gntdev_from_buf(struct gntdev_priv *priv, int fd, int dmabuf_= flags, + int count, unsigned int data_ofs) +{ + struct gntdev_dmabuf *gntdev_dmabuf; + struct dma_buf_attachment *attach; + struct dma_buf *dma_buf; + struct sg_table *sgt; + int ret =3D 0; + + gntdev_dmabuf =3D kzalloc(sizeof(*gntdev_dmabuf), GFP_KERNEL); + if (!gntdev_dmabuf) + return ERR_PTR(-ENOMEM); + + gntdev_dmabuf->pages =3D kcalloc(count, + sizeof(gntdev_dmabuf->pages[0]), GFP_KERNEL); + + if (!gntdev_dmabuf->pages) { + ret =3D -ENOMEM; + goto free; + } + + gntdev_dmabuf->u.map.frames =3D kvcalloc(count, + sizeof(gntdev_dmabuf->u.map.frames[0]), GFP_KERNEL); + if (!gntdev_dmabuf->u.map.frames) { + ret =3D -ENOMEM; + goto free; + } + + if (gntdev_test_page_count(count)) { + ret =3D -EINVAL; + goto free; + } + + dma_buf =3D dma_buf_get(fd); + if (IS_ERR_OR_NULL(dma_buf)) { + pr_debug("Unable to get dmabuf from fd\n"); + ret =3D PTR_ERR(dma_buf); + goto free; + } + + attach =3D dma_buf_attach(dma_buf, priv->dma_dev); + if (IS_ERR_OR_NULL(attach)) { + ret =3D PTR_ERR(attach); + goto fail_put; + } + + sgt =3D dma_buf_map_attachment(attach, DMA_BIDIRECTIONAL); + if (IS_ERR_OR_NULL(sgt)) { + ret =3D PTR_ERR(sgt); + goto fail_detach; + } + + if (sgt->sgl->offset !=3D data_ofs) { + pr_debug("DMA buffer offset %d, user-space expects %d\n", + sgt->sgl->offset, data_ofs); + ret =3D -EINVAL; + goto fail_unmap; + } + + /* Check number of pages that imported buffer has. */ + if (attach->dmabuf->size < count << PAGE_SHIFT) { + pr_debug("DMA buffer has %zu pages, user-space expects %d\n", + attach->dmabuf->size, count << PAGE_SHIFT); + ret =3D -EINVAL; + goto fail_unmap; + } + + gntdev_dmabuf->u.map.map =3D gntdev_get_alloc_from_fd(priv, sgt, count, + dmabuf_flags); + if (IS_ERR_OR_NULL(gntdev_dmabuf->u.map.map)) { + ret =3D -ENOMEM; + goto fail_unmap; + }; + + gntdev_dmabuf->priv =3D priv->dmabuf_priv; + gntdev_dmabuf->fd =3D fd; + gntdev_dmabuf->u.map.attach =3D attach; + gntdev_dmabuf->u.map.sgt =3D sgt; + gntdev_dmabuf->dmabuf =3D dma_buf; + gntdev_dmabuf->nr_pages =3D count; + gntdev_dmabuf->u.map.priv =3D priv; + + memcpy(gntdev_dmabuf->pages, gntdev_dmabuf->u.map.map->pages, count * + sizeof(gntdev_dmabuf->u.map.map->pages[0])); + memcpy(gntdev_dmabuf->u.map.frames, gntdev_dmabuf->u.map.map->frames, cou= nt * + sizeof(gntdev_dmabuf->u.map.map->frames[0])); + + return gntdev_dmabuf; +fail_unmap: + dma_buf_unmap_attachment(attach, sgt, DMA_BIDIRECTIONAL); +fail_detach: + dma_buf_detach(dma_buf, attach); +fail_put: + dma_buf_put(dma_buf); +free: + dmabuf_map_free_gntdev_dmabuf(gntdev_dmabuf); + return ERR_PTR(ret); +} + static int dmabuf_exp_from_refs(struct gntdev_priv *priv, int flags, int count, u32 domid, u32 *refs, u32 *fd) { @@ -481,6 +679,117 @@ static int dmabuf_exp_from_refs(struct gntdev_priv *p= riv, int flags, return ret; } =20 +static void dmabuf_release_notifier_cb(struct dma_buf *dmabuf, void *priv) +{ + struct gntdev_dmabuf *gntdev_dmabuf =3D priv; + + if (!gntdev_dmabuf) + return; + + dmabuf_map_remove(gntdev_dmabuf->u.map.priv, gntdev_dmabuf); + dmabuf_map_wait_obj_signal(gntdev_dmabuf->priv, gntdev_dmabuf); +} + +static int dmabuf_detach_map(struct gntdev_dmabuf *gntdev_dmabuf) +{ + struct dma_buf *dma_buf =3D gntdev_dmabuf->dmabuf; + long lret; + + /* Wait on any implicit fences */ + lret =3D dma_resv_wait_timeout(dma_buf->resv, + dma_resv_usage_rw(true), true, + MAX_SCHEDULE_TIMEOUT); + if (lret =3D=3D 0) + return -ETIME; + else if (lret < 0) + return lret; + + if (gntdev_dmabuf->u.map.sgt) { + dma_buf_unmap_attachment(gntdev_dmabuf->u.map.attach, + gntdev_dmabuf->u.map.sgt, DMA_BIDIRECTIONAL); + } + + dma_buf_detach(dma_buf, gntdev_dmabuf->u.map.attach); + dma_buf_put(dma_buf); + + return 0; +} + +static int dmabuf_map_release(struct gntdev_dmabuf *gntdev_dmabuf, bool sy= nc) +{ + int ret; + + if (!sync) { + ret =3D dmabuf_map_wait_obj_set(gntdev_dmabuf->priv, gntdev_dmabuf, + gntdev_dmabuf->fd); + if (ret) + return ret; + } + + ret =3D dmabuf_detach_map(gntdev_dmabuf); + if (ret) + return ret; + + if (!sync) { + ret =3D dma_buf_register_release_notifier(gntdev_dmabuf->dmabuf, + &dmabuf_release_notifier_cb, gntdev_dmabuf); + if (ret) + return ret; + } else { + dmabuf_map_remove(gntdev_dmabuf->u.map.priv, gntdev_dmabuf); + } + + return 0; +} + +static int dmabuf_map_refs_to_fd(struct gntdev_priv *priv, int flags, + int count, u32 domid, u32 *refs, u32 fd, + unsigned int data_ofs) +{ + struct gntdev_dmabuf *gntdev_dmabuf; + int i, ret; + + gntdev_dmabuf =3D dmabuf_alloc_gntdev_from_buf(priv, fd, flags, count, + data_ofs); + + if (IS_ERR_OR_NULL(gntdev_dmabuf)) { + ret =3D PTR_ERR(gntdev_dmabuf); + goto fail_gntdev; + } + + for (i =3D 0; i < count; i++) { + gntdev_dmabuf->u.map.map->grants[i].domid =3D domid; + gntdev_dmabuf->u.map.map->grants[i].ref =3D refs[i]; + } + + mutex_lock(&priv->lock); + gntdev_add_map(priv, gntdev_dmabuf->u.map.map); + mutex_unlock(&priv->lock); + + gntdev_dmabuf->u.map.map->flags |=3D GNTMAP_host_map; +#if defined(CONFIG_X86) + gntdev_dmabuf->u.map.map->flags |=3D GNTMAP_device_map; +#endif + + ret =3D gntdev_map_grant_pages(gntdev_dmabuf->u.map.map); + if (ret < 0) + goto fail; + + mutex_lock(&priv->lock); + list_add(&gntdev_dmabuf->next, &priv->dmabuf_priv->map_list); + mutex_unlock(&priv->lock); + + return 0; +fail: + mutex_lock(&priv->lock); + list_del(&gntdev_dmabuf->u.map.map->next); + mutex_unlock(&priv->lock); + dmabuf_detach_map(gntdev_dmabuf); + dmabuf_map_free_gntdev_dmabuf(gntdev_dmabuf); +fail_gntdev: + return ret; +} + /* DMA buffer import support. */ =20 static int @@ -673,14 +982,15 @@ dmabuf_imp_to_refs(struct gntdev_dmabuf_priv *priv, s= truct device *dev, * it from the buffer's list. */ static struct gntdev_dmabuf * -dmabuf_imp_find_unlink(struct gntdev_dmabuf_priv *priv, int fd) +dmabuf_list_find_unlink(struct gntdev_dmabuf_priv *priv, struct list_head = *list, + int fd) { struct gntdev_dmabuf *q, *gntdev_dmabuf, *ret =3D ERR_PTR(-ENOENT); =20 mutex_lock(&priv->lock); - list_for_each_entry_safe(gntdev_dmabuf, q, &priv->imp_list, next) { + list_for_each_entry_safe(gntdev_dmabuf, q, list, next) { if (gntdev_dmabuf->fd =3D=3D fd) { - pr_debug("Found gntdev_dmabuf in the import list\n"); + pr_debug("Found gntdev_dmabuf in the list\n"); ret =3D gntdev_dmabuf; list_del(&gntdev_dmabuf->next); break; @@ -696,7 +1006,7 @@ static int dmabuf_imp_release(struct gntdev_dmabuf_pri= v *priv, u32 fd) struct dma_buf_attachment *attach; struct dma_buf *dma_buf; =20 - gntdev_dmabuf =3D dmabuf_imp_find_unlink(priv, fd); + gntdev_dmabuf =3D dmabuf_list_find_unlink(priv, &priv->imp_list, fd); if (IS_ERR(gntdev_dmabuf)) return PTR_ERR(gntdev_dmabuf); =20 @@ -726,6 +1036,21 @@ static void dmabuf_imp_release_all(struct gntdev_dmab= uf_priv *priv) dmabuf_imp_release(priv, gntdev_dmabuf->fd); } =20 +static void dmabuf_map_release_all(struct gntdev_dmabuf_priv *priv) +{ + struct gntdev_dmabuf *q, *gntdev_dmabuf; + struct gntdev_dmabuf_wait_obj *o, *obj; + + list_for_each_entry_safe(obj, o, &priv->map_wait_list, next) { + dmabuf_exp_wait_obj_free(priv, obj); + } + + list_for_each_entry_safe(gntdev_dmabuf, q, &priv->map_list, next) { + dmabuf_map_release(gntdev_dmabuf, true); + } + +} + /* DMA buffer IOCTL support. */ =20 long gntdev_ioctl_dmabuf_exp_from_refs(struct gntdev_priv *priv, int use_p= temod, @@ -769,6 +1094,47 @@ long gntdev_ioctl_dmabuf_exp_from_refs(struct gntdev_= priv *priv, int use_ptemod, return ret; } =20 +long gntdev_ioctl_dmabuf_map_refs_to_buf(struct gntdev_priv *priv, int use= _ptemod, + struct ioctl_gntdev_dmabuf_map_refs_to_buf __user *u) +{ + struct ioctl_gntdev_dmabuf_map_refs_to_buf op; + u32 *refs; + long ret; + + if (use_ptemod) { + pr_debug("Cannot provide dma-buf: use_ptemode %d\n", + use_ptemod); + return -EINVAL; + } + + if (copy_from_user(&op, u, sizeof(op)) !=3D 0) + return -EFAULT; + + if (op.count <=3D 0) + return -EINVAL; + + refs =3D kcalloc(op.count, sizeof(*refs), GFP_KERNEL); + if (!refs) + return -ENOMEM; + + if (copy_from_user(refs, u->refs, sizeof(*refs) * op.count) !=3D 0) { + ret =3D -EFAULT; + goto out; + } + + ret =3D dmabuf_map_refs_to_fd(priv, op.flags, op.count, + op.domid, refs, op.fd, op.data_ofs); + if (ret) + goto out; + + if (copy_to_user(u, &op, sizeof(op)) !=3D 0) + ret =3D -EFAULT; + +out: + kfree(refs); + return ret; +} + long gntdev_ioctl_dmabuf_exp_wait_released(struct gntdev_priv *priv, struct ioctl_gntdev_dmabuf_exp_wait_released __user *u) { @@ -823,6 +1189,45 @@ long gntdev_ioctl_dmabuf_imp_release(struct gntdev_pr= iv *priv, return dmabuf_imp_release(priv->dmabuf_priv, op.fd); } =20 +long gntdev_ioctl_dmabuf_map_release(struct gntdev_priv *priv, + struct ioctl_gntdev_dmabuf_map_release __user *u) +{ + struct ioctl_gntdev_dmabuf_map_release op; + struct gntdev_dmabuf *gntdev_dmabuf; + + if (copy_from_user(&op, u, sizeof(op)) !=3D 0) + return -EFAULT; + + gntdev_dmabuf =3D dmabuf_list_find_unlink(priv->dmabuf_priv, + &priv->dmabuf_priv->map_list, op.fd); + if (IS_ERR(gntdev_dmabuf)) + return PTR_ERR(gntdev_dmabuf); + + return dmabuf_map_release(gntdev_dmabuf, false); +} + +long gntdev_ioctl_dmabuf_map_wait_released(struct gntdev_priv *priv, + struct ioctl_gntdev_dmabuf_map_wait_released __user *u) +{ + struct ioctl_gntdev_dmabuf_map_wait_released op; + struct gntdev_dmabuf_wait_obj *obj; + int ret =3D 0; + + if (copy_from_user(&op, u, sizeof(op)) !=3D 0) + return -EFAULT; + + obj =3D dmabuf_map_wait_obj_find(priv->dmabuf_priv, op.fd); + if (IS_ERR_OR_NULL(obj)) + return (PTR_ERR(obj) =3D=3D -ENOENT) ? 0 : PTR_ERR(obj); + + if (!completion_done(&obj->completion)) + ret =3D dmabuf_exp_wait_obj_wait(obj, op.wait_to_ms); + + if (!ret && ret !=3D -ETIMEDOUT) + dmabuf_exp_wait_obj_free(priv->dmabuf_priv, obj); + return ret; +} + struct gntdev_dmabuf_priv *gntdev_dmabuf_init(struct file *filp) { struct gntdev_dmabuf_priv *priv; @@ -835,6 +1240,8 @@ struct gntdev_dmabuf_priv *gntdev_dmabuf_init(struct f= ile *filp) INIT_LIST_HEAD(&priv->exp_list); INIT_LIST_HEAD(&priv->exp_wait_list); INIT_LIST_HEAD(&priv->imp_list); + INIT_LIST_HEAD(&priv->map_list); + INIT_LIST_HEAD(&priv->map_wait_list); =20 priv->filp =3D filp; =20 @@ -844,5 +1251,6 @@ struct gntdev_dmabuf_priv *gntdev_dmabuf_init(struct f= ile *filp) void gntdev_dmabuf_fini(struct gntdev_dmabuf_priv *priv) { dmabuf_imp_release_all(priv); + dmabuf_map_release_all(priv); kfree(priv); } diff --git a/drivers/xen/gntdev-dmabuf.h b/drivers/xen/gntdev-dmabuf.h index 3d9b9cf9d5a1..07301f12ac52 100644 --- a/drivers/xen/gntdev-dmabuf.h +++ b/drivers/xen/gntdev-dmabuf.h @@ -21,6 +21,9 @@ void gntdev_dmabuf_fini(struct gntdev_dmabuf_priv *priv); long gntdev_ioctl_dmabuf_exp_from_refs(struct gntdev_priv *priv, int use_p= temod, struct ioctl_gntdev_dmabuf_exp_from_refs __user *u); =20 +long gntdev_ioctl_dmabuf_map_refs_to_buf(struct gntdev_priv *priv, int use= _ptemod, + struct ioctl_gntdev_dmabuf_map_refs_to_buf __user *u); + long gntdev_ioctl_dmabuf_exp_wait_released(struct gntdev_priv *priv, struct ioctl_gntdev_dmabuf_exp_wait_released __user *u); =20 @@ -30,4 +33,8 @@ long gntdev_ioctl_dmabuf_imp_to_refs(struct gntdev_priv *= priv, long gntdev_ioctl_dmabuf_imp_release(struct gntdev_priv *priv, struct ioctl_gntdev_dmabuf_imp_release __user *u); =20 +long gntdev_ioctl_dmabuf_map_release(struct gntdev_priv *priv, + struct ioctl_gntdev_dmabuf_map_release __user *u); +long gntdev_ioctl_dmabuf_map_wait_released(struct gntdev_priv *priv, + struct ioctl_gntdev_dmabuf_map_wait_released __user *u); #endif diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c index 4d9a3050de6a..677a51244bb2 100644 --- a/drivers/xen/gntdev.c +++ b/drivers/xen/gntdev.c @@ -22,6 +22,7 @@ =20 #define pr_fmt(fmt) "xen:" KBUILD_MODNAME ": " fmt =20 +#include #include #include #include @@ -43,6 +44,7 @@ #include #include #include +#include #include #include =20 @@ -96,7 +98,11 @@ static void gntdev_free_map(struct gntdev_grant_map *map= ) return; =20 #ifdef CONFIG_XEN_GRANT_DMA_ALLOC - if (map->dma_vaddr) { + if (map->pages && map->preserve_pages) { + gnttab_dma_clean_page_reservation(map->count, map->pages, + map->frames); + + } else if (map->dma_vaddr) { struct gnttab_dma_alloc_args args; =20 args.dev =3D map->dma_dev; @@ -216,6 +222,82 @@ struct gntdev_grant_map *gntdev_alloc_map(struct gntde= v_priv *priv, int count, return NULL; } =20 +struct gntdev_grant_map *gntdev_get_alloc_from_fd(struct gntdev_priv *priv= , + struct sg_table *sgt, int count, int dma_flags) +{ + struct gntdev_grant_map *add; + int i =3D 0; + struct sg_page_iter sg_iter; + + add =3D kzalloc(sizeof(*add), GFP_KERNEL); + if (!add) + return NULL; + + add->grants =3D kvcalloc(count, sizeof(add->grants[0]), GFP_KERNEL); + add->map_ops =3D kvcalloc(count, sizeof(add->map_ops[0]), GFP_KERNEL); + add->unmap_ops =3D kvcalloc(count, sizeof(add->unmap_ops[0]), GFP_KERNEL)= ; + add->pages =3D kvcalloc(count, sizeof(add->pages[0]), GFP_KERNEL); + add->frames =3D kvcalloc(count, sizeof(add->frames[0]), + GFP_KERNEL); + add->being_removed =3D + kvcalloc(count, sizeof(add->being_removed[0]), GFP_KERNEL); + add->preserve_pages =3D 1; + + if (add->grants =3D=3D NULL || + add->map_ops =3D=3D NULL || + add->unmap_ops =3D=3D NULL || + add->pages =3D=3D NULL || + add->frames =3D=3D NULL || + add->being_removed =3D=3D NULL) + goto err; + + if (use_ptemod) { + add->kmap_ops =3D kvmalloc_array(count, sizeof(add->kmap_ops[0]), + GFP_KERNEL); + add->kunmap_ops =3D kvmalloc_array(count, sizeof(add->kunmap_ops[0]), + GFP_KERNEL); + if (NULL =3D=3D add->kmap_ops || NULL =3D=3D add->kunmap_ops) + goto err; + } + + for_each_sgtable_page(sgt, &sg_iter, 0) { + struct page *page =3D sg_page_iter_page(&sg_iter); + + add->pages[i] =3D page; + add->frames[i] =3D xen_page_to_gfn(page); + i++; + if (i >=3D count) + break; + } + + if (i < count) { + pr_debug("Provided buffer is too small"); + goto err; + } + + if (gnttab_dma_reserve_pages(count, add->pages, add->frames)) + goto err; + + for (i =3D 0; i < count; i++) { + add->map_ops[i].handle =3D -1; + add->unmap_ops[i].handle =3D -1; + if (use_ptemod) { + add->kmap_ops[i].handle =3D -1; + add->kunmap_ops[i].handle =3D -1; + } + } + + add->index =3D 0; + add->count =3D count; + refcount_set(&add->users, 1); + + return add; + +err: + gntdev_free_map(add); + return NULL; +} + void gntdev_add_map(struct gntdev_priv *priv, struct gntdev_grant_map *add= ) { struct gntdev_grant_map *map; @@ -610,6 +692,9 @@ static int gntdev_release(struct inode *inode, struct f= ile *flip) struct gntdev_grant_map *map; =20 pr_debug("priv %p\n", priv); +#ifdef CONFIG_XEN_GNTDEV_DMABUF + gntdev_dmabuf_fini(priv->dmabuf_priv); +#endif =20 mutex_lock(&priv->lock); while (!list_empty(&priv->maps)) { @@ -620,10 +705,6 @@ static int gntdev_release(struct inode *inode, struct = file *flip) } mutex_unlock(&priv->lock); =20 -#ifdef CONFIG_XEN_GNTDEV_DMABUF - gntdev_dmabuf_fini(priv->dmabuf_priv); -#endif - kfree(priv); return 0; } @@ -1020,6 +1101,16 @@ static long gntdev_ioctl(struct file *flip, =20 case IOCTL_GNTDEV_DMABUF_IMP_RELEASE: return gntdev_ioctl_dmabuf_imp_release(priv, ptr); + + case IOCTL_GNTDEV_DMABUF_MAP_REFS_TO_BUF: + return gntdev_ioctl_dmabuf_map_refs_to_buf(priv, use_ptemod, ptr); + + case IOCTL_GNTDEV_DMABUF_MAP_RELEASE: + return gntdev_ioctl_dmabuf_map_release(priv, ptr); + + case IOCTL_GNTDEV_DMABUF_MAP_WAIT_RELEASED: + return gntdev_ioctl_dmabuf_map_wait_released(priv, ptr); + #endif =20 default: diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c index d6576c8b6f0f..257e335bc65b 100644 --- a/drivers/xen/grant-table.c +++ b/drivers/xen/grant-table.c @@ -1036,6 +1036,40 @@ void gnttab_free_pages(int nr_pages, struct page **p= ages) } EXPORT_SYMBOL_GPL(gnttab_free_pages); =20 +int gnttab_dma_reserve_pages(int nr_pages, struct page **pages, + xen_pfn_t *frames) +{ + int ret, i; + + for (i =3D 0; i < nr_pages; i++) + xenmem_reservation_scrub_page(pages[i]); + + xenmem_reservation_va_mapping_reset(nr_pages, pages); + + ret =3D xenmem_reservation_decrease(nr_pages, frames); + if (ret !=3D nr_pages) + return ret; + + return 0; +} +EXPORT_SYMBOL_GPL(gnttab_dma_reserve_pages); + +int gnttab_dma_clean_page_reservation(int nr_pages, struct page **pages, + xen_pfn_t *frames) +{ + int ret; + + ret =3D xenmem_reservation_increase(nr_pages, frames); + if (ret !=3D nr_pages) { + pr_debug("Failed to increase reservation for DMA buffer\n"); + return -EFAULT; + } + + xenmem_reservation_va_mapping_update(nr_pages, pages, frames); + return 0; +} +EXPORT_SYMBOL_GPL(gnttab_dma_clean_page_reservation); + #ifdef CONFIG_XEN_GRANT_DMA_ALLOC /** * gnttab_dma_alloc_pages - alloc DMAable pages suitable for grant mapping= into @@ -1071,17 +1105,11 @@ int gnttab_dma_alloc_pages(struct gnttab_dma_alloc_= args *args) =20 args->pages[i] =3D page; args->frames[i] =3D xen_page_to_gfn(page); - xenmem_reservation_scrub_page(page); } =20 - xenmem_reservation_va_mapping_reset(args->nr_pages, args->pages); - - ret =3D xenmem_reservation_decrease(args->nr_pages, args->frames); - if (ret !=3D args->nr_pages) { - pr_debug("Failed to decrease reservation for DMA buffer\n"); - ret =3D -EFAULT; + ret =3D gnttab_dma_reserve_pages(args->nr_pages, args->pages, args->frame= s); + if (ret) goto fail; - } =20 ret =3D gnttab_pages_set_private(args->nr_pages, args->pages); if (ret < 0) @@ -1109,17 +1137,8 @@ int gnttab_dma_free_pages(struct gnttab_dma_alloc_ar= gs *args) for (i =3D 0; i < args->nr_pages; i++) args->frames[i] =3D page_to_xen_pfn(args->pages[i]); =20 - ret =3D xenmem_reservation_increase(args->nr_pages, args->frames); - if (ret !=3D args->nr_pages) { - pr_debug("Failed to increase reservation for DMA buffer\n"); - ret =3D -EFAULT; - } else { - ret =3D 0; - } - - xenmem_reservation_va_mapping_update(args->nr_pages, args->pages, - args->frames); - + ret =3D gnttab_dma_clean_page_reservation(args->nr_pages, args->pages, + args->frames); size =3D args->nr_pages << PAGE_SHIFT; if (args->coherent) dma_free_coherent(args->dev, size, diff --git a/include/uapi/xen/gntdev.h b/include/uapi/xen/gntdev.h index 7a7145395c09..cadc7fd9bc9c 100644 --- a/include/uapi/xen/gntdev.h +++ b/include/uapi/xen/gntdev.h @@ -312,4 +312,66 @@ struct ioctl_gntdev_dmabuf_imp_release { __u32 reserved; }; =20 +/* + * Fd mapping ioctls allows to map @fd to @refs. + * + * Allows gntdev to map scatter-gather table to the existing dma-buf + * file destriptor. It provides the same functionality as + * DMABUF_EXP_FROM_REFS_V2 ioctls, + * but maps sc table on top of the existing buffer memory, instead of + * allocting memory. This is useful when exporter should work with externa= l + * buffer. + */ + +#define IOCTL_GNTDEV_DMABUF_MAP_REFS_TO_BUF \ + _IOC(_IOC_NONE, 'G', 15, \ + sizeof(struct ioctl_gntdev_dmabuf_map_refs_to_buf)) +struct ioctl_gntdev_dmabuf_map_refs_to_buf { + /* IN parameters. */ + /* Specific options for this dma-buf: see GNTDEV_DMA_FLAG_XXX. */ + __u32 flags; + /* Number of grant references in @refs array. */ + __u32 count; + /* Offset of the data in the dma-buf. */ + __u32 data_ofs; + /* File descriptor of the dma-buf. */ + __u32 fd; + /* The domain ID of the grant references to be mapped. */ + __u32 domid; + /* Variable IN parameter. */ + /* Array of grant references of size @count. */ + __u32 refs[1]; +}; + +/* + * This will release gntdev attachment to the provided buffer with file + * descriptor @fd, so it can be released by the owner. This is only valid + * for buffers created with IOCTL_GNTDEV_DMABUF_EXP_REFS_TO_BUF. + * Returns 0 on success, -ETIME when waiting dma_buffer fences to clean + * reached timeout. In this case release call should be repeated after + * releasing dma_buffer fences. + */ +#define IOCTL_GNTDEV_DMABUF_MAP_RELEASE \ + _IOC(_IOC_NONE, 'G', 16, \ + sizeof(struct ioctl_gntdev_dmabuf_map_release)) +struct ioctl_gntdev_dmabuf_map_release { + /* IN parameters */ + __u32 fd; + __u32 reserved; +}; + +/* + * This will wait until gntdev release procedure is finished and buffer wa= s + * released completely. This is only valid for buffers created with + * IOCTL_GNTDEV_DMABUF_EXP_REFS_TO_BUF. + */ +#define IOCTL_GNTDEV_DMABUF_MAP_WAIT_RELEASED \ + _IOC(_IOC_NONE, 'G', 17, \ + sizeof(struct ioctl_gntdev_dmabuf_map_wait_released)) +struct ioctl_gntdev_dmabuf_map_wait_released { + /* IN parameters */ + __u32 fd; + __u32 wait_to_ms; +}; + #endif /* __LINUX_PUBLIC_GNTDEV_H__ */ diff --git a/include/xen/grant_table.h b/include/xen/grant_table.h index 8e220edf44ab..73b473474ac9 100644 --- a/include/xen/grant_table.h +++ b/include/xen/grant_table.h @@ -250,6 +250,11 @@ int gnttab_dma_alloc_pages(struct gnttab_dma_alloc_arg= s *args); int gnttab_dma_free_pages(struct gnttab_dma_alloc_args *args); #endif =20 +int gnttab_dma_reserve_pages(int nr_pages, struct page **pages, + xen_pfn_t *frames); +int gnttab_dma_clean_page_reservation(int nr_pages, struct page **pages, + xen_pfn_t *frames); + int gnttab_pages_set_private(int nr_pages, struct page **pages); void gnttab_pages_clear_private(int nr_pages, struct page **pages); =20 --=20 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Jan 02 13:42:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 Jan 2023 13:42:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470287.729740 (Exim 4.92) (envelope-from ) id 1pCL4u-00023y-21; Mon, 02 Jan 2023 13:42:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470287.729740; Mon, 02 Jan 2023 13:42:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCL4t-000237-Sn; Mon, 02 Jan 2023 13:42:11 +0000 Received: by outflank-mailman (input) for mailman id 470287; Mon, 02 Jan 2023 13:42:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCL4s-00020m-I0 for xen-devel@lists.xenproject.org; Mon, 02 Jan 2023 13:42:10 +0000 Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3f199e7a-8aa3-11ed-91b6-6bf2151ebd3b; Mon, 02 Jan 2023 14:42:07 +0100 (CET) Received: from pps.filterd (m0174682.ppops.net [127.0.0.1]) by mx0b-0039f301.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 302Bx46C011991; Mon, 2 Jan 2023 13:41:51 GMT Received: from eur04-he1-obe.outbound.protection.outlook.com (mail-he1eur04lp2054.outbound.protection.outlook.com [104.47.13.54]) by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3mtd0uv746-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 02 Jan 2023 13:41:51 +0000 Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23) by DB9PR03MB9709.eurprd03.prod.outlook.com (2603:10a6:10:459::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Mon, 2 Jan 2023 13:41:48 +0000 Received: from PA4PR03MB7136.eurprd03.prod.outlook.com ([fe80::2da6:6d63:389b:3552]) by PA4PR03MB7136.eurprd03.prod.outlook.com ([fe80::2da6:6d63:389b:3552%9]) with mapi id 15.20.5944.019; Mon, 2 Jan 2023 13:41:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3f199e7a-8aa3-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ABPLD1J8Kgnw715Dt1/2KX2dbDeje4uBexVMcbPScdgoa5Ic6kYbKvXO+cui/dem3U9LADmf/iKoHKFFeXuMfbZPp3U8KglwR5PTslS7OJkTJdQp1K0l5J+ufIDB1UpU6afpou/jC8ue08RNNHJqG+UAqfB0oXgLWtTqx2eFp0IugPVZKZxp2KBA9mz0yGdAbrY47e1FKNCJUk+PR/jWpeFBu6UTOMc5t9USRBdxJNGM5Tea+l/KV9Gzy0alkFTwZSbun43ey5NU6CC0bpzw1G5HdvUI5+hyMm0a08yqFJ66FNIlODhiPyNcLXPPdnwYy+pjje5Yu5kS8FKcst9ovQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iuEwZFP31bPDffsqU14aI2kPMruZO5ACTYwm5FDPm60=; b=B9R/I6QLYSiJU+rii9DHveI07cMZtlbZXngAXR/puw/cgHHwLp5JGWxVLrg+b3BTF2Q7WU4Z/DObyL6xLwXHlx5G4RAV2k2bKDhbyidMnRDo5sq8xCD15iFtpVjzL3tC2L3q7Qgy14QvilN3S7zgyf1O/3oP9sfwKGFY9V3w8iyghobsDLk5DlQiHN1H45QBzs6GaUwrXSaCRNBbehQ+mmg04w0fAWeuJ85YUoLzIy7XP1+qOwq4Uj5eTTpGWKuLuT6iO52xYVsv/P8iPYqExb6tmrAToRvAPHfOpeb8SW2sjIPtgQpKRfXvVk0CEXx3Y1mVGn8A6C2/v6RKrCdi1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iuEwZFP31bPDffsqU14aI2kPMruZO5ACTYwm5FDPm60=; b=Fj64byEjy6KUX0YgNrwxi4w4yTqByFsOVPSfZxAYH/vd6Q4mO6K0I929JQcT0CGUSh1iLJ6OVIt03Hl0cStQ0yQ2hhePHeIwmn19mSxc9aCbP25w3FPYsWgvVm19EMr7G5NnbGkWJW7LQe2uejzlWo8014RWSliHs/GLKMs60J++lOEHifxY81phUlClQxIRKuWZBr9pKxptY6IbkuS9T2dM5jEMgIOYRwsrBv1nc7DmGbBw5TfeFPY55tieXLeAmWgIvmVtzouTWQTpHKx0rAYrYA3eT5h88OeQjYD6iAV/jIgdyGWp0cAMtdP9mOVsKmFLBusZfvIdGW39WVP9WA== From: Oleksii Moisieiev To: "jgross@suse.com" CC: Oleksii Moisieiev , Stefano Stabellini , Oleksandr Tyshchenko , "xen-devel@lists.xenproject.org" , "linux-kernel@vger.kernel.org" , Sumit Semwal , =?iso-8859-1?Q?Christian_K=F6nig?= , "linux-media@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linaro-mm-sig@lists.linaro.org" Subject: [PATCH v1 0/3] Add ioctls to map grant refs on the external backing storage Thread-Topic: [PATCH v1 0/3] Add ioctls to map grant refs on the external backing storage Thread-Index: AQHZHq/2qxwFjlIdpkaeJi9xnPE21Q== Date: Mon, 2 Jan 2023 13:41:48 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PA4PR03MB7136:EE_|DB9PR03MB9709:EE_ x-ms-office365-filtering-correlation-id: d61e592b-7ca9-4505-ba47-08daecc7189d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: K//txomNbdnSgoB7Ft87gMsqzlplA7ByfPveZH2lOQbvzABfonhwPmW8pHTNVcWTtxhsA5pikAmzM4H43dTGp5i67FfOE6KrsVW/xqecWgvPNpwRErzxifu/6Dh7LMSihwMtaA4ZNSJsAR5Bh7Ofo8G9TJ4zwgbQxcC+i8EvuQn5oFj41yWqthGpy5doxFGUZsePuUZrrZJURNp7H9wTJfZPr9M66lcICykSQJtytLyBXnYk4VFdf3OuCKWUkxXPLnhzpdAgsil+oTjBXbDQ5TEacgQB4Y6L9lt59W8/XuaaHqPUVUE96QFFTMU4tASrqj1T5GqGgxNvbMo05ijG7i5rDAUW8galctv+eyyR2EF1ygZBYj9ce+q4rmgE9g6b7MPadEhwy1bAhh52OVhgqA4UaaTD0ffgE6xLbwm8J2FoadXZY4dxq54JF8XrbLVHAxiEPseciaNfVFWVKslvmPS105pRW1ZRN2d0X8DLzQN9SGU40rj4rgm40/KDPDoS9wBlsa9fJwktvRREvui4tdnsPGj4DuhJzy42AsxUQ12Kz21QKNgm4rpEdmCSgXz/Q8KAFDQWpEqY7Jn2dfTwQw/X/ubqmjfaWPQx0nOFRjjwxO9qfOMc6BFaJ2V9qABylklJMBrGgAt3QNQ/5tlqJRftRFbfu0Dm0EyOIIUqZq61zsUty87JKWX/ln3ZTgwBGU35xLvoW+hkIb0dRxV2XLtAlHyksYaGai0kIpUbyHk= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(136003)(376002)(39860400002)(366004)(451199015)(38100700002)(122000001)(86362001)(8676002)(38070700005)(66476007)(76116006)(66946007)(64756008)(66446008)(66556008)(6916009)(91956017)(4326008)(41300700001)(54906003)(316002)(2906002)(5660300002)(8936002)(2616005)(83380400001)(6512007)(478600001)(71200400001)(6486002)(6506007)(26005)(55236004)(186003)(36756003)(22166006);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?PimHRKzqh67sap2y2kDEW/CM2rd3FBGTTabLIqTqSyMy/RLiHOm+gXm8aG?= =?iso-8859-1?Q?Hnuj2k+DTRaDD5ESNOehMMM846HY5OaQIkW3l4pjaaUfzUEhxjby2Ac1xK?= =?iso-8859-1?Q?XeDLrvdsSK+2BnhMlDHiXB7MTLeSE2E8GriDNay6Rg0zoIhthgVUqQAUbt?= =?iso-8859-1?Q?ifrpBbeO/oc3ErtvBDnbAFM1svMTk3dXPcybVgnRTXTuDoFieCZawXZrWe?= =?iso-8859-1?Q?ZiT5Dm3BVL0nXr2lRJ1ze8mcYM+OHSEtZirldOJoduV6vXz552ddktFqz7?= =?iso-8859-1?Q?qg1SsTjGNJtSLptzQ88HYATYXZHeeWJgzEEHwX6IpOVxazUWzHnKpwEtBW?= =?iso-8859-1?Q?4HnbQnEZy49jw28MWMsy8UYmt71KYKShDc+uBjCDTp1Xqdh1WLU5mxP5ZE?= =?iso-8859-1?Q?ViFQvCbsLM0jx67476k8SJMC4ZZOzupO0AZPMa29Z9R1RzyaTXiOCa9zHH?= =?iso-8859-1?Q?AjNR19bieXK/4dylgt4UGDyCQOrBWxDbRG4y64SljszHiGtZ4iZdzu1aA6?= =?iso-8859-1?Q?0nVLEhmpk2KtQKqjBA+HYQZXrX8sg2SWXEa3pObkLtxAjdoWmWdiuT8SKY?= =?iso-8859-1?Q?nb7gq3NO+o9syurpCfSjxqvCParte6GjpYJP91ItCJUWb0HPFJg1GFPAHv?= =?iso-8859-1?Q?DZNEQhimJzXKW+p/BQmdN9DWNWpSYInuTnWDuvGXyeRp0ixOGNlVMN5ycw?= =?iso-8859-1?Q?wKHcsMv+1ZTyraq8NgL04IkkQSlJ/dPTWNM0lOvwa9I1TCDBO+iW6xcrj1?= =?iso-8859-1?Q?9TPM3lLQ/b4SiGmGBXAJyffCCzdPXwgTAJjduf934bZ+IXPuYjit60YIgT?= =?iso-8859-1?Q?uU/nZSyrDoULkQvFArILSSEL5c9jcLUsfZcmVffEdFEY+YcRwcGHv/u51+?= =?iso-8859-1?Q?bUgdaaeju+jdcGFFla8Zc8BL3iO6Ynct9KpP3l4mXy4iLZfzq0nwnYvUXC?= =?iso-8859-1?Q?U/G7PVhp4Eut8dTLf/wY39NNhX/zHGA75m88nLBe2yPe2MyxG9ssZ6Wk8K?= =?iso-8859-1?Q?RmDJZGV4PU4yLtxVmusqZc62cZrGMo/cny0W0qRTdIUpgb+N+5X6ixu2ZI?= =?iso-8859-1?Q?Xi9Rqpi7hgThw7GA9fQQwFo0nPS2MTvZNZQuSLpL5qanaJgdK1AKEbQktO?= =?iso-8859-1?Q?j8/STEsx9CHPtOWCR7CpiuWyH3Y6/OqH5p6XGUTmAb0ze1SeXzhG7QBolX?= =?iso-8859-1?Q?R8xTxyYn+m+qG7LLIuP+UGb7cSmDAs3LyhMVgrNyQiclf2p2K/jcRGv9yx?= =?iso-8859-1?Q?HSYQlHoHpZbTRfNaCMoH2WupqAIzLrMOMa3Q6OgL81qXj7ydI40/Zh0FXb?= =?iso-8859-1?Q?6++sxxXzVIa9XxOvFpibW8O9W29l2taYNnkbZHadC+ar1SOrgcjNrAbxBU?= =?iso-8859-1?Q?p807cTlttC2AxOaZcT5VthKfvSpUCFZVO5p0x+cHDTqKJxYW6+2ppy+JRA?= =?iso-8859-1?Q?g6wcVY/lZqgSPKXiaZYcKebfU7b/MotBTCi098JvAYW6rSYr7+w4faH7gg?= =?iso-8859-1?Q?UkIsQyvfEd4FtBRbX6cQU7/ttc64DTWCP2jkhAxZZUytHjdFVd5cZCn1pC?= =?iso-8859-1?Q?ScOhRLV3Dk9VrgJk2kF/BpuUaTBBMFK6+3S4QQd6NZkPdieiAP7Gj6yzAD?= =?iso-8859-1?Q?mZbzlbnUSocfa+hX+HGmntj5hKBCpd0H0n7CK5Sv0tJkYz6ImXTtQyIw?= =?iso-8859-1?Q?=3D=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d61e592b-7ca9-4505-ba47-08daecc7189d X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jan 2023 13:41:48.1514 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: v8p9FkNMGcd+IAcNLFIF+4SgKpMOoAi7zGCwL0Q8hm7GPRWT8c9uD3HtozKM872KL0egO8w00Y3Y/YZBdiHg4+4C35ro1kP5trBmjT97ZdU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR03MB9709 X-Proofpoint-GUID: xU2f70Y-pvWxurXYXUo2TyiosKfNjL_N X-Proofpoint-ORIG-GUID: xU2f70Y-pvWxurXYXUo2TyiosKfNjL_N X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2023-01-02_08,2022-12-30_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=835 phishscore=0 lowpriorityscore=0 bulkscore=0 impostorscore=0 spamscore=0 priorityscore=1501 adultscore=0 suspectscore=0 mlxscore=0 malwarescore=0 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301020124 Hello, Let me introduce the new ioctls, which are intended to allow gntdev to map scatter-gather table on top of the existing dmabuf, referenced by file descriptor. When using dma-buf exporter to create dma-buf with backing storage and map it to the grant refs, provided from the domain, we've met a problem, that several HW (i.MX8 gpu in our case) do not support external buffer and requires backing storage to be created using it's native tools. That's why new ioctls were added to be able to pass existing dma-buffer fd as input parameter and use it as backing storage to export to refs. Following calls were added: IOCTL_GNTDEV_DMABUF_MAP_REFS_TO_BUF - map existing buffer as the backing storage and export it to the provided grant refs; IOCTL_GNTDEV_DMABUF_MAP_RELEASE - detach buffer from the grant table and set notification to unmap grant refs before releasing the external buffer. After this call the external buffer should be detroyed. IOCTL_GNTDEV_DMABUF_MAP_WAIT_RELEASED - wait for timeout until buffer is completely destroyed and gnt refs unmapped so domain could free grant pages. Should be called after buffer was destoyed. Our setup is based on IMX8QM board. We're trying to implement zero-copy support for DomU graphics using Wayland zwp_linux_dmabuf_v1_interface implementation. For dma-buf exporter we used i.MX8 gpu native tools to create backing storage grant-refs, received from DomU. Buffer for the backing storage was allocated using gbm_bo_create call because gpu do not support external buffer and requires backing storage to be created using it's native tools (eglCreateImageKHR returns EGL_NO_IMAGE_KHR for buffers, which were not created using gbm_bo_create). This behaviour was also tested on Qemu setup using DRM_IOCTL_MODE_CREATE_DUMB call to create backing storage buffer. --- Oleksii Moisieiev (3): xen/grant-table: save page_count on map and use if during async unmapping dma-buf: add dma buffer release notifier callback xen/grant-table: add new ioctls to map dmabuf to existing fd drivers/dma-buf/dma-buf.c | 44 ++++ drivers/xen/gntdev-common.h | 8 +- drivers/xen/gntdev-dmabuf.c | 416 +++++++++++++++++++++++++++++++++++- drivers/xen/gntdev-dmabuf.h | 7 + drivers/xen/gntdev.c | 101 ++++++++- drivers/xen/grant-table.c | 73 +++++-- include/linux/dma-buf.h | 15 ++ include/uapi/xen/gntdev.h | 62 ++++++ include/xen/grant_table.h | 8 + 9 files changed, 703 insertions(+), 31 deletions(-) --=20 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Jan 02 13:57:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 Jan 2023 13:57:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470318.729778 (Exim 4.92) (envelope-from ) id 1pCLJu-0005Nb-3G; Mon, 02 Jan 2023 13:57:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470318.729778; Mon, 02 Jan 2023 13:57:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCLJu-0005NU-0i; Mon, 02 Jan 2023 13:57:42 +0000 Received: by outflank-mailman (input) for mailman id 470318; Mon, 02 Jan 2023 13:57:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCLJs-0005NO-KE for xen-devel@lists.xenproject.org; Mon, 02 Jan 2023 13:57:40 +0000 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2087.outbound.protection.outlook.com [40.107.95.87]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6949fb15-8aa5-11ed-b8d0-410ff93cb8f0; Mon, 02 Jan 2023 14:57:37 +0100 (CET) Received: from MN2PR20CA0012.namprd20.prod.outlook.com (2603:10b6:208:e8::25) by BL0PR12MB4961.namprd12.prod.outlook.com (2603:10b6:208:1c9::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Mon, 2 Jan 2023 13:57:34 +0000 Received: from BL02EPF00010208.namprd05.prod.outlook.com (2603:10b6:208:e8:cafe::61) by MN2PR20CA0012.outlook.office365.com (2603:10b6:208:e8::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5966.19 via Frontend Transport; Mon, 2 Jan 2023 13:57:34 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BL02EPF00010208.mail.protection.outlook.com (10.167.241.199) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5944.8 via Frontend Transport; Mon, 2 Jan 2023 13:57:33 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 2 Jan 2023 07:57:33 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 2 Jan 2023 07:57:33 -0600 Received: from [10.71.193.33] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Mon, 2 Jan 2023 07:57:31 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6949fb15-8aa5-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W2VACdSmDz5iLDl0kP+sKe7hWiU6YDRc1rVINaLagfuz2xO6h8wpOBGQUvZScfP9B65z8RLn8z6QiJFnpALDqOW/7HoHUyVFRQc2VT92s4eCgGQdOJM7lOEeKOsHOjOZj9NrgxXyji/GJSsDPv7n9/04ksHQgksl+IIKODUvniwqxZFR4t+S0ovg7InKRf3GtqjfQ2eV9vqS6a0PZk5vEj6NZM/r3ZyNgfZdlVMPcDFVv9QSw6eVKPTZGnrVZ5mBkbRcBRV+vSVtuqBPmaAtaeSuFiqAC1axxbh23UBnWl6aXb7Jox1AQlwX18gimuIVibs3fWI/Ga3Kt7r4h2HvQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kOiwgzj1hlD6HA/7tnUM8GQZQVyFlg4Pd1hXLiTyrPs=; b=PfwAjgafJQ4wE19tbbhz4SupNPCIu6JvU4qRcprGSEGE74R9/U9xJ2lt4S2ru5o87oSFfnXNjB+O8Xy7h29O9sdrbZWrGI6YhkaVjvNLnx16Oe8SR9uPAQnJdmEZE62U6S3rkZVPFy9fVkHiYDPjwkGqzrY7XizPvrDtqRIvUL80QkGCotRGlM2y+c0YHJbDT5tVyWbSyHa9vrz4ZROFHzn9ypUWS5BSnPFWg2OW8bbJ/Fq2Wjdv6Gr6BLWnoJW1gh26s1Y8eEux2u2eewpYuLy+ufpiarlNbSqkcff9MKQELZep02Kg5yfuF+O++s8qqOYhzcQGRCFiRkxTk4Q28Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=citrix.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kOiwgzj1hlD6HA/7tnUM8GQZQVyFlg4Pd1hXLiTyrPs=; b=V648YDqu/sZKWeT7uxbJEkxoDrsDuP2r3tF+6PyO5z4+84k+Pi+/puGv9YYtZ1gkbsz/XB+jjVVVe4ukN2qGyrSXsGu2NS5KQSwg0sT45E5geZpgwUVbVy/Be+Z+f76G2f34KryawlL3xUX1AS4lwLcM7eC7HS6MADHf1AImjDU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <8f26f8fd-ec65-57c9-4ab3-7cb411580b6c@amd.com> Date: Mon, 2 Jan 2023 14:57:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 1/6] CI: Drop automation/configs/ To: Andrew Cooper , Xen-devel CC: Doug Goldstein , Stefano Stabellini , Anthony PERARD , "Oleksii Kurochko" References: <20221230003848.3241-1-andrew.cooper3@citrix.com> <20221230003848.3241-2-andrew.cooper3@citrix.com> Content-Language: en-US From: Michal Orzel In-Reply-To: <20221230003848.3241-2-andrew.cooper3@citrix.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF00010208:EE_|BL0PR12MB4961:EE_ X-MS-Office365-Filtering-Correlation-Id: 65123726-f4a4-43bf-ec5d-08daecc94c5f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5MDAEZPX9//T8/0czxw1hwJ1Mrqw03IEZsi/OJ9zHV/+qfhJ3E2qQf5nAxRkUUqdJBqF0V+G6RxW8l3uDX7R/M3xe3xSCqtrO3o/SgEVCpCFZ0KaOXL/SGxkxFLiPDTTE6nzYVhxHGHC1Vl+PBQQLnBSkGFPPzdVUeZxF0OG2Nks5kZnKHPKU1cC1K/M1/xtv5QS8fILQKbYfAAbxCIjj1wZVf3CRlusdw4pkwIUrh4HLh9VyRx/4GArm/H90ZW5aVyAVAwmru3lqDiUHEFsB94JqwEJ3TgS2pl3YyYXFkLEurYsJ00K/Ma1eKtDK7AuuAu20zV5YizrM5+ysd7QSIXHhUM0hssBAX9NAkF1kIOr9d2qfiIVvhT6P+qtIb+/Ptjzaj8rcsNcnmWTgM2TtRFa6ud5tiBU3urxGaP0VDJHkHZtkxPjD9nLrVgrbtafV32n7DdOjkSGPK4Lz2/59oizEZT5GueWnwqjhG63+dzKLuQX6/4zZzNwnFjtYSTmkVz0pb+jke/8haL4/gxVKPCJxvHX0nSgooW1BoWo/I7U++Gnh5PDbsSnArFsXE4Lr9wVNUfLB9fHWvPmap/tHIRAGZyULFpGV3mtoy+Z9kj5B2StMj4S2EH9SmZTsEoIaqbpIYkLmr8k6hT3UIJSJCRFC2at2UFzVgpfGw73cpOesxE+Irml1i+ccCCnOhc5SQIPxC0aTFKLAS0lT+vHE7p1YULyNCvqYnuc/gN0LMVXk9jtDOoUIu1Cf124dqUee4jWz/mdNbaM2Gm+zQLhWw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39850400004)(136003)(346002)(396003)(376002)(451199015)(36840700001)(46966006)(5660300002)(2906002)(4744005)(44832011)(8936002)(8676002)(4326008)(41300700001)(54906003)(70206006)(316002)(70586007)(16576012)(110136005)(478600001)(31686004)(53546011)(6666004)(26005)(82310400005)(336012)(40480700001)(83380400001)(47076005)(426003)(82740400003)(81166007)(356005)(186003)(2616005)(31696002)(86362001)(36756003)(36860700001)(22166006)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jan 2023 13:57:33.9814 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 65123726-f4a4-43bf-ec5d-08daecc94c5f X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF00010208.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB4961 Hi Andrew, On 30/12/2022 01:38, Andrew Cooper wrote: > Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. > > > Having 3 extra hypervisor builds on the end of a full build is deeply > confusing to debug if one of them fails, because the .config file presented in > the artefacts is not the one which caused a build failure. Also, the log > tends to be truncated in the UI. > > PV-only is tested as part of PV-Shim in a full build anyway, so doesn't need > repeating. HVM-only and neither will come up frequently in randconfig, so > drop all the logic here to simplify things. > > Signed-off-by: Andrew Cooper Reviewed-by: Michal Orzel ~Michal From xen-devel-bounces@lists.xenproject.org Mon Jan 02 14:01:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 Jan 2023 14:01:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470325.729789 (Exim 4.92) (envelope-from ) id 1pCLNk-0006ru-KB; Mon, 02 Jan 2023 14:01:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470325.729789; Mon, 02 Jan 2023 14:01:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCLNk-0006rn-HX; Mon, 02 Jan 2023 14:01:40 +0000 Received: by outflank-mailman (input) for mailman id 470325; Mon, 02 Jan 2023 14:01:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCLNj-0006rh-AF for xen-devel@lists.xenproject.org; Mon, 02 Jan 2023 14:01:39 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2049.outbound.protection.outlook.com [40.107.92.49]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f89bd132-8aa5-11ed-91b6-6bf2151ebd3b; Mon, 02 Jan 2023 15:01:37 +0100 (CET) Received: from BN8PR12CA0025.namprd12.prod.outlook.com (2603:10b6:408:60::38) by CH0PR12MB5042.namprd12.prod.outlook.com (2603:10b6:610:e1::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Mon, 2 Jan 2023 14:01:34 +0000 Received: from BL02EPF00010207.namprd05.prod.outlook.com (2603:10b6:408:60:cafe::94) by BN8PR12CA0025.outlook.office365.com (2603:10b6:408:60::38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5966.19 via Frontend Transport; Mon, 2 Jan 2023 14:01:34 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BL02EPF00010207.mail.protection.outlook.com (10.167.241.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5944.8 via Frontend Transport; Mon, 2 Jan 2023 14:01:34 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 2 Jan 2023 08:01:33 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 2 Jan 2023 08:01:00 -0600 Received: from [10.71.193.33] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Mon, 2 Jan 2023 08:00:59 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f89bd132-8aa5-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iTOhaNPCQopKF+VeJPvubk3OPDFMBCmITNpImUqg2rJQJ7yCyrHHZ6qusE2moXStFi84dNKUsDhyxuMzM/M3owBLoqoWQvWuhd3qgy+z4AE48E6AncLV8di8z0aOVB3kk0ip1N+PMXMOUpnkiIe8hxZn1VHTC0+UHj4cGpz9zWxUyTt0b57a287o5oMwFBbe1+qudt3W2G6uA0/FEHtME0/ULS1clYbdEULMZEB01EQeHKSQA5VhoHSHaSii7yjZ+cbrvHXyUT0NXDOOcCzHMug1hrDU8ujhnLCfbgm36OBG0lGNYql0r21BjX6cWwwEGGhfuwwRTCpDaXbf07+h9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ABCgx/a3xNCjBPacP85PXQGgbm8BLLReM5BWn7wRal4=; b=YTHiozJc7qQygkeKY11CSBPldE2VcMZ1ZfjzxL1GlpGW+5AbxcvPVg7CU2Lz+NpQMJd7zhRfr2JlTwLGEUsnE/5QL22HZJE06xXH9sSR/60xmjysYyFmc3OiHxi/Zovhgff1Y0cWeBA4SarOkRtXZYFRe7NVb8/ZmIR9FL277pVKO/Wqwenks8Uzv2DiGiJY6+IhFnXO/x5gf0XBWacEW98QCa2zYu29EGnNVDvccTHDewdf3dE00vudf+cdKB6osn8QGaqh6DlEfMwlgbC98752ZbdjlaElRL9pObjKmMOTT15VOc0zp8isDAyDSgYWd96ECnOBqLTER5uj++vZPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=citrix.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ABCgx/a3xNCjBPacP85PXQGgbm8BLLReM5BWn7wRal4=; b=QlP3WhmhYXG2zjR4hs5QyBxkdkZcgr5Jz0feaTXiSjtrR3mtTVyfOEpldrLVs5lgrOEy9TTqR9glZwndzip7fZmbi8VH3kxPGhtsTfHfKj/0FVNcCItw2kCM6VJYhpBlSFS91SMPpXKvJIx+PjGa3TlfhL+fcc3oZb2EUxK7S3I= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <07b5cc36-e0ea-9b51-036a-9523920dd74a@amd.com> Date: Mon, 2 Jan 2023 15:00:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 2/6] CI: Remove guesswork about which artefacts to preserve Content-Language: en-US To: Andrew Cooper , Xen-devel CC: Doug Goldstein , Stefano Stabellini , Anthony PERARD , "Oleksii Kurochko" References: <20221230003848.3241-1-andrew.cooper3@citrix.com> <20221230003848.3241-3-andrew.cooper3@citrix.com> From: Michal Orzel In-Reply-To: <20221230003848.3241-3-andrew.cooper3@citrix.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF00010207:EE_|CH0PR12MB5042:EE_ X-MS-Office365-Filtering-Correlation-Id: d4c969fc-3648-4ae2-67c3-08daecc9db87 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0u6BXlASZ44acsqFlYmT9XE87+1XgE2geVGvdLjglH2ynRwISjm8YRU6RmNmTN03Ij/QqGKwaa7OZxjLWVrqsLRSEnXw5AXk7N1s42F7QwY/ZnVogJRXWLiRR706cE/buRn52VjbCFDY1L/NJwIdbuIjMaBQvR5QzWpg177nblI7GEgIs49wT1QRYrcgvnDYBlCV+wpWv3HQjX4j8MX17Yc51FwB3j3HTUOWDtH+I4/zvkpUpq7F5BMLbWuvrK/6Qj5bwkaveFWVbRzk66duJbUYMor8APfS7z8wIB9qJ64esisaLyOcFFz3joXo251qRWZgib/UdH1uqfKTBeNzO7nveFu7l/2hiJf/q3KO4QsapLHARdkjaw3nLLJUqGZVRjlQ05XNKn/B468jSVwo0Wmm5XAC3edzCxBU4js8pnKjKx9mkVu9QB21G4GE0XKnco3ITVbiha5j+3jcZ9pJ0I8hdSba27q+s5+iUK6v9WcNCopr/0xmF8SW/3+Ggvl7RsB2xmAOh9Gcl8Tyw5Hyy20DdxihZFN9Sry2nKevQ7mLYNvUP62kOkf0+pMxfUQaN/+gSdundOb+o8FD/mmrjOe8WPG/JmBE7l/AOlBsEA6pdebA+CjrDynuaLqUtjNE1xZpJ5yl6N+KG+vV2lX9qJBn56UWSeXId6+pOZ6wRB+0IpOo+k7UdwNgcf1PHLKL+fpbNbn1Cv1KUqbo3j1pfcH8ylEG/QAmL+pLp0tNRFkQA/yHDsE0xZEqWYMriCVdE29aROQH9F4KBsConi2m30njmcw2pPCvwp1+d06UzqI= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(136003)(396003)(39860400002)(451199015)(40470700004)(46966006)(36840700001)(36756003)(2906002)(82740400003)(356005)(8936002)(5660300002)(41300700001)(44832011)(4744005)(426003)(47076005)(36860700001)(86362001)(31696002)(83380400001)(70206006)(110136005)(54906003)(31686004)(70586007)(81166007)(40460700003)(82310400005)(336012)(40480700001)(478600001)(316002)(4326008)(8676002)(16576012)(53546011)(186003)(26005)(2616005)(22166006)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jan 2023 14:01:34.0762 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d4c969fc-3648-4ae2-67c3-08daecc9db87 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF00010207.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5042 Hi Andrew, On 30/12/2022 01:38, Andrew Cooper wrote: > Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. > > > Preserve the artefacts based on the `make` rune we actually ran, rather than > guesswork about which rune we would have run based on other settings. > > Note that the ARM qemu smoke tests depend on finding binaries/xen even from > full builds. Also that the Jessie-32 containers build tools but not Xen. > > This means the x86_32 builds now store relevant artefacts. No change in other > configurations. > > Signed-off-by: Andrew Cooper I'd prefer to keep using "artifacts" and not "artefacts" as the former is what GitLab uses and what we use in build/test.yaml. Apart from that: Reviewed-by: Michal Orzel ~Michal From xen-devel-bounces@lists.xenproject.org Mon Jan 02 14:01:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 Jan 2023 14:01:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470326.729801 (Exim 4.92) (envelope-from ) id 1pCLNs-00079n-TB; Mon, 02 Jan 2023 14:01:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470326.729801; Mon, 02 Jan 2023 14:01:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCLNs-00079g-P9; Mon, 02 Jan 2023 14:01:48 +0000 Received: by outflank-mailman (input) for mailman id 470326; Mon, 02 Jan 2023 14:01:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCLNr-00079J-Ol for xen-devel@lists.xenproject.org; Mon, 02 Jan 2023 14:01:47 +0000 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2067.outbound.protection.outlook.com [40.107.212.67]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fd722ad5-8aa5-11ed-b8d0-410ff93cb8f0; Mon, 02 Jan 2023 15:01:45 +0100 (CET) Received: from DM6PR06CA0042.namprd06.prod.outlook.com (2603:10b6:5:54::19) by MW4PR12MB7381.namprd12.prod.outlook.com (2603:10b6:303:219::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Mon, 2 Jan 2023 14:01:42 +0000 Received: from DM6NAM11FT110.eop-nam11.prod.protection.outlook.com (2603:10b6:5:54:cafe::cb) by DM6PR06CA0042.outlook.office365.com (2603:10b6:5:54::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5966.19 via Frontend Transport; Mon, 2 Jan 2023 14:01:42 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by DM6NAM11FT110.mail.protection.outlook.com (10.13.173.205) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5966.18 via Frontend Transport; Mon, 2 Jan 2023 14:01:42 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 2 Jan 2023 08:01:41 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 2 Jan 2023 06:01:41 -0800 Received: from [10.71.193.33] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Mon, 2 Jan 2023 08:01:40 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fd722ad5-8aa5-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MyniDtl3pJnC1SFpkJ6hJ3gzbM4/GRo3EDrmn4XlQsIO7oWFuO3U5kBfmAoJN1GzOwPsDdM6OEbskWgUWF/9sfekiaWMW//a47gN72ErKyflFJnHy+g0cFeDkMzD1fLsP6Lnofk+Aa0jLiJjza/rIL5kxvAdTVa9QvsbBEC5lg8PPrJf/mD6eK0Lt3nXWOnhdv/MIJsE8WOdfI5krliveaej+UDSXjkvWYm1CIvUkknPqqPZL+dPGDpbeJjyI0zEnGJ6ekzyijXlXzpy8dLZNnYC+q0uuIH5QMrQmgqCmWtpInl4M/ULxRvlQGK15xwdPVNTtH9+z5X5zm0HgHu0yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J0gEafiirFF0bZlDHW4qHs/6kFKGTcRmz9ZoeGuR6fE=; b=HGIxDXOcKmGOTgXbBnKsZl9+5bNaYWwMwZ+++kD3HORvBYc1+zfrGqYIg0zKHInjy2bHyQKLctie5oFWnJHkvxqpyw2yEUVNo1mSDyZ/bnU7ez9BVBNmPuvuBMP4euVS2PTvr2D+hPje80I5Aek/pGoIleqtNSP+8RG510EFr94FuRh1q6guJ33t00INVk15726zxwgszBvqJq8S2SsaC4BnU0YmZUaGZDhc18GVbLGGJSsVkV8U/xp2iCurbOTrUv6gl9vb6h8W6LvUlGj9ssBPAojYNt9dVe2jdiqyJ4w09OG4bbry0D6CtxR09RH9Mr12A2gvhFG4jo6PO/e4dQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=citrix.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J0gEafiirFF0bZlDHW4qHs/6kFKGTcRmz9ZoeGuR6fE=; b=04uLRQnN+fyJ9UKHMWMV31P0rG8iZY3ta/83hmFsKwygewmtK0f/cfEt++l9ghfvDdIs3Fz5N+4HDq6z+rs9MCwOwR8HEW+45HpyAooGN7R+rJcI/hVs+Rigdsb5aOmhOqIYYV5QaSgzPz9Dn9ddQ93QktMIKPBEk22vE2cFEro= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: Date: Mon, 2 Jan 2023 15:01:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 3/6] CI: Only calculate ./configure args if needed Content-Language: en-US To: Andrew Cooper , Xen-devel CC: Doug Goldstein , Stefano Stabellini , Anthony PERARD , "Oleksii Kurochko" References: <20221230003848.3241-1-andrew.cooper3@citrix.com> <20221230003848.3241-4-andrew.cooper3@citrix.com> From: Michal Orzel In-Reply-To: <20221230003848.3241-4-andrew.cooper3@citrix.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT110:EE_|MW4PR12MB7381:EE_ X-MS-Office365-Filtering-Correlation-Id: 89031ae5-c623-4ab0-a82b-08daecc9e03d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qjPdYPpf47sX6xAl/KihMxpYgUo6xgiBzzmT9EJfxKyj0OQGJDDgFfkicoyJa6QKv7ppGijmftUhBTMJn7RGC6WPHrEpIGUUKmXLF50TFkDwKBXTOePdMXcK1QXohfleQSH8V+GmKeYwfglMWCu1GTeKvTYn+jTUiLQSFMK3waJQwLSE+7ishIura/n2iD+FYrzMhkLMbRzWCGjhe1cWzZxM7QauOHOSBMT+4a8i+yrdmCgJ6sBGpeJYcJCvHoEW17D3EOv7x8pO4bUawpK6Z2cvLq0lBftlSnDMRJgNlRv26XjCrp7Ldi29q2pxiH4RbEcLruCjhW3tZsLqtOLfVlKfRhLfzyggXj8BwfDtPBP+JSfjnCvnc+C6YD8FmoQBCpjPv02203oc94algOD3SfGHAj2VvAFgVi7YE2ISIsV7m9DL0M7TnqHGjbIcVB+uUQvzvWUXRUKFL8PpH8xITdDAjwtL+/6qUeOSZcHAVnf9xahMjdKqkspw8VfCEJMQRei2GfCMqHjGqX4xF2WXuCR7FimrUwNHWCKJm3GXGXROleOPPXy3/8rA5RuOeEnEaHL5rtDnC7+85InnsMiLGPJsa5CySJzfKIKJ6tjcC7jdLCkpO/CZIanyFufkH4db8Mxxgdm3eQ3OLKlWvAr5qUNgCyJwkBi/L2kv2kIQ/ZlJyAT8VNRCzGD5xjRYgnQvJDr9/TGNhuytUsRKg2Sj0nZQxPvdelSiZuLYiFB795dozb/OAxlP6GGLrlb7CI5deVgWwb16CrCO100Z0kll0/moH50L74+6L6E0HLErBno= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(376002)(39860400002)(136003)(451199015)(36840700001)(46966006)(40470700004)(81166007)(356005)(82740400003)(40480700001)(558084003)(40460700003)(36756003)(82310400005)(86362001)(31696002)(53546011)(36860700001)(70586007)(70206006)(316002)(2616005)(478600001)(26005)(186003)(16576012)(31686004)(54906003)(110136005)(8676002)(2906002)(47076005)(41300700001)(426003)(336012)(8936002)(4326008)(44832011)(5660300002)(22166006)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jan 2023 14:01:42.0284 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 89031ae5-c623-4ab0-a82b-08daecc9e03d X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT110.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7381 Hi Andrew, On 30/12/2022 01:38, Andrew Cooper wrote: > > > This is purely code motion of the cfgargs construction, into the case where it > is used. > > No practical change. > > Signed-off-by: Andrew Cooper Reviewed-by: Michal Orzel ~Michal From xen-devel-bounces@lists.xenproject.org Mon Jan 02 14:05:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 Jan 2023 14:05:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470339.729811 (Exim 4.92) (envelope-from ) id 1pCLRQ-000838-Ce; Mon, 02 Jan 2023 14:05:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470339.729811; Mon, 02 Jan 2023 14:05:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCLRQ-000831-9u; Mon, 02 Jan 2023 14:05:28 +0000 Received: by outflank-mailman (input) for mailman id 470339; Mon, 02 Jan 2023 14:05:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCLRO-00082q-Th for xen-devel@lists.xenproject.org; Mon, 02 Jan 2023 14:05:26 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2076.outbound.protection.outlook.com [40.107.243.76]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 809d5f19-8aa6-11ed-91b6-6bf2151ebd3b; Mon, 02 Jan 2023 15:05:25 +0100 (CET) Received: from BN9PR03CA0197.namprd03.prod.outlook.com (2603:10b6:408:f9::22) by DM4PR12MB6566.namprd12.prod.outlook.com (2603:10b6:8:8d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Mon, 2 Jan 2023 14:05:21 +0000 Received: from BN8NAM11FT017.eop-nam11.prod.protection.outlook.com (2603:10b6:408:f9:cafe::b) by BN9PR03CA0197.outlook.office365.com (2603:10b6:408:f9::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5966.19 via Frontend Transport; Mon, 2 Jan 2023 14:05:20 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT017.mail.protection.outlook.com (10.13.177.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5966.18 via Frontend Transport; Mon, 2 Jan 2023 14:05:20 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 2 Jan 2023 08:05:20 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 2 Jan 2023 06:05:19 -0800 Received: from [10.71.193.33] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Mon, 2 Jan 2023 08:05:18 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 809d5f19-8aa6-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aQfKUCh69TDJtBzRyezYuC43lVhYInQ2xv0WwQo8su7h8EnGkZgzfUXuxZi0lONAQALMigNU8LJ6ZoKd2BHQ/6a6vEtaj6fPerKBOyDU+KhfosLjD6Ev4laHQsdShYlYyGaExUTEm2Hfw9SA/YB1VeYzYPLAHY9yu/bPhOnL3MEgdPUobmr48nuYmQihAbG6E49+hzhAiGV2NHOIhBs1OfrqPESD+BSHmXq1gUz5CdSuUEV+TQ6eNA3X8TUiVn601R8IFSV4gfFV6VvYJlgVPtXst74kvFimBFHc22yI/uA6wmyz1n3CkztSscuGDjabQQ5E/++cWvs3sK4TdZHIew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Yv2nbBORmNi9jMe76KzemtB5/sficMOEg/4qBqBfQog=; b=X3b9O2onx+PLmuyOjXNf4hYz+LSJZlVTGFJlzQ2q+rMkCzzMtFVktS5BRHJ8CA2dQMLihWTIUG85Jrvw17a2C9wZsqJZxFRvsRbA2D/lEMMmcmqibd9PtbmYkr3OkMzmZUfX8dF/5xU5L2KzD3Pdl1fHhRu8KhEGEyNhp/Q+RNcgWemhnCGpFXgnfKeSVPOj75XRogZEizdt4BfFkIAuemnqk147y++rcONzvwD6la7b1t6hVM6WwYEcxty+vdLc+3vYkRaOXSdOVJRWx+TjeQrTLM+mxsaQiLL/cXN4i7kSERDBOOEsQUFg6TLm8w123ZCUOxW6Sac4rQcRQKAFYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=citrix.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Yv2nbBORmNi9jMe76KzemtB5/sficMOEg/4qBqBfQog=; b=voQ6nPNErpryNN+qY4HZWb5EPMkYONhd4ovhhC5aLAJQ0xZRPBnLOqtoPaJCZsNAygmX/UjHfaDu8lqfUv9bVAlEKnwTKjJtxF0XWpuHnLCs1KCaUbFMpJeQD3c/kc91mI5ndfO9dlDrRC2RNrEbuMV5oaYNZeu6TDV0XpZmKvk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <4caae81c-84a3-9925-2e9d-0f256feaa6c4@amd.com> Date: Mon, 2 Jan 2023 15:05:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 4/6] CI: Express HYPERVISOR_ONLY in build.yml Content-Language: en-US To: Andrew Cooper , Xen-devel CC: Doug Goldstein , Stefano Stabellini , Anthony PERARD , "Oleksii Kurochko" References: <20221230003848.3241-1-andrew.cooper3@citrix.com> <20221230003848.3241-5-andrew.cooper3@citrix.com> From: Michal Orzel In-Reply-To: <20221230003848.3241-5-andrew.cooper3@citrix.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT017:EE_|DM4PR12MB6566:EE_ X-MS-Office365-Filtering-Correlation-Id: 3bfa60f8-76b9-4f1d-36d3-08daecca6278 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: M45WnpRSehcSRgLauqT+P57rmVJ64fDbUaOKsKAMzlv+8oL/ovUmyGr/0sDimdYRpPQOLE2qfa7SrH7xGieAM5956g+Lj36pPcAzdTfoOAN9Ub3g+nDpY2nyqRflMb1CfHd3/ENXM9jNxN07XBE7ReH3F+eiFaE/ITmKJtb0IFtBaQ5psbxLcf8PsfP5jfJnPAW/5kf6Zefuy9uEYm+NEkaJNW4/YXnSDi5z8+ZEWNT+JQYhEt2GpWdnNeb638ZcSx14BxwQS3u/Xx5proxTHVeAXJvVl4JdkZ8SVOwg/U5BZNVpwyxdIYvrVLVi4NcI+jLeTkjIXht6LvNicd1QbyAuKj2y+c+fLJkmDnZCg/VdinSvBtYtSCwsRO8KNOGZXIISMkAfFkVzBR+ErKAQ8Dvn5tkeBZI3NhPFVEpwRog9x9kgOGXZpjKjQvF1hV/hFeZessNf5Jk6Bh+9Pcl4mNNlXK57/y6gswvsa3OODFrMc8kK8Q7pFpf0ZaysR+hDkFyxEVu1Mz3/eqCt+TiyBsO9sPOihHbK/G9ewQhjqEiDtT7v1h7hHzQohITllym4J7DQSgs7iMdnLVymmU8bSU10ZJmccJIrjRd2+/8F+2whuwEKBRMG4/rI7dKuT1oBSJoY6UMqbVAqoxsh8hN5g+Qp+mEopG9oAbb0E4//7oAmOrrsGdBOkSwQdwYys7YoU2DXZm6DgVZ4INAa8qmu/IEYrFIadJDxDAZFlCJN4qhGDXqlNefKMRZA0cZVtONpEr8Qa7rB/wgz99BaWvIa43eC2inZNqKRqf08bqkneoo= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(376002)(39860400002)(136003)(451199015)(46966006)(36840700001)(40470700004)(81166007)(356005)(82740400003)(40480700001)(40460700003)(36756003)(82310400005)(86362001)(31696002)(53546011)(16576012)(316002)(36860700001)(70586007)(70206006)(2616005)(478600001)(26005)(186003)(31686004)(54906003)(110136005)(2906002)(47076005)(41300700001)(426003)(336012)(8676002)(8936002)(4326008)(44832011)(4744005)(5660300002)(22166006)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jan 2023 14:05:20.5472 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3bfa60f8-76b9-4f1d-36d3-08daecca6278 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT017.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6566 Hi Andrew, On 30/12/2022 01:38, Andrew Cooper wrote: > > > Whether to build only Xen, or everything, is a property of container, > toolchain and/or testcase. It is not a property of XEN_TARGET_ARCH. > > Capitalise HYPERVISOR_ONLY and have it set by the debian-unstable-gcc-arm32-* > testcases at the point that arm32 get matched with a container that can only > build Xen. > > For simplicity, retain the RANDCONFIG -> HYPERVISOR_ONLY implication. > > Signed-off-by: Andrew Cooper Reviewed-by: Michal Orzel With regards to Oleksii comment, I do not think we should add HYPERVISOR_ONLY explicitly for randconfig debian-unstable-gcc-arm32-* jobs. Doing so would require similar change for all the randconfig jobs to be consistent and this is not needed. ~Michal From xen-devel-bounces@lists.xenproject.org Mon Jan 02 14:49:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 Jan 2023 14:49:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470348.729823 (Exim 4.92) (envelope-from ) id 1pCM7n-0003vb-OS; Mon, 02 Jan 2023 14:49:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470348.729823; Mon, 02 Jan 2023 14:49:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCM7n-0003vU-Lo; Mon, 02 Jan 2023 14:49:15 +0000 Received: by outflank-mailman (input) for mailman id 470348; Mon, 02 Jan 2023 14:49:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCM7m-0003vO-7F for xen-devel@lists.xenproject.org; Mon, 02 Jan 2023 14:49:14 +0000 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2044.outbound.protection.outlook.com [40.107.102.44]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9e3e6c39-8aac-11ed-91b6-6bf2151ebd3b; Mon, 02 Jan 2023 15:49:12 +0100 (CET) Received: from DM6PR21CA0017.namprd21.prod.outlook.com (2603:10b6:5:174::27) by IA0PR12MB7675.namprd12.prod.outlook.com (2603:10b6:208:433::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Mon, 2 Jan 2023 14:49:09 +0000 Received: from DM6NAM11FT012.eop-nam11.prod.protection.outlook.com (2603:10b6:5:174:cafe::b8) by DM6PR21CA0017.outlook.office365.com (2603:10b6:5:174::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.2 via Frontend Transport; Mon, 2 Jan 2023 14:49:09 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT012.mail.protection.outlook.com (10.13.173.109) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5966.18 via Frontend Transport; Mon, 2 Jan 2023 14:49:08 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 2 Jan 2023 08:49:07 -0600 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Mon, 2 Jan 2023 08:49:06 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9e3e6c39-8aac-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RuB2gXUQZGR7Cv/1+KZRvB4PM22ZXzMuLPHkpRTtoc5JWCeU0B+zTQskVzFB2k5KSp7H497c6KHFG8M944pPDrxZvlV8yGDCkfVUMREGfP2RTvXBF3PkHdPwMFOwHf/fKNyPYNGfd/jU68TaULwP+Yv9GLbtuh4gdnXCTwNHmYJz3IlplOA1pD1c77X9ob/NHDAuAxeoAwAyBeh3LVVdF3CIGr1VevnE0KxUBLgvsiZ/yriA766pnfuKowfzKdeJiteXVcGw1hnwtmpyTJ+kKtI8b6+5xduKacm3T/IVqdF1fZjeW4Uhty+kDQlOV+2Bzc3FgVSX4SpDrnyVcq8rug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=efh/Yhzkae+fINf3IfQzkBHj+8mOBrO76E4WEVCwp8Y=; b=loi+jwbdNCnhgN+rYjVn77BF9bDZluXY+SAKWKn3HY77Vzbhtdnh6f5eA9ZYr572X1is1DEtOGS1e3OqQAtQN7C4Faxd9mDdwIA79G3G7zWqKl0WZKhEgpqknlX2yqnjjpqYxHumYjOb+UHIodxcQep5vDM7Z8ZaT6hunSweEQlKzcbvu0wXZ5ENM6RACwqo8TWSotqZkXdDooZPm3/giibKxru28r+f2ORx8VtoLVn/B+awiaPCzSwPmsTKfVu5eh7kVk9hXMcD8xKLK2uqQaIOXDWImuQ+lr0cA8Dqb1QKUSe8DhQ0JVD2rITkDJm1f2YbPTf5/Mv+7uvOIu7LMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=efh/Yhzkae+fINf3IfQzkBHj+8mOBrO76E4WEVCwp8Y=; b=NkMUBsfU67o6GM97paS6SzxTEnz8Ucj4w95d3oU3dAyIY3CgFukot29ICnrIw5xvl/7JEw/4hhQTj8gnq/I7TiiqG//42HT9GB48NoBbFQ/MulnQG7DBDDbrSrVLcDvvapLWGSPJrK4d49QpgPiqfbwkFERZv9l27KIGJwQR0lM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH] xen/arm: Print memory size in decimal in construct_domU Date: Mon, 2 Jan 2023 15:49:04 +0100 Message-ID: <20230102144904.17619-1-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT012:EE_|IA0PR12MB7675:EE_ X-MS-Office365-Filtering-Correlation-Id: 21fd9655-9e8f-47f6-6819-08daecd080ed X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MtQBb6uID8MpFXOcmFSRs3kXSzkoOOILoj2Cc/V85xcsWhvH1biTc88zAV52DfOQOo8rBVpINlhTnstUPQYUJkcpGhRo8qNDor4MIwPM4KSyF51KYb3jgSNRJZcFlq98OXnpw/Z46k/FOpHpPmScQsWnbtthdbTE0rVg8rpRyLXuw+0ANO744GAz0PnbaldsnNhqIDZIp18K6pb0HquaDk+iTD9XkzYMULWc/uFWFXnAJXyHiQ0EDqodo442gclSC6Cad8VzWjSw7VySmefJcXRwjEkf8p+gCMmOGqj0RgHSSBH8m6BGef8bJahiisbsQSxJ/tWKan8yiHIDfXiDmpxPg9NhgWSun/uzm1RpXpHj11RiRIZZ1DKtHkAS7fLl99KID7A7sJ4LiMM9wxDuSXJ53wQeAqxMZeUh6EP1IJArbGxqdUtIeTc295w28aAT8VIjzaShTBtSvCuMIT2uY4zYhtkhIzO66V6czh/AZl48+OybY2FDhiiGso+DjKK6gSIG9Q/pfzbuLqZKiiiFKqdxZtvK+fnEoNRqKd2OtxAOToDMGKvbYbS3s7tzaTkjBSXXgV8b5s+T+tQsbcA96mKueVLVa2f3iikSd/MiY5lIJXcspaZP+Q1VDz5E3Oc8cBng7XQDzPsGjsIQFP2r9DsYEPpae7AnCTCU/smpkhzgAit1Bsi343D2bXNGK7YSuitLI5oTKpMQaewlrzLyS8IpAozFEOwwdRY2YYcTFb50aKXy4XxaoGUqdcs1RB4ZXXYciJ+ZkrqseYFYmXkTdA== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(376002)(346002)(396003)(451199015)(40470700004)(36840700001)(46966006)(54906003)(26005)(186003)(2616005)(70586007)(36860700001)(1076003)(316002)(70206006)(478600001)(8676002)(8936002)(4326008)(336012)(426003)(47076005)(41300700001)(83380400001)(5660300002)(4744005)(44832011)(2906002)(82740400003)(40480700001)(356005)(81166007)(86362001)(6916009)(36756003)(40460700003)(82310400005)(22166006)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jan 2023 14:49:08.5960 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 21fd9655-9e8f-47f6-6819-08daecd080ed X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT012.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7675 Printing domain's memory size in hex without even prepending it with 0x is not very useful and can be misleading. Switch to decimal notation. Signed-off-by: Michal Orzel --- xen/arch/arm/domain_build.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 829cea8de84f..7e204372368c 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -3774,7 +3774,7 @@ static int __init construct_domU(struct domain *d, if ( rc != 0 ) return rc; - printk("*** LOADING DOMU cpus=%u memory=%"PRIx64"KB ***\n", d->max_vcpus, mem); + printk("*** LOADING DOMU cpus=%u memory=%"PRIu64"KB ***\n", d->max_vcpus, mem); kinfo.vpl011 = dt_property_read_bool(node, "vpl011"); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Jan 02 15:09:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 Jan 2023 15:09:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470355.729834 (Exim 4.92) (envelope-from ) id 1pCMRX-0006KM-Fo; Mon, 02 Jan 2023 15:09:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470355.729834; Mon, 02 Jan 2023 15:09:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCMRX-0006KF-Bq; Mon, 02 Jan 2023 15:09:39 +0000 Received: by outflank-mailman (input) for mailman id 470355; Mon, 02 Jan 2023 15:09:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCMRV-0006K5-Nh; Mon, 02 Jan 2023 15:09:37 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCMRV-0008Qr-Hz; Mon, 02 Jan 2023 15:09:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCMRV-00009x-1X; Mon, 02 Jan 2023 15:09:37 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pCMRV-0004dk-11; Mon, 02 Jan 2023 15:09:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=LrcgIju8gsvzBsMrfYfpmnFb4Ao9ySubas6Vb31qVN8=; b=MOGenCN+3j5/B6DXs0mTkIA0T+ 1S8SUDUrqrJz9BBcAQGLaFRVkCBj1WQ+4cYLHrQuzSqVjkhgBmalELThJnFeK7xAx1ECYpF+DPdUk kqopsFY2kdvmiG2X8qJxjUREu2aYmFUfEu0Y6Znn0p9/rM//iGcnW5+6lHFMwUgoGf8Q=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 175549: FAIL X-Osstest-Failures: linux-5.4:test-amd64-amd64-xl-qemut-debianhvm-amd64::broken:regression linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64::broken:regression linux-5.4:test-amd64-i386-qemuu-rhel6hvm-intel::broken:regression linux-5.4:test-amd64-amd64-xl-credit2::broken:regression linux-5.4:test-armhf-armhf-xl-credit1::broken:regression linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:host-install(5):broken:heisenbug linux-5.4:test-amd64-i386-qemuu-rhel6hvm-intel:host-install(5):broken:heisenbug linux-5.4:test-amd64-amd64-xl-credit2:host-install(5):broken:heisenbug linux-5.4:test-amd64-amd64-xl-qemut-debianhvm-amd64:host-install(5):broken:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:host-install(5):broken:heisenbug linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:heisenbug linux-5.4:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug linux-5.4:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-amd64-i386-xl-vhd:guest-start.2:fail:heisenbug linux-5.4:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-amd64-i386-libvirt-raw:xen-install:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=851c2b5fb7936d54e1147f76f88e2675f9f82b52 X-Osstest-Versions-That: linux=66bb2e2b24ce52819a7070d3a3255726cb946b69 From: osstest service owner Date: Mon, 02 Jan 2023 15:09:37 +0000 flight 175549 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/175549/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-debianhvm-amd64 broken in 175407 test-amd64-i386-xl-qemuu-ws16-amd64 broken in 175407 test-amd64-i386-qemuu-rhel6hvm-intel broken in 175407 test-amd64-amd64-xl-credit2 broken in 175407 test-armhf-armhf-xl-credit1 broken in 175547 Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-ws16-amd64 5 host-install(5) broken in 175407 pass in 175549 test-amd64-i386-qemuu-rhel6hvm-intel 5 host-install(5) broken in 175407 pass in 175549 test-amd64-amd64-xl-credit2 5 host-install(5) broken in 175407 pass in 175549 test-amd64-amd64-xl-qemut-debianhvm-amd64 5 host-install(5) broken in 175407 pass in 175549 test-armhf-armhf-xl-credit1 5 host-install(5) broken in 175547 pass in 175549 test-armhf-armhf-xl-multivcpu 14 guest-start fail in 175407 pass in 175549 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail in 175545 pass in 175549 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail in 175545 pass in 175549 test-amd64-i386-xl-vhd 22 guest-start.2 fail in 175547 pass in 175545 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail in 175547 pass in 175549 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail pass in 175407 test-amd64-i386-libvirt-raw 7 xen-install fail pass in 175547 test-armhf-armhf-xl-credit2 14 guest-start fail pass in 175547 test-armhf-armhf-xl 18 guest-start/debian.repeat fail pass in 175547 test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail pass in 175547 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail blocked in 175197 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail in 175407 like 175197 test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail in 175547 like 175197 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 175547 like 175197 test-amd64-i386-libvirt-raw 14 migrate-support-check fail in 175547 never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 175547 never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 175547 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 175197 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 175197 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175197 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 175197 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175197 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175197 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 175197 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 175197 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 175197 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 175197 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175197 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 3 hosts-allocate starved in 175547 n/a version targeted for testing: linux 851c2b5fb7936d54e1147f76f88e2675f9f82b52 baseline version: linux 66bb2e2b24ce52819a7070d3a3255726cb946b69 Last test of basis 175197 2022-12-14 10:43:17 Z 19 days Testing same since 175407 2022-12-19 11:42:26 Z 14 days 34 attempts ------------------------------------------------------------ People who touched revisions under test: Alexei Starovoitov Andrew Morton Baolin Wang Charles Keepax Florian Fainelli Greg Kroah-Hartman Guenter Roeck Heiko Schocher Hulk Robot Jakub Kicinski Jialiang Wang Jon Hunter Linus Walleij Linux Kernel Functional Testing Lorenzo Colitti Maciej Żenczykowski Marc Kleine-Budde Mark Brown Ming Lei Paul E. McKenney Ricardo Ribalda Samuel Mendoza-Jonas Sasha Levin Shiwei Cui Shuah Khan Simon Horman Sudip Mukherjee Yasushi SHOJI Yasushi SHOJI jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl fail test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-armhf-armhf-xl-credit1 broken broken-job test-amd64-amd64-xl-qemut-debianhvm-amd64 broken broken-job test-amd64-i386-xl-qemuu-ws16-amd64 broken broken-job test-amd64-i386-qemuu-rhel6hvm-intel broken broken-job test-amd64-amd64-xl-credit2 broken Not pushing. (No revision log; it would be 410 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Jan 02 16:36:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 Jan 2023 16:36:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470366.729845 (Exim 4.92) (envelope-from ) id 1pCNnR-0007CU-Pr; Mon, 02 Jan 2023 16:36:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470366.729845; Mon, 02 Jan 2023 16:36:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCNnR-0007CN-NB; Mon, 02 Jan 2023 16:36:21 +0000 Received: by outflank-mailman (input) for mailman id 470366; Mon, 02 Jan 2023 16:36:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCNnR-0007CH-01 for xen-devel@lists.xenproject.org; Mon, 02 Jan 2023 16:36:21 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 940d627b-8abb-11ed-91b6-6bf2151ebd3b; Mon, 02 Jan 2023 17:36:17 +0100 (CET) Received: from BN8PR12MB3587.namprd12.prod.outlook.com (2603:10b6:408:43::13) by CH0PR12MB5204.namprd12.prod.outlook.com (2603:10b6:610:bb::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Mon, 2 Jan 2023 16:36:14 +0000 Received: from BN8PR12MB3587.namprd12.prod.outlook.com ([fe80::80d8:934f:caa7:67b0]) by BN8PR12MB3587.namprd12.prod.outlook.com ([fe80::80d8:934f:caa7:67b0%3]) with mapi id 15.20.5944.019; Mon, 2 Jan 2023 16:36:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 940d627b-8abb-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UQigwWBF6x3OemHSKmW41oBtjIO4MMzBqTqTL+J4zOHnr9oco0p1nV4zs5Ok97SGgvgVe6FNO2866hZW3Ozap37V7bdcZP2/uY91Ez85HGZ5J+TVqiRs9/orSP/xBR4d1S5ALWa6NWOnMX2csFW85X2BEQqfpwNkOhYU9OOioDZWAwV/mAF6ddwGmGT86zkYc3Qdj+kP3roGanE3fkqj/MURLTyAcfP462ueGPJOt+kFiyDqxzWyZyZeKib/TN2dCimYu2FcNy7IFzx/yJr+LBCedIz3gpTpvFJYuUwa9W0Tl5gN2YvRLAE1vReAQ7f7wLP+vSPrjCFrXSyNkEm4ZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=81NAQSNOaG4Jfe/lCufx56HmfZ33XwLIlKF0EzKp46s=; b=UIQfa+4xwB3WSx+wbQsopZuMcKqSDVh3lZ2uX5kvaIIcJZRfQhQm4zJMy3eIkU03+EqP+nyr77VJdUkCuBhca75sZoc2h4sP8Jh32M5SSx9PBflm5BFTwCJAR2VeedOwufh4pt+o3cGCIIhF6kdfVjcmYTIT2I7l0XAHCAhPWK4fc3dxlGLt2yyABjiMWSpqPOuy4M24jnkPbtNtF7w9sO6LOWTGailBPMEPjKtnNjBYQxI2PVdZ8NezR9jUOXzGFhNOU+ur/a7hqzeqVAOXch65H93lr3dQI8hYQImjv/iEQeaF1XdVl+s+WndPRESJe1HFdqQiJ6lqYBSuppcCCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=81NAQSNOaG4Jfe/lCufx56HmfZ33XwLIlKF0EzKp46s=; b=nlfBcXuKCGXLIb+RPD1HMhcaz4iiQBP4ViJ0GSGOw2xiQ8YnaAPXhpBod9LccGNWbLhT4ckz4lvsnZ56FzL/+yp+O0PsL3EdUAJrW0Gz9IFgxgWaVdY9Gp+GPHsDmWI7oHfunDxWl9X2Q/kQYR2yf/Hya3O/yaBlhlD0eMDXhrE= From: "Koenig, Christian" To: Oleksii Moisieiev , "jgross@suse.com" CC: Stefano Stabellini , Oleksandr Tyshchenko , "xen-devel@lists.xenproject.org" , "linux-kernel@vger.kernel.org" , Sumit Semwal , "linux-media@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linaro-mm-sig@lists.linaro.org" Subject: AW: [PATCH v1 0/3] Add ioctls to map grant refs on the external backing storage Thread-Topic: [PATCH v1 0/3] Add ioctls to map grant refs on the external backing storage Thread-Index: AQHZHq/2qxwFjlIdpkaeJi9xnPE21a6LUk6x Date: Mon, 2 Jan 2023 16:36:13 +0000 Message-ID: References: In-Reply-To: Accept-Language: de-DE, en-US Content-Language: de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=True;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-01-02T16:36:13.069Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN8PR12MB3587:EE_|CH0PR12MB5204:EE_ x-ms-office365-filtering-correlation-id: d8e81b28-214b-4d4f-fe6b-08daecdf7696 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8lfP6iV9Cj8Jf/vzIyuWKa81TwB63aWW/m+BoHNfidtF6xE+G5DGFfdL9rQqy80aQTkKnf41J6eBOL4NwXskCpP+4oKhYYfiCvV0ADvfqbbaEg9YXkk8EpxqANuJQvGr4w6oMRHgQ84+8NfaVhSIDAN4Wg7KJwZXd5Gybsj85JPVVE5W2bzRWhbzNQqFZrGD5KPEkp3U3q/U7PB7Qabh91DogSG7QXxxmzkfi9lxIrsa6Iup7qDSHw9E9oaVgzXeFRakA/MnG6oeAJGfNBQDM+Z/XdZVn/JPkN6QKr8nmUqN3//3xLga9sa+nXg4w3JgbMS/uPgCv8S0CcGJPOWXgfbJWyL0V7+nQqW+4kSb5l0gY6X1DQQ746AWpg17UAreMe5gDqgYrZ+fr1hpKvdJs6Ru/lGlUNLhWkCuBCJKrDcJ7N0sF4smbrVaAhy9SIq27YhuhXvuUzgvgboekV+Rs06X01qT7tII0y3+woBxxyRJr5X91CatSefQMQapJNRzxvVaYNuPGvj4f85+DAC6W/9vskW6fRNcIMlRVsXPlcgWD6FIWz5m7715lXknIWZ+id+xI4hL0kYICR6sMvUp4714ftltCyyNPJIBK+c4n8mIFeQBG2kR9uNck2LqQvsv0UBVu67eUfQsc98J9hIVh3CD4H2YUI9yc5h+3e5H6ybw5LoBG3GdVqHMC1Mrck3RqLLTt39X6018gjWCs56Uf2Q90pJnmdhk3QlcIsbluyg= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN8PR12MB3587.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(366004)(39860400002)(346002)(396003)(136003)(451199015)(76116006)(8676002)(66946007)(4326008)(64756008)(66446008)(66476007)(91956017)(66556008)(41300700001)(38070700005)(316002)(54906003)(110136005)(2906002)(86362001)(5660300002)(122000001)(38100700002)(33656002)(7416002)(8936002)(55016003)(83380400001)(6506007)(478600001)(7696005)(186003)(9686003)(71200400001)(52536014)(19627405001)(22166006);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?iynZLw+lWnlyJUuFnxCDxh0ai/Y+taz9/0TxacvKmUXxZ4pNx/vj+EH3gq?= =?iso-8859-1?Q?0kMRNyinvhUWXF0+Dv1Y4cs5JAOXfVXgJkAOXeCbCrfpqZ+SmSD6+2iTu9?= =?iso-8859-1?Q?JfDAQlLOb+EApigzE2fGA1hojOYbiJ5nyhl5lDFnNSx6vCD4tsvcPip0iN?= =?iso-8859-1?Q?CWMm0eO/nPD332qWUpH9yjCsQ2mLa8DKXXMrzkegu0kqIIVYA6LWVgZiak?= =?iso-8859-1?Q?XBi2N8vji5MuXW6gSOPRYWe6jaYxFGWvUZ7dvx8Gs+pIAAfsw3xzDMPJa3?= =?iso-8859-1?Q?+99t3QFFzFCh2UnLAcYGSyNiWjwi53Kp6hd1o3V8hqPD/5b+s9IVui3+n6?= =?iso-8859-1?Q?DRCm2+pIFNNeeBJN+6Zkil/gIGVJqChIH1alH/QyVEj4r6Dpaf1e0xg1oo?= =?iso-8859-1?Q?qXw4r2sO3Van9JOa0s3XjWjdUWGAWsUdP42Dx1J49POz3sM8B6zUGoW7RY?= =?iso-8859-1?Q?dmOfH+bP06K042aIMuu2APFoddmOZ4ZT2WBrmMWMp1eepo4pRvv0Wj7WC+?= =?iso-8859-1?Q?IwldBcHkyYiOnL9QEdbY7XMUUbvfefCQvxXHXjtMA04pEwrrsRzYcHVl9r?= =?iso-8859-1?Q?gujegkpoZw45y0K94imEYeP9SOI5T8JrxaWyEz80wIgA8TmDU+vUHkKbIU?= =?iso-8859-1?Q?355p3L2B3SYOfjPQWdKpTjRsWhzH0VEilO1oKJYh5n/8BfpevEC05/CXHT?= =?iso-8859-1?Q?Ki74tm/rBzeQ/sx0LhoG77g87tHe3iQrZReyTqJDD5DhJytbsG3SBe2l5x?= =?iso-8859-1?Q?y1m4rpSBKmbitpmm3dAVUEL9E1gpYtReoRC3fQMnH3B7DsBFRYCrm2Jnrp?= =?iso-8859-1?Q?lrZjuIkRfo2EDp0IZ4p678cxs6+rYuytefwhmAFL375aO8XVQSNQbz6Bp4?= =?iso-8859-1?Q?ME2jaZfPah2N+7ZkNYiBMddxlpD6HhxWEHHYDl1UOFR+jSZXZYuUVSiAy8?= =?iso-8859-1?Q?kd7PU7US3RNFtjp8ziClQ1l4d81aEpWOezLtL0QkpJQ9uxMAfFT08Tn7HD?= =?iso-8859-1?Q?oYHFRoKyju0lOdH+jO0XRqhALrdvSE+ZYMNlnvu+ssJBY1reuoP8PITbjS?= =?iso-8859-1?Q?shjfR2GeMIY2+MyA2n178lkildN8e1htCB3jjZ+nrId6GhyuYmJBgiUxeg?= =?iso-8859-1?Q?/ZZRCm6SNho0bCvCvxk1+EuxH10FnZmamF+mntK/GGQJsVE3rolrGrZSfC?= =?iso-8859-1?Q?or3IvTs7hVKnQ7Kl+pmQtDSsII82ARieIFwRv8NMNb9fSC6r2iopaueEbZ?= =?iso-8859-1?Q?ZKevTWk0gaGoGeWxBtxLFbxdMdT8ht/bPM44CXQfvzlGjdOLNbZzp6XatM?= =?iso-8859-1?Q?CuBBwim3YZHGW4b0ALlT5p4ljVpgd7agKWDaNibleWniSQgxnrbYAB4RMH?= =?iso-8859-1?Q?el1dnVVzSQWY/ChT+j+AoYDQnR2kt1mOCJ36jHVkO7zVtleMHwHcjrIure?= =?iso-8859-1?Q?uaqTWtqwach2GuoYjnh7O4LbVq2UaBPllK+Ic43QJWGfBAeFBpC71FEVGD?= =?iso-8859-1?Q?gl8K0O552ZFeBk86gvnLQb54wBSYZA/EPzBj4uJmG7dem2vY2gJ6Cw4URu?= =?iso-8859-1?Q?fkShI4MISlH9rikntgbzTE8VpRazk/urs0+vf+yIaPMHAIvK1IRYN3DEPv?= =?iso-8859-1?Q?snEYjiOFOkEazvqO719xzd754ELKRNf34laSo9hkA8BZYN6adqOFzry4wL?= =?iso-8859-1?Q?R4/A8b+WNO70/FyyDpg=3D?= Content-Type: multipart/alternative; boundary="_000_BN8PR12MB3587673F8EF2642D267E943D83F79BN8PR12MB3587namp_" MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d8e81b28-214b-4d4f-fe6b-08daecdf7696 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jan 2023 16:36:13.7503 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: idFrnxasVVJCk0pFQ8h95HH9zVeB9lUNVXY57oBtij/oJpQd8jBH9GAc94odtIIr X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5204 --_000_BN8PR12MB3587673F8EF2642D267E943D83F79BN8PR12MB3587namp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Sorry for the messed up mail. We currently have mail problems here at AMD. ________________________________ Von: Oleksii Moisieiev Gesendet: Montag, 2. Januar 2023 14:41 An: jgross@suse.com Cc: Oleksii Moisieiev ; Stefano Stabellini ; Oleksandr Tyshchenko ;= xen-devel@lists.xenproject.org ; linux-ker= nel@vger.kernel.org ; Sumit Semwal ; Koenig, Christian ; linux-media@= vger.kernel.org ; dri-devel@lists.freedesktop.= org ; linaro-mm-sig@lists.linaro.org Betreff: [PATCH v1 0/3] Add ioctls to map grant refs on the external backin= g storage Hello, Let me introduce the new ioctls, which are intended to allow gntdev to map scatter-gather table on top of the existing dmabuf, referenced by file descriptor. When using dma-buf exporter to create dma-buf with backing storage and map it to the grant refs, provided from the domain, we've met a problem, that several HW (i.MX8 gpu in our case) do not support external buffer and requires backing storage to be created using it's native tools. That's why new ioctls were added to be able to pass existing dma-buffer fd as input parameter and use it as backing storage to export to refs. This is a pretty big NAK from my side to this approach. If you need to replace a file descriptor number local to your process then = you can simply use dup2() from userspace. If your intention here is to replace the backing store of the fd on all pro= cesses which currently have it open then please just completely forget that= . This will *NEVER* ever work correctly. Regards, Christian. Following calls were added: IOCTL_GNTDEV_DMABUF_MAP_REFS_TO_BUF - map existing buffer as the backing storage and export it to the provided grant refs; IOCTL_GNTDEV_DMABUF_MAP_RELEASE - detach buffer from the grant table and set notification to unmap grant refs before releasing the external buffer. After this call the external buffer should be detroyed. IOCTL_GNTDEV_DMABUF_MAP_WAIT_RELEASED - wait for timeout until buffer is completely destroyed and gnt refs unmapped so domain could free grant pages. Should be called after buffer was destoyed. Our setup is based on IMX8QM board. We're trying to implement zero-copy support for DomU graphics using Wayland zwp_linux_dmabuf_v1_interface implementation. For dma-buf exporter we used i.MX8 gpu native tools to create backing storage grant-refs, received from DomU. Buffer for the backing storage was allocated using gbm_bo_create call because gpu do not support external buffer and requires backing storage to be created using it's native tools (eglCreateImageKHR returns EGL_NO_IMAGE_KHR for buffers, which were not created using gbm_bo_create). This behaviour was also tested on Qemu setup using DRM_IOCTL_MODE_CREATE_DUMB call to create backing storage buffer. --- Oleksii Moisieiev (3): xen/grant-table: save page_count on map and use if during async unmapping dma-buf: add dma buffer release notifier callback xen/grant-table: add new ioctls to map dmabuf to existing fd drivers/dma-buf/dma-buf.c | 44 ++++ drivers/xen/gntdev-common.h | 8 +- drivers/xen/gntdev-dmabuf.c | 416 +++++++++++++++++++++++++++++++++++- drivers/xen/gntdev-dmabuf.h | 7 + drivers/xen/gntdev.c | 101 ++++++++- drivers/xen/grant-table.c | 73 +++++-- include/linux/dma-buf.h | 15 ++ include/uapi/xen/gntdev.h | 62 ++++++ include/xen/grant_table.h | 8 + 9 files changed, 703 insertions(+), 31 deletions(-) -- 2.25.1 --_000_BN8PR12MB3587673F8EF2642D267E943D83F79BN8PR12MB3587namp_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable

[AMD Official Use Only - General]


Sorry = for the messed up mail. We currently have mail problems here at AMD.=

Von: Oleksii Moisieiev <= Oleksii_Moisieiev@epam.com>
Gesendet: Montag, 2. Januar 2023 14:41
An: jgross@suse.com <jgross@suse.com>
Cc: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>; Stefano St= abellini <sstabellini@kernel.org>; Oleksandr Tyshchenko <Oleksandr= _Tyshchenko@epam.com>; xen-devel@lists.xenproject.org <xen-devel@list= s.xenproject.org>; linux-kernel@vger.kernel.org <linux-kernel@vger.ke= rnel.org>; Sumit Semwal <sumit.semwal@linaro.org>; Koenig, Christian <Christ= ian.Koenig@amd.com>; linux-media@vger.kernel.org <linux-media@vger.ke= rnel.org>; dri-devel@lists.freedesktop.org <dri-devel@lists.freedeskt= op.org>; linaro-mm-sig@lists.linaro.org <linaro-mm-sig@lists.linaro.o= rg>
Betreff: [PATCH v1 0/3] Add ioctls to map grant refs on the external= backing storage
 
Hello,

Let me introduce the new ioctls, which are intended to allow gntdev to
map scatter-gather table on top of the existing dmabuf, referenced by
file descriptor.

When using dma-buf exporter to create dma-buf with backing storage and
map it to the grant refs, provided from the domain, we've met a problem, that several HW (i.MX8 gpu in our case) do not support external buffer
and requires backing storage to be created using it's native tools.
That's why new ioctls were added to be able to pass existing dma-buffer
fd as input parameter and use it as backing storage to export to refs.

This is a pretty big NAK from my si= de to this approach.

If you need to replace a file descr= iptor number local to your process then you can simply use dup2() from user= space.

If your intention here is to replac= e the backing store of the fd on all processes which currently have it open= then please just completely forget that. This will *NEVER* ever work corre= ctly.

Regards,
Christian.

Following calls were added:
IOCTL_GNTDEV_DMABUF_MAP_REFS_TO_BUF - map existing buffer as the backing storage and export it to the provided grant refs;
IOCTL_GNTDEV_DMABUF_MAP_RELEASE - detach buffer from the grant table and set notification to unmap grant refs before releasing the external
buffer. After this call the external buffer should be detroyed.
IOCTL_GNTDEV_DMABUF_MAP_WAIT_RELEASED - wait for timeout until buffer is completely destroyed and gnt refs unmapped so domain could free grant
pages. Should be called after buffer was destoyed.

Our setup is based on IMX8QM board. We're trying to implement zero-copy
support for DomU graphics using Wayland zwp_linux_dmabuf_v1_interface
implementation.

For dma-buf exporter we used i.MX8 gpu native tools to create backing
storage grant-refs, received from DomU. Buffer for the backing storage was<= br> allocated using gbm_bo_create call because gpu do not support external
buffer and requires backing storage to be created using it's native tools (eglCreateImageKHR returns EGL_NO_IMAGE_KHR for buffers, which were not
created using gbm_bo_create).

This behaviour was also tested on Qemu setup using
DRM_IOCTL_MODE_CREATE_DUMB call to create backing storage buffer.

---
Oleksii Moisieiev (3):
  xen/grant-table: save page_count on map and use if during async
    unmapping
  dma-buf: add dma buffer release notifier callback
  xen/grant-table: add new ioctls to map dmabuf to existing fd

 drivers/dma-buf/dma-buf.c   |  44 ++++
 drivers/xen/gntdev-common.h |   8 +-
 drivers/xen/gntdev-dmabuf.c | 416 +++++++++++++++++++++++++++++++++++= -
 drivers/xen/gntdev-dmabuf.h |   7 +
 drivers/xen/gntdev.c        | 101 = ++++++++-
 drivers/xen/grant-table.c   |  73 +++++--
 include/linux/dma-buf.h     |  15 ++
 include/uapi/xen/gntdev.h   |  62 ++++++
 include/xen/grant_table.h   |   8 +
 9 files changed, 703 insertions(+), 31 deletions(-)

--
2.25.1
--_000_BN8PR12MB3587673F8EF2642D267E943D83F79BN8PR12MB3587namp_-- From xen-devel-bounces@lists.xenproject.org Mon Jan 02 17:47:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 Jan 2023 17:47:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470373.729856 (Exim 4.92) (envelope-from ) id 1pCOtq-0005iK-UH; Mon, 02 Jan 2023 17:47:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470373.729856; Mon, 02 Jan 2023 17:47:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCOtq-0005iD-Pb; Mon, 02 Jan 2023 17:47:02 +0000 Received: by outflank-mailman (input) for mailman id 470373; Mon, 02 Jan 2023 17:47:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCOtp-0005i7-K5 for xen-devel@lists.xenproject.org; Mon, 02 Jan 2023 17:47:02 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 73bfb719-8ac5-11ed-b8d0-410ff93cb8f0; Mon, 02 Jan 2023 18:46:58 +0100 (CET) Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-563-STQ25Pb-PuC45ur2pQwQaQ-1; Mon, 02 Jan 2023 12:46:55 -0500 Received: by mail-wm1-f71.google.com with SMTP id m38-20020a05600c3b2600b003d1fc5f1f80so18795768wms.1 for ; Mon, 02 Jan 2023 09:46:55 -0800 (PST) Received: from redhat.com ([2.52.151.85]) by smtp.gmail.com with ESMTPSA id bo19-20020a056000069300b00294176c2c01sm7280930wrb.86.2023.01.02.09.46.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Jan 2023 09:46:53 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 73bfb719-8ac5-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672681617; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UEwMEVORwGQdUkaE8aygrUja5mjHxP1iCKWj4zKLawg=; b=b9j4b2WJh/hMUN9HVjw95rHqJFkAe0A9GUeWljyrD+0F5WyW3F6J9EW67bysgQtCvOy2pa wTDqmRAg3UlAzT/JF6j0ovYqoSm7L1ixlauWHEvxVvURagigSkfe+840IQsSwX9uuqhMnX c1iMy6PQY/ee9Ie7wuNPu63J7zxM+9I= X-MC-Unique: STQ25Pb-PuC45ur2pQwQaQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UEwMEVORwGQdUkaE8aygrUja5mjHxP1iCKWj4zKLawg=; b=rjpjM5M0jhdX60KDfM5Xah0bwGWOPnFmMfXoi7NSA9QdWYyFVHMaAtYypuMFClgqkO 1OSqBQJm6jReFaY2Z3k7J94GvdX/zsffrNatGLQZlSK23KuR9dOF/4KaEIv6mWM5b6Oa vNgnfbzQOw6Cde50miQVcKBLnfydy4K90TxVk5G0gIWV9DIv6d66+YZ0c8SyvJfdFnRv IoiRiysEcgeNB25MN4Ru9v6kIZN0jc0l7GnkyHVCrce2d9MLajNKyiq2OSlZlCtKedAI CVLFB9Au0tB5nPLpXbOyiFNO7RnjKLXpKxH6ANrfMHFMvvFoa32a/PJ2tudyn2n0TEu6 C3cA== X-Gm-Message-State: AFqh2kqHiC4lbRnT0yLN1qFYFFt8/INs4I7DGKbXaApNd9keS+4RthuH 9Qm8Ee/vqfzi2RaD2Y0HKtFgngxSTnn4UXh4fvP/gXq09XkKK8ysFOJrHyy2Wa1MGARwBh7JFjR Bi4xjQBC//nO4a4zbXbG8/P3DOKA= X-Received: by 2002:adf:9dd1:0:b0:242:165c:95ed with SMTP id q17-20020adf9dd1000000b00242165c95edmr25290017wre.48.1672681614740; Mon, 02 Jan 2023 09:46:54 -0800 (PST) X-Google-Smtp-Source: AMrXdXt0p5m4ylYbBESCUKrBIMR1ZDEWRey8pWymXQEuhRcdaKS8YrAUzdmCxicDkxYUA8Ea68YynA== X-Received: by 2002:adf:9dd1:0:b0:242:165c:95ed with SMTP id q17-20020adf9dd1000000b00242165c95edmr25290000wre.48.1672681614461; Mon, 02 Jan 2023 09:46:54 -0800 (PST) Date: Mon, 2 Jan 2023 12:46:49 -0500 From: "Michael S. Tsirkin" To: Chuck Zmudzinski Cc: qemu-devel@nongnu.org, Stefano Stabellini , Anthony Perard , Paul Durrant , Paolo Bonzini , Richard Henderson , Eduardo Habkost , Marcel Apfelbaum , xen-devel@lists.xenproject.org, alex.williamson@redhat.com Subject: Re: [PATCH v6] xen/pt: reserve PCI slot 2 for Intel igd-passthru Message-ID: <20230102124605-mutt-send-email-mst@kernel.org> References: <830263507e8f1a24a94f81909d5102c4b204e938.1672615492.git.brchuckz.ref@aol.com> <830263507e8f1a24a94f81909d5102c4b204e938.1672615492.git.brchuckz@aol.com> MIME-Version: 1.0 In-Reply-To: <830263507e8f1a24a94f81909d5102c4b204e938.1672615492.git.brchuckz@aol.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Jan 01, 2023 at 06:52:03PM -0500, Chuck Zmudzinski wrote: > Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, > as noted in docs/igd-assign.txt in the Qemu source code. > > Currently, when the xl toolstack is used to configure a Xen HVM guest with > Intel IGD passthrough to the guest with the Qemu upstream device model, > a Qemu emulated PCI device will occupy slot 2 and the Intel IGD will occupy > a different slot. This problem often prevents the guest from booting. > > The only available workaround is not good: Configure Xen HVM guests to use > the old and no longer maintained Qemu traditional device model available > from xenbits.xen.org which does reserve slot 2 for the Intel IGD. > > To implement this feature in the Qemu upstream device model for Xen HVM > guests, introduce the following new functions, types, and macros: > > * XEN_PT_DEVICE_CLASS declaration, based on the existing TYPE_XEN_PT_DEVICE > * XEN_PT_DEVICE_GET_CLASS macro helper function for XEN_PT_DEVICE_CLASS > * typedef XenPTQdevRealize function pointer > * XEN_PCI_IGD_SLOT_MASK, the value of slot_reserved_mask to reserve slot 2 > * xen_igd_reserve_slot and xen_igd_clear_slot functions > > The new xen_igd_reserve_slot function uses the existing slot_reserved_mask > member of PCIBus to reserve PCI slot 2 for Xen HVM guests configured using > the xl toolstack with the gfx_passthru option enabled, which sets the > igd-passthru=on option to Qemu for the Xen HVM machine type. > > The new xen_igd_reserve_slot function also needs to be implemented in > hw/xen/xen_pt_stub.c to prevent FTBFS during the link stage for the case > when Qemu is configured with --enable-xen and --disable-xen-pci-passthrough, > in which case it does nothing. > > The new xen_igd_clear_slot function overrides qdev->realize of the parent > PCI device class to enable the Intel IGD to occupy slot 2 on the PCI bus > since slot 2 was reserved by xen_igd_reserve_slot when the PCI bus was > created in hw/i386/pc_piix.c for the case when igd-passthru=on. > > Move the call to xen_host_pci_device_get, and the associated error > handling, from xen_pt_realize to the new xen_igd_clear_slot function to > initialize the device class and vendor values which enables the checks for > the Intel IGD to succeed. The verification that the host device is an > Intel IGD to be passed through is done by checking the domain, bus, slot, > and function values as well as by checking that gfx_passthru is enabled, > the device class is VGA, and the device vendor in Intel. > > Signed-off-by: Chuck Zmudzinski I'm not sure why is the issue xen specific. Can you explain? Doesn't it affect kvm too? > --- > Notes that might be helpful to reviewers of patched code in hw/xen: > > The new functions and types are based on recommendations from Qemu docs: > https://qemu.readthedocs.io/en/latest/devel/qom.html > > Notes that might be helpful to reviewers of patched code in hw/i386: > > The small patch to hw/i386/pc_piix.c is protected by CONFIG_XEN so it does > not affect builds that do not have CONFIG_XEN defined. > > xen_igd_gfx_pt_enabled() in the patched hw/i386/pc_piix.c file is an > existing function that is only true when Qemu is built with > xen-pci-passthrough enabled and the administrator has configured the Xen > HVM guest with Qemu's igd-passthru=on option. > > v2: Remove From: tag at top of commit message > > v3: Changed the test for the Intel IGD in xen_igd_clear_slot: > > if (is_igd_vga_passthrough(&s->real_device) && > (s->real_device.vendor_id == PCI_VENDOR_ID_INTEL)) { > > is changed to > > if (xen_igd_gfx_pt_enabled() && (s->hostaddr.slot == 2) > && (s->hostaddr.function == 0)) { > > I hoped that I could use the test in v2, since it matches the > other tests for the Intel IGD in Qemu and Xen, but those tests > do not work because the necessary data structures are not set with > their values yet. So instead use the test that the administrator > has enabled gfx_passthru and the device address on the host is > 02.0. This test does detect the Intel IGD correctly. > > v4: Use brchuckz@aol.com instead of brchuckz@netscape.net for the author's > email address to match the address used by the same author in commits > be9c61da and c0e86b76 > > Change variable for XEN_PT_DEVICE_CLASS: xptc changed to xpdc > > v5: The patch of xen_pt.c was re-worked to allow a more consistent test > for the Intel IGD that uses the same criteria as in other places. > This involved moving the call to xen_host_pci_device_get from > xen_pt_realize to xen_igd_clear_slot and updating the checks for the > Intel IGD in xen_igd_clear_slot: > > if (xen_igd_gfx_pt_enabled() && (s->hostaddr.slot == 2) > && (s->hostaddr.function == 0)) { > > is changed to > > if (is_igd_vga_passthrough(&s->real_device) && > s->real_device.domain == 0 && s->real_device.bus == 0 && > s->real_device.dev == 2 && s->real_device.func == 0 && > s->real_device.vendor_id == PCI_VENDOR_ID_INTEL) { > > Added an explanation for the move of xen_host_pci_device_get from > xen_pt_realize to xen_igd_clear_slot to the commit message. > > Rebase. > > v6: Fix logging by removing these lines from the move from xen_pt_realize > to xen_igd_clear_slot that was done in v5: > > XEN_PT_LOG(d, "Assigning real physical device %02x:%02x.%d" > " to devfn 0x%x\n", > s->hostaddr.bus, s->hostaddr.slot, s->hostaddr.function, > s->dev.devfn); > > This log needs to be in xen_pt_realize because s->dev.devfn is not > set yet in xen_igd_clear_slot. > > Sorry for the extra noise. > > hw/i386/pc_piix.c | 3 +++ > hw/xen/xen_pt.c | 46 +++++++++++++++++++++++++++++++++++--------- > hw/xen/xen_pt.h | 16 +++++++++++++++ > hw/xen/xen_pt_stub.c | 4 ++++ > 4 files changed, 60 insertions(+), 9 deletions(-) > > diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c > index b48047f50c..bc5efa4f59 100644 > --- a/hw/i386/pc_piix.c > +++ b/hw/i386/pc_piix.c > @@ -405,6 +405,9 @@ static void pc_xen_hvm_init(MachineState *machine) > } > > pc_xen_hvm_init_pci(machine); > + if (xen_igd_gfx_pt_enabled()) { > + xen_igd_reserve_slot(pcms->bus); > + } > pci_create_simple(pcms->bus, -1, "xen-platform"); > } > #endif > diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c > index 0ec7e52183..7fae1e7a6f 100644 > --- a/hw/xen/xen_pt.c > +++ b/hw/xen/xen_pt.c > @@ -780,15 +780,6 @@ static void xen_pt_realize(PCIDevice *d, Error **errp) > s->hostaddr.bus, s->hostaddr.slot, s->hostaddr.function, > s->dev.devfn); > > - xen_host_pci_device_get(&s->real_device, > - s->hostaddr.domain, s->hostaddr.bus, > - s->hostaddr.slot, s->hostaddr.function, > - errp); > - if (*errp) { > - error_append_hint(errp, "Failed to \"open\" the real pci device"); > - return; > - } > - > s->is_virtfn = s->real_device.is_virtfn; > if (s->is_virtfn) { > XEN_PT_LOG(d, "%04x:%02x:%02x.%d is a SR-IOV Virtual Function\n", > @@ -950,11 +941,47 @@ static void xen_pci_passthrough_instance_init(Object *obj) > PCI_DEVICE(obj)->cap_present |= QEMU_PCI_CAP_EXPRESS; > } > > +void xen_igd_reserve_slot(PCIBus *pci_bus) > +{ > + XEN_PT_LOG(0, "Reserving PCI slot 2 for IGD\n"); > + pci_bus->slot_reserved_mask |= XEN_PCI_IGD_SLOT_MASK; > +} > + > +static void xen_igd_clear_slot(DeviceState *qdev, Error **errp) > +{ > + ERRP_GUARD(); > + PCIDevice *pci_dev = (PCIDevice *)qdev; > + XenPCIPassthroughState *s = XEN_PT_DEVICE(pci_dev); > + XenPTDeviceClass *xpdc = XEN_PT_DEVICE_GET_CLASS(s); > + PCIBus *pci_bus = pci_get_bus(pci_dev); > + > + xen_host_pci_device_get(&s->real_device, > + s->hostaddr.domain, s->hostaddr.bus, > + s->hostaddr.slot, s->hostaddr.function, > + errp); > + if (*errp) { > + error_append_hint(errp, "Failed to \"open\" the real pci device"); > + return; > + } > + > + if (is_igd_vga_passthrough(&s->real_device) && > + s->real_device.domain == 0 && s->real_device.bus == 0 && > + s->real_device.dev == 2 && s->real_device.func == 0 && > + s->real_device.vendor_id == PCI_VENDOR_ID_INTEL) { > + pci_bus->slot_reserved_mask &= ~XEN_PCI_IGD_SLOT_MASK; > + XEN_PT_LOG(pci_dev, "Intel IGD found, using slot 2\n"); > + } > + xpdc->pci_qdev_realize(qdev, errp); > +} > + > static void xen_pci_passthrough_class_init(ObjectClass *klass, void *data) > { > DeviceClass *dc = DEVICE_CLASS(klass); > PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); > > + XenPTDeviceClass *xpdc = XEN_PT_DEVICE_CLASS(klass); > + xpdc->pci_qdev_realize = dc->realize; > + dc->realize = xen_igd_clear_slot; > k->realize = xen_pt_realize; > k->exit = xen_pt_unregister_device; > k->config_read = xen_pt_pci_read_config; > @@ -977,6 +1004,7 @@ static const TypeInfo xen_pci_passthrough_info = { > .instance_size = sizeof(XenPCIPassthroughState), > .instance_finalize = xen_pci_passthrough_finalize, > .class_init = xen_pci_passthrough_class_init, > + .class_size = sizeof(XenPTDeviceClass), > .instance_init = xen_pci_passthrough_instance_init, > .interfaces = (InterfaceInfo[]) { > { INTERFACE_CONVENTIONAL_PCI_DEVICE }, > diff --git a/hw/xen/xen_pt.h b/hw/xen/xen_pt.h > index e7c4316a7d..40b31b5263 100644 > --- a/hw/xen/xen_pt.h > +++ b/hw/xen/xen_pt.h > @@ -3,6 +3,7 @@ > > #include "hw/xen/xen_common.h" > #include "hw/pci/pci.h" > +#include "hw/pci/pci_bus.h" > #include "xen-host-pci-device.h" > #include "qom/object.h" > > @@ -41,7 +42,20 @@ typedef struct XenPTReg XenPTReg; > #define TYPE_XEN_PT_DEVICE "xen-pci-passthrough" > OBJECT_DECLARE_SIMPLE_TYPE(XenPCIPassthroughState, XEN_PT_DEVICE) > > +#define XEN_PT_DEVICE_CLASS(klass) \ > + OBJECT_CLASS_CHECK(XenPTDeviceClass, klass, TYPE_XEN_PT_DEVICE) > +#define XEN_PT_DEVICE_GET_CLASS(obj) \ > + OBJECT_GET_CLASS(XenPTDeviceClass, obj, TYPE_XEN_PT_DEVICE) > + > +typedef void (*XenPTQdevRealize)(DeviceState *qdev, Error **errp); > + > +typedef struct XenPTDeviceClass { > + PCIDeviceClass parent_class; > + XenPTQdevRealize pci_qdev_realize; > +} XenPTDeviceClass; > + > uint32_t igd_read_opregion(XenPCIPassthroughState *s); > +void xen_igd_reserve_slot(PCIBus *pci_bus); > void igd_write_opregion(XenPCIPassthroughState *s, uint32_t val); > void xen_igd_passthrough_isa_bridge_create(XenPCIPassthroughState *s, > XenHostPCIDevice *dev); > @@ -76,6 +90,8 @@ typedef int (*xen_pt_conf_byte_read) > > #define XEN_PCI_INTEL_OPREGION 0xfc > > +#define XEN_PCI_IGD_SLOT_MASK 0x4UL /* Intel IGD slot_reserved_mask */ > + > typedef enum { > XEN_PT_GRP_TYPE_HARDWIRED = 0, /* 0 Hardwired reg group */ > XEN_PT_GRP_TYPE_EMU, /* emul reg group */ > diff --git a/hw/xen/xen_pt_stub.c b/hw/xen/xen_pt_stub.c > index 2d8cac8d54..5c108446a8 100644 > --- a/hw/xen/xen_pt_stub.c > +++ b/hw/xen/xen_pt_stub.c > @@ -20,3 +20,7 @@ void xen_igd_gfx_pt_set(bool value, Error **errp) > error_setg(errp, "Xen PCI passthrough support not built in"); > } > } > + > +void xen_igd_reserve_slot(PCIBus *pci_bus) > +{ > +} > -- > 2.39.0 From xen-devel-bounces@lists.xenproject.org Mon Jan 02 20:49:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 Jan 2023 20:49:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470382.729867 (Exim 4.92) (envelope-from ) id 1pCRk0-0006Hm-7P; Mon, 02 Jan 2023 20:49:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470382.729867; Mon, 02 Jan 2023 20:49:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCRk0-0006Hf-4B; Mon, 02 Jan 2023 20:49:04 +0000 Received: by outflank-mailman (input) for mailman id 470382; Mon, 02 Jan 2023 20:49:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCRjy-0006HZ-4l for xen-devel@lists.xenproject.org; Mon, 02 Jan 2023 20:49:02 +0000 Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e08094fb-8ade-11ed-b8d0-410ff93cb8f0; Mon, 02 Jan 2023 21:48:58 +0100 (CET) Received: from pps.filterd (m0174681.ppops.net [127.0.0.1]) by mx0b-0039f301.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 302FvnSs017390; Mon, 2 Jan 2023 20:48:48 GMT Received: from eur05-am6-obe.outbound.protection.outlook.com (mail-am6eur05lp2113.outbound.protection.outlook.com [104.47.18.113]) by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3mtcd4n2ym-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 02 Jan 2023 20:48:47 +0000 Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23) by DB4PR03MB9388.eurprd03.prod.outlook.com (2603:10a6:10:3f8::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Mon, 2 Jan 2023 20:48:45 +0000 Received: from PA4PR03MB7136.eurprd03.prod.outlook.com ([fe80::2da6:6d63:389b:3552]) by PA4PR03MB7136.eurprd03.prod.outlook.com ([fe80::2da6:6d63:389b:3552%9]) with mapi id 15.20.5944.019; Mon, 2 Jan 2023 20:48:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e08094fb-8ade-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZY5F6RkHCoYxBoKv7EDZQHoaek3xW7u5Hm+FDvD8RHAG7RMqEZgXY1nNHR9pkl8gZyr5lk6pi18a1NmyEpyRY5orZ9/aD5NiXPgXO2+cmXpek9FOK1UG7qNAbKtbEYipmAPJXrGyPpivsnOL6Em95nSqLJnWOxjNlA6WvJIwpbIBEpubYfpNo0Jln2DpgBEH4QrqTHDnFI3mkZqFvK/YUykP0oYXjJctg9S6hRaghU7PoT2d99fMaGtiK6gqRIh+OIyAmH/RAv0Tiqzcu0gHPEV68X5Ie5ktiEPnHKRi/zDS8TQt3iXuUfhFscPq6yLz7k/szIlNtHmnUqy1f/XR1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+E3TXzxPss9HYZ06zJckRnc/PGr5FuEsdgCcfgst9PQ=; b=VcRJLxHluv948WS8AhgDKvVx3ERiEAmeHRhgLi8ssM/NuwDQkU/Oh8KBQvmHvqyiLeKjq42w8+gsNxs4OReRY+l4OoHyGRRyTetydb46N++jQDl93YeikSEcIwRFSNxMYuiHp8lKrRfzwbsHqXdcSXcC7X3LG1cb7wrQRtJxWLUID1VINhgCVsj2o3TX2ITFJ2KzbKqywhjFVj4rmwwbo6EGe/M0yviLbtb35+Fv9tjcCR8m79c1RosJJbpBWUy3Y3iegzqOSomFsiWfl6MUh9zSQI9J7v2ffU78RgXTMp6T4vqHbvo4L5zcQziKjf29OGUUEnGXbx02SANMYqRinw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+E3TXzxPss9HYZ06zJckRnc/PGr5FuEsdgCcfgst9PQ=; b=bwAkRATXco11uanrTRzXnTaT66HVkj96Et4g7dCRI1yWQutbnBpC/pdaSA4cDzufB5CzVvJCYN/+tZLZzy0TFlDRv8zc/tfDR8nWPPv1OJ0+aIEHHQ3cXmqwxd4Vs5DFjD5COOjXMySg/1n6mDbF0y/VAl2+czOZE2nYvHHFk3DA0Da9NxoDFzam8Nc1Lra4TBK1JtvhdWd+bMinHPpCEZ1TW2rxQM3MkQ+icUDZNRTWjOZiXaGMbHr06SOdVZN8NT8GZ0Viur3Pu6wO2ZAVMKiSOfmjlKcCB4tiGI0ohMENduxxzKL+cGvrTO7s1+fSBDocJ1WrlVBs0UgjXZawgQ== From: Oleksii Moisieiev To: "Koenig, Christian" , "jgross@suse.com" CC: Stefano Stabellini , Oleksandr Tyshchenko , "xen-devel@lists.xenproject.org" , "linux-kernel@vger.kernel.org" , Sumit Semwal , "linux-media@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linaro-mm-sig@lists.linaro.org" Subject: Re: AW: [PATCH v1 0/3] Add ioctls to map grant refs on the external backing storage Thread-Topic: AW: [PATCH v1 0/3] Add ioctls to map grant refs on the external backing storage Thread-Index: AQHZHq/2qxwFjlIdpkaeJi9xnPE21a6LUk6xgABHXgA= Date: Mon, 2 Jan 2023 20:48:44 +0000 Message-ID: <3066964b-511f-6314-bc8f-79e387712013@epam.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PA4PR03MB7136:EE_|DB4PR03MB9388:EE_ x-ms-office365-filtering-correlation-id: 62401e1d-d955-4914-1b8e-08daed02bd5d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: undBv+hWy72zwCvSlrHqV7I9nQOzX/iM/BxUaY+m/sdfGuNWlVWuhFcXslxMFEfdFvQ/VL07xz21DiMVzMpU0Wd9hFbHY2TtPNfRKQjrSTguaOtCl45ILx05D8iIDtnzzRcLsN8/4TALcks83Ig3hR9aVeJdWOj00KxsIaFqYn+Z9QowyARfIHS/vNXuvW3ZnQ+PkozF9jbDknEQ1k3J02gtPWeK4t5Z4ZzSs01atGfjXAA//eM4SmPp4YZI9jHllTDHDsrVp817uldLL9ZLJi9G2cLYbPCJw4jRuQ9Yma48xhvBunBtLGxiGtmQPYYgGE+/GN5FCrFyei5D/kMZ+mDhxMXOD6MnWOqwKD28b5zwFLnaxPrn+7PkeG4c8WiJ6Q547ui468Vj3Z3aip8DJE1Crzk5sKtHHAoYIi6wOFjtjvZKP1KbVNyazEA2n4RmCLS2DeXAT1L+DK9SDXa8uQXEmxR9XHlOXvoLxS4M7z4Ez753BNbOYe4pBqFOjETNezWycBYGhL6PGn9M98np3hSTNVyuGi1IOBpTHRD/HsVuDsEaVnryfa8IGBUoGDoZ7EEtujqTQjy6Y76RU833xLkzfzvveJvMWOhMFyC/rEH7odRoxrNMXkavMIRm/lEtjLSMjCflqu8OjfS8PLFvSXUFE6HWXMYy8z2HF7UPiquUGyuSiMaBR0FBM8QKNXjuKvUGzkx/a4DIJ4dvIlNIqRq1njkJfnU9LC/0rlWsTPKKZVmHvJOBioQv2JQlHI+r x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(366004)(39860400002)(376002)(396003)(451199015)(38070700005)(122000001)(38100700002)(36756003)(86362001)(31696002)(6506007)(53546011)(66446008)(91956017)(76116006)(66946007)(2616005)(66476007)(66556008)(64756008)(478600001)(316002)(6512007)(26005)(186003)(71200400001)(55236004)(31686004)(54906003)(110136005)(19627405001)(6486002)(8676002)(2906002)(41300700001)(4326008)(8936002)(83380400001)(5660300002)(22166006)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NXBIYk9DTTl0a3ozaXFBbGI4MVc4bTJEWFZCR1krZTlnVWVjNDc1SG1peFda?= =?utf-8?B?U3ZPM0tTaU5ONnpaWDcycmloWnhXZGx2bTZOY3FCdW43VmUvcmw3OTdwcDIz?= =?utf-8?B?TEd2SzdHVngvVE9NWksxQTJqdDhCelVXdGtaWnJ2T3RKZTV3b3FJMmpicCtM?= =?utf-8?B?WUtqSzV1QkRPVWVFSzNMU21Cd3VPQzc4ZWo1TFNjZmg4cFhqNFZiK3hBekVa?= =?utf-8?B?L3ZESnI1ZXpJWEtuU0cvSTJIYUZjQ0VDdkJvVWtURk1WTG51WXNkT2ZpQWdv?= =?utf-8?B?MS9oOUp2TWpyYTF0OGM0NzBMczhwUUJWMlZnQVgwV24xVVIvSW5IenR6YjhB?= =?utf-8?B?Q0duRy9vK1d3aWpORjlRb2Z3NG81cU9sdVBicGpCdW94dWhsckZ4ellKK1dS?= =?utf-8?B?TmFyV0JiekV0SU12R2YzWTUzeWlvQnplRk1kUFhiOWoxRXpyUndzaE0xTkN5?= =?utf-8?B?LzUvSFgvQS9GeE5tU045UHpFTEJCVHRIR0ppVzFnV0xNZFllV2dqbUdNcnhy?= =?utf-8?B?MUpyM2FyMFJKczBPYzBrbGlESnZZYU1yU0Q0aWlWN1ZEZ1NSVGdocHNmeG1j?= =?utf-8?B?SnN2cFZ6ZCtJWUYxaWlFd21jRUI1RXZTWENrekdqRkkzNGNkeEFISTlkNGhF?= =?utf-8?B?UHl1Nm93dG5RYjBWS214MW9WLzJwZG1mL1dYc0xHVGJRR3NmSjRoTjJuRmRt?= =?utf-8?B?amgxRTBiRThWWmVMVldEQmtabGNlQUY1RWVqOXhUelliUm8rS0RBNFZnMjds?= =?utf-8?B?Wm56MHQ3OWZjU0lkTzlIRUlCdlVkUmU2cHhvOVg3QkpxbzRvazJ6RUk1OFhL?= =?utf-8?B?eksxVEpiaU1VTWtQNS9lN1dXeE5iK1o5NEN3YTBrdVN5R2xQdDR1L1A3S1lY?= =?utf-8?B?Z1pubVJPd2tCV2tLMUpia2NEVG5jcEZUWjBkWDRRdnZQalkvQ3hNTGdmVnZi?= =?utf-8?B?ZmNOamhYRDQrVlpxVTlKYTk4NVJUM05QWGZNaDV5eG1wa3IyUEZwdXE5a04x?= =?utf-8?B?S1hsRzBpdjhPNzI1VG5YNWVUOXpudDVnTk9xWi9nVDRwWXY4TXZJSDVaRDd6?= =?utf-8?B?VXBnYXMzdm0vaUt1UXZ1M2pzUkl6SmhlVUtaUjZ4aytYVElEbnZBMUk2Sith?= =?utf-8?B?WUtYQUo3bzBtQm9RTTd1UmVrMEFleFRHUjNhVitNUGo5N0E5QzZKYW5xcEkx?= =?utf-8?B?WTJpQmFONThZUUN5UDI3KytzeW1IODR5V2JQQmNPR29iY2VjSTZka2Rya2Uw?= =?utf-8?B?Z25FVk9RTTJpVG9ueXY2dEpLdWNlWTFZSVg5d2pvUTJrVUJkWm9FeWszSTJ1?= =?utf-8?B?b3BhRjNQL3hMM3BRZDlaS2hOVE9YYzYzVkN1OEhqU1RRQmJuWHJITGc4Mmo1?= =?utf-8?B?NnowRXh6c25EaVYwZ2JJWkhJOHR6S0lkTmlTNjNnZDVSbzV3ZVNhUE44TWl4?= =?utf-8?B?RUx2VGNHZ2dWS05rY1UyZnRVa25PVktWNWVaYStobHgvMkp5b1dENUpxUjhE?= =?utf-8?B?L24waDlrSE42ZkM0a0JqSXhJYnAvemVJRGlkRlBTN1pkQmZtdTk0Q0hFWDlJ?= =?utf-8?B?V2ZqREx2UW9zbzFFYVdLbEhIY3ZJY2NpallrSDBXdThrVi95YzBiQVdrRHZI?= =?utf-8?B?d1hZdk9kN0FqR1lvUWJtcmNZak94VWVQZktmMFF0ekhWRk5lZlhjay9Pam1y?= =?utf-8?B?eEt2azlJeUowUlBhSE1kTDVVdWtqRXRNZmpXeDRvWGprYVorWWorTUVhNHRu?= =?utf-8?B?dGlvVUx2QVJEUDJlWVBnUVNLaGFBeGtUN1JKUnVUdStCRVZHK2IrTTAxMG1z?= =?utf-8?B?MjNsR1Q4MDhkWnVZUFpjZ01VcW5qNVlVc3djNnptR0gyVkR6U0FiWDk5Kytr?= =?utf-8?B?bk44Z01yNm5WQzZRSWZMOGJRbDFKb3VzYzNja3ZoU0w1K2htbS9TS3BIUExw?= =?utf-8?B?ZTVTVGRaMGtXVlRza080UkpwMTFOUUl2cVA0cXJLQldzazJPem1ad0VKNTFK?= =?utf-8?B?aThRODAxOW1JNll0MEJzcVU2blkzakJpcXpQdDBZdDh4RlFUbi85RnZ1QSth?= =?utf-8?B?SFFSOTB4ZUwyVG5LKzZ2Sm16MFM5OGxYUW16cnhOa3ZUajQ0WmpKUFU5N1Rp?= =?utf-8?B?UXpOV3pMdm1iVWlicWx4YmRRSC91S0VDRUk5eGdZWDBKdnBJQnA2cE0wN3E5?= =?utf-8?B?cnc9PQ==?= Content-Type: multipart/alternative; boundary="_000_3066964b511f6314bc8f79e387712013epamcom_" MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 62401e1d-d955-4914-1b8e-08daed02bd5d X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jan 2023 20:48:44.8590 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7fAbwh6e613qsKOD0RYyyQIRh1mUiUcvI52MWQUL33bL2zp0Mhi83Ta67QqjZwxYldzCDOzRVck24atwUZhyTQ2YR5B5+0uMuWTWk10dmuQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR03MB9388 X-Proofpoint-ORIG-GUID: kGRKwnH16VakoAE2LHJNXe6X_U5GkfkA X-Proofpoint-GUID: kGRKwnH16VakoAE2LHJNXe6X_U5GkfkA X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2023-01-02_12,2022-12-30_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 priorityscore=1501 suspectscore=0 bulkscore=0 adultscore=0 spamscore=0 impostorscore=0 mlxscore=0 mlxlogscore=999 clxscore=1015 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301020188 --_000_3066964b511f6314bc8f79e387712013epamcom_ Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 DQpPbiAwMi4wMS4yMyAxODozNiwgS29lbmlnLCBDaHJpc3RpYW4gd3JvdGU6DQoNCltBTUQgT2Zm aWNpYWwgVXNlIE9ubHkgLSBHZW5lcmFsXQ0KDQpTb3JyeSBmb3IgdGhlIG1lc3NlZCB1cCBtYWls LiBXZSBjdXJyZW50bHkgaGF2ZSBtYWlsIHByb2JsZW1zIGhlcmUgYXQgQU1ELg0KDQpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXw0KVm9uOiBPbGVrc2lpIE1vaXNpZWlldiA8T2xla3Np aV9Nb2lzaWVpZXZAZXBhbS5jb20+PG1haWx0bzpPbGVrc2lpX01vaXNpZWlldkBlcGFtLmNvbT4N Ckdlc2VuZGV0OiBNb250YWcsIDIuIEphbnVhciAyMDIzIDE0OjQxDQpBbjogamdyb3NzQHN1c2Uu Y29tPG1haWx0bzpqZ3Jvc3NAc3VzZS5jb20+IDxqZ3Jvc3NAc3VzZS5jb20+PG1haWx0bzpqZ3Jv c3NAc3VzZS5jb20+DQpDYzogT2xla3NpaSBNb2lzaWVpZXYgPE9sZWtzaWlfTW9pc2llaWV2QGVw YW0uY29tPjxtYWlsdG86T2xla3NpaV9Nb2lzaWVpZXZAZXBhbS5jb20+OyBTdGVmYW5vIFN0YWJl bGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+PG1haWx0bzpzc3RhYmVsbGluaUBrZXJuZWwu b3JnPjsgT2xla3NhbmRyIFR5c2hjaGVua28gPE9sZWtzYW5kcl9UeXNoY2hlbmtvQGVwYW0uY29t PjxtYWlsdG86T2xla3NhbmRyX1R5c2hjaGVua29AZXBhbS5jb20+OyB4ZW4tZGV2ZWxAbGlzdHMu eGVucHJvamVjdC5vcmc8bWFpbHRvOnhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZz4gPHhl bi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZz48bWFpbHRvOnhlbi1kZXZlbEBsaXN0cy54ZW5w cm9qZWN0Lm9yZz47IGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc8bWFpbHRvOmxpbnV4LWtl cm5lbEB2Z2VyLmtlcm5lbC5vcmc+IDxsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnPjxtYWls dG86bGludXgta2VybmVsQHZnZXIua2VybmVsLm9yZz47IFN1bWl0IFNlbXdhbCA8c3VtaXQuc2Vt d2FsQGxpbmFyby5vcmc+PG1haWx0bzpzdW1pdC5zZW13YWxAbGluYXJvLm9yZz47IEtvZW5pZywg Q2hyaXN0aWFuIDxDaHJpc3RpYW4uS29lbmlnQGFtZC5jb20+PG1haWx0bzpDaHJpc3RpYW4uS29l bmlnQGFtZC5jb20+OyBsaW51eC1tZWRpYUB2Z2VyLmtlcm5lbC5vcmc8bWFpbHRvOmxpbnV4LW1l ZGlhQHZnZXIua2VybmVsLm9yZz4gPGxpbnV4LW1lZGlhQHZnZXIua2VybmVsLm9yZz48bWFpbHRv OmxpbnV4LW1lZGlhQHZnZXIua2VybmVsLm9yZz47IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3Rv cC5vcmc8bWFpbHRvOmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmc+IDxkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnPjxtYWlsdG86ZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9w Lm9yZz47IGxpbmFyby1tbS1zaWdAbGlzdHMubGluYXJvLm9yZzxtYWlsdG86bGluYXJvLW1tLXNp Z0BsaXN0cy5saW5hcm8ub3JnPiA8bGluYXJvLW1tLXNpZ0BsaXN0cy5saW5hcm8ub3JnPjxtYWls dG86bGluYXJvLW1tLXNpZ0BsaXN0cy5saW5hcm8ub3JnPg0KQmV0cmVmZjogW1BBVENIIHYxIDAv M10gQWRkIGlvY3RscyB0byBtYXAgZ3JhbnQgcmVmcyBvbiB0aGUgZXh0ZXJuYWwgYmFja2luZyBz dG9yYWdlDQoNCkhlbGxvLA0KDQpMZXQgbWUgaW50cm9kdWNlIHRoZSBuZXcgaW9jdGxzLCB3aGlj aCBhcmUgaW50ZW5kZWQgdG8gYWxsb3cgZ250ZGV2IHRvDQptYXAgc2NhdHRlci1nYXRoZXIgdGFi bGUgb24gdG9wIG9mIHRoZSBleGlzdGluZyBkbWFidWYsIHJlZmVyZW5jZWQgYnkNCmZpbGUgZGVz Y3JpcHRvci4NCg0KV2hlbiB1c2luZyBkbWEtYnVmIGV4cG9ydGVyIHRvIGNyZWF0ZSBkbWEtYnVm IHdpdGggYmFja2luZyBzdG9yYWdlIGFuZA0KbWFwIGl0IHRvIHRoZSBncmFudCByZWZzLCBwcm92 aWRlZCBmcm9tIHRoZSBkb21haW4sIHdlJ3ZlIG1ldCBhIHByb2JsZW0sDQp0aGF0IHNldmVyYWwg SFcgKGkuTVg4IGdwdSBpbiBvdXIgY2FzZSkgZG8gbm90IHN1cHBvcnQgZXh0ZXJuYWwgYnVmZmVy DQphbmQgcmVxdWlyZXMgYmFja2luZyBzdG9yYWdlIHRvIGJlIGNyZWF0ZWQgdXNpbmcgaXQncyBu YXRpdmUgdG9vbHMuDQpUaGF0J3Mgd2h5IG5ldyBpb2N0bHMgd2VyZSBhZGRlZCB0byBiZSBhYmxl IHRvIHBhc3MgZXhpc3RpbmcgZG1hLWJ1ZmZlcg0KZmQgYXMgaW5wdXQgcGFyYW1ldGVyIGFuZCB1 c2UgaXQgYXMgYmFja2luZyBzdG9yYWdlIHRvIGV4cG9ydCB0byByZWZzLg0KDQpUaGlzIGlzIGEg cHJldHR5IGJpZyBOQUsgZnJvbSBteSBzaWRlIHRvIHRoaXMgYXBwcm9hY2guDQoNCklmIHlvdSBu ZWVkIHRvIHJlcGxhY2UgYSBmaWxlIGRlc2NyaXB0b3IgbnVtYmVyIGxvY2FsIHRvIHlvdXIgcHJv Y2VzcyB0aGVuIHlvdSBjYW4gc2ltcGx5IHVzZSBkdXAyKCkgZnJvbSB1c2Vyc3BhY2UuDQoNCklm IHlvdXIgaW50ZW50aW9uIGhlcmUgaXMgdG8gcmVwbGFjZSB0aGUgYmFja2luZyBzdG9yZSBvZiB0 aGUgZmQgb24gYWxsIHByb2Nlc3NlcyB3aGljaCBjdXJyZW50bHkgaGF2ZSBpdCBvcGVuIHRoZW4g cGxlYXNlIGp1c3QgY29tcGxldGVseSBmb3JnZXQgdGhhdC4gVGhpcyB3aWxsICpORVZFUiogZXZl ciB3b3JrIGNvcnJlY3RseS4NCg0KUmVnYXJkcywNCkNocmlzdGlhbi4NCg0KDQpIZWxsbyBDcmlz dGlhbiwNCg0KDQpUaGFuayB5b3UgZm9yIHRoZSBxdWljayByZXNwb25zZS4NCg0KDQpNeSBnb2Fs IGlzIHRvIHByb3ZpZGUgY29ycmVjdCBidWZmZXIgZm9yIHRoZSBpbnRlcmZhY2VzLCBzdWNoIGFz IHp3cF9saW51eF9kbWFidWZfdjFfaW50ZXJmYWNlLCBzbyB6ZXJvLWNvcHkNCg0KZmVhdHVyZSB3 aWxsIHdvcmsuIE15IHN1Z2dlc3Rpb24gaXMgdG8gZ2l2ZSBhIHBvc3NpYmlsaXR5IHRvIHVzZSBz b21lIHNwZWNpZmljIGJ1ZmZlciBhcyBiYWNraW5nIHN0b3JhZ2Ugd2hlcmUgY2FsbGVyDQoNCnRh a2VzIHJlc3BvbnNpYmlsaXR5IGZvciB0aGUgcHJvdmlkZWQgYnVmZmVyIHRvIGhhdmUgdGhlIGNv cnJlY3QgZm9ybWF0Lg0KDQoNCkluIG91ciBjYXNlIHdlIGFyZSB1c2luZyB0aGVzZSBjYWxscyB0 aGUgZm9sbG93aW5nIHdheToNCg0KMSkgR2V0IGdyZWZzIGZyb20gYW5vdGhlciBEb21haW4gKFdl J3JlIHdvcmtpbmcgb24gdGhlIHZpcnR1YWxpemVkIHN5c3RlbSB3aXRoIGRpZmZlcmVudCBEb21h aW5zDQoNCndvcmtpbmcgYXMgc3RhbmRhbG9uZSBWTXMgdGhhdCBhcmUgc2hhcmluZyByZXNvdXJj ZXMpOw0KDQoyKSBDcmVhdGUgYnVmZmVyIHVzaW5nIGdibV9ib19jcmVhdGUgYW5kIHJlY2VpdmUg ZmQgKGkuTVg4IHJlcXVpcmVzIGVnbCBhcGkgdG8gYmUgY2FsbGVkIGZvciB0aGUgYnVmZmVyDQoN CmFsbG9jYXRpb24sIG9yIGVnbENyZWF0ZUltYWdlS0hSIHdpbGwgcmV0dXJuIEVHTF9OT19JTUFH RV9LSFIgZHVyaW5nIHBhcmFtIHNldHRpbmcgZm9yIHp3cF9saW51eF9kbWFidWYpOw0KDQozKSBD YWxsIGZvciBJT0NUTF9HTlRERVZfRE1BQlVGX01BUF9SRUZTX1RPX0JVRiB0byBtYXAgZ3JlZnMg dXNpbmcgZmQgYXMgdGhlIGJhY2tpbmcgc3RvcmFnZTsNCg0KNCkgQ2FsbCBmb3IgendwX2xpbnV4 X2RtYWJ1Zl92MV9pbnRlcmZhY2UgYW5kIHVzZSB6ZXJvLWNvcHkgZmVhdHVyZSB3aXRoIFdheWxh bmQ7DQoNCjUpIEFmdGVyIHdvcmsgZmluaXNoZWQgLSBjYWxsIGZvciBJT0NUTF9HTlRERVZfRE1B QlVGX01BUF9SRUxFQVNFIHRvIHVubWFwIGdyYW50IHJlZnM7DQoNCjYpIENhbGwgZ2JtX2JvX2Rl c3Ryb3kgdG8gcmVsZWFzZSBhbGxvY2F0ZWQgQk8gb2JqZWN0Ow0KDQo3KSBDYWxsIGZvciBJT0NU TF9HTlRERVZfRE1BQlVGX01BUF9XQUlUX1JFTEVBU0VEIHRvIHdhaXQgdW50aWwgbWFwIHJlbGVh c2VkIGNvbXBsZXRlbHkNCg0KKFRoaXMgaW5jbHVkZXMgcmVsZWFzaW5nIGdyYW50IHJlZnMgb24g dGhlIERvbWFpbiBzaWRlKS4NCg0KDQpJJ3ZlIHRlc3RlZCBteSBjaGFuZ2VzIG9uIElNWDhRTSBi b2FyZCB1c2luZyBnYm1fYm9fY3JlYXRlIHRvIGFsbG9jYXRlIGJ1ZmZlciBhbmQNCg0Kb24gUUVN VSBzZXR1cCB1c2luZyBEUk1fSU9DVExfTU9ERV9DUkVBVEVfRFVNQiBmb3IgYnVmZmVyIGFsbG9j YXRpb24uDQoNCkkgY2FuIHByb3ZpZGUgdGVzdCBhcHBsaWNhdGlvbnMgSSd2ZSB1c2VkIGZvciB0 ZXN0aW5nIHB1cnBvc2VzLg0KDQoNCkJlc3QgcmVnYXJkcywNCg0KT2xla3NpaS4NCg0KDQpGb2xs b3dpbmcgY2FsbHMgd2VyZSBhZGRlZDoNCklPQ1RMX0dOVERFVl9ETUFCVUZfTUFQX1JFRlNfVE9f QlVGIC0gbWFwIGV4aXN0aW5nIGJ1ZmZlciBhcyB0aGUgYmFja2luZw0Kc3RvcmFnZSBhbmQgZXhw b3J0IGl0IHRvIHRoZSBwcm92aWRlZCBncmFudCByZWZzOw0KSU9DVExfR05UREVWX0RNQUJVRl9N QVBfUkVMRUFTRSAtIGRldGFjaCBidWZmZXIgZnJvbSB0aGUgZ3JhbnQgdGFibGUgYW5kDQpzZXQg bm90aWZpY2F0aW9uIHRvIHVubWFwIGdyYW50IHJlZnMgYmVmb3JlIHJlbGVhc2luZyB0aGUgZXh0 ZXJuYWwNCmJ1ZmZlci4gQWZ0ZXIgdGhpcyBjYWxsIHRoZSBleHRlcm5hbCBidWZmZXIgc2hvdWxk IGJlIGRldHJveWVkLg0KSU9DVExfR05UREVWX0RNQUJVRl9NQVBfV0FJVF9SRUxFQVNFRCAtIHdh aXQgZm9yIHRpbWVvdXQgdW50aWwgYnVmZmVyIGlzDQpjb21wbGV0ZWx5IGRlc3Ryb3llZCBhbmQg Z250IHJlZnMgdW5tYXBwZWQgc28gZG9tYWluIGNvdWxkIGZyZWUgZ3JhbnQNCnBhZ2VzLiBTaG91 bGQgYmUgY2FsbGVkIGFmdGVyIGJ1ZmZlciB3YXMgZGVzdG95ZWQuDQoNCk91ciBzZXR1cCBpcyBi YXNlZCBvbiBJTVg4UU0gYm9hcmQuIFdlJ3JlIHRyeWluZyB0byBpbXBsZW1lbnQgemVyby1jb3B5 DQpzdXBwb3J0IGZvciBEb21VIGdyYXBoaWNzIHVzaW5nIFdheWxhbmQgendwX2xpbnV4X2RtYWJ1 Zl92MV9pbnRlcmZhY2UNCmltcGxlbWVudGF0aW9uLg0KDQpGb3IgZG1hLWJ1ZiBleHBvcnRlciB3 ZSB1c2VkIGkuTVg4IGdwdSBuYXRpdmUgdG9vbHMgdG8gY3JlYXRlIGJhY2tpbmcNCnN0b3JhZ2Ug Z3JhbnQtcmVmcywgcmVjZWl2ZWQgZnJvbSBEb21VLiBCdWZmZXIgZm9yIHRoZSBiYWNraW5nIHN0 b3JhZ2Ugd2FzDQphbGxvY2F0ZWQgdXNpbmcgZ2JtX2JvX2NyZWF0ZSBjYWxsIGJlY2F1c2UgZ3B1 IGRvIG5vdCBzdXBwb3J0IGV4dGVybmFsDQpidWZmZXIgYW5kIHJlcXVpcmVzIGJhY2tpbmcgc3Rv cmFnZSB0byBiZSBjcmVhdGVkIHVzaW5nIGl0J3MgbmF0aXZlIHRvb2xzDQooZWdsQ3JlYXRlSW1h Z2VLSFIgcmV0dXJucyBFR0xfTk9fSU1BR0VfS0hSIGZvciBidWZmZXJzLCB3aGljaCB3ZXJlIG5v dA0KY3JlYXRlZCB1c2luZyBnYm1fYm9fY3JlYXRlKS4NCg0KVGhpcyBiZWhhdmlvdXIgd2FzIGFs c28gdGVzdGVkIG9uIFFlbXUgc2V0dXAgdXNpbmcNCkRSTV9JT0NUTF9NT0RFX0NSRUFURV9EVU1C IGNhbGwgdG8gY3JlYXRlIGJhY2tpbmcgc3RvcmFnZSBidWZmZXIuDQoNCi0tLQ0KT2xla3NpaSBN b2lzaWVpZXYgKDMpOg0KICB4ZW4vZ3JhbnQtdGFibGU6IHNhdmUgcGFnZV9jb3VudCBvbiBtYXAg YW5kIHVzZSBpZiBkdXJpbmcgYXN5bmMNCiAgICB1bm1hcHBpbmcNCiAgZG1hLWJ1ZjogYWRkIGRt YSBidWZmZXIgcmVsZWFzZSBub3RpZmllciBjYWxsYmFjaw0KICB4ZW4vZ3JhbnQtdGFibGU6IGFk ZCBuZXcgaW9jdGxzIHRvIG1hcCBkbWFidWYgdG8gZXhpc3RpbmcgZmQNCg0KIGRyaXZlcnMvZG1h LWJ1Zi9kbWEtYnVmLmMgICB8ICA0NCArKysrDQogZHJpdmVycy94ZW4vZ250ZGV2LWNvbW1vbi5o IHwgICA4ICstDQogZHJpdmVycy94ZW4vZ250ZGV2LWRtYWJ1Zi5jIHwgNDE2ICsrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrLQ0KIGRyaXZlcnMveGVuL2dudGRldi1kbWFidWYuaCB8 ICAgNyArDQogZHJpdmVycy94ZW4vZ250ZGV2LmMgICAgICAgIHwgMTAxICsrKysrKysrLQ0KIGRy aXZlcnMveGVuL2dyYW50LXRhYmxlLmMgICB8ICA3MyArKysrKy0tDQogaW5jbHVkZS9saW51eC9k bWEtYnVmLmggICAgIHwgIDE1ICsrDQogaW5jbHVkZS91YXBpL3hlbi9nbnRkZXYuaCAgIHwgIDYy ICsrKysrKw0KIGluY2x1ZGUveGVuL2dyYW50X3RhYmxlLmggICB8ICAgOCArDQogOSBmaWxlcyBj aGFuZ2VkLCA3MDMgaW5zZXJ0aW9ucygrKSwgMzEgZGVsZXRpb25zKC0pDQoNCi0tDQoyLjI1LjEN Cg== --_000_3066964b511f6314bc8f79e387712013epamcom_ Content-Type: text/html; charset="utf-8" Content-ID: <57550DFA2D6AF9478A26363158656BE6@eurprd03.prod.outlook.com> Content-Transfer-Encoding: base64 PGh0bWw+DQo8aGVhZD4NCjxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIgY29udGVudD0i dGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ij4NCjwvaGVhZD4NCjxib2R5Pg0KPHA+PGJyPg0KPC9w Pg0KPGRpdiBjbGFzcz0ibW96LWNpdGUtcHJlZml4Ij5PbiAwMi4wMS4yMyAxODozNiwgS29lbmln LCBDaHJpc3RpYW4gd3JvdGU6PGJyPg0KPC9kaXY+DQo8YmxvY2txdW90ZSB0eXBlPSJjaXRlIiBj aXRlPSJtaWQ6Qk44UFIxMk1CMzU4NzY3M0Y4RUYyNjQyRDI2N0U5NDNEODNGNzlAQk44UFIxMk1C MzU4Ny5uYW1wcmQxMi5wcm9kLm91dGxvb2suY29tIj4NCjxzdHlsZSB0eXBlPSJ0ZXh0L2NzcyIg c3R5bGU9ImRpc3BsYXk6bm9uZTsiPlAge21hcmdpbi10b3A6MDttYXJnaW4tYm90dG9tOjA7fTwv c3R5bGU+DQo8cCBzdHlsZT0iZm9udC1mYW1pbHk6QXJpYWw7Zm9udC1zaXplOjEwcHQ7Y29sb3I6 IzAwMDBGRjttYXJnaW46NXB0OyIgYWxpZ249IkxlZnQiPg0KW0FNRCBPZmZpY2lhbCBVc2UgT25s eSAtIEdlbmVyYWxdPGJyPg0KPC9wPg0KPGJyPg0KPGRpdj4NCjxkaXYgY2xhc3M9ImVsZW1lbnRU b1Byb29mIiBzdHlsZT0iZm9udC1mYW1pbHk6IENhbGlicmksIEFyaWFsLA0KICAgICAgICAgIEhl bHZldGljYSwgc2Fucy1zZXJpZjsgZm9udC1zaXplOiAxMnB0OyBjb2xvcjogcmdiKDAsIDAsIDAp Ow0KICAgICAgICAgIGJhY2tncm91bmQtY29sb3I6IHJnYigyNTUsIDI1NSwgMjU1KTsiPg0KPHNw YW4gc3R5bGU9ImZvbnQtZmFtaWx5OiBDYWxpYnJpLCBBcmlhbCwgSGVsdmV0aWNhLCBzYW5zLXNl cmlmOw0KICAgICAgICAgICAgZm9udC1zaXplOiAxMnB0OyBjb2xvcjogcmdiKDAsIDAsIDApOyBi YWNrZ3JvdW5kLWNvbG9yOg0KICAgICAgICAgICAgcmdiKDI1NSwgMjU1LCAyNTUpOyI+U29ycnkg Zm9yIHRoZSBtZXNzZWQgdXAgbWFpbC4gV2UgY3VycmVudGx5IGhhdmUgbWFpbCBwcm9ibGVtcyBo ZXJlIGF0IEFNRC48L3NwYW4+PC9kaXY+DQo8ZGl2IHN0eWxlPSJmb250LWZhbWlseTpDYWxpYnJp LEFyaWFsLEhlbHZldGljYSxzYW5zLXNlcmlmOw0KICAgICAgICAgIGZvbnQtc2l6ZToxMnB0OyBj b2xvcjpyZ2IoMCwwLDApIj4NCjxicj4NCjwvZGl2Pg0KPGhyIHRhYmluZGV4PSItMSIgc3R5bGU9 ImRpc3BsYXk6aW5saW5lLWJsb2NrOyB3aWR0aDo5OCUiPg0KPGRpdiBpZD0iZGl2UnBseUZ3ZE1z ZyIgZGlyPSJsdHIiPjxmb250IHN0eWxlPSJmb250LXNpemU6MTFwdCIgZmFjZT0iQ2FsaWJyaSwg c2Fucy1zZXJpZiIgY29sb3I9IiMwMDAwMDAiPjxiPlZvbjo8L2I+IE9sZWtzaWkgTW9pc2llaWV2 DQo8YSBjbGFzcz0ibW96LXR4dC1saW5rLXJmYzIzOTZFIiBocmVmPSJtYWlsdG86T2xla3NpaV9N b2lzaWVpZXZAZXBhbS5jb20iPiZsdDtPbGVrc2lpX01vaXNpZWlldkBlcGFtLmNvbSZndDs8L2E+ PGJyPg0KPGI+R2VzZW5kZXQ6PC9iPiBNb250YWcsIDIuIEphbnVhciAyMDIzIDE0OjQxPGJyPg0K PGI+QW46PC9iPiA8YSBjbGFzcz0ibW96LXR4dC1saW5rLWFiYnJldmlhdGVkDQogICAgICAgICAg ICAgIG1vei10eHQtbGluay1mcmVldGV4dCIgaHJlZj0ibWFpbHRvOmpncm9zc0BzdXNlLmNvbSI+ DQpqZ3Jvc3NAc3VzZS5jb208L2E+IDxhIGNsYXNzPSJtb3otdHh0LWxpbmstcmZjMjM5NkUiIGhy ZWY9Im1haWx0bzpqZ3Jvc3NAc3VzZS5jb20iPg0KJmx0O2pncm9zc0BzdXNlLmNvbSZndDs8L2E+ PGJyPg0KPGI+Q2M6PC9iPiBPbGVrc2lpIE1vaXNpZWlldiA8YSBjbGFzcz0ibW96LXR4dC1saW5r LXJmYzIzOTZFIiBocmVmPSJtYWlsdG86T2xla3NpaV9Nb2lzaWVpZXZAZXBhbS5jb20iPg0KJmx0 O09sZWtzaWlfTW9pc2llaWV2QGVwYW0uY29tJmd0OzwvYT47IFN0ZWZhbm8gU3RhYmVsbGluaSA8 YSBjbGFzcz0ibW96LXR4dC1saW5rLXJmYzIzOTZFIiBocmVmPSJtYWlsdG86c3N0YWJlbGxpbmlA a2VybmVsLm9yZyI+DQombHQ7c3N0YWJlbGxpbmlAa2VybmVsLm9yZyZndDs8L2E+OyBPbGVrc2Fu ZHIgVHlzaGNoZW5rbyA8YSBjbGFzcz0ibW96LXR4dC1saW5rLXJmYzIzOTZFIiBocmVmPSJtYWls dG86T2xla3NhbmRyX1R5c2hjaGVua29AZXBhbS5jb20iPg0KJmx0O09sZWtzYW5kcl9UeXNoY2hl bmtvQGVwYW0uY29tJmd0OzwvYT47IDxhIGNsYXNzPSJtb3otdHh0LWxpbmstYWJicmV2aWF0ZWQg bW96LXR4dC1saW5rLWZyZWV0ZXh0IiBocmVmPSJtYWlsdG86eGVuLWRldmVsQGxpc3RzLnhlbnBy b2plY3Qub3JnIj4NCnhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZzwvYT4gPGEgY2xhc3M9 Im1vei10eHQtbGluay1yZmMyMzk2RSIgaHJlZj0ibWFpbHRvOnhlbi1kZXZlbEBsaXN0cy54ZW5w cm9qZWN0Lm9yZyI+DQombHQ7eGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnJmd0OzwvYT47 IDxhIGNsYXNzPSJtb3otdHh0LWxpbmstYWJicmV2aWF0ZWQgbW96LXR4dC1saW5rLWZyZWV0ZXh0 IiBocmVmPSJtYWlsdG86bGludXgta2VybmVsQHZnZXIua2VybmVsLm9yZyI+DQpsaW51eC1rZXJu ZWxAdmdlci5rZXJuZWwub3JnPC9hPiA8YSBjbGFzcz0ibW96LXR4dC1saW5rLXJmYzIzOTZFIiBo cmVmPSJtYWlsdG86bGludXgta2VybmVsQHZnZXIua2VybmVsLm9yZyI+DQombHQ7bGludXgta2Vy bmVsQHZnZXIua2VybmVsLm9yZyZndDs8L2E+OyBTdW1pdCBTZW13YWwgPGEgY2xhc3M9Im1vei10 eHQtbGluay1yZmMyMzk2RSIgaHJlZj0ibWFpbHRvOnN1bWl0LnNlbXdhbEBsaW5hcm8ub3JnIj4N CiZsdDtzdW1pdC5zZW13YWxAbGluYXJvLm9yZyZndDs8L2E+OyBLb2VuaWcsIENocmlzdGlhbiA8 YSBjbGFzcz0ibW96LXR4dC1saW5rLXJmYzIzOTZFIiBocmVmPSJtYWlsdG86Q2hyaXN0aWFuLktv ZW5pZ0BhbWQuY29tIj4NCiZsdDtDaHJpc3RpYW4uS29lbmlnQGFtZC5jb20mZ3Q7PC9hPjsgPGEg Y2xhc3M9Im1vei10eHQtbGluay1hYmJyZXZpYXRlZCBtb3otdHh0LWxpbmstZnJlZXRleHQiIGhy ZWY9Im1haWx0bzpsaW51eC1tZWRpYUB2Z2VyLmtlcm5lbC5vcmciPg0KbGludXgtbWVkaWFAdmdl ci5rZXJuZWwub3JnPC9hPiA8YSBjbGFzcz0ibW96LXR4dC1saW5rLXJmYzIzOTZFIiBocmVmPSJt YWlsdG86bGludXgtbWVkaWFAdmdlci5rZXJuZWwub3JnIj4NCiZsdDtsaW51eC1tZWRpYUB2Z2Vy Lmtlcm5lbC5vcmcmZ3Q7PC9hPjsgPGEgY2xhc3M9Im1vei10eHQtbGluay1hYmJyZXZpYXRlZCBt b3otdHh0LWxpbmstZnJlZXRleHQiIGhyZWY9Im1haWx0bzpkcmktZGV2ZWxAbGlzdHMuZnJlZWRl c2t0b3Aub3JnIj4NCmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmc8L2E+IDxhIGNsYXNz PSJtb3otdHh0LWxpbmstcmZjMjM5NkUiIGhyZWY9Im1haWx0bzpkcmktZGV2ZWxAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnIj4NCiZsdDtkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnJmd0Ozwv YT47IDxhIGNsYXNzPSJtb3otdHh0LWxpbmstYWJicmV2aWF0ZWQgbW96LXR4dC1saW5rLWZyZWV0 ZXh0IiBocmVmPSJtYWlsdG86bGluYXJvLW1tLXNpZ0BsaXN0cy5saW5hcm8ub3JnIj4NCmxpbmFy by1tbS1zaWdAbGlzdHMubGluYXJvLm9yZzwvYT4gPGEgY2xhc3M9Im1vei10eHQtbGluay1yZmMy Mzk2RSIgaHJlZj0ibWFpbHRvOmxpbmFyby1tbS1zaWdAbGlzdHMubGluYXJvLm9yZyI+DQombHQ7 bGluYXJvLW1tLXNpZ0BsaXN0cy5saW5hcm8ub3JnJmd0OzwvYT48YnI+DQo8Yj5CZXRyZWZmOjwv Yj4gW1BBVENIIHYxIDAvM10gQWRkIGlvY3RscyB0byBtYXAgZ3JhbnQgcmVmcyBvbiB0aGUgZXh0 ZXJuYWwgYmFja2luZyBzdG9yYWdlPC9mb250Pg0KPGRpdj4mbmJzcDs8L2Rpdj4NCjwvZGl2Pg0K PGRpdiBjbGFzcz0iQm9keUZyYWdtZW50Ij48Zm9udCBzaXplPSIyIj48c3BhbiBzdHlsZT0iZm9u dC1zaXplOjExcHQiPg0KPGRpdiBjbGFzcz0iUGxhaW5UZXh0IGVsZW1lbnRUb1Byb29mIj5IZWxs byw8YnI+DQo8YnI+DQpMZXQgbWUgaW50cm9kdWNlIHRoZSBuZXcgaW9jdGxzLCB3aGljaCBhcmUg aW50ZW5kZWQgdG8gYWxsb3cgZ250ZGV2IHRvPGJyPg0KbWFwIHNjYXR0ZXItZ2F0aGVyIHRhYmxl IG9uIHRvcCBvZiB0aGUgZXhpc3RpbmcgZG1hYnVmLCByZWZlcmVuY2VkIGJ5PGJyPg0KZmlsZSBk ZXNjcmlwdG9yLjxicj4NCjxicj4NCldoZW4gdXNpbmcgZG1hLWJ1ZiBleHBvcnRlciB0byBjcmVh dGUgZG1hLWJ1ZiB3aXRoIGJhY2tpbmcgc3RvcmFnZSBhbmQ8YnI+DQptYXAgaXQgdG8gdGhlIGdy YW50IHJlZnMsIHByb3ZpZGVkIGZyb20gdGhlIGRvbWFpbiwgd2UndmUgbWV0IGEgcHJvYmxlbSw8 YnI+DQp0aGF0IHNldmVyYWwgSFcgKGkuTVg4IGdwdSBpbiBvdXIgY2FzZSkgZG8gbm90IHN1cHBv cnQgZXh0ZXJuYWwgYnVmZmVyPGJyPg0KYW5kIHJlcXVpcmVzIGJhY2tpbmcgc3RvcmFnZSB0byBi ZSBjcmVhdGVkIHVzaW5nIGl0J3MgbmF0aXZlIHRvb2xzLjxicj4NClRoYXQncyB3aHkgbmV3IGlv Y3RscyB3ZXJlIGFkZGVkIHRvIGJlIGFibGUgdG8gcGFzcyBleGlzdGluZyBkbWEtYnVmZmVyPGJy Pg0KZmQgYXMgaW5wdXQgcGFyYW1ldGVyIGFuZCB1c2UgaXQgYXMgYmFja2luZyBzdG9yYWdlIHRv IGV4cG9ydCB0byByZWZzLjwvZGl2Pg0KPGRpdiBjbGFzcz0iUGxhaW5UZXh0IGVsZW1lbnRUb1By b29mIj48YnI+DQo8L2Rpdj4NCjxkaXYgY2xhc3M9IlBsYWluVGV4dCBlbGVtZW50VG9Qcm9vZiI+ VGhpcyBpcyBhIHByZXR0eSBiaWcgTkFLIGZyb20gbXkgc2lkZSB0byB0aGlzIGFwcHJvYWNoLjwv ZGl2Pg0KPGRpdiBjbGFzcz0iUGxhaW5UZXh0IGVsZW1lbnRUb1Byb29mIj48YnI+DQo8L2Rpdj4N CjxkaXYgY2xhc3M9IlBsYWluVGV4dCBlbGVtZW50VG9Qcm9vZiI+SWYgeW91IG5lZWQgdG8gcmVw bGFjZSBhIGZpbGUgZGVzY3JpcHRvciBudW1iZXIgbG9jYWwgdG8geW91ciBwcm9jZXNzIHRoZW4g eW91IGNhbiBzaW1wbHkgdXNlIGR1cDIoKSBmcm9tIHVzZXJzcGFjZS48L2Rpdj4NCjxkaXYgY2xh c3M9IlBsYWluVGV4dCBlbGVtZW50VG9Qcm9vZiI+PGJyPg0KPC9kaXY+DQo8ZGl2IGNsYXNzPSJQ bGFpblRleHQgZWxlbWVudFRvUHJvb2YiPklmIHlvdXIgaW50ZW50aW9uIGhlcmUgaXMgdG8gcmVw bGFjZSB0aGUgYmFja2luZyBzdG9yZSBvZiB0aGUgZmQgb24gYWxsIHByb2Nlc3NlcyB3aGljaCBj dXJyZW50bHkgaGF2ZSBpdCBvcGVuIHRoZW4gcGxlYXNlIGp1c3QgY29tcGxldGVseSBmb3JnZXQg dGhhdC4gVGhpcyB3aWxsICpORVZFUiogZXZlciB3b3JrIGNvcnJlY3RseS48L2Rpdj4NCjxkaXYg Y2xhc3M9IlBsYWluVGV4dCBlbGVtZW50VG9Qcm9vZiI+PGJyPg0KPC9kaXY+DQo8ZGl2IGNsYXNz PSJQbGFpblRleHQgZWxlbWVudFRvUHJvb2YiPlJlZ2FyZHMsPC9kaXY+DQo8ZGl2IGNsYXNzPSJQ bGFpblRleHQgZWxlbWVudFRvUHJvb2YiPkNocmlzdGlhbi48L2Rpdj4NCjxkaXYgY2xhc3M9IlBs YWluVGV4dCBlbGVtZW50VG9Qcm9vZiI+PGJyPg0KPC9kaXY+DQo8L3NwYW4+PC9mb250PjwvZGl2 Pg0KPC9kaXY+DQo8L2Jsb2NrcXVvdGU+DQo8cD5IZWxsbyBDcmlzdGlhbiw8L3A+DQo8cD48YnI+ DQo8L3A+DQo8cD5UaGFuayB5b3UgZm9yIHRoZSBxdWljayByZXNwb25zZS48L3A+DQo8cD48YnI+ DQo8L3A+DQo8cD5NeSBnb2FsIGlzIHRvIHByb3ZpZGUgY29ycmVjdCBidWZmZXIgZm9yIHRoZSBp bnRlcmZhY2VzLCBzdWNoIGFzIDxmb250IHNpemU9IjIiPg0KPHNwYW4gc3R5bGU9ImZvbnQtc2l6 ZToxMXB0Ij56d3BfbGludXhfZG1hYnVmX3YxX2ludGVyZmFjZSwgc28gemVyby1jb3B5PC9zcGFu PjwvZm9udD48L3A+DQo8cD48Zm9udCBzaXplPSIyIj48c3BhbiBzdHlsZT0iZm9udC1zaXplOjEx cHQiPmZlYXR1cmUgd2lsbCB3b3JrLiBNeSBzdWdnZXN0aW9uIGlzIHRvIGdpdmUgYSBwb3NzaWJp bGl0eSB0byB1c2Ugc29tZSBzcGVjaWZpYyBidWZmZXIgYXMgYmFja2luZyBzdG9yYWdlIHdoZXJl IGNhbGxlcjwvc3Bhbj48L2ZvbnQ+PC9wPg0KPHA+PGZvbnQgc2l6ZT0iMiI+PHNwYW4gc3R5bGU9 ImZvbnQtc2l6ZToxMXB0Ij50YWtlcyByZXNwb25zaWJpbGl0eSBmb3IgdGhlIHByb3ZpZGVkIGJ1 ZmZlciB0byBoYXZlIHRoZSBjb3JyZWN0IGZvcm1hdC48L3NwYW4+PC9mb250PjwvcD4NCjxwPjxm b250IHNpemU9IjIiPjxzcGFuIHN0eWxlPSJmb250LXNpemU6MTFwdCI+PGJyPg0KPC9zcGFuPjwv Zm9udD48L3A+DQo8cD48Zm9udCBzaXplPSIyIj48c3BhbiBzdHlsZT0iZm9udC1zaXplOjExcHQi PkluIG91ciBjYXNlIHdlIGFyZSB1c2luZyB0aGVzZSBjYWxscyB0aGUgZm9sbG93aW5nIHdheTo8 L3NwYW4+PC9mb250PjwvcD4NCjxwPjxmb250IHNpemU9IjIiPjxzcGFuIHN0eWxlPSJmb250LXNp emU6MTFwdCI+MSkgR2V0IGdyZWZzIGZyb20gYW5vdGhlciBEb21haW4gKFdlJ3JlIHdvcmtpbmcg b24gdGhlIHZpcnR1YWxpemVkIHN5c3RlbSB3aXRoIGRpZmZlcmVudCBEb21haW5zPC9zcGFuPjwv Zm9udD48L3A+DQo8cD48Zm9udCBzaXplPSIyIj48c3BhbiBzdHlsZT0iZm9udC1zaXplOjExcHQi PndvcmtpbmcgYXMgc3RhbmRhbG9uZSBWTXMgdGhhdCBhcmUgc2hhcmluZyByZXNvdXJjZXMpOzwv c3Bhbj48L2ZvbnQ+PC9wPg0KPHA+PGZvbnQgc2l6ZT0iMiI+PHNwYW4gc3R5bGU9ImZvbnQtc2l6 ZToxMXB0Ij4yKSBDcmVhdGUgYnVmZmVyIHVzaW5nIGdibV9ib19jcmVhdGUgYW5kIHJlY2VpdmUg ZmQgKGkuTVg4IHJlcXVpcmVzIGVnbCBhcGkgdG8gYmUgY2FsbGVkIGZvciB0aGUgYnVmZmVyPC9z cGFuPjwvZm9udD48L3A+DQo8cD48Zm9udCBzaXplPSIyIj48c3BhbiBzdHlsZT0iZm9udC1zaXpl OjExcHQiPmFsbG9jYXRpb24sIG9yIDwvc3Bhbj48L2ZvbnQ+PGZvbnQgc2l6ZT0iMiI+PHNwYW4g c3R5bGU9ImZvbnQtc2l6ZToxMXB0Ij48Zm9udCBzaXplPSIyIj48c3BhbiBzdHlsZT0iZm9udC1z aXplOjExcHQiPmVnbENyZWF0ZUltYWdlS0hSIHdpbGwgcmV0dXJuIEVHTF9OT19JTUFHRV9LSFIN Cjwvc3Bhbj48L2ZvbnQ+ZHVyaW5nIHBhcmFtIHNldHRpbmcgZm9yIHp3cF9saW51eF9kbWFidWYp Ozwvc3Bhbj48L2ZvbnQ+PC9wPg0KPHA+PGZvbnQgc2l6ZT0iMiI+PHNwYW4gc3R5bGU9ImZvbnQt c2l6ZToxMXB0Ij4zKSBDYWxsIGZvciA8L3NwYW4+PC9mb250Pjxmb250IHNpemU9IjIiPjxzcGFu IHN0eWxlPSJmb250LXNpemU6MTFwdCI+SU9DVExfR05UREVWX0RNQUJVRl9NQVBfUkVGU19UT19C VUYgdG8gbWFwIGdyZWZzIHVzaW5nIGZkIGFzIHRoZSBiYWNraW5nIHN0b3JhZ2U7PC9zcGFuPjwv Zm9udD48L3A+DQo8cD48Zm9udCBzaXplPSIyIj48c3BhbiBzdHlsZT0iZm9udC1zaXplOjExcHQi PjQpIENhbGwgZm9yIDwvc3Bhbj48L2ZvbnQ+PGZvbnQgc2l6ZT0iMiI+PHNwYW4gc3R5bGU9ImZv bnQtc2l6ZToxMXB0Ij56d3BfbGludXhfZG1hYnVmX3YxX2ludGVyZmFjZSBhbmQgdXNlIHplcm8t Y29weSBmZWF0dXJlIHdpdGggV2F5bGFuZDs8L3NwYW4+PC9mb250PjwvcD4NCjxwPjxmb250IHNp emU9IjIiPjxzcGFuIHN0eWxlPSJmb250LXNpemU6MTFwdCI+NSkgQWZ0ZXIgd29yayBmaW5pc2hl ZCAtIGNhbGwgZm9yIDwvc3Bhbj4NCjwvZm9udD48Zm9udCBzaXplPSIyIj48c3BhbiBzdHlsZT0i Zm9udC1zaXplOjExcHQiPklPQ1RMX0dOVERFVl9ETUFCVUZfTUFQX1JFTEVBU0UgdG8gdW5tYXAg Z3JhbnQgcmVmczs8L3NwYW4+PC9mb250PjwvcD4NCjxwPjxmb250IHNpemU9IjIiPjxzcGFuIHN0 eWxlPSJmb250LXNpemU6MTFwdCI+NikgQ2FsbCBnYm1fYm9fZGVzdHJveSB0byByZWxlYXNlIGFs bG9jYXRlZCBCTyBvYmplY3Q7PC9zcGFuPjwvZm9udD48L3A+DQo8cD48Zm9udCBzaXplPSIyIj48 c3BhbiBzdHlsZT0iZm9udC1zaXplOjExcHQiPjcpIENhbGwgZm9yIDwvc3Bhbj48L2ZvbnQ+PGZv bnQgc2l6ZT0iMiI+PHNwYW4gc3R5bGU9ImZvbnQtc2l6ZToxMXB0Ij5JT0NUTF9HTlRERVZfRE1B QlVGX01BUF9XQUlUX1JFTEVBU0VEIHRvIHdhaXQgdW50aWwgbWFwIHJlbGVhc2VkIGNvbXBsZXRl bHk8L3NwYW4+PC9mb250PjwvcD4NCjxwPjxmb250IHNpemU9IjIiPjxzcGFuIHN0eWxlPSJmb250 LXNpemU6MTFwdCI+KFRoaXMgaW5jbHVkZXMgcmVsZWFzaW5nIGdyYW50IHJlZnMgb24gdGhlIERv bWFpbiBzaWRlKS48L3NwYW4+PC9mb250PjwvcD4NCjxwPjxmb250IHNpemU9IjIiPjxzcGFuIHN0 eWxlPSJmb250LXNpemU6MTFwdCI+PGJyPg0KPC9zcGFuPjwvZm9udD48L3A+DQo8cD48Zm9udCBz aXplPSIyIj48c3BhbiBzdHlsZT0iZm9udC1zaXplOjExcHQiPkkndmUgdGVzdGVkIG15IGNoYW5n ZXMgb24gSU1YOFFNIGJvYXJkIHVzaW5nIGdibV9ib19jcmVhdGUgdG8gYWxsb2NhdGUgYnVmZmVy IGFuZDwvc3Bhbj48L2ZvbnQ+PC9wPg0KPHA+PGZvbnQgc2l6ZT0iMiI+PHNwYW4gc3R5bGU9ImZv bnQtc2l6ZToxMXB0Ij5vbiBRRU1VIHNldHVwIHVzaW5nIDwvc3Bhbj48L2ZvbnQ+PGZvbnQgc2l6 ZT0iMiI+PHNwYW4gc3R5bGU9ImZvbnQtc2l6ZToxMXB0Ij5EUk1fSU9DVExfTU9ERV9DUkVBVEVf RFVNQiBmb3IgYnVmZmVyIGFsbG9jYXRpb24uPC9zcGFuPjwvZm9udD48L3A+DQo8cD48Zm9udCBz aXplPSIyIj48c3BhbiBzdHlsZT0iZm9udC1zaXplOjExcHQiPkkgY2FuIHByb3ZpZGUgdGVzdCBh cHBsaWNhdGlvbnMgSSd2ZSB1c2VkIGZvciB0ZXN0aW5nIHB1cnBvc2VzLjxicj4NCjwvc3Bhbj48 L2ZvbnQ+PC9wPg0KPHA+PGZvbnQgc2l6ZT0iMiI+PHNwYW4gc3R5bGU9ImZvbnQtc2l6ZToxMXB0 Ij48YnI+DQo8L3NwYW4+PC9mb250PjwvcD4NCjxwPjxmb250IHNpemU9IjIiPjxzcGFuIHN0eWxl PSJmb250LXNpemU6MTFwdCI+QmVzdCByZWdhcmRzLDwvc3Bhbj48L2ZvbnQ+PC9wPg0KPHA+PGZv bnQgc2l6ZT0iMiI+PHNwYW4gc3R5bGU9ImZvbnQtc2l6ZToxMXB0Ij5PbGVrc2lpLjwvc3Bhbj48 L2ZvbnQ+PC9wPg0KPHA+PGZvbnQgc2l6ZT0iMiI+PHNwYW4gc3R5bGU9ImZvbnQtc2l6ZToxMXB0 Ij48YnI+DQo8L3NwYW4+PC9mb250Pjxmb250IHNpemU9IjIiPjxzcGFuIHN0eWxlPSJmb250LXNp emU6MTFwdCI+PC9zcGFuPjwvZm9udD48Zm9udCBzaXplPSIyIj48c3BhbiBzdHlsZT0iZm9udC1z aXplOjExcHQiPjwvc3Bhbj48L2ZvbnQ+PC9wPg0KPGJsb2NrcXVvdGUgdHlwZT0iY2l0ZSIgY2l0 ZT0ibWlkOkJOOFBSMTJNQjM1ODc2NzNGOEVGMjY0MkQyNjdFOTQzRDgzRjc5QEJOOFBSMTJNQjM1 ODcubmFtcHJkMTIucHJvZC5vdXRsb29rLmNvbSI+DQo8ZGl2Pg0KPGRpdiBjbGFzcz0iQm9keUZy YWdtZW50Ij48Zm9udCBzaXplPSIyIj48c3BhbiBzdHlsZT0iZm9udC1zaXplOjExcHQiPg0KPGRp diBjbGFzcz0iUGxhaW5UZXh0IGVsZW1lbnRUb1Byb29mIj5Gb2xsb3dpbmcgY2FsbHMgd2VyZSBh ZGRlZDo8YnI+DQpJT0NUTF9HTlRERVZfRE1BQlVGX01BUF9SRUZTX1RPX0JVRiAtIG1hcCBleGlz dGluZyBidWZmZXIgYXMgdGhlIGJhY2tpbmc8YnI+DQpzdG9yYWdlIGFuZCBleHBvcnQgaXQgdG8g dGhlIHByb3ZpZGVkIGdyYW50IHJlZnM7PGJyPg0KSU9DVExfR05UREVWX0RNQUJVRl9NQVBfUkVM RUFTRSAtIGRldGFjaCBidWZmZXIgZnJvbSB0aGUgZ3JhbnQgdGFibGUgYW5kPGJyPg0Kc2V0IG5v dGlmaWNhdGlvbiB0byB1bm1hcCBncmFudCByZWZzIGJlZm9yZSByZWxlYXNpbmcgdGhlIGV4dGVy bmFsPGJyPg0KYnVmZmVyLiBBZnRlciB0aGlzIGNhbGwgdGhlIGV4dGVybmFsIGJ1ZmZlciBzaG91 bGQgYmUgZGV0cm95ZWQuPGJyPg0KSU9DVExfR05UREVWX0RNQUJVRl9NQVBfV0FJVF9SRUxFQVNF RCAtIHdhaXQgZm9yIHRpbWVvdXQgdW50aWwgYnVmZmVyIGlzPGJyPg0KY29tcGxldGVseSBkZXN0 cm95ZWQgYW5kIGdudCByZWZzIHVubWFwcGVkIHNvIGRvbWFpbiBjb3VsZCBmcmVlIGdyYW50PGJy Pg0KcGFnZXMuIFNob3VsZCBiZSBjYWxsZWQgYWZ0ZXIgYnVmZmVyIHdhcyBkZXN0b3llZC48YnI+ DQo8YnI+DQpPdXIgc2V0dXAgaXMgYmFzZWQgb24gSU1YOFFNIGJvYXJkLiBXZSdyZSB0cnlpbmcg dG8gaW1wbGVtZW50IHplcm8tY29weTxicj4NCnN1cHBvcnQgZm9yIERvbVUgZ3JhcGhpY3MgdXNp bmcgV2F5bGFuZCB6d3BfbGludXhfZG1hYnVmX3YxX2ludGVyZmFjZTxicj4NCmltcGxlbWVudGF0 aW9uLjxicj4NCjxicj4NCkZvciBkbWEtYnVmIGV4cG9ydGVyIHdlIHVzZWQgaS5NWDggZ3B1IG5h dGl2ZSB0b29scyB0byBjcmVhdGUgYmFja2luZzxicj4NCnN0b3JhZ2UgZ3JhbnQtcmVmcywgcmVj ZWl2ZWQgZnJvbSBEb21VLiBCdWZmZXIgZm9yIHRoZSBiYWNraW5nIHN0b3JhZ2Ugd2FzPGJyPg0K YWxsb2NhdGVkIHVzaW5nIGdibV9ib19jcmVhdGUgY2FsbCBiZWNhdXNlIGdwdSBkbyBub3Qgc3Vw cG9ydCBleHRlcm5hbDxicj4NCmJ1ZmZlciBhbmQgcmVxdWlyZXMgYmFja2luZyBzdG9yYWdlIHRv IGJlIGNyZWF0ZWQgdXNpbmcgaXQncyBuYXRpdmUgdG9vbHM8YnI+DQooZWdsQ3JlYXRlSW1hZ2VL SFIgcmV0dXJucyBFR0xfTk9fSU1BR0VfS0hSIGZvciBidWZmZXJzLCB3aGljaCB3ZXJlIG5vdDxi cj4NCmNyZWF0ZWQgdXNpbmcgZ2JtX2JvX2NyZWF0ZSkuPGJyPg0KPGJyPg0KVGhpcyBiZWhhdmlv dXIgd2FzIGFsc28gdGVzdGVkIG9uIFFlbXUgc2V0dXAgdXNpbmc8YnI+DQpEUk1fSU9DVExfTU9E RV9DUkVBVEVfRFVNQiBjYWxsIHRvIGNyZWF0ZSBiYWNraW5nIHN0b3JhZ2UgYnVmZmVyLjxicj4N Cjxicj4NCi0tLTxicj4NCk9sZWtzaWkgTW9pc2llaWV2ICgzKTo8YnI+DQombmJzcDsgeGVuL2dy YW50LXRhYmxlOiBzYXZlIHBhZ2VfY291bnQgb24gbWFwIGFuZCB1c2UgaWYgZHVyaW5nIGFzeW5j PGJyPg0KJm5ic3A7Jm5ic3A7Jm5ic3A7IHVubWFwcGluZzxicj4NCiZuYnNwOyBkbWEtYnVmOiBh ZGQgZG1hIGJ1ZmZlciByZWxlYXNlIG5vdGlmaWVyIGNhbGxiYWNrPGJyPg0KJm5ic3A7IHhlbi9n cmFudC10YWJsZTogYWRkIG5ldyBpb2N0bHMgdG8gbWFwIGRtYWJ1ZiB0byBleGlzdGluZyBmZDxi cj4NCjxicj4NCiZuYnNwO2RyaXZlcnMvZG1hLWJ1Zi9kbWEtYnVmLmMmbmJzcDsmbmJzcDsgfCZu YnNwOyA0NCArKysrPGJyPg0KJm5ic3A7ZHJpdmVycy94ZW4vZ250ZGV2LWNvbW1vbi5oIHwmbmJz cDsmbmJzcDsgOCArLTxicj4NCiZuYnNwO2RyaXZlcnMveGVuL2dudGRldi1kbWFidWYuYyB8IDQx NiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy08YnI+DQombmJzcDtkcml2ZXJz L3hlbi9nbnRkZXYtZG1hYnVmLmggfCZuYnNwOyZuYnNwOyA3ICs8YnI+DQombmJzcDtkcml2ZXJz L3hlbi9nbnRkZXYuYyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyB8 IDEwMSArKysrKysrKy08YnI+DQombmJzcDtkcml2ZXJzL3hlbi9ncmFudC10YWJsZS5jJm5ic3A7 Jm5ic3A7IHwmbmJzcDsgNzMgKysrKystLTxicj4NCiZuYnNwO2luY2x1ZGUvbGludXgvZG1hLWJ1 Zi5oJm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7IHwmbmJzcDsgMTUgKys8YnI+DQombmJzcDtpbmNs dWRlL3VhcGkveGVuL2dudGRldi5oJm5ic3A7Jm5ic3A7IHwmbmJzcDsgNjIgKysrKysrPGJyPg0K Jm5ic3A7aW5jbHVkZS94ZW4vZ3JhbnRfdGFibGUuaCZuYnNwOyZuYnNwOyB8Jm5ic3A7Jm5ic3A7 IDggKzxicj4NCiZuYnNwOzkgZmlsZXMgY2hhbmdlZCwgNzAzIGluc2VydGlvbnMoKyksIDMxIGRl bGV0aW9ucygtKTxicj4NCjxicj4NCi0tIDxicj4NCjIuMjUuMTxicj4NCjwvZGl2Pg0KPC9zcGFu PjwvZm9udD48L2Rpdj4NCjwvZGl2Pg0KPC9ibG9ja3F1b3RlPg0KPC9ib2R5Pg0KPC9odG1sPg0K --_000_3066964b511f6314bc8f79e387712013epamcom_-- From xen-devel-bounces@lists.xenproject.org Mon Jan 02 21:01:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 Jan 2023 21:01:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470389.729878 (Exim 4.92) (envelope-from ) id 1pCRvb-0000A2-EY; Mon, 02 Jan 2023 21:01:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470389.729878; Mon, 02 Jan 2023 21:01:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCRvb-00009s-B3; Mon, 02 Jan 2023 21:01:03 +0000 Received: by outflank-mailman (input) for mailman id 470389; Mon, 02 Jan 2023 21:01:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCRvZ-00009f-UD; Mon, 02 Jan 2023 21:01:01 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCRvZ-0000Ri-Py; Mon, 02 Jan 2023 21:01:01 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCRvZ-0006LP-6k; Mon, 02 Jan 2023 21:01:01 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pCRvZ-0001M9-6I; Mon, 02 Jan 2023 21:01:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=lam2k+eFP9Z/Vyf+PiWhfCGZt1/LdhplGcM9qnY5dzI=; b=T1BPKcTU9TLZWIPzQJB1RwosO3 +b9LDFYIOF5nvnJ7FX80AIP3t1b9+pK84O8xzBptnVx+2h6+gMB3SdG4fSlQGYyh1QZ1QzGjDIAIn ENFXrEn4ShS2qgpeasE1OasJWVDRyFkFYMv35kerT0HmewteEojIZFt7Wp3/zoQWM5yw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 175550: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=88603b6dc419445847923fcb7fe5080067a30f98 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Mon, 02 Jan 2023 21:01:01 +0000 flight 175550 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/175550/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 173462 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine 8 reboot fail REGR. vs. 173462 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux 88603b6dc419445847923fcb7fe5080067a30f98 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 87 days Failing since 173470 2022-10-08 06:21:34 Z 86 days 179 attempts Testing same since 175546 2023-01-01 23:13:03 Z 0 days 2 attempts ------------------------------------------------------------ 3255 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 497012 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Jan 02 21:35:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 Jan 2023 21:35:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470400.729912 (Exim 4.92) (envelope-from ) id 1pCST9-00041q-V7; Mon, 02 Jan 2023 21:35:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470400.729912; Mon, 02 Jan 2023 21:35:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCST9-00041Y-Nr; Mon, 02 Jan 2023 21:35:43 +0000 Received: by outflank-mailman (input) for mailman id 470400; Mon, 02 Jan 2023 21:35:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCST8-0003Wk-CH for xen-devel@lists.xenproject.org; Mon, 02 Jan 2023 21:35:42 +0000 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [2a00:1450:4864:20::633]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6765f685-8ae5-11ed-b8d0-410ff93cb8f0; Mon, 02 Jan 2023 22:35:40 +0100 (CET) Received: by mail-ej1-x633.google.com with SMTP id m18so69165178eji.5 for ; Mon, 02 Jan 2023 13:35:40 -0800 (PST) Received: from osoxes.fritz.box (p200300faaf0bb2009c4947838afc41b6.dip0.t-ipconnect.de. [2003:fa:af0b:b200:9c49:4783:8afc:41b6]) by smtp.gmail.com with ESMTPSA id f11-20020a17090631cb00b0084c465709b7sm10583826ejf.74.2023.01.02.13.35.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Jan 2023 13:35:39 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6765f685-8ae5-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gZDEL8s6HWwEfgKMeGlSAkqHU0n7hORkrqT7smSJTVY=; b=GU3AYEhEt5HGHHUhKsuD0ojio6SvhzKD2dSKr64WYZjapbbSIsZnEZNRwIsilTaOUJ iGTkrUbs+yhPQyQgY/ZZpAiFqB4ecrRyGNQlNB9jjQAFyfPYYKyIu3p+2LAHxwhgitUL LedNWX6Boc+BkDPK3KEqCjyCurW61QmS5JrZOGNzDZwVGaY/3Bu50aDxQPLngHJylhPt wdEtW5D2xVHw3Vu4PphFdbdzXJQQT1bvsQyyOKRq9fDe6W81Cvgzz2lFPFByXTJL5t4o 5CQ8Qo1pNIhYYxhrzpL7P7fjIZnzuZrFuUzHvPYI6ubpnIrjO06SV/rS4zJP0QG7PcyB Swaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gZDEL8s6HWwEfgKMeGlSAkqHU0n7hORkrqT7smSJTVY=; b=QFU5oC71Yk5hHY3H/mWS4ZzcDTAPl9QJmWRDXZL/vYIu94oZrMi2UUeX9GvuBg054w l0NcjgtS0WiPe5tdOa5JaM/lKwO/G9BUL0RjYTmeHvuMzbwkJYyUod5szAYZpB7DkuP/ DvUP8FGng4ovzsvOOy1DoSUxU/zdCt06RlJ3blF7fZgAeimbiBB8QRt6rdbCL8LQk7qe iu0xRlKY/0AKQqPYbYPgA1On3ED52tMEVy9HOQcDrkNxDJsjHeTNxPQQXafgr+zPYME+ wJwQft0ubY7aDmpTm/2UkArG4KyzjTatRsraXO4wtOjmk9csNCqUsz+Oq9eoT1xPDTMF pg3A== X-Gm-Message-State: AFqh2kq4QmGcSTQvY+RkxZNzHkCDxDBLfatipvHgcL1TZoOMbPxUs+lU JGOUpXl6NYgZYkufwyHwvaQ= X-Google-Smtp-Source: AMrXdXtC/ibfuSlBrNsQnaQfyhwXLOGrgcrvGa+eum0cbe4JY/6WC6uF8ZpOR32bH9fWmLx0CvyqaQ== X-Received: by 2002:a17:906:a1d7:b0:815:8942:dde with SMTP id bx23-20020a170906a1d700b0081589420ddemr45198684ejb.23.1672695340325; Mon, 02 Jan 2023 13:35:40 -0800 (PST) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: Paul Durrant , Marcel Apfelbaum , "Michael S. Tsirkin" , Stefano Stabellini , Anthony Perard , Aurelien Jarno , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Eduardo Habkost , xen-devel@lists.xenproject.org, =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Paolo Bonzini , Richard Henderson , Bernhard Beschow Subject: [PATCH 2/6] hw/isa/piix: Reuse piix3_realize() in piix3_xen_realize() Date: Mon, 2 Jan 2023 22:35:00 +0100 Message-Id: <20230102213504.14646-3-shentey@gmail.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230102213504.14646-1-shentey@gmail.com> References: <20230102213504.14646-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This is a preparational patch for the next one to make the following more obvious: First, pci_bus_irqs() is now called twice in case of Xen where the second call overrides the pci_set_irq_fn with the Xen variant. Second, pci_bus_set_route_irq_fn() is now also called in Xen mode. Signed-off-by: Bernhard Beschow --- hw/isa/piix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/isa/piix.c b/hw/isa/piix.c index dc6014a4e4..a1281c2d77 100644 --- a/hw/isa/piix.c +++ b/hw/isa/piix.c @@ -493,7 +493,7 @@ static void piix3_xen_realize(PCIDevice *dev, Error **errp) PIIXState *piix3 = PIIX_PCI_DEVICE(dev); PCIBus *pci_bus = pci_get_bus(dev); - pci_piix_realize(dev, TYPE_PIIX3_USB_UHCI, errp); + piix3_realize(dev, errp); if (*errp) { return; } -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Mon Jan 02 21:35:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 Jan 2023 21:35:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470399.729895 (Exim 4.92) (envelope-from ) id 1pCST8-0003aS-Dx; Mon, 02 Jan 2023 21:35:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470399.729895; Mon, 02 Jan 2023 21:35:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCST8-0003ZF-7a; Mon, 02 Jan 2023 21:35:42 +0000 Received: by outflank-mailman (input) for mailman id 470399; Mon, 02 Jan 2023 21:35:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCST6-0003Wl-Qh for xen-devel@lists.xenproject.org; Mon, 02 Jan 2023 21:35:40 +0000 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [2a00:1450:4864:20::631]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 66c192d6-8ae5-11ed-91b6-6bf2151ebd3b; Mon, 02 Jan 2023 22:35:39 +0100 (CET) Received: by mail-ej1-x631.google.com with SMTP id u9so69361564ejo.0 for ; Mon, 02 Jan 2023 13:35:39 -0800 (PST) Received: from osoxes.fritz.box (p200300faaf0bb2009c4947838afc41b6.dip0.t-ipconnect.de. [2003:fa:af0b:b200:9c49:4783:8afc:41b6]) by smtp.gmail.com with ESMTPSA id f11-20020a17090631cb00b0084c465709b7sm10583826ejf.74.2023.01.02.13.35.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Jan 2023 13:35:38 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 66c192d6-8ae5-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AhjGz5k2CpbSc4H1yL5PDfOgeHeVz+Sw9cmuSS5IpyA=; b=owH/gHSxZpPPK6jvooYZ2wLT9TML1U3LOD629OCrtg+nERm71Dji9K6TNg3MbP6Idc qcr126FdTfRUKlWTIXTY+Bgh37w+XP8+KS1ONuTsaMPx8lC9OojQhW7i7hBUNA9igiqi 0v1xr7C4jQOwjzirYfnBq8TDN97Iw+0ano5/nh5z0xMU5V/R/iqLspeXW77ZBjfooiu3 r8Xfxx73bxr97JwI5kDKQM/jYhKNXoAT2c00SH5ujp4Jzc+PhtRVm192H5TPW1zIPZvr TpLoG9qlpOhMEhPVkIGVXiyGOxzZUa63JMH+ChYMA8W8mWV7O3EAr+PNxZJ1Gd4R6rOu pYsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AhjGz5k2CpbSc4H1yL5PDfOgeHeVz+Sw9cmuSS5IpyA=; b=BdzhCGTWdTkEauStNARUaT9PapnrXOAQX5Q/3DsOr/i0FUMuhTlG3GGmE4A1Cw16wn F3AEroIqqgetoxljdL0UVHP5TbXoPbd0zDuq4FbIjizUHybdnswlM29ihCkjiyEj9Kpx svpexZfru7U9JfahntnfoLgm/gap7LSq6k9EMKDW4msS8i6k0hN4sMJvo9+a3LgNyOG8 bdeMjbl9shENjuRDgymYgeRURSDeF5wnEqTWsmcfBpwK9kMUFxmhyhrNm2Q3gI/tbS9P GMUBsKPzHazTU7eg1AXzr3SK4CBB3Ub4ZF+DtOUkmcv42n9VXfeDE1JiqgOsuFUD7Jbm XzjA== X-Gm-Message-State: AFqh2kq2yGJyiTc5YZRE9u9xxc7wXmAUXywe8GhafM9AeS75c5tguORt Y2WbrB/sNehmbLAXZ46vwYo= X-Google-Smtp-Source: AMrXdXsKw/KWvzmQ9hqdX4WTRGdsRsoTmLiF1urYt1nYchYGOMtg1bcydRX4/IC9k2BmIdSzSy2jZQ== X-Received: by 2002:a17:907:9625:b0:7ad:9455:d57d with SMTP id gb37-20020a170907962500b007ad9455d57dmr38487663ejc.74.1672695339125; Mon, 02 Jan 2023 13:35:39 -0800 (PST) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: Paul Durrant , Marcel Apfelbaum , "Michael S. Tsirkin" , Stefano Stabellini , Anthony Perard , Aurelien Jarno , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Eduardo Habkost , xen-devel@lists.xenproject.org, =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Paolo Bonzini , Richard Henderson , Bernhard Beschow Subject: [PATCH 1/6] include/hw/xen/xen: Make xen_piix3_set_irq() generic and rename it Date: Mon, 2 Jan 2023 22:34:59 +0100 Message-Id: <20230102213504.14646-2-shentey@gmail.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230102213504.14646-1-shentey@gmail.com> References: <20230102213504.14646-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit xen_piix3_set_irq() hardcoded the number of PCI IRQ lines. Get it from the PCI bus instead. Signed-off-by: Bernhard Beschow --- hw/i386/xen/xen-hvm.c | 9 ++++++--- hw/isa/piix.c | 2 +- include/hw/xen/xen.h | 2 +- stubs/xen-hw-stub.c | 2 +- 4 files changed, 9 insertions(+), 6 deletions(-) diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c index e4293d6d66..59e8246a48 100644 --- a/hw/i386/xen/xen-hvm.c +++ b/hw/i386/xen/xen-hvm.c @@ -142,10 +142,13 @@ int xen_pci_slot_get_pirq(PCIDevice *pci_dev, int irq_num) return irq_num + (PCI_SLOT(pci_dev->devfn) << 2); } -void xen_piix3_set_irq(void *opaque, int irq_num, int level) +void xen_intx_set_irq(void *opaque, int irq_num, int level) { - xen_set_pci_intx_level(xen_domid, 0, 0, irq_num >> 2, - irq_num & 3, level); + PCIDevice *pci_dev = opaque; + PCIBus *pci_bus = pci_get_bus(pci_dev); + + xen_set_pci_intx_level(xen_domid, 0, 0, irq_num / pci_bus->nirq, + irq_num % pci_bus->nirq, level); } int xen_set_pci_link_route(uint8_t link, uint8_t irq) diff --git a/hw/isa/piix.c b/hw/isa/piix.c index ae8a27c53c..dc6014a4e4 100644 --- a/hw/isa/piix.c +++ b/hw/isa/piix.c @@ -504,7 +504,7 @@ static void piix3_xen_realize(PCIDevice *dev, Error **errp) * connected to the IOAPIC directly. * These additional routes can be discovered through ACPI. */ - pci_bus_irqs(pci_bus, xen_piix3_set_irq, piix3, XEN_PIIX_NUM_PIRQS); + pci_bus_irqs(pci_bus, xen_intx_set_irq, piix3, XEN_PIIX_NUM_PIRQS); } static void piix3_xen_class_init(ObjectClass *klass, void *data) diff --git a/include/hw/xen/xen.h b/include/hw/xen/xen.h index afdf9c436a..7c83ecf6b9 100644 --- a/include/hw/xen/xen.h +++ b/include/hw/xen/xen.h @@ -22,7 +22,7 @@ extern bool xen_domid_restrict; int xen_pci_slot_get_pirq(PCIDevice *pci_dev, int irq_num); int xen_set_pci_link_route(uint8_t link, uint8_t irq); -void xen_piix3_set_irq(void *opaque, int irq_num, int level); +void xen_intx_set_irq(void *opaque, int irq_num, int level); void xen_hvm_inject_msi(uint64_t addr, uint32_t data); int xen_is_pirq_msi(uint32_t msi_data); diff --git a/stubs/xen-hw-stub.c b/stubs/xen-hw-stub.c index 34a22f2ad7..7d7ffe83a9 100644 --- a/stubs/xen-hw-stub.c +++ b/stubs/xen-hw-stub.c @@ -15,7 +15,7 @@ int xen_pci_slot_get_pirq(PCIDevice *pci_dev, int irq_num) return -1; } -void xen_piix3_set_irq(void *opaque, int irq_num, int level) +void xen_intx_set_irq(void *opaque, int irq_num, int level) { } -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Mon Jan 02 21:35:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 Jan 2023 21:35:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470402.729927 (Exim 4.92) (envelope-from ) id 1pCSTB-0004KI-F5; Mon, 02 Jan 2023 21:35:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470402.729927; Mon, 02 Jan 2023 21:35:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCSTB-0004JT-8N; Mon, 02 Jan 2023 21:35:45 +0000 Received: by outflank-mailman (input) for mailman id 470402; Mon, 02 Jan 2023 21:35:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCST9-0003Wk-Lw for xen-devel@lists.xenproject.org; Mon, 02 Jan 2023 21:35:43 +0000 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [2a00:1450:4864:20::633]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6823eacd-8ae5-11ed-b8d0-410ff93cb8f0; Mon, 02 Jan 2023 22:35:41 +0100 (CET) Received: by mail-ej1-x633.google.com with SMTP id qk9so69227516ejc.3 for ; Mon, 02 Jan 2023 13:35:41 -0800 (PST) Received: from osoxes.fritz.box (p200300faaf0bb2009c4947838afc41b6.dip0.t-ipconnect.de. [2003:fa:af0b:b200:9c49:4783:8afc:41b6]) by smtp.gmail.com with ESMTPSA id f11-20020a17090631cb00b0084c465709b7sm10583826ejf.74.2023.01.02.13.35.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Jan 2023 13:35:41 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6823eacd-8ae5-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=D3N14otcWIL0n4lyXnEKPR8qnN0/LRmM4qVkpIj4xR0=; b=o/cROMVNdjgczrnzaHlIWJEYXmIcrhVEkY1chtTByVFgw8LTNs+VtgtFtEZgCY5yoO nzOSynWwIDOUxRcnk9SUCJGzI20lfjgufMnCsY3qKkrbVKMBuWhX5TfEhfasZkfISq3w UUBnbDggVxAN214v2MFTNHh1dDpNtR39S8/3tlxvw36a2E8mKGLvwXUdhgefdiWugr2Q /JRT9RMXrxyUOTVNhO906P9DpV3HnLmQXEbcusyKm+dfxznocAkcd176q8u6n1jPlKMw RuGYas0dxRTf9TF7zr00vUMGJtTGMRb1AQ7dyW7UTX3Cu2OxXUh1shUHoWE61xetRae1 jQiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=D3N14otcWIL0n4lyXnEKPR8qnN0/LRmM4qVkpIj4xR0=; b=12C9he5Yw+mNQUKLlQ/Sg/I21kIO8cWuyM6u5dL1lhOkjmbqffQxY02quCSoG3H/GQ 54gNXO8ioU6yB+8pjn99HwGkIONlAyruzA+rvfhs0ziS/xrCU1NQjAW05rDEIpZKEHY6 RIOk2SluH9doZwZ+Vd3blxbv43JnICfdTRYc/QwEBUf5hDPRSgCeXLZW3h9jIX7uhHHE wRf89QriXv7FxNv5TBeCjeJMx+M/7asvAVU8SFAhDqeAeS8Ggc2/Lnom372dAc/eGSb2 kGTWYvqdFAksjIzQo6l30PetMySpNaaxDs5I6tP5eV+by7S0zWQ2agE+dqe/10m6tcDt cI/Q== X-Gm-Message-State: AFqh2kp9eWLGHFRUQKRmRjz6K5KnsF9p8ULVJQp4eu30OAZdSPbUSjiQ asnFgr02jffAxX8DrtNWRS4= X-Google-Smtp-Source: AMrXdXsbnk+1fmyTa+aN0jvfrb8pZSWUpibMyiM6zr4b2AEMWkyILO87oUs0wXcIHRi65FlXo993VQ== X-Received: by 2002:a17:906:2349:b0:837:3ddb:7e97 with SMTP id m9-20020a170906234900b008373ddb7e97mr43321304eja.61.1672695341405; Mon, 02 Jan 2023 13:35:41 -0800 (PST) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: Paul Durrant , Marcel Apfelbaum , "Michael S. Tsirkin" , Stefano Stabellini , Anthony Perard , Aurelien Jarno , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Eduardo Habkost , xen-devel@lists.xenproject.org, =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Paolo Bonzini , Richard Henderson , Bernhard Beschow Subject: [PATCH 3/6] hw/isa/piix: Wire up Xen PCI IRQ handling outside of PIIX3 Date: Mon, 2 Jan 2023 22:35:01 +0100 Message-Id: <20230102213504.14646-4-shentey@gmail.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230102213504.14646-1-shentey@gmail.com> References: <20230102213504.14646-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit xen_intx_set_irq() doesn't depend on PIIX state. In order to resolve TYPE_PIIX3_XEN_DEVICE and in order to make Xen agnostic about the precise south bridge being used, set up Xen's PCI IRQ handling of PIIX3 in the board. Signed-off-by: Bernhard Beschow --- hw/i386/pc_piix.c | 12 ++++++++++++ hw/isa/piix.c | 24 +----------------------- 2 files changed, 13 insertions(+), 23 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index aacdb72b7c..c02f68010d 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -67,6 +67,7 @@ #include "kvm/kvm-cpu.h" #define MAX_IDE_BUS 2 +#define XEN_PIIX_NUM_PIRQS 128ULL #ifdef CONFIG_IDE_ISA static const int ide_iobase[MAX_IDE_BUS] = { 0x1f0, 0x170 }; @@ -246,6 +247,17 @@ static void pc_init1(MachineState *machine, &error_abort); pci_realize_and_unref(pci_dev, pci_bus, &error_fatal); + if (xen_enabled()) { + /* + * Xen supports additional interrupt routes from the PCI devices to + * the IOAPIC: the four pins of each PCI device on the bus are also + * connected to the IOAPIC directly. + * These additional routes can be discovered through ACPI. + */ + pci_bus_irqs(pci_bus, xen_intx_set_irq, pci_dev, + XEN_PIIX_NUM_PIRQS); + } + dev = DEVICE(object_resolve_path_component(OBJECT(pci_dev), "pic")); for (i = 0; i < ISA_NUM_IRQS; i++) { qdev_connect_gpio_out(dev, i, x86ms->gsi[i]); diff --git a/hw/isa/piix.c b/hw/isa/piix.c index a1281c2d77..ac04781f46 100644 --- a/hw/isa/piix.c +++ b/hw/isa/piix.c @@ -38,8 +38,6 @@ #include "migration/vmstate.h" #include "hw/acpi/acpi_aml_interface.h" -#define XEN_PIIX_NUM_PIRQS 128ULL - static void piix_set_irq_pic(PIIXState *piix, int pic_irq) { qemu_set_irq(piix->pic.in_irqs[pic_irq], @@ -487,33 +485,13 @@ static const TypeInfo piix3_info = { .class_init = piix3_class_init, }; -static void piix3_xen_realize(PCIDevice *dev, Error **errp) -{ - ERRP_GUARD(); - PIIXState *piix3 = PIIX_PCI_DEVICE(dev); - PCIBus *pci_bus = pci_get_bus(dev); - - piix3_realize(dev, errp); - if (*errp) { - return; - } - - /* - * Xen supports additional interrupt routes from the PCI devices to - * the IOAPIC: the four pins of each PCI device on the bus are also - * connected to the IOAPIC directly. - * These additional routes can be discovered through ACPI. - */ - pci_bus_irqs(pci_bus, xen_intx_set_irq, piix3, XEN_PIIX_NUM_PIRQS); -} - static void piix3_xen_class_init(ObjectClass *klass, void *data) { DeviceClass *dc = DEVICE_CLASS(klass); PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); k->config_write = piix3_write_config_xen; - k->realize = piix3_xen_realize; + k->realize = piix3_realize; /* 82371SB PIIX3 PCI-to-ISA bridge (Step A1) */ k->device_id = PCI_DEVICE_ID_INTEL_82371SB_0; dc->vmsd = &vmstate_piix3; -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Mon Jan 02 21:35:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 Jan 2023 21:35:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470403.729942 (Exim 4.92) (envelope-from ) id 1pCSTC-0004jt-PH; Mon, 02 Jan 2023 21:35:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470403.729942; Mon, 02 Jan 2023 21:35:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCSTC-0004iy-J8; Mon, 02 Jan 2023 21:35:46 +0000 Received: by outflank-mailman (input) for mailman id 470403; Mon, 02 Jan 2023 21:35:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCSTB-0003Wk-Gr for xen-devel@lists.xenproject.org; Mon, 02 Jan 2023 21:35:45 +0000 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [2a00:1450:4864:20::633]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6960b59e-8ae5-11ed-b8d0-410ff93cb8f0; Mon, 02 Jan 2023 22:35:43 +0100 (CET) Received: by mail-ej1-x633.google.com with SMTP id m18so69165375eji.5 for ; Mon, 02 Jan 2023 13:35:43 -0800 (PST) Received: from osoxes.fritz.box (p200300faaf0bb2009c4947838afc41b6.dip0.t-ipconnect.de. [2003:fa:af0b:b200:9c49:4783:8afc:41b6]) by smtp.gmail.com with ESMTPSA id f11-20020a17090631cb00b0084c465709b7sm10583826ejf.74.2023.01.02.13.35.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Jan 2023 13:35:43 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6960b59e-8ae5-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZTbz96Fg6rdZNkQF03buq3nvArFrt1X2bnXBL/QETy8=; b=PsKszMFE/irXAQUUzyvmEIaEr0Tcpdj3qhQcGkpM6bYRneaVlCz9APN9qcxNx7XmNo KLZfpHfC5iyIkCg8DGZEO4juAo/rZxv4CMMbW6pgthHUkyA2C1vKwUY20xj2gWQil7Zw jDG7lQAM8bdmOaCwb7KbNXuVBzjg4YjJD5g65Tg0rYTlN+NbeDFcUpR6TAg1MVAEV7zN i481Ii117uzsakJQlHK4tV7aHWnDIjke8SIy8P0RWBgz4pEH+jNFsPpnCqeEDR3i8nak Dc6oZySXPxHR7v967RWJPS5SkmtQNNGpv+r2EOUT/sAmRxGlHKArDmdliBsUgWsrEfGG VIIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZTbz96Fg6rdZNkQF03buq3nvArFrt1X2bnXBL/QETy8=; b=tXC1jm6887S5wd9YaEsRFoqjXGPZpmYbqnMKuwRPhumdHNRlDbJ7+dfMDwvtjP+SAD yx+R79Yf1zpm7t+35x7dQT6DDFr9qQjrvqo5K02HnCWpZRSYlq82l/xP+kB2BmXjW5+v oExYubbBtpVF8RKJEt+WJvn60MQOCez2pQYY4l4S7GpqDxblPDn/ValmAtfydga6muj5 EMdqQxzQJoE6mggJwP6J3vJYMZJrSvpQXNQWzxY6o1x1hH4VQLCj16fZaBCVmYeyvWzd xs58pUhFthghW4mxnKn+26MkE0DiTaiyofEv8ruiyxGGXzgNpQCs8raI34dZ/i8hA45p ss5w== X-Gm-Message-State: AFqh2kpyJ6FW2Sgb9jQ3lphEYanMwZYry2yJXcJMM1cMlf2g9NZp4xYY /cMQJEuJX91dJtFHip/suVE= X-Google-Smtp-Source: AMrXdXsn74EQeNcIi6oiYO0nJq/ZeXKHgJ9u+Dwmp6n2+uN/W06k2zB+iAzGi6JoudbLO8czjj/jbQ== X-Received: by 2002:a17:906:d205:b0:7c1:51ee:a2ec with SMTP id w5-20020a170906d20500b007c151eea2ecmr36107634ejz.46.1672695343628; Mon, 02 Jan 2023 13:35:43 -0800 (PST) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: Paul Durrant , Marcel Apfelbaum , "Michael S. Tsirkin" , Stefano Stabellini , Anthony Perard , Aurelien Jarno , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Eduardo Habkost , xen-devel@lists.xenproject.org, =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Paolo Bonzini , Richard Henderson , Bernhard Beschow Subject: [PATCH 5/6] hw/isa/piix: Resolve redundant k->config_write assignments Date: Mon, 2 Jan 2023 22:35:03 +0100 Message-Id: <20230102213504.14646-6-shentey@gmail.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230102213504.14646-1-shentey@gmail.com> References: <20230102213504.14646-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The previous patch unified handling of piix_write_config() accross all PIIX device models which allows for assigning k->config_write once in the base class. Signed-off-by: Bernhard Beschow --- hw/isa/piix.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/isa/piix.c b/hw/isa/piix.c index d4cdb3dadb..98e9b12661 100644 --- a/hw/isa/piix.c +++ b/hw/isa/piix.c @@ -396,6 +396,7 @@ static void pci_piix_class_init(ObjectClass *klass, void *data) PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); AcpiDevAmlIfClass *adevc = ACPI_DEV_AML_IF_CLASS(klass); + k->config_write = piix_write_config; dc->reset = piix_reset; dc->desc = "ISA bridge"; dc->hotpluggable = false; @@ -451,7 +452,6 @@ static void piix3_class_init(ObjectClass *klass, void *data) DeviceClass *dc = DEVICE_CLASS(klass); PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); - k->config_write = piix_write_config; k->realize = piix3_realize; /* 82371SB PIIX3 PCI-to-ISA bridge (Step A1) */ k->device_id = PCI_DEVICE_ID_INTEL_82371SB_0; @@ -470,7 +470,6 @@ static void piix3_xen_class_init(ObjectClass *klass, void *data) DeviceClass *dc = DEVICE_CLASS(klass); PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); - k->config_write = piix_write_config; k->realize = piix3_realize; /* 82371SB PIIX3 PCI-to-ISA bridge (Step A1) */ k->device_id = PCI_DEVICE_ID_INTEL_82371SB_0; @@ -519,7 +518,6 @@ static void piix4_class_init(ObjectClass *klass, void *data) DeviceClass *dc = DEVICE_CLASS(klass); PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); - k->config_write = piix_write_config; k->realize = piix4_realize; k->device_id = PCI_DEVICE_ID_INTEL_82371AB_0; dc->vmsd = &vmstate_piix4; -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Mon Jan 02 21:35:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 Jan 2023 21:35:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470398.729888 (Exim 4.92) (envelope-from ) id 1pCST8-0003X3-33; Mon, 02 Jan 2023 21:35:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470398.729888; Mon, 02 Jan 2023 21:35:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCST8-0003Ww-0F; Mon, 02 Jan 2023 21:35:42 +0000 Received: by outflank-mailman (input) for mailman id 470398; Mon, 02 Jan 2023 21:35:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCST6-0003Wk-Nl for xen-devel@lists.xenproject.org; Mon, 02 Jan 2023 21:35:40 +0000 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [2a00:1450:4864:20::634]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6627f758-8ae5-11ed-b8d0-410ff93cb8f0; Mon, 02 Jan 2023 22:35:38 +0100 (CET) Received: by mail-ej1-x634.google.com with SMTP id vm8so62327859ejc.2 for ; Mon, 02 Jan 2023 13:35:38 -0800 (PST) Received: from osoxes.fritz.box (p200300faaf0bb2009c4947838afc41b6.dip0.t-ipconnect.de. [2003:fa:af0b:b200:9c49:4783:8afc:41b6]) by smtp.gmail.com with ESMTPSA id f11-20020a17090631cb00b0084c465709b7sm10583826ejf.74.2023.01.02.13.35.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Jan 2023 13:35:37 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6627f758-8ae5-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ThcfWkzyxbomQpjRZA7dc6wiEsJYQ4EhFUJkZuMYNh4=; b=l3DiR+ii5Hfw71WDsiNsQdM2zwr5EVsEEAGGOTU6ym+YOnTFgyDMg9p3kAGMFm2Uf/ aQS0jZyQnqxtYSMIPattFYbm1mdsvpSJ/GGsEEd5HhYrEEeJ6+2Fu38VF4NsSG6Y21lK AHtxfwQOcsVklKIdAlVyxuFr1pmDQodVdZJhWtiAToFJemLAUAaz3oFSXvJAQTBCumzf fXIh9eI0mnzZ2IHGNbfvZOC7FxHI11aH6DYlMAaKv7fdbr/Awo02oZHlRFHMG503UjCZ k9Rxs77JgBKr5BTE3jl29v3+IbSrFZHhEs8IwI6z+tCMLssBEMwiOSRQih7t0fPjl1kG WoJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ThcfWkzyxbomQpjRZA7dc6wiEsJYQ4EhFUJkZuMYNh4=; b=vUCrY0uGT43bpAGlD3s/VcRla72zCXlf/OWrx9ChDsvBLU/JR3PfE+/WtfB5egh+X7 b6cPuaiOjWRK+DaTVqIMv5Fs04ijQT0dPW25OKudhXq5TlPVmltUGdgAg4e7q5yDtqm1 zQLGUeWB+1yQFIitxUGIMSB5+FVWQVy1WvDiwSZITlH/hVHZe6uRGJcP4XYXfMqwkAIK 1VVEwusu+xsjcSbal7bFCB94SOz/Xmqbzpr2sTO6Jzr1Jh0P6t3uXKeJx8/S+/Kg+NOU RhEGgleYEIMOBWKtk0sf1lg1DVjFWFvQdyBJqEK4XhxHRejbPzF1fs83O6CujQE6Pjb3 g99g== X-Gm-Message-State: AFqh2krQFiPQyZpmz2ktSeSv2x+pZ0aMssNz+shn6kKNlW7+tVypr/wQ BRTfUy99YtpjE+RVpfyeWJM= X-Google-Smtp-Source: AMrXdXurMjYiz5Hum/Tzox9GBdNJ4/Pvd6hcKQmZX141+8/hdih4/lbxpie9ZEO4sSmtCYEFcdoKug== X-Received: by 2002:a17:907:3ea1:b0:7c1:7f84:10ac with SMTP id hs33-20020a1709073ea100b007c17f8410acmr61151091ejc.33.1672695338100; Mon, 02 Jan 2023 13:35:38 -0800 (PST) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: Paul Durrant , Marcel Apfelbaum , "Michael S. Tsirkin" , Stefano Stabellini , Anthony Perard , Aurelien Jarno , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Eduardo Habkost , xen-devel@lists.xenproject.org, =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Paolo Bonzini , Richard Henderson , Bernhard Beschow Subject: [PATCH 0/6] Resolve TYPE_PIIX3_XEN_DEVICE Date: Mon, 2 Jan 2023 22:34:58 +0100 Message-Id: <20230102213504.14646-1-shentey@gmail.com> X-Mailer: git-send-email 2.39.0 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable This series first renders TYPE_PIIX3_XEN_DEVICE redundant and finally remov= es=0D it. The motivation is to 1/ decouple PIIX from Xen and 2/ to make Xen in th= e PC=0D machine agnostic to the precise southbridge being used. 2/ will become=0D particularily interesting once PIIX4 becomes usable in the PC machine, avoi= ding=0D the "Frankenstein" use of PIIX4_ACPI in PIIX3.=0D =0D Testing done:=0D None, because I don't know how to conduct this properly :(=0D =0D Based-on: <20221221170003.2929-1-shentey@gmail.com>=0D "[PATCH v4 00/30] Consolidate PIIX south bridges"=0D =0D Bernhard Beschow (6):=0D include/hw/xen/xen: Make xen_piix3_set_irq() generic and rename it=0D hw/isa/piix: Reuse piix3_realize() in piix3_xen_realize()=0D hw/isa/piix: Wire up Xen PCI IRQ handling outside of PIIX3=0D hw/isa/piix: Avoid Xen-specific variant of piix_write_config()=0D hw/isa/piix: Resolve redundant k->config_write assignments=0D hw/isa/piix: Resolve redundant TYPE_PIIX3_XEN_DEVICE=0D =0D hw/i386/pc_piix.c | 34 ++++++++++++++++--=0D hw/i386/xen/xen-hvm.c | 9 +++--=0D hw/isa/piix.c | 66 +----------------------------------=0D include/hw/southbridge/piix.h | 1 -=0D include/hw/xen/xen.h | 2 +-=0D stubs/xen-hw-stub.c | 2 +-=0D 6 files changed, 40 insertions(+), 74 deletions(-)=0D =0D -- =0D 2.39.0=0D =0D From xen-devel-bounces@lists.xenproject.org Mon Jan 02 21:35:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 Jan 2023 21:35:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470401.729922 (Exim 4.92) (envelope-from ) id 1pCSTB-0004Hn-4X; Mon, 02 Jan 2023 21:35:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470401.729922; Mon, 02 Jan 2023 21:35:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCSTB-0004He-1T; Mon, 02 Jan 2023 21:35:45 +0000 Received: by outflank-mailman (input) for mailman id 470401; Mon, 02 Jan 2023 21:35:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCST9-0003Wl-HS for xen-devel@lists.xenproject.org; Mon, 02 Jan 2023 21:35:43 +0000 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [2a00:1450:4864:20::631]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 68b2b11a-8ae5-11ed-91b6-6bf2151ebd3b; Mon, 02 Jan 2023 22:35:42 +0100 (CET) Received: by mail-ej1-x631.google.com with SMTP id tz12so69253234ejc.9 for ; Mon, 02 Jan 2023 13:35:42 -0800 (PST) Received: from osoxes.fritz.box (p200300faaf0bb2009c4947838afc41b6.dip0.t-ipconnect.de. [2003:fa:af0b:b200:9c49:4783:8afc:41b6]) by smtp.gmail.com with ESMTPSA id f11-20020a17090631cb00b0084c465709b7sm10583826ejf.74.2023.01.02.13.35.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Jan 2023 13:35:42 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 68b2b11a-8ae5-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7hyvY3JWBoATeou/9rB1bwHPuTVRUibflv0giDEMRFI=; b=FFEt7jlJJ+TZncL9s1i0SklCgyxtm7oXcgRQkgj1jE/dUm5xg4LuIlrUbaq8eTpWQk lusWPMYsPPe89MlCOjXfmbss+PluOmAxo6TNTCn9VkwqzVNEZ3pVIGV+6zPOo/B7hbEh FmoABY83bkE7ljMZ/86Ed1q7lLc0TapiAISU8cMWHLoCo4wI4jM8GQazvPxntgfkxhiz 2ZSA4IZW5Si/6jksdfwVNRNxrFq3EWZxMZttbBJnMHMVsowEnu9KUUccK7YbD9iPZamu DParMymbvqglGiQez25zSFsN1UKJDDtUYdY3QfXN5LHP3fVI24Qal2+w+ixfoMNzXLhj V9dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7hyvY3JWBoATeou/9rB1bwHPuTVRUibflv0giDEMRFI=; b=3UUAPrDBn6aryWVtNxiLS7asCOMcMAjUJbU4CUbVqxKh8a4iYJ6CE6SK10ch4/ndJt B5LtgvQvD7dKPaAmR8Z9FCy9/lHtB+XMeFhuaiwPcJyfyFG8xmuZTQbEagqvW9ZblUli /YswbHBHfRuYk4uuB3o2C+Lenpe6UAWpYcgX452CpeDPgMEzu3+zEggkzO2FZYg8hF+B +wKITtukVVqr8iMZojEt0s9QzFewVBP/WZRUt0XrQCb25cDB6E247slJkOD6c56d/hfP CJUsv6B2bSuhy0AJOoVZoWxPy065WeyN195sBf0HzGvz97Kjv9wbvEJTlFEB2PX4qFZj WzRg== X-Gm-Message-State: AFqh2kqguy8j4HZBlynSxeobZVM6EacLLp4+vz9PW3RJzZ+LVTLq+fUo ba0Tl7mpNIx/zK/YrXFFH/g= X-Google-Smtp-Source: AMrXdXvIXbwA5JGbCDQQQ/3trRrkBQ1pENW/JDFoCpw2RIHuU1jqIwyoQaXoQv83ATNGp2NKk0iVhw== X-Received: by 2002:a17:906:1410:b0:7c0:eba3:e2e with SMTP id p16-20020a170906141000b007c0eba30e2emr32660029ejc.31.1672695342501; Mon, 02 Jan 2023 13:35:42 -0800 (PST) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: Paul Durrant , Marcel Apfelbaum , "Michael S. Tsirkin" , Stefano Stabellini , Anthony Perard , Aurelien Jarno , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Eduardo Habkost , xen-devel@lists.xenproject.org, =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Paolo Bonzini , Richard Henderson , Bernhard Beschow Subject: [PATCH 4/6] hw/isa/piix: Avoid Xen-specific variant of piix_write_config() Date: Mon, 2 Jan 2023 22:35:02 +0100 Message-Id: <20230102213504.14646-5-shentey@gmail.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230102213504.14646-1-shentey@gmail.com> References: <20230102213504.14646-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subscribe to pci_bus_fire_intx_routing_notifier() instead which allows for having a common piix_write_config() for all PIIX device models. While at it, move the subscription into machine code in order to resolve TYPE_PIIX3_XEN_DEVICE. In a possible future followup, pci_bus_fire_intx_routing_notifier() could be adjusted in such a way that subscribing to it doesn't require knowledge of the device firing it. Signed-off-by: Bernhard Beschow --- hw/i386/pc_piix.c | 18 ++++++++++++++++++ hw/isa/piix.c | 22 +--------------------- 2 files changed, 19 insertions(+), 21 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index c02f68010d..7ef0054b3a 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -86,6 +86,21 @@ static int pci_slot_get_pirq(PCIDevice *pci_dev, int pci_intx) return (pci_intx + slot_addend) & 3; } +static void piix_intx_routing_notifier_xen(PCIDevice *dev) +{ + int i; + + /* Scan for updates to PCI link routes (0x60-0x63). */ + for (i = 0; i < PIIX_NUM_PIRQS; i++) { + uint8_t v = dev->config_read(dev, PIIX_PIRQCA + i, 1); + if (v & 0x80) { + v = 0; + } + v &= 0xf; + xen_set_pci_link_route(i, v); + } +} + /* PC hardware initialisation */ static void pc_init1(MachineState *machine, const char *host_type, const char *pci_type) @@ -248,6 +263,9 @@ static void pc_init1(MachineState *machine, pci_realize_and_unref(pci_dev, pci_bus, &error_fatal); if (xen_enabled()) { + pci_device_set_intx_routing_notifier( + pci_dev, piix_intx_routing_notifier_xen); + /* * Xen supports additional interrupt routes from the PCI devices to * the IOAPIC: the four pins of each PCI device on the bus are also diff --git a/hw/isa/piix.c b/hw/isa/piix.c index ac04781f46..d4cdb3dadb 100644 --- a/hw/isa/piix.c +++ b/hw/isa/piix.c @@ -125,26 +125,6 @@ static void piix_write_config(PCIDevice *dev, uint32_t address, uint32_t val, } } -static void piix3_write_config_xen(PCIDevice *dev, - uint32_t address, uint32_t val, int len) -{ - int i; - - /* Scan for updates to PCI link routes (0x60-0x63). */ - for (i = 0; i < len; i++) { - uint8_t v = (val >> (8 * i)) & 0xff; - if (v & 0x80) { - v = 0; - } - v &= 0xf; - if (((address + i) >= PIIX_PIRQCA) && ((address + i) <= PIIX_PIRQCD)) { - xen_set_pci_link_route(address + i - PIIX_PIRQCA, v); - } - } - - piix_write_config(dev, address, val, len); -} - static void piix_reset(DeviceState *dev) { PIIXState *d = PIIX_PCI_DEVICE(dev); @@ -490,7 +470,7 @@ static void piix3_xen_class_init(ObjectClass *klass, void *data) DeviceClass *dc = DEVICE_CLASS(klass); PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); - k->config_write = piix3_write_config_xen; + k->config_write = piix_write_config; k->realize = piix3_realize; /* 82371SB PIIX3 PCI-to-ISA bridge (Step A1) */ k->device_id = PCI_DEVICE_ID_INTEL_82371SB_0; -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Mon Jan 02 21:35:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 Jan 2023 21:35:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470404.729954 (Exim 4.92) (envelope-from ) id 1pCSTE-00053j-4V; Mon, 02 Jan 2023 21:35:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470404.729954; Mon, 02 Jan 2023 21:35:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCSTD-00053C-TO; Mon, 02 Jan 2023 21:35:47 +0000 Received: by outflank-mailman (input) for mailman id 470404; Mon, 02 Jan 2023 21:35:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCSTC-0003Wk-Qk for xen-devel@lists.xenproject.org; Mon, 02 Jan 2023 21:35:46 +0000 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [2a00:1450:4864:20::62f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6a0576a9-8ae5-11ed-b8d0-410ff93cb8f0; Mon, 02 Jan 2023 22:35:45 +0100 (CET) Received: by mail-ej1-x62f.google.com with SMTP id u19so69210598ejm.8 for ; Mon, 02 Jan 2023 13:35:45 -0800 (PST) Received: from osoxes.fritz.box (p200300faaf0bb2009c4947838afc41b6.dip0.t-ipconnect.de. [2003:fa:af0b:b200:9c49:4783:8afc:41b6]) by smtp.gmail.com with ESMTPSA id f11-20020a17090631cb00b0084c465709b7sm10583826ejf.74.2023.01.02.13.35.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Jan 2023 13:35:44 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6a0576a9-8ae5-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Di8D1ZLAqNG4YBVeY21LWd3M3jwmUnOPUPIRfWvH74o=; b=oKrx+5YbmTLqbEyB0IFlqqHxQljKl/Fp1de0CQdBSfdKl10T7XcJA8XTNLwawbTkeh j5cv6e8K3sfV/6QNn70B21D7ZKgQZTo6P0tzupn4POy+aqrOfkP+od97KKCbHnOo6Fpj sPkN9L6tV5zGaOfBboViBOI31hupccc6I1zTDQGrZnwnnQcNQ7H1IESNC/LCsbAvfHAZ tHza0+AzW+kC0P4eZuGrQfVFLSnww6j6TKQuz3rfwRxSJJBD6CJQdyvobGr3WA3BHfc3 pRH+0ycpzvBgWh/4lVAbvjxJL97sgxaxg9vbiPlGIZI0NsS7h9yctI5oRHM+0gDXCPgf wI3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Di8D1ZLAqNG4YBVeY21LWd3M3jwmUnOPUPIRfWvH74o=; b=Y2yRrYs/cCAa2wY9z2Qk/jLy7yiywOKBrIzz4j0QDTToJaY1MeMRlj1isdRryTrVjT SteVF1MYNY5LCkyhJ1Lx98emwDOVlUwbJlMQQ9uhXfg6zNYFrEJGI7jDU4sjahSaXKf9 zpxOAkTktxvOz5VDuff7xlvh63zY+dQCOaxqXKX0zWHUeShGiphVK79TrgQV3yb/nN0z ujE/aHjl5ggeMWycAV3K94djwkUDScVD5XE8c/RGI9JKxHA8o6aKW8Q69QLkhqhYbGP9 5mjnBdw8TClOWLUKqnsrI+twtWG5JRhfE4nATOpHf73v/JZ7CpKoEoJMTXZS6m2hvKK8 rtQw== X-Gm-Message-State: AFqh2krWy2NAhUHG3p9G0Wyunap00h0CIFiQ7PfMk00RYXrLfv4r1XLH 4Lab/GaN+oZIab2gXV/L68Wyb9YLU8M= X-Google-Smtp-Source: AMrXdXuZ+eoqe1BE27lbsYyf/6auDgeXSZ1ibYoD7I6UMu7gzvCwnSHmEmW7pvlF2BvjpLremBPADA== X-Received: by 2002:a17:907:a407:b0:84c:7974:8a73 with SMTP id sg7-20020a170907a40700b0084c79748a73mr22076362ejc.57.1672695344686; Mon, 02 Jan 2023 13:35:44 -0800 (PST) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: Paul Durrant , Marcel Apfelbaum , "Michael S. Tsirkin" , Stefano Stabellini , Anthony Perard , Aurelien Jarno , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Eduardo Habkost , xen-devel@lists.xenproject.org, =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Paolo Bonzini , Richard Henderson , Bernhard Beschow Subject: [PATCH 6/6] hw/isa/piix: Resolve redundant TYPE_PIIX3_XEN_DEVICE Date: Mon, 2 Jan 2023 22:35:04 +0100 Message-Id: <20230102213504.14646-7-shentey@gmail.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230102213504.14646-1-shentey@gmail.com> References: <20230102213504.14646-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit During the last patches, TYPE_PIIX3_XEN_DEVICE turned into a clone of TYPE_PIIX3_DEVICE. Remove this redundancy. Signed-off-by: Bernhard Beschow --- hw/i386/pc_piix.c | 4 +--- hw/isa/piix.c | 20 -------------------- include/hw/southbridge/piix.h | 1 - 3 files changed, 1 insertion(+), 24 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 7ef0054b3a..76d98183ac 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -235,8 +235,6 @@ static void pc_init1(MachineState *machine, if (pcmc->pci_enabled) { DeviceState *dev; PCIDevice *pci_dev; - const char *type = xen_enabled() ? TYPE_PIIX3_XEN_DEVICE - : TYPE_PIIX3_DEVICE; int i; pci_bus = i440fx_init(pci_type, @@ -250,7 +248,7 @@ static void pc_init1(MachineState *machine, : pci_slot_get_pirq); pcms->bus = pci_bus; - pci_dev = pci_new_multifunction(-1, true, type); + pci_dev = pci_new_multifunction(-1, true, TYPE_PIIX3_DEVICE); object_property_set_bool(OBJECT(pci_dev), "has-usb", machine_usb(machine), &error_abort); object_property_set_bool(OBJECT(pci_dev), "has-acpi", diff --git a/hw/isa/piix.c b/hw/isa/piix.c index 98e9b12661..e4587352c9 100644 --- a/hw/isa/piix.c +++ b/hw/isa/piix.c @@ -33,7 +33,6 @@ #include "hw/qdev-properties.h" #include "hw/ide/piix.h" #include "hw/isa/isa.h" -#include "hw/xen/xen.h" #include "sysemu/runstate.h" #include "migration/vmstate.h" #include "hw/acpi/acpi_aml_interface.h" @@ -465,24 +464,6 @@ static const TypeInfo piix3_info = { .class_init = piix3_class_init, }; -static void piix3_xen_class_init(ObjectClass *klass, void *data) -{ - DeviceClass *dc = DEVICE_CLASS(klass); - PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); - - k->realize = piix3_realize; - /* 82371SB PIIX3 PCI-to-ISA bridge (Step A1) */ - k->device_id = PCI_DEVICE_ID_INTEL_82371SB_0; - dc->vmsd = &vmstate_piix3; -} - -static const TypeInfo piix3_xen_info = { - .name = TYPE_PIIX3_XEN_DEVICE, - .parent = TYPE_PIIX_PCI_DEVICE, - .instance_init = piix3_init, - .class_init = piix3_xen_class_init, -}; - static void piix4_realize(PCIDevice *dev, Error **errp) { ERRP_GUARD(); @@ -534,7 +515,6 @@ static void piix3_register_types(void) { type_register_static(&piix_pci_type_info); type_register_static(&piix3_info); - type_register_static(&piix3_xen_info); type_register_static(&piix4_info); } diff --git a/include/hw/southbridge/piix.h b/include/hw/southbridge/piix.h index 65ad8569da..b1fc94a742 100644 --- a/include/hw/southbridge/piix.h +++ b/include/hw/southbridge/piix.h @@ -77,7 +77,6 @@ struct PIIXState { OBJECT_DECLARE_SIMPLE_TYPE(PIIXState, PIIX_PCI_DEVICE) #define TYPE_PIIX3_DEVICE "PIIX3" -#define TYPE_PIIX3_XEN_DEVICE "PIIX3-xen" #define TYPE_PIIX4_PCI_DEVICE "piix4-isa" #endif -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Mon Jan 02 21:47:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 Jan 2023 21:47:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470451.729966 (Exim 4.92) (envelope-from ) id 1pCSeY-00006N-Ba; Mon, 02 Jan 2023 21:47:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470451.729966; Mon, 02 Jan 2023 21:47:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCSeY-00006G-7w; Mon, 02 Jan 2023 21:47:30 +0000 Received: by outflank-mailman (input) for mailman id 470451; Mon, 02 Jan 2023 21:47:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCSeW-000066-Vp; Mon, 02 Jan 2023 21:47:28 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCSeW-0001X5-Qq; Mon, 02 Jan 2023 21:47:28 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCSeW-0007Pn-4C; Mon, 02 Jan 2023 21:47:28 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pCSeW-0005FO-3k; Mon, 02 Jan 2023 21:47:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=sDKInzDfiPQ0zyd0VH+Niz3QJ70OcqD45GsibYiTQ1w=; b=cDmHlGasIYSTuaJO/05Pvr+IKt 3K6QxeVk48Pz8W90NuBwgZ7l10zjCiMIodRknwhtWf66FdrJzZr0EqDnu9ccUQfmVRvfdsWbWYsMp 8RprGLmYrQecommj269vKvYw2Kc5jIpO7L85822pdRMf4BDiAHMinh04QUb+wTtlOSvQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 175551: FAIL X-Osstest-Failures: linux-5.4:test-amd64-i386-qemuu-rhel6hvm-intel::broken:regression linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64::broken:regression linux-5.4:test-amd64-amd64-xl-qemut-debianhvm-amd64::broken:regression linux-5.4:test-amd64-amd64-xl-credit2::broken:regression linux-5.4:test-armhf-armhf-xl-credit1::broken:regression linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:host-install(5):broken:heisenbug linux-5.4:test-amd64-i386-qemuu-rhel6hvm-intel:host-install(5):broken:heisenbug linux-5.4:test-amd64-amd64-xl-credit2:host-install(5):broken:heisenbug linux-5.4:test-amd64-amd64-xl-qemut-debianhvm-amd64:host-install(5):broken:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:host-install(5):broken:heisenbug linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:heisenbug linux-5.4:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug linux-5.4:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-amd64-i386-xl-vhd:guest-start.2:fail:heisenbug linux-5.4:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-amd64-i386-libvirt-raw:xen-install:fail:heisenbug linux-5.4:test-armhf-armhf-xl:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:heisenbug linux-5.4:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=851c2b5fb7936d54e1147f76f88e2675f9f82b52 X-Osstest-Versions-That: linux=66bb2e2b24ce52819a7070d3a3255726cb946b69 From: osstest service owner Date: Mon, 02 Jan 2023 21:47:28 +0000 flight 175551 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/175551/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-qemuu-rhel6hvm-intel broken in 175407 test-amd64-i386-xl-qemuu-ws16-amd64 broken in 175407 test-amd64-amd64-xl-qemut-debianhvm-amd64 broken in 175407 test-amd64-amd64-xl-credit2 broken in 175407 test-armhf-armhf-xl-credit1 broken in 175547 Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-ws16-amd64 5 host-install(5) broken in 175407 pass in 175551 test-amd64-i386-qemuu-rhel6hvm-intel 5 host-install(5) broken in 175407 pass in 175551 test-amd64-amd64-xl-credit2 5 host-install(5) broken in 175407 pass in 175551 test-amd64-amd64-xl-qemut-debianhvm-amd64 5 host-install(5) broken in 175407 pass in 175551 test-armhf-armhf-xl-credit1 5 host-install(5) broken in 175547 pass in 175551 test-armhf-armhf-xl-multivcpu 14 guest-start fail in 175407 pass in 175551 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail in 175545 pass in 175551 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail in 175545 pass in 175551 test-amd64-i386-xl-vhd 22 guest-start.2 fail in 175547 pass in 175545 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail in 175547 pass in 175551 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail in 175549 pass in 175407 test-amd64-i386-libvirt-raw 7 xen-install fail in 175549 pass in 175551 test-armhf-armhf-xl 18 guest-start/debian.repeat fail in 175549 pass in 175551 test-armhf-armhf-xl-credit2 14 guest-start fail pass in 175547 test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail pass in 175547 test-armhf-armhf-xl-credit1 14 guest-start fail pass in 175549 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail blocked in 175197 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail in 175407 like 175197 test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 175407 never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 175407 never pass test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail in 175547 like 175197 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 175547 like 175197 test-armhf-armhf-xl-credit1 15 migrate-support-check fail in 175549 never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail in 175549 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 175197 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 175197 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175197 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 175197 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175197 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175197 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 175197 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 175197 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail like 175197 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 175197 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 175197 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175197 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 3 hosts-allocate starved in 175547 n/a version targeted for testing: linux 851c2b5fb7936d54e1147f76f88e2675f9f82b52 baseline version: linux 66bb2e2b24ce52819a7070d3a3255726cb946b69 Last test of basis 175197 2022-12-14 10:43:17 Z 19 days Testing same since 175407 2022-12-19 11:42:26 Z 14 days 35 attempts ------------------------------------------------------------ People who touched revisions under test: Alexei Starovoitov Andrew Morton Baolin Wang Charles Keepax Florian Fainelli Greg Kroah-Hartman Guenter Roeck Heiko Schocher Hulk Robot Jakub Kicinski Jialiang Wang Jon Hunter Linus Walleij Linux Kernel Functional Testing Lorenzo Colitti Maciej Żenczykowski Marc Kleine-Budde Mark Brown Ming Lei Paul E. McKenney Ricardo Ribalda Samuel Mendoza-Jonas Sasha Levin Shiwei Cui Shuah Khan Simon Horman Sudip Mukherjee Yasushi SHOJI Yasushi SHOJI jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-i386-qemuu-rhel6hvm-intel broken broken-job test-amd64-i386-xl-qemuu-ws16-amd64 broken broken-job test-amd64-amd64-xl-qemut-debianhvm-amd64 broken broken-job test-amd64-amd64-xl-credit2 broken broken-job test-armhf-armhf-xl-credit1 broken Not pushing. (No revision log; it would be 410 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Jan 02 23:10:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 Jan 2023 23:10:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470460.729977 (Exim 4.92) (envelope-from ) id 1pCTwy-0000RN-8S; Mon, 02 Jan 2023 23:10:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470460.729977; Mon, 02 Jan 2023 23:10:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCTwy-0000RG-5q; Mon, 02 Jan 2023 23:10:36 +0000 Received: by outflank-mailman (input) for mailman id 470460; Mon, 02 Jan 2023 23:10:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCTww-0000RA-6X for xen-devel@lists.xenproject.org; Mon, 02 Jan 2023 23:10:34 +0000 Received: from sonic301-22.consmr.mail.gq1.yahoo.com (sonic301-22.consmr.mail.gq1.yahoo.com [98.137.64.148]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a5e65120-8af2-11ed-b8d0-410ff93cb8f0; Tue, 03 Jan 2023 00:10:30 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.gq1.yahoo.com with HTTP; Mon, 2 Jan 2023 23:10:28 +0000 Received: by hermes--production-ne1-7b69748c4d-nmpxj (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 963445cead58a3588ed1e45bff7a73fd; Mon, 02 Jan 2023 23:10:26 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a5e65120-8af2-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1672701028; bh=/P05T3kVETVy1VB1C0TuUxelNF1OaAvo1evjneqVCMU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=b+7pSiRSKew1q/VPQv7CaT+qZJBnZDTW0heVp++EhRpqK28AT8nCreJ1suIBVTu8czSCsrLd0J8HeGVXCkAm+qwrtyL6z7Wofh3s8WCEF5HmL+hNbei0cRKDfJ+1Mi2sHZAB8nTjJvZeMoLbU4UbMTWIzO7IaSeOaux+s8z68M/mWxb5r9iNLWuObrpDqtFqysnD2hWdkrr+gPQ09fmfQVUPpPbUSVJeOhiQDkqYozN1wXi3f3ue3diupb+CjWstFYm6/jUoxY1E4ONDpkNAWviJZXaraqlNZDDZyuDXMYEApuclr/ylcwj1j3L83zzLtpfckMp4VI5fzbcnUSfOlg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1672701028; bh=F7PED5wr9QAQjEahtUrLzVLgsgKiEXXeUwZjmBCgO8h=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=hCWIKrqN02NpKGle9G/IhBUWXwXGugj+Mihg4GftI73UNwJ830+EqA7FUaQ6zDplxk+SuyhFaORHG6dlzkw0VoEBsNCBecY6pS4T83d7jWWHlOInItZZsyK0J946nuJnlXZbCnbk89HnkhENvOxJMbOVL94xe+DUKk1I+g5E0mS+QwJRiAh4BHIl0lvxtIRfeUcFL4Z/pMqB2awTOjTo89BJSVUxbxBrrxpeQVBpTQCYCFWG/TSu3Lvzk74W7vhNJoeDSQ67fRgv2MoO3GTO2cWQp++13/3eSFexcL2I3pOO0TGCGz4FtSl22Yqu5ulegU85QqacmrdXz6gTL9+3Bw== X-YMail-OSG: F0I5ySsVM1nusXZyF.Cjxyr_dddCC3_SHHp9I0IS_eTCEfOog1xA2ISVyCSMLbc 5VRYLDj_3mzgO8dRLirYUu2nS01PUG_JplqrUMOMPNF7e3bvDoVgHO3H.d1KJ72CCMnzYJLDh0ys eMxO0NLUau7PzXigqidVCjhA1KMijX8fdUUxtXRCHK1.o6vTN02ZeY1MgwnGrN1yt6eiIburoQUR dn34Z9huL4PFLyQvWed_bmIcSq5Pic1ckBjNdPNXgcDy9eZ_Swx6ssyobjhMkh6T.06IG8aK_kb5 B0uMGExA6v43Brfpx_vexlWAmS0H92rtrLaBZhkI8qB3f6aCe7q9ggSxXSNrlSDhYI7taWIkMsaw IpZD0VqdMmg0J_54fPzLLVawZj.cS.3H89cx0miEspQkucSyt8_l1adqlj6ZLRuDJnrcDXpb8D_W pHFgK3f.rOhMObixVVYhqz.fLnCyQt.mfoXvDCsmvOfyUXv9zyTS3QbbpqXdO4gTcmkUnMd0VCwZ dtTq2e6gq6nJ3TwsncW7LtgAf2GIIAUoGqqLFiOsM5378IgCtP30lJg_9cuOtgurm4CcgRdGlJ8S X9wfAqyjeETrhOscYIco8f0w.Z1y3vxZc7v3qWbsuqvJXE7IfuUeu6AzTBoE3ithGMohcy0IOESz 8TF448t36ws5WMi6BtHbFGUHzjVtFnVrSVYYNRHWAZYkbx2h64K3tu.PqEyqRD0saZX7fI.i6v1K xNFupaLtOXvGoXDE.1ljGFrV26N04vo5P9sy1ClyNCVtofYD78xvM1K6OLfCXYiCLatWjRFi9_YX do3nyojH4gKoWPbG_RSAgyQB3L.a5rVN1gPBWDZoBd404mZvPJIROUrBUPEln7X0TuriY_bCpCBm lWgg2lX3Q0yBQFKUPczm.wYddPE_Jr5KC1jWOZW2mnQ8JoVEfP48ZdmUEHC9kVxux7yBbGbrpKiQ xVhOOOAEA4Kq32tlVfU.ZbFWWhiALU4C9Ebpjq.AdqI0et7K3YnzLG54EPGg.eRhXk.nqT4PaYaS eet.7h81VK2HIJAq7I8JOBTKFxJCgFPJTdAtPkRp7R3_1XKc3MT.9WFWKtvScgEBwO4z7bnABvgf oYN1XRc27xvVQbypSpD6ht_.l2BXSRj_8IpiHs1reejifFvafFLQi8qmp9k9JJN8aV8WvB6Q64ng Q7_3kGCuBwZQqgnonLMnkx3PYFVnO.EhUz6CnQoCb2SDE_U9or4BPEOwkuR7wGRcaWefQP16k4YV AwZQGTnEVgUNT5Q9BtBH5rcuxpH4wkD2XF._WSZjrO3cPsVviErG9OWr9knokD9yk5zlj55Hsfej mHvV39e2A7c.S2wDF2cRGl_nlQhYx2KIT_hefC5kptfo.qFFsaCz5LtUREyKx0bPxrKzzRe5pybk iu1F9mHYxro5sThCP78jA35LzURGA0PI05zAcx5FlqGtKYS6HK5iXda41O6n7uK8_UBzkheLBF7m Or3rqLS3J9MLggLVxUWbEINBLUXI6YGDiqebvmAD6HL3u_L9xFPLQFVh8Urk10hz.IL4_m9ib5eW xlePTrby0DpUD4Kc6IkcZ_G0aPZb45hwK491MT1XDv95CzfPEjQeLkXrlv_19MjP8d3nw5zBYeR5 wp8KfV3NDryVIqkaSSW60d_hyPNrLaWxJxyydZBK2MqAV872EWJ5qhJuiJZtCecsU4_uaCpwHgds ErQcgFQ78Gna4sEac833bxjbxKFLbmM3Nw458rfNgJmaKrfbU9v0xBlGdsF5kyAG.pjgw15ZsWxZ 5lf5vBQUj3EAhgkvbVKEm.x5xqMfmVBlfPGWTaUcSWyLA.5ndvuVpDNcmLJro7PYCJ.iYbgNT20i 5jort5ktFigPIbreTXRvdFNqzsyvBhd0.Xs0EiRo9CEqJxg33aYemvy9_wK9ZfR8G26I9pbQTxLD Ewka.Oit1t.lagGwFkKNeLVsQMSA9dCNdJDUzZQ7XFYDiVWjUXVCvNlxypWq_asUVuyv5CfRkR3T gQy8.KphKCYdeuSdcH2hnYpVQ_ew3HKRSk5mvAYB0fK6hiP1HdCGlhqCZt4C4KPvraQnN0givVph lyg6XfmGZhXuuAmYSYJtbR7d_6lFMdcHKeelBqakhQupObVeCZwbFPdtGt1bX1aGKC5dWYv4JnjJ dw2Q41jP26DsiXH1ZqA0eUPcrNmXYRBZaDi_IbULyosecKqvefQZ2jHL.lQjD_xw3feieNMBolGX WpISfWsRX8OGlKYXC X-Sonic-MF: Message-ID: Date: Mon, 2 Jan 2023 18:10:24 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v6] xen/pt: reserve PCI slot 2 for Intel igd-passthru Content-Language: en-US To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org, Stefano Stabellini , Anthony Perard , Paul Durrant , Paolo Bonzini , Richard Henderson , Eduardo Habkost , Marcel Apfelbaum , xen-devel@lists.xenproject.org, alex.williamson@redhat.com References: <830263507e8f1a24a94f81909d5102c4b204e938.1672615492.git.brchuckz.ref@aol.com> <830263507e8f1a24a94f81909d5102c4b204e938.1672615492.git.brchuckz@aol.com> <20230102124605-mutt-send-email-mst@kernel.org> From: Chuck Zmudzinski In-Reply-To: <20230102124605-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailer: WebService/1.1.20982 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 4657 On 1/2/23 12:46 PM, Michael S. Tsirkin wrote: > On Sun, Jan 01, 2023 at 06:52:03PM -0500, Chuck Zmudzinski wrote: > > Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, > > as noted in docs/igd-assign.txt in the Qemu source code. > > > > Currently, when the xl toolstack is used to configure a Xen HVM guest with > > Intel IGD passthrough to the guest with the Qemu upstream device model, > > a Qemu emulated PCI device will occupy slot 2 and the Intel IGD will occupy > > a different slot. This problem often prevents the guest from booting. > > > > The only available workaround is not good: Configure Xen HVM guests to use > > the old and no longer maintained Qemu traditional device model available > > from xenbits.xen.org which does reserve slot 2 for the Intel IGD. > > > > To implement this feature in the Qemu upstream device model for Xen HVM > > guests, introduce the following new functions, types, and macros: > > > > * XEN_PT_DEVICE_CLASS declaration, based on the existing TYPE_XEN_PT_DEVICE > > * XEN_PT_DEVICE_GET_CLASS macro helper function for XEN_PT_DEVICE_CLASS > > * typedef XenPTQdevRealize function pointer > > * XEN_PCI_IGD_SLOT_MASK, the value of slot_reserved_mask to reserve slot 2 > > * xen_igd_reserve_slot and xen_igd_clear_slot functions > > > > The new xen_igd_reserve_slot function uses the existing slot_reserved_mask > > member of PCIBus to reserve PCI slot 2 for Xen HVM guests configured using > > the xl toolstack with the gfx_passthru option enabled, which sets the > > igd-passthru=on option to Qemu for the Xen HVM machine type. > > > > The new xen_igd_reserve_slot function also needs to be implemented in > > hw/xen/xen_pt_stub.c to prevent FTBFS during the link stage for the case > > when Qemu is configured with --enable-xen and --disable-xen-pci-passthrough, > > in which case it does nothing. > > > > The new xen_igd_clear_slot function overrides qdev->realize of the parent > > PCI device class to enable the Intel IGD to occupy slot 2 on the PCI bus > > since slot 2 was reserved by xen_igd_reserve_slot when the PCI bus was > > created in hw/i386/pc_piix.c for the case when igd-passthru=on. > > > > Move the call to xen_host_pci_device_get, and the associated error > > handling, from xen_pt_realize to the new xen_igd_clear_slot function to > > initialize the device class and vendor values which enables the checks for > > the Intel IGD to succeed. The verification that the host device is an > > Intel IGD to be passed through is done by checking the domain, bus, slot, > > and function values as well as by checking that gfx_passthru is enabled, > > the device class is VGA, and the device vendor in Intel. > > > > Signed-off-by: Chuck Zmudzinski > > I'm not sure why is the issue xen specific. Can you explain? > Doesn't it affect kvm too? Recall from docs/igd-assign.txt that there are two modes for igd passthrough: legacy and upt, and the igd needs to be at slot 2 only when using legacy mode which gives one single guest exclusive access to the Intel igd. It's only xen specific insofar as xen does not have support for the upt mode so xen must use legacy mode which requires the igd to be at slot 2. I am not an expert with kvm, but if I understand correctly, with kvm one can use the upt mode with the Intel i915 kvmgt kernel module and in that case the guest will see a virtual Intel gpu that can be at any arbitrary slot when using kvmgt, and also, in that case, more than one guest can access the igd through the kvmgt kernel module. Again, I am not an expert and do not have as much experience with kvm, but if I understand correctly it is possible to use the legacy mode with kvm and I think you are correct that if one uses kvm in legacy mode and without using the Intel i915 kvmgt kernel module, then it would be necessary to reserve slot 2 for the igd on kvm. Your question makes me curious, and I have not been able to determine if anyone has tried igd passthrough using legacy mode on kvm with recent versions of linux and qemu. I will try reproducing the problem on kvm in legacy mode with current versions of linux and qemu and report my findings. With kvm, there might be enough flexibility to specify the slot number for every pci device in the guest. Such a capability is not available using the xenlight toolstack for managing xen guests, so I have been using this patch to ensure that the Intel igd is at slot 2 with xen guests created by the xenlight toolstack. The patch as is will only fix the problem on xen, so if the problem exists on kvm also, I agree that the patch should be modified to also fix it on kvm. Chuck From xen-devel-bounces@lists.xenproject.org Tue Jan 03 03:15:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 Jan 2023 03:15:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470472.729988 (Exim 4.92) (envelope-from ) id 1pCXlr-00011d-6m; Tue, 03 Jan 2023 03:15:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470472.729988; Tue, 03 Jan 2023 03:15:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCXlr-00011V-1J; Tue, 03 Jan 2023 03:15:23 +0000 Received: by outflank-mailman (input) for mailman id 470472; Tue, 03 Jan 2023 03:15:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCXlq-00011P-1M for xen-devel@lists.xenproject.org; Tue, 03 Jan 2023 03:15:22 +0000 Received: from sonic310-22.consmr.mail.gq1.yahoo.com (sonic310-22.consmr.mail.gq1.yahoo.com [98.137.69.148]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d84929b4-8b14-11ed-91b6-6bf2151ebd3b; Tue, 03 Jan 2023 04:15:20 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.gq1.yahoo.com with HTTP; Tue, 3 Jan 2023 03:15:15 +0000 Received: by hermes--production-ne1-7b69748c4d-8kjnk (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID a4e7c13e8efaf23c69e74dbbd036ec23; Tue, 03 Jan 2023 03:15:09 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d84929b4-8b14-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1672715715; bh=mUvEtjv/I8yLh91vV87I0a3FTB0JyYixbRRmZITWn+U=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=Rszazt7e+Bzxyiv4od/qkS3bXTWNb/x02M884X0I00UJRm8xuIFfAhFKBVAlLdSqEqSXZsjFWsuSwCWHgZO2Zqmq0C3v6YfbR/OanmRrYcTIMM55BhpdsXpFxDvjp3RuhLnZF85P5Lx6nO4R3AvpF7rMynXKT6RLCKEtYr5qLo8WLwFZpDkXfTpfinnGHIpl8GsiOmZQkDE2sxiN8Lvbkr/y+Y4mS1h4iw8bov6tANc8v3+sRRlI9YXCJxTn8Ip4DetYzW4fiKwIy8yT/LO/ZeVCgEVvUBM5/cYANcrBvJZb/mFtih5QF6JzpOmsbyHbMfiQIOEcpO7HlQ08pl0u1A== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1672715715; bh=lYJfJoQuxGxXFN6h0u7dbEyN70Bc3LSevVyoVriBqCD=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=sehfmdw8c2IZH7yxVsapPdyC5oZk8E9C8HG+RZlHweyTRT01NJXlGl1iSkBcdmKNSAvEE/1ffIB0aIHVFuf766DnCOnlbVQZPa40CKhW6Ej8xZHlok+XK5Wh3Etcf4lOTUMQlIsHpDym9nK6BCeIOhX70DK+orIkPdY1Fx82vY+fCRzaFzX/Jvz4D5y+Xc+mwvKd/3PP89Dnsp948+ybPy2HtCV0WJGsX8ARvxzpCrseLx3nHig1Kg898sWGib66rqMseYrfb5GQrzI5ew4OWat4mBItgYYoBggl3G40JmfQaWF/hk3KcR0HNcxqF8eKDhfZ/IJY2h2wWBrkkiOK2Q== X-YMail-OSG: lCVByNUVM1n9wslqYSg4OXTvsdTRZ9_iuMTmzMW9dTREhHpL_UOylw05Cz7exkl Z5ljYFmVFCILlOFzUUr52ffQahGqKRKFSW_e.1IxBKheaSe..uR.mCsgd4Zzwbmj.gFsBav0HFj. dKStrESxn_aXF8JxMNE1d8Wxhsdmu8VENtmyq6g6T_Z88.RsjV8B9cXf..gvYgzqskiCNfPyrWgd GTGH_JGI0ZeVIiczSvmIrZnEc.2enwHsdFntOagaU3KPKalav98xS6M36QDnT20djOsRM.Ggt19H njBeoFSAXTGwE6yrODnAH6DcHRz0HUa_It3aQwqQ30GBhxHPktU5jHnjJUMXIlOUeOUdfy3_1TlW LR09f.yR1smbw8x7B.k02yzzO..7FQ_NZDfberb74CivbkqvqznI3CQUVcbGnOWhcmqss7kBu3S. 2bCyKfPJIJw4etb9dv3sp.88kg2QORspv3HQ_Aln_cHonT0XT9yk8bzhQ2rOU5SOCFQMoZGgC_PE 3CR_mAgs1_5g0qSd4ldP3Q3bj0NRcPy.n115m52vgTaghoM5GUKEbR9mvhK8BraD0ifqnrFL_kz. XCYPbCdMSM2DO2mOVDyRySzh4PLDLr7a07LXhmdHhOgSiK45BmqAvWcOOeRc.4VT0TAd79kqfU5. IcziZdxEcHsasp8rapBpIGkJ.GZAkGVhejkDvr16X4ceNSvIIhmoAWPzIZQtmDlmbeP9lXCvE4Pv CxqJHTIe1ocQoQbjhQ.jeIJcPyFNBXOVpiHeV4rVHLSIJjRzWJ8OZy.4SbiILz35xcATpdRLkOvZ Bxj9p81S.HztznklXUHBuYjFPg3RaEI_bWETggJ8OEnOgRdJhFh2ZvfVFJV9d7MzvYXdjmhPlfjJ 655osScA4NmCcn9YBEFecN82TIKxFTnzFh_fJwjPZrkNsiOcF_oHp_a7_he4OxcDXZ9Dk0s9oRHb 1DfyjPX7.qCSc7kK9bEE.ckWXkQE9JxHYFsPBzrL8PDgnTLB3Oq.1WRxeloHpPirqi_UkAUB7oO9 FwHrcew9dluUAKfNnhG_8.utzChEsv2jhocIU5cyu6.C8qsGOZKKSU0j5ctTtJKnvH_iV9aW2j9Y ijOu4CK_B2KEYCyHp1AqekyWvvKRbpgEQsD6aUkA_hX.hhaS14H5FgNID20.DXw1dRiHys2cKBiu _2iluXRh_Xwuw1yumac92P3.TSNgfj6sPnMTg.tSKHYOJB.48WjdgHEk4OMTXh9W_FotUqHzPMng KdFKoV8s7yxGnC5BNlhKugrbvJhqrhpTV5skZBG.tR54LjQ.O8HbwHNE33p4fBIy.ctdRXVlyykr pyXmz4bn377tu0Pd2Te53a.MK72k6R.QYv7vwGDoxsQWDuwU6kQIPAOCb2gOyADp7Lr76eVN6Q9O ZvsVjbUw1qLUAHGZDa1.SISq47XkkBGKEP6c0_6ssR8DTBx84xxt8miA8WS_9ub.LxLjmQq6HT5L yDK8ljvXxbS5PpM1AOU.CMDQ3dUrOINXyPYW4NcRlcbqTob3LwJ2BrShjvRFNjYVHWKpw_sLokX5 fWDVGxmfmZVkdZDBYtWJsNaOFcpviFO3cVu75eYRtwcHs8nvRNWW05zNEZ5PirJ3R3Y2QzuHt7n4 uDxgBxWMemJfV6s5zzH95.iVKZR5saoT1WBWJpwGjyqhgjkEA7mFSbfkbbYJD0T3XCZ.HFRO9WX5 fXtTXwOvXRvM3Dcj9tuq_2.Fs2hB3B5Vd1K0DCo6Cyp5rlpLC1zEA8S3Sk8wVDavi91C63GBCZj2 _gIwiN6RJrwvEZTetXmpyjB34RP9mRaoUsgEJsju.M288S4RdsTye_yXLGKpfqh7EvOLpzZlle.l Pv55CFZs3ch8jkYkYvOkmZO4RSmPQ8kwjVO6RzPDczr_JjzLYFm0dh3BAnmxpPC7qkV0lnkgki7. cwViyU4OCEfAOky1t4gr8fTVE2S_DAT_fatW4C_DH5XKrDevZ7q67pAw2LQZZUubwYhcc71BrgKI 0I4LWAplQzaZOUZNW8kU76eyEsYaacFsCEiNKQ2O_kU_uoZ0B89NoTzZRkIIO_RnrK6PUdTlrC9X r5lw7ebYBEk1eUDBfU6K9bDu6gvbhlz0bxGoo7PLgMlj7gB389sIKtgUYylENK.orwl7pd5jFLOF 6i.s13qkMAAQFHwDiUyk3O.xqoTFRFFuTYkrgW2HvQs92ylDoYy24Jvv8nBd8ExGljETdrUM5dqV tEqm5pDVYa7cAvIlC1Q_m78E- X-Sonic-MF: Message-ID: Date: Mon, 2 Jan 2023 22:15:04 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH 0/6] Resolve TYPE_PIIX3_XEN_DEVICE Content-Language: en-US To: Bernhard Beschow , qemu-devel@nongnu.org Cc: Paul Durrant , Marcel Apfelbaum , "Michael S. Tsirkin" , Stefano Stabellini , Anthony Perard , Aurelien Jarno , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Eduardo Habkost , xen-devel@lists.xenproject.org, =?UTF-8?Q?Herv=c3=a9_Poussineau?= , Paolo Bonzini , Richard Henderson References: <20230102213504.14646-1-shentey@gmail.com> From: Chuck Zmudzinski In-Reply-To: <20230102213504.14646-1-shentey@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.20982 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 1835 On 1/2/23 4:34 PM, Bernhard Beschow wrote: > This series first renders TYPE_PIIX3_XEN_DEVICE redundant and finally removes > it. The motivation is to 1/ decouple PIIX from Xen and 2/ to make Xen in the PC > machine agnostic to the precise southbridge being used. 2/ will become > particularily interesting once PIIX4 becomes usable in the PC machine, avoiding > the "Frankenstein" use of PIIX4_ACPI in PIIX3. > > Testing done: > None, because I don't know how to conduct this properly :( > > Based-on: <20221221170003.2929-1-shentey@gmail.com> > "[PATCH v4 00/30] Consolidate PIIX south bridges" > > Bernhard Beschow (6): > include/hw/xen/xen: Make xen_piix3_set_irq() generic and rename it > hw/isa/piix: Reuse piix3_realize() in piix3_xen_realize() > hw/isa/piix: Wire up Xen PCI IRQ handling outside of PIIX3 > hw/isa/piix: Avoid Xen-specific variant of piix_write_config() > hw/isa/piix: Resolve redundant k->config_write assignments > hw/isa/piix: Resolve redundant TYPE_PIIX3_XEN_DEVICE > > hw/i386/pc_piix.c | 34 ++++++++++++++++-- > hw/i386/xen/xen-hvm.c | 9 +++-- > hw/isa/piix.c | 66 +---------------------------------- This file does not exist on the Qemu master branch. But hw/isa/piix3.c and hw/isa/piix4.c do exist. I tried renaming it from piix.c to piix3.c in the patch, but the patch set still does not apply cleanly on my tree. Is this patch set re-based against something other than the current master Qemu branch? I have a system that is suitable for testing this patch set, but I need guidance on how to apply it to the Qemu source tree. Thanks, Chuck Zmudzinski > include/hw/southbridge/piix.h | 1 - > include/hw/xen/xen.h | 2 +- > stubs/xen-hw-stub.c | 2 +- > 6 files changed, 40 insertions(+), 74 deletions(-) > From xen-devel-bounces@lists.xenproject.org Tue Jan 03 05:50:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 Jan 2023 05:50:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470479.729999 (Exim 4.92) (envelope-from ) id 1pCaBQ-0007nn-1y; Tue, 03 Jan 2023 05:49:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470479.729999; Tue, 03 Jan 2023 05:49:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCaBP-0007ng-Ut; Tue, 03 Jan 2023 05:49:55 +0000 Received: by outflank-mailman (input) for mailman id 470479; Tue, 03 Jan 2023 05:49:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCaBO-0007nW-2J; Tue, 03 Jan 2023 05:49:54 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCaBN-0007RA-Vn; Tue, 03 Jan 2023 05:49:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCaBN-0004n1-FY; Tue, 03 Jan 2023 05:49:53 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pCaBN-0001rZ-DQ; Tue, 03 Jan 2023 05:49:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Tf1mkHv01cPgr10qPYZWIuf6QJRrCnwt08+WxRELxdI=; b=pkCEfslchEx543reFDb77Ren+p nXRtZzDKzs3S9EeeulzSFPb69R1WnJ1e7f2h5g1Uq0GBNfmoVMDX787rn72LfN+LolFr2XFIMq25V Fv7kwneZfy8b/FVJaMUk4SEHWyEDDP6YgFXH5IQX/xbAYFxCg1Kd0lfmgBYdK2fCqvH8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 175552: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=69b41ac87e4a664de78a395ff97166f0b2943210 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Tue, 03 Jan 2023 05:49:53 +0000 flight 175552 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/175552/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine 8 reboot fail REGR. vs. 173462 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux 69b41ac87e4a664de78a395ff97166f0b2943210 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 87 days Failing since 173470 2022-10-08 06:21:34 Z 86 days 180 attempts Testing same since 175552 2023-01-02 21:13:23 Z 0 days 1 attempts ------------------------------------------------------------ 3257 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 497265 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Jan 03 06:33:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 Jan 2023 06:33:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470488.730009 (Exim 4.92) (envelope-from ) id 1pCar6-0004WG-Am; Tue, 03 Jan 2023 06:33:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470488.730009; Tue, 03 Jan 2023 06:33:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCar6-0004W9-8D; Tue, 03 Jan 2023 06:33:00 +0000 Received: by outflank-mailman (input) for mailman id 470488; Tue, 03 Jan 2023 06:32:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCar4-0004Vz-Mg; Tue, 03 Jan 2023 06:32:58 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCar4-0008Rt-CQ; Tue, 03 Jan 2023 06:32:58 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCar3-0007Ti-Qs; Tue, 03 Jan 2023 06:32:57 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pCar3-0000kK-QL; Tue, 03 Jan 2023 06:32:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=FY67voJVR18X58zrC1O5tndNZGNUWeXoQ52VEUY4qac=; b=DUJcA3MN3TMUjvE0tUxZ3JQKg2 hxVMtirOZLD85s/sUsuLMJbCYSp8Xs50ihtCwjRGzdyAeRNsUi8CCn9M4ExqARBp+WN5Uf3Wal0Hg qvYaft0MtSGmoaM8Il4RELmrjiLY7/hr/5I89MIEmugviibn589nn2tWFWGg3COXFiBI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 175553: FAIL X-Osstest-Failures: linux-5.4:test-amd64-amd64-xl-qemut-debianhvm-amd64::broken:regression linux-5.4:test-amd64-i386-qemuu-rhel6hvm-intel::broken:regression linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64::broken:regression linux-5.4:test-amd64-amd64-xl-credit2::broken:regression linux-5.4:test-armhf-armhf-xl-credit1::broken:regression linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:host-install(5):broken:heisenbug linux-5.4:test-amd64-i386-qemuu-rhel6hvm-intel:host-install(5):broken:heisenbug linux-5.4:test-amd64-amd64-xl-credit2:host-install(5):broken:heisenbug linux-5.4:test-amd64-amd64-xl-qemut-debianhvm-amd64:host-install(5):broken:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:host-install(5):broken:heisenbug linux-5.4:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug linux-5.4:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-amd64-i386-xl-vhd:guest-start.2:fail:heisenbug linux-5.4:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-amd64-i386-libvirt-raw:xen-install:fail:heisenbug linux-5.4:test-armhf-armhf-xl:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:heisenbug linux-5.4:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:heisenbug linux-5.4:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-xl-arndale:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=851c2b5fb7936d54e1147f76f88e2675f9f82b52 X-Osstest-Versions-That: linux=66bb2e2b24ce52819a7070d3a3255726cb946b69 From: osstest service owner Date: Tue, 03 Jan 2023 06:32:57 +0000 flight 175553 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/175553/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-debianhvm-amd64 broken in 175407 test-amd64-i386-qemuu-rhel6hvm-intel broken in 175407 test-amd64-i386-xl-qemuu-ws16-amd64 broken in 175407 test-amd64-amd64-xl-credit2 broken in 175407 test-armhf-armhf-xl-credit1 broken in 175547 Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-ws16-amd64 5 host-install(5) broken in 175407 pass in 175553 test-amd64-i386-qemuu-rhel6hvm-intel 5 host-install(5) broken in 175407 pass in 175553 test-amd64-amd64-xl-credit2 5 host-install(5) broken in 175407 pass in 175553 test-amd64-amd64-xl-qemut-debianhvm-amd64 5 host-install(5) broken in 175407 pass in 175553 test-armhf-armhf-xl-credit1 5 host-install(5) broken in 175547 pass in 175553 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail in 175545 pass in 175553 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail in 175545 pass in 175553 test-amd64-i386-xl-vhd 22 guest-start.2 fail in 175547 pass in 175545 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail in 175547 pass in 175553 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail in 175549 pass in 175407 test-amd64-i386-libvirt-raw 7 xen-install fail in 175549 pass in 175553 test-armhf-armhf-xl 18 guest-start/debian.repeat fail in 175549 pass in 175553 test-armhf-armhf-xl-credit2 14 guest-start fail pass in 175547 test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail pass in 175547 test-armhf-armhf-xl-credit1 14 guest-start fail pass in 175549 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 175551 test-armhf-armhf-xl-multivcpu 14 guest-start fail pass in 175551 test-armhf-armhf-xl-vhd 17 guest-start/debian.repeat fail pass in 175551 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-arndale 18 guest-start/debian.repeat fail blocked in 175197 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail blocked in 175197 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail in 175407 like 175197 test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 175407 never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 175407 never pass test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail in 175547 like 175197 test-armhf-armhf-xl-credit1 15 migrate-support-check fail in 175549 never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail in 175549 never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail in 175549 never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail in 175549 never pass test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail in 175551 like 175197 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 175197 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 175197 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175197 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 175197 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175197 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175197 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 175197 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 175197 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 175197 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 175197 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 175197 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175197 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 3 hosts-allocate starved in 175547 n/a version targeted for testing: linux 851c2b5fb7936d54e1147f76f88e2675f9f82b52 baseline version: linux 66bb2e2b24ce52819a7070d3a3255726cb946b69 Last test of basis 175197 2022-12-14 10:43:17 Z 19 days Testing same since 175407 2022-12-19 11:42:26 Z 14 days 36 attempts ------------------------------------------------------------ People who touched revisions under test: Alexei Starovoitov Andrew Morton Baolin Wang Charles Keepax Florian Fainelli Greg Kroah-Hartman Guenter Roeck Heiko Schocher Hulk Robot Jakub Kicinski Jialiang Wang Jon Hunter Linus Walleij Linux Kernel Functional Testing Lorenzo Colitti Maciej Żenczykowski Marc Kleine-Budde Mark Brown Ming Lei Paul E. McKenney Ricardo Ribalda Samuel Mendoza-Jonas Sasha Levin Shiwei Cui Shuah Khan Simon Horman Sudip Mukherjee Yasushi SHOJI Yasushi SHOJI jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd fail test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-xl-qemut-debianhvm-amd64 broken broken-job test-amd64-i386-qemuu-rhel6hvm-intel broken broken-job test-amd64-i386-xl-qemuu-ws16-amd64 broken broken-job test-amd64-amd64-xl-credit2 broken broken-job test-armhf-armhf-xl-credit1 broken Not pushing. (No revision log; it would be 410 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Jan 03 09:22:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 Jan 2023 09:22:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470503.730021 (Exim 4.92) (envelope-from ) id 1pCdUO-0004im-P6; Tue, 03 Jan 2023 09:21:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470503.730021; Tue, 03 Jan 2023 09:21:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCdUO-0004if-MF; Tue, 03 Jan 2023 09:21:44 +0000 Received: by outflank-mailman (input) for mailman id 470503; Tue, 03 Jan 2023 09:21:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCdUN-0004iZ-Cx for xen-devel@lists.xenproject.org; Tue, 03 Jan 2023 09:21:43 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2057.outbound.protection.outlook.com [40.107.237.57]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 07aebe6f-8b48-11ed-91b6-6bf2151ebd3b; Tue, 03 Jan 2023 10:21:41 +0100 (CET) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by MN0PR12MB6150.namprd12.prod.outlook.com (2603:10b6:208:3c6::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Tue, 3 Jan 2023 09:21:38 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::9856:da7:1ff1:d55c]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::9856:da7:1ff1:d55c%5]) with mapi id 15.20.5944.019; Tue, 3 Jan 2023 09:21:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 07aebe6f-8b48-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L57P4pEsXqa97kttUkByOOOjc/CDl82noJeBFXsgziCBWwbh9BOXZduzWcgBZ+xjMzVSfsU6GWD3p1od5MiW6AmrleEkd3b4SI9y8s2rJCLb/FPVjMs6aJnpEoqnz9B0Y9NSJdJuaThDiQB6pNRdtN8fSgZCyNiprBK4rxhLYJF/YEIrxbky4U0Yx7xHYAKli7YjFw/K/wMDAvcshizyKw5DvuRKC4ndDzuKNEfR7AFPI5zuQtwTKCmtXRZD7RXroWDeXxSYxSTj/olS4E4SrP3Wm0ahBRodY78uQ4KaB9rXURY7AmLbtN18XX2ihSrc9bEkjTUp4ZagraymAf+qJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7qkI29jLQQRBYRidEwFXmAcmunYaTX4OpV8a84XMPHA=; b=BqqAfsyEMXTP/CABtrHwV5l0aYPGaBDwebePedHap8DFQHHtm+TKh5xJ6sfSKpHbDQ/TfxAIPmBZy4645Eeur0OPb0E87eHSF5s1HCZukb4ndm2OA1TzaEE0VMcC/mF3nPnbgniz40OVtQZUzmdcl7m1eH8BtSKJgiZt64zOPDnInFS33akbTp+Bj7oTcxpYn7wLUeNG06ZbKqV2n4cCSqtiMMLkMGaIObpKpo8vr6UirX7YGUn/T+C9GbRFUyrTZej/3JqnMGIP+7PVOcacPlWfJJH2sZ8SOA8TvFUCzO9bvLZZZBwM8h5OvFTYXyhzg55cvMU8Sdci7PcuR1mGIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7qkI29jLQQRBYRidEwFXmAcmunYaTX4OpV8a84XMPHA=; b=Q2WrKf98MKoFUNBXEDLn4CfYpbVfduh51k6u1T4MY2mez+vd5MpknQ4xfSdmtUR/qdg2/Y9jJSmv/SzpSPLhGM4b9ZSvPz6+csq9EenDN+mzPcFhxviNmQ7jZDA6BsqaCANMJEws7etOKqR7zV3DybHkJN9fkdZVEWZ6GoNvctA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <2ddcaf95-03f5-81fb-3091-316b99201a1c@amd.com> Date: Tue, 3 Jan 2023 09:21:33 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] xen/arm: Print memory size in decimal in construct_domU To: xen-devel@lists.xenproject.org References: <20230102144904.17619-1-michal.orzel@amd.com> From: Ayan Kumar Halder In-Reply-To: <20230102144904.17619-1-michal.orzel@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0077.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:190::10) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|MN0PR12MB6150:EE_ X-MS-Office365-Filtering-Correlation-Id: 7a872c1d-6783-4b2b-95c8-08daed6bea8d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nIfBgkVcm5u9+UfjzBEvvfjZ6Pjkz57arRg7sJz2j2QdjO6FmI/RHkDcwIaIMZ7IGgxHLn/GyXFQu+oif42H7G3gMCA2Qi60dJ9QbmflfWOnB3PzuL5+Ua0McJNTaERiEH3t+yWApe/CBYaEDi0ZNsnkLcFlTD7sOV/TTym6+Kq6UvIijNxGpUsiSmPpAMXyBuYV0ah18Z7DlfUUMXGQNLc9gjbhQCDGSCHC8NOdZMH8USLiH1DKw9WXTAJ15CVNZy1rjaGtNhOZ8ATiBqCOXlD0MGjnVcA2mOVPHTsBQ5UIHrmJCqh291Fr5oMHTZNNmeUMgc56SwDvz/Chv1V/tXg8ZypK3w10xNLAnTgfoos2mXVNqt6ewt9EcdkoJgxRxw6G1U0c8T0b3AulWezaf5v2bz6tfg3zqEcLy5vm+zowcteacUKpGeVGuaDLN1/k5vfYp6SSYfjNylXmQeAFvS9a/e/pXg0FOdLbjSpdZENKFjddHxJGreif3ukoWPckckFdwRBRYTH1zsZQRGxHFS89sZc63OOX5u2DVN+L09aXPWh/KDZHKUziumWCvclpPW0JLAJcJHdrGTtlobq8+SlLEGtDmjmKCkPeBk3DAzbt8pFfPnA6l78HkIT8e3mhk+BXqe0Oi0QVDqHgcQ1ODmG3YW1KzYUNZzkbJ1ncxkXIjqlZt9N7h+t2vKsAPNe3Ra+CbkCED9VaznxEoxPqBeISKRGCI3QFym6308rOj0HV7mKr5tWaqRsZdjtNyrZO X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(136003)(376002)(39860400002)(346002)(396003)(451199015)(36756003)(38100700002)(2906002)(8936002)(5660300002)(41300700001)(83380400001)(31696002)(66476007)(66946007)(6486002)(6916009)(31686004)(66556008)(6666004)(53546011)(478600001)(6506007)(8676002)(2616005)(186003)(6512007)(316002)(26005)(22166006)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eWdTTStqZ2RvZ1ZEVUZVYjM2UHNIUnU2aklIQ0Z1YVhXTjF2MXJlanRQMzkr?= =?utf-8?B?eTB5QjZCTjZCRmIwc2xWM0Y1L3lIWjZ6SUR5M3p2eWdvZUVtMmduY01sMG53?= =?utf-8?B?QSs3S2puUFZBQTNFVzVoekFMTVpDTUJYVzR0ZFk1SGZLc0MwTU1STVdFcThQ?= =?utf-8?B?UTN4NWpYVE16RkpKUVczRlJIdHhySG9wUiszYmVrZGN3TVhzYjZmekJIV2Zo?= =?utf-8?B?MDZmcGdLQ3MvMWpKRHZtTUcwWkhWU1JuazJxVmJhc2srME4rTFI3eEc5UFVv?= =?utf-8?B?MC9oczBOVGZIcTdnaC9Nd3ViTFZxeXBjaWR3WTI1amJRVlVnZ2Jsb25ZZkF6?= =?utf-8?B?dVB6dlhkS1Rkd25Lb0d4TEFUZnpIczcvUVp3Q0hDaGFabXo0K3J6cFZRdE15?= =?utf-8?B?M2YyWUlhYUJrWk82ZkNkQU5kay9CVkcybEN0eGJuK24yeXFjclRzSWJaeWlR?= =?utf-8?B?RitZbE56Mk9leHBrOFpPdkhoVU05UGhxQjRJNi8rVzYyanovYXVIb2t3R2Js?= =?utf-8?B?VUtqOWZ4R1dSbC9hTStSSmtEbjdOaVlEQVpjZUZDSEtSWXAxMVh5aFlvVzlD?= =?utf-8?B?NWUyTzE2eHBMaDhZVC81Rm9ES29pV21sWThhb3U5dUNXVXlDYkdnMFIwZHhr?= =?utf-8?B?TVUwWjRBeWt0YnVOZC9sekpQR2FZWjEvQzNtSnNXaE9qM040ZmFSSXRCTllF?= =?utf-8?B?VE1SZis4NDZIMmNMMWFzV3VNQUN6TkhjR3p5ZFgvUXI0NUpUblZ1R0IwN0RX?= =?utf-8?B?RVV6LzFYTDIzZHZGbEtEbW41R1hJVmFPK1p3QUpIOFFKdTI3OXk0Z2N3QmJx?= =?utf-8?B?MXhsd0d3TmtPendrMTFlNW9yUmFkVmFmZWJ4dm9FZ01ma0M1amVsejRJTzEy?= =?utf-8?B?VlQyS0NEajdCZUhJei96dVlUNHNsZ0JHNXd1eGlrN3dZT3dnUFlORk1RYkZ4?= =?utf-8?B?MTFwNWpzT011dUxSdmUxOGYvc29DVlludk1DVU9icERlNHBuUnJoazE3dWZk?= =?utf-8?B?azJjR1JNOGxaMVRUdGM5V1FRakVQMGkrdHh4cUl2WkFadk5yK0VVcTRnYWxP?= =?utf-8?B?YWdZRi8wdFk1U0J1Y0dDN0VHdGRHQ0p2dVowZGdzdGZ1bVR3c1lvWVZza2Rv?= =?utf-8?B?V0VnZHcycWhOSWdKcUF0Q0NISDNlNTV2c29VaHI3Y2RrRTFlN2h5RXo0WEJ4?= =?utf-8?B?eWFjbTNLVk50NkFUeDZjQW5Ya2xTRW1sMisrQnp0WXNYMUtiOFE5RHhPaWRO?= =?utf-8?B?WS8wUzFPbDVDR3R1UVZqcm1PdERYMkduQWxJMU85VkQ3T2xXdXhxd3VDWW1o?= =?utf-8?B?K1dESXFNTWt5bVhYTzRzRVNDSDJjQlUzdS9TY2hKMk9STjRGaERQNDdqVCtp?= =?utf-8?B?SWhMbjBmUmJieDBxalQ4eWdGN01yL0o0Wkd6bkFYSHhESFI0ODcrUkV4MlhE?= =?utf-8?B?ODZDc3pUek5HM0RQRXRuWHN5LzFUTDNGalQ0KzlYRzRwZUpuMkZQUjQyamEr?= =?utf-8?B?dHU4Y1RJaDIwZFN4NE93V3E3ZzgyOG9mMDJ3dXlHNUNhbUUwL245WHl1NnNr?= =?utf-8?B?dVBvTHlCUk1nWWRqMUI2VkpZWmVNWDk3eEtVR2xBQ1NjL1YyMnowdi9vRlc5?= =?utf-8?B?MXJVQTc0U1gyVHlZWjhHRVdIY0FNVjJMTDEvZk1ETGFBdDlBRDhCeGE4bzUx?= =?utf-8?B?Zk84WmM4ZWg1bFpJNkJOcTFycktlRHNUVnBrdUN3cmVORUJjVUV6S2liamhx?= =?utf-8?B?ZWtrUE5FdUd0clZYZXdadFVwUnVNb3IrUXVxZlRnNk05N0pCa0VOeDJVOXlF?= =?utf-8?B?Wk9HTUFubEs2SmE2Q2IwYTdKRDBXUGNQaDE1bmFMdEpVejhqVmNVQXBuQ2pG?= =?utf-8?B?ZEk5bzFFd1J1R3ZIeXpMcHg3Wk1TSmJSSml3WGZxczF6eVQzd1A4b2VFUWpM?= =?utf-8?B?TWtLQ3RmRFJ5MlVyRTZTZ1FtUURhM1BDZ2NBaURXQk9tRkh5Y21xcDFWbFk4?= =?utf-8?B?NmpyMW1zQm9vNG1adytwVzR3cHNzanZRbmVDQnd4Wk4xb3VlWi81dkQxRGd3?= =?utf-8?B?UlJCamQ4MUc3czhSc1V5dElvV1VydHBHQks4WW9yc0JSWVI0a2RzRUtOa2FG?= =?utf-8?Q?bsQmZNpVQ7J9BOZNa1pLn968b?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7a872c1d-6783-4b2b-95c8-08daed6bea8d X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2023 09:21:38.0964 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: C7rTaYPMSVNb0g39rC0awRsPNMP4ookeqzoXF71+YIIV3/bySEy3HXxRRUoNBLTOqjSNLGKUPT6NmY0aqfFC4g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6150 Hi Michal, On 02/01/2023 14:49, Michal Orzel wrote: > Printing domain's memory size in hex without even prepending it > with 0x is not very useful and can be misleading. Switch to decimal > notation. > > Signed-off-by: Michal Orzel > --- > xen/arch/arm/domain_build.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 829cea8de84f..7e204372368c 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -3774,7 +3774,7 @@ static int __init construct_domU(struct domain *d, > if ( rc != 0 ) > return rc; > > - printk("*** LOADING DOMU cpus=%u memory=%"PRIx64"KB ***\n", d->max_vcpus, mem); > + printk("*** LOADING DOMU cpus=%u memory=%"PRIu64"KB ***\n", d->max_vcpus, mem); I will prefer it to be printed in hex format with 0x prefixed. The reason being the mem is obtained from device-tree domU's 'memory' prop where the values are in hex. It will help the user to debug easily without requiring the the person to manually calculate the hex equivalent and then trying to correlate it with what is written in dts. - Ayan > > kinfo.vpl011 = dt_property_read_bool(node, "vpl011"); > From xen-devel-bounces@lists.xenproject.org Tue Jan 03 09:39:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 Jan 2023 09:39:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470511.730032 (Exim 4.92) (envelope-from ) id 1pCdlu-0006L3-B6; Tue, 03 Jan 2023 09:39:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470511.730032; Tue, 03 Jan 2023 09:39:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCdlu-0006Kw-8D; Tue, 03 Jan 2023 09:39:50 +0000 Received: by outflank-mailman (input) for mailman id 470511; Tue, 03 Jan 2023 09:39:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCdlt-0006Kq-Cf for xen-devel@lists.xenproject.org; Tue, 03 Jan 2023 09:39:49 +0000 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on2074.outbound.protection.outlook.com [40.107.96.74]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 687222b4-8b4a-11ed-b8d0-410ff93cb8f0; Tue, 03 Jan 2023 10:38:42 +0100 (CET) Received: from BN7PR06CA0072.namprd06.prod.outlook.com (2603:10b6:408:34::49) by SN7PR12MB6862.namprd12.prod.outlook.com (2603:10b6:806:265::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Tue, 3 Jan 2023 09:39:42 +0000 Received: from BN8NAM11FT085.eop-nam11.prod.protection.outlook.com (2603:10b6:408:34:cafe::49) by BN7PR06CA0072.outlook.office365.com (2603:10b6:408:34::49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5966.19 via Frontend Transport; Tue, 3 Jan 2023 09:39:42 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT085.mail.protection.outlook.com (10.13.176.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5944.17 via Frontend Transport; Tue, 3 Jan 2023 09:39:42 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 3 Jan 2023 03:39:42 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 3 Jan 2023 01:39:41 -0800 Received: from [10.71.193.33] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 3 Jan 2023 03:39:41 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 687222b4-8b4a-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZbDtK9IN8dJyVC3JAft+EUdIKXjvw1pWdfjiTScHZYPs09NGXc4D8aJ5YCI4qOAoUg9EL2x4OEhE8CsG9kTYhh6xz3WOwQ7k263D4MYei7WkteBqNNSkZqAPrr/tz829tONYuYrdoV8hJgeAN/ahQUmCIWEUaf763T0l3oIFNMiK6BQ2++94wi14ffKsY9eAZp3gTp1UkWFyPW+3dLqzOboEJXmJraMTYPo/g92G2Bnoi3IeL/dI7w/eDCgoJVHs79r0rtCYEBQltGg6w60zCOhPhqfHZOWBTvdvOMlXt3tqZMcgXXWO2LhFLBZXyPMqnoZqzBU/cZjXlS6/4EgSSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c2ya0maJOkqbjYxQwcP9WS/1jwK67qwB1Qca1G3RDtk=; b=F6F11XGXRk69Tld0eJOrFiyWaWOEXOIK6UQnTP1QzEHJi7yQ4QNc/Zs489G1VNOEUN2pAKEzqGcHuMzGBmDKZTOTLbyXXvQ9q+52gwA5ex63hvERzB1PKLskX/HTgP9I8n4uKismrNQaJnhMAsX2KGcoWxsLTrPdH2BeJm6IGnGGz70Epn9a+0IDTlc0FzZM5VSgoutzvS1mvz0W0lGXHkm20x4FW0uYg5HSAn8PUPxgYZDSZyrznXEJnbfl/J2GTKmtLLUpxeqC0ufqQDXN1T82H3niroedVHXO8P8STpwWaW651FP/Jw0RvOMW6mmALUfUybxELJnFIlvMuLhA+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c2ya0maJOkqbjYxQwcP9WS/1jwK67qwB1Qca1G3RDtk=; b=KnP0mEITVSQ5oY11j3KQuwkwgnWejGpt+sTKzPu7dcD/gZ2XQuvAXJmVsP+5LCHn1rpD+mzoR9NnLT0st87XJEU1wdsanAYUzG/SX8hfzXr/ZlF1HU1jM4Apn1pRDk6+jUPHeM/q8x6bB0Ur0pIBMxhtmNHcOmRbFbo0R7QtXjU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <562770a6-2933-43b8-326f-3bb6d8e0ce61@amd.com> Date: Tue, 3 Jan 2023 10:39:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] xen/arm: Print memory size in decimal in construct_domU To: Ayan Kumar Halder , References: <20230102144904.17619-1-michal.orzel@amd.com> <2ddcaf95-03f5-81fb-3091-316b99201a1c@amd.com> Content-Language: en-US From: Michal Orzel In-Reply-To: <2ddcaf95-03f5-81fb-3091-316b99201a1c@amd.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT085:EE_|SN7PR12MB6862:EE_ X-MS-Office365-Filtering-Correlation-Id: 5c1305de-deb5-47ba-ab1b-08daed6e70f9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gD462IFkFzA3j870YILR/JGoo0/qrYGE9HS1pCVwXfmKCuxBFxf06d+/sNHC1l3iCRjO8h2+2KsnGSMp4CCJZfG8KpN9AuqyM3QzUYVyrwwsS3G2WcyZw17NsVQxKs8ytdZsTzgyIzdRgBpSvsta3SOsy/4FM3q8c1Dg/8CJG7nAszj+CKji32V9+gSVBYSqxG3oozjgSj0nJtXUNjg68w2AMpzitNd3xovbVFc7ae6optf9v3EFk8n2U3VQOACY+OuWuPyjfq56tEoSXZDWtyle8RW1Sd/VTb4Nv2yQXI7DE1Adff1taVVsaaWSJ0jVoySPeYqdkNxFYcNx2aZEQQ/OQDi7O2HvYBopaSXH9Syl8jrhQCsCZ1ac2EcyAFL2Ob0Axixy0vFCgIgoBkBJIoEEICtRnlsyDopQN6U4ecfD/av8UwH+5+DdoL5wg2ATmWPwhtYiM0z7tEASITjydQQRXkie7mWHgNfhC14Ia64bGJZNtZLt9V1DIdRghKOcZyqdv3WcONvUkF/kuZLvAU/9mfscoVXessWD+D1MuH5xXy12qYPnp6/r59xGeZQY3GHqCHkQqRW0HzZTfTGdVuY+tmgRLC5gorf6jsg9sYEIFgQOP/uJRV8GBgW+tXpwuZuMVEktyb8MrT83BNg8WBxH+sQGLmTXuvV2PlgD4ox45NxjA+hCcEwFr3X53krDxyUkvq2ZEDlS8g6RIt0/eWqSxY50BmhAicID22KFwZ6MERvQSjJys48Fqw1lil2JlvRq/W1ZMsxVQ+qucpP5lHQqQVSiLFyHEtMtsJ3aTzE= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(376002)(136003)(396003)(451199015)(46966006)(40470700004)(36840700001)(70586007)(44832011)(31686004)(5660300002)(316002)(41300700001)(16576012)(2906002)(8676002)(70206006)(8936002)(478600001)(36756003)(36860700001)(110136005)(82310400005)(53546011)(6666004)(2616005)(186003)(83380400001)(426003)(47076005)(336012)(31696002)(40480700001)(82740400003)(40460700003)(86362001)(26005)(81166007)(356005)(22166006)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2023 09:39:42.3473 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5c1305de-deb5-47ba-ab1b-08daed6e70f9 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT085.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6862 Hi Ayan, On 03/01/2023 10:21, Ayan Kumar Halder wrote: > > > Hi Michal, > > On 02/01/2023 14:49, Michal Orzel wrote: >> Printing domain's memory size in hex without even prepending it >> with 0x is not very useful and can be misleading. Switch to decimal >> notation. >> >> Signed-off-by: Michal Orzel >> --- >> xen/arch/arm/domain_build.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c >> index 829cea8de84f..7e204372368c 100644 >> --- a/xen/arch/arm/domain_build.c >> +++ b/xen/arch/arm/domain_build.c >> @@ -3774,7 +3774,7 @@ static int __init construct_domU(struct domain *d, >> if ( rc != 0 ) >> return rc; >> >> - printk("*** LOADING DOMU cpus=%u memory=%"PRIx64"KB ***\n", d->max_vcpus, mem); >> + printk("*** LOADING DOMU cpus=%u memory=%"PRIu64"KB ***\n", d->max_vcpus, mem); > > I will prefer it to be printed in hex format with 0x prefixed. The > reason being the mem is obtained from device-tree domU's 'memory' prop > where the values are in hex. No, I cannot agree. Refer to booting.txt documentation: "A 64-bit integer specifying the amount of kilobytes of RAM to allocate to the guest." Also note that in the provided examples, we are using the decimal values. All in all it does not matter the notation, you can provide e.g. "memory = 131072;" or "memory = 0x20000". I find it a bit odd to print e.g. 0x20000KB and decimal is easier to read. ~Michal From xen-devel-bounces@lists.xenproject.org Tue Jan 03 09:45:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 Jan 2023 09:45:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470518.730043 (Exim 4.92) (envelope-from ) id 1pCdqw-0007l1-V7; Tue, 03 Jan 2023 09:45:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470518.730043; Tue, 03 Jan 2023 09:45:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCdqw-0007ku-Rb; Tue, 03 Jan 2023 09:45:02 +0000 Received: by outflank-mailman (input) for mailman id 470518; Tue, 03 Jan 2023 09:45:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCdqv-0007ko-Sq for xen-devel@lists.xenproject.org; Tue, 03 Jan 2023 09:45:01 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCdqv-0005MU-LU; Tue, 03 Jan 2023 09:45:01 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=[192.168.2.2]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pCdqv-0001LC-EP; Tue, 03 Jan 2023 09:45:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:To:Subject:MIME-Version:Date:Message-ID; bh=UNZIIxpcYI8SXohcSlee+JrQs+hB8zr/zTLdkwPGu6U=; b=vXxNb5bT7zMh005sKxH5BTj6ZP 8kqheebd0ivh1efYQKu5xfDyk0P1bsKqcrCzkQPB8WQwJpueVetAG4xwJlQ7tGX7iJqR0y9pxYnbF j7FgOItpEL6pyP0Twc2diHDfHX2nlkJBLN07qlu9No/doBiYWty62vW6zJM1J2vR9vgk=; Message-ID: <57a19b1b-7078-7653-978a-d4b72e564d1a@xen.org> Date: Tue, 3 Jan 2023 09:44:59 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] xen/arm: Print memory size in decimal in construct_domU To: Ayan Kumar Halder , xen-devel@lists.xenproject.org References: <20230102144904.17619-1-michal.orzel@amd.com> <2ddcaf95-03f5-81fb-3091-316b99201a1c@amd.com> Content-Language: en-US From: Julien Grall In-Reply-To: <2ddcaf95-03f5-81fb-3091-316b99201a1c@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Ayan, On 03/01/2023 09:21, Ayan Kumar Halder wrote: > On 02/01/2023 14:49, Michal Orzel wrote: >> Printing domain's memory size in hex without even prepending it >> with 0x is not very useful and can be misleading. Switch to decimal >> notation. >> >> Signed-off-by: Michal Orzel >> --- >>   xen/arch/arm/domain_build.c | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c >> index 829cea8de84f..7e204372368c 100644 >> --- a/xen/arch/arm/domain_build.c >> +++ b/xen/arch/arm/domain_build.c >> @@ -3774,7 +3774,7 @@ static int __init construct_domU(struct domain *d, >>       if ( rc != 0 ) >>           return rc; >> -    printk("*** LOADING DOMU cpus=%u memory=%"PRIx64"KB ***\n", >> d->max_vcpus, mem); >> +    printk("*** LOADING DOMU cpus=%u memory=%"PRIu64"KB ***\n", >> d->max_vcpus, mem); > > I will prefer it to be printed in hex format with 0x prefixed. The > reason being the mem is obtained from device-tree domU's 'memory' prop > where the values are in hex. > > It will help the user to debug easily without requiring the the person > to manually calculate the hex equivalent and then trying to correlate it > with what is written in dts. I am a bit confused with your reasoning. The value stored in the device-tree is a 64-bit value. This is then up to the consumer to decide whether the output provided is in hexadecimal or decimal. So are you saying that the tool dumping the device-tree will show the values in hexadecimal? If so, the argument is the same for the number of CPUs (you could have more than 15 vCPUs). So I think this argument to be used here. TBH, I am a bit split between using hexadecimal and decimal here. For smaller values, decimal is definitely easier to read but for larger one (i.e. GB), then the hexadecimal would help (it is easier to do the math). So I would leaning towards using hexadecimal for the memory (so adding the 0x). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Jan 03 09:56:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 Jan 2023 09:56:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470525.730054 (Exim 4.92) (envelope-from ) id 1pCe29-0000og-2D; Tue, 03 Jan 2023 09:56:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470525.730054; Tue, 03 Jan 2023 09:56:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCe28-0000oZ-UD; Tue, 03 Jan 2023 09:56:36 +0000 Received: by outflank-mailman (input) for mailman id 470525; Tue, 03 Jan 2023 09:56:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCe27-0000oS-66 for xen-devel@lists.xenproject.org; Tue, 03 Jan 2023 09:56:35 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCe27-0005kL-1z; Tue, 03 Jan 2023 09:56:35 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=[192.168.2.2]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pCe26-0001gu-R1; Tue, 03 Jan 2023 09:56:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:To:Subject:MIME-Version:Date:Message-ID; bh=Usdo28dg4bFOA1INrPO7hb0HNbXQ9TsZkQjhVBPS8YE=; b=yRG0WEh7qnNYMQLG7sr8ScIxSx /mL2DyiY9gxVe07H0G2xqSU0KSfRXymdEDKVDSZeBPkxMJ39E6qucOybjZby9x6rFiV/Kl/koKu6n 0HHDPUFuugImvhYg8Om2fp9j3/Xa5/8pqfNk+UBPn9x0WNK7ynfjraaapyGgUxDy2O/g=; Message-ID: Date: Tue, 3 Jan 2023 09:56:33 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] xen/arm: Print memory size in decimal in construct_domU Content-Language: en-US To: Michal Orzel , Ayan Kumar Halder , xen-devel@lists.xenproject.org References: <20230102144904.17619-1-michal.orzel@amd.com> <2ddcaf95-03f5-81fb-3091-316b99201a1c@amd.com> <562770a6-2933-43b8-326f-3bb6d8e0ce61@amd.com> From: Julien Grall In-Reply-To: <562770a6-2933-43b8-326f-3bb6d8e0ce61@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Michal, On 03/01/2023 09:39, Michal Orzel wrote: > On 03/01/2023 10:21, Ayan Kumar Halder wrote: >> >> >> Hi Michal, >> >> On 02/01/2023 14:49, Michal Orzel wrote: >>> Printing domain's memory size in hex without even prepending it >>> with 0x is not very useful and can be misleading. Switch to decimal >>> notation. >>> >>> Signed-off-by: Michal Orzel >>> --- >>> xen/arch/arm/domain_build.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c >>> index 829cea8de84f..7e204372368c 100644 >>> --- a/xen/arch/arm/domain_build.c >>> +++ b/xen/arch/arm/domain_build.c >>> @@ -3774,7 +3774,7 @@ static int __init construct_domU(struct domain *d, >>> if ( rc != 0 ) >>> return rc; >>> >>> - printk("*** LOADING DOMU cpus=%u memory=%"PRIx64"KB ***\n", d->max_vcpus, mem); >>> + printk("*** LOADING DOMU cpus=%u memory=%"PRIu64"KB ***\n", d->max_vcpus, mem); >> >> I will prefer it to be printed in hex format with 0x prefixed. The >> reason being the mem is obtained from device-tree domU's 'memory' prop >> where the values are in hex. > No, I cannot agree. Refer to booting.txt documentation: > "A 64-bit integer specifying the amount of kilobytes of RAM to allocate to the guest." > Also note that in the provided examples, we are using the decimal values. > All in all it does not matter the notation, you can provide e.g. "memory = 131072;" or "memory = 0x20000". > I find it a bit odd to print e.g. 0x20000KB and decimal is easier to read. By easier, do you mean you can easily figure out how much memory in GB/MB/KB you gave to the guest? If so, then I have to disagree. Without a calculator, I will find quicker the split. If you want to print in decimal, then I think we should split the amount in GB/MB/KB. Otherwise, we should stick in hexadecimal (so add 0x). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Jan 03 10:08:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 Jan 2023 10:08:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470533.730064 (Exim 4.92) (envelope-from ) id 1pCeDx-0002Pn-40; Tue, 03 Jan 2023 10:08:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470533.730064; Tue, 03 Jan 2023 10:08:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCeDx-0002Pg-1L; Tue, 03 Jan 2023 10:08:49 +0000 Received: by outflank-mailman (input) for mailman id 470533; Tue, 03 Jan 2023 10:08:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCeDw-0002Pa-0j for xen-devel@lists.xenproject.org; Tue, 03 Jan 2023 10:08:48 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2075.outbound.protection.outlook.com [40.107.92.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9b29dcfa-8b4e-11ed-b8d0-410ff93cb8f0; Tue, 03 Jan 2023 11:08:45 +0100 (CET) Received: from BN0PR04CA0186.namprd04.prod.outlook.com (2603:10b6:408:e9::11) by PH0PR12MB5608.namprd12.prod.outlook.com (2603:10b6:510:143::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Tue, 3 Jan 2023 10:08:42 +0000 Received: from BN8NAM11FT095.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e9:cafe::7e) by BN0PR04CA0186.outlook.office365.com (2603:10b6:408:e9::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5966.19 via Frontend Transport; Tue, 3 Jan 2023 10:08:42 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT095.mail.protection.outlook.com (10.13.176.206) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5944.17 via Frontend Transport; Tue, 3 Jan 2023 10:08:41 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 3 Jan 2023 04:08:40 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 3 Jan 2023 02:08:40 -0800 Received: from [10.71.193.33] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 3 Jan 2023 04:08:39 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9b29dcfa-8b4e-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KQlAG2TdtiaLrntgRqveCMe6JhTH4SsrbrdG2OFGTR0PnkcFEhX4hioMc5kqQd/MjniP5T5wjSNGL5gasNyfSulBdRzv9YTCgQAB0PeG2b/rNDxt6RvOuqg+oT622TFlKUFw+Mvf1QJq5ISZpFy3XJZ/Jqd9lMyOhdU6We4isuxdCUTho563wBqtFYYw/HN9o2/QPljt4J7yjdR/HLXcg8hC21EfmH6hS81/qvsubUOwfgh6bVMseYY12MaF5TQRDiP0JMSLpMmcTmRGbNO7MiNHfLM8JH5kwOTjBnVYBpK8z2tWH6Pe+DtyL2R6pHOU10BhpPn0vdj74OFEtJ+d/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IFbfQOi4RZr5UwQVShC5LQVMlBWdSbMPdaMTF/RdxIM=; b=aON696qhTVIuXYB3sZEhlUyLh5i+sltmNKN0TpC1P2HnZ7MlNVC1XZL5BlTZJTLcHV+gp7mlrIj31POmuV+EVPHRmQOopbk2UL3mw/7RG/gVGnN5ysffsAupo0nCfSJ7xQLq4DXwyHhtwDCbDJmxLVTcKOE45cFnxCAbOASiNYSMpn+huXQEorJj6hseOZNogcM/J92WG+FC1d7RiPjTZPPtsvrTBIKu60uDM+UVW5lccz6V7U404/oiIVXGMtpIJ2Zd7zrXrzkYo0rP41jVDmPNRuy2UM5s2pi8z6GudV0kPPWMtg7/1N/euUsaHIeq01+YyCf6rjvhmx95MqW+Tw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IFbfQOi4RZr5UwQVShC5LQVMlBWdSbMPdaMTF/RdxIM=; b=bia2XultJv1WyD2zxHUxT3wBf26RWLYO1QCCBWChdtyXAt/X9FHMfeUIRctuidPRFOH0x58x0NR9vzIX8LwO0iV6Nk3K8nbN9abF1U4tVM/qNaTlh10hZYGEZTQMZWiTKDeXs6C7oQYQOhKj+rjK2+mYQSQvL0PT9Rt94UFwHko= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: Date: Tue, 3 Jan 2023 11:08:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] xen/arm: Print memory size in decimal in construct_domU Content-Language: en-US To: Julien Grall , Ayan Kumar Halder , References: <20230102144904.17619-1-michal.orzel@amd.com> <2ddcaf95-03f5-81fb-3091-316b99201a1c@amd.com> <562770a6-2933-43b8-326f-3bb6d8e0ce61@amd.com> From: Michal Orzel In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT095:EE_|PH0PR12MB5608:EE_ X-MS-Office365-Filtering-Correlation-Id: b1d014c4-b8ac-4a02-1a26-08daed727de3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fJynHSJnSPEBvzbxghtpDupzx9m9Qee+q1G70VG1EtoMAmrWrGOfp0Kd0HRcKMQfHbHlZWZPU2LwnmXIeyyI8VC22z5PN0v02sge4e5tO9m67pLhi+NGYF8GJP9lWEvcgog5smDgaSIFazlJsCCAEKcJYwxuR11RMDSdkX+f2Wq8f2yAEGA6m5Sx4mhhdl+TVEQa9zbOFv6uxTkchaZsGQsgzN61QfeH1WCSHzMrJoXU/fLcAddOkjn2k8QgMhwmWxwPIrV+U14KJrGVBRclJbV36laKw5ZX6kQnxhl048R6Gj1R5cgCdbr8IHYIL2gtMaRpexPzHEY4X5MRIvMEi/rrIaoSVYkS01q2cYULM7upLNHTMFIbC9OYeic4cmXeHCH1RAsIqcCfNFeMSCcSf3StkdS6Yq9tGHwiMXtl84Q9uQlCViEZtyuG49Is0J5ULWLTlYH69DOb8Dm97JJbEBibEQegin5qn6r33V4KLdIQBr0Vl1BmiXVTwePib7EdeExISxQZ9BwgFZR4hylpg4zyn2MeYRnFpImMWzoDAqe0VLgytr3wjUSw2dZbN7lXlH4r4AN5ACRsvLFWTd3TdlPIcmo9gZJ36LHIRLwO+Zgj4bMWlrGcmNGdKGz5rrJRETl9EaL9oTeRqZSPRjuktRNueYI3GGNcL7HPVD4lLapyCiFDAu93I3XsdGioAzR+rAzZBMQgQMFDEr5LXBVgONqiXUV+u2AIdpvdias3DCWLydRuGpuW5isxP+cmG5+QdI62q6uMPS31/HquIftlvM5Qr20+J94E+3Cad6B0c7A= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(396003)(346002)(376002)(451199015)(36840700001)(46966006)(40470700004)(81166007)(2616005)(316002)(16576012)(26005)(356005)(40480700001)(186003)(478600001)(40460700003)(82310400005)(86362001)(36756003)(53546011)(31696002)(110136005)(41300700001)(336012)(2906002)(8936002)(44832011)(426003)(47076005)(83380400001)(5660300002)(82740400003)(8676002)(31686004)(70586007)(36860700001)(70206006)(22166006)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2023 10:08:41.9499 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b1d014c4-b8ac-4a02-1a26-08daed727de3 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT095.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB5608 Hi Julien, On 03/01/2023 10:56, Julien Grall wrote: > > > Hi Michal, > > On 03/01/2023 09:39, Michal Orzel wrote: >> On 03/01/2023 10:21, Ayan Kumar Halder wrote: >>> >>> >>> Hi Michal, >>> >>> On 02/01/2023 14:49, Michal Orzel wrote: >>>> Printing domain's memory size in hex without even prepending it >>>> with 0x is not very useful and can be misleading. Switch to decimal >>>> notation. >>>> >>>> Signed-off-by: Michal Orzel >>>> --- >>>> xen/arch/arm/domain_build.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c >>>> index 829cea8de84f..7e204372368c 100644 >>>> --- a/xen/arch/arm/domain_build.c >>>> +++ b/xen/arch/arm/domain_build.c >>>> @@ -3774,7 +3774,7 @@ static int __init construct_domU(struct domain *d, >>>> if ( rc != 0 ) >>>> return rc; >>>> >>>> - printk("*** LOADING DOMU cpus=%u memory=%"PRIx64"KB ***\n", d->max_vcpus, mem); >>>> + printk("*** LOADING DOMU cpus=%u memory=%"PRIu64"KB ***\n", d->max_vcpus, mem); >>> >>> I will prefer it to be printed in hex format with 0x prefixed. The >>> reason being the mem is obtained from device-tree domU's 'memory' prop >>> where the values are in hex. >> No, I cannot agree. Refer to booting.txt documentation: >> "A 64-bit integer specifying the amount of kilobytes of RAM to allocate to the guest." >> Also note that in the provided examples, we are using the decimal values. >> All in all it does not matter the notation, you can provide e.g. "memory = 131072;" or "memory = 0x20000". >> I find it a bit odd to print e.g. 0x20000KB and decimal is easier to read. > By easier, do you mean you can easily figure out how much memory in > GB/MB/KB you gave to the guest? If so, then I have to disagree. Without > a calculator, I will find quicker the split. I guess it depends on the size but you have a valid point. > > If you want to print in decimal, then I think we should split the amount > in GB/MB/KB. Otherwise, we should stick in hexadecimal (so add 0x). Ok, I will then just add a prefix. > > Cheers, > > -- > Julien Grall ~Michal From xen-devel-bounces@lists.xenproject.org Tue Jan 03 10:25:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 Jan 2023 10:25:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470543.730076 (Exim 4.92) (envelope-from ) id 1pCeUE-0004pl-LW; Tue, 03 Jan 2023 10:25:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470543.730076; Tue, 03 Jan 2023 10:25:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCeUE-0004pe-IS; Tue, 03 Jan 2023 10:25:38 +0000 Received: by outflank-mailman (input) for mailman id 470543; Tue, 03 Jan 2023 10:25:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCeUD-0004pY-AF for xen-devel@lists.xenproject.org; Tue, 03 Jan 2023 10:25:37 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2063.outbound.protection.outlook.com [40.107.237.63]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f51e8cae-8b50-11ed-91b6-6bf2151ebd3b; Tue, 03 Jan 2023 11:25:35 +0100 (CET) Received: from DS7PR05CA0050.namprd05.prod.outlook.com (2603:10b6:8:2f::9) by SN7PR12MB6814.namprd12.prod.outlook.com (2603:10b6:806:266::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Tue, 3 Jan 2023 10:25:32 +0000 Received: from DS1PEPF0000E643.namprd02.prod.outlook.com (2603:10b6:8:2f:cafe::ea) by DS7PR05CA0050.outlook.office365.com (2603:10b6:8:2f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.14 via Frontend Transport; Tue, 3 Jan 2023 10:25:32 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DS1PEPF0000E643.mail.protection.outlook.com (10.167.17.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5944.8 via Frontend Transport; Tue, 3 Jan 2023 10:25:31 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 3 Jan 2023 04:25:31 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 3 Jan 2023 02:25:31 -0800 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 3 Jan 2023 04:25:29 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f51e8cae-8b50-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OerhJLJ1dIwKnPPnc1vVMFxZFSnasESGa2Hu7zfkdb2Ilq9PAUbdrxdT5mpd6rZKz3gAYRxrq0fojRZxKOxuP32KEjlbBYlaAtZOz2eX6oq0xxLP7arnrW143vMT/zOnawAnE13cWwy1TQSNuQQYHyKg6/n6LsWoV/5up+WdZfwdH5WDdRjgkzlhjDptG5J/5GYItTPpvqsE9L4uIMxD8PmSC61dGVgK5diB7e7LQN/hKjVCDzvc8xF7yfG7D5VqWddrML6JzbqzR8uTe6nlYGzpcpQ9JVMbavvFiM/N4Xq9GChYSAcG/lZObd3GEZ5OsaQ1MrIlCsx2UnMvKuGQjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1wG8Ayo4aOuncq1FnIWUKxCPPCI3r62/OM1xAaqLnPc=; b=XQFKrWqfbEa98m3l47QqBVK1zGJbiikXZmOVYc4BJo3fVM9XkPo0UBCz/lNDVXsA4+0tn8rSSjXc1LF0eS7Im09xphUaPHljNdc5aUEOS6KVqutUfM3t91qBhnRsd5agJ+3vdO3O8la4eD6MZ/4fcY/5/syHnBC0GJr/Ctpz/N3jNOf0uGBEVylIhzqRd8xDnUanavp2mqUCS9C4OxwEFDFz6NoowYUQHLQVQaQst4kPEe0q2AXZHV41SO5uE7uya7oU5z2S3oRtTG4IlP/Da4Z0X3Y4+24sUlIxZFKizor9qCDNi7FIhRwZA9K7ELlp9/aSDuCNWnBMbP9Irso3XA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1wG8Ayo4aOuncq1FnIWUKxCPPCI3r62/OM1xAaqLnPc=; b=2IlrJDtvsRoUlklYanmZjqDFz9z2uI9ab1U0X2l2eLSryfWfsa90qwyYMo7D5ushEj1yBBurbVxwYW9UOrsZQX4ZLJ53usS6nxXLxK7zU0DxOys4RpsQTPCcvxu+myrJC7P+H/3NgfsUxAjZNl7gDaBUBUmoLYRqhVXl7aTOhPE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v2] xen/arm: Add 0x prefix when printing memory size in construct_domU Date: Tue, 3 Jan 2023 11:25:19 +0100 Message-ID: <20230103102519.26224-1-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF0000E643:EE_|SN7PR12MB6814:EE_ X-MS-Office365-Filtering-Correlation-Id: 16268770-c82a-468d-0230-08daed74d7dc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EDRiX9j+dJxylAl3t2/a7ozIS4mwMnZHatopv7kLQifDZk2hsTlaTmVGd9mJpTdnghp2sTshtzLbHkbO3B0BOlkFRZkwGSWbMXGajdQOsX6UJhIeAn8wxLbEWVag+R+88fsm/bK6At1UffUjPP9Hbj6UstuI33TjjOJL+P5IqPQ0YMBNr/FOxtz1p58jZGiZmcxj1Ss+yrj2YjCsowr8m0etOutVMviRwp+acEAolt9+pb5bJ/gzoNl9wp6IVVXlcLn5lBQaMXx78f3vn8S31vPgz58GLsyTlxysfDD2V+OSZcc6eMSYW7r6glYJwh2MqXqf2Pd+G7Yzexlb7ze1hnK4njxL0u0r5soYrPTEkHoLmQpX5b0Et1vry5F73/9K3Z3kzxzaRI4PYCFM9R5MdrtgyihkMlYmyLGcXjwmAu9gGRHxEnhUCptPT9pOE7Ovk6TKQ4q2GG06tRz4KpkLywK4dvlNOGgAcJ7CgpLgayazoOnM/QzktGQeN8roSCBa2P9GmUiSc1XA92ogPZVbkAIN50DGT7G6KXIrRIaL/uyc2BArfl+Rnjrsffe3KKsXgvux8FKJ9xYyix15zruAtG+gFgyyZSRcnfKC1Z/+fdpzM9ygHpzclkVtzCtvk4YM3hLrSeC9OfUvsUPq/6gflzjV1u0DdOhufio5sFV2kKmEWWvGia3htR1GHBHb6/urCwmoIA1BGLQCKoGvuWH+MWW4pdcHhCmTCg2hH0eJXAlOwK+l3om7ENA5HvDAQLqtsm2l0eRjqfBq2LnCBH1p8w== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(396003)(39860400002)(136003)(451199015)(36840700001)(46966006)(40470700004)(83380400001)(47076005)(426003)(1076003)(82310400005)(336012)(26005)(6666004)(40480700001)(40460700003)(86362001)(36756003)(36860700001)(81166007)(82740400003)(356005)(2616005)(186003)(478600001)(41300700001)(8676002)(4326008)(2906002)(5660300002)(44832011)(8936002)(4744005)(316002)(70586007)(70206006)(6916009)(54906003)(22166006)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2023 10:25:31.9074 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 16268770-c82a-468d-0230-08daed74d7dc X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF0000E643.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6814 Printing memory size in hex without 0x prefix can be misleading, so add it. Also, take the opportunity to adhere to 80 chars line length limit by moving the printk arguments to the next line. Signed-off-by: Michal Orzel --- Changes in v2: - was: "Print memory size in decimal in construct_domU" - stick to hex but add a 0x prefix - adhere to 80 chars line length limit --- xen/arch/arm/domain_build.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 829cea8de84f..f35f4d24569c 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -3774,7 +3774,8 @@ static int __init construct_domU(struct domain *d, if ( rc != 0 ) return rc; - printk("*** LOADING DOMU cpus=%u memory=%"PRIx64"KB ***\n", d->max_vcpus, mem); + printk("*** LOADING DOMU cpus=%u memory=%#"PRIx64"KB ***\n", + d->max_vcpus, mem); kinfo.vpl011 = dt_property_read_bool(node, "vpl011"); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Jan 03 10:33:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 Jan 2023 10:33:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470550.730087 (Exim 4.92) (envelope-from ) id 1pCebi-0006Iy-EI; Tue, 03 Jan 2023 10:33:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470550.730087; Tue, 03 Jan 2023 10:33:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCebi-0006Ir-Am; Tue, 03 Jan 2023 10:33:22 +0000 Received: by outflank-mailman (input) for mailman id 470550; Tue, 03 Jan 2023 10:33:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCebg-0006Ih-Nb; Tue, 03 Jan 2023 10:33:20 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCebg-0006fZ-I1; Tue, 03 Jan 2023 10:33:20 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCebf-0001NP-VA; Tue, 03 Jan 2023 10:33:20 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pCebf-00080n-UM; Tue, 03 Jan 2023 10:33:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=U62M04JiUpJ8vsnwyW/6C/ih+T4SqsduBxg/obDWGaI=; b=P1pufGgPcgMcUMGY9ZWuqKwDns f1VzA/BinEiQIceGpb3ixf0iqCPR9aW7Se0PsUaNgjii+/SMYzkBAMvAkLeTCWv1ppmOqCkQV+08I QkR3UrU6Au2kGKQAwCvhPTCawiqyH9hmRl+ZW3yHjzMDs06vR7e19MkMU9CKU9aTHBXM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 175554: FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-libvirt-pair::broken:regression xen-unstable:test-amd64-amd64-libvirt-pair:host-install/src_host(6):broken:heisenbug xen-unstable:test-amd64-i386-livepatch:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-libvirt:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-i386-qemut-rhel6hvm-amd:guest-start.2:fail:heisenbug xen-unstable:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:heisenbug xen-unstable:test-arm64-arm64-xl-vhd:debian-di-install:fail:heisenbug xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-freebsd10-amd64:xen-install:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=7eef80e06ed2282bbcec3619d860c6aacb0515d8 X-Osstest-Versions-That: xen=7eef80e06ed2282bbcec3619d860c6aacb0515d8 From: osstest service owner Date: Tue, 03 Jan 2023 10:33:19 +0000 flight 175554 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/175554/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-pair broken in 175548 Tests which are failing intermittently (not blocking): test-amd64-amd64-libvirt-pair 6 host-install/src_host(6) broken in 175548 pass in 175554 test-amd64-i386-livepatch 7 xen-install fail in 175548 pass in 175554 test-amd64-i386-libvirt 20 guest-start/debian.repeat fail pass in 175548 test-amd64-i386-qemut-rhel6hvm-amd 15 guest-start.2 fail pass in 175548 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail pass in 175548 test-arm64-arm64-xl-vhd 12 debian-di-install fail pass in 175548 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-vhd 14 migrate-support-check fail in 175548 never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail in 175548 never pass test-amd64-i386-freebsd10-amd64 7 xen-install fail like 175548 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 175548 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175548 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 175548 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175548 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175548 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 175548 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 175548 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 175548 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 175548 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 175548 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175548 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 175548 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen 7eef80e06ed2282bbcec3619d860c6aacb0515d8 baseline version: xen 7eef80e06ed2282bbcec3619d860c6aacb0515d8 Last test of basis 175554 2023-01-03 01:53:38 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-libvirt-pair broken Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Tue Jan 03 10:54:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 Jan 2023 10:54:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470561.730097 (Exim 4.92) (envelope-from ) id 1pCewS-0000N2-7p; Tue, 03 Jan 2023 10:54:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470561.730097; Tue, 03 Jan 2023 10:54:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCewS-0000Mv-52; Tue, 03 Jan 2023 10:54:48 +0000 Received: by outflank-mailman (input) for mailman id 470561; Tue, 03 Jan 2023 10:54:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCewQ-0000Ml-Dp; Tue, 03 Jan 2023 10:54:46 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCewQ-0007FR-BH; Tue, 03 Jan 2023 10:54:46 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCewQ-0002LA-0f; Tue, 03 Jan 2023 10:54:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pCewQ-0002Jh-0H; Tue, 03 Jan 2023 10:54:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ZTHG2ZwIsaSqEf66LtQuBcdhmyksofI4lkxW5wb3inM=; b=Cq4NCQ/SE1TLd91avksjoLhlaU Hhcyho3PAvNg3eZdw/rYtiNSjaXK6X1ipt71IjC5lmGXjAvDI75aqDyvYE0vZRxNJeXQVN4x6kFXO OVCYasbwX6U9PND8Gi9YK/TTPQ0JCjjOD1g9UTaofI/0n/N2/8oG2haOprQuG3peXaTM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 175558: all pass - PUSHED X-Osstest-Versions-This: ovmf=b670700ddf5eb1dd958d60eb4f2a51e0636206f9 X-Osstest-Versions-That: ovmf=bbd30066e137c036db140b6e58e6e172e2827eb3 From: osstest service owner Date: Tue, 03 Jan 2023 10:54:46 +0000 flight 175558 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/175558/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf b670700ddf5eb1dd958d60eb4f2a51e0636206f9 baseline version: ovmf bbd30066e137c036db140b6e58e6e172e2827eb3 Last test of basis 175529 2022-12-30 07:40:56 Z 4 days Testing same since 175558 2023-01-03 06:41:58 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Dun Tan Tan, Dun jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git bbd30066e1..b670700ddf b670700ddf5eb1dd958d60eb4f2a51e0636206f9 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue Jan 03 11:15:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 Jan 2023 11:15:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470570.730109 (Exim 4.92) (envelope-from ) id 1pCfGO-0002pJ-SW; Tue, 03 Jan 2023 11:15:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470570.730109; Tue, 03 Jan 2023 11:15:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCfGO-0002pB-Pj; Tue, 03 Jan 2023 11:15:24 +0000 Received: by outflank-mailman (input) for mailman id 470570; Tue, 03 Jan 2023 11:15:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCfGM-0002p5-Um for xen-devel@lists.xenproject.org; Tue, 03 Jan 2023 11:15:23 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e7d0c786-8b57-11ed-91b6-6bf2151ebd3b; Tue, 03 Jan 2023 12:15:20 +0100 (CET) Received: from mail-bn7nam10lp2105.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.105]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 03 Jan 2023 06:15:11 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DS7PR03MB5414.namprd03.prod.outlook.com (2603:10b6:5:2c2::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Tue, 3 Jan 2023 11:15:09 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5944.019; Tue, 3 Jan 2023 11:15:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e7d0c786-8b57-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1672744520; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=FrCbF7/5KWC5RgyFF95YNecZCcdp2COhwvPWjoJVcOc=; b=UYCTDV0VbuCflIR+Q25xYJxm+po8LYn/wn0im9lhfEx+Gj7pLHoOaRrw Cwvg6sPwgtQU1ce9n+CWM/BwQg3Ti8ZoL1iJsCqUzJSh/OxEEnIK2DDbN hePdY35M3YmBFMYTZFijD9f3w3tVZ+T9vJD7m8tRVkmez9vYlW1U1L5Or g=; X-IronPort-RemoteIP: 104.47.70.105 X-IronPort-MID: 90987143 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:dTr0S6oejxSDGtOOD4NTgkSn1dteBmLUZBIvgKrLsJaIsI4StFCzt garIBnXafncNGbxLYgjaYni8UsPv5eGn95jSAZoryljQ3xG8ZuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpAFc+E0/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06W1wUmAWP6gR5weHzyJNVfrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXADEgQS6Iht+O+ajhSrJ8nZ0sCtDsFZxK7xmMzRmBZRonabbqZvySoPV+g3I3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3j+CraYKIEjCJbZw9ckKwj 2TK5WnmRDodM8SS02Gt+XOwnO7f2yj8Xer+EZXprq863wTPnQT/DjU1UUOVp+e5uHLlRt9CM BJOvXITr+8toRnDot7VGkfQTGS/lhsVQd9ZCeA5wACL1KvP4gydC3QETzhOc9gvvok9QjlC/ k+EmZblCCJitJWRSGmB7fGEoDWqIy8XIGQeIygeQmMtwfPuvYUyhRLnVct4Hei+ididMS706 yCHqm45nbp7sCIQ/6Cy/FSCiTTzoJHMF1Yx/l+OBj/j6R5lbom4YYDu8ULc8ftLMIeeSB+Go WQAnM+dqusJCPlhiRCwfQnEJ5nxj97tDdEWqQQxd3X931xBI0KeQL0= IronPort-HdrOrdr: A9a23:ZEysqa0Gh6JflL5ymjZougqjBZxxeYIsimQD101hICG9Lfb0qy n+pp4mPEHP4wr5AEtQ4uxpOMG7MBDhHQYc2/hcAV7QZnidhILOFvAs0WKC+UysJ8SazIJgPM hbAs9D4bHLbGSSyPyKmDVQcOxQjuVvkprY49s2pk0FJW4FV0gj1XYBNu/xKDwVeOAyP+tcKH Pq3Lsjm9PPQxQqR/X+IkNAc/nIptXNmp6jSRkaByQ/4A3LoSK05KX8Gx242A5bdz9U278t/U XMjgS8v8yYwrGG4y6Z81WWw4VdmdPnxNcGLMuQivINIjGpphe0aJ9nU7iiuilwhO208l4lnP TFvh9lFcVu7HH6eH2zvHLWqkjd+Qdrz0Wn5U6TgHPlr8C8bik9EdB9iYVQdQacw1Y8vflnuZ g7nV6xht5yN1ftjS7979/HW1VBjUyvu0cvluYVkjh2TZYeUrlMtoYSlXklVavoXRiKrLzPIt MeSv0018wmKG9yqEqp5lWH9ebcGUjb2C32GXTq9PbliQS+10oJsnfwjPZv4kvosqhNCKWsrt 60TJiB3tt1P7ArRLM4C+EbTcStDGvRBRrKLWKJOFziULoKInTXtvfMkf0IDU6RCe41JbYJ6e L8uWljxCcPUlOrDdfL0IxA8xjLTmn4VTPxyttG75w8vrHnXrLkPSCKVVhryqKb0r8iK9yeX+ z2NINdAvflI2erEYFV3xfmU50XLXUFSsUattsyRlrLqMPWLY/hsPDdbZ/oVfHQOCdhXnm6Dm oIXTD1KskF5ke3WmXgiByUQH/pclyXx+MGLEEbxZlm9GEgDPw+juFOsyXJ2iiiE0wzjoUmOE 1jPbjgjqS34WGr4Geg1RQdBiZg X-IronPort-AV: E=Sophos;i="5.96,296,1665460800"; d="scan'208";a="90987143" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mNJCg+pI6zQ6RY3Pzy8amqUlpSfA7yPPEy4AxpcEA4yofADJ1IgJSKi1/hjwAIPtG7wdZ8SIznTU0EPDWuGzefEzvXWAF+Lr3hCpph/RFKW97AnFuaK2EOcCK06Cbq5k2pftQPPiFASg1wD9ZhuaesAzS4mI0bgmE+YYHXqUh0JyXwK+gCVRLaRm+5d2bn0Y2Alzyc7E7vleVGhZjFkPH+VJINLiK43QF5+aNki/h2kjSF5Y5RhhuRNDGZbYFpMaQv0r9/bAwzdUqm7QPjTM2mO479SKGy7nE4GsSkw5NWqkStU7caNqo5G7Q3V7nGwowd6NqqLRh/Sml7+iR57YHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FrCbF7/5KWC5RgyFF95YNecZCcdp2COhwvPWjoJVcOc=; b=nfgh/ohiv+BW+d1x9wR2tU4tF6NyCM8rQ3I2B5LQJ8wOSG8jfG178knpnst6DdvEK5iC1qb+QyaCmBPyoAXVyun295nB7dyDjqb3ZCggVHxxHBsJ2tNjk+HSGBMqwq9qZBIYBgowEtS9Eg0zGM/c0OwlYbrWVqjLU/hxnaSFFbNY3DR9iAsfwm9N/s3VyrhmhUB9etiY7rPpWzjPLlaGrOJj80vXSjeJSFC0qt9l9ry0MxGD8Pw7xD1AwGXMSrkY0i95ozn6fc7xa9JlQ8+qBUdzu9Y4oDTbr9mWBIYBL4nDFciNnXfhQa8Onzzzr8pAy+lMfbriD+THM1G7VELrPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FrCbF7/5KWC5RgyFF95YNecZCcdp2COhwvPWjoJVcOc=; b=hbe3TypLI1htgupX+s+FKOuAv4Ri4lb8zRakf/CfDofdm9IoJOTs0IiWvf8KJoBkukqIz4t83VGIOhXujk6itL3wMsBppj7MJEkGXfXnKEQuQ11t8M18BlIL2NQet8rgu9nhsW9zSqXPP4UZCwWDanyrc/hGrhSNNBJD6UTTKN4= From: Andrew Cooper To: =?utf-8?B?TWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tp?= CC: Xen-devel , Jan Beulich , Roger Pau Monne , Wei Liu Subject: Re: [PATCH 1/2] x86/cpuid: Infrastructure for leaves 7:1{ecx,edx} Thread-Topic: [PATCH 1/2] x86/cpuid: Infrastructure for leaves 7:1{ecx,edx} Thread-Index: AQHZHK8RB6bbm4Xa9UKGRMzZOin/e66Jqk4AgALlmgA= Date: Tue, 3 Jan 2023 11:15:08 +0000 Message-ID: <9557496f-e232-ef50-39bb-7eb509bc72e8@citrix.com> References: <20221231003007.26916-1-andrew.cooper3@citrix.com> <20221231003007.26916-2-andrew.cooper3@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|DS7PR03MB5414:EE_ x-ms-office365-filtering-correlation-id: d94ef126-11fa-4f73-605e-08daed7bc60d x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ZFL/7HY6Wkjr7lQC1xQool8D8xW8czTNapUDf7qZ5SffDCwFa9wlCPtmUkbEJbFz6f8WywflqB3T0fPCYwF0KCqNd5vI05MTqrcqTJkhBr7A7b+rYT1mtUs0KuAvwEDD76zbK7k+AYFwz2HuRkNkbU39QaaJSfddMfjPI90i3wdxO+TtaBwUlqKqPJN7oyTUF2noAKyJHQKkLJhuAC/OATUd92Hcp7J3R3+diow91RMnuU7olTOsIkAhp2K24ctUdZKwkYyyWmSz4ylQPrOs4W6kkqcD3NhvW5YPRiJf1fA6asdCYAx1JNbeiFQSVRsvgjs9Rg9ix3/mjKlB4QjI+wDuj2Xi2CmQ+nwIEFGHoH93cSeGoDh0WIiCBIlvfXxHXmx90NevQAbPUjv6Jag/lCrUAZVf8kaDDj4t8tEseahnrZll+328JtBcbLI+XC335jNCL6UnmoO1IedK7u144oDhUgji+oQdJaXDlxUFoen5xcDJFROWZyE57D6S0cVSADy0J9TWwKAGlalW1jXfAHUudXM2l7uMt2dQ3mVTeAA/Mwq/X34Y7lZuy8SPrD3DP2c9JT+jI5OOoqZzbc9CqPuzh0/kXnNIZAKbGsxsD7Zu81sgd12ysifpxBWOmCJoKNA8kj5HFSfT/xum2rm1Avbm0aJ54dGsTK7lLxQ+IdOa//B2K23a77Syj4VpvMyDjkoVpQGXVLi+VTvpbHkTrOLCIarH25Q6Cq7JCxaZ2tjOJT3+njo4zUhNrT/fHC+HX/xo3XmewxkQIyzfWmfCYjjDnQti9KItd2qVCfwcycU= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(366004)(396003)(346002)(136003)(451199015)(38070700005)(53546011)(76116006)(31686004)(64756008)(66446008)(66556008)(66476007)(66946007)(6506007)(4326008)(41300700001)(91956017)(8676002)(316002)(6916009)(2906002)(86362001)(26005)(54906003)(186003)(31696002)(478600001)(6486002)(6512007)(82960400001)(122000001)(38100700002)(4744005)(8936002)(5660300002)(2616005)(71200400001)(36756003)(22166006)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?K2Z3TG9NT2pXK2NkOXo1ZUY3OThQSDV2YXhWbkNINldGQmlLa3cwRHR0dmJH?= =?utf-8?B?cm5sWGI1SXZlVUJ4Nlk1cEJVMFhmajZnUDcyaDF3NUFSREhKazBWRk0wQ3pW?= =?utf-8?B?eDRNWFkyYkRQOGM2SVRpTitPQmF0TmhweVNidUVsbXpPaytCZ1ZBMmwxSmZX?= =?utf-8?B?dVRWcXFDY0JDOUEvcUNsVk1yR20vc0lNSG9VYmtJVHpGZWtvQklsWUlhQTdD?= =?utf-8?B?bVZBY0U1TlNVOEdvVlpLUlNBVEE5N1J3Y1MxaENkMHpML2trbU53YkFFUCsx?= =?utf-8?B?WGpkTGlBVWQyZzVPcE9nUENDU2xONVNXZ2ZMR0t6WXJ0dk1aZTd3TndFSTh4?= =?utf-8?B?eDZXVGxaaDBaTmhZcjAxVlhNZEZPRnl4QmhjUzBBTjRpOHVkb09iVnZFbno2?= =?utf-8?B?bHZnaUZ1NEtKTGlWNWZGcVRRQTczZytreitLMzRsNUVWN2toajB0Zlp4QmZX?= =?utf-8?B?TXZGYUtpOGpqTXRnSWFad0hYVEI5aEF6WDZZTTZEeFBzWjNOODQrSGFhRzlX?= =?utf-8?B?ZWZTSk5pdGM2cTlOeTMwNXhYK1hzRy9uNlk5dTJIbExKQy9lNEVQYTB0ck1n?= =?utf-8?B?NGdocGpPUWp1b2JwQkFCemJ5b3VLbk1Hd2ZQOTloa0ZHdnRKSnRMK24raEQr?= =?utf-8?B?UmU0YUpnNGpsRG90Z1NGYXFuNXJxNkpBVGVVTG00UmFzVEFJUW1zOUUxVmZJ?= =?utf-8?B?V3B1WnJPREhlYTdpS2hZaHVIWVJESU5zbUV5MnF5UWd6Y0tlRGg0aC95TytI?= =?utf-8?B?UjN2d0M2Y0RDY3Q1bkFiamNabmdWQU9YK3lQWnR6UDRqV0tIVVljYktlaWpL?= =?utf-8?B?TDZacEZ5RFMyVE1vbWdmVTVJVmpPeWFhQmludXMvYXhsMkR4V3JKTTNrcUd5?= =?utf-8?B?WmMvM2JIeSs0dm9zMkZkdUZscjJyN3JLT2Nxb2FnTmxZRGt1bldzS2RQeWZz?= =?utf-8?B?bTRxVzFtTDd1WXB0SWpXY09xOG56WVhSOTNUbXZSSmFoSUlTd1hJcG5NeEFU?= =?utf-8?B?V01ONHQ4RFc1ODBpME9GZ2dSOVNyWUp1UHJ6RkJlNmJvZXlXUitlYXB0WHRm?= =?utf-8?B?cG43OGd4cUtyMXlvY1UxTlc2Skh6YzJ6Vk9mUU0xcW4xM3JaL29PSCs3bkhh?= =?utf-8?B?SlFMN2Z4bGZVZnR2aHZBTjZIVDV3b2owd2ZZekZBS093WFAwMFVEcGhBWW40?= =?utf-8?B?Rjl0VWQyMzgwOENOaitPdzR6b21LakcwemNHdXE0bHd2R2d4amhmUG9qcW04?= =?utf-8?B?Y091cnlnR0NORGJFK1RPeWljVGtyRDVUOEpZK0owNlNXSS91bmoxVzRIeWk0?= =?utf-8?B?ejhBN1oyNStFSGk4aDdobG5nUWR5Wld6MGMxaGFDZTdPckpJTEJDQWxHVDFK?= =?utf-8?B?NTVWN1B2amFZUXRqRGVqVFZ6RmxlYjg3cXN0VHZudXNqWE5NMFRjZ2tzSlFW?= =?utf-8?B?RUpkZDhwZUhrczFnMzFndVZraERqV1VOcEUwRVZCUjR0cHBlbFNnQWRtNWZh?= =?utf-8?B?YVdvYmNQbWhJTVAyWGRRUVNwRUdZaEF3QjRuekFqeGJ1RlVOckhuMFFOTnBD?= =?utf-8?B?OWk0eDBleGlnMHFMWXRpemZLelRzUDl4T3lkYWlwa2lBS1NmWGJqeGFua29T?= =?utf-8?B?cVpuK2lwaDZna2xkdDB5YXFNNjFpbjlsWDZuMTh1cE1RVThxWFEzeDZHQ3p0?= =?utf-8?B?Q0I0UkNveU1wWXpOSk1TczVPRElUZDJEYzJsN3RtNVMvQldUYjNpTHBrajhH?= =?utf-8?B?RnlERHVUSGhGRmtpVU9XZW1oZnVRckdhY1ZydThaRHR6L3YwY1lqYXBDRnB0?= =?utf-8?B?am5yNDFIUDE0cUg3UzdTdjZ0K3l5TmQxc1E2aXF6d0x2OTBGZXRHWnkxOUNl?= =?utf-8?B?N2tZY2s1eklQVHVYeDdEZ01GbFNvdjlMbTdua21Zbk1xWWh1YWg5Z2dDOU5w?= =?utf-8?B?YkNoZ1ByTThPMFZraW1Benp3dTNsYVdBM2VxRDdINm5GSll4MjhFZXRGSFE0?= =?utf-8?B?Z2hFVENhUzkvcFBQUmVDbFJhN0tMNUJHL0M2QmFnak85TFUrT05oYkVJdFhL?= =?utf-8?B?ZjdoUDEwYzVIcmhJMjVyK3Q5Nkc5QVo0YjJlRi9vS2RtK1dOejFaU0NXRnhY?= =?utf-8?Q?oHBmR3GPL0gB39R/j8fzchHat?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: ztuzM6H6ZXFYqSjqCwzLfem3cA5R4M9VtB7fnul0YXSplBIWSKKtayOvs0WO95+UGERRPpstyO5cAvOF0DazNUxQxvNXYh09NhCIsXKjlzgtjNpv9APhxhiDbRnD29AKodIq/V0nvchcneVhmKG1fH6BrxXISvEIpUi+xMiAQX3t5VijnNxLlDqyWkZq7UjhOYqQLJPzSH+5OzmvoWObY2m+qFkGG1UZ9T/Dp4BHm8UDeZqhBILLerJOIbtyGYteh0yocuVeWw8H8wrPPH3sojrcTPvtsKiSIqbSCbmW6ZLbc/VjcN01VTPqgmp2QvELt5Ey1p/N5Mf5vLqFiTZOr57cePp1u7vLMKce7Dli8zoeFbDzC/s0920nxoVg+I3CrLkkdscgMl2ljJWxOkUhapuTa7+9vNEiepATcwnXUj+HeUyMWk1717TDbdofGzNu814wg3otRDkEsvaVOQfxAfoZSz3GgEqBxqpx6AAbrf/B1L3537qgGw/UUs9lq5G9UvoeiXjuoRaEY+8fbxqewo5Yr5yZnTLduCeOjexczWtE7WvpkWewCNllnHEZ4fEOsAsH5zlj1gIHqWoMEOtPFunnsgwcFDvN39lLrcJvk2KgCCHqVf4bQsAodckSJLNHtxsIvKkcZGjftqWet2B+ZqxaW3BUxPU1DQwaa7Zy00HxxqNTppze8B3d3G0rzTOSKFZJS9DcFuoR6NsQoGP5I8ZadRZq96P1oB5n9nVpmH2Iyoc/VSiP6E9xM0DjlFuGMVFpT6UKAMoPfr42r54RpsJUP7sD/25eFbOhM9aaU1Z4uxV1uLPCfSKOcP1r03AumS0mQ/79ThNby0N2MZmXe9W68phzNlRvx6MYJ9Bbaw/4MDVT0cL3VCRqf5L5m0GV X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d94ef126-11fa-4f73-605e-08daed7bc60d X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jan 2023 11:15:08.5403 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: i84OxRmiDwmiLcUYzkGigotJ7RoL9i42Lx4qOn6gJC6CfazQhMgXnKZkhh3HqQiEw4X5+fV3qsm+dG8Mq5Ixwn1T3ODAnqPxII6Ac8ijwU4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5414 T24gMDEvMDEvMjAyMyAzOjAwIHBtLCBNYXJlayBNYXJjenlrb3dza2ktR8OzcmVja2kgd3JvdGU6 DQo+IE9uIFNhdCwgRGVjIDMxLCAyMDIyIGF0IDEyOjMwOjA2QU0gKzAwMDAsIEFuZHJldyBDb29w ZXIgd3JvdGU6DQo+PiBkaWZmIC0tZ2l0IGEvdG9vbHMvbWlzYy94ZW4tY3B1aWQuYyBiL3Rvb2xz L21pc2MveGVuLWNwdWlkLmMNCj4+IGluZGV4IGQ1ODMzZTljZTg3OS4uMDA5MWExMWE2N2JjIDEw MDY0NA0KPj4gLS0tIGEvdG9vbHMvbWlzYy94ZW4tY3B1aWQuYw0KPj4gKysrIGIvdG9vbHMvbWlz Yy94ZW4tY3B1aWQuYw0KPj4gQEAgLTIyOSw2ICsyMzcsOCBAQCBzdGF0aWMgY29uc3Qgc3RydWN0 IHsNCj4+ICAgICAgeyAiMHg4MDAwMDAyMS5lYXgiLCAgImUyMWEiLCBzdHJfZTIxYSB9LA0KPj4g ICAgICB7ICIweDAwMDAwMDA3OjEuZWJ4IiwgIjdiMSIsIHN0cl83YjEgfSwNCj4+ICAgICAgeyAi MHgwMDAwMDAwNzoyLmVkeCIsICI3ZDIiLCBzdHJfN2QyIH0sDQo+PiArICAgIHsgIjB4MDAwMDAw MDc6MS5lY3giLCAiN2IxIiwgc3RyXzdjMSB9LA0KPj4gKyAgICB7ICIweDAwMDAwMDA3OjEuZWR4 IiwgIjdiMSIsIHN0cl83ZDEgfSwNCj4gIjdjMSIgYW5kICI3ZDEiID8NCg0KRml4ZWQsIHRoYW5r cy4NCg0KfkFuZHJldw0K From xen-devel-bounces@lists.xenproject.org Tue Jan 03 11:18:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 Jan 2023 11:18:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470577.730120 (Exim 4.92) (envelope-from ) id 1pCfIt-0003Pm-Al; Tue, 03 Jan 2023 11:17:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470577.730120; Tue, 03 Jan 2023 11:17:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCfIt-0003Pf-7k; Tue, 03 Jan 2023 11:17:59 +0000 Received: by outflank-mailman (input) for mailman id 470577; Tue, 03 Jan 2023 11:17:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCfIr-0003PZ-5C for xen-devel@lists.xenproject.org; Tue, 03 Jan 2023 11:17:57 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 443a6bd5-8b58-11ed-91b6-6bf2151ebd3b; Tue, 03 Jan 2023 12:17:55 +0100 (CET) Received: from mail-dm6nam11lp2172.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.172]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 03 Jan 2023 06:17:35 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DS7PR03MB5414.namprd03.prod.outlook.com (2603:10b6:5:2c2::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Tue, 3 Jan 2023 11:17:33 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5944.019; Tue, 3 Jan 2023 11:17:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 443a6bd5-8b58-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1672744675; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=loQ1+D7roScKs3lPYDTnaMxLHTA/ehvWJiM110hZ2Zo=; b=F8BWpFI6LmIORtA2/SHrrMR8SV0UqVlui9B6yC3jfJR7FfBbLZgaue45 g1/qSR2NkQHMJx4YWrauKw35buAsHovrKac1I3SijqYr7XWI2iViIGMQ1 PxD4upPCumLeEVPIK4ilxtzD+KultIzH16Bxd01i8j0YvGbE5rwksICpN k=; X-IronPort-RemoteIP: 104.47.57.172 X-IronPort-MID: 89900496 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:UGrBGq7QBOyaeQHbyqLH1AxRtPXGchMFZxGqfqrLsTDasY5as4F+v jAfWDqHa/mKM2qgL9tzbo+3ph4GvMeGztQ3GwNr/Cg9Hi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraBYnoqLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+4pwehBtC5gZlPakT5weH/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m9 tgIED5dMle/u8mI5+KBZvhVudYPM5y+VG8fkikIITDxK98DGMmGb4CUoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6Ok0ooj+KF3Nn9I7RmQe18mEqCq 32A1GP+GhwAb/SUyCaf82LqjejK9c/+cNJDReXgqq806LGV7kc9VzAqalGJm6mkkm3iasNkD WM56BN7+MDe82TuFLERRSaQpXeeuxcGVtl4Eusk6RqMwK7Z/waYAGcfSjdLLtchsaceVTEsk 1OEgd7tLThuq6GOD2KQ8K+OqjG/MjRTKnUNDQcmZwYY59jooKkokwnCCN1kFcadkdndCTz2h TeQo0ADa647iMcK0+C3+A7Bijf1/5zRFFdqvEPQQ36v6R5/aMi9fYu05FPH7PFGaoGEUl2Gu 3tCkM+bhAwTMayweOW2aL1lNNmUCzytYVUwXXYH80EdygmQ IronPort-HdrOrdr: A9a23:rovTC62V3ljUhsoG425UlQqjBZxxeYIsimQD101hICG9Lfb0qy n+pp4mPEHP4wr5AEtQ4uxpOMG7MBDhHQYc2/hcAV7QZnidhILOFvAs0WKC+UysJ8SazIJgPM hbAs9D4bHLbGSSyPyKmDVQcOxQjuVvkprY49s2pk0FJW4FV0gj1XYBNu/xKDwVeOAyP+tcKH Pq3Lsjm9PPQxQqR/X+IkNAc/nIptXNmp6jSRkaByQ/4A3LoSK05KX8Gx242A5bdz9U278t/U XMjgS8v8yYwrGG4y6Z81WWw4VdmdPnxNcGLMuQivINIjGpphe0aJ9nU7iiuilwhO208l4lnP TFvh9lFcVu7HH6eH2zvHLWqkjd+Qdrz0Wn5U6TgHPlr8C8bik9EdB9iYVQdQacw1Y8vflnuZ g7nV6xht5yN1ftjS7979/HW1VBjUyvu0cvluYVkjh2TZYeUrlMtoYSlXklVavoXRiKrLzPIt MeSv0018wmKG9yqEqp5lWH9ebcGUjb2C32GXTq9PbliQS+10oJsnfwjPZv4kvosqhNCKWsrt 60TJiB3tt1P7ArRLM4C+EbTcStDGvRBRrKLWKJOFziULoKInTXtvfMkf0IDU6RCe41JbYJ6e L8uWljxCcPUlOrDdfL0IxA8xjLTmn4VTPxyttG75w8vrHnXrLkPSCKVVhryqKb0r8iK9yeX+ z2NINdAvflI2erEYFV3xfmU50XLXUFSsUattsyRlrLqMPWLY/hsPDdbZ/oVfHQOCdhXnm6Dm oIXTD1KskF5ke3WmXgiByUQH/pclyXx+MGLEEbxZlm9GEgDPw+juFOsyXJ2iiiE0wzjoUmOE 1jPbjgjqS34WGr4Geg1RQdBiZg X-IronPort-AV: E=Sophos;i="5.96,296,1665460800"; d="scan'208";a="89900496" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WkR7GoBglnFwdLrezXZPSkC+Aj7NpdeoUb+CsbPZ6yIOa55dtSiM+Db8rwpNJA856Q4GdL2XUJSJwGZ+pLMy8gf/t7tkLzCSJHd9B/e56N8ODORXRpfytZ94SB6AI+3i2YLCQNdMnSS+hWnR9PUKSVb892Ig7dfA+dwEnDdU+0/6fi9epnh3UcyaRXlCz84THrP3XPpAkx7/AA5BywNaqTO42DJ8R+81EVZc7KBTzpRUDYwCai885DdPhD0Ku/5ZaDObig83jZXKyA5qAmNIhl4qNUosr5xY0cUfXYWygDo9AG9v5SapdmB3vXoWHADdn2GXn8XWYNyiSHXNLJOVLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=loQ1+D7roScKs3lPYDTnaMxLHTA/ehvWJiM110hZ2Zo=; b=VhG6bOkBmFYHGpm7nceKkNGJd7nht7Ta2Iogu3PB25TH57tNPvZcfY/OTKzTq5SAiyVZ66Q2IOSS/JfIPA8p98Ogju2peMD5mW03KsLqi9kDCZHpqSAUvTjogWzPnYIUsDCj9hR7OxFuUqqIE+3e1vLwlob44Q4suvt052DXeNUeAV+1CA0dsY3G2v1ilXv1yWoP907jTvNoI6rld0hm5eM0TO/JcSJoDG4MASWlYWaufehKBzZFS41EzpFAv7q6i74PWGH6e0uInLmxqKp4lz7hji4gu5pRixd9+s3xGNV02NANzcKfzyvKTiB0+X3IE6UVBvfoQVd8f917rnv/DQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=loQ1+D7roScKs3lPYDTnaMxLHTA/ehvWJiM110hZ2Zo=; b=jjT+6Qk+9AfJldODV5rOv5g9SgXCoNwZnAqJoWDeofWMviDdWsikgcJBXJogjU0IOJ408kkYVIfm2YMAbr2slsE49tL7KLUGKIDfH54Gtum3cZzJCWXqEHIJQhP7RQDhxeV7rhFIdwr/B1b5GPLJ4jkwl9t5nMCXXm60rtHb3po= From: Andrew Cooper To: =?utf-8?B?TWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tp?= CC: Xen-devel , Jan Beulich , Roger Pau Monne , Wei Liu Subject: Re: [PATCH 2/2] x86/shskt: Disable CET-SS on parts succeptable to fractured updates Thread-Topic: [PATCH 2/2] x86/shskt: Disable CET-SS on parts succeptable to fractured updates Thread-Index: AQHZHK8Tc134ZZkfC0SbNIFFZQXGXq6JrR4AgALjd4A= Date: Tue, 3 Jan 2023 11:17:33 +0000 Message-ID: References: <20221231003007.26916-1-andrew.cooper3@citrix.com> <20221231003007.26916-3-andrew.cooper3@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|DS7PR03MB5414:EE_ x-ms-office365-filtering-correlation-id: d5f58551-5bd6-4906-a271-08daed7c1c76 x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: urFOqW4+7Rw8yYtZFNVE6Y23iUhgAAaea0FqjFNBTNPEVcroEOPMhdP4GOdNAzA9MkndhlhBO/S/JBxBt4yqL9FvVVZYx9+pOzOxCog6Rgo+3P3xAqKt+67qYRvfDEZjPFr0t7A2W/mmdAts5P1eYWLGd8ud1Fs91NNuW+UGSvOmAOUY2GHqikAu6C1wbEJjrz/xzVdVVe5yJYiJ0MeT3plgRo9IkBT/PMZ8/pgH0HkDYEzH5ZE8Nz81NPNaLINV3pjbxGRTn99eU7ymtNJNfq5FUjOwI9D76DH+gk/hrViIZpl6orAS17uUTYJUg9MSrSmx9z3Wq4JypRN+C6IHThCHFmpevRcDkpfaFjeAkJyr8CDkaCJZsu6XxubdHxCeu2isOS0foIU8fiGN8fFlxlmj0VNqdi6NMhz8atD98S52zgeuwzzlTmWhi2H9t/GFCQFAcABOXvp2eYgMlaOsrszpM35EIGkPghOSia2kfjZ5jXbKwrc0D9fO7ticwdH19e8fdQpLgTvi+5yrqtPx4vse8q9Y2NImIhP81RTyMAh7+B46vOc7Nub3V3uRFalS9wAyUAK6WukP2U3retE7vOVauNH31TSv0p084oy6qJuQ37i6j8ZlRWSkahAKbfZcxzHoaCvxsXUvmQoY/lkXrZcOdnwU+C4o0gJPUBKIhfZ4pqm7fy1rgNamHWU99AFuyIa1r49rZPynKIDgWxrvca216LZzkT81H8Bk0ejLsO+REkvsZ+b8Tgl2EeaTLFhylEAPbrISbn3M0YaAKcNFZS0UeEJi5071YGaZumkM+1g= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(366004)(396003)(346002)(136003)(451199015)(38070700005)(53546011)(76116006)(31686004)(64756008)(66446008)(66556008)(66476007)(66946007)(6506007)(4326008)(41300700001)(91956017)(8676002)(316002)(6916009)(2906002)(86362001)(26005)(54906003)(186003)(31696002)(478600001)(6486002)(6512007)(82960400001)(122000001)(38100700002)(4744005)(8936002)(5660300002)(2616005)(71200400001)(36756003)(22166006)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?bXUwSmZ6ZkNvZVVLVW5EZWZ1WWR2cWt2RFd5RmllL08xM2w4eWt0MVVxTXJY?= =?utf-8?B?MExiUUFZMTk2K2FJNG9RblllKzIwSjVPcjVSUk9TVldnREJxUVBibWIxUmR3?= =?utf-8?B?cC9BRDVVTXAyeVdZR0U4K09aOWg0SDF3TmNFc0MxMEhoWUVKNHZ5WEFValZL?= =?utf-8?B?SWhmcHZ1eGViSnY1dWt4cHppakRLeUJ3NEFaN05mVCtpdlMveDlQeXhFaHZG?= =?utf-8?B?VlYrTVJxem5YQnJsTGt6aytUMEFwZWxxanFZSnI4ZmRVandmS3JVT0hMbEdw?= =?utf-8?B?WTFLbEo2WHlWQnprc2x6dURsZmlReVNaR0NUbWFUekp0ZFNWZ1J5WHNxMS8w?= =?utf-8?B?TXVmcS8vVGdweSswNTNYU0wyZE5jcGt4cm13N1ZsSWp1cUE1STA2SXVvUENW?= =?utf-8?B?bzZpYWF1aTdLUGY2eTRUK21qZGdlOC8wR2UrUEszalFUSUVKYU5PU1BRYzVo?= =?utf-8?B?cjVYZDVPejkwVWR4d0tPL05yRGRMSHZvZUd5R0pqYThHNWI5Zk41ZzdnNFdl?= =?utf-8?B?R040R1FnSHQrVlp2YU5YNHlORGNFYlhyNzRhZXd1YWRKWGxhc3FBdkxQK2M1?= =?utf-8?B?Z1BMK1JCSmdhdjdPaGFyT2hRZG9xVDlRTmtzRms2dFIwTlNNaW5IZCtMaW51?= =?utf-8?B?Sys5dk5CbzdjakIxKzlROHgybmtYcDQwTG1LazV0NXhuUTBRdGpZbS9hL2Uy?= =?utf-8?B?VDBEdlZzWC9KdGFodlpUbFB0ZW43bnZuN1FQN0k3dHNwaHNXRDJmL1dxYis1?= =?utf-8?B?KzlvaEtxejU0ZTJobWFyVUhCemF3eG5uWDdLU1Y1RFIyK3pidHJHWEY0VGQv?= =?utf-8?B?ODhhMzFUMVRRM1BEYVlQaWxTWnJwRzBoWGFXc0E1NDAzRkt5UEIxUjN5QXhW?= =?utf-8?B?WkQ2cmk0ZVc2WmNtZmZGMFBQU3NkSW5ZU3M0Z1piRmg1RTFNSXBKZ0ZPRzYr?= =?utf-8?B?UUNHZEpDaS9NZDhxcEpBdDEvb2N1dXRiQWR1M1RSM1dydnVZYTV1RlBoVUt2?= =?utf-8?B?Syt2RkJ2dnZWWXFCT3JPZHVhVzBaZkoyU2p1Tk9ieDQzSnlkUElUTnRqRVpt?= =?utf-8?B?VWFmVGFQdngrSnRPblNkb1JCM1hFUlB4eWxVL01tOVVXcE9IdW13QkY3L3N4?= =?utf-8?B?enZNYkVPSUNYSlpNYjJsNEQ1a0JXN05ZK1ZtN0lzNWJzY1A2ZGJKQkFjUGFx?= =?utf-8?B?TDRRbWtCeTJlLzdiQ1RmckU2NU9KZTM5bDIzc0h1S1JWZmZ2bWN2M1RQNG14?= =?utf-8?B?eFhwc05kOFVwa3FueU9OWXB4c3ZDUmIwRGFzQ09qVWF3U2JiUkNjVmNNLzlE?= =?utf-8?B?V3VNcXlwR2x3aVhVSXBuc1p2dUR6L3RCOEN4dXdCb0MzdUlyS25sNG9aVUts?= =?utf-8?B?d09uVnhlY0wvSTQyMU9ONU5qUTJYVTdVRkJlNkdyQXl4WnZnMTFOOUhRQkV4?= =?utf-8?B?d0pyUTJSY3QvK1hKelZqcldTajBuR1liZWtqUHcrT0I0RHAzVTJuRkNpU1pr?= =?utf-8?B?Z3BYd00wdnMxUXFzU3BPZmR1T2tyWkpFdWRjK3M3RzJXdTVmMm1FbVRLa3Bi?= =?utf-8?B?ZHBlTmU4ODRUQWw0NFNVOHhDbFRuZmVKbURHRFk5TmhEam9WYXJ0Q0IrUmpW?= =?utf-8?B?OEJIeGtBVVp1UTFPZlhGaEF0WlQyL2pCZmFqVEViUmxRcGZSQkYrcUpJbFNt?= =?utf-8?B?RCt6RytqMHV2QmlyUzBqSXczYkl2ZzJYWWpzdzU3UlRVOGl4bUVuOUFTdko4?= =?utf-8?B?NEVEa3JFd1lYS1VWWlJ5cUV6Q1A3WnUrdFlIOGtXbVBVUk5KU2ZuOEZBQ2FI?= =?utf-8?B?azNlNnRnQ1V1R3BZQnoyS1VHM3Q4UmpoQk55bGlZNE4xcFB1VkYwYVpXbjR1?= =?utf-8?B?K201UkpYOFJ6MEFqbEp1U0dXbW5KZlB3SmZDQ3djamFoSVRPTEUzTGxVM2xJ?= =?utf-8?B?cm5GbS9uQ3ZGN2xXekRJeVdKOWhEY1NnUjRLR3M3bXdpTHFMcFJkelFUOHpy?= =?utf-8?B?ZXZMQ1FPSTYwcXpvb0pVL1IxUUVhcGhvY2JsYjFidFdjNUY0RG91TnEvVmJL?= =?utf-8?B?V1l5OElJQVNMczRSN2pMVEtFOG5rdkNES0hjeDI4dzU0cUFhM2tPSHp6OElp?= =?utf-8?Q?ZD9an9vwhc6iQ4o7O7sdLPcfS?= Content-Type: text/plain; charset="utf-8" Content-ID: <48F5AA714F8BAE4F8386F60BF328D80E@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 9n1vybJ40N9m7G2ZMje5H/85HT+PSDUW/oYQdjhAIeBqu5lC3D2213sSOMbW/lFSFC3KDcLL2BnVo8mo6YLl8knT7VwrKMiIm5G7pCDfLV3Jqd9rg4jdjsiFTP6TTQlg8lx/loOBMftKaLGDw8aWxNeWGbZpt/Gtw1jbgoyWm1uR19BDjTl1x8dpTI1JHiC6/Lg71jdgm53aAtN/dAk79TpOMJ0uMCofl70X/ACV01Qc5hUj3eULc9tfESVPi9NsKPViJAv6xQS2wKIABQx9Q9po+6RS1OF2kMVsBE2456oVRUv7/ahcYEkw+H7F5yjgPAvFNq1D4DzVrj5QNfiSOBalMajgsXuBO7teFPfSKocvxLp5bY/Opxe9x6rTKv3YH/bjEmxfOoU17tqjRUTxiOsp5POKZz+bl54fbMEty75aPp0oGru7Jk5Adgmhk+/Zi0U+vV1hxq12K5aPTByhlafrcp//TatykzMBokCXSUsjCZ2pFhGtNSplXuOuPXrpy8DXHNAlX2n39KGDmpLE/au/aHNowI9vbd5Zp/lJgWfIOUaQH9HKEv7xBtNw90NDbUsGP4BVRjllFPVlbhpz4eWekDFyZKfey3d7YDxPvCOjhzNfnFEN/IeUcPs8DspJTdDWqV/M0TDdmhPIIJLRV2Zeo408zUUPp9zta6hrFVak+z3oQ13FugheTq8t4vJK03h1UbqAmo7DnpNRX3k9AwvsUCPcHyoVinJs7ZL53/SAkiJ6Ei+7+XFrfRUqgTaH8rutn7HWrUfXe0GlLcVdslas3x5vuX+QGdHRnSR7LIMgEmT+MfM6jasOT544sX6PIIvoI2fynq0DxXuX8PK3Dh9sSAaalEAdI+VqseoOpDUXSeo6jWzA+Hob7mq22V7u X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d5f58551-5bd6-4906-a271-08daed7c1c76 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jan 2023 11:17:33.5454 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xxgWUWNmWak2zgmNtbKYzkxQgFX1vJj1NxCItAISKkIlji4CITVaPEIDqYl1Zq8rzW5irqyCQBfsqXeLgRbuyh779uYgAy4aD88qaKeMfSU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5414 T24gMDEvMDEvMjAyMyAzOjEwIHBtLCBNYXJlayBNYXJjenlrb3dza2ktR8OzcmVja2kgd3JvdGU6 DQo+IE9uIFNhdCwgRGVjIDMxLCAyMDIyIGF0IDEyOjMwOjA3QU0gKzAwMDAsIEFuZHJldyBDb29w ZXIgd3JvdGU6DQo+PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L2NwdS9jb21tb24uYyBiL3hl bi9hcmNoL3g4Ni9jcHUvY29tbW9uLmMNCj4+IGluZGV4IGIzZmNmNDY4MGYzYS4uZDk2MmYzODRh OTk1IDEwMDY0NA0KPj4gLS0tIGEveGVuL2FyY2gveDg2L2NwdS9jb21tb24uYw0KPj4gKysrIGIv eGVuL2FyY2gveDg2L2NwdS9jb21tb24uYw0KPj4gQEAgLTM0NiwxMSArMzQ2LDE4IEBAIHZvaWQg X19pbml0IGVhcmx5X2NwdV9pbml0KHZvaWQpDQo+PiAgCSAgICAgICB4ODZfY3B1aWRfdmVuZG9y X3RvX3N0cihjLT54ODZfdmVuZG9yKSwgYy0+eDg2LCBjLT54ODYsDQo+PiAgCSAgICAgICBjLT54 ODZfbW9kZWwsIGMtPng4Nl9tb2RlbCwgYy0+eDg2X21hc2ssIGVheCk7DQo+PiAgDQo+PiAtCWlm IChjLT5jcHVpZF9sZXZlbCA+PSA3KQ0KPj4gLQkJY3B1aWRfY291bnQoNywgMCwgJmVheCwgJmVi eCwNCj4+ICsJaWYgKGMtPmNwdWlkX2xldmVsID49IDcpIHsNCj4+ICsJCXVpbnQzMl90IG1heF9z dWJsZWFmOw0KPj4gKw0KPj4gKwkJY3B1aWRfY291bnQoNywgMCwgJm1heF9zdWJsZWFmLCAmZWJ4 LA0KPj4gIAkJCSAgICAmYy0+eDg2X2NhcGFiaWxpdHlbRkVBVFVSRVNFVF83YzBdLA0KPj4gIAkJ CSAgICAmYy0+eDg2X2NhcGFiaWxpdHlbRkVBVFVSRVNFVF83ZDBdKTsNCj4+ICANCj4+ICsgICAg ICAgICAgICAgICAgaWYgKG1heF9zdWJsZWFmID49IDEpDQo+IHRhYnMgdnMgc3BhY2VzIC4uLg0K DQpGaXhlZC4NCg0KPg0KPiBJcyB0aGlzIGZpbGUgaW1wb3J0ZWQgZnJvbSBMaW51eD8gSXQgdXNl cyB0YWJzIGZvciBpbmRlbnRhdGlvbiwgY29udHJhcnkNCj4gdG8gdGhlIHJlc3Qgb2YgdGhlIFhl biBjb2RlIGJhc2UuDQoNCkl0IGlzIGEgZmlsZSB3aGljaCBvcmlnaW5hbGx5IGluaGVyaXRzIGZy b20gTGludXgsIGJ1dCBpdCBwcm9iYWJseSBoYXMNCn4wJSBpbiBjb21tb24gYW55IG1vcmUuLi4N Cg0KfkFuZHJldw0K From xen-devel-bounces@lists.xenproject.org Tue Jan 03 11:27:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 Jan 2023 11:27:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470585.730130 (Exim 4.92) (envelope-from ) id 1pCfRq-0004wi-Al; Tue, 03 Jan 2023 11:27:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470585.730130; Tue, 03 Jan 2023 11:27:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCfRq-0004wb-8B; Tue, 03 Jan 2023 11:27:14 +0000 Received: by outflank-mailman (input) for mailman id 470585; Tue, 03 Jan 2023 11:27:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCfRp-0004wR-HJ; Tue, 03 Jan 2023 11:27:13 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCfRp-0008Ai-9s; Tue, 03 Jan 2023 11:27:13 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCfRo-0004bX-P9; Tue, 03 Jan 2023 11:27:12 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pCfRo-0007bQ-OR; Tue, 03 Jan 2023 11:27:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=dZq4ag7xytgvKdQRS3T7T3mJLpMyuCfLdfvb2n15uLw=; b=R139uJuCzFzsVqYQROL3WYtgVN 1pktIqaTjGHmAcJETaLT0Rh97kip5kUkIqvef+yewBdrXV82QMMy8KKoCgPZWqCVwE+SIUhqEHgiS 3MZcvV+PHNx1m2e+bgPABQSIxvAr+Jcj+geSn0otneBrqR+72ruTHF2PSt2h7oV0Neds=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 175555: tolerable all pass - PUSHED X-Osstest-Failures: libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: libvirt=35afa1d2d6c10ce993c60caea1efe1c589fa1d5d X-Osstest-Versions-That: libvirt=0f2396751fccdc9f742230763880f70dbd977f3b From: osstest service owner Date: Tue, 03 Jan 2023 11:27:12 +0000 flight 175555 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/175555/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 175482 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 175482 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 175482 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: libvirt 35afa1d2d6c10ce993c60caea1efe1c589fa1d5d baseline version: libvirt 0f2396751fccdc9f742230763880f70dbd977f3b Last test of basis 175482 2022-12-24 04:20:18 Z 10 days Testing same since 175555 2023-01-03 04:20:26 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Martin Kletzander jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git 0f2396751f..35afa1d2d6 35afa1d2d6c10ce993c60caea1efe1c589fa1d5d -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue Jan 03 12:15:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 Jan 2023 12:15:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470597.730142 (Exim 4.92) (envelope-from ) id 1pCgCu-0001w4-4G; Tue, 03 Jan 2023 12:15:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470597.730142; Tue, 03 Jan 2023 12:15:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCgCu-0001vx-1T; Tue, 03 Jan 2023 12:15:52 +0000 Received: by outflank-mailman (input) for mailman id 470597; Tue, 03 Jan 2023 12:15:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCgCs-0001vr-Dq for xen-devel@lists.xenproject.org; Tue, 03 Jan 2023 12:15:50 +0000 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2051.outbound.protection.outlook.com [40.107.100.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5b3abe62-8b60-11ed-91b6-6bf2151ebd3b; Tue, 03 Jan 2023 13:15:48 +0100 (CET) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by MN2PR12MB4519.namprd12.prod.outlook.com (2603:10b6:208:262::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Tue, 3 Jan 2023 12:15:45 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::9856:da7:1ff1:d55c]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::9856:da7:1ff1:d55c%5]) with mapi id 15.20.5944.019; Tue, 3 Jan 2023 12:15:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5b3abe62-8b60-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OzTWRdHDNEkRNFp21ZBe0/CrTV3OnUHeiUI9GI6/E5Va7bmb9i1wSXznr0Mt0+tL5CTANP0pLt10rzywCVdPXdA1pkb60DtCn4Ev0hOrJ5QDvzwekihtgP6I9v+1Tyrn/30ZdYzTvmY4y5kS8rEQ9tC+rgCJHJB78cVBGoAK39pMG4tjDnuMZ776k+litqQDsGLrg5rHvPdA1GgJGBV0zVI8FsrWRwJowfmFjiWXrUzOQtd8FNbOByXKTpLUDJ5G4F0cCAdpE0GyQXFyia8L7cR6x4x8gzbwN1xVsFMO7zzvuQdpDeiLKFgJfYern5wkiftGEDM8YchAJsSMYAqzRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EJNCStJYDmn1oZ0E2+wobE6P7eaHGzm9mLkM3k1B11Q=; b=ffEGqKXZf9/kZ1vYJCYBrVsDq1kiF7yH0ZfoDwOecgS++dBwylOc1rYr6gN3OJ1tjU6KUEN6rFYDHcNn4QkAGBnKsOT/dDvHyWY6piNSn/l5jy3Ss+8e+G9LG19/r6pu0MnPHqfO0gVtTi33Qze7OTIodrjIskA1N/qZLn22YnCOknHt4mtHcHeyAOMfzS+Sp6Wmb/hy4nR4vDapJH5HLUGZnkVR+hv0JQnkSVfPERbk9HNUKGVViCye4IFYfIMRZD8NnyKt12EDKqf31AFu1fKlCf/BL640FvuTTLlX7HBoYFGscGcCaaqeZ0OZ+2TGpNfWZvUfTDajSN5uwPHrUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EJNCStJYDmn1oZ0E2+wobE6P7eaHGzm9mLkM3k1B11Q=; b=gKMgUB1asm1I9Da+ilboCNfSXeX0fiVkxurP6WF8wUUG0432YLprly1GLnBnL/oObPkvrFVoqmRLwD3RzULy90AUBo2kumJK6GG4mzDzuE3Cik59mSD2uAOsSPxLyGjW7DRDvqlBKhDxP2tSPmOIr69e1zUTDvyOvtfWavmjw5w= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <5dc9db0c-529a-3906-b866-2ec6e9efc27c@amd.com> Date: Tue, 3 Jan 2023 12:15:40 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2] xen/arm: Add 0x prefix when printing memory size in construct_domU To: xen-devel@lists.xenproject.org References: <20230103102519.26224-1-michal.orzel@amd.com> From: Ayan Kumar Halder In-Reply-To: <20230103102519.26224-1-michal.orzel@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0257.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8a::29) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|MN2PR12MB4519:EE_ X-MS-Office365-Filtering-Correlation-Id: 37134b9a-1b2e-4418-fcab-08daed843da3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2vGNH4WD9ABWvD1IGwYMBTEiS9dzNdYIYQswrBnNrkXzfAAoJWFjwPxfM6DR6Og46HHbjEyBFS5MNwYdV7SkwelizIwcSvmqWQwakiTymeEXhWhdSVkaw7iPM5LPYEK3yHP9ZyJZ7FpqAoQxJqDTasVvUjMehKhuI3Z4yq7dcnWEYyzto6n4LzsCaWi7o2p5UmKEaURbYM+x/mhsug0hOJ6JfoBTBHVVLl23yoCYMkNhdw566Kn6WcvWn59m0xYZsI+DM+z/Z/P8rzuQdmtugtGQ1WzX8+5pc8oKtGqcvr/iJ5xtkZA55Lziovrh/0rVqvzJv00P8pa7lU5IHTCvTs5sFV/cFNkyI1Mvh2WouiwzOD9KIjYnGgldrOwMyhYkXlGcEp9/8WU3GZR5+J8Jw6nLUHKTDZxjjCkFCOGut8RvPX9jnobsKRaPMC2MrlDZokaQk3ADVsO+zudljX3Y2+sDc0cKumARg71513wQDewO16RG1yo6JUIH488NOPfqzQZpngeUkFQ9mQ4ozkiY0KK+xgWozGzDsZYTvCcZrZJrXemJ1v0g7SxiHlxeAfMuR4Xs0Yy9Bi6mOp9XMZh0uflttrbNBAD4jiW0fW6Ot+nTw9hE1Ab3S1f09H2sLV1Wwb877AHgm5oHh7eGKZ6097czpCMDJy9tPtTXJZ0p96ruDPx/w4G0crUWKpVS+u7FNiXo/40hcOO16C8rnTuTtPVz7DOdDCiwufd3iF5cCazG1yhBfXJ71VbwU8XMTR2uI7MzuSNncywA0xLUvE/Niw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(376002)(136003)(366004)(396003)(451199015)(38100700002)(6916009)(36756003)(316002)(31696002)(2616005)(31686004)(53546011)(6486002)(478600001)(6506007)(6666004)(26005)(186003)(6512007)(2906002)(5660300002)(66946007)(41300700001)(66556008)(66476007)(8676002)(8936002)(83380400001)(22166006)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bk1MSFlCK3dwajhWTFplNkZTbFc5cllBVlhwSWJBUDc4aVFUcnVmSUNxMnF1?= =?utf-8?B?NjdrQWxIM2ZVSnBGUU5YRjJ6MmxtSEJQbFRMNFRPY0FkSDFnR0xlc3Vpc2pY?= =?utf-8?B?ZjR6am5ZMXFncmFLRE9vZVNZZEhsYVFzNDFPUjMwZURlUXJIZmthZktYYWVM?= =?utf-8?B?UEpwRjNsUTRZUXZaR2pnMktWeHd2K0JwMFUzbWN6NnQvZUd3VnhiTXh1Q0VP?= =?utf-8?B?WVZqNHY3aks5eC8rNlpTdCtkazRTRnJxTUZlNVNNc3UyVFZJcFRTS0ZSNGNB?= =?utf-8?B?K3N0b1dYUDUvZjNxWHFteTJLZEFjWmxuMnZPdVpHU2dWYmhib1o3Tk51QXRF?= =?utf-8?B?dWtxK0ZkcmZMMldreUdwQVo2eEJ4Mm9KbkFoWC9hZHg2K2FtUnd5Sk1WQ3Zn?= =?utf-8?B?Ukw0a0J0cjUwTDJNdGtRZ1BidzgxTVdxZFprbVRpeTVWdzArOHRJMEJNWFlB?= =?utf-8?B?eHY5NHZDVEtocmNBaERHRTc0aTk5WnF1RjNTWVBvRTFQVkpla1hmbG02bUsr?= =?utf-8?B?VzhVSitZVDFtUlp3NkE1N1h4VEsrb1dCa0RoMTlqYzloVklRTmFjMTNKbzE5?= =?utf-8?B?WXpjazRNUk11REJHK0lkQzhDZUFjU3FxV2wweitnaFY1aGtXN1NZV243Mzln?= =?utf-8?B?K0oxSjgxQTl5R1BJUFlhcjNETWtwNVdONjhyNTFxcnhTcU12TkQzVCtiamsr?= =?utf-8?B?ODlXb3gvUEU3Z3k3QzdRTDJkbUd3MmVwc1ByS1FKc3h4eE9nNDZPWlNnNEsx?= =?utf-8?B?cThZSHd0VmlYT2Rsa25aTUdRMncrSzJIMVNsT3ZDMG1MNHIvSjUzSzJ3NUJq?= =?utf-8?B?Vmt0SFRVRkZSdHJpaWcweFg4NVl3MjhJdjNWUHJYSTF5UmQ0MVk5NVRyNkMz?= =?utf-8?B?a0ptc2dFTXNjRFpqSU04UlovWTlwTlJmUVRGNzlOTGMvVzlYUGd1OWl5Qm5n?= =?utf-8?B?Q2tMc2s4eXNKbStSY0NoQ0llZW9uS0pPWHhTNlJKdE9FZGlvemd2VFV0T2V5?= =?utf-8?B?Z09zTW9PTnN4RXc0RDVYdUZnZU40YjlkczIyaC9WNEZNNElUdG9WeDZWS0N5?= =?utf-8?B?TEhPNFAwdExQWHB4VGovdENPUzRRRkpDdWMwTmpqTUc3dDMxd2VPVW5UZXFk?= =?utf-8?B?U2JmWjVWWU9iMGpUSTgwemhSS1VhQlNObExYN2xWR2tHeHFPZVNrb0VGQ28r?= =?utf-8?B?QXN4N3I4TXFWTGMxbVY5WjBsN1JjZkVOa1VHeW1wSG5nd3MzcVZlTmxTSGNE?= =?utf-8?B?dnBxVFVqY0dTL3F0bWpBNHhZWlYxNC81bUI1Tlg5K29CdzZ2SGdOMG1KODVC?= =?utf-8?B?ZEJuZDJSSWRzNXdLWDZ4R09CZDFwZ0U2NGM1LzhzZEV1OTBuVUZ2RkZiWW1v?= =?utf-8?B?OUVGeHV1dXRHU05FalhhSTRpUXVTRVVtbVAyR205TlU1YkoxS21pbmlYTmVu?= =?utf-8?B?bkdHQTJvcGFWU21kTldqeisvLzJvSGM2WkpHUm4zWXZLNGdzWTMrUnBsdVFD?= =?utf-8?B?U1MrUThpdTZNK3A4VlJHbXRoZ2NOYlVDUSswT1lMcDlmaGExSzJUcnBOWFc3?= =?utf-8?B?eUFTNFl3VHBKeE9RaVJ4QU44VXJIWlhLZ3JDUzhMWmFpdmJINVNDdUVnWjRt?= =?utf-8?B?NFkrdjZCMjZGM1BFTEMvRXBlZEVJOEtGOVR5cVBDaE0rZjBBd284NzhUWk5T?= =?utf-8?B?S1J5dzlmVDVGYzYyUlliYm83U3BWOWlybFAxWEo2eU1rUEE3U2RlZXREM3VT?= =?utf-8?B?MFZhQ2duOEFXSWRUbWtmRjY5ZnZyWDU3NzVWUG5NZkpEU05OSHpsdGJ6WVJ2?= =?utf-8?B?WEVibkN4cVNWOHdPVHRyVEpLOVBTZGxiZjFRdkIrY08vTkJWektEQ2RUalph?= =?utf-8?B?ZEtMNlI4RWU1N1hMdndKQlU2Qzd0dTdRODhYVjlCNFFLZnZLZTJXeDcwRGJy?= =?utf-8?B?b3B1NXRXcUtlTlpoQkh0TTM3QkVOUG1sRDh5WHZBYm5Fb2FrekVCcGNEUFBo?= =?utf-8?B?TCtCZ3hhU3RxNkpNZ054akRCeVhEYWc1bC9jM2pDMEFYMy9kNjlTZnpWbnow?= =?utf-8?B?SnR6dkxVUHRxc0VOTzdDeEkxQ2o2VjFHeFMxTmx5RW9kZjBLTzc0c3VSeUxv?= =?utf-8?Q?g4YvRrw5k1X7Sv9FLG3ayn5LZ?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 37134b9a-1b2e-4418-fcab-08daed843da3 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2023 12:15:45.4000 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NOkDQNSfwcKmREPZ2IP8NnpBw9wjEMpKW9MFGNlNorMex1cD+PT5ni404qw40D9xUmUoUawBA8vcOh+U+2tARg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4519 On 03/01/2023 10:25, Michal Orzel wrote: > Printing memory size in hex without 0x prefix can be misleading, so > add it. Also, take the opportunity to adhere to 80 chars line length > limit by moving the printk arguments to the next line. > > Signed-off-by: Michal Orzel Reviewed-by: Ayan Kumar Halder > --- > Changes in v2: > - was: "Print memory size in decimal in construct_domU" > - stick to hex but add a 0x prefix > - adhere to 80 chars line length limit > --- > xen/arch/arm/domain_build.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 829cea8de84f..f35f4d24569c 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -3774,7 +3774,8 @@ static int __init construct_domU(struct domain *d, > if ( rc != 0 ) > return rc; > > - printk("*** LOADING DOMU cpus=%u memory=%"PRIx64"KB ***\n", d->max_vcpus, mem); > + printk("*** LOADING DOMU cpus=%u memory=%#"PRIx64"KB ***\n", > + d->max_vcpus, mem); > > kinfo.vpl011 = dt_property_read_bool(node, "vpl011"); > From xen-devel-bounces@lists.xenproject.org Tue Jan 03 12:34:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 Jan 2023 12:34:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470604.730152 (Exim 4.92) (envelope-from ) id 1pCgV1-0004L4-M6; Tue, 03 Jan 2023 12:34:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470604.730152; Tue, 03 Jan 2023 12:34:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCgV1-0004Kx-JO; Tue, 03 Jan 2023 12:34:35 +0000 Received: by outflank-mailman (input) for mailman id 470604; Tue, 03 Jan 2023 12:34:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCgUz-0004Kr-Qq for xen-devel@lists.xenproject.org; Tue, 03 Jan 2023 12:34:34 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2049.outbound.protection.outlook.com [40.107.22.49]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f898d381-8b62-11ed-91b6-6bf2151ebd3b; Tue, 03 Jan 2023 13:34:31 +0100 (CET) Received: from DB8PR06CA0033.eurprd06.prod.outlook.com (2603:10a6:10:100::46) by DB5PR08MB9998.eurprd08.prod.outlook.com (2603:10a6:10:489::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.14; Tue, 3 Jan 2023 12:34:28 +0000 Received: from DBAEUR03FT053.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:100:cafe::bb) by DB8PR06CA0033.outlook.office365.com (2603:10a6:10:100::46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5966.19 via Frontend Transport; Tue, 3 Jan 2023 12:34:28 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT053.mail.protection.outlook.com (100.127.142.121) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5966.18 via Frontend Transport; Tue, 3 Jan 2023 12:34:28 +0000 Received: ("Tessian outbound 0d7b2ab0f13d:v132"); Tue, 03 Jan 2023 12:34:28 +0000 Received: from c3ea07c5858d.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 6B79D49D-969C-46E7-8BC8-BCB82A3C1FFD.1; Tue, 03 Jan 2023 12:34:18 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c3ea07c5858d.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 03 Jan 2023 12:34:18 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by GV2PR08MB9254.eurprd08.prod.outlook.com (2603:10a6:150:e3::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.14; Tue, 3 Jan 2023 12:34:13 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::1909:220b:70ee:a5c3]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::1909:220b:70ee:a5c3%7]) with mapi id 15.20.5986.009; Tue, 3 Jan 2023 12:34:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f898d381-8b62-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m+pfp5dyoybtMDi34WVwk5cS65qgk7w5i6y4Bj/H1fk=; b=HH2QYVWclhr8Zi1UnQOnHd37puEZQsT3yPr+SNs437Z6pj8WoMh2t91ThJNMPS7klO/kM+mGQpEpTmdlCp/VZuldeSk+reCU5Fgkp939KagBGXJbup2o78MVfhzWHoKByKF0RQI3m36eesYaU0pRd9VZm3HqT5CXXc9IYjpDNRc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: f9841ea2b83a4b58 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mGyWvN1Jxz7/JdAk8PoMjPF5jyp4NFdHW7iCHXDj9iHzfv8ozcfcfjktSwPEl/5y2nzdhNrvlRs9xK+KpXxSKovDR2nJUgJDkBb6cUIHx674IEv52CBUzio3Yt9NEmHHzAGCgAJr+y6k1dBi1kY1BSAZBpaw29TAGwku+uGsSHAIOyxDi80X2TLhD/GbnrSmBh4MAXEgeDffaZ0RSpEuyCnIVuMQIwNBHHQthRX/u+jjjZUzjHSD5z0fIrU7db1Bc5qy++pJEpLeBJlH273H58FyUyGZmPNn/FILatWQWI0vbuYd+6XmnGyYwg0sAnUurLc4dvCzBm2zEbtWgWpsRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=m+pfp5dyoybtMDi34WVwk5cS65qgk7w5i6y4Bj/H1fk=; b=Sl2CjsljSdXzfel8aHYM+p46t4PfxwenM1RGXVdYwhb+lf3CZxlnkVLJEJHVxChH1JbmpZ7PbaoTAIVOLruyVRAegCNO+0txtRLCAvg6GtqfntBmaQF95ESemAKRvUU7Z9Z4amJTDbu+6Ox4SnmJVClmX0kbLLtRwWYOfuTgR5MtYsGCJcKfP+RADmfT3iDaTtZKqh+xSkNpER3qGX4oc3jgaSttWpCvkWUKGUGbOLOzljvrJdmtbGvo1LVEcv7k/CWXL8lrgbYWm+ZqRGxaNN5xD99Adt64uVNx75uQS1lNyf6hB0UP+i7xXzLMky6p0N9k9yCreQrZyX7CHQ2Hjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m+pfp5dyoybtMDi34WVwk5cS65qgk7w5i6y4Bj/H1fk=; b=HH2QYVWclhr8Zi1UnQOnHd37puEZQsT3yPr+SNs437Z6pj8WoMh2t91ThJNMPS7klO/kM+mGQpEpTmdlCp/VZuldeSk+reCU5Fgkp939KagBGXJbup2o78MVfhzWHoKByKF0RQI3m36eesYaU0pRd9VZm3HqT5CXXc9IYjpDNRc= From: Bertrand Marquis To: Stefano Stabellini CC: Julien Grall , Henry Wang , Wei Chen , Volodymyr Babchuk , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in arch_domain_create() Thread-Topic: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in arch_domain_create() Thread-Index: AQHY36RTFiJSG85qSUCZzK4infnuWq4NsO2AgAANc4CAAYyLAIBUWeeAgAKahgCAADe5AIAmqQKA Date: Tue, 3 Jan 2023 12:34:12 +0000 Message-ID: References: <20221014080917.14980-1-Henry.Wang@arm.com> <9d5ab09e-650f-118d-0233-d7988f1504f1@xen.org> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|GV2PR08MB9254:EE_|DBAEUR03FT053:EE_|DB5PR08MB9998:EE_ X-MS-Office365-Filtering-Correlation-Id: 56858e94-17c4-4f85-73fd-08daed86dafa x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: adYc2ewzfsaYEgPg+LmehYT9Rz03VERxxxR2J8DWj2ZTEuCNtZDv6ow95LqpEwmhDFEx7NplCOeE5XCUI8uO4IeUqOWmpzJ7Zr2QOD6xcnCONqxHWqgVwFBWBKL69BNuswteTXO0KOgQYsdr9JRy1ivSGKRulf/xAFSKoZCEZOjbAa5uLB/F0IvKoTN1Y8J4YoUNi1lkkNO6rU4p2TubsHSsvcCJvxwG+1zQVOMinRG2j/Jr/ZtecjGa4HOErPJ83QZ/Co7VDZIGY9aFoFRHrS3V5XEdj1XgPdg0Rwds7HELxQmknLsf9iWZAP4SDVpFSLF21rCMdyMYtFCRuTWIjDbv4tnHOWF4Z7G9Cp0Pc09dDJxqd+y0QTn7fND6/mVFlE8m94SImAjtThMxL/zv0CeSE41bJVCPSz97dtNsobcNg8rdeHy+UcG/FIif/YRd9QGNoDkwIbl6zp8eAmxioTclVZQurz9bWUrpPDo6okY9Rg64oLP5rbU83xbivB9mR9zyU1gFOm7ZYBRt/24mdGRfM4CoXlCnw/3k/tgaQawraRCF1ujaIR0Zmzgk3wtDq7sGjS2KGRB27Up6ZQg5RXAijwCclbHUCqv3ZMrbAEkNAo0CUExpWLAFSMnLir9laHINaVCjURkIsLvAW0xOlp+Yb+mf7OSVnpRx6d6XnJgWuQmUeQRFtbB8ZkPCK+UhFh8hnMn/1jUSbaZjAxMdcCd0e6koR6w8iC+E0FLrzKVipSPAa3Y16nFheJe73dqHHaweTbuECglF8yLlcz3TUw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(39860400002)(396003)(366004)(346002)(451199015)(66899015)(36756003)(86362001)(4326008)(6916009)(41300700001)(54906003)(91956017)(66946007)(38070700005)(66556008)(66446008)(66476007)(8676002)(76116006)(64756008)(38100700002)(122000001)(33656002)(26005)(53546011)(6486002)(186003)(71200400001)(6512007)(478600001)(2906002)(8936002)(5660300002)(6506007)(316002)(83380400001)(2616005)(22166006)(45980500001);DIR:OUT;SFP:1101; Content-Type: multipart/alternative; boundary="_000_A52E1C0940F1416CA0852F2320EE69EAarmcom_" MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB9254 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT053.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 8d182304-f1a0-42ba-c491-08daed86d187 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sfnrfhc6gvWXsK4ic9EbnnT7yLcF1t4OC4TvZluKsAbrNy3EwXiSaCQuTgVZv+e5HwJQY6hFqtSFs/xC1TIiRiQfsX3/hlZQ/9189LalP5oe9OcdTAcApZRoS0W/7ypw0yZmlbx8bPMdf4VVGA22DLprAjnfGX7ONylHwM5fPOHxEUMX421WV3FEebNe+E64oV0K4FEtns2MB9o2cqHy0x1oNtO4DVZsE5/sJep4nqU8Tx8vSutzxB5SbocSDq8X7NeNZPU/MNyT430u/TFhQinlaPA7dFBUlzn1f0QCZtYWZvEQGdjqDTrk4H9llW8NXpVZpVOKvadd8Przp4zPm7fyZLO7xjpKsADqltiJ2W4nPReWlDGCrz8bpzsLBPQhYFJFCvEMJ3RAKkYClzbhq4luR9qsKCMDopBOgIlAdIuK5bVSqQNxmEt46ZjL6dkwHQQ495iSlCKRe0lbkha0KvRfFikl4MRpUZlGUyXHRxD2bw58InuCDymGQVLJX1fFcDKOwdD36/Lkz2+WfEIlSAcgPaPCtPNEMSGL16F9BjYY+YhiZfVYk/vrQxbdVjrRVZgBKHSIoA3sDdy+uTQJdvBR+g62naJjfi67/g6ioB83AfIXRCgBGttWGTXe6jP3N95bWcIjoEMZgbjqklLelu9pk//JnSj/TZzbokaNFMZ/vPmSgOquDDeN94qmGz6/mVTBgpPiBijfRRCFO1JWm9Q80y2F36Zn0tldewPPow8= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(39850400004)(136003)(346002)(376002)(451199015)(36840700001)(40470700004)(46966006)(33656002)(36756003)(81166007)(356005)(8936002)(82740400003)(6862004)(5660300002)(41300700001)(83380400001)(47076005)(36860700001)(86362001)(2906002)(82310400005)(6486002)(70586007)(54906003)(45080400002)(66899015)(70206006)(6506007)(53546011)(40480700001)(40460700003)(478600001)(8676002)(4326008)(316002)(336012)(2616005)(6512007)(186003)(26005)(22166006);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2023 12:34:28.1593 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 56858e94-17c4-4f85-73fd-08daed86dafa X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT053.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR08MB9998 --_000_A52E1C0940F1416CA0852F2320EE69EAarmcom_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi, Sorry for the delay but I have very limited access to my mails right now. On 9 Dec 2022, at 23:11, Stefano Stabellini > wrote: On Fri, 9 Dec 2022, Julien Grall wrote: Hi Henry, On 08/12/2022 03:06, Henry Wang wrote: I am trying to work on the follow-up improvements about the Arm P2M code, and while trying to address the comment below, I noticed there was an unfinished discussion between me and Julien which I would like to continue and here opinions from all of you (if possible). -----Original Message----- From: Julien Grall > Subject: Re: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in arch_domain_create() I also noticed that relinquish_p2m_mapping() is not called. This should be fine for us because arch_domain_create() should never create a mapping that requires p2m_put_l3_page() to be called. For the background of the discussion, this was about the failure path of arch_domain_create(), where we only call p2m_final_teardown() which does not call relinquish_p2m_mapping()... So all this mess with the P2M is necessary because we are mapping the GICv2 CPU interface in arch_domain_create(). I think we should consider to defer = the mapping to later. Other than it makes the code simpler, it also means we could also the P2M r= oot on the same numa node the domain is going to run (those information are pas= sed later on). There is a couple of options: 1. Introduce a new hypercall to finish the initialization of a domain (e.g. allocating the P2M and map the GICv2 CPU interface). This option was briefl= y discussed with Jan (see [2])./ 2. Allocate the P2M when populate the P2M pool and defer the GICv2 CPU interface mapping until the first access (similar to how with deal with MMI= O access for ACPI). I find the second option is neater but it has the drawback that it requires= on more trap to the hypervisor and we can't report any mapping failure (which should not happen if the P2M was correctly sized). So I am leaning towards option 2. Any opinions? Option 1 is not great due to the extra hypercall. But I worry that option 2 might make things harder for safety because the mapping/initialization becomes "dynamic". I don't know if this is a valid concern. I would love to hear Bertrand's thoughts about it. Putting him in To: How option 1 would work for dom0less ? Option 2 would make safety more challenging but not impossible (we have a l= ot of other use cases where we cannot map everything on boot). I would vote for option 2 as I think we will not certify gicv2 and it is no= t adding an other hyper call. Cheers Bertrand --_000_A52E1C0940F1416CA0852F2320EE69EAarmcom_ Content-Type: text/html; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable Hi,

Sorry for the delay but I have very limited access to my ma= ils right now.

On 9 Dec 2022, at 23:11, Stefano Stabellini <sstabellini@kernel.org> wr= ote:

On Fri, 9 Dec 2022, Julien Grall wrote:
Hi Henry,

On 08/12/2022 03:06, Henry Wang wrote:
I am trying to work on the follow-up i= mprovements about the Arm P2M code,
and while trying to address the comment below, I noticed there was an
unfinished
discussion between me and Julien which I would like to continue and here opinions from all of you (if possible).

-----Original Message-----
From: Julien Grall <julien@= xen.org>
Subject: Re: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in arch_domain_create()
I also noticed that relinquish_p2m_map= ping() is not called. This
should
be fine for us because arch_domain_create() should never create a
mapping that requires p2m_put_l3_page() to be called.

For the background of the discussion, this was about the failure path of arch_domain_create(), where we only call p2m_final_teardown() which does not call relinquish_p2m_mapping()...
So all this mess with the P2M is necessary because we are mapping the GICv2=
CPU interface in arch_domain_create(). I think we should consider to defer = the
mapping to later.

Other than it makes the code simpler, it also means we could also the P2M r= oot
on the same numa node the domain is going to run (those information are pas= sed
later on).

There is a couple of options:
1. Introduce a new hypercall to finish the initialization of a domain (e.g.=
allocating the P2M and map the GICv2 CPU interface). This option was briefl= y
discussed with Jan (see [2])./
2. Allocate the P2M when populate the P2M pool and defer the GICv2 CPU
interface mapping until the first access (similar to how with deal with MMI= O
access for ACPI).

I find the second option is neater but it has the drawback that it requires= on
more trap to the hypervisor and we can't report any mapping failure (which<= br class=3D""> should not happen if the P2M was correctly sized). So I am leaning towards<= br class=3D""> option 2.

Any opinions?

Option 1 is not great due to the extra hypercall. But I worry that
option 2 might make things harder for safety because the
mapping/initialization becomes "dynamic". I don't know if this is a
valid concern.

I would love to hear Bertrand's thoughts about it. Putting him in To:=

How option 1 would work for dom0less ?

Option 2 would make safety more challenging but not impossible (we hav= e a lot of other use cases where we cannot map everything on boot).

I would vote for option 2 as I think we will not certify gicv2 and it = is not adding an other hyper call.

Cheers
Bertrand


--_000_A52E1C0940F1416CA0852F2320EE69EAarmcom_-- From xen-devel-bounces@lists.xenproject.org Tue Jan 03 13:02:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 Jan 2023 13:02:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470615.730163 (Exim 4.92) (envelope-from ) id 1pCgwG-0007mk-Um; Tue, 03 Jan 2023 13:02:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470615.730163; Tue, 03 Jan 2023 13:02:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCgwG-0007md-S7; Tue, 03 Jan 2023 13:02:44 +0000 Received: by outflank-mailman (input) for mailman id 470615; Tue, 03 Jan 2023 13:02:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCgwF-0007l1-8g for xen-devel@lists.xenproject.org; Tue, 03 Jan 2023 13:02:43 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e58a8ef3-8b66-11ed-b8d0-410ff93cb8f0; Tue, 03 Jan 2023 14:02:39 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e58a8ef3-8b66-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1672750959; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=q3pBHOUVWnIYdWgJPflbM7j5UuiigUvRijYwk8CcALY=; b=Y+L66T8d29bwOBvqTqhebby2KXA8TbrA2Y4g3o0Z66L2hJ23k4uujweF Clcb2od2n8Ab5buAbi4v1N0oPCrH0J5JWjh05/yUmE6aZaLKERtUVfcVc 9zUcMK6uh9qqF5O4RLyDbiyKedfeo1VNJ0lAVH/fO/3OE8r1mqliSB4gr 8=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 89911226 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:D7kuqKjbAIKAlgz3YuoRr//OX161qBAKZh0ujC45NGQN5FlHY01je htvWWmGM/iCN2XxedBxad+/o0xTusfSnIBnQFZs+HwwFCob9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmUpH1QMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWs0N8klgZmP6sT5QeFzyN94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQ6cmo0RCGJodirg/WHFdhIgYcFFsDCadZ3VnFIlVk1DN4jSJHHBa7L+cVZzHE7gcUm8fT2P pRDL2A1NVKZPkMJagx/5JEWxY9EglHHficeglORvqcf6GnP1g1hlrPqNbI5f/TaFJQMxxzC+ Aoq+UypAi88bv6RzgDcrHGC2bCUoSChB6ANQejQGvlC3wTImz175ActfUCgvfCzh0q6WtReA 08Z4Cwjqe417kPDZt75Uh6jqXiIpCkASsFQGO037gKK4qfM6gPfDW8BJhZRZdpjuMIoSDgC0 l6Sg8ivFTFpqKeSS3+W6vGTtzzaESwUK3ISICwJVw0I5/H9r4wpyBHCVNBuFOiylNKdMTP/2 TeRtwAlmq4ey8UM0s2GEUvv2mz24MKTF0hsu1uRDjnNAh5FiJCNRdby0HLq59B6McXecgawm H9HvfKXxbVbZX2SrxClTOIIFbCvwv+KNjzAnFJid6UcGySRF22LJt4JvmwnTKt9GoNdIGKyP heP0e9EzMULVEZGe5ObdG5Y5y4C6aH7XeroWfnPBjalSsggLVTXlM2CiKP54owMrKTOuftjU Xt4WZz2ZZr/NUiA5GTeegvl+eV3rh3SPEuKLXwB8zyp0KCFeFmeQqofPV2FY4gRtf3b+luFr 4oBa5bVkH2ztdEShQGOqOYuwa0idyBnVfgaVeQNHgJ8HuaWMD54UKKAqV/QU4dkg75Uho/1w 51JYWcBkACXrSSeeW23hoVLNOuHsWBX8ShqYkTB/D+AhxAeXGpYxP1PLMZvJOJ6rLELIDwdZ 6BtRvhsy89nElzvkwnxp7GmxGC+XHxHXT6zAhc= IronPort-HdrOrdr: A9a23:Va8EVat2YcnzdA9hxSrePiDE7skDzdV00zEX/kB9WHVpmwKj9v xG+85rsyMc6QxhP03I/OrrBEDuex7hHPJOjbX5eI3SPzUPVgOTXf1fBMjZskDd8xSXzJ8j6U 4YSdkBNDSTNzhHZLfBkW2F+o0bsaC6GcmT7I+0854ud3AJV0gH1WhE422gYyhLrWd9a6bRPa Dsl/Zvln6PeWk3cs/+PXUMRe7Fzue77q7OUFopBwMH9ALLtj+j6Kf7Hx+Ety1uKA9n8PMN8X Xljwe83amos+i6xhjAk0ff4o9bgsGJ8KoyOOW8zuYUNxTxgUKTaINtV6bqhkFMnN2S X-IronPort-AV: E=Sophos;i="5.96,297,1665460800"; d="scan'208";a="89911226" From: Per Bilse To: CC: Per Bilse , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , "moderated list:XEN HYPERVISOR INTERFACE" Subject: [PATCH v3] drivers/xen/hypervisor: Expose Xen SIF flags to userspace Date: Tue, 3 Jan 2023 13:02:13 +0000 Message-ID: <20230103130213.2129753-1-per.bilse@citrix.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain /proc/xen is a legacy pseudo filesystem which predates Xen support getting merged into Linux. It has largely been replaced with more normal locations for data (/sys/hypervisor/ for info, /dev/xen/ for user devices). We want to compile xenfs support out of the dom0 kernel. There is one item which only exists in /proc/xen, namely /proc/xen/capabilities with "control_d" being the signal of "you're in the control domain". This ultimately comes from the SIF flags provided at VM start. This patch exposes all SIF flags in /sys/hypervisor/start_flags/ as boolean files, one for each bit, returning '1' if set, '0' otherwise. Two known flags, 'privileged' and 'initdomain', are explicitly named, and all remaining flags can be accessed via generically named files, as suggested by Andrew Cooper. Signed-off-by: Per Bilse --- v2: minor fix to layout, incorporate suggestions from Juergen Gross v3: update assumed availability in documentation --- Documentation/ABI/stable/sysfs-hypervisor-xen | 13 ++++ drivers/xen/sys-hypervisor.c | 69 +++++++++++++++++-- 2 files changed, 78 insertions(+), 4 deletions(-) diff --git a/Documentation/ABI/stable/sysfs-hypervisor-xen b/Documentation/ABI/stable/sysfs-hypervisor-xen index 748593c64568..be9ca9981bb1 100644 --- a/Documentation/ABI/stable/sysfs-hypervisor-xen +++ b/Documentation/ABI/stable/sysfs-hypervisor-xen @@ -120,3 +120,16 @@ Contact: xen-devel@lists.xenproject.org Description: If running under Xen: The Xen version is in the format . This is the part of it. + +What: /sys/hypervisor/start_flags/* +Date: March 2023 +KernelVersion: 6.3.0 +Contact: xen-devel@lists.xenproject.org +Description: If running under Xen: + All bits in Xen's start-flags are represented as + boolean files, returning '1' if set, '0' otherwise. + This takes the place of the defunct /proc/xen/capabilities, + which would contain "control_d" on dom0, and be empty + otherwise. This flag is now exposed as "initdomain" in + addition to the "privileged" flag; all other possible flags + are accessible as "unknownXX". diff --git a/drivers/xen/sys-hypervisor.c b/drivers/xen/sys-hypervisor.c index fcb0792f090e..f5460b34ae6f 100644 --- a/drivers/xen/sys-hypervisor.c +++ b/drivers/xen/sys-hypervisor.c @@ -31,7 +31,10 @@ struct hyp_sysfs_attr { struct attribute attr; ssize_t (*show)(struct hyp_sysfs_attr *, char *); ssize_t (*store)(struct hyp_sysfs_attr *, const char *, size_t); - void *hyp_attr_data; + union { + void *hyp_attr_data; + unsigned long hyp_attr_value; + }; }; static ssize_t type_show(struct hyp_sysfs_attr *attr, char *buffer) @@ -399,6 +402,60 @@ static int __init xen_sysfs_properties_init(void) return sysfs_create_group(hypervisor_kobj, &xen_properties_group); } +#define FLAG_UNAME "unknown" +#define FLAG_UNAME_FMT FLAG_UNAME "%02u" +#define FLAG_UNAME_MAX sizeof(FLAG_UNAME "XX") +#define FLAG_COUNT (sizeof(xen_start_flags) * BITS_PER_BYTE) +static_assert(sizeof(xen_start_flags) + <= sizeof_field(struct hyp_sysfs_attr, hyp_attr_value)); + +static ssize_t flag_show(struct hyp_sysfs_attr *attr, char *buffer) +{ + char *p = buffer; + + *p++ = '0' + ((xen_start_flags & attr->hyp_attr_value) != 0); + *p++ = '\n'; + return p - buffer; +} + +#define FLAG_NODE(flag, node) \ + [ilog2(flag)] = { \ + .attr = { .name = #node, .mode = 0444 },\ + .show = flag_show, \ + .hyp_attr_value = flag \ + } + +/* + * Add new, known flags here. No other changes are required, but + * note that each known flag wastes one entry in flag_unames[]. + * The code/complexity machinations to avoid this isn't worth it + * for a few entries, but keep it in mind. + */ +static struct hyp_sysfs_attr flag_attrs[FLAG_COUNT] = { + FLAG_NODE(SIF_PRIVILEGED, privileged), + FLAG_NODE(SIF_INITDOMAIN, initdomain) +}; +static struct attribute_group xen_flags_group = { + .name = "start_flags", + .attrs = (struct attribute *[FLAG_COUNT + 1]){} +}; +static char flag_unames[FLAG_COUNT][FLAG_UNAME_MAX]; + +static int __init xen_sysfs_flags_init(void) +{ + for (unsigned fnum = 0; fnum != FLAG_COUNT; fnum++) { + if (likely(flag_attrs[fnum].attr.name == NULL)) { + sprintf(flag_unames[fnum], FLAG_UNAME_FMT, fnum); + flag_attrs[fnum].attr.name = flag_unames[fnum]; + flag_attrs[fnum].attr.mode = 0444; + flag_attrs[fnum].show = flag_show; + flag_attrs[fnum].hyp_attr_value = 1 << fnum; + } + xen_flags_group.attrs[fnum] = &flag_attrs[fnum].attr; + } + return sysfs_create_group(hypervisor_kobj, &xen_flags_group); +} + #ifdef CONFIG_XEN_HAVE_VPMU struct pmu_mode { const char *name; @@ -539,18 +596,22 @@ static int __init hyper_sysfs_init(void) ret = xen_sysfs_properties_init(); if (ret) goto prop_out; + ret = xen_sysfs_flags_init(); + if (ret) + goto flags_out; #ifdef CONFIG_XEN_HAVE_VPMU if (xen_initial_domain()) { ret = xen_sysfs_pmu_init(); if (ret) { - sysfs_remove_group(hypervisor_kobj, - &xen_properties_group); - goto prop_out; + sysfs_remove_group(hypervisor_kobj, &xen_flags_group); + goto flags_out; } } #endif goto out; +flags_out: + sysfs_remove_group(hypervisor_kobj, &xen_properties_group); prop_out: sysfs_remove_file(hypervisor_kobj, &uuid_attr.attr); uuid_out: -- 2.31.1 From xen-devel-bounces@lists.xenproject.org Tue Jan 03 13:17:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 Jan 2023 13:17:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470621.730175 (Exim 4.92) (envelope-from ) id 1pChAW-0000uM-7s; Tue, 03 Jan 2023 13:17:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470621.730175; Tue, 03 Jan 2023 13:17:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pChAW-0000uF-53; Tue, 03 Jan 2023 13:17:28 +0000 Received: by outflank-mailman (input) for mailman id 470621; Tue, 03 Jan 2023 13:17:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pChAV-0000u9-He for xen-devel@lists.xenproject.org; Tue, 03 Jan 2023 13:17:27 +0000 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [2a00:1450:4864:20::329]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f673d0b5-8b68-11ed-b8d0-410ff93cb8f0; Tue, 03 Jan 2023 14:17:24 +0100 (CET) Received: by mail-wm1-x329.google.com with SMTP id p1-20020a05600c1d8100b003d8c9b191e0so23054738wms.4 for ; Tue, 03 Jan 2023 05:17:24 -0800 (PST) Received: from [192.168.30.216] ([81.0.6.76]) by smtp.gmail.com with ESMTPSA id r17-20020a05600c425100b003cffd3c3d6csm40171333wmm.12.2023.01.03.05.17.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Jan 2023 05:17:23 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f673d0b5-8b68-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+6FCYc7IsbLXUkXo08SQ4GUWBR9iGC2Xzf9FolVUtRo=; b=n/56VD4IRMp0yuUVG73jhVPdUgXayuZx4giEfUZ8VLgAAnbQZeIuIvQcokB2wptb6k roMl4LNuBykQy/MpusQOu0PMAW1zy6KpNMcCebcpS9DCuAqDne0+v68abElKm/+c9PGX 5deJomEDWCynXEAQCe2GxPFbAKq3knf/Q0Vi2APEhmyoBGnSpcnvaiXifXNt7MFWuLtI CYdI4jO0cRMmDBNHyzsDW6aehiMZJ7lHGoG9Mw1g3tBw2z61ryhoGk+Eml41wavMKgNr 3jQc0/MkoQeBHxtCrcfilhHCmnRLxA8ZrtYjJvD3vWgTfxcPoCHF0jAIAEkIpPZNbsBN AdAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+6FCYc7IsbLXUkXo08SQ4GUWBR9iGC2Xzf9FolVUtRo=; b=DIgZrvcbTihimYS6Pc/U3JE+nIRpF4Cyp7Qs+KLLG0IegroKrqKw80gzRDYiJaYwbM kzjd9Pzn865w5K0BlWo29hijZ0dPchQtS1yPlZl2Z5Kwg8XBFpIm1ePUqjeRg0Q/t211 3lTDKkP4GrMftcqmSyXrzTtkee+VgOLscLcRVaR7sOElR7m2jX5ay0gBg5jwSAD/cpeZ jp0j91xrhXeKgDdNFoMtDv7ihed3rXsjPAJBcR7hyoa7Fti+9ir+XcraLFcGi/xxBeG8 Gou/OOlwwAQ00c6KU4mZnr6r+ZuEweQmqugD6cM7kFPk6L+EFfq5uECH5YPhAF4xkicM CHew== X-Gm-Message-State: AFqh2kobLcBRJp5YBSA9+KTFBrM2X7a4gkbGOvt/bA0mniOqg8XBJlE7 WZmY02M4mWDXmJFvbHePXPJHbA== X-Google-Smtp-Source: AMrXdXtKrBI9NGgAUmqiWfEI2RGlGcbNiSC2hdExF6pkPz5b4Eg0tXIw6L8+2KPWlNKYtW4NbzL5LQ== X-Received: by 2002:a05:600c:4255:b0:3d3:3d34:5d63 with SMTP id r21-20020a05600c425500b003d33d345d63mr32744520wmm.8.1672751844305; Tue, 03 Jan 2023 05:17:24 -0800 (PST) Message-ID: <0de699a7-98b8-e320-da4d-678d0f594213@linaro.org> Date: Tue, 3 Jan 2023 14:17:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 0/6] Resolve TYPE_PIIX3_XEN_DEVICE Content-Language: en-US To: Chuck Zmudzinski , Bernhard Beschow , qemu-devel@nongnu.org Cc: Paul Durrant , Marcel Apfelbaum , "Michael S. Tsirkin" , Stefano Stabellini , Anthony Perard , Aurelien Jarno , Eduardo Habkost , xen-devel@lists.xenproject.org, =?UTF-8?Q?Herv=c3=a9_Poussineau?= , Paolo Bonzini , Richard Henderson References: <20230102213504.14646-1-shentey@gmail.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Chuck, On 3/1/23 04:15, Chuck Zmudzinski wrote: > On 1/2/23 4:34 PM, Bernhard Beschow wrote: >> This series first renders TYPE_PIIX3_XEN_DEVICE redundant and finally removes >> it. The motivation is to 1/ decouple PIIX from Xen and 2/ to make Xen in the PC >> machine agnostic to the precise southbridge being used. 2/ will become >> particularily interesting once PIIX4 becomes usable in the PC machine, avoiding >> the "Frankenstein" use of PIIX4_ACPI in PIIX3. >> >> Testing done: >> None, because I don't know how to conduct this properly :( >> >> Based-on: <20221221170003.2929-1-shentey@gmail.com> >> "[PATCH v4 00/30] Consolidate PIIX south bridges" This series is based on a previous series: https://lore.kernel.org/qemu-devel/20221221170003.2929-1-shentey@gmail.com/ (which itself also is). >> Bernhard Beschow (6): >> include/hw/xen/xen: Make xen_piix3_set_irq() generic and rename it >> hw/isa/piix: Reuse piix3_realize() in piix3_xen_realize() >> hw/isa/piix: Wire up Xen PCI IRQ handling outside of PIIX3 >> hw/isa/piix: Avoid Xen-specific variant of piix_write_config() >> hw/isa/piix: Resolve redundant k->config_write assignments >> hw/isa/piix: Resolve redundant TYPE_PIIX3_XEN_DEVICE >> >> hw/i386/pc_piix.c | 34 ++++++++++++++++-- >> hw/i386/xen/xen-hvm.c | 9 +++-- >> hw/isa/piix.c | 66 +---------------------------------- > > This file does not exist on the Qemu master branch. > But hw/isa/piix3.c and hw/isa/piix4.c do exist. > > I tried renaming it from piix.c to piix3.c in the patch, but > the patch set still does not apply cleanly on my tree. > > Is this patch set re-based against something other than > the current master Qemu branch? > > I have a system that is suitable for testing this patch set, but > I need guidance on how to apply it to the Qemu source tree. You can ask Bernhard to publish a branch with the full work, or apply each series locally. I use the b4 tool for that: https://b4.docs.kernel.org/en/latest/installing.html i.e.: $ git checkout -b shentey_work $ b4 am 20221120150550.63059-1-shentey@gmail.com $ git am ./v2_20221120_shentey_decouple_intx_to_lnkx_routing_from_south_bridges.mbx $ b4 am 20221221170003.2929-1-shentey@gmail.com $ git am ./v4_20221221_shentey_this_series_consolidates_the_implementations_of_the_piix3_and_piix4_south.mbx $ b4 am 20230102213504.14646-1-shentey@gmail.com $ git am ./20230102_shentey_resolve_type_piix3_xen_device.mbx Now the branch 'shentey_work' contains all the patches and you can test. Regards, Phil. From xen-devel-bounces@lists.xenproject.org Tue Jan 03 13:20:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 Jan 2023 13:20:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470629.730186 (Exim 4.92) (envelope-from ) id 1pChDO-0002Ik-N5; Tue, 03 Jan 2023 13:20:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470629.730186; Tue, 03 Jan 2023 13:20:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pChDO-0002Id-JQ; Tue, 03 Jan 2023 13:20:26 +0000 Received: by outflank-mailman (input) for mailman id 470629; Tue, 03 Jan 2023 13:20:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pChDN-0002IX-5Y for xen-devel@lists.xenproject.org; Tue, 03 Jan 2023 13:20:25 +0000 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [2a00:1450:4864:20::32c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 616f84da-8b69-11ed-91b6-6bf2151ebd3b; Tue, 03 Jan 2023 14:20:24 +0100 (CET) Received: by mail-wm1-x32c.google.com with SMTP id ja17so22623180wmb.3 for ; Tue, 03 Jan 2023 05:20:24 -0800 (PST) Received: from [192.168.30.216] ([81.0.6.76]) by smtp.gmail.com with ESMTPSA id q185-20020a1c43c2000000b003cff309807esm48256372wma.23.2023.01.03.05.20.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Jan 2023 05:20:23 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 616f84da-8b69-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZAwOz3kc/9RSBo9h8xa3JZTDJQ2pKeCHHfYRBL5M+SY=; b=w6BTCvFONQCYPX0/nZZCMv4rr29dPxkv98CNXiyLTNiTsQbTli7oCIEorcdwzVRc3Q ge3kqsR5GujjPB0TW7Pfp2NU83khk8s3NXWX8wKRV1tIJK8gp6OTTXxCAVEi8dGmp2iE lSDbp3a/SWK5od1MJsS6FD+hXAzD4sSwQ9gd/VTBqX31dHDmzyczIf3WwfGAFeCnsVtd R4W7sbNJr0jZ+6X6duvmxscybWitengU3/4qw/6wfZC1vSF4TxAx4LbtKYfauDhMGWc8 9qdRLb6hF7Co+q3ij/HqSwp9UpU0jJhxmDYqusP9482jSljfGackybhTGEO4GzTJm0cC xn+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZAwOz3kc/9RSBo9h8xa3JZTDJQ2pKeCHHfYRBL5M+SY=; b=g4tzIF+wBHSb2rkIIkUuzkRi/5nMTEK5FYv2VhsSav6YIafagvYA0dLATUOShueGz7 x1/pCExsNbiUVyDiXe8noIkGHBHx7arSrTgXfUi5KRX1wAmCehV+caAuIlMISE/yiCHH +b/9+2UKFiFuII+bMltACNaZgzi76065eToucQcsjWnOfi9mWlVluVlHKEGz48gfgftM yhW9qSU2zUQ+g+1xWmOIM9jBKREbFTim6CrLSjQNS/4ftWdY1ciN7+Cr4r07lqzx93G7 MX9A8yIS05SN2qXuEhq+n73WB0m0131KSl32EIbHj/18wtsac9s+mZeed34e1awd4efx m5Pw== X-Gm-Message-State: AFqh2kocusvibBb0AVE61QJs8coaPUmbugD7WSYgtsrySj0USqzY2nkG ZdAe8RA6PWscx/WU1+6OjuZPJg== X-Google-Smtp-Source: AMrXdXujUu1mK5FhNhKF64/Kjpk2KVHVVnvRRQsbR6qSJmMKeYk3xlYQ4gde/xnsingH5Bey5hXL1A== X-Received: by 2002:a05:600c:22cc:b0:3d1:bd81:b1b1 with SMTP id 12-20020a05600c22cc00b003d1bd81b1b1mr30316821wmg.18.1672752023907; Tue, 03 Jan 2023 05:20:23 -0800 (PST) Message-ID: Date: Tue, 3 Jan 2023 14:20:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 5/6] hw/isa/piix: Resolve redundant k->config_write assignments Content-Language: en-US To: Bernhard Beschow , qemu-devel@nongnu.org Cc: Paul Durrant , Marcel Apfelbaum , "Michael S. Tsirkin" , Stefano Stabellini , Anthony Perard , Aurelien Jarno , Eduardo Habkost , xen-devel@lists.xenproject.org, =?UTF-8?Q?Herv=c3=a9_Poussineau?= , Paolo Bonzini , Richard Henderson References: <20230102213504.14646-1-shentey@gmail.com> <20230102213504.14646-6-shentey@gmail.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20230102213504.14646-6-shentey@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2/1/23 22:35, Bernhard Beschow wrote: > The previous patch unified handling of piix_write_config() accross all > PIIX device models which allows for assigning k->config_write once in the > base class. > > Signed-off-by: Bernhard Beschow > --- > hw/isa/piix.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Reviewed-by: Philippe Mathieu-Daudé From xen-devel-bounces@lists.xenproject.org Tue Jan 03 13:39:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 Jan 2023 13:39:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470636.730197 (Exim 4.92) (envelope-from ) id 1pChVL-0003vz-4v; Tue, 03 Jan 2023 13:38:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470636.730197; Tue, 03 Jan 2023 13:38:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pChVL-0003vs-1R; Tue, 03 Jan 2023 13:38:59 +0000 Received: by outflank-mailman (input) for mailman id 470636; Tue, 03 Jan 2023 13:38:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pChVJ-0003vj-SP for xen-devel@lists.xenproject.org; Tue, 03 Jan 2023 13:38:58 +0000 Received: from mail-vs1-xe2d.google.com (mail-vs1-xe2d.google.com [2607:f8b0:4864:20::e2d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f7dc828f-8b6b-11ed-91b6-6bf2151ebd3b; Tue, 03 Jan 2023 14:38:56 +0100 (CET) Received: by mail-vs1-xe2d.google.com with SMTP id h27so18006907vsq.3 for ; Tue, 03 Jan 2023 05:38:56 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f7dc828f-8b6b-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=/LsA1hPZM5dA9H27C/BbcFIU066UnS0soamgpDeqDB8=; b=ZaZolHmVwQMCjQ/Vy+OT863+IagRBZtKYtxqP3l9IxNNTOJsCBPgAs1G92xOvTOSUZ y8iZSDODB5uwW1ulxWbMpK4ol3HPNUWJu8JS5Q6gt+AEKz9RB74lqsTvlTK+SA59hIeB oMpRhIHM83rJdrzSVIzUYnmcg+9X/X1KTm2k7qKSpuqQro1aQ7KaqnFwXvPKX8p1XCrn nxWmuWxbx1zhsNMZMCgSnyvc1gx8kMpaTKB8NiGcGA6OyymHpd6Tv/l1kr8kjWL/Ptpg fFd7fsYZdSwP3yGVIzNbt/aAYEMBqr3dy/eYewuHRZX0yFVVwJtWPpjPxu20HW1P8lXT GYwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/LsA1hPZM5dA9H27C/BbcFIU066UnS0soamgpDeqDB8=; b=v2CxP9zAYBht/CkT/0Gk0SBHk1YCCdku591tlztYlhc9yw9opC0NEFcpTUBkKEx94h WrUbAV0cKJtXgYN0E44JqKfEoB6xwVJrKCTYv569JcfLx6bBL6OVREhfDCUhiXBsTaqT sBQOKCUouMOF454jXyR4584cWZ8Eo/Qp2QCLzGu2LR6NhnKiLpAJHDFQ8klw7LdIB9Tv dL1f0wreVNHUTRI9Kj9ujRol6UOWPKl9LxvIBQ1+Srtf9601aLifYa80Ev/dKBTiUFSd ZwLLwVyVoMWE9vEKj+tfcey/xnp6ZwYeR3T6hZilTz4iWKBAPNE2oEPee6iv3L7PkP9Y 3y+A== X-Gm-Message-State: AFqh2kq3Uc37UVojurTy488p9i1UPPTYYyi7BCFYRaE/vuwHASl1M2jf uKQwiwUAQ/xneyMZAtOkTbZu4EqkRVtcBEJIGbM= X-Google-Smtp-Source: AMrXdXsKnsuze9zgtzTt/vE0gzVOeHDaiKZOvCtvg2WBe8lWBDodUYclv5LABCoqB6l+X/uAVhfC0lKwpOH5KleJtnI= X-Received: by 2002:a67:f9d8:0:b0:3ce:82f7:5f41 with SMTP id c24-20020a67f9d8000000b003ce82f75f41mr1139409vsq.2.1672753134937; Tue, 03 Jan 2023 05:38:54 -0800 (PST) MIME-Version: 1.0 References: <20230102213504.14646-1-shentey@gmail.com> <0de699a7-98b8-e320-da4d-678d0f594213@linaro.org> In-Reply-To: <0de699a7-98b8-e320-da4d-678d0f594213@linaro.org> From: Bernhard Beschow Date: Tue, 3 Jan 2023 14:38:40 +0100 Message-ID: Subject: Re: [PATCH 0/6] Resolve TYPE_PIIX3_XEN_DEVICE To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Cc: Chuck Zmudzinski , qemu-devel@nongnu.org, Paul Durrant , Marcel Apfelbaum , "Michael S. Tsirkin" , Stefano Stabellini , Anthony Perard , Aurelien Jarno , Eduardo Habkost , xen-devel@lists.xenproject.org, =?UTF-8?Q?Herv=C3=A9_Poussineau?= , Paolo Bonzini , Richard Henderson Content-Type: multipart/alternative; boundary="00000000000067a9ab05f15c3005" --00000000000067a9ab05f15c3005 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Jan 3, 2023 at 2:17 PM Philippe Mathieu-Daud=C3=A9 wrote: > Hi Chuck, > > On 3/1/23 04:15, Chuck Zmudzinski wrote: > > On 1/2/23 4:34=E2=80=AFPM, Bernhard Beschow wrote: > >> This series first renders TYPE_PIIX3_XEN_DEVICE redundant and finally > removes > >> it. The motivation is to 1/ decouple PIIX from Xen and 2/ to make Xen > in the PC > >> machine agnostic to the precise southbridge being used. 2/ will become > >> particularily interesting once PIIX4 becomes usable in the PC machine, > avoiding > >> the "Frankenstein" use of PIIX4_ACPI in PIIX3. > >> > >> Testing done: > >> None, because I don't know how to conduct this properly :( > >> > >> Based-on: <20221221170003.2929-1-shentey@gmail.com> > >> "[PATCH v4 00/30] Consolidate PIIX south bridges" > > This series is based on a previous series: > https://lore.kernel.org/qemu-devel/20221221170003.2929-1-shentey@gmail.co= m/ > (which itself also is). > > >> Bernhard Beschow (6): > >> include/hw/xen/xen: Make xen_piix3_set_irq() generic and rename it > >> hw/isa/piix: Reuse piix3_realize() in piix3_xen_realize() > >> hw/isa/piix: Wire up Xen PCI IRQ handling outside of PIIX3 > >> hw/isa/piix: Avoid Xen-specific variant of piix_write_config() > >> hw/isa/piix: Resolve redundant k->config_write assignments > >> hw/isa/piix: Resolve redundant TYPE_PIIX3_XEN_DEVICE > >> > >> hw/i386/pc_piix.c | 34 ++++++++++++++++-- > >> hw/i386/xen/xen-hvm.c | 9 +++-- > >> hw/isa/piix.c | 66 +--------------------------------= -- > > > > This file does not exist on the Qemu master branch. > > But hw/isa/piix3.c and hw/isa/piix4.c do exist. > > > > I tried renaming it from piix.c to piix3.c in the patch, but > > the patch set still does not apply cleanly on my tree. > > > > Is this patch set re-based against something other than > > the current master Qemu branch? > > > > I have a system that is suitable for testing this patch set, but > > I need guidance on how to apply it to the Qemu source tree. > > You can ask Bernhard to publish a branch with the full work, > Hi Chuck, ... or just visit https://patchew.org/QEMU/20230102213504.14646-1-shentey@gmail.com/ . There you'll find a git tag with a complete history and all instructions! Thanks for giving my series a test ride! Best regards, Bernhard or apply each series locally. I use the b4 tool for that: > https://b4.docs.kernel.org/en/latest/installing.html > > i.e.: > > $ git checkout -b shentey_work > $ b4 am 20221120150550.63059-1-shentey@gmail.com > $ git am > ./v2_20221120_shentey_decouple_intx_to_lnkx_routing_from_south_bridges.mb= x > $ b4 am 20221221170003.2929-1-shentey@gmail.com > $ git am > > ./v4_20221221_shentey_this_series_consolidates_the_implementations_of_the= _piix3_and_piix4_south.mbx > $ b4 am 20230102213504.14646-1-shentey@gmail.com > $ git am ./20230102_shentey_resolve_type_piix3_xen_device.mbx > > Now the branch 'shentey_work' contains all the patches and you can test. > > Regards, > > Phil. > --00000000000067a9ab05f15c3005 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Tue, Jan 3, 2023 at 2:17 PM Philip= pe Mathieu-Daud=C3=A9 <philmd@linar= o.org> wrote:
Hi Chuck,

On 3/1/23 04:15, Chuck Zmudzinski wrote:
> On 1/2/23 4:34=E2=80=AFPM, Bernhard Beschow wrote:
>> This series first renders TYPE_PIIX3_XEN_DEVICE redundant and fina= lly removes
>> it. The motivation is to 1/ decouple PIIX from Xen and 2/ to make = Xen in the PC
>> machine agnostic to the precise southbridge being used. 2/ will be= come
>> particularily interesting once PIIX4 becomes usable in the PC mach= ine, avoiding
>> the "Frankenstein" use of PIIX4_ACPI in PIIX3.
>>
>> Testing done:
>> None, because I don't know how to conduct this properly :(
>>
>> Based-on: <20221221170003.2929-1-shentey@gmail.com> >>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "[PATCH v4 00/30] Co= nsolidate PIIX south bridges"

This series is based on a previous series:
https://lore.kernel.org/q= emu-devel/20221221170003.2929-1-shentey@gmail.com/
(which itself also is).

>> Bernhard Beschow (6):
>>=C2=A0 =C2=A0 include/hw/xen/xen: Make xen_piix3_set_irq() generic = and rename it
>>=C2=A0 =C2=A0 hw/isa/piix: Reuse piix3_realize() in piix3_xen_reali= ze()
>>=C2=A0 =C2=A0 hw/isa/piix: Wire up Xen PCI IRQ handling outside of = PIIX3
>>=C2=A0 =C2=A0 hw/isa/piix: Avoid Xen-specific variant of piix_write= _config()
>>=C2=A0 =C2=A0 hw/isa/piix: Resolve redundant k->config_write ass= ignments
>>=C2=A0 =C2=A0 hw/isa/piix: Resolve redundant TYPE_PIIX3_XEN_DEVICE<= br> >>
>>=C2=A0 =C2=A0hw/i386/pc_piix.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0| 34 ++++++++++++++++--
>>=C2=A0 =C2=A0hw/i386/xen/xen-hvm.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0|=C2=A0 9 +++--
>>=C2=A0 =C2=A0hw/isa/piix.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0| 66 +----------------------------------
>
> This file does not exist on the Qemu master branch.
> But hw/isa/piix3.c and hw/isa/piix4.c do exist.
>
> I tried renaming it from piix.c to piix3.c in the patch, but
> the patch set still does not apply cleanly on my tree.
>
> Is this patch set re-based against something other than
> the current master Qemu branch?
>
> I have a system that is suitable for testing this patch set, but
> I need guidance on how to apply it to the Qemu source tree.

You can ask Bernhard to publish a branch with the full work,

Hi Chuck,

... or just visit = https://patchew.org/QEMU/20230102213504.14646-1-shentey@gmail.com/ = . There you'll find a git tag with a complete history and all instructi= ons!

Thanks for giving my series a test ride!

Best regards,
Bernhard

<= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft:1px solid rgb(204,204,204);padding-left:1ex"> or apply each series locally. I use the b4 tool for that:
https://b4.docs.kernel.org/en/latest/installing.= html

i.e.:

$ git checkout -b shentey_work
$ b4 am 20221120150550.63059-1-shentey@gmail.com
$ git am
./v2_20221120_shentey_decouple_intx_to_lnkx_routing_from_south_bridges.mbx<= br> $ b4 am 20221221170003.2929-1-shentey@gmail.com
$ git am
./v4_20221221_shentey_this_series_consolidates_the_implementations_of_the_p= iix3_and_piix4_south.mbx
$ b4 am 20230102213504.14646-1-shentey@gmail.com
$ git am ./20230102_shentey_resolve_type_piix3_xen_device.mbx

Now the branch 'shentey_work' contains all the patches and you can = test.

Regards,

Phil.
--00000000000067a9ab05f15c3005-- From xen-devel-bounces@lists.xenproject.org Tue Jan 03 15:15:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 Jan 2023 15:15:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470645.730208 (Exim 4.92) (envelope-from ) id 1pCj0O-0005c6-5A; Tue, 03 Jan 2023 15:15:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470645.730208; Tue, 03 Jan 2023 15:15:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCj0O-0005bz-1B; Tue, 03 Jan 2023 15:15:08 +0000 Received: by outflank-mailman (input) for mailman id 470645; Tue, 03 Jan 2023 15:15:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCj0M-0005bt-8b for xen-devel@lists.xenproject.org; Tue, 03 Jan 2023 15:15:06 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 65b57108-8b79-11ed-91b6-6bf2151ebd3b; Tue, 03 Jan 2023 16:15:04 +0100 (CET) Received: from mail-il1-f199.google.com (mail-il1-f199.google.com [209.85.166.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-179-I2NBm3HZPaKoWNPYrnMZpw-1; Tue, 03 Jan 2023 10:14:59 -0500 Received: by mail-il1-f199.google.com with SMTP id n15-20020a056e021baf00b0030387c2e1d3so19417872ili.5 for ; Tue, 03 Jan 2023 07:14:59 -0800 (PST) Received: from redhat.com ([38.15.36.239]) by smtp.gmail.com with ESMTPSA id v17-20020a02b091000000b00356738a2aa2sm9895119jah.55.2023.01.03.07.14.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Jan 2023 07:14:57 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 65b57108-8b79-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672758903; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3C3N3hWqoUvt4wQQ24fzp8QfU4qA5jURytjfdBX+cwQ=; b=Qef+lj1tCgVPMgWr+qqywfKx/t002r3ZtY/4bSo0eIdt/S74B6rAl4fOoBElYs+Bc53eKn 5UvtyfqWYN+dAAOaoeVbAEif6QD9QigvCOg99lDktA3f4y5VN3HLwAyt7SzpiL1LjIBYS/ eVR+Ne+ZbHH381qKHEHKjzGEXz0t9Gw= X-MC-Unique: I2NBm3HZPaKoWNPYrnMZpw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=3C3N3hWqoUvt4wQQ24fzp8QfU4qA5jURytjfdBX+cwQ=; b=OJsYPioBZurw/AaMGH6n7PjybIYwr2pky+LiOt3X0KTNj4IT2JBHNlLTwPhymggXxk ++EattZ5mb6/tPK6286KH+AjtQcc6+Ni1AdP5XyBOAf0WFIjYNBJP8I5xB2dBbovrb0h j7f1vAS3FmdQuW2ZZgRyGzWIyWjbwXo57HfrCKMDaN+ulKIha7N+pzShAlX1y3x5R7Fy PObsWHbpOs861G+alMWRnGQ1SC8m3vUiOxwrtkyfp0SuObAefJhD97lqv4wLyMurHAvl +xUjq3zqz5XhTAW6pEBhYDni0aHW2lyyAJELgUFoswmcdpSBlrAoQCl/2g9NXi62H7LY b/zg== X-Gm-Message-State: AFqh2kpNm5PSFXewLKfJbekrbmlMRBiDuNf1p9y03CDpn0fefeYo//H8 OEjnyBAYVOa/vC7TCNH97Xa0q7QHg9NPaGSelBEHMYSjEfTce4OgCfP1q0DJiBtpXkFmlcMGkNq lnINrVrC16Udt7pcHcI+blQwxE0w= X-Received: by 2002:a92:b745:0:b0:304:c04b:c184 with SMTP id c5-20020a92b745000000b00304c04bc184mr30283020ilm.28.1672758899079; Tue, 03 Jan 2023 07:14:59 -0800 (PST) X-Google-Smtp-Source: AMrXdXv34XF6KPgrepazk8naDtFk/N6HqJkq8zkS1urCN22H3/wO2mCbFnxpkHrBAKNgBTuqKEFBxA== X-Received: by 2002:a92:b745:0:b0:304:c04b:c184 with SMTP id c5-20020a92b745000000b00304c04bc184mr30283006ilm.28.1672758898748; Tue, 03 Jan 2023 07:14:58 -0800 (PST) Date: Tue, 3 Jan 2023 08:14:56 -0700 From: Alex Williamson To: Chuck Zmudzinski Cc: "Michael S. Tsirkin" , qemu-devel@nongnu.org, Stefano Stabellini , Anthony Perard , Paul Durrant , Paolo Bonzini , Richard Henderson , Eduardo Habkost , Marcel Apfelbaum , xen-devel@lists.xenproject.org Subject: Re: [PATCH v6] xen/pt: reserve PCI slot 2 for Intel igd-passthru Message-ID: <20230103081456.1d676b8e.alex.williamson@redhat.com> In-Reply-To: References: <830263507e8f1a24a94f81909d5102c4b204e938.1672615492.git.brchuckz.ref@aol.com> <830263507e8f1a24a94f81909d5102c4b204e938.1672615492.git.brchuckz@aol.com> <20230102124605-mutt-send-email-mst@kernel.org> Organization: Red Hat MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 2 Jan 2023 18:10:24 -0500 Chuck Zmudzinski wrote: > On 1/2/23 12:46 PM, Michael S. Tsirkin wrote: > > On Sun, Jan 01, 2023 at 06:52:03PM -0500, Chuck Zmudzinski wrote: > > > Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, > > > as noted in docs/igd-assign.txt in the Qemu source code. > > > > > > Currently, when the xl toolstack is used to configure a Xen HVM guest with > > > Intel IGD passthrough to the guest with the Qemu upstream device model, > > > a Qemu emulated PCI device will occupy slot 2 and the Intel IGD will occupy > > > a different slot. This problem often prevents the guest from booting. > > > > > > The only available workaround is not good: Configure Xen HVM guests to use > > > the old and no longer maintained Qemu traditional device model available > > > from xenbits.xen.org which does reserve slot 2 for the Intel IGD. > > > > > > To implement this feature in the Qemu upstream device model for Xen HVM > > > guests, introduce the following new functions, types, and macros: > > > > > > * XEN_PT_DEVICE_CLASS declaration, based on the existing TYPE_XEN_PT_DEVICE > > > * XEN_PT_DEVICE_GET_CLASS macro helper function for XEN_PT_DEVICE_CLASS > > > * typedef XenPTQdevRealize function pointer > > > * XEN_PCI_IGD_SLOT_MASK, the value of slot_reserved_mask to reserve slot 2 > > > * xen_igd_reserve_slot and xen_igd_clear_slot functions > > > > > > The new xen_igd_reserve_slot function uses the existing slot_reserved_mask > > > member of PCIBus to reserve PCI slot 2 for Xen HVM guests configured using > > > the xl toolstack with the gfx_passthru option enabled, which sets the > > > igd-passthru=on option to Qemu for the Xen HVM machine type. > > > > > > The new xen_igd_reserve_slot function also needs to be implemented in > > > hw/xen/xen_pt_stub.c to prevent FTBFS during the link stage for the case > > > when Qemu is configured with --enable-xen and --disable-xen-pci-passthrough, > > > in which case it does nothing. > > > > > > The new xen_igd_clear_slot function overrides qdev->realize of the parent > > > PCI device class to enable the Intel IGD to occupy slot 2 on the PCI bus > > > since slot 2 was reserved by xen_igd_reserve_slot when the PCI bus was > > > created in hw/i386/pc_piix.c for the case when igd-passthru=on. > > > > > > Move the call to xen_host_pci_device_get, and the associated error > > > handling, from xen_pt_realize to the new xen_igd_clear_slot function to > > > initialize the device class and vendor values which enables the checks for > > > the Intel IGD to succeed. The verification that the host device is an > > > Intel IGD to be passed through is done by checking the domain, bus, slot, > > > and function values as well as by checking that gfx_passthru is enabled, > > > the device class is VGA, and the device vendor in Intel. > > > > > > Signed-off-by: Chuck Zmudzinski > > > > I'm not sure why is the issue xen specific. Can you explain? > > Doesn't it affect kvm too? > > Recall from docs/igd-assign.txt that there are two modes for > igd passthrough: legacy and upt, and the igd needs to be > at slot 2 only when using legacy mode which gives one > single guest exclusive access to the Intel igd. > > It's only xen specific insofar as xen does not have support > for the upt mode so xen must use legacy mode which > requires the igd to be at slot 2. I am not an expert with UPT mode never fully materialized for direct assignment, the folks at Intel championing this scenario left. > kvm, but if I understand correctly, with kvm one can use > the upt mode with the Intel i915 kvmgt kernel module > and in that case the guest will see a virtual Intel gpu > that can be at any arbitrary slot when using kvmgt, and > also, in that case, more than one guest can access the > igd through the kvmgt kernel module. This is true, IIRC an Intel vGPU does not need to be in slot 2. > Again, I am not an expert and do not have as much > experience with kvm, but if I understand correctly it is > possible to use the legacy mode with kvm and I think you > are correct that if one uses kvm in legacy mode and without > using the Intel i915 kvmgt kernel module, then it would be > necessary to reserve slot 2 for the igd on kvm. It's necessary to configure the assigned IGD at slot 2 to make it functional, yes, but I don't really understand this notion of "reserving" slot 2. If something occupies address 00:02.0 in the config, it's the user's or management tool's responsibility to move it to make this configuration functional. Why does QEMU need to play a part in reserving this bus address. IGD devices are not generally hot-pluggable either, so it doesn't seem we need to reserve an address in case an IGD device is added dynamically later. > Your question makes me curious, and I have not been able > to determine if anyone has tried igd passthrough using > legacy mode on kvm with recent versions of linux and qemu. Yes, it works. > I will try reproducing the problem on kvm in legacy mode with > current versions of linux and qemu and report my findings. > With kvm, there might be enough flexibility to specify the > slot number for every pci device in the guest. Such a I think this is always the recommendation, libvirt will do this by default in order to make sure the configuration is reproducible. This is what we generally rely on for kvm/vfio IGD assignment to place the GPU at the correct address. > capability is not available using the xenlight toolstack > for managing xen guests, so I have been using this patch > to ensure that the Intel igd is at slot 2 with xen guests > created by the xenlight toolstack. Seems like a deficiency in xenlight. I'm not sure why QEMU should take on this burden to support support tool stacks that lack such basic features. > The patch as is will only fix the problem on xen, so if the > problem exists on kvm also, I agree that the patch should > be modified to also fix it on kvm. AFAICT, it's not a problem on kvm/vfio because we generally make use of invocations that specify bus addresses for each device by default, making this a configuration requirement for the user or management tool stack. Thanks, Alex From xen-devel-bounces@lists.xenproject.org Tue Jan 03 15:25:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 Jan 2023 15:25:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470652.730219 (Exim 4.92) (envelope-from ) id 1pCjAL-00076q-26; Tue, 03 Jan 2023 15:25:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470652.730219; Tue, 03 Jan 2023 15:25:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCjAK-00076j-VO; Tue, 03 Jan 2023 15:25:24 +0000 Received: by outflank-mailman (input) for mailman id 470652; Tue, 03 Jan 2023 15:25:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCjAI-00076d-M3 for xen-devel@lists.xenproject.org; Tue, 03 Jan 2023 15:25:22 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2059.outbound.protection.outlook.com [40.107.237.59]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d2087c08-8b7a-11ed-b8d0-410ff93cb8f0; Tue, 03 Jan 2023 16:25:15 +0100 (CET) Received: from BN0PR04CA0180.namprd04.prod.outlook.com (2603:10b6:408:eb::35) by BL1PR12MB5062.namprd12.prod.outlook.com (2603:10b6:208:313::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Tue, 3 Jan 2023 15:25:17 +0000 Received: from BN8NAM11FT101.eop-nam11.prod.protection.outlook.com (2603:10b6:408:eb:cafe::55) by BN0PR04CA0180.outlook.office365.com (2603:10b6:408:eb::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5966.19 via Frontend Transport; Tue, 3 Jan 2023 15:25:17 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT101.mail.protection.outlook.com (10.13.177.126) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5966.17 via Frontend Transport; Tue, 3 Jan 2023 15:25:16 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 3 Jan 2023 09:25:14 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 3 Jan 2023 07:25:14 -0800 Received: from [192.168.137.15] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 3 Jan 2023 09:25:13 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d2087c08-8b7a-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fzQQXm6jCsEr6SEsVauW/nRsBpxPEIulDuuZEDFKFDu35RrtbCdoxhY9Eb7t+0pxrKPOTMi+V0XucCbE3RXdAl8mIFvou7IBTcqaKk8sp6oiGo8qBxAyM8YH/Amo2kaNW45N1HfQyCYKHcu6zQuBo/1ki1WBEhxB7ZaAShIhsUqYdQBV2dRdQWJjXEomUsPSLI5bnY833jr5E9tn2mLIT9gg/9TDyXCm8TX2DgoWs1GkT5yEQk6FXXpKY+gS7Oa/83mKq3jkN+m69LGGH6oaxJtt/U4HMdTzWSIr1er7CaZxFcVGxwt/gKvU13dgdFNJEhNlpYJdicSF82rfbhowUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=15mGA6wja2IZernS34ru3oqZcAZP2HDHZmQsJGvAPbA=; b=GiomPXlCx8eG93WtfhP2oxRrkuuHUOkqgYuR78ZkEh+u4kLlOfBhb5zLm9QcvUUIbD2fDMgqE3aSJu0IE0VllblJkvjCj0JUXFvLf7XZD99MBFDO3mjMrExhFCaVi0X9NAkaqqYk16D3SNab8JQ4OrEFbcXGrViz5K2i933CWiEJ8iR6zZDP5MfXDFmOoExAktu1N9zBKARjwHuZfiEnVDrQMhOTMB2vhiv7metyZdpYNpujhH/is5Ai9Ikn+A5iBJ8mdMZtBcj+1+rVxA5Cllup1Zxk5WDfxBhvi9twqHbnSj3oZImd1Lsw5WEjMlTjoENMKwIiAH8cSiH7qu64cQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=15mGA6wja2IZernS34ru3oqZcAZP2HDHZmQsJGvAPbA=; b=TaDBrxHBOVOshOIe09f3w2xtJzmxbXRvR6lOunqCEmiPGwAlf0TojOFfn3WvKMwJOt5t+OO7lSHEABpSulcAiKl4tX9EIxZ8PFaqugdHWm+1hTU7pB/XXHBN/2QTTwgLcNDs6vPP+ZMO5PLysxDvNcVhH9OOgkK9oRX2AUkCDKY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <33e3e0f0-6784-5012-eb25-4d90f9cf188b@amd.com> Date: Tue, 3 Jan 2023 10:25:12 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [RFC PATCH 21/21] xen/arm: vIOMMU: Modify the partial device tree for dom0less To: Rahul Singh , CC: Stefano Stabellini , Julien Grall , Bertrand Marquis , "Volodymyr Babchuk" References: <127da5a0d4300e083b8840a4f3a0d2d63bde5b6f.1669888522.git.rahul.singh@arm.com> Content-Language: en-US From: Stewart Hildebrand In-Reply-To: <127da5a0d4300e083b8840a4f3a0d2d63bde5b6f.1669888522.git.rahul.singh@arm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT101:EE_|BL1PR12MB5062:EE_ X-MS-Office365-Filtering-Correlation-Id: 67c76040-fd68-40d8-dd53-08daed9eb7b0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: u3O4znWQAghTI0l4vOGlH5msU7OkxnsKbhRdQPkBprmSj6ocjlokBV2PlBM2VMH+yoTgLrD7QNJ5vY8LcifWQHFohxabwB0bsUMMc/U9AgNKFo0JqbyqoCYBA2/SlqifpgYgxBjZD/BzzgP0Cg+pt2ZuMzOId9VgkrQTAWl4jl9xBAe263BDbGThCTtJ1Wv3zfaoVNEVgKxE8ajvwAuxe+ggu1yHYFP3WsvMVv7X6HbE8tx10b5P9b5DvxV2gGHveJFTGtwy0NhSlf9gebvdI6glCjQJeDyXQkC+ScadnXm/cF5HGjOfInk2MOm2ADTzS4TnjMrFqDrOhZtDW4ZvhVVAbGaLoGpeGLsqC+VE60PxdAMrA7QSqeGamoYhwTAPNkP4WJVHFnCPcXZNoRIoBMMNt4jUY+OQUYkmgeqWlwGYDgcOfu/4B80P2lhy/TcmfylwZbmCEtOKJV9bqe070AFl+A6sx3u4aAg6QajMHcxQoI7+XW7hHX1VxkvhtWKxZXfm3IxB27Aogc5aXcUzR6hVVjH4UHZW1zOqLxoO6g2O0YuZPUD5x/9fObGlCZy1JPxkIz8raCm488M4lcgBesXvHrf51Sm022EDPDPgjutdA4gJec89w9TxM4+nO2hNf3xFbaiIsB7KkI9WEWLiv0SLRcWMbJNM0LVNX9sDmShZ/6e+EMV84JyVnC9/09XPYEOqMOIe9vCx7/G2VW1mRQTlAazhXqtqNHj0x32wyAtQy3pIW5weQitdIgkup70nfWQiAjUseuV6W62VLkwG7vKQu31aGaE6Fq0IRzuC+3QZU+IR7qXp/4MsOUDkHngJ X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(39860400002)(346002)(396003)(451199015)(40470700004)(36840700001)(46966006)(26005)(186003)(8936002)(83380400001)(40480700001)(44832011)(53546011)(478600001)(31686004)(40460700003)(54906003)(16576012)(316002)(41300700001)(36756003)(2616005)(70586007)(70206006)(8676002)(81166007)(4326008)(336012)(47076005)(426003)(36860700001)(82310400005)(82740400003)(5660300002)(86362001)(2906002)(356005)(110136005)(31696002)(22166006)(32563001)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2023 15:25:16.8314 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 67c76040-fd68-40d8-dd53-08daed9eb7b0 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT101.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5062 On 12/1/22 11:02, Rahul Singh wrote: > To configure IOMMU in guest for passthrough devices, user will need to > copy the unmodified "iommus" property from host device tree to partial > device tree. To enable the dom0 linux kernel to confiure the IOMMU > correctly replace the phandle in partial device tree with virtual > IOMMU phandle when "iommus" property is set. > > Signed-off-by: Rahul Singh > --- > xen/arch/arm/domain_build.c | 31 ++++++++++++++++++++++++++++++- > 1 file changed, 30 insertions(+), 1 deletion(-) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 7cd99a6771..afb3e76409 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -3235,7 +3235,35 @@ static int __init handle_prop_pfdt(struct kernel_info *kinfo, > return ( propoff != -FDT_ERR_NOTFOUND ) ? propoff : 0; > } > > -static int __init scan_pfdt_node(struct kernel_info *kinfo, const void *pfdt, > +static void modify_pfdt_node(void *pfdt, int nodeoff) This should have the __init attribute From xen-devel-bounces@lists.xenproject.org Tue Jan 03 16:14:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 Jan 2023 16:14:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470659.730230 (Exim 4.92) (envelope-from ) id 1pCjvF-0004QM-Mi; Tue, 03 Jan 2023 16:13:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470659.730230; Tue, 03 Jan 2023 16:13:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCjvF-0004QF-JL; Tue, 03 Jan 2023 16:13:53 +0000 Received: by outflank-mailman (input) for mailman id 470659; Tue, 03 Jan 2023 16:13:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCjvF-0004Q9-2y for xen-devel@lists.xenproject.org; Tue, 03 Jan 2023 16:13:53 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2084.outbound.protection.outlook.com [40.107.220.84]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9852df46-8b81-11ed-b8d0-410ff93cb8f0; Tue, 03 Jan 2023 17:13:45 +0100 (CET) Received: from DS7PR03CA0156.namprd03.prod.outlook.com (2603:10b6:5:3b2::11) by MN2PR12MB4454.namprd12.prod.outlook.com (2603:10b6:208:26c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Tue, 3 Jan 2023 16:13:46 +0000 Received: from DM6NAM11FT046.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3b2:cafe::dc) by DS7PR03CA0156.outlook.office365.com (2603:10b6:5:3b2::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5966.19 via Frontend Transport; Tue, 3 Jan 2023 16:13:46 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT046.mail.protection.outlook.com (10.13.172.121) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5944.10 via Frontend Transport; Tue, 3 Jan 2023 16:13:45 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 3 Jan 2023 10:13:45 -0600 Received: from [192.168.137.15] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 3 Jan 2023 10:13:43 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9852df46-8b81-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IyYmyWqVNOBzOpct5pUdnvHwZxnRj+hg67YAoqMeI6qT04AXucw8gh5uvtfPoJZCSo8PW9BGSksmr6GBnCJEolOfJjgXy3MgGyyFaewB3NaKdC4ms2ps7N7AKcr8tKRV2zlLXR2dsm2EjxmC7wxBca+z3MCs0YOHpF536uigjDtvHEbD1WTzCsmL3bPM1JNOMxZL1bQ0CHg7KYs6CoGB6rKVkCwFVjITj6zQWAY25ETPLYYJO1pfaqaP3SCIJi0Jjd33wqiBT/EjGbBfvhciHmDif3Xt+dBhl0Lfk+7kEjCoif5XTfvt4n37XWErGKeBHR7DJafMEYJsUKbvpJ9ynw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zAeB5DZg5O4cLoUIOlrA32lq3p/qkuMgOeXypP9e4Uc=; b=mRmO0bjHJ46qRqQO1tbGgGkwrsxtpvKQsQgxJY0HkAeMVzLJRRmVaDKN/fiyjoHuxnREK85lffRJKX7ihR7P6nIMb2gZko0C/7msK6ET7bnvtoJVxzxjlnK2WGviZFtNF9bSaTGyrvOYxqPRM9AQ5mMf4X0a6xhBCzoEKgx1LPPOkSuL2nPQW7L00pT2fpI8nV6gZfXf9aV5VHYAwOQ3VKPRoSkSCP3RJaSRrult5VXGgsKCTBxbIXFsN7gAEDcUh/0NqdE6n4NNlZMrEsUs++wyqteyDQBb9U6SLgUd7QEJMMFhyvSFJxNnsbtjn1t6Y4/KTqXLI/ntj1+lgQC1lA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zAeB5DZg5O4cLoUIOlrA32lq3p/qkuMgOeXypP9e4Uc=; b=bUdgB5xAVBBbzj/uXLYOBwEjNzMXxlQRU94Y8+eQfyvLEXbC+JJv8lLC/1wKrqxCQyzY4HdqXBhBP70w3XDwLVlgZMrEPn2a/eCWoeF8M4nthk2Boa9BmzxF5q171bV019nfYsrb7lS1ADwfvcNAU8nM5LSkZ2nmh2gyOyY7O5k= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <9c11f1d8-1f59-9993-22bd-fb7e6d1b93ae@amd.com> Date: Tue, 3 Jan 2023 11:13:42 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [RFC PATCH 11/21] xen/arm: vsmmuv3: Attach Stage-1 configuration to SMMUv3 hardware Content-Language: en-US To: Rahul Singh , CC: Bertrand Marquis , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Jan Beulich , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: From: Stewart Hildebrand In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT046:EE_|MN2PR12MB4454:EE_ X-MS-Office365-Filtering-Correlation-Id: 224f5d43-8e7e-417a-4b2b-08daeda57d96 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mDwQhiGyCkNz/XfPANZsWewMcPHUMJnbjL3NXCv8QtCOF+6CIPpzNgFq72cnsx5+keAitAsFFFXgAiYmNnVVaC0R8j6uwZcnzDuJY0gTRwkcZfMD/KR9kIo02WY+ryifJi6eycE8NT/ccc9DKZ6JIX4VTKTl34iNCGvxb2sJBIHULiIo9q1oZNW7ayjRjVEf1dVfHq+gP624WSOIdWyQtQXeinqcMjpgDvdh+RjFRE5nUm3oRDjKKSskn/M1F5UH33SkeWm3Rogrnu9JmKnt/cq0/LYeUZedVK3uBFEZm5btt59X+Cz7M2M3ZrGK2BmYewl/yQs7jVkVMDydljrN29V3dsHsm8WLwWPfXTdwP5o9r5zfcMfbBhFw1SIi16jDz5SD0FG8txOfJ3ANsyJ2jk9zPjMtYHEtbcBds/Zp+nh4KZC/lchLuhUkG2Fe5va2K7BVr6+u8B+78BsmHP6xklX324pEhLLDRLY9r9XGJcXMenpTJGkh+TVOAS/pWZ4aUp12D9k/hJJFu4HlmL2Tmrb8HP3Qx4qGxndNN3xxIqYJUQRyjj4tK+pefYbAusgjdfTyz1WaQMNOqVDeh/eRHowk5zrbqiPgwW7g7vejReUD1wpvOWYJopCJKZ28Mrqa6KZcTprOvhx0RdrAyOQXnHHmd7YKEScRXnacEKCPglxFRj5jXBjXtfqh7pLg/DCLSP0VwEnic92U6gj5MzpG8zysMBpM+HNKTCE8m3SkF+YlXH0anKiLiX/l7e8jWuU/Px5oBvUr0oghHo1wnA8OKnV1qrHoSCGGYmDXE56/KtSvmf15o3UpfQFeEHKl/IKYxsQ2bqpPJdYTssIJjUy11jpl+puEScldh1eWybfVsTU= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(346002)(396003)(136003)(451199015)(46966006)(36840700001)(40470700004)(70206006)(8676002)(70586007)(4326008)(81166007)(36756003)(2616005)(426003)(47076005)(336012)(41300700001)(40460700003)(54906003)(16576012)(316002)(110136005)(31696002)(2906002)(356005)(86362001)(36860700001)(5660300002)(82740400003)(82310400005)(40480700001)(44832011)(8936002)(83380400001)(53546011)(478600001)(186003)(26005)(31686004)(22166006)(43740500002)(36900700001)(473944003)(414714003);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2023 16:13:45.8109 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 224f5d43-8e7e-417a-4b2b-08daeda57d96 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT046.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4454 On 12/1/22 11:02, Rahul Singh wrote: > Attach the Stage-1 configuration to device STE to support nested > translation for the guests. > > Signed-off-by: Rahul Singh > --- > xen/drivers/passthrough/arm/smmu-v3.c | 79 ++++++++++++++++++++++++++ > xen/drivers/passthrough/arm/smmu-v3.h | 1 + > xen/drivers/passthrough/arm/vsmmu-v3.c | 18 ++++++ > xen/include/xen/iommu.h | 14 +++++ > 4 files changed, 112 insertions(+) > > diff --git a/xen/drivers/passthrough/arm/smmu-v3.c b/xen/drivers/passthrough/arm/smmu-v3.c > index 4f96fdb92f..c4b4a5d86d 100644 > --- a/xen/drivers/passthrough/arm/smmu-v3.c > +++ b/xen/drivers/passthrough/arm/smmu-v3.c > @@ -2754,6 +2754,37 @@ static struct arm_smmu_device *arm_smmu_get_by_dev(struct device *dev) > return NULL; > } > > +static struct iommu_domain *arm_smmu_get_domain_by_sid(struct domain *d, > + u32 sid) > +{ > + int i; > + unsigned long flags; > + struct iommu_domain *io_domain; > + struct arm_smmu_domain *smmu_domain; > + struct arm_smmu_master *master; > + struct arm_smmu_xen_domain *xen_domain = dom_iommu(d)->arch.priv; > + > + /* > + * Loop through the &xen_domain->contexts to locate a context > + * assigned to this SMMU > + */ > + list_for_each_entry(io_domain, &xen_domain->contexts, list) { > + smmu_domain = to_smmu_domain(io_domain); > + > + spin_lock_irqsave(&smmu_domain->devices_lock, flags); > + list_for_each_entry(master, &smmu_domain->devices, domain_head) { > + for (i = 0; i < master->num_streams; i++) { > + if (sid != master->streams[i].id) > + continue; > + spin_unlock_irqrestore(&smmu_domain->devices_lock, flags); > + return io_domain; > + } > + } > + spin_unlock_irqrestore(&smmu_domain->devices_lock, flags); > + } > + return NULL; > +} > + > static struct iommu_domain *arm_smmu_get_domain(struct domain *d, > struct device *dev) > { > @@ -2909,6 +2940,53 @@ static void arm_smmu_iommu_xen_domain_teardown(struct domain *d) > xfree(xen_domain); > } > > +static int arm_smmu_attach_guest_config(struct domain *d, u32 sid, > + struct iommu_guest_config *cfg) > +{ > + int ret = -EINVAL; > + unsigned long flags; > + struct arm_smmu_master *master; > + struct arm_smmu_domain *smmu_domain; > + struct arm_smmu_xen_domain *xen_domain = dom_iommu(d)->arch.priv; > + struct iommu_domain *io_domain = arm_smmu_get_domain_by_sid(d, sid); > + > + if (!io_domain) > + return -ENODEV; > + > + smmu_domain = to_smmu_domain(io_domain); > + > + spin_lock(&xen_domain->lock); > + > + switch (cfg->config) { > + case ARM_SMMU_DOMAIN_ABORT: > + smmu_domain->abort = true; > + break; > + case ARM_SMMU_DOMAIN_BYPASS: > + smmu_domain->abort = false; > + break; > + case ARM_SMMU_DOMAIN_NESTED: > + /* Enable Nested stage translation. */ > + smmu_domain->stage = ARM_SMMU_DOMAIN_NESTED; > + smmu_domain->s1_cfg.s1ctxptr = cfg->s1ctxptr; > + smmu_domain->s1_cfg.s1fmt = cfg->s1fmt; > + smmu_domain->s1_cfg.s1cdmax = cfg->s1cdmax; > + smmu_domain->abort = false; > + break; > + default: > + goto out; > + } > + > + spin_lock_irqsave(&smmu_domain->devices_lock, flags); > + list_for_each_entry(master, &smmu_domain->devices, domain_head) > + arm_smmu_install_ste_for_dev(master); > + spin_unlock_irqrestore(&smmu_domain->devices_lock, flags); > + > + ret = 0; > +out: > + spin_unlock(&xen_domain->lock); > + return ret; > +} > + > static const struct iommu_ops arm_smmu_iommu_ops = { > .page_sizes = PAGE_SIZE_4K, > .init = arm_smmu_iommu_xen_domain_init, > @@ -2921,6 +2999,7 @@ static const struct iommu_ops arm_smmu_iommu_ops = { > .unmap_page = arm_iommu_unmap_page, > .dt_xlate = arm_smmu_dt_xlate, > .add_device = arm_smmu_add_device, > + .attach_guest_config = arm_smmu_attach_guest_config Please append a trailing comma here, even if it is the last element > }; > > static __init int arm_smmu_dt_init(struct dt_device_node *dev, > diff --git a/xen/drivers/passthrough/arm/smmu-v3.h b/xen/drivers/passthrough/arm/smmu-v3.h > index e270fe05e0..50a050408b 100644 > --- a/xen/drivers/passthrough/arm/smmu-v3.h > +++ b/xen/drivers/passthrough/arm/smmu-v3.h > @@ -393,6 +393,7 @@ enum arm_smmu_domain_stage { > ARM_SMMU_DOMAIN_S2, > ARM_SMMU_DOMAIN_NESTED, > ARM_SMMU_DOMAIN_BYPASS, > + ARM_SMMU_DOMAIN_ABORT, > }; > > /* Xen specific code. */ > diff --git a/xen/drivers/passthrough/arm/vsmmu-v3.c b/xen/drivers/passthrough/arm/vsmmu-v3.c > index 916b97b8a2..5188181929 100644 > --- a/xen/drivers/passthrough/arm/vsmmu-v3.c > +++ b/xen/drivers/passthrough/arm/vsmmu-v3.c > @@ -223,8 +223,11 @@ static int arm_vsmmu_handle_cfgi_ste(struct virt_smmu *smmu, uint64_t *cmdptr) > { > int ret; > uint64_t ste[STRTAB_STE_DWORDS]; > + struct domain *d = smmu->d; > + struct domain_iommu *hd = dom_iommu(d); > struct arm_vsmmu_s1_trans_cfg s1_cfg = {0}; > uint32_t sid = smmu_cmd_get_sid(cmdptr[0]); > + struct iommu_guest_config guest_cfg = {0}; > > ret = arm_vsmmu_find_ste(smmu, sid, ste); > if ( ret ) > @@ -234,6 +237,21 @@ static int arm_vsmmu_handle_cfgi_ste(struct virt_smmu *smmu, uint64_t *cmdptr) > if ( ret ) > return (ret == -EAGAIN ) ? 0 : ret; > > + guest_cfg.s1ctxptr = s1_cfg.s1ctxptr; > + guest_cfg.s1fmt = s1_cfg.s1fmt; > + guest_cfg.s1cdmax = s1_cfg.s1cdmax; > + > + if ( s1_cfg.bypassed ) > + guest_cfg.config = ARM_SMMU_DOMAIN_BYPASS; > + else if ( s1_cfg.aborted ) > + guest_cfg.config = ARM_SMMU_DOMAIN_ABORT; > + else > + guest_cfg.config = ARM_SMMU_DOMAIN_NESTED; > + > + ret = hd->platform_ops->attach_guest_config(d, sid, &guest_cfg); > + if ( ret ) > + return ret; > + > return 0; > } > > diff --git a/xen/include/xen/iommu.h b/xen/include/xen/iommu.h > index 4f22fc1bed..b2fc027e5e 100644 > --- a/xen/include/xen/iommu.h > +++ b/xen/include/xen/iommu.h > @@ -230,6 +230,15 @@ int iommu_do_dt_domctl(struct xen_domctl *, struct domain *, > > #endif /* HAS_DEVICE_TREE */ > > +#ifdef CONFIG_ARM > +struct iommu_guest_config { > + paddr_t s1ctxptr; > + uint8_t config; > + uint8_t s1fmt; > + uint8_t s1cdmax; > +}; > +#endif /* CONFIG_ARM */ > + > struct page_info; > > /* > @@ -302,6 +311,11 @@ struct iommu_ops { > */ > int (*dt_xlate)(device_t *dev, const struct dt_phandle_args *args); > #endif > + > +#ifdef CONFIG_ARM > + int (*attach_guest_config)(struct domain *d, u32 sid, > + struct iommu_guest_config *cfg); > +#endif > }; > > /* > -- > 2.25.1 > > From xen-devel-bounces@lists.xenproject.org Tue Jan 03 16:22:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 Jan 2023 16:22:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470668.730241 (Exim 4.92) (envelope-from ) id 1pCk3q-0005z7-Mq; Tue, 03 Jan 2023 16:22:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470668.730241; Tue, 03 Jan 2023 16:22:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCk3q-0005z0-Je; Tue, 03 Jan 2023 16:22:46 +0000 Received: by outflank-mailman (input) for mailman id 470668; Tue, 03 Jan 2023 16:22:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCk3p-0005yp-HC; Tue, 03 Jan 2023 16:22:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCk3p-0007FY-EX; Tue, 03 Jan 2023 16:22:45 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCk3o-0003tk-Uw; Tue, 03 Jan 2023 16:22:45 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pCk3o-0006uX-UY; Tue, 03 Jan 2023 16:22:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=zCmiLNKq5IvoyoJImn8u+ON/yqdwLEQ9u9RwZk0AlaU=; b=zs4LFuy8rOMAmDanYghrn97svH V90jjkR7avSlEUAmi+T8ii5LY/qDOyxXCeSkgifxvLk57KrHbbpT6H7whT86WX43eeicdpZVKiggG NjFpi9S91dA+B/SS95kqjRTtEFi9zyzjreE7KYGxw1q6XM3P7ZJ8Zb5chi8qLqrT16jk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 175556: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=69b41ac87e4a664de78a395ff97166f0b2943210 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Tue, 03 Jan 2023 16:22:44 +0000 flight 175556 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/175556/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine 8 reboot fail REGR. vs. 173462 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux 69b41ac87e4a664de78a395ff97166f0b2943210 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 87 days Failing since 173470 2022-10-08 06:21:34 Z 87 days 181 attempts Testing same since 175552 2023-01-02 21:13:23 Z 0 days 2 attempts ------------------------------------------------------------ 3257 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 497265 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Jan 03 17:03:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 Jan 2023 17:03:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470677.730252 (Exim 4.92) (envelope-from ) id 1pCkhD-0001se-O9; Tue, 03 Jan 2023 17:03:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470677.730252; Tue, 03 Jan 2023 17:03:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCkhD-0001sX-Kt; Tue, 03 Jan 2023 17:03:27 +0000 Received: by outflank-mailman (input) for mailman id 470677; Tue, 03 Jan 2023 17:03:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCkhC-0001sN-9n; Tue, 03 Jan 2023 17:03:26 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCkhC-0008AA-63; Tue, 03 Jan 2023 17:03:26 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCkhB-0004o3-Rk; Tue, 03 Jan 2023 17:03:25 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pCkhB-0001cS-RJ; Tue, 03 Jan 2023 17:03:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=XTDO45LiqFqn+Hn/GBMBcWBxChM+LfX28bE2ABfufN0=; b=pGeWsLz/BTKBdq435hEHHPpY24 E/wG0i8kFN0wX6YEF08Rl7d/t7XyrC6yUgDwwT3HRX0WgNP58kyXs9XxbaZcPxeCyTEdc3yegzI7X 1eXrv+z4IicwhXN1/7td83wSjzNWbkOPiPTBH3A52XFOgKI9I0+msh9D3gfOV5S6SXAo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 175557: FAIL X-Osstest-Failures: linux-5.4:test-armhf-armhf-xl-credit1::broken:regression linux-5.4:test-armhf-armhf-xl-credit1:host-install(5):broken:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug linux-5.4:test-amd64-i386-xl-vhd:guest-start.2:fail:heisenbug linux-5.4:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug linux-5.4:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=851c2b5fb7936d54e1147f76f88e2675f9f82b52 X-Osstest-Versions-That: linux=66bb2e2b24ce52819a7070d3a3255726cb946b69 From: osstest service owner Date: Tue, 03 Jan 2023 17:03:25 +0000 flight 175557 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/175557/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit1 broken in 175547 Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-credit1 5 host-install(5) broken in 175547 pass in 175557 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail in 175545 pass in 175557 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail in 175545 pass in 175557 test-amd64-i386-xl-vhd 22 guest-start.2 fail in 175547 pass in 175545 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail in 175547 pass in 175557 test-armhf-armhf-xl-credit1 14 guest-start fail in 175551 pass in 175557 test-armhf-armhf-xl-credit2 14 guest-start fail in 175551 pass in 175557 test-armhf-armhf-xl-multivcpu 14 guest-start fail in 175553 pass in 175557 test-armhf-armhf-xl-vhd 17 guest-start/debian.repeat fail in 175553 pass in 175557 test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail pass in 175547 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 175551 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail pass in 175553 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail blocked in 175197 test-armhf-armhf-xl-arndale 18 guest-start/debian.repeat fail in 175553 blocked in 175197 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 175197 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 175197 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175197 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 175197 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175197 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175197 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 175197 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 175197 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail like 175197 test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail like 175197 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 175197 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 175197 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 175197 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175197 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 3 hosts-allocate starved in 175547 n/a version targeted for testing: linux 851c2b5fb7936d54e1147f76f88e2675f9f82b52 baseline version: linux 66bb2e2b24ce52819a7070d3a3255726cb946b69 Last test of basis 175197 2022-12-14 10:43:17 Z 20 days Testing same since 175407 2022-12-19 11:42:26 Z 15 days 37 attempts ------------------------------------------------------------ People who touched revisions under test: Alexei Starovoitov Andrew Morton Baolin Wang Charles Keepax Florian Fainelli Greg Kroah-Hartman Guenter Roeck Heiko Schocher Hulk Robot Jakub Kicinski Jialiang Wang Jon Hunter Linus Walleij Linux Kernel Functional Testing Lorenzo Colitti Maciej Żenczykowski Marc Kleine-Budde Mark Brown Ming Lei Paul E. McKenney Ricardo Ribalda Samuel Mendoza-Jonas Sasha Levin Shiwei Cui Shuah Khan Simon Horman Sudip Mukherjee Yasushi SHOJI Yasushi SHOJI jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-armhf-armhf-xl-credit1 broken Not pushing. (No revision log; it would be 410 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Jan 03 17:26:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 Jan 2023 17:26:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470688.730263 (Exim 4.92) (envelope-from ) id 1pCl2r-0004Q8-Nh; Tue, 03 Jan 2023 17:25:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470688.730263; Tue, 03 Jan 2023 17:25:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCl2r-0004Q1-Ji; Tue, 03 Jan 2023 17:25:49 +0000 Received: by outflank-mailman (input) for mailman id 470688; Tue, 03 Jan 2023 17:25:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCl2p-0004Pv-9n for xen-devel@lists.xenproject.org; Tue, 03 Jan 2023 17:25:48 +0000 Received: from sonic305-20.consmr.mail.gq1.yahoo.com (sonic305-20.consmr.mail.gq1.yahoo.com [98.137.64.83]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a64ebdcc-8b8b-11ed-91b6-6bf2151ebd3b; Tue, 03 Jan 2023 18:25:44 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic305.consmr.mail.gq1.yahoo.com with HTTP; Tue, 3 Jan 2023 17:25:41 +0000 Received: by hermes--production-ne1-7b69748c4d-7hwnr (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 82ee4ab4f4bd9b6bcc4691c031bc8c2e; Tue, 03 Jan 2023 17:25:36 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a64ebdcc-8b8b-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1672766741; bh=BQrajt4wazRs/IHuCnNgKkNdztR9Jg2pmYu2J+B7rHE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=MWkZBW23xhtaKL1h1Y0DanzZgzC9tYI/+m4L8tapKm3VckHEyr4IKBKbt2karoTLcVff2Rzi4Y5XNLNCb0bPm5I+ipKxq63QIYuHQbEGlxZ6ODcsmt+WA6z2clSqp73iNijF2uZjEdOOfjJo53wsQkAIWwKhpYFjyuCNrO9SyqAAl1SoBdpgAJSSmKRCFCcAz/91QXdhjtMO4aD05AV0jbdhtMuBxFwVCYQGwUefbBxB6fapNDZZJDoypx8Qys8rFkCCUkA62AXAei8GDiCDpfxTdubgFKOJfKSHYEZFqzb04k/Sx1upwmzdmSbnm2Hp6mHQV4hc1gmsV+jCs8NpUg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1672766741; bh=Q7Gnch2KYK2DKvvEQImsPlGPBX0A629TKeRg29/A8EE=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=mof7SKRASPArXL2gtemBJPLd0mREs96QXV1acGqUuAHynSzRDGaw8Wu+EX7leobknIu7iKptkgx60XyiDLy1OPhgHAIjnPNDMNWGidPOd4yBAoG1Al0u/gojbvZGVe5R1Lya/ei+RnmXHiMlFCS0h3K13/XUrXBZdfKuRXEkXE3O35E5NXnmvzLfcd0baS06B102tjQPpyfiWI/dHTgVXZbyvTwBdkyb4YD0tjXXqG4HbUJTsAarKTd/BqQYuc+0P6NgweedkzHN5/DlJFbFz9bVhqqCpns2WgWH6HTf8tBMRqwx6sGC7sr7DKBHplQtcaR0bp1sByimvapXoqxsqg== X-YMail-OSG: ny44inEVM1l0o89yZjgXBU7LE7onIq0HkXAJb04On7SUMzGglQaXKHGEWbCdbXB pmtWDTz0hbtpwQwDQdKrNh39Zp5m.O4Fj8UzgRiJNrfoovSEieMGvk3PRI7G3OeyN1wf8dtCb2fU lIuCZdt_FzLFBPLLUQKK59mu6QyzsjiQ.MA2CL3GglAx.pHzyz1gcWtEF3E4A2WERHEiSN47ztBk vA_nx_mve0L1iBQviDPoysrv_Dv6A401Z8nWr08svddzs6_Lbc3pcpi5dSvqxavNRMcSCwLT6poG AP8fUICvBp50lOthZFFZwQT9ULK5rEKLCmhYLV2nEPEM4uKz2lYveZQqHEEj3Se9MCm0fnHQX.Av eWxHZi0ci1N63I0ZQpHBUrUiZ_Ja89TIIUj1IHi3fXG_ezTJAjAitU4dDn9DtPGwQzD6vpIwP2dw Mz1rM9mIMFjcEnTil.iLvPnDm27rD0FL8NU43hlzh7Rn3Cs8Vpg_brBeuqS4tLGq.T0XgmW_LUlj MevjUuIOwAkBlZ8WQuQrAww71HAQa_q.vTJmZbIu1W4Wg_Ap5WYnvl6iA.a4YWu5nl1O5.za1rX3 3JVeLg8e9wr2tPg4s_QOLwAQ4JyTLH_AH4mCZZEpycm_06_Lw.k4VaNKKziz1pOP4mFi8B8XIbgt nELLx6LD10127YlU9Kz.me5IiFC_YIY9c6HsK3.YiNVMVuN1QO8YELfEzOGiCjJ29E.FgOz9vPed QYiGVNmRS_WJAUzg.lUxZX_YW26wLaPeaw8.Rdn.x5oud2.cy7khkWsEr7os2WMeeKimm2ck4FYs AI7TbzN0qkHZ5seroGCG1CNnQU1gcgKw8SR449tFz4nhp5Bddsv7VL6P54ua8QrBoxFh28hhZgo1 84zal0QCIM6pbyIff8BL_zRFnbW56PZ2bHmLrUBoraOTaVcEY2p1WO0iE73_BBuSCSWHPOOhRG49 1ugaJ8SlzuHlnSGLcFGsHI1lEGwVwwcoqdYyHk4AbvqVtHhP1F7kml8h863Z7yrJIg3JInK.eb5a RMfNR9VhhyQDPVHbGL7SLhEx27Zdy6dVmGmv96OFZ29gdGXhOBGKuvmpiIOgBPxKe5WKKl3Mn6m_ B8CosT0xV4IIk.Q2v1iGJSm0J7P881Eehr52j5K9QwkILs.9tvkeZJ8xwcOB53xoEEHUiCFNJdki 1L.Rx37MYVoMi1FLKWMoSdGjvaa2ffAfLsO8gtL2SujvwD6jiiJQss0.MYtLUI3MaxKUHwiw4V9v Q6UxoStJG_8xM_JZWD8vVxkPl6XGC_NWumKgLxTFHHXTR.45Fddbn.89QpWmAFLUeHr85dLo2VDu iz1KPlb8jKa5EoksQuGN2dHhBxqdhyLfgoACHqXeMzzWik65x51kBk9zSDNJee2IMP6upuDjt02_ TO9owR24rQbCtO69dUSaizmN60t.16Yr3_iX92NOyQcrLhlD6CCgAvUYXKpSRBBoNSY26Q.oCjEx JcrZDLz0Akcy1PD.RUGB8ujrQaJSP6GMa1dMSm5r94wWzaXsY8a226lrtxxhjCvFfihStkYhfk1s _rlgw9ThgSZJinU2JZp1tEtglK.ZJwHrkKaf0Fk8IcannH5gJtR2lAPx_9Z2lvTRbj1DeiUQe8I5 rGUnYmhKPYL7TLLzZjoQ_2aClfkGMQj5QHf57B7oTlWIX7k4TjpgfXduxedaXrr8CriQ993AgjdN BAVE.9._rB1T_pyKSznCLu1DnLcmko7VBnPRjF3jsMW_nWKeMPppVnytd56NF4yRAWJ35Tf1KCUZ jt046_JMEx1MpFLgf5QDmbZXH6kj8.H95aTch0Gg.UA0nXWUo5TTQLGAx6DpJ0HKtmn.WQehXQWv au0g7rUxzWEkHDVJrwGKKFspT8Xfw._VxuO1cqNzagTcIbI3KWHVrFj759GdWobklFaekSZQ8Jh_ oztf0Nx7QIN2vk_KPhcQhHONf0tNJlpVcy9KZ97EQmpn4tLeLipY5cECcRpXk0cxUGb.a05t4OvI wk.Dy1tethPFxK.DsMSnkmepWfMc4Vi7uJeYastmy99mgOvSmAkN1WixcIEjCYgazYqG4eJ4nP.a rSEk8helJW93kYoS2hqPQoBHB4Q0ocIzic3jIEZ2mfmqvGCfGCk_B3Nuz1T7TWEwIHjlKtfvtgUA k8i2n6BqQ2XazK6JaY7DqSKtrd6xbIBKMdt6CvizK1vkCsjEL66UVJXyZPJg3rhYfI_rHcCZWZGD w1XDPplRRvqzeXI0s.GhMng-- X-Sonic-MF: Message-ID: <6360e4a1-dc2b-685e-5e19-62b92eec695b@aol.com> Date: Tue, 3 Jan 2023 12:25:35 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 0/6] Resolve TYPE_PIIX3_XEN_DEVICE To: Bernhard Beschow , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Cc: qemu-devel@nongnu.org, Paul Durrant , Marcel Apfelbaum , "Michael S. Tsirkin" , Stefano Stabellini , Anthony Perard , Aurelien Jarno , Eduardo Habkost , xen-devel@lists.xenproject.org, =?UTF-8?Q?Herv=c3=a9_Poussineau?= , Paolo Bonzini , Richard Henderson References: <20230102213504.14646-1-shentey@gmail.com> <0de699a7-98b8-e320-da4d-678d0f594213@linaro.org> Content-Language: en-US From: Chuck Zmudzinski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.20982 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 3727 On 1/3/2023 8:38 AM, Bernhard Beschow wrote: > > > On Tue, Jan 3, 2023 at 2:17 PM Philippe Mathieu-Daudé wrote: > > Hi Chuck, > > On 3/1/23 04:15, Chuck Zmudzinski wrote: > > On 1/2/23 4:34 PM, Bernhard Beschow wrote: > >> This series first renders TYPE_PIIX3_XEN_DEVICE redundant and finally removes > >> it. The motivation is to 1/ decouple PIIX from Xen and 2/ to make Xen in the PC > >> machine agnostic to the precise southbridge being used. 2/ will become > >> particularily interesting once PIIX4 becomes usable in the PC machine, avoiding > >> the "Frankenstein" use of PIIX4_ACPI in PIIX3. > >> > >> Testing done: > >> None, because I don't know how to conduct this properly :( > >> > >> Based-on: <20221221170003.2929-1-shentey@gmail.com> > >>            "[PATCH v4 00/30] Consolidate PIIX south bridges" > > This series is based on a previous series: > https://lore.kernel.org/qemu-devel/20221221170003.2929-1-shentey@gmail.com/ > (which itself also is). > > >> Bernhard Beschow (6): > >>    include/hw/xen/xen: Make xen_piix3_set_irq() generic and rename it > >>    hw/isa/piix: Reuse piix3_realize() in piix3_xen_realize() > >>    hw/isa/piix: Wire up Xen PCI IRQ handling outside of PIIX3 > >>    hw/isa/piix: Avoid Xen-specific variant of piix_write_config() > >>    hw/isa/piix: Resolve redundant k->config_write assignments > >>    hw/isa/piix: Resolve redundant TYPE_PIIX3_XEN_DEVICE > >> > >>   hw/i386/pc_piix.c             | 34 ++++++++++++++++-- > >>   hw/i386/xen/xen-hvm.c         |  9 +++-- > >>   hw/isa/piix.c                 | 66 +---------------------------------- > > > > This file does not exist on the Qemu master branch. > > But hw/isa/piix3.c and hw/isa/piix4.c do exist. > > > > I tried renaming it from piix.c to piix3.c in the patch, but > > the patch set still does not apply cleanly on my tree. > > > > Is this patch set re-based against something other than > > the current master Qemu branch? > > > > I have a system that is suitable for testing this patch set, but > > I need guidance on how to apply it to the Qemu source tree. > > You can ask Bernhard to publish a branch with the full work, > > > Hi Chuck, > > ... or just visit https://patchew.org/QEMU/20230102213504.14646-1-shentey@gmail.com/ . There you'll find a git tag with a complete history and all instructions! > > Thanks for giving my series a test ride! > > Best regards, > Bernhard > > or apply each series locally. I use the b4 tool for that: > https://b4.docs.kernel.org/en/latest/installing.html > > i.e.: > > $ git checkout -b shentey_work > $ b4 am 20221120150550.63059-1-shentey@gmail.com > $ git am > ./v2_20221120_shentey_decouple_intx_to_lnkx_routing_from_south_bridges.mbx > $ b4 am 20221221170003.2929-1-shentey@gmail.com > $ git am > ./v4_20221221_shentey_this_series_consolidates_the_implementations_of_the_piix3_and_piix4_south.mbx > $ b4 am 20230102213504.14646-1-shentey@gmail.com > $ git am ./20230102_shentey_resolve_type_piix3_xen_device.mbx > > Now the branch 'shentey_work' contains all the patches and you can test. > > Regards, > > Phil. > OK, I didn't see the "Consolidate PIIX south bridges" series is a prerequisite. I will try it - it may take a couple of days because I need to test both patch series in my environment and I can only work on this in my spare time. I will provide Tested-by tags to both series if successful. Otherwise, I will reply with an explanation of any problems. Chuck From xen-devel-bounces@lists.xenproject.org Tue Jan 03 18:39:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 Jan 2023 18:39:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470695.730275 (Exim 4.92) (envelope-from ) id 1pCmBl-0003KZ-1Q; Tue, 03 Jan 2023 18:39:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470695.730275; Tue, 03 Jan 2023 18:39:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCmBk-0003KS-S7; Tue, 03 Jan 2023 18:39:04 +0000 Received: by outflank-mailman (input) for mailman id 470695; Tue, 03 Jan 2023 18:39:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCmBi-0003KM-Tg for xen-devel@lists.xenproject.org; Tue, 03 Jan 2023 18:39:03 +0000 Received: from sonic309-21.consmr.mail.gq1.yahoo.com (sonic309-21.consmr.mail.gq1.yahoo.com [98.137.65.147]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e1a14f44-8b95-11ed-b8d0-410ff93cb8f0; Tue, 03 Jan 2023 19:38:58 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic309.consmr.mail.gq1.yahoo.com with HTTP; Tue, 3 Jan 2023 18:38:56 +0000 Received: by hermes--production-ne1-7b69748c4d-ljcdv (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID e8d8eabb7d2095d26a89087287432376; Tue, 03 Jan 2023 18:38:52 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e1a14f44-8b95-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1672771136; bh=jk/KLNiyy/FQvaIWK2eHg0WptgKxIBRh7IHFHEKYpQE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=hv7CP/giOX1qsGY0VIw1lh1/GYpUIzG/RE4PDQgN5oDHkURma2JkFbatER7UZo6h661DRV0dp/L4GMbmLRuMXCuEtuyt3RMJG7EWROoBbNHxnzMsZkJBLjm1aBJRfZKcypIkntELcAqUq/dxHgvYwE/v5onddTgU0Da3Lh27nqVKuJgTpy+DAL+5iE8vBhyBEe0wctaEG3Wl3+/HN/O1x9ifQd+O32FBoylMWYMkbzs9Rb4QzbqcS7traVjAX87v0yXvE+1jkUKSZkZVKK/C0kRYtCrj3hAQa4mEYtTePktIPWvuCYr/nezRBE5/DshfUxurZZhw+oru/GmFM79vRA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1672771136; bh=hRuGRUez3Oizt3ToDFhsg/1SZnSh4jC6hJlllWzQatj=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=IvaoES6iP1QGItnVNQAEOVWCUELU/Dgq6gEpPs2abS1gu2cTAJlZPHjbIi5RM/7/618RBrH8RCHC+6/elZLq1tBFBv3ug2KdCnSNrknqlN9AYOAZ/vFu5edtn4FtUvt243J+Y8r0KPuowkN2Ir50GG7nqktEAapa7il14xrma9z0936wSestfJzL6ILDKII+vgX0CMS7UlaHh0UZ+k5+5I6wnYSFM+4uw5vfWpDqS/Kgh+uYfRqnF1hxXL4zMRthKvLp0pnyVP6WwcJ1q59QFVmBOVPTqMA7WWLKQEslNb24yPVNro/Ud/pmRAciffLNn1bGi0SVLM8+2MyDefazBA== X-YMail-OSG: Pxqkev0VM1kZ9lcHp3BG8TNw_e4OtoPcljfhZXr9f.UAqZk_9eDy5yZKdcIVkat e8rbybkHsnbzus0vOKoiBlRJ1TOHJU6URU7aenVuc9aawjXoGsMzYSRD.Tqjl8OdY14mlbKE7Uj1 6i6eQqq8CMVTqINo0q7Pp3KYnBvdvRFOs3Gb99icY4PfZbTnLhV3NlyEY7NaKRAKokJqPutPotfz qLAVSVYsqs.5MMLzcz8EIp6lestsZw5XGsbG_FhFST7FDHfR_A4At1NYxCsRQd43ythspegLc32N eQoZleQrdgUvDxg1xmd0L8rCZpmn6NS4ADNK5qnJTYume4epZXbvOAjnRgiqukd1kkOJb4Ey6RE5 J6MGKuQVpHSuGhVXTXpJY6h8zV7y5EV3hhxNP9TAgn1LdrrOYNexkbbrcl9SUCK__GH_pYqNF8Wj n22tmFEvARbDR_v7AMw4RVwf4stvoM0lYUen6KJSbD40Tg0SiPgdPDLbdOsvdJ_HdP4NJoR4EGz1 LYFSnnTvVp5utKncHJLBY5CS87bNaHiE.OxVWfu7kGO9rUFtAk2adia2HaFLwq67AxCQHr8FtBai _TlmciLzTMwAmHpYikazEDtU48R65SIaougDhaYdtO.S4OKoKvM4Z0fqxWrLtluaFwbabdm1X9t. 64VbVnqaqzejohCwuyq31dFojfAKYvNSlJhqMLMBKDokuaW5QRTyzxxj6qkPmHhiZ1j2jMSuxpK4 fD9aBZxlTto8sZclslhKRcfatKhbdDz3uiCkAVey.tHCuKHNzDgmLBRr7ZAr1Uu1jFmy8u87BeAr diLKufT_vSVbGGABb49xpHkTVrCtXxNrrzScmJlzdd3BPbhjkAOM38.farQ3J3IhvCdl0nAUFbi_ 4S9SC6jSKlkTK.Pn0578mZLjH154133AKPpcxameaPBLM_RFJevXLWdoaDCtStimet5pWNRnIeaT Z044PksPv.B1jo0W7zQi4zg6mGHVCu.asdiqKqDBE6ZajUVU9HfykIl.S5a.jdjGBbjCJSsOow7X u0tZx8YyclHQrSN6rxKyTv5uzt9yQMVjuIZ0q0AAWf2EFxtOOAz5U7taRRY7ZUWAraCxFovKbQJL S_Cyy5w1i0BBNj9kB0xMrtlkJcoPukOMVYJ_xZGdoT_4Kw7NADoY9AlOvkraqBzTZYO_eievY7Wc UXCl2Ns4z6TjVYsYnhotJt1zxEGtN_KenBycSwcS0s6y46Wl0jRO3CKklDZzEWTkJ74aSisFrThe gyjiGdlr4NiLGDlyfr2Jszz_5O37Ql6KQZkfl.QcvsmsiIt5VaJq2rPcRWGzccl6u4mwyr2p6go8 aXcjWVlD7NhuQ.XwdttT7Y3YMgzmM4do969H.qfLSd7KgZ7Hq8jDvnW5weEaat1bS_et7ISeRRy8 RGtJov3SiBPeVupZY.NAulXJjfirNjozS_hZPO6ax4LyO0DnCciELWuxJ80mYde2CyUwHLe0swOr aFPGy7Rt8O2tJj.qEPljplt2wuGN3L5AG_nMCiZ0XrJTDIalwEAsXm9YCCGkGwlRFw9moriwRDkA 3yd_uCxI2eRh7bwRq1xF8LqncVR6EhTTXBYUSStfHl39U.lTi.Q.1UdQZVQ_whhDdMmSnMZFm6lx rMxS54DRavOwxm6nIha87._oytTKn1gACIpvi5A0H2V_x9zyUK7zodw67M31zywb.PzJQD4CC5tZ XDZzqPP2V4FwneNvO0UH.eKjjq6CDlonYn.nsjhOgPi6La_2M_bIscIQPrIhIWM6aMu76T648yLg ttuAcpvL3XcCjY0EE.e1JngxQcTlhZCLFqWhcacDak2W5CUAQSzLOU0dhOGKjbUV6EeIjp9UKRMq G2tVWQRNOJJnRbGuNIKkduMaMzQx7k6cW9yqDzIdTytvyXeBjf8Malgf8k.T9txoreie9ftH02EL HcIW.GZjvuc7e3XJS9EC7CW0A_EHaucrEa5XTaiPoB3l8hjFmy5EtQkrl2Cidx3eGCSTtnw.TmQQ m.EPiBIgR1U8mQCjTAEaGEZWrcJNp0yuMJhbrFvEna9Wk_0s9P2LH.mOMp0BVgbC7D2sAIK827e8 gyROrL9kbLBU4GbH8yFSM0bQIkYaFk9ID3tQTkEpyn7G6pFhakrFhfhthhFfvz3D84ZhxsWKdQUr EfY3wtOgAS91a4uIAwXCjrm.Qw6Sf5DQmNZgzYTE63jt.STtw0jhdWrCWPT5hGJIl6a98XCK5dIZ VIzixOEE7GW1Leho- X-Sonic-MF: Message-ID: Date: Tue, 3 Jan 2023 13:38:51 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v6] xen/pt: reserve PCI slot 2 for Intel igd-passthru To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org, Stefano Stabellini , Anthony Perard , Paul Durrant , Paolo Bonzini , Richard Henderson , Eduardo Habkost , Marcel Apfelbaum , xen-devel@lists.xenproject.org, alex.williamson@redhat.com References: <830263507e8f1a24a94f81909d5102c4b204e938.1672615492.git.brchuckz.ref@aol.com> <830263507e8f1a24a94f81909d5102c4b204e938.1672615492.git.brchuckz@aol.com> <20230102124605-mutt-send-email-mst@kernel.org> Content-Language: en-US From: Chuck Zmudzinski In-Reply-To: <20230102124605-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailer: WebService/1.1.20982 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 5456 On 1/2/2023 12:46 PM, Michael S. Tsirkin wrote: > On Sun, Jan 01, 2023 at 06:52:03PM -0500, Chuck Zmudzinski wrote: > > Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, > > as noted in docs/igd-assign.txt in the Qemu source code. > > > > Currently, when the xl toolstack is used to configure a Xen HVM guest with > > Intel IGD passthrough to the guest with the Qemu upstream device model, > > a Qemu emulated PCI device will occupy slot 2 and the Intel IGD will occupy > > a different slot. This problem often prevents the guest from booting. > > > > The only available workaround is not good: Configure Xen HVM guests to use > > the old and no longer maintained Qemu traditional device model available > > from xenbits.xen.org which does reserve slot 2 for the Intel IGD. > > > > To implement this feature in the Qemu upstream device model for Xen HVM > > guests, introduce the following new functions, types, and macros: > > > > * XEN_PT_DEVICE_CLASS declaration, based on the existing TYPE_XEN_PT_DEVICE > > * XEN_PT_DEVICE_GET_CLASS macro helper function for XEN_PT_DEVICE_CLASS > > * typedef XenPTQdevRealize function pointer > > * XEN_PCI_IGD_SLOT_MASK, the value of slot_reserved_mask to reserve slot 2 > > * xen_igd_reserve_slot and xen_igd_clear_slot functions > > > > The new xen_igd_reserve_slot function uses the existing slot_reserved_mask > > member of PCIBus to reserve PCI slot 2 for Xen HVM guests configured using > > the xl toolstack with the gfx_passthru option enabled, which sets the > > igd-passthru=on option to Qemu for the Xen HVM machine type. > > > > The new xen_igd_reserve_slot function also needs to be implemented in > > hw/xen/xen_pt_stub.c to prevent FTBFS during the link stage for the case > > when Qemu is configured with --enable-xen and --disable-xen-pci-passthrough, > > in which case it does nothing. > > > > The new xen_igd_clear_slot function overrides qdev->realize of the parent > > PCI device class to enable the Intel IGD to occupy slot 2 on the PCI bus > > since slot 2 was reserved by xen_igd_reserve_slot when the PCI bus was > > created in hw/i386/pc_piix.c for the case when igd-passthru=on. > > > > Move the call to xen_host_pci_device_get, and the associated error > > handling, from xen_pt_realize to the new xen_igd_clear_slot function to > > initialize the device class and vendor values which enables the checks for > > the Intel IGD to succeed. The verification that the host device is an > > Intel IGD to be passed through is done by checking the domain, bus, slot, > > and function values as well as by checking that gfx_passthru is enabled, > > the device class is VGA, and the device vendor in Intel. > > > > Signed-off-by: Chuck Zmudzinski > > I'm not sure why is the issue xen specific. Can you explain? > Doesn't it affect kvm too? Yes, it does, and of course this only applies to using the igd in a guest in legacy mode as described in docs/igd-assign.txt. Searching the web, I found this successful report of legacy igd passthrough using kvm: https://www.reddit.com/r/VFIO/comments/i9dbyp/this_is_how_i_managed_to_passthrough_my_igd/ That user posted the virtual machine xml on pastebin: https://pastebin.com/vYf3a1gz For reference, details of my configuration of legacy igd passthrough on xen are available on the xenproject wiki: https://wiki.xenproject.org/wiki/Xen_VGA_Passthrough_Tested_Adapters#Intel_display_adapters As I expected, with kvm, it is possible to specify the slot number of every pci device in the guest (as well as domain, bus, and function) in the xml configuration, but this is not easy to do with xen's xenlight (libxl) toolstack. That is why this patch is specific to xen. To further explain this: On xen, the xl.cfg guest configuration file does not allow the administrator to specify the slot number of the xen platform pci device, or of the emulated network device and disk controller, and one of these devices will grab slot 2 without this patch to qemu, making it impossible to have the passed through igd at slot 2 on xen without patching qemu. Another way to solve this problem on xen is to extend libxl so the administrator can specify the slot number of the emulated qemu pci devices, or possibly by using the xl.cfg device_model_args_hvm=[ "ARG", "ARG", ...] settings which might allow the administrator to control the slot number of the emulated qemu pci devices, and I tried that without success. This solution of patching qemu to reserve slot 2 for the intel igd when the qemu igd-passthru=on option for the xenfv machine type is set is a more simple solution to the problem on xen than trying to manually set all the slot numbers using the device_model_args_hvm option in xl.cfg. I think kvm users who desire this feature of legacy igd passthrough would benefit from something like the qemu igd-passthru=on option which, as far as I know, only applies to the xenfv machine type that is enabled with the gfx_passthru setting in the xl.cfg configuration file. Such an option for kvm could allow for qemu to take care of all the details of configuring the vm correctly for igd legacy passthrough on kvm instead of requiring the administrator to manually specify all the settings correctly in the xml configuration file. I think making igd legacy passthrough easier to configure on kvm would be a useful patch, but it is beyond the scope of what this patch is trying to accomplish. Chuck From xen-devel-bounces@lists.xenproject.org Tue Jan 03 20:10:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 Jan 2023 20:10:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470703.730296 (Exim 4.92) (envelope-from ) id 1pCnbm-0004km-MH; Tue, 03 Jan 2023 20:10:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470703.730296; Tue, 03 Jan 2023 20:10:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCnbm-0004kF-J9; Tue, 03 Jan 2023 20:10:02 +0000 Received: by outflank-mailman (input) for mailman id 470703; Tue, 03 Jan 2023 20:10:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCnbl-0004TZ-Bx for xen-devel@lists.xenproject.org; Tue, 03 Jan 2023 20:10:01 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 97c03ea5-8ba2-11ed-b8d0-410ff93cb8f0; Tue, 03 Jan 2023 21:09:58 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 97c03ea5-8ba2-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1672776598; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=/mBbqgiiuNZanVYbh0nZVNE+sEURAYgdK6CFKGtITFc=; b=RNyF8re0u6gsjimsCEUzigihal79cUqMyWBE5z8TpwKxL6lmH/4GcjHd B9DsC1uRN8NSIrSjc7LdOjPuMVP50ubTXE0lP/oRJ/mNdm6fzakgXyL5w gwto9jLvqkV+EG5z1mNDbzXV4P/n38YVMBuv91z2s2koE8SRimRn768im 4=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 90516756 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:k8kcW6sr222vbiNZasQ29fFuCufnVGBeMUV32f8akzHdYApBsoF/q tZmKTuAP/fcNmWhf910YIqwp04HuMDczdM1SQNq+XxhQytH+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg0HVU/IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj5lv0gnRkPaoQ5AaGzCFJZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwcQgPdkqxiNKKzLO3e8dIr8A8E+PxM9ZK0p1g5Wmx4fcORJnCR+PB5MNC3Sd2jcdLdRrcT 5NHM3w1Nk2GOkARfAdMYH49tL7Aan3XWjtUsl+K44Ew5HDe1ldZ27nxKtvFPNeNQK25m27J/ j+foTukXHn2MvSu+weD1SqAn9PtlBLcAb4cTrCk8uxT1Qj7Kms7V0RNCArTTeOColWlR9tVJ kgQ+ywvhas/7kqmSp/6RRLQiGGAlg4RXZxXCeJSwAOQzqvZ5S6JC25CSSROAPQEnsIrQT0h1 neSgsjkQzdotdW9WX+bs7uZsz62ESwUNnMZIz8JSxMf5Nvuq511iQjAJuuPC4bs0IezQ2uph WnX8m5u3N3/kPLnyY3ixVLf2QCjlqTFTwIEyCH+Wn2axBl2MdvNi5OT1XDX6vNJLYC8R1aHv WQZl8X20N3iHa1hhwTWHrxTQejBC+KtdWSF3AUxR8VJGyGFoSbLQGxG3N1pyK6F2O4gcCShX kLcsBg5CHR7bCrzNv8fj25c5q0XIUnc+TbNDKu8gjlmOMIZmOq7EMZGOyatM5jFyhRErE3GE c7znTyQJXgbE7976zG9Wv0Q17QmrghnmzyJGs+jn0T/iObODJJwdVviGALXBt3VEYve+FmFm zqhH5HiJ+pjvB3WPXCMrN97waEiJnknH5Hmw/Fqmhq4ClM+QgkJUqaBqY7NjqQ5x8y5YM+Up CDiMqKZoXKj7UD6xfKiMy06MOu2DMsv8hrW/0UEZD6V5pTqWq73hI93Snf9VeJPGDBLpRKsc 8Q4Rg== IronPort-HdrOrdr: A9a23:Ki5oxqqFSrmfBcOJouT2EOwaV5rveYIsimQD101hICG9Evb0qy nOpoV/6faQslwssR4b9uxoVJPvfZq+z+8W3WByB9eftWDd0QPFEGgL1+DfKlbbak7DH4BmtJ uJc8JFeafN5VoRt7eG3OFveexQvOVu88qT9JjjJ28Gd3APV0n5hT0JcjpyFCdNNW57LKt8Lr WwzOxdqQGtfHwGB/7LfUXsD4D41rv2fIuNW29+OyIa X-IronPort-AV: E=Sophos;i="5.96,297,1665460800"; d="scan'208";a="90516756" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Julien Grall Subject: [PATCH 2/4] xen/version: Drop compat/kernel.c Date: Tue, 3 Jan 2023 20:09:41 +0000 Message-ID: <20230103200943.5801-3-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20230103200943.5801-1-andrew.cooper3@citrix.com> References: <20230103200943.5801-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain kernel.c is mostly in an #ifndef COMPAT guard, because compat/kernel.c reincludes kernel.c to recompile xen_version() in a compat form. However, the xen_version hypercall is almost guest-ABI-agnostic; only XENVER_platform_parameters has a compat split. Handle this locally, and do away with the reinclude entirely. In particular, this removed the final instances of obfucation via the DO() macro. No functional change. Also saves 2k of of .text in the x86 build. Signed-off-by: Andrew Cooper --- CC: George Dunlap CC: Jan Beulich CC: Stefano Stabellini CC: Wei Liu CC: Julien Grall --- xen/common/Makefile | 2 +- xen/common/compat/kernel.c | 53 -------------------------------------------- xen/common/kernel.c | 43 ++++++++++++++++++++++------------- xen/include/hypercall-defs.c | 2 +- xen/include/xlat.lst | 3 +++ 5 files changed, 33 insertions(+), 70 deletions(-) delete mode 100644 xen/common/compat/kernel.c diff --git a/xen/common/Makefile b/xen/common/Makefile index 9a3a12b12dea..bbd75b4be6d3 100644 --- a/xen/common/Makefile +++ b/xen/common/Makefile @@ -59,7 +59,7 @@ obj-y += xmalloc_tlsf.o obj-bin-$(CONFIG_X86) += $(foreach n,decompress bunzip2 unxz unlzma lzo unlzo unlz4 unzstd earlycpio,$(n).init.o) -obj-$(CONFIG_COMPAT) += $(addprefix compat/,domain.o kernel.o memory.o multicall.o xlat.o) +obj-$(CONFIG_COMPAT) += $(addprefix compat/,domain.o memory.o multicall.o xlat.o) ifneq ($(CONFIG_PV_SHIM_EXCLUSIVE),y) obj-y += domctl.o diff --git a/xen/common/compat/kernel.c b/xen/common/compat/kernel.c deleted file mode 100644 index 804b919bdc72..000000000000 --- a/xen/common/compat/kernel.c +++ /dev/null @@ -1,53 +0,0 @@ -/****************************************************************************** - * kernel.c - */ - -EMIT_FILE; - -#include -#include -#include -#include -#include -#include -#include -#include -#include - -extern xen_commandline_t saved_cmdline; - -#define xen_extraversion compat_extraversion -#define xen_extraversion_t compat_extraversion_t - -#define xen_compile_info compat_compile_info -#define xen_compile_info_t compat_compile_info_t - -CHECK_TYPE(capabilities_info); - -#define xen_platform_parameters compat_platform_parameters -#define xen_platform_parameters_t compat_platform_parameters_t -#undef HYPERVISOR_VIRT_START -#define HYPERVISOR_VIRT_START HYPERVISOR_COMPAT_VIRT_START(current->domain) - -#define xen_changeset_info compat_changeset_info -#define xen_changeset_info_t compat_changeset_info_t - -#define xen_feature_info compat_feature_info -#define xen_feature_info_t compat_feature_info_t - -CHECK_TYPE(domain_handle); - -#define DO(fn) int compat_##fn -#define COMPAT - -#include "../kernel.c" - -/* - * Local variables: - * mode: C - * c-file-style: "BSD" - * c-basic-offset: 4 - * tab-width: 4 - * indent-tabs-mode: nil - * End: - */ diff --git a/xen/common/kernel.c b/xen/common/kernel.c index f8134d3e7a9d..ccee178ff17a 100644 --- a/xen/common/kernel.c +++ b/xen/common/kernel.c @@ -18,7 +18,13 @@ #include #include -#ifndef COMPAT +#ifdef CONFIG_COMPAT +#include + +CHECK_compile_info; +CHECK_feature_info; +CHECK_build_id; +#endif enum system_state system_state = SYS_STATE_early_boot; @@ -463,15 +469,7 @@ static int __init cf_check param_init(void) __initcall(param_init); #endif -# define DO(fn) long do_##fn - -#endif - -/* - * Simple hypercalls. - */ - -DO(xen_version)(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg) +long do_xen_version(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg) { bool_t deny = !!xsm_xen_version(XSM_OTHER, cmd); @@ -520,12 +518,27 @@ DO(xen_version)(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg) case XENVER_platform_parameters: { - xen_platform_parameters_t params = { - .virt_start = HYPERVISOR_VIRT_START - }; +#ifdef CONFIG_COMPAT + if ( current->hcall_compat ) + { + compat_platform_parameters_t params = { + .virt_start = HYPERVISOR_COMPAT_VIRT_START(current->domain), + }; + + if ( copy_to_guest(arg, ¶ms, 1) ) + return -EFAULT; + } + else +#endif + { + xen_platform_parameters_t params = { + .virt_start = HYPERVISOR_VIRT_START, + }; + + if ( copy_to_guest(arg, ¶ms, 1) ) + return -EFAULT; + } - if ( copy_to_guest(arg, ¶ms, 1) ) - return -EFAULT; return 0; } diff --git a/xen/include/hypercall-defs.c b/xen/include/hypercall-defs.c index 41e1af01f6b2..6d361ddfce1b 100644 --- a/xen/include/hypercall-defs.c +++ b/xen/include/hypercall-defs.c @@ -245,7 +245,7 @@ multicall compat:2 do:2 compat do do update_va_mapping compat do - - - set_timer_op compat do compat do - event_channel_op_compat do do - - dep -xen_version compat do compat do do +xen_version do do do do do console_io do do do do do physdev_op_compat compat do - - dep #if defined(CONFIG_GRANT_TABLE) diff --git a/xen/include/xlat.lst b/xen/include/xlat.lst index 65f7fe3811c7..f2bae220a6df 100644 --- a/xen/include/xlat.lst +++ b/xen/include/xlat.lst @@ -169,6 +169,9 @@ ! vcpu_runstate_info vcpu.h ? vcpu_set_periodic_timer vcpu.h ! vcpu_set_singleshot_timer vcpu.h +? compile_info version.h +? feature_info version.h +? build_id version.h ? xenoprof_init xenoprof.h ? xenoprof_passive xenoprof.h ? flask_access xsm/flask_op.h -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Tue Jan 03 20:10:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 Jan 2023 20:10:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470702.730284 (Exim 4.92) (envelope-from ) id 1pCnbf-0004EE-DW; Tue, 03 Jan 2023 20:09:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470702.730284; Tue, 03 Jan 2023 20:09:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCnbf-0004E7-As; Tue, 03 Jan 2023 20:09:55 +0000 Received: by outflank-mailman (input) for mailman id 470702; Tue, 03 Jan 2023 20:09:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCnbe-0004E1-CL for xen-devel@lists.xenproject.org; Tue, 03 Jan 2023 20:09:54 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 93d66c6d-8ba2-11ed-91b6-6bf2151ebd3b; Tue, 03 Jan 2023 21:09:52 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 93d66c6d-8ba2-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1672776592; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=2yFcSH2umpU0naapLlqvQU9WmOebWnbXbogEZZlzszQ=; b=NGhzt1fpRodRKYbZz8kndgdKkukR2L0+6sTWeGoXnbizLFxsR2VorXDx IkzjmWA/WAc7PILrIsreGejf0Rxs5pDf/OlGJLWhso3LElhhAZTjTx2Ov D1pd0wvgli+LX+mOZWQxpQyQIMNA/c9dxx+rNTdyOvopGqmomNsaob86O I=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 91025429 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:K79aoK27suSQTPsnj/bD5eVxkn2cJEfYwER7XKvMYLTBsI5bpzNTy mQbCDjXOfiOYjf9f9Ekb4rkoxgBuZCHnIVgTVBupC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK5ULSfUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS9nuDgNyo4GlD5gVmPqgX1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfPX588 KZfAjQ0cU7cmeuQkI66bukzr5F2RCXrFNt3VnBIyDjYCbAtQIzZQrWM7thdtNsyrpkQR7CEP ZNfMGcxKkSbC/FMEg5/5JYWteGknHTgNRZfr0qYv/Ef6GnP1g1hlrPqNbI5f/TbHJ0PwxrC9 woq+Uz1LhU2BfKv1gO68yuJvPHLxB6jYoI7QejQGvlC3wTImz175ActfUCgvfCzh0q6WtReA 08Z4Cwjqe417kPDZsb5dw21pjiDpBF0c9hNF+w37imdx6yS5ByWbkAmZDNcbN0ttOctWCcnk FSOmrvBFTFp9bGYV3+Z3rOVti+pfzgYK3cYYi0JRhdD5MPsyLzflTqWEIwlSvTsyISoR3egm FhmsRTSmZ0vkvwOjeKR+WnY3W2yr76Zcg8R5lr+CzfNAhxCWKapYImh6F7+5PlGLZqEQlTpg EXoi/Ry/8hVU8jTyXXlrPElWejwuq3baGG0bUtHRcFJyti7x5K0kWm8ChlaLVwhDMsLcCSBj KT76VIIv8870JdHgMZKj2ON5yYCl/OI+TfNDKq8gj9yjn9ZKme6ENlGPxL44owUuBFEfVsDE Zmaa92wKn0RFL5qyjG7L89Ej+BxmX9mlTOLHMyrp/hC7VZ5TCfMIYrpzXPUNrxphE96iF+9H ylj2zuilEwEDbyWjtj/+o8PN1EaRUUG6WTNg5UPLIare1M2cFzN/teNmdvNjaQ5xfUK/goJl 1nhMnJlJK3X3CCecV3TOy0zN9sCn/9X9BoGAMDlBn7ws1BLXGplxP13m0cfFVX/yNFe8A== IronPort-HdrOrdr: A9a23:MwMeY6B+wy/VSHDlHems55DYdb4zR+YMi2TDtnoBLyC9F/bzqy nApoV46faWslYssRMb6LW90cC7KBu2lKKdirNhWYtKMjOW31dA77sP0WIh+VDd8uHFmdK1HJ 0PT0DZZeeAbmRHsQ== X-IronPort-AV: E=Sophos;i="5.96,297,1665460800"; d="scan'208";a="91025429" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Julien Grall Subject: [PATCH 3/4] xen/version: Drop bogus return values for XENVER_platform_parameters Date: Tue, 3 Jan 2023 20:09:42 +0000 Message-ID: <20230103200943.5801-4-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20230103200943.5801-1-andrew.cooper3@citrix.com> References: <20230103200943.5801-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain A split in virtual address space is only applicable for x86 PV guests. Furthermore, the information returned for x86 64bit PV guests is wrong. Explain the problem in version.h, stating the other information that PV guests need to know. For 64bit PV guests, and all non-x86-PV guests, return 0, which is strictly less wrong than the values currently returned. Signed-off-by: Andrew Cooper --- CC: George Dunlap CC: Jan Beulich CC: Stefano Stabellini CC: Wei Liu CC: Julien Grall --- xen/common/kernel.c | 6 ++++-- xen/include/public/version.h | 20 ++++++++++++++++++++ 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/xen/common/kernel.c b/xen/common/kernel.c index ccee178ff17a..70e7dff87488 100644 --- a/xen/common/kernel.c +++ b/xen/common/kernel.c @@ -522,7 +522,9 @@ long do_xen_version(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg) if ( current->hcall_compat ) { compat_platform_parameters_t params = { - .virt_start = HYPERVISOR_COMPAT_VIRT_START(current->domain), + .virt_start = is_pv_vcpu(current) + ? HYPERVISOR_COMPAT_VIRT_START(current->domain) + : 0, }; if ( copy_to_guest(arg, ¶ms, 1) ) @@ -532,7 +534,7 @@ long do_xen_version(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg) #endif { xen_platform_parameters_t params = { - .virt_start = HYPERVISOR_VIRT_START, + .virt_start = 0, }; if ( copy_to_guest(arg, ¶ms, 1) ) diff --git a/xen/include/public/version.h b/xen/include/public/version.h index 0ff8bd9077c6..c8325219f648 100644 --- a/xen/include/public/version.h +++ b/xen/include/public/version.h @@ -42,6 +42,26 @@ typedef char xen_capabilities_info_t[1024]; typedef char xen_changeset_info_t[64]; #define XEN_CHANGESET_INFO_LEN (sizeof(xen_changeset_info_t)) +/* + * This API is problematic. + * + * It is only applicable to guests which share pagetables with Xen (x86 PV + * guests), and is supposed to identify the virtual address split between + * guest kernel and Xen. + * + * For 32bit PV guests, it mostly does this, but the caller needs to know that + * Xen lives between the split and 4G. + * + * For 64bit PV guests, Xen lives at the bottom of the upper canonical range. + * This previously returned the start of the upper canonical range (which is + * the userspace/Xen split), not the Xen/kernel split (which is 8TB further + * on). This now returns 0 because the old number wasn't correct, and + * changing it to anything else would be even worse. + * + * For all guest types using hardware virt extentions, Xen is not mapped into + * the guest kernel virtual address space. This now return 0, where it + * previously returned unrelated data. + */ #define XENVER_platform_parameters 5 struct xen_platform_parameters { xen_ulong_t virt_start; -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Tue Jan 03 20:10:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 Jan 2023 20:10:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470704.730307 (Exim 4.92) (envelope-from ) id 1pCnbo-0005CO-5e; Tue, 03 Jan 2023 20:10:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470704.730307; Tue, 03 Jan 2023 20:10:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCnbo-0005Bq-0q; Tue, 03 Jan 2023 20:10:04 +0000 Received: by outflank-mailman (input) for mailman id 470704; Tue, 03 Jan 2023 20:10:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCnbm-0004TZ-Sh for xen-devel@lists.xenproject.org; Tue, 03 Jan 2023 20:10:03 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9a018dc3-8ba2-11ed-b8d0-410ff93cb8f0; Tue, 03 Jan 2023 21:10:00 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9a018dc3-8ba2-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1672776600; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=JKdrRr7waCmGtSepF69W8Ba+E4SGmyEJw2vd/HieU84=; b=ffSbfg2XRS+ZCjyF/xrg7vJqJ8yWr+HTHFhj4+sdz3Tc2NX+mqRprw4k AoDajDy01nxfofsqU5pZzrrBtzup5rBynJbVgu4JIi6k3Ed3U12rG54c6 EZMfFwaSXVJ7+fbA+1LETXLD+ZSAleBS+1gmXfufsojCbV8NsXL2MLg09 s=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 90516757 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:rqrKsqJugGU/2yUtFE+R55UlxSXFcZb7ZxGr2PjKsXjdYENShjIDm GAdCmGGb/bbMWqhco10bI7jpENUvJeHyYQwGgdlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHv+kUrWs1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPdwP9TlK6q4mhA5wRlPawjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c4uOWNWr 84XGAwBbxyyqcafxK2EYPNj05FLwMnDZOvzu1llxDDdS/0nXYrCU+PB4towMDUY354UW6yEP oxANGQpPE+ojx5nYz/7DLoXmuuyi2a5WDpfsF+P/oI84nTJzRw327/oWDbQUo3SGJwLwRvHz o7A12LdKT1ABffc8jPbzHmto82fggnSUatHQdVU8dY12QbOlwT/EiY+TkCnqPO0jkq/XdN3K EEO/Ccq668o+ySDUd3VTxC+5nmesXY0WcdUEuA8wBGAzOzT+QnxLkouQyNFadcmnNQrXjFs3 ViM9/v5CDoqvLCLRHa18raPsSj0KSUTNXUFZyIPUU0C+daLnW0opkuRFJA5Svfz14CrX2Grq 9yXkMQgr+wrj9ZR5aqLwVzGjwOCgrHNUTEf/AqCCwpJ8ThFTIKiYoWp733S4vBBMJuVQzG9g ZQUpySNxLtQVM/QzURhVM1IRej0vKjdbFUwlHY1R/EcGyKRF2lPlGy6yBV3Pw9XP8kNYlcFi 2eD6FoKtPe/0JZHBJKbgr5d6exwlsAM9vy/DJg4i+aihbAvHDJrBAk0OSatM5nFySDAa50XN 5aBatqLBn0HE6lhxzfeb75DjuV0mXhulTuKGcCTI/GbPV22PSf9dFv4GAHWMrBRAF2s+m05D Oqzx+PVkk4CAYUSkwHc8JIJLEBiEEXX8ave8pQNHsbae1oOJY3UI6OJqV/XU9A/zvs9eyah1 i3VZ3K0P3Km2CSfcVzbNyA8AF4tNL4mxU8G0eUXFQ7A8xAejUyHt8/zq7NfkWEbydFe IronPort-HdrOrdr: A9a23:rENAKKPYHoXrDcBcTgWjsMiBIKoaSvp037BK7S1MoH1uA6mlfq WV9sjzuiWatN98Yh8dcLO7Scu9qBHnlaKdiLN5VduftWHd01dAR7sSjrcKrQeAJ8X/nNQtr5 uJccJFeaDN5Y4Rt7eH3OG6eexQv+Vu6MqT9IPjJ+8Gd3ATV0lnhT0JbTqzIwlNayRtI4E2L5 aY7tovnUvaRZxGBv7LYEXsRoL41qT2qK4= X-IronPort-AV: E=Sophos;i="5.96,297,1665460800"; d="scan'208";a="90516757" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Julien Grall Subject: [PATCH 4/4] xen/version: Introduce non-truncating XENVER_* subops Date: Tue, 3 Jan 2023 20:09:43 +0000 Message-ID: <20230103200943.5801-5-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20230103200943.5801-1-andrew.cooper3@citrix.com> References: <20230103200943.5801-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain Recently in XenServer, we have encountered problems caused by both XENVER_extraversion and XENVER_commandline having fixed bounds. More than just the invariant size, the APIs/ABIs also broken by typedef-ing an array, and using an unqualified 'char' which has implementation-specific signed-ness. Provide brand new ops, which are capable of expressing variable length strings, and mark the older ops as broken. This fixes all issues around XENVER_extraversion being longer than 15 chars. More work is required to remove other assumptions about XENVER_commandline being 1023 chars long. Signed-off-by: Andrew Cooper --- CC: George Dunlap CC: Jan Beulich CC: Stefano Stabellini CC: Wei Liu CC: Julien Grall Tested by forcing XENVER_extraversion to be 20 chars long, and confirming that an untruncated version can be obtained. API/ABI wise, XENVER_build_id could be merged into xenver_varstring_op(), but the internal infrastructure is awkward. --- xen/common/kernel.c | 69 ++++++++++++++++++++++++++++++++++++++++++++ xen/include/public/version.h | 56 +++++++++++++++++++++++++++++++++-- xen/include/xlat.lst | 1 + xen/xsm/flask/hooks.c | 4 +++ 4 files changed, 128 insertions(+), 2 deletions(-) diff --git a/xen/common/kernel.c b/xen/common/kernel.c index 70e7dff87488..56bd6c6f5d9c 100644 --- a/xen/common/kernel.c +++ b/xen/common/kernel.c @@ -24,6 +24,7 @@ CHECK_compile_info; CHECK_feature_info; CHECK_build_id; +CHECK_var_string; #endif enum system_state system_state = SYS_STATE_early_boot; @@ -469,6 +470,66 @@ static int __init cf_check param_init(void) __initcall(param_init); #endif +static long xenver_varstring_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg) +{ + const char *str = NULL; + size_t sz = 0; + union { + xen_capabilities_info_t info; + } u; + struct xen_var_string user_str; + + switch ( cmd ) + { + case XENVER_extraversion2: + str = xen_extra_version(); + break; + + case XENVER_changeset2: + str = xen_changeset(); + break; + + case XENVER_commandline2: + str = saved_cmdline; + break; + + case XENVER_capabilities2: + memset(u.info, 0, sizeof(u.info)); + arch_get_xen_caps(&u.info); + str = u.info; + break; + + default: + ASSERT_UNREACHABLE(); + break; + } + + if ( !str || + !(sz = strlen(str)) ) + return -ENODATA; /* failsafe */ + + if ( sz > INT32_MAX ) + return -E2BIG; /* Compat guests. 2G ought to be plenty. */ + + if ( guest_handle_is_null(arg) ) /* Length request */ + return sz; + + if ( copy_from_guest(&user_str, arg, 1) ) + return -EFAULT; + + if ( user_str.len == 0 ) + return -EINVAL; + + if ( sz > user_str.len ) + return -ENOBUFS; + + if ( copy_to_guest_offset(arg, offsetof(struct xen_var_string, buf), + str, sz) ) + return -EFAULT; + + return sz; +} + long do_xen_version(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg) { bool_t deny = !!xsm_xen_version(XSM_OTHER, cmd); @@ -670,6 +731,14 @@ long do_xen_version(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg) return sz; } + + case XENVER_extraversion2: + case XENVER_capabilities2: + case XENVER_changeset2: + case XENVER_commandline2: + if ( deny ) + return -EPERM; + return xenver_varstring_op(cmd, arg); } return -ENOSYS; diff --git a/xen/include/public/version.h b/xen/include/public/version.h index c8325219f648..cf2d2ef38b54 100644 --- a/xen/include/public/version.h +++ b/xen/include/public/version.h @@ -19,12 +19,20 @@ /* arg == NULL; returns major:minor (16:16). */ #define XENVER_version 0 -/* arg == xen_extraversion_t. */ +/* + * arg == xen_extraversion_t. + * + * This API/ABI is broken. Use XENVER_extraversion2 instead. + */ #define XENVER_extraversion 1 typedef char xen_extraversion_t[16]; #define XEN_EXTRAVERSION_LEN (sizeof(xen_extraversion_t)) -/* arg == xen_compile_info_t. */ +/* + * arg == xen_compile_info_t. + * + * This API/ABI is broken and truncates data. + */ #define XENVER_compile_info 2 struct xen_compile_info { char compiler[64]; @@ -34,10 +42,20 @@ struct xen_compile_info { }; typedef struct xen_compile_info xen_compile_info_t; +/* + * arg == xen_capabilities_info_t. + * + * This API/ABI is broken. Use XENVER_capabilities2 instead. + */ #define XENVER_capabilities 3 typedef char xen_capabilities_info_t[1024]; #define XEN_CAPABILITIES_INFO_LEN (sizeof(xen_capabilities_info_t)) +/* + * arg == xen_changeset_info_t. + * + * This API/ABI is broken. Use XENVER_changeset2 instead. + */ #define XENVER_changeset 4 typedef char xen_changeset_info_t[64]; #define XEN_CHANGESET_INFO_LEN (sizeof(xen_changeset_info_t)) @@ -88,6 +106,11 @@ typedef struct xen_feature_info xen_feature_info_t; */ #define XENVER_guest_handle 8 +/* + * arg == xen_commandline_t. + * + * This API/ABI is broken. Use XENVER_commandline2 instead. + */ #define XENVER_commandline 9 typedef char xen_commandline_t[1024]; @@ -103,6 +126,35 @@ struct xen_build_id { }; typedef struct xen_build_id xen_build_id_t; +/* + * Container for an arbitrary variable length string. + */ +struct xen_var_string { + uint32_t len; /* IN: size of buf[] in bytes. */ + unsigned char buf[XEN_FLEX_ARRAY_DIM]; /* OUT: requested data. */ +}; +typedef struct xen_var_string xen_var_string_t; + +/* + * arg == xenver_string_t + * + * Equivalent to the original ops, but with a non-truncating API/ABI. + * + * Passing arg == NULL is a request for size. The returned size does not + * include a NUL terminator, and has a practical upper limit of INT32_MAX for + * 32bit guests. This is expected to be plenty for the purpose. + * + * Otherwise, the input xenver_string_t provides the size of the following + * buffer. Xen will fill the buffer, and return the number of bytes written + * (e.g. if the input buffer was longer than necessary). + * + * These hypercalls can fail, in which case they'll return -XEN_Exx. + */ +#define XENVER_extraversion2 11 +#define XENVER_capabilities2 12 +#define XENVER_changeset2 13 +#define XENVER_commandline2 14 + #endif /* __XEN_PUBLIC_VERSION_H__ */ /* diff --git a/xen/include/xlat.lst b/xen/include/xlat.lst index f2bae220a6df..19cef4424add 100644 --- a/xen/include/xlat.lst +++ b/xen/include/xlat.lst @@ -172,6 +172,7 @@ ? compile_info version.h ? feature_info version.h ? build_id version.h +? var_string version.h ? xenoprof_init xenoprof.h ? xenoprof_passive xenoprof.h ? flask_access xsm/flask_op.h diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c index 78225f68c15c..a671dcd0322e 100644 --- a/xen/xsm/flask/hooks.c +++ b/xen/xsm/flask/hooks.c @@ -1777,15 +1777,18 @@ static int cf_check flask_xen_version(uint32_t op) /* These sub-ops ignore the permission checks and return data. */ return 0; case XENVER_extraversion: + case XENVER_extraversion2: return avc_has_perm(dsid, SECINITSID_XEN, SECCLASS_VERSION, VERSION__XEN_EXTRAVERSION, NULL); case XENVER_compile_info: return avc_has_perm(dsid, SECINITSID_XEN, SECCLASS_VERSION, VERSION__XEN_COMPILE_INFO, NULL); case XENVER_capabilities: + case XENVER_capabilities2: return avc_has_perm(dsid, SECINITSID_XEN, SECCLASS_VERSION, VERSION__XEN_CAPABILITIES, NULL); case XENVER_changeset: + case XENVER_changeset2: return avc_has_perm(dsid, SECINITSID_XEN, SECCLASS_VERSION, VERSION__XEN_CHANGESET, NULL); case XENVER_pagesize: @@ -1795,6 +1798,7 @@ static int cf_check flask_xen_version(uint32_t op) return avc_has_perm(dsid, SECINITSID_XEN, SECCLASS_VERSION, VERSION__XEN_GUEST_HANDLE, NULL); case XENVER_commandline: + case XENVER_commandline2: return avc_has_perm(dsid, SECINITSID_XEN, SECCLASS_VERSION, VERSION__XEN_COMMANDLINE, NULL); case XENVER_build_id: -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Tue Jan 03 20:10:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 Jan 2023 20:10:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470705.730318 (Exim 4.92) (envelope-from ) id 1pCnc1-00067p-Dm; Tue, 03 Jan 2023 20:10:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470705.730318; Tue, 03 Jan 2023 20:10:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCnc1-00067Z-9K; Tue, 03 Jan 2023 20:10:17 +0000 Received: by outflank-mailman (input) for mailman id 470705; Tue, 03 Jan 2023 20:10:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCnbz-0004E1-W5 for xen-devel@lists.xenproject.org; Tue, 03 Jan 2023 20:10:15 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a1e434ae-8ba2-11ed-91b6-6bf2151ebd3b; Tue, 03 Jan 2023 21:10:15 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a1e434ae-8ba2-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1672776615; h=from:to:cc:subject:date:message-id:mime-version; bh=DE3aCaTT2lSMY1mYXXzNfG1b9Pe72/lY/yfRxG9StRQ=; b=hxfpMNhg8ygN7klPOiR4sivGIBa8mgys/zGE5JI+DKA7rQ6rYV+fPJCB HO4lFi4emAie7Grt1NQoMjB2sr8virlzVakHkOatS0Ne3JyHse12/Z1wi 1PxExUQ2oR41IqlRa6RNZF4xnrDQ+b8NJATSuB6jlgVTs3WdX0Gnktvcb A=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 89980395 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:Sm87RalYXZe1VtTXKmr0tIHo5gxsJkRdPkR7XQ2eYbSJt1+Wr1Gzt xIXDGDUOP7eYmSjLd9zPoy+ph5Xv56AyNVlTws5+CwxEyMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icf3grHmeIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aqaVA8w5ARkPqgS5ASGyxH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 cIocj1XdS++vey3yeiQdNlc3J16Lda+aevzulk4pd3YJfMvQJSFSKTW/95Imjw3g6iiH96HO ZBfM2A2Kk2dPVsfYT/7C7pn9AusrlD5fydVtxS+oq0v7nKI5AdwzKLsIJzefdniqcB9zhfJ9 jqdrjmR7hcyE4GPl3nfzWuXtvLGnTvWZoVKC6+Z+as/6LGU7jNKU0BHPbehmtG7l0q/VtR3O 0ESvC00osAa60iDXtT7GRqirxassgYHXttME8Uz8AyX1rfP+AGdG3QFSThaLtchsaceSTMm2 1CTlvv1FDdvt/uTUnvb+bCKxRupIjQcJ2IGYS4CTCMG7sPlrYV1iQjAJv5zHajwgtDrFDXYx zGRsDN4l7gVldQM1aiw4RbAmT3EjrrjQxMx5w7Xdnm49Q4/b4mgD7FE8nCCs6wGdtzACADc4 j5UwKBy8dziE7mzpHaAGv4yIYun5v/fGwPssQQ2Rpg+omHFF2GYQahc5zR3JUFMO8kCeCP0b EK7hT699KO/L1PxM/YpPtvZ59ACiPG5SI+7Dqy8gs9mOMAZSeORwM15iad8NUjJmVNkr6wwM IzznS2EXSdDUvQPINZbqo4gPV4XKsIWnzi7qXPTlU7PPV+iiJm9F9843KOmNLxR0U99iFy9H yxjH8WL0Q5Dd+b1fzPa94UeRXhTcydhWs+u+5wPL7LTSuaDJI3GI6aIqY7NhqQ/x/gF/gs21 ivVtrBkJKrX2iScdFTihoFLY7LzR5dvxU8G0dgXFQ/wgRALON//hJrzgrNrJdHLAsQ/l68rJ xTEEu3caslypsPvomlENcGk/dEyK3xGR2umZkKYXdT2RLY4LyShxzMuVlGHGPUmZsZvifYDn g== IronPort-HdrOrdr: A9a23:mtaaPqP8jMQ7OcBcTgWjsMiBIKoaSvp037BK7S1MoH1uA6mlfq WV9sjzuiWatN98Yh8dcLO7Scu9qBHnlaKdiLN5VduftWHd01dAR7sSjrcKrQeAJ8X/nNQtr5 uJccJFeaDN5Y4Rt7eH3OG6eexQv+Vu6MqT9IPjJ+8Gd3ATV0lnhT0JbTqzIwlNayRtI4E2L5 aY7tovnUvaRZxGBv7LYEXsRoL41qT2qK4= X-IronPort-AV: E=Sophos;i="5.96,297,1665460800"; d="scan'208";a="89980395" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Julien Grall , Daniel De Graaf , Daniel Smith Subject: [PATCH 0/4] Fix truncation of various XENVER_* subops Date: Tue, 3 Jan 2023 20:09:39 +0000 Message-ID: <20230103200943.5801-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain See patch 4 for details of the problem. Other patches fix other errors found while investigating. This is only the hypervisor side of the change for now, because I want agreement before starting to untangle the mess which is libxc's helpers for this. Also a disaster is Linux's sysfs handling for these. In several places it makes a heap allocation for a pointer (or two) sized object. Andrew Cooper (4): public/version: Change xen_feature_info to have a fixed size xen/version: Drop compat/kernel.c xen/version: Drop bogus return values for XENVER_platform_parameters xen/version: Introduce non-truncating XENVER_* subops xen/common/Makefile | 2 +- xen/common/compat/kernel.c | 53 --------------------- xen/common/kernel.c | 108 ++++++++++++++++++++++++++++++++++++++----- xen/include/hypercall-defs.c | 2 +- xen/include/public/version.h | 78 +++++++++++++++++++++++++++++-- xen/include/xlat.lst | 4 ++ xen/xsm/flask/hooks.c | 4 ++ 7 files changed, 181 insertions(+), 70 deletions(-) delete mode 100644 xen/common/compat/kernel.c -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Tue Jan 03 20:10:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 Jan 2023 20:10:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470708.730322 (Exim 4.92) (envelope-from ) id 1pCnc1-0006B5-Q9; Tue, 03 Jan 2023 20:10:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470708.730322; Tue, 03 Jan 2023 20:10:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCnc1-00069t-Jm; Tue, 03 Jan 2023 20:10:17 +0000 Received: by outflank-mailman (input) for mailman id 470708; Tue, 03 Jan 2023 20:10:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCnc1-0004E1-0Y for xen-devel@lists.xenproject.org; Tue, 03 Jan 2023 20:10:17 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a33a766e-8ba2-11ed-91b6-6bf2151ebd3b; Tue, 03 Jan 2023 21:10:16 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a33a766e-8ba2-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1672776616; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=VaSW3H4jlJ3dv04QHJz+xn4RvXE21Emi7q8vmojUlYQ=; b=K1YvjnCQ8K5mZB3i6BUWM59Lo5NSp758Kd+vknByeD0K4ogC4iuu17bL upcLJJ5vpZkSGWggLMcQqkBF6fFNiV6fWLcqhqoreGYC/MyHlxTUEhgiJ 4g2bsSQgyifm0fmPYe02LPTvlPcElLoA4r/mtLQ4gJJ4A5ifNwlKYRPIP 8=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 89980396 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:zISvBajSqRhsWFeCDFxR0A02X161VhAKZh0ujC45NGQN5FlHY01je htvCmrXPqyPamD1fIokPdy2pB4AscXQmtFmSFE9/iphRXsb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmUpH1QMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWs0N8klgZmP6sT5QeFzyV94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQmGGoANAu8uti4wbvhYddctp56dcj0adZ3VnFIlVk1DN4jSJHHBa7L+cVZzHE7gcUm8fT2P pRDL2A1NVKZPkMJagx/5JEWxY9EglHWdTFCpU3Tjq0w+2XJlyR60aT3McqTcduPLSlQthbJ9 zKepDWnav0cHPPFjhSX0UOMvN3esjP2c6MdOf6etdc/1TV/wURMUUZLBDNXu8KRlUqWS99Zb UsO9UIGr7U29UGtZsnwWVu/unHslgUHR9NaHuk+6QeM4qnZ+QCUAi4DVDEpQMwrsoo6SCIn0 neNnsj1Hnp/vbuNU3Wf+7yI6zSoNkA9D0UPeCsFRgst+MT4rcc4iRenczp4OPfr1JuvQ2i2m m3U6nhl71kOsSIV/5uLp12dmA2RnJbIR1Qe2DXnBDv87xwsMeZJeLeUwVTc6P9BKqOQQV+Ao GUIlqCi0QweMX2evHfTGbtQRdlF897AaWSB2gA3Q/HN4hz3oxaekZZsDCaSzauDGuINYnfXb UDaomu9D7cDbSLxPcebj29cYvnGLJQM9/y/DZg4jfIUOPCdkTNrGwkwDXN8J0i3zCARfVgXY P93i/qEA3cAErhAxzGrXeob2rJD7nlgmjmMGsirn0z+jer2iJuppVAtaQLmUwzExPnc/FW9H yh3baNmNCmzoMWhO3KKoOb/3HgBLGQhBICelvG7gtWre1I8cEl4Uq+5/F/UU9A990ijvruSr y7Vt44x4AaXuEAr3i3TNyk7MOq+AMYgxZ/5VAR1VWuVN7EYSd7HxM8im1EfJNHLKMQLISZIc sQ4 IronPort-HdrOrdr: A9a23:oznK46q+t3YFZKpl/7t2pyQaV5rveYIsimQD101hICG9Evb0qy nOpoV/6faQslwssR4b9uxoVJPvfZq+z+8W3WByB9eftWDd0QPFEGgL1+DfKlbbak7DH4BmtJ uJc8JFeafN5VoRt7eG3OFveexQvOVu88qT9JjjJ28Gd3APV0n5hT0JcjpyFCdNNW57LKt8Lr WwzOxdqQGtfHwGB/7LfUXsD4D41rv2fIuNW29+OyIa X-IronPort-AV: E=Sophos;i="5.96,297,1665460800"; d="scan'208";a="89980396" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , George Dunlap , Jan Beulich , "Stefano Stabellini" , Wei Liu , Julien Grall Subject: [PATCH 1/4] public/version: Change xen_feature_info to have a fixed size Date: Tue, 3 Jan 2023 20:09:40 +0000 Message-ID: <20230103200943.5801-2-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20230103200943.5801-1-andrew.cooper3@citrix.com> References: <20230103200943.5801-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain This is technically an ABI change, but Xen doesn't operate in any environment where "unsigned int" is differnet to uint32_t, so switch to the explicit form. This avoids the need to derive (identical) compat logic for handling the subop. Signed-off-by: Andrew Cooper --- CC: George Dunlap CC: Jan Beulich CC: Stefano Stabellini CC: Wei Liu CC: Julien Grall --- xen/include/public/version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/include/public/version.h b/xen/include/public/version.h index 9c78b4f3b6a4..0ff8bd9077c6 100644 --- a/xen/include/public/version.h +++ b/xen/include/public/version.h @@ -50,7 +50,7 @@ typedef struct xen_platform_parameters xen_platform_parameters_t; #define XENVER_get_features 6 struct xen_feature_info { - unsigned int submap_idx; /* IN: which 32-bit submap to return */ + uint32_t submap_idx; /* IN: which 32-bit submap to return */ uint32_t submap; /* OUT: 32-bit submap */ }; typedef struct xen_feature_info xen_feature_info_t; -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Tue Jan 03 20:41:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 Jan 2023 20:41:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470739.730340 (Exim 4.92) (envelope-from ) id 1pCo6S-0002Po-A3; Tue, 03 Jan 2023 20:41:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470739.730340; Tue, 03 Jan 2023 20:41:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCo6S-0002Ph-7J; Tue, 03 Jan 2023 20:41:44 +0000 Received: by outflank-mailman (input) for mailman id 470739; Tue, 03 Jan 2023 20:41:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCo6R-0002Pb-0a for xen-devel@lists.xenproject.org; Tue, 03 Jan 2023 20:41:43 +0000 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 05ff00ef-8ba7-11ed-91b6-6bf2151ebd3b; Tue, 03 Jan 2023 21:41:40 +0100 (CET) Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 303Jn0ac005591; Tue, 3 Jan 2023 20:41:13 GMT Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3mtbv2w4h7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 03 Jan 2023 20:41:13 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 303KIn43023165; Tue, 3 Jan 2023 20:41:12 GMT Received: from nam04-mw2-obe.outbound.protection.outlook.com (mail-mw2nam04lp2171.outbound.protection.outlook.com [104.47.73.171]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3mvu9s0wnr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 03 Jan 2023 20:41:12 +0000 Received: from BY5PR10MB3793.namprd10.prod.outlook.com (2603:10b6:a03:1f6::14) by BY5PR10MB4146.namprd10.prod.outlook.com (2603:10b6:a03:20d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Tue, 3 Jan 2023 20:36:09 +0000 Received: from BY5PR10MB3793.namprd10.prod.outlook.com ([fe80::e21f:383b:e0bc:afb4]) by BY5PR10MB3793.namprd10.prod.outlook.com ([fe80::e21f:383b:e0bc:afb4%3]) with mapi id 15.20.5944.019; Tue, 3 Jan 2023 20:36:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 05ff00ef-8ba7-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=PMWevr6d4J682B7tfyH8LkkhLNv+gcCfzKsdi7NhCZE=; b=nd2trsc4+12C7q/7zRvaNkXkPnx/0ejO8moafSoxlrAm2JhnHwYKptCG8WZMUlYBMGkJ pxEbyw6vmQnyNCmDT4soxD8NztIwcrjKHGSsxyVqI3M9HsOIvzkbJuvmeGIy/7hRcH/c l2kRPG9GKrKVpkwRBU6tVtrQf+qL1aYw8c9OdwNSvFmm4mhlpQcS3wXD0Dfavr+vRzjh b9byZryfdclBh238baG8UXgH1iIvEEDhDNP3GNbjTzPdSfbxMY51RvyIxZIrHJFF8qJx BIEaS/5BgzGF0B4EtLtm85lEMYq0mcX5Bvdl4hSJEdBFkKcrmGjw30HW59ZgWIj3Mei4 Jg== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DNQUo2+lB00qyENmtMdgCjwesqpzLgdLfIZBiYFqYnjLZOJlndHyNoEoOvYAK7I41OMuToLAXiQVrv/kdanCoV7F0gK6URYIc0lWFTyI2xWLDPY2hjEdkWfG8p7g56/naDnIMz9+vI/YBotIYTrQYhzxMO/84jLQl+QGTMyX8yRrRNZKBbEH5kllUVACWlXoo56DrwGFsWOTlBa+pX1isnUMtXxV4eaeWP2XXdNxDolv8bvdv2WZTgmSa3XaOIyO4wj3RU25NtZATerXUSYdaNX9bdRuYg2OZ6qqn1WkvtKXYjB8qS9yKdBQgNLJ2T5Fd1aq7mq1U0uEfVlsnrzdPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PMWevr6d4J682B7tfyH8LkkhLNv+gcCfzKsdi7NhCZE=; b=Z0Q4gUQQHKtkdngFWn+9/VbJ94XAGpXOrpPhC3H90MIYrDL3jrc6zRlVO2eu30WLk3uvILNU46AgR0YEQ0T7bwoAHnR8ZhJGqnJsXul/zrzfkOMURr2w70LHJ0mc1FPJc37tkW2QGRGEVc4+fBdsSlgHA0U1xqFIUhmeNa3AzRzu7UiTzTPFD73dT/oxUyJSYk+6T6kFHq4312tFa+8X5ScJY3cQ8PMLd9gX7/JXdZh6X/BsPqgXzY7v7eJEFfxYygdDiISnV0qPoZzfxcw/ZAUwYNykTXlMCo9jQ30Sluo3FQOxY8XfGAdFYkN67a/Gnlw65VmE5d/5gIOoWpG+QA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PMWevr6d4J682B7tfyH8LkkhLNv+gcCfzKsdi7NhCZE=; b=MJU5uWrNBr8HQUmh81E3YXppBk7ko0cVsW46s3ESe3SPDj85WGg36WHRJePKk4hTgQWrtKFGFafnhdEi9gzeQrrzkEyUAuIROx3P79vjiRXw6ikSgOc+MzRmpYpsV5NqfUK11DJHsDDJYmrrHtm+CKck1wpfAPjij7Zu8nD1NSg= Message-ID: <6dbb8c10-1c3d-2ad8-0491-049af8ccd89b@oracle.com> Date: Tue, 3 Jan 2023 15:36:03 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v2 0/2] x86: Check return values for early memory/IO remap calls Content-Language: en-US To: linux-kernel@vger.kernel.org, x86@kernel.org, bp@alien8.de Cc: dpsmith@apertussolutions.com, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, luto@amacapital.net, dave.hansen@linux.intel.com, kanth.ghatraju@oracle.com, trenchboot-devel@googlegroups.com, jailhouse-dev@googlegroups.com, jan.kiszka@siemens.com, xen-devel@lists.xenproject.org, jgross@suse.com, boris.ostrovsky@oracle.com, andrew.cooper3@citrix.com References: <20221110154521.613472-1-ross.philipson@oracle.com> From: Ross Philipson In-Reply-To: <20221110154521.613472-1-ross.philipson@oracle.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BN9PR03CA0543.namprd03.prod.outlook.com (2603:10b6:408:138::8) To BY5PR10MB3793.namprd10.prod.outlook.com (2603:10b6:a03:1f6::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY5PR10MB3793:EE_|BY5PR10MB4146:EE_ X-MS-Office365-Filtering-Correlation-Id: ed08d174-8445-49ac-e4cc-08daedca2493 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iHACh/TdwfV/ZHDhxnPq1AawOD0xs1skenzpmGR9AgUL/MnvZq11muFcrPVxs3GWvQYIy4ZIep2knTbkJPsyHBspFey3PboGUxUvrb1BCe4VRuvHFFZ947tEFKKJVtXcX1SB6WAFsVp/4nXhKoJF229iEJk2mlfxprYfONY1EXsrlyzX6HbaddGIG31yxztMXni8J4xaa4XMIPKADcXQt8SuqKxtWJNk34XABnho97OaRrKOpw9wapZDokp/qGkX+Hv/ZHWCoLLKJ0eDxOyjNqXYlUsPB4AE+rcz6WpMnXWQJk/s1P3hxaJ/PdnCcQllwjEEQ64HUCxqWlMhnY/GTqgBdd60X9txKXH8LODKBRSkVKuxV/5duKnC3GZSWtM8PMKbTUruSfAyUXkqyO+/ovimOgiS3E6cDS3hfQNzL5V+H5F6j+ULyrIEJIvj0jG6Bww+4XcOnohpzU94H6/a2sww4FwzJhgACuzwF0Kyv4Vp+nBe1kKEVXRoSUrXF7wXCkjxcseAn4DDTzuwBndEE6ywS7LwDpvtY96Bxz/7+SepYg2M5pR/v9mo4Dz0ZbuRBSWD9ZDA9uYALH9dLJestIZP66GrB46+D7dl8MH/o9eVxkuWJC+7JigIsDe8Pc76rVhIBakOVliYlYjiqKPV5JIlVW9l1CLCdOjb8L5obCjiQgl+rgfxK396TYzXjzashv1IgKRPwQoufuZ8LbJS9YyBPGvOTXj5sB9A3NwUtIraV7wcPp6nbVOsFnV/+Fo64IdRp5a5lTSXX0Y0EQCtnA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR10MB3793.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(376002)(39860400002)(396003)(136003)(346002)(451199015)(7416002)(5660300002)(2906002)(8936002)(44832011)(8676002)(4326008)(41300700001)(66476007)(66946007)(316002)(6486002)(478600001)(31686004)(66556008)(53546011)(6512007)(186003)(6506007)(6666004)(83380400001)(2616005)(38100700002)(31696002)(86362001)(36756003)(22166006)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L084TUFxSkJFa0xXcUJ3dEZVcnh0S1lKUkh1SnZZUXMxTzlhYVV3b1FQQUtl?= =?utf-8?B?em1nSG84N0dHcWFuSHkxVGhieHpCdlZFSjRNKzNIZS9Jc1lyNHVhRnVuV3hP?= =?utf-8?B?QkZUWUc4dmJVN3ZYQU13Smg5bWtBNWNRbEdSR1lSMU9qQ1QwSEVXbDFUaHJt?= =?utf-8?B?cXNDTG51dXN0ZWlLbTFJY2FjcWFjZTdGRkx1Wk14ZWlPbUN6ZVByQ2ROTUNy?= =?utf-8?B?VUdwVjdVK2ZxWjhIMVR2alNkNm9yQVRENVdOWER0OEszMlRTYk0wOE8xMzFC?= =?utf-8?B?dmREUjlIUkZzYzRIWGJ0Nm52Y3pCVkFqbVQwNUUvUUVQRFh3d3poc01JbFh5?= =?utf-8?B?ODQrYlpKZEFyWGU3dVNOSjFvemlxMlV1VVJPc3lmVXQ4SDF1MVNwSk9EV3ZL?= =?utf-8?B?Z2NVZ1hYZXpJM0VyVytscUdNeVZqQm50em1MSEdkRE5objBKOFAwNkNVNTI3?= =?utf-8?B?QkMxRVBVY3FXN3J6MHdRd2o3aFprcWFkWXlHcW9RYlNJY1pTb0o3SE96VGJR?= =?utf-8?B?V3ZJQjVHV2I5UVllcnlUNi9IK3BNUlJnR0ZvSk5QbWdXSkxYdW5DYVlWOHUz?= =?utf-8?B?L2NXVlBVU1I5ZHcvbHMvM3V6S0tWelkzOXVxUUxxekVIUUkxWmIzOE9YdmZH?= =?utf-8?B?M2lIdE9XbTY1RHd5ZDFhWGF0dHhUb2h4V2hoNS9WUkRmSUlSUnZvU0hZeGhi?= =?utf-8?B?L0hDR0tlK3JFQzljZXkwZmFRRGxucXlWM0wycGVBWDQ4WkYxTHR2Q0c3QUVy?= =?utf-8?B?TXlJdDlEWXM5d1RKM2wvUkVNdjNZSkxTeWlENHdZQjdZemN1NVQ2bVZzbVBr?= =?utf-8?B?NEw5bUdRZENwdGoyMUI2WG84N1FWRDZYSmora0lvaXNzOFgxSFhLamd0d2p1?= =?utf-8?B?RlQrKzR0SlZCRWdTVWpSV0MzdXc2N3pwTGVTUmlVT3RqNFR2ZkFuSnZUUjRo?= =?utf-8?B?MXh0eVpXMjZ3a0tuQ3l1c1BVa1RzQ1Y4cFB0SytYRWZEdzduNWkvNHhaT1pV?= =?utf-8?B?QzdmUXpwd0xpdTM4NkwyeCtSdTgvYlFRQ1EyVUVrWnQ5ZWNqY0x2bEtFNlUv?= =?utf-8?B?d0s3YW9zTWZ2VG5sNEd1d1hid1AxazQ4N3MyNXpGR1d4cGdUMkkvaTBPWEZh?= =?utf-8?B?Z1NNcW5KaEZMOFlXNEl5bVRLQ0tqZWpVdkF1OVY0blVSb2ZhTVVVUUcxenlR?= =?utf-8?B?NFZqblAxMGRrQ3cxU1lzUDYwMHA5bVlRU1czYWhCU3UwanVwTnlMdFFsL0RX?= =?utf-8?B?NDNJQldLY1NGcVQ0UTVKR2tEWnVSeWlETHFYMzBVMEg0c0JMNEJQY2p5SUdF?= =?utf-8?B?d3dWWFFyTXFNN1kvakR1SW9CaTBpVzQ0MUd1UEgza1ZmblA2anJONG14N1Bt?= =?utf-8?B?R2J3NUtGdG1VRldteitGb3FJS01NaGxxbm1uYTc5S0NaVW14SUZGVmhtUlFD?= =?utf-8?B?TzJKSzh1aWUydVVkZ2d3a0kxOU81Vi92ek9WbXV4bmduQTUyem5YNnd5Z1ZP?= =?utf-8?B?SE5KdVJrL0FrNlIxa1pjMXVBak1kVFJidlJoQ2M4V1ZZaDhpWUE0b0ErMXNL?= =?utf-8?B?SzZFRGFaaW5LckNlWlpyVGdSNVZnSHo2UmE0UkdNOUMrVEFlU1lCRnJLM0pq?= =?utf-8?B?L3pPdGxuLzlsV05maGVPMkRZR0tmcjBjcWllNnpDNDk1MFpzTWJYbG5yWUlP?= =?utf-8?B?akZXemFkYS9tQzJmZjFuOWQzR0kzQWlCM0N2WE1qaElPWHI1OWdramw0RDln?= =?utf-8?B?blJUUEE1MXdpZWNpSVVmR1QyU0hZUFVPZlJLYWZrd1FvTys3dXZSQU5aWVJ0?= =?utf-8?B?dXBQRDAwTU9zOURQcjFWK2s1Y2R1aUhmQ3MwNXJlbW93am9zcnM3TDJOU2VM?= =?utf-8?B?L1FLQ3NwUitoQzBuTWIwMExuL0pYY3BTdlZDcHpET1pldWRGU1hyY0I5dGlJ?= =?utf-8?B?bjNYMGhEeE9FRmpSYzNCNTgzbldOUytHMVdyYTlqREtOMitiSDQ1eXEyNWRi?= =?utf-8?B?MEFyNzI5UVNFMkc0cHVIaWxaRzMyVzlFUFpzcnZCa3I2UDRxNU15VGxHSHFW?= =?utf-8?B?cDBmM3hxWjc1L2dOVkRQRjBVNDVZb3ppTFVOQVAzMm44VzFIMFZReE55UlpC?= =?utf-8?B?UlFBU1RaM1J0UmRaTmpFbEJOQVFqazBPYWtYbUlvd3F6bmprZjRTR3JOeHhl?= =?utf-8?Q?KLBqw4sBE+nwAH+DLZsPZ70=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?U1dYc2FFRVZNbTBUbm9BUkV3M2tDOTJMbmJ3Nll5aEk3bVo3ZGRSM0l2VTll?= =?utf-8?B?eG9JNTErY0UzOS92bHpzdjRCM0JjeFI4WWxxaHZBZHVtUkpIbElJdFNpMVhI?= =?utf-8?B?VTAxRTNkWm1nZTFmMHFyVjBNN1dQVkVSY3dpU25oZHF6TUl6MkJYM3cycDZP?= =?utf-8?B?UU1rWlB4UjFlQ2liVFJSSVJPM201MjdPdmJ0USt2Z21sYk01L3M0eWJERXFq?= =?utf-8?B?dXpKaDJ2YXpiVE5CZUZJR2w4WUJNb0F5aEV1WTJRcTRhUjY3anpaeXVucnhZ?= =?utf-8?B?SlRUc3BqcHUwWHE5RFhrTnFzTjZZL0FlalNOczNmSFRSck8vNC92SkIrK2xM?= =?utf-8?B?Z3BPRTlGQkkvdFVGQXI5T2Q1RUQ2TWpvTnFZK1Bpd01SckxycGxjb2M4UDRJ?= =?utf-8?B?Q2ZXL0J6WTVRM2h5ZHczSGxocjVpYXZVSlQrNWR5eS9rYThJQUwrVGt5UnRR?= =?utf-8?B?K0xSMWwvc0JQcm5WZThlTU9TcEsrdW1UNHFBQWZzd21YTXdqVThXWXpyQkxH?= =?utf-8?B?YlZPdURQUkZUZTVXTVJ6ZmVvZlJFRmZ2ZG5mdlpaemtPZ0pGS0tSY2JkSnhL?= =?utf-8?B?SFVRV0pOMW82NTQvd3NFYTQ0YVpYRThLRTJCTjlsQlZqSnIvWTFHZVgxck9E?= =?utf-8?B?VjRKWitKK2Z2UGlVOUhidlQxbnVZNHN1R3JFUjE2NlN0aTk3MGVKK0lrK3hq?= =?utf-8?B?YWM3Nm9vcDR6Y3NjeE93L2NHdTlxNHp2VWl4VW5hRXo2RTVYNHIvVCtna1Rl?= =?utf-8?B?NFErRkNBMytIZW1yV1gxZUVLakpUTjAyMm5JQ2pVRDR4QmlTY1N5UlJHWTRy?= =?utf-8?B?NUNsZWlrcjZDaWR0SFE4R3hOakpqSk9XU1kzZU5xaE96SFZLa2sraEhzZGEr?= =?utf-8?B?blpIRkRXc3c1d0owL0M2U3JoRzBGWlVIMkJUTWV1YXVKSjgwVG1tK2VwUURs?= =?utf-8?B?R01uajIyR2Q2SW5TOTA3ZXZmSDhFc3VucU1Wd0VPVFZxQmFhd1dOMjlqVjQx?= =?utf-8?B?cjdjc3lRMjFvcnlzQXRkTWkzaFlTbk0ycjVEN3J4d1lMZVY1L3hZZmRxM3BM?= =?utf-8?B?dGFpSStTOFNTeWgvV1paS3lvSGhGc200TXRnWHd3RVN5VnBwSWUvdnk2YWlZ?= =?utf-8?B?L2tiTmU3R1dMaE11RFpiVFpkZDE0alhyb2x6SFhEQWI4M21pRVppQVNSb0Mx?= =?utf-8?B?SXNEQWFiMTlRQmNtbXNGSElxbHBmNGpKZnRKOXRYNC9jYlRqZGpxK0p2T3cy?= =?utf-8?B?RmxvM1Z1WDM2K0l6ejZ2OU8rRVVId2M4YjZCUWZCMXhzWHhjZzRTRzJCamFN?= =?utf-8?B?TU1QSjFwa082aEFYd2ZQVTczZGgxWWpNd0xqYkVpT1FKMUNKMDIyMXVrZUNG?= =?utf-8?B?aVpwazRQdmZjbnlkL3hwbVF1R1RROWZ4djZ0aDhxVzNwSHk1YzdSeVZ4UzdX?= =?utf-8?B?NXRJMmVIVjBUVlc3Z0pSZVhkWi96TmtkSXRmcXhkeDg2bS9WUjVWYWMyNnBh?= =?utf-8?B?MWErRGxHV3ZCbjI0V0oxaEFnKzc2UXdWamlwSG12U1BqTDJhRldqOFFJclY0?= =?utf-8?B?VS9tQWRFeVNPeUwzeUJSVi9Ec3cwNC9MMW5KY01FaXd3TUc0TkxGL284a3R4?= =?utf-8?B?Ry90amVmRmFFT2hHa3Bqd2Z0UEs3dFErODZGU1MvSGVSWHVUTkNFMlFIaEQ5?= =?utf-8?B?c3lyVUhvUmtFMjMrVlpzeXpqdFlDbXdsaUYrTUJYNlVzZHdCT0w4amVRPT0=?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: ed08d174-8445-49ac-e4cc-08daedca2493 X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB3793.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2023 20:36:08.2007 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3wUYta/Sway5MJS5K1zPkGzSmHXn3y6PYL0T0pQkqNW5bBxQLCpYXQ6IKvf8+W2zrD7YJlBfI+yW6bHuNDSj8IEovoM5nmcxhKZuLKPQ9AA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4146 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2023-01-03_07,2023-01-03_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 suspectscore=0 mlxlogscore=999 adultscore=0 malwarescore=0 bulkscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301030175 X-Proofpoint-GUID: OcoREfwsY4SJgwNelb5L45jMWqgk5Nsj X-Proofpoint-ORIG-GUID: OcoREfwsY4SJgwNelb5L45jMWqgk5Nsj On 11/10/22 10:45, Ross Philipson wrote: > While sending an earlier patch set it was discovered that there are a > number of places in early x86 code were the functions early_memremap() > and early_ioremap() are called but the returned pointer is not checked > for NULL. Since NULL can be returned for a couple of reasons, the return > value should be checked for NULL. > > This set fixes the places where the checks were missing. It was not always > clear what the best failure mode should be when NULL is detected. In modules > where other places tended to pr_warn or panic e.g., the same was done for > the checks. In other places it was based on how significantly fatal the > failure would end up being. The review process may point out places where > this should be changed. Borislav, I just wanted to get your thoughts here since it was by your prompting that I sent this second patch set to make checking of return values from early_memremap() and early_ioremap() consistent. I have gotten Reviewed-by's from some of the maintainers in specific areas that they approve of the return handling. I also got two replies basically questioning the underlying approach. I replied that I basically did what you asked me to do. I have not heard back. How would you like me to proceed? Thanks, Ross Philipson > > Changes in v2: > - Added notes in comments about why panic() was used in some cases and > the fact that maintainers approved the usage. > - Added pr_fmt macros in changed files to allow proper usage of pr_* > printing macros. > > Ross Philipson (2): > x86: Check return values from early_memremap calls > x86: Check return values from early_ioremap calls > > arch/x86/kernel/apic/x2apic_uv_x.c | 2 ++ > arch/x86/kernel/devicetree.c | 13 ++++++++++ > arch/x86/kernel/e820.c | 12 +++++++-- > arch/x86/kernel/early_printk.c | 2 ++ > arch/x86/kernel/jailhouse.c | 6 +++++ > arch/x86/kernel/mpparse.c | 51 ++++++++++++++++++++++++++++---------- > arch/x86/kernel/setup.c | 19 +++++++++++--- > arch/x86/kernel/vsmp_64.c | 3 +++ > arch/x86/xen/enlighten_hvm.c | 2 ++ > arch/x86/xen/mmu_pv.c | 8 ++++++ > arch/x86/xen/setup.c | 2 ++ > 11 files changed, 102 insertions(+), 18 deletions(-) > From xen-devel-bounces@lists.xenproject.org Tue Jan 03 20:47:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 Jan 2023 20:47:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470747.730351 (Exim 4.92) (envelope-from ) id 1pCoCL-0003An-2P; Tue, 03 Jan 2023 20:47:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470747.730351; Tue, 03 Jan 2023 20:47:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCoCK-0003Ag-V2; Tue, 03 Jan 2023 20:47:48 +0000 Received: by outflank-mailman (input) for mailman id 470747; Tue, 03 Jan 2023 20:47:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCoCJ-0003Aa-5R for xen-devel@lists.xenproject.org; Tue, 03 Jan 2023 20:47:47 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCoCI-0004pF-BW; Tue, 03 Jan 2023 20:47:46 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=[192.168.2.2]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pCoCI-0000Ww-5T; Tue, 03 Jan 2023 20:47:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=VsuQH8n3GuXWuA+VQJgibmsw0UwoS3Jh87+EAp1bEec=; b=Pp7lzDQvvlB4HdI9AWWQk0Q83z Y374uwIdkfvwX2CBHBJ0SjddoHdJ77RdnlFJ+zXIlRz20PYoDoyPaC6ie1XhsdkF8/mhl59C/Oeab H/zGT8IbuAkvYytW0l2jbui5LMTD5SHz/rlLISiDdBdnN3/p8AELBJUi5AxL/0XjVOuo=; Message-ID: Date: Tue, 3 Jan 2023 20:47:43 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 4/4] xen/version: Introduce non-truncating XENVER_* subops Content-Language: en-US To: Andrew Cooper , Xen-devel Cc: George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu References: <20230103200943.5801-1-andrew.cooper3@citrix.com> <20230103200943.5801-5-andrew.cooper3@citrix.com> From: Julien Grall In-Reply-To: <20230103200943.5801-5-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Andrew, On 03/01/2023 20:09, Andrew Cooper wrote: > diff --git a/xen/include/public/version.h b/xen/include/public/version.h > index c8325219f648..cf2d2ef38b54 100644 > --- a/xen/include/public/version.h > +++ b/xen/include/public/version.h > @@ -19,12 +19,20 @@ > /* arg == NULL; returns major:minor (16:16). */ > #define XENVER_version 0 > > -/* arg == xen_extraversion_t. */ > +/* > + * arg == xen_extraversion_t. > + * > + * This API/ABI is broken. Use XENVER_extraversion2 instead. I read this as newer tools should never try to call XENVER_extraversion. But I don't think this is what you intend to say, correct? If so, I would say that an OS should first try XENVER_extraversion2 and then fallback to XENVER_extraversion if it returns -ENOSYS. Same goes for the new hypercalls. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Jan 03 21:23:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 Jan 2023 21:23:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470755.730361 (Exim 4.92) (envelope-from ) id 1pCokO-0007VZ-Ob; Tue, 03 Jan 2023 21:23:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470755.730361; Tue, 03 Jan 2023 21:23:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCokO-0007VS-Lt; Tue, 03 Jan 2023 21:23:00 +0000 Received: by outflank-mailman (input) for mailman id 470755; Tue, 03 Jan 2023 21:22:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCokN-0007VM-5U for xen-devel@lists.xenproject.org; Tue, 03 Jan 2023 21:22:59 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c9515cb1-8bac-11ed-b8d0-410ff93cb8f0; Tue, 03 Jan 2023 22:22:56 +0100 (CET) Received: from mail-sn1nam02lp2043.outbound.protection.outlook.com (HELO NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.57.43]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 03 Jan 2023 16:22:39 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BLAPR03MB5554.namprd03.prod.outlook.com (2603:10b6:208:290::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Tue, 3 Jan 2023 21:22:34 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5944.019; Tue, 3 Jan 2023 21:22:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c9515cb1-8bac-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1672780976; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=gCKpOgleSfHJ92c+Y9v38Ry7yOOQgS66T1rdtC84y1E=; b=XV+AuZl6u0KAwZchSgrJJ1ou7YJuoso4YULHPSHHpHJ4fafF2vxowT0j yv08cEvkt+mt9RJ21c27LzQmeVz2RrW3N/P+vLx75k7GF2kOJWzE2u6yi Qd7CrBr/aykNqZsdkeaAvE+jA05C5NBtV5KZ4EPwR1phs8EVsGb0N74VM Q=; X-IronPort-RemoteIP: 104.47.57.43 X-IronPort-MID: 90524720 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:gg7TuKodUJq75S7f+drAhPfYJOleBmLSZBIvgKrLsJaIsI4StFCzt garIBnSa/3cYDehe9pxa4Ww9x4BuJOAm9VgSQdt/i1jHi0b85uZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpAFc+E0/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06W1wUmAWP6gR5weHzyJNUfrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXABYicw2KhOnn/ICEWvNrp+kENPjTBpxK7xmMzRmBZRonabbqZv2QoOR+hXI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jeerbIG9lt+iHK25mm6xo G7c8nu/KRYdLNGFkhKO8262h/+JliT+MG4XPOzgq6Q23wfLroAVIB9JSGO4g8SptlGFXtZ9I Fw6wwEQ94FnoSRHSfG4BXVUukWsvAMYWtdWO/037keK0KW8yxaUAC0IQyBMbPQitdQqXno62 1mRhdTrCDdz9rqPRhq11J2ZsDezMig9NnIZaGkPSg5ty8L4vIg5gxbLT9BiOK24lNv4HXf32 T/ihDc6r6Uei4gMzarTwLzcqzelp5yMVQhs4AzSBjih9lkhONXjYJG041/G6/oGNJyeUlSKo HkDnY6Z8fwKCpaO0ieKRY3hAY2U2hpMCxWE6XYHInXr327wk5J/Vei8OA1DGXo= IronPort-HdrOrdr: A9a23:3BDY4qC62fm0N8vlHemT55DYdb4zR+YMi2TDGXoBMCC9E/bo7/ xG+c5w6faaskd1ZJhNo6HjBEDEewK+yXcX2+gs1NWZLW3bUQKTRekI0WKh+V3d8kbFh4lgPM lbAs5D4R7LYWSST/yW3OB1KbkdKRC8npyVuQ== X-IronPort-AV: E=Sophos;i="5.96,297,1665460800"; d="scan'208";a="90524720" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Uu3S+0Pt8nu/TYtlbsPc5gfNPoQnYZJoD5rhtJxZarKOYtwHpNAxLk/KHng00ZwQBDRrBOqdfEP4iiJQEaC5D1dFxSAYHIHHHdvkZIH+bRFFtr+fawAxdKODVG1lFiJ0lmkRwtPhMiXpSZaMEHN75wuQdDWT5BY0MJvR81AQb8q9j8wLwiOFuytpzVJNT4UO+D/B9UjPRSC/69HVTJ/gP66/qc7Q4UYat8oSPnKURr796/lZOs3gptkNl4JGMO5oK9n8dOLmtJ0Y/ssG302wj+HPQXnHtYz8zh4wXH3PAjJiN/pQXt1jmQR/9sMOUZpl486YwHPvZ/lKFkG36qsYPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gCKpOgleSfHJ92c+Y9v38Ry7yOOQgS66T1rdtC84y1E=; b=dqTvYpEya0vaCpfIInDkOKoDSM9nyu70QTe+ZnT2NmqLgZZ7YJJaO8iYu4uXzVqFspduKQ5J8DHdrQu4+dJP8+szf1DW2K0DWxNAZzJU3Z8LWDVQooXK0K87i7TZJDenNHPAb2xiPRf/wRSTmlcWksA5UH8yxOwznSlXHrOWhB9QUsjnemg//LQ41nyxFMREc/egdUivrkcRKDxUEhjauTojbJ4gY4RN6ljxi389AyjpMI5CUOc25MoAiVU82QmEzhRsmFthjNr7EAZsCLHXKyUrtoh1ZAIZDY4vOwUmgG8DkSkZBv6F2wLZAsBlDhWsB+tRhOVBiRIK7eJ6VE+k5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gCKpOgleSfHJ92c+Y9v38Ry7yOOQgS66T1rdtC84y1E=; b=pCVfVTaI20YXPELy/b+hMIYOXSd6aPPwp8BKmlp785tdJdxLxl5T+lagyUi7PSsZA8GJqrU0qlBt2a/LX4j6mQNgGmMgVn7tzRhUTPeiSS+Qhs90xLlOe8Sdc/XRnouneDq+z2eGeJmA8Yooep1OB3pZZORaFfb2MUD8TNLtu0w= From: Andrew Cooper To: Julien Grall , Xen-devel CC: George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu Subject: Re: [PATCH 4/4] xen/version: Introduce non-truncating XENVER_* subops Thread-Topic: [PATCH 4/4] xen/version: Introduce non-truncating XENVER_* subops Thread-Index: AQHZH69eYU4qCMuPJUaHOPPUV+yM+a6NKeKAgAAJu4A= Date: Tue, 3 Jan 2023 21:22:34 +0000 Message-ID: <88f0365f-2ab7-ed8d-fc99-0b1f2a4837aa@citrix.com> References: <20230103200943.5801-1-andrew.cooper3@citrix.com> <20230103200943.5801-5-andrew.cooper3@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|BLAPR03MB5554:EE_ x-ms-office365-filtering-correlation-id: a167821b-bc1e-4bdf-230f-08daedd0a176 x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DavcmWwVXoelIIHWQEhdbh9DGYJn9QiOOGyUAEmUPPZYRV2quXpygC2vVRTcU1XS+Wf87xA1QhPOC5CsFaFHV6ijVfA2BmkkP40uV0JyCN/zJzLCwxgqZR0pT0qqL4U0zYWDgQSoKII6khy9NdheleaOxPxhdRyQblN+h6DC2lN4JFe02V4CjdRDB1TVG87KWiuOEvPP/rSoMV9gWnmWSzPqay0cwHIpWH2JPjiaGk/+uDOveN69b2oSSgupqAyjkrf25O6b08NEq+Owz3ZZi1EGR6VEYPQMooAB4OmJqkGRTWCy8PbhpwErBefiFp/YDHPVNaaJFByOl3W/VfjsNic4TfmrVA/0aRUgOGCNpgQ4HEc4CT3gke4WVZNe+rnRFxw7VlGSKv6OzKf5TCUbF+my+egeod78R/rMi4w0YQenKstucma2vF0xrsT/Fl22/g9JW1Oc44/hA7/1bTZ/MqW4ldvoShlCh1t470SNo6xse1Jy4hLdkHfZ+NX+rYAASgCVkdCXk81/E9DXLF3kLw02rijXzipwRrjg9EWTchrxIDO4+WaL8adbz0YJcdxSHpkzupsAkYTM2YVl48bhSWTjKgidqPANCBWV6+gzUadyyBxsMuZQTSfyQHO8P/CMzHvd9atvdXZAV1dtkEHNCUDFdDZqdBCK6KWlSvww1USF+N7Dht4knuYKoACIYAS+RZRtO2Wm88ozMo9xZ3S1lEQbSz67xzmaUqIBzpVwCklHid6j9+XdBtBsv8tOt4TO0CCM0ryFg7V1kZqycib7yj/iKBzd0eHJUxDrWYkI/gk= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(366004)(396003)(136003)(346002)(39860400002)(451199015)(4744005)(2906002)(5660300002)(8936002)(8676002)(4326008)(41300700001)(66476007)(54906003)(66946007)(110136005)(64756008)(66446008)(91956017)(76116006)(71200400001)(316002)(6486002)(478600001)(31686004)(66556008)(53546011)(6512007)(186003)(26005)(6506007)(2616005)(122000001)(38100700002)(82960400001)(31696002)(38070700005)(86362001)(36756003)(22166008)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?eHBEeTJiMTlYNlo4emZWQTBrbk0zeDI5d2lkQnJ2RkFMOXhMZ2N5cHp1c0dw?= =?utf-8?B?N3RlT1BNOEh1SFdsQ1hpRVpTczVranhCWFQyYklVUm5oV3VCVzFTaHg0Mk5n?= =?utf-8?B?SGlqajBhQktBbEV3bjc4SUhqUDhCVWJGZDJSREZLeXVsSWtqMVRFblZSRk5h?= =?utf-8?B?dkc5Vk10RndNcTd5TEpjUWxKdUlTQ1FMWW8xR21jMktwUEpVcHZqWHNtSE5P?= =?utf-8?B?RGw1bkZIMncrOWlCdFpud2dYTnlzM2s0aFBaNVJNR01WdHBlOEtKbjEwVlN2?= =?utf-8?B?eVpkeUh1Mi9XNFkxZ0FaSW9kRzVlSWR3MzVFdVRNckRDSTF6NUFsS0FqeWZk?= =?utf-8?B?NkxmQ3RaNG5LVFdGeHplRjhXeXBsS0tJMkZoL0NQTlZsRE9kUWdjSUtVMWJz?= =?utf-8?B?eEJOUXczbncxejFlUW9tUWsxYjc5U2QvcWN3cEFEeW5pRHUwRW10Tmx5WUla?= =?utf-8?B?UGR4dE5CN3ZLbDg2V05OeENGeUE1b2JqN1I5ckRmVExnMEQvSnpnZ0FGbjVn?= =?utf-8?B?dk8wU28zQjZsUE13ODVyOEFWZENIMkNxWWVQOFNWU3Mzb2pzWTU1Vk0wV0Fw?= =?utf-8?B?SEYrd1E5NFhVdURBVjZVbjduazBKNzdtT2tpdjZldGdZMTVQUmVhUzhUNERL?= =?utf-8?B?SFF5bWhmdU9vV2VSUjhzZXJmL3JCTStOR0RjLzRRYlUvVlBWWnFWcThMS2JZ?= =?utf-8?B?V2dnWDhwVy9UaG1xem1ERG4velRHYnNJd1pSQWRubG1XMG8rUWx1a1FiRVF3?= =?utf-8?B?aGJDbVl0ZEVVcEpmOUoreEkxMThsUHhXL3dtdmd1QzZVajd4M080VkZ5RDF3?= =?utf-8?B?U0FpWnNrQnpHOXpGT3dJZUZ1YWplakhpWHhDZ3VCanFra0dGVXlreVRJcGxW?= =?utf-8?B?WWJwdkJZK0xwQzBRL0xWVTFUc1dzWndIeEFCVjdMNGxKa0hpbzFRNy8zbi9N?= =?utf-8?B?WUJBN240QVBXSnRKc2duV1FFMlgzNWdmSVpSeXJnVndyZFlEcWlCZ1BhNWVy?= =?utf-8?B?YWJYNGlJMkxpUFJxQ012ZjZXQk5KL3dBeTBhSUtFcHRHM0kxOW83VzJvaVFN?= =?utf-8?B?Y1lWYjJaKzl0SXMzaUdic1JEM24yWnllbTJvTEpLV0hBT3BIRENkcUxaeXdE?= =?utf-8?B?TU16aGNhbGIxTGp4VjhYeHBQVGN2eU1NaEQ0VHkreS8xd3ZJOEszNitIbkVz?= =?utf-8?B?ZG96SkRiWHVXKzc3TFBVc3YvL0gvakdoVVpiV3RSbWkzOCs3eXhsbW9JZUpI?= =?utf-8?B?VGtJZFIzSDhJZ3JXUS9OSkhxdFo5Z3R4T29sczdOU3dWUUVGVjF2UVh2dkJa?= =?utf-8?B?bW4zN2t6alBxVFZiUEg2U0dpTGlDSWNNTTRLNXl2cDFCWitTYzh1QjA0STJY?= =?utf-8?B?Rzhqam9DSkFYUm9WZUU2NnRlL2d3RWdLQjk5SGhKandkRTZVR3QzdXJEQ0E0?= =?utf-8?B?clJaOUdmQ1RKNnVaZmY5RHYzRFh5NFU1dU83bTV6UGVGcFREN2MzUzBiU1Fi?= =?utf-8?B?emxhVU93YVl4MzJOZndxV2pocDJyV0VZTjl1WXJ3ZGExOXgrMnJZRmZmSFV1?= =?utf-8?B?WTdodzlleFFQMU1HZTlRcFdwSWkrZHBoQXBTMktSZVc5Q0RBSUxKeURFUnU3?= =?utf-8?B?MWZ0Z1JDem0vTlVrUEZicEJsZ0EvYW9PeEN0Q3lzSVlCVGdHelVnTzJ5Z250?= =?utf-8?B?czNNd1gzU2d0c253MEZ5L3lTRFRyTVoyUkZ3cno4L0tzUHdOWElyZTRCRWxa?= =?utf-8?B?ck5oNk0yMThOR1k0Y0NrV09BTmRjL3JYa0FXZG8wZHdlQjdybXBXUnVweEdu?= =?utf-8?B?Y3EvWlI2aGZLWWtRNGxEOWtsZEN2ZDM4NEtJUVYwNHNzNEhyL1FUR2pJWnBR?= =?utf-8?B?QzAzTXNqeEhKbjNjQjlhZHJHcThBbGxyRTZnZTJKdmFza01Qb1BwSWhyczd4?= =?utf-8?B?Q3NqUCtlM3hiTWlqQ0JGUi95YnpmU1FTdEV4clZiN0Ftb2I2cDlIRUh6UUpJ?= =?utf-8?B?UzRFMlF0R2QwaEJHRnMrdElnVWpodUs3UnpPVUUrQWNJZnVWU0QrcnBvSko3?= =?utf-8?B?dHpVdUZLNDVvSWdmeGZ5Qnh1WFJzdVJUeVN2M1RLVHgzZnFxQVNFUkpLV0FF?= =?utf-8?Q?vPYNa48CkpGahZPybKWBaTtZX?= Content-Type: text/plain; charset="utf-8" Content-ID: <29864C5C5355714C9F9A915CB1444921@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 87lgWfx8BNUBFqWfupj5fg38AOZ/IlRXxDWfKyffbGyDwOzNAwasQFxGT1Zc3Exy4NLJkX9GkXfN0YZkfs5d/CSAOhk6Fp5NaYOsycW0IN04GWuYHCNvpwtgxRTl1EwotlZy/8TDAyx3PWAgdbJHWOUqvtOjQb2bIXUxBZFV4RSJJ4TOMJfJoqQORCBHHQ04jjDNeP4bzXVxnN+EZXzUGDMmz+krPvE0xDRr6YbakOsG8D1e2CRRMGB+Bqu+HzSpPoHNixu0D7lsYm6YFYMqbqW2mpQGocvvMK4+4KgRictXamE8/4M91nzhsmBp6ysR4/55mTtxM4sR1kvbuyBoVgAQE51/SYplkY/9rNgkgrN8ZaijZvf0xcavhSIqMGuxMU5qL83MoSaLF2jemBIoghwcCbvxwyV3VCR4HdESv4Cj6aZkttCoWpc8ca1IDFGHkFpdxKvp3vJNDyCrz2e6f31igk1/QpFSFH6Zx9FEd5ih06udhIe8dbZXb2MFglXUTdDsb2jWGilRYZj5nbkmz/sS5ekqTTKjlNQXA+uVqHj6w5t9mFl59T8mGN6NtTao5V7FXanJcb0h80sbAia1pqYpIqRuG8BrCd6XHSXfsgm/I+YRhF77wIwTgdzkUBD0twPTH7t6hhO4aG7ShZ2tzvmdYoqPh4Bo23C44bMzfakJyoYNcLM2gBM3+bzFWcrgDw3ahG6JVPs3fzWa9LAMb13i0SAcMZZn9hSiQ0y9wM+QxWXizbbaD+PAcoCbQUSF/9E6juYNCuCVJMPQ4Vxy0de+Qyu91mfv9887wV/encUe1xO/j1VNfTED8zh2k2+MayLEOI8Xs/uye/r2jc4vj9DP/8WTVTeLXZa3LapuN57K1+ljg89IP05PkUAU1FCK X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a167821b-bc1e-4bdf-230f-08daedd0a176 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jan 2023 21:22:34.3888 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 42yc3fjxyxDVO6uAxX4zDv0y9Vh+mIlghFAJ03MLw/RVAa/Ca/KvesVSPciC+H8iTcZE7LV5WSW0djWnIZjTnBZD+PXFeN9XgjIZprskuJc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5554 T24gMDMvMDEvMjAyMyA4OjQ3IHBtLCBKdWxpZW4gR3JhbGwgd3JvdGU6DQo+IEhpIEFuZHJldywN Cj4NCj4gT24gMDMvMDEvMjAyMyAyMDowOSwgQW5kcmV3IENvb3BlciB3cm90ZToNCj4+IGRpZmYg LS1naXQgYS94ZW4vaW5jbHVkZS9wdWJsaWMvdmVyc2lvbi5oIGIveGVuL2luY2x1ZGUvcHVibGlj L3ZlcnNpb24uaA0KPj4gaW5kZXggYzgzMjUyMTlmNjQ4Li5jZjJkMmVmMzhiNTQgMTAwNjQ0DQo+ PiAtLS0gYS94ZW4vaW5jbHVkZS9wdWJsaWMvdmVyc2lvbi5oDQo+PiArKysgYi94ZW4vaW5jbHVk ZS9wdWJsaWMvdmVyc2lvbi5oDQo+PiBAQCAtMTksMTIgKzE5LDIwIEBADQo+PiDCoCAvKiBhcmcg PT0gTlVMTDsgcmV0dXJucyBtYWpvcjptaW5vciAoMTY6MTYpLiAqLw0KPj4gwqAgI2RlZmluZSBY RU5WRVJfdmVyc2lvbsKgwqDCoMKgwqAgMA0KPj4gwqAgLS8qIGFyZyA9PSB4ZW5fZXh0cmF2ZXJz aW9uX3QuICovDQo+PiArLyoNCj4+ICsgKiBhcmcgPT0geGVuX2V4dHJhdmVyc2lvbl90Lg0KPj4g KyAqDQo+PiArICogVGhpcyBBUEkvQUJJIGlzIGJyb2tlbi7CoCBVc2UgWEVOVkVSX2V4dHJhdmVy c2lvbjIgaW5zdGVhZC4NCj4NCj4gSSByZWFkIHRoaXMgYXMgbmV3ZXIgdG9vbHMgc2hvdWxkIG5l dmVyIHRyeSB0byBjYWxsDQo+IFhFTlZFUl9leHRyYXZlcnNpb24uIEJ1dCBJIGRvbid0IHRoaW5r IHRoaXMgaXMgd2hhdCB5b3UgaW50ZW5kIHRvIHNheSwNCj4gY29ycmVjdD8gSWYgc28sIEkgd291 bGQgc2F5IHRoYXQgYW4gT1Mgc2hvdWxkIGZpcnN0IHRyeQ0KPiBYRU5WRVJfZXh0cmF2ZXJzaW9u MiBhbmQgdGhlbiBmYWxsYmFjayB0byBYRU5WRVJfZXh0cmF2ZXJzaW9uIGlmIGl0DQo+IHJldHVy bnMgLUVOT1NZUy4NCj4NCj4gU2FtZSBnb2VzIGZvciB0aGUgbmV3IGh5cGVyY2FsbHMuDQoNClJp Z2h0LCBidXQgdGhhdCdzIHN1ZmZpY2llbnRseSBiYXNpYyB0aGF0IGl0IGdvZXMgd2l0aG91dCBz YXlpbmcuDQoNClRoaXMgaXMgbm90IGEgIm15IGZpcnN0IGludHJvZHVjdGlvbiB0byB3cml0aW5n IGNvZGUiIHR1dG9yaWFsLg0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Tue Jan 03 21:40:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 Jan 2023 21:40:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470762.730373 (Exim 4.92) (envelope-from ) id 1pCp1H-0001Vo-5k; Tue, 03 Jan 2023 21:40:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470762.730373; Tue, 03 Jan 2023 21:40:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCp1H-0001Vh-1Q; Tue, 03 Jan 2023 21:40:27 +0000 Received: by outflank-mailman (input) for mailman id 470762; Tue, 03 Jan 2023 21:40:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCp1F-0001Vb-Mu for xen-devel@lists.xenproject.org; Tue, 03 Jan 2023 21:40:25 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCp1F-0005pj-GI; Tue, 03 Jan 2023 21:40:25 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=[192.168.2.2]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pCp1F-0002lG-9N; Tue, 03 Jan 2023 21:40:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=jiiODyd1ijypetGoKyiCA8WgkDKdxvuaiGHcJPoL/ak=; b=uR1nmPRUei0Z+pHk4So1HUih72 s0HF5yaqYWHSslGtSUi/iuXznIZUt74vjBcK0jrpXUTHVgbOwXQJva66L+FGD8MHGSxoB74HggyYS dRfguHVVaUv12XrdPdnEcC44Ih+idTW+mVG1ijKpOByOdzYX2KfUNMK1ZGpAExVOzkL0=; Message-ID: <750237c6-d20f-a66a-45d0-3cefcbe0efed@xen.org> Date: Tue, 3 Jan 2023 21:40:22 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 4/4] xen/version: Introduce non-truncating XENVER_* subops To: Andrew Cooper , Xen-devel Cc: George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu References: <20230103200943.5801-1-andrew.cooper3@citrix.com> <20230103200943.5801-5-andrew.cooper3@citrix.com> <88f0365f-2ab7-ed8d-fc99-0b1f2a4837aa@citrix.com> Content-Language: en-US From: Julien Grall In-Reply-To: <88f0365f-2ab7-ed8d-fc99-0b1f2a4837aa@citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 03/01/2023 21:22, Andrew Cooper wrote: > On 03/01/2023 8:47 pm, Julien Grall wrote: >> On 03/01/2023 20:09, Andrew Cooper wrote: >>> diff --git a/xen/include/public/version.h b/xen/include/public/version.h >>> index c8325219f648..cf2d2ef38b54 100644 >>> --- a/xen/include/public/version.h >>> +++ b/xen/include/public/version.h >>> @@ -19,12 +19,20 @@ >>>   /* arg == NULL; returns major:minor (16:16). */ >>>   #define XENVER_version      0 >>>   -/* arg == xen_extraversion_t. */ >>> +/* >>> + * arg == xen_extraversion_t. >>> + * >>> + * This API/ABI is broken.  Use XENVER_extraversion2 instead. >> >> I read this as newer tools should never try to call >> XENVER_extraversion. But I don't think this is what you intend to say, >> correct? If so, I would say that an OS should first try >> XENVER_extraversion2 and then fallback to XENVER_extraversion if it >> returns -ENOSYS. >> >> Same goes for the new hypercalls. > > Right, but that's sufficiently basic that it goes without saying. It never hurts to be obvious. I couldn't say the same for the other way around. > > This is not a "my first introduction to writing code" tutorial. That's the first introduction to Xen for an OS developer. Adding a few words (maybe with the first version introducing it) would likely be welcomed by any developer. This avoids any misinterpretation and/or losing time playing the git blame game... Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Jan 03 21:50:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 Jan 2023 21:50:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470769.730383 (Exim 4.92) (envelope-from ) id 1pCpAt-00031H-1D; Tue, 03 Jan 2023 21:50:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470769.730383; Tue, 03 Jan 2023 21:50:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCpAs-00031A-Up; Tue, 03 Jan 2023 21:50:22 +0000 Received: by outflank-mailman (input) for mailman id 470769; Tue, 03 Jan 2023 21:50:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCpAr-000314-QI for xen-devel@lists.xenproject.org; Tue, 03 Jan 2023 21:50:22 +0000 Received: from sonic314-20.consmr.mail.gq1.yahoo.com (sonic314-20.consmr.mail.gq1.yahoo.com [98.137.69.83]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9c5d08b8-8bb0-11ed-b8d0-410ff93cb8f0; Tue, 03 Jan 2023 22:50:18 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.gq1.yahoo.com with HTTP; Tue, 3 Jan 2023 21:50:15 +0000 Received: by hermes--production-ne1-7b69748c4d-gv5kc (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 81c81d8f73da6f85953acc29cd3f8c46; Tue, 03 Jan 2023 21:50:11 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9c5d08b8-8bb0-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1672782615; bh=MuT9WQEKaC6d5FTK4Spmmmji5WG4CNUMm8s9sH9M3Ko=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=fZ9+7V+JUVWcviXErNxRBhy7rIrayNLgYtb2o+MyMD2fHbuRDCVfiWvQzSfYWfm41mRh5HU2GZgkYMTar+g3iJUKlGRiJx2mag5njYkyVWAYDeowegtR9gthrV8DbSomjSTQaSg+4vjn2D0ia6+XTUnXlPbxd7pv5zG6EAgT3awW0wAZz/0rzNc2eDDCr5PHxe8pV984CeU9GJEN9X2Y+Vftn/l2AzLWZGY74g2wZchKo2woUpKP+5Shx9leyB5uMI2hK0+GutgSBWWNeWPLzN+P5O9eiI7zK32SHX2ceXrVjiPOMIYgnBRrxiZKoVYd/eCA9zhakpxfE9YQgKKM8A== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1672782615; bh=fsWlUl+B0IEOHQXXH6HoSZbHVIhMRyVbJAlb1IU7XRr=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=YS6wTKRBBk9kNivnCoUIkmrdr8N+uvWDCZ43eCWLk0jpXMjwilt41nZVpGns/GRMnsmP3kRbVoH0u0BLDwL9PWcDOAbHvdBKqVNPwFUfc+rLby38rtEdc/Mi79wEwoRElc3fOxq0A/pXVVPdvBVXh9CwnCp7cOcWlKFArPBaoVV/D2P1oMDG+dk+zjGMORCJKbewxBEpFikkt0ceu0uX6NZAu1gLNVa9lpj6hPDaWOAnKXJOSWMKI5YaaqhXMMD6IZdgtunuTVCmc/nOzLeacEvZ9zBbUDeBk6Sh53H2rm07bivVIFIF+FN37ZOLzyM3Yl5uQXIjvmni+4dlv4QSgg== X-YMail-OSG: p_yAS9UVM1m2RvDl.g5.yw1FtsPTQHp_HScHPKTHjXDGTAUveyFVf5JiUggVOcV 5TZ_yEVYvttCTnxMxCqadl5HOrUs1YQyUF6UUw3Y2AacQMzj5JUURRijKz1aeX99WCFC5JnTT8qL SxGDMGFQz2rfimKdqEp3XD1wJD9OB3JneX.UWFOBr2DdTfERdg6wREgPSbge3GCvrPZcJbEqeyB4 sv_1Kk11J0GiOWEv5n6JC_YFa0Ten1ko_o01uP79FwcbZT5XutDnIFtNw8bW7MLTO3oQDa3zkveD mJagKcsW8B2.D9R_KprjvIyc39EgkcX94rB1HgPcmR5EUCskxY3sni82aew0nzJZs02ZfyEW.P1C 8gYiXwDnJDRgeq64uRNHDR7w5ScI_SKpfmitL9o9_Zfy8g.5CMcMPDtt0O.YJ_o8VBlCdmPOE0Av INdLtOcKw.DrfeudB5zL8sfefuM2PEeYzEa54rqzc_.7eAnX69e9LzCF14hYc7nbxYlSbTwbxhdb EeCtf17WVSDWclH1Cnf2KfptnucTlNhperWrRb0yLBf3rU_RAhrO2pjiE6tuOd9L2gP_LVN3WRNj mRnVZHacflHnjfRuzN5QQvfrjicBr6OYjKVEUIPmK_cb7urm9MYIyHYj55soEVza4eWwMzZFuHWg UintR8uIw74oL.ua29ABtW2B_tOca57qC00p6mcj50JOy7PgkQal12S1x_Hhfxf2gQH8QmT4_dWJ SmYXfqXDVGt02aSLYiygdIM43aWzR0T6gmkqTiCglq8NbBNrOge5MeURR9mQbKF40a51v.K.fdwB Yc.kyC17Gu2Y4mI.l7tjDzFcfW86bGhIq9B3uJkmyM88IJNvjvBKpj9EAaeAZv2nGTz5SWZZuoaX iENfaIZWQXw.VmT4H8BfJytM1gtmWHzY1igSJvOTVlb5mhmVn0vWpU7egiVgIxdgRnJO5_nEVHMV GuNEvd729eVy66lgKhhsQHRfwn1EiOlWUVO4C45AAhGvrHeWwyk2QeEGOYzathi3zimHuVYd9kPS THogexzZiJGD5XXkrEy9ujpud_tlGFcTON1TuZYIM_cdyHExGxZG19_qZT8VhLjkhF6fxAqlJWYx fJffKY44sYLH2PY6GDVI_iIWUD7J8OuwS3hWI.3kIojwK1zW5JfXqj0WPTzkaPbdh1VqN3zwbmXp pm3gcPc1Mlg8kT2vBIZ1V58rNdQ2D_aLrMTkfvbbU6FMtWNP6vi4FknpYpl8J6Uepk6G.Y0urE_7 eFU8KvZTRpfW8TnXOc.Lg5XY85fjduxZfH8reslwY5C9SHYGlji1Rla7JQwtgjqUZaPcJ1sPOfcW Qxd61FD9_3mysXPIsSVia90gCrRoEMfGYJCqaur4ObYdhSwNfxXQzhdl_lum2Fn8hrOqZjrqRruJ K52CWG0mWjaXtpDdvo.9tb..WrpgqnFHu5.bmcpm_ze7Gbejve3m4XYf08CSfLCl75g5Fikfmm_g uvgLQOng0qUvfyZPXv_arPa.GeJNfRqv2_wPjxNNqzDiNUI70ZlI9ENodqz4bTlVBlTyl7SGvPhM lmJQfnnOaZb4dHaOE_LszPdY_OQHC1XPrQEiJ_1l4FfkgsbCt7jXCh0i6m3G9qvkh0gXK0nYV6NQ Rgx3rUrSl5HI3D4JBGBjznbj6qE9WS_UihYta83.eAzwg66q7jovqm6nw7vDLzVHgjFcae6DZGw2 0LHK8Ci3JyfGSkZzXUlfE33iiAUATiF0TJ14ExwIR0iojgaoLi.s00KpkyMq.1cX4no6PQUw7JCb vgjpijzgHx2hrVCl7Hinugio3keN.4kk3t_rVaO49wDNH2G6uNebb8xX7gjgGAo0TvwDS3zTD6o8 ecjgVDTpVhxNCKKpsMZlc.NfLLfHBce3syV3w0D10360EMnaz8kLm_Lj8c7DodkZrQ_6cVDGRQl2 SAhfHS7lZW6iaEbBdni1QRD7TopKEo5P4TLMRD1cZGWAEz1e6E0z6k6p68wCSqPaD1yNM5s34Uw2 erVz4HXwjK84aCpXrqb5envrdJVWxxWRWzAUARXU4gnwyBPLSNftlj2vgzmCVtPLhYo1s.KlbGHl X2EAu_BOdlw.3rE.SdMfRtcTLIiOrk8umNvQhGk2A1xriRpRnMCTsyPPkdcF.P2zQE02LoIU1xOT ozU6p4hmKxHp7ChXY9HXBsP9fH9oFLARfdNVVBizBdg6QHUiNUW2eVq4jKPn99HDu4uR6hCskX0f 0xH_sUVP2JNfUyqEZChU- X-Sonic-MF: Message-ID: Date: Tue, 3 Jan 2023 16:50:09 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v6] xen/pt: reserve PCI slot 2 for Intel igd-passthru Content-Language: en-US To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Stefano Stabellini , Anthony Perard , Paul Durrant , Paolo Bonzini , Richard Henderson , Eduardo Habkost , Marcel Apfelbaum , xen-devel@lists.xenproject.org References: <830263507e8f1a24a94f81909d5102c4b204e938.1672615492.git.brchuckz.ref@aol.com> <830263507e8f1a24a94f81909d5102c4b204e938.1672615492.git.brchuckz@aol.com> <20230102124605-mutt-send-email-mst@kernel.org> <20230103081456.1d676b8e.alex.williamson@redhat.com> From: Chuck Zmudzinski In-Reply-To: <20230103081456.1d676b8e.alex.williamson@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailer: WebService/1.1.20982 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 5329 On 1/3/2023 10:14 AM, Alex Williamson wrote: > On Mon, 2 Jan 2023 18:10:24 -0500 > Chuck Zmudzinski wrote: > > > On 1/2/23 12:46 PM, Michael S. Tsirkin wrote: > > > On Sun, Jan 01, 2023 at 06:52:03PM -0500, Chuck Zmudzinski wrote: > > > > Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, > > > > as noted in docs/igd-assign.txt in the Qemu source code. > > > > ... > > > > Signed-off-by: Chuck Zmudzinski > > > > > > I'm not sure why is the issue xen specific. Can you explain? > > > Doesn't it affect kvm too? > > > > Recall from docs/igd-assign.txt that there are two modes for > > igd passthrough: legacy and upt, and the igd needs to be > > at slot 2 only when using legacy mode which gives one > > single guest exclusive access to the Intel igd. > > > > It's only xen specific insofar as xen does not have support > > for the upt mode so xen must use legacy mode which > > requires the igd to be at slot 2. I am not an expert with > > UPT mode never fully materialized for direct assignment, the folks at > Intel championing this scenario left. Thanks for clarifying that for me. > > > kvm, but if I understand correctly, with kvm one can use > > the upt mode with the Intel i915 kvmgt kernel module > > and in that case the guest will see a virtual Intel gpu > > that can be at any arbitrary slot when using kvmgt, and > > also, in that case, more than one guest can access the > > igd through the kvmgt kernel module. > > This is true, IIRC an Intel vGPU does not need to be in slot 2. > > > Again, I am not an expert and do not have as much > > experience with kvm, but if I understand correctly it is > > possible to use the legacy mode with kvm and I think you > > are correct that if one uses kvm in legacy mode and without > > using the Intel i915 kvmgt kernel module, then it would be > > necessary to reserve slot 2 for the igd on kvm. > > It's necessary to configure the assigned IGD at slot 2 to make it > functional, yes, but I don't really understand this notion of > "reserving" slot 2. If something occupies address 00:02.0 in the > config, it's the user's or management tool's responsibility to move it > to make this configuration functional. Why does QEMU need to play a > part in reserving this bus address. IGD devices are not generally > hot-pluggable either, so it doesn't seem we need to reserve an address > in case an IGD device is added dynamically later. As I said in earlier message in this thread, the xenlight toolstack (libxl) that is provided as the default toolstack for building xen guests with pci passthrough is not the most flexible management tool, and that is why, in the case of xen, it is simpler to reserve slot 2 while qemu assigns the slot addresses of the qemu emulated pci devices so that the igd can use slot 2. IIRC, In hw/pci/pci.c, once the slot value is assigned, it is constant and cannot be changed later on by a management tool. > > > Your question makes me curious, and I have not been able > > to determine if anyone has tried igd passthrough using > > legacy mode on kvm with recent versions of linux and qemu. > > Yes, it works. > > > I will try reproducing the problem on kvm in legacy mode with > > current versions of linux and qemu and report my findings. > > With kvm, there might be enough flexibility to specify the > > slot number for every pci device in the guest. Such a > > I think this is always the recommendation, libvirt will do this by > default in order to make sure the configuration is reproducible. This > is what we generally rely on for kvm/vfio IGD assignment to place the > GPU at the correct address. > > > capability is not available using the xenlight toolstack > > for managing xen guests, so I have been using this patch > > to ensure that the Intel igd is at slot 2 with xen guests > > created by the xenlight toolstack. > > Seems like a deficiency in xenlight. I'm not sure why QEMU should take > on this burden to support support tool stacks that lack such basic > features. So you would prefer to patch xenlight (libxl) to make it flexible enough to properly handle this case of legacy igd passthrough. > > > The patch as is will only fix the problem on xen, so if the > > problem exists on kvm also, I agree that the patch should > > be modified to also fix it on kvm. > > AFAICT, it's not a problem on kvm/vfio because we generally make use of > invocations that specify bus addresses for each device by default, > making this a configuration requirement for the user or management tool > stack. Thanks, Unfortunately, and as I mentioned in an earlier message on this thread, the xenlight management tool stack (libxl) is not so flexible and does not make it so easy for the administrator to specify the bus address of each device, and that is why either this patch is needed for igd legacy passtrhough on xen, or the libxl management tool needs to be patched so it is flexible enough to enable the slot addresses to be assigned correctly using that tool instead of relying on qemu to reserve slot 2 for the igd. If there is a consensus that this should be fixed in libxl instead of in qemu, I will work on a patch to libxl, but I will wait a while for some feedback from the xen people before I do that. Thanks for your feedback, Chuck From xen-devel-bounces@lists.xenproject.org Tue Jan 03 22:58:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 Jan 2023 22:58:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470778.730395 (Exim 4.92) (envelope-from ) id 1pCqEY-00013Z-86; Tue, 03 Jan 2023 22:58:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470778.730395; Tue, 03 Jan 2023 22:58:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCqEY-00013S-5U; Tue, 03 Jan 2023 22:58:14 +0000 Received: by outflank-mailman (input) for mailman id 470778; Tue, 03 Jan 2023 22:58:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCqEW-00013M-0y for xen-devel@lists.xenproject.org; Tue, 03 Jan 2023 22:58:12 +0000 Received: from sonic307-8.consmr.mail.gq1.yahoo.com (sonic307-8.consmr.mail.gq1.yahoo.com [98.137.64.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 15bb7a1e-8bba-11ed-b8d0-410ff93cb8f0; Tue, 03 Jan 2023 23:58:07 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.gq1.yahoo.com with HTTP; Tue, 3 Jan 2023 22:58:05 +0000 Received: by hermes--production-ne1-7b69748c4d-g8q5j (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 0f5dfd348dcdea8c73c8659aacf64335; Tue, 03 Jan 2023 22:58:03 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 15bb7a1e-8bba-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1672786685; bh=mj1hV3XKQIygCD5C9KFURA84Ye2W3J4D7Pbw0h3BRWA=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From:Subject:Reply-To; b=oVLw59c2TpHpmBbmqkxVGh+rT0QahuIz5Kwu3F0cTm0BnxdWl5gMqpZxe84EQL2WUFg4ORFhLXXYnU6BjzTyxhrgCLA4ld+nIeHBCSOm51s7tue3kjRPWRkkVGwu5KU+jPW6v4SlflGTS771Ea/Fh7N9qYftEnMI1+l4L1j3p2nJcrwHztX/GxBHFSFhALY1GZ30rBNBmYqMWud3yGjE7rIrqqL16Q/R+ujs/w1p+9C1ezFjyJ4UihG1DRH9yOiK6ASlSHl90qs6Om/3woxlQ+/12lxNu/A4A1+xuQm+M2Pb4EY4EEdFbqN60dx3V/T5uFd8BVZzh/CH13z3yAW+AQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1672786685; bh=WiuYg/8LnJwOnfok6Fmccn7n30Kdg+k73gk70EwdB92=; h=X-Sonic-MF:Date:Subject:From:To:From:Subject; b=n4kTffxFaPUi2qDYIzZilwOPEGgKbbVccVG0Um9oVZF/xBMv7Vkgz2STKSFbvIMCYplYb4V70da4km5LNhSQJS7UV6FTVJTZBGjVFy9KqWW4G9bqHDBRrvIsmg1cctQV3h98fY5gUs2+sbDZ+q+0tVDJUiubWWiD1TQUgCW9+Sv+H5lr+v2/3SxLL+q0aRFO1nHBbjyi2Q3ybniWyDzLTC6AZzEOzerZTIMl86SEN4PoTh0WMzb9sG0OlGZndwCIIDUgsw8iiMwbRnGLeeQBjYqoH/MT0/np5/37GVCoFuY6M+VhNyeYsMtCmDsYYEfTYtbGV0FNffjHvtrX/9BiIg== X-YMail-OSG: q4EKH0wVM1mptllaHzGei_ILU8jAVyZuPHgXULVo9UBiHSGLwwc31Ply3EO5C_j wACY7Ozc2P.BmIh91qBKmgPSm_w0K.uq2avCrTNHwWPUcONjUMZmZhTD.iJPaYr0ofsqkbSXQxrW yI7fBHMqDDw7lkH6R2rmeJfLmZuVdSNANun7UwLC.X0eS96xMOQKVi3h1aQfC0hfE_mKg5QzRNJH _KvOX5hKqTrmQejreoA.zM2GDEOPCcKD.ftFbBYppPivdK7PaU0aHWGd3rS_2QmDMBFX2ISgAvi6 VYod1cMb9Q.K7ZeWplt_2ORWMnlmXq54U8NVj68I0iJAgNhfgZ9cPS5.GtaJJq_rsrztZq.407q6 SaDUe72dL66fjNW82fgyU8Hb3Qvcf2eWgPDzrNuuYOusgH1.pM8pUkizr2A0urEi6fG9zu83.hMF Uu1Z.z5gmKqZtb9EUvGsoMKqTyXssbrBmk38nNOu2jmgIITY84WoaCSYgfK6EFDOqoG8zPqOhW1B jeqjjYqWFj5dl86hkBwqBImFfVx6Fm52sQzjtm57_c1fQ4kezh3onY2uiJsVexxsdpqBcW0EFD4O 7RGJY7c.Ye_mgreGmjhSq7loxnbtH7KX_mCMmO9Nw.Xrwhor5ErcgHIQ8MFSge2GBazCdCGPv249 zI4sTBvaIQjXi8rZZvmC1mH6B6IrbHbu8pszTXFLHp.dEJ5NPFF3.FRcVuHrhQXQ2p63sRKstB7Y wqOzAeDx.3cIpoU4POhY2sHff3IGa4S8EHtj5taw7KqHuMbguRFl6Elx5oDKNYELXuBJyGHnWzNh 6UhrYxbR0tba7icOFdY6UWbU86W.NNpwp.K2eQTKoza2sgXq3NE3xdkGU.9XFsd8OGx4Ykz_09rO jbkpPuTzxeyVbirGqNDMTlr_F0F_1N2VyIjJq8SkrGWwUw.GJDmBsIT30hk8A08zelBxAmZfgmcG a_Ze93VozORjSudR5nvwK6TQa7t5TNZ1Z9U7ZLTBiVoceC_CRElukLTnLeBdguuo688N7oqJq5R9 4ZEJvpu36Ti_m2WX6RCsWuT3rT8uddUQzVfbK.VGVItJFaqaKczb7KTzhIKj9IsDrOjCeC.tnb3t OtB78VpZXKKtE8xSDGvvzm.dgPP91_7hBYuzZxzQdtCUXo9XacpIDm8KhUgCaU_VMxcDuf_Z1lhm PqkWln5DukOy2EU395DnU0rfaMKUQC2ETwdtA4oHUr1p7covCCWEggkl.MkKi9Nhs1diZ11KXwmB HiVy2elukJBMBG9SFcM59LO3Vq5gqo0eq6octYtyU1Ivj0BYesHwpI.lOTsWcgbVsDyW3Jvhu015 ViiN0ZRgBd6Xkfbrf5Ro.OFXmU6j3EZyRZscdY.aopdIEVVDaXzjiZfyHVdg0x.6cfTfMMvoQEMT ubG4.ox9jnC2YKpIO.RNbVujqmWEYeScj7lKAbdEVdGWpSGhYlAN13Hlxdf5aGy.O6Oib4mayIf3 getvbasKI899OX8sDSXYGrH1guctlqIPoZpt.dkwAdTZz_W6wlYlZapXPlXpvys.FIQUWkQAtNGe G5xlNLfnYyhFOFt_UfYMYtBgy7ePWgJc.wbk6AJ2lknqf31vK2I.CnOl2kVQQsPFOk84TG6r_VN0 cO0iE0gC9Vv2FytA0M1Z0JGCSLi.gBzvEAov0ujaEVjEOxuidZZxtkzY_mCfAL3UngrbptbVTdPn 32q3dkuwQix5QniG6pBCZqMGC61lMaNwj18r.LdombM1WOOrq.dIF2KuE7dnEUCwBaeRXvAXDZe. MDDsfxxnDSAbPHctZxxFYLcEpO5oBwT9Ue2CJhsApL0qFqmFHbeLmoqZE5epPi81_TmnuBg3o7L0 DyNllDHNGMBoOP64A7.IKcvEUFiNDmpXf4dBgsB1Ditj4PSB98qt0umhviu_NfYRzeuLKV0Ty49_ TJkZVXvUMQsjmlSYNr9_mkVVfagt.bZ8QQ6ypqg6Hhq02tEJOijwlfoqmvGgjiYrv3ZGJjWJ5jl5 7rAcWotmCnwVU0TWrQohDjDwSNmckodQ_v1pp7pmudJhoQNKXTHjx0tUKpH645wUen8OovJyDsH7 0XecIee8uKHH3tdaBSSzKkked2Op_60w9jWrPkEnT.1b5ivSa5_QJpheO4lXoZw9L8gZvhlToTq2 Ud1OF9PCSVmvPOl4TKR9ep3rZbjZ1ISNFut_K4YE7pFdXcbp2wPY7nEqL.cqU.bCo253JwXaOk7I ODzkowUPjZrwGIitOBZbHnyEE39.atOM- X-Sonic-MF: Message-ID: Date: Tue, 3 Jan 2023 17:58:01 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v6] xen/pt: reserve PCI slot 2 for Intel igd-passthru Content-Language: en-US From: Chuck Zmudzinski To: Alex Williamson , Anthony Perard , Paul Durrant Cc: "Michael S. Tsirkin" , Stefano Stabellini , Paolo Bonzini , Richard Henderson , Eduardo Habkost , Marcel Apfelbaum , xen-devel@lists.xenproject.org, qemu-devel@nongnu.org References: <830263507e8f1a24a94f81909d5102c4b204e938.1672615492.git.brchuckz.ref@aol.com> <830263507e8f1a24a94f81909d5102c4b204e938.1672615492.git.brchuckz@aol.com> <20230102124605-mutt-send-email-mst@kernel.org> <20230103081456.1d676b8e.alex.williamson@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailer: WebService/1.1.20982 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 6508 On 1/3/2023 4:50 PM, Chuck Zmudzinski wrote: > On 1/3/2023 10:14 AM, Alex Williamson wrote: > > On Mon, 2 Jan 2023 18:10:24 -0500 > > Chuck Zmudzinski wrote: > > > > > On 1/2/23 12:46 PM, Michael S. Tsirkin wrote: > > > > On Sun, Jan 01, 2023 at 06:52:03PM -0500, Chuck Zmudzinski wrote: > > > > > Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, > > > > > as noted in docs/igd-assign.txt in the Qemu source code. > > > > > ... > > > > > Signed-off-by: Chuck Zmudzinski > > > > > > > > I'm not sure why is the issue xen specific. Can you explain? > > > > Doesn't it affect kvm too? > > > > > > Recall from docs/igd-assign.txt that there are two modes for > > > igd passthrough: legacy and upt, and the igd needs to be > > > at slot 2 only when using legacy mode which gives one > > > single guest exclusive access to the Intel igd. > > > > > > It's only xen specific insofar as xen does not have support > > > for the upt mode so xen must use legacy mode which > > > requires the igd to be at slot 2. I am not an expert with > > > > UPT mode never fully materialized for direct assignment, the folks at > > Intel championing this scenario left. > > Thanks for clarifying that for me. > > > > > > kvm, but if I understand correctly, with kvm one can use > > > the upt mode with the Intel i915 kvmgt kernel module > > > and in that case the guest will see a virtual Intel gpu > > > that can be at any arbitrary slot when using kvmgt, and > > > also, in that case, more than one guest can access the > > > igd through the kvmgt kernel module. > > > > This is true, IIRC an Intel vGPU does not need to be in slot 2. > > > > > Again, I am not an expert and do not have as much > > > experience with kvm, but if I understand correctly it is > > > possible to use the legacy mode with kvm and I think you > > > are correct that if one uses kvm in legacy mode and without > > > using the Intel i915 kvmgt kernel module, then it would be > > > necessary to reserve slot 2 for the igd on kvm. > > > > It's necessary to configure the assigned IGD at slot 2 to make it > > functional, yes, but I don't really understand this notion of > > "reserving" slot 2. If something occupies address 00:02.0 in the > > config, it's the user's or management tool's responsibility to move it > > to make this configuration functional. Why does QEMU need to play a > > part in reserving this bus address. IGD devices are not generally > > hot-pluggable either, so it doesn't seem we need to reserve an address > > in case an IGD device is added dynamically later. > > As I said in earlier message in this thread, the xenlight toolstack (libxl) that is > provided as the default toolstack for building xen guests with pci passthrough > is not the most flexible management tool, and that is why, in the case of xen, > it is simpler to reserve slot 2 while qemu assigns the slot addresses of the > qemu emulated pci devices so that the igd can use slot 2. IIRC, In hw/pci/pci.c, > once the slot value is assigned, it is constant and cannot be changed later on > by a management tool. > > > > > > Your question makes me curious, and I have not been able > > > to determine if anyone has tried igd passthrough using > > > legacy mode on kvm with recent versions of linux and qemu. > > > > Yes, it works. > > > > > I will try reproducing the problem on kvm in legacy mode with > > > current versions of linux and qemu and report my findings. > > > With kvm, there might be enough flexibility to specify the > > > slot number for every pci device in the guest. Such a > > > > I think this is always the recommendation, libvirt will do this by > > default in order to make sure the configuration is reproducible. This > > is what we generally rely on for kvm/vfio IGD assignment to place the > > GPU at the correct address. > > > > > capability is not available using the xenlight toolstack > > > for managing xen guests, so I have been using this patch > > > to ensure that the Intel igd is at slot 2 with xen guests > > > created by the xenlight toolstack. > > > > Seems like a deficiency in xenlight. I'm not sure why QEMU should take > > on this burden to support support tool stacks that lack such basic > > features. > > So you would prefer to patch xenlight (libxl) to make it flexible enough to properly > handle this case of legacy igd passthrough. > > > > > > The patch as is will only fix the problem on xen, so if the > > > problem exists on kvm also, I agree that the patch should > > > be modified to also fix it on kvm. > > > > AFAICT, it's not a problem on kvm/vfio because we generally make use of > > invocations that specify bus addresses for each device by default, > > making this a configuration requirement for the user or management tool > > stack. Thanks, > > Unfortunately, and as I mentioned in an earlier message on this thread, > the xenlight management tool stack (libxl) is not so flexible and does not > make it so easy for the administrator to specify the bus address of each > device, and that is why either this patch is needed for igd legacy passtrhough > on xen, or the libxl management tool needs to be patched so it is flexible > enough to enable the slot addresses to be assigned correctly using > that tool instead of relying on qemu to reserve slot 2 for the igd. > > If there is a consensus that this should be fixed in libxl instead of in qemu, > I will work on a patch to libxl, but I will wait a while for some feedback from > the xen people (Anthony, Paul) before I do that. Hello Anthony and Paul, I am requesting your feedback to Alex Williamson's suggestion that this problem with assigning the correct slot address to the igd on xen should be fixed in libxl instead of in qemu. It seems to me that the xen folks and the kvm folks have two different philosophies regarding how a tool stack should be designed. kvm/libvirt provides much greater flexibility in configuring the guest which puts the burden on the administrator to set all the options correctly for a given feature set, while xen/xenlight does not provide so much flexibility and tries to automatically configure the guest based on a high-level feature option such as the igd-passthrough=on option that is available for xen guests using qemu but not for kvm guests using qemu. What do you think? Should libxl be patched instead of fixing the problem with this patch to qemu, which is contrary to Alex's suggestion? Thanks in advance, Chuck From xen-devel-bounces@lists.xenproject.org Tue Jan 03 23:13:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 Jan 2023 23:13:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470785.730406 (Exim 4.92) (envelope-from ) id 1pCqSr-0003Qc-GH; Tue, 03 Jan 2023 23:13:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470785.730406; Tue, 03 Jan 2023 23:13:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCqSr-0003QV-DF; Tue, 03 Jan 2023 23:13:01 +0000 Received: by outflank-mailman (input) for mailman id 470785; Tue, 03 Jan 2023 23:12:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCqSp-0003QP-Qh for xen-devel@lists.xenproject.org; Tue, 03 Jan 2023 23:12:59 +0000 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [2a00:1450:4864:20::431]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 28c971a9-8bbc-11ed-91b6-6bf2151ebd3b; Wed, 04 Jan 2023 00:12:57 +0100 (CET) Received: by mail-wr1-x431.google.com with SMTP id y8so31270773wrl.13 for ; Tue, 03 Jan 2023 15:12:57 -0800 (PST) Received: from ?IPv6:::1? (p200300faaf0bb20094284aaccacb64e1.dip0.t-ipconnect.de. [2003:fa:af0b:b200:9428:4aac:cacb:64e1]) by smtp.gmail.com with ESMTPSA id a18-20020a5d4d52000000b0028df2d57204sm16840020wru.81.2023.01.03.15.12.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Jan 2023 15:12:56 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 28c971a9-8bbc-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=7+qafBATEoa+2wTKgOzGNp070b+aJSvCBksgwfL9zmI=; b=FfjpMyyhXfBZThxZeYGQQO7vyOLV9v0CEBG6dVn0ZgBxugLJMWJFd+HsU69RlII0C5 /NLql6fmLqkER/sYBYysomuni9ejwEf7pxSGpAaLjsF7eIsaeBgxI1z74MJkrgXL2kup nCuuYp4mXX+BAmgm7SJnSWiNnYy1w7RUz530xYxJMgmpoH8y3sHa1My98uOYcLgv7QnL xlHE4D85uwdfL1i7el8H9LOGgF+r9iZrSVpxLUQpOXnc36chinVi9laOaZdgnkTVpro0 ck9PK0oPV359foRYgxXgeM46zviSi6e0Qi7JAOcLHC6FAfFdoQHJMEmicC2WMdlMwzGD k7bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7+qafBATEoa+2wTKgOzGNp070b+aJSvCBksgwfL9zmI=; b=1+jdHgsIUKXyam0rAKhbMaMdeNe2Hw/qhMM9jjyuxQUaTh6QvfxulR7znGv6B14ilj elo6afXkXW2cbQFp3DGXBLGaKjEviNxonXksOdYZuCo2gljTtKJp+lBnLCUwZwMti2ZT b++c0KttX7RqOy3VcPEFr0Vj6otj/QiQTwbfuvye30OPDl6bWzzTnqHU1phpqbzU4Ute 12WoJ6V0WG45h7VBFUyJ0wr1t7rLzUNNHH0qr7i8jeaxnI5u8mqIDMOONB6/PJ3Rndqp DqS0qFQW+XUciao4dVaEReYibzNfjj2D4Qsmns15Y2D4VBt6kkvt3DlC19inXPmRhChQ SNoA== X-Gm-Message-State: AFqh2krWJU0dI4ctT2wFsXMNzEaEOa3TH1yDycLEMC7shWq3yXfpshdc poa2/FFJS7glvT4YF9Oxsj8= X-Google-Smtp-Source: AMrXdXv5WbayTDQhnHzoCHddCGvxv2hlBPr+kTrTQpT4lKo5mnbVdopIJ2APRWebmxbsRfsVjBUHYg== X-Received: by 2002:a5d:42cc:0:b0:28a:326d:1d11 with SMTP id t12-20020a5d42cc000000b0028a326d1d11mr14209407wrr.53.1672787576887; Tue, 03 Jan 2023 15:12:56 -0800 (PST) Date: Tue, 03 Jan 2023 23:12:48 +0000 From: Bernhard Beschow To: Chuck Zmudzinski , =?ISO-8859-1?Q?Philippe_Mathieu-Daud=E9?= CC: qemu-devel@nongnu.org, Paul Durrant , Marcel Apfelbaum , "Michael S. Tsirkin" , Stefano Stabellini , Anthony Perard , Aurelien Jarno , Eduardo Habkost , xen-devel@lists.xenproject.org, =?ISO-8859-1?Q?Herv=E9_Poussineau?= , Paolo Bonzini , Richard Henderson Subject: Re: [PATCH 0/6] Resolve TYPE_PIIX3_XEN_DEVICE In-Reply-To: <6360e4a1-dc2b-685e-5e19-62b92eec695b@aol.com> References: <20230102213504.14646-1-shentey@gmail.com> <0de699a7-98b8-e320-da4d-678d0f594213@linaro.org> <6360e4a1-dc2b-685e-5e19-62b92eec695b@aol.com> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Am 3=2E Januar 2023 17:25:35 UTC schrieb Chuck Zmudzinski : >On 1/3/2023 8:38 AM, Bernhard Beschow wrote: >> >> >> On Tue, Jan 3, 2023 at 2:17 PM Philippe Mathieu-Daud=C3=A9 wrote: >> >> Hi Chuck, >> >> On 3/1/23 04:15, Chuck Zmudzinski wrote: >> > On 1/2/23 4:34=E2=80=AFPM, Bernhard Beschow wrote: >> >> This series first renders TYPE_PIIX3_XEN_DEVICE redundant and fi= nally removes >> >> it=2E The motivation is to 1/ decouple PIIX from Xen and 2/ to m= ake Xen in the PC >> >> machine agnostic to the precise southbridge being used=2E 2/ wil= l become >> >> particularily interesting once PIIX4 becomes usable in the PC ma= chine, avoiding >> >> the "Frankenstein" use of PIIX4_ACPI in PIIX3=2E >> >> >> >> Testing done: >> >> None, because I don't know how to conduct this properly :( >> >> >> >> Based-on: <20221221170003=2E2929-1-shentey@gmail=2Ecom> >> >>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "[PATCH v4 00/30] Conso= lidate PIIX south bridges" >> >> This series is based on a previous series: >> https://lore=2Ekernel=2Eorg/qemu-devel/20221221170003=2E2929-1-shen= tey@gmail=2Ecom/ >> (which itself also is)=2E >> >> >> Bernhard Beschow (6): >> >>=C2=A0 =C2=A0 include/hw/xen/xen: Make xen_piix3_set_irq() generi= c and rename it >> >>=C2=A0 =C2=A0 hw/isa/piix: Reuse piix3_realize() in piix3_xen_rea= lize() >> >>=C2=A0 =C2=A0 hw/isa/piix: Wire up Xen PCI IRQ handling outside o= f PIIX3 >> >>=C2=A0 =C2=A0 hw/isa/piix: Avoid Xen-specific variant of piix_wri= te_config() >> >>=C2=A0 =C2=A0 hw/isa/piix: Resolve redundant k->config_write assi= gnments >> >>=C2=A0 =C2=A0 hw/isa/piix: Resolve redundant TYPE_PIIX3_XEN_DEVIC= E >> >> >> >>=C2=A0 =C2=A0hw/i386/pc_piix=2Ec=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0| 34 ++++++++++++++++-- >> >>=C2=A0 =C2=A0hw/i386/xen/xen-hvm=2Ec=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0|=C2=A0 9 +++-- >> >>=C2=A0 =C2=A0hw/isa/piix=2Ec=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0| 66 +---------------------------------- >> > >> > This file does not exist on the Qemu master branch=2E >> > But hw/isa/piix3=2Ec and hw/isa/piix4=2Ec do exist=2E >> > >> > I tried renaming it from piix=2Ec to piix3=2Ec in the patch, but >> > the patch set still does not apply cleanly on my tree=2E >> > >> > Is this patch set re-based against something other than >> > the current master Qemu branch? >> > >> > I have a system that is suitable for testing this patch set, but >> > I need guidance on how to apply it to the Qemu source tree=2E >> >> You can ask Bernhard to publish a branch with the full work, >> >> >> Hi Chuck, >> >> =2E=2E=2E or just visit https://patchew=2Eorg/QEMU/20230102213504=2E146= 46-1-shentey@gmail=2Ecom/ =2E There you'll find a git tag with a complete h= istory and all instructions! >> >> Thanks for giving my series a test ride! >> >> Best regards, >> Bernhard >> >> or apply each series locally=2E I use the b4 tool for that: >> https://b4=2Edocs=2Ekernel=2Eorg/en/latest/installing=2Ehtml >> >> i=2Ee=2E: >> >> $ git checkout -b shentey_work >> $ b4 am 20221120150550=2E63059-1-shentey@gmail=2Ecom >> $ git am >> =2E/v2_20221120_shentey_decouple_intx_to_lnkx_routing_from_south_br= idges=2Embx >> $ b4 am 20221221170003=2E2929-1-shentey@gmail=2Ecom >> $ git am >> =2E/v4_20221221_shentey_this_series_consolidates_the_implementation= s_of_the_piix3_and_piix4_south=2Embx >> $ b4 am 20230102213504=2E14646-1-shentey@gmail=2Ecom >> $ git am =2E/20230102_shentey_resolve_type_piix3_xen_device=2Embx >> >> Now the branch 'shentey_work' contains all the patches and you can = test=2E >> >> Regards, >> >> Phil=2E >> > >OK, I didn't see the "Consolidate PIIX south bridges" series is a >prerequisite=2E > >I will try it - it may take a couple of days because I need to test both >patch series in my environment and I can only work on this in my spare >time=2E > >I will provide Tested-by tags to both series if successful=2E Otherwise, >I will reply with an explanation of any problems=2E Sounds good! You don't need to test the prerequisite though since it is al= ready reviewed=2E It would be completely sufficient if you could test this = series to fill in the gap for my limited Xen knowledge -- thanks! Best regards, Bernhard > >Chuck From xen-devel-bounces@lists.xenproject.org Wed Jan 04 00:38:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 00:38:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470792.730418 (Exim 4.92) (envelope-from ) id 1pCrnG-0003ux-UJ; Wed, 04 Jan 2023 00:38:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470792.730418; Wed, 04 Jan 2023 00:38:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCrnG-0003uq-P0; Wed, 04 Jan 2023 00:38:10 +0000 Received: by outflank-mailman (input) for mailman id 470792; Wed, 04 Jan 2023 00:38:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCrnE-0003uf-UK; Wed, 04 Jan 2023 00:38:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCrnE-0002BX-Rl; Wed, 04 Jan 2023 00:38:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCrnE-0004wD-A9; Wed, 04 Jan 2023 00:38:08 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pCrnE-0000WN-9O; Wed, 04 Jan 2023 00:38:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=E3bsdIUnk3QSGeuOzyoRSHT+vVNTZiIud/NMZwF6ZU0=; b=bbQwdGaqHfbDYT2em1vZLhV1Mx neUqda85SaonsN1WPuPSBLIfh1W7KZV9jIVlYOaCQv6YsL7cqvtA/CxCao8ZQBYXAZzq0swMj1ive chcNqmBUr6msaPi2o97nDCdXigCjgk841QUXeWieDY1vy57p5I38g3jQj0UFFxFPR3Ps=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 175559: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=69b41ac87e4a664de78a395ff97166f0b2943210 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Wed, 04 Jan 2023 00:38:08 +0000 flight 175559 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/175559/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine 8 reboot fail REGR. vs. 173462 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux 69b41ac87e4a664de78a395ff97166f0b2943210 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 88 days Failing since 173470 2022-10-08 06:21:34 Z 87 days 182 attempts Testing same since 175552 2023-01-02 21:13:23 Z 1 days 3 attempts ------------------------------------------------------------ 3257 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 497265 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Jan 04 01:08:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 01:08:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470805.730428 (Exim 4.92) (envelope-from ) id 1pCsGI-0001Cy-Ez; Wed, 04 Jan 2023 01:08:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470805.730428; Wed, 04 Jan 2023 01:08:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCsGI-0001Cr-Ba; Wed, 04 Jan 2023 01:08:10 +0000 Received: by outflank-mailman (input) for mailman id 470805; Wed, 04 Jan 2023 01:08:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCsGH-0001Cl-E2 for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 01:08:09 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [2604:1380:4601:e00::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3ef0ec07-8bcc-11ed-b8d0-410ff93cb8f0; Wed, 04 Jan 2023 02:08:06 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D7277B810A5; Wed, 4 Jan 2023 01:08:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 908D2C433D2; Wed, 4 Jan 2023 01:08:03 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3ef0ec07-8bcc-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672794484; bh=BMlVarPMrb1stKvQSfClz/2+qPszURvdTGuLCEAjXoQ=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=PdY8whexeyDHkc9yR78kXhn6ArLt0hzS+qjbzyW/uk8WiBBzI0Uzp7hiwPQH6h8bE XFZhPsZw+QZkGNnkeyNOhsd+bBloGR6UxIomrCVyBujXVHrxkELkXAoC1aAiaQtoQF BhuzQiAM69+1SScIIhDnuB9Vf+Aagh0QzbClTXaQRHSy7lQD/tBxQhZuWrS631AtOd u9LWyMlNSAL17atr6Uobw8SbrtYSPY14X6KXbGLFCUJAE7nXPMeoyErnMGBNkzMuEY GyZ9aCYCfPg0/oUbrvfNp1HFMZFmtDbruOv4nQyKBDo9FmUxDB5BUcRCZ5UqIqCwHZ A/EHdi2M9o9/g== Date: Tue, 3 Jan 2023 17:08:01 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Andrew Cooper cc: Xen-devel , Doug Goldstein , Stefano Stabellini , Anthony PERARD , Michal Orzel , Oleksii Kurochko Subject: Re: [PATCH 1/6] CI: Drop automation/configs/ In-Reply-To: <20221230003848.3241-2-andrew.cooper3@citrix.com> Message-ID: References: <20221230003848.3241-1-andrew.cooper3@citrix.com> <20221230003848.3241-2-andrew.cooper3@citrix.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 30 Dec 2022, Andrew Cooper wrote: > Having 3 extra hypervisor builds on the end of a full build is deeply > confusing to debug if one of them fails, because the .config file presented in > the artefacts is not the one which caused a build failure. Also, the log > tends to be truncated in the UI. > > PV-only is tested as part of PV-Shim in a full build anyway, so doesn't need > repeating. HVM-only and neither will come up frequently in randconfig, so > drop all the logic here to simplify things. > > Signed-off-by: Andrew Cooper Reviewed-by: Stefano Stabellini > --- > CC: Doug Goldstein > CC: Stefano Stabellini > CC: Anthony PERARD > CC: Michal Orzel > CC: Oleksii Kurochko > --- > automation/configs/x86/hvm_only_config | 3 --- > automation/configs/x86/no_hvm_pv_config | 3 --- > automation/configs/x86/pv_only_config | 3 --- > automation/scripts/build | 21 --------------------- > 4 files changed, 30 deletions(-) > delete mode 100644 automation/configs/x86/hvm_only_config > delete mode 100644 automation/configs/x86/no_hvm_pv_config > delete mode 100644 automation/configs/x86/pv_only_config > > diff --git a/automation/configs/x86/hvm_only_config b/automation/configs/x86/hvm_only_config > deleted file mode 100644 > index 9efbddd5353b..000000000000 > --- a/automation/configs/x86/hvm_only_config > +++ /dev/null > @@ -1,3 +0,0 @@ > -CONFIG_HVM=y > -# CONFIG_PV is not set > -# CONFIG_DEBUG is not set > diff --git a/automation/configs/x86/no_hvm_pv_config b/automation/configs/x86/no_hvm_pv_config > deleted file mode 100644 > index 0bf6a8e46818..000000000000 > --- a/automation/configs/x86/no_hvm_pv_config > +++ /dev/null > @@ -1,3 +0,0 @@ > -# CONFIG_HVM is not set > -# CONFIG_PV is not set > -# CONFIG_DEBUG is not set > diff --git a/automation/configs/x86/pv_only_config b/automation/configs/x86/pv_only_config > deleted file mode 100644 > index e9d8b4a7c753..000000000000 > --- a/automation/configs/x86/pv_only_config > +++ /dev/null > @@ -1,3 +0,0 @@ > -CONFIG_PV=y > -# CONFIG_HVM is not set > -# CONFIG_DEBUG is not set > diff --git a/automation/scripts/build b/automation/scripts/build > index a5934190634b..5dafa72ba540 100755 > --- a/automation/scripts/build > +++ b/automation/scripts/build > @@ -85,24 +85,3 @@ if [[ "${XEN_TARGET_ARCH}" != "x86_32" ]]; then > cp -r dist binaries/ > fi > fi > - > -if [[ "${hypervisor_only}" == "y" ]]; then > - # If we are build testing a specific Kconfig exit now, there's no point in > - # testing all the possible configs. > - exit 0 > -fi > - > -# Build all the configs we care about > -case ${XEN_TARGET_ARCH} in > - x86_64) arch=x86 ;; > - *) exit 0 ;; > -esac > - > -cfg_dir="automation/configs/${arch}" > -for cfg in `ls ${cfg_dir}`; do > - echo "Building $cfg" > - make -j$(nproc) -C xen clean > - rm -f xen/.config > - make -C xen KBUILD_DEFCONFIG=../../../../${cfg_dir}/${cfg} defconfig > - make -j$(nproc) -C xen > -done > -- > 2.11.0 > From xen-devel-bounces@lists.xenproject.org Wed Jan 04 01:10:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 01:10:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470812.730439 (Exim 4.92) (envelope-from ) id 1pCsIn-0002aC-Qe; Wed, 04 Jan 2023 01:10:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470812.730439; Wed, 04 Jan 2023 01:10:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCsIn-0002a5-O2; Wed, 04 Jan 2023 01:10:45 +0000 Received: by outflank-mailman (input) for mailman id 470812; Wed, 04 Jan 2023 01:10:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCsIm-0002Ze-KY for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 01:10:44 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9c77776d-8bcc-11ed-91b6-6bf2151ebd3b; Wed, 04 Jan 2023 02:10:43 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1CFA4B810A5; Wed, 4 Jan 2023 01:10:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EC4D6C433EF; Wed, 4 Jan 2023 01:10:40 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9c77776d-8bcc-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672794641; bh=GDcvH45biK4FMGW3wYmyxksscV4VpSyTbRTo0Z0xoQA=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=HPSfISB5bqRcObrshfvAhQQJ7L8WUNPmN9FAgm5AXd1J0bW/8B0NEXM3iZgGsbKIJ 98r3rcHwzqZVe3gy6+hcSnZpFybisbvCUp2LDwID3sY8mAknXpf555maiIAv7zJ9gJ UP7ZnF5qxmP12xDyY8hSioE3Vl0ZKU0A0MaWcxuxcicCCuUEdMWSd2mEus4WzjEWMs UARo1Oyc9E0qUDqxzVCEt2iGcZBGdbPV9tLVpomcTsfEE43jo00Qcs9lKn4rZTYxDn 35Z2EsyfgpvLGRw7snf4QGRBeXUsKBOnG0+VKYx0RUGfiEDiDZFmLReRgBx/ax2aDz rBGyRA2zBqiSQ== Date: Tue, 3 Jan 2023 17:10:38 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Andrew Cooper cc: Xen-devel , Doug Goldstein , Stefano Stabellini , Anthony PERARD , Michal Orzel , Oleksii Kurochko Subject: Re: [PATCH 2/6] CI: Remove guesswork about which artefacts to preserve In-Reply-To: <20221230003848.3241-3-andrew.cooper3@citrix.com> Message-ID: References: <20221230003848.3241-1-andrew.cooper3@citrix.com> <20221230003848.3241-3-andrew.cooper3@citrix.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 30 Dec 2022, Andrew Cooper wrote: > Preserve the artefacts based on the `make` rune we actually ran, rather than > guesswork about which rune we would have run based on other settings. > > Note that the ARM qemu smoke tests depend on finding binaries/xen even from > full builds. Also that the Jessie-32 containers build tools but not Xen. > > This means the x86_32 builds now store relevant artefacts. No change in other > configurations. > > Signed-off-by: Andrew Cooper > --- > CC: Doug Goldstein > CC: Stefano Stabellini > CC: Anthony PERARD > CC: Michal Orzel > CC: Oleksii Kurochko > --- > automation/scripts/build | 22 ++++++++++++++-------- > 1 file changed, 14 insertions(+), 8 deletions(-) > > diff --git a/automation/scripts/build b/automation/scripts/build > index 5dafa72ba540..8dee1cbbc251 100755 > --- a/automation/scripts/build > +++ b/automation/scripts/build > @@ -70,18 +70,24 @@ if [[ "${CC}" == "gcc" && `cc-ver` -lt 0x040600 ]]; then > cfgargs+=("--with-system-seabios=/bin/false") > fi > > +# Directory for the artefacts to be dumped into > +mkdir binaries > + > if [[ "${hypervisor_only}" == "y" ]]; then > + # Xen-only build > make -j$(nproc) xen > + > + # Preserve artefacts > + cp xen/xen binaries/xen > else > + # Full build > ./configure "${cfgargs[@]}" > make -j$(nproc) dist > -fi > > -# Extract artifacts to avoid getting rewritten by customised builds > -mkdir binaries > -if [[ "${XEN_TARGET_ARCH}" != "x86_32" ]]; then > - cp xen/xen binaries/xen > - if [[ "${hypervisor_only}" != "y" ]]; then > - cp -r dist binaries/ > - fi > + # Preserve artefacts > + # Note: Some smoke tests depending on finding binaries/xen on a full build > + # even though dist/ contains everything, while some containers don't even > + # build Xen > + cp -r dist binaries/ > + if [[ -f xen/xen ]] ; then cp xen/xen binaries/xen; fi why the "if" ? You could just: cp xen/xen binaries/xen unconditionally? If you are OK with this change you can do it on commit Reviewed-by: Stefano Stabellini From xen-devel-bounces@lists.xenproject.org Wed Jan 04 01:12:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 01:12:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470819.730450 (Exim 4.92) (envelope-from ) id 1pCsKg-0003A5-7Z; Wed, 04 Jan 2023 01:12:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470819.730450; Wed, 04 Jan 2023 01:12:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCsKg-00039w-3S; Wed, 04 Jan 2023 01:12:42 +0000 Received: by outflank-mailman (input) for mailman id 470819; Wed, 04 Jan 2023 01:12:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCsKe-00039m-8w for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 01:12:40 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e0e52d7e-8bcc-11ed-91b6-6bf2151ebd3b; Wed, 04 Jan 2023 02:12:39 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 83D96614CC; Wed, 4 Jan 2023 01:12:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EF0DDC433D2; Wed, 4 Jan 2023 01:12:35 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e0e52d7e-8bcc-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672794756; bh=M7neBu1eufP02ijEEgXFLm7XN0usVpAGztqI1Ji4c3Q=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=LY/KgCgyzX1J4lo2GPH8cS2Ty9MqIQoh7vcOUKeNTeT0RxiDvEogMGgEbpkx2tQUD FX+Ni/hOZn75YWWabLrPHDJdNVzwqy8k7qhJWrWB1MYt+T8zAHhHqdBmCU7gW0iP1T LvrZ+0cPv2quN87jSPmS0aYflozp2J8ZcyuH73PwBC2Uf7nU6jtCOegf/B6ulHf5/m mHWCUsHUVUT6TMUPjfRGR15XCD9TY3el++YbBqykb4gBAd6Tk06AwFqsaPXlt8KtFX 1oNijbnaK3HIC3BPOOCEFsjNcs+eKbS4YZBlXy1jtcUTf7LXyLGR2egJsiGj+DrQYO 0uYti9QbJne4A== Date: Tue, 3 Jan 2023 17:12:33 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Andrew Cooper cc: Xen-devel , Doug Goldstein , Stefano Stabellini , Anthony PERARD , Michal Orzel , Oleksii Kurochko Subject: Re: [PATCH 3/6] CI: Only calculate ./configure args if needed In-Reply-To: <20221230003848.3241-4-andrew.cooper3@citrix.com> Message-ID: References: <20221230003848.3241-1-andrew.cooper3@citrix.com> <20221230003848.3241-4-andrew.cooper3@citrix.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 30 Dec 2022, Andrew Cooper wrote: > This is purely code motion of the cfgargs construction, into the case where it > is used. > > No practical change. > > Signed-off-by: Andrew Cooper Reviewed-by: Stefano Stabellini > --- > CC: Doug Goldstein > CC: Stefano Stabellini > CC: Anthony PERARD > CC: Michal Orzel > CC: Oleksii Kurochko > --- > automation/scripts/build | 63 ++++++++++++++++++++++++------------------------ > 1 file changed, 31 insertions(+), 32 deletions(-) > > diff --git a/automation/scripts/build b/automation/scripts/build > index 8dee1cbbc251..f2301d08789d 100755 > --- a/automation/scripts/build > +++ b/automation/scripts/build > @@ -39,37 +39,6 @@ if [[ "${XEN_TARGET_ARCH}" = "arm32" ]]; then > hypervisor_only="y" > fi > > -# build up our configure options > -cfgargs=() > -cfgargs+=("--enable-docs") > - > -if [[ "${CC}" == "clang"* ]]; then > - # SeaBIOS cannot be built with clang > - cfgargs+=("--with-system-seabios=/usr/share/seabios/bios.bin") > - # iPXE cannot be built with clang > - cfgargs+=("--with-system-ipxe=/usr/lib/ipxe/ipxe.pxe") > - # newlib cannot be built with clang so we cannot build stubdoms > - cfgargs+=("--disable-stubdom") > -fi > - > -if ! test -z "$(ldd /bin/ls|grep musl|head -1)"; then > - # disable --disable-werror for QEMUU when building with MUSL > - cfgargs+=("--with-extra-qemuu-configure-args=\"--disable-werror\"") > - # SeaBIOS doesn't build on MUSL systems > - cfgargs+=("--with-system-seabios=/bin/false") > -fi > - > -# Qemu requires Python 3.5 or later, and ninja > -if ! type python3 || python3 -c "import sys; res = sys.version_info < (3, 5); exit(not(res))" \ > - || ! type ninja; then > - cfgargs+=("--with-system-qemu=/bin/false") > -fi > - > -# SeaBIOS requires GCC 4.6 or later > -if [[ "${CC}" == "gcc" && `cc-ver` -lt 0x040600 ]]; then > - cfgargs+=("--with-system-seabios=/bin/false") > -fi > - > # Directory for the artefacts to be dumped into > mkdir binaries > > @@ -80,7 +49,37 @@ if [[ "${hypervisor_only}" == "y" ]]; then > # Preserve artefacts > cp xen/xen binaries/xen > else > - # Full build > + # Full build. Figure out our ./configure options > + cfgargs=() > + cfgargs+=("--enable-docs") > + > + if [[ "${CC}" == "clang"* ]]; then > + # SeaBIOS cannot be built with clang > + cfgargs+=("--with-system-seabios=/usr/share/seabios/bios.bin") > + # iPXE cannot be built with clang > + cfgargs+=("--with-system-ipxe=/usr/lib/ipxe/ipxe.pxe") > + # newlib cannot be built with clang so we cannot build stubdoms > + cfgargs+=("--disable-stubdom") > + fi > + > + if ! test -z "$(ldd /bin/ls|grep musl|head -1)"; then > + # disable --disable-werror for QEMUU when building with MUSL > + cfgargs+=("--with-extra-qemuu-configure-args=\"--disable-werror\"") > + # SeaBIOS doesn't build on MUSL systems > + cfgargs+=("--with-system-seabios=/bin/false") > + fi > + > + # Qemu requires Python 3.5 or later, and ninja > + if ! type python3 || python3 -c "import sys; res = sys.version_info < (3, 5); exit(not(res))" \ > + || ! type ninja; then > + cfgargs+=("--with-system-qemu=/bin/false") > + fi > + > + # SeaBIOS requires GCC 4.6 or later > + if [[ "${CC}" == "gcc" && `cc-ver` -lt 0x040600 ]]; then > + cfgargs+=("--with-system-seabios=/bin/false") > + fi > + > ./configure "${cfgargs[@]}" > make -j$(nproc) dist > > -- > 2.11.0 > From xen-devel-bounces@lists.xenproject.org Wed Jan 04 01:15:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 01:15:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470826.730461 (Exim 4.92) (envelope-from ) id 1pCsNW-0003qI-Ka; Wed, 04 Jan 2023 01:15:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470826.730461; Wed, 04 Jan 2023 01:15:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCsNW-0003qB-Hz; Wed, 04 Jan 2023 01:15:38 +0000 Received: by outflank-mailman (input) for mailman id 470826; Wed, 04 Jan 2023 01:15:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCsNW-0003q5-0I for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 01:15:38 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4af041a3-8bcd-11ed-91b6-6bf2151ebd3b; Wed, 04 Jan 2023 02:15:36 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B777D6152B; Wed, 4 Jan 2023 01:15:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2E2DDC433D2; Wed, 4 Jan 2023 01:15:34 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4af041a3-8bcd-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672794935; bh=pSP+FWoGi3j9xVpx2Q3vxu2qFJqevFkECabRvGMIwXE=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=Nd1uLcSPDGKBsZxT370TxN3yzQoJgYOWyk6vqou7q8EP9q9c9jLz9XR0qpZm/9EqB ItRfa3flimSMn/Bj8hnoEus25CUaZQ0lLXYUAkYWBWv9iVnRf92Ck3hS/GCSNqFGZz tGFYR2hDPrl/LHa38nGteNmOvY6r1kDf0JEm2eye/EM/bIqUTKVaM08BAIjy7m8ySk 9XWczzTQihkECO72RHEKUv84hHNwgynGMpKoIegVm2J5EnKDJNjjrSlDpPx0xrqqFA qhCvdHxMP1LtdEVubYKkoJQNTIK4bCEs1UzNe90ZinCaN4IWj8iMsrwizhd9giUitS 5EEmxcRx/TF/A== Date: Tue, 3 Jan 2023 17:15:31 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Andrew Cooper cc: Xen-devel , Doug Goldstein , Stefano Stabellini , Anthony PERARD , Michal Orzel , Oleksii Kurochko Subject: Re: [PATCH 4/6] CI: Express HYPERVISOR_ONLY in build.yml In-Reply-To: <20221230003848.3241-5-andrew.cooper3@citrix.com> Message-ID: References: <20221230003848.3241-1-andrew.cooper3@citrix.com> <20221230003848.3241-5-andrew.cooper3@citrix.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 30 Dec 2022, Andrew Cooper wrote: > Whether to build only Xen, or everything, is a property of container, > toolchain and/or testcase. It is not a property of XEN_TARGET_ARCH. > > Capitalise HYPERVISOR_ONLY and have it set by the debian-unstable-gcc-arm32-* > testcases at the point that arm32 get matched with a container that can only > build Xen. > > For simplicity, retain the RANDCONFIG -> HYPERVISOR_ONLY implication. > > Signed-off-by: Andrew Cooper > --- > CC: Doug Goldstein > CC: Stefano Stabellini > CC: Anthony PERARD > CC: Michal Orzel > CC: Oleksii Kurochko > --- > automation/gitlab-ci/build.yaml | 2 ++ > automation/scripts/build | 11 ++++------- > 2 files changed, 6 insertions(+), 7 deletions(-) > > diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml > index 93d9ff69a9f2..e6a9357de3ef 100644 > --- a/automation/gitlab-ci/build.yaml > +++ b/automation/gitlab-ci/build.yaml > @@ -516,11 +516,13 @@ debian-unstable-gcc-arm32: > extends: .gcc-arm32-cross-build > variables: > CONTAINER: debian:unstable-arm32-gcc > + HYPERVISOR_ONLY: y > > debian-unstable-gcc-arm32-debug: > extends: .gcc-arm32-cross-build-debug > variables: > CONTAINER: debian:unstable-arm32-gcc > + HYPERVISOR_ONLY: y can you move the setting of HYPERVISOR_ONLY to .arm32-cross-build-tmpl ? I think that makes the most sense because .arm32-cross-build-tmpl is the one setting XEN_TARGET_ARCH and also the x86_64 tag. > > debian-unstable-gcc-arm32-randconfig: > extends: .gcc-arm32-cross-build > diff --git a/automation/scripts/build b/automation/scripts/build > index f2301d08789d..4c6d1f3b70bc 100755 > --- a/automation/scripts/build > +++ b/automation/scripts/build > @@ -19,7 +19,9 @@ if [[ "${RANDCONFIG}" == "y" ]]; then > fi > > make -j$(nproc) -C xen KCONFIG_ALLCONFIG=tools/kconfig/allrandom.config randconfig > - hypervisor_only="y" > + > + # RANDCONFIG implies HYPERVISOR_ONLY > + HYPERVISOR_ONLY="y" > else > echo "CONFIG_DEBUG=${debug}" > xen/.config > > @@ -34,15 +36,10 @@ fi > # to exit early -- bash is invoked with -e. > cp xen/.config xen-config > > -# arm32 only cross-compiles the hypervisor > -if [[ "${XEN_TARGET_ARCH}" = "arm32" ]]; then > - hypervisor_only="y" > -fi > - > # Directory for the artefacts to be dumped into > mkdir binaries > > -if [[ "${hypervisor_only}" == "y" ]]; then > +if [[ "${HYPERVISOR_ONLY}" == "y" ]]; then > # Xen-only build > make -j$(nproc) xen > > -- > 2.11.0 > From xen-devel-bounces@lists.xenproject.org Wed Jan 04 01:18:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 01:18:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470833.730472 (Exim 4.92) (envelope-from ) id 1pCsPs-0004Sj-0l; Wed, 04 Jan 2023 01:18:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470833.730472; Wed, 04 Jan 2023 01:18:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCsPr-0004Sc-U1; Wed, 04 Jan 2023 01:18:03 +0000 Received: by outflank-mailman (input) for mailman id 470833; Wed, 04 Jan 2023 01:18:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCsPq-0004SK-O3; Wed, 04 Jan 2023 01:18:02 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCsPq-0005HB-Jv; Wed, 04 Jan 2023 01:18:02 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCsPq-0005pj-7e; Wed, 04 Jan 2023 01:18:02 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pCsPq-0006Dl-7G; Wed, 04 Jan 2023 01:18:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=IC2bfMXVPIP3VLfpbogX9WUs2Pod6RrYRKd3mye1aJg=; b=w9STSdoCnpWc0re8REKgTpdG7x x12FLNpxohzOpde6SM9njOaNJ2VfJSHYNQhLElwhgIvttSfAah+3Z/QraBzNukYZ48yG+qf7JO5di pT+lhr3VO0OUHXy6pbtEi/tMTrqlA/kbiFFb5+i50sTvKqSjhIwuDIlpWofULXyx1hvc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 175560: tolerable FAIL - PUSHED X-Osstest-Failures: linux-5.4:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug linux-5.4:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-amd64-i386-xl-shadow:xen-install:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-libvirt-raw:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=851c2b5fb7936d54e1147f76f88e2675f9f82b52 X-Osstest-Versions-That: linux=66bb2e2b24ce52819a7070d3a3255726cb946b69 From: osstest service owner Date: Wed, 04 Jan 2023 01:18:02 +0000 flight 175560 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/175560/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 175557 pass in 175560 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail in 175557 pass in 175560 test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail in 175557 pass in 175560 test-amd64-i386-xl-shadow 7 xen-install fail pass in 175557 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail pass in 175557 test-armhf-armhf-libvirt-raw 13 guest-start fail pass in 175557 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail blocked in 175197 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail in 175557 like 175197 test-armhf-armhf-libvirt-raw 14 migrate-support-check fail in 175557 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 175197 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 175197 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175197 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 175197 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175197 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175197 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 175197 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 175197 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail like 175197 test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail like 175197 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 175197 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 175197 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175197 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux 851c2b5fb7936d54e1147f76f88e2675f9f82b52 baseline version: linux 66bb2e2b24ce52819a7070d3a3255726cb946b69 Last test of basis 175197 2022-12-14 10:43:17 Z 20 days Testing same since 175407 2022-12-19 11:42:26 Z 15 days 38 attempts ------------------------------------------------------------ People who touched revisions under test: Alexei Starovoitov Andrew Morton Baolin Wang Charles Keepax Florian Fainelli Greg Kroah-Hartman Guenter Roeck Heiko Schocher Hulk Robot Jakub Kicinski Jialiang Wang Jon Hunter Linus Walleij Linux Kernel Functional Testing Lorenzo Colitti Maciej Żenczykowski Marc Kleine-Budde Mark Brown Ming Lei Paul E. McKenney Ricardo Ribalda Samuel Mendoza-Jonas Sasha Levin Shiwei Cui Shuah Khan Simon Horman Sudip Mukherjee Yasushi SHOJI Yasushi SHOJI jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw fail test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 66bb2e2b24ce..851c2b5fb793 851c2b5fb7936d54e1147f76f88e2675f9f82b52 -> tested/linux-5.4 From xen-devel-bounces@lists.xenproject.org Wed Jan 04 01:18:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 01:18:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470843.730483 (Exim 4.92) (envelope-from ) id 1pCsQi-00053q-IX; Wed, 04 Jan 2023 01:18:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470843.730483; Wed, 04 Jan 2023 01:18:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCsQi-00053j-Ec; Wed, 04 Jan 2023 01:18:56 +0000 Received: by outflank-mailman (input) for mailman id 470843; Wed, 04 Jan 2023 01:18:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCsQg-0004ud-Ie for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 01:18:54 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id be53b235-8bcd-11ed-b8d0-410ff93cb8f0; Wed, 04 Jan 2023 02:18:51 +0100 (CET) Received: from mail-dm6nam10lp2101.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.101]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 03 Jan 2023 20:18:48 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DM4PR03MB6000.namprd03.prod.outlook.com (2603:10b6:5:38b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Wed, 4 Jan 2023 01:18:46 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5944.019; Wed, 4 Jan 2023 01:18:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: be53b235-8bcd-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1672795131; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=eqOY2ksHn1dUxyXx0p4brYvZm8CgsRTAnDvPno2SXMU=; b=hPwFtGuK+WOXxkhjj5L5hL3KxNJ9FtWvcK3hc3N/Nh6NIO8o9tRRoNLb wrfcclBn0ZTX7uBcC59OcVfRBKHLbE23v/9UrTLNiyvfzD9U++VwX3QEQ f4FBo9eQ5GIr06LsXwsbVJo32wIe+KgwYov40Jw4b/WfCQ25rMjFZfoYe U=; X-IronPort-RemoteIP: 104.47.58.101 X-IronPort-MID: 91475240 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:uQtTcaJdowZapfqTFE+RMZQlxSXFcZb7ZxGr2PjKsXjdYENS1WQGm mRKXmiEM66JZWDzKd9wbN/lpx5UvMXVmtUxQVdlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHv+kUrWs1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPdwP9TlK6q4mhA5wRlPa0jUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c55AjBiq eVGEAs8YzWngsa1+LG7aOpj05FLwMnDZOvzu1lG5BSAVbMKZM6GRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dnpTGLlWSd05C0WDbRUvWMSd9YgQCzo WXe8n6iKhobKMae2XyO9XfEaurnzHqnB99ISOXQGvhC2GSq4nQ+DQcqa3ih/Min03GzUol7N BlBksYphe1onKCxdfHmRAGxqnOAuh8aWvJTHvc85QXLzbDbiy6JC25BQjNfZdgOsM4tWSdsx lKPh8nuBzFkrPuSU3313rydtz+1NAAeJHUOYiJCRgwAi/HmoYozhxaJScxxHaqdh9j5Xzr3x liiqywzhK4SjIgIyr+89lDEhBqjo5HISkg+4QC/Y46+xgZwZYrga4n271HetK5ENNzAFgDHu 2UYkc+D6uxIFYuKiCGGXOQKGveu+uqBNzrfx1VoGvHN6giQxpJqRqgIiBkWGaujGp9slePBC KMLhT5s2Q== IronPort-HdrOrdr: A9a23:oR5fUagVgY0Y7I1Gq9jpB7YwxnBQXvwji2hC6mlwRA09TyXPrb HVoB0+726MtN93YgBHpTngAtjmfZq4z/RICOYqTNSftWXd2FdAT7sSibcKoQeQeREWrdQtrZ uIGpIWYLbN5DNB/KPHCWeDcuoI8Z2u7L2vnuvGymcFd3AQV0ii1WtE48Sgf3GeiDMoOXPxLv Sh2vY= X-IronPort-AV: E=Sophos;i="5.96,297,1665460800"; d="scan'208";a="91475240" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KexJpr9wgWU1QiwPzIyza/NBjZfYyhJGuUIwvIrS0oXyTbRL47jIaJCS4OKsfjTaCADleOsFH9cQEkMfZ8VpBgZ23D87LLqz1tonN7DQCtlD3kfDnPhW4goQkWASuxeB4QYZKfOI+f8tqbnk+FRyGXoNU9QADsVG6GINLBwDSa18Y0QqHGZGalpe3wGAKAGrTAikCa8Rop5k8oJqYEBeA2CBgJYPJltk8fXwvEV/x7kDAsyLYUh3RmS4Ecg/kKjKCwafc3dSRRCVDltJzATDBXXU5TeX5Ac5JwhTAlbFHjhxh1wnUwCIqWVIdfs/BJW1C38uHiLZafNkIf6UkSm2fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eqOY2ksHn1dUxyXx0p4brYvZm8CgsRTAnDvPno2SXMU=; b=R64kivNJImWCR+4n54KC9VBP/NI8x4cJe9gGN5vvbA+VhHuKszB09VsylC52SM+kyeCq6QRzsYSsEiZs4tTuBssj7AhSdS1RChwmkhQ81dGe2WkkCOzaNqgMBUdb0irl6aKl1PZjyIHsd2GPMA6Tfdhyx5ncHjfQ1gR9RtmY4+pIp0kzzi9Ft4DvHPmlPoRGwebfneSTvj1560eToN1yRGl3QdPraAy6L9Ng1zPsX1h8SZkIASPZY91DI666gD64FG3GGG2yM2FMR2RtxUkt0iOMPylLhRgUmDeesE9n78sn6IYPF2hNnaqg99vIcU24e4zw1U0TEL2vQqX3Tpe71Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eqOY2ksHn1dUxyXx0p4brYvZm8CgsRTAnDvPno2SXMU=; b=RJQF9NfNE2QdHMcbPFp8yVLTrnQunnAauwAo7Wk9M7oSlzj92h8WdKF2PdsbEqWmA43fW6jB/NuhseKQpYEU2wRIj0adW9Ccmu194LB96oeHQH9tIOmEpv1ZkXomSak/ey9f9wZszQcqvp4KaDic1DrSd9NORpyksuhzPxNYIaQ= From: Andrew Cooper To: Stefano Stabellini CC: Xen-devel , Doug Goldstein , Anthony Perard , Michal Orzel , Oleksii Kurochko Subject: Re: [PATCH 2/6] CI: Remove guesswork about which artefacts to preserve Thread-Topic: [PATCH 2/6] CI: Remove guesswork about which artefacts to preserve Thread-Index: AQHZG+cbH36uve2aEUGxm9tAfYRLqK6NeucAgAACRYA= Date: Wed, 4 Jan 2023 01:18:46 +0000 Message-ID: <71b7e387-8607-039b-6cb3-8555a1593361@citrix.com> References: <20221230003848.3241-1-andrew.cooper3@citrix.com> <20221230003848.3241-3-andrew.cooper3@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|DM4PR03MB6000:EE_ x-ms-office365-filtering-correlation-id: e2cc64c4-edbb-42ee-88e5-08daedf1a098 x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: oLwOb5ZgR2ChadQU6PJ7ze67qYvJKlEOSjXMEAqXrdiJvp+2j1kTJQ+pbGZxNxfKyLLNEzDH6QGSJ5hhQU0dexfU9i4HqIqCsxBfiZneHyk4DubPDZrfk74nt1yVoDg6GBwZX6Noa6Mc7xJkFxqUKo8z0lo8k0clh1sRtAiNsbaafY6zD8upIB6qTDiGKH2Tm2FCdRZI8c4Ok17F0wrnjlPCLg5Sp0Ae51oHs0u6+sYqueLjsSkJrobUqHNbokQjtmvdhA63XMrZHjxDAPoSquM2LLvM8xdM+oy0tbG8zyD9yFqdauHk5ZTAB1+FlBbsAT1/ZkglA23iqx7Y0+1bEaoLQUQWG2rJzpz8SQD493dX8gjepcdzU4ES1sQE2xlEmio6t3D3aJP6nwmt4gsDAAFRCWzr0ikICW3sE30LmYnfWgV5vpV9HIP82wehOBd7xM4V3cid4kmTYseUnlX1fr4GV7SONo6OkXOUv6/xqpcigrTXkyJfiThNudBQ3yoCbabF84NKBr97R7cU4jPIUEkCBn6lwmWEEx7Hqll+PFa9R5uO4vzP7eUWi0M3DAs8boMMVsET/MbZBnHOg9ewhDvzvkUMnYNeMLAlGKWKNelAFQDosXM6CtV9gCskVfHnwiw407dwUy8/+bY00DkNbc5Xa6CDvp6HapZJLFlpY0bR7VMLtCmgxOe7CDOnyKAf5GQVWU8798H5jf5JjIVY+2y/m7XqielGqon0iqM+gjMqg5R8EN4Isn++yLssjAXaF4xqLvD7Atz4CWXqV9bzsQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(366004)(346002)(396003)(136003)(451199015)(38070700005)(53546011)(31686004)(41300700001)(66946007)(66446008)(66556008)(76116006)(66476007)(6506007)(64756008)(4326008)(91956017)(8676002)(316002)(6916009)(2906002)(54906003)(86362001)(186003)(31696002)(26005)(83380400001)(478600001)(6486002)(6512007)(82960400001)(38100700002)(122000001)(8936002)(5660300002)(2616005)(36756003)(71200400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?aCsyd20zQ09jQXdOeCsrandUNVUwRFU4RGoxY1RVK1dZdzhIdkM4Vm9zNVdo?= =?utf-8?B?Y1lSOGI2bFBvTVpESGtvbjN5NW9yWW9vVXYzdFd0TUFuRVdGV1FBRUF4N3U4?= =?utf-8?B?amcrN2toelVqWnNVSW9peTcwYUIrdmZNV25TVWFhaXlDR3J5dGlQbXRTbjM0?= =?utf-8?B?U2lvQ1c5TjZpZHF0Qy9tdlpDNGpiZG0wS3c2Y3IxZXVsbmRYVmZaQlcrd29M?= =?utf-8?B?U1ZQSlNuM2lTUmoxN3AzOGpNb01JSXZkZ1lmeENpbGtCKzhXdnZJeW5XK2Rl?= =?utf-8?B?eVpnK25zQ3YwTWFSMlR3c3RvZlpISnZCd0Nyb1RCWk5YUi9qM1NiTUVRM1gw?= =?utf-8?B?RnNJSXVkamtuZGwrY0VRRXlCVU93ZTU1L0VyY2tGNkJOSG05Vk55TmsvNmJW?= =?utf-8?B?WjNXcGhseWhaWEFIeFRwUUhHZGpEWXVURFdPV0N6T1N2bnNkemdnWXhLZ2k4?= =?utf-8?B?MXo3a05SalJjRXpjcjhIOTJUSUFMQU5iMU1uWXB5WFlIeFVrdWFxc1NLOGVF?= =?utf-8?B?TUdOSTgvMW1PeXhaTDB4K3cyaUhZTE1IRHROR0lBM1VzWHhyNkpNczNYZjhY?= =?utf-8?B?djRqZXRHUHpWVU5rZUxNSnU4OTdrS0QvZkh0bkxDWTJub25vUlQvNnJGakt6?= =?utf-8?B?ZEJka0dnYnc4aDlUdlh6UTd0c29ReXo5bEpMM0dGeVE1NGdaQjh5c2NrY3Fx?= =?utf-8?B?ckdPQTRQcU5aWFkzbW8yTzVkNzNqSDJNb0dRaENXRHo3dmd0eEtjaUJUem43?= =?utf-8?B?cDNvSUlNODNIWWpMWi84Tlh3TnNWOGFLOVlTcmp0dXl1QWVhVTIrVkpMaGdY?= =?utf-8?B?QWptNDVUaHBFblVLUE1TTU5oMDdmeEZ0YjUwWEw1Yk9YQ1BFLzcwRC9waHhS?= =?utf-8?B?VlVIRTVIUlZtM1Zmak53dkRXcDhCVW4zUlZpWE9JR3dJcTJZNjhiUWx0Nk8y?= =?utf-8?B?VzloUVFDSFhLUzZzeUR6bjEwRXl2YmxJdEF1eDlJdnNleUlRd2kzbnFYOUFN?= =?utf-8?B?T3dieCttM1RjemVNU0xZcEZydTJycFp4UFZUZ3czVEREWEJSL1JVN0FSYnIx?= =?utf-8?B?YSs4SXFjMWZxTkQrMDhBeXBRclVlQlJpc1ZueHQyT0pNcW9uTk14WUNDTXdZ?= =?utf-8?B?cURoNVZGdHQvaTZvdTBoajc2SnpkZ1ZNQWlwYTB0VDFCRUpFRlVlYWJrNGc1?= =?utf-8?B?bnVJNWxMbEd4dmFHVXBVK0xyWkIzemhGa0FueHdCeU5JcGVuM0ZONGZtRUdC?= =?utf-8?B?NGdyWEtsK2hiK3E0dm40TzZKdjh1THJBRlpDd0c1Z24yRG9WS3RYdzZMdCsy?= =?utf-8?B?WnBEN0YrOFl2a3Aydk1OYjlUYUNLQXNUU0lOOVZRQlp5aGF6QmorRGNwZmNY?= =?utf-8?B?R0cxQ3VOZFFKQ3RnYmhDTlJMRFlkRVlRR1c1cGh2WElwaU1mWk5YVGF4cHpz?= =?utf-8?B?YTNEMitzbHVoa1YwSXhVWGNhaFZaTGZUT3BRNDhvbkVOTUo3QWJoQ0dJMTJk?= =?utf-8?B?NkVJcFFyM0ZaNHlFdHYzMnREaDAxRGZhZ29SVFBDWDU2V2tBQWJ0SjlpK0sz?= =?utf-8?B?aTVEaVVrck5jaFZsWllZUjVSU0w2dFVISmNZMmVJWWFRaFJoaTF0bkJjeU41?= =?utf-8?B?TWhyRVozMVZnbjBHeDBhTGRvOWpMdCtsUUdnMExDV0pkMGduMmpnL1lxeUJt?= =?utf-8?B?V3JVVmhKMTV0dDdzUmhKV0U5dkc2NjljVFdqVFVQTnhBNU9NT2FvaWQxNXIw?= =?utf-8?B?bHhTczBSblRFVjhuYXRnZGd4VWFQOHU5aUlnMGVmL0VqNzl1TEUrK3Rva0xS?= =?utf-8?B?eEFac3d4U2xZaGUzKzJtTXBDOXlmWW5JU3Q0VS9sV29RbVZPRzFjaHlET1J6?= =?utf-8?B?K3hHUTU0MDRDUjVyaHhFdWJlRTcrdWIxVnQvSVZhVVU5aWtjVHZwcFRycGxS?= =?utf-8?B?QUF5ZXNBK1ZEM1JOVVRaK01iYjdqckdLeXhkbWFVQ0dhLzlQajF5Z0FVN1lT?= =?utf-8?B?THFYQVdHUjNuUnF3bkYxbDFoZ1p4NllPOHJieERVNTdZUTJsR3ptWnZxZ0Zo?= =?utf-8?B?dGJVNXA4SE5rOEM1Tmx3dVFVUmZDalRxY1N3V1MzNjhhK0FVbS9pMlJVYU52?= =?utf-8?Q?It8kPRFIJfPqW90rrgbMNu64Y?= Content-Type: text/plain; charset="utf-8" Content-ID: <6AA8B9985F017B41AE18BC62411A0977@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: S3b/7Qz6Xw4UxshWtUYxuMWsS3DufwTYg29sgfxiA6aYJbYPqt2VVy12JCURjGThrPgWNZaUmCPaNJV8hk2iQSjj2oKPwF84fmmZtV4FaaKF/5vS6P9OgaEfs3Uo2gFtmLbF+f7ImWbX2JU1bIF0jEYcDjPKlCMU4rbJ8woy781wLTfAtiVbMBuqBpc82xtfbkTbHfONJPQJLuawbL5CYHo5IwAFaXweLyoGnozsFN6yI2D+0qjJ7MGHU469yMlriF+Th10s6+FPUbrjr18XIWcAOyycdQwmnMXaDcmxvAaSfXwl4YOJiKoaoTx2aL2K4ukMfXiwIQr1dwefCzRx4slw6ithlaa0tAvyZbeGG8dSKHur3tTu99+TTiCJtnjpV9pQNhayzYCOb4FzeWo6oEUN0kosB/hqZHzqm2N37+wfdGXRqgy6UfMdi2V3Th/GPMGzb3c9QUChwSH/eJFbfl5oJmLaXRFg9FG6kQ0bntROq33TjL5udV6LkM4XTbM05tFC7kN/+sluyBdLkt8rRJy2GuveYdh4+R5cV33bh82OmM14p8/AVbHzSgTamXdmSLxI7YJxWUrWrv1N4Emm6BwVtHyF04TRllOUr/9fDolnc64IELqpdQ1BovIcBS4ORRPdPE7OCyI2vVYnWTUfF/jpJs7HpC/vpYHHVPYoU4gpHAQeoMTjdGFFtw24cyKZrF96fO2egnMFylTzsl7Eko5DvL0LZApH6NW8DS/HFXeDVtxCFAFCxBVH3MnCAf6H8ASb1pgDlIl0TNEMyuyOCXefH1VT0pknUBgk01wPu5X+bU84IpQhT1smz8ev5raAIFjRnL3RTg2ay0CWqFCPAAxJNJTtliB42Zv7DMjRS7UM02kZ7zDxNZiZmW9UCwuw X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e2cc64c4-edbb-42ee-88e5-08daedf1a098 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jan 2023 01:18:46.3442 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: RT7KOKbm2v8+qj3Oy4Wt3bPQmuX4jweA1l5LpC+H4/RP2pjzzb1u7RcFqpI76wER/aPwXbk6+8I2R64s8gK4NSNs4u2ZzJ1ane3d23gLrCA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6000 T24gMDQvMDEvMjAyMyAxOjEwIGFtLCBTdGVmYW5vIFN0YWJlbGxpbmkgd3JvdGU6DQo+IE9uIEZy aSwgMzAgRGVjIDIwMjIsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBQcmVzZXJ2ZSB0aGUgYXJ0 ZWZhY3RzIGJhc2VkIG9uIHRoZSBgbWFrZWAgcnVuZSB3ZSBhY3R1YWxseSByYW4sIHJhdGhlciB0 aGFuDQo+PiBndWVzc3dvcmsgYWJvdXQgd2hpY2ggcnVuZSB3ZSB3b3VsZCBoYXZlIHJ1biBiYXNl ZCBvbiBvdGhlciBzZXR0aW5ncy4NCj4+DQo+PiBOb3RlIHRoYXQgdGhlIEFSTSBxZW11IHNtb2tl IHRlc3RzIGRlcGVuZCBvbiBmaW5kaW5nIGJpbmFyaWVzL3hlbiBldmVuIGZyb20NCj4+IGZ1bGwg YnVpbGRzLiAgQWxzbyB0aGF0IHRoZSBKZXNzaWUtMzIgY29udGFpbmVycyBidWlsZCB0b29scyBi dXQgbm90IFhlbi4NCj4+DQo+PiBUaGlzIG1lYW5zIHRoZSB4ODZfMzIgYnVpbGRzIG5vdyBzdG9y ZSByZWxldmFudCBhcnRlZmFjdHMuICBObyBjaGFuZ2UgaW4gb3RoZXINCj4+IGNvbmZpZ3VyYXRp b25zLg0KPj4NCj4+IFNpZ25lZC1vZmYtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIz QGNpdHJpeC5jb20+DQo+PiAtLS0NCj4+IENDOiBEb3VnIEdvbGRzdGVpbiA8Y2FyZG9lQGNhcmRv ZS5jb20+DQo+PiBDQzogU3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3Jn Pg0KPj4gQ0M6IEFudGhvbnkgUEVSQVJEIDxhbnRob255LnBlcmFyZEBjaXRyaXguY29tPg0KPj4g Q0M6IE1pY2hhbCBPcnplbCA8bWljaGFsLm9yemVsQGFtZC5jb20+DQo+PiBDQzogT2xla3NpaSBL dXJvY2hrbyA8b2xla3NpaS5rdXJvY2hrb0BnbWFpbC5jb20+DQo+PiAtLS0NCj4+ICBhdXRvbWF0 aW9uL3NjcmlwdHMvYnVpbGQgfCAyMiArKysrKysrKysrKysrKy0tLS0tLS0tDQo+PiAgMSBmaWxl IGNoYW5nZWQsIDE0IGluc2VydGlvbnMoKyksIDggZGVsZXRpb25zKC0pDQo+Pg0KPj4gZGlmZiAt LWdpdCBhL2F1dG9tYXRpb24vc2NyaXB0cy9idWlsZCBiL2F1dG9tYXRpb24vc2NyaXB0cy9idWls ZA0KPj4gaW5kZXggNWRhZmE3MmJhNTQwLi44ZGVlMWNiYmMyNTEgMTAwNzU1DQo+PiAtLS0gYS9h dXRvbWF0aW9uL3NjcmlwdHMvYnVpbGQNCj4+ICsrKyBiL2F1dG9tYXRpb24vc2NyaXB0cy9idWls ZA0KPj4gQEAgLTcwLDE4ICs3MCwyNCBAQCBpZiBbWyAiJHtDQ30iID09ICJnY2MiICYmIGBjYy12 ZXJgIC1sdCAweDA0MDYwMCBdXTsgdGhlbg0KPj4gICAgICBjZmdhcmdzKz0oIi0td2l0aC1zeXN0 ZW0tc2VhYmlvcz0vYmluL2ZhbHNlIikNCj4+ICBmaQ0KPj4gIA0KPj4gKyMgRGlyZWN0b3J5IGZv ciB0aGUgYXJ0ZWZhY3RzIHRvIGJlIGR1bXBlZCBpbnRvDQo+PiArbWtkaXIgYmluYXJpZXMNCj4+ ICsNCj4+ICBpZiBbWyAiJHtoeXBlcnZpc29yX29ubHl9IiA9PSAieSIgXV07IHRoZW4NCj4+ICsg ICAgIyBYZW4tb25seSBidWlsZA0KPj4gICAgICBtYWtlIC1qJChucHJvYykgeGVuDQo+PiArDQo+ PiArICAgICMgUHJlc2VydmUgYXJ0ZWZhY3RzDQo+PiArICAgIGNwIHhlbi94ZW4gYmluYXJpZXMv eGVuDQo+PiAgZWxzZQ0KPj4gKyAgICAjIEZ1bGwgYnVpbGQNCj4+ICAgICAgLi9jb25maWd1cmUg IiR7Y2ZnYXJnc1tAXX0iDQo+PiAgICAgIG1ha2UgLWokKG5wcm9jKSBkaXN0DQo+PiAtZmkNCj4+ ICANCj4+IC0jIEV4dHJhY3QgYXJ0aWZhY3RzIHRvIGF2b2lkIGdldHRpbmcgcmV3cml0dGVuIGJ5 IGN1c3RvbWlzZWQgYnVpbGRzDQo+PiAtbWtkaXIgYmluYXJpZXMNCj4+IC1pZiBbWyAiJHtYRU5f VEFSR0VUX0FSQ0h9IiAhPSAieDg2XzMyIiBdXTsgdGhlbg0KPj4gLSAgICBjcCB4ZW4veGVuIGJp bmFyaWVzL3hlbg0KPj4gLSAgICBpZiBbWyAiJHtoeXBlcnZpc29yX29ubHl9IiAhPSAieSIgXV07 IHRoZW4NCj4+IC0gICAgICAgIGNwIC1yIGRpc3QgYmluYXJpZXMvDQo+PiAtICAgIGZpDQo+PiAr ICAgICMgUHJlc2VydmUgYXJ0ZWZhY3RzDQo+PiArICAgICMgTm90ZTogU29tZSBzbW9rZSB0ZXN0 cyBkZXBlbmRpbmcgb24gZmluZGluZyBiaW5hcmllcy94ZW4gb24gYSBmdWxsIGJ1aWxkDQo+PiAr ICAgICMgZXZlbiB0aG91Z2ggZGlzdC8gY29udGFpbnMgZXZlcnl0aGluZywgd2hpbGUgc29tZSBj b250YWluZXJzIGRvbid0IGV2ZW4NCj4+ICsgICAgIyBidWlsZCBYZW4NCj4+ICsgICAgY3AgLXIg ZGlzdCBiaW5hcmllcy8NCj4+ICsgICAgaWYgW1sgLWYgeGVuL3hlbiBdXSA7IHRoZW4gY3AgeGVu L3hlbiBiaW5hcmllcy94ZW47IGZpDQo+IHdoeSB0aGUgImlmIiA/DQo+DQo+IFlvdSBjb3VsZCBq dXN0Og0KPg0KPiBjcCB4ZW4veGVuIGJpbmFyaWVzL3hlbg0KPg0KPiB1bmNvbmRpdGlvbmFsbHk/ DQoNCk5vIC0gdGhlIHNjcmlwdCBpcyBgc2V0IC1lYCBhbmQgeGVuL3hlbiBkb2Vzbid0IGV4aXN0 IGluIHRoZSBKZXNzaWUzMg0KY29udGFpbmVycy4NCg0KVGhhdCdzIHdoeSB0aGUgb2xkIGxvZ2lj IGhhZCBhbiAiaWYgbm90IHg4Nl8zMiIgZ3VhcmQgKGV4Y2VwdCBpdCBhbHNvDQpndWFyZGVkIHRo ZSByZWd1bGFyIGRpc3QgLT4gYmluYXJpZXMvIGNvcHkgd2hpY2ggaXMgcHJvYmxlbWF0aWMpLg0K DQpBdCBhIGd1ZXNzLCB0aGUgb3RoZXIgd29ya2luZyBvcHRpb24gd291bGQgYmUgYGNwIHhlbi94 ZW4gYmluYXJpZXMveGVuIHx8IDpgDQoNCkkgZG9uJ3QgbXVjaCBjYXJlIHdoaWNoIG9mIHRoZXNl IHR3byBnZXRzIHVzZWQsIGJ1dCBwcmV0dHkgbXVjaCBhbnl0aGluZw0KZWxzZSByZXN1bHRzIGlu IGEgZmFpbGVkIHRlc3QuDQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Wed Jan 04 01:21:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 01:21:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470850.730495 (Exim 4.92) (envelope-from ) id 1pCsSi-0006RR-Vr; Wed, 04 Jan 2023 01:21:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470850.730495; Wed, 04 Jan 2023 01:21:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCsSi-0006RK-R9; Wed, 04 Jan 2023 01:21:00 +0000 Received: by outflank-mailman (input) for mailman id 470850; Wed, 04 Jan 2023 01:20:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCsSh-0006RC-6v for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 01:20:59 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 09a78602-8bce-11ed-b8d0-410ff93cb8f0; Wed, 04 Jan 2023 02:20:56 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 96701614F9; Wed, 4 Jan 2023 01:20:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 15DC1C433D2; Wed, 4 Jan 2023 01:20:53 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 09a78602-8bce-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672795255; bh=1BW4Ls3PHmwwNSiG3AJmJkC7DqZ5ixj1dctuN6FJe6A=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=W2CTHzPLrV5O04ASlyt0KThzyjd9P8cwZF+/2X7KOfjTR0/rJbCAOh0Qo8D0oz6XM 00F2Rr0xUSCBEhGj32m4+mH6LELAW4USYcFNzoTn+29d3L+bDuGuOQT9THdRygFAxh tiO+SyVMTs1GLceBJhxlSEIjBsTs16ZJhUk2lpufB/DwGSllL73HcvEtqATXywUmiE yaOT5jkhbxsnvoox4uHcVgsA2HMc/IMp1EBtAp1xHtjwJzKVN1keWcE5TTN8Fe7wB3 BLWou4RAzthN7oUj7YySAHFDysvggg4g1pTu8bSBVkv8KXNIzXpWr6JkoDmXt8KUXF Ag6NDqNLoh8Bg== Date: Tue, 3 Jan 2023 17:20:51 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Andrew Cooper cc: Xen-devel , Doug Goldstein , Stefano Stabellini , Anthony PERARD , Michal Orzel , Oleksii Kurochko Subject: Re: [PATCH 5/6] CI: Fix build script when CROSS_COMPILE is in use In-Reply-To: <20221230003848.3241-6-andrew.cooper3@citrix.com> Message-ID: References: <20221230003848.3241-1-andrew.cooper3@citrix.com> <20221230003848.3241-6-andrew.cooper3@citrix.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 30 Dec 2022, Andrew Cooper wrote: > Some testcases use a cross compiler. Presently it's only arm32 and due to > previous cleanup the only thing which is now wrong is printing the compiler > version at the start of day. > > Construct $cc to match what `make` will eventually choose given CROSS_COMPILE, > taking care not to modify $CC. Use $cc throughout the rest of the script. > > Also correct the compiler detection logic. Plain "gcc" was wrong, and > "clang"* was a bodge highlighting the issue, but neither survive the > CROSS_COMPILE correction. Instead, construct cc_is_{gcc,clang} booleans like > we do elsewhere in the build system, by querying the --version text for gcc or > clang. > > While making this change, adjust cc_ver to be calculated once at the same time > as cc_is_* are calculated. > > Signed-off-by: Andrew Cooper Reviewed-by: Stefano Stabellini > --- > CC: Doug Goldstein > CC: Stefano Stabellini > CC: Anthony PERARD > CC: Michal Orzel > CC: Oleksii Kurochko > --- > automation/scripts/build | 22 ++++++++++++++-------- > 1 file changed, 14 insertions(+), 8 deletions(-) > > diff --git a/automation/scripts/build b/automation/scripts/build > index 4c6d1f3b70bc..206312ecc7d0 100755 > --- a/automation/scripts/build > +++ b/automation/scripts/build > @@ -2,13 +2,12 @@ > > test -f /etc/os-release && cat "$_" > > -$CC --version > +# Construct $cc such that it matches what `make` will chose when taking > +# CROSS_COMPILE into account. Do not modify $CC directly, as that will cause > +# `make` to double-account CROSS_COMPILE. > +cc="${CROSS_COMPILE}${CC}" > > -# Express the compiler version as an integer. e.g. GCC 4.9.2 => 0x040902 > -cc-ver() > -{ > - $CC -dumpversion | awk -F. '{ printf "0x%02x%02x%02x", $1, $2, $3 }' > -} > +$cc --version > > # random config or default config > if [[ "${RANDCONFIG}" == "y" ]]; then > @@ -50,7 +49,14 @@ else > cfgargs=() > cfgargs+=("--enable-docs") > > - if [[ "${CC}" == "clang"* ]]; then > + # booleans for which compiler is in use > + cc_is_gcc="$($cc --version | grep -q gcc && echo "y" || :)" > + cc_is_clang="$($cc --version | grep -q clang && echo "y" || :)" > + > + # The compiler version as an integer. e.g. GCC 4.9.2 => 0x040902 > + cc_ver="$($cc -dumpversion | awk -F. '{ printf "0x%02x%02x%02x", $1, $2, $3 }')" > + > + if [[ "${cc_is_clang}" == "y" ]]; then > # SeaBIOS cannot be built with clang > cfgargs+=("--with-system-seabios=/usr/share/seabios/bios.bin") > # iPXE cannot be built with clang > @@ -73,7 +79,7 @@ else > fi > > # SeaBIOS requires GCC 4.6 or later > - if [[ "${CC}" == "gcc" && `cc-ver` -lt 0x040600 ]]; then > + if [[ "${cc_is_gcc}" == "y" && "${cc_ver}" -lt 0x040600 ]]; then > cfgargs+=("--with-system-seabios=/bin/false") > fi > > -- > 2.11.0 > From xen-devel-bounces@lists.xenproject.org Wed Jan 04 01:22:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 01:22:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470857.730504 (Exim 4.92) (envelope-from ) id 1pCsTp-00070P-7i; Wed, 04 Jan 2023 01:22:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470857.730504; Wed, 04 Jan 2023 01:22:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCsTp-00070I-58; Wed, 04 Jan 2023 01:22:09 +0000 Received: by outflank-mailman (input) for mailman id 470857; Wed, 04 Jan 2023 01:22:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCsTn-00070C-QK for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 01:22:07 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 33c37a1e-8bce-11ed-91b6-6bf2151ebd3b; Wed, 04 Jan 2023 02:22:06 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id F3976B810FA; Wed, 4 Jan 2023 01:22:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B0014C433D2; Wed, 4 Jan 2023 01:22:03 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 33c37a1e-8bce-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672795324; bh=pTGI2ZexUZC1WRlRQKkwMJUAN5r/S/qdIbguBBS3LXs=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=WtXaF5/0GmUJHS6EKjC90BWZokfrZamzUxNu/v3g60FuOCYvEJQw7RGNgcsA6/L35 SVuTJ0CHTvouMLmBKsN6OoM65Y1ptNY6LIqjWYRjJJzffg8SvMEbYxpgP/TW8aBwfI uXXAMirDvkbdqX5vlXSQHTgNyXyjujSLLuKxhxd8dQ2XlnNYlTERQZ65ZG2wTTDuXW k11E2ohgi9Uhe92XySYG95EBzaQiYjy2diPOq6df+pqm74uAug05phXOaaY5WH3DnT MgT040kdLGrvA+X4xEadcNCoSIggZZxhYH+jT6PPRmHevmhN15vHx7g3oVCByqw9oL 16Tha2WuIhEGg== Date: Tue, 3 Jan 2023 17:22:01 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Andrew Cooper cc: Xen-devel , Doug Goldstein , Stefano Stabellini , Anthony PERARD , Michal Orzel , Oleksii Kurochko Subject: Re: [PATCH 6/6] CI: Simplify the MUSL check In-Reply-To: <20221230003848.3241-7-andrew.cooper3@citrix.com> Message-ID: References: <20221230003848.3241-1-andrew.cooper3@citrix.com> <20221230003848.3241-7-andrew.cooper3@citrix.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 30 Dec 2022, Andrew Cooper wrote: > There's no need to do ad-hoc string parsing. Use grep -q instead. > > No functional change. > > Signed-off-by: Andrew Cooper Reviewed-by: Stefano Stabellini > --- > CC: Doug Goldstein > CC: Stefano Stabellini > CC: Anthony PERARD > CC: Michal Orzel > CC: Oleksii Kurochko > --- > automation/scripts/build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/automation/scripts/build b/automation/scripts/build > index 206312ecc7d0..f2f5e55bc04f 100755 > --- a/automation/scripts/build > +++ b/automation/scripts/build > @@ -65,7 +65,7 @@ else > cfgargs+=("--disable-stubdom") > fi > > - if ! test -z "$(ldd /bin/ls|grep musl|head -1)"; then > + if ldd /bin/ls | grep -q musl; then > # disable --disable-werror for QEMUU when building with MUSL > cfgargs+=("--with-extra-qemuu-configure-args=\"--disable-werror\"") > # SeaBIOS doesn't build on MUSL systems > -- > 2.11.0 > From xen-devel-bounces@lists.xenproject.org Wed Jan 04 01:22:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 01:22:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470864.730516 (Exim 4.92) (envelope-from ) id 1pCsUc-0007aW-Ha; Wed, 04 Jan 2023 01:22:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470864.730516; Wed, 04 Jan 2023 01:22:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCsUc-0007aP-EQ; Wed, 04 Jan 2023 01:22:58 +0000 Received: by outflank-mailman (input) for mailman id 470864; Wed, 04 Jan 2023 01:22:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCsUb-0007UY-Mp for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 01:22:57 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5086befd-8bce-11ed-b8d0-410ff93cb8f0; Wed, 04 Jan 2023 02:22:55 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9EBAB61569; Wed, 4 Jan 2023 01:22:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2062BC433EF; Wed, 4 Jan 2023 01:22:53 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5086befd-8bce-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672795374; bh=HDAcCFD2XNQIAh7QQfIjgmW6fh/8SiYiGhMXClePVhk=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=UvzSMXNCLqUTxPTOn3i50WPUc3u+G1whb1nhBH/K+q6VDacFkxcUxjRaMyJtYjF5h bgUp80itAkGQFVlzPuq/slGzJ6ymuZq92HsDJi4T1AuosJ0GfVUX8zZKjVTmb56XOJ eBhb6CY82i55K3quh7kKfxCLW1+7W2ZJW/Bd6AyyIDTCrpG9e5v6V1Q5XO98gLbRfS 94vDqcem6UK3HrbmSEUgDB/ada8ipFIGnHz3afJg+SgCfPROc6wZUWlQnqZp6/l68R At0ps+ThlZ++SxrW2OFO4mQQqDCwFGs0s+RYUKtb3EpPSmb6lXM40YEaTSLapFlXlI Zb4V1k5plDTHQ== Date: Tue, 3 Jan 2023 17:22:51 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Andrew Cooper cc: Stefano Stabellini , Xen-devel , Doug Goldstein , Anthony Perard , Michal Orzel , Oleksii Kurochko Subject: Re: [PATCH 2/6] CI: Remove guesswork about which artefacts to preserve In-Reply-To: <71b7e387-8607-039b-6cb3-8555a1593361@citrix.com> Message-ID: References: <20221230003848.3241-1-andrew.cooper3@citrix.com> <20221230003848.3241-3-andrew.cooper3@citrix.com> <71b7e387-8607-039b-6cb3-8555a1593361@citrix.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 4 Jan 2023, Andrew Cooper wrote: > On 04/01/2023 1:10 am, Stefano Stabellini wrote: > > On Fri, 30 Dec 2022, Andrew Cooper wrote: > >> Preserve the artefacts based on the `make` rune we actually ran, rather than > >> guesswork about which rune we would have run based on other settings. > >> > >> Note that the ARM qemu smoke tests depend on finding binaries/xen even from > >> full builds. Also that the Jessie-32 containers build tools but not Xen. > >> > >> This means the x86_32 builds now store relevant artefacts. No change in other > >> configurations. > >> > >> Signed-off-by: Andrew Cooper > >> --- > >> CC: Doug Goldstein > >> CC: Stefano Stabellini > >> CC: Anthony PERARD > >> CC: Michal Orzel > >> CC: Oleksii Kurochko > >> --- > >> automation/scripts/build | 22 ++++++++++++++-------- > >> 1 file changed, 14 insertions(+), 8 deletions(-) > >> > >> diff --git a/automation/scripts/build b/automation/scripts/build > >> index 5dafa72ba540..8dee1cbbc251 100755 > >> --- a/automation/scripts/build > >> +++ b/automation/scripts/build > >> @@ -70,18 +70,24 @@ if [[ "${CC}" == "gcc" && `cc-ver` -lt 0x040600 ]]; then > >> cfgargs+=("--with-system-seabios=/bin/false") > >> fi > >> > >> +# Directory for the artefacts to be dumped into > >> +mkdir binaries > >> + > >> if [[ "${hypervisor_only}" == "y" ]]; then > >> + # Xen-only build > >> make -j$(nproc) xen > >> + > >> + # Preserve artefacts > >> + cp xen/xen binaries/xen > >> else > >> + # Full build > >> ./configure "${cfgargs[@]}" > >> make -j$(nproc) dist > >> -fi > >> > >> -# Extract artifacts to avoid getting rewritten by customised builds > >> -mkdir binaries > >> -if [[ "${XEN_TARGET_ARCH}" != "x86_32" ]]; then > >> - cp xen/xen binaries/xen > >> - if [[ "${hypervisor_only}" != "y" ]]; then > >> - cp -r dist binaries/ > >> - fi > >> + # Preserve artefacts > >> + # Note: Some smoke tests depending on finding binaries/xen on a full build > >> + # even though dist/ contains everything, while some containers don't even > >> + # build Xen > >> + cp -r dist binaries/ > >> + if [[ -f xen/xen ]] ; then cp xen/xen binaries/xen; fi > > why the "if" ? > > > > You could just: > > > > cp xen/xen binaries/xen > > > > unconditionally? > > No - the script is `set -e` and xen/xen doesn't exist in the Jessie32 > containers. > > That's why the old logic had an "if not x86_32" guard (except it also > guarded the regular dist -> binaries/ copy which is problematic). > > At a guess, the other working option would be `cp xen/xen binaries/xen || :` > > I don't much care which of these two gets used, but pretty much anything > else results in a failed test. I didn't realize that. I think your version is this patch is better, keep it as is From xen-devel-bounces@lists.xenproject.org Wed Jan 04 01:27:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 01:27:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470874.730527 (Exim 4.92) (envelope-from ) id 1pCsYo-0008MY-6C; Wed, 04 Jan 2023 01:27:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470874.730527; Wed, 04 Jan 2023 01:27:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCsYo-0008MR-3R; Wed, 04 Jan 2023 01:27:18 +0000 Received: by outflank-mailman (input) for mailman id 470874; Wed, 04 Jan 2023 01:27:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCsYm-0008ML-T5 for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 01:27:17 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ea2a94a8-8bce-11ed-91b6-6bf2151ebd3b; Wed, 04 Jan 2023 02:27:14 +0100 (CET) Received: from mail-dm6nam12lp2170.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.170]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 03 Jan 2023 20:27:11 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BN9PR03MB5962.namprd03.prod.outlook.com (2603:10b6:408:133::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Wed, 4 Jan 2023 01:27:08 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5944.019; Wed, 4 Jan 2023 01:27:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ea2a94a8-8bce-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1672795634; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=CsMEGptc43vLte0q02CVPOWS3aRKtCm8JX6gPknmLfM=; b=ULq994mPcGoo/JoMTeJk5yv0mBznXEgAiBtJbjE4fTfm3SgFaofftJPg s9USZV5T1bE8loB3RZkzkUlKAhT9402euZFuKtuIS8swDTEDT4eTVQ/5L wi/7eD+q0FhBq8ll/UebGrf6LBMWK+AQ2ifVVTPdpZwgwfMn0MEmJ0Ni5 Q=; X-IronPort-RemoteIP: 104.47.59.170 X-IronPort-MID: 91475861 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:rfnMHKp/nnagpfBlVQIOqt3YA8teBmL4ZBIvgKrLsJaIsI4StFCzt garIBmGPf2NN2DxeY1zPdnioBkB7J7cx4A1SQdl/yoyESND9JuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpAFc+E0/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06W1wUmAWP6gR5weHzyJNUfrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXACAcb0+8luXs+7iyTsJ8u+A4PuLgJrpK7xmMzRmBZRonabbqZvyQoPN9gnI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jemraYWNEjCJbZw9ckKwj 2TK5WnmRDodM8SS02Gt+XOwnO7f2yj8Xer+EZXpr6I13Q3NnwT/DjVLBFeRiOS4sXePWvx2I m491hoIrqktoRnDot7VGkfQTGS/lgUHR9NaHuk+6QeM4qnZ+QCUAi4DVDEpQMwrsoo6SCIn0 neNnsj1Hnp/vbuNU3Wf+7yI6zSoNkA9JmYYaSgJZQAM+dXkrcc4iRenZtNiG668ipvyAyP9x xiDqSR4jLIW5eYM06i45lHGxTGxvJ/CTg0yzgrSV2OhqAh+YeaYi5eA7FHa6bNMKdifR1zY5 nwcwZHBtKYJEI2HkzGLTKMVBra16v2ZMTrax1lyA50m8Dfr8HmmFWxN3AxDyI5SGp5sUVfUj IX74Gu9OLc70KOWUJJK IronPort-HdrOrdr: A9a23:JwGQCa/ozJNLz6UEVFtuk+AuI+orL9Y04lQ7vn2ZKSY5TiVXra CTdZUgpHnJYVMqMk3I9uruBEDtex3hHNtOkOss1NSZLW7bUQmTXeJfBOLZqlWNJ8S9zJ856U 4JScND4bbLfDxHZKjBgTVRE7wbsaa6GKLDv5ah85+6JzsaGp2J7G1Ce3am+lUdfng+OXKgfq Dsm/auoVCbCAwqR/X+PFYpdc7ZqebGkZr3CCR2eyLOuGG1/EiVAKeRKWnj4isj X-IronPort-AV: E=Sophos;i="5.96,297,1665460800"; d="scan'208";a="91475861" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j35cgxW88//7tu9zUnPYnw89O5WIBjTRF+Fw+9EjwbmzmERUsEI38jxJRsP+GkdbAKprYk4xkvc6YR93XpduvgkSgTCiV0BRn+JpZMri2CwcV6F8kD+3AZ/A/NQWXFwpn0JVnoryYFRpTfTz3yylz2jmclOhqS7zKMKTPF4w6S8IsEM5WUI9m/MeZNFpq/m+7UP5RWWS/UcOYVwf0N6JZLhwKRJ8Jymay+iix4Tv8JpXae717T9QkSxERlw7WPmnMUbtfKzsFumvFg4fOlaOvkbJSGc5+wYjmd0wenutgaWYzW1fBRAE3MulNuwJzTzoqONLJ7icDxs66yh1xM2Plg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CsMEGptc43vLte0q02CVPOWS3aRKtCm8JX6gPknmLfM=; b=d4NcYJ1Hx+x+MPF00zboJ5BT6tR6jSa7iwWa59ImHY9QS9aYOQl1Up0vg+TMWrkcztfI+TGSoCYRLgJ8k/huVUxzM36yOivM4dCpvMzJFQu32zzvjdUnZrL7ogDpCVK+VAhvEDrbpqHLJexJJRJvJqWBl0MwUxqDrkdQZvbUSq0fhcy0YQVS/rBiEj1CT/CvrbVVtr9r88pi37InZFV++M0q73YUI871TcxI/OnLn95F5kxKkhXdkaDzyn92vuwDJIOSBfLMEqzF13Gz6EqA9jUQc+cSozYReDbAqAa4EYrxLvbt0rUUOj0Co/Gd3K6lfekWZYXW89zYxavQWcb03A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CsMEGptc43vLte0q02CVPOWS3aRKtCm8JX6gPknmLfM=; b=onQPY8K/ozqeQXc66qN0SQj7Ii8pGb8flLN+s+mlIsBHvWyHhM9KifUdbKWJ5XJIY4tIy+c7+XnaRX0wW7HY6b+ATd8FJ3EgTQRxux0x9FJCG7C0BY9UdBGbsVIwAfcBZuQm9VFTPDo2Tjm2HUOt51kYm4DGtLOlXBXpaSUAOwk= From: Andrew Cooper To: Stefano Stabellini CC: Xen-devel , Doug Goldstein , Anthony Perard , Michal Orzel , Oleksii Kurochko Subject: Re: [PATCH 4/6] CI: Express HYPERVISOR_ONLY in build.yml Thread-Topic: [PATCH 4/6] CI: Express HYPERVISOR_ONLY in build.yml Thread-Index: AQHZG+cbFLjU6ViRqEqaO8BfTNldnq6NfEWAgAADPYA= Date: Wed, 4 Jan 2023 01:27:07 +0000 Message-ID: <34e692e3-ef76-a43e-ec4f-a7c1ed2d094f@citrix.com> References: <20221230003848.3241-1-andrew.cooper3@citrix.com> <20221230003848.3241-5-andrew.cooper3@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|BN9PR03MB5962:EE_ x-ms-office365-filtering-correlation-id: 187c1aab-702c-45e3-5da9-08daedf2cb87 x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /v4ND3ZQbgdjQX3BW9gyCmC0r1dhlP6o4NuZv1D11joi0BQ39rfHWjLHLIr017DmFtTWRXArxfki8BM8dBceS1LLcYxwIqii7W7L5g8reqmzkYAhg4za3lx5x7PHJabdYREoIbfCgv3o9uzE9K/c1jP0c8hI++zgKN8SIB038bH8WsXvTa2Nw28HDd+efVZYJukVXkM211KyotLMPOvt+mDPjHSKDqXNyvKFL65wl6cJapRuySXCHUBKzlIaFcyeIqFtgNtr7GkOvZWjblKH+iglYc9+qS0d2EIM2o1NgqNsKSdGew0pzZ5unfRlooJvfTGBXORweDsajpVfXfZJo+d2/Yym5DicEc4ORgiCZDTgJsoVJWxMi4KHoNRwKhXlFzAfNj/5nilHnI7bZ5iYnpCEnalLKocbsVTYM1FfdCYDh8yRgNHUEmxVlYXHCZ9f+z1HGX2d6sxC3HyxCMr1WPQveNVMKHTpOEgBt7UIHSmjQrhYbwZwe1lenjRlEKVe+9p68739i7Dv+/mI60chloRSuJpHk7oa8sdTYMIFx7qWlhHKWG55oQpVwZ6QGOMJR/lVaXae0rbWOe+P6tsnDkZPZjAkIdtf6ulwgPKnmW+7xRs0HrR3XKsztNovsPVW4T7yU4cbXoUKPztN63gMMSF3tcvJaapU0izkXfcrHNfoK2MYlQkRtNcttLT7+fo1wuRtYdHT8wqZcGiKdjfkFA6e7bKHH1DK3JO88QtDEBC7iEKeooCcrQ0mhNWhzZBKVCGh9D6XhblR01wDyxPuBQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(366004)(136003)(376002)(39860400002)(396003)(451199015)(83380400001)(186003)(6512007)(26005)(6506007)(31696002)(38070700005)(86362001)(36756003)(82960400001)(122000001)(38100700002)(53546011)(2616005)(8676002)(4326008)(31686004)(41300700001)(8936002)(2906002)(5660300002)(6486002)(71200400001)(478600001)(66946007)(66476007)(6916009)(76116006)(316002)(91956017)(54906003)(66556008)(64756008)(66446008)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?WmE5ZmV0S2JUZFNUd2JQV1I1QnlvMS8xdnZlZ2FtVDdjM0MrUmRvUHpyUWVL?= =?utf-8?B?TEVRQ1BaWDYwaUU2cnNtVlRxWmtJYXQ1SklwSjN1bEZ5MlJvWVFCU3NLY25D?= =?utf-8?B?Yk8wd0ovc2tobTh3L0U1alpyaEUzOHZwL2dQc0IvNVBpbVQyakdIcFMwM0FG?= =?utf-8?B?UFNqdzRjSVdnVjJ5UlhNV2M3ekFRckJSV3cxejZzandzQ0RLeHBadzBFNmlo?= =?utf-8?B?S2FUemxkN0swdmZmekFaVkEvOHNKWUlFKzkzTXlLK1k0RWd6dEdyb2lrcER0?= =?utf-8?B?bytWejVwdE5rWkNtYUFJTFR3SkJGRXMzRktKOW9ycUw2RFU4aEtZSEh3Zmhk?= =?utf-8?B?SDkzVjYyWDZzcmxraUVXdmU2T2FlZEVRR05YL1B6UHVpSy80bmowdTc1MU5Z?= =?utf-8?B?S0pQL1VtVUxCNThIdk02VDNhc01aZy8vQzczb1N2aXFQV0NhQlk5eUJvWndn?= =?utf-8?B?Yy8zK1NLaVhGU01DNGd4R2xhV2RLR2pxWEZRaTV6VlNqcHdsMjl3YWd0aFc4?= =?utf-8?B?bnY1LzNaWDN1ZEZQK2JWSnNUSlJkaGtMdGtDMHFhNGFpUnpGYU4wSXk0M3Fi?= =?utf-8?B?V2FwYjV4UXB1U1Bnclo5Z2FkKytnVCt3U0hPckFROG10WnRKdE9jVmlVU3NG?= =?utf-8?B?TnlZS0xXd1JZVFNFNVo3bUR3M0lLRkVMZ2ZTWW5pQXNIaG1PU0ZYcmVhd2dq?= =?utf-8?B?WllBRzRpd2x5ZkJBbEcvb1lGSUVaZ2dWRVVPUUVIR25ibmVmazQvNWFPbzVz?= =?utf-8?B?OS9QeE43NUEvL1pKalJzZ0FtTFdFOStubEpsdG5QbUI0Qkg1M3VnWDNuN0F1?= =?utf-8?B?YWp4eDVxU1AyUXNoUXdLY1RRb0VtenlvUUZ3YUNjTkNQb2lacWhtbW9OdlBH?= =?utf-8?B?cGIxVE5rYlFYTmRtc3NkcUJuQjF3eGJhZWc0cmI1d0x1bkZjZHZ2VVhSUGZ0?= =?utf-8?B?NmduRHcrTVcvdDdxZG1lTG0xdXoxYkRlSzRsQzc0VXZGeHU0NjVCalo3Wk1k?= =?utf-8?B?ejBCYU9LMXFZSlFDNmUvME1xaXFLZk1yZ2R6TENTcmZCL3llbjU0N2dHY3dU?= =?utf-8?B?WnF5dW51c21TbUhvb1pXSzRmbEh4WDVocEdKdUhXMXJGUFQwOXhFM2F2d3pU?= =?utf-8?B?WDZWdlhEeEN0U2xPRkZld20vQ0lBNHh5MDREcmFycEtqenY1Um5MTndNNzRT?= =?utf-8?B?eXpVTGxRZUhoTkFMSkkvd1VCUnM3NFViWDZWZUZxU3BacXYxTnNtWG5Hand2?= =?utf-8?B?YzZxRVVXMy9BTkJ2d2ZWSlZVWkx5MzY2WXA1a01Sc04wb3RhUnFqN3JJOWZm?= =?utf-8?B?d3F4R2JaMFRKLzZXUEJ6TDZrcjgxckV4allsTWlGS2t6RGtsVjFEdnVobUFK?= =?utf-8?B?eVpXTTNuSEhnQ1FjbW1ySUhjMjgrY3hwNjNSaXgvTHVNU3c5UEQ2cXFoRCtj?= =?utf-8?B?ejY1QWJCODVPUllyQkh6S290Sjgwckdpdlk3R25uek52RG1SWmIyZWducnd0?= =?utf-8?B?NytzM1h3MVVlejI2a0h2UzdpZDEwN1hod2xkMGNOSUNQSzUySXRTcndlamp4?= =?utf-8?B?WkJRTXZxRzNsOXRZdDJZd2Nxc1dyUnJMcDJCa1hGTWQrTW1Xam1sOTFxNkRW?= =?utf-8?B?M1hGTzMxVDhSelVkZTB2MWJBbU9pZXc1K1ZJeHh4YlprMnBhNFpKZGQydTQw?= =?utf-8?B?dmJ4N3ZpVmhXcDJyY3diRXJKWlYwTmdhSnpLUk0xaTEvZEN6Y2trUXBmMlkx?= =?utf-8?B?Qng3L1FnVDRaa2F6bFY5eGZ3L1Exck5yQ0ZRenY2V2FYZGpNS2lNejJkM1Rp?= =?utf-8?B?ak9xV2NKYmpaQXVMdTNnWTNOaXRqalVRZTBtRjlhWUFnSFJTMVBuOE9FTVBr?= =?utf-8?B?S0w4MWNIdDZFeFFzUE1nelU3QjVyQm1RNTc1bGJoS2ovZ1pPa1pWcy9IeVZE?= =?utf-8?B?YWM2N0Q0M01OZ2tGQ0JieldEcjB6azBwWFlpYm1YcGx0M2lPWTNJZmE3SWZC?= =?utf-8?B?RjJPcGoyd1plOWY5SkJvWExieFZ6eWVrZWNKSkM3cjkwUlFsWWc3aXlZdHBW?= =?utf-8?B?dWNhSTJmTFJwdDhaWWpYY0NXVUFKb3hIQkN5TWJsdkMrT05nREVEVG9YUys3?= =?utf-8?Q?ip+fuQahUav9n8no+MkUc500L?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: IIekUxq1ooG+5M7hXDklfTQgvJ+UziZomfAdvKzZE/9G0G5KEWYexsMtD2EailrNlQn1maFh4uMjsPoM326GS7EW1Mnk/14yrZErVd45G2wJHUG55FnkUexHooJNAbUxVyilykU06gsDJmsQLKQ8e/hPqXKnpuOUumoSImTYgxiWgEtntjWxUn1ev6O9+gwF5+ivXiVfs0uAxzdBOGi4EFulYVMakOFepg6X1f/duog7FnM2OnjlBffJzbQlSg1Scd5DSoD3nA8+z0p58pCWrB42z4RHjpZM/PuHrHOfxwIngvEwP6wY1oAnZDR1owL+Dve9NTSLtsm2Q2VCK54Iqmc7lg5pfJnHw/NLMZ+NTLd/GL+W4/GpNG+A7G/o79qOYOuOy6KxBkD/GfOyue6BWANrSS/LBcOjHL0oW7A05EeOSUGiTlOI6LNhlFC97Zad/E5sQG8pwwI/OnhVBJdN9rPUWknH4eopHt3eB2beXNZV9XymqJO7n8Ak+033rA1TzJh3ms1cyFReujEGcqqSn0fuVqbJYqfHsjSC2S2fzLVaNMrILubHLxvLw+eqdvBj55UA1mdbU6KCR9bZePzTWI9LKna0sWHiTy5EcbO6+3fUZdI0N3JB8nXTvWQ9BV0UJHyA7Y00hK6Jci1UAdT2k3SrgXz3d87qsdBlvV3pdRgxt7RV5EF6Bqw8yeBNghIbn6HGtZoWHRjboteHcOnCHIDu/ww0lMpiT55FG5zQ/DRDyfeY68U7mqTVyFyZ8KhdhqH26BijtPEKLO/pAjQ84bXQ6w2H2nwo6FIvBDbiO3EsbGqJwjPtTmI5UW37BMhYY1T5xJJ3PUrt7qFjzrtYVEGBZ1Ci1Ab0eQbtiqNh5TRahIHHZQEydVThzWB9XPFy X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 187c1aab-702c-45e3-5da9-08daedf2cb87 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jan 2023 01:27:07.8548 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: B3hwhehOI8jCBlHR4FRgSmRUVvI207TFmAWlbmMtYzO2JnGX7sAElbh7l4ZZLZFur0fhgnyR4JT/vQ/Bkde6SvCuh8GNlI93kLkVC44gHFc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB5962 T24gMDQvMDEvMjAyMyAxOjE1IGFtLCBTdGVmYW5vIFN0YWJlbGxpbmkgd3JvdGU6DQo+IE9uIEZy aSwgMzAgRGVjIDIwMjIsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+DQo+PiBXaGV0aGVyIHRvIGJ1 aWxkIG9ubHkgWGVuLCBvciBldmVyeXRoaW5nLCBpcyBhIHByb3BlcnR5IG9mIGNvbnRhaW5lciwN Cj4+IHRvb2xjaGFpbiBhbmQvb3IgdGVzdGNhc2UuICBJdCBpcyBub3QgYSBwcm9wZXJ0eSBvZiBY RU5fVEFSR0VUX0FSQ0guDQo+Pg0KPj4gQ2FwaXRhbGlzZSBIWVBFUlZJU09SX09OTFkgYW5kIGhh dmUgaXQgc2V0IGJ5IHRoZSBkZWJpYW4tdW5zdGFibGUtZ2NjLWFybTMyLSoNCj4+IHRlc3RjYXNl cyBhdCB0aGUgcG9pbnQgdGhhdCBhcm0zMiBnZXQgbWF0Y2hlZCB3aXRoIGEgY29udGFpbmVyIHRo YXQgY2FuIG9ubHkNCj4+IGJ1aWxkIFhlbi4NCj4+DQo+PiBGb3Igc2ltcGxpY2l0eSwgcmV0YWlu IHRoZSBSQU5EQ09ORklHIC0+IEhZUEVSVklTT1JfT05MWSBpbXBsaWNhdGlvbi4NCj4+DQo+PiBT aWduZWQtb2ZmLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPg0K Pj4gLS0tDQo+PiBDQzogRG91ZyBHb2xkc3RlaW4gPGNhcmRvZUBjYXJkb2UuY29tPg0KPj4gQ0M6 IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz4NCj4+IENDOiBBbnRo b255IFBFUkFSRCA8YW50aG9ueS5wZXJhcmRAY2l0cml4LmNvbT4NCj4+IENDOiBNaWNoYWwgT3J6 ZWwgPG1pY2hhbC5vcnplbEBhbWQuY29tPg0KPj4gQ0M6IE9sZWtzaWkgS3Vyb2Noa28gPG9sZWtz aWkua3Vyb2Noa29AZ21haWwuY29tPg0KPj4gLS0tDQo+PiAgYXV0b21hdGlvbi9naXRsYWItY2kv YnVpbGQueWFtbCB8ICAyICsrDQo+PiAgYXV0b21hdGlvbi9zY3JpcHRzL2J1aWxkICAgICAgICB8 IDExICsrKystLS0tLS0tDQo+PiAgMiBmaWxlcyBjaGFuZ2VkLCA2IGluc2VydGlvbnMoKyksIDcg ZGVsZXRpb25zKC0pDQo+Pg0KPj4gZGlmZiAtLWdpdCBhL2F1dG9tYXRpb24vZ2l0bGFiLWNpL2J1 aWxkLnlhbWwgYi9hdXRvbWF0aW9uL2dpdGxhYi1jaS9idWlsZC55YW1sDQo+PiBpbmRleCA5M2Q5 ZmY2OWE5ZjIuLmU2YTkzNTdkZTNlZiAxMDA2NDQNCj4+IC0tLSBhL2F1dG9tYXRpb24vZ2l0bGFi LWNpL2J1aWxkLnlhbWwNCj4+ICsrKyBiL2F1dG9tYXRpb24vZ2l0bGFiLWNpL2J1aWxkLnlhbWwN Cj4+IEBAIC01MTYsMTEgKzUxNiwxMyBAQCBkZWJpYW4tdW5zdGFibGUtZ2NjLWFybTMyOg0KPj4g ICAgZXh0ZW5kczogLmdjYy1hcm0zMi1jcm9zcy1idWlsZA0KPj4gICAgdmFyaWFibGVzOg0KPj4g ICAgICBDT05UQUlORVI6IGRlYmlhbjp1bnN0YWJsZS1hcm0zMi1nY2MNCj4+ICsgICAgSFlQRVJW SVNPUl9PTkxZOiB5DQo+PiAgDQo+PiAgZGViaWFuLXVuc3RhYmxlLWdjYy1hcm0zMi1kZWJ1ZzoN Cj4+ICAgIGV4dGVuZHM6IC5nY2MtYXJtMzItY3Jvc3MtYnVpbGQtZGVidWcNCj4+ICAgIHZhcmlh YmxlczoNCj4+ICAgICAgQ09OVEFJTkVSOiBkZWJpYW46dW5zdGFibGUtYXJtMzItZ2NjDQo+PiAr ICAgIEhZUEVSVklTT1JfT05MWTogeQ0KPiBjYW4geW91IG1vdmUgdGhlIHNldHRpbmcgb2YgSFlQ RVJWSVNPUl9PTkxZIHRvIC5hcm0zMi1jcm9zcy1idWlsZC10bXBsID8NCg0KTm90IHJlYWxseSAt IHRoYXQncyB0aGUgcG9pbnQgSSdtIHRyeWluZyB0byBtYWtlIGluIHRoZSBjb21taXQgbWVzc2Fn ZS4NCg0KPiBJIHRoaW5rIHRoYXQgbWFrZXMgdGhlIG1vc3Qgc2Vuc2UgYmVjYXVzZSAuYXJtMzIt Y3Jvc3MtYnVpbGQtdG1wbCBpcyB0aGUNCj4gb25lIHNldHRpbmcgWEVOX1RBUkdFVF9BUkNIIGFu ZCBhbHNvIHRoZSB4ODZfNjQgdGFnLg0KDQpJdCdzIG5vdCBhYm91dCB4ODZfNjQ7IGl0cyBhYm91 dCB0aGUgY29udGFpbmVyLg0KDQpXaGV0aGVyIHdlIGNhbiBidWlsZCBqdXN0IFhlbiwgb3IgZXZl cnl0aGluZywgc29sZWx5IGRlcGVuZHMgb24gdGhlDQpjb250ZW50cyBpbiBkZWJpYW46dW5zdGFi bGUtYXJtMzItZ2NjDQoNCklmIHdlIHdhbnRlZCB0bywgd2UgY291bGQgdXBkYXRlIHVuc3RhYmxl LWFybTMyLWdjYydzIGRvY2tlcmZpbGUgdG8NCmluc3RhbGwgdGhlIGFybTMyIGNyb3NzIHVzZXIg bGlicywgYW5kIGRyb3AgdGhpcyBIWVBFUlZJU09SX09OTFkNCnJlc3RyaWN0aW9uLg0KDQp+QW5k cmV3DQo= From xen-devel-bounces@lists.xenproject.org Wed Jan 04 01:36:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 01:36:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470882.730539 (Exim 4.92) (envelope-from ) id 1pCshh-0001So-5r; Wed, 04 Jan 2023 01:36:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470882.730539; Wed, 04 Jan 2023 01:36:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCshg-0001Sg-V4; Wed, 04 Jan 2023 01:36:28 +0000 Received: by outflank-mailman (input) for mailman id 470882; Wed, 04 Jan 2023 01:36:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCshf-0001Sa-Sw for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 01:36:27 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 326c050d-8bd0-11ed-b8d0-410ff93cb8f0; Wed, 04 Jan 2023 02:36:24 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 984716157D; Wed, 4 Jan 2023 01:36:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C409C433F1; Wed, 4 Jan 2023 01:36:22 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 326c050d-8bd0-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672796183; bh=GQAamOljZd55tkVcWUsHddK5hYE0gMhCzFuyOd9DZd4=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=aIhtNsQ2iVKyJPgCqVS3G3Zz/1hW7XTt4tju1nwRPASAw13zF8OUqvrAJ3ih6B+Jw oQ2Cg1ODHS7pXBYl3eeK3G/FWwLkX5CFLl17s2/si/tYwbif1GjCeuynMPYIKy16MW jTTp1oRXuJQ407tjj3fmcIkBy7HbWWE6+TqXg08WWEmatXmtGUNHqfszNl9o4/bWI1 5zSRUprnfwkG3NBdXc9Q2wrkYanjl5b87r2lDNJbV4aOXDABRt4hdGlqPcIWIuD1tv OkOJlWnNhE5WQzZ15ikTzw7qtEWl1WJMCyjdFUbSliupWQ4m4Vh+00qj1iP1MzwVtA V7mNArNzZnBlw== Date: Tue, 3 Jan 2023 17:36:21 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Andrew Cooper cc: Stefano Stabellini , Xen-devel , Doug Goldstein , Anthony Perard , Michal Orzel , Oleksii Kurochko Subject: Re: [PATCH 4/6] CI: Express HYPERVISOR_ONLY in build.yml In-Reply-To: <34e692e3-ef76-a43e-ec4f-a7c1ed2d094f@citrix.com> Message-ID: References: <20221230003848.3241-1-andrew.cooper3@citrix.com> <20221230003848.3241-5-andrew.cooper3@citrix.com> <34e692e3-ef76-a43e-ec4f-a7c1ed2d094f@citrix.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 4 Jan 2023, Andrew Cooper wrote: > On 04/01/2023 1:15 am, Stefano Stabellini wrote: > > On Fri, 30 Dec 2022, Andrew Cooper wrote: > > > >> Whether to build only Xen, or everything, is a property of container, > >> toolchain and/or testcase. It is not a property of XEN_TARGET_ARCH. > >> > >> Capitalise HYPERVISOR_ONLY and have it set by the debian-unstable-gcc-arm32-* > >> testcases at the point that arm32 get matched with a container that can only > >> build Xen. > >> > >> For simplicity, retain the RANDCONFIG -> HYPERVISOR_ONLY implication. > >> > >> Signed-off-by: Andrew Cooper > >> --- > >> CC: Doug Goldstein > >> CC: Stefano Stabellini > >> CC: Anthony PERARD > >> CC: Michal Orzel > >> CC: Oleksii Kurochko > >> --- > >> automation/gitlab-ci/build.yaml | 2 ++ > >> automation/scripts/build | 11 ++++------- > >> 2 files changed, 6 insertions(+), 7 deletions(-) > >> > >> diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml > >> index 93d9ff69a9f2..e6a9357de3ef 100644 > >> --- a/automation/gitlab-ci/build.yaml > >> +++ b/automation/gitlab-ci/build.yaml > >> @@ -516,11 +516,13 @@ debian-unstable-gcc-arm32: > >> extends: .gcc-arm32-cross-build > >> variables: > >> CONTAINER: debian:unstable-arm32-gcc > >> + HYPERVISOR_ONLY: y > >> > >> debian-unstable-gcc-arm32-debug: > >> extends: .gcc-arm32-cross-build-debug > >> variables: > >> CONTAINER: debian:unstable-arm32-gcc > >> + HYPERVISOR_ONLY: y > > can you move the setting of HYPERVISOR_ONLY to .arm32-cross-build-tmpl ? > > Not really - that's the point I'm trying to make in the commit message. > > > I think that makes the most sense because .arm32-cross-build-tmpl is the > > one setting XEN_TARGET_ARCH and also the x86_64 tag. > > It's not about x86_64; its about the container. > > Whether we can build just Xen, or everything, solely depends on the > contents in debian:unstable-arm32-gcc > > If we wanted to, we could update unstable-arm32-gcc's dockerfile to > install the arm32 cross user libs, and drop this HYPERVISOR_ONLY > restriction. If it is a property of the container, shouldn't HYPERVISOR_ONLY be set every time the debian:unstable-arm32-gcc container is used? Including debian-unstable-gcc-arm32-randconfig and debian-unstable-gcc-arm32-debug-randconfig? I realize that the other 2 jobs are randconfigs so HYPERVISOR_ONLY gets set anyway. But if HYPERVISOR_ONLY is a property of the specific container, then I think it would be best to be consistent and set HYPERVISOR_ONLY everywhere debian:unstable-arm32-gcc is used. E.g. one day we could just randconfigs to build also the tools with a simple change to the build script and otherwise we would need to remember to also add the HYPERVISOR_ONLY tag for the other 2 jobs using debian:unstable-arm32-gcc. From xen-devel-bounces@lists.xenproject.org Wed Jan 04 01:42:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 01:42:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470889.730549 (Exim 4.92) (envelope-from ) id 1pCsnE-0002sQ-MB; Wed, 04 Jan 2023 01:42:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470889.730549; Wed, 04 Jan 2023 01:42:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCsnE-0002sJ-JW; Wed, 04 Jan 2023 01:42:12 +0000 Received: by outflank-mailman (input) for mailman id 470889; Wed, 04 Jan 2023 01:42:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCsnC-0002sD-L1 for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 01:42:10 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fd129cfc-8bd0-11ed-b8d0-410ff93cb8f0; Wed, 04 Jan 2023 02:42:05 +0100 (CET) Received: from mail-dm6nam12lp2169.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 03 Jan 2023 20:41:59 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by MN2PR03MB5022.namprd03.prod.outlook.com (2603:10b6:208:1ab::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Wed, 4 Jan 2023 01:41:57 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5944.019; Wed, 4 Jan 2023 01:41:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fd129cfc-8bd0-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1672796526; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=4zdzJlG75cMPxlVOfMNmGrXGm/DiNSso512V2M2wsXg=; b=UGUrTio43wf+7qzzCR0k+j1JxcG7Ce5aRvBObCdbaPs5o4MnkbZ9kzC0 DmKaoizzlbThZRSJjLxCF6VLNAlch50P/8weVhEUupAFvLZtuHeOu8aXh bwmolQYOjIvpdF3iADbEvMt58TCMieQXhKwDpNfxiQz8Kip+fgii8X2zY E=; X-IronPort-RemoteIP: 104.47.59.169 X-IronPort-MID: 90010168 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:D5rKf6skDRdWy6jlb1VcBm2FmefnVLZfMUV32f8akzHdYApBsoF/q tZmKTiEMvjZNDD1LYsgPInloBgEuJ/SmN9jSAo6qCoxQy5B+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg0HVU/IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj5lv0gnRkPaoQ5AaGzCFIZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwLS0rPyumoN2P6Y2HU65dh8ADMtLnM9ZK0p1g5Wmx4fcOZ7nmGv+PyfoGmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osgf60bou9lt+iHK25mm6xo G7c8nu/KRYdLNGFkhKO8262h/+JliT+MG4XPOzgrqcy2QPDroAVIEUuBUKinfSDs3W3HO1cF E4up3M2sZFnoSRHSfG4BXVUukWspQUAUtBdF+k77gClyafO5QudQG8eQVZpeNEg8cM7WzEu/ luIhM/yQyxitqWPTnCQ/avSqim9UQAeJHUOYiIsRgIf797u5oo0i3rnS9doEKexyNrvCzz06 zmPoG41gLB7pckP2qag/FGBgC+2oZPJTQkd6QDeX2bj5QR8DLNJfKSt4FnfqPpFcoCQSwDbu GBewpbPqucTEZuKiSqBBv0XG62k7OqENzuahkNzG54m9HKm/HvLkZ1s3QyS7XxBaq4sEQIFq meK0e+NzPe/5EeXUJI= IronPort-HdrOrdr: A9a23:cvHzUKvYz8TGFkid6uE8edbF7skDstV00zEX/kB9WHVpm6yj+v xG/c5rsCMc7Qx6ZJhOo7+90cW7L080lqQFg7X5X43DYOCOggLBQL2KhbGI/9SKIVycygcy78 Zdm6gVMqyLMbB55/yKnTVRxbwbsaW6GKPDv5ag8590JzsaD52Jd21Ce36m+ksdfnggObMJUK Cyy+BgvDSadXEefq2AdwI4t7iqnaysqHr+CyR2fiIa1A== X-IronPort-AV: E=Sophos;i="5.96,297,1665460800"; d="scan'208";a="90010168" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NxsKbGibreGMl0Ag8UXh0EX3w+AkOqpvaEQ/KOWKsT8018MfPT+3W8kA2QVEBWkBcewcTIaw8HR55bvCZZL6BOFgwjgb1KnA6Rq8t/rbKiu85ykbTZmpLCPJ12CNsc4lWtytKtqdf34Lc92TJo1Y14u4OhLTh45p7kl8hGc+mfpfykElvxm0YqRA7SaAaGULjZqEDk7G6wSBDnApOWZrhSHtfxAzTZzv0/bqdTOa4HdKlhziOIVTz3TXiKAh8/MMyOi5QbjjA4taxtSew3tzDdjsa+MpZzpTBrHx4RBM4nnSkbeXj3xY6zDRcFYNbIe9mzf63oMc0M5R5vyM4EE0mA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4zdzJlG75cMPxlVOfMNmGrXGm/DiNSso512V2M2wsXg=; b=XzmKaQ0Jhr9jx3/ix0AtrFdlk4WMnilSe5xWjzR3y9kaw71+TQCDtUaKRORUz88qf7dyEmDPzQdcUT+2pZIlHybEmYBzCTjEIyT2hz1iWa/DqdgVrnI80Fn2mDxkTSIx8FAVOQIvl1yP6yrHl8NlSIEB1aNvUqwC5IyG+5ULrAyYTfMJ+aSaDZp26Ve37F8xDIGtZiUaTftbw8k5tfs+eZSOqxNo3NzUVsIN7yKW2l7LD0LO76mtBJ011APaj/xmXPTbjndD5Qu3QIuoidt/SBJoFSGoWgZ0TAVRt9zZsZNgavbh+k4PHq1SI3RW5DXW9uPjEGF6QMQ7ZLU2vYysdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4zdzJlG75cMPxlVOfMNmGrXGm/DiNSso512V2M2wsXg=; b=oI53Kb3SjEhuGbEyDTtf/HJvKeTLyOFljsDVSEN3n9uesiqZHYfCVX1kmW13u3EnRwBuyIkmUeSBGFQ2WkQ+Fjc8w5qEjoDzT8+t31tbZNNhpNMm1a8qnRv1ApkSrIvw3fpC0ObNstNuBrNc70xUUK2vExa5VwT4e4Gq8ZRO+zo= From: Andrew Cooper To: Stefano Stabellini CC: Xen-devel , Doug Goldstein , Anthony Perard , Michal Orzel , Oleksii Kurochko Subject: Re: [PATCH 4/6] CI: Express HYPERVISOR_ONLY in build.yml Thread-Topic: [PATCH 4/6] CI: Express HYPERVISOR_ONLY in build.yml Thread-Index: AQHZG+cbFLjU6ViRqEqaO8BfTNldnq6NfEWAgAADPYCAAAKVgIAAAY8A Date: Wed, 4 Jan 2023 01:41:57 +0000 Message-ID: <4f9a9927-c287-b40e-e4b0-653e69dbc1bb@citrix.com> References: <20221230003848.3241-1-andrew.cooper3@citrix.com> <20221230003848.3241-5-andrew.cooper3@citrix.com> <34e692e3-ef76-a43e-ec4f-a7c1ed2d094f@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|MN2PR03MB5022:EE_ x-ms-office365-filtering-correlation-id: e9c54b3d-cb61-4b94-0dcf-08daedf4dd8b x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ewMfha2+TxL6HkdkvUj4v8C9WNEsjmYNEBTKpLEV/RMzHYNhbfYC+Kw5UCiPdpoAP6wS6+p6rR8WsCjQ84kGnxPxxihPc+5w0RnbMdrzj1H27MtXdl3a7FPa1w+GJHO5QrmkoBYICYT4HQGA3cHFDLlq7gyQeQxFodD4bCKdC3BGnP7k1ajjJcMMjCtCL2F0g79qQHz9N4zRXcgndtt1aHFhF6Df9X/Sxo8qldNhHvVue8OPwJBZYMIJwN4ZVbU4jsSJbmMD2IHUDDV2N7aWcs4LH7OSjWNxc7D/D04vBEHCzlGI56axXkfba4fJxn9xXQHuZo3waoPzV4vzHov+zIcGZg5kbh3kvhdLscRShdj0ltFUB2b9NuUJN9WOaFkxcyVDXj9V9tfA7FKZeZrBM8+JtsOcMmKbD+p50TCBMNQwUTrah7UMBQ+gu93XvyQXOFkMYqQvc8rF/xUrUqpZ/v2q/D8nsSAbFcPBNCpXQXHLbOuFh1qQODZi5UD5N9e3/4K7ZQXPj8vi9yBTWm1P4FyIKsXZDZPe6d4f8arFofE3WUm+tHOTrpzGqxz+/v7juiIw4MV2jptzzg8nTFNzvsxVaCaEk8dcF0HTlTqXmrGtyRcqm41QvMe+WoAna3QM5X3kGkvrz43RN+nUOIYaWG010F/nyY1BP1uM8h5KNBvBbylaeqbrHy8aaCLPaRUtyG5Mea3o+9C827yrqaPutkzoYTY45uBq/1nP5kmqMbLGKRs0d0Y1eYuoGQR8uebzNYNJNWOR6ANfxZLcu7poOg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(376002)(396003)(366004)(346002)(451199015)(31686004)(36756003)(86362001)(31696002)(66446008)(4326008)(54906003)(91956017)(66946007)(41300700001)(6916009)(66556008)(38070700005)(66476007)(64756008)(76116006)(8676002)(82960400001)(38100700002)(122000001)(26005)(186003)(6486002)(53546011)(6512007)(71200400001)(478600001)(5660300002)(8936002)(2906002)(6506007)(316002)(2616005)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?YnZTTVU0aHRsRlpKS0NwUmVUZFlETGZvK0lJYWxZTk1reW1Fc0VyUU5vdERZ?= =?utf-8?B?WUJOTW50SXhWZHdOei9xN0M0TnhQemdEcWJTVlNpb1hFa0twVy9XampGRnIy?= =?utf-8?B?eDUzZUswTml0dHBCVDM5cWZrVWFseEk1d0FISXhwekhIMENENllMRnBaOW1w?= =?utf-8?B?a1ZBeW93L0l3eGpvMGJPNys3MXNlRktyRmVBT3FrZ2R6U042RXJCdCtOMjZU?= =?utf-8?B?emdCZlNlYmNJZzA0aEVBR0l4NzNJcHcvK3JBMzNDOWVnSDhNTnlMc0FxZHI4?= =?utf-8?B?MndVbDhBbGwzbW53RElpSms0TWczWVJhT2xnUW5veXFWWUFUL3B1TzN0NUs5?= =?utf-8?B?MG9XNmdtTGlqVERuUGxzQjVSSzJHSnNUTnJZdVZiczBsZy9ZYWMyZTh2T2hC?= =?utf-8?B?d3FnaGJGL1Zkc01FL2czWXZnMk13U0pDQ09FMStGM1FDNkF1QUtGelhlTWN0?= =?utf-8?B?dVZwTWFUKzY4WnYxcTZ0RGhSdHQzZ2hvQjFkK2VpbDE0S01lYjI3U0p1MWky?= =?utf-8?B?VDVvcUFsL055T0ExK2lubndQMVlkTFlxRnpRZlZUdXhJMHBZc1VZdHdHNFNM?= =?utf-8?B?ay9KMWZLNER0a1BKNEZBTlZjWExCZGhsNmhGcWk5TUxaWThaRU1EM0dRbTBI?= =?utf-8?B?RGljUWE0a0I5azBjYWllc3VqZytaUTl6VkxTNnlHUkpVSGtBZmZvMHpqaSsw?= =?utf-8?B?OVFKUWFlM3VwTXpoYlo3WXFSNWtxRlliMzJNVFptN3l2RTVGVGpRemFudkRS?= =?utf-8?B?NWduSi90cGJyMXNzYlNoODdza0RURDQ5c0hRL0VhcWw4Q3Fibmw1bVpZUW5z?= =?utf-8?B?TjIrK3greWh2b0xxbVdhT2dVaElRM1FpSmt4WldpVmZrb0tid252VlAweW9o?= =?utf-8?B?T0s3S01ab1UrSVdqa3M4empSdzQwZnZYb1h4MnZBVnZjQWtDaUNmOVFyWE0r?= =?utf-8?B?dGIyMW9NK2ZiTWpXV0E5ZHVtOXNPVDQrVE5yQzZCcVJSWjM5RTNsZEdqcW55?= =?utf-8?B?Rk9lZGdKWTVuWWwweFJpazZ2QWh4SmJaWlcvUEFOa0JETTdGdjloaUNhZ0lp?= =?utf-8?B?MFc4Z2w5U2xYaGpvMnJHQ05rK2x5aWdWVlVvbTRKQkg2WXd3Ym9WMnhHRmFv?= =?utf-8?B?dzFFblk5UmdFcktEUnFLeDUwdElEb3ZPQU1QSHovbk9zWGluOXdrYXZmcG0v?= =?utf-8?B?WkhadmtReHJRWWZzV1pDMzRvbkU2dWhOZmV2bTQrT1ZIOWlqMW85TEpWbk5Q?= =?utf-8?B?M3hxV1Uzb0t3VUVTL1dEUFJSZ0F3U0IyRm50eDg5eVZjNDdZNWZiNjFtK1Iv?= =?utf-8?B?UnNwOElxdHZGY1FZVHJyUjlZMk5zQmF1aWRVVzZHbFNKWHRYNTZIYXJmdkZK?= =?utf-8?B?TWx0SDNWa2dJSnE1eXVLK0tMSEVzRVEvTTVncit2OEIzT2pScWRGcW5ZRjFp?= =?utf-8?B?M2dwRkdLU1RtV0g3NlQveFVBSEVvcGVHc1NDZ1lBQXJnZzE3V29xU01YeDE1?= =?utf-8?B?NTVoSGhSS1BWbk9ZK205QjJuZjd1Y2tsOENwUEdWTk5ybmxCQnFwYzhGNmpi?= =?utf-8?B?NFBUQXFKSHgyS0w0TXdON1NSQVdMR3ozZ0dkVXRhNDBHWjdUVlV3d2FwbXZm?= =?utf-8?B?YmswelAzbHF1aDJyRFdIZ1JUbXJwOVZ2WGkyWURXa0RMQlAydEc1UFNnaC8r?= =?utf-8?B?ZWNkWHRMeGJjU21iU0lSYWpmZy9malk4NHc5eHVpek5mcVI1MXIzVEh2dkx2?= =?utf-8?B?ZEtCeU9CcEtoOFdkVzBydGVSY3BKZThNN3B5NWg4bUF3SlBBK3k1SXI3Q0VI?= =?utf-8?B?cGVxM0lpTm9OUUZlKytIWFVsOXdHR21TVE1UZk1YTXQ5M2dwUUFJbUsvdnZN?= =?utf-8?B?UUZhRmJ2VWE2RTZSQTRiQ1p3dmQyeTFiWkZGYitTQU1lSWJKYUppKzEwUWpP?= =?utf-8?B?R2VRZWtIOU9uM3ZaZklZcGFxbmNMNml4M08xemRXVGNxSGpaTHNkT0lEUWVx?= =?utf-8?B?NHhtMDNPakpNUk5CV2FDK0J3R2dwNlQ5K3dSeEwxTHRMWTNHQWU2a0xTQzNq?= =?utf-8?B?MnlRYWYxOE1GNnB5UU1yQ3ZzMUpMbFhRT3A5MmUyN1NZQXNIT3U0NE5PeVY2?= =?utf-8?Q?QeiUove9+CZxWZSfu74KJlVh9?= Content-Type: text/plain; charset="utf-8" Content-ID: <1239397978D90B4B8430A6826B3FDC78@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: YUyL0nEbAMSdKqJQXSuH8Z+PrwARjbl/AoH6HLp7X6Y7yar7oIsmpJDKElj4t4xlu3lpseTIF0/JVhHblce2sso8ibmib+ndSUSI71kFyN3CaHxmQ14stx4QRCj8ArblQfSmwnefTCoUSqQHC2z2IGrUaiybSbOChL1fv3Cj7hT/O1EpQGUu0huBj2rJiZmEneUbqMJ16HE69twrQy3e1tDpGXYEx5SdBfyBM++maZeBSInX7oHzObwMgxcQzIEMyu0dTEaail0EflkVRYlEqZhMaX2u80uTBNeGHDLmWhRAiEEN7Utq1mACj/W2Fqj4h8Ejxg5oneYT8uJJPlZS+sOLEH1j8w8KF7hImDCya3D5+6seHMDxlmLr69iIhgrY9XBIZQugJiCZIMbXfC4jxnWSL+ejqASJAWcSP/d8XznkgHsZrxfyDiGhvThyINbwLpptD3jyNLtrgiTsMNYa8YzaTF1cIlrjWWJ+LivGAS2N6cn78NCtbAGFy0lnU9ksbpiVVf0rf202THbzXNhuxFUzGHO1ufRmUi2svoaTmeTk/DNdPkuQaF6qqIkQK39woqJ59EsiGAGo3Ww9LpvaeDfW1nyor64NshdYeYMXdebv+KDG0AI4FEBuEm6trSJczaJeedzqSC9BlJVqmPSNseMSXvOxXbfD+ZUGi2qC1I3XbQL2nsuv8WfzbsPqVNRigUC7iHa0ue8DWh2M6tDXrUJ0ghp87RbYgyzmX2ETrPswt3BtBuEMbLtVecbfu6rLCdh3JYLb8gkxXnlXaJ4YDR3228i9usH5T82dL+dQvsHQZKV5EGYqJf3KWhtd03x/PYIpCwOpy52RqFCM2U4Gohau0aejCkh5C4gCAUolJMQD6U6tbxgNhkndBpfQ2TW/ X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e9c54b3d-cb61-4b94-0dcf-08daedf4dd8b X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jan 2023 01:41:57.0871 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WjVoH2+7Ml0cbU75bkReyjjRE6T2H9mZ2ADzVpTUgo/g+Y5HE1yD2AmQe/q0bsoKlMyWU49tOe2AaKJLU7wHdNfnedeKa4s1/loIW0APAVc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5022 T24gMDQvMDEvMjAyMyAxOjM2IGFtLCBTdGVmYW5vIFN0YWJlbGxpbmkgd3JvdGU6DQo+IE9uIFdl ZCwgNCBKYW4gMjAyMywgQW5kcmV3IENvb3BlciB3cm90ZToNCj4+IE9uIDA0LzAxLzIwMjMgMTox NSBhbSwgU3RlZmFubyBTdGFiZWxsaW5pIHdyb3RlOg0KPj4+IE9uIEZyaSwgMzAgRGVjIDIwMjIs IEFuZHJldyBDb29wZXIgd3JvdGU6DQo+Pj4NCj4+Pj4gV2hldGhlciB0byBidWlsZCBvbmx5IFhl biwgb3IgZXZlcnl0aGluZywgaXMgYSBwcm9wZXJ0eSBvZiBjb250YWluZXIsDQo+Pj4+IHRvb2xj aGFpbiBhbmQvb3IgdGVzdGNhc2UuICBJdCBpcyBub3QgYSBwcm9wZXJ0eSBvZiBYRU5fVEFSR0VU X0FSQ0guDQo+Pj4+DQo+Pj4+IENhcGl0YWxpc2UgSFlQRVJWSVNPUl9PTkxZIGFuZCBoYXZlIGl0 IHNldCBieSB0aGUgZGViaWFuLXVuc3RhYmxlLWdjYy1hcm0zMi0qDQo+Pj4+IHRlc3RjYXNlcyBh dCB0aGUgcG9pbnQgdGhhdCBhcm0zMiBnZXQgbWF0Y2hlZCB3aXRoIGEgY29udGFpbmVyIHRoYXQg Y2FuIG9ubHkNCj4+Pj4gYnVpbGQgWGVuLg0KPj4+Pg0KPj4+PiBGb3Igc2ltcGxpY2l0eSwgcmV0 YWluIHRoZSBSQU5EQ09ORklHIC0+IEhZUEVSVklTT1JfT05MWSBpbXBsaWNhdGlvbi4NCj4+Pj4N Cj4+Pj4gU2lnbmVkLW9mZi1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4 LmNvbT4NCj4+Pj4gLS0tDQo+Pj4+IENDOiBEb3VnIEdvbGRzdGVpbiA8Y2FyZG9lQGNhcmRvZS5j b20+DQo+Pj4+IENDOiBTdGVmYW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+ DQo+Pj4+IENDOiBBbnRob255IFBFUkFSRCA8YW50aG9ueS5wZXJhcmRAY2l0cml4LmNvbT4NCj4+ Pj4gQ0M6IE1pY2hhbCBPcnplbCA8bWljaGFsLm9yemVsQGFtZC5jb20+DQo+Pj4+IENDOiBPbGVr c2lpIEt1cm9jaGtvIDxvbGVrc2lpLmt1cm9jaGtvQGdtYWlsLmNvbT4NCj4+Pj4gLS0tDQo+Pj4+ ICBhdXRvbWF0aW9uL2dpdGxhYi1jaS9idWlsZC55YW1sIHwgIDIgKysNCj4+Pj4gIGF1dG9tYXRp b24vc2NyaXB0cy9idWlsZCAgICAgICAgfCAxMSArKysrLS0tLS0tLQ0KPj4+PiAgMiBmaWxlcyBj aGFuZ2VkLCA2IGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0pDQo+Pj4+DQo+Pj4+IGRpZmYg LS1naXQgYS9hdXRvbWF0aW9uL2dpdGxhYi1jaS9idWlsZC55YW1sIGIvYXV0b21hdGlvbi9naXRs YWItY2kvYnVpbGQueWFtbA0KPj4+PiBpbmRleCA5M2Q5ZmY2OWE5ZjIuLmU2YTkzNTdkZTNlZiAx MDA2NDQNCj4+Pj4gLS0tIGEvYXV0b21hdGlvbi9naXRsYWItY2kvYnVpbGQueWFtbA0KPj4+PiAr KysgYi9hdXRvbWF0aW9uL2dpdGxhYi1jaS9idWlsZC55YW1sDQo+Pj4+IEBAIC01MTYsMTEgKzUx NiwxMyBAQCBkZWJpYW4tdW5zdGFibGUtZ2NjLWFybTMyOg0KPj4+PiAgICBleHRlbmRzOiAuZ2Nj LWFybTMyLWNyb3NzLWJ1aWxkDQo+Pj4+ICAgIHZhcmlhYmxlczoNCj4+Pj4gICAgICBDT05UQUlO RVI6IGRlYmlhbjp1bnN0YWJsZS1hcm0zMi1nY2MNCj4+Pj4gKyAgICBIWVBFUlZJU09SX09OTFk6 IHkNCj4+Pj4gIA0KPj4+PiAgZGViaWFuLXVuc3RhYmxlLWdjYy1hcm0zMi1kZWJ1ZzoNCj4+Pj4g ICAgZXh0ZW5kczogLmdjYy1hcm0zMi1jcm9zcy1idWlsZC1kZWJ1Zw0KPj4+PiAgICB2YXJpYWJs ZXM6DQo+Pj4+ICAgICAgQ09OVEFJTkVSOiBkZWJpYW46dW5zdGFibGUtYXJtMzItZ2NjDQo+Pj4+ ICsgICAgSFlQRVJWSVNPUl9PTkxZOiB5DQo+Pj4gY2FuIHlvdSBtb3ZlIHRoZSBzZXR0aW5nIG9m IEhZUEVSVklTT1JfT05MWSB0byAuYXJtMzItY3Jvc3MtYnVpbGQtdG1wbCA/DQo+PiBOb3QgcmVh bGx5IC0gdGhhdCdzIHRoZSBwb2ludCBJJ20gdHJ5aW5nIHRvIG1ha2UgaW4gdGhlIGNvbW1pdCBt ZXNzYWdlLg0KPj4NCj4+PiBJIHRoaW5rIHRoYXQgbWFrZXMgdGhlIG1vc3Qgc2Vuc2UgYmVjYXVz ZSAuYXJtMzItY3Jvc3MtYnVpbGQtdG1wbCBpcyB0aGUNCj4+PiBvbmUgc2V0dGluZyBYRU5fVEFS R0VUX0FSQ0ggYW5kIGFsc28gdGhlIHg4Nl82NCB0YWcuDQo+PiBJdCdzIG5vdCBhYm91dCB4ODZf NjQ7IGl0cyBhYm91dCB0aGUgY29udGFpbmVyLg0KPj4NCj4+IFdoZXRoZXIgd2UgY2FuIGJ1aWxk IGp1c3QgWGVuLCBvciBldmVyeXRoaW5nLCBzb2xlbHkgZGVwZW5kcyBvbiB0aGUNCj4+IGNvbnRl bnRzIGluIGRlYmlhbjp1bnN0YWJsZS1hcm0zMi1nY2MNCj4+DQo+PiBJZiB3ZSB3YW50ZWQgdG8s IHdlIGNvdWxkIHVwZGF0ZSB1bnN0YWJsZS1hcm0zMi1nY2MncyBkb2NrZXJmaWxlIHRvDQo+PiBp bnN0YWxsIHRoZSBhcm0zMiBjcm9zcyB1c2VyIGxpYnMsIGFuZCBkcm9wIHRoaXMgSFlQRVJWSVNP Ul9PTkxZDQo+PiByZXN0cmljdGlvbi4NCj4gSWYgaXQgaXMgYSBwcm9wZXJ0eSBvZiB0aGUgY29u dGFpbmVyLCBzaG91bGRuJ3QgSFlQRVJWSVNPUl9PTkxZIGJlIHNldA0KPiBldmVyeSB0aW1lIHRo ZSBkZWJpYW46dW5zdGFibGUtYXJtMzItZ2NjIGNvbnRhaW5lciBpcyB1c2VkPyBJbmNsdWRpbmcN Cj4gZGViaWFuLXVuc3RhYmxlLWdjYy1hcm0zMi1yYW5kY29uZmlnIGFuZA0KPiBkZWJpYW4tdW5z dGFibGUtZ2NjLWFybTMyLWRlYnVnLXJhbmRjb25maWc/DQo+DQo+IEkgcmVhbGl6ZSB0aGF0IHRo ZSBvdGhlciAyIGpvYnMgYXJlIHJhbmRjb25maWdzIHNvIEhZUEVSVklTT1JfT05MWSBnZXRzDQo+ IHNldCBhbnl3YXkuIEJ1dCBpZiBIWVBFUlZJU09SX09OTFkgaXMgYSBwcm9wZXJ0eSBvZiB0aGUg c3BlY2lmaWMNCj4gY29udGFpbmVyLCB0aGVuIEkgdGhpbmsgaXQgd291bGQgYmUgYmVzdCB0byBi ZSBjb25zaXN0ZW50IGFuZCBzZXQNCj4gSFlQRVJWSVNPUl9PTkxZIGV2ZXJ5d2hlcmUgZGViaWFu OnVuc3RhYmxlLWFybTMyLWdjYyBpcyB1c2VkLg0KPg0KPiBFLmcuIG9uZSBkYXkgd2UgY291bGQg anVzdCByYW5kY29uZmlncyB0byBidWlsZCBhbHNvIHRoZSB0b29scyB3aXRoIGENCj4gc2ltcGxl IGNoYW5nZSB0byB0aGUgYnVpbGQgc2NyaXB0IGFuZCBvdGhlcndpc2Ugd2Ugd291bGQgbmVlZCB0 bw0KPiByZW1lbWJlciB0byBhbHNvIGFkZCB0aGUgSFlQRVJWSVNPUl9PTkxZIHRhZyBmb3IgdGhl IG90aGVyIDIgam9icyB1c2luZw0KPiBkZWJpYW46dW5zdGFibGUtYXJtMzItZ2NjLg0KDQpPaywg c28gd2Ugd2FudCA0IEhZUEVSVklTT1JfT05MWSdzIGluIHRvdGFsLCBvbmUgZm9yIGVhY2ggaW5z dGFuY2Ugb2YNCkNPTlRBSU5FUjogZGViaWFuOnVuc3RhYmxlLWFybTMyLWdjYyA/DQoNCn5BbmRy ZXcNCg== From xen-devel-bounces@lists.xenproject.org Wed Jan 04 01:48:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 01:48:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470898.730560 (Exim 4.92) (envelope-from ) id 1pCstK-0003dm-EZ; Wed, 04 Jan 2023 01:48:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470898.730560; Wed, 04 Jan 2023 01:48:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCstK-0003df-BT; Wed, 04 Jan 2023 01:48:30 +0000 Received: by outflank-mailman (input) for mailman id 470898; Wed, 04 Jan 2023 01:48:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCstJ-0003dZ-C4 for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 01:48:29 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e0de79ee-8bd1-11ed-b8d0-410ff93cb8f0; Wed, 04 Jan 2023 02:48:26 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C6560614F9; Wed, 4 Jan 2023 01:48:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 41AA7C433D2; Wed, 4 Jan 2023 01:48:24 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e0de79ee-8bd1-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672796905; bh=w+ufstUd4M6KNCTa9BPxRDQ4SqOmoKlG5WoFYlctB60=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=ErUBhbgQ2WiwWGJpfcH0xUZNrW4HUTWwZNZBSIC9NGDigO2qshwS26i/v9DvouMcU ulHKLYCnxJvMdkL4PRdoW8Y95Z1Gz3E+GWul0F0upOxchS58SU3xYaJTJlmMPWj7i+ mWkQnKaiGwatzIqFKEIP95+ko2FoFQZTUT6+RcI81kQXrQKNscs4dqnrmSRalAhi4H 6KLfKP9tTImVoXVA7kPjA2jRJ38YDPnjCis8FMqDbAzjbpGRdsKY6vSYE2hLwB4VWK krQsQvSJRggXYSJywy05A1BU6NuayojYK9edCPf7nxVMCQzuN6uZvXhxvgqyz0F/Wz OgPacIVQguwbg== Date: Tue, 3 Jan 2023 17:48:22 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Andrew Cooper cc: Stefano Stabellini , Xen-devel , Doug Goldstein , Anthony Perard , Michal Orzel , Oleksii Kurochko Subject: Re: [PATCH 4/6] CI: Express HYPERVISOR_ONLY in build.yml In-Reply-To: <4f9a9927-c287-b40e-e4b0-653e69dbc1bb@citrix.com> Message-ID: References: <20221230003848.3241-1-andrew.cooper3@citrix.com> <20221230003848.3241-5-andrew.cooper3@citrix.com> <34e692e3-ef76-a43e-ec4f-a7c1ed2d094f@citrix.com> <4f9a9927-c287-b40e-e4b0-653e69dbc1bb@citrix.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 4 Jan 2023, Andrew Cooper wrote: > On 04/01/2023 1:36 am, Stefano Stabellini wrote: > > On Wed, 4 Jan 2023, Andrew Cooper wrote: > >> On 04/01/2023 1:15 am, Stefano Stabellini wrote: > >>> On Fri, 30 Dec 2022, Andrew Cooper wrote: > >>> > >>>> Whether to build only Xen, or everything, is a property of container, > >>>> toolchain and/or testcase. It is not a property of XEN_TARGET_ARCH. > >>>> > >>>> Capitalise HYPERVISOR_ONLY and have it set by the debian-unstable-gcc-arm32-* > >>>> testcases at the point that arm32 get matched with a container that can only > >>>> build Xen. > >>>> > >>>> For simplicity, retain the RANDCONFIG -> HYPERVISOR_ONLY implication. > >>>> > >>>> Signed-off-by: Andrew Cooper > >>>> --- > >>>> CC: Doug Goldstein > >>>> CC: Stefano Stabellini > >>>> CC: Anthony PERARD > >>>> CC: Michal Orzel > >>>> CC: Oleksii Kurochko > >>>> --- > >>>> automation/gitlab-ci/build.yaml | 2 ++ > >>>> automation/scripts/build | 11 ++++------- > >>>> 2 files changed, 6 insertions(+), 7 deletions(-) > >>>> > >>>> diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml > >>>> index 93d9ff69a9f2..e6a9357de3ef 100644 > >>>> --- a/automation/gitlab-ci/build.yaml > >>>> +++ b/automation/gitlab-ci/build.yaml > >>>> @@ -516,11 +516,13 @@ debian-unstable-gcc-arm32: > >>>> extends: .gcc-arm32-cross-build > >>>> variables: > >>>> CONTAINER: debian:unstable-arm32-gcc > >>>> + HYPERVISOR_ONLY: y > >>>> > >>>> debian-unstable-gcc-arm32-debug: > >>>> extends: .gcc-arm32-cross-build-debug > >>>> variables: > >>>> CONTAINER: debian:unstable-arm32-gcc > >>>> + HYPERVISOR_ONLY: y > >>> can you move the setting of HYPERVISOR_ONLY to .arm32-cross-build-tmpl ? > >> Not really - that's the point I'm trying to make in the commit message. > >> > >>> I think that makes the most sense because .arm32-cross-build-tmpl is the > >>> one setting XEN_TARGET_ARCH and also the x86_64 tag. > >> It's not about x86_64; its about the container. > >> > >> Whether we can build just Xen, or everything, solely depends on the > >> contents in debian:unstable-arm32-gcc > >> > >> If we wanted to, we could update unstable-arm32-gcc's dockerfile to > >> install the arm32 cross user libs, and drop this HYPERVISOR_ONLY > >> restriction. > > If it is a property of the container, shouldn't HYPERVISOR_ONLY be set > > every time the debian:unstable-arm32-gcc container is used? Including > > debian-unstable-gcc-arm32-randconfig and > > debian-unstable-gcc-arm32-debug-randconfig? > > > > I realize that the other 2 jobs are randconfigs so HYPERVISOR_ONLY gets > > set anyway. But if HYPERVISOR_ONLY is a property of the specific > > container, then I think it would be best to be consistent and set > > HYPERVISOR_ONLY everywhere debian:unstable-arm32-gcc is used. > > > > E.g. one day we could just randconfigs to build also the tools with a > > simple change to the build script and otherwise we would need to > > remember to also add the HYPERVISOR_ONLY tag for the other 2 jobs using > > debian:unstable-arm32-gcc. > > Ok, so we want 4 HYPERVISOR_ONLY's in total, one for each instance of > CONTAINER: debian:unstable-arm32-gcc ? yeah From xen-devel-bounces@lists.xenproject.org Wed Jan 04 01:51:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 01:51:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470905.730571 (Exim 4.92) (envelope-from ) id 1pCsvx-00050m-Ts; Wed, 04 Jan 2023 01:51:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470905.730571; Wed, 04 Jan 2023 01:51:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCsvx-00050f-Qo; Wed, 04 Jan 2023 01:51:13 +0000 Received: by outflank-mailman (input) for mailman id 470905; Wed, 04 Jan 2023 01:51:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCsvw-00050Z-F4 for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 01:51:12 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 408487ba-8bd2-11ed-b8d0-410ff93cb8f0; Wed, 04 Jan 2023 02:51:07 +0100 (CET) Received: from mail-dm6nam12lp2177.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.177]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 03 Jan 2023 20:51:05 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DS7PR03MB5429.namprd03.prod.outlook.com (2603:10b6:5:2d1::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Wed, 4 Jan 2023 01:51:04 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5944.019; Wed, 4 Jan 2023 01:51:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 408487ba-8bd2-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1672797068; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=SPun27trLn8T3iqBdiblTkkD7u1SnPWiZG1UR+0D4M0=; b=fuwuaw7itMNk2IEAoCXybXvPfZfR179Hxk4Wftpkds23ZUvpw9yKTWDL LM8BTBaT/37SgXrmenqqMsVpMRR0xNsV1ru4eNmuvp/74bPtIZXuzb7Au q1y4wKVH0QoB59K78Ag17rHD7GXrBtdZJVtGdzzJq9xF1BJKdveoFWF4y o=; X-IronPort-RemoteIP: 104.47.59.177 X-IronPort-MID: 90010737 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:szezXa5XZFkH/nj1LVt+VgxRtNjGchMFZxGqfqrLsTDasY5as4F+v mNNWj2CPauKN2OhKYsibY/lpEwD78fSyYBmG1dqpX81Hi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraBYnoqLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+4pwehBtC5gZlPakT5weD/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m2 dAcMXMrcCG5gc29npyRafU9wes5I5y+VG8fkikIITDxK98DGMqGb4CUoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6OnUooj+eF3Nn9I7RmQe18mEqCq 32A1GP+GhwAb/SUyCaf82LqjejK9c/+cNNKTOTgqaU16LGV7nAJCwckfmGQmsG8in/kWN5tF UELoDV7+MDe82TuFLERRSaQu2WYtxQRX95RFewS6wyXzKfQpQGDCQAsXjNHLdArqsIybTgrz UOS2cPkAyR1t7+YQm7b8a2bxRu5MDIZKmIqbiYeQQwIpdLkpekbixPETt9nVqmvnNDxMTj1z 3aBqy1Wr7IXgM0Q1qT9/k3dhDmspZ/hQQs85wGRVWWghj6Vf6agbo2srFTes/BJKd/DSkHb5 Sdb3c+D8OoJEJeB0jSXR/kAF62o4PDDNyDAhVloHN8q8DHFF2OfQL28KQpWfC9BWvvosxewC KMPkWu9PKNuAUY= IronPort-HdrOrdr: A9a23:ejJTrK9vAL4WUAkd3gtuk+HGdr1zdoMgy1knxilNoERuA7Slf8 DHppQmPGzP+XIssRAb6Je90cy7Kk80mqQFhbX5UY3NYOCighrQEGgA1/qU/9SDIVyYygc178 4JGcQQNDSzNykdsS+Q2njaLz9U+qjjzEnev5a9854Cd2BXgwwK1WpEIzfeNnczaBhNBJI/Gp bZzs1bpwC4cXBSQtWnCmIDV+3jocSOsJ79exYJCzMu9QHL1FqTmffHOind+i1bfyJEwL8k/2 SAuwvl5p+7u/X+5g7A23TV55F2nsKk7tdYHsSDhuUcNz2poAe1Y4ZKXaGEoVkO0ZeSwWdvtO OJjwYrPsx15X+UVHqyuwHR1w7p1ytrw2P+yHeD6EGT6vDRdXYfMY5slIhZehzW5w4Lp9dnyp 9G2Gqfqt5+EQ7ApiLg/NLFPisa3HZc4EBS3NL7vUYvHrf2W4Uh47D3O3klUavoKRiKpLzP1t MeTP00qswmMm9yJEqpxVWHiObcJEjamXy9Mw0/Uhj/6UkVoJk+9TpR+OUP2ngH754zUJ9C+q DNNblpjqhHSosMYbt6H/ppe7rENoXhe2O9DIupGyWVKIgXf3bW75Ln6rQ84++nPJQO0ZspgZ zEFFdVr3Q7dU7iAdCHmMQjyGG4fEytGTD2js1O7ZlwvbPxALLtLC2YUVgr18+tue8WDMHXU+ u6fJhWH/jgJ23zHpsh5XyKZ7BCbX0FFMEFsNcyXFyD5srNN43xr+TeNO3eIbL8eAxUK18Xwk FzIgQbCP8wkXxDAEWI/SQ5c0mdBnDCwQ== X-IronPort-AV: E=Sophos;i="5.96,297,1665460800"; d="scan'208";a="90010737" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Opey2Jn5lEmHD7A6JW7ki6Qs3qgz+6f+7YetS2xaClZKTF4rEqa28l3i5HnGlWvkbnGrhbczHVdH2Kj3o1eKVylltG6/YlGBvK73E3G+Mfii4iNLAEchtT0C/mHMc0pat18SqVwLsQrJVGMx20N2KtRwymmw8RsyovdK0lfJhi2t87tO2tGuKFuE4yPVyZvIwMhpCZPncAebQdYzqqIxsKRADVQV4dvjW7ZZTQWTjPL4PZ68ir8Z0jCNILB2S/c5i19WDsJ+QrlwTnUpVscsN1pJcNvJlSFW1bBYaqGGEErYoaErhMT5fhTRl1mc5GAz4x5HDuKTFkB5sxqNwEJrbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SPun27trLn8T3iqBdiblTkkD7u1SnPWiZG1UR+0D4M0=; b=Y1bJVKCFHDXRN49KpA3e02fvXMvEGfOUO/nNKPwh++URyO1TxzgFhFmV3lfgEtCUgAwcZgsQf10wjB+WAURj0C0Z8I/F8sfAj1k+VhsZDcPkYF8hUrR6Wk5R0y+jjnwPqSoLZbm+SCPvG0xFt7BTzhbZIlQw/Jf207AcCOSWY24ROPCOPoB7VJ9v1f070hub8EZgdQN3tajuJKCndjVs7w1xmDqn4dyDqKFsC3SAh6US44tSblEtpm+9d+CQnS8y22F0Qpxnxw+69ErKAIY01yA76jD/HmCb/5vt/MoFWtf/vh2rzb+GzMr1uISeb40QZJOUIlpIdXf3Ru/yKw30FQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SPun27trLn8T3iqBdiblTkkD7u1SnPWiZG1UR+0D4M0=; b=OTM9vjz2ZpsQmPC5XutVqB65vZx386AVqYFD17OINK8pYzqjLWdugIziRfp9qUNmjIzFYOnFMzQdQ+TunQteGE4PgvwtLRelr2mQzOQ18JV71+FOtLDiklne4ByOZC8qdGcIPvYF8TCfq3g5CJVoBlpuRthpASLexChYfnPlTaM= From: Andrew Cooper To: Stefano Stabellini CC: Xen-devel , Doug Goldstein , Anthony Perard , Michal Orzel , Oleksii Kurochko Subject: Re: [PATCH 4/6] CI: Express HYPERVISOR_ONLY in build.yml Thread-Topic: [PATCH 4/6] CI: Express HYPERVISOR_ONLY in build.yml Thread-Index: AQHZG+cbFLjU6ViRqEqaO8BfTNldnq6NfEWAgAADPYCAAAKVgIAAAY8AgAABzACAAADAgA== Date: Wed, 4 Jan 2023 01:51:03 +0000 Message-ID: <5d3ed12e-3c01-5ea8-8d41-4a199fdf92b7@citrix.com> References: <20221230003848.3241-1-andrew.cooper3@citrix.com> <20221230003848.3241-5-andrew.cooper3@citrix.com> <34e692e3-ef76-a43e-ec4f-a7c1ed2d094f@citrix.com> <4f9a9927-c287-b40e-e4b0-653e69dbc1bb@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|DS7PR03MB5429:EE_ x-ms-office365-filtering-correlation-id: d51f62b5-468a-40a4-fa89-08daedf62371 x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BMCHowQ0FesAalJ2lN7tvhZh763c5r0KoymdgYXGgAsOZNgVwsV08NPCdA4mWGmp4iJgqYr+CC0pm3KtCBdj571c9d0mqZv5j8/3dupeK5OYOLIuagB3P7EXWrq7R6ghOWqME+VYVpoFb5NrE7uLPU9qIvXEhSHs1IqmkzyMz6jIhS0t5sMrFZYm0DB3QNYzHvwomSasF0WadCmzKXIL8diahwOx3pc1NadAm7ScSuz5t+18nie/33PfDlVjSRbuuB3WMGE+Uj8fJiFoX32Ev1bxrCNm9G36h89PS6X80aCJQqhVC9YTvtVxPnn95z+dNjoN276rsvUsOqZ4118JN3yj7LaffB8BdpZOvlYCC/SGSSoJS+y6GGIyeBEXzU6z++pgEL4G5sPVmviswl0YacU1BC00qWAo7QkQDCnrVeboFgJxr9zWlV2fbE6NfmAWD9pHsoGsFA/vY+3rPhXee5v3L0WcdeTATZQuKMJs71ETU9HLijx+ZM+16Owu7GSumFP/ZU3T5JQv73ot5+kXTd5uMz4F+luu7+8UygGuPyty+h+LdCo7+U04GRF/Z+H60fck/XsQxcsAiJwJwRqAcr8BAYsR7XXMwBXR0GX0Ityvp0iiRxKuw4cvMy59Qrich58dcE2rVCKM3wP6mkMvlaHrDFZemKJ0NPSXkhUcCoV3tAcrJFlc/rP4a/3rw+tH75qugwdVknkB0/CKyQlhXDfDbHAXunHrpYFLAI1DRlUCHevw1w18wfOeLHxNSYIG+a/gzs79dllGWn/Go8c61Q== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(396003)(39860400002)(376002)(366004)(451199015)(6486002)(71200400001)(6512007)(26005)(186003)(8936002)(122000001)(83380400001)(6506007)(53546011)(478600001)(31686004)(54906003)(6916009)(316002)(2616005)(66446008)(66476007)(4326008)(8676002)(66556008)(76116006)(36756003)(64756008)(66946007)(91956017)(38070700005)(41300700001)(38100700002)(82960400001)(5660300002)(2906002)(31696002)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Mlc3TUlFb21oNnZmWEY1a2JHMlYxNnB1RG1VRmZVOWYxQVNDNWRQa2swOGxa?= =?utf-8?B?T20yV2krNXY0ZkNpTjZjOEs5bnZ0N0xIOEtKdVBxYklvR1RobzFHdUR2WXBr?= =?utf-8?B?TUZYK1RBb3Z3NFB6S1ZnNlFERzJySmwzM2JvUU5kQTFqTno1ZFhzMmE5d0dN?= =?utf-8?B?ajRMNW5oVjNSc3g4Tzhvei9NeHRlbGNGa05xcDUzV1o4VzF6UXY3K1ROL0ZN?= =?utf-8?B?K1V0NGc4UVlDZlF5anA3eE5OV3VrTFZYQzZSU3J5NUJwZURZY3BxODc0K2tY?= =?utf-8?B?UFd2ZEdST0xuUWFoS0gyNDhWZFRNdnNnZnRKM2xlblU1TDVLVGFKdU10TnBM?= =?utf-8?B?NFpPTStNSlplVVZUZW1jN3cxOElodDkwdWF6R1JXbXRnREhqbmJnZ0NoYnlv?= =?utf-8?B?citJT2c4d2g3U1pQZTVBNU0xSkF3Wll4QmJNQlR4ZWI1VzYxbUlMUDdYMXBt?= =?utf-8?B?bm5ycDlyM1M5d1JUbmhnOWZ2Q3NiNlJJM1EvaWNxZDBuQ0UzeDgrUmFCUTBK?= =?utf-8?B?R295WmR6c2xWcmY1OUd0UDdTRDVmUnVxcUJvNHpvSVN5RktocEtkUFdQQnoy?= =?utf-8?B?TlNiMVF4dWFMUGhsend2UVNNNTJ6SjFQRG5aVmdEV2E3RnhoelhNTm9kbURI?= =?utf-8?B?N1NYVkI3ZlNZMzJLb1dSMXhBSENaanFHalFRdmNHcUdkWVRCaHB4bURCcm5j?= =?utf-8?B?RVp5eW9OOGtwalV0SURndjQ4Y1ZDWlN3N0xESWZYbFF0eEc5dU1DenEyR0la?= =?utf-8?B?L3A4NUdqc0Q2Y0dydVYxWXBBWFVWOEpsZ0RtUWtnUmdvblpJL2wxeFFmYVdP?= =?utf-8?B?ZTMvL055b2NDZTFQbjJadFNUTGZ4S1h6WTE1N3hYcnlPNEdPQktSNUxET2xG?= =?utf-8?B?ZlEwaytLeVRJRWJvczFjNTYrWlVMay8rbEZVUTFZT1pDdlczb0h3MzJVc0Rl?= =?utf-8?B?UENvN0NLQmZtRXhIYm92SXJSQzYrTFJTZDdaRVl3T01yY2UvVVRDYVZ2eTFj?= =?utf-8?B?a0tnRWt3eWJ2NVJRRGl1MHZ1aGwvQ2t2aTdpZnFkTE9GWFVyeVYyRTNJdm8y?= =?utf-8?B?MHk4dnNUckdxcHFUdGMwZFFVVEhTeFNvYXN5L1RQK2RHaE1jV21mVVVEVW9x?= =?utf-8?B?cE1EQjBnWDRpWnFDZWFBLzZHZUJ6cVVsUjhsbXJVK3RvYmorUjVMVzBLZkEy?= =?utf-8?B?SlF1b0RpczRkNlI4enhrRTdOSVJsdWdMTnRTdzFVV1VOcWFuSCtaZ0U4VUE0?= =?utf-8?B?LzBZaUZlT1BFZndwaGxVZkNJZEExUUtPYjVKKzJIMVlLak5oZmlKRTZmVE9P?= =?utf-8?B?dFA5eVZUc09MNE13QUppZVpGVGEvZmdhV2sreUp1VHNaMlNVR3JmM1UxaFFx?= =?utf-8?B?MndkTzQzTVZTdS9OSVE1QURPdDlBMXkyblhVNTIyZmJGSmt0ZXdtL0g2UHJt?= =?utf-8?B?cFE5a01wOTlscnY4OHozNFpyTVhnSEh4Wmh2cElrMkl5aExMc1QzaTJCTnE1?= =?utf-8?B?RFNqOFVJMUJteFNoMFhlcTNlU3VZd1dTWDBxVHpjU0Y5Z1V0eEVkT09IenIw?= =?utf-8?B?cmlrRU1Qd1BiMkhNZDAzazV0SzZlbXJ1bExzWWdKeXZKcUo3YWFkS21HUkVw?= =?utf-8?B?ZXFlRkxZeFgwUlFjbDRzRUFtMmxTUEUxNDN6WTdDRG14dUlLQWxJamdScWdG?= =?utf-8?B?dHZQNE14bWtZMFFVc2w1VjZQZEp1RW9JZDZFc3RaUEJDQUQrMlVkSEhvSDhT?= =?utf-8?B?RnZUd24vaHB5ODM3d3hFTU5Kb2k2WkdkZ3RBMjdiWTdsRmF4enpLRTRTV1I0?= =?utf-8?B?ZWFnTkN3UjVWalFhOFFCSlBraVpYaU5VTWZFWVEvQllEZ3k5d3B2OEt5S0k2?= =?utf-8?B?QS84UktrU3gwaVZhQngxeE1sYXhzRkF0dFJ6VEcvRk9jbTlNRUloNFN4Z2k3?= =?utf-8?B?ZTJQelJHYkUwNVFoUFN5UVRFR0dnbXZSTWxTdXo1QXIvdWlPeVkxUVJ2bTZm?= =?utf-8?B?UFp3OXUyZnRBbnpPaGVFUzMvZTJ2djdpUFZQRS9tZkc1VnNscm12YjVjdzF3?= =?utf-8?B?VTdKU2pIekFWdmFZOThvaWYvQS9oRzdON2V0RVo3blIwZjB3UDBlVzJPOEhO?= =?utf-8?Q?KkTQcX3lrNaZ/DCo4vtNrDuon?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Htf94hKcFUR9XJPXySwYiyFGubF6T0jWNoWG1QJnYuCbaJ/NshYZdTUlV1nv7bnwO3jP8kEjs4rvcfcWzeg1dVmjtG4z7dBZrtIQ9MNmWHPXpmsWQLNI6zyZBimTgG/2Y6tfJ+Ac8CbwAPK5u9PDNEMpGU5GuJ9R+UJ6A+a2bSq/FMQ1TD4m4GEfVfDR/Bb4CrwT9Fu1gc0Ogiuei6MMWAg4HZ9eAjsdJrfPKSWe+A+gTu0Dy7kS9CCjAmJcy1vpuFEcGG6Yjs2VMAmNqyDsTnVbLAfkfMjd1vlDYSL0sQjLC4dFOo/2yb1QgUY0le+wO3rfZt6I/K0CBB2+W6icOQ2SB9XD6q92J8Gf0Bd/aMe5TKZEoDET8h4uQCb3occWWV+xMRZDpdv9i0kXkMtLDzzFrcVt/R5FKa3MXUrYdfP27F/eLPtj9S1410Di7xq3xfRWdzIa/0P6NuLpoAD13zbcxnJUvOVWeOLTl0sbM8tE8QLkQT/HyECIszsC/6XQo7oOFWBNq7prRgXD2Z0P2KSzfFPAt5k83FV8OFGrARH3Tubs/w8rHllHhy7AyrrIOLPLAYItS7MTQRfRHXLvd1jNHSa0zkhC7+2jYNErSH/RUb0iG8nLydsWyAiPhprfbKMAF/wvDGvrNxEY0aR1FKQnAdZXAqPmYC/jFylwL/SS+FZR+9eiIHI9cKiMrUFZE7YCf9rgB+iqq7zrCmx7Lh5M+jHXohMQ3a2meEVAwuwVjvVOD0N3NmLThYPuLf2JpSR8Q6Z0mnIT9pnP4Jnp/YGmACm/NKwPS9SQgSYUDbn62HtCocZkJBbbv58lrAKX+TYXOXokPEQwvIcraD17BOOnvnlXPeIZDz4qEyT4luLLhxEdija9A70ApOO2AJJn X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d51f62b5-468a-40a4-fa89-08daedf62371 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jan 2023 01:51:03.8600 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Fm8PNh5daqtkfhyQuIHMV41ggtJ9UZHJNG5Eaufgk77nRXKaJ6r+63guTrjVo2pT7r1bNP9Pi3bRhLlTro9ONX6hTKNzgqgH0yGPrsReky4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5429 T24gMDQvMDEvMjAyMyAxOjQ4IGFtLCBTdGVmYW5vIFN0YWJlbGxpbmkgd3JvdGU6DQo+IE9uIFdl ZCwgNCBKYW4gMjAyMywgQW5kcmV3IENvb3BlciB3cm90ZToNCj4+IE9uIDA0LzAxLzIwMjMgMToz NiBhbSwgU3RlZmFubyBTdGFiZWxsaW5pIHdyb3RlOg0KPj4+IE9uIFdlZCwgNCBKYW4gMjAyMywg QW5kcmV3IENvb3BlciB3cm90ZToNCj4+Pj4gT24gMDQvMDEvMjAyMyAxOjE1IGFtLCBTdGVmYW5v IFN0YWJlbGxpbmkgd3JvdGU6DQo+Pj4+PiBPbiBGcmksIDMwIERlYyAyMDIyLCBBbmRyZXcgQ29v cGVyIHdyb3RlOg0KPj4+Pj4NCj4+Pj4+PiBXaGV0aGVyIHRvIGJ1aWxkIG9ubHkgWGVuLCBvciBl dmVyeXRoaW5nLCBpcyBhIHByb3BlcnR5IG9mIGNvbnRhaW5lciwNCj4+Pj4+PiB0b29sY2hhaW4g YW5kL29yIHRlc3RjYXNlLiAgSXQgaXMgbm90IGEgcHJvcGVydHkgb2YgWEVOX1RBUkdFVF9BUkNI Lg0KPj4+Pj4+DQo+Pj4+Pj4gQ2FwaXRhbGlzZSBIWVBFUlZJU09SX09OTFkgYW5kIGhhdmUgaXQg c2V0IGJ5IHRoZSBkZWJpYW4tdW5zdGFibGUtZ2NjLWFybTMyLSoNCj4+Pj4+PiB0ZXN0Y2FzZXMg YXQgdGhlIHBvaW50IHRoYXQgYXJtMzIgZ2V0IG1hdGNoZWQgd2l0aCBhIGNvbnRhaW5lciB0aGF0 IGNhbiBvbmx5DQo+Pj4+Pj4gYnVpbGQgWGVuLg0KPj4+Pj4+DQo+Pj4+Pj4gRm9yIHNpbXBsaWNp dHksIHJldGFpbiB0aGUgUkFORENPTkZJRyAtPiBIWVBFUlZJU09SX09OTFkgaW1wbGljYXRpb24u DQo+Pj4+Pj4NCj4+Pj4+PiBTaWduZWQtb2ZmLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29v cGVyM0BjaXRyaXguY29tPg0KPj4+Pj4+IC0tLQ0KPj4+Pj4+IENDOiBEb3VnIEdvbGRzdGVpbiA8 Y2FyZG9lQGNhcmRvZS5jb20+DQo+Pj4+Pj4gQ0M6IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJl bGxpbmlAa2VybmVsLm9yZz4NCj4+Pj4+PiBDQzogQW50aG9ueSBQRVJBUkQgPGFudGhvbnkucGVy YXJkQGNpdHJpeC5jb20+DQo+Pj4+Pj4gQ0M6IE1pY2hhbCBPcnplbCA8bWljaGFsLm9yemVsQGFt ZC5jb20+DQo+Pj4+Pj4gQ0M6IE9sZWtzaWkgS3Vyb2Noa28gPG9sZWtzaWkua3Vyb2Noa29AZ21h aWwuY29tPg0KPj4+Pj4+IC0tLQ0KPj4+Pj4+ICBhdXRvbWF0aW9uL2dpdGxhYi1jaS9idWlsZC55 YW1sIHwgIDIgKysNCj4+Pj4+PiAgYXV0b21hdGlvbi9zY3JpcHRzL2J1aWxkICAgICAgICB8IDEx ICsrKystLS0tLS0tDQo+Pj4+Pj4gIDIgZmlsZXMgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCA3 IGRlbGV0aW9ucygtKQ0KPj4+Pj4+DQo+Pj4+Pj4gZGlmZiAtLWdpdCBhL2F1dG9tYXRpb24vZ2l0 bGFiLWNpL2J1aWxkLnlhbWwgYi9hdXRvbWF0aW9uL2dpdGxhYi1jaS9idWlsZC55YW1sDQo+Pj4+ Pj4gaW5kZXggOTNkOWZmNjlhOWYyLi5lNmE5MzU3ZGUzZWYgMTAwNjQ0DQo+Pj4+Pj4gLS0tIGEv YXV0b21hdGlvbi9naXRsYWItY2kvYnVpbGQueWFtbA0KPj4+Pj4+ICsrKyBiL2F1dG9tYXRpb24v Z2l0bGFiLWNpL2J1aWxkLnlhbWwNCj4+Pj4+PiBAQCAtNTE2LDExICs1MTYsMTMgQEAgZGViaWFu LXVuc3RhYmxlLWdjYy1hcm0zMjoNCj4+Pj4+PiAgICBleHRlbmRzOiAuZ2NjLWFybTMyLWNyb3Nz LWJ1aWxkDQo+Pj4+Pj4gICAgdmFyaWFibGVzOg0KPj4+Pj4+ICAgICAgQ09OVEFJTkVSOiBkZWJp YW46dW5zdGFibGUtYXJtMzItZ2NjDQo+Pj4+Pj4gKyAgICBIWVBFUlZJU09SX09OTFk6IHkNCj4+ Pj4+PiAgDQo+Pj4+Pj4gIGRlYmlhbi11bnN0YWJsZS1nY2MtYXJtMzItZGVidWc6DQo+Pj4+Pj4g ICAgZXh0ZW5kczogLmdjYy1hcm0zMi1jcm9zcy1idWlsZC1kZWJ1Zw0KPj4+Pj4+ICAgIHZhcmlh YmxlczoNCj4+Pj4+PiAgICAgIENPTlRBSU5FUjogZGViaWFuOnVuc3RhYmxlLWFybTMyLWdjYw0K Pj4+Pj4+ICsgICAgSFlQRVJWSVNPUl9PTkxZOiB5DQo+Pj4+PiBjYW4geW91IG1vdmUgdGhlIHNl dHRpbmcgb2YgSFlQRVJWSVNPUl9PTkxZIHRvIC5hcm0zMi1jcm9zcy1idWlsZC10bXBsID8NCj4+ Pj4gTm90IHJlYWxseSAtIHRoYXQncyB0aGUgcG9pbnQgSSdtIHRyeWluZyB0byBtYWtlIGluIHRo ZSBjb21taXQgbWVzc2FnZS4NCj4+Pj4NCj4+Pj4+IEkgdGhpbmsgdGhhdCBtYWtlcyB0aGUgbW9z dCBzZW5zZSBiZWNhdXNlIC5hcm0zMi1jcm9zcy1idWlsZC10bXBsIGlzIHRoZQ0KPj4+Pj4gb25l IHNldHRpbmcgWEVOX1RBUkdFVF9BUkNIIGFuZCBhbHNvIHRoZSB4ODZfNjQgdGFnLg0KPj4+PiBJ dCdzIG5vdCBhYm91dCB4ODZfNjQ7IGl0cyBhYm91dCB0aGUgY29udGFpbmVyLg0KPj4+Pg0KPj4+ PiBXaGV0aGVyIHdlIGNhbiBidWlsZCBqdXN0IFhlbiwgb3IgZXZlcnl0aGluZywgc29sZWx5IGRl cGVuZHMgb24gdGhlDQo+Pj4+IGNvbnRlbnRzIGluIGRlYmlhbjp1bnN0YWJsZS1hcm0zMi1nY2MN Cj4+Pj4NCj4+Pj4gSWYgd2Ugd2FudGVkIHRvLCB3ZSBjb3VsZCB1cGRhdGUgdW5zdGFibGUtYXJt MzItZ2NjJ3MgZG9ja2VyZmlsZSB0bw0KPj4+PiBpbnN0YWxsIHRoZSBhcm0zMiBjcm9zcyB1c2Vy IGxpYnMsIGFuZCBkcm9wIHRoaXMgSFlQRVJWSVNPUl9PTkxZDQo+Pj4+IHJlc3RyaWN0aW9uLg0K Pj4+IElmIGl0IGlzIGEgcHJvcGVydHkgb2YgdGhlIGNvbnRhaW5lciwgc2hvdWxkbid0IEhZUEVS VklTT1JfT05MWSBiZSBzZXQNCj4+PiBldmVyeSB0aW1lIHRoZSBkZWJpYW46dW5zdGFibGUtYXJt MzItZ2NjIGNvbnRhaW5lciBpcyB1c2VkPyBJbmNsdWRpbmcNCj4+PiBkZWJpYW4tdW5zdGFibGUt Z2NjLWFybTMyLXJhbmRjb25maWcgYW5kDQo+Pj4gZGViaWFuLXVuc3RhYmxlLWdjYy1hcm0zMi1k ZWJ1Zy1yYW5kY29uZmlnPw0KPj4+DQo+Pj4gSSByZWFsaXplIHRoYXQgdGhlIG90aGVyIDIgam9i cyBhcmUgcmFuZGNvbmZpZ3Mgc28gSFlQRVJWSVNPUl9PTkxZIGdldHMNCj4+PiBzZXQgYW55d2F5 LiBCdXQgaWYgSFlQRVJWSVNPUl9PTkxZIGlzIGEgcHJvcGVydHkgb2YgdGhlIHNwZWNpZmljDQo+ Pj4gY29udGFpbmVyLCB0aGVuIEkgdGhpbmsgaXQgd291bGQgYmUgYmVzdCB0byBiZSBjb25zaXN0 ZW50IGFuZCBzZXQNCj4+PiBIWVBFUlZJU09SX09OTFkgZXZlcnl3aGVyZSBkZWJpYW46dW5zdGFi bGUtYXJtMzItZ2NjIGlzIHVzZWQuDQo+Pj4NCj4+PiBFLmcuIG9uZSBkYXkgd2UgY291bGQganVz dCByYW5kY29uZmlncyB0byBidWlsZCBhbHNvIHRoZSB0b29scyB3aXRoIGENCj4+PiBzaW1wbGUg Y2hhbmdlIHRvIHRoZSBidWlsZCBzY3JpcHQgYW5kIG90aGVyd2lzZSB3ZSB3b3VsZCBuZWVkIHRv DQo+Pj4gcmVtZW1iZXIgdG8gYWxzbyBhZGQgdGhlIEhZUEVSVklTT1JfT05MWSB0YWcgZm9yIHRo ZSBvdGhlciAyIGpvYnMgdXNpbmcNCj4+PiBkZWJpYW46dW5zdGFibGUtYXJtMzItZ2NjLg0KPj4g T2ssIHNvIHdlIHdhbnQgNCBIWVBFUlZJU09SX09OTFkncyBpbiB0b3RhbCwgb25lIGZvciBlYWNo IGluc3RhbmNlIG9mDQo+PiBDT05UQUlORVI6IGRlYmlhbjp1bnN0YWJsZS1hcm0zMi1nY2MgPw0K PiB5ZWFoDQoNCkNhbiBJIHRha2UgdGhhdCBhcyBhbiBSLWJ5L0EtYnkgdGhlbj8NCg0KfkFuZHJl dw0K From xen-devel-bounces@lists.xenproject.org Wed Jan 04 01:55:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 01:55:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470913.730581 (Exim 4.92) (envelope-from ) id 1pCszj-0005gR-CV; Wed, 04 Jan 2023 01:55:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470913.730581; Wed, 04 Jan 2023 01:55:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCszj-0005gK-9l; Wed, 04 Jan 2023 01:55:07 +0000 Received: by outflank-mailman (input) for mailman id 470913; Wed, 04 Jan 2023 01:55:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCszi-0005gE-B7 for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 01:55:06 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ced283a4-8bd2-11ed-91b6-6bf2151ebd3b; Wed, 04 Jan 2023 02:55:04 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 758B4B810C0; Wed, 4 Jan 2023 01:55:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2607BC433D2; Wed, 4 Jan 2023 01:55:02 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ced283a4-8bd2-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672797303; bh=ffuO8QeritqlgaKdGOBoioav+yKqzjNsb4dskCyqBb8=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=L7hAeJKvvlPDYcxVj3sFPfF86oYhORzOJwl/Me2JplsVNNK+fGuKtYuubuxIS/k8i mRJ84ngqn4rsvTjpomeuxiwEAvBVEkAatTxiQEj2huX4lqQ3eNBX8JgBDR3zrIlbia Uz/9QpPJYxvM1cRNTbKFlSqmzk4s72uqBjnvC47G8C27alJO8hrp9noAvlJxTBcDeB JEgGoodtyh3lQ452D8o2xRbd0vXB+fEoddymctdsQEtMcFuBfC1X9Qb72STOhQA44v 3byRAO+YADkzuTkL9rjr9dodVLY//Wr+2Id+tkBIIYXcdWUNZPnMS4xDBKnThe8kVX EYw4oYLQwetvA== Date: Tue, 3 Jan 2023 17:55:00 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Andrew Cooper cc: Stefano Stabellini , Xen-devel , Doug Goldstein , Anthony Perard , Michal Orzel , Oleksii Kurochko Subject: Re: [PATCH 4/6] CI: Express HYPERVISOR_ONLY in build.yml In-Reply-To: <5d3ed12e-3c01-5ea8-8d41-4a199fdf92b7@citrix.com> Message-ID: References: <20221230003848.3241-1-andrew.cooper3@citrix.com> <20221230003848.3241-5-andrew.cooper3@citrix.com> <34e692e3-ef76-a43e-ec4f-a7c1ed2d094f@citrix.com> <4f9a9927-c287-b40e-e4b0-653e69dbc1bb@citrix.com> <5d3ed12e-3c01-5ea8-8d41-4a199fdf92b7@citrix.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 4 Jan 2023, Andrew Cooper wrote: > On 04/01/2023 1:48 am, Stefano Stabellini wrote: > > On Wed, 4 Jan 2023, Andrew Cooper wrote: > >> On 04/01/2023 1:36 am, Stefano Stabellini wrote: > >>> On Wed, 4 Jan 2023, Andrew Cooper wrote: > >>>> On 04/01/2023 1:15 am, Stefano Stabellini wrote: > >>>>> On Fri, 30 Dec 2022, Andrew Cooper wrote: > >>>>> > >>>>>> Whether to build only Xen, or everything, is a property of container, > >>>>>> toolchain and/or testcase. It is not a property of XEN_TARGET_ARCH. > >>>>>> > >>>>>> Capitalise HYPERVISOR_ONLY and have it set by the debian-unstable-gcc-arm32-* > >>>>>> testcases at the point that arm32 get matched with a container that can only > >>>>>> build Xen. > >>>>>> > >>>>>> For simplicity, retain the RANDCONFIG -> HYPERVISOR_ONLY implication. > >>>>>> > >>>>>> Signed-off-by: Andrew Cooper > >>>>>> --- > >>>>>> CC: Doug Goldstein > >>>>>> CC: Stefano Stabellini > >>>>>> CC: Anthony PERARD > >>>>>> CC: Michal Orzel > >>>>>> CC: Oleksii Kurochko > >>>>>> --- > >>>>>> automation/gitlab-ci/build.yaml | 2 ++ > >>>>>> automation/scripts/build | 11 ++++------- > >>>>>> 2 files changed, 6 insertions(+), 7 deletions(-) > >>>>>> > >>>>>> diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml > >>>>>> index 93d9ff69a9f2..e6a9357de3ef 100644 > >>>>>> --- a/automation/gitlab-ci/build.yaml > >>>>>> +++ b/automation/gitlab-ci/build.yaml > >>>>>> @@ -516,11 +516,13 @@ debian-unstable-gcc-arm32: > >>>>>> extends: .gcc-arm32-cross-build > >>>>>> variables: > >>>>>> CONTAINER: debian:unstable-arm32-gcc > >>>>>> + HYPERVISOR_ONLY: y > >>>>>> > >>>>>> debian-unstable-gcc-arm32-debug: > >>>>>> extends: .gcc-arm32-cross-build-debug > >>>>>> variables: > >>>>>> CONTAINER: debian:unstable-arm32-gcc > >>>>>> + HYPERVISOR_ONLY: y > >>>>> can you move the setting of HYPERVISOR_ONLY to .arm32-cross-build-tmpl ? > >>>> Not really - that's the point I'm trying to make in the commit message. > >>>> > >>>>> I think that makes the most sense because .arm32-cross-build-tmpl is the > >>>>> one setting XEN_TARGET_ARCH and also the x86_64 tag. > >>>> It's not about x86_64; its about the container. > >>>> > >>>> Whether we can build just Xen, or everything, solely depends on the > >>>> contents in debian:unstable-arm32-gcc > >>>> > >>>> If we wanted to, we could update unstable-arm32-gcc's dockerfile to > >>>> install the arm32 cross user libs, and drop this HYPERVISOR_ONLY > >>>> restriction. > >>> If it is a property of the container, shouldn't HYPERVISOR_ONLY be set > >>> every time the debian:unstable-arm32-gcc container is used? Including > >>> debian-unstable-gcc-arm32-randconfig and > >>> debian-unstable-gcc-arm32-debug-randconfig? > >>> > >>> I realize that the other 2 jobs are randconfigs so HYPERVISOR_ONLY gets > >>> set anyway. But if HYPERVISOR_ONLY is a property of the specific > >>> container, then I think it would be best to be consistent and set > >>> HYPERVISOR_ONLY everywhere debian:unstable-arm32-gcc is used. > >>> > >>> E.g. one day we could just randconfigs to build also the tools with a > >>> simple change to the build script and otherwise we would need to > >>> remember to also add the HYPERVISOR_ONLY tag for the other 2 jobs using > >>> debian:unstable-arm32-gcc. > >> Ok, so we want 4 HYPERVISOR_ONLY's in total, one for each instance of > >> CONTAINER: debian:unstable-arm32-gcc ? > > yeah > > Can I take that as an R-by/A-by then? yep From xen-devel-bounces@lists.xenproject.org Wed Jan 04 06:29:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 06:29:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470922.730593 (Exim 4.92) (envelope-from ) id 1pCxH1-00088F-Ui; Wed, 04 Jan 2023 06:29:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470922.730593; Wed, 04 Jan 2023 06:29:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCxH1-000888-RK; Wed, 04 Jan 2023 06:29:15 +0000 Received: by outflank-mailman (input) for mailman id 470922; Wed, 04 Jan 2023 06:29:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCxH0-00087y-6X; Wed, 04 Jan 2023 06:29:14 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCxH0-0004WC-4n; Wed, 04 Jan 2023 06:29:14 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCxGz-00022C-Ie; Wed, 04 Jan 2023 06:29:13 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pCxGz-0003xp-Fq; Wed, 04 Jan 2023 06:29:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=yBqAwBtZh4rt+py5r6h+d+4HmZXNp1GHJ2AzfZUrLNc=; b=Q1QvNqnpX41IHQKkcdxnFaz9FH HqtndwwgcDWQzUos2HZAqPSep1NpUBLCEG08UBS8rUbjqqpcyb7vqP/SM9eVrOjj0dBoRF8xxK4im 5Src9v2NBrPDlF0sqZ9lXmcBUjHaGg+N4+0W8iyZgQTFIPveD5hd7cdrItVacOYGSSUw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 175563: all pass - PUSHED X-Osstest-Versions-This: ovmf=89c5d90003d9c54d03d3e85bd305718e9c29a213 X-Osstest-Versions-That: ovmf=b670700ddf5eb1dd958d60eb4f2a51e0636206f9 From: osstest service owner Date: Wed, 04 Jan 2023 06:29:13 +0000 flight 175563 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/175563/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 89c5d90003d9c54d03d3e85bd305718e9c29a213 baseline version: ovmf b670700ddf5eb1dd958d60eb4f2a51e0636206f9 Last test of basis 175558 2023-01-03 06:41:58 Z 0 days Testing same since 175563 2023-01-04 02:10:49 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Gua Guo jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git b670700ddf..89c5d90003 89c5d90003d9c54d03d3e85bd305718e9c29a213 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Jan 04 08:19:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 08:19:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470934.730603 (Exim 4.92) (envelope-from ) id 1pCyzR-0002m6-1y; Wed, 04 Jan 2023 08:19:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470934.730603; Wed, 04 Jan 2023 08:19:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCyzQ-0002lz-Ve; Wed, 04 Jan 2023 08:19:12 +0000 Received: by outflank-mailman (input) for mailman id 470934; Wed, 04 Jan 2023 08:19:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCyzP-0002lt-4d for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 08:19:11 +0000 Received: from sonic308-54.consmr.mail.gq1.yahoo.com (sonic308-54.consmr.mail.gq1.yahoo.com [98.137.68.30]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 741a636f-8c08-11ed-91b6-6bf2151ebd3b; Wed, 04 Jan 2023 09:19:08 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic308.consmr.mail.gq1.yahoo.com with HTTP; Wed, 4 Jan 2023 08:19:04 +0000 Received: by hermes--production-bf1-5458f64d4-rkcp4 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID c7ed076b62267adadaa8fddc1f12ac2c; Wed, 04 Jan 2023 08:19:02 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 741a636f-8c08-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1672820344; bh=jItkp3Ywrhodg9IS7x5pkpdm6AjC+m6vJyEcdHBOpiU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=R0dkFiTFtn40tuRMVlNGzdofL2Lt95wFM25rBh1mdMpO7n88cuIwpQGTvHLt08TTDqYNl/9ycnCrDPtzK6GFyBH0q7KrXXgmTVLrnZlolzgeCZBa1FfHqMlkA16lU4GVlK/FHJNbhYbv/nzTs6As0p84Rvzvi4qfj4SnOBO0PRiP4AVIYxFNFwbNOeaBf+GAwlHwtJ9j+TwS3MpVHE15yDOd3v2p+OvhPsqxIaTbeXS/4/j9Q/pqq+TxpjwWGQF61K5bzSMGpGRAevYYErQm/haAncRIZX6rYKdLpuoRg69EbUWUj1phnXTtX6QppsecHVXRJBDl26cBlZnyEwSa5Q== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1672820344; bh=7hgLgK60MMH0sdqTp22ESPXOA7a2xV2NLOYU1/ccyc9=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=W+7gxxwUWLe9DWK7TCCV7Kj2Ru3dwKsB7QMCTFx6k4cq0j+lReoursm950uVpho3KMki3iHxsvmevlg4AmBSGq9MJxNVNIeWmjHYfQ8FnilFJDSGy1GDiT50TsEXldBsT1yFZJxYjyYfROZOh/wFjXwMzhApjSP/2IhgyqfZFSoZVSkQHVtiKuTf8gHWBEwLiX4Nxdw3Nofa2r3Geeef1UE94y9VRekxvu0WC/Ghi0z/l9v16AaG0sOimRu+xoFGf7BK1fRfCY9MKFuFjVrhmdTovRMrOayoY2mUoJVuaDLyZc+E+1KpsBQWlpNS+PoH5gkUWQOE1QS9zI1cHIrWjw== X-YMail-OSG: EFRbsZcVM1kycu_tVwkZa8YorSJ.0VupyH.WmI86cP2UGP_8F1MD0ctMb3h.Cl3 BSiL3iWc9.j4Awwxbe0ni3pOHwXBcRg__QKKlcWqTWXrmiWdmIC6cnXXLxMtLJztXCxim5SJp7a3 Iy7dHw8tG0sfVn57FPhydkaMpgOctrtT458QnHjePK1B3tEcuPHsU.qThFCfqIaK6j9kn1q2bsnI CtbkrZwUpmrXELKMWowWsw38LR8m8BSia5wopoxoZ6SPNWT4pF5x_HerYEvE35TBhg6P6jYLfqmX soKpiAI04X2ajYBd.UsTcyqePzMH9vw6zhO8NoZtBZbb7VbAFAs4nUJnd3j8HgYUusf7j.7rCpHM XyqHy338tKG.yZrzMnbT2OnYoX0VA_t8SMQQ_cuTvaXysa_To4tXsS_B7Oj8Qi1yGVlhEfT953Ru WHgNkDDms7MM5OWgVokzumIri4InTnSPGKSGPgTP8maNky0Hp7gyR6RdWGCsleYVdaGAsQ1qeoYr 7YL7zTndySyTHFDavpg4bwdvL7o3UDa4SaZfI4kDqsspfJBreT1r13.8wrEkyNWiSsRlZd_e9jDA _JKue73h00sgDlqzhnP0dpNSwi8tDoCoYK.93F3mPumZ4Dk23vUmKmv_oU33OypLTHmXtzohZgvt Qvtvtwai4_sbgOpq42ibWTOUc5QLi_5ARES1BlYCotUcBGTR4uEGul36FUVHUB1lNTCqd1hpP9oW OtSWNjvs276Cr2xNPaK0fzTFpiCxqIHhipm8GBDHjUUazL9AZX_2YB7kMW33bbTOvbKInmQUD83o 64bTY5AckLzeU5N0KgnL2W2X9qbO3ITnbVYhz.Qf1DuVAAmIiC0aRGdHcBrcY54oYHxQTCcV5_pC .hNIj4tWc4cAL2G0xgbM_HEKyCHbW5AqcvNHkDtak2QjtdJAgk3JQXQGVFRoJ9ZubdcuqksNwi0V A9ptTT11noqBMma1VtDS.24pfTI8AWiq_ulT_1f8iTBbHd0qT2jBeg3pC1ahDtzSxA_UIl7PBe1m iQ.XhpUggqbKJ6bGUClwaX_vji3rZ1SCU69Y2X.Z9ETDILMbgaU08FY_CUB7OEtip1wTHaSFXAdt naLTlwOjqk54MrOE6z624Ue6gQdZI_brLyQ6nb88mH8PrCXUkkFXOyeBQu.b_aR7SJNdGq1CYQaA oET4_Gqh2FUYAUYqZwx3S2ouDBXQIGN1ucikG8bP9Cwx4zf_ONu6V7exlLAa746Kfirc.Kdcont_ gb3Xoz5D8klhWL4paq4DpJItmWZatesgmG4Njo23s5Nzw7_pGXrlvZo2U.dqVJrfEorDafltK5H5 av6eSAapz8XY5ihOtSG_0TIHBVr_yNWEBXS3dXIaZFJ_jRA3iBxh2wYbo1Gl9UkRLT41sohS5i_9 GGkc7QDLdVv1239T0_MSTA9eOQKBgXMWW6rtIPNj_hkoMgcGE_6SKYy7nF036J3UcmFK.2nJGjqL su26fCX_viP87c7P8K3uLUsvkGqS2quhHr8xZl8g5KDOgiWrJWtIoupKtMfLbTdtKrh0uwe1LRq6 h6B.qzaIpKUPGBEnhGR61Tf72pPzDdlD8eMRlMAZ__uelm07BW.KihWJKjF9CY_fvIcEImJfT3pw F5AZTLvph6B8ivOyH5.PYvob96N.k2vQcUDffQGemIqI6v3DKDWN01_XWsWPki1FELppkuv6Se9W 1Op5kHBFLc4c2Un0x0LzQI8rkFNeXPBz7QQZNp0_5FCE6bQOMpQul_yC7ECXHyNZN4z_u8wfgvrt 0bXXZ_ef_B3OPiAj6rAIGdhOCEiz5Sru.qB3Cz_VfXBD3AW.nmC.tJtedP7bxp2.nxIwGNS7pfg6 CfzJHBPiTmTUu7hT_eRsB3mpF4j1W09Sz21582ELRXMF5.TRHwHdzOMcTtOWMs5aHre54l0qtUf3 kg6CAHhZs0BpU6YIWK62X7YR6r.wydoeqMNVb95fNM3tvgq6WAn54t_EHRDAL2TikB5P8ijgk3aV c679_jV1I29kxOKi.7mfVZmS35WjoutTF0Wag5FYQ8G8AZq5KDR9OrrIssQes2Yb8DrRi.LFMDz1 Bf71VHxT8Sw7tfBn_8X1Sx0GcvW12opvBnlJNppzUaZgfGavviXdI4Zx37gR_nr0dcNFXavbJbF8 K76kryuS7ewg_4ETxjuiKxMhqwJQUIRNYuMUXJ6FYZ_A44wIGwYYGpMAs.sCkYm9G2NmEKAId_DS BoFmj2yyfdUv75V0TRxxBc3ec X-Sonic-MF: Message-ID: Date: Wed, 4 Jan 2023 03:18:59 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 0/6] Resolve TYPE_PIIX3_XEN_DEVICE Content-Language: en-US To: Bernhard Beschow , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Cc: qemu-devel@nongnu.org, Paul Durrant , Marcel Apfelbaum , "Michael S. Tsirkin" , Stefano Stabellini , Anthony Perard , Aurelien Jarno , Eduardo Habkost , xen-devel@lists.xenproject.org, =?UTF-8?Q?Herv=c3=a9_Poussineau?= , Paolo Bonzini , Richard Henderson References: <20230102213504.14646-1-shentey@gmail.com> <0de699a7-98b8-e320-da4d-678d0f594213@linaro.org> From: Chuck Zmudzinski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.20982 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 6141 On 1/3/2023 8:38 AM, Bernhard Beschow wrote: > > > On Tue, Jan 3, 2023 at 2:17 PM Philippe Mathieu-Daudé wrote: > > Hi Chuck, > > On 3/1/23 04:15, Chuck Zmudzinski wrote: > > On 1/2/23 4:34 PM, Bernhard Beschow wrote: > >> This series first renders TYPE_PIIX3_XEN_DEVICE redundant and finally removes > >> it. The motivation is to 1/ decouple PIIX from Xen and 2/ to make Xen in the PC > >> machine agnostic to the precise southbridge being used. 2/ will become > >> particularily interesting once PIIX4 becomes usable in the PC machine, avoiding > >> the "Frankenstein" use of PIIX4_ACPI in PIIX3. > >> > >> Testing done: > >> None, because I don't know how to conduct this properly :( > >> > >> Based-on: <20221221170003.2929-1-shentey@gmail.com> > >>            "[PATCH v4 00/30] Consolidate PIIX south bridges" > > This series is based on a previous series: > https://lore.kernel.org/qemu-devel/20221221170003.2929-1-shentey@gmail.com/ > (which itself also is). > > >> Bernhard Beschow (6): > >>    include/hw/xen/xen: Make xen_piix3_set_irq() generic and rename it > >>    hw/isa/piix: Reuse piix3_realize() in piix3_xen_realize() > >>    hw/isa/piix: Wire up Xen PCI IRQ handling outside of PIIX3 > >>    hw/isa/piix: Avoid Xen-specific variant of piix_write_config() > >>    hw/isa/piix: Resolve redundant k->config_write assignments > >>    hw/isa/piix: Resolve redundant TYPE_PIIX3_XEN_DEVICE > >> > >>   hw/i386/pc_piix.c             | 34 ++++++++++++++++-- > >>   hw/i386/xen/xen-hvm.c         |  9 +++-- > >>   hw/isa/piix.c                 | 66 +---------------------------------- > > > > This file does not exist on the Qemu master branch. > > But hw/isa/piix3.c and hw/isa/piix4.c do exist. > > > > I tried renaming it from piix.c to piix3.c in the patch, but > > the patch set still does not apply cleanly on my tree. > > > > Is this patch set re-based against something other than > > the current master Qemu branch? > > > > I have a system that is suitable for testing this patch set, but > > I need guidance on how to apply it to the Qemu source tree. > > You can ask Bernhard to publish a branch with the full work, > > > Hi Chuck, > > ... or just visit https://patchew.org/QEMU/20230102213504.14646-1-shentey@gmail.com/ . There you'll find a git tag with a complete history and all instructions! > > Thanks for giving my series a test ride! > > Best regards, > Bernhard > > or apply each series locally. I use the b4 tool for that: > https://b4.docs.kernel.org/en/latest/installing.html > > i.e.: > > $ git checkout -b shentey_work > $ b4 am 20221120150550.63059-1-shentey@gmail.com > $ git am > ./v2_20221120_shentey_decouple_intx_to_lnkx_routing_from_south_bridges.mbx > $ b4 am 20221221170003.2929-1-shentey@gmail.com > $ git am > ./v4_20221221_shentey_this_series_consolidates_the_implementations_of_the_piix3_and_piix4_south.mbx > $ b4 am 20230102213504.14646-1-shentey@gmail.com > $ git am ./20230102_shentey_resolve_type_piix3_xen_device.mbx > > Now the branch 'shentey_work' contains all the patches and you can test. > > Regards, > > Phil. > Hi Phil and Bernard, I tried applying these 3 patch series on top of the current qemu master branch. Unfortunately, I saw a regression, so I can't give a tested-by tag yet. Here are the details of the testing I did so far: Xen only needs one target, the i386-softmmu target which creates the qemu-system-i386 binary that Xen uses for its device model. That target compiled and linked with no problems with these 3 patch series applied on top of qemu master. I didn't try building any other targets. My tests used the xenfv machine type with the xen platform pci device, which is ordinarily called a xen hvm guest with xen paravirtualized network and block device drivers. It is based on the i440fx machine type and so emulates piix3. I tested the xen hvm guests with two different configurations as described below. I tested both Linux and Windows guests, with mixed results. With the current Qemu master (commit 222059a0fccf4 without the 3 patch series applied), all tested guest configurations work normally for both Linux and Windows guests. With these 3 patch series applied on top of the qemu master branch, which tries to consolidate piix3 and piix4 and resolve the xen piix3 device that my guests use, I unfortunately got a regression. The regression occurred with a configuration that uses the qemu bochs stdvga graphics device with a vnc display, and the qemu usb-tablet device to emulate the mouse and keyboard. After applying the 3 patch series, the emulated mouse is not working at all for Linux guests. It works for Windows guests, but the mouse pointer in the guest does not follow the mouse pointer in the vnc window as closely as it does without the 3 patch series. So this is the bad news of a regression introduced somewhere in these 3 patch series. The good news is that by using guests in a configuration that does not use the qemu usb-tablet device or the bochs stdvga device but instead uses a real passed through usb3 controller with a real usb mouse and a real usb keyboard connected, and also the real sound card and vga device passed through and a 1920x1080 HDMI monitor, there is no regression introduced by the 3 patch series and both Linux and Windows guests in that configuration work perfectly. My next test will be to test Bernhard's published git tag without trying to merge the 3 patch series into master and see if that also has the regression. I also will double check that I didn't make any mistakes in merging the 3 patch series by creating the shentey_work branch with b4 and git as Phil described and compare that to my working tree. I also will try testing only the first series, then the first series and the second series, to try to determine in which of the 3 series the regression is introduced. Best regards, Chuck From xen-devel-bounces@lists.xenproject.org Wed Jan 04 08:31:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 08:31:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470941.730615 (Exim 4.92) (envelope-from ) id 1pCzBQ-0005GZ-6Q; Wed, 04 Jan 2023 08:31:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470941.730615; Wed, 04 Jan 2023 08:31:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCzBQ-0005GS-3J; Wed, 04 Jan 2023 08:31:36 +0000 Received: by outflank-mailman (input) for mailman id 470941; Wed, 04 Jan 2023 08:31:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCzBO-0005GM-HP for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 08:31:34 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2066.outbound.protection.outlook.com [40.107.20.66]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 31016a85-8c0a-11ed-b8d0-410ff93cb8f0; Wed, 04 Jan 2023 09:31:32 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by GV1PR04MB9184.eurprd04.prod.outlook.com (2603:10a6:150:28::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Wed, 4 Jan 2023 08:31:29 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5944.019; Wed, 4 Jan 2023 08:31:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 31016a85-8c0a-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AhmVTYpDTRaBjXq/UucI1FyAs2XNrVS6bLwWz3aShLhOjYoEkr8tP1c0M43vNP/la8Qv9/IkDrEsdiO4mOgXrIozrLcRZYrEgsPQNpftS9TAAnLY77tQSKi3Yl4kg92v/P/6iOhJTfU4cZinL5dKS/6wuUd2uUeWYDiyzv0E5pimdQsAyqzJ/5I505q+NPjnp0ua+2HzxA9Ipu00q+2y/ZCPgZGu7mKRXhdO4mK7Bong8MaBJE+ilYJdsgpJJpYYOySdI5FhrUsEPwF3MyCzHidfhq1pop9+eDa0kRfhdE29w2SMtinTOFUeo1nuBcTur+aLui1G77xP3Sh6ARAY5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=z41OvX2AvLdrMyeP19C5M5ObnBSWq+4jnWayoWtdC5o=; b=We773hljTbjK8ZKrA3JZDlbadZIFZxVjsQR7qKoo234ApGdQiAEVdblUMYajdWXphjSJGmOw6YkENYNWTVa+7lSbjEbD9g2qv5s/NeY7Qiwd9/EzaN9IglfGcxGSpVvBleg0cZNDDPXg16b50Eln29OHuVVRRD2yF/Mvc1BJW+7iod0nRiB4+vgdAFDvyprD3GT4aKKjuVytS2YGLTGY78WO4Lj80Co8KAWfvdYie30n9IhwNGDpkAzd9e0JOZx2eDXni8RlW2BcFv6LLf6mcl6dVkx4DH1AszCA1rStOb7oiigI8jAw+yvg5FLHvw48IEihM+DG8YxyxS0vc9jxaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z41OvX2AvLdrMyeP19C5M5ObnBSWq+4jnWayoWtdC5o=; b=AvhZjc9J9eFFbOZDESWCbr1HSPJKsDVkPqFpBH1QDJKqb31wYtdkDLMOy4trS/NNDYsEgMyARb0e7nT0eS+wUhPlBIrIOu0EJ/yxQkDR8fPon0EQBpRX+7tVWTBKzAMDTgCwfPbTHiYjEztaGUlJfIPLVQDoCFmgWq9RAbWxs209hUKAe3NIyTyBIZsdOyjKIVXUkO2SOi+34ZdensLg+3QhchJyeCfGkhgg4yrlnmsLRCKHKpdNElLM4YH0dJJT/pZuhPhhRfs7KdnSehZOIMRvVa+fLlz4Szd9u+U+PI9GzpiGFd4KyewZVQK1P/BkR+2BLUAD6OcmJE7EYFfeWA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 4 Jan 2023 09:31:36 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] x86/xen: Remove the unused function p2m_top_mfn_init() Content-Language: en-US To: Jiapeng Chong Cc: boris.ostrovsky@oracle.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, Abaci Robot , jgross@suse.com References: <20221227082115.59000-1-jiapeng.chong@linux.alibaba.com> From: Jan Beulich In-Reply-To: <20221227082115.59000-1-jiapeng.chong@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0036.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|GV1PR04MB9184:EE_ X-MS-Office365-Filtering-Correlation-Id: cd1917cb-0d3f-40d4-4fa3-08daee2e135c X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DWcvrHrMnjOII81DDVjEyJdJVEs7u/2MNMiU3lvKq2yPJSRgpQdDASpuCF1PZWH8Bqm+6aFdJTnye/IVSi2qvNkwn6+bnDT39RXpSHFaAUr/n9Fy1/qextCvH2DY5vj/uA0zeWBCZtwEpK0tsog2ncyhdkVoPb5RFL4HOUyriJLZyYpYI+TTnf95Tlf8D2LWc+yMYogWRqwZKoempsf0R8VQemXdnYOy/NzXbZeWXrJ9GVzAFH4QeuUDNBPCqBeYF1ItDa2HPovsjFBHjdd98h1lL3PzYr/qvnlS2M3IkVaqknt50bcEPwJvAwDpeG3RVI4pVfAgp9Gce8n7nkcvbL5gSI3ZI7M4BAZeE5zUeqPu6i30WH5Sxn+3h96WEXJiBSopvH0gDYxyq+kTEs6DErVOHMp2Iq/O6qcozBEwrVJo8+ya3iB6QsNg5/PQE4xh0uO/IPEFzNI2m3zHWPrhLeC2iTgzE2ko5BThrzLDmSJ1jIfzbJG1uKoRVkUrNYZcxpxwmkVSrkA4XGlCYi+ewOTs7ZijFoXxeHDb4LPJ04I2dPHXB30CQ4xwhMhIhsgiiUQaA17FmGRDQqILG/EU3siqjrcQ8AoSYjgxur0tPRHNS47W9AlrsuNlWLdJRDc4NfMISaLwzvzNI1GLuz0/DGaG+lsbsTP0aUIqeRT4OfcesS0v+if6+n/4U9yuAg6NkI75RQU8iP5NmslX28+IOhIKVWK3W8BOPOfy8bIqDkA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(376002)(136003)(346002)(366004)(39860400002)(451199015)(7416002)(5660300002)(2906002)(8936002)(4744005)(41300700001)(4326008)(478600001)(8676002)(316002)(66476007)(66946007)(6916009)(66556008)(6486002)(31686004)(107886003)(6512007)(26005)(6506007)(6666004)(83380400001)(186003)(38100700002)(53546011)(2616005)(31696002)(86362001)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?amwxeTIrYkJvNUdRVU10MXYvLzk4WWhidndVc2g5S0h1bnNRclVaRXpTTTRj?= =?utf-8?B?MTl5ZHJ0a3BwWkpxREZqc2dzSWpYaDZYM1NzSThDSFYzQ3p0MUNRZnFFdjl3?= =?utf-8?B?ckNISkZ3QVVjRFdWODZ0K2pxSUhPVitGYnllZEFJZFc3eis1RHl5dGJxdEtJ?= =?utf-8?B?NS9EUlhuNTF1cWg0WWxyaWRjMTluTmpPVEV1eDk3L2NiTG9pQU40S0VmQllk?= =?utf-8?B?aFRrb0NQcjFOR1I1OS9qNHMrMmJ1VTcvWmFJcy9YVGhwV0ZKeTdNUzFrSkJT?= =?utf-8?B?WkdlaGZBS0twN0p0M3I5QWs1QXp4dElWMjZ1Rm12Qkgxak5EWjdGQzNDZkln?= =?utf-8?B?QmYzTmplVUdFWDdPaERyWDVzNm9XUmI3TEJtUDhNSkpMM0NiYnZBU1RKY2dG?= =?utf-8?B?Unc3OE5TZ0gyazJzZXJpZVR3UjFHWjNUQUtuL1czbnNPcUhtbkRxd3FoQWc4?= =?utf-8?B?N3pyMGQrditOZzAxcU5CbnV6aXU2b01DaUVzQTkwVzJwektNU1ZZUldTS1Yz?= =?utf-8?B?UXJwNDZRamkycEhNaXBVQml6Q2xLZ0M0bWtyTStIdUZuc1Q1NUEvS0tZWE8x?= =?utf-8?B?TTRQYUQ2RFRwNmhXWlJabkk1Vmw2N2FTWExLSlpPRUJUbjdmczlsV05uSHph?= =?utf-8?B?Qk9zVk5NU0N0VTh5RnFqWUdFa2F0M3owMzRtcEJVWTlkU2Ruc2RBNzVOZklU?= =?utf-8?B?dVBkYW4veitZN0ZtRU1vaUlrcVdXWUI3ckJWeVF4eEZaWUFxbmtiQkNiRzZw?= =?utf-8?B?Mi9jdTVtV2VabFdLRGY5OVZQd0ZrVXN1bW5ZRUpXWTVVRWI4aWVUMENFZ2Ir?= =?utf-8?B?bFJ1d21oU01BOWR0NC9lMTNSMXlRYkJKRlRQUzdEZnpseHBBWC9NMVRibjFJ?= =?utf-8?B?UWZoSVQ0aC84RzcxNVhzR2JjMnJnN0ZJak9ZVzlPVUxnbnUzRmdMajhZdGRq?= =?utf-8?B?SUJuRy83YzdVendYZG91bU96RjdUZEFGM2VOUXpPc0cwNSs5bm56cHVjaC92?= =?utf-8?B?clh4b25BcEozeGdDOVBsN3JEUkN2azNRazluak5mNDRkNXcrcHp0UitWLzk3?= =?utf-8?B?SU1PQXRPL0dVeE5KYjAwUWpORDBBd1lJYmRtajNqMkxLZkJjSzkxaEJVQWl4?= =?utf-8?B?Y1QwaGxHblB3dHB0aXNBbzhLOTJjZzRsbThYY2NFUG5KUmY5RTFQaUI0dlJ4?= =?utf-8?B?NHZvT0N0c28xSkxFQTJVbFlXYnhDSXhud3prOFJua3dmdU5Rdkx1TnhRemYy?= =?utf-8?B?U0ZkZExaL0ZwbXEvQkZZUXpQdVhGYXNqSldSejZDN3JXMXpsVlJDMXl4NXUy?= =?utf-8?B?WFJjRWFlVC9WRHYzYTZBQUw3dTkvNjIxQ2x0SnRwNjd0TElidzlCSlFPbDhB?= =?utf-8?B?WFoyQ2x5WEREeHhIcFY3bjJ4cm1Ta0xGc3RBeVgyWWgrdXhGVEh4OTdzUmZT?= =?utf-8?B?ZXppYlFQcXZZQ0orNklaYXUyTEE1Y0hKRFpIV0M3WjNGOXp5WDlsdGJNdFUy?= =?utf-8?B?cU5BRjByd3Q0VE5NTnFmNUFZc01XMWxianJETDZib0xWdEVPTFUrQkRGSTJH?= =?utf-8?B?QXVCNkhPRElNK3RuVnFlRmkwMHczelNCcy9aMTh2L0lld2JkeU1PMEZZdVFV?= =?utf-8?B?TjdVMGx3K0cyL2lDSjJoc1EvMXdFanJBMXFMSXd1aXh4ZWMvc09HZFFFMERu?= =?utf-8?B?bUNRNUFuWlJDdGpkUHJLNWpRVys2aXEzYmdvNXR5TWpjeld3VlBLdEJKUVJ0?= =?utf-8?B?aUZtRFdsOHV0NEt2bXpKaTNoUGZ1d3B0bHBzUHNnajlhOHhickNSSEZhV1du?= =?utf-8?B?TlV3M0p0ZWI1a3lUVVEzaFkrWElLU3RWdERxNnoweHZlOFE5MHFZU0hOUUIv?= =?utf-8?B?akc5MVNRUXlOdG1Fc1BZVFJ2Q1VKRVhORVl3cVIzRkZoOHpYelN0TWVsOEpE?= =?utf-8?B?SnlHSkVQU00xUkd6YTEwTWNGWStIcHEzUTJhaWlQQkwxOVFUQ1BRT1d3VEZa?= =?utf-8?B?UnM3WFBSTE85SXczWlBnU3Zsb2FSNjNxb0pvRVV2UUgxMzJFcnRZTGRGU0gx?= =?utf-8?B?d3hTbTZGSkNlRlU0blpPQU4ydlU0SklxMkVFNTVNUUp1dEg5dHFEU3ByMCtL?= =?utf-8?Q?8cvKfQwAD9WGYm62juxevJCia?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: cd1917cb-0d3f-40d4-4fa3-08daee2e135c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2023 08:31:28.9100 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IBkh0DLcUpcMeaJVX9kUPlG4J1KxVRuuIppJcLnNmBFHVQ4N3k0bx2RaDHbfHEY5b5zPj38orMojAfstZ+Kn5g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9184 On 27.12.2022 09:21, Jiapeng Chong wrote: > The function p2m_top_mfn_init is defined in the p2m.c file, > but not called elsewhere, so remove this unused function. This and the title are wrong - p2m_top_mfn_init() is used by xen_build_mfn_list_list(). > arch/x86/xen/p2m.c:137:24: warning: unused function 'p2m_index'. Whereas this and the actual code change look correct to me. Jan From xen-devel-bounces@lists.xenproject.org Wed Jan 04 08:32:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 08:32:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470947.730642 (Exim 4.92) (envelope-from ) id 1pCzBw-0006A5-RE; Wed, 04 Jan 2023 08:32:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470947.730642; Wed, 04 Jan 2023 08:32:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCzBw-00069y-OX; Wed, 04 Jan 2023 08:32:08 +0000 Received: by outflank-mailman (input) for mailman id 470947; Wed, 04 Jan 2023 08:32:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCzBv-0005oA-N4; Wed, 04 Jan 2023 08:32:07 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCzBv-0007qP-LP; Wed, 04 Jan 2023 08:32:07 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCzBv-000774-A2; Wed, 04 Jan 2023 08:32:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pCzBv-0004ir-9c; Wed, 04 Jan 2023 08:32:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=SLUaGebJDqEx5zZic8zLR+toRxeS6xh0yZBcvX35n3k=; b=UIz72zw55JroSOXMaI1QI3sPSU KvdyYJpi5e9s8g9QAWtG7V3rAUrL3ti1OxLd7m47c24bi2XBRnFH8tDwZEZVkUtZzihDb2wGsm0B+ AjNTCqsabegA0RcMhOwQ3yz3iJ427gYNSvwyefoW89SxjjoAmP3hHS3eRWpoNsXMc9/A=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 175565: all pass - PUSHED X-Osstest-Versions-This: ovmf=992d5451d19b93635d52db293bab680e32142776 X-Osstest-Versions-That: ovmf=89c5d90003d9c54d03d3e85bd305718e9c29a213 From: osstest service owner Date: Wed, 04 Jan 2023 08:32:07 +0000 flight 175565 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/175565/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 992d5451d19b93635d52db293bab680e32142776 baseline version: ovmf 89c5d90003d9c54d03d3e85bd305718e9c29a213 Last test of basis 175563 2023-01-04 02:10:49 Z 0 days Testing same since 175565 2023-01-04 06:42:15 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Sean Rhodes jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 89c5d90003..992d5451d1 992d5451d19b93635d52db293bab680e32142776 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Jan 04 08:45:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 08:45:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470985.730687 (Exim 4.92) (envelope-from ) id 1pCzOb-0000kE-P5; Wed, 04 Jan 2023 08:45:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470985.730687; Wed, 04 Jan 2023 08:45:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCzOb-0000k7-Ln; Wed, 04 Jan 2023 08:45:13 +0000 Received: by outflank-mailman (input) for mailman id 470985; Wed, 04 Jan 2023 08:45:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCzOZ-0008Pe-JT for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 08:45:11 +0000 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [2a00:1450:4864:20::530]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 192bf692-8c0c-11ed-91b6-6bf2151ebd3b; Wed, 04 Jan 2023 09:45:10 +0100 (CET) Received: by mail-ed1-x530.google.com with SMTP id m21so47531507edc.3 for ; Wed, 04 Jan 2023 00:45:10 -0800 (PST) Received: from uni.router.wind (adsl-57.109.242.233.tellas.gr. [109.242.233.57]) by smtp.googlemail.com with ESMTPSA id k22-20020a170906129600b007c10fe64c5dsm15016382ejb.86.2023.01.04.00.45.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Jan 2023 00:45:10 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 192bf692-8c0c-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FErdG0bpTyu0YrAGq/30Jx78fTnJ4dyc3jWhGGqv2No=; b=qcSJvgIbcIVR8siwzqOdvogq8s0VHZTvIkzMO4poTEVOg2oi34sCvhNjBA68pbp6/c oDYUTImvkzAXzSsv4EEunLBJSB5/Z1RyCpcVyeiopQGkcdFGFVHZOIQGvy4sPsP7dzQ7 oIjr6PInSK5S792qgowN7s9Nkot8vOLo43qTK9FDBWi/p05O6Sex6mx/DpXc0G/1riCB Slw9YvtQRRQm5uxl1zVVddLMM4fWRYsLvX3Dqrbfvy5BG0D4uCCT+B3EL2tg1dlI3Hx9 shVf/l3/rsEHRL14qYRlbC1YAXccLTqlnn6aSv/rlynLQEkp0ECG/O04YL+r6mhV7TeT WcIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FErdG0bpTyu0YrAGq/30Jx78fTnJ4dyc3jWhGGqv2No=; b=WOXSfMjdP0o+diG+ChXXCFPZIz8E98QnYd46Ekcgy/JOTg1iGbPf91eKm3klAI5ifB ZwNOJn3cwxN16wtrStztJbRo7edBRKia0fuST+TVe5aqw3JQR2dcCjJ30VJvvcKSnRoq c4LDxjps/sIqsyXWA5e2voivb9OdWNve6haPaTmZVGsy2qkSBZuTBPjBa4ItnskIWfmE /YtPPSgn6Cok1iYcCJ3qDRvdMgofQBaTmMprUv/HNeGqAhYi5gzrfuCnCIHjLLYG32O+ Ukg2ZoHrttBUVw+j1RaGFXxw5X7Q3+17spA2TGAyy8SEJDaMFjpGIG8DLK3BSTcJqWCD JbmQ== X-Gm-Message-State: AFqh2koky4frLRCSOM61evC5KJjBts9OYBCs7yosFiloSr9rXpO/MpKl Tgbiylzf3xsKwt8/Nty7nsRP5p2A9bY= X-Google-Smtp-Source: AMrXdXtrV1AIwj0GTEIapqRqGaPwRkP//LOEvC89r7CXGAfVOJlmo1Xm/ZybUic50a87TCyZTzoBpQ== X-Received: by 2002:a05:6402:1119:b0:472:46bf:fb3c with SMTP id u25-20020a056402111900b0047246bffb3cmr39919587edv.35.1672821910348; Wed, 04 Jan 2023 00:45:10 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Paul Durrant , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v2 3/8] x86/iommu: iommu_igfx, iommu_qinval and iommu_snoop are VT-d specific Date: Wed, 4 Jan 2023 10:44:57 +0200 Message-Id: <20230104084502.61734-4-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230104084502.61734-1-burzalodowa@gmail.com> References: <20230104084502.61734-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use CONFIG_INTEL_IOMMU to guard their usage in common code. No functional change intended. Signed-off-by: Xenia Ragiadakou --- Changes in v2: - replace CONFIG_INTEL_VTD with CONFIG_INTEL_IOMMU xen/drivers/passthrough/iommu.c | 4 +++- xen/include/xen/iommu.h | 6 +++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/xen/drivers/passthrough/iommu.c b/xen/drivers/passthrough/iommu.c index 998dfaf20d..a2c67a17cd 100644 --- a/xen/drivers/passthrough/iommu.c +++ b/xen/drivers/passthrough/iommu.c @@ -82,11 +82,13 @@ static int __init cf_check parse_iommu_param(const char *s) else if ( ss == s + 23 && !strncmp(s, "quarantine=scratch-page", 23) ) iommu_quarantine = IOMMU_quarantine_scratch_page; #endif -#ifdef CONFIG_X86 +#ifdef CONFIG_INTEL_IOMMU else if ( (val = parse_boolean("igfx", s, ss)) >= 0 ) iommu_igfx = val; else if ( (val = parse_boolean("qinval", s, ss)) >= 0 ) iommu_qinval = val; +#endif +#ifdef CONFIG_X86 else if ( (val = parse_boolean("superpages", s, ss)) >= 0 ) iommu_superpages = val; #endif diff --git a/xen/include/xen/iommu.h b/xen/include/xen/iommu.h index 4f22fc1bed..aa924541d5 100644 --- a/xen/include/xen/iommu.h +++ b/xen/include/xen/iommu.h @@ -74,9 +74,13 @@ extern enum __packed iommu_intremap { iommu_intremap_restricted, iommu_intremap_full, } iommu_intremap; -extern bool iommu_igfx, iommu_qinval, iommu_snoop; #else # define iommu_intremap false +#endif + +#ifdef CONFIG_INTEL_IOMMU +extern bool iommu_igfx, iommu_qinval, iommu_snoop; +#else # define iommu_snoop false #endif -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Wed Jan 04 08:45:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 08:45:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470986.730697 (Exim 4.92) (envelope-from ) id 1pCzOd-000110-1w; Wed, 04 Jan 2023 08:45:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470986.730697; Wed, 04 Jan 2023 08:45:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCzOc-00010r-Uz; Wed, 04 Jan 2023 08:45:14 +0000 Received: by outflank-mailman (input) for mailman id 470986; Wed, 04 Jan 2023 08:45:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCzOc-0008Pf-0S for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 08:45:14 +0000 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [2a00:1450:4864:20::62b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 19fa257a-8c0c-11ed-b8d0-410ff93cb8f0; Wed, 04 Jan 2023 09:45:12 +0100 (CET) Received: by mail-ej1-x62b.google.com with SMTP id u19so80869654ejm.8 for ; Wed, 04 Jan 2023 00:45:12 -0800 (PST) Received: from uni.router.wind (adsl-57.109.242.233.tellas.gr. [109.242.233.57]) by smtp.googlemail.com with ESMTPSA id k22-20020a170906129600b007c10fe64c5dsm15016382ejb.86.2023.01.04.00.45.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Jan 2023 00:45:11 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 19fa257a-8c0c-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mdM0GT8K2NEubn6wx1wh2HmFlgRPGL3ox7yjkbP2cHM=; b=IlyAPSqkdHW7+9UwD5gXGVtDULbpYhhfd0Gx3yvhyrN1hcnLLYpk/M8pLuZh3YGQA5 RsVx5uaz+bOugElYhIBMhtGc3tqbn9YBkmVDrxuCMqWWX/W5oNuPk6DW0mfx8vmvL3HF ENubWWJaVNiyKeqpPIwwuejdwmsFxhgpxr1B0qOLb/mJ/yQinsTqM9N5w7duefO33xzh CxrIrX8vsDWj7A9Pvq8nOW5W7QBLF+SVPuTuHzx+86VaMLDiZtwdhK3Musr1DWA3roXi SaRmbzkQydU5DN5adQlyaJo10MX9fRjb3UDxkTH2wFOytbtjR6qE6Ebm4ZmQd2sZty00 eE/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mdM0GT8K2NEubn6wx1wh2HmFlgRPGL3ox7yjkbP2cHM=; b=ujVkcSyvyXqPUEzNnTKz9NEDyz6evmAWdfIEWrtANAzNhQa+VFsLYIoN81nofZI6hO J9yPis4/OgPsLufkJFyLb8MMX/WTpu4KZX6q6PqcvQBsPHS9G8ApWIu3bFNlNh9aBcMd fpD75xnB0RWP9aD43mDdwSopD5WtKV3ZmHYIV0M8AsCMYzj1EeM+bySilgzzN7SznPnK qFmtD3DAsPVBdvNn9Q28pdP6jYvVofAaBCc8FTsp66rShvPRnHBfgeHrPDc8q+F0mTQ1 mkWNhLyq0c/Ku47e60sy5pQHjEeAVaxuhwAflQrUH/5/94/ASkOcTrN4MPvxXW5kbWYm o7rA== X-Gm-Message-State: AFqh2krDHKuaSvEMjWKXTJOVpOfbxAE0OgnG+FAVj0A6RLn67shxDH7h Lr6frMdaxd8qZBJkYusiGnKOga9DAT8= X-Google-Smtp-Source: AMrXdXsZZgpByDZtDx+HjsyiTiwAs0G3noW3D/xTiatDsGRWMUyXQVuGvHA8kTWk4IDuO3qsJCn9ZA== X-Received: by 2002:a17:907:20b0:b0:7d3:8159:f361 with SMTP id pw16-20020a17090720b000b007d38159f361mr40554936ejb.36.1672821911636; Wed, 04 Jan 2023 00:45:11 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini Subject: [PATCH v2 4/8] x86/acpi: separate AMD-Vi and VT-d specific functions Date: Wed, 4 Jan 2023 10:44:58 +0200 Message-Id: <20230104084502.61734-5-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230104084502.61734-1-burzalodowa@gmail.com> References: <20230104084502.61734-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The functions acpi_dmar_init() and acpi_dmar_zap/reinstate() are VT-d specific while the function acpi_ivrs_init() is AMD-Vi specific. To eliminate dead code, they need to be guarded under CONFIG_INTEL_IOMMU and CONFIG_AMD_IOMMU, respectively. Instead of adding #ifdef guards around the function calls, implement them as empty static inline functions. Take the opportunity to move the declarations of acpi_dmar_zap/reinstate() to the arch specific header. No functional change intended. Signed-off-by: Xenia Ragiadakou --- Changes in v2: - replace CONFIG_INTEL_VTD with CONFIG_INTEL_IOMMU xen/arch/x86/include/asm/acpi.h | 14 ++++++++++++++ xen/include/xen/acpi.h | 3 --- 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/include/asm/acpi.h b/xen/arch/x86/include/asm/acpi.h index c453450a74..ca8529a7c8 100644 --- a/xen/arch/x86/include/asm/acpi.h +++ b/xen/arch/x86/include/asm/acpi.h @@ -140,8 +140,22 @@ extern u32 pmtmr_ioport; extern unsigned int pmtmr_width; void acpi_iommu_init(void); + +#ifdef CONFIG_INTEL_IOMMU int acpi_dmar_init(void); +void acpi_dmar_zap(void); +void acpi_dmar_reinstate(void); +#else +static inline int acpi_dmar_init(void) { return -ENODEV; } +static inline void acpi_dmar_zap(void) {} +static inline void acpi_dmar_reinstate(void) {} +#endif + +#ifdef CONFIG_AMD_IOMMU int acpi_ivrs_init(void); +#else +static inline int acpi_ivrs_init(void) { return -ENODEV; } +#endif void acpi_mmcfg_init(void); diff --git a/xen/include/xen/acpi.h b/xen/include/xen/acpi.h index 1b9c75e68f..82b24a5ef0 100644 --- a/xen/include/xen/acpi.h +++ b/xen/include/xen/acpi.h @@ -206,9 +206,6 @@ static inline int acpi_get_pxm(acpi_handle handle) void acpi_reboot(void); -void acpi_dmar_zap(void); -void acpi_dmar_reinstate(void); - #endif /* __ASSEMBLY__ */ #endif /*_LINUX_ACPI_H*/ -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Wed Jan 04 08:45:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 08:45:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470982.730654 (Exim 4.92) (envelope-from ) id 1pCzOZ-0008Q2-3Z; Wed, 04 Jan 2023 08:45:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470982.730654; Wed, 04 Jan 2023 08:45:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCzOZ-0008Pv-0s; Wed, 04 Jan 2023 08:45:11 +0000 Received: by outflank-mailman (input) for mailman id 470982; Wed, 04 Jan 2023 08:45:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCzOX-0008Pe-Qd for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 08:45:09 +0000 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [2a00:1450:4864:20::62e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 17e4f316-8c0c-11ed-91b6-6bf2151ebd3b; Wed, 04 Jan 2023 09:45:08 +0100 (CET) Received: by mail-ej1-x62e.google.com with SMTP id kw15so80791239ejc.10 for ; Wed, 04 Jan 2023 00:45:08 -0800 (PST) Received: from uni.router.wind (adsl-57.109.242.233.tellas.gr. [109.242.233.57]) by smtp.googlemail.com with ESMTPSA id k22-20020a170906129600b007c10fe64c5dsm15016382ejb.86.2023.01.04.00.45.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Jan 2023 00:45:07 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 17e4f316-8c0c-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=U41p6PerASg/ei7rzLx/hT3otWDVCdBfixYygyAySwk=; b=CAgRsne3K9cYsoKps2JWLBhsdMVSIAip+bDt2+YOPYqa60Nwgh5iMJu69YQh0xbaI8 61pO1+Er9QCvpY2ZfiM8RPYU1eqqYFxaKvpDkmdJvaoPA52aqLQ0KHWkTn1jIc8Z+H7R dEFEZIez3O7qkF4W/2iQ5X8WSpy+XyeMn99Jp0DC4CUj8lKYfsYv4dq4Xra+pEOeU4C8 SJaTT7Q9j3ZZOsPZqsDnEe22RbGD7o2Y3H/JmaYOM7D5Sv6mY3zy5RqMHVGSva6yqO/b zVQLZOTerGCntCmyZzk1NyBdZspKxV/Jum5qWvVGkIlmOQnjZfQqJl6ht5KYUPBtNuVX sibA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=U41p6PerASg/ei7rzLx/hT3otWDVCdBfixYygyAySwk=; b=Cetd5oEilMjN4+qysv5IxONRy1hyfKs122I+0/yAR719XsB3dEyqGCRA8n2tGAw3Dv 33IwbdfNcrsjJ8sORzKIOgTY3N2VTRoHDJCy3pG5czjSwkVKUNH6/eJ0jC4dG7t3Buqd 6sowMtCDbcAQYOkW436xIm3P+/yKbfMjAucQfTxjr15I4k7dE8ZBmezjiXiFj2ERi0S/ CX8T/FaixqDCyYf4kFqcXqLzbUmK//Z0H5kGa0V67c9jnCn9CBctU8+48RXu7AqbZCQI eRWjin5ywsjSPdmErvwV2Fl+9kJZB3KGOhD6fYVEKW/3Ov2AHRvxj+gqJn6E+QaUTGVI XjJg== X-Gm-Message-State: AFqh2kr3RNrs2loScO146FnigipSbPcfY/zTdDxuHt5MQ7pkdFA0+BZI miVKnbMD6fi2NnBBu1e8vREeM8tzX38= X-Google-Smtp-Source: AMrXdXs/+Vz7qVltCpOMZdgYin4fHcD0O3cVt2uL1v+aHewb2ycGe0IGJJHzHLbfcfM3tR+DqK94yA== X-Received: by 2002:a17:907:a708:b0:82e:a59a:5c3e with SMTP id vw8-20020a170907a70800b0082ea59a5c3emr52269642ejc.10.1672821908187; Wed, 04 Jan 2023 00:45:08 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Paul Durrant , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v2 1/8] x86/iommu: introduce AMD-Vi and Intel VT-d Kconfig options Date: Wed, 4 Jan 2023 10:44:55 +0200 Message-Id: <20230104084502.61734-2-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230104084502.61734-1-burzalodowa@gmail.com> References: <20230104084502.61734-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Introduce two new Kconfig options, AMD_IOMMU and INTEL_IOMMU, to allow code specific to each IOMMU technology to be separated and, when not required, stripped. AMD_IOMMU will be used to enable IOMMU support for platforms that implement the AMD I/O Virtualization Technology. INTEL_IOMMU will be used to enable IOMMU support for platforms that implement the Intel Virtualization Technology for Directed I/O. Since, at this point, disabling any of them would cause Xen to not compile, the options are not visible to the user and are enabled by default if X86. Signed-off-by: Xenia Ragiadakou --- Changes in v2: - just introduce the new options but not make them selectable by the user - adjust commit message - replace CONFIG_INTEL_VTD with CONFIG_INTEL_IOMMU xen/drivers/passthrough/Kconfig | 6 ++++++ xen/drivers/passthrough/Makefile | 4 ++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/xen/drivers/passthrough/Kconfig b/xen/drivers/passthrough/Kconfig index 479d7de57a..5c65567744 100644 --- a/xen/drivers/passthrough/Kconfig +++ b/xen/drivers/passthrough/Kconfig @@ -37,6 +37,12 @@ config IPMMU_VMSA endif +config AMD_IOMMU + def_bool y if X86 + +config INTEL_IOMMU + def_bool y if X86 + config IOMMU_FORCE_PT_SHARE bool diff --git a/xen/drivers/passthrough/Makefile b/xen/drivers/passthrough/Makefile index a5efa22714..a1621540b7 100644 --- a/xen/drivers/passthrough/Makefile +++ b/xen/drivers/passthrough/Makefile @@ -1,5 +1,5 @@ -obj-$(CONFIG_X86) += vtd/ -obj-$(CONFIG_X86) += amd/ +obj-$(CONFIG_INTEL_IOMMU) += vtd/ +obj-$(CONFIG_AMD_IOMMU) += amd/ obj-$(CONFIG_X86) += x86/ obj-$(CONFIG_ARM) += arm/ -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Wed Jan 04 08:45:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 08:45:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470983.730659 (Exim 4.92) (envelope-from ) id 1pCzOZ-0008TX-FA; Wed, 04 Jan 2023 08:45:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470983.730659; Wed, 04 Jan 2023 08:45:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCzOZ-0008SU-8P; Wed, 04 Jan 2023 08:45:11 +0000 Received: by outflank-mailman (input) for mailman id 470983; Wed, 04 Jan 2023 08:45:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCzOY-0008Pf-2k for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 08:45:10 +0000 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [2a00:1450:4864:20::62e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 175bb389-8c0c-11ed-b8d0-410ff93cb8f0; Wed, 04 Jan 2023 09:45:07 +0100 (CET) Received: by mail-ej1-x62e.google.com with SMTP id u9so81072765ejo.0 for ; Wed, 04 Jan 2023 00:45:07 -0800 (PST) Received: from uni.router.wind (adsl-57.109.242.233.tellas.gr. [109.242.233.57]) by smtp.googlemail.com with ESMTPSA id k22-20020a170906129600b007c10fe64c5dsm15016382ejb.86.2023.01.04.00.45.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Jan 2023 00:45:06 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 175bb389-8c0c-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=EBCGeHaBTmxyN/DaJmKzht+c6jCnKFesS3Z897W1Kpg=; b=JofC2WjASo4RG8zIrbk6xa6YUAa3FT7Jj7pAXx4ze5bEmGFhHy6xVTEDJswYShuLd3 oXCsr70nlBgeo4xO6yUa4FimRvyUT1cKnZ+ypf29bol4wnfFsqbWnKgItghkw01Ett65 EnZhGqR3rFV4DnVWovgKN3JcE8Lgu8yYAYAjJTFRysld0F27OHFAHtzkIkuZbY44nrwb irfHUk8OgLkxn2vipZz3d2zGa5dJriBJaFaDOErbGNCXOZPLQtQxhqnOWjWyIoAJ5M93 95t5mV5b3MmSQ2vog6CuziGQzmT4HqBaxuk+XaPNmbfjvkRtpUEiPvtY2oj4DAkqRyHe OBSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EBCGeHaBTmxyN/DaJmKzht+c6jCnKFesS3Z897W1Kpg=; b=bWqzMuTfvlZKeILfnpZ2bmnvjCwMAFyNfaWqYv5pkDd6MG58VtZdj+QNaELfL6FdOs 2PUhKcPoTE8w1x/XAytG31YEwKbz5FubFRQ1xyrJgstZ3GWeCGrPOFmYIVkUWhtzg4Xl ZvEFBj7LSOOVuPZgGoX9ZKua+2tSIfv21bWGZVrDF8UKyk9zSMBpkbHvOd5lF8O5VIUd SkRaDgo23sbPMmU9Q4FPuV7iw1UosC0ofKA0pNQ+N28A6TggnliMFS8FUP4wFY0B3BQh UdKn2k0clwBETSAnMx7/T0RudKkbNpxN3pDCEutx1was93cT/lbwZ0lCgADE42kReC8r 0I9Q== X-Gm-Message-State: AFqh2krqMwFGDZM2aOJjC405vqCWAyb3EpxtfSmaxH8FfIaTHJ6ridqE 8ybFRllYxdSadObHqkZBnibhls6OcfM= X-Google-Smtp-Source: AMrXdXumjn8F5BjTIazn7G7h3S0/llhfHrGEVIch0uQ5aP66cd7oCFL/Tv5eNSx0bxDF6y5WjQIWAA== X-Received: by 2002:a17:906:859:b0:84c:c4a4:61ca with SMTP id f25-20020a170906085900b0084cc4a461camr9478845ejd.61.1672821907069; Wed, 04 Jan 2023 00:45:07 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Paul Durrant , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Andrew Cooper , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , Jun Nakajima , Kevin Tian Subject: [PATCH v2 0/8] Make x86 IOMMU driver support configurable Date: Wed, 4 Jan 2023 10:44:54 +0200 Message-Id: <20230104084502.61734-1-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This series aims to provide a means to render the iommu driver support for x86 configurable. Currently, irrespectively of the target platform, both AMD and Intel iommu drivers are built. This is the case because the existent Kconfig infrastructure does not provide any facilities for finer-grained configuration. The series adds two new Kconfig options, AMD_IOMMU and INTEL_IOMMU, that can be used to generate a tailored iommu configuration for a given platform. This version of the series addresses the initial comments made in the RFC version to facilitate further review of the parts that need more feedback. Xenia Ragiadakou (8): x86/iommu: introduce AMD-Vi and Intel VT-d Kconfig options x86/iommu: amd_iommu_perdev_intremap is AMD-Vi specific x86/iommu: iommu_igfx, iommu_qinval and iommu_snoop are VT-d specific x86/acpi: separate AMD-Vi and VT-d specific functions x86/iommu: the code addressing CVE-2011-1898 is VT-d specific x86/iommu: call pi_update_irte through an hvm_function callback x86/dpci: move hvm_dpci_isairq_eoi() to generic HVM code x86/iommu: make AMD-Vi and Intel VT-d support configurable xen/arch/x86/hvm/vmx/vmx.c | 10 ++++ xen/arch/x86/include/asm/acpi.h | 14 ++++++ xen/arch/x86/include/asm/hvm/hvm.h | 15 ++++++ xen/arch/x86/include/asm/hvm/vmx/vmx.h | 11 ++++ xen/arch/x86/include/asm/iommu.h | 5 +- xen/arch/x86/pv/hypercall.c | 2 + xen/arch/x86/x86_64/entry.S | 2 + xen/drivers/passthrough/Kconfig | 24 +++++++++ xen/drivers/passthrough/Makefile | 4 +- xen/drivers/passthrough/amd/iommu_init.c | 2 + xen/drivers/passthrough/iommu.c | 9 +++- xen/drivers/passthrough/vtd/x86/Makefile | 1 - xen/drivers/passthrough/vtd/x86/hvm.c | 64 ------------------------ xen/drivers/passthrough/x86/hvm.c | 48 ++++++++++++++++-- xen/include/xen/acpi.h | 3 -- xen/include/xen/iommu.h | 7 ++- 16 files changed, 141 insertions(+), 80 deletions(-) delete mode 100644 xen/drivers/passthrough/vtd/x86/hvm.c -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Wed Jan 04 08:45:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 08:45:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470984.730676 (Exim 4.92) (envelope-from ) id 1pCzOa-0000U7-J7; Wed, 04 Jan 2023 08:45:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470984.730676; Wed, 04 Jan 2023 08:45:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCzOa-0000Ty-Fb; Wed, 04 Jan 2023 08:45:12 +0000 Received: by outflank-mailman (input) for mailman id 470984; Wed, 04 Jan 2023 08:45:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCzOY-0008Pe-JR for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 08:45:10 +0000 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [2a00:1450:4864:20::633]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 188b29c4-8c0c-11ed-91b6-6bf2151ebd3b; Wed, 04 Jan 2023 09:45:09 +0100 (CET) Received: by mail-ej1-x633.google.com with SMTP id t17so80776947eju.1 for ; Wed, 04 Jan 2023 00:45:09 -0800 (PST) Received: from uni.router.wind (adsl-57.109.242.233.tellas.gr. [109.242.233.57]) by smtp.googlemail.com with ESMTPSA id k22-20020a170906129600b007c10fe64c5dsm15016382ejb.86.2023.01.04.00.45.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Jan 2023 00:45:08 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 188b29c4-8c0c-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=C2lVOOqFcf6BKXv3+gSDIksJ5cf6q+xOsktrfoPl6c8=; b=QADj/+r42GTlhqcmiLkt+4z4W4FZNfMPjZCt2fEzAMhFmYXlNRG4AeW5EmHS62VS9C deBnM3SUhDLULCartyBVBru9Rvh8jSUoTIzJUi8s+HCpOdNcvXwNp5M6aySNHtEgVHxC j+mdUyZcm71ul1fTmrg6Aj3MISpCAHrmSL0DZieRsixKoYIKfktRA6Xi4CUJKlrgWTj/ Fk/QymbzqFYez7sTp/xE0v5aPg61T3FIiqxaDEl43eiJBV+/oe9HAD4CGQOJ3wsz3Q/W VhHd6TnDqqUFHUJ5nFlG1ICvDrS10E6WOM6A3y1u6tPIFenJ+CxA3jjQG4+tfX+ZRUAO E+rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=C2lVOOqFcf6BKXv3+gSDIksJ5cf6q+xOsktrfoPl6c8=; b=bMKwckyJgyQjI04+qh/AL4m67kiVYKuNouIXAQZsLVFcjsQJMZN54deKSrEP7yz7eP PHR9KD6Vibbs3ZYKNrjyWO3NBrBniyxz45do0xSdVezhBp2NW7wso6JX75lvqVHE1uua aUFPaPqEWMEL4F/DXk592LNPzGUVoddeOVd08xZSdFn7yeEqpES15mn/WCjWr5W6GZ7v udswNSW2R+N1JZZ7OkiqJa94k+Cx9EMUx/4+W7NtggasVXf0fvNswgTDayb3Bt6xAh9Q vGfz7uXH1tWhTgUunvl/EcDrcuowjOtYXo6O/7qsvHZ49FG67UKTy7h7o6IbsCUSp8y6 jWkw== X-Gm-Message-State: AFqh2kqlHzlxcE31nuMxw23xO4aC1Ww+b5vobkiBdENoaoV6s7KuBMvH 7E/nbYocRqnp6QHuoDbUgE5nMRF5zLQ= X-Google-Smtp-Source: AMrXdXvItxE5hRpoj+ycvRCaI78Q5RBjmYLhM84Rcmus0xMSC+Kut57gjsLwxguo9onjP5q5CnkkUw== X-Received: by 2002:a17:907:8b89:b0:7c1:6f86:eeb with SMTP id tb9-20020a1709078b8900b007c16f860eebmr36851095ejc.7.1672821909265; Wed, 04 Jan 2023 00:45:09 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Paul Durrant , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v2 2/8] x86/iommu: amd_iommu_perdev_intremap is AMD-Vi specific Date: Wed, 4 Jan 2023 10:44:56 +0200 Message-Id: <20230104084502.61734-3-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230104084502.61734-1-burzalodowa@gmail.com> References: <20230104084502.61734-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Move its definition to the AMD-Vi driver and use CONFIG_AMD_IOMMU to guard its usage in common code. Take the opportunity to replace bool_t with bool, __read_mostly with __ro_after_init and 1 with true. No functional change intended. Signed-off-by: Xenia Ragiadakou --- Changes in v2: - declare amd_iommu_perdev_intremap __ro_after_init - use no_config_param() to print a warning when the user sets an AMD_IOMMU specific string in the iommu boot parameter and AMD_IOMMU is disabled - remove the #ifdef CONFIG_AMD_IOMMU guard from the declaration of amd_iommu_perdev_intremap in xen/iommu.h xen/drivers/passthrough/amd/iommu_init.c | 2 ++ xen/drivers/passthrough/iommu.c | 5 ++++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/xen/drivers/passthrough/amd/iommu_init.c b/xen/drivers/passthrough/amd/iommu_init.c index 1f14aaf49e..9773ccfcb4 100644 --- a/xen/drivers/passthrough/amd/iommu_init.c +++ b/xen/drivers/passthrough/amd/iommu_init.c @@ -36,6 +36,8 @@ static struct radix_tree_root ivrs_maps; LIST_HEAD_READ_MOSTLY(amd_iommu_head); bool_t iommuv2_enabled; +bool __ro_after_init amd_iommu_perdev_intremap = true; + static bool iommu_has_ht_flag(struct amd_iommu *iommu, u8 mask) { return iommu->ht_flags & mask; diff --git a/xen/drivers/passthrough/iommu.c b/xen/drivers/passthrough/iommu.c index 5e2a720d29..998dfaf20d 100644 --- a/xen/drivers/passthrough/iommu.c +++ b/xen/drivers/passthrough/iommu.c @@ -58,7 +58,6 @@ bool __read_mostly iommu_hap_pt_share = true; #endif bool_t __read_mostly iommu_debug; -bool_t __read_mostly amd_iommu_perdev_intremap = 1; DEFINE_PER_CPU(bool_t, iommu_dont_flush_iotlb); @@ -116,7 +115,11 @@ static int __init cf_check parse_iommu_param(const char *s) iommu_verbose = 1; } else if ( (val = parse_boolean("amd-iommu-perdev-intremap", s, ss)) >= 0 ) +#ifdef CONFIG_AMD_IOMMU amd_iommu_perdev_intremap = val; +#else + no_config_param("AMD_IOMMU", "amd-iommu-perdev-intremap", s, ss); +#endif else if ( (val = parse_boolean("dom0-passthrough", s, ss)) >= 0 ) iommu_hwdom_passthrough = val; else if ( (val = parse_boolean("dom0-strict", s, ss)) >= 0 ) -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Wed Jan 04 08:45:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 08:45:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470987.730702 (Exim 4.92) (envelope-from ) id 1pCzOd-00015H-GU; Wed, 04 Jan 2023 08:45:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470987.730702; Wed, 04 Jan 2023 08:45:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCzOd-00014l-AR; Wed, 04 Jan 2023 08:45:15 +0000 Received: by outflank-mailman (input) for mailman id 470987; Wed, 04 Jan 2023 08:45:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCzOc-0008Pe-2t for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 08:45:14 +0000 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [2a00:1450:4864:20::636]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1aa4181c-8c0c-11ed-91b6-6bf2151ebd3b; Wed, 04 Jan 2023 09:45:13 +0100 (CET) Received: by mail-ej1-x636.google.com with SMTP id u19so80869748ejm.8 for ; Wed, 04 Jan 2023 00:45:13 -0800 (PST) Received: from uni.router.wind (adsl-57.109.242.233.tellas.gr. [109.242.233.57]) by smtp.googlemail.com with ESMTPSA id k22-20020a170906129600b007c10fe64c5dsm15016382ejb.86.2023.01.04.00.45.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Jan 2023 00:45:12 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1aa4181c-8c0c-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HOiaAsPMwgLoSMJypKuCfvLjyhJsFw19vxzxT5oap4g=; b=Hd2mClmwGN7qPAVe8jLCBJik7TSu6D1hwPwRA6n95halEdoHOO5XHhWX2UHU6b6QaR apkNmStPd4cT1h/6oOJnkb/2bFDjpD+nmAOI39BHYt1vVWTBte6I0MJLrQghx1ZGKZYH 8FLLbt5b7rEL4BF1k6fB2z7zni+yCr+ZaZgceCAglR7HvjajZ3HZOmmxrNPqPZ+LU0GT kw1GvxZdBd2btMegnuFM25MGAaBAcT7isq8D5DSD4tIGTtaG+dvJykEO446bArRtgd14 euK0j83jYn+YYNEsQoEm5ZKu4sTQXH9HcXbxEdSxRbDJlW3zA0jDLyfElaLsk4WC7okw cAbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HOiaAsPMwgLoSMJypKuCfvLjyhJsFw19vxzxT5oap4g=; b=qhbXC4niQE0bEJMxKLhBskodGjobmlzejTiuJV4czC7QGykh6ttjaAw8/b+FCf0lkZ fu1VHE8/f74MElaSd9napSDwr8UQupq9MS+Fa7U0Jv+uZlMML5yVEbVnv/pJBiWLrMJC VPscnb9hylW09GPGEG66ZS9Lhrzz42CnyVlB2YHvlN0a6GFGvJcROeLE6ouaBJx/GAeG x3oqFueBtv4gCFFWU65JUZMLt24Qf/EWcOsC5wHvcePcySIqKDEmrQBRFpGtLz0lZeyu SkIG519e3guWseIO13uk1D0AYKMjpnUZqCgoDloZXOZEuZot6QpSZJSPnif0OJJH3aqg TytQ== X-Gm-Message-State: AFqh2kr8dDdEDK+mpSxWc960O8835l4OfO9hNzRG25w2SvkBe3wtMXNc vQun9RtDy8q3MR0wmA6wy49NnX57HTU= X-Google-Smtp-Source: AMrXdXs5pE7YUspJLpR94+D/sV7BchYm34JJQ0CbAEWxWKKA/p0spj1+jbTzfVoPYDOubEeR4PhlqA== X-Received: by 2002:a17:906:39d8:b0:847:410:ecff with SMTP id i24-20020a17090639d800b008470410ecffmr34003836eje.16.1672821912776; Wed, 04 Jan 2023 00:45:12 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v2 5/8] x86/iommu: the code addressing CVE-2011-1898 is VT-d specific Date: Wed, 4 Jan 2023 10:44:59 +0200 Message-Id: <20230104084502.61734-6-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230104084502.61734-1-burzalodowa@gmail.com> References: <20230104084502.61734-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The variable untrusted_msi indicates whether the system is vulnerable to CVE-2011-1898. This vulnerablity is VT-d specific. Place the code that addresses the issue under CONFIG_INTEL_IOMMU. No functional change intended. Signed-off-by: Xenia Ragiadakou --- Changes in v2: - replace CONFIG_INTEL_VTD with CONFIG_INTEL_IOMMU xen/arch/x86/include/asm/iommu.h | 2 ++ xen/arch/x86/pv/hypercall.c | 2 ++ xen/arch/x86/x86_64/entry.S | 2 ++ 3 files changed, 6 insertions(+) diff --git a/xen/arch/x86/include/asm/iommu.h b/xen/arch/x86/include/asm/iommu.h index fc0afe35bf..fb5fe4e1bf 100644 --- a/xen/arch/x86/include/asm/iommu.h +++ b/xen/arch/x86/include/asm/iommu.h @@ -127,7 +127,9 @@ int iommu_identity_mapping(struct domain *d, p2m_access_t p2ma, unsigned int flag); void iommu_identity_map_teardown(struct domain *d); +#ifdef CONFIG_INTEL_IOMMU extern bool untrusted_msi; +#endif int pi_update_irte(const struct pi_desc *pi_desc, const struct pirq *pirq, const uint8_t gvec); diff --git a/xen/arch/x86/pv/hypercall.c b/xen/arch/x86/pv/hypercall.c index 2eedfbfae8..9d616a0fc5 100644 --- a/xen/arch/x86/pv/hypercall.c +++ b/xen/arch/x86/pv/hypercall.c @@ -193,8 +193,10 @@ void pv_ring1_init_hypercall_page(void *p) void do_entry_int82(struct cpu_user_regs *regs) { +#ifdef CONFIG_INTEL_IOMMU if ( unlikely(untrusted_msi) ) check_for_unexpected_msi((uint8_t)regs->entry_vector); +#endif _pv_hypercall(regs, true /* compat */); } diff --git a/xen/arch/x86/x86_64/entry.S b/xen/arch/x86/x86_64/entry.S index ae01285181..8f2fb36770 100644 --- a/xen/arch/x86/x86_64/entry.S +++ b/xen/arch/x86/x86_64/entry.S @@ -406,11 +406,13 @@ ENTRY(int80_direct_trap) .Lint80_cr3_okay: sti +#ifdef CONFIG_INTEL_IOMMU cmpb $0,untrusted_msi(%rip) UNLIKELY_START(ne, msi_check) movl $0x80,%edi call check_for_unexpected_msi UNLIKELY_END(msi_check) +#endif movq STACK_CPUINFO_FIELD(current_vcpu)(%rbx), %rbx -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Wed Jan 04 08:45:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 08:45:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470988.730720 (Exim 4.92) (envelope-from ) id 1pCzOg-0001dd-5g; Wed, 04 Jan 2023 08:45:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470988.730720; Wed, 04 Jan 2023 08:45:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCzOf-0001dC-Ux; Wed, 04 Jan 2023 08:45:17 +0000 Received: by outflank-mailman (input) for mailman id 470988; Wed, 04 Jan 2023 08:45:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCzOd-0008Pe-LM for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 08:45:15 +0000 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [2a00:1450:4864:20::631]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1b7c2fdb-8c0c-11ed-91b6-6bf2151ebd3b; Wed, 04 Jan 2023 09:45:14 +0100 (CET) Received: by mail-ej1-x631.google.com with SMTP id qk9so80720802ejc.3 for ; Wed, 04 Jan 2023 00:45:14 -0800 (PST) Received: from uni.router.wind (adsl-57.109.242.233.tellas.gr. [109.242.233.57]) by smtp.googlemail.com with ESMTPSA id k22-20020a170906129600b007c10fe64c5dsm15016382ejb.86.2023.01.04.00.45.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Jan 2023 00:45:13 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1b7c2fdb-8c0c-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Tj9i4k4Po7JyYtPs55wgOJc0qUd+pVBAioCcKA5YDiY=; b=Zk+2/cbxitpP46T2xli3DDei5RXHSwU29gjuLZrqJIo5izrT20VbUgQPqJsoEFGTOc /W5fc3wv67hCfpm1t12Ko8J8tL1OoAck5uYCQR2rHRD+Y7bobdryX37MXLcS0wGOBinj sfmXg6ZATbhiMJUVaOAjzB9CpCFUWM4eatisjFSKochHLue/OZd2USvw144OzRzASLmc A2+LucMoBQ8V32eCE2nvpI01CKlieGkI7D71enXT+XQSZ/53iB11tE64UfHLtQlA7w9P Pv/+P/8KodQeSpU4MNasky3A6OTEwPnzfs1DPhQrLWke0TvD005GLTE4soIPyEHXtF97 E+DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Tj9i4k4Po7JyYtPs55wgOJc0qUd+pVBAioCcKA5YDiY=; b=R0D6QB90BGTKCxztadvHO2ADWox0M1pWIPjXtjNWIchfPIt9FWvajgtw9xU0JQZ4Px OWktcbtMchdfpmvxslO4NNsY090AgXLbs2XF049xAdPNSr+xKU9f++3MvXKRPrL6c6gk wCg16qd11ztWbwmDdeothjsD09wEywfKqWpZlln8+gtCJN5elwsBc/nG5VfdXwefzQZH DzQGK9rOsFmgtswFT83LB6cOtiO0UIs2EzaBM6boOgCspDVfA642RF09eDhrEfbStIiu IXBfKZBwpEck/0+QNAn1fOvA7fsZug1T0EK4SIfbrsfZfwyIUiyqgDDj9G4vDjo7ybiN O3eQ== X-Gm-Message-State: AFqh2koJAwLtcnLCK288w7AWUjct14CWVQp/mukFLpBCutfiP/GkcsHM C8j5CBlel7B9l7SDCZ0mhCb8HPda4SY= X-Google-Smtp-Source: AMrXdXvYf/Q/hqROtjcI4p728EDt17GV1HrYpbRwl8Wf778r0ZHaKQAZ6Auylm8M+YkwBNQ7HdOJYg== X-Received: by 2002:a17:906:a186:b0:82d:e2a6:4b0d with SMTP id s6-20020a170906a18600b0082de2a64b0dmr40816443ejy.18.1672821914148; Wed, 04 Jan 2023 00:45:14 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jun Nakajima , Kevin Tian , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Paul Durrant Subject: [PATCH v2 6/8] x86/iommu: call pi_update_irte through an hvm_function callback Date: Wed, 4 Jan 2023 10:45:00 +0200 Message-Id: <20230104084502.61734-7-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230104084502.61734-1-burzalodowa@gmail.com> References: <20230104084502.61734-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Posted interrupt support in Xen is currently implemented only for the Intel platforms. Instead of calling directly pi_update_irte() from the common hvm code, add a pi_update_irte callback to the hvm_function_table. Then, create a wrapper function hvm_pi_update_irte() to be used by the common hvm code. In the pi_update_irte callback prototype, pass the vcpu as first parameter instead of the posted-interrupt descriptor that is platform specific, and remove the const qualifier from the parameter gvec since it is not needed and because it does not compile with the alternative code patching in use. Move the declaration of pi_update_irte() from asm/iommu.h to asm/hvm/vmx/vmx.h since it is hvm and Intel specific. No functional change intended. Signed-off-by: Xenia Ragiadakou --- Changes in v2: - remove the definition of hvm_pi_update_irte() for !CONFIG_HVM - replace CONFIG_INTEL_VTD with CONFIG_INTEL_IOMMU xen/arch/x86/hvm/vmx/vmx.c | 10 ++++++++++ xen/arch/x86/include/asm/hvm/hvm.h | 15 +++++++++++++++ xen/arch/x86/include/asm/hvm/vmx/vmx.h | 11 +++++++++++ xen/arch/x86/include/asm/iommu.h | 3 --- xen/drivers/passthrough/x86/hvm.c | 5 ++--- 5 files changed, 38 insertions(+), 6 deletions(-) diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index 43a4865d1c..cb6b325e41 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -2143,6 +2143,14 @@ static bool cf_check vmx_test_pir(const struct vcpu *v, uint8_t vec) return pi_test_pir(vec, &v->arch.hvm.vmx.pi_desc); } +static int cf_check vmx_pi_update_irte(const struct vcpu *v, + const struct pirq *pirq, uint8_t gvec) +{ + const struct pi_desc *pi_desc = v ? &v->arch.hvm.vmx.pi_desc : NULL; + + return pi_update_irte(pi_desc, pirq, gvec); +} + static void cf_check vmx_handle_eoi(uint8_t vector, int isr) { uint8_t old_svi = set_svi(isr); @@ -2591,6 +2599,8 @@ static struct hvm_function_table __initdata_cf_clobber vmx_function_table = { .tsc_scaling = { .max_ratio = VMX_TSC_MULTIPLIER_MAX, }, + + .pi_update_irte = vmx_pi_update_irte, }; /* Handle VT-d posted-interrupt when VCPU is blocked. */ diff --git a/xen/arch/x86/include/asm/hvm/hvm.h b/xen/arch/x86/include/asm/hvm/hvm.h index 93254651f2..b3fe0663f9 100644 --- a/xen/arch/x86/include/asm/hvm/hvm.h +++ b/xen/arch/x86/include/asm/hvm/hvm.h @@ -28,6 +28,8 @@ #include #include +struct pirq; /* needed by pi_update_irte */ + #ifdef CONFIG_HVM_FEP /* Permit use of the Forced Emulation Prefix in HVM guests */ extern bool_t opt_hvm_fep; @@ -250,6 +252,9 @@ struct hvm_function_table { /* Architecture function to setup TSC scaling ratio */ void (*setup)(struct vcpu *v); } tsc_scaling; + + int (*pi_update_irte)(const struct vcpu *v, + const struct pirq *pirq, uint8_t gvec); }; extern struct hvm_function_table hvm_funcs; @@ -774,6 +779,16 @@ static inline void hvm_set_nonreg_state(struct vcpu *v, alternative_vcall(hvm_funcs.set_nonreg_state, v, nrs); } +static inline int hvm_pi_update_irte(const struct vcpu *v, + const struct pirq *pirq, uint8_t gvec) +{ + if ( hvm_funcs.pi_update_irte ) + return alternative_call(hvm_funcs.pi_update_irte, v, pirq, gvec); + + return -EOPNOTSUPP; +} + + #else /* CONFIG_HVM */ #define hvm_enabled false diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmx.h b/xen/arch/x86/include/asm/hvm/vmx/vmx.h index 96a9f07ca5..e827fece07 100644 --- a/xen/arch/x86/include/asm/hvm/vmx/vmx.h +++ b/xen/arch/x86/include/asm/hvm/vmx/vmx.h @@ -146,6 +146,17 @@ static inline void pi_clear_sn(struct pi_desc *pi_desc) clear_bit(POSTED_INTR_SN, &pi_desc->control); } +#ifdef CONFIG_INTEL_IOMMU +int pi_update_irte(const struct pi_desc *pi_desc, + const struct pirq *pirq, const uint8_t gvec); +#else +static inline int pi_update_irte(const struct pi_desc *pi_desc, + const struct pirq *pirq, const uint8_t gvec) +{ + return -EOPNOTSUPP; +} +#endif + /* * Exit Reasons */ diff --git a/xen/arch/x86/include/asm/iommu.h b/xen/arch/x86/include/asm/iommu.h index fb5fe4e1bf..b432790d24 100644 --- a/xen/arch/x86/include/asm/iommu.h +++ b/xen/arch/x86/include/asm/iommu.h @@ -131,9 +131,6 @@ void iommu_identity_map_teardown(struct domain *d); extern bool untrusted_msi; #endif -int pi_update_irte(const struct pi_desc *pi_desc, const struct pirq *pirq, - const uint8_t gvec); - extern bool iommu_non_coherent, iommu_superpages; static inline void iommu_sync_cache(const void *addr, unsigned int size) diff --git a/xen/drivers/passthrough/x86/hvm.c b/xen/drivers/passthrough/x86/hvm.c index a16e0e5344..e720461a14 100644 --- a/xen/drivers/passthrough/x86/hvm.c +++ b/xen/drivers/passthrough/x86/hvm.c @@ -381,8 +381,7 @@ int pt_irq_create_bind( /* Use interrupt posting if it is supported. */ if ( iommu_intpost ) - pi_update_irte(vcpu ? &vcpu->arch.hvm.vmx.pi_desc : NULL, - info, pirq_dpci->gmsi.gvec); + hvm_pi_update_irte(vcpu, info, pirq_dpci->gmsi.gvec); if ( pt_irq_bind->u.msi.gflags & XEN_DOMCTL_VMSI_X86_UNMASKED ) { @@ -672,7 +671,7 @@ int pt_irq_destroy_bind( what = "bogus"; } else if ( pirq_dpci && pirq_dpci->gmsi.posted ) - pi_update_irte(NULL, pirq, 0); + hvm_pi_update_irte(NULL, pirq, 0); if ( pirq_dpci && (pirq_dpci->flags & HVM_IRQ_DPCI_MAPPED) && list_empty(&pirq_dpci->digl_list) ) -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Wed Jan 04 08:45:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 08:45:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470989.730725 (Exim 4.92) (envelope-from ) id 1pCzOg-0001he-J4; Wed, 04 Jan 2023 08:45:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470989.730725; Wed, 04 Jan 2023 08:45:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCzOg-0001fz-BE; Wed, 04 Jan 2023 08:45:18 +0000 Received: by outflank-mailman (input) for mailman id 470989; Wed, 04 Jan 2023 08:45:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCzOe-0008Pe-KN for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 08:45:16 +0000 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [2a00:1450:4864:20::62e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1c29c3f9-8c0c-11ed-91b6-6bf2151ebd3b; Wed, 04 Jan 2023 09:45:15 +0100 (CET) Received: by mail-ej1-x62e.google.com with SMTP id kw15so80791873ejc.10 for ; Wed, 04 Jan 2023 00:45:15 -0800 (PST) Received: from uni.router.wind (adsl-57.109.242.233.tellas.gr. [109.242.233.57]) by smtp.googlemail.com with ESMTPSA id k22-20020a170906129600b007c10fe64c5dsm15016382ejb.86.2023.01.04.00.45.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Jan 2023 00:45:14 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1c29c3f9-8c0c-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tqo5/tDlicPu5mCxcbh6Z6IjcPc3BV3fslYWB3OSArs=; b=LePRpHzDhHQjRWbDbuAHMYF8Ya6h/Nu3+/MhJyIyz06QAqOF1EVetuhx8mCgZMC887 kH7P9lgSIwn4eWBO93tmf01OzBKP4dDKVIzeOr/DpfVmuLWgRGIvYMUtgTa7YisgLZgP hn4oemUODuBnAQ5fxvN+mIWNSILJQwDbX1t+FNyMouEeOdIpJlDG/9kQdAlAsx80UlJL jTl1vRnFgs+K9AUDdy5LxW2dtzxuLLDtfPFyv45+htKGvvluZ6coAPK+sH8X0xLuVXjg UdP7pHR2LaOY4Om4f1/aSV5nvuxO0okrXOk2pJ/uSDKf7tvvuqVZZc3JdHrSVpAS7xzL yl4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tqo5/tDlicPu5mCxcbh6Z6IjcPc3BV3fslYWB3OSArs=; b=3RCtZm2Kzdh1cL0CLDS7L1jN/eOCXAthuVTJlyTy8YpW94x+Lv/8IhDYau+gKUpocY 55oTEfZMEcTYPRFx8aIqs5uZXWTN387uWzzBqQAyoJHAS3kk73L26WwIgdRnFwyXjBDS WQ2ndI9cOlM+isgbM7/GODZzKnd7Coiufs/emP8KyvNZG6YTI5FOYavD23X8ZCp7m/Bf WxUU6hixUDLhcKx0z2xB7cBrCZCqtXjzyuuj87LVZPovlAdZsCU8NUDaN+bqCP4pQkqY VBJYl4Nv5vWBVDp442llz3ZWej40bvJK3NG+QAfCUxRi0TrEHI5Up8uO8JJHKph4Mij3 cJFA== X-Gm-Message-State: AFqh2kqCh9TZv7AtNxZ8VZf5kWsFO883dmNqY96J8zpgvDz72Sb1G/IO 87pQ5//ssTfCd6fGx5mB5bgLX3BXKzc= X-Google-Smtp-Source: AMrXdXs5y3cNVYlCIU2x42F91fpieCpDGRWVHMwTv5YUoJffv5zEYYp91gCsYfg7Tg8x1q5qUj4dZw== X-Received: by 2002:a17:907:cb85:b0:7c0:f216:cc14 with SMTP id un5-20020a170907cb8500b007c0f216cc14mr40673315ejc.11.1672821915341; Wed, 04 Jan 2023 00:45:15 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Kevin Tian , Jan Beulich , Paul Durrant , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v2 7/8] x86/dpci: move hvm_dpci_isairq_eoi() to generic HVM code Date: Wed, 4 Jan 2023 10:45:01 +0200 Message-Id: <20230104084502.61734-8-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230104084502.61734-1-burzalodowa@gmail.com> References: <20230104084502.61734-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The function hvm_dpci_isairq_eoi() has no dependencies on VT-d driver code and can be moved from xen/drivers/passthrough/vtd/x86/hvm.c to xen/drivers/passthrough/x86/hvm.c, along with the corresponding copyrights. Remove the now empty xen/drivers/passthrough/vtd/x86/hvm.c. Since the funcion is used only in this file, declare it static. No functional change intended. Signed-off-by: Xenia Ragiadakou --- Changes in v2: - update the copyright - declare hvm_dpci_isairq_eoi() static xen/drivers/passthrough/vtd/x86/Makefile | 1 - xen/drivers/passthrough/vtd/x86/hvm.c | 64 ------------------------ xen/drivers/passthrough/x86/hvm.c | 43 ++++++++++++++++ xen/include/xen/iommu.h | 1 - 4 files changed, 43 insertions(+), 66 deletions(-) delete mode 100644 xen/drivers/passthrough/vtd/x86/hvm.c diff --git a/xen/drivers/passthrough/vtd/x86/Makefile b/xen/drivers/passthrough/vtd/x86/Makefile index 4ef00a4c5b..fe20a0b019 100644 --- a/xen/drivers/passthrough/vtd/x86/Makefile +++ b/xen/drivers/passthrough/vtd/x86/Makefile @@ -1,3 +1,2 @@ obj-y += ats.o -obj-$(CONFIG_HVM) += hvm.o obj-y += vtd.o diff --git a/xen/drivers/passthrough/vtd/x86/hvm.c b/xen/drivers/passthrough/vtd/x86/hvm.c deleted file mode 100644 index bc776cf7da..0000000000 --- a/xen/drivers/passthrough/vtd/x86/hvm.c +++ /dev/null @@ -1,64 +0,0 @@ -/* - * Copyright (c) 2008, Intel Corporation. - * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . - * - * Copyright (C) Allen Kay - * Copyright (C) Weidong Han - */ - -#include -#include -#include - -static int cf_check _hvm_dpci_isairq_eoi( - struct domain *d, struct hvm_pirq_dpci *pirq_dpci, void *arg) -{ - struct hvm_irq *hvm_irq = hvm_domain_irq(d); - unsigned int isairq = (long)arg; - const struct dev_intx_gsi_link *digl; - - list_for_each_entry ( digl, &pirq_dpci->digl_list, list ) - { - unsigned int link = hvm_pci_intx_link(digl->device, digl->intx); - - if ( hvm_irq->pci_link.route[link] == isairq ) - { - hvm_pci_intx_deassert(d, digl->device, digl->intx); - if ( --pirq_dpci->pending == 0 ) - pirq_guest_eoi(dpci_pirq(pirq_dpci)); - } - } - - return 0; -} - -void hvm_dpci_isairq_eoi(struct domain *d, unsigned int isairq) -{ - struct hvm_irq_dpci *dpci = NULL; - - ASSERT(isairq < NR_ISAIRQS); - if ( !is_iommu_enabled(d) ) - return; - - write_lock(&d->event_lock); - - dpci = domain_get_irq_dpci(d); - - if ( dpci && test_bit(isairq, dpci->isairq_map) ) - { - /* Multiple mirq may be mapped to one isa irq */ - pt_pirq_iterate(d, _hvm_dpci_isairq_eoi, (void *)(long)isairq); - } - write_unlock(&d->event_lock); -} diff --git a/xen/drivers/passthrough/x86/hvm.c b/xen/drivers/passthrough/x86/hvm.c index e720461a14..5043ecab9c 100644 --- a/xen/drivers/passthrough/x86/hvm.c +++ b/xen/drivers/passthrough/x86/hvm.c @@ -14,6 +14,7 @@ * this program; If not, see . * * Copyright (C) Allen Kay + * Copyright (C) Weidong Han * Copyright (C) Xiaohui Xin */ @@ -924,6 +925,48 @@ static void hvm_gsi_eoi(struct domain *d, unsigned int gsi) hvm_pirq_eoi(pirq); } +static int cf_check _hvm_dpci_isairq_eoi( + struct domain *d, struct hvm_pirq_dpci *pirq_dpci, void *arg) +{ + struct hvm_irq *hvm_irq = hvm_domain_irq(d); + unsigned int isairq = (long)arg; + const struct dev_intx_gsi_link *digl; + + list_for_each_entry ( digl, &pirq_dpci->digl_list, list ) + { + unsigned int link = hvm_pci_intx_link(digl->device, digl->intx); + + if ( hvm_irq->pci_link.route[link] == isairq ) + { + hvm_pci_intx_deassert(d, digl->device, digl->intx); + if ( --pirq_dpci->pending == 0 ) + pirq_guest_eoi(dpci_pirq(pirq_dpci)); + } + } + + return 0; +} + +static void hvm_dpci_isairq_eoi(struct domain *d, unsigned int isairq) +{ + struct hvm_irq_dpci *dpci = NULL; + + ASSERT(isairq < NR_ISAIRQS); + if ( !is_iommu_enabled(d) ) + return; + + write_lock(&d->event_lock); + + dpci = domain_get_irq_dpci(d); + + if ( dpci && test_bit(isairq, dpci->isairq_map) ) + { + /* Multiple mirq may be mapped to one isa irq */ + pt_pirq_iterate(d, _hvm_dpci_isairq_eoi, (void *)(long)isairq); + } + write_unlock(&d->event_lock); +} + void hvm_dpci_eoi(struct domain *d, unsigned int guest_gsi) { const struct hvm_irq_dpci *hvm_irq_dpci; diff --git a/xen/include/xen/iommu.h b/xen/include/xen/iommu.h index aa924541d5..f08bc2a4a5 100644 --- a/xen/include/xen/iommu.h +++ b/xen/include/xen/iommu.h @@ -200,7 +200,6 @@ int hvm_do_IRQ_dpci(struct domain *, struct pirq *); int pt_irq_create_bind(struct domain *, const struct xen_domctl_bind_pt_irq *); int pt_irq_destroy_bind(struct domain *, const struct xen_domctl_bind_pt_irq *); -void hvm_dpci_isairq_eoi(struct domain *d, unsigned int isairq); struct hvm_irq_dpci *domain_get_irq_dpci(const struct domain *); void free_hvm_irq_dpci(struct hvm_irq_dpci *dpci); -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Wed Jan 04 08:45:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 08:45:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.470990.730742 (Exim 4.92) (envelope-from ) id 1pCzOi-0002Fb-QC; Wed, 04 Jan 2023 08:45:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 470990.730742; Wed, 04 Jan 2023 08:45:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCzOi-0002FP-Lr; Wed, 04 Jan 2023 08:45:20 +0000 Received: by outflank-mailman (input) for mailman id 470990; Wed, 04 Jan 2023 08:45:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCzOg-0008Pf-OL for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 08:45:18 +0000 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [2a00:1450:4864:20::633]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1cc9b85c-8c0c-11ed-b8d0-410ff93cb8f0; Wed, 04 Jan 2023 09:45:17 +0100 (CET) Received: by mail-ej1-x633.google.com with SMTP id ud5so81013310ejc.4 for ; Wed, 04 Jan 2023 00:45:17 -0800 (PST) Received: from uni.router.wind (adsl-57.109.242.233.tellas.gr. [109.242.233.57]) by smtp.googlemail.com with ESMTPSA id k22-20020a170906129600b007c10fe64c5dsm15016382ejb.86.2023.01.04.00.45.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Jan 2023 00:45:15 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1cc9b85c-8c0c-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DXOzrCrP8CVhczjYbqhFp6hVHdTDovyn5H+grp051f4=; b=qeP7xCjifPj0QarjFgSOGJRU4qkTv1zwQ4edK6rTI+eSwqKg+JufxW8DXzH8md0vUK OOfmwgDfA2698SQzUCoM/5O1c3rlhV5lq3nsDZqtyGLrjNzJoKO+o5QRpQcxNdgUjSck 8pz7Y3YcWzIGlbpLWFWTq9L5GXNOVcK1wWg9EyGkQypzwYLtk824AZKDhIMFNHbzaWnZ 68ftp/Tmkt+E39dxup49sKqm1JK2p6me2q8IqsL1sof2c5x7UUqzdDNDtMhUXv64nE9D UzQabCUIHGG6hblKTyrWFfaWVz/ZO15PUiP+3ZAgHUKueM8BE57SN7F8Qr+4CmQjO7l1 Y0Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DXOzrCrP8CVhczjYbqhFp6hVHdTDovyn5H+grp051f4=; b=VK+RU3jJgk7Fahz518Wt6xzeIbT1p5HoHQiqi52dWagfvUP66BXivZ/Y3D50WvvpMa 6erQU8nTMARf6ozWTTGqgPR0mgTAmYIaviDaTh6Ko5B61WMtgoOEsy5eiwL5mjM6OJVa ApqUrF4qxhjP3TNO1DQdR8bdlKGuIumI3X0i32wHAbm8i/Nc99yJ+g7BQUXjOvy2gv1D tU+e+v8lCixSptuRdOSUbbVXXbRNypXe42DihPYm0Mo7dxhSOvLnJYK/Qz2SQmVGeK6e uawVOdmIPwUw4yf4tDDk60hioMMr9yhQU6rHCw4N5Qm6vXY2FsHXdDp96IJMETVv2c3q twtg== X-Gm-Message-State: AFqh2kqNCxHeXJVaqQ3a3bGQSm+P806m2K0IP/OHHJXv8Tz8Yl52bFeR dNQbl1oFfDjGhdbBWQQuA/Nu8fU5r7k= X-Google-Smtp-Source: AMrXdXubp/bxwGlLu0FavJ4su5iF17RcY+AXjEy9frY7aW1SYFUeDfC4LNrgH7JgZHj4KH1yH9TQ+w== X-Received: by 2002:a17:907:d389:b0:7c1:5a37:825 with SMTP id vh9-20020a170907d38900b007c15a370825mr52798189ejc.34.1672821916328; Wed, 04 Jan 2023 00:45:16 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Paul Durrant , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v2 8/8] x86/iommu: make AMD-Vi and Intel VT-d support configurable Date: Wed, 4 Jan 2023 10:45:02 +0200 Message-Id: <20230104084502.61734-9-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230104084502.61734-1-burzalodowa@gmail.com> References: <20230104084502.61734-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Provide the user with configuration control over the IOMMU support by making AMD_IOMMU and INTEL_IOMMU options user selectable and able to be turned off. However, there are cases where the IOMMU support is required, for instance for a system with more than 254 CPUs. In order to prevent users from unknowingly disabling it and ending up with a broken hypervisor, make the support user selectable only if EXPERT is enabled. To preserve the current default configuration of an x86 system, both options depend on X86 and default to Y. Signed-off-by: Xenia Ragiadakou --- Changes in v2: - new patch that derives from patch 1/7 of v1 - replace --help-- with help - make the options visible if EXPERT is enabled - indicate the cases where the options need to be enabled xen/drivers/passthrough/Kconfig | 22 ++++++++++++++++++++-- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/xen/drivers/passthrough/Kconfig b/xen/drivers/passthrough/Kconfig index 5c65567744..864fcf3b0c 100644 --- a/xen/drivers/passthrough/Kconfig +++ b/xen/drivers/passthrough/Kconfig @@ -38,10 +38,28 @@ config IPMMU_VMSA endif config AMD_IOMMU - def_bool y if X86 + bool "AMD IOMMU" if EXPERT + depends on X86 + default y + help + Enables I/O virtualization on platforms that implement the + AMD I/O Virtualization Technology (IOMMU). + + If your system includes an IOMMU implementing AMD-Vi, say Y. + This is required if your system has more than 254 CPUs. + If in doubt, say Y. config INTEL_IOMMU - def_bool y if X86 + bool "Intel VT-d" if EXPERT + depends on X86 + default y + help + Enables I/O virtualization on platforms that implement the + Intel Virtualization Technology for Directed I/O (Intel VT-d). + + If your system includes an IOMMU implementing Intel VT-d, say Y. + This is required if your system has more than 254 CPUs. + If in doubt, say Y. config IOMMU_FORCE_PT_SHARE bool -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Wed Jan 04 09:03:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 09:03:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471058.730752 (Exim 4.92) (envelope-from ) id 1pCzft-00072Q-PO; Wed, 04 Jan 2023 09:03:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471058.730752; Wed, 04 Jan 2023 09:03:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCzft-00072J-MG; Wed, 04 Jan 2023 09:03:05 +0000 Received: by outflank-mailman (input) for mailman id 471058; Wed, 04 Jan 2023 09:03:04 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCzfs-000729-Em; Wed, 04 Jan 2023 09:03:04 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCzfs-00008R-Bz; Wed, 04 Jan 2023 09:03:04 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCzfr-0007tV-Qb; Wed, 04 Jan 2023 09:03:03 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pCzfr-0004Yp-Q8; Wed, 04 Jan 2023 09:03:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=v2Krd+m8F0I7k4aHmYO02GgmL7VmRQ/F9KS0hJv0Tfg=; b=xyBrLBja3ipF5ihjW6ofK7Nv4j i55JZ4DTeBe2ex8RFXp6FsgmokIdgg1Fb4b0opsLVQ8tUB6wXPaGaVRgqwM0Rw3hIk3uFHKoRjAFi LaBNau5+MIBCptCZnIY9cet8Ng9Xb2o0NimfbR/Kg7jd7IkEYUXGHkB+SCRknCoBz4GQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 175561: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=69b41ac87e4a664de78a395ff97166f0b2943210 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Wed, 04 Jan 2023 09:03:03 +0000 flight 175561 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/175561/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine 8 reboot fail REGR. vs. 173462 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux 69b41ac87e4a664de78a395ff97166f0b2943210 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 88 days Failing since 173470 2022-10-08 06:21:34 Z 88 days 183 attempts Testing same since 175552 2023-01-02 21:13:23 Z 1 days 4 attempts ------------------------------------------------------------ 3257 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 497265 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Jan 04 09:03:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 09:03:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471068.730764 (Exim 4.92) (envelope-from ) id 1pCzgl-0007cR-8q; Wed, 04 Jan 2023 09:03:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471068.730764; Wed, 04 Jan 2023 09:03:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCzgl-0007cK-5O; Wed, 04 Jan 2023 09:03:59 +0000 Received: by outflank-mailman (input) for mailman id 471068; Wed, 04 Jan 2023 09:03:57 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCzgj-0007c8-Rl for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 09:03:57 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCzgj-00008o-2o; Wed, 04 Jan 2023 09:03:57 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.240]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pCzgi-0007ac-Tt; Wed, 04 Jan 2023 09:03:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=E5QF3ZIYhIqtza+uUT60SAKBwRufJQsVMuv2YnaYHQ8=; b=VvcM8sPcG29hG5Jox/rEHnB177 Pls2nM4qVrVH6uGURQk4eWL9L7sXOTkSshSZx8F9lt8+B6mfjC+I1/tCfi2V14Fj5W6NncFgy4bke PW7uTsyqNsrvCgDfUGk9gZbWmQSmD/RKvBdgJQLZhNYETDom45TeuOFWlnsTMRKsEk7g=; Message-ID: <11432e22-94cd-c956-63dc-d45c419150f5@xen.org> Date: Wed, 4 Jan 2023 09:03:55 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 1/4] public/version: Change xen_feature_info to have a fixed size Content-Language: en-US To: Andrew Cooper , Xen-devel Cc: George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu References: <20230103200943.5801-1-andrew.cooper3@citrix.com> <20230103200943.5801-2-andrew.cooper3@citrix.com> From: Julien Grall In-Reply-To: <20230103200943.5801-2-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Andrew, On 03/01/2023 20:09, Andrew Cooper wrote: > This is technically an ABI change, but Xen doesn't operate in any environment > where "unsigned int" is differnet to uint32_t, so switch to the explicit form. typo: s/differnet/different/ > This avoids the need to derive (identical) compat logic for handling the > subop. > > Signed-off-by: Andrew Cooper Acked-by: Julien Grall Cheers, > --- > CC: George Dunlap > CC: Jan Beulich > CC: Stefano Stabellini > CC: Wei Liu > CC: Julien Grall > --- > xen/include/public/version.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/include/public/version.h b/xen/include/public/version.h > index 9c78b4f3b6a4..0ff8bd9077c6 100644 > --- a/xen/include/public/version.h > +++ b/xen/include/public/version.h > @@ -50,7 +50,7 @@ typedef struct xen_platform_parameters xen_platform_parameters_t; > > #define XENVER_get_features 6 > struct xen_feature_info { > - unsigned int submap_idx; /* IN: which 32-bit submap to return */ > + uint32_t submap_idx; /* IN: which 32-bit submap to return */ > uint32_t submap; /* OUT: 32-bit submap */ > }; > typedef struct xen_feature_info xen_feature_info_t; -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Jan 04 09:20:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 09:20:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471075.730775 (Exim 4.92) (envelope-from ) id 1pCzwW-0001bw-J2; Wed, 04 Jan 2023 09:20:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471075.730775; Wed, 04 Jan 2023 09:20:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCzwW-0001bp-Fk; Wed, 04 Jan 2023 09:20:16 +0000 Received: by outflank-mailman (input) for mailman id 471075; Wed, 04 Jan 2023 09:20:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCzwV-0001bf-EE; Wed, 04 Jan 2023 09:20:15 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCzwV-0000cN-Bl; Wed, 04 Jan 2023 09:20:15 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pCzwU-0008Ln-VW; Wed, 04 Jan 2023 09:20:15 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pCzwU-0000lZ-V4; Wed, 04 Jan 2023 09:20:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=nYteTN+bVQACOqSlCkhq/HvlpTFd4l/wJ/H0DoxSeJ8=; b=rmPLt24NbOKyWPheQaid4JNfAF L4K+GmI5Q4WwXU9vpam1AYks9lxcKJN2tInlKsgi6/kTj59aV+crzJUBwRU4OGZ2md4WgoEGs23Rz fOnpuc39zdaisRJUFX6zeggZXah+Jan5Z75u0Z+IOHOXesf8wZ3Ntm8kl6VL3sVOQlY0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 175564: tolerable all pass - PUSHED X-Osstest-Failures: libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: libvirt=9193bac260620fbeec580d709699b3e0f97b9bd7 X-Osstest-Versions-That: libvirt=35afa1d2d6c10ce993c60caea1efe1c589fa1d5d From: osstest service owner Date: Wed, 04 Jan 2023 09:20:14 +0000 flight 175564 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/175564/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 175555 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 175555 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 175555 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: libvirt 9193bac260620fbeec580d709699b3e0f97b9bd7 baseline version: libvirt 35afa1d2d6c10ce993c60caea1efe1c589fa1d5d Last test of basis 175555 2023-01-03 04:20:26 Z 1 days Testing same since 175564 2023-01-04 04:20:21 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ettore Atalan Gedalya Jan Kuparinen Michal Privoznik Peter Krempa 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git 35afa1d2d6..9193bac260 9193bac260620fbeec580d709699b3e0f97b9bd7 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Jan 04 09:57:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 09:57:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471084.730786 (Exim 4.92) (envelope-from ) id 1pD0W0-00050r-Bv; Wed, 04 Jan 2023 09:56:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471084.730786; Wed, 04 Jan 2023 09:56:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD0W0-00050k-89; Wed, 04 Jan 2023 09:56:56 +0000 Received: by outflank-mailman (input) for mailman id 471084; Wed, 04 Jan 2023 09:56:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD0Vz-00050a-9H; Wed, 04 Jan 2023 09:56:55 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD0Vy-0001Vh-VX; Wed, 04 Jan 2023 09:56:55 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD0Vy-0000lr-D5; Wed, 04 Jan 2023 09:56:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pD0Vy-0007HX-CZ; Wed, 04 Jan 2023 09:56:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=TYXYHR4YwoG3jJWyaCO/sm230k9pfvnmXYXkRTtOX1E=; b=21lc8UIHDfybeh36dpryLG3eKX wmBHfiIhqBM5pCIL2CMQP983Yxkg1MJ3eIdt+opqNLST0xx9kFZcXlrl4YZtw4JT3uIHa/gGkmwZ8 dyKH4C8cDqN0Gh0VEnjmPlko4NwcLx1ac9D4DkQSskzEy8iQ7vjVlAbCMknfNIRyJGhE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 175562: regressions - FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-libvirt-pair::broken:regression xen-unstable:build-arm64-pvops:kernel-build:fail:regression xen-unstable:test-amd64-amd64-libvirt-pair:host-install/src_host(6):broken:heisenbug xen-unstable:test-amd64-i386-livepatch:xen-install:fail:heisenbug xen-unstable:test-arm64-arm64-xl-vhd:debian-di-install:fail:heisenbug xen-unstable:test-amd64-i386-libvirt:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-i386-qemut-rhel6hvm-amd:guest-start.2:fail:heisenbug xen-unstable:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:heisenbug xen-unstable:test-arm64-arm64-examine:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-freebsd10-amd64:xen-install:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=7eef80e06ed2282bbcec3619d860c6aacb0515d8 X-Osstest-Versions-That: xen=7eef80e06ed2282bbcec3619d860c6aacb0515d8 From: osstest service owner Date: Wed, 04 Jan 2023 09:56:54 +0000 flight 175562 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/175562/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-pair broken in 175548 build-arm64-pvops 6 kernel-build fail REGR. vs. 175554 Tests which are failing intermittently (not blocking): test-amd64-amd64-libvirt-pair 6 host-install/src_host(6) broken in 175548 pass in 175562 test-amd64-i386-livepatch 7 xen-install fail in 175548 pass in 175562 test-arm64-arm64-xl-vhd 12 debian-di-install fail in 175554 pass in 175548 test-amd64-i386-libvirt 20 guest-start/debian.repeat fail in 175554 pass in 175562 test-amd64-i386-qemut-rhel6hvm-amd 15 guest-start.2 fail in 175554 pass in 175562 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail pass in 175554 Tests which did not succeed, but are not blocking: test-arm64-arm64-examine 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 14 migrate-support-check fail in 175548 never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail in 175548 never pass test-amd64-i386-freebsd10-amd64 7 xen-install fail in 175554 like 175548 test-arm64-arm64-xl-seattle 15 migrate-support-check fail in 175554 never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail in 175554 never pass test-arm64-arm64-xl 15 migrate-support-check fail in 175554 never pass test-arm64-arm64-xl 16 saverestore-support-check fail in 175554 never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail in 175554 never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail in 175554 never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail in 175554 never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 175554 never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail in 175554 never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 175554 never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 175554 never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 175554 never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail in 175554 never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 175554 never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 175554 never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 175554 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 175554 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175554 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 175554 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail like 175554 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175554 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175554 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 175554 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 175554 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 175554 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 175554 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 175554 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175554 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 175554 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen 7eef80e06ed2282bbcec3619d860c6aacb0515d8 baseline version: xen 7eef80e06ed2282bbcec3619d860c6aacb0515d8 Last test of basis 175562 2023-01-04 01:55:19 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops fail build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl blocked test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm blocked test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine blocked test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-libvirt-pair broken Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Wed Jan 04 10:23:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 10:23:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471094.730797 (Exim 4.92) (envelope-from ) id 1pD0vV-0008S8-LF; Wed, 04 Jan 2023 10:23:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471094.730797; Wed, 04 Jan 2023 10:23:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD0vV-0008S1-Hc; Wed, 04 Jan 2023 10:23:17 +0000 Received: by outflank-mailman (input) for mailman id 471094; Wed, 04 Jan 2023 10:23:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD0vU-0008Rv-27 for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 10:23:16 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2057.outbound.protection.outlook.com [40.107.20.57]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ca8f7dde-8c19-11ed-b8d0-410ff93cb8f0; Wed, 04 Jan 2023 11:23:12 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8074.eurprd04.prod.outlook.com (2603:10a6:10:24a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Wed, 4 Jan 2023 10:23:10 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5944.019; Wed, 4 Jan 2023 10:23:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ca8f7dde-8c19-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X+C7P2uz4eDXlg3xI4PsY7OYOZr8bcOox/EUFgAxGsF0wfvVz3wsZ/XSHSSXagnm/ytSWTL0KHIwA1QYdfVkJjGQN1paugLjrPDVEaSJUqjtBi6irkWb6xQ4gvDGvKUWYOR/8hdzCtV/lPSR3NpoRGEBrhw6cGsP9dEI0KH5etajyyeZdboJuQ3yjCSPNUmH5UXa0tGy/ykAq3NLu2RQBPen7RzRS6P4JSRQv5EjDeiGZ6oLMqiSkQkTjIRRpLN51RegeCjfuHUnpA1uzaiFrpOR0piZGWg5zV5wf14zC+PqpzIRt7I0z7nu0bjMe2pN81w/U2N/UFQtfnJmbrFj4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=q0RcQ0o/ff3cMD/M7ElC/t6CUe9cnaxHFi1kJMUWY50=; b=XJhLCx+WVk6+PL63pxGEeGadAmtN3v/RX7vpLNgJiu5dfOZ+Tb3O5vG2h338icsCtRTbYZiQymqOGenGCWnQwn3wTp43KpOUCVMB+Y1g6Tljrt6YfbGS6olXP3o5dCA+ci2dcg2za3v9m2rEw47SlOiX21E9Dtp2yR/ZPlO0u8es35zEdqZvgTZbGcr2x1GmeoT2zxYBkS5dP5zMas29J3LBKLosSpH/lDct1yyB0o+pAjTEg6cLZ6KHt1xonIj78dy0SOYaV4Fa+EEu7Ae0DwJVPULw9rA8xAOHVp8l49Tph5ecB7cHobtSmp9T1bi4VqV/ST6odP8LDrr81iZUZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q0RcQ0o/ff3cMD/M7ElC/t6CUe9cnaxHFi1kJMUWY50=; b=aLBjZro+AQB1E3fbVf7h5J85C9qzO/ai0gBdInG0zj4hKPeSqnfDiczxSK8vU+Bu05hA38r0pjA6gBJosGy1KQy/0ugw319GPYfzOl0pc1JOHP4ZOHd4P6FAQeaZYsv+FrxgFMEJvi4ckEu3vvR/rNH0ZeaAG7UboL68yR8ezedteaGQUViywe7mqaWkscV8icohbOUDBMQg2q1u74QfgtFhq0LwtxtERbo3TTMkbDgCKeccV1M8mCKChycBZUtTAoCIQKAWRoFITh+lL4QFtulg0ITSA+MSVzTkKssSzetSKY+fZcOlX5sK/Vpaz4YAzXUMUOFLbeXJgiivEjSn/Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 4 Jan 2023 11:23:18 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 05/22] x86/srat: vmap the pages for acpi_slit Content-Language: en-US To: Julien Grall Cc: Hongyan Xia , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org, Julien Grall References: <20221216114853.8227-1-julien@xen.org> <20221216114853.8227-6-julien@xen.org> <965e3faa-472d-9a79-83ca-fef57cda81c5@xen.org> From: Jan Beulich In-Reply-To: <965e3faa-472d-9a79-83ca-fef57cda81c5@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0108.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8074:EE_ X-MS-Office365-Filtering-Correlation-Id: a2d52c6e-e7fb-4996-ae12-08daee3dadc3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: axDbbIbII69PS1LPz5UcfVp+L9CYX2zdCj8MvCFzXnbTpu2frFtqFHvpexQsrExYzXwPoVuhvZ4f/8v0YcxFuIUgm8EZS2L9I2dUe0zRLQ/9EK324TXkxi1oQ2cieiuS4wMItHHS0+cwgNZX52Z32uaBpjMN2s6Gfd0GynxWlWYgwaTxNwnLCmLXoFGLazjyw6jKKjxMuRqQgeJdOii0HhlShaxpoPKRubYDdyovkNg9WVCwbsMECm/Mv+PLTChtotpLmpaa1V8OxF08VH3X02WMtKfargEkkio4BghDmC9nLqKRSJeTmKKuNQaCAaaVX1d+EdI9y3nM/+h2Ma8v+k+gsxIQwAOda9tsUSKk96bs39yfdpEQ1I54Udxj+IDH0ntE6JTxgOEqbj/Q31rqLxSZd4BRynmN/78PbZXpkCatzPxWrh7kz7pr/YUdoYokAEvy8DtH1yilVw0smO71/os6HzKv+VW5JImxBAnEPIi46Nb5xMgj9sgSa38LG3wk0Vdzg2DowdNuXELPSIyrDxcs6n+Rn4eAwZCoYXT6ugzBlA5C9tMfYTRskmfGrPfmjY9dc8AwEg7LkkzWZGKAYelyi8KIPGaEE1QQn208NxF8dFBelT3UtQ2UCIXxCnjpvA5mZhxaZDn+HySRO3V0BoPswYCbHDR3dolv8nNt4bqNlAudrmqDRRp5xFXDFf14CVK+mt9x9WKm8Y86He3/mxLY3q7LqDUF734ns0TH7Ms= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(376002)(346002)(136003)(396003)(366004)(451199015)(83380400001)(53546011)(26005)(2616005)(6506007)(6512007)(186003)(31696002)(36756003)(86362001)(38100700002)(8676002)(4326008)(41300700001)(2906002)(5660300002)(8936002)(31686004)(6486002)(478600001)(66946007)(316002)(66556008)(66476007)(54906003)(6916009)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UnNBTSthUjFDS0lMVUEwaitsMnZVM09BZ09vcmtadFJySFNIRk5WNFAwVnBu?= =?utf-8?B?T09Cb1NERXVTRHhKUU9XRlRjbHNZcFBWcHB4bUJnVElzU09oZis3TFNVZEZE?= =?utf-8?B?RGQxTU9tYWhqLzF4ckcvb1U5K3VnMi9US0VoQVNBQ2Fpd1lsalI1NXlEdE4w?= =?utf-8?B?b1lzck9YNUV2ZHJmTk91Y2IzWnFZMWM0aHFFaWZmQ2JaVjNqU2huOElYT0lI?= =?utf-8?B?OExpOEliVXEyamgrWENreWFqY3ZEd1hRaVFsZzdpQzN2YzJTZktwWmU1ODMz?= =?utf-8?B?TmJVcm5jSDl4SkVaUGlYZS9yWDNocXVsbHVMU2FEdmE4bGdsaE1acjFRTmdR?= =?utf-8?B?OTZVS0RhaXhKcldxK2lmMUJkcUQzQjZXNmhGeXVYZjZITlM2ZDdNQVFyMjZ5?= =?utf-8?B?ZWExc0ZVTGdHbUFIRTkxbzNSQmVaNGk1aVlnNEN5QjRLU2tpQVZia1lWRzRa?= =?utf-8?B?VldwOEd0V2NRNW1HaFZPNUNzd0g4VWRJMnQ4dHJrWGZyNzBUbmR1Q05MdVN5?= =?utf-8?B?a2Rkd2hVNjdIVnMyeFNvYWpYZUx6ZllnVzJETWJWc3ZsUHdHRCtTL1krS005?= =?utf-8?B?Y3R6dTRwMTJKa0FzTzRIdFpUL1pERW80b0kwUlNabTFsckJ2eFZJQmhNZ1hO?= =?utf-8?B?aXBEN1d0TjZlV3IrRUN1eE1RSDV1N3JQdEpkekdGTEt0Vm54MXo2dFd5UUR5?= =?utf-8?B?WllTTlJQSVJLSWtFRGczY2JlbXpuVkZua3pDM1BCOEtVN3BqWEppSk1BQU41?= =?utf-8?B?S3lPWUVwZE9PU0RCdHUvbmJXblF2Qk05RUdNTXU3c1NGSm9JWWh3clV5K3Yx?= =?utf-8?B?TEJJTFV3U2FDMkltcHhZRnhyd1BVNTQ2aVhNQ0xQRWJicWplVXhnalJjNmM5?= =?utf-8?B?U2tvZmZ4MjZDdmhhZTZiSGhqeDRrU3ZCOWIybFNlcFBWblBFZUdLdmVlZVF6?= =?utf-8?B?K1l5anY0YndrMnVUcEVEcXRCU0FRdkJ0NVlXVGtJMUVvTEsvTEFEeC9GcE1Y?= =?utf-8?B?NzlQZHA0eXJ4bXcrcm04YTBlY3ROb1g4emRsNnBzZkRtOGNIbUhqRWtLNDY2?= =?utf-8?B?RktIQUtuQ2pXVlZoLzJhcDlndE9iUER6S2d2TFl1NGJvQThNWUtzVWhwOWRz?= =?utf-8?B?QlhPaG1pUys5WU8yeFNvdzlXVUR5cWNudlNlZzRGUmlWYlBCTDNraEZ6ZGVB?= =?utf-8?B?bnBoWmI1UUZlemZsL1dUYllIVGNsaHB6Tk13M200VmNGV0cwUDNTUWxsYkp5?= =?utf-8?B?WVNwNjVJeCtVRlVPUjJTL2p5cnh0YytkRitOYlhSMDdyaFptL2ZhOVA1cHNK?= =?utf-8?B?Y2d3ZkdwckN3VGZVejZyeXhkQVBTdzV5Q3EvR3dXRjZsMENNVHlVYVZYV094?= =?utf-8?B?VTYxS2xEcDZUMmxVaERsZ1Bwc3p1WXE3K25scTZyRk1HMjJGQkpWSEhOdkFn?= =?utf-8?B?YzBkbnZCOXMxV2FVZVVjS1cwMnRlV0JqOGZ1VHZsMFozMHJ5dUI1RER3clI5?= =?utf-8?B?Nm9qcVhtdkFJRjVvMitDaXMvUFhaQ1hPc1ptaDh0cHNrTXc2ekZ5bEd6NUY5?= =?utf-8?B?c3N5NUlKcXZ4YXgyMVBzNVQyTWtCc2NxNlNIUWJQMnJydVpIOGo4VlRra043?= =?utf-8?B?MWpOMHFVV1Fxb2dQK1hXSkdmYnArSnBtLzdTa0FvNTRSbXNqMWp2M1J3R04r?= =?utf-8?B?L01rdnJwV29MdGdXQytmMStGZStxOU1SY3BEQXhiZHZOQWhKYUJEem02VThY?= =?utf-8?B?YzJsRVBSekpmS01wSll1SFV3T25kMEMyL2U2L2tpZWJxMG1KN0dScng3NWlX?= =?utf-8?B?YTZCWUpVK3A0R2IrMDZCcUUzcVJZUkV0TXJiVGI4WnlrMWJzcXMvUmM0c2ti?= =?utf-8?B?NGJ6a3JMcHVLQWVwdzdPN1VHd0tGcWZUMUhmK1c2WkFpVzZVMVJ6WTdtV25Z?= =?utf-8?B?TytYRHg4OGtCYmZ6QVhwazJzTDFXWkIrZXlmUWEzMkFOcmQwa1pYcG51VHZo?= =?utf-8?B?bU13UWtWMXlqenljRzBjZExMNU1lc0lxVkM5UzBjVVpLWmxSeXhiakZUdjJM?= =?utf-8?B?Q0R6U0tlMmdqMFgvT2Z5RFFoUFFlUVA0b2RTc3NCMUhsbmVPNXdNMHNxK2E2?= =?utf-8?Q?LL7Kz9BJn2X2uPkIT92yOCm/5?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a2d52c6e-e7fb-4996-ae12-08daee3dadc3 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2023 10:23:10.3919 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WoAl85N9MhwIKw8rWZZ17GRhGbByxtFt0vAbjMh33O2k/TjneAGBigAIQelWuQ8pp/cj0RNrusSMTEwZvR2t2w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8074 On 23.12.2022 12:31, Julien Grall wrote: > On 20/12/2022 15:30, Jan Beulich wrote: >> On 16.12.2022 12:48, Julien Grall wrote: >>> From: Hongyan Xia >>> >>> This avoids the assumption that boot pages are in the direct map. >>> >>> Signed-off-by: Hongyan Xia >>> Signed-off-by: Julien Grall >> >> Reviewed-by: Jan Beulich >> >> However, ... >> >>> --- a/xen/arch/x86/srat.c >>> +++ b/xen/arch/x86/srat.c >>> @@ -139,7 +139,8 @@ void __init acpi_numa_slit_init(struct acpi_table_slit *slit) >>> return; >>> } >>> mfn = alloc_boot_pages(PFN_UP(slit->header.length), 1); >>> - acpi_slit = mfn_to_virt(mfn_x(mfn)); >>> + acpi_slit = vmap_contig_pages(mfn, PFN_UP(slit->header.length)); >> >> ... with the increased use of vmap space the VA range used will need >> growing. And that's perhaps better done ahead of time than late. > > I will have a look to increase the vmap(). > >> >>> + BUG_ON(!acpi_slit); >> >> Similarly relevant for the earlier patch: It would be nice if boot >> failure for optional things like NUMA data could be avoided. > > If you can't map (or allocate the memory), then you are probably in a > very bad situation because both should really not fail at boot. > > So I think this is correct to crash early because the admin will be able > to look what went wrong. Otherwise, it may be missed in the noise. Well, I certainly can see one taking this view. However, at least in principle allocation (or mapping) may fail _because_ of NUMA issues. At which point it would be better to boot with NUMA support turned off. Jan From xen-devel-bounces@lists.xenproject.org Wed Jan 04 10:27:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 10:27:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471101.730808 (Exim 4.92) (envelope-from ) id 1pD0zB-0000ck-4w; Wed, 04 Jan 2023 10:27:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471101.730808; Wed, 04 Jan 2023 10:27:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD0zB-0000cd-21; Wed, 04 Jan 2023 10:27:05 +0000 Received: by outflank-mailman (input) for mailman id 471101; Wed, 04 Jan 2023 10:27:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD0z9-0000cS-SM for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 10:27:03 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2054.outbound.protection.outlook.com [40.107.20.54]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 542d4b2a-8c1a-11ed-91b6-6bf2151ebd3b; Wed, 04 Jan 2023 11:27:02 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8074.eurprd04.prod.outlook.com (2603:10a6:10:24a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Wed, 4 Jan 2023 10:27:01 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5944.019; Wed, 4 Jan 2023 10:27:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 542d4b2a-8c1a-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mslr9fnSh/7Xy49QUClU2PK1DtCoL+fyNGTnyc3WBjM4CazDLIfG5q8k7EqquoC043UoixidCnHlCNDC3QQZcGwHuiqN99Xx4TYvdmyl+0qjYC1nRUXhlQzqxaA9fiYr76uEE4yn+WF7iLl+jKmnJlOFmcxG2e9PXrEhmV6a7Y1lx1IG8Y/cmdBQ7wYT7tIEgBcPGRQzsRM2lmtv/6SQIIRCkyD8U1e9L9YXP1fh1RivI1c4AmbCuXcIYXVp9hnlJOu4hapIrjSV4VInoTm+++IZwnTAidneYfL9whOw8vTd3h69cxkKQI7C/um/DGed2UxQ+5BvApUuXA3TPkUzdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tx015fr3bjIhPCp331DUzfxXuxihO+fi9PQYrtpxUYk=; b=btmbypBYR+HPRjanODVX7MV6/8K4CUqg9ST+eVHpol9qCKipmW/Hn+Iyk8zIBU7T6DDCl8H6tPem1c5EktjMhn+EnLvjgTf7uppRT5ZvdRxP/raaVEFkl7/D1Fab3Ap5yvYLXKxG7zjD7NgNUUdSAdFzkwoaqV/K3yTSio9gFSOPjMyhO1mkgWf1QDZeIS/hUWWzeeh+PBwp+BDuL5Evnsn4rmR6in2s2QO8fBK4ogcVp3IOrYcWIJCuN/sSICqAdpGs0Omi+Hp7mBQ358kNR1Kx5hRbqIiMIozp5S9I6GDnVUgwu5g/YWPDEBnWFYyXVJBCdDJLjfDD95BJIP1XmA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tx015fr3bjIhPCp331DUzfxXuxihO+fi9PQYrtpxUYk=; b=5jTSAepkHFrBJXxUZjb4a1iM44PJAXD+7iIrku5nIyN4SygtTuXeXSXsWtPZqy1SOWi391CIf+oIqt7EfQITFQnF+gCXT5FCcWRBFsxIPmnAo/UzQodS+1Gv3aioFse/VhiI/FOH5UPyRbggWUBFDLWSmRyi+B95G0cxlDC5BnJKoSB6LPSm2Lgm4iTcGXMazFJXeO1DaclAWdwZEW61El2TcEMh00GHjkKrrIqcEcYuXJCE3ykd0/yutgcomOLwGbpZcwMEeC0WhKmIrBtMP+w8l0rxrtsDqU0vMUljQtnZMZxOCC5pO6XWOtjSZGSopbiVMTgCBZVtVxNGhbWAig== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <01584e11-36ca-7836-85ad-bba9351af46e@suse.com> Date: Wed, 4 Jan 2023 11:27:09 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 06/22] x86: map/unmap pages in restore_all_guests Content-Language: en-US To: Julien Grall Cc: Hongyan Xia , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Julien Grall , xen-devel@lists.xenproject.org References: <20221216114853.8227-1-julien@xen.org> <20221216114853.8227-7-julien@xen.org> <478e04bc-6ff7-de01-dfb9-55d579228152@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0171.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:99::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8074:EE_ X-MS-Office365-Filtering-Correlation-Id: 9f95ef90-8dd0-497e-51d9-08daee3e3784 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: T+1yW+o7Qnjt+lVjetaPFSzisAz8qBiQDidy1G0vpDD/eRo7poUU2Z4K/hNCWAhTxF73b/Zl91YZNYlDxruEwmxecrt4cNUhrNR54Oic4zk9o8LLkbH3iRIdI48EODsq5hqnrLm/A4rahEmpEvlz6p8bGfNsWxemA/nodo8Di7qt8re8bf9DNCBOIq0XNOowRSAPEQiehDggBlvtPUZuAzUspmIeGaxOds/tEW02r/WYMT6/io8ao4zikMBusE4TthwTBaSKZ8dNjivQEBM+tfzCSPLp4Z9rjddOBL7Blp1QkUzkWyKtJsMOwp4TAiqsyfJbB1AemxUO9/44+uh32ceBKJ7awlbvtHLmKONRJqu6aNChEpLHxPwd6SyHsOpC7in34zGKxmdRl36D/6EqngDzytyJ7G+MZsv9Irh/ZgONnCPRFs1yg83UKmPt7kDUbmK/uCCESvZrPBh7ZfUIZsPA1SQEVG3Ln7hn0qzmYlR9d2sZBVbOMtTtbSmYslgXwQB/FY96/OO1HWgN8jLkozoiz12mKlqRcDlIVTSEwp2K4J2e6UxT70IJxe0WU4E02dI3SnWUURubu9uz23u0N/Kfo7YyelcOZDRd3GNcF2Q+0h6Vp2+ICLkc84hzJNcVxHnm+l+4FiXb4MIEcyF7MMjHQn5mxnReHXRzM8V2ObK02KzNX0aL1P3R4BcNPmPG9haQPdJkI2al+PCwk4Uwj798xA96ewCSwpMR/foT1tk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(376002)(346002)(136003)(396003)(366004)(451199015)(83380400001)(53546011)(26005)(2616005)(6506007)(6512007)(186003)(31696002)(36756003)(86362001)(38100700002)(8676002)(4326008)(41300700001)(2906002)(5660300002)(8936002)(31686004)(6486002)(478600001)(66946007)(316002)(66556008)(66476007)(54906003)(6916009)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MlpldnlueFo2WktUcGQwMGdYWHJoK2xIcVhhemFQSzh5TndNRWZoY281cldF?= =?utf-8?B?S05BS0xYeTg5ZEp3cUlxeld6d3Q0blBFalZZK2JhRCtHaHRUdlczRnZmcXdk?= =?utf-8?B?ekFpbnpaUXQyU3RIeU1jZGF5WmN5bTRVZVg0NzlwMklSQlVpeThTRVdYWDU3?= =?utf-8?B?Rm5lTWF5cVl3aFZ5L3ZFOGZSK1ZiWVJQNTBzc2lQUFZWeW5zTzlCV3FMU242?= =?utf-8?B?ZEVmbnNmR1N3RWJQY2FpU3U3RUlIS3pYYWVGWi9uWGJ3SkoyYWp4VUg1UHVr?= =?utf-8?B?cjc2akJsN3oreUlzampQOE5sUGYvSS9PWmhnUlRIVkI5emtrZHhJU0xaeWk1?= =?utf-8?B?ejVRUEZveGRLUGw1TGloUzJpb20yV1NJWVVEUUFsOVhzRi9OcUwyUE5EUDZr?= =?utf-8?B?QTIwbFB0OHpFTkkxczlCdFd5SEd3d2hXNCs1dWpCRHAxNWRRVVNkVENmYWZl?= =?utf-8?B?aDVtVWpYWVNoaWRySVl5a2lOYlZMRnhHUFFCcHhpYjhiSkMvV1dvTzdxV3d0?= =?utf-8?B?c3lsbnhWdDljdGlvZncvOVEySTZqZ1hOUTJmSTh1QlVCY2RKWjkyQUFLL1NX?= =?utf-8?B?eEp3QWdBUkNOVGQyRUxhL09MQjFSWUJiQXVFY2Y0bkhLVzR4Qk5ZTXR5dXJh?= =?utf-8?B?aFNJMHlVb3Bxb1M1VkZSL2c2Nlg1K2M1a2Y3OEc5UWYvSHhUbGxxSktVNlR1?= =?utf-8?B?a3JKVkxQaFFWYzdDNVhtMTJ0eEhaYjdJc09pb05yZnZkZ0l0OWpYVG9mQ1ZQ?= =?utf-8?B?b1lDVVpIeW5aWVcvbFU2WFRLbm5DSmNDNUIrUzd6T3BlR09TWU1tOGZWOFlY?= =?utf-8?B?cHNJU2NjL1lUS3FFVjVVNzFBMEkwV2l3V2RxSlZWMVUxVUNyZkptUm5zckk2?= =?utf-8?B?elNtdjFiQTRSZWVaRzFqYTZLYkgrdXJhSmRuK2lqRjREZGhNemszWUZZSmls?= =?utf-8?B?MWMwL3FQUEQ2ZVFTeXNPclFtNUVKOTNEcmVTYVlDQTVVYzByUTB4R0J4dDFG?= =?utf-8?B?NVNZMzlHc05QY2pGNDlnTU9LTGZQQjB2enFaVHVDdGx6Ly9zOFhFQ3QvT0Jo?= =?utf-8?B?Z1QxU3l3cTBueVlqS2xZWm1rUlJ3eEs5UTk5aHZEaTAvY2c2NlZKbk1XSFc4?= =?utf-8?B?M0Q0MUVqcGdPUVBQSkdCWE5WeTRiWDIyazJiU1VxOElaalJFbnVSSTFpV0xv?= =?utf-8?B?U3FQODNRTEFvRVZJb1FrSHo4SllFbFFzVkh0WjVIVTNBWnRUVkw5WmpGY3dl?= =?utf-8?B?OVZXWUNzOFBrMDhua2x2Y2xiWnBuZTRkcVQzdzlLS2k0bEEzYTcraEpIcDFz?= =?utf-8?B?VU01S0hTbkF5Z0JwTHRzckxka0NyR2FpWE5UemxFd3ZjKzdFUzJKQUp0cUdq?= =?utf-8?B?amxnRERSOXo1K2k1aTFZUHVja3FyY2NSbTRZMjRibGNUa0JDNktMUDd0L2tS?= =?utf-8?B?WkFVazBoQTFaMU9YQTV5QjlucmxqSWZwa1NIMVZEeWVzeGlIZ0Z3K1VHOW9r?= =?utf-8?B?ejR2K0x0eFFieUlpTFh5c3pmRnBrb0lkbEMvNEtmOWpNT3ZrcUxYUlJxRFBP?= =?utf-8?B?eFRmcGJSQkZYcHIrUUZsUVNOcGlJbWhjQzJQZlZPSHh4OXVVLzNNNTBid2Q1?= =?utf-8?B?MlBwVXpDRHBKTXhwb01vUWxyQnFsa0wyUWVRSU1zaEEzeGdkelNQb2tsZU9m?= =?utf-8?B?bkJPdW42Vzh5Mm1UaHNIZVpIYmZpbDFucEtGTXc1U3JZemNrWmtvR054Y01P?= =?utf-8?B?YTBtREwzU0xBWnZFcnlsYWI1TTBpYWt6RUFpZHB1ZE81aU5XZllNOUxxZ01G?= =?utf-8?B?UUM1eVNaME8vRTdkdG1OanFlYzVuM1R0MSsvWjRwZno5NnZkenVIV1Y2N3RM?= =?utf-8?B?Uks0RlZPbXF0ZXptWXJaVzlCSEY0bzIwalZJWldleXRLcmMvS1ZjeWJTaWRZ?= =?utf-8?B?eWx1b3UrMEY3VVBJNWlzbWFlNFFheFdIVUlhVG9IQy9mSnVWanRZRkw1S3ZY?= =?utf-8?B?ZURtSktucGI2dmdtYXF2NVBESTdxL2JyOHZxWW9TWUNZcnVad3hwRmlaRWhi?= =?utf-8?B?NGswRjRFcEs5QnB4SWlIcWVqVGNXcDBXeE1MQjA1aXdiTGI5a00razZvNXNm?= =?utf-8?Q?kK2ew9qPQzqhfvlNL8ZUWwoF2?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9f95ef90-8dd0-497e-51d9-08daee3e3784 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2023 10:27:01.4241 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: p2vgT1tWJOGUkUJou7l9W4T6VnhB2tFoQlaAmvc6CJXjSgwOHCAkCP4l53SYaNJOv+Pph592ydMm4TaAlmRmWw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8074 On 23.12.2022 13:22, Julien Grall wrote: > Hi, > > On 22/12/2022 11:12, Jan Beulich wrote: >> On 16.12.2022 12:48, Julien Grall wrote: >>> --- a/xen/arch/x86/x86_64/entry.S >>> +++ b/xen/arch/x86/x86_64/entry.S >>> @@ -165,7 +165,24 @@ restore_all_guest: >>> and %rsi, %rdi >>> and %r9, %rsi >>> add %rcx, %rdi >>> - add %rcx, %rsi >>> + >>> + /* >>> + * Without a direct map, we have to map first before copying. We only >>> + * need to map the guest root table but not the per-CPU root_pgt, >>> + * because the latter is still a xenheap page. >>> + */ >>> + pushq %r9 >>> + pushq %rdx >>> + pushq %rax >>> + pushq %rdi >>> + mov %rsi, %rdi >>> + shr $PAGE_SHIFT, %rdi >>> + callq map_domain_page >>> + mov %rax, %rsi >>> + popq %rdi >>> + /* Stash the pointer for unmapping later. */ >>> + pushq %rax >>> + >>> mov $ROOT_PAGETABLE_FIRST_XEN_SLOT, %ecx >>> mov root_table_offset(SH_LINEAR_PT_VIRT_START)*8(%rsi), %r8 >>> mov %r8, root_table_offset(SH_LINEAR_PT_VIRT_START)*8(%rdi) >>> @@ -177,6 +194,14 @@ restore_all_guest: >>> sub $(ROOT_PAGETABLE_FIRST_XEN_SLOT - \ >>> ROOT_PAGETABLE_LAST_XEN_SLOT - 1) * 8, %rdi >>> rep movsq >>> + >>> + /* Unmap the page. */ >>> + popq %rdi >>> + callq unmap_domain_page >>> + popq %rax >>> + popq %rdx >>> + popq %r9 >> >> While the PUSH/POP are part of what I dislike here, I think this wants >> doing differently: Establish a mapping when putting in place a new guest >> page table, and use the pointer here. This could be a new per-domain >> mapping, to limit its visibility. > > I have looked at a per-domain approach and this looks way more complex > than the few concise lines here (not mentioning the extra amount of > memory). Yes, I do understand that would be a more intrusive change. > So I am not convinced this is worth the effort here. > > I don't have an other approach in mind. So are you disliking this > approach to the point this will be nacked? I guess I wouldn't nack it, but I also wouldn't provide an ack. I'm curious what Andrew or Roger think here... Jan From xen-devel-bounces@lists.xenproject.org Wed Jan 04 11:12:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 11:12:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471109.730830 (Exim 4.92) (envelope-from ) id 1pD1gk-000622-Qo; Wed, 04 Jan 2023 11:12:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471109.730830; Wed, 04 Jan 2023 11:12:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD1gk-00061v-No; Wed, 04 Jan 2023 11:12:06 +0000 Received: by outflank-mailman (input) for mailman id 471109; Wed, 04 Jan 2023 11:12:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD1gj-0005kw-AA for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 11:12:05 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9d30ff2d-8c20-11ed-91b6-6bf2151ebd3b; Wed, 04 Jan 2023 12:12:04 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9d30ff2d-8c20-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1672830724; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=RmOdWMA5OLBNSSGKpmQKaV/mcBDHQ91bElXomYvQBTI=; b=S8kC3II/vWhQ5gA8MGDMfSsJPos/Wx2DQndl0BpjmYxJ/U1g7HYisteu QTrPvDk7K536kI0J3lTdYy4svV+SX/80ega9G6WTJGECgKe2vN0lW4Nyn 1ArVPhGNYZFsqEN91vpvDlKKB4k6mIUt6xCtYOYE5fmJy5MJYD9rcR9s2 k=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 93590517 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:IdDSV65w2jytOMymdgW9DgxRtDbHchMFZxGqfqrLsTDasY5as4F+v mQWXDiHbvyJZWH3Ldp/PtvjpBwOsJeHzIBgGwJr/H1nHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraBYnoqLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+4pwehBtC5gZlPakT4AeH/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m2 /gACw81fxe5tcmKh7ORS7dJhsktM5y+VG8fkikIITDxCP8nRdbIQrnQ5M8e1zA17ixMNa+AP YxDM2MpNUmeJU0UUrsUIMtWcOOAr3/zaTBH7nmSorI6+TP7xw1tyrn9dtHSf7RmQO0ExRvJ/ j+foAwVBDk0Nv/C0GHa/0ihg//9mTnRW541KuSRo6sCbFq7mTVIVUx+uUGAiea9ol6zXZRYM UN80jojq+0++VKmSvH5XgakuziUsxgEQd1SHuYmrgaXxcL8wSyUG2wFRT5pc8E9uYk9QjlC6 7OSt4q3X3o16uTTEC/DsOfPxd+vBcQLBUEGfQw7dRoC2evInMYypBORa9ZuHrHg27UZBgrM6 zyNqSE/gZAagsgKy7i38Dj7vt68mnTaZlVrv1uKBwpJ+is8Pdf4PNLwtTA3+N4adO6kok+9U G/ociR0xMQHFtmzmSOEW43h95n5tq/eYFUwbbOCdqTNFghBGVb5Jui8Axkkfi+F1/ronhe3C HI/QSsLuPdu0IKCNMebmb6ZBcUw1rTHHt/4TP3SZdcmSsEvK1XYo3k+NRbJgzCFfK0QfUYXY M7zTCpRJSxCVfQPIMSeHY/xLoPHNghhnDiOFPgXPjys0KaEZW79dIrpxGCmN7hjhIvd+VW9z jqqH5fSo/mpeLGkM3a/HE96BQxiEEXX8riv8ZQGLrTafVM2cIzjYteIqY4cl0Vet/w9vo/1E ruVACe0FHKXaaX7FDi3 IronPort-HdrOrdr: A9a23:h9quJKkiKRjEVKyHmo5p6XuzTVzpDfIi3DAbv31ZSRFFG/Fw9v rDoB1/73TJYVkqN03I9ervBEDjexPhHO9OgLX5VI3KNGOKhILCFvAA0WKN+UyEJwTOssJbyK d8Y+xfJbTLfDxHZB/BkWuFL+o= X-IronPort-AV: E=Sophos;i="5.96,299,1665460800"; d="scan'208";a="93590517" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH 0/2] x86: Work around Shstk fracturing Date: Wed, 4 Jan 2023 11:11:44 +0000 Message-ID: <20230104111146.2094-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit See patch 2 for details. Andrew Cooper (2): x86/cpuid: Infrastructure for leaves 7:1{ecx,edx} x86/shskt: Disable CET-SS on parts susceptible to fractured updates docs/misc/xen-command-line.pandoc | 7 ++++- tools/libs/light/libxl_cpuid.c | 2 ++ tools/misc/xen-cpuid.c | 11 +++++++ xen/arch/x86/cpu/common.c | 14 +++++++-- xen/arch/x86/setup.c | 46 ++++++++++++++++++++++++----- xen/include/public/arch-x86/cpufeatureset.h | 4 +++ xen/include/xen/lib/x86/cpuid.h | 15 +++++++++- 7 files changed, 86 insertions(+), 13 deletions(-) -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Wed Jan 04 11:12:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 11:12:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471108.730818 (Exim 4.92) (envelope-from ) id 1pD1ge-0005l9-DR; Wed, 04 Jan 2023 11:12:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471108.730818; Wed, 04 Jan 2023 11:12:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD1ge-0005l2-Ak; Wed, 04 Jan 2023 11:12:00 +0000 Received: by outflank-mailman (input) for mailman id 471108; Wed, 04 Jan 2023 11:11:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD1gd-0005kw-LH for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 11:11:59 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9962cbb2-8c20-11ed-91b6-6bf2151ebd3b; Wed, 04 Jan 2023 12:11:57 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9962cbb2-8c20-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1672830717; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Y4umxcgEQ+iPNN3hZApARntuGd8s3vbDQqyRC58FQsU=; b=ebw2b1zj1z+Z+ql8j5S1rVSnFQrceoiWqkfMPBtvJ/lmDyeHFxqiExx7 LuGlmw7jIBxVQAIPpvo2x3NBeSA4Gc5oKDS9tsoY3rPnhUlFts8ApF7yp 2CwW/ayEb3yTTsY461VRBxceKo1v3LpRYQUE1OseAkGbKFw5ujf7LsPfF 4=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 91153120 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:QUVk6agYuSaEWSW8w4oQtFgNX161bhAKZh0ujC45NGQN5FlHY01je htvUWyBaKuNYWb0fY1xO9y3/RlQvcXdztdkGlFprnhhQnwb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmUpH1QMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWs0N8klgZmP6sT5QeCzyB94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQ4OhIHNQyKo9iO2az4G7g8rO0cF+j0adZ3VnFIlVk1DN4jSJHHBa7L+cVZzHE7gcUm8fT2P pRDL2A1NVKZPkMJagx/5JEWxY9EglHWdTFCpU3Tjq0w+2XJlyR60aT3McqTcduPLSlQthfB/ z+dpj6hav0cHNrBywTaySuHvcuVmBLXG5xIF+H7x9c/1TV/wURMUUZLBDNXu8KRlUqWS99Zb UsO9UIGvaU0sUCmUNT5dxm5u2Kf+A4RXcJKFO834x3LzbDbiy67LGUZSj9KaPQ9qdQ7Azct0 ze0c8jBXGI19ufPEDTEq+nS/Wja1TUpwXEqRT0mR1AZ6v3ZmJgtzUOeHvxKL5WUkYigcd3v+ AyioC87jrQVqMcE0aSn4FzK6w6RSoj1oh0dvVuOAD/8hu9tTMv8PtHztwCHhRpVBNzBJmRtq kTojCR3AAomKZiW3BKAT+wWdF1Cz6bUaWaM6bKD8nRIythMx5JBVdoLiN2dDB0zWirhRdMOS BG7hO+pzMUPVEZGlIcuC25LN+wkzLL7CfPuXe3OY9xFb/BZLVHYpn4xPR7AhzmxwCDAdJ3T3 r/CKK6R4YsyU/w7nFJauc9HuVPU+szO7TyKHs2qp/hW+bGfeGSUWd84Dbd6VchgtPnsiFyMo 75i2z6il003vBvWPnOGrub+7DkicRAGOHwBg5UNLr/beFM5QTFJ5j246epJRrGJVp99zo/gl kxRkGcBoLYjrRUr8Tm3V00= IronPort-HdrOrdr: A9a23:DCTKYqhnDQlvEpstI9xAbQV4aXBQXjwji2hC6mlwRA09TyVXrb HKoB0+7268tN9xYgBXpTnkAtjJfZqyz/5ICOMqTMKftWXdyQiVxcRZnPPfKxOJIVyOygd279 YST0CVYOeAc2SS9PyKnzVQcOxQueVuIcqT9JXjJhVWPGZXgvpbnntE42+geyVLrUt9dPwE/f ynl756ThWbCAQqh6+Adx04tob41r/2fVHdEGk777NN0mWzZbTC0s+GL/BNtS1uKQ+nCI1Imw Wr/W3EDsnPiYDB9iPh X-IronPort-AV: E=Sophos;i="5.96,299,1665460800"; d="scan'208";a="91153120" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH 2/2] x86/shskt: Disable CET-SS on parts susceptible to fractured updates Date: Wed, 4 Jan 2023 11:11:46 +0000 Message-ID: <20230104111146.2094-3-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20230104111146.2094-1-andrew.cooper3@citrix.com> References: <20230104111146.2094-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Refer to Intel SDM Rev 70 (Dec 2022), Vol3 17.2.3 "Supervisor Shadow Stack Token". Architecturally, an event delivery which starts in CPL<3 and switches shadow stack will first validate the Supervisor Shadow Stack Token (setting the busy bit), then pushes CS/LIP/SSP. One example of this is an NMI interrupting Xen. Some CPUs suffer from an issue called fracturing, whereby a fault/vmexit/etc between setting the busy bit and completing the event injection renders the action non-restartable, because when it comes time to restart, the busy bit is found to be already set. This is far more easily encountered under virt, yet it is not the fault of the hypervisor, nor the fault of the guest kernel. The fault lies somewhere between the architectural specification, and the uarch behaviour. Intel have allocated CPUID.7[1].ecx[18] CET_SSS to enumerate that supervisor shadow stacks are safe to use. Because of how Xen lays out its shadow stacks, fracturing is not expected to be a problem on native. Detect this case on boot and default to not using shstk if virtualised. Specifying `cet=shstk` on the command line will override this heuristic and enable shadow stacks irrespective. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu v2: * Confirmation from AMD that their parts are not impacted. * Fix pv-shim build. The "define false" trick doesn't work with tristates. * Tweak wording in several places. * Fix tabs vs spaces. This ideally wants backporting to Xen 4.14. I have no idea how likely it is to need to backport the prerequisite patch for new feature words, but we've already had to do that once for security patches. OTOH, I have no idea how easy it is to trigger in non-synthetic cases. --- docs/misc/xen-command-line.pandoc | 7 ++++- tools/libs/light/libxl_cpuid.c | 2 ++ tools/misc/xen-cpuid.c | 1 + xen/arch/x86/cpu/common.c | 11 +++++-- xen/arch/x86/setup.c | 46 ++++++++++++++++++++++++----- xen/include/public/arch-x86/cpufeatureset.h | 1 + 6 files changed, 57 insertions(+), 11 deletions(-) diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc index 923910f553c5..19d4d815bdee 100644 --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -287,10 +287,15 @@ can be maintained with the pv-shim mechanism. protection. The option is available when `CONFIG_XEN_SHSTK` is compiled in, and - defaults to `true` on hardware supporting CET-SS. Specifying + generally defaults to `true` on hardware supporting CET-SS. Specifying `cet=no-shstk` will cause Xen not to use Shadow Stacks even when support is available in hardware. + Some hardware suffers from an issue known as Supervisor Shadow Stack + Fracturing. On such hardware, Xen will default to not using Shadow Stacks + when virtualised. Specifying `cet=shstk` will override this heuristic and + enable Shadow Stacks unilaterally. + * The `ibt=` boolean controls whether Xen uses Indirect Branch Tracking for its own protection. diff --git a/tools/libs/light/libxl_cpuid.c b/tools/libs/light/libxl_cpuid.c index 2aa23225f42c..d97a2f3338bc 100644 --- a/tools/libs/light/libxl_cpuid.c +++ b/tools/libs/light/libxl_cpuid.c @@ -235,6 +235,8 @@ int libxl_cpuid_parse_config(libxl_cpuid_policy_list *cpuid, const char* str) {"fsrs", 0x00000007, 1, CPUID_REG_EAX, 11, 1}, {"fsrcs", 0x00000007, 1, CPUID_REG_EAX, 12, 1}, + {"cet-sss", 0x00000007, 1, CPUID_REG_EDX, 18, 1}, + {"intel-psfd", 0x00000007, 2, CPUID_REG_EDX, 0, 1}, {"mcdt-no", 0x00000007, 2, CPUID_REG_EDX, 5, 1}, diff --git a/tools/misc/xen-cpuid.c b/tools/misc/xen-cpuid.c index addb3a39a11a..0248eaef44c1 100644 --- a/tools/misc/xen-cpuid.c +++ b/tools/misc/xen-cpuid.c @@ -208,6 +208,7 @@ static const char *const str_7c1[32] = static const char *const str_7d1[32] = { + [18] = "cet-sss", }; static const char *const str_7d2[32] = diff --git a/xen/arch/x86/cpu/common.c b/xen/arch/x86/cpu/common.c index b3fcf4680f3a..27f73d3bbe31 100644 --- a/xen/arch/x86/cpu/common.c +++ b/xen/arch/x86/cpu/common.c @@ -346,11 +346,18 @@ void __init early_cpu_init(void) x86_cpuid_vendor_to_str(c->x86_vendor), c->x86, c->x86, c->x86_model, c->x86_model, c->x86_mask, eax); - if (c->cpuid_level >= 7) - cpuid_count(7, 0, &eax, &ebx, + if (c->cpuid_level >= 7) { + uint32_t max_subleaf; + + cpuid_count(7, 0, &max_subleaf, &ebx, &c->x86_capability[FEATURESET_7c0], &c->x86_capability[FEATURESET_7d0]); + if (max_subleaf >= 1) + cpuid_count(7, 1, &eax, &ebx, &ecx, + &c->x86_capability[FEATURESET_7d1]); + } + eax = cpuid_eax(0x80000000); if ((eax >> 16) == 0x8000 && eax >= 0x80000008) { ebx = eax >= 0x8000001f ? cpuid_ebx(0x8000001f) : 0; diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index 566422600d94..1b8b74599f4a 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -95,11 +95,7 @@ unsigned long __initdata highmem_start; size_param("highmem-start", highmem_start); #endif -#ifdef CONFIG_XEN_SHSTK -static bool __initdata opt_xen_shstk = true; -#else -#define opt_xen_shstk false -#endif +static int8_t __initdata opt_xen_shstk = -IS_ENABLED(CONFIG_XEN_SHSTK); #ifdef CONFIG_XEN_IBT static bool __initdata opt_xen_ibt = true; @@ -1099,11 +1095,45 @@ void __init noreturn __start_xen(unsigned long mbi_p) early_cpu_init(); /* Choose shadow stack early, to set infrastructure up appropriately. */ - if ( opt_xen_shstk && boot_cpu_has(X86_FEATURE_CET_SS) ) + if ( !boot_cpu_has(X86_FEATURE_CET_SS) ) + opt_xen_shstk = 0; + + if ( opt_xen_shstk ) { - printk("Enabling Supervisor Shadow Stacks\n"); + /* + * Some CPUs suffer from Shadow Stack Fracturing, an issue whereby a + * fault/VMExit/etc between setting a Supervisor Busy bit and the + * event delivery completing renders the operation non-restartable. + * On restart, event delivery will find the Busy bit already set. + * + * This is a problem on bare metal, but outside of synthetic cases or + * a very badly timed #MC, it's not believed to problem. It is a much + * bigger problem under virt, because we can VMExit for a number of + * legitimate reasons and tickle this bug. + * + * CPUs with this addressed enumerate CET-SSS to indicate that + * supervisor shadow stacks are now safe to use. + */ + bool cpu_has_bug_shstk_fracture = + boot_cpu_data.x86_vendor == X86_VENDOR_INTEL && + !boot_cpu_has(X86_FEATURE_CET_SSS); - setup_force_cpu_cap(X86_FEATURE_XEN_SHSTK); + /* + * On bare metal, assume that Xen won't be impacted by shstk + * fracturing problems. Under virt, be more conservative and disable + * shstk by default. + */ + if ( opt_xen_shstk == -1 ) + opt_xen_shstk = + cpu_has_hypervisor ? !cpu_has_bug_shstk_fracture + : true; + + if ( opt_xen_shstk ) + { + printk("Enabling Supervisor Shadow Stacks\n"); + + setup_force_cpu_cap(X86_FEATURE_XEN_SHSTK); + } } if ( opt_xen_ibt && boot_cpu_has(X86_FEATURE_CET_IBT) ) diff --git a/xen/include/public/arch-x86/cpufeatureset.h b/xen/include/public/arch-x86/cpufeatureset.h index 7a896f0e2d92..f6a46f62a549 100644 --- a/xen/include/public/arch-x86/cpufeatureset.h +++ b/xen/include/public/arch-x86/cpufeatureset.h @@ -290,6 +290,7 @@ XEN_CPUFEATURE(INTEL_PPIN, 12*32+ 0) /* Protected Processor Inventory /* Intel-defined CPU features, CPUID level 0x00000007:1.ecx, word 14 */ /* Intel-defined CPU features, CPUID level 0x00000007:1.edx, word 15 */ +XEN_CPUFEATURE(CET_SSS, 15*32+18) /* CET Supervisor Shadow Stacks safe to use */ /* Intel-defined CPU features, CPUID level 0x00000007:2.edx, word 13 */ XEN_CPUFEATURE(INTEL_PSFD, 13*32+ 0) /*A MSR_SPEC_CTRL.PSFD */ -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Wed Jan 04 11:12:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 11:12:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471110.730841 (Exim 4.92) (envelope-from ) id 1pD1gm-0006I7-2i; Wed, 04 Jan 2023 11:12:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471110.730841; Wed, 04 Jan 2023 11:12:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD1gl-0006I0-Vz; Wed, 04 Jan 2023 11:12:07 +0000 Received: by outflank-mailman (input) for mailman id 471110; Wed, 04 Jan 2023 11:12:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD1gk-0005kw-GW for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 11:12:06 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9ee64cf1-8c20-11ed-91b6-6bf2151ebd3b; Wed, 04 Jan 2023 12:12:05 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9ee64cf1-8c20-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1672830725; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=UAKOXtp3MBtKPheGYD3/xlv27YzzrN4rSPgxLhvD/Gw=; b=gsmztJ5C15L7xl8g1EBQWbQHx3f7E+sRte6/Ie2UVzZ0mnXeGwEqIBZ2 8Q8R4Aoy8MRxnI/ptxIzVfMfyimU1plmfMeJl4VqzGCC9oe2PhayoXbzz p68ax8G9BKYci/UN8HEeq18cwqqoSOm8OjM4QZa8JoHgp2nttozNI0KpD 4=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 93590518 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:/saynqt14HnKlcVzlDMXqR6G8OfnVFheMUV32f8akzHdYApBsoF/q tZmKWDVbqyOZWHzKYt/bN/npxgH756AxoNqHgZr+3g9EypH+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg0HVU/IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj5lv0gnRkPaoQ5AaGyyFMZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwBjQVTS+7luWM8pmHDehGh5oGLMTlI9ZK0p1g5Wmx4fcORJnCR+PB5MNC3Sd2jcdLdRrcT 5NHM3w1Nk2GOkARfAdMYH49tL7Aan3XWjtUsl+K44Ew5HDe1ldZ27nxKtvFPNeNQK25m27J/ T+XpzmgUnn2MvS8zRuZ23apm9bPvnLyfJwvGuW3ytV11Qj7Kms7V0RNCArTTeOColG6c8JSL QoT4CVGhYoY+VGvT9L9dwalu3PCtRkZM/JAHut/5AyTx6785weCGnNCXjNHcMYhtsI9WXotz FDhoj/yLWUx6vvPEyvbr+rK62PpUcQIEYMcTQEAVSg628jkmrMYslXOZNc9Na64gMKgTFkc3 Au2hCQ5grwSi+sC2KO64U3LjlqQm3TZcuImzl6JBzz4t2uVcKbgPtX1sgaDsZ6sOa7DFjG8U G44d99yBQzkJbWEj2SzTeoEB9lFDN7VYWSH0TaD83TMnglBGkJPn6gKu1mSx28zaK7onAMFh 2eN0T69HLcJYBOXgVZfOupd8fgCw6n6DsjCXfvJdNdIaZUZXFbZo3sxOhbAjzi0zBhEfUQD1 XCzKJ/EMJrnIf4/kGreqxk1i9fHORzSNUuMHMumnnxLIJKVZWKPSKdtDWZimtsRtfveyC2Mq oY3Cid/40kHOAEISnWNoNF7wJFjBSRTOK0aXOQOLLbSelA/RzhxYxITqJt4E7FYc21uvr+g1 hmAtoVwkTITWVWvxd22V01e IronPort-HdrOrdr: A9a23:Enyza6labInGAmMNtvOt8hz+WEXpDfIi3DAbv31ZSRFFG/Fw9v rDoB1/73TJYVkqN03I9ervBEDjexPhHO9OgLX5VI3KNGOKhILCFvAA0WKN+UyEJwTOssJbyK d8Y+xfJbTLfDxHZB/BkWuFL+o= X-IronPort-AV: E=Sophos;i="5.96,299,1665460800"; d="scan'208";a="93590518" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH 1/2] x86/cpuid: Infrastructure for leaves 7:1{ecx,edx} Date: Wed, 4 Jan 2023 11:11:45 +0000 Message-ID: <20230104111146.2094-2-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20230104111146.2094-1-andrew.cooper3@citrix.com> References: <20230104111146.2094-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit We don't actually need ecx yet, but adding it in now will reduce the amount to which leaf 7 is out of order in a featureset. cpufeatureset.h remains in leaf architectrual order for the sanity of anyone trying to locate where to insert new rows. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu v2: * Fix decodes[] short string --- tools/misc/xen-cpuid.c | 10 ++++++++++ xen/arch/x86/cpu/common.c | 3 ++- xen/include/public/arch-x86/cpufeatureset.h | 3 +++ xen/include/xen/lib/x86/cpuid.h | 15 ++++++++++++++- 4 files changed, 29 insertions(+), 2 deletions(-) diff --git a/tools/misc/xen-cpuid.c b/tools/misc/xen-cpuid.c index d5833e9ce879..addb3a39a11a 100644 --- a/tools/misc/xen-cpuid.c +++ b/tools/misc/xen-cpuid.c @@ -202,6 +202,14 @@ static const char *const str_7b1[32] = [ 0] = "ppin", }; +static const char *const str_7c1[32] = +{ +}; + +static const char *const str_7d1[32] = +{ +}; + static const char *const str_7d2[32] = { [ 0] = "intel-psfd", @@ -229,6 +237,8 @@ static const struct { { "0x80000021.eax", "e21a", str_e21a }, { "0x00000007:1.ebx", "7b1", str_7b1 }, { "0x00000007:2.edx", "7d2", str_7d2 }, + { "0x00000007:1.ecx", "7c1", str_7c1 }, + { "0x00000007:1.edx", "7d1", str_7d1 }, }; #define COL_ALIGN "18" diff --git a/xen/arch/x86/cpu/common.c b/xen/arch/x86/cpu/common.c index 0412dbc915e5..b3fcf4680f3a 100644 --- a/xen/arch/x86/cpu/common.c +++ b/xen/arch/x86/cpu/common.c @@ -450,7 +450,8 @@ static void generic_identify(struct cpuinfo_x86 *c) cpuid_count(7, 1, &c->x86_capability[FEATURESET_7a1], &c->x86_capability[FEATURESET_7b1], - &tmp, &tmp); + &c->x86_capability[FEATURESET_7c1], + &c->x86_capability[FEATURESET_7d1]); if (max_subleaf >= 2) cpuid_count(7, 2, &tmp, &tmp, &tmp, diff --git a/xen/include/public/arch-x86/cpufeatureset.h b/xen/include/public/arch-x86/cpufeatureset.h index 7915f5826f57..7a896f0e2d92 100644 --- a/xen/include/public/arch-x86/cpufeatureset.h +++ b/xen/include/public/arch-x86/cpufeatureset.h @@ -288,6 +288,9 @@ XEN_CPUFEATURE(NSCB, 11*32+ 6) /*A Null Selector Clears Base (and /* Intel-defined CPU features, CPUID level 0x00000007:1.ebx, word 12 */ XEN_CPUFEATURE(INTEL_PPIN, 12*32+ 0) /* Protected Processor Inventory Number */ +/* Intel-defined CPU features, CPUID level 0x00000007:1.ecx, word 14 */ +/* Intel-defined CPU features, CPUID level 0x00000007:1.edx, word 15 */ + /* Intel-defined CPU features, CPUID level 0x00000007:2.edx, word 13 */ XEN_CPUFEATURE(INTEL_PSFD, 13*32+ 0) /*A MSR_SPEC_CTRL.PSFD */ XEN_CPUFEATURE(IPRED_CTRL, 13*32+ 1) /* MSR_SPEC_CTRL.IPRED_DIS_* */ diff --git a/xen/include/xen/lib/x86/cpuid.h b/xen/include/xen/lib/x86/cpuid.h index 73a5c330365e..fa98b371eef4 100644 --- a/xen/include/xen/lib/x86/cpuid.h +++ b/xen/include/xen/lib/x86/cpuid.h @@ -18,6 +18,8 @@ #define FEATURESET_e21a 11 /* 0x80000021.eax */ #define FEATURESET_7b1 12 /* 0x00000007:1.ebx */ #define FEATURESET_7d2 13 /* 0x00000007:2.edx */ +#define FEATURESET_7c1 14 /* 0x00000007:1.ecx */ +#define FEATURESET_7d1 15 /* 0x00000007:1.edx */ struct cpuid_leaf { @@ -194,7 +196,14 @@ struct cpuid_policy uint32_t _7b1; struct { DECL_BITFIELD(7b1); }; }; - uint32_t /* c */:32, /* d */:32; + union { + uint32_t _7c1; + struct { DECL_BITFIELD(7c1); }; + }; + union { + uint32_t _7d1; + struct { DECL_BITFIELD(7d1); }; + }; /* Subleaf 2. */ uint32_t /* a */:32, /* b */:32, /* c */:32; @@ -343,6 +352,8 @@ static inline void cpuid_policy_to_featureset( fs[FEATURESET_e21a] = p->extd.e21a; fs[FEATURESET_7b1] = p->feat._7b1; fs[FEATURESET_7d2] = p->feat._7d2; + fs[FEATURESET_7c1] = p->feat._7c1; + fs[FEATURESET_7d1] = p->feat._7d1; } /* Fill in a CPUID policy from a featureset bitmap. */ @@ -363,6 +374,8 @@ static inline void cpuid_featureset_to_policy( p->extd.e21a = fs[FEATURESET_e21a]; p->feat._7b1 = fs[FEATURESET_7b1]; p->feat._7d2 = fs[FEATURESET_7d2]; + p->feat._7c1 = fs[FEATURESET_7c1]; + p->feat._7d1 = fs[FEATURESET_7d1]; } static inline uint64_t cpuid_policy_xcr0_max(const struct cpuid_policy *p) -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Wed Jan 04 11:17:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 11:17:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471130.730852 (Exim 4.92) (envelope-from ) id 1pD1m4-0007aO-Mj; Wed, 04 Jan 2023 11:17:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471130.730852; Wed, 04 Jan 2023 11:17:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD1m4-0007aH-Jw; Wed, 04 Jan 2023 11:17:36 +0000 Received: by outflank-mailman (input) for mailman id 471130; Wed, 04 Jan 2023 11:17:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD1m3-0007a9-Ou for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 11:17:35 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 60feff1a-8c21-11ed-b8d0-410ff93cb8f0; Wed, 04 Jan 2023 12:17:32 +0100 (CET) Received: from mail-bn7nam10lp2102.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.102]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Jan 2023 06:17:27 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BN8PR03MB5106.namprd03.prod.outlook.com (2603:10b6:408:df::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Wed, 4 Jan 2023 11:17:25 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5944.019; Wed, 4 Jan 2023 11:17:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 60feff1a-8c21-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1672831052; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=PF5+qnr50HlgCu8Yl2X1uruIFc58QQfovGua4qn8lv4=; b=gDDCJvyD5LVz+aaebL1+tjcxiSrwFQdXwXQLWlzMwBZ0/trALrBvbgys 0NDMPj1AFmFSSe24PP8c4yINyg7gQTSYrpg38SDLwa8eMfZlTzY4N+fBv zfMMZ4oP5wLJu1zNIw9engF+zxU1DSCB9FSXPo9QbyjKCbkClAmZvR1GE w=; X-IronPort-RemoteIP: 104.47.70.102 X-IronPort-MID: 90603934 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:1gmxqqw9Xv9GXNDNl296t+cVxyrEfRIJ4+MujC+fZmUNrF6WrkVRm GAaUGGFafaIYWDxLYslO4rlo04EvJ7Rn982Tgpq+yAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTbaeYUidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+U0HUMja4mtC5QRnPawT5TcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KURH5 9kXGQldVymK3s2E77eyePNNoO12eaEHPKtH0p1h5RfwKK9+BLrlHODN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvDCVlVQruFTuGIO9ltiibMNZhEuH4 EnB+Hz0GEoyP92D0zuVtHmrg4cjmAuqANxKT+zjqpaGhnWI+0gyGRkGfmKyqN+Yo3GwfohUF n4br39GQa8asRbDosPGdw21pjuIswARX/JUEvYm80edx6zM+QGbC2MYCDlbZ7QOluU7WDgr3 V+hhM7yCHpkt7j9YW2Z3qeZq3W1Iyd9EIMZTSoNTA9A6d+8pog210rLVow6SPTzicDpEzbtx TzMtDI5m7gYkc8M0eO84EzDhDWv4JPOS2bZ+znqY45s1SshDKbNWmBiwQKzASpoRGpBcmS8g Q== IronPort-HdrOrdr: A9a23:WE6k0qkJEO6WsZVIOKYnb6ey1jjpDfIi3DAbv31ZSRFFG/Fw9v rDoB1/73TJYVkqN03I9ervBEDjexPhHO9OgLX5VI3KNGOKhILCFvAA0WKN+UyEJwTOssJbyK d8Y+xfJbTLfDxHZB/BkWuFL+o= X-IronPort-AV: E=Sophos;i="5.96,299,1665460800"; d="scan'208";a="90603934" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mDRzcU2PmNald1yoXvo+VnSSH4clZOOM5mLjk4wQKeem1UBZ/mHtg72oSBa8mQH/5/iNthXUap3t2zcqTkKgz0Ff2+Iqv3GEq7g+h0JOcowMAmyIjwezQXZ4fO8zAvi5fW+xT2GbO+1Xt9Gm5pRl+fiddYqGfZ+Oi/K8OySEE7kfw/bqrClqE79lVTVisuKL/fx8fJhTvM2TQ/t26LqVAEgmC6bmK7MWSVB9mo74YR9CvFFWjjO88A/hW9zQQeh+8j+ywbsfrz3NlUO+PPfauRFITYK7nxJWoxTRVdRuen8gYqLU5vqTKFTTA6S35T0bZTM1GfdNVol++JM4/9vJYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PF5+qnr50HlgCu8Yl2X1uruIFc58QQfovGua4qn8lv4=; b=KH57fZl8i7h6s7RvA1GVUjKMPYt8m002JxrvC62fjdch27gkUm+K2ob6CRX4D/Mk0o0+yZh4yKQzby0ieQy+2cw98d4aCRCzOEzyKxRL+a4a8t/ekbjhZlgtIaoAy2qeThABJr/wDBtHHadIIKuBEjLkELmaelaX/hMO0NF7WgIo5bIUAMMeYHyXFd3IwiuhPLmb2YKCQUFb23z2gOKQnVIFLR7Ujw4SPd68fAoM9Ehh1SfPiUGMUb14qUdF+AbteO3QLRCPEXabXCXedoKujePBPxGra9evpCri/p4fRAAq1UfyLvvznI7KLrjS2KAcRtTPU1Rv0E1bPBVASEsT1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PF5+qnr50HlgCu8Yl2X1uruIFc58QQfovGua4qn8lv4=; b=MIpgHvxe99QbgZrZYZ+5Pd3ReJCZi6OHCDjSKB8HBCdiQWwZVnrFAhvi4VZyrLjDD2lDk9Cpt08NJzsFzUzaMWhmWsvviPg+KLnM/yqwMQLBGsq2Io+GEBdayAOVxQSx/7U0TDCUD9/hsBhmeFWDvBOcrQ7CQQej0y8o+r8TllU= From: Andrew Cooper To: Xen-devel CC: Jan Beulich , Roger Pau Monne , Wei Liu Subject: Re: [PATCH v2 0/2] x86: Work around Shstk fracturing Thread-Topic: [PATCH v2 0/2] x86: Work around Shstk fracturing Thread-Index: AQHZIC4eprKe1GLtgUSigry+xdpDWw== Date: Wed, 4 Jan 2023 11:17:24 +0000 Message-ID: <028d658d-db7d-9cd0-08aa-9033bc65e547@citrix.com> References: <20230104111146.2094-1-andrew.cooper3@citrix.com> In-Reply-To: <20230104111146.2094-1-andrew.cooper3@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|BN8PR03MB5106:EE_ x-ms-office365-filtering-correlation-id: f721dea9-21b6-45ad-c6f1-08daee45417a x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Vgk15gTQXxlmOO+SE/oe5OzHtwzrgZmqYuoPKBOItQhttvBt4m1qx+iWnS7QWrFEgrBQbIK7o0oNO26vXZCzpTxJe8LlxmQuku2HEoSsJMHceAVX3XnN9MOtH/AYP7VaWuAhIWpvP4fqEneLeT8D6vvOKxs2+IDcQX9eN+2v71e4ZW3+evCwrwZmdQ/aEom0+0N0x/nM4TQso++L5TecWBzyoinlKQy8S2vyHExC4/SSYXt6J4M4/3FQ0agd1+AXfH5E+JQuvPMtbMfeA5kkiZQP08pnswtJcYejMJYJbDKUDXOLRM3rskAhB/ndEGzC5T0alHfE9qBNuCJJgJ4qpdCHSiGCdMHdcIbXE6a9DFqSjtWTIPN3p0HDOJUGi7RM5ipmBm9zJQ2Mg+ACz0di3BQ9IWCjMHfdImNES9XggylusEiyj5Z1CeIMTR+767CWvu1ZMcxkbqL0QJOVYF5X1XgJXPTvNDalWIJF+f8RLPAwJTo86yIwQ9kN40g8d5JaZwSm4wuKBMDT1BObhBXYT2jXBQmMfe3wcKR8kSULLXpmBu5Ccjbb1VVWKSMR/XrEI/oTF6uZvGrNXwn2TLAkeYUlYpXQwvvk+Ano5Ph/1OdT5aEgHMqh9GkbDURPqjtXyIOzpby6nz581dNATZqMb7re/ipaBKukCN/oBENCXpQq10/2FPb3mTAgphbFTLQux0U4QiYSoCws6fRKIv+4WBKkK4WoMBWBI2oyKVypms6hjfoQvRdPmRkOg7LLO9aVO68O3RSbNdrMBddyOU6Dcw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(346002)(39860400002)(376002)(396003)(136003)(451199015)(6506007)(26005)(6512007)(2616005)(53546011)(186003)(86362001)(31696002)(558084003)(38070700005)(36756003)(82960400001)(38100700002)(122000001)(478600001)(8676002)(4326008)(41300700001)(2906002)(5660300002)(8936002)(66476007)(6486002)(71200400001)(31686004)(316002)(76116006)(66556008)(66946007)(54906003)(91956017)(66446008)(64756008)(6916009)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?TlNOSStCcTJaaHR6WUEwU0pYelZOQkVNdFlZZjJjN2szYUhvVnFuMnJiU2JI?= =?utf-8?B?cmVKTzdPb0tMZkNIR1llaWgzbFlibG10T3FoUFBVRGVXazZoMHFWRGhNRnZI?= =?utf-8?B?Y1NYLzNRTU9VSUxUcjEya1ByYlR1OUlUN1pXWDN2a2svT04vQlhhNVZBZmI0?= =?utf-8?B?UVZickRTN0Z6ckFGTmdGRS9jU0NvQ1dWSTMvT0FGNFFaUkRWN2tCOWZUVi9a?= =?utf-8?B?WE5OS1o3dlJVRlJvcWVKQVpxbCtOcERicXNzUTBqVUNaVVUwbi9JenF3dmxU?= =?utf-8?B?MWI1RG5salJ0SjFtak95TXQ4WW8rYStrY250VWx2ekowdjhLMldXTUlMNWFt?= =?utf-8?B?em5IWFI0OHFXYmhMTTV1UDRwa0FNUG1FV1Vpbi8rWi9HQ0JuU1VOQWFYSUN6?= =?utf-8?B?d3RpSks0akVXZFI4QlphOFNMUmxsaFBnckdTdXpZUjg2Z1MzSjJQZ01pQTBa?= =?utf-8?B?ckh5Y253bzUzQ040c2FicGtjR0Z5UFFDbms0d29zMjM2UEdRdDB1S01KcldE?= =?utf-8?B?bEdmRmQrZGVjcW5Ea0pRc1Rld0tKMFp5WEg0QldGbkZ3Y2l2c2FSelRNRVdn?= =?utf-8?B?Sk9ZV0tNS2ZNaUhhajZHanZwUk5mUHZxZ1BxVE9KeWJSVE9TcWhWZmR6MGJ2?= =?utf-8?B?amp5VDhIQnNTdTE2MWNGMnFObEhQTkg0a3VkdnJ4SmxwVzZ6eWw0dGpIL1hq?= =?utf-8?B?ejJKMDNPUXY4cUxsQ0ZJV2o0SXRROXIyYzN5TWlMYzhyRXpORi9sZ1Urc3Nw?= =?utf-8?B?a29tU1JvZk5zWTBqckEwN1JmQjF0V3BaeGJRMHpFRXBlZWRuNlZwM0VQcjQ2?= =?utf-8?B?RlBjNlNUM3I5T3dJVlpGUUFZSzdQYitLRER3ZFRwODg5Mlg1MG5tTWNrTG1M?= =?utf-8?B?REptZ3pYUE5SWUIxK1JwUWo4NUlScnZlK1VHbDZ1VzI4M091RVBhTU1wV3Zm?= =?utf-8?B?Zm01NVg2SGlGM1grMlZraTJ4bGpvVnBBajhleDRQMFR5RjYwSzBuVlpuZEpj?= =?utf-8?B?UFM1ZlFkckZCd2FIOGtlbWN3T3lOS3NuTU1kRmpKaU9wTndtVnFIYm5VdHk5?= =?utf-8?B?bEVFY1ovVk5kaGJUZmROTEx1SjBHL2NBVGdxb21PVTVYV1BtWnplWFRubVZI?= =?utf-8?B?ZStRNzRoSTFBNU16SzYzaDU4MUlaZ3NPY0VlcEJIQlN4NXJOTGdtQ2NsZHlX?= =?utf-8?B?MDBQVDBkZHVZTVIwNnVya1JybkhkZXNqZHBHQm5EckdLTHVZSHhlcis1L3Ay?= =?utf-8?B?a3hFWWowR0JGRkJlQWJNSlhGZ3pVV2dqVVFBTmEvVGF4b3V0RTVscmkzcWRN?= =?utf-8?B?OXFyWDZSRmE1WEFMMGlpV2JCOGtyMXJVaGk5ZGdhbnU1blViSzU5UkU1MjBD?= =?utf-8?B?SS8waytEYXRzMjNicUZvWUl4d3dKcnVMSlFHK0hSZGsvTEIxVkswVkQwTFIv?= =?utf-8?B?dUJseGJaS1ZKMnJKWTk4YUY1bmo5bGhVU1VHVitiZVhLYVZIdFQ5VFBha3lY?= =?utf-8?B?VElKcTJBdnUwQk1TU1FBWWpXRFdHVlVHT0ltZmUvZDRwaE9VVEp6OGlMbnM4?= =?utf-8?B?b2VvdDZLck1UbkU4N1VCTTF0WnpPSEFmc0dqdVdqSktwSHBNZStEcHF3Y1A5?= =?utf-8?B?VXd4RmFoc3FyU2IyOXBrRHZsanhFRWNrRUJIQnRvNnVJdU1SWTNyZzNHQmM4?= =?utf-8?B?SlN3WnVxSFR4T0MvcUNhaldxeWFlN2psWWVKVWVkaS9yTGZxdUI3NUdoWDVt?= =?utf-8?B?T28rS3pRamNudXNUWUJzajNMZklJZUZyOFhvVG5PRkdxZUhtZERsbXRtWDlE?= =?utf-8?B?bzVkUmZXZXJYU0E2ZWVwS01zbUM0R3ZyYlJXSXFwY002QStQdDlMU3BoM1kv?= =?utf-8?B?bGVzbnJlZTk1b2xGeXhqVGZFUzcxRzU0UTRJNjMzc0JyN2x0M3hKbDU3b2lW?= =?utf-8?B?ZUJSTWdYRlRzQ0VLT2FySE5TZnlpWTZyNGd1bU9OVytEL1lnRXlOVHJzdmlH?= =?utf-8?B?dThLalF0ZW9KVndzYU12dm9zRVpQWXpzNU9kRXpMOXJtY2NUYTdQVTAwRm1O?= =?utf-8?B?VFVkajdZbkhZN3BlLzI2TWd3ZGlpMkZ4dlU3dC95cGtCb1laUE5VZTFBU0x1?= =?utf-8?Q?WkqwmoZ9t/R5+IMLVQQvWKQMe?= Content-Type: text/plain; charset="utf-8" Content-ID: <06EE0AC8DDD7AD4BAC2D1EC9E864D7B4@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 2Z0dp6dMxhCwvWDgKFl32onbUU8uqPL38PK9udjyGvvR4qQG5q7pjj5fYcwvB8Kt4Aqe1sFTGZQTOx7wAtd4qHOEoGOcm2VgpJUUyP/KTgATlgLkXhYMRgDEQghJMDXYXy3A+D+S+2gnWXJAMtznTL+wFnv8NflkNrbNPM8LT4qbocHDMJJrWw+kL6sS3zyHKuVTt6xRLLiLDFiny81LWoh/AoF4cuKOfjzIGKLAtx98L8bG+7ZAX+i/CdpSubxRae/tV9CqnZiuv2uWtczwFIOnJXVbL4G0CDZx5y4yE5dHRNTxkH5y19jnl7fSSxroq/TBli3gRAd36e9czyvJCqS1K1oc0cc4wpIevXaVGqRxwZmQISO8yWdidtitde2DcvIOmwbM6DlFHUXWrD3Rvf5+UoESmXGBBTd+BowL7mgsCQEQGtYUzTpD8IVTpZduSewnXJkRJnx/rlGAem7f7aKltyfV1odljhVODLZz1ycjQr8G5ydpkmupt8AVDdcthamsivdPCcoz/IcEd0yg42bre1rlcpF8M/tJYLsLXBQ0Dqg9qDtnwGfhIiBoq0BEske06NV1eBVJe4PMnNb5+vck8lrGViqISxGrzUQs80dvDzjI69OigqQLH4gaPxc74fe4DNQ0v8sFGWIOyGt25816mFdi0A3Z87RGV940he3KJD++6n6qDA/paJ4+qcT8v57SETKaUPTVnaaL3OCw6qqKkMvQPrX0+JRNVv2YGvI5uAWSJ822qu+khJXEXj4faqS/4GlHp0A1XLnMr8nEVbZL/rcKf9KVMPN0w8xN9gLp+cOJc8C9zMNT4T5zks/K X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f721dea9-21b6-45ad-c6f1-08daee45417a X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jan 2023 11:17:24.4753 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nllPKvA/Pe1plXY7YzG00Exan2B+vRCPIX+RJSvGZ15Bmbuyt8XmZVPzjlutHxSrfmXwEWzHcf50SKdpgbuYabTJtE7OEjr70nA8ytb4JCM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB5106 T24gMDQvMDEvMjAyMyAxMToxMSBhbSwgQW5kcmV3IENvb3BlciB3cm90ZToNCj4gU2VlIHBhdGNo IDIgZm9yIGRldGFpbHMuDQoNCkFwb2xvZ2llcyAtIHRoaXMgc2VyaWVzIHNob3VsZCBiZSAidjIi Lg0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Wed Jan 04 11:59:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 11:59:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471137.730863 (Exim 4.92) (envelope-from ) id 1pD2QE-0003UQ-O6; Wed, 04 Jan 2023 11:59:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471137.730863; Wed, 04 Jan 2023 11:59:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD2QE-0003UJ-LL; Wed, 04 Jan 2023 11:59:06 +0000 Received: by outflank-mailman (input) for mailman id 471137; Wed, 04 Jan 2023 11:59:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD2Q3-0003UA-HG for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 11:59:05 +0000 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 285a2951-8c27-11ed-b8d0-410ff93cb8f0; Wed, 04 Jan 2023 12:58:53 +0100 (CET) Received: from zn.tnic (p5de8e9fe.dip0.t-ipconnect.de [93.232.233.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 18EC91EC008F; Wed, 4 Jan 2023 12:58:52 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 285a2951-8c27-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1672833532; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=UKl/CVF+4GJS0LDdyX728sU1J1aGkocy2OklfcAdRtI=; b=VcttLkPNy9K1xNdWfFV7Yz0KEUwXXic9v2XG1jbmKgXxKVSo4wcHOiMPPS/Y09Wr2p5SCF 2pmDtdw/423IjVUdnSQ/yOxlJdQFacJj5lXUfKDExPe/KfWSxHLfgoaUswfq1pSyDkPKwR +8kZx8fwKmnCVLzKEVBMtns1UtQy+9g= Date: Wed, 4 Jan 2023 12:58:48 +0100 From: Borislav Petkov To: Dave Hansen Cc: Ross Philipson , linux-kernel@vger.kernel.org, x86@kernel.org, dpsmith@apertussolutions.com, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, luto@amacapital.net, dave.hansen@linux.intel.com, kanth.ghatraju@oracle.com, trenchboot-devel@googlegroups.com, jailhouse-dev@googlegroups.com, jan.kiszka@siemens.com, xen-devel@lists.xenproject.org, jgross@suse.com, boris.ostrovsky@oracle.com, andrew.cooper3@citrix.com Subject: Re: [PATCH v2 1/2] x86: Check return values from early_memremap calls Message-ID: References: <20221110154521.613472-1-ross.philipson@oracle.com> <20221110154521.613472-2-ross.philipson@oracle.com> <8e62a029-f2fa-0627-1f71-4850a68ec6b6@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <8e62a029-f2fa-0627-1f71-4850a68ec6b6@intel.com> On Thu, Nov 10, 2022 at 08:07:53AM -0800, Dave Hansen wrote: > On 11/10/22 07:45, Ross Philipson wrote: > > dt = early_memremap(initial_dtb, map_len); > > + if (!dt) { > > + pr_warn("failed to memremap initial dtb\n"); > > + return; > > + } > > Are all of these new pr_warn/err()'s really adding much value? They all > look pretty generic. It makes me wonder if we should just spit out a > generic message in early_memremap() and save all the callers the trouble. Well, let's see. early_memremap() calls __early_ioremap() and that one already warns befofe each NULL return. So I guess we don't need the error messages as we will know where it starts failing. I guess we still need the error handling though. I.e., this above should be: dt = early_memremap(initial_dtb, map_len); + if (!dt) + return; so that we don't go off into the weeds with a NULL ptr. Or? -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette From xen-devel-bounces@lists.xenproject.org Wed Jan 04 12:12:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 12:12:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471151.730874 (Exim 4.92) (envelope-from ) id 1pD2dE-00061t-7h; Wed, 04 Jan 2023 12:12:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471151.730874; Wed, 04 Jan 2023 12:12:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD2dE-00061m-4T; Wed, 04 Jan 2023 12:12:32 +0000 Received: by outflank-mailman (input) for mailman id 471151; Wed, 04 Jan 2023 12:12:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD2dC-00061g-NJ for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 12:12:30 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0d36f55c-8c29-11ed-91b6-6bf2151ebd3b; Wed, 04 Jan 2023 13:12:28 +0100 (CET) Received: from mail-bn7nam10lp2107.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.107]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Jan 2023 07:12:24 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by MW4PR03MB6345.namprd03.prod.outlook.com (2603:10b6:303:11c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Wed, 4 Jan 2023 12:12:22 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5944.019; Wed, 4 Jan 2023 12:12:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0d36f55c-8c29-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1672834348; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=GzrVoLQbytdkR1Wp0KQFMh+Px/VkZ4Z8nHXx96puNtI=; b=bIUTrIImGpmRCbWlKrWEQwpIFXGQYtEh5z1Frk32aCofAd3GwuOcNQe6 6pAe4rvPcNOaNv1mFw3bTbJY4xR6SM40mT5+lh4CMigIbqomguel/dnkm P8t/IGYpWFoole6LqBBDrLCf6ylqMph/w8SRwjKUUhJpQtZYa8RtNayyL I=; X-IronPort-RemoteIP: 104.47.70.107 X-IronPort-MID: 91159701 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:Tg52davV94b2m0kvJLqOgIaqvufnVLZfMUV32f8akzHdYApBsoF/q tZmKWGDbP7bZTOmLtl/a4m1/EsA7cDQmIM3QQJv/ns8Hy0b+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg0HVU/IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj5lv0gnRkPaoQ5AaGyyFMZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwAR8uaA2AgbOK0p2kWMV9m+V/dOTTFdZK0p1g5Wmx4fcOZ7nmGv2Pz/kHmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0ouiP60aIW9lt+iHK25mm6xo G7c8nu/KRYdLNGFkhKO8262h/+JliT+MG4XPOzhr6M73wXKroAVIDQOeEKAq+OIs0eRedBQF XIS2jQnioFnoSRHSfG4BXVUukWsux8XW9NUVeog+gyJ4qPR70CSAW1sZi5MbpkqudE7QRQu1 0SVhJX5CDp3qrqXRHmBsLCOoluaMiEPIWgPTSQNVwcC7p/op4RbpgnUUt9pHaqxj9v0MTL92 TaHqG45nbp7pckP2qag/FGBgC+2oZPJTQkd6QDeX2bj5QR8DLNJfKSt4FnfqPxGc4CQSwDZu GBewpDBqucTEZuKiSqBBv0XG62k7OqENzuahkNzG54m9HKm/HvLkZ1s3QyS7XxBaq4sEQIFq meK0e+NzPe/5EeXUJI= IronPort-HdrOrdr: A9a23:0euD16xdKvjeTyHpdCXAKrPwP71zdoMgy1knxilNoH1uA6+lfq +V9sjzuSWYtN9zYhEdcLK7VpVoKEm0nfVICO8qUYtKNzOGhILHFu5fBU+I+UyEJ8U4ndQtt5 tdTw== X-IronPort-AV: E=Sophos;i="5.96,299,1665460800"; d="scan'208";a="91159701" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y2Qzs8reLCpDxPF+xgVraCyCy1SX4jXeQx5ZvCVI/07byZRhnOcXvClHp65Cbbk17y0i6jDGvV1WPmG5XtDMltVNzZlwYn+yMOY+VGMVyDxGwCJHf2lDX7m/9ksTC6ffwJCoEd0Ay6Aro615qJ7lXNK8tlUptQhZ44QknDJE36E2+dFS5jg+o3/W/h1W7lHgtnUi5hEFySqRevPE8c2VJkt41A46pS7n2YCJ5gMZTQEtbRU6TvAGMKa3AyGTxr5hjLJmW2ETkDVIW3ahBqjtzDW6v5wqrlrJfzlsKke4fZFWdNIKmTJjccMoe4Rne2LnlB6Bq/5NFgzRCZsN8wbVeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GzrVoLQbytdkR1Wp0KQFMh+Px/VkZ4Z8nHXx96puNtI=; b=WeHdu18g6l5POtV6ABN/vHDXVdc+ArSCcHbFB33Ojj8kBjrUeowz+M7XzsUHchkUJqvpV83J1jRNFbhSSlCfLTa0PAq4xv/a/uk2e6NuwhbyI3MVG9NXGeJeFFxgrb+LWtBtxNNQLitWGaujR9Hs/QjgAttP8IRMGadHiEt5sJH40GC920gksk6flc+3c0uM7G1n/EZEcmAjRvaMdRJYxUlzfRhE3zNGFxVEknK2LxO7/u1iV/cIM0ZSnWQ822zAp1ux0vtrSvnV/CVF6dbgiJ7RqlCJZnCT0EOCIWqstWAp8KN04wCMUcT8K1TN5tdJzGVQcC27Vy1ArURx7owm8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GzrVoLQbytdkR1Wp0KQFMh+Px/VkZ4Z8nHXx96puNtI=; b=xKJ1LRgz/WXhEeDPgZFHjicl3HIcQ+9wXYop0GuOhRiKh0GR9CyjukxJT7PHiBxcwnBeAPkjvZJZFFX9vNM2CBkftGEJLEmEDvxDT+8NQrmsIU05O0i4BO4qCritgi78mZvEd2LcSNJLQPeVbUM1v5oblCOxTZDYBy8dfG3mEdA= From: Andrew Cooper To: Michal Orzel , Xen-devel CC: Doug Goldstein , Stefano Stabellini , Anthony Perard , Oleksii Kurochko Subject: Re: [PATCH 2/6] CI: Remove guesswork about which artefacts to preserve Thread-Topic: [PATCH 2/6] CI: Remove guesswork about which artefacts to preserve Thread-Index: AQHZG+cbH36uve2aEUGxm9tAfYRLqK6LLXmAgAMGUIA= Date: Wed, 4 Jan 2023 12:12:21 +0000 Message-ID: References: <20221230003848.3241-1-andrew.cooper3@citrix.com> <20221230003848.3241-3-andrew.cooper3@citrix.com> <07b5cc36-e0ea-9b51-036a-9523920dd74a@amd.com> In-Reply-To: <07b5cc36-e0ea-9b51-036a-9523920dd74a@amd.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|MW4PR03MB6345:EE_ x-ms-office365-filtering-correlation-id: 44cb12d5-77e1-402f-a341-08daee4ceef0 x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: G6h9PgyduLJ0RbgdAwCaM0xLXwLic4yfPLvQlgyGYXyriccXGUmNTweE4NbOND1eySIY5ltrf2sdaP0k6mTJ7acZ0YwUilJTOl2WpTGVz1zDsEH7kNIX1CiW/P0PUzVDvYSictzD0OC/nWnOACR0vYkA9tefJ1508hM2EQQ+DYgr6TybWpYmrSmvqMkQjt2cVVb2h+QpIIL1OgJ056hdj8FaUeaZwSIm8mUJkSLEfvDZnDVkc1wyrEKkjchmixNpD6yYbC49E0MMHaB4S/uZY8vKUF4T/rlYVzzEvnFC9YJ5rTDX0F+RHSvQDL8EzmvZQNXIdi+WNQ7RDk2EEpvcu+zO5iQPTvuTR9OPR9Afq37aUMJY1wwUNPkNHnpTpwZlL4f/rNkJs8HuWP1XbsXldnQmAEpHyD/NE3dFuC/8whSbB8gz3QJPhp+5v01ENeYubP8uB5gIaLsc8itTlMnsqjrGaHeG230HwXWjVj7ltkUPdpfrIEWdmpQIa7lus5+w60rU4SW3Ybp60DNo4jpX5n0UomOf8gMo+PgHzZ3ILfxGKpQJbTqRahtPA7VUDOQgPPrrmNOb5jkFJFy5T5o6mRJ2B4VBLlFO8P9GgM8+C6P/mK+X9XVgp4a44HkhByd5eDFcq2/DdK1JYxNfAz5xxs0QLu2J6TSIUwOToAu7ejK0rghCcMKwO9ndKM5/TcHjDpcXTRZD3iP6W3gdignTGY9pJE+Gqm/xOAnLEan0HFoUGtAcAZDR20kwRqp/H1ZOibC512O1QtPfzQaBvFVFbA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(39860400002)(366004)(396003)(346002)(451199015)(38100700002)(83380400001)(122000001)(82960400001)(38070700005)(31696002)(86362001)(5660300002)(4744005)(66476007)(2906002)(4326008)(8676002)(76116006)(64756008)(66556008)(66446008)(66946007)(41300700001)(186003)(6512007)(91956017)(26005)(53546011)(6506007)(8936002)(2616005)(110136005)(54906003)(478600001)(316002)(71200400001)(6486002)(31686004)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?am5Zbm45L3FIMWlrcFYwVmxCZGpIOUxENnNaRjVrL29tTkpoOE9LMkNUR3pa?= =?utf-8?B?YytFR1BQTXRHR2ZsbitqeS9TS1MzbHVEN2hycGwxSnlja1IrSjNxSjlxMmdQ?= =?utf-8?B?UW5lU2tsNXVObTdrWFJCUnd5Z21KVjI0ZEJUOVl4Y3JSd2RUZkd4UTBnbDIr?= =?utf-8?B?VEd4WkpXM2VJWWpvMVRrWDAyK2dtVndSZHo4VGNndjB2RU5lVUJPQmNoSVhM?= =?utf-8?B?ZVBGUTF2dlhpcmlUck1GRFo4enBKOGtiMU5Gc2VUVVVTMkJxeFRkQmJud3pV?= =?utf-8?B?NDZiNlNXaCsxRlVPWTRGZlJTdkxDQ1VEMmkzRnlpMzJrazNINmRrRzNUSUdK?= =?utf-8?B?QjJ0VG0vS3Z5bGJmSkovNUMvTVNyMXlLM28xVnpac2lmdEhDQlJSOCtOZTBH?= =?utf-8?B?RklKMVdlcWV1dnZSNHdndzJEa25MSGdFZVBBRFVRYnVPSnRlWXp1c2NmeEFL?= =?utf-8?B?N3ZnV1hBemtKY2R1NzNGdkR6WGpudGlra1dsU2hibmtiM1liaXk5VVdHOXll?= =?utf-8?B?cXA2MDVWQ2t5V1R1YTVtYVR6MFYzQ1R5ZHVZTmpudTM2UGx4UEJYVVpINVJs?= =?utf-8?B?bFhwekZvRUJCTDMvWXg5MjFRYkFKZ3FVc1g3cnZCSDNVYjAxeGxpcjBIM1Jq?= =?utf-8?B?ekJQRndMNVowclNHVDNtaFlHTHYwMjBoWDd3VkNidlljNkkrUmZYZGhaVXJ1?= =?utf-8?B?c2xkcUxpdmFtTS94Y3N1YUFaU1UzeVZhdWF5ZTlkWDdaVzRrS0pGVWE2MjJi?= =?utf-8?B?UjBIMjV4MVhZWnVLdDRlRGpRNDFYM0tyOERCUEtwRHRIVitwNUYveTFKZ3E1?= =?utf-8?B?dDBCeTdnQ1pYbEFMZkxKWi9QODlHNGtHcjAwWEFRZEh4U2FCZDdiSlJYSUFG?= =?utf-8?B?UDM2Mkx5WFRPVnVVM1dhellxRDFuOEhJMitnN1I2TEMxYkFhWHRVZThSbFdk?= =?utf-8?B?U0p3YUVmcjFERVhoNHpSWXNyaGlCY1lmRWNCNFZSOVNDWGQ1elQrWFM2ODRm?= =?utf-8?B?MUVWREIzMmsxUlZZbWpvMEdPV0VIekJNNU5RNnF2em9RN3NZRXYvRkt2WUxk?= =?utf-8?B?bGxzMC9GeXBmSnB4ZzVzUDJxYUk1b1Nzc0FjSEtDenBFWlN1VEpnTm1QVXph?= =?utf-8?B?U2dvZ2s5ZWtCVDFNSFJFTFdvK1FwRWxSVVgybzFDYlNvVUhKbU9xSnNleWh1?= =?utf-8?B?NEpNRnBGZk5KTGt5Wk9vWmIrRG5DaXZUZVVjdmxBR0prbTFaM3ZMYlFPSGtG?= =?utf-8?B?U2E3b2crNm80b28yVFRNZHVIa0VUTXVIMXpVR095YVFieXNVazFESUZhSXpD?= =?utf-8?B?WnZwKzBJN0k1ak5WbjFmeFJKUmdqNENVK2R0d3pCU3dhWDVqZ1RrRWRoZnFL?= =?utf-8?B?d1E5YUhlM0FXRUxDclFsanJsVXlzbTI1akpLMldFZHl5UW5relA4ejg3Sitq?= =?utf-8?B?QUlIM2pVQzJnNG1rU0Z5c1kxVithUjdXV2FYQVVPL3Q2YWhQUlVVeHNQVEVu?= =?utf-8?B?U1pxcnB4Y2lZM1lXRzJFcHA3MnJ1Zi9kQ3lEbWliaFF4Z1JuWG9YMUNSelRD?= =?utf-8?B?Y3BTZ29ZZk5FZm5vb0VyTzdrWWhtMkhhQVdvNnRmelBxeG1iOHN2ZVlJQkxH?= =?utf-8?B?TEZ5SkRUZXlERzNMTE80bXpPWTFFeDJkUCs2cy9hUWhpWHRxak5kVyt2TVR3?= =?utf-8?B?ZlJLbm1YeWkwM3ByUmV3cXMxVlJBTlprNHFPRlRXWFRqK0xJbVRCM0tnc1ZI?= =?utf-8?B?UlBrTEdmeEgvTzlLdzY1U3hDdk5IQjNkVEg0Vm5sMUhFclhQK3RMMFNZUnFm?= =?utf-8?B?SlhuY0lLTUg2b0FEbXZDT2ljbXlac1hvQVU4ay9uWUFvZlVWQTdsN1ZsTTRk?= =?utf-8?B?OFI4TzRFS2Z4eDJTZGM1UzcrdzNKaFZYenRGOVdVdHRidndab25PcHl2WUVY?= =?utf-8?B?RTErTDVKdWVVakRodDhEZ2Z0NldBL1p0L2xDUmRuNDE3OEFXUU1rZ2t0RWVk?= =?utf-8?B?VXVab2dSTnNNSWs3TVNoR04yTmxIVTFrbEdKSUVJcWlwK1Z4TmR3Q0htb01s?= =?utf-8?B?THVDZitOMG1jUm9UdWgrRVpRL2ZWSlJQSlhTdlVPQ3gxNnBVTjZXbC9lbG00?= =?utf-8?Q?YLNVWnm4OrULaFFZIeBh7JNHT?= Content-Type: text/plain; charset="utf-8" Content-ID: <90E7DE2C213C5C4FBB44CCBC7E8B790A@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 2Nj88TlfsgWnyFUS5jU/aTCO3qzIf4a0/3RMsJWyS1A7VP0MEhZ0mot0SiP2r7pc9zPlxhEBU4yCIt+9En6b4rLgTqFNs6GktYRC3QA3zJO/u738TTicf+gLRZofMhejKxlx0aNoFn1TEJgq0JQ8XOZDY0cge+lh/8xprBR56MCDWQDxhTWe03KCE5TyyJRC8tvs8PMUddC68ACNLCWckIhBSFcVxwJUkeKhxP+HPDsKDNfRkbPkLHCIuxkn4liW2uJ8mXlyLKoq+eLxD5vDC2ZXTmMxxhxqnna2BQ6Htzrk3TjQvh188U1FJHHgvBlY5goPNNu+r9N98xltsw7wMjuqxlBn9wzE5ub2iEjq+8jpSetxOkyX+DurpHqiSUwWE9ZnKtiEbXFD2QdrcN9UI4loNSQvLi62U3Xx3KTHpK4pA19ns08BUWTY9Ger9yYLt4mNMEDHAH7zlmBasNYXJ6ZtLwWHBunfwoJhsiX34Rd+bV7XAYrfKUdJYWAN3rg8afIXp6OarEdd8jdG9qtsG6hFewuftKSVPI8C972zFliwbslEVO+EZxoItgZw2JzT6ZwtQUAGkbmf9KXbblnGlU/E94USfQj1CxsZozE5lM3u3WACKngsmY521n3R1U5fDFAeI5jmdTq4gMD7C/l/6PT7305sYBJ3epXuOr1mVEgX97kRlgGmg01nVA+sy8qi4B2Ko/dp3lBfo2yb/EChngevxM16MXPn4M3QTDsnHl7aVjWKSUjjNhXC2aBZ1mRw33WClinnztucThmmssxxhB5yKPWz9++o8xSTdq02ByCwlra7SpRjimtvfNv72lVbXmC7DfxsmOxepUSr1YnEBbnwtfeiQbmZFp08nkyboUllZzOVVIrHtHz580N39O8l X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 44cb12d5-77e1-402f-a341-08daee4ceef0 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jan 2023 12:12:21.9863 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qwGdT9Ywx68hoQfBQyl+mNntpPC/h3I/MstY4Etl9MtZoCsOgvoNB6DJgn02hSxFUl9XmK9dG4gViUqOGT3TuISp5dePOoS7Yd5D2+IpGoE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6345 T24gMDIvMDEvMjAyMyAyOjAwIHBtLCBNaWNoYWwgT3J6ZWwgd3JvdGU6DQo+IEhpIEFuZHJldywN Cj4NCj4gT24gMzAvMTIvMjAyMiAwMTozOCwgQW5kcmV3IENvb3BlciB3cm90ZToNCj4+IENhdXRp b246IFRoaXMgbWVzc2FnZSBvcmlnaW5hdGVkIGZyb20gYW4gRXh0ZXJuYWwgU291cmNlLiBVc2Ug cHJvcGVyIGNhdXRpb24gd2hlbiBvcGVuaW5nIGF0dGFjaG1lbnRzLCBjbGlja2luZyBsaW5rcywg b3IgcmVzcG9uZGluZy4NCj4+DQo+Pg0KPj4gUHJlc2VydmUgdGhlIGFydGVmYWN0cyBiYXNlZCBv biB0aGUgYG1ha2VgIHJ1bmUgd2UgYWN0dWFsbHkgcmFuLCByYXRoZXIgdGhhbg0KPj4gZ3Vlc3N3 b3JrIGFib3V0IHdoaWNoIHJ1bmUgd2Ugd291bGQgaGF2ZSBydW4gYmFzZWQgb24gb3RoZXIgc2V0 dGluZ3MuDQo+Pg0KPj4gTm90ZSB0aGF0IHRoZSBBUk0gcWVtdSBzbW9rZSB0ZXN0cyBkZXBlbmQg b24gZmluZGluZyBiaW5hcmllcy94ZW4gZXZlbiBmcm9tDQo+PiBmdWxsIGJ1aWxkcy4gIEFsc28g dGhhdCB0aGUgSmVzc2llLTMyIGNvbnRhaW5lcnMgYnVpbGQgdG9vbHMgYnV0IG5vdCBYZW4uDQo+ Pg0KPj4gVGhpcyBtZWFucyB0aGUgeDg2XzMyIGJ1aWxkcyBub3cgc3RvcmUgcmVsZXZhbnQgYXJ0 ZWZhY3RzLiAgTm8gY2hhbmdlIGluIG90aGVyDQo+PiBjb25maWd1cmF0aW9ucy4NCj4+DQo+PiBT aWduZWQtb2ZmLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPg0K PiBJJ2QgcHJlZmVyIHRvIGtlZXAgdXNpbmcgImFydGlmYWN0cyIgYW5kIG5vdCAiYXJ0ZWZhY3Rz IiBhcyB0aGUgZm9ybWVyIGlzIHdoYXQgR2l0TGFiIHVzZXMNCj4gYW5kIHdoYXQgd2UgdXNlIGlu IGJ1aWxkL3Rlc3QueWFtbC4NCg0KWGVuIGlzIHdyaXR0ZW4gaW4gQnJpdGlzaCBFbmdsaXNoLsKg IFdlJ3JlIGZvcmNlZCB0byBjb21wcm9taXNlIGZvcg0KZXh0ZXJuYWwgZGVwZW5kZW5jaWVzLCBi dXQgeGVuLmdpdCBpcyBtb3N0bHkgQnJpdGlzaCBub3QgQW1lcmljYW4uDQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Wed Jan 04 12:14:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 12:14:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471158.730885 (Exim 4.92) (envelope-from ) id 1pD2ei-0006bc-IA; Wed, 04 Jan 2023 12:14:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471158.730885; Wed, 04 Jan 2023 12:14:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD2ei-0006bV-FE; Wed, 04 Jan 2023 12:14:04 +0000 Received: by outflank-mailman (input) for mailman id 471158; Wed, 04 Jan 2023 12:14:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD2eg-0006bP-Vq for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 12:14:03 +0000 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [2a00:1450:4864:20::332]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 456b697c-8c29-11ed-b8d0-410ff93cb8f0; Wed, 04 Jan 2023 13:14:00 +0100 (CET) Received: by mail-wm1-x332.google.com with SMTP id m3so16502532wmq.0 for ; Wed, 04 Jan 2023 04:14:00 -0800 (PST) Received: from ?IPv6:::1? (p200300faaf0bb20064d0d42b6b29c193.dip0.t-ipconnect.de. [2003:fa:af0b:b200:64d0:d42b:6b29:c193]) by smtp.gmail.com with ESMTPSA id bg24-20020a05600c3c9800b003cfa3a12660sm2320766wmb.1.2023.01.04.04.13.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Jan 2023 04:13:59 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 456b697c-8c29-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=tp0OYuN+hFp93UNubvtXVhop92O4XSYXyFAqRN3asxg=; b=bUjggjXm/ZKd2AdcPuoyYtGHQkJlJsoQhispfOfu6iis4HsJgusAR6+OaYyUeOFW/C ZXSbcyXa9RNXynpta1alP+kbX7N8M/3V2pAioMbthnKQc0qd/JUjpPLtFoBAjuRnSKdr qsihK5gCrYrl1NtVf98bO7tXADzeAw42JsNFo0K4SyG0NuS/ho3OSZs4h1bQNPsC2X3J ZH4dOO8tzOHxo0/3eVhOlr4y8Rvo87UoJIwsxwv55ykT53pD1pGl5CYdvgcKDBfSXO1D ZcJkLbeBpOHsl3EE/hYpAJWXISJ3cVGD+lZG7pr8Kt5bMq7ftvzQS9Bg6EM3uZYdz9yu 794w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tp0OYuN+hFp93UNubvtXVhop92O4XSYXyFAqRN3asxg=; b=MtAIqzXTErTd5n9FyiIyYuHXccSeLtR2untEcrp+42vp7Yp2ZeSt5TtDpkAJPK04AN B6MDYjOXfFvst1Cl+QKZwxoNlZ8fy4BQnbShN386vrjqlnEh6TGrQEBJDrL1S/oWuHMr XJ6DsE5eGCzEV57ZXQrZJDA4pE6odaddTp3HOELynYsg4Heu0H2KgOtlQPLR7eFR8XXB 5qlauCZi/jBvk5j3vkaTle8Rzy/0eCon6xOczqSRX8bPHVW07MU9mV7vkjOSm7liQkwz tyRq4mk9hHaUasb3MymiMphGykZB0ZEuO/v9eGgkMhhvk735JSC7iHhxHSrsTe8A/kIe P4iQ== X-Gm-Message-State: AFqh2kob01VUyuvxeozFGL/d918jF3W7Px2Xvht+T7PQFqu37y6ESQQV dY7JLC/QhC2SnrosGHUKrjo= X-Google-Smtp-Source: AMrXdXsxsodApwN0IFQ7MnSFd/e8HkT0U6Gmn6hEN4OSkztIw+emGuCdlBq9EcIRLyPspNRRIEuLBA== X-Received: by 2002:a05:600c:5c8:b0:3d1:4145:b3b with SMTP id p8-20020a05600c05c800b003d141450b3bmr34663011wmd.9.1672834440070; Wed, 04 Jan 2023 04:14:00 -0800 (PST) Date: Wed, 04 Jan 2023 12:13:54 +0000 From: Bernhard Beschow To: Chuck Zmudzinski , =?ISO-8859-1?Q?Philippe_Mathieu-Daud=E9?= CC: qemu-devel@nongnu.org, Paul Durrant , Marcel Apfelbaum , "Michael S. Tsirkin" , Stefano Stabellini , Anthony Perard , Aurelien Jarno , Eduardo Habkost , xen-devel@lists.xenproject.org, =?ISO-8859-1?Q?Herv=E9_Poussineau?= , Paolo Bonzini , Richard Henderson Subject: Re: [PATCH 0/6] Resolve TYPE_PIIX3_XEN_DEVICE In-Reply-To: References: <20230102213504.14646-1-shentey@gmail.com> <0de699a7-98b8-e320-da4d-678d0f594213@linaro.org> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Am 4=2E Januar 2023 08:18:59 UTC schrieb Chuck Zmudzinski : >On 1/3/2023 8:38 AM, Bernhard Beschow wrote: >> >> >> On Tue, Jan 3, 2023 at 2:17 PM Philippe Mathieu-Daud=C3=A9 wrote: >> >> Hi Chuck, >> >> On 3/1/23 04:15, Chuck Zmudzinski wrote: >> > On 1/2/23 4:34=E2=80=AFPM, Bernhard Beschow wrote: >> >> This series first renders TYPE_PIIX3_XEN_DEVICE redundant and fi= nally removes >> >> it=2E The motivation is to 1/ decouple PIIX from Xen and 2/ to m= ake Xen in the PC >> >> machine agnostic to the precise southbridge being used=2E 2/ wil= l become >> >> particularily interesting once PIIX4 becomes usable in the PC ma= chine, avoiding >> >> the "Frankenstein" use of PIIX4_ACPI in PIIX3=2E >> >> >> >> Testing done: >> >> None, because I don't know how to conduct this properly :( >> >> >> >> Based-on: <20221221170003=2E2929-1-shentey@gmail=2Ecom> >> >>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "[PATCH v4 00/30] Conso= lidate PIIX south bridges" >> >> This series is based on a previous series: >> https://lore=2Ekernel=2Eorg/qemu-devel/20221221170003=2E2929-1-shen= tey@gmail=2Ecom/ >> (which itself also is)=2E >> >> >> Bernhard Beschow (6): >> >>=C2=A0 =C2=A0 include/hw/xen/xen: Make xen_piix3_set_irq() generi= c and rename it >> >>=C2=A0 =C2=A0 hw/isa/piix: Reuse piix3_realize() in piix3_xen_rea= lize() >> >>=C2=A0 =C2=A0 hw/isa/piix: Wire up Xen PCI IRQ handling outside o= f PIIX3 >> >>=C2=A0 =C2=A0 hw/isa/piix: Avoid Xen-specific variant of piix_wri= te_config() >> >>=C2=A0 =C2=A0 hw/isa/piix: Resolve redundant k->config_write assi= gnments >> >>=C2=A0 =C2=A0 hw/isa/piix: Resolve redundant TYPE_PIIX3_XEN_DEVIC= E >> >> >> >>=C2=A0 =C2=A0hw/i386/pc_piix=2Ec=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0| 34 ++++++++++++++++-- >> >>=C2=A0 =C2=A0hw/i386/xen/xen-hvm=2Ec=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0|=C2=A0 9 +++-- >> >>=C2=A0 =C2=A0hw/isa/piix=2Ec=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0| 66 +---------------------------------- >> > >> > This file does not exist on the Qemu master branch=2E >> > But hw/isa/piix3=2Ec and hw/isa/piix4=2Ec do exist=2E >> > >> > I tried renaming it from piix=2Ec to piix3=2Ec in the patch, but >> > the patch set still does not apply cleanly on my tree=2E >> > >> > Is this patch set re-based against something other than >> > the current master Qemu branch? >> > >> > I have a system that is suitable for testing this patch set, but >> > I need guidance on how to apply it to the Qemu source tree=2E >> >> You can ask Bernhard to publish a branch with the full work, >> >> >> Hi Chuck, >> >> =2E=2E=2E or just visit https://patchew=2Eorg/QEMU/20230102213504=2E146= 46-1-shentey@gmail=2Ecom/ =2E There you'll find a git tag with a complete h= istory and all instructions! >> >> Thanks for giving my series a test ride! >> >> Best regards, >> Bernhard >> >> or apply each series locally=2E I use the b4 tool for that: >> https://b4=2Edocs=2Ekernel=2Eorg/en/latest/installing=2Ehtml >> >> i=2Ee=2E: >> >> $ git checkout -b shentey_work >> $ b4 am 20221120150550=2E63059-1-shentey@gmail=2Ecom >> $ git am >> =2E/v2_20221120_shentey_decouple_intx_to_lnkx_routing_from_south_br= idges=2Embx >> $ b4 am 20221221170003=2E2929-1-shentey@gmail=2Ecom >> $ git am >> =2E/v4_20221221_shentey_this_series_consolidates_the_implementation= s_of_the_piix3_and_piix4_south=2Embx >> $ b4 am 20230102213504=2E14646-1-shentey@gmail=2Ecom >> $ git am =2E/20230102_shentey_resolve_type_piix3_xen_device=2Embx >> >> Now the branch 'shentey_work' contains all the patches and you can = test=2E >> >> Regards, >> >> Phil=2E >> > >Hi Phil and Bernard, > >I tried applying these 3 patch series on top of the current qemu >master branch=2E > >Unfortunately, I saw a regression, so I can't give a tested-by tag yet=2E Hi Chuck, Thanks for your valuable test report! I think the culprit may be commit ht= tps://lists=2Enongnu=2Eorg/archive/html/qemu-devel/2023-01/msg00102=2Ehtml = where now 128 PIRQs are considered rather than four=2E I'll revisit my seri= es and will prepare a v2 in the next days=2E I think there is no need for f= urther testing v1=2E Thanks, Bernhard > >Here are the details of the testing I did so far: > >Xen only needs one target, the i386-softmmu target which creates >the qemu-system-i386 binary that Xen uses for its device model=2E >That target compiled and linked with no problems with these 3 >patch series applied on top of qemu master=2E I didn't try building >any other targets=2E > >My tests used the xenfv machine type with the xen platform >pci device, which is ordinarily called a xen hvm guest with xen >paravirtualized network and block device drivers=2E It is based on the >i440fx machine type and so emulates piix3=2E I tested the xen >hvm guests with two different configurations as described below=2E > >I tested both Linux and Windows guests, with mixed results=2E With the >current Qemu master (commit 222059a0fccf4 without the 3 patch >series applied), all tested guest configurations work normally for both >Linux and Windows guests=2E > >With these 3 patch series applied on top of the qemu master branch, >which tries to consolidate piix3 and piix4 and resolve the xen piix3 >device that my guests use, I unfortunately got a regression=2E > >The regression occurred with a configuration that uses the qemu >bochs stdvga graphics device with a vnc display, and the qemu >usb-tablet device to emulate the mouse and keyboard=2E After applying >the 3 patch series, the emulated mouse is not working at all for Linux >guests=2E It works for Windows guests, but the mouse pointer in the >guest does not follow the mouse pointer in the vnc window as closely >as it does without the 3 patch series=2E So this is the bad news of a >regression introduced somewhere in these 3 patch series=2E > >The good news is that by using guests in a configuration that does >not use the qemu usb-tablet device or the bochs stdvga device but >instead uses a real passed through usb3 controller with a real usb >mouse and a real usb keyboard connected, and also the real sound >card and vga device passed through and a 1920x1080 HDMI monitor, >there is no regression introduced by the 3 patch series and both Linux >and Windows guests in that configuration work perfectly=2E > >My next test will be to test Bernhard's published git tag without >trying to merge the 3 patch series into master and see if that also >has the regression=2E I also will double check that I didn't make >any mistakes in merging the 3 patch series by creating the shentey_work >branch with b4 and git as Phil described and compare that to my >working tree=2E > >I also will try testing only the first series, then the first series and = the >second series, to try to determine in which of the 3 series the regressio= n >is introduced=2E > >Best regards, > >Chuck From xen-devel-bounces@lists.xenproject.org Wed Jan 04 12:19:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 12:19:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471165.730896 (Exim 4.92) (envelope-from ) id 1pD2jd-0007Gr-4i; Wed, 04 Jan 2023 12:19:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471165.730896; Wed, 04 Jan 2023 12:19:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD2jd-0007Gk-1q; Wed, 04 Jan 2023 12:19:09 +0000 Received: by outflank-mailman (input) for mailman id 471165; Wed, 04 Jan 2023 12:19:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD2jc-0007Ge-AQ for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 12:19:08 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2071.outbound.protection.outlook.com [40.107.92.71]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fb0ff6d8-8c29-11ed-91b6-6bf2151ebd3b; Wed, 04 Jan 2023 13:19:06 +0100 (CET) Received: from DM5PR07CA0088.namprd07.prod.outlook.com (2603:10b6:4:ae::17) by BY5PR12MB4065.namprd12.prod.outlook.com (2603:10b6:a03:202::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Wed, 4 Jan 2023 12:19:02 +0000 Received: from DM6NAM11FT038.eop-nam11.prod.protection.outlook.com (2603:10b6:4:ae:cafe::43) by DM5PR07CA0088.outlook.office365.com (2603:10b6:4:ae::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.14 via Frontend Transport; Wed, 4 Jan 2023 12:19:02 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by DM6NAM11FT038.mail.protection.outlook.com (10.13.173.137) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5966.17 via Frontend Transport; Wed, 4 Jan 2023 12:19:02 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 4 Jan 2023 06:19:01 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 4 Jan 2023 04:19:00 -0800 Received: from [10.71.193.33] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Wed, 4 Jan 2023 06:18:59 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fb0ff6d8-8c29-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZEmue9qvMhHZsyPXoDTayU+NimjKOXrhG+ZpRKQvxKm4rqeHPAu6N5ZKoHBTWYpthOM4nLncmGH+XqofpqRiwEJdSaoAm7OnMHcS2nZXyXNZvsmX+SswPQPpF4vlcxI3cpddJHqHEKSsqvBTEOiaaseQKi4nHrOk2N1sdfQYwl5SDKQO6Yu9N2Nft1fpagNdZwKMo6HPWzXN1IbSf5ReOAp9IKK3bnxF4hevGsu6arPO8PT0tiS8x4QSginkM1bwFCVs4zP0iaMalp5fW9gPlosQgmU2yjVdxpka/ZENVXj+M5HLuMFgoybdaYtDBUUcadMiBwVgMMrxoaH/LoWqfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=owsf/i7YRUA/xls2EfGwWANAD2PSYeWoOIm1GTKWhJs=; b=m3sicxencausxZSruM0KMq5xqkefUdOWIplYs50FDHeSSS4P4QxYfx9XlMVCsToBhumuGVGFrD1hBA0Qyd+y23s8ipMBCQCeiddKso9OKbjWzq9tMYPpmBMCBbfrchL0+7n9V1UEmeBv1v5v8PC3TViUfDhr76LmLgSYUI3DpSZ5rzMLMvuKmMIF9qL8WwSXYLaprPqacaudpaAnpPbrZqLAOLUpfkqGnKSV5jV90f7+GRaMlREdv/SOMxHBZmeHG4Ui7PqgNI+m+9LhfumzKC+xOmcXl9bGDcH3kvQ2FXN6fudhVJLGMrlrlB7xyn+5TBCrV2kOkvBUlPJPgyYBRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=citrix.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=owsf/i7YRUA/xls2EfGwWANAD2PSYeWoOIm1GTKWhJs=; b=XtTj6DBAJ5zPxwKrcytbFkik7GXCDHgOukujzK9pLoS0P8iE5lVP3vcg/rdSd0KxkNcypqUNH7BGxNhrSJuYN/BvDNdBBtZ3aLjFboCG0TQ/cAFdmEGVDo6dNryzeG96F5rNgwteAWxpt4Eio9QnXiaBPqMYv0Spts8DTgIFThg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: Date: Wed, 4 Jan 2023 13:18:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 2/6] CI: Remove guesswork about which artefacts to preserve Content-Language: en-US To: Andrew Cooper , Xen-devel CC: Doug Goldstein , Stefano Stabellini , Anthony Perard , "Oleksii Kurochko" References: <20221230003848.3241-1-andrew.cooper3@citrix.com> <20221230003848.3241-3-andrew.cooper3@citrix.com> <07b5cc36-e0ea-9b51-036a-9523920dd74a@amd.com> From: Michal Orzel In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT038:EE_|BY5PR12MB4065:EE_ X-MS-Office365-Filtering-Correlation-Id: 190b7f70-2a3c-4127-f0d9-08daee4ddd8c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tDmtTo64YLeyM4hvsK9hyH/48CI36WZQNZ2xcPF36btRe7dc/mA2YiSAXMubh13ZRmCQlSEDdnMJfBiKs4UFITZzGcsQvNd6x6s8xzAmnleINxWMspj7sv4IMZAxdQHx5kGdWcQ1lCwsfigmr38FK91cXS53+yPe3dMt7RXcC/2GOR8JGg9wyACRNf23ukNoAesoB+z3NqzPPtlvKdooweyn8Rz5KHiyEQU/ki1HTLMDbp2zWuEOQ11FHoNFh3RfPTEQ/FQdaa2sxhK1seA5OBdCbJmlkLLshXThcjCrKFmCnLFtFkGifbxXkNvFwjENEWn/1p99JZiHJ/lR7M3LR+JEo7BWx/zKgHYSa1oXCi3cOHVPOfijKUDR+K3uqIYn+TS/upQTQ7RRXz9yWS1finqFAYYhX2V3ft98C5TjN0XR7/EM4SCfwxzUxeJwUlzdIJjEy+XlFhlx/9NavhkfJEFVQSwkzTYu+y7LqnJIn1WMaKU66oQg/dUYU5uYVNv/oIpzYbQu9N1KlAsaYBkwksF9ESYRhEkNgAKmEc+zUxACWxRW7KZtlUrKJ+7MqCKT0+yQfbFO5LTeElRZR0CQ3HgIHvXovEbsXl+trbaToW4JFF5pT9FVYnUMvCqLNW85AdGzhaRl7VVqX5IR0w4bkVMvyI3IRGjTMyaACKloU++lpfY+1QgzXlwdjgOZ+8cgUv1og1fznXKO6siwJ+MvCz+aFAOig5ssULeirghrzTFT+ttFB4rw5gd7XbOTev+C+rsUon52pyPXuQTLUGmiog== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(376002)(39860400002)(396003)(451199015)(40470700004)(46966006)(36840700001)(2906002)(5660300002)(31686004)(8936002)(44832011)(4326008)(8676002)(41300700001)(54906003)(70206006)(70586007)(16576012)(110136005)(316002)(478600001)(53546011)(186003)(82310400005)(26005)(336012)(40480700001)(83380400001)(426003)(47076005)(2616005)(81166007)(82740400003)(356005)(31696002)(86362001)(40460700003)(36756003)(36860700001)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2023 12:19:02.2459 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 190b7f70-2a3c-4127-f0d9-08daee4ddd8c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT038.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4065 On 04/01/2023 13:12, Andrew Cooper wrote: > > > On 02/01/2023 2:00 pm, Michal Orzel wrote: >> Hi Andrew, >> >> On 30/12/2022 01:38, Andrew Cooper wrote: >>> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. >>> >>> >>> Preserve the artefacts based on the `make` rune we actually ran, rather than >>> guesswork about which rune we would have run based on other settings. >>> >>> Note that the ARM qemu smoke tests depend on finding binaries/xen even from >>> full builds. Also that the Jessie-32 containers build tools but not Xen. >>> >>> This means the x86_32 builds now store relevant artefacts. No change in other >>> configurations. >>> >>> Signed-off-by: Andrew Cooper >> I'd prefer to keep using "artifacts" and not "artefacts" as the former is what GitLab uses >> and what we use in build/test.yaml. > > Xen is written in British English. We're forced to compromise for > external dependencies, but xen.git is mostly British not American. True, but from the consistency perspective and easy grepping, it is beneficial to stick to what a subsystem uses by default. > > ~Andrew ~Michal From xen-devel-bounces@lists.xenproject.org Wed Jan 04 12:38:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 12:38:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471173.730907 (Exim 4.92) (envelope-from ) id 1pD32a-0001K1-TS; Wed, 04 Jan 2023 12:38:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471173.730907; Wed, 04 Jan 2023 12:38:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD32a-0001Ju-QA; Wed, 04 Jan 2023 12:38:44 +0000 Received: by outflank-mailman (input) for mailman id 471173; Wed, 04 Jan 2023 12:38:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD32Z-0001Jk-TG; Wed, 04 Jan 2023 12:38:43 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD32Z-0005N3-RN; Wed, 04 Jan 2023 12:38:43 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD32Z-0004Wt-H5; Wed, 04 Jan 2023 12:38:43 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pD32Z-0007zx-GZ; Wed, 04 Jan 2023 12:38:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Vp3xFGxDQtgtNhcfWty+Eg0d9+1Hfd1RyUmHsQqWqkE=; b=AuWm9LuPBA0/yGzwfBFfzNX3BM IMNYlKSeFP69dml0uTrWY9dyJweYsCoLZPP+FbSZ/Vj6Gi+lmY++TASV6CHgLmMEO+3PYEjNAuF+u p/IQcuKrRmvSkBZ4pNBGPx+EW2WmzOANn6osbfiRzROjYY9Ef2spJACZ4ngS8FXVXJC4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 175567: all pass - PUSHED X-Osstest-Versions-This: ovmf=9ce09870e721efacc41fa7ee684e9e299f120350 X-Osstest-Versions-That: ovmf=992d5451d19b93635d52db293bab680e32142776 From: osstest service owner Date: Wed, 04 Jan 2023 12:38:43 +0000 flight 175567 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/175567/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 9ce09870e721efacc41fa7ee684e9e299f120350 baseline version: ovmf 992d5451d19b93635d52db293bab680e32142776 Last test of basis 175565 2023-01-04 06:42:15 Z 0 days Testing same since 175567 2023-01-04 10:13:33 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Dun Tan Laszlo Ersek jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 992d5451d1..9ce09870e7 9ce09870e721efacc41fa7ee684e9e299f120350 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Jan 04 13:11:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 13:11:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471182.730918 (Exim 4.92) (envelope-from ) id 1pD3YI-0005XS-FP; Wed, 04 Jan 2023 13:11:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471182.730918; Wed, 04 Jan 2023 13:11:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD3YI-0005XL-CP; Wed, 04 Jan 2023 13:11:30 +0000 Received: by outflank-mailman (input) for mailman id 471182; Wed, 04 Jan 2023 13:11:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD3YG-0005XF-BX for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 13:11:29 +0000 Received: from sonic316-54.consmr.mail.gq1.yahoo.com (sonic316-54.consmr.mail.gq1.yahoo.com [98.137.69.30]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 499b7c2f-8c31-11ed-91b6-6bf2151ebd3b; Wed, 04 Jan 2023 14:11:25 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic316.consmr.mail.gq1.yahoo.com with HTTP; Wed, 4 Jan 2023 13:11:22 +0000 Received: by hermes--production-ne1-7b69748c4d-dzr9v (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 5f71576bf612bcab338a616d92656601; Wed, 04 Jan 2023 13:11:19 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 499b7c2f-8c31-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1672837882; bh=9KFOB9JL9CLZbbSE/mPnz5kluCg2oPK3oquc5XsZ7fw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=Z4wUGpXg9lLdhSQCcDPDA6OZ6NhRx03NFdWfYG03mAK0xqRfXLOB/hOM2hjF0xe8yd0LQH9mYzWFlxdnLpMHS4PjBYlq0kaFUUbuBVMgrmUn8Nyt08HVsX96Szk+VLgiI71X2Qq9bUCHimXdXWK+C07g1apX8DCE2pVcrzEFb8yAyPhE41HiXctuV7ec4ENvvbe0rBnRb48rv8ZzK8BCxQm7C+xdvDXk8idqsHJQnKeTz2Dy/a6enTZCuLo5Pt/zASfVtfU7tKqQg5erj2sxiQfKBL7SEXpANc9IwPejBZ9t63cgvAmvaD5fkuJMeS4IzB70yVeK+5ZlJopYCQ184w== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1672837882; bh=NiaQdQUKSXqj+/3FoQox87OgVYUchmxnGWiebKNaBbT=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=ij+iOgayTlmgInCanbFFrLJKs8XttBMJo7nZNtVgxapvaicNQ+WmRicwxdnaTJfcZdbKfRIy1ORkkoVDR17X1iurZwKzIZgBcupGw6DgNfNNyhdMlAUgLd3eUWqPdeljEvqZ6r8qmGA/Y6pmTGsW2fP7+XdXKqcAQM83hkLMNGPaPxMYk3R0u6KkaI4IWDTsBGb7+SWsz7aAvgSajI1HpwkLFjWk3Am/ZDp34YdohzMrHG22j2bEVeAnGlKGn6FBVepLjUgyaD9waIrMlYmlnLhKzmby03fWz7v/xchBFgc7e8OvlbXeaHPXATvhNr/lsPYnSRp+o6Sj+WcqF7NvHQ== X-YMail-OSG: n1H3IGsVM1loDdT7ZhBKWbz4cuAZ.SQTUKrfCLV3b66hcka0Wr5vXQs0K7G2O4a Pv3SQUoN110Ab4muX1TA0xNP0vjRa.a5ncz89pv5MU5JZwATM6urstOsUHcchhqRYh0P8M4oPZeQ XUodIbreLkjgp3nATolbTgX_9IQX6ZKeDnv5f9zUCXEQyoqYUoC4uwLYz9JgoTTWAwMOeiqsrU2P O8FHKEvXm6ezl7mJjUHZ5DNaABq1tsla1IxTYH3_4FX2er5vRhpYpjq6kopMyvTJGt5g.b_2EKfx Z56Qe1D40a_IPjqKfRLPwddcidkHlFHU0OF4EfpG7h1PvNYJECSEwawqCwkQ_Bwzf6fJNTeLfv2x FgvVJA6_y9yXhS6AuK6KS_AwelVo2YSr2MItKQGHl39gj8lSYg7v8gC2yPxIPHtucvnOZ5mO9ewX ztXJLxo2WUkFg3xTA7F4Pa2fAZ8rFeVW63ACln1X_x98Jy4NZLcmsTDX8KrS85D.Adr3964bcolZ 0uH9mT6LHItN_Qb3vKlhRds5bYwgbfMvrx78QCKHT5IbnIV57ncmN1h4YKqpL.LkjCBUVJxdeLJq Vqx9bZv0BQl74Y_M9KKH0B7EQdhX54LcC.ESRtZHuC0nK44sSqK.BLWPnPYVo.lM5hZIgwZjd234 NExT6Mt1kQ4C.WEWvkhV2c8fOVg9qMItdZuzfoaT0tCPh8ZVZur6ESsKYruP3dqEEPy8iRTETLiC 5CoQ9oweZhpPoclg4OejckehtSeK6r5iVYy70XVcNgHLsNgmdBwhtSG8ldRdCdGLpiheUPf3IhXP EpJOoTkNTwfGaH2Gpng.hQ1JITaCyv906CZlGLttyCddtgku4UD9UbD97VNEp4Eaols6O84xgyB7 GMSGFqjr3xzFGw.ADJn1NnHXB4_8a.rMv.6C.YkjaAbN4u34qr7ZStcrO0QdKV9Aya0w4GMRuVJ4 BPHFB5nITpreOTrezrOzxNKIAvlk_smur7OtMPr263JDsl.EayZBcedMsQTF5ulux6maH8EZeGBo xcqX_qhaEsVZeVHtrk5W1SPzIOzyWqOU9PdtTxxXUbsyTyTIqPQZLfkvUq5lROtP3dcO87I5Vlvz IowI3ZEgl5e90cwl1mpsXSfLzYsd7M6S0yR3rl6OTLNkx8f0opeOy84_aZnx1k.qtPE9vikA8v3E Y2l6Fx927_OcOC1GVG.XhG3jJLq2hjBbxVAO.zLwhOZHEKbmIZl6E.QISDMxyjxFL6535NPJ9yzU UE80GzbJ3pbjnHRK0OMlxDyFdi9yX.5zpKrz1RZyvwzWFlBNY5dXIP91RR1jxgGGFx9JRPF3G5.B atmfH3u7DY2DxlyqeAjUCHuZUfo34g3Ts64wCBOdAnVuNRzjTiSFgkKkoatEmZEc1_2NTKd3Fp20 6v70bJPDB_GwzrsycSug6wQrtVCnDmjNmoEiKaQcXk88KQBVO1UkerMbNun2iHwi5C_RTBzjtj8b FLZaHCX6Dgua19BJvvFWXlgI2w.LWZU4Ru533E703a8z3okxeCkh_KTVnsmBAeN0CZYIpOxDEACw CKkJ0LAfJWA.yJCdMDkXklm82Wm_luHu7MPGZ04Fvmgd4tRx3mvHsAOV5FQfwPjiFCIcXajc0Xbf xF9r20rVlbZaIo6lDNzRb8cyjntoucLuVMrtg7Ncy1J1QzYW0nEoXlIoQ2U2vWZ3mVx2PxxGqgwY Ogdm0A100uX1R4hwVSxj2jmC.gDBp6ekwxAzCCf5hbCqKwYOpc1zCLf0Ksd6QuvQrnuu8R4DMvxY 55.fuzprOyNLCaxO5vj4WHmQr6HMA3fqGvZgOILONvBSBVN3P1B2dx1ZkRwJXrWIldV4h29WV3HG NbSVjhaueaHiAN3OB2_.JIqa_0J7tGFnbQVWOPfXJtOcSmuaHuQHTzda3He1oCmttJ5abz6u8qxQ NGWCc1jOhS6PU6Js55BS7VtJKR0KpNjBLBUYeBNUOX18OPiV_jfg1aln8DNIAzVanXikm.P5ORLC wyO0gpzGYTgFjwLFhg2UodfOHX9WDGLEIy6Sy53euhHfP4bRqTKiXfWIuEtKobIhf67npHixRiQ_ 5xBoIW4GJ6fQLCMPqnminlF0ALGUSqSwiMubqRfJV9wCIMhRGoRBxxHY2tKpcxCGeHrKGTFq5FBw uoQERC7qiyAiKFFarQc6tbRDes5jQv_2lxPn58JdHVgp1N8ObbmRfdwLHceQllHgYw8prmUHOFgb gfMHBTfGjIPcouIdEkUbefA-- X-Sonic-MF: Message-ID: <00094755-ca61-372d-0bcf-540fe2798f5c@aol.com> Date: Wed, 4 Jan 2023 08:11:16 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 0/6] Resolve TYPE_PIIX3_XEN_DEVICE To: Bernhard Beschow , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Cc: qemu-devel@nongnu.org, Paul Durrant , Marcel Apfelbaum , "Michael S. Tsirkin" , Stefano Stabellini , Anthony Perard , Aurelien Jarno , Eduardo Habkost , xen-devel@lists.xenproject.org, =?UTF-8?Q?Herv=c3=a9_Poussineau?= , Paolo Bonzini , Richard Henderson References: <20230102213504.14646-1-shentey@gmail.com> <0de699a7-98b8-e320-da4d-678d0f594213@linaro.org> Content-Language: en-US From: Chuck Zmudzinski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.20982 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 7404 On 1/4/2023 7:13 AM, Bernhard Beschow wrote: > Am 4. Januar 2023 08:18:59 UTC schrieb Chuck Zmudzinski : > >On 1/3/2023 8:38 AM, Bernhard Beschow wrote: > >> > >> > >> On Tue, Jan 3, 2023 at 2:17 PM Philippe Mathieu-Daudé wrote: > >> > >> Hi Chuck, > >> > >> On 3/1/23 04:15, Chuck Zmudzinski wrote: > >> > On 1/2/23 4:34 PM, Bernhard Beschow wrote: > >> >> This series first renders TYPE_PIIX3_XEN_DEVICE redundant and finally removes > >> >> it. The motivation is to 1/ decouple PIIX from Xen and 2/ to make Xen in the PC > >> >> machine agnostic to the precise southbridge being used. 2/ will become > >> >> particularily interesting once PIIX4 becomes usable in the PC machine, avoiding > >> >> the "Frankenstein" use of PIIX4_ACPI in PIIX3. > >> >> > >> >> Testing done: > >> >> None, because I don't know how to conduct this properly :( > >> >> > >> >> Based-on: <20221221170003.2929-1-shentey@gmail.com> > >> >>            "[PATCH v4 00/30] Consolidate PIIX south bridges" > >> > >> This series is based on a previous series: > >> https://lore.kernel.org/qemu-devel/20221221170003.2929-1-shentey@gmail.com/ > >> (which itself also is). > >> > >> >> Bernhard Beschow (6): > >> >>    include/hw/xen/xen: Make xen_piix3_set_irq() generic and rename it > >> >>    hw/isa/piix: Reuse piix3_realize() in piix3_xen_realize() > >> >>    hw/isa/piix: Wire up Xen PCI IRQ handling outside of PIIX3 > >> >>    hw/isa/piix: Avoid Xen-specific variant of piix_write_config() > >> >>    hw/isa/piix: Resolve redundant k->config_write assignments > >> >>    hw/isa/piix: Resolve redundant TYPE_PIIX3_XEN_DEVICE > >> >> > >> >>   hw/i386/pc_piix.c             | 34 ++++++++++++++++-- > >> >>   hw/i386/xen/xen-hvm.c         |  9 +++-- > >> >>   hw/isa/piix.c                 | 66 +---------------------------------- > >> > > >> > This file does not exist on the Qemu master branch. > >> > But hw/isa/piix3.c and hw/isa/piix4.c do exist. > >> > > >> > I tried renaming it from piix.c to piix3.c in the patch, but > >> > the patch set still does not apply cleanly on my tree. > >> > > >> > Is this patch set re-based against something other than > >> > the current master Qemu branch? > >> > > >> > I have a system that is suitable for testing this patch set, but > >> > I need guidance on how to apply it to the Qemu source tree. > >> > >> You can ask Bernhard to publish a branch with the full work, > >> > >> > >> Hi Chuck, > >> > >> ... or just visit https://patchew.org/QEMU/20230102213504.14646-1-shentey@gmail.com/ . There you'll find a git tag with a complete history and all instructions! > >> > >> Thanks for giving my series a test ride! > >> > >> Best regards, > >> Bernhard > >> > >> or apply each series locally. I use the b4 tool for that: > >> https://b4.docs.kernel.org/en/latest/installing.html > >> > >> i.e.: > >> > >> $ git checkout -b shentey_work > >> $ b4 am 20221120150550.63059-1-shentey@gmail.com > >> $ git am > >> ./v2_20221120_shentey_decouple_intx_to_lnkx_routing_from_south_bridges.mbx > >> $ b4 am 20221221170003.2929-1-shentey@gmail.com > >> $ git am > >> ./v4_20221221_shentey_this_series_consolidates_the_implementations_of_the_piix3_and_piix4_south.mbx > >> $ b4 am 20230102213504.14646-1-shentey@gmail.com > >> $ git am ./20230102_shentey_resolve_type_piix3_xen_device.mbx > >> > >> Now the branch 'shentey_work' contains all the patches and you can test. > >> > >> Regards, > >> > >> Phil. > >> > > > >Hi Phil and Bernard, > > > >I tried applying these 3 patch series on top of the current qemu > >master branch. > > > >Unfortunately, I saw a regression, so I can't give a tested-by tag yet. > > Hi Chuck, > > Thanks for your valuable test report! I think the culprit may be commit https://lists.nongnu.org/archive/html/qemu-devel/2023-01/msg00102.html where now 128 PIRQs are considered rather than four. I'll revisit my series and will prepare a v2 in the next days. I think there is no need for further testing v1. > > Thanks, > Bernhard Hi Bernhard, Thanks for letting me know I do not need to test v1 further. I agree the symptoms are that it is an IRQ problem - it looks like IRQs associated with the emulated usb tablet device are not making it to the guest with the patched v1 piix device on xen. I will be looking for your v2 in coming days and try it out also! Best regards, Chuck > > > > >Here are the details of the testing I did so far: > > > >Xen only needs one target, the i386-softmmu target which creates > >the qemu-system-i386 binary that Xen uses for its device model. > >That target compiled and linked with no problems with these 3 > >patch series applied on top of qemu master. I didn't try building > >any other targets. > > > >My tests used the xenfv machine type with the xen platform > >pci device, which is ordinarily called a xen hvm guest with xen > >paravirtualized network and block device drivers. It is based on the > >i440fx machine type and so emulates piix3. I tested the xen > >hvm guests with two different configurations as described below. > > > >I tested both Linux and Windows guests, with mixed results. With the > >current Qemu master (commit 222059a0fccf4 without the 3 patch > >series applied), all tested guest configurations work normally for both > >Linux and Windows guests. > > > >With these 3 patch series applied on top of the qemu master branch, > >which tries to consolidate piix3 and piix4 and resolve the xen piix3 > >device that my guests use, I unfortunately got a regression. > > > >The regression occurred with a configuration that uses the qemu > >bochs stdvga graphics device with a vnc display, and the qemu > >usb-tablet device to emulate the mouse and keyboard. After applying > >the 3 patch series, the emulated mouse is not working at all for Linux > >guests. It works for Windows guests, but the mouse pointer in the > >guest does not follow the mouse pointer in the vnc window as closely > >as it does without the 3 patch series. So this is the bad news of a > >regression introduced somewhere in these 3 patch series. > > > >The good news is that by using guests in a configuration that does > >not use the qemu usb-tablet device or the bochs stdvga device but > >instead uses a real passed through usb3 controller with a real usb > >mouse and a real usb keyboard connected, and also the real sound > >card and vga device passed through and a 1920x1080 HDMI monitor, > >there is no regression introduced by the 3 patch series and both Linux > >and Windows guests in that configuration work perfectly. > > > >My next test will be to test Bernhard's published git tag without > >trying to merge the 3 patch series into master and see if that also > >has the regression. I also will double check that I didn't make > >any mistakes in merging the 3 patch series by creating the shentey_work > >branch with b4 and git as Phil described and compare that to my > >working tree. > > > >I also will try testing only the first series, then the first series and the > >second series, to try to determine in which of the 3 series the regression > >is introduced. > > > >Best regards, > > > >Chuck From xen-devel-bounces@lists.xenproject.org Wed Jan 04 14:35:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 14:35:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471195.730939 (Exim 4.92) (envelope-from ) id 1pD4rg-0005el-Pe; Wed, 04 Jan 2023 14:35:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471195.730939; Wed, 04 Jan 2023 14:35:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD4rg-0005ee-Mk; Wed, 04 Jan 2023 14:35:36 +0000 Received: by outflank-mailman (input) for mailman id 471195; Wed, 04 Jan 2023 14:35:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD4rf-0005eY-AD for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 14:35:35 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2042.outbound.protection.outlook.com [40.107.21.42]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0b218fdf-8c3d-11ed-91b6-6bf2151ebd3b; Wed, 04 Jan 2023 15:35:33 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM7PR04MB7158.eurprd04.prod.outlook.com (2603:10a6:20b:120::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Wed, 4 Jan 2023 14:35:30 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5944.019; Wed, 4 Jan 2023 14:35:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0b218fdf-8c3d-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RWhIRKcMsrRSFxT20nxy5pJ+TmXM6ob/S50ssBFPkAnzP+UsmWPoLXIZD9/aTimxf6ZtMqRGF1+JBPr4JJLVQTrtGQv7fIrTngqTXVV3oOtbAfCwFx8hn1RM1VQnNyFkQlIl1zl4BoBiioZO1U3Ea6hqUeDTYyCP4F+dgKqt+PpSJ0FadW2A+MshxzwxpNYAjcEhoheyEbDmhSdMkE07Ar0MBkrWALrtN+xgiPrhnC0zlBm67g7YpGI7LPNlSsI/SDFx6gvHS99K6JmJeGqZN6vLjQDV8egwIFWSVJEgkAtTsER5pGODn7OxFRkcCEC8xavzRvIqQtpqrjuipdILPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KSdnEC4H8uuzngem4U0xCx9Q9CnYDPx8Fuv7+TTrdUE=; b=gbJsV5NDu+XPYCZG8w2NKcgxS3JaRlLkB+d2AM7oDcSNxIt7lUaffGiPDA4bMumdHGrfAN/bY0ULkHINBQWo9p8BcnJqRNeTQvBmWormc+QreoyxFYga8a30dt0do6Oo80M8OCsgpRuWWKk4qZDNnFWbd0924QfzgtBn5xIXTbmp4/DdNoq0VIDGlAxz+Q8fixme8eb9m3BcXiDmzys6XdaP03A0cnnzOcq30GKI1mzxKWYqSbfApjShO88ii0QJq4biBC/c7yG3EzAJkjyvuz3VCOsos1M6bT13dj8Nc/gNfJLiJMoMZ8bFSDIsSimdLcN3cnpy0FzwZrQUACCS0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KSdnEC4H8uuzngem4U0xCx9Q9CnYDPx8Fuv7+TTrdUE=; b=T6BWMIFozNHFtJfjNPJT3m0J64UMt1UGqpzy1mvEJWNyWX9urVnUZl+gAMDTIZFKyEBr4CY53fJu5g+M3pKb7dfExQ/a1qV+mh4I7tDEO19V3bKKNMklZc8IV/mF17lCNNdPWI16EuhQeXNthcotlolTHkYsPGaKd6n3urMBazG1TZQiaA45/cJREn0MYZrTL6Fga5GH/isJ8m4wruxV+HCDM6BTUcI1yK9UnEP5DEgPnlHyUPl6PcI9lIoZys7kz80XwJwSDa3krW84vkrHvA1gzjxgxLWVl2KwaFSk2jI2FilAHH9uAZ0ZKkB+bGY53VurkHOuoKIGs+L56p72/Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <37b87d38-de11-cc8d-0663-73c09e1dfd0c@suse.com> Date: Wed, 4 Jan 2023 15:35:28 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 1/2] x86/cpuid: Infrastructure for leaves 7:1{ecx,edx} Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230104111146.2094-1-andrew.cooper3@citrix.com> <20230104111146.2094-2-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20230104111146.2094-2-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0090.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9b::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM7PR04MB7158:EE_ X-MS-Office365-Filtering-Correlation-Id: 41f0afcd-ee32-40e5-f8de-08daee60ee16 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iEXdOrYZKGClUXAZax0JWRCl4iiSAgRtG5f6W1S/MSNZqQ6tvSfLpsgdiBA2IkvffM7hMH4eoqXWqH5ySD9LufxVJOT45Blk+oS0rF+B3SBoDlIBvuhMV4CNos7RUt5c/q0YmS1gxe/hFO3BAQyrTMsBin/wFmV0Ui1TibYXMld/YxiHwamXKR2pZ0TcsJxuItdNOX3AfLSdFfSikyjD1wr3wycAKK252QOG4VK264h9RFLJaHj1lBa+G6TpnFWCBCPB8bB3oznK/NfR+KsKLKBxK0sZwRlxAdpppyRGt6xoigjRTllHKQN4nbLQnNLgFtQ3CZS833jAVidXSiFOl7Yqe6mWsQyPsWB9nZT8e7jf9gUVYDxGF2+BRujoHvSlalS/OgRbOPZw6wXEP9up1GXYC6AvbZonuI0xMnTUPE/zfOjMAdodfILFZibihUwLhUg/XbvsxIrm9pWsfZGe4M6NQ817T2DbMABN51VprU7PQVXXpNkBcGwQxJBek5T9G3zIU/3nq9SJ6j+pZM7kxQxZQFDanMXmXrC/DiK0lKNxXczMonckp+vvIvxCgFH488arJCkBwGWDzM83o9g+pE7aTkUouQ25NCFciI2/Gg7ERj1qJx+xI1htlOJFcgN4k8anj1Y4/3Yfi388ph0kKMw1ccAYC0zjuUF7p9vZ++jmZ4dK+2/niNUrMPiqQRM5RHzVgkCx6KqdUcSTRR6s6DtMqq44SPPHytA9l0KbAoA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(376002)(396003)(366004)(39860400002)(136003)(451199015)(31696002)(86362001)(83380400001)(6506007)(53546011)(36756003)(2616005)(26005)(186003)(6512007)(38100700002)(6486002)(478600001)(8936002)(31686004)(4326008)(66946007)(66556008)(8676002)(41300700001)(316002)(66476007)(54906003)(6916009)(2906002)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cGdGb0doMjhkc2RQQW9talc5MWE0TGdwTzVqdjMrRFd0eTZEbTJQNjBQRVV4?= =?utf-8?B?VVhQMHd3ZFkwYWpxMzY0WVc5b29nUnM5cWpZYmRUbkxsMVdlZVhJMVVIeFpl?= =?utf-8?B?V3hqZTdjRFJPWHoxNjZkWDVHdGJUNlhPcVY3VWpqNlljbis2aUxaVTY4bFND?= =?utf-8?B?WHE3NzZmOEJ6bUNPWjh4OHNNWFJVSVNhdWkrOUUyWFJueUt5WlNXOGg2Skln?= =?utf-8?B?ZzBxNzdja0Qrcmg4V3RxampKZFQ3VWlXd21KbEFWOXNFYlNPTWJ3aHhET05H?= =?utf-8?B?MHB6WWZvZEova00xWkxmUXM1S0dITGVqNnpYMlpRTDNzeTlWeEcyTjJ6bG9u?= =?utf-8?B?cDBUd05ZZ1Y2RVBxbU1wamN5amZLbTFRRlFObGtLTFUvWjV3OCs5RzEvMk13?= =?utf-8?B?aG56dzlwcVppc3dadDZxZEFxcGp0cTNSODV1cTFTVzZtd1J5ZlVZaHo4ZTdG?= =?utf-8?B?OGsvMWdjWTJiSHEvaW1ncDJBbi9uTHA0MFFrQXJNcG5BMmtwTi9hbWk5Z3FG?= =?utf-8?B?aUlGUnZubEw4K1haVWlmVW9ieENPY0dZbWptQ0cvWjRVVzU5bmNXRjJTZnVU?= =?utf-8?B?cUxHd0I5SEZDZjNOQzhIaEVnL2FlRE82Nm9YVUE2UVEwNmdtSVp5OTNLMTdy?= =?utf-8?B?K21SQmVsYmNOcFlrQjdKdHZ1bWRNWFhUS0g2OHpMR2lZSmdmcWQ1dVJRMGVR?= =?utf-8?B?NGNDK0l5bzhVaFZYV25hMVV0b3RHRTZ5OVFQd3R2cm1aYzl3YVNrb0ZYRjVQ?= =?utf-8?B?dGpkQ2ZXRnlqMEN4c0t5UnlYd1BBMnJSd3JIYnVoT2tTTjdxSzh5TnN4OXQv?= =?utf-8?B?Z3ZUdk9RZmFOc3dobVg1eVVBa2hnRE9LZlRidGJiU0pNMlNmUHZqajlCSjVa?= =?utf-8?B?bGRicGF5KzFpQW5LUUk0TmZ5TnpBR0hYbUs0TTl6RzFuQml3bTRVYzlkVWJK?= =?utf-8?B?UFJ0dmZ0T05uMkpxM1RYanZkU0YxanJmS095aXJBTTduNEwyTlBiQ0xNNTZj?= =?utf-8?B?MWszU1F4bHhUaDdqWTZZczdsYTBHem1mQWw4L1ZqN1ZkOUJMalRtS1FCVkRp?= =?utf-8?B?TWlBY3ovWEFadk15UXdSSjlNSGMxc1BINHFZV1hrWGQrL2dJRGpRbjBlOUd5?= =?utf-8?B?RlRya2tPSzhPQnN6WjZWOW5oZ1dZTSt1Q2NXcm02TGMvajArSXNYc1lINWhL?= =?utf-8?B?TU9Tb0RwRDYxWldSNEZFNHZTLzhsQTBnanc4S0ZLa29GWWtxa2thOVh2T3FE?= =?utf-8?B?U09oWU5pY3ViMFduRVBuUnd5Y1ErcEQ4MFdndjl6cDhqRXJ4bVhxeUE4NUVj?= =?utf-8?B?UDZrTmdJaERIZGhsallZT3FNVnpURlJKSTBpS2VaSVhpNkxoYnJwYjhwalZ2?= =?utf-8?B?b0oxUXdDekR1V3NFU1lrRVI1eEpsMm4rSjJ0a0VMaCtaY2hSclNaZERCa0xC?= =?utf-8?B?Sm9ZWHRjZVg4WEVkK0JQVENCdzJ3WmlzSnF6Q2g1S0U2OUJuYnZ1RW1yWUxv?= =?utf-8?B?bVZSb0V1bGl0UlI1cGhXVjV5YXhwWE5Cd2RiNGRoVFNlemdQMGJIOGlRV3J3?= =?utf-8?B?QlpuQTRRQVIydGd2QVdacnFuQ3EyclhLeE9nWXVjRlErMjJKSktoZFdjaS9P?= =?utf-8?B?aXRGR0NnYUlML3ZGSFFFeFJRc1ZHMHNFWWZiR2ZuclNGQXhqTUVGTEsybXdW?= =?utf-8?B?Q0N5elg4ZmNRKzB4MlNDYXQyTEVoQzJ1MjJxb2VBTncrOTNJMUFzc2FWNDlS?= =?utf-8?B?Ulh2akNUeTJualhjaU8zL2tmcFlScTdnVG9FRTRUZ0JFKzhNbHBuRTI5Mk5B?= =?utf-8?B?bGtjNUZyN05OVzdXWXBDT2lmZE9vbVZkVzgvNXl1Zk9sQk0vWUlLRnJuRDVH?= =?utf-8?B?NmFyRS9pMWN0Nkc4eWN1eU10WEIxYzBiSXJQNGhLREM2aGpPd1VQNDNRSmVS?= =?utf-8?B?ZlRNeEplOHVZd0tlcUgrQ3lIZWJYQm4rdTltZk1mOUxaRTlPRjllZnl4eS9a?= =?utf-8?B?UTNBZFJtcVNCbURNaS9SVCtzTXhoSEFiUUllQ0NhTm9SbWZkRkxJc1V6b3hQ?= =?utf-8?B?WVVadk43QTRySmExMFNxaGIrVytob1gzNGZGcGtPUlBXRjZuMWo2Yndoamkv?= =?utf-8?Q?TC0NqRDThuNDsJsBJ13pvfDYb?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 41f0afcd-ee32-40e5-f8de-08daee60ee16 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2023 14:35:30.6975 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wRr8THmXfwl5VM15QaJ9PE/X5HK7L2uzUN+cly8HTnGTImTIoLvCcDVIIFTi/RWykg+YGRV0U4l4L0YRxS28nQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7158 On 04.01.2023 12:11, Andrew Cooper wrote: > We don't actually need ecx yet, but adding it in now will reduce the amount to > which leaf 7 is out of order in a featureset. > > cpufeatureset.h remains in leaf architectrual order for the sanity of anyone > trying to locate where to insert new rows. > > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich albeit ... > --- a/xen/include/public/arch-x86/cpufeatureset.h > +++ b/xen/include/public/arch-x86/cpufeatureset.h > @@ -288,6 +288,9 @@ XEN_CPUFEATURE(NSCB, 11*32+ 6) /*A Null Selector Clears Base (and > /* Intel-defined CPU features, CPUID level 0x00000007:1.ebx, word 12 */ > XEN_CPUFEATURE(INTEL_PPIN, 12*32+ 0) /* Protected Processor Inventory Number */ > > +/* Intel-defined CPU features, CPUID level 0x00000007:1.ecx, word 14 */ > +/* Intel-defined CPU features, CPUID level 0x00000007:1.edx, word 15 */ > + ... I'm not convinced getting these ordered by other than their word indexes is quite reasonable. We can't really predict in what order elements / leaves get populated, as can best be seen from ... > /* Intel-defined CPU features, CPUID level 0x00000007:2.edx, word 13 */ > XEN_CPUFEATURE(INTEL_PSFD, 13*32+ 0) /*A MSR_SPEC_CTRL.PSFD */ > XEN_CPUFEATURE(IPRED_CTRL, 13*32+ 1) /* MSR_SPEC_CTRL.IPRED_DIS_* */ ... subleaf 2 already having one entry, and that one not being eax, ebx, nor ecx, but edx. AMD (extended) leaves would also always be sprinkled into the middle of any such sequence. To me it ends up more confusing (perhaps not right away, but in a couple of years time) if one needs to go hunt for what the next free index value would be. Similarly the need to re-base stuff using non-upstream index values (like is the case for the KeyLocker leaves that I have pending locally) is easier to notice when new sets are put at the end of the existing list. In any event, what I'd like to ask for as a minimum is that you insert a blank line between the two new comments. Jan From xen-devel-bounces@lists.xenproject.org Wed Jan 04 14:45:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 14:45:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471204.730964 (Exim 4.92) (envelope-from ) id 1pD51E-0007Sm-EA; Wed, 04 Jan 2023 14:45:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471204.730964; Wed, 04 Jan 2023 14:45:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD51E-0007Rs-9t; Wed, 04 Jan 2023 14:45:28 +0000 Received: by outflank-mailman (input) for mailman id 471204; Wed, 04 Jan 2023 14:45:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD51C-00079V-3l for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 14:45:26 +0000 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [2a00:1450:4864:20::429]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6b8f66c4-8c3e-11ed-b8d0-410ff93cb8f0; Wed, 04 Jan 2023 15:45:24 +0100 (CET) Received: by mail-wr1-x429.google.com with SMTP id s9so1187877wru.13 for ; Wed, 04 Jan 2023 06:45:24 -0800 (PST) Received: from osoxes.fritz.box (p200300faaf0bb2009c4947838afc41b6.dip0.t-ipconnect.de. [2003:fa:af0b:b200:9c49:4783:8afc:41b6]) by smtp.gmail.com with ESMTPSA id e10-20020a5d594a000000b0028663fc8f4csm21168241wri.30.2023.01.04.06.45.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Jan 2023 06:45:23 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6b8f66c4-8c3e-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qwwBmjkQ+lNHH0kKiW9e0yfr8jRksndzOx0yQHLnF3U=; b=Wch2+6IG0obcLWirCwO0uN2viNNRWGwjqAFhW/ZYw1fchDlIbgWmuB3c8dlern5JGN 4zUs9Y2GjuybCLMXzn2i3IB2HpMdnJ3HOfcR0Id/ZqbSM3D2zZU/HKa/camSQegFxTMw AHdCTPkE+aAGidOO551rDDq7D9WH+cxg/4sMPHQ+cM+9wzSWfesq1yH6xy47O9xTEoFd eZfdHHVnJEmwB7VwCBj9m9+mWDLchXhhkYcMqSmiWNviCG4U3NvQshROvXH0TUL+D83f 7bjrqMxVbRF0Ka56hPzfPNov9BdR1GZ9Rp8kUFHu/C6dGAo3y08PsXTkRemZcP/M5Y9L Ojww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qwwBmjkQ+lNHH0kKiW9e0yfr8jRksndzOx0yQHLnF3U=; b=ha4OAtcP3A//iPmL22Htk6mlfmsxKkyCAtcj+wFfNTPK4W7NfBUH92dNVbuZ67/5DU HtjyJmAhsuDpIwtPWRa+sQQKbBblXN81VJuUjpF83odvMT8vMQxvbkt6OxjoowTKckLR lxyx/znmf5sWnsNGpvneX5P85Ay1mNIIjvKepEVtVX/JMFnWKooUZIMNcvWBmVH/uWrK KzWZfQ2nNiTLmhJNwgIgXio1uNKwaY6VVNGaOM/dxxozJWYsXMVPHprs4YAOrhuMKNns /zAgwhbmCcpoTsZjmqhx0wGUXTu5dtNOVneIxnM9/+OW1Wn0n24FVDk3ZtRtauvlGNRI /CmA== X-Gm-Message-State: AFqh2ko9ayom09+ubbFwtjokwIp9A8wUPW7/gXxOyCIVvQkxui1NDcnH jcji60g8/Uy8LHvfgf2NT54= X-Google-Smtp-Source: AMrXdXv1Bz9WYYfmdlxF76KLvJgFfsoIF1V0rIeHDad7Wu77HbMKWyWlh26v/oTTwkdlUrXJkWzplw== X-Received: by 2002:a05:6000:1d84:b0:273:6845:68ef with SMTP id bk4-20020a0560001d8400b00273684568efmr24329892wrb.60.1672843523618; Wed, 04 Jan 2023 06:45:23 -0800 (PST) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: Richard Henderson , Stefano Stabellini , xen-devel@lists.xenproject.org, =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Aurelien Jarno , Paul Durrant , Marcel Apfelbaum , Anthony Perard , "Michael S. Tsirkin" , Paolo Bonzini , Eduardo Habkost , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Chuck Zmudzinski , Bernhard Beschow Subject: [PATCH v2 1/6] include/hw/xen/xen: Rename xen_piix3_set_irq() to xen_intx_set_irq() Date: Wed, 4 Jan 2023 15:44:32 +0100 Message-Id: <20230104144437.27479-2-shentey@gmail.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230104144437.27479-1-shentey@gmail.com> References: <20230104144437.27479-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit xen_piix3_set_irq() isn't PIIX specific: PIIX is a single PCI device while xen_piix3_set_irq() maps multiple PCI devices to their respective IRQs, which is board-specific. Rename xen_piix3_set_irq() to communicate this. Also rename XEN_PIIX_NUM_PIRQS to XEN_IOAPIC_NUM_PIRQS since the Xen's IOAPIC rather than PIIX has this many interrupt routes. Signed-off-by: Bernhard Beschow --- hw/i386/xen/xen-hvm.c | 2 +- hw/isa/piix.c | 4 ++-- include/hw/xen/xen.h | 2 +- stubs/xen-hw-stub.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c index e4293d6d66..558c43309e 100644 --- a/hw/i386/xen/xen-hvm.c +++ b/hw/i386/xen/xen-hvm.c @@ -142,7 +142,7 @@ int xen_pci_slot_get_pirq(PCIDevice *pci_dev, int irq_num) return irq_num + (PCI_SLOT(pci_dev->devfn) << 2); } -void xen_piix3_set_irq(void *opaque, int irq_num, int level) +void xen_intx_set_irq(void *opaque, int irq_num, int level) { xen_set_pci_intx_level(xen_domid, 0, 0, irq_num >> 2, irq_num & 3, level); diff --git a/hw/isa/piix.c b/hw/isa/piix.c index ae8a27c53c..a7a4eec206 100644 --- a/hw/isa/piix.c +++ b/hw/isa/piix.c @@ -38,7 +38,7 @@ #include "migration/vmstate.h" #include "hw/acpi/acpi_aml_interface.h" -#define XEN_PIIX_NUM_PIRQS 128ULL +#define XEN_IOAPIC_NUM_PIRQS 128ULL static void piix_set_irq_pic(PIIXState *piix, int pic_irq) { @@ -504,7 +504,7 @@ static void piix3_xen_realize(PCIDevice *dev, Error **errp) * connected to the IOAPIC directly. * These additional routes can be discovered through ACPI. */ - pci_bus_irqs(pci_bus, xen_piix3_set_irq, piix3, XEN_PIIX_NUM_PIRQS); + pci_bus_irqs(pci_bus, xen_intx_set_irq, piix3, XEN_IOAPIC_NUM_PIRQS); } static void piix3_xen_class_init(ObjectClass *klass, void *data) diff --git a/include/hw/xen/xen.h b/include/hw/xen/xen.h index afdf9c436a..7c83ecf6b9 100644 --- a/include/hw/xen/xen.h +++ b/include/hw/xen/xen.h @@ -22,7 +22,7 @@ extern bool xen_domid_restrict; int xen_pci_slot_get_pirq(PCIDevice *pci_dev, int irq_num); int xen_set_pci_link_route(uint8_t link, uint8_t irq); -void xen_piix3_set_irq(void *opaque, int irq_num, int level); +void xen_intx_set_irq(void *opaque, int irq_num, int level); void xen_hvm_inject_msi(uint64_t addr, uint32_t data); int xen_is_pirq_msi(uint32_t msi_data); diff --git a/stubs/xen-hw-stub.c b/stubs/xen-hw-stub.c index 34a22f2ad7..7d7ffe83a9 100644 --- a/stubs/xen-hw-stub.c +++ b/stubs/xen-hw-stub.c @@ -15,7 +15,7 @@ int xen_pci_slot_get_pirq(PCIDevice *pci_dev, int irq_num) return -1; } -void xen_piix3_set_irq(void *opaque, int irq_num, int level) +void xen_intx_set_irq(void *opaque, int irq_num, int level) { } -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Wed Jan 04 14:45:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 14:45:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471202.730950 (Exim 4.92) (envelope-from ) id 1pD51C-00079t-OE; Wed, 04 Jan 2023 14:45:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471202.730950; Wed, 04 Jan 2023 14:45:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD51C-00079m-L2; Wed, 04 Jan 2023 14:45:26 +0000 Received: by outflank-mailman (input) for mailman id 471202; Wed, 04 Jan 2023 14:45:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD51B-00079V-BY for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 14:45:25 +0000 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [2a00:1450:4864:20::42f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6b14eac9-8c3e-11ed-b8d0-410ff93cb8f0; Wed, 04 Jan 2023 15:45:23 +0100 (CET) Received: by mail-wr1-x42f.google.com with SMTP id w1so21082853wrt.8 for ; Wed, 04 Jan 2023 06:45:23 -0800 (PST) Received: from osoxes.fritz.box (p200300faaf0bb2009c4947838afc41b6.dip0.t-ipconnect.de. [2003:fa:af0b:b200:9c49:4783:8afc:41b6]) by smtp.gmail.com with ESMTPSA id e10-20020a5d594a000000b0028663fc8f4csm21168241wri.30.2023.01.04.06.45.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Jan 2023 06:45:22 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6b14eac9-8c3e-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=8AWtfe719mk9eM2p93lKeuen7Jx5n1pIewca97MBqdc=; b=OwFsjrcMxKj1s4H/fotfYoCBwsygaVEcANDEtkGKlRyfBhRTz2OCJEfvXLHdpvGD7x 1UEQXKL/fkPiuknoLjoM5DN7aY70nsceK2OJjfdaAgw9ncTN9zqwANYNKuVh9/VYPIav Gxa5DzQLOhl4wRP4fdUdJRo0/0J+NooIx+ufMBgihzp8h8ReOBqkfcMdo5OIuU7w6C1T xeIFvIeZUCH0v04IqmRX6RWe7b9aT6myshNL5uBQppaZzdT6fjevlsqcM0Ali9GqYGyM 3aA5vHjcTLoKc3+eO5xe3fGq8g9ZH0qb1jafzvK3ILB8i4T2FQ5zM5m/u/LZkPbBN/GS +UMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8AWtfe719mk9eM2p93lKeuen7Jx5n1pIewca97MBqdc=; b=Y+BI5Lx0ljBGFGeV01i+XvUq18IBuXCIzgOikKUY5CTWVKZ5eN1rQwNuOyL5/N5/mj pwgwec873LDLleg5xtmK420SbNUBb+7XTPmD9zQdwoeqGc0ggFMk7mq2xSy+MOiNsJlo fdwap9bmVJLFp5Qr0qcX6SZb9gxPPb03fCQSJjiJ9IxPMKDV7fPuXFv4RXhsGWQjDDwN lFxKLxfjsxF58VmbSGy1sModkypnlygJll4KSvuDBGCMwMV+vxR6eypfFsQlJmt9dFQ3 b/ArioVeZJEbqiM18IdYP4bXocxprc8HlzAoiTrPhn78GCPrkJeQLgQlA4KcR6lwUInO A63g== X-Gm-Message-State: AFqh2korvb/y1hK+QB8RwuTWj3WabA+qKQ5+2Om5tPdtsg0MAXTjGKMW jfIVJJmtiAKRlP8SE0mR8SE= X-Google-Smtp-Source: AMrXdXvIETTxnaRaRvm9hcFDe31cy8g3McWj56E8OyCHBH1xc4SjLtjj5azN8me5MaQQNXaIHCKkjw== X-Received: by 2002:a5d:5e81:0:b0:244:e704:df2c with SMTP id ck1-20020a5d5e81000000b00244e704df2cmr34565713wrb.57.1672843522692; Wed, 04 Jan 2023 06:45:22 -0800 (PST) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: Richard Henderson , Stefano Stabellini , xen-devel@lists.xenproject.org, =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Aurelien Jarno , Paul Durrant , Marcel Apfelbaum , Anthony Perard , "Michael S. Tsirkin" , Paolo Bonzini , Eduardo Habkost , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Chuck Zmudzinski , Bernhard Beschow Subject: [PATCH v2 0/6] Resolve TYPE_PIIX3_XEN_DEVICE Date: Wed, 4 Jan 2023 15:44:31 +0100 Message-Id: <20230104144437.27479-1-shentey@gmail.com> X-Mailer: git-send-email 2.39.0 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable This series first renders TYPE_PIIX3_XEN_DEVICE redundant and finally remov= es=0D it. The motivation is to 1/ decouple PIIX from Xen and 2/ to make Xen in th= e PC=0D machine agnostic to the precise southbridge being used. 2/ will become=0D particularily interesting once PIIX4 becomes usable in the PC machine, avoi= ding=0D the "Frankenstein" use of PIIX4_ACPI in PIIX3.=0D =0D v2:=0D - xen_piix3_set_irq() is already generic. Just rename it. (Chuck)=0D =0D Testing done:=0D None, because I don't know how to conduct this properly :(=0D =0D Based-on: <20221221170003.2929-1-shentey@gmail.com>=0D "[PATCH v4 00/30] Consolidate PIIX south bridges"=0D =0D Bernhard Beschow (6):=0D include/hw/xen/xen: Rename xen_piix3_set_irq() to xen_intx_set_irq()=0D hw/isa/piix: Reuse piix3_realize() in piix3_xen_realize()=0D hw/isa/piix: Wire up Xen PCI IRQ handling outside of PIIX3=0D hw/isa/piix: Avoid Xen-specific variant of piix_write_config()=0D hw/isa/piix: Resolve redundant k->config_write assignments=0D hw/isa/piix: Resolve redundant TYPE_PIIX3_XEN_DEVICE=0D =0D hw/i386/pc_piix.c | 34 ++++++++++++++++--=0D hw/i386/xen/xen-hvm.c | 2 +-=0D hw/isa/piix.c | 66 +----------------------------------=0D include/hw/southbridge/piix.h | 1 -=0D include/hw/xen/xen.h | 2 +-=0D stubs/xen-hw-stub.c | 2 +-=0D 6 files changed, 35 insertions(+), 72 deletions(-)=0D =0D -- =0D 2.39.0=0D =0D From xen-devel-bounces@lists.xenproject.org Wed Jan 04 14:45:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 14:45:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471205.730972 (Exim 4.92) (envelope-from ) id 1pD51E-0007WK-RO; Wed, 04 Jan 2023 14:45:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471205.730972; Wed, 04 Jan 2023 14:45:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD51E-0007Ur-Jr; Wed, 04 Jan 2023 14:45:28 +0000 Received: by outflank-mailman (input) for mailman id 471205; Wed, 04 Jan 2023 14:45:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD51D-00079V-SS for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 14:45:27 +0000 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [2a00:1450:4864:20::433]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6cc26dac-8c3e-11ed-b8d0-410ff93cb8f0; Wed, 04 Jan 2023 15:45:26 +0100 (CET) Received: by mail-wr1-x433.google.com with SMTP id bk16so19994157wrb.11 for ; Wed, 04 Jan 2023 06:45:26 -0800 (PST) Received: from osoxes.fritz.box (p200300faaf0bb2009c4947838afc41b6.dip0.t-ipconnect.de. [2003:fa:af0b:b200:9c49:4783:8afc:41b6]) by smtp.gmail.com with ESMTPSA id e10-20020a5d594a000000b0028663fc8f4csm21168241wri.30.2023.01.04.06.45.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Jan 2023 06:45:25 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6cc26dac-8c3e-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jWsSUpGWnwKoxzlBa2RTErBbFhPwkbaywyVJwsOJ9Nk=; b=YlPrLritShhHTaeSGbLlb++n9XqS9VBhEgsy2PwwgydtFFm8UrBGDJ7iUMy8EaMHeH 9SBO1n2DyEa7U5jCTGTOQDdlOVkvnVOt1hp8JY3uNc4BSSwglDnmGx2Ero35GpcLb5UZ lxDNlGzSW/OY/+wh4qjm3mF5gciV5251nu62u5qkggcU3PaBu3OtH7lvV3LzAIHUHPpY i/fR6+7MuwJBxH89wLn/4BkSrlZxnPIIZCNrMfecj4xhrjBhXyY2bE6HPVdgtcf6jPaJ iN/TGG+HuHA766ERLaC5giouVQ+KfyHIHRbdPCXS9JqqjfVfCA6wQA2G70I6E8iUvn/6 2/8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jWsSUpGWnwKoxzlBa2RTErBbFhPwkbaywyVJwsOJ9Nk=; b=7qubFAMSt0fgnIvn0DjngdK/c1YJK3nunCjBytT/lxypyWA2pIpWEv4Fgw7FaHgtL3 hGFuPLIJHGeES8zA0VYyUsGEE5JU/hOUxuKeLh25Zt/96MHVEbmXj/8Tcsi4M/nrDMkH fg2X8bU2ro69SvUUUNv/gVvWniIBppFycOwAIjyI7gom+L+dKLb8GQSC+iB7a0ThkXlA HikQfR8zytqpXEXh4lc97n54B0YkbMuF+1L+1TcYwoZNli8jYyenYayZJn9GamHU+YN0 ZqRoaMbhYwsJyGeD3Uwo6EFVnjVpWuZ5cTJqJFi5VeobGLTTB093jOroWCuKHnEzY6B8 xa5Q== X-Gm-Message-State: AFqh2ko0JyJW1tJrzpeJBaM5z/YbJf9LNMrxatT+TxPR58ULo2CD7c13 uiTha4ScvyKUiHT0dgnVq1w= X-Google-Smtp-Source: AMrXdXtdVz6/t/nUcG3XroMW/zOMXTIelUM5J1RHwOTKB+xhi7kJEMzBdrFkmDsmcHHUWZlTsIodDw== X-Received: by 2002:adf:f4c5:0:b0:291:3f93:b7d1 with SMTP id h5-20020adff4c5000000b002913f93b7d1mr11327512wrp.64.1672843525599; Wed, 04 Jan 2023 06:45:25 -0800 (PST) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: Richard Henderson , Stefano Stabellini , xen-devel@lists.xenproject.org, =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Aurelien Jarno , Paul Durrant , Marcel Apfelbaum , Anthony Perard , "Michael S. Tsirkin" , Paolo Bonzini , Eduardo Habkost , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Chuck Zmudzinski , Bernhard Beschow Subject: [PATCH v2 3/6] hw/isa/piix: Wire up Xen PCI IRQ handling outside of PIIX3 Date: Wed, 4 Jan 2023 15:44:34 +0100 Message-Id: <20230104144437.27479-4-shentey@gmail.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230104144437.27479-1-shentey@gmail.com> References: <20230104144437.27479-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit xen_intx_set_irq() doesn't depend on PIIX state. In order to resolve TYPE_PIIX3_XEN_DEVICE and in order to make Xen agnostic about the precise south bridge being used, set up Xen's PCI IRQ handling of PIIX3 in the board. Signed-off-by: Bernhard Beschow --- hw/i386/pc_piix.c | 12 ++++++++++++ hw/isa/piix.c | 24 +----------------------- 2 files changed, 13 insertions(+), 23 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index aacdb72b7c..792dcd3ce8 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -67,6 +67,7 @@ #include "kvm/kvm-cpu.h" #define MAX_IDE_BUS 2 +#define XEN_IOAPIC_NUM_PIRQS 128ULL #ifdef CONFIG_IDE_ISA static const int ide_iobase[MAX_IDE_BUS] = { 0x1f0, 0x170 }; @@ -246,6 +247,17 @@ static void pc_init1(MachineState *machine, &error_abort); pci_realize_and_unref(pci_dev, pci_bus, &error_fatal); + if (xen_enabled()) { + /* + * Xen supports additional interrupt routes from the PCI devices to + * the IOAPIC: the four pins of each PCI device on the bus are also + * connected to the IOAPIC directly. + * These additional routes can be discovered through ACPI. + */ + pci_bus_irqs(pci_bus, xen_intx_set_irq, pci_dev, + XEN_IOAPIC_NUM_PIRQS); + } + dev = DEVICE(object_resolve_path_component(OBJECT(pci_dev), "pic")); for (i = 0; i < ISA_NUM_IRQS; i++) { qdev_connect_gpio_out(dev, i, x86ms->gsi[i]); diff --git a/hw/isa/piix.c b/hw/isa/piix.c index 25707479eb..ac04781f46 100644 --- a/hw/isa/piix.c +++ b/hw/isa/piix.c @@ -38,8 +38,6 @@ #include "migration/vmstate.h" #include "hw/acpi/acpi_aml_interface.h" -#define XEN_IOAPIC_NUM_PIRQS 128ULL - static void piix_set_irq_pic(PIIXState *piix, int pic_irq) { qemu_set_irq(piix->pic.in_irqs[pic_irq], @@ -487,33 +485,13 @@ static const TypeInfo piix3_info = { .class_init = piix3_class_init, }; -static void piix3_xen_realize(PCIDevice *dev, Error **errp) -{ - ERRP_GUARD(); - PIIXState *piix3 = PIIX_PCI_DEVICE(dev); - PCIBus *pci_bus = pci_get_bus(dev); - - piix3_realize(dev, errp); - if (*errp) { - return; - } - - /* - * Xen supports additional interrupt routes from the PCI devices to - * the IOAPIC: the four pins of each PCI device on the bus are also - * connected to the IOAPIC directly. - * These additional routes can be discovered through ACPI. - */ - pci_bus_irqs(pci_bus, xen_intx_set_irq, piix3, XEN_IOAPIC_NUM_PIRQS); -} - static void piix3_xen_class_init(ObjectClass *klass, void *data) { DeviceClass *dc = DEVICE_CLASS(klass); PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); k->config_write = piix3_write_config_xen; - k->realize = piix3_xen_realize; + k->realize = piix3_realize; /* 82371SB PIIX3 PCI-to-ISA bridge (Step A1) */ k->device_id = PCI_DEVICE_ID_INTEL_82371SB_0; dc->vmsd = &vmstate_piix3; -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Wed Jan 04 14:45:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 14:45:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471203.730961 (Exim 4.92) (envelope-from ) id 1pD51E-0007PI-45; Wed, 04 Jan 2023 14:45:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471203.730961; Wed, 04 Jan 2023 14:45:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD51E-0007P7-0i; Wed, 04 Jan 2023 14:45:28 +0000 Received: by outflank-mailman (input) for mailman id 471203; Wed, 04 Jan 2023 14:45:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD51C-00079b-56 for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 14:45:26 +0000 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [2a00:1450:4864:20::42a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6c262db5-8c3e-11ed-91b6-6bf2151ebd3b; Wed, 04 Jan 2023 15:45:25 +0100 (CET) Received: by mail-wr1-x42a.google.com with SMTP id s9so1187925wru.13 for ; Wed, 04 Jan 2023 06:45:25 -0800 (PST) Received: from osoxes.fritz.box (p200300faaf0bb2009c4947838afc41b6.dip0.t-ipconnect.de. [2003:fa:af0b:b200:9c49:4783:8afc:41b6]) by smtp.gmail.com with ESMTPSA id e10-20020a5d594a000000b0028663fc8f4csm21168241wri.30.2023.01.04.06.45.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Jan 2023 06:45:24 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6c262db5-8c3e-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=skngD2C07lkAR57VFiC9hSpSkRXE8QLpJkhdrtzHaoE=; b=fglIPWzWe7OF+ReYiVQjbIlqvtMvTu/HBo031zXX2Dmr6PoRqVzCCMudfgPYd4aGRi ZzXHYC+LUG8aYoxMQ2QopDZUsHWe8+I3MBPfz33YHbBlA0wpSiPunpMSxDNEQu3gic8o tjY9LXxtHVjsr5RFAPk3J091DyzHz40da+k0hi4YR2NRpwGdMpmrPobxn+rII4pfszR+ ABmHKixdWzp6dCP+vGUOG1X6vLOHELWO4oX1VeVkM5l0HNpdBbKdWd/OSHzgbTTCC2Ov ZZVVZUIoXft/7/vDq3sRETSoVxCTNiDIkVm5XL0QJYkZbABRQHyxfDTifj0y4vNNeuN2 dMvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=skngD2C07lkAR57VFiC9hSpSkRXE8QLpJkhdrtzHaoE=; b=kg0lubPSIw99ddQbqcMxO2UKuAKQ487UQqg1qktYtMniSR30oTmTs6q81N4JP3eI0i yFw91Zu6sCl2XRa9ZFvPZ18DHKcsprpvXjsrmryo8kvWMKXUI5ou/U0cd3G7qUxd9JpH ZGmouFnqsOi62gtiFCCMUnmBLW8OoFovgUYsU1UI4xBVD50mlseRbgp0acqoIJ0MfqiG loIRgnik8o6qPN7piuSN7sTDXdy7HEUZmdfoynvAdPrpX8g/aRexww5q/5W25s1SL6hT P0OwQmVUxJvx/RjpTYnQMfT81mJN7SwcJI33tn1MJ5vwbNnO+ArJWRhMXNG8Nn77on6l O2fw== X-Gm-Message-State: AFqh2kpk7jXHU7ldk5yEkqrkdWIhooaAqwZc42X8ny+AtmfkiQjkJ2jn NKmD4AgHlgHcPMoGb3fg2Io= X-Google-Smtp-Source: AMrXdXsN3egZuow7sNDCctPG+VunNJGlKj4E12ZlT9Um1FBGzDz97HrRjJAVFxuMN8+oPIQ6UyZajQ== X-Received: by 2002:adf:fa0f:0:b0:28f:b480:f4 with SMTP id m15-20020adffa0f000000b0028fb48000f4mr12954011wrr.12.1672843524496; Wed, 04 Jan 2023 06:45:24 -0800 (PST) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: Richard Henderson , Stefano Stabellini , xen-devel@lists.xenproject.org, =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Aurelien Jarno , Paul Durrant , Marcel Apfelbaum , Anthony Perard , "Michael S. Tsirkin" , Paolo Bonzini , Eduardo Habkost , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Chuck Zmudzinski , Bernhard Beschow Subject: [PATCH v2 2/6] hw/isa/piix: Reuse piix3_realize() in piix3_xen_realize() Date: Wed, 4 Jan 2023 15:44:33 +0100 Message-Id: <20230104144437.27479-3-shentey@gmail.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230104144437.27479-1-shentey@gmail.com> References: <20230104144437.27479-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This is a preparational patch for the next one to make the following more obvious: First, pci_bus_irqs() is now called twice in case of Xen where the second call overrides the pci_set_irq_fn with the Xen variant. Second, pci_bus_set_route_irq_fn() is now also called in Xen mode. Signed-off-by: Bernhard Beschow --- hw/isa/piix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/isa/piix.c b/hw/isa/piix.c index a7a4eec206..25707479eb 100644 --- a/hw/isa/piix.c +++ b/hw/isa/piix.c @@ -493,7 +493,7 @@ static void piix3_xen_realize(PCIDevice *dev, Error **errp) PIIXState *piix3 = PIIX_PCI_DEVICE(dev); PCIBus *pci_bus = pci_get_bus(dev); - pci_piix_realize(dev, TYPE_PIIX3_USB_UHCI, errp); + piix3_realize(dev, errp); if (*errp) { return; } -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Wed Jan 04 14:45:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 14:45:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471206.730989 (Exim 4.92) (envelope-from ) id 1pD51G-0007zf-5U; Wed, 04 Jan 2023 14:45:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471206.730989; Wed, 04 Jan 2023 14:45:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD51F-0007xg-Ti; Wed, 04 Jan 2023 14:45:29 +0000 Received: by outflank-mailman (input) for mailman id 471206; Wed, 04 Jan 2023 14:45:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD51E-00079V-NI for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 14:45:28 +0000 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [2a00:1450:4864:20::429]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6d631fb3-8c3e-11ed-b8d0-410ff93cb8f0; Wed, 04 Jan 2023 15:45:26 +0100 (CET) Received: by mail-wr1-x429.google.com with SMTP id s9so1188041wru.13 for ; Wed, 04 Jan 2023 06:45:26 -0800 (PST) Received: from osoxes.fritz.box (p200300faaf0bb2009c4947838afc41b6.dip0.t-ipconnect.de. [2003:fa:af0b:b200:9c49:4783:8afc:41b6]) by smtp.gmail.com with ESMTPSA id e10-20020a5d594a000000b0028663fc8f4csm21168241wri.30.2023.01.04.06.45.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Jan 2023 06:45:26 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6d631fb3-8c3e-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9kGVFT98W8E67AgEjIgODwyRdBIrAWSrE8+3kXPv+J8=; b=ZOgIvlh/yVYKniIe+nDfDmWng8AeG9tivYZ8qAp1ejGNIiF0OlcQxQQawaNqvp5kyI db6PpoClsgtQ24vN7b43iAIA4RkZZU2IuOOdMiKpghvD5UHV30I+MHCh5SnMLIlEqhWk mR+3nciHSn7my9PZJ/fxT/DQUm5quEOmOzKRJxhQXvCi1Tlkjaffx44yMQmtlg7jafz9 wOcea1XtCncOTtqIdlZLJeZYVgaPkId9KcpEWYWGMpMofvDc7L/iDozqI0Ael/BQ+wHL j+1XDUGTqoI9HCUs5EMZBaZj8RISPwyWc1chvQYyjR/soqxI4/ZON7/PcZZGAwU+arqe ymhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9kGVFT98W8E67AgEjIgODwyRdBIrAWSrE8+3kXPv+J8=; b=uqCJCt0N6crTncE10JorEj2r3sHJgBtLmnI/+SXmThCLsmNvPszNYblAPLgOJomsep g/W0QCD80NZ14/6fjbWuX0Ptqgdkm7CtjtfCXtO2kXcfgP6+AbcPSyjxQiHYwbgD1KTx IfvvXOaPYgI5IQ/5CDWcy67MJingWccMM9hEC7AWOBB9TKGk5n9Of11dMlTYZJd4dhx0 eKKPqiVjF1sCL0dVW3lPWFqlC7nStXFwa7mAn+IMPHEhuIvO/GYxktAd9/rq5DrEZvsl EIwcElE32YmhWgkvgIHXmCt3hHin/F4Nkpz3euUFRb6TmqtFWeDwAXabnbsWYnh1DSxA OSmA== X-Gm-Message-State: AFqh2krlW2JxHLCP9cclFtLM2fFwHgJr4scvfnS6uAhgE6Mn41skztBl xzDVTSqGFQM42PtzvyJnReo= X-Google-Smtp-Source: AMrXdXu/V1VAakoVNA901K1DaXhCb0Z6edEmYwIKwkLsKHezEymfRbemWS6Mw7ngG0Tn4FnagiDi+A== X-Received: by 2002:a5d:5485:0:b0:294:50d6:86ad with SMTP id h5-20020a5d5485000000b0029450d686admr8741280wrv.2.1672843526555; Wed, 04 Jan 2023 06:45:26 -0800 (PST) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: Richard Henderson , Stefano Stabellini , xen-devel@lists.xenproject.org, =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Aurelien Jarno , Paul Durrant , Marcel Apfelbaum , Anthony Perard , "Michael S. Tsirkin" , Paolo Bonzini , Eduardo Habkost , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Chuck Zmudzinski , Bernhard Beschow Subject: [PATCH v2 4/6] hw/isa/piix: Avoid Xen-specific variant of piix_write_config() Date: Wed, 4 Jan 2023 15:44:35 +0100 Message-Id: <20230104144437.27479-5-shentey@gmail.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230104144437.27479-1-shentey@gmail.com> References: <20230104144437.27479-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subscribe to pci_bus_fire_intx_routing_notifier() instead which allows for having a common piix_write_config() for all PIIX device models. While at it, move the subscription into machine code in order to resolve TYPE_PIIX3_XEN_DEVICE. In a possible future followup, pci_bus_fire_intx_routing_notifier() could be adjusted in such a way that subscribing to it doesn't require knowledge of the device firing it. Signed-off-by: Bernhard Beschow --- hw/i386/pc_piix.c | 18 ++++++++++++++++++ hw/isa/piix.c | 22 +--------------------- 2 files changed, 19 insertions(+), 21 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 792dcd3ce8..5738d9cdca 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -86,6 +86,21 @@ static int pci_slot_get_pirq(PCIDevice *pci_dev, int pci_intx) return (pci_intx + slot_addend) & 3; } +static void piix_intx_routing_notifier_xen(PCIDevice *dev) +{ + int i; + + /* Scan for updates to PCI link routes (0x60-0x63). */ + for (i = 0; i < PIIX_NUM_PIRQS; i++) { + uint8_t v = dev->config_read(dev, PIIX_PIRQCA + i, 1); + if (v & 0x80) { + v = 0; + } + v &= 0xf; + xen_set_pci_link_route(i, v); + } +} + /* PC hardware initialisation */ static void pc_init1(MachineState *machine, const char *host_type, const char *pci_type) @@ -248,6 +263,9 @@ static void pc_init1(MachineState *machine, pci_realize_and_unref(pci_dev, pci_bus, &error_fatal); if (xen_enabled()) { + pci_device_set_intx_routing_notifier( + pci_dev, piix_intx_routing_notifier_xen); + /* * Xen supports additional interrupt routes from the PCI devices to * the IOAPIC: the four pins of each PCI device on the bus are also diff --git a/hw/isa/piix.c b/hw/isa/piix.c index ac04781f46..d4cdb3dadb 100644 --- a/hw/isa/piix.c +++ b/hw/isa/piix.c @@ -125,26 +125,6 @@ static void piix_write_config(PCIDevice *dev, uint32_t address, uint32_t val, } } -static void piix3_write_config_xen(PCIDevice *dev, - uint32_t address, uint32_t val, int len) -{ - int i; - - /* Scan for updates to PCI link routes (0x60-0x63). */ - for (i = 0; i < len; i++) { - uint8_t v = (val >> (8 * i)) & 0xff; - if (v & 0x80) { - v = 0; - } - v &= 0xf; - if (((address + i) >= PIIX_PIRQCA) && ((address + i) <= PIIX_PIRQCD)) { - xen_set_pci_link_route(address + i - PIIX_PIRQCA, v); - } - } - - piix_write_config(dev, address, val, len); -} - static void piix_reset(DeviceState *dev) { PIIXState *d = PIIX_PCI_DEVICE(dev); @@ -490,7 +470,7 @@ static void piix3_xen_class_init(ObjectClass *klass, void *data) DeviceClass *dc = DEVICE_CLASS(klass); PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); - k->config_write = piix3_write_config_xen; + k->config_write = piix_write_config; k->realize = piix3_realize; /* 82371SB PIIX3 PCI-to-ISA bridge (Step A1) */ k->device_id = PCI_DEVICE_ID_INTEL_82371SB_0; -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Wed Jan 04 14:45:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 14:45:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471207.730996 (Exim 4.92) (envelope-from ) id 1pD51G-00086j-Ki; Wed, 04 Jan 2023 14:45:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471207.730996; Wed, 04 Jan 2023 14:45:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD51G-000842-BR; Wed, 04 Jan 2023 14:45:30 +0000 Received: by outflank-mailman (input) for mailman id 471207; Wed, 04 Jan 2023 14:45:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD51E-00079b-O1 for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 14:45:28 +0000 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [2a00:1450:4864:20::42b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6dea74b4-8c3e-11ed-91b6-6bf2151ebd3b; Wed, 04 Jan 2023 15:45:28 +0100 (CET) Received: by mail-wr1-x42b.google.com with SMTP id az7so8799947wrb.5 for ; Wed, 04 Jan 2023 06:45:28 -0800 (PST) Received: from osoxes.fritz.box (p200300faaf0bb2009c4947838afc41b6.dip0.t-ipconnect.de. [2003:fa:af0b:b200:9c49:4783:8afc:41b6]) by smtp.gmail.com with ESMTPSA id e10-20020a5d594a000000b0028663fc8f4csm21168241wri.30.2023.01.04.06.45.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Jan 2023 06:45:27 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6dea74b4-8c3e-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZTbz96Fg6rdZNkQF03buq3nvArFrt1X2bnXBL/QETy8=; b=W9Un76kfIXX71algBT3MUyLCUiN80OFK1EUd0YbCe6wUItAP0Luda8qEceYXzOUdFw jY1QLBi8eG0gW8dCgOjygcJ+fp4QbyzP8Ye4eARwBnC9y0DkgijILW6lYwfh0Jwvet2r 4qrOldpBtix87pTunJpR5Hzs+5mBOue2wekAGVrS5ABa97Ub9oHHVlIjCdGw8E/QrMWt uF7+vwGjO6ufN4oR16pm29afZxpgs19LCt554cFbOcBl4NTLEdn0+fh7sb0bkFYX/Qy3 /7j2qYCvOrtcFrstpMIW3NJQlCJzKvvJDPW6GJrhHDp8NV6E0rozu/tgN7PiVc9LxJ4d rJkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZTbz96Fg6rdZNkQF03buq3nvArFrt1X2bnXBL/QETy8=; b=hAnboLlHOS5i/VMcaI6yf68aOHJr0usBmCb06vuVRan5avil1+ldzlNf8eXIMIQg+l 4Deg6DYtiB0rLKw+6ctJXTWNvG0swLwt9S+h5CDOWnUZAwhVLSOpkz1zE5Z5n/0LIKdT lzpyzrvy0KBG2YW2cZ2s+BT+VA9AYOqK1IoIveKkec3kCjekl+/A2pMs9DOyCwa/QLS0 39aPNGn9Y7tpc8wO2jYD/0pVxmUoQKSSL1q+vuuDHquid8MnmNF3Z7+UOUBqvg434CiL Ao4jFao6FGw75Z/bM95D0vaEkZCvrImVlrhT6CulONXKUOxrfID+8HcsSwlOdKfY0hiw R6qA== X-Gm-Message-State: AFqh2krX0egy/g06wqU8ZS7NXEYaDE4gG1YDueJEapnq8Uqu3VUz+/+W N3Oef5fU7Ea3x6GYH+kWGl4= X-Google-Smtp-Source: AMrXdXuqwFIIXGumdoGoKi2S2o1kZi2sGwiXEGMwUaQU6kBeT44weD6z/UJouVJiTGdquTAHfyXG3g== X-Received: by 2002:a5d:640c:0:b0:2a3:1c13:2888 with SMTP id z12-20020a5d640c000000b002a31c132888mr2471851wru.60.1672843527498; Wed, 04 Jan 2023 06:45:27 -0800 (PST) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: Richard Henderson , Stefano Stabellini , xen-devel@lists.xenproject.org, =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Aurelien Jarno , Paul Durrant , Marcel Apfelbaum , Anthony Perard , "Michael S. Tsirkin" , Paolo Bonzini , Eduardo Habkost , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Chuck Zmudzinski , Bernhard Beschow Subject: [PATCH v2 5/6] hw/isa/piix: Resolve redundant k->config_write assignments Date: Wed, 4 Jan 2023 15:44:36 +0100 Message-Id: <20230104144437.27479-6-shentey@gmail.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230104144437.27479-1-shentey@gmail.com> References: <20230104144437.27479-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The previous patch unified handling of piix_write_config() accross all PIIX device models which allows for assigning k->config_write once in the base class. Signed-off-by: Bernhard Beschow --- hw/isa/piix.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/isa/piix.c b/hw/isa/piix.c index d4cdb3dadb..98e9b12661 100644 --- a/hw/isa/piix.c +++ b/hw/isa/piix.c @@ -396,6 +396,7 @@ static void pci_piix_class_init(ObjectClass *klass, void *data) PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); AcpiDevAmlIfClass *adevc = ACPI_DEV_AML_IF_CLASS(klass); + k->config_write = piix_write_config; dc->reset = piix_reset; dc->desc = "ISA bridge"; dc->hotpluggable = false; @@ -451,7 +452,6 @@ static void piix3_class_init(ObjectClass *klass, void *data) DeviceClass *dc = DEVICE_CLASS(klass); PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); - k->config_write = piix_write_config; k->realize = piix3_realize; /* 82371SB PIIX3 PCI-to-ISA bridge (Step A1) */ k->device_id = PCI_DEVICE_ID_INTEL_82371SB_0; @@ -470,7 +470,6 @@ static void piix3_xen_class_init(ObjectClass *klass, void *data) DeviceClass *dc = DEVICE_CLASS(klass); PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); - k->config_write = piix_write_config; k->realize = piix3_realize; /* 82371SB PIIX3 PCI-to-ISA bridge (Step A1) */ k->device_id = PCI_DEVICE_ID_INTEL_82371SB_0; @@ -519,7 +518,6 @@ static void piix4_class_init(ObjectClass *klass, void *data) DeviceClass *dc = DEVICE_CLASS(klass); PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); - k->config_write = piix_write_config; k->realize = piix4_realize; k->device_id = PCI_DEVICE_ID_INTEL_82371AB_0; dc->vmsd = &vmstate_piix4; -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Wed Jan 04 14:45:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 14:45:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471208.731016 (Exim 4.92) (envelope-from ) id 1pD51J-0000NY-AF; Wed, 04 Jan 2023 14:45:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471208.731016; Wed, 04 Jan 2023 14:45:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD51J-0000NJ-5i; Wed, 04 Jan 2023 14:45:33 +0000 Received: by outflank-mailman (input) for mailman id 471208; Wed, 04 Jan 2023 14:45:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD51H-00079V-HU for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 14:45:31 +0000 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [2a00:1450:4864:20::335]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6ede4b6e-8c3e-11ed-b8d0-410ff93cb8f0; Wed, 04 Jan 2023 15:45:29 +0100 (CET) Received: by mail-wm1-x335.google.com with SMTP id m3so16838999wmq.0 for ; Wed, 04 Jan 2023 06:45:29 -0800 (PST) Received: from osoxes.fritz.box (p200300faaf0bb2009c4947838afc41b6.dip0.t-ipconnect.de. [2003:fa:af0b:b200:9c49:4783:8afc:41b6]) by smtp.gmail.com with ESMTPSA id e10-20020a5d594a000000b0028663fc8f4csm21168241wri.30.2023.01.04.06.45.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Jan 2023 06:45:28 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6ede4b6e-8c3e-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=E4FebSrd6qw4EtXuaelySJNjsiB1Oj70YbVnrwvN8/I=; b=lMKvYCGOWYmnaT84GaMb23/VAi195oDQudE1wLzcerQEkKvvtsHLGjOSg3Wp4GFafE XEtBgvv3xHIUWKKXmH1Ae9427VzyfEBA7cUKnYZSZvXPXSBefmryW+xa2Iv6VyKgWZfs r85U50UOY19i1THGPSpmLtkLrbogJ7ind85Uxcyqly4kLwW+iIYVU0SFYWcvUyE/B88b LnK2tJgHA8CffJ4VpAQZujNkJQGRaVtif+jOh2hKIW0Htmy+z0Ns9XHX5CwsqjO/ECtm 2O5VciXS7zNEcI+bZMOyLKHtdkcj+Ej/CLxWUUVLE1r7h5cOkCZL6K1xhBFqGNEijOdc pK5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E4FebSrd6qw4EtXuaelySJNjsiB1Oj70YbVnrwvN8/I=; b=VubhW56+2sC0a3puKqULFdv9Gkm+LnINfZRaYDMOi0Xf36oRRGzZ5oxbP5vOFaIKPz K5VZMTTvKUMw/UjLrT/dzw9ezOfiiF7BsE+7YbRxtzgrb4kZdxcf2Ep8w2LLae++qCb2 mAzA3tXm6WPI4uhfFDnLwlG9gOb2RK9QueK0+n3Zh+8t707IuA08cZZpWwRC1uz7fOqz MlRocXKzkaYepwoZOWA8Ea2jgIU1dXQSDZGPeG0zBDvyyO1JnP6ctzXs1sAtOqZ+HakC AQPbFW9yItVag7P6D7x1rHyTn29FflavWIgAtahJ6jB6Z8alHwXZSqttBrVjajR0D8TQ RonA== X-Gm-Message-State: AFqh2koIjQC6wfGpSqX8+uTIVeEI+t/aMYT0VvHWpPVWkBg1AVxapUcD zGS8z2ua3K/2ATz1s7DXO/Y= X-Google-Smtp-Source: AMrXdXsYGgxoZWnwVZ7yR7arNry46fXICAla5+IdicOq5hbJrnHe2MpsGju5mZBACJ42RwflZH2L8w== X-Received: by 2002:a05:600c:54cb:b0:3cf:d0be:1231 with SMTP id iw11-20020a05600c54cb00b003cfd0be1231mr41547624wmb.13.1672843529178; Wed, 04 Jan 2023 06:45:29 -0800 (PST) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: Richard Henderson , Stefano Stabellini , xen-devel@lists.xenproject.org, =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Aurelien Jarno , Paul Durrant , Marcel Apfelbaum , Anthony Perard , "Michael S. Tsirkin" , Paolo Bonzini , Eduardo Habkost , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Chuck Zmudzinski , Bernhard Beschow Subject: [PATCH v2 6/6] hw/isa/piix: Resolve redundant TYPE_PIIX3_XEN_DEVICE Date: Wed, 4 Jan 2023 15:44:37 +0100 Message-Id: <20230104144437.27479-7-shentey@gmail.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230104144437.27479-1-shentey@gmail.com> References: <20230104144437.27479-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit During the last patches, TYPE_PIIX3_XEN_DEVICE turned into a clone of TYPE_PIIX3_DEVICE. Remove this redundancy. Signed-off-by: Bernhard Beschow --- hw/i386/pc_piix.c | 4 +--- hw/isa/piix.c | 20 -------------------- include/hw/southbridge/piix.h | 1 - 3 files changed, 1 insertion(+), 24 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 5738d9cdca..6b8de3d59d 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -235,8 +235,6 @@ static void pc_init1(MachineState *machine, if (pcmc->pci_enabled) { DeviceState *dev; PCIDevice *pci_dev; - const char *type = xen_enabled() ? TYPE_PIIX3_XEN_DEVICE - : TYPE_PIIX3_DEVICE; int i; pci_bus = i440fx_init(pci_type, @@ -250,7 +248,7 @@ static void pc_init1(MachineState *machine, : pci_slot_get_pirq); pcms->bus = pci_bus; - pci_dev = pci_new_multifunction(-1, true, type); + pci_dev = pci_new_multifunction(-1, true, TYPE_PIIX3_DEVICE); object_property_set_bool(OBJECT(pci_dev), "has-usb", machine_usb(machine), &error_abort); object_property_set_bool(OBJECT(pci_dev), "has-acpi", diff --git a/hw/isa/piix.c b/hw/isa/piix.c index 98e9b12661..e4587352c9 100644 --- a/hw/isa/piix.c +++ b/hw/isa/piix.c @@ -33,7 +33,6 @@ #include "hw/qdev-properties.h" #include "hw/ide/piix.h" #include "hw/isa/isa.h" -#include "hw/xen/xen.h" #include "sysemu/runstate.h" #include "migration/vmstate.h" #include "hw/acpi/acpi_aml_interface.h" @@ -465,24 +464,6 @@ static const TypeInfo piix3_info = { .class_init = piix3_class_init, }; -static void piix3_xen_class_init(ObjectClass *klass, void *data) -{ - DeviceClass *dc = DEVICE_CLASS(klass); - PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); - - k->realize = piix3_realize; - /* 82371SB PIIX3 PCI-to-ISA bridge (Step A1) */ - k->device_id = PCI_DEVICE_ID_INTEL_82371SB_0; - dc->vmsd = &vmstate_piix3; -} - -static const TypeInfo piix3_xen_info = { - .name = TYPE_PIIX3_XEN_DEVICE, - .parent = TYPE_PIIX_PCI_DEVICE, - .instance_init = piix3_init, - .class_init = piix3_xen_class_init, -}; - static void piix4_realize(PCIDevice *dev, Error **errp) { ERRP_GUARD(); @@ -534,7 +515,6 @@ static void piix3_register_types(void) { type_register_static(&piix_pci_type_info); type_register_static(&piix3_info); - type_register_static(&piix3_xen_info); type_register_static(&piix4_info); } diff --git a/include/hw/southbridge/piix.h b/include/hw/southbridge/piix.h index 65ad8569da..b1fc94a742 100644 --- a/include/hw/southbridge/piix.h +++ b/include/hw/southbridge/piix.h @@ -77,7 +77,6 @@ struct PIIXState { OBJECT_DECLARE_SIMPLE_TYPE(PIIXState, PIIX_PCI_DEVICE) #define TYPE_PIIX3_DEVICE "PIIX3" -#define TYPE_PIIX3_XEN_DEVICE "PIIX3-xen" #define TYPE_PIIX4_PCI_DEVICE "piix4-isa" #endif -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Wed Jan 04 15:17:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 15:17:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471253.731027 (Exim 4.92) (envelope-from ) id 1pD5Vr-0005cv-Qw; Wed, 04 Jan 2023 15:17:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471253.731027; Wed, 04 Jan 2023 15:17:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD5Vr-0005co-O8; Wed, 04 Jan 2023 15:17:07 +0000 Received: by outflank-mailman (input) for mailman id 471253; Wed, 04 Jan 2023 15:17:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD5Vp-0005ci-Pg for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 15:17:05 +0000 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [2a00:1450:4864:20::433]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d7979cd7-8c42-11ed-b8d0-410ff93cb8f0; Wed, 04 Jan 2023 16:17:03 +0100 (CET) Received: by mail-wr1-x433.google.com with SMTP id d17so13568528wrs.2 for ; Wed, 04 Jan 2023 07:17:03 -0800 (PST) Received: from [192.168.30.216] ([81.0.6.76]) by smtp.gmail.com with ESMTPSA id b16-20020adfee90000000b002a1dd8ff75fsm3038540wro.62.2023.01.04.07.17.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Jan 2023 07:17:01 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d7979cd7-8c42-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CeQL5xWC173b6TUlkncPiMJP/Eoy8yXUJGOkp8pSziE=; b=J5vToNBwZNPE6isC6rzDCQasdXVM5QQ6ViaudBztq9BY1UjSa7dqNQ4YtwVCTbIlM4 VcFAiu42pOHnylu6h+Is6Sj4pPaGI2bDWbOdTgS29Hl0K7x09j1lk4l3FoJskBIVbjQy XR8I/KX+RNmSq9VDy6LX2bf5BJq4bIg8zUvtZMdjiJSL6yZa/YyfRW5ito3x+6nZpwTE swVNnHjOf+0BvmS6nLhRt9rPID6FeaoBnmfqsafX90aGSYTBKdJZO0bWoLLm+/f9yzID XB1vwczUCLW8KqQvCyAyboPhmSTxI7uiqJ7R6+kg309LuHLEexw+/tWuQR05HG87CQwu ebCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CeQL5xWC173b6TUlkncPiMJP/Eoy8yXUJGOkp8pSziE=; b=rQm+OIE5MofYax/tSSnJlP/Vtk1bDx/680QLDyqPzpExeLXzqrNAmFVPFcEockeoKT mXfYlpFoPnTrSyu7ZYfzA3wUOuRjJvACbdkv3Yrzc5dKQoYueqkh7wb0YEX7Fdz4HtM9 El/bX/2QTD9vdyGoAjvg40K26EmZl2LTfsrmnEMM5ilT7it4ZvwVSzUR2JJdMKDvGTxy 7JjKs2AypC9rxOBaIusthAutckGiOi1gLDK1AIvWjY7oWTG8p8jGZfCnZKou9PlhSeO7 rxqk4nG0Fn6zCFElOkAaBRLwaEP28IlG8lltk1dAxSZNz5PRpDkQnQBJoqlbOnfg3bMK 4g8w== X-Gm-Message-State: AFqh2kq5TF6vzkQZA2rhvN/2ygCgthBbxMxwoY2PoL/R7NlQYqnzpFfJ tuRQwdoto3f0S1BStODyFnzbFQ== X-Google-Smtp-Source: AMrXdXvH2pOn3LWxDaYFR7QAs+zf153SI/Oyb1HLgOqiNzpUp5DYIJp/xLQE53lCu6Un1TZ3PMWlhw== X-Received: by 2002:a5d:52c1:0:b0:242:5d8e:6c35 with SMTP id r1-20020a5d52c1000000b002425d8e6c35mr29010302wrv.28.1672845422878; Wed, 04 Jan 2023 07:17:02 -0800 (PST) Message-ID: <5a1b4b87-e6eb-de5d-ae1f-b648b6a7fc58@linaro.org> Date: Wed, 4 Jan 2023 16:17:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 1/6] include/hw/xen/xen: Rename xen_piix3_set_irq() to xen_intx_set_irq() Content-Language: en-US To: Bernhard Beschow , qemu-devel@nongnu.org Cc: Richard Henderson , Stefano Stabellini , xen-devel@lists.xenproject.org, =?UTF-8?Q?Herv=c3=a9_Poussineau?= , Aurelien Jarno , Paul Durrant , Marcel Apfelbaum , Anthony Perard , "Michael S. Tsirkin" , Paolo Bonzini , Eduardo Habkost , Chuck Zmudzinski References: <20230104144437.27479-1-shentey@gmail.com> <20230104144437.27479-2-shentey@gmail.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20230104144437.27479-2-shentey@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 4/1/23 15:44, Bernhard Beschow wrote: > xen_piix3_set_irq() isn't PIIX specific: PIIX is a single PCI device > while xen_piix3_set_irq() maps multiple PCI devices to their respective > IRQs, which is board-specific. Rename xen_piix3_set_irq() to communicate > this. > > Also rename XEN_PIIX_NUM_PIRQS to XEN_IOAPIC_NUM_PIRQS since the Xen's > IOAPIC rather than PIIX has this many interrupt routes. > > Signed-off-by: Bernhard Beschow > --- > hw/i386/xen/xen-hvm.c | 2 +- > hw/isa/piix.c | 4 ++-- > include/hw/xen/xen.h | 2 +- > stubs/xen-hw-stub.c | 2 +- > 4 files changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Philippe Mathieu-Daudé From xen-devel-bounces@lists.xenproject.org Wed Jan 04 15:19:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 15:19:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471260.731038 (Exim 4.92) (envelope-from ) id 1pD5Xk-0006D2-5d; Wed, 04 Jan 2023 15:19:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471260.731038; Wed, 04 Jan 2023 15:19:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD5Xk-0006Cv-2P; Wed, 04 Jan 2023 15:19:04 +0000 Received: by outflank-mailman (input) for mailman id 471260; Wed, 04 Jan 2023 15:19:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD5Xj-0006Cp-8h for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 15:19:03 +0000 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [2a00:1450:4864:20::32e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1e7f6673-8c43-11ed-91b6-6bf2151ebd3b; Wed, 04 Jan 2023 16:19:02 +0100 (CET) Received: by mail-wm1-x32e.google.com with SMTP id p1-20020a05600c1d8100b003d8c9b191e0so26704581wms.4 for ; Wed, 04 Jan 2023 07:19:02 -0800 (PST) Received: from [192.168.30.216] ([81.0.6.76]) by smtp.gmail.com with ESMTPSA id 6-20020a05600c024600b003cfd0bd8c0asm44453781wmj.30.2023.01.04.07.19.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Jan 2023 07:19:01 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1e7f6673-8c43-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ppHjajXu00sfHG3gYewiMMYX9m68H41AIgp8I+UXRqY=; b=UC2d663kGMVSshGb3omgRSAw0Ledaea0D1mgz5XDzXkbSgMftbWdaODs4OZmZOZBoh FyMvchGQ+037Hv9r0gY2rD51/ne2FMsPDuiE3Zr9tDtd+GSwonagjkiT7goqZzl2Gh+U W4ctjpskbLJNK16iOyLNAxtSD8TykO7UWVx0+q05zFYM+chKLMn8WWzPXDTOREDFoFoX ai1PC9EBJ+Nyq85ZUfyieR+RVa63WqYZX6+4bmFIFPCpfBkXyscUWiRMXh36EpIKeSMd SKarwbnDmbMBH9wuFC0txM58BjgBz9sYihOWquggB5SiYOaAcSqkst3g2R31OfWxnwCT tISQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ppHjajXu00sfHG3gYewiMMYX9m68H41AIgp8I+UXRqY=; b=lEdKjYJOc7ks5opfm5A+glUuT2bZWlLgGwAi+Xr8z6Gnf8fFgeHVYTlMMthk9hW+mT 5p/Fg2h1bbhnirKy00MlO2wnx6hh5D5Q4tWuDQao2vYwgftW+htNtzT5PaOhZ5OOWBZe aKu6xhBhG12g67lWDMvIS9aUic6L2xQWswvXYusSdqxuqmj5X8XzuOcfp/Zv4ilXotje hn52WPPVdllQj0mqruwUdfYJICI2gLSWOp0QLd0Q5K/w66q9xsVPE2Z+JaRPjiqqwiaV pe2sAwl+8aZu0k6H+3RhMqa01jKWgMmgXhjAJSDzIuy0BZZA+Y12ofiDx7pZhUG7wfX0 dl4g== X-Gm-Message-State: AFqh2krWRvTaYyTjQU6Hr5W6dWhcme5YsV/dHW+3Jc9QYWn3uaRCGGbr Qdzh23zkMrdy86MqsajrSW8onw== X-Google-Smtp-Source: AMrXdXs4D+lia01lWxYpxoqiFcHhQKZtcCTZ221KZh9cuBly4YiKqjSpq4+CbaUrUFzi9gJI4l5cIg== X-Received: by 2002:a05:600c:3844:b0:3d3:4406:8a3a with SMTP id s4-20020a05600c384400b003d344068a3amr41590590wmr.30.1672845541824; Wed, 04 Jan 2023 07:19:01 -0800 (PST) Message-ID: <90e7dc87-e2a1-90ae-1002-6f98abe2224e@linaro.org> Date: Wed, 4 Jan 2023 16:18:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 3/6] hw/isa/piix: Wire up Xen PCI IRQ handling outside of PIIX3 Content-Language: en-US To: Bernhard Beschow , qemu-devel@nongnu.org Cc: Richard Henderson , Stefano Stabellini , xen-devel@lists.xenproject.org, =?UTF-8?Q?Herv=c3=a9_Poussineau?= , Aurelien Jarno , Paul Durrant , Marcel Apfelbaum , Anthony Perard , "Michael S. Tsirkin" , Paolo Bonzini , Eduardo Habkost , Chuck Zmudzinski References: <20230104144437.27479-1-shentey@gmail.com> <20230104144437.27479-4-shentey@gmail.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20230104144437.27479-4-shentey@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 4/1/23 15:44, Bernhard Beschow wrote: > xen_intx_set_irq() doesn't depend on PIIX state. In order to resolve > TYPE_PIIX3_XEN_DEVICE and in order to make Xen agnostic about the > precise south bridge being used, set up Xen's PCI IRQ handling of PIIX3 > in the board. > > Signed-off-by: Bernhard Beschow > --- > hw/i386/pc_piix.c | 12 ++++++++++++ > hw/isa/piix.c | 24 +----------------------- > 2 files changed, 13 insertions(+), 23 deletions(-) Reviewed-by: Philippe Mathieu-Daudé From xen-devel-bounces@lists.xenproject.org Wed Jan 04 15:19:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 15:19:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471263.731049 (Exim 4.92) (envelope-from ) id 1pD5Y4-0006dX-F5; Wed, 04 Jan 2023 15:19:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471263.731049; Wed, 04 Jan 2023 15:19:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD5Y4-0006dQ-B5; Wed, 04 Jan 2023 15:19:24 +0000 Received: by outflank-mailman (input) for mailman id 471263; Wed, 04 Jan 2023 15:19:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD5Y3-0006bu-Oi for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 15:19:23 +0000 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [2a00:1450:4864:20::333]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2a278203-8c43-11ed-b8d0-410ff93cb8f0; Wed, 04 Jan 2023 16:19:21 +0100 (CET) Received: by mail-wm1-x333.google.com with SMTP id ja17so25823465wmb.3 for ; Wed, 04 Jan 2023 07:19:21 -0800 (PST) Received: from [192.168.30.216] ([81.0.6.76]) by smtp.gmail.com with ESMTPSA id r9-20020a05600c35c900b003d6b71c0c92sm69512254wmq.45.2023.01.04.07.19.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Jan 2023 07:19:21 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2a278203-8c43-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kPTejbbi0VjrwZB3qm0I8/+jmgejs37VoikSC1jaUtQ=; b=AhDzPHiSag5hRqrsTQN2J0vuhBPs6nWR14Nx5/y7Eg0iKnIDoPZPGkD9b4OwiPoR9u wS9wgHnq7Ei4czHMLFTstFMhCH94/k12Ehtc4wRjzriD1k8WsGRQyUCzc9gTaImXQNhg qqwLwDiOkCUBdgQqahpfsNY3lfYZgilLFDbpu6SFuL6zxpz8oBVLVMJmVO5lg5HEE2Hi Ia9CuCDCBhGADcfj6+Qjr7uK7SoThYMhM1JnGu6XtSq0Bw/hj8L7MbItaxiQLEynibq4 koSFvychnjqJrUvLRBcE+yuFr4jJChIxAVVfzEg7fULMcQxwxiYsWLpaMam1a5HJWq0h A+Hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kPTejbbi0VjrwZB3qm0I8/+jmgejs37VoikSC1jaUtQ=; b=TFDJiTY4wth89+k86/hJLASTAgvNVw56P+wX+8ma5fPaX9tH+2XsJjPy9g667Qr5C4 +tIpnrGPg1yDgZxDn3wMYExNn0S2avpJTiMziIFWHPUFy8XgSmgPu+i6aU0FQMvYWDr1 HdB8MOpQQ0kF8/8iLWpqHH7Fx4gfOqcHkNe89VJbbHnkD8nYLHYJPr5U4YX7eumEDmYr ONtLfW4oBqjxnIBYEZjKH2ScuGQUXd1ivwegWqDhQY7NZkpWgn/DjcrKomtGC0qru22X qK3OmGhxAFCKBi7DMxE61JD1C5GE76yMSeWomITh7r8XWgxRPs6iF4+RIvKhukfSbRUq 5Uyg== X-Gm-Message-State: AFqh2krF8pxrTbO3mxcnoNAdPWP+CDVkzyK3tK5qMg1r+isG/AEseW81 XvseS2eeOiM8beTQ0716ABGbyg== X-Google-Smtp-Source: AMrXdXur2qtX7wLHbl0tKH2b2is4RZ/VKSr2T4aG8FJIBb61gSsVoK18AtRN6qbV2HSt2GDGU9Bh7A== X-Received: by 2002:a05:600c:4d25:b0:3d2:27ba:dde0 with SMTP id u37-20020a05600c4d2500b003d227badde0mr34776131wmp.33.1672845561368; Wed, 04 Jan 2023 07:19:21 -0800 (PST) Message-ID: <265c7231-31a0-09a5-2b39-57e0d610661f@linaro.org> Date: Wed, 4 Jan 2023 16:19:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 5/6] hw/isa/piix: Resolve redundant k->config_write assignments Content-Language: en-US To: Bernhard Beschow , qemu-devel@nongnu.org Cc: Richard Henderson , Stefano Stabellini , xen-devel@lists.xenproject.org, =?UTF-8?Q?Herv=c3=a9_Poussineau?= , Aurelien Jarno , Paul Durrant , Marcel Apfelbaum , Anthony Perard , "Michael S. Tsirkin" , Paolo Bonzini , Eduardo Habkost , Chuck Zmudzinski References: <20230104144437.27479-1-shentey@gmail.com> <20230104144437.27479-6-shentey@gmail.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20230104144437.27479-6-shentey@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 4/1/23 15:44, Bernhard Beschow wrote: > The previous patch unified handling of piix_write_config() accross all > PIIX device models which allows for assigning k->config_write once in the > base class. > > Signed-off-by: Bernhard Beschow > --- > hw/isa/piix.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Reviewed-by: Philippe Mathieu-Daudé From xen-devel-bounces@lists.xenproject.org Wed Jan 04 15:35:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 15:35:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471274.731060 (Exim 4.92) (envelope-from ) id 1pD5nn-0000hk-RW; Wed, 04 Jan 2023 15:35:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471274.731060; Wed, 04 Jan 2023 15:35:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD5nn-0000hd-Op; Wed, 04 Jan 2023 15:35:39 +0000 Received: by outflank-mailman (input) for mailman id 471274; Wed, 04 Jan 2023 15:35:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD5nm-0000hX-K4 for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 15:35:38 +0000 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [2a00:1450:4864:20::430]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6f69a975-8c45-11ed-91b6-6bf2151ebd3b; Wed, 04 Jan 2023 16:35:36 +0100 (CET) Received: by mail-wr1-x430.google.com with SMTP id d17so13632402wrs.2 for ; Wed, 04 Jan 2023 07:35:36 -0800 (PST) Received: from [192.168.30.216] ([81.0.6.76]) by smtp.gmail.com with ESMTPSA id bt15-20020a056000080f00b00297dcfdc90fsm9758428wrb.24.2023.01.04.07.35.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Jan 2023 07:35:36 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6f69a975-8c45-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qKfYp56DzEdln6bw+epRjXvgWK4+5r5Y+0Le7rGeP9o=; b=uUvu3TZZ6cU7XFsjBFeKFFSqBvz1X0ROcGMGdM4mLTlVoVeGwEz9o6k2bGbmQIg4om TzVOHY6Cc2lGZTwx1Jj931bRdVCLmTaRi4NoaiXpD5LbwGwC5p5EbIjsbQz/Fl5chbHt qwMRsbZtZebWs3sWytVS2FNwfYSGFEmenYR03MWPelgo93c5N9u/OtlHARpd+iCZPoxT HZ5YaVoZSL8s59ak8bCLBbh4Iq6DjtCsnsjdSBN7D015K8yzoJN7xivoNYasnE06Lgaj 9nJr7AZ1SEXoTAuMxBDbxJyCxj8CTZoJKcaS2AoX+xRNQ3SuZqcYI8rj691I/weGzwsL /Rmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qKfYp56DzEdln6bw+epRjXvgWK4+5r5Y+0Le7rGeP9o=; b=6GeLvfNmc+Yl+Y0EdLLWhCLf60sMuUjyAGn11iyVN4qqLd0de7MpU9L9eImxEd+1R1 PXaq2MOnN3dMNRT5fu8EFyXkaG6w/ZLPpVerY6etXoJGFlQ4X8neClvPvV9mN/3eDrnZ TeGqFdC7fZ4Ie7ZrF7I6s1EBTVrVVTcWMmTcFgSv3JnWbtjmrkPFxxxbfGgoUJodGj90 1HFciqGYd6cDxldYcHxHvKpOfPHdGh6Fx2EFZok/oDP8CNyu7eMDrCMulNTBQeyQpdNH PSbuhU3yJu8gtBMEpq05di6AlhJuSFqRs5k2GsN8aYoujv9FGS0RQB6nliAUnV7AG6JJ g0tg== X-Gm-Message-State: AFqh2ko7mARTSnNbNfS0x4iyGcXn63Vzo7KRJQAG4crVxQTPGXbW4Arq Jaiw1ptyngYKH4H6nQEbX7pEdA== X-Google-Smtp-Source: AMrXdXtY6RzOZmuFEL1JagfUdSvbatncLArmeYUWzIWeXgc02Qt4gc26aWsY4X0BGqOTYR424X5PZQ== X-Received: by 2002:adf:de8a:0:b0:266:3709:5ce3 with SMTP id w10-20020adfde8a000000b0026637095ce3mr28787116wrl.0.1672846536505; Wed, 04 Jan 2023 07:35:36 -0800 (PST) Message-ID: <1c2e0780-e5fb-1321-0d84-b0591db9fec7@linaro.org> Date: Wed, 4 Jan 2023 16:35:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 6/6] hw/isa/piix: Resolve redundant TYPE_PIIX3_XEN_DEVICE Content-Language: en-US To: Bernhard Beschow , qemu-devel@nongnu.org, Markus Armbruster Cc: Richard Henderson , Stefano Stabellini , xen-devel@lists.xenproject.org, =?UTF-8?Q?Herv=c3=a9_Poussineau?= , Aurelien Jarno , Paul Durrant , Marcel Apfelbaum , Anthony Perard , "Michael S. Tsirkin" , Paolo Bonzini , Eduardo Habkost , Chuck Zmudzinski , Thomas Huth References: <20230104144437.27479-1-shentey@gmail.com> <20230104144437.27479-7-shentey@gmail.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20230104144437.27479-7-shentey@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit +Markus/Thomas On 4/1/23 15:44, Bernhard Beschow wrote: > During the last patches, TYPE_PIIX3_XEN_DEVICE turned into a clone of > TYPE_PIIX3_DEVICE. Remove this redundancy. > > Signed-off-by: Bernhard Beschow > --- > hw/i386/pc_piix.c | 4 +--- > hw/isa/piix.c | 20 -------------------- > include/hw/southbridge/piix.h | 1 - > 3 files changed, 1 insertion(+), 24 deletions(-) > > diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c > index 5738d9cdca..6b8de3d59d 100644 > --- a/hw/i386/pc_piix.c > +++ b/hw/i386/pc_piix.c > @@ -235,8 +235,6 @@ static void pc_init1(MachineState *machine, > if (pcmc->pci_enabled) { > DeviceState *dev; > PCIDevice *pci_dev; > - const char *type = xen_enabled() ? TYPE_PIIX3_XEN_DEVICE > - : TYPE_PIIX3_DEVICE; > int i; > > pci_bus = i440fx_init(pci_type, > @@ -250,7 +248,7 @@ static void pc_init1(MachineState *machine, > : pci_slot_get_pirq); > pcms->bus = pci_bus; > > - pci_dev = pci_new_multifunction(-1, true, type); > + pci_dev = pci_new_multifunction(-1, true, TYPE_PIIX3_DEVICE); > object_property_set_bool(OBJECT(pci_dev), "has-usb", > machine_usb(machine), &error_abort); > object_property_set_bool(OBJECT(pci_dev), "has-acpi", > diff --git a/hw/isa/piix.c b/hw/isa/piix.c > index 98e9b12661..e4587352c9 100644 > --- a/hw/isa/piix.c > +++ b/hw/isa/piix.c > @@ -33,7 +33,6 @@ > #include "hw/qdev-properties.h" > #include "hw/ide/piix.h" > #include "hw/isa/isa.h" > -#include "hw/xen/xen.h" > #include "sysemu/runstate.h" > #include "migration/vmstate.h" > #include "hw/acpi/acpi_aml_interface.h" > @@ -465,24 +464,6 @@ static const TypeInfo piix3_info = { > .class_init = piix3_class_init, > }; > > -static void piix3_xen_class_init(ObjectClass *klass, void *data) > -{ > - DeviceClass *dc = DEVICE_CLASS(klass); > - PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); > - > - k->realize = piix3_realize; > - /* 82371SB PIIX3 PCI-to-ISA bridge (Step A1) */ > - k->device_id = PCI_DEVICE_ID_INTEL_82371SB_0; > - dc->vmsd = &vmstate_piix3; IIUC, since this device is user-creatable, we can't simply remove it without going thru the deprecation process. Alternatively we could add a type alias: -- >8 -- diff --git a/softmmu/qdev-monitor.c b/softmmu/qdev-monitor.c index 4b0ef65780..d94f7ea369 100644 --- a/softmmu/qdev-monitor.c +++ b/softmmu/qdev-monitor.c @@ -64,6 +64,7 @@ typedef struct QDevAlias QEMU_ARCH_LOONGARCH) #define QEMU_ARCH_VIRTIO_CCW (QEMU_ARCH_S390X) #define QEMU_ARCH_VIRTIO_MMIO (QEMU_ARCH_M68K) +#define QEMU_ARCH_XEN (QEMU_ARCH_ARM | QEMU_ARCH_I386) /* Please keep this table sorted by typename. */ static const QDevAlias qdev_alias_table[] = { @@ -111,6 +112,7 @@ static const QDevAlias qdev_alias_table[] = { { "virtio-tablet-device", "virtio-tablet", QEMU_ARCH_VIRTIO_MMIO }, { "virtio-tablet-ccw", "virtio-tablet", QEMU_ARCH_VIRTIO_CCW }, { "virtio-tablet-pci", "virtio-tablet", QEMU_ARCH_VIRTIO_PCI }, + { "PIIX3", "PIIX3-xen", QEMU_ARCH_XEN }, { } }; --- But I'm not sure due to this comment from commit ee46d8a503 (2011-12-22 15:24:20 -0600): 47) /* 48) * Aliases were a bad idea from the start. Let's keep them 49) * from spreading further. 50) */ Maybe using qdev_alias_table[] during device deprecation is acceptable? > -} > - > -static const TypeInfo piix3_xen_info = { > - .name = TYPE_PIIX3_XEN_DEVICE, > - .parent = TYPE_PIIX_PCI_DEVICE, > - .instance_init = piix3_init, > - .class_init = piix3_xen_class_init, > -}; > - > static void piix4_realize(PCIDevice *dev, Error **errp) > { > ERRP_GUARD(); > @@ -534,7 +515,6 @@ static void piix3_register_types(void) > { > type_register_static(&piix_pci_type_info); > type_register_static(&piix3_info); > - type_register_static(&piix3_xen_info); > type_register_static(&piix4_info); > } > > diff --git a/include/hw/southbridge/piix.h b/include/hw/southbridge/piix.h > index 65ad8569da..b1fc94a742 100644 > --- a/include/hw/southbridge/piix.h > +++ b/include/hw/southbridge/piix.h > @@ -77,7 +77,6 @@ struct PIIXState { > OBJECT_DECLARE_SIMPLE_TYPE(PIIXState, PIIX_PCI_DEVICE) > > #define TYPE_PIIX3_DEVICE "PIIX3" > -#define TYPE_PIIX3_XEN_DEVICE "PIIX3-xen" > #define TYPE_PIIX4_PCI_DEVICE "piix4-isa" > > #endif From xen-devel-bounces@lists.xenproject.org Wed Jan 04 15:45:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 15:45:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471282.731071 (Exim 4.92) (envelope-from ) id 1pD5wq-0002Eu-R6; Wed, 04 Jan 2023 15:45:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471282.731071; Wed, 04 Jan 2023 15:45:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD5wq-0002En-OK; Wed, 04 Jan 2023 15:45:00 +0000 Received: by outflank-mailman (input) for mailman id 471282; Wed, 04 Jan 2023 15:44:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD5wp-0002EU-B3 for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 15:44:59 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2040.outbound.protection.outlook.com [40.107.20.40]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bdd70812-8c46-11ed-91b6-6bf2151ebd3b; Wed, 04 Jan 2023 16:44:58 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8377.eurprd04.prod.outlook.com (2603:10a6:10:25c::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Wed, 4 Jan 2023 15:44:55 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5944.019; Wed, 4 Jan 2023 15:44:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bdd70812-8c46-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nu30EW1cGTSvrNgzZhfYOoggD+Q16sa+nRBET+DscSiBrlVEj7EaxbMowo72pZ1koFBhLX8FSup4UObLUdTOoPQH/eOJ0ko9dxE39yr4ZI5KnCQrWb+c4rajegqX/G7Ril+AKSFEnTkSq4kON3HVg++Z5aUdFDoV0ioe5sGmnknLlkwaTRqxVGLkpafs4Q6a+5F0yQaaqRIpl3q4kMhxxV/5k+0axfCWWRO0iFdO8v4bLcz9M8+f0C2QfHLc4yV4daR6dl7Bl6xhB7I7TAp/WQuXoq/8dNZ+vecBAmTleun0h3vxTkYZh+aIYIHfGmQRX2ljoIXZyWz12QwT/BFkUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ekUmmCLjTlbJSqa3zB70oJ7pL5kMKDCfK5iJNx+FSQY=; b=TgpaWhfQrk2wD0u43wvsOTE4hyOLx9Ndm7jDs60xO6lHUNnoZKlKXdSwNj873NF++P6m0ZbfyrW8jh4oj3NzX0Ob/Tj1HRExpvEz9EY6TEBm0N6yFczxKh3pO+gHyqXbTakMlxLWj799JGDtAdxKw3D2+bb2BGObq18bXBDE42mbmLD0UNCJ6VIn9VM6GakPWGJaQVExBblAQxkLYpCVWKtTIUocdA4Iyn8E1biMc/avmFEOFP7lVdDTuHLXGW8LacSjBxl061NLmyftiUV4atMfK/ZMI+ybKpG5YOzBnm8G0FPLtERldB0rR6eW4zPXhvX2WGwMW9kFjASehf9IJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ekUmmCLjTlbJSqa3zB70oJ7pL5kMKDCfK5iJNx+FSQY=; b=e+boEKtCGHJnMzoVsJ2p9qAvkmJLdEPKLyRYjEvkT+Uw/1VG6o8TqUjv8tjOXHIwkVfzMqDYHFW27mHjkRDEtmZBM7i98/K7lb8L7Sg5Q1j29FB3IKesZpHkOlNzuwRfn4x0pnTk99QyPGlIRYo75Ut3TORB2UTjFB9N6F5lg7KkNIHPDnu911gON3su+RzHOttfE0ya08F+0vv/zdgQjb5W4/Tq8zwg+kQxW5f8R3dBuPZrPSyN1AxIlde53xYpdYj1XggEisr2fzKJO8n+wNE6JSjUcJPbT1m8/j1KkzKfCpKqFhyobu8Ka8cpt+G+Zsp3PprxvZwAjjMSV4QYNA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 4 Jan 2023 16:44:54 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 2/2] x86/shskt: Disable CET-SS on parts susceptible to fractured updates Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230104111146.2094-1-andrew.cooper3@citrix.com> <20230104111146.2094-3-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20230104111146.2094-3-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0080.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8377:EE_ X-MS-Office365-Filtering-Correlation-Id: 691ad437-f119-46ae-78d4-08daee6aa093 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nUzd5OJUrLBZxc8nhI+DVNAs97ImunS1agOQyZ+e5V7VC/ypEfFJQIsokslFIuHOCZh8OKpZNChk6lRcqroO9ac2hzmF+9VxNQo1B+WDSijM4qTN+dKE7sYHSbyeSj/WioL7SZjYPl22pGw+Hi47r/CcKWIuceEOpdFXqyw0bfMIzOeoOKT+9bYNP2ZyJ4dl9oKfxXFKa1RE5OxTVoK0lnHPR3ml+MMw4TGMZ08U3zQHAZYt2e5y22zxxk0LXdsBC+pWNtY5lX21Mg/za5969inqwy0UwMjcPZD6NR6UYjIbG9tHuc1c6S5bEWWgcffMjK8qGkTD8+mVBsA5qCXiXBuKI2JOEB8tuYwOcg7/lD4IaMx8N2JtqIyCQp0LIOmlZqpv1UjIt1dCjYK6cEzjg7w21Vwmg04/9mZtfUFMqKF30mymcxKCrERp6eqXYTiSHQIlSDgZNEh5FLGVBazHahL/4tn0bAYzUSBA5Nyik+s4Uo0pTJ+jumIU+lD0iGAKAC6GfyiAJWsXfvVxCgj3jmf0r2a6P9q1FXuwytDuQClIFOi2c0eOUb/P0av8cD898WCTe3D4Np28hpxjVBgNsKoA4Q/N18e5WnmRb+UR11G95IpKsoDTBZEEZGW7ivwTgLbQbCuAWqsShcv/b9I6co6D+Bx5SwngYYALmpO1bEE99FT7sMv5obytfj0j0dHNGjIOqzpVGGCRszgAnKeHDghTza7T7QVT/lwQuoV1950= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(396003)(346002)(376002)(39860400002)(366004)(451199015)(83380400001)(5660300002)(8936002)(36756003)(6916009)(316002)(54906003)(8676002)(4326008)(66946007)(66556008)(66476007)(2616005)(15650500001)(2906002)(31686004)(66899015)(6506007)(86362001)(31696002)(6512007)(186003)(478600001)(6486002)(53546011)(26005)(38100700002)(41300700001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UXZaZEdxbDVUaHZDWm1WTjNvVFErOWFYbFBuRmpGK2FHZUtyZVZiMGdZcEhu?= =?utf-8?B?REFtVkd2NWxSU0JiSXRNb2RNVTEzSEZBUHpoTmVCZHJNT21qaHozUUNlMlZl?= =?utf-8?B?cHRJTFU5WEtVNWZjNTA1dFhFMlBEUkdMZnhheldWUzBPdnQ1NXJOaUdmQ3dn?= =?utf-8?B?NVhoWDlzck9rMmFwNlZzTnAxU2pETWhlakJ0dHVLV2lVdkdZaGNRRjFoZFRX?= =?utf-8?B?WWcxYWFDc3FWcWRBNTQ1eW5EOXp0TTJNRC9zSlFMSXpvWDNwNHdtWEVZNDZR?= =?utf-8?B?M3lab3MwdlB5UnFWVWU3NXhOVVNqY1NpUFBtakYzRHgrVm9QL0haTGIwOVB5?= =?utf-8?B?Z1d6aGJuSGFGd0VGSjVzQWhOVUV1NmVnYzBrTUEyQ3FyWFMrczFab3hWL0NT?= =?utf-8?B?RTFmb2xOUzIrSkJRMkhzWFRoUjNsY2FiK21JQ2JvRGs5UlZyVS9sUDZqRU8r?= =?utf-8?B?MlNQRitnT0NrbkN6MDM3dlB0TDVnM0x1amFsNDM5QkVGSFE4TkpzL0xka3lt?= =?utf-8?B?NUJvdndCb0VFakJzWnF3NWl6cmg2QS91WTZjZFJ3NjQ5akNJVnQ5eVNjK2h4?= =?utf-8?B?Q1pRSFdlaUxucjNVanIrQnN3Z3ZpQjE4UVBvMHBsTGRBTnZsMklpOEJkZ0F0?= =?utf-8?B?YituWWlRd2dBVTFGc083OXNXbHpndkJ5a0VzNkR5d3V2eU81bTNtZ3VTdUdq?= =?utf-8?B?b2FiTFY2NTFoQzRRVytrTG1OVXYvbkVGZmtsRm5oSVNsRStaNkpaVU5YRHhx?= =?utf-8?B?ZFRROEFzTVA2d3hrRWYwamdSTFl4VU1Rc0hPSHlHZGNJMWJXN1owZUtncWs2?= =?utf-8?B?NWlxdXUvUHIzWHRjYnVKWHE5V3ExMm1RRnUwTzZPa29XNE5KSmgrOXNrRm1J?= =?utf-8?B?QzdRRXpQdElJZDhucllydytZMm9veTQwak5zd3YwL1ZqK240OFRIeE9QcU1O?= =?utf-8?B?b2F0R1dEYlJ6L0IyakdIbW5DK0dmdld0QWVjRXp6OTkxWDZML25DS20vWTRY?= =?utf-8?B?dVEzNy9RdjJoMUNTSHl3d2xaVURaOU1nbXhDaWs4VlFES1RQZEFCZkd1dFVL?= =?utf-8?B?L1BUbmdSWVU3RjhXMFBZVUxNRjZUNy9wRFo1NG80ZFlBajBxUU1BT0lBWG8w?= =?utf-8?B?cFZOQTgxdldSRW9qSU1Ta2hwYmpiWXBWTVJDWjZOa0NsZVZ6bDQ5NkNIRjRN?= =?utf-8?B?NHdXSXZyWlBnM3pkMmFjc1pmOVRmZEZGTDlaMmJzRUhCKzNKOVZUeXFaVTRt?= =?utf-8?B?ME1QZGpkSlpxUDk2L2t4YlVvMzZ2Mmw3d2R3Q29tbEsxaURvQ3VrNmxFTURj?= =?utf-8?B?bFR5djdPWS9mZTRjT3NGYXJkK0RqeTVrT2pJY1FkOFVIMEx3Zm0zSkNvK2dQ?= =?utf-8?B?cUNMakRnbWI5MTVUSDgvelprWStWdFBiaTdaVS9DVnpNMlZFT0pVcHhveXVZ?= =?utf-8?B?YU4vek90b1NLRmg2bzZpQlU5WjdjVkI4d0hQVndjV0RyajhidVRiL1RTRk93?= =?utf-8?B?ZjJ3cEZRYWdnc1hKYVpmWXhDYkI2dDd6Syt1UmdFeld5ZXRUL0lEK2NYdGZp?= =?utf-8?B?dlUyRnNxUGRXSkRQWWR3dHVZdVI4bEx4b09jSXpuQk9pWVNUcyttNDhzY0dI?= =?utf-8?B?VGlHaC9CQjM4cHorOEZtRGFlNEFNbFI4RUJXaHduTUErazgvOHIxTCtjMlpD?= =?utf-8?B?RkYxNzhqajNnRXBXUEpKMXYwMC9ubnB1Z21iak9VZXFpbnphQkpWSnRpUERB?= =?utf-8?B?RU5WSmEreWFLTDRYcWl2bEhWMXBEbmwrdHNXVjFvRUsxZFp1TTRXY04vc3Zu?= =?utf-8?B?QWp6MSsvdVQ4MVVkd1FiYUNBUVY5UzAwK1NqT3NlbkhvbDFlZHNXOHJsR1ZM?= =?utf-8?B?YWVaNVg5WEFpalJDTWFOeUlyV2R1WS9oMnVIdmlyb0prTDBjSTdFeHB0Zzdy?= =?utf-8?B?SDBabnhxY1BVME8zWmhJUFNhaGRwTXYwRVhJbUlQQkY0OFRDUy9YZzd6Wnpo?= =?utf-8?B?R2RSK2IzZVBmQmsvblFHSURUN21FS0cyVXVsWDdrcmoxZy83SlRHNFJSSTRx?= =?utf-8?B?VnJscE9qR2hNQXNQWUgwNy9PU3hlNWJlbnhOVCtUY2s4b0JCR25La3p5MkhB?= =?utf-8?Q?g8Ejr9oLTJhWlqPscocAEom0a?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 691ad437-f119-46ae-78d4-08daee6aa093 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2023 15:44:55.5559 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OaPlvKH3LnzB24JRc8qlxECr4rB4TF48FA0D4g/7cxUerATsOIzw1uh5ho/AeCGzRbAmF2ppB3p/VAkWnkKBnw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8377 On 04.01.2023 12:11, Andrew Cooper wrote: > Refer to Intel SDM Rev 70 (Dec 2022), Vol3 17.2.3 "Supervisor Shadow Stack > Token". > > Architecturally, an event delivery which starts in CPL<3 and switches shadow > stack will first validate the Supervisor Shadow Stack Token (setting the busy > bit), then pushes CS/LIP/SSP. One example of this is an NMI interrupting Xen. > > Some CPUs suffer from an issue called fracturing, whereby a fault/vmexit/etc > between setting the busy bit and completing the event injection renders the > action non-restartable, because when it comes time to restart, the busy bit is > found to be already set. > > This is far more easily encountered under virt, yet it is not the fault of the > hypervisor, nor the fault of the guest kernel. The fault lies somewhere > between the architectural specification, and the uarch behaviour. > > Intel have allocated CPUID.7[1].ecx[18] CET_SSS to enumerate that supervisor > shadow stacks are safe to use. Because of how Xen lays out its shadow stacks, > fracturing is not expected to be a problem on native. IOW that's the "contained in an aligned 32-byte region" constraint which we meet, aiui. > Detect this case on boot and default to not using shstk if virtualised. > Specifying `cet=shstk` on the command line will override this heuristic and > enable shadow stacks irrespective. > > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich with one nit (below). > This ideally wants backporting to Xen 4.14. I have no idea how likely it is > to need to backport the prerequisite patch for new feature words, but we've > already had to do that once for security patches. OTOH, I have no idea how > easy it is to trigger in non-synthetic cases. Plus: How likely is it that Xen actually is used virtualized in production? For the moment I don't see any reason to backport to branches in security- only maintenance mode. I'm not even sure it needs backporting at all. > @@ -1099,11 +1095,45 @@ void __init noreturn __start_xen(unsigned long mbi_p) > early_cpu_init(); > > /* Choose shadow stack early, to set infrastructure up appropriately. */ > - if ( opt_xen_shstk && boot_cpu_has(X86_FEATURE_CET_SS) ) > + if ( !boot_cpu_has(X86_FEATURE_CET_SS) ) > + opt_xen_shstk = 0; > + > + if ( opt_xen_shstk ) > { > - printk("Enabling Supervisor Shadow Stacks\n"); > + /* > + * Some CPUs suffer from Shadow Stack Fracturing, an issue whereby a > + * fault/VMExit/etc between setting a Supervisor Busy bit and the > + * event delivery completing renders the operation non-restartable. > + * On restart, event delivery will find the Busy bit already set. > + * > + * This is a problem on bare metal, but outside of synthetic cases or > + * a very badly timed #MC, it's not believed to problem. It is a much Nit: "... to be a problem." Jan From xen-devel-bounces@lists.xenproject.org Wed Jan 04 16:12:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 16:12:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471289.731082 (Exim 4.92) (envelope-from ) id 1pD6NX-00061z-0S; Wed, 04 Jan 2023 16:12:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471289.731082; Wed, 04 Jan 2023 16:12:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD6NW-00061s-Ty; Wed, 04 Jan 2023 16:12:34 +0000 Received: by outflank-mailman (input) for mailman id 471289; Wed, 04 Jan 2023 16:12:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD6NW-00061k-JW for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 16:12:34 +0000 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [2a00:1450:4864:20::634]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9869fabb-8c4a-11ed-91b6-6bf2151ebd3b; Wed, 04 Jan 2023 17:12:33 +0100 (CET) Received: by mail-ej1-x634.google.com with SMTP id ud5so83878412ejc.4 for ; Wed, 04 Jan 2023 08:12:33 -0800 (PST) Received: from ?IPv6:::1? (p200300faaf0bb2008108eedf25879029.dip0.t-ipconnect.de. [2003:fa:af0b:b200:8108:eedf:2587:9029]) by smtp.gmail.com with ESMTPSA id lj2-20020a170906f9c200b007a4e02e32ffsm15454154ejb.60.2023.01.04.08.12.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Jan 2023 08:12:32 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9869fabb-8c4a-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=govlnVA/VYqvVYKVSZE+CubqtU9g2EyfrdDcVjmMz6Y=; b=hk0Ny9eqmlchaMtYq7vYJnD2Xmrs4Tdbt0M/fiPj9+Csj1z3CNL44oGwDKK7yRjdRv 1GdpucAx2w2stB9XA7MInVGx4tWEX53dQDzTKfVvI8RD94sYVc9V3XySjo5UpSkEklwC +CHaz0G97T/v2UggrwM4/Q/JJ/92B3hhQmSQNduXZ0astWp1XVfTMeWdTeDmV1hPxwf4 NqCdGLvOcxw5C16GR0why6KidTYpZEWceNhodGD75yk/jbINnVgg4DFew3nfk410nY0X 0exWpyG1wsR6uA9qu1lmrXlrntfKKHI87YrgZmVEyzgYnUF0kOEAWU0acaw4J/zZaj+n RyTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=govlnVA/VYqvVYKVSZE+CubqtU9g2EyfrdDcVjmMz6Y=; b=KBB0iShlqRZWDZGlsEFMHP9QGhGoSmI5/2+0c0UJaDtQ1K7E0Rwk6GKyVMzw3GTg6o XKenFBD9kfUNbkzaIN3MnMMrnmPdc0P+wT0AEQTr0WSCHsNmiE2iiUHWX0Evru3ikbeI KMx0BIRF5q9TlGIz+ihmAivtMo0cIOSgu5ky2h2wngdoF3pCkcwJrZg5or7YjwfYnRLo Ww5lNSsLJbnvZRlNPmxLpBIY3he4tZzRFh5FhFBuHiY5VqYj8O5+PVX6EMBVpsUqYHi+ ndMMvInhcukopKHF0ElCv4KRxj8R8YkDynLHh+3zBivqHj0l8OCaf8It2KsCAdwtbOkw uXJQ== X-Gm-Message-State: AFqh2kp9vVjqKQ6YooqwnEooM1Cs9ukJdFqHM1AyMZg96sOyk5z/nT3W hS4niovAl3hDtD8U9OUrKRg= X-Google-Smtp-Source: AMrXdXtr3CdYAVbyb1GO2YeoRc3JJBajOiJ++PsT7D527I82IhxNk6hCymLzpQxg4HAA+IfNwMnr1Q== X-Received: by 2002:a17:907:b684:b0:7c0:a99c:485c with SMTP id vm4-20020a170907b68400b007c0a99c485cmr45324433ejc.68.1672848752666; Wed, 04 Jan 2023 08:12:32 -0800 (PST) Date: Wed, 04 Jan 2023 16:12:27 +0000 From: Bernhard Beschow To: Chuck Zmudzinski , =?ISO-8859-1?Q?Philippe_Mathieu-Daud=E9?= CC: qemu-devel@nongnu.org, Paul Durrant , Marcel Apfelbaum , "Michael S. Tsirkin" , Stefano Stabellini , Anthony Perard , Aurelien Jarno , Eduardo Habkost , xen-devel@lists.xenproject.org, =?ISO-8859-1?Q?Herv=E9_Poussineau?= , Paolo Bonzini , Richard Henderson Subject: Re: [PATCH 0/6] Resolve TYPE_PIIX3_XEN_DEVICE In-Reply-To: <00094755-ca61-372d-0bcf-540fe2798f5c@aol.com> References: <20230102213504.14646-1-shentey@gmail.com> <0de699a7-98b8-e320-da4d-678d0f594213@linaro.org> <00094755-ca61-372d-0bcf-540fe2798f5c@aol.com> Message-ID: <7E657325-705A-47EA-A334-0B59DF0DF772@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Am 4=2E Januar 2023 13:11:16 UTC schrieb Chuck Zmudzinski : >On 1/4/2023 7:13 AM, Bernhard Beschow wrote: >> Am 4=2E Januar 2023 08:18:59 UTC schrieb Chuck Zmudzinski : >> >On 1/3/2023 8:38 AM, Bernhard Beschow wrote: >> >> >> >> >> >> On Tue, Jan 3, 2023 at 2:17 PM Philippe Mathieu-Daud=C3=A9 wrote: >> >> >> >> Hi Chuck, >> >> >> >> On 3/1/23 04:15, Chuck Zmudzinski wrote: >> >> > On 1/2/23 4:34=E2=80=AFPM, Bernhard Beschow wrote: >> >> >> This series first renders TYPE_PIIX3_XEN_DEVICE redundant and= finally removes >> >> >> it=2E The motivation is to 1/ decouple PIIX from Xen and 2/ t= o make Xen in the PC >> >> >> machine agnostic to the precise southbridge being used=2E 2/ = will become >> >> >> particularily interesting once PIIX4 becomes usable in the PC= machine, avoiding >> >> >> the "Frankenstein" use of PIIX4_ACPI in PIIX3=2E >> >> >> >> >> >> Testing done: >> >> >> None, because I don't know how to conduct this properly :( >> >> >> >> >> >> Based-on: <20221221170003=2E2929-1-shentey@gmail=2Ecom> >> >> >>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "[PATCH v4 00/30] Co= nsolidate PIIX south bridges" >> >> >> >> This series is based on a previous series: >> >> https://lore=2Ekernel=2Eorg/qemu-devel/20221221170003=2E2929-1-s= hentey@gmail=2Ecom/ >> >> (which itself also is)=2E >> >> >> >> >> Bernhard Beschow (6): >> >> >>=C2=A0 =C2=A0 include/hw/xen/xen: Make xen_piix3_set_irq() gen= eric and rename it >> >> >>=C2=A0 =C2=A0 hw/isa/piix: Reuse piix3_realize() in piix3_xen_= realize() >> >> >>=C2=A0 =C2=A0 hw/isa/piix: Wire up Xen PCI IRQ handling outsid= e of PIIX3 >> >> >>=C2=A0 =C2=A0 hw/isa/piix: Avoid Xen-specific variant of piix_= write_config() >> >> >>=C2=A0 =C2=A0 hw/isa/piix: Resolve redundant k->config_write a= ssignments >> >> >>=C2=A0 =C2=A0 hw/isa/piix: Resolve redundant TYPE_PIIX3_XEN_DE= VICE >> >> >> >> >> >>=C2=A0 =C2=A0hw/i386/pc_piix=2Ec=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0| 34 ++++++++++++++++-- >> >> >>=C2=A0 =C2=A0hw/i386/xen/xen-hvm=2Ec=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0|=C2=A0 9 +++-- >> >> >>=C2=A0 =C2=A0hw/isa/piix=2Ec=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0| 66 +---------------------------------- >> >> > >> >> > This file does not exist on the Qemu master branch=2E >> >> > But hw/isa/piix3=2Ec and hw/isa/piix4=2Ec do exist=2E >> >> > >> >> > I tried renaming it from piix=2Ec to piix3=2Ec in the patch, b= ut >> >> > the patch set still does not apply cleanly on my tree=2E >> >> > >> >> > Is this patch set re-based against something other than >> >> > the current master Qemu branch? >> >> > >> >> > I have a system that is suitable for testing this patch set, b= ut >> >> > I need guidance on how to apply it to the Qemu source tree=2E >> >> >> >> You can ask Bernhard to publish a branch with the full work, >> >> >> >> >> >> Hi Chuck, >> >> >> >> =2E=2E=2E or just visit https://patchew=2Eorg/QEMU/20230102213504=2E= 14646-1-shentey@gmail=2Ecom/ =2E There you'll find a git tag with a complet= e history and all instructions! >> >> >> >> Thanks for giving my series a test ride! >> >> >> >> Best regards, >> >> Bernhard >> >> >> >> or apply each series locally=2E I use the b4 tool for that: >> >> https://b4=2Edocs=2Ekernel=2Eorg/en/latest/installing=2Ehtml >> >> >> >> i=2Ee=2E: >> >> >> >> $ git checkout -b shentey_work >> >> $ b4 am 20221120150550=2E63059-1-shentey@gmail=2Ecom >> >> $ git am >> >> =2E/v2_20221120_shentey_decouple_intx_to_lnkx_routing_from_south= _bridges=2Embx >> >> $ b4 am 20221221170003=2E2929-1-shentey@gmail=2Ecom >> >> $ git am >> >> =2E/v4_20221221_shentey_this_series_consolidates_the_implementat= ions_of_the_piix3_and_piix4_south=2Embx >> >> $ b4 am 20230102213504=2E14646-1-shentey@gmail=2Ecom >> >> $ git am =2E/20230102_shentey_resolve_type_piix3_xen_device=2Emb= x >> >> >> >> Now the branch 'shentey_work' contains all the patches and you c= an test=2E >> >> >> >> Regards, >> >> >> >> Phil=2E >> >> >> > >> >Hi Phil and Bernard, >> > >> >I tried applying these 3 patch series on top of the current qemu >> >master branch=2E >> > >> >Unfortunately, I saw a regression, so I can't give a tested-by tag yet= =2E >> >> Hi Chuck, >> >> Thanks for your valuable test report! I think the culprit may be commit= https://lists=2Enongnu=2Eorg/archive/html/qemu-devel/2023-01/msg00102=2Eht= ml where now 128 PIRQs are considered rather than four=2E I'll revisit my s= eries and will prepare a v2 in the next days=2E I think there is no need fo= r further testing v1=2E >> >> Thanks, >> Bernhard > >Hi Bernhard, > >Thanks for letting me know I do not need to test v1 further=2E I agree th= e >symptoms are that it is an IRQ problem - it looks like IRQs associated wi= th >the emulated usb tablet device are not making it to the guest with the >patched v1 piix device on xen=2E All PCI IRQs were routed to PCI slot 0=2E This should be fixed in v2 now= =2E >I will be looking for your v2 in coming days and try it out also! Thank you! Here it is: https://patchew=2Eorg/QEMU/20230104144437=2E27479-1= -shentey@gmail=2Ecom/ Best regards, Bernhard > >Best regards, > >Chuck > >> >> > >> >Here are the details of the testing I did so far: >> > >> >Xen only needs one target, the i386-softmmu target which creates >> >the qemu-system-i386 binary that Xen uses for its device model=2E >> >That target compiled and linked with no problems with these 3 >> >patch series applied on top of qemu master=2E I didn't try building >> >any other targets=2E >> > >> >My tests used the xenfv machine type with the xen platform >> >pci device, which is ordinarily called a xen hvm guest with xen >> >paravirtualized network and block device drivers=2E It is based on the >> >i440fx machine type and so emulates piix3=2E I tested the xen >> >hvm guests with two different configurations as described below=2E >> > >> >I tested both Linux and Windows guests, with mixed results=2E With the >> >current Qemu master (commit 222059a0fccf4 without the 3 patch >> >series applied), all tested guest configurations work normally for bot= h >> >Linux and Windows guests=2E >> > >> >With these 3 patch series applied on top of the qemu master branch, >> >which tries to consolidate piix3 and piix4 and resolve the xen piix3 >> >device that my guests use, I unfortunately got a regression=2E >> > >> >The regression occurred with a configuration that uses the qemu >> >bochs stdvga graphics device with a vnc display, and the qemu >> >usb-tablet device to emulate the mouse and keyboard=2E After applying >> >the 3 patch series, the emulated mouse is not working at all for Linux >> >guests=2E It works for Windows guests, but the mouse pointer in the >> >guest does not follow the mouse pointer in the vnc window as closely >> >as it does without the 3 patch series=2E So this is the bad news of a >> >regression introduced somewhere in these 3 patch series=2E >> > >> >The good news is that by using guests in a configuration that does >> >not use the qemu usb-tablet device or the bochs stdvga device but >> >instead uses a real passed through usb3 controller with a real usb >> >mouse and a real usb keyboard connected, and also the real sound >> >card and vga device passed through and a 1920x1080 HDMI monitor, >> >there is no regression introduced by the 3 patch series and both Linux >> >and Windows guests in that configuration work perfectly=2E >> > >> >My next test will be to test Bernhard's published git tag without >> >trying to merge the 3 patch series into master and see if that also >> >has the regression=2E I also will double check that I didn't make >> >any mistakes in merging the 3 patch series by creating the shentey_wor= k >> >branch with b4 and git as Phil described and compare that to my >> >working tree=2E >> > >> >I also will try testing only the first series, then the first series a= nd the >> >second series, to try to determine in which of the 3 series the regres= sion >> >is introduced=2E >> > >> >Best regards, >> > >> >Chuck > From xen-devel-bounces@lists.xenproject.org Wed Jan 04 16:29:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 16:29:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471296.731092 (Exim 4.92) (envelope-from ) id 1pD6dZ-0007bG-Cu; Wed, 04 Jan 2023 16:29:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471296.731092; Wed, 04 Jan 2023 16:29:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD6dZ-0007b9-A7; Wed, 04 Jan 2023 16:29:09 +0000 Received: by outflank-mailman (input) for mailman id 471296; Wed, 04 Jan 2023 16:29:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD6dX-0007b3-Vz for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 16:29:07 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2044.outbound.protection.outlook.com [40.107.20.44]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e87ed6b7-8c4c-11ed-91b6-6bf2151ebd3b; Wed, 04 Jan 2023 17:29:06 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS1PR04MB9584.eurprd04.prod.outlook.com (2603:10a6:20b:473::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Wed, 4 Jan 2023 16:29:04 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5944.019; Wed, 4 Jan 2023 16:29:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e87ed6b7-8c4c-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fDU9paoNdYFVwZ1CnLYr0VfEHjf1dyc+ZhZuQz6YVhuATmGywPvoDXES9uE7/9ia/ZlJ07R5rEqbHFde+KGsd69miJfntoWSH4r6VG18Ov3h/7EEHep0vsDR8wvy/yj/SudVv6cUkMdwb9Nx3k8MqRH/W8ByD8u4yxs3WAvLLlZTwQeCBmrfZDwuM0e/R5YejWPEqbDI+Cgl519Z3FWAmuDtwG8bUxxDmqKCKEaTo64/gS9c5tBFdyTtfpHAG+bwduGROwIwMNhltdQYGPMUmYrSoKJ9enBZsgDl3iIvnxJvneLL1vPIJ5r2uR8COyTthh2C0gL+coujE31LCWfBuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YYIvdnzux6f8D6z+9d1KjGqws6fClpdUIa/CmQotqho=; b=T3o1oHLJ/LK9zDofWyQ5+/bZHked8AB+j9NzXSFsz0lEEO1e9UUoI4xXPRg4oSwSanHOfy/oS2VnE91gqOnqN1tiylKg27BS7RH+yPyWtqdBgK6pLFnpkiaC4XELT7HFPd8doaTGsv8OYm30lM35CzFUmK77X1j8aMSd1PZbpFsB0JBclDFIxvJh+4/kLao7jTnqBs4/bGV0DE3cjNM9i1QJWemj1k5MmQWSNvGgA7Je5XyByOpMKvv9E7Bo9tsUiN4sLDxswWCeFUx8DwSu/SrQIA3WTK7njQW4NWQdcK2DuL3QfzzXt2ckqcO2fC01jGWLBmMmTpNINCRMUwx99A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YYIvdnzux6f8D6z+9d1KjGqws6fClpdUIa/CmQotqho=; b=bAQBfQfM81T/jgqtFtm0lm0fOXjhmIPJisCn3eMAx27sYIm5pot/F00BDEyH0jtY6BchOow3p3Rl/90Fv0xhovJgAkXPY/JGit0Rqh4e8fS/qBOO8KJrDDzU0pjMRjQHgrIMZWKEXQcreFrn+BDbvMhFr9YpYz6rnrBLetXTcPB5soITIWxowUIAU3TTQJ/bU93FcLhLl3BQlFubCf5yE4ki8aBaoFOwsj40KnKE64ycnjcsGTgazw/E7W+dHhNYTgFDiLQ8EfHke6H/CPXNq2CTQRs0Xe4m+kFq8ofDbn3zU5JXX1VIr0kkA34jwOBH5ikrFEuyQFJLOYwTvsbAbQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <074042f5-ecc1-11c9-bdcd-b9d619475d58@suse.com> Date: Wed, 4 Jan 2023 17:29:02 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 2/4] xen/version: Drop compat/kernel.c Content-Language: en-US To: Andrew Cooper Cc: George Dunlap , Stefano Stabellini , Wei Liu , Julien Grall , Xen-devel References: <20230103200943.5801-1-andrew.cooper3@citrix.com> <20230103200943.5801-3-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20230103200943.5801-3-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0136.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9e::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS1PR04MB9584:EE_ X-MS-Office365-Filtering-Correlation-Id: 5b379f1a-b868-4afe-3e69-08daee70cb11 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8fwNwtfOnFpeg+cvUu0La0O64US0YEfij3D760+CsAIuzu0orLcT4r2LCps9j6VXSeXyoXoOBTxqYY5WbI1lSOnmxbA8046p+toYlKYD57nXc2L+3WALWwuzsMrUxk97aP2oeSDjvXh7MIsp8xXDzVpW3n3N1o705vOYLG36MkaB0Eve+hNibl3DExO6G0N10Bfc5IU0nViH7wRPQUWiRmNuFA/foc9gDpk6uEvr5pWiDMEdN/hfn2hpL49bHwMKBMXlQUpB7HIwQVigidjZ9G3V0ftOj2CHBFXIPSkRCNbPOpztMvBU8jfXDt5Pt1Vu1+ZyhgMMEXu9o8Bjk1ARvfxBiC9DQ/ArTV7kCVKF2O3XYAVTfIGafivUPei69ams9vwkMU6RRXt+L3Q6l4ycMvDxZePYLDqSwG+Zn/gi9IcLo+kHAuqCQR8QG/kYRlW9SY9Vvkbu5ctZlZzRiK6JuF/roZrlba0MeGPEEABX1+Rbfyft9l2Bj0Ss0oD19y1MaenWLpi1tyI32J7ZkKyGBhdRTcSs2k5TPKGtafUjcxMP9MQuRg6ooAHr/XEC+LApCf4nxYZdM8toCwD8emw/fwn7ox/sOEmDh6Lp5qPqZ7v8FqjNtgB7BbXU3lOmfP4dxPieTIBXAiGLRTZyaK4fHYPUVKVxoeLAfqM4sHfPRVCn8BqFGzvYqXKqSY4mLaMVRC0ajgWncMZ/utNEggPGumeJpVMO2S6FKDLxpyl2OEg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(376002)(396003)(136003)(346002)(366004)(451199015)(36756003)(6916009)(54906003)(53546011)(316002)(478600001)(31696002)(86362001)(6486002)(5660300002)(2906002)(66556008)(66946007)(4326008)(66476007)(8936002)(8676002)(41300700001)(38100700002)(6512007)(6506007)(26005)(186003)(2616005)(83380400001)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WUgxUHFJdmtGTXR4MTlsVFlub3Z6TmtMRjZPMDQxOEpjZTY4QlhMbjJqSDRB?= =?utf-8?B?b1hXUzN1WnVVZWYzTFVWTHF6Mk1oNG85emZqVlpHanNKSVhwSjdUakVZSTJu?= =?utf-8?B?NzRpMlgyaVJ5V29XWThmcnpMNC9ZVUNUK0xBTXVwbXlvS25lYklqendveXls?= =?utf-8?B?bWpsekZmOHBnWmk0OFJ1MUtKbG5vazY3ZGp6aWtSMm5rNHdReGZWdGI2Sjhy?= =?utf-8?B?S2IxaHRFMHBKMU9qTVh4YXdGY096RmVpV25JWUJReGZUNkZzdS91QTlRUSt2?= =?utf-8?B?cys0L0RRUVFRbSsxSVNRbVFGWFZKdTdLT0hEUGJ1eGxzWjhXaXNqWDQ5Zi9G?= =?utf-8?B?VHUwQitYVTdEcXhvbXVna0JVdWlJRkZOaXNKK3ZmNGRzT3JJTy9vS0drZFF3?= =?utf-8?B?V1lGQjVUdHY5c3M5c2hrbmw0Z0krZm5yTUdrSGMzVlRTYUpCaGtjR09ZZk9V?= =?utf-8?B?WkkrTFJQVi9XRmRIRUZDVnJabGZrNlhmZHQ2U29hR0RnMnF3WnM5M2hVTXQ4?= =?utf-8?B?N09XcUorano5SDIrck1IZHNkM05IbnR2b2xzZGdDd1pjWm9sUVpkQWFCaFZu?= =?utf-8?B?NGVMenpsRnBKK1VDK1ZEMEw4RlpIK0ZKcmQ1cVBENFZNelV5ams1b2NFb0tu?= =?utf-8?B?eXBuSzJ3bGhRcmJyb3ByWGY1ZjUrYnVRbU95WVhtdzB2ZFY0QXZyOWhtdk5u?= =?utf-8?B?SnAyVXZsM2N6WHZSRCtBVVhvNUVBTW1ZZWZlSS9xZlhHRWI1eGNYWUNHZ1o0?= =?utf-8?B?YlNJWFAxcjR1eThBUHIrYzhqSVpVYjJuMlhzMGlhV1MzZDc0cEtGdjQzZ2RC?= =?utf-8?B?TGt0ekxDQTBaZmFUOVZIbFpJVlRnbGp5cFZTQWIxVkV2NUVjbnV1WnhsTUNY?= =?utf-8?B?Y2ZNeUZJNVVSbTcyODNaWHJaNUlYNSt3V0VBWFZyRlY4Z2U1b3pjUUdVaDdm?= =?utf-8?B?dElETHJwV3hQWmhDRy90TUg4azZVSG9zZU9SaDZSQUhvVCtJMWRrNkM2N0c2?= =?utf-8?B?VkF6bi9TSFpXaUMzYVlXYW9MNmVnUlRoRWFwVVlCSk1CVWlma2NqUzhEa0hm?= =?utf-8?B?OEFWRy9OZGM3M3hOTkNtVXFSaERRbEFTazhNY1NHdE1UcFZYVUxKMkJCQWdv?= =?utf-8?B?R2YzelFpbTNzclY4WGNnOXdtdXFxM1Z6Q2NuSk5LaE50R2M5aUowSnVxd3pr?= =?utf-8?B?NW5DZXRGUllkWFUvU0kxMmVBaVlzQUsrVnk1dTY3cmNROTdsbVVKb21hcHg0?= =?utf-8?B?a3BVNGs2ZEYxMThsaDhuSFFvZUcvZDhpeXp3NUN5OExtNkkwK3k3d2VoYnpx?= =?utf-8?B?SU94ZXFWb2FZeEN2MnM0QldtT2pXOVdQMm1LQzdqeDlZRXA4dWZleEhEbmxi?= =?utf-8?B?cjVUTG5GNGhRM3lNTGFjcXNOWXZhR2MvUlJ0NU8zWi8zUEpDL3JxZkdDTDQx?= =?utf-8?B?eVBBUlM5QjJwNnFVVnlEYkNDM0FrWUpzTUtzRU1uNjhrWGRIeEVzS0JvWGtP?= =?utf-8?B?QmhyUURZaVhzTC9uTncwQTZHMXdxZ0s5TXA2Skl1bDNjaUFRWkJIZ2lZVlFC?= =?utf-8?B?VlQ3NkUvdVloWUVMcHBWYXFaejlLcjdmV2hJVVRRUDZOUTlMWDFzNmo5d3BL?= =?utf-8?B?Y3FHU0tscUlFaHl5K0hCNnRZakprV3lpMmFWakRLa2h2REE2emlncVFkYXBh?= =?utf-8?B?ZmZIVWpOYVJ1aGNzc2YwdGlXNTVFbEU0Rkx3WFJSWnZXUjZuYUpaSm1zM2g3?= =?utf-8?B?c3g1VkdIbjV5WXI4T1YzbU54UlJvZlA1c1VoTnVQOFNnL2hJc2lFU01HTkpG?= =?utf-8?B?VmV3a2ZqL0VCanRWdFNMRHdzWDZDY2oxb3JhbVBXSWJUYm1ldmt3SVQ1eCt6?= =?utf-8?B?VlIyRXZ5UStWT3lFR2IyY1AzVnpqSDg0K1BjNmttejVYTjJYSDFjYWJYYzN1?= =?utf-8?B?Ky9ZZENnNUdkb2JDbFFwbEJadFN1VVEwY0swU1NBQit0SkJ6Vnp1VHVQU25G?= =?utf-8?B?TlVucFk5T0NINjRvdUlJNG8vazVsM2lXMkFKYlBUSGEwOWhRaWxYWWx2MVls?= =?utf-8?B?OGZSZGNtMm9KOE9XSmxDSFF0Y2V3V1NIVml3MFVnaSszbVdyMzJRb3NoS2lw?= =?utf-8?Q?4G3nlEN6aMIb9wgBAdBPs3EzI?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5b379f1a-b868-4afe-3e69-08daee70cb11 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2023 16:29:03.8405 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UHbYP3SdX5R7wWmqtaiLWfvIN0izWZIlCA/LBsNqhBg7DegTbALWNt3WGBjYrALsok+iB0qxI1ZWy289miWERg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9584 On 03.01.2023 21:09, Andrew Cooper wrote: > kernel.c is mostly in an #ifndef COMPAT guard, because compat/kernel.c > reincludes kernel.c to recompile xen_version() in a compat form. > > However, the xen_version hypercall is almost guest-ABI-agnostic; only > XENVER_platform_parameters has a compat split. Handle this locally, and do > away with the reinclude entirely. And we henceforth mean to not introduce any interface structures here which would require translation (or we're willing to accept the clutter of handling those "locally" as well). Fine with me, just wanting to mention it. > --- a/xen/common/compat/kernel.c > +++ /dev/null > @@ -1,53 +0,0 @@ > -/****************************************************************************** > - * kernel.c > - */ > - > -EMIT_FILE; > - > -#include > -#include > -#include > -#include > -#include > -#include > -#include > -#include > -#include > - > -extern xen_commandline_t saved_cmdline; > - > -#define xen_extraversion compat_extraversion > -#define xen_extraversion_t compat_extraversion_t > - > -#define xen_compile_info compat_compile_info > -#define xen_compile_info_t compat_compile_info_t > - > -CHECK_TYPE(capabilities_info); This and ... > -#define xen_platform_parameters compat_platform_parameters > -#define xen_platform_parameters_t compat_platform_parameters_t > -#undef HYPERVISOR_VIRT_START > -#define HYPERVISOR_VIRT_START HYPERVISOR_COMPAT_VIRT_START(current->domain) > - > -#define xen_changeset_info compat_changeset_info > -#define xen_changeset_info_t compat_changeset_info_t > - > -#define xen_feature_info compat_feature_info > -#define xen_feature_info_t compat_feature_info_t > - > -CHECK_TYPE(domain_handle); ... this go away without any replacement. Considering they're both char[], that's probably fine, but could do with mentioning in the description. > @@ -520,12 +518,27 @@ DO(xen_version)(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg) > > case XENVER_platform_parameters: > { > - xen_platform_parameters_t params = { > - .virt_start = HYPERVISOR_VIRT_START > - }; With this gone the oddly (but intentionally) placed braces can then also go away. Preferably with these minor adjustments Reviewed-by: Jan Beulich Jan From xen-devel-bounces@lists.xenproject.org Wed Jan 04 16:33:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 16:33:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471304.731104 (Exim 4.92) (envelope-from ) id 1pD6hI-0000dN-2Q; Wed, 04 Jan 2023 16:33:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471304.731104; Wed, 04 Jan 2023 16:33:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD6hH-0000dG-VD; Wed, 04 Jan 2023 16:32:59 +0000 Received: by outflank-mailman (input) for mailman id 471304; Wed, 04 Jan 2023 16:32:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD6hH-0000d6-02; Wed, 04 Jan 2023 16:32:59 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD6hG-0002np-Tp; Wed, 04 Jan 2023 16:32:58 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD6hG-0001Lf-Ds; Wed, 04 Jan 2023 16:32:58 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pD6hG-0004vB-DN; Wed, 04 Jan 2023 16:32:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Xdhn2w1Vm6E81nwFY01aJgpMOgccQAofxCo5KepJfMs=; b=do9ObP8ZZ/qUojlYyMjoJhHf/c xf5JsNV8xfOE9nrfbZKeDppwiKlcdxFDz44hVCGrCZK+A4k1zOxlVq8CEGS5/NB9dQ4divPDF17RY XBV9fF6NiJTwCqRpT6otA755hRt8d429h1wjCNFZ9ZBWCDyoCz1Kysk997McqJ7vx710=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 175566: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=69b41ac87e4a664de78a395ff97166f0b2943210 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Wed, 04 Jan 2023 16:32:58 +0000 flight 175566 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/175566/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine 8 reboot fail REGR. vs. 173462 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux 69b41ac87e4a664de78a395ff97166f0b2943210 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 88 days Failing since 173470 2022-10-08 06:21:34 Z 88 days 184 attempts Testing same since 175552 2023-01-02 21:13:23 Z 1 days 5 attempts ------------------------------------------------------------ 3257 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 497265 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Jan 04 16:36:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 16:36:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471313.731115 (Exim 4.92) (envelope-from ) id 1pD6kB-0001DJ-HO; Wed, 04 Jan 2023 16:35:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471313.731115; Wed, 04 Jan 2023 16:35:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD6kB-0001DC-E4; Wed, 04 Jan 2023 16:35:59 +0000 Received: by outflank-mailman (input) for mailman id 471313; Wed, 04 Jan 2023 16:35:57 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD6k9-0001D2-J2; Wed, 04 Jan 2023 16:35:57 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD6k9-0002qj-IA; Wed, 04 Jan 2023 16:35:57 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD6k9-0001Pw-31; Wed, 04 Jan 2023 16:35:57 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pD6k9-0007OX-2Z; Wed, 04 Jan 2023 16:35:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=PrWdftEX9qT2U+aAUgfYWxi7bcWV/5I2f//PX7X6zpE=; b=YDC7TCFAm+DX4oJt4kVZYq0Pla EmbeMe1J1RuzhuLTVtbwIBpHNz3mNK1x0jh8VHjhB012ws2AB0g9Qfa18021ZrZJN938dU5GxyFzg 67I0jdAEAS1QcPWJNVDVT0hb4a6JSqPdj/IJbkmcZIy6fVaXmK45pu+PsxfaWMGk7KGU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 175568: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=c1df06afe578f698ebe91a1e3817463b9d165123 X-Osstest-Versions-That: xen=7eef80e06ed2282bbcec3619d860c6aacb0515d8 From: osstest service owner Date: Wed, 04 Jan 2023 16:35:57 +0000 flight 175568 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/175568/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen c1df06afe578f698ebe91a1e3817463b9d165123 baseline version: xen 7eef80e06ed2282bbcec3619d860c6aacb0515d8 Last test of basis 175516 2022-12-28 19:00:28 Z 6 days Testing same since 175568 2023-01-04 14:00:26 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 7eef80e06e..c1df06afe5 c1df06afe578f698ebe91a1e3817463b9d165123 -> smoke From xen-devel-bounces@lists.xenproject.org Wed Jan 04 16:40:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 16:40:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471322.731126 (Exim 4.92) (envelope-from ) id 1pD6oe-0002eV-3m; Wed, 04 Jan 2023 16:40:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471322.731126; Wed, 04 Jan 2023 16:40:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD6oe-0002eO-0M; Wed, 04 Jan 2023 16:40:36 +0000 Received: by outflank-mailman (input) for mailman id 471322; Wed, 04 Jan 2023 16:40:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD6oc-0002eI-91 for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 16:40:34 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2081.outbound.protection.outlook.com [40.107.21.81]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 80205dd2-8c4e-11ed-b8d0-410ff93cb8f0; Wed, 04 Jan 2023 17:40:31 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU0PR04MB9276.eurprd04.prod.outlook.com (2603:10a6:10:357::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Wed, 4 Jan 2023 16:40:25 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5944.019; Wed, 4 Jan 2023 16:40:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 80205dd2-8c4e-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WbS+078ChGzJD9HY8Atp8m+3h4fMzx/IBArexLeGwSiT9RKtdrhdLTsGaOkbkjwkR9Vr6CBF4uRNnLKnHYgCWfF9Tcf6eRyeKpcdg8X96yKDNA+W+pGfmceQfVpYy8jTbZLkKnGNXKS/Zn3WaUQz4Ln2t7c29totqTFlZxNn3w+wcRjGCRsjepsQbeoQ1QclaB6Eb2RnKPh8K8Hec2OXhPQrHtfoG3rJMByxNyZybG4lS42FUUiD+5ED908VZ7AbzLwi/jLRHQENWKutr4dk4c9YiYddDj3fKXZX3FYKJ6MyEgnixTOy9hVW/TKqueakIaFl13Bk9soaEe3khq0GoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8tbsBPvURDFJUYLUmdtEznWOuWGi2HvZk8KWkzCBso8=; b=m8jhjXYThJHIWQ/6JWfhYofPvDT5sDEBbSbQvB459zjHg+W+psov+1cntd42j2Om2Z3UzUXe1Wj2SEQOwLKsNWiTK2uluTd4piz7kj+HsFz7Y5Xzrvt6bBgiYBSTSOgh85zjGnYqu4qFTIckMlEN4SBZeS+SaEfg1p/VzW/LuWZxmunM+VqFhIjih0CEiYJh69ECfRR11Ebf8K1wYvOme8L4MyrRXR7LlreNtUfE3/lTUwhweU/FzwsNG6ZxA8iGzi/h+auu5KimrCRM54WJXxZOZBeS2tYlaX6lTcXegSuZvdGka0ncIz0c+ksANKMyMD5E1bVZSjKNtLWBFdmYGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8tbsBPvURDFJUYLUmdtEznWOuWGi2HvZk8KWkzCBso8=; b=nq5bovy61x9fgha32KEREBG3yELEVDwjWbAm3/4yKDU3s/2QJAF9K3R9VWJfnUUUAjyC7HLXJ5AKNemRRcjrWhwYMWV8Yxj7hGQVgmCUbO53uBQUrYLBveoQcz84W5qjy3DmWCnsLNg1uS4iuIO/FjlMxG9bH1P7tb1XQjVk7Mxy1TujrpTfT7d2NJsxEqZJ/yd7VdJKBFOViCpCg0sHAgvjhk9UWBiI3sSx67DGJlWlGnmkK9ega7VpNcr19111KMFYWOH7iAbN3+m0t6/Vs+oedl6VGLg7Lt7xmQNgBdo9BrKcISLXXvgDwYRgn4CZetL7JGreeGM0WEQrhZCi/g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <540a449d-f76d-eb16-4f98-c4fb3564ce98@suse.com> Date: Wed, 4 Jan 2023 17:40:23 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 3/4] xen/version: Drop bogus return values for XENVER_platform_parameters Content-Language: en-US To: Andrew Cooper Cc: George Dunlap , Stefano Stabellini , Wei Liu , Julien Grall , Xen-devel References: <20230103200943.5801-1-andrew.cooper3@citrix.com> <20230103200943.5801-4-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20230103200943.5801-4-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FRYP281CA0009.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU0PR04MB9276:EE_ X-MS-Office365-Filtering-Correlation-Id: a1583721-fa72-41db-f6b3-08daee72616e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IkFOcWrpdQZ0jBKljvo8ge51neTRuvFh4rdMveWjAXaH+Nl0z7AAj9/DzZFiTtskRye3wLYTsXFDN/8eiaoOZnjKBxYeG1TYsp1vchJf1QeK6rbUt+eEKTl7+ZadvAoynsTHNzh54dv8uEKWJO8DAesvj3tdLI6WUSI836du4S5JwZHeKpo1TmuqU7OKo7BFvh5LcDFoPXQtrxa8i3T+zPRuw14ztkxy2n2JUPOH7Nogb/C/CON4A4xTwkL3K7wvbiL3QR8J0Oz8pumfrDuOjLcIcD5sT3Do5tQbIfXBOG82CrhONyWQGywhZTlQ7+6aeuldqGPLHFaBPBXGeIIwjsCj4D7L1DHNR0aR1GUwkT1BkYUOQE58sTzESZv1evw07RGTQ5aTqBlV48i3M1lerHFOlyvK9Z2ftDLNFrRM0F6aklHSa0IAuoHbgvIIlhkzPAY94eD1QaQ4OmjuAHgr1ER1A7NILEFBV1fwATAir4iS7EN/AfWBoBXndW2ptXD+qWjufTU2HW2VvKVheyI3Dd8csT9TmJzx8CdP5kOp+xKaW/cdv2/pLMM4f/lF3PBAFDMghpeLyq3Ba5sk6En6UDe6pjCJUenTSs/fJKx7rG4dFB37g2RAfPhExftDPomwqwP4eqAH2IPYiToCUSVshp+hT8KIwnH075EmTvyZ9c5a0tlM/5iTCzLF4f/p7MXGcUB6pxXxSPz3KA/gX6dmBx/Uo1HL+eXJ2qqjvoLPI8g= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(136003)(39860400002)(396003)(376002)(346002)(451199015)(31686004)(36756003)(4326008)(8676002)(66556008)(66946007)(66476007)(8936002)(5660300002)(2906002)(38100700002)(86362001)(31696002)(478600001)(316002)(54906003)(6916009)(6486002)(2616005)(41300700001)(53546011)(6512007)(26005)(186003)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y0t2ak9TR2ZpU25ybWNVRmIrVDAxeVA1cHU3SHFPdmttZUx1N1hVdCt3cCtj?= =?utf-8?B?T1hQa2JSZHRhdzhhdGxoZVFoTlhaelVpWlhCUHllWUc5QUdPK1hvc3VvYWw4?= =?utf-8?B?OXlIdHNORXdPOGRnamNHek9YbW4wWGhiUXE1bEc5NWJPaGRQblhVT1JFYWZK?= =?utf-8?B?SnFRZ0o3cm5tN3JDMDdRTnBZSDlTMVVHTmJvT2Q0c25XY2szd2tvWS83a3FF?= =?utf-8?B?RDRsYmdsbFVPVTNuTGpFMC9SSWtDSXVtYWhPNXBmSnlBR1JmdkNRUmplMnJy?= =?utf-8?B?ZmJCNHlmbmhzRmxsTXpKWmpnSGRNU1o2VERYd2JtdzNIUW9xcVNpVVlWVnRK?= =?utf-8?B?VThOWDZPckJYc3dWMkdDZW9kdkxZV095NUJ0NmtxYnRGRy9KaFUzQXMrT0kv?= =?utf-8?B?NUt1bFUwem1ZT1hRQi9XcVArdUVqZDV2VFQzc2NTUittbWxaREZmSVErZDFW?= =?utf-8?B?cmRWd1pZK0JQdG1SQ0RzU2dUUW40VGJ0OGVNV1FhWGpobTc1MWkyQlBuQXpl?= =?utf-8?B?bXp5Vlo5SEN1b0tiUTRGVGE2Q25pVUNuaG9VUk5RcUhFd1l4MlNIazlXSlRT?= =?utf-8?B?Q3lJV2Q2ajI2bklkZWFMcDViaGFOMzIzVk50dGJlaFdsMWhWOTNqL3RCWGtn?= =?utf-8?B?Tys0Ymh4a0dsVy8zWlZibjJIc1dSUW1uYXZsNlVnSjNZRGIxai9FSXJJRjJF?= =?utf-8?B?aEZiQk80akFuQ0pIc1ZiM0lQazJVdTNOVmlpZko4TFlxdUUyZkxTNTZvQlR1?= =?utf-8?B?R2wyeTNpRFQ2K1VhOU5FTk9nSU9mYXlUZUNVR3UvdDM3RFdOU09zcG0yakg3?= =?utf-8?B?ZGUyN3RvVFVzV05GMTJNdmtVRnpQWHJnb01WSkFuRWhwUVA4bmRmbS9ReDBH?= =?utf-8?B?c0p3VHpVNHVlT3hBaEI5ZVdScG1UbkcrTHBQTXNLSExXd2Y0SWtndEx6M0d2?= =?utf-8?B?QUxjNWFFVzFwMlVGTmhlVEpnUnNMenRvSXhNRVY1QXJxNjRJRDNHRm1IZkhn?= =?utf-8?B?Y1VrWlQySjg1MDZJNlNldm80V2NFYUpiVGtEOHpsQlFjVHdjWjZHc05YdFlt?= =?utf-8?B?bVQvZ3p2SGZCbStFWDZBL3AzZk9CVzhBajNQbFRWeEF3MFdzdmVDZUZvY21h?= =?utf-8?B?WW9IOTFwbU5wSENLWnBnTU5LTzRGNkFsQk03RGF6eXUrNmZ3RDF3bmFLdHFO?= =?utf-8?B?SVZZa2pBOStIek8vdlpGNWJlaWFJQlgvaXIxS1djaGZCaVR6Lyt3RlF6Y1hZ?= =?utf-8?B?c0JlVkJ1N2xkZzF4UlFXaFBtaTNGeDdOR0VRSVFnYi9RRm1qSUNYTitudEpZ?= =?utf-8?B?Z2dZRGdWSTk3L25UQ2N5Q1FPMTdnQlp2RGFObzhkclRFaDJDOVBPSFlEK3pm?= =?utf-8?B?SGFaNDhiKzVQMW53WGM0RlpDOEZZT08vWWw3SlZyS3ZwM2RuTnFNSUIwNXJ6?= =?utf-8?B?c2FicE1aQ3Myekl0d1MwQStlQWhNWVc5L0x5dWp3Rk5zRXRkZXlEQ1QwMmdw?= =?utf-8?B?bW5BbzlCVTNJVnhjU081TEpFUTgzYWFmWUV0RWdsOHFZNFp5TXUxZDdaQjVs?= =?utf-8?B?VXlkdXN2SUtKRUxjNWk0aTUvdU0reXNVMHZlVkRtbTFONEZUeWY5U3pzRVVl?= =?utf-8?B?a3NYSitPYXBEa0luTUM5dnhwaThrRHo3SnZ2VXh3UTN2ZzZoNWRwQUVwSDQw?= =?utf-8?B?OUloQTdVbERVQ1hxemdBMTZYMGNqLzhGY3Z4ZFk0K25oK0gzaEZ0V1Z1RnZE?= =?utf-8?B?dWswTHhDODYwSWZGNjVWcEJKczdDREE1NE94ZWlEZVZMNGloZTk0b0wxTFRX?= =?utf-8?B?YjkvZElLVExCQk02SjQ3WXFIbzg1aVoyTVByZWVoT2xCbmM4bG15aE9qeWxB?= =?utf-8?B?UGdYYTBEOVZSTVFSNytFd09WTmZCTjQ0Y3lhWmdDbHVndDdZZy93b1EwSTdR?= =?utf-8?B?cGoyM0lZQmFuNlBvMUhTRytjOEtMcUZlNXFGTkRzbEszK3pmNVo1TTZzeElI?= =?utf-8?B?UWRqTW1jb2hCalBnN2RUbENsaHlPd1duVFpvam9tWkZyc2QyTlY0VHk1NUtx?= =?utf-8?B?SlZBRlFLbVJOQ2dCMFR5SWxuelNiSkVOdVpmcjNMQXdZek9jdHNWRU5NWmFa?= =?utf-8?Q?3g6emGOQvN+76XKEWyK5nUOty?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a1583721-fa72-41db-f6b3-08daee72616e X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2023 16:40:25.5784 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZVJ1jqjeYhj2j+7eV+yygH6TWdEzF3LMr8stwGj7e6AFfVE0Zj/M3DqDcSvPuxjhd1vwX9LJ6z7UcH94Yf18sA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9276 On 03.01.2023 21:09, Andrew Cooper wrote: > A split in virtual address space is only applicable for x86 PV guests. > Furthermore, the information returned for x86 64bit PV guests is wrong. > > Explain the problem in version.h, stating the other information that PV guests > need to know. > > For 64bit PV guests, and all non-x86-PV guests, return 0, which is strictly > less wrong than the values currently returned. I disagree for the 64-bit part of this. Seeing Linux'es exposure of the value in sysfs I even wonder whether we can change this like you do for HVM. Who knows what is being inferred from the value, and by whom. > --- a/xen/include/public/version.h > +++ b/xen/include/public/version.h > @@ -42,6 +42,26 @@ typedef char xen_capabilities_info_t[1024]; > typedef char xen_changeset_info_t[64]; > #define XEN_CHANGESET_INFO_LEN (sizeof(xen_changeset_info_t)) > > +/* > + * This API is problematic. > + * > + * It is only applicable to guests which share pagetables with Xen (x86 PV > + * guests), and is supposed to identify the virtual address split between > + * guest kernel and Xen. > + * > + * For 32bit PV guests, it mostly does this, but the caller needs to know that > + * Xen lives between the split and 4G. > + * > + * For 64bit PV guests, Xen lives at the bottom of the upper canonical range. > + * This previously returned the start of the upper canonical range (which is > + * the userspace/Xen split), not the Xen/kernel split (which is 8TB further > + * on). This now returns 0 because the old number wasn't correct, and > + * changing it to anything else would be even worse. Whether the guest runs user mode code in the low or high half (or in yet another way of splitting) isn't really dictated by the PV ABI, is it? So whether the value is "wrong" is entirely unclear. Instead ... > + * For all guest types using hardware virt extentions, Xen is not mapped into > + * the guest kernel virtual address space. This now return 0, where it > + * previously returned unrelated data. > + */ > #define XENVER_platform_parameters 5 > struct xen_platform_parameters { > xen_ulong_t virt_start; ... the field name tells me that all that is being conveyed is the virtual address of where the hypervisor area starts. Jan From xen-devel-bounces@lists.xenproject.org Wed Jan 04 16:43:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 16:43:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471329.731137 (Exim 4.92) (envelope-from ) id 1pD6qu-0003IY-Kb; Wed, 04 Jan 2023 16:42:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471329.731137; Wed, 04 Jan 2023 16:42:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD6qu-0003IR-Gw; Wed, 04 Jan 2023 16:42:56 +0000 Received: by outflank-mailman (input) for mailman id 471329; Wed, 04 Jan 2023 16:42:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD6qt-0003I0-7c for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 16:42:55 +0000 Received: from sonic309-21.consmr.mail.gq1.yahoo.com (sonic309-21.consmr.mail.gq1.yahoo.com [98.137.65.147]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d38d321d-8c4e-11ed-b8d0-410ff93cb8f0; Wed, 04 Jan 2023 17:42:52 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic309.consmr.mail.gq1.yahoo.com with HTTP; Wed, 4 Jan 2023 16:42:49 +0000 Received: by hermes--production-ne1-7b69748c4d-bxfkx (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID b97eb870a99459924a5a879746b40ce5; Wed, 04 Jan 2023 16:42:46 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d38d321d-8c4e-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1672850569; bh=gkECN0M7dTCv9hA50jRyxlhxwaSHqhYobw90TKq7mWM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=h8oY8n4lLbImB1k6gMs4kYXc4cNXruE9QK7kq7ctrtMOTKcGEyQR3UEhj1g9LiQW8G8HQ215zzdM1N3uYxFtojKOPkWG6aoUCpE+ZdjEGE7kD3LqmIDu0NiG5wSqJryzR1V0IWBtCiAjPvlXh/7KFvC0kLfkLQ4hneRcZsgVZz1TSG2/vbRJxSRxO+JMFySsIDZBFnREiFfwaWs+gLyKVPsTb4IqcJHEANa1a8t2MqaCCJ5N0UOPql3J9Anje6DeTiSnmhZw7IFJqURXiwctYcmAlO7SXYWXDweeOSxrFeF1R68P3uB69xG+zHu6uacNG5wEKOJBQSYcZYsvwmnn4w== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1672850569; bh=02o3orJMLFp/E0j67fA2cazTjOZU8h9oAObFnE24cw2=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=lkkqrk2W9BhxIhO66ofRokPWnaWMyJ3Ygie8qiTAKKM7GtnrbV6JtfdjM0+EH8f5ioGJKOiRFZHQ/3U6Id7sI/N/GI9/GnuU716vvxg/eJBkeGc/jlLnOpqH+rXNWi40e95rbxsJI6KS7EFq+mTs3CERXL2kOOca527EXRWVXpL3bszjreGg0tlrCHYkfXeZb7JDQxnpcSPWxb7PEwAtghnbTZWaNius53k009QGyTLPKvnO/PnBtZaeT24SdUz5YGVhHYE1MyLhaAGnb5b63zE/qPI2zKHigsVI6SHkmK/Ozq78LjIIDfKQV8Km0dvyyRSGn+tmqgBIsxU1sBIraQ== X-YMail-OSG: vknwtRAVM1l1uz1Q_nHZbH.B8L8gyl.qQ.KBCiCZrU_RCKZy0AnUDBa42P9Tzru iXAXZJghdT5Gr6nTd95_2CNoTsA.SvwRJjoUWPYxjLAM8zoyq0Sftla.zHqD5U3_jIQxpGgWReks m4iCgagvyS96mwvKkE6OoObuSyqoJ9.cbmHGU.IDplR0uX2upFsq0OxzzGF6m9Vlrta_uzNZ6Y32 ZSzit1PdsgbIO4mZyf_d18Vwrjb2oHQ.8terXvT8KACy9Sf5sdSlils4Snk8oQIcH4CMy43hUFpB .Gfi3OtGCB4aiik236yGWOgJVNWUeNLvS3BQCjVIdO7SeE4id3cMAqp3z5R84bjUfktHEFjA5Mtj r2YVQGwdllrd2d9CJ_O_KV_Ipanu5viRC4VUl6.8nW.itbEHQn3.5VQuKscFo52kX3D2WjTAxrrz lNhwT1DBHsqRT3oELI23i_G2d5pl7AoBYssEiYeJWBu1.RJ8.cJ1LQtuDE.gRhu6N_nA19bU38PM 8sX5eo8x7PXyPemEtXz1tfrBe1yJxjZqnuTYslLGWNZT1zs42UsQcthR9ZCI6COOJeUhZJUP5PqJ N5nvfZxg4mO4XRzbMI0IxxWP.SyHTwDD3FjmuPAKI2KfUYF8i8wNT0xpzu52fYOF01N771kaG36M lHgXM8WQrNHocPLW.W2dl78JPjtxgOOLeFMu0Xpl3wZ3OfH.itcTiaskB3z7.iKH2sI.uuCm4oxF LCttbeR92n8eF41rLX3jYVGmpdX9V3aZ2wytMm0J2lxM_Vle4sXouGvuVoe1Zf5hNSCogsegN_vj ljmGMXb0V4HHhqAjdYm9tuM5_8P5jgAm1wFOpOIUgu2wHKkVgxIWpGZDLBvJQm6UDNHYeq.u1QiL cquBrZjXaKtM8ws6DjuvTv3mhguu8qXGRC.k7b4vaV_7XfWdMsjGn3PWFRV68gTGAvYKLygWv3Qv 88_vieb4xNpIjUdGjZNs3fUTWNDs90b8ebVChnkhZlTa3.LbOHYupm3BJrPvNN9cTvzu9F.0gKHl v55ufBNyKa47L9NwwdTzOgQIOzF_bG9TCWmJKYJ2QOt5wiwoEeu8APYbbVY5pliyDGipzXRXgPEZ akot0gTNo58w3LHV2IM0ycODKBXCkRSNv1mMoJd1omQITPAGGm5pwxC3OeLal7jEFZV.KiE.4ncz 7ydc1i4rHU.45Ez0sno7tMlJnmtm23n4yWRobmc57yHrKvi8GQi3r7zVXVJ65lchQhygU83s7f17 DafsXn608z0Hk0KOC56QGEcysFYRuDMz3Ly7dw99EiOmpmXSUEM.zwJETceKuz89keWBxJgio_Kk V1S_5OYaHq3ckztTMBe_68OfMBQPoafkosXYdVbiwMvrg3sdtwayGCHWr9ZaAjG2HHccypxywy6b OZ4KMMuFUeMa5NN8LZgDvzTPqOy9hVMJBvDPz_knuf1eWyi0hQTjGvjHA.kllO63kCu6g4BZGjEE 82rGQ0tM2lqSSTznD6tf871ijV2mwNijMI_hpAIpylW2KqxZQfP9SwyxBLR1CFa._bpNDHND5u1k oayEKK0sz8blLKg7SJTrQNNN9xL5WW5BUHuc7AU5JBPBzVm5aICylhfgdByJg0shVSK9l40ID_cL AAkOETf4ddNcfhYA4YlfqiDptlRX52tH6EzOTk.F8f1w3WbCkf1EzP_Bm7QTlLXWqTkLspnyzOze AS_vTi6DYOZ_N1csoX._HWEqQMHoQpJCVJY8G4NMm7PwlATHw7CceuwmBweGeHjCpOhrXPH2NIFG B7im88usBn0wHgjb24nZrbCQ0rwJnQ8KZiJGEw6G.YDNn6.sQqPYV37IqFzmu.KTryK8CEWwbYSr XrYFaF6YmyL7u2tnS33ZvPur3CQpqY5_cIxQDVvMlxWJUzfbPJ5E3Y.j_4_pbjbiXQp.7R8geggv IKu9.wyEvLN8R3nK8Vj_s6TW1oF5ZsvpkMtFGyZbiF.RHm9MoE35LeCg1Ju5pSmqv8NenFrd0axY nlwlPXOMzXo2vqBHhyrWhCgEMfqJuAqaiv2O_yQ3q6ADJ6DidlfuKyj.HD9R8vRNzQFk6y5pKab0 tQOArth2F3MVhO4HQA7oEWNBrxk7U9OGJT1MdRmFm84Mupmn7Q.OyFyIaY4u4hKAivSpxkKj30WT irJnBuvWUmIz35PJLqwhK4Z5I.P20Ex3zOiFBa6fVC8wxE0q105DsBQxTTj6BTvVshDNKuFSMKcT J3nr7F4iEZpwQNQUsf5JXjHo- X-Sonic-MF: Message-ID: <30ed41ab-f7c9-15fb-8f4b-b2742b1d4188@aol.com> Date: Wed, 4 Jan 2023 11:42:43 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v2 6/6] hw/isa/piix: Resolve redundant TYPE_PIIX3_XEN_DEVICE To: Bernhard Beschow , qemu-devel@nongnu.org, =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Cc: Richard Henderson , Stefano Stabellini , xen-devel@lists.xenproject.org, =?UTF-8?Q?Herv=c3=a9_Poussineau?= , Aurelien Jarno , Paul Durrant , Marcel Apfelbaum , Anthony Perard , "Michael S. Tsirkin" , Paolo Bonzini , Eduardo Habkost References: <20230104144437.27479-1-shentey@gmail.com> <20230104144437.27479-7-shentey@gmail.com> Content-Language: en-US From: Chuck Zmudzinski In-Reply-To: <20230104144437.27479-7-shentey@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.20982 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 3589 On 1/4/23 9:44 AM, Bernhard Beschow wrote: > During the last patches, TYPE_PIIX3_XEN_DEVICE turned into a clone of > TYPE_PIIX3_DEVICE. Remove this redundancy. > > Signed-off-by: Bernhard Beschow > --- > hw/i386/pc_piix.c | 4 +--- > hw/isa/piix.c | 20 -------------------- > include/hw/southbridge/piix.h | 1 - > 3 files changed, 1 insertion(+), 24 deletions(-) > > diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c > index 5738d9cdca..6b8de3d59d 100644 > --- a/hw/i386/pc_piix.c > +++ b/hw/i386/pc_piix.c > @@ -235,8 +235,6 @@ static void pc_init1(MachineState *machine, > if (pcmc->pci_enabled) { > DeviceState *dev; > PCIDevice *pci_dev; > - const char *type = xen_enabled() ? TYPE_PIIX3_XEN_DEVICE > - : TYPE_PIIX3_DEVICE; > int i; > > pci_bus = i440fx_init(pci_type, > @@ -250,7 +248,7 @@ static void pc_init1(MachineState *machine, > : pci_slot_get_pirq); > pcms->bus = pci_bus; > > - pci_dev = pci_new_multifunction(-1, true, type); > + pci_dev = pci_new_multifunction(-1, true, TYPE_PIIX3_DEVICE); > object_property_set_bool(OBJECT(pci_dev), "has-usb", > machine_usb(machine), &error_abort); > object_property_set_bool(OBJECT(pci_dev), "has-acpi", > diff --git a/hw/isa/piix.c b/hw/isa/piix.c > index 98e9b12661..e4587352c9 100644 > --- a/hw/isa/piix.c > +++ b/hw/isa/piix.c > @@ -33,7 +33,6 @@ > #include "hw/qdev-properties.h" > #include "hw/ide/piix.h" > #include "hw/isa/isa.h" > -#include "hw/xen/xen.h" > #include "sysemu/runstate.h" > #include "migration/vmstate.h" > #include "hw/acpi/acpi_aml_interface.h" > @@ -465,24 +464,6 @@ static const TypeInfo piix3_info = { > .class_init = piix3_class_init, > }; > > -static void piix3_xen_class_init(ObjectClass *klass, void *data) > -{ > - DeviceClass *dc = DEVICE_CLASS(klass); > - PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); > - > - k->realize = piix3_realize; > - /* 82371SB PIIX3 PCI-to-ISA bridge (Step A1) */ > - k->device_id = PCI_DEVICE_ID_INTEL_82371SB_0; > - dc->vmsd = &vmstate_piix3; > -} > - > -static const TypeInfo piix3_xen_info = { > - .name = TYPE_PIIX3_XEN_DEVICE, > - .parent = TYPE_PIIX_PCI_DEVICE, > - .instance_init = piix3_init, > - .class_init = piix3_xen_class_init, > -}; > - > static void piix4_realize(PCIDevice *dev, Error **errp) > { > ERRP_GUARD(); > @@ -534,7 +515,6 @@ static void piix3_register_types(void) > { > type_register_static(&piix_pci_type_info); > type_register_static(&piix3_info); > - type_register_static(&piix3_xen_info); > type_register_static(&piix4_info); > } > > diff --git a/include/hw/southbridge/piix.h b/include/hw/southbridge/piix.h > index 65ad8569da..b1fc94a742 100644 > --- a/include/hw/southbridge/piix.h > +++ b/include/hw/southbridge/piix.h > @@ -77,7 +77,6 @@ struct PIIXState { > OBJECT_DECLARE_SIMPLE_TYPE(PIIXState, PIIX_PCI_DEVICE) > > #define TYPE_PIIX3_DEVICE "PIIX3" > -#define TYPE_PIIX3_XEN_DEVICE "PIIX3-xen" > #define TYPE_PIIX4_PCI_DEVICE "piix4-isa" > > #endif This fixes the regression with the emulated usb tablet device that I reported in v1 here: https://lore.kernel.org/qemu-devel/aed4f2c1-83f7-163a-fb44-f284376668dc@aol.com/ I tested this patch again with all the prerequisites and now with v2 there are no regressions. Tested-by: Chuck Zmudzinski From xen-devel-bounces@lists.xenproject.org Wed Jan 04 16:49:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 16:49:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471336.731148 (Exim 4.92) (envelope-from ) id 1pD6wj-0003wv-90; Wed, 04 Jan 2023 16:48:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471336.731148; Wed, 04 Jan 2023 16:48:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD6wj-0003wo-6D; Wed, 04 Jan 2023 16:48:57 +0000 Received: by outflank-mailman (input) for mailman id 471336; Wed, 04 Jan 2023 16:48:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD6wi-0003wi-6i for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 16:48:56 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2075.outbound.protection.outlook.com [40.107.22.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id acc592db-8c4f-11ed-91b6-6bf2151ebd3b; Wed, 04 Jan 2023 17:48:54 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9351.eurprd04.prod.outlook.com (2603:10a6:102:2b6::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Wed, 4 Jan 2023 16:48:53 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5944.019; Wed, 4 Jan 2023 16:48:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: acc592db-8c4f-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KByuMl3EQA2boIbd/IEpUu2zIs2s5DUsfCcF+o2bffxPD8rlQ/yqNoyAK83ENLldmgWtc9x09upKadJBgasG2Yye3BIRaOWzofK2mO5byltKjZt9+PFVrkKaVIpMEf9Rfhm5oM9kirG+o6eQfBun5dCBOZ3QMyq5od9uhEMI+lRe9ANn292/oeV0EXWlousEXVpGwAr+GGwaUFzuKFUHVe4G7WDg1kCD5Zp1+8LO0lCV5R+cE0mtPKalBHm3a49GffkMTiApM7fgM/1Ea507SuM7FLrcpYrwPRkIzFZtqmY7bhgB0BMF8XyUyzsfqPMC/0MJTXGuW0UinJlD80/Akg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9xAmverj9++5UlRNO3QmIsOYSyc2TLNT0B7BkJv09qQ=; b=DqYwGhYsK/kAqChvuQVFRTEAIFQO/H8wASIzW+9eJ078bv/PZXL45TMdlvKqe0jgPEBugKm5RQyDoJlg8lpiMK3dI8KqE4TXrFhzmFkOCsrWb6dQsYAqckbGJLXzJmcCdwKowiBjRYLkCsg5/A1C2jIISoLW2dGIjEFqO6Oqt0yE7qvK7BFiNs0HgRznnxxfurj4zpKYSZIAwLd2xXpu1XEgIalmowcKchLu8fgv3t/Ke8h6wWozAHD4Fj5qGXW076/PfGVu9rlqAdJLlVrmqHV5/7clMPwm3jSfAGMTg8/avXeAV8pfUpkox8QZ/YWUf3jCLf5MX/QQtI2aj67YmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9xAmverj9++5UlRNO3QmIsOYSyc2TLNT0B7BkJv09qQ=; b=s+2KXcIBjLaSUvUoKlBik02Oty7Ci9zfOE7IkVcA5+QCrMHDkVfvK7dawnkjCmRttT81jcakwVLAo285bwbhjfP2Eh32uyKdHsPWCIOC64hMTzBw1vwZhJkebjgzRpYTE+BBW2FF9k7D4pFRpYwiBRiBpUWd3wy1n8HD0POcJNR9qsw7AHNMrmUO6t+okVcX3/DMPvJejbLNdwGpEDBhFUbVn8ko8HoSmQXvlirHGOtPxw5LC/1uat9qDmd+84HsSv1J7sRylI3GkQlINbvJBVUP63FOR4y7tWwsIdWMLDL11dR/HyNc13G2U9W1ybP1mskBDGNZ25C64Az4KJW5VA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <23360b49-5e64-4b8b-49b1-214a26d9fd47@suse.com> Date: Wed, 4 Jan 2023 17:48:51 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 2/4] xen/version: Drop compat/kernel.c Content-Language: en-US To: Andrew Cooper Cc: George Dunlap , Stefano Stabellini , Wei Liu , Julien Grall , Xen-devel References: <20230103200943.5801-1-andrew.cooper3@citrix.com> <20230103200943.5801-3-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20230103200943.5801-3-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0135.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9e::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9351:EE_ X-MS-Office365-Filtering-Correlation-Id: 5b5083e4-d739-4c70-c622-08daee739009 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5hy1+vjpu7iK4XuFizmCeIIzj4pYaDqku8oNIiJwqnWelWWhufmQWQRcuGMe4JlrsN4785+WAwV4T8kqrQTKpOD3PENhNWTpmF7ZA6UqM25dekpeXN9cnAthXxqExi5m2OkVpSIAeGJZVVboWPIW79gV8WDwfRGHZF6hy//9FEDukOmDrTRnaoVNaQCtItmS2xfCegvcVpYxUK5OdobcOB+t1UM25+2X3kFJ4R2NGp+rygdBrrSxRn5hn4CZEuXOFFoaQlVaS0Xa67KM2gwT+bPBatxCRCTFq5LgfEy+SYFht12NjdvLmfX3OND3379zOmO0HiB7MiFKuQxbmOCXvb0UV9pEIpPkRK6eaji7jpsRWxioiMPwNlyy6L17v0nDBhjAVPZ6JbCcwOA0CuGqWVyzo0dDigEGDSa6he2yFrSIx3+PZgSIDgnvXWR8U9EcL9/v4YWmrUfvIomt2htGitin8rYP0EW7NegzTUckDn6I2EN67UB2buWBLDenSmwve8vVhgXhLWuQ7V74wEhU9j0WFSLRF0aM7mBd1MIgK1mjEVd1KObC++p7cqUG2vGjMtGGeBB3ZDAtSVKcY6ebdjA491EWsEeGn5kwXuB3rvR2pJnFkbEWPirX8TjynUkV14zlCm5NMEDZF3jzR+D0yAQrhVcYsuqywDvAKJ9ll3PrBe+kpimH4HgaoJSI1SURC0nZ32dkTjYgum/salSGyNnRV7x29h/tk4UjaxGy7pk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(346002)(396003)(39860400002)(136003)(376002)(451199015)(36756003)(8936002)(5660300002)(4744005)(38100700002)(2906002)(41300700001)(83380400001)(86362001)(31696002)(66556008)(6916009)(54906003)(66946007)(31686004)(6486002)(53546011)(478600001)(6506007)(4326008)(316002)(66476007)(8676002)(6512007)(26005)(2616005)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RUVEK2Y5SmxOcndTWkdlemRFRDByeHpsemZpa1dyd2UzTjIxYUE0Z0NiRm1i?= =?utf-8?B?RGsvSkxDbUJwVG1GTk9mZE9BUWRKYUdtNGpEOWFYQ1RhcCtiY3FPMHhpT2dU?= =?utf-8?B?SEE2cVVZTXZhajB3bytWK3VLbEZjNXJHNTU0UkJWODZ1UjlCZE1YZnNYQ0hN?= =?utf-8?B?NGhFeHkwb1NTTGMwLzFOWEhmUjBGb2NybVV3YXZzNS9sKzRVTGM4OVFjWCtv?= =?utf-8?B?Y2NvVFhoeXNHdXEvTC9nTmEzNlBvTXhJRmRjcGdUcm5WUkF0OEJPOGpyS2Ro?= =?utf-8?B?QTZOakdIL1RDUGZTZ3dIT3V4NXo0cnNYTnZ0WXZGTTQ3QTVjakhQS05WWldi?= =?utf-8?B?MWZ5c0k4eW4rK0FrUjRrZ2pOYVZGaXBXcWRDUUoyamlCUlJ0eWpjb3ZPNXZh?= =?utf-8?B?ak10NGxGQ29kYUFmeDYzNEFremxLK3lwWitvYnJwYkY5N09nckhTTTRNaVVZ?= =?utf-8?B?d1lEVWhENC9taTFyY0ZSSFJsa2VtR2IxQ3kvbUd1TWJ5aklhazBvVzhrR0s0?= =?utf-8?B?b2VrVlV2UjIyVVZkQWlubXlRcnJ4SFlWSFlNMk5PbjRXQ2RTUTh4L3VVSjRF?= =?utf-8?B?ZjNQNUFqdTZHVUhnMVdYeUUrOE5rbkd0bkZtNnI1RjN2QTZ5TmhsRUFtTUVB?= =?utf-8?B?U2xEcHVVRHZ4SzJMNlVaVC90L2ViZFE4VzNvcXMvekNXKzRPb2lMREI4V0Vj?= =?utf-8?B?RGF3am10NUJDYk1xeUF4cUgwK3o4R1d4RlZxcmNFQ1NxRmR0SHBRT0FBUGc3?= =?utf-8?B?Z3dCczNtRThRSm5pVXo5dzloK2ZNQzEraW10VkhCMHFLU3phbkpRc0RkY1Zs?= =?utf-8?B?V2VvL3pDTTRESmZndU5yYnlNbHczV3FJRmtMM0RiU1VaRzNURmRvZ0t6RmJV?= =?utf-8?B?b21BaGNSM1EwRG0rMFdNZWJhWlFCMzN6VFdzUFhsR2x0VkZ0dm93M0pFcnh2?= =?utf-8?B?S0JKc3FrT2F1SWNJeVdPc1l6clpyTitkbFlzWDA4OUdqSHV2NURnR1U3OTI0?= =?utf-8?B?L3FWZlpEYThMWG82bzAzMS82TUJMQWQvTUE5T0xma08xTnFkcGs4L0hhNEdi?= =?utf-8?B?V2pyVkkrdVpXd204a2VBdGxFcUs4cFBEOFV5WEYwYk9KcXdSV3lKbHhidFFD?= =?utf-8?B?RkFSUEpRYmhlMzBxdFh3R0J5ZEw5Y2tZRS9lY3ZOYS8yaGhrNDFpdlNUL3ZO?= =?utf-8?B?di9CcW8xREdRWTduVWhvNUFONnR0Ulk1dHYvS3UxTjhUTXFlQS9ZeFJQckJ2?= =?utf-8?B?U0V1bUVNTkRMVW9nb1F3R1E2SDI0OHlBMjRVa1AxUUk1R0ZSTEhaNk1rMDBK?= =?utf-8?B?QUk5ZERhT3k1NEQzdGR0cVV4d2dMYm9sN0djTDI5cWFoRDNRdmJleUV0RlI1?= =?utf-8?B?Ty82SEhFRVFYaDF6QnpZYzNOWEdPVG93Z3E5SzkxQzFMUUNTbEI3L0FQVHcv?= =?utf-8?B?eExJSWprSExQVGwxcGtXOG9rKzRRb2NZdlBwcmt0Y0ZGaDEyR2VMNWhOMmJj?= =?utf-8?B?K2ZvU3FScU0yVTRJZmZtam1JT0VPd2dlQUpCYnBTUDNLazNFZlZ5NzNiZktI?= =?utf-8?B?TWZVK2p2TS9xRTJJTVMvWGFQQVc4K1ZqYzhPYWRsWHdwcXB2VVltRS8yVDVT?= =?utf-8?B?SFJiczdaVGdrUC9BZEFOUlVVZk13aUdHeUJsYS92MVYreFdMRkh2a2pWVGQ2?= =?utf-8?B?SEJQaktyNVVKWlJiRGI3ZFM5ejJTUmlrTGhycXo5M1RsSW1BdVhDQS8yL0Vi?= =?utf-8?B?Q2k4NC8vSGppSlVpREJOWXc3K2lTUnB1QVdPSDgvQzgrdTRvdnJxalgycmYx?= =?utf-8?B?SUNnZmNEWlF2MmFMTERWZk9zUXdBMW1MQ3lOODM2K2lXR2Z3ZmhBTSt2QVB6?= =?utf-8?B?U3dpYUkzaXZxTlByM3hIZ05XWG9qRk1SYmo3QVN3cmRhdFpST3BuaWdUM3Vt?= =?utf-8?B?R2xGVS9JbWd5MFhqNDd4SVRBMno0Qm0zVVVPR01XNHNTMnIrWFJpNjVCWitH?= =?utf-8?B?Njh2YlphM3NUQ3l4VmdTWUlyT1BuZ1JpWS9EME5nK25iMHk5UWJrd21hWTFy?= =?utf-8?B?LzkwTkVMbG1pMHhXQUVnUmNYUWUxUldla3RhNkJZNk1PQkJuNlNxODZrbUVi?= =?utf-8?Q?HqaLFb+XJyVg9d/IWcxrtkLU9?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5b5083e4-d739-4c70-c622-08daee739009 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2023 16:48:53.4524 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ezlwZD1NIfHo2xTeGxqdap1K6p/6QpPPeyXkoNXve+2G+1sh+1ak9IBGgjUoVLQk1U2BX+e7XHj7nad0cP84tA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9351 On 03.01.2023 21:09, Andrew Cooper wrote: > --- a/xen/include/xlat.lst > +++ b/xen/include/xlat.lst > @@ -169,6 +169,9 @@ > ! vcpu_runstate_info vcpu.h > ? vcpu_set_periodic_timer vcpu.h > ! vcpu_set_singleshot_timer vcpu.h > +? compile_info version.h > +? feature_info version.h > +? build_id version.h Oh, btw, another minor request: Can you please sort these by name (as secondary criteria after the name of the containing header)? Thanks, Jan From xen-devel-bounces@lists.xenproject.org Wed Jan 04 16:49:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 16:49:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471340.731159 (Exim 4.92) (envelope-from ) id 1pD6xW-0004SO-Hb; Wed, 04 Jan 2023 16:49:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471340.731159; Wed, 04 Jan 2023 16:49:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD6xW-0004SH-EQ; Wed, 04 Jan 2023 16:49:46 +0000 Received: by outflank-mailman (input) for mailman id 471340; Wed, 04 Jan 2023 16:49:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD6xV-0004Pt-4w for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 16:49:45 +0000 Received: from sonic301-22.consmr.mail.gq1.yahoo.com (sonic301-22.consmr.mail.gq1.yahoo.com [98.137.64.148]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c87c342d-8c4f-11ed-b8d0-410ff93cb8f0; Wed, 04 Jan 2023 17:49:42 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.gq1.yahoo.com with HTTP; Wed, 4 Jan 2023 16:49:40 +0000 Received: by hermes--production-ne1-7b69748c4d-9jjs9 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID f78b14bbe46129161d3132f677ac1e69; Wed, 04 Jan 2023 16:49:36 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c87c342d-8c4f-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1672850980; bh=Uv0BocHD5tWIg18/jevfjehh7q0MhSFzY8Dyf/BXAg4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=JbYYbvz87wXyfJVL0rGXDO37O81ZJSJ75kAmtjzrQ8Ux9WcdgKZsXRjVDE82L/aPd1WGXiR9qkCsQz9ZrvZl2dIBRSW0vkZ7DgrPIf9QKBlVI8syU8XFKJEZZlpxAa5X0bPQggQTuizc2seXsDYMGtOA4BGWvnI26ovQwe1AeIfmaLl0mi6SgPTBxmkuK6g+kE2F9O2OV6ajfslItuTza09LBG7KEgjzwYKrBQjU+I6USPYXWWAYa6DKK0lOgfhRMtlxgllUx4vdRLk4RDzF9/toB46ZKQcob4ejgV5qs9MHu9CGsaIigmrYMonQ/2vDNNxUWwmojvDd0+4bOI94Kg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1672850980; bh=FxzOEnvBptL07rvzdDlcQCWQrhGrukvipEJHtDDzfWh=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=OYvHrPLvawpjH0CokBSNIhIygYnWUO1JQgVPCJuD2o9U5nkXiL2AvCIRQzOqEWEkzheTfey8a0nxHhDTULI0JbX8xhWnEbwkBsjXsFwz0vHT0bADsWynNcbVJyTuEsKWG3up47pilbtGN3mZ4M4I/udFDcmG/lOVQ8gpyLYY1qygxYoBTdcgUgqLtzImaa7FZcTXyNwPOArSqa5fWqqiCkfAi8oaRTNKQacYHG7ZmT88eb0DN4C5NbxiOXDixu1t2whaI8+OttmzhLU/rQNvzSPyV9jyBkyv39Aa/PSnHwFTFHo7CHFV+mCFqR96afdNwGrwIzp63lbhk/WxGGPRtQ== X-YMail-OSG: Y.cY9QQVM1n12rN8bHGsI27Q8vksmGZnxhR.qASFPFpFz2aPufAc26szN7uy8RZ RlDLbliSLZ7kWm4a4GWBe.arjJy3fAzPrAp6W4LcLnaEshl3OvFtMBItLq5XfNpgwyV48QJ7F042 TztH6BRKJG5RwIRzv0GTaOcB96LaltnABc0xhcY32V5DuOYKbvSGRKnjNkL6MChfOjgmMYyR9GYM aEod0xGcSVcD6P.b_Cq35fmQWjzay2iPdmYNFDjIFzQxpOGgc5peFNt8QeRwZy3AphQ0QXOxCM2. V2M_M1TjOYfavoJeIQoa4VSwg4LbkvaHO7JQRpwplTlapPrTITZuvSlHo__C6T85_np.XiLaKDsL qp5GB2GUYoYvxuyMwwyaGrYmzlHBR.6.m7gf8WWyH9LEF_xhvNn.pMb2dpb7OLN0CacdXsmpnvX3 3uDcCXJHHgPEIU.AKvv5_HtBFPpPVXPajjHYBEWChZv71bAjrFf6aqpsTdVlO8NXI7ncZSnN3.w4 TFCksh7.OyDy8crk5oDN89TOTxoP2_xqmWG2U0glQ8wnroq3KdOtL2uj0n5wFPCS74aL6KCbzhLZ AHNovKeCGqqnSRuAVX1tDwzvyYQpO0mSk07Uv.ncGAXZAxCbgpqALa2KCYm6LLR4jdjvRQfZSx68 NHOfxrwHW72xRro.H1mskH_5gfRa4k1jF4cNZwP4ZbwBX4khm_s4nwXfnLxwjFGkSR61YVRf2F.N Wo60cRmmCMjI2gdrXxyAxFi5NuLg0EJnILFyaI3.gwE0e6EljA4ldjinI1w_9CJPODaeJm_3rFpD gCBWFpCq.J6X4yvV1wbAoZUBkcWsDbJQ_HPC1skYB2JmNGoi88rqAwFUCKDKCubfrGSAiFfB8xtg kPbPwol7Nc5wF7eLQ1KZ_am1Ne7dbW_61i3hNGV8vXC_iO_Xuo2yBbdwMR_HMbxvF08S6PWXRg7K L.4fPq5N1pD_B9qFkwaPc5jQmg.68_bsdAsvxuxTJDGHp.MfnwSUZiW1MqF.dW6K5yn8FjSpMfAs 2vF3Xx2DCI7MHBP02J4wbZhXmFgnC9yk_gj.kHiLJwK5nKFkn9nnpf02uDpEwYCK5VYhu9gx09fv 6N4Qc5g4OwCZX2W.7eArebedl1d.5SthtaAT3XIs3Q9aWF8hvE.udbekuB2nXSHlacZhuiRcxPCJ 3LQSh0FNb23omeCPlkHfVV2zjBj.4fJ0PXqUYDvgV2nnb2VqLhXOL6b6KugV0abri7na7y5wfKIB ZAa.k5NibC0RGO70bMCIXF2Z8WdcFQ_NKAeTbAO.vBpJH40fVdfhKDfuqZI2BwsE8ppEp3fGzxvw YvZpwZmbIH13FCODp8IyZBMxew9nINe2WIecckS86mKq_U3tYg_TRJ8xO5w4uvWABxYGFHZwplhZ p3zCf49QZifHg8juo_QlZnmM5XDuh.tCKQhxiiOSWJDHgvORE2MXq288bJrvSwofCkmTeaHWU.R9 A_0SkxYj1mmEWfdQ2_mGTjmeWo8JWntBJAg28X6PcPRiveOSeqCffG8alu4kQK314kH1vjm2ByJb ZKIqKUBNecy6wPEqAyeFBb.WHGda9RFtBzmiHRQM8nmfNQQL6luszjA7tTOFDlldFugucL.qS0o0 mIzz85Mkc2FvdTMBI1EAFHb9T4aOuy22ViEKRQjkoIFparniZB5ooS2Iyhon3FMkLXB8I5F2AB6Z 46KhYPCfz.clEFl3sY0kB8TWRuraitYtXA5aTEYr5oyByVNZG.0XtZi8UP3Qax0uLwUfXOw20d_c gaq3LbSXwtUc.lqyU1hU.j.BtJiER4.mF2WZkEzQQvlExvd935oOg7I1HUnmH01oIhoDvCEPQOb. MlfiPKcuKlqIAydWmacz.2hjxeRc9OUQIb16B2JiaIXbZJkWS1HPgmALR7jbS_AWENbuesxSm7m0 cIk4wSgcJJQ6ApgfVa_xq089uNrI4jIb7JAY3vcRMqaQ8V3s3slPU9dBmbhvLAqm8QEkJ9tyanTF RFUGMJNrVvqPp.9Q8phM0bkn8KN9r62uBqWeQUFC7qZ7ARUL4XTUYmm7_bLNQdTKF8QagMqc0jnR kAVtwoWxZuKmRPYqkcYYwljTm_JeKD9Zo9ETYP1IHnHC3tR8eiq9OCEJe.0J.y7ZFO6DKiQGvSox ZO9.h7igNXcBNlBnXxHNiV54wfYs0l1lL0YEklgs6LX263sMaj50wnKLJBeB7cmyalcLzDt3agpV JyG.EzTBq0U6wvqy3gf5josIr X-Sonic-MF: Message-ID: Date: Wed, 4 Jan 2023 11:49:34 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH 0/6] Resolve TYPE_PIIX3_XEN_DEVICE Content-Language: en-US To: Bernhard Beschow , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Cc: qemu-devel@nongnu.org, Paul Durrant , Marcel Apfelbaum , "Michael S. Tsirkin" , Stefano Stabellini , Anthony Perard , Aurelien Jarno , Eduardo Habkost , xen-devel@lists.xenproject.org, =?UTF-8?Q?Herv=c3=a9_Poussineau?= , Paolo Bonzini , Richard Henderson References: <20230102213504.14646-1-shentey@gmail.com> <0de699a7-98b8-e320-da4d-678d0f594213@linaro.org> <00094755-ca61-372d-0bcf-540fe2798f5c@aol.com> <7E657325-705A-47EA-A334-0B59DF0DF772@gmail.com> From: Chuck Zmudzinski In-Reply-To: <7E657325-705A-47EA-A334-0B59DF0DF772@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.20982 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 5318 On 1/4/23 11:12 AM, Bernhard Beschow wrote: > > > Am 4. Januar 2023 13:11:16 UTC schrieb Chuck Zmudzinski : >>On 1/4/2023 7:13 AM, Bernhard Beschow wrote: >>> Am 4. Januar 2023 08:18:59 UTC schrieb Chuck Zmudzinski : >>> >On 1/3/2023 8:38 AM, Bernhard Beschow wrote: >>> >> >>> >> >>> >> On Tue, Jan 3, 2023 at 2:17 PM Philippe Mathieu-Daudé wrote: >>> >> >>> >> Hi Chuck, >>> >> >>> >> On 3/1/23 04:15, Chuck Zmudzinski wrote: >>> >> > On 1/2/23 4:34 PM, Bernhard Beschow wrote: >>> >> >> This series first renders TYPE_PIIX3_XEN_DEVICE redundant and finally removes >>> >> >> it. The motivation is to 1/ decouple PIIX from Xen and 2/ to make Xen in the PC >>> >> >> machine agnostic to the precise southbridge being used. 2/ will become >>> >> >> particularily interesting once PIIX4 becomes usable in the PC machine, avoiding >>> >> >> the "Frankenstein" use of PIIX4_ACPI in PIIX3. >>> >> >> >>> >> >> Testing done: >>> >> >> None, because I don't know how to conduct this properly :( >>> >> >> >>> >> >> Based-on: <20221221170003.2929-1-shentey@gmail.com> >>> >> >>            "[PATCH v4 00/30] Consolidate PIIX south bridges" >>> >> >>> >> This series is based on a previous series: >>> >> https://lore.kernel.org/qemu-devel/20221221170003.2929-1-shentey@gmail.com/ >>> >> (which itself also is). >>> >> >>> >> >> Bernhard Beschow (6): >>> >> >>    include/hw/xen/xen: Make xen_piix3_set_irq() generic and rename it >>> >> >>    hw/isa/piix: Reuse piix3_realize() in piix3_xen_realize() >>> >> >>    hw/isa/piix: Wire up Xen PCI IRQ handling outside of PIIX3 >>> >> >>    hw/isa/piix: Avoid Xen-specific variant of piix_write_config() >>> >> >>    hw/isa/piix: Resolve redundant k->config_write assignments >>> >> >>    hw/isa/piix: Resolve redundant TYPE_PIIX3_XEN_DEVICE >>> >> >> >>> >> >>   hw/i386/pc_piix.c             | 34 ++++++++++++++++-- >>> >> >>   hw/i386/xen/xen-hvm.c         |  9 +++-- >>> >> >>   hw/isa/piix.c                 | 66 +---------------------------------- >>> >> > >>> >> > This file does not exist on the Qemu master branch. >>> >> > But hw/isa/piix3.c and hw/isa/piix4.c do exist. >>> >> > >>> >> > I tried renaming it from piix.c to piix3.c in the patch, but >>> >> > the patch set still does not apply cleanly on my tree. >>> >> > >>> >> > Is this patch set re-based against something other than >>> >> > the current master Qemu branch? >>> >> > >>> >> > I have a system that is suitable for testing this patch set, but >>> >> > I need guidance on how to apply it to the Qemu source tree. >>> >> >>> >> You can ask Bernhard to publish a branch with the full work, >>> >> >>> >> >>> >> Hi Chuck, >>> >> >>> >> ... or just visit https://patchew.org/QEMU/20230102213504.14646-1-shentey@gmail.com/ . There you'll find a git tag with a complete history and all instructions! >>> >> >>> >> Thanks for giving my series a test ride! >>> >> >>> >> Best regards, >>> >> Bernhard >>> >> >>> >> or apply each series locally. I use the b4 tool for that: >>> >> https://b4.docs.kernel.org/en/latest/installing.html >>> >> >>> >> i.e.: >>> >> >>> >> $ git checkout -b shentey_work >>> >> $ b4 am 20221120150550.63059-1-shentey@gmail.com >>> >> $ git am >>> >> ./v2_20221120_shentey_decouple_intx_to_lnkx_routing_from_south_bridges.mbx >>> >> $ b4 am 20221221170003.2929-1-shentey@gmail.com >>> >> $ git am >>> >> ./v4_20221221_shentey_this_series_consolidates_the_implementations_of_the_piix3_and_piix4_south.mbx >>> >> $ b4 am 20230102213504.14646-1-shentey@gmail.com >>> >> $ git am ./20230102_shentey_resolve_type_piix3_xen_device.mbx >>> >> >>> >> Now the branch 'shentey_work' contains all the patches and you can test. >>> >> >>> >> Regards, >>> >> >>> >> Phil. >>> >> >>> > >>> >Hi Phil and Bernard, >>> > >>> >I tried applying these 3 patch series on top of the current qemu >>> >master branch. >>> > >>> >Unfortunately, I saw a regression, so I can't give a tested-by tag yet. >>> >>> Hi Chuck, >>> >>> Thanks for your valuable test report! I think the culprit may be commit https://lists.nongnu.org/archive/html/qemu-devel/2023-01/msg00102.html where now 128 PIRQs are considered rather than four. I'll revisit my series and will prepare a v2 in the next days. I think there is no need for further testing v1. >>> >>> Thanks, >>> Bernhard >> >>Hi Bernhard, >> >>Thanks for letting me know I do not need to test v1 further. I agree the >>symptoms are that it is an IRQ problem - it looks like IRQs associated with >>the emulated usb tablet device are not making it to the guest with the >>patched v1 piix device on xen. > > All PCI IRQs were routed to PCI slot 0. This should be fixed in v2 now. > >>I will be looking for your v2 in coming days and try it out also! > > Thank you! Here it is: https://patchew.org/QEMU/20230104144437.27479-1-shentey@gmail.com/ That fixed it! I added my Tested-by tag to the last patch of v2: [PATCH v2 6/6] hw/isa/piix: Resolve redundant TYPE_PIIX3_XEN_DEVICE AFAICT, v2 is is ready to go! Best regards, Chuck From xen-devel-bounces@lists.xenproject.org Wed Jan 04 17:00:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 17:00:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471352.731170 (Exim 4.92) (envelope-from ) id 1pD77X-0006tO-MR; Wed, 04 Jan 2023 17:00:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471352.731170; Wed, 04 Jan 2023 17:00:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD77X-0006tH-Ik; Wed, 04 Jan 2023 17:00:07 +0000 Received: by outflank-mailman (input) for mailman id 471352; Wed, 04 Jan 2023 17:00:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD77V-0006rD-PN for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 17:00:06 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3a646905-8c51-11ed-91b6-6bf2151ebd3b; Wed, 04 Jan 2023 18:00:03 +0100 (CET) Received: from mail-bn1nam02lp2048.outbound.protection.outlook.com (HELO NAM02-BN1-obe.outbound.protection.outlook.com) ([104.47.51.48]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Jan 2023 11:59:47 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by PH0PR03MB6915.namprd03.prod.outlook.com (2603:10b6:510:169::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Wed, 4 Jan 2023 16:59:44 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5944.019; Wed, 4 Jan 2023 16:59:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3a646905-8c51-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1672851603; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=xrAHntuMP5McfeZATKKyDoJutzM7llCarZaRHoOccBo=; b=GsCy6fBXA/QWL9tJpZZZOcOxikYpWhWl+NXNWJhXRlVvlYgSVIHx1dNi XrvTcEvMvWR4K08OhdEgDBkNcohkpJf8u5BGhWJ1KIylLmNVB8rriiWiL kmXHsqC3jLJ3d80J9uRTDg2rcSk8fsqu6JIyhhKyxwyemtX8g09Q9XLT2 A=; X-IronPort-RemoteIP: 104.47.51.48 X-IronPort-MID: 90660050 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:aOg0rq/Wp2unswfPhhRRDrUDon+TJUtcMsCJ2f8bNWPcYEJGY0x3n zRJXD+Oaa2KY2vyLo0gbY6woRwB6pPSmtAxHlBo+Hw8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKucYHsZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kIx1BjOkGlA5AdmPKgX5AO2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDkli1 qU8eTlTQSndmu2t5/G3aPRGnvUKeZyD0IM34hmMzBn/JNN+G9XpZfyP4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWKilAhuFTuGIO9ltiibMNZhEuH4 EnB+Hz0GEoyP92D0zuVtHmrg4cjmAuqANxMTOXlrpaGhnWt1FAKAiUrW2HlrMGGo1zuHMpZJ kALr39GQa8asRbDosPGdx+yrWOAvxUcc8FNCOB84waIooLL5y6JC25CSSROAPQ2uclzSTE02 1uhm9LyGScpoLCTUWia9LqfsXW1Iyd9EIMZTSoNTA9A6d+6pog21kjLVow7TP7zicDpEzbtx TzMtDI5m7gYkc8M0eO84EzDhDWv4JPOS2bZ+znqY45s1SshDKbNWmBiwQOEhRqcBO51lmW8g UU= IronPort-HdrOrdr: A9a23:Jkg7F65PcBHunGa94gPXwPLXdLJyesId70hD6qkmc20zTiX+rb HMoB1773/JYVkqM03I9errBEDiexLhHPxOjrX5Zo3SODUO0VHARL2Ki7GO/9SKIUPDH4BmuZ uJ3MJFebvN5fQRt7eZ3OEYeexQpeW6zA== X-IronPort-AV: E=Sophos;i="5.96,300,1665460800"; d="scan'208";a="90660050" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jxr6a4sdIJQV44zu1DxtIYp1Uvlu9RS5PQGirXM/MCsBCs5JCLfjvs99ltfklQHA1XQBwnLiG/z0GOnIg6hxaZ3RgRKKIEagaARTv3Zz7BXwfTSxVCu0/EpigYQCAEbGbLsXquokjTj418vJ8jHpifypR6Gb3HOVQESOJWevD0pR5nI3S8DG27I5Bd365hLXMMB9WmEZQ8vvmXC+1UweTRDXKLtkIFkwcbPCYiXPJbV9mwfvr25WE5uOwdNvDa/xONHb/MgO4vSn4Tqt2pPl7YQVDAdt2cpp1ghIUIwO/u+uOckU+RTBdVQjLUZOnhYaGS26OwATDg60puQW7Ssr0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xrAHntuMP5McfeZATKKyDoJutzM7llCarZaRHoOccBo=; b=ToNgNzYGJpYf1P2q9NKt2gq3c1S1+BTAvxLg68hycriFkS3/JL6H6gbyTBFvmRm//BVl0aYqz2C/b2eIUZ6TF89n1DN/klrdaVScN8uXBZ8bdFMsx5Vc2HZw0FPp/pwlXCD4d5OelpP+uXp8LVKLbjd9TTfOP4YrtlwncENq3Qm6NeNl4YPIM9tBbYrcbAl9mEQTKCE3LpQuWA2z9VMyNmB81K1KU10CRJP0J/qNQOxFlDxZYnzStnMn7bxLKbpqSQmIWvp1F5v0rdnCAn753r0sAWLhb4oVqFyBkECxPIDNEhTmU7h07yZmr8kUMJ1PdUXmVrKIm2bxtcZtIcjZDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xrAHntuMP5McfeZATKKyDoJutzM7llCarZaRHoOccBo=; b=miNCeBRt/YYCbyQkuRD6PDVVikFqHO6mDYb2yb2LTtZKBJKGyAsvoJb2vL6M9Hiy1GUXrEzPhWc0UmMk47LQAEM0Au34+ZDIQJd/lXb+7xyAB9xMfro0qJR9R4ENY1UwdCfraFh+5LBGtinIsGRCvINo3vnT/06diirN8UUAl04= From: Andrew Cooper To: Jan Beulich CC: Roger Pau Monne , Wei Liu , Xen-devel Subject: Re: [PATCH 2/2] x86/shskt: Disable CET-SS on parts susceptible to fractured updates Thread-Topic: [PATCH 2/2] x86/shskt: Disable CET-SS on parts susceptible to fractured updates Thread-Index: AQHZIC1dxLDr/Ft5R0KgtQNaFohPLq6OZp8AgAAU6IA= Date: Wed, 4 Jan 2023 16:59:44 +0000 Message-ID: References: <20230104111146.2094-1-andrew.cooper3@citrix.com> <20230104111146.2094-3-andrew.cooper3@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|PH0PR03MB6915:EE_ x-ms-office365-filtering-correlation-id: b9488f9f-af29-4686-6ca4-08daee751411 x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hN32oQmD6AB1vGKL39bquuQ7vYQZaCnslXqufOVKmRpZDSKCHUCg0XTLPYSpFKDwA7tAjlbwr1D5nUxlSpHAbmcrFa03okjrNDlWB4HJdS8+UwPLOXJ36DpHOlgMmRbY1djYP+JxfbekW2t39Z605FApvxjATJ5Z4qneC3GUPdIfZ7t6OD8keanwTko4DxrQAz4eJffqmRx59C18CLcQKe9BhsvixSf9XJLtuH7htx3A3Rr7EgqycmIdh8v8We+P2ITJXPj/EHNzaZlkyiVXgKysuzSZr1VmLvhg6V7MGljyQHhznpJK+P9bUgm1IVoPvF9OzsaYaOFE7dabO3eKcWpSeqnNlldEWiRH1uVz18jGjLEu409lsD2qiyk5dhjrX2AuKmm+kFTWoSHERayW4c7PgXGatTLF0TPcTe9ru3Vf4vqjmHX2WJ2SqPUHXI4PkAeXvXl6u5pK3k0bW+11o+bzT+S77xjokeUX2AxjqsQ954jW6vASzu/e3YwQ4M1qvc+2D1iVweagVOpqPOTZtvgwjL8b1vUmcBMHyHMjaWme+o2ZKGp4OHnI8HKumjWb4mf634+j29ex1ro7cOV/p3lHNTFTZA5wZD8p4RCX4o4H7+kHNaLIt/xxjEzbVwzjw5HdHSwfuksAfUiB+HdaOCfoA1UpptJRg0AfcDdqe3GLqVsG0t5TvO3ywUsFMoKXnW7b8V+IC8xtJ0EQKY5Y0MmHDuqKUOlFtzmUaFo3XtjNX3BtVF+Nvv3+ng1iptDQtQbh9bkUhA3jdWCSWRnLHw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(366004)(396003)(136003)(376002)(451199015)(5660300002)(2906002)(15650500001)(8936002)(41300700001)(4326008)(478600001)(316002)(8676002)(66899015)(54906003)(66476007)(66946007)(76116006)(6916009)(66446008)(91956017)(64756008)(66556008)(71200400001)(6486002)(31686004)(6512007)(26005)(6506007)(83380400001)(122000001)(82960400001)(186003)(38100700002)(53546011)(2616005)(31696002)(86362001)(38070700005)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?eTdlUnlPb1dpYnJ1QUtCOVZtS2l3d0NVcjc3SlJOK0k0U0RCcHVNem1EVkQ5?= =?utf-8?B?cjJHQlJ2SXVKeC8waFZueWhGaExFOURmeWlTZ2hFNWZVTFpTTERuSk8vWCs5?= =?utf-8?B?bnJQcXVEVCt0RnRKeU15SEpJYnVkYnp1azVPNEdwOWQyWjJ0ak9LVllvd1RN?= =?utf-8?B?dHRwdSs3cUdTUzM5WnpjZ2RDZVdaaUJodW1SaE5MMkVhUnNJQjBQWGc3enky?= =?utf-8?B?bnd1dE1abW5HMUcrQjFScWpUOVNJVHRwQ29GeUJZT0NGWWpsNzlFL0QxSnBy?= =?utf-8?B?TDNHNmhVbkdiTi85WnN3blFzNy84NHh6dXlnbzNZNVlJZTdkWXBhZ2NwTWFu?= =?utf-8?B?L1preVA1cGJyMzI4b05QU3RoNTUwdENuRnN5a2VpWDY2NGIyNy8zaXlNZ1dE?= =?utf-8?B?Wlk1N1JsL2NOZzA3blRaWEhGVFRRK1Q2R0ticzBuN0lhc0Nkd0MyeGZvcFFa?= =?utf-8?B?RlVvV24rb3hXWmdFeGF0cU9HbTFNckpvakx5N1RHeVhhNkRsdVZOWjg2T3Yr?= =?utf-8?B?VERwL0ZGSjdaK3Ewc3NRYktkTCtxREtkbVYxMkRnbk1CQWxRcjM1TW9vVUdt?= =?utf-8?B?U2ZhMkxjemN0d0tVWi9QYnpBdERNanNPSUp3U0h4blFNM1RSRG90WGVDK0la?= =?utf-8?B?Y25PaXN1YXVwYWtqaVdIdTB0dTE5Vmc0c2U2YW1XdTlrR3VvRFNKRHRJcnpa?= =?utf-8?B?OWc5TFh2ZHFFQ3h2eEE2K29naHc4SHZ5SGRqODh4M0ZuRFBIR3JQM0dJcXFY?= =?utf-8?B?QTNGM1RVSzBLUUVFOUl6UGEvdzVMWGd5aHNBc0NGTFYvc0krNncxWDUxeks5?= =?utf-8?B?bEJpY0NNdjBzUlNUL2JKME02UWJ4QWI1cW5EeS9taXJjOEI0UXFJZ0ZlUnhy?= =?utf-8?B?Z0dkTXZXWTM1KzNsdTU5UHZaWmxaTkkvM3VIVlFwQVVBd2toYzRyUWtFcXh4?= =?utf-8?B?bmM4dFRoVmZpUmM4NE1lci92WVhoOUxqQUQ3SzZ1bTA0d1QwZ2RrUi9EUEt2?= =?utf-8?B?V3FFbTRsNWxmRklVRWdZa1ZySEUwTzczU3kyVExLanhWT1cxTUZDR0sxUEp5?= =?utf-8?B?YVJ4WGxDRWdQcVoxajlKN2FZb0w3SjFHeE9pOVJNanZqdTR3Tkxpb3RsR1lT?= =?utf-8?B?c2FRZ1ZHek1pUDE1QmJpTVlCMS9Ya0lIYm94MzJkK2tRSzhMVnhoaU9VUmFn?= =?utf-8?B?c3pmc2l5d3FhU0NXbU1BN1RWWE41dC9iTmwzOFQyTEJFSjNqQWVlSSs1Rjlz?= =?utf-8?B?Qnlhbi9oRmZWUDg5NXF3SmJOZ0Jmd3IwdDNaeWd1bkwyaVd1bjgvWk5lSE1r?= =?utf-8?B?ZjU5UnBhZEdVWnEyWEFKaXdLckQ5VTVnc05ML3lBVEdOU2owWS84eTU0K3hm?= =?utf-8?B?WVVCNnJEVHJ4eTFLVXhlV0FNeU1xdUswUytCNTN6Z3J4SkluUEhRRWJRVWhU?= =?utf-8?B?aTFqQmMxWFRPVEx1ckdKWStOVC9uM3NVOStxcUdkZXUvK1pMOUtpUWc0NmdI?= =?utf-8?B?MTh3MTBOZVY3OTRtLzBxL3JZK2tJeWlUK0dGT2ZZYW83NWNhaEFwaksveTl3?= =?utf-8?B?RTBpb2VhMXpYRGlOeTdTRWVqZ29YdnE3VWdsUEpLWmF3TUtIcUNPcllSTm9w?= =?utf-8?B?Y0k2UkhSWDhieXViQTQ3VmJCMlpCc0twUWJvWkJPc011d2RZSEdPRU0rTjdY?= =?utf-8?B?aCtIZmdnY0Z6WnFpZTN5VFFoR1F1blVVTzhEdk1FbkMvbVAreTB5QmdMbjdu?= =?utf-8?B?SzVmVnpxMVg0TUZ6YzUrTEcwWmR0TUtwK1JmdkNoVkxXR1JqQWdYK2VJdVdw?= =?utf-8?B?Zjd6ZHV5a3BCTERiQStyUkc4ZFd6emtzcUJDUnpvbmVMWTJMOTBxR2taVm5Y?= =?utf-8?B?KzI1MGxQb0hWL2dFZlc2MUpCcHExaC9nREQ4WHQ5dHlLM2pwbXJteTNqQUJa?= =?utf-8?B?dXplcDRrQjkyWVV4MFhDaXgzd3BlS201bjN2L3BzTXArTWVQYk56VWlTTXpC?= =?utf-8?B?SkNXbHltZzdXTVhEZjBHakVoTXhlc2JSL3phMnhMOEdwcWU2VVpwQkFSY3hM?= =?utf-8?B?cVk4QkdaemdUdjVKNFRRN3dWeUJKUEladVNCaXdTd1hjb0hGOElTWlY5SE05?= =?utf-8?Q?p49Szy75yyPJgEyy20G9OzKmL?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 7p8ZOtUCv7y8d/UkurIzYx1RfNhhYdtZQDeDqwVLB7oIgV+COjt9D0AIUXHnnbUSMJUoITrFRksTNpTPljwnXQlYka9YNx8q/H87h+wc5MU4kBfhbdJ5hOfeA8ZjcGEDX451NRGrNV+HlMXeccMKRAT+ogoTI3/XZpio2U6wXuZ/A7cqsK6Hx7PnJ+9VAuGxT2lI3dFDA54b4SQfoJOdojmykQ/r4ZjxmzXjNRj+BNq3SI1MG/uclgPU1yeP+029AyAQJfe4xtT4X/dRanTQi3KuX+IBj79lTq+mT0O9XaSc38w2lufde2YbiKyJRei888V35UQ2W8JCtjqEe5tz6TikkRw3hOgbzzZsBhj5fMgVZh+2yrJmfHMufPdnJRaRKoBpyBU5o/fFj7qhdzSk+pFGzXdugnGLGoR/kqVHDE8P0hn2V6ayjGid+yjR7nB8xCHnl+15naudTCdwPlfYjuXxNG8mf5m2W84CMGyDe3P0cjPvhburlEqndnyJ6I9XNrDD10APdKiMt4AdFtZGKtotHL7qGcgy1w93+NnMiOTWLmLFUkrtRvQ0JZnWSBiexks3LQJ8inYs90IgPlVxcSZT/lKv5majQM+ufz2TVE9QiHHBhp8/qFN09vimTTpwrR0vNUenuvW2DGvpBV3+Jrs5EZIXzti6vD1d14NE7ovQFkcHclk4V/q82eZ6aRm1c2aLcVBwJ9a9+5FfcYx/Njg3ZPknwa+jS9pFNGq6HhHqNzUOZYlnMfM95HugjIUvJSlqQ2h3idjX3xPxMuZu07b3EEp1SUDXx3uLHy9CFDmRznpD1mMftVCoOPVLIjfW X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b9488f9f-af29-4686-6ca4-08daee751411 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jan 2023 16:59:44.1148 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Pjdcl2Jd0jlpdPr+atwBr5QxKS8LShKPlj9cQjsEPygoo+C9x62eMN2oMpnLBepmEt9ltDd44ccO4qlt8+88RFMM+eFo5/s799B+TCSwfDA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6915 T24gMDQvMDEvMjAyMyAzOjQ0IHBtLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMDQuMDEuMjAy MyAxMjoxMSwgQW5kcmV3IENvb3BlciB3cm90ZToNCj4+IFJlZmVyIHRvIEludGVsIFNETSBSZXYg NzAgKERlYyAyMDIyKSwgVm9sMyAxNy4yLjMgIlN1cGVydmlzb3IgU2hhZG93IFN0YWNrDQo+PiBU b2tlbiIuDQo+Pg0KPj4gQXJjaGl0ZWN0dXJhbGx5LCBhbiBldmVudCBkZWxpdmVyeSB3aGljaCBz dGFydHMgaW4gQ1BMPDMgYW5kIHN3aXRjaGVzIHNoYWRvdw0KPj4gc3RhY2sgd2lsbCBmaXJzdCB2 YWxpZGF0ZSB0aGUgU3VwZXJ2aXNvciBTaGFkb3cgU3RhY2sgVG9rZW4gKHNldHRpbmcgdGhlIGJ1 c3kNCj4+IGJpdCksIHRoZW4gcHVzaGVzIENTL0xJUC9TU1AuICBPbmUgZXhhbXBsZSBvZiB0aGlz IGlzIGFuIE5NSSBpbnRlcnJ1cHRpbmcgWGVuLg0KPj4NCj4+IFNvbWUgQ1BVcyBzdWZmZXIgZnJv bSBhbiBpc3N1ZSBjYWxsZWQgZnJhY3R1cmluZywgd2hlcmVieSBhIGZhdWx0L3ZtZXhpdC9ldGMN Cj4+IGJldHdlZW4gc2V0dGluZyB0aGUgYnVzeSBiaXQgYW5kIGNvbXBsZXRpbmcgdGhlIGV2ZW50 IGluamVjdGlvbiByZW5kZXJzIHRoZQ0KPj4gYWN0aW9uIG5vbi1yZXN0YXJ0YWJsZSwgYmVjYXVz ZSB3aGVuIGl0IGNvbWVzIHRpbWUgdG8gcmVzdGFydCwgdGhlIGJ1c3kgYml0IGlzDQo+PiBmb3Vu ZCB0byBiZSBhbHJlYWR5IHNldC4NCj4+DQo+PiBUaGlzIGlzIGZhciBtb3JlIGVhc2lseSBlbmNv dW50ZXJlZCB1bmRlciB2aXJ0LCB5ZXQgaXQgaXMgbm90IHRoZSBmYXVsdCBvZiB0aGUNCj4+IGh5 cGVydmlzb3IsIG5vciB0aGUgZmF1bHQgb2YgdGhlIGd1ZXN0IGtlcm5lbC4gIFRoZSBmYXVsdCBs aWVzIHNvbWV3aGVyZQ0KPj4gYmV0d2VlbiB0aGUgYXJjaGl0ZWN0dXJhbCBzcGVjaWZpY2F0aW9u LCBhbmQgdGhlIHVhcmNoIGJlaGF2aW91ci4NCj4+DQo+PiBJbnRlbCBoYXZlIGFsbG9jYXRlZCBD UFVJRC43WzFdLmVjeFsxOF0gQ0VUX1NTUyB0byBlbnVtZXJhdGUgdGhhdCBzdXBlcnZpc29yDQo+ PiBzaGFkb3cgc3RhY2tzIGFyZSBzYWZlIHRvIHVzZS4gIEJlY2F1c2Ugb2YgaG93IFhlbiBsYXlz IG91dCBpdHMgc2hhZG93IHN0YWNrcywNCj4+IGZyYWN0dXJpbmcgaXMgbm90IGV4cGVjdGVkIHRv IGJlIGEgcHJvYmxlbSBvbiBuYXRpdmUuDQo+IElPVyB0aGF0J3MgdGhlICJjb250YWluZWQgaW4g YW4gYWxpZ25lZCAzMi1ieXRlIHJlZ2lvbiIgY29uc3RyYWludCB3aGljaCB3ZQ0KPiBtZWV0LCBh aXVpLg0KDQpGb3IgcHJhY3RpY2FsIHB1cnBvc2VzLCBpdCBpcyAiY29udGFpbmVkIHdpdGhpbiBh IHNpbmdsZSBjYWNoZSBsaW5lIi4NCg0KQU1EJ3MgcG9zaXRpb24gaXMgImlmIHRoZSBPUyBkb2Vz bid0IGhhdmUgc3VpdGFibGUgYWxpZ25tZW50LCBvciBkb2Vzbid0DQpwbGFjZSB0aGUgc2hzdGsg b24gV0IgbWVtb3J5LCBpdCBnZXRzIHRvIGtlZXAgYW55IHJlc3VsdGluZyBwaWVjZXMiLsKgDQpU aGV5IGhhdmUgY29uZmlybWVkIHRoYXQgaWYgdGhlcmUgaXMgc3VpdGFibGUgYWxpZ25tZW50IGFu ZCBpdCBpcyBvbiBhDQpXQiBtYXBwaW5nLCB0aGVuIG5vIHZtZXhpdCBjYW4gb2NjdXIgd2hpY2gg d291bGQgZnJhY3R1cmUgdGhlIHRoZSBzaGFkb3cNCnN0YWNrLg0KDQpJbnRlbCByZXRyb2FjdGl2 ZWx5IHRpZ2h0ZW5lZCB0aGUgY29uc3RyYWludHMgaW4gbWljcm9jb2RlIG9uIFRHTC9BREwgc28N CnRoYXQgTVNSX1BMP19TU1AgKG9yIElTU1QgcG9pbnRlcnMgZnJvbSBtZW1vcnkpIHdvdWxkIHN1 ZmZlciAjR1AgaWYgdGhleQ0KZGlkbid0IHJlZmVyIHRvIHRoZSB0b3Agd29yZCBpbiBhbiBhbGln bmVkIDMyLWJ5dGUgcmVnaW9uLg0KDQpCdXQgdGhpcyBwcm92aWRlIHRvIGJlIGluc3VmZmljaWVu dCB0byBmaXggdGhlIHByb2JsZW0sIGhlbmNlIHRoZSBuZXcNCkNQVUlEIGJpdCwgYW5kIHJlY29t bWVuZGF0aW9uIHRvIGRpc2FibGUgc3VwZXJ2aXNvciBzaGFkb3cgc3RhY2tzIGJ5DQpkZWZhdWx0 IHVuZGVyIHZpcnQuDQoNCj4+IERldGVjdCB0aGlzIGNhc2Ugb24gYm9vdCBhbmQgZGVmYXVsdCB0 byBub3QgdXNpbmcgc2hzdGsgaWYgdmlydHVhbGlzZWQuDQo+PiBTcGVjaWZ5aW5nIGBjZXQ9c2hz dGtgIG9uIHRoZSBjb21tYW5kIGxpbmUgd2lsbCBvdmVycmlkZSB0aGlzIGhldXJpc3RpYyBhbmQN Cj4+IGVuYWJsZSBzaGFkb3cgc3RhY2tzIGlycmVzcGVjdGl2ZS4NCj4+DQo+PiBTaWduZWQtb2Zm LWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPg0KPiBSZXZpZXdl ZC1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPiB3aXRoIG9uZSBuaXQgKGJl bG93KS4NCj4NCj4+IFRoaXMgaWRlYWxseSB3YW50cyBiYWNrcG9ydGluZyB0byBYZW4gNC4xNC4g IEkgaGF2ZSBubyBpZGVhIGhvdyBsaWtlbHkgaXQgaXMNCj4+IHRvIG5lZWQgdG8gYmFja3BvcnQg dGhlIHByZXJlcXVpc2l0ZSBwYXRjaCBmb3IgbmV3IGZlYXR1cmUgd29yZHMsIGJ1dCB3ZSd2ZQ0K Pj4gYWxyZWFkeSBoYWQgdG8gZG8gdGhhdCBvbmNlIGZvciBzZWN1cml0eSBwYXRjaGVzLiAgT1RP SCwgSSBoYXZlIG5vIGlkZWEgaG93DQo+PiBlYXN5IGl0IGlzIHRvIHRyaWdnZXIgaW4gbm9uLXN5 bnRoZXRpYyBjYXNlcy4NCj4gUGx1czogSG93IGxpa2VseSBpcyBpdCB0aGF0IFhlbiBhY3R1YWxs eSBpcyB1c2VkIHZpcnR1YWxpemVkIGluIHByb2R1Y3Rpb24/DQoNCkFsbCBvZiBvdXIgZ2l0bGFi IHNtb2tlIHRlc3RzLCBhIGxhcmdlciBwYXJ0IG9mIFF1YmVzT1MncyBDSSwgYW5kDQpub24tZGVm YXVsdCBQVi1zaGltIGNvbmZpZ3VyYXRpb25zLg0KDQpBcyBzb29uIGFzIHdlIGdldCBndWVzdCBD RVQgd29ya2luZywgdGhlbiBwYXJ0IG9mIE9TU3Rlc3QsIGFuZCBhIHBvcnRpb24NCm9mIFhlblNl cnZlcidzIGdlbmVyYWwgdGVzdGluZyB0b28uDQoNCkl0IGRvZXMgbmVlZCBiYWNrcG9ydGluZyB0 byBhbGwgZ2VuZXJhbCBzdXBwb3J0IHRyZWVzLsKgIChXaGVuIEkgZmlyc3QNCnN0YXJ0ZWQgd29y a2luZyBvbiB0aGlzIHByb2JsZW0gd2l0aCBJbnRlbCwgdGhhdCB3b3VsZCBoYXZlIGluY2x1ZGVk DQo0LjE0IHRvby4uLikNCg0KPj4gQEAgLTEwOTksMTEgKzEwOTUsNDUgQEAgdm9pZCBfX2luaXQg bm9yZXR1cm4gX19zdGFydF94ZW4odW5zaWduZWQgbG9uZyBtYmlfcCkNCj4+ICAgICAgZWFybHlf Y3B1X2luaXQoKTsNCj4+ICANCj4+ICAgICAgLyogQ2hvb3NlIHNoYWRvdyBzdGFjayBlYXJseSwg dG8gc2V0IGluZnJhc3RydWN0dXJlIHVwIGFwcHJvcHJpYXRlbHkuICovDQo+PiAtICAgIGlmICgg b3B0X3hlbl9zaHN0ayAmJiBib290X2NwdV9oYXMoWDg2X0ZFQVRVUkVfQ0VUX1NTKSApDQo+PiAr ICAgIGlmICggIWJvb3RfY3B1X2hhcyhYODZfRkVBVFVSRV9DRVRfU1MpICkNCj4+ICsgICAgICAg IG9wdF94ZW5fc2hzdGsgPSAwOw0KPj4gKw0KPj4gKyAgICBpZiAoIG9wdF94ZW5fc2hzdGsgKQ0K Pj4gICAgICB7DQo+PiAtICAgICAgICBwcmludGsoIkVuYWJsaW5nIFN1cGVydmlzb3IgU2hhZG93 IFN0YWNrc1xuIik7DQo+PiArICAgICAgICAvKg0KPj4gKyAgICAgICAgICogU29tZSBDUFVzIHN1 ZmZlciBmcm9tIFNoYWRvdyBTdGFjayBGcmFjdHVyaW5nLCBhbiBpc3N1ZSB3aGVyZWJ5IGENCj4+ ICsgICAgICAgICAqIGZhdWx0L1ZNRXhpdC9ldGMgYmV0d2VlbiBzZXR0aW5nIGEgU3VwZXJ2aXNv ciBCdXN5IGJpdCBhbmQgdGhlDQo+PiArICAgICAgICAgKiBldmVudCBkZWxpdmVyeSBjb21wbGV0 aW5nIHJlbmRlcnMgdGhlIG9wZXJhdGlvbiBub24tcmVzdGFydGFibGUuDQo+PiArICAgICAgICAg KiBPbiByZXN0YXJ0LCBldmVudCBkZWxpdmVyeSB3aWxsIGZpbmQgdGhlIEJ1c3kgYml0IGFscmVh ZHkgc2V0Lg0KPj4gKyAgICAgICAgICoNCj4+ICsgICAgICAgICAqIFRoaXMgaXMgYSBwcm9ibGVt IG9uIGJhcmUgbWV0YWwsIGJ1dCBvdXRzaWRlIG9mIHN5bnRoZXRpYyBjYXNlcyBvcg0KPj4gKyAg ICAgICAgICogYSB2ZXJ5IGJhZGx5IHRpbWVkICNNQywgaXQncyBub3QgYmVsaWV2ZWQgdG8gcHJv YmxlbS4gIEl0IGlzIGEgbXVjaA0KPiBOaXQ6ICIuLi4gdG8gYmUgYSBwcm9ibGVtLiINCg0KRml4 ZWQsIHRoYW5rcy4NCg0KfkFuZHJldw0K From xen-devel-bounces@lists.xenproject.org Wed Jan 04 17:04:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 17:04:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471359.731181 (Exim 4.92) (envelope-from ) id 1pD7Bt-0007WA-6Q; Wed, 04 Jan 2023 17:04:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471359.731181; Wed, 04 Jan 2023 17:04:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD7Bt-0007W3-3G; Wed, 04 Jan 2023 17:04:37 +0000 Received: by outflank-mailman (input) for mailman id 471359; Wed, 04 Jan 2023 17:04:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD7Bs-0007Vx-0y for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 17:04:36 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on2089.outbound.protection.outlook.com [40.107.14.89]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id dc43f200-8c51-11ed-b8d0-410ff93cb8f0; Wed, 04 Jan 2023 18:04:33 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB9676.eurprd04.prod.outlook.com (2603:10a6:10:308::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Wed, 4 Jan 2023 17:04:31 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5944.019; Wed, 4 Jan 2023 17:04:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dc43f200-8c51-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XPyu6UHebCGyvPMdGlvnMEOnCDrvTE0VjL6ZB9MToYvCOMmiOr8T4r296TNmDVAdTo9yq4wNhBQZCNuNlHRbevMjX6FWpYGIK9G11Ent188TDy2cLu61byLLjJ/oGb5HBMiDgUI6EXWowexnIf1EMzoe3twddbIpK+RGQUJ1+xaJiFZKQ1mBZ9cWlZWllbX6LTzPCt7CmMLgrdtoLdkdbP0eDUJQzaXq0qNIXMr7J5ec9i0i9Bodt6CMnFJVhihdhF3OpHyWaeWWr4GChZpyUjCI4kL+U2nTqDX5aBqeBw+uFjw2ZFwFp+HdpnSbdR77JUeMLjXx0Iklfk5PsTmgPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cTxVePJt05zGmcAekCz40ZmvpoevLyoOtQJxIKsCzm8=; b=E0vNktuH22uBUt5578eWUBpsB0n8QttkP2ZI/s84JPB0tDgQNN7H4mMyEoazdaeoRWnVQB/7SWMXsqFvqlE9SnlIgdco5a1UI71dfAT4xaHJN3wpNr+PykVnlM0Ob8GG3I2VQ+wce+vf2SKOX0QR7rj1lXqiAMpwXA/BX8/Adso9gFDObWL5EVVkiwPu66uaEk1wFHZLZptN5Zx1o60yXQIBRCMex8JcYR7kQFzpdFeIj4V3m89EkmBxO5aKvLroKeO55nHsaZuwW2ptXoFGSMTKszXwku59qhUO01YaDeGcqzvVUA+WQ462PgVsBcRfeOuMbaQdQcDI4G+ir63FGw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cTxVePJt05zGmcAekCz40ZmvpoevLyoOtQJxIKsCzm8=; b=Sny63Sz/PpvfUFjXIIbGh1AoyCy2k0tXOXKfrniijkccUmGotk7lY4wQnx001USzfLHohpUxTvXPCdZWpfEK/qmvFpL2cWeKaSBkEOf+aMKfyD7mpxUPUfSjmEgmzN7bRRSFyBpCOAq7lIQQWt74+zwiwtrHU0JCK4wWVttRtAVf3VSV5/mK4MZi+LdRAsTsM7Edt3W6B2u1ybymH50iRZsb1+oXA+iExVCuAJ5uiyQbjGamYhXDJCyshQ/GEbE2jgBoBM5d7njKuZRG7II//YHTpqqgAFWZv5FRNXhssiDnYd6D8YQTFiIQE49D1f5IYjsCYsqyTsMV0AlP9VOxOg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 4 Jan 2023 18:04:29 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 4/4] xen/version: Introduce non-truncating XENVER_* subops Content-Language: en-US To: Andrew Cooper Cc: George Dunlap , Stefano Stabellini , Wei Liu , Julien Grall , Xen-devel References: <20230103200943.5801-1-andrew.cooper3@citrix.com> <20230103200943.5801-5-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20230103200943.5801-5-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0092.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a9::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB9676:EE_ X-MS-Office365-Filtering-Correlation-Id: a85aab11-6941-48cd-78aa-08daee75bee8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MMUfiKKMjf9g2sg6L3bMGYcH8OxT3stgJaBjqVMQslzvgzAJZdrKe3lvUo9MpKSyJEl49dAEq8JGq2PGtu4PQedWJqJICa70+ymQ2xWtQzuYWUu0SEDHKaKsYBBMzkPLhSMwjfSubnljX/wPZqq5dSayrAQkHpGUBQ3E5k2fUKbg3bWdH1mSYV/pq2XMJhtkDe0brdz7wSmpiJSyJxPqHqprp4EYW72qF4rrxzALnNr5xU2rBL4JWcyEsug1dUadbT0ky/YB3fTuI6HGRSazU+j62nWeBCDzo5BAM3Uv+97d2yYxplAUPLEVlWTZ5MHgBqR05E1jtKN5sKnHufZOgV77dqpamsEAcKMgQgBac69XTADbGozjC4Jmb5LaIHyo1AKCyvfldYXZMtrUrGC2/CKlOIveg05nKWUBOOvguwOLMFSZrhmmauO9T+NYQn0qygj6/xkIMYkoFaas6cZeYQOMSd/kinZOXnbhNEVf0z7Lmc+MVp37SEQQrrwIxiudRCiSp/1NDZKGYlmjlkSNdI5VgWdrdtBBzeG1qcDpDqJi9mG4XpjvrHhdisCPNvLLsytjlW6mLBrESg5gIZZ4HhxZv870DdvQBZTljdP9I2j+PsmfzoBenXSUlYmiR9d3y+7MtuJTleeTjyqIIiNsELMIChKaJQoCKK5Hkx0OxTPRvGpzjS1oe0XTB8xaScvLng4MkIELXZq33ppesTGD4wxcMOoWvQU7fcVWpRfFuK8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(39860400002)(366004)(396003)(136003)(376002)(451199015)(5660300002)(2906002)(8936002)(41300700001)(4326008)(478600001)(316002)(8676002)(66899015)(54906003)(66476007)(66946007)(6916009)(66556008)(6486002)(31686004)(6512007)(26005)(6506007)(83380400001)(186003)(38100700002)(53546011)(2616005)(31696002)(86362001)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZTNTNlBmLzE1cTVvSDcvZ0ExTVFUN0dCc0p0NEhRSUErNVVkSkJGemsvamFM?= =?utf-8?B?WUhlSFVUeWhQamlUclFBeDBPWGhPZ1BlWlJvS3hSTXZnUFAvTFNiN3FrTVhh?= =?utf-8?B?eS9aZHNEbzUyQk1FbzRBMExtSkVxRCtES1JsYURGSStlR1ZkclByY0syeG9n?= =?utf-8?B?RlNxVlpLdWxrdnlNMTRteWdHaHlFR05ZQlBLU2xJWDdBMFA0SHpYb0l6d0l6?= =?utf-8?B?U3paamQzS3BHN3hXU2VpWVJMbU45ME1qQlZzYzFXbDVTT2hVenBVLzZobnZT?= =?utf-8?B?NFp4SE1CMXAzaWdTeFM0MGJjK0tVVGNmMS9tclJ4dUdwQnF6aFVqazNvS1lP?= =?utf-8?B?bkQ2c0dwRjhyYkxqWitjZG5BTVJsQ1VVbFFxMHZYUVAwVEZmT1daeGFzeWZw?= =?utf-8?B?UVFJNFZTUFlCbktDMzNndDRoTDUvM3grQ29ZbVE0ZGYxMWpPdWhpb3V0YjVx?= =?utf-8?B?WjJFTjFIdFN0ZGdUdzBjOG4wQ2NYcGxUOHk0amp5M2d1eVR0Y0FNbVozNDlN?= =?utf-8?B?OGQzbHlrNmFpRFltRHFjSTFQRWhXUnFEQjRrbHhyNDVibmVOYUlJMkpueThV?= =?utf-8?B?Mno0V2NoS2VCQmNtclEzajlCNjNzNUU1MW4xdXpkcVY0a0Y0ZXp3ZEx1Y1ZD?= =?utf-8?B?bEdJTnJFUDFHdDNkQytOdFFFUHNpanUvWGtTR1J0dzZESWI1eGNzVWMzcml5?= =?utf-8?B?MnBPSWxNWHVNaStnVVZuNVorSStWcUJUeW1HTjJkaVMzZzQ3VkJhTkw4aUJv?= =?utf-8?B?ZFU5V2EvT3BReEdkTFJHOUhkckUvUy9YbU54MmI3K2o5RzVWSmVhUFg0dW00?= =?utf-8?B?ZEVPTm9rN3R2d2Q4OCtIMmZiQjVUVFRMNzZuNEJrenBzT0dwK3FOaHRWNHVB?= =?utf-8?B?emN6akp2UHFVK1lKSFpJUHVMMTFqYzRzb0NidFUveWlrSk53UW4yVnhWajRy?= =?utf-8?B?Uy80em9jRGtyZld3NTBIYUx4RTdLMDRxQi9abVh4MXFObjhSS2Y2Ylc2U3Z5?= =?utf-8?B?YWFtb2J3QVI3MnFIL3dZYjlLN1prWjg3cGlOblZQTFpmOFlON08ybnVVTC9u?= =?utf-8?B?SDU1dnpvSzdrUWNCMXRLTDUxU21heVVZWFF1aFFqVDBvSEY4c3NBdk9IbGxy?= =?utf-8?B?RUh3OUVYajVzTytlMGtOSkhVeDJsa24zcS9RZWU1elhJcytmTTU1MDlPWWEx?= =?utf-8?B?MWNic3VpUXRVb25GT2F0K0p5S3JWNGpyZ05SWGdNWDJhdGpNamJQUVhBSVU4?= =?utf-8?B?d2V2R3hieTBZUjBFU2t0aGszQzZOSkZMTjN0eHBESWIxN1lVMXJxTzdZV3FD?= =?utf-8?B?dng2UUtNYXhoRWlUKzNhMTIxSDUyK1ZDSWlQZTVVa2xNSnBoQkk5c1dzZWdI?= =?utf-8?B?alUwcmdpemFyakxtQ0VwQ1hNNEpFVXh2ekMrNjgvZXFoY2JweTlxdmhEVTN5?= =?utf-8?B?QVJkUjVkSGZndUs3OVBweG1qRVd3bGV3cFBtZUVKbWt5azdlU3B4SGtyKzZp?= =?utf-8?B?OUZKM1ZSa284UWphVXBuZm9PUXQ2Q1ptRGhlaGlrR3JhZ3FJUU1iN0N1V1pZ?= =?utf-8?B?Y2U4WjZ2NW5QN2NVSW9lY3lqWmZWOGx2cXdCM2dCNGVCQzRLZEl5KzNPQVFz?= =?utf-8?B?ZE9iVTdpQlB4ZUs1T3Q0cUdwM0c0NWtRWmtDd04xT01tR0dxNW4wRjhKTFRs?= =?utf-8?B?MGlMbzNyTEVuQ0Z1dGxsM1N0UXZmdFVneE02eTBWVStyU2VYYTBsWHpZbTdX?= =?utf-8?B?ZnBORFJKOVQxRmh0NkIxVjNxdXlkdnM3ZVFTOU1FQjBqTUJVSHJtdTFmb1M1?= =?utf-8?B?SXRjdUlZb2xJRjF6UFVxdStaZkxzbkE1OVFkTTRITkpXWGVnQmNOdmVjYlVn?= =?utf-8?B?ei9aeEJuRVVVeUVSTFp1V1JOdEtpQlhlSGhwN1c2RGNlaGJOdEczNDcvbDlw?= =?utf-8?B?WndpWFA1MFNaU2xaVzVmaDc2NHR2U0tWdkNIWUJ4ZWc1eEFycnJoelN1SmRk?= =?utf-8?B?cHA3cXRycGg5a1dydVplRTErcWZtL3RJRTNoSmJCOHJnbkdsRENMNTlsZUJk?= =?utf-8?B?dVZmbEFCQlRDMCtwblptTFV1Q2tsRnE4R3ZQSHl5YWZ0SkZlNnIxeEd4c3o3?= =?utf-8?Q?zoGubOIaoj2w0WvhHd56dG1lD?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a85aab11-6941-48cd-78aa-08daee75bee8 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2023 17:04:31.0493 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CMyhFq+BNHT8TirD4HgWUM2NNjbHyskQCtgpKWnsKSIgananpBHJGmQI9igVr68rrpBrXxceWKE5iJ0Y2vT+rw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9676 On 03.01.2023 21:09, Andrew Cooper wrote: > Recently in XenServer, we have encountered problems caused by both > XENVER_extraversion and XENVER_commandline having fixed bounds. > > More than just the invariant size, the APIs/ABIs also broken by typedef-ing an > array, and using an unqualified 'char' which has implementation-specific > signed-ness. Which is fine as long as only ASCII is returned. If non-ASCII can be returned, I agree "unsigned char" is better, but then we also need to spell out what encoding the strings use (UTF-8 presumably). > API/ABI wise, XENVER_build_id could be merged into xenver_varstring_op(), but > the internal infrastructure is awkward. I guess build-id also doesn't fit the rest because of not returning strings, but indeed an array of bytes. You also couldn't use strlen() on the array. > @@ -469,6 +470,66 @@ static int __init cf_check param_init(void) > __initcall(param_init); > #endif > > +static long xenver_varstring_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg) > +{ > + const char *str = NULL; > + size_t sz = 0; > + union { > + xen_capabilities_info_t info; > + } u; > + struct xen_var_string user_str; > + > + switch ( cmd ) > + { > + case XENVER_extraversion2: > + str = xen_extra_version(); > + break; > + > + case XENVER_changeset2: > + str = xen_changeset(); > + break; > + > + case XENVER_commandline2: > + str = saved_cmdline; > + break; > + > + case XENVER_capabilities2: > + memset(u.info, 0, sizeof(u.info)); > + arch_get_xen_caps(&u.info); > + str = u.info; > + break; > + > + default: > + ASSERT_UNREACHABLE(); > + break; > + } > + > + if ( !str || > + !(sz = strlen(str)) ) > + return -ENODATA; /* failsafe */ Is this really appropriate for e.g. an empty command line? > + if ( sz > INT32_MAX ) > + return -E2BIG; /* Compat guests. 2G ought to be plenty. */ While the comment here and in the public header mention compat guests, the check is uniform. What's the deal? > + if ( guest_handle_is_null(arg) ) /* Length request */ > + return sz; > + > + if ( copy_from_guest(&user_str, arg, 1) ) > + return -EFAULT; > + > + if ( user_str.len == 0 ) > + return -EINVAL; > + > + if ( sz > user_str.len ) > + return -ENOBUFS; > + > + if ( copy_to_guest_offset(arg, offsetof(struct xen_var_string, buf), > + str, sz) ) > + return -EFAULT; Not inserting a nul terminator is going to make this slightly awkward to use. > @@ -103,6 +126,35 @@ struct xen_build_id { > }; > typedef struct xen_build_id xen_build_id_t; > > +/* > + * Container for an arbitrary variable length string. > + */ > +struct xen_var_string { > + uint32_t len; /* IN: size of buf[] in bytes. */ > + unsigned char buf[XEN_FLEX_ARRAY_DIM]; /* OUT: requested data. */ > +}; > +typedef struct xen_var_string xen_var_string_t; > + > +/* > + * arg == xenver_string_t Nit: xen_var_string_t (also again in the following text). > + * Equivalent to the original ops, but with a non-truncating API/ABI. > + * > + * Passing arg == NULL is a request for size. The returned size does not > + * include a NUL terminator, and has a practical upper limit of INT32_MAX for > + * 32bit guests. This is expected to be plenty for the purpose. As said above, the limit applies to all guests, which the wording here doesn't suggest. Jan > + * Otherwise, the input xenver_string_t provides the size of the following > + * buffer. Xen will fill the buffer, and return the number of bytes written > + * (e.g. if the input buffer was longer than necessary). > + * > + * These hypercalls can fail, in which case they'll return -XEN_Exx. > + */ > +#define XENVER_extraversion2 11 > +#define XENVER_capabilities2 12 > +#define XENVER_changeset2 13 > +#define XENVER_commandline2 14 > + > #endif /* __XEN_PUBLIC_VERSION_H__ */ > > /* From xen-devel-bounces@lists.xenproject.org Wed Jan 04 17:54:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 17:54:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471368.731192 (Exim 4.92) (envelope-from ) id 1pD7y9-0004Nq-Vo; Wed, 04 Jan 2023 17:54:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471368.731192; Wed, 04 Jan 2023 17:54:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD7y9-0004Nj-S2; Wed, 04 Jan 2023 17:54:29 +0000 Received: by outflank-mailman (input) for mailman id 471368; Wed, 04 Jan 2023 17:54:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD7y9-0004NY-6N for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 17:54:29 +0000 Received: from sonic316-54.consmr.mail.gq1.yahoo.com (sonic316-54.consmr.mail.gq1.yahoo.com [98.137.69.30]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d3ac3425-8c58-11ed-91b6-6bf2151ebd3b; Wed, 04 Jan 2023 18:54:27 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic316.consmr.mail.gq1.yahoo.com with HTTP; Wed, 4 Jan 2023 17:54:24 +0000 Received: by hermes--production-ne1-7b69748c4d-brw6v (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 3b6e3b6717f2ad0d4df9645e096a3d43; Wed, 04 Jan 2023 17:54:18 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d3ac3425-8c58-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1672854864; bh=62GrjcKcrjn6pGet/GNWyEnuI3H5ZMFveZgVFAY9fi4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=XgcKO9mT2A5OpXMzNhTUWfEVZQeb3tZpsZi6pH8142PKactCJPOqzFwC0JdfDSsrPVx9PQymQO2Vh+y7/UH+fEjfmlLKfiAu6FO/nWGw/xlbSoj960yeTTZp7A5FPRNpovMsbZ5DMnAhrky90cR5W4IlqfThLdFaYNaozPbcoTRlgHPjeqNNffswzGk0pMkcfMBRfsEtngRVONq+24PF1eRHOaNp35sUXo43D4INbIR70r8t/imIFmavvVMR4xY6Hbdt8pLJY7E8Yz7IhW1r6gjpN5MpUZuR6Kp76gHXskt7q1FIkUEAM0PqM4t6KAnR2w7Mj/g2kPee4gwt0cnfmg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1672854864; bh=hyoo4l5eYpZvZ37UDueVbgUvGgA7cb6c0wte2v6dAvd=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=LG2pMM13WGB66ytLaHr4OMlZA6Q2xRxDMSI4tEm6m/QLPGf3KWl9aSdO6B+2iLAuRbkU9Qx2LfjJY/8/lRLASAu8JQFel5gVTpQFLj1G1mRHxBHnukHWJSsaq4aAkPqrYEFeiN2zLnqcyFeEd9idjxfpz/eHxcp1yRwJUGQoJ2XWJBos9DdWysPxRgsZd+kSL+QfjONrMI+8Ivpz+wdrnw+REdozZ7IFHh+FoXHKbUqG39ZhXwTWH9ppsQF8iyRY8G8MD9EMr5OeG2ByLJwQGomyoWm4BHracWAqiISBcvH2eKjfwYkxIGFi+TlUuvJ7dmBypjQsdHlkPG94h9TPug== X-YMail-OSG: hsgtjjMVM1kYbV.iYsvv_79.2anRl0pBtsppgVsWfzACkf34ams5kiyUUKtRAeR ZixpwMNisCWUZvqF3TyOuVRefxOjsMsVG_RWa0zr.A3jfIPAy6LYMBU3SbmOsSetaUSZfTM6v1X4 MgjLyLoEu0MKqtTLBfk3Mb1Tg9yCa8HMuZtjK0eFZo3Mk4G8lUvWuDUhRMNLTPl7wAHj2W_YNqCa DOuVBUxMB8zVAtPSaSAZK4YnATYpBNYnwcrtbBrxLjSzu98wnxVVxOiKcEFisouTnxYS3qqjWXFi xyQoDB39mTkmGwRJ9DA.0Xz6rbntkl2Xx_jLQWy4dEvs2FBA8yNved08SQdsL7H7BVHE7amdURLN YLxKXvzdKyAmYknKoP6O_BZfNW0UFhzNz8GydVOQr2I5S8cWQSdyxX5XTW2f62mcLlY8_3dg4zIK K43e8sDu18HJberC7t2eM7SW9lQOuXnimfxTY4QgiyooPabhE11pNi9XO2QeA1Fgi6Pqi7EOvmFi mIcDAOd8L97.T5YfvC0ugCDemxEn7_rGWb2WVzW2JvgfEkMVlkK0kN3auayrzM_de0ynRY8GUjgh f.B8ZT.lCBxYSofNU4RJGVxId19GMonO5zj2ex0h7iJOSOtjPlBz1D17MY46RD15f3ihdrAU5z5r rOFdOiPq.FpngnAgSArFxIvOyO6Fm9qJ8QdPiGNw4R25XNm9_m1_05VgRGpeo.f5FX3WLHgv22C7 ihX6yHXQDiNbEEktd1H_tcwJCVsRx_9PEG6QlXtX7uH8Yo3yQm77_ihbcDQ0jEMOMrJOqahMNzE5 97KMP74VxteFthVugEqkr1UBTwbri99BzYKP5n1vLOCkazOaT6umA8pkuVbHE_jYW9RsjxoYizbW IBxG_usnYLBdA3.nBOjj4QpNmEVYaChv924thTD4OE47hI9ODDOETxR9PCLNe42GkBD3tJ8QGmsD A2ikhYE1_VqIPZcb6cSwK5Ju08oPEnUdK7S.viVcEiJzhFgT0DNh9xEqxEChtVOLnKOL5JqUImja eG3gTSGs_gY3C6.DfiWH4PhPZ0tfD6C7jgztZxzvORVtcnjjC2Oi.ZJAimFA6HSQvX5DS2c0Aag6 1qiaH0EoSmd3O_AIch.ecUX4UnmUqNuey8UuXuvHUmo40DeVc9q14QDfWVgLT8fSKekjsWjeds90 xoPCfKuQHXTaIxIhT3B9d5SR4.HlobPoSyeYQENmQrzDArxZiBsEpt10eRNIlmQ1.yR4vOoyCYwF EBIXU6X3QcOH.oPzJry9pykHkgOotSI5bfIUXz764ICdaAp2MSaBzjS.Jx.6NbUOqb.2z3kLduQs Qv0Tl.J3N4sWJiAlDd01j2A5dbpHND4nrKhCQj2zP1r.pi27izYq9Vkfexeo77IzxvfZ4VA3BMcm Kh1GwULZI04NKkPev4MSk9bpDL98aaoBY.OxfR3PnkG_fMLboLMujQIXDTCdu3D7grrrg58o97xo grE5Wwofk3j1.28IqBgz4EXC_7ceS8VMre8tRwQfI7DDV8VqYZBFOf.wVCbI6ok9hzhbokZh3wvf rTx2KRB0qNFLxlqfONlbUDh9DevOY8X5ltG5bRwqxEYA.ljbxS.aJWlxPpsNbxMDNeVLkr9xwz9Q ux9oFJSLl.uSV6.9xg7YwBtsH3jG65TrQtsR1P5wot.HH4pfCc4Anad7jv7jLykk9ZbivX_Rn5Hx 4D2oolxJ002G18kAveulzNST1m5DdF_gdYQvitTLsjnBgZbjHw_Q4gI50Yb5Yv9SkgILQuk0OnUz xoR3J1E3xssxbZ2FCUcRAotd7r87C9PMXZ88M4nV_mxStQqaRbgm9nK4VxsJZERkmJvLKBklJFDx wy1X3M_.PklRG2hjjQnYpcJPM4tHOo.nZtwzi1dV9PDFkLMZN3x58gCHE.N4T2aR7M57J0Gm79SJ uyJmBphuyjttwYRbLzxRkguIhn3fMzhbg35si.8S8OeQRTa3gP2ro8KiN5qHp31caZCLV8m37C58 5uU_6twcwnml9ok4uFaIWbW_sAHXW6SbcmdRE1z5i.U07PDLMghN5AV8LeKeKtsCnod2UGM9dP89 9VCFtLto5buHFjzgkrS6.hp42mK2GN57tJS6ueY8q9LnmLR2o4AEUBpOAyQLZoyW5ccqWqaqgf_x XmDsl4SyxxsQmirGp0WRtPg0rtTCGNtxh28zkJ3JR0B8pG.wLhyECqc8Aid.LPydCoFdLOqgY0U3 WkGJGa41Fz3kqygvv07ja9Qk- X-Sonic-MF: Message-ID: Date: Wed, 4 Jan 2023 12:54:16 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v2 6/6] hw/isa/piix: Resolve redundant TYPE_PIIX3_XEN_DEVICE Content-Language: en-US To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Bernhard Beschow , qemu-devel@nongnu.org, Markus Armbruster Cc: Richard Henderson , Stefano Stabellini , xen-devel@lists.xenproject.org, =?UTF-8?Q?Herv=c3=a9_Poussineau?= , Aurelien Jarno , Paul Durrant , Marcel Apfelbaum , Anthony Perard , "Michael S. Tsirkin" , Paolo Bonzini , Eduardo Habkost , Thomas Huth References: <20230104144437.27479-1-shentey@gmail.com> <20230104144437.27479-7-shentey@gmail.com> <1c2e0780-e5fb-1321-0d84-b0591db9fec7@linaro.org> From: Chuck Zmudzinski In-Reply-To: <1c2e0780-e5fb-1321-0d84-b0591db9fec7@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.20982 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 5089 On 1/4/23 10:35 AM, Philippe Mathieu-Daudé wrote: > +Markus/Thomas > > On 4/1/23 15:44, Bernhard Beschow wrote: >> During the last patches, TYPE_PIIX3_XEN_DEVICE turned into a clone of >> TYPE_PIIX3_DEVICE. Remove this redundancy. >> >> Signed-off-by: Bernhard Beschow >> --- >> hw/i386/pc_piix.c | 4 +--- >> hw/isa/piix.c | 20 -------------------- >> include/hw/southbridge/piix.h | 1 - >> 3 files changed, 1 insertion(+), 24 deletions(-) >> >> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c >> index 5738d9cdca..6b8de3d59d 100644 >> --- a/hw/i386/pc_piix.c >> +++ b/hw/i386/pc_piix.c >> @@ -235,8 +235,6 @@ static void pc_init1(MachineState *machine, >> if (pcmc->pci_enabled) { >> DeviceState *dev; >> PCIDevice *pci_dev; >> - const char *type = xen_enabled() ? TYPE_PIIX3_XEN_DEVICE >> - : TYPE_PIIX3_DEVICE; >> int i; >> >> pci_bus = i440fx_init(pci_type, >> @@ -250,7 +248,7 @@ static void pc_init1(MachineState *machine, >> : pci_slot_get_pirq); >> pcms->bus = pci_bus; >> >> - pci_dev = pci_new_multifunction(-1, true, type); >> + pci_dev = pci_new_multifunction(-1, true, TYPE_PIIX3_DEVICE); >> object_property_set_bool(OBJECT(pci_dev), "has-usb", >> machine_usb(machine), &error_abort); >> object_property_set_bool(OBJECT(pci_dev), "has-acpi", >> diff --git a/hw/isa/piix.c b/hw/isa/piix.c >> index 98e9b12661..e4587352c9 100644 >> --- a/hw/isa/piix.c >> +++ b/hw/isa/piix.c >> @@ -33,7 +33,6 @@ >> #include "hw/qdev-properties.h" >> #include "hw/ide/piix.h" >> #include "hw/isa/isa.h" >> -#include "hw/xen/xen.h" >> #include "sysemu/runstate.h" >> #include "migration/vmstate.h" >> #include "hw/acpi/acpi_aml_interface.h" >> @@ -465,24 +464,6 @@ static const TypeInfo piix3_info = { >> .class_init = piix3_class_init, >> }; >> >> -static void piix3_xen_class_init(ObjectClass *klass, void *data) >> -{ >> - DeviceClass *dc = DEVICE_CLASS(klass); >> - PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); >> - >> - k->realize = piix3_realize; >> - /* 82371SB PIIX3 PCI-to-ISA bridge (Step A1) */ >> - k->device_id = PCI_DEVICE_ID_INTEL_82371SB_0; >> - dc->vmsd = &vmstate_piix3; > > IIUC, since this device is user-creatable, we can't simply remove it > without going thru the deprecation process. Alternatively we could > add a type alias: > > -- >8 -- > diff --git a/softmmu/qdev-monitor.c b/softmmu/qdev-monitor.c > index 4b0ef65780..d94f7ea369 100644 > --- a/softmmu/qdev-monitor.c > +++ b/softmmu/qdev-monitor.c > @@ -64,6 +64,7 @@ typedef struct QDevAlias > QEMU_ARCH_LOONGARCH) > #define QEMU_ARCH_VIRTIO_CCW (QEMU_ARCH_S390X) > #define QEMU_ARCH_VIRTIO_MMIO (QEMU_ARCH_M68K) > +#define QEMU_ARCH_XEN (QEMU_ARCH_ARM | QEMU_ARCH_I386) > > /* Please keep this table sorted by typename. */ > static const QDevAlias qdev_alias_table[] = { > @@ -111,6 +112,7 @@ static const QDevAlias qdev_alias_table[] = { > { "virtio-tablet-device", "virtio-tablet", QEMU_ARCH_VIRTIO_MMIO }, > { "virtio-tablet-ccw", "virtio-tablet", QEMU_ARCH_VIRTIO_CCW }, > { "virtio-tablet-pci", "virtio-tablet", QEMU_ARCH_VIRTIO_PCI }, > + { "PIIX3", "PIIX3-xen", QEMU_ARCH_XEN }, Hi Bernhard, Can you comment if this should be: + { "PIIX", "PIIX3-xen", QEMU_ARCH_XEN }, instead? IIUC, the patch series also removed PIIX3 and PIIX4 and replaced them with PIIX. Or am I not understanding correctly? Best regards, Chuck > { } > }; > --- > > But I'm not sure due to this comment from commit ee46d8a503 > (2011-12-22 15:24:20 -0600): > > 47) /* > 48) * Aliases were a bad idea from the start. Let's keep them > 49) * from spreading further. > 50) */ > > Maybe using qdev_alias_table[] during device deprecation is > acceptable? > >> -} >> - >> -static const TypeInfo piix3_xen_info = { >> - .name = TYPE_PIIX3_XEN_DEVICE, >> - .parent = TYPE_PIIX_PCI_DEVICE, >> - .instance_init = piix3_init, >> - .class_init = piix3_xen_class_init, >> -}; >> - >> static void piix4_realize(PCIDevice *dev, Error **errp) >> { >> ERRP_GUARD(); >> @@ -534,7 +515,6 @@ static void piix3_register_types(void) >> { >> type_register_static(&piix_pci_type_info); >> type_register_static(&piix3_info); >> - type_register_static(&piix3_xen_info); >> type_register_static(&piix4_info); >> } >> >> diff --git a/include/hw/southbridge/piix.h b/include/hw/southbridge/piix.h >> index 65ad8569da..b1fc94a742 100644 >> --- a/include/hw/southbridge/piix.h >> +++ b/include/hw/southbridge/piix.h >> @@ -77,7 +77,6 @@ struct PIIXState { >> OBJECT_DECLARE_SIMPLE_TYPE(PIIXState, PIIX_PCI_DEVICE) >> >> #define TYPE_PIIX3_DEVICE "PIIX3" >> -#define TYPE_PIIX3_XEN_DEVICE "PIIX3-xen" >> #define TYPE_PIIX4_PCI_DEVICE "piix4-isa" >> >> #endif > From xen-devel-bounces@lists.xenproject.org Wed Jan 04 18:34:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 18:34:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471375.731203 (Exim 4.92) (envelope-from ) id 1pD8ap-0000LO-02; Wed, 04 Jan 2023 18:34:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471375.731203; Wed, 04 Jan 2023 18:34:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD8ao-0000LH-TV; Wed, 04 Jan 2023 18:34:26 +0000 Received: by outflank-mailman (input) for mailman id 471375; Wed, 04 Jan 2023 18:34:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD8an-0000LA-LV for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 18:34:25 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 67a0e035-8c5e-11ed-91b6-6bf2151ebd3b; Wed, 04 Jan 2023 19:34:23 +0100 (CET) Received: from mail-dm3nam02lp2040.outbound.protection.outlook.com (HELO NAM02-DM3-obe.outbound.protection.outlook.com) ([104.47.56.40]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Jan 2023 13:34:19 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SA1PR03MB6564.namprd03.prod.outlook.com (2603:10b6:806:1cb::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Wed, 4 Jan 2023 18:34:15 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5944.019; Wed, 4 Jan 2023 18:34:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 67a0e035-8c5e-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1672857263; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=R8d0creBhCbzEKKsTWf735ZH/0haJVM6D8OEXMR4+qw=; b=gYWfxQcy0G9GUF0RR+SKIHoa3+OCwfNMLz8UlI+BT0rn1C1VHeT4m0rg C2fGY843CsNI5Iue/gpRWQ7+QKdSyay1veAaDCx2CuChuq/QptmX6Q+Ri j8vWpyam2zWrV3kB881pvv7WGW8nzq6eip/RY7tIhVrS9ek8aN87c4HJr I=; X-IronPort-RemoteIP: 104.47.56.40 X-IronPort-MID: 91188611 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:hg5ODqKDICh4Ngy/FE+RGpQlxSXFcZb7ZxGr2PjKsXjdYENSg2YGn 2VLXWiFP/jZNGb3Ldh2bozl9xlX6pPQn9FiHlRlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHv+kUrWs1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPdwP9TlK6q4mhA5wRiPawjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5WEGBMz vU4JwsWURaGlsmx0b6nWvZz05FLwMnDZOvzu1lG5BSBV7MKZMuGRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dppTSLpOBy+OGF3N79U9qGX8hK2G2fo XrL5T/RCRAGLt2PjzGC9xpAg8eexHqrCNxLTdVU8NZkx0Si51JUOScmWGX8pd7ktU63Bc1mf hl8Fi0G6PJaGFaQZtv3UgC8oXWElgUBQNcWGOo/gCmW0bbd6QudAmkCTxZCZcYguctwQiYlv neWm/v5CDopt6eaIVqf67OVoDWaKSUTa2gYakcsXQYDptXuvow3phbOVcp4Vr64iMXvHjP9y CzMqzIx74j/luYO3qS/uFzC2DSlo8CTShZvvlmPGGW48gl+eYipIZSy7kTW5upBK4DfSUSdu H8DmI6V6+Vm4YyxqRFhid4lRNmBj8tp+hWB6bKzN/HNLwiQxkM= IronPort-HdrOrdr: A9a23:sHQ4HqCNGKCuMsvlHehLsceALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPEfP+VAssQIb6Km90ci7MAThHPtOjbX5Uo3SODUO1FHIEGgA1/qV/9SDIVyYygc178 4JHMZD4bbLfDtHZLPBkWyF+qEbsbu6Gc6T5dv2/jNId0VHeqtg5wB2BkKwCUttXjRLApI/Cd 61+tdHjyDIQwVeUu2LQl0+G8TTrdzCk5zrJTQcAQQ81QWIhTS0rJbnDhmj2AsEWT8n+8ZozY GFqX2y2kyQiYD29vbu7R6d032Qoqqu9jJ3Pr3AtiHSEESstu/nXvUgZ1TIhkFMnAjm0idQrD CLmWZoAy070QKqQkil5RTqwAXuyzAo9jvrzkKZm2LqpYjjSCs9ENcpv/MqTvL10TtRgDhH6t M540uJ855MSR/QliX04NbFExlsi0qvuHIn1eoelWZWX4cSYKJY6dV3xjIgLL4QWCbhrIw3Gu hnC8/RoP5QbFOBdnjc+m1i2salUHg/FgqPBkICpsuW2T5Lm20R9Tps+OUP2nMbsJ4tQZhN4O rJdqxuibFVV8cTKblwAe8QKPHHe1AlgSi8Tl56DW6Xa53vYUi91qIfyI9FmN2XRA== X-IronPort-AV: E=Sophos;i="5.96,300,1665460800"; d="scan'208";a="91188611" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KuPpe2N4LpV9NsqS2hQgfbPOddkz3Lb/GAOGc720ADEMycfCBqyPfxUhneOd0nCMZFP4nSxM0ejy5Tvy9+x+XrSB4ZwN5alI27y+ynPe+nitkb455xrHgPp4oz7UyAMRYVsO6xNvs0TngZFNo+IJZp/T26DRvu19B8dKxiiaYCq2W6BD3rImdl72c8HOoIaaxhhZzZjxrjJltPADWH4hqlwfUBYgTYkx3IO64mX0EGnEmzb/P8PSphNYnWCgeu1j6eY6ylKnKdPxL++mo1d2qhXPGEtoChoCL/U2eucM6kDMTYO4JhpHfCM4V/GDM+RSI5SuyvUijQg3CSWBrAd2Fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=R8d0creBhCbzEKKsTWf735ZH/0haJVM6D8OEXMR4+qw=; b=eovIpsR0nUclfxDFFkw+AjnZPzQP8OCFmq6wjVjQzdpo8DTJrOFKzpvRTJaD95+a9eAUVRkwp076Tx6nlBNyxdW0zIwXVfswcj+1g69e1Zj4niIOKRaviSk4YAEFrkFXax0wncnOayyPK8gS9cSZbXZkdhsvtjDHeEvtE1ibm2AUf7ZTCoAuUikBnpQCBHSJowEuMHiZaMrO3kRIhw2n+BAe1GBZgX+kCeS5/vhqBNqUUlJkLgQtCqj5bhe8sy7rm5jvBe7wZeADJpgN7O6MvGwueaGt9y7RVd9Vb/n/gWKqWgOU3tutQ5ePnN8S2so+L20tgALYz0KcG1KMIXUNjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R8d0creBhCbzEKKsTWf735ZH/0haJVM6D8OEXMR4+qw=; b=aqhPD0si6R2AJFvo2iDDQmyMpdfuj8Tr8wpqm6wV7C566QJdryKScpHejYDAU3h8HxyFQXRxdMSZ+BAIzBzQf3ed11vQ7jGYMd71mCLTItcC+65bpor89kgcKKISCrlXVXtrYpoqVMNLLss06qCYllqD7J2BxljGo361qwQXmvo= From: Andrew Cooper To: Jan Beulich CC: George Dunlap , Stefano Stabellini , Wei Liu , Julien Grall , Xen-devel Subject: Re: [PATCH 4/4] xen/version: Introduce non-truncating XENVER_* subops Thread-Topic: [PATCH 4/4] xen/version: Introduce non-truncating XENVER_* subops Thread-Index: AQHZH69eYU4qCMuPJUaHOPPUV+yM+a6OfdiAgAAZEwA= Date: Wed, 4 Jan 2023 18:34:14 +0000 Message-ID: <9c9cedd5-cca7-95d4-00bb-f34a56de2695@citrix.com> References: <20230103200943.5801-1-andrew.cooper3@citrix.com> <20230103200943.5801-5-andrew.cooper3@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|SA1PR03MB6564:EE_ x-ms-office365-filtering-correlation-id: c93bb995-222b-4f94-3c3a-08daee824816 x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 38LE06HUUS/tohxVoExBUWoR+GhC+aaUpzJOw13JA+zttx/zAB60KnWDV9Pls2scxgO8d4oSYdhDhGwjrJQDYc50gUtVkLP8E+iTanAMA090/GhRGJS/l3D05pS8BePKv6GekRprumYlMSKA1ekL8y2tGWKnqHBn1RQYBev5A1R1rRKr/shIn2KmcuntiLlUUk3+ODfaG9u8X4PojKJDdk+9CMenfRlMCw25m12Or/WdpDdAQhbMEH2tSV2K5XSjyVaLqgdO+f9DZvC9quFO36Zi150PFjg/6WHlkL1qn2Mgh21KKUnregTHlCdanu4tk3FiOXxhjeZrO/3OFx9AV1v7G6pIuawe2RfnUg01cDSpXYBjUZ6BfaHzO01kHZaqfeh/+o/G8tZGJbiYUdBm9SgMxHO6yBOwejG0jDEGBGNDR/tp4UtsEepupy5QID2lpyiRVDGlXY/EBNepO79w59GJ4B7n6S/6NTX/wk9+oXC/q81dLyn8wibuOz1qFLRTCKEY2/OlJEx+2uzJ8hS2uzavGUERUNp12SsGpKuNvvvnKwx9jw07SkyxkXwKvHk2C4nm7fpGoiYxg9Yl5P0Hk0hFJmDsCsgT1/123kVMiZXyvqXfwklPFaD2HaSNhNwuqHtzl+P7A5bz5Uj6sPtoJ9ZfTozaUjb7FXqWy3x26ZqoqEuX8m1aP0J+qJduEWpnKWdgO+lOAlLeBwa5z4Tt827iQJaYoLNAbrO2JxGtpMno+WX6fTLneuS/TYP3hhlJ1cfo1azlbaSiqx+DuE9bAQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(376002)(366004)(346002)(39860400002)(451199015)(83380400001)(82960400001)(122000001)(8936002)(38100700002)(4326008)(66946007)(38070700005)(8676002)(86362001)(31696002)(5660300002)(66476007)(2906002)(76116006)(66556008)(66446008)(64756008)(41300700001)(26005)(6512007)(91956017)(6506007)(186003)(53546011)(54906003)(6916009)(71200400001)(316002)(6486002)(2616005)(478600001)(31686004)(66899015)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?dUorUnFMNk1ibk00a1dKa2JoSUxpcnhNK25Wd0NVWHJXM1BYUENlVzh1MGVZ?= =?utf-8?B?dG51KzdvcVlmSzVIcFU1QnlwQXhYckhja2VIdHBkakNvbmV2cGhRcnF1Z3dT?= =?utf-8?B?QldIb0pvOGVVaVpNK0E1ZkJYVGRCeW02VE5FSzBWVE93d2l1Y3p1RFNaOVg1?= =?utf-8?B?N051VHBSVHBKdnNKaHlwd0hMeGYzSWlDTEprMnFSaTRRQjFoSGNWWWRPRHFG?= =?utf-8?B?dTcxQitwRXpIKzNYdmVwSzZ2ZmdVZWY3ZXJRc0lHTVZWSmxtN3hzYkdmWmNT?= =?utf-8?B?Q0l3Uzg1U2J4a2E3ZDJQdjM1UWptRjEya3hKWG9tZkorQkNCRkZOS2xmQTR6?= =?utf-8?B?NjVyNiszLzFnK01iY3JxNlhtN2VqTjYvcHJ4ck5MdmNZNUlQUlhhYU9JRWJm?= =?utf-8?B?ZWFGMkYvQm1WYkhYT0ZGODJHNHY4NldhNEM5cGRMaUpabHFiYjM3YXdXQzlv?= =?utf-8?B?Z2VIQjB4Yk0xUm0xRGtvQnl6Nm84M3ZyeVdxYzRzbUo1MDQ4WHlPTnFZVEIv?= =?utf-8?B?c1hvRlBvYjFrbUJ5by9QYmVDQ2UrNkRsZEk4MWhIVkRydVk0UGlVdE0rbHZM?= =?utf-8?B?aUU3VUhkcHFzM2xsSDNMOXhxU0wvMXNwUHVONUxXbmtMTE5WV0JWREY0UUFS?= =?utf-8?B?MmN4dDFFU3BaZnBYWCtvTFcrKzVZWEVvOXVNR2RPUHB3M0ppSnR3djd4VlJN?= =?utf-8?B?dWFoR25Yc1FVeElGYm9LY0h2TkJQMHRxRU1TZERwZllqL3c1ck5QWFlqR2tl?= =?utf-8?B?Vnl3Q01mUURlb24xZERHQXI2SGErZm94dmZ5YUg3cG01RVhEY3laM2N3bU95?= =?utf-8?B?NEYwU1VkNkNBcnJWUzkrSmNLalJkVnZQSzlwTDVyOU5lUUJOOHFvQ2liQWJU?= =?utf-8?B?L0FseUtUNGZYUEg5VE5ZRU1QQzRaWFJkWGQ0eGhJTnlpMzNkS0Fvd1krcGdC?= =?utf-8?B?Qzl3ZUxkNk5HdjVFQ3U1RkF1OGxoNTE0anJ2Vm1SOU5MZUYwMlo5cGl0YlZ1?= =?utf-8?B?em5tQXB0SE1pM2xPVG45MG5HaE5MbGFLTFpBeVc1OEZvWTdrd0JrYzNoWHZi?= =?utf-8?B?bEJNMDRqdkRtVlFndzZ1OWk2Ujg0NkNvQjNxWVIvSEFBRW9PMzN1MWQ1RW05?= =?utf-8?B?TS9GS21XeWs2NlptbjNPZ3JMNnlDb29LenZEcFhCQ2VsMnhSdzhYbDByd3FW?= =?utf-8?B?UCszY0RpcndMNnR0U2pLU1hCbVpJR0IyeEp5YXp2QTZjNUpxeUd0Qjh2bndv?= =?utf-8?B?ckIrOGdvK1B2SkNyTDJvVjhwYjBtb1BFY0N6VEkwZ1Nrekl0S25RclExZ2xU?= =?utf-8?B?cjVaMDBodTBoU2JZdHVXSWNuc2tXeGd6OVFPc0tyVlpaYmxMWVlvRnl1cE1U?= =?utf-8?B?TDZ1QzluelZuZmZnempSSkVicWFVdm4yY1M3bTFBZEMxSGJHOGFQUDZrdThY?= =?utf-8?B?clhtRFV2Z3pmMEpzTFIrbXVjbW5sM0FDM0hTZUxPd1BlVHpHeFZLSFdsdTlJ?= =?utf-8?B?WitENEpkNFB2US8rRkFMZFNOakQ1NC95WVdJTUF2SVhZTDhjbUZKNHpjSWo5?= =?utf-8?B?TWdiZGRRcTlEVDN1Z29PUTRuTHRMY1BhdGdVUXVwSlRoL0RXU0RFYlhqZUhS?= =?utf-8?B?bHlmcnZqUS9hNlBQQmxvV1JuL2ovYW9yUDhTT0dBMEI1RGFzTFBvUXRLSmRU?= =?utf-8?B?S2t2VFMwTDZCaWJPYy9YV0dCbnRrZWdBcFVIVXFnNG5YcXE1a0JNMk94YW5R?= =?utf-8?B?OGZhaWp2MFVBcWhPQ29rTVA5aXgrdzV3SUxRUFlVbXNDTjArYk04M0FDUGRt?= =?utf-8?B?VFpZVXBmbnVUUDJlSW94d3ZtdlNIUS8wY0J0bldpVFk5elB4TlBlN0RIeXh4?= =?utf-8?B?R1FhcC9rV1BnSDJuSldqdVBMRXpiOEZXblhSVkMvZkEwd3ZMK0Y3TC9ZcTl1?= =?utf-8?B?R0c4bk9wN3N4aHZET25QazQ5TzNqQ3Z1bjRnT0JINFNSemxRbVVQWVJQQUx0?= =?utf-8?B?cE9DV3ByODJCUkJ6M0sxdnltMURDeFFQUkdhQnZyV0UzV2JOdlR1ajhDeGpn?= =?utf-8?B?YU9JN2Z3QzVaNVB3S3kyTUE5bkhlb1dvY2owK2xJTkF0N3J1QUs4ODFuVGs4?= =?utf-8?Q?ARMDxtLQBVV0wEN83K62ZZ1uJ?= Content-Type: text/plain; charset="utf-8" Content-ID: <13F53D7107A7664C82EAB7BF14044A34@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 6GlldlbtsgKibT2Jrai+8R6qA+OH3HhHJbZ9MpJJmOWA6D21FoIWFEVnXsRQTJWKhfW9YQ/yi8iew9SlWkLnB4r5WrzBp42cokxJPTsTo/hWqE7NSjIA+GmFRAeK5EGtRmqc18O8w/xp/0T/UrrujR8GwMPsQ2+BsIELwC7ahh4mnBlHBlHiWxpz89rJwtMZszZRmEvuPRtqLHdM/H+y4Y+A+BQ3CS26sH2C+9f7asPtNNx++Rvj3ggqCyfHaRkz1od+M80lzgplFXqJ7KTsyL50XjqRcjykQq2ScETPq8oZ/rB1Y3PjcbIz7NFAAwGe7x3RBMnzKK91wElhLGApArL3VsGnIGmhJIN2G/YbY2KdX8X8jnPcLyxikQod6onGpp0crgzzSLdjBkGhMJYlU4xHkwzTS7J5rHUxGw4pM7RMvOl+pYvTWyFmUFOka3P+PJ+Ag8d6B4+I3nONBft60B0GFL3NsQ4GVw6PmZU5fB1Cti7iQfp6eES8j8pFe44ZYDP+5ndFWOOMWWssmnlL96kL4aerWDJmIViMvQxzq9nx09nYTvDAKYHNEusQFdFno5bGzvE2PDDgr+NDVjLLgQ71WyVkiNWwA/Q8c5/bj3Te2OuQjY1Wpwr8YxJjv/F/Qmmd8YnvHSA9CMjJy2CC8IlQOWCUOF+NrUo/sEhxUTH23xuwR/zv6fjY+ZhyLCgNflzPYR/02ryyKaeRZwCLSE6YhwrbnMPui0zLFc5TgH//NXEmtzdEuPQ+xY62IqLj9lk28crQPBhMd5wIgetkDqLT77FyogJ8doyjeZync42KIakd1nN1an7xb+1KcAPW1O/itsxh+ndPBhaIbP3S877GiJ/c5hcxScNyv/IfiAg3xf/6yLyOgiJ70yw5UeOE X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c93bb995-222b-4f94-3c3a-08daee824816 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jan 2023 18:34:14.8453 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nR5FhHbv7AG2urwwjUxQxFMEHpab9irJRbtaT7tB/ybV5iuPb017RLxMZ6aqjLJou/4VW8We3vNJE98ORQ3bOjTePAjW5ekXjPmH44bjpdA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6564 T24gMDQvMDEvMjAyMyA1OjA0IHBtLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMDMuMDEuMjAy MyAyMTowOSwgQW5kcmV3IENvb3BlciB3cm90ZToNCj4+IFJlY2VudGx5IGluIFhlblNlcnZlciwg d2UgaGF2ZSBlbmNvdW50ZXJlZCBwcm9ibGVtcyBjYXVzZWQgYnkgYm90aA0KPj4gWEVOVkVSX2V4 dHJhdmVyc2lvbiBhbmQgWEVOVkVSX2NvbW1hbmRsaW5lIGhhdmluZyBmaXhlZCBib3VuZHMuDQo+ Pg0KPj4gTW9yZSB0aGFuIGp1c3QgdGhlIGludmFyaWFudCBzaXplLCB0aGUgQVBJcy9BQklzIGFs c28gYnJva2VuIGJ5IHR5cGVkZWYtaW5nIGFuDQo+PiBhcnJheSwgYW5kIHVzaW5nIGFuIHVucXVh bGlmaWVkICdjaGFyJyB3aGljaCBoYXMgaW1wbGVtZW50YXRpb24tc3BlY2lmaWMNCj4+IHNpZ25l ZC1uZXNzLg0KPiBXaGljaCBpcyBmaW5lIGFzIGxvbmcgYXMgb25seSBBU0NJSSBpcyByZXR1cm5l ZC4gSWYgbm9uLUFTQ0lJIGNhbiBiZSByZXR1cm5lZCwNCj4gSSBhZ3JlZSAidW5zaWduZWQgY2hh ciIgaXMgYmV0dGVyLCBidXQgdGhlbiB3ZSBhbHNvIG5lZWQgdG8gc3BlbGwgb3V0IHdoYXQNCj4g ZW5jb2RpbmcgdGhlIHN0cmluZ3MgdXNlIChVVEYtOCBwcmVzdW1hYmx5KS4NCg0KV2VsbCwgaXQg ImZ1bmN0aW9ucyIgYXMgZmFyIGFzIEFTQ0lJIGlzIGNvbmNlcm5lZCwgYnV0IEkgd291bGRuJ3Qg c2F5DQp0aGF0IHdhcyBmaW5lIGZvciBhbiBBQkkuDQoNClRoZSBjb21tYW5kIGxpbmUgY2FuIHJl YXNvbmFibHkgaGF2ZSBub24tQVNDSUkgY2hhcmFjdGVycyB0aGVzZSBkYXlzLsKgDQooYXMgY2Fu IHRoZSBjb21waWxlIGluZm9ybWF0aW9uLCBidXQgSSBpbnRlbnRpb25hbGx5IGRpZG4ndCBjb252 ZXJ0IHRoZW0NCnRvIHRoaXMgbmV3IGZvcm1hdCkuDQoNClVURi04IGlzIHByb2JhYmx5IHRoZSBz ZW5zaWJsZSB0aGluZyB0byBzcGVjaWZ5LCBpZiB3ZSdyZSBnb2luZyB0byBtYWtlDQphbnkgc3Rh dGVtZW50Lg0KDQo+DQo+PiBBUEkvQUJJIHdpc2UsIFhFTlZFUl9idWlsZF9pZCBjb3VsZCBiZSBt ZXJnZWQgaW50byB4ZW52ZXJfdmFyc3RyaW5nX29wKCksIGJ1dA0KPj4gdGhlIGludGVybmFsIGlu ZnJhc3RydWN0dXJlIGlzIGF3a3dhcmQuDQo+IEkgZ3Vlc3MgYnVpbGQtaWQgYWxzbyBkb2Vzbid0 IGZpdCB0aGUgcmVzdCBiZWNhdXNlIG9mIG5vdCByZXR1cm5pbmcgc3RyaW5ncywNCj4gYnV0IGlu ZGVlZCBhbiBhcnJheSBvZiBieXRlcy4gWW91IGFsc28gY291bGRuJ3QgdXNlIHN0cmxlbigpIG9u IHRoZSBhcnJheS4NCg0KVGhlIGZvcm1hdCBpcyB1bnNwZWNpZmllZCwgYnV0IGl0IGlzIGEgYmFz ZTY0IGVuY29kZWQgQVNDSUkgc3RyaW5nIChub3QNCk5VTCB0ZXJtaW5hdGVkKS4NCg0KPj4gQEAg LTQ2OSw2ICs0NzAsNjYgQEAgc3RhdGljIGludCBfX2luaXQgY2ZfY2hlY2sgcGFyYW1faW5pdCh2 b2lkKQ0KPj4gIF9faW5pdGNhbGwocGFyYW1faW5pdCk7DQo+PiAgI2VuZGlmDQo+PiAgDQo+PiAr c3RhdGljIGxvbmcgeGVudmVyX3ZhcnN0cmluZ19vcChpbnQgY21kLCBYRU5fR1VFU1RfSEFORExF X1BBUkFNKHZvaWQpIGFyZykNCj4+ICt7DQo+PiArICAgIGNvbnN0IGNoYXIgKnN0ciA9IE5VTEw7 DQo+PiArICAgIHNpemVfdCBzeiA9IDA7DQo+PiArICAgIHVuaW9uIHsNCj4+ICsgICAgICAgIHhl bl9jYXBhYmlsaXRpZXNfaW5mb190IGluZm87DQo+PiArICAgIH0gdTsNCj4+ICsgICAgc3RydWN0 IHhlbl92YXJfc3RyaW5nIHVzZXJfc3RyOw0KPj4gKw0KPj4gKyAgICBzd2l0Y2ggKCBjbWQgKQ0K Pj4gKyAgICB7DQo+PiArICAgIGNhc2UgWEVOVkVSX2V4dHJhdmVyc2lvbjI6DQo+PiArICAgICAg ICBzdHIgPSB4ZW5fZXh0cmFfdmVyc2lvbigpOw0KPj4gKyAgICAgICAgYnJlYWs7DQo+PiArDQo+ PiArICAgIGNhc2UgWEVOVkVSX2NoYW5nZXNldDI6DQo+PiArICAgICAgICBzdHIgPSB4ZW5fY2hh bmdlc2V0KCk7DQo+PiArICAgICAgICBicmVhazsNCj4+ICsNCj4+ICsgICAgY2FzZSBYRU5WRVJf Y29tbWFuZGxpbmUyOg0KPj4gKyAgICAgICAgc3RyID0gc2F2ZWRfY21kbGluZTsNCj4+ICsgICAg ICAgIGJyZWFrOw0KPj4gKw0KPj4gKyAgICBjYXNlIFhFTlZFUl9jYXBhYmlsaXRpZXMyOg0KPj4g KyAgICAgICAgbWVtc2V0KHUuaW5mbywgMCwgc2l6ZW9mKHUuaW5mbykpOw0KPj4gKyAgICAgICAg YXJjaF9nZXRfeGVuX2NhcHMoJnUuaW5mbyk7DQo+PiArICAgICAgICBzdHIgPSB1LmluZm87DQo+ PiArICAgICAgICBicmVhazsNCj4+ICsNCj4+ICsgICAgZGVmYXVsdDoNCj4+ICsgICAgICAgIEFT U0VSVF9VTlJFQUNIQUJMRSgpOw0KPj4gKyAgICAgICAgYnJlYWs7DQo+PiArICAgIH0NCj4+ICsN Cj4+ICsgICAgaWYgKCAhc3RyIHx8DQo+PiArICAgICAgICAgIShzeiA9IHN0cmxlbihzdHIpKSAp DQo+PiArICAgICAgICByZXR1cm4gLUVOT0RBVEE7IC8qIGZhaWxzYWZlICovDQo+IElzIHRoaXMg cmVhbGx5IGFwcHJvcHJpYXRlIGZvciBlLmcuIGFuIGVtcHR5IGNvbW1hbmQgbGluZT8NCg0KSG1t LsKgIEdvb2QgcG9pbnQuwqAgQWxsIGNhbiBpbiBwcmluY2lwbGUgYmUgZW1wdHkuDQoNCkluIHdo aWNoIGNhc2UgSSB0aGluayBJJ2xsIHB1dCB0aGUgLUVOT0RBVEEgaW4gdGhlIGRlZmF1bHQgY2Fz ZSBhbmQgaGF2ZQ0KYSByZXR1cm4gMCBmb3IgdGhlIHN6ID09IDAgY2FzZS4NCg0KPj4gKyAgICBp ZiAoIHN6ID4gSU5UMzJfTUFYICkNCj4+ICsgICAgICAgIHJldHVybiAtRTJCSUc7IC8qIENvbXBh dCBndWVzdHMuICAyRyBvdWdodCB0byBiZSBwbGVudHkuICovDQo+IFdoaWxlIHRoZSBjb21tZW50 IGhlcmUgYW5kIGluIHRoZSBwdWJsaWMgaGVhZGVyIG1lbnRpb24gY29tcGF0IGd1ZXN0cywNCj4g dGhlIGNoZWNrIGlzIHVuaWZvcm0uIFdoYXQncyB0aGUgZGVhbD8NCg0KV2VsbCBpdHMgZWl0aGVy IHRoaXMsIG9yIGEgKGNvbWF0ID8gSU5UMzJfTUFYIDogSU5UNjRfTUFYKSBjaGVjaywgYWxvbmcN CndpdGggdGhlIGlmZGVmYXJ5IGFuZCBwcmVkaWNhdGVzIHJlcXVpcmVkIHRvIG1ha2UgdGhhdCBj b21waWxlLg0KDQpCdXQgdGhlcmUncyBub3QgYSBDUFUgdG9kYXkgd2hpY2ggY2FuIGFjdHVhbGx5 IG1vdmUgMkcgb2YgZGF0YSAod2hpY2ggaXMNCjRHIG9mIEwxZCBiYW5kd2lkdGgpIHdpdGhvdXQg c3VmZmVyaW5nIHRoZSB3YXRjaGRvZyAoZXNwZWNpYWxseSBhcyB3ZSd2ZQ0KanVzdCByZWFkIGl0 IG9uY2UgZm9yIHN0cmxlbigpLCBzbyB0aGF0J3MgNkcgb2YgYmFuZHdpZHRoKSwgbm9yIGRvIEkN CmV4cGVjdCB0aGlzIHRvIGNoYW5nZSBpbiB0aGUgZm9yc2VlYWJsZSBmdXR1cmUuDQoNClRoZXJl J3Mgc29tZSBib3VuZGFyeSAocHJvYmFibHkgZmFyIGxvd2VyKSBiZXlvbmQgd2hpY2ggd2UgY2Fu J3QgdXNlIHRoZQ0KYWxnb3JpdGhtIGhlcmUuDQoNClRoZXJlIHdhbnRzIHRvIGJlIHNvbWUgbGlt aXQsIGFuZCBJIGRvbid0IGZlZWwgaXQgaXMgbmVjZXNzYXJ5IHRvIG1ha2UNCml0IHZhcmlhYmxl IG9uIHRoZSBndWVzdCB0eXBlLg0KDQo+DQo+PiArICAgIGlmICggZ3Vlc3RfaGFuZGxlX2lzX251 bGwoYXJnKSApIC8qIExlbmd0aCByZXF1ZXN0ICovDQo+PiArICAgICAgICByZXR1cm4gc3o7DQo+ PiArDQo+PiArICAgIGlmICggY29weV9mcm9tX2d1ZXN0KCZ1c2VyX3N0ciwgYXJnLCAxKSApDQo+ PiArICAgICAgICByZXR1cm4gLUVGQVVMVDsNCj4+ICsNCj4+ICsgICAgaWYgKCB1c2VyX3N0ci5s ZW4gPT0gMCApDQo+PiArICAgICAgICByZXR1cm4gLUVJTlZBTDsNCj4+ICsNCj4+ICsgICAgaWYg KCBzeiA+IHVzZXJfc3RyLmxlbiApDQo+PiArICAgICAgICByZXR1cm4gLUVOT0JVRlM7DQo+PiAr DQo+PiArICAgIGlmICggY29weV90b19ndWVzdF9vZmZzZXQoYXJnLCBvZmZzZXRvZihzdHJ1Y3Qg eGVuX3Zhcl9zdHJpbmcsIGJ1ZiksDQo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg c3RyLCBzeikgKQ0KPj4gKyAgICAgICAgcmV0dXJuIC1FRkFVTFQ7DQo+IE5vdCBpbnNlcnRpbmcg YSBudWwgdGVybWluYXRvciBpcyBnb2luZyB0byBtYWtlIHRoaXMgc2xpZ2h0bHkgYXdrd2FyZCB0 bw0KPiB1c2UuDQoNCk5vdCByZWFsbHkuwqAgSXQgbWF0Y2hlcyBob3cgYnVpbGQtaWQgY3VycmVu dGx5IHdvcmtzLCBhbmQgZm9yY2VzIHRoZQ0KY2FsbGVyIHRvIHVzZSBwcm9wZXIgdGFpbmVkLXN0 cmluZyBkaXNjaXBsaW5lLg0KDQpUbyBzYWZlbHkgcHJpbnRrKCkgaXQsIGFsbCB5b3UgbmVlZCBp czoNCg0KcmMgPSB4ZW5fdmVyc2lvbihYRU5WRVJfJFgsICZzdHIpOw0KaWYgKCByYyA8IDAgKQ0K wqDCoMKgIHJldHVybiByYzsNCnByaW50aygiJSouc1xuIiwgcmMsIHN0ci5idWYpOw0KDQo+PiBA QCAtMTAzLDYgKzEyNiwzNSBAQCBzdHJ1Y3QgeGVuX2J1aWxkX2lkIHsNCj4+ICB9Ow0KPj4gIHR5 cGVkZWYgc3RydWN0IHhlbl9idWlsZF9pZCB4ZW5fYnVpbGRfaWRfdDsNCj4+ICANCj4+ICsvKg0K Pj4gKyAqIENvbnRhaW5lciBmb3IgYW4gYXJiaXRyYXJ5IHZhcmlhYmxlIGxlbmd0aCBzdHJpbmcu DQo+PiArICovDQo+PiArc3RydWN0IHhlbl92YXJfc3RyaW5nIHsNCj4+ICsgICAgdWludDMyX3Qg bGVuOyAgICAgICAgICAgICAgICAgICAgICAgICAgLyogSU46ICBzaXplIG9mIGJ1ZltdIGluIGJ5 dGVzLiAqLw0KPj4gKyAgICB1bnNpZ25lZCBjaGFyIGJ1ZltYRU5fRkxFWF9BUlJBWV9ESU1dOyAv KiBPVVQ6IHJlcXVlc3RlZCBkYXRhLiAgICAgICAgICovDQo+PiArfTsNCj4+ICt0eXBlZGVmIHN0 cnVjdCB4ZW5fdmFyX3N0cmluZyB4ZW5fdmFyX3N0cmluZ190Ow0KPj4gKw0KPj4gKy8qDQo+PiAr ICogYXJnID09IHhlbnZlcl9zdHJpbmdfdA0KPiBOaXQ6IHhlbl92YXJfc3RyaW5nX3QgKGFsc28g YWdhaW4gaW4gdGhlIGZvbGxvd2luZyB0ZXh0KS4NCg0KQWggeWVzLsKgIEkgb3JpZ2luYWxseSBj YWxsZWQgaXQgeGVudmVyX3N0cmluZ190IHRoZW4gZm91bmQgYSB3aG9sZSBsb2FkDQpvZiBjb21w YXQgYXNzdW1wdGlvbnMgYWJvdXQgeGVuIHByZWZpeGVzIG9uIG5hbWVzLg0KDQpXaWxsIGZpeC4N Cg0KDQpCdXQgb3ZlcmFsbCwgSSdtIG5vdCBzZWVpbmcgYSBtYWpvciBvYmplY3Rpb24gdG8gdGhp cyBjaGFuZ2U/wqAgSW4gd2hpY2gNCmNhc2UgSSdsbCBnbyBhaGVhZCBhbmQgZG8gdGhlIHRvb2xz LyBjbGVhbnVwIHRvbyBmb3IgdjIuDQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Wed Jan 04 18:48:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 18:48:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471383.731213 (Exim 4.92) (envelope-from ) id 1pD8oK-0001xQ-9M; Wed, 04 Jan 2023 18:48:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471383.731213; Wed, 04 Jan 2023 18:48:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD8oK-0001xJ-6n; Wed, 04 Jan 2023 18:48:24 +0000 Received: by outflank-mailman (input) for mailman id 471383; Wed, 04 Jan 2023 18:48:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD8oJ-0001xC-4K for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 18:48:23 +0000 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [2a00:1450:4864:20::630]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5b9719bd-8c60-11ed-b8d0-410ff93cb8f0; Wed, 04 Jan 2023 19:48:20 +0100 (CET) Received: by mail-ej1-x630.google.com with SMTP id ud5so84922695ejc.4 for ; Wed, 04 Jan 2023 10:48:20 -0800 (PST) Received: from [192.168.1.115] ([185.126.107.38]) by smtp.gmail.com with ESMTPSA id i16-20020a170906115000b008373f9ea148sm15616785eja.71.2023.01.04.10.48.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Jan 2023 10:48:19 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5b9719bd-8c60-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FVquXEatkjsnt7/WWB3T+s6lCdXnkT97jqT/BXU5H7A=; b=zw2gd8LZo8cOpCZglRMftk6BEyJasva6EP/VBZSAXcv9OKOjH6N5pZmQws6Ilaec2r rxXBXUYdnR1hcB2O2ot+/iyc8XC8nfpuzUBB+5mzocUghZoJvzHGGKd4gezz20bRA00L ZPqt2BQcinhISzbDcrGVqFZJ8KKcWNoNxKTW3IS4d8ksDwLdFQ+eRXI0CMTEHZos7nJW 4wydv+J9HUuKhWtC897qN0xbqsbEYNknTQabNmAjuz+S+rKwR+popxvD3jm/yuHfhFWy AMpN+CKtEkpMqQsePykDGSf1bAcgQeFDhx2wYgqLqJO+TotxLXqAY8bJmXoFBYAfllnv FiTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FVquXEatkjsnt7/WWB3T+s6lCdXnkT97jqT/BXU5H7A=; b=ei6Oct+9eEg6p0OQ9ZqtFKvY5r9cFdiP9K8hcBpX/lc991JxuOQ56I+rKTAtS9Ohki 5OKgAJWSBnqDvadu/F3OOpC2oRpzBIeIQLXFyP1bbmQ0Wo6Hw+DEL/VZO6O8+5OoUR62 j+D/Ys/aTSljFZSHnEYsbiyAPvdmn58R1CqkmGTFBs7Sq3m9MEpEdRznZ/VpB2YKR7E9 hMVK0s0aB6+h6V9ci6T/JM3WJklkKdjxZcLuZ9bLghfzN10xuxrlrioNcEGkp7aqIySO zOumbtW7YlBAAqNilUxmvIyy5Iwlh+h6A2NiYo0mUOkL7zWXTZcxOhNAXW1fWk2zUJ3y yB6g== X-Gm-Message-State: AFqh2ko/5UC8owhvfPFr0GQz10WCDL22bthoM246z0R7glYKE7NLzZp6 vRWcPPHIMKsjO0V5e+J4ZBK29w== X-Google-Smtp-Source: AMrXdXtYAXbVIrEFvTkHu0Nr5M4bnN/BQvUtskqbL1WpwJ+T9PNcK0ZQpANoPO0mI9+9TvUnAkcmxg== X-Received: by 2002:a17:907:c68a:b0:84c:e9c4:5751 with SMTP id ue10-20020a170907c68a00b0084ce9c45751mr6014067ejc.74.1672858100076; Wed, 04 Jan 2023 10:48:20 -0800 (PST) Message-ID: Date: Wed, 4 Jan 2023 19:48:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 6/6] hw/isa/piix: Resolve redundant TYPE_PIIX3_XEN_DEVICE Content-Language: en-US To: Chuck Zmudzinski , Bernhard Beschow , qemu-devel@nongnu.org, Markus Armbruster Cc: Richard Henderson , Stefano Stabellini , xen-devel@lists.xenproject.org, =?UTF-8?Q?Herv=c3=a9_Poussineau?= , Aurelien Jarno , Paul Durrant , Marcel Apfelbaum , Anthony Perard , "Michael S. Tsirkin" , Paolo Bonzini , Eduardo Habkost , Thomas Huth References: <20230104144437.27479-1-shentey@gmail.com> <20230104144437.27479-7-shentey@gmail.com> <1c2e0780-e5fb-1321-0d84-b0591db9fec7@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 4/1/23 18:54, Chuck Zmudzinski wrote: > On 1/4/23 10:35 AM, Philippe Mathieu-Daudé wrote: >> +Markus/Thomas >> >> On 4/1/23 15:44, Bernhard Beschow wrote: >>> During the last patches, TYPE_PIIX3_XEN_DEVICE turned into a clone of >>> TYPE_PIIX3_DEVICE. Remove this redundancy. >>> >>> Signed-off-by: Bernhard Beschow >>> --- >>> hw/i386/pc_piix.c | 4 +--- >>> hw/isa/piix.c | 20 -------------------- >>> include/hw/southbridge/piix.h | 1 - >>> 3 files changed, 1 insertion(+), 24 deletions(-) >>> >>> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c >>> index 5738d9cdca..6b8de3d59d 100644 >>> --- a/hw/i386/pc_piix.c >>> +++ b/hw/i386/pc_piix.c >>> @@ -235,8 +235,6 @@ static void pc_init1(MachineState *machine, >>> if (pcmc->pci_enabled) { >>> DeviceState *dev; >>> PCIDevice *pci_dev; >>> - const char *type = xen_enabled() ? TYPE_PIIX3_XEN_DEVICE >>> - : TYPE_PIIX3_DEVICE; >>> int i; >>> >>> pci_bus = i440fx_init(pci_type, >>> @@ -250,7 +248,7 @@ static void pc_init1(MachineState *machine, >>> : pci_slot_get_pirq); >>> pcms->bus = pci_bus; >>> >>> - pci_dev = pci_new_multifunction(-1, true, type); >>> + pci_dev = pci_new_multifunction(-1, true, TYPE_PIIX3_DEVICE); >>> object_property_set_bool(OBJECT(pci_dev), "has-usb", >>> machine_usb(machine), &error_abort); >>> object_property_set_bool(OBJECT(pci_dev), "has-acpi", >>> diff --git a/hw/isa/piix.c b/hw/isa/piix.c >>> index 98e9b12661..e4587352c9 100644 >>> --- a/hw/isa/piix.c >>> +++ b/hw/isa/piix.c >>> @@ -33,7 +33,6 @@ >>> #include "hw/qdev-properties.h" >>> #include "hw/ide/piix.h" >>> #include "hw/isa/isa.h" >>> -#include "hw/xen/xen.h" >>> #include "sysemu/runstate.h" >>> #include "migration/vmstate.h" >>> #include "hw/acpi/acpi_aml_interface.h" >>> @@ -465,24 +464,6 @@ static const TypeInfo piix3_info = { >>> .class_init = piix3_class_init, >>> }; >>> >>> -static void piix3_xen_class_init(ObjectClass *klass, void *data) >>> -{ >>> - DeviceClass *dc = DEVICE_CLASS(klass); >>> - PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); >>> - >>> - k->realize = piix3_realize; >>> - /* 82371SB PIIX3 PCI-to-ISA bridge (Step A1) */ >>> - k->device_id = PCI_DEVICE_ID_INTEL_82371SB_0; >>> - dc->vmsd = &vmstate_piix3; >> >> IIUC, since this device is user-creatable, we can't simply remove it >> without going thru the deprecation process. Alternatively we could >> add a type alias: >> >> -- >8 -- >> diff --git a/softmmu/qdev-monitor.c b/softmmu/qdev-monitor.c >> index 4b0ef65780..d94f7ea369 100644 >> --- a/softmmu/qdev-monitor.c >> +++ b/softmmu/qdev-monitor.c >> @@ -64,6 +64,7 @@ typedef struct QDevAlias >> QEMU_ARCH_LOONGARCH) >> #define QEMU_ARCH_VIRTIO_CCW (QEMU_ARCH_S390X) >> #define QEMU_ARCH_VIRTIO_MMIO (QEMU_ARCH_M68K) >> +#define QEMU_ARCH_XEN (QEMU_ARCH_ARM | QEMU_ARCH_I386) >> >> /* Please keep this table sorted by typename. */ >> static const QDevAlias qdev_alias_table[] = { >> @@ -111,6 +112,7 @@ static const QDevAlias qdev_alias_table[] = { >> { "virtio-tablet-device", "virtio-tablet", QEMU_ARCH_VIRTIO_MMIO }, >> { "virtio-tablet-ccw", "virtio-tablet", QEMU_ARCH_VIRTIO_CCW }, >> { "virtio-tablet-pci", "virtio-tablet", QEMU_ARCH_VIRTIO_PCI }, >> + { "PIIX3", "PIIX3-xen", QEMU_ARCH_XEN }, > > Hi Bernhard, > > Can you comment if this should be: > > + { "PIIX", "PIIX3-xen", QEMU_ARCH_XEN }, > > instead? IIUC, the patch series also removed PIIX3 and PIIX4 and > replaced them with PIIX. Or am I not understanding correctly? There is a confusion in QEMU between PCI bridges, the first PCI function they implement, and the other PCI functions. Here TYPE_PIIX3_DEVICE means for "PCI function part of the PIIX south bridge chipset, which expose a PCI-to-ISA bridge". A better name could be TYPE_PIIX3_ISA_PCI_DEVICE. Unfortunately this device is named "PIIX3" with no indication of ISA bridge. From xen-devel-bounces@lists.xenproject.org Wed Jan 04 19:15:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 19:15:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471391.731224 (Exim 4.92) (envelope-from ) id 1pD9Eg-0005HN-Cj; Wed, 04 Jan 2023 19:15:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471391.731224; Wed, 04 Jan 2023 19:15:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD9Eg-0005HG-A1; Wed, 04 Jan 2023 19:15:38 +0000 Received: by outflank-mailman (input) for mailman id 471391; Wed, 04 Jan 2023 19:15:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD9Ee-0005HA-Gb for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 19:15:36 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 290561a0-8c64-11ed-91b6-6bf2151ebd3b; Wed, 04 Jan 2023 20:15:35 +0100 (CET) Received: from mail-dm6nam11lp2172.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.172]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Jan 2023 14:15:24 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SJ0PR03MB5423.namprd03.prod.outlook.com (2603:10b6:a03:28c::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Wed, 4 Jan 2023 19:15:16 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5944.019; Wed, 4 Jan 2023 19:15:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 290561a0-8c64-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1672859735; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=ES+kHXVNJkaJV81kDGifXMUJBPFcIwo0/HwQsQat0AE=; b=WNelfR7GPnBn1EPbkjRIgrAl4qehZTtd29k/1ArIpo0PnAGlMFfGZoZU vvRRHhWFHVBqoEzngkBk6Pmr6e95nBP4Jpqhep9yHL9TustBjdoIgCCnQ ogvv1gy4Tktfjs6ryAz72HdAHHO9Wp4d4R9w6t/hA8Msysa4WfsdFoS9T s=; X-IronPort-RemoteIP: 104.47.57.172 X-IronPort-MID: 90682189 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:1sxPZ6wvRxZNrVaCJGF6t+f9xyrEfRIJ4+MujC+fZmUNrF6WrkVSm moZCjiCbP7ZZ2P3LdEnPtix9E8DvJSBzt5lHgVqpSAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTbaeYUidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+U0HUMja4mtC5QRnPawT4DcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KSIXq 9lbBzsnVUykpvyH4qmZRc5AhMt2eaEHPKtH0p1h5RfwKK9/BLzmHeDN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvjeVlVMruFTuGIO9ltiibMNZhEuH4 EnB+Hz0GEoyP92D0zuVtHmrg4cjmAuqANxCTuTop5aGhnXJlmZPLBIKWWCwitDnuGyneNN1d k0br39GQa8asRbDosPGdx+yrWOAvxUcc8FNCOB84waIooLP+BqQDGUASj9HafQludUwSDhs0 UWG9/v2ARR/vbvTTmiSnp+WsDezNC49PWIEIygeQmMt89Tl5Y0+kB/LZtJiC7KuyM34Hynqx DKHpzR4gK8c5fPnzI2+9FHDxj6p+J7AS1ds4h2NBz3/qARkeISieoqkr0DB6upNJ5qYSV/Hu 2UYn8+Z76YFCpTleDGxfdjh1YqBv56tWAAwS3Y0d3X931xBI0KeQL0= IronPort-HdrOrdr: A9a23:CfHTEq1Oiy4b5QOZft5SKwqjBKMkLtp133Aq2lEZdPU1SKGlfq WV954mPHDP6Ar5J0tQ++xoVJPufZq+z/JICOsqTNSftWDd0QOVxepZjLcKrQePJ8T2zJ856Z td X-IronPort-AV: E=Sophos;i="5.96,300,1665460800"; d="scan'208";a="90682189" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VbkJ81F2guUFQ+9R/QitJS11I7xkpRJAbQ8Jwn2JKbVPUdy6VX7VzQ5BXQByDGlU226PUFXp94fhTGhSaDmVY/7Z3tF5GLQaRu+ciAKRA468IZD/9tsxOkOsy+lIkebLks5kL4c45lPuOGnvlatiqEBGQy75vwLGImN07qWlOG/QoBgC+xJf1LRzTDyQKsHC4kKSiVQeT3GnijDQODytrUiaB0QywknZrVGR3q0cT3YSbjjacH8074kGVm1nZVIiMPCHnBwIs14CRXEfqiYkZC2sGvXTd+S6KC0oTlqtYLBcx5qXuue+kdB8xZWLUArSt/c9q0ZAQTj8t7MyvBeB8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ES+kHXVNJkaJV81kDGifXMUJBPFcIwo0/HwQsQat0AE=; b=UgC4XwWw58TJrRl0Yi2lbOQQDvtskvPKjka/7lktz2ULs74S64CXKuu7oEjsMeAk68A62KfIfdJLFkSAa/M0CYWlStdiybN49eQ9rGNzVd+yrE1BgZoxFqoMo5CXmwl0q7JQawT6dlccMecfB8q4LxFAgLc44W4zIZz8VBocKdWfJokdWcbZmoIFyi3VwfAScAtQ0WPGlTIgJi/hOOmiWljiiHSHhv1lCpmZilmu9j4MvDHvBt82hQAZXfg0dsNqvSEISfD9H9fjguX8U+2Pkp8237N7G4y3EhvG+bTRLvdgC9gT9Tf90YKFJanK34RN14EnpT1psLCuVBG63CL3Ng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ES+kHXVNJkaJV81kDGifXMUJBPFcIwo0/HwQsQat0AE=; b=Ui+GYpNj2ewOOFdUmzktB3KSlfnIIvzI2O5VXXLKV3FD3I2x5RQ3MPW2n12HIR1hCJyliq8nXOWg3ib68Bk9YsfSFM5+6ySD8sf5bXq0grxNYOOzAbEejKTtFmEI2PRWylDUG2woWCl8OesJ9GPTNiEQS6QooSbRqO9A/yT3jW0= From: Andrew Cooper To: Jan Beulich CC: George Dunlap , Stefano Stabellini , Wei Liu , Julien Grall , Xen-devel Subject: Re: [PATCH 2/4] xen/version: Drop compat/kernel.c Thread-Topic: [PATCH 2/4] xen/version: Drop compat/kernel.c Thread-Index: AQHZH69b2rEsPPoAl0SiHrhvZ3gYIK6Oc/AAgAAucYA= Date: Wed, 4 Jan 2023 19:15:15 +0000 Message-ID: References: <20230103200943.5801-1-andrew.cooper3@citrix.com> <20230103200943.5801-3-andrew.cooper3@citrix.com> <074042f5-ecc1-11c9-bdcd-b9d619475d58@suse.com> In-Reply-To: <074042f5-ecc1-11c9-bdcd-b9d619475d58@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|SJ0PR03MB5423:EE_ x-ms-office365-filtering-correlation-id: 9e38970d-5cbc-4f84-d7d8-08daee8802f8 x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wa8cPpSWkVRdQGIKDEKzyo//wjwv5VcoXFgePCyIPoo2WYZVpgST/XKO2VxACD0g9Vv2phbYAh8hOO8LPHqr3LjjVQoXLvz340KIE/zlVU0pZyNUJPIq3jvIOOTvp1TjDFlhcaapJIxtBuJszWzI6c7GpfAyuHHtMnD9KYKIOqV7jQ++XmsF7qxi8ocjAfUpO9e/DaBcA/asmOe9s8JadVvP4j+rZHrySZJpsGd74EoFpNs6F6fYyo6uovoJUHJWQ+hkqSFFjIe6Fb8KCGGHakNcN5BONNbDNNDoSl2grv9YTJiHgKWtwA3RuLaKmTedSqN6KsWg8NBh9OVgTylMZG1cO83wUyYHsVVhf/Jff/1U8LBnXiS3k0YoH0c07BcR2uVoprekg52qyX6GJTezazqeGgxEVmjAVm650TV25pu2TG0u5h5Ay1ccTG4pPycm6svcyPLSgXd2dbLzFXS14ZKX/pfLd3yqu4u9p+ukLNzPGU9nhSit61qQHpUqS6pyxQ9Y8aiI2IcDLKXmd5prNC5rJzV1FDfIViWvkrijYgqF8cwQA6Gdx9EpowhQo5FxoYCNJvXWUMVRKkI4/USXligU9FfFrYfE81n2fwXe6r467z62PfddhsP5tkmXll+tYw0EgoUnnJhtK08SaSqrlkqpcZujNHJG1y97WvLZIvm0VdC01+wyrvHwTKVM4pLmdrq60Y+rKg5QZNto0X55pkZKwFz/rVgxqhq31TI0Ro9OnUrZY/Se4iquK3c0AePhdpeObBh0rWQiHaaKTUIjmA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(366004)(39860400002)(396003)(136003)(346002)(451199015)(5660300002)(2906002)(8936002)(8676002)(4326008)(31686004)(41300700001)(66556008)(54906003)(316002)(66946007)(76116006)(64756008)(6916009)(91956017)(66446008)(6486002)(478600001)(71200400001)(66476007)(2616005)(53546011)(6506007)(186003)(6512007)(26005)(83380400001)(122000001)(38100700002)(82960400001)(38070700005)(31696002)(86362001)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?dEl2bFhMcTRldXFoVExGcmZkRHQxZy9pUVV1aDQ5WldVaHhMcGdrMVV5cjdh?= =?utf-8?B?QkZ2VGpnek1md1NNL3ZYRnJPQWF2ck0xTXBxUFQ4TmdHdzNwZmNPbks3NVRs?= =?utf-8?B?MkkydnhhTGVVWXhURE12eVVmWitJbkpma0g3K2dRNXRvMHFYVDZRYkhPUzI2?= =?utf-8?B?UzVNYW5TVWpDSWRXT2RnVmpmQU51SWJEOU9Tc0dYZnkyZi9sVDBqSGpsZUQr?= =?utf-8?B?aS9HUlhBK3Y5ejJCTWJ6TmUvYnQzbUZiaEhWQlloNW52c2RJRzdHSHZyaC94?= =?utf-8?B?T0hOMDA1MXFtb0lCMVJZdCsxWUJzSENVMTdIaXlzSUNJQnpoQXNEOGlnRUtx?= =?utf-8?B?VWZJZUNPaHArcDZSTVFXZXNTamhmekQ0LzBhZmt1M0h3UUEvTmh2QTJEcVJn?= =?utf-8?B?c2EraEFpaG9Zcy9YSzhwcmNxRkxwRDZyakI4VWF5bldkVk9obXFwQ2Nwc2dm?= =?utf-8?B?RzNKVWtVK2FxL01VQ3gxb2ZYWTY0NmZBT3c4cGRlRzFVV2QvNXlkL3dVaGV6?= =?utf-8?B?d2ZpbkgxSG91d0pGcmYvaFBhSzM5aUdUSWlEempaZkcvUmVxL3JyL0pzTkNX?= =?utf-8?B?RDZ6ZFo1OTZlVUpzUkFXNndSRkQvREJuYmJXQS9uQlRMK3FOYUN2SVd2UzRy?= =?utf-8?B?R0hPaFo5ZVNxTGNKSXA5Mkd1cEdOVExJQ0kzUTNsYVlKREd4RFdTTTY3dUtC?= =?utf-8?B?bU95NnkxQlBZNXFKRTc2a3h0ZUtxVjlPV0lhWEw5MHpESzc4OEZTOTVvdGhl?= =?utf-8?B?aEhuUlVBVWVOeHY4RkxlT1pOUWZmRmxGcHN0UTZZalJmYThpQzJ0aU5lSVJF?= =?utf-8?B?THM5NU5RVlpSQkZ0c21mMis5Wnp5aFVnSVluK0cxcGd0L0pvam9wanVuSjhL?= =?utf-8?B?YnprMldRakJzTlVHR1J3djJaZUZ1Y3RjZmovc1RUdDhZeGJRZnluNUQ3R2ZJ?= =?utf-8?B?R3E4VUZmc3ZhcDFaWWZCSXR5L2NKeHR0U2IvbUpjYXQ1TDVZWW1PdjhtWFV2?= =?utf-8?B?Nit1MVQ1Q0RTeURRV3U0aWFsNzBDYmh6YXF4NTRDaWRzME5XY3EzbDUwY3Vx?= =?utf-8?B?bzVpTmRuQUFhYXF5elQyd3cyMGVYZzJtbUpWSE1MTlVhT0tlUDhiQ3NQdCto?= =?utf-8?B?cUZraENRaEFGQzA4V2E0T0NVK3QyYndjZU1HenpFVW03L0xpaXVjYXJZYnBr?= =?utf-8?B?VTkrZElaZWxGaGJPME9MRGhUdCt2RlZmQldXdDRMQjduZkRWYUl5WWdGd1VT?= =?utf-8?B?VEQ1SFdGbkVNUjJ3U0pzR1ZrakVDcmJPUlZ6SFppZEZtYlI2LzBvZGoxQkxL?= =?utf-8?B?T3RUdndxRHN3cDNhekZaanh3SDB3TTNNdmJuL0I0V2pyL3lzMWZyVEFlczBr?= =?utf-8?B?K3B6d1dvN1U0WUw1Qm5IOXlsZnB5YkpuajljeWxneFk1WnBscCsvQUdJRnFQ?= =?utf-8?B?eGdzMFhwcEZCanB5TDY5ZHY2bXlFRmNvbTQ4aTFTcHR0dDZNYnkxaE8zZFFz?= =?utf-8?B?UWNxdEltUWVrd2hST0RaT2xVSnpmWXRpYmNTN0FLUjI0OWhtSjFiQ0UyTkdX?= =?utf-8?B?S1U3R09kWko3QnJITUNVbWxqeTl5U3RQcHkvakkxdEZpZ3lweWRlVDI2ejBP?= =?utf-8?B?MHpoL0pncENwMml2YkNjSStVN1IrZFRVUGYyVEc3cTd5djQ1Vi90MVUxOGp1?= =?utf-8?B?MHNvSlU0cEp1SVp2b05ESm1hTzJpcnh6YWRGZVdyV3NkVkgxb0FhdTUybGpW?= =?utf-8?B?VjIxZTBxd2wxSlhDekJnVUVnWVhBbzM4SSt3alZxdVFRZDFwUCtMTHY3d2dH?= =?utf-8?B?bmEycnZUWVViT1FDOGZBbldjbE9LeGhRSmFjQ090NEo0TW9tSVdzemFBYmFN?= =?utf-8?B?OW8va3ZtNXdOSFM0UTBhSlFrUFlOTFNIV2liUzluREFWQVhkQnpXSWpnbEJm?= =?utf-8?B?THYwa09lNTIzMmtucHdHSE5tZ1ptalpVS2JsVll0T2w1TjJ4RExYZS8zS2ZC?= =?utf-8?B?bm50aUcveGZBb0hnMGhFdytFbER5ZlhQUHhsUEkvaE5QenFScUM4cmNwSWxO?= =?utf-8?B?ZzlmTWpYZzFWKzFrK0hkVXU2QXQvTEx5anhpeHYrZnJXbXVrMzBwUUplM0Fv?= =?utf-8?B?NkZWcDVFK3NwQ3ZHcjNIWm1YeWJjRlpOQzR6UkNPeXFRRVRwbGRnc0REMmh5?= =?utf-8?B?TUE9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <13739C70CA4FD642898371BD8B097636@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: ZkQnKcX4CgEUtA9dnFwEVhh+xG+FURvVZkIu35Bghaolde8jnz1pC+eV1fZJ/CLgM7n0PVIv5a6+r2Rg0lVrtaaUApgoagyO6fKdfG3wXJ/TepiAMSOXbGX9HzUZraVe8lrqxm50eoZUPGdL4aR0vs+ZsrwojcNBi8MYK+scldkfgFpoy58D8M7ANOwqvZBsp9HhBB6W48y2RzjD0hhDK335RbP0vCgsnsDat3+qkeFKniHs+BfJGE8bWkqzhhKKYPpwKo3Nw+SYiVwHRP1lt/6/+t8uj9uHKLzsLXHhNyE6vPme1L4WxjqdPUb6UKN6YHf4fhtwMQSHANQfgl7q9mdNlUB+us+pxzgzVUhm0yU8tVUjdWHTHSd3AtVKlWxGb9mzBwTOA2G3qrHhsPukJ8E1273Au9uRE6fQP+0cw31gwfV8pl+q5MfWxRklnT0PsL1jbg5h7gB68dEaQe+hFENvSfWjy3TpSO6Oq1ohd85tIvwlHSbWDmbAH46ihcYG7AzdIE6Nra15ESBcUwl0qVwP6xO0b89W641JlRsuDKZlYbFcQBqI+j9RePMStDi2FPN99kPnabE3wLtpOW2cxQ+RtUtCFpCnYRqVL/6zePSk6TXenYviAiZfwAbv58KGDy6PKIuDlW1QpZ4aI71WOcaCovuIzoKDEVcYBpNPzkKEbQvLXddpNE6BXc4qvvyayticTXF/tz0LKIrFsJKA0yxgoCV/3H+XgWXca9wwDo1p73SmmSdq+3ZVzRUIJKrAHLNvqgCDFzcUVSSjw6jcMDonnFyEliSM4xRKwRmbJV7FG8Xbh8K6dG2FvOHchVqcvZJe3HP2V8D8dvMfwDtcvaou+bacJFWeyNEBzmQgQFOdxaSwWxJS3+lH6f0nPxo1 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9e38970d-5cbc-4f84-d7d8-08daee8802f8 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jan 2023 19:15:15.9015 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 28EeK6JdHutwXbrLmgxixL6uibIH7zGTH1d19uxJ7x/aRSOzU9+OfBe70avVkcIH/bvm7bfShToag/7xdTZbNevvqBaZ17JF+x3lYSmJyP0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5423 T24gMDQvMDEvMjAyMyA0OjI5IHBtLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMDMuMDEuMjAy MyAyMTowOSwgQW5kcmV3IENvb3BlciB3cm90ZToNCj4+IGtlcm5lbC5jIGlzIG1vc3RseSBpbiBh biAjaWZuZGVmIENPTVBBVCBndWFyZCwgYmVjYXVzZSBjb21wYXQva2VybmVsLmMNCj4+IHJlaW5j bHVkZXMga2VybmVsLmMgdG8gcmVjb21waWxlIHhlbl92ZXJzaW9uKCkgaW4gYSBjb21wYXQgZm9y bS4NCj4+DQo+PiBIb3dldmVyLCB0aGUgeGVuX3ZlcnNpb24gaHlwZXJjYWxsIGlzIGFsbW9zdCBn dWVzdC1BQkktYWdub3N0aWM7IG9ubHkNCj4+IFhFTlZFUl9wbGF0Zm9ybV9wYXJhbWV0ZXJzIGhh cyBhIGNvbXBhdCBzcGxpdC4gIEhhbmRsZSB0aGlzIGxvY2FsbHksIGFuZCBkbw0KPj4gYXdheSB3 aXRoIHRoZSByZWluY2x1ZGUgZW50aXJlbHkuDQo+IEFuZCB3ZSBoZW5jZWZvcnRoIG1lYW4gdG8g bm90IGludHJvZHVjZSBhbnkgaW50ZXJmYWNlIHN0cnVjdHVyZXMgaGVyZQ0KPiB3aGljaCB3b3Vs ZCByZXF1aXJlIHRyYW5zbGF0aW9uIChvciB3ZSdyZSB3aWxsaW5nIHRvIGFjY2VwdCB0aGUgY2x1 dHRlcg0KPiBvZiBoYW5kbGluZyB0aG9zZSAibG9jYWxseSIgYXMgd2VsbCkuIEZpbmUgd2l0aCBt ZSwganVzdCB3YW50aW5nIHRvDQo+IG1lbnRpb24gaXQuDQoNClN1cmUgLSBJJ2xsIHB1dCBhIG5v dGUgaW4gdGhlIGNvbW1pdCBtZXNzYWdlLg0KDQpJbiBnZW5lcmFsLCB3ZSBkb24ndCB3YW50IGd1 ZXN0LXZhcmlhbnQgaW50ZXJmYWNlcy4NCg0KPg0KPj4gLS0tIGEveGVuL2NvbW1vbi9jb21wYXQv a2VybmVsLmMNCj4+ICsrKyAvZGV2L251bGwNCj4+IEBAIC0xLDUzICswLDAgQEANCj4+IC0vKioq KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqDQo+PiAtICoga2VybmVsLmMNCj4+IC0gKi8NCj4+IC0NCj4+IC1F TUlUX0ZJTEU7DQo+PiAtDQo+PiAtI2luY2x1ZGUgPHhlbi9pbml0Lmg+DQo+PiAtI2luY2x1ZGUg PHhlbi9saWIuaD4NCj4+IC0jaW5jbHVkZSA8eGVuL2Vycm5vLmg+DQo+PiAtI2luY2x1ZGUgPHhl bi92ZXJzaW9uLmg+DQo+PiAtI2luY2x1ZGUgPHhlbi9zY2hlZC5oPg0KPj4gLSNpbmNsdWRlIDx4 ZW4vZ3Vlc3RfYWNjZXNzLmg+DQo+PiAtI2luY2x1ZGUgPGFzbS9jdXJyZW50Lmg+DQo+PiAtI2lu Y2x1ZGUgPGNvbXBhdC94ZW4uaD4NCj4+IC0jaW5jbHVkZSA8Y29tcGF0L3ZlcnNpb24uaD4NCj4+ IC0NCj4+IC1leHRlcm4geGVuX2NvbW1hbmRsaW5lX3Qgc2F2ZWRfY21kbGluZTsNCj4+IC0NCj4+ IC0jZGVmaW5lIHhlbl9leHRyYXZlcnNpb24gY29tcGF0X2V4dHJhdmVyc2lvbg0KPj4gLSNkZWZp bmUgeGVuX2V4dHJhdmVyc2lvbl90IGNvbXBhdF9leHRyYXZlcnNpb25fdA0KPj4gLQ0KPj4gLSNk ZWZpbmUgeGVuX2NvbXBpbGVfaW5mbyBjb21wYXRfY29tcGlsZV9pbmZvDQo+PiAtI2RlZmluZSB4 ZW5fY29tcGlsZV9pbmZvX3QgY29tcGF0X2NvbXBpbGVfaW5mb190DQo+PiAtDQo+PiAtQ0hFQ0tf VFlQRShjYXBhYmlsaXRpZXNfaW5mbyk7DQo+IFRoaXMgYW5kIC4uLg0KPg0KPj4gLSNkZWZpbmUg eGVuX3BsYXRmb3JtX3BhcmFtZXRlcnMgY29tcGF0X3BsYXRmb3JtX3BhcmFtZXRlcnMNCj4+IC0j ZGVmaW5lIHhlbl9wbGF0Zm9ybV9wYXJhbWV0ZXJzX3QgY29tcGF0X3BsYXRmb3JtX3BhcmFtZXRl cnNfdA0KPj4gLSN1bmRlZiBIWVBFUlZJU09SX1ZJUlRfU1RBUlQNCj4+IC0jZGVmaW5lIEhZUEVS VklTT1JfVklSVF9TVEFSVCBIWVBFUlZJU09SX0NPTVBBVF9WSVJUX1NUQVJUKGN1cnJlbnQtPmRv bWFpbikNCj4+IC0NCj4+IC0jZGVmaW5lIHhlbl9jaGFuZ2VzZXRfaW5mbyBjb21wYXRfY2hhbmdl c2V0X2luZm8NCj4+IC0jZGVmaW5lIHhlbl9jaGFuZ2VzZXRfaW5mb190IGNvbXBhdF9jaGFuZ2Vz ZXRfaW5mb190DQo+PiAtDQo+PiAtI2RlZmluZSB4ZW5fZmVhdHVyZV9pbmZvIGNvbXBhdF9mZWF0 dXJlX2luZm8NCj4+IC0jZGVmaW5lIHhlbl9mZWF0dXJlX2luZm9fdCBjb21wYXRfZmVhdHVyZV9p bmZvX3QNCj4+IC0NCj4+IC1DSEVDS19UWVBFKGRvbWFpbl9oYW5kbGUpOw0KPiAuLi4gdGhpcyBn byBhd2F5IHdpdGhvdXQgYW55IHJlcGxhY2VtZW50LiBDb25zaWRlcmluZyB0aGV5J3JlIGJvdGgN Cj4gY2hhcltdLCB0aGF0J3MgcHJvYmFibHkgZmluZSwgYnV0IGNvdWxkIGRvIHdpdGggbWVudGlv bmluZyBpbiB0aGUNCj4gZGVzY3JpcHRpb24uDQoNCkkgZGlkIGFjdHVhbGx5IG1lYW4gdG8gYXNr IGFib3V0IHRoZXNlIHR3bywgYmVjYXVzZSB0aGV5J3JlIGluY29tcGxldGUNCmFscmVhZHkuDQoN CldoeSBkbyB3ZSBDSEVDS19UWVBFKGNhcGFiaWxpdGllc19pbmZvKSBidXQgZGVmaW5lIGlkZW50 aXR5IGFsaWFzZXMgZm9yDQpjb21wYXRfZXh0cmF2ZXJzaW9uIChhbW9uZ3N0IG90aGVycykgPw0K DQpJcyB0aGVyZSBldmVuIGEgcG9pbnQgZm9yIGhhdmluZyBhIGNvbXBhdCBhbGlhcyBvZiBhIGNo YXIgYXJyYXk/DQoNCkknbSB0ZW1wdGVkIHRvIGp1c3QgZHJvcCB0aGVtLsKgIEkgZG9uJ3QgdGhp bmsgdGhlIGNoZWNrIGRvZXMgYW55dGhpbmcNCnVzZWZ1bCBmb3IgdXMuDQoNCj4+IEBAIC01MjAs MTIgKzUxOCwyNyBAQCBETyh4ZW5fdmVyc2lvbikoaW50IGNtZCwgWEVOX0dVRVNUX0hBTkRMRV9Q QVJBTSh2b2lkKSBhcmcpDQo+PiAgICAgIA0KPj4gICAgICBjYXNlIFhFTlZFUl9wbGF0Zm9ybV9w YXJhbWV0ZXJzOg0KPj4gICAgICB7DQo+PiAtICAgICAgICB4ZW5fcGxhdGZvcm1fcGFyYW1ldGVy c190IHBhcmFtcyA9IHsNCj4+IC0gICAgICAgICAgICAudmlydF9zdGFydCA9IEhZUEVSVklTT1Jf VklSVF9TVEFSVA0KPj4gLSAgICAgICAgfTsNCj4gV2l0aCB0aGlzIGdvbmUgdGhlIG9kZGx5IChi dXQgaW50ZW50aW9uYWxseSkgcGxhY2VkIGJyYWNlcyBjYW4gdGhlbg0KPiBhbHNvIGdvIGF3YXku DQoNCkluIGxpZ2h0IG9mIGhvdyBwYXRjaCAzIGVuZGVkIHVwLCBJIHdhcyBjb25zaWRlcmluZyBw dWxsaW5nIGN1cnIgb3V0DQppbnRvIGEgdmFyaWFibGUuDQoNCj4gUHJlZmVyYWJseSB3aXRoIHRo ZXNlIG1pbm9yIGFkanVzdG1lbnRzDQo+IFJldmlld2VkLWJ5OiBKYW4gQmV1bGljaCA8amJldWxp Y2hAc3VzZS5jb20+DQoNClRoYW5rcywNCg0KfkFuZHJldw0K From xen-devel-bounces@lists.xenproject.org Wed Jan 04 19:29:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 19:29:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471398.731236 (Exim 4.92) (envelope-from ) id 1pD9SQ-0006oW-Kg; Wed, 04 Jan 2023 19:29:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471398.731236; Wed, 04 Jan 2023 19:29:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD9SQ-0006oP-Gr; Wed, 04 Jan 2023 19:29:50 +0000 Received: by outflank-mailman (input) for mailman id 471398; Wed, 04 Jan 2023 19:29:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD9SP-0006oJ-9P for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 19:29:49 +0000 Received: from sonic306-20.consmr.mail.gq1.yahoo.com (sonic306-20.consmr.mail.gq1.yahoo.com [98.137.68.83]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 24452f5e-8c66-11ed-b8d0-410ff93cb8f0; Wed, 04 Jan 2023 20:29:45 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic306.consmr.mail.gq1.yahoo.com with HTTP; Wed, 4 Jan 2023 19:29:43 +0000 Received: by hermes--production-ne1-7b69748c4d-rglm6 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 6610acf198dd57a5acb45951fb7310cb; Wed, 04 Jan 2023 19:29:38 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 24452f5e-8c66-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1672860583; bh=f38ykNsj5P5917DyUYEqB636yxECNNSILhQF338ksUE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=oskHmGnhbNjCTSYoC2MIf79xuDr6C9L/Ef+Tbju7HlyvAqO67EFex28GmboTCQWrJHmFdUdlHhgxo+dRtqJqbd19qBliT3pf+vURuOAtIAvXoIp0Xv9ptgM0fdRpIigEfJpi23IL6C/Bz6NdSpyH3eXWFUFdP7TUkMydbGc6s1sczjkYzZyzsFh6gYpgj3N9HuWytymGvI0W5f0fAV11Rj0MquVqPXcTr036fT9Nyvju2/tKDkVvZ4XQ55yQPAcn771nMXp78kPJJYsfYaKfMoB/vCjr7SzHaa4dkfGRCdXniPrfqvVp9PC25JBlQ1soisWBnS/5o3bCIEEBCHLWaA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1672860583; bh=TTo4eJza70SWteqIqAHCCivI/STyWz6raPujdPpDkaa=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=LfnkBDyJg/pTxw8b94YEMOQZRCu0D3K1Xa8RyqUFjMB+WhGmO+aWeQ+yENtLZ+dVu38S0ZVrg647scpYoagu1jnICr/Jc/mhTW7syQL7hfaB7eqW78AF818YfU1WUF9Xx7dda8bO8Pk2HAVhc8DT9tYPGImchwmkpi+X8Cxerj7IepMDHVxyYI30yklevOydEspX6jp9EtKvtdr0Md8RInw7P3aS3kiNMELLfvceaG89HP738n9wuCgOFwMkd6N2EG/6tashj5HiSJEphyaAo6GB0g7nYQfhXeSc3ZHmm9JOB/ki0THx4PGhWVE+RO09hOqrnSIZ4OmOrfOVlZ3Ggg== X-YMail-OSG: AYNUE8kVM1n0bruCHoYB.IOVLws3knC5gqJehESqqWC08o0GHu3bTOn0JE.68ZT mbWk_64D8Jw6GmRA..9I9OkdsyArBEY3YVrFWG5CwGDcrttgw68n5loH_fQ0Sfkx66GPrv4P0sZC C6asHdO2VkZknNwpbjkGw7OPb3Cw82gULXWf.Uj5UraX9a3vBoYq0LF1dsIYsKJP2Teqcw6bCsuD HlpI3NB4Y0d0Z2219BZZWOB.xIdR.jpiKrtbybQFlWVYEd1Gg9ErXE8LYwBf34DO2FdOQk4Ut5oK geiGkAY8joeWyr_lGKHV.JII28OcCg3tpYu98lYwjjPbrpOaAjxz9PzkZXEfadFsLfvBa_vAp.ky TDbQ9LF63wt6Vr596iaes631G.LXmJIJGoMBV0XQHhuCrxEO9iAG3nWJuyGDWYNLhiGQif_XQ4be LjAPDUMLeIq6Hd580BEIGUw_DbL0JFRjDZ.Pjr9Bk7Mespxe4WjuBB6s7JKmlAFFQSvCVDjTmr_G U7ZvtqpcFoeH6_7MGjyAXPPbM3fIdU3YcnNvQjbmMJojShDzlnygGOe39v.qrbdKA8kC9Pkx.qWJ 7qtYILJU8Mga1xHV2aap9sKqUPwSApzyHIQqF7B8VSmncfDij27BPiHauaby3tDMEIAZFyjlUbYr XsWeKAWZxNIzas99Pag_PxkkVfTFcDry57eHj2nG1e_RkAywZUIlBnPQUvbtBEQYGezDrQJ7pgga 0hlru888cmjdOLpLZQ5wfXXAtXMmUPq8uW3Z4WPel7ejnt_fKTvv9BAg7x30KxcNRIQmbNn5b69P I6lm97257DJhlyQQ6kmbMMSiC7Oe9d8nFLU7.H4iMciRXQkBHRg7OE93TDiKdKtjaAF.CSsNC7fw pHKd7CQCvxUv6rH63jlZzsrhasGRJE9EDHJEHTVrQiuN5LQjmfHpbc1iWNsLesQCAeW0g1v2k0Xc rTXmqodsgUKdMhX64F_Enbu7rnG8FrtXDYPIGgHO6MMUOJt20GYOhBUYaSIx9lzOxICHu8JjhB8l BBrJQY61_n3.DWSezPfJsM0UaDU7cYjojPryDyP2pzdnhi3v0zkMbIovNGSmWz23_2hebNMnD8RP _MLh4Xmk7mPzbAhFMxJ95dnRHkDtNTM5QcwfrbxDB3WzbnxrNBKspN648w4y5wsDA5vyiGT0Qfnu XU7fiuKeftpByta2nvdVVtWXfFKtWYch82dPlN3NLBrX80Blc.B4P_gCUDbLyTC2IO8grjkcspFa hMrblJi_CEkOiybPwQ2VmYEf99bk2BOCKOWkfPTQUV0dc7WEyVGDlk4C9uylC4ZJpy6fDoKCmnh2 ay7qy.GxbzOB.yUbYJGh4h7kfOkcBOXgGFJPJFWuulgVEYnvXMBFaZgNzUGTlGiz8MmSuhXNhPZt DXi3GNLoEp6jxi5KzBmKQ4FNYW2NoQKhrbnrm8sVxzZ_Llsmd2goQeeW9zxtvN8rjvNcoV4R6jUG ssV7T6dj6OCblboyS7CcliN80tpppepzyHTUNeM8OZe5YeJCUF3h7xVLh1onukIsLkLsF9.HrCY6 0cGuRFmmR3LBcWrJ3gfMt2skDyluUiw4ZAS5Kd6PuUnP9Ux6oK.stKkNfRToK.Nbg_T7g_n0Gm_B cacRgJ1nm4lX1m6z0KlyQfopoVFKwiqdwpmJM3SHX48pWy2A5wK8JcS7Jf19Og87IVHKMhCh.XV3 Ejtb_HjsAXyYCtgHbLUnD0dM2oeWtiLsKufzHF.wV3UqLjfq_vHX2Z_ST9fp2Oqrqn6CWkm5bCnm zfPfpJqiNCuUVP5b8EvnW8d37p4Y2mqx46_w.meadkhD7XSHAPrEO3XhMkYufO8GfRtUMHRU48gI ZhAUGWpMmuGAJ24FtR_zT0w6QAJLrvKeCNTsjjgh_9FPlaUTI8RCOrGn.lIB6G9GSn31y0DOrrlk 8F0Hx8mbjp_VkJ_jmoG8MG.X9MNTws6PtV0KhK_5GqHJ.T9B6le284N.rXbFW8WXeQc8zfeNk67M 8uIT1CnZewnDNMICpbpYEMvk4Tmg5Klc425MttS_EpLzavr617uh1R7vkihEs7tgoJZ6sjLphJA5 GeQWmp8b2w62DyIRnbSAcAWVXFYD9dEbn8NHXgLQvd9BYsB0WkPbZN8Q9a70h197OqtyTLL10.Lv VUuTlCqfTKljNlwzUF5mv.XONurczDHfHPe.6jJzOQvhWN31kopHC3EpCqZU4YWx.YbB41sdupog EtoozBnGiaz4t3UepihlDMQ-- X-Sonic-MF: Message-ID: <92efe0f1-f22b-47bc-f27d-2f31cb3621ea@aol.com> Date: Wed, 4 Jan 2023 14:29:35 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v2 6/6] hw/isa/piix: Resolve redundant TYPE_PIIX3_XEN_DEVICE To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Bernhard Beschow , qemu-devel@nongnu.org, Markus Armbruster Cc: Richard Henderson , Stefano Stabellini , xen-devel@lists.xenproject.org, =?UTF-8?Q?Herv=c3=a9_Poussineau?= , Aurelien Jarno , Paul Durrant , Marcel Apfelbaum , Anthony Perard , "Michael S. Tsirkin" , Paolo Bonzini , Eduardo Habkost , Thomas Huth References: <20230104144437.27479-1-shentey@gmail.com> <20230104144437.27479-7-shentey@gmail.com> <1c2e0780-e5fb-1321-0d84-b0591db9fec7@linaro.org> Content-Language: en-US From: Chuck Zmudzinski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.20982 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 5455 On 1/4/23 1:48 PM, Philippe Mathieu-Daudé wrote: > On 4/1/23 18:54, Chuck Zmudzinski wrote: >> On 1/4/23 10:35 AM, Philippe Mathieu-Daudé wrote: >>> +Markus/Thomas >>> >>> On 4/1/23 15:44, Bernhard Beschow wrote: >>>> During the last patches, TYPE_PIIX3_XEN_DEVICE turned into a clone of >>>> TYPE_PIIX3_DEVICE. Remove this redundancy. >>>> >>>> Signed-off-by: Bernhard Beschow >>>> --- >>>> hw/i386/pc_piix.c | 4 +--- >>>> hw/isa/piix.c | 20 -------------------- >>>> include/hw/southbridge/piix.h | 1 - >>>> 3 files changed, 1 insertion(+), 24 deletions(-) >>>> >>>> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c >>>> index 5738d9cdca..6b8de3d59d 100644 >>>> --- a/hw/i386/pc_piix.c >>>> +++ b/hw/i386/pc_piix.c >>>> @@ -235,8 +235,6 @@ static void pc_init1(MachineState *machine, >>>> if (pcmc->pci_enabled) { >>>> DeviceState *dev; >>>> PCIDevice *pci_dev; >>>> - const char *type = xen_enabled() ? TYPE_PIIX3_XEN_DEVICE >>>> - : TYPE_PIIX3_DEVICE; >>>> int i; >>>> >>>> pci_bus = i440fx_init(pci_type, >>>> @@ -250,7 +248,7 @@ static void pc_init1(MachineState *machine, >>>> : pci_slot_get_pirq); >>>> pcms->bus = pci_bus; >>>> >>>> - pci_dev = pci_new_multifunction(-1, true, type); >>>> + pci_dev = pci_new_multifunction(-1, true, TYPE_PIIX3_DEVICE); >>>> object_property_set_bool(OBJECT(pci_dev), "has-usb", >>>> machine_usb(machine), &error_abort); >>>> object_property_set_bool(OBJECT(pci_dev), "has-acpi", >>>> diff --git a/hw/isa/piix.c b/hw/isa/piix.c >>>> index 98e9b12661..e4587352c9 100644 >>>> --- a/hw/isa/piix.c >>>> +++ b/hw/isa/piix.c >>>> @@ -33,7 +33,6 @@ >>>> #include "hw/qdev-properties.h" >>>> #include "hw/ide/piix.h" >>>> #include "hw/isa/isa.h" >>>> -#include "hw/xen/xen.h" >>>> #include "sysemu/runstate.h" >>>> #include "migration/vmstate.h" >>>> #include "hw/acpi/acpi_aml_interface.h" >>>> @@ -465,24 +464,6 @@ static const TypeInfo piix3_info = { >>>> .class_init = piix3_class_init, >>>> }; >>>> >>>> -static void piix3_xen_class_init(ObjectClass *klass, void *data) >>>> -{ >>>> - DeviceClass *dc = DEVICE_CLASS(klass); >>>> - PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); >>>> - >>>> - k->realize = piix3_realize; >>>> - /* 82371SB PIIX3 PCI-to-ISA bridge (Step A1) */ >>>> - k->device_id = PCI_DEVICE_ID_INTEL_82371SB_0; >>>> - dc->vmsd = &vmstate_piix3; >>> >>> IIUC, since this device is user-creatable, we can't simply remove it >>> without going thru the deprecation process. Alternatively we could >>> add a type alias: >>> >>> -- >8 -- >>> diff --git a/softmmu/qdev-monitor.c b/softmmu/qdev-monitor.c >>> index 4b0ef65780..d94f7ea369 100644 >>> --- a/softmmu/qdev-monitor.c >>> +++ b/softmmu/qdev-monitor.c >>> @@ -64,6 +64,7 @@ typedef struct QDevAlias >>> QEMU_ARCH_LOONGARCH) >>> #define QEMU_ARCH_VIRTIO_CCW (QEMU_ARCH_S390X) >>> #define QEMU_ARCH_VIRTIO_MMIO (QEMU_ARCH_M68K) >>> +#define QEMU_ARCH_XEN (QEMU_ARCH_ARM | QEMU_ARCH_I386) >>> >>> /* Please keep this table sorted by typename. */ >>> static const QDevAlias qdev_alias_table[] = { >>> @@ -111,6 +112,7 @@ static const QDevAlias qdev_alias_table[] = { >>> { "virtio-tablet-device", "virtio-tablet", QEMU_ARCH_VIRTIO_MMIO }, >>> { "virtio-tablet-ccw", "virtio-tablet", QEMU_ARCH_VIRTIO_CCW }, >>> { "virtio-tablet-pci", "virtio-tablet", QEMU_ARCH_VIRTIO_PCI }, >>> + { "PIIX3", "PIIX3-xen", QEMU_ARCH_XEN }, >> >> Hi Bernhard, >> >> Can you comment if this should be: >> >> + { "PIIX", "PIIX3-xen", QEMU_ARCH_XEN }, >> >> instead? IIUC, the patch series also removed PIIX3 and PIIX4 and >> replaced them with PIIX. Or am I not understanding correctly? > > There is a confusion in QEMU between PCI bridges, the first PCI > function they implement, and the other PCI functions. > > Here TYPE_PIIX3_DEVICE means for "PCI function part of the PIIX > south bridge chipset, which expose a PCI-to-ISA bridge". A better > name could be TYPE_PIIX3_ISA_PCI_DEVICE. Unfortunately this > device is named "PIIX3" with no indication of ISA bridge. Thanks, you are right, I see the PIIX3 device still exists after this patch set is applied. chuckz@debian:~/sources-sid/qemu/qemu-7.50+dfsg/hw/i386$ grep -r PIIX3 * pc_piix.c: pci_dev = pci_new_multifunction(-1, true, TYPE_PIIX3_DEVICE); I also understand there is the PCI-to-ISA bridge at 00:01.0 on the PCI bus: chuckz@debian:~$ lspci 00:00.0 Host bridge: Intel Corporation 440FX - 82441FX PMC [Natoma] (rev 02) 00:01.0 ISA bridge: Intel Corporation 82371SB PIIX3 ISA [Natoma/Triton II] 00:01.1 IDE interface: Intel Corporation 82371SB PIIX3 IDE [Natoma/Triton II] 00:01.2 USB controller: Intel Corporation 82371SB PIIX3 USB [Natoma/Triton II] (rev 01) 00:01.3 Bridge: Intel Corporation 82371AB/EB/MB PIIX4 ACPI (rev 03) 00:02.0 Unassigned class [ff80]: XenSource, Inc. Xen Platform Device (rev 01) 00:03.0 VGA compatible controller: Device 1234:1111 (rev 02) I also see with this patch, there is a bridge that is a PIIX4 ACPI at 00:01.3. I get the exact same output from lspci without the patch series, so that gives me confidence it is working as designed. From xen-devel-bounces@lists.xenproject.org Wed Jan 04 19:45:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 19:45:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471428.731263 (Exim 4.92) (envelope-from ) id 1pD9hK-0001kH-D9; Wed, 04 Jan 2023 19:45:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471428.731263; Wed, 04 Jan 2023 19:45:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD9hK-0001kA-AX; Wed, 04 Jan 2023 19:45:14 +0000 Received: by outflank-mailman (input) for mailman id 471428; Wed, 04 Jan 2023 19:45:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD9hI-0001jw-AI for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 19:45:12 +0000 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [2a00:1450:4864:20::636]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4cb32b48-8c68-11ed-91b6-6bf2151ebd3b; Wed, 04 Jan 2023 20:45:11 +0100 (CET) Received: by mail-ej1-x636.google.com with SMTP id gh17so85261134ejb.6 for ; Wed, 04 Jan 2023 11:45:11 -0800 (PST) Received: from ?IPv6:::1? (p200300faaf0bb2008108eedf25879029.dip0.t-ipconnect.de. [2003:fa:af0b:b200:8108:eedf:2587:9029]) by smtp.gmail.com with ESMTPSA id z27-20020a1709063a1b00b007aea1dc1840sm15719325eje.111.2023.01.04.11.45.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Jan 2023 11:45:10 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4cb32b48-8c68-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=1kn+AYwd9lDHGXpUlw4WpNPWS0CBUeFg+5hmPOLLj2g=; b=fvw62VWCDMnjcXtA15FzvRRp64P3oNkuH/ZltE0KWoV3o5+NfP4Ep0LVLGB6BHpgz8 2Es1/5ovPDWfohWdEir7Lop58w3KC26cxxW7sEFJ+B2G3/yy/h4scu0L3/FIKuox1XJd xLvm6xNx3sWjWoNGXqKJaeCSKnBQfv1haPzSX96eK78sKGQ30cH/WXUrw+ON92w5vn1v Z/IHW7X1e1HEZjzNyY9CJFsWR/2BRBjrsPP6sgAB/zJfWILsX8GUCR5Q/d+H4EoGauh5 Px2Z0t6pzlXUdOEy9ObdXzVkC3QdPrGLGtwNo9YLG4bbkDjkb1L0WjI9fzb2tfshqP7C FoYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1kn+AYwd9lDHGXpUlw4WpNPWS0CBUeFg+5hmPOLLj2g=; b=o/3DD3DTtg2mLixFGXIMsgczFpU/61gj5flWVVoeauF16vqJTM/Ae7cDEvonsOxP35 0LpfbRskZfJif7JoyMYsPikKnyTcz/+q1u6OGbdvVkrhxE5FjxzqqTRVj50XO3+jjN/d KmxkeIP1JETVl+fi2MFMLC+YUM7NomtuFYkjz+0iyjb7XZQ2Q0rMt1ZHXSOnOHwTdc1m /1lWioUBL82R235RFUpPi4uliGIn8uZ8am8uCO7hahEEg4zQjnDrlowRN33cOgV+T9Zx OM/1nOjxvKk8r0eJiJBrcWWpqa8aMCsw/tDTk7NNawcHzvPUHTktTJaCaRFTbbdDcesX w9qQ== X-Gm-Message-State: AFqh2kqM7ApbUMtsdwg3Pc7ISuVNc1ujiliak5MCYWov3eN951qrTHvo VzlQRYGpQIb6GHYiWkPbcDI= X-Google-Smtp-Source: AMrXdXu2tDDJFnRrl/d4WpCbxJux1PU03beEP+9otm5co6/WDkq8FqU81+yT4TaSGMFOmqXiN0FxFg== X-Received: by 2002:a17:907:8b09:b0:7c0:e5c8:d439 with SMTP id sz9-20020a1709078b0900b007c0e5c8d439mr45326486ejc.3.1672861510655; Wed, 04 Jan 2023 11:45:10 -0800 (PST) Date: Wed, 04 Jan 2023 19:45:04 +0000 From: Bernhard Beschow To: Chuck Zmudzinski , qemu-devel@nongnu.org, =?ISO-8859-1?Q?Philippe_Mathieu-Daud=E9?= CC: Richard Henderson , Stefano Stabellini , xen-devel@lists.xenproject.org, =?ISO-8859-1?Q?Herv=E9_Poussineau?= , Aurelien Jarno , Paul Durrant , Marcel Apfelbaum , Anthony Perard , "Michael S. Tsirkin" , Paolo Bonzini , Eduardo Habkost Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_v2_6/6=5D_hw/isa/piix=3A_Res?= =?US-ASCII?Q?olve_redundant_TYPE=5FPIIX3=5FXEN=5FDEVICE?= In-Reply-To: <30ed41ab-f7c9-15fb-8f4b-b2742b1d4188@aol.com> References: <20230104144437.27479-1-shentey@gmail.com> <20230104144437.27479-7-shentey@gmail.com> <30ed41ab-f7c9-15fb-8f4b-b2742b1d4188@aol.com> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Am 4=2E Januar 2023 16:42:43 UTC schrieb Chuck Zmudzinski : >On 1/4/23 9:44=E2=80=AFAM, Bernhard Beschow wrote: >> During the last patches, TYPE_PIIX3_XEN_DEVICE turned into a clone of >> TYPE_PIIX3_DEVICE=2E Remove this redundancy=2E >>=20 >> Signed-off-by: Bernhard Beschow >> --- >> hw/i386/pc_piix=2Ec | 4 +--- >> hw/isa/piix=2Ec | 20 -------------------- >> include/hw/southbridge/piix=2Eh | 1 - >> 3 files changed, 1 insertion(+), 24 deletions(-) >>=20 >> diff --git a/hw/i386/pc_piix=2Ec b/hw/i386/pc_piix=2Ec >> index 5738d9cdca=2E=2E6b8de3d59d 100644 >> --- a/hw/i386/pc_piix=2Ec >> +++ b/hw/i386/pc_piix=2Ec >> @@ -235,8 +235,6 @@ static void pc_init1(MachineState *machine, >> if (pcmc->pci_enabled) { >> DeviceState *dev; >> PCIDevice *pci_dev; >> - const char *type =3D xen_enabled() ? TYPE_PIIX3_XEN_DEVICE >> - : TYPE_PIIX3_DEVICE; >> int i; >> =20 >> pci_bus =3D i440fx_init(pci_type, >> @@ -250,7 +248,7 @@ static void pc_init1(MachineState *machine, >> : pci_slot_get_pirq); >> pcms->bus =3D pci_bus; >> =20 >> - pci_dev =3D pci_new_multifunction(-1, true, type); >> + pci_dev =3D pci_new_multifunction(-1, true, TYPE_PIIX3_DEVICE)= ; >> object_property_set_bool(OBJECT(pci_dev), "has-usb", >> machine_usb(machine), &error_abort); >> object_property_set_bool(OBJECT(pci_dev), "has-acpi", >> diff --git a/hw/isa/piix=2Ec b/hw/isa/piix=2Ec >> index 98e9b12661=2E=2Ee4587352c9 100644 >> --- a/hw/isa/piix=2Ec >> +++ b/hw/isa/piix=2Ec >> @@ -33,7 +33,6 @@ >> #include "hw/qdev-properties=2Eh" >> #include "hw/ide/piix=2Eh" >> #include "hw/isa/isa=2Eh" >> -#include "hw/xen/xen=2Eh" >> #include "sysemu/runstate=2Eh" >> #include "migration/vmstate=2Eh" >> #include "hw/acpi/acpi_aml_interface=2Eh" >> @@ -465,24 +464,6 @@ static const TypeInfo piix3_info =3D { >> =2Eclass_init =3D piix3_class_init, >> }; >> =20 >> -static void piix3_xen_class_init(ObjectClass *klass, void *data) >> -{ >> - DeviceClass *dc =3D DEVICE_CLASS(klass); >> - PCIDeviceClass *k =3D PCI_DEVICE_CLASS(klass); >> - >> - k->realize =3D piix3_realize; >> - /* 82371SB PIIX3 PCI-to-ISA bridge (Step A1) */ >> - k->device_id =3D PCI_DEVICE_ID_INTEL_82371SB_0; >> - dc->vmsd =3D &vmstate_piix3; >> -} >> - >> -static const TypeInfo piix3_xen_info =3D { >> - =2Ename =3D TYPE_PIIX3_XEN_DEVICE, >> - =2Eparent =3D TYPE_PIIX_PCI_DEVICE, >> - =2Einstance_init =3D piix3_init, >> - =2Eclass_init =3D piix3_xen_class_init, >> -}; >> - >> static void piix4_realize(PCIDevice *dev, Error **errp) >> { >> ERRP_GUARD(); >> @@ -534,7 +515,6 @@ static void piix3_register_types(void) >> { >> type_register_static(&piix_pci_type_info); >> type_register_static(&piix3_info); >> - type_register_static(&piix3_xen_info); >> type_register_static(&piix4_info); >> } >> =20 >> diff --git a/include/hw/southbridge/piix=2Eh b/include/hw/southbridge/p= iix=2Eh >> index 65ad8569da=2E=2Eb1fc94a742 100644 >> --- a/include/hw/southbridge/piix=2Eh >> +++ b/include/hw/southbridge/piix=2Eh >> @@ -77,7 +77,6 @@ struct PIIXState { >> OBJECT_DECLARE_SIMPLE_TYPE(PIIXState, PIIX_PCI_DEVICE) >> =20 >> #define TYPE_PIIX3_DEVICE "PIIX3" >> -#define TYPE_PIIX3_XEN_DEVICE "PIIX3-xen" >> #define TYPE_PIIX4_PCI_DEVICE "piix4-isa" >> =20 >> #endif > > >This fixes the regression with the emulated usb tablet device that I repo= rted in v1 here: > >https://lore=2Ekernel=2Eorg/qemu-devel/aed4f2c1-83f7-163a-fb44-f284376668= dc@aol=2Ecom/ > >I tested this patch again with all the prerequisites and now with v2 ther= e are no regressions=2E Good news! >Tested-by: Chuck Zmudzinski Thanks for the test ride and the Tested-by medal ;) Best regards, Bernhard From xen-devel-bounces@lists.xenproject.org Wed Jan 04 19:47:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 19:47:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471437.731274 (Exim 4.92) (envelope-from ) id 1pD9jA-0002N8-Ou; Wed, 04 Jan 2023 19:47:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471437.731274; Wed, 04 Jan 2023 19:47:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD9jA-0002N1-Ls; Wed, 04 Jan 2023 19:47:08 +0000 Received: by outflank-mailman (input) for mailman id 471437; Wed, 04 Jan 2023 19:47:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD9jA-0002Mt-2O for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 19:47:08 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 91225a90-8c68-11ed-91b6-6bf2151ebd3b; Wed, 04 Jan 2023 20:47:06 +0100 (CET) Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-433-46R5JUs0NmaPYkxYbwUVvA-1; Wed, 04 Jan 2023 14:47:01 -0500 Received: by mail-wm1-f69.google.com with SMTP id bd6-20020a05600c1f0600b003d96f7f2396so19176950wmb.3 for ; Wed, 04 Jan 2023 11:47:01 -0800 (PST) Received: from work-vm (ward-16-b2-v4wan-166627-cust863.vm18.cable.virginm.net. [81.97.203.96]) by smtp.gmail.com with ESMTPSA id p19-20020a1c5453000000b003d2157627a8sm50343697wmi.47.2023.01.04.11.46.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Jan 2023 11:46:59 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 91225a90-8c68-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672861625; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6QXOEovurLwLNIz+FnppUbIJfgyjk9M5XlA8eSDuCrU=; b=SfiSU2cr7jb/KCeBiGBtuRoIwdXqP6eVp26xyDHcyRFwjdbN2RjPCAKGqHFM5llRysVsQv xD1GQ8AIGdB/3Gxg9IHfgB0pqbC5op4XAmHSSmMqDRbDyf/4YZvdkvaFP4VYtJgS5aeS70 TPxpeQL8HeinP1lqtTHQ/htJLHJCNbo= X-MC-Unique: 46R5JUs0NmaPYkxYbwUVvA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6QXOEovurLwLNIz+FnppUbIJfgyjk9M5XlA8eSDuCrU=; b=HjDOM2rEKyh8Kq9oCdDUbSTrM52WmlMjj42wm+UsIX6Tl5v+RmUOeZDQkLwe0Sj8kj eyKw82Dnuvr9agRKD0t7tXnOp+YL9g1OwlHoXqhKRcVmNWs8mwA/6eXZEH/uPBSRRsrV yoUXbxvpz8qEoCSNbbPQ6sNRHyPTAOE49AG1Teg/mqw/gTIfg98Zm2gtTwTcFAgwrpZ4 gVb+L0nFpp/EQMBwYLSq1gGkTGa/2LYajMleF+6fONFKDEVZ9RQQ2cNeCCNJKuMmKgWa /8pi+rYmxgB7ra3Duc2SzfixwFEid1afVICIFOymTz8RPg0YWOf2cKxua8DtJDqye1Uq hQpg== X-Gm-Message-State: AFqh2kpHelz0Su3Hp4JLTxZueDiC8JQ7ubjDPoCJOJBJiuWMbLbtPjFd axdpb4brDto2icqUVDrpAJPbnVJs4eK1cUIgXXw1EI+AMosw3/o+cmsGgxBROwZmJ+41DHLp7bS CgQjqThJTb7pD4T5mW2QIuDEa3Lk= X-Received: by 2002:a05:600c:4191:b0:3d1:fcca:ce24 with SMTP id p17-20020a05600c419100b003d1fccace24mr33592850wmh.32.1672861620110; Wed, 04 Jan 2023 11:47:00 -0800 (PST) X-Google-Smtp-Source: AMrXdXt2IDKCOAndi+PoVcK0qTiAwfAqGYMJPzp7glXtRb4nxvriYq01FutSchTWhSgLZ0xQbbf1Wg== X-Received: by 2002:a05:600c:4191:b0:3d1:fcca:ce24 with SMTP id p17-20020a05600c419100b003d1fccace24mr33592836wmh.32.1672861619972; Wed, 04 Jan 2023 11:46:59 -0800 (PST) Date: Wed, 4 Jan 2023 19:46:56 +0000 From: "Dr. David Alan Gilbert" To: Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, xen-devel@lists.xenproject.org, Laurent Vivier , Markus Armbruster , Daniel Henrique Barboza , virtio-fs@redhat.com, Michael Roth , Alex =?iso-8859-1?Q?Benn=E9e?= , qemu-block@nongnu.org, Peter Maydell , qemu-arm@nongnu.org, Paul Durrant , Anthony Perard , David Gibson , =?iso-8859-1?Q?C=E9dric?= Le Goater , John Snow , Stefan Hajnoczi , Paolo Bonzini , Stefano Stabellini , Gerd Hoffmann , Greg Kurz , Thomas Huth Subject: Re: [PATCH 3/6] tools/virtiofsd: add G_GNUC_PRINTF for logging functions Message-ID: References: <20221219130205.687815-1-berrange@redhat.com> <20221219130205.687815-4-berrange@redhat.com> MIME-Version: 1.0 In-Reply-To: <20221219130205.687815-4-berrange@redhat.com> User-Agent: Mutt/2.2.9 (2022-11-12) X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit * Daniel P. Berrang (berrange@redhat.com) wrote: > Signed-off-by: Daniel P. Berrang Yes, although I'm a little surprised this hasn't thrown up any warnings. Reviewed-by: Dr. David Alan Gilbert > --- > tools/virtiofsd/fuse_log.c | 1 + > tools/virtiofsd/fuse_log.h | 6 ++++-- > tools/virtiofsd/passthrough_ll.c | 1 + > 3 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/tools/virtiofsd/fuse_log.c b/tools/virtiofsd/fuse_log.c > index 745d88cd2a..2de3f48ee7 100644 > --- a/tools/virtiofsd/fuse_log.c > +++ b/tools/virtiofsd/fuse_log.c > @@ -12,6 +12,7 @@ > #include "fuse_log.h" > > > +G_GNUC_PRINTF(2, 0) > static void default_log_func(__attribute__((unused)) enum fuse_log_level level, > const char *fmt, va_list ap) > { > diff --git a/tools/virtiofsd/fuse_log.h b/tools/virtiofsd/fuse_log.h > index 8d7091bd4d..e5c2967ab9 100644 > --- a/tools/virtiofsd/fuse_log.h > +++ b/tools/virtiofsd/fuse_log.h > @@ -45,7 +45,8 @@ enum fuse_log_level { > * @param ap format string arguments > */ > typedef void (*fuse_log_func_t)(enum fuse_log_level level, const char *fmt, > - va_list ap); > + va_list ap) > + G_GNUC_PRINTF(2, 0); > > /** > * Install a custom log handler function. > @@ -68,6 +69,7 @@ void fuse_set_log_func(fuse_log_func_t func); > * @param level severity level (FUSE_LOG_ERR, FUSE_LOG_DEBUG, etc) > * @param fmt sprintf-style format string including newline > */ > -void fuse_log(enum fuse_log_level level, const char *fmt, ...); > +void fuse_log(enum fuse_log_level level, const char *fmt, ...) > + G_GNUC_PRINTF(2, 3); > > #endif /* FUSE_LOG_H_ */ > diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c > index 20f0f41f99..40ea2ed27f 100644 > --- a/tools/virtiofsd/passthrough_ll.c > +++ b/tools/virtiofsd/passthrough_ll.c > @@ -4182,6 +4182,7 @@ static void setup_nofile_rlimit(unsigned long rlimit_nofile) > } > } > > +G_GNUC_PRINTF(2, 0) > static void log_func(enum fuse_log_level level, const char *fmt, va_list ap) > { > g_autofree char *localfmt = NULL; > -- > 2.38.1 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK From xen-devel-bounces@lists.xenproject.org Wed Jan 04 19:55:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 19:55:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471445.731287 (Exim 4.92) (envelope-from ) id 1pD9rX-0003t0-M5; Wed, 04 Jan 2023 19:55:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471445.731287; Wed, 04 Jan 2023 19:55:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD9rX-0003st-Gm; Wed, 04 Jan 2023 19:55:47 +0000 Received: by outflank-mailman (input) for mailman id 471445; Wed, 04 Jan 2023 19:55:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pD9rW-0003sn-Io for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 19:55:46 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c47a1958-8c69-11ed-b8d0-410ff93cb8f0; Wed, 04 Jan 2023 20:55:43 +0100 (CET) Received: from mail-bn8nam11lp2169.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Jan 2023 14:55:39 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DM8PR03MB6248.namprd03.prod.outlook.com (2603:10b6:8:25::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Wed, 4 Jan 2023 19:55:36 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5944.019; Wed, 4 Jan 2023 19:55:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c47a1958-8c69-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1672862144; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=lIjvNeL89m8O0HXMTS1K/V+te9aKFWyhRTArbSYxqPc=; b=DIUpeYdMj7+doehCq40tjzhT7TVSbWDbMBn6AstenfLFseWyO0ydtMfS tFjTxYXsFQXbqPR2zXgUp67+iLTO6cMBvxmyOEEg+hjF4Se+/ih4UoUa5 Q4M7ZsSE+jM7vQ0JKCsJYQDViP9Z6iAVz1BDDGu2z/ErMxgkC3zrGQChC g=; X-IronPort-RemoteIP: 104.47.58.169 X-IronPort-MID: 93674422 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:GOLbX6nRjh4c8tvua5AvMV7o5gxLJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xIfXD+OPf7fYWL3edpxa4WxoU5XvpSGzIRgSgBq/3xhECMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icf3grHmeIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aqaVA8w5ARkPqgS5AOGyxH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 aBJMixSVxesu7OR0I+XcOYwmpp6FuC+aevzulk4pd3YJdAPZMmaBo/stZpf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkVw3iea8WDbWUoXiqcF9t0CUv G/ZuU/+BQkXLoe3wjuZ6HO8wOTImEsXXapDT+PnqqIw2jV/wEQUERhMW1zim8KFoXaMVI9uK hVI4hEx+P1aGEuDC4OVsweDiHyOswMYWtFQO/Yn8wzLwa3Riy6CHXQNRDNFbN0gtec1SCYs2 1vPmMnmbRRwtJWFRHTb8a2bxRuwJCwUIGkqdSICCwwf7LHLsIw1yx7CUNtnOKq0lcHuXyH9x SiQqyozjKlVitQEv5hX5njCijOo45LPHgg841yOWnr/t10oIom4e4av9F7Xq+5aK5qURUWAu 35CnNWC6OcJDteGkynlrPgxIYxFLs2taFX06WOD1bF7n9hx0xZPpbxt3Qw= IronPort-HdrOrdr: A9a23:i8iujql//WsCUc4eSfrv09BEqmPpDfLo3DAbv31ZSRFFG/Fw9/ rCoB17726QtN91YhsdcL+7V5VoLUmzyXcX2/hyAV7BZmnbUQKTRekP0WKL+Vbd8kbFh41gPM lbEpSXCLfLfCJHZcSR2njELz73quP3jJxBho3lvghQpRkBUdAF0+/gYDzranGfQmN9dP0EPa vZ3OVrjRy6d08aa8yqb0N1JNQq97Xw5fTbiQdtPW9f1DWz X-IronPort-AV: E=Sophos;i="5.96,300,1665460800"; d="scan'208";a="93674422" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D3882hFN487MXL074f1/5DVe2l2w78ysE7f2ggzp9H7FCzLxL493h5/O1ZlCUjLkNEn+rD4jN1mBoCY+2y5Hxy0lJp3yIKNoefNH/elF/3sqPmXlobSRU9DDrj8daVMYGdyjVlfRz6UTY8loX9iT5OgRgUk/w346SJQjSAODEq4Clnr37Q/V/fEi9sfDkyCLoXPu7d7Ix9G0CPjkEQgGxBjUcXVgqnIL3SKTE041Z2Uh0thrVGGrdNr0T9zkyocwRKGpR6fZNPST2llU2bdF4waWbUSAmIAcKLN5i/On3YmxnSSg2AOZDpSyt1gLjqOZnC3K6ZeIozrQoCQiIfOFpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lIjvNeL89m8O0HXMTS1K/V+te9aKFWyhRTArbSYxqPc=; b=YQQLS34xMCIdHhd06b5jFci2hOrdzqC5Vk7evrtkazQwLhH/NoJiykSHqObDEahD3h8G5ZiReYAKz5mLm9IVfswse/bPm35RljXJZM2+6TeeOeC5UJ85yJfu7Anc/nDsn9Wz2Kee5IdYtTBTIzW3bIL/E1hJrI4ImJNjTd0JqCyaA4yD38TAieUVR50QUkUn7MCvDKpYzctjEp1/mR/l0JVEUCxOeQR8J+SQxp/sA+scm70Xh9rMBJBIjMyj31Jd7jREeQdB1EH4E4hJlyKFJMDWuuyeKARNn4PgKQCGpx1ySItykXiCFDSWCyCkzDSOgszVc6Wnr1tu9B3SWcATzw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lIjvNeL89m8O0HXMTS1K/V+te9aKFWyhRTArbSYxqPc=; b=kXHrPahcPTFH7QrFyFek+4Ir4OMU70/fLsG1VJgwJnP1Kmio8xb4aFWMps3jQr22OTzjhlA57Wx8Bs7reNQj2Vzzx8nleGTOYJ8GyXmwT3up+yTbyzaex5yDiehRsp/qfSDjdAD+fDtlSrD95pgo+4L1ukLh+/J35jgojR4jKjo= From: Andrew Cooper To: Jan Beulich CC: George Dunlap , Stefano Stabellini , Wei Liu , Julien Grall , Xen-devel Subject: Re: [PATCH 3/4] xen/version: Drop bogus return values for XENVER_platform_parameters Thread-Topic: [PATCH 3/4] xen/version: Drop bogus return values for XENVER_platform_parameters Thread-Index: AQHZH69XYhd2rMGoWE+asSBKOPPG4q6OdxyAgAA2ioA= Date: Wed, 4 Jan 2023 19:55:35 +0000 Message-ID: <7dd00ce3-a95b-2477-128c-de36e75c4a34@citrix.com> References: <20230103200943.5801-1-andrew.cooper3@citrix.com> <20230103200943.5801-4-andrew.cooper3@citrix.com> <540a449d-f76d-eb16-4f98-c4fb3564ce98@suse.com> In-Reply-To: <540a449d-f76d-eb16-4f98-c4fb3564ce98@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|DM8PR03MB6248:EE_ x-ms-office365-filtering-correlation-id: 0b4122ae-3476-4370-6db0-08daee8da551 x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: RYJz0lnHpvjLu9v89Wd3lsCv6HWmkwfkHn9jQoIHyv5kg2vPY2TFLpY/G9qLy4y2KjFaZFFmSF35goDleJLcu597FYese+D+I4TDQyQJdld1ewssqQnDvEcgo0y2VGEGgXYXzQnsS6C4BOw4l89a4E8wD9PNkPjAuJU7Eb1DXTUehUQkaf9AqaONIcg92Irs/O+cP9bJzdObD16P08DKBO30SFuEmdkin1vkZ2zhTfe0Zux/3h8S6RJ9So1NWReqBo3tYje9S2k4nVPsmq3+/N00HhBTxvNY7xVVDtCQv8cRzOKBI5g0NPTMRjdz7Y+HcfZSqM+35kYPt/OUvaQjSey3IGghN/CgfCrMIglFPqKHyqz2d6kTmsAxx+/5AYsvnE9tMGhPhDlgSpyP5Et29LRY/zGkgh3L+SwEqrljCEvIQrNYg+g+vGKpioI1G95ac00BAEno/OXw7rA8BUSE3/4rYs/8H0Od9n0APiuj4uv7iLNPtp0Doqm/pRjjvJr0rgh/wn4qtxfIDncLiwO9JWw7Te3XWF3Cu1mgPSEvsSScVP/wbsmx1pYY0++FTMP0lqf/6R4hcLeZ8N2of+ZMFmSx3XPkybNKTxVXVFwpL3H3d+usQDSc886Q1HsO5tXp0u0GzH7z67Fb+ZkoXKLYqtE32u95XrIMQIJnxyE0RfPV0OCu+Lw2AFWlONe3tQJNgt+F+9LiZ9HpIcYY1NzgHwRXPl/Gdo66K8zrCxuLtnLfRJgTVhMEBrmujnYhemHzCps/cz5zWp8Ovh4u4x6AvQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(136003)(39860400002)(396003)(366004)(451199015)(38100700002)(76116006)(122000001)(82960400001)(38070700005)(31696002)(4326008)(66476007)(66446008)(86362001)(5660300002)(64756008)(8676002)(66946007)(66556008)(2906002)(41300700001)(8936002)(6506007)(186003)(26005)(6512007)(91956017)(53546011)(54906003)(6916009)(316002)(71200400001)(6486002)(478600001)(2616005)(31686004)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ZjJRbVlFREhyZk1YeGx3NGw1cDBsdEFZVXFRUFB4RVhzTERHWnFJMWxrZ0xq?= =?utf-8?B?dVZxNFBoZDRUcUVzOGxBOG8yd2VHTlNLenV5dlpiblhzN25NU2F2MGpMMDV3?= =?utf-8?B?R3hiWVVxRGxEK1lpZDhLRXRnNzg5WTMxUklYc3FBM0VYYjlDNmgrUUtqTmNk?= =?utf-8?B?YkZnVEJnWDk5V09KMGZTM1hORkdiL1JleVB6ckh4dVNiZjBieFFxM0IrcnFi?= =?utf-8?B?bmVVLzh6a1h5REhDMXdIQy9lMWl0V0tMUlc5dzZrUnI5MHVzbzIwZmxZSkkw?= =?utf-8?B?SXVwTDFiSEs2L3JpejhVSUgvTGNmanoxVlN6WFF0S2ZGTXpqQ1dLWDY4ZjF5?= =?utf-8?B?NFFmQ2RjREIvRUh6d0NpYzlvZzA0OHNMUlRTRmdQY0tVcmRYK2gxcEJpMmUw?= =?utf-8?B?VHAreFdnTU9aaXBnWWJpRWdPS1F5dUgrSGFFVzQxaVV4RlZveUsyT2g2eWN4?= =?utf-8?B?Q1F2ZExheTFJeFdselFtVHkzVi9nZFIvSm1YUzVEQzhzSUZpNnBFNFZEODdL?= =?utf-8?B?MFAzYm1SRVhYd1lFNG0ybzJqUEVvTEUrTmFIQ3JtTU91elgzNGxWNTI5VFpN?= =?utf-8?B?anRlTUNFT0NaSnhYVFo5TEZkcllzV3hSdmtRNDZ4SThDMDMwVTFVMjgvcmk3?= =?utf-8?B?RDV6RDdjTjFsRlE2cklJNFFIbjFsZ25ES1hQY2d2Y0xiOHNuUTBiWGtmK3Y3?= =?utf-8?B?cnA2cDNwK2E0S2FySTFyeTdnb3NOQjNWakpOVVZSUDdmcG9WaWd3aEVKZHdx?= =?utf-8?B?U0NwZWNTd2luMmlmS2R4WXRnUk13QW02Y1k1dVoxaVltVWZIdFphQ1VkUWg4?= =?utf-8?B?YnpSb1Fhc3ZVN1UrSU9sTmVrektnTU5VbFF1dzRQVStZb2ZZOHdDaXZtM0Mw?= =?utf-8?B?d0JmdVQ4ZStySXhYSklhSXlMVWh5Q05YT2pLZ0xWa0FUQS9xbGFhMHQvMU5r?= =?utf-8?B?Ykp1bGVYaEZUU0FqSTNEcWUwR2twWFVYamtlYWwveDM5YnluSHZiUkUvdmQ2?= =?utf-8?B?SWhyUEJ1L1RITDgzQW5kKzVZSE80enpTblZUb21PMlVGNjZQZFNoaDRtVDY2?= =?utf-8?B?ZnFPMjBUd1JLQXhKamlmMnAwV1I3M3NCSzhPblZJNEdKWHZJajZwOHNWdG1B?= =?utf-8?B?VkMxNzdUZE93OWVTZUpxU1VPajJDcXJlQStaT3lEcjE5OGtmZmp3VXFkS3Y3?= =?utf-8?B?MG5OQ0p5dHFWeEVEWEQ4dVhVT3ltWkE4bHpiOW1xMzBEQnllRFZNY3JxMUNm?= =?utf-8?B?THRsY1ZpK2NxVWpRQkhjdmtuWEVJc3BzRlJGZTcxMVNwbHVsajB6VjBVVG40?= =?utf-8?B?WkFETzVqeFBiNHBWVnpBd00xTWpQdjhlS0o3VGNudnhQUWtnU0xmV1ltTWVv?= =?utf-8?B?WHpSWHBnaTArUHpSWGRJRWNpdTcwbEtYcWpQd2hlZENoWnpOaWZLbUNab1c3?= =?utf-8?B?NHJNUktzbUFXbFNFWTlwR3dRVEkwMEh5L2ZFQVRhTUVuSjdoUFpwVzh0SEx1?= =?utf-8?B?dCtMakY2djZFbC9SWGFack9iOEE3V2ZuQnN5MWE0cXVuTjNDc1NOZ2Y1a3pN?= =?utf-8?B?Z2VveVdQeXc3OS84Z2I3bmdXZitJMEwxVnByZU1nYjRPQ1JJcTRBMlo5VFMy?= =?utf-8?B?bTFhdEszQ1ZwSEtSYm4rVnd2Mjd4QmJJNVVkclJUYkR1RDNmbzd3VktSSXF3?= =?utf-8?B?Y01XYnIyOE9lWG1qcGV1SUZxMy9FSFRMMWx1YndaelRYMlN0Q2RNRFA2TVlV?= =?utf-8?B?VEtkaG9TMG90OHBWS3kyVStFN3FnSVI5YlhsSVBvL2l1ZVBTd29wVFVWRTl0?= =?utf-8?B?TXBrZHVXUWhSWnZ4LzNIN1FNOWU3MnZ2cWJibHN2UlRlQmVvdktrbnB4ZWdZ?= =?utf-8?B?d1pqRE10bk1rZVFYMUZONGdQdzV6YWwxUTJzM0VZU3RFUjAyQjZIOFIxYkd4?= =?utf-8?B?cHlGaVFFbmtnbmdPZTV6WW1QSnhCczFRemQ0UWduOHUvY3k1a2lBNmZoOTR3?= =?utf-8?B?ZnRWQ2pIYURXQTA0UnR4dmQ2Z1llUUI5WURDbW1mRkVtRzlITVBQOXZ5TmM4?= =?utf-8?B?Q0VpSFVHV1JTNTFrOVh3cWI3T2x3ajZPR1Y4TWxKUnAveTl4UGdrZzJCZ1Ji?= =?utf-8?B?bUtIeFRsOWdoWE9ocG9WQmY1STNyQjVsUVlRUFllbENnY01WUHpEa3ovZlJP?= =?utf-8?B?c2c9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <8BAAB875855C2141A830C3988AC2C40F@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: ZjJvlAYseAMKGUmYvaMMSlzSNgVzDIw1i22HIiyKJ+jFUf7eCNn+z00fG88fuIo6fe3guzcxqo455YXA4glE4U7sGGzzykX2s+RzorFE47dhtfWTiYmOplQ6nsXxi63nDPtD71gl6Z3IcGDFbFsgw24vNIZpvogTaJs6c1MxwalWNDOWQaYxnaygJhi6HAvVDva4IIA5Hj1q4gqVCCKnEAuMSYE0STT9cqAxem/I/+8YTsSczQeqYf/0G6m4r8iSZpZ1lpRDPru8hxaCn1Q04OfAFIctLhYq7n1ePJTxQovaNhGX4GAXaliCmu5GAK88WlCp2W//Jre1Ux5wcmzLpwBKpixmYFLKdQSqGKHy8VMeJSWONzTvqBcHCPu3ZBgUbpcCCaCMPa/tcwADtKT/RecU/44M5l6xuJ7UKu4Hbfe0LGJaK3/oeGYVQRdgYA7fORlR9w6QGhqqqTK5kv31uI9b+6f9XBnQnB/oG5SaHzoeGckBXvM5nSVyyIrGUK9bOtNOKA+RW+hbQ8lx6hTbQj53Uf53r5Fywj02MWLDg48uFuFTuG2Tn+u5YAdvWSQLwpK56B9T5DB8OCRGZZvkYakNi22q77aDyodP3FNPyQdWk/pKG9rfMa70ofTvnzLsOfzEA7zzavaIl6CnFIX/ScDmTHgFIzJUwp2I0lpAiBfGZvLxVaQOP/6NNqeFWtWfEo3ylqkRx646xl1U5z1BjIu9JQU6GkgksG16yVCgulpzVJGxQeaCuzD5Bn29mTRS+DPicAPsS4lblF4KxmaMakKR8U0ZK/TjRMIXe6M5WPs8r4cAAbse9Vk9ZzKcoXdA9aEuv/YQTNRCz/dRZzBFJrXv8I8ZCFenYDgHuAhlC5Jh+tfjcWHGsYOfk7MTR8CW X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0b4122ae-3476-4370-6db0-08daee8da551 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jan 2023 19:55:35.7254 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wapB1tHHZ8CaBknxBW9DJ0z5a7IxbdwnbxiKIdWapf0og0OgCtict17gmGm/6C4ucLAL4cJmWrE7MkgzEyAhWrjwaXdj4d8NqamFyT3JSt0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR03MB6248 T24gMDQvMDEvMjAyMyA0OjQwIHBtLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMDMuMDEuMjAy MyAyMTowOSwgQW5kcmV3IENvb3BlciB3cm90ZToNCj4+IEEgc3BsaXQgaW4gdmlydHVhbCBhZGRy ZXNzIHNwYWNlIGlzIG9ubHkgYXBwbGljYWJsZSBmb3IgeDg2IFBWIGd1ZXN0cy4NCj4+IEZ1cnRo ZXJtb3JlLCB0aGUgaW5mb3JtYXRpb24gcmV0dXJuZWQgZm9yIHg4NiA2NGJpdCBQViBndWVzdHMg aXMgd3JvbmcuDQo+Pg0KPj4gRXhwbGFpbiB0aGUgcHJvYmxlbSBpbiB2ZXJzaW9uLmgsIHN0YXRp bmcgdGhlIG90aGVyIGluZm9ybWF0aW9uIHRoYXQgUFYgZ3Vlc3RzDQo+PiBuZWVkIHRvIGtub3cu DQo+Pg0KPj4gRm9yIDY0Yml0IFBWIGd1ZXN0cywgYW5kIGFsbCBub24teDg2LVBWIGd1ZXN0cywg cmV0dXJuIDAsIHdoaWNoIGlzIHN0cmljdGx5DQo+PiBsZXNzIHdyb25nIHRoYW4gdGhlIHZhbHVl cyBjdXJyZW50bHkgcmV0dXJuZWQuDQo+IEkgZGlzYWdyZWUgZm9yIHRoZSA2NC1iaXQgcGFydCBv ZiB0aGlzLiBTZWVpbmcgTGludXgnZXMgZXhwb3N1cmUgb2YgdGhlDQo+IHZhbHVlIGluIHN5c2Zz IEkgZXZlbiB3b25kZXIgd2hldGhlciB3ZSBjYW4gY2hhbmdlIHRoaXMgbGlrZSB5b3UgZG8gZm9y DQo+IEhWTS4gV2hvIGtub3dzIHdoYXQgaXMgYmVpbmcgaW5mZXJyZWQgZnJvbSB0aGUgdmFsdWUs IGFuZCBieSB3aG9tLg0KDQpMaW51eCdzIHN5c2ZzIEFCSSBpc24ndCByZWxldmFudCB0byB1cyBo ZXJlLsKgIFRoZSBzeXNmcyBBQkkgc2F5cyBpdA0KcmVwb3J0cyB3aGF0IHRoZSBoeXBlcnZpc29y IHByZXNlbnRzLCBub3QgdGhhdCBpdCB3aWxsIGJlIGEgbm9uemVybyBudW1iZXIuDQoNCj4+IC0t LSBhL3hlbi9pbmNsdWRlL3B1YmxpYy92ZXJzaW9uLmgNCj4+ICsrKyBiL3hlbi9pbmNsdWRlL3B1 YmxpYy92ZXJzaW9uLmgNCj4+IEBAIC00Miw2ICs0MiwyNiBAQCB0eXBlZGVmIGNoYXIgeGVuX2Nh cGFiaWxpdGllc19pbmZvX3RbMTAyNF07DQo+PiAgdHlwZWRlZiBjaGFyIHhlbl9jaGFuZ2VzZXRf aW5mb190WzY0XTsNCj4+ICAjZGVmaW5lIFhFTl9DSEFOR0VTRVRfSU5GT19MRU4gKHNpemVvZih4 ZW5fY2hhbmdlc2V0X2luZm9fdCkpDQo+PiAgDQo+PiArLyoNCj4+ICsgKiBUaGlzIEFQSSBpcyBw cm9ibGVtYXRpYy4NCj4+ICsgKg0KPj4gKyAqIEl0IGlzIG9ubHkgYXBwbGljYWJsZSB0byBndWVz dHMgd2hpY2ggc2hhcmUgcGFnZXRhYmxlcyB3aXRoIFhlbiAoeDg2IFBWDQo+PiArICogZ3Vlc3Rz KSwgYW5kIGlzIHN1cHBvc2VkIHRvIGlkZW50aWZ5IHRoZSB2aXJ0dWFsIGFkZHJlc3Mgc3BsaXQg YmV0d2Vlbg0KPj4gKyAqIGd1ZXN0IGtlcm5lbCBhbmQgWGVuLg0KPj4gKyAqDQo+PiArICogRm9y IDMyYml0IFBWIGd1ZXN0cywgaXQgbW9zdGx5IGRvZXMgdGhpcywgYnV0IHRoZSBjYWxsZXIgbmVl ZHMgdG8ga25vdyB0aGF0DQo+PiArICogWGVuIGxpdmVzIGJldHdlZW4gdGhlIHNwbGl0IGFuZCA0 Ry4NCj4+ICsgKg0KPj4gKyAqIEZvciA2NGJpdCBQViBndWVzdHMsIFhlbiBsaXZlcyBhdCB0aGUg Ym90dG9tIG9mIHRoZSB1cHBlciBjYW5vbmljYWwgcmFuZ2UuDQo+PiArICogVGhpcyBwcmV2aW91 c2x5IHJldHVybmVkIHRoZSBzdGFydCBvZiB0aGUgdXBwZXIgY2Fub25pY2FsIHJhbmdlICh3aGlj aCBpcw0KPj4gKyAqIHRoZSB1c2Vyc3BhY2UvWGVuIHNwbGl0KSwgbm90IHRoZSBYZW4va2VybmVs IHNwbGl0ICh3aGljaCBpcyA4VEIgZnVydGhlcg0KPj4gKyAqIG9uKS4gIFRoaXMgbm93IHJldHVy bnMgMCBiZWNhdXNlIHRoZSBvbGQgbnVtYmVyIHdhc24ndCBjb3JyZWN0LCBhbmQNCj4+ICsgKiBj aGFuZ2luZyBpdCB0byBhbnl0aGluZyBlbHNlIHdvdWxkIGJlIGV2ZW4gd29yc2UuDQo+IFdoZXRo ZXIgdGhlIGd1ZXN0IHJ1bnMgdXNlciBtb2RlIGNvZGUgaW4gdGhlIGxvdyBvciBoaWdoIGhhbGYg KG9yIGluIHlldA0KPiBhbm90aGVyIHdheSBvZiBzcGxpdHRpbmcpIGlzbid0IHJlYWxseSBkaWN0 YXRlZCBieSB0aGUgUFYgQUJJLCBpcyBpdD8NCg0KTm8sIGJ1dCBnaXZlbiBhIGNob2ljZSBvZiBy ZXBvcnRpbmcgdGhlIHRoaW5nIHdoaWNoIGlzIGFuIGFyY2hpdGVjdHVyYWwNCmJvdW5kYXJ5LCBv ciB0aGUgb25lIHdoaWNoIGlzIHRoZSBhY3R1YWwgc3BsaXQgYmV0d2VlbiB0aGUgdHdvIGFkamFj ZW50DQpyYW5nZXMsIHJlcG9ydGluZyB0aGUgYXJjaGl0ZWN0dXJhbCBib3VuZGFyeSBpcyBjbGVh cmx5IHRoZSB1bmhlbHBmdWwgdGhpbmcuDQoNCj4gIFNvDQo+IHdoZXRoZXIgdGhlIHZhbHVlIGlz ICJ3cm9uZyIgaXMgZW50aXJlbHkgdW5jbGVhci4gSW5zdGVhZCAuLi4NCj4NCj4+ICsgKiBGb3Ig YWxsIGd1ZXN0IHR5cGVzIHVzaW5nIGhhcmR3YXJlIHZpcnQgZXh0ZW50aW9ucywgWGVuIGlzIG5v dCBtYXBwZWQgaW50bw0KPj4gKyAqIHRoZSBndWVzdCBrZXJuZWwgdmlydHVhbCBhZGRyZXNzIHNw YWNlLiAgVGhpcyBub3cgcmV0dXJuIDAsIHdoZXJlIGl0DQo+PiArICogcHJldmlvdXNseSByZXR1 cm5lZCB1bnJlbGF0ZWQgZGF0YS4NCj4+ICsgKi8NCj4+ICAjZGVmaW5lIFhFTlZFUl9wbGF0Zm9y bV9wYXJhbWV0ZXJzIDUNCj4+ICBzdHJ1Y3QgeGVuX3BsYXRmb3JtX3BhcmFtZXRlcnMgew0KPj4g ICAgICB4ZW5fdWxvbmdfdCB2aXJ0X3N0YXJ0Ow0KPiAuLi4gdGhlIGZpZWxkIG5hbWUgdGVsbHMg bWUgdGhhdCBhbGwgdGhhdCBpcyBiZWluZyBjb252ZXllZCBpcyB0aGUgdmlydHVhbA0KPiBhZGRy ZXNzIG9mIHdoZXJlIHRoZSBoeXBlcnZpc29yIGFyZWEgc3RhcnRzLg0KDQpJTU8sIGl0IGRvZXNu J3QgbWF0dGVyIHdoYXQgdGhlIG5hbWUgb2YgdGhlIGZpZWxkIGlzLsKgIEl0IGRhdGVzIGZyb20g dGhlDQpkYXlzIHdoZW4gMzJiaXQgUFYgd2FzIHRoZSBvbmx5IHR5cGUgb2YgZ3Vlc3QuDQoNCjMy Yml0IFBWIGd1ZXN0cyByZWFsbHkgZG8gaGF2ZSBhIHZhcmlhYmxlIHNwbGl0LCBzbyB0aGUgZ3Vl c3Qga2VybmVsDQpyZWFsbHkgZG9lcyBuZWVkIHRvIGdldCB0aGlzIHZhbHVlIGZyb20gWGVuLg0K DQpUaGUgc3BsaXQgZm9yIDY0Yml0IFBWIGd1ZXN0cyBpcyBjb21waWxlLXRpbWUgY29uc3RhbnQs IGhlbmNlIHdoeSA2NGJpdA0KUFYga2VybmVscyBkb24ndCBjYXJlLg0KDQpGb3IgY29tcGF0IEhW TSwgaXQgaGFwcGVucyB0byBwaWNrIHVwIHRoZSAtMSBmcm9tOg0KDQojaWZkZWYgQ09ORklHX1BW MzINCsKgwqDCoCBIWVBFUlZJU09SX0NPTVBBVF9WSVJUX1NUQVJUKGQpID0NCsKgwqDCoMKgwqDC oMKgIGlzX3B2X2RvbWFpbihkKSA/IF9fSFlQRVJWSVNPUl9DT01QQVRfVklSVF9TVEFSVCA6IH4w dTsNCiNlbmRpZg0KDQppbiBhcmNoX2RvbWFpbl9jcmVhdGUoKSwgd2hlcmVhcyBmb3Igbm9uLWNv bXBhdCBIVk0sIGl0IGdldHMgYSBudW1iZXIgaW4NCmFuIGFkZHJlc3Mgc3BhY2UgaXQgaGFzIG5v IGNvbm5lY3Rpb24gdG8gaW4gdGhlIHNsaWdodGVzdC7CoCBBUk0gZ3Vlc3RzDQplbmQgdXAgZ2V0 dGluZyBYRU5fVklSVF9TVEFSVCAoPT0gMk0pIGhhbmRlZCBiYWNrLCBidXQgdGhpcyBhYnNvbHV0 ZWx5DQphbiBpbnRlcm5hbCBkZXRhaWwgdGhhdCBndWVzdHMgaGF2ZSBubyBidXNpbmVzcyBrbm93 aW5nLg0KDQoNClRoZSBvbmx5IHJlYXNvbiBJJ20gbm90IGlzc3VpbmcgYW4gWFNBIGZvciB0aGlz IGlzIGJlY2F1c2Ugd2UgZG9uJ3QgaGF2ZQ0KYW55IHByZXRlbmNlIG9mIEtBU0xSIGluIFhlbi7C oCBQcmV0dHkgbXVjaCBldmVyeSBvdGhlciBrZXJuZWwgZ2V0cyBDVkVzDQpmb3IgaW5mb2xlYWtz IGxpa2UgdGhpcy4NCg0KV2UgZmVhc2libHkgY291bGQgZG8gS0FTTFIgaW4gIVBWIGJ1aWxkcywg YXQgd2hpY2ggcG9pbnQgdGhpcyB3b3VsZA0KcXVhbGlmeSBmb3IgYW4gWFNBLg0KDQp+QW5kcmV3 DQo= From xen-devel-bounces@lists.xenproject.org Wed Jan 04 20:04:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 20:04:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471454.731297 (Exim 4.92) (envelope-from ) id 1pDA0G-0005W5-Ja; Wed, 04 Jan 2023 20:04:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471454.731297; Wed, 04 Jan 2023 20:04:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDA0G-0005Vy-Gi; Wed, 04 Jan 2023 20:04:48 +0000 Received: by outflank-mailman (input) for mailman id 471454; Wed, 04 Jan 2023 20:04:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDA0E-0005Vs-V6 for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 20:04:47 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 071b0d19-8c6b-11ed-91b6-6bf2151ebd3b; Wed, 04 Jan 2023 21:04:44 +0100 (CET) Received: from mail-dm6nam11lp2170.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.170]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Jan 2023 15:04:33 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by MN2PR03MB5312.namprd03.prod.outlook.com (2603:10b6:208:1e9::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Wed, 4 Jan 2023 20:04:31 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5944.019; Wed, 4 Jan 2023 20:04:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 071b0d19-8c6b-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1672862684; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=Q8lqIglA3cLE3gjKfVs53dWzklNgm/Z2M2j8Ey4rR3I=; b=CQI0kznF8bTSA5UgKzdn3RCyLc0gsvBfg3PaceTUZV1Ym23gmzdJD16K TQkagn4BemF6NlFexc/BfKb0kzXDmb3bc6t/hc7iTEZXUr2utlLRbTJVl cuYjVmkzpG7cxyPaAAxAdQr9E5tQ+8o5Oufolj06dbb5dMQG1q2v3+af5 o=; X-IronPort-RemoteIP: 104.47.57.170 X-IronPort-MID: 90151052 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:5/XurqrtoCwaTiObZQ520C9RH0deBmI6ZBIvgKrLsJaIsI4StFCzt garIBnXaa7eajP3c9pzYI22/E0DvZTUnYU2SVc4+Ck1QisQ8ZuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpAFc+E0/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06W1wUmAWP6gR5weHzyVNUPrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXABQURQ+ju+a1/LW6G8lVvskOEunZE4xK7xmMzRmBZRonabbqZvyToPN9gnI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jeeraYWNEjCJbZw9ckKwj 2TK5WnmRDodM8SS02Gt+XOwnO7f2yj8Xer+EZXprqc32QXOnAT/DjVRVVKqgeGGknW3WvZmK 3IR8ycJlogLoRnDot7VGkfQTGS/lhwWVsdUEuY6wBqQ0aeS6AGcbkAbShZRZdpgs9U5LRQ62 1nMk973CDhHtLyOVWnb5rqStSm1OyUeMSkFfyBscOcey9zqoYV2gheRSN9mSfexloesRmm2x C2Wpi8jgblVldQMy6iw4VHAhXSru4TNSQk2oA7QWwpJ8z9EWWJsXKTwgXCz0BqKBN/xooWp1 JTcp/Wj0Q== IronPort-HdrOrdr: A9a23:OCvYYqo++QmBgGtBG2IkRPcaV5scL9V00zEX/kB9WHVpm5Oj+v xGzc5w6farsl0ssRYb6Kq90ci7MAjhHPtOjbX5Uo3SOTUO1FHYSL2Kj7GSpQEIaheOjtK1vJ 0IG8cReb6Ab2SWlfyb3ODRKade/DDtytHQuQ6x9QYLcehCUdAd0+5MMHfkLqQ6fngxObMJUL 6nouZXrTupfnoaKuy9G3k+RuDG4+bGkZr3CCR2ciLOvGO17A+A2frfKVy1zx0eWzRAzfMJ6m 7eiTH04a2lrrWS1gLc/3W71eUYpPLRjv94QOCcgMkcLTvhziyyYp56ZrGEtDcp5Mmy9VcRls XWqRtIBbU+15roRBD6nfLR4Xir7N9u0Q6o9baguwqqnSUtfkN2NyJD7bgpACcxpXBQ/e2U65 g7rF6xht5yN1fngDn54d7LEyFjkk65ulYyjOIVlXxVVIc1brhNoYsD0UtJGP47bV/HAbAcYZ hT5f7nlYZrmHOhHgTkVzpUsauRtzIIb167fnQ= X-IronPort-AV: E=Sophos;i="5.96,300,1665460800"; d="scan'208";a="90151052" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BUduF74z8gtOEPoxpvdB+b9Zk3G3cOqbVwGagme4YFA4hlu4+7GOtXe/j5QswTA8JERYkLOiVKHSfXwHZoM8VQp8KEYO7iRPtl4mPRpy5SnliedMKbZP8uoJ8t5x02QREPdNLLRKV7wUj4TpMxQrUR779fWU8hrU3oc9OltZLE5ZkNPA/iGHMMr5vUCT2y9R2WYIHzNIBKKEyOqkSoPTOoUHm5VmZFDN5L4xYNr91Av1a5ffAzNH71eDztK7CRZpsbvAcRGYNdA5AVmR55QBdpqNTGmGJVaZxsfK7/69ffLqqIOLDFDn00f1t75wSzeo38XWoQtzJxd9HMpZOoC+RA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Q8lqIglA3cLE3gjKfVs53dWzklNgm/Z2M2j8Ey4rR3I=; b=P3EdI7bC16DC/fWxWhGKHMsY4AOzgiBqg0+dSfVT2fGrkQdDIdxgf/6N4WeNzT+IL0E7y9qG7RLUMzl36X3fAmqvn708OuPnUsi5s3jJyaZe4sji66IiSZ+BoRZyoUHxd6wNcetLCvEIVKkXtiBt3as9vPrQ+TlmQxo1pR0ZpwcKzLs2G5ZD8FtogAIq3GqaXNWt8ARcaPtMtZcUcJLO+nHcNuMpcrII3dzTQ+bEASxx3Zs92kF8mWKal1G8X94YA40UeZVWk3DDsr3qnGK9BNjyk/8ckZiNJY51eFdu/vNrSaNdbFCfgbwH1pbdvD4zOUSFTWjuWB28RUEnKgC5xQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q8lqIglA3cLE3gjKfVs53dWzklNgm/Z2M2j8Ey4rR3I=; b=iXTrHbSs2g7yG1zFjyQvxUAc0jUf5bQ8v+jjXYbN73+cq+QY27epcVY+5qv5XPaeWiLgtWMK5FqemQCxckojXD/cHK/2GYZA0sbvrrwlNwh07zvYBS4WAzchTwt6Pyfxawfrj7XzByN31FalGPZssGmVpp4blvT0GTgS0ykU784= From: Andrew Cooper To: Jan Beulich CC: Roger Pau Monne , Wei Liu , Xen-devel Subject: Re: [PATCH v2-ish] x86/boot: Factor move_xen() out of __start_xen() Thread-Topic: [PATCH v2-ish] x86/boot: Factor move_xen() out of __start_xen() Thread-Index: AQHZEYuAyVgzwEEad0Cj70OyJmEML6520VMAgAB2soCAALPugIAW0HgA Date: Wed, 4 Jan 2023 20:04:30 +0000 Message-ID: <5f3df359-2906-ba20-b8df-ae2f2d5f5981@citrix.com> References: <20211207105339.28440-1-andrew.cooper3@citrix.com> <20221216201749.32164-1-andrew.cooper3@citrix.com> <520cdde9-07e1-fce8-56d9-205fc31c62e3@suse.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|MN2PR03MB5312:EE_ x-ms-office365-filtering-correlation-id: 27caa092-f2ac-4007-b33c-08daee8ee43e x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: aAXGvrFz3uHCl8YNj5zjio432c/8YP8/+2LRHHynR4ZT45lTKrqyLBV6f4ngXJ+/D3xbKmJeoPuTF3tLHFSpdHiCpBacHZH9XmzeNxhHlDeY+ZgcATu76MHhXlTHFPUxaeDFxaPTeRA02SexT/kTCgd3RyDYvgf4FXzhUem141SmnQeIZAIcm4kgRVpcPrVf2DxCZefg7OGLCi6Ks98rWaK9Rm9VqJG5TJo5uf4j+18whn6eVBHf5SbahJr3rgWEU7AsjckR8rhrqJnIWUnL5uci48STYpGaUAWkgNta1o+zMzhiuM5YNQpG+64OvZYqrTOjyW5O073+HdM+8Nz7s0JoqTjGQ4bBWhjJY1s3TOB/xCOFuy7yozStkDNy/cMRnVyR3VhyoFwdSoXB5EhzVUiKNZNcCHC1b66L1MbJQjVZLns3c9Qoju07Dl4Je23c9Yh8/AKF1oGMXxsYGhsXy1Ga56TW2BmhfNi8iOH45MeDmutTkMc1rbA/nnokoUPOfgewFHGuDTNwdjdCglxC+IDPJQ8McAzqaHXkdOfGqrm0OA56oyi8F1QjeZD6Zm9A4E0x3L8cz1EJ2NRffD1aGNnI0eD92rZTWBmR4nU6+xyE2S6SM3pTtGOLaqejsrGYFvNja5VkB/X8tY/3BnDxpSDky9cjHPiy7PwGMhm/fXUtZsEqSXCZSAEl1DJSDFl8g6XaTuov9VZOLtGxlZyTjDJ0we5Y+crSW1AroPaHqGRfOiHHi3oSh5U9aU/GVWmguy9HqdFh2etY03QZvAyXTbrQMoK2BY5lFWcAsYi+0Cs= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(376002)(39860400002)(366004)(396003)(451199015)(36756003)(122000001)(38100700002)(5660300002)(8936002)(41300700001)(83380400001)(86362001)(31696002)(38070700005)(2906002)(82960400001)(966005)(66946007)(71200400001)(66556008)(76116006)(6486002)(54906003)(6916009)(31686004)(6506007)(91956017)(66476007)(4326008)(2616005)(8676002)(6512007)(66446008)(316002)(64756008)(26005)(186003)(53546011)(478600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?RjVyUGxRaTYxYTdaTWt6TDZpcU00WVdBNmJvckFNN2JkbDB4MkVhQ2p3Sk5E?= =?utf-8?B?S0J4TTBCbThTMHpjMDkrdkp2UGgzWXVPVXNjZHBmeHpHMVh6V1VKR1RmUDI5?= =?utf-8?B?dXdqbVNZdUZZdTg3U3BrbjFBaG4xOFl6Ump0WUJRYllWMTJJN0RCTTRLQ3Zn?= =?utf-8?B?cWE5dXo2dGpENVRzWm5NYjF4d01WRjZGeFEvTy9jdE1FWHdpMkExaTRlUFN1?= =?utf-8?B?NVBIMytjZThTTXBDeCtYUk5WZVVXMjlvcVAzQ1l5UDlpNjY5V05iQTdQWWJq?= =?utf-8?B?TDVZdUNTenQ2eHFzNWQ0ajY5YU1OMEg2ZnNsVXVEOStSOU9TYnRIWkgxSkd2?= =?utf-8?B?VkxZNVVWZzVzV3JoVTlOU3NjTkl2NFQxN05DWG1LU1hkaW5BZEJvZXFLZmJB?= =?utf-8?B?MmtEOS9qV2NBTllCMFUwN3NneTJPZFNONW9GZmxxOFpYZTFJT05iV1ZiQ3Fv?= =?utf-8?B?dFhicm55QzdCYUhTNUVEbXBrR2hYT2RzODZGZUIwalJIZHp0UENKMlpjOXRQ?= =?utf-8?B?SDRSN1dsN245dCtpVlVxMTZ1cVRBUU1TVmxQRGN1Uk5CMDkvSUdPQVlhQzZY?= =?utf-8?B?MEtSTTFSNUJSSXZZQ3FGckFZVHBqWE1Zdk02dmlkWVNmRllLMlBLdDlEazVZ?= =?utf-8?B?S2JLUmVScEFnNWtTQzBrOC81aGMxQmU0WWhhdkxJdGZHbjltN0xBWXVjN3A3?= =?utf-8?B?MGcxaktJV0d0RXlJaUU3UzhKeEpHck1pWnRkdXJzdUhKYmkzU3FxZitNQ1JB?= =?utf-8?B?UzFRYzNBdVlGeFVNUGpWcXM5KzFZTmYrR3FLU0dOWDRGYXlrY0VwR2toU081?= =?utf-8?B?a1B4QVhRTjZXRmdjckxpbkxXRHFhNnkxRGlkby9DRVJGVVl1S2NZTHlDRVZG?= =?utf-8?B?S0lvb1JMMGFxd3lDS2xUSmNUMzEzR1BEb0pEL2lNRmZBeWR6Q3hXQ0VFdEE4?= =?utf-8?B?Ymg5OCtuLzRGZHNIT0RBaFRkS1g1ZGNBd0pBdDRxTDJEMHEvd29YaTVBVHJI?= =?utf-8?B?SmF6aGFoSkVvam1pZlZsVmVjVDVhbnpMQjRiMnVZR0N6QmFKVUVqUmxnYklB?= =?utf-8?B?MGdjK1IzWlNaN3ZzbENSTzFOZ1F1L2lCRk5XSVRpYkg2THpNN0RtdDk0T3hq?= =?utf-8?B?MXRCUDRsNUZtS1cxclZSQXc3VlZvc0JGekxPOVhaMkZaZUxLR1R2Sk04a2F3?= =?utf-8?B?NXRwcXhLMEhWcVp0bWdFM3JSdXhvaFJldHpKVGNhM0l0U2t4eGJMQWFJN0ov?= =?utf-8?B?MG1FNnloNzdPYzc2d0FySTBSMGw4SE5WcUEydWZhY0VDYmNlY1ZoRkZlMnlq?= =?utf-8?B?WFBraUJRekpPUUx2aDlNTlFaUDg0bjJKQWsyZmt0YXJzcmVGSCtzMi9UZVBn?= =?utf-8?B?aHJDYWV2V2tDU0YwM2IvWXdtRDJCY0tMNVZYYW94T3cvWWpuUXBOVzZVcGph?= =?utf-8?B?dUdSTG5GekJ1L2t1VlhlbTFPYnlTdUE4TVNNR3VZTTNJV0Q3S2hGYjZjUXZE?= =?utf-8?B?ZklOT21uUHpKMUJySGp5bUpyRUxCWHFMZUR2ZnZ5K2FjY2Zqam9EMklzM2xa?= =?utf-8?B?bG10MVBmRXUzZHB5SHVKWnNUaGxCWWpra09tSzV1WlMrc3ZnTXJIQ29QRWs5?= =?utf-8?B?K1RtOC83ckZSUzE3ZWZJekJzOTBMYmFrWjFEem5sWGtKb2tGVzNLWWt3MFFE?= =?utf-8?B?SDF1NktjWm1FZFZuT3ZTeE53SWNlU1Vyelhld1k4Y3llQlkvZDJ5TThWdGdX?= =?utf-8?B?ZldNSC9URTZDUjliOGJrVFgvdUt2MStURGlwbDBGS2xaVENENXBSTUw1WUhR?= =?utf-8?B?eHpXb2ZwYlJJL0VXZlo5UzV3ZXBvODVqYjJCcWtQQVQwZ0pYMk40ZHJoOUM5?= =?utf-8?B?WTBVcTduTkducTJFVTF1RXY5SkcwV2FvNzhsZlh6QUR2d3R4UnZpc3hhNzdG?= =?utf-8?B?eEZGMFRFbFREakJMQlNQbjVoeFZWRWNQcXVCR3lmeU5YK0NTM21RQ013QlBi?= =?utf-8?B?L0xqZS94bWNoaU0wRUxGMFVpOFM4QWVWTEdlV0RuSWpick1TckhWd1ZZK3Bv?= =?utf-8?B?N25NNlZTejFycG8wQmJoRy9WNUxGUkdaNFVUYkE1TUhSdzdFd1lHL29iMDJG?= =?utf-8?B?cXVTTjZrQU1FZEhWeTA0cnJqcndzdGFlb096SnJ5UUk1cWR3VEtDbm9SQWFI?= =?utf-8?B?WFE9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <3C3073882006F0489B71C3F9AD10B543@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 3GVJQUPme3502kB408snSO+lbyxtufW/d+3Hcjg94RMiNn8XFe8nmvWSqJX4oCmv1WYL7BRwF5Xkt7voQxGuHDlZs4MIukMWk7kgM3FWlA4N50FtEktsi+R7XD7Le/xSAfQU8i4a0qc0GDpVc/nnX198KT2aCPWtjHMdhgduGyTPDV8HcKe73BXP4OBbMHNpbjDR5gbqWeY0X6Ae/DtOgsaP1V+bT3Tp77P3xTTiI9hbmnCag2qNhWbSsB65dI8zMV6HkCESqLrDBzEU9+7cjE+uFb+WapeklYdG9x2aNvmi3cb6oFohuVUbHT1kbv4yvYqQ/hqKu2e9/DHG0jWAo27OeHWvu0+RA8yY7o7at2WDiLNBbgJsysSXV8YyhT9wXKRThf/2er8rRrAU95LXPy6665lxhwgBV+38RBxo4SC1eeMsmJNrBLbEL93flE7bj6B/7mSAyjiHmUIciIr2BLDs60xseqMOAWsRUbaDFn8aWcnRm+JMekPTTsbsBtfI65pGp0IN0AimwWR56FMsNTa1KbRRGsAVU6kkvtMmqqiyhKn4tB4TVYL+pHVrFHbE6AgbTkrasNIPlVmTFIsPZPUBcHVgKfrgV+j1QLSeBCIpE+xDKiKcYOG1rITDQMT/O85Go3e+8j7DyC7fYnT/VxlOIxcsUU07q+BLjKcEF3ajDUmQLSJ2pnQfFDgX01ySpaZo/J/4i6CkD1vn6CLWI3EkwbaNSvxub4yWnQPkFVi+FJYRc6/uhmsYRZCWSLarBPOryinxCucMraZ8JAXQ5BtFb9t2IpFl2vqrJhptezZqZcT/EmBQqb80ASe6hRP5 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 27caa092-f2ac-4007-b33c-08daee8ee43e X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jan 2023 20:04:30.7802 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /XSBZYAZ1AhrR+gJ56L9v2jZat6uDOBH+gbMGzI8dCfQjzb926Ao9g+2AmOoFjshkbBgCdCW4MvvptyMxtWRdrox/tHVnjsrDfJRpD7sO1g= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5312 T24gMjEvMTIvMjAyMiA3OjQwIGFtLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMjAuMTIuMjAy MiAyMTo1NiwgQW5kcmV3IENvb3BlciB3cm90ZToNCj4+IE9uIDIwLzEyLzIwMjIgMTo1MSBwbSwg SmFuIEJldWxpY2ggd3JvdGU6DQo+Pj4gT24gMTYuMTIuMjAyMiAyMToxNywgQW5kcmV3IENvb3Bl ciB3cm90ZToNCj4+Pj4gKyAgICAgICAgIm1vdiAgICAlW2NyNF0sICUlY3I0XG5cdCIgICAgIC8q IENSNC5QR0UgPSAxICovDQo+Pj4+ICsgICAgICAgIDogW2NyNF0gIj0mYSIgKHRtcCkgLyogQ291 bGQgYmUgInIiLCBidXQgImEiIG1ha2VzIGJldHRlciBhc20gKi8NCj4+Pj4gKyAgICAgICAgOiBb Y3IzXSAiciIgKF9fcGEoaWRsZV9wZ190YWJsZSkpLA0KPj4+PiArICAgICAgICAgIFtwZ2VdICJp IiAoWDg2X0NSNF9QR0UpDQo+Pj4+ICsgICAgICAgIDogIm1lbW9yeSIgKTsNCj4+PiBUaGUgcmVt b3ZlZCBzdGFjayBjb3B5aW5nIHdvcnJpZXMgbWUsIHRvIGJlIGhvbmVzdC4gWWVzLCBmb3IgbG9j YWwNCj4+PiB2YXJpYWJsZXMgb2Ygb3VycyBpdCBkb2Vzbid0IG1hdHRlciBiZWNhdXNlIHRoZXkg YXJlIGFib3V0IHRvIGdvIG91dA0KPj4+IG9mIHNjb3BlLiBCdXQgd2hhdCBpZiB0aGUgY29tcGls ZXIgaW5zdGFudGlhdGVzIGFueSBmb3IgaXRzIG93biB1c2UsDQo+Pj4gZS5nLiAuLi4NCj4+Pg0K Pj4+PiArICAgIC8qDQo+Pj4+ICsgICAgICogRW5kIG9mIHRoZSBjcml0aWNhbCByZWdpb24uICBV cGRhdGVzIHRvIGxvY2FscyBhbmQgZ2xvYmFscyBub3cgd29yayBhcw0KPj4+PiArICAgICAqIGV4 cGVjdGVkLg0KPj4+PiArICAgICAqDQo+Pj4+ICsgICAgICogVXBkYXRlcyB0byBsb2NhbCB2YXJp YWJsZXMgd2hpY2ggaGF2ZSBiZWVuIHNwaWxsZWQgdG8gdGhlIHN0YWNrIHNpbmNlDQo+Pj4+ICsg ICAgICogdGhlIG1lbWNweSgpIGhhdmUgYmVlbiBsb3N0LiAgQnV0IHdlIGRvbid0IGNhcmUsIGJl Y2F1c2UgdGhleSdyZSBhbGwNCj4+Pj4gKyAgICAgKiBnb2luZyBvdXQgb2Ygc2NvcGUgaW1taW5l bnRseS4NCj4+Pj4gKyAgICAgKi8NCj4+Pj4gKw0KPj4+PiArICAgIHByaW50aygiTmV3IFhlbiBp bWFnZSBiYXNlIGFkZHJlc3M6ICUjbHhcbiIsIHhlbl9waHlzX3N0YXJ0KTsNCj4+PiAuLi4gdGhl IHJlc3VsdCBvZiB0aGUgYWRkcmVzcyBjYWxjdWxhdGlvbiBmb3IgdGhlIHN0cmluZyBsaXRlcmFs DQo+Pj4gaGVyZT8gU3VjaCBhdXhpbGlhcnkgY2FsY3VsYXRpb25zIGNhbiBoYXBwZW4gYXQgYW55 IHBvaW50IGluIHRoZQ0KPj4+IGZ1bmN0aW9uLCBhbmQgd29uJ3QgbmVjZXNzYXJpbHkgKGhlbmNl IHRoZSBleGFtcGxlIGNob3NlbikgYmVjb21lDQo+Pj4gaW1wb3NzaWJsZSBmb3IgdGhlIGNvbXBp bGVyIHRvIGRvIHdpdGggdGhlIG1lbW9yeSBjbG9iYmVyIGluIHRoZQ0KPj4+IGFzbSgpLiBBbmQg d2hpbGUgdGhlIHN0cmluZyBsaXRlcmFsJ3MgYWRkcmVzcyBpcyBsaWtlbHkgY2hlYXANCj4+PiBl bm91Z2ggdG8gY2FsY3VsYXRlIHJpZ2h0IGluIHRoZSBmdW5jdGlvbiBpbnZvY2F0aW9uIHNlcXVl bmNlIChhbmQNCj4+PiBhbiBvcHRpb24gd291bGQgYWxzbyBiZSB0byByZXRhaW4gdGhlIHByaW50 aygpIGluIHRoZSBjYWxsZXIpLA0KPj4+IG90aGVyIGluc3RydW1lbnRhdGlvbiBvcHRpb25zIGNv dWxkIGJlIHVuZGVybWluZWQgYnkgdGhpcyBhcyB3ZWxsLg0KPj4gUmlnaHQgbm93LCB0aGUgY29t cGlsZXIgaXMgZnJlZSB0byBjYWxjdWxhdGUgdGhlIGFkZHJlc3Mgb2YgdGhlIHN0cmluZw0KPj4g bGl0ZXJhbCBpbiBhIHJlZ2lzdGVyLCBhbmQgbW92ZSBpdCB0aGUgb3RoZXIgc2lkZSBvZiB0aGUg VExCIGZsdXNoLsKgDQo+PiBUaGlzIHdpbGwgd29yayBqdXN0IGZpbmUuDQo+Pg0KPj4gSG93ZXZl ciwgdGhlIGNvbXBpbGVyIGNhbm5vdCBub3csIG9yIGV2ZXIgaW4gdGhlIGZ1dHVyZSwgc3BpbGwg c3VjaCBhDQo+PiBjYWxjdWxhdGlvbiB0byB0aGUgc3RhY2suDQo+IEknbSBhZnJhaWQgdGhlIGNv bXBpbGVyJ3MgdmlldyBhdCB0aGluZ3MgaXMgZGlmZmVyZW50OiBXaGF0ZXZlciBpdCBwdXRzDQo+ IG9uIHRoZSBzdGFjayBpcyB2aWV3ZWQgYXMgdmlydHVhbCByZWdpc3RlcnMsIHVuYWZmZWN0ZWQg YnkgYSBtZW1vcnkNCj4gY2xvYmJlciAob2YgY291cnNlIHRoZXJlIGNhbiBiZSBlZmZlY3RzIHJl c3VsdGluZyBmcm9tIHVzZXMgb2YgbmFtZWQNCj4gdmFyaWFibGVzKS4gTG9vayBhdCAtTzMgb3V0 cHV0IG9mIGdjYzEyICh3aGljaCBpcyB3aGF0IEkgaGFwcGVuZWQgdG8NCj4gcGxheSB3aXRoOyBJ IGRvbid0IHRoaW5rIGl0J3Mgb3Zlcmx5IHZlcnNpb24gZGVwZW5kZW50KSBmb3IgdGhpcw0KPiAo Y2xlYXJseSBjb250cml2ZWQpIHBpZWNlIG9mIGNvZGU6DQo+DQo+IGludCBfX2F0dHJpYnV0ZV9f KChjb25zdCkpIGNhbGMoaW50KTsNCj4NCj4gaW50IHRlc3QoaW50IGkpIHsNCj4gCWludCBqID0g Y2FsYyhpKTsNCj4NCj4gCWFzbSgibm9wbCAlMCIgOiAiK20iIChqKSk7DQo+IAlhc20oIm5vcHEg JSVyc3AiIDo6OiAibWVtb3J5IiwgImF4IiwgImN4IiwgImR4IiwgImJ4IiwgImJwIiwgInNpIiwg ImRpIiwNCj4gCSAgICAgICAgICAgICAgICAgICAgICJyOCIsICJyOSIsICJyMTAiLCAicjExIiwg InIxMiIsICJyMTMiLCAicjE0IiwgInIxNSIpOw0KPiAJaiA9IGNhbGMoaSk7DQo+IAlhc20oIm5v cGwgJTAiIDo6ICJtIiAoaikpOw0KPg0KPiAJcmV0dXJuIGo7DQo+IH0NCj4NCj4gSXQgaW5zdGFu dGlhdGVzIGEgbG9jYWwgb24gdGhlIHN0YWNrIGZvciB0aGUgcmVzdWx0IG9mIGNhbGMoKTsgaXQg ZG9lcw0KPiBub3QgcmUtaW52b2tlIGNhbGMoKSBhIDJuZCB0aW1lLiBXaGljaCBtZWFucyB0aGUg bWVtb3J5IGNsb2JiZXIgaW4gdGhlDQo+IG1pZGRsZSBhc20oKSBkb2VzIG5vdCBhZmZlY3QgdGhh dCAoYW5kIGJ5IGltcGxpY2F0aW9uOiBhbnkpIHN0YWNrIHNsb3QuDQo+DQo+IFVzaW5nIGdvZGJv bHQgSSBjYW4gYWxzbyBzZWUgdGhhdCBjbGFuZzE1IGFncmVlcyB3aXRoIGdjYzEyIGluIHRoaXMN Cj4gcmVnYXJkLiBJIGRpZG4ndCBib3RoZXIgdHJ5aW5nIG90aGVyIHZlcnNpb25zLg0KDQpXZWxs IHRoaXMgaXMgcHJvYmxlbWF0aWMsIGJlY2F1c2UgaXQgY29udHJhZGljdHMgd2hhdCB3ZSBkZXBl bmQgb24NCmFzbSgiIjo6OiJtZW1vcnkiKSBkb2luZy4uLg0KDQpodHRwczovL2dvZGJvbHQub3Jn L3oveGVHTWMzc005DQoNCkJ1dCBJIGRvbid0IGZ1bGx5IGFncmVlIHdpdGggdGhlIGNvbmNsdXNp b25zIGRyYXduIGJ5IHRoaXMgZXhhbXBsZS4NCg0KSXQgb25seSBpbnN0YW50aWF0ZXMgYSBsb2Nh bCBvbiB0aGUgc3RhY2sgYmVjYXVzZSB5b3UgZm9yY2UgYSBtZW1vcnkNCm9wZXJhbmQgdG8gc2F0 aXNmeSB0aGUgIm0iIGNvbnN0cmFpbnRzLCBub3QgdG8gc2F0aXNmeSB0aGUgIm1lbW9yeSINCmNv bnN0cmFpbnQuDQoNCkJ5IGRlY2xhcmluZyBjYWxjIGFzIGNvbnN0LCB5b3UgYXJlIHBlcm1pdHRp bmcgdGhlIGNvbXBpbGVyIHRvIG1ha2UgYW4NCmV4cGxpY2l0IHRyYW5zZm9ybWF0aW9uIHRvIGRl bGV0ZSBvbmUgb2YgdGhlIGNhbGxzLCBpcnJlc3BlY3RpdmUgb2YNCmFueXRoaW5nIGVsc2UgaW4g dGhlIGZ1bmN0aW9uLg0KDQpJdCBpcyB3ZWlyZCB0aGF0ICdqJyBlbmRzIHVwIHRha2luZyB0d28g c3RhY2sgc2xvdHMgd2hlbiB3b3VsZCBiZQ0KYWJzb2x1dGVseSBmaW5lIGZvciBpdCB0byBvbmx5 IGhhdmUgMSwgYW5kIGluZGVlZCB0aGlzIGlzIHdoYXQgaGFwcGVucw0Kd2hlbiB5b3UgcmVtb3Zl IHRoZSBmaXJzdCBhbmQgdGhpcmQgYXNtKCkncy7CoCBJdCBpcyB0aGVzZSB3aGljaCBmb3JjZQ0K J2onIHRvIGJlIG9uIHRoZSBzdGFjaywgbm90IHRoZSBtZW1vcnkgY2xvYmJlciBpbiB0aGUgbWlk ZGxlLg0KDQpPYnNlcnZlIHRoYXQgYWZ0ZXIgY29tbWVudGluZyB0aG9zZSB0d28gb3V0LCBDbGFu ZyB0cmFuc2Zvcm1zIHRoaW5ncyB0bw0Kc3BpbGwgJ2knIG9udG8gdGhlIHN0YWNrLCByYXRoZXIg dGhhbiAnaicsIGFuZCB0aGVuIHRhaWwtY2FsbCBjYWxjKCkgb24NCnRoZSB3YXkgb3V0LsKgIFRo aXMgaXMgYWN0dWFsbHkgZGVsZXRpbmcgdGhlIGZpcnN0IGNhbGMoKSBjYWxsLCByYXRoZXINCnRo YW4gdGhlIHNlY29uZC4NCg0KfkFuZHJldw0K From xen-devel-bounces@lists.xenproject.org Wed Jan 04 20:31:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 20:31:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471461.731308 (Exim 4.92) (envelope-from ) id 1pDAPw-0000Nx-M1; Wed, 04 Jan 2023 20:31:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471461.731308; Wed, 04 Jan 2023 20:31:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDAPw-0000Nq-In; Wed, 04 Jan 2023 20:31:20 +0000 Received: by outflank-mailman (input) for mailman id 471461; Wed, 04 Jan 2023 20:31:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDAPv-0000Nk-E4 for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 20:31:19 +0000 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [2a00:1450:4864:20::633]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bccd8b91-8c6e-11ed-b8d0-410ff93cb8f0; Wed, 04 Jan 2023 21:31:16 +0100 (CET) Received: by mail-ej1-x633.google.com with SMTP id x22so85394680ejs.11 for ; Wed, 04 Jan 2023 12:31:16 -0800 (PST) Received: from ?IPv6:::1? (p200300faaf0bb2008108eedf25879029.dip0.t-ipconnect.de. [2003:fa:af0b:b200:8108:eedf:2587:9029]) by smtp.gmail.com with ESMTPSA id l2-20020a1709060cc200b0084c4a8062a0sm12901703ejh.149.2023.01.04.12.31.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Jan 2023 12:31:15 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bccd8b91-8c6e-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=+XRBUxpmPx9usQEuTJXDwuff2z3rP9GnzpnzVXFfp2A=; b=KPR7ESFJUZ9mQDwHEIGHdXbgAumH46eg/HrFO8zp0Wzpc46FWnPJVYGRnO/nt6OjNc ouzKS2j34Qvb2dyGEZxtdRr5SDNyE4S2A0/UG6gjJxBRuqTOv71pMCY4j+piNai2QZxb uDWTJx67GW7J6kE23DtA68wH2pytXfrREZnuxxzguNTOaL2eH4DEJ2QYZtH6yG1kpTsa 790YDTiWkV/FtzskkuhqUrNZIifd3V1zmpTDtqWAFsoR0hWAljOxP4EC91YO3PX6SD20 l2DyB1Q3XnC5SJldn3YQVxu6GS24ixejmv78PidQHKSxji/wwNnzmVRQvaJlN0G9oCFM 0lKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+XRBUxpmPx9usQEuTJXDwuff2z3rP9GnzpnzVXFfp2A=; b=Y/svb7YuSV9qeRAcbgabEtaTKeGbNGr8PhAuMXysYEORu78EqBs1qc1huSb3Fi1gid wlsOUw/5HjQ9V93aX35o9DlnqFc4SMxMhblzi7qzfpJTS/kLgFYvlp6sEEjqVZvszDdj CtseQj3+HyYYUfTbVrVpYsJKI4RqTh5raGWwAq66EX8ECpclfpdhL0AKVDI4RpON0e5q RLRlSD+c+sFjejvt2e4x0Cv87FIzhiB/xGPW87PfLMW1qD/ipfXmEB0kb2eA06xuxV3M Gx81li6wW14Ow4xX4RSEauhmtvrOogSLNmPPqZvU2PdclRFaOaKzIZQGT8NStASQWL3w nQpw== X-Gm-Message-State: AFqh2kq7i8K1ndEjKo8YbyqyNSXBqzWXKojhJlnjlbl0tpOyO7Lc63lz EdWHIaAQoKWhH5RA3F/cqaE= X-Google-Smtp-Source: AMrXdXsta8i2SwGAjzUl+oFzU2XtPqGoG0G+UvqlFlG8R0YsfOzmlrhJt+FjHFZ1CmWKajdhCWGJ1Q== X-Received: by 2002:a17:907:6f19:b0:818:3ef8:f2fc with SMTP id sy25-20020a1709076f1900b008183ef8f2fcmr40195994ejc.5.1672864275622; Wed, 04 Jan 2023 12:31:15 -0800 (PST) Date: Wed, 04 Jan 2023 20:31:10 +0000 From: Bernhard Beschow To: Chuck Zmudzinski , =?ISO-8859-1?Q?Philippe_Mathieu-Daud=E9?= , qemu-devel@nongnu.org, Markus Armbruster CC: Richard Henderson , Stefano Stabellini , xen-devel@lists.xenproject.org, =?ISO-8859-1?Q?Herv=E9_Poussineau?= , Aurelien Jarno , Paul Durrant , Marcel Apfelbaum , Anthony Perard , "Michael S. Tsirkin" , Paolo Bonzini , Eduardo Habkost , Thomas Huth Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_v2_6/6=5D_hw/isa/piix=3A_Res?= =?US-ASCII?Q?olve_redundant_TYPE=5FPIIX3=5FXEN=5FDEVICE?= In-Reply-To: <92efe0f1-f22b-47bc-f27d-2f31cb3621ea@aol.com> References: <20230104144437.27479-1-shentey@gmail.com> <20230104144437.27479-7-shentey@gmail.com> <1c2e0780-e5fb-1321-0d84-b0591db9fec7@linaro.org> <92efe0f1-f22b-47bc-f27d-2f31cb3621ea@aol.com> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Am 4=2E Januar 2023 19:29:35 UTC schrieb Chuck Zmudzinski : >On 1/4/23 1:48=E2=80=AFPM, Philippe Mathieu-Daud=C3=A9 wrote: >> On 4/1/23 18:54, Chuck Zmudzinski wrote: >>> On 1/4/23 10:35=E2=80=AFAM, Philippe Mathieu-Daud=C3=A9 wrote: >>>> +Markus/Thomas >>>> >>>> On 4/1/23 15:44, Bernhard Beschow wrote: >>>>> During the last patches, TYPE_PIIX3_XEN_DEVICE turned into a clone o= f >>>>> TYPE_PIIX3_DEVICE=2E Remove this redundancy=2E >>>>> >>>>> Signed-off-by: Bernhard Beschow >>>>> --- >>>>> hw/i386/pc_piix=2Ec | 4 +--- >>>>> hw/isa/piix=2Ec | 20 -------------------- >>>>> include/hw/southbridge/piix=2Eh | 1 - >>>>> 3 files changed, 1 insertion(+), 24 deletions(-) >>>>> >>>>> diff --git a/hw/i386/pc_piix=2Ec b/hw/i386/pc_piix=2Ec >>>>> index 5738d9cdca=2E=2E6b8de3d59d 100644 >>>>> --- a/hw/i386/pc_piix=2Ec >>>>> +++ b/hw/i386/pc_piix=2Ec >>>>> @@ -235,8 +235,6 @@ static void pc_init1(MachineState *machine, >>>>> if (pcmc->pci_enabled) { >>>>> DeviceState *dev; >>>>> PCIDevice *pci_dev; >>>>> - const char *type =3D xen_enabled() ? TYPE_PIIX3_XEN_DEVICE >>>>> - : TYPE_PIIX3_DEVICE; >>>>> int i; >>>>> =20 >>>>> pci_bus =3D i440fx_init(pci_type, >>>>> @@ -250,7 +248,7 @@ static void pc_init1(MachineState *machine, >>>>> : pci_slot_get_pirq); >>>>> pcms->bus =3D pci_bus; >>>>> =20 >>>>> - pci_dev =3D pci_new_multifunction(-1, true, type); >>>>> + pci_dev =3D pci_new_multifunction(-1, true, TYPE_PIIX3_DEVI= CE); >>>>> object_property_set_bool(OBJECT(pci_dev), "has-usb", >>>>> machine_usb(machine), &error_abo= rt); >>>>> object_property_set_bool(OBJECT(pci_dev), "has-acpi", >>>>> diff --git a/hw/isa/piix=2Ec b/hw/isa/piix=2Ec >>>>> index 98e9b12661=2E=2Ee4587352c9 100644 >>>>> --- a/hw/isa/piix=2Ec >>>>> +++ b/hw/isa/piix=2Ec >>>>> @@ -33,7 +33,6 @@ >>>>> #include "hw/qdev-properties=2Eh" >>>>> #include "hw/ide/piix=2Eh" >>>>> #include "hw/isa/isa=2Eh" >>>>> -#include "hw/xen/xen=2Eh" >>>>> #include "sysemu/runstate=2Eh" >>>>> #include "migration/vmstate=2Eh" >>>>> #include "hw/acpi/acpi_aml_interface=2Eh" >>>>> @@ -465,24 +464,6 @@ static const TypeInfo piix3_info =3D { >>>>> =2Eclass_init =3D piix3_class_init, >>>>> }; >>>>> =20 >>>>> -static void piix3_xen_class_init(ObjectClass *klass, void *data) >>>>> -{ >>>>> - DeviceClass *dc =3D DEVICE_CLASS(klass); >>>>> - PCIDeviceClass *k =3D PCI_DEVICE_CLASS(klass); >>>>> - >>>>> - k->realize =3D piix3_realize; >>>>> - /* 82371SB PIIX3 PCI-to-ISA bridge (Step A1) */ >>>>> - k->device_id =3D PCI_DEVICE_ID_INTEL_82371SB_0; >>>>> - dc->vmsd =3D &vmstate_piix3; >>>> >>>> IIUC, since this device is user-creatable, we can't simply remove it >>>> without going thru the deprecation process=2E Alternatively we could >>>> add a type alias: >>>> >>>> -- >8 -- >>>> diff --git a/softmmu/qdev-monitor=2Ec b/softmmu/qdev-monitor=2Ec >>>> index 4b0ef65780=2E=2Ed94f7ea369 100644 >>>> --- a/softmmu/qdev-monitor=2Ec >>>> +++ b/softmmu/qdev-monitor=2Ec >>>> @@ -64,6 +64,7 @@ typedef struct QDevAlias >>>> QEMU_ARCH_LOONGARCH) >>>> #define QEMU_ARCH_VIRTIO_CCW (QEMU_ARCH_S390X) >>>> #define QEMU_ARCH_VIRTIO_MMIO (QEMU_ARCH_M68K) >>>> +#define QEMU_ARCH_XEN (QEMU_ARCH_ARM | QEMU_ARCH_I386) >>>> >>>> /* Please keep this table sorted by typename=2E */ >>>> static const QDevAlias qdev_alias_table[] =3D { >>>> @@ -111,6 +112,7 @@ static const QDevAlias qdev_alias_table[] =3D { >>>> { "virtio-tablet-device", "virtio-tablet", QEMU_ARCH_VIRTIO_MM= IO }, >>>> { "virtio-tablet-ccw", "virtio-tablet", QEMU_ARCH_VIRTIO_CCW }= , >>>> { "virtio-tablet-pci", "virtio-tablet", QEMU_ARCH_VIRTIO_PCI }= , >>>> + { "PIIX3", "PIIX3-xen", QEMU_ARCH_XEN }, >>>=20 >>> Hi Bernhard, >>>=20 >>> Can you comment if this should be: >>>=20 >>> + { "PIIX", "PIIX3-xen", QEMU_ARCH_XEN }, >>>=20 >>> instead? IIUC, the patch series also removed PIIX3 and PIIX4 and >>> replaced them with PIIX=2E Or am I not understanding correctly? >>=20 >> There is a confusion in QEMU between PCI bridges, the first PCI >> function they implement, and the other PCI functions=2E >>=20 >> Here TYPE_PIIX3_DEVICE means for "PCI function part of the PIIX >> south bridge chipset, which expose a PCI-to-ISA bridge"=2E A better >> name could be TYPE_PIIX3_ISA_PCI_DEVICE=2E Unfortunately this >> device is named "PIIX3" with no indication of ISA bridge=2E > > >Thanks, you are right, I see the PIIX3 device still exists after >this patch set is applied=2E > >chuckz@debian:~/sources-sid/qemu/qemu-7=2E50+dfsg/hw/i386$ grep -r PIIX3 = * >pc_piix=2Ec: pci_dev =3D pci_new_multifunction(-1, true, TYPE_PIIX= 3_DEVICE); > >I also understand there is the PCI-to-ISA bridge at 00:01=2E0 on the PCI = bus: > >chuckz@debian:~$ lspci >00:00=2E0 Host bridge: Intel Corporation 440FX - 82441FX PMC [Natoma] (re= v 02) >00:01=2E0 ISA bridge: Intel Corporation 82371SB PIIX3 ISA [Natoma/Triton = II] >00:01=2E1 IDE interface: Intel Corporation 82371SB PIIX3 IDE [Natoma/Trit= on II] >00:01=2E2 USB controller: Intel Corporation 82371SB PIIX3 USB [Natoma/Tri= ton II] (rev 01) >00:01=2E3 Bridge: Intel Corporation 82371AB/EB/MB PIIX4 ACPI (rev 03) >00:02=2E0 Unassigned class [ff80]: XenSource, Inc=2E Xen Platform Device = (rev 01) >00:03=2E0 VGA compatible controller: Device 1234:1111 (rev 02) > >I also see with this patch, there is a bridge that is a PIIX4 ACPI at 00:= 01=2E3=2E Yeah, this PIIX4 ACPI device is what we consider a "Frankenstein" device h= ere on the list=2E Indeed my PIIX consolidation series aims for eventually = replacing the remaining PIIX3 devices with PIIX4 ones to present a realisti= c environment to guests=2E The series you tested makes Xen work with PIIX4= =2E With a couple of more patches you might be able to opt into a realistic= PIIX4 emulation in the future! Best regards, Bernhard >I get the exact same output from lspci without the patch series, so that = gives >me confidence it is working as designed=2E From xen-devel-bounces@lists.xenproject.org Wed Jan 04 20:36:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 20:36:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471468.731318 (Exim 4.92) (envelope-from ) id 1pDAUs-00010p-9b; Wed, 04 Jan 2023 20:36:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471468.731318; Wed, 04 Jan 2023 20:36:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDAUs-00010i-71; Wed, 04 Jan 2023 20:36:26 +0000 Received: by outflank-mailman (input) for mailman id 471468; Wed, 04 Jan 2023 20:36:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDAUr-00010c-86 for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 20:36:25 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 72fb8ae8-8c6f-11ed-91b6-6bf2151ebd3b; Wed, 04 Jan 2023 21:36:23 +0100 (CET) Received: from mail-mw2nam12lp2048.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.48]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Jan 2023 15:36:20 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SA0PR03MB5449.namprd03.prod.outlook.com (2603:10b6:806:bd::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Wed, 4 Jan 2023 20:36:18 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5944.019; Wed, 4 Jan 2023 20:36:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 72fb8ae8-8c6f-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1672864583; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=PX9Hao7kAOIUCw01ZnI+MlM66qhVjSXG+ZjoCHG19xs=; b=QUffAJYOu4311AtoLcUJou8SLWvjqdV7mpxjqraMtAenCIEJdLjszp7O GBT/mXZt2ojETK+jSgHR8ouiwIZuE4AVaXUWVf8AwlwCgUDKJmDr+lsne KrGQEh+40qmD0L3LD2RWJTefftErnyoNf/xBUA07mDXFPXkOA9DBDLR1z I=; X-IronPort-RemoteIP: 104.47.66.48 X-IronPort-MID: 91204710 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:jbDMRKqc6xEj+mJn4PnrduGrwXReBmKxZBIvgKrLsJaIsI4StFCzt garIBmEOvaON2f2KN53O9+1oRkO78PRmNFgQAFq+Co1QSgb9puZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpAFc+E0/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06W1wUmAWP6gR5weHzyVNUfrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXABs/czGarNqP+5zlCdJciMgAN9XpNZxK7xmMzRmBZRonabbqZvyQoPpnhnI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3juarbIq9lt+iHK25mm6xo G7c8nu/KRYdLNGFkhKO8262h/+JliT+MG4XPOzhrKY23wTLroAVIF4bDBiSntuAsXP9HNx+L EFO6gt2t4FnoSRHSfG4BXVUukWsuRoRWMFREqs59RuKwarX5C6WA2EFSnhKb9lOnN87Q3km2 0GEm/vtBCdzq/uFRHSF7LCWoDiufy8PIgcqbygORxoI+NnnrYQ6iDrAS99iFOi+ididMTj0w iuWpSkkwbsJhMgA1r6T4lzMxTmro/DhRQkz4ALVUmu77xhRa4usZoju4l/ehd5CMYKYQ1+pr HUC3c+E44gmFoqRnSaAROEMGrCB5PufNjDYx1l1EPEJ+DWk/Xq+dol4+jBgI1xoNM1CcjjsC HI/oitU7Z5XeX61N6l+ZtvrD9xwlfSwU9P4SvrTc9xCJIBrcxOK9z1vYkjW2H3xlE8rkuc0P pLznduQMEv2wJ9PlFKeL9rxG5dyrszi7Qs/nazG8ik= IronPort-HdrOrdr: A9a23:PgFxNq4/3M/fqOk8xwPXwPXXdLJyesId70hD6mlbQxY9SL3+qy nIppgmPH7P5wr5PUtKpTnuAse9qB/nlKKdg7NhXotKLTOHhILAFugLh+bfKlbbak/DH4BmpM NdWpk7JNrsDUVryebWiTPIderIGeP3lZyVuQ== X-IronPort-AV: E=Sophos;i="5.96,301,1665460800"; d="scan'208";a="91204710" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kE81Gwf+/uQB7/gUc5Yft1aiBxdo265ZX1zDA+qI5G8OEsZP+s2O53ClDQxL4L4fFpWT/Fz7J1JV6uiH84nJ+oVFz+F4erVAoa6NJjz1uPmysDBG/TzpS3fvuh2WjpZUfwnf5/ydwKRWR8CsxXKHKq1lbCfjvKOn2GLGdaLbwNrN5MqFmVdRm4737rp4wowNWsPOV8ZJXS97ViXrR7gyzzsxzRwJC+k/dVBljuEFexffvVrAjYW1PwCFSp6+0WrMkQTGtbt5Teo/oXc2dCpPbApsOi1WcioECS0p3DqYSLLAxfNq+ykuc1DHxF4ePzwKf6lecR7uS48HZXQpgFJguw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PX9Hao7kAOIUCw01ZnI+MlM66qhVjSXG+ZjoCHG19xs=; b=LpjPTE6AmkbgnCqRf7jGx3zJYknMe8pwS3AbWlyN1ifWK8LbBmd2EMc6RYHYXO2fgY8Mn6CD1Bel+X5bKVFxussVb+YfcbJtaUcZORRQXGsm09aMRFG8viK5VBnuNs1GTUb5XERFGWeNmLW0r+mDfS+WOwDDQIIZnnmqpy1CnT1goP32XQmj5qp4uCJuWHO/C1PXOtv23uKmSzRCOClLoHXKxz+TEl/UAE/q2Iq14zt5YScUWuVH6TuYAjvg6RK+Qw/9f6yaMKLIVRozFEeROc0AVNOoih5oiyYBuw/wg6Vh8qFHVeApt/874Nvn8aBNcGbAM3SQNpYrZQZbM3omlg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PX9Hao7kAOIUCw01ZnI+MlM66qhVjSXG+ZjoCHG19xs=; b=TECNXG6HNbP/wgwpgtHgrGLVM+VNTHO0W9teIH4qY1OyKPisEMoRU4GV7LXhen4k2uJJ31ASTyKIgLwYOsHxRhvanK7omycL0g3v3wV3auacKWoADrFveJPcRfoaGAWEm99noagfL5mjKfYlY2SPn1k8R7AFw03OBvuMf0R3wNg= From: Andrew Cooper To: Oleksii Kurochko , "xen-devel@lists.xenproject.org" CC: Bob Eshleman , Alistair Francis , Connor Davis , Julien Grall , Anthony Perard , Stefano Stabellini , Gianluca Guida Subject: Re: [XEN PATCH v2 1/2] arch/riscv: initial RISC-V support to build/run minimal Xen Thread-Topic: [XEN PATCH v2 1/2] arch/riscv: initial RISC-V support to build/run minimal Xen Thread-Index: AQHZHE7fYMe4r24iGUSr/qW4K6+f3q6Ov8aA Date: Wed, 4 Jan 2023 20:36:18 +0000 Message-ID: References: <4702cb223dbd7629fe3d3e494eb363f4b2534e96.1672401599.git.oleksii.kurochko@gmail.com> In-Reply-To: <4702cb223dbd7629fe3d3e494eb363f4b2534e96.1672401599.git.oleksii.kurochko@gmail.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|SA0PR03MB5449:EE_ x-ms-office365-filtering-correlation-id: 610409af-518d-4e13-d89c-08daee935517 x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Fg+he7S+pyE976bVWE8ZFC/jg0HmosF6Ifi/9DxqZ2EsSaasQ3K22te1M+oR/Wf95QHfPnTPm5PIUJFCytl5MieEM+eyJpTSbgAPMtUeU75lnF3UJYYTRM/EP8Z7u2p1WAK4Lv37AY9M8IZdeRR85oqggdIYzbCcC6Co+fHOaM5XWZrT/bAgFi1gAB+rWHxYuy+Yt94d/yFEkGYENWZu2Oszv1QTUeeXu85UQ3+1Qvt4RLgo+48HsWCivkcSeE+OGgHDFRD5NzioPfoyFOZtTxa+OVbe7E97Ad9gB04E///3cHcthNdET9607lvfhaPXyWFU0mX8wrAMCnHOVYzEr0yuDZePI5kT6Xi35XL+SVMsvZDDPzTFhtcJ+NwIsII1EjJfixnbBUcSjA4EYT9u8HEthx4+s96RXzpt6DbapdOdfGfr9JXA2bhGFZFmj1UijgXjGBTE3vibG4AP+tqS3byinqrTb6j42ngmK2FuV2ifNomliYYLQwUsGDcWFW/wc9NKNwsZlaLPgROejxZEwnbfmpmBnwojrgkbDLXWwZRf2DYDqWQp1wUZpxpItPt/pvItAH2L39uFh48CcJn4SfIfWm6ZMUZpDqfuU0F42FoWsjLXGNxGYs9NTLK5ruHDzSbfsRC2zKLs1NX5iX25ss4ZtXEqR+ZYP7vj61vLa061kJK1yGK6g7iWvGdjEPPkOrwzYsvznX4wrMlDB4A3wNY48FGS8e7qR/+EJP9qlr2qBqHC2WrR2YUzyCf62xSOZ4eS7I4HJ/RF0p8F+wnprw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(366004)(136003)(376002)(396003)(346002)(451199015)(38070700005)(122000001)(82960400001)(38100700002)(36756003)(31696002)(86362001)(2616005)(66556008)(64756008)(6506007)(66476007)(316002)(53546011)(478600001)(66446008)(76116006)(26005)(71200400001)(6512007)(186003)(110136005)(54906003)(31686004)(6486002)(91956017)(2906002)(66946007)(8676002)(41300700001)(8936002)(4326008)(83380400001)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?MTltbTkrbTdjejQ2SnRvc2hORDhPRXZGSlVBbHExbG1QdzNDQlNILy9FM29E?= =?utf-8?B?eUZ0SjhGUDhhaHFCcm1KMytLcUNvU3hEWkQwcVNHcEVrK0g2cUxORXkvL1p3?= =?utf-8?B?U00vZHJNdjEwMWVzbmt5WC85ekR5NmhpR3hHRmFyRVVMT2xBQ3NqSEJMdFR0?= =?utf-8?B?NVorUnBWS2N5dk9CSmJkOTRQZWtuRXlEckc1MEJJWitpZlRHWU9SRDlucjFW?= =?utf-8?B?K1QzY3cybFh5aTcwQmt6VHFxMFBWMGFCRU9CdGFWY2l6NmI5dkpiZVFqd1Fn?= =?utf-8?B?NFBkWms3NU1VZzQ2QStaNzAxcUcySU9DM2RKczAyQ2UrVitpelZ4MHZmMFRY?= =?utf-8?B?NlpOSWx5T0xEMFNmSWx2bDIvZmljOXdKeTJ1a2ZvLzg5eHZxc1RIZjV6VXdv?= =?utf-8?B?ZEh2TXRhZklqYkVFa254U0tzb0p6R2w1V3JhdHA4NS9XUlNMMlZ4OWNFT1lE?= =?utf-8?B?S3JsUnRyOW9WRjJHOHg2SEo0eHJUM1MwNFIrY21TRHVWMEhiTkJqcFlJUVMr?= =?utf-8?B?MEZFT2NlYWpKa3lNbjZtZzlKU0NyT3NMSHhJMkZPaVNNZ2k3clVVaWlXdnps?= =?utf-8?B?NGVRQTdVT3AvZTc5SGJiZXdRZmRXQ2tMTWs1NXEzOXpnaDRzbkQ0WEVURFBz?= =?utf-8?B?QU91ZnNSUHh0dzVmZmtFQ1lZejNMaHorMGM5L3p3cFoyVFU4OXRZNVlXNzJT?= =?utf-8?B?UzNHOXdnTm8yRysrVjRFdlI5citibWxzNUcwRG93MVgwL3JDVDkyQkxoeUF5?= =?utf-8?B?RlhrMTFjK0R3Rjlsa3VUMW8rMmtXdEo5VjNRYUdyczNCQ2JJUHpqc1g2TnVR?= =?utf-8?B?WmowR1FsNEYwVWhGbWFlSGVwUGNmTDhIcHRZZThPM2hLQzVGYndkUVhpU3BJ?= =?utf-8?B?dkJrcVpnamtnQVFvNWZHdWo4enRsQTllYnRlNTlBZy9kL044NndlY3NhV0hm?= =?utf-8?B?ZXZ1RGczd0dNc2lxcHpicGVaOXhHbmozOFVJR2FwSFQwSS9PR3VLTXp5VmQy?= =?utf-8?B?eWIxWU16eHNka01ndVZxck1QbXZOSjNiaDFGK3BNTUtPRTdmRWVjZHY4Nk1V?= =?utf-8?B?MlpncWE2OXdOSVlYMzlHUk1WZ0hROURtUmlvR0pTbEF1YVV1dW90RktVazRy?= =?utf-8?B?Z1Avd2RUT29LazVQOWNSeTV3c01HRTdPc0wzQTdZdk13R2w0ZHJONzg4eWlt?= =?utf-8?B?K3R1SDBaemNPU1pIN1lSaHJ5a2VwVXR3ZVJQWnBCcWdYcmF6bEZiOHBRdzdu?= =?utf-8?B?UXUrcnhDNXMyQ1FyY0wzZ2d4OUZLT1dVSEhLWXg1MzVkaTQyc1hrajEyVmlI?= =?utf-8?B?TVExLzJFSk1DaEg3b2NXMkxDSkhRKzBJS1N2ZDJMYkVKRnI1cHhubFF6NUJL?= =?utf-8?B?OHowbzJ2T1pBd2pKdWwrelJyQmdtY041WXIxTHVLZUhGQk9GL0FTdk1RNHBJ?= =?utf-8?B?T29VK3lENE90RzVySm5ST1Z1SWZ4eEc3dnp6L2oweG5WSWlKL1l5M3NmTEx4?= =?utf-8?B?Z3h1MXl6VzIyNDhoZXBXVEIvaW94UWE4aFlnY2JyOUtMWDUxc2R5aGpuUUg4?= =?utf-8?B?R29CQXJUUGE4cjhRSGVXUk8zVFVmWU5zZk1lVnh6M3F0Y0o5L0VqeVFma2Fq?= =?utf-8?B?ZGkvSHZMVFRyOGNEQ3EzeC9vdkVCMDVIbk9WYkpIbVFyQlo4TUxxalZwaDNF?= =?utf-8?B?YjNySFdlVm14Qm5CWVFhR0JvZ2JnUHdVdnIzbU9JWFRXSEg4OEFid0lXdW1k?= =?utf-8?B?RmE0QjlrdnpBMGFyczVLTGlqaFFBUDhpb3FqYlMxVWhWOStpWEJza25QODA5?= =?utf-8?B?bXYwN0JDUXJsVkRGY1JWZVg2cUo5Q01ZeS9lUE11S3RtSjZ3MnkwelpZdzFG?= =?utf-8?B?M1o4QXpxRU9ldzBTY3NtL3FnT3dkenY4WVkrSS9nRHZNeU5hZDRndHZFM09O?= =?utf-8?B?OHVZcEx2Ny9DeGNaOUc0MDc2WG1yN0QvdlRrZ0hSTTg1a0o3QXZ1UVpYNnJU?= =?utf-8?B?bm9KMGN1azdvYnhLMkZVMkx0VDRpTkt4cU13UzdrY0I4SzlwYTRqL3dhOStZ?= =?utf-8?B?RUVORXB2eGRvcFRGM2tYWVMvbGxSdlU2Tk1EWmdIVGdKck1kc2NmUnVySjQ0?= =?utf-8?B?eG9PM2ZFallwTXZzckFNakhlZVlpQ2JDZHFnWGFxakZoY2FLaWlkWXVKOE9T?= =?utf-8?B?Y3c9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <9A63B007D543C9449974BDBC2C78F189@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?UjJ6M3hFTVZBTndkQ0E4RVVUeEF2NGJ0dW5DYitaVDJESFNmZEtSR0xqNW9a?= =?utf-8?B?K3RoYlE1Rk43M1Nud21pa0lNckNoRG83NnpKcU5PbnRsa0wxQ3NkYzRxQXRw?= =?utf-8?B?UHYyL0RXdUtWbHdEVjFGMjdlMEd3MnhFK2pVOFVqU3FXaHR3RXI5dkRibVNX?= =?utf-8?B?Q1JWeEJHMWRZWkQ1dUlXWkZhL1BhTGpNakxjQnpkeFBwYzdUK09PeXRWd0Fp?= =?utf-8?B?V0pKSFVvQSszb0lmMmR1M0VkZlhHYkR1K2xvTTlWUFVtbDlwbW1pM1hoeERR?= =?utf-8?B?WnNwd05jb3gwZ0ZMNExKYlVqOE9UbXR0YU5nbkRuYmJmSWJPWEl3LzNyKzdu?= =?utf-8?B?SEloNUc5M0QyMXliK3VwOFFXNXdxeG5PWHNoNlNKQW1ZaHJxQTE1aHZScENa?= =?utf-8?B?aHpXRERGNDNhQmpOdXY4Y3Z2bGFubjZOa0k3UG1laDJER2o5UUIyRjU1LzVL?= =?utf-8?B?TlZwTGtMbU1jZG83dUlHcGNRdkZJdTFQc1VocHFHK3dsb3YzbHdwditQUUEx?= =?utf-8?B?MkIrSjlZVXlOZTBWTHNuaEFpc0p4aHpFNDM2SlhKYnlJM2ZRSXdTQXZ1d1hj?= =?utf-8?B?U2c4RFlaT0NaNnRvcStaUlI3VzhGV1Z3aFNKaDF4bjJOS2VidDdCL2NuL0dS?= =?utf-8?B?M09sVXBIZGhxb0tnbXVPcmQ0WnI1alU3Q2VuTE9QV2dHdFFjK1JmekRKSHRS?= =?utf-8?B?NFFTMnBWdkZaZTd0OER0a0pNeWNFSkZwZjJzbkNtdjBwMGx0RVd2UUVDczB4?= =?utf-8?B?ME9WU1ZTL2xsRXVsOG5ubzZ4QTNVUEc4TWQxZzRlVTBSUVNuaHdLYjdtVnBH?= =?utf-8?B?N3hVZW9IS0VpY2Z3YXlYU3Ava09kYkFLQmNDTFpDY0M3eGRrMHJwb05zaENa?= =?utf-8?B?eUhlWThpdkY0MitvTTNNdHRmVVVYYTVpR0dxOEJteG1kOStGako4R0MrSXNU?= =?utf-8?B?UnFOamg4RmU3a3MveWVCcUxuMkNVTE52dGJxaFdkRVdLbUlOWnBtN0Uza1Ez?= =?utf-8?B?VGpWbm1VZUVUU1lnUzJPT0hpbGcyTngwb0NDbkh5TGtuM2hNTkxqZ2YycXhN?= =?utf-8?B?ZGYwWUkvK2pCUjg4ano0WTV4WDFqNmIyNm1UeTZ6ZURTZGJFZWlKbEJNMWdR?= =?utf-8?B?SkE2ck9JVnFBemI1WlNHWXd5YU1pQ1dwV3VTRjM4RWJvVTYvOTJUY0xBUmlO?= =?utf-8?B?ditIRitFWHlCU0lSN2N0ajhVNkU1c1RpZXRYNVh4aXVTVUxheEZBbXNvVjdW?= =?utf-8?B?WWxtc0hNUDk4QmRrOUE1QVNkelp6S01MV2wxSS9OcmNLYjVnQT09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 610409af-518d-4e13-d89c-08daee935517 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jan 2023 20:36:18.1107 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3+0sQmjB106lp5RS6lXiQLA8d8iKldcQQUaduiYzrXBAdKZBbz33wY0KCin6yt6vx/AIHSWBUHiKH3wJxZLPYMhchSgwB9QhaodfiSEYx8U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR03MB5449 T24gMzAvMTIvMjAyMiAxOjAxIHBtLCBPbGVrc2lpIEt1cm9jaGtvIHdyb3RlOg0KPiBUaGUgcGF0 Y2ggcHJvdmlkZXMgYSBtaW5pbWFsIGFtb3VudCBvZiBjaGFuZ2VzIHRvIHN0YXJ0DQo+IGJ1aWxk IGFuZCBydW4gbWluaW1hbCBYZW4gYmluYXJ5IGF0IEdpdExhYiBDSSZDRCB0aGF0IHdpbGwNCj4g YWxsb3cgY29udGludW91cyBjaGVja2luZyBvZiB0aGUgYnVpbGQgc3RhdHVzIG9mIFJJU0MtViBY ZW4uDQo+DQo+IEV4Y2VwdCBpbnRyb2R1Y3Rpb24gb2YgbmV3IGZpbGVzIHRoZSBmb2xsb3dpbmcg Y2hhbmdlcyB3ZXJlIGRvbmU6DQo+ICogUmVkZWZpbml0aW9uIG9mIEFMSUdOIGRlZmluZSBmcm9t ICcuYWxnaW4gMicgdG8gJy5hbGlnbiA0JyBhcw0KDQoiYWxpZ24iDQoNCj4gICBSSVNDLVYgaW1w bGVtZW50YXRpb25zIChleGNlcHQgZm9yIHdpdGggQyBleHRlbnNpb24pIGVuZm9yY2UgMzItYml0 DQoNCldoaWxlIHRoZSBDIGV4dGVuc2lvbiBtaWdodCBtZWFuIHRoaW5ncyB0byBSSVNDLVYgZXhw ZXJ0cywgaXQgaXMgYmV0dGVyDQp0byBzYXkgdGhlICJjb21wcmVzc2lvbiIgZXh0ZW5zaW9uIGhl cmUgc28gaXQncyBjbGVhciB0byBub24tUklTQy1WDQpleHBlcnRzIHJlYWRpbmcgdGhlIGNvbW1p dCBtZXNzYWdlIHRvby4NCg0KQnV0LCBkbyB3ZSBhY3R1YWxseSBjYXJlIGFib3V0IEM/DQoNCkVO VFJZKCkgbmVlZHMgdG8gYmUgNCBieXRlIGFsaWduZWQgYmVjYXVzZSBvbmUgb2YgdGhlIGZldyB0 aGluZ3MgaXQgaXMNCmdvaW5nIHRvIGJlIHVzZWQgZm9yIGlzIHttLHN9dHZlYyB3aGljaCByZXF1 aXJlcyA0LWJ5dGUgYWxpZ25tZW50IGV2ZW4NCndpdGggYW4gSUFMSUdOIG9mIDIuDQoNCg0KSSdk IGRyb3AgYWxsIHRhbGsgYWJvdXQgQyBhbmQganVzdCBzYXkgdGhhdCAyIHdhcyBhbiBpbmNvcnJl Y3QgY2hvaWNlDQpwcmV2aW91c2x5Lg0KDQo+ICAgaW5zdHJ1Y3Rpb24gYWRkcmVzcyBhbGlnbm1l bnQuICBXaXRoIEMgZXh0ZW5zaW9uLCAxNi1iaXQgYW5kIDMyLWJpdA0KPiAgIGFyZSBib3RoIGFs bG93ZWQuDQo+ICogQUxMX09CSi15IGFuZCBBTExfTElCUy15IHdlcmUgdGVtcG9yYXJ5IG92ZXJ3 cml0dGVkIHRvIHByb2R1Y2UNCj4gICBhIG1pbmltYWwgaHlwZXJ2aXNvciBpbWFnZSBvdGhlcndp c2UgaXQgd2lsbCBiZSByZXF1aXJlZCB0byBwdXNoDQo+ICAgaHVnZSBhbW91bnQgb2YgaGVhZGVy cyBhbmQgc3R1YnMgZm9yIGNvbW1vbiwgZHJpdmVycywgbGlicyBldGMgd2hpY2gNCj4gICBhcmVu J3QgbmVjZXNzYXJ5IGZvciBub3cuDQo+ICogU2VjdGlvbiBjaGFuZ2VkIGZyb20gLnRleHQgdG8g LnRleHQuaGVhZGVyIGZvciBzdGFydCBmdW5jdGlvbg0KPiAgIHRvIG1ha2UgaXQgdGhlIGZpcnN0 IG9uZSBleGVjdXRlZC4NCj4gKiBSZXdvcmsgcmlzY3Y2NC9NYWtlZmlsZSBsb2dpYyB0byByZWJh c2Ugb3ZlciBjaGFuZ2VzIHNpbmNlIHRoZSBmaXJzdA0KPiAgIFJJU0MtViBjb21taXQuDQo+DQo+ IFJJU0MtViBYZW4gY2FuIGJlIGJ1aWx0IGJ5IHRoZSBmb2xsb3dpbmcgaW5zdHJ1Y3Rpb25zOg0K PiAgICQgQ09OVEFJTkVSPXJpc2N2NjQgLi9hdXRvbWF0aW9uL3NjcmlwdHMvY29udGFpbmVyaXpl IFwNCj4gICAgICAgIG1ha2UgWEVOX1RBUkdFVF9BUkNIPXJpc2N2NjQgdGlueTY0X2RlZmNvbmZp Zw0KDQpUaGlzIG5lZWRzIGEgYC1DIHhlbmAgaW4gdGhpcyBydW5lLg0KDQo+IGRpZmYgLS1naXQg YS94ZW4vYXJjaC9yaXNjdi9NYWtlZmlsZSBiL3hlbi9hcmNoL3Jpc2N2L01ha2VmaWxlDQo+IGlu ZGV4IDk0MmU0ZmZiYzEuLjc0Mzg2YmViODUgMTAwNjQ0DQo+IC0tLSBhL3hlbi9hcmNoL3Jpc2N2 L01ha2VmaWxlDQo+ICsrKyBiL3hlbi9hcmNoL3Jpc2N2L01ha2VmaWxlDQo+IEBAIC0xLDIgKzEs MTggQEANCj4gK29iai0kKENPTkZJR19SSVNDVl82NCkgKz0gcmlzY3Y2NC8NCj4gKw0KPiArJChU QVJHRVQpOiAkKFRBUkdFVCktc3ltcw0KPiArCSQoT0JKQ09QWSkgLU8gYmluYXJ5IC1TICQ8ICRA DQo+ICsNCj4gKyQoVEFSR0VUKS1zeW1zOiAkKG9ianRyZWUpL3ByZWxpbmsubyAkKG9iaikveGVu Lmxkcw0KPiArCSQoTEQpICQoWEVOX0xERkxBR1MpIC1UICQob2JqKS94ZW4ubGRzIC1OICQ8ICQo YnVpbGRfaWRfbGlua2VyKSAtbyAkQA0KPiArCSQoTk0pIC1wYSAtLWZvcm1hdD1zeXN2ICQoQEQp LyQoQEYpIFwNCj4gKwkJfCAkKG9ianRyZWUpL3Rvb2xzL3N5bWJvbHMgLS1hbGwtc3ltYm9scyAt LXhlbnN5bXMgLS1zeXN2IC0tc29ydCBcDQo+ICsJCT4kKEBEKS8kKEBGKS5tYXANCj4gKw0KPiAr JChvYmopL3hlbi5sZHM6ICQoc3JjKS94ZW4ubGRzLlMgRk9SQ0UNCj4gKwkkKGNhbGwgaWZfY2hh bmdlZF9kZXAsY3BwX2xkc19TKQ0KPiArDQo+ICtjbGVhbi1maWxlcyA6PSAkKG9ianRyZWUpLy54 ZW4tc3ltcy5bMC05XSoNCg0KV2UgZG9uJ3QgbmVlZCBjbGVhbi1maWxlcyBub3cgdGhhdCB0aGUg bWFpbiBsaW5rIGhhcyBiZWVuIHNpbXBsaWZpZWQuDQoNCj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNo L3Jpc2N2L2luY2x1ZGUvYXNtL2NvbmZpZy5oIGIveGVuL2FyY2gvcmlzY3YvaW5jbHVkZS9hc20v Y29uZmlnLmgNCj4gaW5kZXggZTJhZTIxZGU2MS4uZTEwZTEzYmE1MyAxMDA2NDQNCj4gLS0tIGEv eGVuL2FyY2gvcmlzY3YvaW5jbHVkZS9hc20vY29uZmlnLmgNCj4gKysrIGIveGVuL2FyY2gvcmlz Y3YvaW5jbHVkZS9hc20vY29uZmlnLmgNCj4gQEAgLTM2LDYgKzM5LDEwIEBADQo+ICAgIG5hbWU6 DQo+ICAjZW5kaWYNCj4gIA0KPiArI2RlZmluZSBYRU5fVklSVF9TVEFSVCAgX0FUKFVMLDB4MDAy MDAwMDApDQoNClNwYWNlIGFmdGVyIHRoZSBjb21tYS4NCg0KT3RoZXJ3aXNlLCBMR1RNLg0KDQp+ QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Wed Jan 04 20:39:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 20:39:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471476.731330 (Exim 4.92) (envelope-from ) id 1pDAXr-0001g1-Su; Wed, 04 Jan 2023 20:39:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471476.731330; Wed, 04 Jan 2023 20:39:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDAXr-0001fu-Q5; Wed, 04 Jan 2023 20:39:31 +0000 Received: by outflank-mailman (input) for mailman id 471476; Wed, 04 Jan 2023 20:39:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDAXq-0001fk-Ec for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 20:39:30 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e192caec-8c6f-11ed-91b6-6bf2151ebd3b; Wed, 04 Jan 2023 21:39:28 +0100 (CET) Received: from mail-mw2nam12lp2044.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.44]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Jan 2023 15:39:17 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SJ0PR03MB5536.namprd03.prod.outlook.com (2603:10b6:a03:28a::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Wed, 4 Jan 2023 20:39:15 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5944.019; Wed, 4 Jan 2023 20:39:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e192caec-8c6f-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1672864768; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=sc0XT9Feq1UxpfZT/2AWJeldbgWn4KYN/O8SA/SfGkY=; b=PVZX2Jjkq66m/fMYx+Urm98UWfhkdtQnAYxtrC/w5udQkG7/y4Xl7ULt OUdRd8ZIJOIh+S/XakR7J9SXjFNMQcZxfd3PAFTRppCbCeL2xPFztuhk3 Yf0JWyFr2SBXJ0skEO1LykpXGOy3cwz8Bqj3wziYcXqTKTIwoL4TW5SDf o=; X-IronPort-RemoteIP: 104.47.66.44 X-IronPort-MID: 90692786 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:OgHOX6CnV+2UARVW/9Piw5YqxClBgxIJ4kV8jS/XYbTApDwr1T1Ry mFOXj2HO66PZmf0LdFybIrkp0xV7JSDz95hQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nNHuCnYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtcpvlDs15K6p4GpA4gRjDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIwvdcvH1oQ2 tgiKCEraQ6hjO+Wmu6SVbw57igjBJGD0II3nFhFlGucKMl8BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTL++xrvwA/zyQouFTpGPPTdsaHWoN+mUGAq 3id12/4HgsbJJqUzj/tHneE17eRzHmkCNx6+LuQ+dlvunjD42MqBwAZD0CHv7qdr2icVIcKQ 6AT0m90xUQoz2SsStT+RBy55n2ZpBkXW9lXO+I/4QCJjKHT5m6xFmUCCzJMdtEinMs3XiAxk E+EmcvzAj5iu6HTTmiSnp+fpCm+PiU9JmYYaSgJCwAC5rHLqYUylQ7GT8wlHrS8iNb0Ahnvz zvMpy87750IltIC3ai/+VHBghqvq4LPQwpz4R/YNkqq7wp/YJOubqSy6Ebc9vdGJ8CSSVzpg ZQfs82X7eRLCI7XkiWIGb8JBOvxu6rDNyDAi1lyGZVn7y6q53OoYYFX5nd5OVttNcEHPzTuZ Sc/pD9s2XOaB1PyBYcfXm57I51CIXTIfTg9as3pUw== IronPort-HdrOrdr: A9a23:hkTIm6F8dFtNkd+bpLqE0ceALOsnbusQ8zAXPiFKOGVom6mj/f xG885rsCMc5AxhOk3I3OrwW5VoIkm8yXcW2/h0AV7KZmCP01dAbrsD0WKI+UyGJ8SRzJ866U 6iScRD4R/LYGSSQfyU3OBwKbgd/OU= X-IronPort-AV: E=Sophos;i="5.96,301,1665460800"; d="scan'208";a="90692786" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YXAkCERYUBIMESk0mZoQI89fMv4J202QTv2dALiKL51QYA+hn6/nwCtRTktJRgpO1Ajg5A9DQdo+p+YGMA13oZ3o2prr11HrnG0UcKXrugfzb1Py605F+tm67cAYTwYMkvhHqrnuR9TXFwLcXuL/kvIc/EzRCKK4dIxEKcq1gSiwJu9zfRo2Uhtb+hnzX/ew7Autsf4OyzHjOgCWWRKvk9CCZbxI2A2/WEQoWBoQukxhp+idLSvepv+KKKTQCBCWAZumIpDsaUAeASkEnof4BBIjA6kkDrqGxG/sq+s5unVQMvCJTERGkCeIkC3e4ljZyGpZLxnHJSqUhQdS+B9YNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sc0XT9Feq1UxpfZT/2AWJeldbgWn4KYN/O8SA/SfGkY=; b=l6mLlIJOhx2JdRVYYtPymbdOxqvNUwBq3jnh3yCBMmhrMM2BI/GXlz6RUDxmF1TCq8RggrBL1myzsjaAsCGMvkhGX0aTtlzbJPzaw97VhaqjsQjNihpvhUuwVnQyrIe+9riXiprvuzBfLHIA+PKulRsiPxUbJBESNurLjSXtQM5VM9Ws3bZluQPmPW0+RD6Ri3Oa3cRBPUTIQVqtQBXZLHdHDv8pJbEd/xRihDBkFQZOx28Hexk8LadX9uPdXTwJTSlNIew5KsoOTS0BMSn+b+RCmbDkpgjw0WLZP6N4zUgp5+/3b3x5etqDqdPeCb3uO/HluwZuS86TuIWL/FtSpg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sc0XT9Feq1UxpfZT/2AWJeldbgWn4KYN/O8SA/SfGkY=; b=ZilPj/lFOkgGHdcich8NksKQJDe4V+tc4xoELLeAdJieyGTWnb3Mm4SLU6DHT2qUS8D2WEiRkyW6X+ri8ldiFVfRmHXFV5a5X9fiSNAP8wg5cgUTxqNBkcLuML6PXd7s+QeTXQ5RI9/fMFrGujQzlxwR4BHh5GAkWfo/DbaDD3k= From: Andrew Cooper To: Oleksii Kurochko , "xen-devel@lists.xenproject.org" CC: Doug Goldstein , Alistair Francis , Stefano Stabellini , Gianluca Guida Subject: Re: [XEN PATCH v2 2/2] automation: add RISC-V 64 cross-build tests for Xen Thread-Topic: [XEN PATCH v2 2/2] automation: add RISC-V 64 cross-build tests for Xen Thread-Index: AQHZHE7hYcTjVcm+Z06GDSck55kIla6OwJqA Date: Wed, 4 Jan 2023 20:39:15 +0000 Message-ID: References: <855e05a0459d44282679f08c8f67e38d35635eb6.1672401599.git.oleksii.kurochko@gmail.com> In-Reply-To: <855e05a0459d44282679f08c8f67e38d35635eb6.1672401599.git.oleksii.kurochko@gmail.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|SJ0PR03MB5536:EE_ x-ms-office365-filtering-correlation-id: 7ebd50ec-df32-4e86-c65a-08daee93becc x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: B0k6utREynH7vg5J5NtwF9ZkjCfrzG/ENqmMjCwkU24eU1hZZY+UFmksPR+w2TDvdGhvm7mBGWlDEqarD5nZ4jNeZ4etMwSXLc8GU/K53iMJvcHLbEjpm90+LzGB2NfH55bwjcEwVVGr4/zmhZyf8JMw0mdErLaaMxE8vW8mHM85AQXMN1lp2joU5Q93USv2qr9BBeEOZqPQqYFed5A75o5jqGuBynvzijkZ2DMzQq8o4GyxGrT2Eui2k1kkAoS8M6HdD3BSe0AfyMiBfUESG+laYarlltDEu/oeY/akn824h5l0FtN22KtNgEghyMiRhkf93JiLDsfbX2/YPcSmoWDj9jqKHTz1HtVfLKMks8YwcNIRqNROaQzXo/upAIhlorCDykqV9BVJOuZQ8uqPyfURNV06/6Pi7Dq+1Hl2yBjf+bieErQ0RMN6D0/F93AW4tzyeM9nfI7PppXvLs8We6cgvaTHXNnDSlQozxypI9tFi3AsqSUu6xh1OdIW0al8Vj8pnujm2Gfn8+KIAlzJFJU+nJRgQdUbd1eTkKBHLrpZF/v1eLFa0E5w1gBVAHqbY4hrKCcN4SnXbtjYtD/7fqPhN0Ap3WHwNtdpJuUFE5u8CsjHBXe9nRDxWPgo3JByAkOXNYZkQAfC8muidg8vtjutzmrfNflqznDpDJ/R7D6DGsDvZPSfltTT+Sw8+RY70wf07/zA19Pl+yQIvbAcHU3GnhbD+yxYhpOs2EYQJIwztB2knYX5pepNURp46yFlW5qEitx3YPEq47z4AicTIQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(39860400002)(376002)(346002)(136003)(396003)(451199015)(2616005)(82960400001)(6512007)(186003)(26005)(38070700005)(38100700002)(31696002)(86362001)(36756003)(122000001)(2906002)(110136005)(76116006)(5660300002)(66556008)(91956017)(66446008)(8936002)(66476007)(64756008)(66946007)(8676002)(4326008)(316002)(31686004)(54906003)(53546011)(41300700001)(6506007)(478600001)(6486002)(71200400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?K3Y0TlFTM0p6clhTSTRhc1ltVVJrMHFpczFQRVVIdWdtTEI1TG1vS2x3emZE?= =?utf-8?B?bmpReUxJc1Yyd3U5UUNaSnh6dE5rTjI0b1VmTTh4U0hoNlIwdEdVN1M3NWEx?= =?utf-8?B?R3ErcjNoaEZTRGpCVnpaK043Ny8yS1dQSENzN0ltZ25WS1JyYzVpTDVmd3kv?= =?utf-8?B?RTc5N00wb1BvRUUzdUpjbk5nUDhqL0VmQlZ3TGluOCtzdTBCMVhCYzk1REIv?= =?utf-8?B?dHAxMHUvVXVNYldoY2ttMlRTQ3N0Wm5NK0lZYjZSNk5aSzExSDRrK0JYTFZF?= =?utf-8?B?aVdLYlJUelN5YTdybkUzQlhUSmM5Q0JsNFJjVHJoUUFKYjRtTlo0RlNEd1pT?= =?utf-8?B?cUIvZXZCOHhvNllIaS9PRlNzR2hnSFV1aGsydUVyeE5Nb09kMUVITHVHSGhj?= =?utf-8?B?Y0R0RGI0OGhqcHdpOERvUmZWTHBzSWtvbW9lMkxVQTJmNDJUUjBWc2ljNWFO?= =?utf-8?B?MkJjOE9uTDRhM3lHL3UvUEdiOFcxbGRndWRmalg5WXpab0lYdUYwVHJsanBZ?= =?utf-8?B?Q0NzMmxvUGFEREdvcVNQaC82UHpHRVpTS0Z4N0RYTXVKL1BFOW1TWDRpcGM5?= =?utf-8?B?TXBlaFdxa2JCMUVrTjdJbFVlTS8weWgyY3YxYjBNZ25XekFxZzdmZjRjVkZx?= =?utf-8?B?cmE4dm9lOVdtbHh1RkRIcFM5QWZrUlk5K3MycFdDUjgvNjJSQWE0d0x1U1Bi?= =?utf-8?B?U2RTZkJaMVp6WExFQ1lycHR6dmNucTFHamNkdFhSLzZPWklDQ1NnZHozZkds?= =?utf-8?B?ZnVmUTJHY2NjelQ5WXY0LzEwT0htT29aandjYVYzOS9hWGdINUlsTjdiWjNQ?= =?utf-8?B?elp5SUN0bWQ4M2xLUUZteTl1dDBsV0NPT0xPam1KamFlaWtKVzd4Q0o1SUNq?= =?utf-8?B?c0ZEa3RRYmlZME9hS1hCdzFnWjdyRDFHVkVvUHRwNGFYUWwyZEV0VktTTTV5?= =?utf-8?B?OUxENEFRZ1hwSVJFK3Q5bG9RV1JhVkpXZ3BvSFB1QWlXYk9scThPWnVzeFVZ?= =?utf-8?B?VkNPZkkrNzk2cEpTWDNHdGc5czdnY05WTC9XSVErbVEzRm1RMXZFalY1RFdj?= =?utf-8?B?Y1JuZFFCbjJRTEVxaVhPZzBaeGFLZnp0bTErYU1Hay9ja2VDMFJIRXJPMTZB?= =?utf-8?B?OERTVGlWZVlVcjU3aGY3WlJrZmRISEhvcUR0MVk0Q2p3U05SbU04eEtxRmpP?= =?utf-8?B?Vjk3alJwaFBoMTNja3FsM1NIeE5TUm93WFdGMlRwTGVFUjI3V04wcHI4REdU?= =?utf-8?B?OGNXczRaR1hRSDNFNUo3MHFwUjk3STBxWlRHWUo5WXBvbjEzNjJLR0pqV1hq?= =?utf-8?B?ek5ha0UvVHk0dEtqRmhDRmh6YVQ5WStYTlptNDdEVXl2S205R1E3VFdweHVa?= =?utf-8?B?Y0JyVEZWejBpdlF4cE1oVUxVcS9ma3g0cmNFM0hoakVoQUhUdXZaYXlmTzVT?= =?utf-8?B?S2pMTXB4S1lVSEIvczdKRGNJd2NEcXBKelRGUnZPZ1NxOHMwVGFZRGtTSXdv?= =?utf-8?B?cjZ2SGpROENqMzB6WW9hRmdvcGJnMXVHZ2FsTWsyS1ovRGFPMnIxSVZ1OVA2?= =?utf-8?B?N2xpR1JjYTV0UTZyR2JaNUk3U253UUd6eFJSSlNYNm1sRFNic25VdjdQckE5?= =?utf-8?B?c2FWSlE5a2d4dXVVNFhuMUs3NlRqTHBzcVpJT3ZRUFYxTkx5NWVqMWZCM1JJ?= =?utf-8?B?NWV5NGZSVFZTMlNwaHZTR3JRbGwxT0VpM3M0WlRlNmNVc1U5MU5mcHEzYU5z?= =?utf-8?B?aEthUlJncVptTVE0eWRhSmNDY1oyb3FHMkVrdG5ITFNUVGVlbUdpS29URkh0?= =?utf-8?B?Q3N0U0NieTdub1RCTmMvM1M0d2ZXalA0OHN5WFFQbUhrTUJwb3BpRGhpSlVI?= =?utf-8?B?UVZGL3ZJZU5DWEMxTk5lKzQzUEN0eVZWMWx0VTFhaGlXNmFRamExYS91aFlN?= =?utf-8?B?a3lVUyt4cDJVRjRjS0RJTFRncThKclRaR2lDRU5VRE5zN1FXS3g1S1p6ZmJP?= =?utf-8?B?MW15SHBPRXZTQmZkdC9kMVovUjF0cUVYK1NtcTVmWVlpUWtnbWNIcGF4UmhQ?= =?utf-8?B?ZkJKUjBPWDBzc0VPeFNVREFPUHdrdm54QnVrT3d4WlVCNXA5RDFieDM1Ymt1?= =?utf-8?B?ckVTd09nYUZDb0pNZmQzR0pldUR2VkFQOGJxNGI0eVpWVEthY0pSdlhHYmRw?= =?utf-8?B?YlE9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <8398A85E667F5440BD462359DE261F31@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: nT6PAZHd2nYbfTWi2xKEgMW08Z3ryxLXRnoaaXafRecHNaJSp/m+MJB+qSnFmlQMxrpuRcbmEGFoyxiYz5VLvKVEupS4JlbOi3inF9S0UOgYzlmDXP28vRaKqz+Q55zyjXu6g/Jeq5DopthB30hI8ADZa5f1YXIY84JaxWBH93cb2P2fP0H57VWqjl3iyvamu/Q71p2z+4v9YZ5JJewp6do335MFNlamRolsZEm+2Osv2Qd6aChKd07UZuWUG0+6+gZ6AccwaslIZFxQ1UKhWFoTQyBiTDh+7Zv0mjKXtbjneoXV6iPWPn8vSr1d7w4gLKILEpq045RrqxL9ypSbskP+TH0Ska5cPSNf597xRyUh4FxnT+nwDo3uQIGlRxdiAU+0tCn2+o17lmdzIrN8G3SM0qkbhVs0IKX+jLh68ywJQo6e3n43sBRRhHwplTlebmf+CHc5ZS0zW/q087edpjoSzp8vQCyxASysBrS+087i0ujBTJlsE1kZilx4gpBNqT5FxZj87yT9eqPlls4H1vDYfbD9gdFs2JR/tRj6Z5ZcGvnZJlkOZ+5j4Wmkdr6Y5p8idyiP3UmaTNM6gjx7tAKBT5l6m+eKAFWIZD0Kkux2mFt9P5F/eLREewGujlnDudNw5K/UO9fiPc/OddeCAlGEQzXLdgA93CG3Ati6dieh/JJoUiXDjbPmo39lPcpx4EoQh4RnNaaXqpt3oQKV3lyQryPx925XczddbqsCtjb6OKIftyhb/2IzNOMvIzSnm12eBm0Q0i5IoegG7r/PMzXOGSa2SJLXzIA6thGXEgB96EdpjyorPfacx/iInmy55qC+y5m0m6UOpQqAqihjXzn9Sl/rgdpkD34n8js4teL1+4cNU6sH9EtRrovAAShtfqHC883dIIpHQlBDPWLHeeyrda0deMRd69MlewoTLK4= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7ebd50ec-df32-4e86-c65a-08daee93becc X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jan 2023 20:39:15.4884 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: le90nfdN960ELi0TTiLjll5Moe2rvjD+GHCDJHXS4vZFhuNiH2WQ+mFphsk++eE0bBxRGfYOxwNjiUXXZl7WIuj64UjOeJohyyz7iyRVwKg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5536 T24gMzAvMTIvMjAyMiAxOjAxIHBtLCBPbGVrc2lpIEt1cm9jaGtvIHdyb3RlOg0KPiBkaWZmIC0t Z2l0IGEvYXV0b21hdGlvbi9naXRsYWItY2kvYnVpbGQueWFtbCBiL2F1dG9tYXRpb24vZ2l0bGFi LWNpL2J1aWxkLnlhbWwNCj4gaW5kZXggZTZhOTM1N2RlMy4uMTFlYjFjNmI4MiAxMDA2NDQNCj4g LS0tIGEvYXV0b21hdGlvbi9naXRsYWItY2kvYnVpbGQueWFtbA0KPiArKysgYi9hdXRvbWF0aW9u L2dpdGxhYi1jaS9idWlsZC55YW1sDQo+IEBAIC02MTcsNiArNjQ0LDIxIEBAIGFscGluZS0zLjEy LWdjYy1kZWJ1Zy1hcm02NC1ib290LWNwdXBvb2xzOg0KPiAgICAgIEVYVFJBX1hFTl9DT05GSUc6 IHwNCj4gICAgICAgIENPTkZJR19CT09UX1RJTUVfQ1BVUE9PTFM9eQ0KPiAgDQo+ICsjIFJJU0Mt ViA2NCBjcm9zcy1idWlsZA0KPiArcmlzY3Y2NC1jcm9zcy1nY2M6DQo+ICsgIGV4dGVuZHM6IC5n Y2MtcmlzY3Y2NC1jcm9zcy1idWlsZA0KPiArICB2YXJpYWJsZXM6DQo+ICsgICAgQ09OVEFJTkVS OiBhcmNobGludXg6cmlzY3Y2NA0KPiArICAgIEtCVUlMRF9ERUZDT05GSUc6IHRpbnk2NF9kZWZj b25maWcNCj4gKyAgICBIWVBFUlZJU09SX09OTFk6IHkNCj4gKw0KPiArcmlzY3Y2NC1jcm9zcy1n Y2MtZGVidWc6DQo+ICsgIGV4dGVuZHM6IC5nY2MtcmlzY3Y2NC1jcm9zcy1idWlsZC1kZWJ1Zw0K PiArICB2YXJpYWJsZXM6DQo+ICsgICAgQ09OVEFJTkVSOiBhcmNobGludXg6cmlzY3Y2NA0KPiAr ICAgIEtCVUlMRF9ERUZDT05GSUc6IHRpbnk2NF9kZWZjb25maWcNCj4gKyAgICBIWVBFUlZJU09S X09OTFk6IHkNCj4gKw0KDQpKdWRnaW5nIGJ5IHRoZSBLY29uZmlnIHdoaWNoIGdldHMgd3JpdHRl biBvdXQsIEkgc3VnZ2VzdCBpbnNlcnRpbmcgdGhlDQp0d28gUkFORENPTkZJRyBqb2JzIHJpZ2h0 IG5vdy4NCg0KPiAgIyMgVGVzdCBhcnRpZmFjdHMgY29tbW9uDQo+ICANCj4gIC50ZXN0LWpvYnMt YXJ0aWZhY3QtY29tbW9uOg0KPiBAQCAtNjkyLDMgKzczNCw2IEBAIGtlcm5lbC01LjEwLjc0LWV4 cG9ydDoNCj4gICAgICAgIC0gYmluYXJpZXMvYnpJbWFnZQ0KPiAgICB0YWdzOg0KPiAgICAgIC0g eDg2XzY0DQo+ICsNCj4gKyMgIyBSSVNDLVYgNjQgdGVzdCBhcnRpZmljYXRzDQo+ICsjICMgVE9E TzogYWRkIFJJU0MtViA2NCB0ZXN0IGFydGl0aWZhY3RzDQoNCkRyb3AgdGhpcyBodW5rLsKgIEFs bCB5b3UncmUgZ29pbmcgdG8gYmUgZG9pbmcgaXMgZGVsZXRpbmcgaXQgaW4gdGhlIG5leHQNCnNl cmllcy4uLg0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Wed Jan 04 20:44:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 20:44:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471484.731341 (Exim 4.92) (envelope-from ) id 1pDAd3-00035b-FC; Wed, 04 Jan 2023 20:44:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471484.731341; Wed, 04 Jan 2023 20:44:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDAd3-00035U-Cf; Wed, 04 Jan 2023 20:44:53 +0000 Received: by outflank-mailman (input) for mailman id 471484; Wed, 04 Jan 2023 20:44:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDAd1-00035O-M2 for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 20:44:51 +0000 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [2a00:1450:4864:20::529]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a2371365-8c70-11ed-91b6-6bf2151ebd3b; Wed, 04 Jan 2023 21:44:50 +0100 (CET) Received: by mail-ed1-x529.google.com with SMTP id u28so45464790edd.10 for ; Wed, 04 Jan 2023 12:44:50 -0800 (PST) Received: from ?IPv6:::1? (p200300faaf0bb2008108eedf25879029.dip0.t-ipconnect.de. [2003:fa:af0b:b200:8108:eedf:2587:9029]) by smtp.gmail.com with ESMTPSA id i5-20020a05640200c500b00463c5c32c6esm15153884edu.89.2023.01.04.12.44.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Jan 2023 12:44:49 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a2371365-8c70-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=gbV63gD9zn2fwjFvmF2ZygodMpZQcbM7tsdfwBcVKcw=; b=JoTrbyhvGJhx35lyAEl4uafzDehZJtSZL96Yt/G8GZyAM9VW+8CK7S+MgS6Jl360Z2 uedFsPbWc2WBAqkRE5QrwUKI2LMmP9tIxJ+bOHpq6YZQfHu9tuLCcruvkj4euj8HY3k5 cotEGIqV8sKqrfsO8VBrzHh8imH2bd9RoDXYgPe51OCGe3pSM+e6G1zU3N0zrBgpFTug vx8kd6S47Lj9jZ2rsEWEFSn7stp1xHEW9lyOZqgt+XC0OHufB57DzOhvUhNHv03pCM55 EW/P/y2yrem3oCCItMjDKhUO3Hg0OO7PMDXqR7mQZvo3eqKlYvPOQ1YyocbnL18EKJiR K+hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gbV63gD9zn2fwjFvmF2ZygodMpZQcbM7tsdfwBcVKcw=; b=hDspIl/xQ5h8ScskmOwGo/gqLsAM/zsw48LIS+7xlIur54BpjFEhJpBk7T/dNtYK4J 30Y4hHr76LaMdlA70TA5tdWxmT18KFKe0ia7QqqOyU9hJ3NJa7GE5xYCFEjgRkXd++J0 1Y10Sbo6kgduqUsbWbiTWOyw2x5Muj1s/LRRqv+XpjIv4ZxMfYwgE5Yux6IojzNC7FLh LO7eoD0dQfqKiPFt5Hc47J7TdFYZm1NDC7cJt9pzivwh6WtFpDv72IXuKM51SR//8bsc VpbkJI37DQWkFE2cTlg9a+8JGr4NFqL/9DoybyP+Tr/vp1g9C8QldRKeXY4fXti4i0KM TSSA== X-Gm-Message-State: AFqh2kqHCLDWkteorhHeIsNig/rPL0ffNqG96EZF8CKRHQaekSMoyuvB SR+5Dfbx0Aj+zxxFcbhFh+U= X-Google-Smtp-Source: AMrXdXvoh5ORGxbIS7Ab4BCz07HsM9Kyaok5VbIDwUkQO0I/bxoGzMUn3yMRwqi70ndk6P6pYenC4Q== X-Received: by 2002:a05:6402:551b:b0:46a:732e:fd29 with SMTP id fi27-20020a056402551b00b0046a732efd29mr44634692edb.42.1672865090026; Wed, 04 Jan 2023 12:44:50 -0800 (PST) Date: Wed, 04 Jan 2023 20:44:44 +0000 From: Bernhard Beschow To: Chuck Zmudzinski , =?ISO-8859-1?Q?Philippe_Mathieu-Daud=E9?= , qemu-devel@nongnu.org, Markus Armbruster CC: Richard Henderson , Stefano Stabellini , xen-devel@lists.xenproject.org, =?ISO-8859-1?Q?Herv=E9_Poussineau?= , Aurelien Jarno , Paul Durrant , Marcel Apfelbaum , Anthony Perard , "Michael S. Tsirkin" , Paolo Bonzini , Eduardo Habkost , Thomas Huth Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_v2_6/6=5D_hw/isa/piix=3A_Res?= =?US-ASCII?Q?olve_redundant_TYPE=5FPIIX3=5FXEN=5FDEVICE?= In-Reply-To: References: <20230104144437.27479-1-shentey@gmail.com> <20230104144437.27479-7-shentey@gmail.com> <1c2e0780-e5fb-1321-0d84-b0591db9fec7@linaro.org> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Am 4=2E Januar 2023 17:54:16 UTC schrieb Chuck Zmudzinski : >On 1/4/23 10:35=E2=80=AFAM, Philippe Mathieu-Daud=C3=A9 wrote: >> +Markus/Thomas >>=20 >> On 4/1/23 15:44, Bernhard Beschow wrote: >>> During the last patches, TYPE_PIIX3_XEN_DEVICE turned into a clone of >>> TYPE_PIIX3_DEVICE=2E Remove this redundancy=2E >>>=20 >>> Signed-off-by: Bernhard Beschow >>> --- >>> hw/i386/pc_piix=2Ec | 4 +--- >>> hw/isa/piix=2Ec | 20 -------------------- >>> include/hw/southbridge/piix=2Eh | 1 - >>> 3 files changed, 1 insertion(+), 24 deletions(-) >>>=20 >>> diff --git a/hw/i386/pc_piix=2Ec b/hw/i386/pc_piix=2Ec >>> index 5738d9cdca=2E=2E6b8de3d59d 100644 >>> --- a/hw/i386/pc_piix=2Ec >>> +++ b/hw/i386/pc_piix=2Ec >>> @@ -235,8 +235,6 @@ static void pc_init1(MachineState *machine, >>> if (pcmc->pci_enabled) { >>> DeviceState *dev; >>> PCIDevice *pci_dev; >>> - const char *type =3D xen_enabled() ? TYPE_PIIX3_XEN_DEVICE >>> - : TYPE_PIIX3_DEVICE; >>> int i; >>> =20 >>> pci_bus =3D i440fx_init(pci_type, >>> @@ -250,7 +248,7 @@ static void pc_init1(MachineState *machine, >>> : pci_slot_get_pirq); >>> pcms->bus =3D pci_bus; >>> =20 >>> - pci_dev =3D pci_new_multifunction(-1, true, type); >>> + pci_dev =3D pci_new_multifunction(-1, true, TYPE_PIIX3_DEVICE= ); >>> object_property_set_bool(OBJECT(pci_dev), "has-usb", >>> machine_usb(machine), &error_abort)= ; >>> object_property_set_bool(OBJECT(pci_dev), "has-acpi", >>> diff --git a/hw/isa/piix=2Ec b/hw/isa/piix=2Ec >>> index 98e9b12661=2E=2Ee4587352c9 100644 >>> --- a/hw/isa/piix=2Ec >>> +++ b/hw/isa/piix=2Ec >>> @@ -33,7 +33,6 @@ >>> #include "hw/qdev-properties=2Eh" >>> #include "hw/ide/piix=2Eh" >>> #include "hw/isa/isa=2Eh" >>> -#include "hw/xen/xen=2Eh" >>> #include "sysemu/runstate=2Eh" >>> #include "migration/vmstate=2Eh" >>> #include "hw/acpi/acpi_aml_interface=2Eh" >>> @@ -465,24 +464,6 @@ static const TypeInfo piix3_info =3D { >>> =2Eclass_init =3D piix3_class_init, >>> }; >>> =20 >>> -static void piix3_xen_class_init(ObjectClass *klass, void *data) >>> -{ >>> - DeviceClass *dc =3D DEVICE_CLASS(klass); >>> - PCIDeviceClass *k =3D PCI_DEVICE_CLASS(klass); >>> - >>> - k->realize =3D piix3_realize; >>> - /* 82371SB PIIX3 PCI-to-ISA bridge (Step A1) */ >>> - k->device_id =3D PCI_DEVICE_ID_INTEL_82371SB_0; >>> - dc->vmsd =3D &vmstate_piix3; >>=20 >> IIUC, since this device is user-creatable, we can't simply remove it >> without going thru the deprecation process=2E Alternatively we could >> add a type alias: >>=20 >> -- >8 -- >> diff --git a/softmmu/qdev-monitor=2Ec b/softmmu/qdev-monitor=2Ec >> index 4b0ef65780=2E=2Ed94f7ea369 100644 >> --- a/softmmu/qdev-monitor=2Ec >> +++ b/softmmu/qdev-monitor=2Ec >> @@ -64,6 +64,7 @@ typedef struct QDevAlias >> QEMU_ARCH_LOONGARCH) >> #define QEMU_ARCH_VIRTIO_CCW (QEMU_ARCH_S390X) >> #define QEMU_ARCH_VIRTIO_MMIO (QEMU_ARCH_M68K) >> +#define QEMU_ARCH_XEN (QEMU_ARCH_ARM | QEMU_ARCH_I386) >>=20 >> /* Please keep this table sorted by typename=2E */ >> static const QDevAlias qdev_alias_table[] =3D { >> @@ -111,6 +112,7 @@ static const QDevAlias qdev_alias_table[] =3D { >> { "virtio-tablet-device", "virtio-tablet", QEMU_ARCH_VIRTIO_MMIO = }, >> { "virtio-tablet-ccw", "virtio-tablet", QEMU_ARCH_VIRTIO_CCW }, >> { "virtio-tablet-pci", "virtio-tablet", QEMU_ARCH_VIRTIO_PCI }, >> + { "PIIX3", "PIIX3-xen", QEMU_ARCH_XEN }, > >Hi Bernhard, > >Can you comment if this should be: > >+ { "PIIX", "PIIX3-xen", QEMU_ARCH_XEN }, > >instead? IIUC, the patch series also removed PIIX3 and PIIX4 and >replaced them with PIIX=2E Or am I not understanding correctly? PIIX3 is correct=2E The PIIX consolidation is just about sharing code betw= een the PIIX3 and PIIX4 south bridges and should not cause any user or gues= t observable differences=2E Best regards, Bernhard > >Best regards, > >Chuck > > >> { } >> }; >> --- >>=20 >> But I'm not sure due to this comment from commit ee46d8a503 >> (2011-12-22 15:24:20 -0600): >>=20 >> 47) /* >> 48) * Aliases were a bad idea from the start=2E Let's keep them >> 49) * from spreading further=2E >> 50) */ >>=20 >> Maybe using qdev_alias_table[] during device deprecation is >> acceptable? >>=20 >>> -} >>> - >>> -static const TypeInfo piix3_xen_info =3D { >>> - =2Ename =3D TYPE_PIIX3_XEN_DEVICE, >>> - =2Eparent =3D TYPE_PIIX_PCI_DEVICE, >>> - =2Einstance_init =3D piix3_init, >>> - =2Eclass_init =3D piix3_xen_class_init, >>> -}; >>> - >>> static void piix4_realize(PCIDevice *dev, Error **errp) >>> { >>> ERRP_GUARD(); >>> @@ -534,7 +515,6 @@ static void piix3_register_types(void) >>> { >>> type_register_static(&piix_pci_type_info); >>> type_register_static(&piix3_info); >>> - type_register_static(&piix3_xen_info); >>> type_register_static(&piix4_info); >>> } >>> =20 >>> diff --git a/include/hw/southbridge/piix=2Eh b/include/hw/southbridge/= piix=2Eh >>> index 65ad8569da=2E=2Eb1fc94a742 100644 >>> --- a/include/hw/southbridge/piix=2Eh >>> +++ b/include/hw/southbridge/piix=2Eh >>> @@ -77,7 +77,6 @@ struct PIIXState { >>> OBJECT_DECLARE_SIMPLE_TYPE(PIIXState, PIIX_PCI_DEVICE) >>> =20 >>> #define TYPE_PIIX3_DEVICE "PIIX3" >>> -#define TYPE_PIIX3_XEN_DEVICE "PIIX3-xen" >>> #define TYPE_PIIX4_PCI_DEVICE "piix4-isa" >>> =20 >>> #endif >>=20 > From xen-devel-bounces@lists.xenproject.org Wed Jan 04 20:47:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 20:47:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471492.731353 (Exim 4.92) (envelope-from ) id 1pDAfo-0003i7-VK; Wed, 04 Jan 2023 20:47:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471492.731353; Wed, 04 Jan 2023 20:47:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDAfo-0003i0-Qx; Wed, 04 Jan 2023 20:47:44 +0000 Received: by outflank-mailman (input) for mailman id 471492; Wed, 04 Jan 2023 20:47:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDAfn-0003h6-5o for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 20:47:43 +0000 Received: from sonic313-20.consmr.mail.gq1.yahoo.com (sonic313-20.consmr.mail.gq1.yahoo.com [98.137.65.83]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 067ed089-8c71-11ed-b8d0-410ff93cb8f0; Wed, 04 Jan 2023 21:47:39 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.gq1.yahoo.com with HTTP; Wed, 4 Jan 2023 20:47:38 +0000 Received: by hermes--production-ne1-7b69748c4d-dzr9v (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 6c878df3bbaf9935a45a9609953ac48f; Wed, 04 Jan 2023 20:47:36 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 067ed089-8c71-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1672865258; bh=FLlL0Znq3MYflQbaAlbZMfah9YnKAAkzhkPNyAmAnYo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=KDH9WaiS1KXgbWghoV4HnCmF93QGXWTOT5fr1SC5F1PRK63KybA8DKCIatPU9lvgXB5fECISUamfzaznjzPoaSGwk32CH9Q/sXq6QZ4u/p178Hb+TheLkuH3y5Eh4ZeYLoIf7tY3WwgnuFZGIOGbekxrCde8M8AthD6yIVcq+Y0R20CIq+GqjvpTKwCcAiQmWNMfdun+ns2bStujuVdYes/p0gZCjudYwfyuZcdDLwELdcw/ldP3zApkHjVf/DI+y3NmWlz0pW9Fq4Bj2EX+3l68vpnXeBzxrGVebntQV7t6iYrK86tHd8hJXEEpYiOY3wnGPRIy3MSwVk3pGQRrWw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1672865258; bh=rd+9VNkpX9KRPfP3h2G2X5n3Ypj1rGC/lgX+KO7N4xX=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=QZn8SdyWbKB5DsSdTquVTHtaQCBvr5bbql460GmW0MIv5m6dYeh2QlegS5yQaVnQhBFgWLUXG4IIpJlOpGcFDCZOADIdMyyLBPBtUIkMm+3jBsVKv5ovu2XdUexK+lwflNbL4mmM9edHZrI9L8Ulno61Xh3M2W5eDK01DYow8oeDfABCAIZ4ohH3Ly8V4jKFh/eLdyvrvgSmxHkqt+1uEEVMPoXKgvOKnP75/cDQ6gIDh/jDhY5XRwv801OtWgXbVTBdfkLduWJnLvPLjC+WvpVrGwh8I3zZ8DR8vfVd6zM41FMEA7x0E8o6VBU0bfvjLKfYIURrg8Fs0Yz+QBC1xw== X-YMail-OSG: LU2heVoVM1mhE8eq57Zy8wqFpUouWpl3R3PBRRyFH2OhAFZxA_bJWQsbDI8Zd.d YG6.etuKO9F4mTUG1tyW5WzJb7591qppMYk.kN5cpy.8CHNUaT4dSWvWrVRXOFNmbO7nXYM_3oP3 ObfBvM9TiX5GwJrRg89JHTyI6HlI4UqJjjJms1XYn9st39csae5XUTi2KGfcCtInq6no_FH13vRs Q0juuEt9sGQnTib1QOg4mYWP1T9JCP97ytEvj8o16ugbFi37jKc42xYuvsEJFuNBC.tXOES7HFDk 7TXfcwttj2D3HVla6Npx2tmTvFmmgwjIS4zB5eGStweda0bi5vnmIRJZQ2tJTb7yqzkIp2GJvi07 but27yb3x4mF.zb5XnKh8QiaJilk4b0xQOlzFKGIaBCnCpLe1EFWiK2MD4gYveC1MzzM1Xuws1d2 U1H.atPcAwcFE8hjPHYgeX3H4coQpmL1qoAagYreLbXYEzllSwGFHSh37Ukcb4ofhl5h5bBgq9hY IU4bXFlkdBamVTF2zxEdAgXz5p9EFB2ck9qoSzYWJYm_daQnuvIAI5VvI80HsUlJq8B3Uq2IxV2c xrU6__HcLnKTjOs4o_LSQQp2yWJL7k4XCjXQpc9v5KQkNv2h.JihzpvtQXSTi0nZh1BDmnHYVW4F AXCE1SM7xZhx2WPRljxLumhKidHoYXz.puvV4BWC0FNfWhnC4sGp8x6Cg9cYMy5TJwemHcuFRbci JGgoVAWH0p31bLaBx5h12Q6qJD1.inYVYqXbOy80HqAyCKAkMmepM8xDPAUxgcPhZL.BJXMVv4sc MN8QXrkF9H0Ge8uOo7sa8RwkiVIfLaIGHUQxmmLwlt6lRKYbLOG4cgtLvkVjRU1WZaf6WWUclgR_ VCE.4iXaCenI37KZkcz6LEOdcxoNzOYnaKuBS4an09m.923cHkgYZH9cETrkecl9rntoySsmvlxR HuVn1AeF5eAB8ccfn5vqiKnVQRXz7IXb4MuioChbyOQkNOVX9_omJKi3zx3P9.WZDLh9GJavIRJ6 Yp36TIwtdMCkNZEekkF0yZf632CkP97JXvWg8tc6_QXRAbwekb8ZlxfMQD1IBQPvhcT89dXSmCfG e2y__WrCIe8MA5wNvFBrElyLswyO6CYx7QOeC0kWSwMgOIvD_duV7tFxVJNcwXwwB6jqKRBu_mkU ptrAxrGpXv5_FkjtnpaE5MicyVhzNx7e1YBiOEbiVv8DcIbhM.Re4oeK0vD2lBL.M7vzD_vi1jxW Q0r7reRUj9qX9cxHsbvGShsoT8DH8.L7qOUrgp2m8CMK.y.Z_L_5rIcrRtjmWs3tnhmNwLjm70TI bPZCoLbyN71aOn5gUzZ3idvAHCsryMIkPcPHFQR4VuwXm1Z4ZcGCEyxGOMUikZEA6maMSDeHlWEc ODbhWXdF6PvPluKyIClMbvSg7V5OTFhqf7Gby6j5bshhH6Qy7LQFZ_yxb14m.bZQraDaiaQXWk6f r1Y2PAOy3QbCO2sLqd64LcDxF16J709lLsCuS5W6qsr.PDR2z90FeKnxLLd6_Koqf9QMfma8e5HP H8rerCx.mIwS8uSw3BRnNREfsJFyftcYwmVxmPN3IA8UZH2v4_FO0b2QMWVwSZXl4MOH_xRZ5MNY 1UC61lX04HGgM_EFhqCwTnlWZO7eYHMszUnHfLYFKdfurLca25Ocm_wVr4RipRVnMrTsCcLKWXfI 4F6OLlMqYGoup9.etjjLkwYJz0rpr_slMbxO4_T.gRe6HGtycAdrLKe01BSyEPg2ubjDj3ithbYA VQWmxmjsQFlmN7Zh3e1qpEIDnbD8_EjvibzE2c.lkToSQ8MFdLQijyRQtrGo.yHDvDk5Yqz.X3pe _drORI2z9qBD3oFL19GYqZFaNUtV.L42KEG0E3GqLQ_7edyE_7OpK78ovSqnBr2YyyOt22iyxfi3 hnObSSy9yNZtke6Jb3d.GbdwNdYDtig_vfZJR93V4FsOXWRh4A2Qf10bx1OjW0avm7NhHnlU_KLa A1kzF7Bokp0HQSQvCH9DvBvKEtkaS4.R1brVE6PFf_jmqs1iqB_mFt3uPgXsfw3VXPcvYDN20R.D V0hv7guo1bOLFM_n6_oWQdkrrf5EVTEKKnr1TSrcwREO5tBwhq7e.1ta5TIrBaNgo9GER6XlSJxj cwXgESSoc8hsmwjwbmvJF26yywagzD4O4BGZOOa4k6rxNvAEcPMy6UXupjtULeWRHaurh4TeBEtL cua_DBwyZl8H4z74nTt4- X-Sonic-MF: Message-ID: Date: Wed, 4 Jan 2023 15:47:34 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v6] xen/pt: reserve PCI slot 2 for Intel igd-passthru Content-Language: en-US To: Alex Williamson , "Michael S. Tsirkin" , Anthony Perard , Paul Durrant Cc: qemu-devel@nongnu.org, Stefano Stabellini , Paolo Bonzini , Richard Henderson , Eduardo Habkost , Marcel Apfelbaum , xen-devel@lists.xenproject.org References: <830263507e8f1a24a94f81909d5102c4b204e938.1672615492.git.brchuckz.ref@aol.com> <830263507e8f1a24a94f81909d5102c4b204e938.1672615492.git.brchuckz@aol.com> <20230102124605-mutt-send-email-mst@kernel.org> <20230103081456.1d676b8e.alex.williamson@redhat.com> From: Chuck Zmudzinski In-Reply-To: <20230103081456.1d676b8e.alex.williamson@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.20982 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 3366 On 1/3/23 10:14 AM, Alex Williamson wrote: > > It's necessary to configure the assigned IGD at slot 2 to make it > functional, yes, but I don't really understand this notion of > "reserving" slot 2. If something occupies address 00:02.0 in the > config, it's the user's or management tool's responsibility to move it > to make this configuration functional. Why does QEMU need to play a > part in reserving this bus address. IGD devices are not generally > hot-pluggable either, so it doesn't seem we need to reserve an address > in case an IGD device is added dynamically later. The capability to reserve a bus address for a quirky device need not be limited to the case of hotplugged or dynamically added devices. The igd is a quirky device, and its presence in an emulated system like qemu requires special handling. The slot_reserved_mask member of PCIBus is also well-suited to the case of quirky device like Intel the igd that needs to be at slot 2. Just because it is not dynamically added later does not change the fact that it needs special handling at its initial configuration when the guest is being created. > Here's the problem that answers Michael's question why this patch is specific to xen: ---snip--- #ifdef CONFIG_XEN ... static void pc_xen_hvm_init(MachineState *machine) { PCMachineState *pcms = PC_MACHINE(machine); if (!xen_enabled()) { error_report("xenfv machine requires the xen accelerator"); exit(1); } pc_xen_hvm_init_pci(machine); pci_create_simple(pcms->bus, -1, "xen-platform"); } #endif ---snip--- This code is from hw/i386/pc_piix.c. Note the call to pci_create_simple to create the xen platform pci device, which has -1 as the second argument. That -1 tells pci_create_simple to autoconfigure the pci bdf address. It is *hard-coded* that way. That means no toolstack or management tool can change it. And what is hard-coded here is that the xen platform device will occupy slot 2, preventing the Intel igd or any other device from occupying slot 2. So, even if xen developers wanted to create a version of the libxl that is flexible enough to allow the xen platform device to be at a different slot, they could not without patching qemu to at least change that -1 to an initialization variable that can be read from a qemu command line option that libxl could configure. So, why not just accept this patch as the best way to deal with a xen-specific problem and fix it in a way that uses the xen/libxl philosophy of autoconfiguring things as much as possible except in cases of quirky devices like the Intel igd in which case the existing slot_reserved_mask member of PCIBus is very useful to accommodate the quirky igd device? IMHO, trying to impose the kvm/libvirt philosophy of having a very configurable toolstack on the xen/xenlight philosophy of autoconfiguring things that can be autoconfigured and using higher-level configuration options like igd-passthrough=on to tweak how autoconfiguration is done in a way that is compatible with quirky devices like the Intel igd is like trying to put a square peg into a round hole. Actually, qemu with its qom is able to accommodate both approaches to the design of a toolstack, and each vendor or project that depends on qemu should be free to use the approach it prefers. Just my two cents, FWIW. Kind regards, Chuck From xen-devel-bounces@lists.xenproject.org Wed Jan 04 20:51:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 20:51:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471500.731362 (Exim 4.92) (envelope-from ) id 1pDAiu-00059j-F8; Wed, 04 Jan 2023 20:50:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471500.731362; Wed, 04 Jan 2023 20:50:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDAiu-00059c-CS; Wed, 04 Jan 2023 20:50:56 +0000 Received: by outflank-mailman (input) for mailman id 471500; Wed, 04 Jan 2023 20:50:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDAit-00059W-Eu for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 20:50:55 +0000 Received: from sonic315-55.consmr.mail.gq1.yahoo.com (sonic315-55.consmr.mail.gq1.yahoo.com [98.137.65.31]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 79a6e7fc-8c71-11ed-b8d0-410ff93cb8f0; Wed, 04 Jan 2023 21:50:53 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic315.consmr.mail.gq1.yahoo.com with HTTP; Wed, 4 Jan 2023 20:50:51 +0000 Received: by hermes--production-ne1-7b69748c4d-bmdl9 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 48efc7ae25fbebe2e93c90ab59b9c6eb; Wed, 04 Jan 2023 20:50:46 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 79a6e7fc-8c71-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1672865451; bh=/7FmWC3We4NIkOcuub5MeTdLnF/yS37TemzpFMKai2s=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=r9jLsBPhibNqyy9S+gbD1MR5HeKsI7U6hTi83h06dg669hvFOrc+dnCfNupsO/fCXZo2ahfsKirc/I5LOxk4APzMFxpben2smQlWtFsmQCmXzyT34VdYaPrzBpPta/3rZMEy+tQTnLhQGHkgA2PJZz5JOKYBgURHjSMhYF+K9OiguB+ETO70q8prQqkT/14bWGJw1llRdG04o+x2TVZuEBUxnkgPPTAjMQkm3HFu8hEAL5V3Glvl5SStazzZhXPAl3j+/eotR7OfBZMOwF/S0HM0ckmProVICrZg5ndtbBurLHan/rz3Zu8jmuO6upN0B+wQBo2m78RO7wkJyWwqxA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1672865451; bh=4u8K/39RqcAwmuB+QplqjOBExwC5vcMH37jYFoiYHZ6=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=gBUvRYv/eanwhFcA710YtJukZoktcIyKyss284FcbyYyOSXx7I58IitWB32S/pfnfZ1m19MkZC+Xk13AJ9usvRCe+rMpKWUtfYkLuTvvj1q5mT+Gxk0C+vfxnsm8KSxgZh93Rcm4p5n9XiNAvE304y+Ik9y4/xuwg4/qHnrCVVV7waj8xhp17cGeCyFoq8UIx2D/QAvRZSSS91zLzDd8G+TJGghA/VgRCSWe6paIplay/ZMJxtxNtcPRIagkoQqeaa2CItkS/6vWE3Asnxt7QJnCLBr7O+cKJaGrRQLiadnLz7EFza+V7ttoAODgs6vdemIVeL1txfdiu7ljpkoHYQ== X-YMail-OSG: ZBIrh1kVM1k5EftxDLIx1GLNYz5JBJm0sGOynMCGSfr2OuExkOJuJ7okeTaXXUi 2gzoumf5Y2D5hu1ZKHNZTHL6ZQJRdCkN8a.VYuyoso4WNXsDaVp2qA4BMVGGLQp7bxCM9I_XKY3p iu9NoBGq_PPmUjw0.kThe9BjQT9egrdC0WA4vurL6JUT_NPmtVmS7eL5XmQPi9HshzacUlQH73Dd xqABGR3c5XxA8RyJhUkpkp09Wr_cxcKT_4uFLx.K5ufcUa3h8T2PUE7zuU_I5b8oOGJiOClZz6gd XocOO6wWWRAgKDvKbaysp2MFy_BK9vpijMEr2CTRske4k2Eigl6EF3_thpYXgxfhUgEZLJD6UJ8s jydPaWs7EwsBZXAsDzsjTNa.qbaWEpkNzOgvxBEwTeUa33GnbArfIyWy3Czp1PDqJ9j6gyCYgo86 nmkpT_uid1ST1CPajhMy5HVzBMqi3TOzqpmKL_lZCeNiMfDQVltf_UQttAh6gIyGLiDBhYGF8221 75IO2VYJiV4SPLDReSIsW5pu5gW4p8OUWWSbEiSB0NmIfOqksJ.XtaYgF8RaplOqNeF0fG1PzVN6 iOZUwrmhtmcxYJ7HYei2VxSsgmgQpYOxBYnxFAI2X_6DFcqlSL3c8JeBZ9xkpken3071nMtvJMMZ PQ0sTaZgpZGnGGPo8OPeD6341BQLxU1gki_uaDWsoHRT1CR5eXo4gV87zpFZ9E.JI29mzr5rodbc QBSsxu38WzcVhB1mfkPKIgeWzRJPRjpNVeCfbM_LPC2YFWP0VtD1LhsXlmWXkuENhaUjLs.3yU_5 Tx25TefAdqxHFb.VeCB7gD8FQIqrs7bT_vZfSQv9L7TbZIDTixuE2q7HLT9E9mcq4JlaWicyMkcY 2umAV02Cth6fDWv7.w5In1xXTukO0KNND.t5fG5A70jcB.bycf8ioAyA4lFUD77iss8ohQU6Rjvg zM3jP1cTCX_y9_I.0SXdWMcNEIeqyqaahcuGhst3RWyQgiLuMXgINgSJukiBgfMd7DScJAzyzRn. dkU41aC6OVTIXDImX0NpnGMAAmR6Y4KDOAvvzqO1xcjMrLWubw2CBgzeZqi5.7Mles1NVlq2JPZi KY_qicZg2_VGP89.C6.tA_k82SbnW8TKKejqXJ8sM0VKd4qZ8c07Fd92Igoqpp_LoIcYHigqTI3p iMqznn5a1j88GSCbUmpYaR_fnlPWr4NRozScdgURpenZLl9wSFNhv05uk.2jPgwreIxgwFORwtv4 H2HzPWMlyMyui6GT8yqGd3XEYxcr.T8jozql16d.msQ3EbdkClzwRtBJqirkS8p9PDjXpVrEfWft 73MsBPaYigK..ag_WmpMja96XTFv.7rYdVESuZPb6RhLTwQJ.fiQL0Wo8FksbLFR3zAgsw9tB5Fn J4_ecW5H3B0kZJcDhHsOhQPbxOsWU_Bdcojfv6x3Cl_FkpTv6iNsAedf2Mp49q1KpCqszDv4IPSn cI4T0zIP.ND13vtRg20trtz16RY9rv.bDWeRtMNp1MxG4z0vVgq_YnisDseGb0HLje07lxW7H9iw c6cZkMfOZkK4L.RnKtq3lRd9T2vER0HwwiXsFIdnIpypyv.ao.wImx74C9viWjCsULhGmIxpk5Q6 e_tBNynJACMdMd6kdWdJFp3cZ8NhivMztyUAVwjhpX4rnROixmdD5Un_8NhpxAXagxHg39XVb9JY 9_0u7IGGJR6pTkwPsmS.rA5oRybbkvxcBiOLJmIVRNrZJJE0S8kbmyBvWBgLsSZ8LDB6_V6fjNgi acRzqBKjECkRS.xX3SHNNdQ1klsDfoatNUjQgwh_TxupSSbu4k8FStYiA6GdTTcDdcmLYEpJ2wfe nbPJhBwg38vY_Fux7ZMm8GoVKXznu9wWoSq4bkH6_FE4hrIVELSkQKGYEvMepxNzvfgGFO1wXVtw Wzwt7HpLpHa0zTJcm_0EY_dcxOuiN9PcuNQl1E5BH1Ap0vmJuU6n2KcZvcbqPlvLWR0z3QEYVeJP wx8Zzh.9z2RIwMHo1bolZOCbHaDYTEe.gVPvtulml5EnH8SLPBQpAJakwOBnEh4ZAk1UqSP2O2gE AQBuydAk.KHb6Jau3zqVjeKwlZsIbZ8w5R5wMUKlsfMZuriNAPyLIkX3vMiqQvs42iHTWDa6RHKX y.fsLMSZVRIlmVrXttGFhMYQv56bDJZu7yvAMWr1_YL86_4pE.YAllwMSXoEC_YpvZjs9Cat37JE eG6wEvz02OaW8G6KLgx.v4WYqlA-- X-Sonic-MF: Message-ID: <38e0ba3c-1914-9148-0541-e2c28efb5f87@aol.com> Date: Wed, 4 Jan 2023 15:50:44 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v2 6/6] hw/isa/piix: Resolve redundant TYPE_PIIX3_XEN_DEVICE Content-Language: en-US To: Bernhard Beschow , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org, Markus Armbruster Cc: Richard Henderson , Stefano Stabellini , xen-devel@lists.xenproject.org, =?UTF-8?Q?Herv=c3=a9_Poussineau?= , Aurelien Jarno , Paul Durrant , Marcel Apfelbaum , Anthony Perard , "Michael S. Tsirkin" , Paolo Bonzini , Eduardo Habkost , Thomas Huth References: <20230104144437.27479-1-shentey@gmail.com> <20230104144437.27479-7-shentey@gmail.com> <1c2e0780-e5fb-1321-0d84-b0591db9fec7@linaro.org> From: Chuck Zmudzinski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.20982 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 4274 On 1/4/23 3:44 PM, Bernhard Beschow wrote: > > > Am 4. Januar 2023 17:54:16 UTC schrieb Chuck Zmudzinski : >>On 1/4/23 10:35 AM, Philippe Mathieu-Daudé wrote: >>> +Markus/Thomas >>> >>> On 4/1/23 15:44, Bernhard Beschow wrote: >>>> During the last patches, TYPE_PIIX3_XEN_DEVICE turned into a clone of >>>> TYPE_PIIX3_DEVICE. Remove this redundancy. >>>> >>>> Signed-off-by: Bernhard Beschow >>>> --- >>>> hw/i386/pc_piix.c | 4 +--- >>>> hw/isa/piix.c | 20 -------------------- >>>> include/hw/southbridge/piix.h | 1 - >>>> 3 files changed, 1 insertion(+), 24 deletions(-) >>>> >>>> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c >>>> index 5738d9cdca..6b8de3d59d 100644 >>>> --- a/hw/i386/pc_piix.c >>>> +++ b/hw/i386/pc_piix.c >>>> @@ -235,8 +235,6 @@ static void pc_init1(MachineState *machine, >>>> if (pcmc->pci_enabled) { >>>> DeviceState *dev; >>>> PCIDevice *pci_dev; >>>> - const char *type = xen_enabled() ? TYPE_PIIX3_XEN_DEVICE >>>> - : TYPE_PIIX3_DEVICE; >>>> int i; >>>> >>>> pci_bus = i440fx_init(pci_type, >>>> @@ -250,7 +248,7 @@ static void pc_init1(MachineState *machine, >>>> : pci_slot_get_pirq); >>>> pcms->bus = pci_bus; >>>> >>>> - pci_dev = pci_new_multifunction(-1, true, type); >>>> + pci_dev = pci_new_multifunction(-1, true, TYPE_PIIX3_DEVICE); >>>> object_property_set_bool(OBJECT(pci_dev), "has-usb", >>>> machine_usb(machine), &error_abort); >>>> object_property_set_bool(OBJECT(pci_dev), "has-acpi", >>>> diff --git a/hw/isa/piix.c b/hw/isa/piix.c >>>> index 98e9b12661..e4587352c9 100644 >>>> --- a/hw/isa/piix.c >>>> +++ b/hw/isa/piix.c >>>> @@ -33,7 +33,6 @@ >>>> #include "hw/qdev-properties.h" >>>> #include "hw/ide/piix.h" >>>> #include "hw/isa/isa.h" >>>> -#include "hw/xen/xen.h" >>>> #include "sysemu/runstate.h" >>>> #include "migration/vmstate.h" >>>> #include "hw/acpi/acpi_aml_interface.h" >>>> @@ -465,24 +464,6 @@ static const TypeInfo piix3_info = { >>>> .class_init = piix3_class_init, >>>> }; >>>> >>>> -static void piix3_xen_class_init(ObjectClass *klass, void *data) >>>> -{ >>>> - DeviceClass *dc = DEVICE_CLASS(klass); >>>> - PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); >>>> - >>>> - k->realize = piix3_realize; >>>> - /* 82371SB PIIX3 PCI-to-ISA bridge (Step A1) */ >>>> - k->device_id = PCI_DEVICE_ID_INTEL_82371SB_0; >>>> - dc->vmsd = &vmstate_piix3; >>> >>> IIUC, since this device is user-creatable, we can't simply remove it >>> without going thru the deprecation process. Alternatively we could >>> add a type alias: >>> >>> -- >8 -- >>> diff --git a/softmmu/qdev-monitor.c b/softmmu/qdev-monitor.c >>> index 4b0ef65780..d94f7ea369 100644 >>> --- a/softmmu/qdev-monitor.c >>> +++ b/softmmu/qdev-monitor.c >>> @@ -64,6 +64,7 @@ typedef struct QDevAlias >>> QEMU_ARCH_LOONGARCH) >>> #define QEMU_ARCH_VIRTIO_CCW (QEMU_ARCH_S390X) >>> #define QEMU_ARCH_VIRTIO_MMIO (QEMU_ARCH_M68K) >>> +#define QEMU_ARCH_XEN (QEMU_ARCH_ARM | QEMU_ARCH_I386) >>> >>> /* Please keep this table sorted by typename. */ >>> static const QDevAlias qdev_alias_table[] = { >>> @@ -111,6 +112,7 @@ static const QDevAlias qdev_alias_table[] = { >>> { "virtio-tablet-device", "virtio-tablet", QEMU_ARCH_VIRTIO_MMIO }, >>> { "virtio-tablet-ccw", "virtio-tablet", QEMU_ARCH_VIRTIO_CCW }, >>> { "virtio-tablet-pci", "virtio-tablet", QEMU_ARCH_VIRTIO_PCI }, >>> + { "PIIX3", "PIIX3-xen", QEMU_ARCH_XEN }, >> >>Hi Bernhard, >> >>Can you comment if this should be: >> >>+ { "PIIX", "PIIX3-xen", QEMU_ARCH_XEN }, >> >>instead? IIUC, the patch series also removed PIIX3 and PIIX4 and >>replaced them with PIIX. Or am I not understanding correctly? > > PIIX3 is correct. The PIIX consolidation is just about sharing code between the PIIX3 and PIIX4 south bridges and should not cause any user or guest observable differences. I realize that now. I see the PIIX3 device still exists after applying the patch set. Thanks, Chuck From xen-devel-bounces@lists.xenproject.org Wed Jan 04 20:58:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 20:58:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471507.731374 (Exim 4.92) (envelope-from ) id 1pDApo-0005pT-8A; Wed, 04 Jan 2023 20:58:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471507.731374; Wed, 04 Jan 2023 20:58:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDApo-0005pM-50; Wed, 04 Jan 2023 20:58:04 +0000 Received: by outflank-mailman (input) for mailman id 471507; Wed, 04 Jan 2023 20:58:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDApn-0005pA-2M for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 20:58:03 +0000 Received: from sonic307-55.consmr.mail.gq1.yahoo.com (sonic307-55.consmr.mail.gq1.yahoo.com [98.137.64.31]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 78d6bbaf-8c72-11ed-91b6-6bf2151ebd3b; Wed, 04 Jan 2023 21:58:01 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.gq1.yahoo.com with HTTP; Wed, 4 Jan 2023 20:57:59 +0000 Received: by hermes--production-ne1-7b69748c4d-drrwg (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID c018152b0879594142c30836da56166d; Wed, 04 Jan 2023 20:57:54 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 78d6bbaf-8c72-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1672865879; bh=MwqxqmMf18MOAgnCK181pLsHPRDudVx5Vcx25bazdHY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=jF8CsG9yyVzc/LfhMgmjumRjssA7XyT7Lmr2xT1z+IP7YOi6Tnxf1D9l+S0TkQ5XY5neasaWRQXKh6OmBCBENtGYszgxsr+tCWA5twvDOZHKeJVdGgATPZBprlz4PSYgb3d9LX25EO+jJkb5x5TluDRFME7QoCgXQCZ9rKmVToi+8TMczNlXRtTby1xK4C48uKmQxCLEj/mQ4dRJRuQgkBux6y2Q7i9fW/23m7Ry5v0m+PfFvo1pm5rut817HuCAPj+hteKVMk8O5S0UXqlPU5LCY5hKDh0o5DSK8J+jMVbFHEpyYmbiJWZmTE47c9zOfTboTymlvczvVCOmHhTF9w== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1672865879; bh=2Ropz9OOjxUP5aP+emjrqR06SAJW6JbpIF/9X9NCbbZ=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=WFWWD1qzqOIXvwmXIMcgxWPR8KqiFcGRlf4sACs3LFzfpU4Tz4nGWvk+VXERK3FRmywWmQcfFotrphCLTT+PwrRRLEsJa+FLu35T2fiYmIqjz1RIEwXUAx/sVOmjHrYPTozE07/7paBTDVuVpp7J3Xt2nnVPCtA5ajFJb6zNx5Te3/wBuVYdOzyMQDQPLsxQky7GKZqJ0WBzQtVk0g6hLkO8H9NAl0jI7IiBEbrpYNldyo1JlyCutKMVGNFRA6DsY3FH+oFKUsVaIfgMRxYsiRWlFZl0CjVDGfqZ3NTMMJs80rfDPrZG+RNyKV+ac7qPi+l0DV0W9cJf8xyEql/ygw== X-YMail-OSG: fsn.Lh0VM1mJv879NPieLib8bbgxISTRbyYolGsULGeNjvftgMlIzOkVnfvZm5Z 3rQXoEOI_2TVq.wD7nOBGLRIBRqYLYGszRd44dfj8JwxgwUXf8BJ0m3tYviqk4UkmEBlaESc4pdr kl6wZB3bTnQiHFrrjS7lW4NxCncBP9CDq3k1rkqsP73DWQ0IveKwyPLGJ55YtkmkmMXiMn4YiUw_ UdqVogcKlhKPPqG6BHKGiDFQwcgzlWa7iJdvn1GrvA17p3TUQ7AvQrl5rky2weI6r7bWcnvLOWwF K33VZ0kyH8wO7wfpGFiRTgGYxTwHytJjBtrtmzhvD9CiiI2f4MGAuEq1ir42WAJGcMPBcVM6tTQS dzE6iuiV4hEJIpdivPEB42tFQHJMnkkJLcyzrXYWA.7RjmDPLsyp6p31Le3o593PIsvAtHSI_cwL ff3ZjGIYBarimFdgGEtofJ6yvsasMeg8KvqmlThbzNXHLKuCaOAVIhC5cAosfpjCa_uhM7s.nFhZ UZq0MDBUVhIO5IHoJLKzT.bydQOZyqt6W.ied_U1HsdHnVO0j4u3R34TaFFlGMtykE2W3AZm0602 FVqcH1xBhyKkjtibsagqRXql6YNbEIjmHvU4h5RPE2BqDPSojL_n9dcSxqZBfndA0a5Oc7aVOgzu YSpl6xEhgWLcnt3jzOX3DGlZT.YuAh0BiJ.Aru1rgptw1dBuzDvHPKNC7uxJnWs7ZBHV49ISNI0f BCH6XtJTpa.KVQfwwAJOfPOQ6SuhgkZZXN7vcQEQ3B8QzRKNbbMsMMtrDOCAtwpEecrLe2q2pcwd keL7wjbA4KtzixTIUcRtJ2S0eTcWa_vR2j9TfJxv8y7d_wiu8LN6BVH16xD5Qnaab7srR1aUoLU4 1Uw65FruC1qWWsQTJDx_7oaByX77BR2C8GIsvxM31_TcZt8ThuW3DFAD_C8C2WE18WwMb647cdrr bR1yNq51OyH3HYzcUtvnPej.Dssig_2m.ai8caAcd8YtXddznK9tzWCyHMhHh4dbpgKEM4T5j7BQ NT11iOpIOPj_72Swf_.m_z6TmVOEBbUtR0gUkounQ_le64rMBPMsOJaVfxxQKT5bGeb750ekGJXE lA7nQeZZojZCN4J6Vy7eSxh3kZQEWesx0gMtYQxECqN5HsSc2E0OTFn4o8Nm_8LjNyFxk78_zAuo nfrIW_Peud28klRsn2iYcT6WxeVj5WVlgTVH1VsmcheW2rWsv9iLe4mno_44ovLD9vW1N1f5meeF rSLuadXq4grgwTLb6d6wY9nCJBxWvo8aQv_2CVlgT6PS6725_ySi6_kPJ51_nsdxHHNtg_0_a0GN UlN6cZkP6XoOJOA18fMR07kWOMzhEYbiGkW73vKe7F1g3kJMPABpUxkGmY8I4ssZcaRlkyqvucIl Xbe2f2GY1EPxJOySjJ3ccUf.a28HE.8ThyZlLhJlXWAb0g9hRuig9_9MIECjZki3fgMiA_ZAwT2z Qrj.BxJNVnNUepnvSehmFqikrM8sjb3AmmjOXXmqRkDsmgaw_fcZy7bQfyQSNrh9gqTDMTXxTUxH .FcI3FNtmSh1iAiiZ0dBsbl9b07NDjnsPOUHtFoDHFjra8jACLXINTUNX362mc9Se.9WJeJoWmaX mLo9923QIFqOJRzrqL4VUshFz2V0zL_C5ZKw1u.hp5P15XjuctUBNxrMLiRDja2KqQq5fxpl48Fk l87BGMi5j_67b_pEA6wPH7PGp0Dhb.ARAFl3mVLJ_12lI_sixyMU_IWc7WwNm.5QkfoxqsS7FkrH 9DnoAR4VoK09rmhYc7Kcf7AWvleFjXsYtPIW6sjZjiZvCqAquR0flyukq93VYj1.Xdw6MabSo3WY NXQ3Z8_rBZx7O0DfOME_ScQwObHBDLQWSgnYbOnjPyad1e9.jDajVhHtCk924DalLobsDj0aeKXX mWSMhfVzmd_ePmXKLok8F5SswczNNsIOz20EmpAowbQBNpNfGzXL_lDjPkNAy3IGrZaNhkheZGTX LBGMJX0M45lLkYysQUdbXHHpNJj4_DSoTkBjfaejHkV53y9aWDPBP7lzKuaCsEYjQJsKVcIS2ijU HKrUjacjNgGWT_3iH4pRYfNYVzJw1EDEuqr0qNQ4yqz5ghUoke__vU6sAikjExA8qK01DlJThFUR 5LKZU5XmnXpOmLwHtRXCC_vHvPQRDtmS.Z_UDa4TUvL49e1cbZDSmdwbgWOu.Ia65TB5OAF8AxC_ cXEz1SYuAYx8lbT9PA7gx5wcXzzk- X-Sonic-MF: Message-ID: Date: Wed, 4 Jan 2023 15:57:51 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v2 6/6] hw/isa/piix: Resolve redundant TYPE_PIIX3_XEN_DEVICE Content-Language: en-US To: Bernhard Beschow , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org, Markus Armbruster Cc: Richard Henderson , Stefano Stabellini , xen-devel@lists.xenproject.org, =?UTF-8?Q?Herv=c3=a9_Poussineau?= , Aurelien Jarno , Paul Durrant , Marcel Apfelbaum , Anthony Perard , "Michael S. Tsirkin" , Paolo Bonzini , Eduardo Habkost , Thomas Huth References: <20230104144437.27479-1-shentey@gmail.com> <20230104144437.27479-7-shentey@gmail.com> <1c2e0780-e5fb-1321-0d84-b0591db9fec7@linaro.org> <92efe0f1-f22b-47bc-f27d-2f31cb3621ea@aol.com> From: Chuck Zmudzinski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.20982 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 6229 On 1/4/23 3:31 PM, Bernhard Beschow wrote: > > > Am 4. Januar 2023 19:29:35 UTC schrieb Chuck Zmudzinski : >>On 1/4/23 1:48 PM, Philippe Mathieu-Daudé wrote: >>> On 4/1/23 18:54, Chuck Zmudzinski wrote: >>>> On 1/4/23 10:35 AM, Philippe Mathieu-Daudé wrote: >>>>> +Markus/Thomas >>>>> >>>>> On 4/1/23 15:44, Bernhard Beschow wrote: >>>>>> During the last patches, TYPE_PIIX3_XEN_DEVICE turned into a clone of >>>>>> TYPE_PIIX3_DEVICE. Remove this redundancy. >>>>>> >>>>>> Signed-off-by: Bernhard Beschow >>>>>> --- >>>>>> hw/i386/pc_piix.c | 4 +--- >>>>>> hw/isa/piix.c | 20 -------------------- >>>>>> include/hw/southbridge/piix.h | 1 - >>>>>> 3 files changed, 1 insertion(+), 24 deletions(-) >>>>>> >>>>>> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c >>>>>> index 5738d9cdca..6b8de3d59d 100644 >>>>>> --- a/hw/i386/pc_piix.c >>>>>> +++ b/hw/i386/pc_piix.c >>>>>> @@ -235,8 +235,6 @@ static void pc_init1(MachineState *machine, >>>>>> if (pcmc->pci_enabled) { >>>>>> DeviceState *dev; >>>>>> PCIDevice *pci_dev; >>>>>> - const char *type = xen_enabled() ? TYPE_PIIX3_XEN_DEVICE >>>>>> - : TYPE_PIIX3_DEVICE; >>>>>> int i; >>>>>> >>>>>> pci_bus = i440fx_init(pci_type, >>>>>> @@ -250,7 +248,7 @@ static void pc_init1(MachineState *machine, >>>>>> : pci_slot_get_pirq); >>>>>> pcms->bus = pci_bus; >>>>>> >>>>>> - pci_dev = pci_new_multifunction(-1, true, type); >>>>>> + pci_dev = pci_new_multifunction(-1, true, TYPE_PIIX3_DEVICE); >>>>>> object_property_set_bool(OBJECT(pci_dev), "has-usb", >>>>>> machine_usb(machine), &error_abort); >>>>>> object_property_set_bool(OBJECT(pci_dev), "has-acpi", >>>>>> diff --git a/hw/isa/piix.c b/hw/isa/piix.c >>>>>> index 98e9b12661..e4587352c9 100644 >>>>>> --- a/hw/isa/piix.c >>>>>> +++ b/hw/isa/piix.c >>>>>> @@ -33,7 +33,6 @@ >>>>>> #include "hw/qdev-properties.h" >>>>>> #include "hw/ide/piix.h" >>>>>> #include "hw/isa/isa.h" >>>>>> -#include "hw/xen/xen.h" >>>>>> #include "sysemu/runstate.h" >>>>>> #include "migration/vmstate.h" >>>>>> #include "hw/acpi/acpi_aml_interface.h" >>>>>> @@ -465,24 +464,6 @@ static const TypeInfo piix3_info = { >>>>>> .class_init = piix3_class_init, >>>>>> }; >>>>>> >>>>>> -static void piix3_xen_class_init(ObjectClass *klass, void *data) >>>>>> -{ >>>>>> - DeviceClass *dc = DEVICE_CLASS(klass); >>>>>> - PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); >>>>>> - >>>>>> - k->realize = piix3_realize; >>>>>> - /* 82371SB PIIX3 PCI-to-ISA bridge (Step A1) */ >>>>>> - k->device_id = PCI_DEVICE_ID_INTEL_82371SB_0; >>>>>> - dc->vmsd = &vmstate_piix3; >>>>> >>>>> IIUC, since this device is user-creatable, we can't simply remove it >>>>> without going thru the deprecation process. Alternatively we could >>>>> add a type alias: >>>>> >>>>> -- >8 -- >>>>> diff --git a/softmmu/qdev-monitor.c b/softmmu/qdev-monitor.c >>>>> index 4b0ef65780..d94f7ea369 100644 >>>>> --- a/softmmu/qdev-monitor.c >>>>> +++ b/softmmu/qdev-monitor.c >>>>> @@ -64,6 +64,7 @@ typedef struct QDevAlias >>>>> QEMU_ARCH_LOONGARCH) >>>>> #define QEMU_ARCH_VIRTIO_CCW (QEMU_ARCH_S390X) >>>>> #define QEMU_ARCH_VIRTIO_MMIO (QEMU_ARCH_M68K) >>>>> +#define QEMU_ARCH_XEN (QEMU_ARCH_ARM | QEMU_ARCH_I386) >>>>> >>>>> /* Please keep this table sorted by typename. */ >>>>> static const QDevAlias qdev_alias_table[] = { >>>>> @@ -111,6 +112,7 @@ static const QDevAlias qdev_alias_table[] = { >>>>> { "virtio-tablet-device", "virtio-tablet", QEMU_ARCH_VIRTIO_MMIO }, >>>>> { "virtio-tablet-ccw", "virtio-tablet", QEMU_ARCH_VIRTIO_CCW }, >>>>> { "virtio-tablet-pci", "virtio-tablet", QEMU_ARCH_VIRTIO_PCI }, >>>>> + { "PIIX3", "PIIX3-xen", QEMU_ARCH_XEN }, >>>> >>>> Hi Bernhard, >>>> >>>> Can you comment if this should be: >>>> >>>> + { "PIIX", "PIIX3-xen", QEMU_ARCH_XEN }, >>>> >>>> instead? IIUC, the patch series also removed PIIX3 and PIIX4 and >>>> replaced them with PIIX. Or am I not understanding correctly? >>> >>> There is a confusion in QEMU between PCI bridges, the first PCI >>> function they implement, and the other PCI functions. >>> >>> Here TYPE_PIIX3_DEVICE means for "PCI function part of the PIIX >>> south bridge chipset, which expose a PCI-to-ISA bridge". A better >>> name could be TYPE_PIIX3_ISA_PCI_DEVICE. Unfortunately this >>> device is named "PIIX3" with no indication of ISA bridge. >> >> >>Thanks, you are right, I see the PIIX3 device still exists after >>this patch set is applied. >> >>chuckz@debian:~/sources-sid/qemu/qemu-7.50+dfsg/hw/i386$ grep -r PIIX3 * >>pc_piix.c: pci_dev = pci_new_multifunction(-1, true, TYPE_PIIX3_DEVICE); >> >>I also understand there is the PCI-to-ISA bridge at 00:01.0 on the PCI bus: >> >>chuckz@debian:~$ lspci >>00:00.0 Host bridge: Intel Corporation 440FX - 82441FX PMC [Natoma] (rev 02) >>00:01.0 ISA bridge: Intel Corporation 82371SB PIIX3 ISA [Natoma/Triton II] >>00:01.1 IDE interface: Intel Corporation 82371SB PIIX3 IDE [Natoma/Triton II] >>00:01.2 USB controller: Intel Corporation 82371SB PIIX3 USB [Natoma/Triton II] (rev 01) >>00:01.3 Bridge: Intel Corporation 82371AB/EB/MB PIIX4 ACPI (rev 03) >>00:02.0 Unassigned class [ff80]: XenSource, Inc. Xen Platform Device (rev 01) >>00:03.0 VGA compatible controller: Device 1234:1111 (rev 02) >> >>I also see with this patch, there is a bridge that is a PIIX4 ACPI at 00:01.3. > > Yeah, this PIIX4 ACPI device is what we consider a "Frankenstein" device here on the list. Indeed my PIIX consolidation series aims for eventually replacing the remaining PIIX3 devices with PIIX4 ones to present a realistic environment to guests. The series you tested makes Xen work with PIIX4. With a couple of more patches you might be able to opt into a realistic PIIX4 emulation in the future! That's exactly what I want to hear as a future milestone, and thanks for your work on this! Kind regards, Chuck From xen-devel-bounces@lists.xenproject.org Wed Jan 04 22:18:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 22:18:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471514.731384 (Exim 4.92) (envelope-from ) id 1pDC5j-0005Nq-UY; Wed, 04 Jan 2023 22:18:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471514.731384; Wed, 04 Jan 2023 22:18:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDC5j-0005Nj-Ro; Wed, 04 Jan 2023 22:18:35 +0000 Received: by outflank-mailman (input) for mailman id 471514; Wed, 04 Jan 2023 22:18:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDC5i-0005NX-8v for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 22:18:34 +0000 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [2a00:1450:4864:20::62d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b7a785ba-8c7d-11ed-b8d0-410ff93cb8f0; Wed, 04 Jan 2023 23:18:30 +0100 (CET) Received: by mail-ej1-x62d.google.com with SMTP id ud5so86128864ejc.4 for ; Wed, 04 Jan 2023 14:18:30 -0800 (PST) Received: from [192.168.1.115] ([185.126.107.38]) by smtp.gmail.com with ESMTPSA id o17-20020a1709062e9100b007bd9e683639sm15718720eji.130.2023.01.04.14.18.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Jan 2023 14:18:28 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b7a785ba-8c7d-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4ysHgPmEoM4C0MsKpxmajfVnShhx28Dsr3QVGstLB34=; b=VV0KG9555T9PoLAI8dAC21IQsnZ3lSR8DsLsgK/MtaWHYl/VxEiwDbH+RTDfrr5dQW WA4utGik6635RTmghS0a7WkHbgjPjuHiE+pO+hgiksDUq+n8V5BNHExlZHlUloYboqY7 zrU8PN4gZjq2WnCGmIiIMR675pgNyuDdsxOet1Bt9y03U0vOuXBwptSClErZqrI/0bHR KFQQFiqETpzUcm2ka7wktHggBLgYZyP7Mvj21q6OfiyMwE7sHyIMp+Dz2BCx02mnBy6N 5FNUZefTOV8iHE77uu4IjCU7RVsjQhh39eEJrTwmwNi2v/yN30VM+aOjm2Gsij5+8n96 tXgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4ysHgPmEoM4C0MsKpxmajfVnShhx28Dsr3QVGstLB34=; b=yJX0MjuGvD6UQ9jmX2V71pklPnvolzEK9g79Qx+aDlFgeK8Tz45oYxU0w5Mh9UY7tr E3Lc1FtU5fjgwAjxetEKNY3WGXpBwLgQmzs1I2IAGqHgQiCRrAqi4oqRAAK9T7zuW9Hv XfSaDKUrUjgQ+K1hUeq6rGBbq7XSVciW4wW5d7IuOKhd1/JFjshZvtYnQJOKR5CYW1Ke glf94T3QVXDFEJVIXKl4lj0yAJ39BidEsXxYxPy116B5hF6XxaLXGnEB86lhoHJ4nWt4 mfu3oGoRyPnT09vtiZJJ2FcWMFXFFOAcBNwT0QCtuvNNUZepWBuPj14/Yd4RdnUWlnxj uXig== X-Gm-Message-State: AFqh2kqFRfWKeQ7dm3rp1dhH08/UMGT8hVf2oyChg7fFjJ67e3jRpKJO Ui+Ph4s6gQAOp4H4sNzg+HibBg== X-Google-Smtp-Source: AMrXdXviPfF39VzEoGdqBpllgHy43HnZ0JUR7GccE1WHtt6JagF8scMFZzI1nxTausiLoRgwOJZm3A== X-Received: by 2002:a17:906:94f:b0:7c1:4f7c:947f with SMTP id j15-20020a170906094f00b007c14f7c947fmr44428107ejd.72.1672870709605; Wed, 04 Jan 2023 14:18:29 -0800 (PST) Message-ID: <877abde0-2e76-7fde-0212-eb7ce1384ea6@linaro.org> Date: Wed, 4 Jan 2023 23:18:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 6/6] hw/isa/piix: Resolve redundant TYPE_PIIX3_XEN_DEVICE Content-Language: en-US To: Chuck Zmudzinski , Bernhard Beschow , qemu-devel@nongnu.org, Markus Armbruster Cc: Richard Henderson , Stefano Stabellini , xen-devel@lists.xenproject.org, =?UTF-8?Q?Herv=c3=a9_Poussineau?= , Aurelien Jarno , Paul Durrant , Marcel Apfelbaum , Anthony Perard , "Michael S. Tsirkin" , Paolo Bonzini , Eduardo Habkost , Thomas Huth References: <20230104144437.27479-1-shentey@gmail.com> <20230104144437.27479-7-shentey@gmail.com> <1c2e0780-e5fb-1321-0d84-b0591db9fec7@linaro.org> <92efe0f1-f22b-47bc-f27d-2f31cb3621ea@aol.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <92efe0f1-f22b-47bc-f27d-2f31cb3621ea@aol.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 4/1/23 20:29, Chuck Zmudzinski wrote: > On 1/4/23 1:48 PM, Philippe Mathieu-Daudé wrote: >> Here TYPE_PIIX3_DEVICE means for "PCI function part of the PIIX >> south bridge chipset, which expose a PCI-to-ISA bridge". A better >> name could be TYPE_PIIX3_ISA_PCI_DEVICE. Unfortunately this >> device is named "PIIX3" with no indication of ISA bridge. > > > Thanks, you are right, I see the PIIX3 device still exists after > this patch set is applied. > > chuckz@debian:~/sources-sid/qemu/qemu-7.50+dfsg/hw/i386$ grep -r PIIX3 * > pc_piix.c: pci_dev = pci_new_multifunction(-1, true, TYPE_PIIX3_DEVICE); > > I also understand there is the PCI-to-ISA bridge at 00:01.0 on the PCI bus: > > chuckz@debian:~$ lspci > 00:00.0 Host bridge: Intel Corporation 440FX - 82441FX PMC [Natoma] (rev 02) All these entries ('PCI functions') ...: > 00:01.0 ISA bridge: Intel Corporation 82371SB PIIX3 ISA [Natoma/Triton II] > 00:01.1 IDE interface: Intel Corporation 82371SB PIIX3 IDE [Natoma/Triton II] > 00:01.2 USB controller: Intel Corporation 82371SB PIIX3 USB [Natoma/Triton II] (rev 01) > 00:01.3 Bridge: Intel Corporation 82371AB/EB/MB PIIX4 ACPI (rev 03) ... are part of the same *device*: the PIIX south bridge. This device is enumerated as #1 on the PCI bus #0. It currently exposes 4 functions: ISA/IDE/USB/ACPI. > 00:02.0 Unassigned class [ff80]: XenSource, Inc. Xen Platform Device (rev 01) > 00:03.0 VGA compatible controller: Device 1234:1111 (rev 02) > > I also see with this patch, there is a bridge that is a PIIX4 ACPI at 00:01.3. > I get the exact same output from lspci without the patch series, so that gives > me confidence it is working as designed. Historically the PIIX3 and PIIX4 QEMU models have been written by different people with different goals. - PIIX3 comes from x86 machines and is important for KVM/Xen accelerators - PIIX4 was developed by hobbyist for MIPS machines PIIX4 added the ACPI function which was proven helpful for x86 machines. OS such Linux don't consider the PIIX south bridge as a whole chipset, and enumerate each PCI function individually. So it was possible to add the PIIX4 ACPI function to a PIIX3... A config that doesn't exist with real hardware :/ While QEMU aims at modeling real HW, this config is still very useful for KVM/Xen. So this Frankenstein config is accepted / maintained. Bernhard is doing an incredible work merging the PIIX3/PIIX4 differences into a more maintainable model :) Regards, Phil. From xen-devel-bounces@lists.xenproject.org Wed Jan 04 22:35:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 22:35:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471522.731396 (Exim 4.92) (envelope-from ) id 1pDCMQ-0007og-Gv; Wed, 04 Jan 2023 22:35:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471522.731396; Wed, 04 Jan 2023 22:35:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDCMQ-0007oZ-Do; Wed, 04 Jan 2023 22:35:50 +0000 Received: by outflank-mailman (input) for mailman id 471522; Wed, 04 Jan 2023 22:35:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDCMP-0007oT-69 for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 22:35:49 +0000 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [2a00:1450:4864:20::633]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 219598ff-8c80-11ed-b8d0-410ff93cb8f0; Wed, 04 Jan 2023 23:35:46 +0100 (CET) Received: by mail-ej1-x633.google.com with SMTP id u9so86272002ejo.0 for ; Wed, 04 Jan 2023 14:35:46 -0800 (PST) Received: from [192.168.1.115] ([185.126.107.38]) by smtp.gmail.com with ESMTPSA id q19-20020a17090676d300b008072c925e4csm15659503ejn.21.2023.01.04.14.35.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Jan 2023 14:35:45 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 219598ff-8c80-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9D9ufjFO5ErkH2AbAYOcVhRTOeT61tLIfkXN1tOblOs=; b=qv7p6hbUZqhwy3iQDuhw5Zh/OaU+jdEqOBkCsMH4ACc+FvjAC91j7cExF3wcIjxTj/ P5Af9RwADSEA4/2xj9jtn/bp4tinOssr7+eXzK5rb5W23ksxutq2KGWCOV8Vx0xUBEIj 3SDQr6m6fnxHqGsFHN4hmyUPzpeyrvMBIGoy8RJkUKrdu3Dlse6HMVzuWofLbywDG8w7 Yh0M2kZfJ6Hbhlrvq9jKxqEIEnU2CxVdRasynMZS6octhZaF3M72EbUgEIdGnHxJ5c16 Zgdizvrjpo+H4Q9780RNeX85HvoeAzJ5ShUyofin14VywCadZG8+7SGyzKC6eUot9hS0 mg6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9D9ufjFO5ErkH2AbAYOcVhRTOeT61tLIfkXN1tOblOs=; b=QhR2R8+ZYlkN2bhd4y7JoLRNbAnp/A+oYxJP6oo75shvul7BlwYL2GWUd1pfpX9Fxi DPfIBa/hiBev9agcpRVfJBepHSyYUzGycD/XBEjtyUxOBPZGEi6QVZSRYDhl1CH688Mm xsTWlTraHRdLqSXA7Uv9kYQ61MOWOnG6FHGZgTuf2G4PWSqtrsSxYbNZFCnxoqGl1fso gZlks54ekuejTuk4oaO+pNdkDAH/fHchGLKcacpwrqx3QG2spKh2EuOI14jQR+ku+NtG e39yhoSAYT39jFsHQ2v0Iww04UcxdX/Q1YkleB9s6/tQKpn0HDzmyEsKZuWhhwWGWzFx 6CWA== X-Gm-Message-State: AFqh2kpSRM3v/xXTRMgrEUEpEO4Re4QVN6u6iAVchg3CWrV6WznTHAbp RwJnwBvPW3+6h5JhcAkrefqxOg== X-Google-Smtp-Source: AMrXdXsQ3IhtNb5cG1wk60QS7wd3RDWh6fd1SXn/KbYkoE54jRIhMPY1SXG2MimpwT8M9GQLVoAtyg== X-Received: by 2002:a17:907:86a6:b0:7c0:fd1a:79f0 with SMTP id qa38-20020a17090786a600b007c0fd1a79f0mr59371406ejc.21.1672871746219; Wed, 04 Jan 2023 14:35:46 -0800 (PST) Message-ID: <405dc396-7b7e-842a-2b94-6b26df1aa564@linaro.org> Date: Wed, 4 Jan 2023 23:35:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 6/6] hw/isa/piix: Resolve redundant TYPE_PIIX3_XEN_DEVICE Content-Language: en-US To: Chuck Zmudzinski , Bernhard Beschow , qemu-devel@nongnu.org Cc: Richard Henderson , Stefano Stabellini , xen-devel@lists.xenproject.org, =?UTF-8?Q?Herv=c3=a9_Poussineau?= , Aurelien Jarno , Paul Durrant , Marcel Apfelbaum , Anthony Perard , "Michael S. Tsirkin" , Paolo Bonzini , Eduardo Habkost References: <20230104144437.27479-1-shentey@gmail.com> <20230104144437.27479-7-shentey@gmail.com> <30ed41ab-f7c9-15fb-8f4b-b2742b1d4188@aol.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <30ed41ab-f7c9-15fb-8f4b-b2742b1d4188@aol.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 4/1/23 17:42, Chuck Zmudzinski wrote: > On 1/4/23 9:44 AM, Bernhard Beschow wrote: >> During the last patches, TYPE_PIIX3_XEN_DEVICE turned into a clone of >> TYPE_PIIX3_DEVICE. Remove this redundancy. >> >> Signed-off-by: Bernhard Beschow >> --- >> hw/i386/pc_piix.c | 4 +--- >> hw/isa/piix.c | 20 -------------------- >> include/hw/southbridge/piix.h | 1 - >> 3 files changed, 1 insertion(+), 24 deletions(-) >> >> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c >> index 5738d9cdca..6b8de3d59d 100644 >> --- a/hw/i386/pc_piix.c >> +++ b/hw/i386/pc_piix.c >> @@ -235,8 +235,6 @@ static void pc_init1(MachineState *machine, >> if (pcmc->pci_enabled) { >> DeviceState *dev; >> PCIDevice *pci_dev; >> - const char *type = xen_enabled() ? TYPE_PIIX3_XEN_DEVICE >> - : TYPE_PIIX3_DEVICE; >> int i; >> >> pci_bus = i440fx_init(pci_type, >> @@ -250,7 +248,7 @@ static void pc_init1(MachineState *machine, >> : pci_slot_get_pirq); >> pcms->bus = pci_bus; >> >> - pci_dev = pci_new_multifunction(-1, true, type); >> + pci_dev = pci_new_multifunction(-1, true, TYPE_PIIX3_DEVICE); >> object_property_set_bool(OBJECT(pci_dev), "has-usb", >> machine_usb(machine), &error_abort); >> object_property_set_bool(OBJECT(pci_dev), "has-acpi", >> diff --git a/hw/isa/piix.c b/hw/isa/piix.c >> index 98e9b12661..e4587352c9 100644 >> --- a/hw/isa/piix.c >> +++ b/hw/isa/piix.c >> @@ -33,7 +33,6 @@ >> #include "hw/qdev-properties.h" >> #include "hw/ide/piix.h" >> #include "hw/isa/isa.h" >> -#include "hw/xen/xen.h" >> #include "sysemu/runstate.h" >> #include "migration/vmstate.h" >> #include "hw/acpi/acpi_aml_interface.h" >> @@ -465,24 +464,6 @@ static const TypeInfo piix3_info = { >> .class_init = piix3_class_init, >> }; >> >> -static void piix3_xen_class_init(ObjectClass *klass, void *data) >> -{ >> - DeviceClass *dc = DEVICE_CLASS(klass); >> - PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); >> - >> - k->realize = piix3_realize; >> - /* 82371SB PIIX3 PCI-to-ISA bridge (Step A1) */ >> - k->device_id = PCI_DEVICE_ID_INTEL_82371SB_0; >> - dc->vmsd = &vmstate_piix3; >> -} >> - >> -static const TypeInfo piix3_xen_info = { >> - .name = TYPE_PIIX3_XEN_DEVICE, >> - .parent = TYPE_PIIX_PCI_DEVICE, >> - .instance_init = piix3_init, >> - .class_init = piix3_xen_class_init, >> -}; >> - >> static void piix4_realize(PCIDevice *dev, Error **errp) >> { >> ERRP_GUARD(); >> @@ -534,7 +515,6 @@ static void piix3_register_types(void) >> { >> type_register_static(&piix_pci_type_info); >> type_register_static(&piix3_info); >> - type_register_static(&piix3_xen_info); >> type_register_static(&piix4_info); >> } >> >> diff --git a/include/hw/southbridge/piix.h b/include/hw/southbridge/piix.h >> index 65ad8569da..b1fc94a742 100644 >> --- a/include/hw/southbridge/piix.h >> +++ b/include/hw/southbridge/piix.h >> @@ -77,7 +77,6 @@ struct PIIXState { >> OBJECT_DECLARE_SIMPLE_TYPE(PIIXState, PIIX_PCI_DEVICE) >> >> #define TYPE_PIIX3_DEVICE "PIIX3" >> -#define TYPE_PIIX3_XEN_DEVICE "PIIX3-xen" >> #define TYPE_PIIX4_PCI_DEVICE "piix4-isa" >> >> #endif > > > This fixes the regression with the emulated usb tablet device that I reported in v1 here: > > https://lore.kernel.org/qemu-devel/aed4f2c1-83f7-163a-fb44-f284376668dc@aol.com/ > > I tested this patch again with all the prerequisites and now with v2 there are no regressions. > > Tested-by: Chuck Zmudzinski (IIUC Chuck meant to send this tag to the cover letter) From xen-devel-bounces@lists.xenproject.org Wed Jan 04 23:42:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 23:42:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471529.731407 (Exim 4.92) (envelope-from ) id 1pDDOI-0006LN-Co; Wed, 04 Jan 2023 23:41:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471529.731407; Wed, 04 Jan 2023 23:41:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDDOI-0006LG-A4; Wed, 04 Jan 2023 23:41:50 +0000 Received: by outflank-mailman (input) for mailman id 471529; Wed, 04 Jan 2023 23:41:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDDOG-0006LA-LP for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 23:41:48 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5962f51e-8c89-11ed-91b6-6bf2151ebd3b; Thu, 05 Jan 2023 00:41:46 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 21156B81916; Wed, 4 Jan 2023 23:41:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B2924C433F0; Wed, 4 Jan 2023 23:41:42 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5962f51e-8c89-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672875703; bh=Pn1GRpPj68jTuNTIPUm9liY//bIbQe9ac+YPKX51frY=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=T87xF5b90qc4fUXNB01GaoNNftjiBJ3x9vHzXdC4jCkZfY/k7PJO77JC7V/Umjvpl dm+JFEQJaCu9bKiQIMw9p0ZZo/+XUZ69O9Ij2vfnSkXMfw+z6TIQIf6xY9C5dH+ifa lLn/h5uHFR5Xgu1GgNDxiYFukww0nFVOHJ4Jir4/pTpApIUCOTjW2nL2r1x8ihTMhU 5kZQAVsBYppF1PXUtd73QgYMQfyETCzean+EFaKuc1nYOibbod5xSAwTx5zX0ASg2c 1htKIFymfFYeMwC7BtsPfvuSsk6D03fnJw12Eu0OnUMDWkKdUrCqwpIohYb9HGyYkN plqc0LDzl48iQ== Date: Wed, 4 Jan 2023 15:41:40 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: xen-devel@lists.xenproject.org, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH] xen/arm: Print memory size in decimal in construct_domU In-Reply-To: <20230102144904.17619-1-michal.orzel@amd.com> Message-ID: References: <20230102144904.17619-1-michal.orzel@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Mon, 2 Jan 2023, Michal Orzel wrote: > Printing domain's memory size in hex without even prepending it > with 0x is not very useful and can be misleading. Switch to decimal > notation. > > Signed-off-by: Michal Orzel Acked-by: Stefano Stabellini > --- > xen/arch/arm/domain_build.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 829cea8de84f..7e204372368c 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -3774,7 +3774,7 @@ static int __init construct_domU(struct domain *d, > if ( rc != 0 ) > return rc; > > - printk("*** LOADING DOMU cpus=%u memory=%"PRIx64"KB ***\n", d->max_vcpus, mem); > + printk("*** LOADING DOMU cpus=%u memory=%"PRIu64"KB ***\n", d->max_vcpus, mem); > > kinfo.vpl011 = dt_property_read_bool(node, "vpl011"); > > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Wed Jan 04 23:46:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 23:46:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471536.731418 (Exim 4.92) (envelope-from ) id 1pDDSl-0006yJ-U9; Wed, 04 Jan 2023 23:46:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471536.731418; Wed, 04 Jan 2023 23:46:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDDSl-0006yC-R7; Wed, 04 Jan 2023 23:46:27 +0000 Received: by outflank-mailman (input) for mailman id 471536; Wed, 04 Jan 2023 23:46:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDDSk-0006y6-KQ for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 23:46:26 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDDSi-0004aK-ND; Wed, 04 Jan 2023 23:46:24 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pDDSi-0007lI-9M; Wed, 04 Jan 2023 23:46:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=gmGTuusN/Cw77oybOwaLhW7XmTlkAMPzqinnHBSTdxg=; b=tYnmNNAk9EcGInkeuV7IWS/4yf xgx4FW5Jy8IZm7kO7iBuuv15RxiMUO+aR+2xzncu8Cche+m0nXKjhcQBlcoxWoRRrQkGB6EEV3247 EgNUa72ObOt25KWLqzjnIjEGIw/9TGYuHmSvrhZKyVGn29oR6VbrrH/0hZCvIIlgUsI0=; Message-ID: <2a343532-d324-e1ac-418c-5b34967d8de2@xen.org> Date: Wed, 4 Jan 2023 23:46:22 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH] xen/arm: Print memory size in decimal in construct_domU To: Stefano Stabellini , Michal Orzel Cc: xen-devel@lists.xenproject.org, Bertrand Marquis , Volodymyr Babchuk References: <20230102144904.17619-1-michal.orzel@amd.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Stefano, On 04/01/2023 23:41, Stefano Stabellini wrote: > On Mon, 2 Jan 2023, Michal Orzel wrote: >> Printing domain's memory size in hex without even prepending it >> with 0x is not very useful and can be misleading. Switch to decimal >> notation. >> >> Signed-off-by: Michal Orzel > > Acked-by: Stefano Stabellini Was this intended for v2 rather than v1? Cheers, > > >> --- >> xen/arch/arm/domain_build.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c >> index 829cea8de84f..7e204372368c 100644 >> --- a/xen/arch/arm/domain_build.c >> +++ b/xen/arch/arm/domain_build.c >> @@ -3774,7 +3774,7 @@ static int __init construct_domU(struct domain *d, >> if ( rc != 0 ) >> return rc; >> >> - printk("*** LOADING DOMU cpus=%u memory=%"PRIx64"KB ***\n", d->max_vcpus, mem); >> + printk("*** LOADING DOMU cpus=%u memory=%"PRIu64"KB ***\n", d->max_vcpus, mem); >> >> kinfo.vpl011 = dt_property_read_bool(node, "vpl011"); >> >> -- >> 2.25.1 >> -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Jan 04 23:47:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 23:47:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471544.731429 (Exim 4.92) (envelope-from ) id 1pDDTX-0007VJ-5m; Wed, 04 Jan 2023 23:47:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471544.731429; Wed, 04 Jan 2023 23:47:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDDTX-0007VC-32; Wed, 04 Jan 2023 23:47:15 +0000 Received: by outflank-mailman (input) for mailman id 471544; Wed, 04 Jan 2023 23:47:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDDTV-0007SD-Lv for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 23:47:13 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1b2d6673-8c8a-11ed-b8d0-410ff93cb8f0; Thu, 05 Jan 2023 00:47:11 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4EF6A6187C; Wed, 4 Jan 2023 23:47:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9FBF5C433D2; Wed, 4 Jan 2023 23:47:08 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1b2d6673-8c8a-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672876029; bh=AZmbvsghGNSym+NrkscJbs9ahmzLtFbFNacMjbGYpbo=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=MOaeIY2A/RZ7PfRSiRQV+AgR6jgq7o7btLpGBsmnc/L7qfU/t3Amws5Vryaxdg15l cjgKdLMT9T1HLTr1UdmdX8LshhkFY49kSRUO1zIRcsh1S93223IqS+YxsMIkODOxOo CuBz0UknlgLr38DRhFIeoz3HrJm8nG/DXMOFbIXbPmqGbH3qLfwutEtTtn1pVfvKOC +awgPZLeVQD2Q775dnbPoEIiwa3rd9hvTWLSDKtuMnwHCzQPPY/6SXT3bcKi/d/pHU aKKHnTrUtCPKevWKNr5dn8Pc891tlOmpxl/7SG9mkZZeOn6b1aRWgXudMgetsfqqmS FEqYEkBl5IyZg== Date: Wed, 4 Jan 2023 15:47:06 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: xen-devel@lists.xenproject.org, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH v2] xen/arm: Add 0x prefix when printing memory size in construct_domU In-Reply-To: <20230103102519.26224-1-michal.orzel@amd.com> Message-ID: References: <20230103102519.26224-1-michal.orzel@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 3 Jan 2023, Michal Orzel wrote: > Printing memory size in hex without 0x prefix can be misleading, so > add it. Also, take the opportunity to adhere to 80 chars line length > limit by moving the printk arguments to the next line. > > Signed-off-by: Michal Orzel > --- > Changes in v2: > - was: "Print memory size in decimal in construct_domU" > - stick to hex but add a 0x prefix > - adhere to 80 chars line length limit Honestly I prefer decimal but also hex is fine. I'll let Julien pick the version of this patch that he prefers. > --- > xen/arch/arm/domain_build.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 829cea8de84f..f35f4d24569c 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -3774,7 +3774,8 @@ static int __init construct_domU(struct domain *d, > if ( rc != 0 ) > return rc; > > - printk("*** LOADING DOMU cpus=%u memory=%"PRIx64"KB ***\n", d->max_vcpus, mem); > + printk("*** LOADING DOMU cpus=%u memory=%#"PRIx64"KB ***\n", > + d->max_vcpus, mem); > > kinfo.vpl011 = dt_property_read_bool(node, "vpl011"); > > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Wed Jan 04 23:48:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 23:48:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471552.731439 (Exim 4.92) (envelope-from ) id 1pDDUP-000858-FJ; Wed, 04 Jan 2023 23:48:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471552.731439; Wed, 04 Jan 2023 23:48:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDDUP-000851-Ci; Wed, 04 Jan 2023 23:48:09 +0000 Received: by outflank-mailman (input) for mailman id 471552; Wed, 04 Jan 2023 23:48:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDDUO-0007SD-Dt for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 23:48:08 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3c679f56-8c8a-11ed-b8d0-410ff93cb8f0; Thu, 05 Jan 2023 00:48:06 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2AE95B81717; Wed, 4 Jan 2023 23:48:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D5681C433D2; Wed, 4 Jan 2023 23:48:03 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3c679f56-8c8a-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672876084; bh=fjUjCM6/dbAhaWVyakEsxbpi0WIuGmgOsRwOzF62oD0=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=oXOAFC6/JyOvB7WzvJ+IAdutVCqCBX2EcQZJeEm6iWJociOiZ/IJ1rXkWfckuc1iW bwX/po1vMsNVr+VUzomE7vm5n2VOoM5oYVBjMssb30lozxzFb+H5mpekIqzQU/VMRm K+crZSzrqKZ4O/aLkSSkneVYxmw85WW9tDn2BGPoh2GIioKPNEA7bbuJmboOpvzeo/ 9ZqbIuKKzqqJg4QMOHn/gSJ22Iq4LRVXyYdZ3+cOyWwXQzol8frNanL58ynGQrcn93 0FU75BeZ7pBPE7FRqlPo/aP37PrdXY4+OPwpD3WVmNktV8kgRWZNSp4CkqWBlFXcNu 5a4Kw/PfnlbGQ== Date: Wed, 4 Jan 2023 15:48:02 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Julien Grall cc: Stefano Stabellini , Michal Orzel , xen-devel@lists.xenproject.org, Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH] xen/arm: Print memory size in decimal in construct_domU In-Reply-To: <2a343532-d324-e1ac-418c-5b34967d8de2@xen.org> Message-ID: References: <20230102144904.17619-1-michal.orzel@amd.com> <2a343532-d324-e1ac-418c-5b34967d8de2@xen.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 4 Jan 2023, Julien Grall wrote: > Hi Stefano, > > On 04/01/2023 23:41, Stefano Stabellini wrote: > > On Mon, 2 Jan 2023, Michal Orzel wrote: > > > Printing domain's memory size in hex without even prepending it > > > with 0x is not very useful and can be misleading. Switch to decimal > > > notation. > > > > > > Signed-off-by: Michal Orzel > > > > Acked-by: Stefano Stabellini > > Was this intended for v2 rather than v1? I didn't notice v2 was already out. I did test v2 and made sure it is working so go ahead and pick whichever version you prefer > > > --- > > > xen/arch/arm/domain_build.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > > > index 829cea8de84f..7e204372368c 100644 > > > --- a/xen/arch/arm/domain_build.c > > > +++ b/xen/arch/arm/domain_build.c > > > @@ -3774,7 +3774,7 @@ static int __init construct_domU(struct domain *d, > > > if ( rc != 0 ) > > > return rc; > > > - printk("*** LOADING DOMU cpus=%u memory=%"PRIx64"KB ***\n", > > > d->max_vcpus, mem); > > > + printk("*** LOADING DOMU cpus=%u memory=%"PRIu64"KB ***\n", > > > d->max_vcpus, mem); > > > kinfo.vpl011 = dt_property_read_bool(node, "vpl011"); > > > > > > -- > > > 2.25.1 > > > > > -- > Julien Grall > From xen-devel-bounces@lists.xenproject.org Wed Jan 04 23:56:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 Jan 2023 23:56:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471559.731450 (Exim 4.92) (envelope-from ) id 1pDDcc-0001AS-AA; Wed, 04 Jan 2023 23:56:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471559.731450; Wed, 04 Jan 2023 23:56:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDDcc-0001AL-7W; Wed, 04 Jan 2023 23:56:38 +0000 Received: by outflank-mailman (input) for mailman id 471559; Wed, 04 Jan 2023 23:56:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDDca-0001AF-Gx for xen-devel@lists.xenproject.org; Wed, 04 Jan 2023 23:56:36 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6ae9959b-8c8b-11ed-91b6-6bf2151ebd3b; Thu, 05 Jan 2023 00:56:34 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9B8D860B9F; Wed, 4 Jan 2023 23:56:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A2207C433EF; Wed, 4 Jan 2023 23:56:31 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6ae9959b-8c8b-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672876593; bh=56exPYTrVJWailpagQVD//cB5k6Ua23keldYMrZSHMY=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=Su5w5hidKmUJHpqaiIg43YfZ5DqaZRZnsFtd8qaBvscpk7h+GUD9IH2B31Dw/GxUb aqBFyUghI89tZyLqOB2ZBSzLraI6AX6MQWt5pB6gqrKxJ4Wp5lvS6cUhG+h7CILDpO JgkMSG7YmFLW7eOLuGM9Lb+TRoDf+l3prPj2Cf+ctNnzr1I6ISw1cHYQjrui8L1seM sZnNCKPxMTxfvFZJcHM+Fl9bjr/rEBJa7ZKhtBzEC/cU8wMVj6PlxQmK1XBx7wjXZ8 uBO9v9e68rRru1pft3Dk6Anx0AfFUmLnnevjVewxZfjEyhNIKOYhBWigFrVez2OTB3 JWL9EUVUH4uJQ== Date: Wed, 4 Jan 2023 15:56:29 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Julien Grall cc: Ayan Kumar Halder , Stefano Stabellini , Ayan Kumar Halder , xen-devel@lists.xenproject.org, stefano.stabellini@amd.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com Subject: Re: [XEN v1 2/9] xen/arm: Define translate_dt_address_size() for the translation between u64 and paddr_t In-Reply-To: <5898da03-9947-1540-f424-d76c715619f4@xen.org> Message-ID: References: <20221215193245.48314-1-ayan.kumar.halder@amd.com> <20221215193245.48314-3-ayan.kumar.halder@amd.com> <74786a57-d99a-6cfe-f475-df11c0d93afa@xen.org> <5bc9435e-aee9-006c-a35a-ee9c7f946f91@amd.com> <5898da03-9947-1540-f424-d76c715619f4@xen.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-1427513259-1672876592=:4079" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1427513259-1672876592=:4079 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Fri, 23 Dec 2022, Julien Grall wrote: > On 23/12/2022 10:01, Ayan Kumar Halder wrote: > > Hi Julien/Stefano, > > > > I want to make sure I understand correctly. > > > > On 22/12/2022 23:20, Stefano Stabellini wrote: > > > On Sat, 17 Dec 2022, Julien Grall wrote: > > > > On 17/12/2022 00:46, Stefano Stabellini wrote: > > > > > On Fri, 16 Dec 2022, Julien Grall wrote: > > > > > > Hi Ayan, > > > > > > > > > > > > On 15/12/2022 19:32, Ayan Kumar Halder wrote: > > > > > > > paddr_t may be u64 or u32 depending of the type of architecture. > > > > > > > Thus, while translating between u64 and paddr_t, one should check > > > > > > > that > > > > > > > the > > > > > > > truncated bits are 0. If not, then raise an appropriate error. > > > > > > I am not entirely convinced this extra helper is worth it. If the > > > > > > user > > > > > > can't > > > > > > provide 32-bit address in the DT, then there are also a lot of other > > > > > > part > > > > > > that > > > > > > can go wrong. > > > > > > > > > > > > Bertrand, Stefano, what do you think? > > > > > In general, it is not Xen's job to protect itself against bugs in > > > > > device > > > > > tree. However, if Xen spots a problem in DT and prints a helpful > > > > > message > > > > > that is better than just crashing because it gives a hint to the > > > > > developer about what the problem is. > > > > I agree with the principle. In practice this needs to be weight out with > > > > the > > > > long-term maintenance. > > > > > > > > > In this case, I think a BUG_ON would be sufficient. > > > > BUG_ON() is the same as panic(). They both should be used only when > > > > there are > > > > no way to recover (see CODING_STYLE). > > > > > > > > If we parse the device-tree at boot, then BUG_ON() is ok. However, if we > > > > need > > > > to parse it after boot (e.g. the DT overlay from Vikram), then we should > > > > definitely not call BUG_ON() for checking DT input. > > > yeah, I wasn't thinking of that series > > > > > > > > > > The correct way is like Ayan did by checking returning an error and let > > > > the caller deciding what to do. > > > > > > > > My concern with his approach is the extra amount of code in each caller > > > > to > > > > check it (even with a new helper). > > > > > > > > I am not fully convinced that checking the addresses in the DT is that > > > > useful. > > > I am also happy not to do it to be honest > > > > So are you suggesting that we do the truncation, but do not check if any non > > zero bits have been truncated. > > > > As an example, currently with this patch :- > > > > -        device_tree_get_reg(&cells, addr_cells, addr_cells, &pbase, > > &gbase); > > -        psize = dt_read_number(cells, size_cells); > > +        device_tree_get_reg(&cells, addr_cells, addr_cells, &dt_pbase, > > &dt_gbase); > > +        ret = translate_dt_address_size(&dt_pbase, &dt_gbase, &pbase, > > &gbase); > > +        if ( ret ) > > +            return ret; > > +        dt_psize = dt_read_number(cells, size_cells); > > +        ret = translate_dt_address_size(NULL, &dt_psize, NULL, &psize); > > > > > > With your proposed change, it should be > > > > -        device_tree_get_reg(&cells, addr_cells, addr_cells, &pbase, > > &gbase); > > -        psize = dt_read_number(cells, size_cells); > > +        device_tree_get_reg(&cells, addr_cells, addr_cells, &dt_pbase, > > &dt_gbase); > > +        dt_psize = dt_read_number(cells, size_cells); > > +        pbase = (paddr_t) dt_pbase; > > +        gbase = (paddr_t) dt_gbase; > > +        psize = (paddr_t) dt_psize; > > -ETOOMANY cast and lines (the more if this is expected to be duplicated). But > the last one seems unnecessary as the only reason you need separate variable > for pbase and gbase is because the function are taking a reference rather than > returning the value. > > > > Because, we still need some way to convert u64 dt address/size to paddr_t > > (u64/u32) address/size. > How about following the approach I suggested in my previous e-mail to Stefano: > - Convert device_tree_get_reg() to use paddr_t. I think this is OK > - Introduce dt_device_get_address_checked() (Assuming you want to still add > the check) Let's just skip the check > We may need an helper to wrap around dt_read_number() but I don't have a good > idea for a name. There are only a couple of use. So I think it is fine to > open-code. But you would not need a separate local variable. For the cast, I > am in two mind. In one way, I don't like unnecessary explicit cast, but on the > other way it serves as documentation. > > Stefano, any opinions? I would not add a wrapper for dt_read_number() and open-code the cast, like you said because something non-trivial is happening and it serves as documentation: psize = (paddr_t) dt_read_number(cells, size_cells); --8323329-1427513259-1672876592=:4079-- From xen-devel-bounces@lists.xenproject.org Thu Jan 05 01:57:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 01:57:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471567.731462 (Exim 4.92) (envelope-from ) id 1pDFVY-00076D-AN; Thu, 05 Jan 2023 01:57:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471567.731462; Thu, 05 Jan 2023 01:57:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDFVY-000765-6H; Thu, 05 Jan 2023 01:57:28 +0000 Received: by outflank-mailman (input) for mailman id 471567; Thu, 05 Jan 2023 01:57:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDFVW-00075z-5Z for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 01:57:26 +0000 Received: from sonic313-21.consmr.mail.gq1.yahoo.com (sonic313-21.consmr.mail.gq1.yahoo.com [98.137.65.84]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4a147cf7-8c9c-11ed-91b6-6bf2151ebd3b; Thu, 05 Jan 2023 02:57:23 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.gq1.yahoo.com with HTTP; Thu, 5 Jan 2023 01:57:19 +0000 Received: by hermes--production-ne1-7b69748c4d-pm9xv (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 5ad7388ff1f2f81a903f2d20066a3dfd; Thu, 05 Jan 2023 01:57:17 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a147cf7-8c9c-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1672883839; bh=r+wBx6/58Y0GMmVdloTVPnv7cslaN9V9d73StXKUUQ0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=JmEijnJdY7xyeLtDVlvC20MAJx8IVALM9Pronf2NQS5j2l+f/wyRWYl8J7cSEL1zZ/TBkznsom4bDOkSXrw/XcvyL7owSzB6dxmFzPeJib1Zy9A0rWSoUJivzXbvtyA2RxXTPsinXKkTtu9tkl86TPOEXRc987IAoYishhEsbeiUVjoMIzHxILCKyh1w6XAlokZae5Sya9UZhJPJ3SnJmQ87DYWxjw0CWgk6dlguWRSnEGdHkZObZTA7i5SjHUhnmKH6sTzyJcGTdqV1AoWbM7W1Fmisas+fc9Qhp2pkiFaSiObE80HbloNAvyvVAS3d2dS07orDtWsHH3T/4Qn00Q== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1672883839; bh=qg/iaLMBO19KpWjwfX+oJMpEdkALXNVjTEsgw++ocL1=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=Jl3jLKW6kJoI4mpVi3z0GUCtoMhc80+fdQm1ekRJM9kvEsYPDFIb32xyltXBCZ9HgLYdNS/aMleLo6aqT2VpFqXLQN03CHmBs0R2x2P/NzE4eJmSs9VZeBcy6E/1dQOoJwlOE6y1TU75iAdruTlWFO8UyyMfDQeFubEC82HPzmFWhQBJFqUxRBz1Cwm8/RcA2cv9AR/C2fTgLGCS8lBbzh/XdMA5ciblp1NoXuDF7Fhq4Ow1GX+OiOvnO//g+P7+nOAErfyHDUmn+9I9zZAC4kT+U6m6utWqAe/RmcS0vXHhgg3ZoN5t2dIYjxiBE2Ei7RBd4WfigmUqYm59nI1tvw== X-YMail-OSG: mjPnh2wVM1nYlFHG1wPD0LqgcsVvFTHn2zlCr52Dzy1RRgwnNgMIwbrqc4UBZGW g5ebvmD1XpHnv1qJa0ceI2rXtq7yKR4hXgB_ZH0jxMlETJLq71y3iSC0NEAPfPwwoYNlf.ldIRE_ HLdZ7oEBSC.J1BQLzMIf9Il0dtXUjp0kZ.ASo_.KMnRvNB8L24NPVNOtcPHWcPFg_YVMx67_fmdr a45OA3cPlGxb86tn00WW7rkTa2Xc4FLzYpca1x.jdXUPn6NhSfTy98PGszTLbXOOSkbRTZrPf3nP 8ovNSzyuYe_c8kPbQNx5rpSZ5Zb4Swa0.4Opn9HZyG7fP1E.kxe67v0fDYbPnlgW3u5r2XdxJoGB n3plPYn2GNgeI6ZaHY2yJ4v1bzYrT_cAErxOe6gRPyfJ94Yly4eODm8meQUXiAqXQo_i.oXPc5BR FNgZdlu10FhvSQKfUQtntd2iw7y05.CQ9BBfTrVMFmbAJES1npSRO.nD8srXa2kAKvqLtEv9Ht0e _8X8zCzbSUkeL7V.5cHxdaR2f_icGCM_DZmF8q.TNn3TmaMav2Yp__GgviyofishrFTMvnmIkV.F KKI4n6Qd9YogKRB8WsMjUAxp0FW.HWECFmPCs9ba4yn43bP_RPOCV4PH4EJWjgDhzdAB1dsVkHdb 5kkzNdlfsbDGrLUnzXHbSfrlptw6Agzorify.3O6kAky6kVg0lY_M4Dpa.xlvp8CLZqZbKbXXOzC szIklmCmFFMmOZTNZ5bC0gGNOrNcMN1zK9dqkO8DkEcOuF72l.VSaM4dR1.UQBw6t_Sb_vrzkE7z McxI9ddM8CoqUgYru0LQMrNSqcB8TuO3kzf7SbCRd_6hfnrzEgzoqq7jVy6cA62v20HcZLAMAn9r euEyQSoRT6UeekL2dP.OShWP4pzepNfCAfElTVs2NpNKLtRpo1A2TUZo73dZBKjG9rjkKsbuvrI7 ONc9_sSSQUmHcn3VSIiJXKg2OWEgre9X6WaBnG0hMShrf7lvHfW60anLl6n60e_o5OC_uMdFN2f. gnC2FStCvECDumMpX9KygOO5VwdjgaRd7GRiZDKsvu5.oCPikWciYNhnxlLnTkv2l4NAaUQCHyDF 7m4otnDOios1oFtwVEWqhZnv5VYpLwTuQtZOAHb6FTNYZV1gtvX4IKac5gVNcApHRDz8srn5hqY7 bBvYjOgJ.VMss7FmxUQjQpefvgJTREgV2wTWskEEVEbXAUu8rreb6MlmLBn5G4uE9jDTQNtXosG_ 0BJoKG3_viYet2.QkErR2MZ2fwOmAJUarluIzNzGdvdpui4Ve0eFVaHepwuNS1yu.EFkMnr5IwUY ooi0k4yntguWPgpANsLKjAn2_Z8SudR3lzdWgA4QDtwgJfWaRy0P4Ev0KQyGcMQLG6iNf3j1tsYR EgBILItCsp8mF50BaLtms10i6c0H_bwdkWUp1Qz0XzP_G1qN_FYh4SkLJ0XMxJoIldZpdZ54kp7F qwPoHd75eKQ4X92k_uoOpgB8bjfwmv3iiJmlSbVJp.8z87SvSUx2up9EImRQZrcSGk56_robF42B Cz52dSFnu7s4W3pQxdhIExa7Fpo8Byib_VsBqla9vfEqTHHXUJnbFwpa3QkjHChEYeyBz5pHrQ23 yH7zBb8wjQ_CgT4EWXdwUEb0O8M__9OILjCX7_cU7Aphthwul1guay2suGMcY86nAeBgDon7jGjZ v5FP7EJvVFblYTpR_T0L.aDUmyy6ouFC8LzxjIy0h0l2jF_WoIv03g5jf8MHRfO4upQBtqIrcBic TWaNPYL_qdH_nofo30E1kG.7L_1x1Xx2FrBMc6Ul3bgKTefvevqpSwNr8CRiSdywV1E0j_t0LsKW IhXIQkosmqklw12RKKQ2SWZ2zTFOZgIQewHkekRfSrhbWfF3U4dD6Fec5s9OovQid1AUjO0IliiS Wk4R5y1VSX.9Q7Tv52jIk_SooNCyPt3XCFtVKm_aI7N6.jWY_y.JHDxFn4BBmD0BIhJHB8ofr6Q9 GIAuKpRqsfMsj.KnqSXPf6cPHVR__vz7_tfhcmAycjk2HfN0KWHu_n7FV9qL.rZITE5_LPoObwZZ sFwKjYk_DH1k10OPdGiiNouED_leV0LDP4ZzPi6y8quR_.Cygj8nrjidYA5WfIZ3M.mflmlcn5rR q2wxP2G3Dc_IaYgzogP0bQZvK4vVqpZiIjRcYgLDKOo_RT28_3IKyL9D7GqGIa2n6OoJeyAI6ZQ1 r6AhHWSu87w57eeuePB4CVSNQfHE- X-Sonic-MF: Message-ID: <1353bd20-0edb-ed66-5c1f-9d117a76c372@aol.com> Date: Wed, 4 Jan 2023 20:57:14 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v2 6/6] hw/isa/piix: Resolve redundant TYPE_PIIX3_XEN_DEVICE Content-Language: en-US To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Bernhard Beschow , qemu-devel@nongnu.org Cc: Richard Henderson , Stefano Stabellini , xen-devel@lists.xenproject.org, =?UTF-8?Q?Herv=c3=a9_Poussineau?= , Aurelien Jarno , Paul Durrant , Marcel Apfelbaum , Anthony Perard , "Michael S. Tsirkin" , Paolo Bonzini , Eduardo Habkost References: <20230104144437.27479-1-shentey@gmail.com> <20230104144437.27479-7-shentey@gmail.com> <30ed41ab-f7c9-15fb-8f4b-b2742b1d4188@aol.com> <405dc396-7b7e-842a-2b94-6b26df1aa564@linaro.org> From: Chuck Zmudzinski In-Reply-To: <405dc396-7b7e-842a-2b94-6b26df1aa564@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.20982 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 4127 On 1/4/23 5:35 PM, Philippe Mathieu-Daudé wrote: > On 4/1/23 17:42, Chuck Zmudzinski wrote: >> On 1/4/23 9:44 AM, Bernhard Beschow wrote: >>> During the last patches, TYPE_PIIX3_XEN_DEVICE turned into a clone of >>> TYPE_PIIX3_DEVICE. Remove this redundancy. >>> >>> Signed-off-by: Bernhard Beschow >>> --- >>> hw/i386/pc_piix.c | 4 +--- >>> hw/isa/piix.c | 20 -------------------- >>> include/hw/southbridge/piix.h | 1 - >>> 3 files changed, 1 insertion(+), 24 deletions(-) >>> >>> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c >>> index 5738d9cdca..6b8de3d59d 100644 >>> --- a/hw/i386/pc_piix.c >>> +++ b/hw/i386/pc_piix.c >>> @@ -235,8 +235,6 @@ static void pc_init1(MachineState *machine, >>> if (pcmc->pci_enabled) { >>> DeviceState *dev; >>> PCIDevice *pci_dev; >>> - const char *type = xen_enabled() ? TYPE_PIIX3_XEN_DEVICE >>> - : TYPE_PIIX3_DEVICE; >>> int i; >>> >>> pci_bus = i440fx_init(pci_type, >>> @@ -250,7 +248,7 @@ static void pc_init1(MachineState *machine, >>> : pci_slot_get_pirq); >>> pcms->bus = pci_bus; >>> >>> - pci_dev = pci_new_multifunction(-1, true, type); >>> + pci_dev = pci_new_multifunction(-1, true, TYPE_PIIX3_DEVICE); >>> object_property_set_bool(OBJECT(pci_dev), "has-usb", >>> machine_usb(machine), &error_abort); >>> object_property_set_bool(OBJECT(pci_dev), "has-acpi", >>> diff --git a/hw/isa/piix.c b/hw/isa/piix.c >>> index 98e9b12661..e4587352c9 100644 >>> --- a/hw/isa/piix.c >>> +++ b/hw/isa/piix.c >>> @@ -33,7 +33,6 @@ >>> #include "hw/qdev-properties.h" >>> #include "hw/ide/piix.h" >>> #include "hw/isa/isa.h" >>> -#include "hw/xen/xen.h" >>> #include "sysemu/runstate.h" >>> #include "migration/vmstate.h" >>> #include "hw/acpi/acpi_aml_interface.h" >>> @@ -465,24 +464,6 @@ static const TypeInfo piix3_info = { >>> .class_init = piix3_class_init, >>> }; >>> >>> -static void piix3_xen_class_init(ObjectClass *klass, void *data) >>> -{ >>> - DeviceClass *dc = DEVICE_CLASS(klass); >>> - PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); >>> - >>> - k->realize = piix3_realize; >>> - /* 82371SB PIIX3 PCI-to-ISA bridge (Step A1) */ >>> - k->device_id = PCI_DEVICE_ID_INTEL_82371SB_0; >>> - dc->vmsd = &vmstate_piix3; >>> -} >>> - >>> -static const TypeInfo piix3_xen_info = { >>> - .name = TYPE_PIIX3_XEN_DEVICE, >>> - .parent = TYPE_PIIX_PCI_DEVICE, >>> - .instance_init = piix3_init, >>> - .class_init = piix3_xen_class_init, >>> -}; >>> - >>> static void piix4_realize(PCIDevice *dev, Error **errp) >>> { >>> ERRP_GUARD(); >>> @@ -534,7 +515,6 @@ static void piix3_register_types(void) >>> { >>> type_register_static(&piix_pci_type_info); >>> type_register_static(&piix3_info); >>> - type_register_static(&piix3_xen_info); >>> type_register_static(&piix4_info); >>> } >>> >>> diff --git a/include/hw/southbridge/piix.h b/include/hw/southbridge/piix.h >>> index 65ad8569da..b1fc94a742 100644 >>> --- a/include/hw/southbridge/piix.h >>> +++ b/include/hw/southbridge/piix.h >>> @@ -77,7 +77,6 @@ struct PIIXState { >>> OBJECT_DECLARE_SIMPLE_TYPE(PIIXState, PIIX_PCI_DEVICE) >>> >>> #define TYPE_PIIX3_DEVICE "PIIX3" >>> -#define TYPE_PIIX3_XEN_DEVICE "PIIX3-xen" >>> #define TYPE_PIIX4_PCI_DEVICE "piix4-isa" >>> >>> #endif >> >> >> This fixes the regression with the emulated usb tablet device that I reported in v1 here: >> >> https://lore.kernel.org/qemu-devel/aed4f2c1-83f7-163a-fb44-f284376668dc@aol.com/ >> >> I tested this patch again with all the prerequisites and now with v2 there are no regressions. >> >> Tested-by: Chuck Zmudzinski > > (IIUC Chuck meant to send this tag to the cover letter) > Yes, I tested the whole patch series, not just this individual patch. I tagged this one because it is the last patch in the series. From xen-devel-bounces@lists.xenproject.org Thu Jan 05 02:14:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 02:14:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471574.731473 (Exim 4.92) (envelope-from ) id 1pDFlu-0001Oq-N8; Thu, 05 Jan 2023 02:14:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471574.731473; Thu, 05 Jan 2023 02:14:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDFlu-0001Oj-KQ; Thu, 05 Jan 2023 02:14:22 +0000 Received: by outflank-mailman (input) for mailman id 471574; Thu, 05 Jan 2023 02:14:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDFlt-0001OZ-Pp; Thu, 05 Jan 2023 02:14:21 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDFlt-0002RZ-MU; Thu, 05 Jan 2023 02:14:21 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDFlt-0002Y6-83; Thu, 05 Jan 2023 02:14:21 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pDFlt-0002X1-7Q; Thu, 05 Jan 2023 02:14:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=XCzpgb5IkVcTARFvF29hxA051Lbxm63kHERRJiL5RZQ=; b=ZcUqICi0V9GdK29Z8g3ETj4hl1 5uUZ3jOSVFx1Oyyc00h0UB5FKh3QIE97K7md7kxTHcZwV/zQvSBixEgI1j7WV+NIN2J3sAfahj4+F qRd5xyxxThHzOYnCBBGKSujP0SRtbHrOCW/Rh/FkEQYzlKE75iDgP1DHru9exuMNVUME=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 175569: regressions - FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-migrupgrade:xen-install/src_host:fail:regression xen-unstable:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:regression xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=c1df06afe578f698ebe91a1e3817463b9d165123 X-Osstest-Versions-That: xen=7eef80e06ed2282bbcec3619d860c6aacb0515d8 From: osstest service owner Date: Thu, 05 Jan 2023 02:14:21 +0000 flight 175569 xen-unstable real [real] flight 175572 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/175569/ http://logs.test-lab.xenproject.org/osstest/logs/175572/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-migrupgrade 10 xen-install/src_host fail REGR. vs. 175562 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail REGR. vs. 175562 Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail pass in 175572-retest test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail pass in 175572-retest Tests which did not succeed, but are not blocking: test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail like 175520 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 175562 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175562 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 175562 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175562 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175562 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 175562 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 175562 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 175562 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 175562 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 175562 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175562 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 175562 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen c1df06afe578f698ebe91a1e3817463b9d165123 baseline version: xen 7eef80e06ed2282bbcec3619d860c6aacb0515d8 Last test of basis 175562 2023-01-04 01:55:19 Z 1 days Testing same since 175569 2023-01-04 16:38:42 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit c1df06afe578f698ebe91a1e3817463b9d165123 Author: Andrew Cooper Date: Thu Dec 29 22:19:40 2022 +0000 CI: Simplify the MUSL check There's no need to do ad-hoc string parsing. Use grep -q instead. No functional change. Signed-off-by: Andrew Cooper Reviewed-by: Stefano Stabellini commit df57a2c8da7acb14f3feac823f2fcbeef56899b2 Author: Andrew Cooper Date: Thu Dec 29 21:46:50 2022 +0000 CI: Fix build script when CROSS_COMPILE is in use Some testcases use a cross compiler. Presently it's only arm32 and due to previous cleanup the only thing which is now wrong is printing the compiler version at the start of day. Construct $cc to match what `make` will eventually choose given CROSS_COMPILE, taking care not to modify $CC. Use $cc throughout the rest of the script. Also correct the compiler detection logic. Plain "gcc" was wrong, and "clang"* was a bodge highlighting the issue, but neither survive the CROSS_COMPILE correction. Instead, construct cc_is_{gcc,clang} booleans like we do elsewhere in the build system, by querying the --version text for gcc or clang. While making this change, adjust cc_ver to be calculated once at the same time as cc_is_* are calculated. Signed-off-by: Andrew Cooper Reviewed-by: Stefano Stabellini commit d329ca6baf51b229f866af2542cfdc0d5f5a4c2c Author: Andrew Cooper Date: Thu Dec 29 15:52:50 2022 +0000 CI: Express HYPERVISOR_ONLY in build.yml Whether to build only Xen, or everything, is a property of container, toolchain and/or testcase. It is not a property of XEN_TARGET_ARCH. Capitalise HYPERVISOR_ONLY and have it set by all the debian-unstable-gcc-arm32-* testcases at the point that arm32 get matched with a container that can only build Xen. To reduce the churn elsewhere, retain the RANDCONFIG implies HYPERVISOR_ONLY property. Signed-off-by: Andrew Cooper Reviewed-by: Stefano Stabellini commit 2eb750242101f0b9c17688a09825ba6befbab113 Author: Andrew Cooper Date: Thu Dec 29 20:05:33 2022 +0000 CI: Only calculate ./configure args if needed This is purely code motion of the cfgargs construction, into the case where it is used. No practical change. Signed-off-by: Andrew Cooper Reviewed-by: Michal Orzel Reviewed-by: Stefano Stabellini commit b67625568448480eaa432d9637431ff7b1f62aa0 Author: Andrew Cooper Date: Thu Dec 29 20:01:52 2022 +0000 CI: Remove guesswork about which artefacts to preserve Preserve the artefacts based on the `make` rune we actually ran, rather than guesswork about which rune we would have run based on other settings. Note that the ARM qemu smoke tests depend on finding binaries/xen even from full builds. Also the Jessie-32 containers build tools but not Xen. This means the x86_32 builds now store relevant artefacts. No change in other configurations. Signed-off-by: Andrew Cooper Reviewed-by: Stefano Stabellini commit 7b20009a812f26e74bdbde2ab96165376b3dad34 Author: Andrew Cooper Date: Thu Dec 29 15:39:13 2022 +0000 CI: Drop automation/configs/ Having 3 extra hypervisor builds on the end of a full build is deeply confusing to debug if one of them fails, because the .config file presented in the artefacts is not the one which caused a build failure. Also, the log tends to be truncated in the UI. PV-only is tested as part of PV-Shim in a full build anyway, so doesn't need repeating. HVM-only and neither appear frequently in randconfig, so drop all the logic here to simplify things. Signed-off-by: Andrew Cooper Reviewed-by: Michal Orzel Reviewed-by: Stefano Stabellini (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Thu Jan 05 02:25:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 02:25:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471585.731484 (Exim 4.92) (envelope-from ) id 1pDFwf-0002y6-TT; Thu, 05 Jan 2023 02:25:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471585.731484; Thu, 05 Jan 2023 02:25:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDFwf-0002xz-Pi; Thu, 05 Jan 2023 02:25:29 +0000 Received: by outflank-mailman (input) for mailman id 471585; Thu, 05 Jan 2023 02:25:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDFwe-0002xt-HP for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 02:25:28 +0000 Received: from sonic315-55.consmr.mail.gq1.yahoo.com (sonic315-55.consmr.mail.gq1.yahoo.com [98.137.65.31]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 35810b64-8ca0-11ed-b8d0-410ff93cb8f0; Thu, 05 Jan 2023 03:25:25 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic315.consmr.mail.gq1.yahoo.com with HTTP; Thu, 5 Jan 2023 02:25:23 +0000 Received: by hermes--production-ne1-7b69748c4d-bmdl9 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID b445f58ecae7df5da904de2ba90d4713; Thu, 05 Jan 2023 02:25:20 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 35810b64-8ca0-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1672885523; bh=9/D7me0E4of8lPWTP1WaFa8eMBIgzfn0nOyeytivp40=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=RTy8KAQq4Zw4/69W08n3xkrG3E08Z+y1eboEZBZRR9yKIz1FTqCFNyXWHafN9KSYzRofahHXPiBLQWYDhYo3EAO79pKAc+giesAILPO/E5eH0aVTOQJqNleOJADkxJUID5vwporLLHurAopOn9Y3PTjMo2Iq3iNoI5uAnD4OCdNcp5aQ0NSpDdjMeOQH6JcXPJzKVor9I2bhS5t1dydDhSVt4d9UImxyaEjyxcP57sgvgwrqicVHVl8L5qP8QzK7MnnqPLJVxTWey5k5ro6Rlncdhbe2EFzBRjAjKStyHH7ZB5Af9iQJ+NgD5zUiztVKdO2HjTRDq8eirqLSgeIYLA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1672885523; bh=bN+9ECMIMdaEvR4AWB7Sp8ghwy8CXF4zhl6GI6si8jq=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=PTm4dMsLtVuKTYjVRDQ8L8PZIRqFpGGYrPtfMgY85YL4VLzAjnsDyEdehEjJqs6JLlQEKfqNf8fmpF+NJ3Y4ooLGjTgL5XfeN9QjyEa/AaF8fW1dLJuBT3IJwgF/cfzTMOlb4CcJI+ym/vppY6nAYZTZZMmhY7LmQm/9nqwyb+ruKcv9FGcVXHWDsoDdHL6+oCtalYYRUIF0RlMiLqi2rJUXOzC8hWfcatsB7tlt3npiVeytAyTRWfdg9/f4k1dNpWaCGRkToOXTpAOcsyrqND/KrTLu4JTboEqN0RO5vvU/6MZslVZB9vcfsPN8QhbwucEt351+TmBLbXeTQHD0Ig== X-YMail-OSG: IIJ1B6MVM1mlYeRXcKKGEFPddTrnCAMqj5pADwY0bEqgUR70H56Pm5q6EpfPkfH 7ZW4sL0HJRgcACVZXjC9.I6MjX_EP7jgxST4q89YqdETjq8hI6bmpJ.s6slAky6dnPTYsnAX9_E7 okPq1ECgp9pWWEHqqlzLwuCiUXhGA78tK6AgMTyb2Od5j4z.0tp6pT.feezrHyc6b.Rv.5uL.NP_ oS2GDCpbkowUsd4d7dsKXoYMwlkuD2oCueY82Q9gk0keevyMNoBYmK9O3jlIzD5aakmSuBifNtfl 5t.2.2U1SPJZSeAERLb2KbpAydRSSXwtHXN3dHmlBjyueknJgChTxp_CKu7Ya4HHEl0QErCjBHEs VI1SPSAg82vQJZlcm86KNpjgWkKNJlTAVDOhlc3cD_Wq2pRqMUb.oTbEJPZtDjJb5yv5_hmmLai5 zHHDNHNXf7YtVgRUpTEw15MFWwsJUwDPbj3wKfN3IcWDmJVrpDYf8jslM.cNCDBmIxYEnnf1TXr. XoSPfajAdTiBJn67aEInJjlJP7L.XkPoc62yFvgPsajDzILnNdNLtOAnKzV63nHTszW.0WQJ9Dhk f._26dFXuuOnBV48QQwVyuXCfrgRrvBBkk.ynAdkoUIygD21uoBsc9DxmHqbE9ktVrwqHWJeKxjB Jp7ywLJTt80RRz8Yag6a5hFf185oNGRYipehfFCjnaOli8YSwD7kC85c73tjvxwnpKr34HoUoR9E VuuQsfcI8LsdsYTPe5NILLGgPBKzWa_V.qm2TWenR1hhyAdVJeOot_4ozu_n3uO1l.UUzgPvYKah Wj49y7tQYSglT5XrX.rxbPVZuSD9p8DyzoRvj9FCwDzSyNDfsgo22XTaTA98nEsxHB2rO16L.m3G vbw6Vd7D29ZxcHEEnRe8aON7Ir0a6wdn5tSk8khgvvCmemPcqNkpez_2Jltmcqabiagw3rBHv7u5 CnZUit6edZJ6ZkLRr9RMVgfNgkETaG1PyppTFBjK4JiOGbCNV9dxDM4_P1WftBVqVukOecErZXrR PUFj4m800SBR0zuqLM02ZpQUrRxzTVCq1y8TyiriYJKfnxr78_zLjuy4_B506eM3wDipxz_Qweiq toZpS5H3g2w34b3iegJ8L52zBL9M2SOMBJqT0YGOIUaSlF3RNa76T.7k7IWieXHIxyF.B1kmW4t9 3tfujjuVi0mbx8FEZRJK8mmOAROl826X6n9MmM4.bAsxUEw.qWtcEdtqhq4VZvjZIzatRkMn1TL8 Xl88RAHz0_SCK83Pl9NqYT6VwAJthLtbxmlXw4YI1rt6qPTHPoPVxb_e9_Pn_Tp2KSdUAmkkXAA. .5so.hW0SbqBKeUm2zKzYdZNnnnfIaLEbUFfvE.1DtvkeqD7_ecnpSaC7r_PfacyCdamgkeyV6_c 2mE_OcgOmJvEx_wePCe3ooN1JtaUeqMgFExYEmJVa5C7MQPFmp9OkR8_UepneNHOWV7wF8XQqvq_ QqRdPwncq3sLDFuT5TiNGmybWmKAfJW5rVncS4fv4a9Gip0bOOybGFZhixxFPeGQlmnyLW2c_Fiq N5HPACbickUmImnquX7XUAE77CewA77qZfb5mqaNDlj_K3M7KQpmgyBHSF1uTFwRtHekC_o_77k1 CXV3C.wDbVO7UG4iv8k.6ndC6nqf1hUZfXkvAnemdt0woSHGOptarg0p_X3ZVyE_Vb2nKDyZiQxK 4Q8yUo2LHQEKa5J1hBxzWRSn.mCUG7Atkb5KU9uKXhgB10bf3eG52qYHbr0zqIf0JXN3cpQbCg.E h0LN_3pru0oIG_5Zk_y7PQJaRaheUBahOnk6FG4fuQR2hZR58FZN_u_7EHGsMMQ.eaCVsr4Y_1d_ iXsCsC_kmEG_ocOSe1H9Xu0QgzEloiRSHVH5EaL9_PYSQlnlmIsvJq2fh9lIKy89XOp8641KA6tA ZqxUNpq8yKGQk6wgBnIzdG4S5oCO893TBr_uyaMdzzMdNSBTFp_0DszYm4BFTBxyjJWNNHmVoO9J vyduPpZ1lbNyECQpdmKZ2LlKOhDiLbHaajeLAXaIylLZe.RZhlpHRevP6v0Bb3N4rVdG5MGLw5FD jf6KVlcdt4tzGNbkykOVqYEIjN9GFLww5OdEvmkMOIwsrX8fPxXxJYYEPgQFVniHQIX44CwSAqUU J4ewkRh8aaVuAIF.9VcZTtnQ7vQyphqe.pSTJ1ZZwhaC3N58JCP_y9eezDAuk8XDjTLdFLuCoDn8 xNjDx6c1Z1lHki6mCVjvKNqnXAw-- X-Sonic-MF: Message-ID: <91a05e98-1b1b-94a2-248c-8fe7ff0b5f4e@aol.com> Date: Wed, 4 Jan 2023 21:25:15 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 6/6] hw/isa/piix: Resolve redundant TYPE_PIIX3_XEN_DEVICE To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Bernhard Beschow , qemu-devel@nongnu.org Cc: Richard Henderson , Stefano Stabellini , xen-devel@lists.xenproject.org, =?UTF-8?Q?Herv=c3=a9_Poussineau?= , Aurelien Jarno , Paul Durrant , Marcel Apfelbaum , Anthony Perard , "Michael S. Tsirkin" , Paolo Bonzini , Eduardo Habkost References: <20230104144437.27479-1-shentey@gmail.com> <20230104144437.27479-7-shentey@gmail.com> <30ed41ab-f7c9-15fb-8f4b-b2742b1d4188@aol.com> <405dc396-7b7e-842a-2b94-6b26df1aa564@linaro.org> Content-Language: en-US From: Chuck Zmudzinski In-Reply-To: <405dc396-7b7e-842a-2b94-6b26df1aa564@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.20982 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 4571 On 1/4/2023 5:35 PM, Philippe Mathieu-Daudé wrote: > On 4/1/23 17:42, Chuck Zmudzinski wrote: > > On 1/4/23 9:44 AM, Bernhard Beschow wrote: > >> During the last patches, TYPE_PIIX3_XEN_DEVICE turned into a clone of > >> TYPE_PIIX3_DEVICE. Remove this redundancy. > >> > >> Signed-off-by: Bernhard Beschow > >> --- > >> hw/i386/pc_piix.c | 4 +--- > >> hw/isa/piix.c | 20 -------------------- > >> include/hw/southbridge/piix.h | 1 - > >> 3 files changed, 1 insertion(+), 24 deletions(-) > >> > >> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c > >> index 5738d9cdca..6b8de3d59d 100644 > >> --- a/hw/i386/pc_piix.c > >> +++ b/hw/i386/pc_piix.c > >> @@ -235,8 +235,6 @@ static void pc_init1(MachineState *machine, > >> if (pcmc->pci_enabled) { > >> DeviceState *dev; > >> PCIDevice *pci_dev; > >> - const char *type = xen_enabled() ? TYPE_PIIX3_XEN_DEVICE > >> - : TYPE_PIIX3_DEVICE; > >> int i; > >> > >> pci_bus = i440fx_init(pci_type, > >> @@ -250,7 +248,7 @@ static void pc_init1(MachineState *machine, > >> : pci_slot_get_pirq); > >> pcms->bus = pci_bus; > >> > >> - pci_dev = pci_new_multifunction(-1, true, type); > >> + pci_dev = pci_new_multifunction(-1, true, TYPE_PIIX3_DEVICE); > >> object_property_set_bool(OBJECT(pci_dev), "has-usb", > >> machine_usb(machine), &error_abort); > >> object_property_set_bool(OBJECT(pci_dev), "has-acpi", > >> diff --git a/hw/isa/piix.c b/hw/isa/piix.c > >> index 98e9b12661..e4587352c9 100644 > >> --- a/hw/isa/piix.c > >> +++ b/hw/isa/piix.c > >> @@ -33,7 +33,6 @@ > >> #include "hw/qdev-properties.h" > >> #include "hw/ide/piix.h" > >> #include "hw/isa/isa.h" > >> -#include "hw/xen/xen.h" > >> #include "sysemu/runstate.h" > >> #include "migration/vmstate.h" > >> #include "hw/acpi/acpi_aml_interface.h" > >> @@ -465,24 +464,6 @@ static const TypeInfo piix3_info = { > >> .class_init = piix3_class_init, > >> }; > >> > >> -static void piix3_xen_class_init(ObjectClass *klass, void *data) > >> -{ > >> - DeviceClass *dc = DEVICE_CLASS(klass); > >> - PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); > >> - > >> - k->realize = piix3_realize; > >> - /* 82371SB PIIX3 PCI-to-ISA bridge (Step A1) */ > >> - k->device_id = PCI_DEVICE_ID_INTEL_82371SB_0; > >> - dc->vmsd = &vmstate_piix3; > >> -} > >> - > >> -static const TypeInfo piix3_xen_info = { > >> - .name = TYPE_PIIX3_XEN_DEVICE, > >> - .parent = TYPE_PIIX_PCI_DEVICE, > >> - .instance_init = piix3_init, > >> - .class_init = piix3_xen_class_init, > >> -}; > >> - > >> static void piix4_realize(PCIDevice *dev, Error **errp) > >> { > >> ERRP_GUARD(); > >> @@ -534,7 +515,6 @@ static void piix3_register_types(void) > >> { > >> type_register_static(&piix_pci_type_info); > >> type_register_static(&piix3_info); > >> - type_register_static(&piix3_xen_info); > >> type_register_static(&piix4_info); > >> } > >> > >> diff --git a/include/hw/southbridge/piix.h b/include/hw/southbridge/piix.h > >> index 65ad8569da..b1fc94a742 100644 > >> --- a/include/hw/southbridge/piix.h > >> +++ b/include/hw/southbridge/piix.h > >> @@ -77,7 +77,6 @@ struct PIIXState { > >> OBJECT_DECLARE_SIMPLE_TYPE(PIIXState, PIIX_PCI_DEVICE) > >> > >> #define TYPE_PIIX3_DEVICE "PIIX3" > >> -#define TYPE_PIIX3_XEN_DEVICE "PIIX3-xen" > >> #define TYPE_PIIX4_PCI_DEVICE "piix4-isa" > >> > >> #endif > > > > > > This fixes the regression with the emulated usb tablet device that I reported in v1 here: > > > > https://lore.kernel.org/qemu-devel/aed4f2c1-83f7-163a-fb44-f284376668dc@aol.com/ > > > > I tested this patch again with all the prerequisites and now with v2 there are no regressions. > > > > Tested-by: Chuck Zmudzinski > > (IIUC Chuck meant to send this tag to the cover letter) > Is it customary to tag the cover letter instead? I thought it appropriate to tag the last commit in the series because it best represents the actual commit on which tests were carried out. Also, the cover letter does not actually represent a real commit that can be tested, except maybe the last commit in the series. I did read the document on submitting patches, but I don't remember if it specifies how to tag a series of patches with the Tested-by tag. Kind regards, Chuck From xen-devel-bounces@lists.xenproject.org Thu Jan 05 02:35:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 02:35:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471592.731494 (Exim 4.92) (envelope-from ) id 1pDG5v-0004RI-Oq; Thu, 05 Jan 2023 02:35:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471592.731494; Thu, 05 Jan 2023 02:35:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDG5v-0004RB-Lq; Thu, 05 Jan 2023 02:35:03 +0000 Received: by outflank-mailman (input) for mailman id 471592; Thu, 05 Jan 2023 02:35:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDG5t-0004Qm-Fq for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 02:35:02 +0000 Received: from sonic313-21.consmr.mail.gq1.yahoo.com (sonic313-21.consmr.mail.gq1.yahoo.com [98.137.65.84]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8b2df3e2-8ca1-11ed-b8d0-410ff93cb8f0; Thu, 05 Jan 2023 03:34:58 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.gq1.yahoo.com with HTTP; Thu, 5 Jan 2023 02:34:56 +0000 Received: by hermes--production-ne1-7b69748c4d-rglm6 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID ac337fbdd3f23fe8dbfff1f809657b1b; Thu, 05 Jan 2023 02:34:50 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8b2df3e2-8ca1-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1672886096; bh=/pRkfyPTTNceKNunGNRzqNqyo3veLlHP7DUWR1szcLQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=V2vW5f5Uy+sJKNuydA6aOe5NtERI8guZXx/KTQOH8sk5WVpJrSco7chMF9TZ5mT/wCJB1hOXZKYgtq0TwjIBY8EOe64Cy7wwwYzksEL/AJjKbd5kUWF1yzMttZqENpXg7aykoVF7MACyshYLm7bRmV9f20iq6uqFHRYcUi+2BFydZoyvUnJt0airuiB6z7+wjxg1y2Zqm36NRBAMvZj5/rS0Tm0SzvQ8+mMw4Cm2PbSJ0DfSGZdS0g6/a2f4Ds8hQLAs844R1sRKauZRK31y7Hzk2sZbmmyg7nnD89Y+KUjq2PvkCFsw2+UdzmYKbkMUvWpWSiGrkvu5Kshloc8hOg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1672886096; bh=SUmFmCwnNydbHOG0E0HDGzqHeyfavww5DndpuizCsUo=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=Kjt/pFUbGuld+5RFIx3jW/KIhauf9E5JSh+SHMpql3A3Xofswqz9trqnGk3kw5WBwZ8WL0ZL//p04FgiPANN4u65O29eNG6/zxinPC+OQwQciUcyX8sFgz3M57hwUcPQ6KgZ0C31/H569vLdBoEjmV5W85H3lszxoXTT+BYg7RHvImQdtp7eARPaVAk5hGG3+VDKyyfa2QtvfKXC4WMBZRcIrwPgKAzM0e5ter5orr8JzCNHpLRm/8yr5IY0HAmaL9Oc63FF616NigXzbDRKr8n078F3YEBqGigV58fqKwlxAdOKRxQCF6H8J1tAgXq7aYBsm45YL+Opv9ldmsuvag== X-YMail-OSG: sCZ4kewVM1nXmt9YrAGtmMRCOz5NRTCtu7Qkwdn1prKvo0eaIAQ91dp6FC7S0Fh WLtze.ZOUgVRzQJ3m9t4D7B89Mjmfa_LtZ4cHVOhMe7RgjAlGr1iodiQ2Duh6UZ.YjhHx5gcBKkj vwxFX_Qiz58yGw416YJhpAdE5rrcbPdPm9qjrYE1bPOr0rBRBVAiL.gEzjrlDFWTKhauZCnV4B9_ eMcqMxjeOUZ4NP2Kut47wgg2X8HaauLL1OSQXFXLlgueB2VAQW88lxwdj3BJM51un9uG83hcp4dj zE.EHY_gKPyOCMrPhgoMoWK_kWgkG5I83ut7OKfZGMOjpOIUSvgJzoP8fdlqgCDa6FaRDPdpDURU Hqno4WdMyp9hHr_Wu1ccvAH.qi2CKh6IW0MGz5.kKx6yJhHoXMZ13zJqUH2l5ztjzbgkw2IUVX2P FOrHdOsjiojByZMdctdQ2bD1cfl7.R3PBtC5LNuMJofxTyUWRCHQjmdjIBZTwWH8rdNfEw7W1Ohl 2TLX_33LtakfH6eRuccaXVt4U7OWaKcoG_cZvR2XLkmsJs11eyuiajMYFTKqexRbn3DFkp1E_BtD HCoNQJ3eclwTj5T0s2QODziPzfPrv0Eb_ufODOsGaprndkYPl0hBp3RoHrP0lLPgV7wLlfEregk7 Hy0jhSocEn3aCwQDZ7yeNG.dHD6Me13sNHTUo4PJ.VNGq4LdIoWqh.BkjJ3q6WH37E3C08Ix_zoJ pdb.hWyY3QeihO9ui8ndOObskZo5Inda.JpTax6JSKCF7GWpJfENRKPgXJzG1iORf37VO7Z31Y_a _GuJ8PCRZVces8zc0J.n.eqQHjPHum8oMmGQ4KMnUPw1dbepkySzHqWkLtuFkSiENnt8lFOIcH1Z lmcYTByocaBRzXm2zs2ZYFT_VaSUHwe0ZFqbleQcB8xYh7rbKXXJeNNUooL7Jb0W2XO0LswaLekB PXaJtrPphOGyPdzJDIXE8FVupTUB.FBtnUbu.0zrD5gAbrIUAYAYQKbBpDGl831EJD4wjuH7PRT6 H8c62QqNyNEeCSJd6ZHewi2rGLFqKe3q0l9nkt535bF0qZ7mkz1r_0XJJU035xASFmpnrS784bEG jUeAuCQZ9hNtFmCeRoBCGJcqr0aZin25_bMpkcbaKnGgVnoS_izKAxFaC.38WA3YHf271GeE2FzN EZPKv9lDe_.qpkjTlY__7iyFiuvdAwtRvLCtdUAnBfJ.O5CnCluSctbxjD3VfFu2EdK.amZDb5Oh GOl0QzhUlV4iiqbAHSClDMN314EEEz.LhEmy8s.VZrx5YkwIpEgFAp_Eukqcu8a_IGEq8k1DoQtl F9PlfFDJhxpuFXdE_jMtBQcO_OnglAw7F4yRYfiJXAYz0hH9vpGD9FOVwtxr45mbXiLn7rHFhukQ WioNy4GpsW6_MYBE_FMl8t5WxBWD4fBzZ7apctIhMEXsUe2g4a.TCT7l0nJ8AB24Du7U1OE_ciT. O8cp0mW72CCLIDIz3aACZQEhl9qNcaZOPKfwZ.v_MpVsBNQVirdPakWwre_Bby6inRNk7_1EjfNl rm1H9YZpggJ8XRIjR1ZfgyxhhAPgqgbo8GTHPmpv65zjzyFhUWTYoXvBiKJelzKTGqrRYtWNa7Iq K2ecVuDoyXz3NbzrPx187zvU7rSJE5Ot.73yeoukmfMeFDB0eZrn_BnqRX3WSyme80CY3h1kA.MF IbobusjxrLmzIYo1qkbtz40PAC1iXye6zVHBTLP19LWD630de.MqAhuXs4pqVnO9E0PiB5haht.6 LD4RqkIkh968fIrsL4qvkXn7uiJElOvCT8OGMZXNiybrwPHEoSCOtJrnGUIsO5QC7lid9JZqb6Oh qmGRbXDE3tYCIBtT1Aax5uZvT2p6KbwRU.49yZfg_jkKf.zXf7WcxCskywcAzDa3e5BxvFE_J0Ed tKE0o8L3Z4b5WG3lE1QQEYZuE4Qs6a1pzFujdQKAsZRcmlGe9lerepndjdqXIIkYt40FakuvZrQf 1jxM7nyAcBXgSY53j6oQN6nRTiix_kXKOzGCb_Wel0oYEW4JE7kus6KWlDaAoEp2CgTmNa28FRzY AaSJ0Fm4o8BkNCUowfAz5rvVmSvsu_rbpM2Fu9N6V5RaSgiIjOi6kSycqUfMtHj6Jc6J.N2.s.mZ 6SGewiDdW98VXChfXmttbARU_f2qjVbj9bcWXZZnwX1NmlX08zkueL9rdF8vZKBVETfjuHzLj9.r XjqUi2ypTBepw2iX_Jd_9L4.gSQ-- X-Sonic-MF: Message-ID: <157390bd-4d1f-64be-49df-639ddbd8bf2d@aol.com> Date: Wed, 4 Jan 2023 21:34:46 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 6/6] hw/isa/piix: Resolve redundant TYPE_PIIX3_XEN_DEVICE Content-Language: en-US To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Bernhard Beschow , qemu-devel@nongnu.org, Markus Armbruster Cc: Richard Henderson , Stefano Stabellini , xen-devel@lists.xenproject.org, =?UTF-8?Q?Herv=c3=a9_Poussineau?= , Aurelien Jarno , Paul Durrant , Marcel Apfelbaum , Anthony Perard , "Michael S. Tsirkin" , Paolo Bonzini , Eduardo Habkost , Thomas Huth References: <20230104144437.27479-1-shentey@gmail.com> <20230104144437.27479-7-shentey@gmail.com> <1c2e0780-e5fb-1321-0d84-b0591db9fec7@linaro.org> <92efe0f1-f22b-47bc-f27d-2f31cb3621ea@aol.com> <877abde0-2e76-7fde-0212-eb7ce1384ea6@linaro.org> From: Chuck Zmudzinski In-Reply-To: <877abde0-2e76-7fde-0212-eb7ce1384ea6@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.20982 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 3103 On 1/4/2023 5:18 PM, Philippe Mathieu-Daudé wrote: > On 4/1/23 20:29, Chuck Zmudzinski wrote: > > On 1/4/23 1:48 PM, Philippe Mathieu-Daudé wrote: > > >> Here TYPE_PIIX3_DEVICE means for "PCI function part of the PIIX > >> south bridge chipset, which expose a PCI-to-ISA bridge". A better > >> name could be TYPE_PIIX3_ISA_PCI_DEVICE. Unfortunately this > >> device is named "PIIX3" with no indication of ISA bridge. > > > > > > Thanks, you are right, I see the PIIX3 device still exists after > > this patch set is applied. > > > > chuckz@debian:~/sources-sid/qemu/qemu-7.50+dfsg/hw/i386$ grep -r PIIX3 * > > pc_piix.c: pci_dev = pci_new_multifunction(-1, true, TYPE_PIIX3_DEVICE); > > > > I also understand there is the PCI-to-ISA bridge at 00:01.0 on the PCI bus: > > > > chuckz@debian:~$ lspci > > 00:00.0 Host bridge: Intel Corporation 440FX - 82441FX PMC [Natoma] (rev 02) > > All these entries ('PCI functions') ...: > > > 00:01.0 ISA bridge: Intel Corporation 82371SB PIIX3 ISA [Natoma/Triton II] > > 00:01.1 IDE interface: Intel Corporation 82371SB PIIX3 IDE [Natoma/Triton II] > > 00:01.2 USB controller: Intel Corporation 82371SB PIIX3 USB [Natoma/Triton II] (rev 01) > > 00:01.3 Bridge: Intel Corporation 82371AB/EB/MB PIIX4 ACPI (rev 03) > > ... are part of the same *device*: the PIIX south bridge. > > This device is enumerated as #1 on the PCI bus #0. > It currently exposes 4 functions: ISA/IDE/USB/ACPI. > > > 00:02.0 Unassigned class [ff80]: XenSource, Inc. Xen Platform Device (rev 01) > > 00:03.0 VGA compatible controller: Device 1234:1111 (rev 02) > > > > I also see with this patch, there is a bridge that is a PIIX4 ACPI at 00:01.3. > > I get the exact same output from lspci without the patch series, so that gives > > me confidence it is working as designed. > > Historically the PIIX3 and PIIX4 QEMU models have been written by > different people with different goals. > > - PIIX3 comes from x86 machines and is important for KVM/Xen > accelerators > - PIIX4 was developed by hobbyist for MIPS machines > > PIIX4 added the ACPI function which was proven helpful for x86 machines. > > OS such Linux don't consider the PIIX south bridge as a whole chipset, > and enumerate each PCI function individually. So it was possible to add > the PIIX4 ACPI function to a PIIX3... A config that doesn't exist with > real hardware :/ > While QEMU aims at modeling real HW, this config is still very useful > for KVM/Xen. So this Frankenstein config is accepted / maintained. > > Bernhard is doing an incredible work merging the PIIX3/PIIX4 differences > into a more maintainable model :) > > Regards, > > Phil. Thanks for the nice explanation of the history. I understand the PIIX3 is associated with the i440fx machine type for i386 - it goes all the way back to 1995 I think with the original 32-bit Pentium processor and Windows 95. So it is a worthwhile effort to work on updating this to something newer, and of course kvm can use the newer Q35 chipset which goes back to 2009 or so, I think, but xen/x86 languishes on the i440fx for now. Best regards, Chuck From xen-devel-bounces@lists.xenproject.org Thu Jan 05 04:54:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 04:54:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471606.731524 (Exim 4.92) (envelope-from ) id 1pDIGm-0001NW-Ga; Thu, 05 Jan 2023 04:54:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471606.731524; Thu, 05 Jan 2023 04:54:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDIGm-0001NP-Dt; Thu, 05 Jan 2023 04:54:24 +0000 Received: by outflank-mailman (input) for mailman id 471606; Thu, 05 Jan 2023 04:54:23 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDIGk-0001NF-Vm; Thu, 05 Jan 2023 04:54:22 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDIGk-0006N2-Rq; Thu, 05 Jan 2023 04:54:22 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDIGk-0008BE-Cv; Thu, 05 Jan 2023 04:54:22 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pDIGk-0001sI-CP; Thu, 05 Jan 2023 04:54:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=9LaNnHNrvD2gi1b4pViituYE1r1RA108h4zfpDGpfYQ=; b=wWgyHoEfod7Y+mxyGBOy7Hp02G xi7oeu6/ZpFtlk4XSds39yvOKqPaQ0Qp7Up3oVKu/YYlHlRoNUeSsP8O3Ibur1ce8IkhrU2b59Tgu jy5/hB1775yd3WrxkMLkY2MA4QzZb10mqaK+1zAa330hnGMqkUT9qGZ9vOXB9ijACCgs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 175570: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=69b41ac87e4a664de78a395ff97166f0b2943210 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Thu, 05 Jan 2023 04:54:22 +0000 flight 175570 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/175570/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine 8 reboot fail REGR. vs. 173462 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux 69b41ac87e4a664de78a395ff97166f0b2943210 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 89 days Failing since 173470 2022-10-08 06:21:34 Z 88 days 185 attempts Testing same since 175552 2023-01-02 21:13:23 Z 2 days 6 attempts ------------------------------------------------------------ 3257 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 497265 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Jan 05 06:44:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 06:44:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471623.731550 (Exim 4.92) (envelope-from ) id 1pDJzG-0004Gl-Me; Thu, 05 Jan 2023 06:44:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471623.731550; Thu, 05 Jan 2023 06:44:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDJzG-0004Ge-JP; Thu, 05 Jan 2023 06:44:26 +0000 Received: by outflank-mailman (input) for mailman id 471623; Thu, 05 Jan 2023 06:44:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDJzF-0004GU-93; Thu, 05 Jan 2023 06:44:25 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDJzF-0000hI-5Q; Thu, 05 Jan 2023 06:44:25 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDJzE-00087L-RI; Thu, 05 Jan 2023 06:44:24 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pDJzE-0005fX-Qh; Thu, 05 Jan 2023 06:44:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=/wcW7TSTHh7lbkw4eeRAFe0Z+Z63P8BJNaPHygWmW+E=; b=NguCIK4GnMgRNqSxfBU1Fgr2tL X9c6pnOJ1YzRVQkKWWbo9zBuGVMjc9Op50tsX1kMuU91rI03QSHQ2sXv7Sl+JljuSdoegbqz8t3Gs BC5mLNX4Rra392HrWP9QhvkLtBcV+TdWX8tOQ2xEzkz1irK/aWvEhhzSaEVZ+Dq01jCU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 175571: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start.2:fail:heisenbug qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=ecc9a58835f8d4ea4e3ed36832032a71ee08fbb2 X-Osstest-Versions-That: qemuu=222059a0fccf4af3be776fe35a5ea2d6a68f9a0b From: osstest service owner Date: Thu, 05 Jan 2023 06:44:24 +0000 flight 175571 qemu-mainline real [real] flight 175581 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/175571/ http://logs.test-lab.xenproject.org/osstest/logs/175581/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-libvirt-vhd 20 guest-start.2 fail pass in 175581-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 175457 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 175457 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175457 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175457 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 175457 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 175457 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175457 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175457 test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu ecc9a58835f8d4ea4e3ed36832032a71ee08fbb2 baseline version: qemuu 222059a0fccf4af3be776fe35a5ea2d6a68f9a0b Last test of basis 175457 2022-12-22 11:29:39 Z 13 days Testing same since 175571 2023-01-04 17:08:54 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Bin Meng Christian Schoenebeck Greg Kurz Peter Maydell jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 222059a0fc..ecc9a58835 ecc9a58835f8d4ea4e3ed36832032a71ee08fbb2 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Thu Jan 05 07:13:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 07:13:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471657.731583 (Exim 4.92) (envelope-from ) id 1pDKRT-0000Ia-DE; Thu, 05 Jan 2023 07:13:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471657.731583; Thu, 05 Jan 2023 07:13:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDKRT-0000IT-AN; Thu, 05 Jan 2023 07:13:35 +0000 Received: by outflank-mailman (input) for mailman id 471657; Thu, 05 Jan 2023 07:13:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDKRR-0000IJ-DE for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 07:13:33 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2047.outbound.protection.outlook.com [40.107.6.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 74f3d6fb-8cc8-11ed-b8d0-410ff93cb8f0; Thu, 05 Jan 2023 08:13:30 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8337.eurprd04.prod.outlook.com (2603:10a6:20b:3e8::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 07:13:29 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 07:13:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 74f3d6fb-8cc8-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VM3VqyJ3usvUou7yHCxvrhCW4EDnmn/YJPTrvCm/f9UM3Dipg+2BUfXfgJyf1owCJ7q16IF3uffQsG2StG8JP6PNVbxBTq1NMcTBJ4FOXwjtQqp+k0qIJncV4XnODLgNzA084lZNUilxI8iQRKeS7IPAkRobePvELrYOdHwPi/+wiXxLkpHs+iPmz3w8EK0OSn+6qoW2W28g7RHXp2Qbew5FOpg6LiEFFBK5o45b2WTogFL1ydZswL7HkRnSE2zgfLVilbubsREdvlGQUUhAR8EODFYvxSN3MaMK+HG+cutQT0VCX09MRUW/DrtgU7zTUUDejENBhhE5cyw0ETP+CA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4180Hykc+KTZMJiQ1FymiaCwrT2A7+kybbdi21Hl2ks=; b=GwFNsH/BPPxn9wR5fUKyH1mY91TfVKUXbQTru0ZDF6yToUiXiktWCKbN7V6BN+B1yNuH4vp2zn20o2PzACbZ3LmLAy0ymUOPGMicingfnCrrssjDtUPI5ccVii791udStRCrg/p/TTZyXg678B93UQSeb8KwPPcagbNKQKWAlBYoMrrHxRdFA8xfiXhTAjWUpuH0Kh8d8Vfs0afSxtW/PdVAp/WDw4z9YHDYd0IJQyInj1jPWIsAxsAXpJP9TMI6PNewfhmQUCkhVImA/gmvAqf0n0XYhORgBUJdl9l26HazpkPViH+26Yov5bS8Lw23M2N0xsrVk/36w6scgYfJIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4180Hykc+KTZMJiQ1FymiaCwrT2A7+kybbdi21Hl2ks=; b=XShXLow1Xekh21gVO/411AR/B6mIWLUsGTNKauGGYl5Epu5DPeq3fouBQnXrt/BSnA+hs88mzNrR3hH/TQawsl8VVC3BcQZSgx8Ga/YSsLmHgzmM2+OYlf/cnWQXWPokqtylIaD13SoGGIxQ3vtu+UxGV1r2l7Q/3d0mOOABD3eoyM3IJAg2hJE9+5b2ooKnDiIvsJ5M5oc5VzTsiE8eoTB9XsNadw4tN1UVQSwTg2P66A5f19Alr1Nsz+adw/ICpDpcJYRF/rXWiZGaheJvfAQEs0i/QY3yaBQFI5VqHfznkeglQyuWvouTYlBao1PDKPzx3bMHrsFRxkdL2W7CpA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 5 Jan 2023 08:13:27 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2-ish] x86/boot: Factor move_xen() out of __start_xen() Content-Language: en-US To: Andrew Cooper Cc: Roger Pau Monne , Wei Liu , Xen-devel References: <20211207105339.28440-1-andrew.cooper3@citrix.com> <20221216201749.32164-1-andrew.cooper3@citrix.com> <520cdde9-07e1-fce8-56d9-205fc31c62e3@suse.com> <5f3df359-2906-ba20-b8df-ae2f2d5f5981@citrix.com> From: Jan Beulich In-Reply-To: <5f3df359-2906-ba20-b8df-ae2f2d5f5981@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0134.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8337:EE_ X-MS-Office365-Filtering-Correlation-Id: af0c9e5e-c866-40d7-ed5e-08daeeec5868 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: I5q2s1BOChuYGuI2wl4jkS4bogSS9HAMRupMCoI1tsV86suzLlkU1g5uT2WTxitanrtVzjfw64ilT1DaIF6hKTm25DMDjro9QspkPZJnVr6LDLpYHJGrCy6RXOiyDbpb4sj4mW+zdwKwO9wvql+QCeV44U2X5Rul/mlZ6CI8KMFkQHMbqM+xGObKvAnFHGumpTfS/nySl67dz04ssi1vkr3kHir/Hw24FHBsVsbA14dqpoVTP9a0bm+g2RPXvz93qvpdYQ8itQqWvOsx6GJ5izEak3+bfKnPV900K9g+Q41L6vUpOL7awK3aZLqKks/W+vUCTXMtyzXti9DMa0EtEqiyOu1QIVZtaL82DNrT81EFZxNTIw+r+kLmbRG0mF/KIkxGsy8RPJ67SoOX+lo8CQ9RGb6TouUPAz/k9vpQ8Q/8yskIyuJCYHzfebXDSN8/opG8sj2/IpvJHmow5s6WOtgwMdyiGgrANXJcyBwO3EqgbGVgNycfpqcAc+fKwr8p0I/8UYM9ZJo4ftTazIKsGwYQ3mHHxcGXdv0GaetVox6aw3dskX7/M5kmxqgKXIJ/6X9phsiBBC93cocvT6ORnGdsyOojnTo5ogibont52r5JihnnTemrPgiCwAFm7ZXVyQmaBzij145AbWwweNe5e1Ba90V2+6zX7ljZVLNUue4cjZydTm8Ru4OpNR7P3ff4zYnDAG2kgxwjHV/VXVC5VeWFXIpmgQwrgZrffWhq9OLpgqZk2KOPiXLpctYdkC541xry5llSlb/17IqY2fZGLQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(136003)(39860400002)(396003)(366004)(346002)(451199015)(5660300002)(2906002)(8936002)(478600001)(41300700001)(4326008)(316002)(8676002)(66899015)(66556008)(66476007)(6916009)(54906003)(66946007)(31686004)(6486002)(966005)(6512007)(26005)(6506007)(83380400001)(2616005)(53546011)(38100700002)(186003)(86362001)(31696002)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MUozTWErdEZkZ1dFRzZyZUN2Tzdwa0N1SlNHUkFUdFNFbkpUUVYzby9DTS9B?= =?utf-8?B?QkhiUWVRS2hVVWFjTTBBZEJuNHlvK2J1QjVaSC94NVBwdENmVEpNUFhDSnZr?= =?utf-8?B?Ti9oanZnd1A2UGJCUlNIZUNSTlg1NmJqQjJwWVc3SUdxZzV3a3NwTGVHT3Jj?= =?utf-8?B?QmNSc3V4dHROVGR3WEU4ZHlVUm16QnZaY1Q5aXk2NS8vU29FYUh0UmVhMGYy?= =?utf-8?B?ZkQ0WnlVZzhGS2JXMHVNQjRQbnBFaUdFdUtvcnZLeGdXeTgwWTY2WUFVUzRa?= =?utf-8?B?R01VOStsLzNOVThHL2w3MG9ENHROeXZKWU52L0VTNVFHOGs3V0lvdFpzbk1B?= =?utf-8?B?cDBkOVpMa20wd3lOVTlsaUhBQVBEZENsbFJhdkExMU1aVk9SQ2VTcVBoUVNy?= =?utf-8?B?dkFKWktydHdsSXpacENxUlpnelVkUWxDN0pRYmRJYnNubHNQWTJCVVJLQm1G?= =?utf-8?B?WFFQZzJid2owU05Ja1VMSWsyZkJCZTFhbnYvY2EwNDVxSFE2eUg0L1NsWjVO?= =?utf-8?B?VHAreWVHS0ZtalJqK1oyYVZsaThLTy83cGpNZG04T09yYU5VZThvYVdiZnZT?= =?utf-8?B?RTZHWVdIQTQ3eGJ0Q3kwb0w1dEw0aGlrUEVnQU5VM3ZiMWVId1F3VjAzR2xy?= =?utf-8?B?QVBzdVozb3RzcUdld09RQ1NQRzZtdUQ1emNQbkJKZlY3cjYxV1dJbjIyQ1ZX?= =?utf-8?B?dGJ6MmRjQUFaNzNWaERlK0RjZTBnaEJhcGtIcDdTK0tCbkRoQ3NycUpjYm1Q?= =?utf-8?B?aEh6MTQvU3o3cWphbTY3Uk5ES3E5cC9BOFpxMCtjZFh5U3VLZEtZdzB2eSti?= =?utf-8?B?YzFLcmthN1hoNE0wQi9Ia0ZwZGxhOXNDaXJ5SlBJejlabUQrdkY2SWwxVUJT?= =?utf-8?B?Y3EyZVlUc1JlSjI5dlBpKys3Vlg2V1pPNHZBM2RNZ3ZQZUQvT2pFbnJxbEJl?= =?utf-8?B?MEorRy8zNWVTYXNhSkR6cXY5dWVXd0JwbE9tazBEa25CRHpMbXVoK1ZTKzRp?= =?utf-8?B?UEpiNWQ4NUZPVEV0RlNwNDVwcFQyeGdQS1JTZUJnRGN3UXBYZDFqYjVkV1Iy?= =?utf-8?B?b0o1OGNoTFdHWkFYYnY4QTBicktaazBGVXZGMnVrOFBNajYrZ2d1R0t5ZG44?= =?utf-8?B?QWNhemJEQkw5ait1Y2MvUzVJUHErTzF4NjlTdVpybnNOQ1JtR2NGb2luUGYz?= =?utf-8?B?bUpmVFBJdEJ0RFFKdEVONE11UlYrY2t4L0FxMGZTUE5lWHYxQ0NaZFEwZkxh?= =?utf-8?B?NXhDdExCUE1RR2xQcEVJU3lzYXhwd2xzbHJnWkVNalZKREZ0SnoybzFFS3Z3?= =?utf-8?B?TEQ0TGFIdkh0SGdWSXpYNGFRdm1qcjZDbkRuWnI0ZFBWMHBOVUxaQjJxNlpa?= =?utf-8?B?WUd0a1QwK0pjUVJ3TFpOZ0RyNkVzcXpqRk42d3paMU5semg0S3JWQTY0RE85?= =?utf-8?B?Wis1MTNsSWhocEpESzlaYWlRTEEzekFLZ3VxVlpVRFEvZzV6Q1dOSHZkTENF?= =?utf-8?B?RFBjb2c5M1lzRU1WOG16N3AzRitwZkFxUldGbUUxK0wrYzBqNVZjdWtIN1Y0?= =?utf-8?B?YnBhcDIzYTcydk85RUhYU3Y4enpsSi9xRSt2STZqWWpvem5XUnh6Y2VsVEEx?= =?utf-8?B?dk1sKzkyUjA0bHJ2VUN0MjgvTkQyUDZmTTR6NG50MGJPMGRJVENSVmFZaTFa?= =?utf-8?B?dTBIVzRCYmkzY0FzemxOWGFTcnErdnFrNWVlZHFXb0laVlczZzdQSTNKRXIr?= =?utf-8?B?OWMyWjhKWWdTblFDTGNsRVN4WUdMSmFMcm95YVJScHN0eDV2SmpSbUE2bjBN?= =?utf-8?B?aXA2U1hTNFhZa2pEZnpzUjRXeS9sOVBMTStkZm1UeGxZejQybUNOSjYyRVJG?= =?utf-8?B?a0FZN29lQXNiRmNWVXhuRTIvbzJwd3ZCSVR1NHViTFpCUkRDWkdMVTFuR2hJ?= =?utf-8?B?cGFac3hQZlNncjlYbiszbTNJVVJvYjREYUhlaGQ3V05LTGJOSzNXQVdRVFRL?= =?utf-8?B?TkdkMnRsYSsrb3BnRzVSQjl1VVZOZXF3UzNIRmRLV3cvZ0VpSkdHSDdYTXBy?= =?utf-8?B?bW5LTy9NZVhqam1IcklvVVlUaUtOMkF4OWw2cFlDRnVBaERFNmV2Wm5sdllv?= =?utf-8?Q?94NwyMAHdu4SVOScNeXSKjtkP?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: af0c9e5e-c866-40d7-ed5e-08daeeec5868 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2023 07:13:29.0716 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PNJEfzNFG404jJM3BrultHvqYsSpi3NM2znqVMuHwopIi5560B7s7OMf0AuCRhEVj3e8REbzagFmkSf5ZGW6Cw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8337 On 04.01.2023 21:04, Andrew Cooper wrote: > On 21/12/2022 7:40 am, Jan Beulich wrote: >> On 20.12.2022 21:56, Andrew Cooper wrote: >>> On 20/12/2022 1:51 pm, Jan Beulich wrote: >>>> On 16.12.2022 21:17, Andrew Cooper wrote: >>>>> + "mov %[cr4], %%cr4\n\t" /* CR4.PGE = 1 */ >>>>> + : [cr4] "=&a" (tmp) /* Could be "r", but "a" makes better asm */ >>>>> + : [cr3] "r" (__pa(idle_pg_table)), >>>>> + [pge] "i" (X86_CR4_PGE) >>>>> + : "memory" ); >>>> The removed stack copying worries me, to be honest. Yes, for local >>>> variables of ours it doesn't matter because they are about to go out >>>> of scope. But what if the compiler instantiates any for its own use, >>>> e.g. ... >>>> >>>>> + /* >>>>> + * End of the critical region. Updates to locals and globals now work as >>>>> + * expected. >>>>> + * >>>>> + * Updates to local variables which have been spilled to the stack since >>>>> + * the memcpy() have been lost. But we don't care, because they're all >>>>> + * going out of scope imminently. >>>>> + */ >>>>> + >>>>> + printk("New Xen image base address: %#lx\n", xen_phys_start); >>>> ... the result of the address calculation for the string literal >>>> here? Such auxiliary calculations can happen at any point in the >>>> function, and won't necessarily (hence the example chosen) become >>>> impossible for the compiler to do with the memory clobber in the >>>> asm(). And while the string literal's address is likely cheap >>>> enough to calculate right in the function invocation sequence (and >>>> an option would also be to retain the printk() in the caller), >>>> other instrumentation options could be undermined by this as well. >>> Right now, the compiler is free to calculate the address of the string >>> literal in a register, and move it the other side of the TLB flush.  >>> This will work just fine. >>> >>> However, the compiler cannot now, or ever in the future, spill such a >>> calculation to the stack. >> I'm afraid the compiler's view at things is different: Whatever it puts >> on the stack is viewed as virtual registers, unaffected by a memory >> clobber (of course there can be effects resulting from uses of named >> variables). Look at -O3 output of gcc12 (which is what I happened to >> play with; I don't think it's overly version dependent) for this >> (clearly contrived) piece of code: >> >> int __attribute__((const)) calc(int); >> >> int test(int i) { >> int j = calc(i); >> >> asm("nopl %0" : "+m" (j)); >> asm("nopq %%rsp" ::: "memory", "ax", "cx", "dx", "bx", "bp", "si", "di", >> "r8", "r9", "r10", "r11", "r12", "r13", "r14", "r15"); >> j = calc(i); >> asm("nopl %0" :: "m" (j)); >> >> return j; >> } >> >> It instantiates a local on the stack for the result of calc(); it does >> not re-invoke calc() a 2nd time. Which means the memory clobber in the >> middle asm() does not affect that (and by implication: any) stack slot. >> >> Using godbolt I can also see that clang15 agrees with gcc12 in this >> regard. I didn't bother trying other versions. > > Well this is problematic, because it contradicts what we depend on > asm("":::"memory") doing... Does it? I'm unaware of instances where we use "memory" to deal with local variables. > https://godbolt.org/z/xeGMc3sM9 > > But I don't fully agree with the conclusions drawn by this example. > > It only instantiates a local on the stack because you force a memory > operand to satisfy the "m" constraints, not to satisfy the "memory" > constraint. Sure, all I wanted to show is that the compiler may make such transformations. As said, the example is clearly contrived, but I also didn't want to spend too much time on finding a yet better one. > By declaring calc as const, you are permitting the compiler to make an > explicit transformation to delete one of the calls, irrespective of > anything else in the function. > > It is weird that 'j' ends up taking two stack slots when would be > absolutely fine for it to only have 1, and indeed this is what happens > when you remove the first and third asm()'s.  It is these which force > 'j' to be on the stack, not the memory clobber in the middle. > > Observe that after commenting those two out, Clang transforms things to > spill 'i' onto the stack, rather than 'j', and then tail-call calc() on > the way out.  This is actually deleting the first calc() call, rather > than the second. Which would still demonstrate what I wanted to demonstrate - we can't assume that "memory" guards against the use of stack locals by the compiler. Jan From xen-devel-bounces@lists.xenproject.org Thu Jan 05 07:22:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 07:22:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471666.731598 (Exim 4.92) (envelope-from ) id 1pDKZj-0001oo-Bn; Thu, 05 Jan 2023 07:22:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471666.731598; Thu, 05 Jan 2023 07:22:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDKZj-0001oh-8Y; Thu, 05 Jan 2023 07:22:07 +0000 Received: by outflank-mailman (input) for mailman id 471666; Thu, 05 Jan 2023 07:22:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDKZh-0001ob-Fb for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 07:22:05 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2083.outbound.protection.outlook.com [40.107.7.83]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a7097441-8cc9-11ed-91b6-6bf2151ebd3b; Thu, 05 Jan 2023 08:22:04 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB8PR04MB7051.eurprd04.prod.outlook.com (2603:10a6:10:fd::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 07:22:02 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 07:22:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a7097441-8cc9-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DK6G3ULUcYtFg74R2S9L9wqwLLN3+1jfcD6GGteXsVrQIFoEvcYlkzf5sSBCiOrP/sYiVBsomQ4VYwLWUF1AmVBarRDYmG814+9Y5nBD5u5EziMiJHFXwXqK6FdPXPC6x988DQbVN2cs2UGmdTMxSU3LMWyLRxp7a55c0Vox+BcTkb5IcE3fRuO8q9cZerDbGw+RmhJH5FGjErpjF0mricgnBr6ttPQRApQg0EP5bYzS+cP5p5xuaKhTDNK7ONc7nP7wyEuVoESrc7mpdxLxuz+wK1+JRl/FwmxoC6lTYBPkunHOsEZlXuofsXFzuODpTz+P65+AzFcFkjsmnwcnTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vc6zNnVnnN9AEYpO0uP9nMDevrwJb8ehtkqTdKNxanY=; b=ipukJdbW7okFFaXvuKZqyZvjyPVKNO74JyGEvJeoNTDFyZ+2mP+O0f5yjSHv8WkmSgIr8sNrOavBKpesPYLzdpj3YLu32s3t4o2R7LBXvtU2YJgkdAvnPej/kFnDiqzx8jetonSEDkMBeAHJQ2FOxsQ5uKwFodfxSlch6+Rf6cWCGrguXJMt1wqugBPU84YtM7R8lAE05K7O85EzVfANwu1Wr9X2QUIAiEoFJwyjJKtcWBQFED4gV/LTXo1Ana4dS7K4zGCag4VPH3PZN0HnrUpFY3auZOGd9g3NNRmGMCODE13qlnuVlJOH4dBrv6eix4cy60Zf2m6LYb72PurxZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vc6zNnVnnN9AEYpO0uP9nMDevrwJb8ehtkqTdKNxanY=; b=eSLOkKfoPH04qKiI0F2O3oD/V/G4VP2iUC/jY2ObQU4SLl2saES/kinmJQAX6YizL4yiTV7vglF5q0asZ1kmU3GgHZaPig3OfpLGsu/+XJIH4z+GqpEQeeeFDmV5LFDzru24eDC3Pe/XEvQ05CefVi3lWe162gLQp56X6u+y7XlnYINa3XE5XHY1EsEGrshselLD06dReUh8E6r+vlMpN4Robj/H+/tN0OSOf7tTPZduBnPlOlPB4DcGoaZQ9PIusw6ptfN1Li3+L+X/qtWtaJpPTV8MLrzSGkFhinP8avpCMWQy0J7IzvxpGFz4+h+e8rfwTt9DmG2q0wfHVW0BoQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <8da65f2f-19ae-6f79-d13c-c502ae1d3889@suse.com> Date: Thu, 5 Jan 2023 08:22:00 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 2/4] xen/version: Drop compat/kernel.c Content-Language: en-US To: Andrew Cooper Cc: George Dunlap , Stefano Stabellini , Wei Liu , Julien Grall , Xen-devel References: <20230103200943.5801-1-andrew.cooper3@citrix.com> <20230103200943.5801-3-andrew.cooper3@citrix.com> <074042f5-ecc1-11c9-bdcd-b9d619475d58@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0135.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9e::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB8PR04MB7051:EE_ X-MS-Office365-Filtering-Correlation-Id: b7984aa7-66dd-4f7f-6884-08daeeed8a03 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ohY8MRUUyZ9R6tWr7g0b2AT/RpwbNkiU5Lt3qKXtGf42nPN3OYD4fq7Z5qX6UTitiyFSJ313nygIdafU5TCTuU8pECQYoPC6DJFqOoZqWQW3PbTLR0Vzi1mYpNYFG4NsCHpdTSfRdInsPRXxTbByLszTFx/7lhV8/s8QFaLnUYgxlsk0ARfKJJYKTgxquRKQbDYaOQGwVQNzPbU+pLvnbsTmEMtRceQ8K1HU0skXuaZBbwvMCgR1Bq0RRzcs/KGtbtp7HUgE8mTBQj/0wlWOlkH4xb4YJfjD1cFTWoWJ9WkYtcJNqrNfIdfT1EqCLhiSdb2kYidM3GZ1W+VNzFyJTvBzNTyUDO8/L82nr2q19riex7dtYj+mnMqWwfDPhAfPZxifpy1INfwKnehM+/yMeQBXzrS6/MfiLJxYqjLJ2/dmQjDEYz3b1ESYGCo1xJkGL/Ky3rKCHunFskj8X1BC7b3Th41lSYquVrwlsDqv+U+CWhUkzG0vugyWfQHf7WlHjC5YroWVqstEc0cJHaFVXAq9dYi6dhI+2VgDyOPDPLV9KWf+VJa7gHoBhY+M7StJaUEZocDwu/gIECPK0VR2qYQkHLkTaiwJQ8cXbh/DqSNquaRpiQ3q1phTicKCHxriVcEy/Ck3Gfr2ttaHAJeiDFK8WQze7RHR+PtM8Iu01z5G23giT7ejYwvFhXLamV9jeIzX56eM/lhD3wJU4xIAp/AyvUO+nxhJ9PvouUDtSOs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(136003)(39860400002)(346002)(376002)(366004)(451199015)(41300700001)(8936002)(66946007)(5660300002)(8676002)(54906003)(6916009)(2906002)(66556008)(316002)(31686004)(4326008)(6486002)(53546011)(6506007)(478600001)(66476007)(31696002)(86362001)(26005)(186003)(83380400001)(2616005)(6512007)(38100700002)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RXlIQXFpVSsrcEpwWlRPQzZmWkp4L2Q1TVNhN3lZdUlHNWRHM1R3ZS9IV3dy?= =?utf-8?B?UlNXdFAvR3llRTlNVStlbzJVZEgrYnVFWVo0VWJZYVdtYk93YVVUNThkaCtR?= =?utf-8?B?WTFLZWNxVUVSQTFCWDk1Rmlrc3kzU2l6MkgrS2hhNk1KMkRXVnd4OTd4NEwx?= =?utf-8?B?MDRYMGU2ajFXRjQ0WjUvWjRhVHdNbkttZTVlL3lhdU9xUVkvdWFyUXlTa2hT?= =?utf-8?B?MDNpWi9XUFlGZWowd1BZVFdSNU1HMU1YT2JEWVlVRGlZMVJNY1cxSnpoOHFP?= =?utf-8?B?OGtBcDE4NU5hbGlNUHd2dU9iUitNYmV1NmsrZzM4eC9wN09XdER2QitpTms4?= =?utf-8?B?MXBIVHhnQWZnZDQ4WEU0RTduQUIwazhhRS90bzRqTlZ0LzVBMzRGeDZxaWpr?= =?utf-8?B?WWR4WXJ3YTdsMjd3TlVKa0hBYUFNZU1hQWxNVEc3YWNHQ1lQaVJZaURNMnJq?= =?utf-8?B?VkR4K1dXRE55NjdZUkxWOVJFSFIydDdieGNxRzFCcElvTTlHOHVyMGMvM1Z6?= =?utf-8?B?cFRTUGZoaEhpckZHMUhCT3NyNUxJaFlkbWNCbkQ3NktQRGRzVVFXQTdlTTh1?= =?utf-8?B?Z0l1dFB6THFnd3lLZW1DZzRFem9ZNENvRlhrd2dvaUlHRjJwNFVsZ0JyRThM?= =?utf-8?B?ZkpMeE52cXllTFNGV09WRW9YVXlwTHMyOG1lRVJPbzdESTdDeUNyK1lEZ0pr?= =?utf-8?B?eDUrQk81MWRZbXI5c0RQdDNsWG5lUzNoTUREM29CaXZpQlhaZXAwL2FydTNr?= =?utf-8?B?VlJTenJwY0tORUtnUUlETEV6OFNtNFo2NHJ5eGFpeGhmT1ZScjU0UmxlYnN1?= =?utf-8?B?MGZuUnNYd0tSVnIyeHN5bDU2VjR0QUdKVWRrd25GQUVQL1lYVGg5U0s4YWdF?= =?utf-8?B?bzFQdHk4bU4wK0ljY1NlUTVlNnBoV0RRcUVOYlg1eVJmTVZtUXZzcFRURHV6?= =?utf-8?B?OGduYmh2SE1IamF5OG9UbTYrVFQwdTFJeU9ETlRaVTBVYlpUai9XYXd5QXVV?= =?utf-8?B?R2hJbW9CWlRPb09EMVVVTWZQUXFPeExobEIxZWlIbldhcTFSZ1FtK0hCZFNy?= =?utf-8?B?UnJYVUFGU01ldHQxRlFkOVFXM2lQSUhWbDBaQ0Y0Qk5XV3VVV0NMcFdwdlpj?= =?utf-8?B?NTMzK0ZWVk9JbndKck16Ui9nUTFsWTlFa1QwQkRldFJyOGZ2RHM2Z1hBc1d4?= =?utf-8?B?ZnJsaktQdnRicGNqcW5oS2dZb1g1ZEFOSFRqeW1hblVRaHRFd3ZINkdVU0tq?= =?utf-8?B?SkNVKzZZVFlMRjNOdE5yRVlhdFNqTHRweGJUWlg1aHlaQ2tMVzJHaFdEeVR3?= =?utf-8?B?eEFMeTFyQlVmRElvcWNRc3pCZmMzbFVOZU9FNDg2K0NNQ0F0TCt3SlhuWFpW?= =?utf-8?B?K2h1bHBvaERyV2tFNGY2ODErYkNXQTFCa1ZjSEc0aC9QbldKNXF3VlBvOG1H?= =?utf-8?B?N01iWTY1T2ZtUWtKelB2QmFRVVZlbDhKdlhURy9NaEEzK0hCYmtQVjdqMUpo?= =?utf-8?B?Y0FYWGxJNFpQNTV0eCsvVTZ3bDlYTlplT2JKNHE0WFFxZUdaZzVKeUM0cm9p?= =?utf-8?B?am9tVEpVZkN0VnNJSURjWXZRWHZad1NOOEwrVmx4QWJmUGs2UWc5V3Z6aXVU?= =?utf-8?B?cFU0VFNQd3FwaDd0SSt6aVhjYWJISm5YT1p0RDFwbm11bm1QcUVZSHNXbFpB?= =?utf-8?B?Tlo1NWt5N1hZR2RzaGdWNi85ZWtrK0tBV1F6RDJEeUdWR2NKNHhJM29zdzVy?= =?utf-8?B?R2UxOTVDK29LUjVvSnhtNGU4b1ZVWTBOT2NIaFZFSW8vY2xmNjYwNzUyVG9Z?= =?utf-8?B?NC8rMlVnTTkwNUoyNC9PeDgyN25VV1lYYXdyaTRiR2xNUldSK1Q1R0puTnU2?= =?utf-8?B?NDlpNlErVDBPTGR0T2grN2wwQkx1alVacXhmamVLN2FXZlAremN6c1JZWU1h?= =?utf-8?B?U1g2WEZKTmw4Q29GejkyZXo3bkhyWTVXckVpcHd6TEJHbDNUZE4zUEZoZEJT?= =?utf-8?B?bU1NQVpYZW9tK2Q2bktIS2V6ekh5akVCQkU3cXFsRXpRNmVOM0NOamh4Y0JG?= =?utf-8?B?OEZNUEhPOE1yRFpIMXVkN0ZLZzFRODl1cTVselQ5M1BtN2Vmb3A2M3hkQjdC?= =?utf-8?Q?SG5Jo8ORettOSDezFjgogHYUq?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b7984aa7-66dd-4f7f-6884-08daeeed8a03 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2023 07:22:01.7891 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 26BJLJl2LdsUqszAbkNVJqq39/92P1W+nwUEabl/k7bT+DfoS+YM7ywFnA/1ieI16OB91HHbZ/S6U+IKItZ2vg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7051 On 04.01.2023 20:15, Andrew Cooper wrote: > On 04/01/2023 4:29 pm, Jan Beulich wrote: >> On 03.01.2023 21:09, Andrew Cooper wrote: >>> --- a/xen/common/compat/kernel.c >>> +++ /dev/null >>> @@ -1,53 +0,0 @@ >>> -/****************************************************************************** >>> - * kernel.c >>> - */ >>> - >>> -EMIT_FILE; >>> - >>> -#include >>> -#include >>> -#include >>> -#include >>> -#include >>> -#include >>> -#include >>> -#include >>> -#include >>> - >>> -extern xen_commandline_t saved_cmdline; >>> - >>> -#define xen_extraversion compat_extraversion >>> -#define xen_extraversion_t compat_extraversion_t >>> - >>> -#define xen_compile_info compat_compile_info >>> -#define xen_compile_info_t compat_compile_info_t >>> - >>> -CHECK_TYPE(capabilities_info); >> This and ... >> >>> -#define xen_platform_parameters compat_platform_parameters >>> -#define xen_platform_parameters_t compat_platform_parameters_t >>> -#undef HYPERVISOR_VIRT_START >>> -#define HYPERVISOR_VIRT_START HYPERVISOR_COMPAT_VIRT_START(current->domain) >>> - >>> -#define xen_changeset_info compat_changeset_info >>> -#define xen_changeset_info_t compat_changeset_info_t >>> - >>> -#define xen_feature_info compat_feature_info >>> -#define xen_feature_info_t compat_feature_info_t >>> - >>> -CHECK_TYPE(domain_handle); >> ... this go away without any replacement. Considering they're both >> char[], that's probably fine, but could do with mentioning in the >> description. > > I did actually mean to ask about these two, because they're incomplete > already. > > Why do we CHECK_TYPE(capabilities_info) but define identity aliases for > compat_extraversion (amongst others) ? > > Is there even a point for having a compat alias of a char array? To be quite honest, for capabilities_info I don't recall why it wasn't aliased. For domain_handle I think the reason was that it's declared outside of this header, and it could conceivably be a more UUID-like struct. > I'm tempted to just drop them.  I don't think the check does anything > useful for us. As said, I'm pretty much okay with this, but would like you to mention in the description that this is an intentional change. Jan From xen-devel-bounces@lists.xenproject.org Thu Jan 05 07:58:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 07:58:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471675.731615 (Exim 4.92) (envelope-from ) id 1pDL8G-0005Gv-5q; Thu, 05 Jan 2023 07:57:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471675.731615; Thu, 05 Jan 2023 07:57:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDL8G-0005Go-1Z; Thu, 05 Jan 2023 07:57:48 +0000 Received: by outflank-mailman (input) for mailman id 471675; Thu, 05 Jan 2023 07:57:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDL8E-0005Gi-Fc for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 07:57:46 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on2074.outbound.protection.outlook.com [40.107.15.74]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a1f8aea2-8cce-11ed-b8d0-410ff93cb8f0; Thu, 05 Jan 2023 08:57:43 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM7PR04MB7191.eurprd04.prod.outlook.com (2603:10a6:20b:11c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 07:57:42 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 07:57:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a1f8aea2-8cce-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eB+bYGx7rKD0h3IHROmfe58JArXY3sX9rdfEYrKV+m5mvUe2g3WCJJil5hsBGub70gxleslJ5bVgApS7TpFF2XvDH2qGj8DecX5ZtjMlzXftgALuIPJtQEWA6gLQmZznKYYwWjEj2tClsKmQr7jULRbFY2DbolQumyJi101cLaGSb+/5TqdHe8tBcETbKw3pEYWn+NxyJ5HdsYLHMqcx+DrjBRDqkbOjEs3zzpFK/Z2pQemApNEXkvsp6bQHZKxCdhYt/P6bAiyfSq/P9RgK5PdpmdeaDhoOdWvNGEFBWrlamYqsfNK03EWaymW78XLO6TZZdSKHYrfpb4wKDyxxBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2u/5XapuE10KqU2DCj7P5PcSdhcY/Y5VJzSmMaxZnD8=; b=LJu3RGSRt/odNK8gTey0v+AIFAa6CrKIr+UJbkTXsLRexf3968W+tdZveCO0ImuBQcmiz2Iyy+MadgtF3BaD6XbxUqZ7Oz2ilPBW2VaGfJjYbx9veK+4bbq/e5LclcU8r4t98zE3wWmWFSHaABjzx4EVdU6YVNlHO3nChL1zHFSMAZTDrWH2J3F1qE2hgjXpPgbZHHG7XPWnwaVM/7c9v+eYu/tP3P0XRtlrA6CKgl8+MS4ETNLp08rXGnfEfI9pWaLWuTNW0SRexIcFOQmR3e+u8fK5UpUVPeW7b51hFXGH4xXoykfSCqECb/pLkkEeVtSXmQHKCIhkuzFYCGJKaw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2u/5XapuE10KqU2DCj7P5PcSdhcY/Y5VJzSmMaxZnD8=; b=ZDANJ3SVwo0ih9wc7RpvJsCGQEeYWWhCcV0ywCVt3c+tsjAjxrNUiCZnFCGFISCI031fglVGwmaRWnh+WBqVFZCh2b+h3lrH4LHUxxT+0hIS/o5sI9oCgmi4XMJ9pjPjJ4Jv+wjyA1tmSovcx9TpGOjmiSIPDGgaoifdWbYBg5/gxD6+Fr1sFyUXQ+xvdCZFkHHGjj2dJYqaOG95EYhovXaEGCxiOOXWGDNvIHviuB++G7PSiT7q1HhC9u6fiFIKA3h0I+xfZ91w4bcTx4q4Rb9nqhGS/mB7/hhHI2yvMx3ZJmZBIh0A+qkuHwRI01qM8ACgxBwSfTNYxlMLaeDigg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 5 Jan 2023 08:57:39 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 3/4] xen/version: Drop bogus return values for XENVER_platform_parameters Content-Language: en-US To: Andrew Cooper Cc: George Dunlap , Stefano Stabellini , Wei Liu , Julien Grall , Xen-devel References: <20230103200943.5801-1-andrew.cooper3@citrix.com> <20230103200943.5801-4-andrew.cooper3@citrix.com> <540a449d-f76d-eb16-4f98-c4fb3564ce98@suse.com> <7dd00ce3-a95b-2477-128c-de36e75c4a34@citrix.com> From: Jan Beulich In-Reply-To: <7dd00ce3-a95b-2477-128c-de36e75c4a34@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0092.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a9::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM7PR04MB7191:EE_ X-MS-Office365-Filtering-Correlation-Id: f49f8969-8513-4cbb-e33b-08daeef2857f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TBx8dCfGUESSCwjM3zUdMwNaFoPJpNtAJyRsE23ibH6JPGFR85nJh2IqmWwSrPVf+wYLc1Aku2woP6SCkrsr6FDkWchCFhDLTPAYOSBX/p8nN6u2mmCNQv5CW+Itw2flSHndTQk8npBSlrItUlRT/2YwujnXPTNCUT/FmWBtEPiCmD4+xM5Hpev2NonWYSQ9qEiUpIzVrQ59Pp1VNlx86Klwznug+/lqaCr/2rXdoFTxIkpyE3zRZ3GONPvFDs2Wf4H0wk56k3t+QUD+rnFwzF/hFSVSCJQj5btiKWY32rsSNvaLz2cv9g1NOoRdaLZBf/n5KdbNjn6zuKOyN7AaDPsLo9pk8dmRyXu9NObUMifk9L1XTKDdqvMy0gqRFe5u0r68Qcpxhsftp15IVM5UMpAVGOGOpmH6ZjV2kffVnjhTb8y6066whzfil32E32IMB41XwNECtWQLcKg4A01SMO9Lg+5jnp9aoM+tnawo/fKWpFT/rfneKl0kLfhx0yNM6mF7H0lT6h6zavLAVCgm95I3f9CmxHGieGN2fJSCDKhPHn1tB2kHKTpGcUF82nx3uf29gDSUwUTyEXTsyh+m3WfHKCJS9OKVRJeSfJIrtB5P+1ySx5fzZcIJTVlQxdfKgR2dIRt4wWInwY3iyBKsiWFtFhXkecqHLxjB7KNGwf0OwDltpLn4thRtfwq3N5Sj5/Kp+x2q1A+eLO+PHjxzWrSwxnigQU6Q4e+pkILEwHM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(346002)(366004)(376002)(39860400002)(396003)(451199015)(26005)(2616005)(6512007)(186003)(31686004)(86362001)(31696002)(36756003)(38100700002)(316002)(6916009)(54906003)(2906002)(41300700001)(4326008)(66946007)(8936002)(5660300002)(8676002)(66476007)(478600001)(6486002)(66556008)(6506007)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VnQ5OXhFQzZkRXdiTFJKaytlQVdQTGowSXBwbXlIclNNN2xJWituYnpJZ3B3?= =?utf-8?B?emsyTmcycVlFLzd1eGNndXVkenpRYkdEUnhjVEUwclVQOGtrdFQ0dzAxNnVm?= =?utf-8?B?V3J3Y2laenpaRExtYVgzajVJL21EQnJaRUNoWHg3L3p0ZUFyMnRlM3hJMWp1?= =?utf-8?B?SXN2KzBPRUF6Q1pCZVdKK0JocVBpY0Q2Mm5Jc056K2RSazRpdmRacEJpRXg1?= =?utf-8?B?OFhxaFMxN2dGa1ZtU281bG1Sb29Cck9kcUZsaFZoREE3anY3VGE2NzNtSENU?= =?utf-8?B?bVZicXNsMEFGSnNaSS8rVFc1WjBoUmh2TnR6VGFvcU5vUXUyMEE2WHJHWlBU?= =?utf-8?B?cUd0NERNSHpueWUwekpmTFlNZFRSS1k1TXFUSXMySGxZdnlybGNvZVp4NDVu?= =?utf-8?B?UGtOVXVHUFkwQlJIdmtrNjB0cG5xQXZtRUZCN2l4WTVCVHZ2TTgrRkM0alRu?= =?utf-8?B?UDNHcXZkcmhWd004SU1CdnR1NVNwMUl3dlV4b3VoNTVodTZMQ0dqWS85ZDVt?= =?utf-8?B?NFRGWitDRStMOWZsQUdOblIxWUt6ZVp0OXJjTHZibEVaVzh4OE1zMlQwU1BC?= =?utf-8?B?OEprYlp4bXF0RmNvcWF4MkNLMVdaZnR5Wlh1My9vS2U4WGRXbHBLWGJoQThZ?= =?utf-8?B?WCtUVVZxOUxhOHlKTC9IeTdJanhPa2h5ZE04Z3JwT1hMZTZoai9UakdJRTZQ?= =?utf-8?B?dTlSclQyQm1LZURoaVpzSkVObkxSV2pQR3RzMmQwWUpQY3gwaks5am43TklY?= =?utf-8?B?RzFNZFFzcmJMN08rYWd3V1NucHpJa3JkSGUzblB4QitGcUIxaUlheTBnNUZC?= =?utf-8?B?bXVKVjZaUGwwdkR2UW90Wm5MWWJnQk14bTVpak40bVpsa25lZ3EvOUtUV0ox?= =?utf-8?B?akZYQTVMSkF0anVua3dzUTRhd01KMmRlMjdDdVNkekRrem5sWmJVOXhpUnZY?= =?utf-8?B?eDBaSTNzR0VMc1FSdEQzdkR6N25ReEpZdW5oaEcvR1BIWWNxVGRFa1N5TWMw?= =?utf-8?B?cWpLNjhLZy9SYjB2d2I2VTJWT1FQK1lZRlNxRm5CcUc1OEVyTEQxMzEwYytk?= =?utf-8?B?N1pyRm82RW9MRDdxbUd3M3grM1IyUWdHRDg3MEkvSjMya2RrZVkySk9pc1RI?= =?utf-8?B?YmJ5bDlNaGQ3RVZRczB6MXk0SFM3TlhZeTFES0tiUEViSS9naGNIWE5hdTZZ?= =?utf-8?B?d2lPRVNBSUR0QlBnczRjYVhiZXNmQjk0SFhlNDdudmkxSEdoNGc3amUxRFZp?= =?utf-8?B?OCtjYVJaUEFQQjlORHlQN2RVdHE4bUl2djMyWHc1cUY5VHZpUUxGWUFZSjV3?= =?utf-8?B?NHpRaU9PRWZLRkJPMS9EbWpnNGlRUEdZYUw3OEUvRjV6VWN0NUFPbURPSm4x?= =?utf-8?B?TUZiOG95MUtEb3EvZU1Cd2U0bUVLUFlGaXhNYzB3UXgxQW16dzk3T1lzaGFK?= =?utf-8?B?Y1RFUDhKOTlzbnYvRmdMY3ptZkN1enJ5R2N5WmNpKzBROTFnQWltUHdFVFhu?= =?utf-8?B?S1pUL2xwS1NkRnZOWEMzVVp5MUh1RHovcXpWMEdtOXFBVEs1MVJtR2lEakRs?= =?utf-8?B?bEYzYXJXemJ0VjFxZVQ1dEJ4Q0lDTzZrOVc3cFF6WFdPYlhRZ3pZVG1OZ2U2?= =?utf-8?B?MjBuTVFuN0t2RXV2TXpWVk5oQXBnbTIwS3lZcjJRZzFIMXJrZ3llRDhDQjVX?= =?utf-8?B?ZzhpZUFsK1pCcDRaenVIZTM2RExUUEk5b1hKQjFIandnSi9JRkxCQVFSc0Jh?= =?utf-8?B?YU9JNzAwQVphejZnYUJKd2NiWW9IeXM5bXZuUFJ1ek5maC9jS2hER1B5MGdl?= =?utf-8?B?VjhtZ2V1bllzdEtGbVMzL0dXOW9Zdis2dnE5K1F4WnU1aU1aNnNyNjJtSmdI?= =?utf-8?B?VE9QenllM2hPSlhIMG51Ri8vdmF0eU03NEVjRVVhLzVCWXpXS1FiMURmdlow?= =?utf-8?B?aWtuMDlGUUZVSjVJeWd1bnFRL1JIbXo5d3phRDIxQk9XS3pWdFJpdFllQlRM?= =?utf-8?B?aWV2UWdYUlZDZUJRLy90U0l1YmxXOHpJQlYvdmFRNU9CNC9RS3N3Vk5LRkxk?= =?utf-8?B?dlNjaTlyTGtpWjRjRy9IVmpGZDJxbkxMZEtOWFpPbGgyR3pTZWhNSnY0Y0FM?= =?utf-8?Q?e/cMS6grRiLS5eNutA6SVGzGA?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f49f8969-8513-4cbb-e33b-08daeef2857f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2023 07:57:41.6999 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0h4Hsz3EAHq1BFz+A73zKaLfpIH1565Nws3qTHJXO7E/S1+SxLUPq7a0oCbQzO73AgiDMAr7427rL/GSjkrhHQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7191 On 04.01.2023 20:55, Andrew Cooper wrote: > On 04/01/2023 4:40 pm, Jan Beulich wrote: >> On 03.01.2023 21:09, Andrew Cooper wrote: >>> A split in virtual address space is only applicable for x86 PV guests. >>> Furthermore, the information returned for x86 64bit PV guests is wrong. >>> >>> Explain the problem in version.h, stating the other information that PV guests >>> need to know. >>> >>> For 64bit PV guests, and all non-x86-PV guests, return 0, which is strictly >>> less wrong than the values currently returned. >> I disagree for the 64-bit part of this. Seeing Linux'es exposure of the >> value in sysfs I even wonder whether we can change this like you do for >> HVM. Who knows what is being inferred from the value, and by whom. > > Linux's sysfs ABI isn't relevant to us here.  The sysfs ABI says it > reports what the hypervisor presents, not that it will be a nonzero number. It effectively reports the hypervisor (virtual) base address there. How can we not care if something (kexec would come to mind) would be using it for whatever purpose. And thinking of it, the tool stack has uses, too. Assuming you audited them, did you consider removing dead uses in a prereq patch (and discuss the effects on live ones in the description)? >>> --- a/xen/include/public/version.h >>> +++ b/xen/include/public/version.h >>> @@ -42,6 +42,26 @@ typedef char xen_capabilities_info_t[1024]; >>> typedef char xen_changeset_info_t[64]; >>> #define XEN_CHANGESET_INFO_LEN (sizeof(xen_changeset_info_t)) >>> >>> +/* >>> + * This API is problematic. >>> + * >>> + * It is only applicable to guests which share pagetables with Xen (x86 PV >>> + * guests), and is supposed to identify the virtual address split between >>> + * guest kernel and Xen. >>> + * >>> + * For 32bit PV guests, it mostly does this, but the caller needs to know that >>> + * Xen lives between the split and 4G. >>> + * >>> + * For 64bit PV guests, Xen lives at the bottom of the upper canonical range. >>> + * This previously returned the start of the upper canonical range (which is >>> + * the userspace/Xen split), not the Xen/kernel split (which is 8TB further >>> + * on). This now returns 0 because the old number wasn't correct, and >>> + * changing it to anything else would be even worse. >> Whether the guest runs user mode code in the low or high half (or in yet >> another way of splitting) isn't really dictated by the PV ABI, is it? > > No, but given a choice of reporting the thing which is an architectural > boundary, or the one which is the actual split between the two adjacent > ranges, reporting the architectural boundary is clearly the unhelpful thing. Hmm. To properly parallel the 32-bit variant, a [start,end] range would need exposing for 64-bit, rather than exposing nothing. Not the least because ... >> So >> whether the value is "wrong" is entirely unclear. Instead ... >> >>> + * For all guest types using hardware virt extentions, Xen is not mapped into >>> + * the guest kernel virtual address space. This now return 0, where it >>> + * previously returned unrelated data. >>> + */ >>> #define XENVER_platform_parameters 5 >>> struct xen_platform_parameters { >>> xen_ulong_t virt_start; >> ... the field name tells me that all that is being conveyed is the virtual >> address of where the hypervisor area starts. > > IMO, it doesn't matter what the name of the field is.  It dates from the > days when 32bit PV was the only type of guest. > > 32bit PV guests really do have a variable split, so the guest kernel > really does need to get this value from Xen. > > The split for 64bit PV guests is compile-time constant, hence why 64bit > PV kernels don't care. ... once we get to run Xen in 5-level mode, 4-level PV guests could also gain a variable split: Like for 32-bit guests now, only the r/o M2P would need to live in that area, and this may well occupy less than the full range presently reserved for the hypervisor. > For compat HVM, it happens to pick up the -1 from: > > #ifdef CONFIG_PV32 >     HYPERVISOR_COMPAT_VIRT_START(d) = >         is_pv_domain(d) ? __HYPERVISOR_COMPAT_VIRT_START : ~0u; > #endif > > in arch_domain_create(), whereas for non-compat HVM, it gets a number in > an address space it has no connection to in the slightest.  ARM guests > end up getting XEN_VIRT_START (== 2M) handed back, but this absolutely > an internal detail that guests have no business knowing. Well, okay, this looks to be good enough an argument to make the adjustment you propose for !PV guests. > The only reason I'm not issuing an XSA for this is because we don't have > any pretence of KASLR in Xen.  Pretty much every other kernel gets CVEs > for infoleaks like this. > > We feasibly could do KASLR in !PV builds, at which point this would > qualify for an XSA. I would question that, but I can see your view as one possible one. Jan From xen-devel-bounces@lists.xenproject.org Thu Jan 05 08:15:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 08:15:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471686.731628 (Exim 4.92) (envelope-from ) id 1pDLP3-0008C1-Vm; Thu, 05 Jan 2023 08:15:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471686.731628; Thu, 05 Jan 2023 08:15:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDLP3-0008Bu-T8; Thu, 05 Jan 2023 08:15:09 +0000 Received: by outflank-mailman (input) for mailman id 471686; Thu, 05 Jan 2023 08:15:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDLP2-0008Bo-0o for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 08:15:08 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2066.outbound.protection.outlook.com [40.107.247.66]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0fdab74c-8cd1-11ed-91b6-6bf2151ebd3b; Thu, 05 Jan 2023 09:15:06 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM8PR04MB8020.eurprd04.prod.outlook.com (2603:10a6:20b:244::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 08:15:04 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 08:15:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0fdab74c-8cd1-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T0Fk8ZV87V9TBQSrXBFa5Pihfxwot/6gD6VgL2hefcfA/ykN1oSWoRt/EEHbW58JlqpdjOAp+NP7zSEOltp+6c0ivNIvXqlMtTvur8TcBqwU57oNR4UztpILxmMg5DmVLRMMH0YmI/C2va7JxjWuOCf9DOb3UaPDmx5NiZJJmnZsQ7KRuIkMRbx7ZojwgG71NPEepcdBXoqyW7B74lLL9epwKTdYn5Mz4N5XzgKsVQNa83JfFVkbcr5rfzXPhk5HD1+hJ12NIilQF8A8JvJagvp2JV3XUqewQF3cz4nBRyWiOlbLSz2bQIx+Cykmquu8w0ikQybwFPIkWSFLj3KNZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zYVrlbX8302WXqllVpFUD8somimCH2U2T6URi+6uf4s=; b=Juy10aC5QMK+ZSCdhuMRudsb4JpV8T2xaHYulUInMks9ZfX7RjwuUhPEvk4h7DfgyKDmnczuHkFHMtzGlTcXJjCh+eUhunEG/oyTDSATxkgAv0/WWZBTaqVD0VZlrYgjUZtXmCF7udczPpqhq+VGgf7Y1uryh3RQ0qED9ETrRLO6YYNHDZ/LBNNetNrcJcpu0A0/vTu+tMxWLviGUEcu8yOXy2qboShPzZGFhSfAIk8q3YJ/JuSSpwcJqRbD0kKXHbqm5MpdEjBVb46cjrkCXgxfQRxal0j3BUZM2adhxF+Ig1cPChk0xWUgIkt8ikChCmZTx6wUnJJ0q9UlPgBGyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zYVrlbX8302WXqllVpFUD8somimCH2U2T6URi+6uf4s=; b=rCT0kTdHZM+MwBQOr9BzqQWBes2miZQR8Io2g89wgbktQxTipm1sbrsOeWO01tUip1u+xtzrOZKZBPUVvi+9lku0w3FEEhIDrnqaj63sUl/FaeMJ3S5R+pZgGDMaRMNF/MMbSiupJ92yYqke6pjiorTXzU8UbqJVwgGVjdN4ZEhA97q0iY42zTj+NEn9/8HwbEHIjAR1V/SyVwJQ8eNFzidJP9qKwWOh4nowTKntkY9ZX6iJ6f2N/DLGO2gJNEH2CxLLT5+/AkkSSw0+YdOQyjcuogEgmiWgjyGjOFEMmIZsX9TTXVl4s+RSoyNgo6jCHTQ36HrI7R6nNe4YHNJETA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 5 Jan 2023 09:15:02 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 4/4] xen/version: Introduce non-truncating XENVER_* subops Content-Language: en-US To: Andrew Cooper Cc: George Dunlap , Stefano Stabellini , Wei Liu , Julien Grall , Xen-devel References: <20230103200943.5801-1-andrew.cooper3@citrix.com> <20230103200943.5801-5-andrew.cooper3@citrix.com> <9c9cedd5-cca7-95d4-00bb-f34a56de2695@citrix.com> From: Jan Beulich In-Reply-To: <9c9cedd5-cca7-95d4-00bb-f34a56de2695@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0166.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM8PR04MB8020:EE_ X-MS-Office365-Filtering-Correlation-Id: 6e40d968-ce7c-4b69-3737-08daeef4f2f3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dC+Z0LrCgx7J61M1ks1w+ze+cxyEs00MHcT0Lebwg01gRvmV5mhYhomwKndyQ6eQFkNmt4+Ujhewn5vX8Vl/b+9bbWopggEdSfYBJfDglQNbGN5nGXdvxnNr1QeHI9DmgL+khvx6dAGFUUnfnVwldwWhpK//N2RUvxIZH3AezUSGzH8KQBja6G+tjfGypqvF5smNkmU9KqYf48j4mUJ9u3163752WyxDgdIrxTyurwqi6lLpPLjCTxqw7TuasI8rdcMewAur7rBU+rPlz1ENrpWBjgZd4Qa7EOOp7Getdv4hR9qDxKqMQMhdrUn2+CD9U4KaApanlQ8UJ3pwMHLsb6/n6spdu3SbvVrh7iRrGABmMdWwqqrQg5vBpAns3ObbILK+VlXxUyDLUW6EuQvtEDcIsgHp81K0B50+xZnf7MbWi+pFXxdHYmC2r6OLbMofOHedE1qZv5EZ2YuC6VEFN+3lj6SR80t6pM84p4caTUe6fQ1Dc0Ujnttc/9sTC1Us2hJVSQasNojaUzc4jupLsVm5kR6PZ413iKlp6aHIoFdXADdVsChkZfwYCknknfYuxUaNcGSvCImZJpZxNVNB5VKDNoLjzPdM2Howm0ayuuWnbfBuYO8NNsMk3QW6GnZL4KzUJdQ/wxBIM6Dyz6YvWu2udVfwmYXTF0CYnuyjruk7OP9cKOjxPctdxjGFOC+wfLsMJGwz+zzl7IDFlGGoGaTpXIGWMxmpr0GtrIWlDlM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(346002)(396003)(136003)(376002)(366004)(451199015)(478600001)(38100700002)(36756003)(86362001)(31696002)(6916009)(54906003)(316002)(66899015)(31686004)(2906002)(6486002)(2616005)(6506007)(8936002)(186003)(26005)(8676002)(66476007)(4326008)(66556008)(66946007)(53546011)(41300700001)(5660300002)(83380400001)(6512007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S0xvVlY5b0p2R2tSb2tXbVUxTlczdENnMEpOaDFkb212WVd6NkZTL2lERURy?= =?utf-8?B?cG1oS25ySEVkU29VMUdSMlJyRzl3TlMwUVptOWd5OWtpdG5yeUppbWRoVEVO?= =?utf-8?B?T2V1c1djdHNTWXFSV1dkQkcxR1dzNmFSaGJvVzlyYllvVDRxd2g0ZFlZL2M3?= =?utf-8?B?OFM0bnFhMkhaRUZweGZDRUQ0OG5pN0dGc2xmUVZYV0dLS1loMFZTZHBVUU5E?= =?utf-8?B?Y0xkNENCZ0hUcDBIdkMxSktYYnBvWGV2TW40Sm5VVGQveXp4bFM5b250QzRv?= =?utf-8?B?UDZiYzZQcVUvOWxQdVZJRHZTU0VmRkx6ZDdWLzM0QTl5NTg3V1htQUI2U0JP?= =?utf-8?B?SnM2UFJSR0YzSUxKSVF5elRrWm04SURyRW95cHUrNURhaFlWc1RodUZkN1o5?= =?utf-8?B?ZnJOK1JhSUcwVXBNcEJyUDVhZzBPT2JOUHhtcVlETyt2aWtiNVpuY0lnVzdP?= =?utf-8?B?S25URjJ6ZHR4TzlBMHU1ZnIwVktiOVl6OE54aCtXMlo3YlovbldiMUFuZy9P?= =?utf-8?B?V0c4dUlBSVFBV0xKQjMwUnVTZVoxb3ZpVWpRMlVIWkNqM2hhZkQ2U3hzMnVi?= =?utf-8?B?SHVGTTRvKzZEWVJLRkpTNldBckZUeXBLVXd4YXlYVHRjRTFyN0JSU2I0dmRV?= =?utf-8?B?Zms4TVpRNkI4UW44NkZoMGk5aEhobjhHVCs5RE5qZGc0TUZ3Tyt1NGFlQW40?= =?utf-8?B?S3E4dCtzR1BrWjZWay9Yc3AzWnpmMFRobHcrOFZNbDJHNHBLZy9Ya1BOZ2Qr?= =?utf-8?B?eEYydFRXTzJ0QkVhZWoyQlAwazZPd2EvT1lPenJlSE1IazIzSkk0NU1kK2ps?= =?utf-8?B?WlNIZVpJQWhKTXNFVmU0QlFwSGhjVzR5TnFYVHdjcVpsNjd1ak9PQXFTRyt4?= =?utf-8?B?dGg1WlROQzhrQ1Z1YXJJUHpCQVBoNjJNTGlrQUpGY0xlTlFvYTdUTFNTMWVP?= =?utf-8?B?TUo0UW9kQXVuS1FKeVFBUDlYNWZZai9zMTVFOHhWbGJpVmNLK2RCMnpWeTE4?= =?utf-8?B?N2JBZUVrSXlYZE9YaTVQZ0c1SDV5eWpDU2JSd2MreGx4eElHTUMrQk0vblor?= =?utf-8?B?aGhjdzVrQnJvQ0pJanlscWFWWUo4d3BPVjc2azFaT2puRXVINVVhZDROQ2dD?= =?utf-8?B?dTEyLzNLY29DeDBzeXV0L3Mrc1dDZjlMMDdOdThEMXdmSytnNk5IK3B4UjRG?= =?utf-8?B?Mjl2aHcraG8wTFZRV0daVzBLbFBKNk1jQWhNNUFnS1IzVE5DR3N3R0hrd1Va?= =?utf-8?B?dDcyKzFuNjhrNzEzbEd4SU5mQzVIdm4yUEYyU3BwRWorUGQvRWZ0Q0tyL1pu?= =?utf-8?B?YWF6bDNqQVlnRlUreVdHaE5kM2N0UWVZUFplMFJGYzRQK0hxZHdzT3hvS0VL?= =?utf-8?B?N21pVjcvTzUrWjBPTmZIeTFwKzdaanJwTWI5SjQzK25VTTRVRUR2UWxGTEJ0?= =?utf-8?B?dW50Rm1ETmUzbGpMNHZ3UmgvTUh3TTdxTGJSUDJ6d3d5L0djbFFWdGJoQ01x?= =?utf-8?B?VENNNS9ubkxOSWVTWVRteXZ2c0VBZjBrZjJ0enE2anRUTWhuVkJ0bW8xTzlX?= =?utf-8?B?QlFHY2VLWS92d1ZQcGxGRm5rOUNyS2VwbzVoTThnZ1VtWU14VmwvaVk0Ukxl?= =?utf-8?B?YmJjVHFVK1RlTWdjN04zRklsYjBUak05RkdVcGpkL0U5aXlUbk5xeWJHZG8y?= =?utf-8?B?cEJ4RlFWSXJLTExnSEkxYktER0JyYWFERXVXZE5hQXExS3NhMlBiYVNZTDVp?= =?utf-8?B?eHJqR2oxV0tqTWZYN0lTWEgyYWRIeExSajI3bVR5VzJkb1ZhMWNGZmJsd0tK?= =?utf-8?B?ODNMZ21oZ3l2bG9URGRBR3I1RGdpSUd5dGxLdVlkZDA3ajczTW1BZkFUbXc1?= =?utf-8?B?RXFVZXBqZlBQbkJwRFczbFJmWVYyQ1hHb0dMenJMQnJ2YkY1OXQxOGtEK2ZT?= =?utf-8?B?YVJ0NEtJV2Nld2EwODJWRzM2UlpkckQ3U2R3K1JHU29ROWc5VXFjcmVmTjJ5?= =?utf-8?B?ZDBWWjQ3bWErTGVLekZmNUNaekNKVWFPUENtcU5GbW9oaDRtQ0k5cEhLZzZS?= =?utf-8?B?K244QlVEakRLM3c1MWQ5UDRBSG5BTERsN2VYVS9FcUlEV05mS25rY0F2ZXBF?= =?utf-8?Q?utvRic9M6LSZgIfeyDoU9JFJn?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6e40d968-ce7c-4b69-3737-08daeef4f2f3 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2023 08:15:04.3209 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Q8Xm8LYaC64KMNZyCbVXr7MAe2LrUKftR+CQwhxwXLOkBDwFHD0ZCkIfqGhmAkT9rh0xk5P+BRu3qPpdLjq0dQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB8020 On 04.01.2023 19:34, Andrew Cooper wrote: > On 04/01/2023 5:04 pm, Jan Beulich wrote: >> On 03.01.2023 21:09, Andrew Cooper wrote: >>> API/ABI wise, XENVER_build_id could be merged into xenver_varstring_op(), but >>> the internal infrastructure is awkward. >> I guess build-id also doesn't fit the rest because of not returning strings, >> but indeed an array of bytes. You also couldn't use strlen() on the array. > > The format is unspecified, but it is a base64 encoded ASCII string (not > NUL terminated). Where are you taking this base64 encoding from? I see the build ID being pure binary data, which could easily have an embedded nul. >>> + if ( sz > INT32_MAX ) >>> + return -E2BIG; /* Compat guests. 2G ought to be plenty. */ >> While the comment here and in the public header mention compat guests, >> the check is uniform. What's the deal? > > Well its either this, or a (comat ? INT32_MAX : INT64_MAX) check, along > with the ifdefary and predicates required to make that compile. > > But there's not a CPU today which can actually move 2G of data (which is > 4G of L1d bandwidth) without suffering the watchdog (especially as we've > just read it once for strlen(), so that's 6G of bandwidth), nor do I > expect this to change in the forseeable future. > > There's some boundary (probably far lower) beyond which we can't use the > algorithm here. > > There wants to be some limit, and I don't feel it is necessary to make > it variable on the guest type. Sure. My question was merely because of the special mentioning of 32-bit / compat guests. I'm fine with the universal limit, and I'd also be fine with a lower (universal) bound. All I'm after is that the (to me at least) confusing comments be adjusted. > But overall, I'm not seeing a major objection to this change?  In which > case I'll go ahead and do the tools/ cleanup too for v2. Well, I'm not entirely convinced of the need for the new subops (we could as well introduce build time checks to make sure no truncation will occur for the existing ones), but I also won't object to their introduction. At least for the command line I can see that we will want (need) to support more than 1k worth of a string, considering how many options we have accumulated. Jan From xen-devel-bounces@lists.xenproject.org Thu Jan 05 08:39:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 08:39:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471696.731639 (Exim 4.92) (envelope-from ) id 1pDLmv-0002HS-39; Thu, 05 Jan 2023 08:39:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471696.731639; Thu, 05 Jan 2023 08:39:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDLmv-0002HL-0U; Thu, 05 Jan 2023 08:39:49 +0000 Received: by outflank-mailman (input) for mailman id 471696; Thu, 05 Jan 2023 08:39:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDLmu-0002HB-9S; Thu, 05 Jan 2023 08:39:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDLmu-0003ib-5T; Thu, 05 Jan 2023 08:39:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDLmt-0003YF-OL; Thu, 05 Jan 2023 08:39:47 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pDLmt-0006Vz-Nt; Thu, 05 Jan 2023 08:39:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=CC6zXFyhJ98YNVHF1vPE1je0wOb/orcJsTo46y9U6qY=; b=s21RjYLLRzZ6U3Ws1Ya8x92k/h scEgDv7AlocVh0IY0H6LQgQK4TLUeLtJOMWqdmBbYFfBp5grYT6hjl4KZA4QXzb3ZGgK2UQf1kdvn oLAeq7yl+zEsp4JuQqymG5MzYzwYyL0TxMhAyC5vP2bkJea/XhVbGuZfoYqlTq4c84+Y=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 175573: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-migrupgrade:xen-install/src_host:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-i386-examine-bios:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:guest-start.2:fail:heisenbug xen-unstable:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=c1df06afe578f698ebe91a1e3817463b9d165123 X-Osstest-Versions-That: xen=7eef80e06ed2282bbcec3619d860c6aacb0515d8 From: osstest service owner Date: Thu, 05 Jan 2023 08:39:47 +0000 flight 175573 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/175573/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail in 175569 pass in 175573 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail in 175569 pass in 175573 test-amd64-i386-migrupgrade 10 xen-install/src_host fail in 175569 pass in 175573 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail in 175569 pass in 175573 test-amd64-i386-examine-bios 6 xen-install fail pass in 175569 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 19 guest-start.2 fail pass in 175569 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail pass in 175569 Tests which did not succeed, but are not blocking: test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail in 175569 like 175520 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 175562 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175562 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 175562 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175562 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175562 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 175562 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 175562 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 175562 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 175562 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 175562 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175562 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 175562 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen c1df06afe578f698ebe91a1e3817463b9d165123 baseline version: xen 7eef80e06ed2282bbcec3619d860c6aacb0515d8 Last test of basis 175562 2023-01-04 01:55:19 Z 1 days Testing same since 175569 2023-01-04 16:38:42 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 7eef80e06e..c1df06afe5 c1df06afe578f698ebe91a1e3817463b9d165123 -> master From xen-devel-bounces@lists.xenproject.org Thu Jan 05 08:40:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 08:40:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471706.731654 (Exim 4.92) (envelope-from ) id 1pDLo2-0003ce-GA; Thu, 05 Jan 2023 08:40:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471706.731654; Thu, 05 Jan 2023 08:40:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDLo2-0003cX-DJ; Thu, 05 Jan 2023 08:40:58 +0000 Received: by outflank-mailman (input) for mailman id 471706; Thu, 05 Jan 2023 08:40:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDLo1-0003Um-3i for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 08:40:57 +0000 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [2a00:1450:4864:20::32d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ab522935-8cd4-11ed-91b6-6bf2151ebd3b; Thu, 05 Jan 2023 09:40:56 +0100 (CET) Received: by mail-wm1-x32d.google.com with SMTP id k22-20020a05600c1c9600b003d1ee3a6289so757335wms.2 for ; Thu, 05 Jan 2023 00:40:55 -0800 (PST) Received: from fedora.. ([195.234.76.149]) by smtp.gmail.com with ESMTPSA id n17-20020a05600c4f9100b003cffd3c3d6csm1752711wmq.12.2023.01.05.00.40.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Jan 2023 00:40:54 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ab522935-8cd4-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=fZgScg//r5KpzoqMeCWFDkQSqGzHzzpOB/W401gAMtM=; b=TqO7OCnB85PKAFF38C3QVGCH5mxK+Y46APnEg13YshyyClqX3Ok8C4+Uq4mYpAhotM jzwi0GnpBFxDeKNN3z7KcBZ5JLZsuaw4d1o/YpUtTKBuLbhDgXql4Ti8XQ0otJtvFJJs EHavA3csOSEz/2zy/kdF+wWD5eD5fqIwybW+P1FNZIZlRR7aAdlZBiHJwlO86+6wzIvh q92rg76kyQhZk7Fwe3G1AMylMdBAyFsUdS3ye+IEFLNQLybLYOiM/BTGKHI4kNYsWWj1 +jgM3QxyN+PKnUWoqd7NSOKOTJjGe43SxyOE8BAyaPZKs+OD+GOpgt6gDxJyY1TxRPDE CZkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fZgScg//r5KpzoqMeCWFDkQSqGzHzzpOB/W401gAMtM=; b=inZWW4C78Mg+PEIDtukyX0xDQ5YWYz5pR7B68otZsZTryYPGT5+mlBT3sYyQbCU6Fj cZKUISy7WBwXDgmgxrtkiuaBZoucBi5loHtjR/IlCqVpVNpSYRx3zqwfNSztP/wZ+h9R F2UmWNARVm+ldXeAJ1aWhdnwUgyUZ3ISVkOyfWJhyLl7F7INZaSsNFrMV1+Fb9DwhL0B M3Qijxe5o3AEzQ3H2TmKWwbaP+BoNf8hC70WG8Qq9Zp7/Wf3obcn2a7tKyIPx9/xI/zO tZarxb5FU1FSVSZAe6E0Jw3mcvlXbZeQF2EmYTPNUxn01MmkQv8/uASXheBOlnzuvw4Y R+EA== X-Gm-Message-State: AFqh2kpU/66Alm1sGJaUGQx1EvzuJashoDs6QLcFsUjsqAcHqj4R5QdY 6xoZY1GYYUXgInDpvRMRIlziPN55eQfPm/1u X-Google-Smtp-Source: AMrXdXuYODPiQgWsNEyisCw6VhRWEzZEI8c5abzEX6U4l/O3cjPsGK7MvNB2/q/BRvvZ2+FmAB/bYw== X-Received: by 2002:a1c:2b04:0:b0:3d3:4f28:40c6 with SMTP id r4-20020a1c2b04000000b003d34f2840c6mr34647278wmr.1.1672908054693; Thu, 05 Jan 2023 00:40:54 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis , Doug Goldstein , Stefano Stabellini , Julien Grall , Anthony PERARD , Andrew Cooper , Gianluca Guida Subject: [PATCH v3 0/2] Add minimal RISC-V Xen build and build testing Date: Thu, 5 Jan 2023 10:40:49 +0200 Message-Id: X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The patch series introduces the following: - provide a minimal amount of changes to add initial RISC-V support to make Xen binary buildable and runnable for RISC-V architecture which can be used for future development and testing. - add RISC-V 64 cross-compile build jobs to check if any new changes break RISC-V build. Changes in V3: - Remove include of from head.S. Changes in V2: - Remove the patch "automation: add cross-compiler support for the build script" because it was reworked as a part of the patch series "CI: Fixes/cleanup in preparation for RISCV". - Remove the patch "automation: add python3 package for riscv64.dockerfile" because it is not necessary for RISCV Xen binary build now. - Rework the patch "arch/riscv: initial RISC-V support to build/run minimal Xen" according to the comments about v1 of the patch series. - Add HYPERVISOR_ONLY to RISCV jobs in build.yaml after rebasing on "CI: Fixes/cleanup in preparation for RISCV" patch series. Oleksii Kurochko (2): arch/riscv: initial RISC-V support to build/run minimal Xen automation: add RISC-V 64 cross-build tests for Xen automation/gitlab-ci/build.yaml | 45 ++++++++ xen/arch/riscv/Makefile | 16 +++ xen/arch/riscv/arch.mk | 4 + xen/arch/riscv/include/asm/config.h | 9 +- xen/arch/riscv/riscv64/Makefile | 2 +- xen/arch/riscv/riscv64/head.S | 4 +- xen/arch/riscv/xen.lds.S | 158 ++++++++++++++++++++++++++++ 7 files changed, 233 insertions(+), 5 deletions(-) create mode 100644 xen/arch/riscv/xen.lds.S -- 2.38.1 From xen-devel-bounces@lists.xenproject.org Thu Jan 05 08:41:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 08:41:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471707.731665 (Exim 4.92) (envelope-from ) id 1pDLo6-0003tV-OO; Thu, 05 Jan 2023 08:41:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471707.731665; Thu, 05 Jan 2023 08:41:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDLo6-0003tO-KB; Thu, 05 Jan 2023 08:41:02 +0000 Received: by outflank-mailman (input) for mailman id 471707; Thu, 05 Jan 2023 08:41:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDLo5-0003sb-AE for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 08:41:01 +0000 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [2a00:1450:4864:20::329]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ad524a14-8cd4-11ed-b8d0-410ff93cb8f0; Thu, 05 Jan 2023 09:40:58 +0100 (CET) Received: by mail-wm1-x329.google.com with SMTP id ay40so27507622wmb.2 for ; Thu, 05 Jan 2023 00:40:58 -0800 (PST) Received: from fedora.. ([195.234.76.149]) by smtp.gmail.com with ESMTPSA id n17-20020a05600c4f9100b003cffd3c3d6csm1752711wmq.12.2023.01.05.00.40.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Jan 2023 00:40:57 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ad524a14-8cd4-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1DmOMupuCoWDrIsiMMu25qOlzUBJXmbm34omuNR0qaQ=; b=jEnnMoJsw/QR9BZmza/gxrU1z8UTyZnyWNrDOF6UyqsyG1XBIuhmRGY0Oyv7LfIosV uLuoX0OopVqyrU3SqigHHfbG7lL/aJe2HGn7E4it4/Nx/c0Xodn2HvV1Hw07vb4Kh68L PBBB8lk7Z+vxoTzytBuQHm949+/UQ7p01PNSbmrHqxFtvGAlHA5+jVivdYbIOznrkjQf yfoQbdoCQumqKFqtrDDwQZFR4VieSopb/K2KYgQPQ3SF1M7uYlYNFNgZ4TwijlltygHX 7uI3pcUrexy0fUgRmSTfECGQLC5+29lxdMDXy9oLxU8mVnmeFz1yIwP8rBjRU/h6b5sR PhhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1DmOMupuCoWDrIsiMMu25qOlzUBJXmbm34omuNR0qaQ=; b=4203oaBj+M14aNP9WZOPI+5v9QNB3B5EdXKvfTK9kFoyLYlI7TNR5g26cHHx0OobGo 26fwkhiSaaMT9+pbJkBNJASy2J3NZ1QT54ZwzfriVK44SqKnnMddYkhDZo15ggckEx/8 qxI65rToY4T5i4AxS5wQ78oCJN6f2GcBq8iX2/pStnvT2o0afoQMgVclnIavIUaBOOy1 U2ueVz7IO2qzrIrwjkg0ikGy2/nCPR2tSmoU6tBXc0XkVh5BCOLkb2po1fRJEh8biZIz iExhEoShNDvecIao+98SqIvGjbiUdE62k6ElptX9TUqbQJtYbyTMCuQBIoBkImwneTg9 Ki5Q== X-Gm-Message-State: AFqh2kp9fk1Eu37dWoJDqIT2fUnfiUQ9o9rh+Zcr1X07raP4zJcNGAek BD/a848o24hlc1qvC9chfAPnJjdnXPNNhhmN X-Google-Smtp-Source: AMrXdXukQDeR5j0Ysjd9JHSWYImdEWJ6Dv4Vsx4eHct59HG9CM/lZXIMrVSQpGMpsYJZS4J1VlJ9zw== X-Received: by 2002:a05:600c:4b0f:b0:3d2:2651:64bd with SMTP id i15-20020a05600c4b0f00b003d2265164bdmr35671137wmp.10.1672908058181; Thu, 05 Jan 2023 00:40:58 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis , Julien Grall , Anthony PERARD , Andrew Cooper , Stefano Stabellini , Gianluca Guida Subject: [PATCH v3 1/2] arch/riscv: initial RISC-V support to build/run minimal Xen Date: Thu, 5 Jan 2023 10:40:50 +0200 Message-Id: <9f575b36965088936b5f7beed1b0d4bd96063d16.1672906559.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The patch provides a minimal amount of changes to start build and run minimal Xen binary at GitLab CI&CD that will allow continuous checking of the build status of RISC-V Xen. Except introduction of new files the following changes were done: * Redefinition of ALIGN define from '.algin 2' to '.align 4' as RISC-V implementations (except for with C extension) enforce 32-bit instruction address alignment. With C extension, 16-bit and 32-bit are both allowed. * ALL_OBJ-y and ALL_LIBS-y were temporary overwritted to produce a minimal hypervisor image otherwise it will be required to push huge amount of headers and stubs for common, drivers, libs etc which aren't necessary for now. * Section changed from .text to .text.header for start function to make it the first one executed. * Rework riscv64/Makefile logic to rebase over changes since the first RISC-V commit. RISC-V Xen can be built by the following instructions: $ CONTAINER=riscv64 ./automation/scripts/containerize \ make XEN_TARGET_ARCH=riscv64 tiny64_defconfig $ CONTAINER=riscv64 ./automation/scripts/containerize \ make XEN_TARGET_ARCH=riscv64 -C xen build RISC-V Xen can be run as: $ qemu-system-riscv64 -M virt -smp 1 -nographic -m 2g \ -kernel xen/xen To run in debug mode should be done the following instructions: $ qemu-system-riscv64 -M virt -smp 1 -nographic -m 2g \ -kernel xen/xen -s -S # In separate terminal: $ riscv64-buildroot-linux-gnu-gdb $ target remote :1234 $ add-symbol-file /xen/xen-syms 0x80200000 $ hb *0x80200000 $ c # it should stop at instruction j 0x80200000 Signed-off-by: Oleksii Kurochko --- Changes in V3: - Remove include of from head.S --- Changes in V2: - Update commit message: - Add explanation why ALIGN define was changed. - Add explanation why section of 'start' function was changed. - Rework xen.lds.S linker script. It is mostly based on ARM except ARM-specific sections which have been removed. - Rework in riscv64/Makefile rule $(TARGET)-syms - Remove asm/types.h header as after reworking of riscv64/Makefile it is not needed now. - Remove unneeded define SYMBOLS_DUMMY_OBJ. --- xen/arch/riscv/Makefile | 16 +++ xen/arch/riscv/arch.mk | 4 + xen/arch/riscv/include/asm/config.h | 9 +- xen/arch/riscv/riscv64/Makefile | 2 +- xen/arch/riscv/riscv64/head.S | 4 +- xen/arch/riscv/xen.lds.S | 158 ++++++++++++++++++++++++++++ 6 files changed, 188 insertions(+), 5 deletions(-) create mode 100644 xen/arch/riscv/xen.lds.S diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile index 942e4ffbc1..74386beb85 100644 --- a/xen/arch/riscv/Makefile +++ b/xen/arch/riscv/Makefile @@ -1,2 +1,18 @@ +obj-$(CONFIG_RISCV_64) += riscv64/ + +$(TARGET): $(TARGET)-syms + $(OBJCOPY) -O binary -S $< $@ + +$(TARGET)-syms: $(objtree)/prelink.o $(obj)/xen.lds + $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< $(build_id_linker) -o $@ + $(NM) -pa --format=sysv $(@D)/$(@F) \ + | $(objtree)/tools/symbols --all-symbols --xensyms --sysv --sort \ + >$(@D)/$(@F).map + +$(obj)/xen.lds: $(src)/xen.lds.S FORCE + $(call if_changed_dep,cpp_lds_S) + +clean-files := $(objtree)/.xen-syms.[0-9]* + .PHONY: include include: diff --git a/xen/arch/riscv/arch.mk b/xen/arch/riscv/arch.mk index ae8fe9dec7..012dc677c3 100644 --- a/xen/arch/riscv/arch.mk +++ b/xen/arch/riscv/arch.mk @@ -11,3 +11,7 @@ riscv-march-$(CONFIG_RISCV_ISA_C) := $(riscv-march-y)c # -mcmodel=medlow would force Xen into the lower half. CFLAGS += -march=$(riscv-march-y) -mstrict-align -mcmodel=medany + +# TODO: Drop override when more of the build is working +override ALL_OBJS-y = arch/$(TARGET_ARCH)/built_in.o +override ALL_LIBS-y = diff --git a/xen/arch/riscv/include/asm/config.h b/xen/arch/riscv/include/asm/config.h index e2ae21de61..e10e13ba53 100644 --- a/xen/arch/riscv/include/asm/config.h +++ b/xen/arch/riscv/include/asm/config.h @@ -1,6 +1,9 @@ #ifndef __RISCV_CONFIG_H__ #define __RISCV_CONFIG_H__ +#include +#include + #if defined(CONFIG_RISCV_64) # define LONG_BYTEORDER 3 # define ELFSIZE 64 @@ -28,7 +31,7 @@ /* Linkage for RISCV */ #ifdef __ASSEMBLY__ -#define ALIGN .align 2 +#define ALIGN .align 4 #define ENTRY(name) \ .globl name; \ @@ -36,6 +39,10 @@ name: #endif +#define XEN_VIRT_START _AT(UL,0x00200000) + +#define SMP_CACHE_BYTES (1 << 6) + #endif /* __RISCV_CONFIG_H__ */ /* * Local variables: diff --git a/xen/arch/riscv/riscv64/Makefile b/xen/arch/riscv/riscv64/Makefile index 15a4a65f66..3340058c08 100644 --- a/xen/arch/riscv/riscv64/Makefile +++ b/xen/arch/riscv/riscv64/Makefile @@ -1 +1 @@ -extra-y += head.o +obj-y += head.o diff --git a/xen/arch/riscv/riscv64/head.S b/xen/arch/riscv/riscv64/head.S index 0dbc27ba75..990edb70a0 100644 --- a/xen/arch/riscv/riscv64/head.S +++ b/xen/arch/riscv/riscv64/head.S @@ -1,6 +1,4 @@ -#include - - .text + .section .text.header, "ax", %progbits ENTRY(start) j start diff --git a/xen/arch/riscv/xen.lds.S b/xen/arch/riscv/xen.lds.S new file mode 100644 index 0000000000..ca57cce75c --- /dev/null +++ b/xen/arch/riscv/xen.lds.S @@ -0,0 +1,158 @@ +#include + +#undef ENTRY +#undef ALIGN + +OUTPUT_ARCH(riscv) +ENTRY(start) + +PHDRS +{ + text PT_LOAD ; +#if defined(BUILD_ID) + note PT_NOTE ; +#endif +} + +SECTIONS +{ + . = XEN_VIRT_START; + _start = .; + .text : { + _stext = .; /* Text section */ + *(.text.header) + + *(.text.cold) + *(.text.unlikely .text.*_unlikely .text.unlikely.*) + + *(.text) +#ifdef CONFIG_CC_SPLIT_SECTIONS + *(.text.*) +#endif + + *(.fixup) + *(.gnu.warning) + . = ALIGN(POINTER_ALIGN); + _etext = .; /* End of text section */ + } :text + + . = ALIGN(PAGE_SIZE); + .rodata : { + _srodata = .; /* Read-only data */ + *(.rodata) + *(.rodata.*) + *(.data.rel.ro) + *(.data.rel.ro.*) + + VPCI_ARRAY + + . = ALIGN(POINTER_ALIGN); + _erodata = .; /* End of read-only data */ + } :text + + #if defined(BUILD_ID) + . = ALIGN(4); + .note.gnu.build-id : { + __note_gnu_build_id_start = .; + *(.note.gnu.build-id) + __note_gnu_build_id_end = .; + } :note :text + #endif + _erodata = .; /* End of read-only data */ + + . = ALIGN(PAGE_SIZE); + .data.ro_after_init : { + __ro_after_init_start = .; + *(.data.ro_after_init) + . = ALIGN(PAGE_SIZE); + __ro_after_init_end = .; + } : text + + .data.read_mostly : { + *(.data.read_mostly) + } :text + + . = ALIGN(PAGE_SIZE); + .data : { /* Data */ + *(.data.page_aligned) + . = ALIGN(8); + __start_schedulers_array = .; + *(.data.schedulers) + __end_schedulers_array = .; + + HYPFS_PARAM + + *(.data .data.*) + CONSTRUCTORS + } :text + + . = ALIGN(PAGE_SIZE); /* Init code and data */ + __init_begin = .; + .init.text : { + _sinittext = .; + *(.init.text) + _einittext = .; + . = ALIGN(PAGE_SIZE); /* Avoid mapping alt insns executable */ + } :text + . = ALIGN(PAGE_SIZE); + .init.data : { + *(.init.rodata) + *(.init.rodata.*) + + . = ALIGN(POINTER_ALIGN); + __setup_start = .; + *(.init.setup) + __setup_end = .; + + __initcall_start = .; + *(.initcallpresmp.init) + __presmp_initcall_end = .; + *(.initcall1.init) + __initcall_end = .; + + LOCK_PROFILE_DATA + + *(.init.data) + *(.init.data.rel) + *(.init.data.rel.*) + + . = ALIGN(8); + __ctors_start = .; + *(.ctors) + *(.init_array) + *(SORT(.init_array.*)) + __ctors_end = .; + } :text + . = ALIGN(POINTER_ALIGN); + __init_end = .; + + .bss : { /* BSS */ + __bss_start = .; + *(.bss.stack_aligned) + . = ALIGN(PAGE_SIZE); + *(.bss.page_aligned) + . = ALIGN(PAGE_SIZE); + __per_cpu_start = .; + *(.bss.percpu.page_aligned) + *(.bss.percpu) + . = ALIGN(SMP_CACHE_BYTES); + *(.bss.percpu.read_mostly) + . = ALIGN(SMP_CACHE_BYTES); + __per_cpu_data_end = .; + *(.bss .bss.*) + . = ALIGN(POINTER_ALIGN); + __bss_end = .; + } :text + _end = . ; + + /* Section for the device tree blob (if any). */ + .dtb : { *(.dtb) } :text + + DWARF2_DEBUG_SECTIONS + + DISCARD_SECTIONS + + STABS_DEBUG_SECTIONS + + ELF_DETAILS_SECTIONS +} -- 2.38.1 From xen-devel-bounces@lists.xenproject.org Thu Jan 05 08:41:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 08:41:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471708.731675 (Exim 4.92) (envelope-from ) id 1pDLoA-0004CS-4B; Thu, 05 Jan 2023 08:41:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471708.731675; Thu, 05 Jan 2023 08:41:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDLoA-0004CL-0Q; Thu, 05 Jan 2023 08:41:06 +0000 Received: by outflank-mailman (input) for mailman id 471708; Thu, 05 Jan 2023 08:41:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDLo8-0003sb-G8 for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 08:41:04 +0000 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [2a00:1450:4864:20::32d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id af938764-8cd4-11ed-b8d0-410ff93cb8f0; Thu, 05 Jan 2023 09:41:02 +0100 (CET) Received: by mail-wm1-x32d.google.com with SMTP id ay2-20020a05600c1e0200b003d22e3e796dso781108wmb.0 for ; Thu, 05 Jan 2023 00:41:02 -0800 (PST) Received: from fedora.. ([195.234.76.149]) by smtp.gmail.com with ESMTPSA id n17-20020a05600c4f9100b003cffd3c3d6csm1752711wmq.12.2023.01.05.00.41.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Jan 2023 00:41:01 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: af938764-8cd4-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aehIhiOSPO0UY1yboaOg5tDnKtSx7l5gzqO3ILXdJfA=; b=XyBn4t9PzsoVBWZ5HogTlhYr0qTNW/9gO9b4BLE4oYOPFemstOkmpmmEJXvftygwGM QBCPN4YC7GvxpentTkz1VTfxFLW8YcixdBVvCMXKYspCyzT6DsD9S1T38kEyhMShVXwe OFeY4WIN+/G3ubdPacUBSonky/oZzbZVTMgG7s7sGWUlUS1L3c9ON3bH1OUlR0UtskE4 Jl8wGcyifXpg2af7OIY+r3Skj9nSW1SqpbMdWu755Ilpsb6sGpAvmmlWiHhbxlC13T+U GfKP5NhZIjolgGyb/lXgo64wQnrpXqzI9YrudkZvDB75gY1nP0xZaMtraRzTYy7UXaLJ 5Qag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aehIhiOSPO0UY1yboaOg5tDnKtSx7l5gzqO3ILXdJfA=; b=zCfyEj4iVyNv3DAnXEf55KFxnSWc4mFLNnjEG/TOHT/aeoRXHZkgEmE8CkedgILuC1 Jc1MYT9FQDJGDTiW5dGsqzpaQHqOr+BW78GfnyOwQc71iWMC8kqF2Yq//ia1oVnIw7O0 bygWRNlj7wqad7R5NTIRfrZ0pGoVMA5+EtHeuU8JNJbjpjfuMy6rYAhYoKgbWiQCUVXb ddczT9SRRYpa59JnVP/nGjuU2SquqMQQSOHMOWtAYS9cQN3v9YEyl1qk2md1UVjjFzhe RNiYR0zmtH3V87muIsXc5BG3/YfaM1LhCaMHvvPaJfVGp3FXGP/5/VXuKpAEB27HxpVo NCTA== X-Gm-Message-State: AFqh2kp2xGiFa4EVbRmbuJrRXzUwFy4ZFArtp0pWf/gFR7AdkkHAPRVf oZjrm7trJG/Sl+44GRXEMJWLHt9pw3cgIgnl X-Google-Smtp-Source: AMrXdXsjNND4+vpRTOlet0CB22rhp0yoxL/EPO4XuLf3u5HKhxkQhI4j9IALsg7DG6x7TD2Vl9XO5A== X-Received: by 2002:a05:600c:1e10:b0:3d1:f496:e25f with SMTP id ay16-20020a05600c1e1000b003d1f496e25fmr38734543wmb.16.1672908061997; Thu, 05 Jan 2023 00:41:01 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Oleksii Kurochko , Doug Goldstein , Stefano Stabellini , Andrew Cooper , Gianluca Guida , Alistair Francis Subject: [PATCH v3 2/2] automation: add RISC-V 64 cross-build tests for Xen Date: Thu, 5 Jan 2023 10:40:51 +0200 Message-Id: X-Mailer: git-send-email 2.38.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add build jobs to cross-compile Xen-only for RISC-V 64. Signed-off-by: Oleksii Kurochko Acked-by: Alistair Francis --- Changes in V2: - Add HYPERVISOR_ONLY to RISCV jobs because after rebase on top of the patch series "CI: Fixes/cleanup in preparation for RISCV" it is required to set HYPERVISOR_ONLY in build.yaml --- automation/gitlab-ci/build.yaml | 45 +++++++++++++++++++++++++++++++++ 1 file changed, 45 insertions(+) diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml index e6a9357de3..11eb1c6b82 100644 --- a/automation/gitlab-ci/build.yaml +++ b/automation/gitlab-ci/build.yaml @@ -172,6 +172,33 @@ variables: <<: *gcc +.riscv64-cross-build-tmpl: + <<: *build + variables: + XEN_TARGET_ARCH: riscv64 + tags: + - x86_64 + +.riscv64-cross-build: + extends: .riscv64-cross-build-tmpl + variables: + debug: n + +.riscv64-cross-build-debug: + extends: .riscv64-cross-build-tmpl + variables: + debug: y + +.gcc-riscv64-cross-build: + extends: .riscv64-cross-build + variables: + <<: *gcc + +.gcc-riscv64-cross-build-debug: + extends: .riscv64-cross-build-debug + variables: + <<: *gcc + # Jobs below this line archlinux-gcc: @@ -617,6 +644,21 @@ alpine-3.12-gcc-debug-arm64-boot-cpupools: EXTRA_XEN_CONFIG: | CONFIG_BOOT_TIME_CPUPOOLS=y +# RISC-V 64 cross-build +riscv64-cross-gcc: + extends: .gcc-riscv64-cross-build + variables: + CONTAINER: archlinux:riscv64 + KBUILD_DEFCONFIG: tiny64_defconfig + HYPERVISOR_ONLY: y + +riscv64-cross-gcc-debug: + extends: .gcc-riscv64-cross-build-debug + variables: + CONTAINER: archlinux:riscv64 + KBUILD_DEFCONFIG: tiny64_defconfig + HYPERVISOR_ONLY: y + ## Test artifacts common .test-jobs-artifact-common: @@ -692,3 +734,6 @@ kernel-5.10.74-export: - binaries/bzImage tags: - x86_64 + +# # RISC-V 64 test artificats +# # TODO: add RISC-V 64 test artitifacts -- 2.38.1 From xen-devel-bounces@lists.xenproject.org Thu Jan 05 09:02:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 09:02:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471740.731711 (Exim 4.92) (envelope-from ) id 1pDM8Q-0007Z5-1u; Thu, 05 Jan 2023 09:02:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471740.731711; Thu, 05 Jan 2023 09:02:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDM8P-0007Yy-Uu; Thu, 05 Jan 2023 09:02:01 +0000 Received: by outflank-mailman (input) for mailman id 471740; Thu, 05 Jan 2023 09:02:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDM8O-0007Ys-MA for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 09:02:00 +0000 Received: from out30-8.freemail.mail.aliyun.com (out30-8.freemail.mail.aliyun.com [115.124.30.8]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 99c8f410-8cd7-11ed-b8d0-410ff93cb8f0; Thu, 05 Jan 2023 10:01:56 +0100 (CET) Received: from localhost(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0VYvE98r_1672909303) by smtp.aliyun-inc.com; Thu, 05 Jan 2023 17:01:51 +0800 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 99c8f410-8cd7-11ed-b8d0-410ff93cb8f0 X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R231e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046050;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=12;SR=0;TI=SMTPD_---0VYvE98r_1672909303; From: Jiapeng Chong To: jgross@suse.com Cc: boris.ostrovsky@oracle.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, Jiapeng Chong , Abaci Robot Subject: [PATCH v2] x86/xen: Remove the unused function p2m_index() Date: Thu, 5 Jan 2023 17:01:41 +0800 Message-Id: <20230105090141.36248-1-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The function p2m_index is defined in the p2m.c file, but not called elsewhere, so remove this unused function. arch/x86/xen/p2m.c:137:24: warning: unused function 'p2m_index'. Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3557 Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- Changes in v2: -Modify title and submission. arch/x86/xen/p2m.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/arch/x86/xen/p2m.c b/arch/x86/xen/p2m.c index 58db86f7b384..9bdc3b656b2c 100644 --- a/arch/x86/xen/p2m.c +++ b/arch/x86/xen/p2m.c @@ -134,11 +134,6 @@ static inline unsigned p2m_mid_index(unsigned long pfn) return (pfn / P2M_PER_PAGE) % P2M_MID_PER_PAGE; } -static inline unsigned p2m_index(unsigned long pfn) -{ - return pfn % P2M_PER_PAGE; -} - static void p2m_top_mfn_init(unsigned long *top) { unsigned i; -- 2.20.1.7.g153144c From xen-devel-bounces@lists.xenproject.org Thu Jan 05 09:16:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 09:16:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471748.731722 (Exim 4.92) (envelope-from ) id 1pDMLt-0000fe-7K; Thu, 05 Jan 2023 09:15:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471748.731722; Thu, 05 Jan 2023 09:15:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDMLt-0000fX-4W; Thu, 05 Jan 2023 09:15:57 +0000 Received: by outflank-mailman (input) for mailman id 471748; Thu, 05 Jan 2023 09:15:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDMLr-0000fR-GJ for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 09:15:55 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8cb48600-8cd9-11ed-b8d0-410ff93cb8f0; Thu, 05 Jan 2023 10:15:52 +0100 (CET) Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-528-JEsIRH6WNHSAI5I6i2C_2w-1; Thu, 05 Jan 2023 04:15:48 -0500 Received: by mail-wm1-f70.google.com with SMTP id bd6-20020a05600c1f0600b003d96f7f2396so733188wmb.3 for ; Thu, 05 Jan 2023 01:15:47 -0800 (PST) Received: from redhat.com ([2.52.151.85]) by smtp.gmail.com with ESMTPSA id ba13-20020a0560001c0d00b002a91572638csm2863835wrb.75.2023.01.05.01.15.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Jan 2023 01:15:45 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8cb48600-8cd9-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672910151; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WvJnFbsqNB85Ex5Jy9JWOBFwO+5P6BtsVC31mbY8Jko=; b=HGzcLJ606AZB/ucSA1nWJFKnp1HlzdqXu6SEDIXKCDKhXiTVK0xrq4KlRntjXb0/Bzwxfu FQ505qUj3nQ26ZKspbJwUtwJZH8zigoamnsR1gACilibxPWEOfvg1LAEoJPHpasYgXfVrE PX3cNW1H/Oij72e50RlgcFkegM5w45s= X-MC-Unique: JEsIRH6WNHSAI5I6i2C_2w-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WvJnFbsqNB85Ex5Jy9JWOBFwO+5P6BtsVC31mbY8Jko=; b=qtM4et2NBL9rHncv9LHOc0I/G0cF0qsv9qH+yJNv3r0VV4Mpvnxd0Knn7OtT1wFYUf 2gpAarIXD6DNr4UtrTKC+s36eEpaHLA7tCddPEsayz86B/2eOQSMMq69xRzmmuf99KSB 7Xh1Fu/Im5QmIR0mzdwraxNNZMkYpbqzYH9aYR+y069NnyPxuQMcHlkaqUDidU5r5lwU FnO5SltrYVGOuLt0azgi5KSpWusSH6aq/jD7Ul4VRJ9V0beJHymBBQhLrkS6ybIgF42Z Q7ZChzJ0tPQalCEp5oyJbmx9boUPpfOesaBtmCQf0ztSlOqGsTyKydOveO/Wu6jEazlS V2GA== X-Gm-Message-State: AFqh2kquoTlnpfIvXgMNGM0SPY/BowL0Vxb8Ba2d4rxkw+4pvMgSnC8y 0BqGiBcHA2SXApVHsjdB6SsU8B2HAOo9rRfdO+PerbBWqBJLMnXDKSmpf4KtDLattSSYt5JXBjz 1GHKtscOtaCC7aDqnW/UIJ5MwwiA= X-Received: by 2002:a5d:63cb:0:b0:293:b54e:4f09 with SMTP id c11-20020a5d63cb000000b00293b54e4f09mr10584293wrw.4.1672910146658; Thu, 05 Jan 2023 01:15:46 -0800 (PST) X-Google-Smtp-Source: AMrXdXtL7rkgthxuayEoRod50MDK5WIP+ZyW54cKv1y5T8C/qx/fxyUAvKbsu59WxqwvfyS7nCS0Gg== X-Received: by 2002:a5d:63cb:0:b0:293:b54e:4f09 with SMTP id c11-20020a5d63cb000000b00293b54e4f09mr10584279wrw.4.1672910146407; Thu, 05 Jan 2023 01:15:46 -0800 (PST) Date: Thu, 5 Jan 2023 04:15:41 -0500 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Cc: Peter Maydell , Markus Armbruster , Richard Henderson , Igor Mammedov , Ani Sinha , Paolo Bonzini , Eduardo Habkost , Marcel Apfelbaum , Yuval Shaia , Fam Zheng , Gerd Hoffmann , Stefano Stabellini , Anthony Perard , Paul Durrant , Ben Widawsky , Jonathan Cameron , Huacai Chen , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Jiaxun Yang , Andrey Smirnov , Xiaojuan Yang , Song Gao , =?utf-8?Q?C=C3=A9dric?= Le Goater , Paul Burton , Aleksandar Rikalo , xen-devel@lists.xenproject.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org Subject: [PULL 27/51] include/hw/pci: Break inclusion loop pci_bridge.h and cxl.h Message-ID: <20230105091310.263867-28-mst@redhat.com> References: <20230105091310.263867-1-mst@redhat.com> MIME-Version: 1.0 In-Reply-To: <20230105091310.263867-1-mst@redhat.com> X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline From: Markus Armbruster hw/pci/pci_bridge.h and hw/cxl/cxl.h include each other. Fortunately, breaking the loop is merely a matter of deleting unnecessary includes from headers, and adding them back in places where they are now missing. Signed-off-by: Markus Armbruster Message-Id: <20221222100330.380143-2-armbru@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/alpha/alpha_sys.h | 1 - hw/rdma/rdma_utils.h | 1 - hw/rdma/vmw/pvrdma.h | 1 - hw/usb/hcd-ehci.h | 1 - hw/xen/xen_pt.h | 1 - include/hw/cxl/cxl.h | 1 - include/hw/cxl/cxl_cdat.h | 1 + include/hw/cxl/cxl_device.h | 1 + include/hw/cxl/cxl_pci.h | 2 -- include/hw/i386/ich9.h | 4 ---- include/hw/i386/x86-iommu.h | 1 - include/hw/isa/vt82c686.h | 1 - include/hw/pci-host/designware.h | 3 --- include/hw/pci-host/i440fx.h | 2 +- include/hw/pci-host/ls7a.h | 2 -- include/hw/pci-host/pnv_phb3.h | 2 -- include/hw/pci-host/pnv_phb4.h | 3 +-- include/hw/pci-host/xilinx-pcie.h | 1 - include/hw/pci/pcie.h | 1 - include/hw/virtio/virtio-scsi.h | 1 - hw/alpha/pci.c | 1 + hw/alpha/typhoon.c | 2 +- hw/i386/acpi-build.c | 2 +- hw/pci-bridge/i82801b11.c | 2 +- hw/rdma/rdma_utils.c | 1 + hw/scsi/virtio-scsi.c | 1 + 26 files changed, 10 insertions(+), 30 deletions(-) diff --git a/hw/alpha/alpha_sys.h b/hw/alpha/alpha_sys.h index 2263e821da..a303c58438 100644 --- a/hw/alpha/alpha_sys.h +++ b/hw/alpha/alpha_sys.h @@ -5,7 +5,6 @@ #include "target/alpha/cpu-qom.h" #include "hw/pci/pci.h" -#include "hw/pci/pci_host.h" #include "hw/boards.h" #include "hw/intc/i8259.h" diff --git a/hw/rdma/rdma_utils.h b/hw/rdma/rdma_utils.h index 0c6414e7e0..54e4f56edd 100644 --- a/hw/rdma/rdma_utils.h +++ b/hw/rdma/rdma_utils.h @@ -18,7 +18,6 @@ #define RDMA_UTILS_H #include "qemu/error-report.h" -#include "hw/pci/pci.h" #include "sysemu/dma.h" #define rdma_error_report(fmt, ...) \ diff --git a/hw/rdma/vmw/pvrdma.h b/hw/rdma/vmw/pvrdma.h index d08965d3e2..0caf95ede8 100644 --- a/hw/rdma/vmw/pvrdma.h +++ b/hw/rdma/vmw/pvrdma.h @@ -18,7 +18,6 @@ #include "qemu/units.h" #include "qemu/notify.h" -#include "hw/pci/pci.h" #include "hw/pci/msix.h" #include "chardev/char-fe.h" #include "hw/net/vmxnet3_defs.h" diff --git a/hw/usb/hcd-ehci.h b/hw/usb/hcd-ehci.h index a173707d9b..4d4b2830b7 100644 --- a/hw/usb/hcd-ehci.h +++ b/hw/usb/hcd-ehci.h @@ -23,7 +23,6 @@ #include "sysemu/dma.h" #include "hw/pci/pci.h" #include "hw/sysbus.h" -#include "qom/object.h" #ifndef EHCI_DEBUG #define EHCI_DEBUG 0 diff --git a/hw/xen/xen_pt.h b/hw/xen/xen_pt.h index e7c4316a7d..cf10fc7bbf 100644 --- a/hw/xen/xen_pt.h +++ b/hw/xen/xen_pt.h @@ -2,7 +2,6 @@ #define XEN_PT_H #include "hw/xen/xen_common.h" -#include "hw/pci/pci.h" #include "xen-host-pci-device.h" #include "qom/object.h" diff --git a/include/hw/cxl/cxl.h b/include/hw/cxl/cxl.h index 38e0e271d5..5129557bee 100644 --- a/include/hw/cxl/cxl.h +++ b/include/hw/cxl/cxl.h @@ -13,7 +13,6 @@ #include "qapi/qapi-types-machine.h" #include "qapi/qapi-visit-machine.h" -#include "hw/pci/pci_bridge.h" #include "hw/pci/pci_host.h" #include "cxl_pci.h" #include "cxl_component.h" diff --git a/include/hw/cxl/cxl_cdat.h b/include/hw/cxl/cxl_cdat.h index e9eda00142..7f67638685 100644 --- a/include/hw/cxl/cxl_cdat.h +++ b/include/hw/cxl/cxl_cdat.h @@ -11,6 +11,7 @@ #define CXL_CDAT_H #include "hw/cxl/cxl_pci.h" +#include "hw/pci/pcie_doe.h" /* * Reference: diff --git a/include/hw/cxl/cxl_device.h b/include/hw/cxl/cxl_device.h index 449b0edfe9..fd475b947b 100644 --- a/include/hw/cxl/cxl_device.h +++ b/include/hw/cxl/cxl_device.h @@ -10,6 +10,7 @@ #ifndef CXL_DEVICE_H #define CXL_DEVICE_H +#include "hw/pci/pci.h" #include "hw/register.h" /* diff --git a/include/hw/cxl/cxl_pci.h b/include/hw/cxl/cxl_pci.h index 3cb79eca1e..aca14845ab 100644 --- a/include/hw/cxl/cxl_pci.h +++ b/include/hw/cxl/cxl_pci.h @@ -11,8 +11,6 @@ #define CXL_PCI_H #include "qemu/compiler.h" -#include "hw/pci/pci.h" -#include "hw/pci/pcie.h" #include "hw/cxl/cxl_cdat.h" #define CXL_VENDOR_ID 0x1e98 diff --git a/include/hw/i386/ich9.h b/include/hw/i386/ich9.h index 23ee8e371b..222781e8b9 100644 --- a/include/hw/i386/ich9.h +++ b/include/hw/i386/ich9.h @@ -5,12 +5,8 @@ #include "hw/sysbus.h" #include "hw/i386/pc.h" #include "hw/isa/apm.h" -#include "hw/pci/pci.h" -#include "hw/pci/pcie_host.h" -#include "hw/pci/pci_bridge.h" #include "hw/acpi/acpi.h" #include "hw/acpi/ich9.h" -#include "hw/pci/pci_bus.h" #include "qom/object.h" void ich9_lpc_set_irq(void *opaque, int irq_num, int level); diff --git a/include/hw/i386/x86-iommu.h b/include/hw/i386/x86-iommu.h index 7637edb430..8d8d53b18b 100644 --- a/include/hw/i386/x86-iommu.h +++ b/include/hw/i386/x86-iommu.h @@ -21,7 +21,6 @@ #define HW_I386_X86_IOMMU_H #include "hw/sysbus.h" -#include "hw/pci/pci.h" #include "hw/pci/msi.h" #include "qom/object.h" diff --git a/include/hw/isa/vt82c686.h b/include/hw/isa/vt82c686.h index eaa07881c5..e273cd38dc 100644 --- a/include/hw/isa/vt82c686.h +++ b/include/hw/isa/vt82c686.h @@ -1,7 +1,6 @@ #ifndef HW_VT82C686_H #define HW_VT82C686_H -#include "hw/pci/pci.h" #define TYPE_VT82C686B_ISA "vt82c686b-isa" #define TYPE_VT82C686B_USB_UHCI "vt82c686b-usb-uhci" diff --git a/include/hw/pci-host/designware.h b/include/hw/pci-host/designware.h index 6d9b51ae67..908f3d946b 100644 --- a/include/hw/pci-host/designware.h +++ b/include/hw/pci-host/designware.h @@ -22,9 +22,6 @@ #define DESIGNWARE_H #include "hw/sysbus.h" -#include "hw/pci/pci.h" -#include "hw/pci/pci_bus.h" -#include "hw/pci/pcie_host.h" #include "hw/pci/pci_bridge.h" #include "qom/object.h" diff --git a/include/hw/pci-host/i440fx.h b/include/hw/pci-host/i440fx.h index d02bf1ed6b..fc93e22732 100644 --- a/include/hw/pci-host/i440fx.h +++ b/include/hw/pci-host/i440fx.h @@ -11,7 +11,7 @@ #ifndef HW_PCI_I440FX_H #define HW_PCI_I440FX_H -#include "hw/pci/pci_bus.h" +#include "hw/pci/pci.h" #include "hw/pci-host/pam.h" #include "qom/object.h" diff --git a/include/hw/pci-host/ls7a.h b/include/hw/pci-host/ls7a.h index df7fa55a30..b27db8e2ca 100644 --- a/include/hw/pci-host/ls7a.h +++ b/include/hw/pci-host/ls7a.h @@ -8,8 +8,6 @@ #ifndef HW_LS7A_H #define HW_LS7A_H -#include "hw/pci/pci.h" -#include "hw/pci/pcie_host.h" #include "hw/pci-host/pam.h" #include "qemu/units.h" #include "qemu/range.h" diff --git a/include/hw/pci-host/pnv_phb3.h b/include/hw/pci-host/pnv_phb3.h index 4854f6d2f6..f791ebda9b 100644 --- a/include/hw/pci-host/pnv_phb3.h +++ b/include/hw/pci-host/pnv_phb3.h @@ -10,8 +10,6 @@ #ifndef PCI_HOST_PNV_PHB3_H #define PCI_HOST_PNV_PHB3_H -#include "hw/pci/pcie_host.h" -#include "hw/pci/pcie_port.h" #include "hw/ppc/xics.h" #include "qom/object.h" #include "hw/pci-host/pnv_phb.h" diff --git a/include/hw/pci-host/pnv_phb4.h b/include/hw/pci-host/pnv_phb4.h index 50d4faa001..d9cea3f952 100644 --- a/include/hw/pci-host/pnv_phb4.h +++ b/include/hw/pci-host/pnv_phb4.h @@ -10,8 +10,7 @@ #ifndef PCI_HOST_PNV_PHB4_H #define PCI_HOST_PNV_PHB4_H -#include "hw/pci/pcie_host.h" -#include "hw/pci/pcie_port.h" +#include "hw/pci/pci_bus.h" #include "hw/ppc/xive.h" #include "qom/object.h" diff --git a/include/hw/pci-host/xilinx-pcie.h b/include/hw/pci-host/xilinx-pcie.h index 89be88d87f..e1b3c1c280 100644 --- a/include/hw/pci-host/xilinx-pcie.h +++ b/include/hw/pci-host/xilinx-pcie.h @@ -21,7 +21,6 @@ #define HW_XILINX_PCIE_H #include "hw/sysbus.h" -#include "hw/pci/pci.h" #include "hw/pci/pci_bridge.h" #include "hw/pci/pcie_host.h" #include "qom/object.h" diff --git a/include/hw/pci/pcie.h b/include/hw/pci/pcie.h index 698d3de851..798a262a0a 100644 --- a/include/hw/pci/pcie.h +++ b/include/hw/pci/pcie.h @@ -26,7 +26,6 @@ #include "hw/pci/pcie_aer.h" #include "hw/pci/pcie_sriov.h" #include "hw/hotplug.h" -#include "hw/pci/pcie_doe.h" typedef enum { /* for attention and power indicator */ diff --git a/include/hw/virtio/virtio-scsi.h b/include/hw/virtio/virtio-scsi.h index a36aad9c86..37b75e15e3 100644 --- a/include/hw/virtio/virtio-scsi.h +++ b/include/hw/virtio/virtio-scsi.h @@ -20,7 +20,6 @@ #define VIRTIO_SCSI_SENSE_SIZE 0 #include "standard-headers/linux/virtio_scsi.h" #include "hw/virtio/virtio.h" -#include "hw/pci/pci.h" #include "hw/scsi/scsi.h" #include "chardev/char-fe.h" #include "sysemu/iothread.h" diff --git a/hw/alpha/pci.c b/hw/alpha/pci.c index 72251fcdf0..7c18297177 100644 --- a/hw/alpha/pci.c +++ b/hw/alpha/pci.c @@ -7,6 +7,7 @@ */ #include "qemu/osdep.h" +#include "hw/pci/pci_host.h" #include "alpha_sys.h" #include "qemu/log.h" #include "trace.h" diff --git a/hw/alpha/typhoon.c b/hw/alpha/typhoon.c index bd39c8ca86..49a80550c5 100644 --- a/hw/alpha/typhoon.c +++ b/hw/alpha/typhoon.c @@ -10,10 +10,10 @@ #include "qemu/module.h" #include "qemu/units.h" #include "qapi/error.h" +#include "hw/pci/pci_host.h" #include "cpu.h" #include "hw/irq.h" #include "alpha_sys.h" -#include "qom/object.h" #define TYPE_TYPHOON_PCI_HOST_BRIDGE "typhoon-pcihost" diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index aa15b11cde..127c4e2d50 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -27,7 +27,7 @@ #include "acpi-common.h" #include "qemu/bitmap.h" #include "qemu/error-report.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_bridge.h" #include "hw/cxl/cxl.h" #include "hw/core/cpu.h" #include "target/i386/cpu.h" diff --git a/hw/pci-bridge/i82801b11.c b/hw/pci-bridge/i82801b11.c index d9f224818b..f3b4a14611 100644 --- a/hw/pci-bridge/i82801b11.c +++ b/hw/pci-bridge/i82801b11.c @@ -42,7 +42,7 @@ */ #include "qemu/osdep.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_bridge.h" #include "migration/vmstate.h" #include "qemu/module.h" #include "hw/i386/ich9.h" diff --git a/hw/rdma/rdma_utils.c b/hw/rdma/rdma_utils.c index 5a7ef63ad2..77008552f4 100644 --- a/hw/rdma/rdma_utils.c +++ b/hw/rdma/rdma_utils.c @@ -14,6 +14,7 @@ */ #include "qemu/osdep.h" +#include "hw/pci/pci.h" #include "trace.h" #include "rdma_utils.h" diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c index 6f6e2e32ba..2b649ca976 100644 --- a/hw/scsi/virtio-scsi.c +++ b/hw/scsi/virtio-scsi.c @@ -22,6 +22,7 @@ #include "qemu/iov.h" #include "qemu/module.h" #include "sysemu/block-backend.h" +#include "sysemu/dma.h" #include "hw/qdev-properties.h" #include "hw/scsi/scsi.h" #include "scsi/constants.h" -- MST From xen-devel-bounces@lists.xenproject.org Thu Jan 05 09:16:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 09:16:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471749.731733 (Exim 4.92) (envelope-from ) id 1pDMMC-00011z-FI; Thu, 05 Jan 2023 09:16:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471749.731733; Thu, 05 Jan 2023 09:16:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDMMC-00011s-CH; Thu, 05 Jan 2023 09:16:16 +0000 Received: by outflank-mailman (input) for mailman id 471749; Thu, 05 Jan 2023 09:16:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDMMA-0000fR-OH for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 09:16:15 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 977c9566-8cd9-11ed-b8d0-410ff93cb8f0; Thu, 05 Jan 2023 10:16:10 +0100 (CET) Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-190-4sSTT-oqNt-XxeRmToRbUw-1; Thu, 05 Jan 2023 04:16:07 -0500 Received: by mail-wm1-f70.google.com with SMTP id c23-20020a7bc857000000b003d97c8d4935so15190818wml.8 for ; Thu, 05 Jan 2023 01:16:07 -0800 (PST) Received: from redhat.com ([2.52.151.85]) by smtp.gmail.com with ESMTPSA id g41-20020a05600c4ca900b003cfd0bd8c0asm1541324wmp.30.2023.01.05.01.15.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Jan 2023 01:16:04 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 977c9566-8cd9-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672910169; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9E0uGbaHWSARDpwjIvxsxquPxCSk2QGI6Ma+Y/5MGDY=; b=OwnTmi68GSJuI4G7MsG6R8JuxBfwFMowpHaa+4inKJc3c05jbHtQw0UscNKWxSAVnCRS+0 V+f1Srh9j0MvRE3gwVwlio4QGGTlst9ClHncIKhHutI1mmaAJXwyCK9pie5mvcwoRI9+PB AjtLQxp6goMwXOfVOzVxhFDCJeZdxrI= X-MC-Unique: 4sSTT-oqNt-XxeRmToRbUw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9E0uGbaHWSARDpwjIvxsxquPxCSk2QGI6Ma+Y/5MGDY=; b=7/nMtyW0wSGa2lhuXYUFgcmf1RWAaynhcA2V1IQfnfIR/2JGAMEdwQU6erXavZPyyy hCj1NQ0dFv5acKz7VNK2JFuEvYLsjYNreFOW4q92Y5gXbTXWGyjnnypEX5YXwotDjZjM Jj03V6u25GGJTPAOu5lEZNELrGavpEJbkUXxjQtzTzJbCB0aYy/VLAVLsI9CBCrvaXUC rTJJ219yjOAm4h5+ZxlV3XNe5rEfLda1xasYFebBMn1VHUYu1IeyeqEYCGuWct01t7pM 52h92gbunLR5NyLLxSl0FnNFsXjwYaI4zjhjtQBlakJ3/BENWdCPTyr5WoZNWTNwY3VX z5WQ== X-Gm-Message-State: AFqh2krhZusXrtSlmZAq5vcySSGhDJTvP17Rssd/GV69TN68X+pAFq9B VsJ/9GP6Twd0+K9CWl6tJ6Rb7QfDRbrDUFEbjSvul+r3fWMD02bsHy04QxkmAxXcvqO0KCv40/O QXe0NhHMhKy8HbbdTc6da3Nr+X0g= X-Received: by 2002:a05:600c:44d4:b0:3cf:7925:7a3 with SMTP id f20-20020a05600c44d400b003cf792507a3mr35414326wmo.24.1672910165830; Thu, 05 Jan 2023 01:16:05 -0800 (PST) X-Google-Smtp-Source: AMrXdXtomsIn8w+yG1vNX43EiWLehS044MzumjQUALNU2pfPKqSwYO6JSwdk86MB9u4hPAZrggu7uA== X-Received: by 2002:a05:600c:44d4:b0:3cf:7925:7a3 with SMTP id f20-20020a05600c44d400b003cf792507a3mr35414200wmo.24.1672910164789; Thu, 05 Jan 2023 01:16:04 -0800 (PST) Date: Thu, 5 Jan 2023 04:15:55 -0500 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Cc: Peter Maydell , Markus Armbruster , Igor Mammedov , Ani Sinha , Gerd Hoffmann , Paolo Bonzini , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= , Eduardo Habkost , BALATON Zoltan , Stefano Stabellini , Anthony Perard , Paul Durrant , Richard Henderson , Marcel Apfelbaum , John Snow , Alberto Garcia , Corey Minyard , =?utf-8?B?SGVydsOp?= Poussineau , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Aurelien Jarno , Pavel Pisa , Vikram Garhwal , Jason Wang , Dmitry Fleytman , Stefan Weil , Jiri Pirko , Sven Schnelle , Keith Busch , Klaus Jensen , Huacai Chen , Jiaxun Yang , Helge Deller , Mark Cave-Ayland , Yoshinori Sato , Magnus Damm , Daniel Henrique Barboza , =?utf-8?Q?C=C3=A9dric?= Le Goater , David Gibson , Greg Kurz , Yuval Shaia , Matthew Rosato , Eric Farman , David Hildenbrand , Ilya Leoshkevich , Halil Pasic , Christian Borntraeger , Thomas Huth , Fam Zheng , Alex Williamson , Beniamino Galvani , Ben Widawsky , Jonathan Cameron , Elena Ufimtseva , Jagannathan Raman , John G Johnson , Bin Meng , Alexander Bulekov , Bandan Das , Stefan Hajnoczi , Darren Kenny , Qiuhao Li , Laurent Vivier , qemu-ppc@nongnu.org, xen-devel@lists.xenproject.org, qemu-block@nongnu.org, qemu-arm@nongnu.org, qemu-s390x@nongnu.org Subject: [PULL 31/51] include/hw/pci: Split pci_device.h off pci.h Message-ID: <20230105091310.263867-32-mst@redhat.com> References: <20230105091310.263867-1-mst@redhat.com> MIME-Version: 1.0 In-Reply-To: <20230105091310.263867-1-mst@redhat.com> X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline From: Markus Armbruster PCIDeviceClass and PCIDevice are defined in pci.h. Many users of the header don't actually need them. Similar structs live in their own headers: PCIBusClass and PCIBus in pci_bus.h, PCIBridge in pci_bridge.h, PCIHostBridgeClass and PCIHostState in pci_host.h, PCIExpressHost in pcie_host.h, and PCIERootPortClass, PCIEPort, and PCIESlot in pcie_port.h. Move PCIDeviceClass and PCIDeviceClass to new pci_device.h, along with the code that needs them. Adjust include directives. This also enables the next commit. Signed-off-by: Markus Armbruster Message-Id: <20221222100330.380143-6-armbru@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/display/ati_int.h | 2 +- hw/display/qxl.h | 3 +- hw/ide/ahci_internal.h | 2 +- hw/net/vmxnet3_defs.h | 2 +- hw/nvme/nvme.h | 2 +- hw/rdma/vmw/pvrdma.h | 1 + hw/scsi/mptsas.h | 2 +- hw/usb/hcd-ehci.h | 2 +- hw/usb/hcd-uhci.h | 2 +- hw/usb/hcd-xhci-pci.h | 1 + hw/vfio/pci.h | 2 +- include/hw/acpi/piix4.h | 2 +- include/hw/arm/allwinner-a10.h | 1 + include/hw/cxl/cxl_device.h | 2 +- include/hw/ide/pci.h | 2 +- include/hw/misc/macio/macio.h | 2 +- include/hw/pci-host/gpex.h | 2 +- include/hw/pci-host/i440fx.h | 2 +- include/hw/pci-host/q35.h | 2 +- include/hw/pci-host/sabre.h | 2 +- include/hw/pci/msi.h | 2 +- include/hw/pci/pci.h | 344 ------------------------------ include/hw/pci/pci_bridge.h | 2 +- include/hw/pci/pci_device.h | 350 +++++++++++++++++++++++++++++++ include/hw/pci/pcie_port.h | 1 + include/hw/pci/shpc.h | 2 +- include/hw/remote/iohub.h | 2 +- include/hw/remote/proxy.h | 2 +- include/hw/sd/sdhci.h | 2 +- include/hw/southbridge/piix.h | 3 +- include/hw/xen/xen_common.h | 2 +- hw/acpi/erst.c | 2 +- hw/audio/ac97.c | 2 +- hw/audio/es1370.c | 2 +- hw/audio/via-ac97.c | 2 +- hw/char/serial-pci-multi.c | 2 +- hw/char/serial-pci.c | 2 +- hw/core/qdev-properties-system.c | 1 + hw/display/bochs-display.c | 2 +- hw/display/cirrus_vga.c | 2 +- hw/display/sm501.c | 2 +- hw/display/vga-pci.c | 2 +- hw/display/vmware_vga.c | 2 +- hw/i386/xen/xen_pvdevice.c | 2 +- hw/ipack/tpci200.c | 2 +- hw/ipmi/pci_ipmi_bt.c | 2 +- hw/ipmi/pci_ipmi_kcs.c | 2 +- hw/isa/i82378.c | 2 +- hw/mips/gt64xxx_pci.c | 2 +- hw/misc/pci-testdev.c | 2 +- hw/misc/pvpanic-pci.c | 2 +- hw/net/can/can_kvaser_pci.c | 2 +- hw/net/can/can_mioe3680_pci.c | 2 +- hw/net/can/can_pcm3680_pci.c | 2 +- hw/net/can/ctucan_pci.c | 2 +- hw/net/e1000.c | 2 +- hw/net/e1000x_common.c | 2 +- hw/net/eepro100.c | 2 +- hw/net/ne2000-pci.c | 2 +- hw/net/net_tx_pkt.c | 2 +- hw/net/pcnet-pci.c | 2 +- hw/net/rocker/rocker.c | 2 +- hw/net/rocker/rocker_desc.c | 2 +- hw/net/rtl8139.c | 2 +- hw/net/sungem.c | 2 +- hw/net/sunhme.c | 2 +- hw/net/tulip.c | 2 +- hw/net/virtio-net.c | 2 +- hw/pci-host/bonito.c | 2 +- hw/pci-host/dino.c | 2 +- hw/pci-host/grackle.c | 2 +- hw/pci-host/mv64361.c | 2 +- hw/pci-host/ppce500.c | 2 +- hw/pci-host/raven.c | 2 +- hw/pci-host/sh_pci.c | 2 +- hw/pci-host/uninorth.c | 2 +- hw/pci-host/versatile.c | 2 +- hw/pci/pci-hmp-cmds.c | 1 + hw/pci/pcie_host.c | 2 +- hw/pci/pcie_sriov.c | 2 +- hw/pci/slotid_cap.c | 2 +- hw/ppc/ppc440_pcix.c | 2 +- hw/ppc/ppc4xx_pci.c | 2 +- hw/ppc/spapr_pci_vfio.c | 1 + hw/rdma/rdma_utils.c | 2 +- hw/s390x/s390-pci-inst.c | 1 + hw/scsi/esp-pci.c | 2 +- hw/scsi/lsi53c895a.c | 2 +- hw/smbios/smbios.c | 1 + hw/usb/hcd-ohci-pci.c | 2 +- hw/watchdog/wdt_i6300esb.c | 2 +- tests/qtest/fuzz/generic_fuzz.c | 1 + ui/util.c | 2 +- 93 files changed, 441 insertions(+), 427 deletions(-) create mode 100644 include/hw/pci/pci_device.h diff --git a/hw/display/ati_int.h b/hw/display/ati_int.h index 8acb9c7466..e8d3c7af75 100644 --- a/hw/display/ati_int.h +++ b/hw/display/ati_int.h @@ -10,7 +10,7 @@ #define ATI_INT_H #include "qemu/timer.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/i2c/bitbang_i2c.h" #include "vga_int.h" #include "qom/object.h" diff --git a/hw/display/qxl.h b/hw/display/qxl.h index 7894bd5134..cd82c7a6fe 100644 --- a/hw/display/qxl.h +++ b/hw/display/qxl.h @@ -1,8 +1,7 @@ #ifndef HW_QXL_H #define HW_QXL_H - -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "vga_int.h" #include "qemu/thread.h" diff --git a/hw/ide/ahci_internal.h b/hw/ide/ahci_internal.h index 109de9e2d1..303fcd7235 100644 --- a/hw/ide/ahci_internal.h +++ b/hw/ide/ahci_internal.h @@ -26,7 +26,7 @@ #include "hw/ide/ahci.h" #include "hw/ide/internal.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #define AHCI_MEM_BAR_SIZE 0x1000 #define AHCI_MAX_PORTS 32 diff --git a/hw/net/vmxnet3_defs.h b/hw/net/vmxnet3_defs.h index 71440509ca..64034af6d5 100644 --- a/hw/net/vmxnet3_defs.h +++ b/hw/net/vmxnet3_defs.h @@ -19,7 +19,7 @@ #include "net/net.h" #include "hw/net/vmxnet3.h" -#include "qom/object.h" +#include "hw/pci/pci_device.h" #define TYPE_VMXNET3 "vmxnet3" typedef struct VMXNET3State VMXNET3State; diff --git a/hw/nvme/nvme.h b/hw/nvme/nvme.h index 7adf042ec3..16da27a69b 100644 --- a/hw/nvme/nvme.h +++ b/hw/nvme/nvme.h @@ -19,7 +19,7 @@ #define HW_NVME_NVME_H #include "qemu/uuid.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/block/block.h" #include "block/nvme.h" diff --git a/hw/rdma/vmw/pvrdma.h b/hw/rdma/vmw/pvrdma.h index 0caf95ede8..4cbc10c980 100644 --- a/hw/rdma/vmw/pvrdma.h +++ b/hw/rdma/vmw/pvrdma.h @@ -19,6 +19,7 @@ #include "qemu/units.h" #include "qemu/notify.h" #include "hw/pci/msix.h" +#include "hw/pci/pci_device.h" #include "chardev/char-fe.h" #include "hw/net/vmxnet3_defs.h" diff --git a/hw/scsi/mptsas.h b/hw/scsi/mptsas.h index c046497db7..04e97ce3af 100644 --- a/hw/scsi/mptsas.h +++ b/hw/scsi/mptsas.h @@ -2,7 +2,7 @@ #define MPTSAS_H #include "mpi.h" -#include "qom/object.h" +#include "hw/pci/pci_device.h" #define MPTSAS_NUM_PORTS 8 #define MPTSAS_MAX_FRAMES 2048 /* Firmware limit at 65535 */ diff --git a/hw/usb/hcd-ehci.h b/hw/usb/hcd-ehci.h index 4d4b2830b7..2cd821f49e 100644 --- a/hw/usb/hcd-ehci.h +++ b/hw/usb/hcd-ehci.h @@ -21,7 +21,7 @@ #include "qemu/timer.h" #include "hw/usb.h" #include "sysemu/dma.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/sysbus.h" #ifndef EHCI_DEBUG diff --git a/hw/usb/hcd-uhci.h b/hw/usb/hcd-uhci.h index c85ab7868e..5843af504a 100644 --- a/hw/usb/hcd-uhci.h +++ b/hw/usb/hcd-uhci.h @@ -30,7 +30,7 @@ #include "exec/memory.h" #include "qemu/timer.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/usb.h" typedef struct UHCIQueue UHCIQueue; diff --git a/hw/usb/hcd-xhci-pci.h b/hw/usb/hcd-xhci-pci.h index c193f79443..08f70ce97c 100644 --- a/hw/usb/hcd-xhci-pci.h +++ b/hw/usb/hcd-xhci-pci.h @@ -24,6 +24,7 @@ #ifndef HW_USB_HCD_XHCI_PCI_H #define HW_USB_HCD_XHCI_PCI_H +#include "hw/pci/pci_device.h" #include "hw/usb.h" #include "hcd-xhci.h" diff --git a/hw/vfio/pci.h b/hw/vfio/pci.h index 7c236a52f4..177abcc8fb 100644 --- a/hw/vfio/pci.h +++ b/hw/vfio/pci.h @@ -13,7 +13,7 @@ #define HW_VFIO_VFIO_PCI_H #include "exec/memory.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/vfio/vfio-common.h" #include "qemu/event_notifier.h" #include "qemu/queue.h" diff --git a/include/hw/acpi/piix4.h b/include/hw/acpi/piix4.h index 32686a75c5..be1f8ea80e 100644 --- a/include/hw/acpi/piix4.h +++ b/include/hw/acpi/piix4.h @@ -22,7 +22,7 @@ #ifndef HW_ACPI_PIIX4_H #define HW_ACPI_PIIX4_H -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/acpi/acpi.h" #include "hw/acpi/cpu_hotplug.h" #include "hw/acpi/memory_hotplug.h" diff --git a/include/hw/arm/allwinner-a10.h b/include/hw/arm/allwinner-a10.h index a76dc7b84d..f9240ffa64 100644 --- a/include/hw/arm/allwinner-a10.h +++ b/include/hw/arm/allwinner-a10.h @@ -4,6 +4,7 @@ #include "qemu/error-report.h" #include "hw/char/serial.h" #include "hw/arm/boot.h" +#include "hw/pci/pci_device.h" #include "hw/timer/allwinner-a10-pit.h" #include "hw/intc/allwinner-a10-pic.h" #include "hw/net/allwinner_emac.h" diff --git a/include/hw/cxl/cxl_device.h b/include/hw/cxl/cxl_device.h index 3f91969db0..250adf18b2 100644 --- a/include/hw/cxl/cxl_device.h +++ b/include/hw/cxl/cxl_device.h @@ -11,7 +11,7 @@ #define CXL_DEVICE_H #include "hw/cxl/cxl_component.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/register.h" /* diff --git a/include/hw/ide/pci.h b/include/hw/ide/pci.h index d8384e1c42..2a6284acac 100644 --- a/include/hw/ide/pci.h +++ b/include/hw/ide/pci.h @@ -2,7 +2,7 @@ #define HW_IDE_PCI_H #include "hw/ide/internal.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "qom/object.h" #define BM_STATUS_DMAING 0x01 diff --git a/include/hw/misc/macio/macio.h b/include/hw/misc/macio/macio.h index 95d30a1745..86df2c2b60 100644 --- a/include/hw/misc/macio/macio.h +++ b/include/hw/misc/macio/macio.h @@ -27,7 +27,7 @@ #define MACIO_H #include "hw/char/escc.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/ide/internal.h" #include "hw/intc/heathrow_pic.h" #include "hw/misc/macio/cuda.h" diff --git a/include/hw/pci-host/gpex.h b/include/hw/pci-host/gpex.h index fcf8b63820..b0240bd768 100644 --- a/include/hw/pci-host/gpex.h +++ b/include/hw/pci-host/gpex.h @@ -22,7 +22,7 @@ #include "exec/hwaddr.h" #include "hw/sysbus.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/pci/pcie_host.h" #include "qom/object.h" diff --git a/include/hw/pci-host/i440fx.h b/include/hw/pci-host/i440fx.h index fc93e22732..bf57216c78 100644 --- a/include/hw/pci-host/i440fx.h +++ b/include/hw/pci-host/i440fx.h @@ -11,7 +11,7 @@ #ifndef HW_PCI_I440FX_H #define HW_PCI_I440FX_H -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/pci-host/pam.h" #include "qom/object.h" diff --git a/include/hw/pci-host/q35.h b/include/hw/pci-host/q35.h index ab989698ef..e89329c51e 100644 --- a/include/hw/pci-host/q35.h +++ b/include/hw/pci-host/q35.h @@ -22,7 +22,7 @@ #ifndef HW_Q35_H #define HW_Q35_H -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/pci/pcie_host.h" #include "hw/pci-host/pam.h" #include "qemu/units.h" diff --git a/include/hw/pci-host/sabre.h b/include/hw/pci-host/sabre.h index 01190241bb..d12de84ea2 100644 --- a/include/hw/pci-host/sabre.h +++ b/include/hw/pci-host/sabre.h @@ -1,7 +1,7 @@ #ifndef HW_PCI_HOST_SABRE_H #define HW_PCI_HOST_SABRE_H -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/pci/pci_host.h" #include "hw/sparc/sun4u_iommu.h" #include "qom/object.h" diff --git a/include/hw/pci/msi.h b/include/hw/pci/msi.h index 58aa576215..ee8ee469a6 100644 --- a/include/hw/pci/msi.h +++ b/include/hw/pci/msi.h @@ -21,7 +21,7 @@ #ifndef QEMU_MSI_H #define QEMU_MSI_H -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" struct MSIMessage { uint64_t address; diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h index 5ca2a9df58..7048a373d1 100644 --- a/include/hw/pci/pci.h +++ b/include/hw/pci/pci.h @@ -166,7 +166,6 @@ enum { #define QEMU_PCI_VGA_IO_HI_SIZE 0x20 #include "hw/pci/pci_regs.h" -#include "hw/pci/pcie.h" /* PCI HEADER_TYPE */ #define PCI_HEADER_TYPE_MULTI_FUNCTION 0x80 @@ -210,23 +209,6 @@ enum { QEMU_PCIE_CAP_CXL = (1 << QEMU_PCIE_CXL_BITNR), }; -#define TYPE_PCI_DEVICE "pci-device" -typedef struct PCIDeviceClass PCIDeviceClass; -DECLARE_OBJ_CHECKERS(PCIDevice, PCIDeviceClass, - PCI_DEVICE, TYPE_PCI_DEVICE) - -/* - * Implemented by devices that can be plugged on CXL buses. In the spec, this is - * actually a "CXL Component, but we name it device to match the PCI naming. - */ -#define INTERFACE_CXL_DEVICE "cxl-device" - -/* Implemented by devices that can be plugged on PCI Express buses */ -#define INTERFACE_PCIE_DEVICE "pci-express-device" - -/* Implemented by devices that can be plugged on Conventional PCI buses */ -#define INTERFACE_CONVENTIONAL_PCI_DEVICE "conventional-pci-device" - typedef struct PCIINTxRoute { enum { PCI_INTX_ENABLED, @@ -236,24 +218,6 @@ typedef struct PCIINTxRoute { int irq; } PCIINTxRoute; -struct PCIDeviceClass { - DeviceClass parent_class; - - void (*realize)(PCIDevice *dev, Error **errp); - PCIUnregisterFunc *exit; - PCIConfigReadFunc *config_read; - PCIConfigWriteFunc *config_write; - - uint16_t vendor_id; - uint16_t device_id; - uint8_t revision; - uint16_t class_id; - uint16_t subsystem_vendor_id; /* only for header type = 0 */ - uint16_t subsystem_id; /* only for header type = 0 */ - - const char *romfile; /* rom bar */ -}; - typedef void (*PCIINTxRoutingNotifier)(PCIDevice *dev); typedef int (*MSIVectorUseNotifier)(PCIDevice *dev, unsigned int vector, MSIMessage msg); @@ -262,129 +226,6 @@ typedef void (*MSIVectorPollNotifier)(PCIDevice *dev, unsigned int vector_start, unsigned int vector_end); -enum PCIReqIDType { - PCI_REQ_ID_INVALID = 0, - PCI_REQ_ID_BDF, - PCI_REQ_ID_SECONDARY_BUS, - PCI_REQ_ID_MAX, -}; -typedef enum PCIReqIDType PCIReqIDType; - -struct PCIReqIDCache { - PCIDevice *dev; - PCIReqIDType type; -}; -typedef struct PCIReqIDCache PCIReqIDCache; - -struct PCIDevice { - DeviceState qdev; - bool partially_hotplugged; - bool has_power; - - /* PCI config space */ - uint8_t *config; - - /* - * Used to enable config checks on load. Note that writable bits are - * never checked even if set in cmask. - */ - uint8_t *cmask; - - /* Used to implement R/W bytes */ - uint8_t *wmask; - - /* Used to implement RW1C(Write 1 to Clear) bytes */ - uint8_t *w1cmask; - - /* Used to allocate config space for capabilities. */ - uint8_t *used; - - /* the following fields are read only */ - int32_t devfn; - /* - * Cached device to fetch requester ID from, to avoid the PCI tree - * walking every time we invoke PCI request (e.g., MSI). For - * conventional PCI root complex, this field is meaningless. - */ - PCIReqIDCache requester_id_cache; - char name[64]; - PCIIORegion io_regions[PCI_NUM_REGIONS]; - AddressSpace bus_master_as; - MemoryRegion bus_master_container_region; - MemoryRegion bus_master_enable_region; - - /* do not access the following fields */ - PCIConfigReadFunc *config_read; - PCIConfigWriteFunc *config_write; - - /* Legacy PCI VGA regions */ - MemoryRegion *vga_regions[QEMU_PCI_VGA_NUM_REGIONS]; - bool has_vga; - - /* Current IRQ levels. Used internally by the generic PCI code. */ - uint8_t irq_state; - - /* Capability bits */ - uint32_t cap_present; - - /* Offset of MSI-X capability in config space */ - uint8_t msix_cap; - - /* MSI-X entries */ - int msix_entries_nr; - - /* Space to store MSIX table & pending bit array */ - uint8_t *msix_table; - uint8_t *msix_pba; - - /* May be used by INTx or MSI during interrupt notification */ - void *irq_opaque; - - MSITriggerFunc *msi_trigger; - MSIPrepareMessageFunc *msi_prepare_message; - MSIxPrepareMessageFunc *msix_prepare_message; - - /* MemoryRegion container for msix exclusive BAR setup */ - MemoryRegion msix_exclusive_bar; - /* Memory Regions for MSIX table and pending bit entries. */ - MemoryRegion msix_table_mmio; - MemoryRegion msix_pba_mmio; - /* Reference-count for entries actually in use by driver. */ - unsigned *msix_entry_used; - /* MSIX function mask set or MSIX disabled */ - bool msix_function_masked; - /* Version id needed for VMState */ - int32_t version_id; - - /* Offset of MSI capability in config space */ - uint8_t msi_cap; - - /* PCI Express */ - PCIExpressDevice exp; - - /* SHPC */ - SHPCDevice *shpc; - - /* Location of option rom */ - char *romfile; - uint32_t romsize; - bool has_rom; - MemoryRegion rom; - uint32_t rom_bar; - - /* INTx routing notifier */ - PCIINTxRoutingNotifier intx_routing_notifier; - - /* MSI-X notifiers */ - MSIVectorUseNotifier msix_vector_use_notifier; - MSIVectorReleaseNotifier msix_vector_release_notifier; - MSIVectorPollNotifier msix_vector_poll_notifier; - - /* ID of standby device in net_failover pair */ - char *failover_pair_id; - uint32_t acpi_index; -}; - void pci_register_bar(PCIDevice *pci_dev, int region_num, uint8_t attr, MemoryRegion *memory); void pci_register_vga(PCIDevice *pci_dev, MemoryRegion *mem, @@ -745,11 +586,6 @@ void lsi53c8xx_handle_legacy_cmdline(DeviceState *lsi_dev); qemu_irq pci_allocate_irq(PCIDevice *pci_dev); void pci_set_irq(PCIDevice *pci_dev, int level); -static inline int pci_intx(PCIDevice *pci_dev) -{ - return pci_get_byte(pci_dev->config + PCI_INTERRUPT_PIN) - 1; -} - static inline void pci_irq_assert(PCIDevice *pci_dev) { pci_set_irq(pci_dev, 1); @@ -770,186 +606,6 @@ static inline void pci_irq_pulse(PCIDevice *pci_dev) pci_irq_deassert(pci_dev); } -static inline int pci_is_cxl(const PCIDevice *d) -{ - return d->cap_present & QEMU_PCIE_CAP_CXL; -} - -static inline int pci_is_express(const PCIDevice *d) -{ - return d->cap_present & QEMU_PCI_CAP_EXPRESS; -} - -static inline int pci_is_express_downstream_port(const PCIDevice *d) -{ - uint8_t type; - - if (!pci_is_express(d) || !d->exp.exp_cap) { - return 0; - } - - type = pcie_cap_get_type(d); - - return type == PCI_EXP_TYPE_DOWNSTREAM || type == PCI_EXP_TYPE_ROOT_PORT; -} - -static inline int pci_is_vf(const PCIDevice *d) -{ - return d->exp.sriov_vf.pf != NULL; -} - -static inline uint32_t pci_config_size(const PCIDevice *d) -{ - return pci_is_express(d) ? PCIE_CONFIG_SPACE_SIZE : PCI_CONFIG_SPACE_SIZE; -} - -static inline uint16_t pci_get_bdf(PCIDevice *dev) -{ - return PCI_BUILD_BDF(pci_bus_num(pci_get_bus(dev)), dev->devfn); -} - -uint16_t pci_requester_id(PCIDevice *dev); - -/* DMA access functions */ -static inline AddressSpace *pci_get_address_space(PCIDevice *dev) -{ - return &dev->bus_master_as; -} - -/** - * pci_dma_rw: Read from or write to an address space from PCI device. - * - * Return a MemTxResult indicating whether the operation succeeded - * or failed (eg unassigned memory, device rejected the transaction, - * IOMMU fault). - * - * @dev: #PCIDevice doing the memory access - * @addr: address within the #PCIDevice address space - * @buf: buffer with the data transferred - * @len: the number of bytes to read or write - * @dir: indicates the transfer direction - */ -static inline MemTxResult pci_dma_rw(PCIDevice *dev, dma_addr_t addr, - void *buf, dma_addr_t len, - DMADirection dir, MemTxAttrs attrs) -{ - return dma_memory_rw(pci_get_address_space(dev), addr, buf, len, - dir, attrs); -} - -/** - * pci_dma_read: Read from an address space from PCI device. - * - * Return a MemTxResult indicating whether the operation succeeded - * or failed (eg unassigned memory, device rejected the transaction, - * IOMMU fault). Called within RCU critical section. - * - * @dev: #PCIDevice doing the memory access - * @addr: address within the #PCIDevice address space - * @buf: buffer with the data transferred - * @len: length of the data transferred - */ -static inline MemTxResult pci_dma_read(PCIDevice *dev, dma_addr_t addr, - void *buf, dma_addr_t len) -{ - return pci_dma_rw(dev, addr, buf, len, - DMA_DIRECTION_TO_DEVICE, MEMTXATTRS_UNSPECIFIED); -} - -/** - * pci_dma_write: Write to address space from PCI device. - * - * Return a MemTxResult indicating whether the operation succeeded - * or failed (eg unassigned memory, device rejected the transaction, - * IOMMU fault). - * - * @dev: #PCIDevice doing the memory access - * @addr: address within the #PCIDevice address space - * @buf: buffer with the data transferred - * @len: the number of bytes to write - */ -static inline MemTxResult pci_dma_write(PCIDevice *dev, dma_addr_t addr, - const void *buf, dma_addr_t len) -{ - return pci_dma_rw(dev, addr, (void *) buf, len, - DMA_DIRECTION_FROM_DEVICE, MEMTXATTRS_UNSPECIFIED); -} - -#define PCI_DMA_DEFINE_LDST(_l, _s, _bits) \ - static inline MemTxResult ld##_l##_pci_dma(PCIDevice *dev, \ - dma_addr_t addr, \ - uint##_bits##_t *val, \ - MemTxAttrs attrs) \ - { \ - return ld##_l##_dma(pci_get_address_space(dev), addr, val, attrs); \ - } \ - static inline MemTxResult st##_s##_pci_dma(PCIDevice *dev, \ - dma_addr_t addr, \ - uint##_bits##_t val, \ - MemTxAttrs attrs) \ - { \ - return st##_s##_dma(pci_get_address_space(dev), addr, val, attrs); \ - } - -PCI_DMA_DEFINE_LDST(ub, b, 8); -PCI_DMA_DEFINE_LDST(uw_le, w_le, 16) -PCI_DMA_DEFINE_LDST(l_le, l_le, 32); -PCI_DMA_DEFINE_LDST(q_le, q_le, 64); -PCI_DMA_DEFINE_LDST(uw_be, w_be, 16) -PCI_DMA_DEFINE_LDST(l_be, l_be, 32); -PCI_DMA_DEFINE_LDST(q_be, q_be, 64); - -#undef PCI_DMA_DEFINE_LDST - -/** - * pci_dma_map: Map device PCI address space range into host virtual address - * @dev: #PCIDevice to be accessed - * @addr: address within that device's address space - * @plen: pointer to length of buffer; updated on return to indicate - * if only a subset of the requested range has been mapped - * @dir: indicates the transfer direction - * - * Return: A host pointer, or %NULL if the resources needed to - * perform the mapping are exhausted (in that case *@plen - * is set to zero). - */ -static inline void *pci_dma_map(PCIDevice *dev, dma_addr_t addr, - dma_addr_t *plen, DMADirection dir) -{ - return dma_memory_map(pci_get_address_space(dev), addr, plen, dir, - MEMTXATTRS_UNSPECIFIED); -} - -static inline void pci_dma_unmap(PCIDevice *dev, void *buffer, dma_addr_t len, - DMADirection dir, dma_addr_t access_len) -{ - dma_memory_unmap(pci_get_address_space(dev), buffer, len, dir, access_len); -} - -static inline void pci_dma_sglist_init(QEMUSGList *qsg, PCIDevice *dev, - int alloc_hint) -{ - qemu_sglist_init(qsg, DEVICE(dev), alloc_hint, pci_get_address_space(dev)); -} - -extern const VMStateDescription vmstate_pci_device; - -#define VMSTATE_PCI_DEVICE(_field, _state) { \ - .name = (stringify(_field)), \ - .size = sizeof(PCIDevice), \ - .vmsd = &vmstate_pci_device, \ - .flags = VMS_STRUCT, \ - .offset = vmstate_offset_value(_state, _field, PCIDevice), \ -} - -#define VMSTATE_PCI_DEVICE_POINTER(_field, _state) { \ - .name = (stringify(_field)), \ - .size = sizeof(PCIDevice), \ - .vmsd = &vmstate_pci_device, \ - .flags = VMS_STRUCT | VMS_POINTER, \ - .offset = vmstate_offset_pointer(_state, _field, PCIDevice), \ -} - MSIMessage pci_get_msi_message(PCIDevice *dev, int vector); void pci_set_power(PCIDevice *pci_dev, bool state); diff --git a/include/hw/pci/pci_bridge.h b/include/hw/pci/pci_bridge.h index 58a3fb0c2c..63a7521567 100644 --- a/include/hw/pci/pci_bridge.h +++ b/include/hw/pci/pci_bridge.h @@ -26,7 +26,7 @@ #ifndef QEMU_PCI_BRIDGE_H #define QEMU_PCI_BRIDGE_H -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/pci/pci_bus.h" #include "hw/cxl/cxl.h" #include "qom/object.h" diff --git a/include/hw/pci/pci_device.h b/include/hw/pci/pci_device.h new file mode 100644 index 0000000000..d3dd0f64b2 --- /dev/null +++ b/include/hw/pci/pci_device.h @@ -0,0 +1,350 @@ +#ifndef QEMU_PCI_DEVICE_H +#define QEMU_PCI_DEVICE_H + +#include "hw/pci/pci.h" +#include "hw/pci/pcie.h" + +#define TYPE_PCI_DEVICE "pci-device" +typedef struct PCIDeviceClass PCIDeviceClass; +DECLARE_OBJ_CHECKERS(PCIDevice, PCIDeviceClass, + PCI_DEVICE, TYPE_PCI_DEVICE) + +/* + * Implemented by devices that can be plugged on CXL buses. In the spec, this is + * actually a "CXL Component, but we name it device to match the PCI naming. + */ +#define INTERFACE_CXL_DEVICE "cxl-device" + +/* Implemented by devices that can be plugged on PCI Express buses */ +#define INTERFACE_PCIE_DEVICE "pci-express-device" + +/* Implemented by devices that can be plugged on Conventional PCI buses */ +#define INTERFACE_CONVENTIONAL_PCI_DEVICE "conventional-pci-device" + +struct PCIDeviceClass { + DeviceClass parent_class; + + void (*realize)(PCIDevice *dev, Error **errp); + PCIUnregisterFunc *exit; + PCIConfigReadFunc *config_read; + PCIConfigWriteFunc *config_write; + + uint16_t vendor_id; + uint16_t device_id; + uint8_t revision; + uint16_t class_id; + uint16_t subsystem_vendor_id; /* only for header type = 0 */ + uint16_t subsystem_id; /* only for header type = 0 */ + + const char *romfile; /* rom bar */ +}; + +enum PCIReqIDType { + PCI_REQ_ID_INVALID = 0, + PCI_REQ_ID_BDF, + PCI_REQ_ID_SECONDARY_BUS, + PCI_REQ_ID_MAX, +}; +typedef enum PCIReqIDType PCIReqIDType; + +struct PCIReqIDCache { + PCIDevice *dev; + PCIReqIDType type; +}; +typedef struct PCIReqIDCache PCIReqIDCache; + +struct PCIDevice { + DeviceState qdev; + bool partially_hotplugged; + bool has_power; + + /* PCI config space */ + uint8_t *config; + + /* + * Used to enable config checks on load. Note that writable bits are + * never checked even if set in cmask. + */ + uint8_t *cmask; + + /* Used to implement R/W bytes */ + uint8_t *wmask; + + /* Used to implement RW1C(Write 1 to Clear) bytes */ + uint8_t *w1cmask; + + /* Used to allocate config space for capabilities. */ + uint8_t *used; + + /* the following fields are read only */ + int32_t devfn; + /* + * Cached device to fetch requester ID from, to avoid the PCI tree + * walking every time we invoke PCI request (e.g., MSI). For + * conventional PCI root complex, this field is meaningless. + */ + PCIReqIDCache requester_id_cache; + char name[64]; + PCIIORegion io_regions[PCI_NUM_REGIONS]; + AddressSpace bus_master_as; + MemoryRegion bus_master_container_region; + MemoryRegion bus_master_enable_region; + + /* do not access the following fields */ + PCIConfigReadFunc *config_read; + PCIConfigWriteFunc *config_write; + + /* Legacy PCI VGA regions */ + MemoryRegion *vga_regions[QEMU_PCI_VGA_NUM_REGIONS]; + bool has_vga; + + /* Current IRQ levels. Used internally by the generic PCI code. */ + uint8_t irq_state; + + /* Capability bits */ + uint32_t cap_present; + + /* Offset of MSI-X capability in config space */ + uint8_t msix_cap; + + /* MSI-X entries */ + int msix_entries_nr; + + /* Space to store MSIX table & pending bit array */ + uint8_t *msix_table; + uint8_t *msix_pba; + + /* May be used by INTx or MSI during interrupt notification */ + void *irq_opaque; + + MSITriggerFunc *msi_trigger; + MSIPrepareMessageFunc *msi_prepare_message; + MSIxPrepareMessageFunc *msix_prepare_message; + + /* MemoryRegion container for msix exclusive BAR setup */ + MemoryRegion msix_exclusive_bar; + /* Memory Regions for MSIX table and pending bit entries. */ + MemoryRegion msix_table_mmio; + MemoryRegion msix_pba_mmio; + /* Reference-count for entries actually in use by driver. */ + unsigned *msix_entry_used; + /* MSIX function mask set or MSIX disabled */ + bool msix_function_masked; + /* Version id needed for VMState */ + int32_t version_id; + + /* Offset of MSI capability in config space */ + uint8_t msi_cap; + + /* PCI Express */ + PCIExpressDevice exp; + + /* SHPC */ + SHPCDevice *shpc; + + /* Location of option rom */ + char *romfile; + uint32_t romsize; + bool has_rom; + MemoryRegion rom; + uint32_t rom_bar; + + /* INTx routing notifier */ + PCIINTxRoutingNotifier intx_routing_notifier; + + /* MSI-X notifiers */ + MSIVectorUseNotifier msix_vector_use_notifier; + MSIVectorReleaseNotifier msix_vector_release_notifier; + MSIVectorPollNotifier msix_vector_poll_notifier; + + /* ID of standby device in net_failover pair */ + char *failover_pair_id; + uint32_t acpi_index; +}; + +static inline int pci_intx(PCIDevice *pci_dev) +{ + return pci_get_byte(pci_dev->config + PCI_INTERRUPT_PIN) - 1; +} + +static inline int pci_is_cxl(const PCIDevice *d) +{ + return d->cap_present & QEMU_PCIE_CAP_CXL; +} + +static inline int pci_is_express(const PCIDevice *d) +{ + return d->cap_present & QEMU_PCI_CAP_EXPRESS; +} + +static inline int pci_is_express_downstream_port(const PCIDevice *d) +{ + uint8_t type; + + if (!pci_is_express(d) || !d->exp.exp_cap) { + return 0; + } + + type = pcie_cap_get_type(d); + + return type == PCI_EXP_TYPE_DOWNSTREAM || type == PCI_EXP_TYPE_ROOT_PORT; +} + +static inline int pci_is_vf(const PCIDevice *d) +{ + return d->exp.sriov_vf.pf != NULL; +} + +static inline uint32_t pci_config_size(const PCIDevice *d) +{ + return pci_is_express(d) ? PCIE_CONFIG_SPACE_SIZE : PCI_CONFIG_SPACE_SIZE; +} + +static inline uint16_t pci_get_bdf(PCIDevice *dev) +{ + return PCI_BUILD_BDF(pci_bus_num(pci_get_bus(dev)), dev->devfn); +} + +uint16_t pci_requester_id(PCIDevice *dev); + +/* DMA access functions */ +static inline AddressSpace *pci_get_address_space(PCIDevice *dev) +{ + return &dev->bus_master_as; +} + +/** + * pci_dma_rw: Read from or write to an address space from PCI device. + * + * Return a MemTxResult indicating whether the operation succeeded + * or failed (eg unassigned memory, device rejected the transaction, + * IOMMU fault). + * + * @dev: #PCIDevice doing the memory access + * @addr: address within the #PCIDevice address space + * @buf: buffer with the data transferred + * @len: the number of bytes to read or write + * @dir: indicates the transfer direction + */ +static inline MemTxResult pci_dma_rw(PCIDevice *dev, dma_addr_t addr, + void *buf, dma_addr_t len, + DMADirection dir, MemTxAttrs attrs) +{ + return dma_memory_rw(pci_get_address_space(dev), addr, buf, len, + dir, attrs); +} + +/** + * pci_dma_read: Read from an address space from PCI device. + * + * Return a MemTxResult indicating whether the operation succeeded + * or failed (eg unassigned memory, device rejected the transaction, + * IOMMU fault). Called within RCU critical section. + * + * @dev: #PCIDevice doing the memory access + * @addr: address within the #PCIDevice address space + * @buf: buffer with the data transferred + * @len: length of the data transferred + */ +static inline MemTxResult pci_dma_read(PCIDevice *dev, dma_addr_t addr, + void *buf, dma_addr_t len) +{ + return pci_dma_rw(dev, addr, buf, len, + DMA_DIRECTION_TO_DEVICE, MEMTXATTRS_UNSPECIFIED); +} + +/** + * pci_dma_write: Write to address space from PCI device. + * + * Return a MemTxResult indicating whether the operation succeeded + * or failed (eg unassigned memory, device rejected the transaction, + * IOMMU fault). + * + * @dev: #PCIDevice doing the memory access + * @addr: address within the #PCIDevice address space + * @buf: buffer with the data transferred + * @len: the number of bytes to write + */ +static inline MemTxResult pci_dma_write(PCIDevice *dev, dma_addr_t addr, + const void *buf, dma_addr_t len) +{ + return pci_dma_rw(dev, addr, (void *) buf, len, + DMA_DIRECTION_FROM_DEVICE, MEMTXATTRS_UNSPECIFIED); +} + +#define PCI_DMA_DEFINE_LDST(_l, _s, _bits) \ + static inline MemTxResult ld##_l##_pci_dma(PCIDevice *dev, \ + dma_addr_t addr, \ + uint##_bits##_t *val, \ + MemTxAttrs attrs) \ + { \ + return ld##_l##_dma(pci_get_address_space(dev), addr, val, attrs); \ + } \ + static inline MemTxResult st##_s##_pci_dma(PCIDevice *dev, \ + dma_addr_t addr, \ + uint##_bits##_t val, \ + MemTxAttrs attrs) \ + { \ + return st##_s##_dma(pci_get_address_space(dev), addr, val, attrs); \ + } + +PCI_DMA_DEFINE_LDST(ub, b, 8); +PCI_DMA_DEFINE_LDST(uw_le, w_le, 16) +PCI_DMA_DEFINE_LDST(l_le, l_le, 32); +PCI_DMA_DEFINE_LDST(q_le, q_le, 64); +PCI_DMA_DEFINE_LDST(uw_be, w_be, 16) +PCI_DMA_DEFINE_LDST(l_be, l_be, 32); +PCI_DMA_DEFINE_LDST(q_be, q_be, 64); + +#undef PCI_DMA_DEFINE_LDST + +/** + * pci_dma_map: Map device PCI address space range into host virtual address + * @dev: #PCIDevice to be accessed + * @addr: address within that device's address space + * @plen: pointer to length of buffer; updated on return to indicate + * if only a subset of the requested range has been mapped + * @dir: indicates the transfer direction + * + * Return: A host pointer, or %NULL if the resources needed to + * perform the mapping are exhausted (in that case *@plen + * is set to zero). + */ +static inline void *pci_dma_map(PCIDevice *dev, dma_addr_t addr, + dma_addr_t *plen, DMADirection dir) +{ + return dma_memory_map(pci_get_address_space(dev), addr, plen, dir, + MEMTXATTRS_UNSPECIFIED); +} + +static inline void pci_dma_unmap(PCIDevice *dev, void *buffer, dma_addr_t len, + DMADirection dir, dma_addr_t access_len) +{ + dma_memory_unmap(pci_get_address_space(dev), buffer, len, dir, access_len); +} + +static inline void pci_dma_sglist_init(QEMUSGList *qsg, PCIDevice *dev, + int alloc_hint) +{ + qemu_sglist_init(qsg, DEVICE(dev), alloc_hint, pci_get_address_space(dev)); +} + +extern const VMStateDescription vmstate_pci_device; + +#define VMSTATE_PCI_DEVICE(_field, _state) { \ + .name = (stringify(_field)), \ + .size = sizeof(PCIDevice), \ + .vmsd = &vmstate_pci_device, \ + .flags = VMS_STRUCT, \ + .offset = vmstate_offset_value(_state, _field, PCIDevice), \ +} + +#define VMSTATE_PCI_DEVICE_POINTER(_field, _state) { \ + .name = (stringify(_field)), \ + .size = sizeof(PCIDevice), \ + .vmsd = &vmstate_pci_device, \ + .flags = VMS_STRUCT | VMS_POINTER, \ + .offset = vmstate_offset_pointer(_state, _field, PCIDevice), \ +} + +#endif diff --git a/include/hw/pci/pcie_port.h b/include/hw/pci/pcie_port.h index d9b5d07504..fd484afb30 100644 --- a/include/hw/pci/pcie_port.h +++ b/include/hw/pci/pcie_port.h @@ -23,6 +23,7 @@ #include "hw/pci/pci_bridge.h" #include "hw/pci/pci_bus.h" +#include "hw/pci/pci_device.h" #include "qom/object.h" #define TYPE_PCIE_PORT "pcie-port" diff --git a/include/hw/pci/shpc.h b/include/hw/pci/shpc.h index d5683b7399..89c7a3b7fa 100644 --- a/include/hw/pci/shpc.h +++ b/include/hw/pci/shpc.h @@ -3,7 +3,7 @@ #include "exec/memory.h" #include "hw/hotplug.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "migration/vmstate.h" struct SHPCDevice { diff --git a/include/hw/remote/iohub.h b/include/hw/remote/iohub.h index 0bf98e0d78..6a8444f9a9 100644 --- a/include/hw/remote/iohub.h +++ b/include/hw/remote/iohub.h @@ -11,7 +11,7 @@ #ifndef REMOTE_IOHUB_H #define REMOTE_IOHUB_H -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "qemu/event_notifier.h" #include "qemu/thread-posix.h" #include "hw/remote/mpqemu-link.h" diff --git a/include/hw/remote/proxy.h b/include/hw/remote/proxy.h index 741def71f1..0cfd9665be 100644 --- a/include/hw/remote/proxy.h +++ b/include/hw/remote/proxy.h @@ -9,7 +9,7 @@ #ifndef PROXY_H #define PROXY_H -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "io/channel.h" #include "hw/remote/proxy-memory-listener.h" #include "qemu/event_notifier.h" diff --git a/include/hw/sd/sdhci.h b/include/hw/sd/sdhci.h index a989fca3b2..6cd2822f1d 100644 --- a/include/hw/sd/sdhci.h +++ b/include/hw/sd/sdhci.h @@ -25,7 +25,7 @@ #ifndef SDHCI_H #define SDHCI_H -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/sysbus.h" #include "hw/sd/sd.h" #include "qom/object.h" diff --git a/include/hw/southbridge/piix.h b/include/hw/southbridge/piix.h index 2693778b23..0bf48e936d 100644 --- a/include/hw/southbridge/piix.h +++ b/include/hw/southbridge/piix.h @@ -12,8 +12,7 @@ #ifndef HW_SOUTHBRIDGE_PIIX_H #define HW_SOUTHBRIDGE_PIIX_H -#include "hw/pci/pci.h" -#include "qom/object.h" +#include "hw/pci/pci_device.h" /* PIRQRC[A:D]: PIRQx Route Control Registers */ #define PIIX_PIRQCA 0x60 diff --git a/include/hw/xen/xen_common.h b/include/hw/xen/xen_common.h index 77ce17d8a4..9a13a756ae 100644 --- a/include/hw/xen/xen_common.h +++ b/include/hw/xen/xen_common.h @@ -15,7 +15,7 @@ #include "hw/xen/interface/io/xenbus.h" #include "hw/xen/xen.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/xen/trace.h" extern xc_interface *xen_xc; diff --git a/hw/acpi/erst.c b/hw/acpi/erst.c index aefcc03ad6..35007d8017 100644 --- a/hw/acpi/erst.c +++ b/hw/acpi/erst.c @@ -14,7 +14,7 @@ #include "hw/qdev-core.h" #include "exec/memory.h" #include "qom/object.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "qom/object_interfaces.h" #include "qemu/error-report.h" #include "migration/vmstate.h" diff --git a/hw/audio/ac97.c b/hw/audio/ac97.c index be2dd701a4..364cdfa733 100644 --- a/hw/audio/ac97.c +++ b/hw/audio/ac97.c @@ -20,7 +20,7 @@ #include "qemu/osdep.h" #include "hw/audio/soundhw.h" #include "audio/audio.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/qdev-properties.h" #include "migration/vmstate.h" #include "qemu/module.h" diff --git a/hw/audio/es1370.c b/hw/audio/es1370.c index 6904589814..54cc19a637 100644 --- a/hw/audio/es1370.c +++ b/hw/audio/es1370.c @@ -29,7 +29,7 @@ #include "qemu/osdep.h" #include "hw/audio/soundhw.h" #include "audio/audio.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "migration/vmstate.h" #include "qemu/module.h" #include "sysemu/dma.h" diff --git a/hw/audio/via-ac97.c b/hw/audio/via-ac97.c index 6d556f74fc..d1a856f63d 100644 --- a/hw/audio/via-ac97.c +++ b/hw/audio/via-ac97.c @@ -11,7 +11,7 @@ #include "qemu/osdep.h" #include "hw/isa/vt82c686.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" static void via_ac97_realize(PCIDevice *pci_dev, Error **errp) { diff --git a/hw/char/serial-pci-multi.c b/hw/char/serial-pci-multi.c index 3a9f96c2d1..f18b8dcce5 100644 --- a/hw/char/serial-pci-multi.c +++ b/hw/char/serial-pci-multi.c @@ -31,7 +31,7 @@ #include "qapi/error.h" #include "hw/char/serial.h" #include "hw/irq.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/qdev-properties.h" #include "hw/qdev-properties-system.h" #include "migration/vmstate.h" diff --git a/hw/char/serial-pci.c b/hw/char/serial-pci.c index 93d6f99244..801b769aba 100644 --- a/hw/char/serial-pci.c +++ b/hw/char/serial-pci.c @@ -30,7 +30,7 @@ #include "qemu/module.h" #include "hw/char/serial.h" #include "hw/irq.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/qdev-properties.h" #include "migration/vmstate.h" #include "qom/object.h" diff --git a/hw/core/qdev-properties-system.c b/hw/core/qdev-properties-system.c index 97a968f477..54a09fa9ac 100644 --- a/hw/core/qdev-properties-system.c +++ b/hw/core/qdev-properties-system.c @@ -32,6 +32,7 @@ #include "sysemu/blockdev.h" #include "net/net.h" #include "hw/pci/pci.h" +#include "hw/pci/pcie.h" #include "util/block-helpers.h" static bool check_prop_still_unset(Object *obj, const char *name, diff --git a/hw/display/bochs-display.c b/hw/display/bochs-display.c index 8ed734b195..e7ec268184 100644 --- a/hw/display/bochs-display.c +++ b/hw/display/bochs-display.c @@ -8,7 +8,7 @@ #include "qemu/osdep.h" #include "qemu/module.h" #include "qemu/units.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/qdev-properties.h" #include "migration/vmstate.h" #include "hw/display/bochs-vbe.h" diff --git a/hw/display/cirrus_vga.c b/hw/display/cirrus_vga.c index 6e8c747c46..55c32e3e40 100644 --- a/hw/display/cirrus_vga.c +++ b/hw/display/cirrus_vga.c @@ -39,7 +39,7 @@ #include "sysemu/reset.h" #include "qapi/error.h" #include "trace.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/qdev-properties.h" #include "migration/vmstate.h" #include "ui/pixel_ops.h" diff --git a/hw/display/sm501.c b/hw/display/sm501.c index 663c37e7f2..52e42585af 100644 --- a/hw/display/sm501.c +++ b/hw/display/sm501.c @@ -32,7 +32,7 @@ #include "ui/console.h" #include "hw/sysbus.h" #include "migration/vmstate.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/qdev-properties.h" #include "hw/i2c/i2c.h" #include "hw/display/i2c-ddc.h" diff --git a/hw/display/vga-pci.c b/hw/display/vga-pci.c index df23dbf3a0..b351b8f299 100644 --- a/hw/display/vga-pci.c +++ b/hw/display/vga-pci.c @@ -25,7 +25,7 @@ */ #include "qemu/osdep.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/qdev-properties.h" #include "migration/vmstate.h" #include "vga_int.h" diff --git a/hw/display/vmware_vga.c b/hw/display/vmware_vga.c index 53949d2539..59ae7f74b8 100644 --- a/hw/display/vmware_vga.c +++ b/hw/display/vmware_vga.c @@ -29,7 +29,7 @@ #include "qemu/log.h" #include "hw/loader.h" #include "trace.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/qdev-properties.h" #include "migration/vmstate.h" #include "qom/object.h" diff --git a/hw/i386/xen/xen_pvdevice.c b/hw/i386/xen/xen_pvdevice.c index 1ea95fa601..e62e06622b 100644 --- a/hw/i386/xen/xen_pvdevice.c +++ b/hw/i386/xen/xen_pvdevice.c @@ -32,7 +32,7 @@ #include "qemu/osdep.h" #include "qapi/error.h" #include "qemu/module.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/qdev-properties.h" #include "migration/vmstate.h" #include "trace.h" diff --git a/hw/ipack/tpci200.c b/hw/ipack/tpci200.c index 1f764fc85b..6b3edbf017 100644 --- a/hw/ipack/tpci200.c +++ b/hw/ipack/tpci200.c @@ -12,7 +12,7 @@ #include "qemu/units.h" #include "hw/ipack/ipack.h" #include "hw/irq.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "migration/vmstate.h" #include "qemu/bitops.h" #include "qemu/module.h" diff --git a/hw/ipmi/pci_ipmi_bt.c b/hw/ipmi/pci_ipmi_bt.c index b6e52730d3..633931b825 100644 --- a/hw/ipmi/pci_ipmi_bt.c +++ b/hw/ipmi/pci_ipmi_bt.c @@ -25,7 +25,7 @@ #include "migration/vmstate.h" #include "qapi/error.h" #include "hw/ipmi/ipmi_bt.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "qom/object.h" #define TYPE_PCI_IPMI_BT "pci-ipmi-bt" diff --git a/hw/ipmi/pci_ipmi_kcs.c b/hw/ipmi/pci_ipmi_kcs.c index de13418862..1a581413c2 100644 --- a/hw/ipmi/pci_ipmi_kcs.c +++ b/hw/ipmi/pci_ipmi_kcs.c @@ -25,7 +25,7 @@ #include "migration/vmstate.h" #include "qapi/error.h" #include "hw/ipmi/ipmi_kcs.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "qom/object.h" #define TYPE_PCI_IPMI_KCS "pci-ipmi-kcs" diff --git a/hw/isa/i82378.c b/hw/isa/i82378.c index 2a2ff05b93..e3322e03bf 100644 --- a/hw/isa/i82378.c +++ b/hw/isa/i82378.c @@ -18,7 +18,7 @@ */ #include "qemu/osdep.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/irq.h" #include "hw/intc/i8259.h" #include "hw/timer/i8254.h" diff --git a/hw/mips/gt64xxx_pci.c b/hw/mips/gt64xxx_pci.c index 19d0d9889f..164866cf3e 100644 --- a/hw/mips/gt64xxx_pci.c +++ b/hw/mips/gt64xxx_pci.c @@ -26,7 +26,7 @@ #include "qapi/error.h" #include "qemu/units.h" #include "qemu/log.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/pci/pci_host.h" #include "migration/vmstate.h" #include "hw/intc/i8259.h" diff --git a/hw/misc/pci-testdev.c b/hw/misc/pci-testdev.c index 03845c8de3..49303134e4 100644 --- a/hw/misc/pci-testdev.c +++ b/hw/misc/pci-testdev.c @@ -19,7 +19,7 @@ */ #include "qemu/osdep.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/qdev-properties.h" #include "qemu/event_notifier.h" #include "qemu/module.h" diff --git a/hw/misc/pvpanic-pci.c b/hw/misc/pvpanic-pci.c index 99cf7e2041..fbcaa50731 100644 --- a/hw/misc/pvpanic-pci.c +++ b/hw/misc/pvpanic-pci.c @@ -20,7 +20,7 @@ #include "migration/vmstate.h" #include "hw/misc/pvpanic.h" #include "qom/object.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "standard-headers/linux/pvpanic.h" OBJECT_DECLARE_SIMPLE_TYPE(PVPanicPCIState, PVPANIC_PCI_DEVICE) diff --git a/hw/net/can/can_kvaser_pci.c b/hw/net/can/can_kvaser_pci.c index 94b3a534f8..2cd90cef1e 100644 --- a/hw/net/can/can_kvaser_pci.c +++ b/hw/net/can/can_kvaser_pci.c @@ -37,7 +37,7 @@ #include "qapi/error.h" #include "chardev/char.h" #include "hw/irq.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/qdev-properties.h" #include "migration/vmstate.h" #include "net/can_emu.h" diff --git a/hw/net/can/can_mioe3680_pci.c b/hw/net/can/can_mioe3680_pci.c index 29dc696f7c..b9918773b3 100644 --- a/hw/net/can/can_mioe3680_pci.c +++ b/hw/net/can/can_mioe3680_pci.c @@ -33,7 +33,7 @@ #include "qapi/error.h" #include "chardev/char.h" #include "hw/irq.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/qdev-properties.h" #include "migration/vmstate.h" #include "net/can_emu.h" diff --git a/hw/net/can/can_pcm3680_pci.c b/hw/net/can/can_pcm3680_pci.c index e8e57f4f33..8ef3e4659c 100644 --- a/hw/net/can/can_pcm3680_pci.c +++ b/hw/net/can/can_pcm3680_pci.c @@ -33,7 +33,7 @@ #include "qapi/error.h" #include "chardev/char.h" #include "hw/irq.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/qdev-properties.h" #include "migration/vmstate.h" #include "net/can_emu.h" diff --git a/hw/net/can/ctucan_pci.c b/hw/net/can/ctucan_pci.c index 50f4ea6cd6..ea079e2af5 100644 --- a/hw/net/can/ctucan_pci.c +++ b/hw/net/can/ctucan_pci.c @@ -34,7 +34,7 @@ #include "qapi/error.h" #include "chardev/char.h" #include "hw/irq.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/qdev-properties.h" #include "migration/vmstate.h" #include "net/can_emu.h" diff --git a/hw/net/e1000.c b/hw/net/e1000.c index e26e0a64c1..7efb8a4c52 100644 --- a/hw/net/e1000.c +++ b/hw/net/e1000.c @@ -26,7 +26,7 @@ #include "qemu/osdep.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/qdev-properties.h" #include "migration/vmstate.h" #include "net/eth.h" diff --git a/hw/net/e1000x_common.c b/hw/net/e1000x_common.c index a8d93870b5..2f43e8cd13 100644 --- a/hw/net/e1000x_common.c +++ b/hw/net/e1000x_common.c @@ -24,7 +24,7 @@ #include "qemu/osdep.h" #include "qemu/units.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "net/net.h" #include "e1000x_common.h" diff --git a/hw/net/eepro100.c b/hw/net/eepro100.c index 679f52f80f..dc07984ae9 100644 --- a/hw/net/eepro100.c +++ b/hw/net/eepro100.c @@ -42,7 +42,7 @@ #include "qemu/osdep.h" #include "qemu/units.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/qdev-properties.h" #include "migration/vmstate.h" #include "net/net.h" diff --git a/hw/net/ne2000-pci.c b/hw/net/ne2000-pci.c index 9e5d10859a..edc6689d33 100644 --- a/hw/net/ne2000-pci.c +++ b/hw/net/ne2000-pci.c @@ -24,7 +24,7 @@ #include "qemu/osdep.h" #include "hw/irq.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/qdev-properties.h" #include "migration/vmstate.h" #include "ne2000.h" diff --git a/hw/net/net_tx_pkt.c b/hw/net/net_tx_pkt.c index 1cb1125d9f..2533ea2700 100644 --- a/hw/net/net_tx_pkt.c +++ b/hw/net/net_tx_pkt.c @@ -21,7 +21,7 @@ #include "net/checksum.h" #include "net/tap.h" #include "net/net.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" enum { NET_TX_PKT_VHDR_FRAG = 0, diff --git a/hw/net/pcnet-pci.c b/hw/net/pcnet-pci.c index 95d27102aa..96a302c141 100644 --- a/hw/net/pcnet-pci.c +++ b/hw/net/pcnet-pci.c @@ -29,7 +29,7 @@ #include "qemu/osdep.h" #include "hw/irq.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/qdev-properties.h" #include "migration/vmstate.h" #include "net/net.h" diff --git a/hw/net/rocker/rocker.c b/hw/net/rocker/rocker.c index 281d43e6cf..cf54ddf49d 100644 --- a/hw/net/rocker/rocker.c +++ b/hw/net/rocker/rocker.c @@ -16,7 +16,7 @@ */ #include "qemu/osdep.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/qdev-properties.h" #include "hw/qdev-properties-system.h" #include "migration/vmstate.h" diff --git a/hw/net/rocker/rocker_desc.c b/hw/net/rocker/rocker_desc.c index 01845f1157..f3068c9250 100644 --- a/hw/net/rocker/rocker_desc.c +++ b/hw/net/rocker/rocker_desc.c @@ -16,7 +16,7 @@ #include "qemu/osdep.h" #include "net/net.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "rocker.h" #include "rocker_hw.h" diff --git a/hw/net/rtl8139.c b/hw/net/rtl8139.c index 700b1b66b6..5a5aaf868d 100644 --- a/hw/net/rtl8139.c +++ b/hw/net/rtl8139.c @@ -53,7 +53,7 @@ #include "qemu/osdep.h" #include -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/qdev-properties.h" #include "migration/vmstate.h" #include "sysemu/dma.h" diff --git a/hw/net/sungem.c b/hw/net/sungem.c index 3684a4d733..eb01520790 100644 --- a/hw/net/sungem.c +++ b/hw/net/sungem.c @@ -8,7 +8,7 @@ */ #include "qemu/osdep.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/qdev-properties.h" #include "migration/vmstate.h" #include "qemu/log.h" diff --git a/hw/net/sunhme.c b/hw/net/sunhme.c index fc34905f87..1f3d8011ae 100644 --- a/hw/net/sunhme.c +++ b/hw/net/sunhme.c @@ -23,7 +23,7 @@ */ #include "qemu/osdep.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/qdev-properties.h" #include "migration/vmstate.h" #include "hw/net/mii.h" diff --git a/hw/net/tulip.c b/hw/net/tulip.c index c2b3b1bdfa..915e5fb595 100644 --- a/hw/net/tulip.c +++ b/hw/net/tulip.c @@ -9,7 +9,7 @@ #include "qemu/osdep.h" #include "qemu/log.h" #include "hw/irq.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/qdev-properties.h" #include "hw/nvram/eeprom93xx.h" #include "migration/vmstate.h" diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index f191e3037f..3ae909041a 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio-net.c @@ -42,7 +42,7 @@ #include "sysemu/sysemu.h" #include "trace.h" #include "monitor/qdev.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "net_rx_pkt.h" #include "hw/virtio/vhost.h" #include "sysemu/qtest.h" diff --git a/hw/pci-host/bonito.c b/hw/pci-host/bonito.c index a57e81e3a9..f04f3ad668 100644 --- a/hw/pci-host/bonito.c +++ b/hw/pci-host/bonito.c @@ -42,7 +42,7 @@ #include "qemu/units.h" #include "qapi/error.h" #include "qemu/error-report.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/irq.h" #include "hw/mips/mips.h" #include "hw/pci/pci_host.h" diff --git a/hw/pci-host/dino.c b/hw/pci-host/dino.c index f257c24e64..e8eaebca54 100644 --- a/hw/pci-host/dino.c +++ b/hw/pci-host/dino.c @@ -15,7 +15,7 @@ #include "qemu/units.h" #include "qapi/error.h" #include "hw/irq.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/pci/pci_bus.h" #include "hw/qdev-properties.h" #include "hw/pci-host/dino.h" diff --git a/hw/pci-host/grackle.c b/hw/pci-host/grackle.c index 95945ac0f4..8cf318cb80 100644 --- a/hw/pci-host/grackle.c +++ b/hw/pci-host/grackle.c @@ -25,7 +25,7 @@ #include "qemu/osdep.h" #include "hw/qdev-properties.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/irq.h" #include "qapi/error.h" #include "qemu/module.h" diff --git a/hw/pci-host/mv64361.c b/hw/pci-host/mv64361.c index cc9c4d6d3b..015b92bd5f 100644 --- a/hw/pci-host/mv64361.c +++ b/hw/pci-host/mv64361.c @@ -13,7 +13,7 @@ #include "qapi/error.h" #include "hw/hw.h" #include "hw/sysbus.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/pci/pci_host.h" #include "hw/irq.h" #include "hw/intc/i8259.h" diff --git a/hw/pci-host/ppce500.c b/hw/pci-host/ppce500.c index 89c1b53dd7..568849e930 100644 --- a/hw/pci-host/ppce500.c +++ b/hw/pci-host/ppce500.c @@ -19,7 +19,7 @@ #include "hw/ppc/e500-ccsr.h" #include "hw/qdev-properties.h" #include "migration/vmstate.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/pci/pci_host.h" #include "qemu/bswap.h" #include "qemu/module.h" diff --git a/hw/pci-host/raven.c b/hw/pci-host/raven.c index 7a105e4a63..2c96ddf8fe 100644 --- a/hw/pci-host/raven.c +++ b/hw/pci-host/raven.c @@ -28,7 +28,7 @@ #include "qemu/units.h" #include "qemu/log.h" #include "qapi/error.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/pci/pci_bus.h" #include "hw/pci/pci_host.h" #include "hw/qdev-properties.h" diff --git a/hw/pci-host/sh_pci.c b/hw/pci-host/sh_pci.c index 719d6ca2a6..77e7bbc65f 100644 --- a/hw/pci-host/sh_pci.c +++ b/hw/pci-host/sh_pci.c @@ -26,7 +26,7 @@ #include "hw/sysbus.h" #include "hw/sh4/sh.h" #include "hw/irq.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/pci/pci_host.h" #include "qemu/bswap.h" #include "qemu/module.h" diff --git a/hw/pci-host/uninorth.c b/hw/pci-host/uninorth.c index 8396c91d59..e3abe3c0f9 100644 --- a/hw/pci-host/uninorth.c +++ b/hw/pci-host/uninorth.c @@ -26,7 +26,7 @@ #include "hw/irq.h" #include "hw/qdev-properties.h" #include "qemu/module.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/pci/pci_host.h" #include "hw/pci-host/uninorth.h" #include "trace.h" diff --git a/hw/pci-host/versatile.c b/hw/pci-host/versatile.c index f66384fa02..0d50ea4cc0 100644 --- a/hw/pci-host/versatile.c +++ b/hw/pci-host/versatile.c @@ -12,7 +12,7 @@ #include "hw/sysbus.h" #include "migration/vmstate.h" #include "hw/irq.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/pci/pci_bus.h" #include "hw/pci/pci_host.h" #include "hw/qdev-properties.h" diff --git a/hw/pci/pci-hmp-cmds.c b/hw/pci/pci-hmp-cmds.c index fb7591d6ab..b09fce9377 100644 --- a/hw/pci/pci-hmp-cmds.c +++ b/hw/pci/pci-hmp-cmds.c @@ -15,6 +15,7 @@ #include "qemu/osdep.h" #include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "monitor/hmp.h" #include "monitor/monitor.h" #include "pci-internal.h" diff --git a/hw/pci/pcie_host.c b/hw/pci/pcie_host.c index 5abbe83220..3717e1a086 100644 --- a/hw/pci/pcie_host.c +++ b/hw/pci/pcie_host.c @@ -20,7 +20,7 @@ */ #include "qemu/osdep.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/pci/pcie_host.h" #include "qemu/module.h" diff --git a/hw/pci/pcie_sriov.c b/hw/pci/pcie_sriov.c index 8e3faf1f59..f0bd72e069 100644 --- a/hw/pci/pcie_sriov.c +++ b/hw/pci/pcie_sriov.c @@ -11,7 +11,7 @@ */ #include "qemu/osdep.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/pci/pcie.h" #include "hw/pci/pci_bus.h" #include "hw/qdev-properties.h" diff --git a/hw/pci/slotid_cap.c b/hw/pci/slotid_cap.c index 36d021b4a6..8372d05d9e 100644 --- a/hw/pci/slotid_cap.c +++ b/hw/pci/slotid_cap.c @@ -1,6 +1,6 @@ #include "qemu/osdep.h" #include "hw/pci/slotid_cap.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "qemu/error-report.h" #include "qapi/error.h" diff --git a/hw/ppc/ppc440_pcix.c b/hw/ppc/ppc440_pcix.c index 788d25514a..f10f93c533 100644 --- a/hw/ppc/ppc440_pcix.c +++ b/hw/ppc/ppc440_pcix.c @@ -26,7 +26,7 @@ #include "hw/irq.h" #include "hw/ppc/ppc.h" #include "hw/ppc/ppc4xx.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/pci/pci_host.h" #include "trace.h" #include "qom/object.h" diff --git a/hw/ppc/ppc4xx_pci.c b/hw/ppc/ppc4xx_pci.c index 8642b96455..1d4a50fa7c 100644 --- a/hw/ppc/ppc4xx_pci.c +++ b/hw/ppc/ppc4xx_pci.c @@ -29,7 +29,7 @@ #include "migration/vmstate.h" #include "qemu/module.h" #include "sysemu/reset.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/pci/pci_host.h" #include "trace.h" #include "qom/object.h" diff --git a/hw/ppc/spapr_pci_vfio.c b/hw/ppc/spapr_pci_vfio.c index 2a76b4e0b5..d8aeee0b7e 100644 --- a/hw/ppc/spapr_pci_vfio.c +++ b/hw/ppc/spapr_pci_vfio.c @@ -22,6 +22,7 @@ #include "hw/ppc/spapr.h" #include "hw/pci-host/spapr.h" #include "hw/pci/msix.h" +#include "hw/pci/pci_device.h" #include "hw/vfio/vfio.h" #include "qemu/error-report.h" diff --git a/hw/rdma/rdma_utils.c b/hw/rdma/rdma_utils.c index 77008552f4..c948baf052 100644 --- a/hw/rdma/rdma_utils.c +++ b/hw/rdma/rdma_utils.c @@ -14,7 +14,7 @@ */ #include "qemu/osdep.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "trace.h" #include "rdma_utils.h" diff --git a/hw/s390x/s390-pci-inst.c b/hw/s390x/s390-pci-inst.c index 9abe95130c..69137e0757 100644 --- a/hw/s390x/s390-pci-inst.c +++ b/hw/s390x/s390-pci-inst.c @@ -16,6 +16,7 @@ #include "exec/memory-internal.h" #include "qemu/error-report.h" #include "sysemu/hw_accel.h" +#include "hw/pci/pci_device.h" #include "hw/s390x/s390-pci-inst.h" #include "hw/s390x/s390-pci-bus.h" #include "hw/s390x/s390-pci-kvm.h" diff --git a/hw/scsi/esp-pci.c b/hw/scsi/esp-pci.c index 1792f84cea..2f7f11e70b 100644 --- a/hw/scsi/esp-pci.c +++ b/hw/scsi/esp-pci.c @@ -24,7 +24,7 @@ */ #include "qemu/osdep.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/irq.h" #include "hw/nvram/eeprom93xx.h" #include "hw/scsi/esp.h" diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c index 50979640c3..af93557a9a 100644 --- a/hw/scsi/lsi53c895a.c +++ b/hw/scsi/lsi53c895a.c @@ -16,7 +16,7 @@ #include "qemu/osdep.h" #include "hw/irq.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/scsi/scsi.h" #include "migration/vmstate.h" #include "sysemu/dma.h" diff --git a/hw/smbios/smbios.c b/hw/smbios/smbios.c index b4243de735..4869566cf5 100644 --- a/hw/smbios/smbios.c +++ b/hw/smbios/smbios.c @@ -28,6 +28,7 @@ #include "hw/loader.h" #include "hw/boards.h" #include "hw/pci/pci_bus.h" +#include "hw/pci/pci_device.h" #include "smbios_build.h" /* legacy structures and constants for <= 2.0 machines */ diff --git a/hw/usb/hcd-ohci-pci.c b/hw/usb/hcd-ohci-pci.c index 8e1146b862..6b630d35a7 100644 --- a/hw/usb/hcd-ohci-pci.c +++ b/hw/usb/hcd-ohci-pci.c @@ -23,7 +23,7 @@ #include "qemu/timer.h" #include "hw/usb.h" #include "migration/vmstate.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/sysbus.h" #include "hw/qdev-dma.h" #include "hw/qdev-properties.h" diff --git a/hw/watchdog/wdt_i6300esb.c b/hw/watchdog/wdt_i6300esb.c index 5693ec6a09..54c167cd35 100644 --- a/hw/watchdog/wdt_i6300esb.c +++ b/hw/watchdog/wdt_i6300esb.c @@ -24,7 +24,7 @@ #include "qemu/module.h" #include "qemu/timer.h" #include "sysemu/watchdog.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "migration/vmstate.h" #include "qom/object.h" diff --git a/tests/qtest/fuzz/generic_fuzz.c b/tests/qtest/fuzz/generic_fuzz.c index afc1d20355..7326f6840b 100644 --- a/tests/qtest/fuzz/generic_fuzz.c +++ b/tests/qtest/fuzz/generic_fuzz.c @@ -24,6 +24,7 @@ #include "exec/ramblock.h" #include "hw/qdev-core.h" #include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/boards.h" #include "generic_fuzz_configs.h" #include "hw/mem/sparse-mem.h" diff --git a/ui/util.c b/ui/util.c index 907d60e032..d54bbb74fb 100644 --- a/ui/util.c +++ b/ui/util.c @@ -17,7 +17,7 @@ #include "qemu/osdep.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_device.h" #include "hw/pci/pci_bus.h" #include "qapi/error.h" #include "ui/console.h" -- MST From xen-devel-bounces@lists.xenproject.org Thu Jan 05 09:21:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 09:21:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471763.731744 (Exim 4.92) (envelope-from ) id 1pDMRP-0002ii-72; Thu, 05 Jan 2023 09:21:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471763.731744; Thu, 05 Jan 2023 09:21:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDMRP-0002ib-3a; Thu, 05 Jan 2023 09:21:39 +0000 Received: by outflank-mailman (input) for mailman id 471763; Thu, 05 Jan 2023 09:21:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDMRM-0002iT-Uw for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 09:21:37 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 59059493-8cda-11ed-91b6-6bf2151ebd3b; Thu, 05 Jan 2023 10:21:35 +0100 (CET) Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-43-VgtQ5RWpOqOlpYBu-NTB8Q-1; Thu, 05 Jan 2023 04:21:32 -0500 Received: by mail-wm1-f70.google.com with SMTP id fm25-20020a05600c0c1900b003d9702a11e5so17818777wmb.0 for ; Thu, 05 Jan 2023 01:21:32 -0800 (PST) Received: from redhat.com ([2.52.151.85]) by smtp.gmail.com with ESMTPSA id p7-20020a05600c1d8700b003cf4eac8e80sm2044043wms.23.2023.01.05.01.21.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Jan 2023 01:21:30 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 59059493-8cda-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672910494; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WvJnFbsqNB85Ex5Jy9JWOBFwO+5P6BtsVC31mbY8Jko=; b=hglsu2slg4MnTDYTUy47wghObtzBvyy0Sz0A7flJqHBc5WfEWYsRk65a/7aSGx6yL5k2Jt f0Grl/pHJ8YJl3NHF1vJTcRX3+W7BoGwMBbnY8EaLQTsRxOHt9MzTKX/vC09kXbZ2trMf1 XGsLUKtVK/MOjjiUXdj3/abKlOSzkqU= X-MC-Unique: VgtQ5RWpOqOlpYBu-NTB8Q-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WvJnFbsqNB85Ex5Jy9JWOBFwO+5P6BtsVC31mbY8Jko=; b=I3r1yIlneraGv1ZM1ZfhOo1nQI8KthQbM62LKQFt2ytgN44yEh30phFZMck7v1ZBwb uEQ7BKG6bCvhpxmxf+kEz+2kmlNm9YQO4xIZuK9RBCktTkgKpJfFpuz4aF0KJL0gQdF8 x8eIfPTQhOeDX3r8Xlcx+1t2EVqblguIMBTCsy1aFgfvKxZxAZOUzyHhb0x6AoUZnCiK TjbBTnfXRlAoMh18ZqWN8SkP9E3WtvvdYRQYrsNJHKn3k+b3O36aErjNkvyiz0H5M8J4 Qh8KttUDjvQcSt3I9SvnPK5moul3jYkzM/+CWFWi3o2KPxBrX1VtvTKc9ZDkaLxiH6vO tGAQ== X-Gm-Message-State: AFqh2kpiEnk7eUxPF2EuCjn5tPULH35C9SjveQr63cEeX9W6+mjvTg27 /z/R3O67Tkr3VqhLdkLRNqxeQNsAM4ER6g36AZNhzzhu4bIvX2RE/UyieCAqKDY3KOBrO0yy8dW lHdeKSPvVSRTU6s9cJdqQlC70UAQ= X-Received: by 2002:a05:600c:1c21:b0:3d2:2043:9cb7 with SMTP id j33-20020a05600c1c2100b003d220439cb7mr34918982wms.5.1672910491475; Thu, 05 Jan 2023 01:21:31 -0800 (PST) X-Google-Smtp-Source: AMrXdXtLDlc36VB/aXU7Q2yc/oSic44vXngqutQ8bJreyz+6azTWmcavTASW5ywJO485dZiUmBNxkw== X-Received: by 2002:a05:600c:1c21:b0:3d2:2043:9cb7 with SMTP id j33-20020a05600c1c2100b003d220439cb7mr34918960wms.5.1672910491141; Thu, 05 Jan 2023 01:21:31 -0800 (PST) Date: Thu, 5 Jan 2023 04:21:26 -0500 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Cc: Peter Maydell , Markus Armbruster , Richard Henderson , Igor Mammedov , Ani Sinha , Paolo Bonzini , Eduardo Habkost , Marcel Apfelbaum , Yuval Shaia , Fam Zheng , Gerd Hoffmann , Stefano Stabellini , Anthony Perard , Paul Durrant , Ben Widawsky , Jonathan Cameron , Huacai Chen , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Jiaxun Yang , Andrey Smirnov , Xiaojuan Yang , Song Gao , =?utf-8?Q?C=C3=A9dric?= Le Goater , Paul Burton , Aleksandar Rikalo , xen-devel@lists.xenproject.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org Subject: [PULL 27/51] include/hw/pci: Break inclusion loop pci_bridge.h and cxl.h Message-ID: <20230105091310.263867-28-mst@redhat.com> References: <20230105091310.263867-1-mst@redhat.com> MIME-Version: 1.0 In-Reply-To: <20230105091310.263867-1-mst@redhat.com> X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline From: Markus Armbruster hw/pci/pci_bridge.h and hw/cxl/cxl.h include each other. Fortunately, breaking the loop is merely a matter of deleting unnecessary includes from headers, and adding them back in places where they are now missing. Signed-off-by: Markus Armbruster Message-Id: <20221222100330.380143-2-armbru@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/alpha/alpha_sys.h | 1 - hw/rdma/rdma_utils.h | 1 - hw/rdma/vmw/pvrdma.h | 1 - hw/usb/hcd-ehci.h | 1 - hw/xen/xen_pt.h | 1 - include/hw/cxl/cxl.h | 1 - include/hw/cxl/cxl_cdat.h | 1 + include/hw/cxl/cxl_device.h | 1 + include/hw/cxl/cxl_pci.h | 2 -- include/hw/i386/ich9.h | 4 ---- include/hw/i386/x86-iommu.h | 1 - include/hw/isa/vt82c686.h | 1 - include/hw/pci-host/designware.h | 3 --- include/hw/pci-host/i440fx.h | 2 +- include/hw/pci-host/ls7a.h | 2 -- include/hw/pci-host/pnv_phb3.h | 2 -- include/hw/pci-host/pnv_phb4.h | 3 +-- include/hw/pci-host/xilinx-pcie.h | 1 - include/hw/pci/pcie.h | 1 - include/hw/virtio/virtio-scsi.h | 1 - hw/alpha/pci.c | 1 + hw/alpha/typhoon.c | 2 +- hw/i386/acpi-build.c | 2 +- hw/pci-bridge/i82801b11.c | 2 +- hw/rdma/rdma_utils.c | 1 + hw/scsi/virtio-scsi.c | 1 + 26 files changed, 10 insertions(+), 30 deletions(-) diff --git a/hw/alpha/alpha_sys.h b/hw/alpha/alpha_sys.h index 2263e821da..a303c58438 100644 --- a/hw/alpha/alpha_sys.h +++ b/hw/alpha/alpha_sys.h @@ -5,7 +5,6 @@ #include "target/alpha/cpu-qom.h" #include "hw/pci/pci.h" -#include "hw/pci/pci_host.h" #include "hw/boards.h" #include "hw/intc/i8259.h" diff --git a/hw/rdma/rdma_utils.h b/hw/rdma/rdma_utils.h index 0c6414e7e0..54e4f56edd 100644 --- a/hw/rdma/rdma_utils.h +++ b/hw/rdma/rdma_utils.h @@ -18,7 +18,6 @@ #define RDMA_UTILS_H #include "qemu/error-report.h" -#include "hw/pci/pci.h" #include "sysemu/dma.h" #define rdma_error_report(fmt, ...) \ diff --git a/hw/rdma/vmw/pvrdma.h b/hw/rdma/vmw/pvrdma.h index d08965d3e2..0caf95ede8 100644 --- a/hw/rdma/vmw/pvrdma.h +++ b/hw/rdma/vmw/pvrdma.h @@ -18,7 +18,6 @@ #include "qemu/units.h" #include "qemu/notify.h" -#include "hw/pci/pci.h" #include "hw/pci/msix.h" #include "chardev/char-fe.h" #include "hw/net/vmxnet3_defs.h" diff --git a/hw/usb/hcd-ehci.h b/hw/usb/hcd-ehci.h index a173707d9b..4d4b2830b7 100644 --- a/hw/usb/hcd-ehci.h +++ b/hw/usb/hcd-ehci.h @@ -23,7 +23,6 @@ #include "sysemu/dma.h" #include "hw/pci/pci.h" #include "hw/sysbus.h" -#include "qom/object.h" #ifndef EHCI_DEBUG #define EHCI_DEBUG 0 diff --git a/hw/xen/xen_pt.h b/hw/xen/xen_pt.h index e7c4316a7d..cf10fc7bbf 100644 --- a/hw/xen/xen_pt.h +++ b/hw/xen/xen_pt.h @@ -2,7 +2,6 @@ #define XEN_PT_H #include "hw/xen/xen_common.h" -#include "hw/pci/pci.h" #include "xen-host-pci-device.h" #include "qom/object.h" diff --git a/include/hw/cxl/cxl.h b/include/hw/cxl/cxl.h index 38e0e271d5..5129557bee 100644 --- a/include/hw/cxl/cxl.h +++ b/include/hw/cxl/cxl.h @@ -13,7 +13,6 @@ #include "qapi/qapi-types-machine.h" #include "qapi/qapi-visit-machine.h" -#include "hw/pci/pci_bridge.h" #include "hw/pci/pci_host.h" #include "cxl_pci.h" #include "cxl_component.h" diff --git a/include/hw/cxl/cxl_cdat.h b/include/hw/cxl/cxl_cdat.h index e9eda00142..7f67638685 100644 --- a/include/hw/cxl/cxl_cdat.h +++ b/include/hw/cxl/cxl_cdat.h @@ -11,6 +11,7 @@ #define CXL_CDAT_H #include "hw/cxl/cxl_pci.h" +#include "hw/pci/pcie_doe.h" /* * Reference: diff --git a/include/hw/cxl/cxl_device.h b/include/hw/cxl/cxl_device.h index 449b0edfe9..fd475b947b 100644 --- a/include/hw/cxl/cxl_device.h +++ b/include/hw/cxl/cxl_device.h @@ -10,6 +10,7 @@ #ifndef CXL_DEVICE_H #define CXL_DEVICE_H +#include "hw/pci/pci.h" #include "hw/register.h" /* diff --git a/include/hw/cxl/cxl_pci.h b/include/hw/cxl/cxl_pci.h index 3cb79eca1e..aca14845ab 100644 --- a/include/hw/cxl/cxl_pci.h +++ b/include/hw/cxl/cxl_pci.h @@ -11,8 +11,6 @@ #define CXL_PCI_H #include "qemu/compiler.h" -#include "hw/pci/pci.h" -#include "hw/pci/pcie.h" #include "hw/cxl/cxl_cdat.h" #define CXL_VENDOR_ID 0x1e98 diff --git a/include/hw/i386/ich9.h b/include/hw/i386/ich9.h index 23ee8e371b..222781e8b9 100644 --- a/include/hw/i386/ich9.h +++ b/include/hw/i386/ich9.h @@ -5,12 +5,8 @@ #include "hw/sysbus.h" #include "hw/i386/pc.h" #include "hw/isa/apm.h" -#include "hw/pci/pci.h" -#include "hw/pci/pcie_host.h" -#include "hw/pci/pci_bridge.h" #include "hw/acpi/acpi.h" #include "hw/acpi/ich9.h" -#include "hw/pci/pci_bus.h" #include "qom/object.h" void ich9_lpc_set_irq(void *opaque, int irq_num, int level); diff --git a/include/hw/i386/x86-iommu.h b/include/hw/i386/x86-iommu.h index 7637edb430..8d8d53b18b 100644 --- a/include/hw/i386/x86-iommu.h +++ b/include/hw/i386/x86-iommu.h @@ -21,7 +21,6 @@ #define HW_I386_X86_IOMMU_H #include "hw/sysbus.h" -#include "hw/pci/pci.h" #include "hw/pci/msi.h" #include "qom/object.h" diff --git a/include/hw/isa/vt82c686.h b/include/hw/isa/vt82c686.h index eaa07881c5..e273cd38dc 100644 --- a/include/hw/isa/vt82c686.h +++ b/include/hw/isa/vt82c686.h @@ -1,7 +1,6 @@ #ifndef HW_VT82C686_H #define HW_VT82C686_H -#include "hw/pci/pci.h" #define TYPE_VT82C686B_ISA "vt82c686b-isa" #define TYPE_VT82C686B_USB_UHCI "vt82c686b-usb-uhci" diff --git a/include/hw/pci-host/designware.h b/include/hw/pci-host/designware.h index 6d9b51ae67..908f3d946b 100644 --- a/include/hw/pci-host/designware.h +++ b/include/hw/pci-host/designware.h @@ -22,9 +22,6 @@ #define DESIGNWARE_H #include "hw/sysbus.h" -#include "hw/pci/pci.h" -#include "hw/pci/pci_bus.h" -#include "hw/pci/pcie_host.h" #include "hw/pci/pci_bridge.h" #include "qom/object.h" diff --git a/include/hw/pci-host/i440fx.h b/include/hw/pci-host/i440fx.h index d02bf1ed6b..fc93e22732 100644 --- a/include/hw/pci-host/i440fx.h +++ b/include/hw/pci-host/i440fx.h @@ -11,7 +11,7 @@ #ifndef HW_PCI_I440FX_H #define HW_PCI_I440FX_H -#include "hw/pci/pci_bus.h" +#include "hw/pci/pci.h" #include "hw/pci-host/pam.h" #include "qom/object.h" diff --git a/include/hw/pci-host/ls7a.h b/include/hw/pci-host/ls7a.h index df7fa55a30..b27db8e2ca 100644 --- a/include/hw/pci-host/ls7a.h +++ b/include/hw/pci-host/ls7a.h @@ -8,8 +8,6 @@ #ifndef HW_LS7A_H #define HW_LS7A_H -#include "hw/pci/pci.h" -#include "hw/pci/pcie_host.h" #include "hw/pci-host/pam.h" #include "qemu/units.h" #include "qemu/range.h" diff --git a/include/hw/pci-host/pnv_phb3.h b/include/hw/pci-host/pnv_phb3.h index 4854f6d2f6..f791ebda9b 100644 --- a/include/hw/pci-host/pnv_phb3.h +++ b/include/hw/pci-host/pnv_phb3.h @@ -10,8 +10,6 @@ #ifndef PCI_HOST_PNV_PHB3_H #define PCI_HOST_PNV_PHB3_H -#include "hw/pci/pcie_host.h" -#include "hw/pci/pcie_port.h" #include "hw/ppc/xics.h" #include "qom/object.h" #include "hw/pci-host/pnv_phb.h" diff --git a/include/hw/pci-host/pnv_phb4.h b/include/hw/pci-host/pnv_phb4.h index 50d4faa001..d9cea3f952 100644 --- a/include/hw/pci-host/pnv_phb4.h +++ b/include/hw/pci-host/pnv_phb4.h @@ -10,8 +10,7 @@ #ifndef PCI_HOST_PNV_PHB4_H #define PCI_HOST_PNV_PHB4_H -#include "hw/pci/pcie_host.h" -#include "hw/pci/pcie_port.h" +#include "hw/pci/pci_bus.h" #include "hw/ppc/xive.h" #include "qom/object.h" diff --git a/include/hw/pci-host/xilinx-pcie.h b/include/hw/pci-host/xilinx-pcie.h index 89be88d87f..e1b3c1c280 100644 --- a/include/hw/pci-host/xilinx-pcie.h +++ b/include/hw/pci-host/xilinx-pcie.h @@ -21,7 +21,6 @@ #define HW_XILINX_PCIE_H #include "hw/sysbus.h" -#include "hw/pci/pci.h" #include "hw/pci/pci_bridge.h" #include "hw/pci/pcie_host.h" #include "qom/object.h" diff --git a/include/hw/pci/pcie.h b/include/hw/pci/pcie.h index 698d3de851..798a262a0a 100644 --- a/include/hw/pci/pcie.h +++ b/include/hw/pci/pcie.h @@ -26,7 +26,6 @@ #include "hw/pci/pcie_aer.h" #include "hw/pci/pcie_sriov.h" #include "hw/hotplug.h" -#include "hw/pci/pcie_doe.h" typedef enum { /* for attention and power indicator */ diff --git a/include/hw/virtio/virtio-scsi.h b/include/hw/virtio/virtio-scsi.h index a36aad9c86..37b75e15e3 100644 --- a/include/hw/virtio/virtio-scsi.h +++ b/include/hw/virtio/virtio-scsi.h @@ -20,7 +20,6 @@ #define VIRTIO_SCSI_SENSE_SIZE 0 #include "standard-headers/linux/virtio_scsi.h" #include "hw/virtio/virtio.h" -#include "hw/pci/pci.h" #include "hw/scsi/scsi.h" #include "chardev/char-fe.h" #include "sysemu/iothread.h" diff --git a/hw/alpha/pci.c b/hw/alpha/pci.c index 72251fcdf0..7c18297177 100644 --- a/hw/alpha/pci.c +++ b/hw/alpha/pci.c @@ -7,6 +7,7 @@ */ #include "qemu/osdep.h" +#include "hw/pci/pci_host.h" #include "alpha_sys.h" #include "qemu/log.h" #include "trace.h" diff --git a/hw/alpha/typhoon.c b/hw/alpha/typhoon.c index bd39c8ca86..49a80550c5 100644 --- a/hw/alpha/typhoon.c +++ b/hw/alpha/typhoon.c @@ -10,10 +10,10 @@ #include "qemu/module.h" #include "qemu/units.h" #include "qapi/error.h" +#include "hw/pci/pci_host.h" #include "cpu.h" #include "hw/irq.h" #include "alpha_sys.h" -#include "qom/object.h" #define TYPE_TYPHOON_PCI_HOST_BRIDGE "typhoon-pcihost" diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index aa15b11cde..127c4e2d50 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -27,7 +27,7 @@ #include "acpi-common.h" #include "qemu/bitmap.h" #include "qemu/error-report.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_bridge.h" #include "hw/cxl/cxl.h" #include "hw/core/cpu.h" #include "target/i386/cpu.h" diff --git a/hw/pci-bridge/i82801b11.c b/hw/pci-bridge/i82801b11.c index d9f224818b..f3b4a14611 100644 --- a/hw/pci-bridge/i82801b11.c +++ b/hw/pci-bridge/i82801b11.c @@ -42,7 +42,7 @@ */ #include "qemu/osdep.h" -#include "hw/pci/pci.h" +#include "hw/pci/pci_bridge.h" #include "migration/vmstate.h" #include "qemu/module.h" #include "hw/i386/ich9.h" diff --git a/hw/rdma/rdma_utils.c b/hw/rdma/rdma_utils.c index 5a7ef63ad2..77008552f4 100644 --- a/hw/rdma/rdma_utils.c +++ b/hw/rdma/rdma_utils.c @@ -14,6 +14,7 @@ */ #include "qemu/osdep.h" +#include "hw/pci/pci.h" #include "trace.h" #include "rdma_utils.h" diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c index 6f6e2e32ba..2b649ca976 100644 --- a/hw/scsi/virtio-scsi.c +++ b/hw/scsi/virtio-scsi.c @@ -22,6 +22,7 @@ #include "qemu/iov.h" #include "qemu/module.h" #include "sysemu/block-backend.h" +#include "sysemu/dma.h" #include "hw/qdev-properties.h" #include "hw/scsi/scsi.h" #include "scsi/constants.h" -- MST From xen-devel-bounces@lists.xenproject.org Thu Jan 05 09:26:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 09:26:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471770.731755 (Exim 4.92) (envelope-from ) id 1pDMW6-0003Lt-PS; Thu, 05 Jan 2023 09:26:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471770.731755; Thu, 05 Jan 2023 09:26:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDMW6-0003Lm-MU; Thu, 05 Jan 2023 09:26:30 +0000 Received: by outflank-mailman (input) for mailman id 471770; Thu, 05 Jan 2023 09:26:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDMW5-0003Lg-Q0 for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 09:26:29 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDMW3-0005OB-JW; Thu, 05 Jan 2023 09:26:27 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=[192.168.4.62]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pDMW3-0007Rl-Cp; Thu, 05 Jan 2023 09:26:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=PEBC+UaIwLwZGAnFM0C127VFp32FpIJgDVgumc8M6K8=; b=UgaFoxdDnHb1LiRcDtwU/6apht o9f37caHdBmW9GMG+4+7I+FHY7bkxNmxdQyenIePj9utCd00Jdr3Z1YZGfACn4L7/ppvQZYOQCyxe ofy0Z6VzJCTCQ0jaBN5tPeR5S1bdSZDzBQLG+QXBC0i6R2ZX8eGOl65Spc5zPzfsucgw=; Message-ID: <1264e5cc-1960-95d3-5ecb-d6f23d194aa4@xen.org> Date: Thu, 5 Jan 2023 09:26:25 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2] xen/arm: Add 0x prefix when printing memory size in construct_domU Content-Language: en-US To: Stefano Stabellini , Michal Orzel Cc: xen-devel@lists.xenproject.org, Bertrand Marquis , Volodymyr Babchuk References: <20230103102519.26224-1-michal.orzel@amd.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Stefano, On 04/01/2023 23:47, Stefano Stabellini wrote: > On Tue, 3 Jan 2023, Michal Orzel wrote: >> Printing memory size in hex without 0x prefix can be misleading, so >> add it. Also, take the opportunity to adhere to 80 chars line length >> limit by moving the printk arguments to the next line. >> >> Signed-off-by: Michal Orzel >> --- >> Changes in v2: >> - was: "Print memory size in decimal in construct_domU" >> - stick to hex but add a 0x prefix >> - adhere to 80 chars line length limit > > Honestly I prefer decimal but also hex is fine. decimal is perfect for very small values, but as we print the amount in KB it will become a big mess. Here some examples (decimal first, then hexadecimal): 512MB: 524288 vs 0x80000 555MB: 568320 vs 0x8ac00 1GB: 1048576 vs 0x100000 512GB: 536870912 vs 0x20000000 1TB: 1073741824 vs 0x40000000 For power of two values, you might be able to find your way with decimal. It is more difficult for non power of two unless you have a calculator in hand. The other option I suggested in v1 is to print the amount in KB/GB/MB. Would that be better? That said, to be honest, I am not entirely sure why we are actually printing in KB. It would seems strange that someone would create a guest with memory not aligned to 1MB. So I would consider to check the size is 1MB-aligned and then print the value in KB. This will remove one order of magnitude and make the value more readable in decimal. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Jan 05 10:00:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 10:00:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471777.731765 (Exim 4.92) (envelope-from ) id 1pDN2V-0006lt-8F; Thu, 05 Jan 2023 09:59:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471777.731765; Thu, 05 Jan 2023 09:59:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDN2V-0006lm-5O; Thu, 05 Jan 2023 09:59:59 +0000 Received: by outflank-mailman (input) for mailman id 471777; Thu, 05 Jan 2023 09:59:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDN2U-0006lg-12 for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 09:59:58 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b39c3a16-8cdf-11ed-b8d0-410ff93cb8f0; Thu, 05 Jan 2023 10:59:54 +0100 (CET) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by PH0PR12MB7981.namprd12.prod.outlook.com (2603:10b6:510:26c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 09:59:52 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::9856:da7:1ff1:d55c]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::9856:da7:1ff1:d55c%5]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 09:59:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b39c3a16-8cdf-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nsVTOw4vHJEFa7Uz+G6Nx/OkRvX/htpyZ2C4dcMKZcw9w1hhcg2h9T0X1D5FyOcHtlzmepZY0y4XFNepiTfg4zzppTdO3zcw2MO7XqklyH6XFbdAHqAQq8TpJAsPSjf39pL6YnbVAJIaR/kJwzPOjXRmYERBbdC4azJoAs7eavbWEnZLcWFTj//ShRPtdHMWaKXBxZ30mhd8WmVaeUYEr7fQOBEfxUFzcOIg6WEPFrPUQVXYFR0dQtVcHSEe90wMbnANEyMMsJ+4bmdC4p7ZInd6W1P2myAT/W5qH+t+GsgjxU9o3zqFnk0dk1VJ6gGN8PeoWvrKu8XAOcyIz3nYfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Jlfi8Xu69UjMjxtpqFoHVECk8dVZwxh51RO7VwTAM48=; b=TLmNfUTQuLWX7EhxfwEH95orLp/iaAY7w0apawK0ZkdQh68PX2GPdATL9swzssEmKpxg/snldHvv/Xrw1I9kdhL3hOh9pzmS5U04kPj+Zz1rWeEK16qgKmEssMwasZ+hSr53KvfGL1Gbv5bKrfQNiU1Cp+3FvSLg6ry/90JUoSNTQrvCQbOz+0pW/HtFFZIc9234gSUxcw1cxTobWpiA/5SrsN7rDjUMH3Ip2y+FAN16kR7HT2G6DlPHL6gyObW9ssFSYajsTVWTgCx3DD4dsgcITxTfAWGMxsCongdXDpnAF145p3mTgHyCpKu+zS5SiHhXVjd0WjEdFJrFZHQLzA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Jlfi8Xu69UjMjxtpqFoHVECk8dVZwxh51RO7VwTAM48=; b=pVEqIUntoznkKqsbVSPlQVsaOhdUA6SKcecfwgvt79X65QsBpUf0YLqHJiYhKocOfKGF/g6vt79uBRAJ1n70N9V+R1RrgtvJlPM6kjOYJsc/4ltyQZrILqj0Tdh9hA9O3DGp8EGJexy8tHOXJCFqb62wvrR4/5x9fi7azgSvzAE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <29460d07-cd43-7415-7125-6ed01f3c2920@amd.com> Date: Thu, 5 Jan 2023 09:59:47 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2] xen/arm: Add 0x prefix when printing memory size in construct_domU To: xen-devel@lists.xenproject.org References: <20230103102519.26224-1-michal.orzel@amd.com> <1264e5cc-1960-95d3-5ecb-d6f23d194aa4@xen.org> From: Ayan Kumar Halder In-Reply-To: <1264e5cc-1960-95d3-5ecb-d6f23d194aa4@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO6P265CA0027.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ff::13) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|PH0PR12MB7981:EE_ X-MS-Office365-Filtering-Correlation-Id: 60671af0-5172-4eef-b952-08daef0396fc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: U4+Gu5nLXaIGuEav96iRWDJwNL5AQ9JLlm/T5mCm5Yli8ZdDtzRvmr5y2YY4RHE0SrFSaSnB9pkDusHlxe6vMQ+aFJ5WhAsW8xLFfrW3WVQE1RAYSjndSOTaN4c6SWFsOYMYIi1B8FsrCr5IEyr3V74+U+Mhp4ujQo1KpqqIEoseexUl8EDVtm6qRkG8OjVzkYNpWYardoYr7+ueY3u1HWDGh/0BgeB6B2BVnKyxnVRjmrZfflwlpp4IBWVeK0G3l+iDSBrTUFVMV9DtHxlKB3hpFltJ5CHez/o9gvA1s9g7zgGLT+jc30dlRmwZVBaRLhrVQt4l4ZnOWJY53Vz0+BcVGW4lrz/I7SPpHAa/h2+SfwOu14R/rwCBDlif1sn4+bAT4wCuYkYwaQ77182+ISQYlant9HijqzhuzGmW7s9B3Zm2eKXkbwwlVJyWYCtY+Tp7sgyjQoZtR3PNvKckrFbCglVDAHItddMPgUDIwMQLAkjifyMSTVuRS/BaPXSJ9+81hAylqQHm+1aIoRHhGnltUe5ESI24QnunluqMQ2dtUGHkEKRi3KU++U9KkQvSOtYAPjKC1heBa/+UdcBD52a9OYkfCuchxbIqJ42P8FBGNwgt0jSx9QiOaIcExnqBClnGgvdLk6+8O+ZiXvIjv2tlzUP0meRdd7yfFjJfkGT2IcFyyWiNDXygCo7iYsGmcDPnN0Zs3EUZRw6e6I4ETq9C3Ousf4ibji32yLB0KDk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(39860400002)(366004)(396003)(376002)(451199015)(53546011)(66476007)(66946007)(66556008)(41300700001)(6666004)(6506007)(8676002)(316002)(2906002)(6916009)(26005)(31696002)(186003)(31686004)(83380400001)(478600001)(6486002)(6512007)(38100700002)(8936002)(36756003)(5660300002)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SmlqNnVsZXYrSnBEcTdjdzV1VE45TlpwRW1PanBVd3liekV2Rm9aWmJuVitS?= =?utf-8?B?LzNhbjBXR1ZSNVFKNGVsTC9yT1lqck5YcTZUb2toenhrbURON3FLUDNZUEkz?= =?utf-8?B?YWtlN3Vjd0dNQlM1L0p6S2Yzd2pHa1IxS0JWWWpGMDFDZ2t1aDFoa2tVODU0?= =?utf-8?B?TXVDSEdSbmVXWHRZcy83czdjNXllV3pPUlpVMTVRdllEc1BGbzVPYTl0S1JZ?= =?utf-8?B?OFA5SjNrTTBncDBWVThQZ1B1Z1BzdEhvTUlQNnZQSDVsL2dtYzVVaENRdnNm?= =?utf-8?B?SVJxR28rZy95ZTJCdGE3eGY0Q01sTnhHOUkrZWFEZndBR3gzT3ZqR0t5bmVN?= =?utf-8?B?cTA3Skg2NmhPRzZDTlB4ZldqZ0hROTNyK0FuT00wdlFoMTEwc0F1MEpaSDRr?= =?utf-8?B?eW94SytBSFBmbXd2R1pXb2hPYzJ5bG5vMXdWWkJkOWJERXZldW14c1ZTV0ZG?= =?utf-8?B?R3JVMDk1c0hMc0pURnZHVWRZNUFkZldjRkNreG0zbUtSTGxhRWlkVm5VNmxW?= =?utf-8?B?dFB5MlNHYzVnVXZyMFp0eDc2OU5QUkVzeGZwQ0VSMGUrWnpmV3ZuTlltaXFk?= =?utf-8?B?dXhxb2J2N1BXTnpZQVlOOC9KMW9KWGpneVJwYnVVRDhRZU40K0xPSUIreVBj?= =?utf-8?B?NHorcml6ei9kOFpNRCsvZmlDSHZERUIvTy9UUHRYMFRXaitFL21mckdiWmlF?= =?utf-8?B?L0tQMzdqZXJ6ZzgwdEd0NWpVZ1NmYjBNc0FkVko3QTJLdlRXS2xVMnY0aDIv?= =?utf-8?B?NGdZdlN5cXRKOG9weDBqNUlCWkdWQnkwYTRVVC9Zd3hVUzBpd0ROcWxmSTho?= =?utf-8?B?YnpIVjJxNjVjZlZjMVUrZHhDYk55cm5VU0gwL3VldzlIV0pGditKK3B2RWtn?= =?utf-8?B?aUJ0Z3JENEQ3L2NtQ0tBZ2VOdTV2SmJvNGk4VURORms5QWhlYUk5S3dHaFh2?= =?utf-8?B?OGV1YlVyc25PR3NIOW1Ca290ZFkrTGRiSi93WjBxZXdkV08xaDZ2NGViRDFU?= =?utf-8?B?dEQvRmYyRTlwTlhBMFlFN1V2WVpydlNvTlBBUHJVeFFpbkhhSmVsOHlKNExt?= =?utf-8?B?Wk80T3lQSFp0N2pWbU9VM09JWk1mb3RBVUxWdml1M0RqNW96WTF4cko1MzNN?= =?utf-8?B?UkVoVSsxNFlVSHlwdlpjMmR2T0lxNmFDQlVMRVJBa28ySUE0TDZNN3k2bkI3?= =?utf-8?B?ZVdudHJxTGFJeksrWGk2MFdZa2lqaTRaN0hzMWl1NGdqbDVPM3pwV1ZsNEth?= =?utf-8?B?di9aMExzZzgzRE45d1BDZ0dFS0FBYTZLcHoyQ2pRbHhUbGRqZ2lOUjR6Q0RK?= =?utf-8?B?SVFNRUNXU1hVckoweUw4OTdjMldFa3FwTUFiOXFLbjZLWmJEN1l1QUhzNHdJ?= =?utf-8?B?TmpjUzE5VENRc3RPZUFZNXFmZXluQnIzR1ZrZXB1NFR1Uk9RNjlmLzVGckRr?= =?utf-8?B?dDdZemxGRlRCUzE3dk1QQTFXNzlWZHYwQUNsQTZSRmpKYU1Ta3RxS1FuRG51?= =?utf-8?B?Nm5NU2orazZXQnhxZENZL2oyQUtGeDIwYU56WWdIVGtsbkRHT0ptaCtDWmRG?= =?utf-8?B?dmNOcHhSeVBBTFBrWk5qdUtuOEpGemVNSjArL3NLZ1p5M1krbCtxYWVzZFk5?= =?utf-8?B?R21rQVlKWlY2U3V0aVNSdVZXeWJSNDRhNXFnRUhKUGRWekFNVkt3Si90aS9k?= =?utf-8?B?dmhYQm9jcTdseStSNHJRUU9BeU5aTWhSK1hSNTMwWXZCYUF3SUk1N1lseko4?= =?utf-8?B?dWl6M2VZT05qek9KRjF4bUpFbzJwWnhyb0dtNldYSitiMHZ1aFMwbUdDalQ3?= =?utf-8?B?b2N2SVp2NXhkWm9UWFB3dHFJVlhkemdJQnJNS0dhSGljUHJnQkRHeHkyc0VN?= =?utf-8?B?eU5QUUEyRks2dTIvK0ZJTjkvTE9MMDJnOURuSnVGclRlb1hpY1JzTkcvdDhS?= =?utf-8?B?MkZsQnJLSVg4TU5QTEdGWUdVV29KajVSa1FCbGxKTkcxeUlrWGpiemswQ0w5?= =?utf-8?B?TFQ2bEsxcU1YelFKalg1Z09admZuMkltYjhqUnpLZHQvdFdzR1Rkb1RvSFRJ?= =?utf-8?B?ODVyTWZLaHd1ZmU2Z0ZMVDUydTdISEdhSzdFRDk2ZUIrRVFZWkcxRGhwMXox?= =?utf-8?Q?zTPCD2FhxYdybkkSqlIXSZm15?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 60671af0-5172-4eef-b952-08daef0396fc X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2023 09:59:52.5462 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9nSbIm7CBpnYpx+Czi4GWGKvVAlPjD2pDf4SClN9Gfr6J7J7q68+CnrCCkNeRCvn1NdInQpTrZU/icojQKmVFg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB7981 Hi Julien, I have a clarification. On 05/01/2023 09:26, Julien Grall wrote: > CAUTION: This message has originated from an External Source. Please > use proper judgment and caution when opening attachments, clicking > links, or responding to this email. > > > Hi Stefano, > > On 04/01/2023 23:47, Stefano Stabellini wrote: >> On Tue, 3 Jan 2023, Michal Orzel wrote: >>> Printing memory size in hex without 0x prefix can be misleading, so >>> add it. Also, take the opportunity to adhere to 80 chars line length >>> limit by moving the printk arguments to the next line. >>> >>> Signed-off-by: Michal Orzel >>> --- >>> Changes in v2: >>>   - was: "Print memory size in decimal in construct_domU" >>>   - stick to hex but add a 0x prefix >>>   - adhere to 80 chars line length limit >> >> Honestly I prefer decimal but also hex is fine. > > decimal is perfect for very small values, but as we print the amount in > KB it will become a big mess. Here some examples (decimal first, then > hexadecimal): > >   512MB: 524288 vs 0x80000 >   555MB: 568320 vs 0x8ac00 >   1GB: 1048576 vs 0x100000 >   512GB: 536870912 vs 0x20000000 >   1TB: 1073741824 vs 0x40000000 > > For power of two values, you might be able to find your way with > decimal. It is more difficult for non power of two unless you have a > calculator in hand. > > The other option I suggested in v1 is to print the amount in KB/GB/MB. > Would that be better? > > That said, to be honest, I am not entirely sure why we are actually > printing in KB. It would seems strange that someone would create a guest > with memory not aligned to 1MB. For RTOS (Zephyr and FreeRTOS), it should be possible for guests to have memory less than 1 MB, isn't it ? - Ayan > > So I would consider to check the size is 1MB-aligned and then print the > value in KB. This will remove one order of magnitude and make the value > more readable in decimal. > > Cheers, > > -- > Julien Grall > From xen-devel-bounces@lists.xenproject.org Thu Jan 05 10:12:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 10:12:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471785.731777 (Exim 4.92) (envelope-from ) id 1pDNEL-0000sZ-Gy; Thu, 05 Jan 2023 10:12:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471785.731777; Thu, 05 Jan 2023 10:12:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDNEL-0000sS-Dc; Thu, 05 Jan 2023 10:12:13 +0000 Received: by outflank-mailman (input) for mailman id 471785; Thu, 05 Jan 2023 10:12:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDNEK-0000sM-5k for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 10:12:12 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on2059.outbound.protection.outlook.com [40.107.8.59]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6a31f8f5-8ce1-11ed-b8d0-410ff93cb8f0; Thu, 05 Jan 2023 11:12:10 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8359.eurprd04.prod.outlook.com (2603:10a6:20b:3b3::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 10:12:07 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 10:12:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6a31f8f5-8ce1-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZVLcHCyk2/JLnkCZGKicwOdU4frcid+8BrB5gWY7rJ1LPM5XcWK6Q7leASIKtRc22iSWjUL1iHL1jtGkk7d6+sxmxaFay5PHP+TN8R/W5vtzsmQ5VzeSv94jlr2N4qXNqAz5sh38V10HZwBTK2OG4NX/3n7JCVYxrkLVCWFjbwBl0uJKAqeGdzTujndXTB2GjIiOwCYf/Xl9Hw0CPF3CjuMFlJC4J1wwglSi1RzWQvfC8aEWbJad01I/Kr1EvkHOiMtKj3LSINHdHtr2fS35V+hc//kxBoS44Y9/uP9ovt6qnrkxi/YbZ07tNQ6e4do+Nghm1Z081BffOITlydYRUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1RJywEcRfnPvZxYe9Fm8SQ3wBZj+5X3Tbq3pifAWXgM=; b=QQ/6VforayYyTv8IJdLgKHVa2KiJ8zKZ5jeYzuB3kltOJKWwYDJIiVv6WNmE4f1HPvvWRRr/67m7q2GDBvDiSx2b0ZtztqAHOOYccVvK3ZVEEZDS1Z3VdXqpvR4KCfl6RZ6uj+9w/RyUblsdO/TLQauPEATJuznt0znvbOS4pGzi4CodCt327J2I1lamsP13xDcO9QypGR9na+0o9FUCBy//PUgM2Kc3igp6rAAscdCzaxG6PhRQSbIw7MqZGQ5YmTybYWebXixl+ufmiPvjnrT/DrOdL0DKtRsJrH8qprjcyEZhRWcXQkZlg63+8IXXdRtRJgKLmIWrGXvThLPKEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1RJywEcRfnPvZxYe9Fm8SQ3wBZj+5X3Tbq3pifAWXgM=; b=277lANii0BjzasAhf3UwxAut5Z5PpkkyQxpVz4d6XM/GOj2W9FZm5anliZxYvF3eqC7LXOFDiDHr/CqjBIg2x+7yb1Ks6vXYdvWlU0UoTlIg9Lzi2L8Ym/SdXKtDQqAIUd/nnM2xH0yAZg0s1S+WEL1unDUAuGD7135pHjU1XnqPi+nHLGHJhPnGTdI5j2LuoWb+cEwN87fVJBG3GkoQ7pO88HQPMsUmcEUMAKeAyw9ZX0sPX5XtP+lrRQmeNpnXvHlzYCMbLLF1QFUf63GRTr8A5DbzFR7WYsTNhhayVwqZnTyWUX7PPoVxl3SRPWIZdQRp5rFjt8YWBH1OPnBmxw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <15dd4897-d87b-9a0d-fc99-551a1b4be04d@suse.com> Date: Thu, 5 Jan 2023 11:12:06 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= From: Jan Beulich Subject: [PATCH v2] hvmloader: use memory type constants Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0031.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8359:EE_ X-MS-Office365-Filtering-Correlation-Id: 2ddca258-141c-4210-c54c-08daef054d46 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VIUCT+qyONgTkqH1UG8F1KO1P5AcgGQpMBOkQnuyCcpG2/2GERw67BsAZkAC6qDNi7LM8K4b5bSZSQiAlfxNnWRXq4kOBkj8jwxw/n0rLKT62uOmJ2T8OHiN35+U1h9Q+xaI2Is4MabKvHhwlbzjw0AMrYgTjMKmeDGqsmvCxk2pYLDrzWJQ1e60roW/kVNIjEDVs6ic+exwY9jvFWUNNDJ4KGsRwyjMuwJCRgBATpcz3aArX13Qk1gy1m1Raud4YFZJMbJeildIm2ivu+x3sf3OxZ7d99qos3Lpc2d6BePkNp3Dlg5FkLzZbiyPjZkWKGnTBC1MooJUDxRDmLNXfeYGN6azmN0EEtS6yenGCFxDYdkM1xguP1elPLFvfZeshj9OUArlTniOKE7ahVinxintzOgh0Z4VUkN04B5yMLG0I0MwTi1hA3aM+Tb3Na7uEjLr9vGbfVAHq5Q6bL+oMGNJogKvDh3x/ODnMVjU3JWwLEdwQXXWPht2CSY8uacNe9iuRGfBzpHhEPV4Wr3I5VxG5IL/rjhd/3zVedhMC4BnYX4wAYB6rYiOSEIuX602NYsgRtBNzRpOZmMHsw46vkigybs2zJTVTCZ7oNs+NrugklJd9ac0TX5L5XD3Tfuza7rhLs325OK3qB/Bv4babq0Yzr1CimKh9UklE3NXocgTZUnlD6j2gSYWKWH2MdCq3W796q+DC9XOyXohDcszJU7onSuDZIj7m7YfcVWFfUY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(346002)(376002)(39860400002)(396003)(366004)(451199015)(38100700002)(31696002)(316002)(54906003)(66946007)(6486002)(2906002)(66476007)(66556008)(5660300002)(8676002)(4326008)(6916009)(41300700001)(8936002)(2616005)(478600001)(186003)(6512007)(6506007)(26005)(86362001)(31686004)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cEp3dm40K0JuaGI0UHFrWUFqNGNQY05leFZKQ3U3TFRaL1hkMS91bllxUEY5?= =?utf-8?B?MExiOWdaTklTVDJDRkJ4TElvOVB2c1VhOG8rNDRyNVhjdURvVE80d3JoMlN6?= =?utf-8?B?MlBYdXNHRWJyOXlNMlE0ZEJjMC9rcXQxWUhmVG00dXhRR0NoM1FKSEdLUXBM?= =?utf-8?B?SUQ2cHIzbzBhMzJ6TlVWTFRRa3V6Z1p6UkpZU3JoQlJkN2NIaWdGQnlCZ0pE?= =?utf-8?B?MC9RSlc4N2dDTjBFMTFvSjVDMkNEd2R6OVlVQ0p6OEJ5Zk9BcjVUUkVUVGln?= =?utf-8?B?aXRjNThzZDlzZ3lzQ0orRXl6a1ptR2ZSdnVJaFErcU9ESVdSNWl1OFpHZzNT?= =?utf-8?B?TXAzSGs1UmtWRHhRcjRrbm1SRWM3T2NBTXFjZUV0cE9WU3NEUGhVekkzUHBS?= =?utf-8?B?ZnJyTEt3ekFMZlVVWVlyT1VscUV1QzBGd3hqc05JSlBWQTUwZmpuZC9OZHh3?= =?utf-8?B?eDlZZkFLbTU5RGx1eFJSRkltNVpFdDRaQmhRK1pMKzFyaVl3RWwwN3VIZ3JE?= =?utf-8?B?Uk01NjlNWFF3REltR1hWREVEem1aLzkxQlVpSjY0R3k5ZldJZVFoU1JzUkh1?= =?utf-8?B?bWZac0tQcjBxVFZhd2ZIbit6cVVPTlB4ek95RXp0S05VeGhRNTdvZktWZk5G?= =?utf-8?B?TFR3L1RQNmhCaTEvOElpZ25mWWtnVzRZSGlyWFFzbkJYUmxGZnMrVXdld1Rw?= =?utf-8?B?djIrQWs1VTVPTnZVRGc3cHlZb1d5S3B3KzByZENRdWFrZzk1SkxzZ0xuR1o5?= =?utf-8?B?Tjdjd1pUZ1hBNzcrUktRVmJIMU8xTTYvWDNJWmlXK2VxbkJNVlhtTEl5QUl3?= =?utf-8?B?SllDNUk2d3dyR2FyTElKYlQ0Zy9pd0ExMkxkRllDd3JZTFJETnR4dk84cHJv?= =?utf-8?B?NWZGdFJaSVh2SmZYVStZdlJ1Y296NmRISitESFd3U3RTZVlwQnk1K1pEdnlX?= =?utf-8?B?UW55WnVzUzIyb1UwNUJDcWUyNndWSkZCZFpCRnpKUW1rK0ZnVGZ1OHovNXJs?= =?utf-8?B?eTAzcVZWRnFHRGVpa0pLZU5sb25OQkpyMlBHZ01qTUIvZWoyMWM3cThsOE9Q?= =?utf-8?B?dFEvMUJsZXhWN01EaDY5cU8rVnBScXNmY2QwUVRhSXhJTVJsa3R0amdZNWNn?= =?utf-8?B?Y2hhS2pDL09wZjhjdkRVNm5NL0xkangrdmlwUFZ2bXg4WWREWUJUQWNud3JQ?= =?utf-8?B?TE5xK0JHWTRjdUJZQXEwQ245bDZnSHdvaWFXeVBRb0JmRnhLdDUzdjdTNUhi?= =?utf-8?B?OUdUUW9TTkh5WkVHQ2x1c21jODJFS3luM25KNlYrMzZpdjNVRFV4MUlsM1Zj?= =?utf-8?B?UERwcnJ4TGMvZnpMVWFpNExCZnZFM2dpa0lLUnBMRit1azRDei92L0hmTUdI?= =?utf-8?B?ZVlYaVE2bENrMXZXYnQzRDFDbmszbkE3dGo2SnV1djAzbktHSGhHUFhHeU0r?= =?utf-8?B?cXJLeERnSFkwRVI1dUFFQUk4VWt3WDZOUzcvc1JuRTFKUXZnRmcwaGpNbXFO?= =?utf-8?B?c2xWdWppRE5IeW5DWkhBS3RseG5TUDhpSml4WUdTWDRJRkRZTXJUWnNUc1BE?= =?utf-8?B?U1VyVTFIc0FKSGRjQlNQZ1ZtczFkaFlzSWs0aXFoM2JPcXdNOElOYnczR3Bv?= =?utf-8?B?QXJkakxHSzRoK3dBb3lJbHA5UVJsUGc0TWZEKzNBMG9PRFh4MXl6eDQ1Qkxp?= =?utf-8?B?ZHljc0hZNy9lZjBvMHRvVkNiYzA2bzErcjFnSGZaeUZ2aHNwYitoaEZ2SjBX?= =?utf-8?B?MUtnRFNHZ1dmY1oxeXBLbCtKME10VTVnZ1N0TUZ5N05WdlRqQTFVMEk2NDNS?= =?utf-8?B?bkU0Ry8zakdzQ0pRMS9hTDNUSGc5dDBncU1aZ0Z5ZkJldDJuQ0xRMllxLzVX?= =?utf-8?B?ek1qb0lHM3BMMmRwMER1UGlvTTkwRDVIMVpXUldWOVd1VUZ2ZEhYN05iUnJB?= =?utf-8?B?ZVlLTWtxMEFGcTJiUDVsOVdvTmNXMDhVRmFaODA2U1ZTR0xLZGJ5K2hhU29k?= =?utf-8?B?MDB3M1o5RFFhK1BZeDNjNjlXNEpUS0VuMTVpMGphb2tTRGRRZjlnQjdDZVZr?= =?utf-8?B?RmFsTUF0UDdGVnJ6MHlsR01Yekwyd1BNbXFGQ2xkNGpSOGEvS2RhaDVFVjR3?= =?utf-8?Q?YrJ8YMlic8RXz4pSvMwqsYLOI?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2ddca258-141c-4210-c54c-08daef054d46 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2023 10:12:07.8111 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6swL7whTXVbPMkhnwUbrgVPJ7C59HAo6O6DCuQBXYNFKyeQQ9OTDHVwE/62gEx/XZWd56PTQMiE6taXmq4FLFA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8359 Now that we have them available in a header which is okay to use from hvmloader sources, do away with respective literal numbers and silent assumptions. Signed-off-by: Jan Beulich --- v2: Use simpler BCST() macro. --- a/tools/firmware/hvmloader/cacheattr.c +++ b/tools/firmware/hvmloader/cacheattr.c @@ -22,6 +22,8 @@ #include "util.h" #include "config.h" +#include + #define MSR_MTRRphysBase(reg) (0x200 + 2 * (reg)) #define MSR_MTRRphysMask(reg) (0x200 + 2 * (reg) + 1) #define MSR_MTRRcap 0x00fe @@ -71,23 +73,28 @@ void cacheattr_init(void) addr_mask = ((1ull << phys_bits) - 1) & ~((1ull << 12) - 1); mtrr_cap = rdmsr(MSR_MTRRcap); - mtrr_def = (1u << 11) | 6; /* E, default type WB */ + mtrr_def = (1u << 11) | X86_MT_WB; /* E, default type WB */ /* Fixed-range MTRRs supported? */ if ( mtrr_cap & (1u << 8) ) { +#define BCST(mt) ((mt) * 0x0101010101010101ULL) /* 0x00000-0x9ffff: Write Back (WB) */ - content = 0x0606060606060606ull; + content = BCST(X86_MT_WB); wrmsr(MSR_MTRRfix64K_00000, content); wrmsr(MSR_MTRRfix16K_80000, content); + /* 0xa0000-0xbffff: Write Combining (WC) */ if ( mtrr_cap & (1u << 10) ) /* WC supported? */ - content = 0x0101010101010101ull; + content = BCST(X86_MT_WC); wrmsr(MSR_MTRRfix16K_A0000, content); + /* 0xc0000-0xfffff: Write Back (WB) */ - content = 0x0606060606060606ull; + content = BCST(X86_MT_WB); for ( i = 0; i < 8; i++ ) wrmsr(MSR_MTRRfix4K_C0000 + i, content); +#undef BCST + mtrr_def |= 1u << 10; /* FE */ printf("fixed MTRRs ... "); } @@ -106,7 +113,7 @@ void cacheattr_init(void) while ( ((base + size) < base) || ((base + size) > pci_mem_end) ) size >>= 1; - wrmsr(MSR_MTRRphysBase(i), base); + wrmsr(MSR_MTRRphysBase(i), base | X86_MT_UC); wrmsr(MSR_MTRRphysMask(i), (~(size - 1) & addr_mask) | (1u << 11)); base += size; @@ -121,7 +128,7 @@ void cacheattr_init(void) while ( (base + size < base) || (base + size > pci_hi_mem_end) ) size >>= 1; - wrmsr(MSR_MTRRphysBase(i), base); + wrmsr(MSR_MTRRphysBase(i), base | X86_MT_UC); wrmsr(MSR_MTRRphysMask(i), (~(size - 1) & addr_mask) | (1u << 11)); base += size; From xen-devel-bounces@lists.xenproject.org Thu Jan 05 10:21:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 10:21:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471792.731788 (Exim 4.92) (envelope-from ) id 1pDNNX-0002LX-Ed; Thu, 05 Jan 2023 10:21:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471792.731788; Thu, 05 Jan 2023 10:21:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDNNX-0002LQ-Bf; Thu, 05 Jan 2023 10:21:43 +0000 Received: by outflank-mailman (input) for mailman id 471792; Thu, 05 Jan 2023 10:21:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDNNV-0002LG-TK for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 10:21:42 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bcc3e809-8ce2-11ed-91b6-6bf2151ebd3b; Thu, 05 Jan 2023 11:21:40 +0100 (CET) Received: from mail-dm6nam11lp2169.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 05 Jan 2023 05:21:34 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BL1PR03MB6197.namprd03.prod.outlook.com (2603:10b6:208:30b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 10:21:32 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 10:21:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bcc3e809-8ce2-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1672914100; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=DJ7lKESvxhuCgrxIskdZvgGuje2QQJAQLZrTbRSZmj0=; b=egP0ACbQ52obv5bmSSUTjtvsL7V9sTQdV88RIXAYy7i+gfvlDxc+C7Sb ukYHN5NXfEHElb7FkKK4cIqRd0e6JMA0+92Vx2WiO9Je2YdVCTzJPMwy1 3anVPnzzvgn+D8jK+FTfJXnvuGbEKlaDwwYhxnXvE/TTzY0QXfOD2f6l6 A=; X-IronPort-RemoteIP: 104.47.57.169 X-IronPort-MID: 90235615 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:xtGeWai5AbMFDDzZXrFrQjTTX161QhEKZh0ujC45NGQN5FlHY01je htvDz+CPPmJNDP8Lt1/aI61/RwC6MTcn4djQAY4+y88FCgb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmUpH1QMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWs0N8klgZmP6sT5QeDzyN94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQ9EXNRVz/ft964+7afYbBc3fU+a9HkadZ3VnFIlVk1DN4AaLWaGuDmwIEd2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilEuluGzYbI5efTTLSlRtm+eq njL4CLSBRYCOcbE4TGE7mitlqnEmiaTtIc6ReXiraM02QD7Kmo7AzwJCGK6pNaFkBC1atJyd Wk+8y8Rov1nnKCsZpynN/Gim1aGtBMBX9tbE8Uh9RqAjKHT5m6xFmUCCzJMdtEinMs3XiAxk E+EmcvzAj5iu6HTTmiSnp+LqRuiNC5TKnUNDRLoViMA6tjn5Y020BTGS486FLbv14OkXzbt3 zqNsS4ywa0JitIG3Lm6+laBhC+wop/OTUg+4QC/sn+Z0z6VrbWNP+SAgWU3J94aRGpFZjFtZ EQ5pvU= IronPort-HdrOrdr: A9a23:89mxbK74RlGpt80qSAPXwNnXdLJyesId70hD6qkXc202TiX4rb HMoB1/73TJYVkqOU3I6errBEDtexzhHP1OjbX5X43SOTUO0VHAROxfBODZowEIdReRytJg X-IronPort-AV: E=Sophos;i="5.96,302,1665460800"; d="scan'208";a="90235615" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PJzzvtozj3aUq+4Pk+cLIIasSA97O/2/R3IgWvdvq1Ufn2C6ML3GHgXIj8BcbCIALygBwrfsuUKDqhaptYH3SbPtG8x4LHDK050IQn36XvQDW83ZDVKmODEEbkLddej/Fe0AsMcJj4WYVZs2raTgbl4hhA7tMlDIhx8q+tryF+YgSveOR9FEaYH9IsjxP8n5YrAWbu8o2pbvgf508FQEYlJ521WBa9HuasxHyc9qWndrhkeTUtdwu+Ldt4JfSmUIGTRL6fBb3QxMC+f9xu5IfjyRWA7t4LI1kIMkfMOYDRSCnc4/FoHIeb37yun4zaP1cGCQxRqq5BuBi0gCbrNgGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DJ7lKESvxhuCgrxIskdZvgGuje2QQJAQLZrTbRSZmj0=; b=Up87IpPx6xcrLuRJgyeluOkrpjjxCflQXnpHcvC82y1vu06BTQVbJY1q64x6/OKVJoubEG4c56OXqCZmbfXuvV32NODMztCnErt0Dih/oI0izQU8rW6UxoWh5q2taXgGMdD6WOyGC8HT9hVJuEgp5OLMXVTPFdUnArO/4mdUKN9hxXhjxdJ7698NFHxTY3d3I6g/QncZpxFXjC81NRXP4bPCeqTz3Ec0RKWz7lNJhLqfdcue6dfzEfGqcZqYYYtbBjlvkiqnxeL1Y430kTqmA9wVrxUI5Gz3BNZfYkRJOmdW41VIdEK3tSgtKDmZm/Z60Xh8L5+S+rw8KHIR9PW9rA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DJ7lKESvxhuCgrxIskdZvgGuje2QQJAQLZrTbRSZmj0=; b=T+/zy+FQ9daKcgrEHrdxwNdEmbffnV2buvrwnq7AaXxS4zGty2wrOhCDePuS+KSAPAuYg8/3aT6IOsAbIA63GKuu2NsXV3YONMlgq6/pC3WoT0GHw5B9wHgDS89lYCBoXt+OtO3DUhXOzLMuwoHUD0HszHsROupbWukcj0DjL4A= From: Andrew Cooper To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Wei Liu , Roger Pau Monne Subject: Re: [PATCH v2] hvmloader: use memory type constants Thread-Topic: [PATCH v2] hvmloader: use memory type constants Thread-Index: AQHZIO4xGYPRUU9lrUSG9wpp5EE7mK6PnRcA Date: Thu, 5 Jan 2023 10:21:30 +0000 Message-ID: References: <15dd4897-d87b-9a0d-fc99-551a1b4be04d@suse.com> In-Reply-To: <15dd4897-d87b-9a0d-fc99-551a1b4be04d@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|BL1PR03MB6197:EE_ x-ms-office365-filtering-correlation-id: 89282547-5ddb-4e9f-8e1f-08daef069ccd x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: M/3qGEZeVA8BrHgCZ9/p5aktFpvMX61Lh+gRO70LiQwj6RvC0jwYp7FcC+aelz0fNoH2j9peoz73gdHVcQskGp79vJNfszQtwUlIbaRt7BmQ0ndXYaiB6gUKXjWqj7cVmz1vBPMNTS6xyxWSWSZhMfiWgIDKt41yGvBZgQEPeEtq2x8cSmCZXQU/gFLokZIuTAqMop2a0pHoToUPIKYtYptBAUolwnW/IFrd0WesOFoBJblDKrt9y7b0x8i1FIRwugKStq4BCqThquctAryx2V3aWWxOeT5dX4eRVHhj4ZZKA8Dl8jrHy6SLTUhnqO9rFdNNVPil8MbDC78f2RtD5vjUwsddpsElN6UOQQKdmQW9LHxi1tXVz1BYs1JABp7Gk3z6gRGP8sPN6ZYdc+oxxHCZ6dLggoNLZrPoAyRwqXCyMYpXJLTk/inyLwp/PxR/dgLjgkYlfM9QrLzRwurDLhuVE+JHGR9eKZeNtA9iwWJ/Bq2r34JsqC08TTb6y1ceDD3xBn7JHIEw9okC6pBlCq/XYdsWnHuTzbYcIeCMF7P1R22OEOFqfnex3O0gQela8ZthKpA7xATALTrvLuOpHEeNHH/29Cdx+1iBpm2vOHfVwBzVnoRP2FeXgtKXcjrgdkMqrw0YEPcMTewZpeD1GsPO0XjVrBCjEeAH3C14g7XErsWh8db8y33wo6Qi+Ef8JOd4oG4TfOdNtvYzC36Sqy56D1faKfww3iaf/hag4rRO+aorcizid/AcFw9FgjAfs4Hxxa84SIl8EssNDEqv/g== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(366004)(346002)(136003)(376002)(396003)(451199015)(6512007)(26005)(107886003)(6506007)(86362001)(38070700005)(36756003)(558084003)(31696002)(82960400001)(122000001)(2616005)(53546011)(38100700002)(186003)(316002)(4326008)(478600001)(41300700001)(8676002)(2906002)(5660300002)(8936002)(71200400001)(6486002)(31686004)(76116006)(66476007)(66556008)(66946007)(91956017)(54906003)(66446008)(110136005)(64756008)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?bjVhVjA0bXhGWk1IN25lS0QzMmVkUGs5aVNnRlpTN2VucHNlay9MTGhuWklP?= =?utf-8?B?U2x0RlgreW9nRVVPb2thV2tBQUswbkJlT2Fta3ZSTTZOeS83TUprZ1NybGF1?= =?utf-8?B?cmFTMEFQQmNEaWluWDl2T1ZZRmg5ZE9QVjJmbnlEclM4UDR5OTF2Szk1anor?= =?utf-8?B?UVpOVUNJMlVncW9WUDMyRmpSOTJIa211ZzRNb0Vqa2dhcy8yTEFYd3BEVkhr?= =?utf-8?B?c0FyTW9DdG1qMWNsd3pReVFPVXdqYm5aSHJ6QVBWcFNzbWtjWnhUdzFUa3Y5?= =?utf-8?B?RFBodlFrc0JtV3NnYWIvaGVvcllQR1VSK05uaStya3ErcERkd0pkMExOMllp?= =?utf-8?B?Sk82Y1F3T0o1cDhqWjZtNGxBT0U5YWVXNG1OYldRb0RxaHllVmN0RXdmaUdW?= =?utf-8?B?RWU4Y2h4eVAwa0N6RmhZQnVKbWpOVDdhZDFqZS9JWGxqRkFITUgvN1hwUkJR?= =?utf-8?B?UEJETnZMN3FETkI0NFZtN25wYVlNR1N2YW55cUthYXR6bHZGMmpqUWxWVk5T?= =?utf-8?B?a3hpWjNON0wxQWhXM2hyWThVcHF0TFRyaG5lTG1xaXRJd3pTNUlFNmswZ3dn?= =?utf-8?B?UktXc0F3NjE0UmdBd0RFUnBKZFJMVW1GZHVOU3dyeUVBdGV1MUQxQitqbWs0?= =?utf-8?B?ZGVpbisvcEZ4ckZYblNoVVMrdkdkOHUwTUlZeHRIbWl4WEJvWHRRWnVVMnR5?= =?utf-8?B?aFVLdXgvN2JTN1NLN0xPYzh3ajZMS1JqcmVoNXlSZVpRd0FUbHQvUE5uNStC?= =?utf-8?B?cFlLQUNOOEI1d241ZEI5dGo2OHI4cHl1M3lSaldxZkg3U0hYSi9qV1FwMXlh?= =?utf-8?B?RmY4UzFTckR4b2dGQ2dHTkNhdGJEUS81ZVlrUlVBT0ROUkI3YVM2d1lOcUF2?= =?utf-8?B?WFg1SWU4d0E2b3VxZTEwVy8vNEMzN0hBODdVK0p5aDdFYWo1U0dmR0o2MXY5?= =?utf-8?B?cHAwcXRlVjFDaVF3bkFXTDRPcVFQMEdxS0JxSHpWQ0c1R0k2L0lZYUNrUXd5?= =?utf-8?B?M2tkVXJ2Q0pyQjJZay9oem1QVFJ2THRVMllJczR0SEYvR05FQSs0TGphQXBP?= =?utf-8?B?MGljVGxPVUxCMmd6VkJxSlpWTGJsN2tSSW9lb1VFV0pUL2xWK2ZHK2ZYSS9E?= =?utf-8?B?cUhRUmNxKzdsMGZlcVVHNW8vWFllQnhBOVl5UlRWNjE1MkJCU2ZacjhIRGZG?= =?utf-8?B?VXZRSmVZWFdZT3NFaUZQV2RsR0Z5NWNnWC9VVnZsYTB3cTZXSVNndzYybGxR?= =?utf-8?B?Y2FoRTZrajdQVkdQUzlLOG55M2pvVnhGZ05uNFd5RWhoRm1FLzdLdWVZdmdq?= =?utf-8?B?NDRCWm95SjBZL0FsRDh3Q282cU1yUVhiSU5BTE9ua2NKTm12aHJhczRKRllT?= =?utf-8?B?QkF4YmFnOFNsN3VZNWtEcjkyZVQ3dE9KMld0b0JqanJEN3Q2M3BsS2UzUG82?= =?utf-8?B?T3NLd2pPZnlHOE5oOUxwcUpMSm80cmJKZUFzeXZGNEthN2ZjVTZNajlBdmlU?= =?utf-8?B?Y1U3dzhjUVBnaWltL083aDZZNi9HdHVudjZMeHIrOVZGNTI4WVZpdkZoUURU?= =?utf-8?B?QmpVaXN0Q21HMzZlRUZLVDZQeU9Pa2lHY1B3cWRYUTc1RWNMR3NWNVBnSXkv?= =?utf-8?B?RnlRem1IYUxoQlQzQWxiam5NRXA5M3NZVm9YWTlqUFlYaXNXbGUzNTdrY0Rv?= =?utf-8?B?SHlqaFYzbDk0SDZ0Qkk4dElFRXdFSkt0WG56dXNpUnliYi9jZmFSaHlTVHU1?= =?utf-8?B?VVQ3ZEpBVDNxT1dUQzdEZ3lxbFBkTGtkTW9qZ2hiVFNsOTQ2ZlAzSTh0L1Q2?= =?utf-8?B?NktwWUlucG9vVllsZitNR3hTbEJ0QlRVNTNiWXM1TWI5bG9pTThBcFM5V3Z3?= =?utf-8?B?QmV3ZlpmQ0lDWExEYTl5T0VUWTlnN1JGVkxFOUxtb1FtY3BKNzB3cHdOWjVN?= =?utf-8?B?ZGlQcTQ2RFc3dFo1dUJOMWg2Mi90K1g3L0RJck9XSDZ3TitOL29Pc2IxMzFZ?= =?utf-8?B?R1UzQnFwNEtBUWNkcXBhUmdiNy9ialJ4Mys0Mk5QbTIrSHcvYlU2aENwQVpY?= =?utf-8?B?aExMbUlOZENVZTQwNmpqdForVjB0bkkvNGV4MllnZjJvMnpMNkZCRnlJZjdS?= =?utf-8?Q?4RCNBPykLkuw/aItWHk3O0UZJ?= Content-Type: text/plain; charset="utf-8" Content-ID: <5F7A3CB5A084FB4EBCDFCA5B88CB1816@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: tbEO4sih/91FC8TGg5Wuy+h8pDf2755M3hjm5AawkJCYDigAa2T9Mgra9dQvvKUzSJQNo7IcY2wQuhkTWIkgsDgUsNsIz/TI1qPe0cDoGg//jX9jl+M678GAo+aLcfI4cgqPR9tP7DRtXxM8SruARtv4CpEOpil+9ED0f8XmSriZsA+cvJ4nsIGu7jRtBm2FbjzfQZNnQ4uQI6SJvDfAZLRvbWOQKHfhABJMYH49D3i3TGArSqKe91ekJwpKvJYjQXqv2gGm1NXtHTDf98Fjo+c1yUM0WAjUZRdP6CUaitwMOtN+5lqQM3cyYNUxeTTQHuSPtOoFSTsj8YHQqnBhfrJMDA9eFh6QxadyiqQH/U3js8h9qATb6EZWGrvZKpMxKsykGypZvgf+MWK32mjVbOK92aBI+mQkcziT0P9UaV5WyocCUgFNK4E1VXSbFsK+HrdLPFbgV5tSKF8wN1gWmbRgJK0aG8wfizTt5b+LBDUsA2wLinWZefS/k0RfqkACZRQg0ok+F8NIl08zgcckPhtiI1TzPmgSFdGUtAPGBFw7pmry+aLgv16jwO69HRW0fO65fLVimjqlhXTszW6bdQn/wQJtlmNyQdVbkJ37VLLc9q69DAphWWO2PTVdvrqq0LsmV7dnJLUYVGKlhZ/EVJemcf6J5Nbopmpzjk5xnvMaGW7jqPx7zUd/vZMsdWki6HrlgwEtJhV+lhw0EXNVG6oIWnSOdsbRNB++aayivUxbfq7VkgSMI1ljbFP4wE+PfSY+tGGxId7QBBpAUpMtnHroC9haZlZrYvMrbfJLKBKCDXACxOjTB1zng1FtqoUQ X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 89282547-5ddb-4e9f-8e1f-08daef069ccd X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jan 2023 10:21:30.5749 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: okECWCMB6zLzoEvPQZVpeBL+tim3P7SCl9ZOW77NsN195i/X7EDjBEYh1yIPv/Z8J+pxOYdaIRdrtFXvqyx5UwIhOEYfbHbAHIiBvkqaUT8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR03MB6197 T24gMDUvMDEvMjAyMyAxMDoxMiBhbSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE5vdyB0aGF0IHdl IGhhdmUgdGhlbSBhdmFpbGFibGUgaW4gYSBoZWFkZXIgd2hpY2ggaXMgb2theSB0byB1c2UgZnJv bQ0KPiBodm1sb2FkZXIgc291cmNlcywgZG8gYXdheSB3aXRoIHJlc3BlY3RpdmUgbGl0ZXJhbCBu dW1iZXJzIGFuZCBzaWxlbnQNCj4gYXNzdW1wdGlvbnMuDQo+DQo+IFNpZ25lZC1vZmYtYnk6IEph biBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCg0KUmV2aWV3ZWQtYnk6IEFuZHJldyBDb29w ZXIgPGFuZHJldy5jb29wZXJAY2l0cml4LmNvbT4NCg== From xen-devel-bounces@lists.xenproject.org Thu Jan 05 11:09:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 11:09:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471799.731798 (Exim 4.92) (envelope-from ) id 1pDO7z-0006jI-Ug; Thu, 05 Jan 2023 11:09:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471799.731798; Thu, 05 Jan 2023 11:09:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDO7z-0006jB-S3; Thu, 05 Jan 2023 11:09:43 +0000 Received: by outflank-mailman (input) for mailman id 471799; Thu, 05 Jan 2023 11:09:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDO7z-0006j4-1t for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 11:09:43 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2063.outbound.protection.outlook.com [40.107.6.63]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 72874b91-8ce9-11ed-b8d0-410ff93cb8f0; Thu, 05 Jan 2023 12:09:39 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8423.eurprd04.prod.outlook.com (2603:10a6:20b:3b5::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 11:09:39 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 11:09:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 72874b91-8ce9-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kPrUxtfFQq/gUda+YtL0dXlEP1j6oELrH4y/nr07aqQInol4goKcFbqRc4MxsOuYSzAFQT6g/dczZBll9U1Y8+QxoKRC6Y7YHHMkdfkIlrpDNVGk3vHuIQbqJ7Rggd8D1NkkNFmdSDRx2pjrM06+AoTjuIqoOm6nTkMrGU4hH/RpjrSVs6pMa41pJ9nXUm+yNnn5tZsXi/3ugSYATzAhDHr5vflkOrQZLBbRiz8buJ2E6/59OPVzbsG6sGphj2Z0KZJHEzSxVyDhCGbwCFfLv2EXUKb8yPyJO1b7X1Y7OepDIp8AqG1zQz3ZRFdYVxnA/qfXt1TCB5CaNDEul3ORew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xtJ2tMl3hWQX0ZOOqnHW05T+xWUWp8nD3ypTcC84mxA=; b=Z8bPzqLT7Tpl9Hu3kX2IH5Nf7UxqJpTlDW4MOPMurW7x7HyBW1NtQAZ17z771Dd5jDophr63DpdseZ6Cf083tF5+irVRi9FPo39x0TlyQTyoBQvAsP7yUQnkYaXDTX34HeG1gBZbIEKHKa+XZvzGeq1o4bcsVN5BoSpvGBx140Ru1nv/7xsvjBUMkhHybPhYf8MFI/cThQYFHBoRNowRy6/NRVFevKaUP8XIrW0FTsJ3alQwR4qo1UBZOeKNG6nimpd0htNr13FKjL7FXDc+s74emyMchScSpoEc25nfzVuKeCT823slpNRq1M/3TFW8CwJHRZZKx6zCq+jNhzpWCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xtJ2tMl3hWQX0ZOOqnHW05T+xWUWp8nD3ypTcC84mxA=; b=lSlMtiULll5Z8uf0ZXNU86IRDBE4Mwb7KuKW3+0Es8lIM24UK6Y1TRo3QmvK942G0gmgWclNus4uhQOPHO9l0/Knd77deKJysoGAv7MsJjEenwI1c9PCX4clqmAweWbesfXAsWZ4GY6lbAUyFzcN/wChf5Ttl48uGIEqFFo4c9mWJWx85REUMtwRjyP9v0+L1wcPx76Q3kfXUsoEhm02ZZ/J8RTZ4m21wHbJ8goH3hAyFDpkA4QmiLq7eI5ay65M9uSO6V0U5IHifTBkYvcvLyeBo3oHrj7TLypHqGGjjAkmwh0CQj2ZiWwEAwyZtwWwPDvlwcsuc8j5ddhzXqOBGA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <139bab3a-fd3e-fec2-b7b4-f63dd9f9439a@suse.com> Date: Thu, 5 Jan 2023 12:09:37 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Julien Grall From: Jan Beulich Subject: [PATCH] x86: idle domains don't have a domain-page mapcache Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0202.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a5::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8423:EE_ X-MS-Office365-Filtering-Correlation-Id: 8fb5b746-b21c-46b8-54d3-08daef0d565f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FFo7UhOL9DWFY9GcW7DpNCrrsgZQKCFii4/qLpT5bMhIs3UTzhIhkNSO0LQ2IJIFQ9m/p4l0j9RZCT9jbvFLEUdcqcRAryhNnomXXx8wBJWePM0mFtKmLGIj3Vcf4IPl8ueWYdwiVEzCGdTGnrJPfoUyq/iwMGEUX7m0lY79dMll8FyfuuKUnX5h6VvHjUBYqivbYj1AY4GlB6CD0GzR7XkiV2KOFOuiRwDSJSaQXK0ScUXDYBls+MchJEMgAopqgdXH+by0DGP5C5bWuNJ3ASEcaWwCqM9s1xCztbNxOhFTrWdu6Qu26Zjdku6iLG5aBLDzWUOUzCqR/9Z0qDMGCJvXAZLAALC1+nEAyJZfCpyh+LbfxSJzdUxRaOxmWaWRsyj2to673+Z2WTJKYnJyeuqVsyVjTn+msHCspgB7V8RgQnxPlXyg+8qpcfDNvsWzoF512VdW6jr72H5N1G+ckDJQb9Ac/5s84m3+5ZL3t/55Q33jFWTFyvBDRy8VVbsSbnOmdH8IqTuXXiME7L/ja6IxcBVPakrKI53vsOemWXM+XS0L9dvCVik3cBvW37poNM1OCQlUECiZOxdWega7QdTyQI3IDn2ugQdAlZ9o/jCW7dgi5+2/HhnY+uNwljoioaTEE73wSkZ58voaZ7g6h+Qgrei+QQJARI2dvYkad0V5S6LJKwZZwH1udGFWHtT3AEyCa6q6V1vzJ91LsmNaLzZENZHUuMHCCX+ktMpeCu0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(136003)(39860400002)(346002)(366004)(376002)(451199015)(2616005)(2906002)(86362001)(31696002)(36756003)(38100700002)(316002)(54906003)(6916009)(8676002)(66946007)(66556008)(8936002)(5660300002)(41300700001)(66476007)(4326008)(31686004)(6486002)(26005)(186003)(6512007)(478600001)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c0xCdU5LenJUTlVDNUN3RjVIU3pweE0vUFo1c0xwU01ZV0lvWUo3ZHc3Rk5D?= =?utf-8?B?QUJQK25LWEkvaERhdUVGaXJYTFNiQ3BNVXlmamUzSSsrcEJVR005VHZSOUFq?= =?utf-8?B?MW9OQkV4aDBCb2tHY010bFFOUGtNdjZmNHhmaWxvQVczdnZ6dVhTNVBpUlVP?= =?utf-8?B?K3JFSUtjS1pKcitJdVNPM2dCSDlTRHI4S1NldmpXaGttTlgxMW1jVVBoTm9r?= =?utf-8?B?eTdEc2ZmVjFqZWpTemp5NDVnWlY2QVdLK2tMNm55WDYwWWZqR0ZjRXZMVEJ3?= =?utf-8?B?WUE0NmpHbHJOOGQ5REk5SXlZcGNQdzlSbXp6OERiU09VeSt4ZkljbG4wR2Ju?= =?utf-8?B?Q2pDSitSY1IzQjNidjBsdUtIOUZST05MUkRuNHRkbWQ2cEQwTFM5TTNtc2Jw?= =?utf-8?B?UGZrS3cwbC9kTmxzWEZ6bXJJenE0L21KVDhNQ0oxLzhVMWJ4TlMzcXE4TDkz?= =?utf-8?B?ankxeTYvWlYySFQzSXpkeEFwV08vSm96Q3hTcDRzUE0xc1Y4L0Y1ZGk5Y2RW?= =?utf-8?B?S0FRYWN1b1N0QVBHQlo4aFNWR0NiLzhHYm4zVE1ndUYxV1YxUzVqRUxrQWZq?= =?utf-8?B?MEJ3OVlTMHhieEZVNTNzT1pSKzhGN1FLUDUvSEJVMzhvYVdJamUwR2RuM2lG?= =?utf-8?B?VVNvTXgwV0hNZEwvdGdaVTE4SUtiWVdLT1EyNVFlNWtyTm5XdzczbVJxM1JW?= =?utf-8?B?bzI4NExwOUN1NzY0SGxZNUdWcjNGZCsvWC82SHk3b2VMSHpLdVluQmREVnFR?= =?utf-8?B?VEdtNlBrOWZHSDVHSmVVeTBIV1k2bFc5UHZXcTYyakM2ZDVmL2xLRWEwVnZJ?= =?utf-8?B?c3BBWVBSdEhmTmtRMHptVjNHY0RzUjZ3Y3J5QUIvMW1JRXl3VUZKTXpxOXhG?= =?utf-8?B?RXNzVXQwSlF2NVdIYnJ6aEQ3VmlPSUQyS0hWRTk4SmVuV25IQVpQTTE5bmZh?= =?utf-8?B?WlM1UHNVSE9MSkJ4RnAxeXBSdnRaLzJ5N2ZydjhQK0FneXFqMHJ5UmJzbWdX?= =?utf-8?B?MzZ4Mk5PRmJheE9HT3JzWVNqZlk0UDRERERaTWo4WmVNSWNhODBDWTF3Q01j?= =?utf-8?B?L2xOTGM0bk1SejNwK3FrVlZSME1BbjRmenF4ZnlNeWNEKzVENEdmMEF6cWVJ?= =?utf-8?B?bWtMSGxFaGRzM1I5bzhha0JaOHB2Z3N4NkxBRDNmL3JDZGJEQ3BZd0l3N2I2?= =?utf-8?B?blJLY0hvOUxjaUY5NmE1enFzRlIvME9tM0Jid0NDNTI0bkdzRDFZS0ZPNElY?= =?utf-8?B?RFZ1bFBncU52S3VlSEJUYktvbm5reHRHS1hJY0lrRmpoUVlDZVFrVVN4Ulli?= =?utf-8?B?ckFwWW1MV3ErS1FTZklhRFVyN2pRVExKemlrUkZlUzZIYzJTZUtlRVUvSVRH?= =?utf-8?B?TEVySmpjQ2RIR29wbWFnWmtYZUdiZnF3VTh5Z25hbm50ZTRkS29lZEM2NElS?= =?utf-8?B?VmZjM2MxUDBRelNVUGpiZzA4QlFnV0N4WHd2Q3NVNGJkNms1MUQwNE5yUWtq?= =?utf-8?B?cFRWdG5vb1BsaFRDQmZTV3BNQWdqQnhtdDlxdytTV21VdGhZMlhHSy9FQ3p5?= =?utf-8?B?SkJKY0o1cTJGMmpsVU5HUHVQTlNYdEdCekVMTk9XTk8xMkRJTW5YRW9wdWd5?= =?utf-8?B?UzRHS3hEOHNiRjdGdFFKUGxJU01GVDRiQW5RUnU2VVA2bW1oV0hHZG9WbzAx?= =?utf-8?B?bFhDL1F2Z0FyNlRVNEZPUERralh1T3ZqRlkrTTM4RVQ4QUY4ai9RSEw0TnBh?= =?utf-8?B?dTh5QVBSODByQks1Uk43ZDhqVlQwZDhaKzJkU3ozdDJHZS8zblpDMG5Ld3dN?= =?utf-8?B?V2gxMEl2dE5OcjVvZys1ZmI2OVBmTHpDOE1RTUlyby9vcnVSYlNWbkFWenFR?= =?utf-8?B?YlNXcVA5Qmd1WnlrYUlETHRYS01Nc3VmWUhuMVZWVjB2OG0vUjRwc1REa3Rq?= =?utf-8?B?RDhQajRVWTVNbUVCRlY1R0V5V0NHWWJzemROdm9CK0Zaa29HeTF3QXlvYW5D?= =?utf-8?B?RVk4Qmd2bGxybXMwa1lzQTllNkl3VytMSmR1SVB2Ykhua0VFQnZXQVl3WnJI?= =?utf-8?B?OC9aQWw2SkU3RzErbkJMdFMyaHBaaUxZN21vSDdnejFiSlhCZW0vSkVKMytH?= =?utf-8?Q?Y1b+NIVB/+0TVfymagLHGxcSA?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8fb5b746-b21c-46b8-54d3-08daef0d565f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2023 11:09:39.1235 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +B+wBs2iRsoReeE210tsipcmTXN7ZbomIyk/FJWtmIpVSsWip4tYaO2w/V1w6rh8W/SYQ7rV1K8sRXEZkjxI2Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8423 First and foremost correct a comment implying the opposite. Then, to make things more clear PV-vs-HVM-wise, move the PV check earlier in the function, making it unnecessary for both callers to perform the check individually. Finally return NULL from the function when using the idle domain's page tables, allowing a dcache->inuse check to also become an assertion. Signed-off-by: Jan Beulich --- a/xen/arch/x86/domain_page.c +++ b/xen/arch/x86/domain_page.c @@ -28,8 +28,11 @@ static inline struct vcpu *mapcache_curr /* * When current isn't properly set up yet, this is equivalent to * running in an idle vCPU (callers must check for NULL). + * + * Non-PV domains don't have any mapcache. For idle domains (which + * appear to be PV but also have no mapcache) see below. */ - if ( !v ) + if ( !v || !is_pv_vcpu(v) ) return NULL; /* @@ -41,19 +44,22 @@ static inline struct vcpu *mapcache_curr return NULL; /* - * If guest_table is NULL, and we are running a paravirtualised guest, - * then it means we are running on the idle domain's page table and must - * therefore use its mapcache. + * If guest_table is NULL for a PV domain (which includes IDLE), then it + * means we are running on the idle domain's page tables and therefore + * must not use any mapcache. */ - if ( unlikely(pagetable_is_null(v->arch.guest_table)) && is_pv_vcpu(v) ) + if ( unlikely(pagetable_is_null(v->arch.guest_table)) ) { /* If we really are idling, perform lazy context switch now. */ - if ( (v = idle_vcpu[smp_processor_id()]) == current ) + if ( idle_vcpu[smp_processor_id()] == current ) sync_local_execstate(); /* We must now be running on the idle page table. */ ASSERT(cr3_pa(read_cr3()) == __pa(idle_pg_table)); + return NULL; } + ASSERT(!is_idle_vcpu(v)); + return v; } @@ -82,13 +88,12 @@ void *map_domain_page(mfn_t mfn) #endif v = mapcache_current_vcpu(); - if ( !v || !is_pv_vcpu(v) ) + if ( !v ) return mfn_to_virt(mfn_x(mfn)); dcache = &v->domain->arch.pv.mapcache; vcache = &v->arch.pv.mapcache; - if ( !dcache->inuse ) - return mfn_to_virt(mfn_x(mfn)); + ASSERT(dcache->inuse); perfc_incr(map_domain_page_count); @@ -187,7 +192,7 @@ void unmap_domain_page(const void *ptr) ASSERT(va >= MAPCACHE_VIRT_START && va < MAPCACHE_VIRT_END); v = mapcache_current_vcpu(); - ASSERT(v && is_pv_vcpu(v)); + ASSERT(v); dcache = &v->domain->arch.pv.mapcache; ASSERT(dcache->inuse); From xen-devel-bounces@lists.xenproject.org Thu Jan 05 11:11:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 11:11:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471807.731810 (Exim 4.92) (envelope-from ) id 1pDO9E-0008DN-DM; Thu, 05 Jan 2023 11:11:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471807.731810; Thu, 05 Jan 2023 11:11:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDO9E-0008DG-8p; Thu, 05 Jan 2023 11:11:00 +0000 Received: by outflank-mailman (input) for mailman id 471807; Thu, 05 Jan 2023 11:10:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDO9C-0008D0-Ns for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 11:10:58 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2080.outbound.protection.outlook.com [40.107.249.80]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a0e0defa-8ce9-11ed-91b6-6bf2151ebd3b; Thu, 05 Jan 2023 12:10:57 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB6929.eurprd04.prod.outlook.com (2603:10a6:208:181::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 11:10:56 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 11:10:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a0e0defa-8ce9-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AWZoSVZvVS+yUg0EpG/vMUAWdVh7Qo1rQaUII+hhTEbOZzXd40K+Xfg1Bsb2St6lhcHH+X3KuvXCBVu9lk7DgMwvPua9effvt/RTqnGYzkEm/4dpJfA4tyMi1euxjP3jSMAO2k9tbIYnUZje0xREeiJfFMo93SMDuOXes9+Zr6DrAj75wvJRFhrtiQ0HrtY9iEeOccAJE4zpTFjLu/CNFLMAItB+HCl7xZSb11DEkkw1Ne5ubIwEihcMG/mp9f5Lvzfk7ZniUDKF9T1vf+7wUW2uBGMcS6EccPQgFizn4yV/CoF+NqDxyHlARI/OlsUl/fb6W25l165lsjRMKklPgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iUugKwc+XLh8jVo+BdOIcApbl8H5L6XGAwjWzprilPQ=; b=MK31eb6SjI/yXHQ26o2U1qacXuWd5JhoFc+O3P3VcrwrmUMCgrCaQ8C4CucMhl4UZfUNo6FbH8EC+hzVC+OttvKYU/PQRA7hKkOj+Vm+ZlJGZs3imAxSQEnPgFu8O1hUydvafIIqbSem/RlN+Y3+r3s2xmUT/26oSWJyLQTXeiVJ6Cx9HI8e7i5o45tfKpK+MwSVsskFLiMoOk0c2WfxeI2XJfanVEOEHwMgJybc0lvPLnO56KbxG16peR8uM5p/W+MVtWriRIJwm9IDFF5aYhZT4sYerbEb8ZZJBekDb9grUxTuR8U3rJmzkXc82e5qspT0ZggBMV1MLyQIAt0XtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iUugKwc+XLh8jVo+BdOIcApbl8H5L6XGAwjWzprilPQ=; b=ODjQ5kewyuCXTJX3CKR0265bER3XIRcv/DPSRzYl7EGk0lOdTTUJZDI1mq2OhZRxxfoIQdG/BD1OXGjMOmvD8Uo8tYdW6O++q4Ea+hbbA/rxPU026cldN8SJJa91C1Qn6urKZ0V+QbIRu31t4xp0aaO08YVAfeCQYos+6oxUTqIjHcUBilTjLMI7TG7Yb8+ILUTVcRYtYNsrJO0vkULDtCiM+cTD4PAxtQRiW6Dhh4Wk/XGXl/9g6hfev+KHjwsbgZL00wEqkGVjX/22NjLb0AYu/tMqt0jDgGkjzmI3EWzNcU5ovFY0CbVYIrC42m4czmz/GSXTYiFsD19N2C4M3Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 5 Jan 2023 12:10:54 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= From: Jan Beulich Subject: [PATCH 0/2] x86: adjustments to .fixup section handling Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0132.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM0PR04MB6929:EE_ X-MS-Office365-Filtering-Correlation-Id: 516afa8e-5c22-4e95-a115-08daef0d8429 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: moD69y5FSppqjtD+p6wntZ4D4cgsMjR4/ZGuXCAKFyPUm4zo6hCJm+cQdOgMxrL9PvXtXyAUW1WBSQINJJZ1Z8PIBz9IXQ/EWZkXCyDiJOY5OnJTw7FJM6/n+NQ7COS4tHvtmVNHczCG+Sp+ynHE3jiMWo+tdjOkp3lYaxKRdJlGL/cfNPi/bwX3hr/+R22lR9/xnJV8eS+vkYjPJ2qU0O4c3fNXRm4AQpPbLt6MVjuABCMkISikg5a+Ov+rMbvPGsjnRRftdkUUVQho3RJxwJw34brRD3PuWpzdxQM4AQZgtbWAb+bZcGYpnH0HEU06t0gGcQATQ7lTqZwalq8ZfhFJgNuPUOh1637ibw0rmur04wsoKdRZKl51pY0tWZactzgsvzrTzAITcPgXqt84YGEsyD3aEZfjzawbYaKpsSQMWEW3CJ+UZuJVJWFCiRP0Q2RdIG9BBUOas24+6FqaFxnu3/sXO8u4yzGDHw6ti4M382aEXt4qCvdyNSO9s+tVnhG+KsHD03FyB90+pESdHMPPhJDv/z/YYwWrF+PUJOxJtWfLRT2lJCgAcD7KvD6ZgMZRgyLXrP8hkuAwDuIBvjCzmLFu6KTetjT8VDNdz5D37I3IVuNGGDOrx8qYsq4qGfeHGKb9OqqwPVrXLKwRQx+1q5IuTNbpMwt/WcbjO0UaDi6b2DuliquwfatbTOADfpPu0VZ1TLvyt84VThp5xQTWdvd/9WhA5oSrOOn/P4j1RIKy1yrV4AM9NMU4W11F X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(346002)(366004)(396003)(376002)(136003)(451199015)(31686004)(5660300002)(316002)(8676002)(54906003)(6916009)(2906002)(41300700001)(4326008)(66556008)(66476007)(8936002)(66946007)(6486002)(6506007)(478600001)(36756003)(186003)(86362001)(26005)(2616005)(6512007)(558084003)(31696002)(38100700002)(142923001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YmZsWFRXVXRwNXpUWDVUL25DdDVoQTRkakNXc25TMEhHSEVZb2RDNkJUSjgw?= =?utf-8?B?YUE0RWdidnFxb0JERkFxTGtUZUtFU0tXMFh0QzMrWisvQkVQcndDRWlVenRI?= =?utf-8?B?NHBQTWQwR3E1dHFlSk1ZTHVSN2hQZlJrcVhaNFlVbGlMbjl5c0JyRjJEQ0dX?= =?utf-8?B?alV0VnV3YVgwTGt5SERqaXh3ZXhiVHd1NmducXR0ZXVONEQ0QVFnSktvR1I4?= =?utf-8?B?QXF3aXJZUHZTRTVYV2c3d2lNbDhEamwzbzB3ZHErb1NPMFkxbkhiRzhnWmN5?= =?utf-8?B?VFBSL1dja3ZKZFk2MWR4S3hNdThRWUEvSE5BeVV3Rkg4Zm5Pc29ONWNtRHYy?= =?utf-8?B?ZXlGeVI0YTkyTzc5QlFERGMxUWZ5TklxNTFrREgzcUwyTTJDaHFYOTQyRDEv?= =?utf-8?B?eW1NRzEyNjU2TmZ3SnR0RVhhdkNiMTdUWDl1SWtTVkJiOEZoNWpYTHJhOVA5?= =?utf-8?B?NUZLZnVUS2VQRXd0MnBLWW5nTlQ4MGU5eE9FZjdJZXdoZklNeWhkZnc0MU1Q?= =?utf-8?B?eXk2Zm1jSHpobzAvQ2RtcUVsaFRPOXNRZ29pckJvVU9ES1pncFllT0ljL2hC?= =?utf-8?B?RHZrdXo4WkdnY2JkU3c4WDUwUi9oVVk3WTNjckNyWlo5blRGNzFraEJIaGZP?= =?utf-8?B?TnptNnQvNEt0dlRmSlZsQmZUUk9xcTlwN1hmN1M4OVZWcUtqVVFJOUZXOHFF?= =?utf-8?B?dEhWV1pRcElXYllpZi9NZERkc3lLWTZMWDRvdm9RV05sTGFTK1gwM2hFcVNa?= =?utf-8?B?RjA4YWlDbHNzZ2JwMGw4N21EZ0RJN0M1eU1NUVNLNjhDVkVPbmdPWG00dVpD?= =?utf-8?B?alpmdGNpWEl4Nmozc0FHeWhOUFpTQndqaG5iRWcxbndWa2VrZ2JCdE10Z0FG?= =?utf-8?B?TldudHR5N21HUXdIMzF2MzVtNVlHdjNhRnlxblFKQnJUWGU1RGhOWWdsWFha?= =?utf-8?B?dlU0YmxtUHErU0EvSkk2eUZ1UjNGZEk3dU1XNzJ0UVpndzhuQXFGcEZKRUFS?= =?utf-8?B?UjVHRFhRbUxsa2dBR1BmU0ZuVDJkbEpLRzNpcUhxNUxiUjc2OFBKZS9Udkdr?= =?utf-8?B?a0ppVnhZcUFNOVFnemR1OXhkUDN4Q2JKWTdJa2V0UGZOTW1EU2pXVHhaR3Y5?= =?utf-8?B?Zy8yUEU2TWVZK2F5eUI4QVBCZmdXWHRhTVJPYkNSRWZuNGNGNTZiMWxEQkw5?= =?utf-8?B?L1VDd0dpRXQwc3NmMnFqaXh2QmQ3TTVpM0tJMndGcGFnUFAzOTVObVM2SWM4?= =?utf-8?B?THJ2eE1Md2Qrdkc3THB5eDFxaGdUMWFQZitTeHV5RHNZdHJWSjBId01aQ2p1?= =?utf-8?B?QVloeEkyT2YxaFZBZ25PSVh4VzhSTzIrSkVxQ0dqTjJEWFlWSU9XRHRvczlB?= =?utf-8?B?WWh6S3F5endxMmFaRFN0WmRjbTJCT0xMaVFWYWZEWE8zNDluWjRDb1JkcE5q?= =?utf-8?B?bFhFazFCYkI2V3ZBMHZPTERyNlFLa1g4U25FMWQvV1RSc3I0eTMwanltQzFl?= =?utf-8?B?UnJXcnV5dmZteXJZZzZzRStGTVRlMkp2NThaOE4wV2U4eFRKbEFmQWl1bmRi?= =?utf-8?B?ejJHU2tNWWVlSTErK051TzdCb0dIT1FyNkpXYmF0L1NLR2VucU1TdWhiTGU2?= =?utf-8?B?ZDQ3dlB6NUZEK011V1hNdVdoS0VFWTFVZEE1TlZUenRsL1BoRVlFanBNRzZI?= =?utf-8?B?SVhwZFIyQWFlYUl0YzJEYkhuOVlxeWVIMlBRcC9zaE9SZ25rUjVoUXEvZW1s?= =?utf-8?B?Q1pRL3VoVnRPcmhHdmRqSTV2cytRNmhFdVZGRG82OW9tcU51ZEt5VG1NU2Yz?= =?utf-8?B?aEVUMWFLR3VhOE9yNm9CZzFCQ2VlM2xrN2ljd2VDd0xGUWI4OTlnc3lCdm9Y?= =?utf-8?B?QkozT0JrV0J3ZVdQcDRNS1JJeEJvaHEwenA5Mk1rSFR1L0JWRHJackRsYnZu?= =?utf-8?B?Y0toZkJhM05td2tDb0t2MTdlQ1JSbGdqd0RDeFVLWTR4R3piRll3NVhvRVV2?= =?utf-8?B?Q2J3S29ZUHJrZWpSQ1FwczFjZmlvK0dVaDVIekFSSFh3U2JBWXluS3RIWldz?= =?utf-8?B?WEk5RzNEdHdBc0taenhaMVV4dGFJSnJJUlVFenVlWTAxeStaNlVNNElsZkhx?= =?utf-8?Q?k0EFqKPS1sI9A/UY9e7AvviqR?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 516afa8e-5c22-4e95-a115-08daef0d8429 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2023 11:10:56.0092 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: padRoTB60SLNRoV3a9fmw9Zx70KJNpLIH6RdmH90E4ma+DKGhHbt/ybxFqKBIQbdgO/kIm++gEWMzdY8YaXtMg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6929 1: macroize switches to/from .fixup section 2: split .fixup section with new enough gas Jan From xen-devel-bounces@lists.xenproject.org Thu Jan 05 11:11:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 11:11:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471812.731821 (Exim 4.92) (envelope-from ) id 1pDO9s-0000Mj-Kp; Thu, 05 Jan 2023 11:11:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471812.731821; Thu, 05 Jan 2023 11:11:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDO9s-0000Mc-Hy; Thu, 05 Jan 2023 11:11:40 +0000 Received: by outflank-mailman (input) for mailman id 471812; Thu, 05 Jan 2023 11:11:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDO9r-0000MS-HE for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 11:11:39 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on2043.outbound.protection.outlook.com [40.107.15.43]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b8ef1ecb-8ce9-11ed-91b6-6bf2151ebd3b; Thu, 05 Jan 2023 12:11:38 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB6929.eurprd04.prod.outlook.com (2603:10a6:208:181::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 11:11:36 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 11:11:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b8ef1ecb-8ce9-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n1z2ouDNT8Y943IKrK5OPbF8jF8m6MCFsdtr+V+6cJsi3bmuxH53N/8wHACn+oML4Ke7Howg7PYwVhbzikQccmyqYsHiVvvKFlNmF0OcI1mO7GPQnG67MPHBREBY10MUZ2qkObj9++TYnKxtUm1RYzaMN5Le1tZQx2DWMVgnIZqBiXk35HrLjyPqhtCyMRxrChaLiM4wKu2E2p8uY8/HjJsMofnIcqx4yr++jq/9rralAiJJyBt/J5auKHNjJn1E7qca42auMHX1ZIa4YSgY/cwccK8bGRKMLNDXV6HnXHd3jOd/dC2WW+IQE1wA8HkFSn/Q//cnFjOG4B7PpwX13Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Cm9QUjQ0OiBxmbXmS8go9kS0Co5ZCYy7d8B43NW/X6E=; b=hjpnfc4CEnTc4m52gTccQVOKhh6EERJJ3QXkgHZV9kP+LApWQfe8JZ6n1cbkeIpftSlnL8u9mQQzCJrR8K4WXQFsEjaJXnyfMhPNavRI6tvCDtzvjM62SK+LU+XmLfj1Dhg9aJdxRv18yFrnrVn4UQ6LdZhkqkTsJEuHLcBiYIb8X/vfRw4z5SF8xTpfTYHOdPdvdveK7YsOgqUPpStPy8REvlzCwlk3W92i7GRAgGsh6T6Apw58iU6x7HQ0VlTIAHQol+ccM4VxTqFPrN3zk31rbqLpieZ4uHioCkx20AC9WhfcMVZqmUrPNpt+YIUsUd2xAjAZ1ln+BK3PRuM5Fg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Cm9QUjQ0OiBxmbXmS8go9kS0Co5ZCYy7d8B43NW/X6E=; b=KAqDODOOtOkq3Mn+Wr7k3Ag2w3gvH9whJUHp/ycOF80s+d1WUhTHxEM13EGsUHNs+3kO3DHADoRhXaFfqDd5w6qJyAETlbGKDJ/DObnwPhJuN9HsZnakdXqvtiSISGGlUsSgW1Y9S/MNlURRJ6Qn+HV8AZi2DXK01Mu+prhMdBdm/Le89nH5jOAuHTpptkkk/c7QYxgmzJaJGIqrFct/ZQ3ZL3nOBqbjg7clSTd34OfQ/aXrW9HifbkWiytZu4wXt7gqSMWzi4C8ZP0s4GwQCA5tq2USLlYWVC3d+S98unBoE3/nqPCXwf+SPTuPhfvfjBvmTBnfGu3N7XxG0GAqig== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <87efc536-3344-0459-b756-62a035db4090@suse.com> Date: Thu, 5 Jan 2023 12:11:35 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: [PATCH 1/2] x86: macroize switches to/from .fixup section Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0133.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM0PR04MB6929:EE_ X-MS-Office365-Filtering-Correlation-Id: 41ffbc2c-292a-4dd4-e515-08daef0d9c45 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4N2lcKCBikWndPU9hdaDzG55Qa/GnydCdeHJ61KkwZaXURg31s15l8EWZg3sK1vlkfBuRhkesWYeq1X9sDJZ5v3DyNs4O9GJGMcq4DBNoiijigX2IG07XA2ZD1Q5MfeQxmlGD75xROJhU9VGrdYWAph5cJmoCMBjr23Tb5RogET0+qCnsubVaYCdOHFAn0aDuLL/vgRmeKj2PQj5tKP0N1dUKfIpaJdUbf9iDce/2DJyCNPYnx5EtYhAVJ4U5sFL+c2HuAr/3IYYXrtrwNCT4S/zIA4BQ0OUsx1xl6wtSUVlR0CW8c475yPFURteYjwBFjYHCkqqqH+IT5IRdt/zWHQzSZsiODwRYW8caCO20UR7qkzy1+RBaOhJLODIipRLzl1ZVdARYLLZVx6sPiqd8w4KR7w++jdM26Vmo+EuHMjK7GIHg17xInfDUCbHD/P+bKlaDJdLwtfNtRH9m4X66+cuhBgLY1eXGurRUQHcCS3D8AXJBpEp/5cENjWSYGxhg9/KZhEeqUjDt93fCS6GJO+ronNZVhDGqVj250ltpCGMq09J/izlxGygNAnV/o/+moHi26BI4bP3sE9t/PrFboSasg5Mp44pVcU+mfnn02UG8kuaax9c1fQ97wRK80wHRMlq++JZvxyqRP5CqdJl09rs1TYpTOqrHFyvVUPqHm5wW3qZe/BwdDVaSk6TtY1s+84rLYKSaVMrtJP1FZQT4Yhv1se9KX5dSK+foGRzSFyTYmgyaBFB4KuOT2/EkZhk/Wlwx6A2VqRCzarKzuaFCA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(346002)(366004)(396003)(376002)(136003)(451199015)(31686004)(5660300002)(30864003)(316002)(8676002)(54906003)(6916009)(2906002)(41300700001)(4326008)(66556008)(66476007)(8936002)(66946007)(6486002)(6506007)(478600001)(36756003)(83380400001)(186003)(86362001)(26005)(2616005)(6512007)(31696002)(38100700002)(142923001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TTdiQVRlY3ppcWVZUG10b09TcVZ4NVZhdWtrQ0RETWhFeUE2amM4aUVlY1Ft?= =?utf-8?B?YVNteDhyMHE5TTJEYjZSV0lnN3IrTk9kSnZoai9WclpxU1R3WHNidHlzNkhX?= =?utf-8?B?VlZxMmQ2a3hJcnM3SHhqRnBHRUNoMS9IS1AvOXdKSFh2MGEwUzRqS1hoT3dl?= =?utf-8?B?MjVzMkN0NW5RZG1yVnA3UWh6VnZvQ3NkS2M3T1BRMVlrS1MrM0pNZzJkMlg5?= =?utf-8?B?NTUxZEVENXQvUzBkemR5V2VlMndUNnUwcmkzSFMxQVQ0Qm15eXRZZjRyYzRn?= =?utf-8?B?Z0kzVDM1YlNDZzk3WmpJeXV4dWE2Smh2VXFTQmxJMnFWVnVkL3RQcVV6TnpR?= =?utf-8?B?TGI2M0lvakc0U3IxQXNua3AvRFRLWm9pRWZXUXpxVVlLbGVzSzRJNHFGZVZx?= =?utf-8?B?cmpETHNJaEFpQVRROVl0eVgzNWllU0VRTFhnMUdTSnJQR1JXVVJxbnQ0dlRE?= =?utf-8?B?K0tGNDRlVDA5c1UxanFTUGdZN3JjRHJrQnhxaVdLdlJFeGk3Q0d0d05uZWdK?= =?utf-8?B?ckhpVjREVkpzYzA2SjNiS25XSWlhbjhLOFFhTExPMW84WHptMWdEZnVYaFBK?= =?utf-8?B?TUR6ZUNIL05hWEhMeVE2WWl5aVdMSlU2d3ZOczF0RzgxeGVtY045akpxR2Fy?= =?utf-8?B?WmdrWUpPS1pVRnFoNjRzZ2NieXdvdy9zRDBZQVlvSnlGWjk0U0orbVhhcWxV?= =?utf-8?B?UXVMS0lta2JTNkh5dU85TldpTUMxc3NoSjVVV3Z2Z1dSQ00wRlRrVXUyWEV3?= =?utf-8?B?SERCcTZSYm8zMUEydzZDVlJtLzFWM1dvYUdWWkxFME4zbUpycVJiRHdPSW5u?= =?utf-8?B?czJPR09KVDB4MXpBajVrZzZEaU9uMHdkb2FSd0tNSHE2ZjkrTDg1S1lTeWts?= =?utf-8?B?K3p4QkpRSVlTcnRSQ1JlaGJrMlpYbWpPbE45N3pta0tndThRMkd6T0t5MUw2?= =?utf-8?B?K2NoenRqb1JsbHNWTzlud01wdmNZeWFab3kybUw3dkJmYkFOZ1VQQzlTckVW?= =?utf-8?B?R2RFcXd3KzhBNkNGNHVxcFJFQ3haMDJxdWNRc3FnYlNDcXNFaDZybXYzWmt5?= =?utf-8?B?bDdIelc1NVZ6dXRlYlJDdFNpeFBEMXFwclFybmlNcmpCeHM3MWdENE1Kb0VX?= =?utf-8?B?WGRWaS94T1VLWHQzcVpueFRaVk1nbWV0K1Z2Y1lJcjB0MWI1bFpoTTZXd29W?= =?utf-8?B?dHJzVlRkL1U3UTNranRBdnFxRFFaOGZYTTRGd1NQZjFpbnlDc3hnMmp6SjlB?= =?utf-8?B?R09OWERONjBzajRuZzNkK000blJpSHlYaHRaLzh6Qi9VakRoby9LUlgwbGJl?= =?utf-8?B?UGhoQnQrNm9LR0dtaTRJemxIak1NOENILzFwbHcrYXNIWWEvQUEzZE9MZ05j?= =?utf-8?B?cXZqQ1VRZmpwTURiY1ZiemJqdDJzOGx4SDVCaWpzQ3hja3lrNnhHS05TWTBa?= =?utf-8?B?ZnM4UDRtdWhVYzFQTysyalJDWVRnbWpaZ3kvUnZvL3AyYTNZMDkwbEpTSlp5?= =?utf-8?B?cHFaRVUvWEFYd3BlcC8rR2xSdytKSDZocEZGYW9iQ0s1T2dYNFJ3blpaS0Ja?= =?utf-8?B?KzN5cnp0Y1lPaGNtV25ydlUrMGVMdGFmdXgzOHk5cjB6c3FyZW5HeG1pQzY1?= =?utf-8?B?OEFIZXNGVklqUEtxZkQ5TGpUNDlRaStkdGpHTkd1aTIySmZaVU5TYVphWDRW?= =?utf-8?B?VFdTREYzcllOdEFwMWY2QTdSc1pRbWhlb043amJVTENNVTVMbTd4QVBrL1o2?= =?utf-8?B?OU0yY1lRamJ1alJ5cm8zMnRLWTBPOERHUmFZSityenEvSnNpbHAweXc3VDV3?= =?utf-8?B?dklqWU9weWw1RGVRWlB1VkgrNkxKYlI4VkVSRkRLT21lSVNhMXNvLzN1S3RZ?= =?utf-8?B?VlVwSXFINjk2WlZkOEZ6YVNLcHAzM2o3MkE1WmdFN294T013ZUxGMndGYWZ4?= =?utf-8?B?RGhQQW1uK1I3U3hpVG9MRDN5MllBVDAxK0NOR21WdWJYRnloWjJrVEk2TnEv?= =?utf-8?B?ZmxtaGdhVXNCU2lIR2o4SDVsYmdpakgzYjJJYjh6WnRhak9hNmJnd0pEZGZL?= =?utf-8?B?RUljYW1UZE5TRlhSN0p6WWl3SkpXbmIyL2NSMjd0Y0RFbUhySTJTQVdNMW5M?= =?utf-8?Q?Z/dBPvNeG5CkirnDqUylLSDNf?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 41ffbc2c-292a-4dd4-e515-08daef0d9c45 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2023 11:11:36.3973 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BtYRtnUuOTh34jTC7v99gUGKdyAvXUTJ6Q5xC1y9n0jzXfoi7mQYLrs1DUj1boSZ3Rg/Cs9zJQMtuLAj2KHx2w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6929 This centralizes section name and attribute setting, thus simplifying future changes to either of these. Signed-off-by: Jan Beulich --- a/xen/arch/x86/cpu/amd.c +++ b/xen/arch/x86/cpu/amd.c @@ -57,10 +57,10 @@ static inline int rdmsr_amd_safe(unsigne int err; asm volatile("1: rdmsr\n2:\n" - ".section .fixup,\"ax\"\n" + _ASM_FIXUP "\n" "3: movl %6,%2\n" " jmp 2b\n" - ".previous\n" + _ASM_FIXUP_END "\n" _ASM_EXTABLE(1b, 3b) : "=a" (*lo), "=d" (*hi), "=r" (err) : "c" (msr), "D" (0x9c5a203a), "2" (0), "i" (-EFAULT)); @@ -74,10 +74,10 @@ static inline int wrmsr_amd_safe(unsigne int err; asm volatile("1: wrmsr\n2:\n" - ".section .fixup,\"ax\"\n" + _ASM_FIXUP "\n" "3: movl %6,%0\n" " jmp 2b\n" - ".previous\n" + _ASM_FIXUP_END "\n" _ASM_EXTABLE(1b, 3b) : "=r" (err) : "c" (msr), "a" (lo), "d" (hi), "D" (0x9c5a203a), --- a/xen/arch/x86/domain.c +++ b/xen/arch/x86/domain.c @@ -1607,11 +1607,11 @@ static void load_segments(struct vcpu *n #define TRY_LOAD_SEG(seg, val) \ asm volatile ( "1: mov %k[_val], %%" #seg "\n\t" \ "2:\n\t" \ - ".section .fixup, \"ax\"\n\t" \ + _ASM_FIXUP "\n\t" \ "3: xor %k[ok], %k[ok]\n\t" \ " mov %k[ok], %%" #seg "\n\t" \ " jmp 2b\n\t" \ - ".previous\n\t" \ + _ASM_FIXUP_END "\n\t" \ _ASM_EXTABLE(1b, 3b) \ : [ok] "+r" (all_segs_okay) \ : [_val] "rm" (val) ) --- a/xen/arch/x86/extable.c +++ b/xen/arch/x86/extable.c @@ -164,11 +164,11 @@ static int __init cf_check stub_selftest asm volatile ( "INDIRECT_CALL %[stb]\n" ".Lret%=:\n\t" - ".pushsection .fixup,\"ax\"\n" + _ASM_FIXUP "\n" ".Lfix%=:\n\t" "pop %[exn]\n\t" "jmp .Lret%=\n\t" - ".popsection\n\t" + _ASM_FIXUP_END "\n\t" _ASM_EXTABLE(.Lret%=, .Lfix%=) : [exn] "+m" (res) ASM_CALL_CONSTRAINT : [stb] "r" (addr), "a" (tests[i].rax)); --- a/xen/arch/x86/i387.c +++ b/xen/arch/x86/i387.c @@ -67,7 +67,7 @@ static inline void fpu_fxrstor(struct vc asm volatile ( /* See below for why the operands/constraints are this way. */ "1: " REX64_PREFIX "fxrstor (%2)\n" - ".section .fixup,\"ax\" \n" + _ASM_FIXUP "\n" "2: push %%"__OP"ax \n" " push %%"__OP"cx \n" " push %%"__OP"di \n" @@ -79,7 +79,7 @@ static inline void fpu_fxrstor(struct vc " pop %%"__OP"cx \n" " pop %%"__OP"ax \n" " jmp 1b \n" - ".previous \n" + _ASM_FIXUP_END "\n" _ASM_EXTABLE(1b, 2b) : : "m" (*fpu_ctxt), "i" (sizeof(*fpu_ctxt) / 4), "R" (fpu_ctxt) ); @@ -87,7 +87,7 @@ static inline void fpu_fxrstor(struct vc case 4: case 2: asm volatile ( "1: fxrstor %0 \n" - ".section .fixup,\"ax\"\n" + _ASM_FIXUP "\n" "2: push %%"__OP"ax \n" " push %%"__OP"cx \n" " push %%"__OP"di \n" @@ -99,7 +99,7 @@ static inline void fpu_fxrstor(struct vc " pop %%"__OP"cx \n" " pop %%"__OP"ax \n" " jmp 1b \n" - ".previous \n" + _ASM_FIXUP_END "\n" _ASM_EXTABLE(1b, 2b) : : "m" (*fpu_ctxt), "i" (sizeof(*fpu_ctxt) / 4) ); --- a/xen/arch/x86/include/asm/asm_defns.h +++ b/xen/arch/x86/include/asm/asm_defns.h @@ -79,6 +79,15 @@ register unsigned long current_stack_poi #define _ASM_EXTABLE(from, to) _ASM__EXTABLE(, from, to) #define _ASM_PRE_EXTABLE(from, to) _ASM__EXTABLE(.pre, from, to) +/* Exception recovery code section */ +#ifdef __ASSEMBLY__ +# define _ASM_FIXUP .pushsection .fixup, "ax", @progbits +# define _ASM_FIXUP_END .popsection +#else +# define _ASM_FIXUP " .pushsection .fixup, \"ax\", @progbits" +# define _ASM_FIXUP_END " .popsection" +#endif + #ifdef __ASSEMBLY__ #ifdef HAVE_AS_QUOTED_SYM --- a/xen/arch/x86/include/asm/hvm/vmx/vmx.h +++ b/xen/arch/x86/include/asm/hvm/vmx/vmx.h @@ -579,9 +579,9 @@ static inline int __vmxon(u64 addr) "1: " VMXON_OPCODE MODRM_EAX_06 "\n" " setna %b0 ; neg %0\n" /* CF==1 or ZF==1 --> rc = -1 */ "2:\n" - ".section .fixup,\"ax\"\n" + _ASM_FIXUP "\n" "3: sub $2,%0 ; jmp 2b\n" /* #UD or #GP --> rc = -2 */ - ".previous\n" + _ASM_FIXUP_END "\n" _ASM_EXTABLE(1b, 3b) : "=q" (rc) : "0" (0), "a" (&addr) --- a/xen/arch/x86/include/asm/msr.h +++ b/xen/arch/x86/include/asm/msr.h @@ -44,10 +44,10 @@ static inline void wrmsrl(unsigned int m uint32_t lo_, hi_; \ __asm__ __volatile__( \ "1: rdmsr\n2:\n" \ - ".section .fixup,\"ax\"\n" \ + _ASM_FIXUP "\n" \ "3: xorl %0,%0\n; xorl %1,%1\n" \ " movl %5,%2\n; jmp 2b\n" \ - ".previous\n" \ + _ASM_FIXUP_END "\n" \ _ASM_EXTABLE(1b, 3b) \ : "=a" (lo_), "=d" (hi_), "=&r" (rc_) \ : "c" (msr), "2" (0), "i" (-EFAULT)); \ @@ -64,9 +64,9 @@ static inline int wrmsr_safe(unsigned in __asm__ __volatile__( "1: wrmsr\n2:\n" - ".section .fixup,\"ax\"\n" + _ASM_FIXUP "\n" "3: movl %5,%0\n; jmp 2b\n" - ".previous\n" + _ASM_FIXUP_END "\n" _ASM_EXTABLE(1b, 3b) : "=&r" (rc) : "c" (msr), "a" (lo), "d" (hi), "0" (0), "i" (-EFAULT)); --- a/xen/arch/x86/include/asm/uaccess.h +++ b/xen/arch/x86/include/asm/uaccess.h @@ -160,10 +160,10 @@ struct __large_struct { unsigned long bu ) \ "1: mov"itype" %"rtype"[val], (%[ptr])\n" \ "2:\n" \ - ".section .fixup,\"ax\"\n" \ + " " _ASM_FIXUP "\n" \ "3: mov %[errno], %[ret]\n" \ " jmp 2b\n" \ - ".previous\n" \ + _ASM_FIXUP_END "\n" \ _ASM_EXTABLE(1b, 3b) \ : [ret] "+r" (err), [ptr] "=&r" (dummy_) \ GUARD(, [scr1] "=&r" (dummy_), [scr2] "=&r" (dummy_)) \ @@ -177,11 +177,11 @@ struct __large_struct { unsigned long bu ) \ "1: mov (%[ptr]), %"rtype"[val]\n" \ "2:\n" \ - ".section .fixup,\"ax\"\n" \ + " " _ASM_FIXUP "\n" \ "3: mov %[errno], %[ret]\n" \ " xor %k[val], %k[val]\n" \ " jmp 2b\n" \ - ".previous\n" \ + _ASM_FIXUP_END "\n" \ _ASM_EXTABLE(1b, 3b) \ : [ret] "+r" (err), [val] ltype (x), \ [ptr] "=&r" (dummy_) \ --- a/xen/arch/x86/pv/misc-hypercalls.c +++ b/xen/arch/x86/pv/misc-hypercalls.c @@ -251,11 +251,11 @@ long do_set_segment_base(unsigned int wh * re-read %gs and compare against the input. */ asm volatile ( "1: mov %[sel], %%gs\n\t" - ".section .fixup, \"ax\", @progbits\n\t" + _ASM_FIXUP "\n\t" "2: mov %k[flat], %%gs\n\t" " xor %[sel], %[sel]\n\t" " jmp 1b\n\t" - ".previous\n\t" + _ASM_FIXUP_END "\n\t" _ASM_EXTABLE(1b, 2b) : [sel] "+r" (sel) : [flat] "r" (FLAT_USER_DS32) ); --- a/xen/arch/x86/traps.c +++ b/xen/arch/x86/traps.c @@ -550,9 +550,9 @@ static void show_trace(const struct cpu_ /* Guarded read of the stack top. */ asm ( "1: mov %[data], %[tos]; 2:\n" - ".pushsection .fixup,\"ax\"\n" + _ASM_FIXUP "\n" "3: movb $1, %[fault]; jmp 2b\n" - ".popsection\n" + _ASM_FIXUP_END "\n" _ASM_EXTABLE(1b, 3b) : [tos] "+r" (tos), [fault] "+qm" (fault) : [data] "m" (*sp) ); --- a/xen/arch/x86/usercopy.c +++ b/xen/arch/x86/usercopy.c @@ -38,12 +38,12 @@ unsigned int copy_to_guest_ll(void __use " mov %[aux],%[cnt]\n" "1: rep movsb\n" /* ...remainder copied as bytes */ "2:\n" - ".section .fixup,\"ax\"\n" + " " _ASM_FIXUP "\n" "5: add %[aux], %[cnt]\n" " jmp 2b\n" "3: lea (%q[aux], %q[cnt], "STR(BYTES_PER_LONG)"), %[cnt]\n" " jmp 2b\n" - ".previous\n" + " " _ASM_FIXUP_END "\n" _ASM_EXTABLE(4b, 5b) _ASM_EXTABLE(0b, 3b) _ASM_EXTABLE(1b, 2b) @@ -81,7 +81,7 @@ unsigned int copy_from_guest_ll(void *to " mov %[aux], %[cnt]\n" "1: rep movsb\n" /* ...remainder copied as bytes */ "2:\n" - ".section .fixup,\"ax\"\n" + " " _ASM_FIXUP "\n" "5: add %[aux], %[cnt]\n" " jmp 6f\n" "3: lea (%q[aux], %q[cnt], "STR(BYTES_PER_LONG)"), %[cnt]\n" @@ -92,7 +92,7 @@ unsigned int copy_from_guest_ll(void *to " xchg %[aux], %%eax\n" " mov %k[from], %[cnt]\n" " jmp 2b\n" - ".previous\n" + " " _ASM_FIXUP_END "\n" _ASM_EXTABLE(4b, 5b) _ASM_EXTABLE(0b, 3b) _ASM_EXTABLE(1b, 6b) @@ -149,10 +149,10 @@ unsigned int clear_guest_pv(void __user " mov %[bytes], %[cnt]\n" "1: rep stosb\n" "2:\n" - ".section .fixup,\"ax\"\n" + " " _ASM_FIXUP "\n" "3: lea (%q[bytes], %q[longs], "STR(BYTES_PER_LONG)"), %[cnt]\n" " jmp 2b\n" - ".previous\n" + " " _ASM_FIXUP_END "\n" _ASM_EXTABLE(0b,3b) _ASM_EXTABLE(1b,2b) : [cnt] "=&c" (n), [to] "+D" (to), [scratch1] "=&r" (dummy), --- a/xen/arch/x86/x86_64/compat/entry.S +++ b/xen/arch/x86/x86_64/compat/entry.S @@ -321,11 +321,11 @@ __UNLIKELY_END(compat_bounce_null_select mov %al, TRAPBOUNCE_flags(%rdx) ret -.section .fixup,"ax" + _ASM_FIXUP .Lfx13: xorl %edi,%edi jmp .Lft13 -.previous + _ASM_FIXUP_END _ASM_EXTABLE(.Lft1, dom_crash_sync_extable) _ASM_EXTABLE(.Lft2, compat_crash_page_fault) _ASM_EXTABLE(.Lft3, compat_crash_page_fault_4) @@ -346,9 +346,9 @@ compat_crash_page_fault: movl %esi,%edi call show_page_walk jmp dom_crash_sync_extable -.section .fixup,"ax" + _ASM_FIXUP .Lfx14: xorl %edi,%edi jmp .Lft14 -.previous + _ASM_FIXUP_END _ASM_EXTABLE(.Lft14, .Lfx14) --- a/xen/arch/x86/x86_64/entry.S +++ b/xen/arch/x86/x86_64/entry.S @@ -580,7 +580,7 @@ __UNLIKELY_END(create_bounce_frame_bad_b mov %al, TRAPBOUNCE_flags(%rdx) ret - .pushsection .fixup, "ax", @progbits + _ASM_FIXUP # Numeric tags below represent the intended overall %rsi adjustment. domain_crash_page_fault_6x8: addq $8,%rsi @@ -616,7 +616,7 @@ ENTRY(dom_crash_sync_extable) #endif xorl %edi,%edi jmp asm_domain_crash_synchronous /* Does not return */ - .popsection + _ASM_FIXUP_END #endif /* CONFIG_PV */ /* --- CODE BELOW THIS LINE (MOSTLY) NOT GUEST RELATED --- */ --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -1260,11 +1260,11 @@ static inline int mkec(uint8_t e, int32_ block_speculation(); /* SCSB */ \ asm volatile ( pre "\n\tINDIRECT_CALL %[stub]\n\t" post "\n" \ ".Lret%=:\n\t" \ - ".pushsection .fixup,\"ax\"\n" \ + _ASM_FIXUP "\n" \ ".Lfix%=:\n\t" \ "pop %[exn]\n\t" \ "jmp .Lret%=\n\t" \ - ".popsection\n\t" \ + _ASM_FIXUP_END "\n\t" \ _ASM_EXTABLE(.Lret%=, .Lfix%=) \ : [exn] "+g" (stub_exn.info) ASM_CALL_CONSTRAINT, \ constraints, \ --- a/xen/arch/x86/xstate.c +++ b/xen/arch/x86/xstate.c @@ -45,10 +45,10 @@ static inline bool xsetbv(u32 index, u64 asm volatile ( "1: .byte 0x0f,0x01,0xd1\n" "3: \n" - ".section .fixup,\"ax\" \n" + _ASM_FIXUP "\n" "2: xor %0,%0 \n" " jmp 3b \n" - ".previous \n" + _ASM_FIXUP_END "\n" _ASM_EXTABLE(1b, 2b) : "+a" (lo) : "c" (index), "d" (hi)); @@ -403,10 +403,10 @@ void xrstor(struct vcpu *v, uint64_t mas #define _xrstor(insn) \ asm volatile ( "1: .byte " insn "\n" \ "3:\n" \ - " .section .fixup,\"ax\"\n" \ + " " _ASM_FIXUP "\n" \ "2: incl %[faults]\n" \ " jmp 3b\n" \ - " .previous\n" \ + " " _ASM_FIXUP_END "\n" \ _ASM_EXTABLE(1b, 2b) \ : [mem] "+m" (*ptr), [faults] "+g" (faults) \ : [lmask] "a" (lmask), [hmask] "d" (hmask), \ From xen-devel-bounces@lists.xenproject.org Thu Jan 05 11:12:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 11:12:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471821.731832 (Exim 4.92) (envelope-from ) id 1pDOAL-0000xH-3L; Thu, 05 Jan 2023 11:12:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471821.731832; Thu, 05 Jan 2023 11:12:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDOAK-0000xA-WB; Thu, 05 Jan 2023 11:12:08 +0000 Received: by outflank-mailman (input) for mailman id 471821; Thu, 05 Jan 2023 11:12:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDOAJ-0000K8-F1 for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 11:12:07 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on2087.outbound.protection.outlook.com [40.107.15.87]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c8ef8586-8ce9-11ed-b8d0-410ff93cb8f0; Thu, 05 Jan 2023 12:12:04 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB6929.eurprd04.prod.outlook.com (2603:10a6:208:181::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 11:12:04 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 11:12:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c8ef8586-8ce9-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dyXTtLgnBsZZO9u37fZXGeTTu5JWvKD1DVDmwSnNIsJQhB4siXfK9v9Tcogv9xqtAuOJ34+E92vtmDxOo1cXP0yuIguQPvURdOmjE4EqTkJiDgYvqu+ZeL6PIfUedMqOIouLtV9Key2oj7EoCKMZbh8UbGmDN8raP3k7zcKAGMhYbs9nxJh6nST71VLKQhm1mwZfnQfTm4y9gaUlQFKoa+ecGv/jux4cmyVFNe5pkPkto2RAvnovUuynVzsU6tYFrhjiqqmYA3p9mH3JoQh29hsxMgwPcHBeTDHkVxQbI41HRxdZi9QXUiQsd0qv5DNNZLgk2PXzdYPkWaTcKd3yyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NJJFY6hYgfpPLoX7W5+fl1W4cpHjk669sUfN4cB1eO4=; b=Gl2XsCoFZrKOoBk5spBRrAEktn0fQa577mT5Rnth1Dk6kGV6ksK+avl2viwFwl6P3ElZKsl4MZuSCjWG0Yozb7PPGsBMiGPoAV66uCe1qLMhGzmVEVXzck/Xz0t6QUTnanPEkiFjgKxhZ3beKo16vF2NheRMJ6bhGgVuFTtnB8bOB154N+daxkCHO0+ssF0yJRvuuOxUvkLxmW7astb0J5SDjZLss9JVoqRpjtwmLQi4WaJ6YNNIx4FTmxIIfBYZDyhi/zwA53l6LH8Dp3moRFyrno13sf/oxRL7WEHjPR0vojwTMy2pM4dkwqYi3g/lL2WzH917ZCi1DjHtq74zmA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NJJFY6hYgfpPLoX7W5+fl1W4cpHjk669sUfN4cB1eO4=; b=r9cAfSWtjaYlWbFUtsDO0rIgcMGtWDSdnzVedeNJEcmPFJl/IYnCluiuWlueG4j33u5CQPjW7RYLwsy12Ci2xKnsJS/2hO0onT31j2TYhfCAlQwX+Pc2bsjinKeyS7SL1+5FJ8Us0VrDyXJI+3Quwxn6CYvn+ZwBuJKpYbOoCHfO6CdOUQYO9+nIrML2Be7+U8Dke3CJu+gm3uTXEPf1o0Et9ZMwf0cAt67UhvqZJba78DkPSw1535c8TIuQjvSFB8+H4VyQluEPgoEnJ0KpVz/b1WINzX+S+YyZAEmotC26dZYasfnh35iu4iUvuRy+MNDhaeU+/DrkpmkxpCa8Bw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 5 Jan 2023 12:12:02 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: [PATCH 2/2] x86: split .fixup section with new enough gas Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0078.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM0PR04MB6929:EE_ X-MS-Office365-Filtering-Correlation-Id: c7427232-bf02-40f8-a2bf-08daef0dacc1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lC9rxu0veaq+jiBLxYuaD8heqYt7pi8bkfVQSigOj/ZB8x23c/gswtkVkwOdqcS6xqwV/gAh1kWxUHwlM3uUgDbLqLz+JGEm/g/JxObZ7TIau6nr95lUV8UQIf0WMfcU+pdlLqHrNj92ggQVkdGa4x/H4ZpW8S1w0alnxaBMTsAJ8XBThlATmdAj0cIxhTyu/tAiuqHNf2Xh7uO5oNjWitCezEXYmb14uU/OC7X92ppMjEyh19THOKQDxWOCtkgUrwexCMb0xsrNSF8namc2Hgm20DFUoLB9QzvEa4l0QSO6mwcF41zG+wJCPD/MmnUzDuiC77Adev8Cbvfn3rRKuGmoYcUsC8X27yp6Zru/UZd0ZSSANf9DkVYzgrOE0mQ/ow45omhfbI2sxhaWoM9EGlgO1b59+dgRigLdqKnee+8MVZ9bT/R9KG5FCOPGq1xk439o1l6h3Tf86f8MIUOf81SWZ33MDUIeyzTGBrCM1u4t663Kzf58YWjTQDVJyKa+TS/0Wp2gQRS3mGZ2DgGZmZ6AZsg/PczsKKD/JaPjfpp3J6HEa7gd6qqcL1KPj6FQ+vB6ThMh6G0Rp6BOjj73392UZpxXGeF0NwccMGvczpAVyJdZze3b8ZagE05rf8rmsLoLc+J5HwBkHisSG2tBthfhr89wrVHC/Q+SjM+ogZB12ybIxOiUuC1pGMKyUhPvZlwKb9a/gs5i6s7QRR0dXM2mXNCPIjyBCWV7i8gBwE4+07FJccqGZgj18OprApUe X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(346002)(366004)(396003)(376002)(136003)(451199015)(31686004)(5660300002)(316002)(8676002)(54906003)(6916009)(2906002)(41300700001)(4326008)(66556008)(66476007)(8936002)(66946007)(6486002)(6506007)(478600001)(36756003)(83380400001)(186003)(86362001)(26005)(2616005)(6512007)(31696002)(38100700002)(142923001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cW5FME1OQ3FuMkdlOGNwY2c2MWFQNW8yUkxaMU1HWG5sRDJJK2lFblROaTBr?= =?utf-8?B?ZVVnb3duakVkRDFLSitlNlVkenVTcVZlR0UxdzQyUkdBRU1rZEM2eFVKUVZy?= =?utf-8?B?NXB3QUIwZjVnQ3ZnUjRORVhMSXVCdDFMSkRQSkdOaWZ6azlzc3NyOTFoaVc3?= =?utf-8?B?SE9keEppeG1wRHFRTkxDMXRkMkpYZ1I3dlRSTEQ4NWZGQWJpeFZlVGI3QWtj?= =?utf-8?B?bGVRbEpjc2hvVGNmRGtheFpiUmdoSVdTYjgxeEJnZGxyeWJGY01DbkdqVDF3?= =?utf-8?B?amkzbEQ2UHEzTE9xTkYwdkZ4QzJqN3o5S3FySmFkSFBZQzlTUWtUaVFPUnFw?= =?utf-8?B?VlcyakYzWHpVUVgzUDc1dTMzMTVtRzRxalNFV0RraURjOHdCcm0rY2FuN0hO?= =?utf-8?B?dFRWU1hKeHZmejlNY0ptdmJaZHFUWHVFanZVYkh0eEZnNmVyR3owenMxUEtt?= =?utf-8?B?Mno0dnM3M21QbXZxZXA2Q2JEVzd0NUwyWGQ5dGxuSnJ5UDBRbmxDTzBZNHJk?= =?utf-8?B?eSticjlBdTBXTGM4cFZzM0RzSEJlTnRCT0tVeVNWWTEwU0ZQRHA4ajY5M3lE?= =?utf-8?B?Yi9vS2tYQzZJbW9XZjlNcUtrLzlwQ3ZUZ1VWY0ZMeWJpa2FQcFp6NTVhL3Fx?= =?utf-8?B?RmdxTWZSVit4V2FFdVVncFViN1ZKbnU0RGVJKzFKSC93M1Bya0pTM241ZU1O?= =?utf-8?B?c2IxRVF4ejhWWUVLem9VU005b1l4bWpYbWhmZjZ4ekVFSS8vRjZRU3FZcFMz?= =?utf-8?B?KzF2VmNId09CdEgwWkdXQnJBc3hGeml6OHJGelZ0dDhFRkZrb2JXT3hJK28w?= =?utf-8?B?NmU1bVlCbUtTWkdjdEFGMDZmTDhLUnVxVnc3L2FIQ1NPU2JUOFNCSFhUTDQw?= =?utf-8?B?MUEvN015YlNPRlgxZlNQZDZua0NaTG0xajlGMzJxNVBPZWVjQndNT21RRmxu?= =?utf-8?B?MEgrRVZnamNLcThlR3BzWDg4VC9Cc3Q2dUVYSnorK3lFQWtCOG5JcGdoNEc3?= =?utf-8?B?SlM4YnpTTmZWOVdDV2tWU2l2RkpvaDlhS0lSR3orMXZjb1A2bGxGbkplU2ZH?= =?utf-8?B?V2E2QlhqNGhDa3Uwd0tSOHpnazJ5YkhpNlRpOUd6TDQxeFllWUdud3UrRnVm?= =?utf-8?B?eXBDbzllOWs3RWZLZ2NycGlMLzBNL215Uk9vVnpyWHphelpnWmVCSDZiUVJp?= =?utf-8?B?Z3lCMUZXNDgyRGlFUTBwYzd4bjliemFyYWxsM0xSYWFsU0FTNUdVNjU1Mk16?= =?utf-8?B?WHF1ZGUzV1Q2bk1mTWFwakZwZEV1L2Q0ZnNTNG5Fa2gxdUFjZzJucDJoVkRw?= =?utf-8?B?N0ZWZ1YvYjd0K3NmYVl0L2I1SkNCQzdmYm9XZDlDNjNRdFUzaGF4U24zU0p2?= =?utf-8?B?OE9ZUVlYZ1I3Nmx1a1VIVWtUSnI4N0I1Tk94U0MrN1JoTGNVNzc5TzRXbEpV?= =?utf-8?B?YmUzbGd3MkhHN0J1SWpJazJ0R2FwUXNRWWRqaUczSWxjRmx3SlVSYXdZcm9O?= =?utf-8?B?ODlzWDFYV3hxQzhwanFuQWdNNkVDMUF5TkNnZXFOSkUrRkFPbDJHRW53OThG?= =?utf-8?B?cXVJa0ZwLzVvdDZkdFBQNk5uREZrcytEeVRSWjYwUkh5cFNGN2xPVG4wamhN?= =?utf-8?B?ZkZLQngzWmRxU2VuV3NoSlVQM1lKbUhHK2lTa2dIM3U1NXE2bkNMTmtpbDZX?= =?utf-8?B?dThLajdzeVRRY2hFRnU1cmR6VzZtcFF1Y1dNLzdZd0Q4d0p0blZnekk0amhu?= =?utf-8?B?Qnh4WnZrVWFKeE4vR0JJT3YvbUdSRE5UU01DajFzR2xNVkR3bC9ZTWxJOERP?= =?utf-8?B?VGs3c3N3eGwvVDJvZk96L0dCWlkyOUxMTzV4Mk5iVlJYa042djljMmpxLzBP?= =?utf-8?B?Z2t4bHlFaERQcVFuRjE4NTNrWVU5SzI2TmV1TzlzdmQycDdNem1neFFHcGRm?= =?utf-8?B?dFAzUjBIYTlsRXV5LzJoTlVRem5BVG1Jb3ZCVHFFd2tOREpWQzdRdlhvSVVw?= =?utf-8?B?dkhtbEgydWY3ZWFKTXcrYmVpcXBSV2NNbm9rNG1LazFlQUhGYnE1c2JQa2U5?= =?utf-8?B?YzBkaGs1SnZyaS9FbUhLWS8rWnZ5M2h5VnF4dGxrNGlVVE5xdzl6cDFOZmg5?= =?utf-8?Q?kKn3C+plDyUlzhPCa6SC7RhUZ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c7427232-bf02-40f8-a2bf-08daef0dacc1 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2023 11:12:04.0674 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HYs/zNKJahfOc5qL3EDW2ibHQ07ZE6zKwKZrrrrslZYiriAQh7Hseqoq2oJI8IdzYcnk0/MUltBfNdqG5klAqQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6929 GNU as, as of version 2.26, allows deriving the name of a section to switch to from the present section's name. For the replacement to occur --sectname-subst needs to be passed to the assembler. Signed-off-by: Jan Beulich --- Similarly (and perhaps of more interest) we could split .ex_table, allowing to reduce the number of entries to search through post-init. --- a/Config.mk +++ b/Config.mk @@ -98,7 +98,7 @@ cc-option = $(shell if test -z "`echo 'v # Usage: $(call cc-option-add CFLAGS,CC,-march=winchip-c6) cc-option-add = $(eval $(call cc-option-add-closure,$(1),$(2),$(3))) define cc-option-add-closure - ifneq ($$(call cc-option,$$($(2)),$(3),n),n) + ifneq ($$(call cc-option,$$($(2)),$(firstword $(3)),n),n) $(1) += $(3) endif endef --- a/xen/arch/x86/arch.mk +++ b/xen/arch/x86/arch.mk @@ -34,6 +34,9 @@ $(call as-option-add,CFLAGS,CC,\ $(call as-option-add,CFLAGS,CC,\ ".L1: .L2: .nops (.L2 - .L1)$$(comma)9",-DHAVE_AS_NOPS_DIRECTIVE) +# Check to see whether the assmbler supports the --sectname-subst option. +$(call cc-option-add,CFLAGS,CC,-Wa$$(comma)--sectname-subst -DHAVE_AS_SECTNAME_SUBST) + CFLAGS += -mno-red-zone -fpic # Xen doesn't use MMX or SSE interally. If the compiler supports it, also skip --- a/xen/arch/x86/include/asm/asm_defns.h +++ b/xen/arch/x86/include/asm/asm_defns.h @@ -81,10 +81,18 @@ register unsigned long current_stack_poi /* Exception recovery code section */ #ifdef __ASSEMBLY__ -# define _ASM_FIXUP .pushsection .fixup, "ax", @progbits +# ifdef HAVE_AS_SECTNAME_SUBST +# define _ASM_FIXUP .pushsection .fixup%S, "ax", @progbits +# else +# define _ASM_FIXUP .pushsection .fixup, "ax", @progbits +# endif # define _ASM_FIXUP_END .popsection #else -# define _ASM_FIXUP " .pushsection .fixup, \"ax\", @progbits" +# ifdef HAVE_AS_SECTNAME_SUBST +# define _ASM_FIXUP " .pushsection .fixup%%S, \"ax\", @progbits" +# else +# define _ASM_FIXUP " .pushsection .fixup, \"ax\", @progbits" +# endif # define _ASM_FIXUP_END " .popsection" #endif --- a/xen/arch/x86/xen.lds.S +++ b/xen/arch/x86/xen.lds.S @@ -103,6 +103,12 @@ SECTIONS *(.text.__x86_indirect_thunk_*) *(.fixup) + *(.fixup.text) + *(.fixup.text.cold) + *(.fixup.text.unlikely .fixup.text.*_unlikely .fixup.text.unlikely.*) +#ifdef CONFIG_CC_SPLIT_SECTIONS + *(.fixup.text.*) +#endif *(.gnu.warning) _etext = .; /* End of text section */ } PHDR(text) = 0x9090 @@ -215,6 +221,8 @@ SECTIONS _sinittext = .; *(.init.text) *(.text.startup) + *(.fixup.init.text) + *(.fixup.text.startup) _einittext = .; /* * Here are the replacement instructions. The linker sticks them --- a/xen/include/xen/xen.lds.h +++ b/xen/include/xen/xen.lds.h @@ -89,7 +89,9 @@ #define DISCARD_SECTIONS \ /DISCARD/ : { \ *(.text.exit) \ + *(.fixup.text.exit) \ *(.exit.text) \ + *(.fixup.exit.text) \ *(.exit.data) \ *(.exitcall.exit) \ *(.discard) \ From xen-devel-bounces@lists.xenproject.org Thu Jan 05 11:19:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 11:19:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471830.731843 (Exim 4.92) (envelope-from ) id 1pDOHc-0001jc-R1; Thu, 05 Jan 2023 11:19:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471830.731843; Thu, 05 Jan 2023 11:19:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDOHc-0001jV-Nr; Thu, 05 Jan 2023 11:19:40 +0000 Received: by outflank-mailman (input) for mailman id 471830; Thu, 05 Jan 2023 11:19:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDOHb-0001jP-Hi for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 11:19:39 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDOHb-0008PS-D9; Thu, 05 Jan 2023 11:19:39 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=[192.168.4.62]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pDOHb-0003qE-5I; Thu, 05 Jan 2023 11:19:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:To:Subject:MIME-Version:Date:Message-ID; bh=oeDOelHc6GbkzzkkG0rlTlPgpKRaqk6cNmUOAcKglGk=; b=fHJKWoOV3BY2w4ouLf4l9dWsaX UUTWg8ajpy6rWd4TaImZpjnM0hbEnMI82VG0i1n8SBXwLzuzr4R71AzVH4bekXwWKXyChDovQnVlL /1f6XmQdXHjGZrGs6SSnAFKuvXRW64fckW9n8/BBiKuGVY0oz6mhQu7tSklkFl3dILSc=; Message-ID: Date: Thu, 5 Jan 2023 11:19:37 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2] xen/arm: Add 0x prefix when printing memory size in construct_domU To: Ayan Kumar Halder , xen-devel@lists.xenproject.org References: <20230103102519.26224-1-michal.orzel@amd.com> <1264e5cc-1960-95d3-5ecb-d6f23d194aa4@xen.org> <29460d07-cd43-7415-7125-6ed01f3c2920@amd.com> Content-Language: en-US From: Julien Grall In-Reply-To: <29460d07-cd43-7415-7125-6ed01f3c2920@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 05/01/2023 09:59, Ayan Kumar Halder wrote: > Hi Julien, Hi, > I have a clarification. > > On 05/01/2023 09:26, Julien Grall wrote: >> CAUTION: This message has originated from an External Source. Please >> use proper judgment and caution when opening attachments, clicking >> links, or responding to this email. >> >> >> Hi Stefano, >> >> On 04/01/2023 23:47, Stefano Stabellini wrote: >>> On Tue, 3 Jan 2023, Michal Orzel wrote: >>>> Printing memory size in hex without 0x prefix can be misleading, so >>>> add it. Also, take the opportunity to adhere to 80 chars line length >>>> limit by moving the printk arguments to the next line. >>>> >>>> Signed-off-by: Michal Orzel >>>> --- >>>> Changes in v2: >>>>   - was: "Print memory size in decimal in construct_domU" >>>>   - stick to hex but add a 0x prefix >>>>   - adhere to 80 chars line length limit >>> >>> Honestly I prefer decimal but also hex is fine. >> >> decimal is perfect for very small values, but as we print the amount in >> KB it will become a big mess. Here some examples (decimal first, then >> hexadecimal): >> >>   512MB: 524288 vs 0x80000 >>   555MB: 568320 vs 0x8ac00 >>   1GB: 1048576 vs 0x100000 >>   512GB: 536870912 vs 0x20000000 >>   1TB: 1073741824 vs 0x40000000 >> >> For power of two values, you might be able to find your way with >> decimal. It is more difficult for non power of two unless you have a >> calculator in hand. >> >> The other option I suggested in v1 is to print the amount in KB/GB/MB. >> Would that be better? >> >> That said, to be honest, I am not entirely sure why we are actually >> printing in KB. It would seems strange that someone would create a guest >> with memory not aligned to 1MB. > > For RTOS (Zephyr and FreeRTOS), it should be possible for guests to have > memory less than 1 MB, isn't it ? Yes. So does XTF. But most of the users are likely going allocate at least 1MB (or even 2MB to reduce the TLB pressure). So it would be better to print the value in a way that is more meaningful for the majority of the users. >> So I would consider to check the size is 1MB-aligned and then print the I will retract my suggestion to check the size. There are technically no restriction to run a guest with a size not aligned to 1MB. Although, it would still seem strange. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Jan 05 12:02:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 12:02:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471846.731854 (Exim 4.92) (envelope-from ) id 1pDOwU-00072F-IO; Thu, 05 Jan 2023 12:01:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471846.731854; Thu, 05 Jan 2023 12:01:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDOwU-000728-Dt; Thu, 05 Jan 2023 12:01:54 +0000 Received: by outflank-mailman (input) for mailman id 471846; Thu, 05 Jan 2023 12:01:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDOwT-0006u7-2X for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 12:01:53 +0000 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [2a00:1450:4864:20::334]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bdc2f18e-8cf0-11ed-91b6-6bf2151ebd3b; Thu, 05 Jan 2023 13:01:52 +0100 (CET) Received: by mail-wm1-x334.google.com with SMTP id ja17so27834038wmb.3 for ; Thu, 05 Jan 2023 04:01:52 -0800 (PST) Received: from fedora.. ([195.234.76.149]) by smtp.gmail.com with ESMTPSA id x5-20020a05600c21c500b003d9b89a39b2sm2159826wmj.10.2023.01.05.04.01.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Jan 2023 04:01:51 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bdc2f18e-8cf0-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=SlLZPNoeJrg9cCvwh4LLybSVlr8nbBmVdnfp1y+ineg=; b=hzRcx6YBiRcm4FokAjkbrcKpadrRq2GwCMqX7mJssJXf+av4F1cwWTYDYof9ohOX0E QHgcn4c/eLYPFWKqfhCqQc+Ykp9kePrrxl/AMqDFaoZPULpGq7mIeKsHEl7ro1P+PGUK FGMzNL0ZvmJgpvRNdSJ75CaQteR7AZ1J/OjvyNObec5xt56Syz/1MpfyGmiy7XMM9kPO HUrS2E7ShbrxBzPhl3XVT6V1ojlxFDAM/wBuYC8cGNl4kLeGot/MhWuq+AKbsm0kgoGB Xzv3Wg95Qr2kIrKs7MjsTN2v9TSS5/AT/PbnN0VO9RGTyn2gQJLJrW4PjeuEwKmmqqsp /fEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SlLZPNoeJrg9cCvwh4LLybSVlr8nbBmVdnfp1y+ineg=; b=yyAy/80HCFbkys9mSLXzkCL7lOle4CeiV8tGsFiVloqW+XC35tCWBDqTqiRkWU4BZg FaJJts5iLfShXLD4NtwTklyo12V0L/Emz9pqdGXoG7wk4o2QpLsOkdeW+LN0PvOQ0Krb DqbF1lcNwrbhAy6AzdEd7MOWS7rCyvvxUzQ8TEkIE4ytErb7gU65VAizOUJCUvwR+GZs KYXWxFOLFFJcN7Q35p06vxpl11gyIoQFRyGASXgEpErC0O5IwM2Zhe+DPWGaVQosvzil QBX433OvGQqswA4YEbo1SfamMLsID95lYsOpIt2hfNXhvIsC1JLVJAQE3T4LOhYGON83 lVGw== X-Gm-Message-State: AFqh2kpYZajz9b7jXzsZ6Q26iqiUceudNc86bSeyRnaX2SqP9N1D/and EmKhip8HAwLwcGugU1s/n6TOc0C6s8bQHab+ X-Google-Smtp-Source: AMrXdXvODMR5TZzDvOc65KDrVwjTNQu+GioNqH2BQd8eEEciG1Bvmi3YA5DM+yUlGniuo0fV8xbKIA== X-Received: by 2002:a1c:7c0f:0:b0:3d5:816e:2fb2 with SMTP id x15-20020a1c7c0f000000b003d5816e2fb2mr39008747wmc.14.1672920111508; Thu, 05 Jan 2023 04:01:51 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis , Doug Goldstein , Stefano Stabellini , Julien Grall , Anthony PERARD , Andrew Cooper , Gianluca Guida Subject: [PATCH v4 0/2] Add minimal RISC-V Xen build and build testing Date: Thu, 5 Jan 2023 14:01:44 +0200 Message-Id: X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The patch series introduces the following: - provide a minimal amount of changes to add initial RISC-V support to make Xen binary buildable and runnable for RISC-V architecture which can be used for future development and testing. - add RISC-V 64 cross-compile build jobs to check if any new changes break RISC-V build. Changes in V4: - Rebase on mainline 'staging'. - Code style fixes and commit message updates. - Minor changes of riscv/Makefile and build.yaml Changes in V3: - Remove include of from head.S. Changes in V2: - Remove the patch "automation: add cross-compiler support for the build script" because it was reworked as a part of the patch series "CI: Fixes/cleanup in preparation for RISCV". - Remove the patch "automation: add python3 package for riscv64.dockerfile" because it is not necessary for RISCV Xen binary build now. - Rework the patch "arch/riscv: initial RISC-V support to build/run minimal Xen" according to the comments about v1 of the patch series. - Add HYPERVISOR_ONLY to RISCV jobs in build.yaml after rebasing on "CI: Fixes/cleanup in preparation for RISCV" patch series. Oleksii Kurochko (2): arch/riscv: initial RISC-V support to build/run minimal Xen automation: add RISC-V 64 cross-build tests for Xen automation/gitlab-ci/build.yaml | 56 ++++++++++ xen/arch/riscv/Makefile | 14 +++ xen/arch/riscv/arch.mk | 4 + xen/arch/riscv/include/asm/config.h | 9 +- xen/arch/riscv/riscv64/Makefile | 2 +- xen/arch/riscv/riscv64/head.S | 4 +- xen/arch/riscv/xen.lds.S | 158 ++++++++++++++++++++++++++++ 7 files changed, 242 insertions(+), 5 deletions(-) create mode 100644 xen/arch/riscv/xen.lds.S -- 2.38.1 From xen-devel-bounces@lists.xenproject.org Thu Jan 05 12:02:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 12:02:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471847.731866 (Exim 4.92) (envelope-from ) id 1pDOwW-0007Hh-QZ; Thu, 05 Jan 2023 12:01:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471847.731866; Thu, 05 Jan 2023 12:01:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDOwW-0007Ha-L9; Thu, 05 Jan 2023 12:01:56 +0000 Received: by outflank-mailman (input) for mailman id 471847; Thu, 05 Jan 2023 12:01:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDOwU-0006u7-I6 for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 12:01:54 +0000 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [2a00:1450:4864:20::32a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id be606e7b-8cf0-11ed-91b6-6bf2151ebd3b; Thu, 05 Jan 2023 13:01:53 +0100 (CET) Received: by mail-wm1-x32a.google.com with SMTP id ay40so27872133wmb.2 for ; Thu, 05 Jan 2023 04:01:53 -0800 (PST) Received: from fedora.. ([195.234.76.149]) by smtp.gmail.com with ESMTPSA id x5-20020a05600c21c500b003d9b89a39b2sm2159826wmj.10.2023.01.05.04.01.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Jan 2023 04:01:52 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: be606e7b-8cf0-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nOuybka6m9Zk5Om7Z7pMNEOSvOvsqAFonp5yEXrOY74=; b=RHgAudbgayymqxO19Hdfk4rKzq5iyVG5oIOYA3urYRNss2gMQl40VGFGFfSJqpa7HV XwOcGcl4fW+B7VlnUKLsQF7Vg8ydupY/GwDhgsJYrxysloDOxwQnAEQkt8p1Q2ONv3/A TRVUeHHk54dna433b0q2o47TZDcSpsB2D+7poTLJbv34nL8IAcgnpg3rJh/KJgMvZnTP e1ADeReuU2xwDDRqBOcplSll1FGDcFan+2gbM5UOaazjr4DzLj9xD/hY8GW0C4ICmJMh bUBbxrfU4VK8I68HHFJuImfeLDjwVOOwC/CqbQzQfBiEcY7xOTmI2LCzTboghuDznAue IwdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nOuybka6m9Zk5Om7Z7pMNEOSvOvsqAFonp5yEXrOY74=; b=ftYERKJONKAtpwzXSinemlbCW5c6y0QDZyxRXKzhbI+U+ysSIwsxbtyXlbYgQ+WbNO SuVq3gwjgYcE8gUbZah4G+Uk0mJeQJwUGJ9zIq51wWIG6Scxw+ju5n0ycOoYv6njok/d 7iA7Wcz/MetjwqY50MAWtz5PwizByY6gg+eLWR1DJxq20ec2o7pZh1kUplAcz7bNXQmW ToPOKQm2285YP8ylC7+XDOvTKar8odmdKIu8KYqbTnx+NlzI/SZyj+Nf4Ritv5E3wisz N31n8P8g57Mws54W+s6dJBHq0harEssA7WIacVJBk9qgtdSW0YTJoNsLo1NlyceX73Yq lH6Q== X-Gm-Message-State: AFqh2koNfgmh3hGoeZnsJYcffl17khSnr/Wc6RZmpwEydDN2JoiokfDt 7mRhhgkhW6qj49XVonJuzZ2uypGSldGoHNMN X-Google-Smtp-Source: AMrXdXsj8/JreMZze0R9CwSolXzrA+C8W9QYfrFquPaqB8brVIc7qbccQ7ISl+IDm15WZcdwGEq9eA== X-Received: by 2002:a05:600c:1c27:b0:3cf:a83c:184a with SMTP id j39-20020a05600c1c2700b003cfa83c184amr37045215wms.24.1672920112580; Thu, 05 Jan 2023 04:01:52 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis , Julien Grall , Anthony PERARD , Andrew Cooper , Stefano Stabellini , Gianluca Guida Subject: [PATCH v4 1/2] arch/riscv: initial RISC-V support to build/run minimal Xen Date: Thu, 5 Jan 2023 14:01:45 +0200 Message-Id: X-Mailer: git-send-email 2.38.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The patch provides a minimal amount of changes to start build and run minimal Xen binary at GitLab CI&CD that will allow continuous checking of the build status of RISC-V Xen. Except introduction of new files the following changes were done: * Redefinition of ALIGN define from '.align 2' to '.align 4'. '.align 2' was incorrect choice done previously * ALL_OBJ-y and ALL_LIBS-y were temporary overwritted to produce a minimal hypervisor image otherwise it will be required to push huge amount of headers and stubs for common, drivers, libs etc which aren't necessary for now. * Section changed from .text to .text.header for start function to make it the first one executed. * Rework riscv64/Makefile logic to rebase over changes since the first RISC-V commit. RISC-V Xen can be built by the following instructions: $ CONTAINER=riscv64 ./automation/scripts/containerize \ make XEN_TARGET_ARCH=riscv64 -C xen tiny64_defconfig $ CONTAINER=riscv64 ./automation/scripts/containerize \ make XEN_TARGET_ARCH=riscv64 -C xen build RISC-V Xen can be run as: $ qemu-system-riscv64 -M virt -smp 1 -nographic -m 2g \ -kernel xen/xen To run in debug mode should be done the following instructions: $ qemu-system-riscv64 -M virt -smp 1 -nographic -m 2g \ -kernel xen/xen -s -S # In separate terminal: $ riscv64-buildroot-linux-gnu-gdb $ target remote :1234 $ add-symbol-file /xen/xen-syms 0x80200000 $ hb *0x80200000 $ c # it should stop at instruction j 0x80200000 Signed-off-by: Oleksii Kurochko --- Changes in V4: - Remove clean-files target from Makefile as ${TARGET-syms} was simplifed and there is no any sense for clean-files target for now. - Update the commit message. - Code style fixes. --- Changes in V3: - Remove include of from head.S --- Changes in V2: - Update commit message: - Add explanation why ALIGN define was changed. - Add explanation why section of 'start' function was changed. - Rework xen.lds.S linker script. It is mostly based on ARM except ARM-specific sections which have been removed. - Rework in riscv64/Makefile rule $(TARGET)-syms - Remove asm/types.h header as after reworking of riscv64/Makefile it is not needed now. - Remove unneeded define SYMBOLS_DUMMY_OBJ. --- xen/arch/riscv/Makefile | 14 +++ xen/arch/riscv/arch.mk | 4 + xen/arch/riscv/include/asm/config.h | 9 +- xen/arch/riscv/riscv64/Makefile | 2 +- xen/arch/riscv/riscv64/head.S | 4 +- xen/arch/riscv/xen.lds.S | 158 ++++++++++++++++++++++++++++ 6 files changed, 186 insertions(+), 5 deletions(-) create mode 100644 xen/arch/riscv/xen.lds.S diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile index 942e4ffbc1..248f2cbb3e 100644 --- a/xen/arch/riscv/Makefile +++ b/xen/arch/riscv/Makefile @@ -1,2 +1,16 @@ +obj-$(CONFIG_RISCV_64) += riscv64/ + +$(TARGET): $(TARGET)-syms + $(OBJCOPY) -O binary -S $< $@ + +$(TARGET)-syms: $(objtree)/prelink.o $(obj)/xen.lds + $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< $(build_id_linker) -o $@ + $(NM) -pa --format=sysv $(@D)/$(@F) \ + | $(objtree)/tools/symbols --all-symbols --xensyms --sysv --sort \ + >$(@D)/$(@F).map + +$(obj)/xen.lds: $(src)/xen.lds.S FORCE + $(call if_changed_dep,cpp_lds_S) + .PHONY: include include: diff --git a/xen/arch/riscv/arch.mk b/xen/arch/riscv/arch.mk index ae8fe9dec7..012dc677c3 100644 --- a/xen/arch/riscv/arch.mk +++ b/xen/arch/riscv/arch.mk @@ -11,3 +11,7 @@ riscv-march-$(CONFIG_RISCV_ISA_C) := $(riscv-march-y)c # -mcmodel=medlow would force Xen into the lower half. CFLAGS += -march=$(riscv-march-y) -mstrict-align -mcmodel=medany + +# TODO: Drop override when more of the build is working +override ALL_OBJS-y = arch/$(TARGET_ARCH)/built_in.o +override ALL_LIBS-y = diff --git a/xen/arch/riscv/include/asm/config.h b/xen/arch/riscv/include/asm/config.h index e2ae21de61..c6f9e230d7 100644 --- a/xen/arch/riscv/include/asm/config.h +++ b/xen/arch/riscv/include/asm/config.h @@ -1,6 +1,9 @@ #ifndef __RISCV_CONFIG_H__ #define __RISCV_CONFIG_H__ +#include +#include + #if defined(CONFIG_RISCV_64) # define LONG_BYTEORDER 3 # define ELFSIZE 64 @@ -28,7 +31,7 @@ /* Linkage for RISCV */ #ifdef __ASSEMBLY__ -#define ALIGN .align 2 +#define ALIGN .align 4 #define ENTRY(name) \ .globl name; \ @@ -36,6 +39,10 @@ name: #endif +#define XEN_VIRT_START _AT(UL, 0x00200000) + +#define SMP_CACHE_BYTES (1 << 6) + #endif /* __RISCV_CONFIG_H__ */ /* * Local variables: diff --git a/xen/arch/riscv/riscv64/Makefile b/xen/arch/riscv/riscv64/Makefile index 15a4a65f66..3340058c08 100644 --- a/xen/arch/riscv/riscv64/Makefile +++ b/xen/arch/riscv/riscv64/Makefile @@ -1 +1 @@ -extra-y += head.o +obj-y += head.o diff --git a/xen/arch/riscv/riscv64/head.S b/xen/arch/riscv/riscv64/head.S index 0dbc27ba75..990edb70a0 100644 --- a/xen/arch/riscv/riscv64/head.S +++ b/xen/arch/riscv/riscv64/head.S @@ -1,6 +1,4 @@ -#include - - .text + .section .text.header, "ax", %progbits ENTRY(start) j start diff --git a/xen/arch/riscv/xen.lds.S b/xen/arch/riscv/xen.lds.S new file mode 100644 index 0000000000..ca57cce75c --- /dev/null +++ b/xen/arch/riscv/xen.lds.S @@ -0,0 +1,158 @@ +#include + +#undef ENTRY +#undef ALIGN + +OUTPUT_ARCH(riscv) +ENTRY(start) + +PHDRS +{ + text PT_LOAD ; +#if defined(BUILD_ID) + note PT_NOTE ; +#endif +} + +SECTIONS +{ + . = XEN_VIRT_START; + _start = .; + .text : { + _stext = .; /* Text section */ + *(.text.header) + + *(.text.cold) + *(.text.unlikely .text.*_unlikely .text.unlikely.*) + + *(.text) +#ifdef CONFIG_CC_SPLIT_SECTIONS + *(.text.*) +#endif + + *(.fixup) + *(.gnu.warning) + . = ALIGN(POINTER_ALIGN); + _etext = .; /* End of text section */ + } :text + + . = ALIGN(PAGE_SIZE); + .rodata : { + _srodata = .; /* Read-only data */ + *(.rodata) + *(.rodata.*) + *(.data.rel.ro) + *(.data.rel.ro.*) + + VPCI_ARRAY + + . = ALIGN(POINTER_ALIGN); + _erodata = .; /* End of read-only data */ + } :text + + #if defined(BUILD_ID) + . = ALIGN(4); + .note.gnu.build-id : { + __note_gnu_build_id_start = .; + *(.note.gnu.build-id) + __note_gnu_build_id_end = .; + } :note :text + #endif + _erodata = .; /* End of read-only data */ + + . = ALIGN(PAGE_SIZE); + .data.ro_after_init : { + __ro_after_init_start = .; + *(.data.ro_after_init) + . = ALIGN(PAGE_SIZE); + __ro_after_init_end = .; + } : text + + .data.read_mostly : { + *(.data.read_mostly) + } :text + + . = ALIGN(PAGE_SIZE); + .data : { /* Data */ + *(.data.page_aligned) + . = ALIGN(8); + __start_schedulers_array = .; + *(.data.schedulers) + __end_schedulers_array = .; + + HYPFS_PARAM + + *(.data .data.*) + CONSTRUCTORS + } :text + + . = ALIGN(PAGE_SIZE); /* Init code and data */ + __init_begin = .; + .init.text : { + _sinittext = .; + *(.init.text) + _einittext = .; + . = ALIGN(PAGE_SIZE); /* Avoid mapping alt insns executable */ + } :text + . = ALIGN(PAGE_SIZE); + .init.data : { + *(.init.rodata) + *(.init.rodata.*) + + . = ALIGN(POINTER_ALIGN); + __setup_start = .; + *(.init.setup) + __setup_end = .; + + __initcall_start = .; + *(.initcallpresmp.init) + __presmp_initcall_end = .; + *(.initcall1.init) + __initcall_end = .; + + LOCK_PROFILE_DATA + + *(.init.data) + *(.init.data.rel) + *(.init.data.rel.*) + + . = ALIGN(8); + __ctors_start = .; + *(.ctors) + *(.init_array) + *(SORT(.init_array.*)) + __ctors_end = .; + } :text + . = ALIGN(POINTER_ALIGN); + __init_end = .; + + .bss : { /* BSS */ + __bss_start = .; + *(.bss.stack_aligned) + . = ALIGN(PAGE_SIZE); + *(.bss.page_aligned) + . = ALIGN(PAGE_SIZE); + __per_cpu_start = .; + *(.bss.percpu.page_aligned) + *(.bss.percpu) + . = ALIGN(SMP_CACHE_BYTES); + *(.bss.percpu.read_mostly) + . = ALIGN(SMP_CACHE_BYTES); + __per_cpu_data_end = .; + *(.bss .bss.*) + . = ALIGN(POINTER_ALIGN); + __bss_end = .; + } :text + _end = . ; + + /* Section for the device tree blob (if any). */ + .dtb : { *(.dtb) } :text + + DWARF2_DEBUG_SECTIONS + + DISCARD_SECTIONS + + STABS_DEBUG_SECTIONS + + ELF_DETAILS_SECTIONS +} -- 2.38.1 From xen-devel-bounces@lists.xenproject.org Thu Jan 05 12:02:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 12:02:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471848.731876 (Exim 4.92) (envelope-from ) id 1pDOwY-0007Xa-17; Thu, 05 Jan 2023 12:01:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471848.731876; Thu, 05 Jan 2023 12:01:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDOwX-0007XQ-TP; Thu, 05 Jan 2023 12:01:57 +0000 Received: by outflank-mailman (input) for mailman id 471848; Thu, 05 Jan 2023 12:01:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDOwW-00071H-ES for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 12:01:56 +0000 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [2a00:1450:4864:20::329]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bf1eaf22-8cf0-11ed-b8d0-410ff93cb8f0; Thu, 05 Jan 2023 13:01:54 +0100 (CET) Received: by mail-wm1-x329.google.com with SMTP id k26-20020a05600c1c9a00b003d972646a7dso1115571wms.5 for ; Thu, 05 Jan 2023 04:01:54 -0800 (PST) Received: from fedora.. ([195.234.76.149]) by smtp.gmail.com with ESMTPSA id x5-20020a05600c21c500b003d9b89a39b2sm2159826wmj.10.2023.01.05.04.01.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Jan 2023 04:01:53 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bf1eaf22-8cf0-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HEdE610llDLMp8O4DeyVRrmQCHhD1SKsTN47twxNoiI=; b=QFErldNCO2mrk5LL8zlYwXziQNBpOK+PphWvyCkUgYROLNMOs7C9I4qr/uDXg5kYhj 8kqTI4rfGYYbB32LMUgGcX/Sx5/zHTuOYtvFe5kGHfwxbkswYskCJmkRk3h2RF4G3LfN A6gNjbSnsFpr7RValUIU12j34ckg6WaXbdMa0R0yZeeXPv24mhxvhY1avQsi5lGDKdLz H35Up31QgjmueDcNvKW+BIB9KjYx3MqtmyN8P/sqJLapiXBz0f4RTSy8YOkyTHcFXBWr O6LmVK76Ww0wRoiFONMqNSm3C2i539AjjvecNwt5f+LnsONlBxDAdkIhGJ7LHQjimAHe crrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HEdE610llDLMp8O4DeyVRrmQCHhD1SKsTN47twxNoiI=; b=c0waLa+KnFc3tPsXKrXG/AToea9LFdoLugrYQuOufxRqM7bQdhKfTZRqHLddlj8n9Y ZlAH2M5dqLKcejVX92vyz8wyZMiC6qAtHE6VzhY6eNbr4zSZySQA8DSi9w0H8sFg4sMm c1jMfHJhjHWktZJSQUuTwg1+mH1DWxoC4hjA5drJ5sKnrYZYumfAoQ15jSPbRVypBC3U MPkS/0jlVCPLy/BgOzK0YwkJePL9/mlCKSN7oUi18lOsV/2vHeTibFLkWq+igtwCvkME MYmN1xxkKjA/4u9pI+UCMg69q6WYgk8MB4xaPfTmDfcMQq2X2H4UflHgxgh8LtLSm9CE 1dJQ== X-Gm-Message-State: AFqh2krEUHOMb6CLH8JcQ3aQvAbx/urSTSS/IvhWKoriwrI7aeRmXcbl aO4caCaw1i3OQ8EIKotaLoQvrFI63mcV7zK+ X-Google-Smtp-Source: AMrXdXtCSkkQJPSIaON/PqlUvKP0j+OCC8GRjx3CUMUnB0kYwufcQ54q3I7Z7/HiR3oPi6kFNsMgNQ== X-Received: by 2002:a05:600c:3ac3:b0:3d1:cfcb:7d19 with SMTP id d3-20020a05600c3ac300b003d1cfcb7d19mr43668618wms.32.1672920113643; Thu, 05 Jan 2023 04:01:53 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Oleksii Kurochko , Doug Goldstein , Stefano Stabellini , Andrew Cooper , Gianluca Guida , Alistair Francis Subject: [PATCH v4 2/2] automation: add RISC-V 64 cross-build tests for Xen Date: Thu, 5 Jan 2023 14:01:46 +0200 Message-Id: <7d9bf454d056180376031aaf862963036a46d1e5.1672912316.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add build jobs to cross-compile Xen-only for RISC-V 64. Signed-off-by: Oleksii Kurochko Acked-by: Alistair Francis --- Changes in V4: - Add RISCV RANDCONFIG jobs - Remove unnecessary comments --- Changes in V2: - Add HYPERVISOR_ONLY to RISCV jobs because after rebase on top of the patch series "CI: Fixes/cleanup in preparation for RISCV" it is required to set HYPERVISOR_ONLY in build.yaml --- automation/gitlab-ci/build.yaml | 56 +++++++++++++++++++++++++++++++++ 1 file changed, 56 insertions(+) diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml index 43dbef8aba..6784974619 100644 --- a/automation/gitlab-ci/build.yaml +++ b/automation/gitlab-ci/build.yaml @@ -172,6 +172,33 @@ variables: <<: *gcc +.riscv64-cross-build-tmpl: + <<: *build + variables: + XEN_TARGET_ARCH: riscv64 + tags: + - x86_64 + +.riscv64-cross-build: + extends: .riscv64-cross-build-tmpl + variables: + debug: n + +.riscv64-cross-build-debug: + extends: .riscv64-cross-build-tmpl + variables: + debug: y + +.gcc-riscv64-cross-build: + extends: .riscv64-cross-build + variables: + <<: *gcc + +.gcc-riscv64-cross-build-debug: + extends: .riscv64-cross-build-debug + variables: + <<: *gcc + # Jobs below this line archlinux-gcc: @@ -619,6 +646,35 @@ alpine-3.12-gcc-debug-arm64-boot-cpupools: EXTRA_XEN_CONFIG: | CONFIG_BOOT_TIME_CPUPOOLS=y +# RISC-V 64 cross-build +riscv64-cross-gcc: + extends: .gcc-riscv64-cross-build + variables: + CONTAINER: archlinux:riscv64 + KBUILD_DEFCONFIG: tiny64_defconfig + HYPERVISOR_ONLY: y + +riscv64-cross-gcc-debug: + extends: .gcc-riscv64-cross-build-debug + variables: + CONTAINER: archlinux:riscv64 + KBUILD_DEFCONFIG: tiny64_defconfig + HYPERVISOR_ONLY: y + +riscv64-cross-gcc-randconfig: + extends: .gcc-riscv64-cross-build + variables: + CONTAINER: archlinux:riscv64 + KBUILD_DEFCONFIG: tiny64_defconfig + RANDCONFIG: y + +riscv64-cross-gcc-debug-randconfig: + extends: .gcc-riscv64-cross-build-debug + variables: + CONTAINER: archlinux:riscv64 + KBUILD_DEFCONFIG: tiny64_defconfig + RANDCONFIG: y + ## Test artifacts common .test-jobs-artifact-common: -- 2.38.1 From xen-devel-bounces@lists.xenproject.org Thu Jan 05 12:04:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 12:04:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471866.731887 (Exim 4.92) (envelope-from ) id 1pDOyw-0000Ge-Es; Thu, 05 Jan 2023 12:04:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471866.731887; Thu, 05 Jan 2023 12:04:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDOyw-0000GX-BR; Thu, 05 Jan 2023 12:04:26 +0000 Received: by outflank-mailman (input) for mailman id 471866; Thu, 05 Jan 2023 12:04:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDOyu-0000GR-Ob for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 12:04:24 +0000 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [2a00:1450:4864:20::430]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1804023e-8cf1-11ed-91b6-6bf2151ebd3b; Thu, 05 Jan 2023 13:04:23 +0100 (CET) Received: by mail-wr1-x430.google.com with SMTP id bn26so16422647wrb.0 for ; Thu, 05 Jan 2023 04:04:23 -0800 (PST) Received: from [192.168.0.145] ([195.234.76.149]) by smtp.gmail.com with ESMTPSA id u13-20020a5d468d000000b00275970a85f4sm34267278wrq.74.2023.01.05.04.04.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Jan 2023 04:04:22 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1804023e-8cf1-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=BJDrDvFPt6L3MK72KoH0Saq8Kzr+Mx5258nj+894ZnY=; b=U4fioNqQrhKU+OkSBh7GX0XZ4/AppZ6oWbH+gw5ezXws42D6Fbw6aX3ibvVeMdi8w+ pjfQE/YJECPRmQ7fOePqETTutf217by7GmfzlisFlXorhlBHSjyMFIPK6f43RI2AbCl2 KHP0+5mk8iMykygjMPTq1ih/UjxYBhA/ppL1Vm5L6cD60waefK+RK3WVarBsBDbw/h5v 1pI33DkHjuNXV3q+pECSdz2KvwK0OfcKJGqwJxP5Hv55iFUVGG0MQoo7dAnvdsMsVCOK jnL4Gc14z7vbsyBqNbWKrKrdwid40GM1kQ8q5y4ZM6WvkcHKZhJbrqpR2i8cScHLWTwt I/QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=BJDrDvFPt6L3MK72KoH0Saq8Kzr+Mx5258nj+894ZnY=; b=SRYsny3Nunh4HRnEZwJUlUZ+KvsuVI6SKRvRAYl5DaAQ5FqIKbt6+i80Q27foMOabd wuP2Ydo4S+p89UB3DS92pq4vkqS9OPFxcBhoHIOCJummwHtkBeysM+JXM+GjXLGblgwN LdIGOwO+Vh7PJXnAx8siwcNSgrWNoaQwKANEVLfvdzSMCSxdjgM42rOvD7n2/t1BbXe1 Ejtd1leeWvNObFXvQn0CNKh7csKrZ7xE7iAU5x0lv0POFf2tdLWAlEDCh+s7edydR4Ly 5IHxRI4WwEDp/gIQbTObpaAF1VH3hkclOH9ppWJ2fDT5lKgHiNcqZ+yRbkFar6AWet4I UyOw== X-Gm-Message-State: AFqh2kpIyIm8bOyHpinXEzjjdgfpzVvM4gMOXG0rCRwoqmdl7YHP9OGD fzjN+QB3b6j6yyKw53QallIyH1ppRrbCqrlB X-Google-Smtp-Source: AMrXdXvcUk2t/09+QmXNjOMtv1LqPJHVsHvnHbRAP0Da4oAbisBu6nLsTLvKEdiTipdIbJuEqSeF+A== X-Received: by 2002:a5d:4081:0:b0:27a:cc74:977c with SMTP id o1-20020a5d4081000000b0027acc74977cmr25261803wrp.70.1672920263074; Thu, 05 Jan 2023 04:04:23 -0800 (PST) Message-ID: <0b4f63ee0d1f72a0cf566364d8be0cdf06e9fc75.camel@gmail.com> Subject: Re: [PATCH v3 0/2] Add minimal RISC-V Xen build and build testing From: Oleksii To: xen-devel@lists.xenproject.org Cc: Bob Eshleman , Alistair Francis , Connor Davis , Doug Goldstein , Stefano Stabellini , Julien Grall , Anthony PERARD , Andrew Cooper , Gianluca Guida Date: Thu, 05 Jan 2023 14:04:21 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.1 (3.46.1-1.fc37) MIME-Version: 1.0 Sorry for flooding but please skip review of patch series v3 as I missed comments of Andrew so only v4 should be reviewed. On Thu, 2023-01-05 at 10:40 +0200, Oleksii Kurochko wrote: > The patch series introduces the following: > - provide a minimal amount of changes to add initial RISC-V support > =C2=A0 to make Xen binary buildable and runnable for RISC-V architecture > =C2=A0 which can be used for future development and testing. > - add RISC-V 64 cross-compile build jobs to check if any new changes > =C2=A0 break RISC-V build. >=20 > Changes in V3: > - Remove include of from head.S. >=20 > Changes in V2: > - Remove the patch "automation: add cross-compiler support > =C2=A0 for the build script" because it was reworked as a part of the > patch > =C2=A0 series "CI: Fixes/cleanup in preparation for RISCV". > - Remove the patch "automation: add python3 package for > riscv64.dockerfile" > =C2=A0 because it is not necessary for RISCV Xen binary build now. > - Rework the patch "arch/riscv: initial RISC-V support to build/run > =C2=A0 minimal Xen" according to the comments about v1 of the patch > series. > - Add HYPERVISOR_ONLY to RISCV jobs in build.yaml after rebasing on > =C2=A0 "CI: Fixes/cleanup in preparation for RISCV" patch series. >=20 > Oleksii Kurochko (2): > =C2=A0 arch/riscv: initial RISC-V support to build/run minimal Xen > =C2=A0 automation: add RISC-V 64 cross-build tests for Xen >=20 > =C2=A0automation/gitlab-ci/build.yaml=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 45 = ++++++++ > =C2=A0xen/arch/riscv/Makefile=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 16 +++ > =C2=A0xen/arch/riscv/arch.mk=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 4 + > =C2=A0xen/arch/riscv/include/asm/config.h |=C2=A0=C2=A0 9 +- > =C2=A0xen/arch/riscv/riscv64/Makefile=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2= =A0 2 +- > =C2=A0xen/arch/riscv/riscv64/head.S=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |= =C2=A0=C2=A0 4 +- > =C2=A0xen/arch/riscv/xen.lds.S=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 | 158 > ++++++++++++++++++++++++++++ > =C2=A07 files changed, 233 insertions(+), 5 deletions(-) > =C2=A0create mode 100644 xen/arch/riscv/xen.lds.S >=20 From xen-devel-bounces@lists.xenproject.org Thu Jan 05 12:04:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 12:04:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471867.731898 (Exim 4.92) (envelope-from ) id 1pDOz4-0000aS-Qj; Thu, 05 Jan 2023 12:04:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471867.731898; Thu, 05 Jan 2023 12:04:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDOz4-0000aG-Nb; Thu, 05 Jan 2023 12:04:34 +0000 Received: by outflank-mailman (input) for mailman id 471867; Thu, 05 Jan 2023 12:04:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDOz2-0000GR-KM for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 12:04:32 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1b70698f-8cf1-11ed-91b6-6bf2151ebd3b; Thu, 05 Jan 2023 13:04:31 +0100 (CET) Received: from mail-bn8nam11lp2168.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 05 Jan 2023 07:04:28 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by MN2PR03MB5295.namprd03.prod.outlook.com (2603:10b6:208:1e7::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 12:04:22 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 12:04:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1b70698f-8cf1-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1672920271; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=3ykmsFdGGmg1YLJtWbMR4ZNI61TRCFhCcyqvlK2ivpU=; b=ePd4g3rOTR8305ZimjzVPXebsbEdlPvVJ4Td49KNzhDejW7T8GzB8trL KpG0UZl1vEocGGu3rgorV8lkyVFa07mZit+UTjXjx2HyVltXXVn0agnol gLCfgYjCH+ZVwtaQ15O2YqL2jDUlyiks7VbbkG2elG5/dNELX9MZRiCiq Q=; X-IronPort-RemoteIP: 104.47.58.168 X-IronPort-MID: 91298111 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:9zD4u6PZFhHXXs3vrR2XlsFynXyQoLVcMsEvi/4bfWQNrUp20TEOm jAdWTiBO62NZWunKY12O4m//B9V7ZTUmt9kGgto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQA+KmU4YoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvzrRC9H5qyo42tB5gFmP5ingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0t1dBltTp fBEEmxOQTatosaYg7a/W8A506zPLOGzVG8ekldJ6GiASNwAEdXESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+PpxujaDpOBy+OGF3N79U9qGX8hK2G2fo XrL5T/RCRAGLt2PjzGC9xpAg8eexHmqCNtLTdVU8NZQsniX7EI2OCE6VFCCvfCHqFPnZ45Af hl8Fi0G6PJaGFaQZtv3UgC8oXWElgUBQNcWGOo/gCmdx6yR7wuHC2wsSj9adMdgpMIwXSYt1 FKCg5XuHzMHmKKRYWKQ8PGTtzzaESoIKW4PYwcUQA1D5MPsyLzflTrKR9dnVaSz3tv8HGipx yjQ9XZuwbIOkcQMyqO3u0jdhC6hrYTISQhz4RjLWmWi7UVyY4vNi5GU1GU3JM1odO6xJmRtd lBd8yRCxIji1a2wqRE= IronPort-HdrOrdr: A9a23:vXrQQqxj75MPpseGR4QcKrPwIr1zdoMgy1knxilNoH1uHvBw8v rEoB1173DJYVoqNk3I++rhBEDwexLhHPdOiOF6UItKNzOW21dAQrsSiLfK8nnNHDD/6/4Y9Y oISdkbNDQoNykZsfrH X-IronPort-AV: E=Sophos;i="5.96,302,1665460800"; d="scan'208";a="91298111" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jbTn9W3gGCGXeF2CksLIfEvd1pRokFjoUfqXABsKPJ9P/AY/757YKX9M6iP80NEmyByWoGSnAin0iDCANe7IA4EkzLBWRlPrXzKqIfNrih+eq/iDIIC7q6Noma/i6YbcUBpj9EfRUy58zfzNfAFEsgab3ifXozluOMbWqWn5sqjn78xKMr9CgDuusFAPs9l1qN1Wtf2qAa6Z5uckRbQhVSOALu8gF1rMcVDJJKcHB0TVr2gdq7yfpZRBHluAXwJw9ihGT5jr/NsrDgyf2zMaN69+U8IRcawDeockCtInRKGMAyPoS+y7UOwMYfpEFMVIMJO9FtKl016ppqwZNF/F2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3ykmsFdGGmg1YLJtWbMR4ZNI61TRCFhCcyqvlK2ivpU=; b=HcvZ0mdCL5isDDdSPtIZj4DBTMZyPV7/HiOoDr6J8EQR6DPnUjXYwAXJGM6BUDHo+6ovLCFliV+wB4+NeViXq0ebbMr2eNd7uSCHFtQnl/4Wq9oNw7eBcTPvA/esuBYCbQuKAE9Bdw2Iz5M2pAFlStNXZPBhqBlKG1NgxR7jjyLpuCpHPegMou4KaWbY7QMpnHBSw5Kmre4BO6WWk2s7AgvxoWaNcXdbx6QvyAa5ytkUhHqS4mTEgP2SaYOyXIQOJETorkHzl1d/gGsIm6qPoG5xkKdBOOogIR9AtmG2OdlgcfKKnttilMBVFvip5Mlf86KQecSz1mAZ1Npn+NoMVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3ykmsFdGGmg1YLJtWbMR4ZNI61TRCFhCcyqvlK2ivpU=; b=MKRJMOXdtGKbOxW+TDzV7g6MpXmIl0ZmEJrJ34O44q+9cbcfJLVkFn+7uwzhiwEqwqvXtnbTqFQeElIay/TnLSdwSdmNFttaZJsLZrKS2q+Zb+f4AVn/RlieC/lRwA8cJkxIaOxlXpX83GJA+UVUcwxY+nTvRZreJurQ/aHHI00= From: Andrew Cooper To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Wei Liu , Roger Pau Monne , Julien Grall Subject: Re: [PATCH] x86: idle domains don't have a domain-page mapcache Thread-Topic: [PATCH] x86: idle domains don't have a domain-page mapcache Thread-Index: AQHZIPY76jcWuuXMREKwR1wL4WEG2q6PucOA Date: Thu, 5 Jan 2023 12:04:21 +0000 Message-ID: <330dce2f-ffa4-2f6b-a481-cac53e996255@citrix.com> References: <139bab3a-fd3e-fec2-b7b4-f63dd9f9439a@suse.com> In-Reply-To: <139bab3a-fd3e-fec2-b7b4-f63dd9f9439a@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|MN2PR03MB5295:EE_ x-ms-office365-filtering-correlation-id: 7ce8f36c-5f51-4642-fc8c-08daef14fb28 x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yhHvV0+XBIxKkIv9HBgo10+6WtH5CSmUEnL6/n62VlehdvPOhZB9pmfNLWflvLyqE1UaoWLeL6xOdVgh4I0EaJK5KAGoXEMFUEu5Y+vgJ3mQ5JrGG/UIZHMrWVujafVZl6GODD2nUZLFEdSaOLXvo5OsaNZnthHbRbeh1/KlgnWPpzqME0GCogjYN+mxuHXfkYTropurmtjE28jQAC/DGEjULlM3AILGhWObkAvWywToqTcUCV4b2Hf04zHi5cj/W3nYZcoB5qcwh9UuZ9G6xuiidqLNHhpa7pb6lnHIgVrjTXhQmaXEqjSuPn5NM3DLxrCp/YVNGiFDpLbaDfAIdRU+J//7lhbWU1wHwztiQfm/ZJ1blRzjZg3zlBBepSaIbK5qKDVSRZ6TLgm4tdo+5VoSPd/g1R5i36DmjTHuJODlGFzLGksXy2Mvm3Stzq9RWNvLV+c6ABm0dsROo4FzrhqrmH10vSSgVAdPTS+yK6e404xKkkC+xNrdavLD4oPMJegnEnt3DX7+HLnEXFqHucHK32WCeZlnWzoS2DbgTUxVp59CfXegLAkXBXKj1JE3f3ZevElfkO620Yn46x3+lvu5LLpLzEclWzamXhWVGmqZ9zosOxWFrgtapIzcsqENJGJ/YBkFnctVJAzDlobvlyiahq+9weP6bahvRQzGTuc+RkU7ZXdXoQBSvNpp4kwaWL66/gtedDbpV03deAN0GzVqZqAn99lRxaxphtDEbsYZ6pBFg3R8V+qT/uxJQWIoOz9vy5LQyE5qt8obTebIrw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(366004)(136003)(346002)(39860400002)(396003)(451199015)(64756008)(66476007)(66446008)(76116006)(2616005)(66946007)(66556008)(36756003)(8676002)(91956017)(41300700001)(38070700005)(4326008)(54906003)(316002)(31696002)(2906002)(82960400001)(86362001)(5660300002)(110136005)(38100700002)(83380400001)(31686004)(122000001)(6486002)(8936002)(53546011)(478600001)(71200400001)(6512007)(186003)(26005)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?MFREWW9qdlBCWmhOSVBEbzJNeXhKR0hMck1CTjFkL3ZoSUZDUC9UYUxwa25J?= =?utf-8?B?MGMybEloRm0xTDN5UzhZRlhCdEYzRW1RWThOdCtwcG45eVNQdE85QnFycGhz?= =?utf-8?B?WFMxRENoL0JpaytwdmZUTVVHRVVTbHYyY0FwcFBDUVQ3OWNRczVoelVqV2pq?= =?utf-8?B?anpONytRZ1dIV1JqV2NmV24rL2Y5OEtRUFVxMHZsdUJLa1M0OURuT3YzY21a?= =?utf-8?B?bnVVWnN0Q1dzaWVBZXBWSXBhYjRkWTBIdEUvVGs0cmVsSXUvN2V6a0Q2bFZJ?= =?utf-8?B?bGg0bVhMUTBWc3RvQ2ZnbzFqRW5vRTI3ZHQxcGpqSlBMYzRKMW9xLzRhVzhG?= =?utf-8?B?RDlZYlp1WS9hOGZYSnp3RFFkdUgvWnBZdE0wQ2lzUzh4NTNQamFYYlMrZUd3?= =?utf-8?B?MEdtbzg4V3RFUkdkQ0U4VENVQmFXTmpEWGdhRDAydEtOTmhXaldGYUo1NmVy?= =?utf-8?B?L3E5NHBtK0c5RTB6OElYYUV0NDA1WTlCT1M1WDAyNDluTlVNTFZmd0JQQ0t2?= =?utf-8?B?aUhvbWMwQmpXZStIN0ovQ01ZaFlTYVBSblcwUnVuek1QTGRpdWhKdkdYZWNX?= =?utf-8?B?bmNmN1dVcnh5eGtlaWRrQythMTN5bU5DeWdkZzR6WS9WckRkeDhRRjhDaGxI?= =?utf-8?B?RkdVUnR2OVRPTS9MMFdWNUVCaDBnM2g1aVNMM1RmOWNrazFNaGUwdWRNNHh1?= =?utf-8?B?ajdHbzlFWEo5SVV6SEN2NHJXaE1xZXdOVmVFMS9vQ0F2UzNTdnhFcVNTNkVu?= =?utf-8?B?ZWttbXpNMGVydWxaTmY0ODhDY3Vud29RZmJ6VmhQSFBEYkxBeVlhWmNnZkJW?= =?utf-8?B?RkZtWnE0SGxnMkg0QUxQN05Jck5OdGRXVFUxM3E4TEhPWUVad1BYSGhoNVUz?= =?utf-8?B?Y2hYN2p6VDlId1N3cWJremtaUEE0RGJPV0hhOWg3TzE3dzNkaXlvK0tJandh?= =?utf-8?B?aUFOcDlRbjhyVGgyVHJrWW56aDQxTmd5ODUzeWdaZDl3RXZyZDdMaTE5S20r?= =?utf-8?B?TUluUmZNNC84SWdia1dwWU9vMW1MZDMvc1RmWGpPOWx2MVZ0YlE4Q2hFYnhQ?= =?utf-8?B?eXNYbUFIUjB1WStyVVp6d25rMi9Qdk1zYVlrN1ZWbDJFd2pMNWgrS21rQ1pC?= =?utf-8?B?RE9YMzB4TWoyL0N1UWt3ckZhV2xPaVVYZmtOS2EzeENLOExwaXg4R1NEMUxP?= =?utf-8?B?Zm81Y1FFUS9WZWI4S2pmd3kySm80eHF0VGtDbjNWOHRoRTQ4ZnJpbTRGUDVk?= =?utf-8?B?aDVJN0I5eDVjNWFLWXAwMkdMYk4vY3ZXZkpCYjRHSG5zS3hmU25NY051aWEx?= =?utf-8?B?ZVlNU1M5aVlJZUJDSkhtSkZOd0VnTnAxVFlCR293NXRYUnloYzNMM2tQVXF1?= =?utf-8?B?bENKNjRQR2hoNEtKbElYVWlGQmV3WmlQTmhtVS9Ram9oMlA0MWVUNFdaczJp?= =?utf-8?B?SjhuQ2t4WWNrRHh3UUR2OXdxSnJNZGFzblZCb0JZVEtKVHFzSSt1R0tTYnNi?= =?utf-8?B?eFZhZ25mODV4Y0ZHclJzRDl6VlluZENKZktMVWtkM0c0VkxTYk53Q0htcldO?= =?utf-8?B?WXZONkRjZDI5dTNGWEZCTlAyRkJXVytyamRORGJQOE0veTF2OEIyNmVTVUQ0?= =?utf-8?B?UndyV1FMd083cnpJL0pZRWI5Z09BaXBHWmkzQU83MkhVYnpLeEZ5TklPNnJJ?= =?utf-8?B?YU5EeXdveHFSMjNkRDlCMXhUdm9icmRGbE16bmpNcjg2NDFJM1lzWW1Wbkxj?= =?utf-8?B?UTFxNHl5Y05mdHdJTUZEa2pOdFl2dWI2bmQ0WEtKOUphL2ZsU1VWTDljaC9l?= =?utf-8?B?SHBaeFVTUHlDNEJSV1NJUXR3Tm10dlhmOW50WDdaaG5DSTlsWC8veXJScnk1?= =?utf-8?B?d3dHbVBiSStXN2syWDgyd3l3VlJHZGVkamlkY215MGl6eUl5QytOOGFpcXVT?= =?utf-8?B?ZFpQQkMvYTNQeG5nVG1qSkYxSm9LQ0l2MDFGaHZjbGZ1cE45SWh5Wk9BU05l?= =?utf-8?B?a0lKbHdmT1VmNE1ZSU9PRDNUUnM0amxtQ1VDdFUxNEp6REpEaEJSUmhnUWVS?= =?utf-8?B?ZEYvVitHS3JzZFlNVm9ldW4rVjJEZWdUSURNL3BYdlRQbmNvOWtUTW1YcWRP?= =?utf-8?Q?HikDexVlQaH+IIVRnr/U4gB/V?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: T6d27e3FhXyIDIMKCduoDVv73J+MEKkZTDhndCzJpN+QEIqLVlk+OquL9EFTp7rkcgiZOYx7CRoNZ3c5QevDX7lA5Mnme16vYb0X8tMALattAUA+VhXh3njsG1W6DBqbW2LHpVr2nSNW4R8E7QeKcpdPf14YixsAO5g9La69DO6P6JoniO/4qpq//dRwvPCiBY8zC7Kofj5/dZXV29g/1XcRexScSB7T2psIzfk5rvjD9lwCTXcVRmBGmuzTx1wGQ1EEpTtkAGuq7GLn/pdod/GrRuYVxKPtdg3ba6xIz5s67LdGY6MlfEehceF50tUQENWXdSoyjIcXaIOqSkPW3m26vwquCpD7yZfOeQV8KdWhhoX9aR4IMlmr0f7eMW7rp9kH6+2NwqpmubX2rlPolzxxn68dgB7vhI+ikkVBEQfkS9s5KmEN4rLrp1bpl3L6fX4iTXYgC8qIe0ZQciE/6M1SHXpCh1b2zbsOB9P5y1MCyftFxd82cnG8qnYYE/JKA0wPc57TT8g/N5NGgx24AQil+EyYeT9ww/CTITaej4mqY46HKIcrWV+4XfOVeOuAnp0NqPNCXpJSdhIeLlTXuFMtFa9uMl9UJ+9mBrYHNFh+OWoHNd83oaTXkDiSylSeNKkRorFp3eX6fuXYCHpROXLOA80mAZPyrhN9I8HOhlP2RxLKkeKg2zNcO1gkJEbF66YQkgq3c4aTVhH2sEtCLRHCS5Pzltlu9GjBuCsi5KRK571vDQL95ZFZT/i3zIQYV44PUYzz+wDeDO+/Fr0VJ2Vgiqf1HKrT8122qZ8QTfGWUCSAWF29ki4S2EypOgZe9YdDnPV35TbUFWybtL++wA== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7ce8f36c-5f51-4642-fc8c-08daef14fb28 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jan 2023 12:04:21.8185 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WNMyz/g446vbZ4FzMskTda4cDRsUAXKNhkeZdoLbhcaqOodce+/3MCWfIFKdXD9hSDw3OQPgWNwAnp3e8XjkcJHFHvi869eIDiduPRfSWoU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5295 T24gMDUvMDEvMjAyMyAxMTowOSBhbSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IEZpcnN0IGFuZCBm b3JlbW9zdCBjb3JyZWN0IGEgY29tbWVudCBpbXBseWluZyB0aGUgb3Bwb3NpdGUuIFRoZW4sIHRv DQo+IG1ha2UgdGhpbmdzIG1vcmUgY2xlYXIgUFYtdnMtSFZNLXdpc2UsIG1vdmUgdGhlIFBWIGNo ZWNrIGVhcmxpZXIgaW4gdGhlDQo+IGZ1bmN0aW9uLCBtYWtpbmcgaXQgdW5uZWNlc3NhcnkgZm9y IGJvdGggY2FsbGVycyB0byBwZXJmb3JtIHRoZSBjaGVjaw0KPiBpbmRpdmlkdWFsbHkuIEZpbmFs bHkgcmV0dXJuIE5VTEwgZnJvbSB0aGUgZnVuY3Rpb24gd2hlbiB1c2luZyB0aGUgaWRsZQ0KPiBk b21haW4ncyBwYWdlIHRhYmxlcywgYWxsb3dpbmcgYSBkY2FjaGUtPmludXNlIGNoZWNrIHRvIGFs c28gYmVjb21lIGFuDQo+IGFzc2VydGlvbi4NCj4NCj4gU2lnbmVkLW9mZi1ieTogSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KDQpCeSBhbmQgbGFyZ2UsIEkgdGhpbmsgdGhlc2UgY2hh bmdlcyBvaywgYnV0IEkgd2FudCB0byBtYWtlIGFuIGFyZ3VtZW50DQpmb3IgZ29pbmcgZnVydGhl ciByaWdodCBhd2F5Lg0KDQoNCk1vc3Qgb2YgbWFwY2FjaGVfY3VycmVudF92Y3B1KCkgaXMgYSBn aWFudCBib2RnZSB0byBzdXBwb3J0IHRoZSB3ZWlyZA0KY29udGV4dCBpbiBkb20wX2NvbnN0cnVj dF9wdigpLCBidXQgd2UgcGF5IHRoZSBwcmljZSB1bmlsYXRlcmFsbHkuDQoNCkJ5IHVwZGF0aW5n IGN1cnJlbnQgdG9vIGluIHRoYXQgd2VpcmQgY29udGV4dCwgSSB0aGluayB3ZSBjYW4gZHJvcA0K bWFwY2FjaGVfb3ZlcnJpZGVfY3VycmVudCgpLsKgIEl0J3MgYWxzbyB3b3J0aCBub3RpbmcgdGhh dCB0aGUgb25seQ0KY2FsbGVycyBhcmUgX19pbml0IHNvIGhhdmluZyB0aGlzX2NwdShvdmVycmlk ZSkgYXMgcGVyLWNwdSBpcyBhIHdhc3RlLg0KDQpCdXQgSSBhbHNvIHRoaW5rIHdlIGNhbiBkcm9w IHRoZSBwYWdldGFibGVfaXNfbnVsbCh2LT5hcmNoLmd1ZXN0X3RhYmxlKQ0KcGFydCB0b28uwqAg SWYgd2UgaGFwcGVuIHRvIGJlIGhhbGYtaWRsZSwgaXQgZG9lc24ndCBtYXR0ZXIgaWYgd2UgdXNl IHRoZQ0KY3VycmVudCBtYXBjYWNoZSBieSBmb2xsb3dpbmcgY3B1X2luZm8oKS0+Y3VycmVudCBp bnN0ZWFkLsKgIFRoYXQgc2FpZCwgSQ0KY2FuJ3QgdGhpbmsgb2YgYW55IGNhc2Ugd2hlcmUgd2Ug Y291bGQgbGVnYWxseSBhY2Nlc3MgdHJhbnNpZW50IG1hcHBpbmdzDQpmcm9tIGFuIGlkbGUgY29u dGV4dCwgc28gSSdkIGJlIHRlbXB0ZWQgdG8gc2VlIGlmIHdlIGNhbiBzaW1wbHkgZHJvcA0KdGhh dCBjbGF1c2UuDQoNCg0KT3ZlcmFsbCwgSSB0aGluayB0aGUgbG9naWMgd291bGQgYmVuZWZpdCBm cm9tIGJlaW5nIGV4cHJlc3NlZCBpbiB0ZXJtcw0Kb2Ygc2hvcnRfZGlyZWN0bWFwLCBqdXN0IGxp a2UgaW5pdF94ZW5fbDRfc2xvdHMoKS7CoCBUaGF0IGlzIHVsdGltYXRlbHkNCnRoZSBwcm9wZXJ0 eSB0aGF0IHdlIGNhcmUgYWJvdXQsIGFuZCBpdCdzIGFsc28gdGhlIHByb3BlcnR5IHRoYXQgaXMN CmNoYW5naW5nIGluIHRoZSBlZmZvcnQgdG8gcmVtb3ZlIHRoZSBkaXJlY3RtYXAgZW50aXJlbHku DQoNCklmIG5vdCBzaG9ydF9kaXJlY3RtYXAsIHRoZW4gYXQgbGVhc3QgaGF2aW5nIHRoZSBwcm9w ZXJ0eSBleHByZXNzZWQNCmNvbnNpc3RlbnRseSBiZXR3ZWVuIHRoZSB0d28gcGllY2Ugb2YgY29k ZSwgc2VlaW5nIGFzIGl0IGlzIHRoZSBzYW1lDQpwcm9wZXJ0eS4NCg0KfkFuZHJldw0K From xen-devel-bounces@lists.xenproject.org Thu Jan 05 12:06:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 12:06:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471881.731909 (Exim 4.92) (envelope-from ) id 1pDP0z-0001UJ-6s; Thu, 05 Jan 2023 12:06:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471881.731909; Thu, 05 Jan 2023 12:06:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDP0z-0001UC-3m; Thu, 05 Jan 2023 12:06:33 +0000 Received: by outflank-mailman (input) for mailman id 471881; Thu, 05 Jan 2023 12:06:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDP0x-0001U6-Bq for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 12:06:31 +0000 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [2a00:1450:4864:20::42d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 636b288f-8cf1-11ed-91b6-6bf2151ebd3b; Thu, 05 Jan 2023 13:06:30 +0100 (CET) Received: by mail-wr1-x42d.google.com with SMTP id h16so35845418wrz.12 for ; Thu, 05 Jan 2023 04:06:30 -0800 (PST) Received: from [192.168.0.145] ([195.234.76.149]) by smtp.gmail.com with ESMTPSA id t64-20020a1c4643000000b003cf75213bb9sm2139544wma.8.2023.01.05.04.06.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Jan 2023 04:06:29 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 636b288f-8cf1-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=c5egG6SdIg28D8Hak31Q8FP4RU+sU/CcgK37WsyJhEI=; b=KneGFqdrfzkp+yNp5pGslu+l140GD7lt7lIT2kVrN0m4OW2KbeIYJxQRKxKzby92la EveviTrZqr013ou3RMGE3d3jbeA1viGPJ3wP82VuM0zr2h1GbfEyxi3evN/or7E6RiJa JQ0BrOJmHwvP1goasEEea30HS68XnsCI2C2IcrDrKskeTYVVmEijPb5cyoo5ic6cxHJq kSnBj6uioUUDCAkW75p4WEttCKr5rUd1+H+8ZR0cb+klSWSTon8xr5DtS4uBbffbR2R7 bJNsDpovOqjMdMsB5vOApSJ0aet6VC3D4vzTN9fZvjQgWRuHEv4S1eL72c+QqMYX4Lq9 H3bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=c5egG6SdIg28D8Hak31Q8FP4RU+sU/CcgK37WsyJhEI=; b=ZSqH5ukq/cy/N5J7UscSMzJYWzRKLwbMaSXqyLPojMWo1jGAv2eA1CdHKlAiXe+Swn oA9gy0TUj+FKdxBTz9z1rdnUsfgovbZy93MPp0k3sRkRiltf3cA+WnzfgBSxxLMNNVqN SHwt6i/s5P6NwlF3EXUkvO9yADENzJOY6jegbCQN7eQlniC41E1qWB8MzNz5bbL900Bb x5GmrGm+E11PjPa5VAvCVEfFeuoQ2HQ6enURTSmUKTt7S/hPaEVh/TbEyUJj9e6x/Dvi BnngaqguHNz0ppspG1JDkGIPNw63G3q9LnBk6ffJSA48Oaws6Ad8jHzar55YHunI7TEt KUig== X-Gm-Message-State: AFqh2krC5AZE3jagpoqV2Sed5cayNVsPHR2Khl/kFjRYuR7aDBsG7vRs SgtN2DeUoWwLFimLeXEuiFo= X-Google-Smtp-Source: AMrXdXtQesEYZEhViTTqQkcghYE/pMA5SBTjW7QG4I5ITutpnea+M1/HooniRyuqkpaBKQ/c5//3kg== X-Received: by 2002:adf:f187:0:b0:296:4854:2c6d with SMTP id h7-20020adff187000000b0029648542c6dmr9630694wro.32.1672920389857; Thu, 05 Jan 2023 04:06:29 -0800 (PST) Message-ID: <58d3356fb92d0534ed3c023d205909c57c3eb063.camel@gmail.com> Subject: Re: [XEN PATCH v2 1/2] arch/riscv: initial RISC-V support to build/run minimal Xen From: Oleksii To: Andrew Cooper , "xen-devel@lists.xenproject.org" Cc: Bob Eshleman , Alistair Francis , Connor Davis , Julien Grall , Anthony Perard , Stefano Stabellini , Gianluca Guida Date: Thu, 05 Jan 2023 14:06:28 +0200 In-Reply-To: References: <4702cb223dbd7629fe3d3e494eb363f4b2534e96.1672401599.git.oleksii.kurochko@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.1 (3.46.1-1.fc37) MIME-Version: 1.0 On Wed, 2023-01-04 at 20:36 +0000, Andrew Cooper wrote: > On 30/12/2022 1:01 pm, Oleksii Kurochko wrote: > > The patch provides a minimal amount of changes to start > > build and run minimal Xen binary at GitLab CI&CD that will > > allow continuous checking of the build status of RISC-V Xen. > >=20 > > Except introduction of new files the following changes were done: > > * Redefinition of ALIGN define from '.algin 2' to '.align 4' as >=20 > "align" >=20 > > =C2=A0 RISC-V implementations (except for with C extension) enforce 32- > > bit >=20 > While the C extension might mean things to RISC-V experts, it is > better > to say the "compression" extension here so it's clear to non-RISC-V > experts reading the commit message too. >=20 > But, do we actually care about C? >=20 > ENTRY() needs to be 4 byte aligned because one of the few things it > is > going to be used for is {m,s}tvec which requires 4-byte alignment > even > with an IALIGN of 2. >=20 We don't care about C (at least now). >=20 > I'd drop all talk about C and just say that 2 was an incorrect choice > previously. >=20 > > =C2=A0 instruction address alignment.=C2=A0 With C extension, 16-bit an= d 32- > > bit > > =C2=A0 are both allowed. > > * ALL_OBJ-y and ALL_LIBS-y were temporary overwritted to produce > > =C2=A0 a minimal hypervisor image otherwise it will be required to push > > =C2=A0 huge amount of headers and stubs for common, drivers, libs etc > > which > > =C2=A0 aren't necessary for now. > > * Section changed from .text to .text.header for start function > > =C2=A0 to make it the first one executed. > > * Rework riscv64/Makefile logic to rebase over changes since the > > first > > =C2=A0 RISC-V commit. > >=20 > > RISC-V Xen can be built by the following instructions: > > =C2=A0 $ CONTAINER=3Driscv64 ./automation/scripts/containerize \ > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 make XEN_TARGET_ARCH=3Driscv64 tin= y64_defconfig >=20 > This needs a `-C xen` in this rune. >=20 > > diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile > > index 942e4ffbc1..74386beb85 100644 > > --- a/xen/arch/riscv/Makefile > > +++ b/xen/arch/riscv/Makefile > > @@ -1,2 +1,18 @@ > > +obj-$(CONFIG_RISCV_64) +=3D riscv64/ > > + > > +$(TARGET): $(TARGET)-syms > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0$(OBJCOPY) -O binary -S $< $= @ > > + > > +$(TARGET)-syms: $(objtree)/prelink.o $(obj)/xen.lds > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0$(LD) $(XEN_LDFLAGS) -T $(ob= j)/xen.lds -N $< > > $(build_id_linker) -o $@ > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0$(NM) -pa --format=3Dsysv $(= @D)/$(@F) \ > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0| $(objtree)/tools/symbols --all-symbols --xensyms > > --sysv --sort \ > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0>$(@D)/$(@F).map > > + > > +$(obj)/xen.lds: $(src)/xen.lds.S FORCE > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0$(call if_changed_dep,cpp_ld= s_S) > > + > > +clean-files :=3D $(objtree)/.xen-syms.[0-9]* >=20 > We don't need clean-files now that the main link has been simplified. >=20 > > diff --git a/xen/arch/riscv/include/asm/config.h > > b/xen/arch/riscv/include/asm/config.h > > index e2ae21de61..e10e13ba53 100644 > > --- a/xen/arch/riscv/include/asm/config.h > > +++ b/xen/arch/riscv/include/asm/config.h > > @@ -36,6 +39,10 @@ > > =C2=A0=C2=A0 name: > > =C2=A0#endif > > =C2=A0 > > +#define XEN_VIRT_START=C2=A0 _AT(UL,0x00200000) >=20 > Space after the comma. >=20 > Otherwise, LGTM. >=20 Thanks for the comments. They were fixed in patch series v4: [PATCH v4 0/2] Add minimal RISC-V Xen build and build testing ~ Oleksii > ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Jan 05 12:07:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 12:07:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471888.731919 (Exim 4.92) (envelope-from ) id 1pDP1r-00023V-Fo; Thu, 05 Jan 2023 12:07:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471888.731919; Thu, 05 Jan 2023 12:07:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDP1r-00023O-D5; Thu, 05 Jan 2023 12:07:27 +0000 Received: by outflank-mailman (input) for mailman id 471888; Thu, 05 Jan 2023 12:07:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDP1q-000236-F6 for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 12:07:26 +0000 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [2a00:1450:4864:20::430]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8459670b-8cf1-11ed-91b6-6bf2151ebd3b; Thu, 05 Jan 2023 13:07:25 +0100 (CET) Received: by mail-wr1-x430.google.com with SMTP id bs20so33793004wrb.3 for ; Thu, 05 Jan 2023 04:07:25 -0800 (PST) Received: from [192.168.0.145] ([195.234.76.149]) by smtp.gmail.com with ESMTPSA id t12-20020a05600001cc00b0027b35baf811sm29936404wrx.57.2023.01.05.04.07.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Jan 2023 04:07:24 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8459670b-8cf1-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=8wnBL/jmFKxYHcNRdtvyM6TuTfxXm1XjkKh93ADJPd8=; b=gUI5XxHfoeoHELRuzdmvS2vOl6ebJkCm30Oo/sEHOSzSoZbPLk4ij+quExGJOn/Puv ZnSPCbCR5dvKNEkopnS/tS/17utaV6w35cxpm/TQIX+NAXwe2tJ+wxnlN8R29wWiuy0o WHBFutdw0WubFz08UEF6mvFyhitQXGYHIz99ZholPoDi+V/45Ph1hLiOanNJIgknsLZO VyswLgpvT6rsgk2ek3NhBvLtOzcps/lj5lpCqGWNBPkZGZESWsK0oKQT5VBwZK0ITYd4 zrcKpDYTHwLG181NjyYnaBtO2QO2casFeSJMGxunX9H2NFq82dQo2tuvjf1V57NLMYvc cFYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=8wnBL/jmFKxYHcNRdtvyM6TuTfxXm1XjkKh93ADJPd8=; b=jLCZxK2OBUynSixEKPX5O27KmHOBHVDWmfzdN9Z74TAxVPTSBItEI8MM9ZATkodLEo ezjYrF8+MxXmij1MFynZOYs7g38//S9FH9mn0npJ2ekmYiUV/2ii5xfGPymzadnRBFrv rGbZ4o2ZY/FtKvAhELgFCBb7Iftj65XF5mxiDIsej+7OeJhGTzC3Xbkp2Q2fhMb8+9Ht w3pc1pkjOvM8TOY9tntnZ3gUgfKb1AiRpNTnlRo3TulHEhPUcWySA3hdLpJGSe5h4Osr vWcOJ/whFuZOzR74xW1fMK3jJnAi77DckSo9DYdddMKi8ZROMDpuJTzSEQIXRftcaHR9 +T+Q== X-Gm-Message-State: AFqh2kpkG1EViqPpGzcV0fQSHj0vYTM2IvMqjF1+aZyt8jQKsyFAEgmp KdS4FiZ6/SI/+d8ePDEf+y4= X-Google-Smtp-Source: AMrXdXuIuwVjNQyHpItyL3RjKI1GzeiriNBFSFhMxVmzPx3yx1C2Ww/4cGLZeUGjAH2jAAQs9kuS6A== X-Received: by 2002:a05:6000:1109:b0:28d:b028:b16 with SMTP id z9-20020a056000110900b0028db0280b16mr14837756wrw.32.1672920445017; Thu, 05 Jan 2023 04:07:25 -0800 (PST) Message-ID: Subject: Re: [XEN PATCH v2 2/2] automation: add RISC-V 64 cross-build tests for Xen From: Oleksii To: Andrew Cooper , "xen-devel@lists.xenproject.org" Cc: Doug Goldstein , Alistair Francis , Stefano Stabellini , Gianluca Guida Date: Thu, 05 Jan 2023 14:07:23 +0200 In-Reply-To: References: <855e05a0459d44282679f08c8f67e38d35635eb6.1672401599.git.oleksii.kurochko@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.1 (3.46.1-1.fc37) MIME-Version: 1.0 On Wed, 2023-01-04 at 20:39 +0000, Andrew Cooper wrote: > On 30/12/2022 1:01 pm, Oleksii Kurochko wrote: > > diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab- > > ci/build.yaml > > index e6a9357de3..11eb1c6b82 100644 > > --- a/automation/gitlab-ci/build.yaml > > +++ b/automation/gitlab-ci/build.yaml > > @@ -617,6 +644,21 @@ alpine-3.12-gcc-debug-arm64-boot-cpupools: > > =C2=A0=C2=A0=C2=A0=C2=A0 EXTRA_XEN_CONFIG: | > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 CONFIG_BOOT_TIME_CPUPOOLS=3Dy > > =C2=A0 > > +# RISC-V 64 cross-build > > +riscv64-cross-gcc: > > +=C2=A0 extends: .gcc-riscv64-cross-build > > +=C2=A0 variables: > > +=C2=A0=C2=A0=C2=A0 CONTAINER: archlinux:riscv64 > > +=C2=A0=C2=A0=C2=A0 KBUILD_DEFCONFIG: tiny64_defconfig > > +=C2=A0=C2=A0=C2=A0 HYPERVISOR_ONLY: y > > + > > +riscv64-cross-gcc-debug: > > +=C2=A0 extends: .gcc-riscv64-cross-build-debug > > +=C2=A0 variables: > > +=C2=A0=C2=A0=C2=A0 CONTAINER: archlinux:riscv64 > > +=C2=A0=C2=A0=C2=A0 KBUILD_DEFCONFIG: tiny64_defconfig > > +=C2=A0=C2=A0=C2=A0 HYPERVISOR_ONLY: y > > + >=20 > Judging by the Kconfig which gets written out, I suggest inserting > the > two RANDCONFIG jobs right now. >=20 > > =C2=A0## Test artifacts common > > =C2=A0 > > =C2=A0.test-jobs-artifact-common: > > @@ -692,3 +734,6 @@ kernel-5.10.74-export: > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - binaries/bzImage > > =C2=A0=C2=A0 tags: > > =C2=A0=C2=A0=C2=A0=C2=A0 - x86_64 > > + > > +# # RISC-V 64 test artificats > > +# # TODO: add RISC-V 64 test artitifacts >=20 > Drop this hunk.=C2=A0 All you're going to be doing is deleting it in the > next > series... >=20 Thanks for the comments. They were fixed in patch series v4: [PATCH v4 2/2] automation: add RISC-V 64 cross-build tests for Xen ~ Oleksii > ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Jan 05 12:15:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 12:15:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471896.731931 (Exim 4.92) (envelope-from ) id 1pDP9y-0003qG-9o; Thu, 05 Jan 2023 12:15:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471896.731931; Thu, 05 Jan 2023 12:15:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDP9y-0003q9-6l; Thu, 05 Jan 2023 12:15:50 +0000 Received: by outflank-mailman (input) for mailman id 471896; Thu, 05 Jan 2023 12:15:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDP9x-0003q1-Cq for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 12:15:49 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id adae7a0d-8cf2-11ed-b8d0-410ff93cb8f0; Thu, 05 Jan 2023 13:15:46 +0100 (CET) Received: from mail-bn8nam11lp2169.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 05 Jan 2023 07:15:43 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SA2PR03MB5834.namprd03.prod.outlook.com (2603:10b6:806:f8::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 12:15:38 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 12:15:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: adae7a0d-8cf2-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1672920946; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=DugpVJyShds+JdKCIeHKaDxrw2o9ohUEHmwSAbO7ieE=; b=NEcHbNJ8/0vmiG8jmJQDMU3NV2KU6F2UNRkMkNIEXEyVRj5VtwiJ5adC RmPfu+an7KmbMp7LmzM4NejOiTq780v3M8q/0s8EoQdJJh8ahA3fL4rHn F3C0sS/s4ej8B5CzClgKkfmxelOmk1gEsTs1vjDhhkPG/r04XhOg5vNRa 4=; X-IronPort-RemoteIP: 104.47.58.169 X-IronPort-MID: 91299082 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:eSW5tK+hLxkHBFkgSSIQDrUDr3+TJUtcMsCJ2f8bNWPcYEJGY0x3m mEXXG6OMvrcYjSmKdB/O4rloB4B7JaBz9dlHgY/+3o8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKucYHsZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kIx1BjOkGlA5AdmPKgW5AW2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklHz KImGhEwaiuH3bqJwvWZasJ9qpU8eZyD0IM34hmMzBn/JNN/GNXpZfWP4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWDilUvgdABM/KMEjCObexTklyVu STt+GPhDwtBHNee1SCE4jSngeqncSbTCdtIRezgpqQCbFu771NPLh1LSl6AoPi5zQmPBYpuE 3Ys9X97xUQ13AnxJjXnZDW6vXqFsxg0S9dWVeog52mlw7vd5QWEA2EsRztNLtchsaceVTEsk 1OEgd7tLThuq6GOD2KQ8K+OqjG/MjRTKnUNDRLoViMA6tjn5Ys13hTGS486FLbv14OkXzbt3 zqNsS4ywa0JitIG3Lm6+laBhC+wop/OTUg+4QC/sn+Z0z6VrbWNP+SAgWU3J94aRGpFZjFtZ EQ5pvU= IronPort-HdrOrdr: A9a23:ZUG3m6xl1NPIJAR6A1g3KrPxHegkLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9IYgBZpTgZUJPwC080hqQFmrX5Wo3SETUO2VHYZ72KiLGP/9SOIVybygcw78 Zdmu1FeaTN5DtB/IrHCWuDYrEdKbC8mcjG69s2jU0dKz2CAJsQjDuRfzzrd3GeMzM2Z6bReq D92uN34x6bPVgHZMWyAXcIG8DFut3wjZrjJTIWGhI97wGKrDWwrJr3CQKR0BsyWy5Ghe5Kyx mKryXJooGY992rwB7V0GHeq7xQhdva09NGQOCcl8QPLT3oqwCwIKBsQaeLsjwZqPymrHwqjN 7PiRE9ONkb0QKfQkiF5T/WnyXw2jcn7HHvjXWCh2H4nMD/TDUmT+JcmINwaHLimgodleA59J gO83OStpJRAx+Ftj/6/cL0WxZjkVfxiWY+kNQUk2dUXeIlGfxsRM0kjQFo+aU7bWbHAbMcYa 5T5QbnlbBrmGahHjXkV69UsYWRtzoIb0+7qwM5y7aoOnBt7Q1EJg0jtY0idz47he0Ao9Mv3Z W5Do140L5JVcMYdqR7GaMIRta2EHXERVbWPHuVOkmPLtBwB5vhke+C3FwO3pDcRLUYiJ8p3J jRWlJRsmA/P0roFM2VxZVOthTAWn+0UzjhwtxXo8ERgMy1eJP7dSmYDFw+mcqppPsSRsXdRv aoIZpTR/vuN3HnF4pF1xD3H5NSNX4dWssIvctTYSPGnuvbbonx8uDLevfaI7TgVT4iR2PkG3 MGGCP+Ic1Rh3rbL0MQQCKhKU8FVnaPja6YSpKqgdT74LJ9R7Fko0wSlUmz4N2NJHlLrrE2FX EOU4/arg== X-IronPort-AV: E=Sophos;i="5.96,302,1665460800"; d="scan'208";a="91299082" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dEuBtK7R2/dikj5S0egCNpZYTwdYKIaJZhTTqCRGVoMBuJmAOGxWJn84A8TbLEwgmF4rboWN+ZYfsXz8jYuKIVNmIgMRztbDF81zBlWmpkRRyx1ITt8HTBZoiMNDEz3y+nfuC3zlRv31XDp7fagCKTa3dUIDY4oUOTmgTJiXbxUHjqlEyJaQVh7IojblWUS/dbN9AvEnxJ2FX0I87ATj8swjtKoJYxp7fveFuYyiuWgPc8jnzhMQ1NVs8fBDFdMX9iLYce4mVz4xChfYVeuZzU2MPwteIHMuTexftQTxz57R9lWY4spOExu7R8miglXLNHQc53NsFDJ84jcCz7+pew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DugpVJyShds+JdKCIeHKaDxrw2o9ohUEHmwSAbO7ieE=; b=FdMuWBcYihPW6GdIBk+kqpBWqP/7n1iSrBI0sn0aDpEopCmhkW7xySzs3g0jHKyvsREOxuHUGgFMimohuEMdIl1+FksC/XweDXrO2tvuy/rt4siTBdIO+ur0Yp3xoWDGK1AwUQTpYySj+S5yiiC2ijAfwUgq+mazthKexjB0a0C3Dmz5cAMTZI0JIzbVNV7nVgliEObDdyNpzwhgyBdQsQpClbAf8tfvqNyveZyo69GdTKFDqIIKrSPvJ79q1SKSmRtZPaCv+Rc+BCVXU5HzD9NaCADpvdAzaXM0ueqEuDzaV8VnJqEHUPN2pQEwK0I3aVEVCUdXIaZINiT4AeRBbw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DugpVJyShds+JdKCIeHKaDxrw2o9ohUEHmwSAbO7ieE=; b=v3kl4IdwuaDP2Bc7P+xtEEJ1zUts3e/jXGfB9ZKx3SnB9oIfc9Kwcq8JJVOw0hapHP2DMshSg9TzmzcGGw7AH7UGN6JHuOUirLgF5hUv/ocTErPhFWjHXWkOEhhvWDVu/bFJv2q6pCjyuU6qdlYSha02gL4wgmagzoRliesQDS4= From: Andrew Cooper To: Julien Grall , Ayan Kumar Halder , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH v2] xen/arm: Add 0x prefix when printing memory size in construct_domU Thread-Topic: [PATCH v2] xen/arm: Add 0x prefix when printing memory size in construct_domU Thread-Index: AQHZH13GXnua+lhJCkOWuIi1KAI8E66O7vgAgACh3ICAAAlTgIAAFk6AgAAPpYA= Date: Thu, 5 Jan 2023 12:15:38 +0000 Message-ID: <35d590fb-4b96-70dd-a60b-1c8d7cc8f2d6@citrix.com> References: <20230103102519.26224-1-michal.orzel@amd.com> <1264e5cc-1960-95d3-5ecb-d6f23d194aa4@xen.org> <29460d07-cd43-7415-7125-6ed01f3c2920@amd.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|SA2PR03MB5834:EE_ x-ms-office365-filtering-correlation-id: 561bfbb8-daa3-4e30-4ebf-08daef168e5b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xyPw9xg5TWfMdiMi313HlIzUHVp9FMOyIBzaV7KVuPrv5//apseEdadhYTWNK7J8fiV1zwlfuZX5rLZ69FeZzywqrFXw6TZCcTI8b8isskpYmGwpzVilqVvAMV0MH3/xhqiGbyUkq3+2yVinyg2uLyF3DLsH27JVP4HEmdU6p6ZgMDv59I2QQmELH8e5yDknPm0/NMb0W8XUX2v+oN21VgiCkvinQ8O2IsKCMkZbUV9UGG3LDEbo/zSfz+g/DS74g/ekH2D5F/NMA6BeOT++NKemgby8vz0JNckAEVj92s2XmqAsJKufT6KJWl4xzPX9mUOFfct8zRuvzLjQZC9vi4mvaGcHf/wQPjp74HbZgpNJ/OSJO6t+Oi9HtykVDyfI+eHNE43cNnZTg2ZX+sFsRCQmiqp/5U555qzXyQ4BuQvYR2iqGPvdS0m66IA/DZvXw5jqJJbJ5ZDInYr7/ZAmBsQDwd8VhHNklTzWxoGZPhsS4b7gMxaUCE2ZCYOWOcC1YD6agmBIGhOFKnIK2C91+wdOOYXHjhUzlhLY1F8cRbbwmDl4V/oQPt09XPJnONREKeOfTYXFP2PSE6W0+ENPayxRLdNpmWQcu0n1pQsXptEAbj8VzBqHWTn4PrYDvasowJj+rBnxo7dTdijrdcDBG2KEts22OUwF8hu5fOxXEFjux5KrcmUrbD5TsTvZtLxIvrGiCmtnoIIrM0rYel9dHHHU5gNfIaBscp9kCVDijFq0qHZyWlVBFovBHSII9jxD4B/AnKwFnu0eHM7NNvV0gA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(346002)(376002)(396003)(366004)(451199015)(316002)(2616005)(186003)(38070700005)(6512007)(26005)(6486002)(478600001)(71200400001)(36756003)(86362001)(6506007)(31696002)(53546011)(110136005)(41300700001)(8936002)(2906002)(66476007)(83380400001)(8676002)(91956017)(82960400001)(64756008)(66446008)(76116006)(66946007)(31686004)(66556008)(5660300002)(122000001)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?QlZMRDZTMWZMTm9taW1GYjVleDdwY0tRQWlLNnUxbTVpSnJUOUlGUFR3UUdN?= =?utf-8?B?M25aQk9ObXJBeTAvVmZHc0ZmckM1UC8yb01uL1EzNzNPUGRYU0JDWjFxcVM3?= =?utf-8?B?ZW9yWVI2OG80bGd1WFlxSmF6bHJQdFkzVTNmTlA1aWdFWkQyUHZyN2Q2dEpJ?= =?utf-8?B?d0psUThsYi9uSXU3MndvNGtvVUhJTlVNVGV5b25kd3JYWGxlWnpZby9LVkxm?= =?utf-8?B?RkNMNDFqMUp5SHIxaVJvbFV2Tzk2RlhyU0VBZHJWODBtTHVlSDdPdDFPcEFo?= =?utf-8?B?M1I1a21uZ2JBckVHSklsVVVLblh1SFBPbEhMeGYxTHRDZzRubE1PbDVxTHpJ?= =?utf-8?B?UVdmbCtBWmZ0U0JyYjBaSHA0djUrTDluMEVxa3ZCT0tXOC9hYnVseFIzNnFT?= =?utf-8?B?N3FSZ1pWWHRGYmRwWE1Ma0hwSTIwN1VXZ2FFM2Q4VjZQSEEvRFdCenAvSVJx?= =?utf-8?B?bXhyeDhxd1AzYm1IdW5hNVlOOSsveUI0TXFoR0oxNE1aSkREdVF3d2x4amgw?= =?utf-8?B?Vzc2SkJIUTFINkNuMk1IOWVlRGZZZXF4K0J6Wjc5S0RhK0RLVG1rdXp0V0wv?= =?utf-8?B?T0JhY29OWkhXOGVMTHRJZmJiSitIaER2b0xzY01ZNzNydWxwUUNreVZnc0Qr?= =?utf-8?B?SDNQKzdLU2NMcEVHSVA5UlZuckdnbzgvOWIvOEF4SHlSU2h1TUxQck9pblBC?= =?utf-8?B?K3NmY01zSjREdFFZWTRxVXZpNHd1MU9JZUZ4bmtYRkp1K2VyV3J2b3lmaERo?= =?utf-8?B?UmFMNW0rZnZEcUhONkNoNlJJZWVsUUxlS0lreDRCZWdnU2xDbERPZmY3VDVY?= =?utf-8?B?RTAwU3U1bTBCTS9CZmhhb0NmREk4WXB4cDBEUXIyU3VJNk8yQVBoQW1WZXhH?= =?utf-8?B?T2M4MmQvZXNhVE9BRitncEZoUXF5MGRrWXpxbk9GbGxVbHcwMm1DWDZ0Y2hI?= =?utf-8?B?eDByeTZIbkFpUUZxVDdXT2NjZ2pFYnhxQ1hMekltYnBkZ3VxR2hGQXVJeHNi?= =?utf-8?B?Nnh3SWp2anVsdko1T2JaM3RVcmsvWDR4WmdZb2s1MWN6eE13cGcxSWlsM2JU?= =?utf-8?B?anczU0RaWEVMT1UrOXR6c3FPQ0JleE9Nd1J5UEQ4NUkwQU1QZlQ3STZDSEM2?= =?utf-8?B?dnNoS3NxUWdNZjBuUisvcXBHVWYrdmJxSFJXT1hiREhWSUt4R1JQWWl2eFBh?= =?utf-8?B?azEyMHFIM3NLZHdzcS9yOFNyL290L1QzR0FRUE82bjhST3pzT1R3ejBibEt0?= =?utf-8?B?M1FrS0J6QlROSVlHS0N4T0pkWVU0TXFjNkFlTkVRbHo3OCtmNGl3bzB0eXVZ?= =?utf-8?B?ZmlmVldhYUd0L1N5a2gzSmN0YlA3R0ZOdHJpZkd4UENFdStLVXF4YnpzNEFv?= =?utf-8?B?R1N5VTQzRGJ4TER4eHo5Z0hBbWxzOU4valJiNDU4MlhRUXMwclZuclYvZlVk?= =?utf-8?B?N0pqN2t6cVJ1UlFoako3OVM5ZkgxLzEwWGp3aGZNTVVPRjVnK09Hbm9sZ3BR?= =?utf-8?B?VWM4Mmxib3d5MmdKYkh3OFNQQ21QSzhGOVlhSzVldWkwOXovazdsYlROSFR0?= =?utf-8?B?OGxtMmVBbWNsM2o4bkFDd0RKZy9MWUFKeTNoU3pmVG9KT0wzMGhXNFF0MzFY?= =?utf-8?B?cmQ3RnlWbWYvOFRmYk1jTE96dDNtdTQ3ZU93VnpXUThxSDlXRmwzbkx6bGMy?= =?utf-8?B?Q1R4ZEZiNUp6RXE2VE1KWXVNVnlFOHdMdzF2OVRTMkN2YVFMaHZKVE9jSnNC?= =?utf-8?B?YVozRFNrTHVUbXphakNhb1c1MEN2Y1lFMEI3Skk1b3pNcDdpU3FoRThSU2VM?= =?utf-8?B?bzN0MWNieGpQcThyMUZQTm9OTG42azg5SS85NExaSGlYS3NVZy8xUnphSkhz?= =?utf-8?B?L2JOL3F1cm5PVjlhVEhXQjVtYkNnTVNEQ1A4SlhobTBGV2x3b0pyaHZ6U1Jw?= =?utf-8?B?Wmovc2pIMmY2ODNpSDJSNWt2RU5XSWRDUFZqakM5bjJLZCtnRW5oQnBCMXpS?= =?utf-8?B?TTd0dFdEQ3VVbkpZTG92bjZ5QUd4SGVVRGhqZml1bTd1NHl6ZjArT3VsZVFy?= =?utf-8?B?NDRGVzVDcDByYk04UGlaM0ZnSHdBWWZkZjVYdmladFpvTG41c1N4OUFQMXNw?= =?utf-8?Q?mEPJ2sIOV7e6GNcJy7xYSTsXD?= Content-Type: text/plain; charset="utf-8" Content-ID: <963D43C4BD8960498316A574EAAE293B@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: n3ajyhzCRMcmmqKew02VHWJEnMDogo8YCgir4BvtzKgx4Rs6RYHSEP7KiGPjdf2u2agLRHVH+/gH0A7eojzr9qidInBwTHRpDR4JbKGafwNObMDC6wLEinI/Sr8etu5YZD1tL9DQd7FXHa3K9wTnDGZU60vSm11vpCjjToyS8I8OnLVW1Nx8vT5mTHwHAyyGVktwMBT2pu3hZ2fNaXDdnc5oGTQi7s7J7Z640dbmNk57jzmx/e4v6wBPdgsFrR0HyJz+OgyRkehCSGDWLw3fjXCEGKJAq91cTHyvzqWPVUzsM3vqP2Md9Pa+HvG5h+UDtLMNneWAgh9H3xRPCV25YnDf2Wdia6xk1ZGZM5t84wp23b6ZtIIPP7LrEqxCv7UW6/yluHsI8eaqouXYClZRXhpD4RLDInK2NbMs0xPYwYGYui2dY9VPfIldeMWLfln/lAVYCYEYWy8BLJsMKAaB17pp+5HDe92+kz473FIye7I5jl1e4ruJH2kaGWftH99J6NjKWqEn9p/Bgc3AQsDnBWilbe4J37RFkNhrtdfjs4UHQk94qz3y2XlSOa6pT4hKtu7g7LvcsJ2Ox79Wt6eXB23cHa47vEVBexQPJ0pvSChBc2oQa3M4IEd0eZgEkkvJSYG4ZlaWKJF6XrO8U972NXtdog95DCxTaWM409DcyNDTmLNZvUwSwZkgJj3DKl0/6dcvp6HxqTMWzZUG5TUCemb46duAr8gvTUvq9EcqRjmK9qk7bDuja1QXF8XpOL5xBQIMuAQWtU112LqNRH/ZouxEhIJPa8C3/poArb0xB2aArhAqp8mFu80W4wDTRhw9 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 561bfbb8-daa3-4e30-4ebf-08daef168e5b X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jan 2023 12:15:38.2701 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nUp7YfNB8YGBVquC/yvFiTlwUa3RqWMPfg5o7aT4kTvuJlk6LYeL7iFUJIKVwNXJTMLVIFwp42S3hP0ENM5PtwZz0S2yCcVx75ghJwysMQc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5834 T24gMDUvMDEvMjAyMyAxMToxOSBhbSwgSnVsaWVuIEdyYWxsIHdyb3RlOg0KPiBPbiAwNS8wMS8y MDIzIDA5OjU5LCBBeWFuIEt1bWFyIEhhbGRlciB3cm90ZToNCj4+IEhpIEp1bGllbiwNCj4NCj4g SGksDQo+DQo+PiBJIGhhdmUgYSBjbGFyaWZpY2F0aW9uLg0KPj4NCj4+IE9uIDA1LzAxLzIwMjMg MDk6MjYsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4+PiBDQVVUSU9OOiBUaGlzIG1lc3NhZ2UgaGFz IG9yaWdpbmF0ZWQgZnJvbSBhbiBFeHRlcm5hbCBTb3VyY2UuIFBsZWFzZQ0KPj4+IHVzZSBwcm9w ZXIganVkZ21lbnQgYW5kIGNhdXRpb24gd2hlbiBvcGVuaW5nIGF0dGFjaG1lbnRzLCBjbGlja2lu Zw0KPj4+IGxpbmtzLCBvciByZXNwb25kaW5nIHRvIHRoaXMgZW1haWwuDQo+Pj4NCj4+Pg0KPj4+ IEhpIFN0ZWZhbm8sDQo+Pj4NCj4+PiBPbiAwNC8wMS8yMDIzIDIzOjQ3LCBTdGVmYW5vIFN0YWJl bGxpbmkgd3JvdGU6DQo+Pj4+IE9uIFR1ZSwgMyBKYW4gMjAyMywgTWljaGFsIE9yemVsIHdyb3Rl Og0KPj4+Pj4gUHJpbnRpbmcgbWVtb3J5IHNpemUgaW4gaGV4IHdpdGhvdXQgMHggcHJlZml4IGNh biBiZSBtaXNsZWFkaW5nLCBzbw0KPj4+Pj4gYWRkIGl0LiBBbHNvLCB0YWtlIHRoZSBvcHBvcnR1 bml0eSB0byBhZGhlcmUgdG8gODAgY2hhcnMgbGluZSBsZW5ndGgNCj4+Pj4+IGxpbWl0IGJ5IG1v dmluZyB0aGUgcHJpbnRrIGFyZ3VtZW50cyB0byB0aGUgbmV4dCBsaW5lLg0KPj4+Pj4NCj4+Pj4+ IFNpZ25lZC1vZmYtYnk6IE1pY2hhbCBPcnplbCA8bWljaGFsLm9yemVsQGFtZC5jb20+DQo+Pj4+ PiAtLS0NCj4+Pj4+IENoYW5nZXMgaW4gdjI6DQo+Pj4+PiDCoCAtIHdhczogIlByaW50IG1lbW9y eSBzaXplIGluIGRlY2ltYWwgaW4gY29uc3RydWN0X2RvbVUiDQo+Pj4+PiDCoCAtIHN0aWNrIHRv IGhleCBidXQgYWRkIGEgMHggcHJlZml4DQo+Pj4+PiDCoCAtIGFkaGVyZSB0byA4MCBjaGFycyBs aW5lIGxlbmd0aCBsaW1pdA0KPj4+Pg0KPj4+PiBIb25lc3RseSBJIHByZWZlciBkZWNpbWFsIGJ1 dCBhbHNvIGhleCBpcyBmaW5lLg0KPj4+DQo+Pj4gZGVjaW1hbCBpcyBwZXJmZWN0IGZvciB2ZXJ5 IHNtYWxsIHZhbHVlcywgYnV0IGFzIHdlIHByaW50IHRoZSBhbW91bnQgaW4NCj4+PiBLQiBpdCB3 aWxsIGJlY29tZSBhIGJpZyBtZXNzLiBIZXJlIHNvbWUgZXhhbXBsZXMgKGRlY2ltYWwgZmlyc3Qs IHRoZW4NCj4+PiBoZXhhZGVjaW1hbCk6DQo+Pj4NCj4+PiDCoCA1MTJNQjogNTI0Mjg4IHZzIDB4 ODAwMDANCj4+PiDCoCA1NTVNQjogNTY4MzIwIHZzIDB4OGFjMDANCj4+PiDCoCAxR0I6IDEwNDg1 NzYgdnMgMHgxMDAwMDANCj4+PiDCoCA1MTJHQjogNTM2ODcwOTEyIHZzIDB4MjAwMDAwMDANCj4+ PiDCoCAxVEI6IDEwNzM3NDE4MjQgdnMgMHg0MDAwMDAwMA0KPj4+DQo+Pj4gRm9yIHBvd2VyIG9m IHR3byB2YWx1ZXMsIHlvdSBtaWdodCBiZSBhYmxlIHRvIGZpbmQgeW91ciB3YXkgd2l0aA0KPj4+ IGRlY2ltYWwuIEl0IGlzIG1vcmUgZGlmZmljdWx0IGZvciBub24gcG93ZXIgb2YgdHdvIHVubGVz cyB5b3UgaGF2ZSBhDQo+Pj4gY2FsY3VsYXRvciBpbiBoYW5kLg0KPj4+DQo+Pj4gVGhlIG90aGVy IG9wdGlvbiBJIHN1Z2dlc3RlZCBpbiB2MSBpcyB0byBwcmludCB0aGUgYW1vdW50IGluIEtCL0dC L01CLg0KPj4+IFdvdWxkIHRoYXQgYmUgYmV0dGVyPw0KPj4+DQo+Pj4gVGhhdCBzYWlkLCB0byBi ZSBob25lc3QsIEkgYW0gbm90IGVudGlyZWx5IHN1cmUgd2h5IHdlIGFyZSBhY3R1YWxseQ0KPj4+ IHByaW50aW5nIGluIEtCLiBJdCB3b3VsZCBzZWVtcyBzdHJhbmdlIHRoYXQgc29tZW9uZSB3b3Vs ZCBjcmVhdGUgYQ0KPj4+IGd1ZXN0DQo+Pj4gd2l0aCBtZW1vcnkgbm90IGFsaWduZWQgdG8gMU1C Lg0KPj4NCj4+IEZvciBSVE9TIChaZXBoeXIgYW5kIEZyZWVSVE9TKSwgaXQgc2hvdWxkIGJlIHBv c3NpYmxlIGZvciBndWVzdHMgdG8NCj4+IGhhdmUgbWVtb3J5IGxlc3MgdGhhbiAxIE1CLCBpc24n dCBpdCA/DQo+DQo+IFllcy4gU28gZG9lcyBYVEYuIEJ1dCBtb3N0IG9mIHRoZSB1c2VycyBhcmUg bGlrZWx5IGdvaW5nIGFsbG9jYXRlIGF0DQo+IGxlYXN0IDFNQiAob3IgZXZlbiAyTUIgdG8gcmVk dWNlIHRoZSBUTEIgcHJlc3N1cmUpLg0KPg0KPiBTbyBpdCB3b3VsZCBiZSBiZXR0ZXIgdG8gcHJp bnQgdGhlIHZhbHVlIGluIGEgd2F5IHRoYXQgaXMgbW9yZQ0KPiBtZWFuaW5nZnVsIGZvciB0aGUg bWFqb3JpdHkgb2YgdGhlIHVzZXJzLg0KPg0KPj4+IFNvIEkgd291bGQgY29uc2lkZXIgdG8gY2hl Y2sgdGhlIHNpemUgaXMgMU1CLWFsaWduZWQgYW5kIHRoZW4gcHJpbnQgdGhlDQo+DQo+IEkgd2ls bCByZXRyYWN0IG15IHN1Z2dlc3Rpb24gdG8gY2hlY2sgdGhlIHNpemUuIFRoZXJlIGFyZSB0ZWNo bmljYWxseQ0KPiBubyByZXN0cmljdGlvbiB0byBydW4gYSBndWVzdCB3aXRoIGEgc2l6ZSBub3Qg YWxpZ25lZCB0byAxTUIuDQo+IEFsdGhvdWdoLCBpdCB3b3VsZCBzdGlsbCBzZWVtIHN0cmFuZ2Uu DQoNCkkgaGF2ZSBhIG5lZWQgdG8gZXh0ZW5kIHRvb2xzL3Rlc3RzL3RzeCB3aXRoIGEgVk0gdGhh dCBpcyBhIHNpbmdsZSA0aw0KcGFnZS7CoCBTb21ldGhpbmcgd2hpY2ggY2FuIGV4ZWN1dGUgQ1BV SUQgaW4gdGhlIGNvbnRleHQgb2YgYSBWTSBhbmQNCmNyb3NzLWNoZWNrIHRoZSByZXN1bHRzIHdp dGggd2hhdCB0aGUgInRvb2xzdGFjayIgKHRlc3QpIHRyaWVkIHRvIGNvbmZpZ3VyZS4NCg0KWGVu IGlzIGJ1Z2d5IGlmIGl0IGNhbm5vdCBvcGVyYXRlIGEgVk0gd2hpY2ggbG9va3MgbGlrZSB0aGF0 LCBhbmQgYQ0KYm9udXMgb2YgZXhwbGljaXRseSB0ZXN0aW5nIGxpa2UgdGhpcyBpcyB0aGF0IGl0 IGhlbHBzIHRvIHJlbW92ZQ0KaW5hcHByb3ByaWF0ZSBjaGVja3MuDQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Thu Jan 05 12:47:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 12:47:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471904.731941 (Exim 4.92) (envelope-from ) id 1pDPeo-00082q-RT; Thu, 05 Jan 2023 12:47:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471904.731941; Thu, 05 Jan 2023 12:47:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDPeo-00082j-Nn; Thu, 05 Jan 2023 12:47:42 +0000 Received: by outflank-mailman (input) for mailman id 471904; Thu, 05 Jan 2023 12:47:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDPem-00081o-VN; Thu, 05 Jan 2023 12:47:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDPem-0001y9-Sf; Thu, 05 Jan 2023 12:47:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDPem-0004kR-GO; Thu, 05 Jan 2023 12:47:40 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pDPem-0007oE-FO; Thu, 05 Jan 2023 12:47:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ZMNXeJV++glhK4En1x2i6SjIi8H7eoQIC1VTaQe7bcY=; b=Lqt6R7ZlumZAkTvsgnxzI6Xr/+ 0H24+oH7gkmW6iXqumLWDbPtiALjRKl/T7fweBahjFHv+GWYYsh8deCTjcamseiuxXwvcjiAyz5NX zwhHILSsbeZm1TiFPrzow/WE0vAqZP4CSxkykputKof3EtfICFjPhpeM9ZWEYcjlSeqo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 175577: tolerable FAIL - PUSHED X-Osstest-Failures: libvirt:test-arm64-arm64-libvirt-xsm:xen-boot:fail:heisenbug libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: libvirt=78b3400e50ee0ba01575749728aae9c79d9d116b X-Osstest-Versions-That: libvirt=9193bac260620fbeec580d709699b3e0f97b9bd7 From: osstest service owner Date: Thu, 05 Jan 2023 12:47:40 +0000 flight 175577 libvirt real [real] flight 175587 libvirt real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/175577/ http://logs.test-lab.xenproject.org/osstest/logs/175587/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-arm64-arm64-libvirt-xsm 8 xen-boot fail pass in 175587-retest Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 175587 never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 175587 never pass test-armhf-armhf-libvirt 16 saverestore-support-check fail like 175564 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 175564 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 175564 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: libvirt 78b3400e50ee0ba01575749728aae9c79d9d116b baseline version: libvirt 9193bac260620fbeec580d709699b3e0f97b9bd7 Last test of basis 175564 2023-01-04 04:20:21 Z 1 days Testing same since 175577 2023-01-05 04:18:49 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Michal Privoznik Peter Krempa jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git 9193bac260..78b3400e50 78b3400e50ee0ba01575749728aae9c79d9d116b -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Thu Jan 05 13:20:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 13:20:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471913.731953 (Exim 4.92) (envelope-from ) id 1pDQAS-0003w3-BH; Thu, 05 Jan 2023 13:20:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471913.731953; Thu, 05 Jan 2023 13:20:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDQAS-0003vw-8W; Thu, 05 Jan 2023 13:20:24 +0000 Received: by outflank-mailman (input) for mailman id 471913; Thu, 05 Jan 2023 13:20:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDQAQ-0003vq-Va for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 13:20:23 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b30c4293-8cfb-11ed-91b6-6bf2151ebd3b; Thu, 05 Jan 2023 14:20:20 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b30c4293-8cfb-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1672924820; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=ByrJoUcDQW/Jw5ganKu1HSJnrrgr2Xc0sa9YKf7jgcg=; b=L/C4QhKhdcx/XHGJnNL6xcf3kB9NEd3UayI8Fdjmksb5DOK0eAEeqDbq 5ytu6fR+M0IFoj64a77KOB5PU/pKKx+cK6cRvxTARC2AjqHBVCKqRJ2dP R2B2pmMPga2XB4Dly8l0wH1oJLXT+zEyywkrjr7Es+hcNop/X6IsRUATY E=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 90793652 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:wna+i6NrHskaRtvvrR2ql8FynXyQoLVcMsEvi/4bfWQNrUol3zJRz WIZWWrXPKmMYmf9edBwb9m+/BtUsZfVx9ZqTgto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQA+KmU4YoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvzrRC9H5qyo42tB5gFmPpingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0uhqHGFI0 Pg1EncIdwGj3ca5+p+HTsA506zPLOGzVG8eknRpzDWfBvc6W5HTBa7N4Le03h9p2JoIR6yHI ZNEN3w/N3wsYDUWUrsTIIkzhuillz/zYjRDrFO9rqsr+WnDigd21dABNfKEIoPbHpsIxC50o Ers0UOmDy4mOObB0GemsWmB3s3wrHv0Ddd6+LqQqacx3Qz7KnYoIAISfUu2p7++kEHWc8JSL QkY9zQjqYA29Ve3VZ/tUhugunmGsxUAHd1KHIUS6guA167V6AaxHXUfQ3hKb9lOiSMtbWV0j BnTxYqvXGEx9u3OIZ6AyluKhT2vJCgTCGsvX2gBVBoluf3smqwPijuaG76PD5WJptHyHDjxx RWDoy4/m6gfgKY36kmrwbzUq2ny/8aUF2bZ8i2SBzv4tV0hOOZJcqTysTDmAeB8wJF1p7Vrl FwNgICg4e8HFvlhfwTdEbxWTNlFCxtoWQAwYGKD/bF7rVxBGFb5J+i8BQ2Sw283WvvogRezP CfuVfp5vfe/xkeCY65teJ6WAM8316XmHtmNfqmKMYAeP8crJF/fpHAGiausM4fFyRFErE3CE c3DLZbE4YgyU8yLMwZat89CiOR2l0jSNEvYRIzhzgTP7IdykEW9EO9fWHPXN7BR0U9xiFmNm zqpH5fQmko3vSyXSnW/zLP/2nhTdSdjWMqr9pcOHgNBSyI/cFwc5zbq6etJU+RYc259zY8kI lnVtpdk9WfC IronPort-HdrOrdr: A9a23:watsgKsdkdKZltfVIqUM7ujA7skDZ9V00zEX/kB9WHVpm62j+v xG+c5xvyMc5wxhO03I5urwWpVoLUmzyXcX2+Us1NWZPDUO0VHARL2KhrGM/9SPIUzDH+dmpM JdT5Q= X-IronPort-AV: E=Sophos;i="5.96,303,1665460800"; d="scan'208";a="90793652" From: Sergey Dyasli To: CC: Sergey Dyasli , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH] x86/ucode/AMD: apply the patch early on every logical thread Date: Thu, 5 Jan 2023 13:20:04 +0000 Message-ID: <20230105132004.7750-1-sergey.dyasli@citrix.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit The original issue has been reported on AMD Bulldozer-based CPUs where ucode loading loses the LWP feature bit in order to gain the IBPB bit. LWP disabling is per-SMT core modification and needs to happen on each sibling SMT thread despite the shared microcode engine. Otherwise, logical CPUs will end up with different cpuid capabilities. Link: https://bugzilla.kernel.org/show_bug.cgi?id=216211 In Linux kernel this issue has been addressed by e7ad18d1169c ("x86/microcode/AMD: Apply the patch early on every logical thread"). Follow the same approach in Xen. Introduce SAME_UCODE match result and use it for early AMD ucode loading. Late loading is still performed only on the first of SMT siblings and only if a newer ucode revision has been provided (unless allow_same option is specified). Intel's side of things is modified for consistency but provides no functional change. Signed-off-by: Sergey Dyasli --- CC: Jan Beulich CC: Andrew Cooper CC: "Roger Pau Monné" CC: Wei Liu --- xen/arch/x86/cpu/microcode/amd.c | 16 +++++++++++++--- xen/arch/x86/cpu/microcode/intel.c | 9 +++++++-- xen/arch/x86/cpu/microcode/private.h | 1 + 3 files changed, 21 insertions(+), 5 deletions(-) diff --git a/xen/arch/x86/cpu/microcode/amd.c b/xen/arch/x86/cpu/microcode/amd.c index 4b097187a0..96db10a2e0 100644 --- a/xen/arch/x86/cpu/microcode/amd.c +++ b/xen/arch/x86/cpu/microcode/amd.c @@ -176,8 +176,13 @@ static enum microcode_match_result compare_revisions( if ( new_rev > old_rev ) return NEW_UCODE; - if ( opt_ucode_allow_same && new_rev == old_rev ) - return NEW_UCODE; + if ( new_rev == old_rev ) + { + if ( opt_ucode_allow_same ) + return NEW_UCODE; + else + return SAME_UCODE; + } return OLD_UCODE; } @@ -220,8 +225,13 @@ static int cf_check apply_microcode(const struct microcode_patch *patch) unsigned int cpu = smp_processor_id(); struct cpu_signature *sig = &per_cpu(cpu_sig, cpu); uint32_t rev, old_rev = sig->rev; + enum microcode_match_result result = microcode_fits(patch); - if ( microcode_fits(patch) != NEW_UCODE ) + /* + * Allow application of the same revision to pick up SMT-specific changes + * even if the revision of the other SMT thread is already up-to-date. + */ + if ( result != NEW_UCODE && result != SAME_UCODE ) return -EINVAL; if ( check_final_patch_levels(sig) ) diff --git a/xen/arch/x86/cpu/microcode/intel.c b/xen/arch/x86/cpu/microcode/intel.c index f7fec4b4ed..59a99eee4e 100644 --- a/xen/arch/x86/cpu/microcode/intel.c +++ b/xen/arch/x86/cpu/microcode/intel.c @@ -232,8 +232,13 @@ static enum microcode_match_result compare_revisions( if ( new_rev > old_rev ) return NEW_UCODE; - if ( opt_ucode_allow_same && new_rev == old_rev ) - return NEW_UCODE; + if ( new_rev == old_rev ) + { + if ( opt_ucode_allow_same ) + return NEW_UCODE; + else + return SAME_UCODE; + } /* * Treat pre-production as always applicable - anyone using pre-production diff --git a/xen/arch/x86/cpu/microcode/private.h b/xen/arch/x86/cpu/microcode/private.h index 73b095d5bf..c4c6729f56 100644 --- a/xen/arch/x86/cpu/microcode/private.h +++ b/xen/arch/x86/cpu/microcode/private.h @@ -7,6 +7,7 @@ extern bool opt_ucode_allow_same; enum microcode_match_result { OLD_UCODE, /* signature matched, but revision id is older or equal */ + SAME_UCODE, /* signature matched, but revision id is the same */ NEW_UCODE, /* signature matched, but revision id is newer */ MIS_UCODE, /* signature mismatched */ }; -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Thu Jan 05 13:41:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 13:41:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471920.731964 (Exim 4.92) (envelope-from ) id 1pDQUM-0006Mc-1L; Thu, 05 Jan 2023 13:40:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471920.731964; Thu, 05 Jan 2023 13:40:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDQUL-0006MV-UK; Thu, 05 Jan 2023 13:40:57 +0000 Received: by outflank-mailman (input) for mailman id 471920; Thu, 05 Jan 2023 13:40:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDQUK-0006MP-MH for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 13:40:56 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on2070.outbound.protection.outlook.com [40.107.8.70]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 936cee6e-8cfe-11ed-b8d0-410ff93cb8f0; Thu, 05 Jan 2023 14:40:54 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8640.eurprd04.prod.outlook.com (2603:10a6:102:21f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 13:40:52 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 13:40:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 936cee6e-8cfe-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m624Ro/TcUAEGaZVcd4acTgTW6U39SATAspbq+q2l/GlxHLMFFs/jMoQYrLHg2HUdB7UdPrff4hxL5uLNKgIkDy649wDM0AL1WCIlJvpLIT7CftEjBWBSQhcM2kxPuU7YezvwZPXcGrvafJvL9Jgg/3WcEoVO/OtxVY/VRNiqs4yPCV9sVuXJebcmjHCVpMGt7F5lCyhhVgrplegt29SOum4uDQG/z578Xq2O38rev0pQXjhH3hBzIvW8o0bAbJ+c+u73xXuN4YqSY3qTSDUrBBA+y8rGhQZglELwLOTYiTihpWtqxNky3OHgfMXBVQDtfOca5JF+HtO4Voswe7Kgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0ELXjnIH1l3VfliUzSU5AAkC8qMZTwHQR5Hju6YtaeU=; b=IRuIvA7TG5JizJU36HLurET2P9CUDOAhLJRKh8z9g5jwH/uBfHSQmDYJFsoOhVX0O3WTkbhwEWqhgFwBlZ0D8RkK0XBIigjUW3pBxgXk4/fOCkAFTxmH0GSDOwJZ7K1BVb0SGylT9+iQTa/m/DvjQw6rmi5PsIe0Mzuk1BMpj+RuYKHoR0ftUstUNYPPQ1Rwy+YIgUWsndz7FZ1ru19IMpXX4NxYUTJSLUkCwkOJZX1BBRRT6mQBPa2uP5zjxm9ogoAisHSl3A6XtmhkItrrZb6xwNkbIU9exdmkR2MKokycbIfObKO6BaNUCU+UEqU6NwyE+f+DbhdkQ4VqrMUq2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0ELXjnIH1l3VfliUzSU5AAkC8qMZTwHQR5Hju6YtaeU=; b=ooz5FSMRqfE/Z/YNVWn3rteEnJGUV+RcWByOisrMOe0zPpu6CsRlTE/FjKh+H3I2YkisshArPO4jVx65WFFJogjhFf9SXSgOqWqMZiz51xzK3P8j4dC3+FK6+o/pDZMmKR2P+RuvDx8yYnqYxfLNuP2VWb23XXq6y2GT9zBoQ4ZYN1UBbkY2bkxKQ+H9VKMUTNnM2hIZt6sWQskJcjAfeSlFkLEFYis9J2WAboK3TccZLnx0CJFYqo5iyrGCjs47za61nK3+dF+A6Kf0pakSnHF/RnSsP78xU8niPyWvlQz+EQFsg7d6Zha3UmJehW21Hu+EuZMarb83ymwjJHh+PQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <591d6624-2bd2-93f0-f5d6-760043230756@suse.com> Date: Thu, 5 Jan 2023 14:40:49 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v4 1/2] arch/riscv: initial RISC-V support to build/run minimal Xen Content-Language: en-US To: Oleksii Kurochko Cc: Bob Eshleman , Alistair Francis , Connor Davis , Julien Grall , Anthony PERARD , Andrew Cooper , Stefano Stabellini , Gianluca Guida , xen-devel@lists.xenproject.org References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0197.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a5::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8640:EE_ X-MS-Office365-Filtering-Correlation-Id: 34acf9eb-9845-479d-3821-08daef227638 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pzGs7xX+Ai8f9dpJatylOgWefTQBh6RVFqcG0BMBVkRPmT33fRbfPtuvbZKSvQtTPyS5BCnVyDtK3TK1rdbo/rFuThXSwZNV8vVqfu4fXrxgMAWp98d42eaQU33dngK3CvDI+DzR8Ifili8NB/R0JCbMavSSWjMxNqaq4MogUHDIUXstdsdRB0xZzf0+KP0j5LCnauniC2p/cjlKoPmQI1p1n0bczE1oXJVayyFSf+PAkmoDewgQ2D+DM5SFmWVZP5rdhPst7KN4CHL0h6pNJ4KhdLP0IcyM+/fG4RlRt09iQji1fg8y1PRonfQTs/ecsDcs+JnTQXgEWTlp2ScAtRIbNl7cEmTzOHke2mJuZi0z9VSppacqFbzdidJVu5Vb/ran3PEOU6oBx5cyFZqjXWT8mOLzS+quDQA0p4R02n4ec8oQwOLx9EQEaXzsVLK1XXmDpVNOXjgcORFJCrLNqlQQYpZfwdMHJUwL8UryZKbk07QpWPa8Ds8Qpo7VTPQg0Ti6qoNLB8Ewu9FKdpYRWKuqRJnX7tT2Er7R6J+xHcLp7CPoAW7Sy3ghZ676fLGVLWxn3gSIzY3ih1WtK2bZ5L1qFgDOJsC+UxrSrVn55vr/LdSwV9cKJ3n/7w0lGlOgAIbFNoczFzejZvORkd5K5vz/EO75Io4p5ddVGmDKgvTKApuy/kKmx1AWPa6Mj6crPGdIEN9R0jYCAJAd7sfb6lw8QDsGzDnTuexy8ET47xE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(376002)(396003)(346002)(366004)(136003)(451199015)(31686004)(53546011)(6512007)(186003)(66476007)(6666004)(66946007)(26005)(66556008)(478600001)(6486002)(2616005)(8676002)(6916009)(41300700001)(7416002)(8936002)(83380400001)(4326008)(5660300002)(2906002)(38100700002)(31696002)(86362001)(316002)(54906003)(6506007)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SVBlbUlVRWJGM0VXZ1ZFbjZ3bVY4MVVBWFc3R3daVFlORHU2Y0lwYWcycU1P?= =?utf-8?B?QWgzbzJIaU5sbndtVUxsQkIrRUd5N0JrMHRBdVkwR0toNWVQMUZmNC9lYXdy?= =?utf-8?B?bWMrSmRBak04Tjc5SUcvdGs0em1ja1VaeGtUMHBucE5JeEtzMDhhWTBXVk4x?= =?utf-8?B?bXFJLzNCb0FscVpmbDJzRVZEVVpFN2ZTZTFSN2RkS0VUallNKzRCdzFreVV4?= =?utf-8?B?THBBWnlNS0RDTE1kVU9sbnRuZys3ZkFHczBtY1RvR2RrM3dtOXFIdmw1VzVw?= =?utf-8?B?TGJXZmdDdU9TY0Y4OXZzWHppVk4yUy9icUsrNzBZdnFXdEkvdUxNSlJWbWRN?= =?utf-8?B?VjdGdVlsMys5NFU0QTBNb1UwZFBvYkVxS2U1UlhncUkxNDg3S2VhWjdreHRJ?= =?utf-8?B?b0FaYndxZzNxM0swNDluRVB5YUxCQVF2bFhleVpoMUVWcEJHM3IvSlpMc2NT?= =?utf-8?B?aHBzNm9OTXZrVW5ZTHVTT1d0SzZBZDJNbW5tYkVrMDVEWis1WGRJZmE4YW9Q?= =?utf-8?B?Q2FDdlNwbmFwUjN2ZXM4SkxmNXh2STZsWEVUOVpGN2o1YUdxRkM5Qjdaem5s?= =?utf-8?B?VDh2OG1lOGFTcExORVZwT2l0TnBtUG9pVktLSkxJamhUSUVycm83aGtQcWYv?= =?utf-8?B?amRNeE14S3EwbmFVTUlWN0JzZVZDMGJDaVZOU200L3BNckVob2JJWUVhV3dv?= =?utf-8?B?S1hvYXJOWjBqeTZIcFowczcrTW9xY1R3NGdGeE1mNUd3WVB4TEtQd0w5VnE4?= =?utf-8?B?SHlXRWNQcFlzVU1KTmhIOXRFYmpJT2c2L0l2Z3A1eFRVcGpCcXg2NWE0SDFK?= =?utf-8?B?cWxQYmJRbkJXajA4NEg4WncrL2J5RzZ6RnpjdmlyRlVscUhLL0FiL1J3Wmk5?= =?utf-8?B?V1VLR05NMXBsWStOcFd6eWpaeGw1NjJHbFFUbkhTQkN4TVJFdVdBVnJRbmNG?= =?utf-8?B?dC9YUmduQnRrbjdtWkE1S285MmY3bWo2WUNRcngveTRzSGlmOXhGTElKbXl2?= =?utf-8?B?cWRXaW5GZkQ2KzdMbHcrU2IzT0N4Zjl4YXQxOThQRkw0SkM3S0VBS0RXYjdx?= =?utf-8?B?bzhscUdRbDROLzBRNXBNajRoSHY3WFhTbTU2UFZqMmRKZjRZTXlnN3Aya1VS?= =?utf-8?B?M1RoeEgvZ3lzaHp3TFdCSnkxQXc0cjVWYVE3L0V6YjMwa3BaOFd3ZHZZay80?= =?utf-8?B?RmwyenJDQ09uRTAra0JRNkxhY3dua05jUEU4eXRZSGdSUkVmQW1LN3g0U3kr?= =?utf-8?B?eVU2WFdxeEFxMkpaL2Mxc2JMY0tpQ2JUZWswNjNVdTllY3EzQS9TS0I4M1Fh?= =?utf-8?B?YlZtZnh2Y3ljN29MNkpwa0ZzZWQrVmdhQzgrQTUwbzhBNTZVOEtCWnhNM1dM?= =?utf-8?B?eC9SMnJ1MGFOOVNhaUI4YTJ1VmlheXVlL1lRQzlTMCszNFdBcWVuOXhkeEJZ?= =?utf-8?B?U2M1Q2psQmloUkJPdjJzN3k2bXYrY3FtTG1VelV5N0ZSQm9raGZFQmZ6MjYv?= =?utf-8?B?RkxoMlZsVnh6M09xYlNEWU9abXBoc21MUUJ4blNKZzIxTEl1bGxqU3dHbEs4?= =?utf-8?B?enUwRStLeEt2YXEveWVzTlJYT3pvS2xtaUlrd2pTV2xPQjc5VUVRUUE3aHlq?= =?utf-8?B?NnZleGEzVDlkb3ZJemc4M2o2SldLTGpkS1ExRUFXcTZla01zRkxqTngrNC9D?= =?utf-8?B?YmkxbEhwTUhENS96RXlhUHlrd3ZDMDZ1aC9VNDRNc1hWNmJUa1VUU1E4bXhU?= =?utf-8?B?Y0xacXkxaE1yOUR4WWFDcGZMdWc1T0o5Nnk4UXE2aE1nREhWOUttQVRFdHlR?= =?utf-8?B?VGxWalAxbGdmdEVhWW9oSWhtWGZzQlJwNTlCMm03a01pVUo1WW9Jdy9LRzh0?= =?utf-8?B?bC93ZDlCMmxZS1Y4NHRDWTNiZkJOZlB3amRUbHE1SWpxdlUvOUpHc0NQZEMz?= =?utf-8?B?VEQrbkhOMEV6OUtMZ291TWUyRUNJQWlqNU1pMXJLMHJUOGU4Yk5OdlRSVGNV?= =?utf-8?B?cmJUQmF6aXlSSXdCV3M3ZDRZM3V2UWFOZTUvOGlpUGwvNnExL2p4MjFCNXFO?= =?utf-8?B?TEhUWWhjNWdzK1VGdUl1UmoxRzZMeVlQRDFpaEh5dTErVk41NGI0SWRBUnU2?= =?utf-8?Q?ds23T5EUeu+hFWT0NBqNLNx1o?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 34acf9eb-9845-479d-3821-08daef227638 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2023 13:40:52.0012 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: V6w1sdHbXCPJwQcfaUlFXsm1kpjD/VMJ95ECxDVAcNWV3lxcv2lUGwY2+svSx4fe/r8RkbQ6IsyNfdFMwTRkAQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8640 On 05.01.2023 13:01, Oleksii Kurochko wrote: > To run in debug mode should be done the following instructions: > $ qemu-system-riscv64 -M virt -smp 1 -nographic -m 2g \ > -kernel xen/xen -s -S > # In separate terminal: > $ riscv64-buildroot-linux-gnu-gdb > $ target remote :1234 > $ add-symbol-file /xen/xen-syms 0x80200000 > $ hb *0x80200000 > $ c # it should stop at instruction j 0x80200000 This suggests to me that Xen is meant to run at VA 0x80200000, whereas ... > --- a/xen/arch/riscv/include/asm/config.h > +++ b/xen/arch/riscv/include/asm/config.h > @@ -1,6 +1,9 @@ > #ifndef __RISCV_CONFIG_H__ > #define __RISCV_CONFIG_H__ > > +#include > +#include > + > #if defined(CONFIG_RISCV_64) > # define LONG_BYTEORDER 3 > # define ELFSIZE 64 > @@ -28,7 +31,7 @@ > > /* Linkage for RISCV */ > #ifdef __ASSEMBLY__ > -#define ALIGN .align 2 > +#define ALIGN .align 4 > > #define ENTRY(name) \ > .globl name; \ > @@ -36,6 +39,10 @@ > name: > #endif > > +#define XEN_VIRT_START _AT(UL, 0x00200000) ... here you specify a much lower address (and to be honest even 0x80200000 looks pretty low to me for 64-bit, and perhaps even for 32-bit). Could you clarify what the plans here are? Maybe this is merely a temporary thing, but not called out as such? Jan From xen-devel-bounces@lists.xenproject.org Thu Jan 05 13:42:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 13:42:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471927.731974 (Exim 4.92) (envelope-from ) id 1pDQVR-0006th-BP; Thu, 05 Jan 2023 13:42:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471927.731974; Thu, 05 Jan 2023 13:42:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDQVR-0006ta-8H; Thu, 05 Jan 2023 13:42:05 +0000 Received: by outflank-mailman (input) for mailman id 471927; Thu, 05 Jan 2023 13:42:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDQVQ-0006tR-0x for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 13:42:04 +0000 Received: from mail-ed1-x541.google.com (mail-ed1-x541.google.com [2a00:1450:4864:20::541]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bc475629-8cfe-11ed-91b6-6bf2151ebd3b; Thu, 05 Jan 2023 14:42:02 +0100 (CET) Received: by mail-ed1-x541.google.com with SMTP id b88so45573959edf.6 for ; Thu, 05 Jan 2023 05:42:02 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bc475629-8cfe-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=YrwToGlaZtM/V+QOWTx69dqDId0AmAIUx3GIoQbT6Bg=; b=d7Yq66CGlHscffW/i9FbHmDw9qnz1UeqlyB5MFPDT9uagCWjCP9z8OaZF3J/jjmIze aqXu0+93ye5pNGMmVU22HJAZUmOJj33x4VJnxV/CTo81My0jdX6pSopHIoCGhMoi807T uAmxrMiNepxMhQNJi2uO6lG6fZ2/6kFL/33uE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=YrwToGlaZtM/V+QOWTx69dqDId0AmAIUx3GIoQbT6Bg=; b=oxivEhUslR+KUfCRZ/tBFqQfMlGPBVKMtBgAj9Q+oWyl3hQScTWp0jfIhVobxjhfaU uvF63SAma0liBLdweHOiwNvPxFFlWMg3WKVmHxtNIOuzOlP+NbfYOT9zdzpQv+8734Kx RljEyyTcwaa64viIwdUq9Af2drY1ZpSGfzISh8U5klOeyh7YZ1W7ezpDfQBJeXXSzZMp SjbNMPtZzs+Vqr4qBZgCX8uZ3iScZQq1E/LqlaQsJzrLQISfWbD+h3ZQBY57TnHHMCaW sTmkU7zUJG2NaHB36jJu+IYAItSR6PhP3V7hRDrvWeMFrIytWLLgzdGxS0Q3dLmjmFiS e57w== X-Gm-Message-State: AFqh2ko+Aj40DtzvRP7ZjMSaP24ceZcIaegVdS3SavVezfwJFMwYHUjO iNyoLYrIiQZZfA4jYDlPwjT4sLzIW4lbS+DvNPbRFP3aJIa6dWqekWdUsw== X-Google-Smtp-Source: AMrXdXt1cX7PSjEZmptCzOl7HpzC6qTift+SlOxtvTDV0eugEZ3rhm6bgNwftK07TNzV6MZ1x2mi35Ubsxbtus12P+g= X-Received: by 2002:aa7:d895:0:b0:486:3d22:5685 with SMTP id u21-20020aa7d895000000b004863d225685mr3979832edq.106.1672926122015; Thu, 05 Jan 2023 05:42:02 -0800 (PST) MIME-Version: 1.0 From: George Dunlap Date: Thu, 5 Jan 2023 08:41:51 -0500 Message-ID: Subject: [ANNOUNCE] Call for agenda items for 12 January Community Call @ 1600 UTC To: Xen-devel Content-Type: multipart/alternative; boundary="0000000000003d17af05f18477c6" --0000000000003d17af05f18477c6 Content-Type: text/plain; charset="UTF-8" Hi all, NB that as discussed at the previous call, this month's community call is NEXT THURSDAY, 12 January. The proposed agenda is in https://cryptpad.fr/pad/#/2/pad/edit/9YJwttVUMtpCrgS4ZX3sbNyA/ and you can edit to add items. Alternatively, you can reply to this mail directly. Agenda items appreciated a few days before the call: please put your name besides items if you edit the document. Note the following administrative conventions for the call: * Unless, agreed in the previous meeting otherwise, the call is on the 1st Thursday of each month at 1600 British Time (either GMT or BST) * I usually send out a meeting reminder a few days before with a provisional agenda * To allow time to switch between meetings, we'll plan on starting the agenda at 16:05 sharp. Aim to join by 16:03 if possible to allocate time to sort out technical difficulties &c * If you want to be CC'ed please add or remove yourself from the sign-up-sheet at https://cryptpad.fr/pad/#/2/pad/edit/D9vGzihPxxAOe6RFPz0sRCf+/ Best Regards George == Dial-in Information == ## Meeting time 16:00 - 17:00 UTC Further International meeting times: https://www.timeanddate.com/worldclock/meetingdetails.html?year=2023&month=1&day=12&hour=16&min=0&sec=0&p1=1234&p2=37&p3=224&p4=179 ## Dial in details Web: https://meet.jit.si/XenProjectCommunityCall Dial-in info and pin can be found here: https://meet.jit.si/static/dialInInfo.html?room=XenProjectCommunityCall --0000000000003d17af05f18477c6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Hi all,

NB that as discussed at the previous = call, this month's community call is NEXT THURSDAY, 12 January.

T= he proposed agenda is in https://cryptpad.fr/pad/#/2/pad/edit/9YJwttVUMtpCr= gS4ZX3sbNyA/=C2=A0and you can edit to add items.=C2=A0 Alternatively, y= ou can reply to this mail directly.

Agenda items appreciated a fe= w days before the call: please put your name besides items if you edit the = document.

Note the following administrative conventions for the c= all:
* Unless, agreed in the previous meeting otherwise, the call is on = the 1st Thursday of each month at 1600 British Time (either GMT or BST)
= * I usually send out a meeting reminder a few days before with a provisiona= l agenda

* To allow time to switch between meetings, we'll pl= an on starting the agenda at 16:05 sharp.=C2=A0 Aim to join by 16:03 if pos= sible to allocate time to sort out technical difficulties &c

* If= you want to be CC'ed please add or remove yourself from the sign-up-sh= eet at=C2=A0https://cryptpad.fr/pad/#/2/pad/edit/D9vGzihPxxAOe6RFPz0sRCf+/<= /a>

Best Regards
George


=3D=3D Dial-in In= formation =3D=3D
## Meeting time
16:00 - 17:00 UTC
Further Interna= tional meeting times:=C2=A0https://www.timeanddate.com/worldclock/me= etingdetails.html?year=3D2023&month=3D1&day=3D12&hour=3D16&= min=3D0&sec=3D0&p1=3D1234&p2=3D37&p3=3D224&p4=3D179=


## Dial in details
Web:=C2=A0https://meet.jit.si/XenProjectCommunityCall=

Dial-in info and pin can be found here:

htt= ps://meet.jit.si/static/dialInInfo.html?room=3DXenProjectCommunityCall<= /p>

--0000000000003d17af05f18477c6-- From xen-devel-bounces@lists.xenproject.org Thu Jan 05 14:01:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 14:01:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471937.731986 (Exim 4.92) (envelope-from ) id 1pDQo7-000139-09; Thu, 05 Jan 2023 14:01:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471937.731986; Thu, 05 Jan 2023 14:01:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDQo6-000132-TF; Thu, 05 Jan 2023 14:01:22 +0000 Received: by outflank-mailman (input) for mailman id 471937; Thu, 05 Jan 2023 14:01:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDQo5-00012w-Eu for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 14:01:21 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2076.outbound.protection.outlook.com [40.107.249.76]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6e158459-8d01-11ed-91b6-6bf2151ebd3b; Thu, 05 Jan 2023 15:01:20 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7976.eurprd04.prod.outlook.com (2603:10a6:20b:2af::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 14:01:19 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 14:01:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6e158459-8d01-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jfYAIrI4wcKltuCEO6ZZUOZztEYPJ9+TqSQd+KEVEsL1yXXgX0YFpTTRmV7FO+NWioJ2us6AnLxg4mYUlVq3NxL9IRMYfZXZBrbuEE6ae6lqZMviIFGM4yueRdwz6N4FyJyh4w8X9no2sFX3DLcZUnFPG5jkPVPhsdUrR+9oeOKAjJhwauwqByEQt1AgUEsJJ9j0/REGscDO7qgWia49P03QsbRR/7rxEm17gG/BCqXFwMzDzZ6eVUmhHZ/FccW/FtfbGTRrM2oO0FK/XyvxWjg/JLYL8ZnhSu1gRhH0t3SpNTmdIJxlbESkNoTq9CDWO+WIMv1bhsdm+1Uuh4n7GQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pXqvXHLbXthir5g+J/oME+mWyeNJxBhm5JM/UMSs7BI=; b=aRq0J+LJHeKQRhhtHQ3kv5v+85H53IkyBTqTWkpPeov0iX1F/0R2klcrT6IbY1bPJHggqdyokqiUfzJGiVrAHpRIQS5pxlKFgKunen5jBG0xI7lUcMbmYXWvEACc032gnVzvDvCkcg2I4aRChp0wn35lQ1sKO4B4HQM0pjmUlm+WX9OcW+GALQ79KMjog0q4zRsKLO/T7rOqfWNApiWiLNoDnYctQq3ofcPv3q+A1pektjjs0gqTcvce95j2wS828+3l+8r7jnT0V1Be4mzi/xMlMILmvLEsyxRQRSrbmyZrI/tSsEfODZ3DYkEgmoifiEOQ6LZ5LcuZ75l1RVbJwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pXqvXHLbXthir5g+J/oME+mWyeNJxBhm5JM/UMSs7BI=; b=FAq2xY1+TwLbzkWzWeeiyvWauQeT2opAZ9rAQ5vi/eYR0L3YjRhBqO9qIZzwY1tOvXIdquKidts187MiOvoNm3sn6Qbmi/WF9054xvl/LI3nVn+37nYy0CSHTgIAhYj/WILvFauRkgIuUyK7GR28sNXi/34Qf1St19i7l4+y0z68l3OOUfhsWG6DWyEJIu0ueW+MwC/mNI1aLWNMkJ4pQo3YnhvkSw1T3YO6ci/po2WPloo+6Lxa6+tB/6YTVn6WOTcyxnueUHJrf+CJbithowANGiQiUb3YxtbMUCjaom03KmiwsfjOWsTtbXKEYLPRINIwx9k5k4e9eWf6ta52xA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 5 Jan 2023 15:01:17 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v6 3/5] x86/mm: make code robust to future PAT changes Content-Language: en-US To: Demi Marie Obenour Cc: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Tim Deegan , George Dunlap , xen-devel@lists.xenproject.org References: <00505454afa89b759122008852502a5ef7b1b1ee.1671744225.git.demi@invisiblethingslab.com> From: Jan Beulich In-Reply-To: <00505454afa89b759122008852502a5ef7b1b1ee.1671744225.git.demi@invisiblethingslab.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0112.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9d::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB7976:EE_ X-MS-Office365-Filtering-Correlation-Id: 3849455c-823c-494f-5e21-08daef255196 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0M4uPT5ioLkgH7QYDT2eUCGT8bd5ladOgH/OaItF8y7Hp93fDWsNJi+MLemG7H33KVl1hi+aHyl0VeIMRhbHvU7DNqN6vld9TDc6dFWujK9MffTFiBDc2AlczPSMpMaTy6AVeVNjEYTBW66t1kj2KivmimpI7WqrQJ01sVCr66U0YCoS6pnnia7CCH6VUpuZe2VcuNXlZZyl/6SEa7FIEhtqOcEsWNpzT6e4Okp+HWZAUx6gmZpy1P31hyCRXuCK7g373Hpq6p9gcDPMmhGUo+qPQLgPDQ2NKiTISkeLlZlcMPUCOjuIKo/y4UcKRnL7zt0FI8Lyot80gObyQElRLvxW6EuRmBPx45jIXaRg9RbtpqVRppU3wqO93PcVUstKRlVL8tKfPyE8od532yND/T+jFqvedmWOtz7Kc3SJD2kAoCU4ao+RUtGkHTGLleZzJWUitwbA7nFmHTZDdWljpv4tHvWrXMbTkAKM4LFkgYo3V1mCLyb7iO5jL3FtjNVQL20h3lDCZp9xoEOzD3xQ8/msftkC4rL56ggGkGR06RO+XxNDea7e1m4+oJJSUuv2PEknXLLS+mWatMnfkUze0342Grqaymn+GEamvEeT1oX7qq3bUrUJIBe9jKYUPr9W+HkY1sHhxX/4tZrjjg+jkRZv2kZQr5ybEKCuB5Oh/84Ynj7H1SuY3fygxUS7d7x8jzTnOb18XNmFSK/rb70tH31EIVFxKreSztT3XvtYDtA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(39860400002)(136003)(376002)(396003)(346002)(451199015)(2616005)(6486002)(316002)(186003)(26005)(6512007)(478600001)(6506007)(36756003)(86362001)(31696002)(54906003)(53546011)(6916009)(41300700001)(8936002)(83380400001)(8676002)(66476007)(5660300002)(4326008)(31686004)(66556008)(2906002)(66946007)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VWJtOTJ3M2xkK1ZkR1ZKbkZkSk5QcFh2bjAycGUvTXlwejRZdGJ0TjljK29i?= =?utf-8?B?K3dhWlBRaFZVYkdJMktFbEh1VTVRTjdQeW93M1FlVm4rdzdWekVZeXViRm16?= =?utf-8?B?Ui8yaFBvTHpBNnBFTXJqTXpwazMxc1IybkM5OG9hMmxEYndmczNUZDAveU5Q?= =?utf-8?B?T2hqY2JRanhDaFh2V3ZUS2x0YmxqdG15L0lQamx0WnVKUWFVWUlYb3Y1N3ZU?= =?utf-8?B?a1Zvb0xwYmViU0NFd1BkczdtTVNPcTlkbllETXNzRmZYci84YUdpOUpiSE1y?= =?utf-8?B?a0w2N0xNcCtNZ2sxSnAyVzludGZkeHRiS0E1dGI1QUVKMGpoNGZYbmdxeWw2?= =?utf-8?B?V3NseFo0c0Q3QmsyeVFOQ0U0TlRCZjRuY2lacFhWUFljTG0vVDR6VFdNQlNt?= =?utf-8?B?M1Y5UmxISXpmT1RmVWhocHdNTlFDUlBWT0hjVUoyUHh4eEFQWnFiQzRMbEI0?= =?utf-8?B?cUQ2QmZpbGNtbW1OVER2TkEzQytmeVBMblNZbUo3bU5KZ0pxQTd1cGhxa0JJ?= =?utf-8?B?OFJNaVVpamd0OVNsMWNQNTQ1OWpwYUpLNzhVazhWVTJOdGFsSkhmUFZYclpl?= =?utf-8?B?TTlMTjhKZlVTeDA1a1VQcWNMNXpvdTI2V0dFdms1ZVJvdlQyREtHdkd2VFFo?= =?utf-8?B?b1Vma2pBMlgzWWE2cGdJNUxYdXNlaTRVVGtDY1puZUpMcERhdndUR1lBdDZi?= =?utf-8?B?UzFWT2p4dzVwOUN1YjJFb3BOWVQ0eGFCUDdqTCtQQm1lYWtJWm1zSk1TWW96?= =?utf-8?B?bTdFTE4xSHNLUHpkYjVzRG9QdTNBdTZQOXVmV0dyeHRGZUZhMlFUZkRCRnV1?= =?utf-8?B?UURYSTJxSm5aT0Rlb1M0RUxpMkZNYU1yb0tlejRQTHFFcGxwL0pEVjlTUm1r?= =?utf-8?B?RmlkQ0RYTnd3NlFvbEVNcWlBaWptRmphc0Q4M2N2UzNFRkMxRWpBMDB5UkNh?= =?utf-8?B?emNhQmk0eVVBZXdYRkNaL29vSmZFRnRyaHQ5ekp6bEJmckJhTmVDQkZoWlVm?= =?utf-8?B?R0t3ZjBDN0hlaFYweCswcTFJRzJxNVhMOER4T3NNQUdPQTVUNGhKRmp4TVJM?= =?utf-8?B?MjRUdFVQaDRGRjg1NStST3hzdnF4ZWN3WDdBM2FmL295WE1nTGFVL1FEbmk3?= =?utf-8?B?ZGt3VzR5cnVnaDdZWUpJS2VDMnJkRTNBdkZreVVCelQrdEdKeHVPTkl5NHhQ?= =?utf-8?B?S1Vub0svYlJlQSthMGd6aTUwOW0vVXFBOTVWVU5MU2poajIzYUdtVDFFMTI4?= =?utf-8?B?c0c4amE2UWhleXNiNzhVcDRTS2xTd3hCb1pjZ1NINGtMWE9TWWxkNVlxQ201?= =?utf-8?B?VlpBVzNQLzhqYzBnYW5hQnNOMXFKTHRkbjhkcEJtaTBHVjh2TXN4Q0VWWGJs?= =?utf-8?B?TmZydVl6L09FZ3BWK1pRaFhQd05GR0lQaVNLNVZGTS9pbjZ5RS9yZzcyRXdt?= =?utf-8?B?SlRiYU1lTHdsbzV0OFZTY3cxZEdTNXhGcE9yS2s5c0RCWWhpYTc1UjhRRlo2?= =?utf-8?B?N2ROenJkZ0JvNzhIRGlOQzRYdUZqZmZlNlNTVU5JNEhzV3Q5ZDJHR3FvL0o4?= =?utf-8?B?TkFNNlBtbWlSUm1uZlFXbzBlMlI0YVNFcnY0WXBNOWZLN1ZLTUc4VnVteHlS?= =?utf-8?B?ZHFzNFpyOTY2NXE2UURoNFM2cEdtK0FQSms1UHFmNE9xWVB0VnlZeXkrcFBB?= =?utf-8?B?NjRRTllWbEVxMy96YTB0UXFPUWlzcVlEc2lQNTYwTHM0b2hZOXFlc0tYU29H?= =?utf-8?B?OXgzbmxHMmdDT3dIbG9ROG5Wb0k0QXEwa3d3LzhpdTZkRTRVcVpMb2hYa0RP?= =?utf-8?B?SHM2NlVGY2QvODNzQW1yOWxhNi9PWE9KZnluMnhRdGVpL0lVblNxblRkRnRq?= =?utf-8?B?OTE3c2JvekV4N0VVWFg1VjMvR20wNkh0RXpmUmRTK1lBRUd6MFNCUlVBSnBY?= =?utf-8?B?MFFCdnpzTGtHbGZtbFFmbUxOMk95MlN3M01oMFRnYkhjMGR3WmZBMmN6Yndy?= =?utf-8?B?TWV4NkRGbTB5eFEwM0Y2d0E4K0NLMGkvR0ZHYm5XWkMxdGtvektvZzlOSnVE?= =?utf-8?B?QlgvZStUVkZaL3NteStXclRUbndaWlpScW11dXZEMW14SVBLZUlucGRidFJK?= =?utf-8?Q?MJ54of3L2cCCOnr4KffkqQ07r?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3849455c-823c-494f-5e21-08daef255196 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2023 14:01:19.0171 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /ROGeeHtFAGgu4QsrH5XSBSp1MjAUCpFbQWzyvVzTzgLS6/YKKwiX1KAgTTD+1K0xUqaCArE5okmMB8nXFz8fA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7976 On 22.12.2022 23:31, Demi Marie Obenour wrote: > --- a/xen/arch/x86/mm.c > +++ b/xen/arch/x86/mm.c > @@ -6352,6 +6352,11 @@ unsigned long get_upper_mfn_bound(void) > return min(max_mfn, 1UL << (paddr_bits - PAGE_SHIFT)) - 1; > } > > + > +/* Nit: Please avoid introducing double blank lines. > + * A bunch of static assertions to check that the XEN_MSR_PAT is valid > + * and consistent with the _PAGE_* macros, and that _PAGE_WB is zero. This comment is too specific for a function of ... > + */ > static void __init __maybe_unused build_assertions(void) ... this name, in this file. > @@ -6361,6 +6366,71 @@ static void __init __maybe_unused build_assertions(void) > * using different PATs will not work. > */ > BUILD_BUG_ON(XEN_MSR_PAT != 0x050100070406ULL); > + > + /* > + * _PAGE_WB must be zero for several reasons, not least because Linux > + * PV guests assume it. > + */ > + BUILD_BUG_ON(_PAGE_WB); > + > +#define PAT_ENTRY(v) \ > + (BUILD_BUG_ON_ZERO(((v) < 0) || ((v) > 7)) + \ > + (0xFF & (XEN_MSR_PAT >> (8 * (v))))) > + > + /* Validate at compile-time that v is a valid value for a PAT entry */ > +#define CHECK_PAT_ENTRY_VALUE(v) \ > + BUILD_BUG_ON((v) < 0 || (v) > 7 || \ See my v5 comments. Jan From xen-devel-bounces@lists.xenproject.org Thu Jan 05 14:19:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 14:19:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471944.731996 (Exim 4.92) (envelope-from ) id 1pDR60-0002eI-F8; Thu, 05 Jan 2023 14:19:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471944.731996; Thu, 05 Jan 2023 14:19:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDR60-0002eB-CJ; Thu, 05 Jan 2023 14:19:52 +0000 Received: by outflank-mailman (input) for mailman id 471944; Thu, 05 Jan 2023 14:19:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDR5z-0002e5-G1 for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 14:19:51 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 02593f81-8d04-11ed-91b6-6bf2151ebd3b; Thu, 05 Jan 2023 15:19:49 +0100 (CET) Received: from mail-bn7nam10lp2103.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.103]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 05 Jan 2023 09:19:45 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DM6PR03MB4924.namprd03.prod.outlook.com (2603:10b6:5:1f2::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 14:19:42 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 14:19:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 02593f81-8d04-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1672928389; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=+yGZRXvGO+UVpHf9k+TYi2cBP1Ac/eKITtQzNYJkGlQ=; b=WeGqc1VmVVuS2Y7cUEmO3lUkM3NC6DJb7BDge9IiHIhQbBanAzXNvs8+ 7sVyQ+dfhRkOFehUGcDGC4jRSl0I9OJGNQuUF1/0kiB4Rx4Z9Xwfg9puA B7RxamxMNf+q8+M0zSu7ZQZ5u/k2xfwHMzFET3BlCmy+Y+amBT9GaPDw1 w=; X-IronPort-RemoteIP: 104.47.70.103 X-IronPort-MID: 91735738 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:SvxiAKnrRdxr73YIM3eI2bHo5gysJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xJMXDqPOqncajb1eY1wao+x8EgCvJLUytZjGQNtqCwzFyMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icf3grHmeIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aqaVA8w5ARkPqgS5AKGzBH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 f0fE2EBZ03cvbmd55CcZcVTqc8EJ9a+aevzulk4pd3YJdAPZMmbBo/suppf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVk1Q3ieC2WDbWUoXiqcF9t0CUv G/ZuU/+BQkXLoe3wjuZ6HO8wOTImEsXXapDTeLjq6Ex0DV/wEQJEj42bFahk8PhoUC/fspzK nU/pAQh+P1aGEuDC4OVsweDiHyOswMYWtFQO/Yn8wzLwa3Riy6JC25BQjNfZdgOsM4tWSdsx lKPh8nuBzFkrPuSU3313qiQhSO/P24SN2BqWMMfZQ4M4t2mqodsiBvKF45nCPTs1oazHizsy TeXqiR4n68UkcMAy6S8+xbAni6ooZ/KCAUy4207Q16Y0++wX6b9D6TA1LQRxa8dRGpFZjFtZ EQ5pvU= IronPort-HdrOrdr: A9a23:8cJE46g8U3u9jJtJtR8kelhTFnBQXtIji2hC6mlwRA09TyX4rb HMoB1/73TJYVkqNU3I9ertBED4ewK4yXcX2+ks1NWZMjUO0VHAROtfBODZogEIdReQysdtkZ 1KXINaYeeAb2RHsQ== X-IronPort-AV: E=Sophos;i="5.96,303,1665460800"; d="scan'208";a="91735738" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XzoHwUik2GVOOmptzIG5rMi4xwNuoXZEa3p72ClICGxDm4wzZO1Tus1ADDJvR6Ht0d1ku2qCLbUiUJm9HuZG498hRXRQWoS613HmOxaV+3XTTUyVBTaTYviAeIk/k9bfutYAQCshJSYTlmr5uu9MytOtDZxshMOW4sRLWUqVytXE7rTdUuh0xn1ZuuEvHYdmUTPKXtIIkoBa95gpSYFHvLaoQMqoroAG68U+kRYTbUUw5eyIPK8CXpBH2ae2Iz2bMbMV6iKfc/SZ9R0MnPTYkpaLBgDyTOdOI0OW4zxjeAT8LW21sYYGaas8So2Yt86vi5dXF/AWiWBw4W69FJVi7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+yGZRXvGO+UVpHf9k+TYi2cBP1Ac/eKITtQzNYJkGlQ=; b=AdROlE6D309vvUFefv6kkO+1igeyry1s7hTZZNfcuBhpc+HmbHAESBjuWc4SAXKkv94PJz/zW2j27rHTlSdHz0zBUnw/acZSb9GQQjn/cfZIHyDu8yMFVr/9d417Hk+rtMKuid/OvEjQpDdxMdgFK0C6n6J3d5wlFLjkiI//K3Opow1OAYFn2KtZSttv/4P/EL7QkdYymlaQCD87S8cCpSal4jhQ4BmN66pSbgqJ85PNdLj6NTFaVhX57mZdleGKMDreYTMiqWLzrxf4Pb2rWv5IzW2be+tjhizYEEzGb2Yc96GfBzBTVE9pi6Ip0ebU5ZKttmORYWuU7PrDx7Lc8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+yGZRXvGO+UVpHf9k+TYi2cBP1Ac/eKITtQzNYJkGlQ=; b=qSb6hO2wsQq6gNj0WspyOcQdMHIi3q8eBdQRZQr5HOLGU8YyUJE5UjtqhWU+DUbW5O0/+Iptqa562F8dLy+ZUQcAwVR+LCZ2mjK+70gFgmVlcGowXLOxR1ZhEFALUjfOjIgT2BfDaSYArwc3K9W5DdjEGEROwDVJqZPx3crYsKQ= From: Andrew Cooper To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Wei Liu , Roger Pau Monne Subject: Re: [PATCH 0/2] x86: adjustments to .fixup section handling Thread-Topic: [PATCH 0/2] x86: adjustments to .fixup section handling Thread-Index: AQHZIPZlI/g6KVqo90Cr/TLfuVP4Fq6P35OA Date: Thu, 5 Jan 2023 14:19:42 +0000 Message-ID: <2385cc5f-0680-2ce2-4411-d56df75d2133@citrix.com> References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|DM6PR03MB4924:EE_ x-ms-office365-filtering-correlation-id: 3cb2e80f-323d-4994-ef58-08daef27e371 x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hQwRc0j1GL58PpwL+MmfEOPPtToKA2KvqnJRrHPRa5qcyfkrfVHfak6uIRI+6QL1oblI5/+cQ1cLSVJwU6UuCZCA4eKRzLwF1hDfCWq/s9Cyyt2OsNXAp8kZ9MQ1d0Pd+qx35qs8C1w4Np3hmWv3vHNfuUSjALX00ZQ2FmW/FmOOXvZQPdf6mfdFwY6bIznQLlI4ARj+FZPiqFyDvl0r/BCZHFPi/owoMku+vAMSJQJNdJeINXDTZwpM3KjUbCK1pRJfr5MOtGISisVPfD0MMCVVsFvBJPnORFZPBmHCEnTjKO9TEfD8bNIY0jnS7LcAH8t9WcnsPMGGUSnGc5oTgXr9ukd/R6S8+1tFA0rYDEnLBhldOP+Bk8M5Pfxdg8oNbdEis3MK94xz5+m030+MaHz+UvUzPM3bM9mAUMqcGj1kRLU2kTEwnisal1I24vNDp2pvU0szJcsc7TAWC23nTjLlF8Aj9L4wWuM8UiMqfkLIbrCLrWrz2zxm2v0H54d4b8Dj60Vo+jAyeB80tKQTQK9udbZgzpqNaz90QXvm+6T6He0edKZTJohkF0ZV5Hbzcu82X+LrtSlfJu1ycLi/H+ifwDFkQelJOPjebQtkRZx9uFNaHiNG5g9wuxm7yFR3sAy6YxvR6ojIYESr5uERcNi11DPPu3LKQTBloDUH5dZbI4DsoEu/gks+aX1nHg5rKhoF2pF8/UOd1U+yQA99ljzYmwfn3KD+0KDRHrjmFqUcXbbzcvu2Eokp14w3AzJ/Jv8N2oX/aRAjpu5NeJ+hRkdxT58UV89B89B/Tme0S6M= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(396003)(39860400002)(366004)(376002)(451199015)(107886003)(6512007)(26005)(186003)(8936002)(71200400001)(83380400001)(6486002)(478600001)(53546011)(6506007)(31686004)(91956017)(54906003)(316002)(66946007)(2616005)(66476007)(8676002)(66556008)(76116006)(66446008)(4326008)(64756008)(41300700001)(38070700005)(36756003)(82960400001)(122000001)(5660300002)(110136005)(2906002)(38100700002)(31696002)(86362001)(142923001)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?djJXOUkxTTZtK1pUMjdUYy9EdkVJamxiVWpEU0YrTTVVczB0ZzkzaGRlem4v?= =?utf-8?B?VXZWV2NlZUFKTlNJM2ovdFMvNjBJYTh3YUZlWUYwYklUMXVWcDg4cE1XWkY5?= =?utf-8?B?QXFDYTF3aEF2b2JFSmpibFpVdk9aL3Q1ajBvQ2kza1ZKeDBja1l3YzZXaWFh?= =?utf-8?B?NTJDeURYQVMwMGZXc3d1NjNJWUlEWU9zZ1JzTTBNV0hwZjJjMG50OU5xSDRt?= =?utf-8?B?ZXYydWxqNkpzWk52ay9FZGluNnFZaFhJNjBYSW1QVVhlTGRkVklDSHlQK3ha?= =?utf-8?B?dlM5VGFlekJBT2lBVmw4Z1R2QURYalVxRVcyN2YwYUNJdGxmMXB0M2xUY2VV?= =?utf-8?B?VDAzdGw1dFpZQ3gwbkJtZ0tGekJ6aW91d254K0thR0xjc0tBVjlxNy82UGd1?= =?utf-8?B?eGU4Z3RKSHRMRGtzWHphZzQ1M0RmVCt5SFhNbEFoR3NoSVY1NXAyNVpMSm5Z?= =?utf-8?B?WHB6MFRnczhKblIrcXpoQmttMkwydWhqa0Y5cmlVbE9FYjRVdXVvSUZBdUxv?= =?utf-8?B?UHcrS0tvaUdQdE9PRjY4UUg4VUFpclVPNTh1Y1NlVGVhOFJ3aWF0Yy9pUHNw?= =?utf-8?B?bjhDUjRYdmJMVGFuU21ZTGx1QUVZZ05GRVhOVEMxS2pzaHY1RThJYVJPRlV0?= =?utf-8?B?U3d4T3BON0lYN0RLQlljcEdGSjlRWUJkMktOdWlkMGpzRURPZkhwaFRQUUZX?= =?utf-8?B?KzJ4Y1M2WTEwVFJXQUJZL2NyZldSR1YxZzhibUZwVVZZMTRrVXd0YXhqZzBx?= =?utf-8?B?SG1YdU5QR0FLaEFiZmVGdmJRY01vY1FFRlhtd3UxdUVVS0djZm5UVE5uR2JC?= =?utf-8?B?ajlSVy9IZW8wVVRpc1kvNCtOWHNwczQ3QkVsa1RBVXp3bCtVQ2hncnlQdVd6?= =?utf-8?B?YjBrUTZCWTE3czFyRFNUNHZJVFM2aVVmdVMrOHBHdE16UkZHUFVCbUh4WnBl?= =?utf-8?B?c3lTeXpOOTdENXhnSmpRSWM1OG9oS2ZyV0hFOHpCQmpaNm8wVVJJM1ZYbmFS?= =?utf-8?B?RDlnWHNjeS9LNlRHeDFCVW4zQ0JXR3RnN3ZRcitpNEhWcHh6VDBqeG5KNUFo?= =?utf-8?B?YlVDZ3FuT3V2dHpVR2VFSXJWNFJMK2lSRWVoN01FU3RVTG9XYmlHcWkxa2ZT?= =?utf-8?B?TUV3ZHJ1N1ZYTXJRL3g2T29SOVpjNEdoMlluVmxyWDJUOHJrY2FvTGNlYi9P?= =?utf-8?B?UWxaeXJNOXE1RzczdVZkWjFEcmRWOXdmMjUyTmRTVXVzT3BaSmZwOWp2WjFE?= =?utf-8?B?bUVCM1ViTzZaU0ZBYVVCZEZ3YUJWampXQ3pUK3hUdWxIYnNDQ3o4S2tlcXlH?= =?utf-8?B?NnhFRGFQSnI1WkNqOGxKUmlIOG1YTndKVkNUbit0UUlkTHUwODFDK3A3czAz?= =?utf-8?B?SnlmMlVjTGlJUURLNVJhUlo5QnBEQXdtMGM5WWxBL0NkenkxQzZ2VVJlM2RF?= =?utf-8?B?SWgwSTRCM2xkUHhOUXhoaktQTG90ZHlCWWN6cll2azE2czI5OHlkZitiS0tu?= =?utf-8?B?eTJmbTFEbEppRmczbkZPcUJZY0d5OVU1c1JBUzBMdDdBN1pDTkptWStKNE8w?= =?utf-8?B?YS9sU0hLeWJOSUtESDFBQkRIczBLbkE2eUpKTlE0d1pKVUZmOG1nTDdjNUZw?= =?utf-8?B?OGtoRW54Zjg3U08zRmkydnVkNzFhNTFKL3lJNDB0UDdtUXExbWYzblB5dTZs?= =?utf-8?B?eDJiTmh0dEV3SEpUNW9SN0hHNGRGT2xZR2lBZzlkcm9PVS9ldTY3MENaS205?= =?utf-8?B?SEFLR0tqU1E2azFIS2Jkc0d0dmE4VW5Rc3JLSlV3bksrVkpsWVBpMEdDU0s1?= =?utf-8?B?SmFYbDdpd0Q2TlVNK3NEemdjbmJRT09pOWdnbEdHQVF5Vm5EYWNabmhXeFJI?= =?utf-8?B?WE82VDZEaHZDS3NjVCtnOUpKWFhneDRxMTU1M08vQ3JKME04SHNHUFA3Zkk5?= =?utf-8?B?ZCtGK1hSMGtNV2NsRlNlN2hRcDJWTE1Uc3VDSmRJeUVMbTdzYVBrdm5SZm9K?= =?utf-8?B?czdXTHE4eWpLNWt2VEVZZmNBYno3QnBCVjBPa3Jkd29wZ0RGVjVaeEZ1dXBa?= =?utf-8?B?dVFOVEJab2owUHJpNVNtS1FaL3FtYjFWaG5xV3JGaTZzQU1OT3BOWnJCNUFX?= =?utf-8?B?RFJFZGtVNWpVLy9hWjJtbERHZUcwNFlkUTdjMWRLbld1UWppcVlQdEJiYlVr?= =?utf-8?B?MUE9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <8EB551F302AD8546BD280F143C24B64E@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: ye27i/udrfAaB2JaV24MGVsHHVVcsgWwd9inFkOck8tcTaT0rh05CsjM5C/jNBtXlgd0evdKXnXRmGdIKA3pftmRUrJ4J7tAV2Ly+r8x3rjI3Y4l13MOsfqSAEa7zX8x3banpSVo/rsIQJ/DI7S2TCoR6OX8duFVvQt3ckBYWWhdtcIQ0Lx8nlcRKyQJKM4RXXLSk2eHjBfKXVV8dy+udbOIvJeLRao7SngElIYkzajpgcmEVgSTBpHleQ1o2Umj1QHF60hraFjEPa5o9J1X8BJKI17YcTJcmgx62s1BSPjP+Hm8Erq7Zclmd6v1glNerJ4jYoz8AUPgXo3wodnzg+i5n90I1Ti9QOEjFw1m9FAbjcPZ+PAuwli/7/vXX9u+0fCAqx1xLh9JodlbFMFgBYMiMXt8WQB4PHW4adIcemACqIsUYVVWRWLp7FPEOg8aGG4gRShSx5onYAa4y0f+mKt0aPRJz4Y8KxY5nNlO9k3reGvpf0UujGfNJcMTZomX7MAaQvhwb01OjKwnz6dF+7yB/n1k2cJWRFL/N5nHvoBoEcqbTqcRt8IVRPBbsYljgvePjujTlbJ2OnmHUMImHpXVZHC1umznR28Db8k8ecbZIlchgUcuZGaamUsOibnD2zaafTCh3LxQvKvyOwKpsGVINPRUp/Gadb02seYfLL5va6sz7JKM/lgRz9yQD/wVQcsCMB6DWbCYpwXOXVn8OdD7mYp1D6pHapbu68BSKbIvMElsmxXmsOWhcTjBtce9oqNdnDqSQyucJ/O1ZKGDG1TDbmPcSf3+8gxNXwMkk1EpVaFpZnHQEyBxGaeo4RWw X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3cb2e80f-323d-4994-ef58-08daef27e371 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jan 2023 14:19:42.4848 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: e0wH7PX80qklJj2XrcXnc/0iRC5UMxZh/N8D+gCVXIqT6IOGFhFZPaby4cnL1Uwq9mRghO4Hd5xOUCVsntB2yI0ke+68BnrE0Y1qcrmF7LA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4924 T24gMDUvMDEvMjAyMyAxMToxMCBhbSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IDE6IG1hY3JvaXpl IHN3aXRjaGVzIHRvL2Zyb20gLmZpeHVwIHNlY3Rpb24NCj4gMjogc3BsaXQgLmZpeHVwIHNlY3Rp b24gd2l0aCBuZXcgZW5vdWdoIGdhcw0KPg0KPiBKYW4NCg0KSG9uZXN0bHksIEkgd2FzIHBsYW5u aW5nIHRvIG1ha2UgYW5vdGhlciBlZmZvcnQgdG8gdXAgdGhlIG1pbmltdW0NCmNvbXBpbGVyIHZl cnNpb25zIHRvIHNvbWV0aGluZyB3aGljaCBzdXBwb3J0cyBhc20gZ290bywgYW5kIGRlbGV0ZQ0K LmZpeHVwIGVudGlyZWx5Lg0KDQpUaGlzIGlzIGEgcHJlcmVxdWlzaXRlIGZvciB0YWtpbmcgb2Jq dG9vbCBhbmQgdXNpbmcgT1JDIHVud2luZGluZy7CoCBUaGUNCnVzZSBvZiB0aGUgZml4dXAgc2Vj dGlvbiBpbiB0aGUgZmlyc3QgcGxhY2UgYWN0dWFsbHkgaW50ZXJmZXJlcyB3aXRoDQpiYWNrdHJh Y2VzOyBtb3N0IHVzZXMgY2FuIGJlIHJlbW92ZWQgd2l0aCBzb21lIHR3ZWFrcyAoYW5kIHRpZ2h0 ZW5pbmcNCm92ZXJhbGwpIHRvIHRoZSBleHRhYmxlIGhhbmRsaW5nIG1lY2hhbmlzbSwgYnV0IHRo ZSBWTVggVk0qIGluc3RydWN0aW9ucw0KKG5lZWRpbmcgamFlIGVycikgaW4gcGFydGljdWxhciBj YW4ndCB1c2UgZXh0YWJsZS4NCg0KR2l2ZW4gdGhhdCB3ZSB3YW50IHRvIGRvIHRoaXMgZm9yIHNl dmVyYWwgcmVhc29ucyBhbnl3YXksIEknbSBub3Qgc3VyZQ0KdGhlIGFkZGVkIGNvbXBsZXhpdHkg aGVyZSBpcyB1c2VmdWwuDQoNCg0KQXMgZm9yIGV4dGFibGUgc2l6ZSBub3RlLCBzcGxpdHRpbmcg aW50byB0d28gdGFibGVzIHdpbGwgY29tcGxpY2F0ZSB0aGUNCmxvb2t1cCBsb2dpYyBhdCBydW50 aW1lLsKgIEFuZCBldmVuIGJ5IHNwbGl0dGluZyB0aGUgdGFibGUsIHlvdSdyZSBvbmx5DQpyZWR1 Y2luZyB0aGUgc2VhcmNoIGxlbmd0aCBieSBsZXNzIHRoYW4gMSBzdGVwLg0KDQpJIGRvbid0IHNl ZSBzcGxpdHRpbmcgdGhlIHRhYmxlcyB0dXJuaW5nIG91dCB0byBiZSBhIHdpbiwgYnV0IHRoZXJl IGlzIGENCmZhciBzaW1wbGVyIG9wdGlvbiBJIHRoaW5rLsKgIFRhYmxlIGlzIHNvcnRlZCBieSBh ZGRyZXNzLCBzbyBhbGwgd2UgbmVlZA0KdG8gZG8gaXMgbWFrZSBleHRhYmxlX2VuZFtdIHZhcmlh YmxlLCBhbmQgbW92ZSBpdCBmb3J3YXJkIHdoZW4gd2UgZnJlZQ0KLmluaXQsIGF0IHdoaWNoIHBv aW50IHdlIG9ubHkgYmluYXJ5IHNlYXJjaCB0aHJvdWdoIHRoZSBmaXJzdCBwYXJ0IG9mDQp0aGUg dGFibGUuDQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Thu Jan 05 14:30:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 14:30:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471951.732008 (Exim 4.92) (envelope-from ) id 1pDRGC-0004xV-CO; Thu, 05 Jan 2023 14:30:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471951.732008; Thu, 05 Jan 2023 14:30:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDRGC-0004xO-9Q; Thu, 05 Jan 2023 14:30:24 +0000 Received: by outflank-mailman (input) for mailman id 471951; Thu, 05 Jan 2023 14:30:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDRGB-0004xI-6I for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 14:30:23 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2076.outbound.protection.outlook.com [40.107.6.76]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7b6505c8-8d05-11ed-91b6-6bf2151ebd3b; Thu, 05 Jan 2023 15:30:20 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8431.eurprd04.prod.outlook.com (2603:10a6:10:24e::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 14:30:19 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 14:30:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7b6505c8-8d05-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BvKCrra4pCGYX2/7daq2swJ+jHr5ThbKox1PqD+IxuoNlNrQIQY05kcSpEdTdsTCUdHVVfM4LfRqBH0K/HgewjppCfyw53X8kL6WPUx0WCQVv2gflVavBTJCLO6KdpwbjyaYo/nHpNC6uwYK/Dx1CviGz43fw/W6h1lyodHovH+RbbWGDb6Sq9upmIYSSaqLgFSz7rF8E7M13Dsq+Y2uX0rV3aQtvnu9wr0v/XZ0FchaI85BhF41bkeAKXs3PUyBmONsPmIoXxn7Ajj5w1vykJaUHpl47iujkJ+Qsh6kwe3fL6OugCRl0QsAfEp+ecz4MD8/67QOePCRFaHMeGuv6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=S9/wtwNaCOrx6wqy/6Rdxnz+hvDUMmJOTdH7TQTWBzk=; b=a1sz5c2xOicAhM451JpZnNm1ZhIP4OgawUxXDlK6Yr96tnSFZVx6dj0PUPbw52XB15lqCuzta1ntwY6iVmb5rPAZKrufKgEc4b5/b0KTKIz5JnV0Mx4F3YgtBuqhJk1Bi/diZmVgnMOJDTUnuIF6cBVQsYkSMgwsvq5KTTTyakNfh7bkGjj3qSpQtDA+AtRkUZ7eWUalusGFWJ6bYYahjz7DVx5L9vKMMxEY0dKEGVGKLGFPJCeGCAx+DEw5/DUe2o78UMYsLf5SpyFAN5Mu0VQCWishBfa8V0nry9IsgHWYP7xnQgMkW0O/ZqTUuoMCwVvv26e8SDqC6Rv8wU5Cig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S9/wtwNaCOrx6wqy/6Rdxnz+hvDUMmJOTdH7TQTWBzk=; b=XdU+5R3xwr+DkBWuB6q0dF9RoL7rOhR8R45CUJ0c0Fkw9goIXsK6Vfv3h7AOV0/WNNgIyCalvXuxjRosbZ85Ft4x5BfPVRnZyEsfWNA7r3x8x942YF7Wdeo7s6eOPL/u+/jcIJqeJvgrU82ACVn0440HuM44URrE1+PqvKp2AWRUCSDiH+y2HtvpkUKUIBn8L9iRJXaCDEzRGDICPT81UbU9xjkvuvoP3kfd/u1WOqB2SUAZ11YhnnmfEFrc1g5h6G/wY0NoM4MCgqOEtU30vSd9AP4NWTwmkHNYzeBcEan/qjGpwRsxex37rujyG8+GF7TYUGicgn1sDpasR37Jjw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2fce631d-2e59-f0f9-3330-9618eb5f3057@suse.com> Date: Thu, 5 Jan 2023 15:30:16 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v6 4/5] x86/mm: Reject invalid cacheability in PV guests by default Content-Language: en-US To: Demi Marie Obenour Cc: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Tim Deegan , George Dunlap , xen-devel@lists.xenproject.org References: <2236399f561d348937f2ff7777fe47ad4236dbda.1671744225.git.demi@invisiblethingslab.com> From: Jan Beulich In-Reply-To: <2236399f561d348937f2ff7777fe47ad4236dbda.1671744225.git.demi@invisiblethingslab.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0165.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8431:EE_ X-MS-Office365-Filtering-Correlation-Id: e05a91eb-adef-49b5-c670-08daef295e74 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8uIeeGYxl30ILeSNdKYRqRuVeARHcGIZxqQhndcuZ/xl0HF1F9HYnj9Sh43/+9lb6yfYa9KpaRHmHnIized6PghRDQsrdpktt6BJzwdOMl+pYE2vdPNg7XJ+3yLwX57DOGcephPC//FqPPwmfza4C19Q0KuTzaqRY0ndK6nUwqoycksIbewqzYqiRKEZ9pT6L+nfQNkX+5sHkdvIbG3e+N1qsJyZkJz5IG4pVvlSFMScA+RLb7/35J24LArzcxjq0RqIDUCAImcmHTHOLj7ygdKlQSS30kjsNSPeUIJKOQ8o4symS5gJIc8tpwP8P7J7R9WCWcuNIBfu1fjQ2ANpHFzFUNLG3iZaMfH3lNqjYP067pa7paKT/IeAIvRi02Np1JmngWPZOq0j0lIMOdOoYNaWQ4KoQkt6vQMVIRhLCczVp/A0/naJWRc/+vdPBHSAzrtyiSc1ArF4SgrPNHQSZitvejAQASwHTmMptxeA9yPcKknlZMZIJTfFCVfEUv2zFtcJtI03DHZFxW8HzR79vrYfVrRkKrwM7t4ktsQRrTm12KEWhZ2lL0vVHTsXZbyeU9Me99QSHW2BMGp96Q7rL+sbKYowj7/JavEqDPghvxBHg6Pp0fGtW/bIySJ70K1LBtpnQL2/VaUXoHFCTb1vz6NSDvynFODcQ+SERpaX/rHgeg2LgHOqncCDw4/kpfhofiKk9jkH72xPRnEsvKFKrF69VOsvh2GDg7z3YqJOSC0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(396003)(366004)(39860400002)(376002)(346002)(451199015)(66946007)(66476007)(41300700001)(8936002)(4326008)(66556008)(8676002)(5660300002)(31686004)(86362001)(54906003)(316002)(6916009)(31696002)(2906002)(6486002)(478600001)(38100700002)(2616005)(6512007)(36756003)(186003)(26005)(83380400001)(53546011)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NElCeW01RUZwYXhTLzYyNUdGd3lzbjM3UDgvYk1SMU14OVJoMkg2R1BrNmMw?= =?utf-8?B?R3RYaWp5MXRDWmZvOU1ocVNGTThtMUpjUkpHZTVnNmtndU0vRkFxUG9LSW1U?= =?utf-8?B?RnJNa1VZWTNzaGhsSVdLcDEzVGJVVW92UVE3QkRDUXRjNThnUlRjMkJzbkc0?= =?utf-8?B?ZkQ4djNGYVljeUJXWHhsRXFlN2FCV25Ca2ZYZ0FkTE0xTFRZaHBVeHhPdlY3?= =?utf-8?B?djJNZnFKQnd0cGN5c0hvZ3pFMkRwNDZLWFErUGFaVnRqSGVIVS95K0ZMZVlF?= =?utf-8?B?cnpKWEpFNWYwOFVYNGlrSkdhdFJFbjl1YjFwckV2aUVrRDQxWW5uck5HTzNa?= =?utf-8?B?d2dFNjlQSkVYMS9vVTVuV2srS2JRWENTRk45bzJYREpvYVJGc2ZId0lsOEJ0?= =?utf-8?B?czZ2V0hpR212RFBXajhCbDlSeC9UVFlnMmk0M2tsL3FJYys2VU95RnRXYXQ2?= =?utf-8?B?M09lZEFndmhSeHExcHlZY2hOS2FtYWZxSko0dlBKT1IvMFBGdWcrZ3kxem93?= =?utf-8?B?R1djN1dsZ1Z2S2NVaEFDbFgrVjErWGU0QXpjbTZZL3BzbWpjdkpsVWtBVldh?= =?utf-8?B?QXhXcWhveHY3WVlEOUdaOFhHbURzMWUxRGN4MGpQaEZBUEoxL05vWmFwak8y?= =?utf-8?B?MG9hZytTV2pWUWdjN3pqcm5ZL0lrbGRTYWlFckoycXgwdWU1bHBBV2M3dktL?= =?utf-8?B?L0Zaa3Q4N1ZYRzZJQXl5TVNMZGFrZGN6dERJaXh5Zms0cWthQVNwSWZxL3ZB?= =?utf-8?B?S0tmallQZDVNcDd2K3ZoQ3BMaUN3d0VOcDF1NUV2dmo4amZPZVAvaXpqUFZV?= =?utf-8?B?RDc1TGRrb2JtSmt4bldEVHphRnVoRnIzMm0wZ3pINjlYNDVjaWZ6c3B3RE5W?= =?utf-8?B?dTlRSnpJZm1id2ZRMHZxTXZsNkhhMk41YTlSTmx2R0tRSVhxdFM1Q2RQUzd6?= =?utf-8?B?OVBpNUJobER3dEtPWDY2SnhjUDF6SmdNU2ljeFNmNDd0ekFHSjhNUHFBK1Zz?= =?utf-8?B?dkx1a1ZOUi9kdVc5VUFpM25sRHBhZXgxb043eXRHa3AwN0s2cDIyWENzd3U1?= =?utf-8?B?QzlTMU1XRkRsSG5Bdm1mMWVyc0Q4Ynd3T0c4TkZWVjdYQjFoa25XTHRWVXFl?= =?utf-8?B?dFlrRXhNekVEYjVEMWxSdlFmWFpRWDNCR2Z0Rmw3aXlObXRqaWhGeFRsSnoz?= =?utf-8?B?MGRtMEoySzZvNTlKbCtuM1B3ek9sVTMwajNBNmNwbWNFb1FRQmpRVGlqcUZq?= =?utf-8?B?VzFXM3poYjZmZVYvUnMxRHREdlZVMnMycWJTdURGOHNCOWc4NUVJUWFpQWlS?= =?utf-8?B?RFdCYUhNUjZDSXhBUXFRVkY0YkIvaFFHdFcyQThvb2Z3VmxGK3R0dGNENEVn?= =?utf-8?B?bHp6Zzd2KzN1TEUxWU8yQm1YTGZ0OEI5SlZtVkpDYW1GSTM2NStzQWlJUHNo?= =?utf-8?B?dTl3WG90a09xMVJ5cW1VSzUxUHFaVnFIVEQwNk1QS0cxekVZU2Q2SVFMdk9D?= =?utf-8?B?TDM2cUxpZmRtMXRXNkZPYXFZOWIvVnFYL3hyTU5xZkx6bVl0MlVrM2cxa0Zv?= =?utf-8?B?US9PM0Vsc3VJODNkcmJZZmtCRndlM1RIaFcrUGF6ajNZeXRCR3RSb0llcFJX?= =?utf-8?B?L0dGNXYxMG95MGNRYkptWTJSQi9BeGYvZVBBcEl2NXkxUmhieU53K2gwdnJS?= =?utf-8?B?TVMzems2dWMzUlFIaXV2bnBFczVBZWRydEx2a1dwdDF6ZWRET0Y2YzF5QWNy?= =?utf-8?B?dVNWbnBSNTBLZzVCOEJEellpMnd4MnM1ckEzOWVrdG1ONnVWLytSY25oU2ha?= =?utf-8?B?Z0U2V0pVNWJZNFNNOVppM3A0Y2ZOTVFScnZMalpmRldoSWYrdUxaOVlMMy9p?= =?utf-8?B?WjhuVzkyWEJ2S3F1MzVXOGEzcGpnUXBkSm9XbG1RUmROSHlwN0lXMUwxcGNn?= =?utf-8?B?Wllvby9MeUozT1o0eEZHUkFNUUFXc1E5bnZiUDNmWHRnNHR3Q1cyb09sb3J0?= =?utf-8?B?S1RidGgxeWV1ZWdDdjRXWHptOXJVYm90WlA1dytmVk41TTZYYWRncC84enY2?= =?utf-8?B?c0ZYRjZxcFpOTTVFNDllZnFYbVcvbkNDemt6VHJvTStLMnZNNjZKbGYyM00w?= =?utf-8?Q?6lsN93a6QTdXUiWLmgQ0OtjE5?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e05a91eb-adef-49b5-c670-08daef295e74 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2023 14:30:18.5005 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gSvra5CT/1d3qprmWD2+sD8Npfvmq700Uw6+9C6BNzU57c21iKk1BL77OxYVso7xVIVlASf9F9sfccWWtL1vLA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8431 On 22.12.2022 23:31, Demi Marie Obenour wrote: > Setting cacheability flags that are not ones specified by Xen is a bug > in the guest. By default, return -EINVAL if a guests attempts to do > this. The invalid-cacheability= Xen command-line flag allows the > administrator to allow such attempts or to produce Unfinished sentence? > --- a/xen/arch/x86/mm.c > +++ b/xen/arch/x86/mm.c > @@ -1324,6 +1324,37 @@ static int put_page_from_l4e(l4_pgentry_t l4e, mfn_t l4mfn, unsigned int flags) > return put_pt_page(l4e_get_page(l4e), mfn_to_page(l4mfn), flags); > } > > +enum { > + INVALID_CACHEABILITY_ALLOW, > + INVALID_CACHEABILITY_DENY, > + INVALID_CACHEABILITY_TRAP, > +}; > + > +#ifdef NDEBUG > +#define INVALID_CACHEABILITY_DEFAULT INVALID_CACHEABILITY_DENY > +#else > +#define INVALID_CACHEABILITY_DEFAULT INVALID_CACHEABILITY_TRAP > +#endif > + > +static __ro_after_init uint8_t invalid_cacheability = > + INVALID_CACHEABILITY_DEFAULT; > + > +static int __init cf_check set_invalid_cacheability(const char *str) > +{ > + if (strcmp("allow", str) == 0) > + invalid_cacheability = INVALID_CACHEABILITY_ALLOW; > + else if (strcmp("deny", str) == 0) > + invalid_cacheability = INVALID_CACHEABILITY_DENY; > + else if (strcmp("trap", str) == 0) > + invalid_cacheability = INVALID_CACHEABILITY_TRAP; Style: Missing blanks immediately inside if(). Also note that generally we prefer '!' over "== 0". > + else > + return -EINVAL; > + > + return 0; > +} > + > +custom_param("invalid-cacheability", set_invalid_cacheability); Nit: Generally we avoid blank lines between the handler of a custom_param() and the actual param definition. > @@ -1343,7 +1374,34 @@ static int promote_l1_table(struct page_info *page) > } > else > { > - switch ( ret = get_page_from_l1e(pl1e[i], d, d) ) > + l1_pgentry_t l1e = pl1e[i]; > + > + if ( invalid_cacheability != INVALID_CACHEABILITY_ALLOW ) > + { > + switch ( l1e.l1 & PAGE_CACHE_ATTRS ) You want to use l1e_get_flags() here. Jan From xen-devel-bounces@lists.xenproject.org Thu Jan 05 14:52:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 14:52:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471959.732019 (Exim 4.92) (envelope-from ) id 1pDRbv-0007VN-B2; Thu, 05 Jan 2023 14:52:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471959.732019; Thu, 05 Jan 2023 14:52:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDRbv-0007VG-6o; Thu, 05 Jan 2023 14:52:51 +0000 Received: by outflank-mailman (input) for mailman id 471959; Thu, 05 Jan 2023 14:52:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDRbu-0007V6-Rr; Thu, 05 Jan 2023 14:52:50 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDRbu-0004ud-PC; Thu, 05 Jan 2023 14:52:50 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDRbu-00087h-DR; Thu, 05 Jan 2023 14:52:50 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pDRbu-00073t-D2; Thu, 05 Jan 2023 14:52:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=l15FJLeYlfyLOiiWjYTABtrxHMab3qI2j6EMOzMVZpE=; b=VkS3ECMfqm47qL2iwM2BTSyrO/ sXtqB9s8+NXFYm9ewiig1ecK8tg/wR6vd87cr5VVvkIBGGnMDkkv6VmMGx+CQU8K06qr4vfcOjPgU tIEIuqeakPpu4G+YbV0ne+PTGcDYnWUMlQ0smt7Gp/D8y/czrV9EIKWc51n5Uhkbs7Bg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 175583: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: qemuu=cb9c6a8e5ad6a1f0ce164d352e3102df46986e22 X-Osstest-Versions-That: qemuu=ecc9a58835f8d4ea4e3ed36832032a71ee08fbb2 From: osstest service owner Date: Thu, 05 Jan 2023 14:52:50 +0000 flight 175583 qemu-mainline real [real] flight 175588 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/175583/ http://logs.test-lab.xenproject.org/osstest/logs/175588/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail pass in 175588-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 175571 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 175571 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175571 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175571 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 175571 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 175571 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175571 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175571 test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 3 hosts-allocate starved n/a version targeted for testing: qemuu cb9c6a8e5ad6a1f0ce164d352e3102df46986e22 baseline version: qemuu ecc9a58835f8d4ea4e3ed36832032a71ee08fbb2 Last test of basis 175571 2023-01-04 17:08:54 Z 0 days Testing same since 175583 2023-01-05 06:47:09 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alex Bennée Mukilan Thiyagarajan Peter Maydell Thomas Huth jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git ecc9a58835..cb9c6a8e5a cb9c6a8e5ad6a1f0ce164d352e3102df46986e22 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Thu Jan 05 15:49:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 15:49:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471969.732029 (Exim 4.92) (envelope-from ) id 1pDSUC-0006CR-Ez; Thu, 05 Jan 2023 15:48:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471969.732029; Thu, 05 Jan 2023 15:48:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDSUC-0006CK-CQ; Thu, 05 Jan 2023 15:48:56 +0000 Received: by outflank-mailman (input) for mailman id 471969; Thu, 05 Jan 2023 15:48:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDSUB-0006CE-MX for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 15:48:55 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7445aadb-8d10-11ed-91b6-6bf2151ebd3b; Thu, 05 Jan 2023 16:48:54 +0100 (CET) Received: from mail-co1nam11lp2173.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.173]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 05 Jan 2023 10:48:40 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CO1PR03MB5699.namprd03.prod.outlook.com (2603:10b6:303:95::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 15:48:34 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 15:48:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7445aadb-8d10-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1672933734; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=GtOP1m3e6y8lukYciiLXnlei1xaVG5tNYJ7a1NRQhcs=; b=Ip7VWfkCxH5OWRIQYhU8G2DiwjKxu0S74VXHg2goZM4z6An6Wfnlalrq D7hHyIROdR/YSIs1oxC9lhv3IRY9IznLKc1CF7iYThoTr1uHUxy1koAYK RTIvt2ddjPA+zKEkT6wI0ywlHT72ieG81mamLoEBdqn/Y6uBxoJThi08n E=; X-IronPort-RemoteIP: 104.47.56.173 X-IronPort-MID: 90280575 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:NvkHKKs+XvokwBFsJQ1dQyto1ufnVBNeMUV32f8akzHdYApBsoF/q tZmKWDQOKmIZ2T0f4gnPN6w9ExXsZbQnd5hHgBqrn00ESgb+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg0HVU/IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj5lv0gnRkPaoQ5AaGyiFOZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwCDkrTA+JmOKK352KQdFPncoDDsziBdZK0p1g5Wmx4fcOZ7nmGvyPzvgBmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osjv60b4G9lt+iHK25mm6xo G7c8nu/KRYdLNGFkhKO8262h/+JliT+MG4XPOzgrK4y3QLOroAVIB05VEHjk+S0tlS/a8xCE 3MI5zgzsqdnoSRHSfG4BXVUukWsvBQRRt5RGO0S8xyWx+zf5APxLm8AQz1aad1gt9IsQjcq1 VihkNbgBDgpu7qQIVqX8b2evD6pOSwYKGYETSABRAoBpdLkpekbhxbOVcpqEbTzgMf8Hzrx2 BiVoCN4jLIW5eYA0KO9+lLLiiytvbDGSwc04kPcWWfNxgFkYI+oYaS45F6d6uxPRK6CVUWIt nUAn8mY7cgNAIuLmSjLR/8CdJmm5v+DNCDXiHZ1Hocm7DWr8DioeoU4yCFzIgJlP9gJfRftY VTPokVB6ZlLJnyoYKRrJYWrBKwXIbPIEN3kUrXfaYNIa50oLQufpngxPgiXwnznl1UqnecnI 5CHfM2wDHEcT6N60D6xQORb2rgurswj+V7uqVnA50zP+dKjiLS9E9/p7HPmgjgF0Z65 IronPort-HdrOrdr: A9a23:3gm+3a6Q8E7sU8+CewPXwMHXdLJyesId70hD6qkRc203TiX8ra qTdZsguCMc5Ax8ZJhCo7C90cu7L080nKQdieIs1N+ZLWzbUQCTTb2Kg7GM/9WqcxeOktK0v8 1bAspDNOE= X-IronPort-AV: E=Sophos;i="5.96,303,1665460800"; d="scan'208";a="90280575" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M2AjWK/FjdCHkKTHc70MNpqmIi2UqLLDrkZEdJ4XcPqDa+szk4tZr+I0mBwQeR9XXtLWuA6FTxcxTPHQsY8LVUKsXfU6W8TQS5urNBMVW8qkxUgYy9ubbiSUoizK+jVRoGCGCPsRIpbGDc7ULKPgsi5Inj8fHYs+XPJTo74EyX/NWcSqGhJzPHYPMwiC47lgwwijq475S93zQuGWI1yrtM0KAomBhT7aSiidpwcXWHKkEsx/ow1FzIv1Oz76Yt+qvt3HTlGbV1n1K2PHM80chghrNB6dTel7Z55T2yGgUqWXoGxVL7TUZeb1pQXjzine4qsUaSx8oxPl35ct31m64Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GtOP1m3e6y8lukYciiLXnlei1xaVG5tNYJ7a1NRQhcs=; b=a92T8A40IUUpJtN6helnwLbzKwD2485aLZ0IUJjOEbJqyizu4/IOOcRr/e6Wju52pniqyeF5Af7TR73Lqv44025i/PCiQCEYW3Z3/Z24Z4oUalctAEZJ5NNcllxxMwuei1tzlm42bwnyCL7Ubt8FGK+UyCVzbqzSacbCAA9IAij8uh+W3F/a5IzzFbFhsGIpXY5EgKvg+E6ST7jDp9ZStSUDz3gjlxRRO+v5Y5NggdnLXp4gaGz+AIUb3XffzecR8tu05d+Zy16ggO/YpCmEhzVOboRFlJRgryd77OpLb41sBRESU+c7PMzVTsfRXHgy8MqTvpg3g1FrJwjbZnTeRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GtOP1m3e6y8lukYciiLXnlei1xaVG5tNYJ7a1NRQhcs=; b=FL3F/KTjNwe4EiwTy1E59VF2aYHgjg7COUG0H4wQH807Cnpg/aGRWRlNyitYmp1t4v9mBCktnwLr87TTBVNZ26mHPnvvAWHLKePsj5UWwtfx+XzGJIeO+qWs1AnrcJcp7M6GFNnLi3vQRgLNR+0YvYjCzKfLU7byvfKX/IsHfQQ= From: Andrew Cooper To: Jan Beulich , Oleksii Kurochko CC: Bob Eshleman , Alistair Francis , Connor Davis , Julien Grall , Anthony Perard , Stefano Stabellini , Gianluca Guida , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH v4 1/2] arch/riscv: initial RISC-V support to build/run minimal Xen Thread-Topic: [PATCH v4 1/2] arch/riscv: initial RISC-V support to build/run minimal Xen Thread-Index: AQHZIP2Dn/VS+v8CxEaK8nfj7fmLt66P1KmAgAAjsIA= Date: Thu, 5 Jan 2023 15:48:33 +0000 Message-ID: <01888162-49fb-a280-a088-5e81edff3919@citrix.com> References: <591d6624-2bd2-93f0-f5d6-760043230756@suse.com> In-Reply-To: <591d6624-2bd2-93f0-f5d6-760043230756@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|CO1PR03MB5699:EE_ x-ms-office365-filtering-correlation-id: 5a4eae3b-32bb-42cf-c9bb-08daef344d2f x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SBpXQ9wKeImxtbTvohm4xlTVRKGqZT0z3FppNE+LXj9jnKncPtFiOIKlFP8ghvOZCJ/mXf00xIsMzUfhjqAg6b5gM7UHUktrSBD690FfdVOJegX+tgQRbWnZU68ZIvdrvE9Ut1lMsTICITMNumG6/E2ilAjDCMsYJygNcM9zOc7hbmEw7CLqvKjx3gfpEyywL8NpmITjx2cZmBhYmk2I00vlaJWuK81Mjj2r3Cm1KAHTrptby02BEkOGoo9AOAkUaOJjffqM9bPmHXgf/xHF4hb7OnbLihbZI2jC64RJDlIDnVZPkfiT4wMkDQqwWHOd4oWXaAqX5fkiW1F4befUJIxinW+8XIuKM9Og89+xCwWy/PQ72UthWK4PPU180drBH5VEyD9GWdXjAnPBEidvastsH32rQ7taIuTAeK4vZrETufQb2wm7Y+a+0Kf6rR6T9CFODWyRYEGWT6Lh2F2XSRsFvtL7HYYN2UR8szHn63SvI9iH0CTgzTCoIgxLbmPz7SMZR7O9JDWUMBSDcIZjuuOh8ZhxQ+slt1d1gsvv9c5PkznXkjw9Hr54sW5AhCn6ZWRSuPqK9CXsZWTdz5yCSFmNjPKwY5PU60BcIZ2bnlFIK8axJV89S78Tb5YXt5MUrT4+agDw2l53Fl4JkJdNx2+H6py1NEEytC23FsXuPT2k2EqWMRGaPmt7fKwqDVGP/cmFmHIfKJkvqySzEOOv56wt5hKdoO6lQ+cy4BIywtCARr8xOga/ARoVwSgUXlReiAapsbTiXd5dAL7j6O4rgA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(396003)(136003)(376002)(366004)(451199015)(6506007)(478600001)(53546011)(122000001)(31686004)(38100700002)(82960400001)(6512007)(36756003)(26005)(71200400001)(186003)(6486002)(2616005)(110136005)(2906002)(54906003)(38070700005)(316002)(66946007)(8676002)(7416002)(66476007)(76116006)(66556008)(83380400001)(8936002)(64756008)(5660300002)(66446008)(91956017)(31696002)(41300700001)(4326008)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?MXlrOWxrZHk2UDEyaFJZTUNNQ2UxTzducXRjRnJvNmh1c1pWWXRqVzJhbjJE?= =?utf-8?B?RFNWQm83N3UwVStKMEJxK1NuM0ZuSFcvYUNlM3RhQTFXaEpTK29WUFl1YWtO?= =?utf-8?B?eFltU0gzOWpPbjc2OFVIMklTZVJWOFpFUDhlaUhhSi9JYStnTnRMbmo2cU1L?= =?utf-8?B?eko1QWV3WXltdFdRWHV2bXQySWVYT243UGlXc3dwUTVZOEZJS09YQ0pHMXcz?= =?utf-8?B?TklCVmhoLzluVWYrWHVIMEhNQjlZM2lPVkN4eXplYzl6VGJrSHJ3Y1VxMEgv?= =?utf-8?B?eHZ5cXFTZlVaY3VNYW1xVjZ4YUZWeTVSTHNDaXBwNjJpWnpIMTZ3a0J5dEpB?= =?utf-8?B?bURza1MwU3hiMlUyK2haTFBqS1VVVUZGcktpdHFmeUpFbHdibGJCb0xNVlJO?= =?utf-8?B?MC8zMUNJNGYvWWl0NlJsTFllQllZYzJoVEUybS96ekFqbkdldmprblNlSDNp?= =?utf-8?B?NVlrRExCRDNGTVhDeGRveVlMWDRkd01WZXBsSU5nc0lIUHU1Ry94blBhdENU?= =?utf-8?B?dnl4b2dOdnJURlUwK2lsM0dRQy9FdUY2TS91WEx2bzdHRUZSb1RMU25qYUVS?= =?utf-8?B?MGc4YXZFQ1ZLZnJNSThQcW1sTzBvMnFKak9iYUtqbXpPSUFUb1BmWmRrM0x5?= =?utf-8?B?ZFVibmhQMU5HRjFQU3VXNzZBQ0ltb21XSlVRd1prQmNJUWpINmNKTG9HZzUw?= =?utf-8?B?MXlUdkJGSlpIZ1RjdnRCNUpIaWNwRmgxOTltcXFDaXA4amw5VUcvK25YKy9y?= =?utf-8?B?L1had2pvYytQSmFqYXNGWE1xMkwzaUM3SVhVeWtVRlNwNnlGaUgvaEdOZGpJ?= =?utf-8?B?akdSQkN0YlZrU3hBKzFDZFIxY2VYdGhVNjVpWk1yNkpkaUlnYmVDa0ZmRVVH?= =?utf-8?B?L0N4ZU0vSy9yRThaK1NQa3FXcmxaUFM1TFBRVjlLalkxSFJ6aGh0TUhVZ1dD?= =?utf-8?B?a1lYTFdsVUFpUGZiNENOMjJmRkowNm5kQ0VSeWNDZmhOVEJkN3NKUktZNE1n?= =?utf-8?B?cFFIQzVQa0tRb1NIVGhxcGhWZlh1K3RBY2tqNUkyWnBwSVk3NFJmRkRmcDlE?= =?utf-8?B?dHVrbGs3UU5kSjlQcXV2YkhjMVNQd0dJbjJZd0N5dzlmV2hYTi9IczhoaC9V?= =?utf-8?B?bVBSSHB3U2RDNVBVNThscHQwblk2TWlDUmJGK0diWDFNYzdMY1FNN1lWdjB4?= =?utf-8?B?WVBlUmxMa1QrQThybzBaVWZGZm9SdEZIcDhFS2dQOHZwU2J1RmsrZk5FeDFt?= =?utf-8?B?SGcyWjZKbW9SMDY3aDJqSEViREpiSjBMZXViL2hFYW95WUtJbjVqanczVkhx?= =?utf-8?B?S3V5SUkwY3g1RHlWb0lsbW42RzdLaUhCZ2JOaHBHclgydnp2T1h6eXlXaCth?= =?utf-8?B?aUFPazVVb0FBWm1QTnRGZ1hhb3luNm4xb2NMREVhblNaMHBBOEl6Sy9MZmZl?= =?utf-8?B?ekw4d0xXcnV3c0xYV0tqd3htQUNCMzRmeFdlVDlhRU1teVZnY1NDVk82cUtE?= =?utf-8?B?b0JycXVhcnhjOHZ2ZEdDNW9UeWg1cjBtU1FjK2dwYjQ3NVM5NE5RelVnRWVv?= =?utf-8?B?VHlKUmZmVDVrNWY5MVp3ZklUekRPdTVLcGZ0N3ZoVmM0ZWMzWUswQXFCRzhQ?= =?utf-8?B?dGM5bGtYRTExNEsyL05uSDhqbnJMVWsrbGs0dzRNc2NIM3cvV1BRRnZZSnM2?= =?utf-8?B?aVhGK1czUW1lcnVzTWg4cVVWVStodU1zWnFOZ1BMdi9wdnZTSXBEYWxhRkNl?= =?utf-8?B?ZFZRL1B6K0FKSFJXVnJBYzI3RUhLbGpkMGJ2bHU3VGtqNGJVS2JzTVVLbEFL?= =?utf-8?B?ZXNSL1owL21HbGZzNzhKWi93anVqTFQ3WlNOMWRNd3JRekxsV3RWRE1BNm9n?= =?utf-8?B?Lytpc3Q3dUFFbWl4bXZpNFZueEppVGY4dmpnR1JpWkhuZlZVVGF4Nk9TOE5q?= =?utf-8?B?eHFpNUlOKzloa0Jpem1Vekp5MzJTVXVpYXkrNW1tU2FDZ2k3T0ZGUllvZGQ3?= =?utf-8?B?UmNQMFNoWVR1UGZMSXNaTlhuSUtnOHd4dTBjUDdibGxXa0RjSkJRSk9leWV4?= =?utf-8?B?ejZmYk9WWEhVUEtzUG95N1dLUGk4QTJ5VjgxQlZFZzZTTGlSOTlyQlc0cTB5?= =?utf-8?B?VGZnZE81UW92M2szZ0Y4eFVoWm0xMitMNUhsbDFpaW43WVFSVkFIQ2NveHJm?= =?utf-8?B?bnc9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?RFNFN0x6Qk1XZTRuME5TZGF5ZmpkbzRzVzRxbGJGeGdwb1FhaVhTMnB6UFAz?= =?utf-8?B?UFJyS0Jpdk8zbFhMWWZPNzRDbmV0cUlveE5VQ1NMZGxvY3Y3Z3p4Vy9vbUpW?= =?utf-8?B?WUJhWUIrR1ZNNkUzaWZzNmRaU1NTTDBHN1hkNDUvWUdGQmorUVY4T0lHS3R6?= =?utf-8?B?SmhFbXdzWDY4V0FXcmY2S2VBWnRkZThpZDBSdVc1THk0SGhHeUJaOVNoalFx?= =?utf-8?B?a2tFMnl5aUEyVGVuMDZyNGNPdjZocFd3OWtQZEU1MENqTnBRQkFJVFo2TGYr?= =?utf-8?B?QWtDWFQ1WktRcHNKamxtbnZ0c2FCbDVoc3h1N2hGYVZmeERsWXA1cTY4aEI0?= =?utf-8?B?RHZIeXk3VXNEK09iZ3dNV0s3aFVQVFhHNWdVelJLeE9IREFRdXVVRXZEeTNp?= =?utf-8?B?VzZiaURqR00xU28yZDVJUmxUUGhHSWNaZmFEVnM5MEFUaTZjRlQxSlIwcmJq?= =?utf-8?B?NzN6djhqYWQyQUpYR0kxcmxPRnVKTTkzcFEwVStMQThzeVpGQm51Und4YlQ3?= =?utf-8?B?eVMycmRic1ZzTE1sWWVvN2pPNmorYTlhRHFpZ1ZYUk1PYjRJQzJnRUllcStZ?= =?utf-8?B?Z3FtMlZKK0s5QnpYNmFKQzRrb1VpalVaNVlRdTloQzJoZ0pPR1l1eWUrekE3?= =?utf-8?B?Wmpjb1Rnakt1UjgvdGVwWHJBN05IZXZoV0xPdEkzSGM5SHJDS3I1VEhyeW5i?= =?utf-8?B?Y1hXR08vS3hwdVZTNmVKeXRtaU5SMHJXMWlkN08xU2U5QUdaT2Z4NnBrZ1JG?= =?utf-8?B?YUd4eW40YkFmSjIvSmdPWjFLZ1BvSHkxSEQxZVY3RVYzZW9BeWV6SHc0SWFJ?= =?utf-8?B?ZVF3bHh3Kzk2RWlGWjlqUmpLeXhuYTFIWUI1Wk4wMHdpWHZyb2xQMEs5RDd0?= =?utf-8?B?M3loa29yTStnbE51UHRJcHBWSjN5Y09seEtua09sT2gzRjRJd3VzK1YyaE5S?= =?utf-8?B?OUcycjIwNHQ0RnIwMzJwMEpoWnVwN0VIYUpqbHFFZXRNdHVIMWEya2JJVHgy?= =?utf-8?B?bGNLY3JMVUJKNCsvNUhGZGUveEZuL3lXbnNkZzI0Zk1kMlZ0dWZkN3lnbkpN?= =?utf-8?B?enU4QWVIWjZaSEtFYlFLTytqSFBYclRCbzhpYit0NnhGZGlRSUJzRlVtcHNo?= =?utf-8?B?aDcrZkRVSTBsMVNoVm5RTTRKdHJDZk0zVWVBSjRJaHdKY2NGZzM3MnBOd3N4?= =?utf-8?B?Q1pWVXhlSHlvSFg5WE9YeFVNaWJWMlJvRHExam5aK0V0NVY2a0pMSE81SWNK?= =?utf-8?B?bllYUTJqeXE3Wk11bUREb1RJSkY2YnJHSmFwQUY2U0Y2Y3F1bDNDeWpPeFdM?= =?utf-8?Q?Ij0niykTwlJ5c=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5a4eae3b-32bb-42cf-c9bb-08daef344d2f X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jan 2023 15:48:33.8193 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pfThgX/v3jfMuzlD55NpXmHzK4VtlAue98gy/5IbuTRT0Pv8e9JlxFuysHHypYEGADwjZXbIrgUcvoF/dR95UivN4jmbQXp74LDltiMOTXo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR03MB5699 T24gMDUvMDEvMjAyMyAxOjQwIHBtLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMDUuMDEuMjAy MyAxMzowMSwgT2xla3NpaSBLdXJvY2hrbyB3cm90ZToNCj4+IFRvIHJ1biBpbiBkZWJ1ZyBtb2Rl IHNob3VsZCBiZSBkb25lIHRoZSBmb2xsb3dpbmcgaW5zdHJ1Y3Rpb25zOg0KPj4gICQgcWVtdS1z eXN0ZW0tcmlzY3Y2NCAtTSB2aXJ0IC1zbXAgMSAtbm9ncmFwaGljIC1tIDJnIFwNCj4+ICAgICAg ICAgLWtlcm5lbCB4ZW4veGVuIC1zIC1TDQo+PiAgIyBJbiBzZXBhcmF0ZSB0ZXJtaW5hbDoNCj4+ ICAkIHJpc2N2NjQtYnVpbGRyb290LWxpbnV4LWdudS1nZGINCj4+ICAkIHRhcmdldCByZW1vdGUg OjEyMzQNCj4+ICAkIGFkZC1zeW1ib2wtZmlsZSA8eGVuX3NyYz4veGVuL3hlbi1zeW1zIDB4ODAy MDAwMDANCj4+ICAkIGhiICoweDgwMjAwMDAwDQo+PiAgJCBjICMgaXQgc2hvdWxkIHN0b3AgYXQg aW5zdHJ1Y3Rpb24gaiAweDgwMjAwMDAwIDxzdGFydD4NCj4gVGhpcyBzdWdnZXN0cyB0byBtZSB0 aGF0IFhlbiBpcyBtZWFudCB0byBydW4gYXQgVkEgMHg4MDIwMDAwMCwgd2hlcmVhcyAuLi4NCj4N Cj4+IC0tLSBhL3hlbi9hcmNoL3Jpc2N2L2luY2x1ZGUvYXNtL2NvbmZpZy5oDQo+PiArKysgYi94 ZW4vYXJjaC9yaXNjdi9pbmNsdWRlL2FzbS9jb25maWcuaA0KPj4gQEAgLTEsNiArMSw5IEBADQo+ PiAgI2lmbmRlZiBfX1JJU0NWX0NPTkZJR19IX18NCj4+ICAjZGVmaW5lIF9fUklTQ1ZfQ09ORklH X0hfXw0KPj4gIA0KPj4gKyNpbmNsdWRlIDx4ZW4vY29uc3QuaD4NCj4+ICsjaW5jbHVkZSA8eGVu L3BhZ2Utc2l6ZS5oPg0KPj4gKw0KPj4gICNpZiBkZWZpbmVkKENPTkZJR19SSVNDVl82NCkNCj4+ ICAjIGRlZmluZSBMT05HX0JZVEVPUkRFUiAzDQo+PiAgIyBkZWZpbmUgRUxGU0laRSA2NA0KPj4g QEAgLTI4LDcgKzMxLDcgQEANCj4+ICANCj4+ICAvKiBMaW5rYWdlIGZvciBSSVNDViAqLw0KPj4g ICNpZmRlZiBfX0FTU0VNQkxZX18NCj4+IC0jZGVmaW5lIEFMSUdOIC5hbGlnbiAyDQo+PiArI2Rl ZmluZSBBTElHTiAuYWxpZ24gNA0KPj4gIA0KPj4gICNkZWZpbmUgRU5UUlkobmFtZSkgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIFwNCj4+ICAgIC5nbG9ibCBuYW1lOyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBcDQo+PiBAQCAtMzYsNiArMzksMTAgQEANCj4+ICAg IG5hbWU6DQo+PiAgI2VuZGlmDQo+PiAgDQo+PiArI2RlZmluZSBYRU5fVklSVF9TVEFSVCAgX0FU KFVMLCAweDAwMjAwMDAwKQ0KPiAuLi4gaGVyZSB5b3Ugc3BlY2lmeSBhIG11Y2ggbG93ZXIgYWRk cmVzcyAoYW5kIHRvIGJlIGhvbmVzdCBldmVuIDB4ODAyMDAwMDANCj4gbG9va3MgcHJldHR5IGxv dyB0byBtZSBmb3IgNjQtYml0LCBhbmQgcGVyaGFwcyBldmVuIGZvciAzMi1iaXQpLiBDb3VsZCB5 b3UNCj4gY2xhcmlmeSB3aGF0IHRoZSBwbGFucyBoZXJlIGFyZT8gTWF5YmUgdGhpcyBpcyBtZXJl bHkgYSB0ZW1wb3JhcnkgdGhpbmcsDQo+IGJ1dCBub3QgY2FsbGVkIG91dCBhcyBzdWNoPw0KDQpJ dCdzIHN0YWxlIGZyb20gdjEgd2hpY2ggaGFkOg0KDQojZGVmaW5lIFhFTl9WSVJUX1NUQVJUwqAg MHg4MDIwMDAwMA0KDQoNCkJ1dCBob25lc3RseSwgSSBkb24ndCB0aGluayB0aGUgcWVtdSBkZXRh aWxzIGluIHRoZSBjb21taXQgbWVzc2FnZSBhcmUNCnVzZWZ1bC7CoCBUaGlzIHNlcmllcyBpcyBq dXN0IGFib3V0IG1ha2luZyAibWFrZSBidWlsZCIgd29yay4NCg0KVGhlIG5leHQgc2VyaWVzIChi ZWluZyB3b3JrZWQgb24sIGJ1dCBub3QgcG9zdGVkIHlldCkgaXMgb25seSBhIGZldw0KcGF0Y2hl cyBhbmQgZ2V0cyBhIGZ1bGwgR2l0bGFiIENJIHNtb2tlIHRlc3QsIGF0IHdoaWNoIHBvaW50IHRo ZSBzbW9rZQ0KdGVzdCBzaGVsbCBzY3JpcHQgaXMgdGhlIHJlZmVyZW5jZSBmb3IgaG93IHRvIGlu dm9rZSBxZW11Lg0KDQoNCkknbSBoYXBweSB0byBSLWJ5IHRoaXMgc2VyaWVzIGFuZCBkcm9wIHRo YXQgcGFydCBvZiB0aGUgY29tbWl0IG1lc3NhZ2UNCm9uIGNvbW1pdC4NCg0KfkFuZHJldw0K From xen-devel-bounces@lists.xenproject.org Thu Jan 05 15:57:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 15:57:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471977.732040 (Exim 4.92) (envelope-from ) id 1pDScp-0007lc-Dl; Thu, 05 Jan 2023 15:57:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471977.732040; Thu, 05 Jan 2023 15:57:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDScp-0007lV-Aw; Thu, 05 Jan 2023 15:57:51 +0000 Received: by outflank-mailman (input) for mailman id 471977; Thu, 05 Jan 2023 15:57:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDScn-0007lP-No for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 15:57:49 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on2058.outbound.protection.outlook.com [40.107.14.58]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b31eb18d-8d11-11ed-91b6-6bf2151ebd3b; Thu, 05 Jan 2023 16:57:48 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS1PR04MB9285.eurprd04.prod.outlook.com (2603:10a6:20b:4df::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 15:57:45 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 15:57:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b31eb18d-8d11-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KIr82r64RqQ2fdOQa8XsTQ00nLj001I3N9/HBwlly9WHA674lkaPET8gm6s0GOSL34D7SmarEX6etShRAh7tmU7D4SxrRFH9fPWypk6xhGAEYu2FOKM6Apw9215/TKn9X7ONB5thoqd9DCei4IOlz98y4txraAOFPVTiVFfHtkCs3LmhTzlgKI2T2BZipTomrL/rN4iuQiJhQD7bbm1m4UcVMmQ9VrbdoO8B0QYIrowF+dKx0pU5tFrafgdupAoL2jO7LsuCm7ydh8el16Ib0okcC7esQz9nEFVlWSSdn/uOxn7BKzeuV8m16/vQ6uNLP3+sYxb0Y3rh6DWYOhZbyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jSiR8+UjgVMW8QiXCNqPlZifOkOHmStw8A6NZfqu+kQ=; b=A5RV05DiHqFjo4Y9ZzQbBkgzLfzbZk+2lruXvKkecMj6WY00YuyOJZj6GsfxQ1k6Vid/mIyuJPUKuAMQD87keo9Iu4PZIRFyaR8+5a2MP+7bMQ25UxNJiXWg6ukfIs0MVSFiFFumCMDcqlZp80y5HFOWCc0Ex7cn8umQkXveFHFEKAi365PSLkz6QAvVEhKUF4NzS23NGAhDMgem2GcqPLJ7IZh0I4q4k0X39Ld7QzJfnC1ZOM4mJo7fl/9Va0JCmYd51ENtTSe+kRPUHz4uC7W2h42n7VIazDv7+GcnC555udbhVeDiO5NDGF/R/AmXF03ACSJymEUTFbJDwSOk/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jSiR8+UjgVMW8QiXCNqPlZifOkOHmStw8A6NZfqu+kQ=; b=idkqKQzojWApzPy/EL5JrXlaczlBfUJSfwrx5YRqH3cVQQshhSU519kBftJ1M5s5Tm2Y2ibRaakAkyv4iq0Sk3Z5zATUROvqyIOzDasv0xkNCwZS6UEg7/Yt3HYMsiYqq39DwZ2/avlv9jwgLYHMwDMkyoLcAaihOaBnooJkPsL6PQlsxJ31MiD9x86221EihUtTqbdJ30q2hlOw3cbildXOEzKCaS29xKdWeU348p4gCC2TbyLh7oAEXbUjjDp7GEcPupwMLx604BzCaxeDTCPw8wVyX7vI5xfolWYmxsNg+Z5yJmYk22TVikUy7Dd3Wts5nGhtImhwat45buELdw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <074dc3bb-6057-4f61-d516-d0fe3551165c@suse.com> Date: Thu, 5 Jan 2023 16:57:44 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Tim Deegan , George Dunlap From: Jan Beulich Subject: [PATCH 00/11] x86/shadow: misc tidying Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0063.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS1PR04MB9285:EE_ X-MS-Office365-Filtering-Correlation-Id: 5ac1bcb8-b040-43f4-df0c-08daef359602 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fXlf/Ki00uVFwYM2FFy4afSYUzRKNVVLDDglYy/3Fpu8JS6AAbIZsupLFv+pWwV6sUfALnRarCOMktysUidNCqtngc329xmaqMBut4z++jUa5OQduU/ukN2zySfQgoGXfIzhFdtSzRQ9yY+do3973dwD4uWOhznm7/dPMD39P3Ivy+CB+Wq0BF69JzCQG2z1EZh7TT+OOpWc51qK0QmCm/wKfb3MBOhV6NgmZx69KD1JkhcIQaLTUUxCk6ClWIkRDlNYI+tWOY5k33XlAaC0ST72O+daZM7xEPx6+UbzyhWCdNTnjX0MP+Cu6nLjp6PtmN9+F7RhWyCx3buG8CFh1ZbV+3dCq9MPsnS00Uvbqo1KEQZMdirdnsg8zpo1+hxzn+QzZS8piF1ocvJNvHDoJhEou98KdNAsWUa+YG9+k3EcTI7RYsgo46et+b6TCjUakwpdW2um6CTwZu7fVC+qJHAwOHuSJDJFZfDsinrOrE9zLUExvOiNXKxHtdpafr+bz/sCr61kMSwxUsQ9MjT5mpD6aD53V12wipkDk2iuWJ7ZslAPzUc0QjBiNu77IRQJndhCpkHVvnHOEX03fRB/ysaCwFLvE98thO2dhHOR5laVdtJk2ZLqn3Bvct1JsmFSGT3AFYLsascGpwM171pyiLq8yQs7QDFwBiMrUJufZA5jYy8MoUtjZ+YFjP3RcM9ymVSgIHB3pV27H2gu8KQkxSn1HfJLWlHgpon7k59al4A= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(346002)(376002)(366004)(136003)(396003)(451199015)(54906003)(186003)(26005)(31686004)(66476007)(66556008)(2616005)(6486002)(66946007)(6512007)(478600001)(83380400001)(8676002)(8936002)(5660300002)(4744005)(41300700001)(4326008)(2906002)(316002)(31696002)(86362001)(38100700002)(6916009)(6506007)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZWplbXdERUJDR3k5dUpUQVUva2U5b2JHMWQ1N1k2RlJDV1Qrb1YvcmRxNlNJ?= =?utf-8?B?VG5iemNkUEN4a0lEV0l2aEs1Q0N3KzNRMVZaWmMvMVh2RWFOM0tpMmRDa3JG?= =?utf-8?B?NTdFcXpuWlRsWjIzU0VBSktGbHYvY2lNMUROMjk1eWhvSzcvRXNnYXhZQzg1?= =?utf-8?B?NkpWQW9GT0FpVlJ1czJSKzRseXQxZ21ub0tzZU5BL2d3UjRRWVVFRm0wVi9u?= =?utf-8?B?QlhzVkNieWl0SndDTHc5bGp1ZVJyRmEybnhtMWU5b1NYY1p0SWVDRys1bm9v?= =?utf-8?B?VlFYazhJeHl4WmtzZWJIK1VtVENTeWNscGExSHJXMWh1dGh4WldDcGYxSWow?= =?utf-8?B?dWRVWlpaa0JxQmwwdHdnTzVsYkFFOU0wdEZHQUI2anpEK3l0K2gwMXcvVmRC?= =?utf-8?B?dXlhSzJKUndzWmNwRTMycDEvZTh4ZDJjTnN3ais0dmd1RGFTZk93cE9YTEsr?= =?utf-8?B?Z2VZSzVXekdiazRCYmg5ckZhK3UzcnNsNTJyQkZCdHVnVFJrbXhvZlJSQVJa?= =?utf-8?B?YUhSVFZrTjFaUGtHZ1pDbFN6aEVOYnhYbW9pd0J4M0s2RXRQZ2lYVEdXRHBh?= =?utf-8?B?cnZTNmlQUnUrejQ0RnMrRnZ4SDVSYXFCd28vL2hHYlhHdUkvbVo4QmtINnVy?= =?utf-8?B?MVhPdXBxYUwyUS81bm54dzM0UDdZZFgwK2hjY3RiMHNOb1JJMFlGTk5uQTRT?= =?utf-8?B?dXVsRmlPck5ZM2xnMU0vS2V3Rk0rRDhremdVQmU2WkJQVlZGVzJMd3ZUSWVO?= =?utf-8?B?dVc3MWVKa0hSNWtKM3E4MmZLNk1OZHlVcWhDQ2dXZ09YSkprNG5JR3ZVWTVP?= =?utf-8?B?dmMyS0dSTVNKeVJBbURCMk5MUDFTUWNmRE9FVXFoVVo1NmxrR3JxWEJNVCt1?= =?utf-8?B?NmhSZlFtNURFdXFBVTNDQ0dESVliVUpjVTVmdmFkNjZTaTJPbHl2a2RYUjhj?= =?utf-8?B?NGE1b2NsQ08rU3dkTUpCUVZiQ3htN3BySlhvdTVXVmVHNlJpUXMxUkZEMUxp?= =?utf-8?B?Q1A0bXFjVndMZ3E5My9YSHRBdzVBYzBVRnZlWHVLbldXQjNiMkhKM0FqVHNp?= =?utf-8?B?UHNBSitPWnRFZ1ZjK1hMS0JZeGpBVTZpd0VFSDVUM3hFVm1xckRvNDVXY1Yz?= =?utf-8?B?TUVzVWVTNUQxVnB0dDIySlU5SEtJaFl5M0JWUHJ5ejZ1c1FaMmdLK20wTTA2?= =?utf-8?B?UzVxT09YSDZwazEvNk45N0QrUGNobXVkMnpwY3RRTFdGNytRS2Q1VlExT0JM?= =?utf-8?B?TGNvdElzSzdqc2R4WStaY1Z3WlI5UnZDZHArTGlrbjR6WGtyQnN0eG9hM3NW?= =?utf-8?B?dTBXazNSbUw4S0FIQzUyM0FkdkdUaGlpMTFISnhMaGNtTU5MQk5SZVA0VTlo?= =?utf-8?B?K3hCSGFlemNYdmJ1OEZkdDNMU0VZNnZyazdTZ1pwZ05UUWRlV3ZNR29wQ3V3?= =?utf-8?B?ZE44Q2hBM1NEOFVGaUdlWXNGU2ZKeFlvdHd5THhNeTVvZ0syZkFqNjBmb1FD?= =?utf-8?B?a2xnYmxaYzBsUnpTaE5LQ2c4T3FhM25lajNiakR0YWRQaGNVbVFjMVQ4R1gv?= =?utf-8?B?SURuSEcrSEg4SEpsYXkvandmNXpCdUQ1bzJ2ck84dGRJYXE5c0hIMTZVcGxF?= =?utf-8?B?Q0lveWFiVDAzcStSTWVOUXZYVDE2QTlBRlM2NDVReGF2T082SHRoaXJ4MThL?= =?utf-8?B?N0picUY5NTE1dGZVc0xzUmxPZmF3QnFkbkpML1o2OStJVExFbDFVMzFTcW8r?= =?utf-8?B?TzFpcGhnU3FsUjVFQkxDODhtTTZNS1llVjd0ZERQbEVhcmwwZUZxOVhXOGpK?= =?utf-8?B?T09ZUWhxUnNJbEpEV3FOeUJsR1NSY0ZYN3dDZGs1T3VkR1YwSmhxVG10R3VL?= =?utf-8?B?cFJyOXc5RWtFTEcydUowaW9jU01xZzZULzdEeGRvajE2dEF5ZjZubm1nRWZo?= =?utf-8?B?dE5EcEtaRGhsU3dqQW5vbEhDamlRR3R0S1hJTlAwMU5pR1l6ZktONFhIUldL?= =?utf-8?B?cjVCSGdHT2RMdmNGV2czZHVHcndiU3VLeHJKcFpRMkRuNTRSQmlOc2tRcnZG?= =?utf-8?B?SG91SmZ0Nm50bDk3cndIZnExNGZOcHh0QUQvalJqMy9Hc251YThnY0JzaUtJ?= =?utf-8?Q?cYwyh8Vbs8QRuQc99saRqVWNg?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5ac1bcb8-b040-43f4-df0c-08daef359602 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2023 15:57:45.6828 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IS/IdPKpj6oDXBaHcckujCKCUeFvD/0yTweAplS4JRhMpNefvKFCkexkZkkTGRQW1ExK0zxkrjBoJ/0dZbFRZA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9285 ... or so I hope. The main observation was that we still have both hash_vcpu_for_each() and hash_domain_for_each(), where the latter was introduced in 2014/15 to replace the former. Only some eight years later we can now complete this conversion. Everything else addresses other things noticed along the road. 01: replace sh_reset_l3_up_pointers() 02: convert sh_audit_flags()'es 1st parameter to domain 03: drop hash_vcpu_foreach() 04: rename hash_domain_foreach() 05: move bogus HVM checks in sh_pagetable_dying() 06: drop a few uses of mfn_valid() 07: L2H shadow type is PV32-only 08: reduce effort of hash calculation 09: simplify conditionals in sh_{get,put}_ref() 10: correct shadow type bounds checks 11: sh_remove_all_mappings() is HVM-only Jan From xen-devel-bounces@lists.xenproject.org Thu Jan 05 15:59:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 15:59:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471984.732052 (Exim 4.92) (envelope-from ) id 1pDSeF-0008KB-OA; Thu, 05 Jan 2023 15:59:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471984.732052; Thu, 05 Jan 2023 15:59:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDSeF-0008K4-LK; Thu, 05 Jan 2023 15:59:19 +0000 Received: by outflank-mailman (input) for mailman id 471984; Thu, 05 Jan 2023 15:59:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDSeE-0008Jw-Fs for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 15:59:18 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on2080.outbound.protection.outlook.com [40.107.14.80]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e853aee9-8d11-11ed-91b6-6bf2151ebd3b; Thu, 05 Jan 2023 16:59:17 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS1PR04MB9285.eurprd04.prod.outlook.com (2603:10a6:20b:4df::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 15:59:16 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 15:59:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e853aee9-8d11-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hZcD+H4ve0PIG6pU2giq5aYtk29Z7Prsw7S1ywA9nwCa54jRSIr98DdPEDcZhd+Y/U+mpknJAv8xlTRpOTiTmyFvQjblbCq4eMXsPWRcwBCeEPVdvr9ctyv+2u1M5kyT+SMiy+e4SC0oBJ+xiaIK6RhfzMItOmPH8rUS44TGoWW5FhvPEyNQ9Vd5jdSDJxoSrsS0IrNiPddk0cM7d4d3wew4edjqt5gfO+D5C6pAbpJApBDLVy3Yv2hIHgJVxbd7orZNu08waJgiKeWC6X+7qMYLYfm6t4m3wDYKlWMoj83hGjZ4kF2gSNBULvHClufXjEOqYBYehQjPa+MY/FHnUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rmoM5XdZSCG0IQymIs8Nrrx2EaS6/cU5V9J6nOA40tQ=; b=mYZswt96NTqvno4IES7zeafWv+2a36rtHyT0gdowFdCT7R+sfR0HXaiGtmayWNzWC2fzBQvI2nMVMvppRP5xO1Zt8umLbzMRUelDL8hQeQnO+WLXqiHxeIWuBMed6j6qcHZBthL7GigNLU0/0vA+clu7JSIpRsXp7A2uZeOxidM1Qw1bwdgouGymAliDajcjybkY7f+OMtkiLSl4LNTFU00JITKahW9krFP3EIU0hG0bF6rUuBfJDDkqGg5P4qOZMe35d8vMER7ttZBftCMxrHIt0l7+xwHRQbBz8f5gPa6QdZUjSOvgS7suFxC1Zbzz1woRwPb40sAVV0ewYakLEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rmoM5XdZSCG0IQymIs8Nrrx2EaS6/cU5V9J6nOA40tQ=; b=NN5NO4raLPKWcWez2JHf3sHZRckIwTAjAZgObsXRrYxh3z6bGc+o+NssxGntOkm19X7GZ4yP71VUPlaLKbKqIzpA5zFscnBhdgyK5HiEW/K4dAxejU+93Ld3lrGlFxQ3BGujaM87iACgWFT2/wecreVWiGGDMGsEHScX57u+D3UmNR4whSU8zjAkw09PU8axIsCKWii8fwD/iyEFb1WnJSRZLYmlmcIbo+JboVe7xwYKQjQKITl8pl/SGE9B/dT4R8aRhnJce4a7GtfxFCwKnPF1Q5kqng6pGojWqq7WH6l6KF6e+77KQBNCYJidcMaciqzC5jD2DkVg2IGfl2vU9g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <03ae5a1a-4417-0aa0-27d8-833ade20cc0b@suse.com> Date: Thu, 5 Jan 2023 16:59:14 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: [PATCH 01/11] x86/shadow: replace sh_reset_l3_up_pointers() Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Tim Deegan , George Dunlap References: <074dc3bb-6057-4f61-d516-d0fe3551165c@suse.com> In-Reply-To: <074dc3bb-6057-4f61-d516-d0fe3551165c@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0039.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS1PR04MB9285:EE_ X-MS-Office365-Filtering-Correlation-Id: 59051f4a-e839-4c34-6f74-08daef35cbcf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FTEVlLgcfqoiXp5dVP/eLRCdy9nVrMuV9os0uKWjLO5FOBp2XqUsOlFFmM2ieAKGN1UApSgusgic7EWQrbRzT0/DoHcbXOlr0lpFvPKqqosfkffCR/IilozbVKHs/7qSUc9uPLQaJSBdL9tPvWKQhQ4IwwEFBlDMYWQAS0plE40qF708ZpVjT2dgeDK/bOFUICNq3mwrJvPXWz4H2cCiFQISiio2yQmtUYlLVjvmvRGbkTn60fn/UTzP02i67DrjjGSk3bLElsRNG9krdO/53jgxZXVuqxcrH7lkfIdQI+JZjw/E/HzyiU4SBXI53aPJDRElbIb6LMCfm7AM+HQPWS6hcJFBJf2GaIdT8E0aNZhd6auEGg2i6oQ2YtVTytSo6Ah+5qDPyLkbCfSVdAI4fzMDZ4cJzK9lHVadm6vIHRVFxIdmzDz+qtREWmDTHw/ul73W3InhDsSHkWM774SNzCM6gymzkxlOBnZpEXUH5JwwE9AZhEUC0wHHGFIPTxtqeBZrgSMqZ9GGf5HKGY9TVe1MtXZsx4Q8jY/XCFCTSMU2XeuDyzc4mFQewQiie769kycTzBpZtmBtn27jAmuM0jOZ69Sd+ButFz4X/mDvLTMD7AafL7qegpvmk7bZhK+rqG2YDnkdCvG8KMarXK6k/lvyb1vj7pnqzPG5fiexHDg8EP7oGllkE2eOkmsuNqCRznDVLBxSGrsQV4YrYUMNhqOgR+i5kPDYpb62TlOE5fI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(346002)(376002)(366004)(136003)(396003)(451199015)(54906003)(186003)(26005)(31686004)(66476007)(66556008)(2616005)(6486002)(66946007)(6512007)(478600001)(83380400001)(8676002)(8936002)(5660300002)(41300700001)(4326008)(2906002)(316002)(31696002)(86362001)(38100700002)(6916009)(6506007)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dlpwdnZZeERmT2l0OXhZR2tBWFplTDZ6TXRLbDlYN1FEK0FLVzdoa3BWV2tS?= =?utf-8?B?bUJhakRuZ1N3T2RVaDVIVXluWXJpVWVQNlh0Q2R2YURWbTIxM0JZeHo3MTFw?= =?utf-8?B?TFF3ekdzN255QjFISkFGQVo5NXd4SDFtZ0ZEdHExV21lcm9MeEIxREx3d2Nh?= =?utf-8?B?QmVhMk9WZ1EzOFlMRmoxQmVQdEpYdnloWkR2R2tXMFBNTGZMOHR5NkhnYjhu?= =?utf-8?B?cVVLaDFKVHJqNENuUkhpeXhtNUNTd0Jxb0ExdHhqR0RnUnZQTmxHS2l3UzAw?= =?utf-8?B?VEIyTjltcWJBMVRyc3daN2RLU3VNMktFTkEzV2tZQU5uK0s2QXh3WHhlazFS?= =?utf-8?B?Qzc2dVQwOGZqblk5UFYzVVhob0l1ak10TlVrMHA3c2V1Zm1rYk83TXlhTzU2?= =?utf-8?B?ZkxnRE56TXVaSlRQUW04UkpsTjZSYUNtR0RkR0JaSUp6YWlyU3E4MjBOaDl6?= =?utf-8?B?NkZpOTV2T2hDbGZQcUt4V0FyaWxJRjBScHpYN1pOc2NTZ0lzYlczWHZhMmNV?= =?utf-8?B?bVBQOTFDSXlwd3pBc0tEanFBYUxEWnBRaXBXb3ZhZlVGYlJlOEpOOVA1UVZM?= =?utf-8?B?SFpRUmhEQ3JTVFptZVFSL0hpaFRKNWN6M0dZUWp1b05leTVSb0ZZWTgwR3Mw?= =?utf-8?B?T1hPdlgwZCsxbjdxUGdzTk9Jckt2V2xMUXBFQStjZStwc2NrZnJVbjBvZDFr?= =?utf-8?B?YTltNUV6Uk9CdXZUYkFlVU16Vnl2dGtrK0VaMlJhcjhzd2JRNFZrZExadGZy?= =?utf-8?B?LzBvYlRLSlFRdTM4QUdXZ1c4UXEvQ0tlU2szb1EwNTg3a25zVnNJeEd6Q29F?= =?utf-8?B?VndiTWpsQmtpTjQvQXJpdE9GV05ELytEMXBsZG9tNkFoYWdUN1RId1NLZlVD?= =?utf-8?B?YURJVjMxQ0ZhbnVyNnJPMXlFd0dJN2YraHBjSlNjOFBEWklmdzNBOUhaeXNB?= =?utf-8?B?N2M1RnNRU3NWblVHNnpOc25LdkhCVTJraWYrOTV3T01tNHVDdjhHbVlTb0Zs?= =?utf-8?B?dmpKam5UdGNFOG1JMHl5MzJ1RE04M1pQb3NQWm1kQ3pSdmdiVjFMcGVFREZE?= =?utf-8?B?SzNzczE5M3NlM3lZcGFIYldZd1ZPSUQ3Z0tXWGZzRmlpSmlheXJKTDNxWTNI?= =?utf-8?B?RU9nbzY1dUNjYTNuMG5Uc2JSNlZBVjRiV3V5cTlBQmJQUUMrQWZxaUNpbkFm?= =?utf-8?B?cFZ3NmtTbzN1ek84SlB4aStJbVlWVDZZYmdNU0NtZ3V5dmh2UkgrOXdyVE9N?= =?utf-8?B?VXRta2k1N1NJd2lJLzJ3bjF5TXVMU2pVLy9tZk9LRUFJR3JBYVd1U2dQSUFY?= =?utf-8?B?QWFBYmdueFRuTTRNTlF0UG55U0haVy9Sc1VlclpLTTNyUXF6cWIxZTZhdG9w?= =?utf-8?B?VWhOS1l0L3YxRnRjdWI5Q3ZackpucGJXT01Pb0NCWTdJTW5VdndPZU5PdEJq?= =?utf-8?B?L252cGw1VHNqcnF1Nm41RktwREsrNVN2QUFtVXJ4RWUrWFd6clVuMHNjeU9G?= =?utf-8?B?ZStZc0pSWVRYZ2dkaklwTUtoQ0VaY213TEplNGxjeWJicmFlVURHTHZRL2lN?= =?utf-8?B?Tms4VWZvOXlOM0J2dHVCOXFWVlNtdUN0TjkzdkxnUG1GTWZkK3VGS3RqWm1p?= =?utf-8?B?Z2F4Q1hucUs1OTgvUE01M2dZR2x5bEZPVUV6Mm1LZThWMkQ5eSt4WmhxeWhx?= =?utf-8?B?elQzOFdEWTZtdTgzZHRicGdZdGF0Vk4rVkFITU93TEtQQ1RXQWY0WmdLQXFH?= =?utf-8?B?TXlmV3FnTGJIWXpLTEw3NjN2U1FKMDJxUGUyMXJsNFc0Q3c4dDA0MkxoZ2ZN?= =?utf-8?B?UVhhKzBwcmlTbmVHRzhXODNncUhJL1BKWmE1bm54MmFyNmFpY3RaLyt0aXhE?= =?utf-8?B?ZTVnVnpDM0xienk2cUhCOTE5KzVnbnowM2ozc29Lbno2VWd2QmpqUUYzVjhv?= =?utf-8?B?SDFSRThNUHNtNVJ0SWJkdlpETWZTbnR6N0dpUGZDSFJuMWsvcnpMbXpXSU1M?= =?utf-8?B?MVhvUjJkWUcwdzJMdEwxWHNvbTJhMDhYMnNkOStZb29rMjA1cjFSNzVZZ05x?= =?utf-8?B?UXdpZ0M5cDFOMFZjb1FtYXUyeGc4djFRc3dzWlBiTXo2VldOTUNzNlQ5ZEJz?= =?utf-8?Q?KAVpB169ko7DFsCQsxcY6mKqf?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 59051f4a-e839-4c34-6f74-08daef35cbcf X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2023 15:59:15.9114 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: c/gj38l7AgNF5OFPO0/fRcXrJBCzrlW2XRt8HgGw71aRQk16bZVvetdPzXIEdBp/GzPmfCu+TwqO5d3u/HwuNQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9285 Rather than doing a separate hash walk (and then even using the vCPU variant, which is to go away), do the up-pointer-clearing right in sh_unpin(), as an alternative to the (now further limited) enlisting on a "free floating" list fragment. This utilizes the fact that such list fragments are traversed only for multi-page shadows (in shadow_free()). Furthermore sh_terminate_list() is a safe guard only anyway, which isn't in use in the common case (it actually does anything only for BIGMEM configurations). Signed-off-by: Jan Beulich --- a/xen/arch/x86/include/asm/domain.h +++ b/xen/arch/x86/include/asm/domain.h @@ -116,6 +116,9 @@ struct shadow_domain { /* OOS */ bool_t oos_active; + /* Domain is in the process of leaving SHOPT_LINUX_L3_TOPLEVEL mode. */ + bool unpinning_l3; + #ifdef CONFIG_HVM /* Has this domain ever used HVMOP_pagetable_dying? */ bool_t pagetable_dying_op; --- a/xen/arch/x86/mm/shadow/common.c +++ b/xen/arch/x86/mm/shadow/common.c @@ -2306,29 +2306,6 @@ void shadow_prepare_page_type_change(str /**************************************************************************/ -/* Reset the up-pointers of every L3 shadow to 0. - * This is called when l3 shadows stop being pinnable, to clear out all - * the list-head bits so the up-pointer field is properly inititalised. */ -static int cf_check sh_clear_up_pointer( - struct vcpu *v, mfn_t smfn, mfn_t unused) -{ - mfn_to_page(smfn)->up = 0; - return 0; -} - -void sh_reset_l3_up_pointers(struct vcpu *v) -{ - static const hash_vcpu_callback_t callbacks[SH_type_unused] = { - [SH_type_l3_64_shadow] = sh_clear_up_pointer, - }; - - HASH_CALLBACKS_CHECK(SHF_L3_64); - hash_vcpu_foreach(v, SHF_L3_64, callbacks, INVALID_MFN); -} - - -/**************************************************************************/ - static void sh_update_paging_modes(struct vcpu *v) { struct domain *d = v->domain; --- a/xen/arch/x86/mm/shadow/multi.c +++ b/xen/arch/x86/mm/shadow/multi.c @@ -960,6 +960,8 @@ sh_make_shadow(struct vcpu *v, mfn_t gmf } if ( l4count > 2 * d->max_vcpus ) { + d->arch.paging.shadow.unpinning_l3 = true; + /* Unpin all the pinned l3 tables, and don't pin any more. */ page_list_for_each_safe(sp, t, &d->arch.paging.shadow.pinned_shadows) { @@ -967,7 +969,8 @@ sh_make_shadow(struct vcpu *v, mfn_t gmf sh_unpin(d, page_to_mfn(sp)); } d->arch.paging.shadow.opt_flags &= ~SHOPT_LINUX_L3_TOPLEVEL; - sh_reset_l3_up_pointers(v); + + d->arch.paging.shadow.unpinning_l3 = false; } } #endif --- a/xen/arch/x86/mm/shadow/private.h +++ b/xen/arch/x86/mm/shadow/private.h @@ -497,11 +497,6 @@ void shadow_blow_tables(struct domain *d */ int sh_remove_all_mappings(struct domain *d, mfn_t gmfn, gfn_t gfn); -/* Reset the up-pointers of every L3 shadow to 0. - * This is called when l3 shadows stop being pinnable, to clear out all - * the list-head bits so the up-pointer field is properly inititalised. */ -void sh_reset_l3_up_pointers(struct vcpu *v); - /****************************************************************************** * Flags used in the return value of the shadow_set_lXe() functions... */ @@ -722,7 +717,7 @@ static inline void sh_unpin(struct domai { struct page_list_head tmp_list, *pin_list; struct page_info *sp, *next; - unsigned int i, head_type; + unsigned int i, head_type, sz; ASSERT(mfn_valid(smfn)); sp = mfn_to_page(smfn); @@ -734,20 +729,30 @@ static inline void sh_unpin(struct domai return; sp->u.sh.pinned = 0; - /* Cut the sub-list out of the list of pinned shadows, - * stitching it back into a list fragment of its own. */ + sz = shadow_size(head_type); + + /* + * Cut the sub-list out of the list of pinned shadows, stitching + * multi-page shadows back into a list fragment of their own. + */ pin_list = &d->arch.paging.shadow.pinned_shadows; INIT_PAGE_LIST_HEAD(&tmp_list); - for ( i = 0; i < shadow_size(head_type); i++ ) + for ( i = 0; i < sz; i++ ) { ASSERT(sp->u.sh.type == head_type); ASSERT(!i || !sp->u.sh.head); next = page_list_next(sp, pin_list); page_list_del(sp, pin_list); - page_list_add_tail(sp, &tmp_list); + if ( sz > 1 ) + page_list_add_tail(sp, &tmp_list); + else if ( head_type == SH_type_l3_64_shadow && + d->arch.paging.shadow.unpinning_l3 ) + sp->up = 0; sp = next; } - sh_terminate_list(&tmp_list); + + if ( sz > 1 ) + sh_terminate_list(&tmp_list); sh_put_ref(d, smfn, 0); } From xen-devel-bounces@lists.xenproject.org Thu Jan 05 15:59:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 15:59:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471987.732062 (Exim 4.92) (envelope-from ) id 1pDSeb-0000KC-Vf; Thu, 05 Jan 2023 15:59:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471987.732062; Thu, 05 Jan 2023 15:59:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDSeb-0000K3-Sx; Thu, 05 Jan 2023 15:59:41 +0000 Received: by outflank-mailman (input) for mailman id 471987; Thu, 05 Jan 2023 15:59:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDSea-0000Ja-9G for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 15:59:40 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2061.outbound.protection.outlook.com [40.107.247.61]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f4cccead-8d11-11ed-b8d0-410ff93cb8f0; Thu, 05 Jan 2023 16:59:38 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8498.eurprd04.prod.outlook.com (2603:10a6:20b:341::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 15:59:36 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 15:59:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f4cccead-8d11-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oKo9nrP3Em0BVszABkaGrsSeWIlHIN9fKTE80L45UsjljkAUV7OPHNltFpikUE4zE0JxybWBtjOn+wwRPRmw0tBTTY5SDgH8kEw42RMAIt5mtH2FbErvtCxtb7SIGS2G7Qaj/RhkxL4pskKXE3TvNjbtlo0XVYQUAhR1LNCZhcDD8vzQ6pX+TYuh5CcGcvtmKG5YD6MlklZwrZcXP/flDi83PpjdKtibdqLYkGnkNmVXmv5G+MLIJ6xQ2Eq8V3IyBwe1TazEjuTHI4sLJOcJOEEU7cw7QDCFqt5sjJeBaciD4kssI2Fy01bRKBYJGOpOa0RmiPYzZqhxFzMAJpelmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ssTI6at9j+dmm0UVb4iktGaytHsP2Cy0qsceqf5wJgQ=; b=hn0DDszc2nBSsRuDm3v5cAL6I62a+2xk0rdW8rcNpdW4lUCKT/u62rNbHeWSLQKyKwga4pPk36HbkDTIHjhqUL+uQFW3o14rkxJj+TMKNUFrwRNbeSX2/lEx0W2Zc6LXe5b3z6/EwM0Hcaefm5uh3wWg26udhARbqN9nA58RsYKV9P7jA7xtExrVv+oPuCyGAqBVpODXPBsM4qv4LT8WTteGx7/18tosmtqMMVDlbYftKcZOzbWiggpDNS/lNdcSdsWmBhc5NBF9Xp3FGmZc+CvrdsUPh5Iq5TNohc48wS6tv6lJBDO41JvnhpXyDtMEkaI5YOB2hpYBW0KF+j292Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ssTI6at9j+dmm0UVb4iktGaytHsP2Cy0qsceqf5wJgQ=; b=2RBAg+xx8kgkN831po1jqJcIGZOcFlOsr5Ngz2uR5KO1Hz0ccHP46lMwbo2lzVk9W7BpzlDGfcbCSvbOgTEYUyXOoeeELal3nh1rCRhFhXno6m0eSUKesiGGV0t62mA1jh7ZRFKiu4AiGug1JIdfRqJ9gSh2356tCA6uvD/2PaKTuhD6JKHvXGmtlK5x0RgplTCpz/UzEuDJy/8tgxu7bLBnfQs0ZCMpx2WaPowhWqaO2+SQIxVc9kpGycx62kN1YY4XIi/iEkZ7ld6/BLJ4e9I92MvdF5GnBtMSTpKl9fY9sSwM2x7HDI+lrvyl53btvtWG5BLD6G0m6Mxt5iROLw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 5 Jan 2023 16:59:34 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: [PATCH 02/11] x86/shadow: convert sh_audit_flags()'es 1st parameter to domain Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Tim Deegan , George Dunlap References: <074dc3bb-6057-4f61-d516-d0fe3551165c@suse.com> In-Reply-To: <074dc3bb-6057-4f61-d516-d0fe3551165c@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0046.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8498:EE_ X-MS-Office365-Filtering-Correlation-Id: 1beecf0d-43f8-45ed-1238-08daef35d7ce X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TCLgu6YBl5RO5kw9pDjgt7TEbbZx1slc1MN/kYGf4ExPPho0prgIVK8xGtOP012TIJqjJTpHZ54IuP/aTZf/21uZhFQc9uKI/qeYOiojFW2/JWCl4eD6Zf5N81iPHLf9f+h7Fv1XWv6G3qeg8e9SphlwaD84QFnKbAHv6ZgDkxiqjN7hWuOqL6EwAOjpqsDxxYBdVRk6pQbdv8RizYUmD1mvOWdmlkl+ogSTSN3Gd8ZHbayx21D965abWYNSFQ6o72vp0Witw7kOpvY5TjYKbye6qjnzsqPTpv7InVZ4n866JojRxmjCCjfOX/S8K+r0bXV8uR5/CWhcVQuKrCK290cgoZMVVYGdGm8jEaffdSftqQ/pVKY7MNaJYEKmo9Frf4fnesl44MG0g5ALijeAY7a0f3m+Xk44CldKLAxZDToYAUVRnyuxgjirY/1ACtamsMovVP3f1eFmaU5UCs+JmJX+j3HATt7THd5QKeYHHf86KVeIQX+jkuP9DtVPMnKk+d4QyC+cOxKLOnjbwqxVMkR50NOfz/XJTOriqxzpvSB0OBLeMko/Dii9a+on3g3sLzulqpmaqlIh18KCU5Ro4B4mXc/24PwcTFN3B0Q3f8LKcB1eWkF2IghSiHFvpEOL4fjohMSFyhYLCengpap9JkBVPqKtUe3jOkfzoR5pdFAO2IiOctPKNeRLtDpjE62WmLLb5EhYoFAeer8IJ7/xiCkJ5bej4317kGcXyJXRzdJL6UBV/5+eQHUOk7a8z1QRat0yMqBXGXnVpVOrS0mO2yA/i/cmiXw/y/A/D+RQGEacthmhrKnaE3pQvqblt/Ke X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(366004)(396003)(376002)(136003)(39860400002)(451199015)(38100700002)(41300700001)(36756003)(2906002)(8936002)(5660300002)(83380400001)(186003)(6512007)(26005)(478600001)(6486002)(31686004)(6506007)(316002)(66556008)(6916009)(66476007)(31696002)(86362001)(8676002)(54906003)(4326008)(66946007)(2616005)(45980500001)(43740500002)(414714003)(473944003)(357404004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SnpCYXp6R2dIaUQzU2l4aHRhUjhkNStyTUZIQlc0RXE2TUJhZUtHeE44Qmdx?= =?utf-8?B?SFZhYXpVVlBobHIrYjdUN3A1cENKa2ROS1c4SkU2cE4yQ2Z5Mng2bEgxSFNw?= =?utf-8?B?a2NDVzNCUjdHQi8yVVhUSHZUdnN5WUNRTW8rWlV5N3k4VWtmaEpIaFlmMHVY?= =?utf-8?B?TWZJZjFQK0M4OENXZFNudTBSS0x6U290MHkwSndWZ3c2OThHZk16c0Rrc1U2?= =?utf-8?B?VlhwWUNoWVU0WjZrQU9Vc0NDbmUyU2ZBdUZQaVlLRUZpMEkrem53amU5dHZ6?= =?utf-8?B?VzkyNTg1WTRDWFdTemNZUUwwYWw2NEs4cG8wSE8xcjJhVUJaWGRBZjZvcU1k?= =?utf-8?B?dEh2b0FqRk15K0U5TU54ZkU2bzYyaE8yTm5IYWZRMTJENkZBWE1rVWF6OEFU?= =?utf-8?B?RTNuNTQ0V21tcGdGaUdpR2FmUy9KcVVpRkpxS0RzRVVPajNOaVJwSzg2STNR?= =?utf-8?B?OG5qdDNYQjlIeFVTU2Zvb3RuSGl0MW00alNlUXhLNFowZVQ5dzBEeDFzdmls?= =?utf-8?B?L05TSnVZTWU1QmZJa3orUFdIUVdTTUYxNzBRRGMzV005cVl0RndwMHFVUSth?= =?utf-8?B?QmRPeldGLzQwcVMzb0lHY29JNVpNOHVXendCamVEVWJZMnJVVTA0cHFSK3JZ?= =?utf-8?B?bEhieFVuV0RrdWc2aWhCeU9TeHdVczQxaC96UndyRTlCOVJQYWhlRDZxRjBa?= =?utf-8?B?My9DYWJNMDMxNElBbFQxQXU5aU9GWDk2SjJvQ0lWZVdpWHFOWmxMYzd5Q0l3?= =?utf-8?B?T3RrTTRIS0NRemhOZkFZbWk5Zm5XZkdXYnhESE9DeXNFR0loVWRBNTZtRndL?= =?utf-8?B?YUJZTjRGZUVBZG9IRGZ1Vm1sdys5ZXNSMFRlb2J4MEVIbUk2Vm1RSGZFOUFw?= =?utf-8?B?TkNjWVQ5M0ZJbHdHWDE2TkZxNXU4NmVKcHgyU0tETUhuY21zMStTY1BXeGtz?= =?utf-8?B?WDJCNWdYZWl6Rmx0b2dnUzQ4VG9sRXpKQ0RsQU5XRDg5aUY5emQ1SnBWbU42?= =?utf-8?B?S29keUlFNVZtaExpSkh0K1FkdGZCelVOMEFjSUNaSnR4ek1SaUF5ZEw0OXhB?= =?utf-8?B?Z2dFamtZYjBXaW5iK3h6NmhNT1VXWFFuemRWeTdmMWVCTTdyMHROMXhFSW1Y?= =?utf-8?B?VWwrWVo3ZzNKVGY2c3QrRkZHWVpNdWY3Qkc5dFlCMHlSdWZ5MlArdktTeTcr?= =?utf-8?B?ZklsaUdHc2JtSkhLc1p4bEhYZnRPRkJJcUJOeGFuazBZUU9IYzY2UUh2WTJj?= =?utf-8?B?QmZoN1YzMWhxRUlZTXloODcybytlV044MFM2bnQ0Q0crbTBOZ1lOTVhXa2pZ?= =?utf-8?B?L1RrRVI3RVdlMWlyeFhicGRNMGN1eERtbG5OUktvYmpPZ2NBWlU3TmRBNHRO?= =?utf-8?B?S0grSE5lUnVPOVJnVGtIUk9abGQ2NzQydkgrV2NnR0VRZFdZM0FUQ3IrNG9w?= =?utf-8?B?djQ4NkVSaC9yemJOMXBrVVhFQ1lDdHUvZ1o5cEZSODgrd3p6cHV0NlZrNFA4?= =?utf-8?B?YUVBbGdlS0NaZ0R5NEhMc0djVUNqeDVwU0tlMHJDVnpad1BRMXU3S2FEWWdR?= =?utf-8?B?RmF1UytQTjFOMFQ4OXAvcjQ1T05tWjkvNnd5QUFCdjBNYzFmQndRY1hCVlhm?= =?utf-8?B?WlFRK1VBdkkzc0YyRmFycndpaU5XQXZsbE5YY2QwVVhjY2JvbTA5N0ZmbGlW?= =?utf-8?B?SzFISXp4SmYxT3h3ZlJEeHl2emtUZGUzL2F5R1VGalc3R2NxcEliLzBVQkVM?= =?utf-8?B?d3lMMmZGbDhadHhaRDBXQndiZ0lML3VITUxiaWxRSGNtN1dCNzlUSXlGZUFO?= =?utf-8?B?MndFS2JxblF1RnFNU2x1SE40MEtDYW43YllZRGZ6NDd2bHp1UDBiN25UQWdm?= =?utf-8?B?ZHlkemtHcFdhVFdneFZGblQ5M0hKNEQvYTVBdGZFbTZTSkFMYm1JNUtCeDZu?= =?utf-8?B?TncrQmtCTGVzcXRpb21zcmVWWEJZdlVwZUN5a1hCSk41NWk0b0ZWTFVPZ3RO?= =?utf-8?B?V3pzd1p1T2VkTVpJeXEwcEhEc1VJbTlvK0w2dWZ6Nk85WlJidGlscTcrakdu?= =?utf-8?B?WnkxSGwvdUxobk1MYmN6YzVna2FZOC9LZWZTQ0s5dEZxREZ1SHowRk5WdThT?= =?utf-8?Q?r9/FykCNYn3h+Mm2AEXmsQHZN?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1beecf0d-43f8-45ed-1238-08daef35d7ce X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2023 15:59:36.0508 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4metWACwmbaaQeyvmJyFj/QJ02e4TS3mtJkR00Uzs+7WPuBxm9GNKFMW+4vEjTVAzi8HKTSsw74kcczGaFmWYQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8498 Nothing in there is vCPU-specific. With the introduction of the local variable in sh_audit_l1_table(), convert other uses of v->domain as well. Signed-off-by: Jan Beulich --- a/xen/arch/x86/mm/shadow/multi.c +++ b/xen/arch/x86/mm/shadow/multi.c @@ -3919,13 +3919,13 @@ static void cf_check sh_pagetable_dying( done = 1; \ } while (0) -static const char *sh_audit_flags(struct vcpu *v, int level, +static const char *sh_audit_flags(const struct domain *d, int level, int gflags, int sflags) /* Common code for auditing flag bits */ { if ( (sflags & _PAGE_PRESENT) && !(gflags & _PAGE_PRESENT) ) return "shadow is present but guest is not present"; - if ( (sflags & _PAGE_GLOBAL) && !is_hvm_vcpu(v) ) + if ( (sflags & _PAGE_GLOBAL) && !is_hvm_domain(d) ) return "global bit set in PV shadow"; if ( level == 2 && (sflags & _PAGE_PSE) ) return "PS bit set in shadow"; @@ -3948,6 +3948,7 @@ static const char *sh_audit_flags(struct int cf_check sh_audit_l1_table(struct vcpu *v, mfn_t sl1mfn, mfn_t x) { + struct domain *d = v->domain; guest_l1e_t *gl1e, *gp; shadow_l1e_t *sl1e; mfn_t mfn, gmfn, gl1mfn; @@ -3964,7 +3965,7 @@ int cf_check sh_audit_l1_table(struct vc /* Out-of-sync l1 shadows can contain anything: just check the OOS hash */ if ( page_is_out_of_sync(mfn_to_page(gl1mfn)) ) { - oos_audit_hash_is_present(v->domain, gl1mfn); + oos_audit_hash_is_present(d, gl1mfn); return 0; } #endif @@ -3994,7 +3995,7 @@ int cf_check sh_audit_l1_table(struct vc } else { - s = sh_audit_flags(v, 1, guest_l1e_get_flags(*gl1e), + s = sh_audit_flags(d, 1, guest_l1e_get_flags(*gl1e), shadow_l1e_get_flags(*sl1e)); if ( s ) AUDIT_FAIL(1, "%s", s); @@ -4002,7 +4003,7 @@ int cf_check sh_audit_l1_table(struct vc { gfn = guest_l1e_get_gfn(*gl1e); mfn = shadow_l1e_get_mfn(*sl1e); - gmfn = get_gfn_query_unlocked(v->domain, gfn_x(gfn), &p2mt); + gmfn = get_gfn_query_unlocked(d, gfn_x(gfn), &p2mt); if ( !p2m_is_grant(p2mt) && !mfn_eq(gmfn, mfn) ) AUDIT_FAIL(1, "bad translation: gfn %" SH_PRI_gfn " --> %" PRI_mfn " != mfn %" PRI_mfn, @@ -4064,8 +4065,8 @@ int cf_check sh_audit_l2_table(struct vc gl2e = gp = map_domain_page(gl2mfn); SHADOW_FOREACH_L2E(sl2mfn, sl2e, &gl2e, done, d, { - s = sh_audit_flags(v, 2, guest_l2e_get_flags(*gl2e), - shadow_l2e_get_flags(*sl2e)); + s = sh_audit_flags(d, 2, guest_l2e_get_flags(*gl2e), + shadow_l2e_get_flags(*sl2e)); if ( s ) AUDIT_FAIL(2, "%s", s); if ( SHADOW_AUDIT & SHADOW_AUDIT_ENTRIES_MFNS ) @@ -4116,8 +4117,8 @@ int cf_check sh_audit_l3_table(struct vc gl3e = gp = map_domain_page(gl3mfn); SHADOW_FOREACH_L3E(sl3mfn, sl3e, &gl3e, done, { - s = sh_audit_flags(v, 3, guest_l3e_get_flags(*gl3e), - shadow_l3e_get_flags(*sl3e)); + s = sh_audit_flags(d, 3, guest_l3e_get_flags(*gl3e), + shadow_l3e_get_flags(*sl3e)); if ( s ) AUDIT_FAIL(3, "%s", s); if ( SHADOW_AUDIT & SHADOW_AUDIT_ENTRIES_MFNS ) @@ -4164,8 +4165,8 @@ int cf_check sh_audit_l4_table(struct vc gl4e = gp = map_domain_page(gl4mfn); SHADOW_FOREACH_L4E(sl4mfn, sl4e, &gl4e, done, d, { - s = sh_audit_flags(v, 4, guest_l4e_get_flags(*gl4e), - shadow_l4e_get_flags(*sl4e)); + s = sh_audit_flags(d, 4, guest_l4e_get_flags(*gl4e), + shadow_l4e_get_flags(*sl4e)); if ( s ) AUDIT_FAIL(4, "%s", s); if ( SHADOW_AUDIT & SHADOW_AUDIT_ENTRIES_MFNS ) From xen-devel-bounces@lists.xenproject.org Thu Jan 05 15:59:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 15:59:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.471993.732074 (Exim 4.92) (envelope-from ) id 1pDSet-0000pt-Bb; Thu, 05 Jan 2023 15:59:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 471993.732074; Thu, 05 Jan 2023 15:59:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDSet-0000pk-8m; Thu, 05 Jan 2023 15:59:59 +0000 Received: by outflank-mailman (input) for mailman id 471993; Thu, 05 Jan 2023 15:59:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDSes-0008Jw-Ef for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 15:59:58 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2084.outbound.protection.outlook.com [40.107.247.84]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 00508178-8d12-11ed-91b6-6bf2151ebd3b; Thu, 05 Jan 2023 16:59:57 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8498.eurprd04.prod.outlook.com (2603:10a6:20b:341::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 15:59:56 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 15:59:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 00508178-8d12-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aBAGFaC+7XaXEaS/dMOryNP8HQJjZaJgWlsPf8YSRNoX2nhTcHx8BN9OPCZ0ghGj2h1mfpcHcxFYWugMFPKXx656Ui1k0WuaWoc0w6b3tBV4el8J+UZ1Uu7uw9ONtKCbUq6MS+Xfq6Z+ehawsia9QN33tmh8bzvxut0cKRvx+sJBlJuBJGgSk80vX92j97RfcIdLMxlcj8Twv/Z1A6Qc9fnLEVQSu3xM7T/1DIec4/nhxrEL6p220Ovb9eSOHt9B/VbPsR3gcITTXVc24NOLyvTBYfbgBhSsjQkfnso54zsfVmW6SqrODVyqdoVch/GiZ2QhIyULe3AtHbQGltzGBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0MAeVXjSAqbPszhTtBmGKP8+Eqtn6/71idrhhw4dk4U=; b=cIi/8cE5EczZeXkInl+/1Cs8QWA8mtfdQytQCHE3xg+bLry2lnI7eCVAwAfo9pUdUViw6IsyuZQo5D+qmt0xmKaOzecmby/6M7yUCZjVvN9r1vDyqt5ph4Ppgz/f60xE34HQo7jmvpoS5IR/1U5vUVuMy3OFD07DFPKMaf2+V4kMtpKq6paxBW54qkMR8M+UHek/eNpylprBkzrRWBqY1fR22xcPj/7qk9Cyuyxcgx6x0cCBVcG/+vI+7b5t9jVCad5+aXPUCrjLjQyjh70Nf3s0c7qblO78qeFM3a6GAElP15Lj+EjmdOx27kxNnzEW0WQamr4WjWBO4CM2B9BbpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0MAeVXjSAqbPszhTtBmGKP8+Eqtn6/71idrhhw4dk4U=; b=CLHNi215qsvBFMX1AQSq46LskidQpk2iR6B37Zv7cfzoL5vw/IpazCn8HHcqPfX/19KQOldOxZJ+NEGitxt02Yh1nwd9ZKrrVbiIp94j38GqNKsbDHj3SXha73mk/4NQu1K0FzJ17jojiFwpr5ng/hurKwRy4fUemfWhnoh2EAdmgSXObAU7qHBH4TGRKdzP/q0BWkI5ENTerJ6+fMBO5IcWj5e+/VMLWRY9xQ7P2QaBUL/5AIwvBFZkKXOb25FNUSw2FJXdiZNqlKLtTFgS9bf6wbxTzYpWeW8cWHhU/xpW5ZyVMIZw3qUiNL+34s66JxgMg0Xkv+bwupAF37osYQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9096ecd9-b3ec-4d06-8641-f8d6cef19027@suse.com> Date: Thu, 5 Jan 2023 16:59:55 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: [PATCH 03/11] x86/shadow: drop hash_vcpu_foreach() Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Tim Deegan , George Dunlap References: <074dc3bb-6057-4f61-d516-d0fe3551165c@suse.com> In-Reply-To: <074dc3bb-6057-4f61-d516-d0fe3551165c@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0112.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8498:EE_ X-MS-Office365-Filtering-Correlation-Id: ff7b9a27-cbaa-4d0c-29be-08daef35e3e2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wMA0ow7UH2i2HFI6MYvE66D9IP3H0N4cmahrWnviOiahEWb7sz+WfCQwhn/hTtN0iG2/CLnILb+7ft3cFxkIi5s0h3wON6DmsR7CeZprOaHsvIqHasBJIQKcW/DK8evOSBXFDJebmRcgSjc2EoR5TDkTFLPQqE/KPl8xUJJ1xq2ZRwku/o47QjDsWbTcqzhZf0p07jXebdGkSrs01R+fAosvvylKxK3Uc0bNT0DARD4k4xrK6rOGzdUy3sSBTMVoA44xq/6ZZwmRZhQhd/pB0VLxpqbltW1FlEiryclG4SwHeWfeQywyzO7QuClIAQj9clD/N4I+/+JLsX3/3/8Wf7FWc7KXLuCllg8wxm3aKmvis7ZQb0Gu5AeNrGrcLl+gMYzOP+eMqWJt1xFG/cJ3mEiJXGR9sQ+hk3KZP35vEIuYe3goCGvX7MOWJdIKQNajYmWoHO9kVDQ/Q5OkN7JzW1kbAlTIG6MsfKuvAQ7bd2s8OqShANB+058L2qbiNCU7US8r62xNBr6ln3iqvoeAG3ov7JXgqY1Fii6hM8xR0xj5Ava/wUuahIPuoB9zFLI/hj1N5mkMgwADMnlnpB9hnae65nh6TEtTL5+XRGhFKavpY0j91dVWngn/9W4HJfPsfujZBAgwx2QXBxxOZsuUEn82BLVWkmu6+MbzhUgngf6vrJo+zB8YNVOIff/+zc1uGbYxHYhZ1yssCmFb95pyV4vSIqXdoKenE3wUhktYFIMbYBswtd4uPyy+ZL0KFdhQkV8rlqOe4AhscWeZdbq6gduh7zxFwbOtnT9Od6G4h40c0+dWEvVJpcRNJ/NwZ2D6 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(366004)(396003)(376002)(136003)(39860400002)(451199015)(38100700002)(41300700001)(36756003)(2906002)(8936002)(5660300002)(83380400001)(186003)(6512007)(26005)(478600001)(6486002)(31686004)(6506007)(316002)(66556008)(6916009)(66476007)(31696002)(86362001)(8676002)(54906003)(4326008)(66946007)(2616005)(45980500001)(43740500002)(414714003)(473944003)(357404004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ejlnMWhta3N5dXBNdHhxNmhsWmdTWU8yL3Y2RTVpcjluVk93OTF5L3NQeWhS?= =?utf-8?B?Yi9RbytQUFVGMDQxNDFxOTJESUhIcUJKdFlKWDZoak9WNmhvcHRMYThkR095?= =?utf-8?B?RDVvS3BoR0UvdEVqZ1NuSjhiR2FydkJHNkpTNzhJYmJMR3VUMWZHbUs3emk3?= =?utf-8?B?VlQ1Y3hwOXNHbmNMT0NKcGdHNkdJNVg1UG5QQ3YwYjVwdE92K1YwVWtQNUxZ?= =?utf-8?B?TDhkMWFRdkhvMGFSOEZwWFArd1pHTE1iTlhsbEtnWFRFQnhLZXJlL0NiWFFl?= =?utf-8?B?VkM2TTc1clh4aW5qcTJmWUZhWTlpek5PRjRxc2JGVXJkNE9FSHhVWFBMMmMy?= =?utf-8?B?U3lBQUpodFFSbFhFSE9TMUNDaFhOUnpwOHVIeGJCZit2VnFCZEpyQ2traExM?= =?utf-8?B?M1Y4NmpLS0RNZTF0ZDZYYzVobHJnekhpYWdVMUVXZlRwWE1RRi8waGZWS2pY?= =?utf-8?B?VDBhVXR1VWJQQm1qSWsxSTVEZzIrUW9KQmV5UCswMjZNUUE2MVBDaEd2R0RB?= =?utf-8?B?L25sS05QbmVnNU5QK1hsWlVsZkdzRk94cGNQWW5ycWhiNlBpLy9ZNWNFbXJa?= =?utf-8?B?MEdDRytUY25DTkQwdmxzUFNiOFBoOVdQNmdGTTg2ZVExcytwUmFhdW02WVFF?= =?utf-8?B?akVUYitwRHFrTTFNSHgyTXJlTXVlbG90MFEyOVM2aXVRT2hUMjdkaytUQWFU?= =?utf-8?B?Q1FodkJoYmRwVjNQUGtKSVhYVHRJcnBKK21UTkVnUCtnSDRQQzJzaCt3T2dp?= =?utf-8?B?djFKbTBEQ3NkMlY2dWRTa3RydmVRam9qVTRiL2ptS1dFa1dOV3hSZWVGMkJL?= =?utf-8?B?YkNOa2ZFYkx5K1pHT2QrbHVUUUdRODdEZEVubVFFN0dEQkZSYlN0SWo0cWVQ?= =?utf-8?B?VWZzTG5SdnlSdURnUzA0NlZBUWV0ZWJQS1hHSUtPbjYrdjFDNTQ4TmF5OUxG?= =?utf-8?B?dGZ1U0RWUlRyVjZqWng0Qk0xQURDbHlQZ2twVWRIK1FqOXFxb1Q0TXVVU2FG?= =?utf-8?B?SVZRbjVpaVVMSTZ3a2I1eG1paWtjVWwzY2hEZUVnM3ppZWhIbkNKRzBma0tr?= =?utf-8?B?U0V4NFlPQkV0eDhwRVlValdoSmFwOXhkRGxMSFE5Mjhnbk5kRVA3Uko4dkhq?= =?utf-8?B?clNEZ1VzaDQ0SmJvc25XZUhIV0NDd0wxY1M0UDc1ZHJGa1NwUXNwK0VoUHB3?= =?utf-8?B?L2RIVExaZTNTdWduQ3phVS9rQzQ4U2tBYmY4bS94LzV4YlZjcVR3Q2M4Q3V5?= =?utf-8?B?Q0p0NlRNS3ByNTA3aEJrajU2QW5iZmRvbEJWUy93ZVZadkZub2pNaERjS1Y5?= =?utf-8?B?ZnVETWNEYS82dUhmSEJJeW51ZWxyMS8yT24yUDUyS0szeVBmdElmblRHUzd6?= =?utf-8?B?ejUrMXczUzEwN1ZvQ2k1YU1ZaDVobzBNWUp0US9LbE1YaGUxQXhpK1FRc1Ni?= =?utf-8?B?SENFemR6UXBjUmFJWTFOU0hjblIyZ3NvMUNqcW1GZlg2WHBkSXZPUGppUER3?= =?utf-8?B?WEpEMCtQbC9oeGRHWHZIT3g4emJKc3M5bnp0TlFEMEFEVndINHBNY280dkFQ?= =?utf-8?B?Z25hNElXbVRKY1RrcmFMVnZIT1UyeG0zSUU4MHVlek1ReWpZUTROK0VkcFJT?= =?utf-8?B?c3RpT3BISGJJdzZCd3BURXAweVU3bDlPdk5oVUdVZVd0QVZ3NjRCM0M0ZEdu?= =?utf-8?B?RkFRaDU0bUNMRDA1YWRiTWpqSjV3SEE0RWZoMnh3cHY4TDhLVnlNTmgvb3g5?= =?utf-8?B?c0xjTzE3cnFIaEo0TmJvbzlRVDgwOXFTc1c0a2ZPQWtqeTUwMVZzYThIL25V?= =?utf-8?B?MEtJUURMR1VRc3dDaWNrRjR3SlZ1UWVWSGNBUFQzVjJ6bGMwTkRVdnYwV3U1?= =?utf-8?B?TkEyY0RTaVlhSHF6aWJOdC9kN0phZElWblNDdCtqY1RUR1BaNWlMa2RIVW1p?= =?utf-8?B?Nk9BOW9iQWRaYjFDUndPYUF4cTlPSDMwaHhsamh5RThlY0xYZlpGem95MU1X?= =?utf-8?B?dmNQSkxZTGhldnlEeGRPaVZGRlFpakRncVFEZ3VvRnl1ZmVvUEZkS2FUc2xV?= =?utf-8?B?SXBTK0VVS1RLNTBhditOUzRxWE9kMGs4QW5UUElBVEpSeGVPcUJYRzZRaGhC?= =?utf-8?Q?E0L7ERpl/SYCFvPQ5RpMUUJMz?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ff7b9a27-cbaa-4d0c-29be-08daef35e3e2 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2023 15:59:56.3307 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JiJSv7t2nDH/vrExr8DiKaQCocO2Paf1PDFdzbgsUuVqoUuUFHSeXzPGQqkyQSJankupVF5RQhgRkEbKst6Qfg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8498 The domain based variant is easily usable by shadow_audit_tables(); all that's needed is conversion of the callback functions. Signed-off-by: Jan Beulich --- a/xen/arch/x86/mm/shadow/common.c +++ b/xen/arch/x86/mm/shadow/common.c @@ -1640,59 +1640,11 @@ bool shadow_hash_delete(struct domain *d return true; } -typedef int (*hash_vcpu_callback_t)(struct vcpu *v, mfn_t smfn, mfn_t other_mfn); typedef int (*hash_domain_callback_t)(struct domain *d, mfn_t smfn, mfn_t other_mfn); #define HASH_CALLBACKS_CHECK(mask) \ BUILD_BUG_ON((mask) > (1U << ARRAY_SIZE(callbacks)) - 1) -static void hash_vcpu_foreach(struct vcpu *v, unsigned int callback_mask, - const hash_vcpu_callback_t callbacks[], - mfn_t callback_mfn) -/* Walk the hash table looking at the types of the entries and - * calling the appropriate callback function for each entry. - * The mask determines which shadow types we call back for, and the array - * of callbacks tells us which function to call. - * Any callback may return non-zero to let us skip the rest of the scan. - * - * WARNING: Callbacks MUST NOT add or remove hash entries unless they - * then return non-zero to terminate the scan. */ -{ - int i, done = 0; - struct domain *d = v->domain; - struct page_info *x; - - ASSERT(paging_locked_by_me(d)); - - /* Can be called via p2m code &c after shadow teardown. */ - if ( unlikely(!d->arch.paging.shadow.hash_table) ) - return; - - /* Say we're here, to stop hash-lookups reordering the chains */ - ASSERT(d->arch.paging.shadow.hash_walking == 0); - d->arch.paging.shadow.hash_walking = 1; - - for ( i = 0; i < SHADOW_HASH_BUCKETS; i++ ) - { - /* WARNING: This is not safe against changes to the hash table. - * The callback *must* return non-zero if it has inserted or - * deleted anything from the hash (lookups are OK, though). */ - for ( x = d->arch.paging.shadow.hash_table[i]; x; x = next_shadow(x) ) - { - if ( callback_mask & (1 << x->u.sh.type) ) - { - ASSERT(x->u.sh.type <= SH_type_max_shadow); - ASSERT(callbacks[x->u.sh.type] != NULL); - done = callbacks[x->u.sh.type](v, page_to_mfn(x), - callback_mfn); - if ( done ) break; - } - } - if ( done ) break; - } - d->arch.paging.shadow.hash_walking = 0; -} - static void hash_domain_foreach(struct domain *d, unsigned int callback_mask, const hash_domain_callback_t callbacks[], @@ -3215,7 +3167,7 @@ int shadow_domctl(struct domain *d, void shadow_audit_tables(struct vcpu *v) { /* Dispatch table for getting per-type functions */ - static const hash_vcpu_callback_t callbacks[SH_type_unused] = { + static const hash_domain_callback_t callbacks[SH_type_unused] = { #if SHADOW_AUDIT & (SHADOW_AUDIT_ENTRIES | SHADOW_AUDIT_ENTRIES_FULL) # ifdef CONFIG_HVM [SH_type_l1_32_shadow] = SHADOW_INTERNAL_NAME(sh_audit_l1_table, 2), @@ -3262,7 +3214,7 @@ void shadow_audit_tables(struct vcpu *v) HASH_CALLBACKS_CHECK(SHADOW_AUDIT & (SHADOW_AUDIT_ENTRIES | SHADOW_AUDIT_ENTRIES_FULL) ? SHF_page_type_mask : 0); - hash_vcpu_foreach(v, mask, callbacks, INVALID_MFN); + hash_domain_foreach(v->domain, mask, callbacks, INVALID_MFN); } #ifdef CONFIG_PV --- a/xen/arch/x86/mm/shadow/multi.c +++ b/xen/arch/x86/mm/shadow/multi.c @@ -326,32 +326,32 @@ static void sh_audit_gw(struct vcpu *v, if ( mfn_valid(gw->l4mfn) && mfn_valid((smfn = get_shadow_status(d, gw->l4mfn, SH_type_l4_shadow))) ) - (void) sh_audit_l4_table(v, smfn, INVALID_MFN); + sh_audit_l4_table(d, smfn, INVALID_MFN); if ( mfn_valid(gw->l3mfn) && mfn_valid((smfn = get_shadow_status(d, gw->l3mfn, SH_type_l3_shadow))) ) - (void) sh_audit_l3_table(v, smfn, INVALID_MFN); + sh_audit_l3_table(d, smfn, INVALID_MFN); #endif /* PAE or 64... */ if ( mfn_valid(gw->l2mfn) ) { if ( mfn_valid((smfn = get_shadow_status(d, gw->l2mfn, SH_type_l2_shadow))) ) - (void) sh_audit_l2_table(v, smfn, INVALID_MFN); + sh_audit_l2_table(d, smfn, INVALID_MFN); #if GUEST_PAGING_LEVELS >= 4 /* 32-bit PV only */ if ( mfn_valid((smfn = get_shadow_status(d, gw->l2mfn, SH_type_l2h_shadow))) ) - (void) sh_audit_l2_table(v, smfn, INVALID_MFN); + sh_audit_l2_table(d, smfn, INVALID_MFN); #endif } if ( mfn_valid(gw->l1mfn) && mfn_valid((smfn = get_shadow_status(d, gw->l1mfn, SH_type_l1_shadow))) ) - (void) sh_audit_l1_table(v, smfn, INVALID_MFN); + sh_audit_l1_table(d, smfn, INVALID_MFN); else if ( (guest_l2e_get_flags(gw->l2e) & _PAGE_PRESENT) && (guest_l2e_get_flags(gw->l2e) & _PAGE_PSE) && mfn_valid( (smfn = get_fl1_shadow_status(d, guest_l2e_get_gfn(gw->l2e)))) ) - (void) sh_audit_fl1_table(v, smfn, INVALID_MFN); + sh_audit_fl1_table(d, smfn, INVALID_MFN); #endif /* SHADOW_AUDIT & SHADOW_AUDIT_ENTRIES */ } @@ -3946,9 +3946,8 @@ static const char *sh_audit_flags(const return NULL; } -int cf_check sh_audit_l1_table(struct vcpu *v, mfn_t sl1mfn, mfn_t x) +int cf_check sh_audit_l1_table(struct domain *d, mfn_t sl1mfn, mfn_t x) { - struct domain *d = v->domain; guest_l1e_t *gl1e, *gp; shadow_l1e_t *sl1e; mfn_t mfn, gmfn, gl1mfn; @@ -4015,7 +4014,7 @@ int cf_check sh_audit_l1_table(struct vc return done; } -int cf_check sh_audit_fl1_table(struct vcpu *v, mfn_t sl1mfn, mfn_t x) +int cf_check sh_audit_fl1_table(struct domain *d, mfn_t sl1mfn, mfn_t x) { guest_l1e_t *gl1e, e; shadow_l1e_t *sl1e; @@ -4041,9 +4040,8 @@ int cf_check sh_audit_fl1_table(struct v return 0; } -int cf_check sh_audit_l2_table(struct vcpu *v, mfn_t sl2mfn, mfn_t x) +int cf_check sh_audit_l2_table(struct domain *d, mfn_t sl2mfn, mfn_t x) { - struct domain *d = v->domain; guest_l2e_t *gl2e, *gp; shadow_l2e_t *sl2e; mfn_t mfn, gmfn, gl2mfn; @@ -4093,9 +4091,8 @@ int cf_check sh_audit_l2_table(struct vc } #if GUEST_PAGING_LEVELS >= 4 -int cf_check sh_audit_l3_table(struct vcpu *v, mfn_t sl3mfn, mfn_t x) +int cf_check sh_audit_l3_table(struct domain *d, mfn_t sl3mfn, mfn_t x) { - struct domain *d = v->domain; guest_l3e_t *gl3e, *gp; shadow_l3e_t *sl3e; mfn_t mfn, gmfn, gl3mfn; @@ -4141,9 +4138,8 @@ int cf_check sh_audit_l3_table(struct vc return 0; } -int cf_check sh_audit_l4_table(struct vcpu *v, mfn_t sl4mfn, mfn_t x) +int cf_check sh_audit_l4_table(struct domain *d, mfn_t sl4mfn, mfn_t x) { - struct domain *d = v->domain; guest_l4e_t *gl4e, *gp; shadow_l4e_t *sl4e; mfn_t mfn, gmfn, gl4mfn; --- a/xen/arch/x86/mm/shadow/multi.h +++ b/xen/arch/x86/mm/shadow/multi.h @@ -83,19 +83,19 @@ SHADOW_INTERNAL_NAME(sh_remove_l3_shadow #if SHADOW_AUDIT & SHADOW_AUDIT_ENTRIES int cf_check SHADOW_INTERNAL_NAME(sh_audit_l1_table, GUEST_LEVELS) - (struct vcpu *v, mfn_t sl1mfn, mfn_t x); + (struct domain *d, mfn_t sl1mfn, mfn_t x); int cf_check SHADOW_INTERNAL_NAME(sh_audit_fl1_table, GUEST_LEVELS) - (struct vcpu *v, mfn_t sl1mfn, mfn_t x); + (struct domain *d, mfn_t sl1mfn, mfn_t x); int cf_check SHADOW_INTERNAL_NAME(sh_audit_l2_table, GUEST_LEVELS) - (struct vcpu *v, mfn_t sl2mfn, mfn_t x); + (struct domain *d, mfn_t sl2mfn, mfn_t x); int cf_check SHADOW_INTERNAL_NAME(sh_audit_l3_table, GUEST_LEVELS) - (struct vcpu *v, mfn_t sl3mfn, mfn_t x); + (struct domain *d, mfn_t sl3mfn, mfn_t x); int cf_check SHADOW_INTERNAL_NAME(sh_audit_l4_table, GUEST_LEVELS) - (struct vcpu *v, mfn_t sl4mfn, mfn_t x); + (struct domain *d, mfn_t sl4mfn, mfn_t x); #endif extern const struct paging_mode From xen-devel-bounces@lists.xenproject.org Thu Jan 05 16:00:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 16:00:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472002.732085 (Exim 4.92) (envelope-from ) id 1pDSfQ-0002ri-Ky; Thu, 05 Jan 2023 16:00:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472002.732085; Thu, 05 Jan 2023 16:00:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDSfQ-0002rb-IC; Thu, 05 Jan 2023 16:00:32 +0000 Received: by outflank-mailman (input) for mailman id 472002; Thu, 05 Jan 2023 16:00:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDSfP-0000Ja-JV for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 16:00:31 +0000 Received: from EUR03-VI1-obe.outbound.protection.outlook.com (mail-vi1eur03on2050.outbound.protection.outlook.com [40.107.103.50]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 134a6360-8d12-11ed-b8d0-410ff93cb8f0; Thu, 05 Jan 2023 17:00:29 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB8046.eurprd04.prod.outlook.com (2603:10a6:102:ba::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 16:00:27 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 16:00:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 134a6360-8d12-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fxAjOOLrji3RG5UA1diO5HQwpPpZmwtgl/I4YEhiFwdGWMqONKqxCWXTBeHzm3iPhlRWZIUXQq+llrbVlocHN00J1vrSs/hwR+wuweTW101hIuS/eDiRbGmjrCrE/41lSrCNx5abbvpy63aL88EBK4aua1/7ZxLnJusC5ePjiqXU8P+M4660veGwJ42/lZ4Ibb3nWQL6M+c/RdZj6wjIN7UODCG/dzYpgnfDeez+KJw/PlnEo+giB1nI8lixJi41IjB/oLdLxpK+fDj0r6to6djr15Mi3uSvyBptWvBk5NSHdZIh39lXodr46vLXOqEs0tdbWaKUHCn+hhFdeaplQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ccVaAbNoDzT3PDnX15GWyJdkpvb9ChZOySArZobL5pY=; b=J16Pr14Zty8dPH0kjaQ69LVW9oK8wGdnE/S5ZtL2VbqsJIPuXyReoOn9IUCFKPM5iLXz2505wNnMrhJE8DEHO8FzrZokXtcbiTPPcQhWQqepMpEk2Z+6Lk7wEWiZak4TNXasxUnoh0tdejQXQ3xKbZr0SkSxnVoFnG/LjXLqL3liB66pq7K7+QCbYxqYeQxWzva0h+b0EHjRbtXeJdjR9wb/XC8ISXa0+SBg4Izm/dX8BCPkm9a96HQMg7IQhHq9bkfAPhwY8YoP3T4cDx7ayB4RIOIxnfbexqSDv6NtikyVE6Nr+9duJHTrSpRMsB7KVsobsPrFY8BToS11C02zEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ccVaAbNoDzT3PDnX15GWyJdkpvb9ChZOySArZobL5pY=; b=uleiPKAIJvQhzEH51SiiGkOKvGwSELn6D7nRQ9CCD0VnznoAgXMhBwgFl5AHV0CIEjTJt6z5A3aer9+hBOf4vc6JjCk6EHkUyQcEA1wffN910+82DhrV2MG+PTjqZcFxh2bHzMVqxJ+WfqracXALtAKuvC77oOAy3+w8hOItEAzxIMN20RSiQLG7ioRR4jSqSkHl+zpP+j0TCYdsfmW5mseq5MJDuuiogsm+qP0GEMvNK5lqucotzmrmnfhvzMxHcYQcAYn4ueidfwa+96mXnUHCJTSPuRr9A8WcxERLKVmcgpdQ1Lr+19ZCE5uG6w881pQwLoNahH49i/elBOgL1Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <46233ea3-9bce-b23f-3e6c-887b2c21ee71@suse.com> Date: Thu, 5 Jan 2023 17:00:25 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: [PATCH 04/11] x86/shadow: rename hash_domain_foreach() Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Tim Deegan , George Dunlap References: <074dc3bb-6057-4f61-d516-d0fe3551165c@suse.com> In-Reply-To: <074dc3bb-6057-4f61-d516-d0fe3551165c@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0047.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB8046:EE_ X-MS-Office365-Filtering-Correlation-Id: d2f29f5c-f0f0-4bd8-8ee4-08daef35f633 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oVbbK8g/mC5+HMlDJhWTg9A8eqdUUCE2nqSxOCWajgyL7w6Y5i/r9tnK0rmkLutZADeYLKt7rYUGVXDiC533QhzA1U2mO8xLAabf/w28n+zj9cKmVPj6b/4htYwOgkUFwaxG5V/FuV8XWa8d4fOv2St6aqvV93EJfqwJZKcayJ82vaS6Rn1JespxPHfHDlBZN0ox8+r2B9u9ANVuuTsrNNbL0h1Dib/SBFFDsVz4fRuV82sDf416kJZPyN05ADT6rjedAu38ViyDeAWlG+ItxJuQZ1E3IGtoujgb3vrFJyJ9TX5crEViDFfVcgNzDDsDYKS6ssvtbYovR6dBaHYTFAaAiSUMjxzmdoFY7Gy1FWbCWnkpmaJotZlpkV5WuURfuKesESKkwTe7878KjRsWxMMO9ZXNHH9/6BmwhiFTJVWPRdQrJqb9Ga3+/8fBjR8wMXLDhQkV3Gdf/VBudCQDx3bEz3LKj952QsLBejEWOyK+7w0pqL/sWsJ+pf7AD29gE5seFExlVf+IXG/Dc6lbX9qESQy2uqDh6ev2dOJbYVmM1Z+ewyY13Oj47zenVB8DGKgQOfxAEpcH2YZbiumBxgp/AOaaVjJUiMjFmhf/w74Jbq1OvQoloc7/YpBh0EPA9s7HiKgwco9qcczG24vIhNMZN5DEzs4kTXkeAs4RhmdkcrkCUG/YYuQrNGWSHyRCUyBDI/IYPvWi9YamLbVwZF6gVZ4rSKQe70Tht7GVobo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(376002)(396003)(346002)(366004)(39860400002)(451199015)(38100700002)(6506007)(316002)(83380400001)(31696002)(4326008)(86362001)(66476007)(66946007)(5660300002)(8676002)(2906002)(66556008)(41300700001)(8936002)(6512007)(26005)(186003)(2616005)(6916009)(54906003)(478600001)(6486002)(31686004)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WUFhL0dZWWFwbXMvMzVRTHlVaGg5SGIyMmcvc0dJcWFqTzNpaExmN2RsNG9K?= =?utf-8?B?RER2TlFyTlpZeWlWWjZ3aEd6dC9nYXdWb0JmNVduQzNqK005eEk4cCtPdGxh?= =?utf-8?B?MDhaMUZVZlA4L20vb29rSEZOWDR4NDllZWJic2g2cmtGeTUvSm53b2lCVDlq?= =?utf-8?B?c2prOUdDU0dCNHNFNlU0R295ZXdQU1pTMWVTUDN4Q0JIa2hEcjNKU1NwZFVu?= =?utf-8?B?c0NrQVg3WEU3Nk5wWStwekNHMm5rWE9nUEp5UTJFRGQrZGU4WE9hQ0xBN3Mw?= =?utf-8?B?R1FZbi9ieWZ3QkFjVnRwdVozVmxIUDlMYTFWSHBZZFExRTlUTFkxTVYxRlRZ?= =?utf-8?B?Z3NVRTJhdWNYUk5CUzRsOFUrdUcxdk9VYTFQYjg1S0txcWthMnZUZ0ttR1Z2?= =?utf-8?B?UGNPekR6T1hvelBabnRWVHc4ZVhGcjY4enpwc2R3QWZ3ZWthT2dTNDVZVklj?= =?utf-8?B?WlJ6V1Q2WDZYSzBwSC9BRzdVYjJ2VkwwT24zSXRRbHZYRDJhZ0x0V041VUpX?= =?utf-8?B?Tm5ia0UvS01pTTNydTJTbDNUVVI5ZkJycitNeld5MzVCalhIeXg5LzhPRnV0?= =?utf-8?B?bDRHdEpIQlZCK3Z3MFAwUmV0MmROYlE2WW5TRENZZmw2aE9UbHVpTnZtNTI2?= =?utf-8?B?S3ZET1ZXeTlsUGxkeDc0LzlCU3NjQ2xwZDY2R3JhZzg1NnBjQVlIeDEvTXAr?= =?utf-8?B?enNMRjF4VHlhaUtueE5QY0FyUVpndGlIUmRXTHNsZTB4YjlWTXRNZGtaUW84?= =?utf-8?B?R3RRTzlVd0dxM2FjK2d1dmRwRmNpdGNqd21IZlJ0T283KzdrTmptakRXWkYy?= =?utf-8?B?blFBQjArVUkrUWgxczU4WVdITDhDVCtSa0dpSHRrRGF6R0FmVkVZWnFaZDMz?= =?utf-8?B?bVhSNFBRYXludDA4bWZaajJDZ2FHNUE2Q1NiL0N0MUpQeitwNUs0YngvRk03?= =?utf-8?B?RTg2alBudnlhR0lNUzlSaTJZWERGTThjY3dnZFQ2SjhraitsL21ISkZsSHhY?= =?utf-8?B?MWtnY3g4ZHVUK2FyZ3ZQTlpEZmNEWjhFQ2dVOVk0ZXhDWTdVbjV5N3pjYThJ?= =?utf-8?B?Vm9qTyt1M3JhbGUrKzZHZzUxMVBWK2NaV3V4Ymxxc2I2eVVPbjdKZmJ2dlZU?= =?utf-8?B?NFUzd25RMVV2YXJzbnlLR3J4QlpicDRyd3luRUNMek1YTmpjUUc2NG85QXMz?= =?utf-8?B?cXR0MXRPVEt4WE5nNE1sS2lZam9FVEZCeVk5ajloYlNwc3JhbUg4bnJ2d3Mr?= =?utf-8?B?SVRHZzBuMHVIVEtpT2w3bGEvYlpnQm42cnpGOVFjQ3RaU3pwNWFaWkRqUTRk?= =?utf-8?B?MTdMbHVDN3pFaVBLQXIxeEF4TUVTSjJ1Zkd5aHVRdDFMSkY2SEVEL05ZZ0p6?= =?utf-8?B?SS9tNFlFS3FvVEdSTUdNckhDUnYvazBBQWRjZE5UMjhoNWkzUHUzWnFEM3J0?= =?utf-8?B?VysvQml3YWhYVXJiaFJRTnFWSkNyWWp3Z0N5Y2pwTW4rZzdtSUFCem53d3pJ?= =?utf-8?B?c0tod1Qrei9DNTZYSHB4STc0ZEVzN2tqRmcwQk9DbnA5VWg1UGFaS2lNaytB?= =?utf-8?B?NVd4ZHkxZlVzTjQvbzBuQkRqbjU3dWdqdm5jam1wTW96alc5L3JRdVoyS1lD?= =?utf-8?B?NnBaSWM3aXpLdDlmKzRab1FTZlo5cE5BMVkvazBYdEc3UjZLWVRJNHRqcjI4?= =?utf-8?B?cU9oVU1yL3prVkpZSjFMbnBqTDg0YTZDdUhLL3BZdXNha3ZrQ3VGTlEvdlNt?= =?utf-8?B?STRKc2RTM2Y0R0VGWmVvZk0wNWx6SE9OWGhkMmgrY2kwWHR4c2h5aGFyZENC?= =?utf-8?B?ZS85ZzliLytHcnVBOE42NTZlRU44NFF6clhWeUo3Mk5oZUNIU2p0cDZmTElO?= =?utf-8?B?a2hZd3gxbTVHOEI3VTJ0SVdaMW5JQnp6anJmS1Y2MURhckR1SG1xVmZqWVdZ?= =?utf-8?B?SURXMmpEanUrc0UyRjl2NHJteStMeUpoRzlvOVlMWW9RRFNYWTQ3V0VyaUg4?= =?utf-8?B?RFk2VHlOdEVTeFpqcm9TcWNtUVE5eXlHVG9YTmVIb1pxTHhwS0x1bEVIUGd4?= =?utf-8?B?K0d6QSthcFIvRkQvWDh3ckF2djQ5bHFqTDdvaXZhVjRyK2l3RHo0RDBMc2xE?= =?utf-8?Q?SbGAA+/PE/ZQFLQYh4kZN6S+6?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d2f29f5c-f0f0-4bd8-8ee4-08daef35f633 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2023 16:00:27.1413 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +l6KEO+gl/jpLOR3lQpqLK0F4Xt1P139pvE6qzAXAjshO2TnaAlMetrMwu3MQEf3oheEFvV/Pxw8I/sh/L1Cbw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB8046 The "domain" in there has become meaningless; drop it. Signed-off-by: Jan Beulich --- a/xen/arch/x86/mm/shadow/common.c +++ b/xen/arch/x86/mm/shadow/common.c @@ -1640,15 +1640,15 @@ bool shadow_hash_delete(struct domain *d return true; } -typedef int (*hash_domain_callback_t)(struct domain *d, mfn_t smfn, mfn_t other_mfn); +typedef int (*hash_callback_t)(struct domain *d, mfn_t smfn, mfn_t other_mfn); #define HASH_CALLBACKS_CHECK(mask) \ BUILD_BUG_ON((mask) > (1U << ARRAY_SIZE(callbacks)) - 1) -static void hash_domain_foreach(struct domain *d, - unsigned int callback_mask, - const hash_domain_callback_t callbacks[], - mfn_t callback_mfn) +static void hash_foreach(struct domain *d, + unsigned int callback_mask, + const hash_callback_t callbacks[], + mfn_t callback_mfn) /* Walk the hash table looking at the types of the entries and * calling the appropriate callback function for each entry. * The mask determines which shadow types we call back for, and the array @@ -1784,7 +1784,7 @@ int sh_remove_write_access(struct domain unsigned long fault_addr) { /* Dispatch table for getting per-type functions */ - static const hash_domain_callback_t callbacks[SH_type_unused] = { + static const hash_callback_t callbacks[SH_type_unused] = { #ifdef CONFIG_HVM [SH_type_l1_32_shadow] = SHADOW_INTERNAL_NAME(sh_rm_write_access_from_l1, 2), [SH_type_fl1_32_shadow] = SHADOW_INTERNAL_NAME(sh_rm_write_access_from_l1, 2), @@ -1969,7 +1969,7 @@ int sh_remove_write_access(struct domain else perfc_incr(shadow_writeable_bf); HASH_CALLBACKS_CHECK(SHF_L1_ANY | SHF_FL1_ANY); - hash_domain_foreach(d, SHF_L1_ANY | SHF_FL1_ANY, callbacks, gmfn); + hash_foreach(d, SHF_L1_ANY | SHF_FL1_ANY, callbacks, gmfn); /* If that didn't catch the mapping, then there's some non-pagetable * mapping -- ioreq page, grant mapping, &c. */ @@ -1998,7 +1998,7 @@ int sh_remove_all_mappings(struct domain struct page_info *page = mfn_to_page(gmfn); /* Dispatch table for getting per-type functions */ - static const hash_domain_callback_t callbacks[SH_type_unused] = { + static const hash_callback_t callbacks[SH_type_unused] = { #ifdef CONFIG_HVM [SH_type_l1_32_shadow] = SHADOW_INTERNAL_NAME(sh_rm_mappings_from_l1, 2), [SH_type_fl1_32_shadow] = SHADOW_INTERNAL_NAME(sh_rm_mappings_from_l1, 2), @@ -2024,7 +2024,7 @@ int sh_remove_all_mappings(struct domain /* Brute-force search of all the shadows, by walking the hash */ perfc_incr(shadow_mappings_bf); HASH_CALLBACKS_CHECK(SHF_L1_ANY | SHF_FL1_ANY); - hash_domain_foreach(d, SHF_L1_ANY | SHF_FL1_ANY, callbacks, gmfn); + hash_foreach(d, SHF_L1_ANY | SHF_FL1_ANY, callbacks, gmfn); /* If that didn't catch the mapping, something is very wrong */ if ( !sh_check_page_has_no_refs(page) ) @@ -2132,7 +2132,7 @@ void sh_remove_shadows(struct domain *d, /* Dispatch table for getting per-type functions: each level must * be called with the function to remove a lower-level shadow. */ - static const hash_domain_callback_t callbacks[SH_type_unused] = { + static const hash_callback_t callbacks[SH_type_unused] = { #ifdef CONFIG_HVM [SH_type_l2_32_shadow] = SHADOW_INTERNAL_NAME(sh_remove_l1_shadow, 2), [SH_type_l2_pae_shadow] = SHADOW_INTERNAL_NAME(sh_remove_l1_shadow, 3), @@ -2177,9 +2177,9 @@ void sh_remove_shadows(struct domain *d, /* * Lower-level shadows need to be excised from upper-level shadows. This - * call to hash_domain_foreach() looks dangerous but is in fact OK: each - * call will remove at most one shadow, and terminate immediately when - * it does remove it, so we never walk the hash after doing a deletion. + * call to hash_foreach() looks dangerous but is in fact OK: each call + * will remove at most one shadow, and terminate immediately when it does + * remove it, so we never walk the hash after doing a deletion. */ #define DO_UNSHADOW(_type) do { \ t = (_type); \ @@ -2203,7 +2203,7 @@ void sh_remove_shadows(struct domain *d, (pg->shadow_flags & (1 << t)) ) \ { \ HASH_CALLBACKS_CHECK(SHF_page_type_mask); \ - hash_domain_foreach(d, masks[t], callbacks, smfn); \ + hash_foreach(d, masks[t], callbacks, smfn); \ } \ } while (0) @@ -3167,7 +3167,7 @@ int shadow_domctl(struct domain *d, void shadow_audit_tables(struct vcpu *v) { /* Dispatch table for getting per-type functions */ - static const hash_domain_callback_t callbacks[SH_type_unused] = { + static const hash_callback_t callbacks[SH_type_unused] = { #if SHADOW_AUDIT & (SHADOW_AUDIT_ENTRIES | SHADOW_AUDIT_ENTRIES_FULL) # ifdef CONFIG_HVM [SH_type_l1_32_shadow] = SHADOW_INTERNAL_NAME(sh_audit_l1_table, 2), @@ -3214,7 +3214,7 @@ void shadow_audit_tables(struct vcpu *v) HASH_CALLBACKS_CHECK(SHADOW_AUDIT & (SHADOW_AUDIT_ENTRIES | SHADOW_AUDIT_ENTRIES_FULL) ? SHF_page_type_mask : 0); - hash_domain_foreach(v->domain, mask, callbacks, INVALID_MFN); + hash_foreach(v->domain, mask, callbacks, INVALID_MFN); } #ifdef CONFIG_PV From xen-devel-bounces@lists.xenproject.org Thu Jan 05 16:04:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 16:04:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472013.732096 (Exim 4.92) (envelope-from ) id 1pDSj0-0003hg-96; Thu, 05 Jan 2023 16:04:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472013.732096; Thu, 05 Jan 2023 16:04:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDSj0-0003hZ-64; Thu, 05 Jan 2023 16:04:14 +0000 Received: by outflank-mailman (input) for mailman id 472013; Thu, 05 Jan 2023 16:04:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDSiy-0003hT-GS for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 16:04:12 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2085.outbound.protection.outlook.com [40.107.241.85]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 97d2e2b6-8d12-11ed-91b6-6bf2151ebd3b; Thu, 05 Jan 2023 17:04:11 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB8046.eurprd04.prod.outlook.com (2603:10a6:102:ba::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 16:04:10 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 16:04:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 97d2e2b6-8d12-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Xr++NsNdGlT6TtWx6/n2fQDVYMbGG7WnSMBPz5KHSmGDF9QPtDETIPnA+CjBMH4oPBWT2bwfWX4suSbXeGIypOwZCQRpTh1AompNiWRAlvR3hIiY0nJ6hTmozX01k/WZA6eOtK75QCrBTeKQR+G1WaHokMXzv0nXtNRfUHLzLajaYJfDUasD8xfrsGU7MFRG3/BJ9VBHUTxL2ixjbZZ2EnZb7G1bYkJODXyMMoBjDClEwluN71Ga3FRwXt5oxS0IRdnWM/ugNIysCEu5Rdy/khqVLzO7lWhksIzdRGFzZ/+e/VN1Gehli+018mZsv3P2TtkPaY38eJzZbIkw8YXx4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tiwgHbCRXYI+56kwUcOCgcEtwg3HWt+T1yYbvqBjdYM=; b=LcDpJmTakRzhrmgRdUK6CYYQUe0Rpt+3dW/0+TdMvxGSu5wItFqSnWTvbFLKR4YBDH+/JywaQUpwL9yhMcnLvWM/D5C0zA2YEDGLw5fY/zeBJaEVxpNejZnxLn4w6Jb601ayQPlXmww48lJ/pgMbM5mRfQSt5gOHzYXyaObjKhmGfZjdUFATmi4zgh1eQ/oWwBXca9YnX/MtE58FQs8z5x4RM+1kLU9rpQ2nKQ0Ud1rVQICgmbyBefN9mQX5W96KKsYtEVKVaFnXZDiRS3JYnAZXMz3oHl1/RxrogIen7ZkcMsa3CECnCh0Qr6OJ7nX81OaF8klNdkZfUL2ewxuwag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tiwgHbCRXYI+56kwUcOCgcEtwg3HWt+T1yYbvqBjdYM=; b=NAkNqr3ZTsQ6QsEjVhcI8ueY+7QrN4VUuvFkAFkIBTqeEiP8EK3GFw+kTVoxokZpp3tcgyQ50rlfowHZT2mHmtJ8bO7cwH0+ZvuRqrS/xNDtOH1pKNpb5As/6l6bz9hxEvnMpGV1XSQAr78B20FqnpeYx9qqTgpMjjxd3sx2wYsWM7tt7XicuathzWeoFk3oyXJWGEYNilzhN7Lp5fiK6nVattSg4Ms4s2y7LgUMitJsfCqLLjh17w6MDqRdI+R/7eEFeh1uVpTEcYZEbkqzXPXorlJbcP7cEdugdfQdxDp6vfhcavgfjh4WiZC5HA4/cdAoh38HmJwfxWfWYyMTpw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <76cc0b4a-27ca-21b7-841f-315f31833762@suse.com> Date: Thu, 5 Jan 2023 17:04:08 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: [PATCH 05/11] x86/shadow: move bogus HVM checks in sh_pagetable_dying() Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Tim Deegan , George Dunlap References: <074dc3bb-6057-4f61-d516-d0fe3551165c@suse.com> In-Reply-To: <074dc3bb-6057-4f61-d516-d0fe3551165c@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FRYP281CA0003.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB8046:EE_ X-MS-Office365-Filtering-Correlation-Id: 2ad15354-d748-4b28-5a12-08daef367af6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oYfdVss4Qr69VnO87usxY+HEyw1UMO6LfKX7cL5QHL01Mt22PQlDL5/zr1VOP8m1OrKHXDzroJIOagvtHhs5VJshZ9zWSssQg8wJwZGSQftieXSqaXPiyqP5iFbKoxFKDMnugdqNysq0ufCb6z23gJhGZQ/ACGXSCmvnosYxC7LHTT/v5eVGacB0fGH7hQU7mZscidMDPnLVNxMjPp1o5TXjuAH9zYz0ZiwZdUxYaQLj3jpAH55VHpviJqWUZ/Pvd+ZWyAFsCa5XOtvNj7ZeQfA5VCJfF5BGJ0J3lOzwMAyY+IHhW9v1FhSvh9MZRZMajp4UAdrdhnIp0EszcdOAZiAc7pB0ZeLiOp5Y+1Bp2ucVv6AU3Y+AYW0pOmDOuga94WxnnOMxxbYsE9g6CJEQYswex1lqIg2icEE27CQR2kyYAW+IDv5Qt++uedbM21KfOkcyVUIub6qjbAf6/ddZtYqD/nDB1qxHZR65Xkh3AgeLR0WZ+RsGO1F+Kd5LdEsWzQGtNBiE+u3g6pgdgyaVm3Ahl8R0oa9oVXrKnNyiOXXU8haTqfJoTwyceF3PXyReiWQPWt4FHhhCSxSxdJRkIZlCj8JqvqSKR/QqG0C6JP4QOKuYcEYlHv7QoxVk6QXiFJcli4eT3ZWzLZ5clpiVFL6G5oUFms8D7bmZJej8ORwu7IjmR7IKs3QBUTKBi+E+qF1RSt3RQ6vhA1UH/prX8PXLBvvwziV9e+3XaIN3KlU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(376002)(396003)(346002)(366004)(39860400002)(451199015)(38100700002)(6506007)(316002)(83380400001)(31696002)(4326008)(86362001)(66476007)(66946007)(5660300002)(8676002)(2906002)(66556008)(41300700001)(8936002)(6512007)(26005)(186003)(2616005)(6916009)(54906003)(478600001)(6486002)(31686004)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RnFhWjJXUGdxZlNaaUlpcldMNkoxeDlveWwzRmgvaCtHTUwxUStzMHZISmRX?= =?utf-8?B?d0JabDZKaU5sZldrOW9Bck9aVTR1UHZ1Z3RuZG0xM0FrVGdoeDdsalZJb3Fm?= =?utf-8?B?WFpLaThBVTdMbVBMTTF0Q1hwMnRzSkhQR0NGbGordmNVbWQxQ0xRN1VRSUFw?= =?utf-8?B?Nm9ZQnR1bVJza1k5RWJNQXdhQklhMDVOZ25sREpEU29zaDhNZTcyNytKUU94?= =?utf-8?B?WVp4NjM1aEZPRlAwQ1QraStXOFdRVEsvUmFtOWt4eXk3aFdoMGg1SllxbUE5?= =?utf-8?B?aG5yb3RlM293bFpPc3o2WENPVVJNT2d1YTdxS2Y1YWd6bHhPbjFVNENlMlNX?= =?utf-8?B?UktJVEI5WUcwb0x2ZGRISFZiMXozQy9zbC9LSWFsWmhXQ29PS1M1UUFjUFY4?= =?utf-8?B?TzZIM3JVbG9qV2YwU3FXOStZS2s4M2tMdStmYlh3VDUzNnFsWWFJY0txYXlk?= =?utf-8?B?VWZobVdUbkJTRUdUNE02UDlHaDR4Z2ViWUZpbVpYNndTRFVkN08vYjVtYlBl?= =?utf-8?B?anJPdnh5LzYxdHRVU2VNbzFQdE4yR3RZNnlVMFZtdnNqTXhhM1lCd21LTnNM?= =?utf-8?B?bUozelNDNEFzWUlaQlNuU1lTaVptNnp3aUljNWsxZ0xpVVdxdm9ZdC81R3lC?= =?utf-8?B?YnpvMzYyZHpBbTV0bFUxR2lvYmYybHMwbmhyTkJud2tUTG8ybUpyM1pLeGcz?= =?utf-8?B?eG52QWlaTk9kYVRsRTI5L2JyaGhKL3FNZUMySDA1SE0weURNYUdNTDdqeHV3?= =?utf-8?B?VVVSSEQwKytISWt2djdNQzNnV1doaUdQRThlOGRBTjdRK1l5TGdVMlpNYk5W?= =?utf-8?B?WEVuMU9wQzlkRDJvMU1WNnloQkdpNmVpVWM4WG1UbmVPK1AxYzVCQS9PVGw4?= =?utf-8?B?MEJndjhqTWFSYTN2cWhCdEFnNFRUcU1HZURmVlVmSGN0TWZISCtJK2g3Ukhz?= =?utf-8?B?TmtTKy9vNjR2UWVaSld0SVUzc2QvUXJTV3JTWkhCaWNEa2hzVkw3UTFCYllD?= =?utf-8?B?NHB0elJHbmEwd1Z1bjlodGpZbDNodko5MG1iM2tGSUt5bk95YlVuZmx4bzZJ?= =?utf-8?B?ZzV4cW9HbHgvMVBlSnIxVmdnSjI3K3FLUG5qTEhDa1IzZGJUT01qaFA0bjM4?= =?utf-8?B?YzZlM25DUGRwS2ROL29VOGkwc1BrMTk5Sjc5WnExSkFCOEpjVEFiUkF0ZXE1?= =?utf-8?B?NFRRM0FCUDhLQkZ5RFJpbXJvdHJEdm5VdUh3V3czU240REM0OXV1ZU11SWg1?= =?utf-8?B?TVpoSEEvMTc0bGhOWjdJTXdPemRENkxJMFg1azhxRDhTdWxycktuMVNJSEdZ?= =?utf-8?B?T3ViTGxJTXVFWVQya0pSdDRRSGl0bmw2Y2pzYklaSmc3dUt3bU93a0I1ZmFt?= =?utf-8?B?Ry9JT0d1eWlpSExkbnc5eHVjWjkwL0QrdjFOc2x2QXVrME9NeWs1a0Vjb2d1?= =?utf-8?B?RE1HallIbjU1RXB3SHVRWVNNRkhZQTlpQUEvNjlQbHBnblpMeEU5cEZKRUwr?= =?utf-8?B?ZnpFMldiazBDeGxzKzlIRnpBdnhzVytmSGxhblQxYUdLSWErelBJYXJWaFFM?= =?utf-8?B?azZldVY1bkxCZlZxdkU3aHpYRWt1bENYWjJhczY3UFR5MEtFVDlxZkZGOWdy?= =?utf-8?B?ZEladDYvRXBodXRrT1huNFd1MTNEYzU5aUkwYUM1dGxsUmJxdVRwK0JBSk5n?= =?utf-8?B?cHg3MUY4SGRVMkdkaDlZQThtKzFXbVhBL2FIaC9qcnl4RFBaS3ZOMUlzeEp5?= =?utf-8?B?dm9HTG9VMlNlQXFWU3d2V0hBTVh3YzgraFAxRUJUMnpodWpPcVNBVGd1M25U?= =?utf-8?B?aGRiOUlpdlNCamhlVDBrY3R6UVp2K2d1bFd2UTBrcC8vRlhlRUNhTytVNlYv?= =?utf-8?B?T0l6N0hrTks4NzhJSDVOaFJMQnhqd09NL2lVM3JxSjZHeXRvQjA0L01iZnpz?= =?utf-8?B?MVNvZGMxQ0NjODJvQ3dZUlZzaldiNWs0VTZSYW9WL1JIeERPMWs4S1dvR2FW?= =?utf-8?B?V1hZTFMybGx1WmxLT0t4Ti8vNk5FVGlHY04zaUs0MFlGN3NZc1Rtemc0MVJP?= =?utf-8?B?QlBCTXdncnJHb3NLbWk0dzZQNG4zdE1yR3BjL0FlR3FreWo5ektUaWRCSEVh?= =?utf-8?Q?Yg4FF3Svc/nM8Gbgn54ejbmmZ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2ad15354-d748-4b28-5a12-08daef367af6 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2023 16:04:09.9084 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vTjYqBoyreX/HEhw3Arn7DPnliwAhjDiE6xN38Kxx3c/YlAgml3JHhNnV0QlXADvtvFKRxHymfFrEBeHvvuoPA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB8046 Perhaps these should have been dropped right in 2fb2dee1ac62 ("x86/mm: pagetable_dying() is HVM-only"). Convert both to assertions, noting that in particular the one in the 3-level variant of the function comes too late anyway - first thing there we access the HVM part of a union. Signed-off-by: Jan Beulich --- a/xen/arch/x86/mm/shadow/multi.c +++ b/xen/arch/x86/mm/shadow/multi.c @@ -3780,6 +3780,8 @@ static void cf_check sh_pagetable_dying( unsigned long l3gfn; mfn_t l3mfn; + ASSERT(is_hvm_domain(d)); + gcr3 = v->arch.hvm.guest_cr[3]; /* fast path: the pagetable belongs to the current context */ if ( gcr3 == gpa ) @@ -3822,7 +3824,7 @@ static void cf_check sh_pagetable_dying( : shadow_hash_lookup(d, mfn_x(gmfn), SH_type_l2_pae_shadow); } - if ( mfn_valid(smfn) && is_hvm_domain(d) ) + if ( mfn_valid(smfn) ) { gmfn = _mfn(mfn_to_page(smfn)->v.sh.back); mfn_to_page(gmfn)->pagetable_dying = true; @@ -3854,6 +3856,8 @@ static void cf_check sh_pagetable_dying( mfn_t smfn, gmfn; p2m_type_t p2mt; + ASSERT(is_hvm_domain(d)); + gmfn = get_gfn_query(d, _gfn(gpa >> PAGE_SHIFT), &p2mt); paging_lock(d); @@ -3863,7 +3867,7 @@ static void cf_check sh_pagetable_dying( smfn = shadow_hash_lookup(d, mfn_x(gmfn), SH_type_l4_64_shadow); #endif - if ( mfn_valid(smfn) && is_hvm_domain(d) ) + if ( mfn_valid(smfn) ) { mfn_to_page(gmfn)->pagetable_dying = true; shadow_unhook_mappings(d, smfn, 1/* user pages only */); From xen-devel-bounces@lists.xenproject.org Thu Jan 05 16:04:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 16:04:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472017.732106 (Exim 4.92) (envelope-from ) id 1pDSjS-00048a-HN; Thu, 05 Jan 2023 16:04:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472017.732106; Thu, 05 Jan 2023 16:04:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDSjS-00048T-EU; Thu, 05 Jan 2023 16:04:42 +0000 Received: by outflank-mailman (input) for mailman id 472017; Thu, 05 Jan 2023 16:04:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDSjQ-0003hT-Bx for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 16:04:40 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2059.outbound.protection.outlook.com [40.107.241.59]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a844ed62-8d12-11ed-91b6-6bf2151ebd3b; Thu, 05 Jan 2023 17:04:39 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB8046.eurprd04.prod.outlook.com (2603:10a6:102:ba::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 16:04:38 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 16:04:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a844ed62-8d12-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XmgGKirqO97aW2lzSqCXpaIMGF3eF+gzlXSdDILsRUTRy53Ts+dmTcDoA2bJ/bAnU3z2nlZx2jmznhmU7AK84CybI9T70vXkmie0xgGRut+p6DfJhXVCyNYQYEVyKncF4fIt8u+2ttL2Rt1EihkvWd3GGx9kPusq43eeLKp0iGlEQieUBy6eMtNNcrfy9F/eH/fsGSm0nMo2FGTGENBE2b+OxRjzPauOtWUvDUv2nwbiGW1lw5CAZxcSjIlBYvw/AlMKs0j9DkWWvutTSqko6nE4ozkU8m34mOZ+zTvaq8EjkGeY+cj1tUDHxFx5fGGOifCFF8EsRMH7JJjjEMw3hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MJaoeutQLbYPzxfYQUitLAuxg6Tn53bDvw1b7Tq+keI=; b=PMQyKOvRZKzmstJbOfx7xQT76V22aS/cbEfpwt/kZXbC5BmTLEYAc79ZZqUOjWrv949KUVYamDLCZibCj39TvC/WNHS2UOf5dE6NrJxRuUzculrwq5V0Pa1RirGIo/zvLa6v+m16Xf0LFGFQZjeI9ZoxpvgmBoNCvv10TGr6RbyXKidJPEm0lfvI6ZBP/CHf4z/x5qW8/33ABw7evNPnq/beGfRsRt5ax0Fvmm669kJQ63QRXyebQj9Y1+2PiZK1ZnhktMBwc+n3Q1wtJ70myb1H5bsoe7PzSS8m85hWVaP3t+VtN2WMxP6B+ovqZ8DcmC3JIhL1V5wcoe+VwiV/Tg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MJaoeutQLbYPzxfYQUitLAuxg6Tn53bDvw1b7Tq+keI=; b=Q8YlPobdSJaKnb4lppkjZ0CgQtxuyIXFDSEXkUhMrUEhDLLZALOxc29Ls+Wyt7uyBEdo6xMI6/C+77pbJHzMLDb6O62IYm3YgHWrplzBI+YnAXef5+bCGgAuRWsuFI65PsoCw/jGZC9Bm/ORLYAVCiQCMUwBwGdJViIYwAgkvuprRDgbe176GqqoXkFyfZZnsS1YVgkJ5LV7t4DU7ndRgY7mGY1ANrRq9H1xZsAJkVM3UO6rBaWRhrh3TBKC7WhhWlgm5IsK+omMpMVUVqINWG9z68+PpmEgOnb2hUg+4OaVDpHDsfmXXYPEUxxxuJBB+4Aaff8VLOwUgldlwb8Xjg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 5 Jan 2023 17:04:36 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: [PATCH 06/11] x86/shadow: drop a few uses of mfn_valid() Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Tim Deegan , George Dunlap References: <074dc3bb-6057-4f61-d516-d0fe3551165c@suse.com> In-Reply-To: <074dc3bb-6057-4f61-d516-d0fe3551165c@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FRYP281CA0002.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB8046:EE_ X-MS-Office365-Filtering-Correlation-Id: 15b6a024-c967-437e-adc4-08daef368beb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XbhDPUSuADkRhwC6IzYXEToveZgcb20lXMisLZ+GMM3jSAMmAniv17a7NvzsDci67mEPC+Zzq5fi47TEnsLI3RWN2RHqlXBAEWYUITFOOldngtRs5IfrJ/IemNBFosSmXyimqXnN7HOnePDVVU7GFovd9Dgi0l1ZtG2LeSc5QD+j/6AcvV+3MqbTMrHs06dEduNxprJcZQ542I/L3MRu5WOlEkyPYA/AzYZIouvSgV0ILSvi6QjsfFlSJDhXx4vlOMOqsZsuDkMHQ4AIYYRtMkihj18fKgrvLP240VyRwhXnE45g5oL+Jgvfnrlbg4kTSauyLo/zeMQcPFw88V0G8fE2j72r4OdNbSsMIr5L5JP7IvkzTFDHNMg77cG5FWKIJ2bha14z3QtGKUup7zj8ZpBCERjqCXeFE0sXp6A/10J+Jo8bJ0AwICNUnP+WFcJQysYpxL71uLY2wIUU7VWjFhAbGyujcraQjdUNulTKpDcNO7274wQqr52wnNec4VxFkVw4qaBGSXduUaNjyzHb8uO/fGWMspsCFrn8i+u17kRjJzuo86muPb5nMY0UVgyZq9/lW2gwGv+yD6+kX+VP6ITn+tDDQr46au/SUqgRsbpJyfG1BEJIgeWkUcs1pG95UHkfl/S+3wJtRXNALCxZKzwtAqBRpbU9OsDr2r997pmYHyXqf/IX484ATxnq8nSkAhRaPH7SyRr27BQvT4RLov5L9ocdKSGepiaGwyeYN20= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(376002)(396003)(346002)(366004)(39860400002)(451199015)(38100700002)(6506007)(316002)(31696002)(4326008)(86362001)(66476007)(66946007)(5660300002)(8676002)(2906002)(66556008)(41300700001)(8936002)(6512007)(26005)(186003)(2616005)(6916009)(54906003)(478600001)(6486002)(31686004)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YjhjUlVUSDB0dW9LVE1FTUlwYm1TNm91Z1RLa3JWRmkxRm5YYUNqWWNxdWxv?= =?utf-8?B?VmoxMWwxeUMyUkVnUm01YVV4MEdaUW9TV0M3S2xSOGtqZ05ncDhOdmhkMTFm?= =?utf-8?B?dm1GelpCVENjeWlSUitWeHZUWExhR2phWldqRm03VkZLTHNkUEFUYTRjRzNI?= =?utf-8?B?WmxDY0haS1d0T3BsYzlQSElCcGJVY00reXhFMC9YK3QybnlrQURIR3VoMXN4?= =?utf-8?B?WkJRU21FTWMxRkVFZGZCUUlpNmUyZldXemVzTC9zMGdZT0dhMzVBWjdON3F5?= =?utf-8?B?UExvRXd1YUcxejRjS1pmVXVseVlzQ1NiRUJSdU12c2lpL2RLU1JGWU05cVdk?= =?utf-8?B?Q290d2xPUUVYemo4VThnNWNUeVQyU2FJcmpqWHY5L01sbTZxcEZnOFAvNVRp?= =?utf-8?B?R09IVWRKa09Pb25RUWlGV1pSNkRNdmQ2Qkd1RTFDOVdCczR0S2YwSzFoVFRj?= =?utf-8?B?eWJBck1ZV3FvNFVxMCt0cFJMdmVYdC9NVG5XMmp5S0lKMTR5QVB6djJyMVpN?= =?utf-8?B?ankzUEhGemZlTk1ydldWWGRNVFpIMlBHOU8zVGFDdzRYRG1SeUp3OHlHRVBZ?= =?utf-8?B?ZFBvQk9lSDQ1RWNUaDhGNzMyTnB1VlZsVm94dHQrcHpXemFZUGo4VHEyOFRR?= =?utf-8?B?M1Q0bnRhdHEvUVRDaFgvMk93ODh4WmMxM0g2YXhsdWp4ajJKZTErVk1JRTNH?= =?utf-8?B?L1IxSDI3VkxkdjJtTThqWkZqaGlaS3FIamI4UGc5emQ5R3IzdEcyTnpJUno0?= =?utf-8?B?WDJmai95RDlBd3cvVGduOUlJU1pWTUErR2VHYVZXb3BhVGJBWTZSWlFCV1dk?= =?utf-8?B?MFV0NkpsUlg3bnhjTm8vSkFmbE5Rd0M3bUw2bVNOa3dTdTVHUjhnS2IyaVQ4?= =?utf-8?B?c29TN0psT0E4eHpzYkZhcWl2WnFDd1pON291OVlSaTl1SkdjMEMzaVR2LzBJ?= =?utf-8?B?V1hHRTBjNHcvMjNhbWYzL2RBSTh2VnZNRUhpYmpWL05HQVl0V1Nxb0k5R1Rm?= =?utf-8?B?NHc4WjZoUGhnQWlnTytpYWNaKzdwQnFPVFMrb1dnaFlIYW9LSnBheHdpclRH?= =?utf-8?B?cEtxeEp3SHMzZkVtekdmdGFoNDcrVkY2aEZJYUJzTzNGZVhJSDQ4UFN2RGlS?= =?utf-8?B?ZFlVSFdJRWNwMkRkRVUreSsyRkUvbTlsYWNEUDZqbFVyUTE4VkRLUVhGYmhC?= =?utf-8?B?SE53dUZQS29vbDNrcUVYQlNQTG5yeXZiWkF2bmQ0SHlwZGcyUDRaWkFtcWVr?= =?utf-8?B?d1h5Mmx2cjljU0pSKzA0VFhtRWhMVExDV0tLeE1XVTkwdytLL3hDaThtQm9m?= =?utf-8?B?Y3BBb1pUVVVKOXN1djgzNHNDUy9IRnI3a2gwRDVnOTBqUkVoRklGTVNOeHN5?= =?utf-8?B?SmVnVlNhV0Q5Tms1K0hKQVRwL3JwQ21Lc0cwL3dTeWFxWkwvanFuMzJHbGNG?= =?utf-8?B?bGF1dUpBZlJiamFRUkFXVHE1MHdkdTZpV0x0WmRQODJSTjJacEMraTQybGhS?= =?utf-8?B?UWJsRmd6SzFtMm0yNDdtckpiODBlZzQwTjFFR01HM2hRcTZtZ1ZxZEJiQ2ZN?= =?utf-8?B?MnFvYTBBYUpqNGthVHE3aDV6cUlpTGpjQjBwY2tzMHpxMGhiZGtzRFRVRktY?= =?utf-8?B?d3FGNkZvZUM5QjZHbWdLSERlQ1N1Qnp6Z1BaUm5rdnNNUTNiUkxTcmwrQ0JX?= =?utf-8?B?Y0NrMS9rUkdaaXFXNzNndnJCSSt0T3pwQjNMamN2eU5DelRKSlhSZHUyNFB6?= =?utf-8?B?RGlwbEppZ0wvZHNHM3RrUysycFNMK3hmbldoREt2dTBkaG81NWF1dUpCMGwz?= =?utf-8?B?Wm5MazU1QkpSbHZmQk1IWUZ6d24wREI1SVoza3A2UzRDQUk2RG5wLzA3SHF0?= =?utf-8?B?eXpETWVXVGZpZ3ZBWmhCcDV0SFkzS2U1WUtqMEVZMmdGZTE1dlRPQk5jRWJh?= =?utf-8?B?c1cxVUpZY21NSzZUT3R6YnJqQlRiUkRwOUkyM1ZHRkhzT2hiTWwxOWRwT0RL?= =?utf-8?B?dG9IQWVVbHNsN1hVdWFNM0hkS2QycVpnL2V2cTB2K0lYR3ZJdG9DVFhad0tH?= =?utf-8?B?WXJ0TzlWN1ZJY2d5ZDZUWmhQRVpLem9TMVFybWF0MHJmbUE5bm9pOS91clFv?= =?utf-8?Q?gMS60a4htwmvqQ0o4mrqRwHNZ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 15b6a024-c967-437e-adc4-08daef368beb X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2023 16:04:38.2034 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1ARPHIyL5U0VA9mm0aThyC45AGojNQUrsmdoH6T6X0+YXij7vXFKOyiVmsx4gZnZ4J7lGFRveNRWRUu9+sXXUQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB8046 v->arch.paging.shadow.shadow_table[], v->arch.paging.shadow.oos[], v->arch.paging.shadow.oos_{snapshot[],fixup[].smfn[]} as well as the hash table are all only ever written with valid MFNs or INVALID_MFN. Avoid the somewhat expensive mfn_valid() when checking MFNs coming from these arrays. Signed-off-by: Jan Beulich --- There are many more uses which can likely be replaced, but I think we're better off doing this in piecemeal fashion. --- a/xen/arch/x86/mm/shadow/common.c +++ b/xen/arch/x86/mm/shadow/common.c @@ -171,7 +171,7 @@ static void sh_oos_audit(struct domain * for ( idx = 0; idx < SHADOW_OOS_PAGES; idx++ ) { mfn_t *oos = v->arch.paging.shadow.oos; - if ( !mfn_valid(oos[idx]) ) + if ( mfn_eq(oos[idx], INVALID_MFN) ) continue; expected_idx = mfn_x(oos[idx]) % SHADOW_OOS_PAGES; @@ -327,8 +327,7 @@ void oos_fixup_add(struct domain *d, mfn int i; for ( i = 0; i < SHADOW_OOS_FIXUPS; i++ ) { - if ( mfn_valid(oos_fixup[idx].smfn[i]) - && mfn_eq(oos_fixup[idx].smfn[i], smfn) + if ( mfn_eq(oos_fixup[idx].smfn[i], smfn) && (oos_fixup[idx].off[i] == off) ) return; } @@ -461,7 +460,7 @@ static void oos_hash_add(struct vcpu *v, idx = mfn_x(gmfn) % SHADOW_OOS_PAGES; oidx = idx; - if ( mfn_valid(oos[idx]) + if ( !mfn_eq(oos[idx], INVALID_MFN) && (mfn_x(oos[idx]) % SHADOW_OOS_PAGES) == idx ) { /* Punt the current occupant into the next slot */ @@ -470,8 +469,8 @@ static void oos_hash_add(struct vcpu *v, swap = 1; idx = (idx + 1) % SHADOW_OOS_PAGES; } - if ( mfn_valid(oos[idx]) ) - { + if ( !mfn_eq(oos[idx], INVALID_MFN) ) + { /* Crush the current occupant. */ _sh_resync(v, oos[idx], &oos_fixup[idx], oos_snapshot[idx]); perfc_incr(shadow_unsync_evict); @@ -607,7 +606,7 @@ void sh_resync_all(struct vcpu *v, int s /* First: resync all of this vcpu's oos pages */ for ( idx = 0; idx < SHADOW_OOS_PAGES; idx++ ) - if ( mfn_valid(oos[idx]) ) + if ( !mfn_eq(oos[idx], INVALID_MFN) ) { /* Write-protect and sync contents */ _sh_resync(v, oos[idx], &oos_fixup[idx], oos_snapshot[idx]); @@ -630,7 +629,7 @@ void sh_resync_all(struct vcpu *v, int s for ( idx = 0; idx < SHADOW_OOS_PAGES; idx++ ) { - if ( !mfn_valid(oos[idx]) ) + if ( mfn_eq(oos[idx], INVALID_MFN) ) continue; if ( skip ) @@ -2187,7 +2186,7 @@ void sh_remove_shadows(struct domain *d, !(pg->shadow_flags & (1 << t)) ) \ break; \ smfn = shadow_hash_lookup(d, mfn_x(gmfn), t); \ - if ( unlikely(!mfn_valid(smfn)) ) \ + if ( unlikely(mfn_eq(smfn, INVALID_MFN)) ) \ { \ printk(XENLOG_G_ERR "gmfn %"PRI_mfn" has flags %#x" \ " but no type-%#x shadow\n", \ @@ -2755,7 +2754,7 @@ void shadow_teardown(struct domain *d, b int i; mfn_t *oos_snapshot = v->arch.paging.shadow.oos_snapshot; for ( i = 0; i < SHADOW_OOS_PAGES; i++ ) - if ( mfn_valid(oos_snapshot[i]) ) + if ( !mfn_eq(oos_snapshot[i], INVALID_MFN) ) { shadow_free(d, oos_snapshot[i]); oos_snapshot[i] = INVALID_MFN; @@ -2938,7 +2937,7 @@ static int shadow_one_bit_disable(struct int i; mfn_t *oos_snapshot = v->arch.paging.shadow.oos_snapshot; for ( i = 0; i < SHADOW_OOS_PAGES; i++ ) - if ( mfn_valid(oos_snapshot[i]) ) + if ( !mfn_eq(oos_snapshot[i], INVALID_MFN) ) { shadow_free(d, oos_snapshot[i]); oos_snapshot[i] = INVALID_MFN; --- a/xen/arch/x86/mm/shadow/multi.c +++ b/xen/arch/x86/mm/shadow/multi.c @@ -110,7 +110,7 @@ get_fl1_shadow_status(struct domain *d, /* Look for FL1 shadows in the hash table */ { mfn_t smfn = shadow_hash_lookup(d, gfn_x(gfn), SH_type_fl1_shadow); - ASSERT(!mfn_valid(smfn) || mfn_to_page(smfn)->u.sh.head); + ASSERT(mfn_eq(smfn, INVALID_MFN) || mfn_to_page(smfn)->u.sh.head); return smfn; } @@ -2680,7 +2680,7 @@ static int cf_check sh_page_fault( mfn_t smfn = pagetable_get_mfn( v->arch.paging.shadow.shadow_table[i]); - if ( mfn_valid(smfn) && (mfn_x(smfn) != 0) ) + if ( mfn_x(smfn) ) { used |= (mfn_to_page(smfn)->v.sh.back == mfn_x(gmfn)); @@ -3824,7 +3824,7 @@ static void cf_check sh_pagetable_dying( : shadow_hash_lookup(d, mfn_x(gmfn), SH_type_l2_pae_shadow); } - if ( mfn_valid(smfn) ) + if ( !mfn_eq(smfn, INVALID_MFN) ) { gmfn = _mfn(mfn_to_page(smfn)->v.sh.back); mfn_to_page(gmfn)->pagetable_dying = true; @@ -3867,7 +3867,7 @@ static void cf_check sh_pagetable_dying( smfn = shadow_hash_lookup(d, mfn_x(gmfn), SH_type_l4_64_shadow); #endif - if ( mfn_valid(smfn) ) + if ( !mfn_eq(smfn, INVALID_MFN) ) { mfn_to_page(gmfn)->pagetable_dying = true; shadow_unhook_mappings(d, smfn, 1/* user pages only */); --- a/xen/arch/x86/mm/shadow/private.h +++ b/xen/arch/x86/mm/shadow/private.h @@ -770,8 +770,10 @@ get_shadow_status(struct domain *d, mfn_ /* Look for shadows in the hash table */ { mfn_t smfn = shadow_hash_lookup(d, mfn_x(gmfn), shadow_type); - ASSERT(!mfn_valid(smfn) || mfn_to_page(smfn)->u.sh.head); + + ASSERT(mfn_eq(smfn, INVALID_MFN) || mfn_to_page(smfn)->u.sh.head); perfc_incr(shadow_get_shadow_status); + return smfn; } From xen-devel-bounces@lists.xenproject.org Thu Jan 05 16:05:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 16:05:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472023.732118 (Exim 4.92) (envelope-from ) id 1pDSjq-0004e3-SQ; Thu, 05 Jan 2023 16:05:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472023.732118; Thu, 05 Jan 2023 16:05:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDSjq-0004dw-Nk; Thu, 05 Jan 2023 16:05:06 +0000 Received: by outflank-mailman (input) for mailman id 472023; Thu, 05 Jan 2023 16:05:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDSjp-00043x-Qx for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 16:05:06 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2074.outbound.protection.outlook.com [40.107.241.74]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b6f04905-8d12-11ed-b8d0-410ff93cb8f0; Thu, 05 Jan 2023 17:05:03 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB8046.eurprd04.prod.outlook.com (2603:10a6:102:ba::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 16:05:02 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 16:05:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b6f04905-8d12-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=duAJiTua+JHJcndxBJVume4ofnWTeM8JJbVBTrJj0HJGQa/ojDD0MvZdj+FXNKMBWIG/2JMhmlMJYajPd4PuvDS0NYByn6mcVdmlfXMklo6p7d1OUcrVPJXI85wJcO3zYChCcpdOYY3D0POhf1lJu8yjApZTHBJ6bXh5NJAAqbTgKYRJ05bI93tQhgiy0rYQMRNUClAs2Ax9lylKHvVVeadJMjd1cZlP0lbFaIMKor9GmrHn/yWVYUNFzumU90OZuizDt1ezZZwcqQJo9Ywc68sVU2No1UDRSdfq33swMHAeQ8iHwSBQYJdNr1yr+Q3w2SUYZP1RKgRsdYf1PV8fkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qf+emyh5II2V0/A5S4zzJusw1CCXBsG+DAb5LICmZYA=; b=IUvndegZT73HSgQRKLGacBhYnCgufztfBzZeZA2Fuhoj0G++tNuPEDDWSgtvdWGwDMqO6bhBrqM6LMvpQn4gX6EVyouMOnbqqFU+NZiakbI2DEjTWcJQ8EfaB26r3JjlO3SFKMj0n9jXPaGW1HztLCHt7q5LxYsbw5zMysG+DbAd/OeSHFw2ch4V5x8N5r90eTLaRo6q8a6P6AsFFAr3mqAjwyrXoXcIS8LnoaLsjniEVwbjdNimWKVzcrHPm6OVZVoUa9z4P6l5/Yjbkup9Y+HvmKenEyeCCjL41vc2RiWvnsqwMJ74FIdovv/b2kpN7+B4klET8d660rPvMHCNdw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qf+emyh5II2V0/A5S4zzJusw1CCXBsG+DAb5LICmZYA=; b=vJJFZfrdRCISbegw2kzc9xX5Sdv/+Jj1Ys3IOalhX19F598fMDsJmIBwRW6Kh8rTeDzfC9zKlTFjVJIEczguch81bfG92zOD7GP4cEIvMNz+HKeyE9YsQ0ZoF/3yL/HIDpQdO7bcLwqs6zV3Q1EtzqxGyK/11OaT/w/iq4GDx7DTvOxxjkf4K0yTG57//wCX8h7ANNu+59U2tqbPG/PcXI8/H5oSJq4Ur1l1rSz1U9ePpW76J+K2BdtuFtinF3EmnrqcFdMOYGDfaaK3+ntPZkC6yHGfPt1Qm8FuKqi7Tb7KBb4+cHQGsDEmKOQwOWbZgGouA+BlGkZhqC5QgQHtLw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2743393d-852d-b385-9eba-e22806b1c4af@suse.com> Date: Thu, 5 Jan 2023 17:05:00 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: [PATCH 07/11] x86/shadow: L2H shadow type is PV32-only Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Tim Deegan , George Dunlap References: <074dc3bb-6057-4f61-d516-d0fe3551165c@suse.com> In-Reply-To: <074dc3bb-6057-4f61-d516-d0fe3551165c@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0119.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB8046:EE_ X-MS-Office365-Filtering-Correlation-Id: f543001e-0cbd-41fc-a49d-08daef369a0e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8t3hWtPV3+fLpGRwWuwYnggj1sjtO2C3j2+B9m6JD5BrgbHsCww3hExqYXv+QbV8m1AfWwvvaVUAmVpqvFkdJ62ZnjhMRpis7Fxnz121J5hWYSicvIA2Kn6cea0gKN9fUrVD6ZdanPO41E85dGjuIuG62oWTwdXICtS781UwCewduKaKROmBFY/i7t0xKhcQVkaO4wndeFjoYx22lJtsJVpO97AHTK7PMyu8dp6K7co2nnPnJ7dP+yk0svMvD/hZmJUHCh88+Lb3oyMzkclni/hzG3vpsopV6i6Y77E4ncKpRt0KJ4U/blDn8hoO1DfuY3ENRP6X7KNZm9KiVY7Aop4I4/VQvXFyZ/jgk1LNyAxw3qmgK+zMz1yeCYZcskwmTc7D0pECw4QmEWxDwxW6EuvfS3mpRM9z6XQsYOET7RYJEv+AF2y2G88FABcDaYzi/ot26ZTwYRgphCcrUGHo1C42DyQFq6fnsXmCYKKpT0iY2akGrtyP7WxY3uZNHJfSuXFDyDxI8bguExmWZin9/EG2LCz9nBgsSsTAE72gCyin1PJ4VfSb2GqpHqQj7MW4/eZGDNGdtSxcmUJQofi8+7e37lzufMQ4Ijwzh+1qr0pYbarri0vxiJBh2l8bRKI8ABXVDpY6Q49EcBvXoxbf+wWCnNtMhpdRNPOEo2DIvrn21y9/GezNM4K+nkevUezUwVloXSSfQzNZwgu1/zrSLRPXL0y/q5kS27ppQvWnzeg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(376002)(396003)(346002)(366004)(39860400002)(451199015)(38100700002)(6506007)(316002)(83380400001)(31696002)(4326008)(86362001)(66476007)(66946007)(5660300002)(8676002)(2906002)(66556008)(41300700001)(8936002)(6512007)(26005)(186003)(2616005)(6916009)(54906003)(478600001)(6486002)(31686004)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T1hVeUlNRlZLY2N5QWtHSllXV2Z1YWtVb1VYajJpN1lqSFh2b0p1V3VrdHcv?= =?utf-8?B?MHkvelkzRnV0RUFtR0w0d2pxdFdKU1lZckFEMldYWDVkV2hBZTNDM0JVTGJl?= =?utf-8?B?YTJJTnhZVmxtbldYdXdTR3pqaW5xVW5PTlFXS1lnbnVkRjRqbXc2TzZCZWkw?= =?utf-8?B?YTR3bEhuYVlzK0MwUGNSd1YxTE83YXZCS1FYSW1ISWpEVktSa0wvdlk1eStF?= =?utf-8?B?U0RyWW9ycGZLbXhKYlNWWnA1d015M0pidzdZcnphWnpnMHgxcXMxN3V2WUIy?= =?utf-8?B?RlJHZitTWWVJTVF5Y0pnVVpNZUJJc0VFNUZsZjhBSWNHMXNDdzhscWtxREZr?= =?utf-8?B?QnEvd2pMVnJYZGs2RjRCV0ZQT3c2VFUyQlVmNG5sODlmUEhYYTFYajlOUjg1?= =?utf-8?B?TUp4NDB0aUQyU1hxYi82WU1vUjZmUjV4K1FVSEJUT2o2VDRJd05GTUhSQmlq?= =?utf-8?B?K2J4eVJndWlJQmVjdjFIc0NvMysvWkxHM1Y4azV3R2kwYm1CcTV0NWFXcTNX?= =?utf-8?B?SndsMWNjVitKYVU1RHlxeTYzWFNZYS9FazdKRC9xWTlzQ2hTdDdXaGZuWElo?= =?utf-8?B?LzQyYUdERnYwdUhKZ0c5S0VmdFllV21uQUFrb0U0MzdXeERtVW9Yc0xoUDlX?= =?utf-8?B?d1VvZmFTMlFwVzNBZU85Z1lDRHN5RTBMV2VHem81V0FQa0lvNUg0WWxvMW81?= =?utf-8?B?OWRMWmJ2Q0dxY0pqKzdDOWtFK0FjaHdMbjZDZDdHSkxGNHBOa1haNVR2T0hu?= =?utf-8?B?MFJzNUpMZU1mL2xlU0ltTVJ5ZFJoTWF2bDR1OHBLUVRHMXhXR0l6dVFYM3N4?= =?utf-8?B?ZjNhZzN6SWFWV0g2SlhmU2hVZ3pqNGtLOGppcHo4WlNZTFRlTUhodTluc1BE?= =?utf-8?B?eG9JOUJ2NHVKcy8zOE50YjdvZ0VPcXZQZ3p4VUs0SnZBM3dzUnpkdUlIQkE4?= =?utf-8?B?ejlEdm5BaW5WUEY5V3Jjem9ZTUREQS9KdTJhR3dCYndzQmwveENrZnJ5eWRI?= =?utf-8?B?cklkSHhVVXNzdGVFTkxTR1pWdWd6ZldmNDd1ZFE0d3dyWFZnQVFqa1QvNDNk?= =?utf-8?B?ZzVNNTB2NW9oaWtFU2tUWUNBa3lQUHJPdTJRbldCNVg2OEFaU1kzSVpHRnd2?= =?utf-8?B?b2xKRTBiNGd1VEFTcFNiL0ZBUVhFV1J6c0prek02VElLVlRFdTNSdlExcGly?= =?utf-8?B?Q1Qzbm9aaXJuSzRmS2U2SVlEdk9jbjJ2WWtBcXhiZ0lrT2kyV1UxeGUySGJL?= =?utf-8?B?SWlVaGhxVFZKZGJhVG5vemp2b1JPRE4yeVdKTkxjbTF5WXlaNXZnMUtRZVFt?= =?utf-8?B?a2VHeHl4U3VCSkJzZGFsQ1d0R0tCSlVJVnNqYlNpSGRGNlpwVWZwcUF4aG5L?= =?utf-8?B?MGJ4K0wzV3RLTzlieTBIMWNHSy9qM0lrYnBJeS93U2JzUVRackNEWmw4UUJD?= =?utf-8?B?c3ZoeXdmaFBGQWpnWlBNdzc4YzJzNzZTVEs5WHRUaFNyVitPOXVCY0lDRWlS?= =?utf-8?B?NkFZZ09sanJ6SEFSNWlDMk5KQ0xYM043bTJ4L0ZYQWx3enVYMmxQaHNVOUtH?= =?utf-8?B?RG1CeExWU2tDbll6NHZmNzg5WjdNQ2h5U1lOSnc2Z1VTeUxVeS9ZbUtqdHFC?= =?utf-8?B?bWl2MjV2UFZIczJnaGZhRWFzTTFFYVdZT1BmN0JSWC9WWDNaeVZSbTArV0I3?= =?utf-8?B?UGlHUGFFNmF2TnRrQmkwWWovNVAwZ2VYVUw0aFlIRVpKcng4MzRyWlFJYzA5?= =?utf-8?B?THh2RDNWbEd3Wkl3bHlCV1ZDSUwrQ2tDQnRQaEFINFRCbXZLYXNlaDBvSU5k?= =?utf-8?B?a2VkNnlMaklDV2xxb21hc002Z3JIOGUyZDhKZHZGQWFOTkZ3R05QYTd3SHFO?= =?utf-8?B?c3hMUUM1Nms0R3hxMnVOeXhkYWR3UUdOMWZvTGVzVk5KZ1pSSDNqcEtQR3F2?= =?utf-8?B?dmlDVUZ4aDBPemdUcnBYMHNMaDFVNnFSQmxNem9kWXZHbjhnNEVoWEdQZWNy?= =?utf-8?B?anlJT05yeWlidG95UlFLNTNCT3Z1bmRBYkc2VG5kaE9HakJ2UVA5Tk1peFo0?= =?utf-8?B?VkF3dTNGR0xIWm9aWnFSakc3K3ZQc0E4TkJsS3dKbWtoMnJ5Z3k4dEVnWTJZ?= =?utf-8?Q?6MEtkhrrzr9MphC1N+iEEbAZG?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f543001e-0cbd-41fc-a49d-08daef369a0e X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2023 16:05:02.0144 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WTXXaRZjnpb1VjUjcxphjU+lnjhdVmEQ5clxnF6UNL6YPmc5B/0WMfz8baRlbRRyaxVzmpVCJOoyr7DwIaYM4Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB8046 Like for the various HVM-only types, save a little bit of code by suitably "masking" this type out when !PV32. Signed-off-by: Jan Beulich --- I wasn't really sure whether it would be worthwhile to also update the "#else" part of shadow_size(). Doing so would be a little tricky, as the type to return 0 for has no name right now; I'd need to move down the #undef to allow for that. Thoughts? In the 4-level variant of SHADOW_FOREACH_L2E() I was heavily inclined to also pull out of the loop the entire loop invariant part of the condition (part of which needs touching here anyway). But in the end I guess this would better be a separate change. --- a/xen/arch/x86/mm/shadow/common.c +++ b/xen/arch/x86/mm/shadow/common.c @@ -1740,9 +1740,11 @@ void sh_destroy_shadow(struct domain *d, case SH_type_fl1_64_shadow: SHADOW_INTERNAL_NAME(sh_destroy_l1_shadow, 4)(d, smfn); break; +#ifdef CONFIG_PV32 case SH_type_l2h_64_shadow: ASSERT(is_pv_32bit_domain(d)); /* Fall through... */ +#endif case SH_type_l2_64_shadow: SHADOW_INTERNAL_NAME(sh_destroy_l2_shadow, 4)(d, smfn); break; @@ -2099,7 +2101,9 @@ static int sh_remove_shadow_via_pointer( #endif case SH_type_l1_64_shadow: case SH_type_l2_64_shadow: +#ifdef CONFIG_PV32 case SH_type_l2h_64_shadow: +#endif case SH_type_l3_64_shadow: case SH_type_l4_64_shadow: SHADOW_INTERNAL_NAME(sh_clear_shadow_entry, 4)(d, vaddr, pmfn); @@ -2137,7 +2141,9 @@ void sh_remove_shadows(struct domain *d, [SH_type_l2_pae_shadow] = SHADOW_INTERNAL_NAME(sh_remove_l1_shadow, 3), #endif [SH_type_l2_64_shadow] = SHADOW_INTERNAL_NAME(sh_remove_l1_shadow, 4), +#ifdef CONFIG_PV32 [SH_type_l2h_64_shadow] = SHADOW_INTERNAL_NAME(sh_remove_l1_shadow, 4), +#endif [SH_type_l3_64_shadow] = SHADOW_INTERNAL_NAME(sh_remove_l2_shadow, 4), [SH_type_l4_64_shadow] = SHADOW_INTERNAL_NAME(sh_remove_l3_shadow, 4), }; @@ -2150,7 +2156,9 @@ void sh_remove_shadows(struct domain *d, #endif [SH_type_l1_64_shadow] = SHF_L2H_64 | SHF_L2_64, [SH_type_l2_64_shadow] = SHF_L3_64, +#ifdef CONFIG_PV32 [SH_type_l2h_64_shadow] = SHF_L3_64, +#endif [SH_type_l3_64_shadow] = SHF_L4_64, }; @@ -2214,7 +2222,9 @@ void sh_remove_shadows(struct domain *d, #endif DO_UNSHADOW(SH_type_l4_64_shadow); DO_UNSHADOW(SH_type_l3_64_shadow); +#ifdef CONFIG_PV32 DO_UNSHADOW(SH_type_l2h_64_shadow); +#endif DO_UNSHADOW(SH_type_l2_64_shadow); DO_UNSHADOW(SH_type_l1_64_shadow); @@ -3179,7 +3189,9 @@ void shadow_audit_tables(struct vcpu *v) [SH_type_l1_64_shadow] = SHADOW_INTERNAL_NAME(sh_audit_l1_table, 4), [SH_type_fl1_64_shadow] = SHADOW_INTERNAL_NAME(sh_audit_fl1_table, 4), [SH_type_l2_64_shadow] = SHADOW_INTERNAL_NAME(sh_audit_l2_table, 4), +# ifdef CONFIG_PV32 [SH_type_l2h_64_shadow] = SHADOW_INTERNAL_NAME(sh_audit_l2_table, 4), +# endif [SH_type_l3_64_shadow] = SHADOW_INTERNAL_NAME(sh_audit_l3_table, 4), [SH_type_l4_64_shadow] = SHADOW_INTERNAL_NAME(sh_audit_l4_table, 4), #endif --- a/xen/arch/x86/mm/shadow/hvm.c +++ b/xen/arch/x86/mm/shadow/hvm.c @@ -56,7 +56,6 @@ const uint8_t sh_type_to_size[] = { [SH_type_l1_64_shadow] = 1, [SH_type_fl1_64_shadow] = 1, [SH_type_l2_64_shadow] = 1, - [SH_type_l2h_64_shadow] = 1, [SH_type_l3_64_shadow] = 1, [SH_type_l4_64_shadow] = 1, [SH_type_p2m_table] = 1, --- a/xen/arch/x86/mm/shadow/multi.c +++ b/xen/arch/x86/mm/shadow/multi.c @@ -97,6 +97,13 @@ static void sh_flush_local(const struct flush_local(guest_flush_tlb_flags(d)); } +#if GUEST_PAGING_LEVELS >= 4 && defined(CONFIG_PV32) +#define ASSERT_VALID_L2(t) \ + ASSERT((t) == SH_type_l2_shadow || (t) == SH_type_l2h_shadow) +#else +#define ASSERT_VALID_L2(t) ASSERT((t) == SH_type_l2_shadow) +#endif + /**************************************************************************/ /* Hash table mapping from guest pagetables to shadows * @@ -337,7 +344,7 @@ static void sh_audit_gw(struct vcpu *v, if ( mfn_valid((smfn = get_shadow_status(d, gw->l2mfn, SH_type_l2_shadow))) ) sh_audit_l2_table(d, smfn, INVALID_MFN); -#if GUEST_PAGING_LEVELS >= 4 /* 32-bit PV only */ +#if GUEST_PAGING_LEVELS >= 4 && defined(CONFIG_PV32) if ( mfn_valid((smfn = get_shadow_status(d, gw->l2mfn, SH_type_l2h_shadow))) ) sh_audit_l2_table(d, smfn, INVALID_MFN); @@ -859,13 +866,12 @@ do { int _i; \ int _xen = !shadow_mode_external(_dom); \ shadow_l2e_t *_sp = map_domain_page((_sl2mfn)); \ - ASSERT(mfn_to_page(_sl2mfn)->u.sh.type == SH_type_l2_64_shadow ||\ - mfn_to_page(_sl2mfn)->u.sh.type == SH_type_l2h_64_shadow);\ + ASSERT_VALID_L2(mfn_to_page(_sl2mfn)->u.sh.type); \ for ( _i = 0; _i < SHADOW_L2_PAGETABLE_ENTRIES; _i++ ) \ { \ if ( (!(_xen)) \ || !is_pv_32bit_domain(_dom) \ - || mfn_to_page(_sl2mfn)->u.sh.type != SH_type_l2h_64_shadow \ + || mfn_to_page(_sl2mfn)->u.sh.type == SH_type_l2_64_shadow \ || (_i < COMPAT_L2_PAGETABLE_FIRST_XEN_SLOT(_dom)) ) \ { \ (_sl2e) = _sp + _i; \ @@ -992,6 +998,7 @@ sh_make_shadow(struct vcpu *v, mfn_t gmf } break; +#ifdef CONFIG_PV32 case SH_type_l2h_shadow: BUILD_BUG_ON(sizeof(l2_pgentry_t) != sizeof(shadow_l2e_t)); if ( is_pv_32bit_domain(d) ) @@ -1002,6 +1009,8 @@ sh_make_shadow(struct vcpu *v, mfn_t gmf unmap_domain_page(l2t); } break; +#endif + default: /* Do nothing */ break; } } @@ -1123,11 +1132,13 @@ static shadow_l2e_t * shadow_get_and_cre shadow_l3e_t new_sl3e; unsigned int t = SH_type_l2_shadow; +#ifdef CONFIG_PV32 /* Tag compat L2 containing hypervisor (m2p) mappings */ if ( is_pv_32bit_domain(d) && guest_l4_table_offset(gw->va) == 0 && guest_l3_table_offset(gw->va) == 3 ) t = SH_type_l2h_shadow; +#endif /* No l2 shadow installed: find and install it. */ *sl2mfn = get_shadow_status(d, gw->l2mfn, t); @@ -1337,11 +1348,7 @@ void sh_destroy_l2_shadow(struct domain SHADOW_DEBUG(DESTROY_SHADOW, "%"PRI_mfn"\n", mfn_x(smfn)); -#if GUEST_PAGING_LEVELS >= 4 - ASSERT(t == SH_type_l2_shadow || t == SH_type_l2h_shadow); -#else - ASSERT(t == SH_type_l2_shadow); -#endif + ASSERT_VALID_L2(t); ASSERT(sp->u.sh.head); /* Record that the guest page isn't shadowed any more (in this type) */ @@ -1865,7 +1872,7 @@ int sh_map_and_validate_gl2he(struct vcpu *v, mfn_t gl2mfn, void *new_gl2p, u32 size) { -#if GUEST_PAGING_LEVELS >= 4 +#if GUEST_PAGING_LEVELS >= 4 && defined(CONFIG_PV32) return sh_map_and_validate(v, gl2mfn, new_gl2p, size, SH_type_l2h_shadow, shadow_l2_index, @@ -3674,7 +3681,7 @@ void sh_clear_shadow_entry(struct domain shadow_set_l1e(d, ep, shadow_l1e_empty(), p2m_invalid, smfn); break; case SH_type_l2_shadow: -#if GUEST_PAGING_LEVELS >= 4 +#if GUEST_PAGING_LEVELS >= 4 && defined(CONFIG_PV32) case SH_type_l2h_shadow: #endif shadow_set_l2e(d, ep, shadow_l2e_empty(), smfn); @@ -4124,14 +4131,16 @@ int cf_check sh_audit_l3_table(struct do if ( SHADOW_AUDIT & SHADOW_AUDIT_ENTRIES_MFNS ) { + unsigned int t = SH_type_l2_shadow; + gfn = guest_l3e_get_gfn(*gl3e); mfn = shadow_l3e_get_mfn(*sl3e); - gmfn = get_shadow_status(d, get_gfn_query_unlocked( - d, gfn_x(gfn), &p2mt), - (is_pv_32bit_domain(d) && - guest_index(gl3e) == 3) - ? SH_type_l2h_shadow - : SH_type_l2_shadow); +#ifdef CONFIG_PV32 + if ( guest_index(gl3e) == 3 && is_pv_32bit_domain(d) ) + t = SH_type_l2h_shadow; +#endif + gmfn = get_shadow_status( + d, get_gfn_query_unlocked(d, gfn_x(gfn), &p2mt), t); if ( !mfn_eq(gmfn, mfn) ) AUDIT_FAIL(3, "bad translation: gfn %" SH_PRI_gfn " --> %" PRI_mfn " != mfn %" PRI_mfn, --- a/xen/arch/x86/mm/shadow/private.h +++ b/xen/arch/x86/mm/shadow/private.h @@ -209,6 +209,10 @@ extern void shadow_audit_tables(struct v #define SH_type_unused 10U #endif +#ifndef CONFIG_PV32 /* Unused (but uglier to #ifdef above): */ +#undef SH_type_l2h_64_shadow +#endif + /* * What counts as a pinnable shadow? */ @@ -286,7 +290,11 @@ static inline void sh_terminate_list(str #define SHF_L1_64 (1u << SH_type_l1_64_shadow) #define SHF_FL1_64 (1u << SH_type_fl1_64_shadow) #define SHF_L2_64 (1u << SH_type_l2_64_shadow) +#ifdef CONFIG_PV32 #define SHF_L2H_64 (1u << SH_type_l2h_64_shadow) +#else +#define SHF_L2H_64 0 +#endif #define SHF_L3_64 (1u << SH_type_l3_64_shadow) #define SHF_L4_64 (1u << SH_type_l4_64_shadow) From xen-devel-bounces@lists.xenproject.org Thu Jan 05 16:06:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 16:06:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472036.732129 (Exim 4.92) (envelope-from ) id 1pDSko-0005MP-8Y; Thu, 05 Jan 2023 16:06:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472036.732129; Thu, 05 Jan 2023 16:06:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDSko-0005MI-5k; Thu, 05 Jan 2023 16:06:06 +0000 Received: by outflank-mailman (input) for mailman id 472036; Thu, 05 Jan 2023 16:06:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDSkm-0005LZ-Ad for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 16:06:04 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2068.outbound.protection.outlook.com [40.107.241.68]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d9cb5a9d-8d12-11ed-b8d0-410ff93cb8f0; Thu, 05 Jan 2023 17:06:02 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB8046.eurprd04.prod.outlook.com (2603:10a6:102:ba::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 16:06:00 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 16:06:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d9cb5a9d-8d12-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JK0twxZG6alBtmSSizwcYEyh563fpdxnpgziu3kcb+CZZ8IDa3K+w4U1anaG+W5B10VvmEUVzSq2++WzJjigo0XK4vSOicrqj0v7/FMvfiD/mtB4i+4DroFTkkLtV6kwzHTpAg1q61qYzpZinpL1gKcmbwwq6Hfcn5fasTL+8vpHh3MfmK8DkW5E9LdCmFpbgcmPIJa0m5wFw5cWxwgfkR/fG+0Y+p+jAyzm3fngBE/6TGSnp24Z07B2mgE0DvT47/AbpyVEmyQYoJFFdR7fy3/V5EyLlbboWGEUM2LwcndOzE4oVF0zW4lmyV72gemtGWqdkNl/uYstkh85iSql1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tp/xRy5VT94YqOsqdM3hhLWnXJKhH74obPOAkyaCA0Q=; b=clxZolyFyrRJJ2KxqPgWzTGcPFh0Ka8PidOk5WXeoMN+a3lbNJxVedKEhiMtnQTLzaVNXZbt+L/sXRhqvk5rAD00BJvW4k7n+aeUbwZ8nuqjHJcgbfcazVtxF0Gy2AcYkZF7btAfAsAiyu2+xM6kFVtHvPVjz6V3MZSDfOIcItJE+15VvOCeDYJzJqu8GF5BYLnb+RAcQ3EHydRgnlw4GaAtzgJEEmtZ4VkSWJ+tqL05jcRr4TDgrx8RfuNmBQROOe4CW5pd77vgdVerYIVJCAcQpfjWtF8H6MN3V3UmMOPJZ3zDx2Qg+khE6ioIXnA6jKJy8DuG4OGx5SOEETi0dQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tp/xRy5VT94YqOsqdM3hhLWnXJKhH74obPOAkyaCA0Q=; b=wY3IacouTb28PDk+gWcXEamSJDS2A134FGrYIL0baydIR6X0TvXOQWNCUKq4VtvoPY7DyuwI2t5+r1u/qmEAasK5h8iT2n1epbzlR/A3Y+9FjykMmxCbpc9X7tbVEXMc4qJnof0BAzJfpWjngIkpmPNFamKGPP+EGFe6lzReulrfoGsIgylPajpULKo9SV5pTcZkCg5WOUmMq4KCyl17pNCey9xjj4iOa04hYI4lutWYL7nite7OBEjqP1XF7nUy3Q1xqvTEwErOCqRIP7md4JhplgA58MnyoHRFufh+SEjrI1P7mYzILrckaew0fm2lAGEp7JJ0knKkXTQbYIu+nw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 5 Jan 2023 17:05:59 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: [PATCH 08/11] x86/shadow: reduce effort of hash calculation Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Tim Deegan , George Dunlap References: <074dc3bb-6057-4f61-d516-d0fe3551165c@suse.com> In-Reply-To: <074dc3bb-6057-4f61-d516-d0fe3551165c@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0006.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB8046:EE_ X-MS-Office365-Filtering-Correlation-Id: 64ff1aa6-ab3e-4d85-38af-08daef36bd2f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KhmN35WnVVCHX3NTS8nYQ8roJdSOC+NdLb/oE7FghutaIbMflusxce+Qa2o9/ePhdtP7fSb6npkm70rH99J+SroCKqom1lPPQjYAfCDw6n+J3CWh9OqPXXVEWbXQXqufrAZgBxf+wsbDWwLKQ+LHED6bps0cPQUO2Eb/+ng16H16KmMfu4R0hchihMPwb5y40M13/q2CunrtLxoKEmRL1B5BSqBlcRJ/Mtk+bPpjAZ+hdk+FhbFx51UeE0aF1SzpEcTHCHFgh6xL1AfOFl9u1FMhGqy1b1tDC8B+9zAKk99PfFXhuaDTmJ6ZBkbe12qZTxy06z4XFEH3kc81Lkd2pFFLxo7tPnPLjiJRyaPvww0f6hXlfKtJ40Xe83tN1fdsT3AmCRemmZYB2JUx5s/uHhPEYe2OyewMpFa6JJb94QEdWnbbgusXidQUpWAjmOGT7agQ2lEHdSIlhPtuG0oN+4ckDMXZwCKUkH8swTLm00SMQcfp+ruSjmfDQuJhv7LJ3PSzF/6IilnfmXe0yqk6iXPMWwc9giR1VRZ1EltKQjqokrj5yLkvGzjHAXwgOC93A1m5iFvDSQXvU3dSPxG447K7lg7HCPw0tSztI203dMbIkWjAfAVMAkf/lE8RQDukxX0Vco2gdODinfQ9UnSUJ4RSA1gO7zk4Gslb3D5EX2KeR/0qDaKfx6bUzjWqyn7EcYLaCbkkM1/9UWsjO62XKFsw/rrtRLnlhadZEOPpJSo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(376002)(396003)(346002)(366004)(39860400002)(451199015)(38100700002)(6506007)(316002)(31696002)(4326008)(86362001)(66476007)(66946007)(5660300002)(8676002)(2906002)(66556008)(41300700001)(8936002)(6512007)(26005)(186003)(2616005)(6916009)(54906003)(478600001)(6486002)(31686004)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?azU2cWxwMXJkbmtUWFIveVhubTVja1NtKytQMFdFeVQ1REtEdDFUbFRnaEtv?= =?utf-8?B?dTdYMlJzUGxLdlc3NlZ0UEdweEtQNklqcG16QUVrYVkxYWdBR3VreE8yYURE?= =?utf-8?B?U0pPYVE3bExqTXpsY2wzTzhqL2NDWTJzK09iTlF4TmxCZzdCazg2Tm1DaW9u?= =?utf-8?B?aEIyOG93eWhNd3lnWThTeW0ydGR0Yk1sY1R5MTgxdm44bXlwWTJ3eVo2c1FC?= =?utf-8?B?L3ROK2NYUjJicU9wTmYyUWt0MDFieGJhemd3OEkvaFRiUHF1VXp6c1FBcUpp?= =?utf-8?B?ejRIUGdlNEY0MUZxK3R6a3VwS05KTkUxQWh4UWpEOVB2TXFKZExXbE43UWhU?= =?utf-8?B?VVloU3U5SllBQUdXZStCZFhjK0NhUWpBMXF2ZDd3bkhQUnlydlJVRnR1dHZF?= =?utf-8?B?RlJPOUR0MDBkbXp3cHFGVzVlZGViQ1h2YXMyRkVhcW1rbXM5bExPN2c3TURw?= =?utf-8?B?SUdKNDNyYUl4YjRoRFFENUxXeEswUVk3NjRNNHhKQlZSMStQWEZLNW1CYXo2?= =?utf-8?B?VWdBaTBCWWJReHYxU0VIRnFYUFI3Wmc4WjJ1aHA4QkF0NXdtYjhMUXI3SG1t?= =?utf-8?B?M05RQ3E5NmVMd2xkTjNlNDBPQmM0aWo1US9nZnZyNWtpZW0veEw4bTNLSzJF?= =?utf-8?B?cHdyRFNBaldRaWpKSDRTUUJFeTNoZWV3S0N0aVBzajRRT3VwZHBCNnhjL1V4?= =?utf-8?B?Q24rdmJtNjQrRndDV3FyREU2S2thS1hLYjU5MUVYTDZYUlc4dlpNVXFsNHly?= =?utf-8?B?S0czbitYV3BHcUNNODQwYjQ5SzQrV0N4cXhreHFKK2lQV3A4VW9JY1FmazZq?= =?utf-8?B?MExFdm9uaGc5bE9qQ3ExS1NCNFNNRmdIenFWWmo0eXNtaDRCNk1NYXZjNXY1?= =?utf-8?B?c21PbnU4RC9sUHYxSzVrVHJsWVZ5Qll0Wnc1b0lMNjlUSDliUVloYUx0ZzZq?= =?utf-8?B?aXdlZjJtaDdFazVKK0UxVkI0eUs0NXFkSWhZVjlTV1ZhNFh6LzZBR05KZHZs?= =?utf-8?B?TmxOd2VTTHl2Y2pIU1B0WVA5MzRoVmtVWll3dndFTmxDb0dCRlFHTTN2VnR5?= =?utf-8?B?RjJyVFJiVVF1NksvSVNuRTA5R3p3Qk5iRVdtMkg5VThFdlJOQTVucC83cGJR?= =?utf-8?B?YWlRU3RxNkEydGlUYTZVRU1OcXo2MHFiZDkxcTdqVHR3UFdnZjc0Zk9FMERS?= =?utf-8?B?NmJsR25jeng3NlhBbldJbjcrRVVXSFNjbWtGZk1la3ZhVTliczRBNmdvaXdX?= =?utf-8?B?bzd0SEZGc2NBM1F2KzZyMW4zRWQ0bE9hUnl3VHViekxjQTZhOXhhclkyUDdO?= =?utf-8?B?eDNEUHRoVFpQNmxJbDNQb0hLbnlHcXNTR1hKSG1vWEZGMXIzTldJNndBWHJr?= =?utf-8?B?eUl2bUY1Y0pnei9DV0RodXBRZXlvTE5EY0VSQmdFOU83dVB5Z2xWSE9nK2RY?= =?utf-8?B?T1VWak94akpRZGt2d2NVTXRYdTZodXkyVmVWcXVaWDhqTXMzcC9nTUJVQ24w?= =?utf-8?B?Wnhab3V1VFUxWTNuT1N6OUloMERVWmJyKzErZEJxZllMVlZyNGVhWlFHOER4?= =?utf-8?B?S1RtUUhvQVpUV0NhelhBM2FlYVZPWUplbVJNc2hGdU9tOWdhMVNFL1JvYWF4?= =?utf-8?B?R1lxa3BJaTdWRm55Tm9mUElTbTJ2d1ZpTGR5YnBwZCtRMTRuK1F3UEYwRWFL?= =?utf-8?B?YTY2bFJYWGhSc281d2RRVHExZU5CTkVDcFdxTVBFWEZ0MkVESUFnYXFyZU5X?= =?utf-8?B?R1NkUzc5Wkp1Sng2bWRuZ1VCeVZsa0pLMjJta1pOR20vc2dGN21XL1g1NFdk?= =?utf-8?B?cXBnYWxRSXB5cnN1VGkvOEFDTFdLVTZtVDQrenhwOTFidTFPMTRBbUNYeXll?= =?utf-8?B?bjRZRkl3Qmh4aHNGaUVnZjRrcXhCWXVaQnRxR1c5elZWc1hkeEsvSFNBSUpE?= =?utf-8?B?RFhzSXUxdWZVQzBvbFI0SDRUQ3V2eVVxbnFwekE2U3NQZ1lzQUU2djhLWmJF?= =?utf-8?B?QjFqYjdtZ3AwNUQ4OWJtQlJITDZOUFFWbW12THptWWpUZ1BJWGczNE9mUFMr?= =?utf-8?B?NXJyRlF6WHNveFdIK1lUblFPQk5CU1IwUzMyNG15RDFlU1dCcm01eTJ4clRM?= =?utf-8?Q?lzHrdtOdMLwiWmMoK4pJtWXEE?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 64ff1aa6-ab3e-4d85-38af-08daef36bd2f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2023 16:06:00.8857 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LaQDgsNlFjFJCocMBEUkxOUjT0qwE/voMbSmTu3fAN7wtJpxx0dgCsa2Y6wWK7xICqEttpvbeczQIWvQT6NEbg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB8046 The "n" input is a GFN value and hence bounded by the physical address bits in use on a system. The hash quality won't improve by also including the upper always-zero bits in the calculation. To keep things as compile-time-constant as they were before, use PADDR_BITS (not paddr_bits) for loop bounding. This reduces loop iterations from 8 to 5. While there also drop the unnecessary cast to u32. Signed-off-by: Jan Beulich --- I was tempted to also change the types of "p" (pointer to const) and "i" (unsigned) right here (and perhaps even the "byte" in the comment ahead of the function), but then thought this might be going too far ... --- a/xen/arch/x86/mm/shadow/common.c +++ b/xen/arch/x86/mm/shadow/common.c @@ -1400,7 +1400,11 @@ static inline key_t sh_hash(unsigned lon unsigned char *p = (unsigned char *)&n; key_t k = t; int i; - for ( i = 0; i < sizeof(n) ; i++ ) k = (u32)p[i] + (k<<6) + (k<<16) - k; + + BUILD_BUG_ON(PADDR_BITS > BITS_PER_LONG + PAGE_SHIFT); + for ( i = 0; i < (PADDR_BITS - PAGE_SHIFT + 7) / 8; i++ ) + k = p[i] + (k << 6) + (k << 16) - k; + return k % SHADOW_HASH_BUCKETS; } From xen-devel-bounces@lists.xenproject.org Thu Jan 05 16:06:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 16:06:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472043.732140 (Exim 4.92) (envelope-from ) id 1pDSlN-0005uC-H7; Thu, 05 Jan 2023 16:06:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472043.732140; Thu, 05 Jan 2023 16:06:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDSlN-0005u2-EI; Thu, 05 Jan 2023 16:06:41 +0000 Received: by outflank-mailman (input) for mailman id 472043; Thu, 05 Jan 2023 16:06:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDSlM-0005kL-2C for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 16:06:40 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2087.outbound.protection.outlook.com [40.107.104.87]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id efab7802-8d12-11ed-91b6-6bf2151ebd3b; Thu, 05 Jan 2023 17:06:39 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS1PR04MB9432.eurprd04.prod.outlook.com (2603:10a6:20b:4d8::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 16:06:37 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 16:06:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: efab7802-8d12-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l4YhXWejcZbws13WDR0aSs6oVQoxmssMvS6YypsZTBokNSZJ9iiDVsXHqYHgXkdAsoHjvCFIlfg7kr7p/fCVUxfHLrUSQkICw6Ia+Fc7LirDbF/np3/oebizf+9HFM8Aa6CLSUE2kytICE0Ung6Z3fnGylwiwiOlaPkZAs6dpMWGkeM9ODMRASQh+paGb5CFWgR0Kv/5kz5+GtxeTPabRc4SfKhoUJx3LHmXbZ7EPwE+QcwXyAueXy/Dxbhi4asxcjtP3L3SptiRsNmTCoWBHaRV2vHFuELT4Wwx27l4KucBIlNNOY7RTEIPiR8o8uvBGZ7AMXTqNPYfJS1VKqqzgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iBgM5VtWVqIkPoDCOPK8xEPFq96mp+OUcLEBtT+07eA=; b=ZlHpO0xn9nPfqrWGjoomxwjgSXtoEQvCZAtYBuqneles+J7jyoz3PlESkWmfdEhpcr78533t5xqRSPwQIL5VA3MOGUVoexYKzIw5wvhP8hwX+oSUv5U+0jCcXnpViZVaQeTaSIf3tonW5XLKp6SgjpoWnnMBFDplXIkUKybfRJEEG1XwpBME47OLP8NyYexaNHdbVojtKNljyp7RVnuELpO6I7wP2lW29QB05peTl/Qwve25GNtEZ/uDPw+2PIwJdQFmFOyDbe4g+eHfCyRJ6m2VulvlssUI+OMeEEwl2nlhbH/qxnjVRhuqgp5N5LmaGg5NsIS6FIANbjwC12M0Iw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iBgM5VtWVqIkPoDCOPK8xEPFq96mp+OUcLEBtT+07eA=; b=l7VkZDgN1vWhY7eQ1WCKwhL2ReJP9SDbXcsvQtxT5n+FxK28rOKERP3bt16/JyPsrrEWCkQAvumNn6xhlvx+xLZ4+npqJ9LAZMjpp3CVJoCxkahqcASK1myTLVKI5durFKN+jaFOIBpVzia5qThqnKtg1LNVAY7dfRSfqy0k5KBc3IYtkkPFZXDYu4U6a4hFWZb9NRtdVDX9pPnyhzsjiXZKka6+mZFaPkXl2c9D7b00gpIflcJqRh9wgwhaVisykP2hc4xLOWL9qoraNHYeVjFSUMy/JKWLEU8KpU6lyhjAJmpkTSfYGRzhzAjdYKh+IUnhEIlPJGmvtNcRL19+/A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <0998689a-91b1-e381-ac63-a485ab2cb65d@suse.com> Date: Thu, 5 Jan 2023 17:06:36 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: [PATCH 09/11] x86/shadow: simplify conditionals in sh_{get,put}_ref() Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Tim Deegan , George Dunlap References: <074dc3bb-6057-4f61-d516-d0fe3551165c@suse.com> In-Reply-To: <074dc3bb-6057-4f61-d516-d0fe3551165c@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0010.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS1PR04MB9432:EE_ X-MS-Office365-Filtering-Correlation-Id: 3af18b23-60d9-47d6-01bb-08daef36d320 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vJ6piFQCYG2spTAB6SysG6x25rneJH89bOIqSUkifTZp+K99hrxhrqqMMJKy2KNR/rxGmpiCT4keIHBmCT3Pqe5be1Hy8aTH9IqiNvknbiAA7SyAdozGkaTHQj/muOIf9PIP+gSoqTQH1TyMOOklJ0Gy+iODzINriRUgt50lN+MCSMGS3Q1YjCCd+bShJ/AY8fJ5ayVW5o5yKWaYftAwRcOiaTGOsjvLs1Abx14HJxZlh9rkxsEms1wyjjbOwDBIf7wDXy+hepIdiRfSGkvg07f+OMBmhLCJjYig45Tseq2No2d36zylFjOJcNpQvESBAOOYJ3XBJ0tZVj8fMq3n41TIBdTWP+DA++mUFl1Tf7mUe6adGxWZYvrBwX5mNzagu7HtyOParcy40mZOsUG2xZVMYfbN5mK4/aSL9m2cw1Kga/SK54insiK4jLMy9bItbiGQqGvQ87dw1VeXQJTD5+MZhjAzJFpnM8MKTxRNYUWvZOGTiKDpW2LnoizoHRbl/hrvIZvjYrNnsNUdJ2tYfRA/45xqoBR95x4ADAAhMDh8UVetEgElTz/FFXXZLlx+vVO/aaQsXmOEYhxoFhUjIGLWfE18gjRyOj0hEzjtw1QGjb2NeY6gAXg8NERqbEAKusPkWz7msIuWxd2YxVlZAntaBZlMkKEStNTzY4OAwPHp6teQ7Vm4hSRz7Uhh7F6GYJiwuMPYfmnrvOybkbP8ij3lIMycyPXz8NuEsIROTcs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(136003)(346002)(366004)(39860400002)(396003)(451199015)(54906003)(6916009)(31686004)(26005)(186003)(66946007)(8676002)(6486002)(66476007)(2616005)(478600001)(6512007)(66556008)(41300700001)(8936002)(5660300002)(83380400001)(4326008)(2906002)(316002)(6506007)(38100700002)(31696002)(86362001)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K2kwek5ieHczN2tGMXVBd2NlcE9lSitTS2poMEhVa05TZGZraFNNekVEditV?= =?utf-8?B?MnBoNm9FUVQvNlQ5empVdEszN09SdzAvSGhKSWNNeWNsVHVka1YvTDJvSnNJ?= =?utf-8?B?V2tTakZVL25Lb3dEbGJ4R2tiR2JGejIwMnVwSjZ3VGRsdGplRmNyYjF3aDBa?= =?utf-8?B?Z1Zsc1ljUUYrRmpDR2VUcUdzYXFpYTNzbjBGTGI3RXJlNGlWb0gvZmxBVk9M?= =?utf-8?B?WDA1OVo5Y2padWozclJxUHkxV0hueWpsdTBFcVg3TktDMmxQWFJoVUZ3WjZr?= =?utf-8?B?cUhyZzQxZ0F6SGptdjV5bi9rOXVpSUpaMllHVmNkYVJiSVpHVHZIa0ZFZkk1?= =?utf-8?B?QmxueExLVGlhZ1AxaXYvdTIvRFFiYmlCUjF0N3ZMRFJrODFJMXIxK2FRQXNY?= =?utf-8?B?ZngvV2NCYWZtQWl0UWNTVUUwL1doRjB0STM1MTZ0TlRHeDBjWGoxRGpvd2tX?= =?utf-8?B?L3o5Zm0xZ2hzYXg3dTJaQndvOEFwWWpzU1NJeXcxWHBXaG1hQ0dnbzJMMGlv?= =?utf-8?B?bEJIc2hVTm91a0FQSUs1KzV5Yi8wWDgrczdnUFhkZkJDQUpVV1JtVWRVbmln?= =?utf-8?B?UlJlQytzNEdJQUsyaHN0NXg2dG41cXY4M3czYnAzVzZ0OFpuUnNNb2VKdVc4?= =?utf-8?B?US9sSWZvdXJueURwdi95dDM5OGRDWkRzWHFlVHlEK3I4eFdDZTB2OWJPdlFL?= =?utf-8?B?b2xrSXcwY0lSZWYyeDZLbXh6dGJweTg3U3BIZXoyQUEyRlZzeVdrQUJRelBi?= =?utf-8?B?WGd2K3U1MFh6T0grb0VFRjh6R09md1dFb3d2YWhSU0NHV3QzQjJWbVBKNTVH?= =?utf-8?B?SUphdHZsNnluQjltODBaUmtHWi9SOG1nZDd0elNhenFlaWZtZHpyZitrMnVP?= =?utf-8?B?ZGxrRU9KL2ZJd0MyY0NjWnFuazhncU9CeEdBdWpTQmUrcTMxUEtyMTNOalJF?= =?utf-8?B?M0NhclpBM1QxbE9zZmFTS0FIejV5QkdQTGV1cEZWamZLOWNpQUtCUjgwTGdp?= =?utf-8?B?ZVF4L29QdHhDZVdRb2JTNHFVejAreXV0d1dLZXhtV25BT3NKV2s0NnhsUlUw?= =?utf-8?B?eGMxTG90RFBkd25NNGI2SzdnK00vL3hYMGE5U0h0STFub2lUV0lDeHZaT2hv?= =?utf-8?B?WE5mZ2ZFOXU2eUdOc2l0SVZCZWNZcjYyeGg5N3RzL0M2U3M0NlBneklBVEhs?= =?utf-8?B?Unc1cnVJVFAyQ2ErUnkrbXRTVzNsSEttVUNEWW8zbnMvczdDSEdCbEpRWklj?= =?utf-8?B?dDNzcEpnS2VVVjdGWlFXUFEwWDlXcTgyUXQvU2dhQkJoY28zcXVPVDZLRzdj?= =?utf-8?B?N0RZcnVDbWh0ZEc2UFh0cXZMR2k1ZEErMXZ0L2RoREQrSnZzS29VTVFVS1hu?= =?utf-8?B?eTJXck9DYTBXT2J3WkdoTjBMTkd4d1FqcUdXNnB5LzIzUmRxMGZYTm5UcTR3?= =?utf-8?B?dHA5cTRjRW1jRXNacVVoSHB4TE15YVROeGd3dVJYbk5OaFp1MWNJWkhqVlBu?= =?utf-8?B?Zlg1NEZacE9IVHllVElLa1duRlUzaEhQaU5pWno1ODhGOGEzVjNTZm5aeFlz?= =?utf-8?B?RkwwdGFERlN0RktnUUtQb2FKYUxqVTllMUtOcEo3VjZLMXRBZnBsTHA1dUpX?= =?utf-8?B?MTBwa0orWkZUVkJpWjM0THV4UkhnSjZ3NUxHSWIwSW9hNDIvRXFDRVVkeTlU?= =?utf-8?B?Vzg1UzVsb2xNVEFLMzByU2MzM2JqK3NkY0Y4bVJ0am1QUVFuSTBJWXNEZ2V0?= =?utf-8?B?dE1oUnNveWJ4V3F5RVYzVzlnVzVhZVh3ZmRUZVpyanQ3THVwRk9IZG00b1Uw?= =?utf-8?B?eTVMVE9CVUFrYm1vRFh2dEJUL3BSdFR2L09QWGVkZnArK0dEYUpraWpPRVUx?= =?utf-8?B?ejRJNHM4SEIyVmtub2s0YkxJenpuQkhFWTd3c2U0ZFhhb0lzV1lmdkxsbWdm?= =?utf-8?B?QjFvZTdsc1lBQThnNzJnalZiQ1JsbDg0M3ZsN096WWdoampneGtsdGFTeGl5?= =?utf-8?B?Q25pdmxLbEs0N3d1QWg0eVVLNHFxWkxEaGIvY0RSRm9qelE2MmlNdldObVVV?= =?utf-8?B?MUk2a29FOStpRkw0QnlXZVhBR3BuMFQ1bHZucy9rWGw4N0svNzEzMWRQSkor?= =?utf-8?Q?ijeNtPiyTDbDaQ7TftyWUyokf?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3af18b23-60d9-47d6-01bb-08daef36d320 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2023 16:06:37.6802 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: d54P2iPN7JaHNZZWMtCb08lWhqROSGJ6/zUqKXb7t54PlXli06etdxO9gupjKq5uyxcP6sjcp+wb4ne8smx/xg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9432 In both cases the "entry_pa != 0" check is redundant; storing 0 when the field already is 0 is quite fine. Move the cheaper remaining part first in sh_get_ref(). In sh_put_ref() convert the has-up-pointer check into an assertion (requiring the zero check to be retained there). Signed-off-by: Jan Beulich --- RFC: Strictly speaking accessing ->up ahead of checking that the type actually has an "up" pointer is UB, as only the last written field of a union may be read. But we have violations of this rule in many other places, so I guess we can assume to be okay-ish here as well. --- a/xen/arch/x86/mm/shadow/private.h +++ b/xen/arch/x86/mm/shadow/private.h @@ -586,9 +586,7 @@ static inline int sh_get_ref(struct doma sp->u.sh.count = nx; /* We remember the first shadow entry that points to each shadow. */ - if ( entry_pa != 0 - && sh_type_has_up_pointer(d, sp->u.sh.type) - && sp->up == 0 ) + if ( !sp->up && sh_type_has_up_pointer(d, sp->u.sh.type) ) sp->up = entry_pa; return 1; @@ -607,10 +605,11 @@ static inline void sh_put_ref(struct dom ASSERT(!(sp->count_info & PGC_count_mask)); /* If this is the entry in the up-pointer, remove it */ - if ( entry_pa != 0 - && sh_type_has_up_pointer(d, sp->u.sh.type) - && sp->up == entry_pa ) + if ( sp->up == entry_pa ) + { + ASSERT(!entry_pa || sh_type_has_up_pointer(d, sp->u.sh.type)); sp->up = 0; + } x = sp->u.sh.count; nx = x - 1; From xen-devel-bounces@lists.xenproject.org Thu Jan 05 16:07:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 16:07:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472049.732151 (Exim 4.92) (envelope-from ) id 1pDSlt-0006Sa-Q0; Thu, 05 Jan 2023 16:07:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472049.732151; Thu, 05 Jan 2023 16:07:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDSlt-0006ST-N6; Thu, 05 Jan 2023 16:07:13 +0000 Received: by outflank-mailman (input) for mailman id 472049; Thu, 05 Jan 2023 16:07:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDSls-0005kL-Au for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 16:07:12 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2083.outbound.protection.outlook.com [40.107.104.83]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 02f3f296-8d13-11ed-91b6-6bf2151ebd3b; Thu, 05 Jan 2023 17:07:11 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS1PR04MB9432.eurprd04.prod.outlook.com (2603:10a6:20b:4d8::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 16:07:10 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 16:07:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 02f3f296-8d13-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eWrIEqMbpyYPKBp72HL5f48dhXvraNwHfPslAXimjYCTBZdobp4Ly08KfFp8+86rDHZuJH8D+FLtd0bY6HUgytiWyUKZDRkef/IDjnHKv0i9hMDK/SpuwDnkf4oo3wANK9lxTXqDlssTOkNqzJcA8R/rF7xdshIloMMQ/FhjSb+KClg3LqisbR3tcYC0vCV6VQwhU+WeER1WFbNni/nkAKWLWpsKgnMKusAjHIssgr+9gipNzw9K6op3Y8LjuiarJpp+Sm20vTEaW6vD2tqXhsQ80rMjGZn7uC8c6MAY2US3Iy/mYk1hfdsj8zJrB61mXpjg14TuYfKl52QfolDC6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dOUOzfolYR+T2htvQf9ACsmsUnGdPR9fDgi+OoWIHI0=; b=Wg+B8UTW5zEDkrK57UooT4YDqKkAAv9kO63FjwiESgumJVqxqnNo3eEzJ9B/mYrN6R1S/gM6K9xJjZkIGziH6YhAc/tSyWzMccv85knW/mHkKMOLt6iLFLd85vGErOjSTq2Xv5PpPqyrHYgqojo237s7mIQO4LgTZaP5XjyY1Kpz/SbA57IooXFeoWF9oKx74+DL5KqKYVX1ofhnYp9qJ6HHLi2nS7kmmiMu1rSaowgpBu1PUAK2awRyDjAwyg9mQOkbiIVI9GbhU4P3xhxhNlYIcpPRl1JOh1QYaaqtDO1DqSrckrU4snjIbTpRxDRZGap5dAYfTItR5uyk/QOofw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dOUOzfolYR+T2htvQf9ACsmsUnGdPR9fDgi+OoWIHI0=; b=z17qbJaR+U8+QysUbU2feN+Njj0RrcgbeisU+ko/35QZqOwpFkiT9t78+nxfwEVfst1RaZWU2eJZ2SIJUjzwK8rVpaH+NRXIq45ikCbXnaNzD8QEQ3NUmk4YOG0A6TguLDGKFMlKyoPbk3AmAK+kZsdYcB2438bw0kLRM/VQ9zRlw9GL4G7/yHBwoWZ0W/+T+XKEySu9UBJtIdCbrcn3FJxjt1stSI0R2ApWpfKXe2abgDA/smY/tymzlbcOIUvjV6SfzoVi3HUO48OcolUr4vGCEcmMY74e487DfJRhTQckQ27t0t+0zdeONLJ2yI0hUIz50R/MOoSn97nGltfxCQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <8f19a31a-9bc3-4216-db1c-a9732c6363a7@suse.com> Date: Thu, 5 Jan 2023 17:07:08 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: [PATCH 10/11] x86/shadow: correct shadow type bounds checks Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Tim Deegan , George Dunlap References: <074dc3bb-6057-4f61-d516-d0fe3551165c@suse.com> In-Reply-To: <074dc3bb-6057-4f61-d516-d0fe3551165c@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0140.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9e::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS1PR04MB9432:EE_ X-MS-Office365-Filtering-Correlation-Id: d8c9e9b9-d8ec-4bc1-7e89-08daef36e670 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uoCWZDymnphVsFDawywMhEmu+1148SzShYbJBzyY4dG9y15rG8F4xDSzzhcSV2MKJd1h6sOvHivuv+3LbaScO8YJGiABJoRJgvAZJtFKnP/93F1uSlfNaD3TZlMv/OfMueNfBov+NJnhB82JvtBwJE6UV1Goatemfr+1YttvM+Y6VTbPsRYAKb4yfSN0QXwRxV+AegTiTWfLo7TJxqM6eyN15eMorLMlHQ/7h71dNgJVum/dyg4JbJ/YGx8mzl/foR4bu8EPw2JENCkyvQmnFkRGeZw/uEIjQXcqCjSWyVcpQFS/wkghD4gfCqVHOFXb3bdVnaYJovPjnano0mWt2sYpNKLsrt5Wk4TAMkDV1gGYntq/XjoEHcwzCvK2poQLlW+dqUpGXAcRqzOWdIZ/RDseNF7krUcT8FSlrWm6CTemNmxv13cRDdtdJD49Mpz/Glio27umvYwMsAy1V2+z/7LsRfeD/FKPNMlp7ZJuNVgDZDLwTcHLFPqyJ6g8Bl50wKZLvQJNZTAZSKOubcBJuIEeUHkUPehR3IQ7aOREPEl17KEkpQDLylPNc3Cy8p1PZMskEY7nN/q6XsLHfS93sGbjSNrMXlsKHOXbarLQB66opW7M9b8bXyDy8w5eSShTnBAFSCzOf1iFeh3ReU9NlnykkHeRit6oMmvGm/3NsNO0IAHvAK8f8VJILbjm1ph8eJqMS2q5T6TC9oCZB8QeyV7Gc11xL1jqj53cK52CdYE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(136003)(346002)(366004)(39860400002)(396003)(451199015)(54906003)(6916009)(31686004)(26005)(186003)(66946007)(8676002)(6486002)(66476007)(2616005)(478600001)(6512007)(66556008)(41300700001)(8936002)(5660300002)(83380400001)(4326008)(2906002)(316002)(6506007)(38100700002)(31696002)(86362001)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a1FSNVRHQUlsdDVxdWdybk1xUjhBd28xK2ZFNnFwN0JHWXVON2w4RitYcEc0?= =?utf-8?B?cWZXbnZ4cERLaFJQaUZYRklvbWY5UFM1TUU3UVNMYitzWlV0aW9jWmJRZXJU?= =?utf-8?B?RkVMTWVlLzRRNFQwbzEwN3pOSlZBZDVDckN5T0NXOW9yQzMwMW9GNXFSQ1hP?= =?utf-8?B?cTlaM2k5TlNWclJsVUZnUWp0czN2YVNOdnZnSE5QZ1NJaHYvcFdGMjdtcHRy?= =?utf-8?B?YjIyTngvSFVPTy91M1NhMWw4VWt0TTZYdHh3Y0NpakFGSUI5b0pOMU5aMzJR?= =?utf-8?B?d1RkcVUycFhSZkdOc0UyeUdMcTM4TTR4VTlkNmNzUHRqeEtXd0NwdVpRLy9p?= =?utf-8?B?TWtKZDVBQ1RzazFpZkt1bGpOdlQ1SnlZUnp4TkRTemxybTNhY29wY0tiekRi?= =?utf-8?B?Y2ZJUjVjNFk5RzBSSTdBQ0dwRFhKazlkQ0hzYXBVeWVpamdzVjRnT29ESEM4?= =?utf-8?B?N0tPZDVwaCtRbmRIUlVaVXhSeEtlc3I4eWFlTXpCODRhMjZhMGU5YXB2WmRW?= =?utf-8?B?VkdtNnk5UjRuSDV2aGdUMWtyVDU3cjhVVzVjQ1RrZkpNSnFkNi8zR2JtNmd1?= =?utf-8?B?bUtIY2w1ZGt2bmZTRlowQmJEUE1FNGQ1ZDM0N0kvWldoSW9VUU1ZTWlvNSti?= =?utf-8?B?RHhKRisySS9zYjBjb2krREdseGNkWE5odTN0eXZ0WDVTNit2WFlCL2U4c3JJ?= =?utf-8?B?WHZRQi9HdjQyZWYrV2crOHRUUjRvRHZ6VVFyekEwdVpnNzQwQlU1ZEpndzFn?= =?utf-8?B?STc2RWFhc2kwQnpwUnA1RXNrdEVFbWpYcHNuQ1pVc01ESFhHbGlZM0ZUV3Bu?= =?utf-8?B?S2xycUFkZm91akJvUWZTVjlKWC9xdE1reHhmYkdXQUFkTnVTc05mUFV1NVp1?= =?utf-8?B?OVpjZWtpOFdCOHYzWUlyV2RJOGJaZkpLRmRSRXY4aWQ5dVZTME5nNFlOd2lM?= =?utf-8?B?VHZVOXV0VXN6cERSbU5FdnZRaUdlSGdLeForK2VacCtKdUVxeUdEOWlEZk5y?= =?utf-8?B?Z0MyKzNXemdYcjA2Qk1JbWdkL0xXQ01NenhlNzIxZ08zb0JKWkdkWkN6b0do?= =?utf-8?B?NTZwSnY3a3pLVFpwcEEzc1VtYWx4UUJvR0htSHBBSnB3WXptK0lGWXZyQTZw?= =?utf-8?B?NUp3MWFJSFRGdG5mVkQ2WWZrWTQ5RWpGTHgyTGFrTHYzZWQwSDJvTjFZN09s?= =?utf-8?B?UVorTmg0MWZhY1h6SFRtSFFNUUVIWDFEc1o4M055dHIwUDl1R0JxZHZTSUNu?= =?utf-8?B?dmhuV3p4eGlFTXVFS3p5Zmd4cDZMTXlGNDBuRnBPNjE2MTFkcm92Uzl1azdH?= =?utf-8?B?Unp3TStRc2ZKSkl3bFlPaU1tRDdmWGtPaVdudDg2N3ZQSVhUNzBmem9OTUFy?= =?utf-8?B?dEpZazhnOTY3ZWp2Rm1UNjBNRW5oVkU0aUhNTTk4L05KSDJEa3dHUFdBMmtF?= =?utf-8?B?RW5JSFRWaDJDODVhQ0Q5YmhvU0RITEpWTEwyL2JocU5Sc1Bkdkx4QkpmOFUv?= =?utf-8?B?NXhjUkYxOWZGaVpidVh4NUliZG1MVE12ajQ4T2tKbWZlWUQreWFPeWU0RXpW?= =?utf-8?B?QlB3YU5PNlJoUEhDQlAzRHdWN01lYllMWGgrMHRZSzNMeVVTZmhVT0xkdWxv?= =?utf-8?B?eEVBelhPODg0TllhZTVIaGNodS9yQjJFWHA0eVpLcnBnbThCU290VjVWTldN?= =?utf-8?B?M2htZ29xZCtnYmlqRWtMTmZBWmFFNTk3TXFRNERTUHdXOUszajlQcXhwWGRp?= =?utf-8?B?MVpmbEFZS1Z4UklFR3FPOEpNMlJreE5DcHh3QWp6MHNacW5NUk1lQXVtN29l?= =?utf-8?B?aDFWUWVoTmRoR3dRclUvNE9QQW16eElzZXNFMW1vZmZISHJKeU9oSm5aUVJ6?= =?utf-8?B?a1I3dTZVUFpvVmptK0tFY1gxc2RJdEtDQUlTbFFaM2lRVXl2VXJJdjdLS2FB?= =?utf-8?B?UzdOY0t1YTNiWFlRZTlQeWdzU2lSdUo1Z1JicTF2Wnc4elIyNUgydDZIZzA5?= =?utf-8?B?RUhtVWQ0ZEFEeTZ5NXZkSk9US1R3OFlGa1c0ZmN0MWZSRDlPNE1YOC9xOEFT?= =?utf-8?B?RnFVVnhiR281VFJ3dWJvc1pYK1YrV2dub1NzVmVWUmJSem1UZmQ2ZXg0VG03?= =?utf-8?Q?yGiOi2clw0uO6+QEgU4zWerct?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d8c9e9b9-d8ec-4bc1-7e89-08daef36e670 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2023 16:07:10.0844 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hi+aiyZkAnzOe+vVp5V3J33MF6OzPz4oNZn4SK2QzVZAReP/4NcmxZMlaU5qpgNmIKVGfGtlI4Pec9sF9ktW3g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9432 In sh_remove_shadow_via_pointer() the type range checks, besides being bogus (should be ">= min && <= max"), are fully redundant with the has- up-pointer assertion. In sh_hash_audit_bucket() properly use "min" instead of assuming a certain order of type numbers. Signed-off-by: Jan Beulich --- While style is wrong for the BUG_ON(), keep that aspect as is because of all the neighboring ones. --- a/xen/arch/x86/mm/shadow/common.c +++ b/xen/arch/x86/mm/shadow/common.c @@ -1425,7 +1425,7 @@ static void sh_hash_audit_bucket(struct /* Not a shadow? */ BUG_ON( (sp->count_info & PGC_count_mask )!= 0 ) ; /* Bogus type? */ - BUG_ON( sp->u.sh.type == 0 ); + BUG_ON( sp->u.sh.type < SH_type_min_shadow ); BUG_ON( sp->u.sh.type > SH_type_max_shadow ); /* Wrong page of a multi-page shadow? */ BUG_ON( !sp->u.sh.head ); @@ -2077,8 +2077,6 @@ static int sh_remove_shadow_via_pointer( l1_pgentry_t *vaddr; int rc; - ASSERT(sp->u.sh.type > 0); - ASSERT(sp->u.sh.type < SH_type_max_shadow); ASSERT(sh_type_has_up_pointer(d, sp->u.sh.type)); if (sp->up == 0) return 0; From xen-devel-bounces@lists.xenproject.org Thu Jan 05 16:07:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 16:07:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472056.732162 (Exim 4.92) (envelope-from ) id 1pDSmT-00076W-8T; Thu, 05 Jan 2023 16:07:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472056.732162; Thu, 05 Jan 2023 16:07:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDSmT-00076P-4f; Thu, 05 Jan 2023 16:07:49 +0000 Received: by outflank-mailman (input) for mailman id 472056; Thu, 05 Jan 2023 16:07:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDSmR-0005kL-Ss for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 16:07:48 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2067.outbound.protection.outlook.com [40.107.104.67]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1833933e-8d13-11ed-91b6-6bf2151ebd3b; Thu, 05 Jan 2023 17:07:47 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9326.eurprd04.prod.outlook.com (2603:10a6:102:2b8::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 16:07:46 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 16:07:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1833933e-8d13-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mkvHJGOSyTC+uh7KK9yKtwXtD4wBCxEwOJlMnqQSu0uq0g5kEhJP33TmxQx5ZLAnAeh6eKMBP8hBcNSTnA/eZVd/yyV3iemh/pZwK6bnI2twKpzn7b32ohBawSvYYc4UnmfWnUz27Nzz2BDbcL8G2jDbJaJsJQuPb12RU65DEoGBTi9/CfUPELl7bwhceZIxHT9fU27AE5/kA35CjnzJck9pIgGo3oeYYH54JXjMoweMBO0dHVZ2EFzrWU8fMFJlV44FgMt2Rrbu3UCpLjHjdf0xqXiAY5qraRKvwzLyhOFQzmLKAJWlanwHq4l3qg+nTh72XW5Fall2qvwOn3q7ZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rkzMWSo4VP4iVpCTjNCVb8H5HyGWrBz+Rgr5MlOxOXI=; b=idd6L6FpiU/2DvabEp8/JucIpXyj+UvQJxZXHrqG/WXbSXT9xPtk7rEb5jzkr195Ly6+1lr8bFzLvTCI1VZ69bb5UHy79RAf183moAqy81GH80ZoDksquItCilhSiaff6AJva41BfQC02vmNgHcgXgTnQs/Ix6YXRAZMblcLBc7ttkVfjOxq2nows5tv38cD0Cd8xbn+yoTjFimuTr2h4ox/Ai35saWHLWVawU9qIG1JQh66TeQNMFtZmW5QebKq8kwJrexAAmq7997yp+Tc9sGIWDyfJGuo3/WhuDRlw2JvHw7F18Y3klQU7YfAZygcEe6sOj5PSwXVAn30LnXNtw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rkzMWSo4VP4iVpCTjNCVb8H5HyGWrBz+Rgr5MlOxOXI=; b=gQz6yA5sZHFf4Twv/F1LXZxXucKEh3yRKR3vYxJ78t+WO8OlSBTxbPMiKzC+9KAFJoXSFDWSPtnYjmazJ5cDfynhBBUDQx1W1lEB0LNXzNVhbhF9l6Ga3vfFUEoL+P/PW8hNPQ6/uYSpJrETfq8Lmw29avdvD1RqbsIpRFXUCfaOU1GJeM+m12mLSiiLKW6TMJM9zyUPxPM1fv2FNhXKzt9fU4/I6wKHsaGiyDpXzodcUG1B/4KxOoyfjZ4xkMzPT6PienCcRRuQcIbZ3w+6/wonafpQ2PT2Snu/4bQRhUrBtYo4hzLioSz0YjYUuy9qB4zEYJBUYX1PR/yZh4Q12Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <514f374d-daa0-ddc0-8cdf-9dfd014d508b@suse.com> Date: Thu, 5 Jan 2023 17:07:44 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: [PATCH 11/11] x86/shadow: sh_remove_all_mappings() is HVM-only Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Tim Deegan , George Dunlap References: <074dc3bb-6057-4f61-d516-d0fe3551165c@suse.com> In-Reply-To: <074dc3bb-6057-4f61-d516-d0fe3551165c@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0070.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::22) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9326:EE_ X-MS-Office365-Filtering-Correlation-Id: 3a50beb0-154a-425f-3cd2-08daef36fbd2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3UX9Gb8wOQdYBNL9QMEEOh/S1m4Gqp6MVJVEmW5FkJ4v1Yw6hcrzEQ2bc6lLbB8jlHJwIOV/MvG/aHVvOpnANkCw+NvZYH1WY/cFVNstBkFx2NAD9t4g7hturD5hrjbDW+3LEc56WRnHhhBlkBKV2Mv1jOuZXRYJRLHx6eMigYrkhqQzQw1qeUn+uy63WtgvbqSNpj7XwdyyT2/UrV0FElj7qvgmPP0nFgiTvM9UtqgzGyDeHpFDBT6qGPKmh6PYmYLDnBjd/YxG/UuPuGKcASoDp8xWkp5eCA8yhDiUYjmglusPifgnXBE2IRNF9VFz88w8LjMk027+RqhW4Krd6VR/APKXFGwhvd3PMK6PxFGDbhttPAGTL0cEUX0sULKYp6fH46ctayr3I/46WmDvrcAwe3X5Yh9MVHBB9LIAZapfJaSJLNxfhn3ZKcP0q/Or0LfuPljDkaWweHXCP23z1JhgpOgPH0Gjxsu3e7yoYATC6w//88r/2q5N+mgiZRK1LDyCkPuRoXmd2wyEkIpDJb7/1qXtvPd2ggvbyzNWUcYXfWCNQwNnlGTX6aGcew+1JgOleoEQEHpw0Yw49M/hAxYjDrQShvy8m+3JEElbNWpWtnlOqyVrRQnyaIuf1u6ZSKYjZzlPplgA2+iHFUXmz0h5qU07IWapG/OslnwmCGI1mo8VE0tsVoei9OI1KR438XKYS1QJcVLiy+Olm2AD4pNbxAf9uheuxKCLcsJ0+JA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(376002)(136003)(39860400002)(396003)(366004)(451199015)(186003)(26005)(2616005)(83380400001)(86362001)(31696002)(36756003)(6512007)(38100700002)(316002)(66556008)(31686004)(54906003)(6916009)(2906002)(4326008)(66946007)(8936002)(41300700001)(8676002)(5660300002)(66476007)(478600001)(6486002)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R05veldYdGltS2N2aEd0NE4rY2tnRzBuMFBZZVZXVTJIampqMHRtL0Y3RjJv?= =?utf-8?B?MVBFU05QcjBUajdPOWx1ZGtJZEM2MFN5RFUwVGxrRWVmaTFCZm5VeUdDeCtj?= =?utf-8?B?TzJQeWlobkFhRFhTQTdwUjc5NzJNNEp4OW5YREs1a2x0elhFWCtlUmg2aTNY?= =?utf-8?B?YkJVYklnM3NzazVzV1VTNkhxSk5wbkJRbDM1K0pDUmZ4aytUNVM3NTcyaE5M?= =?utf-8?B?cE9aeDNLVk9ncjJFekwrZXAvSWJseHIxeEd1OUhjbmRrcGhNS2N0aC9HTjF5?= =?utf-8?B?R2hHcjJWUmlXV2U0OUtrMUp2cHBuNHZ4RmZGTzJPNE5GR3NDM2xjU0lYeWxD?= =?utf-8?B?RWhpVVVuaEFSY3RTRTFBMXZiSnRSSGp3ZXRWZnNMYmtVRVRRTmN0cUxmOGpz?= =?utf-8?B?dzJhY0FIaXJocFExaWNadjhIa3IvZnJOQmRPaTM4N2hEc1BMeDVxaGM4elVs?= =?utf-8?B?UDdlNTBtWk9lbCs4NjM1V3d3NkVBWE1LWVRXUjRhUTZrWmZEV3k2eEErZy9H?= =?utf-8?B?TlpwU0dVVWtYa2ZzMWlOT3R1NEhaa0JZYUpicWdoakFpMm9lNE01bzBncW84?= =?utf-8?B?dHFRQnozaFJ2R0s2QXY3UTJRR295WFVRQ29ZRStlTVQzbHNuUXh2SDkybDJM?= =?utf-8?B?ZFJNek9semszRWxrbjF2YjZDVElKN2k0Y1g1STROci9aaEFqVDV2eGlsRzBM?= =?utf-8?B?alJxNGhTd0ZvdkdzbFc1ckRQVWhnQ1N0VFBFU0RDT0RONmxaVzZIM3F3V2th?= =?utf-8?B?c3dob0JGRHBJY2tGZ0JVdWQ0Q3pzZ01zMHlDSVV6Sk11S2dXNnJQbkJYeXRz?= =?utf-8?B?SGNjWTU4bHdVejU5bWVaeXV2eENiRlVxUjVqbndSRXNib2s0YW9lYlJRL1ZC?= =?utf-8?B?QktvZzZraWtzRmdhRHlzU09BM3p3bThJbDhHQy9JOUFnZzk3ZjF2czlMSEM0?= =?utf-8?B?eTA2ZjlZRW5XUDYyRDZPdjlONEcwaFFVL3AveXVTSjZ3MWNnd3NhbFM5aEJj?= =?utf-8?B?ektNTWl1V0kwY1lRV3FycmlzUS9oSnBOMGkzVncybWhzeVRyQUJ1cVVvUHgx?= =?utf-8?B?dXRWdWthVkkwQkdmUmM0VTQwYXo4cnowRUFLNWxqb3U3Uk4yOWJCd1hMSXhT?= =?utf-8?B?V2RBWXZWQjEyaFpmWEpNTm4yazhqbEs4YVo5RG5US1ByVm9vU2pmOUduMDhN?= =?utf-8?B?R29SNHpETDh5NHNNT1dSZlZGRnpITjVZRUxZd2NHcjFjaTk1NnhPeTVwdkYv?= =?utf-8?B?WUthWHUyR0pzRWxtbzRJMXQwSTlNMkdRR1JkSzhJeWpHdzRJTW1IRGhEdmU2?= =?utf-8?B?U1lLVmx6YWdlU3MxL2NvdXozb3loWmpKL1hBZUEwS2F6VGl0M2N4aFplbmox?= =?utf-8?B?NmdrSTJpNjJYbEJCUFRLNjdEOWp5ejF3TWF6czJEZUVCNHRpazBaWi9jbTJl?= =?utf-8?B?dHpNMVltYisvZHZNR2lQY3AwQWp4TjhIWWNhYnZ0QVV0ZVIvU2l2YjR2K2Fh?= =?utf-8?B?WjllVjVqaTRTcndEUVBmTmJiS1BBVEFxLzN2Y3lFYkVLY1M0SVlpb2RUZXIv?= =?utf-8?B?a0FKZFFOa3lwa0NWZVp5RGJhL3VhODJvaU1lU3p3cHd3YWJFNkJIRWdRWHgz?= =?utf-8?B?TS9WUFBwZms1U2swL2V4R0h4S21lTjRjdUNGcHJCVWhvOGZJc216NW9ZV3lH?= =?utf-8?B?N2NtVlFHekMxRVRKRUpkM3NocW8yTStQNWVSSm9jTTZpMXhPQ0ZlSkpDS1pm?= =?utf-8?B?RkdqV2VZeDFOZmpNOFBOZVlFNmxObHc2ZWxJTGlDSjZFeUlKVmxVTHBOTFFI?= =?utf-8?B?NXZXRnU5eUlHOEEvZyt1TWM5VTFDdk9GMW4wSkxqMXg4cUZyL0VWQzBGWDE5?= =?utf-8?B?NE9tc2VRNjY1WWkwcC9VcGxSVmxrL2xPNVc5WmxsNFA5YlRId1JoVENydFNk?= =?utf-8?B?OVJTZjBKUDhVY0EvbCtpZWtMMlpVOXhncXRkMnFwL0RBb201R2FPcmFvUXJi?= =?utf-8?B?QUtkR043VUNnMlRwanh2OFQ2ZTlCZXhWODg5MUhTUnc1Z3FnMm1TUGV3RWdQ?= =?utf-8?B?Y2RJdWJDdE9Xc2F3c0t6WHlyVll4eFQxbGRiK1ZLT2x4MGpWZjg1alZHSGJp?= =?utf-8?Q?IH31xceya9dKIixK+0UWJGd2v?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3a50beb0-154a-425f-3cd2-08daef36fbd2 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2023 16:07:45.9884 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: A9Kk2GnJgQoXn6o5Aw5NeB4cTtB+/9ZszHm7RsREp/286bWoi2PaoGWsz28cy/lSyRECxe8zOeimWxZIkK2dDg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9326 All callers live in hvm.c. Moving the function there is undesirable, as hash walking is local to common.c and probably better remains so. Hence move an #endif, allowing to drop an #ifdef. Signed-off-by: Jan Beulich --- a/xen/arch/x86/mm/shadow/common.c +++ b/xen/arch/x86/mm/shadow/common.c @@ -1992,7 +1992,6 @@ int sh_remove_write_access(struct domain /* We killed at least one writeable mapping, so must flush TLBs. */ return 1; } -#endif /* CONFIG_HVM */ /**************************************************************************/ /* Remove all mappings of a guest frame from the shadow tables. @@ -2004,12 +2003,10 @@ int sh_remove_all_mappings(struct domain /* Dispatch table for getting per-type functions */ static const hash_callback_t callbacks[SH_type_unused] = { -#ifdef CONFIG_HVM [SH_type_l1_32_shadow] = SHADOW_INTERNAL_NAME(sh_rm_mappings_from_l1, 2), [SH_type_fl1_32_shadow] = SHADOW_INTERNAL_NAME(sh_rm_mappings_from_l1, 2), [SH_type_l1_pae_shadow] = SHADOW_INTERNAL_NAME(sh_rm_mappings_from_l1, 3), [SH_type_fl1_pae_shadow] = SHADOW_INTERNAL_NAME(sh_rm_mappings_from_l1, 3), -#endif [SH_type_l1_64_shadow] = SHADOW_INTERNAL_NAME(sh_rm_mappings_from_l1, 4), [SH_type_fl1_64_shadow] = SHADOW_INTERNAL_NAME(sh_rm_mappings_from_l1, 4), }; @@ -2064,6 +2061,7 @@ int sh_remove_all_mappings(struct domain return 1; } +#endif /* CONFIG_HVM */ /**************************************************************************/ /* Remove all shadows of a guest frame from the shadow tables */ From xen-devel-bounces@lists.xenproject.org Thu Jan 05 16:10:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 16:10:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472065.732173 (Exim 4.92) (envelope-from ) id 1pDSpJ-0000Cn-Lo; Thu, 05 Jan 2023 16:10:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472065.732173; Thu, 05 Jan 2023 16:10:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDSpJ-0000Cg-Iq; Thu, 05 Jan 2023 16:10:45 +0000 Received: by outflank-mailman (input) for mailman id 472065; Thu, 05 Jan 2023 16:10:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDSpH-0000Ca-Uv for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 16:10:44 +0000 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [2a00:1450:4864:20::332]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 80764ce5-8d13-11ed-b8d0-410ff93cb8f0; Thu, 05 Jan 2023 17:10:41 +0100 (CET) Received: by mail-wm1-x332.google.com with SMTP id m26-20020a05600c3b1a00b003d9811fcaafso1696015wms.5 for ; Thu, 05 Jan 2023 08:10:41 -0800 (PST) Received: from [192.168.0.145] ([195.234.76.149]) by smtp.gmail.com with ESMTPSA id iv14-20020a05600c548e00b003b47b80cec3sm3319613wmb.42.2023.01.05.08.10.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Jan 2023 08:10:41 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 80764ce5-8d13-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=Y5mKZv7OSvb+gUvfokTjsdLcRFx1w454ZQ5fGUDCzkc=; b=mLRGhG4N2khtiYCt0m2gljJKvR5S6u3EOJQNLukMupFWL7inRHP+h85SmPZUph10lg JWM56s82st49lZEq075Jb0l+VN/hZ969l/j9iPFwgWK8g10kROhPQ97LUUmCZOnh2ZVu W7SZglo/H6cwoCZa9AdqS4Z+mfSRHowsFEk/Ou2ET7VPDfGRom799hoxNejczlyEy02S 05FBdnuzRc8ZyVbxIKDufDdtCm2fJbvZlqgQafVlJxiqW1+JJV0iDPVXiO+KjcFVeafP cSEq5202DsNMb2yuEZ2PKmFxdJPjP9/EuxjuHr2QPPpPqWxb/BIHOokQ+QfFv0bRagCB XktQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Y5mKZv7OSvb+gUvfokTjsdLcRFx1w454ZQ5fGUDCzkc=; b=4WFarSJpmF/Mh/Nd1ORHKK9OZ6+/htwi7oge25C5u1bF9JHMQ2lDes0EyGANvJRn68 zWKviIJ49UtEyE6+OgA+3CububWDYSQOcDvtFsVGq5VcKmfL9S1aa8hqOF+r5KufoSrq cUXteQ8BMFUELjKLToB+a3neQjNPKWAd7bGdz2QHs1oaDsTZt/+3JofFugCJabJJYXdF Cm26EdQGVROGUpHZ8mkXkJkzDzZkHQTCkuQv+MwNtkgmaLwxm+vsO3KSezvddVCSpsCI pBuahWVMk43unNRqSNcxxKc3+60cijdcJf9O8YvYzfXvTw3K5Zj2vXbCzjobrBSfRJFh eX9w== X-Gm-Message-State: AFqh2kr7ErHVVdp5ra7YCjBYznoUfI4oH+UYapWHJUxEBdulVRcv2l1M 3SKriAP84+0IOI9ZUisOrTs= X-Google-Smtp-Source: AMrXdXt8/5c0/IzSkBmxdpQks124bU7k/ld+ca9ksdm1QYFSy+VyjzGBbu+UMDMdaO2U0KjQrHm05A== X-Received: by 2002:a05:600c:4da2:b0:3d2:39dc:f50e with SMTP id v34-20020a05600c4da200b003d239dcf50emr36630874wmp.7.1672935041317; Thu, 05 Jan 2023 08:10:41 -0800 (PST) Message-ID: <439a5b7624dbf4d4ff6acbb9b3a6f15b777ba0fc.camel@gmail.com> Subject: Re: [PATCH v4 1/2] arch/riscv: initial RISC-V support to build/run minimal Xen From: Oleksii To: Andrew Cooper , Jan Beulich Cc: Bob Eshleman , Alistair Francis , Connor Davis , Julien Grall , Anthony Perard , Stefano Stabellini , Gianluca Guida , "xen-devel@lists.xenproject.org" Date: Thu, 05 Jan 2023 18:10:39 +0200 In-Reply-To: <01888162-49fb-a280-a088-5e81edff3919@citrix.com> References: <591d6624-2bd2-93f0-f5d6-760043230756@suse.com> <01888162-49fb-a280-a088-5e81edff3919@citrix.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.1 (3.46.1-1.fc37) MIME-Version: 1.0 On Thu, 2023-01-05 at 15:48 +0000, Andrew Cooper wrote: > On 05/01/2023 1:40 pm, Jan Beulich wrote: > > On 05.01.2023 13:01, Oleksii Kurochko wrote: > > > To run in debug mode should be done the following instructions: > > > =C2=A0$ qemu-system-riscv64 -M virt -smp 1 -nographic -m 2g \ > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 -kernel xen/xen -s -S > > > =C2=A0# In separate terminal: > > > =C2=A0$ riscv64-buildroot-linux-gnu-gdb > > > =C2=A0$ target remote :1234 > > > =C2=A0$ add-symbol-file /xen/xen-syms 0x80200000 > > > =C2=A0$ hb *0x80200000 > > > =C2=A0$ c # it should stop at instruction j 0x80200000 > > This suggests to me that Xen is meant to run at VA 0x80200000, > > whereas ... > >=20 > > > --- a/xen/arch/riscv/include/asm/config.h > > > +++ b/xen/arch/riscv/include/asm/config.h > > > @@ -1,6 +1,9 @@ > > > =C2=A0#ifndef __RISCV_CONFIG_H__ > > > =C2=A0#define __RISCV_CONFIG_H__ > > > =C2=A0 > > > +#include > > > +#include > > > + > > > =C2=A0#if defined(CONFIG_RISCV_64) > > > =C2=A0# define LONG_BYTEORDER 3 > > > =C2=A0# define ELFSIZE 64 > > > @@ -28,7 +31,7 @@ > > > =C2=A0 > > > =C2=A0/* Linkage for RISCV */ > > > =C2=A0#ifdef __ASSEMBLY__ > > > -#define ALIGN .align 2 > > > +#define ALIGN .align 4 > > > =C2=A0 > > > =C2=A0#define ENTRY(name)=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \ > > > =C2=A0=C2=A0 .globl name;=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 \ > > > @@ -36,6 +39,10 @@ > > > =C2=A0=C2=A0 name: > > > =C2=A0#endif > > > =C2=A0 > > > +#define XEN_VIRT_START=C2=A0 _AT(UL, 0x00200000) > > ... here you specify a much lower address (and to be honest even > > 0x80200000 > > looks pretty low to me for 64-bit, and perhaps even for 32-bit). > > Could you > > clarify what the plans here are? Maybe this is merely a temporary > > thing, > > but not called out as such? >=20 > It's stale from v1 which had: >=20 > #define XEN_VIRT_START=C2=A0 0x80200000 >=20 >=20 > But honestly, I don't think the qemu details in the commit message > are > useful.=C2=A0 This series is just about making "make build" work. >=20 > The next series (being worked on, but not posted yet) is only a few > patches and gets a full Gitlab CI smoke test, at which point the > smoke > test shell script is the reference for how to invoke qemu. >=20 >=20 > I'm happy to R-by this series and drop that part of the commit > message > on commit. >=20 I'm happy with that. Thanks. > ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Jan 05 16:24:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 16:24:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472072.732184 (Exim 4.92) (envelope-from ) id 1pDT2Q-0001l9-R2; Thu, 05 Jan 2023 16:24:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472072.732184; Thu, 05 Jan 2023 16:24:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDT2Q-0001l2-OF; Thu, 05 Jan 2023 16:24:18 +0000 Received: by outflank-mailman (input) for mailman id 472072; Thu, 05 Jan 2023 16:24:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDT2P-0001kw-Ml for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 16:24:17 +0000 Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [2a00:1450:4864:20::233]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 65e22e20-8d15-11ed-91b6-6bf2151ebd3b; Thu, 05 Jan 2023 17:24:16 +0100 (CET) Received: by mail-lj1-x233.google.com with SMTP id bn6so29248242ljb.13 for ; Thu, 05 Jan 2023 08:24:16 -0800 (PST) Received: from [192.168.0.145] ([195.234.76.149]) by smtp.gmail.com with ESMTPSA id u21-20020a05651c131500b0027ff16ee6b9sm1010127lja.8.2023.01.05.08.24.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Jan 2023 08:24:15 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 65e22e20-8d15-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=Hh6raYC8+4X6HbqN1scrKnswGRbcSCRlzyoPUATYkiQ=; b=JxR1FSzr+zAv/aJQSWZfHNwfhtqy3BDEW+N4+snt13MYz0y9DHpP1P9P60PjcVe6cx KyAEGoKKa3AXdclQrtQL5BDxwIN8IPfYJPORe5vr6x8P8LQfA7Gmk/CBYpjarHb27G6H L2ESsZK88KNHUCmSiLWTjNcSe5nNNCVzBVE55Kh+VHUJcxiK+9FzdkD6JJu2GgM/nL95 6zQa5ZDSxnMWCmHY8hSG0vIdGsf37+OcoWisHrijns1iS9UPJpYgJPW8ECjXviMhhCL9 B2Gvjj306wJMEhPhN+ksBNYYOXwPIxXfBE5oMp0BU+AVIzC3iGHzzPpitjc6k61K771L pizQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Hh6raYC8+4X6HbqN1scrKnswGRbcSCRlzyoPUATYkiQ=; b=4JkEL/Wy7vokr+RXdLEWOiqynbCPk5H+oSARI6au4shF5mf9fTjFXj2hLhFhvv9w0i HJ2/KPmqGxpX2mIzqPZNcMVd72cPxRT1bpOHOS2UtIqc9pCBkdUGqGrste11OdZijKKm g4QmhjJ1sbLP93QrsKELH98bmOKlkChXlq4/MUk3EcU6E3h4x4pY6t8AjoqK87IqCQ6Y 8Cs1mH/4rJa7sHGIlrJfo06pjPda44RrTRYoYS5+vnwfJUqGJMbV90Jbf+HA2XZgqgnV hT9SFYCm769q0nqsjOIH3/Qkmu1mR0uT1ROMPv8nV+q+I+4K2uURTDonRksv92HvgLou blgw== X-Gm-Message-State: AFqh2kpJIjS2NG757xNcioSMETWlAhXtWGtP07PtUOsrv5WKjHcRtDgp LhmYb+dST6ql9W/Efb7YxUg= X-Google-Smtp-Source: AMrXdXvi2omhnfUo0JZk87iT+w5i+GcD8PntMwGT3VUk03/GCBWvj0UWx+NPLl+zhCHOz51rQIUJIA== X-Received: by 2002:a2e:9e57:0:b0:281:789:7ee5 with SMTP id g23-20020a2e9e57000000b0028107897ee5mr1199738ljk.6.1672935855707; Thu, 05 Jan 2023 08:24:15 -0800 (PST) Message-ID: <8ab7b45a75cdfa332954c8a112cf9b54b4d35c62.camel@gmail.com> Subject: Re: [PATCH v4 1/2] arch/riscv: initial RISC-V support to build/run minimal Xen From: Oleksii To: Andrew Cooper , Jan Beulich Cc: Bob Eshleman , Alistair Francis , Connor Davis , Julien Grall , Anthony Perard , Stefano Stabellini , Gianluca Guida , "xen-devel@lists.xenproject.org" Date: Thu, 05 Jan 2023 18:24:14 +0200 In-Reply-To: <439a5b7624dbf4d4ff6acbb9b3a6f15b777ba0fc.camel@gmail.com> References: <591d6624-2bd2-93f0-f5d6-760043230756@suse.com> <01888162-49fb-a280-a088-5e81edff3919@citrix.com> <439a5b7624dbf4d4ff6acbb9b3a6f15b777ba0fc.camel@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.1 (3.46.1-1.fc37) MIME-Version: 1.0 On Thu, 2023-01-05 at 18:10 +0200, Oleksii wrote: > On Thu, 2023-01-05 at 15:48 +0000, Andrew Cooper wrote: > > On 05/01/2023 1:40 pm, Jan Beulich wrote: > > > On 05.01.2023 13:01, Oleksii Kurochko wrote: > > > > To run in debug mode should be done the following instructions: > > > > =C2=A0$ qemu-system-riscv64 -M virt -smp 1 -nographic -m 2g \ > > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 -kernel xen/xen -s -S > > > > =C2=A0# In separate terminal: > > > > =C2=A0$ riscv64-buildroot-linux-gnu-gdb > > > > =C2=A0$ target remote :1234 > > > > =C2=A0$ add-symbol-file /xen/xen-syms 0x80200000 > > > > =C2=A0$ hb *0x80200000 > > > > =C2=A0$ c # it should stop at instruction j 0x80200000 > > > This suggests to me that Xen is meant to run at VA 0x80200000, > > > whereas ... > > >=20 > > > > --- a/xen/arch/riscv/include/asm/config.h > > > > +++ b/xen/arch/riscv/include/asm/config.h > > > > @@ -1,6 +1,9 @@ > > > > =C2=A0#ifndef __RISCV_CONFIG_H__ > > > > =C2=A0#define __RISCV_CONFIG_H__ > > > > =C2=A0 > > > > +#include > > > > +#include > > > > + > > > > =C2=A0#if defined(CONFIG_RISCV_64) > > > > =C2=A0# define LONG_BYTEORDER 3 > > > > =C2=A0# define ELFSIZE 64 > > > > @@ -28,7 +31,7 @@ > > > > =C2=A0 > > > > =C2=A0/* Linkage for RISCV */ > > > > =C2=A0#ifdef __ASSEMBLY__ > > > > -#define ALIGN .align 2 > > > > +#define ALIGN .align 4 > > > > =C2=A0 > > > > =C2=A0#define ENTRY(name)=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \ > > > > =C2=A0=C2=A0 .globl name;=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 \ > > > > @@ -36,6 +39,10 @@ > > > > =C2=A0=C2=A0 name: > > > > =C2=A0#endif > > > > =C2=A0 > > > > +#define XEN_VIRT_START=C2=A0 _AT(UL, 0x00200000) > > > ... here you specify a much lower address (and to be honest even > > > 0x80200000 > > > looks pretty low to me for 64-bit, and perhaps even for 32-bit). > > > Could you > > > clarify what the plans here are? Maybe this is merely a temporary > > > thing, > > > but not called out as such? > >=20 > > It's stale from v1 which had: > >=20 > > #define XEN_VIRT_START=C2=A0 0x80200000 Let's switch XEN_VIRT_START to 0x0000000080200000 while we don't have any MMU support as 0x80200000 is an address where OpenSBI will load binary (in our case Xen). > >=20 > >=20 > > But honestly, I don't think the qemu details in the commit message > > are > > useful.=C2=A0 This series is just about making "make build" work. > >=20 > > The next series (being worked on, but not posted yet) is only a few > > patches and gets a full Gitlab CI smoke test, at which point the > > smoke > > test shell script is the reference for how to invoke qemu. > >=20 > >=20 > > I'm happy to R-by this series and drop that part of the commit > > message > > on commit. > >=20 > I'm happy with that. Thanks. > > ~Andrew >=20 ~ Oleksii From xen-devel-bounces@lists.xenproject.org Thu Jan 05 16:40:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 16:40:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472079.732195 (Exim 4.92) (envelope-from ) id 1pDTHc-0003KM-6E; Thu, 05 Jan 2023 16:40:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472079.732195; Thu, 05 Jan 2023 16:40:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDTHc-0003KD-32; Thu, 05 Jan 2023 16:40:00 +0000 Received: by outflank-mailman (input) for mailman id 472079; Thu, 05 Jan 2023 16:39:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDTHa-0003K7-4E for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 16:39:58 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9476fed6-8d17-11ed-b8d0-410ff93cb8f0; Thu, 05 Jan 2023 17:39:55 +0100 (CET) Received: from mail-dm6nam04lp2041.outbound.protection.outlook.com (HELO NAM04-DM6-obe.outbound.protection.outlook.com) ([104.47.73.41]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 05 Jan 2023 11:39:51 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by MN2PR03MB5133.namprd03.prod.outlook.com (2603:10b6:208:1a5::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 16:39:48 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 16:39:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9476fed6-8d17-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1672936794; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=KrNF1Nng7ydDEhClHRLc+rGtl/F90VRQU6sC1aXF9SQ=; b=Qsk2H+htkcuM4bufC4cTU+oicWBddNQaMmAjTPraVfbsUc5P70AtlVrM BJbC4qAyv/+J8m2Nn3q67EOHQRkdZNQk+U7LymJSrnUh1zlAOI0jX6IGl wowvsHO9e6hXVlYlIkFj9kd+O+jCsdPnaBZU9fhRzFo3FufipODg9I7cc 0=; X-IronPort-RemoteIP: 104.47.73.41 X-IronPort-MID: 91384130 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:ubANwaJLze2yMEjBFE+Ra5QlxSXFcZb7ZxGr2PjKsXjdYENS1GcAy 2YZXm3SPP6NamOgeYonYNyxpBgF6p/VzoJrSVBlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHv+kUrWs1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPdwP9TlK6q4mhA5wRjPasjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5uK2xTs tAYEglVa0G4rtqw8Oyads9F05FLwMnDZOvzu1lG5BSBUbMKZM6GRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/VspTSKpOBy+OGF3N79U9qGX8hK2G2fo XrL5T/RCRAGLt2PjzGC9xpAg8eexHirBNtJTNVU8NZTq3OJm1Y1FiEnVFjkotKTyQ2jQ/B2f hl8Fi0G6PJaGFaQZt75Uh6joX/CvQMGXNFQEOoS5wSEy66S6AGcbkAGRDNcbN0ttOctWCcnk FSOmrvBDztluqyYUnKZ+7Kdqxu9PCEUKSkJYipsZQIB4sL/qYApyBzVR9BoEbWdkdH+Xzr3x liipy84gbIRgccV1r6T8lXOgjbqrZ/MJiY3+wHWU2SN/g5/Iom/aOSA8kPH5PxNKIKYSFipv 3UencWaqucUAvmlmy2ERuEQF7iB/febNybdh1UpFJ4knxy99njmcY1O7TVWIEZyLt1CaTLve FXUuw5a+NlUJnTCUENsS4e4CsBvwa2+E93gDqzQdoAWPsE3cxKb9iZzY0LWx3rqjEUnjaA4P 9GcbNqoCnEZT69gyVJaWtsg7FPi/QhmrUu7eHwx503PPWa2DJJNdYo4DQ== IronPort-HdrOrdr: A9a23:Rj36s6x+2M8xv+E689KzKrPwKr1zdoMgy1knxilNoH1uA6qlfq WV98jzuiWatN98Yh8dcLO7Scq9qBHnlKKdiLN5Vd3OMDUO3lHYTr2KhrGD/9SPIVybysdtkY tmbqhiGJnRIDFB/KHHCdCDYrMd/OU= X-IronPort-AV: E=Sophos;i="5.96,303,1665460800"; d="scan'208";a="91384130" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d/BT0ei8KvpBcUPIEQm/KsC4nKi4tAxB4RHvULPE8icLZggMIAN0Z5UHVl7SymfsDgFCuqUyaMionxcINob1Ive3GkepyZOUqycjsUN+t4O6o9kABmtxhYafIs6RluVzsxUSW9/O6jtvEzKHbOMKvLksH3X+ghjUsUvueGcCIapPMrow4B4u2wo06qvn4QFwzWnbhSFi/cBUtO2yq/drh8FAPK0SMJmSytGJw5EQ71t86CF0JuxH419RoJRWTTSsHXNgm1pIi2dlzrP7Zu7bBIYLNHAp2bSoouzPDRK5PALowwsE2SOGY+qepBoXilhpLmWT2ph9SlNcGD41jpBMcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KrNF1Nng7ydDEhClHRLc+rGtl/F90VRQU6sC1aXF9SQ=; b=XAON5OMb1JLYkiekyqIwvfg3w9zt6FA4TKLqSdadSYFiUIftPJUyOr+lqlnRWIWFnDrAQGQJv4JHaWn8fY//XoifJ+P5GClQpF1/C4YKdZeEJ2H3EtUx+h1enkt5493EkEE7IgMcatQaZBHmm6qZTDKbjR5wPpiDl9V9Tysi5rQTA7p9Y/r7XnwIeSEV+rbpY8mMYIMYmTUCqSFkZSsZtyMinGJ7+y+tiBXUw0EH1Tst7ujRuuB8a4QLt3S52QhU9RIUhffUx9Uufd97rzClhOmP7ca6UuNSAJ02sbZL0Hxmssz+SlFxXgeTrGq5UhodRN/jl/MNUb5byHPj5a2EPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KrNF1Nng7ydDEhClHRLc+rGtl/F90VRQU6sC1aXF9SQ=; b=v/pOvXVjz/tlF6DDFEPTDb4dgox4gi2gmIGTnM9YdRjktP9GFAv1Q5Kc+m3N+J6J9CGuUX4SkmsijIcjR+gXrBE/q96RHi9RXsI96OIQeJQoQ6XjWLVBUZJHcfU2/XvpUTk3ImEvWaXK08TgizVT293yOf8GSSkMexol437zAYE= From: Andrew Cooper To: Oleksii , Jan Beulich CC: Bob Eshleman , Alistair Francis , Connor Davis , Julien Grall , Anthony Perard , Stefano Stabellini , Gianluca Guida , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH v4 1/2] arch/riscv: initial RISC-V support to build/run minimal Xen Thread-Topic: [PATCH v4 1/2] arch/riscv: initial RISC-V support to build/run minimal Xen Thread-Index: AQHZIP2Dn/VS+v8CxEaK8nfj7fmLt66P1KmAgAAjsICAAAYtgIAAA8sAgAAEWIA= Date: Thu, 5 Jan 2023 16:39:47 +0000 Message-ID: References: <591d6624-2bd2-93f0-f5d6-760043230756@suse.com> <01888162-49fb-a280-a088-5e81edff3919@citrix.com> <439a5b7624dbf4d4ff6acbb9b3a6f15b777ba0fc.camel@gmail.com> <8ab7b45a75cdfa332954c8a112cf9b54b4d35c62.camel@gmail.com> In-Reply-To: <8ab7b45a75cdfa332954c8a112cf9b54b4d35c62.camel@gmail.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|MN2PR03MB5133:EE_ x-ms-office365-filtering-correlation-id: 2923fe1d-be79-4fb7-4014-08daef3b757a x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Pm7Ix79peBDskOd23e6MYcxAAIPGojji3Cxzxi7GUSai3YJSekgqiSVqdWX6V8zl2TdZ8SJUGJyOSr5qVHTy0qysjSzDRI2ZHyWZ1ROJDAC3pzlt2xehrtTbnH/IetLHwOZVuGctpPGd0YiGVB8peBZGAYbCmnYMvN4B6SskkfaLOdCphJI1OMhSfIUjaKW5EFLT+wHDoAgxectiDeIG8jj7gcNHaweMzv0l/vTrOpcX6jtz7DkRriimUPFv0so+RvK0ROVFfvBAJj2GmdmuiJPeICL6QJm/ccEzJVnqUGIdARhRUs7bjFpiG0v50J3rmnMp+RlW6hKT1Et/8fAVcBtocEnKco/cQPpulY3nc3fTgsTEbpHj8QkinDpMq6P5rkD5Qgz9mt7854UcWvs77G7qM5KTqcsHMb8Lcsm+zImUuVsgkCIwqoTJ0yoSwlUuBc6oyfhcZEFvJrFHN+CFSJyv+iKALWI0hiR5aC0L4WF7Ecbknx6qoOdmlgAeoU0rVKCCB/FaF9U0v2HgYf4Q1pp7g6jmcREMkHPe/HJKBtyeJKYGQGYkq/8DOU0CyzaupHUpAMgQ4xe2dPK+k/mVi6F2WHH+JICA/RhvAIE2FhNMgHRpQPkhSIYlpNnr+Gezu5wuuH2bXb1G6IoIhQVoD8IWDm4GrfDpusV8+IZXiFDMqdGpZ5iv6jMV1V+XGVmMHL7yGldu0MqKv6GN1qU8CWJMiMxiN+AXScqJ0YsmVXG+Imlifl/UMekZr1AGORtJ156L1UzsBMjOxuMoMIS/0Q== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(39860400002)(346002)(366004)(376002)(451199015)(186003)(6512007)(26005)(83380400001)(53546011)(6506007)(31696002)(86362001)(38070700005)(36756003)(122000001)(38100700002)(82960400001)(2616005)(31686004)(41300700001)(2906002)(5660300002)(7416002)(8936002)(4326008)(71200400001)(478600001)(8676002)(66946007)(110136005)(66556008)(66476007)(76116006)(91956017)(316002)(6486002)(66446008)(64756008)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?a2lySUl2b3NzSktwVTNlbjk0UTVGdlMzTzhKTUtyT0s0YzIxQWNvbWp4OVVD?= =?utf-8?B?ZzZReVZXVWVkWnl2OVE5dmowM0swVmVaVm1jelFzWFV0QitQbVlPVEEycGU1?= =?utf-8?B?TWU2WXRYK3VSY2I1dUdpODJ1WXF3aE41TWFFK2JWcTVXUExXc3BDajhPWG5Q?= =?utf-8?B?VmNCb2kvT0R1Mk1WRlkyWlFSTTZiVW4yVVRKRG81d2lWWjFDakhLTVRhM09k?= =?utf-8?B?anByWS9UbWlnbkU5R3lsZVNmSW1tR0dqQkZZNlJpRldGN2wxL0xPZEExY01G?= =?utf-8?B?VmJNWVU2YkxkL01rUHd6WmFFRHY3cGxqZGVJSTc4dXF3R2VSVUtVREpSdVd4?= =?utf-8?B?RnF6UXMybUxhMnBqdjR6VmpRdG9GM3RVTHd0RlB0UU1VbHg3REJtanpnanRo?= =?utf-8?B?SEp5TmxjdlN4NjRHa0ozZVR4b1pPM1N3RFBKYzFNL3hDOU5oSWtzWi85REVt?= =?utf-8?B?ekRGSUs3clN0NlJlOC93NndJWU5obFpUTVpsWDRCeDVZVlA3ZDhYaXdTYXlh?= =?utf-8?B?eU81QWU1d2JqalkwMXp1VVM0bVNLZGk2RmRFOVlwd21LN1JtM1BzYVhySU9I?= =?utf-8?B?YjEvcTZNTlJMTFo0U3UrbWovYlNBeWxZU2VWaXdsZ1dXQjJ1cnF1SUJGVmtS?= =?utf-8?B?M1VPczc0L2lzaE0yYk55OUhVaFJnSFpYS3hUd0kyYlRsUlRjQWtObThyZVBC?= =?utf-8?B?OHhrVDhNSkhnN2Z5QnBpZ3dpZzBteERJZlF6K2VodnJ5dS9mcEVhdGVQMVdn?= =?utf-8?B?bXRhUGFMSmhENndua1pKR0xIVi9MeUUwU3pITWtWeTVVc3FoTnI0S2tTY3FT?= =?utf-8?B?dmQ5M2t0dUljM3Z2N1czcTdoUURZWGMvYVVvUW9ab0Q2YkpVNHp5NENkQ1BO?= =?utf-8?B?NGZ4YmhkWlBoQXpPVTlDVlFiaGxwSDZZa2pCZUdIelZLNlAxcUZDMnhnaUFi?= =?utf-8?B?QU5lUFYvM1IzNC9lMG8vS0liMElXcldSWWZWNTFZNThIZGFuVUM1aURoWk4r?= =?utf-8?B?SFFxalU5c21FMlQ4ekpRMG01T3JCK1VSYWQ2SnU4RE5xbmsybmUzVHIvL0VX?= =?utf-8?B?YURJWG5LYVhScG5rL2JuMEFScDhtYnd6ZFBCVUxGY0xYSDE3SUtIbGV1ckgx?= =?utf-8?B?ZWdXMGZNUWQySG9lOEl1Sm8zS1BPSDFIM2dCOVFOTG1RbG5TeFR4ZU1TbTQ4?= =?utf-8?B?eXlNL0xSQTVZYndoM2h6RmZ4RE11bWU0Z21lSDN3RW1VSjhjMkl2dHBjZW5k?= =?utf-8?B?WjBpbC9pMHNsT0dmaW5aMkYxczhiNG9GTy9rUDZYSjJJbk1xVTFMMThQVDVs?= =?utf-8?B?elA3WGRVeXlEb3dCVlBFK2prMFhlcUl4SDFVZjlLa0xSZ3ZyN090aXdCUDBk?= =?utf-8?B?RnhacVRGK1dHN3ZJQ0lxUWpxU3A4WVJGWkVUWUNLelJZZjd3bisxbDEwNVZm?= =?utf-8?B?TWJXRWVIZnY3a3ZYWVpaZThJNlQwRzR5ei9JMWwxSHp3UE9ZZkhMcFlOczF3?= =?utf-8?B?U0tBdnVxQVlwaTNzNmszbm1XSXA3K0ZsL2h2UWJPWlVhZkY0cjZJYWZTRzhz?= =?utf-8?B?UHdjclpuZmxEWGZUNG5ucmVoL0xwOThLbENSenRnSENFM3FIM2pWOGhEdENq?= =?utf-8?B?UWJSb092VGZkd1NUM3l1QnpaZlNtZXhoVEx4QlBPdjBBQnI2RHUzbEpzeHU0?= =?utf-8?B?VFJZbENYcm1wZEduK2d6Z0JuT2J4d0U1NUhacDY5ZVJkTDBPMitrV2dQVzJ3?= =?utf-8?B?M0E5amdUYVhkMU1nNjkxUHVEK245QWk0Z3BXNU9GcEt6MlhOVGJVeUZCYkVM?= =?utf-8?B?OHA0TTNBb3ZxbHhWNE5NWnQzd0ZYTS9leXBGei9kYVA4eFVtWXB6TFIraHVG?= =?utf-8?B?TGxUMTBhcmxtM3d6ZW9mRkQyaVZoNEZyNVgwTWNBMlF5eDIvdmh6MnBrc2Z4?= =?utf-8?B?dFhGaGsyRzRxQm55eG5yR3RodTVIQzhrY2NjcUh0blNpUzhxMTlNMG1hdXNI?= =?utf-8?B?QnBVRzVvaGxuTGZKdXU3Ly9PelRhTnpyZ0dtNHlJd2gwbXVMUjJNdlIwMHVW?= =?utf-8?B?L1JHdUNMS0c0QnR4SEVTdkJhSDc5RWIveUllMnE0RHcyeVhSY0FZY1kvMnFP?= =?utf-8?B?bWF4K1RkSklEa1VFNjBCN1BjMkltd3JQSEZ4R2J5RFkva3NtMDltTmFNaXlD?= =?utf-8?B?S1E9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?cW9GT0c5WHJNaW92Z1dCRUFLNXozakNlc01wSEhNNk1jNmYwTW9TRW5BK2N1?= =?utf-8?B?c0pPZThOMEhtVTJaNGxFMXlBMEYrSVo0YnRVNEk1d1V2TmtoOVNxUnZ6U2Q0?= =?utf-8?B?KzZseTZwdUt4UUoydkxjbFR4VlpFbGdqa1YrWXQybXBjYWo0bWZ6dzZjUWlN?= =?utf-8?B?MlRrZ29BNDFIK1dPZU1vaEN2QW9BSk1taUt1ZXpCYktXL003ckQ2RW1IVFE1?= =?utf-8?B?R0RxQVc5RWx1d2ZpSVVCR1oxdzU1b0M5eE5LODhMNjF3NEkyZ2VyeTZ1bTd1?= =?utf-8?B?MENSM3YyR09JV2R2ZU5iUVBZMGZlZTR3NXQxVmdiSENTQ2F0czUwdW5qTmpQ?= =?utf-8?B?YjZhaHc3SFJXSUVRWU1TRmxXRWlwMUQwMW9HeWhhYTRNYjg2Y01MYlJqZTlr?= =?utf-8?B?amdOb2hicktaK3NRdElxaUZkdjkwS3ZsL1BVSFp5UnJUS3lJMEcrVEp5MnRn?= =?utf-8?B?cGE2YXNPKzhqdWNBbWZVNUFEaGxxSTIrZEYxOFlIRGdOOWxQVGJDZExKMERK?= =?utf-8?B?K3ozRXVEaisvcVA0Vzc5WEpGK1dDMUxSMU9oS05NUSt5a2I0dWIwQS9MWGdy?= =?utf-8?B?eVlsODFYMjRnc0ZYVHVJa0lWZEFVYXZTbVhCV0xVL2xyUnBJU2pmZ1JhSTRo?= =?utf-8?B?d2hsVm9OeDhKNUFtZDVVNnFyU2tnSTIyOEExYWd2VWlmUFRaaU1rZEpZL0RE?= =?utf-8?B?am9ZN2dGL0FHYXR0OWJ2THVES3JPOW5SYU9LS1phU0VMMm9VTm9UTFZLbW56?= =?utf-8?B?RWg1eVlBZnpOT2U0dzFiQWFoUzJxSFBFS0F5ejFYR1EwK0lhbzJKOHRFUlV4?= =?utf-8?B?NFlsRCtBd3JucWVxVmpNamdEbDF2Y20vUzhiNktnVlhKbFlQWUFtRXRzU0hp?= =?utf-8?B?Y2h2VUpVZFJMa0dBSFg5bG9hbFhhakdQL3ZCdFd2bFFNNS9iR0tDbHVTK3dl?= =?utf-8?B?cHJwT0Z6TFM5ZHF5cnlab0YrSUh5dENleWdaODZLMVF3R3d0ZzBwVHgxZ1Ar?= =?utf-8?B?NzNXd3VqU1pjZG8yMjcvU0oyR1UwbEkzS2J0SzlRc0hpSG9lNXJkTTlyRUli?= =?utf-8?B?ZHY4d21ydzdjeXQ5QzEreGhZSm4vWEM5Q2FnZUVob2xRTmE2d2puYjlTVUgx?= =?utf-8?B?UHo3a3dRWG5pdVdWeVhpMThsd2g4a1hXajhvOXBSbzUrd0QyTjNGcGErSnFq?= =?utf-8?B?a3R2TWNhKzJtUUxRc3JkUXR2aG1wL0lmRCtLWk5raVBSd05oWFZSUnhlY01E?= =?utf-8?B?UWJ5QlJZTHFXdjN5M1I4c1hQVUh4MnhvOG5EaE5MT1ZBKzRTMGpQdm5uZHdH?= =?utf-8?Q?fH3lSQlFvv1yY=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2923fe1d-be79-4fb7-4014-08daef3b757a X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jan 2023 16:39:47.8932 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0LaO/eli6Go9fPMBrQrklwiGEYnTrP+7Db5zPaC1M4oLk25I0v+y3nQ+a7PhvlX7BCoIExhTqiFhzLSJNRwAHLt9gF7ZiMKqTzeyOjlXOAo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5133 T24gMDUvMDEvMjAyMyA0OjI0IHBtLCBPbGVrc2lpIHdyb3RlOg0KPiBPbiBUaHUsIDIwMjMtMDEt MDUgYXQgMTg6MTAgKzAyMDAsIE9sZWtzaWkgd3JvdGU6DQo+PiBPbiBUaHUsIDIwMjMtMDEtMDUg YXQgMTU6NDggKzAwMDAsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+Pj4gT24gMDUvMDEvMjAyMyAx OjQwIHBtLCBKYW4gQmV1bGljaCB3cm90ZToNCj4+Pj4gT24gMDUuMDEuMjAyMyAxMzowMSwgT2xl a3NpaSBLdXJvY2hrbyB3cm90ZToNCj4+Pj4+IFRvIHJ1biBpbiBkZWJ1ZyBtb2RlIHNob3VsZCBi ZSBkb25lIHRoZSBmb2xsb3dpbmcgaW5zdHJ1Y3Rpb25zOg0KPj4+Pj4gwqAkIHFlbXUtc3lzdGVt LXJpc2N2NjQgLU0gdmlydCAtc21wIDEgLW5vZ3JhcGhpYyAtbSAyZyBcDQo+Pj4+PiDCoMKgwqDC oMKgwqDCoCAta2VybmVsIHhlbi94ZW4gLXMgLVMNCj4+Pj4+IMKgIyBJbiBzZXBhcmF0ZSB0ZXJt aW5hbDoNCj4+Pj4+IMKgJCByaXNjdjY0LWJ1aWxkcm9vdC1saW51eC1nbnUtZ2RiDQo+Pj4+PiDC oCQgdGFyZ2V0IHJlbW90ZSA6MTIzNA0KPj4+Pj4gwqAkIGFkZC1zeW1ib2wtZmlsZSA8eGVuX3Ny Yz4veGVuL3hlbi1zeW1zIDB4ODAyMDAwMDANCj4+Pj4+IMKgJCBoYiAqMHg4MDIwMDAwMA0KPj4+ Pj4gwqAkIGMgIyBpdCBzaG91bGQgc3RvcCBhdCBpbnN0cnVjdGlvbiBqIDB4ODAyMDAwMDAgPHN0 YXJ0Pg0KPj4+PiBUaGlzIHN1Z2dlc3RzIHRvIG1lIHRoYXQgWGVuIGlzIG1lYW50IHRvIHJ1biBh dCBWQSAweDgwMjAwMDAwLA0KPj4+PiB3aGVyZWFzIC4uLg0KPj4+Pg0KPj4+Pj4gLS0tIGEveGVu L2FyY2gvcmlzY3YvaW5jbHVkZS9hc20vY29uZmlnLmgNCj4+Pj4+ICsrKyBiL3hlbi9hcmNoL3Jp c2N2L2luY2x1ZGUvYXNtL2NvbmZpZy5oDQo+Pj4+PiBAQCAtMSw2ICsxLDkgQEANCj4+Pj4+IMKg I2lmbmRlZiBfX1JJU0NWX0NPTkZJR19IX18NCj4+Pj4+IMKgI2RlZmluZSBfX1JJU0NWX0NPTkZJ R19IX18NCj4+Pj4+IMKgDQo+Pj4+PiArI2luY2x1ZGUgPHhlbi9jb25zdC5oPg0KPj4+Pj4gKyNp bmNsdWRlIDx4ZW4vcGFnZS1zaXplLmg+DQo+Pj4+PiArDQo+Pj4+PiDCoCNpZiBkZWZpbmVkKENP TkZJR19SSVNDVl82NCkNCj4+Pj4+IMKgIyBkZWZpbmUgTE9OR19CWVRFT1JERVIgMw0KPj4+Pj4g wqAjIGRlZmluZSBFTEZTSVpFIDY0DQo+Pj4+PiBAQCAtMjgsNyArMzEsNyBAQA0KPj4+Pj4gwqAN Cj4+Pj4+IMKgLyogTGlua2FnZSBmb3IgUklTQ1YgKi8NCj4+Pj4+IMKgI2lmZGVmIF9fQVNTRU1C TFlfXw0KPj4+Pj4gLSNkZWZpbmUgQUxJR04gLmFsaWduIDINCj4+Pj4+ICsjZGVmaW5lIEFMSUdO IC5hbGlnbiA0DQo+Pj4+PiDCoA0KPj4+Pj4gwqAjZGVmaW5lIEVOVFJZKG5hbWUpwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXA0K Pj4+Pj4gwqDCoCAuZ2xvYmwgbmFtZTvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXA0KPj4+Pj4gQEAgLTM2LDYg KzM5LDEwIEBADQo+Pj4+PiDCoMKgIG5hbWU6DQo+Pj4+PiDCoCNlbmRpZg0KPj4+Pj4gwqANCj4+ Pj4+ICsjZGVmaW5lIFhFTl9WSVJUX1NUQVJUwqAgX0FUKFVMLCAweDAwMjAwMDAwKQ0KPj4+PiAu Li4gaGVyZSB5b3Ugc3BlY2lmeSBhIG11Y2ggbG93ZXIgYWRkcmVzcyAoYW5kIHRvIGJlIGhvbmVz dCBldmVuDQo+Pj4+IDB4ODAyMDAwMDANCj4+Pj4gbG9va3MgcHJldHR5IGxvdyB0byBtZSBmb3Ig NjQtYml0LCBhbmQgcGVyaGFwcyBldmVuIGZvciAzMi1iaXQpLg0KPj4+PiBDb3VsZCB5b3UNCj4+ Pj4gY2xhcmlmeSB3aGF0IHRoZSBwbGFucyBoZXJlIGFyZT8gTWF5YmUgdGhpcyBpcyBtZXJlbHkg YSB0ZW1wb3JhcnkNCj4+Pj4gdGhpbmcsDQo+Pj4+IGJ1dCBub3QgY2FsbGVkIG91dCBhcyBzdWNo Pw0KPj4+IEl0J3Mgc3RhbGUgZnJvbSB2MSB3aGljaCBoYWQ6DQo+Pj4NCj4+PiAjZGVmaW5lIFhF Tl9WSVJUX1NUQVJUwqAgMHg4MDIwMDAwMA0KPiBMZXQncyBzd2l0Y2ggWEVOX1ZJUlRfU1RBUlQg dG8gMHgwMDAwMDAwMDgwMjAwMDAwIHdoaWxlIHdlIGRvbid0IGhhdmUNCj4gYW55IE1NVSBzdXBw b3J0IGFzIDB4ODAyMDAwMDAgaXMgYW4gYWRkcmVzcyB3aGVyZSBPcGVuU0JJIHdpbGwgbG9hZA0K PiBiaW5hcnkgKGluIG91ciBjYXNlIFhlbikuDQoNCk9rLsKgIEkndmUgZml4ZWQgdGhhdCB1cCBh bmQgcHVzaGVkIHdpdGggYSB0d2Vha2VkIGNvbW1pdCBtZXNzYWdlLg0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Thu Jan 05 16:47:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 16:47:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472087.732206 (Exim 4.92) (envelope-from ) id 1pDTOT-0004pE-0s; Thu, 05 Jan 2023 16:47:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472087.732206; Thu, 05 Jan 2023 16:47:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDTOS-0004p7-Tk; Thu, 05 Jan 2023 16:47:04 +0000 Received: by outflank-mailman (input) for mailman id 472087; Thu, 05 Jan 2023 16:47:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDTOR-0004oy-QN for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 16:47:03 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2044.outbound.protection.outlook.com [40.107.6.44]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 93fde1ec-8d18-11ed-91b6-6bf2151ebd3b; Thu, 05 Jan 2023 17:47:02 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBBPR04MB7801.eurprd04.prod.outlook.com (2603:10a6:10:1eb::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 16:46:59 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 16:46:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 93fde1ec-8d18-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fyFAUSgsOH+zDOkh4CLbEMJmVcXFjXCYwnAzUm1vNxoTmmyqSQ6x22x4CVQqCnk3ouFVvhy0cDME3uWMixHhCNLaFt8NH1dFwqPbl87TipA7ijO6hW/CI5q5QyUVjZr6o60m1AHhW/rbbHbF1T5v8im70Cvjl86MjQD/7PV3yR2T318CzbpupVGaY9nml2aRtISUyqqmsJed1EtPb40btBCKI/sOR56LPVIdPyvMfWxV/KlWOWUfsCOmxysTjMkHS9bXzWotHOS4U/bGvpT7eHdpu5b6+xDNbNQwWXUOPwffwGpHMUoujy8GAgXiYjRwoJwGDxlZHuCQvqBjPGuPtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DcGuQU1bGC5b9LD2CPTGRvx/D0t7v/48EG45UhsDssI=; b=EYJGaclsZu9VvnjzuYRqetiU4sJlx4UhnljHDgi8uwvVuVEUlcJZSzYLlyGgaj7NRrLt9L1ICN7ZIGyKHEqwhzDu1K1De28DsXB4u1MQK3bbCQddPdZ8io9DA2kAaolXlMi0RA3ee/fnyEqdU4D1MMDrPBjpMwoQNUMsvNImnHvXFEeJZ0o/BowyFeL7tl3Ork8DBkUbFNYBlEuvS3rvIXcpz58Ja1Cim5jGVh4cKGpUgFAD43Xz1mER413SzY1csUU0DFR8otorO91BEa7T7ElYBfq5yI987JxZicCdWexKMjnVz8WyMMizJpyADSrmadJAjNVQ3bVlRRH+I/RmXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DcGuQU1bGC5b9LD2CPTGRvx/D0t7v/48EG45UhsDssI=; b=PVtTdxnirIoMYiH0CKO7EX+xjWYZFQ3yRGQnWOO+0W76WAvXzs0YfeNVqvTTzt6Nn2++o5OKwBT2k8cctU9HkJ0nUoJpidoyAyL+iNRDgdCTuGRAkXJTTE7M7ugz2pZrf4T7VLDzZLTO6HsZhUQ3MG4CtkTS441F0YdonOVidTtC+d5B0y1rIGpF0ENUwWD9c4iwwvSk1NfwQ76lwXRM6qtOHTFPDAZTkuG+CvJMWcMdBpggb6KcaYj2f1YZib1hf7xIHvmkHfwjw30CsHzk1imtVkB/qh5FZJ5GMmXfx59moOot9W4iQDI2lpNMqUm4IJKaKNONAfRTRa5NwKSQ3A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <84a96972-3c41-ec94-3513-9944467d9e1c@suse.com> Date: Thu, 5 Jan 2023 17:46:57 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 13/22] xen/x86: Add support for the PMAP Content-Language: en-US To: Julien Grall Cc: Julien Grall , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <20221216114853.8227-1-julien@xen.org> <20221216114853.8227-14-julien@xen.org> From: Jan Beulich In-Reply-To: <20221216114853.8227-14-julien@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0155.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBBPR04MB7801:EE_ X-MS-Office365-Filtering-Correlation-Id: c792d951-9630-4f99-1317-08daef3c768e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: msvgdgstWuvw1g4ocUHhX6Yi53k+MY0tvxYieSI8DYP9uD4WR1kA7fkWjQyMobP+UHB1bft4lb41MMhWaUFJORQTf1d8woFo4okqoHSd7Pap8Qx3tqICH7NJr+c9AqcVR3Ijv/4gq/JlHPwPzhLk72FIL8J7OVU+0N0ifYVM/XTc4yKFwVblCaSasOIfD5jER8TXLsC5gui5bIwLmfanNjZJGzRD6ncSq9EFKzXoGG5N+Ez1Aqvy3OZUR+qkG2Xtao66YHBLL6TuVkEJD5i0mNUOuencs+rVStYkdqLi/zgpsLqaoQQLC6by6axg7M5Y44/HM6+tQzOiOP8dwLTLMfsMxW9rBzENeiAk7TyabYYjXr+OQ2pdmx6C7GbBUDqYY8PNkyqCQ6Jhc8H7LmXQRJrgEjoUPhALBtm4Zv+OBu0qLgBuG/Y5Q6vLvb5DBwDGsUDVSOyKabNbfj5PtOPY/Rif6omjb6rSNQao7nQnoSJs/w2fwIysBktgtpUG7PfC29BJkGiAXCgBegMa3ods5wMP8RDeaROKybAq3v/frmFbjlP7dUcKzn8yGcdb9Rsp1wtSRQ/p7nW4l94A58jUcv9yFSPt8A6uuL3Qpm/Feyx6/PTAs32XJ3E206LSaM/RjWyO5/Gjr9D+mJ3Ch37z/r0NaQk/NT9UZsW1i+27wXozgkrDyHmNqp+MCtrEB7Wp8+2GGMq4NQPqDtg3ZgxCn4A2Zjo5tPPqli6HaD0dr8+xbSEnmiwJ0aXG63dUr6s/ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(366004)(39860400002)(396003)(346002)(376002)(451199015)(41300700001)(83380400001)(31686004)(2906002)(5660300002)(4326008)(66476007)(66556008)(66946007)(8676002)(8936002)(38100700002)(31696002)(2616005)(478600001)(316002)(6916009)(36756003)(6486002)(53546011)(54906003)(6506007)(186003)(86362001)(26005)(6512007)(45980500001)(43740500002)(357404004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MWZrb0EyaG8zNEF2WTdaT1hTcEtHQmdpSTVzM3RRM243eVJVaS9YZk9NOUUw?= =?utf-8?B?MDZNeXRDRjNVeExyQ01ESWc3Q0hzZjN6RzduWVRQYnJzZmNJbFgyakFQN0pZ?= =?utf-8?B?LzdGM21vc0Z6Ty9LOS9DYzYxK2hwc2VUOGVpTGpDL29iemY0Y212elgrMzFR?= =?utf-8?B?dDY2djVwOVBIa24ralhJUUNQNlFWTExoeVh0WlR1M1RWLyt1OGxOeFJPL0xr?= =?utf-8?B?VWpDcVA1U2dsMXV5YXRHWGxPWklZQnlVM0xmQlFYcGUyK2t0UnJudGJkY0Jr?= =?utf-8?B?eERyam9jOUkwUnc2Z1BPaXhSa2c0UzIrSUdWZ0FUZ0RoK2wzV05CM0s5RUtR?= =?utf-8?B?L0Z2dVRPOGZVTUZ6ZmY2eGtHK29ITTBMVFpKQWo3bzduT2ttQkRXK0xnVkw3?= =?utf-8?B?STdFVDFSSWJ6MTF4UVpPT2ZaNWdteU5KU0V5Vkx4Q0tsUmY5K1M0d2RFUFNM?= =?utf-8?B?SW9HTENFUmZnWnNrVC8vaitsNlhwRHBwWWVPWFh1aUUrNFJYN2F2UlNDUmZQ?= =?utf-8?B?d3lMTjg2dEdrUDdaMkFCYkM0Ry96dWFuTXhYZG0vOVh4cFkyVzhxNmN6MWRY?= =?utf-8?B?MFkxb3Vaa3RBQWpRWTJnUW8yeU1iSWI1bWhSandGZmFxSFJaWHhIQjByZkQ2?= =?utf-8?B?VGE1OUQrdnVPSGVzcGc4SFo1aTBxOEMyU04vclM1bFBRU1JaUFo4bVBxaFpr?= =?utf-8?B?Mjd5K2hoOHFFQnIzOUN0UUlSdHFIcitYcU9RMitxNnpJbUc5UVlvVXMwdWNL?= =?utf-8?B?UW1wSEJMeitMS2M2djFYODBGR200UFU5MUhrT2tsb1F0bW1nOHAyMzdLSEdm?= =?utf-8?B?anNCRWx1WmVvaVU2bVZHeEdUY2VWMjltbGRFelNxK2VFTkRDV2lhLzJ6L1Fz?= =?utf-8?B?MU9YZXdydTVqK0VScnJFSnBXeGRiQ25maHEvSUtjTmc3bGVLM1Aza1RXOXp2?= =?utf-8?B?emJpdDN2bGZuUGZEd29qb1NRTXVDSkp4OE9NUlNlOGw3VFkxTXFWTXNzczNZ?= =?utf-8?B?c2F1TXR1dGlveWVIN0dObHZWRDdRMkI0YUM5SU9UdTVSNDhVQjlZc3FFSEU4?= =?utf-8?B?S09vaFBCdEtPdkcrbVpZZmU3YUZ6aWFkbUEwbDdhWHdEMGU4QnpaYmpPZ2Z0?= =?utf-8?B?UEZ0WkxvbjZtb1prOWNnYVJ6SGVtYUREUHF0VnNrV3lIZzh5TkZUZU43K0pW?= =?utf-8?B?aVlsZ1h5V1VpeHV1cmpOYi8rYzdoV3ZwZUFyVXpEYUJlQUxoNHlGek1TeG8v?= =?utf-8?B?YmFKbUdBdXpveXBtYTRsTWVRR2xtdEp5MGZsY09IMVUvNkRkREtjRWVXOWpC?= =?utf-8?B?bVAvaWtwMzVkZEpPZlNsRlFBcjdPLzZvNm1ONVZCcjF4SUI0a2o5MktLeGpt?= =?utf-8?B?WGZDTExvcGtPZTljbFJqckVmSUtnQnpLMGVJVFArUWszbG1VeFgzdGFzeTIv?= =?utf-8?B?UkhkMkh5R1FLTWMybnp5c3JmblR6K0VoN0JpRDhxMXVjUDhmU0RrR2R4ZFln?= =?utf-8?B?bWxiNmlPbmlkN2FLN3Q4ZVVqMzdIaUZGYTNoQjJhYmR1U21zYzYvMUFwUjJl?= =?utf-8?B?NkRwZ0tWVzNOMXZsS1Y3alg1ZGJlbGtVU1lzbEEwMjBPa0I2Uy82T1JISXVs?= =?utf-8?B?V3VrUXMwMGpjeDhkbCtzRW1GYXpuenZuUXorNGsyeFFuZmtWeUF4QjFSa3Fz?= =?utf-8?B?MUEyR0NPT2Z6eW40SGpMeHV1bC9Pd3Iyb3hBWU04LytYSnllN0szNGJ5eDBU?= =?utf-8?B?RDRteFRkWHh4M2JGVllOQkFhY0VpV2E4aDMrWll6V0lCT2J2ZlpmZGlOMXAy?= =?utf-8?B?MSt5d25uM0hsalNVdTFETEEvejlISjJmdFAzTVlNbnk5SFh4cGZzaUlYeUxT?= =?utf-8?B?V2N3ZHE5NjAvbXRPcmRnOFJNc3F0ZHFMbEFoN3VtU2tXUE9oZ2Zyb0NGUU5q?= =?utf-8?B?ZHY3K3NheHhyb0xqM29QbWJpT1JwWHBWdjFnaUtiTm1Nb2I2V0RZUWtMOEZT?= =?utf-8?B?NVBkcWdxRm9sbFdFaXdVakhqVERxMnltYXpyR0NvZmZDMUpwY21UR2ZRSHZY?= =?utf-8?B?aURMQ3E3Wi92RG1yT1pmYXFlT1JLK1VJaDVDYjJWTUR1N0g2bW01UTNGcXRP?= =?utf-8?Q?BkaLzuenbNaTdz0GLYUjgAuE6?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c792d951-9630-4f99-1317-08daef3c768e X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2023 16:46:59.4007 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VSjo84KHjVES13ybKNrfkO98Uka8BlRUk5K7bMCctnw/MxZIvuuGpMaozNlNoncG8crbPe1hkCCojKv6FciMHw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7801 On 16.12.2022 12:48, Julien Grall wrote: > PMAP will be used in a follow-up patch to bootstap map domain > page infrastructure -- we need some way to map pages to setup the > mapcache without a direct map. But this isn't going to be needed overly early then, seeing that ... > --- a/xen/arch/x86/include/asm/fixmap.h > +++ b/xen/arch/x86/include/asm/fixmap.h > @@ -21,6 +21,8 @@ > > #include > #include > +#include > + > #include > #include > #include > @@ -54,6 +56,8 @@ enum fixed_addresses { > FIX_XEN_SHARED_INFO, > #endif /* CONFIG_XEN_GUEST */ > /* Everything else should go further down. */ > + FIX_PMAP_BEGIN, > + FIX_PMAP_END = FIX_PMAP_BEGIN + NUM_FIX_PMAP, ... you've inserted the new entries after the respective comment? Is there a reason you don't insert farther towards the end of this enumeration? > --- /dev/null > +++ b/xen/arch/x86/include/asm/pmap.h > @@ -0,0 +1,25 @@ > +#ifndef __ASM_PMAP_H__ > +#define __ASM_PMAP_H__ > + > +#include > + > +static inline void arch_pmap_map(unsigned int slot, mfn_t mfn) > +{ > + unsigned long linear = (unsigned long)fix_to_virt(slot); > + l1_pgentry_t *pl1e = &l1_fixmap[l1_table_offset(linear)]; > + > + ASSERT(!(l1e_get_flags(*pl1e) & _PAGE_PRESENT)); > + > + l1e_write_atomic(pl1e, l1e_from_mfn(mfn, PAGE_HYPERVISOR)); > +} > + > +static inline void arch_pmap_unmap(unsigned int slot) > +{ > + unsigned long linear = (unsigned long)fix_to_virt(slot); > + l1_pgentry_t *pl1e = &l1_fixmap[l1_table_offset(linear)]; > + > + l1e_write_atomic(pl1e, l1e_empty()); > + flush_tlb_one_local(linear); > +} You're effectively open-coding {set,clear}_fixmap(), just without the L1 table allocation (should such be necessary). If you depend on using the build-time L1 table, then you need to move your entries ahead of said comment. But independent of that you want to either use the existing macros / functions, or explain why you can't. Jan From xen-devel-bounces@lists.xenproject.org Thu Jan 05 17:51:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 17:51:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472094.732216 (Exim 4.92) (envelope-from ) id 1pDUO7-0003Kr-N1; Thu, 05 Jan 2023 17:50:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472094.732216; Thu, 05 Jan 2023 17:50:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDUO7-0003Kk-KI; Thu, 05 Jan 2023 17:50:47 +0000 Received: by outflank-mailman (input) for mailman id 472094; Thu, 05 Jan 2023 17:50:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDUO6-0003Ke-7C for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 17:50:46 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDUO3-0001Mr-Sv; Thu, 05 Jan 2023 17:50:43 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=[192.168.4.62]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pDUO3-0000oE-Mo; Thu, 05 Jan 2023 17:50:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=8vcieIbCBqWK4v4MK2ILng/goWaB9VQK/FpAtpowD4k=; b=Z3E9fWBcJwZgZSxJziOArJA0tc rURGvep9oQuxASKqtELj08YwhJhKMqeiBz2GZgZkqqCdV2yYAyBec2kKwOiyPuAlxObNAE/Sist1w 7fBRAHnEZjxQdMlsrMSz1RkdvIyRGQX9nWeWA+Ni8SmIYC5pMgM+rhFtIR8FrAoQKfS8=; Message-ID: <924abe0d-6ba8-5d64-d74a-c2e1894d4f64@xen.org> Date: Thu, 5 Jan 2023 17:50:41 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 13/22] xen/x86: Add support for the PMAP Content-Language: en-US To: Jan Beulich Cc: Julien Grall , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <20221216114853.8227-1-julien@xen.org> <20221216114853.8227-14-julien@xen.org> <84a96972-3c41-ec94-3513-9944467d9e1c@suse.com> From: Julien Grall In-Reply-To: <84a96972-3c41-ec94-3513-9944467d9e1c@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 05/01/2023 16:46, Jan Beulich wrote: > On 16.12.2022 12:48, Julien Grall wrote: >> --- a/xen/arch/x86/include/asm/fixmap.h >> +++ b/xen/arch/x86/include/asm/fixmap.h >> @@ -21,6 +21,8 @@ >> >> #include >> #include >> +#include >> + >> #include >> #include >> #include >> @@ -54,6 +56,8 @@ enum fixed_addresses { >> FIX_XEN_SHARED_INFO, >> #endif /* CONFIG_XEN_GUEST */ >> /* Everything else should go further down. */ >> + FIX_PMAP_BEGIN, >> + FIX_PMAP_END = FIX_PMAP_BEGIN + NUM_FIX_PMAP, > > ... you've inserted the new entries after the respective comment? Is > there a reason you don't insert farther towards the end of this > enumeration? I will answer this below. > >> --- /dev/null >> +++ b/xen/arch/x86/include/asm/pmap.h >> @@ -0,0 +1,25 @@ >> +#ifndef __ASM_PMAP_H__ >> +#define __ASM_PMAP_H__ >> + >> +#include >> + >> +static inline void arch_pmap_map(unsigned int slot, mfn_t mfn) >> +{ >> + unsigned long linear = (unsigned long)fix_to_virt(slot); >> + l1_pgentry_t *pl1e = &l1_fixmap[l1_table_offset(linear)]; >> + >> + ASSERT(!(l1e_get_flags(*pl1e) & _PAGE_PRESENT)); >> + >> + l1e_write_atomic(pl1e, l1e_from_mfn(mfn, PAGE_HYPERVISOR)); >> +} >> + >> +static inline void arch_pmap_unmap(unsigned int slot) >> +{ >> + unsigned long linear = (unsigned long)fix_to_virt(slot); >> + l1_pgentry_t *pl1e = &l1_fixmap[l1_table_offset(linear)]; >> + >> + l1e_write_atomic(pl1e, l1e_empty()); >> + flush_tlb_one_local(linear); >> +} > > You're effectively open-coding {set,clear}_fixmap(), just without > the L1 table allocation (should such be necessary). If you depend > on using the build-time L1 table, then you need to move your > entries ahead of said comment. So the problem is less about the allocation be more the fact that we can't use map_pages_to_xen() because it would call pmap_map(). So we need to break the loop. Hence why set_fixmap()/clear_fixmap() are open-coded. And indeed, we would need to rely on the build-time L1 table in this case. So I will move the entries earlier. > But independent of that you want > to either use the existing macros / functions, or explain why you > can't. This is explained in the caller of arch_pmap*(): /* * We cannot use set_fixmap() here. We use PMAP when the domain map * page infrastructure is not yet initialized, so map_pages_to_xen() called * by set_fixmap() needs to map pages on demand, which then calls pmap() * again, resulting in a loop. Modify the PTEs directly instead. The same * is true for pmap_unmap(). */ The comment is valid for Arm, x86 and (I would expect in the future) RISC-V because the page-tables may be allocated in domheap (so not always mapped). So I don't feel this comment should be duplicated in the header. But I can certainly explain it in the commit message. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Jan 05 17:57:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 17:57:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472101.732228 (Exim 4.92) (envelope-from ) id 1pDUU7-0003yE-E1; Thu, 05 Jan 2023 17:56:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472101.732228; Thu, 05 Jan 2023 17:56:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDUU7-0003y7-9b; Thu, 05 Jan 2023 17:56:59 +0000 Received: by outflank-mailman (input) for mailman id 472101; Thu, 05 Jan 2023 17:56:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDUU5-0003y1-Pc for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 17:56:58 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 55a2dd1b-8d22-11ed-b8d0-410ff93cb8f0; Thu, 05 Jan 2023 18:56:55 +0100 (CET) Received: from mail-mw2nam12lp2049.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.49]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 05 Jan 2023 12:56:46 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BN9PR03MB6171.namprd03.prod.outlook.com (2603:10b6:408:100::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 17:56:43 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 17:56:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 55a2dd1b-8d22-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1672941414; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=GdZtvZrOsg8Sj7hTmBkOQFY27J9pWH8YOATNQ+FZNv4=; b=VncuYD7R936i8/gJa2YXn/vHiulqifIqmedUh7iI49ly2AltjjsPc582 e4dSpfRcBPWyHfn6iFEuI8Wwr+8qdH40pU9+Bx1Qji6oiHNotVHUcnMhK kNziwHkEHhmf6R00Agknk7EhCAeFbL+LLHAulJVMpU01kl8Q1jJk7YPch Y=; X-IronPort-RemoteIP: 104.47.66.49 X-IronPort-MID: 90305539 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:LgcBa6n8nTAbdhTZeSWVHgLo5gy3J0RdPkR7XQ2eYbSJt1+Wr1Gzt xIdDGDTOfbfZ2ekftojaN6w80NSupOGnNEwHFRrrXwzESMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icf3grHmeIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aqaVA8w5ARkPqgS5AKGzBH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 bsbGmAcYQCuveiVx7elYdFigcgCHeC+aevzulk4pd3YJdAPZMmZBoD1v5pf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVklI3jOmF3Nn9I7RmQe18mEqCq 32A1GP+GhwAb/SUyCaf82LqjejK9c/+cNNKT+Xlq6U76LGV7lE8Il5KdgOkm/6ajnKmC+hAe nYT2zV7+MDe82TuFLERRSaQonSJoxodUNp4CPAh5UeGza+8yxmdLngJSHhGctNOnNM3QBQ62 1nPmMnmbRR/vbvQRX+D+7O8qTKpJTNTPWIEfTUDTwYO/5/kuo5bs/7UZtNqEarwi8KvHzj1m mqOtHJm2+RVitMX3aKm+1yBmyirupXCUg8y4EPQQ36h6QR6IoWiYuRE9GTm0BqJF67BJnHpg ZTOs5P2ADwmZX1VqBGwfQ== IronPort-HdrOrdr: A9a23:wznkk6152PDbSQyhwfmTkAqjBHYkLtp133Aq2lEZdPU0SKGlfq GV7ZEmPHrP4gr5N0tOpTntAse9qBDnhPxICOsqXYtKNTOO0AeVxelZhrcKqAeQeBEWmNQ96U 9hGZIOcuEZDzJB/LvHCN/TKadd/DGFmprY+ts31x1WPGVXgzkL1XYANu6ceHcGIzVuNN4CO7 e3wNFInDakcWR/VLXBOpFUN9KzweEijfjdEGc7OyI= X-IronPort-AV: E=Sophos;i="5.96,303,1665460800"; d="scan'208";a="90305539" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DLCnfSJAAmZy1e6lyGUu6OIAHSwZboa9yqGaPYb7a7r44D29NjAsHZd2v8gp0sUAuP0KD07cOHT8JEVKZfxDd75RhGx+XJivhOFcvFTPXCIsGGm/9xj6QvVt3dXE618pAiWkmr9TAyCwHqBHH10V1D0Z1Wiw92+9rAmYE+KzsfOGqwTLwC6DwuGplowYM54nfNoI91EXt0LYlc72uNZLavplGLaFygHtpE040pYY7shhUJuOqtvxFHMOXt+No/55L8ihaW/YX1r3xSDp8NeKnWnWDfq2OvA6mvcxOn/xoaD3auV0k7umlcZWTgzG6cGUxNDs61y7qCpiuBBpWUErPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GdZtvZrOsg8Sj7hTmBkOQFY27J9pWH8YOATNQ+FZNv4=; b=ddVpCJi7LzHy8Cv1Xp+iHATHYa32oDZHkm1A7HQjaHgBkiYZn1A2CUmLNZrCBLHzp548UQ3FqcVtQ8vS8eZ99ntJUND2OxhbDmxjQ4RFyAdWYQSt1P3OagazZBQK500VGxl+/kH+R7nA3iguJ188HcQnSNIn188eVovqmWkzqIq9PDZMK6di33DT9EMllojfTAJqQ03MSSM1NjsfWW1GwdN4WfNg5rVQSTbDTuotcLwndUwYlzOJxjTLcuyBxgrWY+obrQTti+damMNyukSj7t8FPFALmlBLGBEZls5LjVeYyv0etkUo3ah7rrRW229OmOfiNMoDeNFs9Nz+VjDr/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GdZtvZrOsg8Sj7hTmBkOQFY27J9pWH8YOATNQ+FZNv4=; b=BHbm2WpuG4MYCiMuzgjf2krOLF/wprdV+ibF0ky1cjJ46ak1Puf8bpupSBUw6N4XmOUK5Jq7vifYoXBnNqsrUog3hWR/ys8rmUgA7Te8WgThaCB7d8lu7VONbVD6lbaqxQkCS/0SmEva/5rOXCdd4/4XmA4PhIZZLigtl6jF/+w= From: Andrew Cooper To: Jan Beulich CC: Wei Liu , Roger Pau Monne , George Dunlap , "Tim (Xen.org)" , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 2/8] x86/paging: fold most HAP and shadow final teardown Thread-Topic: [PATCH 2/8] x86/paging: fold most HAP and shadow final teardown Thread-Index: AQHZFT+yfO+11AII6U6krdJn3spgiq54lXqAgAD0VYCAFqnVgA== Date: Thu, 5 Jan 2023 17:56:43 +0000 Message-ID: <4de3cf99-f8ab-c439-b383-859a41e90517@citrix.com> References: <8d519e00-83c6-aee9-e7ba-523aa4265e1e@suse.com> <780eb542-34b9-c64f-0a40-acc462b87c72@suse.com> In-Reply-To: <780eb542-34b9-c64f-0a40-acc462b87c72@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|BN9PR03MB6171:EE_ x-ms-office365-filtering-correlation-id: 67e2efb6-64f7-451a-afd4-08daef463492 x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: HBCwJX1K0xfL49T3CmNDukRYdJvKkR4X8O+LZ7kEYBy6PVSClQminp5gatOGyg4eViKjIFAeYCY01abfaE/Fj7Hb8B0Ft+cjJKL1Tfdh+TbPii5BNlUu5rBYnuby+AtSflrHAzxdqFXVfIsMUCrV20WaE+rstpA495hSruv2VNMfw8NjHwgs/vW4Nq50ySNBxJDxU+OTUDAxhL48BLy6nGzDY+PpZKFJjlyysiP8IV1+9BRQu7HcE7+YBO6ojSMYfiKT2M47aNIkgxdKFe/+AeJe15UNV7xrxgahX2PhlTYJvozoAXCxIEx3nwoRnHsYx/qsjCPNiPa6GnfuZx2T0HIx0b5A8FP5dRCAoR5L+nfSbKmKxh5ZhU7Jii/xs77llTfqHY9JQw8I0QIKJ3/DO8N7hbJPf71qAgZ3vEwhZ9KBGx9h6hoYwVfpwaW6A0XPVEH+azoIE9sJXQTA1vhzy61u4YfNP4RS6Z7pqQwBe465C8wluFI/rEawpzbzvE7lqHyS9RX1W5wwW4tzX9+BGNrqhFVUmlwVdu3Cl3kbPwkbBgrj1TFyTsreu/y4mQwngcjNfk+edSgfx7MLqy/rECdePjdUr+0Z6MyfFqCDFxOzTJwA8pGao7T/MYmmJx3eR+gykMokt3yCTx77bzwaNAhEwNY2Omfa9Oa+VkIZzv32EPEaWzjOapMllDWs2t9XAMtaMSULQrT4x5zduQAK4paWq2LXQi/nY1XDee0UUpV4GhKhIOhnWpmzR7n9RuBjY0fGCag99VVB6+pXzbvg6Q== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(376002)(346002)(366004)(39860400002)(451199015)(5660300002)(8936002)(41300700001)(8676002)(4326008)(2906002)(66556008)(76116006)(316002)(64756008)(54906003)(6916009)(66446008)(66946007)(91956017)(71200400001)(31686004)(66476007)(6486002)(478600001)(2616005)(26005)(186003)(6512007)(6506007)(53546011)(82960400001)(38100700002)(122000001)(86362001)(31696002)(38070700005)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SEJ6Qm5TTXozMVk0TDREVjRkN0oxbWhqQlVwS1QwcDlKUjl5dVoxbnZWMGIr?= =?utf-8?B?Q2srNmY2OTFqNmxQNGZzenNwNzRmYzhGVTRncW1KWXhDY254TXJObDhKckx3?= =?utf-8?B?ZVdlMGNLQjVMWDl5dkNNNDRnMzR0empVL0tEMFRmZVd2VVllTTJENUlzSUM3?= =?utf-8?B?eFVScnhxVVR4eENvZncvUnAxNER4TFE4WWR2QnM5WTAzeGFIc1hPK05NYlBS?= =?utf-8?B?WGFRTEJjSGNxRmw4SW1GUEVWcjJZK1JiZlNLNGZYemFnUXRGV21ReWpqSDJN?= =?utf-8?B?NjI1OUdjQjYrbklyTERnVk1rYlhiUEE0cExRNEhsdXdRdjk5OHhpYk8vYjVE?= =?utf-8?B?Vm8wSFdSVGVZZUtyd0VkbnE3VWcwZFExSW5Kd0lRb1lEVW5Dc05DL3BBRXZH?= =?utf-8?B?VnpiSzlCM1FYTkFzaEpRU3YxRGpKclUwbzhMWVYrc3FxVEpkWS9kN2FPQlZ3?= =?utf-8?B?WHpvb2xBVkYxVExpVFZhSy8xMnBkbWthb2lmNVVwMitjTUxScW9aaEdNaVl2?= =?utf-8?B?WjdnejRpT09rMFhQWmk5RWlWWDNSajNDbjdXRFJDa2FhK0FGU1YzQkQ2YlN6?= =?utf-8?B?Wml6ZFphNCtIcUZNSGpvVUZtZ1dVc0xmb2ZxUEVBNGxoejJOQVV5LzRycnpX?= =?utf-8?B?QUZGVHF5RzhDMnNpV0IrbDF6eUVSOGFUTGkwdFRKSkhIKy9hNDVVOEtnUHU3?= =?utf-8?B?VzNnc2JzMkgxdVR4YjRjMzByck90VjRmTG5KNXlPN3BJRVMxTzFSUUJERnpl?= =?utf-8?B?UUxSMExIdDlGY2FmSXh0ZnpCRUpXb2ZkeWo5aHE0ZFhyMVhuM1hkL1hmY2FB?= =?utf-8?B?a3VVZlVvRGh3T2hjNkQrZnViM3oxY3FHZ215NzFIZFVkUWY3K0d5amRzMXlM?= =?utf-8?B?MGxuSXJsRnJEQnAxWExlOXA4aGpVRW5wRzlLWGJFZjgvU3FrZHhOelgvbXFk?= =?utf-8?B?RWU2S01nRW9SRTRtcFovTy9YeTk3UDl3c1pwZ0pLcXlveU1EYVVWMnZlWDl1?= =?utf-8?B?OFdqQkpMQ012V0xWODBYOXRUVHBIRnIybzlrZ3BFNmlqUmFSRWw0VHBsYy9T?= =?utf-8?B?Nk51Y3FPeE80bEpxT3FZQmxtYkJhN05YdkZQd3NXMEowS2xFbjQ4Q0F4Qkhw?= =?utf-8?B?Z3ovYXZzbE8zTE1iSXhYOExMZk9NVW5UNWFFc25maHI2T2JrRGpRd2hiZEl6?= =?utf-8?B?ei8xY0x3VElxdW10cHBCdmV2V1RpMFc4Zjd5dGNKM2F0d1V0eVd3N1JXUFR1?= =?utf-8?B?U0lqM1N5UnhQT0d1VEdPa2JobEowM1o4dVpSZTFDVlNSMUJvbU1FMmxNcjV5?= =?utf-8?B?a2VDUEZFSnlCTFJxMDBydkl5VkNnZGJXLzFGTGZBSHoxNkNiblMxN25RQld5?= =?utf-8?B?RWVaanVUdFVaV09LaU1LekRNcVc3YkpRdXFQQ3F0ZW9mN3JDQzRCUmcvcmZC?= =?utf-8?B?L1d5cjBZUXdsWFBrQXluR2thc2ovMHRRdEJJcHVtVDhEQWw3LzBQbExPbGgz?= =?utf-8?B?UjZhM0djYk5XNjF4SWpFVmR0MjRCaUltL2pPVG9scnE1OFZtRWZQRXdhL2t0?= =?utf-8?B?NWo0OVNtM0x3YVB5WDhOY2p1MFJRdUcyeXdMQUh3QW9CV0ZhYnkvSFZybmZN?= =?utf-8?B?Mi9ubmd1bUd2SDN2aFpjS3pHeW9aSVdNOWxSOTBacXcyRG81WWlGdEJUaVNh?= =?utf-8?B?UTJiQjAxeU85ckI1OFF1UEN1NmliTGhBU3NBSVNoWmFqaENpVEpaRUw4Njcz?= =?utf-8?B?Ly9ITHd5UVFBamRNVkVOZDhsMTVWd2lZVFhaalBkYTZZQ1hOTis0NGxGNUxN?= =?utf-8?B?aThibUZUNU1XOXR4ZnZRMGwvMklHOXZYV3dhTEUyN0ZvOWpUMS9ab2VFTFNz?= =?utf-8?B?bHR4RHZtU1oveTB4MVNLV29kbUJkdnROZEgxZmVYK3NUSm9oQnNzNklGeUlK?= =?utf-8?B?Qk9zYWJrZHJNRXBFYXF4L2xmZ0gwYldRUUdYb1BOUFZaSnJXeStPTjVHQXZj?= =?utf-8?B?ZDRxZTd0eUt3S2JtcnhSZ296aHpoY3MwYnBYOEttUERhdGJVS0RYdFlkZHpM?= =?utf-8?B?NEdTTUVUMnhIS3UzSTZwcE8vVzMrZzVBRmdmM0ttOXVQc0VQa1RibzQyU2hq?= =?utf-8?B?UU5JaXV4ODR2aW55VWdhRWhGdmJXemY3MWJJdUhjZEthUHBRMWNqRi9OYk96?= =?utf-8?B?V0E9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: k+E5ZMhKbdStadBdw1m79HIviaKZ51we5sJsVWlqEbgGVJ3/7MuHoYeJFekOE72SX6SECi+yzexXeBA8X1H2RhB5IJ07nTM4bcy9RTajHWzICDjPeOe/qrgdSL4mDhpScIw9ALWXEL1gCPOk1Km9Ur4ubib2zWYLRg5AtkVQy5ncsw43UGnMh1aln+HyMS3oAhBILJphthD92Vl3b64DDsp0iEiU6WZYBSeCIftXfyvdzvRBHkEjD9I6Trz7XxLQjje7ginmnrHnuW71ZoRXIRcs0sZmrcq/XBR3Z94O32YBEG29fy5zmjdGS5JU69/62CIwwOascujnvnEFawhpvrP6ukvI8r7eQb6hwEPD8nGX1rks1eQ8jrYC1mpUuIptlf/j/YI1EguqlPoaOIrMh8djnhxWGF9D/cYmGX+5E8Oh34s0B1koxnFwb9yCinZDy8fBZr8D/IEogboc05XOOjZe3kHi8Gf4MRJZba/6NkmOYcAqvc+C1ecn8b9No8duz5nZEg1hDiOqkPcgXlpzxPSScttE9KWO1HIYJhSviXDCPf/fZCO6pIkdNEw2ZZd9dFpCsB/XL14j0Qpuo5+Y6p9N0REbMaWXcgdBzXZbHSknqYIneP0qlaMNeiE96OkPokVQFJBvp/2cxI9D1MYPFlnQbK/bSb5vO5ExKgSijm0mmCQw9LkTl8/njF54N2NmHlQDEGgyVzh9HXGpGJxxQiVCH8pWjJRLPBC4dNNPA6VeBJotaYqxcgsdZGGURMeB/1XlzXLwtBjdWYf6sQomRYvjDGAYnOMsFLDV+b0Z3jvZRyVexc/xgQtJASmq/fjkw0c4d0rcjI4sGHiggEYxPA== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 67e2efb6-64f7-451a-afd4-08daef463492 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jan 2023 17:56:43.4967 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Dr0WReK5iycGELS96DFQqEUrB24Dv8nvgqdBk3HMhC8/CWySLAgzsTzcPZSMBLdHS5J3GEjXARdqAesgYflh8fe8EQf3rrUfkhhCeOOcf8U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB6171 T24gMjIvMTIvMjAyMiA3OjUxIGFtLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMjEuMTIuMjAy MiAxODoxNiwgQW5kcmV3IENvb3BlciB3cm90ZToNCj4+IE9uIDIxLzEyLzIwMjIgMToyNSBwbSwg SmFuIEJldWxpY2ggd3JvdGU6DQo+Pj4gKyAgICAgICAgICAgICAgICAgIGQsIGQtPmFyY2gucGFn aW5nLnRvdGFsX3BhZ2VzLA0KPj4+ICsgICAgICAgICAgICAgICAgICBkLT5hcmNoLnBhZ2luZy5m cmVlX3BhZ2VzLCBkLT5hcmNoLnBhZ2luZy5wMm1fcGFnZXMpOw0KPj4+ICsNCj4+PiArICAgIGlm ICggaGFwICkNCj4+PiAgICAgICAgICBoYXBfZmluYWxfdGVhcmRvd24oZCk7DQo+Pj4gKw0KPj4+ ICsgICAgLyoNCj4+PiArICAgICAqIERvdWJsZS1jaGVjayB0aGF0IHRoZSBkb21haW4gZGlkbid0 IGhhdmUgYW55IHBhZ2luZyBtZW1vcnkuDQo+Pj4gKyAgICAgKiBJdCBpcyBwb3NzaWJsZSBmb3Ig YSBkb21haW4gdGhhdCBuZXZlciBnb3QgZG9tYWluX2tpbGwoKWVkDQo+Pj4gKyAgICAgKiB0byBn ZXQgaGVyZSB3aXRoIGl0cyBwYWdpbmcgYWxsb2NhdGlvbiBpbnRhY3QuDQo+PiBJIGtub3cgeW91 J3JlIG1vc3RseSBqdXN0IG1vdmluZyB0aGlzIGNvbW1lbnQsIGJ1dCBpdCdzIG1pc2xlYWRpbmcu DQo+Pg0KPj4gVGhpcyBwYXRoIGlzIHVzZWQgZm9yIHRoZSBkb21haW5fY3JlYXRlKCkgZXJyb3Ig cGF0aCwgYW5kIHRoZXJlIHdpbGwgYmUNCj4+IGEgbm9uemVybyBhbGxvY2F0aW9uIGZvciBIVk0g Z3Vlc3RzLg0KPj4NCj4+IEkgdGhpbmsgd2UgZG8gd2FudCB0byByZXdvcmsgdGhpcyBldmVudHVh bGx5IC0gd2Ugd2lsbCBzaW1wbGlmeSB0aGluZ3MNCj4+IG1hc3NpdmVseSBieSBzcGxpdHRpbmcg dGhlIHRoaW5ncyBjYW4gY2FuIG9ubHkgaGFwcGVuIGZvciBhIGRvbWFpbiB3aGljaA0KPj4gaGFz IHJ1biBpbnRvIHJlbGlucXVpc2hfcmVzb3VyY2VzLg0KPj4NCj4+IEF0IGEgbWluaW11bSwgSSdk IHN1Z2dlc3QgZHJvcHBpbmcgdGhlIGZpcnN0IHNlbnRlbmNlLsKgICJkb3VibGUgY2hlY2siDQo+ PiBpbXBsaWVzIGl0J3MgYW4gZXh0cmFvcmRpbmFyeSBjYXNlLCB3aGljaCBpc24ndCB3YXJyYW50 ZWQgaGVyZSBJTU8uDQo+IEluc3RlYWQgb2YgZHJvcHBpbmcgSSB0aGluayBJIHdvdWxkIHByZWZl ciB0byBtYWtlIGl0IHN0YXJ0ICJNYWtlIHN1cmUNCj4gLi4uIi4NCg0KVGhhdCdzIHN0aWxsIGF3 a3dhcmQgZ3JhbW1hciwgYW5kIGEgYml0IG1pc2xlYWRpbmcgSU1PLsKgIEhvdyBhYm91dA0KcmV3 cml0aW5nIGl0IGVudGlyZWx5Pw0KDQovKiBSZW1vdmUgcmVtYWluaW5nIHBhZ2luZyBtZW1vcnku wqAgVGhpcyBjYW4gYmUgbm9uemVybyBvbiBjZXJ0YWluIGVycm9yDQpwYXRocy4gKi8NCg0KPg0K Pj4+ICsgICAgICovDQo+Pj4gKyAgICBpZiAoIGQtPmFyY2gucGFnaW5nLnRvdGFsX3BhZ2VzICkN Cj4+PiArICAgIHsNCj4+PiArICAgICAgICBpZiAoIGhhcCApDQo+Pj4gKyAgICAgICAgICAgIGhh cF90ZWFyZG93bihkLCBOVUxMKTsNCj4+PiArICAgICAgICBlbHNlDQo+Pj4gKyAgICAgICAgICAg IHNoYWRvd190ZWFyZG93bihkLCBOVUxMKTsNCj4+PiArICAgIH0NCj4+PiArDQo+Pj4gKyAgICAv KiBJdCBpcyBub3cgc2FmZSB0byBwdWxsIGRvd24gdGhlIHAybSBtYXAuICovDQo+Pj4gKyAgICBw Mm1fdGVhcmRvd24ocDJtX2dldF9ob3N0cDJtKGQpLCB0cnVlLCBOVUxMKTsNCj4+PiArDQo+Pj4g KyAgICAvKiBGcmVlIGFueSBwYWdpbmcgbWVtb3J5IHRoYXQgdGhlIHAybSB0ZWFyZG93biByZWxl YXNlZC4gKi8NCj4+IEkgZG9uJ3QgdGhpbmsgdGhpcyBpc24ndCB0cnVlIGFueSBtb3JlLsKgIDQx MCBhbHNvIG1hZGUgSEFQL3NoYWRvdyBmcmVlDQo+PiBwYWdlcyBmdWxseSBmb3IgYSBkeWluZyBk b21haW4sIHNvIHAybV90ZWFyZG93bigpIGF0IHRoaXMgcG9pbnQgd29uJ3QNCj4+IGFkZCB0byB0 aGUgZnJlZSBtZW1vcnkgcG9vbC4NCj4+DQo+PiBJIHRoaW5rIHRoZSBzdWJzZXF1ZW50ICpfc2V0 X2FsbG9jYXRpb24oKSBjYW4gYmUgZHJvcHBlZCwgYW5kIHRoZQ0KPj4gYXNzZXJ0aW9ucyBsZWZ0 Lg0KPiBJIGFncmVlLCBidXQgaWYgYW55dGhpbmcgdGhpcyB3aWxsIHdhbnQgdG8gYmUgYSBzZXBh cmF0ZSBwYXRjaCB0aGVuLg0KDQpJJ2QgYmUgaGFwcHkgcHV0dGluZyB0aGF0IGluIHRoaXMgcGF0 Y2gsIGJ1dCBpZiB5b3UgZG9uJ3Qgd2FudCB0bw0KY29tYmluZSBpdCwgdGhlbiBpdCBzaG91bGQg YmUgYSBwcmVyZXF1aXNpdGUgSU1PLCBzbyB3ZSBkb24ndCBoYXZlIGENCiJjbGVhbiB1cCAkWCIg cGF0Y2ggd2hpY2ggaXMgc2h1ZmZsaW5nIGJ1Z2d5IGNvZGUgYXJvdW5kLg0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Thu Jan 05 18:02:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 18:02:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472110.732239 (Exim 4.92) (envelope-from ) id 1pDUZY-0005Wg-6p; Thu, 05 Jan 2023 18:02:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472110.732239; Thu, 05 Jan 2023 18:02:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDUZY-0005WZ-28; Thu, 05 Jan 2023 18:02:36 +0000 Received: by outflank-mailman (input) for mailman id 472110; Thu, 05 Jan 2023 18:02:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDUZW-0005WP-LL; Thu, 05 Jan 2023 18:02:34 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDUZW-0001ga-GY; Thu, 05 Jan 2023 18:02:34 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDUZW-0004mx-3j; Thu, 05 Jan 2023 18:02:34 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pDUZW-0007nK-3D; Thu, 05 Jan 2023 18:02:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=1EU9qurYFQPXc5nUFf7pHcGnW/IEOA6wEcGYqxLA+Mo=; b=6Ms1WXGhmL7u5HhI1AFTu9LQmG XZShUL4aRM5B/0xvZWd8xWspIrQtjac3YEteFtMvNEtBf708oW+bjI6np+AKV92xcIBsEhl+iU7gV /Y+yypQdU4usBr4McDVNrfGrFgx01+tdQmrwHjCCnyOvP9bKoTpYoYmtyL+b2yZ8sQNw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 175579: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=41c03ba9beea760bd2d2ac9250b09a2e192da2dc X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Thu, 05 Jan 2023 18:02:34 +0000 flight 175579 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/175579/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine 8 reboot fail REGR. vs. 173462 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux 41c03ba9beea760bd2d2ac9250b09a2e192da2dc baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 89 days Failing since 173470 2022-10-08 06:21:34 Z 89 days 186 attempts Testing same since 175579 2023-01-05 04:57:31 Z 0 days 1 attempts ------------------------------------------------------------ 3265 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 498271 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Jan 05 19:27:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 19:27:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472119.732250 (Exim 4.92) (envelope-from ) id 1pDVt7-00054V-6s; Thu, 05 Jan 2023 19:26:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472119.732250; Thu, 05 Jan 2023 19:26:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDVt7-00054O-4D; Thu, 05 Jan 2023 19:26:53 +0000 Received: by outflank-mailman (input) for mailman id 472119; Thu, 05 Jan 2023 19:26:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDVt5-00054E-CE; Thu, 05 Jan 2023 19:26:51 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDVt5-0003YM-50; Thu, 05 Jan 2023 19:26:51 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDVt4-0000Ph-Qd; Thu, 05 Jan 2023 19:26:50 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pDVt4-0005JW-QE; Thu, 05 Jan 2023 19:26:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=dPeraHKPSt5Xr24vT/88edpDy/j4fFVsR05C2rQ2J3Q=; b=Qr+6z3kV87dST/biDrGz5WkwDG a3GG9ufcMgtWntxvueVKy9rXSc28RRO/h7fssvWh1ca6auH1AFmPHdUYsElhwVMjf2WxKIOqJLTFj n5QAhL/OXFoh1dj/fgVbGxrnSSemgxOHmzQJutyrF+lpuSr58NPcteUQ3D/wvkSzhmtI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 175589: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=671f50ffab3329c5497208da89620322b9721a77 X-Osstest-Versions-That: xen=c1df06afe578f698ebe91a1e3817463b9d165123 From: osstest service owner Date: Thu, 05 Jan 2023 19:26:50 +0000 flight 175589 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/175589/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 671f50ffab3329c5497208da89620322b9721a77 baseline version: xen c1df06afe578f698ebe91a1e3817463b9d165123 Last test of basis 175568 2023-01-04 14:00:26 Z 1 days Testing same since 175589 2023-01-05 16:01:55 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Demi Marie Obenour Jan Beulich jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git c1df06afe5..671f50ffab 671f50ffab3329c5497208da89620322b9721a77 -> smoke From xen-devel-bounces@lists.xenproject.org Thu Jan 05 19:54:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 19:54:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472128.732261 (Exim 4.92) (envelope-from ) id 1pDWJd-0008MA-BO; Thu, 05 Jan 2023 19:54:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472128.732261; Thu, 05 Jan 2023 19:54:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDWJd-0008M3-8P; Thu, 05 Jan 2023 19:54:17 +0000 Received: by outflank-mailman (input) for mailman id 472128; Thu, 05 Jan 2023 19:54:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDWJc-0008Lx-DR for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 19:54:16 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b92b2737-8d32-11ed-b8d0-410ff93cb8f0; Thu, 05 Jan 2023 20:54:13 +0100 (CET) Received: from mail-sn1nam02lp2047.outbound.protection.outlook.com (HELO NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.57.47]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 05 Jan 2023 14:54:03 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BL1PR03MB5957.namprd03.prod.outlook.com (2603:10b6:208:310::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 19:53:56 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 19:53:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b92b2737-8d32-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1672948453; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=fYJ4tDZPy7y5zf+0cJyZ+4IZankQAXIi/098J4yBmig=; b=G1y5Y65rdr7lZ8AgMs9ix8dp0Pdw1h7JJ59QsqbJNCth8Px4KlN8lqeO 6vTLYGEBLjRPTcEiUSGOpcmxk0RsAfaLHfkTI1pOA3CCnNcv+t4rcuytP d4kSXHUqTLJoMrfuyYrECxCNkm/W7N1IwU4gfCopIx/L4NM56AoQZ3Dxi I=; X-IronPort-RemoteIP: 104.47.57.47 X-IronPort-MID: 93848175 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:7t5sN6PseYxVTN7vrR2TlsFynXyQoLVcMsEvi/4bfWQNrUp31WBVz zQaWGrUa/nZa2agLtAgYdyz9E8Dv8fSyt42Gwto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQA+KmU4YoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvzrRC9H5qyo42tB5gFmPpingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0vxKGU9T+ tJbEx5TPjqyvcuk6+uaSdA506zPLOGzVG8ekldJ6GmDSM0AGNXESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+PVxvze7IA9ZidABNPL8fNCQSNoTtUGfv m/cpEzyAw0ANczZwj2Amp6prr6UzX+rAd1PfFG+3u9WnWyKw3QBMgBVCgqciqG4u2Kna+sKf iT4/QJr98De7neDTNPwQhm5q36spQMHVpxbFOhSwB6J4rrZ5UCeHGdsZiJAbfQ2uclwQiYlv neZktWsCTFxvbm9TXOG6qzSvT60ITISL2IJeWkDVwRt3jX4iIQ6jxaKVdA6Fqew1ofxAWuon 2/MqzUijbIOi8JNz7+84V3MnzOroN7OUxIx4QLUGGmi62uVebKYWmBh0nCDhd4oEWpTZgDpU KQs8yRG0N0zMA== IronPort-HdrOrdr: A9a23:RX9hPKCmqgbJ/JnlHemV55DYdb4zR+YMi2TDtnoBMCC9F/bzqy nAppQmPHPP+VEssVsb6LO90dC7MBHhHP1Oj7X5X43SOTUO0VHAROpfBODZslnd8kPFh4hgPG RbH5SWyuecMbG3t6nHCcCDcuod/A== X-IronPort-AV: E=Sophos;i="5.96,303,1665460800"; d="scan'208";a="93848175" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BjHFKosjOx/x+S9fXC5uTIJEUAXgW8hiR6biz8BAnZPiY3k9IisrgLtSxRWb6x/+mlT8QFZfMyRtAF1rt1f84cL0QoubN6RvDxOjhLIo+pKpa2CD9RVKOMJ4YxYgTyDNqIGxlsnFNlZ3E2FTR0kCGvUThadgNo+E/PL9OipsH55Fa2fwQluS/Amg3GijdIDPryNttNB+h9RuVs8cUW2J7GTNWWsRw3fPlbK541/eBB06lW80BMG6hynykuT5OS1z1fvi2705fv6j0GesJWmvDyNJSOO5yqYwDpTV6crEPxaNfdMo0EBDwP3V++oSJTuf6ejLLIi6PcnBppJv/m2VpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fYJ4tDZPy7y5zf+0cJyZ+4IZankQAXIi/098J4yBmig=; b=RAzb1rd/Tt0g5yNmw4JdGdNvRVqvm/BZWmVMcC4o0aExQTmglKtL406tQUOYuTeXIy8RGngsEXTEF5xUVNsY4eARfQMFbc0frC+xOopXrMpO8tVSdRwvSt3vmntZtYSThRBpbg1rZtu25W4CiUXk/EMD44xMrBrf4dVksTjQXj9saxzaXZZ1vZ2fnUnPJqzfwBP1k1PS9J93Y8LjS8vVdmEajMbQUvBouzjbX+VNcqH4UqvT7o3vvIFk9jF0SRfvFV2Ua1Vt3LMLqBs0e3WmFnvxlqA8mEpl76gkmJ5ISuMB3vcpzuYJGNUvby5YkjBA6s9H2sGeB8QGy1io50aE7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fYJ4tDZPy7y5zf+0cJyZ+4IZankQAXIi/098J4yBmig=; b=e1xGavS1KQKaEdMUcZnNzoaqAyc9t+w7MVM6Sa4GCF1FiNcy8RsrfFbSyCEmBOH00oytDKBrVf8N6DI55F1XM6V3dFieT7z7+MIisNaIb3td9OqNOXlAar9Dcivs5i14sAlG4Xappgk4MalkN1iCEcpqLoDjkFOyG3tq53MX8EE= From: Andrew Cooper To: Jan Beulich CC: Wei Liu , Roger Pau Monne , George Dunlap , "Tim (Xen.org)" , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 3/8] x86/paging: move update_paging_modes() hook Thread-Topic: [PATCH 3/8] x86/paging: move update_paging_modes() hook Thread-Index: AQHZFT/G4QjmyfM5nk+WhnK7qSG8yq54nRIAgADvdgCAFsfagA== Date: Thu, 5 Jan 2023 19:53:56 +0000 Message-ID: <42d0630e-36d6-f5d2-839f-ef5811714807@citrix.com> References: <96b5613f-144d-29ea-9e17-515509c16300@suse.com> In-Reply-To: <96b5613f-144d-29ea-9e17-515509c16300@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|BL1PR03MB5957:EE_ x-ms-office365-filtering-correlation-id: a406e9f9-10d5-4905-225c-08daef569465 x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xNmuFfzB5YK7hzr+qi436xYOIV28x+XRv+lfatVtoXc5XmzyIXEIEDxJJB9FEZwV6QPTx/8AwfI/HZZwuk3E/oP1C9xBvxsv+xSxJBDKEeCpOqz3cNmW3s2HuxLBzWsmABnbDK21wJvHvCSj4zkQAHCnVjYx/M5mjIBWhhgINgqdqrLAKY2A4E7bQ0ZjWzoor6GCq+pEaXzPmznoPeyHxZMKi7ayFPet6tzckg6Ptj2yJ+zEaiiLqkQUBPk5JhPNNkLPNnWbgyFhuXU93p65sjLa0DVQZIPt9WbZc7qm+/FPwbVPLNwURnXVAcvmsR/i6rwr1C3lo4GJhtB9WqUdeFmvaKkGPEi+X5Hqy0Wim14+auOfgvc4X3mnEooIx+Rgcvk0DGSqywV4dOtOFwFfrKwGaqRJ1vm9T7J1KbRpUPaP0xdjFSyU6laatG2XqK5jle+h0H2VmH9FgslZXoPt36HRR81vZW9gwPDLzQMBRrxFzitAsfp2Qb2Cet4vFSKHABeKl0sGEpXFJxBMHzNvK0UlgJTQ6lncw9oX22WWBTYidUIiSFfwxPMG3KmNnEFHqPTLparcNeOQ3i7/ZQfTKJEs3TOLVEalqwQEl46VIvuNad5cC1DcLoLpE5/WQGTOeb85ri54jk+Fwo4WFY6j7E5mKbm3K2ACpeP5c0kN1TMwnmTSzOpAyOduSfWzhEK/rDdhFJqYVGqmsakK8qJtoffWpO4dhuGBijSD9k0yqhs+FhDAIOUMOMyN1HcAUzHaTAH/LaC0fDeSzagnAO9XAQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(366004)(136003)(396003)(376002)(451199015)(83380400001)(26005)(6512007)(6506007)(38070700005)(86362001)(36756003)(31696002)(122000001)(2616005)(82960400001)(38100700002)(53546011)(186003)(316002)(4326008)(478600001)(41300700001)(8676002)(2906002)(5660300002)(8936002)(15650500001)(71200400001)(31686004)(6486002)(76116006)(66476007)(54906003)(66556008)(66446008)(91956017)(6916009)(64756008)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Y01ZTFp4SDVnRFRXUUNjN2lublZqV3cvd3dwejdmbEtiWU4ybCtjRXhQYm5R?= =?utf-8?B?WElTdDlwSlJFNG1UT1VPaWlCZWIzTXlSMHJBRkZwWnFqMEk4VnRwMTJZVVFO?= =?utf-8?B?ZVFBdHFUdnRjcVRhSm9nUzBTYlBOY09JcXNla2JNQnl3QzI0dzNBSXlJSWRh?= =?utf-8?B?K3JYNjJYelRUYys0aXE2c2lGd3NQTXdCdmt2WW1VREdOYjkyZFFhSFcrNTVZ?= =?utf-8?B?cFROSTVkVWZsQ2w3VENuWXNVd05ZTDROd3AyTXMzK005alRPbDZBWTlQb0VD?= =?utf-8?B?MzNGWmRoYUJWS3V3ZkluQUQ3TFFvV2hKbnlzMDRWendDZ0dlakVwampFbzd4?= =?utf-8?B?S0c3d2hEWktrUVJKSWVuTDdEMFhOOXVDajE3bm4xUTYrTXVDT0FqQStBUi9a?= =?utf-8?B?blQwSGV3VndXQUVqbVorYjdRVDZEbzJOVUsvNis1bzhXd2FtcTg0R3c5M0hV?= =?utf-8?B?b0hqVXNRR0QvR29Ncm8rS3EvWExHa1BLT0tUNHBhWUhEMXRyV25PTStLbUhL?= =?utf-8?B?RnNaODQ0dGxMcTFCWUQwenFkL3dESXdOYWlEaHpPaU03d1h4ZGpmYmd1ZVFn?= =?utf-8?B?ZXB4M2dKMGZVWnZiemYxYVNqMHBUT1c3bUxNZysyN1hKelcvTDZsRjRHdGUv?= =?utf-8?B?SGpRbm9nUlFUbDR4NkMrdnVLMnd4UmhOYU5sSjhtbUVva1ArUjJBdHVheURQ?= =?utf-8?B?ZjVuYTBtZ2ZYWmxjd0YzZHpCcm9KRm12VDdCSUY0ZnlEN2cxOW9VZTZNaEkv?= =?utf-8?B?S0N3MmhGbmtXUWVudlIvdW9VVCtTYVhiVS9taEltTm4wYThxUmd4ZzFKNzh3?= =?utf-8?B?NGl6OSsxWEhtMmJRdWZVejRsL3VuMmxFNnhhOUo2RWlvV0h5UG1CczkxZzJa?= =?utf-8?B?cGVpdXBJRU1VRXdHUTNDcVBnaU5SaERIemFTL3pzOEs3MHBmdHdxUzVtT1o1?= =?utf-8?B?K1diZ1c1TUFpY1UweXJYaEZUcFV1Uk9JLzIvYWlLQ1RLaVR2RllwRXhsU0Fl?= =?utf-8?B?VHAxaW03VkFJM0dGOGRuNjZiYmtlOTNIU1h1QVF5VTlua3ArSUozVURVQUNs?= =?utf-8?B?T1EwM3JnTnJHelo1ZFJpNW5ENUU0NVMvT2FQUzBRYm5NUmdNV1pVdFgvVHJn?= =?utf-8?B?dy8zLzJLUGIzUnlCWG9OaGJBeTZVK3FPVkVLeXdwSHdvUnlqSTJlY29XL0RT?= =?utf-8?B?NDNzVGZVbU5mYnAwVmQ3Y2tLSTQ2N2ora1Z4WnNjWWR4d21hM2dvNnp3MHlr?= =?utf-8?B?cS9lNHQ0UGZPdEdVa0h3UEk1dGM5SDhMM1o4aEVyamUveGZyM3B3WTIvaUFY?= =?utf-8?B?ZDBmMEwxcTNSUmJtUHNyOWpDOUhUZmk4dU9CL2JEOFBUUWc0M1hzemhWRmkr?= =?utf-8?B?eXhOUGFkdUg2VDkyTXRHamE1ei96U3dOa0E2cUwxMFh2RnhTU2FBSW00SVFo?= =?utf-8?B?RnB2aEZOR2JTVHdwYWRiTkhQbFovTlFGeVZIOGJNOEYxYVNzdVF0QmhIQkFX?= =?utf-8?B?K2M5b1lyRUJPNi9sMWorTmFyQ0xoZEY2TkdSQVJaOEJtNjRnRFhMcVN1M1E0?= =?utf-8?B?eU04akFSaHgzaUpuMFNtTHNzeFBoNjgxeW4yT2ZBZ2luemRjczNWL2U4MXk2?= =?utf-8?B?WlJHY1dGay9hQ0l1NkhVWks3NThvVXFWVjhMN3YxMkZ2aG5lV0NIY0o1cjZZ?= =?utf-8?B?ZHMrOWxGYUthb2c4R29tOVd5dW5tVGNCNTZ2ekNYVU8vakM5WHRiWkFZdTU1?= =?utf-8?B?dHhxWkRDbC9aRVV4aTNkQXowZWsySzlvYTY4UG52YWhlTVhSTmI4ZkRCbTBH?= =?utf-8?B?ZER6Nmt5NzlVT3dpdFIvNC90VXQzYzhFemtSU1NTUHJvTkFVcnhhTFAwdito?= =?utf-8?B?TG1vQWJiOSsrblVZY0NwQ0pHNGpWM2VBRzZDRnRqZVROQ0NiL1g5MkFuYytL?= =?utf-8?B?SjVYQzFpbHZTU1ZNNy9SeHhSczIreU5rU0JYdmZDRmpmU1dHNS9QRG02NzRC?= =?utf-8?B?NGVlL0RKODQ1TE9tVWY1cXhBSHI4bnRUbkwvUEhOblZBdmxmZW50NldGTTE1?= =?utf-8?B?eVdaVjRDb1dhY2RKMlRFVVUwTXVxWlRaN3lqNlVCeHFJcHhHUXJTVTlFTVNq?= =?utf-8?B?ZnhvL0RzMEV0TGhpeTIvY3d4ZTVGQ2VUU2d1UkFhR2FhTDFYS1hpT2xDSzZk?= =?utf-8?B?MWc9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <196236DCF8F0874888BA9EACB7F358AA@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: ajULz0UhLgcffh0Kb+50XonyB3hoQVK1kOJMnKmjSjI2Um2ybJnE1dblgj3js4TuECAIVqWMRETrEoB+yJ5QvHXBO8Nj3Yds+HRndpydQoKdO22zIzFnYjZwOv65Mqjq5X36UvoyT0MwDr7kMW+kmMNrK9Kq3itXiwGazRnzO1u2e8wTEBRvoPvblXWd7MPhpvHOIafTjah1P1uvvgrU/Gj10zGI3VGIrULnXpU3s0OlD27t30F1f53ORr/gHjl+hV2Qa2W0iuSUVVq+ksDews+hbdcEXjKDayxE68XLFdIcG/iFsxQ9FvOsLkQtYzoB+UFJ00qYmw6owiBD/GJYzS+rQvyPM7jIIbB8GbTnnGG7Cd5s9NKvjtwPVeZdDWVvX6JcUW/J787IDkP3PWXworeIVtCLpC6Ai9UhCVKtHWlguCGfs63oLZxszzVTFVw6il7XvngmtytXWXDxZ5Ns4A2gL6BEneVscFjcpKV8SiXnzqwXwrCuvUJVErxepxI0uQvyeV8bP48UwtJldj/uQC5O3gQ/70pRQGXtjahIjUAQWXQSWp00mY6WHlvlR0KWU/LNlxaNEQYTaiECBN7GElrM+CD1/I6CHn/K6DruaBPCPJkCd8ZP4SzaR8RAxC1mXzAIYgqz+XcDLA3y57s9hnL4hPpEMS72FBvgMFV8MBpuTON99AWFoUSOZG4HOVAdEpAQh6LIizhahUgR0vd9LdU9aNJL097VteMPdSFGTYBX+oxW+C6n58VomR/yApuDFYstOJJEso/oC6fH1yYd3zpgKbi0KtactSMQRtn2FXjWlUZQF/h59Mk0j9UQ3hGJPPN9IinoOWsSNB5us3YyvA== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a406e9f9-10d5-4905-225c-08daef569465 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jan 2023 19:53:56.1759 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: oSYX5YcHIZl4aTmyI//Z2Z4IuAUSfQOO3OvyuWQsy10jMx0GAD3fbGIIzoPCrRY0MN6T6ZtdUkpv90lNMeFF/38ckr3Fl08YnOUrWKZdbVM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR03MB5957 T24gMjIvMTIvMjAyMiA4OjAwIGFtLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMjEuMTIuMjAy MiAxODo0MywgQW5kcmV3IENvb3BlciB3cm90ZToNCj4+IE9uIDIxLzEyLzIwMjIgMToyNSBwbSwg SmFuIEJldWxpY2ggd3JvdGU6DQo+Pj4gVGhlIGhvb2sgaXNuJ3QgbW9kZSBkZXBlbmRlbnQsIGhl bmNlIGl0J3MgbWlzcGxhY2VkIGluIHN0cnVjdA0KPj4+IHBhZ2luZ19tb2RlLiAoT3IgYWx0ZXJu YXRpdmVseSBJIHNlZSBubyByZWFzb24gd2h5IHRoZSBhbGxvY19wYWdlKCkgYW5kDQo+Pj4gZnJl ZV9wYWdlKCkgaG9va3MgZG9uJ3QgYWxzbyBsaXZlIHRoZXJlLikgTW92ZSBpdCB0byBzdHJ1Y3QN Cj4+PiBwYWdpbmdfZG9tYWluLg0KPj4+DQo+Pj4gV2hpbGUgdGhlcmUgcmVuYW1lIHRoZSBob29r IGFuZCBIQVAncyBhcyB3ZWxsIGFzIHNoYWRvdydzIGhvb2sgZnVuY3Rpb25zDQo+Pj4gdG8gdXNl IHNpbmd1bGFyOyBJIG5ldmVyIHVuZGVyc3Rvb2Qgd2h5IHBsdXJhbCB3YXMgdXNlZC4gKFJlbmFt aW5nIGluDQo+Pj4gcGFydGljdWxhciB0aGUgd3JhcHBlciB3b3VsZCBiZSB0b3VjaGluZyBxdWl0 ZSBhIGxvdCBvZiBvdGhlciBjb2RlLikNCj4+IFRoZXJlIGFyZSBhbHdheXMgdHdvIG1vZGVzOyBY ZW4ncywgYW5kIHRoZSBndWVzdCdzLg0KPj4NCj4+IFRoaXMgd2FzIHByb2JhYmx5IG1vcmUgdmlz aWJsZSBiYWNrIGluIHRoZSAzMi1iaXQgZGF5cywgYnV0IHJlbW5hbnRzIG9mDQo+PiBpdCBhcmUg c3RpbGwgYXJvdW5kIHdpdGggdGhlIGZhY3QgdGhhdCBzdHJ1Y3QgdmNwdSBuZWVkcyB0byBiZSBi ZWxvdyB0aGUNCj4+IDRHIGJvdW5kYXJ5IGZvciB0aGUgUERQVFJzIGZvciB3aGVuIHRoZSBndWVz dCBpc24ndCBpbiBMb25nIE1vZGUuDQo+Pg0KPj4gSEFQIGFsc28gaGlkZXMgaXQgZmFpcmx5IHdl bGwgZ2l2ZW4gdGhlIHVuaWZvcm1pdHkgb2YgRVBUL05QVCAoYW5kDQo+PiBhbHdheXMgNCBsZXZl bHMgaW4gYSA2NC1iaXQgWGVuKSwgYnV0IEkgc3VzcGVjdCBpdCB3aWxsIGJlY29tZSBtb3JlDQo+ PiB2aXNpYmxlIGFnYWluIHdoZW4gd2Ugc3RhcnQgc3VwcG9ydGluZyBMQTU3Lg0KPiBTbyBkb2Vz IHRoaXMgYm9pbCBkb3duIHRvIGEgcmVxdWVzdCB0byB1bmRvIHRoZSByZW5hbWU/IE9yIHVuZG8g aXQganVzdA0KPiBmb3Igc2hhZG93IGNvZGUgKGFzIHRoZSBIQVAgZnVuY3Rpb24gcmVhbGx5IGRv ZXMgb25seSBvbmUgdGhpbmcpPyBBcyB0bw0KPiBMQTU3LCBJJ20gbm90IGNvbnZpbmNlZCBpdCds bCBiZWNvbWUgbW9yZSB2aXNpYmxlIGFnYWluIHRoZW4sIGJ1dCBvZg0KPiBjb3Vyc2Ugd2l0aG91 dCBhY3R1YWxseSBkb2luZyB0aGF0IHdvcmsgaXQncyBhbGwgaGFuZC13YXZpbmcgYW55d2F5Lg0K DQpXaXRoIExBNTcsIEhBUCByZWFsbHkgZG9lcyBiZWNvbWUgMiB0aGluZ3MuwqAgVXNpbmcgYSA1 LWxldmVsIHdhbGsgYXQgdGhlDQpIQVAgbGV2ZWwgaXMgYSBwcmVyZXF1aXNpdGUgZm9yIGJlaW5n IGFibGUgdG8gVk1FbnRyeSB3aXRoIENSNC5MQTU3IHNldCwNCm9uIGJvdGggSW50ZWwgYW5kIEFN RCBoYXJkd2FyZSBJSVJDLg0KDQpUaGVuLCBmb3IgVk1zIHdoaWNoIGRvbid0IGVsZWN0IHRvIGVu YWJsZSBMQTU3LCB3ZSB3aWxsIGJlIGluIGEgNC1vbi01DQoodG8gYm9ycm93IHRoZSBzaGFkb3cg dGVybWlub2xvZ3kpIHNpdHVhdGlvbi4NCg0KVGhlIGNvbW1lbnQgYnkgcGFnaW5nX3VwZGF0ZV9w YWdpbmdfbW9kZXMoKSBpcyBmYWlybHkgY2xlYXIgYWJvdXQgdGhpcw0Kb3BlcmF0aW9uIGJlaW5n IHN0cmljdGx5IHJlbGF0ZWQgdG8gZ3Vlc3Qgc3RhdGUsIHdoaWNoIGZ1cnRoZXINCmRlbW9uc3Ry YXRlcyB0aGF0IGhhcCB2ZXJzaW9uIHBsYXlpbmcgd2l0aCB0aGUgbW9uaXRvciB0YWJsZSBpcyB3 cm9uZy4NCg0KPg0KPj4+IC0tLSBhL3hlbi9hcmNoL3g4Ni9tbS9zaGFkb3cvbm9uZS5jDQo+Pj4g KysrIGIveGVuL2FyY2gveDg2L21tL3NoYWRvdy9ub25lLmMNCj4+PiBAQCAtMjcsNiArMzIsOSBA QCBpbnQgc2hhZG93X2RvbWFpbl9pbml0KHN0cnVjdCBkb21haW4gKmQpDQo+Pj4gICAgICB9Ow0K Pj4+ICANCj4+PiAgICAgIHBhZ2luZ19sb2dfZGlydHlfaW5pdChkLCAmc2hfbm9uZV9vcHMpOw0K Pj4+ICsNCj4+PiArICAgIGQtPmFyY2gucGFnaW5nLnVwZGF0ZV9wYWdpbmdfbW9kZSA9IF91cGRh dGVfcGFnaW5nX21vZGU7DQo+Pj4gKw0KPj4+ICAgICAgcmV0dXJuIGlzX2h2bV9kb21haW4oZCkg PyAtRU9QTk9UU1VQUCA6IDA7DQo+PiBJIGtub3cgeW91IGhhdmVuJ3QgY2hhbmdlZCB0aGUgbG9n aWMgaGVyZSwgYnV0IHRoaXMgaG9vayBsb29rcyBicm9rZW4uwqANCj4+IFdoeSBkbyB3ZSBmYWls IGl0IHJpZ2h0IGF0IHRoZSBlbmQgZm9yIEhWTSBkb21haW5zPw0KPiBJdCdzIGJlZW4gYSBsb25n IHRpbWUsIGJ1dCBJIGd1ZXNzIG15IHRoaW5raW5nIGJhY2sgdGhlbiB3YXMgdGhhdCBpdCdzDQo+ IGJldHRlciB0byBwdXQgaW4gcGxhY2UgcG9pbnRlcnMgd2hpY2ggb3RoZXIgY29kZSBtYXkgcmVs eSBvbiBiZWluZyBub24tDQo+IE5VTEwuDQoNCkFueSBjaGFuY2Ugd2UgY291bGQgZ2FpbiBhIC8q IHNldCB1cCBwb2ludGVycyBmb3Igc2FmZXR5LCB0aGVuIGZhaWwgKi8NCnRoZW4gPw0KDQp+QW5k cmV3DQo= From xen-devel-bounces@lists.xenproject.org Thu Jan 05 19:58:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 19:58:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472136.732272 (Exim 4.92) (envelope-from ) id 1pDWNp-0000bf-Um; Thu, 05 Jan 2023 19:58:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472136.732272; Thu, 05 Jan 2023 19:58:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDWNp-0000bY-S4; Thu, 05 Jan 2023 19:58:37 +0000 Received: by outflank-mailman (input) for mailman id 472136; Thu, 05 Jan 2023 19:58:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDWNp-0000bQ-7V for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 19:58:37 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5570c304-8d33-11ed-91b6-6bf2151ebd3b; Thu, 05 Jan 2023 20:58:35 +0100 (CET) Received: from mail-bn8nam12lp2175.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.175]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 05 Jan 2023 14:58:31 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SJ2PR03MB7111.namprd03.prod.outlook.com (2603:10b6:a03:4f4::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 19:58:29 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 19:58:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5570c304-8d33-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1672948715; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=A5DcOx1HurqUvgeh7+k8zn9b8IirzaV/OriLckeh4Hk=; b=Mlp/CeQrAiSbVJT8gjMWCRrFIGXZueFuTZwCws12wQ2Hunr6cfIhiKpm 6Qy7pgpOmuxK9/cyNcgIpAYBsEKRVB4DEy6oPDjSor53+R649M76K5Ihw xayiZLCk95it5/2JCWg9QlffPXRYiRpYdSZpJUCefxHF6Jd/JQi/LhM9m A=; X-IronPort-RemoteIP: 104.47.55.175 X-IronPort-MID: 91373675 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:SUBD3K4s/PD5/zJEPIOu4AxRtM/GchMFZxGqfqrLsTDasY5as4F+v jFKCjqFbqmOYjanfNx3O4+28UJXvsfVndZkSwE/+38xHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraBYnoqLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+4pwehBtC5gZlPakT4QeF/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m/ PhIEA5dahC4gOuPnKKdWLJ9lJkgM5y+VG8fkikIITDxK98DGMqGaYOaoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6OkUooj+WF3Nn9I7RmQe18mEqCq 32A1GP+GhwAb/SUyCaf82LqjejK9c/+cNNLT+LjqKE36LGV7nMwDwJGb1u+mqW4lmifZPAEE 2w4/iV7+MDe82TuFLERRSaQonSJoxodUNp4CPAh5UeGza+8ywqUA2ksTzhfaccnvss7WTwr0 FCSm9rjQzdotdW9THuH876OoDCaOC4LLHQDbysJUQsE5db4pIg5yBnIS75LD6qdntDzXzbqz FiisCk7r6Uei4gMzarT1UDKhXegq4bESiYx5x7LRSS14wVhfomnaoe0r1/B4p59wJ2xS1CAu D0OnZiY5eVXV5WVznXSHaMKAa2j4OuDPHvEm1lzEpI99jOrvXm+YYRX5zI4L0BsWioZRQLUj IbokVs5zPdu0LGCNMebv6rZ5xwW8JXd IronPort-HdrOrdr: A9a23:8LwbLqibOOMxa/Nn/EPnU5OCpXBQXiAji2hC6mlwRA09TyX5ra 2TdTogtSMc6QxhPE3I/OrrBEDuexzhHPJOj7X5Xo3SOTUO2lHYT72KhLGKq1Hd8kXFndK1vp 0QEZSWZueQMbB75/yKnTVREbwbsaW6GHbDv5ag859vJzsaFZ2J921Ce2Gm+tUdfng8OXI+fq DsgPZvln6bVlk8SN+0PXUBV/irnaywqHq3CSR2fiLO8WO1/EuV1II= X-IronPort-AV: E=Sophos;i="5.96,303,1665460800"; d="scan'208";a="91373675" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T2YyvaLvZvrl3ZruLCpIl93JC4EYd06NrS8HhlF3EVWJqTaO+e3UEWkvG1D0mSHHF5k/3XhwFIUx+E3Yjo9Q6IiJgUldKFyHbr5X23zennlAHuTY2N/th5CdbpqnQBP0+XIQd/1NRNpTWzVpGYmUcJg8pWBIFXroMb6EeoSg2G9X1WNsrXw36yYYtdWljNVtLmayRsiHp+4n17ue2HJ3X52G1LHzDEhsn+M2G+mfe5p/isJeCbNmFIEx+ke2iy+znN0tI2Zt6L7CtIzTPoWmbjI4GURhcMbqAP3aKmRj/xIrPLuQfEQoJUhjXNLTVnEfEJdoNObwLFnIjzXFUyblTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A5DcOx1HurqUvgeh7+k8zn9b8IirzaV/OriLckeh4Hk=; b=GKIcsnA0LpeKE2C2/NOUsnsrGmM9pqGYbrbljVtWTXmLsO5fIpF1uD7zLYYSkZF2W6JCqMHXeAehQXGrcRGeaCNYTlWyIP+czz+v4/K3JrbhP8I2zqK0Zc7ocJ7R5EiyLeJ+XUyuTlTRddfRbfgKhhgBDsEXOJBwjXvHm+KyDM3/Imq0Zs488JJjn3Xqe+mbZy3/IH51jV4bhFkb1rf4COMvsMuRLJvNhGopWnb4o5Dbx8JqyOfNr9MKcQcZBKNEzMgsYeBw9+DT2PaGqeq748fwXO9b6T+tuToeJ6lW0xQB0lfy47nToDD9hSxTHVJ464GPQ+3/Ujo6oKnkohuIug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A5DcOx1HurqUvgeh7+k8zn9b8IirzaV/OriLckeh4Hk=; b=ioebbGTWgv9qbVNkiN4x/IHPYF9YCDzyka8iIBxFYTsNOqJA57zmoTRfMpsqI1jf2lx3TJwRrOIAxCn8KWHZwe+PfAhVwSPvxe2TPHAakJmDNRaHPOtys1nZ6j+YaZPmRXYoMSZUKwsoo56BWmosOifKjkkiYvfJ1LsALsMcjZ4= From: Andrew Cooper To: Jan Beulich , Demi Marie Obenour CC: =?utf-8?B?TWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tp?= , Roger Pau Monne , Wei Liu , "Tim (Xen.org)" , George Dunlap , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH v6 3/5] x86/mm: make code robust to future PAT changes Thread-Topic: [PATCH v6 3/5] x86/mm: make code robust to future PAT changes Thread-Index: AQHZFlVFWAiHUIB/Aka1sujnPXJ1rq6P77GAgABjzAA= Date: Thu, 5 Jan 2023 19:58:29 +0000 Message-ID: <52df603e-624c-56ae-dd5b-c732f3ca5fe6@citrix.com> References: <00505454afa89b759122008852502a5ef7b1b1ee.1671744225.git.demi@invisiblethingslab.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|SJ2PR03MB7111:EE_ x-ms-office365-filtering-correlation-id: 90df5c1e-ff22-4256-8e66-08daef573707 x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: LjSnePJvZTwgIOZdHkPQuGjMvcApVPFlnQBz1CEFLzTdsWVBTcHjCjkVCPeOmM/KXs9ETW9fn8TjxJ9oEIuTipH9ZaaOF8s4fcVoF9vKRqIbKkGxuSZ6FnQbUf8EM1hbmBaCPQfjFGe4a8UxJztFZLY1krsjAGGbcqIVSYxc8A2SvNzGTKu9NZvMy4JJ4mo7JKioQ5eSBauaVC062ZBC4Ab1dHJDnq6J4GYdgfdi0uGn+YH2CiDKkYcdSjMTwKXr1RqdwBA6zEM//mdQ9kH0Vse+ZEJZRatv47TCy7FuW/vs/52xZYPtgMJyryNWkJHF80COT30WJWfe2fy54lvc6F4SJ2NxMuLsyFz/7afuUr4raa6vIR8MWFpMMIt6cPWR3L33zfjRJxuMOgNHw44dJ8mmmAp14vYZj+sF/SjEN+cFI0BeJeIzUQ+of6Sl7FU1HS4S+K/whUCW8zKjsHsvm6BHgJYVTFJ++S1+8T06KrcHujaW5hLZp65AmlnlpXwnpRpeeazVDaPPE8hFqahnTLQSDQtW8xQQJsfJJiI7pXTBbfGq1sE/1jkQf3l5WIigSVQzwQLjyu7DM07kPtfpFBlHtrIYIKl31Bj2EJwLzlcCPpSC3zlCs3+BrQVVUHndXicctg3LGLxRwCpzgVMB6KR5lj55zlojffMxRCqhKCiDlTSAcp8u2C623cr+xLuJwvQwcnlx2pioFB8qNsSwmzRqVZApP3jMgmSE0VUdWFEmVXuQKronkZOqe6aPfpuMSpK8Gok7dLJwNBUlY/cJ8Q== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(366004)(346002)(136003)(39860400002)(396003)(451199015)(6512007)(186003)(26005)(91956017)(31686004)(71200400001)(478600001)(6486002)(6506007)(110136005)(53546011)(2616005)(66556008)(66446008)(66946007)(4326008)(41300700001)(64756008)(8936002)(76116006)(66476007)(8676002)(4744005)(5660300002)(2906002)(38100700002)(122000001)(38070700005)(82960400001)(31696002)(316002)(86362001)(54906003)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?RVJGNm1HSU5LNnZmMExEY29XQXlDWnJwdkRITnRnYUkzSUtPT3NFQ2lZYktI?= =?utf-8?B?SFk1K3B4d3l1K2xJbEp3bWJGZnAycXp0NlhuQk4xWHJMbW5wazFtWDg4Z3U3?= =?utf-8?B?WXQ1cmtCcHNqNytvVmZsMVJnMXBaSEdWQUdGYkVuTitMUGZHMXJxU3RMMTR0?= =?utf-8?B?b2Ezall1aTNYVld5TldjSDJCeFNmZ05LY25EVEd5YmFBNFRjWElaejIyMldo?= =?utf-8?B?ODhKaVRqT1JpaHhBamV2WUI0dEN6bWtpQ002b1l0UEFqWm5wdTZsUGozd21p?= =?utf-8?B?amFLOWthSExxTDRTZitjL09kWGF0WjA3SFdxQVc4UWg5ZGY0YzgrRU1Vb0gy?= =?utf-8?B?NkdZeS9tRCttbXZqVm1MTXo5elNVNWp4akwzOStEOGpQTWlWUGxCWE91UTRE?= =?utf-8?B?OHFTZmNKQy9Jd0Zib0VaUXBYZGpsNVl6cUtuVmN2dEt2cmVNY1p3Mnd5Wlc2?= =?utf-8?B?emFSV04waGdZcEVFZXBDcXpzOFFBeVlzdHV6NndSWWcyMVJkVDNVdjQ0bVJr?= =?utf-8?B?NGt6ZXVMMVN1b1ZzOFlVVEVaMFoyN055VnVLcitqWGIrSGhYZVpWZW5JM2Rp?= =?utf-8?B?MmFoMVNZamdEdkN0M1dtYUlZbG5UenhSN3RsMk9VYU5YcjBnTWxaelQvTWFG?= =?utf-8?B?WlJGZEJ5VVhHa0tOSm9YdTVBK0tIcTBSZHE4b2U5WWdlczE0b2RUY1dDQjVN?= =?utf-8?B?c21YVSttZUhMcjVkSVpFdnR4SERMTVJYZHZjcjdhUU0vdG5zNm84cC80MTF3?= =?utf-8?B?NXMwMjhhTjhyaGNzWGR1OU5YeVVSU1NDRHRmVHFlbTBLckRmV2dHdmYyUjQ0?= =?utf-8?B?Zmc3N0xPVW5VTXNLbXNiYVR6Vi9wMnlKT3YvQWFCSlh1ZkMrL0Z6M05oOFJX?= =?utf-8?B?WVl6cXNCbkRCVS9kc0l6WVkzejR5WDRlT3RSNHFNN3djWnVFL1RzRHZVYS95?= =?utf-8?B?b3ppRjByQ0ZYbUJwcmdOZ0x4S3N5dXNRcGI4ZGVIb1V4L1NCeS92cnYzL1ZT?= =?utf-8?B?MTdqWE4reUVxeW1GL3hxUk41YVJrclFocFNpekJ3QW5yL05SR3BSQjh1SkFE?= =?utf-8?B?T2Nic1dWeS8rZmFNd0pMeFVVT1hXTXduaWs5eitlYnRCbXBmalhTZkFSN0Qv?= =?utf-8?B?QWpQVG5GOGlYcWRMSzFTZS90RmZWM0lnMXhyY0x3MVROMGg2TjIwenBWRUNo?= =?utf-8?B?Q0o0ZDBBUEJ0U2JIZUZiV0J2NXZYNHBUcmI3NzZvY2I3NXJURE5QcW5JbGFt?= =?utf-8?B?cW1YZXRtTmVWV29KOUx5R3l4NnltY0hUZTEzNE9DOFpoTGFGZFNQS2IwUXlJ?= =?utf-8?B?blNoTzhRZEhlK0w2c3Jzd1BzelA0d3U4Nk5GNi9kYUNpT00rejFTRVN2SG5s?= =?utf-8?B?TXB0c3RHd3liK2tEVDJkVUtEcEhOWjMxWEFnajRuRlJJMjNZelVzZWdNOTh6?= =?utf-8?B?dXNjckdEcUxPNGdmdWRxalovSGhVam1LNDBOM01HVzNMbDRYclFtajJWalNO?= =?utf-8?B?OCtiYjN3WWoxTkl5cFQzTFZaZElvSVhvNFNxQXIrUERRUDduMUR0bnMxMHcy?= =?utf-8?B?SkJmNVplWlFlYTM3b2ZOZ0VMdkczaDNPZFBIQnpQdElDZU1KaDd2aFU3cHNI?= =?utf-8?B?VFc2WkU0NlZSaWhZSVFiU1RwRndmdDhYQ3pXOGFpSzFiNEdjbjN4bFRoYW0z?= =?utf-8?B?Zyt3dXJwbndZbWlPWXQ2c3cyVU5YbFp3enUvSzdMM2trUk5md3JJMjZ0SW5G?= =?utf-8?B?MXVtdzZRQVVFSmV2MGd1Y2VSaE5wbWJKZWJhZjl3UkFrQUpicUlNeGRTQ1ha?= =?utf-8?B?aHVvVDJMOUJwWTZicThUTTVRZU9ycDl2Q0lDWmlnRXp4ZzM2dHY1dXZGRngx?= =?utf-8?B?Y2VWUVIzaW9kQzl3VlU3bjFROWJWM3RwQ2IrcTFwQWhuTkJOTFByVVVXSWh2?= =?utf-8?B?bTFRdGI4K2lWcFFQaWNRL29tNmFhMlc0WklZZG85dnVZcU80SnhsOXhvMGZs?= =?utf-8?B?YXNWZENtSHJGTk9LTUduS3hrQkh0RnZ2MjdELzNiYlJ1VlFFVDQ1bGdSU2l3?= =?utf-8?B?aEJpRWpicDFnV1BSVEZ1TXpNN01uK3NoRzNkakV5UUg3cWYyNlA3L1crZ1J5?= =?utf-8?B?R3c1Sm9WekRUVFduSHJ5QXE1anhGQXJWVTlQN3RrT2FjT2hTb0hFSGFCenJQ?= =?utf-8?B?L3c9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <00F1820B124F124B8B6C10D840CE692E@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?Y1k1NnV4dG05eHVkU1kvbUsrdUd5VXdwNU9KRUQ3TXRkKzlqOFFES1JaTnhS?= =?utf-8?B?WmNBdWdTVVREZ1hXQzkvTDAwdXpTZC9GTklReEZYK1J6eFdKc2xHRFJYTHMx?= =?utf-8?B?WWdJVGwyYUNsMDVjOCtoR1dwbUt6Und0UUg4VzVvY2dwNytPUmpHY21OSmZV?= =?utf-8?B?NHZMb0tlbzJ4K3FOUTFjbHM1S2JLV1UxMlN5YTB6SnMyYm9wTEJuRDZpWEEz?= =?utf-8?B?dFNwYmw0R1V2VDJPZ01xTmcyM2U4eWdxMG5helAxMWpmMTh4dFo3cGxNWm1p?= =?utf-8?B?MkgwQmJITXlTNWtXekFFM3VmYjM3TkF2bTREa0NCZjBzMkVFK3M3UmxYUGhR?= =?utf-8?B?b3FsTHE1OEtSeUd2LzluL2VFdGxQZXlwblVNRnA0MEt0bDN5WXlFVjF6OHZm?= =?utf-8?B?eTJBY2ZjeFoxS2s5ckUxbDB1RWN3SThGT0VEOHF4M3lKeDdNejdRRnZCRjdy?= =?utf-8?B?K0FjL205alIvMHp1Z21ISEp6ampuSnFCWFRkTm9jb0tnWXBNaVlPVHFsOE9O?= =?utf-8?B?TUpxT09wMFJtTjlhVHpEb0dHUDRlcHhWT1B4TllGWnZVQkVBMXJkZkVPalk3?= =?utf-8?B?YTNJeERTL1AyTURWa1o4TVNIZXFwcmovSlhOVlFkcHQvaE0rYytGZmFkd01P?= =?utf-8?B?WEdxdmtyOFV4NHpIOElpN3BPK0xLWTB3R0d6VEczcnM4TlBlbXZ5N29idFVJ?= =?utf-8?B?eWxKTStwb3NCTzlJcGdhcE1MajlCd3MwektsVXhLdlkrZ0FFTFJSakc1N2N5?= =?utf-8?B?TDM5UVRDUFNaOWwwVk5SQnZDcERYTGJvWkVwaEh5OE51TVBwVTdyMmJtL0NM?= =?utf-8?B?RmFvSFRYb1prWlF4OHRQdWV6aUZBckZYMWZUcDQ5ZzVaTWU1MTlJRDk3bVR4?= =?utf-8?B?RlJmRWF3T3dHdTBvVnB3WTR6OURNY0JpNmlxb0Y4UWlEajFvSXRJWXc0Q1hv?= =?utf-8?B?UHFBc2RYT004dmtJL2hqTjJ6a0NqTHlHa0VDeTB2ei9DYmZIaFZoN2txWTNQ?= =?utf-8?B?VkkybThjNlRFeFNzeXI0RHRtaXloVXNvRVhLSk5EWVpRT1pFZkk2aUtBc2FH?= =?utf-8?B?cFJLQWdUVVc0WGZBd2JVSVZGL0VqM0VLV0NDQkdGVWdHRThRL2J5RG9KcW90?= =?utf-8?B?dWpTaFh0MU5QNDRzQTdxYS9aNHVXY1E1VDJwcHU4ZlMyU3pOcVBTL0pGU1JK?= =?utf-8?B?NDlMRndJV3ZRWnJOamNQTkZqemVRVDJSSldiSFVNRE5jL0FvU1kyN05YR1I5?= =?utf-8?B?ZWZaYlp1SFhHaURCbVV3L0Y3QUpMZjlEd0E4Z0w3V20vNDZUdz09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 90df5c1e-ff22-4256-8e66-08daef573707 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jan 2023 19:58:29.0469 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: TPIWb6wAnITXz6UMltIEA89Wd7MpGjecZzRf+PkCE3o9jzHPPm/zMzudlKNNE8w3fXdjymY3CMZnyVtu51aW/v55FgebrpIlsGeG1YyIu8s= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR03MB7111 T24gMDUvMDEvMjAyMyAyOjAxIHBtLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMjIuMTIuMjAy MiAyMzozMSwgRGVtaSBNYXJpZSBPYmVub3VyIHdyb3RlOg0KPj4gLS0tIGEveGVuL2FyY2gveDg2 L21tLmMNCj4+ICsrKyBiL3hlbi9hcmNoL3g4Ni9tbS5jDQo+PiBAQCAtNjM1Miw2ICs2MzUyLDEx IEBAIHVuc2lnbmVkIGxvbmcgZ2V0X3VwcGVyX21mbl9ib3VuZCh2b2lkKQ0KPj4gICAgICByZXR1 cm4gbWluKG1heF9tZm4sIDFVTCA8PCAocGFkZHJfYml0cyAtIFBBR0VfU0hJRlQpKSAtIDE7DQo+ PiAgfQ0KPj4gIA0KPj4gKw0KPj4gKy8qDQo+IE5pdDogUGxlYXNlIGF2b2lkIGludHJvZHVjaW5n IGRvdWJsZSBibGFuayBsaW5lcy4NCj4NCj4+ICsgKiBBIGJ1bmNoIG9mIHN0YXRpYyBhc3NlcnRp b25zIHRvIGNoZWNrIHRoYXQgdGhlIFhFTl9NU1JfUEFUIGlzIHZhbGlkDQo+PiArICogYW5kIGNv bnNpc3RlbnQgd2l0aCB0aGUgX1BBR0VfKiBtYWNyb3MsIGFuZCB0aGF0IF9QQUdFX1dCIGlzIHpl cm8uDQo+IFRoaXMgY29tbWVudCBpcyB0b28gc3BlY2lmaWMgZm9yIGEgZnVuY3Rpb24gb2YgLi4u DQo+DQo+PiArICovDQo+PiAgc3RhdGljIHZvaWQgX19pbml0IF9fbWF5YmVfdW51c2VkIGJ1aWxk X2Fzc2VydGlvbnModm9pZCkNCj4gLi4uIHRoaXMgbmFtZSwgaW4gdGhpcyBmaWxlLg0KDQpJTU8s IHlvdSByZWFsbHkgZG9uJ3QgbmVlZCB0byBjb21tZW50IGJ1aWxkX2Fzc2VydGlvbnMoKS7CoCBJ dCdzIGENCnBhdHRlcm4gd2UgdXNlIGVsc2V3aGVyZSwgYW5kIHRoZSBCVUlMRF9CVUdfT04oKSdz IGFyZSBpbmRpdmlkdWFsbHkNCmNvbW1lbnRlZC4NCg0KSSdkIGp1c3QgZHJvcCB0aGlzIGh1bmsg ZW50aXJlbHkuDQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Thu Jan 05 20:28:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 20:28:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472143.732283 (Exim 4.92) (envelope-from ) id 1pDWqq-000431-7R; Thu, 05 Jan 2023 20:28:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472143.732283; Thu, 05 Jan 2023 20:28:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDWqq-00042u-4F; Thu, 05 Jan 2023 20:28:36 +0000 Received: by outflank-mailman (input) for mailman id 472143; Thu, 05 Jan 2023 20:28:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDWqp-00042k-5p for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 20:28:35 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 840dda3e-8d37-11ed-b8d0-410ff93cb8f0; Thu, 05 Jan 2023 21:28:31 +0100 (CET) Received: from mail-mw2nam10lp2108.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.108]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 05 Jan 2023 15:28:28 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DM6PR03MB5017.namprd03.prod.outlook.com (2603:10b6:5:1ee::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 20:28:26 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 20:28:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 840dda3e-8d37-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1672950511; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=3Brf3BTM2yp64T+Ybhf1eDYGhFqzzLxM11WSv72X/XE=; b=C29z4icAFt4RTKpOy3XWziCRFHb4lvUMyg5Nnmh0ggJQCAlLSaPGupvi rzy508nhpL9lG1heYFS0KC5LNEhzhtmt9p9Xz42dnkUsI6mnccToNTgGZ JZOJGfahQMPzFZhZeME9/oaTMdVF/cjZP4LK0JjaNB5+kwuKYjRztSf5Q 8=; X-IronPort-RemoteIP: 104.47.55.108 X-IronPort-MID: 91377134 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:5HYGcq5l0/+SaxhwbLzycQxRtM/GchMFZxGqfqrLsTDasY5as4F+v mpKWDjXP/aMMGDzfN9zOYS/oRgAu8fUm9RkGQY5rHoxHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraBYnoqLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+4pwehBtC5gZlPakT4QeF/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5mz OIfdyImPkG6q+e0xI7kYcV9xdshFZy+VG8fkikIITDxK98DGMiGZpqQoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6OkUooiOiF3Nn9I7RmQe18mEqCq 32A1GP+GhwAb/SUyCaf82LqjejK9c/+cNNLT+Lnr6U26LGV7nVMV0EuUl2endeegEejBMluB GEM/DV7+MDe82TuFLERRSaQrHOBvzYdXcRRCOww7AyRyqvS7B2dD2JCRTlEAPQ2uclzSTE02 1uhm9LyGScpoLCTUWia9LqfsXW1Iyd9BWoLfyoNVwYGy9jlvoAojxjLQ8pjEai6ldn8E3f7x DXihCo0iqgXjMUL/76m5l2BiDWpzrDWSiYl6wORWXiqhitlZYuNd4Gur1/B4p59wJ2xS1CAu D0BhJKY5eVXVZWVznXVEKMKAa2j4OuDPHvEm1lzEpI99jOrvXm+YYRX5zI4L0BsWioZRQLUj IbokVs5zPdu0LGCNMebv6rZ5xwW8JXd IronPort-HdrOrdr: A9a23:QsKeJKrVWbObZ5vgS29hFPYaV5r/eYIsimQD101hICG9E/bo8v xG+c536faaslkssR0b9+xoQZPwJU80rKQFhrX5Xo3SPjUO2lHFEGgK1+KLqQEIfReeygc078 xdmsNFeb7N5DZB7foTNGGDYq8dKMbuytHWuQ/Op00dKz2Ddclbnn9E4wygYzFLrFQvP+tDKH KFjvA33QZJYhwsH7mGOkU= X-IronPort-AV: E=Sophos;i="5.96,303,1665460800"; d="scan'208";a="91377134" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LD/UWG8VzebcNoOk7SPqsCyl+nTffsHe8QpB0Vuq2oTcY/Jq749FfNPvAYGio2m9sdwfKBXBOKi71WmQcACKrougWzjdpo+I8WJdzKayjQGGS9gS+Cn2B6UsQevoyTNVKp3Yn9bEQi5MduNMMaqdX0AreZYW7XXk9LeUpQG3qwSXHjz4LQslK+eeyZHfBl/ZMDl7ZzCQkprG1YDEgpYvclsiPXK2bvBozSeD9Ld4CmiHuK6S7GQQZHlaYWh2NLl9fREL3lmac8JQ0e0BifY1nQ5VSBVKj1RzIqe6D2ZMdlhDteZzT8jCa7B8KmGN5uAXVSXmoSyTQlJ2DU5vsFSzMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3Brf3BTM2yp64T+Ybhf1eDYGhFqzzLxM11WSv72X/XE=; b=KNJFVuf0RS0te31QSxcj6gXnmvAEAR7vBY/UDYkAwT4yI4Ntib8i4aCtiRB+0+TBGzzS2w9aHSJwC2nuLZcQ59qI9oakcJcUYTTA1WH5dDMU5ZeUSykp9JSasvh+uYiTaFN8+ccKSbn30DWuQuSpvMvtSIYso4AGsWBS/fIbss2jtmN3K8bRMv4klPyUhywwctqSDLO8rhDPa/Xcyw2TZnlduifW6kJJk734f8HSzYHf+0APDppEIwqrLhHiHR9Gi4SWFA/PPPvTBf8rqFQUkNMUkvBgZUmdAxEX/wrZkWDwzABJcaRA1Ir4L78bY6dg5WD4jY3f1HbRMuM1/CJmMQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3Brf3BTM2yp64T+Ybhf1eDYGhFqzzLxM11WSv72X/XE=; b=eH1S7z7xP+vxHazu+YSZBp5p87svwqSJUHwu8IdRT0hxOo2WRH4AXNpMAYx8YklI1xYIwrY78TVeWWT7o5sTniXp610refqRxIEKGuoxlLyNCwubv4dws3wTzwVwwdkOkBCcyuO2GHhnJNevfB7KkURHxj35X7n1l9O7XcQJN7E= From: Andrew Cooper To: Demi Marie Obenour , "xen-devel@lists.xenproject.org" CC: =?utf-8?B?TWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tp?= , Jan Beulich , Roger Pau Monne , Wei Liu , "Tim (Xen.org)" , George Dunlap Subject: Re: [PATCH v6 4/5] x86/mm: Reject invalid cacheability in PV guests by default Thread-Topic: [PATCH v6 4/5] x86/mm: Reject invalid cacheability in PV guests by default Thread-Index: AQHZFlU8BnV2WctoSkOEZs7zNTRXG66QW9uA Date: Thu, 5 Jan 2023 20:28:26 +0000 Message-ID: References: <2236399f561d348937f2ff7777fe47ad4236dbda.1671744225.git.demi@invisiblethingslab.com> In-Reply-To: <2236399f561d348937f2ff7777fe47ad4236dbda.1671744225.git.demi@invisiblethingslab.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|DM6PR03MB5017:EE_ x-ms-office365-filtering-correlation-id: dd9dce96-99f8-4f8d-5f19-08daef5b6626 x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gkqglxggRT2enXx90sWB8lBtZs1iUl3miOz8EfUdtJMGNXj00h6C4cfcta1CMGsfDeSDRZ87QAQuHNXnWqATV226+rUoP5Q55+wRVbWkrL/N+rl9Q+4uN5Wpr9+3sq8PFU4+YtEp6wuGxLo2oqnv9sRvVFkcQvvRaDgWp7j6WodaBqjQEQumDwUMaYWowajZj7W8K2sgSUlDHYUtnE06gpqCVhEnI1tYOys9ReVREfSwHsJx3RsoWSE/qkk60fAPs47Zxp5bpZjH8MjmEWxIP6nBUTAfT0jwaL1Lk9hoIlPNbV7BqzVK9Sqg9XpTR18v+JDQFVWMFcfSji24zkTTBWUfBzoozsiLMmH3Op4LoDiRnxIeP+MBj+NtWVAlbP3JPIYGh+M+FioEbTH4XvIaFlzbSVJ2JQQtYRz/KjGChfwKV85igY0hbPUMjBktnMNkrmqE2NGaLhalDwVCPuI+9ArqmPv4LU+bkG5QmMT3Q8c+3ymJPlLLhBWeLBXHOu1SmT3QK5Sn8j3SSfF2UXBR1Dvgiw+ebmPQr7GA83sjI6Mk508fCq1iJgjwHpHkFL3hPf0/srdYgrOt42z3LFDHqFnOiJ+ut3bWLhCAMpEov2FKVS/ma6yZ/FAE92JFLXObhmGEhrX56P0ByjfRb+0LUrKqd5UmsbFN+IzyAAlwnICBW96OYfn1FgwBM3PDzAp1a/Pa+B7XNGttB/Tf5XPTCOdQKQd4dwPv4ILMW5aQxFnx9MOkHqAiCN4EqRrv7PyvjPVukMYL+Bj1ZzhdxrQ07A== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(396003)(376002)(366004)(346002)(451199015)(2906002)(5660300002)(71200400001)(8936002)(41300700001)(478600001)(4326008)(316002)(8676002)(66556008)(76116006)(66476007)(64756008)(66446008)(110136005)(66946007)(91956017)(54906003)(31686004)(6486002)(26005)(6512007)(107886003)(6506007)(83380400001)(2616005)(122000001)(53546011)(38100700002)(186003)(82960400001)(86362001)(38070700005)(31696002)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?cmZxOTNnYWZMTWhjSFUwN3dHejVja1I4RzM5V2QwUmNoNit5Z3BVSHFvcncz?= =?utf-8?B?UDcrYVJqcEpwT0JvVTFOby9ZSnp2ampIbW1KZ3RZaUwzWVRucUN3VVp0b0Ex?= =?utf-8?B?WkZkc0pGd1lzcStBTCs5NzBDZDhHZEFnZG1URGNUNFowR09hUmR3MjR6Q2FO?= =?utf-8?B?MnJRWUlXbm4yaHFlZUtCS1hGWktNSkg1SlNzQzJDTnprQXE2WGR0ODRPWGpS?= =?utf-8?B?TC9ZZGdhaHUzMU5QSUUrMWNqUkljUEJrYXdhVXMxV3pzU1RpRjI4ZHUwVnIx?= =?utf-8?B?L0N3R3ZiRkUwbmoza2xxMFgrcDcvWVRDL01yRTZvNVFVeGY4dXcwMW5va3BV?= =?utf-8?B?T2xBOWd6NFFHVzFXRkIxRXN4dTRJWlVwb3R6NzhYc25RMC9XTkUzeEsvekc4?= =?utf-8?B?S0FnVndrYmp1SlpLWEN5TTNKWHdRWUlCSXJhclNHV1QySjM0TTJEdDU2eUh4?= =?utf-8?B?TzRweDF1cG9ENmk4SHFYTER3N3dqZXJDdzg4QzJPSHpWZVg3aGp2bk0wQTJI?= =?utf-8?B?SXk1Zk00c0h3WDE2NVRzbWpuZ2NyUUJqbjE0NkYvR1JoYXNMbEVXYUhuWHdw?= =?utf-8?B?OWhqbGthWDdEcXpZcGE1eG9oSTJ1VWVxc2Z2M0dUdlFuNmViaEM2KzdjWEtV?= =?utf-8?B?WDZxaTV5NDBBR2tGQVlnaGlHLyszMTA3dXZpVzVoY0plSWdIOVFma3BiN2pH?= =?utf-8?B?ZDdZSm9DQUtLeUtxbTVjRDdzSzRYS2NvQ3hrTnB3bWt2MHdHTjQyT3N1aFZm?= =?utf-8?B?Q3kzd1Q3U1FYVWRwVnhValV5blZxaU5NL0FGUTJuellaTG9JbzdrVGxnS1lM?= =?utf-8?B?OEF5UHJJTmpvbUN4VXE4a1hWZFd6OG4wekV4WUhwZHdNS3IyeWo5aENnSld2?= =?utf-8?B?a3MxdFFJSW1wUUN3NEMzYmt4Tk50Y2puQWw4d3c0alJUalM4YmtDakZMODlH?= =?utf-8?B?cmVOejlRUVpIb09yTUZTVEQ0S1NTY2pJSW1wYXl5YWNpRG95ZmpvVm14OWt5?= =?utf-8?B?OEZWZHRmL29qbm56K0RnSjRLdnBDZXJHRXdsMHlwcUF5WUVWamhoME05MGpi?= =?utf-8?B?bUUxSElWV3JJajB3ZFNrZDN6WU5vNFAvZHFwTXI1Y3Y2VWVFTnZ3dmtyZ0Qx?= =?utf-8?B?NHJKTUQ3RDZQZEpQTk45YzltdmlydDZ6ejNkZGcveEVxQWRVVko2VzJKUFdS?= =?utf-8?B?bllUQWNoOXkyMVhhaXZGRWV1R21mNmN6dW8vblNneUp2a1ZlNDVwVG14VGl0?= =?utf-8?B?cGRzUFBTSFhQN28xQjJ0UXhpRFNOV0UraFU1OWdVUHVoN1piV01wYVlIbWti?= =?utf-8?B?VXNWVDNITlBEU0VZVysrN3I3WXduamppa1dYQUYzMTIzNnVWQnd2NmwreFBP?= =?utf-8?B?RzdxS0poR0dxZzljOSsyVnIxNkFjRExnZXU0MXhUaVdjZjR3R1l4N05sMFR5?= =?utf-8?B?clFoa2x4V1A0SnNldHRXMmdtZnJHRUNmczE4UGFYQmI4WHNUMVphTFJzbitB?= =?utf-8?B?SHpQNFF2L2xISm91UEdjQWV5VTgvN1pPSEljRk1kZGVudFZJek4wQnpMZm5H?= =?utf-8?B?QWx6bkx5d3Z3NTJFUVR3dFBsSDRFYnFubzBqTVV5Yml0T3BMUkMwQWdIQUtu?= =?utf-8?B?a0c2RllqZnhIT3V6NGMwUzRlL0s2dnhjYS8vM1hFeGxUUTY3SVVOUG8zY1Mz?= =?utf-8?B?aDZQS2g2YVlWbm1wZGxDMVdTQnFGU0NCS0F5SUxQeTFDQ0VUUkdVbTBsMlRO?= =?utf-8?B?T3cvcjZpaE93dWNoaVBRTFFUQjh2ZHVjSlV1UnlTRFdvNGdra0RoUWVqVzBi?= =?utf-8?B?RWFzZDZGQzQwbUozcGVuQ01tTFlXdzNUU01ZYnNqVE9xeVRGbmlJUkorWEM4?= =?utf-8?B?K08zanV6RkVUbnZtV09kdzBjQmtHSXpYUTZmV1Z4Sy9DZ0pIU2tVWi9meEFN?= =?utf-8?B?VWRhay81OU42czYwc0k0M0JzODNyK3pFMmhxVklRa1Y3M2t4TXBHU0piQTVn?= =?utf-8?B?ZTkxQ3E1L1RtQi84eGFYaGt1eUpFK3ZnZTNWMVdsVWdtR3FSSEc5WnNiT2VT?= =?utf-8?B?eDRzeWFPOFNySjdxT1l0TzlJVjN2VU5HcjF2bWw4ODZ5WU04RU44c2Y5dFlk?= =?utf-8?B?ME9yYjlBQjh3T1ZFeEVwdXhkY3NpdUpMd1JPNDc1bnd6R1hvVE5QcW9PMDlq?= =?utf-8?B?YXc9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <9289119F77DBB54D877676899D7893FB@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?dkdiSCtTM3A2YzZHZnZsU3haU2FlN2hGTHZYM0FZZnpieE5nQzJkRStGaGdv?= =?utf-8?B?ekFBZ3R0cE9QSGpSYWhWUkRFcDZENGF1Ti9LOUk2SmZOd0pRcGVtK0xzTzRB?= =?utf-8?B?OWtHQVRhbEtzZzJaNUdpYW42Y1c5YTZneVRFRGdYalJnL2c4Y2JjMWpCTGEv?= =?utf-8?B?VkZ2ZFNHOGhUNzYrMTliSDFOL3diMHBtZzc1ZXJMaFhvN0N4Tjlzckd1ajNm?= =?utf-8?B?bVdoaXhUWW12Rm95OTA5N3lHOUdWcCtsRTZPTlN0Tkhtc2ZzdGVMTmpqQk1j?= =?utf-8?B?dHlWZ1MrbFZIY0w2WTRtWDBMNnpQMnRPbXpXRElqcWo2eXM4VjZaVXZyMVZ3?= =?utf-8?B?SmhMeVU3SzBNOTdNTzc3UVNaZ21DeGlDaE1FaHZzZkFTWWQ4VWUrL3oxN2Y2?= =?utf-8?B?azV6Vk1SZ2FUZWdodEpSeGNYcjRTaCthWjMwMUl3Z3MzMnBPVlNkbnZEY2hq?= =?utf-8?B?TGdIVTM4dWRpeFJtYUR2d1daeHJkZk9nem52TzhWelB1QnZQeGNsZS9QUjNL?= =?utf-8?B?UkcvcTVVMDVSL2YvV1lvdXBiOWxhUkx0MjhKVDZ6cVBIN1hIdkhNczRwNEhr?= =?utf-8?B?djhoSENsY1Racm5jSUVPeFFRNlEyQXpGQVlJS0tzUDRBZlRXTW9hczlOVWN4?= =?utf-8?B?RzJ2YUlydmxTOTVFZ1BpMHo5anoveDMwcy9LVGFtQ1NKUVlhZXVJNnA3R1Rh?= =?utf-8?B?eFlzQmhMdkxJc3NLeURaMUtEamt0QmppaFpwOEhVNVlHay9iTVVqdnBCQ0pK?= =?utf-8?B?aGg0eUdTNHVOaWRZS0REZDhLNVFpUXgvcWFMUVd4TmFRTzJ3R3B0WG1XUG45?= =?utf-8?B?TXNES2huaThPTkpvalVJTVhJNm1YS0M0RE9KWktZOFRtWmJpV2szbDdvTGRy?= =?utf-8?B?cStoN1I1MzFUSFc3czlLTGl2WEIyaUgyREUxYnhkbXk1R1RSUkNsdnFXS1lH?= =?utf-8?B?ZFVxYldndUtvRXZuVW83VTFRbHJuSFErUThRWHlUb2tGSUJjT3kxVThseG9I?= =?utf-8?B?OVc1dGJOb1BsTy94cjcvMzg4S0lqMHpKQVJUc2ZhRVdLczE0S2pxNnFVVHJm?= =?utf-8?B?L2gyajdsdlRzYnNNYllQRCsxZFBNNE01b281VDdtY2tOSG02Smp5a0dQY08z?= =?utf-8?B?RUZUUjBpeVh4OTFkNTlwZXJNWDlHSDlwUGZQQ055bmlvMEpJUDhhRzQ0TGxZ?= =?utf-8?B?Zzd5Vlp5ekQ1KzRBRkZaTEFkM3p1S1E0dlVURS85UExySlVCNHZUSFpzRUpW?= =?utf-8?B?TkFVdENkcm04UWdvZmE4dmkyK0NtY1FCZzVWaVU4UHE2cmpVdz09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dd9dce96-99f8-4f8d-5f19-08daef5b6626 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jan 2023 20:28:26.0574 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0BhOetJbSr8p7P6Kv2FiLPk+Uzn/rS+SKXJmri1WLrROMwoueQIYVgK/nZI8ztKLKJzL3Ekj1w8wXZdMVav22ByMA7Vm8bCBSLFOrDjBSjE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5017 T24gMjIvMTIvMjAyMiAxMDozMSBwbSwgRGVtaSBNYXJpZSBPYmVub3VyIHdyb3RlOg0KPiBkaWZm IC0tZ2l0IGEvZG9jcy9taXNjL3hlbi1jb21tYW5kLWxpbmUucGFuZG9jIGIvZG9jcy9taXNjL3hl bi1jb21tYW5kLWxpbmUucGFuZG9jDQo+IGluZGV4IDQyNGIxMmNmYjI3ZDZhZGUyZWM2M2VhY2I4 YWZlNWRmODI0NjU0NTEuLjAyMzBhN2JjMTdjYmQ0MzYyYTQyZWE2NGNlYTY5NWYzMWY1ZTBmODYg MTAwNjQ0DQo+IC0tLSBhL2RvY3MvbWlzYy94ZW4tY29tbWFuZC1saW5lLnBhbmRvYw0KPiArKysg Yi9kb2NzL21pc2MveGVuLWNvbW1hbmQtbGluZS5wYW5kb2MNCj4gQEAgLTE0MTcsNiArMTQxNywx NyBAQCBkZXRlY3Rpb24gb2Ygc3lzdGVtcyBrbm93biB0byBtaXNiZWhhdmUgdXBvbiBhY2Nlc3Nl cyB0byB0aGF0IHBvcnQuDQo+ICAjIyMgaWRsZV9sYXRlbmN5X2ZhY3RvciAoeDg2KQ0KPiAgPiBg PSA8aW50ZWdlcj5gDQo+ICANCj4gKyMjIyBpbnZhbGlkLWNhY2hlYWJpbGl0eSAoeDg2KQ0KPiAr PiBgPSBhbGxvdyB8IGRlbnkgfCB0cmFwYA0KPiArDQo+ICs+IERlZmF1bHQ6IGBkZW55YCBpbiBy ZWxlYXNlIGJ1aWxkcywgb3RoZXJ3aXNlIGB0cmFwYA0KPiArDQo+ICtTcGVjaWZ5IHdoYXQgaGFw cGVucyB3aGVuIGEgUFYgZ3Vlc3QgdHJpZXMgdG8gdXNlIG9uZSBvZiB0aGUgcmVzZXJ2ZWQgZW50 cmllcyBpbg0KPiArdGhlIFBBVC4gIGBkZW55YCBjYXVzZXMgdGhlIGF0dGVtcHQgdG8gYmUgcmVq ZWN0ZWQgd2l0aCAtRUlOVkFMLCBgYWxsb3dgIGFsbG93cw0KPiArdGhlIGF0dGVtcHQsIGFuZCBg dHJhcGAgY2F1c2VzIGEgZ2VuZXJhbCBwcm90ZWN0aW9uIGZhdWx0IHRvIGJlIHJhaXNlZC4NCj4g K0N1cnJlbnRseSwgdGhlIHJlc2VydmVkIGVudHJpZXMgYXJlIG1hcmtlZCBhcyB1bmNhY2hlYWJs ZSBpbiBYZW4ncyBQQVQsIGJ1dCB0aGlzDQo+ICt3aWxsIGNoYW5nZSBpZiBuZXcgbWVtb3J5IHR5 cGVzIGFyZSBhZGRlZCwgc28gZ3Vlc3RzIG11c3Qgbm90IHJlbHkgb24gaXQuDQo+ICsNCg0KVGhp cyB3YW50cyB0byBiZSBzY29wZWQgdW5kZXIgInB2IiwgYW5kIG5vdCBhIHRvcC1sZXZlbCBvcHRp b24uwqAgQ3VycmVudA0KcGFyc2luZyBpcyBhdCB0aGUgdG9wIG9mIHhlbi9hcmNoL3g4Ni9wdi9k b21haW4uYw0KDQpIb3cgYWJvdXQgYHB2PXtuby19b29iLXBhdGAsIGFuZCBwYXJzZSBpdCBpbnRv IHRoZSBvcHRfcHZfb29iX3BhdCBib29sZWFuID8NCg0KVGhlcmUgcmVhbGx5IGlzIG5vIG5lZWQg dG8gZGlzdGluZ3Vpc2ggYmV0d2VlbiBkZW55IGFuZCB0cmFwLsKgIElNTywNCmluamVjdGluZyAj R1AgdW5pbGF0ZXJhbGx5IGlzIGZpbmUgKHRvIGEgZ3Vlc3QgZXhwZWN0aW5nIHRoZSBoeXBlcmNh bGwNCnRvIHN1Y2NlZWQsIC1FSU5WQUwgdnMgI0dQIG1ha2VzIG5vIGRpZmZlcmVuY2UsIGJ1dCAj R1AgaXMgZmFyIG1vcmUNCnVzZWZ1bCB0byBhIGh1bWFuIHRyeWluZyB0byBkZWJ1ZyBpc3N1ZXMg aGVyZSksIGJ1dCBJIGNvdWxkIGJlIHRhbGtlZA0KaW50byBwdXR0aW5nIHRoYXQgYmVoaW5kIGEg Q09ORklHX0RFQlVHIGlmIG90aGVyIGZlZWwgc3Ryb25nbHkuDQoNCj4gQEAgLTEzNDMsNyArMTM3 NCwzNCBAQCBzdGF0aWMgaW50IHByb21vdGVfbDFfdGFibGUoc3RydWN0IHBhZ2VfaW5mbyAqcGFn ZSkNCj4gICAgICAgICAgfQ0KPiAgICAgICAgICBlbHNlDQo+ICAgICAgICAgIHsNCj4gLSAgICAg ICAgICAgIHN3aXRjaCAoIHJldCA9IGdldF9wYWdlX2Zyb21fbDFlKHBsMWVbaV0sIGQsIGQpICkN Cj4gKyAgICAgICAgICAgIGwxX3BnZW50cnlfdCBsMWUgPSBwbDFlW2ldOw0KPiArDQo+ICsgICAg ICAgICAgICBpZiAoIGludmFsaWRfY2FjaGVhYmlsaXR5ICE9IElOVkFMSURfQ0FDSEVBQklMSVRZ X0FMTE9XICkNCj4gKyAgICAgICAgICAgIHsNCj4gKyAgICAgICAgICAgICAgICBzd2l0Y2ggKCBs MWUubDEgJiBQQUdFX0NBQ0hFX0FUVFJTICkNCj4gKyAgICAgICAgICAgICAgICB7DQo+ICsgICAg ICAgICAgICAgICAgY2FzZSBfUEFHRV9XQjoNCj4gKyAgICAgICAgICAgICAgICBjYXNlIF9QQUdF X1VDOg0KPiArICAgICAgICAgICAgICAgIGNhc2UgX1BBR0VfVUNNOg0KPiArICAgICAgICAgICAg ICAgIGNhc2UgX1BBR0VfV0M6DQo+ICsgICAgICAgICAgICAgICAgY2FzZSBfUEFHRV9XVDoNCj4g KyAgICAgICAgICAgICAgICBjYXNlIF9QQUdFX1dQOg0KPiArICAgICAgICAgICAgICAgICAgICBi cmVhazsNCj4gKyAgICAgICAgICAgICAgICBkZWZhdWx0Og0KPiArICAgICAgICAgICAgICAgICAg ICAvKg0KPiArICAgICAgICAgICAgICAgICAgICAgKiBJZiB3ZSBnZXQgaGVyZSwgYSBQViBndWVz dCB0cmllZCB0byB1c2Ugb25lIG9mIHRoZQ0KPiArICAgICAgICAgICAgICAgICAgICAgKiByZXNl cnZlZCB2YWx1ZXMgaW4gWGVuJ3MgUEFULiAgVGhpcyBpbmRpY2F0ZXMgYSBidWcNCj4gKyAgICAg ICAgICAgICAgICAgICAgICogaW4gdGhlIGd1ZXN0LiAgSWYgcmVxdWVzdGVkIGJ5IHRoZSB1c2Vy LCBpbmplY3QgI0dQDQo+ICsgICAgICAgICAgICAgICAgICAgICAqIHRvIGNhdXNlIHRoZSBndWVz dCB0byBsb2cgYSBzdGFjayB0cmFjZS4NCj4gKyAgICAgICAgICAgICAgICAgICAgICovDQo+ICsg ICAgICAgICAgICAgICAgICAgIGlmICggaW52YWxpZF9jYWNoZWFiaWxpdHkgPT0gSU5WQUxJRF9D QUNIRUFCSUxJVFlfVFJBUCApDQo+ICsgICAgICAgICAgICAgICAgICAgICAgICBwdl9pbmplY3Rf aHdfZXhjZXB0aW9uKFRSQVBfZ3BfZmF1bHQsIDApOw0KPiArICAgICAgICAgICAgICAgICAgICBy ZXQgPSAtRUlOVkFMOw0KPiArICAgICAgICAgICAgICAgICAgICBnb3RvIGZhaWw7DQo+ICsgICAg ICAgICAgICAgICAgfQ0KPiArICAgICAgICAgICAgfQ0KDQpUaGlzIHdpbGwgY2F0Y2ggY2FzZXMg d2hlcmUgdGhlIGd1ZXN0IHdyaXRlcyBhIGZ1bGwgcGFnZXRhYmxlLCB0aGVuDQpwcm9tb3RlcyBp dCwgYnV0IHdvbid0IGNhdGNoIGNhc2VzIHdoZXJlIHRoZSBndWVzdCBtb2RpZmllcyBhbg0KaW5k aXZpZHVhbCBlbnRyeSB3aXRoIG1tdV91cGRhdGUvZXRjLg0KDQpUaGUgbG9naWMgbmVlZHMgdG8g YmUgaW4gZ2V0X3BhZ2VfZnJvbV9sMWUoKSB0byBnZXQgYXBwbGllZCB1bmlmb3JtbHkgdG8NCmFs bCBQVEUgbW9kaWZpY2F0aW9ucy4NCg0KUmlnaHQgbm93LCB0aGUgbDFfZGlzYWxsb3dfbWFzaygp IGNoZWNrIG5lYXIgdGhlIHN0YXJ0IGhpZGVzIHRoZSAiY2FuDQp5b3UgdXNlIGEgbm9uemVybyBj YWNoZWF0dHIiIGNoZWNrLsKgIElmIEkgZXZlciBnZXQgYXJvdW5kIHRvIGNsZWFuaW5nIHVwDQpt eSBwb3N0LVhTQS00MDIgc2VyaWVzLCBJIGhhdmUgYSBsb2FkIG9mIG1vZGlmaWNhdGlvbnMgdG8g dGhpcy4NCg0KQnV0IHRoaXMgY291bGQgYmUgc29tZXRoaW5nIGxpa2UgdGhpczoNCg0KaWYgKCBv cHRfcHZfb29iX3BhdCAmJiAobDFmICYgUEFHRV9DQUNIRV9BVFRSUykgPiBfUEFHRV9XUCApDQp7 DQrCoMKgwqAgLy8gI0dQDQrCoMKgwqAgcmV0dXJuIC1FSU5WQUw7DQp9DQoNCmZhaXJseSBlYXJs eSBvbi4NCg0KSXQgb2NjdXJzIHRvIG1lIHRoYXQgdGhpcyBjaGVjayBpcyBvbmx5IGFwcGxpY2Fi bGUgd2hlbiB3ZSdyZSB1c2luZyB0aGUNClhlbiBBQkkgQVBULCBhbmQgc2VlaW5nIGFzIHdlJ3Zl IHRhbGtlZCBhYm91dCBwb3NzaWJseSBtYWtpbmcgcGF0Y2ggNSBhDQpLY29uZmlnIG9wdGlvbiwg dGhhdCBtYXkgd2FudCBhY2NvdW50aW5nIGhlcmUuwqAgKFBlcmhhcHMgc2ltcGx5IG1ha2luZw0K b3B0X3BiX29vYl9wYXQgYmUgZmFsc2UgaW4gYSAhWEVOX1BBVCBidWlsZC4pDQoNCn5BbmRyZXcN Cg== From xen-devel-bounces@lists.xenproject.org Thu Jan 05 20:49:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 20:49:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472152.732294 (Exim 4.92) (envelope-from ) id 1pDXAU-0006VT-Tr; Thu, 05 Jan 2023 20:48:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472152.732294; Thu, 05 Jan 2023 20:48:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDXAU-0006VM-RG; Thu, 05 Jan 2023 20:48:54 +0000 Received: by outflank-mailman (input) for mailman id 472152; Thu, 05 Jan 2023 20:48:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDXAT-0006VG-A6 for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 20:48:53 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5b9bb47e-8d3a-11ed-91b6-6bf2151ebd3b; Thu, 05 Jan 2023 21:48:51 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5b9bb47e-8d3a-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1672951731; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=r4XtkTJHtLTXCBT8B4UdVIsiYW9W6Ow00fDClOE0Tyg=; b=LLLDGAPuzRYRBI6AaNBbPV42exrE68jVXs3YtyEGWSu3kY8LPX51E2lP NEH5dvFNrE4YLrqX4t/YkvfOknXuUeqxelDYnqed2w/aY1QByBBvIjzYo JoJOy9T/56wemgKhKAD9MUP4TjoZVYRUM8Wl6C07QDAAwMkvTjAWWs9tV s=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 93855203 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:V20rZ6kmwjj9cq3e9eJzEV/o5gxLJkRdPkR7XQ2eYbSJt1+Wr1Gzt xJNDT3XPfrbZzSjKtAlOdywp0xQvJPWmNVrSwA6pX1mESMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icf3grHmeIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aqaVA8w5ARkPqgS5AKGzBH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 d4DEgEIcgCAu8eryfWaa+1Ktsd+N/C+aevzulk4pd3YJfMvQJSFSKTW/95Imjw3g6iiH96HO ZBfM2A2Kk2dPVsfYT/7C7pn9AusrlD5fydVtxS+oq0v7nKI5AdwzKLsIJzefdniqcB9zx3I+ z+cpz+R7hcyGf3A52SH6lyQpLWfk2TiXaM1DriJz6s/6LGU7jNKU0BHPbehmtGmjmauVtQZL FYbkgIrpLI3/VamTfH8WQO5u3+OuhMAW9tWHPY+4QvLwa3Riy6VC20FZj9Hdt09tcUySCAq1 1mGhNfgD3pkt7j9YWKQ8PKYoC2/PQARLHQefmkUQA0d+d7hrYovyBXVQb5LMoS4k9n0EjHY2 C2RoW41gLB7sCIQ//zlpxad2Wvq/8WXCF5ujunKYo67xiFiXr+ge5yr1X3G5LFhDYK/flrcp 0FRzqBy89syJZ2KkSWMRsAEE7eo++uJPVXgvLJ/I3Uy32/zoiD+JOi89Bk7fR40aZhcJVcFd WeJ4WtsCIlv0GxGhEOdS6a4EIwUwKfpDrwJvdiEP4MVMvCdmOJqlRyChHJ8PUi3yyDAcollY /93lPpA6l5EYZmLNBLsG48gPUYDn0jSP1/7S5Hh1AiA2rGDfnOTQrptGALQMbposPjZ8FSJo oc32y62J/N3Cr2Wjs7/qNd7ELz3BSJjWcCeRzJ/LIZv3TaK6El+UqSMkNvNiqRunrhPl/egw 0xRrnRwkQKl7VWecFXiV5yWQO+3NXqJhS5hbHNE0JfB8yRLXLtDG49FJsdvLeJ3qrY8pRO2J tFcE/i97j10Ymyv01wggVPV9eSOqDzDadqyAheY IronPort-HdrOrdr: A9a23:5lCdTqEnYyuT4xgkpLqE7MeALOsnbusQ8zAXPiFKJSC9F/byqy nAppsmPHPP5gr5OktBpTnwAsi9qBrnnPYejLX5Vo3SPzUO1lHYSL1K3M/PxCDhBj271sM179 YGT0GmMqyTMbGtt7ee3DWF X-IronPort-AV: E=Sophos;i="5.96,303,1665460800"; d="scan'208";a="93855203" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Demi Marie Obenour Subject: [PATCH] x86/S3: Restore Xen's MSR_PAT value on S3 resume Date: Thu, 5 Jan 2023 20:48:39 +0000 Message-ID: <20230105204839.3676-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit There are two paths in the trampoline, and Xen's PAT needs setting up in both, not just the boot path. Fixes: 4304ff420e51 ("x86/S3: Drop {save,restore}_rest_processor_state() completely") Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu CC: Marek Marczykowski-Górecki CC: Demi Marie Obenour Entirely untested, but this a fairly embarassing mistake in hindsight. --- xen/arch/x86/boot/wakeup.S | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/xen/arch/x86/boot/wakeup.S b/xen/arch/x86/boot/wakeup.S index c17d613b61ff..08447e193496 100644 --- a/xen/arch/x86/boot/wakeup.S +++ b/xen/arch/x86/boot/wakeup.S @@ -130,6 +130,11 @@ wakeup_32: and %edi, %edx wrmsr 1: + /* Set up PAT before enabling paging. */ + mov $XEN_MSR_PAT & 0xffffffff, %eax + mov $XEN_MSR_PAT >> 32, %edx + mov $MSR_IA32_CR_PAT, %ecx + wrmsr /* Set up EFER (Extended Feature Enable Register). */ movl $MSR_EFER,%ecx -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Thu Jan 05 21:20:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 21:20:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472186.732322 (Exim 4.92) (envelope-from ) id 1pDXf4-0003FH-HE; Thu, 05 Jan 2023 21:20:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472186.732322; Thu, 05 Jan 2023 21:20:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDXf4-0003FA-E2; Thu, 05 Jan 2023 21:20:30 +0000 Received: by outflank-mailman (input) for mailman id 472186; Thu, 05 Jan 2023 21:20:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDXf2-0003F4-Ju for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 21:20:29 +0000 Received: from sonic314-20.consmr.mail.gq1.yahoo.com (sonic314-20.consmr.mail.gq1.yahoo.com [98.137.69.83]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c4b19715-8d3e-11ed-91b6-6bf2151ebd3b; Thu, 05 Jan 2023 22:20:26 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.gq1.yahoo.com with HTTP; Thu, 5 Jan 2023 21:20:23 +0000 Received: by hermes--production-bf1-5458f64d4-qthpt (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 3ae8c14202cbd65911d34094373944e4; Thu, 05 Jan 2023 21:20:18 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c4b19715-8d3e-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1672953623; bh=NA4PsefjDtPgPqtlyXz47iDncBWU1Smv50WH37X63KI=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From:Subject:Reply-To; b=FuoCFGtdpukvOkCciwKmcGKLHqacIweVRaRLWLwU/ULIdq6Pu+0E756V/cQbyzXvDRrdGIuyODdILXwdzsCiEj7i/mkKI74ewXvfN+xB88ZmcVAQHB/ZergsVg/MKma2vQyJCqI2/nNXF+dgLvnI88NNSEAGo4qpMryfwQCscbo/gXBgqwH3UiodD/6mVgWf0OdGvlwgF+1YIABOI2BF/cdzW2u27O6DQCN/ymMmYWlE3fSk+Aqfs0adwbQXgS4NzhmmUwBqm09rkytMwxVfhKXS0oexRIWqtdK+qdTXqRJggPetYKSkeHXzQXlWYunZ9I7LjA53inTRpKcODhtSGQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1672953623; bh=hof15gZ0OQwZiOINK1+nvXS3/ZOloYg/esR0maWeSKU=; h=X-Sonic-MF:Date:Subject:From:To:From:Subject; b=NstvfaDt1BeTqp4xp7OWIGZd03giDoK6wtR8WP1ENFFZGBuFOR+/C7nsC2IOXj5yH5HDwsRUcuNKQx/OsBW3uD45p9sIkzaSe23Dw5Cv1QZoc841snF82OlWkYWYAda8dROYKizVIAEgG0zprVAUWV9n78WUMkEQDP3PEDF7n740rtGmSIT20KGLUnWdUZ/3gjFnyay2bXu4tBD5Lp++dDFkjIeC8FLFpXcBSeRxThGj9/cEAnC8PSMqcPB60QQbj2oq6JF9fiTkF++FZ/9hLa/pX1Q5rUMhBW7clZD4W6/C4vy51Fc7qqcGGAxqdc5LqnGBVx3qlpiinB86Fa2bzA== X-YMail-OSG: FEjuAi8VM1kbyC.qcEennX6bxIhKcpE1uGVa7upuD2iMQq.681tscMkpRL0LDLI gX4vGip4JEhHlBSmKio3sJbpVzFjaexMKTV8rGBLcIurOYUDz_tOtLJDGtNiPX9zOKxVK7RZI6pZ 0NOgdIwDy08e63NMuekOGtUnPNLKk3EhD47wr8a86utP351NDAJRzbMJaJfSFPiGNbHFplBvUUIi kXUXqHmolCPDdZJRfZHkoCUduPb1J6pfK5J1.vpj8rUq7d_gKB5nOOCNAeuQPBAJpdHh1gaL5664 drpIYh4aHYU67Uf_gHbludebiZh8y7RTQ.fBlyC4O9Hzw1xY9T6eEJXUhDyxsZRdifUZ8pILdDQN ozFDELeC2.Fa_8DBrnaPIsLSosfIQtBkR8hwW7nncEO78MBV0Gma_nB.gkuUnkCcAjty8.W20ECV weTThqRdjxwTL.IJraHgeTOJPhBYayJr8rwnEk7PyihGSXZV8Ebi6dq1_NoOTkSNLZSt7up6eJlH N4JHCt7mwyG6y.L265B6oP5rCFsXtgyM4cAd5slq0MRehUCMrvhGTBoY9GPMKhnIU7t7FxdZtfPD vR18H12P5g9mviyL00rB80NJKNJTKzehp57PONLks44qNHGWGvhm6RzlGqtlej5tsDbYume9McrT mEQ51kWFzgUiJDtoJQsXkkP2..pxLBSiSYeTy4XPH51u7EY1eWGV9v8YAPWUj.3eAOH1PenCplbb vbnN6mTleiIh6z864mZvuBL5Wy8kFlVoGKI_.N04veAk00hb.OmXkxD2OVPMOjUof4eRFWqdhpjO CD3KcYkT91qQuyyNTLh1xb9DKioYXT11aGblNt0iC0ou2Y8YEfn_LB9jO.6HZx05Pqmd86gK0LPv wvqQIierPXIrLJL3HkvWOkMDsyOXMzJfy9GRT0vNtMt76pbiH5Z8pewhHHe51_RRqPQzabvWtlwE o_gtuISXU84iTlPe5TetE2LBSkIFXF5GwLwgS1CiPwCC.tPwyGtscoXx.uhJryI7TV3t3uHRUdP8 IloBRlB2BJMB8q51vwguAatevaYVkv0.kV7WWMmYkBX0SP.haCnpTDRdmatwKNPXAcgkJHOyB3YY ksLszkQZUdNRBMGXZnBfTzRpc4UBRF9gwUgSOOMnaH12mejf3OMihcRXnqppp_mN2fmdCNnglwBX 8H9bcc3zNuf8Xs3a_Eqn_LNx16cOAHpAVe58xHDApAXJQ8L5jXbVetTz0QL.UW59rucFuDoU3bTU 6v2x_g2sMlpKVICoG7ryGc5IWIK4eto2G1fOfOQtSYAzs_sfd_0TkjsxDj2F3t8Lt.rlGD08fpzH Rm7Ffb5lIigpYE.kvUqiz_yxw0k2Lue7kHwtS27ErbB37SEikCXPVXGTTG_jUUBnhj_eb8ctntSK tRPLMwj6h_lIGqkhFOaufyDyrOyfAnxF9Wp8REcM0mQblLQP6cJ3b6_DM07M8av86soDDFRUEVIR dWfuXrOG4rshUhy4yvqA3PxG4H.q7PCfiBzHaTw_Log_xHIQkXLItF8obbP06riHC1J0jOE9CFfP AOdyHUwGhD2Tyn8jb4PGqW91B79_TmDmYY7PwvSk9dvDgstk59t.LLO1e2f3h4KDKaAPgwCs4vQm ZtlJ40Lg.l_f3zqSSk1TZ4nYxdYDKZFW3uUc4zGGuFY.uWVHVCBd_i5RyiCnVmP0l6F_13oY6wrZ j2I7RpukTZnGjAAGKFuxxwxki6kcMBELMHH8SRcLT58frDV3h_mmYI70n0m8aoN9UKhM0hg1ViFJ FYqGMyqNlAw_RGyTZ_107qvnEI3H7CG6ODHIFB6.qipYHnfzfQ1igMTMXCtOIftAwbviB3129s2c DyegtBOvyKX.MCtNY6q1DJufDK2V3jht3rxpSM8Iw_mGSJ8qR.dJkij7hVZoJgnln3gBAXl8IjIk pcHNk.wFn756fVNv0wgt.okLD_kKtMhZgaN1jS9b35IL.zgcfuJHKLMADYpllmpypKmTyGbIOTzp NAqg.iJv4XCFFpJFhVYyLYXUuSM6EGRhrsx2Yzov89.Y29Bhiy4m3f6QH7suQJhA2cvsPNF4XkL. o4yTt92SaWWh9LWovuTP4yjiYqUpkoab46lvyfQhPJEYf1Qm1R_LJaGJuBw9.pvdchb89CKiHuSp 62RgzEXWCA219_yLIBPkHGiZ8X87WNcfYFhJcdnuEjbYCWJPZvn9tRYlv_EyrUhLMUOhtJUZPUVo 6aUT0yYjOnvQWhKnM X-Sonic-MF: Message-ID: <32193041-ff39-fdc5-01b5-b6e390ed997e@aol.com> Date: Thu, 5 Jan 2023 16:20:15 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v6] xen/pt: reserve PCI slot 2 for Intel igd-passthru From: Chuck Zmudzinski To: Alex Williamson , Paul Durrant , "Michael S. Tsirkin" , Anthony Perard Cc: qemu-devel@nongnu.org, Stefano Stabellini , Paolo Bonzini , Richard Henderson , Eduardo Habkost , Marcel Apfelbaum , xen-devel@lists.xenproject.org References: <830263507e8f1a24a94f81909d5102c4b204e938.1672615492.git.brchuckz.ref@aol.com> <830263507e8f1a24a94f81909d5102c4b204e938.1672615492.git.brchuckz@aol.com> <20230102124605-mutt-send-email-mst@kernel.org> <20230103081456.1d676b8e.alex.williamson@redhat.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.20982 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 4521 On 1/4/23 3:47 PM, Chuck Zmudzinski wrote: > On 1/3/23 10:14 AM, Alex Williamson wrote: > >> >> It's necessary to configure the assigned IGD at slot 2 to make it >> functional, yes, but I don't really understand this notion of >> "reserving" slot 2. If something occupies address 00:02.0 in the >> config, it's the user's or management tool's responsibility to move it >> to make this configuration functional. Why does QEMU need to play a >> part in reserving this bus address. IGD devices are not generally >> hot-pluggable either, so it doesn't seem we need to reserve an address >> in case an IGD device is added dynamically later. > > The capability to reserve a bus address for a quirky device need not > be limited to the case of hotplugged or dynamically added devices. The > igd is a quirky device, and its presence in an emulated system like > qemu requires special handling. The slot_reserved_mask member of PCIBus > is also well-suited to the case of quirky device like Intel the igd that > needs to be at slot 2. Just because it is not dynamically added later > does not change the fact that it needs special handling at its initial > configuration when the guest is being created. > >> > > Here's the problem that answers Michael's question why this patch is > specific to xen: > > ---snip--- > #ifdef CONFIG_XEN > > ... > > static void pc_xen_hvm_init(MachineState *machine) > { > PCMachineState *pcms = PC_MACHINE(machine); > > if (!xen_enabled()) { > error_report("xenfv machine requires the xen accelerator"); > exit(1); > } > > pc_xen_hvm_init_pci(machine); > pci_create_simple(pcms->bus, -1, "xen-platform"); > } > #endif > ---snip--- > > This code is from hw/i386/pc_piix.c. Note the call to > pci_create_simple to create the xen platform pci device, > which has -1 as the second argument. That -1 tells > pci_create_simple to autoconfigure the pci bdf address. > > It is *hard-coded* that way. That means no toolstack or > management tool can change it. And what is hard-coded here > is that the xen platform device will occupy slot 2, preventing > the Intel igd or any other device from occupying slot 2. > Actually, today I discovered it is possible to workaround this issue with libxl that appears to hard-code the xen platform device to slot 2. The code referenced here that effectively hard codes the xen platform device to slot 2 is only executed with the '-machine xenfv' qemu option, which is the default that libxl uses for hvm guests, but this behavior can be changed by setting xen_platform_pci = '0' in the xl guest configuration file, in which case libxl configures qemu with the '-machine pc,accel=xen' option instead, and then one can add the xen platform device at a different slot by adding, for example, device_model_args = ['-device','xen-platform,addr=03'] to the xl guest configuration file which adds the device at slot 3 instead of slot 2. This approach is an ugly workaround which has other side effects, such as by having -machine as pc,accel=xen instead of xenfv, the machine type is not exactly the same because the xenfv machine type is based on a much older version of qemu's i440fx emulation (qemu version 3.1 IIRC), so with this workaround there could be some unintended side effects, although I just tested this workaround and it does seem to work, but I have not been using this approach to the problem for very long. Also, this approach requires setting type=vif in the vif network setting of the xl guest configuration to suppress the creation of the qemu emulated network device that would grab slot 2 if it is created by the ordinary libxl network configuration settings and, for guests that do not have the xen pv network drivers installed, this also would require manually building the qemu command line using device_model_args to allow adding an emulated qemu network device at a different slot and probably also manually configuring the correct networking scripts outside of the normal xen networking scripts, because the ordinary xl guest configuration options do not have a setting for assigning an emulated qemu network device to a specific slot, and the device would otherwise grab slot 2. So,it is possible to configure the guest to have the Intel igd at slot 2 without patching either libxl or qemu, but it is a real PITA with some possible unintended side effects, and that is why I think patching qemu to reserve slot 2 is a much better solution to the problem. Kind regards, Chuck From xen-devel-bounces@lists.xenproject.org Thu Jan 05 22:17:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 22:17:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472196.732333 (Exim 4.92) (envelope-from ) id 1pDYYA-0000Fe-QL; Thu, 05 Jan 2023 22:17:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472196.732333; Thu, 05 Jan 2023 22:17:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDYYA-0000FX-N0; Thu, 05 Jan 2023 22:17:26 +0000 Received: by outflank-mailman (input) for mailman id 472196; Thu, 05 Jan 2023 22:17:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDYY8-0000FR-Mt for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 22:17:24 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b862fe73-8d46-11ed-b8d0-410ff93cb8f0; Thu, 05 Jan 2023 23:17:21 +0100 (CET) Received: from mail-dm6nam12lp2175.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.175]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 05 Jan 2023 17:17:08 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by PH0PR03MB5752.namprd03.prod.outlook.com (2603:10b6:510:36::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 22:17:04 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 22:17:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b862fe73-8d46-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1672957041; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=NTeMV9JIzE4pzgd6mrGvLnoq1bkSnPsinoSCXObJHH4=; b=Ca95tP+hZ1Q+i8LH/91xnRhx2DlhD6hmby3gkj21Qifx881+d9r1nECD 0F5HrkF/45QiWVBziPpJlj080pY+pFM8yYxDYG8onn88aMiKwzc3SlMar PR/EZt1QGMqn0WkJxYCiLM4TC4uXqD5PMJlJYij2s8NWauBDfY74uzfYB o=; X-IronPort-RemoteIP: 104.47.59.175 X-IronPort-MID: 93863639 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:IeHSUKCcboJAFhVW/+Piw5YqxClBgxIJ4kV8jS/XYbTApD8h0TZSn TcWXDyOP/yPZTPyc90iaYWzo0lQup7cxoVrQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nNHuCnYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtcpvlDs15K6p4GpA4wRlDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw5PhaJGAf9 fEhLB8DTkumhN2Ny7SEY7w57igjBJGD0II3nFhFlGucIdN4BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI9OxuvDW7IA9ZidABNPL8fNCQSNoTtUGfv m/cpEzyAw0ANczZwj2Amp6prr6UzX2gBtlDfFG+3sBw3XGxgVUXM0ctV3CSjqC+t0y5Wc0Kf iT4/QJr98De7neDTNPwQhm5q36spQMHVpxbFOhSwBqW1qPe7gKdB24FZj1MctorsIkxXzNC/ kCNt8PkA3poqrL9YXCA8raZqxuiNC5TKnUNDQcUQA1A79T9rYUbihPUUs0lAKOzlsfyGzz73 3aNtidWulkIpcsC1qH+8VWZhTup/8LNVlRsuViRWX+55ARkYoLjf5av9VXQ8fdHKsCeU0WFu 38H3cOZ6YjiEK2wqcBEe81VdJnB2hpPGGS0bYJHd3X5ywmQxg== IronPort-HdrOrdr: A9a23:rfbaWKDTQWlvbLrlHem955DYdb4zR+YMi2TDtnoddfUxSKfzqy nApoV56faKskdyZJhNo7690cq7LU80l6QU3WB5B97LYOCMggSVxe9ZjLcKygeQfhHDyg== X-IronPort-AV: E=Sophos;i="5.96,303,1665460800"; d="scan'208";a="93863639" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DJxcXuXAL+5EWBMm9DGct1BB0rRtt59ZxIL47YJr0+93YhPepuXo27T1kmtVMCLo2xo8iFHbEoTr7+EEUl3p1xNU/lPTNWBtrGXf5CxAahUkQ3l1FcIV+NlUn8KccXf0rArmgyO/m5BsmDvSxduRPUjDzXIb9VA6MuEqMzeqLezgKMJjLzx3hytnqRML1l4geBmTv02pt3m5IVIz4OdDgqFfNtgWOwXLq4q84niixFq1vzCWT2SOPIt04FOMSIc3uVZFjdek07PZOOu9qjC2vWCN65eS3TYdR4N7vaHQ77nAcAFtWeCaJBy+rHECIintEJenRANP8rf/EA8MsakE/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NTeMV9JIzE4pzgd6mrGvLnoq1bkSnPsinoSCXObJHH4=; b=aM3oSUd62btlE5tQn/eXgjBvNUWwIvXEAZbMrZz0PG1RKcrcJroBo/oWqLbqEOmhbRRv0iNLmQzN/QvcPS8SRxwgOsCJCeGqwcsnK664lODR9EHj+y/ucBkBbkfwEHSQJ5NtLlf2EW37kgJwiXUNOvdQxrhSGLhCa0T3d5jqNTJ7OfFwX6azXGEnVdBJ/Fuq5/DxhtxYcIQXy+5uJBTHWchIKAteGYusDzoZcqGm761Cb09y7KjoEyuGlfcuthYZvnB+lZ3E1NuWVyM02KN1KeFbwCTJiaddYCjPcTgGk+SngEuavONwKKWWUcNeLxKJ4C/fHIpWF3zLw8t4fQv76w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NTeMV9JIzE4pzgd6mrGvLnoq1bkSnPsinoSCXObJHH4=; b=Yx1wl7/nVciWG5LXojAyx4rdZuL1wX00qhcWhfEvd6Itl06W4zmt3fiuU/aCU2OwJqh4ExphHeHZqwqumfyWs15GRjNHGsJBsDENlcV52UnFzI3VrNNkarcs4q7jBz4fL+1KFcnL106HWFw9kiUiL/tK6JLlSTBFITFAVwdh8Nc= From: Andrew Cooper To: Jan Beulich CC: George Dunlap , Stefano Stabellini , Wei Liu , Julien Grall , Xen-devel Subject: Re: [PATCH 3/4] xen/version: Drop bogus return values for XENVER_platform_parameters Thread-Topic: [PATCH 3/4] xen/version: Drop bogus return values for XENVER_platform_parameters Thread-Index: AQHZH69XYhd2rMGoWE+asSBKOPPG4q6OdxyAgAA2ioCAAMm+gIAA8B2A Date: Thu, 5 Jan 2023 22:17:03 +0000 Message-ID: <9ce20298-5870-aa1b-ee5e-e16a623beadb@citrix.com> References: <20230103200943.5801-1-andrew.cooper3@citrix.com> <20230103200943.5801-4-andrew.cooper3@citrix.com> <540a449d-f76d-eb16-4f98-c4fb3564ce98@suse.com> <7dd00ce3-a95b-2477-128c-de36e75c4a34@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|PH0PR03MB5752:EE_ x-ms-office365-filtering-correlation-id: fce01bf6-94b9-4f4f-bdc3-08daef6a9323 x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: iJ9q6jHhc/4H0YcLEhzGM8yn+F6m90YXCXAu+siwAaEvmEsYlKP+F9wtifjC4V5qGlrDsTIhIrWgWiEQauIcxFIUE4KHcg8O0XX8AaMJc9ANaGLOPt+0rc673iw5l5jcVdMBri9KXv7zrMzK9uRG6Ngv4ErmmS3mpMPJDHPV5dhKoVuMeJg+L2dgJLFkQFmiYeqcuXBXOP7GkNqZ4H9fiaCmh2muzW+vKPcgLk3cKU5BPiOYpBeiV9o87KRjiN0rpad6Hohj6nNFiYac56cO1NeWrnNRsUUlJoO1k35OG01RdUELBdFWpvWDBLsEvBIOyxXFbOTkyHiYpI5X2ZqFAEMGT+82chMq5DUvHyWNQB3bIrRt3ka16LpPt2cQh4qDt31caZ4mHEKz4qZXxniyyK3IR5jXdc2fw1WMlksmnDjuBUHknTUL7Hjea0hI9rfhc97m9T9yatVuJguxwLawUGgCvPG+FNZD3nVEBbHO4iskMYEBsBmi477OCpAwP/i7f0FmBiXWVuRiCJQHRcDK8nxJ+vxda0rYbBTQ5fRkgT1RbhMJW+t859w0F24B8LR9cQcX/FHueuW0fyAgRP+njg71Uq4O9P4oYuljISf+jtSZxQhqpv+yAVRUvRdbW7O8jeovBNmanBkTbviH3u7gD4BNxPMBwYVJ7I/61OKmw9GYyRa0xvhje3MfVfK6fRpvi9rapDMyCQMO69mGG21nwfXJh3nxflpRYQjHJFPTgANbR46q1yyvUTlqCcPmfz0ywxjyWgRxOjVgVSYJuwXvZA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(366004)(346002)(136003)(39860400002)(451199015)(31686004)(5660300002)(41300700001)(71200400001)(6512007)(2906002)(26005)(186003)(8936002)(6506007)(66446008)(66476007)(91956017)(66946007)(8676002)(4326008)(66556008)(64756008)(76116006)(82960400001)(6916009)(38100700002)(2616005)(316002)(54906003)(6486002)(38070700005)(31696002)(53546011)(86362001)(122000001)(36756003)(478600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?cTBhT0N5dXFEYUd1QUdhbmVHRUg2U1ZuZElKdDJYWDJ2MmhQNFZyRXF0TDZW?= =?utf-8?B?VkFDVFRTNER5U1RXS3JvSkJYeFp2aHFZQzRCVVRMMENhVHE2UEV3cWdNakFK?= =?utf-8?B?ZS9QMUM0YlFVM0pkZEtPVU5oYWlNbStxMTV2V2ZNajY1eTZIRWFWSGZ0R2pQ?= =?utf-8?B?ZnFEN29pVlJzVkQ0d1ErdDhPRCswTjYzZjEvL2s4dkNSWFNMdWFIRS91ajZH?= =?utf-8?B?aFliaDdwMzd1Q2xWaEZFYnFEaHoydVZFZWFaa3FJUm4zemhnd0NsSzR2YVZj?= =?utf-8?B?OUFBbzJmc0ZSZU8xVU5od2ZONm5ZNG94c0RNQm5mOVBXRWlDMVg5czZEbnNo?= =?utf-8?B?WnVOTUVkQlcrS3pRSkdsLzZCK0dncHh5d1F4akRhdG1aOFFxZTFoV28xTElR?= =?utf-8?B?OUlkZkFkZ05CT1pJOC9WNEdtdXZEZmVSOFNmMjdzTWM0QkR6MDBaWHJHb2Nl?= =?utf-8?B?MkxhbzNhaVprUWRNNDM4VG1HZUlEU3BkU1RjMnIzZ0lYSkNHcnZvMHVJbUQ0?= =?utf-8?B?MkFsZ0Q1RW85UmxTdW8xWFNHMTE4dDJpZHg1SGVVeVluK1UvTnlsZ0kyQkdK?= =?utf-8?B?T1dSSlRVOE5VODU4Y2RUR0h4NW1UOHZyL1ZSWENzME53UGkrUFpSZWJJVHEy?= =?utf-8?B?MWkrdXM3a014SFowRU1KU2tCNVFiekNjNHlwMExUb1hlYlhJaUVGa09ZazUr?= =?utf-8?B?OUVDZnI2QjV5czVQZ1kwMnlXQzFFYk5UNUhEcE5jKy9lc1E1Vk1Kd1RINnpy?= =?utf-8?B?V1RYY0tpREZkSnNNallGUlIvZU51V21PZnBIbldSNFlBYU01SGdiK2l6Uno0?= =?utf-8?B?d1JDTkxVZEZUUExEakJ3MmhjOHVZaXUrOGlJakVCWXQ4TzZUa3hlMmRjclJI?= =?utf-8?B?MHIySTNoKzBKSEN5SVJzNnF1ZjVJc2pZcUtXK0o1YVZsNWJrQld0UUJkcFow?= =?utf-8?B?eG11cFQ0cXNYZjVpMEtlRTUrYXVNaUZyMkszVDNqNUlab1pCTTZGRWRZMGZ1?= =?utf-8?B?dWZUVktjTisrZzFlckhaRmdQNTlLN3VYMkFYRlkxaHR6L0hLdlh1S2VUZ3dx?= =?utf-8?B?ZmJjMGZYcG9BZmhSOGpmZmhFSHVXUm5WcW1wcHhMRC9Mbi80VmZRUk9ybCtK?= =?utf-8?B?VytXZ3U1Z3hPNnVXMzBCRlJhZjFKeEN3d0hDT28reFNUbStLUnJGbmlYb0V6?= =?utf-8?B?a0lWK25MSUx4a29JNjZYUkpLUnM4QktWMHFWcG9RRGdEd1kvMUJ3ZHNNRzdO?= =?utf-8?B?YWJkdnRmRWNqY01yNENFR2IrTDZ1YXN6bmU5Y0phM2p5UkcxUmEySVpsUFoz?= =?utf-8?B?SExKY1R2N2RrUE91NFZ6U096WE9kQmNSQitTdHJYWDYvN3hXZm1VNHBtLzZV?= =?utf-8?B?VERvaEwrOXU5MzNVdVN0SFprQzU3OCsvNkh1c00xMUdBT3pMemxsaWNBWUZ0?= =?utf-8?B?TzE5dTVaVGk4anZXRGViQnR2d0hBMURzcXgrMm96aHMvc1Y2ZUxwSzk1Y2xo?= =?utf-8?B?K01TWnVKZnJuMlRRSHQwTDJGK1pEVlVVSjk2RnBMY2NmZnVaUGFNU1RPbmdk?= =?utf-8?B?WVZxY3J6WU90UG1LbEJneDk5ME1QYUJ2d0lkazBzUUI5VHVKNUp4d2ZTNVFY?= =?utf-8?B?clNZazNaZ1Bhd2tXWU5tZzVPZmVCbUk3L1NBSURzV3BHNTZEY1JGM2hzRjdI?= =?utf-8?B?WDIvMXZvTHJtRGhWTm00R0lETWNkc1l1RUVpdDBEN1hRaXp4em00ODZHaFEx?= =?utf-8?B?V2hOMVJpUGtWOHlnUFBFYURSUjAxcjNJL3V2SGFBaHlWczQ3eEwxZW43Q0tO?= =?utf-8?B?cXR2RGZSK2dlNWIvSlJGYlpyNVlGS1Y5S0hxUDkxVzhkNTFnUzBjZmhRYlJL?= =?utf-8?B?WWRYd1hzTytuL0dRVk05TVhxNGMxQ0hvWWN3VFh6Nk9mVnhxbHZCNm9WUDBZ?= =?utf-8?B?cTdJQVVWNm5WbkZDMVZEeG1WOTJicHJZZjZNclJZR2xxYjZmL2t0ZkthNWhZ?= =?utf-8?B?b2UyVWZQM0RIZ2Q5NWJncWdVa1ZROXFLRjhtZmpmekJFUE54a3YxQlFXOVFV?= =?utf-8?B?ZUs1blJ6NE1SUWhqeDB1VjZNK0lGalpHRVFkUFlIZ3UxQkV6RmFRck0yb09N?= =?utf-8?B?cDlyWk16bFRWd3M3dmppODhsMDQ3c0wwdHhIWUUzRCtaS1pva1VEQXFtMmJ5?= =?utf-8?B?RUE9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <2F4E482822F8FD4690A3C6E2B4755AFB@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Gx7jn0rvzQh1NLCadvcaTQxONMUaRsvfVlzCKl5aWONjH57IXEaCwolllBDNelCj1LI5Ul1eLusEVLiX2nNrKe+Kd74kwqvb+qUrGsiJbxDasOeE2tXcGo+kgzMbZND73rIVbmO/Fxz0gaP+SFFJaoqQqKoashLmdwWzI9nXdN5+kPa8zrM3YxS6LhjWyuPfcLPbfL8ghmyXfrBZWvAvOC/vLuETzLCgtmsy0pijeeXaS5bhdx/bHmoVsi8utasXb8C1VF1op7NgmenX7U4WttY59tloVbiRD10eC4y+e/PtZwBE0JdUZ2O3GO+UoVg+hx7ls29WNINaSnbe98aAQoDlMpaVABxeSLBfMoMEoRsqRsUkxPg8ebWZvCVsI34yBT51kJhSph6oG4WOjgcvPGCcFDVq00JE/vsiLkrhb2d1RmG9im5ai2eXdl72Q+Px/Vy56uw09PVu/FufkswnZtLAFXLzXBXFa5JPyEf8sxOxDlxDVlq9Yw5YU7GB5hrCVGdr0CyNI9117DH9dKVh0NRgznzhuwvlCjKHMkvNtqUx6jlEosLC7C27ed0W9g8arEkMwbUynIFiQn26URcQr19m8/vNBIiziSV4nP8juZmPsQdTCVaqaU9D/ajSeOOk+vzzl8U09KglpDPe/XjQ0KmSWjksVhxY9T3NeBZN2kkpPhXwjKRUICSilBgQX+3EIxWotWbqHbCYkp+HTnzpZW4usdTME8awBE8+j9rYB1jLKgecFNUYb/sko0ww/mhWqleDJyQBmt9lpgIecGinls6j/3+9FgG2ns5Lbvq7skqYMtyWX5yLCuDd6Xx11vY7PldQz+qtNw9cafjtAJtDSF79XSK6miEGD46hXUaPTE5PfIiqYAUhbC9+ob7AL3+T X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fce01bf6-94b9-4f4f-bdc3-08daef6a9323 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jan 2023 22:17:04.0355 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7tilhqD3apfYkbjA+tIWuuNyR0E0lMWW+ytej3O7ua9QtNhnm+YAU2EOPBnsedYPWQ2h7KEwBLUwoysYkHKjDAJqLW0bK1pMZQwaaXvbl4Y= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5752 T24gMDUvMDEvMjAyMyA3OjU3IGFtLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMDQuMDEuMjAy MyAyMDo1NSwgQW5kcmV3IENvb3BlciB3cm90ZToNCj4+IE9uIDA0LzAxLzIwMjMgNDo0MCBwbSwg SmFuIEJldWxpY2ggd3JvdGU6DQo+Pj4gT24gMDMuMDEuMjAyMyAyMTowOSwgQW5kcmV3IENvb3Bl ciB3cm90ZToNCj4+Pj4gQSBzcGxpdCBpbiB2aXJ0dWFsIGFkZHJlc3Mgc3BhY2UgaXMgb25seSBh cHBsaWNhYmxlIGZvciB4ODYgUFYgZ3Vlc3RzLg0KPj4+PiBGdXJ0aGVybW9yZSwgdGhlIGluZm9y bWF0aW9uIHJldHVybmVkIGZvciB4ODYgNjRiaXQgUFYgZ3Vlc3RzIGlzIHdyb25nLg0KPj4+Pg0K Pj4+PiBFeHBsYWluIHRoZSBwcm9ibGVtIGluIHZlcnNpb24uaCwgc3RhdGluZyB0aGUgb3RoZXIg aW5mb3JtYXRpb24gdGhhdCBQViBndWVzdHMNCj4+Pj4gbmVlZCB0byBrbm93Lg0KPj4+Pg0KPj4+ PiBGb3IgNjRiaXQgUFYgZ3Vlc3RzLCBhbmQgYWxsIG5vbi14ODYtUFYgZ3Vlc3RzLCByZXR1cm4g MCwgd2hpY2ggaXMgc3RyaWN0bHkNCj4+Pj4gbGVzcyB3cm9uZyB0aGFuIHRoZSB2YWx1ZXMgY3Vy cmVudGx5IHJldHVybmVkLg0KPj4+IEkgZGlzYWdyZWUgZm9yIHRoZSA2NC1iaXQgcGFydCBvZiB0 aGlzLiBTZWVpbmcgTGludXgnZXMgZXhwb3N1cmUgb2YgdGhlDQo+Pj4gdmFsdWUgaW4gc3lzZnMg SSBldmVuIHdvbmRlciB3aGV0aGVyIHdlIGNhbiBjaGFuZ2UgdGhpcyBsaWtlIHlvdSBkbyBmb3IN Cj4+PiBIVk0uIFdobyBrbm93cyB3aGF0IGlzIGJlaW5nIGluZmVycmVkIGZyb20gdGhlIHZhbHVl LCBhbmQgYnkgd2hvbS4NCj4+IExpbnV4J3Mgc3lzZnMgQUJJIGlzbid0IHJlbGV2YW50IHRvIHVz IGhlcmUuwqAgVGhlIHN5c2ZzIEFCSSBzYXlzIGl0DQo+PiByZXBvcnRzIHdoYXQgdGhlIGh5cGVy dmlzb3IgcHJlc2VudHMsIG5vdCB0aGF0IGl0IHdpbGwgYmUgYSBub256ZXJvIG51bWJlci4NCj4g SXQgZWZmZWN0aXZlbHkgcmVwb3J0cyB0aGUgaHlwZXJ2aXNvciAodmlydHVhbCkgYmFzZSBhZGRy ZXNzIHRoZXJlLiBIb3cNCj4gY2FuIHdlIG5vdCBjYXJlIGlmIHNvbWV0aGluZyAoa2V4ZWMgd291 bGQgY29tZSB0byBtaW5kKSB3b3VsZCBiZSB1c2luZw0KPiBpdCBmb3Igd2hhdGV2ZXIgcHVycG9z ZS4NCg0KV2hhdCBhYm91dCBrZXhlYyBkbyB5b3UgdGhpbmsgd291bGQgY2FyZT8NCg0KVGhlIG9u bHkgdGhpbmcga2V4ZWMtdG9vbHMgY2FyZXMgYWJvdXQgaXMgWEVOVkVSX2NhcGFiaWxpdGllcywg YnV0IGV2ZW4NCnRoYXQncyBub3QgYWN0dWFsbHkgY29ycmVjdCBmb3IgZmlndXJpbmcgb3V0IHdo ZXRoZXIgWGVuIGNhbiBkbyBrZXhlYw0KdHJhbnNpdGlvbnMgdG8gRUxGNjQvMzIuDQoNCj4gQW5k IHRoaW5raW5nIG9mIGl0LCB0aGUgdG9vbCBzdGFjayBoYXMgdXNlcywNCj4gdG9vLiBBc3N1bWlu ZyB5b3UgYXVkaXRlZCB0aGVtLCBkaWQgeW91IGNvbnNpZGVyIHJlbW92aW5nIGRlYWQgdXNlcyBp bg0KPiBhIHByZXJlcSBwYXRjaCAoYW5kIGRpc2N1c3MgdGhlIGVmZmVjdHMgb24gbGl2ZSBvbmVz IGluIHRoZSBkZXNjcmlwdGlvbik/DQoNClRoZXJlIGlzIG9ubHkgb25lIHRvb2xzdGFjayB1c2Ug SSBjYW4gc3BvdCB3aGljaCBpcyBub24taW5mb3JtYXRpb25hbCwNCmFuZCBpdCdzIGJyb2tlbiBB RkFJQ1QuDQoNCmB4bCBkdW1wLWNvcmVgIHdyaXRlcyBvdXQgYSBoZWFkZXIgd2hpY2ggaW5jbHVk ZXMgdGhpcyBtZXRhZGF0YSwgYnV0IGl0DQp0YWtlcyBkb20wJ3MgdmFsdWUsIG5vdCBkb21VJ3Mu wqAgKE5vdCB0aGF0IHRoaXMgaXMgcmVsZXZhbnQgQUZBSUNULA0KYmVjYXVzZSB0aGUgTTJQIGlz IGhhbmRsZWQgc3BlY2lhbGx5IGFueXdheS4pDQoNCg0KTW9zdCBYRU5WRVJfKiBpbmZvcm1hdGlv biBpcyBnbG9iYWwgKGFuZCBieSB0aGlzLCBJIG1lYW4gaW52YXJpYW50IGFuZA0Kbm9uLWNhbGxl ciBkZXBlbmRlbnQsIG91dHNpZGUgb2YgbGl2ZXBhdGNoaW5nLikNCg0KWEVOVkVSX2d1ZXN0X2hh bmRsZSBpcyBjYWxsZXItdmFyaWFudCwgYnV0IHRoZSB0b29sc3RhY2sgaGFzIHByb3Blcg0KaW50 ZXJmYWNlcyB0byBnZXQvc2V0IHRoaXMgdmFsdWUuDQoNClhFTlZFUl9wbGF0Zm9ybV9wYXJhbWV0 ZXJzIChhbmQgWEVOVkVSX2dldF9mZWF0dXJlcyBmb3IgdGhhdCBtYXR0ZXIpIGFyZQ0KY2FsbGVy LXZhcmlhbnQsIGFuZCB0aGUgdG9vbHN0YWNrIGhhcyBubyB3YXkgdG8gZ2V0IGRvbVUncyB2aWV3 IG9mIHRoaXMNCmRhdGEuDQoNCg0KRXZlcnkgaW5zdGFuY2UgKHdlbGwgLSB0aGlzIGlzIHRoZSBv bmx5IGludGVyZXN0aW5nIG9uZSkgb2YgdGhlIHVzZSBvZg0KWEVOVkVSX3BsYXRmb3JtX3BhcmFt ZXRlcnMgSSBjYW4gZmluZCBpcyBicm9rZW4sIGV2ZW4gaW4gdGhlIFhlbiBjb2RlLg0KDQo+Pj4+ IC0tLSBhL3hlbi9pbmNsdWRlL3B1YmxpYy92ZXJzaW9uLmgNCj4+Pj4gKysrIGIveGVuL2luY2x1 ZGUvcHVibGljL3ZlcnNpb24uaA0KPj4+PiBAQCAtNDIsNiArNDIsMjYgQEAgdHlwZWRlZiBjaGFy IHhlbl9jYXBhYmlsaXRpZXNfaW5mb190WzEwMjRdOw0KPj4+PiAgdHlwZWRlZiBjaGFyIHhlbl9j aGFuZ2VzZXRfaW5mb190WzY0XTsNCj4+Pj4gICNkZWZpbmUgWEVOX0NIQU5HRVNFVF9JTkZPX0xF TiAoc2l6ZW9mKHhlbl9jaGFuZ2VzZXRfaW5mb190KSkNCj4+Pj4gIA0KPj4+PiArLyoNCj4+Pj4g KyAqIFRoaXMgQVBJIGlzIHByb2JsZW1hdGljLg0KPj4+PiArICoNCj4+Pj4gKyAqIEl0IGlzIG9u bHkgYXBwbGljYWJsZSB0byBndWVzdHMgd2hpY2ggc2hhcmUgcGFnZXRhYmxlcyB3aXRoIFhlbiAo eDg2IFBWDQo+Pj4+ICsgKiBndWVzdHMpLCBhbmQgaXMgc3VwcG9zZWQgdG8gaWRlbnRpZnkgdGhl IHZpcnR1YWwgYWRkcmVzcyBzcGxpdCBiZXR3ZWVuDQo+Pj4+ICsgKiBndWVzdCBrZXJuZWwgYW5k IFhlbi4NCj4+Pj4gKyAqDQo+Pj4+ICsgKiBGb3IgMzJiaXQgUFYgZ3Vlc3RzLCBpdCBtb3N0bHkg ZG9lcyB0aGlzLCBidXQgdGhlIGNhbGxlciBuZWVkcyB0byBrbm93IHRoYXQNCj4+Pj4gKyAqIFhl biBsaXZlcyBiZXR3ZWVuIHRoZSBzcGxpdCBhbmQgNEcuDQo+Pj4+ICsgKg0KPj4+PiArICogRm9y IDY0Yml0IFBWIGd1ZXN0cywgWGVuIGxpdmVzIGF0IHRoZSBib3R0b20gb2YgdGhlIHVwcGVyIGNh bm9uaWNhbCByYW5nZS4NCj4+Pj4gKyAqIFRoaXMgcHJldmlvdXNseSByZXR1cm5lZCB0aGUgc3Rh cnQgb2YgdGhlIHVwcGVyIGNhbm9uaWNhbCByYW5nZSAod2hpY2ggaXMNCj4+Pj4gKyAqIHRoZSB1 c2Vyc3BhY2UvWGVuIHNwbGl0KSwgbm90IHRoZSBYZW4va2VybmVsIHNwbGl0ICh3aGljaCBpcyA4 VEIgZnVydGhlcg0KPj4+PiArICogb24pLiAgVGhpcyBub3cgcmV0dXJucyAwIGJlY2F1c2UgdGhl IG9sZCBudW1iZXIgd2Fzbid0IGNvcnJlY3QsIGFuZA0KPj4+PiArICogY2hhbmdpbmcgaXQgdG8g YW55dGhpbmcgZWxzZSB3b3VsZCBiZSBldmVuIHdvcnNlLg0KPj4+IFdoZXRoZXIgdGhlIGd1ZXN0 IHJ1bnMgdXNlciBtb2RlIGNvZGUgaW4gdGhlIGxvdyBvciBoaWdoIGhhbGYgKG9yIGluIHlldA0K Pj4+IGFub3RoZXIgd2F5IG9mIHNwbGl0dGluZykgaXNuJ3QgcmVhbGx5IGRpY3RhdGVkIGJ5IHRo ZSBQViBBQkksIGlzIGl0Pw0KPj4gTm8sIGJ1dCBnaXZlbiBhIGNob2ljZSBvZiByZXBvcnRpbmcg dGhlIHRoaW5nIHdoaWNoIGlzIGFuIGFyY2hpdGVjdHVyYWwNCj4+IGJvdW5kYXJ5LCBvciB0aGUg b25lIHdoaWNoIGlzIHRoZSBhY3R1YWwgc3BsaXQgYmV0d2VlbiB0aGUgdHdvIGFkamFjZW50DQo+ PiByYW5nZXMsIHJlcG9ydGluZyB0aGUgYXJjaGl0ZWN0dXJhbCBib3VuZGFyeSBpcyBjbGVhcmx5 IHRoZSB1bmhlbHBmdWwgdGhpbmcuDQo+IEhtbS4gVG8gcHJvcGVybHkgcGFyYWxsZWwgdGhlIDMy LWJpdCB2YXJpYW50LCBhIFtzdGFydCxlbmRdIHJhbmdlIHdvdWxkIG5lZWQNCj4gZXhwb3Npbmcg Zm9yIDY0LWJpdCwgcmF0aGVyIHRoYW4gZXhwb3Npbmcgbm90aGluZy4NCg0KVGhlIDMyLWJpdCB2 ZXJzaW9uIGlzIGEgc3RhcnQvZW5kIHBhaXIsIGJ1dCB3aXRoIGVuZCBiZWluZyBpbXBsaWNpdCBh dA0KdGhlIDRHIGFyY2hpdGVjdHVyYWwgYm91bmRhcnkuDQoNCklmIHdlIHdlcmUgZG9pbmcgNjQt Yml0IGZyb20gc2NyYXRjaCwgdGhlbiByZXBvcnRpbmcgZW5kIHdvdWxkIGhhdmUgYmVlbg0Kc2Vu c2libGUsIGJlY2F1c2UgZm9yIDY0LWJpdCwgc3RhcnQgaXMgdGhlIGFyY2hpdGVjdHVyYWwgYm91 bmRhcnkgd2hpY2gNCmNhbiBiZSBpbXBsaWNpdC4NCg0KQnV0IHRoZXJlIGlzIG5vIHN1Y2ggdGhp bmcgYXMgYSA2NGJpdCBQViBndWVzdCB3aXRoIGFueSAodXNlZnVsKSBpZGVhIG9mDQphIHZhcmlh YmxlIHNwbGl0LCBiZWNhdXNlIHRoaXMgbnVtYmVyIGhhcyBiZWVuIGp1bmsgZm9yIHRoZSBlbnRp cmUNCmxpZmV0aW1lIG9mIDY0Yml0IFBWIGd1ZXN0cy7CoCBJbiBwYXJ0aWN1bGFyLCAuLi4NCg0K Pj4+PiArICogRm9yIGFsbCBndWVzdCB0eXBlcyB1c2luZyBoYXJkd2FyZSB2aXJ0IGV4dGVudGlv bnMsIFhlbiBpcyBub3QgbWFwcGVkIGludG8NCj4+Pj4gKyAqIHRoZSBndWVzdCBrZXJuZWwgdmly dHVhbCBhZGRyZXNzIHNwYWNlLiAgVGhpcyBub3cgcmV0dXJuIDAsIHdoZXJlIGl0DQo+Pj4+ICsg KiBwcmV2aW91c2x5IHJldHVybmVkIHVucmVsYXRlZCBkYXRhLg0KPj4+PiArICovDQo+Pj4+ICAj ZGVmaW5lIFhFTlZFUl9wbGF0Zm9ybV9wYXJhbWV0ZXJzIDUNCj4+Pj4gIHN0cnVjdCB4ZW5fcGxh dGZvcm1fcGFyYW1ldGVycyB7DQo+Pj4+ICAgICAgeGVuX3Vsb25nX3QgdmlydF9zdGFydDsNCj4+ PiAuLi4gdGhlIGZpZWxkIG5hbWUgdGVsbHMgbWUgdGhhdCBhbGwgdGhhdCBpcyBiZWluZyBjb252 ZXllZCBpcyB0aGUgdmlydHVhbA0KPj4+IGFkZHJlc3Mgb2Ygd2hlcmUgdGhlIGh5cGVydmlzb3Ig YXJlYSBzdGFydHMuDQo+PiBJTU8sIGl0IGRvZXNuJ3QgbWF0dGVyIHdoYXQgdGhlIG5hbWUgb2Yg dGhlIGZpZWxkIGlzLsKgIEl0IGRhdGVzIGZyb20gdGhlDQo+PiBkYXlzIHdoZW4gMzJiaXQgUFYg d2FzIHRoZSBvbmx5IHR5cGUgb2YgZ3Vlc3QuDQo+Pg0KPj4gMzJiaXQgUFYgZ3Vlc3RzIHJlYWxs eSBkbyBoYXZlIGEgdmFyaWFibGUgc3BsaXQsIHNvIHRoZSBndWVzdCBrZXJuZWwNCj4+IHJlYWxs eSBkb2VzIG5lZWQgdG8gZ2V0IHRoaXMgdmFsdWUgZnJvbSBYZW4uDQo+Pg0KPj4gVGhlIHNwbGl0 IGZvciA2NGJpdCBQViBndWVzdHMgaXMgY29tcGlsZS10aW1lIGNvbnN0YW50LCBoZW5jZSB3aHkg NjRiaXQNCj4+IFBWIGtlcm5lbHMgZG9uJ3QgY2FyZS4NCj4gLi4uIG9uY2Ugd2UgZ2V0IHRvIHJ1 biBYZW4gaW4gNS1sZXZlbCBtb2RlLCA0LWxldmVsIFBWIGd1ZXN0cyBjb3VsZCBhbHNvDQo+IGdh aW4gYSB2YXJpYWJsZSBzcGxpdDogTGlrZSBmb3IgMzItYml0IGd1ZXN0cyBub3csIG9ubHkgdGhl IHIvbyBNMlAgd291bGQNCj4gbmVlZCB0byBsaXZlIGluIHRoYXQgYXJlYSwgYW5kIHRoaXMgbWF5 IHdlbGwgb2NjdXB5IGxlc3MgdGhhbiB0aGUgZnVsbA0KPiByYW5nZSBwcmVzZW50bHkgcmVzZXJ2 ZWQgZm9yIHRoZSBoeXBlcnZpc29yLg0KDQouLi4geW91IGNhbid0IGRvIHRoaXMsIGJlY2F1c2Ug aXQgb25seSB3b3JrcyBmb3IgZ3Vlc3RzIHdoaWNoIGhhdmUNCmNob3NlbiB0byBmaW5kIHRoZSBN MlAgdXNpbmcgWEVOTUVNX21hY2hwaHlzX21hcHBpbmcgKGUuZy4gTGludXgpLCBhbmQNCmRvZXNu J3QgZm9yIGUuZy4gTWluaU9TIHdoaWNoIGRvZXM6DQoNCiNkZWZpbmUgbWFjaGluZV90b19waHlz X21hcHBpbmcgKCh1bnNpZ25lZCBsb25nICopSFlQRVJWSVNPUl9WSVJUX1NUQVJUKQ0KDQppbiBm YWN0LCBsb29raW5nIGF0IHRoaXMsIE1pbmlPUyBpcyBhbHNvIGJyb2tlbiBhcyBhIDMyYml0IFBW IGRvbTAsDQpiZWNhdXNlIGl0IGhhcmRjb2RlcyBfX01BQ0gyUEhZU19WSVJUX1NUQVJUIGluIHRo ZSBjYXNlIHdoZXJlIHRoZSBzcGxpdA0KcmVhbGx5IGlzIHZhcmlhYmxlLg0KDQoNCkl0cyBvbmx5 IFBWIGd1ZXN0cyB3aGljaCBhcmUgTEE1NyBhd2FyZSB3aGljaCBjYW4gcG9zc2libHkgYmVuZWZp dCBmcm9tDQphIHZhcmlhYmxlIHBvc2l0aW9uIE0yUCwgYW5kIG9ubHkgYmVjYXVzZSB0aGF0IHdp bGwgYmUgYSBuZXcgRUxGTk9URQ0KcHJvdG9jb2wuDQoNCj4NCj4+IEZvciBjb21wYXQgSFZNLCBp dCBoYXBwZW5zIHRvIHBpY2sgdXAgdGhlIC0xIGZyb206DQo+Pg0KPj4gI2lmZGVmIENPTkZJR19Q VjMyDQo+PiDCoMKgwqAgSFlQRVJWSVNPUl9DT01QQVRfVklSVF9TVEFSVChkKSA9DQo+PiDCoMKg wqDCoMKgwqDCoCBpc19wdl9kb21haW4oZCkgPyBfX0hZUEVSVklTT1JfQ09NUEFUX1ZJUlRfU1RB UlQgOiB+MHU7DQo+PiAjZW5kaWYNCj4+DQo+PiBpbiBhcmNoX2RvbWFpbl9jcmVhdGUoKSwgd2hl cmVhcyBmb3Igbm9uLWNvbXBhdCBIVk0sIGl0IGdldHMgYSBudW1iZXIgaW4NCj4+IGFuIGFkZHJl c3Mgc3BhY2UgaXQgaGFzIG5vIGNvbm5lY3Rpb24gdG8gaW4gdGhlIHNsaWdodGVzdC7CoCBBUk0g Z3Vlc3RzDQo+PiBlbmQgdXAgZ2V0dGluZyBYRU5fVklSVF9TVEFSVCAoPT0gMk0pIGhhbmRlZCBi YWNrLCBidXQgdGhpcyBhYnNvbHV0ZWx5DQo+PiBhbiBpbnRlcm5hbCBkZXRhaWwgdGhhdCBndWVz dHMgaGF2ZSBubyBidXNpbmVzcyBrbm93aW5nLg0KPiBXZWxsLCBva2F5LCB0aGlzIGxvb2tzIHRv IGJlIGdvb2QgZW5vdWdoIGFuIGFyZ3VtZW50IHRvIG1ha2UgdGhlIGFkanVzdG1lbnQNCj4geW91 IHByb3Bvc2UgZm9yICFQViBndWVzdHMuDQoNClJpZ2h0LCBIVk0gKG9uIGFsbCBhcmNoaXRlY3R1 cmVzKSBpcyB2ZXJ5IGN1dCBhbmQgZHJ5Lg0KDQpCdXQgaXQgZmVlbHMgd3JvbmcgdG8gbm90IGFk ZHJlc3MgdGhlIFBWNjQgaXNzdWUgYXQgdGhlIHNhbWUgdGltZQ0KYmVjYXVzZSBpdCBpcyBzaW1p bGFyIGxldmVsIG9mIGJyb2tlbiwgZGVzcGl0ZSB0aGVyZSBiZWluZyAoaW4gdGhlb3J5KSBhDQps ZWdpdGltYXRlIG5lZWQgZm9yIGEgUFYgZ3Vlc3Qga2VybmVsIHRvIGtub3cgaXQuDQoNCn5BbmRy ZXcNCg== From xen-devel-bounces@lists.xenproject.org Thu Jan 05 22:28:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 22:28:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472204.732344 (Exim 4.92) (envelope-from ) id 1pDYik-0001pO-Te; Thu, 05 Jan 2023 22:28:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472204.732344; Thu, 05 Jan 2023 22:28:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDYik-0001pH-Qw; Thu, 05 Jan 2023 22:28:22 +0000 Received: by outflank-mailman (input) for mailman id 472204; Thu, 05 Jan 2023 22:28:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDYii-0001p8-Qx for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 22:28:20 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3fce2a92-8d48-11ed-b8d0-410ff93cb8f0; Thu, 05 Jan 2023 23:28:18 +0100 (CET) Received: from mail-bn8nam12lp2172.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.172]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 05 Jan 2023 17:28:15 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BLAPR03MB5569.namprd03.prod.outlook.com (2603:10b6:208:287::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 22:28:11 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 22:28:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3fce2a92-8d48-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1672957698; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=i+0q0drz1PnYzIVvpMPaNg9lgG7Tam6XO5zaVwxxGiE=; b=L7Xh1nKT3WVRrlE4RciWyMn3y9PikKXeuxMcJsIEe/bsEanMmI+UmNvx mpaVUD2pvtZZa3ZmHy6NbfdC5HdOH2MeOdNpxWg6vD5/dPrGcuZHGIc+A cerGEOFkx8FUvMr/dRykJTOOZojQurXKqyBEcSVJBGc4vq+k5M0fMX7Cf 4=; X-IronPort-RemoteIP: 104.47.55.172 X-IronPort-MID: 91430264 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:wiET/qBXMbvdIhVW/+Piw5YqxClBgxIJ4kV8jS/XYbTApGsg1GRTx 2scWj/SOqvbNGfwetgjbYXjpksO6p/TxtZgQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nNHuCnYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtcpvlDs15K6p4GpA4wRlDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw2utICmhVx b8hAx8VbiyFqf+m3Je/Y7w57igjBJGD0II3nFhFlGucJ9B2BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI+OxuvDK7IA9ZidABNPL8fNCQSNoTtUGfv m/cpEzyAw0ANczZwj2Amp6prr6WwXijAtxOfFG+3r0xg3eamWYyMzg9VleJg9aQh3S0As0Kf iT4/QJr98De7neDTNPwQhm5q36spQMHVpxbFOhSwBqW1qPe7gKdB24FZj1MctorsIkxXzNC/ kCNt8PkA3poqrL9YXCA8raZqxuiNC5TKnUNDQcUQA1A79T9rYUbihPUUs0lAKOzlsfyGzz73 3aNtidWulkIpcsC1qH+91aXhTup/8LNVlRsuV+RWX+55ARkYoLjf5av9VXQ8fdHKsCeU0WFu 38H3cOZ6YjiEK2wqcBEe81VdJnB2hpPGGe0bYJHd3X5ywmQxg== IronPort-HdrOrdr: A9a23:5z2GP67If76j9ysXNwPXwPfXdLJyesId70hD6qm+c20tTiX4rb HXoB1/73XJYVkqKRQdcLy7Scu9qDbnhP1ICOoqXItKPjOW3FdARbsKheDfKn/bexEWndQtsp uIHZIObuEYzmIXsS852mSF+hobr+VvOZrHudvj X-IronPort-AV: E=Sophos;i="5.96,303,1665460800"; d="scan'208";a="91430264" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Zrb9IreDg66tjwfw1OkaJB+jjOghiDSYRM2vPTx61fiYRuQP88+ePftaMXsQBH7q6NptTGAzj7i313qvAx1uxZ7IIeZAgh7uHrx0FVqOA9jCNLkL8nOg0LS3PVAkRddDQ8KyX+Y+sGG2L5WvjZ8sQMW17X9QGer4Gd+jgdj4eNTW7oMyd0H/eV9s/F4ZNhySG2DkQyaXzxxelxU1sS9wVH1aECJQfDc/T1I9ArqCNbAquZSRL16tyWjE2F8Nby60UMSqHOK+g1JyjwU3x8EE3DrNH2JKENlNrqI1Snr5TTZ+tyW46+a22rX5V6EeN74SkicpGj6C4+nZ0/3i2zm+gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=i+0q0drz1PnYzIVvpMPaNg9lgG7Tam6XO5zaVwxxGiE=; b=PZ0g6YEEIh7hXrQbCWrB9z1NAEBfTf2KCL7tBdDvmHBbfFK4+LZ1c7UyhpztHJM41qsBeZ4wS5gjUyVExpKukv+MLxhfMKQlJLCh3A9sAgHncY1yqp+wN2rpjkl8ZKBcnizxxwVWMt/4AQ7LdnHN9/g0lK2CCtEEC6zH9N03KUxQ4p5msV7+5G1fSCl/JKKkDV2PCbgbd0f4qgxQ6NkzWZjXQMr2/j05d5WqXW4WMmS8SOb6+R6EGR85cbfNny6fsfyCqdRxxde5CaNLs9Mzzb/J+2R7cXtZ65XW5x7148vtlgiaR0H8xpjTcytwLu38cohCENh4qau0qEDwfoFgFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=i+0q0drz1PnYzIVvpMPaNg9lgG7Tam6XO5zaVwxxGiE=; b=uZAKkSzuD5sIoLORsSwUOQfzrOpRNOVJNAtok8NqLQd56X5cxS+31tA62uzO8H5P7fCDWOctpKbSWu+xU8M9ljYNZrPLq2d5bPstFIQO4/DA9Cw5la6crYYPPXHds8D552DeVR56L7tPfG1AoRKAqKTsfk6f9kEVB26HiKiapEc= From: Andrew Cooper To: Jan Beulich CC: George Dunlap , Stefano Stabellini , Wei Liu , Julien Grall , Xen-devel Subject: Re: [PATCH 4/4] xen/version: Introduce non-truncating XENVER_* subops Thread-Topic: [PATCH 4/4] xen/version: Introduce non-truncating XENVER_* subops Thread-Index: AQHZH69eYU4qCMuPJUaHOPPUV+yM+a6OfdiAgAAZEwCAAOVUAIAA7l0A Date: Thu, 5 Jan 2023 22:28:10 +0000 Message-ID: <63789ce5-5dff-c981-4127-d1ef3227595e@citrix.com> References: <20230103200943.5801-1-andrew.cooper3@citrix.com> <20230103200943.5801-5-andrew.cooper3@citrix.com> <9c9cedd5-cca7-95d4-00bb-f34a56de2695@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|BLAPR03MB5569:EE_ x-ms-office365-filtering-correlation-id: b2332e90-9cc2-4dfa-6863-08daef6c20b8 x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +8VM/PAO9Hrylt7YNfVEZ6AKAvBUnxz1pNTlPNr2ICjUwtI8H3aH1F0xpa4uxzdXul88dG3+g+9Ki9gCqqYJB0Ciq03D8d4wMjhjaAYWKbgPb33R4/tH0Rhl3i+mTlqW0lRFwakqR6Qdcqs2YkfcIft8z3OOkZGynCMwjFnqBhaieEzc3ZbqjvYJTBMH3F23TnqgkFhVuX61Fd34OdkrR0yTAj63aFV5qIGtSKN9deBBWqXJ7F2VpYancW/AhkjmY2JnSdTEelzqFIpu5J61FR+zNOZGl8wsSg4L+15AIpeqBOlYdoifeLm7kC90SuLE81bOe1w9Msl69MK9rLTDjDgM+wpnMllh3zaOfG4ABgJBnPOflaYsnljU2YML+yPqYCg8XkDyvZarPl6mP0AKDg8t3cjkN9fHhxEx+nLQnRT9oTjmGt3DpRiMh0pbcEfbuefW+1+Wvynhxokc2NHt96pFScFy+xY+z2wL+vnwPF4ShhtwZgjebus6QGwQYuwdJ04/sA8nTtCHUr5vld9EEqM8miZ3u7Xad/qF7oKNJ/Abbho/IFxpLQ5YLqiA9FoGgri60JyxmI9vWItft8iMS7ccjoaULj27qpruo47eOeT8JCwfcbum5/C0dEb1PMnlLqD7CuQDJh1c1vSsnVT/LpSshZyWBpoDQ5mXhYWtoD24TW3owAdjCE04RGvbSjntT/sNo0smFAvu0gCmE2ralgSe3C4uw9ixl2TbPARS+qPCJEgv2N5sJLa8ewzW63zNQYJHRNkUdjTu8Mb7KsN8cQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(396003)(136003)(39860400002)(366004)(451199015)(2616005)(83380400001)(31696002)(86362001)(38070700005)(122000001)(82960400001)(38100700002)(36756003)(2906002)(6916009)(54906003)(66899015)(5660300002)(91956017)(4326008)(64756008)(8676002)(66946007)(76116006)(66446008)(66556008)(66476007)(8936002)(316002)(41300700001)(478600001)(26005)(186003)(53546011)(6486002)(6512007)(31686004)(6506007)(71200400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ZDQzaWZrNTYrZmhWcjJoQUkvU0h3ZTg1SkxUbHozaW9hRU5LTlpzTmxhNlo5?= =?utf-8?B?N0VteE1TMWF6T0I2ZTFYVjkxYTZIQThFaHU5YW5YdCtrT3hRVzVTd1R4NkF5?= =?utf-8?B?U3R6bzlpdDN1ZjBhblZVRHRjakhmeFpKbWVEMzRhS1V1STlydlZJV0k0bDM1?= =?utf-8?B?Q3Q2MXA1UTZCZU1Bc2puV1lTNXlLU2N4ei80TWRaSEFjeGk2MU5Ub1pqaFl5?= =?utf-8?B?R2dWSUNPWVB3KytzdnhkTUR0SklFRXRPaDNGc1h5aW5hbk9EY0ZLdUdLUUdF?= =?utf-8?B?TExOajNzeTEyNy9ETVVtVWN4WlNZY3FvTWJXODRyYXBpZzY0a1NNVGRuR21O?= =?utf-8?B?Q21JUmErOGcxYnFtRU5SVVpoL0lMQm5XYXpxSElRS3ZBM3VyUkQ4TC8vNUgx?= =?utf-8?B?anUvZzdvWVJjUUJZQUJnZmdLdGg0Vnd4WksvSkZ1QnRadURiOXJoZHZQbkF4?= =?utf-8?B?K3o0VDZUN2dUUU15UjcwRllBczYvdDZPOXlUZVhBSS9VVWNVRHZkNUIzSis1?= =?utf-8?B?NzM1cW1YOVkxckRxSllYUzVOdEx6ZW12djJkamtyYlFLczBlSVhQUC9jcEtj?= =?utf-8?B?TFR3NGFmRDBuZ3RPNDFTRmltbldyNVB0aWZZaTBXQ1J3WlkrZHQ1QS9CNmR0?= =?utf-8?B?aEZZNURmT3ZqVCtlMUVmOUliN3l3NC8yQ0plV0xLeG1NWVQ0NDUxWDBCZ3R6?= =?utf-8?B?K0cyWERpTnhmbGpycHhHZ213cytIcm5aMzJNUTNRd2t1S3BsamRiZi84S0Vw?= =?utf-8?B?Vm1OVnlxQTMrYkdKbHMwRlZjWnIxZWVNNXVmOXBhYmxiMVJvWHRuWnFvZDFy?= =?utf-8?B?cDgvWUdKbDY3R080NzBEYk9uU1oxaUlmS3VGazJJOFdYMTVnTDJmYndqL2dL?= =?utf-8?B?cVVFdUxZdWlZaVcrZGxCTVZFRk5LaXoyYjd4dms3SHpVd0tiV2RFYWMramJU?= =?utf-8?B?dU81VWFma1pLZm9OUlQ4SXd5d3VqS0MwWFo3U0piMlBjNDdneW5nK3djR0Ux?= =?utf-8?B?OGRrMHNXMGhrQkdJYnhUWUMyaDBzSCttWFZXVVc4VWZuck1ucldnN1ZyRkwv?= =?utf-8?B?NzZnZnh5bkZiVjNxR3M1YW9XK3lCWjB3WmRpNDltTnZxSndrMy95S01pT0Yz?= =?utf-8?B?andJejdrLytwSEF0SWM2RVpJOFlibUVZVk5ibFRHaU1Mak5GeXNSbGUwajFN?= =?utf-8?B?Q1Z1eVpaVDhWVThmdy9HejFIdlYxR1I5azQwVXpMMUJkVnh3UllTckVhYWxO?= =?utf-8?B?c0ZpZ3JJLzZSR09EZmNTdnZPL1IxOEdoOEdDemRLdUNMeWNtQmViRHI3RlhB?= =?utf-8?B?SU5tck5WSDBYalpKUHdHaU9lUjAxZmkzQXFlaG9MWWFUSDl5TSt6OENyV00x?= =?utf-8?B?RHl4SGNNeU9NT0VTV0N2UzdoNDdnNUpYUDVsU2lsRElpUXpBeFVOR2hYT1pZ?= =?utf-8?B?UFArNGFKSlVVK0RRMkU3L1dsTjMxL2tmTVV4M1VqTlhUOFBzUWRTOHhmcG5h?= =?utf-8?B?OHJMZTBFL0xyOUZ2bEpMbkNLTUhKbUZpdkJGM2dUbjFFZHNaMFY4OVFtTjVX?= =?utf-8?B?bUFoYWU3bzdiVnliRjlieHpaZXpwN2srUGFIN3dqeUhzL3p3Z2g5OVNCR245?= =?utf-8?B?b1dvcGk0T1RlR3NwdDROd0hab1Nlam1JcmVJVEFTYXNiZDlIS0VVc2thS3Bm?= =?utf-8?B?YldJWWlZS09KMXZOQWpTelZuTWNsRWtNdFpLWmJwdTNsaWVOaDJpVWJFZ1gz?= =?utf-8?B?TG1RVXN2ejNId2FyeXpMY0lXdkF5M2xFblM5VDkxNEVjUWpGbW1hUVhySUtr?= =?utf-8?B?clVaNGdOS0JTcTdrbTNGSGdXQkVzb0NKMnNZeVRHNWxzcnFtMmptYUJrMFVt?= =?utf-8?B?V1NpRlNiL3hmNGNEQ2JZakJ5bTBPanRGVm5aYURtYkxGVGt1aUcxcjRMK0Rn?= =?utf-8?B?dU5YVDAzQVNFRG40U3RETjFEb3Z1TjQ5Z0hiWEVEK0ljRUtSR1l5RW8yMVI5?= =?utf-8?B?UW80TkdGWmwyRCtmYUFrTmNVeXZRMjlNTXpUVkdDYW8zeE0vTE0za2JYajBK?= =?utf-8?B?V3JnVHA5Y0w2ZURJaXg2R1ZZOFFHMGdZa0Nva3RNTER4Tms0SVduVzZEdTdO?= =?utf-8?B?TGdCUXM3TnlObis2SnVaZzNUVmx5cGoveXoybGZzVW1tUXBUV2NLbXJJRGQy?= =?utf-8?B?UEE9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <3E9623949BD3074388EC03CC50EF2EE8@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: QigMAkdvPPYWVCNoEj4GeJ81KHkEhccDbwreKnpg4dmaRT5iOS8UZIaB1FyUW3qzEgpKlf39PsBzDhgugcHGJYbvfloSMHDIX3Ka7TA7+BFLgLpEvz5OVCsJLXKCsv5Ict3c3si4JMBl/7Bui760HLrwZA5gFEOHSyt/Je8IH/2SfoEjCSsskDSSWzZaTP5Cg2iJ7p6CyKLAaAGz7+rmTsXLYMtEoCKzde/j6KIromPMellAH0PePdnFZuc6Aar/47qleOW7YUHLrjevT59U0XNwf9rsUER4C0kUIKHVc4+Vrpy2KyIWRHtlljFNNkIxdlk2QENn43873ezZ+XVxaF5OannQx01uNMi0LRYKieQ7EcR4ijU65iYKzfDX6MF/fAsVpnU1XUBlhhjloQ1XmFoN+RYfnZKeaGxNfnElPzw3VtZh3qW6PA3EmQIsi8VnDJenciw4sxdceMT42FAmfxFKsP1ZDVkYx6DIoHwk29adQ+0fONo8SHQZIncqWt4zcOsLQDmftiVpxId8FnXDW03m+Z3WRBnH3w3FPPj5G7G6KQVxu+7xQswZUNJtDYgG1WSz8hvkDRkOpPrA4OXqyA9FCETUULT6Rle5D5mOyPgitQPCeFQVY02m9hiU8M+S0Rqm5INADYdOj64ymKCh38oMc9yt7KwCqaSmQjtcC0v6vFTIYYKz3m0Kq7cIQ6tG/T/+o4bOxLqS/sDLSYK7/+M47+jeo9mQ1FMtGcotMQ2ixUgWBb8sVILPqvgTO9ILU/HphuG7FKY3JrBeoS9iSs5FyufEfGyCOeT5RlpZq5Ms/npitoAR65K3gBHLjBDU03vzM7pAfcDpZQomf/IfeF5RmIqC50THRf04BaHGOCpeMjVJwHRZ5oojWRxU6Xmi X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b2332e90-9cc2-4dfa-6863-08daef6c20b8 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jan 2023 22:28:11.0184 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wD4otfobODsK4ugo1DAob0VhjshZe2/+E4TFYI6mYy6WyIr0ND+IQ3ERGVmYSE9VMyCmyHut1tE39WgQ3FT50F5KyEbVB0gPP9fijUQuArU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5569 T24gMDUvMDEvMjAyMyA4OjE1IGFtLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMDQuMDEuMjAy MyAxOTozNCwgQW5kcmV3IENvb3BlciB3cm90ZToNCj4+IE9uIDA0LzAxLzIwMjMgNTowNCBwbSwg SmFuIEJldWxpY2ggd3JvdGU6DQo+Pj4gT24gMDMuMDEuMjAyMyAyMTowOSwgQW5kcmV3IENvb3Bl ciB3cm90ZToNCj4+Pj4gQVBJL0FCSSB3aXNlLCBYRU5WRVJfYnVpbGRfaWQgY291bGQgYmUgbWVy Z2VkIGludG8geGVudmVyX3ZhcnN0cmluZ19vcCgpLCBidXQNCj4+Pj4gdGhlIGludGVybmFsIGlu ZnJhc3RydWN0dXJlIGlzIGF3a3dhcmQuDQo+Pj4gSSBndWVzcyBidWlsZC1pZCBhbHNvIGRvZXNu J3QgZml0IHRoZSByZXN0IGJlY2F1c2Ugb2Ygbm90IHJldHVybmluZyBzdHJpbmdzLA0KPj4+IGJ1 dCBpbmRlZWQgYW4gYXJyYXkgb2YgYnl0ZXMuIFlvdSBhbHNvIGNvdWxkbid0IHVzZSBzdHJsZW4o KSBvbiB0aGUgYXJyYXkuDQo+PiBUaGUgZm9ybWF0IGlzIHVuc3BlY2lmaWVkLCBidXQgaXQgaXMg YSBiYXNlNjQgZW5jb2RlZCBBU0NJSSBzdHJpbmcgKG5vdA0KPj4gTlVMIHRlcm1pbmF0ZWQpLg0K PiBXaGVyZSBhcmUgeW91IHRha2luZyB0aGlzIGJhc2U2NCBlbmNvZGluZyBmcm9tPyBJIHNlZSB0 aGUgYnVpbGQgSUQgYmVpbmcgcHVyZQ0KPiBiaW5hcnkgZGF0YSwgd2hpY2ggY291bGQgZWFzaWx5 IGhhdmUgYW4gZW1iZWRkZWQgbnVsLg0KDQpPaCwgc28gaXQgaXMuDQoNCkknZCBmYWlsZWQgdG8g c3BvdCB0aGF0IGxpYnhsIGZvcm1hdHMgaXQgYXV0b21hdGljYWxseSBvbiBiZWhhbGYgb2YgdGhl DQpjYWxsZXIuDQoNCj4+Pj4gKyAgICBpZiAoIHN6ID4gSU5UMzJfTUFYICkNCj4+Pj4gKyAgICAg ICAgcmV0dXJuIC1FMkJJRzsgLyogQ29tcGF0IGd1ZXN0cy4gIDJHIG91Z2h0IHRvIGJlIHBsZW50 eS4gKi8NCj4+PiBXaGlsZSB0aGUgY29tbWVudCBoZXJlIGFuZCBpbiB0aGUgcHVibGljIGhlYWRl ciBtZW50aW9uIGNvbXBhdCBndWVzdHMsDQo+Pj4gdGhlIGNoZWNrIGlzIHVuaWZvcm0uIFdoYXQn cyB0aGUgZGVhbD8NCj4+IFdlbGwgaXRzIGVpdGhlciB0aGlzLCBvciBhIChjb21hdCA/IElOVDMy X01BWCA6IElOVDY0X01BWCkgY2hlY2ssIGFsb25nDQo+PiB3aXRoIHRoZSBpZmRlZmFyeSBhbmQg cHJlZGljYXRlcyByZXF1aXJlZCB0byBtYWtlIHRoYXQgY29tcGlsZS4NCj4+DQo+PiBCdXQgdGhl cmUncyBub3QgYSBDUFUgdG9kYXkgd2hpY2ggY2FuIGFjdHVhbGx5IG1vdmUgMkcgb2YgZGF0YSAo d2hpY2ggaXMNCj4+IDRHIG9mIEwxZCBiYW5kd2lkdGgpIHdpdGhvdXQgc3VmZmVyaW5nIHRoZSB3 YXRjaGRvZyAoZXNwZWNpYWxseSBhcyB3ZSd2ZQ0KPj4ganVzdCByZWFkIGl0IG9uY2UgZm9yIHN0 cmxlbigpLCBzbyB0aGF0J3MgNkcgb2YgYmFuZHdpZHRoKSwgbm9yIGRvIEkNCj4+IGV4cGVjdCB0 aGlzIHRvIGNoYW5nZSBpbiB0aGUgZm9yc2VlYWJsZSBmdXR1cmUuDQo+Pg0KPj4gVGhlcmUncyBz b21lIGJvdW5kYXJ5IChwcm9iYWJseSBmYXIgbG93ZXIpIGJleW9uZCB3aGljaCB3ZSBjYW4ndCB1 c2UgdGhlDQo+PiBhbGdvcml0aG0gaGVyZS4NCj4+DQo+PiBUaGVyZSB3YW50cyB0byBiZSBzb21l IGxpbWl0LCBhbmQgSSBkb24ndCBmZWVsIGl0IGlzIG5lY2Vzc2FyeSB0byBtYWtlDQo+PiBpdCB2 YXJpYWJsZSBvbiB0aGUgZ3Vlc3QgdHlwZS4NCj4gU3VyZS4gTXkgcXVlc3Rpb24gd2FzIG1lcmVs eSBiZWNhdXNlIG9mIHRoZSBzcGVjaWFsIG1lbnRpb25pbmcgb2YgMzItYml0IC8NCj4gY29tcGF0 IGd1ZXN0cy4gSSdtIGZpbmUgd2l0aCB0aGUgdW5pdmVyc2FsIGxpbWl0LCBhbmQgSSdkIGFsc28g YmUgZmluZQ0KPiB3aXRoIGEgbG93ZXIgKHVuaXZlcnNhbCkgYm91bmQuIEFsbCBJJ20gYWZ0ZXIg aXMgdGhhdCB0aGUgKHRvIG1lIGF0IGxlYXN0KQ0KPiBjb25mdXNpbmcgY29tbWVudHMgYmUgYWRq dXN0ZWQuDQoNCkhvdyBhYm91dCAxNmsgdGhlbj8NCg0KPj4gQnV0IG92ZXJhbGwsIEknbSBub3Qg c2VlaW5nIGEgbWFqb3Igb2JqZWN0aW9uIHRvIHRoaXMgY2hhbmdlP8KgIEluIHdoaWNoDQo+PiBj YXNlIEknbGwgZ28gYWhlYWQgYW5kIGRvIHRoZSB0b29scy8gY2xlYW51cCB0b28gZm9yIHYyLg0K PiBXZWxsLCBJJ20gbm90IGVudGlyZWx5IGNvbnZpbmNlZCBvZiB0aGUgbmVlZCBmb3IgdGhlIG5l dyBzdWJvcHMgKHdlIGNvdWxkDQo+IGFzIHdlbGwgaW50cm9kdWNlIGJ1aWxkIHRpbWUgY2hlY2tz IHRvIG1ha2Ugc3VyZSBubyB0cnVuY2F0aW9uIHdpbGwgb2NjdXINCj4gZm9yIHRoZSBleGlzdGlu ZyBvbmVzKSwgYnV0IEkgYWxzbyB3b24ndCBvYmplY3QgdG8gdGhlaXIgaW50cm9kdWN0aW9uLiBB dA0KPiBsZWFzdCBmb3IgdGhlIGNvbW1hbmQgbGluZSBJIGNhbiBzZWUgdGhhdCB3ZSB3aWxsIHdh bnQgKG5lZWQpIHRvIHN1cHBvcnQNCj4gbW9yZSB0aGFuIDFrIHdvcnRoIG9mIGEgc3RyaW5nLCBj b25zaWRlcmluZyBob3cgbWFueSBvcHRpb25zIHdlIGhhdmUNCj4gYWNjdW11bGF0ZWQuDQoNCkkn dmUgbGVnaXRpbWF0ZSBjdXN0b21lciBidWdzIGNhdXNlZCBieSB0aGUgY21kbGluZSBsaW1pdCwg YW5kIHJlYWwgdGVzdA0KcHJvYmxlbXMgY2F1c2VkIGJ5IHRoZSBleHRyYXZlcnNpb24gbGltaXQg d2hpY2ggSSdtIHVud2lsbGluZyB0byAiZml4Ig0KYnkgc3RpY2tpbmcgdG8gdGhlIGN1cnJlbnQg QVBJL0FCSS4NCg0KfkFuZHJldw0K From xen-devel-bounces@lists.xenproject.org Thu Jan 05 22:41:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 22:41:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472211.732355 (Exim 4.92) (envelope-from ) id 1pDYve-00048O-4n; Thu, 05 Jan 2023 22:41:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472211.732355; Thu, 05 Jan 2023 22:41:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDYvd-00048H-Vn; Thu, 05 Jan 2023 22:41:41 +0000 Received: by outflank-mailman (input) for mailman id 472211; Thu, 05 Jan 2023 22:41:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDYvd-000483-0k; Thu, 05 Jan 2023 22:41:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDYvc-0007vo-V2; Thu, 05 Jan 2023 22:41:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDYvc-0000DQ-JA; Thu, 05 Jan 2023 22:41:40 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pDYvc-0004sP-IQ; Thu, 05 Jan 2023 22:41:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=V8HwzMZOSno/ACkYrpNZ4+zTmEMbJF0sZFGklF2A0zc=; b=GHXkwX5DIL01Hqt37FoAkbBMjf uAY/bHWK6qjF6Y0V6mPHuVBkZBoZWAQlSE+/VBIwtSg2Ji/DuzSmsvH1G+g98WJCioT3Pdnix453x 4dk5C2DtcEQ99s/LaydLcmpNSHNFHd7oajeKHniQIwrZ+z/UYSyRKUVm1GE/VxQ2ijow=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 175593: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=2b21cbbb339fb14414f357a6683b1df74c36fda2 X-Osstest-Versions-That: xen=671f50ffab3329c5497208da89620322b9721a77 From: osstest service owner Date: Thu, 05 Jan 2023 22:41:40 +0000 flight 175593 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/175593/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 2b21cbbb339fb14414f357a6683b1df74c36fda2 baseline version: xen 671f50ffab3329c5497208da89620322b9721a77 Last test of basis 175589 2023-01-05 16:01:55 Z 0 days Testing same since 175593 2023-01-05 20:00:28 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alistair Francis Oleksii Kurochko jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 671f50ffab..2b21cbbb33 2b21cbbb339fb14414f357a6683b1df74c36fda2 -> smoke From xen-devel-bounces@lists.xenproject.org Thu Jan 05 22:56:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 Jan 2023 22:56:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472220.732366 (Exim 4.92) (envelope-from ) id 1pDZ9l-0005hS-Bk; Thu, 05 Jan 2023 22:56:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472220.732366; Thu, 05 Jan 2023 22:56:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDZ9l-0005hL-8o; Thu, 05 Jan 2023 22:56:17 +0000 Received: by outflank-mailman (input) for mailman id 472220; Thu, 05 Jan 2023 22:56:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDZ9k-0005gy-DR for xen-devel@lists.xenproject.org; Thu, 05 Jan 2023 22:56:16 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 257e7de7-8d4c-11ed-b8d0-410ff93cb8f0; Thu, 05 Jan 2023 23:56:12 +0100 (CET) Received: from mail-bn7nam10lp2105.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.105]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 05 Jan 2023 17:56:09 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BL1PR03MB6085.namprd03.prod.outlook.com (2603:10b6:208:308::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 22:56:06 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 22:56:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 257e7de7-8d4c-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1672959371; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=EScHE4GWpXVuFvg/BK0Zc3NxeCBO/9KiCKg60f4Y4Fs=; b=PwqXqPRUrjN0hOSYjQX8b4MUv8MuFxEI8iMRzhltjL/5r9WDd6b7Or/6 VhE+uTKQBc2I6KcIttJI9et+v7Wd2nQWDRxQne2jSOnI8PmYUqlp0doPj SglVvyq4e2dAINd6OmCn8sh8bgz40T3/i+CYoyu8+1/z8oZEEz38qPlou o=; X-IronPort-RemoteIP: 104.47.70.105 X-IronPort-MID: 91392351 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:DAMSgK7IbAWrD2I5bCUMNgxRtBrGchMFZxGqfqrLsTDasY5as4F+v mUXUGuHbvaPamf8eNp+bY22phgGvJ/VyYcwTgRr+Xw8Hi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraBYnoqLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+4pwehBtC5gZlPakT4QeF/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m0 sUGESgLYAu/hs29nJzlFflH1/k6FZy+VG8fkikIITDxK98DGMiGaYOVoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6MlEooiOWF3Nn9I7RmQe18mEqCq 32A1GP+GhwAb/SUyCaf82LqjejK9c/+cNNLT+ziraMz6LGV7lITWB00CwacneCgmES7C+lkc mo72yV7+MDe82TuFLERRSaQsHOC+xIRRddUO+k78x2WjLrZ5R6DAWoJRSIHb8Yp3Oc0TzE30 l6Cn/vyGCdi9raSTBq16bO8vT60fy8PIgc/iTQsSAIE55zppt41hxeWFtJ7Svft05vyBC36x C2MoG4mnbIPgMUX1qK9u1fanzaroZuPRQkwjunKYl+YAspCTNbNT+SVBZLzt56s8K7xooG9g UU5 IronPort-HdrOrdr: A9a23:ZJ/PeanNlc1CGxls72udf8RkKKTpDfIg3DAbv31ZSRFFG/Fw9v re/sjzsCWetN9/YhsdcLy7VZVoOEmskaKdgrNhXotKPjOGhILAFugL0WKF+VLd8gLFmtK1vp 0BT0ERMrPN5eQRt7ee3DWF X-IronPort-AV: E=Sophos;i="5.96,303,1665460800"; d="scan'208";a="91392351" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CGrHqgA48/q/GnbuXAUJNU5v4Lr4AHey98FaXcRsoaNR5C85lI/vLV8/y1C+fI73yFbGdwhsf/GC3yVfDQRFr/9bZrIerjzuGw9kzLeWKb+Gqc0ZG29GGuVWXhPD46kyei9ipYWMfzswim8vi9ZMhP08D2gt0ARrl5WQr/S/NwYXZrH7uSNuR3W+KCgQ9uk8pqxXGjfmJehDzK1+glEo/MX/bJ5l9BQZsBSzcx1HCpfqLENnIy42fi58n3S2BnF9y13JZ+4yCn2ev6DiuXuPxbmrbJcWfdXosJ/8aIpYl0jpfmQxXhFBTrgThd4L2koAntzBdqWsWtayyBv786hSfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EScHE4GWpXVuFvg/BK0Zc3NxeCBO/9KiCKg60f4Y4Fs=; b=oL1Obf/k1M2j1qROlt5u62Pfofq83gWPzaInltwyHH92kX4/erGjiN+bACrjzWUyFzszth4p5sBbTqf5Tbv8nwR2/kURWH+Kax9skiY8tqgkVq0yFejVkBtJExxjJF2OqL+9v75bcFosAY5qeZpZbveDJrhc/MokBXXv33qfAJaAVCeGSL0PGQOIlV6vFpJPh8dvSFXntlBZDV+ZiPx0J3J7TvIVB8jyjasJanqy7ImJ0MCYtqJ2Are4LNjcs3rCYD4XfUbC6DERZPmMxm1lCq/K/kErHht9xjBRCtHC+9lvJZFyGa6HJ2ql1pILG8TEJonVa/EwCrKHEeaFM3yGKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EScHE4GWpXVuFvg/BK0Zc3NxeCBO/9KiCKg60f4Y4Fs=; b=aKnTcDpFQ7ScJlOWezra+VaPRKa2VoXhWPas/h9VWJxRsFDSqeqqfBdKLQOlCkWevLkWBjtIovMRT91z5tV5dGPpaWC+1203gb8hkAyJj6crORgVBsW8YE3jNXeF54eXx2X4IZ/Q/ppnKqjcA7EhJCwAaI5a08evgkY2pZGcOgw= From: Andrew Cooper To: Sergey Dyasli , "xen-devel@lists.xenproject.org" CC: Jan Beulich , Roger Pau Monne , Wei Liu Subject: Re: [PATCH] x86/ucode/AMD: apply the patch early on every logical thread Thread-Topic: [PATCH] x86/ucode/AMD: apply the patch early on every logical thread Thread-Index: AQHZIQhyMB1JmOs75E6HWYrcfqEv3a6Qb7eA Date: Thu, 5 Jan 2023 22:56:06 +0000 Message-ID: <55cccf9d-e4c9-6dec-ee9d-fec56f521931@citrix.com> References: <20230105132004.7750-1-sergey.dyasli@citrix.com> In-Reply-To: <20230105132004.7750-1-sergey.dyasli@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|BL1PR03MB6085:EE_ x-ms-office365-filtering-correlation-id: d2315998-d0f7-43fc-ad13-08daef70072c x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: zSZLrQe32GMJM5yqYe+oiiWsJpOit+mViJoZRZb3yFHEY4AF5Ar6XTbZ3YO+uIg/vA0C2Ba/YhbAECxW5qhmz7tc3woVHpiso+DURo487nuCG3lxJ9jwpaAc1rTa8rCe90iUFDQz8fWlviEsw2zaH7+WXZ3z5Q2SOh4l+fnk+rNQGIQqiY4VvpTodlhi0kYk2dnJYgD7PgmDprkh4Ipk3rk1wNfYbW+nuOPcB03W6TR/yzzfhzi1jMX/REUUpmXnx17prPXsUWFDeNzO3wUhe+xpH6askyp+dKPzRpG+Ut8IgbuMbWEdnfjQASRjTr3+dYGZQaornpxjPkze68mTlY1aunX+5jd8hHfSPNozXj6b/6M7UbYay/gUHU3zlNTcOLMwRJ3bKNZjN8op8QptHAm3OlB/7ospxkYJT+Z0zTkqZjL1zhGGpGGBPb9mAQH2D0VAqGpGNpK91NHLohrTUkad+LE46WttvPRJy28Y87T1hsIoIr/5KNSYRqk5l+qlrUKedQP1OWrm2ZbbMOOY1a7gYyDtcs7ECc3VsY28MLayTXzrtbpn0UAzyThCKpb7OCbAz5Aj9ouWbQs4IVTmhzxFvwl0g3Mhu3ZARhk3EJk+oBQr/4xLiEhRt0eAaiVwH2mpgTY9tAEc76yGKqKwY09Z51/Yhee0wgTJ8WjPq5Wr+fq+JfMasRyLG0qMgLQihrLWMFKJX1KrL1ipnAYFhyUQtSHWdyedSgTYmnDVpk6cI3ocPdi/h5BMvisn3QWn9OfhFXGhOGkMry6SrCkyMOSy4cCTbmaH4qzc1Swgpi8= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(366004)(376002)(136003)(346002)(451199015)(6512007)(53546011)(26005)(31686004)(478600001)(2906002)(6486002)(966005)(71200400001)(6506007)(186003)(66446008)(76116006)(2616005)(66476007)(64756008)(66556008)(91956017)(8676002)(66946007)(41300700001)(110136005)(4326008)(316002)(38100700002)(5660300002)(83380400001)(36756003)(122000001)(54906003)(82960400001)(8936002)(38070700005)(86362001)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?U1NCYWxqZ0FiNWl5enJ2aWhIWjFPUTRrUEJUa1dsTUhqbkdMZ2JBWVdDa3hl?= =?utf-8?B?b2xYajM2VTBoN3dwOGlGUXQ5S0Z1TE84NXpzcUdpT1d2RHFhWEJZdjJFczho?= =?utf-8?B?UjF1Q28rL1Y4Y20yTXdvOFpGOFVScDlKemJVeHNyTmY2NFJ2UFluZjBGY2R6?= =?utf-8?B?bEY3ZWNSNkZwOTM3Qm9LaDB6K1lCSG85eitzOHNUUjlrQUsvWGhCaUdxWnFN?= =?utf-8?B?eGV4b0RlZEJrRzBUTzYwenNwTjRUZ0Nuc1lKd2tUUHpya1lPSWIvbmZ1cUl4?= =?utf-8?B?dktLZnNNazFiUmxSTmMyNE1RdlI1OVo4L3NYczRkUllaS2JieHV6VWp6SCsy?= =?utf-8?B?cGd0aGllb2JZV0o2TTZRVFFURFdrdVRHSEZQS1A5anY2MW1sZ0QyUW9rclNy?= =?utf-8?B?aDF5VTFPMmd6cFpsak5sNFVJWGhLeXpKZnp4YWZYT3A3RmRBNHl3Uk11L2Zz?= =?utf-8?B?NTNwa3JvMzRqRXhvMEZQWUw4TDRBK3crVTUrd0RCeEVEbzFTcXdFN0FiVGth?= =?utf-8?B?SmMyYzI1VDlSRWV1Z1BlMEtQdHBhSWN0Zkh6MStaY3o0YWZvVzhkamZCenM3?= =?utf-8?B?SitnOW1pSjlQZ2NZdGpHeUUrL1BTM1RzUlNrVy9lRk8wWEdRbVRpK1NNSDM1?= =?utf-8?B?aURSWkdWOWZWYm8wajhwcGdId0VGSVBMZElBQXlpTXp4ekFOQVZ5Q05udUdB?= =?utf-8?B?OEVEMTRnOG5MNm0vWXlGNHAvUmROcDllakRNZXR0R1p2ZUYva0dWK3FUYi9T?= =?utf-8?B?cGFIVVV3dkNINWU1c2Z6VU9zK3ZtV2JKR2VkR3Fvek1DMDd1OGRVL3ZBSEVh?= =?utf-8?B?QzlaV3hYK3M5L1Z0ZjlubkVOQ3c1MHJRQSt3d01oL2F2WUNzTHIxWW1kMldW?= =?utf-8?B?WmVGQjdSdGhJQzBacjZteWhXYWRzVDc1a0R3ZTNNTUk3RFJtU1hDSFFKL1dn?= =?utf-8?B?aDFLNmxnUFJ0aUZUQXkxSjNKbUUxbHBvOTlUVDJ6N2IwUnVoUEtvS2hUeVo3?= =?utf-8?B?Wk42cFNjR1VMaGh5TVRmdEtpT2ViaTFYd3JLQ09jQzRSY1FIYUFJcDVpMENZ?= =?utf-8?B?WGN2VDM4R0ppdE5mbm9uUWZibklMYnJIQWdiQktuam9sK29zb2ZzaWVXZzRm?= =?utf-8?B?ZldRWDg1YjFCY3RWVXNRY1NnVzdJd1ZoSnd1YlF2NXZybTFiaXE4VnFVOUJv?= =?utf-8?B?bTFJcUxjektydTJTUlFlRHlTeTVrNGRHbFhqV0t1dnhURDNCQUZQdmF4cDRn?= =?utf-8?B?dGFESG1DcXpPenREWjlCenBtaG9GaTl0b1FFVjZZN2x3VU94Z3JDOGFScVVH?= =?utf-8?B?dWM4dzVtSXBKUWlJeHFuRFovZzFQaitMWlF4VUVzV0dyT0p1THM1SlV0U21r?= =?utf-8?B?TlI1Zll6Z1pxQ2ptemtZSThybHJJb3dHU21tUjJCT3R2V2w5WmdadWNiMmdu?= =?utf-8?B?ZFFvSUNBM1VSZk1nWTN3ZVdOT2Q5Ymt2aCt4YUlSVWlQbHg2SVBFanhUQ21Y?= =?utf-8?B?QW1hUk1rdXpHa1VpM3l5YTJKajFqZnpEcVUvQnkwRmoyRmFINlpyYWNYem9S?= =?utf-8?B?cDR3RzFxa3M0RzNiSlg3UlIwRERpZk9IbENQaXBWeSszVDlLZjlBbXpFbWtz?= =?utf-8?B?RXVjYmhVNUJOMTg5d2pGZWNzMWkyYTJ6T0w5TStLMmpQM0ozY2hqSU5SMjJu?= =?utf-8?B?TkNYT2x1N0Q3TEpTZVIyTjhNSmR3MzBPM2tWTG93Ky9zWWs0NUQvMWlpaW0r?= =?utf-8?B?VXk4cXB6dENwZmNoZHROWmNvQXhjaGlnNkE1T0FFVm4vR05HVnh4a2NLVVhW?= =?utf-8?B?VlFRNldYUzZjR0RWUDEya2ZvdzdtRy81QnFWNEtLL3p3NkpLWGttM0dHTnNJ?= =?utf-8?B?NmNXc1pNMDJuakFXYWdKYml6Wm9XOUNWOFpvQkd3b0RQYm8vRTlWT00vbW1F?= =?utf-8?B?ekJHOU4xMkMrTGNpTmRWeWw2bUZQYURJcWlSM2JCMFlEUDB5a09JcktXcklF?= =?utf-8?B?Wkx5VkpyVWs3YnhoWDhvaVRxaW80RXpqekp6ZkNtRlNnMm1lWEF2NzVVaElk?= =?utf-8?B?MU5xdDhZOGRZcysxS045UVhwazVEQk9HaERqdk9QVUxUbUZFWXNnK096MEx0?= =?utf-8?B?Y05ram84Uk5VcUZ4UnB0VWRCWFRZbHl3UzFTcWFlaTZRb0JKeU9sNjFOZFJU?= =?utf-8?B?aGc9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: ZlOgr2EL7jQC8BCa0cqfjfQnJLDZgt9remToFQZWQC4zR7mcZddzrcQzphcI1sPThe0lv6NnHBwzwWpzAQxXgKvJp9gi/FFD4g8RL0OEGPL2brqEDwMtnLN/d+IZWwRhTJG2gCQ7g6yGGkhjwGB5v8gaOMiijR8g9yqv2fQ/IH8eSQ3lUk9gC7AY++tPUXuLNk3oZmvojiH4q2hj3G8Sj8XSmU3ajbV5HccpeExzRpmjq6fc0m/gLI+MyqI7HqQr2FdWElc+EjOKDb/ZXN9eCci2iG/tKFP2UeqhGmif1/drr3Fy6BHSL/o/9iRzEVFzp/1f9ZOYpuPqQaYg0zyJlyA+/NqXRLe9ifhzVP15ff13dJ1/aj2XKg3fxWQ+TTHKQKoPLZQDrXhSPncRRY7JlJkwPdTOwTx9pk3LfP214fTjaxC/xIAkCazj2+wJ0KhxT+Gdyo/lL5BrhXGGnbYx2xiaofOdNLoxuX8YvD8P7dbOYcSI4wWhfMWh1zDuMp8/KeSaJmze68WBacIlX8AQkEeVfSej7TenOn9EIphbpyjze0NbNzCn9uTS70VPGcHD6pZ5lOap8lwYQXF2h3iTL10CbE/2HGEMN9CgXo9SgvhcB2ZyrLAAuGiuZylvGQzIX3JZGBitA1xPKGQVCKzHVz8rzL053fiSLYVnocpoaN9U7hmDYJk5XdtNIXTWMog8f1oE+3tt2YiwUgfLBB9Xe+y7gdn+DknyKFu4p6nZyL2f93UN04u8T0VJUzQbPEKSbTkYWX+TriR4BcbMCR6pVBVK+5t0FfqUGOB6C+52O8PJ2mbXZZEfhrucgKLrZ81Q X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d2315998-d0f7-43fc-ad13-08daef70072c X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jan 2023 22:56:06.1934 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tFs4yesNkYEDDl0KywZZpeSR6zPhUVGwG67/ZtiLbBiQ4IErxL4ZIyajX8EfJK5ojbLE/HZfJZ1dWN2lQxdVFn1TB+2jti+f2u+7a/7N1OY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR03MB6085 T24gMDUvMDEvMjAyMyAxOjIwIHBtLCBTZXJnZXkgRHlhc2xpIHdyb3RlOg0KPiBUaGUgb3JpZ2lu YWwgaXNzdWUgaGFzIGJlZW4gcmVwb3J0ZWQgb24gQU1EIEJ1bGxkb3plci1iYXNlZCBDUFVzIHdo ZXJlDQo+IHVjb2RlIGxvYWRpbmcgbG9zZXMgdGhlIExXUCBmZWF0dXJlIGJpdCBpbiBvcmRlciB0 byBnYWluIHRoZSBJQlBCIGJpdC4NCj4gTFdQIGRpc2FibGluZyBpcyBwZXItU01UIGNvcmUgbW9k aWZpY2F0aW9uIGFuZCBuZWVkcyB0byBoYXBwZW4gb24gZWFjaA0KPiBzaWJsaW5nIFNNVCB0aHJl YWQgZGVzcGl0ZSB0aGUgc2hhcmVkIG1pY3JvY29kZSBlbmdpbmUuIE90aGVyd2lzZSwNCj4gbG9n aWNhbCBDUFVzIHdpbGwgZW5kIHVwIHdpdGggZGlmZmVyZW50IGNwdWlkIGNhcGFiaWxpdGllcy4N Cj4gTGluazogaHR0cHM6Ly9idWd6aWxsYS5rZXJuZWwub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTYy MTENCg0KQnVsbGRvemVyIGlzIENNVCwgbm90IFNNVC7CoCBUaGUgcmVsZXZhbnQgcHJvcGVydHkg aXMgdGhhdCBib3RoIENNVCdzDQpzaGFyZSBhIHNpbmdsZSBtaWNyb2NvZGUgc2VxdWVuY2VyLg0K DQpYZW4gaGFwcGVucyB0byBub3QgYmUgaW1wYWN0ZWQgYnkgdGhhdCBzcGVjaWZpYyBidWcsIGJl Y2F1c2Ugd2UgbGV2ZWwNCnRoZSBmZWF0dXJlIG1hc2tpbmcvb3ZlcnJpZGUgTVNScywgYW5kIHRo ZSBMV1AgYml0IGZhbGxzIG91dC4NCg0KDQpJdCdzIGFsc28gaW1wb3J0YW50IHRvIHN0YXRlIHRo YXQgbG9hZGluZyBvbiBldmVyeSBsb2dpY2FsIHByb2Nlc3NvciBpcw0KdGhlIHJlY29tbWVuZGF0 aW9uIGZyb20gQU1ELCBhZnRlciBkaXNjdXNzaW5nIHRoYXQgYnVnLsKgIEJlY2F1c2UgaXQNCmNv bnRyYWRpY3RzIHRoZSBjdXJyZW50bHkgd3JpdHRlbiBhZHZpY2UgaW4gdGhlIEJLREcvUFBScy4N Cg0KPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L2NwdS9taWNyb2NvZGUvcHJpdmF0ZS5oIGIv eGVuL2FyY2gveDg2L2NwdS9taWNyb2NvZGUvcHJpdmF0ZS5oDQo+IGluZGV4IDczYjA5NWQ1YmYu LmM0YzY3MjlmNTYgMTAwNjQ0DQo+IC0tLSBhL3hlbi9hcmNoL3g4Ni9jcHUvbWljcm9jb2RlL3By aXZhdGUuaA0KPiArKysgYi94ZW4vYXJjaC94ODYvY3B1L21pY3JvY29kZS9wcml2YXRlLmgNCj4g QEAgLTcsNiArNyw3IEBAIGV4dGVybiBib29sIG9wdF91Y29kZV9hbGxvd19zYW1lOw0KPiAgDQo+ ICBlbnVtIG1pY3JvY29kZV9tYXRjaF9yZXN1bHQgew0KPiAgICAgIE9MRF9VQ09ERSwgLyogc2ln bmF0dXJlIG1hdGNoZWQsIGJ1dCByZXZpc2lvbiBpZCBpcyBvbGRlciBvciBlcXVhbCAqLw0KPiAr ICAgIFNBTUVfVUNPREUsIC8qIHNpZ25hdHVyZSBtYXRjaGVkLCBidXQgcmV2aXNpb24gaWQgaXMg dGhlIHNhbWUgKi8NCj4gICAgICBORVdfVUNPREUsIC8qIHNpZ25hdHVyZSBtYXRjaGVkLCBidXQg cmV2aXNpb24gaWQgaXMgbmV3ZXIgKi8NCj4gICAgICBNSVNfVUNPREUsIC8qIHNpZ25hdHVyZSBt aXNtYXRjaGVkICovDQo+ICB9Ow0KDQpJIGRvbid0IHRoaW5rIHRoaXMgaXMgYSBjbGV2ZXIgaWRl YS7CoCBGb3Igb25lLCBPTEQgYW5kIFNBTUUgYXJlIG5vdw0KYW1iaWd1b3VzIChhdCBsZWFzdCBh cyBmYXIgYXMgdGhlIGNvbW1lbnRzIGdvKSwgYW5kIGhhdmluZyB0aGUNCmRpZmZlcmVuY2UgYmV0 d2VlbiB0aGUgdHdvIGRlcGVuZCBvbiBhbGxvd19zYW1lIGlzIHVuZXhwZWN0ZWQgdG8gc2F5IHRo ZQ0KbGVhc3QuDQoNCkkgbmV2ZXIgcmVhbGx5IGxpa2VkIHRoZSBlbnVtIHRvIGJlZ2luIHdpdGgs IGFuZCBJIHRoaW5rIHRoZSBsb2dpYyB3b3VsZA0KYmUgY2xlYW5lciB3aXRob3V0IGl0Lg0KDQoN CldlIGRlcGVuZCBlbnRpcmVseSBvbiB0aGVyZSBiZWluZyBvbmUgdWNvZGUgYmxvYiB3aGljaCBp cyBhcHBsaWNhYmxlDQpnbG9iYWxseSBhY3Jvc3MgdGhlIHN5c3RlbSwgc28gTUlTX1VDT0RFIGNh biBiZSBleHByZXNzZWQgYXMgcmV0dXJuaW5nDQpOVUxMIGZyb20gdGhlIGluaXRpYWwgc2VhcmNo ZXMuwqAgRXZlcnl0aGluZyBlbHNlIGNhbiB0aGVuIGJlIGV4cHJlc3NlZA0KaW4gYSBub3JtYWwg e21lbSxzdHJ9Y21wKCkgd2F5IChpLmUuIC0xLzAvKzEpLg0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Fri Jan 06 00:55:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 00:55:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472228.732377 (Exim 4.92) (envelope-from ) id 1pDb10-0001AO-D4; Fri, 06 Jan 2023 00:55:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472228.732377; Fri, 06 Jan 2023 00:55:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDb10-0001AH-AR; Fri, 06 Jan 2023 00:55:22 +0000 Received: by outflank-mailman (input) for mailman id 472228; Fri, 06 Jan 2023 00:55:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDb0y-0001AB-27 for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 00:55:20 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c80ad64e-8d5c-11ed-91b6-6bf2151ebd3b; Fri, 06 Jan 2023 01:55:16 +0100 (CET) Received: from mail-dm6nam04lp2041.outbound.protection.outlook.com (HELO NAM04-DM6-obe.outbound.protection.outlook.com) ([104.47.73.41]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 05 Jan 2023 19:55:11 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CH2PR03MB5191.namprd03.prod.outlook.com (2603:10b6:610:93::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Fri, 6 Jan 2023 00:55:09 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5944.019; Fri, 6 Jan 2023 00:55:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c80ad64e-8d5c-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1672966516; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=NuV4HaD2bCln0Nm0zAO4yk9D+7lRmMaC1YSTGaUxamE=; b=faRatfXkWZUwY5dpYh8tM1c74HuJDSweMaP52qtggbH0syub/nEmejFa bH7m4wrr1krlRTl5luJ95RA2z2K2byo7y/wku3JImeur/GeyAciZniQbv KaV8Gm4UZBKyNfwWOS3YT8XqBH0AWuTxfaug4t/bZG/lrKatjCjNMpr43 o=; X-IronPort-RemoteIP: 104.47.73.41 X-IronPort-MID: 90885529 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:WpQ7/aj+dSw5rgEWgAUF9+fNX161VhEKZh0ujC45NGQN5FlHY01je htvDDyBMq2DZ2b9LYoia9nnpB4D7Z+DyIRqTgJl+XtmEysb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmUpH1QMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWs0N8klgZmP6sT5QeDzyJ94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQBcA4AcwytrNuo5+68cdtuqdwSNenkadZ3VnFIlVk1DN4AaLWbH+DmwIEd2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilMqluS0WDbWUoXiqcF9t0CUv G/ZuU/+BQkXLoe3wjuZ6HO8wOTImEsXXapDTO3oq6Mw0TV/wEQ9Gh0na0K0isX6ixeRVtxtF 0ZP2WkH+P1aGEuDC4OVsweDiHyOswMYWtFQO/Yn8wzLwa3Riy6JC25BQjNfZdgOsM4tWSdsx lKPh8nuBzFkrPuSU3313qiQhSO/P24SN2BqTTMFSCMV7t+lp5s85i8jVf5mGa+xy9HwRzf5x mjWqDBk3+lKy8kWy6+84FbLxSq2oYTERRI04QORWX+56gR+Z8iuYInABUXn0Mus5b2xFjGp1 EXoUeDHhAzSJflhTBCwfdg= IronPort-HdrOrdr: A9a23:ko1WGK4XRbuPRHTvmQPXwAzXdLJyesId70hD6qkQc3Fom62j5q WTdZEgvyMc5wx/ZJhNo7690cq7MBHhHPxOgbX5VI3KNGXbUQOTR72KhrGSoAEIdReeygZcv5 0QCZSXCrfLfCVHZRCR2njFLz4iquP3j5xBnY3lvhNQpZkBUdAZ0+9+YDzrdXFedU19KrcSMo GT3cZDryrIQwVtUizqbkN1OdQqvrfw5evbXSI= X-IronPort-AV: E=Sophos;i="5.96,303,1665460800"; d="scan'208";a="90885529" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I7zJ96J4bufKwqxWhQmZFMYqEgbXCZjVxGzVwGpoNdNWIWmcHeT9id8UoLiY4SOdSowwaeSJ+C0A7OJ9b7ifO4hK/SXAhU0otJQoH5VY41p1xdRMsRgZujw2EBFJeqeKiI3tog6tY6Q9qvPuAe+uVU0sb62B3XPW40vQOFv6Oi1vw0nrmWn5CWAx4ZYDJlqg9SeC5Y4mePGxhmAa+qIyk+99p+fsau/A0Qpaim4VeY1O6u14ct++LwnQqHdsU/7luk8T24+vk/Wo9F07z2S3+lCInIB5GDzuPRw1ZD+EDnqfLoqc6+XK7UdrsArwBfvvwj4C2BqE/v/OizsR+5y7mQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NuV4HaD2bCln0Nm0zAO4yk9D+7lRmMaC1YSTGaUxamE=; b=fkt7Jmhe8FBzQHojwck8pTwVl+k5EmauAVr7a2Z6Efz0sP77L/m2dmHxd7xafYzRxm7xkgRDHuN25DayPQVMnFTfqezc4PytcJfqC/LbU0ScTQr6HpQGcj8oUziifFXq9lClx5l/c/zAhaFNaAhzZNXzCgEjBPFMVUhjN54RGdKFwk++Ev2QE4EtBNc2AorN3TTUJP4ofIJ1nM7BUGlVQFEpPpxoAW239HWAiOXMDFnRR9++4bsU30nyXyAVS12AX6mifmaLR+EkdRmb34hugJ+IIz3yap/tkiFsdLCFgcJqVB/IxOUDbnMVPpf4LfB1grpKtL3juy9Lw1b4xNYXlg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NuV4HaD2bCln0Nm0zAO4yk9D+7lRmMaC1YSTGaUxamE=; b=p+ruaNFaGd6vUFTnU+01rrprObMQ499tFa/M5t0NT1YUX+SfFiq6nmo8ADlkRtM/K3ViceuJoNrfwVkp/6LIM2WXAMibyY2imcrX12nIx21aAyL+9WlXvG4kdmWPqi6WMw9r+3ceM2M1jWwYb3kLM+eT6WGfQs8p0XdxZCE0IqM= From: Andrew Cooper To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Wei Liu , Roger Pau Monne , "Tim (Xen.org)" , George Dunlap Subject: Re: [PATCH 01/11] x86/shadow: replace sh_reset_l3_up_pointers() Thread-Topic: [PATCH 01/11] x86/shadow: replace sh_reset_l3_up_pointers() Thread-Index: AQHZIR6u/vHw4RYb/kGm/un2td4VGq6QkM0A Date: Fri, 6 Jan 2023 00:55:09 +0000 Message-ID: References: <074dc3bb-6057-4f61-d516-d0fe3551165c@suse.com> <03ae5a1a-4417-0aa0-27d8-833ade20cc0b@suse.com> In-Reply-To: <03ae5a1a-4417-0aa0-27d8-833ade20cc0b@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|CH2PR03MB5191:EE_ x-ms-office365-filtering-correlation-id: 19a9adfd-73b3-4b6b-4cd3-08daef80a8e6 x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IJj+nX1eunCDjNIy1QL+QUTJxVZGauey08tbp+kzR1HImsNqe1Q1R9f7k5ADqA918d6tgcE2A9gkZP0tQtw5fNCKrMxrdck73u+ZGph+8Cn9++3/DbPQOG2h4bwyG7uuMJobSC+ZdDtF6w91jvgtcJPDrRLYDvmLPjlsHXXdupqtp44ICGEmUVsW3P1BiedHkiJICFFrI++Jo2L46nSPFyGR0WgD5oDWNZ5MYIYMu0WDdkhisbTKbTBLvnhwyBN6CO3Hrvu6dBv1qYUKYGBI65SE3F8l6Wi/DuZGbL5yL1I70JwXf7F8s0zfQLtgxTW1exSfoExGbm5KIgZirmcoi7q1h2nfmxCtBlBHh+VK7+1B5P2g5vo5Ms9olwO7fki2GJ1codkVXvtXer4FWHJtQwbpLYDmp3+Kfe29Ni+FnBNVJxWN4ZY+Fw6lC2/q9Kpbg93EdR9Y3mkr+2MlNs58SfWamZrR0+S0oZPTx6ICdY0N+HfHVjwVxeJVJbOv9SllKvWqmQAVjCOFQscvI5eLbI6xnWkYGdUiDnoGn00GvB0g2BitrswYMtoOJgVdHrmIDK2TWyrgv5X6pROpuxGntt/j7RkxIliwpc4bc9lVbgAoDKzgfHWs7syYJ/+iQ/r2vTrNtY0BJA5zsM/ofo3IRpNmhpM2Zn5ojyakvio1UnWXVUK8F1JhbX72eBrVYFbCXqrffzEtG1sMh1hsWjr02nW8t1U12fASm0y+pSSRd2zn7yI9aopoD8ArNVwE63XETVknFi643dKewJbdwaZwJQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(366004)(346002)(136003)(376002)(396003)(451199015)(83380400001)(6512007)(26005)(107886003)(6506007)(38070700005)(86362001)(36756003)(31696002)(122000001)(186003)(82960400001)(53546011)(38100700002)(2616005)(316002)(4326008)(478600001)(41300700001)(8676002)(4744005)(2906002)(5660300002)(8936002)(71200400001)(31686004)(6486002)(76116006)(66476007)(66556008)(66946007)(91956017)(54906003)(66446008)(110136005)(64756008)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NTdaN1RKZGRraXpUSnVjWFF1SlVlN2kzZ1NyV2tMNWJHdWF1WXBvUnN0cER1?= =?utf-8?B?bGwwMitNM1pud3VzYU9XMENBNzVheTkvRlRlSnV1alhpa09yZ3VITkpBUitK?= =?utf-8?B?WGRERThDdUg5K1lJb2VpRnUwTzgzT2hDYk9VaWtaVGM1VjBnRHhNME9yYTFR?= =?utf-8?B?ZE8rZS9jN29QQ0cvWXBMazEwWHFXUzFqQ08yakd0MngxMlNxbURzNUR3Yk9q?= =?utf-8?B?RndraXpCeFF3dU9za0Rjajh1d2EwYVhqTWdjSmFRMkYvOXJaR2o3WmFOdXNt?= =?utf-8?B?aXM4azVyV3VjNVU5cEpxTm1YeG5vZlNFNk5hV1MzcktPQVpmU0srdFFWdy94?= =?utf-8?B?NWRCMENsVTRYZ2ZwQnJ6aGZSaHNvV2FvVDNtaVlNb1ovVllUekVPSWt6VGxk?= =?utf-8?B?OFh3VzRNRDN4aWFVcUQzcFZtd29UZXVpaGd0dW5XNFplKy9pQXFWelBQaTdl?= =?utf-8?B?NThUV09XQkUwdFl0bUdBL2RkRFdOU2UyN1V1aS9jQ1lEd2VyWnpFTUdpbC9O?= =?utf-8?B?RUh0aUYxSkFPUHEzTno2UUhlQUtUTVNzcTJoMFhMTllzWlpPak82bHgyTVdv?= =?utf-8?B?VTEzWGxjQkozdGovd1ZZUXhnZUJldy9vang1QWVkbE5vNVZDdWIzS1hiMVo0?= =?utf-8?B?bWZ0dkJJaE1JM0RpdTVtVzRSamVFMUpEcVJDenEyRnVucWt5dWd6aGxXVGdQ?= =?utf-8?B?NzNFZW41ZUxWUGlIWTRQOGZTZFlaOWZjdUxEUERHS0NxcTVXVXhyZVdza3Q4?= =?utf-8?B?ZnB0SjJEWTB2TGFnQ21xM0h1ZEZGK0g3dDVwd3VwMHRHK3RsaXNpa2hZWmwx?= =?utf-8?B?SXdTZWc1ZG5ySCt0cGh3UURodGh5TWRyOUsyM2NPN3I0ZEt1Z1BFWVJXY01Q?= =?utf-8?B?L3JXMmFRUkZLYWh6ZjgxZ2dNQjkvV3REdnl6Z1VucTdjQTBtSUVWVHdCTkVo?= =?utf-8?B?aHNpZXNUWUlOZ0pYQ2xRa3IrL3ZuNk9LWVdEL2Uzd2lIaWh1STAyVWdsWDRh?= =?utf-8?B?NXVPWk4wU2RMN3RUbjRmc0tlQ1NsaGV3S1VRb2liSkVVbVlENHUrZ2tna05H?= =?utf-8?B?cEtzZ1R3a2xySXRka3ZXV2t6RmxUQXVCd2ZqV2lQVGlJMkcrcU44aU5IUE93?= =?utf-8?B?ZEFFR3VUWDhUN1MwZTQ4OUd6K29vN3c1SGdUT3BxZVVGOHJ0bzVVYUVmVUlm?= =?utf-8?B?VkxjeFhPeUlDNVZORE4vTURBV3dTNmtkZWNIQmJYd0ovVXlzNWVRU1Q1Vnov?= =?utf-8?B?a3hpaXNaZXNFR0xJTUYxZlpFbmpXMmdibE9JUVZubGlLRzRNUWUwQ3JJMFJq?= =?utf-8?B?OFo1bnlYSkVpcHJrK3p2bWZZazZjbm1ZTG9acHpLVVJYVEx6Z0Q1TWZiOHEx?= =?utf-8?B?Nnk4b1luakduZzdHM05sdFBUSGE2dWlUbHJOMG5JaGxjWUhENTJOcnZ1YVVh?= =?utf-8?B?MWcwUTNuWFdmd0VtZUljd2dVa21vMmhDQW83ZXV5YXlmelBNK3dNWTdORER4?= =?utf-8?B?b0owWTIydk0yK3ZaQVBvcUV0VG42RW50amtBWDZ6ME8wcWFYd0VNcWF2RmdL?= =?utf-8?B?ZmV1QXpiR1ZuY25QWXZGQjVTdFlHbUxyY1ZVaXNxMTF4QmhVSHprNkZMZVVx?= =?utf-8?B?bnBwSDBleGp5cTdIY2RUeVR1MmE4QjhaQU1NUUhBUEJYa0xsNXZWSTFpQ2Zm?= =?utf-8?B?dXNIZ2Zmc1Y2TU1USjZuOFJvSE5MdVJNdnp5cmo4OG8vdjNKTm1rdnRjenRL?= =?utf-8?B?dElGSEcyOTJkZGd0SmJibHZNTDhCaGNLd3hhbEJaMmd6Y0sxK0NwRGZsQkxT?= =?utf-8?B?Ri9FSFJOL3BtY0FEaTdxaTZIN0FIdXdURGxUUlFvbzk3V2F1Z2hlZ2ptKzMx?= =?utf-8?B?Z2VkQng1ckl1WFNwOGxYa1VyR25aczVjMFdPYjlvcDE3cmZqUS9zSWc4M1hL?= =?utf-8?B?ZWMzRzJDZnRKbVhYL2ZqMXBHdW5jU1l3MmY3VWR1ZFRCdnZ0aTBpRFNmNmZn?= =?utf-8?B?U2NYWWM5QkEzdHZIbXpFUlhzU2NvYmVDRFpjaUswY1R6SGpHS1pCN0hhbWFv?= =?utf-8?B?d25kanErNzl3NGNGL0gxUU5YYmZzZ294Ni93TklhTnpNNElHZDJkRzJpZWFn?= =?utf-8?Q?gpdSwKXPZ2ub1n/ez84Y2o/+z?= Content-Type: text/plain; charset="utf-8" Content-ID: <46AE5BC851407045A5EA2D1E706E1809@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 49FpFA4vQox+TsqtH3wz2XDrcKy8/sCvDID/U4MQ2f+E6UG95e29N3zD/wz1aHATYQIG1gQaaXceU+yEpnM4wHNiv8s2Hr5c1kMOu+MP37RrFYlO3eyzXMgDu2YVxyGlyR/vWMdj7JvuN74WKW77vq2A2A/43Y5kTj3DWtdDtnpkyvca8tITspKpPF9yOENeaH+NfoqCEArIXTD/SwFgTDHMyBoncTeFwg2XUOmIbYDWQcNPfOOSbVzOf5xVPry35LPTjjgxEvHyheNAZiZY0c3MORrGPnzgBYEMWF2shevwuJFB4MNql2KBthUVwGjLKuZAO0QEVGre76gP+BtPxDcsIC1/2vMzs7CtLqOMRyL0L9fwmNt5sn/wqIyyZSKuwdaZaV2CqzR+Q+BnqSmeOQq2wyW3t8KtG5Wjs18V5esGyPO3WfUNoEz4nRFS94NkFt+KxR4Yxx3OKlQwbMADm4riDn818n08XUyd0iK+6+2v02GDkF8NdCvHr45tWRCAG0FAcGYpD4s5BO0k78Yihw4VCN13KZWxQtYRnJ36uoD7B1HYhudTZLrZ5HNnceXCUbo8ahydgmjfylqQBSjAwJKewsFcqyWROPeHeQJiqvXBnpX52/g0Hi2rHhlXU6RF2v8W+X4buzHstww+ljMnXeGBh0G9ZQ6uTwL6ziwo43SMVRzU2ZHeAGV8Wb2+W6TmIDCGI5FjMqiJXV0k7IhC+IlcUKgWrAjnvjFsoQ+2Fw7FkREfblYtMUurkzp7pxdjZEnEgWX1UgBa/dNGb1v/ztJIitBCowpEWcRsNv7I1X9hGKuUorcvGYEeBg5gtUGBsjJch9BVz7eQrJBmO5bx9w== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 19a9adfd-73b3-4b6b-4cd3-08daef80a8e6 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jan 2023 00:55:09.4551 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ss3eMvwswg/O91i+peOhWmidkxXVm3kGbBQhMaViI6AN5YBvWzss1WnbY95FrOZAHfT5W1yLy8bFbqD+dTLumhSdFoU4TKCza3uvjX2qdxk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR03MB5191 T24gMDUvMDEvMjAyMyAzOjU5IHBtLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gUmF0aGVyIHRoYW4g ZG9pbmcgYSBzZXBhcmF0ZSBoYXNoIHdhbGsgKGFuZCB0aGVuIGV2ZW4gdXNpbmcgdGhlIHZDUFUN Cj4gdmFyaWFudCwgd2hpY2ggaXMgdG8gZ28gYXdheSksIGRvIHRoZSB1cC1wb2ludGVyLWNsZWFy aW5nIHJpZ2h0IGluDQo+IHNoX3VucGluKCksIGFzIGFuIGFsdGVybmF0aXZlIHRvIHRoZSAobm93 IGZ1cnRoZXIgbGltaXRlZCkgZW5saXN0aW5nIG9uDQo+IGEgImZyZWUgZmxvYXRpbmciIGxpc3Qg ZnJhZ21lbnQuIFRoaXMgdXRpbGl6ZXMgdGhlIGZhY3QgdGhhdCBzdWNoIGxpc3QNCj4gZnJhZ21l bnRzIGFyZSB0cmF2ZXJzZWQgb25seSBmb3IgbXVsdGktcGFnZSBzaGFkb3dzIChpbiBzaGFkb3df ZnJlZSgpKS4NCj4gRnVydGhlcm1vcmUgc2hfdGVybWluYXRlX2xpc3QoKSBpcyBhIHNhZmUgZ3Vh cmQgb25seSBhbnl3YXksIHdoaWNoIGlzbid0DQo+IGluIHVzZSBpbiB0aGUgY29tbW9uIGNhc2Ug KGl0IGFjdHVhbGx5IGRvZXMgYW55dGhpbmcgb25seSBmb3IgQklHTUVNDQo+IGNvbmZpZ3VyYXRp b25zKS4NCj4NCj4gU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29t Pg0KDQpBY2tlZC1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4N Cg0KSSB0aGluay7CoCBUaGUgcmVhc29uaW5nIHNlZW1zIHBsYXVzaWJsZSwgYnV0IGl0IHdvdWxk IHByb2JhYmx5IGJlbmVmaXQNCmZyb20gc29tZW9uZSBlbHNlIGRvdWJsZSBjaGVja2luZy4NCg== From xen-devel-bounces@lists.xenproject.org Fri Jan 06 01:00:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 01:00:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472235.732387 (Exim 4.92) (envelope-from ) id 1pDb6M-0005fE-14; Fri, 06 Jan 2023 01:00:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472235.732387; Fri, 06 Jan 2023 01:00:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDb6L-0005eI-UO; Fri, 06 Jan 2023 01:00:53 +0000 Received: by outflank-mailman (input) for mailman id 472235; Fri, 06 Jan 2023 01:00:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDb6L-00058x-71 for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 01:00:53 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8f088e50-8d5d-11ed-b8d0-410ff93cb8f0; Fri, 06 Jan 2023 02:00:50 +0100 (CET) Received: from mail-bn7nam10lp2104.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.104]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 05 Jan 2023 20:00:47 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CH2PR03MB5191.namprd03.prod.outlook.com (2603:10b6:610:93::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Fri, 6 Jan 2023 01:00:45 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5944.019; Fri, 6 Jan 2023 01:00:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8f088e50-8d5d-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1672966850; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=7R5caMStUTAOv6xs/IolzeChzCMqWnsnP5dG+yqWnRY=; b=AXzwh3cWaZFbKUeg7k6lVc1GH74tuZcRyaFycI0GIqT5Fif9e/0H/Yw0 y9vtrjaHMtU26/HosfTMi7Kms7UAuBOH3W2q14UXzfDn3lJLiRUOkCquH xpaDvFD7Bb3XGRvifQ908KUaXNL/1MOfwzDE/O7ZZyQx3RVnmQVktAjCl k=; X-IronPort-RemoteIP: 104.47.70.104 X-IronPort-MID: 91441917 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:ze01W66kd+ezYDiZXq7GbQxRtAnGchMFZxGqfqrLsTDasY5as4F+v mYeCDuGPauNYjPyft1xPtmw/RhTscOGyoBlQQo+rS00Hi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraBYnoqLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+4pwehBtC5gZlPakT4QeF/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5mz s0xBz4XVTC6vM2x/LTiVcZBqc4JBZy+VG8fkikIITDxK98DGMiGaYOVoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6MlEooiOSF3Nn9I7RmQe18mEqCq 32A1GP+GhwAb/SUyCaf82LqjejK9c/+cNNLSOHhp6c16LGV7m8iBgRIBXz8m77nq3KGY89bB kgQ+QN7+MDe82TuFLERRSaQonSJoxodUNp4CPAh5UeGza+8yxaUAC0IQyBMbPQitdQqXno62 1mRhdTrCDdz9rqPRhq16bO8vT60fy8PIgcqeS4BZRsI5Z/kuo5bs/7UZtNqEarwhNuqHzj1m miOtHJn3+lVitMX3aKm+1yBmyirupXCUg8y4EPQQ36h6QR6IoWiYuRE9GTm0BqJF67BJnHpg ZTOs5H2ADwmZX1VqBGwfQ== IronPort-HdrOrdr: A9a23:WkNGP6s3DjLwdJm1/91fD+sa7skDgNV00zEX/kB9WHVpm6yj+v xGUs566faUskd2ZJhEo7q90ca7Lk80maQa3WBVB8bBYOCEghrOEGgB1/qA/9SIIUSXmtK1l5 0QFpSWYOeaMbEQt7ef3ODXKbcdKNnsytHWuQ/dpU0dMz2DvctbnnZE4gXwKDwHeOFfb6BJba Z1fqB81kedkXJ8VLXCOlA1G9Ltivfsj5zcbRsPF3ccmXWzZWPB0s+AL/CAtC1uKQ9y/Q== X-IronPort-AV: E=Sophos;i="5.96,303,1665460800"; d="scan'208";a="91441917" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KGzl9qiPkUbUV4gsp02fCM4xZS9Nlqw88rI49597S3lBd3Lg5EK1fzu3YegUHa/8gJktu5lO2bksRCl6tm3LZc3sxGqnBSSE+vqQbliu9qLHsh54zFodQjNLrYNSssbD9D7qSynm4kp+2z3wD4ShChwjEPjZuR+e4BlE6z2G6JQsGHH+tWA4wBMCVJGM/UGfzGVvLG5iRRMArkUXseHCN7c1XTcFs9HcBBe7bSMlgV/uxx9NJ/pz5DBXScMpPOSMXGqDf5c2amE/K8RFzDuoULEdHOjbwJ09Jx3GQDQ02HbWgtFFtLi7eCqmP/kV2mnGn2VZxaamQa8gJ6x3OANNfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7R5caMStUTAOv6xs/IolzeChzCMqWnsnP5dG+yqWnRY=; b=dI8Xo5bm2EGFKGt8yPfsMMJB/UGEjOCOzNGwSnMYyPORa4zyqFFHz3T0sJnWbAGjx0xGaYgc93OMxZx1ehg4k089ZlZz0NJ2kYESvIvIEZP8Eiode7FEz7YNWBaxveE5ZdhA8a66BBW8egJxjUTaW9t9Ui2XWgPMLDFmGx2c9tsc7wiMrc/MdHtNquamLnETG+UKFcwMtSZ6c2NkPApgsJjnLDJOVKpqSq4x+CCCj9B9NTOGujLzF0ef5u8XV5vrmxzt8ec0SdI6G40k2GOP/V7iCqodNpvK9DsesbsR6bTdKcuNAlSZTKbuDUJbcUBbSMJbie5KwSL1hDmACzIodg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7R5caMStUTAOv6xs/IolzeChzCMqWnsnP5dG+yqWnRY=; b=UndqmyDVTo7AbT6A85r1bWNTpjnhCzpSqVLfurhIPdX7h8cXXyz9jrBcEXL06OCyDh3dh3S5vc/3CcM+GvM/thcIoyqn+2qqI4GTE5Wh2Z7y/L8XrTR6UsmZQBWsh9ojfN298i/ePevj1pacosBEBCEOHGU37zrtOIW7mu86Hpw= From: Andrew Cooper To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Wei Liu , Roger Pau Monne , "Tim (Xen.org)" , George Dunlap Subject: Re: [PATCH 05/11] x86/shadow: move bogus HVM checks in sh_pagetable_dying() Thread-Topic: [PATCH 05/11] x86/shadow: move bogus HVM checks in sh_pagetable_dying() Thread-Index: AQHZIR9eJqf2NVsSC0qgmrUFbi0j7K6QklwA Date: Fri, 6 Jan 2023 01:00:44 +0000 Message-ID: <37bfe65b-d989-7c34-5e14-171a23df37f8@citrix.com> References: <074dc3bb-6057-4f61-d516-d0fe3551165c@suse.com> <76cc0b4a-27ca-21b7-841f-315f31833762@suse.com> In-Reply-To: <76cc0b4a-27ca-21b7-841f-315f31833762@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|CH2PR03MB5191:EE_ x-ms-office365-filtering-correlation-id: 875d8298-c7f6-4c92-727a-08daef8170d9 x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6NuPmKg82/S8Q4P+kltjf/Teo2AJgJCNabqDBG/x6u2bgmU0TJpcGB3YRmso4Skj5KaflbpmPerk5EJ3QL4Dj+3yXEd3r6/uBlSS9CD5KSrcMo0evkXbmZUSlbNCsaCeBKWx5n1ljqW6QjLDIejO22LZWKHvS86DoFT0x+6EYAVFE08qFz/DSztgNNVOQZNcsDJvlgSM2bqNJANd5CpgtrGs1Uk25sKGj/yPWBtel3m5oPSykPHgLQBPzNFhJ0MUqrrjqrSYg3aSyeBlHHdLwGLN3gY1MV19/JcUFrW23EMTjfBcLSvAdHV30Y3eaBFRNtA70zMk964UQU9mVIDoEtG2DHxKujKOeJUIqOQMNVynrmce52BqswRKmxmdHCrmBp+BMkDLHd3ZME3VZp+bd5mEMTyzvwWE+rsZR+LVD03RsIsfWU3Rj9m7ivsUAcdiUenEi9oNXVWO8BzgjkN39yfXSdmKj2eUuPfl8rcujROPF79pv9jAdHd9hiJ3G9FOMBBU8sv9Bi9rcgNzfoRJuxQAN5qhe1+InDHJI4hGajKwCTrgkunMuJp2XRWLSzdApiL+WNEGczxqomM0J+BTefpctdw63xdIrL2juaZoaZreDY4gYYGyVmpaRkFBrus0ka+0ttgiVZ/sOXFN5ez0nyT67ZHY4N5PsHO73rnPOHkBeDmwY86EPnzFEVlJJe6Qm0FQBO6M2xloZEVKvMvEd9NrIQ/IpxnINASwf/ZKDRunBbp2w35bbcLYwLnG05lsQLYXiLke4RsG9VidPESvpg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(366004)(346002)(136003)(376002)(396003)(451199015)(83380400001)(6512007)(26005)(107886003)(6506007)(38070700005)(86362001)(36756003)(31696002)(122000001)(186003)(82960400001)(53546011)(38100700002)(2616005)(316002)(4326008)(478600001)(41300700001)(8676002)(4744005)(2906002)(5660300002)(8936002)(71200400001)(31686004)(6486002)(76116006)(66476007)(66556008)(66946007)(91956017)(54906003)(66446008)(110136005)(64756008)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?cUdzNnBSM2ZKYXZHRSsyMnlkM0dJS01WUkMxMTdLR3ZId24rbm5ja2d2bzdC?= =?utf-8?B?S04xbHFKTUtPN2dCNkhiQkJpNjZjWkdBaENxdDVzWXZqdnl5a01WcU10dDAv?= =?utf-8?B?WWwra0NmeW81bGhWOXA1OWVndzlGWG5mNGFNc2QxVVhzUUZ6ZnpIaUczaDc0?= =?utf-8?B?aW4xZ09UQUZBc0VYZno1WGZUR3dkUHZvNWlyUzBWWGc2MjB0eVdtNEFxNmx2?= =?utf-8?B?UFlMQU1venphSkpyOXYvbFdqbmVieExidVY3K1ZIZEVHYUZzeU9hREgwOXpy?= =?utf-8?B?ZUhad1VRdnc1cHUySFk0ZVcxRVF1bkt6L2k5aDFKMnBNVmZvSVRCaWhBTkhB?= =?utf-8?B?QnNIZGJNMkw1NmxudWlneTduN3R0OUo0Z2c0T2UwcmIrMElOYldQR2llWVBP?= =?utf-8?B?aDl5eDFST3ZBakdBWXhoY2xTWitTVkdhNkNUM2NQZjJWS05uMFNSZStSbFcv?= =?utf-8?B?VlFpR0Y0Z29keitSWGJkR2dLVE5EejJxZXdrVjdGR1hhaHRBVmdtMkQ3Viti?= =?utf-8?B?M2s2dUhoWlQxYTNmYVkrNXRvdCtMSVBnZENBZEtHaFVGcVRpVkNQaVo4YWJu?= =?utf-8?B?MXRRMXBFaU02ZkVBeS9hT3VnTG9acjZxSVY2emR1a2FtY3QvaVYyTTdocHND?= =?utf-8?B?dUdGNjhhRGl0R0VYU0pWVEwzK3JOZG03TnFSQjFsZWdBbC9PNXlnMXZQUUlV?= =?utf-8?B?ME9CNTh5clpNNzBEdXE1Snpjbk9sTEE1SE9aTURTNmF0L1h2WHFZdER1VUND?= =?utf-8?B?eFVnUnlWNTRqUlNsQkZySzdYVXAvRGg2bTNST0lFQStkUWhHWFluWmRqSkcr?= =?utf-8?B?dW5rZmxpeEhhZzZOTjF4ZEtYZUJQckF0eERrY2ZFN0FPd25INzRINTdNeXli?= =?utf-8?B?T1N4VzV3ak9acUJMUnpiOEFDZXZGQ281NHNxMVdQWUdXdzdDSE1qQVVFMDBS?= =?utf-8?B?OUR6NlRuMnBEZmFLNEtLU1o1RUNQY2lPMFJXc21sVFhRay9ic3dDT1NDTnhW?= =?utf-8?B?TXpINXZvWlBLUGpVY2J1MkZveGQzVFdXRGRWVXl0eE9CTUdFTjNHL0VGMldI?= =?utf-8?B?VVVqdUxKeXBQNWlVbzg3d3Urb056Y1hFZmswUWo2NUI4NXp0b0lmRUo0SGNP?= =?utf-8?B?YXRzalQvaHJ4NW1xUFNRMEhiNEZaTTFkVlY5ZFJCQTJxZk1WanEwYzk3N1pX?= =?utf-8?B?WjVNT1I5QTFzQU9DSVlHVTFIWlFYZjRLMUN3eG94bThLQ3pDdU8vVVR6MDlD?= =?utf-8?B?czU4QzJBckc4a3RRMHQxbkNGQlhhc1JkN0tUaFhnL1E0RzBHYjgzUkVVUTlW?= =?utf-8?B?YUhqUkR0cDZOekZOanFYcElKM1IzdVNTaGgrQW4zK0dxeEd5eFBVVTk3TnMx?= =?utf-8?B?VEVRTkROM2Y5aWNPRG9OQmlmQkY1eGFNQzgxSG05bFF2TXdGb1o3ZHZBMWJR?= =?utf-8?B?aXd2cXdoQTZZMEFKZEx6Yjk0b2NOYUcwc0NmR3BiNzl4R3VCYmdyWUl2ampt?= =?utf-8?B?SnNEdlEzaWhSNVhEUENQUFZBVkVyaFdzQUtOZEpSUWMxcnd5WjI1dFRyRnpT?= =?utf-8?B?QWQyWHZ4TDVsL01hdkI4QTRqeURGTFFpVElLeHVNNDJpU0RGM3R0K2NBc0Zo?= =?utf-8?B?d1haK2hiWmJzNDUzTEhmb2VMdytwME4zRWtiZjVndTNYZXpPMldPZmYydjFI?= =?utf-8?B?RWMxaUltNGtTRkgvN0hyYWcrM1dKRnJQdHlsUTg3YnYxSnFBeXE4WStMMHQz?= =?utf-8?B?bkZxcUU5eE84c2dRbVhpdnBpWmcwLzRteWd6NTZadDNuK2ZiVUxqU2lWN3ZG?= =?utf-8?B?bmNVdkNCLzRLQkM0OGdadDVvVUg1MC9seVhQQWMrZi9nelh4UmtUSjFIOUVV?= =?utf-8?B?Um9CcURjY29raThtSjQrRFcwWkVLQmxLQ3FXMUp1VXh0MVB6Mi9LMDlQTngr?= =?utf-8?B?QjdlWXZWZndpNkxVOEFCcUlZZ0RpYnR6R3grN0VabWdmMTE3VUFSTDkwSTBv?= =?utf-8?B?emVVNnFUZlQyalR1ejFNMkxFSmd0MnR2VXBaeWlMVllqcVp2SXRQNGJ2SWpl?= =?utf-8?B?QlBocmJyc2x6TkEwaUtGSVBGOVZPQ2ozZDk0aXZZOURUYzNtOVFiVkY4R2ZD?= =?utf-8?Q?vqSGp5qhMwZeHtZ8+cmGbj5Ks?= Content-Type: text/plain; charset="utf-8" Content-ID: <1BF7B6676F02A54E8C464CE41FF9C8A4@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: +CYBpSjTgnwIA2FDTgwFuhPgUn2gitImkxRvVJLj+4UD9WlL0bIMjBn7iKAiUHlLjlvHDEYjabyQ6651tmYJDQN6d5buVJcgNUJbYEu+OshwQkQdMlf4xu+CQC1gu1vDQpdeT8GZmRjGzhPcEUwhtQAerN+xfsiM2zo6f/aI2BN5uiqg3SX2MstG4/f0DeI4hKyGpbt0wwTxMuAcnVQf30yNolyHnlwb8b6yrUy6tbiH50LthRl/tt6LotelJMCcDLv38Za+avmBQ+KNv+OBCE+nsIO3hsuNdpHzNMYI+yt/6Zz2KGkXMwsjYkF0fYV8KMtXvX4haB/NhR7zTBhcDnkvwwUo0O8mzdz2AmUKOLF/EYUPiC/5hV5UfHs5efg9eR04J2UHdPGqtE3Q75E15TkrKq6VWi+gtpekspee/ivagtLsyVFsyfz80iB94FFnfK5SkfzLJCvUkHrMelI4cNPq8llqYNXbwupKkROw88NJl4iqAdi2rbSG9nGMyPWsG/2yZRqpfc425/KYjwY5jmFOfiiJ6W9aKZb3Xl0J0R2la9m6ZgGLNeBBgoRgexIvYSRqjpJ/sdK7tFIJIkaX2yfg9vBp0vM1j0FqjdiLAPRTRi2O0S2sHoly3utG+I/vgv6+oOfNWaDWe5uRyTfDQtR1UPmeFqmVFeOlBLhk/Ln05jAQDprL/nRWjidy+2aKvVyo2j+7j4S47P8O4H/nAc3/UuDy9Gjw2yp1Zh5yQgwNZnX12KmVxb+piNXuULbQFJGYRNIR31oJKH7Gqu1+Gpc4mXjjdtYGjQulULk8M4i8FRfO1MFdUgCyPUwYLcvN+ZEvZGJzpIjKHxjNgAjRLQ== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 875d8298-c7f6-4c92-727a-08daef8170d9 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jan 2023 01:00:44.9308 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hjtYzlm4f5VuXWYdXqQ9HAt1A1cMPZ4nDu4LhjrM2Y/PMNi8lkr+J7nDXQkxx5T/XBondEPSaBFRbRkBs9GVe6WjvwHMsn7ZuNEB/iF65OM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR03MB5191 T24gMDUvMDEvMjAyMyA0OjA0IHBtLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gUGVyaGFwcyB0aGVz ZSBzaG91bGQgaGF2ZSBiZWVuIGRyb3BwZWQgcmlnaHQgaW4gMmZiMmRlZTFhYzYyICgieDg2L21t Og0KPiBwYWdldGFibGVfZHlpbmcoKSBpcyBIVk0tb25seSIpLiBDb252ZXJ0IGJvdGggdG8gYXNz ZXJ0aW9ucywgbm90aW5nIHRoYXQNCj4gaW4gcGFydGljdWxhciB0aGUgb25lIGluIHRoZSAzLWxl dmVsIHZhcmlhbnQgb2YgdGhlIGZ1bmN0aW9uIGNvbWVzIHRvbw0KDQoiY2FtZSB0b28gbGF0ZSI/ DQoNCkl0IGRvZXNuJ3QgYW55IG1vcmUgd2l0aCB0aGlzIGNoYW5nZSBpbiBwbGFjZS4NCg0KPiBs YXRlIGFueXdheSAtIGZpcnN0IHRoaW5nIHRoZXJlIHdlIGFjY2VzcyB0aGUgSFZNIHBhcnQgb2Yg YSB1bmlvbi4NCj4NCj4gU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2Uu Y29tPg0KDQpBY2tlZC1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4NCg== From xen-devel-bounces@lists.xenproject.org Fri Jan 06 01:02:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 01:02:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472242.732398 (Exim 4.92) (envelope-from ) id 1pDb8H-0005Ep-CX; Fri, 06 Jan 2023 01:02:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472242.732398; Fri, 06 Jan 2023 01:02:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDb8H-0005Ei-9l; Fri, 06 Jan 2023 01:02:53 +0000 Received: by outflank-mailman (input) for mailman id 472242; Fri, 06 Jan 2023 01:02:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDb8G-0005Ec-LL for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 01:02:52 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d71c3705-8d5d-11ed-91b6-6bf2151ebd3b; Fri, 06 Jan 2023 02:02:51 +0100 (CET) Received: from mail-sn1nam02lp2047.outbound.protection.outlook.com (HELO NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.57.47]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 05 Jan 2023 20:02:48 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DM4PR03MB6912.namprd03.prod.outlook.com (2603:10b6:8:47::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Fri, 6 Jan 2023 01:02:47 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5944.019; Fri, 6 Jan 2023 01:02:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d71c3705-8d5d-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1672966971; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=5Yu4XtuSxJDYHI1Yk6SQYnBFkmruKjaDT1sYhAHD+tw=; b=TWdKUaAPVj2hnfxTfO7x6dOzTh8e5K7iX5wAnYNhrKx4l7gn3RnLXUI1 s6X6nX9D8lEmsDdCxerxJdkX6eSxUxIl5mhqOUSYkl6LSW5xbMT2ZTxBH eU988D4YDvk0d6lKTIGhG/O4HKfCobF+yjHjYnqe1QyM9BBEstVtEBYM9 g=; X-IronPort-RemoteIP: 104.47.57.47 X-IronPort-MID: 90886482 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:nGqCOqPWjlD5Y0fvrR2TlsFynXyQoLVcMsEvi/4bfWQNrUoq1jIDz jEcX2yPOvqCZ2Smf9l+bYzko0IAucDQxtNnHQto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQA+KmU4YoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvzrRC9H5qyo42tB5gFmPpingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0qEsIjse5 OVGEgs2SzSjv+adzJC7deY506zPLOGzVG8ekldJ6GmDSM0AGNXESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+PVxvze7IA9ZidABNPL8fNCQSNoTtUGfv m/cpEzyAw0ANczZwj2Amp6prr6XzXOlBNJIfFG+3uFAjEWtzGEpMQAXD2CC/aOhrheuat0Kf iT4/QJr98De7neDTNPwQhm5q36spQMHVpxbFOhSwBGAzO/Y7hiUAkAATyVdc5o2uckuXzso2 1SV2dTzClRHr7m9WX+bsLCOoluaJSkQBX8PY2kDVwRt3jX4iIQ6jxaKVdA6Fqew1ofxAWuon 2/MqzUijbIOi8JNz7+84V3MnzOroN7OUxIx4QLUGGmi62uVebKYWmBh0nCDhd4oEWpTZgDpU KQs8yRG0N0zMA== IronPort-HdrOrdr: A9a23:e81QRKCRz+yKL5zlHela55DYdb4zR+YMi2TDt3oddfWaSKylfq GV7ZImPHrP4gr5N0tOpTntAse9qDbnhPxICOoqTNCftWvdyQiVxehZhOOP/9SjIVyaygc078 xdmsNFebnN5DZB7PoT4GODYqkdKNvsytHXuQ8JpU0dPD2DaMtbnndE4h7wKDwOeOHfb6BJaa Z14KB81kKdUEVSVOuXLF8fUdPOotXa/aiWHSLvV3YcmXKzZSrD0s+BLySl X-IronPort-AV: E=Sophos;i="5.96,303,1665460800"; d="scan'208";a="90886482" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oQdCJvLwx8V+iSvT6xKYjaGt9hayxUiVII1fyeMf0xzj6i1bC3+6fEbAdXU05dgTBw9zNYrYWi6kQhJyJ2EiH7JKEzaQf5es89Ja6MKC+Z3WXSlJUcrgDCuwllFW1ucHvOCeu/KAokSmSSbp/N/fOakWivKyPvjBGeNO6QaPUp87zwQv7OlDHzusxqfKLz3+tkNCBkyc+rW7qTuAbnApW0QGmb3HQIMW6XEUQSBcBHgf3rx/i8bmhDmqscoAUOrCncSO7XsnySSm1ufh/HRJuBD7/neRNU4VFFbyIfOJfGHIEZM4JUSW4TUzv2c2D6Kq0lw32boKlCJIoxFOwCkOzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5Yu4XtuSxJDYHI1Yk6SQYnBFkmruKjaDT1sYhAHD+tw=; b=mTx9e2jxWwsi7stqfON1C/pbusLE5690cs3WSz2PoZH8dowHYw/G4JlyiAKWcvJTYrLcULo+TKi218q5hWxAP4c9k1RciZO6r/lxhY1M8AFox6RUQ+kyO5A4bB02Sr2mEGv+q+EyGzDbO8LTRWWjZ1mzklEMRz7pS4Lp93hIzGxxCwMulqwVfKYQrXBlEtS9wbpMr9iwR89snzw9eN7eN9ecE7Q39vssSVrTZtSbvgqpmRV1OUf4ixHFnAX1f/i1RcXO2tmu9OkclJLotSiNnM6l/9N9R7c+c3TvgdPLkBtbCL0phFQStkw+LdPJiP0+irh+eGgn8uyVmpKOOv28Jw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5Yu4XtuSxJDYHI1Yk6SQYnBFkmruKjaDT1sYhAHD+tw=; b=OvzRuH5q/Sl6dpvc+CSI43yAb7OLazUIu9YFtmOBP7V488uhYzkCvyobb9Wos9flI0Jb6zBjxBqvxIR6ZOGxAd25glBjcPskC99s8gsFV/Gfiz3NqBdZYfX9dwmy6fLobHbO1RWeRZgxb/dR84I6yMg2plaoF6Qnbglw+32jP0E= From: Andrew Cooper To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Wei Liu , Roger Pau Monne , "Tim (Xen.org)" , George Dunlap Subject: Re: [PATCH 06/11] x86/shadow: drop a few uses of mfn_valid() Thread-Topic: [PATCH 06/11] x86/shadow: drop a few uses of mfn_valid() Thread-Index: AQHZIR9umeBFnTREcUub2eAZa8aRda6Qku4A Date: Fri, 6 Jan 2023 01:02:47 +0000 Message-ID: <11758833-fb7a-f937-a847-fe79ba932679@citrix.com> References: <074dc3bb-6057-4f61-d516-d0fe3551165c@suse.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|DM4PR03MB6912:EE_ x-ms-office365-filtering-correlation-id: 488bded1-b792-4150-d21d-08daef81b9ae x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MGrdWtshkseu4iF4dVNOQq8rwOuFkRYuBaXK3T+YrErwoWX0JJtltjnINMoLGFguJks+P93JHMkV2UuUaZUQAYfY/xVvjDvHYVYu6e6HzcUE8JcJ6z7e6NFEtU/edyPjPjnjFZA8omhahZHSUnKBtXGNFeZcg/fUdiCYZZYemfAfi+rMcKTvY8QpkSneSwoq6drFXdAC/LX2KXPtNqsoTbSkItFRqIpaUXewhjHuVb0Zr0faW68Ci9JBIGDUDuNKlDRUzxmsfq2AfqLdAMkbrQhJ6YGhNfHZpl/U9dRnsu+Ygf3CDe0eDzgc6PBIpW+mIHy3LRniOxo3jlwo9aPeusoI4le3Tn+T9QvST4fzOUQJptMafSm10bgUVbxD07CC3vHBROw/zBlyLpSQ/1Qe11hm/APqbRx4/Hp5oCykAc29n28yP6a/kJ/P7cSvYZ75MeGst3DJa2fAEXVAocX6czp/YJzt9bTpgcykZIJPItyABEK0a/Z8wCGIgm52S1XnGR7lnDy+I/sKubzf1l1xO2re5/STf8lwXprOzKlGJsP8dk0QXsIHV4P+U/0frGByhzWefqyMNgN6g2SYhMokcHyo8RTpjmzBi9/Pk34vTNqpIDV+3VWpPt7xXGUfYyWZjVzkby5YIiRJwkCcTpRBa72ap9MJ9gtuFbtpiufvt9X0cX2n4wem5yrfO4aZI8FfwhgLgc86LVrME86UYH5odwou7MYFUNg79VaQmuDdrn3tTxecVWv+9PFcNH+Y7GYV x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(346002)(366004)(376002)(396003)(451199015)(31686004)(8936002)(110136005)(41300700001)(4326008)(76116006)(5660300002)(8676002)(66556008)(66476007)(66946007)(66446008)(6512007)(2906002)(316002)(54906003)(64756008)(91956017)(6506007)(71200400001)(26005)(478600001)(107886003)(53546011)(186003)(6486002)(86362001)(31696002)(2616005)(38100700002)(82960400001)(38070700005)(122000001)(36756003)(558084003)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?N1dPdnllOG8yVGFqeUV0ZHZ4YzdzQW4rSkJ6NlZTM3RXUTZSRkdoUXkyYkQx?= =?utf-8?B?UFlFU1M3MjdmU29WKzVZaUludUlBd2RSMVBYcmRKYXdVWFErQXNldkM1N2pC?= =?utf-8?B?Q3oxTEdmUnA2RUFrWlFERG9VVFpuRGkwbUV4bjYvak9oMmV1eE9aSHNtZmxO?= =?utf-8?B?NkNMTmIzdzlLYXdRWGNLYlJwdkcva0VGTmZiUm4xQU5YdHgwQWhHOE4yV0FK?= =?utf-8?B?bnNPQmxOMWpFNklzY3ZtQWVTNm0ydmU5cDJZdmVNZFRNZ1dhWkV6MWlxa054?= =?utf-8?B?c3NNNysybVdVbEgzQUtNOGZlaU53ejJvS3d6V2dXdi84bGVFR3pkMGlCdGRF?= =?utf-8?B?MnM0dENROW5STGw3RFhOSFk1YnMyWFc1SElDVjNWcE1HUGY0REJ6bTVjR21k?= =?utf-8?B?Ymo2dkZQV0ZIaHhyNkQrblMyY21meWhYSlM2ekF4emVPSFBvbWQwelB2N3hG?= =?utf-8?B?RGc2YjNmVzFtVE1hRG9NYi9RN1FETFVsbU40MElxMEEyMitJRXd0ejVKdDhQ?= =?utf-8?B?VGFEbFQ2WEVJdWxHWUpqaThTeUdVWXJKTXFqd0JISEpqUUtnOW5INnhkUzAr?= =?utf-8?B?WVd6K2lHRHNQTVdwTW1udTFRL0JqVFpDVGlwWFc2QzNndkRNM3FUS0l2WkdF?= =?utf-8?B?Tk43Z0ZCR2VZazh4WWhtVC81V2ozT094cG1qbXNJL3RhNzRuZzBCQzdZRGZG?= =?utf-8?B?R1p6NTJvejBYRnp1eTZnTzV3WEYvU1ArWmJlVk9JcVBGa3JCUWQxVWcwVEdM?= =?utf-8?B?cUpuU1BWVWNsNEFLd3ZZY080SnlFUEhIN1g0MWFNbk5NdXVESEJtRm9zZlpU?= =?utf-8?B?TXNLSnNzNzZjdDJsRmZQRXc1M0M5UC9YNEVhUFZTYktXRWZKVlcvZlgvYVNH?= =?utf-8?B?S21JUGw0Z0ozeWR2bmMzbklmQmFDeHlrVkVhY1VLTlhHNE1LcFk5QktQNnBF?= =?utf-8?B?eVFlSkxoRFgwY0ZVTDhvTGVVUUdzUUcvQS9pM25CWjJaYk5SdVhZOHhzQytN?= =?utf-8?B?MkRNSWhEU0s2dThvYkp3bHBNOGxiT3JUdjRudUYrcEY2S3Z1MVVsNFI5bDNO?= =?utf-8?B?bDlXUmtNNE5IamVVS1JuZXQrM1BCaHVFemkyWmpFc3QydmdwclBZTkpHQmx0?= =?utf-8?B?Q0tDQ0R0SU5FdERQSWt2UHhFUmN0YnU2YjRtUHBRN1BNTHFHa2cxSHl4U29L?= =?utf-8?B?TE15clVTekp3SUordktwR1pDV1hLQjlaWTZ3NmZJUnpad0VOeUZFUzlKajFH?= =?utf-8?B?Znp4R1E1VlJXR1RyeTNzVUlmY2c2SkliNldTUjM4bzRITitWS29Td1NwcitF?= =?utf-8?B?K0M2VTBzMDFlT2toVEM3Z1R4Wm50Z1l0STBTcnppWWZiYmZoaWd6M2E4NnVU?= =?utf-8?B?a29qdFNsdGVXaW1mUmFtV0hGZ09vRG9BdlpJS1VsWmEwSDBGNjE2OVYvZ0ZH?= =?utf-8?B?Um9ha1lCK0dRdTE3ZzhpNHJrcXIxZ3hmdnhJTDFvS0k5ODBJYnRlQzl6dnBP?= =?utf-8?B?VXFrTFNyOHY3MXB3L0lqREx2Mml4YlRwSmU2YnFWTDhiYlcwak5GanJlam45?= =?utf-8?B?a01Qa21VcVlkdFNZZ1dhZGxYSmFnQWZVb2FEdFBWNm9yeGlZc1BDMGpGbHNq?= =?utf-8?B?ZDQyVzl0MWI2QkwzK0JqeTh1dVZUZDNkZ29VaUZpWlVBRkZ1NEZFWElreDRZ?= =?utf-8?B?a2FreE8rV1hUdnNhb0s0MG8zWnFJbEd2TTEyMDhYVWlHTFk2OWR5Vy9sVHhM?= =?utf-8?B?bTNBUXVjaFdLRHVaUnIzM1RVMUJYUEUycVR1ZER5NGZxejJaTXB6aXdRbitu?= =?utf-8?B?NnlZcDg4ZDFzTGs1WVJNeVA4UzJ4WjhPVTNyb1c1Z3Y0RUwyZ3BYMmMwVmti?= =?utf-8?B?TzVtOXdaSWU5Ry9MRzhPZEtpSFpXQlI5K0ltM1AvMUtGYlB5NHdZeVRmc3hF?= =?utf-8?B?RTFqUlhBYkpya1UvaytzMFJqa0phVldrUTEzLzladjlhaTFKdmVzakJqMDZs?= =?utf-8?B?U2pUdDBjeldrVk03U0NxWHZBRTY0SVhIUjdCbnFnWDhIMklnWG9aUW80UEF0?= =?utf-8?B?UVFiaEJkRHFhMjY1U0FaM1hndGpCRmZUNldVTE9GYXhNU09TSDJDbzZEMVlY?= =?utf-8?Q?9gQElr30ilnyVO6IaVXNfWzT+?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: WXoTPzzy3oThcE5NiNJCz2EntLdsClcM2Gyou7Hi79FMfSvbU5b8DWjN8/J9Qenmrgi0LrLkcHhRSXYAE1N1gV0IyHBodcaKYLb71Ud6pLTX3xooexoVzWC9bZ56P5UOB056Xd1dckJZHKxiA9TPxHyPHCMYUkeqwG/I8BWnMmHdY08UBD1YhQ0GJ+CWVPAGmrnXs8y7HIqlXvLQi+w+lI5xFjyV0O2xi7LVRHYUa/ldrYwpXIEUYIJfw6bBZ/aS6Xr0tnFCOYzHayErQZoX3xb3W68uBs1WmQds5EqKCegDySuudCsCr8fLklo57AvnTcC74nViSPbKUL9G9dFlGikJY0Cx5NHORPLuJdIn2OtmWEeaSyUvpwaRvOaALqgsaBNcSVk2Jh8jg67GfxXj1c0A54jbNg+4BxKKQhU9GAC7TWD/kL64nbp4V30daAV48RdGzP4lYHfItBmbzQvXDRY5IJkGm1aCokpm9b0fMiKAVQOH7PixI4iD3znENwHiRwPZKChZwODDq5047PDu7h0bOJveIHjoV2a80z10RWR3h9m+IJWn5CidUp/HJfP+qAoW3SYaxIzbHZeT221OgM9aLXTfLh8CppagygrJI0VIW66BlYKCP4FiyHibbvfeTFXAOsFaBQAIUttNFx3gfT5aEuuATncs5hT901KoQJ+rfcNhU5lBWTWrGRqsmjHXDpi8wL3tpJS4aah0qGlIIgGQ1pPT9hcRLacghOkjte7GbghTeXu9GDcJeDa5NspW6Nf+m9VXVNSgix9N6jzA4N56GdQXiBTMgLtlLo2Ujgm4jeVE8CNfhpDiME9xFT1tjELliwQfvj3ZFCao1Rsv5w== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 488bded1-b792-4150-d21d-08daef81b9ae X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jan 2023 01:02:47.0783 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: I2ZG4slglp0Umqlt4DdYmxVJgBBAEF4wdh8AMd0qWwJMOrIZ+6hR24ufSUk5bbEW+E8ohbWaGF8AzuB8h1s4bHiC6iHdLZeWqLAQSmCpuos= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6912 T24gMDUvMDEvMjAyMyA0OjA0IHBtLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gdi0+YXJjaC5wYWdp bmcuc2hhZG93LnNoYWRvd190YWJsZVtdLCB2LT5hcmNoLnBhZ2luZy5zaGFkb3cub29zW10sDQo+ IHYtPmFyY2gucGFnaW5nLnNoYWRvdy5vb3Nfe3NuYXBzaG90W10sZml4dXBbXS5zbWZuW119IGFz IHdlbGwgYXMgdGhlDQoNCmZpeHVwW10sc21mbltdID8NCg== From xen-devel-bounces@lists.xenproject.org Fri Jan 06 01:32:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 01:32:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472250.732410 (Exim 4.92) (envelope-from ) id 1pDbaN-0000Hy-Oi; Fri, 06 Jan 2023 01:31:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472250.732410; Fri, 06 Jan 2023 01:31:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDbaN-0000Hp-KW; Fri, 06 Jan 2023 01:31:55 +0000 Received: by outflank-mailman (input) for mailman id 472250; Fri, 06 Jan 2023 01:31:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDbaM-0000Hj-4a for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 01:31:54 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e4003a05-8d61-11ed-b8d0-410ff93cb8f0; Fri, 06 Jan 2023 02:31:51 +0100 (CET) Received: from mail-bn8nam12lp2171.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.171]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 05 Jan 2023 20:31:47 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by MW4PR03MB6665.namprd03.prod.outlook.com (2603:10b6:303:120::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Fri, 6 Jan 2023 01:31:44 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5944.019; Fri, 6 Jan 2023 01:31:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e4003a05-8d61-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1672968711; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=oh7cyCArkL503G2e+TUqgklZst87qK1v5xznyrpur2s=; b=dFZJpfuvOJiVwU5WqMAiQTjAKijQbnopO1bT8Ah9mAOxvNQhL9Mqi27i A2f5C5OAKBcMuOZReBtkp/1YpZBl8li+O35nAUAsb0niE4UCx17G3WZIx jHF/VwSBVgGPn33eJoh3JjKgrBl3f24GKklNCjC2aYyACuPqWV3gi4O/G 8=; X-IronPort-RemoteIP: 104.47.55.171 X-IronPort-MID: 91404169 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:jbWz1qpII069CFmoh6826T8AuR5eBmIpZBIvgKrLsJaIsI4StFCzt garIBmHPquMNmegftp/PYSyoUxTucTTnYRnGlQ+qn0zEn4b8puZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpAFc+E0/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06W1wUmAWP6gR5weHzyRNV/rzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXADAPLSDTuOeH+4yEG8l9pNR9A/uwf5xK7xmMzRmBZRonabbqZvyQoPV+jHI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jeWraYWMEjCJbZw9ckKwj 2TK5WnmRDodM8SS02Gt+XOwnO7f2yj8Xer+EZXpr6Iy3ATNlwT/DjUnCBjnsainm3TnVtZiK xEx9nEJ97MLoRnDot7VGkfQTGS/lhwWVsdUEuY6wBqQ0aeS6AGcbkAUQzgEZNE4ucseQT0xy kTPj97vHSZosrCeVTSa7Lj8hSy2ETgYKykFfyBsZRcE5vHzrYd1iQjAJuuPC4awh9zxXDv2k zaDqXFkg61J1JFSkaKm4VrAnjSg4IDTSRI47RnWWWTj6R5lYImiZMqj7l2zAet8Ebt1h2Kp5 BAs8/VyJshUZX1RvERhmNkwIYw= IronPort-HdrOrdr: A9a23:AsAjkK6cP2IM/bTnMgPXwMbXdLJyesId70hD6qkRc3Bom6mj/P xG88516faZslgssRMb+exoSZPgfZq0z/cci+Qs1NyZLWrbUQWTXeRfxLqn7zr8GzDvss5xvJ 0QF5SW0eeAb2RHsQ== X-IronPort-AV: E=Sophos;i="5.96,303,1665460800"; d="scan'208";a="91404169" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kRj2BAisd7GPfX3Nws1+dtWFtkLJFDkvpUXCBubddKlJdTAv8Z56z9VHEG9ym54fFMNk/FPpXe0Zr2Ps5aNgz84K5inC02LqICYMDvpl9pqfxQT00LhX7rTXk6ZSovMUKonpwvlcKkldDIxT1dydhaaWEc1DyHx5sRS6/j9KA89klMULbpApmMLNFSvVLB02KNafnq899eXQ8lW1wAUO6kdmdXW9ZnBvS/GVUEn/ayxfB5zTLRxHDWF6ssW10JBYgVH2d6KpkqEyx7JqYgBW10ufc+kouWClpOq2x0rwQ86N8BcdPAUPnifPdNWD++YN0DXMVZI3Amj046W7JWFtig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oh7cyCArkL503G2e+TUqgklZst87qK1v5xznyrpur2s=; b=gEKVuBrohVqmcbbARxKYbTQ1342wV/LX2GtC6XwNlw4OitPFc9nQUyWQb+SHRmxprVg/L17PJzic/uBKsU0YLuvhqdR6D7p3cJ+amVGs6RupfQJzIah5l05yDB1JI1fwWjn96sw4iHQA0LWJku5iajRwffOOIuj97Yfj1EgG5qXdsG1lam1enWgvuEnglzu8No9kIPnhvseSY9DDjs3kmFAJptICkBULQLB8DfGT45r7PU0EwCEyH9fsrBPJYqBEWawqZi5pnvLFacOXMSQjgRJh0XsUl/QpUnt1vHx4XLcuuAEGj8jCO/SlgDN8AFX/6H1cYHs7qv6+0dHmzGmrRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oh7cyCArkL503G2e+TUqgklZst87qK1v5xznyrpur2s=; b=DFAuZDlztl3HQpQtG1Nh645LwUi0r2f+g3pejWomrFwSgLDSXYkOYLh7hMBuPezz/zBajvJ2Fd7yprAqILdttcnJp/S+Cm47P0euzVKJcIX3xwQjeLg5Kk9nOUa365pRgCZ/G07q7QZL4qfDF3PZP2Lhii0a19t0nHpF8bf8IJI= From: Andrew Cooper To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Wei Liu , Roger Pau Monne , "Tim (Xen.org)" , George Dunlap Subject: Re: [PATCH 07/11] x86/shadow: L2H shadow type is PV32-only Thread-Topic: [PATCH 07/11] x86/shadow: L2H shadow type is PV32-only Thread-Index: AQHZIR97UU3x5E5JME2c1R2RCJMcMa6QmwUA Date: Fri, 6 Jan 2023 01:31:44 +0000 Message-ID: References: <074dc3bb-6057-4f61-d516-d0fe3551165c@suse.com> <2743393d-852d-b385-9eba-e22806b1c4af@suse.com> In-Reply-To: <2743393d-852d-b385-9eba-e22806b1c4af@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|MW4PR03MB6665:EE_ x-ms-office365-filtering-correlation-id: 21858d6e-9db4-427e-65b5-08daef85c538 x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /W6+L2nbaZOeWCAxt7r7gH8X6X8ewwOj6Ag0mhwdkg4XezhhAbaJtYEiSASlDMGDrTke7Gc2oLZ88ad9H2eTwib9Hi7PAjCpSc+ja0yvrmpLmJ0kfHfcxULltxwvdGfJkwZkLzQHtlkWs8ZLYhWxi3SNZB9jQwdK2OZA3zu0pk4wzTAtR0wi0JjNMmrE+Qu3AdkJYqP/7dqMo+pgFVSvboPaMQXa7Z3jzI24Dl34PDPfUBHEfQXnxB2NyaYZQBy+gcIB6cMzJBzFjWaCHTu4zMomWQk9H2g+up+YJI4J4qqO0ZWbJJWV7AkzoSvs92a3r2KlxQdMjv6/bTAwUjOpiyKYpVMNyZSw+goOtF0sg+yEzBm3YRZ1YOXiJi0d7EagRapcEYqOXIVgerNE5LnrDLOj3UbrdQtnGAamXSvJ3ptq0e8Hppz//D69k69qIwBWV54PAtA4JeEVbECv6FbzaGG1sCQJRWlbWSlIUPyywP57U+IpEopIJtx7fmwKzvbZucJL59iGhEIru+qY7CHPJOOo55xRckN5+bS4Y6RDyS64q5hX8euDaV0j61lti0PIYKm7oQ6hvrOdCSkwPpAiiX6LsPAXLcy6YPA+XQeRbQwYjLPKh0O0v0WFU6XToI9r94IJPVX3JeZmNuMbswXguY5ca8EbploKbUFgsB/omXO8IkERh5hwf0I9cMO11MNsQCRZjWiuKDAc7eo79rvLzaCdGY4IaY9oAwc03ve8FaBFcbu/ws7/W5WZ0zjdv3EMDDLG/lAgeVu8qNwjB2w00Q== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(39860400002)(346002)(376002)(396003)(136003)(451199015)(316002)(31686004)(5660300002)(76116006)(91956017)(66556008)(2906002)(41300700001)(54906003)(8676002)(64756008)(66446008)(66476007)(66946007)(8936002)(4326008)(110136005)(107886003)(6506007)(478600001)(53546011)(71200400001)(36756003)(83380400001)(26005)(186003)(6512007)(2616005)(6486002)(82960400001)(86362001)(38100700002)(122000001)(38070700005)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?eGVsWGRDOVduS0piK0xMRnYvaVFvSVd5b0tkbnZ4SnVXZ1l0Q251SDhYTC9B?= =?utf-8?B?dTdEdmZuS1JjVGQzQXlvR0RROGJVemFuVHB4b1UwTWszT3RZWHpGWTBYcXFu?= =?utf-8?B?Yzg0TE1zUTR5eWJZcS85SzQwNEExRUJqZGp3c1cxQU9DaXo5UzdwNE96WDUx?= =?utf-8?B?cFQ5b0tueFdWKzRtaGo0dyt4dVNBRVdaOVZCTVFnRTNhNUFFS0ZBalRDenho?= =?utf-8?B?dnpiWkFuNjFmT2ZlZ1JUSEZ4Y0YrVVRWL0pOU2tnN1lkR3FxUkN4Y09qZk1W?= =?utf-8?B?TFdEVXRwNnhKRGlSWC9HSmtUT2MxcXNsNm9sb01mdEFoV1RmdFdOVDlDNFF1?= =?utf-8?B?cjRaZjhwR3AyaGQ0czkxWFA0bkYzTVhUbHBNeGRZK2xlYW4zTWpna0dwWEF5?= =?utf-8?B?Y2YrdXNyNkhJbk1PYkZ5Tm5KNlQyNnlCbDkxR1hFRjRpc1NuR1JnREpWb0Nq?= =?utf-8?B?b041TTVBbDhZMDAwN3ZKRzMrZ2g2WTI5cEJUdDZpVUhoSHBrbFgxMmxXWkhU?= =?utf-8?B?TTd6MTN0ZzArTGlBQTM4MkRtRU9aOFZqTlVDRmNRY0RtekZqanhqMDhiRXMw?= =?utf-8?B?UmZsMUpVM3FSSmVrVWNHU3B5MmZqVHJ6WW1mMGVmakdoZmxzZVJjY0hJQ0Jq?= =?utf-8?B?NlFyS3E3YjZSTGdTb09hRDNCMjJMREkyZ1RGVTYydE83dzJpQkI0TERKd3Rl?= =?utf-8?B?d3Q4c214Yk0wN0pBV1pQei9VeFJJRExZU1ZzbU1xZ0xnQUExMFBSaWE4YWlk?= =?utf-8?B?RW5CdGxRS0tWZDZzdFdvbnhxSkhMMWxzS3lDT0JJUXhCVXl1bzZ2eWNsVGRR?= =?utf-8?B?dVlUOG5OOW56WDBTbHlQd2NRWmlpTXRFaGl6bVphcTJCWWFDUmRSdXUxbno4?= =?utf-8?B?bHpaVGlNS2tWQzZhUUZRZ1JjVXo2U2FYNXBqWDVFRk15aFRlL2ZLOHVEWHA4?= =?utf-8?B?dldUanBLN0VxdWkrZGJrY3RlRUFYV2w3TFZuNkROVVZjbWtVdEFtNUt3ck91?= =?utf-8?B?a3dNc1diOUU2eFdEb2E4eDV3TkZPSHBielhlWkhmckoxYy9XQnJtWjd6RFpq?= =?utf-8?B?YWFXSklTT2xvbnl0SjFxTGd5TmNuTnVxN3ArcmlmaHQ4WnhIMC9LWm92dlo0?= =?utf-8?B?ODAvQkhrZ2g3SDdheStpSzhlRVB6Y2hoUjFyd0p6d1lEU3dHRUFjUklEK3VN?= =?utf-8?B?all3RzdjSkFiTExyb2NrVE9EVEd6d3dPMDMvRkE2QlQ3MWFZNHJoUEM5VklP?= =?utf-8?B?WGNFNXVnemJveGJVa1JZTFlCTjFHUEk4Ly9RT1lKQ3E4RnRFcmg5UkxZREpX?= =?utf-8?B?ajNNdGU2a3o1QU5kS1dsd2puczJRVGJrMW8rTnRyTDV4anpXNEFGUjRLVi9M?= =?utf-8?B?OU5OQ2dra3JtSmNmYVlVMjlSamlVakN6UkFyaTJUL2x2NlhiVW4wUUk3UmtR?= =?utf-8?B?RTJOREw3RExZS1lqQkxuUDRJazR3OFpZVmVES3ZsZkd4U2dBRFBCZXF5bWxh?= =?utf-8?B?TzVNMi9oMERoNWl2ckJ3MTlBQUJ5T1FPdmJCY2dGcDJHbnhWUnlzUCt0MXg3?= =?utf-8?B?cXM2T3VFMEhyQUZhYXhRNTFoY2VmcWo0cndYNkhidmIvN2JTdUtTVC8za3pM?= =?utf-8?B?OU9WQTBOenlBeU44VENLZm5IbVk2bEI3b2FnbnpFdXJnbjBMU2g2UHMyZWtP?= =?utf-8?B?cW1hMWhWR0hBaEhJQXpjd1ZzUzBnMWhzQjRrM1lPelhuaENCSWVydEdlSVBO?= =?utf-8?B?L0ZiOEtPQyt1blQrOFJRcHpHSXdkOHg0WjQya0J0SmkxcmQvZ0g0ZVhqbGxF?= =?utf-8?B?dXlLeEdKNTB0aGphTUNsS0FZcXhYSWpaclVtNE0zN1FHb0l5aGJyTm9BNDB0?= =?utf-8?B?L3dhL0V6MGVHLzJLTXhnU0lBUlhsNjlnUXpaVlBwSkV0dWxLMWU3OWxiQ1pN?= =?utf-8?B?bFgyMitZS0hHNGlWU040OGYvUGlUeFRzeWhHU0tSUkxpd1U5a2tXZFByMnNV?= =?utf-8?B?RFJNNWRhbHdLRytnVkJ0RXdwb3pLQXdqN0tnREx0YmQvWlZ3Rk5TOFN2M2Uv?= =?utf-8?B?dUxLcEU0NTU5ZDBwNU9KK1cza1ZDTkVZZWhLS2s2ZjA1S09iaWp0L1JSMWJS?= =?utf-8?Q?IxHkPB2beWiZR8Qcqi7kn0gkL?= Content-Type: text/plain; charset="utf-8" Content-ID: <0814466D35FD6349AFD19F49B8F92DAE@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: VEh2B/EXa/D9x0sSy96Sb7t+FopKeAPWJ6gi7zsx2dRQOIZ+hilPBKs7xJFP9mZdn0MW33/kkSj7yo3DfbEzyTOSD5a410+P2dthzhqYyu71VlpFe8In+FVvFcdaNRiTJQhlGhR5N7kYHpJHnE8KMo0t5OADWZAz5SN72C+qF6YRFXOVjL3GSWYCxr2ti5u10YEmhrjZaDdxPuEauP83Fg1bET5KF+WLDq2s+xVgwx1tUkKpoIVHiqrqmRKqLG/BFP7zyvAJ4CgHeX1Z2xz7MWeSXkzdEvF9RHUdGW40dXroWQ26v+DnoV+S/AT+Qg8XPHpglaUDGww38hwLn8g4qLFGQ9icDd5bp7+QFoC80bund82cNlpWKqcA6EBglRxaBJ2LKbG4+y+veDOmbd4mU7Thr04dWRLA7WfM0Dm9K3XbFIgy/+XVjNY1HDuOYR7PRYzd2sqs69Yev6CrQc6cJCkyLvcNFYlkI6rO049wgn3OEV1OvMPUM5jRl14JKihPjxF4yBfnILHaJFQ2lngzjB04JrvbXk85fP/+lTdBNi+nEYcjksLYXanS/rhCMYIuudxDTo5rV4+5YdSqfRPH8AWEvQa6crALFfSmWZDd+eOQ/ZjF9JlTBupCpgDtswB+0etDOVieUJHWsc56cFsE3ldwiNYBo5o4AiSE3eSupwkbDsmZdLdN/RtNofbAAB6uEhMruOhPWXW6vLVoBXrl5jKnWdt0b70ZTmrkP40/oQvzA99KF1fp+hNqS8V9yYRQqeKUByfyrwL0lnAttWO8yE/DDDbfoR8WudPHsphoJQ3+Jw7xJC4dGKQr2vwaB9/yAVRYiA70zDLAIICbB0SMYg== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 21858d6e-9db4-427e-65b5-08daef85c538 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jan 2023 01:31:44.4530 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: twvfdl8yv7tvoLkiLODHPcpFMr7m9YHlAYshIkgA+Z4Qmti2AM2B0/CpWS299sjZc8kvTe+EUF0XikOXmYI0oHEgan9gX4lacSkGKvNGQIM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6665 T24gMDUvMDEvMjAyMyA0OjA1IHBtLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gTGlrZSBmb3IgdGhl IHZhcmlvdXMgSFZNLW9ubHkgdHlwZXMsIHNhdmUgYSBsaXR0bGUgYml0IG9mIGNvZGUgYnkgc3Vp dGFibHkNCj4gIm1hc2tpbmciIHRoaXMgdHlwZSBvdXQgd2hlbiAhUFYzMi4NCg0KYWRkL3JlbW92 ZTogMC8xIGdyb3cvc2hyaW5rOiAyLzQgdXAvZG93bjogNTQ0Ly05MjIgKC0zNzgpDQpGdW5jdGlv bsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoCBvbGTCoMKgwqDCoCBuZXfCoMKgIGRlbHRhDQpzaF9tYXBfYW5kX3Zh bGlkYXRlX2dsMmVfX2d1ZXN0XzTCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIDEzNsKgwqDCoMKgIDY2 NsKgwqDCoCArNTMwDQpzaF9kZXN0cm95X3NoYWRvd8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAyODnCoMKgwqDCoCAzMDPCoMKgwqDCoCArMTQN CnNoX2NsZWFyX3NoYWRvd19lbnRyeV9fZ3Vlc3RfNMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqAgMTc4wqDCoMKgwqAgMTc2wqDCoMKgwqDCoCAtMg0Kc2hfdmFsaWRhdGVfZ3Vlc3RfZW50cnnC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgNTIxwqDCoMKgwqAgNDcy wqDCoMKgwqAgLTQ5DQpzaF9tYXBfYW5kX3ZhbGlkYXRlX2dsMmhlX19ndWVzdF80wqDCoMKgwqDC oMKgwqDCoMKgwqAgMTM2wqDCoMKgwqDCoMKgIDLCoMKgwqAgLTEzNA0Kc2hfcmVtb3ZlX3NoYWRv d3PCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIDQ3 NTfCoMKgwqAgNDU0NcKgwqDCoCAtMjEyDQp2YWxpZGF0ZV9nbDJlwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgNTI1wqDCoMKgwqDC oMKgIC3CoMKgwqAgLTUyNQ0KVG90YWw6IEJlZm9yZT0zOTE0NzAyLCBBZnRlcj0zOTE0MzI0LCBj aGcgLTAuMDElDQoNCk1hcmdpbmFsLi4uDQoNCj4NCj4gU2lnbmVkLW9mZi1ieTogSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPiAtLS0NCj4gSSB3YXNuJ3QgcmVhbGx5IHN1cmUgd2hl dGhlciBpdCB3b3VsZCBiZSB3b3J0aHdoaWxlIHRvIGFsc28gdXBkYXRlIHRoZQ0KPiAiI2Vsc2Ui IHBhcnQgb2Ygc2hhZG93X3NpemUoKS4gRG9pbmcgc28gd291bGQgYmUgYSBsaXR0bGUgdHJpY2t5 LCBhcyB0aGUNCj4gdHlwZSB0byByZXR1cm4gMCBmb3IgaGFzIG5vIG5hbWUgcmlnaHQgbm93OyBJ J2QgbmVlZCB0byBtb3ZlIGRvd24gdGhlDQo+ICN1bmRlZiB0byBhbGxvdyBmb3IgdGhhdC4gVGhv dWdodHM/DQoNClRoaXMgcmVmZXJzIHRvIHRoZSBzdHJhaWdodCBkZWxldGlvbiBmcm9tIHNoX3R5 cGVfdG9fc2l6ZVtdID8NCg0KSSB3YXMgY29uZnVzZWQgYnkgdGhhdCBhdCBmaXJzdC7CoCBUaGUg c2hhZG93IGRvZXMgaGF2ZSBhIHNpemUgb2YgMS7CoCBNaWdodA0KDQovKsKgwqAgW1NIX3R5cGVf bDJoXzY0X3NoYWRvd13CoCA9IDEswqAgUFYzMiBvbmx5ICovDQoNCndvcmsgYmV0dGVyP8KgIFRo YXQgbGVhdmVzIGl0IGNsZWFybHkgaW4gdGhlcmUgYXMgYSAxLCBidXQgbm90IG5lZWRpbmcNCmFu eSBmdXJ0aGVyIGlmZGVmYXJ5Lg0KDQo+IC0tLSBhL3hlbi9hcmNoL3g4Ni9tbS9zaGFkb3cvbXVs dGkuYw0KPiArKysgYi94ZW4vYXJjaC94ODYvbW0vc2hhZG93L211bHRpLmMNCj4gQEAgLTg1OSwx MyArODY2LDEyIEBAIGRvIHsNCj4gICAgICBpbnQgX2k7ICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcDQo+ICAgICAgaW50IF94 ZW4gPSAhc2hhZG93X21vZGVfZXh0ZXJuYWwoX2RvbSk7ICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgXA0KPiAgICAgIHNoYWRvd19sMmVfdCAqX3NwID0gbWFwX2RvbWFpbl9wYWdlKChf c2wybWZuKSk7ICAgICAgICAgICAgICAgICAgICAgICAgIFwNCj4gLSAgICBBU1NFUlQobWZuX3Rv X3BhZ2UoX3NsMm1mbiktPnUuc2gudHlwZSA9PSBTSF90eXBlX2wyXzY0X3NoYWRvdyB8fFwNCj4g LSAgICAgICAgICAgbWZuX3RvX3BhZ2UoX3NsMm1mbiktPnUuc2gudHlwZSA9PSBTSF90eXBlX2wy aF82NF9zaGFkb3cpO1wNCj4gKyAgICBBU1NFUlRfVkFMSURfTDIobWZuX3RvX3BhZ2UoX3NsMm1m biktPnUuc2gudHlwZSk7ICAgICAgICAgICAgICAgICAgICAgICBcDQo+ICAgICAgZm9yICggX2kg PSAwOyBfaSA8IFNIQURPV19MMl9QQUdFVEFCTEVfRU5UUklFUzsgX2krKyApICAgICAgICAgICAg ICAgICAgXA0KPiAgICAgIHsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFwNCj4gICAgICAgICAgaWYgKCAoIShfeGVu KSkgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBc DQo+ICAgICAgICAgICAgICAgfHwgIWlzX3B2XzMyYml0X2RvbWFpbihfZG9tKSAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgXA0KPiAtICAgICAgICAgICAgIHx8IG1mbl90b19wYWdl KF9zbDJtZm4pLT51LnNoLnR5cGUgIT0gU0hfdHlwZV9sMmhfNjRfc2hhZG93ICAgIFwNCj4gKyAg ICAgICAgICAgICB8fCBtZm5fdG9fcGFnZShfc2wybWZuKS0+dS5zaC50eXBlID09IFNIX3R5cGVf bDJfNjRfc2hhZG93ICAgICBcDQoNCklzbid0IHRoaXMgcmVkdW5kYW50IHdpdGggdGhlIEFTU0VS VF9WQUxJRF9MMigpIG5vdz8NCg0KUGVyIHlvdXIgb3RoZXIgcXVlc3Rpb24sIHllcyB0aGlzIGRl c3BlcmF0ZWx5IHdhbnRzIHJlYXJyYW5naW5nLCBidXQgSQ0Kd291bGQgYWdyZWUgd2l0aCBpdCBi ZWluZyBhbm90aGVyIHBhdGNoLg0KDQpJIGRpZCBwcmV2aW91c2x5IHBsYXkgYXQgdHJ5aW5nIHRv IHNpbXBsaWZ5IHRoZSBQViBwYWdldGFibGUgbG9vcHMgaW4gYQ0Kc2ltaWxhciB3YXkuwqAgQ29k ZS1nZW4gd2lzZSwgSSB0aGluayB0aGUgTDIgbG9vcHMgd2hhdCB0byBjYWxjdWxhdGUgYW4NCnVw cGVyIGJvdW5kIHdoaWNoIGlzIGVpdGhlciA1MTIsIG9yIGNvbXBhdF9maXJzdF9zbG90LCB3aGls ZSB0aGUgTDQNCmxvb3BzIHdoYXQgYW4gImlmKGkgPT0gMjU2KSBpICs9IDc7IGNvbnRpbnVlOyIg cmF0aGVyIHRoYW4gaGF2aW5nDQpMRkVOQ0UtaW5nIHByZWRpY2F0ZXMgb24gZWFjaCBpdGVyYXRp b24uDQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Fri Jan 06 01:49:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 01:49:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472258.732421 (Exim 4.92) (envelope-from ) id 1pDbr6-0001yM-5K; Fri, 06 Jan 2023 01:49:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472258.732421; Fri, 06 Jan 2023 01:49:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDbr6-0001yF-0w; Fri, 06 Jan 2023 01:49:12 +0000 Received: by outflank-mailman (input) for mailman id 472258; Fri, 06 Jan 2023 01:49:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDbr4-0001y3-0d; Fri, 06 Jan 2023 01:49:10 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDbr3-00076v-LU; Fri, 06 Jan 2023 01:49:09 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDbr3-0001qW-3A; Fri, 06 Jan 2023 01:49:09 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pDbr3-0007Tv-2e; Fri, 06 Jan 2023 01:49:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=/ZOnyD3PoMAIe3qC2MqwyG80SHNHBUxwg+S/kpcFPpk=; b=Q41X371o2v4DDuGOi1ft3dsLkk TGW5rQtf2Veh74LTn0vuS8yPhDFytzuYvLZqKi64BX5pI+HJgkVaJxNvA1mFlT2nluKniEg9Cqj7l EJRxtxJXjdLrMUC3kouIobsJO2vkwZOqWtNlih+xjjvlEOSvVKdK81/dyQhUAofUxi5M=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 175590: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-i386-xl-shadow:xen-install:fail:heisenbug qemu-mainline:test-arm64-arm64-xl-vhd:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=f8af61fa14441e67300176a5e07671ea395426b3 X-Osstest-Versions-That: qemuu=cb9c6a8e5ad6a1f0ce164d352e3102df46986e22 From: osstest service owner Date: Fri, 06 Jan 2023 01:49:09 +0000 flight 175590 qemu-mainline real [real] flight 175594 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/175590/ http://logs.test-lab.xenproject.org/osstest/logs/175594/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-shadow 7 xen-install fail pass in 175594-retest test-arm64-arm64-xl-vhd 17 guest-start/debian.repeat fail pass in 175594-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail like 175583 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 175583 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 175583 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175583 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175583 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 175583 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 175583 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175583 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175583 test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu f8af61fa14441e67300176a5e07671ea395426b3 baseline version: qemuu cb9c6a8e5ad6a1f0ce164d352e3102df46986e22 Last test of basis 175583 2023-01-05 06:47:09 Z 0 days Testing same since 175590 2023-01-05 17:07:09 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Chenyi Qiang David Hildenbrand Michal Privoznik Peter Maydell Philippe Mathieu-Daudé jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git cb9c6a8e5a..f8af61fa14 f8af61fa14441e67300176a5e07671ea395426b3 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Fri Jan 06 02:00:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 02:00:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472268.732432 (Exim 4.92) (envelope-from ) id 1pDc1u-0004ka-AG; Fri, 06 Jan 2023 02:00:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472268.732432; Fri, 06 Jan 2023 02:00:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDc1u-0004kT-6i; Fri, 06 Jan 2023 02:00:22 +0000 Received: by outflank-mailman (input) for mailman id 472268; Fri, 06 Jan 2023 02:00:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDc1s-0004kN-VL for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 02:00:21 +0000 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id dc1f9371-8d65-11ed-b8d0-410ff93cb8f0; Fri, 06 Jan 2023 03:00:16 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id E534F5C00E8; Thu, 5 Jan 2023 21:00:13 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 05 Jan 2023 21:00:13 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 5 Jan 2023 21:00:12 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dc1f9371-8d65-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1672970413; x= 1673056813; bh=n4HZkBJhhcWVGPn6wmsxBFb/A7GL3M2SBbnddi32WiQ=; b=e psyyWjBsG+IJnTVB10cKN9EOWHjm70L+SWVTbqnQOguVu8FS3C6CEcVIdbJ9xMBd sliMpNKPhus6U84NPW10VK3y15ak+tVar98JKuBa4pxxm07usQS6VKwyKJdtUFjo 30o/d0VinMjUBiJMHhE5q/enUPJKUoLN0AC/7tM49M3mrXQLdB4xcq513cYO/r0A ZBTmDxmLbhjdmCDPN9wu/n2Kq1p1Mm2JMpGYu42dnCS5PSBuvAcgGsY+nNFxIa2T AzO7CbHQPCBYum4c3CE0f+9cygoK4Q+VywY3o5VJnSk4400JYaDRtHdgFxnYWSG1 KoIuXbHnpDetF4IvJat1w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1672970413; x=1673056813; bh=n4HZkBJhhcWVGPn6wmsxBFb/A7GL 3M2SBbnddi32WiQ=; b=PoyysGK8WDMzfpzDbwxKUd7IPk+//sYnUN3974pl44j5 nSce2chh1XAlZB16Hyy1MCfwE2mFGVYWkhKl+fQ5b1gMxQL4sB5+2rM5pT/Lw1RC K5vSOe/LXtw+Iud9rGE/sSkpqd/ktaPoi8+esbVyuuAJ2TMKVbcPxkZPJerB6jGo gxk6Qkg1seIhd0AFBF7EwcCyUNuT36PTCQp4XetY1R+3LS6Lw1+2O4Q1Ipx9mmWo q7S10TREYgr6S6/xoJBvRQd4rCpcRKEsMXiIpnNE7dI38ZV5sAXQFRarw8VY2ps1 4NqT0wMSA4+CTBVqvlp1z9NfOQj7shSHNfzvQaN9Yg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrjeelgdegudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeffvghmihcu ofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinhhgsh hlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpedvjeetgeekhfetudfhgfetffegfffg uddvgffhffeifeeikeektdehgeetheffleenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhgshhl rggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Thu, 5 Jan 2023 21:00:03 -0500 From: Demi Marie Obenour To: Andrew Cooper , "xen-devel@lists.xenproject.org" Cc: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , Jan Beulich , Roger Pau Monne , Wei Liu , "Tim (Xen.org)" , George Dunlap Subject: Re: [PATCH v6 4/5] x86/mm: Reject invalid cacheability in PV guests by default Message-ID: References: <2236399f561d348937f2ff7777fe47ad4236dbda.1671744225.git.demi@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="FR8Kja2I10q88hmI" Content-Disposition: inline In-Reply-To: --FR8Kja2I10q88hmI Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Thu, 5 Jan 2023 21:00:03 -0500 From: Demi Marie Obenour To: Andrew Cooper , "xen-devel@lists.xenproject.org" Cc: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , Jan Beulich , Roger Pau Monne , Wei Liu , "Tim (Xen.org)" , George Dunlap Subject: Re: [PATCH v6 4/5] x86/mm: Reject invalid cacheability in PV guests by default On Thu, Jan 05, 2023 at 08:28:26PM +0000, Andrew Cooper wrote: > On 22/12/2022 10:31 pm, Demi Marie Obenour wrote: > > diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-= line.pandoc > > index 424b12cfb27d6ade2ec63eacb8afe5df82465451..0230a7bc17cbd4362a42ea6= 4cea695f31f5e0f86 100644 > > --- a/docs/misc/xen-command-line.pandoc > > +++ b/docs/misc/xen-command-line.pandoc > > @@ -1417,6 +1417,17 @@ detection of systems known to misbehave upon acc= esses to that port. > > ### idle_latency_factor (x86) > > > `=3D ` > > =20 > > +### invalid-cacheability (x86) > > +> `=3D allow | deny | trap` > > + > > +> Default: `deny` in release builds, otherwise `trap` > > + > > +Specify what happens when a PV guest tries to use one of the reserved = entries in > > +the PAT. `deny` causes the attempt to be rejected with -EINVAL, `allo= w` allows > > +the attempt, and `trap` causes a general protection fault to be raised. > > +Currently, the reserved entries are marked as uncacheable in Xen's PAT= , but this > > +will change if new memory types are added, so guests must not rely on = it. > > + >=20 > This wants to be scoped under "pv", and not a top-level option.=C2=A0 Cur= rent > parsing is at the top of xen/arch/x86/pv/domain.c >=20 > How about `pv=3D{no-}oob-pat`, and parse it into the opt_pv_oob_pat boole= an ? Works for me, though I will use =E2=80=98invalid=E2=80=99 instead of =E2=80= =98oob=E2=80=99 as valid PAT entries might not be contiguous. > There really is no need to distinguish between deny and trap.=C2=A0 IMO, > injecting #GP unilaterally is fine (to a guest expecting the hypercall > to succeed, -EINVAL vs #GP makes no difference, but #GP is far more > useful to a human trying to debug issues here), but I could be talked > into putting that behind a CONFIG_DEBUG if other feel strongly. Marek, thoughts? > > @@ -1343,7 +1374,34 @@ static int promote_l1_table(struct page_info *pa= ge) > > } > > else > > { > > - switch ( ret =3D get_page_from_l1e(pl1e[i], d, d) ) > > + l1_pgentry_t l1e =3D pl1e[i]; > > + > > + if ( invalid_cacheability !=3D INVALID_CACHEABILITY_ALLOW ) > > + { > > + switch ( l1e.l1 & PAGE_CACHE_ATTRS ) > > + { > > + case _PAGE_WB: > > + case _PAGE_UC: > > + case _PAGE_UCM: > > + case _PAGE_WC: > > + case _PAGE_WT: > > + case _PAGE_WP: > > + break; > > + default: > > + /* > > + * If we get here, a PV guest tried to use one of = the > > + * reserved values in Xen's PAT. This indicates a= bug > > + * in the guest. If requested by the user, inject= #GP > > + * to cause the guest to log a stack trace. > > + */ > > + if ( invalid_cacheability =3D=3D INVALID_CACHEABIL= ITY_TRAP ) > > + pv_inject_hw_exception(TRAP_gp_fault, 0); > > + ret =3D -EINVAL; > > + goto fail; > > + } > > + } >=20 > This will catch cases where the guest writes a full pagetable, then > promotes it, but won't catch cases where the guest modifies an > individual entry with mmu_update/etc. >=20 > The logic needs to be in get_page_from_l1e() to get applied uniformly to > all PTE modifications. I will move it there, and also update Qubes OS=E2=80=99s patchset. > Right now, the l1_disallow_mask() check near the start hides the "can > you use a nonzero cacheattr" check.=C2=A0 If I ever get around to cleanin= g up > my post-XSA-402 series, I have a load of modifications to this. I came up with some major cleanups too. > But this could be something like this: >=20 > if ( opt_pv_oob_pat && (l1f & PAGE_CACHE_ATTRS) > _PAGE_WP ) > { > =C2=A0=C2=A0=C2=A0 // #GP > =C2=A0=C2=A0=C2=A0 return -EINVAL; > } >=20 > fairly early on. >=20 > It occurs to me that this check is only applicable when we're using the > Xen ABI APT, and seeing as we've talked about possibly making patch 5 a > Kconfig option, that may want accounting here.=C2=A0 (Perhaps simply maki= ng > opt_pb_oob_pat be false in a !XEN_PAT build.) It=E2=80=99s actually applicable even with other PATs. While Marek and I w= ere tracking down an Intel iGPU cache coherency problem, Marek used it to verify that PAT entries that we thought were not being used were in fact unused. This allowed proving that the behavior of the GPU was impacted by changes to PAT entries the hardware should not even be looking at, and therefore that the hardware itself must be buggy. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --FR8Kja2I10q88hmI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmO3gKsACgkQsoi1X/+c IsEGthAAj11euyGtkuY086E9VeDW2EyrMeCxS3CWqScUund/rBgQsR2J3oYVaZun sjaNxZwPNnrB1qgd38evjCQF0Jq+MCC8Ng24wF1yYYtPqTUXUc63mowbPpoVBUBi OJD1CIlU4joGsnLfQboKwgzV573KUWazeIQU30kasE4sXplyFIX62VlD9tsfPJwB zzm+pzvj1OHDCNja1xtW77krS+2AbPbdTuArktXBduq8U8LirqzDr1ITYh1ypUBT ridc/wxpmc1SBiGmjqs2Ae1xunbVHwzYLU3Kw0a/bChHv/kyb6yNIn0Q/uGBnw10 l3xuyF+QSaNdeeGyzYYzMGffESAv1c23gXU5bTRkAyo8TxgWyMvO8Wz8bzzLkUmR yulAnsLO4oVVI356TpYeceOmVJbz/A6ZUJbD++cn/iEvzrAi+eAheCTSYTHDwC3j MKhDX2XkVtAIOtU8phuSuF72i8zax8HAVhPTFSYeb/YKzrakPowR8+kSMU0d/b0D egNyBqRTIPl6AAqOME/r0asoO7n/Icd89Zjp70whg4wF4lnx5Ky5HH3TYjdZa58q fNyU7BMLxlSC78ekC3Qwj2feWx5VIYEca03RAZedWmnRY4Flr3tXeiQEK72POpF4 RNT9738xnN6oZQUBJnb6lczqI1Tiumi/3xmCkS12H0dYmPx2hXE= =/Bzv -----END PGP SIGNATURE----- --FR8Kja2I10q88hmI-- From xen-devel-bounces@lists.xenproject.org Fri Jan 06 02:03:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 02:03:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472276.732443 (Exim 4.92) (envelope-from ) id 1pDc4i-0005Lb-Oh; Fri, 06 Jan 2023 02:03:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472276.732443; Fri, 06 Jan 2023 02:03:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDc4i-0005LU-LK; Fri, 06 Jan 2023 02:03:16 +0000 Received: by outflank-mailman (input) for mailman id 472276; Fri, 06 Jan 2023 02:03:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDc4g-0005LO-Tu for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 02:03:15 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 44e3f0eb-8d66-11ed-b8d0-410ff93cb8f0; Fri, 06 Jan 2023 03:03:11 +0100 (CET) Received: from mail-dm6nam10lp2102.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.102]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 05 Jan 2023 21:03:09 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DM6PR03MB5162.namprd03.prod.outlook.com (2603:10b6:5:24a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Fri, 6 Jan 2023 02:03:07 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5944.019; Fri, 6 Jan 2023 02:03:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 44e3f0eb-8d66-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1672970591; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=ViXsOb5Flt6Rc1xOWmrEZV/r88DR+Cz+8dlxDG5k1LQ=; b=A60tlV3taHW7xyih+zLoV5d62aIywIiUH8fgtmLKnc1ChzRzjpMaW1vH FrYQUxz0Ac5KOtl06d5/CDRihUuS5dKMhGgjAvo8L2qezRp+TdDrS5LRp loMHRT4eeWA9mtXh3IPiIzvtjO2aL8hzLUq1iPwWBaddegu/z6i6i8rK3 k=; X-IronPort-RemoteIP: 104.47.58.102 X-IronPort-MID: 91823714 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:/bRAp6qqAkcLlqOrsYvR30hrLBheBmIpZBIvgKrLsJaIsI4StFCzt garIBnTa/nba2f0e9h3b9vi8k4Dv5HQyYVjTgo++yw2FihH85uZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpAFc+E0/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06W1wUmAWP6gR5weHzyRNV/rzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXAC4UaRuljOOT+aKAafVGlOIDKtjlF5xK7xmMzRmBZRonabbqZvySoPN9gnI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jeiraYKPEjCJbZw9ckKwj 2TK5WnmRDodM8SS02Gt+XOwnO7f2yj8Xer+EZXpr64w2wLKmgT/DjURaWCln9eh1neccMl+M FQ4+wc1qbIboRnDot7VGkfQTGS/lhwWVsdUEuY6wBqQ0aeS6AGcbkAUQzgEZNE4ucseQT0xy kTPj97vHSZosrCeVTSa7Lj8hSy2ETgYKykFfyBsZRcE5vHzrYd1iQjAJuuPC4awh9zxXD31n TaDqXFmg61J1JZRkaKm4VrAnjSg4IDTSRI47RnWWWTj6R5lYImiZMqj7l2zAet8Ebt1h2Kp5 BAs8/VyJshXZX1RvERhmNkwIYw= IronPort-HdrOrdr: A9a23:8CjS0apxrdXtxfT3aHuefk8aV5oaeYIsimQD101hICG9E/bo9f xG+c5xvyMc5wx9ZJheo6HlBEDtex/hHOdOkO4s1NSZLWrbUQmTTb2KhLGKqwEIfReQygc378 ddmsZFZuEZ8jBB/KPHCQODYrAdKHDuytHQuQ7W9QYUcT1X X-IronPort-AV: E=Sophos;i="5.96,303,1665460800"; d="scan'208";a="91823714" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jA73pZut7Y+iTb1LnGgibzfH8YEh+g9uaFPV4cpbbfSkhbTKlEqifJfPt7OQm9WkPXkz1tByncsU3BvlDK7WtnWTepxOw4y2sfbyWwrqDQxBAaNOxmLg8nbejVxqTSCajjdQliRt+4hThLNkMqwnxpDddIHzLr4Sbn9glwhk+oOyC4kMrl/yyLABmSw+Bf48cRqFSLOdwZ+sPuJencjYoCzDRkOhtPN8XzDesKYMcwBv+saeHKE3wuSNqiYZPvphcJdHwu/9hKhXSYg0h5RfVCpAWf8sDTSLfXyHilTAXxzI2GuVRmfPvP8s2mjSVe7NjvLVW3YhAbz88JhuEcW0Qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ViXsOb5Flt6Rc1xOWmrEZV/r88DR+Cz+8dlxDG5k1LQ=; b=OAhUO2Nnxts/0Jpnsm3DxWLAdIvnHRHlmoun9CjuLTXoWXxPHE4axLyshJDTwS3L7CsZ64zrhKbQGSOc9gac4qm+ZCQec8hMbEGADscQMSNi3Phv5Zla5YuKUW3dW4zKKEjnrbfpcywNtY5vEpN/UwKbjPX/DQMIDowLoM24K9JPEQF1sdp5ddLmWOmYvpaez4WKeO6xJbFUrOn3AwJJDXQYi2As+X5cAgSLVxDIJQ+78+LutqFekRRsDinxWP2QRw3j1sUX5/GvyLYdksOA/dzteEG4+rds5X7p9qoALSRTuzXfTTGUi/Ap3rlMTeJ2b3bDqKJcd7pdoojA4PYuUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ViXsOb5Flt6Rc1xOWmrEZV/r88DR+Cz+8dlxDG5k1LQ=; b=PbJZySaOSUgqzAR2Gq88Twgeqm+Wm6v7Ct+tvkYb6/tJb/aMaxolgW5humWZj9ny90ksphf7RXpSiPSzvNgP7adSk0JocOmJgI95QjBRKihdxxnKgVV1OppD2SGpCcSGEiYIAH6ahPMKxNBE94k8ZGMLRcol/nmVeHsqytngaLg= From: Andrew Cooper To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Wei Liu , Roger Pau Monne , "Tim (Xen.org)" , George Dunlap Subject: Re: [PATCH 08/11] x86/shadow: reduce effort of hash calculation Thread-Topic: [PATCH 08/11] x86/shadow: reduce effort of hash calculation Thread-Index: AQHZIR+fQDluUga6GUWdpW8jT2W5ga6Qo8kA Date: Fri, 6 Jan 2023 02:03:07 +0000 Message-ID: <20c268c0-979b-5ac9-da16-7cb7322552a6@citrix.com> References: <074dc3bb-6057-4f61-d516-d0fe3551165c@suse.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|DM6PR03MB5162:EE_ x-ms-office365-filtering-correlation-id: 986fcdd0-93fe-441b-2a55-08daef8a275d x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: UO60F1oygaASK8cIWlOWwo2CZUW1CIWOFJHLq65K7AMuKEwnpsQEaT+BSgFAKXWMB7dOVE6FtEqxoCzBCGa1xCiqSZGmzU1MouOi2w8EvFkJtBM9sguQhXDzLRtlp1xbn7brNLgceGQJfFlTISlZ2tw21ToTwoaea0haD/dUnuX9O+C9Lq/1MR3UYzrNY5e9iKcDVUQGj8TXtExsEfFG075rMu9z0nfOMpGzKfiUNlxdgibgK4Yr2j448in5TwFD/cBp/UguiJUPNyaSu+ery6nMIsrEgGfa6rq6BcDn5r0UxBSF9Yss3425fMlei8k+seDYCWZtAd4WlOhy4SWpp2fhkNlDKIf79PX/cMIYKtd3BpIYCSFX0W3uzGxg0nVqWr1bXBiz2Bh1dqK29gG2TRLisBzau9oVkfgFhdCuSmjQW1T5FQAPO0eMHZrq8Ha6MQzfBDWkxcqCrcoqYVX36e7b0ZXEUndNsvCL25rn0wT0U4xeNoqBENXIW90iDBOkbM9h61houq9OiXAlUu7ugo4CNnVW1qsYfucFTFtB3B+WxTsRc0VfMoq4O1RsYyBbv1sY/Pa0tWZnqn36bQ2Shaidrfovl+esNUVZ4JbgluizbxQ5WxEyH8sNDA1kGixYyNE/WcIYu/ouweILwT82eBnhNqBEH0sl7/taSSdYezvXB8GQTRx7MPikEqDvwVmpMoCQkVFORwUOPN7JYziw2YGwzRviOacGrIrOn2g45JmBL+bE8ZnkUyAa4zE5alBRIII1OtWKlVNmkO1eQv4Opg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(39860400002)(396003)(376002)(136003)(346002)(451199015)(5660300002)(4326008)(8936002)(31686004)(8676002)(2906002)(41300700001)(71200400001)(66476007)(64756008)(66446008)(91956017)(66946007)(66556008)(316002)(54906003)(110136005)(76116006)(6486002)(478600001)(6512007)(6506007)(2616005)(186003)(83380400001)(107886003)(26005)(53546011)(122000001)(82960400001)(38100700002)(31696002)(86362001)(36756003)(38070700005)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?d3pGZnI3NjJ6SGxqenpwQk1pcXVEbnBGQlA1aGVzL1RTTnNNcGF3bDkvazAr?= =?utf-8?B?Z2t5ZWk5RkVGOEduOXc2clhTK2x0cWtwakt5QkY3YklyQXNzamRaSVhQaWxK?= =?utf-8?B?eGZBbTE2NnV4NHN5RVhwM2trVDFEcUdoUnJTQ2JjMnEvWkVvb1k4bmUvN1Ji?= =?utf-8?B?YXlNb0NvMkVBcHFBY21KSjRRTFB1TjhxT1lyLzRJek85dkZmZHpyMzZ1MWxr?= =?utf-8?B?bzhDSVBxQnJFUUlzckxtTGNoeUcyS3NuVzlkOTNOS0ZBSzk3TnorY3pSWGtu?= =?utf-8?B?V1FtRUlOUWtpTnE4ZEVnOGZYanBmRnFnVng3b3BCeGwxK0RjcVI5WU5jemFY?= =?utf-8?B?dmdHTVhzMEsrSUdwc2liSW1NMDdjZkFwdWdVTzFLZGdxRkdGWGR3Y1lYWHVs?= =?utf-8?B?K2RHTWxUdDRqQkVKNS9tN0pPMlVzeFVnUzMvSjdnRG93UEdjQW9hVmdQdWEy?= =?utf-8?B?a3lNQ2tYTC9UbFZ3VGFwRTAwaTN0dHJJS3gvYUl4cHZ1SEpZNHBqbVBIOHI0?= =?utf-8?B?cmJkUFJvQzk2MzErWDQzMnpPMFpraHBYM1dZOEdlNUl3dXRhQVdJWWVUYW03?= =?utf-8?B?cHdhSTloOHVucU5JN1RxNnJ6TEw1RHJMSnlpYTlEY2xIRktjNWZYRW8yc2Fw?= =?utf-8?B?bzEvZ1RRd3huQkUwVGFPemgwazgwYmZXNFJiWmhhcUw4Z2JFTXk0REpRdlVE?= =?utf-8?B?YVl6YUZrNTlXYStEbVQ5UHZsTmVTb0ZtVDU2NWRpb2t1M0JFQ0xSU3dnN0lJ?= =?utf-8?B?citGbEloOXBUK2R3dHZLeTRaKzVWeFNwMEVveFVpSm52Y1FYdVJWdlgvNGd2?= =?utf-8?B?RE5IUEd0RDFTVGtza1o4UGlwZmxPTlJmZy9yY2N6L2dNa08vdHJybEFlMlFt?= =?utf-8?B?Qm93ckhGZnFBbGZVbWg3bDRJekw5ZmNOanVWSFlsVk9oTzVuQUtrcTlKS0V3?= =?utf-8?B?aEhJdlFVbjBLZ3ZkdmsxN0o3Z1F0Ly9jcHpOT2h0S3ZwNDhlOFloZXJ4ZFh4?= =?utf-8?B?Nk1vRjFqdnBXOG52enJYVWlwSGJQZ1I5cXJJTzhPb2svYlhkOGFldWcyNjVP?= =?utf-8?B?RzBxdjFHdHhpR0pudEYzZEFLWTE3eUo0S3lJSXo0VUZQMmRxVjJtTHR5SjNQ?= =?utf-8?B?NzZYZmpHbXpqWkZ4bDV4dm54enJuQk1SRjBIYnNzWkdXNUJlNVp1bnFOdmRV?= =?utf-8?B?OThBU0xzRktMeUhPVVQrWmI0ZkJtMitTdW1SaGplMlBmUU14Y1JvUHlqTzNR?= =?utf-8?B?VjhMeGlwKzZxOUtuNDljMDlDVUJlWUZQTEsrNkIvT0Zua2Z4eU5oNnZ6LzNJ?= =?utf-8?B?NytFSDBOaTcyWU5kNmxuUWY1aEhENWQrRXcrRFlDa0xmd3d2SUpBK2FtRlpp?= =?utf-8?B?REMwZWlicXJqSzUyVEZkVFU2U0hyRTBIY1duZTQyNCtvQWlkdHJ0TnlVN0pH?= =?utf-8?B?ZUFuUGFPSnJBZzc3WG53SFRKTlNzOFBFM1ZJc0VFKzdJK3AvUk9PS0VGcmNT?= =?utf-8?B?QVpBYVBGVEpkSkdyU3VXckxuNVZmVXZyS1JZaUx1N2ZXelBhSm12dUxFazNv?= =?utf-8?B?V3o4M2pmUEJGQlR2RytmMlV2RTdWMUpKVlpxRnFibk4wTDRHK1ZBdCsxUVc5?= =?utf-8?B?MWJFNnk5M0ROYk5rUEFVSlFjZmlvTDl2MnZ3WisybnF6d3ZkeHVQb0hVRGN0?= =?utf-8?B?alBneVYvQ2JIdXU3eGlMYlNLemVMUy9SMk9jTG5UdU9CSmtlUEVqWXp2NmV6?= =?utf-8?B?RTdCZGZQUUhWc2F2amh1NVYzNXpiMVYzT1ZnYWdpN3RUMUt1TFQ1MWNXWWFp?= =?utf-8?B?eGR0czdWeUxyMk1FREJkN25LZGZkWTJNek9YVG5yM3ptSE5iVjFkaG5jNDlx?= =?utf-8?B?Rmc1T1JTNWl3M3hkU0FSOUpUbFZ5TWlDek9uZHRvRWJGS3JqVE1aWFZFbll5?= =?utf-8?B?QU5MejdOaEJhSUovTVZYaTVjZm5yU3ZPaEF2dStXaG5yOXloVmRnMmtjdUdp?= =?utf-8?B?UUttTXliU1cxQllXNm1Zb3FJNklBR1g1ZllKbjRPTXlha3BtdTV3czB3bVJx?= =?utf-8?B?aVQ4ZFNVNk92ZXU3azVJMU9Oc2lOT25oVWpWMFZ2WGtad01uellLZUVsVi9S?= =?utf-8?Q?VTuy5xi5PbT8KiF4WVuXHk7hL?= Content-Type: text/plain; charset="utf-8" Content-ID: <05F2A68EEA9AAE40863E4275C0D8C0AB@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: uPliLEFzi9zAh3hyMJKsfd2OAcurMonT71C7nDk5U6tyneRv7pOoM8c50mEqwsQpiVctLwcjZCOfNFQgpqOsc0ldfQCaWmnBV7M6NNSotTcuTHzDpc1a8HvXnScy3BThYLsur/IjAtA2wekIE+nWknu3rCQc+ZPUBmEPOIwCN9lkbuGr0LcyibP79mtqRqGI6lldlL579kPYxiWviJDXlZXOdjsfQODl1a8TOYQKNxkpd2x1s3nuBFEMxMWgF+3aQyFp8PY9liDncxikd01HcvNXy/pkQEXyzg8PJdklyxZ3KQkF1oKHTedLQytEVZNmDYRFlaAeXrevwF3h5sk9oAQJzRfs2pgwM0GA8oCG48W1v1JxPev6djSGiqlzViB4jfoDElrzSXy5QsATk4cwlrFoKBofsON8v1YyDgSbEPZWbc2O0D73wVrTBfxPu3NjH/sGuwdHUrO9oxUn0rmVqB7ml7TwvRLUKO/pV66B/UdrulXAKUY58dDa52eCyZfuYKkRgkKDMLJTW70n1vBW8ienMUNx87tB9vnekAXv9uBbGlBS8qQs8xmgZiaPrB9nVKIhlIVFTgB4bJeuinTn6ks/h7GQAGqBQID/Y8LWvkd3pecs/d/JCrRpxg0PKcvY95zEp48ZWQsCa0946m1IBJKjxs+YRF5bfDttawypQ/YQNw2K9cnE8m7WCDP+0wRsZymtqK2bTiHsiqWLBHe9a+iTgDbsJZ93cIaeBZZSZgH/wZCX92d+Nb6gzuos0P7wRxaBiVPmTZdYzOkG8dXpjd4kXcOgYlZs5ORTylG7PICEvl7BHzHZko+A2ALehAJ47dBpdjTgvxwthkZ+8kKiuw== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 986fcdd0-93fe-441b-2a55-08daef8a275d X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jan 2023 02:03:07.1132 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 92bAOolrs6jF9bwbErrfI2bwccOSB9RiWSNCf/QxmfVmXxQ69/ZFSlNBMSF5Dhldy5apQEUkxt7Nnz4wV2wWJgf7QllBpV2cAYx/FiveGTI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5162 T24gMDUvMDEvMjAyMyA0OjA1IHBtLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gVGhlICJuIiBpbnB1 dCBpcyBhIEdGTiB2YWx1ZSBhbmQgaGVuY2UgYm91bmRlZCBieSB0aGUgcGh5c2ljYWwgYWRkcmVz cw0KPiBiaXRzIGluIHVzZSBvbiBhIHN5c3RlbS4NCg0KVGhlIG9uZSBjYXNlIHdoZXJlIHRoaXMg aXNuJ3Qgb2J2aW91c2x5IHRydWUgaXMgaW4gc2hfYXVkaXQoKS7CoCBJdCBjb21lcw0KZnJvbSBh IHJlYWwgTUZOIGluIHRoZSBzeXN0ZW0sIG5vdCBhIEdGTiwgd2hpY2ggd2lsbCBoYXZlIHRoZSBz YW1lDQpwcm9wZXJ0eSBXUlQgUEFERFJfQklUUy4NCg0KPiAgVGhlIGhhc2ggcXVhbGl0eSB3b24n dCBpbXByb3ZlIGJ5IGFsc28NCj4gaW5jbHVkaW5nIHRoZSB1cHBlciBhbHdheXMtemVybyBiaXRz IGluIHRoZSBjYWxjdWxhdGlvbi4gVG8ga2VlcCB0aGluZ3MNCj4gYXMgY29tcGlsZS10aW1lLWNv bnN0YW50IGFzIHRoZXkgd2VyZSBiZWZvcmUsIHVzZSBQQUREUl9CSVRTIChub3QNCj4gcGFkZHJf Yml0cykgZm9yIGxvb3AgYm91bmRpbmcuIFRoaXMgcmVkdWNlcyBsb29wIGl0ZXJhdGlvbnMgZnJv bSA4IHRvIDUuDQoNCldoaWxlIHRoaXMgaXMgYWxsIHRydWUsIHlvdSdsbCBnZXQgYSBtdWNoIGJl dHRlciBpbXByb3ZlbWVudCBieSBub3QNCmZvcmNpbmcgJ24nIG9udG8gdGhlIHN0YWNrIGp1c3Qg dG8gYWNjZXNzIGl0IGJ5dGV3aXNlLsKgIFJpZ2h0IG5vdywgdGhlDQpsb29wIGxvb2tzIGxpa2U6 DQoNCjxzaGFkb3dfaGFzaF9pbnNlcnQ+Og0KwqDCoMKgIDQ4IDgzIGVjIDEwwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqAgc3ViwqDCoMKgICQweDEwLCVyc3ANCsKgwqDCoCA0OSA4OSBj OcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIG1vdsKgwqDCoCAlcmN4LCVy OQ0KwqDCoMKgIDQxIDg5IGQwwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg bW92wqDCoMKgICVlZHgsJXI4ZA0KwqDCoMKgIDQ4IDhkIDQ0IDI0IDA4wqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqAgbGVhwqDCoMKgIDB4OCglcnNwKSwlcmF4DQrCoMKgwqAgNDggOGQgNGMgMjQg MTDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBsZWHCoMKgwqAgMHgxMCglcnNwKSwlcmN4DQrC oMKgwqAgNDggODkgNzQgMjQgMDjCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBtb3bCoMKgwqAg JXJzaSwweDgoJXJzcCkNCsKgwqDCoCAwZiAxZiA4MCAwMCAwMCAwMCAwMMKgwqDCoMKgwqDCoMKg IG5vcGzCoMKgIDB4MCglcmF4KQ0KLy0+IDBmIGI2IDEwwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqAgbW92emJsICglcmF4KSwlZWR4DQp8wqDCoCA0OCA4MyBjMCAwMcKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGFkZMKgwqDCoCAkMHgxLCVyYXgNCnzCoMKgIDQ1 IDY5IGMwIDNmIDAwIDAxIDAwwqDCoMKgwqDCoMKgwqAgaW11bMKgwqAgJDB4MTAwM2YsJXI4ZCwl cjhkDQp8wqDCoCA0MSAwMSBkMMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg IGFkZMKgwqDCoCAlZWR4LCVyOGQNCnzCoMKgIDQ4IDM5IGMxwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqAgY21wwqDCoMKgICVyYXgsJXJjeA0KXC0tIDc1IGVhwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgam5lwqDCoMKgIGZmZmY4MmQwNDAy ZWZkYTANCjxzaGFkb3dfaGFzaF9pbnNlcnQrMHgyMD4NCg0KDQp3aGljaCBkb2Vzbid0IGV2ZW4g aGF2ZSBhIGNvbXBpbGUtdGltZSBjb25zdGFudCBsb29wIGJvdW5kLsKgIEl0J3MNCnJ1bnRpbWUg Y2FsY3VsYXRlZCBieSB0aGUgc2Vjb25kIGxlYSBjb25zdHJ1Y3RpbmcgdGhlIHVwcGVyIHBvaW50 ZXIgYm91bmQuDQoNCkdpdmVuIHRoaXMgZnVydGhlciBkZWx0YToNCg0KZGlmZiAtLWdpdCBhL3hl bi9hcmNoL3g4Ni9tbS9zaGFkb3cvY29tbW9uLmMNCmIveGVuL2FyY2gveDg2L21tL3NoYWRvdy9j b21tb24uYw0KaW5kZXggNGE4YmNlYzEwZmU4Li45MDJjNzQ5ZjI3MjQgMTAwNjQ0DQotLS0gYS94 ZW4vYXJjaC94ODYvbW0vc2hhZG93L2NvbW1vbi5jDQorKysgYi94ZW4vYXJjaC94ODYvbW0vc2hh ZG93L2NvbW1vbi5jDQpAQCAtMTM5NywxMyArMTM5NywxMiBAQCBzdGF0aWMgdW5zaWduZWQgaW50 IHNoYWRvd19nZXRfYWxsb2NhdGlvbihzdHJ1Y3QNCmRvbWFpbiAqZCkNCsKgdHlwZWRlZiB1MzIg a2V5X3Q7DQrCoHN0YXRpYyBpbmxpbmUga2V5X3Qgc2hfaGFzaCh1bnNpZ25lZCBsb25nIG4sIHVu c2lnbmVkIGludCB0KQ0KwqB7DQotwqDCoMKgIHVuc2lnbmVkIGNoYXIgKnAgPSAodW5zaWduZWQg Y2hhciAqKSZuOw0KwqDCoMKgwqAga2V5X3QgayA9IHQ7DQrCoMKgwqDCoCBpbnQgaTsNCsKgDQrC oMKgwqDCoCBCVUlMRF9CVUdfT04oUEFERFJfQklUUyA+IEJJVFNfUEVSX0xPTkcgKyBQQUdFX1NI SUZUKTsNCi3CoMKgwqAgZm9yICggaSA9IDA7IGkgPCAoUEFERFJfQklUUyAtIFBBR0VfU0hJRlQg KyA3KSAvIDg7IGkrKyApDQotwqDCoMKgwqDCoMKgwqAgayA9IHBbaV0gKyAoayA8PCA2KSArIChr IDw8IDE2KSAtIGs7DQorwqDCoMKgIGZvciAoIGkgPSAwOyBpIDwgKFBBRERSX0JJVFMgLSBQQUdF X1NISUZUICsgNykgLyA4OyBpKyssIG4gPj49IDggKQ0KK8KgwqDCoMKgwqDCoMKgIGsgPSAodWlu dDhfdCluICsgKGsgPDwgNikgKyAoayA8PCAxNikgLSBrOw0KwqANCsKgwqDCoMKgIHJldHVybiBr ICUgU0hBRE9XX0hBU0hfQlVDS0VUUzsNCsKgfQ0KDQp0aGUgY29kZSBnZW4gYmVjb21lczoNCg0K PHNoYWRvd19oYXNoX2luc2VydD46DQrCoMKgwqAgNDEgODkgZDDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoCBtb3bCoMKgwqAgJWVkeCwlcjhkDQrCoMKgwqAgNDkgODkgYznC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBtb3bCoMKgwqAgJXJjeCwlcjkN CsKgwqDCoCBiOCAwNSAwMCAwMCAwMMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIG1vdsKgwqDC oCAkMHg1LCVlYXgNCi8tPiA0NSA2OSBjMCAzZiAwMCAwMSAwMMKgwqDCoMKgwqDCoMKgIGltdWzC oMKgICQweDEwMDNmLCVyOGQsJXI4ZA0KfMKgwqAgNDAgMGYgYjYgZDbCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoCBtb3Z6YmwgJXNpbCwlZWR4DQp8wqDCoCA0OCBjMSBlZSAwOMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHNocsKgwqDCoCAkMHg4LCVyc2kNCnzCoMKgIDQx IDAxIGQwwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgYWRkwqDCoMKgICVl ZHgsJXI4ZA0KfMKgwqAgODMgZTggMDHCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoCBzdWLCoMKgwqAgJDB4MSwlZWF4DQpcLS0gNzUgZTnCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBqbmXCoMKgwqAgZmZmZjgyZDA0MDJlZmQ4Yg0KPHNoYWRv d19oYXNoX2luc2VydCsweGI+DQoNCndpdGggYW4gYWN0dWFsIGNvbnN0YW50IGxvb3AgYm91bmQs IGFuZCBub3QgYSBtZW1vcnkgb3BlcmFuZCBpbiBzaWdodC7CoA0KVGhpcyBmb3JtIChldmVuIGF0 IDggaXRlcmF0aW9ucykgd2lsbCBlYXNpbHkgZXhlY3V0ZSBmYXN0ZXIgdGhhbiB0aGUNCnN0YWNr LXNwaWxsZWQgZm9ybS4NCg0KfkFuZHJldw0K From xen-devel-bounces@lists.xenproject.org Fri Jan 06 02:04:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 02:04:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472283.732454 (Exim 4.92) (envelope-from ) id 1pDc5Y-0005t4-1o; Fri, 06 Jan 2023 02:04:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472283.732454; Fri, 06 Jan 2023 02:04:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDc5X-0005sx-Uw; Fri, 06 Jan 2023 02:04:07 +0000 Received: by outflank-mailman (input) for mailman id 472283; Fri, 06 Jan 2023 02:04:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDc5W-0005LO-1i for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 02:04:06 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 64263892-8d66-11ed-b8d0-410ff93cb8f0; Fri, 06 Jan 2023 03:04:03 +0100 (CET) Received: from mail-dm6nam10lp2107.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.107]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 05 Jan 2023 21:04:01 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DM6PR03MB5162.namprd03.prod.outlook.com (2603:10b6:5:24a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Fri, 6 Jan 2023 02:03:59 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5944.019; Fri, 6 Jan 2023 02:03:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 64263892-8d66-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1672970643; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=ZHeOMSQywW2NTLeKBWaSVPj0grpZVg+YVmImQT2V6Uo=; b=iAK4+TIk7ZZ/pk0q0ikgq8cx7A7/5xDfNIowJrCLod3KsypndzUXhE1g ByHIbi8vi2mICf/Zcenv5gmclwNQRnQLXIyzx35HtAadT8jOEqslgR1M8 wkpQ0oPFdvsST9wVrslykwf1xkjdQOZUivS1uMzRX9z6deoZPjGoqRBH9 o=; X-IronPort-RemoteIP: 104.47.58.107 X-IronPort-MID: 91823839 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:Xy5d+aCDG/WEBhVW/xjiw5YqxClBgxIJ4kV8jS/XYbTApDMq1T0Fy mpMW2HXO/uNYDanfI1yPNyz8U8B6pDVxoMyQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nNHuCnYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtcpvlDs15K6p4GpA4wRlDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIwwvswW2ZXs s0heBdWcEu8juyTw4uHc7w57igjBJGD0II3nFhFlGmcIdN4BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI9exuuze7IA9ZidABNPL8fNCQSNoTtUGfv m/cpEzyAw0ANczZwj2Amp6prr6WzXmgCNlDfFG+3tpSvgOr23IyMh8be3KjvPKrulWuCvsKf iT4/QJr98De7neDTNPwQhm5q36spQMHVpxbFOhSwBGAzO/Y7hiUAkAATyVdc5o2uckuXzso2 1SV2dTzClRHr7m9WX+bsLCOoluaJSkQBX8PY2kDVwRt3jX4iIQ6jxaKQtM9Fqew14XxAWupm 2/MqzUijbIOi8JNz7+84V3MnzOroN7OUxIx4QLUGGmi62uVebKYWmBh0nCDhd4oEWpTZgPpU KQs8yRG0N0zMA== IronPort-HdrOrdr: A9a23:Y2b5N6pNurjA8vGv/2n3SOEaV5oaeYIsimQD101hICG9E/bo9f xG+c5xvyMc5wx9ZJheo6HlBEDtex/hHOdOkO4s1NSZLWrbUQmTTb2KhLGKqwEIfReQygc378 ddmsZFZuEZ8jBB/KPHCQODYrAdKHDuytHQuQ7W9QYUcT1X X-IronPort-AV: E=Sophos;i="5.96,303,1665460800"; d="scan'208";a="91823839" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kXxZGYJTLZKwAG0Q5EA8XxDz9HOMkTmpeIgS8gbRrifJE3CfsgaOBXYuNhFmXvwxrNYGnE3CiSEI4UrBMwQEOcyWdSVcL1EYLkmJ670oE9dS94bGkZySlZaiUtdnfNJZUFg+lEaQC6eRfXos4y/zLLWTrXrvQufv4r8gf5pZRI0Fo+lg5jsouL8u5vEbmZMRa8tLUCjeCdavN9dVI5Q4+VWnDApXVSg4kIqQqbes4luxgaY7CkaNCJHt82zJacrKcM8SpZGKvvdQRXazS+z+t+PeAaTnPLIrGITX9wobhsLOFjZ2h/5GXLLxbyfXhyDH732qflND4C/cY0Uety/HXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZHeOMSQywW2NTLeKBWaSVPj0grpZVg+YVmImQT2V6Uo=; b=F4jc4xG86ipihN3KWfOT8ihmCHPSbT+Zofto1dc0KzSUOn5WhtMtUI4Ll246LVoqq5dwsLlHEy0t5jeIHA+yDjTj72NvtZZdpkroj3Ea7pdrijlpxFZ80kQ4Y7TldeALk70QdkNx5hkN8Y/ajKaFemcqwBpKIVA5KokMUex9Mx09xcRHwTQ8ohpxtACGwpTjzxYwmkaaz+5UAj1zkseOM/rScKIvf+P3NcIKaSH+ZYEiXL8DCa7I3tM7k/mI2293odg1acRcTCJ3z+Vkd12LufFHx3fMmeZwgXSXXiwQAj9ki27J0dWOnW4rBJwbAR7qCQB59Awrp0HcWWxUdixi1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZHeOMSQywW2NTLeKBWaSVPj0grpZVg+YVmImQT2V6Uo=; b=KZoHF1BSiVE1njAGPTjjpTq4yyCO2ZR+TO7qswTyFUEYLeT9adH64iNbdtykn9ga6p9o30bmmWej/PJcbaxbDmYrL6XCNJULLlFKCHqTWrbr4GXcG2XrGhRbbwabuzd85YMFXyGlDWZ55F84YmDMt2EWJIK56qRjbBqHB/MFY4s= From: Andrew Cooper To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Wei Liu , Roger Pau Monne , "Tim (Xen.org)" , George Dunlap Subject: Re: [PATCH 00/11] x86/shadow: misc tidying Thread-Topic: [PATCH 00/11] x86/shadow: misc tidying Thread-Index: AQHZIR54p1+0rBg1XUyPGnzUS/cXvK6QpAqA Date: Fri, 6 Jan 2023 02:03:59 +0000 Message-ID: <2e261172-76b3-936d-e95c-e12ed6acf7bd@citrix.com> References: <074dc3bb-6057-4f61-d516-d0fe3551165c@suse.com> In-Reply-To: <074dc3bb-6057-4f61-d516-d0fe3551165c@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|DM6PR03MB5162:EE_ x-ms-office365-filtering-correlation-id: 2c48cc74-d03f-4fe9-d4e9-08daef8a46a9 x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dz5fwdiBu9cLqBv14/BMXOXc3QxZPzIsc0yARruOdDRnUTYZWNPABrp9baAWxoirtFzTnw9NP/mJE4cEVHt6L+pGP5giTi2uHQMSuwHuJnLt+A+/pHh/DBFpVENBv2V1Kqj6cjPr38aAAqJZzhHXJvZ55YzvFGoDp6kvbZ/mFW77bNN5RJ0firuH8fWXH9Ho2pJhlqFJRfORBCLMSMN7MI6k5eiGtTgxmAaujXOlKvzBYC/K5FsQW6FJGiBeldU/SCQjPaQ/Si/Tw12slllSZ0FUcXtYufeYw9/fFqxM/He/DTckVf0Z2mGnnTNt0JwSc1jpC+yTNHBviBXLfuENnlo3pQJK3lifBFNeCvvwrBF749L2x5rHkTZaUky7JXf6G9kme7DkwA5FPknrk9mXvcFWs/xvs1pyET/6UT0L1X9PqDAJUyfwmD5yxh/KcyzedzffkkmZ+IZEl61wiVR711/9rhkHl21mGQI6zABd4Q3YRjpM9EdpYDerymkxlvODFEv71rh0bRlf7H9bnLqfbxXqXoq4ksXEXjOclc6SnuO2ZrXLyT1s2SqdarZP7winZ1dY31g1ZGURhq+tJxBvgdGL+tCcHyxGpQgxkobOpZ2uI8Fm9iuc97eQGTZnOj+1rpV/P0yXZZjpOyMdYXpe/1QYSIFSRUCSLzngGpq38zoVKgO56YMCZ+sTnG7YklT1saJpq9N3XmPYkknY3IngH0AtD9msURd1FyXvcveKDM+Q0XohMOIRD9xy4b0lIIJLvYw0L61fJrWn9FIGYTWjBg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(39860400002)(396003)(376002)(136003)(346002)(451199015)(5660300002)(4326008)(8936002)(31686004)(8676002)(2906002)(41300700001)(71200400001)(66476007)(64756008)(66446008)(91956017)(66946007)(66556008)(316002)(54906003)(110136005)(76116006)(6486002)(478600001)(6512007)(6506007)(2616005)(186003)(83380400001)(107886003)(26005)(53546011)(122000001)(82960400001)(38100700002)(31696002)(86362001)(36756003)(38070700005)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?WXNpZDV3RGJBWnFYWTN5dzlWYmozS09lMG4wS3l2VlRYdGMzVTZvSzdPVll6?= =?utf-8?B?QVV2enE4Wm1zbjdpcUVjcnNTRGdNWW5PSy9Ya2h5QzlzdUVmTHdUcUkyWXF3?= =?utf-8?B?Y0F5V3dhR3JOSnFXZzl0bHpsSDA0Sk9PNWttRkdjYVBDUnNwSWM2dENtWnV1?= =?utf-8?B?a2Fud0xySDZIZ0ZGbDI2MVZyTVhKNERTUzVjR25uZzVFc3NkQ3FWUlduN0Qz?= =?utf-8?B?V3ZEMXdZTVZKWThTcWZUK3M0MVhzOE1URlNNZG1uR2ZTa0J5MExWK013T0Vi?= =?utf-8?B?RnViWjBsdG1XcmVXKzZxb3pSM3RZcUFJU2Q3WjFZSnRaek56a0RNZU8zSlBL?= =?utf-8?B?aDRHV2diQ2RYQWxJU1ZZQWlnS0FQQ3BLN2poMTJxWUFiOS82cTFoL0tpZGM4?= =?utf-8?B?SVl5RVZiOUxLdGc2ZktUODNFd1lJOVpVRjBaZmJQbS9VVUtqb0Zoajhuc2ov?= =?utf-8?B?L1RPN2VjbThCMC8rSG5TbzlYUHlJSS8zSGlGYlpjc2xvNDV6eVRHZGN3MUw1?= =?utf-8?B?MGJmclBJeWZnT01UYy9wSkUxQjVHbE45WUQvV1lTbzVBdDc2YlU0YzVFeWh2?= =?utf-8?B?NEJYS2pIdzZTTVdSZWJtYXgwWmlOM0c3VzRWcjVaYVpMUjF4UjRTdEhReERn?= =?utf-8?B?ZHJjNkoxT0ZzK2VFd2VEU2cyL2c3UTF5Q0lrcHY2TnAvNjVMK290TGRSZHJO?= =?utf-8?B?WUNlRDMxOTU3MzFxY3cwejBudHFMY3FRM0RDZUdrSENmdGt4bEw0UnJYZjl0?= =?utf-8?B?ZEtlS0ZPYjc3ZXMyWTRVbUx3YS9MSHAzWU1kU2dVaS9xdXg5dEQ4dkllL2ox?= =?utf-8?B?L2I1L014K09LR3hhT1RtN1podjBaVU1XQzEybEdGT0ZrcEs5QkJ4bXhJbTlV?= =?utf-8?B?cElGQ2h5bDdHTzNPVGNCTVhlWWZnWWV3VWUvRUgwSGJTazl4TEJSeFhMeFJI?= =?utf-8?B?VzVyREJZcFAzY2FwYTQ5eWhBN1FHUjNGR3JiZ04xRFV3N3FLU1ZaSllaSmU0?= =?utf-8?B?c3pLUERXOElFektYVGRFOU5iWUprRGJVRXRpUEp4SVJPRzk1SkNYRHBjci9n?= =?utf-8?B?MGNPMm5qb2g3ejdFaGtLQnlXVFdvbEZ5WHpjWTc1S0xMM0pMZ281UW1tSU5o?= =?utf-8?B?a0FDdk8rblM5Rm5WcUYzY1RhZFBGWm9vcmZ5TUdodTB0RXBQZnF1cnVTNngz?= =?utf-8?B?bUV2YmtFK3RTQ3ZUSVc0Kyt6RUtuYnpiblEzZDZpNk9OYmMrWktmbEFOZEpH?= =?utf-8?B?NHV2djFjcUdhbTBxS2hUWlAvNjJ6OUlrZVBEakRqVHl0UjF4Yk5TcTdpR3Uv?= =?utf-8?B?ZmJNWnZBRXl6aERNRU9Fcjk5bjlMRTAwSTV5U3ozTnhVT2x5QkNlemxTbjM1?= =?utf-8?B?VXJiVDRGdFB3OFJ2dzlMOHRROHd2V2tjMzR1WGx1aG90NHl4UWFMcFpYUVlh?= =?utf-8?B?Yk9RR2JPend2RTd3ZE1mMFJuS1dvVllpdHM3UTRqdFZKbWlick9Wdmp5VlJE?= =?utf-8?B?dFV3MUMrYzFrNlg2WExrbDFqK0J5OFZWeWJldXlDNzBHa21USkExbUx4ZlJE?= =?utf-8?B?WlFnbDRyZ3Z2NU0rYkZZbUgrK1RjUk9jMXNGMUo0cFR2ZnpQUU50WmRTaTlF?= =?utf-8?B?TzhKaGE1U3NKdTRidi9naW14aUlNQU1CNGIwaXJtSC8vTGhTK1dNUHVDMkxj?= =?utf-8?B?S0JjSHQreVR0eE03SXVVa0FwcFcyTEVEY01LOHFKT1BtVTNkeGZ6dld4LzZr?= =?utf-8?B?cjVRR2pDV1dWRFF4dElJbGtWTHpUVFpmYy9yZnJoY3pJWk4yU2NCSm9rdUFk?= =?utf-8?B?alFVdVN2bVVuajQyb2QrWDVaOWtZUy82dFJOSXZQSXRldU93NGtJd2ViNnNJ?= =?utf-8?B?SldvL3dCMXQvTTNXdmN5aTVtYmZiT3dSNWorcERwVGFaaGF0cWtOU1MwVHEw?= =?utf-8?B?VW11WWNIa2RDcm1SUGV0cmFUOERCdkliTHdYVlh1UHlhc1VuZ1UxZENjSmpz?= =?utf-8?B?S0t4YmdURG1RZi9PTlhqaTVFQVRzUHFmM3QxaHJhUFN6QmNBY0E1ZysvSFRq?= =?utf-8?B?UUpwU1daT1p6N2FCeDhIdEUyc3RPcXU0UUcxMGlmOE80QnRlenVpc000T3do?= =?utf-8?Q?aJEvNMrgxEfIKhd70CKmi7tUh?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: wdfGT9vTdyWvZoIZk62splpgef0lKnxDHXkbPy2HA7xUtEPHGjbIVLzQDT+boh7zBfSLj9ZDV3+tMNDmXxTScCiXykCZ8fXW2C/W0Ea3NjohGdDbm4Ug/aDqpEbQpNiNeOUdtT5LsV/e2dlJAH74DgPVWsqLhnzp+3UvLWBklQB7jIt6AEysVkgOnrcIE01XidF5WMh+t3ERP5JHfkRm5XPdcm6NIIfXYqYOb2ohCb/DCEdE8+Gl3okivv+BSJSlsu6j6KPHD81Mp3Kn2NH+AOBBOtHF+Ni6MYToAvusRx0TfdyqR5orcBdIGfmqfIIXaGklPVn9i4uKNRY94ScHb3sjoa308CyZr7NTNIfhizo7jc+wXn0ZnSz93VWMKsNAj5oiqbDysszX4A+qdt4FSLgPRB4X0bezEaFqhAs+7yKi4EKqw0oAYFSUc7XNcps3146vyU7DfJRaNDxmMGswBsoADMqvXg7/uniEHR+n/aWksNlbaWfxbmT/nrDZZLXCk2/GcVTCUQUTNxkjbJVgLHiGqBeM1LgNkuu8ixQnH4xlm3m9OL6D7efbTLM4frWOyFTFh0Uzprn7cPdYZYImT6qfRDXq124clI4cMsitBpOtUn9kC8XbbrWL/fdDzMQgvuYr1YtgQynOwqj3E5W5zdPiYMIS7xNC/J1KYT+eWMMTL7Gw3MzPwQcjCfs1zpTLiurYGFlLWEchkRttDvZAzMvIZbbWvHXSGYj6xuRx3c5wAu6+hn+cBcDfyQXD8eK8yCijsdffjJpLgdS41PJtgVs1DqvSlXBPmKM4kskamlo/3g80sG5pmHp22XbmWMzZKvntj37heTS+A2brCfEYSg== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2c48cc74-d03f-4fe9-d4e9-08daef8a46a9 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jan 2023 02:03:59.6094 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: n6BTaOhygdNgILOORG6vr6r/ecbiEQdNOQyxGgWPx4G6HC37lnhzX+nKdjGwE0P49bHa4viw039Gxoj6QC3ChSmp/Rjq978Cyc0t7ybkhGE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5162 T24gMDUvMDEvMjAyMyAzOjU3IHBtLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gLi4uIG9yIHNvIEkg aG9wZS4gVGhlIG1haW4gb2JzZXJ2YXRpb24gd2FzIHRoYXQgd2Ugc3RpbGwgaGF2ZSBib3RoDQo+ IGhhc2hfdmNwdV9mb3JfZWFjaCgpIGFuZCBoYXNoX2RvbWFpbl9mb3JfZWFjaCgpLCB3aGVyZSB0 aGUgbGF0dGVyIHdhcw0KDQpmb3JlYWNoDQoNCj4gaW50cm9kdWNlZCBpbiAyMDE0LzE1IHRvIHJl cGxhY2UgdGhlIGZvcm1lci4gT25seSBzb21lIGVpZ2h0IHllYXJzDQo+IGxhdGVyIHdlIGNhbiBu b3cgY29tcGxldGUgdGhpcyBjb252ZXJzaW9uLiBFdmVyeXRoaW5nIGVsc2UgYWRkcmVzc2VzDQo+ IG90aGVyIHRoaW5ncyBub3RpY2VkIGFsb25nIHRoZSByb2FkLg0KDQpXb3csIGl0IGhhcyBiZWVu IGEgbG9uZyB0aW1lLsKgIFRoYXQgd2FzIHRoZSBzdGFydCBvZiB0aGUgIm1ha2UgWGVuIG5vdA0K ZmFsbCBvdmVyIE5VTEwgcG9pbnRlcnMgaWYgdGhlIHRvb2xzdGFjayBpc3N1ZXMgc29tZSBoeXBl cmNhbGxzIG91dCBvZg0Kb3JkZXIiLCBhIHRhc2sgdGhhdCBpcyBzdGlsbCBvbmdvaW5nLi4uDQoN Cj4NCj4gMDE6IHJlcGxhY2Ugc2hfcmVzZXRfbDNfdXBfcG9pbnRlcnMoKQ0KPiAwMjogY29udmVy dCBzaF9hdWRpdF9mbGFncygpJ2VzIDFzdCBwYXJhbWV0ZXIgdG8gZG9tYWluDQo+IDAzOiBkcm9w IGhhc2hfdmNwdV9mb3JlYWNoKCkNCj4gMDQ6IHJlbmFtZSBoYXNoX2RvbWFpbl9mb3JlYWNoKCkN Cj4gMDU6IG1vdmUgYm9ndXMgSFZNIGNoZWNrcyBpbiBzaF9wYWdldGFibGVfZHlpbmcoKQ0KPiAw NjogZHJvcCBhIGZldyB1c2VzIG9mIG1mbl92YWxpZCgpDQo+IDA3OiBMMkggc2hhZG93IHR5cGUg aXMgUFYzMi1vbmx5DQo+IDA4OiByZWR1Y2UgZWZmb3J0IG9mIGhhc2ggY2FsY3VsYXRpb24NCj4g MDk6IHNpbXBsaWZ5IGNvbmRpdGlvbmFscyBpbiBzaF97Z2V0LHB1dH1fcmVmKCkNCj4gMTA6IGNv cnJlY3Qgc2hhZG93IHR5cGUgYm91bmRzIGNoZWNrcw0KPiAxMTogc2hfcmVtb3ZlX2FsbF9tYXBw aW5ncygpIGlzIEhWTS1vbmx5DQoNCkV2ZXJ5dGhpbmcgd2l0aG91dCBjb2RlIHF1ZXJpZXMsIEFj a2VkLWJ5OiBBbmRyZXcgQ29vcGVyDQo8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4NCg== From xen-devel-bounces@lists.xenproject.org Fri Jan 06 02:30:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 02:30:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472291.732465 (Exim 4.92) (envelope-from ) id 1pDcUo-0000xo-A8; Fri, 06 Jan 2023 02:30:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472291.732465; Fri, 06 Jan 2023 02:30:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDcUo-0000xh-72; Fri, 06 Jan 2023 02:30:14 +0000 Received: by outflank-mailman (input) for mailman id 472291; Fri, 06 Jan 2023 02:30:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDcUm-0000xb-6F for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 02:30:12 +0000 Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0978b90c-8d6a-11ed-91b6-6bf2151ebd3b; Fri, 06 Jan 2023 03:30:10 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 9AD8632009B3; Thu, 5 Jan 2023 21:30:06 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 05 Jan 2023 21:30:07 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 5 Jan 2023 21:30:04 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0978b90c-8d6a-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1672972206; x= 1673058606; bh=68Gw4tH2z0Hvyc9UriftpU1Mlh3pagHOU2hiJGFdXPk=; b=i W4f5zzV1SWMlQpBjgBVF575l0EhACjoGMMNeSp2Afl4RsW3auT/hHPYHAs4Qfl3p jIyYA+iysxtMzq8h5ngwECGg+vU56kcZis1w6Rmx2JMbLCUOBJGf7bz3r5wCPlgY AyqzmZSPLC8OGrEM46Ce1xaWGpgtSrImNIyXCX0Vqi40lXioCQ1pLVOlsGYGjKP0 FhU2LJSZjH/XRms3LD27FBVplKl1pYaLc04bOOTzispT4LvcGSfNbB2gi59Q8diX mEuBbuV8KtKffd5NP/hMS11vChbxteDNhTqsQE+6lokdWdrGrrkkV4oMLVQW2BWz TzFLUnV9DmW0Kadh+0RbA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1672972206; x=1673058606; bh=68Gw4tH2z0Hvyc9UriftpU1Mlh3p agHOU2hiJGFdXPk=; b=ocj4/K24DPbrGGn2EIgJAchu3RIDPC9CmOmgnMziWQ0z zBl9jTuhCy9j2riO49ut2Bxj6sWcD1msVhnayV1VUmsDTNKtMISaq3F9uT04alkr EW7XVuLjDoypBCF8NuXWKpF/ioRXxs2P3ZUlSdXcqn7uyHRXZQEAlMJ3qP2LULjP lBlzNPn/ab1e0b6JWvzDH+9kuWvjrA2+/TAmTzDTSgYQKcpSyWqaMGoROIKlz74f t/VwO3W8hEG8AS2E7o2t/793VpDPe/ZFBsCDFac4Usaossc5XQsv8pjS/plEEwsY ulyhtLQt7CyDXlu3DZB7ry5DnzFN07AzQcu6UYvXPQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrjeelgdegjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefgudel teefvefhfeehieetleeihfejhfeludevteetkeevtedtvdegueetfeejudenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhes ihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Fri, 6 Jan 2023 03:30:01 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Demi Marie Obenour Cc: Andrew Cooper , "xen-devel@lists.xenproject.org" , Jan Beulich , Roger Pau Monne , Wei Liu , "Tim (Xen.org)" , George Dunlap Subject: Re: [PATCH v6 4/5] x86/mm: Reject invalid cacheability in PV guests by default Message-ID: References: <2236399f561d348937f2ff7777fe47ad4236dbda.1671744225.git.demi@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="eeQ5Sw3MESoZAt5D" Content-Disposition: inline In-Reply-To: --eeQ5Sw3MESoZAt5D Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Fri, 6 Jan 2023 03:30:01 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Demi Marie Obenour Cc: Andrew Cooper , "xen-devel@lists.xenproject.org" , Jan Beulich , Roger Pau Monne , Wei Liu , "Tim (Xen.org)" , George Dunlap Subject: Re: [PATCH v6 4/5] x86/mm: Reject invalid cacheability in PV guests by default On Thu, Jan 05, 2023 at 09:00:03PM -0500, Demi Marie Obenour wrote: > On Thu, Jan 05, 2023 at 08:28:26PM +0000, Andrew Cooper wrote: > > On 22/12/2022 10:31 pm, Demi Marie Obenour wrote: > > > diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-comman= d-line.pandoc > > > index 424b12cfb27d6ade2ec63eacb8afe5df82465451..0230a7bc17cbd4362a42e= a64cea695f31f5e0f86 100644 > > > --- a/docs/misc/xen-command-line.pandoc > > > +++ b/docs/misc/xen-command-line.pandoc > > > @@ -1417,6 +1417,17 @@ detection of systems known to misbehave upon a= ccesses to that port. > > > ### idle_latency_factor (x86) > > > > `=3D ` > > > =20 > > > +### invalid-cacheability (x86) > > > +> `=3D allow | deny | trap` > > > + > > > +> Default: `deny` in release builds, otherwise `trap` > > > + > > > +Specify what happens when a PV guest tries to use one of the reserve= d entries in > > > +the PAT. `deny` causes the attempt to be rejected with -EINVAL, `al= low` allows > > > +the attempt, and `trap` causes a general protection fault to be rais= ed. > > > +Currently, the reserved entries are marked as uncacheable in Xen's P= AT, but this > > > +will change if new memory types are added, so guests must not rely o= n it. > > > + > >=20 > > This wants to be scoped under "pv", and not a top-level option.=C2=A0 C= urrent > > parsing is at the top of xen/arch/x86/pv/domain.c > >=20 > > How about `pv=3D{no-}oob-pat`, and parse it into the opt_pv_oob_pat boo= lean ? >=20 > Works for me, though I will use =E2=80=98invalid=E2=80=99 instead of =E2= =80=98oob=E2=80=99 as valid PAT > entries might not be contiguous. If we're talking about alternative PAT settings, I'm not sure if they can be called "invalid". With the default Xen's choice of PAT, top two entries are documented as reserved (in xen.h) and only that makes them forbidden to use. But with alternative settings, it's only behavior of Linux parsing that prefers using lower options. When breaking contract set in xen.h, "reserved" entries stop being reserved too. So, _if_ that option would be applicable alternative PAT choice, it's only useful for debugging Linux specifically (assuming Linux won't change its approach to choosing entries - which I think it's allowed to do). > > There really is no need to distinguish between deny and trap.=C2=A0 IMO, > > injecting #GP unilaterally is fine (to a guest expecting the hypercall > > to succeed, -EINVAL vs #GP makes no difference, but #GP is far more > > useful to a human trying to debug issues here), but I could be talked > > into putting that behind a CONFIG_DEBUG if other feel strongly. >=20 > Marek, thoughts? With Xen's default PAT, #GP may be useful indeed, but it must come with a message why it was injected. > > > @@ -1343,7 +1374,34 @@ static int promote_l1_table(struct page_info *= page) > > > } > > > else > > > { > > > - switch ( ret =3D get_page_from_l1e(pl1e[i], d, d) ) > > > + l1_pgentry_t l1e =3D pl1e[i]; > > > + > > > + if ( invalid_cacheability !=3D INVALID_CACHEABILITY_ALLO= W ) > > > + { > > > + switch ( l1e.l1 & PAGE_CACHE_ATTRS ) > > > + { > > > + case _PAGE_WB: > > > + case _PAGE_UC: > > > + case _PAGE_UCM: > > > + case _PAGE_WC: > > > + case _PAGE_WT: > > > + case _PAGE_WP: > > > + break; > > > + default: > > > + /* > > > + * If we get here, a PV guest tried to use one o= f the > > > + * reserved values in Xen's PAT. This indicates= a bug > > > + * in the guest. If requested by the user, inje= ct #GP > > > + * to cause the guest to log a stack trace. > > > + */ > > > + if ( invalid_cacheability =3D=3D INVALID_CACHEAB= ILITY_TRAP ) > > > + pv_inject_hw_exception(TRAP_gp_fault, 0); > > > + ret =3D -EINVAL; > > > + goto fail; > > > + } > > > + } > >=20 > > This will catch cases where the guest writes a full pagetable, then > > promotes it, but won't catch cases where the guest modifies an > > individual entry with mmu_update/etc. > >=20 > > The logic needs to be in get_page_from_l1e() to get applied uniformly to > > all PTE modifications. >=20 > I will move it there, and also update Qubes OS=E2=80=99s patchset. >=20 > > Right now, the l1_disallow_mask() check near the start hides the "can > > you use a nonzero cacheattr" check.=C2=A0 If I ever get around to clean= ing up > > my post-XSA-402 series, I have a load of modifications to this. >=20 > I came up with some major cleanups too. >=20 > > But this could be something like this: > >=20 > > if ( opt_pv_oob_pat && (l1f & PAGE_CACHE_ATTRS) > _PAGE_WP ) > > { > > =C2=A0=C2=A0=C2=A0 // #GP > > =C2=A0=C2=A0=C2=A0 return -EINVAL; > > } > >=20 > > fairly early on. > >=20 > > It occurs to me that this check is only applicable when we're using the > > Xen ABI APT, and seeing as we've talked about possibly making patch 5 a > > Kconfig option, that may want accounting here.=C2=A0 (Perhaps simply ma= king > > opt_pb_oob_pat be false in a !XEN_PAT build.) >=20 > It=E2=80=99s actually applicable even with other PATs. While Marek and I= were > tracking down an Intel iGPU cache coherency problem, Marek used it to > verify that PAT entries that we thought were not being used were in fact > unused. This allowed proving that the behavior of the GPU was impacted > by changes to PAT entries the hardware should not even be looking at, > and therefore that the hardware itself must be buggy. In fact, I did that via WARN() on the Linux side, to _not_ have guest killed in this case, to potentially collect more info. As said above, with alternative PAT settings, the contract which entries are "valid" isn't there anymore, so punishing guest for using them isn't appropriate. It could still be useful feature for debugging Linux (and it feels, we'll need this feature for some time...). So, with !XEN_PAT it should be at least disabled by default, or maybe even hidden behind CONFIG_DEBUG. --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --eeQ5Sw3MESoZAt5D Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmO3h6oACgkQ24/THMrX 1yyQWAf9HO56+c4tEleItkwNk4egtEM7JbnfHfue4DVNGbvYgvqpORvvhtx7wbm8 hjQTIb0bWRBtOmOlPa23conmtzGhJIQgsRJVx+4Y8Uu95BMjAChur9jUo56AmeWA frRMIrJg1va3KcyRdLiChERtTNXH1E43e5vcH2I/Yswntwvq3+vwl2Vk/y0SYlSw J7L3X7USBEcvJMe8jUZwHKXlGebRf9axovR8Gp7KH0xHUofLGE0BOgP9RtERu82t q4LLxrmPRZJyd2rpAnN1vOT1LlqX3lywUluDFGvME94gt0Sl5npQZoGbwmiDBi0U 7Gd2xPjjNTIC3eVlfLV8fztV4Zxiag== =OXk0 -----END PGP SIGNATURE----- --eeQ5Sw3MESoZAt5D-- From xen-devel-bounces@lists.xenproject.org Fri Jan 06 05:24:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 05:24:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472299.732476 (Exim 4.92) (envelope-from ) id 1pDfD9-0001Eh-S1; Fri, 06 Jan 2023 05:24:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472299.732476; Fri, 06 Jan 2023 05:24:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDfD9-0001Ea-OI; Fri, 06 Jan 2023 05:24:11 +0000 Received: by outflank-mailman (input) for mailman id 472299; Fri, 06 Jan 2023 05:24:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDfD8-0001EU-3G for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 05:24:10 +0000 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 55b8809d-8d82-11ed-b8d0-410ff93cb8f0; Fri, 06 Jan 2023 06:24:05 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 423E05C012E; Fri, 6 Jan 2023 00:24:04 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Fri, 06 Jan 2023 00:24:04 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 6 Jan 2023 00:24:03 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 55b8809d-8d82-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1672982644; x= 1673069044; bh=T6QxApLPZtDk4+Nt1PDDcWCHZVNoE6nWso9ONeSi5PA=; b=i pRpRT9szWvhq/kVRiSz3DjByOdrKFTa31g7Eb9gtZ1EKeB4OaNVJYUcU2oB4A2Rn pp7rqMqQIYYfWTb2evUM8LeC4eFZNSRukQaFXR6WKiM9eMcrYeXskLxLuDWPzZqI ePHTznNYHUPAGlfd5aj/urlBYp/Csbc4YYC81A9gb2qyHqlqRYykGdN4jr3EKQWo 6pbKlp/NA1UUmN7EauiLbKJ5Xgxn/p1acPlFSQXueSfTf5n1ojP3rLEu1NxQvr5Q PHRe5JXoaqVN9w4N5No32O4aMC5ApSX/n3mlIzFJ9vDV7zW4Y14ex/d2D0wKmDyO tpV/GYXhcekFbzDFRnMBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1672982644; x=1673069044; bh=T6QxApLPZtDk4+Nt1PDDcWCHZVNo E6nWso9ONeSi5PA=; b=SKNpQ4cNhxrQ2jwwwU4+oUk8/OtbFhtqD1z4zvOUOoMz Ue7/ak5HzaQbsn8iRQUh9CfUL9TDLKdk+AQil/ABbhQweIlE2AmXAj9FDhqvQs/5 K58KhLbKtENsERT4ciGqO5LZbudoXaDTpab5ocia7J1fWlvVwS55cORwBfr1pQj1 z2ahHk/MA6iniKSj8XTtgyFKQreSWRgW8ECEBminv8tGoRuQtdpVKwz66xftfFTN zjOWCv5bcVRksI6K4yM/4vcSOl5JvevVoBuvEQvrO0xtdWFT87xcq0ABELsrZYZa pDwV8PsX5wr2al3T+AosADUaPaclz1HUGLHcegUKfQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrjeelgdekgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeffvghmihcu ofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinhhgsh hlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpedvjeetgeekhfetudfhgfetffegfffg uddvgffhffeifeeikeektdehgeetheffleenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhgshhl rggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Fri, 6 Jan 2023 00:23:13 -0500 From: Demi Marie Obenour To: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= Cc: Andrew Cooper , "xen-devel@lists.xenproject.org" , Jan Beulich , Roger Pau Monne , Wei Liu , "Tim (Xen.org)" , George Dunlap Subject: Re: [PATCH v6 4/5] x86/mm: Reject invalid cacheability in PV guests by default Message-ID: References: <2236399f561d348937f2ff7777fe47ad4236dbda.1671744225.git.demi@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ivFJOV8FZBUMgnec" Content-Disposition: inline In-Reply-To: --ivFJOV8FZBUMgnec Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Fri, 6 Jan 2023 00:23:13 -0500 From: Demi Marie Obenour To: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= Cc: Andrew Cooper , "xen-devel@lists.xenproject.org" , Jan Beulich , Roger Pau Monne , Wei Liu , "Tim (Xen.org)" , George Dunlap Subject: Re: [PATCH v6 4/5] x86/mm: Reject invalid cacheability in PV guests by default On Fri, Jan 06, 2023 at 03:30:01AM +0100, Marek Marczykowski-G=C3=B3recki w= rote: > On Thu, Jan 05, 2023 at 09:00:03PM -0500, Demi Marie Obenour wrote: > > On Thu, Jan 05, 2023 at 08:28:26PM +0000, Andrew Cooper wrote: > > > On 22/12/2022 10:31 pm, Demi Marie Obenour wrote: > > > > diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-comm= and-line.pandoc > > > > index 424b12cfb27d6ade2ec63eacb8afe5df82465451..0230a7bc17cbd4362a4= 2ea64cea695f31f5e0f86 100644 > > > > --- a/docs/misc/xen-command-line.pandoc > > > > +++ b/docs/misc/xen-command-line.pandoc > > > > @@ -1417,6 +1417,17 @@ detection of systems known to misbehave upon= accesses to that port. > > > > ### idle_latency_factor (x86) > > > > > `=3D ` > > > > =20 > > > > +### invalid-cacheability (x86) > > > > +> `=3D allow | deny | trap` > > > > + > > > > +> Default: `deny` in release builds, otherwise `trap` > > > > + > > > > +Specify what happens when a PV guest tries to use one of the reser= ved entries in > > > > +the PAT. `deny` causes the attempt to be rejected with -EINVAL, `= allow` allows > > > > +the attempt, and `trap` causes a general protection fault to be ra= ised. > > > > +Currently, the reserved entries are marked as uncacheable in Xen's= PAT, but this > > > > +will change if new memory types are added, so guests must not rely= on it. > > > > + > > >=20 > > > This wants to be scoped under "pv", and not a top-level option.=C2=A0= Current > > > parsing is at the top of xen/arch/x86/pv/domain.c > > >=20 > > > How about `pv=3D{no-}oob-pat`, and parse it into the opt_pv_oob_pat b= oolean ? > >=20 > > Works for me, though I will use =E2=80=98invalid=E2=80=99 instead of = =E2=80=98oob=E2=80=99 as valid PAT > > entries might not be contiguous. >=20 > If we're talking about alternative PAT settings, I'm not sure if they > can be called "invalid". With the default Xen's choice of PAT, top two > entries are documented as reserved (in xen.h) and only that makes them > forbidden to use. But with alternative settings, it's only behavior of > Linux parsing that prefers using lower options. When breaking contract > set in xen.h, "reserved" entries stop being reserved too. That makes sense. > So, _if_ that option would be applicable alternative PAT choice, it's > only useful for debugging Linux specifically (assuming Linux won't > change its approach to choosing entries - which I think it's allowed to > do). Point taken. > > > There really is no need to distinguish between deny and trap.=C2=A0 I= MO, > > > injecting #GP unilaterally is fine (to a guest expecting the hypercall > > > to succeed, -EINVAL vs #GP makes no difference, but #GP is far more > > > useful to a human trying to debug issues here), but I could be talked > > > into putting that behind a CONFIG_DEBUG if other feel strongly. > >=20 > > Marek, thoughts? >=20 > With Xen's default PAT, #GP may be useful indeed, but it must come with > a message why it was injected. In xl dmesg? > > > > @@ -1343,7 +1374,34 @@ static int promote_l1_table(struct page_info= *page) > > > > } > > > > else > > > > { > > > > - switch ( ret =3D get_page_from_l1e(pl1e[i], d, d) ) > > > > + l1_pgentry_t l1e =3D pl1e[i]; > > > > + > > > > + if ( invalid_cacheability !=3D INVALID_CACHEABILITY_AL= LOW ) > > > > + { > > > > + switch ( l1e.l1 & PAGE_CACHE_ATTRS ) > > > > + { > > > > + case _PAGE_WB: > > > > + case _PAGE_UC: > > > > + case _PAGE_UCM: > > > > + case _PAGE_WC: > > > > + case _PAGE_WT: > > > > + case _PAGE_WP: > > > > + break; > > > > + default: > > > > + /* > > > > + * If we get here, a PV guest tried to use one= of the > > > > + * reserved values in Xen's PAT. This indicat= es a bug > > > > + * in the guest. If requested by the user, in= ject #GP > > > > + * to cause the guest to log a stack trace. > > > > + */ > > > > + if ( invalid_cacheability =3D=3D INVALID_CACHE= ABILITY_TRAP ) > > > > + pv_inject_hw_exception(TRAP_gp_fault, 0); > > > > + ret =3D -EINVAL; > > > > + goto fail; > > > > + } > > > > + } > > >=20 > > > This will catch cases where the guest writes a full pagetable, then > > > promotes it, but won't catch cases where the guest modifies an > > > individual entry with mmu_update/etc. > > >=20 > > > The logic needs to be in get_page_from_l1e() to get applied uniformly= to > > > all PTE modifications. > >=20 > > I will move it there, and also update Qubes OS=E2=80=99s patchset. > >=20 > > > Right now, the l1_disallow_mask() check near the start hides the "can > > > you use a nonzero cacheattr" check.=C2=A0 If I ever get around to cle= aning up > > > my post-XSA-402 series, I have a load of modifications to this. > >=20 > > I came up with some major cleanups too. > >=20 > > > But this could be something like this: > > >=20 > > > if ( opt_pv_oob_pat && (l1f & PAGE_CACHE_ATTRS) > _PAGE_WP ) > > > { > > > =C2=A0=C2=A0=C2=A0 // #GP > > > =C2=A0=C2=A0=C2=A0 return -EINVAL; > > > } > > >=20 > > > fairly early on. > > >=20 > > > It occurs to me that this check is only applicable when we're using t= he > > > Xen ABI APT, and seeing as we've talked about possibly making patch 5= a > > > Kconfig option, that may want accounting here.=C2=A0 (Perhaps simply = making > > > opt_pb_oob_pat be false in a !XEN_PAT build.) > >=20 > > It=E2=80=99s actually applicable even with other PATs. While Marek and= I were > > tracking down an Intel iGPU cache coherency problem, Marek used it to > > verify that PAT entries that we thought were not being used were in fact > > unused. This allowed proving that the behavior of the GPU was impacted > > by changes to PAT entries the hardware should not even be looking at, > > and therefore that the hardware itself must be buggy. >=20 > In fact, I did that via WARN() on the Linux side, to _not_ have guest > killed in this case, to potentially collect more info. Whoops! I must have misunderstood what you meant by "trap". > As said above, > with alternative PAT settings, the contract which entries are "valid" > isn't there anymore, so punishing guest for using them isn't > appropriate. It could still be useful feature for debugging Linux (and > it feels, we'll need this feature for some time...). So, with !XEN_PAT > it should be at least disabled by default, or maybe even hidden behind > CONFIG_DEBUG. Okay, makes sense. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --ivFJOV8FZBUMgnec Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmO3sHAACgkQsoi1X/+c IsHeXg//S1AGIYEzJpckidY72FKng8WRFxrRxiaLYi1x/BaJisp1faR/UiV5qga6 6hcI+GpGYxFwE5KC8+PpJWiTAWkx2GmzGLY4D12f4Qrp/dl97qy2bN1Aqc4vKlfH DnY4yC0nfVHSYXmzHL/WACu0ffIGkE8+yRNZhc3iikMaY1yqFv04aH48AWVVcnGW flZGRSjJWY/jgc7Ih787nr+Lc0iu16TkgUMNApVoLIO680r8YMwJrGLLSXafd6tz aCywzechhBRnsx+tWPDqpDv5iM3Hh+H/gPi66pMRyoEjWkAIeoO2mD52pbJ6Iq8K 97AJZ7C2cTMeSSj+Uv3Q0mPLlrci0GwP7Ej3uMHxvj5ctIkcNW3RDX/Q9+UTZG5z +XtFqY7FXUiulKLX3FHt83daGd9sgV8rR+i6sTMe9un5YrfW5fPM51U+LDjyWf6S lhbcT/yYMbf5rziZhv+/2M67UiUrIhWVYXVp6ctqSbvlLvrhPVddIQRo5sDphiRQ pyMHhQIh9lLvexOgp56DkRCAVvkjaZqWUEt7EHTgmLJSuXPRtLulu5ojImlrsZTl Bu6OvjfNbv/nTRiOUilta2D8bxnrQ+VDYTFTDl4Xzot1pu0SLLJBYNHun+INDyG2 zgTI0s5l93yh1I4KVjR3cRUv+pg+Un6CoZDBxSSzrCQJ5pKmDyg= =qcVE -----END PGP SIGNATURE----- --ivFJOV8FZBUMgnec-- From xen-devel-bounces@lists.xenproject.org Fri Jan 06 05:33:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 05:33:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472307.732487 (Exim 4.92) (envelope-from ) id 1pDfMF-0002k1-PF; Fri, 06 Jan 2023 05:33:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472307.732487; Fri, 06 Jan 2023 05:33:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDfMF-0002ju-Kf; Fri, 06 Jan 2023 05:33:35 +0000 Received: by outflank-mailman (input) for mailman id 472307; Fri, 06 Jan 2023 05:33:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDfME-0002jg-A0; Fri, 06 Jan 2023 05:33:34 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDfME-0004Yx-7s; Fri, 06 Jan 2023 05:33:34 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDfMD-0003EC-Lr; Fri, 06 Jan 2023 05:33:33 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pDfMD-0004Tu-LQ; Fri, 06 Jan 2023 05:33:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=hVQ+F5Z9aFptuE60vsMMDxGFlAf/aEEGiSqiirlZucE=; b=4rYYykOPW9Uv0AU8nATNbMovkO vUUT50T37J3RlmyncdzVBa2QeBpmjnNrNquMso8g/2T44N4eEh36olTWIkEqPteXWDSH0JXJwowri pUikxczSbsoowXcyeblQHIfsvpx9wGDNTlWLNNuzeek5dTSqfECJ2ZTHk3BRW0Cl09Bg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 175596: all pass - PUSHED X-Osstest-Versions-This: ovmf=c32e7331513bfdb625986e4570c304dced4ea109 X-Osstest-Versions-That: ovmf=9ce09870e721efacc41fa7ee684e9e299f120350 From: osstest service owner Date: Fri, 06 Jan 2023 05:33:33 +0000 flight 175596 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/175596/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf c32e7331513bfdb625986e4570c304dced4ea109 baseline version: ovmf 9ce09870e721efacc41fa7ee684e9e299f120350 Last test of basis 175567 2023-01-04 10:13:33 Z 1 days Testing same since 175596 2023-01-06 03:10:50 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jiaxin Wu Wu, Jiaxin jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 9ce09870e7..c32e733151 c32e7331513bfdb625986e4570c304dced4ea109 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Jan 06 07:01:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 07:01:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472320.732498 (Exim 4.92) (envelope-from ) id 1pDgio-0003NA-73; Fri, 06 Jan 2023 07:00:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472320.732498; Fri, 06 Jan 2023 07:00:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDgio-0003N3-4E; Fri, 06 Jan 2023 07:00:58 +0000 Received: by outflank-mailman (input) for mailman id 472320; Fri, 06 Jan 2023 07:00:57 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDgin-0003Mt-77; Fri, 06 Jan 2023 07:00:57 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDgin-0006bv-4Y; Fri, 06 Jan 2023 07:00:57 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDgim-0005zf-M8; Fri, 06 Jan 2023 07:00:56 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pDgim-0005DV-Ll; Fri, 06 Jan 2023 07:00:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=bEKZQki7r8t/zqa36d89r+HNXOS2sar3ggG0+GjEMoE=; b=aqkMBI43hyCuijasrvUrGP1wXA ZlX83deHclFf9bKlEF0GfLGB8viBSXq+xn9wG9QMu3Ms0tg3ezNF5gmOgujjeZNlSh970d9jc/Mmt WChHswkntypJlvunTIttMnvzD+rd8nHVbP/IK6G2hl/lTl2MxSxmcFM3JDOvv3VSoiSQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 175591: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=41c03ba9beea760bd2d2ac9250b09a2e192da2dc X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Fri, 06 Jan 2023 07:00:56 +0000 flight 175591 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/175591/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine 8 reboot fail REGR. vs. 173462 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux 41c03ba9beea760bd2d2ac9250b09a2e192da2dc baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 90 days Failing since 173470 2022-10-08 06:21:34 Z 90 days 187 attempts Testing same since 175579 2023-01-05 04:57:31 Z 1 days 2 attempts ------------------------------------------------------------ 3265 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 498271 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Jan 06 07:11:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 07:11:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472329.732509 (Exim 4.92) (envelope-from ) id 1pDgtC-0004tk-9L; Fri, 06 Jan 2023 07:11:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472329.732509; Fri, 06 Jan 2023 07:11:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDgtC-0004td-4a; Fri, 06 Jan 2023 07:11:42 +0000 Received: by outflank-mailman (input) for mailman id 472329; Fri, 06 Jan 2023 07:11:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDgtB-0004tT-7F for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 07:11:41 +0000 Received: from EUR03-VI1-obe.outbound.protection.outlook.com (mail-vi1eur03on2041.outbound.protection.outlook.com [40.107.103.41]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5d49113e-8d91-11ed-91b6-6bf2151ebd3b; Fri, 06 Jan 2023 08:11:39 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8976.eurprd04.prod.outlook.com (2603:10a6:102:20f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Fri, 6 Jan 2023 07:11:37 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5944.019; Fri, 6 Jan 2023 07:11:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5d49113e-8d91-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oTO/hX2NnU0CaFQ1rnRN2JHB8m6wntDKLv4VxP7WfR2Ms4ooXiUib3yWR7mQJEvDV5ZoSFwXnK/SG2kmnkbHzyRBy30Vbfa35N1jpo5vMApc+K/HJsOZGJxilu3BCy4fpoPH4+gXQxnEwIlAsMjcF+qPMTGCA58ahDMczSupMwvI0hODX2+yPLuZ7ooQgx7jkKJtyVOQlDo8sK8qVhrEFSTeF/1R6Yg93DGFmSpBGSqDrfcJw1d76up8UKKAU0BAr5l8Zx2qGgwkOO5/x5JYB4lK48roL8HA7rIGbpzmAzUQkzz8ZLRgdiKlTyNLmXG0oc7dgRqniWFivkv4jkziEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Dp/SB8FHsc/pkJeDx9F8rMb9yST6AkHe9p8Ch4PCHkc=; b=nCZf8kPTPLb6VlMmePmX6Vlebf0nWDgWVjFdTt7I+n8s7posmeO1hmCcVw/IYeadXnwFKAxAOLBdQSENoPDPhC2Sax9fahrE0eUTg9BDVN3OqPDdFj0Goi36mihpWhmOTTIQGhEaHGMVlRWKCWTCUq3pswyYd8QQvvOgi2qMff5SZfkvihRxZIchSP5QDz0gf6XpbGnGO9YDICmYnmzmPIRywb38ow1X9ocrn9wKHNim/NE5ccNJvgEBMjhqDMRKCqgIFQp4GsIMe3bLykZYe9adYdy5K2f46YEq/YkDV/AZEfXXu47YXE1iAsVmuwHNIxZOzUuUdKh9yC4CfZkrJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Dp/SB8FHsc/pkJeDx9F8rMb9yST6AkHe9p8Ch4PCHkc=; b=2QuCnoSdN3kvDepH/R+VdMtQmnLBl8p3cMOjg1OpFMmlIoVLSNqkwvomdJHTmc5WjMjeDUrNYghAVJVOs9FY+qa/DvZz9ChtINDZfqqAdsWAJatRN/y/0yFlGL8+OuV0PGBNjbjJrDe52KfI+/nNzXhB8+/zoUg1v0GSu/kRRMx1TZyf+pF7xBmdnGAdrafG8sEzOdotn+tNQV4w6myeMDW+SVbIsNN8P5Ja+c9TVuTAow5ftS+KU8isK8HraIoWHgu4KbvcFeHtAXFFi3xjwNmAuVXD+djHjG8z/weP31DR7Tjc00TJImPEkFJxIPnhx2hngF3qKu9KYjUA/z/ymw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <0869534b-4481-d3d1-2afc-09560844d9d5@suse.com> Date: Fri, 6 Jan 2023 08:11:35 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v6 4/5] x86/mm: Reject invalid cacheability in PV guests by default Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , Roger Pau Monne , Wei Liu , "Tim (Xen.org)" , George Dunlap , Demi Marie Obenour , "xen-devel@lists.xenproject.org" References: <2236399f561d348937f2ff7777fe47ad4236dbda.1671744225.git.demi@invisiblethingslab.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0129.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8976:EE_ X-MS-Office365-Filtering-Correlation-Id: 79b9a312-a0d2-49dd-bc05-08daefb53ff2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HffHmHG3QUyYvttGBY2irtzuM5ced7UXhSmTV3vBy9eXsWy4WrOUfgwOzUDSlls5rTHNCqhvCf70ltkFr15bUO8RlhTmothzLY7uBMhqCzJMxh//c3RqB90qpghirRU9ML3YLUTX63TGlfIraOH3u0c8tLCRZnml6ikH4tZ4dC+TNWQWjoHtlIzqhr3h0tN7WjSQgHoSFGXFiaxS5BvHRwaxA4LKOScFnJbH8p6xTyS2c6Z76Qu/EbggqFN2SN60zNdnnjLemUMx81dUlLILpuc/3o/xgvUlJOxccWQGds/Wyb8Mwhk3GV7GaypdQYrWyJmQNyarpmLRyiieJlS6OJ/lo8BTWkH7508qNdfEYkQPaz9vWOpOMfqPckDop7rGyW5rNLinJX+MiMcEiQNFKNAbdWdyiPzozZ67BILx+FgSALWqoXpcM2p3uyPj2lbdWT/UqW4bCZ4SQJGjp0K3J4r7/KUI1r1SrISOgt0s5Qz0SFL4mW67G2HS9XWsVBlPHXScCIGMpqnp2siB6MoCjhZf+GPikhJfdUXcaIhgAQmhLFMbWIPC+2GarTxaS0cxq4fGoWlvR8MQQeR6ihUjFC3KXUyPw6Q3euIdnsMkR7SFPPx5WAfFuXVklklFMqIMWoYFZAzgeuExlcZN7n+voCko/H7W+gd9FKQxi6rjuu/GpwhiSxb++LjDyqfdYzVCSQnUYpQYw06LAu7N0/CADnbJWW36Zgwr7Jdjm5h3L7c= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(346002)(39860400002)(396003)(136003)(376002)(451199015)(83380400001)(2616005)(86362001)(31696002)(38100700002)(36756003)(54906003)(316002)(2906002)(8936002)(41300700001)(66556008)(4326008)(66946007)(8676002)(53546011)(6512007)(26005)(66476007)(478600001)(186003)(6486002)(31686004)(5660300002)(6916009)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z3RiZnFSbUFBMTB3SHkvbkdqelluQ0VGVDZmQmJoUE01WGxXNms3ZFNXZHpO?= =?utf-8?B?eHFIU3U2L2NXTjBzN0EwRU9BMXAxMlhsbHpyNS96ZFE2dkF4M2hIWkNDVC9s?= =?utf-8?B?Y0oySitWaW1JUGlCcTNlOXhVM21nRFhNTDIzTE1VSnUrTnNNMlN2cTRKUlpO?= =?utf-8?B?SHErTWpkTGxvOGRtczBHZTJlL05qUTBES1VCZGt4Y2srTVJwUktENE9rVlBj?= =?utf-8?B?RDNCSDdtYzN2U2k5dUdvdG9ETXFnODBjS0srcFhPY3Rrem54cDFRZlljQk5Y?= =?utf-8?B?cnpLZEk1U1RENXJvdVlXbHAxbi9WTXdWMDVoemVVeUtRTnJWWTNEZUVyTG80?= =?utf-8?B?OTdiRVRXRW1ia0JhYXF0aktQbWl2cTc5aVpCK0xhVnk1ZXQ0dFVPQlB5RkhX?= =?utf-8?B?ZExUN25ZeFRGZHBNMjJCRUxqS25DNUVNK1ZIbnJBNUxiTUNpQk5wTVRreEM4?= =?utf-8?B?TVd2NDJWYitadDk5S0tSUWVuM0ZJNUo5akx0bTFTN2FEOFpOcUpQMDlhWG5F?= =?utf-8?B?MldXWkJmVTQ1SS9vRzg2Qm5vOGVZNXcxU21KWFlneldGZnBnU0g5WWN3Z0d4?= =?utf-8?B?RWJ3d29sRXJZbkFoSGoxdENyeis3dXZjS2JINUFUQXpta3hmRGowOThRT2J2?= =?utf-8?B?MmpsMjFSVlNQWXZuMEMwQ0hOdDRpUUJHcFVLWTJiZDZTRzRlTDByYTlzRGo5?= =?utf-8?B?SDJ2ek4zeGw2N0ZKZlhxUnIvcVY0QXlOL081Z2l4SkNDVUVldkRmUVpZeU91?= =?utf-8?B?bTkyVUhzLzZSdXc5cGFVMXhROWxTa1hHdjJGT1RHdDJCUWZxYzg2UGVtci9k?= =?utf-8?B?cGduVjhSbVRFNklTdGpPcGVOcVZFU2IyaWNybkIzUUQyeUtMT1Y4TTdHOGFv?= =?utf-8?B?ZnNGcHBnV0VIUkhOT0tWdVh0N1BJTDBOUkt4bEsxbWJsc0ZBd0tPZnUyK01w?= =?utf-8?B?UU9peHU5SXNYYTBkRnpxby85aTMwYXpGV0E2OVhBYTB0L2pzQUU2ZVZDYzhX?= =?utf-8?B?eVVKOVVWTG9oUHFSNFEraDN3WVlpSzFCbVFpRmxEdlRMb2JrUkV0eDVaekFO?= =?utf-8?B?Q0dWaXFhT1RNd2duaG8yTEZLeHI0T05LZnBQUndWai9XcUxSWFFrb1czYWF0?= =?utf-8?B?OXBFMktaUE80OVA5b3JKTUhSeGZZRGdyU0ovOXFTMVQxemJFVGRPVVV2RGZJ?= =?utf-8?B?TGxIUHNYb1BWYWZmNkkxanJNTVA2TDdyVTZNMGFwNnBJSnhpTFdtOGNWVkxH?= =?utf-8?B?SlJ5bC80UTVwVXNUbEJJUXNZQkZRTk81alVYRGhUR1pCeHR2OTExV2pnNDVn?= =?utf-8?B?UDJ3SS94VlljWHpSYkFsUnlGV1IvcWFMeUtUdnhpZkQ2dzU5UWFacVQyazhL?= =?utf-8?B?UDJoR3o3MnNKS3ZJR0E4N1lGYWVWWXBaMG0yTWdtWkRVbWovMXNPaHZxaUNF?= =?utf-8?B?eDRSWTJyTlAvaUtpMkxMc0hycEpNY2dSalB0b29xM3QwRWRKYTBGbWp6K0Zh?= =?utf-8?B?cE1nOXdKVVJ2c0pabmUvRU94RklRZDBHaVE4RHN0N2E3aU43b0dTdHRPV242?= =?utf-8?B?WGFDQ0ZsRmEzVGVuSHBrb0ppTnA3RVdJbi9rdzczNFlHc3FFTTlSdkxraTI2?= =?utf-8?B?R2kwaUZ2OXJMZlpYNDJrdmgxdGg1U29hZEY5QW12WmxRRFdNN3BBN2FadWIw?= =?utf-8?B?T09DUGswRlhZTzJDVXVGRmVUQXFmQXRpSWpyd2h4clVrWUlkdndpdjZPZGdx?= =?utf-8?B?SlVkQnQ0QUhxczNFMk4zVDN6UnRsYWRveTNBc0tmeGxYTmNiemY3RWZKdGk3?= =?utf-8?B?cExsSVZOS2VJOVRRcTZ6Slp4RzRGbGVGeFJPS0JYTVMwMHdabW5wdGhiM0dy?= =?utf-8?B?ak9kdVhJWkpTMjBwRDNneUVOM2o2K0tNdVB1TnFFb1hTalhsYTZoLzhncCtm?= =?utf-8?B?SkZMVnYwOG8wdXpmMVpXN1dLVUVPelE1bzBYcnZ4cmpreUNjTVEyYVJ1MFBz?= =?utf-8?B?MktzSzE1R1RRcWRraXpOMkRxeTIxa1cvZitTREtmYnJvdFVhUlNYTEt0eVN5?= =?utf-8?B?TEh0M1BhRnVqS1Z5M2ZuNUNqTWxDTkk1dUdxSUJHVFpGbFlXT2tNb3ZtbWU3?= =?utf-8?Q?a24DWZVbFQAGTcK+rpU7DTZWX?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 79b9a312-a0d2-49dd-bc05-08daefb53ff2 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2023 07:11:36.9056 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DVQd4rDxEdi6rGYpskdP6bYcAmzaB0VKxB1XC0IXVuRmOxNo9VUAjzm/RmmYyCMrIax3A2YlL4yT+cPwgjCUuw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8976 On 05.01.2023 21:28, Andrew Cooper wrote: > On 22/12/2022 10:31 pm, Demi Marie Obenour wrote: >> diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc >> index 424b12cfb27d6ade2ec63eacb8afe5df82465451..0230a7bc17cbd4362a42ea64cea695f31f5e0f86 100644 >> --- a/docs/misc/xen-command-line.pandoc >> +++ b/docs/misc/xen-command-line.pandoc >> @@ -1417,6 +1417,17 @@ detection of systems known to misbehave upon accesses to that port. >> ### idle_latency_factor (x86) >> > `= ` >> >> +### invalid-cacheability (x86) >> +> `= allow | deny | trap` >> + >> +> Default: `deny` in release builds, otherwise `trap` >> + >> +Specify what happens when a PV guest tries to use one of the reserved entries in >> +the PAT. `deny` causes the attempt to be rejected with -EINVAL, `allow` allows >> +the attempt, and `trap` causes a general protection fault to be raised. >> +Currently, the reserved entries are marked as uncacheable in Xen's PAT, but this >> +will change if new memory types are added, so guests must not rely on it. >> + > > This wants to be scoped under "pv", and not a top-level option.  Current > parsing is at the top of xen/arch/x86/pv/domain.c > > How about `pv={no-}oob-pat`, and parse it into the opt_pv_oob_pat boolean ? > > There really is no need to distinguish between deny and trap.  IMO, > injecting #GP unilaterally is fine (to a guest expecting the hypercall > to succeed, -EINVAL vs #GP makes no difference, but #GP is far more > useful to a human trying to debug issues here), but I could be talked > into putting that behind a CONFIG_DEBUG if other feel strongly. What is or is not useful to guests is guesswork. They might be "handling" failure with BUG(), in which case they'd still see a backtrace. So to me, as previously said, injecting #GP in the case here can only reasonably be a debugging aid (and hence be dependent upon DEBUG). Jan From xen-devel-bounces@lists.xenproject.org Fri Jan 06 07:17:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 07:17:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472337.732520 (Exim 4.92) (envelope-from ) id 1pDgye-0005ag-VJ; Fri, 06 Jan 2023 07:17:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472337.732520; Fri, 06 Jan 2023 07:17:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDgye-0005aZ-SE; Fri, 06 Jan 2023 07:17:20 +0000 Received: by outflank-mailman (input) for mailman id 472337; Fri, 06 Jan 2023 07:17:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDgyd-0005aA-Ur for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 07:17:19 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2065.outbound.protection.outlook.com [40.107.241.65]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2763f03c-8d92-11ed-91b6-6bf2151ebd3b; Fri, 06 Jan 2023 08:17:18 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8560.eurprd04.prod.outlook.com (2603:10a6:102:217::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Fri, 6 Jan 2023 07:17:16 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5944.019; Fri, 6 Jan 2023 07:17:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2763f03c-8d92-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=emMJ+JXQB9LtxGhdEY6eeX0ouxEramrc6DiI9rAefvPZ6JJ21UsUaeWH6KWZqjKltX52nUuQ+LxLyOLSmDZXuT1mA/XabV0RvvttQceWvKr30WSTPw/ZOwAbEGynxonUAGYhanJSeYFhWJnwNUF221Q3MCcybctWYmDmo6WmoEFTqIKDAmZz8KzUiPavc27aVf6FAvuSUOJqtnzX/9ui/kVNY7adhJ/u8W9Y1ekm31c7BeUNuTqnGI2hLXet9UtByWqS0SphUyIypU7UMidVecOt1VJ6wRbOd0c1UwJ5Z84Fizd/gHG3ohANOwWRPCCI0CFwxj1yevU/iqXcpNbD2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hB0wHVv2g8VFNrzjAIujsFumyNKGcqZkk2GyhZB67bk=; b=F+Qj9PZvQBf8haBY9WkgIU7bRjlJ3/puJmXz0WrtFmcYu1RGGlECIFvW889r3yGDk3/0PlbKdKt+bWcSaFoQRveP4kXm+HL+R588OnS8kSOPoX/THVTSyazntg18Uwfb8HVF8ZaFe/4OZU4N98YiIwlkCjmHg5QkPsYcBCrUc1WKLs2szgev346nlkgujVaYnFFM/HL4SEpngOi5bTj8yVep0TF6HwIX+k3WAPLMXpC1wkBCp54ZwJkppCMYtfIWOtQN7C6eB7ssYdb7bVdr8LYPeESPKZOm9MZatWung6QCoF8HhXXK6s823zZNGbOFGA0WrR3yMYO5qN67FD34Fw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hB0wHVv2g8VFNrzjAIujsFumyNKGcqZkk2GyhZB67bk=; b=BTIX3zUFGTfctCPFHiF1JOJEtpglgEvrGDfMBgnI38+nk37tzA4rQEe0v1Lanym98J5ZBxUrxprnOYXrx4N4RI+HpLg2mfMpJB3w/Kx2i1WdYOyymdHw93mWw91wwgdAVDDiA2Gfp0ogVVXpi0/vcwcgXCm2GBxXiumT6fU4vAQSzqfQyFXO1pATGTZ//yPX2uO3h/PQBxkBmBBTWWCJXInXoBrq6X8GsrY8GUhM7/Rai+IcjXpDB56rzKjyMyZSbDvl7MzmggYhlASx2J6njdMy/Tf6l2Ch/eV/6rVONwgSAqCh00SK4RxRXPDyvVyQQx9wFKn4hVLPKzLXDwnrmg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 6 Jan 2023 08:17:14 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 13/22] xen/x86: Add support for the PMAP Content-Language: en-US To: Julien Grall Cc: Julien Grall , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <20221216114853.8227-1-julien@xen.org> <20221216114853.8227-14-julien@xen.org> <84a96972-3c41-ec94-3513-9944467d9e1c@suse.com> <924abe0d-6ba8-5d64-d74a-c2e1894d4f64@xen.org> From: Jan Beulich In-Reply-To: <924abe0d-6ba8-5d64-d74a-c2e1894d4f64@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0126.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9d::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8560:EE_ X-MS-Office365-Filtering-Correlation-Id: a0691bbb-a53b-458e-7fea-08daefb60a60 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +DVBXwMDZKPb2T8SIq95pVc6B3p4a+ie6p2lEuCjLHPzFlJI8OdgVdNoKMPoIOCiUAK7hDHNVw1ydS6nBx/B9P8/YmtVN58EOlg6cKF/BbbNPWlmtbyALdoG022RnAVdlfMBKDm/DBcaueHAWXa8qjElHMOo5HQFqJfAYSezpn2nMUK+7RJ+hXqIjSfvCOVrmkFaMMD72yPyqk7PUNvFGR7PzGybRcYEEiXpt9EXOTP6KG51MfeVykISyOIHx7PoPIJUL6F7zKRUYzFeSyqYfIXhjpHGGh61JXSJLfrz9z1nz5+bnWhuAPOtCdCXHfZCunRtzqra7D5zz1ND5rQ4h8ycDur/WaKXwoIksgUpE9Uu/jfJfm7MXygLVXckIsqEEw63jqm74EuGdlDZgf2CIxmImGAPkoQOA3N9egyo2tui+9OsHsqATK+oViP22QH8hsrTeOMIen+P2dz93kjjDJRcfqRdxJIv1nqVfWXFf3yamDLkPnQh5yzVM8hnNJMWzzTPEDKk/9kmRzyg7SMKjfp4cXRldhnlNk3NGZwJm9KuUgjsyawPqlqsVbaKNU0Oz37nkVyr5pG70VUSqmqOrF4RlRBQIglB+ehEI+/eU5WSxebj3FRTCqMUyhd7R6YmPzrXkHUxSC2KFkQ5P1XqCW2XsNeKnaEHqaU7gQqNMJtX6o9yieue2fh9y8npLxdY/pq5vbYmU2At85rmkGi6ocqAri4OSvOA0qSxIMAlyvOzWMuRfWTQGRaIxtVlyXf9juQrBabB/Y2Ji3fNn3sVCA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(366004)(396003)(136003)(376002)(346002)(451199015)(83380400001)(86362001)(31696002)(8936002)(2906002)(5660300002)(38100700002)(41300700001)(478600001)(2616005)(8676002)(53546011)(186003)(6506007)(316002)(6512007)(66476007)(4326008)(26005)(6916009)(66946007)(6486002)(66556008)(54906003)(31686004)(36756003)(45980500001)(43740500002)(357404004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dHp0L0xVNlB0amQ5MmZNTURjOTJyV3QrbkZHc2tUMmhCM2dqOHd0azY1MGdj?= =?utf-8?B?NEhjalJMbzJqUEd6RXZaK3pIY3NHdENpeFNCaHoxV2tvRXNsT3NCd3RXdTMv?= =?utf-8?B?SzRYTnZoRG0wYXBRR0Q3L0t4K0JVSGxJb01KbEZnNzh6aFd3QzRKZXJkWXha?= =?utf-8?B?U1ZrTDV2MzVtRzJ6S3hVRWRvZlhDQmtQT2o5S3NzK1Q5dTBkQlBYS1RWYTVY?= =?utf-8?B?VVBJYnFOSkV2MzFsRE43UjV3eFZMRkpCeHM1SWxNTGxwVkRJa0h0K2xRcHNW?= =?utf-8?B?akhFZnRNZHI5R042c1JCL09CZTY3RUp5TEhRMTRqMmtTQjdnNlFsNkpUT3Rm?= =?utf-8?B?WHA4ckxqWTRBSVdDRHBlSkR2aTN6RWljcU5tZDF3ZmpaNFAxdDllazhqLzNs?= =?utf-8?B?OG5SQU1VQjNma1BleERyZzBQVFBrZDMrUERIZWhHOVNJN2pRcjJRT2RrbnNI?= =?utf-8?B?eHJSY3dWOGJscHpNYVNWQmUwdlp1M1hEMjNzYVN5K3VaZ0JsN3c2clBWSEpP?= =?utf-8?B?dVJ2cDlNd2YxV3lzcnAza0NlQWVOQnpHSWdFT3BKend5bzhwNU16TWdFWmVJ?= =?utf-8?B?UE5xMDRwQUtva05VbjFqc3NOdFFkSVloTjVMZGFUbWFNWVR2a0pQcEhSaUw1?= =?utf-8?B?QllzTm1jVnJleXNidlYzUjBCSnllamRzeENhcW1KWG96M2xxNk4yS2hCZGxG?= =?utf-8?B?L3FERW5uYlFXTCszNGJJeG9LTkkySmNZSW55RldVNk1xV3Z3R25GOU9MUlkr?= =?utf-8?B?WnRJeXhjbFVQZ1k3eVh5UmFkYnhhbGdyQzBqY1lwYmZ1QUxRcVVuYXhzMHJK?= =?utf-8?B?aElxZ292cUtERmVaTmkzWGx6OExVWFlMRjRZRDkwV1BUcEtCWGs1SlpXSFlM?= =?utf-8?B?QVdxQnJKbFFEWVl2YVFwZ2pxT0t2LzJndTFuWTR5K0lRTGQveUMvREJKMmtt?= =?utf-8?B?eWxkT2ZPNFNJSkFOOEtoS2xlNEtuWXpqS2pGcFoyUkp2YzExY0RSelA4MEdP?= =?utf-8?B?YXFhbXgrdko1YWxKbmQxRjQvWHlhVTlzY1ZHNVdGU1hyeDViRjQraXhmdGo4?= =?utf-8?B?Q0pldGxKS212NC9KaHJvVy9NL2JNeXU5ZjBrSjVneHErT2VqZjdYSWFlaXY1?= =?utf-8?B?VzliVzQwQk1TdlJRWEljS0J6akdPNHV5V29BanFKUHREREZpK1VwUmFLcnpw?= =?utf-8?B?aWZXRG5ZMDltRWh6NlI1aWtnQkk3SnhJOVllTjJrN3M3azYvR3h5ME9CSFhE?= =?utf-8?B?Zm5sS3J0WjNkdlVkNkdVMXRNb2pIeHQvZzZxMm9vcGxJVUhrbktFYlpyeVNu?= =?utf-8?B?NGJBWXBzRnlRMjNZKzhQOWM5ZE04d3B1S25LcnpPRTNhdXdtTTB0ZWh0L1ZD?= =?utf-8?B?Z1NycDBJNGQwUnFWbFB1L1lWdHdrZEtSMGFyNVlmNmRZQ3dPSkVlejNQRzFw?= =?utf-8?B?YWNXRE5acFp5Z0FmM1dzZ1NOMkR5SzlxV25pTjhiRHQ4a1RnUjlNSEluTjBr?= =?utf-8?B?bmx5YkIxeHZwZVBKOVh5U091bk1YMlNzT3FHMFZuM1VKVlhwb0poMU51dXpK?= =?utf-8?B?eG50QWZDcUFBU1psMkcyVW56cUE3VGgzSENmWGJyc2JidENJUUJvM1BJRXNJ?= =?utf-8?B?U3VGcFEzaGhEa3JReSsrV1NTYXVtN1ExR2x1SGNZVzNVTWdtMVdNZW1kK011?= =?utf-8?B?UlMyRDRvT3Q0dlJJRHN1VGt3WTVRSGNscCtuYStXc2l5aTBUc0xkWkRJOUtY?= =?utf-8?B?L09jNi9oL21tZjE0cGdOdm5JYUZzTnB3bWw4YWVHTERDS0lKdzdHOUxtMW4z?= =?utf-8?B?Z0pFRGhlZDlQN2ZIeHNJWEVwOWdycm5kV0NTYlZxL01kakhWaGdGbzRHZjhF?= =?utf-8?B?d0VZY05Cc2dUUFNaYmFmMEdFTW9mQ2tTTnphNmVhcmg4WEhqYWRCMmRLQXMy?= =?utf-8?B?OTNHUnAzUVFLR1RKTG1sU1ZSQ0lSNjd4ZC9CNHRvdFRzQVA1MkROcGlJNzZa?= =?utf-8?B?LzYralYxQ3A3R1NIUVhNZEkwR0g5aHEwUG5Ib05yUzRVOTVqNklGTTNMb1hy?= =?utf-8?B?QXNZS3RSOGl6VVhBOGlxbW05V0I5aE5IQ1c4S1FuaGhZSjlkdmVtZ2wzNGdS?= =?utf-8?Q?kg/ZSCihAZzcsGYxVQqJ9qFkz?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a0691bbb-a53b-458e-7fea-08daefb60a60 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2023 07:17:16.5091 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jwHgQklrxSGgTefBzzFmpZhe5sL6EDxTHSJ8BFMhrr9+v3DLz5pbZRfjrlNkffflr4UCrMJs9gh+nZbBIKG9Zw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8560 On 05.01.2023 18:50, Julien Grall wrote: > On 05/01/2023 16:46, Jan Beulich wrote: >> On 16.12.2022 12:48, Julien Grall wrote: >>> --- a/xen/arch/x86/include/asm/fixmap.h >>> +++ b/xen/arch/x86/include/asm/fixmap.h >>> @@ -21,6 +21,8 @@ >>> >>> #include >>> #include >>> +#include >>> + >>> #include >>> #include >>> #include >>> @@ -54,6 +56,8 @@ enum fixed_addresses { >>> FIX_XEN_SHARED_INFO, >>> #endif /* CONFIG_XEN_GUEST */ >>> /* Everything else should go further down. */ >>> + FIX_PMAP_BEGIN, >>> + FIX_PMAP_END = FIX_PMAP_BEGIN + NUM_FIX_PMAP, >> >> ... you've inserted the new entries after the respective comment? Is >> there a reason you don't insert farther towards the end of this >> enumeration? > > I will answer this below. > >> >>> --- /dev/null >>> +++ b/xen/arch/x86/include/asm/pmap.h >>> @@ -0,0 +1,25 @@ >>> +#ifndef __ASM_PMAP_H__ >>> +#define __ASM_PMAP_H__ >>> + >>> +#include >>> + >>> +static inline void arch_pmap_map(unsigned int slot, mfn_t mfn) >>> +{ >>> + unsigned long linear = (unsigned long)fix_to_virt(slot); >>> + l1_pgentry_t *pl1e = &l1_fixmap[l1_table_offset(linear)]; >>> + >>> + ASSERT(!(l1e_get_flags(*pl1e) & _PAGE_PRESENT)); >>> + >>> + l1e_write_atomic(pl1e, l1e_from_mfn(mfn, PAGE_HYPERVISOR)); >>> +} >>> + >>> +static inline void arch_pmap_unmap(unsigned int slot) >>> +{ >>> + unsigned long linear = (unsigned long)fix_to_virt(slot); >>> + l1_pgentry_t *pl1e = &l1_fixmap[l1_table_offset(linear)]; >>> + >>> + l1e_write_atomic(pl1e, l1e_empty()); >>> + flush_tlb_one_local(linear); >>> +} >> >> You're effectively open-coding {set,clear}_fixmap(), just without >> the L1 table allocation (should such be necessary). If you depend >> on using the build-time L1 table, then you need to move your >> entries ahead of said comment. > > So the problem is less about the allocation be more the fact that we > can't use map_pages_to_xen() because it would call pmap_map(). > > So we need to break the loop. Hence why set_fixmap()/clear_fixmap() are > open-coded. > > And indeed, we would need to rely on the build-time L1 table in this > case. So I will move the entries earlier. Additionally we will now need to (finally) gain a build-time check that all "early" entries actually fit in the static L1 table. XHCI has pushed us quite a bit up here, and I could see us considering to alter (bump) the number of PMAP entries. >> But independent of that you want >> to either use the existing macros / functions, or explain why you >> can't. > > This is explained in the caller of arch_pmap*(): > > /* > * We cannot use set_fixmap() here. We use PMAP when the domain map > * page infrastructure is not yet initialized, so > map_pages_to_xen() called > * by set_fixmap() needs to map pages on demand, which then calls > pmap() > * again, resulting in a loop. Modify the PTEs directly instead. > The same > * is true for pmap_unmap(). > */ > > The comment is valid for Arm, x86 and (I would expect in the future) > RISC-V because the page-tables may be allocated in domheap (so not > always mapped). > > So I don't feel this comment should be duplicated in the header. But I > can certainly explain it in the commit message. Right, that's what I was after; I'm sorry for not having worded this precisely enough. Jan From xen-devel-bounces@lists.xenproject.org Fri Jan 06 07:43:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 07:43:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472344.732531 (Exim 4.92) (envelope-from ) id 1pDhNZ-0000Qp-25; Fri, 06 Jan 2023 07:43:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472344.732531; Fri, 06 Jan 2023 07:43:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDhNY-0000Qi-Ti; Fri, 06 Jan 2023 07:43:04 +0000 Received: by outflank-mailman (input) for mailman id 472344; Fri, 06 Jan 2023 07:43:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDhNW-0000QS-Vz; Fri, 06 Jan 2023 07:43:02 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDhNW-0007Va-Sv; Fri, 06 Jan 2023 07:43:02 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDhNW-0007Hk-BE; Fri, 06 Jan 2023 07:43:02 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pDhNW-0003OY-87; Fri, 06 Jan 2023 07:43:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Gw1p+CeJNvUxpqN1/nODy5yLrzoIUuFIbUE2LDwYmXw=; b=v0+th8tBFpcArHepq0qEFfY6+C oGR3H1+u4NzOH76ql+qeqcdyFBdh6fNuG0hGCZGSJoLH+/mGyss0rIjkBm94avLhB8BgUhrCgZUG8 mrDf4jI0z5g6flvHMUncHzGqdnO+ciwmtqb+1sMEeyGc+BC1F3bW1LzXSTt4KtjT5Yec=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 175598: all pass - PUSHED X-Osstest-Versions-This: ovmf=8c2357809e2c352c8ba7c35ab50f49deefd3d39e X-Osstest-Versions-That: ovmf=c32e7331513bfdb625986e4570c304dced4ea109 From: osstest service owner Date: Fri, 06 Jan 2023 07:43:02 +0000 flight 175598 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/175598/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 8c2357809e2c352c8ba7c35ab50f49deefd3d39e baseline version: ovmf c32e7331513bfdb625986e4570c304dced4ea109 Last test of basis 175596 2023-01-06 03:10:50 Z 0 days Testing same since 175598 2023-01-06 05:40:43 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Gua Guo jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git c32e733151..8c2357809e 8c2357809e2c352c8ba7c35ab50f49deefd3d39e -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Jan 06 07:54:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 07:54:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472353.732541 (Exim 4.92) (envelope-from ) id 1pDhYT-0001v3-2G; Fri, 06 Jan 2023 07:54:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472353.732541; Fri, 06 Jan 2023 07:54:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDhYS-0001uw-Vh; Fri, 06 Jan 2023 07:54:20 +0000 Received: by outflank-mailman (input) for mailman id 472353; Fri, 06 Jan 2023 07:54:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDhYR-0001ua-9e for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 07:54:19 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2078.outbound.protection.outlook.com [40.107.20.78]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 51c2c393-8d97-11ed-91b6-6bf2151ebd3b; Fri, 06 Jan 2023 08:54:17 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB9127.eurprd04.prod.outlook.com (2603:10a6:20b:44a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Fri, 6 Jan 2023 07:54:15 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5944.019; Fri, 6 Jan 2023 07:54:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 51c2c393-8d97-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HQDvcmMxiwkn2ol/77g7DO0PUSbnXsXb1q6nvfNxR7/bQapPuaHkQ5AuP0b/FxV0r4DEfVI6OGXNTBdJDs0+an4T2sONOays7fyEu8aomnIgzILfE2Sd4NLELkNWy6j7uYlTF9v8GdrvMP0dss1tsDLZ51fY/wpy4JpCREWjGtBDEBkVVMmJ7rv9iZ1WeNtqYY4IZKugOn9KBApf4VuJOYT+j4/R8SJAgCfhSbphuZhyMs6CyNnBLGzmYCRWscoKWuNflb6Kn5yJh8hbI6p3CzoXZd0vaue+xebqOtiKFXRnklE9C4IVZzWFCUPRSxjosvamySqVOZYLr4v7a+YfYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SFq0d37GfmCTvGfcS+p64VQhkk9QauO6RTWgA1aQC+c=; b=KoMJqrubLyEJtRq1y6MtQNRM26P4tmdtl8Msw/OyWakwIzoaKi/K4/VBtUWa0Tlc5BD50Jq1ypLjZjYbieK6OeNMo0zZmGShs4JTtXk64HhMzJNMSLpcmVJmw57xl7GbhSDJGObbrxnLYcGg2HAG9JvflYSqF2TC04cWf1WgF+DQz63a0QqIY6tpVc/5RIO9xlb6/nd6r2zJtn8BSVoxucq5ccxw0ugGxxh4B1UlmaisuPSSwgGPB6CTKgN+9N+UY0CNEywDxcKbZJNPqu6rRxMpA1zxJZpIZMOVbZyfWQCWldB/747jCxFHWccBtQrByHatSLVKwFIV63NmGGbEdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SFq0d37GfmCTvGfcS+p64VQhkk9QauO6RTWgA1aQC+c=; b=ao79GPE7HsGd2D62XNWsLHdWYCcJBZsedDnf4c0MBbFaqh77qZsmx2Y7seyTWwlQnvwI4FYjPywUd7nASCpFlRZjM4isAE7OOHEj7ljtQeob7eZ8pAlJOl6FYEKZbibseVk03PRNQhHO6IFNP1Y+0UliIZuFoCQr3BIVRJ+eiTYmFUqL3P7uPrf5lvjbj6+3OAKhA21j/meS5e8BrprptuMik+IaQjJKHPXadRwEBQhOslqo73TI4RyWDW/wKiI9yaVX2Hv8/OUndZfkj+Gs6eBu/sbsGKqQisnZYpH2vNo+HooK1gyFf0SWNYvRzIkL/3xZmDlEy9ycGBgFI/jYdg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 6 Jan 2023 08:54:13 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 3/4] xen/version: Drop bogus return values for XENVER_platform_parameters Content-Language: en-US To: Andrew Cooper Cc: George Dunlap , Stefano Stabellini , Wei Liu , Julien Grall , Xen-devel References: <20230103200943.5801-1-andrew.cooper3@citrix.com> <20230103200943.5801-4-andrew.cooper3@citrix.com> <540a449d-f76d-eb16-4f98-c4fb3564ce98@suse.com> <7dd00ce3-a95b-2477-128c-de36e75c4a34@citrix.com> <9ce20298-5870-aa1b-ee5e-e16a623beadb@citrix.com> From: Jan Beulich In-Reply-To: <9ce20298-5870-aa1b-ee5e-e16a623beadb@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0138.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9e::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB9127:EE_ X-MS-Office365-Filtering-Correlation-Id: 5eaf4153-e3cc-4233-ca2e-08daefbb34e6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xHrmCoTqOQ2dHghrY662x85f+6ekiqYNk4NcKcz30GlAtcJnMgL6kpPUREXty4Xd+HtLOs29LnN6pMtr8dSzCCj0lZhtzm+3J1YsuytuFSuC4PovXxPUcyF6cOd8VCBuBT/+agVx2yJk0E2stzimJ7vkwxkK2HrX7LbzBYrgbZN3aYXX84Ry7rFxWApvb/UuW19XH8dKOvmFLlRkrn1RJJQ4m6cEZ3HKmXVYglriJBDlOEi/WDwbQBVJ3Tw9YZ73gfrvqFT8/h7rkqvYMvHo1dNFl1qTQQZbeJOoNd42h/2LLme3Vb75DbqOITZWptNcfmUNjBz5pzFAk9DL656TCodSkdSgqP89uvPEqGLzFgZNxitJ60v3VSXCOA4AbC1XtkEM3IS9AGpKgxWktpIJdlp7ql6phGEwvIgKa2TxyFlKQ02VqWsUEy/X6RgmR9HgUdTqjzmrTMDTGotJmcNEqXL2QKrPk+SCCooBI4mDGXyvwpN34cLF02jhUmiFLnhkN2FRar/kxsfvkkbSQcEaj2J3xPZcN/0iQWR/5KwZu6PLZSrvWt3IXFpGi8tXKZ5byY+GYjz1vm/jQjL40cE5ePiUiNcwEhpPYWfr0H58rTsvOUJWSiLZG4RhAFOpIy3L3GkhK5pFaz3evADlnbxqN9qeUpn7ZPBP7+ex65eEkNXOWjSZ+5QiGjFtom9ILBjkm/LhO3cQV/VY5eaRRQ3EdEBrRuyUKzPoeTzU550l5qg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(136003)(366004)(376002)(39860400002)(396003)(451199015)(2616005)(186003)(26005)(6506007)(53546011)(6512007)(31696002)(86362001)(36756003)(38100700002)(8676002)(4326008)(316002)(41300700001)(31686004)(2906002)(8936002)(5660300002)(6486002)(66556008)(478600001)(66946007)(6916009)(66476007)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MUdjdEJ4aEFReGxEZDNtSU1ReW1oMUViaDFCODNIZENvenNwNzRrd1VQUUtw?= =?utf-8?B?VGltWStsTXoreVBkelNXcEMyVUJDRm9WWGZNdXFIOVZ0eHZySk1LQnViUHhq?= =?utf-8?B?YldVc3lEdDd5SHEveGQyUW0rVS9QTUR2czcyeTlZNXl5WTBvdEszMzk0MXlR?= =?utf-8?B?TXl3RXRLQTNCVGJYOW9JbzZzMDNRaldiaXRUbG5hZXBIRnhKNFR0TnZDeGZp?= =?utf-8?B?TitwNmpZeXVuVWN1VTZMMkxjV3JZelZBbGFoRUFkWlFqVWNNNTlqcXRRYlhY?= =?utf-8?B?bEtoMzAvUGRneXQxTkpKenNQYy96UGNPbStaM1VvQlF3MG9vSCtRSFY2eDFm?= =?utf-8?B?Q1NrZHpYUjV3amhzRmhIRXVweEtjUkxmVElZMHlKTW5XcCtnM3ZRV3Y5T21X?= =?utf-8?B?ZWk4MU1oM0VQc09BelQ4Y1A1S0QrWXBmSjhCblhvSkpMSkxNaDNiU3gwdGdi?= =?utf-8?B?bGdZVTFld1lxM1RMWlRVL3o5QjR1Mk9HaUpZcFRMZ3ZhQjIvQkNLU1ZUV1Vz?= =?utf-8?B?MWlDdGFBVy9iQ1Zya0FDUlVmbVNSekVSeVlHS0psWG1pWlVUL09aeUxKak1G?= =?utf-8?B?M2FqeEptN1V1UWlGVUlxVXdRV3JtSjFqV044NzRmS0dpZkRPQzlGMUMzeHV5?= =?utf-8?B?VDVYYWJGWVc3L3N3TGs2T05LcHVLSXZUMWRyTlFFTFJiZjd5N3MxRDVqYjRj?= =?utf-8?B?YlNoVHV5WmZoWWx6QWYxQzFhZThIelBpTm95RzhvcDA2UDBpa2pQTVdldlF0?= =?utf-8?B?OTVMOW84UkFwTEdJOXc5aC9rRFZiZzhtNUh5d3R0Zkc5NXhtZzV6LzdmWFZk?= =?utf-8?B?OU5BbWtlNnVMR1NJMkNhZ09RejlrY05yYWN5WHp5cFpUTlVKcm9uSEU4VTRZ?= =?utf-8?B?VlN5Qmx1M2FrT1g4NGZ4ZzZqcUhKMzFtSDFwaFBvbmdJdjhCMjhEd2dnQlBC?= =?utf-8?B?eVh3Rlh4ak1MUlR4Q1VjZ2x6a0VuaGUvempWNytPTk5qQlYxMnJ5OVhmVkhQ?= =?utf-8?B?MmMwUUc2N0FWMkk4SjI1L0dSdXFoNU84TzNOUzZiN0FOWjFLNGNYWmxobHlE?= =?utf-8?B?RlphQTlRa25acXBsM2ZLWXI0Umg5UlhTSzFjZGs3SnRJYTM4RnRBUTVHY0tO?= =?utf-8?B?bC8wanJTVVEvSE5hS01KK0tQNitLeUlKQS93U1NzV01Ocmt4SlkyRCtwVWF2?= =?utf-8?B?SkFwQ2ZHcEc3TEl5VExHRlBDcEJlYWRRbmJtYTNjVnJTNDB6ZXV0OStGR09w?= =?utf-8?B?QlROUkU2bWNENzJSYmxBSWNYeE5Nc01obk9ON2EwUHpWNWtyd1Z4QUYwaDNq?= =?utf-8?B?U2hieTlEVjBqWStHMUZsUFJ0RGtVWmQydUdNL2N5NzRCejk3Tms0b0MzeGpx?= =?utf-8?B?YmFlM00vZXVDcGFUNm5yRFRNWno2V2hFQXFVclEzT3hoTFF1eDIwdUQxU083?= =?utf-8?B?eXNxcng5U0ZqVjRKelcrTFVHN2JmSzkyZ2lJUkNoa3hRdkIwVEpBTnZlSWxN?= =?utf-8?B?d2IyeVkzenQyV01WSWtRRFVWYTc3TXNnemJFcjN1MFBrUGZsb1JGUVRIRkNG?= =?utf-8?B?Nk9kRXNEb2IwUUJhRzRGRG1YWTF1eC91QVFGUHRJM1Z1KytPS0NGeEVQd2N0?= =?utf-8?B?dmlDbUhWanhCNUViZDlaVXVRTWZXN2RVNmI3VHZaUHNQV2VvbkZYd0RvemlQ?= =?utf-8?B?QmRYbzVuWVNzUUdxUlY2emZYMlJBVDJtWkRpazNvQVM4TGQ2VWFjRjZoOGtJ?= =?utf-8?B?Wno5NFVmbU8zNFlzcmk2azJ2eHVJNFZoaG9keWhleDFmaWRRSDBsNDRRYnFF?= =?utf-8?B?ZGtBQXZrTW42bDlyY1haVmJraEQwclJpSWV4bTJua0toQ0lsaGFKQU9nWmtT?= =?utf-8?B?Sy90Kzl3dzVtN0RDK3YvVExNUVhTT1VrbElUdGFYQm5rWHFPajZhNi9QS1R6?= =?utf-8?B?UGxtVmRQakZIUVY3VGx6dDFsdGFRNk5MU21DbittSmtOYjlmWEsvVXlPMVVH?= =?utf-8?B?RWNPSFUvLzhEdlI1NHJ2WHgyOVRib3Ira1RJZEFuZGFHaHdmQ1JQazBwbVVk?= =?utf-8?B?U293S1lOYm1wUFM3QUtLdkUydEVNZkVKODJNajgwL0dNSWFMYmVMakJMVHR3?= =?utf-8?Q?v/cwUaHW6GpULbqk0jjHvKHGP?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5eaf4153-e3cc-4233-ca2e-08daefbb34e6 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2023 07:54:15.3528 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FLwAO2Wedall6vsCujEvsec+C8SuXXHVlARz8iE/W+WkP8qssY9kfvbC+D6XbN7zz05xCsBlSchiuq6KwhRotw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB9127 On 05.01.2023 23:17, Andrew Cooper wrote: > On 05/01/2023 7:57 am, Jan Beulich wrote: >> On 04.01.2023 20:55, Andrew Cooper wrote: >>> On 04/01/2023 4:40 pm, Jan Beulich wrote: >>>> On 03.01.2023 21:09, Andrew Cooper wrote: >>>>> A split in virtual address space is only applicable for x86 PV guests. >>>>> Furthermore, the information returned for x86 64bit PV guests is wrong. >>>>> >>>>> Explain the problem in version.h, stating the other information that PV guests >>>>> need to know. >>>>> >>>>> For 64bit PV guests, and all non-x86-PV guests, return 0, which is strictly >>>>> less wrong than the values currently returned. >>>> I disagree for the 64-bit part of this. Seeing Linux'es exposure of the >>>> value in sysfs I even wonder whether we can change this like you do for >>>> HVM. Who knows what is being inferred from the value, and by whom. >>> Linux's sysfs ABI isn't relevant to us here.  The sysfs ABI says it >>> reports what the hypervisor presents, not that it will be a nonzero number. >> It effectively reports the hypervisor (virtual) base address there. How >> can we not care if something (kexec would come to mind) would be using >> it for whatever purpose. > > What about kexec do you think would care? I didn't think about anything specific, but I could see why it may want to know where in VA space Xen sits. >>>>> --- a/xen/include/public/version.h >>>>> +++ b/xen/include/public/version.h >>>>> @@ -42,6 +42,26 @@ typedef char xen_capabilities_info_t[1024]; >>>>> typedef char xen_changeset_info_t[64]; >>>>> #define XEN_CHANGESET_INFO_LEN (sizeof(xen_changeset_info_t)) >>>>> >>>>> +/* >>>>> + * This API is problematic. >>>>> + * >>>>> + * It is only applicable to guests which share pagetables with Xen (x86 PV >>>>> + * guests), and is supposed to identify the virtual address split between >>>>> + * guest kernel and Xen. >>>>> + * >>>>> + * For 32bit PV guests, it mostly does this, but the caller needs to know that >>>>> + * Xen lives between the split and 4G. >>>>> + * >>>>> + * For 64bit PV guests, Xen lives at the bottom of the upper canonical range. >>>>> + * This previously returned the start of the upper canonical range (which is >>>>> + * the userspace/Xen split), not the Xen/kernel split (which is 8TB further >>>>> + * on). This now returns 0 because the old number wasn't correct, and >>>>> + * changing it to anything else would be even worse. >>>> Whether the guest runs user mode code in the low or high half (or in yet >>>> another way of splitting) isn't really dictated by the PV ABI, is it? >>> No, but given a choice of reporting the thing which is an architectural >>> boundary, or the one which is the actual split between the two adjacent >>> ranges, reporting the architectural boundary is clearly the unhelpful thing. >> Hmm. To properly parallel the 32-bit variant, a [start,end] range would need >> exposing for 64-bit, rather than exposing nothing. > > The 32-bit version is a start/end pair, but with end being implicit at > the 4G architectural boundary. > > If we were doing 64-bit from scratch, then reporting end would have been > sensible, because for 64-bit, start is the architectural boundary which > can be implicit. > > But there is no such thing as a 64bit PV guest with any (useful) idea of > a variable split, because this number has been junk for the entire > lifetime of 64bit PV guests.  In particular, ... > >>>>> + * For all guest types using hardware virt extentions, Xen is not mapped into >>>>> + * the guest kernel virtual address space. This now return 0, where it >>>>> + * previously returned unrelated data. >>>>> + */ >>>>> #define XENVER_platform_parameters 5 >>>>> struct xen_platform_parameters { >>>>> xen_ulong_t virt_start; >>>> ... the field name tells me that all that is being conveyed is the virtual >>>> address of where the hypervisor area starts. >>> IMO, it doesn't matter what the name of the field is.  It dates from the >>> days when 32bit PV was the only type of guest. >>> >>> 32bit PV guests really do have a variable split, so the guest kernel >>> really does need to get this value from Xen. >>> >>> The split for 64bit PV guests is compile-time constant, hence why 64bit >>> PV kernels don't care. >> ... once we get to run Xen in 5-level mode, 4-level PV guests could also >> gain a variable split: Like for 32-bit guests now, only the r/o M2P would >> need to live in that area, and this may well occupy less than the full >> range presently reserved for the hypervisor. > > ... you can't do this, because it only works for guests which have > chosen to find the M2P using XENMEM_machphys_mapping (e.g. Linux), and > doesn't for e.g. MiniOS which does: > > #define machine_to_phys_mapping ((unsigned long *)HYPERVISOR_VIRT_START) Hmm, looks like a misunderstanding? I certainly wasn't thinking about making the start of that region variable, but rather the end (i.e. not exactly like for 32-bit compat). >>> For compat HVM, it happens to pick up the -1 from: >>> >>> #ifdef CONFIG_PV32 >>>     HYPERVISOR_COMPAT_VIRT_START(d) = >>>         is_pv_domain(d) ? __HYPERVISOR_COMPAT_VIRT_START : ~0u; >>> #endif >>> >>> in arch_domain_create(), whereas for non-compat HVM, it gets a number in >>> an address space it has no connection to in the slightest.  ARM guests >>> end up getting XEN_VIRT_START (== 2M) handed back, but this absolutely >>> an internal detail that guests have no business knowing. >> Well, okay, this looks to be good enough an argument to make the adjustment >> you propose for !PV guests. > > Right, HVM (on all architectures) is very cut and dry. > > But it feels wrong to not address the PV64 issue at the same time > because it is similar level of broken, despite there being (in theory) a > legitimate need for a PV guest kernel to know it. To me it feels wrong to address the 64-bit PV issue by removing information, when - as you also say - it is actually _missing_ information. To me the proper course of action would be to expose the upper bound as well (such that, down the road, it could become dynamic). There's also no info leak there, as the two (static) bounds are part of the PV ABI anyway. Jan From xen-devel-bounces@lists.xenproject.org Fri Jan 06 07:56:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 07:56:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472362.732552 (Exim 4.92) (envelope-from ) id 1pDhaw-0002Y0-Ie; Fri, 06 Jan 2023 07:56:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472362.732552; Fri, 06 Jan 2023 07:56:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDhaw-0002Xt-Fr; Fri, 06 Jan 2023 07:56:54 +0000 Received: by outflank-mailman (input) for mailman id 472362; Fri, 06 Jan 2023 07:56:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDhaw-0002Xn-5P for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 07:56:54 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2088.outbound.protection.outlook.com [40.107.20.88]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id add77bcc-8d97-11ed-b8d0-410ff93cb8f0; Fri, 06 Jan 2023 08:56:51 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB9127.eurprd04.prod.outlook.com (2603:10a6:20b:44a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Fri, 6 Jan 2023 07:56:50 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5944.019; Fri, 6 Jan 2023 07:56:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: add77bcc-8d97-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d9JQ8z+niPqPw2LkBL00+4xDnfDwMmHDHKyCSDQk/T0nikroYfuh3ZgXS1NXf9gOurmZmf4h7EmWUsLpC/nvGYTexIhi+2p4hLmtz8fOX6uF9ayQnwwvhMDL0zg8BPjreoUUy8l0NO6jnWVXVUS3Xjgetyk0YlCsezviNFxIjH3iYukwZUDCSYpBT4+tzlVtT6XrRqLs04saEpKlAs4dlfM0GbSPpl0IeRf/4EtwQ4YxRCV+GTZWK3un/aXybgQ5nvUqZo3iy4cLPLKB4M5b2DVI9vhmj5K7H1eZ6nuIylTEgZyH/iDNDcHqNaYcxsB47O/WIS8d7v2jPeWaSE5NCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JRhZxzzZ3J6kJnMtHAlWdvDXceG75enGMlLVUHsUWvE=; b=fNYmCoNc4IGsnFAbChKwC90zH872QGfWjPuiMTwy2mkVB8vyznxWf2Y+rAJDSMaP7+/W08kk66j6XKQEVhiHf0Ct73fstaeiHZ+DazZp+J9IAd077BaWNJ81uZOz8stlnLgzZIdH1P3UPoVI0xM2S9hMCQ2E51tbIfuXzaacAKIf4Ys7tP+0E1g7oCn+pAy7dyJj7VsxXnV3/sUML4OFRGq6/asPV0UKqjlohy9M9m96V4w5tLyH+o7Yp2j6lvB+BCWdH2dyi4C4KqPKPqXRlpTb4c70r0mvJ8EFcwxhveZ1v2Xk+whbGpMgB3cxwyhOL0dV4aQ7FRWBdzusFyaLeA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JRhZxzzZ3J6kJnMtHAlWdvDXceG75enGMlLVUHsUWvE=; b=DG9Z+Y/653hM3aRV9vS4ImGGejfRK/RYMYaLSNj8cIEour9MLIHCQeYhkh8tSno13gXet2umftwpKv7i2uvM1nPmXOa0UMsuyNjtYp8OGT5KgOp58BpQ9aSFP/WknR+soHPgmgBTj8KDKrs6JQX9M6DnWBu3ZbIfr09e4vQ9QmiHrXsP1V0A5x8Dx8a/yMuQFEFoT10Aq+4GUDhAhigxMQ7AEi7A2cjIt53UyK5kOz7/6zRopk0Z6ee3Dn1Dn47de1Th2KqSCXj1aMPtwwvBEvjMCa8JlLCNjpu/2ujTqwNvAudGvF/dTZPzj9u2d6Og1TiGxvkWcuL4kCB5XrhEMw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <8ce9eaed-7684-22ea-9ce6-9a45d9cc69c1@suse.com> Date: Fri, 6 Jan 2023 08:56:48 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 4/4] xen/version: Introduce non-truncating XENVER_* subops Content-Language: en-US To: Andrew Cooper Cc: George Dunlap , Stefano Stabellini , Wei Liu , Julien Grall , Xen-devel References: <20230103200943.5801-1-andrew.cooper3@citrix.com> <20230103200943.5801-5-andrew.cooper3@citrix.com> <9c9cedd5-cca7-95d4-00bb-f34a56de2695@citrix.com> <63789ce5-5dff-c981-4127-d1ef3227595e@citrix.com> From: Jan Beulich In-Reply-To: <63789ce5-5dff-c981-4127-d1ef3227595e@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0129.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB9127:EE_ X-MS-Office365-Filtering-Correlation-Id: 1184f8a4-23b1-4bb1-074a-08daefbb9146 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8R0P1dpyZKCsjrAS67GvwwrP+/tl043X/nqDlgYmvldn943s6m3WE1trL4B/5JawmPY/VjOIay3GbjDqCSQYJp7hIr5aYJ+vHqsZhmE+BwqMJce9PiPnyQxzK81YVYGCZbJvirmq+JZPUBh/i3nF6YC3hQ6TYl0O3JB8WHMaG1SVUJqYQ9BcpqQirlZpjvEChg+8fI76BnplnfhytDUmShiMqEI8Imw3pTg7vxXuAco8mDTR7qJePbXVWKbY6O3jMIZ6KmxhhdvEs/PjsmwMmjVaSQClmcs7hFMSKZLwDbilP2PlvonnhUFkfuLV4hJFzAUnIZKYWP9AT1xGl1suFXxcSY8bjYN7WmHcDSNQXHvCTP1uxp1BkNrWtzEFo6xllisf9S8iLcn3EGC/ti8417erwL2/SSxv0t7zXr375QlaR7GstywBRxmkd+GjTquwNqf55uA1SB+2juNJIaUsVNOAJM1VLdBU4EEqpysZzVH5YXgeIphZmdJwTddoF+Ga+atrPqeHmj9uX6kuOekCZKAji3ViNx7p+rz+jwtf2WBgHS6OQPxW1X7v+UP1Cg9ymcdegiw4ymayoks1qr1+d8hw6aHqsnYAG4NO3DBfF5v8b0pKgPFuRGpG7VKoF5yOwXz9v48pSXK5iBw590EGCgoCZkmFuZ5XbDgPNeYCfscyO5ULgA5KVXpdR0gp4vO7RoPiXUAm7vzfO+HZc0ApIuzShIBq47mtYBnM+Ng8oUc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(136003)(366004)(376002)(39860400002)(396003)(451199015)(83380400001)(2616005)(186003)(26005)(6506007)(53546011)(6512007)(31696002)(86362001)(36756003)(38100700002)(8676002)(4326008)(66899015)(316002)(41300700001)(31686004)(2906002)(8936002)(5660300002)(6486002)(66556008)(478600001)(66946007)(6916009)(66476007)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZFZEM2o4cjRDTk5lN2lBdW9sU1c5ZUZkdmlkdk1EbkJBYk41Z0xtT2hzeTNL?= =?utf-8?B?NjEzZWRCVnFEK2RJMis2WnJoTGhOWEsrM0Z5NCtHUDE1clZMQmFtK1J2azFm?= =?utf-8?B?V0tHN0pGUjh6NE9HSlpkbmhKY28rRXRoOG51a2VYcDJTZ2ZkN2pjS1lPRlpl?= =?utf-8?B?U2ZHVUJRZk5uaGVqNndoVk50SE4vK1QyNHRJajdSMks5TFAvVzNBQi91b3Iy?= =?utf-8?B?eVJ0RlpuU2plZGx0MXpLY2NySGEyeVI0UE9oM3liMGpnWnVuOFN1WkJTNUlF?= =?utf-8?B?NHNSRUNvdnlwcmtsMm9LeTc4Z3R4YUdJc3VzWHIvbEIrRlh4bWNGWXoxbkVN?= =?utf-8?B?Q1ZtSWZ1SjYxV2Y3SWVTeEgzSUM3Qk9pSlIxMWx1eFhxei9tMzE1UW1sYXpv?= =?utf-8?B?dmNWZjB5R3JIMmtsbVF0MklCbDRkeE1aTW16Skh4d1gwb3pUMkJUNGNlZmY0?= =?utf-8?B?dXNmcncvbmdJTTZlRzlSenkwVlRMeEo1QlJMdWN2RlZZbkZ2UGhJNjRUdHNv?= =?utf-8?B?Ymo1UHo4cEVhaC8ycERtZy82ZE4xcEJlblduNnVPb2xPdkxrejl3V3V4VTRJ?= =?utf-8?B?RDZ5c1ljNEZhM3FwN1NKWU9VaGhDaG1JWkhKVU5NRGtrc0krRHg5RlVUVm5Q?= =?utf-8?B?TWMvdm5oc2VVK0JZMzlURjF1ZGMzRThkOCtkLy9nNWN3b3lDZ3BoQTI0WTdX?= =?utf-8?B?dERZQ3dTR1lKQkZNWjJsZlJuZzkzd1BuTk1hbWJCa01ndUFlM3dIeHhPME55?= =?utf-8?B?bm50VVhBbXRDU0l0ODFnbkxHZ24vdnhGdmVBQ2diUjZOcndBaXcxc1V6TkRk?= =?utf-8?B?NU9tK0ZxZmdvL1NYckF3MG1QMFNWUzJRWXN5STRyZkY1T2JlaDJ3V0lHRlI3?= =?utf-8?B?Q0JteHVDYVZ4TGIvTk5TYUFvRkhNdlNYV0VteUUrOWhGREh3UGwyRVk0dmJV?= =?utf-8?B?aVpIM2FQQnFjaUF5NGZDR1pXK0hBZzNkVTVSMXMwRUVsUGhnbU1TS2J4ZmNR?= =?utf-8?B?Nk9KdG5Makw2QWlKQldKV3o5Nk5oQk83UzZRS2ZzTlkzb29Mb2RUS2FGWTEy?= =?utf-8?B?VHUwOUdad1d2RkJMN05wL0M5aTllbzZlb25tazhvbnhITWZkZzBxeUtQQUVp?= =?utf-8?B?cmRQR1QrRXhDK09MVFlSRzB1QWRYYU5kc2p4ditkZ0tpVkVXSHAvTitPelpL?= =?utf-8?B?clczcU8wQWNrMG4yRlRIUkpwZjczcDQ4dzF0RkZvcnk3a3ZzVXk0NzJhVnJY?= =?utf-8?B?NmZESFJaTUprUmtacWdyZzBEN29RaGtacG9UN1JKMVo5UFBXMnFCSVdxTTRo?= =?utf-8?B?S1F6MG84V3VUKytMSmZrMUdOTnVCSWZPTlZuTEcyK2NVRWE1RWYzOVlmeUhK?= =?utf-8?B?VkNvZkI0YkRjaWZzYU9odmpOSk9mLzMwMzBXNlpPNGxxdHBsNHhpQWVJcTRG?= =?utf-8?B?T3k3UUdzZk1SSXRrVXlJSExKbEUySkthN29ianFBV1BoVm01Mysxd29QNUcr?= =?utf-8?B?a0VsKzNKM2FJamtNRksxREJENjJ1U1FzZE5sRHJPNEpCUUpOTXM5YkZ4VGJE?= =?utf-8?B?RGt0WTQyVmNJZ1NidEJDRGhpWWV2OUdzVitDeFVoWi8wODQ4d21ZUmdZZjM5?= =?utf-8?B?ZDNRQlFGUE1lZm5PSmU4MnR2S2RxS3FtdjNmM3N2Mk9VTml3ZnlnMDJZZ2hI?= =?utf-8?B?R0FUNG9YZ0lIMHJJalhVTzJadHVBbnFFbWpvN0Q4S0J5QjFHRThsbjBtMEUw?= =?utf-8?B?QTVYaGpLbGR6VUkvSG1UZ0FvdmJoYlE4bTdzcmJVbGJBSVVCNEt3bFFXN2xC?= =?utf-8?B?Y0dSbE1EN3VmMXdOMHcyNCtLeGl2MGVZTEl1OE1vSEVlcDVDdU0xYWp4SnB5?= =?utf-8?B?emhnaWl3bG9UeHE3RFlaWTdRaXo3VVQ2SXRoS2t4b1ZWa2tlVGNIeU1UMnZ1?= =?utf-8?B?SG1qZS94Ri9HOU04WGJQb3BWK2hhR2JwRW1uZ3BkYi9hS2RJTE80QTNwRDZ5?= =?utf-8?B?L21xeis2aVhSVHFXTVc4N2Z3Tnc5Rzh3a1FqUTkzbGc5WXkwd1pzZkowa3ZR?= =?utf-8?B?N1FLU01OSk9rNEtQQXVvbkhKTWpHVzF6RlY4OWFWajByMTg0Q3VVUzlhNlE2?= =?utf-8?Q?4dkkcLtLtXH4X27PysBUpRqDN?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1184f8a4-23b1-4bb1-074a-08daefbb9146 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2023 07:56:50.2804 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6sLSIJxn6efdQWTCApkn9G0rXtAqqn5qqGTTB/f1ZyKZmC6vJm6XnDPYIOWw8jRNDKLEg8cf3HDZ02gjou3exg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB9127 On 05.01.2023 23:28, Andrew Cooper wrote: > On 05/01/2023 8:15 am, Jan Beulich wrote: >> On 04.01.2023 19:34, Andrew Cooper wrote: >>> On 04/01/2023 5:04 pm, Jan Beulich wrote: >>>> On 03.01.2023 21:09, Andrew Cooper wrote: >>>>> + if ( sz > INT32_MAX ) >>>>> + return -E2BIG; /* Compat guests. 2G ought to be plenty. */ >>>> While the comment here and in the public header mention compat guests, >>>> the check is uniform. What's the deal? >>> Well its either this, or a (comat ? INT32_MAX : INT64_MAX) check, along >>> with the ifdefary and predicates required to make that compile. >>> >>> But there's not a CPU today which can actually move 2G of data (which is >>> 4G of L1d bandwidth) without suffering the watchdog (especially as we've >>> just read it once for strlen(), so that's 6G of bandwidth), nor do I >>> expect this to change in the forseeable future. >>> >>> There's some boundary (probably far lower) beyond which we can't use the >>> algorithm here. >>> >>> There wants to be some limit, and I don't feel it is necessary to make >>> it variable on the guest type. >> Sure. My question was merely because of the special mentioning of 32-bit / >> compat guests. I'm fine with the universal limit, and I'd also be fine >> with a lower (universal) bound. All I'm after is that the (to me at least) >> confusing comments be adjusted. > > How about 16k then? Might be okay. If I was to pick a value, I'd use 64k. Jan From xen-devel-bounces@lists.xenproject.org Fri Jan 06 08:37:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 08:37:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472377.732572 (Exim 4.92) (envelope-from ) id 1pDiE9-0007TF-3e; Fri, 06 Jan 2023 08:37:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472377.732572; Fri, 06 Jan 2023 08:37:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDiE8-0007T8-W3; Fri, 06 Jan 2023 08:37:24 +0000 Received: by outflank-mailman (input) for mailman id 472377; Fri, 06 Jan 2023 08:37:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDiE8-0007Sy-53; Fri, 06 Jan 2023 08:37:24 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDiE8-0000zV-2X; Fri, 06 Jan 2023 08:37:24 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDiE7-0000Kv-Ml; Fri, 06 Jan 2023 08:37:23 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pDiE7-0005an-M8; Fri, 06 Jan 2023 08:37:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=oaay86yFGUMaN1OluyyeALLbyQBWNI5Vw+Fo2g0aicE=; b=LWJIS4vFBiZUa3N3kiZjPlBSq2 WeYNHCXkDGjHi3jkkvZ4LTU2rlZESP3BTh0bwPncf4vxChY7CPHyJiQhXn4RjdZR4OnUyDHovBoA7 fuo5s9rO+xbpvMba9E0Bl4TxZhwI8qTO2ZQdBIgTpwbub8rcPYfV1E4nB1TmvFEs9xLE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 175592: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-examine-bios:xen-install:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=671f50ffab3329c5497208da89620322b9721a77 X-Osstest-Versions-That: xen=c1df06afe578f698ebe91a1e3817463b9d165123 From: osstest service owner Date: Fri, 06 Jan 2023 08:37:23 +0000 flight 175592 xen-unstable real [real] flight 175600 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/175592/ http://logs.test-lab.xenproject.org/osstest/logs/175600/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail pass in 175600-retest Tests which did not succeed, but are not blocking: test-amd64-i386-examine-bios 6 xen-install fail like 175573 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 175573 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175573 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 175573 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175573 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175573 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 175573 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 175573 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 175573 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 175573 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 175573 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175573 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 175573 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen 671f50ffab3329c5497208da89620322b9721a77 baseline version: xen c1df06afe578f698ebe91a1e3817463b9d165123 Last test of basis 175573 2023-01-05 02:18:00 Z 1 days Testing same since 175592 2023-01-05 19:38:50 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Demi Marie Obenour Jan Beulich jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git c1df06afe5..671f50ffab 671f50ffab3329c5497208da89620322b9721a77 -> master From xen-devel-bounces@lists.xenproject.org Fri Jan 06 09:16:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 09:16:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472387.732583 (Exim 4.92) (envelope-from ) id 1pDipr-0003Or-7k; Fri, 06 Jan 2023 09:16:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472387.732583; Fri, 06 Jan 2023 09:16:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDipr-0003Ok-57; Fri, 06 Jan 2023 09:16:23 +0000 Received: by outflank-mailman (input) for mailman id 472387; Fri, 06 Jan 2023 09:16:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDipp-0003Oa-Rw; Fri, 06 Jan 2023 09:16:21 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDipp-00020C-PP; Fri, 06 Jan 2023 09:16:21 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDipp-0001MM-4I; Fri, 06 Jan 2023 09:16:21 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pDipp-00029C-3j; Fri, 06 Jan 2023 09:16:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=jpTPvr9GvyBEH8ptwigiUIrODYrUeuSuGyY7qQEASt0=; b=WCHTlGKlbXVMoZjGfEEC46jaXa bRmwuQGkVlwYCMO941uel0y209A0vUs7kZsqbov1lTW/ECe6+jyOtfc9uUxhLMFf04eFX1hi7OoD9 26wQgrzbj/KZc3Wn1uCz7+BRdz6VDLeFYk2WXgkJ9b7RYD52XcEuLC8aacEuSR2UVFz8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 175595: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=d1852caab131ea898134fdcea8c14bc2ee75fbe9 X-Osstest-Versions-That: qemuu=f8af61fa14441e67300176a5e07671ea395426b3 From: osstest service owner Date: Fri, 06 Jan 2023 09:16:21 +0000 flight 175595 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/175595/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 175590 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 175590 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175590 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175590 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 175590 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 175590 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175590 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175590 test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu d1852caab131ea898134fdcea8c14bc2ee75fbe9 baseline version: qemuu f8af61fa14441e67300176a5e07671ea395426b3 Last test of basis 175590 2023-01-05 17:07:09 Z 0 days Testing same since 175595 2023-01-06 01:55:04 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: John Snow Peter Maydell jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git f8af61fa14..d1852caab1 d1852caab131ea898134fdcea8c14bc2ee75fbe9 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Fri Jan 06 10:28:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 10:28:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472396.732593 (Exim 4.92) (envelope-from ) id 1pDjxL-00026x-Hf; Fri, 06 Jan 2023 10:28:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472396.732593; Fri, 06 Jan 2023 10:28:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDjxL-00026q-Eh; Fri, 06 Jan 2023 10:28:11 +0000 Received: by outflank-mailman (input) for mailman id 472396; Fri, 06 Jan 2023 10:28:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDjxK-00026k-2A for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 10:28:10 +0000 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [2a00:1450:4864:20::12d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ceb701eb-8dac-11ed-b8d0-410ff93cb8f0; Fri, 06 Jan 2023 11:28:06 +0100 (CET) Received: by mail-lf1-x12d.google.com with SMTP id g13so1387619lfv.7 for ; Fri, 06 Jan 2023 02:28:06 -0800 (PST) Received: from fedora.. ([195.234.76.149]) by smtp.gmail.com with ESMTPSA id g1-20020a056512118100b004b5732080d1sm107093lfr.150.2023.01.06.02.28.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jan 2023 02:28:04 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ceb701eb-8dac-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=NweUbldW38duLDKXCcl5QGEb3HNDCi1J7bPtOMrCqec=; b=OeezEwoj7ine/gcxcZW1zzNRA7i8wpct49Nd4JgA4zr1yDpClhm9WNCrqzM+fTYpY5 BNSu6Kxo2+EK2QAdtoYNG9S7uYhtQTa+FChFBfW/ikhXKZK7DB9NzjEOG+fBFMYeowIS 78l5EXV1QmB4iNaKD+2AwQq88rk1Tjfn+ukOiSq7yLDzoXehu1CTssFu5qt6n6WjrGqS q6YQAt2rG7SzZIM31jJQnsQtxnUru8UqJ+IOpNsLGzc2eABHlB0lta1ErjcbrVQ2769x VDJYDI6ntRFKLBWzhN8MzmhsK3HD99AEsHDMAUi/gvOKx++8NABafbb+xqAEgjw1Sn36 3U2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NweUbldW38duLDKXCcl5QGEb3HNDCi1J7bPtOMrCqec=; b=CpZwv2Cp8/WwXSceqgLKEqeB2mXXtn2tQ3a9Z5lqv20LrolI41YHLzFPzn9PU25Hnd jscpR84ei4S0sD+XOH6rHiElrvySZFhoEYkuVxshSXLw6yRBVoWlg+K/VN8RGCfRGv1F j1QolQ8op++fP4u+eKNe72p/SJES2+A7pv3QJprk2k0hLl6BwvHICSpt1KO4CFZhIWhb pG4Wr3u2PCXxawb/U75LBzQMi1JagupsP3AAo0SVAkBmS3ps7JGc+GXb8V9SXv/gx1pa dqYxDnQfESTRi3HvWn+1ED9IQNyHxiaep2cBynWMUdE6X5nELf1Qyj8wHKVg4V/pbYF6 JMyQ== X-Gm-Message-State: AFqh2ko2LySfzEZy8rirIwxAMy+Hazpi0NGamnFdJPY+gjFZ9GgbVm+v ygfQ2Erm7ypVMr469JWy0k4clDIYsPokdjLG X-Google-Smtp-Source: AMrXdXs2EFiit5RARTsnthGpvKYH7U73IESbrbaV/NAHQICGUs6kEHu9To4eM5uoRA4Tco6rDK5GBA== X-Received: by 2002:ac2:558f:0:b0:4cc:597b:583e with SMTP id v15-20020ac2558f000000b004cc597b583emr1634692lfg.55.1673000885346; Fri, 06 Jan 2023 02:28:05 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Doug Goldstein Subject: [PATCH] automation: temporarily disable CONFIG_COVERAGE for RISC-V randconfig jobs Date: Fri, 6 Jan 2023 12:28:01 +0200 Message-Id: <5f47cd290a5f173655d7dace7f61384e1f32c8c1.1673000881.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit As common isn't built for RISC-V architecture now, accordingly, common/coverage (where __gconv_* function are defined) isn't built either but randconfig may decide to enable CONFIG_COVERAGE which will lead to the following compilation error: riscv64-linux-gnu-ld: prelink.o: in function `.L0 ': arch/riscv/early_printk.c:(.text+0x18): undefined reference to `__gcov_init' riscv64-linux-gnu-ld: arch/riscv/early_printk.c:(.text+0x40): undefined reference to `__gcov_exit' Signed-off-by: Oleksii Kurochko --- automation/gitlab-ci/build.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml index 6784974619..a292f0fb18 100644 --- a/automation/gitlab-ci/build.yaml +++ b/automation/gitlab-ci/build.yaml @@ -667,6 +667,8 @@ riscv64-cross-gcc-randconfig: CONTAINER: archlinux:riscv64 KBUILD_DEFCONFIG: tiny64_defconfig RANDCONFIG: y + EXTRA_FIXED_RANDCONFIG: + CONFIG_COVERAGE=n riscv64-cross-gcc-debug-randconfig: extends: .gcc-riscv64-cross-build-debug @@ -674,6 +676,8 @@ riscv64-cross-gcc-debug-randconfig: CONTAINER: archlinux:riscv64 KBUILD_DEFCONFIG: tiny64_defconfig RANDCONFIG: y + EXTRA_FIXED_RANDCONFIG: + CONFIG_COVERAGE=n ## Test artifacts common -- 2.38.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 06 10:30:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 10:30:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472403.732605 (Exim 4.92) (envelope-from ) id 1pDjz9-00032L-TO; Fri, 06 Jan 2023 10:30:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472403.732605; Fri, 06 Jan 2023 10:30:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDjz9-00031s-Pw; Fri, 06 Jan 2023 10:30:03 +0000 Received: by outflank-mailman (input) for mailman id 472403; Fri, 06 Jan 2023 10:30:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDjz7-0002dy-MU; Fri, 06 Jan 2023 10:30:01 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDjz7-0003fn-K7; Fri, 06 Jan 2023 10:30:01 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDjz7-0004Rf-Ao; Fri, 06 Jan 2023 10:30:01 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pDjz7-0008IM-AJ; Fri, 06 Jan 2023 10:30:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=psVmlWnKebrLqwSydI25TOhJ0s5wtPmbJuzCuPgU4KA=; b=Ep3QxLWgXKXnj6NFcPLyrB3fRh dPM0hxdtvthUuiyQpLn7P8xZX4x8RQpNLbF4oxnK73LOQk7sqZO4w7eoZ4salWuf1Z2n6vGDtqI8p cAwkFoZuyxYpXQUg+RnaGwsnSrqQ1QjptFi41SMVGSYKli+Uy3V7EaDb9rsAVLyayRZ8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 175597: tolerable all pass - PUSHED X-Osstest-Failures: libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: libvirt=6cd2b4e101cc0b60c6db83f763a08daea67ad6eb X-Osstest-Versions-That: libvirt=78b3400e50ee0ba01575749728aae9c79d9d116b From: osstest service owner Date: Fri, 06 Jan 2023 10:30:01 +0000 flight 175597 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/175597/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 175577 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 175577 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 175577 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: libvirt 6cd2b4e101cc0b60c6db83f763a08daea67ad6eb baseline version: libvirt 78b3400e50ee0ba01575749728aae9c79d9d116b Last test of basis 175577 2023-01-05 04:18:49 Z 1 days Testing same since 175597 2023-01-06 04:20:37 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Michal Privoznik jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git 78b3400e50..6cd2b4e101 6cd2b4e101cc0b60c6db83f763a08daea67ad6eb -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Jan 06 10:31:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 10:31:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472413.732615 (Exim 4.92) (envelope-from ) id 1pDk04-00043E-BQ; Fri, 06 Jan 2023 10:31:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472413.732615; Fri, 06 Jan 2023 10:31:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDk04-000437-8i; Fri, 06 Jan 2023 10:31:00 +0000 Received: by outflank-mailman (input) for mailman id 472413; Fri, 06 Jan 2023 10:30:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDk02-0003xJ-MJ for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 10:30:59 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 32d9d40b-8dad-11ed-91b6-6bf2151ebd3b; Fri, 06 Jan 2023 11:30:56 +0100 (CET) Received: from mail-dm6nam11lp2172.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.172]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 06 Jan 2023 05:30:50 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SJ0PR03MB6778.namprd03.prod.outlook.com (2603:10b6:a03:40d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Fri, 6 Jan 2023 10:30:48 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5944.019; Fri, 6 Jan 2023 10:30:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 32d9d40b-8dad-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1673001056; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=rXUw/uc30/WNZGuy9EcIKoULDRRv8AEzspJUmBKxztE=; b=LuAtUQMx9rG5F/OpBowChq8ca1mtIUBuvBXTqLX0F+vN6ha2CSyp8B7S WQLrBsUZEXc+KBkCt95aYfbjiyDFZIuuKAiSHM37o3R09MVd5VtQ7ytOi w1hTngPCorqtWGi42bupqYzLp1sds0m099+IAq5yhHNgnfzWtEKsoKGzJ M=; X-IronPort-RemoteIP: 104.47.57.172 X-IronPort-MID: 90403247 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:rBzbTKskuu5UpgUpCNI0ddfP5OfnVLVfMUV32f8akzHdYApBsoF/q tZmKWvQMvbYYGXwftpybY+x8hlTsZaDmIcyHVFl/yozF3sU+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg0HVU/IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj5lv0gnRkPaoQ5AaGySFMZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwEDEEUUuimcaM3rOwR7dumuAcEc/BBdZK0p1g5Wmx4fcOZ7nmGvyPyfoGmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osj/60b4C9lt+iHK25mm6xo G7c8nu/KRYdLNGFkhKO8262h/+JliT+MG4XPOzgqqYx2gHMroAVICVRRFyAsdubsXX9ZtRuC xM+q3A/jKdnoSRHSfG4BXVUukWsuRoRWMFREqs59RuKwarX5C6WA2EFSnhKb9lOnN87Q3km2 0GEm/vtBCdzq/uFRHSF7LCWoDiufy8PIgcqfjQYRAEI593ipoAbjR/VSNtnVqmvgbXdFjD5x TSXpyEWnbQNitUK0a799lfC6xqnr4LFSQMd7QzNUmWoqAh+YeaYi5eA7FHa6bNMKdifR1zY5 XwcwZHBtqYJEI2HkzGLTKMVBra16v2ZMTrax1lyA50m8Dfr8HmmFWxN3AxDyI5SGp5sUVfUj IX74Gu9OLc70KOWUJJK IronPort-HdrOrdr: A9a23:L+UR3a9Qw7jKL3tI1NBuk+DlI+orL9Y04lQ7vn1ZYhZeG/bo8P xG+8526faUslkssRQb8uxoV5PvfZqxz/9ICOsqTNSftXjd2FdARbsKheGO/9SKIVydygcy79 YFT4FOTPH2EFhmnYLbzWCDYrAdKQC8gcWVuds= X-IronPort-AV: E=Sophos;i="5.96,304,1665460800"; d="scan'208";a="90403247" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Kr1jw6yrjfFBf+xSNrxjPuT+BBWEE91c9/80LgY2sCkfDwp/3A4MpUvjPfrIXdnqQiw8b2J6xVVqlZH6hU8Om9IZmr8fNYiN/ZKzTFRV3cBnVpDCJ9xIYwlV65N6DcR9B+WOMAD8j71VL29vEQxPeNp/c4wjMG9/eEB/RWM3Mty9aixfvUDRvrd+CZqz2gwKPML+YczXCzW/Xu+gOov6OoxoxZb/CvpaabL1zC73vy7MxBE30WzclNNsasKaILCnBOnnysGENAniOSYrMxsLjkmPVgd3Ym8rqzKKOEoIddYsU0WCLTxgt63vAQZZQ8lPtzK3npXeHVO4FntyvMBEKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rXUw/uc30/WNZGuy9EcIKoULDRRv8AEzspJUmBKxztE=; b=LV+Zw8acpp9ka4Ctrsu3e7RLg2BCt7wDlHNvKzifEjXwHtFQ+cah7Nt1szJ6Y4z0cJuAARFrPEX9HsRE7U8AyJnvvbvu38Tl46wUwuGgtd5ZLtWs9C5pGzBmHRiy4/jU4RSUhRdypMuX1BPz1st0YQyvdKjP/h/J+VrmNWAc1pUtAmN/gR8MIe+tpQrsK7PQCugyy463aQAvfP1do+S0bwdumytvB5YtkAj91tMXuT7Zs9tb/k4n0jjd+FjVIIK0Okw75o0yz68Cg0It2co7ohCUoO2G9Pbry2MYIC2p+9VU9xE7NaCRXIPRoCiHB0dLKhvN6RchCx1J34tQ1w04Sw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rXUw/uc30/WNZGuy9EcIKoULDRRv8AEzspJUmBKxztE=; b=v2vjaPtuZ1eOILbcPir4UdLx+7kuWS5ixM9+u7vuKqUyb8hqU0yq5XuozjLCbWuJmexSAckfTRbquVNjKZEmbwnswcT2lF+iKsQoPWPbRct+JzBLPKNNtoIzFQyBVnc1RPhWzPP/8XC7oo4+G2HkWDZPaKMezmVnlEaBtRoi+OI= From: Andrew Cooper To: Oleksii Kurochko , "xen-devel@lists.xenproject.org" CC: Stefano Stabellini , Gianluca Guida , Doug Goldstein Subject: Re: [PATCH] automation: temporarily disable CONFIG_COVERAGE for RISC-V randconfig jobs Thread-Topic: [PATCH] automation: temporarily disable CONFIG_COVERAGE for RISC-V randconfig jobs Thread-Index: AQHZIbmTfeWmiVKwmkCDRKG76wzwDK6RMG4A Date: Fri, 6 Jan 2023 10:30:48 +0000 Message-ID: <5c03fcbf-d08a-5d0a-d217-c0f4fbdeb133@citrix.com> References: <5f47cd290a5f173655d7dace7f61384e1f32c8c1.1673000881.git.oleksii.kurochko@gmail.com> In-Reply-To: <5f47cd290a5f173655d7dace7f61384e1f32c8c1.1673000881.git.oleksii.kurochko@gmail.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|SJ0PR03MB6778:EE_ x-ms-office365-filtering-correlation-id: 79d96588-837d-4481-7eef-08daefd113e3 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8Thc07je6C/RbJ7y5HLZDTCg8l/nFkzMTo2vR5xaG4gYG3yQvEf2QQm2UNMeCB4EAe8ijZRPXR1QzH0GTcgYdm2MS4/4SkTKuwzMv5jayRMPbs9T8oEN+0zPhLn7RAkwe5hsqQMVHCB7YpQtE6pjw0tLDS7QMlpDYJbqeXdBGM2eBw/nYCxlt1yHWOaRyvJVVkWZ9eCq/WxrPS7svvNC/y0aTiby9P9wKUI5iKrIhKmQ5rkpDWXDxOAFHqz+4Q7dDyiGtxG+BEySrOrAT/WIPXnwdTn27fojhTFKnejHkbq6rKmny043eNM42O3otokLivSatog119kM0KtSPOFQqlc8lZgJ/wHKtsAAIx3f/GkyspSVnctCQRaYV2AHFYBtxdquRwkILswqO+OUyWCp3Fm2obgeVJH1n09fZLrba6vpONr+2yiInA8rCnWuzNMpwcluVFiD17YhTdJr2Sg3krXaWrqzKvgflBzjiq05Bq6TNWxgdHnntQMg8shFwAz/iOFwhzR/Avfh4WxgFrTGKawYW8juoaIZbsyW/hR03PO7g2FI/Yo5+/poi6lPlU54qOQJwYTfyH453ZjPkCsisCHuRdqKk8LXZRd7TWw9dUm5liMe/HgrmVMj4YH1sTlp1Obr23Y8wOLMM1U1B/U+ZvktHWcZ04iT4ExHulwPX856mms0y10ohcKRAsFJJTPK00DSr+zjM7UZ6WsdQj8gXrrSatozbt8ST201+UUzr9jsxKhH5wokuRkm/CvrTx8gFgyb8tvhXs7Kvum9SRaCyQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(366004)(136003)(396003)(346002)(451199015)(2616005)(186003)(26005)(53546011)(6512007)(82960400001)(38100700002)(31696002)(86362001)(4744005)(122000001)(36756003)(38070700005)(31686004)(316002)(4326008)(8936002)(66946007)(64756008)(5660300002)(8676002)(91956017)(76116006)(66476007)(478600001)(66556008)(66446008)(6506007)(41300700001)(110136005)(54906003)(6486002)(71200400001)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?d1AwaVRJckw0aERUZGRNMnQzVHlBSWRxTjBldFJmU0ZrTWFzcG1kUW1YYkRN?= =?utf-8?B?dVEyT2M5TE9yVyt4M2h4WUVVTUl2eG5VODcxYnluY0pGc2pVV2V6ZnhsazhZ?= =?utf-8?B?VnVhV0lhRHN5cFYyM0RuakJHU0FUNWhKblhCRlo2WkFsOWxjb1BhM0Jzb1Ez?= =?utf-8?B?cDFCVlowSGVlOG9mSzZCZ3crUXlqRURqQXNhNHJaWENDK3B0NDlNSkpTUnFE?= =?utf-8?B?YWZXYnBIclB1bE9odVVvWE5Pb0tFbldseTZ3TjdoUmM2bVVIOWN4MTAzU2pC?= =?utf-8?B?MmtDazhpYlFnRlpOd3BPcW1wUjh1MkIxZGh0dmk4Qlp0ZldZL3ZBcU1rVmNo?= =?utf-8?B?TkZ4MGo2VFlUV0EwSWlSTmg0OTJ3QnNRV1ZuZXhJV1hPZEw2TEVmdWd4anhK?= =?utf-8?B?dlNOaWhIYVZFNy9HMzU4dGlsSXFrTjRiNGdvRHllRXVpK1RFOWpUZk0vSTBq?= =?utf-8?B?QnU1STRvM3c0UllIUzgwSFNXcXdaTGYzeVNvY3RDN1ZReW1XMEZ4d0ExdGtO?= =?utf-8?B?T082a1hzTm9SNVVOeTVPRGhWdE5LdlZXMG53UjJ0UnhWWDV5TEhRTnBGZWpG?= =?utf-8?B?VHFlbUxKU0Y4SGxGTy9OSjdPVTV6TVY5UDhHSXpiQ0h6aWtheFNycTdzREhl?= =?utf-8?B?eGtqdWR6MUwxK3JHVHpLdGFNaklZbjdkc3lEZkorQldoeHZQTGNYbXF6aWpH?= =?utf-8?B?UmFHVzNuYnB2aGRnYlcxTkh5cHlVS0wwbXV1b0hRbXo5OTdQQXR3MlJWQm4r?= =?utf-8?B?V0xLNXI2cnc2TWR2YVNlRDBoZm9nYk8vcVoxcFdjdllxMVo3dDVKZVJ5N05s?= =?utf-8?B?bmIwbUZURFJoS09LM2kzTDVxTXNhYll1eDI1SkI1R2wvTFdrQWdSVU5FN0d4?= =?utf-8?B?amFaclhnVnRaakNuTnBoZVEzVzJOL0J1QytjU2wwRWJLMGRWNWo5Vlc1UVdn?= =?utf-8?B?L0RZWmhEOTV1SThSaHlacldzSW4yczYvSU9lNVBIQVh1VGlPQXNmd2F1R2dh?= =?utf-8?B?Um9TSlhuVXovcC83VWVyVS8zUDlFaUhKVXlmMGVYcEJ0SU5Ec05ha0lvMTUz?= =?utf-8?B?dlBSSXMzbk12bUxyaE5pa1kycURvVUNWak11ZTltcjkrWXdycElyTkNPRjNE?= =?utf-8?B?Y1FuNXBlQTEzL2diWHpVR2E0QjllOWt5S1lrWjNqaEJYTnhPbWlwZDdoYVl5?= =?utf-8?B?Qm1LdHJndWR3akkzK01mWXNvR3p0SnFURUp1WVd4RGtKR0dyeXEvdXhUSnM0?= =?utf-8?B?aVlhSkpFb1BsWll6c2FkVHBLWXZ4Sk5IQWY0eDdCc250azF4KzVZSTYwcXBm?= =?utf-8?B?cVQ5dlVGdVlYL2lNWkpVSklDRVhHR1ZqUCswcHMwMnlRZCs1c2pFRzAvYzdh?= =?utf-8?B?bU5GN212c1V1ZUhualJTcVZNUVRNbzhpTHg4MVlYcndldFovWk9jbVh0TnVs?= =?utf-8?B?cmVrbDhheEFkeFpDajZoN2RwNmtCbEFrd0NabE5KWUpHOXB1enNIWU0xSXp4?= =?utf-8?B?TVF0dW8rWWNxckdlenhiYWpwempBZHVBNWZkcGlQVUVjd2RHcjQ1elpLRE1p?= =?utf-8?B?RndQVUs1MUxhZkJEaFBod01tT2tHM1NjRmFDMEsybFN4NDB0NWRKbUMwczJE?= =?utf-8?B?ZkJ0M0FNS21KeGcvZzRNQlFJNjJaNUlNc0FhVmc5UXFvVGR1cXlJTi9menV1?= =?utf-8?B?UWh4RllNTU9ZTHE5cWFPdGNKNEVROXo5VDJNckVLQ3lrdFJsalpUMHlJKzlX?= =?utf-8?B?amsrTUQ3MW00TXY5R0tmM255MEtwb2tSQVY3MFE2NTZTbXVyNW1zS2Ixdzcx?= =?utf-8?B?YklvRHRLaWR6K2QrNWRiU3V1azhzc1I3Y2hoT0tacVdpZDMrb1VrWTJSS3dV?= =?utf-8?B?QVlDNkpTMkgrRTZhSFBPSiszVnhkdUNJWXYxS3lzRERwclVkU01HcVpWeVg1?= =?utf-8?B?TS94Yks5Z202OEl3UXQwd3laeGU4bUh0MEpVTlRSSmJtWnVIVGF6akdqdFRO?= =?utf-8?B?NStQTGpxMFRndTdRd1FkNXJ1RDFVN2hsdHN2RDVpai8xT25Qejk2TU92R04v?= =?utf-8?B?TjY0cTY0eVFWR2xVaVpWUnNpSVhuVFlFV3QzSmFpaUVPYndtcGkwQjFWRk80?= =?utf-8?B?WW4yYUd4MzNDZzFOTisyMURNNjRiamlRWnJNSGhWUlJoakFVTFQ2dU9aYUMv?= =?utf-8?B?NWc9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <6E45605D93C7A547BF138F56FC0FE356@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: hPGcfu6MHrGkHVLPUt82U8hgAKNhDfHJorm64O8cMoH8AN2RsVrOJk3h9Rmq+eJerI5h5+Fvp4OEWb/1oKqN4LtrMEk1+Z99SOfgGfqjH3+kPlwBHN+L2lQ7YFur8ei0a+T29q8fcMJrs2aVeLDvmewD+CtCLTsiB195+2H9JEhNB19m5ttIgNa3Y106VIo4D70MOL+029poH+HUcvYbHY0eWcpBYoshV/Blf0YflrzYfW9TMhPwdS6MX6o8r1pI7udqlmofIQlDTFVytAliNxAkfCtrZ3jA4MLi+Aoke3/R6BUSQSnOBAjHzoxvweHRjNRufV4oObjFSmNuDjzm8XrFu30ck/VNRUBVDOtvvLu12vSlDTWqBYYp4ZBnGHxr/ZdQAJ6AKpWKYDgbE8WAw6G5J2BTn2uYEjGwt6rCn0Eh1oYPexrLsbHD9lnNfsXed4jsuMDw5KN/3vzQgQNbJCUWp0awDEtMHsrRRmf7S3rV/0AgDD+lKbQ4M+p2n7QiO3LFIEsnWazjAi5zkNH1I/MIsdm/VjZmx7dIcoq+2sTjMpDkGgGndIMB0l2wq+kNIDRIveOJ2sCiMci6KngZZv80z1phnsmSzRACr45J//nchKw7BZ47N8E1FHX/EVUfLOFCwijO+XFLjLa4EQJRfsWSNzfDIsaYnJ+42+O+TE4jYne0IG+xoIns+hAu98DtOygXLYqqqR52Fxd+D+h3SwuDLcl+81YSepdsU6BB1VU4r/N4uaRU7hee2geIDAr9s086wM2I9pcAmx5C2tTSTBfX/sw6vmNFLvAtMX0EgEirKlKzcBLcpLtV6xkZMAGrAgcSRM6lJR4clWxZtY7/LNHQr/fwcEJCn5G6lCTQUeUxCy4JG1x7wqE8R3rj/+qL/dCWgt2QJqccqaF7Z9Xe8g== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 79d96588-837d-4481-7eef-08daefd113e3 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jan 2023 10:30:48.7069 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bOcdNoYJknmUMi8azqM/NmVNSuJRHTfVWVm+M7lpyBdBH14jfMgMAvyEC7xmIMWXZNSC4gjh+HUhHzD3VgYXxQndmzshMiIFh6fOhz8LAf4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6778 T24gMDYvMDEvMjAyMyAxMDoyOCBhbSwgT2xla3NpaSBLdXJvY2hrbyB3cm90ZToNCj4gQXMgY29t bW9uIGlzbid0IGJ1aWx0IGZvciBSSVNDLVYgYXJjaGl0ZWN0dXJlIG5vdywgYWNjb3JkaW5nbHks DQo+IGNvbW1vbi9jb3ZlcmFnZSAod2hlcmUgX19nY29udl8qIGZ1bmN0aW9uIGFyZSBkZWZpbmVk KSBpc24ndCBidWlsdCBlaXRoZXINCj4gYnV0IHJhbmRjb25maWcgbWF5IGRlY2lkZSB0byBlbmFi bGUgQ09ORklHX0NPVkVSQUdFIHdoaWNoIHdpbGwgbGVhZCB0bw0KPiB0aGUgZm9sbG93aW5nIGNv bXBpbGF0aW9uIGVycm9yOg0KPg0KPiByaXNjdjY0LWxpbnV4LWdudS1sZDogcHJlbGluay5vOiBp biBmdW5jdGlvbiBgLkwwICc6DQo+IGFyY2gvcmlzY3YvZWFybHlfcHJpbnRrLmM6KC50ZXh0KzB4 MTgpOg0KPiAgICAgdW5kZWZpbmVkIHJlZmVyZW5jZSB0byBgX19nY292X2luaXQnDQo+IHJpc2N2 NjQtbGludXgtZ251LWxkOiBhcmNoL3Jpc2N2L2Vhcmx5X3ByaW50ay5jOigudGV4dCsweDQwKToN Cj4gICAgIHVuZGVmaW5lZCByZWZlcmVuY2UgdG8gYF9fZ2Nvdl9leGl0Jw0KPg0KPiBTaWduZWQt b2ZmLWJ5OiBPbGVrc2lpIEt1cm9jaGtvIDxvbGVrc2lpLmt1cm9jaGtvQGdtYWlsLmNvbT4NCg0K QWNrZWQtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+DQo= From xen-devel-bounces@lists.xenproject.org Fri Jan 06 10:36:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 10:36:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472422.732637 (Exim 4.92) (envelope-from ) id 1pDk5Q-00050f-6Q; Fri, 06 Jan 2023 10:36:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472422.732637; Fri, 06 Jan 2023 10:36:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDk5Q-00050W-3L; Fri, 06 Jan 2023 10:36:32 +0000 Received: by outflank-mailman (input) for mailman id 472422; Fri, 06 Jan 2023 10:36:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDk5P-000500-5n for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 10:36:31 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDk5K-0003o2-SY; Fri, 06 Jan 2023 10:36:26 +0000 Received: from 54-240-197-227.amazon.com ([54.240.197.227] helo=debian.cbg12.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pDk5K-0001wX-Ir; Fri, 06 Jan 2023 10:36:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" From: Paul Durrant To: x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Paul Durrant , Sean Christopherson , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , David Woodhouse Subject: [PATCH v7 1/2] KVM: x86/cpuid: generalize kvm_update_kvm_cpuid_base() and also capture limit Date: Fri, 6 Jan 2023 10:35:59 +0000 Message-Id: <20230106103600.528-2-pdurrant@amazon.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20230106103600.528-1-pdurrant@amazon.com> References: <20230106103600.528-1-pdurrant@amazon.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit A subsequent patch will need to acquire the CPUID leaf range for emulated Xen so explicitly pass the signature of the hypervisor we're interested in to the new function. Also introduce a new kvm_hypervisor_cpuid structure so we can neatly store both the base and limit leaf indices. Signed-off-by: Paul Durrant --- Cc: Sean Christopherson Cc: Paolo Bonzini Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: Dave Hansen Cc: David Woodhouse v7: - Morph kvm_update_hypervisor_cpuid() into kvm_get_hypervisor_cpuid() - Place the definition of struct kvm_hypervisor_cpuid to avoid churn in patch #2. v6: - New in this version --- arch/x86/include/asm/kvm_host.h | 7 ++++++- arch/x86/kvm/cpuid.c | 24 +++++++++++++----------- 2 files changed, 19 insertions(+), 12 deletions(-) diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h index c70690b2c82d..85cbe4571ac9 100644 --- a/arch/x86/include/asm/kvm_host.h +++ b/arch/x86/include/asm/kvm_host.h @@ -678,6 +678,11 @@ struct kvm_vcpu_hv { } nested; }; +struct kvm_hypervisor_cpuid { + u32 base; + u32 limit; +}; + /* Xen HVM per vcpu emulation context */ struct kvm_vcpu_xen { u64 hypercall_rip; @@ -826,7 +831,7 @@ struct kvm_vcpu_arch { int cpuid_nent; struct kvm_cpuid_entry2 *cpuid_entries; - u32 kvm_cpuid_base; + struct kvm_hypervisor_cpuid kvm_cpuid; u64 reserved_gpa_bits; int maxphyaddr; diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c index 69768e4d53a6..db5a4d38fcd0 100644 --- a/arch/x86/kvm/cpuid.c +++ b/arch/x86/kvm/cpuid.c @@ -180,15 +180,15 @@ static int kvm_cpuid_check_equal(struct kvm_vcpu *vcpu, struct kvm_cpuid_entry2 return 0; } -static void kvm_update_kvm_cpuid_base(struct kvm_vcpu *vcpu) +static struct kvm_hypervisor_cpuid kvm_get_hypervisor_cpuid(struct kvm_vcpu *vcpu, + const char *sig) { - u32 function; + struct kvm_hypervisor_cpuid cpuid = {}; struct kvm_cpuid_entry2 *entry; + u32 base; - vcpu->arch.kvm_cpuid_base = 0; - - for_each_possible_hypervisor_cpuid_base(function) { - entry = kvm_find_cpuid_entry(vcpu, function); + for_each_possible_hypervisor_cpuid_base(base) { + entry = kvm_find_cpuid_entry(vcpu, base); if (entry) { u32 signature[3]; @@ -197,19 +197,21 @@ static void kvm_update_kvm_cpuid_base(struct kvm_vcpu *vcpu) signature[1] = entry->ecx; signature[2] = entry->edx; - BUILD_BUG_ON(sizeof(signature) > sizeof(KVM_SIGNATURE)); - if (!memcmp(signature, KVM_SIGNATURE, sizeof(signature))) { - vcpu->arch.kvm_cpuid_base = function; + if (!memcmp(signature, sig, sizeof(signature))) { + cpuid.base = base; + cpuid.limit = entry->eax; break; } } } + + return cpuid; } static struct kvm_cpuid_entry2 *__kvm_find_kvm_cpuid_features(struct kvm_vcpu *vcpu, struct kvm_cpuid_entry2 *entries, int nent) { - u32 base = vcpu->arch.kvm_cpuid_base; + u32 base = vcpu->arch.kvm_cpuid.base; if (!base) return NULL; @@ -439,7 +441,7 @@ static int kvm_set_cpuid(struct kvm_vcpu *vcpu, struct kvm_cpuid_entry2 *e2, vcpu->arch.cpuid_entries = e2; vcpu->arch.cpuid_nent = nent; - kvm_update_kvm_cpuid_base(vcpu); + vcpu->arch.kvm_cpuid = kvm_get_hypervisor_cpuid(vcpu, KVM_SIGNATURE); kvm_vcpu_after_set_cpuid(vcpu); return 0; -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 06 10:36:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 10:36:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472421.732626 (Exim 4.92) (envelope-from ) id 1pDk5N-0004l0-UJ; Fri, 06 Jan 2023 10:36:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472421.732626; Fri, 06 Jan 2023 10:36:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDk5N-0004kt-Rf; Fri, 06 Jan 2023 10:36:29 +0000 Received: by outflank-mailman (input) for mailman id 472421; Fri, 06 Jan 2023 10:36:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDk5N-0004kn-53 for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 10:36:29 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDk5E-0003mV-2t; Fri, 06 Jan 2023 10:36:20 +0000 Received: from 54-240-197-227.amazon.com ([54.240.197.227] helo=debian.cbg12.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pDk5D-0001wX-Ni; Fri, 06 Jan 2023 10:36:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" From: Paul Durrant To: x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Paul Durrant , Borislav Petkov , Boris Ostrovsky , Dave Hansen , David Woodhouse , "H. Peter Anvin" , Ingo Molnar , Juergen Gross , Paolo Bonzini , Sean Christopherson , Thomas Gleixner Subject: [PATCH v7 0/2] KVM: x86/xen: update Xen CPUID Leaf 4 Date: Fri, 6 Jan 2023 10:35:58 +0000 Message-Id: <20230106103600.528-1-pdurrant@amazon.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Patch #2 was the original patch. It has been expended to a series in v6. Paul Durrant (2): KVM: x86/cpuid: generalize kvm_update_kvm_cpuid_base() and also capture limit KVM: x86/xen: update Xen CPUID Leaf 4 (tsc info) sub-leaves, if present arch/x86/include/asm/kvm_host.h | 8 +++++++- arch/x86/include/asm/xen/hypervisor.h | 4 +++- arch/x86/kvm/cpuid.c | 26 +++++++++++++++----------- arch/x86/kvm/x86.c | 1 + arch/x86/kvm/xen.c | 26 ++++++++++++++++++++++++++ arch/x86/kvm/xen.h | 7 +++++++ 6 files changed, 59 insertions(+), 13 deletions(-) --- Cc: Borislav Petkov Cc: Boris Ostrovsky Cc: Dave Hansen Cc: David Woodhouse Cc: "H. Peter Anvin" Cc: Ingo Molnar Cc: Juergen Gross Cc: Paolo Bonzini Cc: Sean Christopherson Cc: Thomas Gleixner -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 06 10:36:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 10:36:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472425.732649 (Exim 4.92) (envelope-from ) id 1pDk5e-0005Z8-GT; Fri, 06 Jan 2023 10:36:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472425.732649; Fri, 06 Jan 2023 10:36:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDk5e-0005Yz-C8; Fri, 06 Jan 2023 10:36:46 +0000 Received: by outflank-mailman (input) for mailman id 472425; Fri, 06 Jan 2023 10:36:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDk5d-0005Uh-4T for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 10:36:45 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDk5O-0003oH-OG; Fri, 06 Jan 2023 10:36:30 +0000 Received: from 54-240-197-227.amazon.com ([54.240.197.227] helo=debian.cbg12.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pDk5O-0001wX-EX; Fri, 06 Jan 2023 10:36:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" From: Paul Durrant To: x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Paul Durrant , Sean Christopherson , Paolo Bonzini , Juergen Gross , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , David Woodhouse Subject: [PATCH v7 2/2] KVM: x86/xen: update Xen CPUID Leaf 4 (tsc info) sub-leaves, if present Date: Fri, 6 Jan 2023 10:36:00 +0000 Message-Id: <20230106103600.528-3-pdurrant@amazon.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20230106103600.528-1-pdurrant@amazon.com> References: <20230106103600.528-1-pdurrant@amazon.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The scaling information in subleaf 1 should match the values set by KVM in the 'vcpu_info' sub-structure 'time_info' (a.k.a. pvclock_vcpu_time_info) which is shared with the guest, but is not directly available to the VMM. The offset values are not set since a TSC offset is already applied. The TSC frequency should also be set in sub-leaf 2. Signed-off-by: Paul Durrant --- Cc: Sean Christopherson Cc: Paolo Bonzini Cc: Juergen Gross Cc: Boris Ostrovsky Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: Dave Hansen Cc: "H. Peter Anvin" Cc: David Woodhouse v7: - Add a definition of XEN_SIGNATURE into asm/xen/hypervisor.h and use that v6: - Stash Xen cpuid base and limit values when cpuid is set - Re-name kvm_xen_setup_tsc_info() to kvm_xen_update_tsc_info() v5: - Drop the caching of the CPUID entry pointers and only update the sub-leaves if the CPU frequency has actually changed v4: - Update commit comment v3: - Add leaf limit check in kvm_xen_set_cpuid() v2: - Make sure sub-leaf pointers are NULLed if the time leaf is removed --- arch/x86/include/asm/kvm_host.h | 1 + arch/x86/include/asm/xen/hypervisor.h | 4 +++- arch/x86/kvm/cpuid.c | 2 ++ arch/x86/kvm/x86.c | 1 + arch/x86/kvm/xen.c | 26 ++++++++++++++++++++++++++ arch/x86/kvm/xen.h | 7 +++++++ 6 files changed, 40 insertions(+), 1 deletion(-) diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h index 85cbe4571ac9..f3e9f6e4b3ea 100644 --- a/arch/x86/include/asm/kvm_host.h +++ b/arch/x86/include/asm/kvm_host.h @@ -703,6 +703,7 @@ struct kvm_vcpu_xen { struct hrtimer timer; int poll_evtchn; struct timer_list poll_timer; + struct kvm_hypervisor_cpuid cpuid; }; struct kvm_queued_exception { diff --git a/arch/x86/include/asm/xen/hypervisor.h b/arch/x86/include/asm/xen/hypervisor.h index 16f548a661cf..5fc35f889cd1 100644 --- a/arch/x86/include/asm/xen/hypervisor.h +++ b/arch/x86/include/asm/xen/hypervisor.h @@ -38,9 +38,11 @@ extern struct start_info *xen_start_info; #include +#define XEN_SIGNATURE "XenVMMXenVMM" + static inline uint32_t xen_cpuid_base(void) { - return hypervisor_cpuid_base("XenVMMXenVMM", 2); + return hypervisor_cpuid_base(XEN_SIGNATURE, 2); } struct pci_dev; diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c index db5a4d38fcd0..560f880cc9fd 100644 --- a/arch/x86/kvm/cpuid.c +++ b/arch/x86/kvm/cpuid.c @@ -25,6 +25,7 @@ #include "mmu.h" #include "trace.h" #include "pmu.h" +#include "xen.h" /* * Unlike "struct cpuinfo_x86.x86_capability", kvm_cpu_caps doesn't need to be @@ -442,6 +443,7 @@ static int kvm_set_cpuid(struct kvm_vcpu *vcpu, struct kvm_cpuid_entry2 *e2, vcpu->arch.cpuid_nent = nent; vcpu->arch.kvm_cpuid = kvm_get_hypervisor_cpuid(vcpu, KVM_SIGNATURE); + vcpu->arch.xen.cpuid = kvm_get_hypervisor_cpuid(vcpu, XEN_SIGNATURE); kvm_vcpu_after_set_cpuid(vcpu); return 0; diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index f6ef44dc8a0e..e849a5445cac 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -3158,6 +3158,7 @@ static int kvm_guest_time_update(struct kvm_vcpu *v) &vcpu->hv_clock.tsc_shift, &vcpu->hv_clock.tsc_to_system_mul); vcpu->hw_tsc_khz = tgt_tsc_khz; + kvm_xen_update_tsc_info(v); } vcpu->hv_clock.tsc_timestamp = tsc_timestamp; diff --git a/arch/x86/kvm/xen.c b/arch/x86/kvm/xen.c index 2e29bdc2949c..fbfc7c17defd 100644 --- a/arch/x86/kvm/xen.c +++ b/arch/x86/kvm/xen.c @@ -22,6 +22,9 @@ #include #include +#include + +#include "cpuid.h" #include "trace.h" static int kvm_xen_set_evtchn(struct kvm_xen_evtchn *xe, struct kvm *kvm); @@ -2067,6 +2070,29 @@ void kvm_xen_destroy_vcpu(struct kvm_vcpu *vcpu) del_timer_sync(&vcpu->arch.xen.poll_timer); } +void kvm_xen_update_tsc_info(struct kvm_vcpu *vcpu) +{ + struct kvm_cpuid_entry2 *entry; + u32 function; + + if (!vcpu->arch.xen.cpuid.base) + return; + + function = vcpu->arch.xen.cpuid.base | XEN_CPUID_LEAF(3); + if (function > vcpu->arch.xen.cpuid.limit) + return; + + entry = kvm_find_cpuid_entry_index(vcpu, function, 1); + if (entry) { + entry->ecx = vcpu->arch.hv_clock.tsc_to_system_mul; + entry->edx = vcpu->arch.hv_clock.tsc_shift; + } + + entry = kvm_find_cpuid_entry_index(vcpu, function, 2); + if (entry) + entry->eax = vcpu->arch.hw_tsc_khz; +} + void kvm_xen_init_vm(struct kvm *kvm) { idr_init(&kvm->arch.xen.evtchn_ports); diff --git a/arch/x86/kvm/xen.h b/arch/x86/kvm/xen.h index ea33d80a0c51..f8f1fe22d090 100644 --- a/arch/x86/kvm/xen.h +++ b/arch/x86/kvm/xen.h @@ -9,6 +9,8 @@ #ifndef __ARCH_X86_KVM_XEN_H__ #define __ARCH_X86_KVM_XEN_H__ +#include + #ifdef CONFIG_KVM_XEN #include @@ -32,6 +34,7 @@ int kvm_xen_set_evtchn_fast(struct kvm_xen_evtchn *xe, int kvm_xen_setup_evtchn(struct kvm *kvm, struct kvm_kernel_irq_routing_entry *e, const struct kvm_irq_routing_entry *ue); +void kvm_xen_update_tsc_info(struct kvm_vcpu *vcpu); static inline bool kvm_xen_msr_enabled(struct kvm *kvm) { @@ -135,6 +138,10 @@ static inline bool kvm_xen_timer_enabled(struct kvm_vcpu *vcpu) { return false; } + +static inline void kvm_xen_update_tsc_info(struct kvm_vcpu *vcpu) +{ +} #endif int kvm_xen_hypercall(struct kvm_vcpu *vcpu); -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 06 10:41:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 10:41:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472445.732660 (Exim 4.92) (envelope-from ) id 1pDkA7-0007Mi-6G; Fri, 06 Jan 2023 10:41:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472445.732660; Fri, 06 Jan 2023 10:41:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDkA7-0007Ma-3L; Fri, 06 Jan 2023 10:41:23 +0000 Received: by outflank-mailman (input) for mailman id 472445; Fri, 06 Jan 2023 10:41:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDkA6-0007M7-4u for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 10:41:22 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id a7effac7-8dae-11ed-91b6-6bf2151ebd3b; Fri, 06 Jan 2023 11:41:20 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 638D911FB; Fri, 6 Jan 2023 02:42:01 -0800 (PST) Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com [10.1.195.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 76EEA3F23F; Fri, 6 Jan 2023 02:41:18 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a7effac7-8dae-11ed-91b6-6bf2151ebd3b From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH 0/2] Cppcheck MISRA analysis improvements Date: Fri, 6 Jan 2023 10:41:06 +0000 Message-Id: <20230106104108.14740-1-luca.fancellu@arm.com> X-Mailer: git-send-email 2.17.1 This serie is adding a way to skip the check for some rules that the Xen project has agreed to follow, this is because cppcheck reports too many false-positive on some rules and it would be easier in a first phase to skip the check on them and allow the tool to be mature enough before using it on the specific rules. The serie includes also an improvement for the cppcheck report. Luca Fancellu (2): xen/cppcheck: sort alphabetically cppcheck report entries xen/cppcheck: add parameter to skip given MISRA rules xen/scripts/xen_analysis/cppcheck_analysis.py | 8 +++-- .../xen_analysis/cppcheck_report_utils.py | 2 ++ xen/scripts/xen_analysis/settings.py | 35 +++++++++++-------- xen/tools/convert_misra_doc.py | 28 ++++++++++----- 4 files changed, 48 insertions(+), 25 deletions(-) -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 06 10:41:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 10:41:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472446.732671 (Exim 4.92) (envelope-from ) id 1pDkA8-0007bo-Da; Fri, 06 Jan 2023 10:41:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472446.732671; Fri, 06 Jan 2023 10:41:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDkA8-0007bf-A5; Fri, 06 Jan 2023 10:41:24 +0000 Received: by outflank-mailman (input) for mailman id 472446; Fri, 06 Jan 2023 10:41:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDkA6-0007M7-UG for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 10:41:22 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id a8b5b86e-8dae-11ed-91b6-6bf2151ebd3b; Fri, 06 Jan 2023 11:41:21 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AFFB112FC; Fri, 6 Jan 2023 02:42:02 -0800 (PST) Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com [10.1.195.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C54FB3F23F; Fri, 6 Jan 2023 02:41:19 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a8b5b86e-8dae-11ed-91b6-6bf2151ebd3b From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH 1/2] xen/cppcheck: sort alphabetically cppcheck report entries Date: Fri, 6 Jan 2023 10:41:07 +0000 Message-Id: <20230106104108.14740-2-luca.fancellu@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230106104108.14740-1-luca.fancellu@arm.com> References: <20230106104108.14740-1-luca.fancellu@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sort alphabetically cppcheck report entries when producing the text report, this will help comparing different reports and will group together findings from the same file. Signed-off-by: Luca Fancellu --- xen/scripts/xen_analysis/cppcheck_report_utils.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/scripts/xen_analysis/cppcheck_report_utils.py b/xen/scripts/xen_analysis/cppcheck_report_utils.py index 02440aefdfec..f02166ed9d19 100644 --- a/xen/scripts/xen_analysis/cppcheck_report_utils.py +++ b/xen/scripts/xen_analysis/cppcheck_report_utils.py @@ -104,6 +104,8 @@ def cppcheck_merge_txt_fragments(fragments_list, out_txt_file, strip_paths): for path in strip_paths: text_report_content[i] = text_report_content[i].replace( path + "/", "") + # sort alphabetically the entries + text_report_content.sort() # Write the final text report outfile.writelines(text_report_content) except OSError as e: -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 06 10:41:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 10:41:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472447.732682 (Exim 4.92) (envelope-from ) id 1pDkAA-0007sj-Lr; Fri, 06 Jan 2023 10:41:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472447.732682; Fri, 06 Jan 2023 10:41:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDkAA-0007sc-IM; Fri, 06 Jan 2023 10:41:26 +0000 Received: by outflank-mailman (input) for mailman id 472447; Fri, 06 Jan 2023 10:41:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDkA9-0007m5-9K for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 10:41:25 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id a9884c2e-8dae-11ed-b8d0-410ff93cb8f0; Fri, 06 Jan 2023 11:41:22 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0964B15A1; Fri, 6 Jan 2023 02:42:04 -0800 (PST) Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com [10.1.195.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1EC053F23F; Fri, 6 Jan 2023 02:41:21 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a9884c2e-8dae-11ed-b8d0-410ff93cb8f0 From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH 2/2] xen/cppcheck: add parameter to skip given MISRA rules Date: Fri, 6 Jan 2023 10:41:08 +0000 Message-Id: <20230106104108.14740-3-luca.fancellu@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230106104108.14740-1-luca.fancellu@arm.com> References: <20230106104108.14740-1-luca.fancellu@arm.com> Add parameter to skip the passed MISRA rules during the cppcheck analysis, the rules are specified as a list of comma separated rules with the MISRA number notation (e.g. 1.1,1.3,...). Modify convert_misra_doc.py script to take an extra parameter giving a list of MISRA rule to be skipped, comma separated. While there, fix some typos in the help and print functions. Modify settings.py and cppcheck_analysis.py to have a new parameter (--cppcheck-skip-rules) used to specify a list of MISRA rule to be skipped during the cppcheck analysis. Signed-off-by: Luca Fancellu --- xen/scripts/xen_analysis/cppcheck_analysis.py | 8 +++-- xen/scripts/xen_analysis/settings.py | 35 +++++++++++-------- xen/tools/convert_misra_doc.py | 28 ++++++++++----- 3 files changed, 46 insertions(+), 25 deletions(-) diff --git a/xen/scripts/xen_analysis/cppcheck_analysis.py b/xen/scripts/xen_analysis/cppcheck_analysis.py index 0e952a169641..cc1f403d315e 100644 --- a/xen/scripts/xen_analysis/cppcheck_analysis.py +++ b/xen/scripts/xen_analysis/cppcheck_analysis.py @@ -153,11 +153,15 @@ def generate_cppcheck_deps(): if settings.cppcheck_misra: cppcheck_flags = cppcheck_flags + " --addon=cppcheck-misra.json" + skip_rules_arg = "" + if settings.cppcheck_skip_rules != "": + skip_rules_arg = "-s {}".format(settings.cppcheck_skip_rules) + utils.invoke_command( "{}/convert_misra_doc.py -i {}/docs/misra/rules.rst" - " -o {}/cppcheck-misra.txt -j {}/cppcheck-misra.json" + " -o {}/cppcheck-misra.txt -j {}/cppcheck-misra.json {}" .format(settings.tools_dir, settings.repo_dir, - settings.outdir, settings.outdir), + settings.outdir, settings.outdir, skip_rules_arg), False, CppcheckDepsPhaseError, "An error occured when running:\n{}" ) diff --git a/xen/scripts/xen_analysis/settings.py b/xen/scripts/xen_analysis/settings.py index a8502e554e95..8c0d357fe0dc 100644 --- a/xen/scripts/xen_analysis/settings.py +++ b/xen/scripts/xen_analysis/settings.py @@ -24,6 +24,7 @@ cppcheck_binpath = "cppcheck" cppcheck_html = False cppcheck_htmlreport_binpath = "cppcheck-htmlreport" cppcheck_misra = False +cppcheck_skip_rules = "" make_forward_args = "" outdir = xen_dir @@ -53,20 +54,22 @@ Cppcheck report creation phase runs only when --run-cppcheck is passed to the script. Options: - --build-only Run only the commands to build Xen with the optional - make arguments passed to the script - --clean-only Run only the commands to clean the analysis artifacts - --cppcheck-bin= Path to the cppcheck binary (Default: {}) - --cppcheck-html Produce an additional HTML output report for Cppcheck - --cppcheck-html-bin= Path to the cppcheck-html binary (Default: {}) - --cppcheck-misra Activate the Cppcheck MISRA analysis - --distclean Clean analysis artifacts and reports - -h, --help Print this help - --no-build Skip the build Xen phase - --no-clean Don\'t clean the analysis artifacts on exit - --run-coverity Run the analysis for the Coverity tool - --run-cppcheck Run the Cppcheck analysis tool on Xen - --run-eclair Run the analysis for the Eclair tool + --build-only Run only the commands to build Xen with the optional + make arguments passed to the script + --clean-only Run only the commands to clean the analysis artifacts + --cppcheck-bin= Path to the cppcheck binary (Default: {}) + --cppcheck-html Produce an additional HTML output report for Cppcheck + --cppcheck-html-bin= Path to the cppcheck-html binary (Default: {}) + --cppcheck-misra Activate the Cppcheck MISRA analysis + --cppcheck-skip-rules= List of MISRA rules to be skipped, comma separated. + (e.g. --cppcheck-skip-rules=1.1,20.7,8.4) + --distclean Clean analysis artifacts and reports + -h, --help Print this help + --no-build Skip the build Xen phase + --no-clean Don\'t clean the analysis artifacts on exit + --run-coverity Run the analysis for the Coverity tool + --run-cppcheck Run the Cppcheck analysis tool on Xen + --run-eclair Run the analysis for the Eclair tool """ print(msg.format(sys.argv[0], cppcheck_binpath, cppcheck_htmlreport_binpath)) @@ -78,6 +81,7 @@ def parse_commandline(argv): global cppcheck_html global cppcheck_htmlreport_binpath global cppcheck_misra + global cppcheck_skip_rules global make_forward_args global outdir global step_get_make_vars @@ -115,6 +119,9 @@ def parse_commandline(argv): cppcheck_htmlreport_binpath = args_with_content_regex.group(2) elif option == "--cppcheck-misra": cppcheck_misra = True + elif args_with_content_regex and \ + args_with_content_regex.group(1) == "--cppcheck-skip-rules": + cppcheck_skip_rules = args_with_content_regex.group(2) elif option == "--distclean": target_distclean = True elif (option == "--help") or (option == "-h"): diff --git a/xen/tools/convert_misra_doc.py b/xen/tools/convert_misra_doc.py index 13074d8a2e91..8984ec625fa7 100755 --- a/xen/tools/convert_misra_doc.py +++ b/xen/tools/convert_misra_doc.py @@ -4,12 +4,14 @@ This script is converting the misra documentation RST file into a text file that can be used as text-rules for cppcheck. Usage: - convert_misr_doc.py -i INPUT [-o OUTPUT] [-j JSON] + convert_misra_doc.py -i INPUT [-o OUTPUT] [-j JSON] [-s RULES,[...,RULES]] INPUT - RST file containing the list of misra rules. OUTPUT - file to store the text output to be used by cppcheck. If not specified, the result will be printed to stdout. JSON - cppcheck json file to be created (optional). + RULES - list of rules to skip during the analysis, comma separated + (e.g. 1.1,1.2,1.3,...) """ import sys, getopt, re @@ -47,21 +49,25 @@ def main(argv): outfile = '' outstr = sys.stdout jsonfile = '' + force_skip = '' try: - opts, args = getopt.getopt(argv,"hi:o:j:",["input=","output=","json="]) + opts, args = getopt.getopt(argv,"hi:o:j:s:", + ["input=","output=","json=","skip="]) except getopt.GetoptError: - print('convert-misra.py -i [-o ] [-j ') + print('convert-misra.py -i [-o ] [-j ] [-s ]') sys.exit(2) for opt, arg in opts: if opt == '-h': - print('convert-misra.py -i [-o ] [-j ') + print('convert-misra.py -i [-o ] [-j ] [-s ]') print(' If output is not specified, print to stdout') sys.exit(1) elif opt in ("-i", "--input"): infile = arg elif opt in ("-o", "--output"): outfile = arg + elif opt in ("-s", "--skip"): + force_skip = arg elif opt in ("-j", "--json"): jsonfile = arg @@ -169,14 +175,18 @@ def main(argv): skip_list = [] + # Add rules to be skipped anyway + for r in force_skip.split(','): + skip_list.append(r) + # Search for missing rules and add a dummy text with the rule number for i in misra_c2012_rules: for j in list(range(1,misra_c2012_rules[i]+1)): - if str(i) + '.' + str(j) not in rule_list: - outstr.write('Rule ' + str(i) + '.' + str(j) + '\n') - outstr.write('No description for rule ' + str(i) + '.' + str(j) - + '\n') - skip_list.append(str(i) + '.' + str(j)) + rule_str = str(i) + '.' + str(j) + if (rule_str not in rule_list) and (rule_str not in skip_list): + outstr.write('Rule ' + rule_str + '\n') + outstr.write('No description for rule ' + rule_str + '\n') + skip_list.append(rule_str) # Make cppcheck happy by starting the appendix outstr.write('Appendix B\n') -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 06 10:42:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 10:42:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472464.732693 (Exim 4.92) (envelope-from ) id 1pDkBN-0000Xo-WA; Fri, 06 Jan 2023 10:42:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472464.732693; Fri, 06 Jan 2023 10:42:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDkBN-0000Xh-TA; Fri, 06 Jan 2023 10:42:41 +0000 Received: by outflank-mailman (input) for mailman id 472464; Fri, 06 Jan 2023 10:42:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDkBM-0000XJ-FA for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 10:42:40 +0000 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2040.outbound.protection.outlook.com [40.107.101.40]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b7d06d31-8dae-11ed-91b6-6bf2151ebd3b; Fri, 06 Jan 2023 11:41:48 +0100 (CET) Received: from DM6PR21CA0003.namprd21.prod.outlook.com (2603:10b6:5:174::13) by PH7PR12MB5879.namprd12.prod.outlook.com (2603:10b6:510:1d7::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Fri, 6 Jan 2023 10:41:43 +0000 Received: from DM6NAM11FT055.eop-nam11.prod.protection.outlook.com (2603:10b6:5:174:cafe::f1) by DM6PR21CA0003.outlook.office365.com (2603:10b6:5:174::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.6 via Frontend Transport; Fri, 6 Jan 2023 10:41:43 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT055.mail.protection.outlook.com (10.13.173.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5966.17 via Frontend Transport; Fri, 6 Jan 2023 10:41:42 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 6 Jan 2023 04:41:42 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 6 Jan 2023 04:41:42 -0600 Received: from [10.71.193.39] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Fri, 6 Jan 2023 04:41:41 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b7d06d31-8dae-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IiYab2Jg0ZKuKIhxBACtNp6p8PwuoRkBPzMs39OmGEJUIdmkHkgWdxLRnxfTJGMzBfWjEzH9PqGH1lTkKZ8df3rQSELr5Nr/WUNctnSP34t34849Rclu1PnDy5nnqsnvjRSbGwbq+VlodgEVsJjOWHuOU9V7Fa33qZ8DNJKI0qN43lZ7oaka+q+nB53H1rVWnYwo1GgYlhZh3qkTJrCMAQCR9YVLt+Y1Kxh8zA6m+gljoWWH6BbtatKzfzAbi07XCVWE+2eJvhfhvIGvHk9fWGA1Acp/pFszu0zqVlbwd8NWbbnQJ2XzaKxDlOulJ5wJDVZnoYlD3RlkHem+oCaCgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4wHK6HK99xoJCu9Ih3KlJHciWVIQHNeLO/b5S8q4/KI=; b=AcGRnSMe4L9Azub3tL8sbY61HtQ+wzx7S85knTYuBqC/C+NZMEFF7L9cib2LsRv2/c9ayt8tPuwfavTkAU9HgZeTJ9XubknK6X6m4RpTtUD06lgOqpzRtQL0TRo63qxe121qGGHq9PFIuIHikTz39ZVQAZC79+8iBieEpMaX7e9CjVhKNm/zqW2c6nV3gSM7mcAcUdoQlKtkLxcuHzoEGPTUr+aVdBma6obTXDn+ybQtbEWWZ91TuTLGl5blweM7BI7lseqaiohmJKgY3QAmW0PPnPphhsb5AhUrHZ+FE7U/h3byq5/PajOoD/hhplV/NcMdpZYCUlpFvU67z/et0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=citrix.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4wHK6HK99xoJCu9Ih3KlJHciWVIQHNeLO/b5S8q4/KI=; b=wENSy1xT8swSrvQMsJ354Si5OIDmGRlTvcqdTTUplA7ZfC5AI2/DREFiFruMGIqHprrRvkgeW1zJyW7h+Y2Dzh40f3w/cRkULgOjRYIHTA0e77fhgCRtM5jMEpUjsB1DDW3sulwsrAkNJRwD1gw39nmeI6J0VgkXwDQOSiCSNjg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <383485e0-37ac-9b0c-f0c5-18e50cf7905b@amd.com> Date: Fri, 6 Jan 2023 11:41:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2] xen/arm: Add 0x prefix when printing memory size in construct_domU Content-Language: en-US To: Andrew Cooper , Julien Grall , Ayan Kumar Halder , "xen-devel@lists.xenproject.org" References: <20230103102519.26224-1-michal.orzel@amd.com> <1264e5cc-1960-95d3-5ecb-d6f23d194aa4@xen.org> <29460d07-cd43-7415-7125-6ed01f3c2920@amd.com> <35d590fb-4b96-70dd-a60b-1c8d7cc8f2d6@citrix.com> From: Michal Orzel In-Reply-To: <35d590fb-4b96-70dd-a60b-1c8d7cc8f2d6@citrix.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT055:EE_|PH7PR12MB5879:EE_ X-MS-Office365-Filtering-Correlation-Id: 2326ee58-65f2-4a1d-90cc-08daefd299dc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LQ7bU/l0aR8396jR9E4VLOGtrrjq18ZKAKvrzojzguor9zwgX5DLPjk53dlt2rr5ghmvFjfzbIVpQUMJYK04zFqP5meexxXrSlA1T0ipnB/r4nqhi7bn09oMfId9jiEKyjnW0Rn1WMz9450NZJCcNpk27JzUSo1APvaKLIQdo61R5vzE5LXRqr6NxasRBihWPNB264M4YeLfhaEaG2gaWzUzq3Ni4f2f6/fTkaX6+mnzIY15Uyz3JvC+3FrHu6jX8NH9Fkw5S7FTJIDW9UE7uv10yrSTM6pl4SOVAa6Z+qv2OwV1xYMd4MCiFmdVZ1LAGVj+TlJ3N9KEkPAUsB4FcdtWgQk495dYkMq8RKBJq77B1aCfnZPJkMdGMSLDDgX8pEx0Ag6YV8pmFuTFliMFxdWCkYoKvkLA952kQONue5hhAXJix8crjnc0xRVudAlbIEMIPAPplbR/H7mgKnfCqkFdvYvioYw42C3Lsvg5U3aTt78HJafiexDFinujZo+5zXyr/CHFGeNMcUosWlMPnCofxFilIBtpT1XC6e2KWq8aA7aNBmrd220oqqytdoEcX4e4dteAecnsGe+k2GfyboxXLQ0CgNl+Dt/unABRCxSfMl0L0MPpQht0wtL2RSpTp97SB7V0i0mDntzhI9PIFI9aj2MKPjPh2jVIkzd9k//O8TGU1YUGnjzzLh6F2eejJDBGtJXkBeFiERVQfpNN8vQNTyxLBw5UX2jstchUfJ4JwD4uMGq11ObJsfmTn1D2U28roCx+WAKeXHg6oKsxzQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(136003)(346002)(39860400002)(451199015)(36840700001)(40470700004)(46966006)(31686004)(36756003)(82740400003)(81166007)(70206006)(70586007)(8676002)(356005)(2906002)(44832011)(5660300002)(336012)(31696002)(86362001)(83380400001)(36860700001)(316002)(16576012)(478600001)(110136005)(41300700001)(82310400005)(8936002)(40460700003)(426003)(2616005)(53546011)(186003)(47076005)(26005)(40480700001)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2023 10:41:42.9104 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2326ee58-65f2-4a1d-90cc-08daefd299dc X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT055.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5879 On 05/01/2023 13:15, Andrew Cooper wrote: > > > On 05/01/2023 11:19 am, Julien Grall wrote: >> On 05/01/2023 09:59, Ayan Kumar Halder wrote: >>> Hi Julien, >> >> Hi, >> >>> I have a clarification. >>> >>> On 05/01/2023 09:26, Julien Grall wrote: >>>> CAUTION: This message has originated from an External Source. Please >>>> use proper judgment and caution when opening attachments, clicking >>>> links, or responding to this email. >>>> >>>> >>>> Hi Stefano, >>>> >>>> On 04/01/2023 23:47, Stefano Stabellini wrote: >>>>> On Tue, 3 Jan 2023, Michal Orzel wrote: >>>>>> Printing memory size in hex without 0x prefix can be misleading, so >>>>>> add it. Also, take the opportunity to adhere to 80 chars line length >>>>>> limit by moving the printk arguments to the next line. >>>>>> >>>>>> Signed-off-by: Michal Orzel >>>>>> --- >>>>>> Changes in v2: >>>>>> - was: "Print memory size in decimal in construct_domU" >>>>>> - stick to hex but add a 0x prefix >>>>>> - adhere to 80 chars line length limit >>>>> >>>>> Honestly I prefer decimal but also hex is fine. >>>> >>>> decimal is perfect for very small values, but as we print the amount in >>>> KB it will become a big mess. Here some examples (decimal first, then >>>> hexadecimal): >>>> >>>> 512MB: 524288 vs 0x80000 >>>> 555MB: 568320 vs 0x8ac00 >>>> 1GB: 1048576 vs 0x100000 >>>> 512GB: 536870912 vs 0x20000000 >>>> 1TB: 1073741824 vs 0x40000000 >>>> >>>> For power of two values, you might be able to find your way with >>>> decimal. It is more difficult for non power of two unless you have a >>>> calculator in hand. >>>> >>>> The other option I suggested in v1 is to print the amount in KB/GB/MB. >>>> Would that be better? >>>> >>>> That said, to be honest, I am not entirely sure why we are actually >>>> printing in KB. It would seems strange that someone would create a >>>> guest >>>> with memory not aligned to 1MB. >>> >>> For RTOS (Zephyr and FreeRTOS), it should be possible for guests to >>> have memory less than 1 MB, isn't it ? >> >> Yes. So does XTF. But most of the users are likely going allocate at >> least 1MB (or even 2MB to reduce the TLB pressure). >> >> So it would be better to print the value in a way that is more >> meaningful for the majority of the users. >> >>>> So I would consider to check the size is 1MB-aligned and then print the >> >> I will retract my suggestion to check the size. There are technically >> no restriction to run a guest with a size not aligned to 1MB. >> Although, it would still seem strange. > > I have a need to extend tools/tests/tsx with a VM that is a single 4k > page. Something which can execute CPUID in the context of a VM and > cross-check the results with what the "toolstack" (test) tried to configure. > > Xen is buggy if it cannot operate a VM which looks like that, and a > bonus of explicitly testing like this is that it helps to remove > inappropriate checks. I can see we are all settled that it is fully ok to boot guests with memory size less than 1MB. The 'memory' dt parameter for dom0less domUs requires being specified in KB and this is the smallest common multiple so it makes the process of cross-checking easier. Stefano is ok with either decimal or hex, Julien wanted hex (hence my v2), I'm more towards printing in hex as well. Let's not forget that this patch aims to fix a misleading print that was missing 0x and can cause someone to take it as a decimal value. > > ~Andrew ~Michal From xen-devel-bounces@lists.xenproject.org Fri Jan 06 10:53:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 10:53:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472477.732704 (Exim 4.92) (envelope-from ) id 1pDkLa-00029W-VL; Fri, 06 Jan 2023 10:53:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472477.732704; Fri, 06 Jan 2023 10:53:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDkLa-00029P-ST; Fri, 06 Jan 2023 10:53:14 +0000 Received: by outflank-mailman (input) for mailman id 472477; Fri, 06 Jan 2023 10:53:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDkLZ-00029J-3u for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 10:53:13 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4cfb5768-8db0-11ed-b8d0-410ff93cb8f0; Fri, 06 Jan 2023 11:53:09 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4cfb5768-8db0-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1673002389; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=6Wk2TSCEO9A+5OEvRCIDTA7EztFEDFJs4i2Z9OGalEk=; b=FJThnpB0G0nAi5Uj4/vTmBx89lsFwzWXoSGCQ5wri/bsJ1jpRfWWV54T xJ2jQLqNlzJLtxKZFJAvpiggtADuoFxCGsNqY/vuR/kp8OKrEHylleegg s8BxWyRe1y0KC6GUnbF6OVGSeM74U3EtC5eNR0BHPq5BjOrvUeYtwq0bm w=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 90405203 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:ullLqqDkDLmaBBVW/33kw5YqxClBgxIJ4kV8jS/XYbTApDp2hmECy 2sbDzqBOfaLYWr0cowgPo7j9E4Bu5/Tz9VqQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nNHuCnYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtcpvlDs15K6p4GpA4ARkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIwxtxWG1NRq fgjMwsObSuM2Mu7+52RY7w57igjBJGD0II3v3hhyXfSDOo8QICFSKLPjTNa9G5u3IYUR6+YP pdHL2o0BPjDS0Qn1lM/AZQinOCulz/nfidRsl69rqsr+WnDigd21dABNfKEIoDSGJ8NxS50o Erhw0DwIjgHF+bYzBub6U61rMOVuR/CDdd6+LqQqacx3Qz7KnYoIBAaSFKhrf6Rike0WNVEN woS9zZGhbIz/0yiVNW7XxC+rHOepRkac95RFeQg70eK0KW8ywOQHGMJSnhIcNIrsMU/WDkC2 VqAntevDjtq2JWMRHeAs7uZsz62ES4SK2AEeGkDVwRty8nupsQ/gwzCSv5nEbWplZvlFDfo2 TeIoSMiwbIJgqYjz6+8+0LGhTOEvJXFTgcpoA7QWwqN5wd0dMi6Zois6FHe9vFGBJyUQlmIo D4PnM32xOoUBpGQny+faOwKGPei4PPtGCXVnFpHD5QnsTO39BaLZptM6TtzIENoNMcsejLzZ kLX/wRL6/d7OWC2RbV6b4K4F4Ihyq2IKDj+fqmKNJwUOME3LVLZunE1DaKN44zzuHQWsLsNJ sufSt2XDnUhBvtOwQGZbc5IhNfH2RsC7W/UQJn6yTGu3ryfeGOZRN85DbeeUgwqxPja+VuIq r6zI+PPkkwCC7OmPkE75KZJdTg3wW4H6YcaQiC9XsqKOUJYFW4oEJc9KptxKtU+z8y5egoll 0xRu3O0KnKl3hUryi3QMBiPjY8Dur4hxU/XxQR2YT6VN4ELOO5DFps3eZotZqUA/+d+1/NyR PRtU5zeXa4eFm+aq2VBPMiVQGlemPKD31Lm082NOWFXQnKdb1aRpo+MkvXHrkHi8RZbReNh+ ub9h2s3sLIIRhh4Dda+Vc9DO2iZ5CBH8MorBhugHzWmUBm0mGScA3Cr36BfzgBlAUmr+wZ2I C7NXEZE9bGS+tZlmDQL7Ijdx7qU/yJFNhIyNwHmAXyebEE2IkLLLVd8bdu1 IronPort-HdrOrdr: A9a23:12j/1qAICkWol0nlHemW55DYdb4zR+YMi2TDsHocdfU1SKOlfq WV98jzuiWbtN98YhAdcLK7Scq9qALnlaKdiLN5Vd3OYOCBghrMEGgI1/qB/9SPIVyYysdtkY tmbqhiGJnRIDFB/KDHCdCDYrId/OU= X-IronPort-AV: E=Sophos;i="5.96,305,1665460800"; d="scan'208";a="90405203" Date: Fri, 6 Jan 2023 10:52:54 +0000 From: Anthony PERARD To: Chuck Zmudzinski CC: Alex Williamson , Paul Durrant , "Michael S. Tsirkin" , Stefano Stabellini , Paolo Bonzini , "Richard Henderson" , Eduardo Habkost , Marcel Apfelbaum , , Subject: Re: [PATCH v6] xen/pt: reserve PCI slot 2 for Intel igd-passthru Message-ID: References: <830263507e8f1a24a94f81909d5102c4b204e938.1672615492.git.brchuckz.ref@aol.com> <830263507e8f1a24a94f81909d5102c4b204e938.1672615492.git.brchuckz@aol.com> <20230102124605-mutt-send-email-mst@kernel.org> <20230103081456.1d676b8e.alex.williamson@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: On Tue, Jan 03, 2023 at 05:58:01PM -0500, Chuck Zmudzinski wrote: > Hello Anthony and Paul, Hi Chuck, > I am requesting your feedback to Alex Williamson's suggestion that this > problem with assigning the correct slot address to the igd on xen should > be fixed in libxl instead of in qemu. > > It seems to me that the xen folks and the kvm folks have two different > philosophies regarding how a tool stack should be designed. kvm/libvirt > provides much greater flexibility in configuring the guest which puts > the burden on the administrator to set all the options correctly for > a given feature set, while xen/xenlight does not provide so much > flexibility and tries to automatically configure the guest based on > a high-level feature option such as the igd-passthrough=on option that > is available for xen guests using qemu but not for kvm guests using > qemu. > > What do you think? Should libxl be patched instead of fixing the problem > with this patch to qemu, which is contrary to Alex's suggestion? I do think that libxl should be able to deal with having to put a graphic card on slot 2. QEMU already provides every API necessary for a toolstack to be able to start a Xen guest with all the PCI card in the right slot. But it would just be a bit more complicated to implement in libxl. At the moment, libxl makes use of the QEMU machine 'xenfv', libxl should instead start to use the 'pc' machine and add the "xen-platform" pci device. (libxl already uses 'pc' when the "xen-platform" pci card isn't needed.) Also probably add the other pci devices to specific slot to be able to add the passthrough graphic card at the right slot. Next is to deal with migration when using the 'pc' machine, as it's just an alias to a specific version of the machine. We need to use the same machine on the receiving end, that is start with e.g. "pc-i440fx-7.1" if 'pc' was an alias for it at guest creation. I wonder if we can already avoid to patch the 'xenfv' machine with some xl config: # avoid 'xenfv' machine and use 'pc' instead xen_platform_pci=0 # add xen-platform pci device back device_model_args_hvm = [ "-device", "xen-platform,addr=3", ] But there's probably another device which is going to be auto-assigned to slot 2. If you feel like dealing with the technical dept in libxl, that is to stop using 'xenfv' and use 'pc' instead, then go for it, I can help with that. Otherwise, if the patch to QEMU only changes the behavior of the 'xenfv' machine then I think I would be ok with it. I'll do a review of that QEMU patch in another email. Cheers, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Fri Jan 06 11:58:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 11:58:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472486.732715 (Exim 4.92) (envelope-from ) id 1pDlMO-000077-RO; Fri, 06 Jan 2023 11:58:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472486.732715; Fri, 06 Jan 2023 11:58:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDlMO-000070-Oj; Fri, 06 Jan 2023 11:58:08 +0000 Received: by outflank-mailman (input) for mailman id 472486; Fri, 06 Jan 2023 11:58:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDlMO-00006p-5R for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 11:58:08 +0000 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [2a00:1450:4864:20::633]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 616d8e3d-8db9-11ed-91b6-6bf2151ebd3b; Fri, 06 Jan 2023 12:58:06 +0100 (CET) Received: by mail-ej1-x633.google.com with SMTP id qk9so3000878ejc.3 for ; Fri, 06 Jan 2023 03:58:06 -0800 (PST) Received: from ?IPv6:::1? (p200300faaf0bb20078bb45bd8c0dfe08.dip0.t-ipconnect.de. [2003:fa:af0b:b200:78bb:45bd:8c0d:fe08]) by smtp.gmail.com with ESMTPSA id hq15-20020a1709073f0f00b0084c7029b24dsm330529ejc.151.2023.01.06.03.58.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Jan 2023 03:58:05 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 616d8e3d-8db9-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=TBxYdY0nhsET79NZ9XKnKiBr1yDDIcpHo558HUBkNFQ=; b=onoSQlpLMrOzWEEpbJjcfYgWALF8enzzBWje3CUbC5Cl+zXPJYyq+J0iI2WdL8Dwd7 0p+MQoMZeclUSiUclWaCU/SWK/Bu6PhKzFvqRoPBT6lUS48gpP8kX3xAiGYv0Qbm/5n9 EWK+IYEarusxXx5rRBpsGiRCjVRYtPBDZJhUreyVJSmt1RfCEYyhtioYkV8inanRpbHH wp1ISW5RaTZ/td3RP/qk2D7GLFhm+sGb3LTtscSU5O+Ey0aDUqhaG+UV8NGxTe36jqxK AtrKk/1kMLv7iqmgQmTxMdB+6LZ9PgbSguUxNYey0zUq5ZlHwT1aHqzwEa9T7d+rKgUn Xdjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TBxYdY0nhsET79NZ9XKnKiBr1yDDIcpHo558HUBkNFQ=; b=DKWlhm7sbIkiUM8fDHPCxk6xeLvmhOcvjO1wkI4FWsrPwhSQH9uKz3vqda6uKlj/jT 2qOzSim1eqfcrXh/ylFWli+6tU1X3TJxPdwprOe2U+1J/7mVtQmEknHVPvWmohFtvgL7 v+NYdXUR8Yi5b0xdoTpvku4CvcisJUXge92lBAkggLWRghndL5SZ33F6PkwOZ81xpo87 c/jsSnF9VaNWuBmgBUBXbDKbNb07qGTCnKidb676Gta7ZXVIdKPCxtIpAbUpyBbTelk8 4ZJqG2rtwciaypevK28tSkNeob7M2SdTPuv1uNosRpCu47XQqnWbm5PymdLv5uaBCFg5 gOPA== X-Gm-Message-State: AFqh2koKA2+eJ7Mul5+OzO+rLF2eXhpaX8DawhTG8c/AnnmNdwZc5iT7 5zzYLGVX+lfl3R5owJsC2gOa9m+AXHduvg== X-Google-Smtp-Source: AMrXdXtk3S7Dcv8qIz8C3RhdtMz6UKvTSdukRpBJB5XtgEItGpsj5crne5XSJSHuqB4f9YXLznGuXw== X-Received: by 2002:a17:907:c71b:b0:7c1:67ca:56f5 with SMTP id ty27-20020a170907c71b00b007c167ca56f5mr53336482ejc.15.1673006285861; Fri, 06 Jan 2023 03:58:05 -0800 (PST) Date: Fri, 06 Jan 2023 11:57:59 +0000 From: Bernhard Beschow To: =?ISO-8859-1?Q?Philippe_Mathieu-Daud=E9?= , qemu-devel@nongnu.org, Markus Armbruster CC: Richard Henderson , Stefano Stabellini , xen-devel@lists.xenproject.org, =?ISO-8859-1?Q?Herv=E9_Poussineau?= , Aurelien Jarno , Paul Durrant , Marcel Apfelbaum , Anthony Perard , "Michael S. Tsirkin" , Paolo Bonzini , Eduardo Habkost , Chuck Zmudzinski , Thomas Huth Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_v2_6/6=5D_hw/isa/piix=3A_Res?= =?US-ASCII?Q?olve_redundant_TYPE=5FPIIX3=5FXEN=5FDEVICE?= In-Reply-To: <1c2e0780-e5fb-1321-0d84-b0591db9fec7@linaro.org> References: <20230104144437.27479-1-shentey@gmail.com> <20230104144437.27479-7-shentey@gmail.com> <1c2e0780-e5fb-1321-0d84-b0591db9fec7@linaro.org> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Am 4=2E Januar 2023 15:35:33 UTC schrieb "Philippe Mathieu-Daud=C3=A9" : >+Markus/Thomas > >On 4/1/23 15:44, Bernhard Beschow wrote: >> During the last patches, TYPE_PIIX3_XEN_DEVICE turned into a clone of >> TYPE_PIIX3_DEVICE=2E Remove this redundancy=2E >>=20 >> Signed-off-by: Bernhard Beschow >> --- >> hw/i386/pc_piix=2Ec | 4 +--- >> hw/isa/piix=2Ec | 20 -------------------- >> include/hw/southbridge/piix=2Eh | 1 - >> 3 files changed, 1 insertion(+), 24 deletions(-) >>=20 >> diff --git a/hw/i386/pc_piix=2Ec b/hw/i386/pc_piix=2Ec >> index 5738d9cdca=2E=2E6b8de3d59d 100644 >> --- a/hw/i386/pc_piix=2Ec >> +++ b/hw/i386/pc_piix=2Ec >> @@ -235,8 +235,6 @@ static void pc_init1(MachineState *machine, >> if (pcmc->pci_enabled) { >> DeviceState *dev; >> PCIDevice *pci_dev; >> - const char *type =3D xen_enabled() ? TYPE_PIIX3_XEN_DEVICE >> - : TYPE_PIIX3_DEVICE; >> int i; >> pci_bus =3D i440fx_init(pci_type, >> @@ -250,7 +248,7 @@ static void pc_init1(MachineState *machine, >> : pci_slot_get_pirq); >> pcms->bus =3D pci_bus; >> - pci_dev =3D pci_new_multifunction(-1, true, type); >> + pci_dev =3D pci_new_multifunction(-1, true, TYPE_PIIX3_DEVICE)= ; >> object_property_set_bool(OBJECT(pci_dev), "has-usb", >> machine_usb(machine), &error_abort); >> object_property_set_bool(OBJECT(pci_dev), "has-acpi", >> diff --git a/hw/isa/piix=2Ec b/hw/isa/piix=2Ec >> index 98e9b12661=2E=2Ee4587352c9 100644 >> --- a/hw/isa/piix=2Ec >> +++ b/hw/isa/piix=2Ec >> @@ -33,7 +33,6 @@ >> #include "hw/qdev-properties=2Eh" >> #include "hw/ide/piix=2Eh" >> #include "hw/isa/isa=2Eh" >> -#include "hw/xen/xen=2Eh" >> #include "sysemu/runstate=2Eh" >> #include "migration/vmstate=2Eh" >> #include "hw/acpi/acpi_aml_interface=2Eh" >> @@ -465,24 +464,6 @@ static const TypeInfo piix3_info =3D { >> =2Eclass_init =3D piix3_class_init, >> }; >> -static void piix3_xen_class_init(ObjectClass *klass, void *data) >> -{ >> - DeviceClass *dc =3D DEVICE_CLASS(klass); >> - PCIDeviceClass *k =3D PCI_DEVICE_CLASS(klass); >> - >> - k->realize =3D piix3_realize; >> - /* 82371SB PIIX3 PCI-to-ISA bridge (Step A1) */ >> - k->device_id =3D PCI_DEVICE_ID_INTEL_82371SB_0; >> - dc->vmsd =3D &vmstate_piix3; > >IIUC, since this device is user-creatable, we can't simply remove it >without going thru the deprecation process=2E AFAICS this device is actually not user-creatable since dc->user_creatable= is set to false once in the base class=2E I think it is safe to remove the= Xen class unless there are ABI issues=2E Best regards, Bernhard >Alternatively we could >add a type alias: > >-- >8 -- >diff --git a/softmmu/qdev-monitor=2Ec b/softmmu/qdev-monitor=2Ec >index 4b0ef65780=2E=2Ed94f7ea369 100644 >--- a/softmmu/qdev-monitor=2Ec >+++ b/softmmu/qdev-monitor=2Ec >@@ -64,6 +64,7 @@ typedef struct QDevAlias > QEMU_ARCH_LOONGARCH) > #define QEMU_ARCH_VIRTIO_CCW (QEMU_ARCH_S390X) > #define QEMU_ARCH_VIRTIO_MMIO (QEMU_ARCH_M68K) >+#define QEMU_ARCH_XEN (QEMU_ARCH_ARM | QEMU_ARCH_I386) > > /* Please keep this table sorted by typename=2E */ > static const QDevAlias qdev_alias_table[] =3D { >@@ -111,6 +112,7 @@ static const QDevAlias qdev_alias_table[] =3D { > { "virtio-tablet-device", "virtio-tablet", QEMU_ARCH_VIRTIO_MMIO }, > { "virtio-tablet-ccw", "virtio-tablet", QEMU_ARCH_VIRTIO_CCW }, > { "virtio-tablet-pci", "virtio-tablet", QEMU_ARCH_VIRTIO_PCI }, >+ { "PIIX3", "PIIX3-xen", QEMU_ARCH_XEN }, > { } > }; >--- > >But I'm not sure due to this comment from commit ee46d8a503 >(2011-12-22 15:24:20 -0600): > >47) /* >48) * Aliases were a bad idea from the start=2E Let's keep them >49) * from spreading further=2E >50) */ > >Maybe using qdev_alias_table[] during device deprecation is >acceptable? > >> -} >> - >> -static const TypeInfo piix3_xen_info =3D { >> - =2Ename =3D TYPE_PIIX3_XEN_DEVICE, >> - =2Eparent =3D TYPE_PIIX_PCI_DEVICE, >> - =2Einstance_init =3D piix3_init, >> - =2Eclass_init =3D piix3_xen_class_init, >> -}; >> - >> static void piix4_realize(PCIDevice *dev, Error **errp) >> { >> ERRP_GUARD(); >> @@ -534,7 +515,6 @@ static void piix3_register_types(void) >> { >> type_register_static(&piix_pci_type_info); >> type_register_static(&piix3_info); >> - type_register_static(&piix3_xen_info); >> type_register_static(&piix4_info); >> } >> diff --git a/include/hw/southbridge/piix=2Eh b/include/hw/southbridge= /piix=2Eh >> index 65ad8569da=2E=2Eb1fc94a742 100644 >> --- a/include/hw/southbridge/piix=2Eh >> +++ b/include/hw/southbridge/piix=2Eh >> @@ -77,7 +77,6 @@ struct PIIXState { >> OBJECT_DECLARE_SIMPLE_TYPE(PIIXState, PIIX_PCI_DEVICE) >> #define TYPE_PIIX3_DEVICE "PIIX3" >> -#define TYPE_PIIX3_XEN_DEVICE "PIIX3-xen" >> #define TYPE_PIIX4_PCI_DEVICE "piix4-isa" >> #endif > From xen-devel-bounces@lists.xenproject.org Fri Jan 06 12:14:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 12:14:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472502.732726 (Exim 4.92) (envelope-from ) id 1pDlcR-0002kc-JA; Fri, 06 Jan 2023 12:14:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472502.732726; Fri, 06 Jan 2023 12:14:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDlcR-0002kV-Fr; Fri, 06 Jan 2023 12:14:43 +0000 Received: by outflank-mailman (input) for mailman id 472502; Fri, 06 Jan 2023 12:14:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDlcP-0002kP-IO for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 12:14:41 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id affb8b01-8dbb-11ed-91b6-6bf2151ebd3b; Fri, 06 Jan 2023 13:14:39 +0100 (CET) Received: from mail-mw2nam12lp2046.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.46]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 06 Jan 2023 07:14:35 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BN9PR03MB6073.namprd03.prod.outlook.com (2603:10b6:408:136::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Fri, 6 Jan 2023 12:14:33 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5944.019; Fri, 6 Jan 2023 12:14:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: affb8b01-8dbb-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1673007279; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=fCGwVpkqYvY+ebNdIlosFz/zHpTs09CKo5DcQO4LugE=; b=TLqEQ+N42Lz3l61qGg1TUgcgcW3ylFrmZ42f26Uf987LBPGYinSc8jVZ giia0vZ/TIx0iCVRqGFenC8YXuCDaAn4C7BrPUPd7foIU3WLWjmzt07fO 3PiYTiX4iwKVx9UxWFPltQfaTYkqfve6AzCLJ9C1xSQ7sEJqNm4ZJQyQI c=; X-IronPort-RemoteIP: 104.47.66.46 X-IronPort-MID: 91882619 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:n7hKqqnsttR2muTDhFU+qeno5gxKJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xJJC2HVO/aKNmT9c9p/aISy9EJSvJ7UndNgSApp/ig8ECMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icf3grHmeIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aqaVA8w5ARkPqgS5AGGzRH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 aYEDg0dPlOGu/CRw4y9evtP3906F+C+aevzulk4pd3YJdAPZMmZBoD1v5pf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVklI3jOaF3Nn9I7RmQe18mEqCq 32A1GP+GhwAb/SUyCaf82LqjejK9c/+cNNLRO3iqKc76LGV7k0cSwQnZXSQmvKSm3yGQe4FL VdMoBN7+MDe82TuFLERRSaQonSJoxodUNp4CPAh5UeGza+8yx2CGmEOQzpFadonnMw7Xzon0 hmOhdyBLSNrmK2YTzSa7Lj8hTGvPSkYK0cSaClCShEKi/HzrYd2gh/RQ9JLFK+uksazCTz22 yqNriU1m/MUl8Fj6kmg1VXOgjbpo4eTSAcwv1/TRjj9sl0/Y5O5bYu171Sd9exHMIuSUliGu j4DhtSa6+cNS5qKkURhXdkwIV1g3N7dWBW0vLKlN8BJG+iFk5J7Qb1t3Q== IronPort-HdrOrdr: A9a23:y5JW5a7IPuV9pSEKKQPXwHrXdLJyesId70hD6qm+c20wTiX4rb HcoB1/73SbtN9/YhEdcK+7SdO9qB/nlKKdgrNhTItKIjOW2ldARbsKheHfKlbbak7DH4BmpM Jdm6MXMqyMMbAT5/yX3OHSeexO/DFJmprEuc7ui05ICSVWQ+VY6QF9YzzrYnGfhmN9dOYE/F 733Ls4m9JkE05nEfhTfUN1ONTrlpnwjZf7ZhxDLAIm7QTmt0LS1JfKVyKA2wsYUXd04ZpKyx miryXJop+7tu29yFvn23TN449wkN/so+EzffCku4wuMzDxjQTtW4h7Qb2Fu1kO0ZmS1Go= X-IronPort-AV: E=Sophos;i="5.96,305,1665460800"; d="scan'208";a="91882619" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gnzv7MAvU48SvKl6ofvDE2CqNYjtMDmtwPNEprPFcX5B/cUkYeO/3pxDwDUOxOXB/uX9zTzD4ssPckYMPcXHMaZ83aTgV+dZg6BJSSZqkrPJIYt8XMYoVu814f9iQYlHiutSvjeKxxtfBFh3FOlcNc4HW+z+vLCMmFZ50D6ABO9+0Lx6G27jDcTOpy2fUC2MU6tLB8GVNuE2PrG0EE3QSxilTXkTQ+Agv4nFmlM6sjczHRxJb8Bw0hEWY+MGxxOKgLngiax8EyA0eGEgE57EIkmZehUKseY7N5a8dY35i5yetf2rgr6oIqvicYeI9hLi2X+++AkTEvTAV76roGgbpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fCGwVpkqYvY+ebNdIlosFz/zHpTs09CKo5DcQO4LugE=; b=mnvCVmDHDXZWfDmHXxQLe3PXF63ajX/wS+b6uEiWIC4QdXcRP9i2EYcSffdZL+KNgG6TCeFjRoYDB0uCFtGNkuwKv1lC8EMxP/evgwTqn1llQHd3oQKct5J9QodSNI9lP2ex6y+qsHyZb8G6M7awI031ojFWqhYB0WtAaRQ2J0yav6bmT5XKNABKSQuT488mq/Y5BXpAE7Axbuwf9kk0/APE8OknSkl7huz+BUb+QWG/OssJvOJXW4J3F7Q2rCKPL+viXuaX62HZ0YSCjDZOIxDFU4Ge5FcVWWESNt4hMbOSSwIpwvcirDAlXcvVu/CfB3mU8b5+kqxPwwwTuLpxrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fCGwVpkqYvY+ebNdIlosFz/zHpTs09CKo5DcQO4LugE=; b=RArDU5/77Yjd/SXsCXY23eeI65cb2+umWMXSn6dqxW68J8R+F3xLb5wYB+CyiIQNp4fWxBDarwWv6+nMSe3ZVAwxZUuSWXc0VZGK3w4FtMXODc7MOWeFpfY0SkwmBP1sHoC6a8WV1zb9sfVkNX4nsgA/gIqJsG/wA8Rsp7ILK1A= From: Andrew Cooper To: Jan Beulich CC: George Dunlap , Stefano Stabellini , Wei Liu , Julien Grall , Xen-devel Subject: Re: [PATCH 3/4] xen/version: Drop bogus return values for XENVER_platform_parameters Thread-Topic: [PATCH 3/4] xen/version: Drop bogus return values for XENVER_platform_parameters Thread-Index: AQHZH69XYhd2rMGoWE+asSBKOPPG4q6OdxyAgAA2ioCAAMm+gIAA8B2AgAChQoCAAEi6gA== Date: Fri, 6 Jan 2023 12:14:31 +0000 Message-ID: <5bb7382c-bed0-144c-2906-38bc08c76a52@citrix.com> References: <20230103200943.5801-1-andrew.cooper3@citrix.com> <20230103200943.5801-4-andrew.cooper3@citrix.com> <540a449d-f76d-eb16-4f98-c4fb3564ce98@suse.com> <7dd00ce3-a95b-2477-128c-de36e75c4a34@citrix.com> <9ce20298-5870-aa1b-ee5e-e16a623beadb@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|BN9PR03MB6073:EE_ x-ms-office365-filtering-correlation-id: 48acae29-53ec-4d7d-4413-08daefdf911b x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hCyLquK7cW01e/Tx4i3/q1Bt4LO3VvJ0buTqfcQx6fG+iMvNiFfPsfQ4yd2figH5KAGqlb/Yy9s4cGtkBVyEWjkc9nQexST7nGecX3EQoj9G5ByfU12qbfx8kKM/0vt9D1Fe51/HrRckZNZSU3A4D+Djz+1Sv083+surlkGLsAxNvOU41bVTsi2azBlgUmt5O8Hdf/TN/5qQyCwnhRoUkidhfE9v0QZwhvT21Nj+ELAznrbglMsMXDlmpJO+h1larHtq/peXgo7nLJA8zocK3LJ7vbdQ8+IVarPioxFxqVY9wOaES+EJ9pb8oGr1MBLqK4rDfLR9o2HNx8y0gp78AWyosZU8ezDx8Nf9iSX8Z9qrQWcjaV1m21uyUo74ouyPzdGIqz+aYWWXe3Xda/fx5LXbkDbt2AQhgqc1+NNAKRN00lpGdiJx2zbf/bxUSkQRy10jQYAycPxHL/gNsZK+SJX57QYcGEtvgC9r69a5HYFPlhkiqoP/MD8HR8acqy1x0L/q/tlvGx8HPfzdHiVRhkivfrSaEesrp8hFCaUrJei55KLAnlYko0UfZWEkzJRJnYWQoFUyahlEcRfc5EY6WamLG57sYe5jbGpZlM0tDNRwltLXAkvwOtdM9pfgzrfmYT1epmKq9Q3oPLKCw7V/Hnm4Rri7c6LtNG+m1W9/PTFLSi3C5YsWVcXI0y3ZgITkUQZERlgNuzHJ6wciUe817AsVFQCz20cdnA5CEWLuFiZ7BYGQSRzU6OEIIOc5EOPnAyb6/o5xO2D5w5jcvV02AQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(376002)(136003)(346002)(396003)(39860400002)(451199015)(5660300002)(2906002)(8936002)(4326008)(8676002)(31686004)(41300700001)(66946007)(64756008)(76116006)(316002)(91956017)(54906003)(66446008)(6916009)(478600001)(66556008)(66476007)(71200400001)(6486002)(6512007)(2616005)(186003)(26005)(6506007)(53546011)(31696002)(38100700002)(122000001)(86362001)(38070700005)(82960400001)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NkI1a3Q4Z3pPQlQ2OW9RcUVydGRxa0p2cWZNWTBWMnNiM2NiKzZDdE1yaUdx?= =?utf-8?B?ZjAvN25Tb1dvMHo2ZHZtK1NpejVXZ2lJT3hGdHZ0ZjN6dno4SkVSbHlQMFF5?= =?utf-8?B?YVA1aHZNNWpqV3NWdGtQNFhxYXNSOFl6V3pWR0tJZ1B6aC8xSWU0VmVnZFJS?= =?utf-8?B?Z25JTmRpMWJ4eEZpMldyMzNVL1FlVk53dlZ2Snh0STREcWprNFVNdnNVMTJZ?= =?utf-8?B?MmdlYm02eDg1cTlGWFUwM1RHRjZkTElBR3dLdFJRaWJ2MGdhOXZSaEVFWE81?= =?utf-8?B?RStyTzVidi9mQWFmQkpINTVCbS90d0RLWFM1dFVGL1NaVmc1ZVZSVURONmdl?= =?utf-8?B?U3ZuOGNhdUEyNUJGWHVwb2Q4RS9EMnpVUzYrR3FsZCswdjhSNDlvWXhUV3po?= =?utf-8?B?M0NWT2g5NmMwRUVBWVhtbTlIZ1RxZ2l1emdTVW0zbGcvQkx3anN2MG04QUVB?= =?utf-8?B?Ty8rWEpqOU1jbG5vM3czUWhjajU4eDVkYndOR1J5N0Q2bG1VYUdmM3NBeFRr?= =?utf-8?B?eEh4TGZqZ3RIWko0Q3dacTREVVNpa3pBNVNCYnNyYlVpNXZYMDZIRzlLUGJG?= =?utf-8?B?dkJXQTBJbVpLRlhUNFkwZWd1RWdoTjY3T1RXRitIWkplck0vOXloOHZuSnlp?= =?utf-8?B?MzlYVmdaQnUvWnNmeHNGeVBYdElpNU9RQWZZV1BNWHZOMnZONzcvL3NGZW81?= =?utf-8?B?KzJnNmJSYnhPWmpMbHZPblZFcEFkL3NTV25udzJHZkRvekg4RU9wMzZieEVH?= =?utf-8?B?T3o5TjJaSTQ0VzN3eXhwak11dWI3TWJwUU9WMkRTNllhaVVROU9PK0I3SUl5?= =?utf-8?B?cDhqZm53MTlGSEM0NDZnU1hZdTk1MTEyMlhQbFhvRzVaUUlZWXRJZ1pDSzYv?= =?utf-8?B?cEdwT285MHdlWitlR3g2R0FMVitqUjdubjc2YXgzQnVwZEo0Z1ExRVlLV1VT?= =?utf-8?B?ekUwUXJSc1ZtRTFvd3JVZ3dOZmxrMTdyYmIxZUZrZWxzNVpmcXBJRUQxZE5B?= =?utf-8?B?aTRYdGwwMzJNaUUrY0M3MldTbEFSQkFvYUFUNGZ4ZTc5SkdOL2ZGTUo2STBl?= =?utf-8?B?UnJIWThoa2ZVVXNBbFpHRWlZd0FaaXRKUE9WeGRqNU5IbjdCYUFYMTZtZmdo?= =?utf-8?B?dlQ0R3pWUmpwM3RxY0daREtoTm1SRDhYTHNOaVdKNHRjSXdiMzhaMWIxMytu?= =?utf-8?B?TXo4MW9wN3NZMmRTY25MY2plMXdzazRiSVdDRzBWc2tuNmp3UjBUR0ZtR29Q?= =?utf-8?B?NU5CZlkzYUJFdXNxbDlHNWcyVnM1ZWFRSmFrZUFxM2NscncyNkt1QnVNc0ZY?= =?utf-8?B?UlYxdCtSWHlOQ1cxdHhuUWdlUkszcWxUQ2ZFYnI4Mk12VU5vQ1JMM1BHUWx4?= =?utf-8?B?VlNHc1Q4ZEhMc3JEY2Irek9VdXdzVk9CbmIwaEFoY00vVVA5bmU2NW1ZeW1m?= =?utf-8?B?ZEpiaktLQ29BT2VhYlJVM1pOOUZTUDdCSytkNlNGRGQrUm1XZmlma2R3Q21x?= =?utf-8?B?UFo4NjVPaElxak8xdld2R0hqSllQNjZIUDk1UjBOSzBTN3B2c2x1M245b0ZY?= =?utf-8?B?WnV5bEE5eWs1Rk5MaTJoTzlrRCtjYWhUbURWVUJTa3d3R21VaW1GVzBUY2gw?= =?utf-8?B?N1ZVcWJ3THhFUmdsci9LMWsvVmNEemRyd2EvS21pYjVtaG5nakc4Zk9iS2w2?= =?utf-8?B?S2NUbzNJR0Z0RW95K1Bla0d0SGhjRFZIajAwQ3ZoOGMvU0F5MHg1bEVZTW8z?= =?utf-8?B?dStVY2E3ZFBJeVlvMjhwM3owYmtMWDFLNGhpcnFIQlQ4UXkzNmd0UkdxaDJh?= =?utf-8?B?cVFZSmJaUG85VGJrdDltd0tqREx3YjQ5L0dBb2hGVXBnZDkxaFUyM05yWWF3?= =?utf-8?B?RzJQemRrUE50d0dBNlpHZmNNY25Ccm01eEoyZXdqSFh0TmNWQXA3eFF6UGli?= =?utf-8?B?Wnk1Rk40MldSMW9PSkRkTkc3STI1MmZDbFpheWNBRHJEbWxjQXFCUlV5dlFI?= =?utf-8?B?eis2VFJNNGNXOXc4bHBPK2xrRElQZzQ2NmYrb0pwMUpTVWRocCtzczRFRWNX?= =?utf-8?B?RzhDY3JEdWtvWHl2cnZ2eGU5RzVmaURqVzFxRy9tWjlKdzhuTGgyR0hFWVdz?= =?utf-8?B?M0Z3N2wxeDZidzVrSTlHczRmbmprU0pZaFc1eldDUG83bklQeHZnVTVnQUN2?= =?utf-8?B?blE9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <7596C5B903702049A2859A08808AEB5A@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: hLUuJW/ByHtEP3ERw0H2Q1OUqsOvoJ7ddioftGV5fdJLxV7OKf0gtvVQMRUsi6/jRJSEEZnuI5upCLVTbBnNS0DkCZ0jGSLlVj+j9fnUGh75grnlU02yOSTDDoIENg9jm8osfH17No+C8+sRe3l+7pGkK/O0bPSypYyD6rBixV3c4pSIozUxBLsNFYml6UDtMW7b09WsrUeMYg93t/mk+5IjyXUix+LxK91ZXtashNk2e1ViCdCz+HVl1N30gEv0fzMBSdpguoKamev4m9Jb6h21D1bmF3bBrQOb7plDS9PDQiLYzlc/X7O0BODI5luJH95cbruajaXKQMkoaAEfwPXMg34uGFZUut/hTfPv3IJAYSLgTx2uOTtKPkslI1wxQxbQZDPeYj/Nh5GbACBQUmWd2JNGMBeAZx9Hlcb5KVOCnrx4zZ1y1tPgWKzhdpLAjQs3DO89L9eb17ZnthQBEF4HiFQeIQfBJkgaTbU2zNJhNdKsw0Ba2Fdhi01ViXVF9qxIqaNuRI3X4MsSCJ6dQEw2hmssnxRV0poXBjSKH7RXBw2xXhrnLhKafQLLxw6dYOFn6/G33YOdbsYMKLGCPp02uYppOQ/drNdGzS+PqBfMT0FTqulZuQASUbckqqGjtLha/Gl0Zj2ta1ECwWMcGDykJ9R7BTTjiQ82KxELZJCAbIGHIG5VvaI3CZBWKtU9aevCYHeTTE3kvoWdYAx0L+WRJV8xCiptlCYyKxLYmtJqYWL5DS1kAzhdQrk9sykY39YiorA9yEsG71F3Ep2qJ95e1oWZHrUDHWoeCwE4Q3YuUSi2W6tdfUGmpUyppCd89lxXNG8dTQFxRP7bXIKtxeb0/J1VApdgDRxigtkz+1Ab2Md7O5XCKokUH8//GM+i X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 48acae29-53ec-4d7d-4413-08daefdf911b X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jan 2023 12:14:31.6950 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5wuhcADoqDBze5TA6FXCLosO7FAiYnUeIbW3udpoCgE9PPNTi5T3viMHUcNVd8KFzDQb0Mf/sU0C7Bd5kInxiOx3FpgYPdF2Vdk//Y/Oa44= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB6073 T24gMDYvMDEvMjAyMyA3OjU0IGFtLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMDUuMDEuMjAy MyAyMzoxNywgQW5kcmV3IENvb3BlciB3cm90ZToNCj4+IE9uIDA1LzAxLzIwMjMgNzo1NyBhbSwg SmFuIEJldWxpY2ggd3JvdGU6DQo+Pj4gT24gMDQuMDEuMjAyMyAyMDo1NSwgQW5kcmV3IENvb3Bl ciB3cm90ZToNCj4+Pj4gT24gMDQvMDEvMjAyMyA0OjQwIHBtLCBKYW4gQmV1bGljaCB3cm90ZToN Cj4+Pj4+IE9uIDAzLjAxLjIwMjMgMjE6MDksIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+Pj4+Pj4g QSBzcGxpdCBpbiB2aXJ0dWFsIGFkZHJlc3Mgc3BhY2UgaXMgb25seSBhcHBsaWNhYmxlIGZvciB4 ODYgUFYgZ3Vlc3RzLg0KPj4+Pj4+IEZ1cnRoZXJtb3JlLCB0aGUgaW5mb3JtYXRpb24gcmV0dXJu ZWQgZm9yIHg4NiA2NGJpdCBQViBndWVzdHMgaXMgd3JvbmcuDQo+Pj4+Pj4NCj4+Pj4+PiBFeHBs YWluIHRoZSBwcm9ibGVtIGluIHZlcnNpb24uaCwgc3RhdGluZyB0aGUgb3RoZXIgaW5mb3JtYXRp b24gdGhhdCBQViBndWVzdHMNCj4+Pj4+PiBuZWVkIHRvIGtub3cuDQo+Pj4+Pj4NCj4+Pj4+PiBG b3IgNjRiaXQgUFYgZ3Vlc3RzLCBhbmQgYWxsIG5vbi14ODYtUFYgZ3Vlc3RzLCByZXR1cm4gMCwg d2hpY2ggaXMgc3RyaWN0bHkNCj4+Pj4+PiBsZXNzIHdyb25nIHRoYW4gdGhlIHZhbHVlcyBjdXJy ZW50bHkgcmV0dXJuZWQuDQo+Pj4+PiBJIGRpc2FncmVlIGZvciB0aGUgNjQtYml0IHBhcnQgb2Yg dGhpcy4gU2VlaW5nIExpbnV4J2VzIGV4cG9zdXJlIG9mIHRoZQ0KPj4+Pj4gdmFsdWUgaW4gc3lz ZnMgSSBldmVuIHdvbmRlciB3aGV0aGVyIHdlIGNhbiBjaGFuZ2UgdGhpcyBsaWtlIHlvdSBkbyBm b3INCj4+Pj4+IEhWTS4gV2hvIGtub3dzIHdoYXQgaXMgYmVpbmcgaW5mZXJyZWQgZnJvbSB0aGUg dmFsdWUsIGFuZCBieSB3aG9tLg0KPj4+PiBMaW51eCdzIHN5c2ZzIEFCSSBpc24ndCByZWxldmFu dCB0byB1cyBoZXJlLsKgIFRoZSBzeXNmcyBBQkkgc2F5cyBpdA0KPj4+PiByZXBvcnRzIHdoYXQg dGhlIGh5cGVydmlzb3IgcHJlc2VudHMsIG5vdCB0aGF0IGl0IHdpbGwgYmUgYSBub256ZXJvIG51 bWJlci4NCj4+PiBJdCBlZmZlY3RpdmVseSByZXBvcnRzIHRoZSBoeXBlcnZpc29yICh2aXJ0dWFs KSBiYXNlIGFkZHJlc3MgdGhlcmUuIEhvdw0KPj4+IGNhbiB3ZSBub3QgY2FyZSBpZiBzb21ldGhp bmcgKGtleGVjIHdvdWxkIGNvbWUgdG8gbWluZCkgd291bGQgYmUgdXNpbmcNCj4+PiBpdCBmb3Ig d2hhdGV2ZXIgcHVycG9zZS4NCj4+IFdoYXQgYWJvdXQga2V4ZWMgZG8geW91IHRoaW5rIHdvdWxk IGNhcmU/DQo+IEkgZGlkbid0IHRoaW5rIGFib3V0IGFueXRoaW5nIHNwZWNpZmljLCBidXQgSSBj b3VsZCBzZWUgd2h5IGl0IG1heSB3YW50IHRvDQo+IGtub3cgd2hlcmUgaW4gVkEgc3BhY2UgWGVu IHNpdHMuDQoNClRoZSBrZXhlYyBpbWFnZSBkb2Vzbid0IHJ1biAidW5kZXIiIFhlbjsgaXQgcmVw bGFjZXMgWGVuIGluIG1lbW9yeSwgYW5kDQp0cmFuc2l0aW9uIGludG8gdGhlIG5ldyBpbWFnZSBp cyB2aWEgbm8gcGFnaW5nICgzMmJpdCkgb3IgaWRlbnRpdHkNCnBhZ2luZyAoNjRiaXQpIGluIHRo ZSByZXNlcnZlZCByZWdpb24uDQoNCldlIGRvbid0IHJlYWxseSBzdXBwb3J0IGtleGVjIGxvYWQg KGl0J3MgdGhlcmUsIGJ1dCBJIGRvbid0IGV4cGVjdA0KYW55b25lIGhhcyBleGVyY2lzZWQgaXQg aW4gYW5nZXIpLCBidXQgaWYgd2Ugd2VyZSB0byBsb2FkIGEgbmV3DQpYZW4rZG9tMCwgdGhlbiBr ZXhlYy10b29scyBzdGlsbCBoYXMgbm90aGluZyByZWxldmFudCB0byBkbyB3aXRoDQpuZXctWGVu K2RvbTAncyBzcGxpdC4NCg0KPj4+Pj4+ICsgKiBGb3IgYWxsIGd1ZXN0IHR5cGVzIHVzaW5nIGhh cmR3YXJlIHZpcnQgZXh0ZW50aW9ucywgWGVuIGlzIG5vdCBtYXBwZWQgaW50bw0KPj4+Pj4+ICsg KiB0aGUgZ3Vlc3Qga2VybmVsIHZpcnR1YWwgYWRkcmVzcyBzcGFjZS4gIFRoaXMgbm93IHJldHVy biAwLCB3aGVyZSBpdA0KPj4+Pj4+ICsgKiBwcmV2aW91c2x5IHJldHVybmVkIHVucmVsYXRlZCBk YXRhLg0KPj4+Pj4+ICsgKi8NCj4+Pj4+PiAgI2RlZmluZSBYRU5WRVJfcGxhdGZvcm1fcGFyYW1l dGVycyA1DQo+Pj4+Pj4gIHN0cnVjdCB4ZW5fcGxhdGZvcm1fcGFyYW1ldGVycyB7DQo+Pj4+Pj4g ICAgICB4ZW5fdWxvbmdfdCB2aXJ0X3N0YXJ0Ow0KPj4+Pj4gLi4uIHRoZSBmaWVsZCBuYW1lIHRl bGxzIG1lIHRoYXQgYWxsIHRoYXQgaXMgYmVpbmcgY29udmV5ZWQgaXMgdGhlIHZpcnR1YWwNCj4+ Pj4+IGFkZHJlc3Mgb2Ygd2hlcmUgdGhlIGh5cGVydmlzb3IgYXJlYSBzdGFydHMuDQo+Pj4+IElN TywgaXQgZG9lc24ndCBtYXR0ZXIgd2hhdCB0aGUgbmFtZSBvZiB0aGUgZmllbGQgaXMuwqAgSXQg ZGF0ZXMgZnJvbSB0aGUNCj4+Pj4gZGF5cyB3aGVuIDMyYml0IFBWIHdhcyB0aGUgb25seSB0eXBl IG9mIGd1ZXN0Lg0KPj4+Pg0KPj4+PiAzMmJpdCBQViBndWVzdHMgcmVhbGx5IGRvIGhhdmUgYSB2 YXJpYWJsZSBzcGxpdCwgc28gdGhlIGd1ZXN0IGtlcm5lbA0KPj4+PiByZWFsbHkgZG9lcyBuZWVk IHRvIGdldCB0aGlzIHZhbHVlIGZyb20gWGVuLg0KPj4+Pg0KPj4+PiBUaGUgc3BsaXQgZm9yIDY0 Yml0IFBWIGd1ZXN0cyBpcyBjb21waWxlLXRpbWUgY29uc3RhbnQsIGhlbmNlIHdoeSA2NGJpdA0K Pj4+PiBQViBrZXJuZWxzIGRvbid0IGNhcmUuDQo+Pj4gLi4uIG9uY2Ugd2UgZ2V0IHRvIHJ1biBY ZW4gaW4gNS1sZXZlbCBtb2RlLCA0LWxldmVsIFBWIGd1ZXN0cyBjb3VsZCBhbHNvDQo+Pj4gZ2Fp biBhIHZhcmlhYmxlIHNwbGl0OiBMaWtlIGZvciAzMi1iaXQgZ3Vlc3RzIG5vdywgb25seSB0aGUg ci9vIE0yUCB3b3VsZA0KPj4+IG5lZWQgdG8gbGl2ZSBpbiB0aGF0IGFyZWEsIGFuZCB0aGlzIG1h eSB3ZWxsIG9jY3VweSBsZXNzIHRoYW4gdGhlIGZ1bGwNCj4+PiByYW5nZSBwcmVzZW50bHkgcmVz ZXJ2ZWQgZm9yIHRoZSBoeXBlcnZpc29yLg0KPj4gLi4uIHlvdSBjYW4ndCBkbyB0aGlzLCBiZWNh dXNlIGl0IG9ubHkgd29ya3MgZm9yIGd1ZXN0cyB3aGljaCBoYXZlDQo+PiBjaG9zZW4gdG8gZmlu ZCB0aGUgTTJQIHVzaW5nIFhFTk1FTV9tYWNocGh5c19tYXBwaW5nIChlLmcuIExpbnV4KSwgYW5k DQo+PiBkb2Vzbid0IGZvciBlLmcuIE1pbmlPUyB3aGljaCBkb2VzOg0KPj4NCj4+ICNkZWZpbmUg bWFjaGluZV90b19waHlzX21hcHBpbmcgKCh1bnNpZ25lZCBsb25nICopSFlQRVJWSVNPUl9WSVJU X1NUQVJUKQ0KPiBIbW0sIGxvb2tzIGxpa2UgYSBtaXN1bmRlcnN0YW5kaW5nPyBJIGNlcnRhaW5s eSB3YXNuJ3QgdGhpbmtpbmcgYWJvdXQNCj4gbWFraW5nIHRoZSBzdGFydCBvZiB0aGF0IHJlZ2lv biB2YXJpYWJsZSwgYnV0IHJhdGhlciB0aGUgZW5kIChpLmUuIG5vdA0KPiBleGFjdGx5IGxpa2Ug Zm9yIDMyLWJpdCBjb21wYXQpLg0KDQpCdXQgZm9yIHdoYXQgcHVycG9zZT/CoCBZb3UgY2FuJ3Qg bWFrZSA0LWxldmVsIGd1ZXN0cyBoYXZlIGEgdmFyaWFibGUgcmFuZ2UuDQoNClRoZSBiZXN0IHlv dSBjYW4gZG8gaXMgbWFrZSBhIDUtbGV2ZWwtYXdhcmUgZ3Vlc3QgcnVubmluZyBvbiA0LWxldmVs IFhlbg0KaGF2ZSBzb21lIG5ldyBzZW1hbnRpY3MsIGJ1dCBhIDQtbGV2ZWwgUFYgZ3Vlc3QgYWxy ZWFkeSBvd25zIHRoZQ0Kb3ZlcndoZWxtaW5nIG1ham9yaXR5IG9mIHZpcnR1YWwgYWRkcmVzcyBz cGFjZSwgc28gYmVpbmcgYWJsZSB0byBoYW5kDQpiYWNrIGEgZmV3IGV4dHJhIFRCIGlzIG5vdCBp bnRlcmVzdGluZy7CoCBBbmQgZm9yIG1ha2luZyB0aGF0IGhhcHBlbi4uLg0KDQo+Pj4+IEZvciBj b21wYXQgSFZNLCBpdCBoYXBwZW5zIHRvIHBpY2sgdXAgdGhlIC0xIGZyb206DQo+Pj4+DQo+Pj4+ ICNpZmRlZiBDT05GSUdfUFYzMg0KPj4+PiDCoMKgwqAgSFlQRVJWSVNPUl9DT01QQVRfVklSVF9T VEFSVChkKSA9DQo+Pj4+IMKgwqDCoMKgwqDCoMKgIGlzX3B2X2RvbWFpbihkKSA/IF9fSFlQRVJW SVNPUl9DT01QQVRfVklSVF9TVEFSVCA6IH4wdTsNCj4+Pj4gI2VuZGlmDQo+Pj4+DQo+Pj4+IGlu IGFyY2hfZG9tYWluX2NyZWF0ZSgpLCB3aGVyZWFzIGZvciBub24tY29tcGF0IEhWTSwgaXQgZ2V0 cyBhIG51bWJlciBpbg0KPj4+PiBhbiBhZGRyZXNzIHNwYWNlIGl0IGhhcyBubyBjb25uZWN0aW9u IHRvIGluIHRoZSBzbGlnaHRlc3QuwqAgQVJNIGd1ZXN0cw0KPj4+PiBlbmQgdXAgZ2V0dGluZyBY RU5fVklSVF9TVEFSVCAoPT0gMk0pIGhhbmRlZCBiYWNrLCBidXQgdGhpcyBhYnNvbHV0ZWx5DQo+ Pj4+IGFuIGludGVybmFsIGRldGFpbCB0aGF0IGd1ZXN0cyBoYXZlIG5vIGJ1c2luZXNzIGtub3dp bmcuDQo+Pj4gV2VsbCwgb2theSwgdGhpcyBsb29rcyB0byBiZSBnb29kIGVub3VnaCBhbiBhcmd1 bWVudCB0byBtYWtlIHRoZSBhZGp1c3RtZW50DQo+Pj4geW91IHByb3Bvc2UgZm9yICFQViBndWVz dHMuDQo+PiBSaWdodCwgSFZNIChvbiBhbGwgYXJjaGl0ZWN0dXJlcykgaXMgdmVyeSBjdXQgYW5k IGRyeS4NCj4+DQo+PiBCdXQgaXQgZmVlbHMgd3JvbmcgdG8gbm90IGFkZHJlc3MgdGhlIFBWNjQg aXNzdWUgYXQgdGhlIHNhbWUgdGltZQ0KPj4gYmVjYXVzZSBpdCBpcyBzaW1pbGFyIGxldmVsIG9m IGJyb2tlbiwgZGVzcGl0ZSB0aGVyZSBiZWluZyAoaW4gdGhlb3J5KSBhDQo+PiBsZWdpdGltYXRl IG5lZWQgZm9yIGEgUFYgZ3Vlc3Qga2VybmVsIHRvIGtub3cgaXQuDQo+IFRvIG1lIGl0IGZlZWxz IHdyb25nIHRvIGFkZHJlc3MgdGhlIDY0LWJpdCBQViBpc3N1ZSBieSByZW1vdmluZyBpbmZvcm1h dGlvbiwNCj4gd2hlbiAtIGFzIHlvdSBhbHNvIHNheSAtIGl0IGlzIGFjdHVhbGx5IF9taXNzaW5n XyBpbmZvcm1hdGlvbi4gVG8gbWUgdGhlDQo+IHByb3BlciBjb3Vyc2Ugb2YgYWN0aW9uIHdvdWxk IGJlIHRvIGV4cG9zZSB0aGUgdXBwZXIgYm91bmQgYXMgd2VsbCAoc3VjaA0KPiB0aGF0LCBkb3du IHRoZSByb2FkLCBpdCBjb3VsZCBiZWNvbWUgZHluYW1pYykuIFRoZXJlJ3MgYWxzbyBubyBpbmZv IGxlYWsNCj4gdGhlcmUsIGFzIHRoZSB0d28gKHN0YXRpYykgYm91bmRzIGFyZSBwYXJ0IG9mIHRo ZSBQViBBQkkgYW55d2F5Lg0KDQouLi4gdGhlIGFic29sdXRlIGJlc3QgeW91IGNvdWxkIGRvIGhl cmUgaXMgaW50cm9kdWNlIGEgbmV3DQpYRU5WRVJfcGxhdGZvcm1fcGFyYW1ldGVyczIgdGhhdCBo YXMgYSBkaWZmZXJlbnQgc3RydWN0dXJlLg0KDQpXaGljaCBzdGlsbCBsZWF2ZXMgdXMgd2l0aCBY RU5WRVJfcGxhdGZvcm1fcGFyYW1ldGVycyBwcm92aWRpbmcgZGF0YQ0Kd2hpY2ggaXMgc29tZXdo ZXJlIGJldHdlZW4gdXNlbGVzcyBhbmQgYWN0aXZlbHkgdW5oZWxwZnVsLg0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Fri Jan 06 12:25:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 12:25:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472509.732738 (Exim 4.92) (envelope-from ) id 1pDln6-0004FV-Jw; Fri, 06 Jan 2023 12:25:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472509.732738; Fri, 06 Jan 2023 12:25:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDln6-0004FO-FD; Fri, 06 Jan 2023 12:25:44 +0000 Received: by outflank-mailman (input) for mailman id 472509; Fri, 06 Jan 2023 12:25:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDln4-0004FI-Oh for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 12:25:42 +0000 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [2a00:1450:4864:20::330]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3b2c188f-8dbd-11ed-b8d0-410ff93cb8f0; Fri, 06 Jan 2023 13:25:40 +0100 (CET) Received: by mail-wm1-x330.google.com with SMTP id l26so937018wme.5 for ; Fri, 06 Jan 2023 04:25:40 -0800 (PST) Received: from [192.168.30.216] ([81.0.6.76]) by smtp.gmail.com with ESMTPSA id az28-20020a05600c601c00b003cf57329221sm6055371wmb.14.2023.01.06.04.25.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Jan 2023 04:25:38 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3b2c188f-8dbd-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=cGfTsxDRG+LfoKkBFGZZ/WvwF0lb6LoKmVVmXvkk4C0=; b=j2BRoliK8qTd+F+OwsZmpdkMniMJPUoh7KnKOodKcQYhH8dYCE2hyVbmWCgTN/maAx r6eQt2KWt4gVNOl07Yrcf+URqL26xP1qlD6w0frzh8QHhCSN6G57NOTcuvs5a31tcrL9 avJ61vY5r0QCoAeGgk2zzuozoAT4vUlXZu5A/EzY20ki4osHwGvFAMBpj/0sBdYVdyNL LedpN2q7UKSxvg7sEVLNNlfg27/NpLeX6nm9lg+c6dlaKgujb7BGQ5Mwx3ltCuIq/jWm dGR4bfGffK1SpFmx9areMCmVEZo8cuK3QDTXkDYPkwaRZljpwDvTOyTrkKc8XHSmVEl1 8zkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cGfTsxDRG+LfoKkBFGZZ/WvwF0lb6LoKmVVmXvkk4C0=; b=Xcc1hMaebxcfcSCDVxNv3wmXy7r8lvjF2P7XSLI3JINGd5cnpByvI4lyd2gEqB10CE NIcH3jH7Cs5uXMzZ9MM9bIpq0eYpeyrHxOAQUTMonw3dV6LCrSCiMPD9zLJohbZcTR8Y vcCWqfkifcIhvL60BfD351+xAxcNxrfTUfAczL/5KSmnNj/4mE6ek8tZV9s2ShdrosLz kZiaUN78HvrIhfHcpfiiZwiXdae8GHKHLs+uvMOXPWWr+3oFMziJyI84McZF0t2RcUsZ xKtwkGp67rRSiIwIPHz6NM1W+xv02UEKrEeSbH6DWv0B69Lu5LPkFu2KsH/Lb3S8oh6w WDhA== X-Gm-Message-State: AFqh2kqj8UX47c+Civ7J/U5UJ/uCR4h6reAVXwWPNbF0I2HF6JtCcYf3 sFlJPjZC4VAmkKN1mbgJRjE87w== X-Google-Smtp-Source: AMrXdXtK2NS9bhPqosfbghflNCW3WATI4EQme8et2nuxBkQ/Co7cKEvbgMhqSWzvFuxk9D76m9gkLw== X-Received: by 2002:a05:600c:3d1b:b0:3d0:6a57:66a5 with SMTP id bh27-20020a05600c3d1b00b003d06a5766a5mr38329071wmb.0.1673007938784; Fri, 06 Jan 2023 04:25:38 -0800 (PST) Message-ID: <6a1a6ed8-568d-c08b-91a7-1093a2b25929@linaro.org> Date: Fri, 6 Jan 2023 13:25:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 6/6] hw/isa/piix: Resolve redundant TYPE_PIIX3_XEN_DEVICE Content-Language: en-US To: Bernhard Beschow , qemu-devel@nongnu.org, Markus Armbruster Cc: Richard Henderson , Stefano Stabellini , xen-devel@lists.xenproject.org, =?UTF-8?Q?Herv=c3=a9_Poussineau?= , Aurelien Jarno , Paul Durrant , Marcel Apfelbaum , Anthony Perard , "Michael S. Tsirkin" , Paolo Bonzini , Eduardo Habkost , Chuck Zmudzinski , Thomas Huth References: <20230104144437.27479-1-shentey@gmail.com> <20230104144437.27479-7-shentey@gmail.com> <1c2e0780-e5fb-1321-0d84-b0591db9fec7@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 6/1/23 12:57, Bernhard Beschow wrote: > > > Am 4. Januar 2023 15:35:33 UTC schrieb "Philippe Mathieu-Daudé" : >> +Markus/Thomas >> >> On 4/1/23 15:44, Bernhard Beschow wrote: >>> During the last patches, TYPE_PIIX3_XEN_DEVICE turned into a clone of >>> TYPE_PIIX3_DEVICE. Remove this redundancy. >>> >>> Signed-off-by: Bernhard Beschow >>> --- >>> hw/i386/pc_piix.c | 4 +--- >>> hw/isa/piix.c | 20 -------------------- >>> include/hw/southbridge/piix.h | 1 - >>> 3 files changed, 1 insertion(+), 24 deletions(-) >>> -static void piix3_xen_class_init(ObjectClass *klass, void *data) >>> -{ >>> - DeviceClass *dc = DEVICE_CLASS(klass); >>> - PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); >>> - >>> - k->realize = piix3_realize; >>> - /* 82371SB PIIX3 PCI-to-ISA bridge (Step A1) */ >>> - k->device_id = PCI_DEVICE_ID_INTEL_82371SB_0; >>> - dc->vmsd = &vmstate_piix3; >> >> IIUC, since this device is user-creatable, we can't simply remove it >> without going thru the deprecation process. > > AFAICS this device is actually not user-creatable since dc->user_creatable is set to false once in the base class. I think it is safe to remove the Xen class unless there are ABI issues. Great news! From xen-devel-bounces@lists.xenproject.org Fri Jan 06 12:41:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 12:41:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472516.732748 (Exim 4.92) (envelope-from ) id 1pDm21-0006e9-Sr; Fri, 06 Jan 2023 12:41:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472516.732748; Fri, 06 Jan 2023 12:41:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDm21-0006e2-Pd; Fri, 06 Jan 2023 12:41:09 +0000 Received: by outflank-mailman (input) for mailman id 472516; Fri, 06 Jan 2023 12:41:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDm20-0006dq-Iq; Fri, 06 Jan 2023 12:41:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDm20-0006jO-Dj; Fri, 06 Jan 2023 12:41:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDm20-0003dC-3C; Fri, 06 Jan 2023 12:41:08 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pDm20-0004LS-2n; Fri, 06 Jan 2023 12:41:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=rdmeO4nQZw8Y7+7nm1vDwBhfMiwnUXBXQ98V3RiimaY=; b=T/k6eQ3zZ2RzVFgm03ssMFhVc3 t6Q0g9gCh6amDOGxRElcRmlLXWCH4c2fXBTOymtfoycZzVbokW0kBnv6RO8RO1GYw6wzeAYOegEEG L0XUT9FH2iCJcshIx1AzfekcpstHilxHExiMYG19cBVtkflAYbrk8ozOpbr/Pdz/N1xM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 175602: all pass - PUSHED X-Osstest-Versions-This: ovmf=0aca5901e34489573c4e9558729704f76869e3d0 X-Osstest-Versions-That: ovmf=8c2357809e2c352c8ba7c35ab50f49deefd3d39e From: osstest service owner Date: Fri, 06 Jan 2023 12:41:08 +0000 flight 175602 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/175602/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 0aca5901e34489573c4e9558729704f76869e3d0 baseline version: ovmf 8c2357809e2c352c8ba7c35ab50f49deefd3d39e Last test of basis 175598 2023-01-06 05:40:43 Z 0 days Testing same since 175602 2023-01-06 08:41:27 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Gerd Hoffmann Laszlo Ersek jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 8c2357809e..0aca5901e3 0aca5901e34489573c4e9558729704f76869e3d0 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Jan 06 12:41:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 12:41:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472520.732758 (Exim 4.92) (envelope-from ) id 1pDm2N-00075z-8K; Fri, 06 Jan 2023 12:41:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472520.732758; Fri, 06 Jan 2023 12:41:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDm2N-00075s-5O; Fri, 06 Jan 2023 12:41:31 +0000 Received: by outflank-mailman (input) for mailman id 472520; Fri, 06 Jan 2023 12:41:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDm2L-0006zY-TI for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 12:41:30 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2055.outbound.protection.outlook.com [40.107.6.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6feb620b-8dbf-11ed-b8d0-410ff93cb8f0; Fri, 06 Jan 2023 13:41:27 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8189.eurprd04.prod.outlook.com (2603:10a6:102:1c2::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Fri, 6 Jan 2023 12:41:26 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5944.019; Fri, 6 Jan 2023 12:41:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6feb620b-8dbf-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PDNeCI/9Mcs81yqa3FuUlVsUYVD52x2KheC+ryWkejk5FWbe2QJXhiNuHMP+5lZKGFxpCbDSs06f42g49OtV1nsgc4VxPzTiFNV2+aoxy924hRiC8xDTh5I3dSHbF5mx+KAhRdnsHn0CRzwMzfitba474IWEq5BK0f2rtYfswBXjwAd7B6qMTj+1FNAF4mgn4V7TjpRuGnMDF11uvjRm1/wQE9lDv14xm6g0RsRD11B7Y+Ld5ttqs2KUwHjg/4g38UN2Y0SBgtCDGVzrzOqSJzQCXEbHWEfhBPaiy8oMqa6olzR1lHo4APVmkNAZJxpZL+W0Zm5bYydKsJlTIYbYVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5LiZnKW8QO/RyfEYputoxeS3/lQZ5Rzk4LEiCHSD+Nw=; b=BS6l6sbeOxfrMss4I86APMahar1ul34O/9rSkBVzRnk+6S+5L57ojEMiftV0/VPWIKf1NsF7bhDvDz5pXMMf+sz2E3gzBuKbX7nrSVVlm/2M0Mz8Ynrum0G5bUERsIOnpJ+eJWJ1z13vrQrPccFDeS6jnj8J0mWYZ/5ssSSph1vc3O/1O128EH6KV6JeTNqcjoeUiUkfqJp2m9E9Czr3BlB/4hS9NWMVzl32mPD7jBb6oTzllOj0iGZxpZJeawPl97LmKlOc6T8DZ41/dPhWsAPlKw8XiSzfVINThvVR4Y6hY0ZTGdr8ksW9NrTexKZznKESBpAsHiPZSK10+qz1ew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5LiZnKW8QO/RyfEYputoxeS3/lQZ5Rzk4LEiCHSD+Nw=; b=TdEeQrYUKHZSuLkvJovCcc3YzL0ZsVYwcu9ghYSvYoaD2bMA4WKOlaXaVWysc3U4tV+J8YAUTuAmWdDk+P4188H23DIFwDCYHaIluwNObuiwu32v28IPSHnVXuBJsE5X3H3HnA7iKFR6LVgnrhRq4RWX8z47dkYbP3ZY74niQmkkO3U8L+6pqWxbOULscXo1NVV+FZUMcjr/rnf3rMO1u1l89ZVq/TJb+WvI/pyNJ8NvvPN6YAyGUlPxJpYM7XpM5gpMYtYnK+o1+7ZUefL3UYOFd407bC8Rt5e/j0ztpNPeYGV7y9QvGWOYgim4R86AuAf9V/Q2UAlM/28t9a8ZUQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <8aa0a1a9-b69a-c201-e5de-0bd5ae6318d6@suse.com> Date: Fri, 6 Jan 2023 13:41:24 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] x86/S3: Restore Xen's MSR_PAT value on S3 resume Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , Demi Marie Obenour , Xen-devel References: <20230105204839.3676-1-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20230105204839.3676-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0191.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a4::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8189:EE_ X-MS-Office365-Filtering-Correlation-Id: f4dad9d1-ec64-43b8-a9e4-08daefe35359 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +VrNfjV8SeVJn8b0cG+NfPTVcj63RBb75aR/KNd0pIVGt7ap7m4ue/yLVaYfp7dWO52i+g+VCLqIMMeE4nGeL6sBcehv0o648yqxBJOdRvFTlvJVs7hY9gHdkFoqku4vVALM19RHjZoFDyNBrh46I1wpIe9FA1pPo+3L7A5u3alSVnI4QKNtjJ1uOPVQb0R/yY/KdyZLfM8GXMZbCIDuPeKuPOCegewdiV61jwxLNRI43p44KrTVjJiEl20+KPs+eCZcirlToSd4OdknGhpSffwP22Xuuvcb9XJb/yUR1dd2EtecA+/qFO085YTlZmKoKScBqCjIz0SA/7lxJXNcdQl6T+ssgPJRaPknfj7Sct/008ZaBbT5GHht5VcPMsyTWwOwTXbmG9EmbsBYgBqeOAF2QxjX2V1noFbOOmgq0qGONj2vAQKNIUZaUHUVnTaZBE35Cbmj6Y4xY60Oa5cnZIRg5U8gvJfN2lj0KdpVnEXxIF2fnR79BJd0z3tR6WejMSGIk/WtfB/BZ2IA1uhxHyOQ2dPBdnhP7w2vV+mZ4kdoJbJhKibIOfqNMRG8OGLk07VwEX/aew0Czvx+A9QdVgpZCWh4sTwJX9/PfDljkWNm0Z1HNYAws2BanL5/yiCSR/ESdxP2fB2gFHmfOozBjNOouoSIRCgATMdg9azkMYmQouMQ1qtnlxg8OwEWHJsLVGDkcuvYP8Xm9M+MGqAveZjff4TWpYftkS3gehHH/1E= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(136003)(376002)(39860400002)(366004)(396003)(451199015)(2616005)(83380400001)(4326008)(8936002)(86362001)(38100700002)(36756003)(66946007)(66556008)(316002)(66476007)(2906002)(6916009)(54906003)(4744005)(186003)(6512007)(31686004)(5660300002)(53546011)(6506007)(8676002)(26005)(31696002)(41300700001)(6486002)(478600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Ym1GbmwvUEpnQjRsUVNSdHVZYmUzVkpUbUVtSjZHZlRQYTBiLzBWSWZFcHRF?= =?utf-8?B?UXB1dXMzVmxrZjBQMTZrbWVRWXBjQ3pseVZ4Vm9CZWNlbndETTBIR2pFTEFl?= =?utf-8?B?aHB5Y0NCVGYxdm1RSklobUZER01zU1FqdDV5RUI2M2llTS91elh6WkNLcEJB?= =?utf-8?B?Q2NFQ2tGZTlvS2ZBaUJLNlptWjg4cUNlS3l0VkdvdGFmMjJDU042NVZTTkwx?= =?utf-8?B?a09OVG1WZE13aHFOMnBZaFhXQnFYM3ZaYlRoWGRtZlZOWk5MTHhxajZyUlpt?= =?utf-8?B?b2VXUnJkdEFZWkxLeWFOY0lRTTR3L1ZXaVF6YzlTWHJBT01pN0lUV3pTMFkx?= =?utf-8?B?NEYzNTBqcWxXaXNYYzFRZGwzZXV6Vys0S0s5WSs4NG1HK0Jmb0ExejdDVkRr?= =?utf-8?B?L1poVjBNeWtvWUcwMS9TdFVqZXhBVHpHNGQxU0duTVVQYk10cFY5TjZLLzBX?= =?utf-8?B?QUluVTNaREMxS0NPMlFRM1FZVWl2cXpDa0lKdFZiL1Y1cnRGckw2WGdTenVN?= =?utf-8?B?cStMZWsxTW5hWUpRQ1F0d1hXcEFMeGN5eUJMbjRWSzZDMTB6U0kxa1VOTDcr?= =?utf-8?B?enhvRkNQR2xqN2o3MUQ0S042Y1NEYzRpbUlselBjQ1hvRThTVS9ORGg2dUxH?= =?utf-8?B?WDVmS24zRjVkV2tVczdwM2ZjMXpBQzcwQVNkOE9Hc1czbVVaWUM3VklJUGxv?= =?utf-8?B?MEJ3cjkydjFUWWFxUGxSSUVtdUJsMGFab2s0NDdldy84QXVSYjdLWlZFV0RX?= =?utf-8?B?TU82a2xoM1A1bTJKam5HbFp6Tzd6Ry96ZlFwME9JcjVrZkhEa0R2WWNmdUsw?= =?utf-8?B?OEpXMlFza0RkK0g5eDJsaUhJWGpOcW1OdFNyS2huOGtWQjBxdm8xWTFqSmhi?= =?utf-8?B?WXF1dUNPQVNPWks0YTRNcW8zQUZ1dTZBcGRBSnBTRThWVHZJTDRGUE1VdG9G?= =?utf-8?B?b0VoUmV1bEtMaC9EUnhVd1pFVU1DYmsvY0l2U1pEdGROKzlrdSt4dmVUbkl3?= =?utf-8?B?MmMySC9ZUythaktscVFuMnNuQU5rdWFzZ2VmU2hNbGxNa2plWFdtQVVXd3FU?= =?utf-8?B?VUVPYUlyd2tlZUlDUmM3aWp3Z0JDNkxQcHl3OFJYd3F1dENCanhEY1UwSEZr?= =?utf-8?B?ckR6SStlekdoemhuczE4MHQ3U2RmQmFhdktnTkpDOGhPNjRDZ01JQXlOUlFY?= =?utf-8?B?WEx5eDdLL1pMTEMxNnRna1N5eEI1SzBLUjI4Z2syM1FBc3JiWVMxaEJLb3Az?= =?utf-8?B?cW1ianFwcC9MekphZ3JMWE1zTWxuRTFjZG13WkU2dHc2MUVhQ0hmZTllM3NB?= =?utf-8?B?aE50TnkwcmcranBkVmdDWCttZ2N2MlA0Nm4rSU81L29VYVAvNm00WXZ4NTV2?= =?utf-8?B?VStYK3k2RTV6V1V4VmRTY1JTM0hBYy9KQ2dZSS9Sdi9LSEt0VUxCK2hCT0tY?= =?utf-8?B?YmVheldDcnNOb2pKY3piTmFqd3BUSTR5L1hwSVZpRHV0ZXI0bTl3QXJadUFp?= =?utf-8?B?VHVldzdiRDdZMUV0ellWdERwU1JvdXhQaGVOMnpyemFoZ1ljNmdaNEg2OU82?= =?utf-8?B?cEcyS1ZjeVE2aEZoRHh2OENObDVBMXE5VHIraW0wUXFPZ2ViV1VxN2xCVWlX?= =?utf-8?B?MzNmbkhMVzh3Z1ljQmFEL3JjRFJjUXRhWnpVSjFub2p5YnlvV0hRanVuM3RB?= =?utf-8?B?MEIvRXUzeWh6R1VJY3A1VVJHNFVxS0ZuRVpoRGZ2Mi9IMzFDNnlYZkR5MDI2?= =?utf-8?B?ckZlQ3R3N1YyaTNSeUFhVTBDK0hOYUwyVzJLaVdySzd5dWVzREdXWEl2cldT?= =?utf-8?B?SG44cHI0WUNydSt5K1ZydDNUTTlpdjlJNlg2b1NTSnZpby80eFdEbWp1Mngy?= =?utf-8?B?TU1IUlNLZFV4QlRnV1lGbWhqb1Zncno2RVZRUEdJdU1iMUR6eHZqcTJIZGZT?= =?utf-8?B?cUhpUTl2THpOTW5wRitpbFJTcXpqeXhBbFNsNkFiOHU5cUszY0M4WkIrNDFy?= =?utf-8?B?M3NOT3l3SXNEZXFTOUV1QlJBUDhHUjRsaXVhTEpwZmE2eXVReWE2c0RSQVMr?= =?utf-8?B?M0dBemNVdzE1Sm5aM2YybnRXcGljUXN5aFlwVzRPM3BEZnBLZUZMZGhsaWM3?= =?utf-8?Q?+DmvzRF0BIaHhVFqfhIslTdM6?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f4dad9d1-ec64-43b8-a9e4-08daefe35359 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2023 12:41:26.3064 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9NQCFnaSVvFpcK/XOnwg/IvV+A4N+xkEGshuGKuZVQb0BPPZWFg0pnua/V7Ier12WAg2GZWeOUbNgP2b3RHeNw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8189 On 05.01.2023 21:48, Andrew Cooper wrote: > There are two paths in the trampoline, and Xen's PAT needs setting up in both, > not just the boot path. > > Fixes: 4304ff420e51 ("x86/S3: Drop {save,restore}_rest_processor_state() completely") > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Fri Jan 06 13:00:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 13:00:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472533.732770 (Exim 4.92) (envelope-from ) id 1pDmKh-0001NM-Rj; Fri, 06 Jan 2023 13:00:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472533.732770; Fri, 06 Jan 2023 13:00:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDmKh-0001NF-Om; Fri, 06 Jan 2023 13:00:27 +0000 Received: by outflank-mailman (input) for mailman id 472533; Fri, 06 Jan 2023 13:00:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDmKf-0001N3-Qj for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 13:00:26 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 136ee7d5-8dc2-11ed-b8d0-410ff93cb8f0; Fri, 06 Jan 2023 14:00:21 +0100 (CET) Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-617-kMSRisufPmahaEwqqtJ8Dg-1; Fri, 06 Jan 2023 08:00:19 -0500 Received: by mail-wm1-f69.google.com with SMTP id g9-20020a7bc4c9000000b003d214cffa4eso456142wmk.5 for ; Fri, 06 Jan 2023 05:00:19 -0800 (PST) Received: from redhat.com ([2.52.141.223]) by smtp.gmail.com with ESMTPSA id bi22-20020a05600c3d9600b003d208eb17ecsm1610633wmb.26.2023.01.06.05.00.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jan 2023 05:00:16 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 136ee7d5-8dc2-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673010020; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sR6um4BbjBj20kfzemMVQ0ZkaqRAHLWQBhrjILhwaG4=; b=Wev9ieiR3/r7UN/G8a9B/RCHMNbUe/KDb9um403EEkBlHBdpW+Ncg0qPEnUrX4+xVhouiV 83z7vIqBlhHAScWt++zgCbD0kT2btbLtYgYKvC2zW6Ivjayr2wjARctgubBJS06jHwW1Ha fv9Ncrg31pFhsrzIWgS/Un/9F/WedrE= X-MC-Unique: kMSRisufPmahaEwqqtJ8Dg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sR6um4BbjBj20kfzemMVQ0ZkaqRAHLWQBhrjILhwaG4=; b=uEktCH0vDhq+6J9b4C2rD0JEZ4viCVjh3nzPLO8xYjDb+DJiKl6xptZetBWrLpGO/i qShmvcy8QyjeEcfh7+azMRTkXKVm9Nltlpnq32qOGL+lKFt3jAIlY/OFkbfqPK9M3uNq BCIHFJUO2QysHcG6HXS98mjaOe4bCvtehMZRpTzdeJlAW6BoovXBKURqrD0JsoICeJlQ fwbbIQXjPDT4xRx7ZWvmKnXXIESYmCpj2ZWQ8c5fgfzxW4MuHJOdIMLjZDfmfMXf0e9K K6QH4RlkerTkkyRyPk5LpFUVG3DZk1PtjocTtovAXjQ2xDmf8T9xdPDG/LZaldC9fZF9 Iebw== X-Gm-Message-State: AFqh2kr50khKCsY00F8U0qkS7wevTBYVf/y6R8f49qifQaOUABzaz6+J MPmyAbGKxDT/9TlBuSGh9uwjU04agqmcEKD55ZJj9qumu86BY+l2jYRq0LdeIfjyI4v2dZJt/NO jgSGenkWz7H8GGXNX5q1p2ellLEk= X-Received: by 2002:a05:600c:4d25:b0:3d3:5b7a:1791 with SMTP id u37-20020a05600c4d2500b003d35b7a1791mr48498783wmp.41.1673010018146; Fri, 06 Jan 2023 05:00:18 -0800 (PST) X-Google-Smtp-Source: AMrXdXuk957aN9qRhSS4mlPMbpT2Ktb2g/2MsJT1cShsyRoFBbX7cRz0ybSLDVX1tt7CCv5iHeOHqA== X-Received: by 2002:a05:600c:4d25:b0:3d3:5b7a:1791 with SMTP id u37-20020a05600c4d2500b003d35b7a1791mr48498757wmp.41.1673010017758; Fri, 06 Jan 2023 05:00:17 -0800 (PST) Date: Fri, 6 Jan 2023 08:00:13 -0500 From: "Michael S. Tsirkin" To: Chuck Zmudzinski Cc: qemu-devel@nongnu.org, Stefano Stabellini , Anthony Perard , Paul Durrant , Paolo Bonzini , Richard Henderson , Eduardo Habkost , Marcel Apfelbaum , xen-devel@lists.xenproject.org Subject: Re: [PATCH v6] xen/pt: reserve PCI slot 2 for Intel igd-passthru Message-ID: <20230106064838-mutt-send-email-mst@kernel.org> References: <830263507e8f1a24a94f81909d5102c4b204e938.1672615492.git.brchuckz.ref@aol.com> <830263507e8f1a24a94f81909d5102c4b204e938.1672615492.git.brchuckz@aol.com> MIME-Version: 1.0 In-Reply-To: <830263507e8f1a24a94f81909d5102c4b204e938.1672615492.git.brchuckz@aol.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Jan 01, 2023 at 06:52:03PM -0500, Chuck Zmudzinski wrote: > Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, > as noted in docs/igd-assign.txt in the Qemu source code. > > Currently, when the xl toolstack is used to configure a Xen HVM guest with > Intel IGD passthrough to the guest with the Qemu upstream device model, > a Qemu emulated PCI device will occupy slot 2 and the Intel IGD will occupy > a different slot. This problem often prevents the guest from booting. > > The only available workaround is not good: Configure Xen HVM guests to use > the old and no longer maintained Qemu traditional device model available > from xenbits.xen.org which does reserve slot 2 for the Intel IGD. > > To implement this feature in the Qemu upstream device model for Xen HVM > guests, introduce the following new functions, types, and macros: > > * XEN_PT_DEVICE_CLASS declaration, based on the existing TYPE_XEN_PT_DEVICE > * XEN_PT_DEVICE_GET_CLASS macro helper function for XEN_PT_DEVICE_CLASS > * typedef XenPTQdevRealize function pointer > * XEN_PCI_IGD_SLOT_MASK, the value of slot_reserved_mask to reserve slot 2 > * xen_igd_reserve_slot and xen_igd_clear_slot functions > > The new xen_igd_reserve_slot function uses the existing slot_reserved_mask > member of PCIBus to reserve PCI slot 2 for Xen HVM guests configured using > the xl toolstack with the gfx_passthru option enabled, which sets the > igd-passthru=on option to Qemu for the Xen HVM machine type. > > The new xen_igd_reserve_slot function also needs to be implemented in > hw/xen/xen_pt_stub.c to prevent FTBFS during the link stage for the case > when Qemu is configured with --enable-xen and --disable-xen-pci-passthrough, > in which case it does nothing. > > The new xen_igd_clear_slot function overrides qdev->realize of the parent > PCI device class to enable the Intel IGD to occupy slot 2 on the PCI bus > since slot 2 was reserved by xen_igd_reserve_slot when the PCI bus was > created in hw/i386/pc_piix.c for the case when igd-passthru=on. > > Move the call to xen_host_pci_device_get, and the associated error > handling, from xen_pt_realize to the new xen_igd_clear_slot function to > initialize the device class and vendor values which enables the checks for > the Intel IGD to succeed. The verification that the host device is an > Intel IGD to be passed through is done by checking the domain, bus, slot, > and function values as well as by checking that gfx_passthru is enabled, > the device class is VGA, and the device vendor in Intel. > > Signed-off-by: Chuck Zmudzinski If we are to make changes, something that might be generally useful is a new mask along the lines of slot_reserved_mask, however - only affecting auto-allocated addresses - controllable from a command line property this way one could say "don't allocate any devices to slot 2" and later "put igd device in slot 2". And, xenpv machine could set defaults for these using the compat machinery. > --- > Notes that might be helpful to reviewers of patched code in hw/xen: > > The new functions and types are based on recommendations from Qemu docs: > https://qemu.readthedocs.io/en/latest/devel/qom.html > > Notes that might be helpful to reviewers of patched code in hw/i386: > > The small patch to hw/i386/pc_piix.c is protected by CONFIG_XEN so it does > not affect builds that do not have CONFIG_XEN defined. > > xen_igd_gfx_pt_enabled() in the patched hw/i386/pc_piix.c file is an > existing function that is only true when Qemu is built with > xen-pci-passthrough enabled and the administrator has configured the Xen > HVM guest with Qemu's igd-passthru=on option. > > v2: Remove From: tag at top of commit message > > v3: Changed the test for the Intel IGD in xen_igd_clear_slot: > > if (is_igd_vga_passthrough(&s->real_device) && > (s->real_device.vendor_id == PCI_VENDOR_ID_INTEL)) { > > is changed to > > if (xen_igd_gfx_pt_enabled() && (s->hostaddr.slot == 2) > && (s->hostaddr.function == 0)) { > > I hoped that I could use the test in v2, since it matches the > other tests for the Intel IGD in Qemu and Xen, but those tests > do not work because the necessary data structures are not set with > their values yet. So instead use the test that the administrator > has enabled gfx_passthru and the device address on the host is > 02.0. This test does detect the Intel IGD correctly. > > v4: Use brchuckz@aol.com instead of brchuckz@netscape.net for the author's > email address to match the address used by the same author in commits > be9c61da and c0e86b76 > > Change variable for XEN_PT_DEVICE_CLASS: xptc changed to xpdc > > v5: The patch of xen_pt.c was re-worked to allow a more consistent test > for the Intel IGD that uses the same criteria as in other places. > This involved moving the call to xen_host_pci_device_get from > xen_pt_realize to xen_igd_clear_slot and updating the checks for the > Intel IGD in xen_igd_clear_slot: > > if (xen_igd_gfx_pt_enabled() && (s->hostaddr.slot == 2) > && (s->hostaddr.function == 0)) { > > is changed to > > if (is_igd_vga_passthrough(&s->real_device) && > s->real_device.domain == 0 && s->real_device.bus == 0 && > s->real_device.dev == 2 && s->real_device.func == 0 && > s->real_device.vendor_id == PCI_VENDOR_ID_INTEL) { > > Added an explanation for the move of xen_host_pci_device_get from > xen_pt_realize to xen_igd_clear_slot to the commit message. > > Rebase. > > v6: Fix logging by removing these lines from the move from xen_pt_realize > to xen_igd_clear_slot that was done in v5: > > XEN_PT_LOG(d, "Assigning real physical device %02x:%02x.%d" > " to devfn 0x%x\n", > s->hostaddr.bus, s->hostaddr.slot, s->hostaddr.function, > s->dev.devfn); > > This log needs to be in xen_pt_realize because s->dev.devfn is not > set yet in xen_igd_clear_slot. > > Sorry for the extra noise. > > hw/i386/pc_piix.c | 3 +++ > hw/xen/xen_pt.c | 46 +++++++++++++++++++++++++++++++++++--------- > hw/xen/xen_pt.h | 16 +++++++++++++++ > hw/xen/xen_pt_stub.c | 4 ++++ > 4 files changed, 60 insertions(+), 9 deletions(-) > > diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c > index b48047f50c..bc5efa4f59 100644 > --- a/hw/i386/pc_piix.c > +++ b/hw/i386/pc_piix.c > @@ -405,6 +405,9 @@ static void pc_xen_hvm_init(MachineState *machine) > } > > pc_xen_hvm_init_pci(machine); > + if (xen_igd_gfx_pt_enabled()) { > + xen_igd_reserve_slot(pcms->bus); > + } > pci_create_simple(pcms->bus, -1, "xen-platform"); > } > #endif > diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c > index 0ec7e52183..7fae1e7a6f 100644 > --- a/hw/xen/xen_pt.c > +++ b/hw/xen/xen_pt.c > @@ -780,15 +780,6 @@ static void xen_pt_realize(PCIDevice *d, Error **errp) > s->hostaddr.bus, s->hostaddr.slot, s->hostaddr.function, > s->dev.devfn); > > - xen_host_pci_device_get(&s->real_device, > - s->hostaddr.domain, s->hostaddr.bus, > - s->hostaddr.slot, s->hostaddr.function, > - errp); > - if (*errp) { > - error_append_hint(errp, "Failed to \"open\" the real pci device"); > - return; > - } > - > s->is_virtfn = s->real_device.is_virtfn; > if (s->is_virtfn) { > XEN_PT_LOG(d, "%04x:%02x:%02x.%d is a SR-IOV Virtual Function\n", > @@ -950,11 +941,47 @@ static void xen_pci_passthrough_instance_init(Object *obj) > PCI_DEVICE(obj)->cap_present |= QEMU_PCI_CAP_EXPRESS; > } > > +void xen_igd_reserve_slot(PCIBus *pci_bus) > +{ > + XEN_PT_LOG(0, "Reserving PCI slot 2 for IGD\n"); > + pci_bus->slot_reserved_mask |= XEN_PCI_IGD_SLOT_MASK; > +} > + > +static void xen_igd_clear_slot(DeviceState *qdev, Error **errp) > +{ > + ERRP_GUARD(); > + PCIDevice *pci_dev = (PCIDevice *)qdev; > + XenPCIPassthroughState *s = XEN_PT_DEVICE(pci_dev); > + XenPTDeviceClass *xpdc = XEN_PT_DEVICE_GET_CLASS(s); > + PCIBus *pci_bus = pci_get_bus(pci_dev); > + > + xen_host_pci_device_get(&s->real_device, > + s->hostaddr.domain, s->hostaddr.bus, > + s->hostaddr.slot, s->hostaddr.function, > + errp); > + if (*errp) { > + error_append_hint(errp, "Failed to \"open\" the real pci device"); > + return; > + } > + > + if (is_igd_vga_passthrough(&s->real_device) && > + s->real_device.domain == 0 && s->real_device.bus == 0 && > + s->real_device.dev == 2 && s->real_device.func == 0 && > + s->real_device.vendor_id == PCI_VENDOR_ID_INTEL) { > + pci_bus->slot_reserved_mask &= ~XEN_PCI_IGD_SLOT_MASK; > + XEN_PT_LOG(pci_dev, "Intel IGD found, using slot 2\n"); > + } > + xpdc->pci_qdev_realize(qdev, errp); > +} > + > static void xen_pci_passthrough_class_init(ObjectClass *klass, void *data) > { > DeviceClass *dc = DEVICE_CLASS(klass); > PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); > > + XenPTDeviceClass *xpdc = XEN_PT_DEVICE_CLASS(klass); > + xpdc->pci_qdev_realize = dc->realize; > + dc->realize = xen_igd_clear_slot; > k->realize = xen_pt_realize; > k->exit = xen_pt_unregister_device; > k->config_read = xen_pt_pci_read_config; > @@ -977,6 +1004,7 @@ static const TypeInfo xen_pci_passthrough_info = { > .instance_size = sizeof(XenPCIPassthroughState), > .instance_finalize = xen_pci_passthrough_finalize, > .class_init = xen_pci_passthrough_class_init, > + .class_size = sizeof(XenPTDeviceClass), > .instance_init = xen_pci_passthrough_instance_init, > .interfaces = (InterfaceInfo[]) { > { INTERFACE_CONVENTIONAL_PCI_DEVICE }, > diff --git a/hw/xen/xen_pt.h b/hw/xen/xen_pt.h > index e7c4316a7d..40b31b5263 100644 > --- a/hw/xen/xen_pt.h > +++ b/hw/xen/xen_pt.h > @@ -3,6 +3,7 @@ > > #include "hw/xen/xen_common.h" > #include "hw/pci/pci.h" > +#include "hw/pci/pci_bus.h" > #include "xen-host-pci-device.h" > #include "qom/object.h" > > @@ -41,7 +42,20 @@ typedef struct XenPTReg XenPTReg; > #define TYPE_XEN_PT_DEVICE "xen-pci-passthrough" > OBJECT_DECLARE_SIMPLE_TYPE(XenPCIPassthroughState, XEN_PT_DEVICE) > > +#define XEN_PT_DEVICE_CLASS(klass) \ > + OBJECT_CLASS_CHECK(XenPTDeviceClass, klass, TYPE_XEN_PT_DEVICE) > +#define XEN_PT_DEVICE_GET_CLASS(obj) \ > + OBJECT_GET_CLASS(XenPTDeviceClass, obj, TYPE_XEN_PT_DEVICE) > + > +typedef void (*XenPTQdevRealize)(DeviceState *qdev, Error **errp); > + > +typedef struct XenPTDeviceClass { > + PCIDeviceClass parent_class; > + XenPTQdevRealize pci_qdev_realize; > +} XenPTDeviceClass; > + > uint32_t igd_read_opregion(XenPCIPassthroughState *s); > +void xen_igd_reserve_slot(PCIBus *pci_bus); > void igd_write_opregion(XenPCIPassthroughState *s, uint32_t val); > void xen_igd_passthrough_isa_bridge_create(XenPCIPassthroughState *s, > XenHostPCIDevice *dev); > @@ -76,6 +90,8 @@ typedef int (*xen_pt_conf_byte_read) > > #define XEN_PCI_INTEL_OPREGION 0xfc > > +#define XEN_PCI_IGD_SLOT_MASK 0x4UL /* Intel IGD slot_reserved_mask */ > + > typedef enum { > XEN_PT_GRP_TYPE_HARDWIRED = 0, /* 0 Hardwired reg group */ > XEN_PT_GRP_TYPE_EMU, /* emul reg group */ > diff --git a/hw/xen/xen_pt_stub.c b/hw/xen/xen_pt_stub.c > index 2d8cac8d54..5c108446a8 100644 > --- a/hw/xen/xen_pt_stub.c > +++ b/hw/xen/xen_pt_stub.c > @@ -20,3 +20,7 @@ void xen_igd_gfx_pt_set(bool value, Error **errp) > error_setg(errp, "Xen PCI passthrough support not built in"); > } > } > + > +void xen_igd_reserve_slot(PCIBus *pci_bus) > +{ > +} > -- > 2.39.0 From xen-devel-bounces@lists.xenproject.org Fri Jan 06 13:14:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 13:14:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472543.732815 (Exim 4.92) (envelope-from ) id 1pDmYX-0003kP-4n; Fri, 06 Jan 2023 13:14:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472543.732815; Fri, 06 Jan 2023 13:14:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDmYW-0003kH-VJ; Fri, 06 Jan 2023 13:14:44 +0000 Received: by outflank-mailman (input) for mailman id 472543; Fri, 06 Jan 2023 13:14:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDmYV-0002z5-E9 for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 13:14:43 +0000 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [2a00:1450:4864:20::12f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 154670af-8dc4-11ed-91b6-6bf2151ebd3b; Fri, 06 Jan 2023 14:14:42 +0100 (CET) Received: by mail-lf1-x12f.google.com with SMTP id cf42so1913857lfb.1 for ; Fri, 06 Jan 2023 05:14:42 -0800 (PST) Received: from fedora.. ([195.234.76.149]) by smtp.gmail.com with ESMTPSA id f14-20020a0565123b0e00b004b7033da2d7sm150221lfv.128.2023.01.06.05.14.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jan 2023 05:14:42 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 154670af-8dc4-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WNxlUh9Ka9jPjJlnMEMMefixCKNIhgCiXW1ZWCXQV/k=; b=Cmp2WrBPADxtPoiKL4ZCWZjbwolz9CwJgGbJPD1rMDDiI4pZKxyKs8tIFpSVx7xZph Zcr/Wt6lvg3FkgxLGPbYrF4RjLh+MGPOl10al8e9P5VIfsaWmG7qfqwCr0gDRlmbkAfz CO6Ru90aBDKMmqCyBvUnfKTZ59ad/qLzNaERvfFpq6tS0plPuFGbhtSTcZgJkNcphG7/ lPwDSreK1qoe1UVY5EEgEN8gA9fHaUCF8UDtd1r6OC2Dyo1tcmf6wdE+qUhpO9dKCZ/u AR6XI3Uh00paOLb9LVgKW81uqYPOwtEkeq9LK9r8uTmgKaMjbvQUwNO/eMCW375itLxT /Wmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WNxlUh9Ka9jPjJlnMEMMefixCKNIhgCiXW1ZWCXQV/k=; b=ujdg131bgkDNS3qAHK/yHdeARCfT6Gj+cHjplIlO4XNknz8yGVkhbyBx3HluqPEz1T /RJmQCwgxUVUDUZnYNwX0JW53//D1T/2E7QDUyDdU58ktV3XSrokah9aVxM19fxiq1rB uWCXBLK19ZmHoAs8V0zaxMfgpucQnkR6zBTgTFTt3XTh87d5cHnMrN1pYyuoQd5Okaap U4aQGT14qXm8yayUpL2kYv/b8LLT79qT7uYKfSOHwntgqzoR+OQr2j2CHN/ikZIHnDCy 6b/HMN+P2Tev0od2jf60jAGIS8aIe7uQvBiQmNgU+PXK4YkvcY6lAxoWlQ/FendQiOh1 B8Qw== X-Gm-Message-State: AFqh2kpRjTK+rKIz6o+3fwT73Gd5hIN9KMZWW2jQhsyZHkEQepBrLSj4 fu73Q2D9zyY9feCAmQ5OiKWGp5c9exjV3cpW X-Google-Smtp-Source: AMrXdXvor3i3sFq+rVboLeo1F3I7ZDy57MwxwjjT77+SwrslgXm0lEQNqBGQktwp9LJBw0V3e91aUw== X-Received: by 2002:ac2:4f13:0:b0:4b5:5da1:4bcb with SMTP id k19-20020ac24f13000000b004b55da14bcbmr20144859lfr.13.1673010882425; Fri, 06 Jan 2023 05:14:42 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH v1 3/8] xen/riscv: introduce stack stuff Date: Fri, 6 Jan 2023 15:14:24 +0200 Message-Id: X-Mailer: git-send-email 2.38.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The patch introduces and sets up a stack in order to go to C environment Signed-off-by: Oleksii Kurochko --- xen/arch/riscv/Makefile | 1 + xen/arch/riscv/riscv64/head.S | 8 +++++++- xen/arch/riscv/setup.c | 6 ++++++ 3 files changed, 14 insertions(+), 1 deletion(-) create mode 100644 xen/arch/riscv/setup.c diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile index 248f2cbb3e..5a67a3f493 100644 --- a/xen/arch/riscv/Makefile +++ b/xen/arch/riscv/Makefile @@ -1,4 +1,5 @@ obj-$(CONFIG_RISCV_64) += riscv64/ +obj-y += setup.o $(TARGET): $(TARGET)-syms $(OBJCOPY) -O binary -S $< $@ diff --git a/xen/arch/riscv/riscv64/head.S b/xen/arch/riscv/riscv64/head.S index 990edb70a0..ddc7104701 100644 --- a/xen/arch/riscv/riscv64/head.S +++ b/xen/arch/riscv/riscv64/head.S @@ -1,4 +1,10 @@ .section .text.header, "ax", %progbits ENTRY(start) - j start + la sp, cpu0_boot_stack + li t0, PAGE_SIZE + add sp, sp, t0 + +_start_hang: + wfi + j _start_hang diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c new file mode 100644 index 0000000000..2c7dca1daa --- /dev/null +++ b/xen/arch/riscv/setup.c @@ -0,0 +1,6 @@ +#include +#include + +/* Xen stack for bringing up the first CPU. */ +unsigned char __initdata cpu0_boot_stack[PAGE_SIZE] + __aligned(PAGE_SIZE); -- 2.38.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 06 13:14:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 13:14:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472540.732781 (Exim 4.92) (envelope-from ) id 1pDmYU-0002zN-3K; Fri, 06 Jan 2023 13:14:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472540.732781; Fri, 06 Jan 2023 13:14:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDmYU-0002zG-0e; Fri, 06 Jan 2023 13:14:42 +0000 Received: by outflank-mailman (input) for mailman id 472540; Fri, 06 Jan 2023 13:14:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDmYS-0002z5-LP for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 13:14:40 +0000 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [2a00:1450:4864:20::129]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 135808af-8dc4-11ed-91b6-6bf2151ebd3b; Fri, 06 Jan 2023 14:14:39 +0100 (CET) Received: by mail-lf1-x129.google.com with SMTP id v25so1862672lfe.12 for ; Fri, 06 Jan 2023 05:14:39 -0800 (PST) Received: from fedora.. ([195.234.76.149]) by smtp.gmail.com with ESMTPSA id f14-20020a0565123b0e00b004b7033da2d7sm150221lfv.128.2023.01.06.05.14.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jan 2023 05:14:38 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 135808af-8dc4-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=V2UtY1Vvt5nd0Ps36YR7BE9Io/IKMRHuA+OuD+Ua5WU=; b=dEJWA4OToBPY9VGTbfJnZSgsfvptCU7zIzTVaNvbPQvAhGXP//sNT8PPf5rOffTiix lXAXd7mf/86mUgdQkvmqhamNAjeOq1FD3iNRV9f++Z04hf0q23EIUyT1I/L9PfNvge9q Oo3LDiRXtRp13jPMCGtewMHfzqD4h4FwdCs0vIhSAjVIBrWqLG4HQslgfjlK5+IWh/J2 P07GZkxP+zJLNYMooHlcfnFw9KOAYhuCQOHtfrW6qsZKIQpnsLJNqeE/bO4N10lqSwoJ dgwK7cNnmmU32YaMINbQnnEFYk34QcObMVDHx/q7yFl+HxLV647YyNN1hy0u7DURGfgI P+Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=V2UtY1Vvt5nd0Ps36YR7BE9Io/IKMRHuA+OuD+Ua5WU=; b=GCrot8gdBjjbXAO1eTEc7y+FRWCmwGv30SFOaLDBnei0DRtjL5ObuHGBgr8eTDSzjM bg1q/9YcQB0zHSXyTGUDMpsooHbRMH864aYjPLH7kOqc7bgvD0ZJ5gXYXTb15EH+Jrkj KElkGypdf05ypVOF/nIDDQnDxT0HT3mQBCZW7YVbpHggGm7hYxQC6bJ+cpyeavbC2fEB WaFyVplspICmJYnWZWUT4edGFxrowmo9AKshxLsqMv5rv67JMEX4Lz4k7rGUMXv3B7Rn RkGdmOFaOnkC3w1JQqVLvIUVB6oHvWxdbB+kGrZaN3vUZEmQhPdOtWhesinsm4O/Bc7M utOA== X-Gm-Message-State: AFqh2kobqWUNjGN/fDQUWw2yUsKplvQXHitR+1/ZnErgOB1xJu0FhCvG XhY4cAWoU3bLnK4N6xwX1tqwc8S6H3k4MzOm X-Google-Smtp-Source: AMrXdXsDCwcZ3QWsZUvaCxQJXZp+bIW/488M3BCCgWqS4hkN/+qe2srwuDhBoHTrJvsHJovegdV3bg== X-Received: by 2002:a05:6512:31cc:b0:4b5:5caf:9d62 with SMTP id j12-20020a05651231cc00b004b55caf9d62mr17690302lfe.61.1673010878710; Fri, 06 Jan 2023 05:14:38 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis , George Dunlap , Jan Beulich , Julien Grall , Wei Liu , Doug Goldstein Subject: [PATCH v1 0/8] Basic early_printk and smoke test implementation Date: Fri, 6 Jan 2023 15:14:21 +0200 Message-Id: X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The patch series introduces the following: - the minimal set of headers and changes inside them. - SBI (RISC-V Supervisor Binary Interface) things necessary for basic early_printk implementation. - things needed to set up the stack. - early_printk() function to print only strings. - RISC-V smoke test which checks if "Hello from C env" message is present in serial.tmp Oleksii Kurochko (8): xen/riscv: introduce dummy asm/init.h xen/riscv: introduce asm/types.h header file xen/riscv: introduce stack stuff xen/riscv: introduce sbi call to putchar to console xen/include: include in xen/riscv: introduce early_printk basic stuff xen/riscv: print hello message from C env automation: add RISC-V smoke test automation/build/archlinux/riscv64.dockerfile | 3 +- automation/scripts/qemu-smoke-riscv64.sh | 20 +++++ xen/arch/riscv/Kconfig.debug | 7 ++ xen/arch/riscv/Makefile | 3 + xen/arch/riscv/early_printk.c | 27 +++++++ xen/arch/riscv/include/asm/early_printk.h | 12 +++ xen/arch/riscv/include/asm/init.h | 12 +++ xen/arch/riscv/include/asm/sbi.h | 34 +++++++++ xen/arch/riscv/include/asm/types.h | 73 +++++++++++++++++++ xen/arch/riscv/riscv64/head.S | 6 +- xen/arch/riscv/sbi.c | 44 +++++++++++ xen/arch/riscv/setup.c | 18 +++++ xen/include/xen/early_printk.h | 2 + 13 files changed, 259 insertions(+), 2 deletions(-) create mode 100755 automation/scripts/qemu-smoke-riscv64.sh create mode 100644 xen/arch/riscv/early_printk.c create mode 100644 xen/arch/riscv/include/asm/early_printk.h create mode 100644 xen/arch/riscv/include/asm/init.h create mode 100644 xen/arch/riscv/include/asm/sbi.h create mode 100644 xen/arch/riscv/include/asm/types.h create mode 100644 xen/arch/riscv/sbi.c create mode 100644 xen/arch/riscv/setup.c -- 2.38.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 06 13:14:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 13:14:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472542.732803 (Exim 4.92) (envelope-from ) id 1pDmYV-0003TR-Qd; Fri, 06 Jan 2023 13:14:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472542.732803; Fri, 06 Jan 2023 13:14:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDmYV-0003Sw-Kp; Fri, 06 Jan 2023 13:14:43 +0000 Received: by outflank-mailman (input) for mailman id 472542; Fri, 06 Jan 2023 13:14:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDmYU-0002z5-Dm for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 13:14:42 +0000 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [2a00:1450:4864:20::12f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 149870ba-8dc4-11ed-91b6-6bf2151ebd3b; Fri, 06 Jan 2023 14:14:41 +0100 (CET) Received: by mail-lf1-x12f.google.com with SMTP id cf42so1913806lfb.1 for ; Fri, 06 Jan 2023 05:14:41 -0800 (PST) Received: from fedora.. ([195.234.76.149]) by smtp.gmail.com with ESMTPSA id f14-20020a0565123b0e00b004b7033da2d7sm150221lfv.128.2023.01.06.05.14.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jan 2023 05:14:40 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 149870ba-8dc4-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MB3mP3saGY5zi4vniFjN+fb62F0tD8zzx/q/eV6PI4g=; b=dHhG0y7E8/G36jeTb3kkFqbhUorGTTD1mCXTlEOCv5nLd0t6yij8q6f2XhSvjbCHSz 4LzUKh/1RbdJJ7qgeiImwk3EztRh9oPbpX+iJqmQgCuJY2xHs3Jqb3giU9uM6FDa+cFP gutliizUf4Wg24ZwSqNd3yN/cKX5mUXHtkje923o2AaxnnfaLMYg/53aRm+WB7XV95bC 0ND1IglLWaPtvyWmqxjBvmnsy29uP6OkLA6ELEAiogGUwyvDU08UIx8tU6BBSVrsHKUk bOfrfqyRVJhfSD4VpvorITmB1PTLQxhnzj9KYF7wEyyyEBYF+qQXyj7s8YOnkkMMQZ1g 5ufQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MB3mP3saGY5zi4vniFjN+fb62F0tD8zzx/q/eV6PI4g=; b=H8EkbD5Bs3MyPAC5+0dBnv88GLV9kVuGS3+EXnaXKhG5Pgecjjb3x37di/aiUJNgBB rxDWUjO3Up91Nq49mLD5129Q0AVtnE+kzn8KkAjwOxTT6GlIvdVedEfbpCVRf/zRGpcT zk4eeBgrTqh+qHATHSEQbfxdl50tjvM1qS1rf40v8xG83jYcnogGZu1kx3ObenzkfOph VHc20MK5z+OsEemOL1rYr/1QYc9wCAIsPOsfruHPjtxX2RtifUrPriQZ7ur1jjn8Y19X 1hooJ0kr6kGSmpurlv2lffmnuzxwNtEIfezuQSLKrnKEL1vBTHW7tLQnPTHQd5+Rc/4V mJ2Q== X-Gm-Message-State: AFqh2kpCRf64iCbwrcO5crNNwEPYOFNnTun2nMD6SosStHjyz+yn4p7c ObeJvLWYrjtkfDYfkk021kmDFVDgaeMX0rv0 X-Google-Smtp-Source: AMrXdXtja92B/6NXyi/klzTpbEH82FEmrjFVVSWx/83yonduRUFATBxzf42E31lSTN70xqAB7n1C+w== X-Received: by 2002:a05:6512:1513:b0:4a4:a7d7:4769 with SMTP id bq19-20020a056512151300b004a4a7d74769mr17352068lfb.8.1673010881180; Fri, 06 Jan 2023 05:14:41 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH v1 2/8] xen/riscv: introduce asm/types.h header file Date: Fri, 6 Jan 2023 15:14:23 +0200 Message-Id: X-Mailer: git-send-email 2.38.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Signed-off-by: Oleksii Kurochko --- xen/arch/riscv/include/asm/types.h | 73 ++++++++++++++++++++++++++++++ 1 file changed, 73 insertions(+) create mode 100644 xen/arch/riscv/include/asm/types.h diff --git a/xen/arch/riscv/include/asm/types.h b/xen/arch/riscv/include/asm/types.h new file mode 100644 index 0000000000..48f27f97ba --- /dev/null +++ b/xen/arch/riscv/include/asm/types.h @@ -0,0 +1,73 @@ +#ifndef __RISCV_TYPES_H__ +#define __RISCV_TYPES_H__ + +#ifndef __ASSEMBLY__ + +typedef __signed__ char __s8; +typedef unsigned char __u8; + +typedef __signed__ short __s16; +typedef unsigned short __u16; + +typedef __signed__ int __s32; +typedef unsigned int __u32; + +#if defined(__GNUC__) && !defined(__STRICT_ANSI__) +#if defined(CONFIG_RISCV_32) +typedef __signed__ long long __s64; +typedef unsigned long long __u64; +#elif defined (CONFIG_RISCV_64) +typedef __signed__ long __s64; +typedef unsigned long __u64; +#endif +#endif + +typedef signed char s8; +typedef unsigned char u8; + +typedef signed short s16; +typedef unsigned short u16; + +typedef signed int s32; +typedef unsigned int u32; + +#if defined(CONFIG_RISCV_32) +typedef signed long long s64; +typedef unsigned long long u64; +typedef u32 vaddr_t; +#define PRIvaddr PRIx32 +typedef u64 paddr_t; +#define INVALID_PADDR (~0ULL) +#define PRIpaddr "016llx" +typedef u32 register_t; +#define PRIregister "x" +#elif defined (CONFIG_RISCV_64) +typedef signed long s64; +typedef unsigned long u64; +typedef u64 vaddr_t; +#define PRIvaddr PRIx64 +typedef u64 paddr_t; +#define INVALID_PADDR (~0UL) +#define PRIpaddr "016lx" +typedef u64 register_t; +#define PRIregister "lx" +#endif + +#if defined(__SIZE_TYPE__) +typedef __SIZE_TYPE__ size_t; +#else +typedef unsigned long size_t; +#endif +typedef signed long ssize_t; + +#endif /* __ASSEMBLY__ */ + +#endif /* __RISCV_TYPES_H__ */ +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ -- 2.38.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 06 13:14:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 13:14:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472541.732787 (Exim 4.92) (envelope-from ) id 1pDmYU-00035p-Hx; Fri, 06 Jan 2023 13:14:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472541.732787; Fri, 06 Jan 2023 13:14:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDmYU-00034D-CJ; Fri, 06 Jan 2023 13:14:42 +0000 Received: by outflank-mailman (input) for mailman id 472541; Fri, 06 Jan 2023 13:14:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDmYT-0002z5-Dm for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 13:14:41 +0000 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [2a00:1450:4864:20::136]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 13e4f564-8dc4-11ed-91b6-6bf2151ebd3b; Fri, 06 Jan 2023 14:14:40 +0100 (CET) Received: by mail-lf1-x136.google.com with SMTP id b3so1912398lfv.2 for ; Fri, 06 Jan 2023 05:14:40 -0800 (PST) Received: from fedora.. ([195.234.76.149]) by smtp.gmail.com with ESMTPSA id f14-20020a0565123b0e00b004b7033da2d7sm150221lfv.128.2023.01.06.05.14.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jan 2023 05:14:39 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 13e4f564-8dc4-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yAcYh/VW7eYXXl0R2jdwjlS37Qv+vZcW+kdMkmb+PS4=; b=IlrI0mSe81MehUEzGp9/MbqL/Pkl6vTOQkeNdnArj8JWWJejtDMyERVIbGWTZ3BpXm cdl2hGleDIcpJ8VKttf+B3DguD+ugtu1V5plc39rePhJu70fhf4HORtDXOluwNgzZFdF HPU35Kzhc/c0ITVRDRzHYzb+qkaLBq9q8fpq4gFPV6cVl8Ct3QcAV2Theof2IrBH4SHE 2KCh5GoBjbLvlq+IxEVb/ykaL0xTbyg+kX6ILflHPNKLfqeC9SXO2/19T6giQkNi91q5 vctCpEYEioJe8qs2XLEIUQyPX5+UPDs1eNsh6eCsx3C76Yk8+brLRJzm+IWy0S7DSxOW np5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yAcYh/VW7eYXXl0R2jdwjlS37Qv+vZcW+kdMkmb+PS4=; b=qvCxCB94RnvTv9Okv6riYgvGGcH3oOafz3lGhFCDqn7TIozOh5gDr7I40MmpHQKhtV UAnk7iFqkr8rGL9mX9w1ob7vVNhHpNIvN0yOFgaIBHfwfog6lbM8F5CodV3K5Wv0DsIF 7nJ1VBafyahkPpV6LVrUNUWXxTVZkU2UPYHSOvHPoQXnS+HKK15m/Hv1/90YaoNsf0jm iVItWbDgsEmIaaO2ThyaTBtCLdm/4owYAnvVj4I4qivKJipY0lBsjshZGMm4GgjRZeOb VZ5Yx4ax3qa7uzCUCcoQRYMDS9T7Z3S+O8a/5DS+vVqfXWDreV6mu4aO94LydDgEGYsa bO9g== X-Gm-Message-State: AFqh2kp444fpXxSdwXUmiXCXaUfRtsmD2gOnDXrJIZ6g7fcCTdZCI07u 4iwpvpQE1zrBNdi14AZbXCVPdakgVcBoSYwp X-Google-Smtp-Source: AMrXdXuRGgsiwA4HhZEUjvPe3rUe82HuuCxRCrIxhvRyjc68zQIey6oqWemF0IKGffdvUIL0o0nSeQ== X-Received: by 2002:a05:6512:6ce:b0:4cc:553f:5b68 with SMTP id u14-20020a05651206ce00b004cc553f5b68mr3020397lff.40.1673010879984; Fri, 06 Jan 2023 05:14:39 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH v1 1/8] xen/riscv: introduce dummy asm/init.h Date: Fri, 6 Jan 2023 15:14:22 +0200 Message-Id: X-Mailer: git-send-email 2.38.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Signed-off-by: Oleksii Kurochko --- xen/arch/riscv/include/asm/init.h | 12 ++++++++++++ 1 file changed, 12 insertions(+) create mode 100644 xen/arch/riscv/include/asm/init.h diff --git a/xen/arch/riscv/include/asm/init.h b/xen/arch/riscv/include/asm/init.h new file mode 100644 index 0000000000..237ec25e4e --- /dev/null +++ b/xen/arch/riscv/include/asm/init.h @@ -0,0 +1,12 @@ +#ifndef _XEN_ASM_INIT_H +#define _XEN_ASM_INIT_H + +#endif /* _XEN_ASM_INIT_H */ +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ -- 2.38.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 06 13:14:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 13:14:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472544.732825 (Exim 4.92) (envelope-from ) id 1pDmYa-00045H-CR; Fri, 06 Jan 2023 13:14:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472544.732825; Fri, 06 Jan 2023 13:14:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDmYa-000458-8K; Fri, 06 Jan 2023 13:14:48 +0000 Received: by outflank-mailman (input) for mailman id 472544; Fri, 06 Jan 2023 13:14:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDmYY-0003zy-Jd for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 13:14:46 +0000 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [2a00:1450:4864:20::136]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 16168da3-8dc4-11ed-b8d0-410ff93cb8f0; Fri, 06 Jan 2023 14:14:44 +0100 (CET) Received: by mail-lf1-x136.google.com with SMTP id bp15so1865644lfb.13 for ; Fri, 06 Jan 2023 05:14:44 -0800 (PST) Received: from fedora.. ([195.234.76.149]) by smtp.gmail.com with ESMTPSA id f14-20020a0565123b0e00b004b7033da2d7sm150221lfv.128.2023.01.06.05.14.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jan 2023 05:14:43 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 16168da3-8dc4-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Szof3vhqcf1cuBmqVq5Q2IZcNa/4nJpd7CeH5aS/VM8=; b=cQzbsV1We3uOandm0dnfdaj/H7IIIhcsfpN/Lxb7zZEiEQWUgLQ4F9PMzPlKUVHcXY jRSZco3lfG1JhL/PTtNL7XwLktSfpwQQPYNJ1d8F0CfgrXGn0EfOkFV8iO9DqQpHj6j5 60YsQ63IXJTO1yh7XAumMCtqfgb/wNJtY1saMKPfMfW913cDSM61f+kLg/zBzPlghdPq uuoErP5j9CAIfWku6Qdh1xr1Wa1dq4fIGHpkRozz7IuzyJxZGdgk779OoZINEAKJCGq6 tjhrvsqOEvkmRuxkyGpg/lQeYe0+5RkvngIsCvKtpTzVl3YD0IPli5DJGsdkopklAup8 kwPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Szof3vhqcf1cuBmqVq5Q2IZcNa/4nJpd7CeH5aS/VM8=; b=FwZCyupFCjNZq1d+nmAg73AMVK7AvMOoT3uGXLJp62W529RSlzmU6dY6PqcMPO6MpO aj57YQnlGK1jvnGO9uDLkCePYxwXa/0cKjVq0gX0edZPH/ciAm2HHST1+FDCgYvluUJw BKFVGxJxWDjCEVtGAiVvJ+/LbGyoHq0teaGg2F03I1VQhRgkQeyMRo9+tUbsPBOlOE4Y dSkF1fdRPvSyzifY3sFCHvnf79S2ZK1O1BD7100gnK3TR1mHJwtC8yRQE6NqS9sbTuds PrEy8RbbawVjuiOg5w64I90leJcfaPcmAy4RNCMISsdW0cyqFhv6ReHQjIqX0Lzl6i/E jmrA== X-Gm-Message-State: AFqh2kq462u/jLGdE86KSGpch86/sVfnVHZJbydqR4c4xIIL/p05zGD4 Tl2K2Hzv9vpWkx7m9t9KvWlRyXbUuNYmZHrf X-Google-Smtp-Source: AMrXdXvNq2lNiXoqpUOykfZiuBP8QUksdxBOvF4zWSj54AMf05ZpoqtWPB5OqFs7UVSr9Xh6n0qkVA== X-Received: by 2002:a05:6512:32cc:b0:4cb:4378:9c6 with SMTP id f12-20020a05651232cc00b004cb437809c6mr3292688lfg.23.1673010883600; Fri, 06 Jan 2023 05:14:43 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH v1 4/8] xen/riscv: introduce sbi call to putchar to console Date: Fri, 6 Jan 2023 15:14:25 +0200 Message-Id: <09da5a3184242152af6af060720a007738a55d6e.1673009740.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The patch introduce sbi_putchar() SBI call which is necessary to implement initial early_printk Signed-off-by: Oleksii Kurochko --- xen/arch/riscv/Makefile | 1 + xen/arch/riscv/include/asm/sbi.h | 34 ++++++++++++++++++++++++ xen/arch/riscv/sbi.c | 44 ++++++++++++++++++++++++++++++++ 3 files changed, 79 insertions(+) create mode 100644 xen/arch/riscv/include/asm/sbi.h create mode 100644 xen/arch/riscv/sbi.c diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile index 5a67a3f493..60db415654 100644 --- a/xen/arch/riscv/Makefile +++ b/xen/arch/riscv/Makefile @@ -1,5 +1,6 @@ obj-$(CONFIG_RISCV_64) += riscv64/ obj-y += setup.o +obj-y += sbi.o $(TARGET): $(TARGET)-syms $(OBJCOPY) -O binary -S $< $@ diff --git a/xen/arch/riscv/include/asm/sbi.h b/xen/arch/riscv/include/asm/sbi.h new file mode 100644 index 0000000000..34b53f8eaf --- /dev/null +++ b/xen/arch/riscv/include/asm/sbi.h @@ -0,0 +1,34 @@ +/* SPDX-License-Identifier: (GPL-2.0-or-later) */ +/* + * Copyright (c) 2021 Vates SAS. + * + * Taken from xvisor, modified by Bobby Eshleman (bobby.eshleman@gmail.com). + * + * Taken/modified from Xvisor project with the following copyright: + * + * Copyright (c) 2019 Western Digital Corporation or its affiliates. + */ + +#ifndef __CPU_SBI_H__ +#define __CPU_SBI_H__ + +#define SBI_EXT_0_1_CONSOLE_PUTCHAR 0x1 + +struct sbiret { + long error; + long value; +}; + +struct sbiret sbi_ecall(unsigned long ext, unsigned long fid, unsigned long arg0, + unsigned long arg1, unsigned long arg2, + unsigned long arg3, unsigned long arg4, + unsigned long arg5); + +/** + * Writes given character to the console device. + * + * @param ch The data to be written to the console. + */ +void sbi_console_putchar(int ch); + +#endif // __CPU_SBI_H__ diff --git a/xen/arch/riscv/sbi.c b/xen/arch/riscv/sbi.c new file mode 100644 index 0000000000..67cf5dd982 --- /dev/null +++ b/xen/arch/riscv/sbi.c @@ -0,0 +1,44 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* + * Taken and modified from the xvisor project with the copyright Copyright (c) + * 2019 Western Digital Corporation or its affiliates and author Anup Patel + * (anup.patel@wdc.com). + * + * Modified by Bobby Eshleman (bobby.eshleman@gmail.com). + * + * Copyright (c) 2019 Western Digital Corporation or its affiliates. + * Copyright (c) 2021 Vates SAS. + */ + +#include +#include + +struct sbiret sbi_ecall(unsigned long ext, unsigned long fid, unsigned long arg0, + unsigned long arg1, unsigned long arg2, + unsigned long arg3, unsigned long arg4, + unsigned long arg5) +{ + struct sbiret ret; + register unsigned long a0 asm ("a0") = arg0; + register unsigned long a1 asm ("a1") = arg1; + register unsigned long a2 asm ("a2") = arg2; + register unsigned long a3 asm ("a3") = arg3; + register unsigned long a4 asm ("a4") = arg4; + register unsigned long a5 asm ("a5") = arg5; + register unsigned long a6 asm ("a6") = fid; + register unsigned long a7 asm ("a7") = ext; + + asm volatile ("ecall" + : "+r" (a0), "+r" (a1) + : "r" (a2), "r" (a3), "r" (a4), "r" (a5), "r" (a6), "r" (a7) + : "memory"); + ret.error = a0; + ret.value = a1; + + return ret; +} + +void sbi_console_putchar(int ch) +{ + sbi_ecall(SBI_EXT_0_1_CONSOLE_PUTCHAR, 0, ch, 0, 0, 0, 0, 0); +} -- 2.38.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 06 13:14:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 13:14:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472545.732830 (Exim 4.92) (envelope-from ) id 1pDmYa-00049s-Qr; Fri, 06 Jan 2023 13:14:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472545.732830; Fri, 06 Jan 2023 13:14:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDmYa-00049H-K4; Fri, 06 Jan 2023 13:14:48 +0000 Received: by outflank-mailman (input) for mailman id 472545; Fri, 06 Jan 2023 13:14:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDmYZ-0003zy-CT for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 13:14:47 +0000 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [2a00:1450:4864:20::12d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 16d71d02-8dc4-11ed-b8d0-410ff93cb8f0; Fri, 06 Jan 2023 14:14:45 +0100 (CET) Received: by mail-lf1-x12d.google.com with SMTP id z26so1886263lfu.8 for ; Fri, 06 Jan 2023 05:14:45 -0800 (PST) Received: from fedora.. ([195.234.76.149]) by smtp.gmail.com with ESMTPSA id f14-20020a0565123b0e00b004b7033da2d7sm150221lfv.128.2023.01.06.05.14.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jan 2023 05:14:44 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 16d71d02-8dc4-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=V/C7mq9n+LLhC4Y4ZbcEJdqsm6p7eqTbyDE7iupd4oI=; b=DmPgp211+8J2th3XIdLG7IFTx4S08FyDzOd2EKY33xrDl/G3AFncyIEwd9hidIynjW My5wV8H1swatr8xVCeu/nA4fhbDyYXH215UKAkYHa/zjrp9Gws+38Z0SsYUN1qcFFlVS rbuwrpYwBVF7X3vdf8bKHyA62wshCC0L+uXcVvoBk/Rr8XdlqLdoiJCiSiST7hPNYHVG bwBJ1t1ISSHFQfFYPJ9W79L+cI51pnkYJ0WQScbMrNDxRYFC9gaAJUsN5oAuuwX10gj6 VJ+sERai9LxYoUtqqt3lpvj1a3yeLGGtY+m4VUcEfkRPxvXvNfUJ5SmYw0VU59TpGiu8 vevg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=V/C7mq9n+LLhC4Y4ZbcEJdqsm6p7eqTbyDE7iupd4oI=; b=NnkWNNRrOhmeW9ToyNCn7stmnwK2/uLmmA2pUXs4BQzMTP+qb0vuO3bJ76tfXOwC4A nD4ioATkBrNxHEWERPXobYdVR+QkDLa5Y+23oZKGHJTrYaMQZFvppysDvrH6Hqt6jp9V Hx/vCtfxDQX1bPD3J1V/qInD0QL482p5YXYYuMihOi/rifWPaoyHk+n75RsnDlcrID08 QFUbj1RVeiu9cenpbfWCx9gHzOoQw3U5vlJKCyJcZnmBrUetzGU3qurpvSTqzFdeUa8l d14rkFt2/Dz8WEneNpt9FwPquKLOra1YZoHUpjZEbBYxl/VCbrjj/eKA80PEwydiOMbZ QGaQ== X-Gm-Message-State: AFqh2kpQm1xgce9MP5LoGvanJpv00kkSmKBAX96JBrCOcyKqVzSkHOK4 jCDGqYQrvpr8sYL1dBh6P8xyJfzL61IzToK6 X-Google-Smtp-Source: AMrXdXuzdj7/0NVCbmFTZQ7fqbaayzfjRYlIo5wrF/b9HwI6nUYbU6E3dM8LqLQZDIL0pVc1/Rrufg== X-Received: by 2002:a05:6512:16a8:b0:4b5:b7ba:cae with SMTP id bu40-20020a05651216a800b004b5b7ba0caemr16054266lfb.48.1673010884899; Fri, 06 Jan 2023 05:14:44 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , George Dunlap , Jan Beulich , Julien Grall , Wei Liu Subject: [PATCH v1 5/8] xen/include: include in Date: Fri, 6 Jan 2023 15:14:26 +0200 Message-Id: <940bf18969634564fa5d206d02eb2a116c9e0ea0.1673009740.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit should be included because second argument of early_puts has type 'size_t' which is defined in Signed-off-by: Oleksii Kurochko --- xen/include/xen/early_printk.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/include/xen/early_printk.h b/xen/include/xen/early_printk.h index 0f76c3a74f..abb34687da 100644 --- a/xen/include/xen/early_printk.h +++ b/xen/include/xen/early_printk.h @@ -4,6 +4,8 @@ #ifndef __XEN_EARLY_PRINTK_H__ #define __XEN_EARLY_PRINTK_H__ +#include + #ifdef CONFIG_EARLY_PRINTK void early_puts(const char *s, size_t nr); #else -- 2.38.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 06 13:14:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 13:14:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472546.732847 (Exim 4.92) (envelope-from ) id 1pDmYc-0004b0-9A; Fri, 06 Jan 2023 13:14:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472546.732847; Fri, 06 Jan 2023 13:14:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDmYc-0004ZS-0y; Fri, 06 Jan 2023 13:14:50 +0000 Received: by outflank-mailman (input) for mailman id 472546; Fri, 06 Jan 2023 13:14:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDmYa-0002z5-5I for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 13:14:48 +0000 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [2a00:1450:4864:20::12f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 180c2e86-8dc4-11ed-91b6-6bf2151ebd3b; Fri, 06 Jan 2023 14:14:47 +0100 (CET) Received: by mail-lf1-x12f.google.com with SMTP id cf42so1914091lfb.1 for ; Fri, 06 Jan 2023 05:14:47 -0800 (PST) Received: from fedora.. ([195.234.76.149]) by smtp.gmail.com with ESMTPSA id f14-20020a0565123b0e00b004b7033da2d7sm150221lfv.128.2023.01.06.05.14.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jan 2023 05:14:46 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 180c2e86-8dc4-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/Qi8VnEIuZ7tu3k7g7nrwofraJgO1NpoRR5W+cQW214=; b=IUO9MIUCR9uzevVnoE6Q5BoLbKRfVemQHPUHAEoYTQT3tphPo6e4/4rUj/rYQLAvQX 5iqss+xdYJai0JXiu5wZ8CbZrItkTyIG0h28Xdz/rgcuE4tUCZxm9SKAcs6jjj31yu68 AUm0+UBq8a3vRf90sO+kGhFnD6ZCthJqi5ifsGvZpMomyC4JBhCISalm6Tmcs49jMoE3 Z0kSgzSdSlTeV//BPmlZIOl5GMM7wXL5GC/Avh7rhY4HXo3xbWF3sAGJuWH0yu4ipGUH VyyDRfok7u/KqekTkgoRn2mNY6Fx2E4YnoHWhOQXyg86MbWAgijpBqtre+bLF+hpV2dT trGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/Qi8VnEIuZ7tu3k7g7nrwofraJgO1NpoRR5W+cQW214=; b=z1goe7/QVe31MFZFwXDra6gie3EfYvBWLMPL6THzaQTzWLM4jE7AL1dxRRNOpRFCpH aEME83JKovQfiioOdQyBwoVg+NH02PejfiAOCzP4+sNHZdkkUy48XR/8ZKAZWVhDVND1 R0RLBczI+Iwm5lclOmrQPDgBygJ70J1W76ek0nrKrr19L0VoyeuU3DY/2B8FFLyiq0vl Y+RMgMEgF7eblVV+jBvIbGuxOLV/CqboBcD+MCdglt+UEagPyQFl1peAJUSqc6bNhRz7 wxE3p6ewQnHFtFotb4F/zvzloinckwlPaZxGy7VKr7boW8N2dM2ZKn9HxQ6tPAzTPL88 MwAg== X-Gm-Message-State: AFqh2kr7+gd46GFlM1LUT1c1U/rP5EYIJ/cUK8sApLKMGtivicz3cLHM u1C8aFv9sDkUKpBO7AmLFrntlEnnMeXCWTnZ X-Google-Smtp-Source: AMrXdXsxlHbO2bPPbcGhGWP/ZxA8JWr/SwPBqT0WRMNphDupmhWfQ7F9toeww1dIfqqiphwz81zoYA== X-Received: by 2002:a05:6512:308f:b0:4cb:1645:7259 with SMTP id z15-20020a056512308f00b004cb16457259mr11225608lfd.61.1673010886967; Fri, 06 Jan 2023 05:14:46 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH v1 7/8] xen/riscv: print hello message from C env Date: Fri, 6 Jan 2023 15:14:28 +0200 Message-Id: <21fb02aa340fe3a7a95dfbb950b33ae7a363496e.1673009740.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Signed-off-by: Oleksii Kurochko --- xen/arch/riscv/riscv64/head.S | 4 +--- xen/arch/riscv/setup.c | 12 ++++++++++++ 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/xen/arch/riscv/riscv64/head.S b/xen/arch/riscv/riscv64/head.S index ddc7104701..4e399016e9 100644 --- a/xen/arch/riscv/riscv64/head.S +++ b/xen/arch/riscv/riscv64/head.S @@ -5,6 +5,4 @@ ENTRY(start) li t0, PAGE_SIZE add sp, sp, t0 -_start_hang: - wfi - j _start_hang + tail start_xen diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c index 2c7dca1daa..785566103b 100644 --- a/xen/arch/riscv/setup.c +++ b/xen/arch/riscv/setup.c @@ -1,6 +1,18 @@ #include #include +#include + /* Xen stack for bringing up the first CPU. */ unsigned char __initdata cpu0_boot_stack[PAGE_SIZE] __aligned(PAGE_SIZE); + +void __init noreturn start_xen(void) +{ + early_printk("Hello from C env\n"); + + for ( ;; ) + asm volatile ("wfi"); + + unreachable(); +} -- 2.38.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 06 13:14:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 13:14:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472547.732851 (Exim 4.92) (envelope-from ) id 1pDmYc-0004fO-NY; Fri, 06 Jan 2023 13:14:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472547.732851; Fri, 06 Jan 2023 13:14:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDmYc-0004ef-FG; Fri, 06 Jan 2023 13:14:50 +0000 Received: by outflank-mailman (input) for mailman id 472547; Fri, 06 Jan 2023 13:14:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDmYa-0003zy-CY for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 13:14:48 +0000 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [2a00:1450:4864:20::130]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 176521e3-8dc4-11ed-b8d0-410ff93cb8f0; Fri, 06 Jan 2023 14:14:46 +0100 (CET) Received: by mail-lf1-x130.google.com with SMTP id bu8so1902321lfb.4 for ; Fri, 06 Jan 2023 05:14:46 -0800 (PST) Received: from fedora.. ([195.234.76.149]) by smtp.gmail.com with ESMTPSA id f14-20020a0565123b0e00b004b7033da2d7sm150221lfv.128.2023.01.06.05.14.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jan 2023 05:14:45 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 176521e3-8dc4-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=deWE8GI9Ntl4m3olds6B452/c7DgLQANjeRayM/Lyr4=; b=KkPDjBNkaIRh+ppwZJdsQCOYaVYRO59kzdiLFP1dy8UBa5sP3DpybFKTltLHwEWE5g KAYOkw4Ci8qbPUnqpCIYzjYOAAvc5e5XHrQJWr5LnptUGHBoVk2xY8Q+UTnTPPfYY1nB uEVVSm42l9BMNhgPTuLO4qNUCxGOzEIZmVmRuXkZleKJbitUzjbO8a+s4sZMXEM8PAkF EbAeJCKxY0SikI/TczNSG4E2MiRweJNsScgLFwAnlxnoQd/3S2zzPPQjcB5/dBm1SCrC wn8XpSFiW60HixsnBnthHs0wFp2MdPqZspdADTGemwPHVSi7qrXnDJopky9SG7Vmw21Y DLzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=deWE8GI9Ntl4m3olds6B452/c7DgLQANjeRayM/Lyr4=; b=0zdFsieWuRshahHRoaJ9HeeX6qiAUOeXOnenmFvBW1lo5+x1Jlz48JYZOaX5ph/nox dVSTAVu/bbX4OA51/snCrLS/2JX7soPJBiwhEmnvYNrKTD9CZRcdRbB1U//ZC5BBqWiD NMxl+oQsSQo/G1p5gxgIGcfQ5KYDv+VvcVd3PSdw5I9PfmlzeNU7dqGc83s7F39ThWCV 6EsYLKov/07OP7tgaI1o8fLj2eF/QTkEdvePfODSK25Xl7/L/QiotQDyltA//kgWtNVV 9BzDyz8cS7Zhy5O1JefXeMy5mHDGMMfsjyN8bpnJu7/9qprHyYC4gsAcwUKJovwKIBTB Pzyg== X-Gm-Message-State: AFqh2kq8jRR7RN1xDTOzD+E+o/gcHn7QfqfLcsVzimM4kDQuEIlwAnxV jgbOMKD+Bc47tu+Ti7e2Ma/+8U9pxGokCBR6 X-Google-Smtp-Source: AMrXdXtd7Mm879/iojPZdzolaaaSsCDSS6dg4V03gg7DzzioaB2FFkJaTLjtD/LgOltwFLEIDf5Tag== X-Received: by 2002:a05:6512:4020:b0:4b6:f595:89a7 with SMTP id br32-20020a056512402000b004b6f59589a7mr16272641lfb.14.1673010885964; Fri, 06 Jan 2023 05:14:45 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH v1 6/8] xen/riscv: introduce early_printk basic stuff Date: Fri, 6 Jan 2023 15:14:27 +0200 Message-Id: <3f30a60729b45ee01adc2d4c0eec5a89bb083abd.1673009740.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The patch introduces a basic stuff of early_printk functionality which will be enough to print 'hello from C environment" Signed-off-by: Oleksii Kurochko --- xen/arch/riscv/Kconfig.debug | 7 ++++++ xen/arch/riscv/Makefile | 1 + xen/arch/riscv/early_printk.c | 27 +++++++++++++++++++++++ xen/arch/riscv/include/asm/early_printk.h | 12 ++++++++++ 4 files changed, 47 insertions(+) create mode 100644 xen/arch/riscv/early_printk.c create mode 100644 xen/arch/riscv/include/asm/early_printk.h diff --git a/xen/arch/riscv/Kconfig.debug b/xen/arch/riscv/Kconfig.debug index e69de29bb2..940630fd62 100644 --- a/xen/arch/riscv/Kconfig.debug +++ b/xen/arch/riscv/Kconfig.debug @@ -0,0 +1,7 @@ +config EARLY_PRINTK + bool "Enable early printk config" + default DEBUG + depends on RISCV_64 + help + + Enables early printk debug messages diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile index 60db415654..e8630fe68d 100644 --- a/xen/arch/riscv/Makefile +++ b/xen/arch/riscv/Makefile @@ -1,6 +1,7 @@ obj-$(CONFIG_RISCV_64) += riscv64/ obj-y += setup.o obj-y += sbi.o +obj-$(CONFIG_EARLY_PRINTK) += early_printk.o $(TARGET): $(TARGET)-syms $(OBJCOPY) -O binary -S $< $@ diff --git a/xen/arch/riscv/early_printk.c b/xen/arch/riscv/early_printk.c new file mode 100644 index 0000000000..f357f3220b --- /dev/null +++ b/xen/arch/riscv/early_printk.c @@ -0,0 +1,27 @@ +/* + * RISC-V early printk using SBI + * + * Copyright (C) 2021 Bobby Eshleman + */ +#include +#include + +void early_puts(const char *s, size_t nr) +{ + while ( nr-- > 0 ) + { + if (*s == '\n') + sbi_console_putchar('\r'); + sbi_console_putchar(*s); + s++; + } +} + +void early_printk(const char *str) +{ + while (*str) + { + early_puts(str, 1); + str++; + } +} diff --git a/xen/arch/riscv/include/asm/early_printk.h b/xen/arch/riscv/include/asm/early_printk.h new file mode 100644 index 0000000000..05106e160d --- /dev/null +++ b/xen/arch/riscv/include/asm/early_printk.h @@ -0,0 +1,12 @@ +#ifndef __EARLY_PRINTK_H__ +#define __EARLY_PRINTK_H__ + +#include + +#ifdef CONFIG_EARLY_PRINTK +void early_printk(const char *str); +#else +static inline void early_printk(const char *s) {}; +#endif + +#endif /* __EARLY_PRINTK_H__ */ -- 2.38.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 06 13:14:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 13:14:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472548.732867 (Exim 4.92) (envelope-from ) id 1pDmYe-00059H-BB; Fri, 06 Jan 2023 13:14:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472548.732867; Fri, 06 Jan 2023 13:14:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDmYe-00057p-41; Fri, 06 Jan 2023 13:14:52 +0000 Received: by outflank-mailman (input) for mailman id 472548; Fri, 06 Jan 2023 13:14:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDmYc-0003zy-5N for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 13:14:50 +0000 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [2a00:1450:4864:20::135]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 18918d88-8dc4-11ed-b8d0-410ff93cb8f0; Fri, 06 Jan 2023 14:14:48 +0100 (CET) Received: by mail-lf1-x135.google.com with SMTP id bt23so1893102lfb.5 for ; Fri, 06 Jan 2023 05:14:48 -0800 (PST) Received: from fedora.. ([195.234.76.149]) by smtp.gmail.com with ESMTPSA id f14-20020a0565123b0e00b004b7033da2d7sm150221lfv.128.2023.01.06.05.14.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jan 2023 05:14:47 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 18918d88-8dc4-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zkuUnAoSkk9s+gFXJpwU6jCUW0aPzs/gF76MvPyHXnI=; b=MVGTWNTTVQ4gdBPkwAo6PykkJ/JZNdEmbXh+V9u38VeofVDL6lNjpAk8ebSnjOy2aC qdLCnQD+QuMrhICGYxaMiQjun2jKwVFXKP+D+RGUuQ8/NnBlnGiAymNJ+tVOGEdV39T4 hYUvy4IYESRjdG7JvciMGqn+fDjDRtJTPGZI+ZrdYeRG9gwdj3qMjkacvklP4Hml+O2/ zbDxQY3UwHMbjR6fq/YTOZSb0EmYs3XrB3pAcrUfObI5XefUYO75+bAAyoBcZcWktlOs fQRD2eR4Rjy9b/ghj/nGUgUiiWydaIrR42doT6+DO44J8H2wblCMCupD0rV6CukG3VaH HSPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zkuUnAoSkk9s+gFXJpwU6jCUW0aPzs/gF76MvPyHXnI=; b=W8TdNl3tHDppVRxm80uT4J3Ub7KUvhuqmKNlk3k+2wOwyPtAfMtixr61r9b+jjeT1N S1uVJ65AjV5LYw6YPLk9UGW4o8JY5LquhjEiOyXPYAKTE3FFBiNUEG1VbgF6jQc8kaSt EPkzXZBDXUtvbln0CD6Whj/iclLSgyq8VjfrJURQkzgRwfloDtOMOd3H0VeVb+mQ81mC fFrxzdG5yLW0mPGKMjzhFUmDhUKl9IeEJUo6KxjiML15Rd9Fv5eiUKiKfuCyGYddvVtB VQ0n8QcgNn5bBNsy6bPmNxYj79FhRUnPRcjvGwR3larjU9hDzacUSoLe+pOWY4BZvwvX kbLw== X-Gm-Message-State: AFqh2krlsZ14pK5xLJzAlW7U5jb7oYk5/ckd9GvnCJ072d5Ec8BZitHl parp1EziKAR36dyAB7mWXh1dBoG2of7SucNy X-Google-Smtp-Source: AMrXdXuUGrBpflnPuMb2DD1qolCCvG4jfT8bJ+rtMFDENSeIxdQCNUSBSPGNfD78+DSR6H0Ar5nG1Q== X-Received: by 2002:ac2:53ab:0:b0:4cb:145d:c407 with SMTP id j11-20020ac253ab000000b004cb145dc407mr9542521lfh.7.1673010887872; Fri, 06 Jan 2023 05:14:47 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Doug Goldstein Subject: [PATCH v1 8/8] automation: add RISC-V smoke test Date: Fri, 6 Jan 2023 15:14:29 +0200 Message-Id: <90078a83982b37846e9845c8ffc50c92f3be1f47.1673009740.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add check if there is a message 'Hello from C env' presents in log file to be sure that stack is set and C part of early printk is working. Also qemu-system-riscv was added to riscv64.dockerfile as it is required for RISC-V smoke test. Signed-off-by: Oleksii Kurochko --- automation/build/archlinux/riscv64.dockerfile | 3 ++- automation/scripts/qemu-smoke-riscv64.sh | 20 +++++++++++++++++++ 2 files changed, 22 insertions(+), 1 deletion(-) create mode 100755 automation/scripts/qemu-smoke-riscv64.sh diff --git a/automation/build/archlinux/riscv64.dockerfile b/automation/build/archlinux/riscv64.dockerfile index ff8b2b955d..375c78ecd5 100644 --- a/automation/build/archlinux/riscv64.dockerfile +++ b/automation/build/archlinux/riscv64.dockerfile @@ -9,7 +9,8 @@ RUN pacman --noconfirm --needed -Syu \ inetutils \ riscv64-linux-gnu-binutils \ riscv64-linux-gnu-gcc \ - riscv64-linux-gnu-glibc + riscv64-linux-gnu-glibc \ + qemu-system-riscv # Add compiler path ENV CROSS_COMPILE=riscv64-linux-gnu- diff --git a/automation/scripts/qemu-smoke-riscv64.sh b/automation/scripts/qemu-smoke-riscv64.sh new file mode 100755 index 0000000000..e0f06360bc --- /dev/null +++ b/automation/scripts/qemu-smoke-riscv64.sh @@ -0,0 +1,20 @@ +#!/bin/bash + +set -ex + +# Run the test +rm -f smoke.serial +set +e + +timeout -k 1 2 \ +qemu-system-riscv64 \ + -M virt \ + -smp 1 \ + -nographic \ + -m 2g \ + -kernel binaries/xen \ + |& tee smoke.serial + +set -e +(grep -q "Hello from C env" smoke.serial) || exit 1 +exit 0 -- 2.38.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 06 13:41:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 13:41:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472605.732880 (Exim 4.92) (envelope-from ) id 1pDmxq-0002XZ-93; Fri, 06 Jan 2023 13:40:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472605.732880; Fri, 06 Jan 2023 13:40:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDmxq-0002XS-6S; Fri, 06 Jan 2023 13:40:54 +0000 Received: by outflank-mailman (input) for mailman id 472605; Fri, 06 Jan 2023 13:40:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDmxo-0002XK-Ky for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 13:40:52 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDmxo-00082r-7K; Fri, 06 Jan 2023 13:40:52 +0000 Received: from 54-240-197-234.amazon.com ([54.240.197.234] helo=[192.168.4.240]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pDmxo-0001Dv-0C; Fri, 06 Jan 2023 13:40:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=pHwJANpkRcSFgmVES30QT1jRvgzCAyd+JZcZ0J+t3G4=; b=fDT4xYoOMSMvX2R8xytxQG0yJZ 0RcDYcDeS5Xe+Iy7oZYXr0p9Zr7Bd00eR1p22/OZ0mYVDdkgTntLbNjMTiUbEe24usMnQ4cMpD879 WtPgxwtvA/+XIY3tBYIMggLt2O4Cqym+z+dAbrCvFfH8aYdWK6yaTln9710nKqrdUsNw=; Message-ID: Date: Fri, 6 Jan 2023 13:40:49 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v1 4/8] xen/riscv: introduce sbi call to putchar to console Content-Language: en-US To: Oleksii Kurochko , xen-devel@lists.xenproject.org Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis References: <09da5a3184242152af6af060720a007738a55d6e.1673009740.git.oleksii.kurochko@gmail.com> From: Julien Grall In-Reply-To: <09da5a3184242152af6af060720a007738a55d6e.1673009740.git.oleksii.kurochko@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 06/01/2023 13:14, Oleksii Kurochko wrote: > The patch introduce sbi_putchar() SBI call which is necessary > to implement initial early_printk > > Signed-off-by: Oleksii Kurochko > --- > xen/arch/riscv/Makefile | 1 + > xen/arch/riscv/include/asm/sbi.h | 34 ++++++++++++++++++++++++ > xen/arch/riscv/sbi.c | 44 ++++++++++++++++++++++++++++++++ IMHO, it would be better to implement sbi.c in assembly so you can use print in the console before you jump to C world. > 3 files changed, 79 insertions(+) > create mode 100644 xen/arch/riscv/include/asm/sbi.h > create mode 100644 xen/arch/riscv/sbi.c > > diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile > index 5a67a3f493..60db415654 100644 > --- a/xen/arch/riscv/Makefile > +++ b/xen/arch/riscv/Makefile > @@ -1,5 +1,6 @@ > obj-$(CONFIG_RISCV_64) += riscv64/ > obj-y += setup.o > +obj-y += sbi.o Please order the filename alphabetically. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Jan 06 13:42:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 13:42:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472612.732891 (Exim 4.92) (envelope-from ) id 1pDmzi-00037C-LG; Fri, 06 Jan 2023 13:42:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472612.732891; Fri, 06 Jan 2023 13:42:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDmzi-000375-IU; Fri, 06 Jan 2023 13:42:50 +0000 Received: by outflank-mailman (input) for mailman id 472612; Fri, 06 Jan 2023 13:42:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDmzh-00036z-Ve for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 13:42:49 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDmzh-000861-L1; Fri, 06 Jan 2023 13:42:49 +0000 Received: from 54-240-197-234.amazon.com ([54.240.197.234] helo=[192.168.4.240]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pDmzh-0001I7-DC; Fri, 06 Jan 2023 13:42:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=1xSvn0wKkIrdDwdTQKVcoGlupvegRZ85iKM+1ckxPpQ=; b=xsEVc6FnI0VAfju6DbUu0t+GQh CK6v/X38FlZSPUut7OG28p28bZ+amJ3w/B2eUpcwYZZ6P6zMNGIO1AWXxyuxz2xI4JRwBH+FhsbHk LWnTpymxM+zq4XNt3N6exlFk0XV/KLf9e5xbP0BuegpY5E1VQCuvHjY+rNHidF5nEq8Q=; Message-ID: <0da22900-63f0-b8fa-00b6-855e2a94485d@xen.org> Date: Fri, 6 Jan 2023 13:42:47 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v1 1/8] xen/riscv: introduce dummy asm/init.h Content-Language: en-US To: Oleksii Kurochko , xen-devel@lists.xenproject.org Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis References: From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 06/01/2023 13:14, Oleksii Kurochko wrote: I am guessing this is necessary because you will use will be used later on. If so, then I think it would be useful for mention it in the commit message. > Signed-off-by: Oleksii Kurochko Reviewed-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Jan 06 13:46:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 13:46:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472619.732902 (Exim 4.92) (envelope-from ) id 1pDn2o-0003jM-45; Fri, 06 Jan 2023 13:46:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472619.732902; Fri, 06 Jan 2023 13:46:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDn2o-0003jF-0s; Fri, 06 Jan 2023 13:46:02 +0000 Received: by outflank-mailman (input) for mailman id 472619; Fri, 06 Jan 2023 13:46:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDn2n-0003j7-4v for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 13:46:01 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDn2m-00088g-6r; Fri, 06 Jan 2023 13:46:00 +0000 Received: from 54-240-197-234.amazon.com ([54.240.197.234] helo=[192.168.4.240]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pDn2m-0001UQ-0p; Fri, 06 Jan 2023 13:46:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=c9iXVFW3rTmIfW3C/upQrZFmISBGPfs6G7zwCooEQRg=; b=2gEsn1qCwQ/J91sTxhEMaLFzx/ le4lD/EPMDVOP2QpO/C+9vmfClynQs7/Sa45hepN9a1BJ8/DuWzrAbAJqxEvUfOYef3IdGhZyCioz hoZLIICMm469iZzmRvcGCbGqYDIdDzNpbYqGlDk8G2zKV70+sRF7wkWL+fwdbgp2ltUw=; Message-ID: <2db650a0-49c4-9894-3220-a13306c7e2ea@xen.org> Date: Fri, 6 Jan 2023 13:45:58 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v1 5/8] xen/include: include in Content-Language: en-US To: Oleksii Kurochko , xen-devel@lists.xenproject.org Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , George Dunlap , Jan Beulich , Wei Liu References: <940bf18969634564fa5d206d02eb2a116c9e0ea0.1673009740.git.oleksii.kurochko@gmail.com> From: Julien Grall In-Reply-To: <940bf18969634564fa5d206d02eb2a116c9e0ea0.1673009740.git.oleksii.kurochko@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 06/01/2023 13:14, Oleksii Kurochko wrote: > should be included because second argument of > early_puts has type 'size_t' which is defined in > > Signed-off-by: Oleksii Kurochko Acked-by: Julien Grall Cheers, > --- > xen/include/xen/early_printk.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/xen/include/xen/early_printk.h b/xen/include/xen/early_printk.h > index 0f76c3a74f..abb34687da 100644 > --- a/xen/include/xen/early_printk.h > +++ b/xen/include/xen/early_printk.h > @@ -4,6 +4,8 @@ > #ifndef __XEN_EARLY_PRINTK_H__ > #define __XEN_EARLY_PRINTK_H__ > > +#include > + > #ifdef CONFIG_EARLY_PRINTK > void early_puts(const char *s, size_t nr); > #else -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Jan 06 13:51:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 13:51:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472626.732912 (Exim 4.92) (envelope-from ) id 1pDn8D-0005AD-Of; Fri, 06 Jan 2023 13:51:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472626.732912; Fri, 06 Jan 2023 13:51:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDn8D-0005A6-Lz; Fri, 06 Jan 2023 13:51:37 +0000 Received: by outflank-mailman (input) for mailman id 472626; Fri, 06 Jan 2023 13:51:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDn8C-0005A0-6A for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 13:51:36 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDn8B-0008PF-Kh; Fri, 06 Jan 2023 13:51:35 +0000 Received: from 54-240-197-234.amazon.com ([54.240.197.234] helo=[192.168.4.240]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pDn8B-0001aw-EQ; Fri, 06 Jan 2023 13:51:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=eO/UT7LLAV0/9FLExjojEvWVJufAtRmMpUZsDz++tBE=; b=dnOcL8rB7uXZp08K21CcfYvv5i VcfkGVeN2HlaJZEHzWc2qkPKJvkmheLakkq58reBQiULQSwlY68tbT5gfdN91XrWkPUWXQ1C+WeAk hFNF5D9IibUBZVhAPTqKaauuXKCjD94Z0/gsCxjYx3rMPp4UiLc6LVQnwl76JXKsDdn0=; Message-ID: Date: Fri, 6 Jan 2023 13:51:33 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v1 6/8] xen/riscv: introduce early_printk basic stuff Content-Language: en-US To: Oleksii Kurochko , xen-devel@lists.xenproject.org Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis References: <3f30a60729b45ee01adc2d4c0eec5a89bb083abd.1673009740.git.oleksii.kurochko@gmail.com> From: Julien Grall In-Reply-To: <3f30a60729b45ee01adc2d4c0eec5a89bb083abd.1673009740.git.oleksii.kurochko@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 06/01/2023 13:14, Oleksii Kurochko wrote: > The patch introduces a basic stuff of early_printk functionality > which will be enough to print 'hello from C environment" > > Signed-off-by: Oleksii Kurochko > --- > xen/arch/riscv/Kconfig.debug | 7 ++++++ > xen/arch/riscv/Makefile | 1 + > xen/arch/riscv/early_printk.c | 27 +++++++++++++++++++++++ > xen/arch/riscv/include/asm/early_printk.h | 12 ++++++++++ > 4 files changed, 47 insertions(+) > create mode 100644 xen/arch/riscv/early_printk.c > create mode 100644 xen/arch/riscv/include/asm/early_printk.h > > diff --git a/xen/arch/riscv/Kconfig.debug b/xen/arch/riscv/Kconfig.debug > index e69de29bb2..940630fd62 100644 > --- a/xen/arch/riscv/Kconfig.debug > +++ b/xen/arch/riscv/Kconfig.debug > @@ -0,0 +1,7 @@ > +config EARLY_PRINTK > + bool "Enable early printk config" > + default DEBUG > + depends on RISCV_64 OOI, why can't this be used for RISCV_32? > + help > + > + Enables early printk debug messages > diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile > index 60db415654..e8630fe68d 100644 > --- a/xen/arch/riscv/Makefile > +++ b/xen/arch/riscv/Makefile > @@ -1,6 +1,7 @@ > obj-$(CONFIG_RISCV_64) += riscv64/ > obj-y += setup.o > obj-y += sbi.o > +obj-$(CONFIG_EARLY_PRINTK) += early_printk.o Please order the files alphabetically. > > $(TARGET): $(TARGET)-syms > $(OBJCOPY) -O binary -S $< $@ > diff --git a/xen/arch/riscv/early_printk.c b/xen/arch/riscv/early_printk.c > new file mode 100644 > index 0000000000..f357f3220b > --- /dev/null > +++ b/xen/arch/riscv/early_printk.c > @@ -0,0 +1,27 @@ Please add an SPDX license (the default for Xen is GPLv2). > +/* > + * RISC-V early printk using SBI > + * > + * Copyright (C) 2021 Bobby Eshleman So the copyright here is from Bobby. But I don't see any mention in the commit message. Where is this coming from? > + */ > +#include > +#include Please order the files alphabetically. > + > +void early_puts(const char *s, size_t nr) > +{ > + while ( nr-- > 0 ) > + { > + if (*s == '\n') > + sbi_console_putchar('\r'); > + sbi_console_putchar(*s); > + s++; > + } > +} > + > +void early_printk(const char *str) > +{ > + while (*str) > + { > + early_puts(str, 1); > + str++; > + } > +} > diff --git a/xen/arch/riscv/include/asm/early_printk.h b/xen/arch/riscv/include/asm/early_printk.h > new file mode 100644 > index 0000000000..05106e160d > --- /dev/null > +++ b/xen/arch/riscv/include/asm/early_printk.h > @@ -0,0 +1,12 @@ > +#ifndef __EARLY_PRINTK_H__ > +#define __EARLY_PRINTK_H__ > + > +#include > + > +#ifdef CONFIG_EARLY_PRINTK > +void early_printk(const char *str); > +#else > +static inline void early_printk(const char *s) {}; > +#endif > + > +#endif /* __EARLY_PRINTK_H__ */ -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Jan 06 13:52:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 13:52:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472630.732923 (Exim 4.92) (envelope-from ) id 1pDn8m-0005fV-1O; Fri, 06 Jan 2023 13:52:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472630.732923; Fri, 06 Jan 2023 13:52:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDn8l-0005fO-Uy; Fri, 06 Jan 2023 13:52:11 +0000 Received: by outflank-mailman (input) for mailman id 472630; Fri, 06 Jan 2023 13:52:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDn8k-0005ey-4y for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 13:52:10 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4d53b167-8dc9-11ed-b8d0-410ff93cb8f0; Fri, 06 Jan 2023 14:52:07 +0100 (CET) Received: from mail-dm6nam12lp2174.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.174]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 06 Jan 2023 08:52:02 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BLAPR03MB5427.namprd03.prod.outlook.com (2603:10b6:208:29d::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Fri, 6 Jan 2023 13:52:00 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5944.019; Fri, 6 Jan 2023 13:52:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4d53b167-8dc9-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1673013127; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=64DRU3wTSykqmUOKNnDmouyLt/Ao2F1H8xBMh1AeVhM=; b=H4BTQiDDyv3aLW5LuMvFxQ2MVek0EZQ1PTpwF//naWlLiKcfvrTUIZcg TDP9xFJ4k4U+KyVqpZb5AXogeCrYWLozvEL6kHqLyZk3bEwRzdo7eGGZW +oYPfgQ9u09Dy2Uu8n3gTbcJBDzksBVpcuXt04zBLqGm/NvWYp7AITYoY M=; X-IronPort-RemoteIP: 104.47.59.174 X-IronPort-MID: 91892705 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:afk756p04iu/9DFQRcJVb/gVVBJeBmJCZRIvgKrLsJaIsI4StFCzt garIBmBbPqLajekf95/bdy08k1T7MDRm9BrTgA/rX1mFH4b9JuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpAFc+E0/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06W1wUmAWP6gR5weHzydNVvrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXAAwBXEGyqO+k/LeiSMxwguYOF8vJH5xK7xmMzRmBZRonabbqZvyQoPN9gnI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jemraYWJEjCJbZw9ckKwj 2TK5WnmRDodM8SS02Gt+XOwnO7f2yj8Xer+EZXpr6472gLLmwT/DjVODmmV++Djs3TmUtFSN 28VuTd3pKk9oRnDot7VGkfQTGS/lhkYVtlLEux86xyXzaHU4AGxCW0NTzoHY9sj3OcmSDpv2 lKXktfBAT10rKbTWX+b7q2Trz65JW4SN2BqTTQfUQIP7t3noYcyphHCVNBuFOiylNKdMT7xy jaOsSM3r68Sk8kQ1qOwu1vAhlqErJ/DRB84/QXTU2es6Ct2YYekY8qj7l2zxf9ELZ2FR1ib+ nYeks6V7fsmEp2G0ieKRY0lF7av4fGHPDTCgEVHEJwo9jDr8HmmFahS6jxjIEZiMu4fZCTkJ kTUvGt55oJXPXasRb96ZcS2EctC5bfkPcToULbTdNUmSpN4bgOA8QllbFSc2G2rm08p+ZzTI r+eeMeoSHofV6JuyWPsQ/9HiOB3gCcj2WnUWJb3iQy91qaTb2KUTrFDN0aSauc+7+WPpwC9H 8tjCvZmAi53CIXWChQ7O6ZPRbzWBRDX3azLlvE= IronPort-HdrOrdr: A9a23:JoGSAa52kLtOSyjfYgPXwPLXdLJyesId70hD6qkRc3Bom6mj/P xG88516faZslgssQgb6La90cu7IU80hKQV3WB5B97LNmTbUQCTXeJfBOXZslndMhy72ulB1b pxN4hSYeeAamSSVPyKgjVQxexQpeW6zA== X-IronPort-AV: E=Sophos;i="5.96,305,1665460800"; d="scan'208";a="91892705" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JRymUHbqmOzUyZsaDr7P2CPCuPK4taQQDR9pxWekOWAlxDxZIrQZTGXXKFVv2NQaMm2r09Di1uFghCsrC5j7NF5SsFcYw66UkRRf0SgAn9Cqd5z1X/APmrd8j62c9FpjDIP3Bb6Yu+ZkoMrnoUgCzQN9Z1bkVIXoIs6nMoft2fIclP0ndI2aIt3WZmHhOMVttoRMl90ZCX3ghl781QlKXaeFck3Rcj0miUMk7qkQXsu0nfD26JMVe1vgr/JYLQGtLLGY//P9MPbAdyTZ1/4/uSnHGvV3BeNgw93SB7Tua3YLUPMntN5eXbaO+nYLvcDEExB2EwmD5/cRWgxBboC2fA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=64DRU3wTSykqmUOKNnDmouyLt/Ao2F1H8xBMh1AeVhM=; b=hFT/xRAQ6rJusYeiexW8nsWlPCtygaEONLxRuYa7gsWA+ZM30pFaRO8CSLRgreeGhISKA40WK9Lxrh9xNVhSr+313Qqi4u/b/xyqzKy4cKLKokxS+ar3q/Nvfrez6/QrqYf3zPe4xCs6J8xTn1pf6EfqlL7lx6GnJe22df1N0RZdsQdTCIDn6CKstmKkv+dVff7qEmB6Tjc0bd+K67fmx2V5IrhZgQtrfERMwJAepDa0fQhLbJX3CfaSsoy6JE8K5HL5h4lG5g2OjNU1DZxesOmjrRc+c5VGPGkZ+vS6LZaHI50Wes7eTIvjBZ7E9/geHuu3HrOUyIq5m7vMsuvhlw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=64DRU3wTSykqmUOKNnDmouyLt/Ao2F1H8xBMh1AeVhM=; b=mEZLOC8Zl43mFxkajabciUrLkLU2qUIOWY9bt++BG2sXShjorDsuIYi0tNzSx2cavx/9tIg5hPqbYcI4wfJTNomZ1vZpRZDaAqwy/2q40wGFb83hbXQ+540f4Xok0ZkZqnin4AgXk71viDlWhfZcCXO22CfvrtrddSBSlvOFUDg= From: Andrew Cooper To: Oleksii Kurochko , "xen-devel@lists.xenproject.org" CC: Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , George Dunlap , Jan Beulich , Julien Grall , Wei Liu , Doug Goldstein Subject: Re: [PATCH v1 0/8] Basic early_printk and smoke test implementation Thread-Topic: [PATCH v1 0/8] Basic early_printk and smoke test implementation Thread-Index: AQHZIdDY/WFtbXZWa0GsMaL1YLWWe66RaHaA Date: Fri, 6 Jan 2023 13:51:59 +0000 Message-ID: <299d913c-8095-ad90-ea3b-d46ef74d4fdc@citrix.com> References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|BLAPR03MB5427:EE_ x-ms-office365-filtering-correlation-id: c0626e55-cf4e-4baa-e38c-08daefed2ee5 x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Ali680qyf8HTQfh+9d+wzx0jih4Ud9sdaSAo2gULwwwAPsJzaHmdh/97Cxe7cWcI2o1YzqtADx7PqZ0RjPugtBSHwnCJjRnobFS57eeYohcFM8QZtDrifmvF4QEsCfmEVRCkPnJ5t28YKrWxUj95mM1LnjlvXKq8Kf3hhID6bhwMDeYj5GQ8TA/G34tSfdr1C2EXhw0MSuKxFfalGeqf0QNVx0TDygX33lGqoyTC7yD9conXgpvNaOQPRqsv0OF1A32LXbzRXlsRUHQ9HRdzmWsCrZYOdnKBMyMSIhVjoSuejRh7ssBiGwEeCjTidzbzDa05nLhpdHnO+dLuRZeVNxKs/0lZ0Wd8MY5eTdhlhrQ5R+r5N80g+55U4KxPzx7h09cEdGtPdGStaL65pgyL5ZEM8R/ZHPL+l1U3YYA5LqUxJqoDNQkKjnvqXmk8Na3TRMRtcDgEks69tz4OSOQa91i6HScXremc0tIsIKba4uXHIo+aOT7mMQJC/u8R5Z5kEBDQzFc3/puZNVak5jMgBJqLPWw5bAg2cFMUtC3GW/dYbtkcdD1ITgCpEh1+m54wJRgZ5dAeu768/oNTeJ6DmkH0AmXMltX7hB7cp7a+195o918GA4/Y3pbr4mLRwK8tR7CVHgh+j2kAdHHrfGHmP3lTQG9FYuODHOLT+NLts5ZW8wldn3NgQvpBVBDF0BtaNIY3r3YjKgKCg5aL3FGRH1o3i/QS6ELdnrIe30YkCO0V94tiZShXeAf7hjvpCqRLpmNcjvALCr8zSVChMpsjrg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(136003)(346002)(366004)(376002)(451199015)(5660300002)(41300700001)(7416002)(8936002)(316002)(91956017)(8676002)(4326008)(66946007)(54906003)(2906002)(110136005)(31686004)(53546011)(66556008)(6486002)(71200400001)(6506007)(66446008)(478600001)(76116006)(66476007)(64756008)(2616005)(86362001)(31696002)(186003)(6512007)(26005)(122000001)(83380400001)(82960400001)(38100700002)(36756003)(38070700005)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SmFHRVpMOFZHazh5aDBwaTZQYzlBZzhFa1NKcW9rcWJSK0JQMmhrOXQ3V2gz?= =?utf-8?B?NUs2WjI2OXMzbTV4RVo0bnYxREtyZlRtbEZ1V2tWV0xCKzRXdnhPOUhpcHRm?= =?utf-8?B?cld3Zm1yMitiU1BMdW5yV1prMU50L1hUT1dTbEl2WTlQMmg2NWEzTEhTS2tm?= =?utf-8?B?UWdJOVBlYUx4bU9aS3l2dU1QY2h0L0VzbWcvcExJcVAzK2tJTjZKQ1Bpd2J3?= =?utf-8?B?d2EvR3AxL0UwRlhyajNDTktCb3NFSm56b1RXa2g0NThTaE1PUTJwdmJUOUEr?= =?utf-8?B?anhSb1JUblFIM2FyZkdEb3F0ZlUzTnhnT2QzazNhRjBQRkRIT0JnSHYwbVJL?= =?utf-8?B?T1RZL210N1JMdkhqdkdsbjRWR0NTdFdhQTRpNUZiTU52ZklnVW9iZ3F1a0pE?= =?utf-8?B?dXkxUDZLYkI5WEpKMzZvcE9EUiszTkVwajRIZVRZU2FEZjEwQUhmWWtDYWU3?= =?utf-8?B?d01mZ0dUOElOOGYxT0tNTkdybUI1a0JVR3dPQkpKYzlXbml0eCtsYzJobDRF?= =?utf-8?B?eHZNZDFCQm5MYXhRRlM5cmdwZFpLWG1qN3RwR21tcW9yR3FicXhTYXBPNW0v?= =?utf-8?B?ZzlneUFKc0FibkRJRWM5djdjcUpYcUJKY1RWM2ZOMHlzMm9TR05SZ216Uys0?= =?utf-8?B?V2tNeFFpNnhDL2MvVTNqV0pPMHMxT2lvWWw5bkphMzU3RGhyRHpKbFgxbzIy?= =?utf-8?B?bWo3RFpoK0R0WEtBV21DZDdJYk84WTRvZFFqVFhYSThCYUlOMFp0V1d5WTZS?= =?utf-8?B?aFJSS2M5Si9XVDhUeDhHc3hYNlRQdEN0VkdQSmJsMnMwOEFZdEIvUkNDdVY1?= =?utf-8?B?MDB3WXlZNGFsMU1hZGFCaFJyU0xvaEZOUVhIOTFwT0ppT1Y4Slc4clQvSUhi?= =?utf-8?B?U0VhTitKTitaVzJyeXVvNXA5Z0pVWUFmOER1U21weFl2WEM1OU1sSGdXVzMw?= =?utf-8?B?MlYzSm8wWnBueTVRdmx2M2hjbVVhek9YZmxUdVBxVFFGdERtNmNJNDJ1UTZt?= =?utf-8?B?dDZhdnJkaUI2ZHlkdE1OZFd0dktsRHQxMHBJbDVrUXQ5U3lkTm1tb1FkNnFk?= =?utf-8?B?dVA1NWNkUE9ndXhGelRXS05qdnRjaFViUlpFRXBoT1VqZ2tFOWthZVoxRzhP?= =?utf-8?B?encwUlRhZXlhNnRXcTF2ZDdvWk92QTc0Uld5MFFacnU0RjYyd1A3ZEo0Y2xw?= =?utf-8?B?Tm9Sdk9qL0l1Q3ZuNHdEeFBrSFNsRE9VREVnM3hXbFd5SDkrL3BLYnV2bGR4?= =?utf-8?B?MU9VSk9Kc2ZKYkdrSmY4dTBPZi85TDJRalZ1Tnhrc1k3SDg3VFJaZDFaUFhQ?= =?utf-8?B?V0NBT0dzLzZZdkZRdVZ6Ukt6dVhyT3BMT2JxeURTZHdqQnpReDR1YU10TFpC?= =?utf-8?B?VGJwN3lIM1EwVjJ6UkNuOU0vYTdVTjU5UTc5d0pYZXRnblRONExrL0srREc1?= =?utf-8?B?VUtVN0NwbUhhdmZCSkc3QjYxSzYvVDdoMlNqalMrK1k2MHUrbDBtWGUvTTFk?= =?utf-8?B?azdQQlAxZnBnVGg4djlSSDZFVXlnWjltbmR5cGl6WDU5MjhoNW55VmJEbUhN?= =?utf-8?B?RFJldCttRVlBNjhHb2g5cjRnbHVqTEM3ZiszbkFHWjE2OTVUbGdISnhLem96?= =?utf-8?B?dG04a0Y4WDhyQ09jdWVCRWt1WDNKclVjV3k2eFlGamdCUU9pSDNvQ3pKL3Iv?= =?utf-8?B?eHpqam1xc2ZldHFBSk9IU1YvY2dxOHRMMFlSV01GMUcrZnZvYUlPckJnaTJY?= =?utf-8?B?RkhTUS9uRFlHRklmVGkrM292d0E0QkNtaG8rTzNOMGpqd0VTV1pXbUhSaito?= =?utf-8?B?RisvZGVCRGdQRjQvb1A3elZOaVlicnc4Y0hBS0JLcW00dU1MODRUSlJKamYr?= =?utf-8?B?eW5MWjdqUkhBTmdBeUROeHZUdmNoUTlVOHRldjRReERSUVQ1NHlHK2cxVTRm?= =?utf-8?B?cHVtaXR2YlZWM2ZPQ3UwSFdBc052RWJSWVdTVk11Q3pLQVZWWVVkYWFKZmtO?= =?utf-8?B?VzBJTU5vR2Y4RjBZSDFCRUhzZDIvVC9VQUJOdEJNZHJOQm5mSGhFWEo0SHV0?= =?utf-8?B?YnVQeDBqU09WQWFTd2FkZS93dXVqZWNtYVF2eUVjKy91TUFpblRSc014blgv?= =?utf-8?B?eENTRjZieWxwL0JZaUNyYzcyRWRhOTVHWG5ZcU5jVUlHbTFsNW9nQ3B5WHFW?= =?utf-8?B?aXc9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <3B46A8CDEAD330428C214F13784C08DC@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?U2hyS0ZibGdtR3ZiZ3ZzczdrSEphQXI1bHRxL2hrbVdEMlFaeE1DSGNPNjdJ?= =?utf-8?B?RENNWjZMZ045ZUtvcE93QmJ2WDBpRWhwWTYyVEtxMjJLTWNKWnhJOUtFR2xQ?= =?utf-8?B?K3R0eGMvU2J2bzU0alNDYlFoUk11bDhRWjE0Z3NkY2hYVjFHcFhlYWhZeStZ?= =?utf-8?B?RERqaUNud0VYQkxVemhNbHB3NldTQkZURm56Nm1tWHY1M2lZQmIrV3Nvb2V6?= =?utf-8?B?ZjhyY0J6VEw0dFp2RVBNQVkwTnZveCtRRHZDcXNkM1c3Q3ZrZkJ6ZDRDRDQ5?= =?utf-8?B?cUpKMkx6SWtqRUJnRk41SGowWklPUjBVY2hSY3YvYUYyYkM0RFR4Z1J1RWRR?= =?utf-8?B?S2pFbG9HT3ltWTZKR0xKc1VqVks1QTZpckdwQ0RUeXdkdUp0UXVBS0ZBVkJP?= =?utf-8?B?d2M3MkxMdkRlV29NODhnQVdLeGJGVDVJTzZmbGxkRG1WcnArY3VxUjlrdHBz?= =?utf-8?B?aUFXclVMSFZtOGtiQ1NzdFVHWGxtYzkwdHlsVWRyUlpPVVNWcmdXdjVTVHFL?= =?utf-8?B?bXpSSUJUaURmTTh6ZUZLUHoyekYxTVZUM1ZnV2l4K2NHVXJkOHd0Nk5WT2pX?= =?utf-8?B?b0RORWhGWFhXT21yZFFQVEMzc2hNamMyZmJ6c0JUcUNHWWJXeXFLYkxodEJE?= =?utf-8?B?RU1GVGdZdDRsaStxdzZvZ1VvQzNRN0tvbXl4NzM4ckM3TUM0b3JUTHdnY2hG?= =?utf-8?B?MXZuWkg2ZG1CakdndDBxTEZVWmtZdFJ0NXQxN25qbUhwVThiYXhycXBGWUdQ?= =?utf-8?B?QVdyMUlVK2g0VU0wdjB5c3Frdk9vMHFMbWhlMzBYWUVUa1VkUDlucW1OK2dv?= =?utf-8?B?bjZQY0cxbFVaYVF4TmpxTm9rdlovVmttUjIzODFQSnBOZUR5NzhkVjlOZXJP?= =?utf-8?B?emp5T1lmWHNLaDgzaWVKbFgzaWEyVlNyNnJPMzRKbmN4WE5EeUswZUt5YXlL?= =?utf-8?B?VTUwRXpTNjljQWlaa2k3TUY5UVNuVmtkbHg2bU0rbWhVS0RtbnBoY201YkRa?= =?utf-8?B?dDQ3dnQvQ3hpV2FCY1k1WDZuTjNwTWxKbzFsWmU2TUI4OVMyb3ZRbjQvWkhU?= =?utf-8?B?MFNIazJBMFVvZjJwQWQ1OFpSWGhSMGRiUm42MFZ2QkgvT0hMb3FjNkhBTk9w?= =?utf-8?B?cHpoMXk2TzM0MC9MaHRUU3FFemJBT2NYWm9RWEdFWW1SU2x6NWsvRmRKT3BI?= =?utf-8?B?VHhjUXdXdDNaQk5jMEREUGtxRlIwclZkUHNZaEJ4c1NocHBRaldZRGJxdk9r?= =?utf-8?B?clprdCtjZGVsUkF2aGRQd3dIY2JMYURVOWlwakZ4Qk5DcmZUNnMwL3ZQY1hp?= =?utf-8?B?ZXp5YzdJUHNPSWZzakhjcEZ6ZkFjazNGd1ptREpOeTVpMlJQZm5QRWVTRFlk?= =?utf-8?Q?tVAdcBw6gb0rZDsBXJRO8GZUFqKEZyek=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c0626e55-cf4e-4baa-e38c-08daefed2ee5 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jan 2023 13:51:59.8827 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MNIzf08frQaQSTI/ORu48GE5J8F0MxZWmG33bgc0xSvSsRG7fnx7zQL6tYYyF/CoRL3khzW1aFJJ7HVu5QHS00ElyqTxZFuUb1UbkpjRfSY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5427 T24gMDYvMDEvMjAyMyAxOjE0IHBtLCBPbGVrc2lpIEt1cm9jaGtvIHdyb3RlOg0KPiBUaGUgcGF0 Y2ggc2VyaWVzIGludHJvZHVjZXMgdGhlIGZvbGxvd2luZzoNCj4gLSB0aGUgbWluaW1hbCBzZXQg b2YgaGVhZGVycyBhbmQgY2hhbmdlcyBpbnNpZGUgdGhlbS4NCj4gLSBTQkkgKFJJU0MtViBTdXBl cnZpc29yIEJpbmFyeSBJbnRlcmZhY2UpIHRoaW5ncyBuZWNlc3NhcnkgZm9yIGJhc2ljDQo+ICAg ZWFybHlfcHJpbnRrIGltcGxlbWVudGF0aW9uLg0KPiAtIHRoaW5ncyBuZWVkZWQgdG8gc2V0IHVw IHRoZSBzdGFjay4NCj4gLSBlYXJseV9wcmludGsoKSBmdW5jdGlvbiB0byBwcmludCBvbmx5IHN0 cmluZ3MuDQo+IC0gUklTQy1WIHNtb2tlIHRlc3Qgd2hpY2ggY2hlY2tzIGlmICAiSGVsbG8gZnJv bSBDIGVudiIgbWVzc2FnZSBpcw0KPiAgIHByZXNlbnQgaW4gc2VyaWFsLnRtcA0KPg0KPiBPbGVr c2lpIEt1cm9jaGtvICg4KToNCj4gICB4ZW4vcmlzY3Y6IGludHJvZHVjZSBkdW1teSBhc20vaW5p dC5oDQo+ICAgeGVuL3Jpc2N2OiBpbnRyb2R1Y2UgYXNtL3R5cGVzLmggaGVhZGVyIGZpbGUNCj4g ICB4ZW4vcmlzY3Y6IGludHJvZHVjZSBzdGFjayBzdHVmZg0KPiAgIHhlbi9yaXNjdjogaW50cm9k dWNlIHNiaSBjYWxsIHRvIHB1dGNoYXIgdG8gY29uc29sZQ0KPiAgIHhlbi9pbmNsdWRlOiBpbmNs dWRlIDxhc20vdHlwZXMuaD4gaW4gPHhlbi9lYXJseV9wcmludGsuaD4NCj4gICB4ZW4vcmlzY3Y6 IGludHJvZHVjZSBlYXJseV9wcmludGsgYmFzaWMgc3R1ZmYNCj4gICB4ZW4vcmlzY3Y6IHByaW50 IGhlbGxvIG1lc3NhZ2UgZnJvbSBDIGVudg0KPiAgIGF1dG9tYXRpb246IGFkZCBSSVNDLVYgc21v a2UgdGVzdA0KDQpUaGFua3MuwqAgVGhpcyBoaWdobGlnaHRzIHNldmVyYWwgYXJlYXMgd2hlcmUg SSB0aGluayB3ZSB3YW50IHNvbWUgcmV3b3JrDQp0byB0aGUgY3VycmVudCBjb21tb24vYXJjaCBz cGxpdC4NCg0KRmlyc3QsIGl0IHJlYWxseSBzaG91bGRuJ3QgYmUgbmVjZXNzYXJ5IGZvciBhcmNo aXRlY3R1cmVzIHRvIGNyZWF0ZQ0KZW10cHkgc3R1YiBmaWxlcy7CoCBUaGVyZSBhcmUgdHdvIG9w dGlvbnMgLSBmaXJzdCBkcm9wIHNvbWUgZW1wdHkgZmlsZXMNCmluIHhlbi9pbmNsdWRlL2FyY2gt ZmFsbGJhY2svYXNtIGFuZCBwdXQgYSBzdWl0YWJsZSAtSSBhdCB0aGUgZW5kIG9mDQpDRkxBR1Mu wqAgVGhlIG90aGVyIG9wdGlvbiwgd2hpY2ggaXMgbmljZXIgSU1PLCBpcyB0byB1c2UgX19oYXNf aW5jbHVkZSgpDQphbHRob3VnaCB0aGF0IHdvdWxkIHJlcXVpcmUgdXMgZmluYWxseSBkZWNpZGlu ZyB0byBidW1wIHRoZSBtaW5pbXVtIEdDQw0KdmVyc2lvbiB0byA1IGZvciB4ODYgKHdoaWNoIHdl IG5lZWQgdG8gZG8gZm9yIG1heSBvdGhlciByZWFzb25zIHRvbykuDQoNClNlY29uZCwgdGhlIGFz bS90eXBlcyBpcyBhYnN1cmQuwqAgVGhhdCBzaG91bGQgYmUgb25lIGNvbW1vbiBoZWFkZXIsDQpi ZWNhdXNlIHRoZXJlJ3Mgbm90aGluZyBhcmNoIHNwZWNpZmljIGFib3V0IG1ha2luZyB0aG9zZSB0 eXBlcyBhcHBlYXIuDQoNClRoaXJkLCB0aGUgZWFybHkgcHJpbnRrIGluZnJhc3RydWN0dXJlIGlz IHBhcnRpYWxseSBicm9rZW4gKHRoZSBjb21tb24NCmhlYWRlciBjYW4ndCBiZSBjbGVhbmx5IGlu Y2x1ZGVkKSwgYW5kIHVuc2F0aXNmYWN0b3J5IHdpdGggaG93IGl0IHBsdW1icw0KaW50byB0aGUg ZGVmYXVsdCBjb25zb2xlIHN0ZWFsIGZ1bmN0aW9uLsKgIFdpdGggYSBiaXQgb2YgY2xlYW51cCwg bW9zdCBvZg0KaXQgY2FuIGJlIG5vdCBkdXBsaWNhdGVkIHBlciBhcmNoLg0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Fri Jan 06 13:54:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 13:54:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472641.732935 (Exim 4.92) (envelope-from ) id 1pDnAw-0006MZ-IF; Fri, 06 Jan 2023 13:54:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472641.732935; Fri, 06 Jan 2023 13:54:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDnAw-0006MS-F5; Fri, 06 Jan 2023 13:54:26 +0000 Received: by outflank-mailman (input) for mailman id 472641; Fri, 06 Jan 2023 13:54:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDnAw-0006MM-6o for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 13:54:26 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDnAt-0008Rs-7L; Fri, 06 Jan 2023 13:54:23 +0000 Received: from 54-240-197-234.amazon.com ([54.240.197.234] helo=[192.168.4.240]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pDnAt-0001fh-1D; Fri, 06 Jan 2023 13:54:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=UUiwMOZIAOAV5xDV4JldE8+o4vqZBnXwxrWhXML++K4=; b=fK94T02u7bRcydLdw/R/jOy8+0 Xxb7BdpiA9pYRq10fKuoGa48mddIRdT1VzXJRop9KsconihYakVbfRu6b6SnZRxsxxm+R+3elnhDk xC7umJ3LZu/4f7ZmuvdMSObiZMya+wBTrAda8uI0MD4Q0At9PQrU4EP3gCz0by0mqKbY=; Message-ID: <4e577d78-ff2f-3258-99d6-712af3b6330d@xen.org> Date: Fri, 6 Jan 2023 13:54:21 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v1 3/8] xen/riscv: introduce stack stuff Content-Language: en-US To: Oleksii Kurochko , xen-devel@lists.xenproject.org Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis References: From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 06/01/2023 13:14, Oleksii Kurochko wrote: > The patch introduces and sets up a stack in order to go to C environment > > Signed-off-by: Oleksii Kurochko > --- > xen/arch/riscv/Makefile | 1 + > xen/arch/riscv/riscv64/head.S | 8 +++++++- > xen/arch/riscv/setup.c | 6 ++++++ > 3 files changed, 14 insertions(+), 1 deletion(-) > create mode 100644 xen/arch/riscv/setup.c > > diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile > index 248f2cbb3e..5a67a3f493 100644 > --- a/xen/arch/riscv/Makefile > +++ b/xen/arch/riscv/Makefile > @@ -1,4 +1,5 @@ > obj-$(CONFIG_RISCV_64) += riscv64/ > +obj-y += setup.o > > $(TARGET): $(TARGET)-syms > $(OBJCOPY) -O binary -S $< $@ > diff --git a/xen/arch/riscv/riscv64/head.S b/xen/arch/riscv/riscv64/head.S > index 990edb70a0..ddc7104701 100644 > --- a/xen/arch/riscv/riscv64/head.S > +++ b/xen/arch/riscv/riscv64/head.S > @@ -1,4 +1,10 @@ > .section .text.header, "ax", %progbits > > ENTRY(start) > - j start > + la sp, cpu0_boot_stack > + li t0, PAGE_SIZE I would recommend to a define STACK_SIZE. So you don't make assumption on the size in the code and it is easier to update. > + add sp, sp, t0 > + > +_start_hang: > + wfi > + j _start_hang > diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c > new file mode 100644 > index 0000000000..2c7dca1daa > --- /dev/null > +++ b/xen/arch/riscv/setup.c > @@ -0,0 +1,6 @@ > +#include > +#include > + > +/* Xen stack for bringing up the first CPU. */ > +unsigned char __initdata cpu0_boot_stack[PAGE_SIZE] > + __aligned(PAGE_SIZE); Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Jan 06 14:02:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 14:02:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472648.732946 (Exim 4.92) (envelope-from ) id 1pDnIV-0007tw-BJ; Fri, 06 Jan 2023 14:02:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472648.732946; Fri, 06 Jan 2023 14:02:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDnIV-0007tp-7T; Fri, 06 Jan 2023 14:02:15 +0000 Received: by outflank-mailman (input) for mailman id 472648; Fri, 06 Jan 2023 14:02:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDnIT-0007tj-Kg for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 14:02:13 +0000 Received: from sonic316-54.consmr.mail.gq1.yahoo.com (sonic316-54.consmr.mail.gq1.yahoo.com [98.137.69.30]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b4e5bb0a-8dca-11ed-b8d0-410ff93cb8f0; Fri, 06 Jan 2023 15:02:09 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic316.consmr.mail.gq1.yahoo.com with HTTP; Fri, 6 Jan 2023 14:02:07 +0000 Received: by hermes--production-ne1-7b69748c4d-drrwg (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 9c3339e25d8418037deac281a90e36bb; Fri, 06 Jan 2023 14:02:03 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b4e5bb0a-8dca-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1673013727; bh=QMiqbDC+61V0Rk1soqHizYsaVxM0KkrnEK/KqG2Ugb8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=dLAt+wG+AyS1eswmXsp5/JpM8WzoW7JftDUt75LKqmPdXJMNjrJ+X8tamc0AMvXCAJzg44JNG2wjaoiHH5WBuTlmtpmcGaUFUwCgafgcI/eTaEOJqPvX4pceIDcHuDujxnqQ6nsAb+YPjblGec1CU8A2mfeuFeKAPX33Hh7jtAsdnSK+d0QfIWLK1R/1I8nRNzh8Eo7smxOsBZdpfgwlH5GaEiJ+hkQQceNJ0RIY7mI/DkEF1kAUMI9jmm+Ra92xeiLNDuRdoNM4RQcdJOzw7Nrg2CJkr9nyaQEVDM4U0RcBfrRBiinyfO8po7oZ2/bBdFZSiJAOwdX+Ve7aVc2jFw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1673013727; bh=fjn70Kv45ZJMgPFlTmq03reHzYK2FHDh7LA5QD2tKRq=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=eBbavZuE/LSY3h0hfEpwWkd5JzmX1KdIFJhJypq+p6NWXEyP8/40yIV3C8H6hbh0QMg2FT5qRZi7ChdpfUYnOBiCVzR4knG9SYG/52GPiUV4nyRDmPcdW5B8SOzdeXlhOnUEfBiYE6IFLXueWU2k571HSgx3Xqvpty//uPjS/0dqJLrlDGQpOcUJt+9lZ+vhYSSfZ8YUlwb0WtpptzvYlpjut9oXk+MQs34Yqeyg88oGISdfQ3hEYrlJADIR7w/zBIsGLM93g51fqVu+ImoSikfuYDrLfpiBAQ8j02ZSQmnaS2EBk4AslLPGj6AZ5bGwvrlO5TrDABOeZJqukpphHQ== X-YMail-OSG: kL_u7lEVM1mSuxyTPDJDIPhacyL5.wwB7HAKS.TTZJ3MJ8qexUFUuMzLjITEqnB LGYRdsSwR.icbCUrgwz6Zfag0x0viZLWqCbigG9KM3v29JJKNn8lpXW7zwatfpotniG2rmNapqNF aA25xqC1BeJi6nsAAYfLviHaRhuNn.Mmj8CmyO_.CKHw709Eu0h1kHueCoWrdYwy_hg7Tcj_R_U4 j.xPKFgsvyql7xBvGc5HQCgaHoDpIh5.6p1CPVOypryqGJLe.ax9wLTGECxXomkquXZ9hcjDspw8 q7UTTJMqxQUxnEXyPlol9wdSEXUrAaU2GIx7ARbBsMnzuII8YTKq95D7Lqo_3mmjmwy1n701FEtM T56TOJbFgLDtTf0pPHzdSP93KZ_GuzUhI3bweWKIWSeA3vVGEH5NItGWlCrGRSnQvyOGyHne5jsv TcNIsxdYplNMzQTRiqa.0zCwF3oyvpOVC2T864OptM5Hf9hps_K9rWX5HHgpos1xQtFts7RHph4. ZpIS8WH1Wwi49sbChVivclNu9UNiuRuMrxEV8KpRbUoNUEg_9iTjjzh5hC_NlyyiB5N6_qaiL1tm zvKUQCkEQC1jfs9.L1Gom71krC6.N1L0ypU.52biP.ICCN021Fj5NAFwbBxE_yd9IAtPTCBzflFj I4RCvqIZiag1lTbup66UJ5H_A6300xI4WI1O3lzNvLQK_2hmWEWxzjC2CfUMQXzZ.CqJOCuaXxIu qLlewqRMM2JAZj_7tiucsyJKWZadcG1lYqb3maloSG1jGzVGg_l7KEBPsenqh57SmSSuM6bdT0gt DQ35edZCwbV9e26IcMaKamWn4QHBXbgDZnF8CahIHbfcPdnPHkDPjhwPVyjaQppMggZfuIehXHDH qbzQsRj9vGYhvTUUmhONIHamvZMLYOZ7doo.DbjVJNlMqVaKuJFtkB6PxZm5cWuowJsqvEYw7LPB c3IexELiJ.OhtIho7J8Ppqthsog4ou5TpcmRBRMqGu0UgyQ6O3vMuDu_dbUSR2nILA3tzXjAPeG_ udUyIaboyu3JKEMxtzRh6dK_asTLRMZG6RWNHByp4t8og_JIc8oG37Tm54zQ87exEyenS7EmUNDV Z2SyUPBkH9EYVHkCSQTA7_RuHYhz6wgNHwo2Iq.qaWX4WZe4guuiJXMZKqQ405xUzlV0AebbCOQw gijuKRQy.ifIIlr0GHF8Gp9_VCXhFQqqNoiSyjPgPAD.hUD8dUc8h.IaYCUKhQidUV9RzUeCX258 rbvKHSERMyIl7pUdlAe25EQAt9pY.TYGCTBNjiVaAibZh61QJqHt43KnntB6fp5x2psHy9LKZ5vt Eh5hZBOI3O6ZKTFedrgAU_1zoS1WOuCK0DCLPiwWqEwZ.8KDxvASj9lc2uuIrfpZXAvqEGVKkmTE UguYnHhRglmLjuZKzmgkA6kr36odmO6.5YXtVgvPs9DPlwFaxC.EM51yEint_zQlwuXjchDdNfcL 0OREZXjCo.1L3RdlB1DDK2UJdt2k92DXkxM8r17o2XG_mGrxQz265t1t708lT5HT1FEc_XPuumTs L5Jtn8y_oWe.dwy_eCMCiRNkhCcNeU6r2QXkp5zhsFqG6X0Z0qL_LPYj3cGzLTTPkLanvZ8km7_H aEP9bDwhuusHtcDRSxeFOvE_N5oj3X8.FYIglmOYOVbgHJpOtBaw0x9gW9eJARMmIO850_hBanFx tto.6eCvifmjdq9el8r_Ni2_.0gYdJUzf.pzJlF_Ix8NW9DWGaEKtH.e8WkiedDU3.nUIDdr2kgu 2UdELYF8wzVpEVgLkJxVYws4x3dJ4U0pMqwv.JTkaq0dOmjfFIOfwqDFwvepjN2NKJdXXgIepCdG iip1d09s6DBlani6fCrBEQM1yiVWnJju3joYXsCTiBCa9_fok4A31nMPLJB48y_s3jn9iZQC2kZb O32YH0KYXccuKQp8ft2_2TrVELhtde9jRVeVDl4a3DWjlDdodsM6UxPxqXJt.VM5jWyS_zHKbkJi uIXPZZcQWp9QVudpBursAaizFm4Sa2nWOrUbzhYckQKgHpduVVAvwedRZu.fDBpshQfd7ks7eT07 sAw_BBN2CeG7C7Vc4_yOXj6NgVtmgdnVjsSGb89Oa92JrngjFaoakBYryALp7rULImuEwgCL6DA6 lzL3h5jN99AQqPyP8EUuHRmu0MBpQ11M4kopPv2h_5PYiEJeY5DMLst6Qzm8oOlKEZ0EuKmtLnCo Pr91k.igyTehyYw-- X-Sonic-MF: Message-ID: Date: Fri, 6 Jan 2023 09:02:01 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v6] xen/pt: reserve PCI slot 2 for Intel igd-passthru Content-Language: en-US To: Anthony PERARD Cc: Alex Williamson , Paul Durrant , "Michael S. Tsirkin" , Stefano Stabellini , Paolo Bonzini , Richard Henderson , Eduardo Habkost , Marcel Apfelbaum , xen-devel@lists.xenproject.org, qemu-devel@nongnu.org References: <830263507e8f1a24a94f81909d5102c4b204e938.1672615492.git.brchuckz.ref@aol.com> <830263507e8f1a24a94f81909d5102c4b204e938.1672615492.git.brchuckz@aol.com> <20230102124605-mutt-send-email-mst@kernel.org> <20230103081456.1d676b8e.alex.williamson@redhat.com> From: Chuck Zmudzinski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.20982 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 3673 On 1/6/23 5:52 AM, Anthony PERARD wrote: > On Tue, Jan 03, 2023 at 05:58:01PM -0500, Chuck Zmudzinski wrote: >> Hello Anthony and Paul, > > Hi Chuck, > >> I am requesting your feedback to Alex Williamson's suggestion that this >> problem with assigning the correct slot address to the igd on xen should >> be fixed in libxl instead of in qemu. >> >> It seems to me that the xen folks and the kvm folks have two different >> philosophies regarding how a tool stack should be designed. kvm/libvirt >> provides much greater flexibility in configuring the guest which puts >> the burden on the administrator to set all the options correctly for >> a given feature set, while xen/xenlight does not provide so much >> flexibility and tries to automatically configure the guest based on >> a high-level feature option such as the igd-passthrough=on option that >> is available for xen guests using qemu but not for kvm guests using >> qemu. >> >> What do you think? Should libxl be patched instead of fixing the problem >> with this patch to qemu, which is contrary to Alex's suggestion? > > I do think that libxl should be able to deal with having to put a > graphic card on slot 2. QEMU already provides every API necessary for a > toolstack to be able to start a Xen guest with all the PCI card in the > right slot. But it would just be a bit more complicated to implement in > libxl. > > At the moment, libxl makes use of the QEMU machine 'xenfv', libxl should > instead start to use the 'pc' machine and add the "xen-platform" pci > device. (libxl already uses 'pc' when the "xen-platform" pci card isn't > needed.) Also probably add the other pci devices to specific slot to be > able to add the passthrough graphic card at the right slot. > > Next is to deal with migration when using the 'pc' machine, as it's just > an alias to a specific version of the machine. We need to use the same > machine on the receiving end, that is start with e.g. "pc-i440fx-7.1" if > 'pc' was an alias for it at guest creation. > > > I wonder if we can already avoid to patch the 'xenfv' machine with some > xl config: > # avoid 'xenfv' machine and use 'pc' instead > xen_platform_pci=0 > # add xen-platform pci device back > device_model_args_hvm = [ > "-device", "xen-platform,addr=3", > ] > But there's probably another device which is going to be auto-assigned > to slot 2. > > > If you feel like dealing with the technical dept in libxl, that is to > stop using 'xenfv' and use 'pc' instead, then go for it, I can help with > that. Otherwise, if the patch to QEMU only changes the behavior of the > 'xenfv' machine then I think I would be ok with it. > > I'll do a review of that QEMU patch in another email. > > Cheers, > Hello Anthony, Thanks for responding! The first part of my v6 of the patch only affects the xenfv machine. Guests created with the pc machine type will not call the new function that reserves slot 2 for the igd because that function is only called when the machine type is xenfv (or xenfv-4.2). But the new functions I added to configure the TYPE_XEN_PT_DEVICE when igd-passthru=on will be called to check if the device is an Intel igd and clear the slot if it is, but this will not have any effect on the behavior in this case because the slot was never reserved. Still, this would add some unnecessary processing in the case of machines other than xenfv, which is undesirable. So I can add a check for the machine type to a v7 of the patch that will skip the new functions that clear the reserved slot if slot 2 is not reserved and therefore does not need to be cleared. Would that be OK? Kind regards, Chuck From xen-devel-bounces@lists.xenproject.org Fri Jan 06 14:04:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 14:04:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472655.732957 (Exim 4.92) (envelope-from ) id 1pDnKE-0008TA-Lx; Fri, 06 Jan 2023 14:04:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472655.732957; Fri, 06 Jan 2023 14:04:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDnKE-0008T3-Ix; Fri, 06 Jan 2023 14:04:02 +0000 Received: by outflank-mailman (input) for mailman id 472655; Fri, 06 Jan 2023 14:04:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDnKD-0008St-1X for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 14:04:01 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f67f4809-8dca-11ed-91b6-6bf2151ebd3b; Fri, 06 Jan 2023 15:03:59 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f67f4809-8dca-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1673013839; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=DJMl9lyCpvXVrpBfjxQaBv2r/oW5Se5HYnobbelCQy4=; b=epOnTaofThDJkCAZfopEpRQFBFaGItTRZHFdA7DlrkFAL0MhBQeMAM8p QDgYw8aY2IE1z56cnS3cR5ww2u6nyFlzmLQ5JNvn4eoulFfjFH2274UVU kslua9c+73eQ3zCuf+M7yB1yownobN/904frTtebFrBCctXUbPbhX4d5Z A=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 91894645 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:qjrk46/Sj8krt9LOfMKhDrUDMH6TJUtcMsCJ2f8bNWPcYEJGY0x3m mIeXGvTOPnbN2qned4iOonjoR4A7cTWxtYxSQM6riE8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKucYHsZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kIx1BjOkGlA5AdmPKgV5AW2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklM3 NNDFBMwXCq+lv+N/+KkZ/JKv5gaeZyD0IM34hmMzBncBPciB5vCX7/L9ZlT2zJYasJmRKiEI ZBDMHw2MUqGM0Yn1lQ/UfrSmM+hgGX/dDtJ7kqYv6Mt70DYzRBr0airO93QEjCPbZQMzhfE+ D6bl4j/Khwlb4av1hikyGyxi8HOmA7BBplVSKLto5aGh3XMnzdOWXX6T2CTrPWkg1SyXPpfI kYX/TEy664/6CSDVNj2XxSirDiEsxgQVsBLFOsS7ACLw7DTpQGDCQAsSyVdQMYruM8/WXoh0 Vrht8PkA3ljvaOYTVqZ96yItnWiNC4NN2gAaCQYCwwf7LHLpYgphR/LCN97HqOxhNToHBn/x jmLqG41gLB7pdcG0rj+8V3ZjjaEoJ/PQQgooALNUQqN5BlyZJOuZJ6A4F/fq/1HKe6xVUKdt XIJn8yf6uEmDpyXkiGJBuIXE9mB//yCNi/dh19HBZQt9z2xvXWkeOh4+DhjIG95P8BCfiXmC HI/oisIusUVZiHzK/YqPcThUKzG0JQMC/znf9+PUvlzUKJMZRK8w3FxSFW25jzUxR1Efb4EB b+XdsOlDHA/AKthzSarS+p17YLH1hzS1kuIG8mlkk3PPa62ISfMFOxbaAfmgvURtvvsnenDz zpI2yJmIT17Wfa2XCTY+JV7wbsifSliXsCeRyC6m4e+zuta9IMJUaS5LVAJIdYNc0FpegDgo BmAtrdwkgaXuJE+AVzihopfQL3uR41jinkwIDYhO12ls1B6P9n1vftEKstmIeh2nACG8RKSZ 6NVEylnKq0WIgkrBhxHNcWtxGCcXE7Daf2y09qNP2FkIs8Iq/3h8d74ZAr/nBQz4t6MnZJm+ dWIj1qLKafvsiw+VK46ntrzlQLu1ZXc8couN3b1zi57Ih20qtYyc3ah0pfa4agkcH3++9dT7 C7OaT9wmAUHi9NdHAXh7Uxck7qULg== IronPort-HdrOrdr: A9a23:l907BKm4XICYeUhJ1BKpyShd6wnpDfIT3DAbv31ZSRFFG/Fw9v rAoB1/73TJYVkqKRcdcK+7UpVoLUmskKKdgrN9AV7BZmXbUQKTRelfBO3Zslnd8kbFh4xgPM lbAs9DIey1Ll5wjcuS2njaLz9a+re6GVeT5ds3oh1WLD1XVw== X-IronPort-AV: E=Sophos;i="5.96,305,1665460800"; d="scan'208";a="91894645" Date: Fri, 6 Jan 2023 14:03:52 +0000 From: Anthony PERARD To: Chuck Zmudzinski CC: , Stefano Stabellini , Paul Durrant , Paolo Bonzini , Richard Henderson , Eduardo Habkost , "Michael S. Tsirkin" , Marcel Apfelbaum , Subject: Re: [PATCH v6] xen/pt: reserve PCI slot 2 for Intel igd-passthru Message-ID: References: <830263507e8f1a24a94f81909d5102c4b204e938.1672615492.git.brchuckz.ref@aol.com> <830263507e8f1a24a94f81909d5102c4b204e938.1672615492.git.brchuckz@aol.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <830263507e8f1a24a94f81909d5102c4b204e938.1672615492.git.brchuckz@aol.com> On Sun, Jan 01, 2023 at 06:52:03PM -0500, Chuck Zmudzinski wrote: > Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, > as noted in docs/igd-assign.txt in the Qemu source code. > > Currently, when the xl toolstack is used to configure a Xen HVM guest with > Intel IGD passthrough to the guest with the Qemu upstream device model, > a Qemu emulated PCI device will occupy slot 2 and the Intel IGD will occupy > a different slot. This problem often prevents the guest from booting. > > The only available workaround is not good: Configure Xen HVM guests to use > the old and no longer maintained Qemu traditional device model available > from xenbits.xen.org which does reserve slot 2 for the Intel IGD. > > To implement this feature in the Qemu upstream device model for Xen HVM > guests, introduce the following new functions, types, and macros: > > * XEN_PT_DEVICE_CLASS declaration, based on the existing TYPE_XEN_PT_DEVICE > * XEN_PT_DEVICE_GET_CLASS macro helper function for XEN_PT_DEVICE_CLASS > * typedef XenPTQdevRealize function pointer > * XEN_PCI_IGD_SLOT_MASK, the value of slot_reserved_mask to reserve slot 2 > * xen_igd_reserve_slot and xen_igd_clear_slot functions > > The new xen_igd_reserve_slot function uses the existing slot_reserved_mask > member of PCIBus to reserve PCI slot 2 for Xen HVM guests configured using > the xl toolstack with the gfx_passthru option enabled, which sets the > igd-passthru=on option to Qemu for the Xen HVM machine type. > > The new xen_igd_reserve_slot function also needs to be implemented in > hw/xen/xen_pt_stub.c to prevent FTBFS during the link stage for the case > when Qemu is configured with --enable-xen and --disable-xen-pci-passthrough, > in which case it does nothing. > > The new xen_igd_clear_slot function overrides qdev->realize of the parent > PCI device class to enable the Intel IGD to occupy slot 2 on the PCI bus > since slot 2 was reserved by xen_igd_reserve_slot when the PCI bus was > created in hw/i386/pc_piix.c for the case when igd-passthru=on. > > Move the call to xen_host_pci_device_get, and the associated error > handling, from xen_pt_realize to the new xen_igd_clear_slot function to > initialize the device class and vendor values which enables the checks for > the Intel IGD to succeed. The verification that the host device is an > Intel IGD to be passed through is done by checking the domain, bus, slot, > and function values as well as by checking that gfx_passthru is enabled, > the device class is VGA, and the device vendor in Intel. > > Signed-off-by: Chuck Zmudzinski This patch looks good enough. It only changes the "xenfv" machine so it doesn't prevent a proper fix to be done in the toolstack libxl. The change in xen_pci_passthrough_class_init() to try to run some code before pci_qdev_realize() could potentially break in the future due to been uncommon but hopefully that will be ok. So if no work to fix libxl appear soon, I'm ok with this patch: Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Fri Jan 06 14:11:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 14:11:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472662.732968 (Exim 4.92) (envelope-from ) id 1pDnR4-0001V1-Dd; Fri, 06 Jan 2023 14:11:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472662.732968; Fri, 06 Jan 2023 14:11:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDnR4-0001Uu-Aa; Fri, 06 Jan 2023 14:11:06 +0000 Received: by outflank-mailman (input) for mailman id 472662; Fri, 06 Jan 2023 14:11:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDnR2-0001Um-TU for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 14:11:04 +0000 Received: from sonic314-19.consmr.mail.gq1.yahoo.com (sonic314-19.consmr.mail.gq1.yahoo.com [98.137.69.82]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f1e92323-8dcb-11ed-b8d0-410ff93cb8f0; Fri, 06 Jan 2023 15:11:01 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.gq1.yahoo.com with HTTP; Fri, 6 Jan 2023 14:10:59 +0000 Received: by hermes--production-ne1-7b69748c4d-drrwg (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 75201934fc037ba28ec21f3880c24bd7; Fri, 06 Jan 2023 14:10:57 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f1e92323-8dcb-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1673014259; bh=xZI1yY4P5g0p968nUuIlQk/jsifkHbagJgWbktARJJs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=lR0BeB9Tn7zcvH0HFlBbQLMP47nxkx3bpuNUBpb/CRKm6KYDq2LmrmxVmuisubjdkLDmRiKQM3fVS3N0+RYI0sCd1KWMHBjhdpNk4Ibd8x6ixs3l6Z9QsVkqQKPymjRNL9vIpVySXsAHGJ/xtBK6eR8i4yQaFIsed4RfZeH5mGs5F7HivoowFs6QVF+pegV2Bqu1xOI7ZbYHfAxqVxRuyNpTc8PMzbWnAkSdNbqjQpBbTC7c6YPI7WT1R8GP4oZmq6leFlRM80ZiWd730atom8/D5kYNqvKAGuMr8ltB/zQg5pi+x5lI5unN65Pc4IMG5qk7Mk7lOkM+YlfAGKjA5A== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1673014259; bh=4l8UCGyy/Qck99GFchfUmSKlEoCFcyg2e9lXbploMDp=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=bVAgo5krm8BjB3DF7tEI9BWpA2ME3BtDZsxWOI5zHEFGxahdosrYxX/0tJbJdaTzoe8iwoHnjH2fxDW5mQg4VotplGgqbr5W5U3dfGglVCI7RD6nyhBT9wgoNRLkM17nD1GZYAD6qYpcq4vF8X7zA21wNmTnq3nnHu9VM80D0rHp3eFmofpnPwZjYNMKjLCrvmcm9vUd9UdDI8sc2TM4nl1cSmf9BElmf07JDJNx+RNUe0uoHYfnHrJ9FPmWpKF4A5FncU0lvR0+wbe1SSpiVBa3HK1UWbQnXJVqW0UPVls/OpwFn7xR25wgbn7JDvxONf5f10ZcZK0UtR5Y+PrKNQ== X-YMail-OSG: 0OFH0ewVM1mftW2s2coCmnaLRsU0Dhyc8.M9VsbDNnBZkYxz0PWBssajaKQeqPW QxMvj.gd6PxIigg73v8abgaT3E0g1sd9DNMNLSdrsGUky6zzoruHxaUwpdSeh3SuTzXWEKxW8tjL N8FXCYRMa3ITayDWYnY0ARXc9K7DtHGoCBbl.jFcj9dfllN6Evh4J1FuBGTcHUz50kP8pMx_zWHt P.2_.L0zUB5uaan0L.94pa7LapxPM1Wp7xTPFkGObwc7GkUjDH9qKHyaTV7dFdQqfyDYJh.uL8hI _toph2f6V6BXy9bp7.juYqRDUPfpYeurpsaIqHtvrmVCX2WB6uOU9BSP1zoVbFZF2RqSpuuwpRAw M8edg2RHk6jgUpHeRm1SXj4NFyu0ouRH4OoWsNPlTrjOFBZBrOOIjtZwJlT8JIKDCHDLVmstPj3J OHMkAE2T85feZT.apQK1OcDfwc3DOYS.lpqDTlZmlk4eP84W30WI2IArPuht2Lm5f4zyOkTFYwqq b_Z691WTWgWxLTZnIbneNG1U3P0qm0E1gh_mPkN1jqWtjblbsOOukFn0QfJZhqdmiW4QAn_sXZpG HUIb3WkjRhJuvRpsZUAzMAlJD.wgO0vUqrgTOhbFCjhOWRHUob.AohyND_Ue8knNfaaeiQ3WnzoC 4UAuAwXGA5OdJ1DoFnUlC3hnDzcyEKr87DyL_2JH48wU0sZnXM0RrSyH24q0SUQUgGnxMF1qWj12 V.OZ9V6RJhpzMCAceS6xUyhGtp_FFGmkY_g2ev_NWZWjauhEgSi6QdI7.LTxtV0.Uv_PaUprsyiA 9xLeiKnt0PpDU_2aukW8nqlghceLtcc763MUorxONgakXuil9p46KegJ7F6xEaXwJqyD1vYF5sPg j4BqjrAPgAOhsyjfIp0A88Q14_S5NvOFWbjjYtwmqT0fNCzK3cjS5lU_mKgpiV6KqFDhPWYYGxB7 lVj_998vL2GGzysHLJ29GmsIRh6NU1c9WVJRGWeY9WWXa8XUuL3BD2UMUP6CdMjgFRWTwelQ_JZo dFGtMvLB8Y94Qgyla4FREJ1CZN0VLKmrUSXjBi6CrNXQsWd5u1p6hahYnb0aBEgmtH1m7cF5iaLD 1WvDweiD1HiyJM82sqBPsayddI7uzbHNiPYf3ssWoEPu3RPuBpq1rrvJA2FitkwFGLGSdxhOTahT VQ_dKcHWSWjKs4QqN57g4MBo_bpg1KBzWKi53M8ooZIkNyEXlEGOfrdOH2rGKq2BzYXXGE408s9Q Ho3OWejwKeU.wlazhgIt6HqyuNJymQh_ZRpoNuHbx6TSM9CgtdYQxeDS.cymE5IB9T47ruQr1iTQ BX27eL9J9KfyJKFV.kMfs6n_tMoG8ecoKp4TTX9PCsdE05EK2a0G9k.y98pMi.HVAvXG5.Fit_Vc MepzWz8zxvK_Pk7AV2DX_uIUgAEURFTfSE2_ngGKi_Q9tKeZNu5BjTWwr9KuVAjX1iK7nNZXYEuc m6SIxSQd14mVMsZMX3JA2UDkSipVYg6ztngUbKhud99..GJbgcKdiJ1XOhqjbBbeCBLJBatTAImo lp8_HdmsvIDi182HzhoL2kgzOVLzrhgr6sOr__v7OWMLJ5CQlFO8IpKTrafMte25yhmbmFzsXlGR 2u7pQJFejp8NhgBfkR2Vq9styImQmBtvECpnQxxeREwvBXdnq837wGfbVu.Aa8BjNKVG11BeanBm oRYKLxECr76s858b17b5Iseh_c8_eFrpT70Arp3d2uCnXhxeaMyPrNyVTfH0QNX33mrnGnenWbYw d38wq0SRbbjB4AMvfyHnlbeu1US2QahPviWgZk1ZB45qz5Uk9CeuPuEYqqgfgevFM_NSZrwuNDp2 2zNyEdM8NrhLO7NWb6qXp9fFYwrzvLn7GTdTzazHNNLtqhFIhIS0.rwRJ_gh6Yn9wAd6FomCm6YC SoDdVybM1jk8R5PsG3Iqi6chFHSmulNc4yVEcX7kH9aMSfk8_A8g4m3CB2coSq_xW0U591uaonkH FMB_lZ1bCUjEZylepkNHNkRjmiWvPU4dFdxwrl4Io7yCb7UAKsbsE8WR8GeNhXxRc5Kee066pGRq xKo5xR4Yg7JS77W0_6ydCh2o5KTMq0PolaUa0bJf9GPPObz02MSyEWgw.QKelLXx_saKbqIU6MaM B3QxQ_ERfvKDh30WclrVO.3DQptRJfYpRfy3LVOvTqyg5gGC7lTaUYgJ4jXGmn8ogA8d.H.Ce4X5 j.hiX6gSlXQ-- X-Sonic-MF: Message-ID: Date: Fri, 6 Jan 2023 09:10:55 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v6] xen/pt: reserve PCI slot 2 for Intel igd-passthru Content-Language: en-US To: Anthony PERARD Cc: qemu-devel@nongnu.org, Stefano Stabellini , Paul Durrant , Paolo Bonzini , Richard Henderson , Eduardo Habkost , "Michael S. Tsirkin" , Marcel Apfelbaum , xen-devel@lists.xenproject.org References: <830263507e8f1a24a94f81909d5102c4b204e938.1672615492.git.brchuckz.ref@aol.com> <830263507e8f1a24a94f81909d5102c4b204e938.1672615492.git.brchuckz@aol.com> From: Chuck Zmudzinski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.20982 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 3563 On 1/6/23 9:03 AM, Anthony PERARD wrote: > On Sun, Jan 01, 2023 at 06:52:03PM -0500, Chuck Zmudzinski wrote: >> Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, >> as noted in docs/igd-assign.txt in the Qemu source code. >> >> Currently, when the xl toolstack is used to configure a Xen HVM guest with >> Intel IGD passthrough to the guest with the Qemu upstream device model, >> a Qemu emulated PCI device will occupy slot 2 and the Intel IGD will occupy >> a different slot. This problem often prevents the guest from booting. >> >> The only available workaround is not good: Configure Xen HVM guests to use >> the old and no longer maintained Qemu traditional device model available >> from xenbits.xen.org which does reserve slot 2 for the Intel IGD. >> >> To implement this feature in the Qemu upstream device model for Xen HVM >> guests, introduce the following new functions, types, and macros: >> >> * XEN_PT_DEVICE_CLASS declaration, based on the existing TYPE_XEN_PT_DEVICE >> * XEN_PT_DEVICE_GET_CLASS macro helper function for XEN_PT_DEVICE_CLASS >> * typedef XenPTQdevRealize function pointer >> * XEN_PCI_IGD_SLOT_MASK, the value of slot_reserved_mask to reserve slot 2 >> * xen_igd_reserve_slot and xen_igd_clear_slot functions >> >> The new xen_igd_reserve_slot function uses the existing slot_reserved_mask >> member of PCIBus to reserve PCI slot 2 for Xen HVM guests configured using >> the xl toolstack with the gfx_passthru option enabled, which sets the >> igd-passthru=on option to Qemu for the Xen HVM machine type. >> >> The new xen_igd_reserve_slot function also needs to be implemented in >> hw/xen/xen_pt_stub.c to prevent FTBFS during the link stage for the case >> when Qemu is configured with --enable-xen and --disable-xen-pci-passthrough, >> in which case it does nothing. >> >> The new xen_igd_clear_slot function overrides qdev->realize of the parent >> PCI device class to enable the Intel IGD to occupy slot 2 on the PCI bus >> since slot 2 was reserved by xen_igd_reserve_slot when the PCI bus was >> created in hw/i386/pc_piix.c for the case when igd-passthru=on. >> >> Move the call to xen_host_pci_device_get, and the associated error >> handling, from xen_pt_realize to the new xen_igd_clear_slot function to >> initialize the device class and vendor values which enables the checks for >> the Intel IGD to succeed. The verification that the host device is an >> Intel IGD to be passed through is done by checking the domain, bus, slot, >> and function values as well as by checking that gfx_passthru is enabled, >> the device class is VGA, and the device vendor in Intel. >> >> Signed-off-by: Chuck Zmudzinski > > > This patch looks good enough. It only changes the "xenfv" machine so it > doesn't prevent a proper fix to be done in the toolstack libxl. > > The change in xen_pci_passthrough_class_init() to try to run some code > before pci_qdev_realize() could potentially break in the future due to > been uncommon but hopefully that will be ok. > > So if no work to fix libxl appear soon, I'm ok with this patch: > > Reviewed-by: Anthony PERARD > > Thanks, > Well, our messages almost collided! I just proposed a v7 that adds a check to prevent the extra processing for cases when machine is not xenfv and the slot does not need to be cleared because it was never reserved. The proposed v7 would not change the behavior of the patch at all but it would avoid some unnecessary processing. Do you want me to submit that v7? Chuck From xen-devel-bounces@lists.xenproject.org Fri Jan 06 14:12:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 14:12:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472669.732979 (Exim 4.92) (envelope-from ) id 1pDnSa-00026n-Rq; Fri, 06 Jan 2023 14:12:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472669.732979; Fri, 06 Jan 2023 14:12:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDnSa-00026g-Or; Fri, 06 Jan 2023 14:12:40 +0000 Received: by outflank-mailman (input) for mailman id 472669; Fri, 06 Jan 2023 14:12:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDnSZ-00026a-6O for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 14:12:39 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2046.outbound.protection.outlook.com [40.107.21.46]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2b231ddc-8dcc-11ed-b8d0-410ff93cb8f0; Fri, 06 Jan 2023 15:12:35 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8804.eurprd04.prod.outlook.com (2603:10a6:20b:42f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Fri, 6 Jan 2023 14:12:34 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5944.019; Fri, 6 Jan 2023 14:12:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2b231ddc-8dcc-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Die09GvshbmyQ/BF8x9nlKVsSsQbaHL7K0SWsZT90Gedjo0lfYfKqc13uC2bFmwhbKLL1PO+8rdKKaunANu1T7QkNzaiWOuwIvWH7MeFK8HJg//f9NeTERdeKvZhteUFWgibMsC2qWAJ6ISfijp9OXKNkOJVruNoihTa/NvGwu/kI+/7K984XjP/rp0+JJipQii07ct8jBSet4tL3qLG5Fbh/vOjhTO+Ywbg8q8cNfgCICak6Qb1P0QAxCjKsSGbH5n4tuoR+TIKKD/Tq2DypBNy7P1HqdmVohjqasf6JWXm2HwZ3OsPUzAO2BRNOkS90vk1dpK7THyoiTYqFcEILw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FacX2mzZ5EiF0EJmp6Q13pLRP+eKFI0c7R9yu/clnsI=; b=SGHJmvCx1JS0T6dQ0q99/WYFDrMRNGbqqimfdGAyxhTuy/4asU4B8hiLbUA/bWGMmMNvEN/7B7EaAfU60EhaOdKdAuTWKRqy/zZx+CgSKgLkuPaiQARNTw/RO191Yt+jVkZ/RCqD5R/CXFJbOC+BVkdTNlEK3xmW6fkQh3GRlqsnwEJ8eTyoNP8GCfsUfMxjNPDwDzfdpmHjpGfY/UUKEi8D9B1Aja8N/4CZNBEPiJaM9JnMjY42mMTEGhRODUCiBpxG4yblQ67QBwlU3+MQczE2X6EaOr3u10u1n/PWjSFxDjMT/UA9D+YAFR9kScDXGAp84uQrvz7GwKyTNCoV5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FacX2mzZ5EiF0EJmp6Q13pLRP+eKFI0c7R9yu/clnsI=; b=soDH96wceQd94okvEZf9r9mAZox8uanxRwaWkdC8//K8u1vlFQ3UgPcZqIiKy0xZaLAD8jG5oNDn2SynD6fjZdMC/XfiJBIF4rATyAofIOj7+A0px2yzoGWPr7SAjjvpmBrVfS72UtFr2rhJELSo9TnWxEQFHOwPRXbjf5A80SkpjIOfi/YPD/z6XLjS79M7T61wkXfQkAybSLDiFvd7upMiKpwhoMj/MKYw3VHk9SB9MVnkwEhKp+c3z37bpGXFdZMsZ5d4xsFZiVg+gmoqxL21dNikUYmeh6Mub/k74KWdeGcxFdmClwXwa5sBC7udIPjdqp5mPu3WrDsCUePlqg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <204d2288-df9a-0d53-2c42-a52ad0c0c0f7@suse.com> Date: Fri, 6 Jan 2023 15:12:32 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v1 2/8] xen/riscv: introduce asm/types.h header file Content-Language: en-US To: Oleksii Kurochko Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0088.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8804:EE_ X-MS-Office365-Filtering-Correlation-Id: 7e1f449b-2f90-4230-91f6-08daeff00e72 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +ssqVpAcrNPecd0wGsU3wXCmNnd1mbUfKdQD5oPDudNFTvGjJEdbRHExzNQwTPA911YQj/9NohGSY/8ye4BKfO+fhHWE22x6jR09sYZgZ/EgJVhuStxhY9foWtQQbZ1Ac07/6b9vROuXuZAUorp0aicSHZo+XBmpAafZSgndVEVDNG7RQek7c3nxrfeKPUC1CEBf5H53AIxUrTm6oUOW5RIkPxzczdpHnoPVR1KkjXB/IScFO6h+rwspzDIU0/QruCR8Ts8rC9kBnFLPsMDizbfs07j1MHR5E3clst+a0NqAjfD1gP93c0LfHiVknG5evHTjaXWnfcZMGeyDmIkcgiuKqZRhjpNCiOILsC54NbTqUmZqZPqX67VuYW8VP+6rwuGEIHIQFB9+hoDG87CbPxGgpD5Iyt4O3JcG1s/TwU/VGeiri3ljFf2uq+YsnzNvLuEy5/FOjUlManUrbRaD5WcVVucJvAr+eSrB6mUKFLOs6oxqYx+R0YroGOHmtGiH2mKz5MT3nKggKtVyMvFxViJcICTnh2sGeDtEIdW4/4zT6CJq/ptaCPWrCeCY42xvo/Q83tp1Rc8t8yovDQaryJWCNL/weq7MeOjQ6AV9SlHUPd5aCcFs67/FnmcffJzGm5B2FOIE/JNNYIoNHQaB9z9FEn/QWKw3m3d5eyqvRDoWoVTIh+nVm8J/ESDaG5xv5LOg8tuT5girdKQP89XHni99tmtou9QjdmUTTpvW0hM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(366004)(346002)(396003)(136003)(39860400002)(451199015)(6512007)(26005)(186003)(2616005)(31696002)(36756003)(38100700002)(316002)(6916009)(54906003)(31686004)(2906002)(4326008)(86362001)(66946007)(41300700001)(8936002)(5660300002)(8676002)(66476007)(478600001)(6486002)(66556008)(53546011)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OUdhZGtZZkRycHdHYm5PQ2E1Z0FBNTkxdnJVOUJvS2poNTZBWWVLa09aZmk0?= =?utf-8?B?NjVzS1AxMkNRcmQycmxZVklrcVQ5SWVTYmwvc2k0ZGJJcGZkNjlvRW41WThF?= =?utf-8?B?QzNGQTZ4RlBOQTJTZGdCTjBIR3h1cDI1VEpqK2tJT2FUdk9yN3N2SjgwaDdi?= =?utf-8?B?aVVYcnp6UVdkMG5CV0szRlV5b2ZYS1FhQk0zT092dFBDMDNzektETVd1VzdT?= =?utf-8?B?T0Y1ZlFpU3hBVjFlbGFLSHU5bjBCUlVnazd2M1Z0dXkzUFErQzA3RTRrM09v?= =?utf-8?B?YnpHc0JRM2JTREhoTXpxaXc5NHlSUXFNV1lld3RPNW9xWlFVdTcxOUs4eWVS?= =?utf-8?B?QzRGM2dGN2UyaFU2N1lCOTl2aTRqVlkrUm05THV3cXNLL3JTdjltazhDR3Bx?= =?utf-8?B?MTRLZWFEdkFlUlZKZmI0YzF4TG1BTXJzMzY1bitnbWo0cjBQOUlzVkpCR3l4?= =?utf-8?B?Zit1M29KR2gxbE1nMzFXc2lsSEVxU0VRZE9uRnRMRWZtNVZreXRvUFV3NGZ2?= =?utf-8?B?QnByT25LTTliNWJySEZRZFU0dWE1Y2wwTTczQUZKVnRUTGpQN05URmU3WnAy?= =?utf-8?B?YzN5REMwSkxiTWM5aWkweXZkZTVnZU9zcFRBdTFlTkYrRThZb2N5L0lWMmcx?= =?utf-8?B?TDN4dllKL2RKU2kvbWR0U0xrTlYwekxiU01IdjBRL1I4MkQ1c3Q3SUtIcTM5?= =?utf-8?B?NHh0UkxzSlE0VU9vbVBYcjZGc3dha1o2S0hHLzBhTlNtUmViY0phdnZSOENC?= =?utf-8?B?OEdjTDBCL1YyQmQycDNnTWR6YTdwVllNZkxOUngzYnkycTdXZ2p3TlppU2Rs?= =?utf-8?B?LzJPSXErUHBVRVF5UXNDakxxclJEUW9YT3pHTHRGZkJXMDJpNmxiV0dPa3VC?= =?utf-8?B?SzNmVWRSTm0ySy9sRk9wUUdYdzlsanQ2c21NUGFYcUtLanErQWRCVVgyVE1y?= =?utf-8?B?NXVIUFBnYy9XMkJ6bE05VjZnbUxWZGRGWHU1eEdQSnhTb1ZLN2pWL252ODBm?= =?utf-8?B?Q1M3K2hDS3ZOS2UvVUFuNFNUL1MvejlFQnR1c2orU2d1Z1BzMGJQU2xOUkIx?= =?utf-8?B?U0hSTy9pMllSMmx5YjNwWGJ2NWtXUHNNNzZqL0N4V0NVRmNXR3NkUWEzMEJm?= =?utf-8?B?ZDZQUHJySGhubWJIRkdnU09pNGNmdTE0WlhYQVNtZHEzSTByT0lRaXRlaUF6?= =?utf-8?B?L2loWE54R0N3R2hDMURGTGpVT1FhYnNXN2ZzQ2twL0tGb2VURDEvTjhjNkhO?= =?utf-8?B?RFhHd3VJeTlFZlhEczVUZUtYQ2ZVVWJpd0Y0Z3NjUEptSXNzVXpydTNoWEN3?= =?utf-8?B?dmErQXRyTExGOW1OMmdRdUhheXp1Z0FEdi9UenRVUTduWE1CRk9zRktsdjEv?= =?utf-8?B?dnVjRXo2TU1lcW9EZDhkczVhaXRRbzBQWkhVb1M5aDBPVk1QQzBwbkhQSWNl?= =?utf-8?B?RGRKaE0rdVBWZFJxUmxBbUxwQnUzck9rNjEvRW9Hb3VRaE9ZdHg3YkdRMU5G?= =?utf-8?B?aFlibTJ3UFhtdkQ5RVZ5K3IyREY2ZVV4eHFLUHZ3KzgrSmdnMHNaZEM5Y0Z1?= =?utf-8?B?d0dyRVB5VWFCVWFFNkhwaExDdFJTeCtjOEFRUW81cWRubnVZRy9KUlg0SVEx?= =?utf-8?B?SHN3cHVWMWVmZDR4ODd4bzBOdU5UZ0QvQ09rM3g0QVRuYnJUb2xFaTZ0NHRs?= =?utf-8?B?dGhwMXh1R28zUzVKZ3l6c1VGd3k3TWFKSUUxRTJua2JLRGRlWjgzYXNVRU9M?= =?utf-8?B?a1pJYmI0bVVRdmZuS25FSkFjNWFVNnE3S3o4c0FWTTBLUnM2MkhqWUlVY3lx?= =?utf-8?B?eUgralYrTk9pVTQzN1NjVGx2NXd3aURSdnlzQkZKdEZxQ1ZibUVDSWE1SERs?= =?utf-8?B?T09YSE0zSlE3Q0ZFUEw0N29saUZMU0dRb0lXU2ZYakFSNnRub0dMN1ltN0FW?= =?utf-8?B?NTMvbENsWm05OVBpNS9NYnVQcEJ3K24zTCtDL2h5NnBjNEo2YUNra0cxZUN5?= =?utf-8?B?S01BN0ZQTzJPQkM4djFuczZPa3JLT3ZiRjB2ZEg0MzB0THlIQWtHcmViMjQ2?= =?utf-8?B?a2ptMHZvdi95aWJ3anNQa21ER2NRUXlQVTFMamdvRkd3a0tlQVRPenFYT3V4?= =?utf-8?Q?YT3t1yGvp4GDIgY5qn2eOq8NI?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7e1f449b-2f90-4230-91f6-08daeff00e72 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2023 14:12:34.1019 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: r72DBgK292McbeACiiYzGlaQWAJ4zZNjA926GYOzng+hnTIG0YJrP3gUi0Vwo8BHpwWm+xrWKDFEqkWwgiLB6A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8804 On 06.01.2023 14:14, Oleksii Kurochko wrote: > Signed-off-by: Oleksii Kurochko > --- > xen/arch/riscv/include/asm/types.h | 73 ++++++++++++++++++++++++++++++ > 1 file changed, 73 insertions(+) > create mode 100644 xen/arch/riscv/include/asm/types.h > > diff --git a/xen/arch/riscv/include/asm/types.h b/xen/arch/riscv/include/asm/types.h > new file mode 100644 > index 0000000000..48f27f97ba > --- /dev/null > +++ b/xen/arch/riscv/include/asm/types.h > @@ -0,0 +1,73 @@ > +#ifndef __RISCV_TYPES_H__ > +#define __RISCV_TYPES_H__ > + > +#ifndef __ASSEMBLY__ > + > +typedef __signed__ char __s8; > +typedef unsigned char __u8; > + > +typedef __signed__ short __s16; > +typedef unsigned short __u16; > + > +typedef __signed__ int __s32; > +typedef unsigned int __u32; > + > +#if defined(__GNUC__) && !defined(__STRICT_ANSI__) > +#if defined(CONFIG_RISCV_32) > +typedef __signed__ long long __s64; > +typedef unsigned long long __u64; > +#elif defined (CONFIG_RISCV_64) > +typedef __signed__ long __s64; > +typedef unsigned long __u64; > +#endif > +#endif Of these, only the ones actually needed should be introduced. We're in the process of phasing out especially the above, but also ... > +typedef signed char s8; > +typedef unsigned char u8; > + > +typedef signed short s16; > +typedef unsigned short u16; > + > +typedef signed int s32; > +typedef unsigned int u32; > + > +#if defined(CONFIG_RISCV_32) > +typedef signed long long s64; > +typedef unsigned long long u64; ... all of these. > +typedef u32 vaddr_t; (New) consumers of such types should therefore use {u,}int_t instead. Jan From xen-devel-bounces@lists.xenproject.org Fri Jan 06 14:15:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 14:15:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472677.732989 (Exim 4.92) (envelope-from ) id 1pDnVf-0002k0-C9; Fri, 06 Jan 2023 14:15:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472677.732989; Fri, 06 Jan 2023 14:15:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDnVf-0002jt-8w; Fri, 06 Jan 2023 14:15:51 +0000 Received: by outflank-mailman (input) for mailman id 472677; Fri, 06 Jan 2023 14:15:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDnVe-0002jl-P0 for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 14:15:50 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2080.outbound.protection.outlook.com [40.107.7.80]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9ecebf5f-8dcc-11ed-91b6-6bf2151ebd3b; Fri, 06 Jan 2023 15:15:49 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8804.eurprd04.prod.outlook.com (2603:10a6:20b:42f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Fri, 6 Jan 2023 14:15:48 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5944.019; Fri, 6 Jan 2023 14:15:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9ecebf5f-8dcc-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ErnpGFYYvUKQPCgH7ZKSSwUdvqUNMkGtZqaxORVlKUJO94OC/cHO738bRKuFrouO2vIuOiCzlWfaLSE7cRTRVLp39IAZjaJTizWm8KSlDx0Tmdk6QyS6uxzaR7/BTLSELQUXBj/JswI4taDZD8Oy7IrEqUg+kwUTPKteZq5FI3X6974TeQqfdNAKas38YPGIl6E+NttZDddEFAw4ZeEsIoZiDqkrK4PDcgTdg8JVZOaQZd2Rj4lpp17j1oydf/kFlXlCSX48kSQRteV3/dnNUMbI8essHDFw++fyM2ca8mAzqlSSOVxAsb97IQzmgPLYLpY+jvqFbuo5BB9312mTxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PwcgD9BxLJS1uqkaTVy7HqdrmgombZtt5wnEh7+I6Dc=; b=cRzaDVcCXY6sLwGCunnPAZ28lg6XvU3hweHGkmOmRx5Ckx4UYkqV4RsMKwu36d2xMCRmqrK9YqEQcgR6XF+OWrsCq4itBpnO9qWifKOwtZMlhy5fPYUjykEUy9oA/FkkDklwFi5WyiZrsUHLLkIeYySNdYu0YHBz/KuYPqIW7tpw9F0tWLAPfIAVOxcZ7HPSn7URzdfMb68RkA2MkogJZtPAXfxcy5DzvlKqS5JbQnxGZd/NVWdYfnbCRyHRll45wEYIYGEauAz7eJTZfd5dQQapEDizvwgGM3rEYgjZW0jf6DTPG88sFWqyworl8i8ukPbRlxIedTlGWjQNH8hn8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PwcgD9BxLJS1uqkaTVy7HqdrmgombZtt5wnEh7+I6Dc=; b=Cabvio0plZdPZQFyYRIMIma3OaOl1IYRNkwrhm7rCTXynh61fDe2Jr3ClHapIpt1YqIDnK6qlsy6cUHQunK1089ppGT+nwNo3L4qJqe1SXpWa8/6fhezi+rFJV2tra7cJHwZ+Lynyzjd7TuhWGUvF70uNnlZfe/sSo/CgqYYAv5Ln1HrtiM1gI0hPnWL8sXJF7JkcLen3Oih8A7iH6nEwZM7QIGuWZx8yU3qOfrMWRweInfRvKoS5B1R2XZdynK7rDQU7elXMOaM4heta85RC3AG9nkaN76TQbM5S493lrTAsMd4DjVcDdzDWcC0QqAzCsx/m8x+Dr17yyV7+EMSRQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9c93ee8c-1c7f-d1aa-c0fd-72518e37a74d@suse.com> Date: Fri, 6 Jan 2023 15:15:46 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v1 3/8] xen/riscv: introduce stack stuff Content-Language: en-US To: Oleksii Kurochko Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0157.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:99::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8804:EE_ X-MS-Office365-Filtering-Correlation-Id: ebafbd80-91ae-40d4-80ac-08daeff08255 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wP+azzrjv1nZ56NX2/jndl/qwA3Zgvu8CDhiN1Sk+wHCDNXmWUaX9a98ggfvS3zF0rWAq9i9H0qjP5c+cF9fSvm/20+NvQUT8Jz+Uq7m26E/syeBK2/SY0FxcD+ZqHMQl5iA8Vtv5qRqr7Hxh+8Mb0v69GopZds+s7V2XP+9RqCvipGoUW2WfzkFeGQ6djyQ72bEKlWJJ4ZcgHFOtWHeoqGj7U2QNN0dBPAD65B2xbvLvbDr1Tf4xtHdq3KXnkZPSQn/9r/tzYe2KYHA8Im5konitW1QMk+P6Ceb9lb5LWRMZbRuW0TwyTrBcYcoh6nZc+asJ7xblkFh8iihlvaOGeuFjPNft+X/1uHRZ2eXvF8pczKqxoa/hl8e1H7IxE+dVHouwyCrp4bMnDdNWwoSg8tE0zduwrE/QLGDb8fL9Dbu2PPVgvSaaQgMc5EoTKNZ3AQdeaRUqVDcQwrzi0E5jwrQkdi9tFIFHfAREqcUy+Fmy7X4cCS6dOaQWpGc+DUzHNMf4ThHGlww5L4PgyUXwGuTmkEHIgcVfBQx+xNPxAaHiCrhdK+gMkMFEjaGGZfJHV/Z2OWsQdA85idwn7AS341kcG2Lo2r9SRuYeuvgWZ8h87IlIIVEqdUXkp6Xj/CsuT77G8GjUHSCg8+vL6iigJw8rskUL8OJt2HteTE3iL48z2Qtd5eR8H+POat9W955Oo3fWfcOjRagylVBge3dZFDErCbwYWqu8eZoZ8B4lBQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(366004)(346002)(396003)(136003)(39860400002)(451199015)(6512007)(26005)(186003)(2616005)(31696002)(36756003)(38100700002)(316002)(6916009)(4744005)(54906003)(31686004)(2906002)(4326008)(86362001)(66946007)(41300700001)(8936002)(5660300002)(8676002)(66476007)(478600001)(6486002)(66556008)(53546011)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?czVSVzdmZGNuekxPWDhRcXc4ekJHZCtJOXJ2a05ic0kwR3FZUjF5QjJvRTVh?= =?utf-8?B?dVB6M2c5S0lqWUFPNG56a25lU1R3b1h2djVzQUVRNTVyalpxM2tITTY5RTgw?= =?utf-8?B?UENXY2tKUGhTMFloa1FOT2xMZWpEVDlVRTRhcUdqa1ZhbHFPT0J4Nm1KV3VE?= =?utf-8?B?RWlVVTBQYVpya2J1ZlJZUHBmaWtBY1I0Sy9INVQ5MVQvSkxCc3FMR1F5Tlk0?= =?utf-8?B?c3VRWjVNcHJoS0Q3TEo0SmlGa1Q1QXc4OTRhSlloN1U0VmxQWHdWaVMrU3M4?= =?utf-8?B?cFlDL1Jwd2I3alE0V1dqNzJTZ1RYTC9aRm1DeUpncmQ0ZUVmVyt0STZiR3NF?= =?utf-8?B?aTdqYjhoeE5qUHRqV25BNmtqeWp5M1c3VUJJWHFWeTRoTHV2ejlhYm4xbHVt?= =?utf-8?B?eFZXYkF1ZjV6dlBmK3VUNkQ1djI3cUpPcmpqbVdVNGM1R2w4d0lYcVoxdUxD?= =?utf-8?B?aXh1T25XNHNVVU5Ob1luY1Q4dnlYaEJkK0svN0dLYW5JZkFSRjVYNFF3YUNs?= =?utf-8?B?Qk5qdEJYZU1LRlVyWXFZa2ZoUWJQMkxnOU9BN1VaMjlQTHZVM2hWOXJUTXNP?= =?utf-8?B?VVR3QjFobVRmWkZ2NDA5blRUL1lybnNnbSt5TTlLM2ZtS0ViN0R2anpjUEhj?= =?utf-8?B?aU1IUU84Sm5BSWlpVDMvdEJwZTZQZ2JuY1F5YWVmMXRaWVBsRmhvczYzM2th?= =?utf-8?B?MWR0ZWJzbDlHSlpOQ0dWazNRekN4M1BnMmRsek1vWXgrRXh1elFhTHp6bWh2?= =?utf-8?B?ZXk3S3diSHFvei9KUDVIUU1MUTFsZ3BoTHlBYkNQYWE3alJPU2M1THg1aXNo?= =?utf-8?B?NkVtQVhBUDVRdjBzUkhuendhWjJuZkNZcnE0WWJ6eVkvOHo4bVBXcThsTUNi?= =?utf-8?B?cjdBRk1GZnBCeUJGNHorL2NhZUgvMEJrQXdnbXVyNERoeUJFYmxlTk1DZEk3?= =?utf-8?B?TkNCMldlWktkVDZDOGtOdm90MFh4d0t0U0sxQ3dsTTZTL3lPUkM3YzVUekd5?= =?utf-8?B?cG9YL05ENVNZQVdJNEFsVGYrM2VOdkdTZ0FDN20wd2lBdmx0SkMwQkRZSDZH?= =?utf-8?B?a3hKRzNod1lsdmo4K2d5cjc5eVM0RTVmZkpkM1FhcWVYdzlzTlA3SEYxNmNG?= =?utf-8?B?SVdVSjlISDl0UmZ2TUUzQkFOcVdTTnZyYmZMdndQU1VsQUpGQUgzcFJTVFdM?= =?utf-8?B?LzVEZVRSRmJFakZpYTJzYVl2MlNoZnNSczFGS2lvNDRuQzc4Njg5dmZLTnpQ?= =?utf-8?B?VE1KYWJNeitEZ050TGwrWURLc1Y0VHl5clQ5K2NxU29nOEtpcHlKWXBjdjQx?= =?utf-8?B?ZFE5cmFUTG43QSs5WkN6dlpRZ0tXV01DQkVuWFlicnRoOEwxQUwrNi8xRW82?= =?utf-8?B?cEY0UTJETm84WGZNcVk5UHJvQ0VwMVJUNW03RWE4ZGhJSmVNN2R2dFJIOTRF?= =?utf-8?B?bFprankwMWZZbHN4TG15VGRrR09SQ3dSbXNXRXFjWVAybno3K09VUUVsU2sw?= =?utf-8?B?SXpOSkxjSjRETitpbjFmWU0xcFRadUlLMHRvalhUL0xZNy85Nk85ZmVRN2RB?= =?utf-8?B?VldoS2Q4QzRybHpSdW4wdGd3Q3I5UmpyVGxRZ0pIWGhqSTdUOUovc09nTEpM?= =?utf-8?B?amdIU2kybXJ4UmY3T3ptaGtQYVhqRERLVFJ6ZjZqVStDM1JNTEdGZEl2Zk5u?= =?utf-8?B?ZXhkcHFveGpUNldoY2huSUpNalFLVkJsK2ROMVRldng2L250UThhRFpib2xZ?= =?utf-8?B?dEpyZmpJQWozRkMzRng1ZzEybGFkenY2aHJsaFRSN2xMR1JjUzFjZmJDVS9I?= =?utf-8?B?UzFpOWxhN1FUMFlORFNrSTNIZGlOZThLMVVpTG1jZVBwNjN2eFpHRDJNV2Fy?= =?utf-8?B?eUVGeXhzS3FxV0RiQnU3UnNCTUJGNDRBTml2akpVUlVoOVZuTFRQd1d4ajIr?= =?utf-8?B?Y1ozQTZhSzE4eEdxV1dRVktpa3cxWEQ4Q0p6elh2TktmaU9YczExcEFnTkRh?= =?utf-8?B?THphUERFWVplQnJJbW0vMGRUZnMzMlRER2gwNVMwc0JpelhNdjkwdzFSUGcy?= =?utf-8?B?OEc1R3o2bmJXWmlJbVNMNjdUQm9xZ3RORlh0UUpRYm1xZDRZRUFiU3J0d0VV?= =?utf-8?Q?Bij+whFGccS4t7DA3//acna6V?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ebafbd80-91ae-40d4-80ac-08daeff08255 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2023 14:15:48.5115 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BDsVYOKeq9YkEKVU3gx7WERb2ApMY6TOrOjUr5dMthiadyGiFEbxSkzIzfSpsm4AGq0IBIdA7IPad/7tGzrNpA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8804 On 06.01.2023 14:14, Oleksii Kurochko wrote: > --- a/xen/arch/riscv/riscv64/head.S > +++ b/xen/arch/riscv/riscv64/head.S > @@ -1,4 +1,10 @@ > .section .text.header, "ax", %progbits > > ENTRY(start) > - j start > + la sp, cpu0_boot_stack > + li t0, PAGE_SIZE > + add sp, sp, t0 > + > +_start_hang: > + wfi > + j _start_hang Nit: I think it would be nice if in a new port assembly code used consistent padding between insn mnemonic and operand(s). Jan From xen-devel-bounces@lists.xenproject.org Fri Jan 06 14:31:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 14:31:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472684.733001 (Exim 4.92) (envelope-from ) id 1pDnkv-00055p-Mx; Fri, 06 Jan 2023 14:31:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472684.733001; Fri, 06 Jan 2023 14:31:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDnkv-00055i-KC; Fri, 06 Jan 2023 14:31:37 +0000 Received: by outflank-mailman (input) for mailman id 472684; Fri, 06 Jan 2023 14:31:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDnku-00055c-HS for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 14:31:36 +0000 Received: from sonic306-20.consmr.mail.gq1.yahoo.com (sonic306-20.consmr.mail.gq1.yahoo.com [98.137.68.83]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d035499f-8dce-11ed-b8d0-410ff93cb8f0; Fri, 06 Jan 2023 15:31:32 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic306.consmr.mail.gq1.yahoo.com with HTTP; Fri, 6 Jan 2023 14:31:31 +0000 Received: by hermes--production-ne1-7b69748c4d-pm9xv (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 99343fc4f63f4df1a7ca33195a3121cf; Fri, 06 Jan 2023 14:31:27 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d035499f-8dce-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1673015491; bh=y6zkYfIxxD5S/JDQeE4SivkZD5jJU4lvdvq0QEx85Mw=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From:Subject:Reply-To; b=gMJWL0CifJBv4PIXb85oKrIf4K47Qac2HcIlDOncDX8HEZIWNdy9TIQRqiIA3b5XATpkMM1hJFLWZpqB4uqaEauoXAlyrpzDfMQCkrCet7AfV9T8iGauEUSqsA5Y/wVbYQh3ZH3Gn8bJDa6DzwsTP/gM0CpHouMKL/lzHff06fdHPvR9l7an1tC0Y1o3Mh8pAbNCM9kKPZcHNLNsHpEdNLgOYuXGft14bJtr1etvZuOgdyhQfjxZ1HuPfacxPdpUoKKcT68seumGyFufEpJq2nXUBU4jPupyARgBJ/jOs9o+yquV6F6jPmlZmEIVHnhgEeJEtk627NFbF2w0Bv6oGQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1673015491; bh=ARB2ekFXVfL0AnjnYt/lBtyXroynDuu7XYPBY3z8lhu=; h=X-Sonic-MF:Date:Subject:From:To:From:Subject; b=nh3kvsIQY5F6Di+rurJIEsQyEaONX+TWAgLdWkJ9aiHCUmGmEgHhPbiHV97/JP0yB/MEma9xQl/lcj7EL+tdNwutgOrlS/EiLbgAT1Oz1opwHx+MFWagI8uEiaEYk61OSwAUdszBo9hjYLCHQArn9JzsGwaLqzpWEYFFsVEpf2eW3fg+AEKOLc5LYVkBolgrlI3kpJLEE/GNzKPn4SZ2Km4E42w01JknPXE5HuaMqqwFFApwupZ4nh4+d3sqHy/gcWsy0bKZtAE9vKMVdf5nmFqF7OAjRvYsrIOCNwzqQ0y8jZgW8LcW4yGHgViORnmi0Kzn5rtPB3v0l0PnkfwnHg== X-YMail-OSG: JX18UQcVM1l7cWKjfZWdrumO8AgdUDt2Esk5Ipbgv8k4TYiXRbvlKzHJO.VrKu3 pr1CX43aD0bmKvPtGTeWKwYF.ml1B.XHdkDWqcSI2GsfZbuIb8Gw9Oi1trCtdDkJJekqM7VLrl89 _wUesm_hKMO7FdJxMrmZqExO6CWfmE7mmy38NNt77FSQbZ1X2WbcN5xzqGtYItnXIdXZskAEDpxb U5ahzAAJ52c.0aOLX8ROf8hbvCMOJFulQbW.yTfvfu3ldOAi3wPpVqm_OjCCuN4wDUf9sFjKXUuW c1F0BpLcwGZWjjbuKMMd4MBLDvp221CAgkKzYvL4rjZ0W0UBH2CRRX.zcMyXtaoCoVukDJiwkg7C 7TANBIVg.qPmyc1uxUnp517HRq.0Hgd9fv45L8dmOedJ6yXtG6TMu16w1yMsEga3dx2NQzzZJQws mCWcF_29NfkgbBkUkLb2GAEzaVoaugW13pxytYicJRsjCajzes_.3TNr0Iv0JnvwG9elgj5iyuBY G_MSkGgkQtORlow2rLGkATJ4qx4C5p93ctcYP8G5jbyiU13BoGxRebuKJMOdJT9wylyAlX1r6M1. 7WKcVz5FPdKC_tc1PSWJGuK04MutTBRP5OadYFYbYU77nP_3Ur4hKrC9Sc.ZhWKyJHLRpBFgegqy 6.9Lq0cxvrRHYvpttLd5lPLqKPjd2wLsr_OE9a6sBuS0YsY2JeIsO9Bty2hO2razoA57xxUKw.EG j6D9dnrWjb_v47U0dPClyaieYtef6E8eoreZ10szXskmYoZQXj1M93cS7KGgLjv4r2FR.1TYta.K .xq3D0OhHK6xWEFN3YS11vt0KPHSiUtuG4437kkuDOXS_UC92r1LIdvL7b46KUqvhLrkx369OuRP Ap65gOCh21Zj_as27WAsR47qc0txlmPBrFPGsWXgvAvtWQNCKK_j9Ibc2YVnKvwkGgF__bvpA4my voquMG2xxFPF7W8A1YH9ViPP.HmaeggD1z7BRKGSbAWKP66AQX21JRUCOD0dxW8mL.miSJ5YibHg 8iTINMCXOO1zRn_ggdg6YsGllXcavf2N42If_DPdjB3k6kVliqmqMd.J6K91M5rnxpZLeVgEWp0j juzKfgKgOsiIWVWFZZolaGaYGrD3mpT836.eZJEXtspHeh9pgqew9TC__sbQz65ityswhmm5XHOa sqLLFu2KYiW2323ZuFza18M1nWAPLRm9IEVAyRHTXqXg.zWUQtw6nJNswPW1rMoS3lFyXUJyqP5w 8QA31EId4H3IPUCLQOnIX_eeerjOnnNxHw59PN2tAsg7MVg9CpoyaVIABqj0VaesaAhWbs9j4MnO 9ri30WMYiTMyIR1gOdaDbLgI_f1LfRQj4bZqctOy2OiLXMQ2OtxgLjU5j_ImU8LmKll9CgU_NA9B ZRWCyInmZOopens1mAT6b5jjH8GK11HNxNELkLDbmOtsrFBGWvq1OjC4YriFy._uL7UD4KC2e_0n LkXAVaLG4mPi_nTgCmcoeV6RSmYbgK1XSjuQzCKptThDWUlckyhkG0PKkQHT3.7SLhBQBte7KGQK ux6pXK98w4U8frPPby1EqoR.Vg6QSZJ84e0pKYeynMPlOvoNEgsw0I0x6oR52P5klQQwW6OyfGpM j1HefmkNGNmqPP_M7WiRDv5Ft9aY.elN6jmpGkfpREB3EhstVkDXhuVBz0zYJrGh0kzmSisXA0Ec Q2s7adhJieyZ1R30ZmBjP0q7SStBXqcHYUxl4tocWZRqMcWrKhhJ0eXxappDJqySE3HjTWfrFOah WeaQO0f2.ikNMWUgPjNVoCl3RXxKVaL9JQldMsd0QuS2RxuzmJv1Lk.ULEGauJ9Ae.hov9UR_zBf 5WRXyWv4aU3a1DbIvoYyqWrsE.U1TxLGGFg9lyo82tcDwm85D63snpc21U6z5ktEoxtMhcOpimK9 awAFVRvj8S_alux4..DwyrD8SXfaVKiu3.DbCEzcg_X9rj_dpSQgAFSCDFmreTaBIS4VZ8uRhq03 dYD9ZYWCr1WSGTFHjO8eTToxq5ezYJgpN16mVJSHfJp4XZauCzkXv6qc.AWeYVSiXzyXf8mJ.Ytk ESEhJgampBejPnxAbRiUqF6y2GYEZZ5voU3DzCTejkTwgaUfHENvpkL51RxxTbbiVYoOL70EE57u Qy2c20k6eumDqNoTJKX.gQ4Bee_j7p5MoWu1cfIdNBtcNyDxDonzDX2t6IwzbgncOadIKHx3ncwc 9KkhzjcjXWA-- X-Sonic-MF: Message-ID: <882652f8-ddda-a7d8-85b9-da46568036d3@aol.com> Date: Fri, 6 Jan 2023 09:31:24 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v6] xen/pt: reserve PCI slot 2 for Intel igd-passthru Content-Language: en-US From: Chuck Zmudzinski To: Anthony PERARD Cc: qemu-devel@nongnu.org, Stefano Stabellini , Paul Durrant , Paolo Bonzini , Richard Henderson , Eduardo Habkost , "Michael S. Tsirkin" , Marcel Apfelbaum , xen-devel@lists.xenproject.org References: <830263507e8f1a24a94f81909d5102c4b204e938.1672615492.git.brchuckz.ref@aol.com> <830263507e8f1a24a94f81909d5102c4b204e938.1672615492.git.brchuckz@aol.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.20982 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 3579 On 1/6/23 9:10 AM, Chuck Zmudzinski wrote: > On 1/6/23 9:03 AM, Anthony PERARD wrote: >> On Sun, Jan 01, 2023 at 06:52:03PM -0500, Chuck Zmudzinski wrote: >>> Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, >>> as noted in docs/igd-assign.txt in the Qemu source code. >>> >>> Currently, when the xl toolstack is used to configure a Xen HVM guest with >>> Intel IGD passthrough to the guest with the Qemu upstream device model, >>> a Qemu emulated PCI device will occupy slot 2 and the Intel IGD will occupy >>> a different slot. This problem often prevents the guest from booting. >>> >>> The only available workaround is not good: Configure Xen HVM guests to use >>> the old and no longer maintained Qemu traditional device model available >>> from xenbits.xen.org which does reserve slot 2 for the Intel IGD. >>> >>> To implement this feature in the Qemu upstream device model for Xen HVM >>> guests, introduce the following new functions, types, and macros: >>> >>> * XEN_PT_DEVICE_CLASS declaration, based on the existing TYPE_XEN_PT_DEVICE >>> * XEN_PT_DEVICE_GET_CLASS macro helper function for XEN_PT_DEVICE_CLASS >>> * typedef XenPTQdevRealize function pointer >>> * XEN_PCI_IGD_SLOT_MASK, the value of slot_reserved_mask to reserve slot 2 >>> * xen_igd_reserve_slot and xen_igd_clear_slot functions >>> >>> The new xen_igd_reserve_slot function uses the existing slot_reserved_mask >>> member of PCIBus to reserve PCI slot 2 for Xen HVM guests configured using >>> the xl toolstack with the gfx_passthru option enabled, which sets the >>> igd-passthru=on option to Qemu for the Xen HVM machine type. >>> >>> The new xen_igd_reserve_slot function also needs to be implemented in >>> hw/xen/xen_pt_stub.c to prevent FTBFS during the link stage for the case >>> when Qemu is configured with --enable-xen and --disable-xen-pci-passthrough, >>> in which case it does nothing. >>> >>> The new xen_igd_clear_slot function overrides qdev->realize of the parent >>> PCI device class to enable the Intel IGD to occupy slot 2 on the PCI bus >>> since slot 2 was reserved by xen_igd_reserve_slot when the PCI bus was >>> created in hw/i386/pc_piix.c for the case when igd-passthru=on. >>> >>> Move the call to xen_host_pci_device_get, and the associated error >>> handling, from xen_pt_realize to the new xen_igd_clear_slot function to >>> initialize the device class and vendor values which enables the checks for >>> the Intel IGD to succeed. The verification that the host device is an >>> Intel IGD to be passed through is done by checking the domain, bus, slot, >>> and function values as well as by checking that gfx_passthru is enabled, >>> the device class is VGA, and the device vendor in Intel. >>> >>> Signed-off-by: Chuck Zmudzinski >> >> >> This patch looks good enough. It only changes the "xenfv" machine so it >> doesn't prevent a proper fix to be done in the toolstack libxl. >> >> The change in xen_pci_passthrough_class_init() to try to run some code >> before pci_qdev_realize() could potentially break in the future due to >> been uncommon but hopefully that will be ok. >> >> So if no work to fix libxl appear soon, I'm ok with this patch: Well, I can tell you and others who use qemu are more comfortable fixing this in libxl, so hold off for a week or so. I should have a patch to fix this in libxl written and tested by then. If for some reason that does not work out, then we can fix it in qemu. Cheers, Chuck >> >> Reviewed-by: Anthony PERARD >> >> Thanks, >> From xen-devel-bounces@lists.xenproject.org Fri Jan 06 14:43:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 14:43:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472692.733011 (Exim 4.92) (envelope-from ) id 1pDnvr-0006hx-S7; Fri, 06 Jan 2023 14:42:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472692.733011; Fri, 06 Jan 2023 14:42:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDnvr-0006hq-PU; Fri, 06 Jan 2023 14:42:55 +0000 Received: by outflank-mailman (input) for mailman id 472692; Fri, 06 Jan 2023 14:42:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDnvq-0006hk-7h for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 14:42:54 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6474b747-8dd0-11ed-b8d0-410ff93cb8f0; Fri, 06 Jan 2023 15:42:51 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6474b747-8dd0-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1673016171; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=dIxp4kB3Fq0R4kfKEpGGR4PCvfMFoXf/LwvzR19LURA=; b=Sd9OQZXf6dEblJY7G6FfZwWwp/VbBLeZF1yZLzDuGFEP0cN5SX5pO1Xm Arwq1zTrZPQGk1FvB90lgrJ23rlfS6+c66F/321C6U82EvJpAHAs3MTEb k7WA2ILrnSGeYtl1LvexmmdC6eEZzlTtGnf8eqoxnxFlv8BN1quDxSlYX w=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 90966612 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:VJswE6jTu9xi3QxlCHxLmkylX1610BAKZh0ujC45NGQN5FlHY01je htvXmCAb66KNmChf41/aYzk8E0G7Zbcn9VqHApvrX89Fykb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmUpH1QMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWs0N8klgZmP6sT5QeAzyN94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQaOmsffgiMo9uo44K3dMN8t58/KvPCadZ3VnFIlVk1DN4jSJHHBa7L+cVZzHE7gcUm8fT2P pRDL2A1NVKZPkMJagx/5JEWxY9EglH2dSFYr1SE47I6+WHJwCR60aT3McqTcduPLSlQthfA9 zyYoT2jav0cHMSSxAHfq3utv8beu3nnVdMLF5yz+OE/1TV/wURMUUZLBDNXu8KRh0KjUshTL GQU8yAtqrMuskqmUrHVRRyzoHeeslgcVtxcHvch7welzqvS6hyeQG8eQVZpbcc6nNU7STwjy hmCmNaBLSxitviZRGyQ8p+QrCiuIm4FIGkafygGQAAZpd75r+kbixvVRdtnVqetgNDxEzjtx hiFqSE/g/MYistj/7y2+E2Cjz+yq5zhSAkz6QPKGGW/4WtRbpSuZ5Gj6krz5PFEao2eSzGpp 2MYksKT6OQPC5CllyGXRugJWraz6J6tKDfbh0xuGZgJ7Tmh+3e/O4tX5VlWPE50Nu4UdDmvZ 1Xc0T69/7cKYiHsN/UuJdvsVYJ6lsAMCOgJSNjWfIFccoB+UDaZ3xFiW2SA7jvxlnIFxPRX1 YigTe6gCnMTCKJCxTWwRvsA3bJD+h3S1V8/VrigkU35jOP2iGq9DO5cbQDQNrxRALas+l29z jpJCyedJ/yzusXaazKfz4McJEtiwZMTVcGv8Jw/mgJuz2Nb9IAd5x35m+hJl29Nxf49egL0E paVBCdlJKLX3yGvFOlzQikLhEnTdZh+t2knGicnIEyl3XMuCa72svhFJsdsIOl2qL0ypRKRc xXjU5/QahioYm2ekwnxkLGn9NAyHPhVrVjm09WZjMgXIMc7Gl2hFi7MdQrz7igeZheKWT8Fi +T4jGvzGMNTLzmO+e6KMJpDOXvt5ylC8A+zNmOUSuRulLLEqtAycXKp1qVnf6nh63zrn1On6 upfOj9AzcGlnmP/2IChaXysx2txL9ZDIw== IronPort-HdrOrdr: A9a23:/alh+6ClgOS3hhjlHemd55DYdb4zR+YMi2TDgXoBLCC9E/bo7P xG+c5wuCMc5wxhP03I9erwQZVoIkm8yXcW2/h0AV7KZmCP01dASrsSjrcK7AeQeREWndQts5 uIHZIOcOEYzmIUsS852mWF+hobruVvOZrJudvj X-IronPort-AV: E=Sophos;i="5.96,305,1665460800"; d="scan'208";a="90966612" Date: Fri, 6 Jan 2023 14:42:35 +0000 From: Anthony PERARD To: Chuck Zmudzinski CC: , Stefano Stabellini , Paul Durrant , Paolo Bonzini , Richard Henderson , Eduardo Habkost , "Michael S. Tsirkin" , Marcel Apfelbaum , Subject: Re: [PATCH v6] xen/pt: reserve PCI slot 2 for Intel igd-passthru Message-ID: References: <830263507e8f1a24a94f81909d5102c4b204e938.1672615492.git.brchuckz.ref@aol.com> <830263507e8f1a24a94f81909d5102c4b204e938.1672615492.git.brchuckz@aol.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: On Fri, Jan 06, 2023 at 09:10:55AM -0500, Chuck Zmudzinski wrote: > Well, our messages almost collided! I just proposed a v7 that adds > a check to prevent the extra processing for cases when machine is > not xenfv and the slot does not need to be cleared because it was > never reserved. The proposed v7 would not change the behavior of the > patch at all but it would avoid some unnecessary processing. Do you > want me to submit that v7? Well, preventing an simple assignment and a message from getting logged isn't going to get us far. On the other end, the message "using slot 2" when we don't even if slot 2 is actually going to be used could be confusing, so I guess preventing that message from been logged could be useful indeed. So your proposed v7 would be fine. Cheers, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Fri Jan 06 14:55:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 14:55:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472699.733023 (Exim 4.92) (envelope-from ) id 1pDo7h-0008FA-WF; Fri, 06 Jan 2023 14:55:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472699.733023; Fri, 06 Jan 2023 14:55:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDo7h-0008F3-Rx; Fri, 06 Jan 2023 14:55:09 +0000 Received: by outflank-mailman (input) for mailman id 472699; Fri, 06 Jan 2023 14:55:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDo7f-0008Ex-P6 for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 14:55:07 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on2058.outbound.protection.outlook.com [40.107.8.58]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1ab1b88d-8dd2-11ed-91b6-6bf2151ebd3b; Fri, 06 Jan 2023 15:55:05 +0100 (CET) Received: from DB6PR1001CA0006.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:b7::16) by AM0PR08MB5331.eurprd08.prod.outlook.com (2603:10a6:208:187::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.14; Fri, 6 Jan 2023 14:55:00 +0000 Received: from DBAEUR03FT046.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:b7:cafe::72) by DB6PR1001CA0006.outlook.office365.com (2603:10a6:4:b7::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.15 via Frontend Transport; Fri, 6 Jan 2023 14:55:00 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT046.mail.protection.outlook.com (100.127.142.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.17 via Frontend Transport; Fri, 6 Jan 2023 14:55:00 +0000 Received: ("Tessian outbound 6e565e48ed4a:v132"); Fri, 06 Jan 2023 14:55:00 +0000 Received: from a14c970605c6.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C6CA9B0E-D381-4961-BF1E-972E26964A33.1; Fri, 06 Jan 2023 14:54:53 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a14c970605c6.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 06 Jan 2023 14:54:53 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DU0PR08MB8639.eurprd08.prod.outlook.com (2603:10a6:10:401::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Fri, 6 Jan 2023 14:54:51 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::d1d7:166d:6c34:d19e]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::d1d7:166d:6c34:d19e%4]) with mapi id 15.20.5986.007; Fri, 6 Jan 2023 14:54:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1ab1b88d-8dd2-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iefGtseeR8T4bINEtwsgEEg3NVUu/gPqbj6/DDnjGLo=; b=WYxe4ReimclZiI1EH30OaHnHnsxWQlvxToFxLNK5vpWzlS1IzA1yzv+UOa1kqJWrmzfp0VoZvKZv4TucwbjMC6Ii2xVc/pAePhXpYScwJuJ3mBQyxrMJlTqBWFWnzbK2mbW9Rb5fzO98wpnQQ/pXNEHQ85yjRkMDwbBywWe+w2Q= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nK8s3jq95aR0GBfj8VeMG5XE+IEAdi5+NIVp+ttXPT6HrXPERuhc2KjI9nxqKqJ2vryfgbZp2a7EJTtujl6j5OamOV5/GTTOWDcDTpVpEPL4H1T7MKPCTTVnNRHTsVdVzk9IegXXozZQDYnHT+yVDg1r5uo8geKe6xU0EksvISlpXJJX572K77HsSvJGvXVflJP5Y3zCf1qJN6BO+vi9cBvPWmHXKCJgVM2yKFOkn6DZuayfsnZyaloZe4wgPm9s1SAznUodIOC1VcuWNbH+41NX6JYsbfTnvK4CGfQnGrjlgBDxmxRfB49erP5X/l8AgrupLRnOMvijFoPj06eNdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iefGtseeR8T4bINEtwsgEEg3NVUu/gPqbj6/DDnjGLo=; b=G+eoA2F1dkPxbXqb/+qctC7wW/KWGThGi2UWUXIg9z7mxb56qAw1uhV05N+jv2lnL/kNLGKjKm7FUbk63rZztFuAOfzYRwAx4DcaQFm8a2ZyyMOHYs9fLQvzNx3Q7I5VHnL8bDxI80Z01mnyi5B+wd9WMhVdKmjG5Yrlnty9QtrV9cUfjWs04YDihuu4VqF7M5HWq0cfFz+M8T6Yc4J+iDZaVs5t/djCDR4JHoHubYlBZz2s6c92kac3v3uveG/j080O0R6/RHiuuqDYs8cYcjgDRA0BuMdpYW/aGCw/HumF4Ra7V8gcNseCpntURkBgtK49mnWbtBYhARl6QAd6gA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iefGtseeR8T4bINEtwsgEEg3NVUu/gPqbj6/DDnjGLo=; b=WYxe4ReimclZiI1EH30OaHnHnsxWQlvxToFxLNK5vpWzlS1IzA1yzv+UOa1kqJWrmzfp0VoZvKZv4TucwbjMC6Ii2xVc/pAePhXpYScwJuJ3mBQyxrMJlTqBWFWnzbK2mbW9Rb5fzO98wpnQQ/pXNEHQ85yjRkMDwbBywWe+w2Q= From: Henry Wang To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH 19/22] xen/arm32: mm: Rename 'first' to 'root' in init_secondary_pagetables() Thread-Topic: [PATCH 19/22] xen/arm32: mm: Rename 'first' to 'root' in init_secondary_pagetables() Thread-Index: AQHZEUh3UTDXWpRZjEa7nLtXRiROF66RkhiA Date: Fri, 6 Jan 2023 14:54:51 +0000 Message-ID: References: <20221216114853.8227-1-julien@xen.org> <20221216114853.8227-20-julien@xen.org> In-Reply-To: <20221216114853.8227-20-julien@xen.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 166E9CEA8F8BE44593B701E6599657EF.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|DU0PR08MB8639:EE_|DBAEUR03FT046:EE_|AM0PR08MB5331:EE_ X-MS-Office365-Filtering-Correlation-Id: 2cbd839d-541e-4173-2576-08daeff5fc12 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ms5UL069jDPYJWnlaoI1S8c/OvH6A2RVp3IAsyEXhbB56DSBllGdOjmqfH+7TzJwOd6kfNPoQwPQ7luC/V0Mj47EcwfMpHHEF62ig2IyeCd9SVCTi/B5VxdKFY1GRIbA/n+1zJquDCMCT3F4/HrzE1azvvg9dciZSPgtL7AmwCQgWqo5hxZUSZSAxnX8DgNXV07CyV7MRvOPORGG7wOHL6TEPfaOUe/Yol+AExt5MlNss17zTvGdFVvJCYdweMV3Fj2E3uSAh531XWsX0G2ckIbVE1OZ2wazQjBrXB1skDFJkdtArmtXRvRXFfHXq+wlq+wM+UwI3dNtvRuFkWKt+3G83fudhG7Xt6rJGRhlqhy4UGUEEInXxSi0WxR7XnDR2XM7nnCODYv8RE/4+8Gy3Xl9I1Xbxmcan5Ur+Rin91BPLZqOifY6ZxXJ/DWf0Esz7FbxTk9RLhTt5GFeQ33zApk3bPs+FEeJv+AIv1wuH9gP/w8apRROE3zv6kQPW1Kr+BebrUWIsZoeCF5DGYOL8RnUu7E4Bq7aGnmseBB200xUVbADjAPtA/I8Ek5WsFKEt21XSL9IXw27K7uNnUdkssfFDbxWvJ6wT5CQfXru8CejcSAEYNcJJtGrRtr4nGfXJp8a62LZh43DQt0/xQDaSSM21M3TzaBmDbS34+rCE0nap78LbaBVM2QyFEVJzVuRW9IelogtW77mnQfFXj0RuA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(376002)(366004)(39860400002)(396003)(451199015)(64756008)(66556008)(4744005)(66476007)(54906003)(66446008)(8676002)(86362001)(66946007)(478600001)(52536014)(76116006)(41300700001)(4326008)(8936002)(5660300002)(33656002)(2906002)(316002)(83380400001)(186003)(9686003)(26005)(7696005)(6506007)(55016003)(71200400001)(38070700005)(110136005)(38100700002)(122000001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8639 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: bd643ca2-f6f7-4c27-44f1-08daeff5f6f5 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SumpMe6cDP0Ji0gMfc+hDKBovLswnVLXyJkAK738wCOA4tF1l/fABb+kcJV6vz8LnnfgpN22sDiLHeJllLlHjRV6Ol3R1TQ8F9GcLy9JWPbf7/n45ZNKe7ADHlbZZ/+edYy7Ktfq49ibzEvIkCDJHIJEE/uuPhDi57Jh2PIXeSH3Gc7mirEk7YzGE084UAjR68G+Srt/qmwXlkvVUlAZhwm/8y6eE/a0L3zMzxF5rvHgySuOqEGqZi9KENcttTLJlxmwDR9b38UMW+tiQ4RLG4GsKyM1gbQrQYDXA6PDe2dpXgBTHzPDQVRQWFoOc8qIB/hD0CHLIUGfQ6FEpq70pu4lMeLob/UfICZcwIKlRSaZb7i0KCxg5v0xphTo4IzAer5r62IFZZl3UwkcdQkjyv8eTcfpTHJlN/mwcVpYFJRNVJOuBUqYTUThvjpeR0UJNldWMgtTYKaPUh4ijkYeEIeANVqrdczTTIUpqtZZ7KTagthvjeM01xKj22MeKL1Pd0aKEbO5+mr1wM69OPFs//KaYkyvYduC1UPA32oWCZVaQror0f/Eh5DXUnQ0HAfkRn0JnUk7X9Smxg5Ll3JFtD3zaO6jnqHtlaU7A8NxxwG1Au3+or2PGyCrLvr+ZRnDMlYjo8LO9t56XPFUfoafU6hyWgU/787CMSf0OaF3bh+siHX0N8SZIskX2TJNa0nwqTCHW8OzjnLVw66qsBqC7g== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(136003)(39860400002)(396003)(451199015)(36840700001)(46966006)(40470700004)(336012)(356005)(8676002)(316002)(70206006)(82740400003)(4326008)(70586007)(54906003)(110136005)(33656002)(81166007)(40460700003)(36860700001)(4744005)(55016003)(40480700001)(2906002)(41300700001)(47076005)(52536014)(8936002)(5660300002)(83380400001)(186003)(6506007)(7696005)(26005)(86362001)(82310400005)(107886003)(478600001)(9686003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2023 14:55:00.1420 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2cbd839d-541e-4173-2576-08daeff5fc12 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5331 Hi Julien, > -----Original Message----- > Subject: [PATCH 19/22] xen/arm32: mm: Rename 'first' to 'root' in > init_secondary_pagetables() >=20 > From: Julien Grall >=20 > The arm32 version of init_secondary_pagetables() will soon be re-used > for arm64 as well where the root table start at level 0 rather than level= 1. Nit: s/start at/starts at/ >=20 > So rename 'first' to 'root'. >=20 > Signed-off-by: Julien Grall Reviewed-by: Henry Wang Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Fri Jan 06 14:55:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 14:55:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472701.733045 (Exim 4.92) (envelope-from ) id 1pDo7n-0000KY-Dg; Fri, 06 Jan 2023 14:55:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472701.733045; Fri, 06 Jan 2023 14:55:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDo7n-0000KR-Ay; Fri, 06 Jan 2023 14:55:15 +0000 Received: by outflank-mailman (input) for mailman id 472701; Fri, 06 Jan 2023 14:55:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDo7m-0008RI-AH for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 14:55:14 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2053.outbound.protection.outlook.com [40.107.247.53]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1efb52f5-8dd2-11ed-b8d0-410ff93cb8f0; Fri, 06 Jan 2023 15:55:12 +0100 (CET) Received: from DB9PR02CA0003.eurprd02.prod.outlook.com (2603:10a6:10:1d9::8) by PAWPR08MB10090.eurprd08.prod.outlook.com (2603:10a6:102:367::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.9; Fri, 6 Jan 2023 14:55:10 +0000 Received: from DBAEUR03FT065.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:1d9:cafe::8a) by DB9PR02CA0003.outlook.office365.com (2603:10a6:10:1d9::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.15 via Frontend Transport; Fri, 6 Jan 2023 14:55:10 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT065.mail.protection.outlook.com (100.127.142.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.13 via Frontend Transport; Fri, 6 Jan 2023 14:55:09 +0000 Received: ("Tessian outbound 333ca28169fa:v132"); Fri, 06 Jan 2023 14:55:09 +0000 Received: from 24d18afe814d.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7ADE9A14-D1A1-4072-95B3-5E69754B0C35.1; Fri, 06 Jan 2023 14:54:59 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 24d18afe814d.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 06 Jan 2023 14:54:59 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DU0PR08MB8639.eurprd08.prod.outlook.com (2603:10a6:10:401::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Fri, 6 Jan 2023 14:54:56 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::d1d7:166d:6c34:d19e]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::d1d7:166d:6c34:d19e%4]) with mapi id 15.20.5986.007; Fri, 6 Jan 2023 14:54:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1efb52f5-8dd2-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mHgBBafFbsjAzJLPSAzRUNa0KLBtz3G/c8cHAzWDPrc=; b=qJQRTP7k13vjSQC/AluPAxNQ7JnPBFhal6DfVpLbDVJcnJBwQmsPvoBnjnLYRpORFrjkRBZJ6IFIaz7klFZiJmurfF6ZVtuhQOHMBneXQZJNSUqS6NjcojEZmjE/hGWiVtuWWv6jsjvf2LvfJpfgwIVsr26cvRb4znFq/E1r8js= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AKsN0lqP4/0psYiA8OjdxuQR1XPZckPpQ8uQQst73D0cdGqVeEU3E7jONU85IXszsvCtyYCxKbupQM9FNgXaZGrCeBxsPZuVmeXyhrpfxRIOiPqXqhip/x522/bsKHJZ/0U+zQ0fyBv8WLI0MjdD7nXMgo4x3VRx2YqHuD+0pfDechbkU78nvViW6jTsf+CD+0I1qS3va45mJpuYSuZJncEOL23orR1VaJZ18yq5QaXJxfZbmsuaUrgRQ/yydCchtkG/xcawzsDRG87V7OArN+UyU+MlFWwCFLzvOGHO3T5RtRQRmXbYBV8LRNYRkjwUhOA9AIwVxGaL2ZM49yIE+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mHgBBafFbsjAzJLPSAzRUNa0KLBtz3G/c8cHAzWDPrc=; b=P2+juIv/+mzTcf1Rmd6Nval0zVoEGtfRUyyVFjkFSFcDGgsRrSovOdI47pnyJoiwCXixzo56verUBAOy35IAVWb2kbyT0K0qTN4uVaHDGNfnOvTdyUZTRpGNaRMWzMG598pWrjJM2QAqhvPQstohE8MHfzyK8jIZIAHlvhWIUBC6PedUn/EbrfH09P3LKnH7GHy1fKzOf04ZbvFdc6uLsHm89LTzVd3CFX4kMoTok65j+HvDesUmlFu8ag5JIUf25FXfIHOh3A3dTA/npYaHkH1Mt5fl5oTQ9y/pqTOchJLPsC7V/6PcQl62yYgLvUUqSg0PNgnfdAppTvLCde8sNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mHgBBafFbsjAzJLPSAzRUNa0KLBtz3G/c8cHAzWDPrc=; b=qJQRTP7k13vjSQC/AluPAxNQ7JnPBFhal6DfVpLbDVJcnJBwQmsPvoBnjnLYRpORFrjkRBZJ6IFIaz7klFZiJmurfF6ZVtuhQOHMBneXQZJNSUqS6NjcojEZmjE/hGWiVtuWWv6jsjvf2LvfJpfgwIVsr26cvRb4znFq/E1r8js= From: Henry Wang To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH 20/22] xen/arm64: mm: Use per-pCPU page-tables Thread-Topic: [PATCH 20/22] xen/arm64: mm: Use per-pCPU page-tables Thread-Index: AQHZEUh12RKmuw645EafAVdnfeFYOK6RkuHg Date: Fri, 6 Jan 2023 14:54:56 +0000 Message-ID: References: <20221216114853.8227-1-julien@xen.org> <20221216114853.8227-21-julien@xen.org> In-Reply-To: <20221216114853.8227-21-julien@xen.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: B5732067FE3B8D43A75B9CD84A545DCE.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|DU0PR08MB8639:EE_|DBAEUR03FT065:EE_|PAWPR08MB10090:EE_ X-MS-Office365-Filtering-Correlation-Id: ef139786-cb2b-4702-b1ec-08daeff601ec x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: kapN2QfqB9/KdMesDdP8tuACJMOdi10pXNKAV+wdOGaH9PPRHqyZgNmNX3oBLLq0xLmQDyGbFBj2vDcCzsGvyrz0j53bjUbxSi40XDJlZb3QdeYrNN+G0sayWDm+xgydN8uoN2y9ILYDkVw+SP364Z34vC7tWsDXUzFuKlpuAwrL+2WwXon5bEM4vAFnEcHNVktzMd6GEXsAisHk0Ja8jIflNBJFpq/AGqHT8lYlR0VwGyeMhRKgmMCRerZAVV2Zezl82QXxRpTgwojuKfgg568TORrCRoaB2fvL8ZeBk9om/8fzrcUtUCTzA6aDxl0hLlzlMR7BSvUZFD4Qt1We6tPjqiEDAc+7niTbIWUOkhA4+e6cbzTEHL+SDdto+6hw08vATsY+lRiGn8UMnij9QKqk7VLI5bzdwdK7x7JESkFiI5a2lcSq6B2rPOZtyh4zZUba+tnHZ+2VhwoPV07SiNMpjZ0/3WFaMQ7DXfEN1f2XQ9jV/acHpaecxWxcy+/bIwT6Rsjk0PGQ+3V1n9Nyp3h6UkLI3tuCkh4g5uJc20ak5WaoAn2xOd0Rimml99kqmR+6mm3xefM50MD8rg+KYj+g8V/uQ+fyw7Z3xEtXP6Fgk4A6S8BsxT1YiMSck9R4Qi8JaDfoc5YHHiE44lptLmjnBUFVma5S/1TN6M8sNLJADOYTH8YihNbgGuUUV8LPD9VgPjiUeIMoHJXXzg0Ulg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(376002)(366004)(39860400002)(396003)(451199015)(64756008)(66556008)(66476007)(54906003)(66446008)(8676002)(86362001)(66946007)(478600001)(52536014)(76116006)(41300700001)(4326008)(8936002)(5660300002)(33656002)(2906002)(316002)(83380400001)(186003)(9686003)(26005)(7696005)(6506007)(55016003)(71200400001)(38070700005)(110136005)(38100700002)(122000001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8639 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT065.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: d7623bb5-f1fc-49b1-c157-08daeff5fa1d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XHipFpSUxuRkpmYA73We9iEN/twARRzJ9JWp4b8kD31H5L2LiedSxZtHs4Jxa2Fw/qp+F19TH2H+OXUlxKJj2rGjpGb8s7J1x4agO4rwo4dXz9+SLfA1FpGEFQv7TssYHh6IRiXEWV64/PokRkNNqw/2qwIzmnPNwdoPT7qXZfniEuPeBypI+8mwTs5R2ZFMvgodUscrW4ZXjBxLylWsSULcczB0zW00V36oudtXDZDnfcnDRMiN4YcQm7CtikF/i0Rqd1qVkhi5yLtVmBVoMsXnrZuGFhpEjS4NJlPTEgLQI6vHi6yPzRlO+nR8Mf0+U3yq67oj79lYIUmP1QiUNE1S8NIJ+HKk31IyGcJA1fMHeSQI/UBDASh4XE0/zCM2lg7xnH9KJVM/26/Fby91gikDouqL+ld1Gt7/y1fT4oh2AKDJsFr8dmPVxiDqryK2ygybJdzlLfb4aAAzSgyk31tJWUmHSd/sUOleWNJclP6vE6rFJtsbQnCqbvUzh0mwxCdp506Qj6Ubb0o7soJv+v+Hv+z4RfT4n5SL0OEdFz/8V32EzY2JZyHnjlPRjtP8qNC0vNFzJxCR4STL2Un1wwH8+gwlDEYgzLiOkZs9TXNXcCBS+nRrsaB8ZAAhpo5NrGj+6std+6psGW/++PttkYYJQjBneQffqf3Jf5SAkAE7F0dEi9bVvdycRFJ6H1M/HxYBABmki1jdxqlHfxORZg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(39850400004)(376002)(136003)(451199015)(40470700004)(46966006)(36840700001)(86362001)(83380400001)(36860700001)(356005)(70206006)(33656002)(4326008)(5660300002)(70586007)(52536014)(8676002)(2906002)(81166007)(41300700001)(478600001)(40480700001)(55016003)(6506007)(47076005)(186003)(26005)(107886003)(9686003)(54906003)(82310400005)(336012)(110136005)(316002)(82740400003)(40460700003)(7696005)(8936002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2023 14:55:09.9472 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ef139786-cb2b-4702-b1ec-08daeff601ec X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT065.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB10090 Hi Julien, > -----Original Message----- > Subject: [PATCH 20/22] xen/arm64: mm: Use per-pCPU page-tables >=20 > From: Julien Grall >=20 > At the moment, on Arm64, every pCPU are sharing the same page-tables. Nit: s/every pCPU are/ every pCPU is/ >=20 > /* > diff --git a/xen/arch/arm/include/asm/domain_page.h > b/xen/arch/arm/include/asm/domain_page.h > new file mode 100644 > index 000000000000..e9f52685e2ec > --- /dev/null > +++ b/xen/arch/arm/include/asm/domain_page.h > @@ -0,0 +1,13 @@ > +#ifndef __ASM_ARM_DOMAIN_PAGE_H__ > +#define __ASM_ARM_DOMAIN_PAGE_H__ > + > +#ifdef CONFIG_ARCH_MAP_DOMAIN_PAGE > +bool init_domheap_mappings(unsigned int cpu); I wonder if we can make this function "__init" as IIRC this function is onl= y used at Xen boot time, but since the original init_domheap_mappings() is not "__init" anyway so this is not a strong argument. > +#else > +static inline bool init_domheap_mappings(unsigned int cpu) (and also here) Either you agree with above "__init" comment or not: Reviewed-by: Henry Wang Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Fri Jan 06 14:55:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 14:55:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472700.733033 (Exim 4.92) (envelope-from ) id 1pDo7k-0008UM-6N; Fri, 06 Jan 2023 14:55:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472700.733033; Fri, 06 Jan 2023 14:55:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDo7k-0008UF-3S; Fri, 06 Jan 2023 14:55:12 +0000 Received: by outflank-mailman (input) for mailman id 472700; Fri, 06 Jan 2023 14:55:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDo7j-0008RI-3C for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 14:55:11 +0000 Received: from EUR03-VI1-obe.outbound.protection.outlook.com (mail-vi1eur03on2059.outbound.protection.outlook.com [40.107.103.59]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1cd42182-8dd2-11ed-b8d0-410ff93cb8f0; Fri, 06 Jan 2023 15:55:08 +0100 (CET) Received: from AS9PR06CA0341.eurprd06.prod.outlook.com (2603:10a6:20b:466::14) by AS8PR08MB6614.eurprd08.prod.outlook.com (2603:10a6:20b:338::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.9; Fri, 6 Jan 2023 14:54:58 +0000 Received: from VI1EUR03FT003.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:466:cafe::18) by AS9PR06CA0341.outlook.office365.com (2603:10a6:20b:466::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.15 via Frontend Transport; Fri, 6 Jan 2023 14:54:58 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT003.mail.protection.outlook.com (100.127.144.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.16 via Frontend Transport; Fri, 6 Jan 2023 14:54:57 +0000 Received: ("Tessian outbound 8038f0863a52:v132"); Fri, 06 Jan 2023 14:54:57 +0000 Received: from 0b56ebb67809.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 526C064E-1FEE-4E50-8EAE-57352C2BB4C2.1; Fri, 06 Jan 2023 14:54:46 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0b56ebb67809.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 06 Jan 2023 14:54:46 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DU0PR08MB8639.eurprd08.prod.outlook.com (2603:10a6:10:401::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Fri, 6 Jan 2023 14:54:44 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::d1d7:166d:6c34:d19e]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::d1d7:166d:6c34:d19e%4]) with mapi id 15.20.5986.007; Fri, 6 Jan 2023 14:54:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1cd42182-8dd2-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DG4sc0OudoXcRpUzDMDRap1+qqTUrPvf4wRtlmnKiSA=; b=90O2dl5eyYiuH1YBAQZgg23+FPwdTPXuDkAeJ1hDaVheY5OfE2qLP7jn8cRf0eHTuSukvatFNVGrmRje01hxsxDxHIOmiBJq1MXiEMXQLPwLQtgGT19C6CEnXrOb1cBIMXsGDfcYaHWx5YKsyGBYeLjH0mN5tbmbMg+baIzUnfA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y6uM9svt7xQB4r+KwcwNlZeQBPlGAIZ47wMu4zeEf6uv27mLWwjkXsTh2SkGCQnqmPXefHkcZmJcgHLB6dEkMhiwO8ryjGatSGn1fCvTcS+IjrXYd1tzMYa4ORQKCb1c1W3mXts0hYFk6m6+k8hSKuFEifSVMRAU2n+6q8A2xel/M/Xc9Z65xFJKqqsJnku2r1hzbOrXU4hF6Gzk7HB+JQQ6cvmDgC9Bgwqsgxjm0xUGub+ecI52ntNKR93dusCm5eDJ1sBKBxRQwc45v/eqnQtsxwMKwpmIK06LFjo4xJHgUtUE9PlpzxiNwFn2ktl+MCVhDniSpSM2irbto6+PLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DG4sc0OudoXcRpUzDMDRap1+qqTUrPvf4wRtlmnKiSA=; b=TZFW/QUrCXPyIb9pgN4MtxtsdjHSEo9pvJmiaafmEhDNcaTvHcFRvdVwe372cWaJIt+s6MZ6IY14Dy+pCwrGdaV20K4P4UW0auHhZdbDOIjfjfNo7AYm1U7C/b00bPtqnT3spCZnDr5UlW9lmihUtzO7r7RMnzKF6nxMRYUvByj438IoFxLkFFP9Gb4HQPhk1Qz1UiSbkxBgCHwi0EAav3vMutYKyhuFsE8elx4C+qNAeD7GvvwoSwjrZOnCZN7HRw03AH9bh+NCrafYaZZMFSo4PKiFhibHj91L/L9b2CaxL9QZZ5C9pSFf7duyqn6I32thrj3QjBFTeUu4suZquw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DG4sc0OudoXcRpUzDMDRap1+qqTUrPvf4wRtlmnKiSA=; b=90O2dl5eyYiuH1YBAQZgg23+FPwdTPXuDkAeJ1hDaVheY5OfE2qLP7jn8cRf0eHTuSukvatFNVGrmRje01hxsxDxHIOmiBJq1MXiEMXQLPwLQtgGT19C6CEnXrOb1cBIMXsGDfcYaHWx5YKsyGBYeLjH0mN5tbmbMg+baIzUnfA= From: Henry Wang To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: RE: [PATCH 12/22] xen/arm: fixmap: Rename the fixmap slots to follow the x86 convention Thread-Topic: [PATCH 12/22] xen/arm: fixmap: Rename the fixmap slots to follow the x86 convention Thread-Index: AQHZEUiBSJDHdzI2P0y6FBuQ6cG/JK6RkVVg Date: Fri, 6 Jan 2023 14:54:43 +0000 Message-ID: References: <20221216114853.8227-1-julien@xen.org> <20221216114853.8227-13-julien@xen.org> In-Reply-To: <20221216114853.8227-13-julien@xen.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 5CCACC92360311429CBBF1ACCE56BA62.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|DU0PR08MB8639:EE_|VI1EUR03FT003:EE_|AS8PR08MB6614:EE_ X-MS-Office365-Filtering-Correlation-Id: a3d23b52-799f-42fd-c8a7-08daeff5fab2 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: cagJFJsjL3U8dHLo2wgYxmFhDL+KW6ZO67mRrAVZWWECZD4h2sKLuFf/U0Sy2C/IOvDa0gvXAVkyVs0YlXFqgzbSpxjmrIVKCMCNO9NHJx1TVMTkEyP2dx/7h0agpt+ufcUcqhJQGqfhUamR/AEXX29n3PsFNKohPWbGv4BgsLFwWGAdZrOnguZ9LDIf5aed0G5p9UJrcqVrgpYpFm09iyya+kLcMRh1w66UKasFtidydBcufOaGLepKDKusGqsDNRVXDAysMiuutO3Mr+1Fb4WfUfv3NX8bjxOnSJ4T3kWOWKaidTsAqIGHq94YJrofE6T8Fp9ISpXkxhb4aWaP4N5TF4HwWRKrq621HZnSBw3AK7TuCkbPAyZJiZEPLiGGkTivAD8jrizZ5gAdfHf9T4obWcHpHdpK/jwhG0ysIk8iGvjR+b8yNg8spwCYEVmaaqdT0kEQVjkL1dD3zxWTGBeYBGAF1BjjJum4so1m2bnNfh8jB29bmsx3lGWzo2pxgDTARzy/Z8iFm2avm1utj8Z4/qf4p8TPfW7yyyy4pxXTM7B9Dh4FPYo/aqi3KL7KY5P+Zb0uBFcpaSKDhDi1KLAM1s5sOutp5APXTPsZAa8+0T5FD+6gGmMunXKyNcurgZG42XqUSZyV9dxcGVxfovDdLF8Xedd/cNPij7bAaaKvnjWGyHRgZAHn7Hk5BMV0RcyPL54pI2lY3SGJ3SNKKA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(376002)(366004)(39860400002)(396003)(451199015)(64756008)(66556008)(4744005)(66476007)(54906003)(66446008)(8676002)(86362001)(66946007)(478600001)(52536014)(76116006)(41300700001)(4326008)(8936002)(5660300002)(33656002)(2906002)(316002)(83380400001)(186003)(9686003)(26005)(7696005)(6506007)(55016003)(71200400001)(38070700005)(110136005)(38100700002)(122000001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8639 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT003.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a4a9665f-c49e-4bf7-96a6-08daeff5f25f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UlrHIm40oCwryi13wX+5etIYW9MZdl4YYPYIz4DKR0CCGqgftYh9uqH5jlPC3zEUVFKN77hN7M1djsGPnifwhu/LDSMpL5hs9lpgYdTCM51XIYRi6mDO+3UgiNP7hesbFblpVarRityPZoRuxaC28v1np9xKdtAyUpvBI8bfx+OZPewhOyFk3qMhMqjljgRzCaZHRKyOgHQFrF+7ZVBxnqqNSo8JLAHgccwXpM+PZix/SioYieoZIsqnt7nhFr/iJt/NwLUE09Df2hh2lzoUHGla8CejPYG0yFo5ejQnf766NZhEX7gyrhGO5XBLyO1kfW0YM6+C0Gv0sIlHhgVXASril2Cf3/woADKXV0yeGrWZT2dapP6bJNSjx+Vek1Tm2QhAj53Ie9wqO6Fw0U+RlOn7nGw3KO7CcoDK1gxvJm10NTiR0fAKYFVTktQh9/MI2dvSsFElrENEriGEQ21gVjSurTOKYBnljFidkZwPqN9VeLYBj0uv35Lh/0hL1ik3QzVznP4nZwttzlM5pBIQ54CxDmyObShV1V6erA0/mr1XXJ7rdsldVBHC1mz4DPxZ6p57n7f6VZj7jLHgY/EgoX0T+gG8qJsy/oIusp1QWQ4IQfE/1OPHEo6EZd1o8asiK5SqkCANH8Z8TmIfsx0sLmq2HxEOsEZ2j59wCS0IKC1iXQilFfphq6SyClJNkM8TjD6nOJzr5lQdKS98KIxOQg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39850400004)(346002)(376002)(396003)(136003)(451199015)(36840700001)(40470700004)(46966006)(6506007)(81166007)(7696005)(478600001)(82310400005)(336012)(2906002)(83380400001)(47076005)(54906003)(316002)(36860700001)(86362001)(40460700003)(33656002)(5660300002)(110136005)(40480700001)(9686003)(55016003)(186003)(356005)(4744005)(8936002)(52536014)(26005)(82740400003)(70586007)(41300700001)(4326008)(8676002)(70206006);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2023 14:54:57.7455 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a3d23b52-799f-42fd-c8a7-08daeff5fab2 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT003.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6614 Hi Julien, > -----Original Message----- > Subject: [PATCH 12/22] xen/arm: fixmap: Rename the fixmap slots to follow > the x86 convention >=20 > From: Julien Grall >=20 > At the moment the fixmap slots are prefixed differently between arm and > x86. >=20 > Some of them (e.g. the PMAP slots) are used in common code. So it would > be better if they are named the same way to avoid having to create > aliases. >=20 > I have decided to use the x86 naming because they are less change. So > all the Arm fixmap slots will now be prefixed with FIX rather than > FIXMAP. >=20 > Signed-off-by: Julien Grall Reviewed-by: Henry Wang Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Fri Jan 06 14:55:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 14:55:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472702.733056 (Exim 4.92) (envelope-from ) id 1pDo7v-0000lO-Pc; Fri, 06 Jan 2023 14:55:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472702.733056; Fri, 06 Jan 2023 14:55:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDo7v-0000l4-MO; Fri, 06 Jan 2023 14:55:23 +0000 Received: by outflank-mailman (input) for mailman id 472702; Fri, 06 Jan 2023 14:55:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDo7t-0008Ex-UQ for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 14:55:22 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2082.outbound.protection.outlook.com [40.107.22.82]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 24680166-8dd2-11ed-91b6-6bf2151ebd3b; Fri, 06 Jan 2023 15:55:21 +0100 (CET) Received: from AM6PR10CA0102.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:8c::43) by DU0PR08MB7924.eurprd08.prod.outlook.com (2603:10a6:10:3cb::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.14; Fri, 6 Jan 2023 14:55:19 +0000 Received: from AM7EUR03FT007.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8c:cafe::9e) by AM6PR10CA0102.outlook.office365.com (2603:10a6:209:8c::43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.15 via Frontend Transport; Fri, 6 Jan 2023 14:55:19 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT007.mail.protection.outlook.com (100.127.140.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.17 via Frontend Transport; Fri, 6 Jan 2023 14:55:18 +0000 Received: ("Tessian outbound 6e565e48ed4a:v132"); Fri, 06 Jan 2023 14:55:18 +0000 Received: from e09339cda5a3.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7DA152D5-473D-4C33-BD83-1B60E4AA420E.1; Fri, 06 Jan 2023 14:55:10 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e09339cda5a3.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 06 Jan 2023 14:55:10 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AS8PR08MB8276.eurprd08.prod.outlook.com (2603:10a6:20b:56e::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.9; Fri, 6 Jan 2023 14:55:05 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::d1d7:166d:6c34:d19e]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::d1d7:166d:6c34:d19e%4]) with mapi id 15.20.5986.007; Fri, 6 Jan 2023 14:55:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 24680166-8dd2-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bB7mfEV+3gGaxVSg/wMmc8Z8VBSo/9rvzcBJqcrEW6E=; b=puFJSeB392T+R3NumBsyprgvCxKLnijg9owvd748IFyIboDftf6A/9sElKDNlHbCRsm5q3w6LOsffYO/OHnAu+kU/FUjOkLHAfMJZj0mssN0no6kAZK8vvXvkLrb/K2NRFCfvP1nxmq1HlswA+2y41b7gs4P5w5R7FFnbqnNJzQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X8atF9RdBlD1kySDpW94N0I9Az1vOquWr9G77/EQVtFJfSi70MmV/Qgj2enwQihYlMQ2+PR3od9zEnHJ83kYXo4A1lf7qitm8qxcggPUlvolcn+uZYV8R9LuegOe3KEsa62jDx2PW5HuGiVi+wdqATywW4mCyWgnnm9sOWwJkgFVlh6vAmNbjJUaAV27bgS9JStqbs6iQKXKRDfJCj4PDx9y9ZGsKE7o9RWt1QgM53/gZyPwR4sFhT8kG44iujKnEB6av07dgPRkaoKUNq7pMB2yEuKW/abjsdON+zefIgnY4AeJzkeTRfP8dR1PW2XFg5fdwP0Vrx2XaHwcoUS4iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bB7mfEV+3gGaxVSg/wMmc8Z8VBSo/9rvzcBJqcrEW6E=; b=G+hLPZqKi6CnfJwl/Ec+diB7WYMxiAddUDdxwMF05XmJLX1OzXLW0Vk6oNFWPtlo7lipM9Mn9dlzKpe8G0gnLzdCKqibNwowi5oi7L0vZAMa/aVBFqbzvfsxo4jvjLoPvcGIJnSRaUjk/r2aCzgaJPVJ8Sgn3ecGBBpkYYc2pHAc9E9h5vvQ72JQpjiwq0lL/u5RRjue79m0K78snn5Spyq7eMoiv0P4FSTaA7Whd/KLlzYso1nAPbXKJ5oiDQ3xDGj8uNIGZScOECbS3RnKpx1p2eELpNCwLRgQxqkF3lXX9MYWl8l/bbdWcYP+RyIolJr90ijEnZrCWGse1lEYlA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bB7mfEV+3gGaxVSg/wMmc8Z8VBSo/9rvzcBJqcrEW6E=; b=puFJSeB392T+R3NumBsyprgvCxKLnijg9owvd748IFyIboDftf6A/9sElKDNlHbCRsm5q3w6LOsffYO/OHnAu+kU/FUjOkLHAfMJZj0mssN0no6kAZK8vvXvkLrb/K2NRFCfvP1nxmq1HlswA+2y41b7gs4P5w5R7FFnbqnNJzQ= From: Henry Wang To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH 21/22] xen/arm64: Implement a mapcache for arm64 Thread-Topic: [PATCH 21/22] xen/arm64: Implement a mapcache for arm64 Thread-Index: AQHZEUhyvmaM0DFPMU2aLMVoP+HuFa6RlnZQ Date: Fri, 6 Jan 2023 14:55:05 +0000 Message-ID: References: <20221216114853.8227-1-julien@xen.org> <20221216114853.8227-22-julien@xen.org> In-Reply-To: <20221216114853.8227-22-julien@xen.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: DE5208C9CF86F842B8BCA8463358CE56.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|AS8PR08MB8276:EE_|AM7EUR03FT007:EE_|DU0PR08MB7924:EE_ X-MS-Office365-Filtering-Correlation-Id: 0c4f5ae3-c42e-4cb2-ba48-08daeff60718 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ukdUnozmQMKQ6pzLifjqnjK8/ooHo7JyIDuPmvdrU7IqhmW/3byjGqRD68LNOPS+s2ZBltQeRWGkYCEeUxpbILpi7hAQaelQxOWQZvYvXvWveHi+duqYny9U5sOrdUhezVt0FXvMX9Kw2VKpmiS219FLuZEg6Tt0MbbMtHQ/qYHiYIzrocnG9Ab0Bz1K0WWCJplrm7CurwB1giMgXFmstGU+3KwbIXN28ZuhkBtwOQ+LsO0VGBMy2iWGgj2eS4Ua2SEHsakhfQmwvtdBUOATK917w/YBfR0iijjL26uM3j9xmQ9OZp26Hp7LdOsqq6jguzilNF3xnNZE11nnn8fO76IZIboawEvhVFc1ItVTJI0lzmHQa4ceQfUj/K1gRHBD2slNMDFhZVSl+qvMz1Kdww/CIfY5T+XfU01JCJZ+46zL9p5EjriZQpC2UQpZageMwM3EDrkHCBmX5h1D3niKfwIP8NmfcxxC4kiSTmwyRDW2JeeJQsd6ec1dfmLqXR/EfC+ebLXopk244DieY9m1VbrD40KL0E2jPYEJpj/nvKoWSJa5xAjsS6qEe84J+PZAYjBTsP0fGNvQ9ZUub4PP0vvssOX233Ou/YV/w+QHDPT/9rKeHVL8+y1LAzhGpFQPzpeupqUw/5Vlp7lDdmDyF7DWuiiiqPI0We+K8OqosEmDWH4UzEUEh0viRubWwenEFujSayAp5g2vgX90ggUvAA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(366004)(346002)(136003)(376002)(451199015)(9686003)(86362001)(2906002)(316002)(110136005)(186003)(55016003)(38070700005)(54906003)(33656002)(122000001)(6506007)(38100700002)(83380400001)(71200400001)(76116006)(478600001)(64756008)(7696005)(8936002)(8676002)(66556008)(66476007)(52536014)(41300700001)(5660300002)(66446008)(26005)(66946007)(4326008);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8276 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT007.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 02c45455-cb9a-4a70-4736-08daeff5ff04 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FzOsndoCTQoQS+Atcvxo22dDwB+vKIoCf+2jAETww4rGMW1yYo1r+quRBaAlUDmh6eejwrjl0jZ0Sz3prwFzTKNycNGIgw2b8GhnvHGhexseS0Rd7xAeCSvQL3qxmv54AQ7te6k3ivUAweNHrILgd6kcIsVhYK7UyMeS3lrbgCphtLYfOuXogSKqFA1prIZFO0/SSV/Kh39UtXxFD7lUfSsM0FLYe2sjp5ZRVlZf/opbNhx8V3gJ/AFev6t+YZmKL+91StKv7lkRR9X9/InMTgLosMKYNhSaclXg8WrWvjzOjTMm6NahLxVUvxl6vBZADlPDy/iD/xZvMeQF+oM71PuQx+VsL1egkv6ZvopR3rnkm3BXAU2Z6oe0ZGOnW5gHLcPe/iqtHLOnmQSUAEGSmeSa5zluw613Zgfp51oEW2mKKTq38IPXNDg3k2WF1nMHOA+mZUJbGvDDY0lKz2DjCN2BCB3p8E5N5Ks/PALopoORIxrdRm3zNZj1NPsMSSGmEE9bycwy3JyXwX5GwGZ59dy0x9rUtiateYUsDVygB2Fpxj3QyKxt0qPxp4M7JeXQZG2PTP8KUFHKY24IyWsfzxmmX2QEBtksJszCopd6ZQPjlh3fxmaR44/oVv02bS0HGxg3+ozAYKKKOxKXz60V15Li+CjyDqmYMh7mNfNKKYInNNfDZMvQeC+rUNmAsBlM4s0pa/pAIuKXYDkotZ1fWg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(376002)(396003)(39850400004)(451199015)(46966006)(40470700004)(36840700001)(316002)(41300700001)(70586007)(8676002)(86362001)(54906003)(70206006)(4326008)(110136005)(8936002)(81166007)(36860700001)(82740400003)(356005)(33656002)(6506007)(83380400001)(336012)(107886003)(478600001)(9686003)(47076005)(40460700003)(52536014)(2906002)(40480700001)(7696005)(26005)(186003)(55016003)(5660300002)(82310400005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2023 14:55:18.5932 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0c4f5ae3-c42e-4cb2-ba48-08daeff60718 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT007.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7924 Hi Julien, > -----Original Message----- > Subject: [PATCH 21/22] xen/arm64: Implement a mapcache for arm64 >=20 > From: Julien Grall >=20 > At the moment, on arm64, map_domain_page() is implemented using > virt_to_mfn(). Therefore it is relying on the directmap. >=20 > In a follow-up patch, we will allow the admin to remove the directmap. > Therefore we want to implement a mapcache. >=20 > Thanksfully there is already one for arm32. So select > ARCH_ARM_DOMAIN_PAGE > and add the necessary boiler plate to support 64-bit: > - The page-table start at level 0, so we need to allocate the level > 1 page-table > - map_domain_page() should check if the page is in the directmap. If > yes, then use virt_to_mfn() to limit the performance impact > when the directmap is still enabled (this will be selectable > on the command line). >=20 > Take the opportunity to replace first_table_offset(...) with offsets[...]= . >=20 > Note that, so far, arch_mfns_in_directmap() always return true on Nit: s/return/returns/ > arm64. So the mapcache is not yet used. This will change in a > follow-up patch. >=20 > Signed-off-by: Julien Grall Reviewed-by: Henry Wang Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Fri Jan 06 14:55:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 14:55:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472703.733067 (Exim 4.92) (envelope-from ) id 1pDo7z-00019w-40; Fri, 06 Jan 2023 14:55:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472703.733067; Fri, 06 Jan 2023 14:55:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDo7z-00019h-02; Fri, 06 Jan 2023 14:55:27 +0000 Received: by outflank-mailman (input) for mailman id 472703; Fri, 06 Jan 2023 14:55:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDo7x-0008RI-Ee for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 14:55:25 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on2048.outbound.protection.outlook.com [40.107.15.48]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 258e20f2-8dd2-11ed-b8d0-410ff93cb8f0; Fri, 06 Jan 2023 15:55:23 +0100 (CET) Received: from AS9PR05CA0282.eurprd05.prod.outlook.com (2603:10a6:20b:492::30) by DBAPR08MB5765.eurprd08.prod.outlook.com (2603:10a6:10:1ac::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.9; Fri, 6 Jan 2023 14:55:20 +0000 Received: from AM7EUR03FT041.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:492:cafe::2c) by AS9PR05CA0282.outlook.office365.com (2603:10a6:20b:492::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.15 via Frontend Transport; Fri, 6 Jan 2023 14:55:20 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT041.mail.protection.outlook.com (100.127.140.233) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.17 via Frontend Transport; Fri, 6 Jan 2023 14:55:19 +0000 Received: ("Tessian outbound 0d7b2ab0f13d:v132"); Fri, 06 Jan 2023 14:55:19 +0000 Received: from 8f9292e1ac63.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7220374F-2E78-4048-A5A1-36C49D8790D3.1; Fri, 06 Jan 2023 14:55:13 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8f9292e1ac63.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 06 Jan 2023 14:55:13 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AS8PR08MB8276.eurprd08.prod.outlook.com (2603:10a6:20b:56e::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.9; Fri, 6 Jan 2023 14:55:11 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::d1d7:166d:6c34:d19e]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::d1d7:166d:6c34:d19e%4]) with mapi id 15.20.5986.007; Fri, 6 Jan 2023 14:55:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 258e20f2-8dd2-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Pvb4D82JzYha9OwUYmFkfhpda4iWTVoaQQUM1CakWko=; b=zaPCpssBGC6uqfrsAcLDqZm38Jv5/amYx6w0JVnnONXRWT55fpV5RoZqmIrEwUIoMH8bctUJPpLD+9mAZzbcev3iEaG2g7gKCaL/b4kjqVLx0txk8UBdMW6APi3xMOyLW2iOv5iS5WyEVtIBPyJGwze5+T4ABctKaGzIxgh8bns= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OzVdum+7CSjxhKe2Z2G+T37IUNFKTKFriY2iJoxOz6cbxwyHjmkhfJx5d3mfHYlKUxtCx5pkki0/1asrTIXBELbkgN86LAWj9cQnikWlvrfC3Sm3bbYTqzN/qiKiuZB/7THpYZVAa/AhqzQFO+439Z8HCp/o/kyoHLFATvcq+/bOtFBaApnVjw6px75IZjBhyHOzbzgS7sPg0jq7Qld4bzByPsyOeIig4nAe5hUe4kw1gpWuUOeOdjHQd4wy9z9Hsu5SQdVnP/h2n2WwrUe/EKGA8l7Raku/2g++7Brz4BviGb2Lc1+wDOvqPcNQN8bDyvRw9mGh92BOuqHVMseC1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Pvb4D82JzYha9OwUYmFkfhpda4iWTVoaQQUM1CakWko=; b=KtDvqMcies27SHY2M+lKqeUZmXejBtrtUSvlKnzhkE1LwRig6HXVquxeLavBaOYVYSvldfRsSqz6Wv7xuNwBQNPlG4rjC2bPUlZAWYuZUWKMBptwvaHNPUjoihM2piFRCChfcFTHRZwseuE/0S9HHDSOGCIwD6OtzA65b6AFRZlO00fxJOeOwQBpbxgkYSoYUJTZfAQYtS3boSGALi3k87unzefNr42dxKm9Xt8aN7QPBH5Lntr6jPZJYDmZG3cCtaDs/lLgl2v78F6d3BTPcNE/cXABOy55XoJ5G/ddVHzO/GS65gC/Va9WD//Fd1cKoaj8sM5Kuw4clB4dsB3Djw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Pvb4D82JzYha9OwUYmFkfhpda4iWTVoaQQUM1CakWko=; b=zaPCpssBGC6uqfrsAcLDqZm38Jv5/amYx6w0JVnnONXRWT55fpV5RoZqmIrEwUIoMH8bctUJPpLD+9mAZzbcev3iEaG2g7gKCaL/b4kjqVLx0txk8UBdMW6APi3xMOyLW2iOv5iS5WyEVtIBPyJGwze5+T4ABctKaGzIxgh8bns= From: Henry Wang To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Julien Grall , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH 22/22] xen/arm64: Allow the admin to enable/disable the directmap Thread-Topic: [PATCH 22/22] xen/arm64: Allow the admin to enable/disable the directmap Thread-Index: AQHZEUh1e0APpjxFfUWN/NZXS3PZ8q6RmKBQ Date: Fri, 6 Jan 2023 14:55:10 +0000 Message-ID: References: <20221216114853.8227-1-julien@xen.org> <20221216114853.8227-23-julien@xen.org> In-Reply-To: <20221216114853.8227-23-julien@xen.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: A6FB936F6608A0469363276AA3709019.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|AS8PR08MB8276:EE_|AM7EUR03FT041:EE_|DBAPR08MB5765:EE_ X-MS-Office365-Filtering-Correlation-Id: b46bf93e-0806-4662-5142-08daeff607e1 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: qtra5IawdtYSHZQGtqyEjs/He7J0Z+2eiRTZMrK+hQYyFUI3AXm8AVFE9PfuWCztjUJGoQ3hOMHXWMaSumbU6bph64nnVfzM6AbBRfWQYfn+/K5PVJkACydbOsjI0/ShPD9iZXI37K+R2ap0cUbTRKV9TzCYe8h8IZzvEV5f0ebg1qJl7W+lWMAmE8oc0WTeC+eXNSeIIJgUUbLwCjtwcZv2eNhIMOK5iD72D+6MUBpk/h3rrTIkYO7/66ATd+MhMO0tdfnENsUjrwFkWt/DMoHVpawKXPpz2mLufuJkk2obh7O7jtM1wLH7WBn13kor7ZSOJYckAoTvVSz3Z106DVtbnZWBNVF+2jv6IARHwALxcTSX8N0aPlyFPcJFnlD0D5avbJJR3kQtRkM6TJIMinIOZm6vPGfsL/Ab0vVQJ7wnGTfAKiQQE0mDqYsVL+kfPxmJIqhArla5pa6HGIlmJv0dui7oqHRBWGRqZSyO3yxnN80igsjp2vObDh5/XbIMsi+oiVS44cKl8UPhxS3uNeikCLQcrYz0y0VIHfzoIJ+p0M5AUMCTMVt+dVNZiXd213d3vhMDtXn2vhZPTmiqeTV1lyOLZE/2glPLdXNQXOLq89bDeMj+KyuZLvrhwLSTRN60soXCgoCmh8Az9Qbu24iYW3ToN+0H7QrYeDbcmY4y1I8wnaZXrkKMmfAMIy0Zw4PqzR75f+fG17cCuFmgRg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(366004)(346002)(136003)(376002)(451199015)(9686003)(86362001)(2906002)(316002)(110136005)(186003)(55016003)(38070700005)(54906003)(33656002)(122000001)(6506007)(38100700002)(83380400001)(71200400001)(76116006)(478600001)(64756008)(7696005)(8936002)(8676002)(66556008)(66476007)(52536014)(41300700001)(5660300002)(66446008)(26005)(66946007)(4326008);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8276 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT041.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 2a94f699-ac09-4852-da28-08daeff6028d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uNzPYVJ8DDoYaVm4JDPfmmqUruzP/3TbFdui6aQ3eMLqzRr46E1jxDylHMRATVZxBROCFFixpqC9hoH1DjwlnAhwOVsVCP1Fm9j6/rdA0HMsajXc3eFK46YJzye3re4u1J4EioF8EBIR3YE3j2IsLVBzAp4ARvTe0rbWExVC+XVtiag3sD64JJ9pwaMmbq1pUzntDiaLh1jkSsIMHrcZTUQrsSK89AC8OP6eHJJ0Eb/nI8E+qYZ1w2dDcQE7FOYVOJTp+TvFoElXqqT0odBNVyywjrRfL8Bkq0V13EGIOxFkdtbtRQSdsFx33FvffuGFzSjwMOxv770EJ94i7TLwJVCN6/Xd/vmoxhxouF93CxGuRMT0hklwi7KEKFJpDTjGMyBIjlRdL8Mo6q0zcoepmXQAcPevM8vJeltWcJtIhwcl2CvOAOKUzWKw1VRDUJzaAciUpMMMiczcw5XXpBIAgvbL2PhaROYlNk06YW1EtWQa4k5CZj/daxqIwdHDAh0gu+ZdlemghtL6UxOk9WaPB5ZJmTj55xEbYRIUFZj2vA0XZ2tCr7ltaa3BQEr2VQFMZKjLb25t43PJ2nYiF0NAU6x6ikkL5mgRzeNnWjXkz16ycwequiIEBobm/7XytSQh11ITrXV+YeBw77jk5iHID/+L6akf+5iSslPLgSZULMtrdmZmMIm+dT5eckdolwpGLsSgUgXggC5xLKy5B9YgNQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39850400004)(136003)(346002)(376002)(396003)(451199015)(46966006)(36840700001)(40470700004)(81166007)(82740400003)(40460700003)(356005)(2906002)(8676002)(70206006)(70586007)(5660300002)(33656002)(86362001)(83380400001)(41300700001)(4326008)(36860700001)(8936002)(478600001)(82310400005)(54906003)(7696005)(336012)(110136005)(316002)(55016003)(52536014)(9686003)(40480700001)(186003)(107886003)(6506007)(26005)(47076005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2023 14:55:19.8921 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b46bf93e-0806-4662-5142-08daeff607e1 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT041.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5765 Hi Julien, > -----Original Message----- > Subject: [PATCH 22/22] xen/arm64: Allow the admin to enable/disable the > directmap >=20 > From: Julien Grall >=20 > Implement the same command line option as x86 to enable/disable the > directmap. By default this is kept enabled. >=20 > Also modify setup_directmap_mappings() to populate the L0 entries > related to the directmap area. >=20 > Signed-off-by: Julien Grall >=20 > ---- > This patch is in an RFC state we need to decide what to do for arm32. >=20 > Also, this is moving code that was introduced in this series. So > this will need to be fix in the next version (assuming Arm64 will > be ready). >=20 > This was sent early as PoC to enable secret-free hypervisor > on Arm64. > --- > @@ -606,16 +613,27 @@ void __init setup_directmap_mappings(unsigned > long base_mfn, > directmap_virt_end =3D XENHEAP_VIRT_START + nr_mfns * PAGE_SIZE; > } > #else /* CONFIG_ARM_64 */ > -/* Map the region in the directmap area. */ > +/* > + * This either populate a valid fdirect map, or allocates empty L1 table= s I guess this is a typo: s/fdirect/direct/ ? Reviewed-by: Henry Wang Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Fri Jan 06 15:02:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 15:02:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472734.733078 (Exim 4.92) (envelope-from ) id 1pDoEz-0003an-TS; Fri, 06 Jan 2023 15:02:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472734.733078; Fri, 06 Jan 2023 15:02:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDoEz-0003ag-Pa; Fri, 06 Jan 2023 15:02:41 +0000 Received: by outflank-mailman (input) for mailman id 472734; Fri, 06 Jan 2023 15:02:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDoEy-0003aa-P8 for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 15:02:40 +0000 Received: from sonic317-20.consmr.mail.gq1.yahoo.com (sonic317-20.consmr.mail.gq1.yahoo.com [98.137.66.146]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 284c4ba5-8dd3-11ed-91b6-6bf2151ebd3b; Fri, 06 Jan 2023 16:02:39 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic317.consmr.mail.gq1.yahoo.com with HTTP; Fri, 6 Jan 2023 15:02:36 +0000 Received: by hermes--production-ne1-7b69748c4d-g8q5j (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID e73641d6e4425e24aadb96822c955bf6; Fri, 06 Jan 2023 15:02:31 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 284c4ba5-8dd3-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1673017356; bh=0VDm502ucQEkSIIWDIcrXnsroFh40vokq/Ikx7Y6nk8=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From:Subject:Reply-To; b=iyzlupQ0NS73Y5VIXErGypapDPeMcOXKm4mG8BWrz6ebrPUZEc4f2DkAaBV1KGmg2mV+XPANhp24iEXb9SGt/YErUOOqPznQTmQka4Xp+NeTELGnd5KhJhlaI4reTdrQvPuBd0FEEGjUPcTcFvUOVGp4hBjJ8F8pSt+hP59N1L7mTsybJjFkOWz2fFFTXoUwFjo3A3eWPoDJR7AfaMtO2HEgpg6MQjlP/kt1uS51zF3B3veq8uBVtsDWzeDb9nVuPfK8y3b3hcpqKfAgtAOvteeNOYbiNo7MJlvdRWUIR4YybjJll8FHXNBSececiHcSX972vBBuRwZoho4VN6dMlg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1673017356; bh=oRw9T96FHEYw+EaVMMY57P6PCdN82bq0am7S/TzbQFq=; h=X-Sonic-MF:Date:Subject:From:To:From:Subject; b=UNjgox1dsuEuzIPLPIC4sZDgSpPa5Etnwq8tiv2rYdQRDgYDfJ7cOPA6AUCF45LcALh1KyTNXv8HOogzllAMSPb6smJAnfO0enrZ5Gfq3haiqAyzO44zc9KMJ+/0qTxrhsVGwwSuWveaaCcaCEtqEvOAiacQ5r3Xi3pJKA8bBmwY+rz2N9g+0vOibsuY2iu9nfEnrtNudlG4XrHmz8K1ur3rGtm8tfR1NKmu0hH28aTXEY9h7s+PflNAO/iWUJB0TiWBRdqfxH9B5yqAFjLQppKJqsUsoQ8jSitgcPycHaTJjTrriBA4ziSmDdasi10pQxzZaKPufiwBPMYUnpteVg== X-YMail-OSG: .Uqmgf4VM1msNoeUWzjybWiLGsnPNeWKLnowVtNS9ZX9bjNd9b78LRkGTjcqfVB 575A2Xmw7k5SQwscjnM_GjoW.JV.XkZvtH2.A0Y.iuQkSD1NGfPBJ9.8847ZcKwZbQwh6lSE4iYd PMb1ITHJ21KKDdHU6eg2TPKMIiPbvMNMyeQN35NOI5.l2BxfOzCBeHot4j6Xpyeopdc3ci.jTcb3 7LrAZc13o_AEwnpmumOydFn4VpuFa7H4IqDn0AeL1QnbL7feWGmjfjFWJdT7dl1T_Ryo2fTTj7Lz EXbXjzZ0DJ.2JOIb2MBn50UWpQAKDcfhmTi_TR5MveD9cRqjc7kptVtys_t..D4z6JKOpYHKl_MY yPg7BSFf2KsVzinONTsKfBLxMV2dqj8rzuuKXr15oczoyk_rq6H1k5peuF.H0D9Q5MxCx0hIEKVh fW4j2ZSd_jd_Ft605Gv6qap5IOrxPbO1fl0le_ADwXqbBROycLMdYvImy.OA_KSuhdLBgTdmlDaR EkCJkaRBxU4nN9tjYp5EIBKel.rSCheKPV3mdFPYrngGzgZ9KTS3u9xD3SeA9yaEoloG0QKIE5xj qCAlXWIdK593knMKdwg8kNJeXVlBNZ9kte5PH7CPIZ5dCGgl.Teq8tzzPI7ShZpbCkk1JAMbqIj9 ZUGUGJ_T1Bxg3e3NNkkyZZxgD14XdaaeF1Dw7yny6PgOHRMRed6hJW1wFLvFrdqnzSUOCSe8LnD8 0wdHdzEHUxvCt25FNHHVYPtcs5VsSMBT7o_b2oAw8ZBNIytEB2vKIl4QmAUf9zvl.zMI1O2b8imH 7Hw7as44Vt5rFbP4BPfOEbc9ys5ojwn_nStmfxMrtXlGWVTMXfJcYdQEXqPMmENf4NSdj2J3zlSG K92lo.ZqMDvWlgHGtDdZMbmmODvRpSpt5RQgRORVysAH_El98myuugLUO7SlkbU_f4SQDZ8FKR2b 5N6ohPKLpV41FXb5U1CuFcdrjQ7Kj4sH07dA_bYPrkkkMYWZhNH28am_ZuOBc_fHhXqH0uPrWaCp sMjuHroFNVO0IeV.ZQGroX8dtBAtFKhW988yHl_umYCW50_Qyb6t5jMFRR2kWXtAQc2QBK7GUlXx kZchz_tUETzoJnfgu2bMtCtDhRUn4EYuEN1ixTSPjlLi_QBofr5ve.M7rQ1GYIeDG.OefAbmcrR5 4MXmTSu7RcvJVuhns11yuu_3DcSK8dOxVzPsCBRbAjKpSyQa9u3jbJ8Ifw5GQrbQtyMQetVev731 lJ4mtSYdF5a0.jbJT9lZFrumznU8eZwtLeKLQWDTuF4rUBfcDgfXQN19Tg49G2nHnIV3SiEb0FeD sZbYld168j8m4ELRCH4ddFO_ilHKcWMSSOHnsJ0AjbN.tNuFH3gwtMrGlMqnSHOVyU15NGnEqgPS ZM3iheGPNaDpBs9DOD5IjKUvlqoopHmiOFTcu9QKPluUQWXLeljZj7xRlGFLD2PsmVsAj3KCS6JM 1TBsQuH9TaEYg1QMKvud4JWn6VuUsCPikOhxoXDtwHEC5L9H6kXAmTb_SXNBQF3.EuxxaOgWXG40 WCCJce.Dy2Cqxd8Dasz8h6_asl5xRLlitnvXw2dD6x7uYGBjZeg_dn3BGLZ1OcntGEBco.oKhry. pV1pwXrUDve777MNN4c0FJm2IIsJcuQ6JonANYfaVVqDzwIm9wQVhBr.loGRt.aF8MgNuuqtmuyX 7_0KqPvZZ_AiYo7KNN9zUrMHZvwtan.3NXbGSj09fDzP0V3OIvC9zQWKy4bnECXkrCrzuZRPbVRJ 5QD77RLb1U4xrtIEn9fIgUdHNf_ewu1c1xrxJKt1.RwrxXrDPALtVwioVvDQZlvN38La_XV6UIOF iwYgb0SWMO2Zo_Yxxe7.oFW.6XFEOH2mKnC_HBvDayQG8Eu7Mgw.Nrf0O0stg8zSD11UrCsDx2Kb Kd_qH6fD.WcLZnytzwruDWxiQ1cwO77BBBKFrxrqTTGg.GVgFjHHLDslsvocY2iHo9AGmTZpGKf8 eP8eVPkfK.7vp8xVMl7bW9wdg3Hs2EZRDUtauj_zvAJQqio3bzl9W91PQ5EhPcjiy2oAWUet9pgy uFBH8RxrUeIC.G4au93m6Htz38yxd5He8vwMSJ8XXiPyNq3ymoNPGvVH5xzqvSkbJ0fqwtmOxKdL 18257Wda6bmLyIwr2h_vKHc91dLtUbclWkO767zayiCyn8N5p._Jd93s8HcmnMW2M7.xZ2i.Spjy wSjxa2W7nyg-- X-Sonic-MF: Message-ID: <6931ef9f-1978-97f5-2d32-003a9e64833c@aol.com> Date: Fri, 6 Jan 2023 10:02:29 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v6] xen/pt: reserve PCI slot 2 for Intel igd-passthru Content-Language: en-US From: Chuck Zmudzinski To: Anthony PERARD Cc: qemu-devel@nongnu.org, Stefano Stabellini , Paul Durrant , Paolo Bonzini , Richard Henderson , Eduardo Habkost , "Michael S. Tsirkin" , Marcel Apfelbaum , xen-devel@lists.xenproject.org References: <830263507e8f1a24a94f81909d5102c4b204e938.1672615492.git.brchuckz.ref@aol.com> <830263507e8f1a24a94f81909d5102c4b204e938.1672615492.git.brchuckz@aol.com> <882652f8-ddda-a7d8-85b9-da46568036d3@aol.com> In-Reply-To: <882652f8-ddda-a7d8-85b9-da46568036d3@aol.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.20982 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 4557 On 1/6/23 9:31 AM, Chuck Zmudzinski wrote: > On 1/6/23 9:10 AM, Chuck Zmudzinski wrote: >> On 1/6/23 9:03 AM, Anthony PERARD wrote: >>> On Sun, Jan 01, 2023 at 06:52:03PM -0500, Chuck Zmudzinski wrote: >>>> Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, >>>> as noted in docs/igd-assign.txt in the Qemu source code. >>>> >>>> Currently, when the xl toolstack is used to configure a Xen HVM guest with >>>> Intel IGD passthrough to the guest with the Qemu upstream device model, >>>> a Qemu emulated PCI device will occupy slot 2 and the Intel IGD will occupy >>>> a different slot. This problem often prevents the guest from booting. >>>> >>>> The only available workaround is not good: Configure Xen HVM guests to use >>>> the old and no longer maintained Qemu traditional device model available >>>> from xenbits.xen.org which does reserve slot 2 for the Intel IGD. >>>> >>>> To implement this feature in the Qemu upstream device model for Xen HVM >>>> guests, introduce the following new functions, types, and macros: >>>> >>>> * XEN_PT_DEVICE_CLASS declaration, based on the existing TYPE_XEN_PT_DEVICE >>>> * XEN_PT_DEVICE_GET_CLASS macro helper function for XEN_PT_DEVICE_CLASS >>>> * typedef XenPTQdevRealize function pointer >>>> * XEN_PCI_IGD_SLOT_MASK, the value of slot_reserved_mask to reserve slot 2 >>>> * xen_igd_reserve_slot and xen_igd_clear_slot functions >>>> >>>> The new xen_igd_reserve_slot function uses the existing slot_reserved_mask >>>> member of PCIBus to reserve PCI slot 2 for Xen HVM guests configured using >>>> the xl toolstack with the gfx_passthru option enabled, which sets the >>>> igd-passthru=on option to Qemu for the Xen HVM machine type. >>>> >>>> The new xen_igd_reserve_slot function also needs to be implemented in >>>> hw/xen/xen_pt_stub.c to prevent FTBFS during the link stage for the case >>>> when Qemu is configured with --enable-xen and --disable-xen-pci-passthrough, >>>> in which case it does nothing. >>>> >>>> The new xen_igd_clear_slot function overrides qdev->realize of the parent >>>> PCI device class to enable the Intel IGD to occupy slot 2 on the PCI bus >>>> since slot 2 was reserved by xen_igd_reserve_slot when the PCI bus was >>>> created in hw/i386/pc_piix.c for the case when igd-passthru=on. >>>> >>>> Move the call to xen_host_pci_device_get, and the associated error >>>> handling, from xen_pt_realize to the new xen_igd_clear_slot function to >>>> initialize the device class and vendor values which enables the checks for >>>> the Intel IGD to succeed. The verification that the host device is an >>>> Intel IGD to be passed through is done by checking the domain, bus, slot, >>>> and function values as well as by checking that gfx_passthru is enabled, >>>> the device class is VGA, and the device vendor in Intel. >>>> >>>> Signed-off-by: Chuck Zmudzinski >>> >>> >>> This patch looks good enough. It only changes the "xenfv" machine so it >>> doesn't prevent a proper fix to be done in the toolstack libxl. >>> >>> The change in xen_pci_passthrough_class_init() to try to run some code >>> before pci_qdev_realize() could potentially break in the future due to >>> been uncommon but hopefully that will be ok. >>> >>> So if no work to fix libxl appear soon, I'm ok with this patch: > > Well, I can tell you and others who use qemu are more comfortable > fixing this in libxl, so hold off for a week or so. I should have > a patch to fix this in libxl written and tested by then. If for > some reason that does not work out, then we can fix it in qemu. One last thought: the only donwnside to fixing this in libxl is that other toolstacks that configure qemu to use the xenfv machine will not benefit from the fix in qemu that would simplify configuring the guest correctly for the igd. Other toolstacks would still need to override the default behavior of adding the xen platform device at slot 2. I think no matter what, we should at least patch qemu to have the xen-platform device use slot 3 instead of being automatically assigned to slot 2 when igd-passthru=on. The rest of the fix could then be implemented in libxl so that other pci devices such as emulated network devices, other passed through pci devices, etc., do not take slot 2 when gfx_passthru in xl.cfg is set. So, unless I hear any objection, my plan is to patch qemu to use slot 3 for the xen platform device when igd-passthru is on, and implement the rest of the fix in libxl. I should have it ready within a week. Thanks for your help, Chuck From xen-devel-bounces@lists.xenproject.org Fri Jan 06 15:05:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 15:05:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472743.733089 (Exim 4.92) (envelope-from ) id 1pDoHD-0004FV-CX; Fri, 06 Jan 2023 15:04:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472743.733089; Fri, 06 Jan 2023 15:04:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDoHD-0004FO-9L; Fri, 06 Jan 2023 15:04:59 +0000 Received: by outflank-mailman (input) for mailman id 472743; Fri, 06 Jan 2023 15:04:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDo8k-0008RI-DA for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 14:56:14 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4159138a-8dd2-11ed-b8d0-410ff93cb8f0; Fri, 06 Jan 2023 15:56:11 +0100 (CET) Received: from mail-bn7nam10lp2100.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.100]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 06 Jan 2023 09:55:52 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BL1PR03MB6151.namprd03.prod.outlook.com (2603:10b6:208:315::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Fri, 6 Jan 2023 14:55:45 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5944.019; Fri, 6 Jan 2023 14:55:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4159138a-8dd2-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1673016971; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=y6nqwjCeO6yIH8eftBJ7Xpict7gjEx2x3YmP+N15b4c=; b=AJ7a2zyVM9HgI+lBlJmJYSG1CWyFsAUCw63xF0qDUWCtDbxCltOFMCrc Eh+AvvncBPtiOWsaI4LD81vLBizECL0qvMG+RNAV/4ddLhtH7zkq2Engd tHdTwQxGuHwR0WFsEm+6crrkKaoZhA0wYLI+V6jxhdf9A+Q/zIGOpEesF k=; X-IronPort-RemoteIP: 104.47.70.100 X-IronPort-MID: 90432588 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:pyYw0aLtNcLAU0NvFE+RSpQlxSXFcZb7ZxGr2PjKsXjdYENSg2YGy mdLDGnUPfyDYmLzf41wPYy19k0FvpWAyIBrQFFlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHv+kUrWs1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPdwP9TlK6q4mhA5wRgPaojUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5vC2FV9 PMfAwokSTvblezm4Z7rdMpV05FLwMnDZOvzu1lG5BSAVbMMZ8+GRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/VvpTGLlGSd05C0WDbRUvWMSd9YgQCzo WXe8n6iKhobKMae2XyO9XfEaurnzHunA9hPRO3QGvhC3nOi4i8TOSwtCgGL++a/rEKadIhBN BlBksYphe1onKCxdfH6WxC7u3+F+B0BQd1bE+49wA6Iw6vQpQ2eAwAsXjNHLdArqsIybTgrz UOS2cPkAyR1t7+YQm7b8a2bxRupIjQcJ2IGYS4CTCMG7sPlrYV1iQjAJv5sEaezisD+EBnqw i6Ntyk4jPMYistj/6+891rWjimsopXMRwgd6QDeX2bj5QR8DKasY42z9VHa97BONo+fRVial GcIkI6V6+VmJZqKkiqKQukEArCyz/mAOTzYx1VoGvEcGy+F/neiecVa5m54LUIwasIcI2axO AnUpB9b44JVMD2yd6hrbomtCsMsi6/9CdDiUfOSZd1LCnRsSDK6EOhVTRb49wjQfIIEy/pX1 UuzGSp0MUsnNA== IronPort-HdrOrdr: A9a23:qvsDdqOPQCkUO8BcTgWjsMiBIKoaSvp037BK7S1MoH1uA6mlfq WV9sjzuiWatN98Yh8dcLO7Scu9qBHnlaKdiLN5VduftWHd01dAR7sSjrcKrQeAJ8X/nNQtr5 uJccJFeaDN5Y4Rt7eH3OG6eexQv+Vu6MqT9IPjJ+8Gd3ATV0lnhT0JbTqzIwlNayRtI4E2L5 aY7tovnUvaRZxGBv7LYEXsRoL41qT2qK4= X-IronPort-AV: E=Sophos;i="5.96,305,1665460800"; d="scan'208";a="90432588" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f4YR2n1k8weDMCmcqvXEEtZ4lP/nhok4woeIP7Okv76b+8VH2AV/RLAGd8n67RwoaK0uVbLovQNRCV88x5EbTvjvjSJSfgVUVGmv3E7dsnl5MQ5H9YxE6yRlKykV09ecMnzaxXq4HFYP6labhCBBfXTi53yh3Gj4YoutM7J2+rBLjhjjp0PvOyOtaVwnvD0mhH04R07PwpHf2gpCcymmE2IWmZ1kXuTt42xINC4MLSUVTofNsf/TZ1l7n09KxfO6kCI2r2yMGbtb7ciWzGqTkg/H5jnIQnk99vNUOx3EFV3bGES+SINUB1XsHGO4SYbvOMytg2jkHg6CfhhCE73N5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y6nqwjCeO6yIH8eftBJ7Xpict7gjEx2x3YmP+N15b4c=; b=ZrtkplRlKvwTWfAyVK03tMEA+y+9i4lu8aXzV3KJ2BXQl/HSsQV/DaXAjpOrhJT7yZCZ/UI7PrFFbq0PMtfFlZ71FrgPT9s14cVSZZTkcYIhIQFHSr/fNse+YnsrLnloAf+HYlnjt0cueXc71SQoS47x9Domz7tvvqpjmHaRsYaycSARA31GLUwKMmuSTlLSldQ6ep9omizZ8K7VS6SmZfK9IuslSjOP7vzH4WKaAmrzWjbdR1g6olYOSzc++qPqGwG0FlmHnYn7+/quLEMfZaKMMB+WlthyaS2fM+SzPp18sMCAMvdM56zPsAu0X/BA13mhyYuBZVJNmWdaouFPsA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y6nqwjCeO6yIH8eftBJ7Xpict7gjEx2x3YmP+N15b4c=; b=Wp7NRNs+IropkTTTFu4f+ameUEif6qThcmfZKq52HRSu5iEqrrHEBavjebZMMN4emLp1doQztEyWLotLE3bBrY6gIdilcYOsnxpcNPeD2II3zovwylTUFV31qjQYpV/hcM2IthGUoQibb0Yhft5FYh4LBXYzQLQD3BYjeK6BZEE= From: Andrew Cooper To: Oleksii Kurochko , "xen-devel@lists.xenproject.org" CC: Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis Subject: Re: [PATCH v1 3/8] xen/riscv: introduce stack stuff Thread-Topic: [PATCH v1 3/8] xen/riscv: introduce stack stuff Thread-Index: AQHZIdDaBwrpw7Xp9EGdXN7qbTOW/a6RekUA Date: Fri, 6 Jan 2023 14:55:44 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|BL1PR03MB6151:EE_ x-ms-office365-filtering-correlation-id: ed02e942-0001-4006-13d0-08daeff616d1 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Lmyb4e0csK28luGYz/fJ2JV1vv2uAckOP+nDyUIceCuALgTLYBzpUkGM3WTldWEQw91Myr7i9v8qXeAYgrub0mFLuZlW39iDEBHXUQ66rU4G4/r95AzGTLGESx7Ssz84vAb73+AjrgtIGxV3X5c6Ie7Lja+uO/xt5c7psQuGQVBfcRbP0qZTVqfWjc0ojQPR5HqnjBj0/Y3m0IGRE5e0nA/VatXIi6rwRN5rW/BfOrb36PpofeF4Q4Gu5k2lErHXdEWjcMMxFNZj2+em6DryXzxXMQk8bkKFl1gJI+RvbWHbr7V/KdLtk64p64qjJAA69MRtT275KAgAFIiBaUcmpgwAnrCx7l3oTqCKtNNRuXVS4ZfUsTlyd7RXQ3Hmm7dZjddnr5VjrOEIZuxJz5T0vkmgUWPFkHAMBNl8kFfqF6SOwFd0JCOqOrxe7vwfljjnIoNVX8/rQru6U9gb901xmXinwwUor5tc0ZYt8pfpYrGFO72s1+1e+DelT34v6toLkHH0rz2idEKQY8kRhW0oW1n7FomPO0gE6CnrvdDepYqzLEX4X0UbJA9L3a9QQqlOqi7rk8cLtrZtERlpRnf7B8ebAl24lk43Stef2nsz5CdtnJT/kPUOIwZHcqRQdcVUfp+soNgnAgoK8ydLx4c+vrHMilwcuXWBDGR+EQpbfodTxqgGvsLaC20uRl7Wkss9hTGXK9OqOmz4Jz+f6T+DdlgqFHLpiLueypwpb24Aq6pTokGf47aJP67wmxMynRe44Sd+qmo2JyantSuQFrzkIQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(136003)(376002)(39860400002)(366004)(451199015)(26005)(186003)(6512007)(6486002)(8936002)(53546011)(478600001)(6506007)(31686004)(71200400001)(91956017)(316002)(66946007)(54906003)(2616005)(8676002)(66476007)(64756008)(66446008)(66556008)(76116006)(82960400001)(4326008)(41300700001)(38070700005)(36756003)(122000001)(83380400001)(5660300002)(2906002)(110136005)(31696002)(86362001)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?QkpraHlCekVqdTRTR0FTMXpybUZQcFlMaFlwTUNmWDRzeW1YQnV5OVZIUkMr?= =?utf-8?B?M280MjFrbHdlU21UOEpXU1JzQXJHbGxqTE1JZ2dpM0NUTkYyOEU5aHBPN2xS?= =?utf-8?B?cjBWSzR6ZG1lbEFNYldndEJNR04rb0JMbWtEdmdGL2RMMU5CZE85SzVVc1hT?= =?utf-8?B?c29ESU1Tc2QwOEhxR0lObTN3S0R4NU1Zak5PeDltL0pUTFkydkpxcSswZ1ow?= =?utf-8?B?NXJuSjJxN1loUjR5eStCM2ZhMTE3ZnlYOFdvUU5sS0hzZThpK1VwRVlzSXVu?= =?utf-8?B?V0lLVnkvTGIxY3pFSFRoZHpRK3ZQWXhHdnY2QjlvNHZGWkZxdmVPZTNoT1JJ?= =?utf-8?B?MkpNL2N2dDdLR1dud3hzdVBuV0ZaV0VlL2pzYmNoYTJpQmd3Y2haYkM5ZUs2?= =?utf-8?B?RW9BOVdyVlpBVlVlbHFtWmFiWmNuVUpMWlVJUloyU3hjanFQWmw3a3krUTY5?= =?utf-8?B?M25INnY2U2ZXa080MVh3Mk1Nb3IrdnR1TllaWWZiOE00Smk0dXFURFoxWk96?= =?utf-8?B?aWdLbTNERUh4Qm83dmxxckhJdkJiVXM0MlkxV0tvMkthOFkwNjFGd1ZlVGdO?= =?utf-8?B?TTlLeHE3MUZPVWdvNzlteFhxbFJEWlZoYzNpM2d5Ukl4M0VveEhZalZZOThq?= =?utf-8?B?aGdwTHdzbXhZcCtDNzBkYWYzQmFUdDUzMWJ4cnNkaFJ5b0lSelJnSjRIeU1Y?= =?utf-8?B?Y1BVNTRpc2xuaDY1V0d4MDNnWnVvdzYzUlJ5SHJZSzl4Rnh3YUp6b1JCQWRu?= =?utf-8?B?THo2ZkVYL0JNTWFQVEQ0VzJnTWtRS2tMSW8zM2g4dVlsaTBDRXplOWNRbWFM?= =?utf-8?B?T2x6d2xna2FJRFV1a05iVUxBNVRBMWJKbERERG5CQ0dhRFhiM205OERHZFV2?= =?utf-8?B?NFVaVWYvdldMMVhyRTFFNUlYbmRWNVp6OXNLQ1JZbUFiY2J6RHljcGhFMW9K?= =?utf-8?B?TUw1MVdUeCtVeXFVcS85ZGRQRkVxMEJ3VmQzV3haN211ZWJIMUtxMC85T3pn?= =?utf-8?B?VXJQTXBsY1B2b1pMRTN5NTdjTHRIS3IreElReWl5dC9tYThIcEcxNDlXYVNJ?= =?utf-8?B?SnFENnZ3ZWE0Z3AzaXNEbks5MHdPcjkyQmRoMllUZjdSVEc2ME9SNUU3S2ZH?= =?utf-8?B?dGI4czJiNFJNMURsL0hMUUZsaUFhRC81NTA3eFhPd2xyd1d4WEJXaXlpWTBR?= =?utf-8?B?SmYvL1ZYWm1RN2U0ZlVmQlNVYWFOMGNwSFRQbnc2Q25uVDhEMW5YakRTZ2dN?= =?utf-8?B?K25KOHpvaVJocWs4Z1JVa0U2bERyaXdWUmY0Sk9QakJzK2dMS0VpRy9BaXVB?= =?utf-8?B?VTFxcWNBeG5aMk1WeWlLWU52UHVJUCtEL3dic1ZXWlNiQ1JEbkVWSzZUbjha?= =?utf-8?B?VzVMeTB2SnJGYk9XL2pmM1llU0JUVTc4bVlVamJTT3dkQTVWM3ZPb0FOb0Nm?= =?utf-8?B?c2tleXh6QVF4Wit6b3dTMWtlRzBVZ2tFb1BqMmJhZVRKR3A3U2V0R0FrUHVS?= =?utf-8?B?djd0TmVVcklkMy85YTBpTCtlOXlKamdZQ2RZclNET3E0TFlnRTlaUnJJZFp6?= =?utf-8?B?eTdQSGc4YmpWby9oRDA4TGd2VXowcCt2cnVXa0dnbUxEZnlQTVhIQTE5bFAr?= =?utf-8?B?RUswVDY0cjNWbm4xZUV5QlJ1OCt5WDdhNjVFVzVjc0lOaHhrcXlaSTJZSUJB?= =?utf-8?B?WVN6N1I1NHIwcEpSRkVsZTYrUE9HVFRLVHg4TWZLUzArS3lsYW9oekhyM2R0?= =?utf-8?B?UHd5SU02MGlRNi82Y25NQnFKQ1lMSkxkMGVwZ2RENStXTDFRd1ltSS9yWS9w?= =?utf-8?B?YzJibzVkU0dIVlZOWmNGSjZmNU51bklISzQ5ZldxbjhiTk5vZldSTFpFSnJz?= =?utf-8?B?NjVNcFFNOHBrT2FpM1lQdTRSUUpQMVZZMU1vYW5xZU5GVXBFNFNoUDBOeGVR?= =?utf-8?B?Mk1vcTM4eHo3RjBmTkN1eC93ZTkvK2Y4U1pqd2VNMjVSaEdtMTlTY09IcFJQ?= =?utf-8?B?T0Y1QkhmU3Qzc3NSSk4vWEtCZVpJclhuVHpjcWdYNXJ3cXl4TzJFSGQwVGpB?= =?utf-8?B?WUpvT3R3aytEWnlvQUcvOTY4ck92QzEwb2lWdHBRMFExV1krcWg1QnYwWFNt?= =?utf-8?B?ZVJyK2hBU0JKN3NGMzE1OFZIMWVGMXArWWhleCtOQzJDSVBrQkE5dklGKzBI?= =?utf-8?B?bVE9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <3D76733CFA921E4C803663BEC4C94DEC@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?Y05VVS9XMjZlMllNV0ExMkwzUHJzMTdSVUdXVmlhWkQ2UXFENHBJZlRINGZX?= =?utf-8?B?UHAvYUZXbVZJVGpzV3lHYVNqWkZkYjVCd1IxNlJMaVdsSHM5R3RMRVVqN2N3?= =?utf-8?B?RE52ZVFzandaN2cvL3NGSHVYUFNOZmFxdllubWF1Q2J3YzZGZ201K2Y2Nm00?= =?utf-8?B?M3NqMWoyQ1czWkRUa2xPcFVVQmJOUkhpNVR1UGtCd3YxeG9UY3UrK3lrVEtO?= =?utf-8?B?dHJkbWd5L2NBeFE4L1c4bDhiVktBc09YRk9Eb0NzcVpQelhqa3VMU0JGOXhQ?= =?utf-8?B?SC9TYWpPZnRxbkx0WmlxK3phbW9WaDF3MFFkUXduUXM1eUdEZjV5RGY5a2p4?= =?utf-8?B?czJuY09jY0laYXJUbkdzRnFuTzhUR0VvWVM4VnFHUmZaMU5NQnJSRDMzRTlv?= =?utf-8?B?VmlyQzdacU95Vy9BRmVmVWUrUnozMEEvUTB5dHpRUE1wWjZXamd2TEhLSlR1?= =?utf-8?B?dXBCRlU5RURna0RnY3ZhRms3VG9oSTgzNzI0emRnQUR0TVdsYUplMUd0MlVL?= =?utf-8?B?ajc4TWlESW5RVlJXRWd2VmtNV1hyMWk2Z216aGZEWU9XanI4ZDhKYzRVeTJC?= =?utf-8?B?dW1iRkxuaUJWdnhDVDdkVlVjOWtJQ09GNnh6TzQrYXZXaS80eGg4Mk9EWVFD?= =?utf-8?B?R3IzL3JGemFrZ1hLbUdZRUF1cU9wWUg1Vmx2eVRsWWY3eVBLdDZ1NnZtc2x5?= =?utf-8?B?OC9nRDZqWmZpNWtOYlN0bDZpQVRxRzEvL2tGUXAxUTZ5UERYSWhIUkg4WlYw?= =?utf-8?B?TmZtNjZlVUdFV1NRUm55TGU2K1VsVUwrbXAzcnpYaW0zbkQ0Yytwb2xxU2xJ?= =?utf-8?B?QStEOGwzLzNZYTBxVnNXUkNHR250WFpjV2N2OGRqbG55NHBjNldWRndCOFZT?= =?utf-8?B?a0ZLY3pVU2YwSnZGMEtJTzhFZ2R1YnFyTk9hbXVaTWxqNzR5Q21uQmdhK3NH?= =?utf-8?B?RVJuQlNqNy9NUXBIelM5aGhRVFowamJZU24wbWllYjVqTXhDQlBKS2pONnN1?= =?utf-8?B?dEZVSEV6WWYyTkVDUFBqRzRxNE5MVWZwQTIvNStUTTFqUGRzdmV6Y0E5dno3?= =?utf-8?B?WTVFYURSQ2ZDYmM1WGlzKzlBWFpWMTgxWEZqWG1hTTE3OUh4Q2FUQ2tWMmky?= =?utf-8?B?WFRtRHdseXNEYnY2Z2IrOWxEc3NXKzlKVEgwWThYMllid2NEbGZEKzAvd0c1?= =?utf-8?B?OUsrcHRhZFVIc3RmOTlpbWRXc0EwL01KS0pzeUtPZkRXaDdnRGk4K1gvWDA4?= =?utf-8?Q?eco7TEMUDbb3bWT?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ed02e942-0001-4006-13d0-08daeff616d1 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jan 2023 14:55:44.9515 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: S48rDDuw/IZz0Bpd8awmrIwg2rEUXIhmH5XhFIlE7sk0NJOlQkBUGijQ6zJTsxgIZQYrpeK98HmSn0UJKQury8/eTNIExP6teTJ6W7u6eH4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR03MB6151 T24gMDYvMDEvMjAyMyAxOjE0IHBtLCBPbGVrc2lpIEt1cm9jaGtvIHdyb3RlOg0KPiBkaWZmIC0t Z2l0IGEveGVuL2FyY2gvcmlzY3YvcmlzY3Y2NC9oZWFkLlMgYi94ZW4vYXJjaC9yaXNjdi9yaXNj djY0L2hlYWQuUw0KPiBpbmRleCA5OTBlZGI3MGEwLi5kZGM3MTA0NzAxIDEwMDY0NA0KPiAtLS0g YS94ZW4vYXJjaC9yaXNjdi9yaXNjdjY0L2hlYWQuUw0KPiArKysgYi94ZW4vYXJjaC9yaXNjdi9y aXNjdjY0L2hlYWQuUw0KPiBAQCAtMSw0ICsxLDEwIEBADQo+ICAgICAgICAgIC5zZWN0aW9uIC50 ZXh0LmhlYWRlciwgImF4IiwgJXByb2diaXRzDQo+ICANCj4gIEVOVFJZKHN0YXJ0KQ0KPiAtICAg ICAgICBqICBzdGFydA0KPiArICAgICAgICBsYSAgICAgIHNwLCBjcHUwX2Jvb3Rfc3RhY2sNCj4g KyAgICAgICAgbGkgICAgICB0MCwgUEFHRV9TSVpFDQo+ICsgICAgICAgIGFkZCAgICAgc3AsIHNw LCB0MA0KPiArDQo+ICtfc3RhcnRfaGFuZzoNCj4gKyAgICAgICAgd2ZpDQo+ICsgICAgICAgIGog IF9zdGFydF9oYW5nDQo+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9yaXNjdi9zZXR1cC5jIGIveGVu L2FyY2gvcmlzY3Yvc2V0dXAuYw0KPiBuZXcgZmlsZSBtb2RlIDEwMDY0NA0KPiBpbmRleCAwMDAw MDAwMDAwLi4yYzdkY2ExZGFhDQo+IC0tLSAvZGV2L251bGwNCj4gKysrIGIveGVuL2FyY2gvcmlz Y3Yvc2V0dXAuYw0KPiBAQCAtMCwwICsxLDYgQEANCj4gKyNpbmNsdWRlIDx4ZW4vaW5pdC5oPg0K PiArI2luY2x1ZGUgPHhlbi9jb21waWxlLmg+DQo+ICsNCj4gKy8qIFhlbiBzdGFjayBmb3IgYnJp bmdpbmcgdXAgdGhlIGZpcnN0IENQVS4gKi8NCj4gK3Vuc2lnbmVkIGNoYXIgX19pbml0ZGF0YSBj cHUwX2Jvb3Rfc3RhY2tbUEFHRV9TSVpFXQ0KPiArICAgIF9fYWxpZ25lZChQQUdFX1NJWkUpOw0K DQpBaCwgSSBkaWRuJ3Qgc3BvdCBoaXMgd2hlbiBsb29raW5nIGF0IHRoZSB1bmlmaWVkIGRlbHRh IG9mIHRoZSBzZXJpZXMuDQoNCllvdSB3YW50IG1vc3Qgb2YgcGF0Y2ggNyBtZXJnZWQgaW50byB0 aGlzLCBzbyB3ZSBlbmQgdXAgd2l0aA0KDQordm9pZCBfX2luaXQgbm9yZXR1cm4gc3RhcnRfeGVu KHZvaWQpDQorew0KK8KgwqDCoCBmb3IgKCA7OyApDQorwqDCoMKgwqDCoMKgwqAgYXNtIHZvbGF0 aWxlICgid2ZpIik7DQorDQorwqDCoMKgIHVucmVhY2hhYmxlKCk7DQorfQ0KDQppbiBzZXR1cC5j IHRvby7CoCBUaGF0IG1lYW5zIHdlIGRvbid0IHRyYW5zaWVudGx5IGFkZCBfc3RhcnRfaGFuZyBq dXN0IHRvDQpkZWxldGUgaXQgMyBwYXRjaGVzIGxhdGVyLsKgIChBbmQgaXQgd2lsbCBmaXggSmFu J3Mgb2JzZXJ2YXRpb24gYWJvdXQgdGhlDQptaXNhbGlnbmVkIG9wZXJhbmQuKQ0KDQpBZGRpbmcg dGhlIGVhcmx5X3ByaW50aygiSGVsbG8gZnJvbSBDIGVudlxuIik7IGxpbmUgd2FudHMgbWVyZ2lu ZyBpbnRvDQpwYXRjaCA2Lg0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Fri Jan 06 15:05:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 15:05:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472746.733100 (Exim 4.92) (envelope-from ) id 1pDoHZ-0004jB-NN; Fri, 06 Jan 2023 15:05:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472746.733100; Fri, 06 Jan 2023 15:05:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDoHZ-0004j2-Je; Fri, 06 Jan 2023 15:05:21 +0000 Received: by outflank-mailman (input) for mailman id 472746; Fri, 06 Jan 2023 15:05:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDoHY-0004hP-5M for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 15:05:20 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 868da59d-8dd3-11ed-b8d0-410ff93cb8f0; Fri, 06 Jan 2023 16:05:17 +0100 (CET) Received: from mail-co1nam11lp2170.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.170]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 06 Jan 2023 10:05:14 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CO1PR03MB5713.namprd03.prod.outlook.com (2603:10b6:303:6f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Fri, 6 Jan 2023 15:05:11 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5944.019; Fri, 6 Jan 2023 15:05:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 868da59d-8dd3-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1673017517; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=pe0jS5A0aRzTdLML3t90WfHJv8bffJSIVdsTEe5UdMk=; b=dzuPRB/0bgkMBp4pYv3NwRhnGTyEvkPWMluqyWYi6trZVeCcVR2MYwFR vBQLov5cf8EP+Ljn7rOnLhQsyxOThKWHnpMbTRi53oKvwcsJcoAmJzuEL X96dFMGnL+Qood2bh+2GzNKpOcLC90EqgepFbTIzdb6oAIs0eh69ZZfHS Q=; X-IronPort-RemoteIP: 104.47.56.170 X-IronPort-MID: 91903485 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:OE9KcqN4zexMOkTvrR1GlsFynXyQoLVcMsEvi/4bfWQNrUor1zQBy mEWUW/UbPaOamqgLt1xOYuz9hkBuZTQzdAwTAto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQA+KmU4YoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvzrRC9H5qyo42tB5gJmP5ingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0uFlWTgU/ s1AFDAqR0G9m6WnnpmrcsA506zPLOGzVG8ekldJ6GiASN0BGNXESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+PRxujeLpOBy+OGF3N79U9qGX8hK2G2fo XrL5T/RCRAGLt2PjzGC9xpAg8eexHKjA95CSdVU8NZrsFKXn1I3CyFVdni4ndW7lxSZXvB2f hl8Fi0G6PJaGFaQZt75Uh6joX/CvQMGXNFQEOoS5wSEy66S6AGcbkAUQzgEZNE4ucseQT0xy kTPj97vHSZosrCeVTSa7Lj8hSipJSEfIGsGZCkFZQgI+d/upMc0lB2nZtliGaixk9b8MSvx3 TeRrS41wb4UiKYj3Kyh8VfKqzmlvJTOQ0g+4QC/Y46+xgZwZYrgbIvx71HetK9ENNzAEQHHu 2UYkc+D6uxIFYuKiCGGXOQKGveu+uqBNzrfx1VoGvHN6giQxpJqRqgIiBkWGaujGp9slePBC KMLhT5s2Q== IronPort-HdrOrdr: A9a23:f6FWVqirmHkD/M179Y38v0gT1nBQXugji2hC6mlwRA09TyX4rb HJoB1/73XJYVkqKRMdcLy7Sc29qBDnm6Kdg7NhXouKZwXvsmqvMJxe9oPpwTH6chefygc178 4JGJSWY+eAaGSS4/yKhzVQ0OxN/DBEys2VbCvloEuFhDsKV51d X-IronPort-AV: E=Sophos;i="5.96,305,1665460800"; d="scan'208";a="91903485" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hxwcozv58hzWGjZOhl/wdeG1mja8/ArtjWt7beR03BTma8/G35ymEVAQh2KdamLVcfr8/XuZs57LikOKxv/AFktKe+dvfOixh0m8uhblFbVunAqduwmP/LlxAwyBE4HuilIK2SIe2YmEe29Z9b5WSF0/8euEjldETkb5iAddDQRXk06g5FGnFEhI0u3OvBFD2GZak3tU09NIhb26N5q6fWb1WZM2pQtaQ+VL7d5fc49CRRzx++/9kCs/4B1BopRlBFu0tEyK0HcDmSTiGp68AEz5FCCaliO+cMLsXt+CsAnzJIS/lNH5ZOd9VrDMapxouBympihPQ6I1d7IcfQjsZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pe0jS5A0aRzTdLML3t90WfHJv8bffJSIVdsTEe5UdMk=; b=VvKg+LCkeRYoVcIL3Xqy3msz+pOic9vIbFH0xgJ5pOUo2ywNcbkgCXj19b194dsrsbTlJeL7mvmvISvNBtbv9tcsYgJURuxVefIcwEei+/6BsEqVpoHVqi/HvJ2Ma7VkqC1BmCZGt5y8H5XLB+JZcPnVQtqvrVkClmLyV749L5LCr4cZOY3g9a3m0m0fYI86IeaifqAFVboIdxLbgcQXkYIKI73Mr+Qeb2CTuQZf+19lvWMJN4c5brhbay8Dk3suOe9wxkR2MidRO4B0yaYfYTTrxHHh8gsqeh0je7uZ0VDMnpd0DmF2WToy5fm6vtfOU1zulFGlMFg2PnhyJmNowA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pe0jS5A0aRzTdLML3t90WfHJv8bffJSIVdsTEe5UdMk=; b=UoovUS3/vEe2eI1HWSWP/fU+oAeaDkXD8NFw9sElyzvAL73nF9sCf8sHgWNzMdST6UiZUi8eYiBx3KTnIJRVrkortH/NCc5cVe0WvIaBcSiEemCW2nkBCDZ6dvZXkMXPjUdzxVJ35FBaylzxkkMs/ftTUV4ANqj+daoakHpmMTM= From: Andrew Cooper To: Oleksii Kurochko , "xen-devel@lists.xenproject.org" CC: Stefano Stabellini , Gianluca Guida , Doug Goldstein Subject: Re: [PATCH v1 8/8] automation: add RISC-V smoke test Thread-Topic: [PATCH v1 8/8] automation: add RISC-V smoke test Thread-Index: AQHZIdDdCltTrKYYX0C6LpSEFhyV666RfOgA Date: Fri, 6 Jan 2023 15:05:10 +0000 Message-ID: References: <90078a83982b37846e9845c8ffc50c92f3be1f47.1673009740.git.oleksii.kurochko@gmail.com> In-Reply-To: <90078a83982b37846e9845c8ffc50c92f3be1f47.1673009740.git.oleksii.kurochko@gmail.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|CO1PR03MB5713:EE_ x-ms-office365-filtering-correlation-id: c74696c0-0cd2-4e38-82d8-08daeff76814 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +pUFiG13bMbXd6hgK9ZV2vnYmoym7Dw7IDwZJ6gmzWwlWIXP1WnYqmHbDBvdiE0hp7DsPhjJavNE+o+EjIVRgxSHEofVfDRgsuocV51Ojj5MSQjuGxfIik++5kfydTxn324hZBaQcyEdlTWFA4dGpmqtMDVE4mONGoUlSRyXi47VBw5fb/1ipzUGuyxU9UC2ScGMyxgJNoD4lWs40EuyInybSxfdDq3/M9Jsaar2MxJUAcNSfeHYpLGSmSHRiA7gJ3Au1M9L3EDLSyRgnag1tWBMFIauUZW84wThYAyf8/jqffiE7xw5MMafljpQA4PjAAs1bXtx6miTWX8Y6/w1CnJhg3kGrMh6F2KK2vaxoIAP19KD6KaZx+1Jwuq/XkVUOAmLEK9BTD5MpHPFawDbY8iF6u5/4sCEvrl0dzYqTCsqwfv0kOx5L+zU3+LeHOQaVU6SGDdn9wRBmqxwounPL5SMjO7fEbFzFul0gJhSCuaf3e4et0qC9brDXb8a8NjZwNJQfVPBNejz+sEu/5Kq1j5SMB/2W2Iuo9KeEZGNFKCezGx4b7+TFANv8uTsLG17LpC/2CNOH7T8h66RBEnjpdbPJgSGxf/rtpI04Uu23N24VKSenxedYfxsoYXmgzN/jODCkW9Q9nTmSruxq1U009BmkO1k08CpztCmcymwHGYabd9/DMpzLGOVb47aWOXKX6Ke+XsUTKCT0oe8VHZFtceANCE4qUQ6/S30Ob5aQblMKqLvEA2hp6v6qfQ0NWgnUCnfbokPDE0HdkVjn/1mNA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(366004)(376002)(346002)(396003)(39860400002)(451199015)(8936002)(31696002)(86362001)(31686004)(41300700001)(122000001)(6506007)(53546011)(478600001)(38070700005)(6486002)(64756008)(71200400001)(5660300002)(38100700002)(82960400001)(83380400001)(36756003)(26005)(6512007)(316002)(66556008)(4326008)(91956017)(76116006)(8676002)(186003)(66476007)(66446008)(2906002)(110136005)(2616005)(66946007)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?KzR4cDR5Zm8rT2sveGNrcU53N0tFTEp1VTdER3V6RGxuQS9EajJHTDhyOTlj?= =?utf-8?B?NUhpWk1paytPamkzbkM2T3ZBM2UrVzdHWWVmaWt1VllTK2VrQ0k2ajV1eSsr?= =?utf-8?B?bGVRQXhDSW8rVWt2ZXhIdjhDbnhUZTNxcU9SeFNoY3RmOG93MXpmTmlDdDZI?= =?utf-8?B?K1plU0U4YWNObnBlZHg3MlNHNFJEakFsRGZSK3lVOHFBTklSSHZjWkd6UVp3?= =?utf-8?B?UWlSL1ZyRUZqRVMvM2ozS1RzWTlNc1FNMTRteVliSDhMUlQ2NVpCelEySHhY?= =?utf-8?B?aTBZMHF0OVhwUVE5dzlhSlRqeDJ0OHAzM1V4YndsTGZjeklhZGRZVTBTM0pr?= =?utf-8?B?Sk51UWdSZzdtNkVQeEZYb3ZURmVGWTJ3Tmx0ZEltcEl3cStUSE9JUHlXT3Vl?= =?utf-8?B?cTVuV2hUYnBSVmN4T01ZelNoUHh2WkgvcnBtb1N2amVHV2dYWEcvSE9PbUh0?= =?utf-8?B?MWZic2hFaHVuVDZYcVNDZldKSUtlUVJGNnZ5Wm9HbHlWOTFuek5OT0tZVEFk?= =?utf-8?B?UEMwT2Z3b3dtRzlBN0ZIcUNhemI1cXBzQ2JuYzVVN2pqNnMrTzVRemt1aUE1?= =?utf-8?B?V2RuQlhPbTBudzhUMUx6a2VOZmJLWS93WVlHejNhaGh0QTVORXBRdVR0ZFVJ?= =?utf-8?B?NGthK1JIUWNiNjVMdXJ0cDc2SzMwcmllRHdNWjZtVHl6TEk3aHF0QXJFZFVZ?= =?utf-8?B?LzVOYTJXV0R0SXNHSVJvMGZERGNIdmZzcytPZXg5Wm90OFo5RlRFODNlYm1K?= =?utf-8?B?L2lmV0laR0tKMWdRZW9Od05XT1BjZVloZGVvWjdIamJOakZTZ0QrY2JrWWhJ?= =?utf-8?B?d3BkN0VEejhuclhadysrakhFV3VhUmxOOWYzcnJEREFzZ1pNOGRqM00xQUFL?= =?utf-8?B?Y2tFN1NLdXVvMDR2YmRiVnN6NXJpS0NSL1ZkdEJqZmpZMUpodWlhUkFLc0Y1?= =?utf-8?B?ZTl3MWh1K1ZjckNQazVXSThkNzNSUnIrVG9ZSlBYNkV5VXJwN0FFYk81VzNt?= =?utf-8?B?cDl1Q200UzVSZGsrUjFTdm1rcTJGTzhab3dUMTcyS242S0FMMDBad3NFdENR?= =?utf-8?B?SThjQVVHL3hETnNDMU1sQ1ZFTkc0UlJGWHNXYU5QK3kzZ2dTczFYeHpyT0pi?= =?utf-8?B?MFhUREk3UDlEeFR5QW9yeHMyb3hiVisvNmFhSS9qa1gxMnZGN01lbU5yUTF2?= =?utf-8?B?M2NYRkE5RHJmTWRxRmRYang4bjFtbVZQaG1HVmZTMFdNZExJWE54ZFFhMW9W?= =?utf-8?B?YzZXbitvNk41WmJKRU5hUk1jODRFa0NvM0RNUUNRdjFxZEVSWXJ0MWtNaTdh?= =?utf-8?B?VnlmZll2TnNuaUl5MWZmLzg4MXpLMDkwKzZpNjJhMG0zRFF1WkUvWU5jZFhE?= =?utf-8?B?SGVUZXlZVFVRSUVkS0EwdENtNi9oTW1WUUNvazlnMDNTMWh4TGV0R29ORnYy?= =?utf-8?B?Qnc2ck91WWJ6L0lmYXBORGlKMUdPRENrbFFVSXdIc2FzVXlTOExSY0VtdGx3?= =?utf-8?B?L2tENlUwUW1GTnRjcW9WSnh3ZUNyUUpuVFR6TmRlVm5rbXIzYU9iTithWi9u?= =?utf-8?B?TW5hb2xyTCtsdHBEdkZkdUo1bVhKdVhGTkR3V3JPMFg5QnlUaXZVOUdOTlhw?= =?utf-8?B?Q1ZLZXpQYzd5UVY5bUh4QnNHZW1aY3dGa1JWZlVQSEUzcWJPZXVRTE5kNDJT?= =?utf-8?B?c2ErM1dETEpVLzFqeHFQYWJpNmNpZXZoWis1Y1ZjMExZTnZXVWgzWUJiSEJP?= =?utf-8?B?bDZhVHVqbzJYZjRhZnFFaFJZd2E5UE1VdmVzVnQyZ0pPVnJjVkdVdkhDOExW?= =?utf-8?B?TFhmM1FMYjl5N284NXh5a2dQSmpQeWY5QVJxeElITzJiTzgyb2ZQaHdsNWhR?= =?utf-8?B?YXNnSnhJTWtpVUxGckxabGlrREM5UFFKcm80Ty9IYWNLTEVncHdMTEVRRDA2?= =?utf-8?B?WUJ0U3dLT001UUE5SDR6a0xpWnprbEJBYVhwdTNUeU1DeXJ3cnFxc1lFWjZ5?= =?utf-8?B?ZzZEM3VaNWNua2V3eHVsNWZsTnRNc2lKUTBDSS9YM2IyUlkyY1E1cmg1K2Ni?= =?utf-8?B?ekt4dEZvS0tIOUpQbXV6Uk5wckUveTBXeW5ZbUdmeUFXVzB3T2oxTFhtWmhJ?= =?utf-8?B?UHdpVUh2OVNxRVhzam14N0MzYWZBa2l4c0Z6N3BDa3IvMmNVWjBpR3JQNjZ6?= =?utf-8?B?U3c9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <1BF3244BACA46F41A9BDC56E5F1021AB@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: ZLBDK3RI+Iyn3SMPH/NpdUYlyHEARYJ208Y7xZfzziH3Gda7EimquiZTOE4Nq+bI3m11UcqaWFqr5fD3zrgxYf+ilinTpzqcZ4cKOYDPZJG7Wc/GRX808zCa8DR1O72Y7Ce5S9XHheApMiICiwl1BMNdt/rodGeGMYs5S8Y7U5osqM0DR9TF46CtiD/xoAw9OUMMZzoGoMWINPyAymiUQnPWRzGllIdu1SMAokN6UJ5c9OGKl+GN65wRD1aOnkFLS9rh9ZeTn0F75ZAkibQlov3cUaA7sW9tuQqih5G0ZTCokKH1uc0ZEQM67/1B8EcNJYZ+fwio87Imy45Ni5I5oBcDvDrZPgRa0TsXUFFmkhoJsOpx0bI7RcjLvXdJzDFxr/HJAeCkI2UgvWROPGUY9+qrhm3aOAj4DzPBR01wi+vxUfvouUg7IHFy6KWtUPN8l6GZG2DouMY+bK6loNan0YmfB2GZ3ivOwlq2ufSYOx5GrurxcLGF6vKnUSyldpKzVMVokojH26uZk90AvmB5rYatmHDATQ5BYTR8ZmACyqnUHBeCn9f5Gjkn0nAQgoSmB/g/fqoU7K8gOw7LGkFdWvzI5EC93bxTMEnjnx+YQ/B1BgwqGWFupMZYcBOtAarIhQnxnA/gsOSiuvf/koJevTv6rwALxZ84u62vQy+mDJO1lIGGpS111R7f7efujGqzjW0eIq3sAvvFI2fgTDhaFuZvImVB3fir/Ep7VxsHyIs7fgoUNJmFvXv2nDFrhBYlkEx4D5pq8Y52KfQA0hLomKaxNZy2NlrJ1DfMtI+2jIJSPl8sUOmGNDiyn2Izw6vy5+duCgNXz9YpaMZL5iPn9q8wV0gHxPxGvb+jyvWRU1Ni9GbZNH9j2VePAc2Vz2RIBMuxjHetRyfHHkSyf+y6dQ== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c74696c0-0cd2-4e38-82d8-08daeff76814 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jan 2023 15:05:10.7856 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JJNFylVQzLs1MiBSYW3d/41lueGCMi+lSoOgQRrQvnWdcVePNIRQRctq5A+u8crvs9nfDwxz0v0Xr3CPV6WFHS3EjTiwU2If6rrkogEJlzA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR03MB5713 T24gMDYvMDEvMjAyMyAxOjE0IHBtLCBPbGVrc2lpIEt1cm9jaGtvIHdyb3RlOg0KPiBBZGQgY2hl Y2sgaWYgdGhlcmUgaXMgYSBtZXNzYWdlICdIZWxsbyBmcm9tIEMgZW52JyBwcmVzZW50cw0KPiBp biBsb2cgZmlsZSB0byBiZSBzdXJlIHRoYXQgc3RhY2sgaXMgc2V0IGFuZCBDIHBhcnQgb2YgZWFy bHkgcHJpbnRrDQo+IGlzIHdvcmtpbmcuDQo+DQo+IEFsc28gcWVtdS1zeXN0ZW0tcmlzY3Ygd2Fz IGFkZGVkIHRvIHJpc2N2NjQuZG9ja2VyZmlsZSBhcyBpdCBpcw0KPiByZXF1aXJlZCBmb3IgUklT Qy1WIHNtb2tlIHRlc3QuDQo+DQo+IFNpZ25lZC1vZmYtYnk6IE9sZWtzaWkgS3Vyb2Noa28gPG9s ZWtzaWkua3Vyb2Noa29AZ21haWwuY29tPg0KPiAtLS0NCj4gIGF1dG9tYXRpb24vYnVpbGQvYXJj aGxpbnV4L3Jpc2N2NjQuZG9ja2VyZmlsZSB8ICAzICsrLQ0KPiAgYXV0b21hdGlvbi9zY3JpcHRz L3FlbXUtc21va2UtcmlzY3Y2NC5zaCAgICAgIHwgMjAgKysrKysrKysrKysrKysrKysrKw0KPiAg MiBmaWxlcyBjaGFuZ2VkLCAyMiBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pDQo+ICBjcmVh dGUgbW9kZSAxMDA3NTUgYXV0b21hdGlvbi9zY3JpcHRzL3FlbXUtc21va2UtcmlzY3Y2NC5zaA0K DQpMb29raW5nIHRocm91Z2ggdGhlIGVudGlyZSBzZXJpZXMsIGFyZW4ndCB3ZSBtaXNzaW5nIGEg aHVuayB0byB0ZXN0LnltbA0KdG8gd2lyZSB1cCB0aGUgc21va2UgdGVzdD8NCg0KSXQgd2FudHMg dG8gbGl2ZSBpbiB0aGlzIHBhdGNoIGFsb25nIHdpdGggdGhlIGludHJvZHVjdGlvbiBvZg0KcWVt dS1zbW9rZS1yaXNjdjY0LnNoDQoNCkhvd2V2ZXIsIHRoZSBtb2RpZmljYXRpb24gdG8gdGhlIGRv Y2tlcmZpbGUgd2FudCBicmVha2luZyBvdXQgYW5kDQpzdWJtaXR0ZWQgc2VwYXJhdGVseS7CoCBJ dCB3aWxsIGludm9sdmUgcmVidWlsZGluZyBhbmQgcmVkZXBsb3lpbmcgdGhlDQpjb250YWluZXIs IHdoaWNoIGlzIGEpIGZpbmUgdG8gZG8gc2VwYXJhdGVseSwgYW5kIGIpIGEgbmVjZXNzYXJ5DQpw cmVyZXF1aXNpdGUgZm9yIGFueW9uZSBlbHNlIHRvIHRha2UgdGhpcyBzZXJpZXMgYW5kIHRlc3Qg aXQuDQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Fri Jan 06 15:19:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 15:19:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472760.733111 (Exim 4.92) (envelope-from ) id 1pDoV3-0006Sq-2M; Fri, 06 Jan 2023 15:19:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472760.733111; Fri, 06 Jan 2023 15:19:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDoV2-0006Sj-VL; Fri, 06 Jan 2023 15:19:16 +0000 Received: by outflank-mailman (input) for mailman id 472760; Fri, 06 Jan 2023 15:19:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDoV1-0006Sd-Nd for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 15:19:15 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 790f2b12-8dd5-11ed-b8d0-410ff93cb8f0; Fri, 06 Jan 2023 16:19:13 +0100 (CET) Received: from mail-co1nam11lp2168.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 06 Jan 2023 10:19:10 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BLAPR03MB5553.namprd03.prod.outlook.com (2603:10b6:208:285::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Fri, 6 Jan 2023 15:19:08 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5944.019; Fri, 6 Jan 2023 15:19:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 790f2b12-8dd5-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1673018353; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=9CdlP3hOQO0KgwM+w6gCU4wWB2bLJCigK1wKvCRZYcI=; b=cci7ysnuDjLvwZgUHLlEaNVK9ChHIXDjQcINM8dya28MrAjmk5xSPFwE QDi8r5MtCIYYsNUcoIg4n1/6fUYOBtmj22+bzaJL4xZYy/g33qWnyURbM EkCjRhkGsv/g6U1oapXI6+1HofJmh/YBXbgUKYfAw1BlSkxqamr6U454R 4=; X-IronPort-RemoteIP: 104.47.56.168 X-IronPort-MID: 90436429 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:1JDpgqy2sFJpBAmL+PB6t+efxyrEfRIJ4+MujC+fZmUNrF6WrkVUy WBKUD+AP/uIMzaje9xzYY7goE0EvceEztZiSVBrriAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTbaeYUidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+U0HUMja4mtC5QRnPa4T5jcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KWF15 9gyNzUcUhGgnOmX++u7RPdlgv12eaEHPKtH0p1h5RfwKK9/BLvkGuDN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvjaVlVIhuFTuGIO9ltiibMNZhEuH4 EnB+Hz0GEoyP92D0zuVtHmrg4cjmAuqAN5JSuHip5aGhnXI7VMUKRMJUmHnhtuDjki/C/9yd mMLr39GQa8asRbDosPGdx+lpH+JuDYMVtwWFPc1gCmKzqfX+AeYQGsZVDlKaN8hnMAzTD0uk FSOmrvBFTFp9bGYV3+Z3rOVti+pfzgYK3cYYi0JRhdD5MPsyKkolQ7GRNtnFK+zj/X2FCv2z jTMqzIx750cjMcN07iw9HjdgiyrvZnPRUg+4QC/dmii5AloaZWlY4Gt4F7z4vNJLYLfRV6E1 FANn8mF8OkPF9eDjiWLS+QWNK6l7LCONzi0qVVoGZ8m9Tik5X+4VY9V6TB6YkxuN645lSTBZ UbSvUZa48ZVNX7zNKtvOdvvW4It0LTqEsnjWrbMdN1Sb5NtdQiBuiZzeUqX2GOrm08p+U0iB aqmnQ+XJS5yIcxaIPCeHY/xDZdDKvgC+F7u IronPort-HdrOrdr: A9a23:b8K5na7+HwlcPJ/HqgPXwMvXdLJyesId70hD6qkRc203TiX8ra uTdZsgvyMc9wxhP03I9ertBED4ewK5yXcX2+ks1NWZMTUO0VHARL2Lh+DZsljd8kvFmdK1vp 0AT0ERMrPN5TUQt7eZ3DWF X-IronPort-AV: E=Sophos;i="5.96,305,1665460800"; d="scan'208";a="90436429" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BL4fr2ItjcJz2gpyhd2NLktdrbNWJA6gxnzwGh5g1JdUp7nKcgViEGSKI5Rj5hG6xpiVPNqvbdEVBUoVgO+q5j/M3FGpnWV1nsCIKBO3XOsZ6UbALWQ/TA4B5X3tOI2+dzcm3Ysg2lZB0NDgSSwqSjTNNcUtasSb9C/GZLqYP6HHBEgRUUGDEHfifFiqbT9VgtO3rWBPiMxkeyQRkE5A3+NDrOc6/nwAQ5FeyBcMQBbhxjvd0vBD3RC/8eLkL4jADWbRC4h/hiK6PXszZtLpFlzbT1Iw4VJvHhK5ylQ+jhEHQL1sBr2Qr66hdzUsC4YBONvp+1TEAuYOD9F60+wcMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9CdlP3hOQO0KgwM+w6gCU4wWB2bLJCigK1wKvCRZYcI=; b=n6uSIBEBAfbx8lNqmi+bRTuY8D5jTHX/1sWcIGB+YkD1bJYbrQCefIXMOjay/fsAtb1Dz+9rwcLwL6rkUv2ZShnozBQ4VK9w6BtbGbuWDg6KODmC0YiHtVWcrN0hDfMN0YRuTibBpouLJ71kKF8VZ1aSVatP+iohQvw9Zd4AOptjUPDs1ZPLWYME+Bf5HP2QCIeZL6I9O4zzBRIy1cxkPnirtJI8GP4FLEznHcOkkK4O2zYayxw/LFjVoc4+m0u4F8Hux/XQSqdjN7lkYyIiCdeb2nvEC3N7wOUk9d1czQeKwyji6xCOvvnFR00zYa8RjyUbAMfhRuYMptruRXHB/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9CdlP3hOQO0KgwM+w6gCU4wWB2bLJCigK1wKvCRZYcI=; b=S1g2CAi9PN3T2/23Rjrg/eoylXaEoAuGIs6vM21xQIQ7/Hv2RSDGJ9qX6GFzFI0z0zo9bPwCH35EVaAqlfko8m833lf40gsteDK8OzNTiYx9NzuPu5DMKJZC8qFpGGOYJGLHG8TRAt9i43Z++6ol/LHTzxGTE4mfTU5gHg8BTzs= From: Andrew Cooper To: Julien Grall , Oleksii Kurochko , "xen-devel@lists.xenproject.org" CC: Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis Subject: Re: [PATCH v1 4/8] xen/riscv: introduce sbi call to putchar to console Thread-Topic: [PATCH v1 4/8] xen/riscv: introduce sbi call to putchar to console Thread-Index: AQHZIdDaR/Z8ZObOWUu8wVolwH1ydK6RZVeAgAAbd4A= Date: Fri, 6 Jan 2023 15:19:07 +0000 Message-ID: <8b6a9927-8a56-6fab-6658-deb4083d2c45@citrix.com> References: <09da5a3184242152af6af060720a007738a55d6e.1673009740.git.oleksii.kurochko@gmail.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|BLAPR03MB5553:EE_ x-ms-office365-filtering-correlation-id: 10292a8f-3a22-477e-f977-08daeff95b0b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: L1Hk74rfAPmZ18+2oz1DZ5nGC9TRx3hjxYVdqZC4j9X/OvrXEHDBWoN4lhefVtvMn+YtzC1olyi9EbIrtkF84Xg2oplR2RnLv6Th8gzb4T3KmD/AoQ5Jv6dGfiEveQAKtMyt9OMYAL5WrxCYHnFaQ0emqn1EZeOTuFMZtCKvIPxDiczfz230Ak9/t66F3ZXQ/WsIqgLlHIqFa6wBpS2dSpW9/U7DjQW4IucrhgwH5HXlJTJrIYw8mCkNFWqXHXCIgOBGcNGXs6mk+JKf9/KAlk+QzmEdsZRnRHXUnMvGBLJNM4C3LLgifepauOQ5LiYZ0jyXSRNkzduKT0pxnSM9oevyDk4/Vi83nIVkibaG1GewkcVhYlk0bnseuLFcFIlJ67XmyeNA3OvP5IFTD/rWBbbNZsZrg+5sINTaCLN7bXTyd8v6xlvE+OsP7zwLkI2GJOddZDkIPSKyP9inP0o6o56YpvaRHSwcDaKV7+P/7rJKgAr8dpmK6+hLsaFfktX85I6GmFwFNgkSoHysh3OyGIk8GR3iCTigLjyMY0W1ZtZfQbHpeccucaa2J6epa6RS0VFL7KJsp4nrX/C4YoFdPvCWhAeP5f+e7iRR72UMxRy1cNIhR/A+RmJYWW5oE3xb3AEpVJEaBzBtUvlE6zGA48ZTcbdh2+0dMPbMbh93wT0vjZIWphDoT3oD8owLrnx0bj2kdVFlIuS4gnhAdupQCc5ixYBIYariG2cYtiLqli/9HZegc/zYYf/b9Ta64/GFzRYk87c4usm+4ztYb3ac1g== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(376002)(346002)(366004)(136003)(451199015)(2616005)(26005)(6512007)(186003)(83380400001)(6506007)(38070700005)(86362001)(31696002)(36756003)(82960400001)(122000001)(53546011)(38100700002)(4326008)(41300700001)(8676002)(8936002)(2906002)(5660300002)(4744005)(31686004)(71200400001)(316002)(66556008)(110136005)(76116006)(6486002)(478600001)(66946007)(64756008)(66476007)(54906003)(91956017)(66446008)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?bnU5OWRsajJ5OGtQZ3BxQUV2b0hnYkl2OTRzTDZXb3kwSnRUSVNCWUFIeHdP?= =?utf-8?B?UXhtaTBwSFhCdE5jcU51UGJ0VDh5QXpZc2c4TlhlUVhlOTJWMXdEVTFSUGZX?= =?utf-8?B?aURycmE4NFlJWHRkRmIvcVdRaFFhdlJTTk8rQ1h1dWozVWRudUdLdDF5d2pk?= =?utf-8?B?TjhzZGxIQ1M5T3lZVEFSUGdlRDNKN0VtZk96MFNHbmpvelE2ZXVka1RLWEFM?= =?utf-8?B?eCtxdUVOdkowa2QvbG9OeDIvem1Nc0tKczg0bVpVY1dnZVZUUVgydWswK0Vs?= =?utf-8?B?NGprOVN6eDVLeUNBVk9BMkhYWFVHdHRCZnFXNzdINndVOEFKcDBUUnBHZnAr?= =?utf-8?B?SXJ0NzAvdlFDY3pWMUVTZFhQWEc4SytRaE5hL1VhSG83TzdhWVNOVkI3Y3Zi?= =?utf-8?B?NDZFMndKcHdxeEFOR29hWmZqazhXL0lZZWFJb2tGWWFDc0NtVXNVQTJUY1l1?= =?utf-8?B?M0ZBVHRoUnlRSTZRMDMrREJveDVTaG8rUko4VUxybUN0Z2hMZVVzQkIvN3hv?= =?utf-8?B?UEQ4alVLdnZ5Z3ZEbTRjYnFuZHZKNE4zN0VDVWhKc2JJTmtrSHBYcGcvcks5?= =?utf-8?B?TnJ5RGZEVE1sdTJHTG1wc05vbUUxTFR0U0xYZ1R2U1k2c0NCdmk3dHhzbXV0?= =?utf-8?B?dGlOSVltaGRxa1ZVbzlFL1NlSXdWcWlnWXphNGtKVjRTRFl1Tk1lYXZDTUc5?= =?utf-8?B?ZGJVcUwzeXJKYU1LTFZxZ0p3Mjdhb0VRWStyZ2E0SGNyVWJad1pkajErOUxH?= =?utf-8?B?bDZva0thbEM4RjBEMEkyaVlCY2VzSVZHL1pGa3Q0NVZRcHZhMzYzeUtGREcz?= =?utf-8?B?TmI1NU9PSURzOVRNVHY1QXRDcTBYTFZKOEp1T0w2bk5KL3NXN0ZobWVlRjkz?= =?utf-8?B?eFoxR2ZQY1Jkcm5YU1BPQXFKeE1DMnRDUjNaZW1YRTVKSldwOG1hOWVDbVFC?= =?utf-8?B?aGpKUjBFa05kejJmQXUxcHRjVjd5bElLdGRXdDBPUjg2OU5RU2kvbTVsd01K?= =?utf-8?B?S3BieEZBaWZObDFjKzZsOTc3bndUZjNtbVh2UTgyMFJHNzJaMkpDZDFrK0dK?= =?utf-8?B?UzJSelB5ZXd2dHNpQlpJM25OM3VYeWpoYWR3YzRWR2s2YTlTa1ZIQ0V4NFJS?= =?utf-8?B?cWN6bU12d1Z6U2V5QXZJRXJhT2kvUk5DazlGOURRTktVdTU1NXlBZzJkSmhj?= =?utf-8?B?dmIxc2o3RW0vUXM1aUx5Zk1hbGZLbUs1OXcwbGUrVTltOUVjWENnamRWL3k1?= =?utf-8?B?S2lSZXViQkxEL0tnWUNzYURWMHRXS1FYejU0MTVrUFk1d0FMTWRjL1VHNS9W?= =?utf-8?B?SlVNalViSjZYNHovc1k0ZW5uc1lIaEFWalI0TjZLcWJVRUlzWTlVR284dk10?= =?utf-8?B?cUlxNHVrbkhPVkFnNnNpcEMxWDR6SE1VTTZaTUM2K1FIbXRuRmxDK2ZrTXBR?= =?utf-8?B?bHhzWmE5WllqekdGZk1ZWFBXTHM0T3NKQXFZY24vdTlQTDRSZ0xmM3R3VVd2?= =?utf-8?B?UkpBejBDRWFCc2ZYb1FVSzlINWMwbjlMUlVIVTRCUTRVcHk0T2wzQzFybzBy?= =?utf-8?B?OCtWRzJ0MERyZ21vTEtQMy9uSTJBbWltMWRPRTU3SUxMS3l6TmhoMEhITG1G?= =?utf-8?B?bVkwS0F0c04xOFltMEpRWFZibk9KNEZab1JDY2tXNEpTL2Q3TVRxMkljWkVr?= =?utf-8?B?NG45MExPNmIrbVRnb2dKaGJvemQzYTdmdFltQXk3d1dOQnVKU1AzZEtMMUJt?= =?utf-8?B?ZWNVQzY1dDk3cHVsZVlCejVaSHNRU2hjeWZFK0ltNE1SSDZpbStZZ3gvWk1w?= =?utf-8?B?WlF1a2I0SVJCRThISjdBSktwWUZzZmlCNEcra1hETGJBZUdlc3BnV09DK294?= =?utf-8?B?UDR6NitiQnhndVlYQk81S0ZFMndqL3E1R3pHMytzL2QwOGlPTFgrVGhsZ2Fo?= =?utf-8?B?MnljL2VBNzd6aDdBSWZFWlhDVXJMK3l0YnNEMkFzY25rWHBFc3pPZmU4ZkdR?= =?utf-8?B?R2ZBSTloTGVyRDBRamo4WUF0aGJ3Y0k5MHpnVnllOUY5RHNDN3gwblBwVyti?= =?utf-8?B?MDZOczNWcWVsVVBKMys1anZIWmttUzJScW1kU3NoNXVybHljNkl4VEc2STFB?= =?utf-8?B?NHNORnZzQnJsd2pJLzNKSGNCY0J0am8zTHliVTRzd0ZuQStsTzBUeTYyNGpV?= =?utf-8?B?NUE9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <34D1B9580B0B1440BF0B3D484ACFC147@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?VWdsZmFOTkYyelNxTnZmUm1oT1lOa0VSTEs5NmV2MVJYVzlaMzN2bmwrRW5Q?= =?utf-8?B?ZXRQeGRlM3NoSncxbkVUa0hMZHY1Vi8rdDA5a0JCQ05jS0lxeUh6Ulplbkwv?= =?utf-8?B?Nlc2eldMTTV6bHhsd2MyYmdubEs2eHVGczIvb0RCUVllcExlTk1CWitXWTkv?= =?utf-8?B?Z0wrTTd3b00rS29JYnE1eXVSZWkzREFHZVRLNmJCcjdUKzFKUUJnbUZsZGtp?= =?utf-8?B?clFXdDEvZDlHU0dLV1pjdm9RK05LeFZvc1kyT2dRR0d1V1Z5VnNLbTlkZ01a?= =?utf-8?B?OWZCcG04VytWTEI1ZmhDR1VmbmNJTHFqNmttc1FOMzMrSmEyR2g0MUV2QXFC?= =?utf-8?B?MytHL3NqQ0ZSMXpyOTRyLzNNT21wZ0VycEgvK1V5ZUZOSUJ1ZHBURmNrc3da?= =?utf-8?B?bGxlTENLbTRIS1VSZVc3cUxaZnNnZmlRYURpcktBbGltSkdPb1hHbnZpY2Np?= =?utf-8?B?b2tINDhSeW1Dbkp2Y1hNSkFPZ0txV1R4bElOdEtZbXYxNCtVRkFXc29pNEVr?= =?utf-8?B?aWRRM1pHVTRrdVFYVzZvSWVLb21kWmNFMmRYZS9xZ1V2ZnM2ZGwzUmxEN2Fh?= =?utf-8?B?N0VNWUp6VFA5REovYW9MYkNnOFNKR0JBZWo4T3R0Y3Jxc1ljL2I5LzhxUG1Y?= =?utf-8?B?WnU5ZVpyaFhwWnFHY0cxcmV3SS9sQTc5RkJzQU5ScVVVdFZaN1IrTy9VQ1c5?= =?utf-8?B?M0pqb1pSY09lOWJOWnpNcmJGeVo1OW95MUdNZW1ObWJUd1JGV2ZreW9uc21E?= =?utf-8?B?TG1ob3JjN3VSQVdkcGc2QWhvV0RkR2s3cVBTTzJRZVNsanJZN09PMHhMYU1B?= =?utf-8?B?bkdIOVhQNGdxNDhFT3JRT0VFWjZCdmxRYzNjSVZ3N2NNdmxiMHc3MGFTWmhF?= =?utf-8?B?ZVUxTmUzOFdMQ1BxMHdKN2hmbndLbzd6N3ZlSmpYWkhYOG1ERzBYWExSSWN0?= =?utf-8?B?ZThSM0tKbEJoSFRkQVZMcUhWanlrQmNqeERSNzhneDllTk8xcit4ZjdWVUZz?= =?utf-8?B?Tmg0ZmVTVklOL0ZwZC9BWlFva0Z0UkFTMmdzVTdvNlBXUitrMEhGbk05Vjdp?= =?utf-8?B?Qk5LTnN1UjFtYTMwU3FiVUZWWlgzTXlIRkR4N0lId1Zwd0F0Z2dtY29wMTZ0?= =?utf-8?B?bENJd0JCdi9DbVlHQzJ6N1hvVGpCTnM5dVc2UU5JUEl6Mk9uMERSRTFtR0FS?= =?utf-8?B?VkE5MDFjRzJjWVZlcTM0cWZXR04vRXVDUzQwaklRVFdBU0grdHJRVjMrYlJV?= =?utf-8?B?L3BoM0lncGl2NU1ObXluTjlLcytOUWg0YzFpRnNtbjkxVXQydz09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 10292a8f-3a22-477e-f977-08daeff95b0b X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jan 2023 15:19:07.9596 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: v6gdBzdIEH0yRdm/TUOnloKmUObTk6CHn4I/YyHa1aTw5flo2yqvDlQNBEgjCltcyREY/JIdytn2eyHQz9ule78UAYDt7RPbpMDPhDXS7zI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5553 T24gMDYvMDEvMjAyMyAxOjQwIHBtLCBKdWxpZW4gR3JhbGwgd3JvdGU6DQo+IEhpLA0KPg0KPiBP biAwNi8wMS8yMDIzIDEzOjE0LCBPbGVrc2lpIEt1cm9jaGtvIHdyb3RlOg0KPj4gVGhlIHBhdGNo IGludHJvZHVjZSBzYmlfcHV0Y2hhcigpIFNCSSBjYWxsIHdoaWNoIGlzIG5lY2Vzc2FyeQ0KPj4g dG8gaW1wbGVtZW50IGluaXRpYWwgZWFybHlfcHJpbnRrDQo+Pg0KPj4gU2lnbmVkLW9mZi1ieTog T2xla3NpaSBLdXJvY2hrbyA8b2xla3NpaS5rdXJvY2hrb0BnbWFpbC5jb20+DQo+PiAtLS0NCj4+ IMKgIHhlbi9hcmNoL3Jpc2N2L01ha2VmaWxlwqDCoMKgwqDCoMKgwqDCoMKgIHzCoCAxICsNCj4+ IMKgIHhlbi9hcmNoL3Jpc2N2L2luY2x1ZGUvYXNtL3NiaS5oIHwgMzQgKysrKysrKysrKysrKysr KysrKysrKysrDQo+PiDCoCB4ZW4vYXJjaC9yaXNjdi9zYmkuY8KgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoCB8IDQ0ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrDQo+DQo+IElNSE8sIGl0 IHdvdWxkIGJlIGJldHRlciB0byBpbXBsZW1lbnQgc2JpLmMgaW4gYXNzZW1ibHkgc28geW91IGNh biB1c2UNCj4gcHJpbnQgaW4gdGhlIGNvbnNvbGUgYmVmb3JlIHlvdSBqdW1wIHRvIEMgd29ybGQu DQoNClRoYXQgd2FzIGFscmVhZHkgcmVxdWVzdGVkIG5vdCB0byBoYXBwZW4uwqAgRnJhbmtseSwg aWYgSSB3YXMgYW4gYXJtDQptYWludGFpbmVyIEknZCBvYmplY3QgdG8gdGhlIGhvdyBpdCdzIHVz ZWQgdGhlcmUgdG9vLCBidXQgUklTQ1YgaXMNCm1hc3NpdmVseSBtb3JlIHNpbXBsZSBzdGlsbC4N Cg0KTm90IGV2ZW4gdGhlIHBhZ2V0YWJsZSBzZXR1cCwgb3IgdGhlIHBoeXNpY2FsIHJlbG9jYXRp b24gKGlmIGV2ZW4NCm5lY2Vzc2FyeSkgbmVlZHMgZG9pbmcgaW4gQVNNLg0KDQpJJ20gbm90IGNv bXBsZXRlbHkgcnVsaW5nIGl0IG91dCBpbiB0aGUgZnV0dXJlLCBidXQgc29tZW9uZSBpcyBnb2lu ZyB0bw0KaGF2ZSB0byBjb21lIHVwIHdpdGggYSB2ZXJ5IGNvbnZpbmNpbmcgYXJndW1lbnQgZm9y IHdoeSB0aGV5IGNhbid0IGRvDQp0aGlzIHBpZWNlIG9mIGNyaXRpY2FsIHNldHVwIGluIEMuDQoN Cn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Fri Jan 06 15:19:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 15:19:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472762.733122 (Exim 4.92) (envelope-from ) id 1pDoVT-0006tP-Bh; Fri, 06 Jan 2023 15:19:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472762.733122; Fri, 06 Jan 2023 15:19:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDoVT-0006tI-7y; Fri, 06 Jan 2023 15:19:43 +0000 Received: by outflank-mailman (input) for mailman id 472762; Fri, 06 Jan 2023 15:19:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDoVS-0006sw-6J for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 15:19:42 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2076.outbound.protection.outlook.com [40.107.223.76]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 892c6e25-8dd5-11ed-91b6-6bf2151ebd3b; Fri, 06 Jan 2023 16:19:39 +0100 (CET) Received: from BL0PR1501CA0022.namprd15.prod.outlook.com (2603:10b6:207:17::35) by CH3PR12MB8511.namprd12.prod.outlook.com (2603:10b6:610:15c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Fri, 6 Jan 2023 15:19:35 +0000 Received: from BL02EPF0000EE3D.namprd05.prod.outlook.com (2603:10b6:207:17:cafe::ef) by BL0PR1501CA0022.outlook.office365.com (2603:10b6:207:17::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.15 via Frontend Transport; Fri, 6 Jan 2023 15:19:35 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BL02EPF0000EE3D.mail.protection.outlook.com (10.167.241.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5986.15 via Frontend Transport; Fri, 6 Jan 2023 15:19:35 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 6 Jan 2023 09:19:35 -0600 Received: from [10.71.193.39] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Fri, 6 Jan 2023 09:19:33 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 892c6e25-8dd5-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YmYYZKmsm8wPu+mMVvCMuOGDou5onGM5gBzV/I4eOskIXzI+6NE30RbZvtBsCrMHS++tOmWmL3Ha0EvDtHLO9qERQLAqOIGWMIoChzx3uTWAfgv9yOQiLqmLEHxRhyExmCXI9jdefmQnCtuCT3arjzSZdjxvWALXdJ72DUBJMQ5vp7p6tIqxonc8o3SFI7UedASi60Na0EdjiEe2ZrPhfkcPAlOPRx8h6Xrsnj9Lh0s7L5uBuF5YCIkODOonQpQZ8tc7vVp2tepfU5KRXPliRSjhYZqi1N+qPWG+7b819kZ//RhrzUSYGZbkGmlcct/QSk1MnZ8qE/hXTo90szETaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NwgDyJdzWg87zclswFLQ8OvS/mSB4UK6QDkVuEFIJx8=; b=YY1/D4tXCUqkIMeyRDeoA4A0TSXpgcaWh5ZhTbvZujoEk/0ndSCmocg3z1eTBCuwQbv+ztICIw7eTMp8MzXszip0g/ubMcdLbi0p+2qYs5Rekum85bUcgtZAh8uFBrB7aHFUSY5UPAQepJo5dWNjVJ2bZ5VXEh47EgLsqamh6c6ve8kXab47DZ3FfYv8l7PYw+WQKayGZUblLSoMLu1q6sUv/OSFQmAHVn91JMMFYKxjEtSLrLpZ7TRRwk0HCykLAKesNVz1ePWA3r1Z8fatCF1n7+clvmuZg1JALPLonHYP5E+KnbTFZd595S9GPXY+iA+vwTadKaWBFHY3rUaRiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=gmail.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NwgDyJdzWg87zclswFLQ8OvS/mSB4UK6QDkVuEFIJx8=; b=CUVuitha+SUvHdMk/QZ7K/reCnYq9OAWxIbTvhZzLLDUAW6T26z+Bif3L+4OtRz6ovMIYJpA8SIS0YEPEBsfPnoacjdCzKQYkTHVnI2T0LpXZCggp5mX8mKMVRII/8mk7Sh+YvMv2W10cP3jymoclxpJrh+mU15xMXXpPU9sNuM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <420e9747-09ba-b6e4-d3c5-14f0f174c1d7@amd.com> Date: Fri, 6 Jan 2023 16:19:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v1 4/8] xen/riscv: introduce sbi call to putchar to console Content-Language: en-US To: Oleksii Kurochko , CC: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis References: <09da5a3184242152af6af060720a007738a55d6e.1673009740.git.oleksii.kurochko@gmail.com> From: Michal Orzel In-Reply-To: <09da5a3184242152af6af060720a007738a55d6e.1673009740.git.oleksii.kurochko@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0000EE3D:EE_|CH3PR12MB8511:EE_ X-MS-Office365-Filtering-Correlation-Id: 74ed7080-a8fc-4de6-717a-08daeff96b8d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /GHIgVc3pfa5ce4nYdV4nJGpB4d+LgU5rIVcl4/DeVnsU0X1wVKEIWhrgohd+LZ8kOMWs8rpE6k7rxg3pDAqyp65II5TR520mNXRC3A0Ua02MjXVW6p/5eBofN8HU2fx6RyTi4+7qoO2TlYlHHvLSr2NzqH9bNsin3G5S2/QLsz+guHiicGXaplb3uX15o8wgqHYrQQn3s4XwB5uVN4VG1fuQqfpdBwj+zDvo2J8rNEnwVGMWhqU3PF77wZ0jAd4DI0OZe6BjH+4bjR2/mGtoHD8Y581eb8FZgpJe3xfTT1HUz+EzBjLB6DJdiYMUP0VhbgpUGy8DEZksXnSzbjjr3Tfr4tsEHHifn2wAVmkbwaleLbuN1yZtVlhXGlkoqVjV7b36fzqR7j2EDBVFxg/JYnkv4DeFm/Pup0ZxGA/OSkh1rQZ1ho05elMNHNirJOvDdmYM0AfYFxSnXuRi+VYgDd++YDX7do+LoKqv/o6jTHrW5oc2++ngZm6J5d2Z5hFNdxm1jkeua8inxwCB30Anu+xKry8FlT9LAn963MH6rD2ypfVFUcleJytHYgDYNhqUBzGIUJ56/pUi1BmjztjOhsW5XAxAqxFy1LwL7SACR4w1NtZNj7wGaj9nxMkMPETbNekeUnNPfXQ3kXzVEdu0/TUtaCKcGa5fRUmtWOrRK0eNat7stcmbmm5QJNBXmX2MQS0EiPYMn/Ivv7UnLa5Qt7ABxRqa//H75idZ9bzAuej9XNws2E9jpZ63F5kgaOrGnXAQ/VJzlPY/KPk48JV5A== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(136003)(396003)(39860400002)(451199015)(46966006)(36840700001)(40470700004)(47076005)(2616005)(426003)(336012)(186003)(40460700003)(81166007)(26005)(356005)(82740400003)(40480700001)(86362001)(36860700001)(31696002)(36756003)(82310400005)(110136005)(70206006)(8676002)(8936002)(4326008)(70586007)(316002)(31686004)(5660300002)(2906002)(54906003)(53546011)(16576012)(41300700001)(44832011)(478600001)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2023 15:19:35.6204 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 74ed7080-a8fc-4de6-717a-08daeff96b8d X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0000EE3D.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8511 Hi Oleksii, On 06/01/2023 14:14, Oleksii Kurochko wrote: > > > The patch introduce sbi_putchar() SBI call which is necessary > to implement initial early_printk > > Signed-off-by: Oleksii Kurochko > --- > xen/arch/riscv/Makefile | 1 + > xen/arch/riscv/include/asm/sbi.h | 34 ++++++++++++++++++++++++ > xen/arch/riscv/sbi.c | 44 ++++++++++++++++++++++++++++++++ > 3 files changed, 79 insertions(+) > create mode 100644 xen/arch/riscv/include/asm/sbi.h > create mode 100644 xen/arch/riscv/sbi.c > > diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile > index 5a67a3f493..60db415654 100644 > --- a/xen/arch/riscv/Makefile > +++ b/xen/arch/riscv/Makefile > @@ -1,5 +1,6 @@ > obj-$(CONFIG_RISCV_64) += riscv64/ > obj-y += setup.o > +obj-y += sbi.o > > $(TARGET): $(TARGET)-syms > $(OBJCOPY) -O binary -S $< $@ > diff --git a/xen/arch/riscv/include/asm/sbi.h b/xen/arch/riscv/include/asm/sbi.h > new file mode 100644 > index 0000000000..34b53f8eaf > --- /dev/null > +++ b/xen/arch/riscv/include/asm/sbi.h > @@ -0,0 +1,34 @@ > +/* SPDX-License-Identifier: (GPL-2.0-or-later) */ > +/* > + * Copyright (c) 2021 Vates SAS. > + * > + * Taken from xvisor, modified by Bobby Eshleman (bobby.eshleman@gmail.com). > + * > + * Taken/modified from Xvisor project with the following copyright: > + * > + * Copyright (c) 2019 Western Digital Corporation or its affiliates. > + */ > + > +#ifndef __CPU_SBI_H__ > +#define __CPU_SBI_H__ I wonder where does CPU come from. Shouldn't this be called __ASM_RISCV_SBI_H__ ? > + > +#define SBI_EXT_0_1_CONSOLE_PUTCHAR 0x1 > + > +struct sbiret { > + long error; > + long value; > +}; > + > +struct sbiret sbi_ecall(unsigned long ext, unsigned long fid, unsigned long arg0, > + unsigned long arg1, unsigned long arg2, > + unsigned long arg3, unsigned long arg4, > + unsigned long arg5); The arguments needs to be aligned. > + > +/** > + * Writes given character to the console device. > + * > + * @param ch The data to be written to the console. > + */ > +void sbi_console_putchar(int ch); > + > +#endif // __CPU_SBI_H__ // should be replaced with /* */ > diff --git a/xen/arch/riscv/sbi.c b/xen/arch/riscv/sbi.c > new file mode 100644 > index 0000000000..67cf5dd982 > --- /dev/null > +++ b/xen/arch/riscv/sbi.c > @@ -0,0 +1,44 @@ > +/* SPDX-License-Identifier: GPL-2.0-or-later */ > +/* > + * Taken and modified from the xvisor project with the copyright Copyright (c) > + * 2019 Western Digital Corporation or its affiliates and author Anup Patel > + * (anup.patel@wdc.com). > + * > + * Modified by Bobby Eshleman (bobby.eshleman@gmail.com). > + * > + * Copyright (c) 2019 Western Digital Corporation or its affiliates. > + * Copyright (c) 2021 Vates SAS. > + */ > + > +#include > +#include > + > +struct sbiret sbi_ecall(unsigned long ext, unsigned long fid, unsigned long arg0, > + unsigned long arg1, unsigned long arg2, > + unsigned long arg3, unsigned long arg4, > + unsigned long arg5) The arguments needs to be aligned. > +{ > + struct sbiret ret; Could you please add an empty line here. > + register unsigned long a0 asm ("a0") = arg0; > + register unsigned long a1 asm ("a1") = arg1; > + register unsigned long a2 asm ("a2") = arg2; > + register unsigned long a3 asm ("a3") = arg3; > + register unsigned long a4 asm ("a4") = arg4; > + register unsigned long a5 asm ("a5") = arg5; > + register unsigned long a6 asm ("a6") = fid; > + register unsigned long a7 asm ("a7") = ext; > + > + asm volatile ("ecall" > + : "+r" (a0), "+r" (a1) > + : "r" (a2), "r" (a3), "r" (a4), "r" (a5), "r" (a6), "r" (a7) > + : "memory"); > + ret.error = a0; > + ret.value = a1; > + > + return ret; > +} > + > +void sbi_console_putchar(int ch) > +{ > + sbi_ecall(SBI_EXT_0_1_CONSOLE_PUTCHAR, 0, ch, 0, 0, 0, 0, 0); > +} > -- > 2.38.1 > > ~Michal From xen-devel-bounces@lists.xenproject.org Fri Jan 06 15:39:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 15:39:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472774.733132 (Exim 4.92) (envelope-from ) id 1pDooT-0000yh-Um; Fri, 06 Jan 2023 15:39:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472774.733132; Fri, 06 Jan 2023 15:39:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDooT-0000ya-S8; Fri, 06 Jan 2023 15:39:21 +0000 Received: by outflank-mailman (input) for mailman id 472774; Fri, 06 Jan 2023 15:39:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDooS-0000yU-Lo for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 15:39:20 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDooS-0002Sd-8N; Fri, 06 Jan 2023 15:39:20 +0000 Received: from 54-240-197-234.amazon.com ([54.240.197.234] helo=[192.168.4.240]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pDooS-0006Cg-1W; Fri, 06 Jan 2023 15:39:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=2b/ivgfkVHeJEkn1ZmY0o6bI75hFvxbn7e3b1wNI5So=; b=5I4xi7U2qDvifQww5bLNeTgXm8 Mc9JUJTuJARTbERribUbYhjc+2ay5F17v3TDVW1v9Rf64EG7jM03KvyYSSudISznzvoSQI7jP0IBa frHHY1e9q3gdh3UTWSBuyq3Vt7bO1BI/ahw54iMRjggKH79e7DbB2YgJKHccrweO56LQ=; Message-ID: Date: Fri, 6 Jan 2023 15:39:17 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v1 4/8] xen/riscv: introduce sbi call to putchar to console Content-Language: en-US To: Andrew Cooper , Oleksii Kurochko , "xen-devel@lists.xenproject.org" Cc: Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis References: <09da5a3184242152af6af060720a007738a55d6e.1673009740.git.oleksii.kurochko@gmail.com> <8b6a9927-8a56-6fab-6658-deb4083d2c45@citrix.com> From: Julien Grall In-Reply-To: <8b6a9927-8a56-6fab-6658-deb4083d2c45@citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Andrew, On 06/01/2023 15:19, Andrew Cooper wrote: > On 06/01/2023 1:40 pm, Julien Grall wrote: >> Hi, >> >> On 06/01/2023 13:14, Oleksii Kurochko wrote: >>> The patch introduce sbi_putchar() SBI call which is necessary >>> to implement initial early_printk >>> >>> Signed-off-by: Oleksii Kurochko >>> --- >>>   xen/arch/riscv/Makefile          |  1 + >>>   xen/arch/riscv/include/asm/sbi.h | 34 ++++++++++++++++++++++++ >>>   xen/arch/riscv/sbi.c             | 44 ++++++++++++++++++++++++++++++++ >> >> IMHO, it would be better to implement sbi.c in assembly so you can use >> print in the console before you jump to C world. > > That was already requested not to happen.  Frankly, if I was an arm > maintainer I'd object to the how it's used there too, but RISCV is > massively more simple still. There are a few reasons: 1) Xen is not fully position independent. Even if -fpic is enabled, you would still need apply some relocation in order if you want to use it before running in the virtual address space. 2) Doing any memory access before the MMU is setup requires some careful though (see [1]). With function implemented in C, you can't really control which memory accesses are done. > > Not even the pagetable setup, or the physical relocation (if even > necessary) needs doing in ASM. > > I'm not completely ruling it out in the future, but someone is going to > have to come up with a very convincing argument for why they can't do > this piece of critical setup in C. That's great if RISC-V doesn't have the issues I mentioned above. On Arm, I don't really think we can get away. But feel free to explain how this could be done... Cheers, [1] https://events.static.linuxfound.org/sites/events/files/slides/slides_10.pdf -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Jan 06 15:44:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 15:44:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472782.733144 (Exim 4.92) (envelope-from ) id 1pDot5-0002Rl-KW; Fri, 06 Jan 2023 15:44:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472782.733144; Fri, 06 Jan 2023 15:44:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDot5-0002Re-Hg; Fri, 06 Jan 2023 15:44:07 +0000 Received: by outflank-mailman (input) for mailman id 472782; Fri, 06 Jan 2023 15:44:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDot4-0002RY-EZ for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 15:44:06 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDot4-0002Xv-4Z; Fri, 06 Jan 2023 15:44:06 +0000 Received: from 54-240-197-234.amazon.com ([54.240.197.234] helo=[192.168.4.240]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pDot3-0006RU-Uf; Fri, 06 Jan 2023 15:44:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=yRY9qGHE9XSyQSDaaF/j9f3fr2k+NbzXeokeIUubZSU=; b=pvV0i8P2cfFYmDriFmPBrFO9J8 gQlfBNAmICSRM8+kk0rsu5Km98tkUxxyec/LZw87A+bB5gPtJJ2NwwEEjBuBJfxoJUwVeapeumJOI JOR9oq61TTcQkxSJi/B9wGYtxRz7g/GpQOMGgvPQzhwY7h2b3H1dKdUlmtzZ5OiHPnIg=; Message-ID: <9c9099e2-dd7a-db37-4d0c-38f1dd8d3e48@xen.org> Date: Fri, 6 Jan 2023 15:44:04 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 20/22] xen/arm64: mm: Use per-pCPU page-tables Content-Language: en-US To: Henry Wang , "xen-devel@lists.xenproject.org" Cc: Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20221216114853.8227-1-julien@xen.org> <20221216114853.8227-21-julien@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Henry, On 06/01/2023 14:54, Henry Wang wrote: >> -----Original Message----- >> Subject: [PATCH 20/22] xen/arm64: mm: Use per-pCPU page-tables >> >> From: Julien Grall >> >> At the moment, on Arm64, every pCPU are sharing the same page-tables. > > Nit: s/every pCPU are/ every pCPU is/ I will fix it. > >> >> /* >> diff --git a/xen/arch/arm/include/asm/domain_page.h >> b/xen/arch/arm/include/asm/domain_page.h >> new file mode 100644 >> index 000000000000..e9f52685e2ec >> --- /dev/null >> +++ b/xen/arch/arm/include/asm/domain_page.h >> @@ -0,0 +1,13 @@ >> +#ifndef __ASM_ARM_DOMAIN_PAGE_H__ >> +#define __ASM_ARM_DOMAIN_PAGE_H__ >> + >> +#ifdef CONFIG_ARCH_MAP_DOMAIN_PAGE >> +bool init_domheap_mappings(unsigned int cpu); > > I wonder if we can make this function "__init" as IIRC this function is only > used at Xen boot time, but since the original init_domheap_mappings() > is not "__init" anyway so this is not a strong argument. While this is not yet supported on Xen on Arm, CPUs can be onlined/offlined at runtime. So you want to keep init_domheap_mappings() around. We could consider to provide a new attribute that will be match __init if hotplug is supported otherwirse it would be a NOP. But I don't think this is related to this series (most of the function used for bringup are not in __init). >> +static inline bool init_domheap_mappings(unsigned int cpu) > > (and also here) > > Either you agree with above "__init" comment or not: > Reviewed-by: Henry Wang Thanks! Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Jan 06 15:51:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 15:51:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472788.733155 (Exim 4.92) (envelope-from ) id 1pDp09-0003s8-Dl; Fri, 06 Jan 2023 15:51:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472788.733155; Fri, 06 Jan 2023 15:51:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDp09-0003s1-A9; Fri, 06 Jan 2023 15:51:25 +0000 Received: by outflank-mailman (input) for mailman id 472788; Fri, 06 Jan 2023 15:51:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDp08-0003rr-TY; Fri, 06 Jan 2023 15:51:24 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDp08-0002ok-Qi; Fri, 06 Jan 2023 15:51:24 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDp08-0005x1-Aa; Fri, 06 Jan 2023 15:51:24 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pDp08-00049G-9l; Fri, 06 Jan 2023 15:51:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=bdQG64tiKkkrRoD3nuu+tBnUNusf5+Q5LrcxGnsvoqU=; b=WxxGmaKA7H6kGFRPSfVRV3zgQ7 KjP3pdsDiQ+t+R7E07dYm/R4XJKBbdhx4pg6lAGIvekLNU3OpETQdJYDSHGrr2Ay2AUUPSDBv05e/ pEv3ljti9GUk6HD5Nk6N/R8pw4Uvei+Wu+cK0+8+Z9tQnlF7dbthET4Ee8T3so05Evbo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 175599: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=1f5abbd77e2c1787e74b7c2caffac97def78ba52 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Fri, 06 Jan 2023 15:51:24 +0000 flight 175599 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/175599/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine 8 reboot fail REGR. vs. 173462 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux 1f5abbd77e2c1787e74b7c2caffac97def78ba52 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 90 days Failing since 173470 2022-10-08 06:21:34 Z 90 days 188 attempts Testing same since 175599 2023-01-06 07:05:33 Z 0 days 1 attempts ------------------------------------------------------------ 3293 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 501982 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Jan 06 15:57:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 15:57:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472798.733166 (Exim 4.92) (envelope-from ) id 1pDp5l-0004Wi-1u; Fri, 06 Jan 2023 15:57:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472798.733166; Fri, 06 Jan 2023 15:57:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDp5k-0004Wb-Ur; Fri, 06 Jan 2023 15:57:12 +0000 Received: by outflank-mailman (input) for mailman id 472798; Fri, 06 Jan 2023 15:57:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDp5j-0004WR-Ot; Fri, 06 Jan 2023 15:57:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDp5j-0002vJ-My; Fri, 06 Jan 2023 15:57:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDp5j-00066P-Ap; Fri, 06 Jan 2023 15:57:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pDp5j-00086t-AP; Fri, 06 Jan 2023 15:57:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=g/I03d3MZ7AG/eC5r5t5Zb6LOu2cfQNNU6Ha2XHJIEY=; b=y91qi223mU9LjwTNZughHSzKX0 XxFWUc2P1OXcusu2LIUp/kHRWkyx8rbpbDoUDFGHMCQgGp7O7sPVutHxmn/QV4/1QMtGLqXfFHDew 0pFQee3Qn3QU2R40Gb4fZeLi4ml4I6msVaKkrs/7cFPfm4KufugJrTRV/akUsrDjySy8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 175604: all pass - PUSHED X-Osstest-Versions-This: ovmf=5386c9e6dab2f6a555e679aff9f6a59f60c8e029 X-Osstest-Versions-That: ovmf=0aca5901e34489573c4e9558729704f76869e3d0 From: osstest service owner Date: Fri, 06 Jan 2023 15:57:11 +0000 flight 175604 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/175604/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 5386c9e6dab2f6a555e679aff9f6a59f60c8e029 baseline version: ovmf 0aca5901e34489573c4e9558729704f76869e3d0 Last test of basis 175602 2023-01-06 08:41:27 Z 0 days Testing same since 175604 2023-01-06 13:12:23 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jiewen Yao Michael Roth Min M Xu Min Xu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 0aca5901e3..5386c9e6da 5386c9e6dab2f6a555e679aff9f6a59f60c8e029 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Jan 06 16:32:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 16:32:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472807.733177 (Exim 4.92) (envelope-from ) id 1pDpdw-0000me-P2; Fri, 06 Jan 2023 16:32:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472807.733177; Fri, 06 Jan 2023 16:32:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDpdw-0000mX-Lu; Fri, 06 Jan 2023 16:32:32 +0000 Received: by outflank-mailman (input) for mailman id 472807; Fri, 06 Jan 2023 16:32:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDpdu-0000mR-Rz for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 16:32:30 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b3f7364a-8ddf-11ed-91b6-6bf2151ebd3b; Fri, 06 Jan 2023 17:32:28 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b3f7364a-8ddf-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1673022748; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=eavG7+hkgdUhfacVrhQ5HxWN5atkNNEzN09mWvS484E=; b=P/1rdWPpa2r4tjboEGibWw9MNNY16enMNewFQC+7X0+9eoEJnD/A7O9i hC+Dxx9E8nR7eYvdbbB+/7BcQ4K93U53KwVzEcn6cDmikOh075qIIOQxe OZCuRniiy6FSLCdcIMIeJv8nCGazurSbHqTgv3w/X/ex2amesnSIMkZ5d U=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 91538047 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:8gv5T6+4bAVqRDvTvzLcDrUDHn6TJUtcMsCJ2f8bNWPcYEJGY0x3y jQfWWDTbPqMN2akLdB/admy8RkPuJ/UmIAySgFpryA8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKucYHsZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kIx1BjOkGlA5AdmPKgV5AW2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDkkf7 uECcmFSZSualsu/ybK2d7Rnn98aeZyD0IM34hmMzBncBPciB5vCX7/L9ZlT2zJYasJmRKiEI ZBDMHw2MUqGM0Yn1lQ/UfrSmM+hgGX/dDtJ7kqYv6Mt70DYzRBr0airO93QEjCPbZQMwx3I/ j6Zl4j/KhUbHYGvmRydzjW1n+7QrR/KSIkDO5Tto5aGh3XMnzdOWXX6T2CTvv2RmkO4HdVFJ CQ8/jclqKk5/02sZtb4Vhy85nWDu3Y0XtNKGOp88waJy6fO4i6cB24JVCBIc8098tM7TjxC/ l2GhdTyHhR0raaYD3ma89+8vT60fCQYM2IGTSsFVhcepcnuppkpiRDCRcolF7S65vX+ECv0x HaMqy43m7I7iM8N2r+l9EvWmHSwq5PJJiY84AnNU2vj5ApieImjZqSt6F7W9+hJN5eCCEWMt 3hss82X9usJS4qKkC2AWuQlAbeo4vGfPXvdnTZS84IJrmr3vST5JMYJvW84dBwB3ts4lSHBM VTOo1kAu5RoJWqDZKZ3br/sAN0x9P21fTj6bcz8Yt1La5l3UQaI+iByeEKdt1zQfFgQfbIXY snCL5v1ZZoOIeE+lWftGb9BuVM+7npmrV4/U6wX2PhOPVC2QHeOAYkIP1KVBgzSxPPV+V6Fm zqz2ibj9vm+bAEcSnOMmWLwBQpQRZTeOXwRg5I/SwJ7ClA6cFzN8teIqV/bR6Rrnr5OisDD9 WynV0lTxTLX3COYc1TWMS0zOe++DP6TSE7X2wR2bT5EPFB6OO6SAFo3LcNrLdHLCsQ5pRKLc xX1U5rZWakeItg20z8ccYP8vORfSfhfvirXZ3DNSGFmL/Zdq/nhpoeMkv3HqHNfUUJadKIW/ 9Wd6+8sacBbH148VJ6MOK7HIpHYlSF1pd+elnDgerF7EHgAOqAwQ8Atppfb+/0xFCg= IronPort-HdrOrdr: A9a23:u9b666wS0thNwpKMtpuMKrPwFr1zdoMgy1knxilNoEpuA6ulfq eV7ZcmPH7P6Ar5N0tKpTntAsO9qBDnlKKdg7N/AV74ZniDhILAFugL0WKF+VDd8kbFmNK1u5 0NT0DQYueAa2STIazBkWuF+3dL+qjjzJyV X-IronPort-AV: E=Sophos;i="5.96,305,1665460800"; d="scan'208";a="91538047" Date: Fri, 6 Jan 2023 16:32:15 +0000 From: Anthony PERARD To: Carlo Nonato CC: , , , , Wei Liu , Juergen Gross , Marco Solieri Subject: Re: [PATCH v3 4/9] tools/xl: add support for cache coloring configuration Message-ID: References: <20221022155120.7000-1-carlo.nonato@minervasys.tech> <20221022155120.7000-5-carlo.nonato@minervasys.tech> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: On Thu, Dec 22, 2022 at 04:28:56PM +0100, Carlo Nonato wrote: > > Could you invent a name that is more specific? Maybe "cache_colors" or > > something, or "vcpu_cache_colors". > > What about llc_colors? LLC stands for Last Level Cache and I'm trying to use > it everywhere else since it's what is really implemented (not any cache is > colored, just the last level) and it's shorter than cache_colors. "llc_colors" sounds good. Cheers, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Fri Jan 06 16:59:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 16:59:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472815.733187 (Exim 4.92) (envelope-from ) id 1pDq43-0003KV-0O; Fri, 06 Jan 2023 16:59:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472815.733187; Fri, 06 Jan 2023 16:59:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDq42-0003KO-Tz; Fri, 06 Jan 2023 16:59:30 +0000 Received: by outflank-mailman (input) for mailman id 472815; Fri, 06 Jan 2023 16:59:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDq42-0003KI-73 for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 16:59:30 +0000 Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com [2607:f8b0:4864:20::536]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7a40c5c8-8de3-11ed-b8d0-410ff93cb8f0; Fri, 06 Jan 2023 17:59:27 +0100 (CET) Received: by mail-pg1-x536.google.com with SMTP id v3so1536321pgh.4 for ; Fri, 06 Jan 2023 08:59:27 -0800 (PST) Received: from localhost (c-73-164-155-12.hsd1.wa.comcast.net. [73.164.155.12]) by smtp.gmail.com with ESMTPSA id 5-20020a621505000000b005772d55df03sm1366021pfv.35.2023.01.06.08.59.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jan 2023 08:59:25 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7a40c5c8-8de3-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=xw2fjJMCegprkjtpBWjKKtwQO+Lc1SNHRh05H+6IcWk=; b=oy42dzreI1K2/czGG5RMStkjz3WM5r9ObUmxjgHNSRhFJi5T7LftO2BOVka5gAfwk4 Id7aK311Fes10tyYVopdlU6zcsUtkC+I2UA723sjEoEnGfDA+6I2KeXPEGlQDQ4PrTJp Or7tv36dEbF+ikv0Yv9FKjo7zEKQK0duRVhVDqJFZzCwkQIUxeovv9LiNxKvkwQpJyEB NlbeQKJ06CkRp4sbLdU4xCRibVD4iq54UaEM9ZchxAQ9pmiuOOF/Fp4kLMbvaydCcMhV NcV+rKKF32N30iOo9VIlzfT1QnHbAVFvl8mvf7EHVikqRWlHn9+aQ1iyo7rj7Q3qSAuv QRxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xw2fjJMCegprkjtpBWjKKtwQO+Lc1SNHRh05H+6IcWk=; b=PzmB2xhripFXcFWhEGRKbWUz3knQaw1bXpONLyJsIZgr7gO5bJLs64pm8YzjyJfn7M uf0tHG0Vvx/Rexy2FMySfSKVIJiMEbEiwx5iMhXNRj66lqBBG7Fgr8mVlOkeO0v1v8H8 25WFPWO3qup8dFHc3BlCKPQZycnBf+ZukOQqfSj6gPCvQ5oa9lsyeFC8Wh708uTNb8mW fvaQijkrr6M+GXQ1LnOgPuL/rzERFkl3/BqBFIbmwVHDlEeWbugbkAetXV9C26QkUt/4 +MRvnfh7XpsjiYsPaIsckGvaUbQa4lqaj+U+Z+ASkhebrKcasUukTo9/TR8E5/E44vTe f78A== X-Gm-Message-State: AFqh2kpjzypgMMNj02yp7rhEgA80MYyTc9dM/ZkP/JMfZ2jcZdlhgFHM QYYP6UWaVST6fJiunQpiess= X-Google-Smtp-Source: AMrXdXtOGTNbjH3A3XUDHxWC8R10zSMyAYt2FDPQRFBwCu6VlK9Tb4xRLCIxxecja0y+hqDRmg2czw== X-Received: by 2002:a62:1c95:0:b0:583:3adc:baed with SMTP id c143-20020a621c95000000b005833adcbaedmr4356405pfc.8.1673024365828; Fri, 06 Jan 2023 08:59:25 -0800 (PST) Date: Tue, 20 Dec 2022 06:23:07 +0000 From: Bobby Eshleman To: Oleksii Kurochko Cc: xen-devel@lists.xenproject.org, Andrew Cooper , Stefano Stabellini , Gianluca Guida , Alistair Francis , Connor Davis Subject: Re: [PATCH v1 4/8] xen/riscv: introduce sbi call to putchar to console Message-ID: References: <09da5a3184242152af6af060720a007738a55d6e.1673009740.git.oleksii.kurochko@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <09da5a3184242152af6af060720a007738a55d6e.1673009740.git.oleksii.kurochko@gmail.com> On Fri, Jan 06, 2023 at 03:14:25PM +0200, Oleksii Kurochko wrote: > The patch introduce sbi_putchar() SBI call which is necessary > to implement initial early_printk > I think that it might be wise to start off with an alternative to sbi_putchar() since it is already planned for deprecation. I realize that this will require rework, but it is almost guaranteed that early_printk() will break on future SBI implementations if using this SBI call. IIRC, Xen/ARM's early printk looked like a reasonable analogy for how it could work on RISC-V, IMHO. > Signed-off-by: Oleksii Kurochko > --- > xen/arch/riscv/Makefile | 1 + > xen/arch/riscv/include/asm/sbi.h | 34 ++++++++++++++++++++++++ > xen/arch/riscv/sbi.c | 44 ++++++++++++++++++++++++++++++++ > 3 files changed, 79 insertions(+) > create mode 100644 xen/arch/riscv/include/asm/sbi.h > create mode 100644 xen/arch/riscv/sbi.c > > diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile > index 5a67a3f493..60db415654 100644 > --- a/xen/arch/riscv/Makefile > +++ b/xen/arch/riscv/Makefile > @@ -1,5 +1,6 @@ > obj-$(CONFIG_RISCV_64) += riscv64/ > obj-y += setup.o > +obj-y += sbi.o > > $(TARGET): $(TARGET)-syms > $(OBJCOPY) -O binary -S $< $@ > diff --git a/xen/arch/riscv/include/asm/sbi.h b/xen/arch/riscv/include/asm/sbi.h > new file mode 100644 > index 0000000000..34b53f8eaf > --- /dev/null > +++ b/xen/arch/riscv/include/asm/sbi.h > @@ -0,0 +1,34 @@ > +/* SPDX-License-Identifier: (GPL-2.0-or-later) */ > +/* > + * Copyright (c) 2021 Vates SAS. > + * > + * Taken from xvisor, modified by Bobby Eshleman (bobby.eshleman@gmail.com). > + * > + * Taken/modified from Xvisor project with the following copyright: > + * > + * Copyright (c) 2019 Western Digital Corporation or its affiliates. > + */ > + > +#ifndef __CPU_SBI_H__ > +#define __CPU_SBI_H__ > + > +#define SBI_EXT_0_1_CONSOLE_PUTCHAR 0x1 > + > +struct sbiret { > + long error; > + long value; > +}; > + > +struct sbiret sbi_ecall(unsigned long ext, unsigned long fid, unsigned long arg0, > + unsigned long arg1, unsigned long arg2, > + unsigned long arg3, unsigned long arg4, > + unsigned long arg5); > + > +/** > + * Writes given character to the console device. > + * > + * @param ch The data to be written to the console. > + */ > +void sbi_console_putchar(int ch); > + > +#endif // __CPU_SBI_H__ > diff --git a/xen/arch/riscv/sbi.c b/xen/arch/riscv/sbi.c > new file mode 100644 > index 0000000000..67cf5dd982 > --- /dev/null > +++ b/xen/arch/riscv/sbi.c > @@ -0,0 +1,44 @@ > +/* SPDX-License-Identifier: GPL-2.0-or-later */ > +/* > + * Taken and modified from the xvisor project with the copyright Copyright (c) > + * 2019 Western Digital Corporation or its affiliates and author Anup Patel > + * (anup.patel@wdc.com). > + * > + * Modified by Bobby Eshleman (bobby.eshleman@gmail.com). > + * > + * Copyright (c) 2019 Western Digital Corporation or its affiliates. > + * Copyright (c) 2021 Vates SAS. > + */ > + > +#include > +#include > + > +struct sbiret sbi_ecall(unsigned long ext, unsigned long fid, unsigned long arg0, > + unsigned long arg1, unsigned long arg2, > + unsigned long arg3, unsigned long arg4, > + unsigned long arg5) > +{ > + struct sbiret ret; > + register unsigned long a0 asm ("a0") = arg0; > + register unsigned long a1 asm ("a1") = arg1; > + register unsigned long a2 asm ("a2") = arg2; > + register unsigned long a3 asm ("a3") = arg3; > + register unsigned long a4 asm ("a4") = arg4; > + register unsigned long a5 asm ("a5") = arg5; > + register unsigned long a6 asm ("a6") = fid; > + register unsigned long a7 asm ("a7") = ext; > + > + asm volatile ("ecall" > + : "+r" (a0), "+r" (a1) > + : "r" (a2), "r" (a3), "r" (a4), "r" (a5), "r" (a6), "r" (a7) > + : "memory"); > + ret.error = a0; > + ret.value = a1; > + > + return ret; > +} > + > +void sbi_console_putchar(int ch) > +{ > + sbi_ecall(SBI_EXT_0_1_CONSOLE_PUTCHAR, 0, ch, 0, 0, 0, 0, 0); > +} > -- > 2.38.1 > > From xen-devel-bounces@lists.xenproject.org Fri Jan 06 17:16:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 17:16:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472823.733199 (Exim 4.92) (envelope-from ) id 1pDqKl-0005iC-Cc; Fri, 06 Jan 2023 17:16:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472823.733199; Fri, 06 Jan 2023 17:16:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDqKl-0005i5-9D; Fri, 06 Jan 2023 17:16:47 +0000 Received: by outflank-mailman (input) for mailman id 472823; Fri, 06 Jan 2023 17:16:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDqKk-0005hz-9H for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 17:16:46 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e3a47588-8de5-11ed-91b6-6bf2151ebd3b; Fri, 06 Jan 2023 18:16:44 +0100 (CET) Received: from mail-dm6nam10lp2105.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.105]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 06 Jan 2023 12:16:36 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CO3PR03MB6776.namprd03.prod.outlook.com (2603:10b6:303:164::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Fri, 6 Jan 2023 17:16:31 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5944.019; Fri, 6 Jan 2023 17:16:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e3a47588-8de5-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1673025404; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=gLRhIwINg8SKw4p5CaBpYacg5GUGCKOjTC1xEUkX0UQ=; b=Ytqk02QEqvY9ZJzT/a7QuTp3+j3s07WKSjMwX3THD+XLQh9XZzQBW+k5 QFKdLI+KB5cjEMGuSn+ui7TtBX2/D0lOtLNR4va0XVnV6dFyNCVm+3ZHg mu73ehuA5P3BtHyWEOUOCB1wiBW8JhudISqM7MSrCklaXrIguF+hSFbHW c=; X-IronPort-RemoteIP: 104.47.58.105 X-IronPort-MID: 90455449 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:Ps99SKw+00Fh8a2Yr696t+esxyrEfRIJ4+MujC+fZmUNrF6WrkUGn zAbXW6HbvyNZDemf40iOdi+o0sHvpDVzNAxGgpsqCAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTbaeYUidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+U0HUMja4mtC5QRnPa4T5jcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KVte/ K1EMAsdVwikq6HnzYzjRsdxmO12eaEHPKtH0p1h5RfwKK9+BLzmHeDN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvjiVlVQsuFTuGIO9ltiibMNZhEuH4 EnB+Hz0GEoyP92D0zuVtHmrg4cjmAuqAN5PSeHkp5aGhnXD/2sRVQNPCWGCsPqaklW3aYlBL hQtr39GQa8asRbDosPGdxe/qnSVswUcX9dVGusS5wSEy66S6AGcbkADSjNCc90n8swrXzsh1 lyOt9zsDD1r9raSTBq15rqS6D+/JyURBWsDfjMfCxsI5cH5p4M+hQ6JScxseIaulcH8Ezz0x zGMrQA9iq8VgMpN0L+0lXjIgjuqooXCRyYv5xvQRWOj5UVyY4vNT4Ws6EPH5PdaaoiDR1+Kv WMshMSVqusJCPmlnyuLRuIPELi35u2tPzjVgFopFJ4knwlB4FamdIFUpT17ekFgN59cfSezO ReO/wRM+JVUIX2mK7dtZJ68ANgryq6mEsn5UvfTbZxFZZ0ZmBK7wRyCrHW4hwjF+HXAW4lmZ v93re7E4a4mNJla IronPort-HdrOrdr: A9a23:Q6PAEakmA/747Zojpcj75InezEjpDfIW3DAbv31ZSRFFG/Fw9v re/8jzsCWetN9/Yh0dcLy7V5VoIkm9yXcW2+cs1N6ZNWGN1VdAR7sC0WKN+UyGJwTOssJbyK d8Y+xfJbTLfD5HZB/BkWyF+gAbsb26GQuT9IXj80s= X-IronPort-AV: E=Sophos;i="5.96,305,1665460800"; d="scan'208";a="90455449" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MxutUXdXhtsYDp/qqj4sO6WaRC5GSjPswhkGR2CC/FzLsy3hpfXYwUPecr6RZKgsP9UE/P/vpaLJ8HTfqxZWDVQEuanf1VzRIgBl4nX25koLiNBAIwRp8Nt+o9hzxh6OyznLDdr9JEZ5g+gEhBhxoucPui8yEkDXkivwLl3Dtu/rhHbsQYLgEydanGxALRqB6DHFhAwcUtGR6pj84vVv7W2iUZjwj+13Zl8qnfqDFpHbDJW841A93/vScLvIftLFulr5GxSrAjrVlC7WGEnfsAawbSPvitkHkDeY1u5qMTGaWSWEHcxKqA7gc7fid+XGHOjLtiWvQhN0yjBprFCTEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gLRhIwINg8SKw4p5CaBpYacg5GUGCKOjTC1xEUkX0UQ=; b=cQv5xgzXF5MSQCti70zoM3aDp4HMlB5szNkWLF3VrORWTneCRwXWikfz6EFNHkNzBlcwF6VXFDVWeVHYEBBSmoNjxMjvMw52oX5MXnpsuFTLSM9zZ+bYNNJ/SX7/d0/+ppMxHV9ESLpjG5A2EFIanlaPXeS0NiIq2AVugPRafKsRe86mblIwSFb11iZ9hxfVkmnXGFgd0a4W5uyw+sBJnOWBuzSM8Pkvq45UjT2JZsR1xNOIQnQ5OAEy9s2BwTfT+qJ2F1/kOykpJ3oguRMaYIXZyUV9X/oepcnfELzP67K8+g69FBz1vD2shZnoA4DTegv6ta+bgFN6b/yq6RrpIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gLRhIwINg8SKw4p5CaBpYacg5GUGCKOjTC1xEUkX0UQ=; b=AvWFFyy7w+a4lnwzce+FLOWzbc6UYbSujbJQKjL5AZ3eFd7hiT6TcnUxN614s8+q9wdOc5zeRsvd4LWRv079g4+qkk7JyAYJZaJF9Qg6H1r3B1Q7xHaNSQseKhGPXGDvclL1mlJhZP937GfSpzZD7vzWKw7pJJOMHzymaQgyGTM= From: Andrew Cooper To: Bobby Eshleman , Oleksii Kurochko CC: "xen-devel@lists.xenproject.org" , Stefano Stabellini , Gianluca Guida , Alistair Francis , Connor Davis Subject: Re: [PATCH v1 4/8] xen/riscv: introduce sbi call to putchar to console Thread-Topic: [PATCH v1 4/8] xen/riscv: introduce sbi call to putchar to console Thread-Index: AQHZIdDaR/Z8ZObOWUu8wVolwH1ydK52M2qAgBtuMAA= Date: Fri, 6 Jan 2023 17:16:31 +0000 Message-ID: <320cc1b3-f03f-ad87-205f-d3c5db446f7d@citrix.com> References: <09da5a3184242152af6af060720a007738a55d6e.1673009740.git.oleksii.kurochko@gmail.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|CO3PR03MB6776:EE_ x-ms-office365-filtering-correlation-id: f7a1615e-5147-44d3-3917-08daf009c13f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: JiEODwImNz+2GnlQJbmMK/wHO55GC2W8oGAyCiZsGC93bsLDYtr2SMFkmPn5KXSPORVvQ3jgEynVlj2edemnEqtRdg42l2xlL10TGQPZLG4FuPj1y0lN/abG3nUBX96e4UhLn7gJ0Q75aLw7YnJoNYaXEb9hZvdAKKRC8U5Tiirw84JHaHt25xyAE/CD5RAf5UPagpODA+s5IGtP59+x0xjLAe6ecqIEqfWgr0LosGhyDDCwR9k/lrzi5JvD+Xq8uANL2ReU6RCOtOp5jwE705oO4iQMaekooNYnFdsUOXNUK46rYnVsBuFU66lcrdW/i/GRWZ4TYMDcEzQ9EsTcgUEuZGgGNbDxO+wqc+km6SuQXm2ExyremOWR5xexykbVIh9i7tyiyXSX+QSF3MdPnMxRf+KwRfb29bot/fVcRbCeBqvXsyV1cFDzAo3b29X7n/pw9MBl9a+wzNOKaOI2zDaZcPzykgDybqv5QeQMTVjh39FRoJTV+YzKKAkSq/F5S6wpMxjSDSZS91t2xfCbGMlM1usmxwJPKOuoyGGDlHcyBy48XgslpZKMgjwEcUw7LqqHo3od4aHIPk86usJvOB5h9w1HggoUNVJsfSe4w9KsUSPUOjQ9+hxXAMoRNT3rEWYGrBHIR3YmyW+AYRCqtlo8+4PQw9O4eY7U36ODweE4QDgYcNIl11JN8N5SaKN8XmCjzqt+nkmZDDJHFWZ+5kLNNiCCFvFBpM3cHqP/z46VxpuuLb+7EN5BJlwBZ/TGhq1on37+Xntf9/8tG7+sfw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(366004)(346002)(376002)(136003)(39860400002)(451199015)(186003)(26005)(2616005)(53546011)(6506007)(82960400001)(86362001)(38070700005)(36756003)(31696002)(38100700002)(122000001)(8676002)(31686004)(4326008)(41300700001)(2906002)(5660300002)(8936002)(66556008)(6512007)(66476007)(71200400001)(6486002)(64756008)(91956017)(76116006)(316002)(478600001)(110136005)(66946007)(66446008)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ckpMbXdzQjlsbStXMUJFRElWVHRZWU04YXh2bWlpS1dkakRWdzhkWjQwUFB4?= =?utf-8?B?N2E5SGVSb2RqMXpzODJSckdoYWFnZk8xWnNpYi9kWS9KaUNvSnVOZm4rcTVK?= =?utf-8?B?Y0J0SjdJVWFLUlp5eitqa0lmVEtuRDBqbDVVU25VNWhWTXZGelR3VC9CUEJk?= =?utf-8?B?c09ZT2FDcVVibmd4TWNyRmRMM3JoWk45bEtmSUkvZU1FSEtpdkNyRkFWcWtX?= =?utf-8?B?aU9lTGk3K2sydnFadkVKUmVHY0FZRUtPL3NmV2xQVnIvS3B2bkw5cThQQ0h6?= =?utf-8?B?NzE4MFhCSDl3L2tUaENnb3ZpZjJFMzNNSk4zRjRTU1M0dEFJQ2JHWFNwRkpv?= =?utf-8?B?WW4wVzJjVEJmWWpId2tSNjhwVzBqNTBwS1JWbkdoUU4rY3VRUGVEVm52N1dD?= =?utf-8?B?MVIrNUIydUh0Smh0eTRRdkE0QmU3N1ZURk5YNEVZekJXVGNkenZqbDY0aTQ1?= =?utf-8?B?NWVMTitoR0RRRnd6dTlYa2NRN2FHMHdYakE4R2RGYkVhZXAzcGs4ZjBoLy8y?= =?utf-8?B?Y00yd3pBN29PMDdRTFJ5V1p6UXYrb0lSWFJwQUM0UGY5a2tWazRHaVFMeHB0?= =?utf-8?B?MGQ2ZitHMHhPSlhiVEg5UzJ5ZlQwT1lwR2tHeVhxRXBJSkVqcmtUeHVGSW50?= =?utf-8?B?Yk5IV0VNQ1ZaL29wNVFveThSTG5Sc1pyRkZaME96RnJxbitoZExKTkMwOW85?= =?utf-8?B?Qm1NaStSTTVhNkhkeEJ1dG1Ib0hBVEdCeDBIZnA4U3Q3VUhZM1RqOWhUc1BY?= =?utf-8?B?a1FBQ1dwSGIxb3B2WC9yc2VCaXh2RGtvL0N3Qmk3ZXhpVzdIbHFodDU4Tm9p?= =?utf-8?B?UWQ1NVBjaFNQMXdXYm1hMGpUdFo1K2YzUGpWWDZwdFViTXJyU2hnaGRTMjFl?= =?utf-8?B?ZUdZL1JOeGFON2JnREVkdGluZ1RJb0p1V0VUc3hmZVZjeE1sb0Nsb0RxVjJt?= =?utf-8?B?eGVFQ3BjZ09UUjMvS25wUHhEdTB3ZzBQYy91RHh4N2FzZzRGenF3OE5xYURh?= =?utf-8?B?N1RVODdjdnNUVmtkT1hEYlNhRXpaNGZ4TTdQOENOT3JqOXJZemtWa1djV0Ja?= =?utf-8?B?c1B1U1R3UlNYS3BJYVpmUDRJVmhsdmtiejlWMC9DRXcwS0xPdVBrY0VMejlv?= =?utf-8?B?WSszb2FIOVVyZE93YWJNYXJ0ZHJraklxdzdGQkU1bDljYldNeHZ4YmhEYkRF?= =?utf-8?B?bUx2Yko3bHdQVHo1SnRpZDB1TmVjS3QxaERhYkI3bnlyWWo3a2haL0RGdXFI?= =?utf-8?B?T3lmdWdvQ3pNTEJ1K0wwRWVrTE1BYU1tOTFTQm5wTU5BZGZRbmJWUC9EY05R?= =?utf-8?B?eUZiM1RObUlNOEp3K3ZxZXZvdVlOVjJJRXJXdTJEZWhnZGl3MGloTG9CZTYx?= =?utf-8?B?dkVVekExdklncm54bkV1ZnVUazdUMVhheW5EMTMwUHc4NW10TGRzY3lVTEhi?= =?utf-8?B?cm5uTHQ2Z3dOUTFTcDlEeFhmQmtCSHhtQW52Q2puYm1pQXgyNzJ0ZEdsSnlS?= =?utf-8?B?clNQRU9IN1E5MGVad0ZaT3BadXdHN1AwWHZKZytwUDc4SkpCc2IvclpzZFha?= =?utf-8?B?dTE4QUcwRlBoV01GZjR2R0xhZ0FPV3IyWmxWM0p2Mlp4WUx5NW92K3B4R3hl?= =?utf-8?B?UVZQeDErUWdlVlQyV1dvRmIzUHQzOTFVSi8wU0U4YXhCY0U0S1RsU3BPYUIx?= =?utf-8?B?a05xY05tV0RoWkpDQXJWMzQvQTFwblhQZjJhMnprcENwdTlVOW5QRVVmY0J2?= =?utf-8?B?Ry9RRkwyWGVuQWlCL3N1YmNwamJGWmNOTXdjZ3AyUDR0ZkRhRlBFWEdPNmpK?= =?utf-8?B?aHRjdWN5SzJ0eGRock1WQkxLZVhKMXdTSEx6VWI1NXJqRThhZy9qSlRuMnht?= =?utf-8?B?SEpEMVB5V09aUnlHTUlVRXlzTlN4N2NEeXF4YWtIbCtHZmJoRG9VcWZLLzlk?= =?utf-8?B?Mnd4Q1c4ZTZzaDRBNE5nbUJYRXovWnBkM1Z0Wk05ME5pMlZFMi9OSWJaV1JC?= =?utf-8?B?aWFUWmZjdXZYT0l2ajVXTkFteDBaUWNhYXEvbFZScnA1ZnN1ZnBydnFHR292?= =?utf-8?B?LzhjWXV1VEtiQWNjYjN6UlBKU2NCbFN5MFgzNTQzYTlRbEFoa2FpV214YUhZ?= =?utf-8?B?SlE4dXZWV2NjQ1pwQ2JBbG9DNE1iVWo0Y0VqY1REMEdrajRLWDVxWVpOSFdJ?= =?utf-8?B?clE9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?RE5zbUlyMnRGbjhOU2JLci80RmY5WUZrQXBJN3dMZmFzdGZEVzJyTlQva0py?= =?utf-8?B?RjlsQVBlclU0WVF2b001TkU0NXZRdWdsaFEvWHdPaXdiZkpwWHVyY3FTNlZj?= =?utf-8?B?VnNuYmlmYTVXZDdwNVVIY1FTSFNXak1uY2drcWYxb0g5a0o3MDFkZkI1dklP?= =?utf-8?B?OUd4a2M3TjVWMmxpWkpLd1E4MGtjaHhqdXB1SU4rektoMnpKNVd2Wml3V1ZY?= =?utf-8?B?WkQzSXQ0UzFKaGkxOEpIWXB1Z3duYUNvakYxSGlNeU5WbEt0K3RXMzdXMnFI?= =?utf-8?B?QWxEQ1gvUVhvRk4yTzdlSXBnUTcrZ0hFVlZhaFRVRjRuN3ZGTWJBZjRjdEZF?= =?utf-8?B?ZVBVMEUwaEVJNG85bUs1VlVFbTBFUDh6bGF0VGRCRjBGQUJXQUc3YzBIOE80?= =?utf-8?B?OS9zTVJGS0sxWk84VFk3SFN5UzdkQllRcjU4Z0RuYmhDKzlBNWduQ29tdk9Q?= =?utf-8?B?cU83bkN6cFIxMHVOZEVJd2JwQnlmNlJPRDFDbjJSZm5qRXpLQWhZOEl1L0tH?= =?utf-8?B?bXpocWZtZjFHTnVqdWUxRytnRHZ4cldrajBuMGhwbDFXSnpwZ05FdjREZTBu?= =?utf-8?B?Q25YZ2xyQkFZU3pyb2RHa2k3QTQrT2pWeTdNODlkY24wZDhGZVV6LzBiK0oy?= =?utf-8?B?VlFmMFZlU1BvMjNQU3J1VXZpRUV1SXFaTElKaTdWUXl2d1RZeXoyM2M3RXVJ?= =?utf-8?B?UkJvZThIV1N3ZjZJSnZWOEl1cDNUZFlpTDM3SmYySzJZaGVDem9TWlNLcUh4?= =?utf-8?B?NmRTcng1clA1UE4xTU81d1pOSHJnQk1uSlA4TGlETjJtMzVPNkk5SUlRWjdH?= =?utf-8?B?NlZpekhPS3U4R2xSWEQ3Sk0zSGNaam5qM040NFVTU0FJaVdsZzZBMU9GTVhi?= =?utf-8?B?VXh4YmI0SEY1NHFoOXBQelVnNXVBUk5IMndQTnNhcDNnb1VsLy9yMDQ1YmJB?= =?utf-8?B?eUk3Qk9MZ2NqL25aSGNHSTEwRFNDNkplUkNVbzAwMG1ZUERObm9pczFwK0pU?= =?utf-8?B?SFlhTU44TFZRckNzbGFKQXFvUjczNlJndFd5SXM5cXZxbjAwR2VBTWpmVGsx?= =?utf-8?B?dFovZ3gzTHJPWlFWM2xZRjhmeTNtTG0zSE0wVnh0SjZ0ZEN0VlE3Y3VNbXVP?= =?utf-8?B?cmNnUWErUU1UM1lhb0JXdlpzNGNLaW85RVNuRjJpbzFVbURLUzZsTDY0SGdl?= =?utf-8?B?YnZ1VHhyWTkzZ2ZFclRUU3RrVU10emdKeThzODk0NVhhaWZYQVVTMzJmM3FN?= =?utf-8?Q?9wGmK6NMmRm8Vqb?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f7a1615e-5147-44d3-3917-08daf009c13f X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jan 2023 17:16:31.3239 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ae54frv2IRlJmslBHhoP5kW6SLZ5QpwmQfzyH2owvxOiyOmas7ZqX9yfwCY15J769g+7wEYNgz+xlQGFnWdg3uf80xR74sJUHJTG6DXhGEM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO3PR03MB6776 T24gMjAvMTIvMjAyMiA2OjIzIGFtLCBCb2JieSBFc2hsZW1hbiB3cm90ZToNCj4gT24gRnJpLCBK YW4gMDYsIDIwMjMgYXQgMDM6MTQ6MjVQTSArMDIwMCwgT2xla3NpaSBLdXJvY2hrbyB3cm90ZToN Cj4+IFRoZSBwYXRjaCBpbnRyb2R1Y2Ugc2JpX3B1dGNoYXIoKSBTQkkgY2FsbCB3aGljaCBpcyBu ZWNlc3NhcnkNCj4+IHRvIGltcGxlbWVudCBpbml0aWFsIGVhcmx5X3ByaW50aw0KPj4NCj4gSSB0 aGluayB0aGF0IGl0IG1pZ2h0IGJlIHdpc2UgdG8gc3RhcnQgb2ZmIHdpdGggYW4gYWx0ZXJuYXRp dmUgdG8NCj4gc2JpX3B1dGNoYXIoKSBzaW5jZSBpdCBpcyBhbHJlYWR5IHBsYW5uZWQgZm9yIGRl cHJlY2F0aW9uLiBJIHJlYWxpemUNCj4gdGhhdCB0aGlzIHdpbGwgcmVxdWlyZSByZXdvcmssIGJ1 dCBpdCBpcyBhbG1vc3QgZ3VhcmFudGVlZCB0aGF0DQo+IGVhcmx5X3ByaW50aygpIHdpbGwgYnJl YWsgb24gZnV0dXJlIFNCSSBpbXBsZW1lbnRhdGlvbnMgaWYgdXNpbmcgdGhpcw0KPiBTQkkgY2Fs bC4gSUlSQywgWGVuL0FSTSdzIGVhcmx5IHByaW50ayBsb29rZWQgbGlrZSBhIHJlYXNvbmFibGUg YW5hbG9neQ0KPiBmb3IgaG93IGl0IGNvdWxkIHdvcmsgb24gUklTQy1WLCBJTUhPLg0KDQpIbW0s IHdlJ3JlIHVzaW5nIGl0IGFzIGEgc3RvcGdhcCByaWdodCBub3cgaW4gQ0kgc28gd2UgY2FuIGJy ZWFrDQoidXBzdHJlYW0gUklTQy1WIHN1cHBvcnQiIGludG8gbWFuYWdlYWJsZSBjaHVua3MuDQoN ClNvIHBlcmhhcHMgd2Ugd2FudCB0byBmb3JnbyBwbHVtYmluZyBzYmlfcHV0Y2hhcigpIGludG8g ZWFybHlfcHJpbnRrKCnCoA0KKHRvIGF2b2lkIGdpdmluZyB0aGUgaW1wcmVzc2lvbiB0aGF0IHRo aXMgd2lsbCBzdGF5IGFyb3VuZCBpbiB0aGUNCmZ1dHVyZSkgYW5kIHVzZSBzYmlfcHV0Y2hhcigp IGRpcmVjdGx5IGZvciB0aGUgaGVsbG8gd29ybGQgcHJpbnQuDQoNCk5leHQsIHdlIGZvY3VzIG9u IGdldHRpbmcgdGhlIHJlYWwgdWFydCBkcml2ZXIgd29ya2luZyBhbG9uZyB3aXRoIHJlYWwNCnBy aW50ayAocmF0aGVyIHRoYW4gZm9jdXNpbmcgb24gZXhjZXB0aW9ucyB3aGljaCB3YXMgZ29pbmcg dG8gYmUgdGhlDQpuZXh0IHRhc2spLCBhbmQgd2UgY2FuIGRyb3Agc2JpX3B1dGNoYXIoKSBlbnRp cmVseS4NCg0KVGhvdWdodHM/DQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Fri Jan 06 17:24:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 17:24:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472830.733209 (Exim 4.92) (envelope-from ) id 1pDqS6-00079y-3E; Fri, 06 Jan 2023 17:24:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472830.733209; Fri, 06 Jan 2023 17:24:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDqS6-00079r-0W; Fri, 06 Jan 2023 17:24:22 +0000 Received: by outflank-mailman (input) for mailman id 472830; Fri, 06 Jan 2023 17:24:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDqS4-00079l-Bp for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 17:24:20 +0000 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [2607:f8b0:4864:20::62c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f38434da-8de6-11ed-91b6-6bf2151ebd3b; Fri, 06 Jan 2023 18:24:19 +0100 (CET) Received: by mail-pl1-x62c.google.com with SMTP id d15so2305571pls.6 for ; Fri, 06 Jan 2023 09:24:19 -0800 (PST) Received: from localhost (c-73-164-155-12.hsd1.wa.comcast.net. [73.164.155.12]) by smtp.gmail.com with ESMTPSA id e1-20020a170902784100b0017f74cab9eesm1198776pln.128.2023.01.06.09.24.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jan 2023 09:24:17 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f38434da-8de6-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=S2NFXzGo9zbhDvyYpgSdnlq0/2Qb+GtlNnT0u3EMLTM=; b=DiSL6l2MsSAryJG7j0Z37LD17gArmltOyGPinT3NjqJv7lftzxLhm9IZXzrJkYHUDI BtipZeoVabBIAJAejC1MghunCM6HY4RIpjybcgIjhhZk0hEyQGcxke5XgPvKgpN50WOW QwjHYG3CU7gNCevU8jDJS3w7o5diAj8UP8u54p6Y5sP2Cpx+mVfLBgqk+yRdWWRb/5ty 7NhWBQspkLacfubNTcOhegRsW2dpua7UpmDhM95Jqp1AF61AdjI06e9Sr/RTKf0mW2Gy bim3LBTTEsTWLMFQwf0M5I98KGza1Zq62zg9CQ4nkCs+vLs56M++PXc6NJb5cKN4lZxg 5sAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=S2NFXzGo9zbhDvyYpgSdnlq0/2Qb+GtlNnT0u3EMLTM=; b=U8PjYgyICUeEjwoB598hlf4Q9JbWeBLAFpooXKPMJ/6TA7FvimBSqYmyMdck1wZxzm /oTiiPr2QQjnaOGMJFVKYj63tR5dlUE5n8NTF0xy4K/oZU2xBR2jMpNO4stQIMlLFTA8 U5Vx0FW7PIDV+JyFFM8X4h7cTtCHmL9Uudkbd9Bo1vsJc/ML8xufgPzK1kNAnZxi4cBg 9us/npu4v7HlvzLxyPRZrO1cR4CAttvRZstVktwXI6KscO4caSO4mbwppc9wgR2u7qHr p/uz87jVd+vHnz2C3m9NuI0Lgmi71T4wTwVI7nCjfmChJ72V7TEj7c0dg/0OcYnsyN+G DL2Q== X-Gm-Message-State: AFqh2koqQPrJnukFeBZJL88bcPi8CKXaMhrUTSdHVH2VdvLjJzv90ipw w1nrvbPhYor8WquGKBEmvLk= X-Google-Smtp-Source: AMrXdXsj7xV3yYdlyIF55ed/UL9hxZ2u0HQTV+FoImGHqTzFNiUJDr/MsyFpLaVnRy4S08wcgY0y8g== X-Received: by 2002:a17:902:c643:b0:192:b6ca:200 with SMTP id s3-20020a170902c64300b00192b6ca0200mr22606994pls.3.1673025858004; Fri, 06 Jan 2023 09:24:18 -0800 (PST) Date: Tue, 20 Dec 2022 06:50:04 +0000 From: Bobby Eshleman To: Andrew Cooper Cc: Oleksii Kurochko , "xen-devel@lists.xenproject.org" , Stefano Stabellini , Gianluca Guida , Alistair Francis , Connor Davis Subject: Re: [PATCH v1 4/8] xen/riscv: introduce sbi call to putchar to console Message-ID: References: <09da5a3184242152af6af060720a007738a55d6e.1673009740.git.oleksii.kurochko@gmail.com> <320cc1b3-f03f-ad87-205f-d3c5db446f7d@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <320cc1b3-f03f-ad87-205f-d3c5db446f7d@citrix.com> On Fri, Jan 06, 2023 at 05:16:31PM +0000, Andrew Cooper wrote: > On 20/12/2022 6:23 am, Bobby Eshleman wrote: > > On Fri, Jan 06, 2023 at 03:14:25PM +0200, Oleksii Kurochko wrote: > >> The patch introduce sbi_putchar() SBI call which is necessary > >> to implement initial early_printk > >> > > I think that it might be wise to start off with an alternative to > > sbi_putchar() since it is already planned for deprecation. I realize > > that this will require rework, but it is almost guaranteed that > > early_printk() will break on future SBI implementations if using this > > SBI call. IIRC, Xen/ARM's early printk looked like a reasonable analogy > > for how it could work on RISC-V, IMHO. > > Hmm, we're using it as a stopgap right now in CI so we can break > "upstream RISC-V support" into manageable chunks. > > So perhaps we want to forgo plumbing sbi_putchar() into early_printk() > (to avoid giving the impression that this will stay around in the > future) and use sbi_putchar() directly for the hello world print. > > Next, we focus on getting the real uart driver working along with real > printk (rather than focusing on exceptions which was going to be the > next task), and we can drop sbi_putchar() entirely. > > Thoughts? > > ~Andrew That sounds like a reasonable approach to me. Best, Bobby From xen-devel-bounces@lists.xenproject.org Fri Jan 06 17:35:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 17:35:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472837.733221 (Exim 4.92) (envelope-from ) id 1pDqd5-0000DB-4N; Fri, 06 Jan 2023 17:35:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472837.733221; Fri, 06 Jan 2023 17:35:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDqd5-0000D4-1S; Fri, 06 Jan 2023 17:35:43 +0000 Received: by outflank-mailman (input) for mailman id 472837; Fri, 06 Jan 2023 17:35:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDqd1-0000Cy-K3 for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 17:35:41 +0000 Received: from casper.infradead.org (casper.infradead.org [2001:8b0:10b:1236::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 86f42156-8de8-11ed-91b6-6bf2151ebd3b; Fri, 06 Jan 2023 18:35:38 +0100 (CET) Received: from [2001:8b0:10b:5::bb3] (helo=u3832b3a9db3152.infradead.org) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pDqct-00HMLI-DX; Fri, 06 Jan 2023 17:35:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 86f42156-8de8-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=MIME-Version:Content-Type:References: In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=j5SJjOVUWB6bIzEcIGazxSgaPhnqoJFI6j1SWoTN3y0=; b=eLneMP0+lyMm7EmYyw8wlZhQij nOzOoIcwVYy/a4kyBXMQ4Y2XzSwmxE8uorOKLivjNneYDuJLGOiqA/Di32Qlj9dP77EY/cjSg/yim 3LgxAXqM4XA1lRdX/aCPKM74JUduIRgAwfQF6aZNVKPleRtG/PdMhRhLQfpx0pkohPaPKSCcdqwsH Q9TxkfDIgT8sl42HW2yXtiVlxHXjThdIBy9JU8f3upn48TO6iuLQUH8J6aetTIDDG+Tt7zTpsbp/g hU9acEpR/g8ouV9xDYk+g04QITRBiOIJPxPetqRxMX5C3Fl8WwPyCaErM8Nkoln1zQIJ2aSa4JhOn DLvSxipw==; Message-ID: Subject: Re: [PATCH v2 3/6] hw/isa/piix: Wire up Xen PCI IRQ handling outside of PIIX3 From: David Woodhouse To: Bernhard Beschow , qemu-devel@nongnu.org Cc: Richard Henderson , Stefano Stabellini , xen-devel@lists.xenproject.org, =?ISO-8859-1?Q?Herv=E9?= Poussineau , Aurelien Jarno , Paul Durrant , Marcel Apfelbaum , Anthony Perard , "Michael S. Tsirkin" , Paolo Bonzini , Eduardo Habkost , Philippe =?ISO-8859-1?Q?Mathieu-Daud=E9?= , Chuck Zmudzinski Date: Fri, 06 Jan 2023 17:35:18 +0000 In-Reply-To: <20230104144437.27479-4-shentey@gmail.com> References: <20230104144437.27479-1-shentey@gmail.com> <20230104144437.27479-4-shentey@gmail.com> Content-Type: multipart/signed; micalg="sha-256"; protocol="application/pkcs7-signature"; boundary="=-1GDoUcmA+YFZPkTfypSI" User-Agent: Evolution 3.44.4-0ubuntu1 MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html --=-1GDoUcmA+YFZPkTfypSI Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2023-01-04 at 15:44 +0100, Bernhard Beschow wrote: > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (xen_enabled()) { Could this perhaps be if (xen_mode !=3D XEN_DISABLED) once we merge the Xen-on-KVM series? --=-1GDoUcmA+YFZPkTfypSI Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Disposition: attachment; filename="smime.p7s" Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCCEkQw ggYQMIID+KADAgECAhBNlCwQ1DvglAnFgS06KwZPMA0GCSqGSIb3DQEBDAUAMIGIMQswCQYDVQQG EwJVUzETMBEGA1UECBMKTmV3IEplcnNleTEUMBIGA1UEBxMLSmVyc2V5IENpdHkxHjAcBgNVBAoT FVRoZSBVU0VSVFJVU1QgTmV0d29yazEuMCwGA1UEAxMlVVNFUlRydXN0IFJTQSBDZXJ0aWZpY2F0 aW9uIEF1dGhvcml0eTAeFw0xODExMDIwMDAwMDBaFw0zMDEyMzEyMzU5NTlaMIGWMQswCQYDVQQG EwJHQjEbMBkGA1UECBMSR3JlYXRlciBNYW5jaGVzdGVyMRAwDgYDVQQHEwdTYWxmb3JkMRgwFgYD VQQKEw9TZWN0aWdvIExpbWl0ZWQxPjA8BgNVBAMTNVNlY3RpZ28gUlNBIENsaWVudCBBdXRoZW50 aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKC AQEAyjztlApB/975Rrno1jvm2pK/KxBOqhq8gr2+JhwpKirSzZxQgT9tlC7zl6hn1fXjSo5MqXUf ItMltrMaXqcESJuK8dtK56NCSrq4iDKaKq9NxOXFmqXX2zN8HHGjQ2b2Xv0v1L5Nk1MQPKA19xeW QcpGEGFUUd0kN+oHox+L9aV1rjfNiCj3bJk6kJaOPabPi2503nn/ITX5e8WfPnGw4VuZ79Khj1YB rf24k5Ee1sLTHsLtpiK9OjG4iQRBdq6Z/TlVx/hGAez5h36bBJMxqdHLpdwIUkTqT8se3ed0PewD ch/8kHPo5fZl5u1B0ecpq/sDN/5sCG52Ds+QU5O5EwIDAQABo4IBZDCCAWAwHwYDVR0jBBgwFoAU U3m/WqorSs9UgOHYm8Cd8rIDZsswHQYDVR0OBBYEFAnA8vwL2pTbX/4r36iZQs/J4K0AMA4GA1Ud DwEB/wQEAwIBhjASBgNVHRMBAf8ECDAGAQH/AgEAMB0GA1UdJQQWMBQGCCsGAQUFBwMCBggrBgEF BQcDBDARBgNVHSAECjAIMAYGBFUdIAAwUAYDVR0fBEkwRzBFoEOgQYY/aHR0cDovL2NybC51c2Vy dHJ1c3QuY29tL1VTRVJUcnVzdFJTQUNlcnRpZmljYXRpb25BdXRob3JpdHkuY3JsMHYGCCsGAQUF BwEBBGowaDA/BggrBgEFBQcwAoYzaHR0cDovL2NydC51c2VydHJ1c3QuY29tL1VTRVJUcnVzdFJT QUFkZFRydXN0Q0EuY3J0MCUGCCsGAQUFBzABhhlodHRwOi8vb2NzcC51c2VydHJ1c3QuY29tMA0G CSqGSIb3DQEBDAUAA4ICAQBBRHUAqznCFfXejpVtMnFojADdF9d6HBA4kMjjsb0XMZHztuOCtKF+ xswhh2GqkW5JQrM8zVlU+A2VP72Ky2nlRA1GwmIPgou74TZ/XTarHG8zdMSgaDrkVYzz1g3nIVO9 IHk96VwsacIvBF8JfqIs+8aWH2PfSUrNxP6Ys7U0sZYx4rXD6+cqFq/ZW5BUfClN/rhk2ddQXyn7 kkmka2RQb9d90nmNHdgKrwfQ49mQ2hWQNDkJJIXwKjYA6VUR/fZUFeCUisdDe/0ABLTI+jheXUV1 eoYV7lNwNBKpeHdNuO6Aacb533JlfeUHxvBz9OfYWUiXu09sMAviM11Q0DuMZ5760CdO2VnpsXP4 KxaYIhvqPqUMWqRdWyn7crItNkZeroXaecG03i3mM7dkiPaCkgocBg0EBYsbZDZ8bsG3a08LwEsL 1Ygz3SBsyECa0waq4hOf/Z85F2w2ZpXfP+w8q4ifwO90SGZZV+HR/Jh6rEaVPDRF/CEGVqR1hiuQ OZ1YL5ezMTX0ZSLwrymUE0pwi/KDaiYB15uswgeIAcA6JzPFf9pLkAFFWs1QNyN++niFhsM47qod x/PL+5jR87myx5uYdBEQkkDc+lKB1Wct6ucXqm2EmsaQ0M95QjTmy+rDWjkDYdw3Ms6mSWE3Bn7i 5ZgtwCLXgAIe5W8mybM2JzCCBhQwggT8oAMCAQICEQDGvhmWZ0DEAx0oURL6O6l+MA0GCSqGSIb3 DQEBCwUAMIGWMQswCQYDVQQGEwJHQjEbMBkGA1UECBMSR3JlYXRlciBNYW5jaGVzdGVyMRAwDgYD VQQHEwdTYWxmb3JkMRgwFgYDVQQKEw9TZWN0aWdvIExpbWl0ZWQxPjA8BgNVBAMTNVNlY3RpZ28g UlNBIENsaWVudCBBdXRoZW50aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBMB4XDTIyMDEwNzAw MDAwMFoXDTI1MDEwNjIzNTk1OVowJDEiMCAGCSqGSIb3DQEJARYTZHdtdzJAaW5mcmFkZWFkLm9y ZzCCAiIwDQYJKoZIhvcNAQEBBQADggIPADCCAgoCggIBALQ3GpC2bomUqk+91wLYBzDMcCj5C9m6 oZaHwvmIdXftOgTbCJXADo6G9T7BBAebw2JV38EINgKpy/ZHh7htyAkWYVoFsFPrwHounto8xTsy SSePMiPlmIdQ10BcVSXMUJ3Juu16GlWOnAMJY2oYfEzmE7uT9YgcBqKCo65pTFmOnR/VVbjJk4K2 xE34GC2nAdUQkPFuyaFisicc6HRMOYXPuF0DuwITEKnjxgNjP+qDrh0db7PAjO1D4d5ftfrsf+kd RR4gKVGSk8Tz2WwvtLAroJM4nXjNPIBJNT4w/FWWc/5qPHJy2U+eITZ5LLE5s45mX2oPFknWqxBo bQZ8a9dsZ3dSPZBvE9ZrmtFLrVrN4eo1jsXgAp1+p7bkfqd3BgBEmfsYWlBXO8rVXfvPgLs32VdV NZxb/CDWPqBsiYv0Hv3HPsz07j5b+/cVoWqyHDKzkaVbxfq/7auNVRmPB3v5SWEsH8xi4Bez2V9U KxfYCnqsjp8RaC2/khxKt0A552Eaxnz/4ly/2C7wkwTQnBmdlFYhAflWKQ03Ufiu8t3iBE3VJbc2 5oMrglj7TRZrmKq3CkbFnX0fyulB+kHimrt6PIWn7kgyl9aelIl6vtbhMA+l0nfrsORMa4kobqQ5 C5rveVgmcIad67EDa+UqEKy/GltUwlSh6xy+TrK1tzDvAgMBAAGjggHMMIIByDAfBgNVHSMEGDAW gBQJwPL8C9qU21/+K9+omULPyeCtADAdBgNVHQ4EFgQUzMeDMcimo0oz8o1R1Nver3ZVpSkwDgYD VR0PAQH/BAQDAgWgMAwGA1UdEwEB/wQCMAAwHQYDVR0lBBYwFAYIKwYBBQUHAwQGCCsGAQUFBwMC MEAGA1UdIAQ5MDcwNQYMKwYBBAGyMQECAQEBMCUwIwYIKwYBBQUHAgEWF2h0dHBzOi8vc2VjdGln by5jb20vQ1BTMFoGA1UdHwRTMFEwT6BNoEuGSWh0dHA6Ly9jcmwuc2VjdGlnby5jb20vU2VjdGln b1JTQUNsaWVudEF1dGhlbnRpY2F0aW9uYW5kU2VjdXJlRW1haWxDQS5jcmwwgYoGCCsGAQUFBwEB BH4wfDBVBggrBgEFBQcwAoZJaHR0cDovL2NydC5zZWN0aWdvLmNvbS9TZWN0aWdvUlNBQ2xpZW50 QXV0aGVudGljYXRpb25hbmRTZWN1cmVFbWFpbENBLmNydDAjBggrBgEFBQcwAYYXaHR0cDovL29j c3Auc2VjdGlnby5jb20wHgYDVR0RBBcwFYETZHdtdzJAaW5mcmFkZWFkLm9yZzANBgkqhkiG9w0B AQsFAAOCAQEAyW6MUir5dm495teKqAQjDJwuFCi35h4xgnQvQ/fzPXmtR9t54rpmI2TfyvcKgOXp qa7BGXNFfh1JsqexVkIqZP9uWB2J+uVMD+XZEs/KYNNX2PvIlSPrzIB4Z2wyIGQpaPLlYflrrVFK v9CjT2zdqvy2maK7HKOQRt3BiJbVG5lRiwbbygldcALEV9ChWFfgSXvrWDZspnU3Gjw/rMHrGnql Htlyebp3pf3fSS9kzQ1FVtVIDrL6eqhTwJxe+pXSMMqFiN0whpBtXdyDjzBtQTaZJ7zTT/vlehc/ tDuqZwGHm/YJy883Ll+GP3NvOkgaRGWEuYWJJ6hFCkXYjyR9IzCCBhQwggT8oAMCAQICEQDGvhmW Z0DEAx0oURL6O6l+MA0GCSqGSIb3DQEBCwUAMIGWMQswCQYDVQQGEwJHQjEbMBkGA1UECBMSR3Jl YXRlciBNYW5jaGVzdGVyMRAwDgYDVQQHEwdTYWxmb3JkMRgwFgYDVQQKEw9TZWN0aWdvIExpbWl0 ZWQxPjA8BgNVBAMTNVNlY3RpZ28gUlNBIENsaWVudCBBdXRoZW50aWNhdGlvbiBhbmQgU2VjdXJl IEVtYWlsIENBMB4XDTIyMDEwNzAwMDAwMFoXDTI1MDEwNjIzNTk1OVowJDEiMCAGCSqGSIb3DQEJ ARYTZHdtdzJAaW5mcmFkZWFkLm9yZzCCAiIwDQYJKoZIhvcNAQEBBQADggIPADCCAgoCggIBALQ3 GpC2bomUqk+91wLYBzDMcCj5C9m6oZaHwvmIdXftOgTbCJXADo6G9T7BBAebw2JV38EINgKpy/ZH h7htyAkWYVoFsFPrwHounto8xTsySSePMiPlmIdQ10BcVSXMUJ3Juu16GlWOnAMJY2oYfEzmE7uT 9YgcBqKCo65pTFmOnR/VVbjJk4K2xE34GC2nAdUQkPFuyaFisicc6HRMOYXPuF0DuwITEKnjxgNj P+qDrh0db7PAjO1D4d5ftfrsf+kdRR4gKVGSk8Tz2WwvtLAroJM4nXjNPIBJNT4w/FWWc/5qPHJy 2U+eITZ5LLE5s45mX2oPFknWqxBobQZ8a9dsZ3dSPZBvE9ZrmtFLrVrN4eo1jsXgAp1+p7bkfqd3 BgBEmfsYWlBXO8rVXfvPgLs32VdVNZxb/CDWPqBsiYv0Hv3HPsz07j5b+/cVoWqyHDKzkaVbxfq/ 7auNVRmPB3v5SWEsH8xi4Bez2V9UKxfYCnqsjp8RaC2/khxKt0A552Eaxnz/4ly/2C7wkwTQnBmd lFYhAflWKQ03Ufiu8t3iBE3VJbc25oMrglj7TRZrmKq3CkbFnX0fyulB+kHimrt6PIWn7kgyl9ae lIl6vtbhMA+l0nfrsORMa4kobqQ5C5rveVgmcIad67EDa+UqEKy/GltUwlSh6xy+TrK1tzDvAgMB AAGjggHMMIIByDAfBgNVHSMEGDAWgBQJwPL8C9qU21/+K9+omULPyeCtADAdBgNVHQ4EFgQUzMeD Mcimo0oz8o1R1Nver3ZVpSkwDgYDVR0PAQH/BAQDAgWgMAwGA1UdEwEB/wQCMAAwHQYDVR0lBBYw FAYIKwYBBQUHAwQGCCsGAQUFBwMCMEAGA1UdIAQ5MDcwNQYMKwYBBAGyMQECAQEBMCUwIwYIKwYB BQUHAgEWF2h0dHBzOi8vc2VjdGlnby5jb20vQ1BTMFoGA1UdHwRTMFEwT6BNoEuGSWh0dHA6Ly9j cmwuc2VjdGlnby5jb20vU2VjdGlnb1JTQUNsaWVudEF1dGhlbnRpY2F0aW9uYW5kU2VjdXJlRW1h aWxDQS5jcmwwgYoGCCsGAQUFBwEBBH4wfDBVBggrBgEFBQcwAoZJaHR0cDovL2NydC5zZWN0aWdv LmNvbS9TZWN0aWdvUlNBQ2xpZW50QXV0aGVudGljYXRpb25hbmRTZWN1cmVFbWFpbENBLmNydDAj BggrBgEFBQcwAYYXaHR0cDovL29jc3Auc2VjdGlnby5jb20wHgYDVR0RBBcwFYETZHdtdzJAaW5m cmFkZWFkLm9yZzANBgkqhkiG9w0BAQsFAAOCAQEAyW6MUir5dm495teKqAQjDJwuFCi35h4xgnQv Q/fzPXmtR9t54rpmI2TfyvcKgOXpqa7BGXNFfh1JsqexVkIqZP9uWB2J+uVMD+XZEs/KYNNX2PvI lSPrzIB4Z2wyIGQpaPLlYflrrVFKv9CjT2zdqvy2maK7HKOQRt3BiJbVG5lRiwbbygldcALEV9Ch WFfgSXvrWDZspnU3Gjw/rMHrGnqlHtlyebp3pf3fSS9kzQ1FVtVIDrL6eqhTwJxe+pXSMMqFiN0w hpBtXdyDjzBtQTaZJ7zTT/vlehc/tDuqZwGHm/YJy883Ll+GP3NvOkgaRGWEuYWJJ6hFCkXYjyR9 IzGCBMcwggTDAgEBMIGsMIGWMQswCQYDVQQGEwJHQjEbMBkGA1UECBMSR3JlYXRlciBNYW5jaGVz dGVyMRAwDgYDVQQHEwdTYWxmb3JkMRgwFgYDVQQKEw9TZWN0aWdvIExpbWl0ZWQxPjA8BgNVBAMT NVNlY3RpZ28gUlNBIENsaWVudCBBdXRoZW50aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBAhEA xr4ZlmdAxAMdKFES+jupfjANBglghkgBZQMEAgEFAKCCAeswGAYJKoZIhvcNAQkDMQsGCSqGSIb3 DQEHATAcBgkqhkiG9w0BCQUxDxcNMjMwMTA2MTczNTE4WjAvBgkqhkiG9w0BCQQxIgQg91B2jFp1 PMQtGaFyS4i9Up5i5gJoNToNZs0En054QjIwgb0GCSsGAQQBgjcQBDGBrzCBrDCBljELMAkGA1UE BhMCR0IxGzAZBgNVBAgTEkdyZWF0ZXIgTWFuY2hlc3RlcjEQMA4GA1UEBxMHU2FsZm9yZDEYMBYG A1UEChMPU2VjdGlnbyBMaW1pdGVkMT4wPAYDVQQDEzVTZWN0aWdvIFJTQSBDbGllbnQgQXV0aGVu dGljYXRpb24gYW5kIFNlY3VyZSBFbWFpbCBDQQIRAMa+GZZnQMQDHShREvo7qX4wgb8GCyqGSIb3 DQEJEAILMYGvoIGsMIGWMQswCQYDVQQGEwJHQjEbMBkGA1UECBMSR3JlYXRlciBNYW5jaGVzdGVy MRAwDgYDVQQHEwdTYWxmb3JkMRgwFgYDVQQKEw9TZWN0aWdvIExpbWl0ZWQxPjA8BgNVBAMTNVNl Y3RpZ28gUlNBIENsaWVudCBBdXRoZW50aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBAhEAxr4Z lmdAxAMdKFES+jupfjANBgkqhkiG9w0BAQEFAASCAgAXuoNJktsTX1LWKHjCdT9hwq9O8vm027u2 KKGDTtG+iZP2vdPw620FjeyjdMm8lcu8DPVxJK6Su8AgaMU7MK7QUdfyJuOXDjDYEJjIJIb92LQq DXzxxH2+Iy/yXz/ti8XiL/BpNfDtMrwbMg+u23XVsumO5mXmyyeSgpcWAmzpwdikgkh2jVc3khlS P1XOSz3BadQPWlm7K8h7Ttqk5fsqutmPn1+Sti2UUGCNoVXVa9RPWaNqdRu9voaYwcCGnmtAC+pW pDXGQjpQsib6n93mqvnAXXbzmi9/HSBPIp24dbP6l6OD6LxSF2EezyFWt/JvLXZxr2Bv3SfStgr8 5583QlbPrWA+feXpA33ylNy4TlZj3U0ZpcjeNUelpAh0Zlbthqd2x/oIKahn4ZuXCqBadTiFTJoI vePPKOuQ5QW0CTCXydMeyuFjhrcDtKnLqYObo6ZbSzZJPn921Wdb0Q08LGd/D4dXuT0P3/ZzAOf+ vH1WjQAaY2zIPDq2msbubNACCdcGzFNaYVAQABzFWVPYTq42XI2nawvjLScYLPAcqqXjZ3P44Bst Ot0Y6GQi3/9F2yAEzdAj7nFcdYKPVIoqBi7eFZVQlUEWZy8k4MMDCIw/yNE8ANIXlyEOAynLkDIf yyeeFihY2CvVVdb8aKZKfMDhQ+XD9fa/lfgXtliwygAAAAAAAA== --=-1GDoUcmA+YFZPkTfypSI-- From xen-devel-bounces@lists.xenproject.org Fri Jan 06 17:47:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 17:47:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472848.733240 (Exim 4.92) (envelope-from ) id 1pDqnx-0001qW-BW; Fri, 06 Jan 2023 17:46:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472848.733240; Fri, 06 Jan 2023 17:46:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDqnx-0001qO-84; Fri, 06 Jan 2023 17:46:57 +0000 Received: by outflank-mailman (input) for mailman id 472848; Fri, 06 Jan 2023 17:46:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDqnw-0001qI-Dy for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 17:46:56 +0000 Received: from sonic308-55.consmr.mail.gq1.yahoo.com (sonic308-55.consmr.mail.gq1.yahoo.com [98.137.68.31]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 19e360e7-8dea-11ed-b8d0-410ff93cb8f0; Fri, 06 Jan 2023 18:46:53 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic308.consmr.mail.gq1.yahoo.com with HTTP; Fri, 6 Jan 2023 17:46:50 +0000 Received: by hermes--production-bf1-5458f64d4-qthpt (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID abddd79a48058f79d1ffdd9f2f3866e9; Fri, 06 Jan 2023 17:46:45 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 19e360e7-8dea-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1673027210; bh=e/yuR16Te9FloniNuhJpbWJIR1Zp8hbWNdHK0VdfjsM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=sTq7fUsaVqnW1jpDYFOf3sgyWg2QJx9xgnlpXe+D9eVnbmEEi+/W/ZKjNh6wtVVn27n7ItlTh2pgoyTpyt5f1L+jBl9ncdfRNt+ljb71kvbY9C0tCroCr0wPcSGL4nEvRVOPUQMq+GhBXkR4ZfmXHouXNvCELOdPtp1cFPh8bCXsjuadMJNZQC+cZ/gRmO2aOMGIR9xIdNhJ/iEBgBl7vckp1zUL7GXZb4GMQrd3EsO/mJk69BOGOAUg3YaIZibynDgkwdNDPFA2woTQcORHKe4rkLZx4kCboOUa7no4W5tyRiS5qRdJ/g0mNp3ja5n1l9hmScQyhA3wzHEjdYDtVg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1673027210; bh=X1JckgDvtHLNYcDAfFF2eP/1ckxVrDQy9LCUKex4cZy=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=lkktQxlD3qmu6y5M2KgUC3WCfgrEvBkPBNPD2lE4aEcYETsQbotlYBTE0ehfoDlgTlKKtgn7pdK4hYil8D6SEzKEGe75TxKvuw9g1fR+hFWItTNwQZPgIM2Sj7vt/uMYzUBdPsVYH4Dzu3UvRKmiSwdLVwo3tXJmHgArDMsYsxyGZBp8KXBxpRu1zTEUQ114h83rhcVzAXYeQJzvx63sTIHszgmbhUx7fBFoapr4/tc5pnJKLKQlN4/3waMt1GxLcbId6o1GaKihlV2vlGbt8AcF9t5perS6C+MNEkpuCeeOg+Ad3ZTb0HHRkOygY9p8eCA6RLYe0gZoi/VyGrPYbw== X-YMail-OSG: 6X0GYxgVM1mDTxdl3ycRcmjH8SrRcUf1frDKKdnj0DaulY4.ExN8BjoBGNv5xYu 1sZpclq.cRAkBMUNvjVFO9kvymnAUXQgvBw5gc9IYZJnXsXQl5MOcftAJTb5Nb6aUs2UXNvDLBKH hcayIq3HXl2n_GcECF1T2qBC4yetb6qsXTGDKGl5x7EWndMZfv_x_jaW2jqXRdbD4Vi25b1XQa27 UPgVql6WNSy8M.3zLgk4_Iy4Q52ro6MuaO0BFo0riEBsVDd_8qibd0b0Fo.i6AqumD9lHFrOvdbn Fwm_IH3ru7R4E8xlZ2Y2jB.N.0h4zr8KGU91mU9BVbTsrsNQStHmjl3_A5KBVKmidCQKB_8HqRv_ jdw2yqm8ekfRQs_0ZW3aOH.33rgic7ntu8ENrN9U5iOuvlxPH5CcNMS.3JmF2nZ6YheRXVy5sZSx D..csbaXJLnJinLrFOSlzCjHAQ08vKFMZkjWZ8zqiaRMDm__2XSI26wrZ16MhbNm6eiEhNwRtx5e D047ZzCBav6hYZe2IKIlNA17FxDZS_O54VL3S1wP9GsOzAWrC7aHl4QMAPjG752.EQvPqKSv1fCB hjgCeACJkj1B92mBCtjdX2BFaSawFSEhcHgm2nJbL_HUuy0S_Rfl9b.Lvt_ZtRYADTjRVQXSieeb DsHT5nvZHdfmve6fOBO37RDhza8pN_KnCHLPcAP0D_DUhXkbey3WzZs.fCspBwNj3oSdZaTysLjB RkFHvfU1KM6Je.HCqiIahkYWLw0w6NRbM.g2MbaQQ.nIgBoqrZB83.3_5s0GgJZvDI2GrxIksgpP VjKi98vCgWhvcCPYjpakQb4LcDTA2ViMdvR7_WnAyvsLT5opM6JVnymRJWJElt0f8Lo0.jnBFtag T3F1QWYGKpc04x4O9ccWQRxNOJZWDx4sOuq8NPEGTSsrNJRmcittTrdgUYYaoqvlSC72MUMej6h_ YPn7Xz5eJxq8qWzzwp3jTJ.2oGsiZdrKRv2l.wqtvrFjk7A7b08Kv_7.wdkC0Auu3Ox277K6NV7T p4bIhE37SHOZfBEzE2sU0RmPJ.zotC1X2edpWbsSR_kI7.8xJq1A46SXdIvaThTqDPh5vmXHKXSW B8NcZvo8SiS_i0CpEB6zTxkL1LmaQQJGCzuzF8j1yEVrqA5eTlkv4_oxCkNb2gOv7xgfl31bwNRx 4C5q0xdwMCOoHBR1pY3PQHmQpE_xPPNCCyGZbtR02x7K0xNi2qaUbo0Y_2kXDot9XR5vsHQmWr4H ol.Tajp44XINGZqKlaL1VNJPTI0mEMNPOBz34mj8.d8ctkAe9ReJ2FJNWY076N80qEVVGzPzXp4M EpuMsFpvW.TfkaMLVHZgmXhBbyM1qfjWITrv2TbcL8gXgLcajH45MbH5uL7XaW7ITbTcfwUVyW2D g919FlXMY7n24ypVRv3cWDC2_rdCmA7YSNjIWJp2tpPCxRRGC2GoU0BPy81vgdvYjXXWML8uBHo0 I9HmgYdCkkfDD6PJiKUtPJZuDGwCBi7wO_Xs2nr0tRhZI62.64shVukxfdKpGToNnC4RdVPA4.Cv 7p6LWOO0s1I9cESqt.xO5aHupg7ATQuP6_zh1fqNhCWIOPR41QHoavbnO7SrELtx4izms4R4zxPD AKEVsWYYYbd0NrcW7RG57t4Eet4PcSS6W9rsLFfjvuI731pJ7nDUqvTCJ8A2zaTBKbyd82kATGoe 253TUeVA0z661P5WDkzEyJAD8qx2StVKEW.ZFi0padXZXbuVF7TO7Q34CyarzVLyLq3ghS_ZWkPR 60Rx5DbCv8RRQfumA7M7KF5YOGG1T_pRu0YedDEtKi8QDfvUtWmPNUpti1huIW6YNHaA.1lUO7em B_nci28BYlNfiTBNFaB2xZngGQMQbOhIcCBNEu9KOw4DxxplLF5tfVDgNQ_b0PBjOkvRjY3xzrpY ju6QxtXVLxc7NboV4VDEXYiM2wLU8y87Ta.ryVbjjDo2VUKxFmOBmrqXmDofQI9gKXm01u7e9JwQ o1KPxAWMi2GyeRdITq_o6nUP27jpFzoadZnz9C2F0nF54jHY1YbQ7eZ.51O61iqLm5IQ_W9hOFks n0l4lRp.RiznfeH9z4e85MMNAjKmKa8Zw7ELOFdRHZ_odQ78ofZlZcMsc.aA3YqoEDli.kDrv4pH jlsR0.oOdQ_4sMOIxb5mXGCbqjdhukrOzIoXXqyRUjCXq0ZF_Xdjia3E2kTFlJULrtGIxXqZyY0N 7h6rSfFOIODBCZwRFt5w- X-Sonic-MF: Message-ID: Date: Fri, 6 Jan 2023 12:46:42 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v2 3/6] hw/isa/piix: Wire up Xen PCI IRQ handling outside of PIIX3 Content-Language: en-US To: David Woodhouse , Bernhard Beschow , qemu-devel@nongnu.org Cc: Richard Henderson , Stefano Stabellini , xen-devel@lists.xenproject.org, =?UTF-8?Q?Herv=c3=a9_Poussineau?= , Aurelien Jarno , Paul Durrant , Marcel Apfelbaum , Anthony Perard , "Michael S. Tsirkin" , Paolo Bonzini , Eduardo Habkost , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= References: <20230104144437.27479-1-shentey@gmail.com> <20230104144437.27479-4-shentey@gmail.com> From: Chuck Zmudzinski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.20982 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 428 On 1/6/23 12:35 PM, David Woodhouse wrote: > On Wed, 2023-01-04 at 15:44 +0100, Bernhard Beschow wrote: >> +        if (xen_enabled()) { > > Could this perhaps be if (xen_mode != XEN_DISABLED) once we merge the > Xen-on-KVM series? I am not an expert and just on here as a user/tester, but I think it would depend on whether or not the Xen-on-KVM mode uses Xen PCI IRQ handling or Linux/KVM PCI IRQ handling. Chuck From xen-devel-bounces@lists.xenproject.org Fri Jan 06 17:48:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 17:48:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472855.733251 (Exim 4.92) (envelope-from ) id 1pDqpp-0002QK-NK; Fri, 06 Jan 2023 17:48:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472855.733251; Fri, 06 Jan 2023 17:48:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDqpp-0002QD-KL; Fri, 06 Jan 2023 17:48:53 +0000 Received: by outflank-mailman (input) for mailman id 472855; Fri, 06 Jan 2023 17:48:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDqpo-0002Q1-GL; Fri, 06 Jan 2023 17:48:52 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDqpo-00062i-E6; Fri, 06 Jan 2023 17:48:52 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDqpn-0000Zl-Va; Fri, 06 Jan 2023 17:48:52 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pDqpn-0007Un-Ux; Fri, 06 Jan 2023 17:48:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Gtvfw6gDyHV+Mth32Vij04ibsiLuak7DdxstQZ1PlBI=; b=6cWqNQBxJZTPH+XxJda2D644mk 3yuSkUTPvXi8LopwSJnpJ5vp6RDKa7AgwYTNvy4bS909dotr+684E0a7/bqxlXcJ79YfsavHUjYgz mWSsqdXFZlBhJv1mvLi1rmpEjWaPKsdmMMRCK00G9XONvZq5JO+tsVnbAuXkgKSsdKzg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 175601: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=2b21cbbb339fb14414f357a6683b1df74c36fda2 X-Osstest-Versions-That: xen=671f50ffab3329c5497208da89620322b9721a77 From: osstest service owner Date: Fri, 06 Jan 2023 17:48:51 +0000 flight 175601 xen-unstable real [real] flight 175607 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/175601/ http://logs.test-lab.xenproject.org/osstest/logs/175607/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 175607-retest test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail pass in 175607-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 175592 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175592 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 175592 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175592 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175592 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 175592 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 175592 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 175592 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 175592 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 175592 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175592 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 175592 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen 2b21cbbb339fb14414f357a6683b1df74c36fda2 baseline version: xen 671f50ffab3329c5497208da89620322b9721a77 Last test of basis 175592 2023-01-05 19:38:50 Z 0 days Testing same since 175601 2023-01-06 08:40:09 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alistair Francis Oleksii Kurochko jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 671f50ffab..2b21cbbb33 2b21cbbb339fb14414f357a6683b1df74c36fda2 -> master From xen-devel-bounces@lists.xenproject.org Fri Jan 06 18:22:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 18:22:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472864.733262 (Exim 4.92) (envelope-from ) id 1pDrM0-0006ek-96; Fri, 06 Jan 2023 18:22:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472864.733262; Fri, 06 Jan 2023 18:22:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDrM0-0006ed-5n; Fri, 06 Jan 2023 18:22:08 +0000 Received: by outflank-mailman (input) for mailman id 472864; Fri, 06 Jan 2023 18:22:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDrLy-0006eX-AK for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 18:22:06 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 030f4c88-8def-11ed-91b6-6bf2151ebd3b; Fri, 06 Jan 2023 19:22:03 +0100 (CET) Received: from mail-dm3nam02lp2046.outbound.protection.outlook.com (HELO NAM02-DM3-obe.outbound.protection.outlook.com) ([104.47.56.46]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 06 Jan 2023 13:21:52 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CH0PR03MB6019.namprd03.prod.outlook.com (2603:10b6:610:be::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Fri, 6 Jan 2023 18:21:45 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5944.019; Fri, 6 Jan 2023 18:21:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 030f4c88-8def-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1673029323; h=from:to:subject:date:message-id:content-id: content-transfer-encoding:mime-version; bh=OkfaNdfhnQi+sNg+lseArwfD8y8L6hRJ8ngS8xkww8A=; b=ZQKeohnOsh4rhgfDcbjF3TE9bmwVYdAF0pbtCjiLpWV1sxttgSUY3lQ9 tbJ1+EYpuz66YjrEBm6ALn/OWf+vNZ5/f/VwXh/T3ZM7kcR7xwqhO7P1I rrs4MvkW8Z6gmW8wTnshHJ11jSPQ4kH0F+r5G5jh1b7Gs2ey8xgdX0yNR U=; X-IronPort-RemoteIP: 104.47.56.46 X-IronPort-MID: 90999364 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:TiA9BaNdVfBXDwvvrR26lsFynXyQoLVcMsEvi/4bfWQNrUon1DYOm 2AZW2yFbKuCYGX9L9x3YI7i9xhUscLVy95iGwto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQA+KmU4YoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvzrRC9H5qyo42tB5gJmPpingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0v95XjBR2 PkTFBNOazuEnbiLz/HhT8A506zPLOGzVG8ekldJ6GmDSNoDGtXESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+PRxvza7IA9ZidABNPL8fNCQSNoTtUGfv m/cpEzyAw0ANczZwj2Amp6prr6XzHKqA9xOfFG+3qJykEfK51chMU0bVFa+iMaiiXCBSt0Kf iT4/QJr98De7neDXtT7GhG1vnOAlhodQMZLVf037hmXzajZ6BrfAXILJhZDYtE7sM49RRQxy 0SE2djuAFRSXKa9THuc8vKYqGi0MC1Nd2saP3dYE00C/sXpp5w1glTXVNF/HaWpj9rzXzbt3 zSNqyt4jLIW5SIW65iGEZn8q2rEjvD0osQdv207gkrNAttFWbOY IronPort-HdrOrdr: A9a23:tH2Eb6peOvEG5oUjPzT5SEIaV5oReYIsimQD101hICG9Ffb1qy nOppsmPHrP4wr5N0tPpTntAsi9qBHnhP1ICPgqXYtKNTOO0AHEEGgI1/qB/9SPIVyYysdtkY tmbqhiGJnRIDFB/KDHCdCDYrMdKQ+8gcSVuds= X-IronPort-AV: E=Sophos;i="5.96,306,1665460800"; d="scan'208";a="90999364" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lbWwwx+e9dhWZLXk1fryigzUFjERC1fbNrlwnUY3Yqdf1I2ajDLwmbUHkWr8Roht9T3kgIzyoi3UsENbkYlE5BvzBcJHKjMbaE1o7sv5p0LpsrZTxLSyYyiN20GG3kXe0WySD2Vd7Mr7BWVvrwZmQL5+bGjKDasH12RqpWjUTgWl7B/EupuriVWi5wLIKly8IK3Y4vaPB3kOWL7lrAEmpmkEi0O+kAOY+PzEVyc2D9WBKp8J90zQmnRbMmquaT8OM88Xql+EKOEc94EzDgSkAhUYXPhTVcep1j5G8PPT4KckEmYebdO5QTRH1u1EEa/jbE+wH9vSNxhecfi3dsAivg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OkfaNdfhnQi+sNg+lseArwfD8y8L6hRJ8ngS8xkww8A=; b=SHLnlE6ijQEy4HEV8TPXTPF508EsFgj8+FZsow/QnChSXSOMvC8ozWyQmadhWtJbrPU1q58lM2/yNjYQeuQvyTZAokAKEqQ4aeu3pYqwe2UfUgOESDM6BPH9d/B2X7kmqo+833UJeN1iu0c6jr5Yo4eSJ56sP3BmaFeVEhCauz2k7TZFvXhYFxa5QyblXCKUvSXmTyv88I9lk6zLB1LjGNHzcJECba1o76ISMi8BNdTp8f975DO3lX8hSsdONNi3mugePLZ37sbcNvE8/+lynMYVbb1K1teb99hAbUlxTv7lpIkVAKIROn9FkrpMbceS9LWw+vY7254KL8yDpbdDwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OkfaNdfhnQi+sNg+lseArwfD8y8L6hRJ8ngS8xkww8A=; b=gW0pKr+JTNCBZGNSV9GtO8lCbKS5mwkTme6+KMayNm6FJviLWprm6VOgZsGJNVB966Qv5QD7S6kBPAAseIUd35fSIDlkmgsT1aRcUJ+EbA4WZ/JUeOTMx/W6mgfYmRJD/NKptI1pCOPX6Hmo7xUDlJEX7ZqSpmQrMoK2a+HjENs= From: Andrew Cooper To: xen-devel , Jan Beulich , Roger Pau Monne Subject: LBR and Sapphire Rapids Thread-Topic: LBR and Sapphire Rapids Thread-Index: AQHZIfu71M1ca5PaBU6iVuTRvRgdgw== Date: Fri, 6 Jan 2023 18:21:45 +0000 Message-ID: <3a80b974-1ddd-2063-863f-8aff3453d545@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|CH0PR03MB6019:EE_ x-ms-office365-filtering-correlation-id: 87524891-defb-4ddb-ba05-08daf012de56 x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: iXpDIV98Qe/JxHdEYt1IqqPPqKdSTmcn9/BVvzqfTWmo+o7i5BN8sD9hV32yu90fLTfw74fzcJDPd84jFCM1BWHWtutf5q/AzM5DxuvcPtK1PjpYaFE5llu8951PuexkhjA/LsE2hoAU6HNKm7Borw/NOcdIAQWsman1sHB8CPUamBwKeZzt1AYgteEiEcVJ3gDExkhsM0tMV360IARlgx/jasRIbrMkBPNSR6cn/Wk5iG/udN2DEU1JILMR1w8+7k6/HrBwOpBDCsIjUUHRYORQ2OflDHCwOMCIPb9xA6rukx6ZhCW1wvehA/BfUoL+hO3pyFwisMdi3LfQcO9smM6MRYI7ZIwxjgnWuZ/vY2c2LZTK5K+25tUFvMXamKthtVb0w6AUbYq6Rqsc9GdAUyuc7Z8MIitnbGvbTi9MzZEAko+5Zasokg+LiwUGiDOwjAx+Xc2FZ0KqtQwCj/p4DxiJUCAqrRs2QYnC7FBvpfDBXfeQup6xMPlm1xvH4lCO09GW+VQaJ2BYK1esyAWTSqw11yi5bg1+LguEHzAGm3ITUtNz/ItmMt8ENby8mN4o/29s767OhQ9iR8Zr6g0lY3A0h7agepfXmBtBqZWHkH1d5jaKHB2YI6ptf2I9fDCr110Mrg8G14cV5Gu2FvSde1NkpLHhrEHybqEX4O+a5KQalgFAHLSaOIX/OxIhSE6A3yM1BJr8JXlDZlpLzLdkG1uKRZxT3Wd58CUqIvSOsrNtk4PgyeZNjZpoFdN+I6I0dp6EKpIzPh6KTgLCCl+rfw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(366004)(396003)(136003)(376002)(346002)(451199015)(66446008)(66556008)(76116006)(82960400001)(2616005)(66476007)(64756008)(8676002)(36756003)(41300700001)(38070700005)(91956017)(6636002)(66946007)(316002)(31696002)(2906002)(110136005)(3480700007)(38100700002)(86362001)(5660300002)(122000001)(83380400001)(6486002)(8936002)(6506007)(478600001)(26005)(186003)(6512007)(71200400001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?cUg0S2gwV1FhcDRaalJIbGxLZTYrWWFLSndnaklWWlN0cTA2bmd4b1gzK2FP?= =?utf-8?B?QkZpdHF1QkptY1lEZzlCcnI0WENMSW5WUHcwbkJGbURqZk9TN3pTcHN5WXcy?= =?utf-8?B?QU1YbGlHY2NFSkhwTVk5aWtvTG41cW45cUdWeG1sdit5VUs1ZFp5VmFxUS81?= =?utf-8?B?ZXFZQlRFcWx6cTd1TTRKRDVmMnRleEtGaThZR2RSN3pKTi92VDBqT0pFVHpi?= =?utf-8?B?ckNZb3VaOWVQVVdQNFgxamsvUEIyZHZ4NWg2ZW1NNkwzTmExS0NHT3Fvd3R1?= =?utf-8?B?QmQybHNDUGhuaENVbXI0Mm1RTGJlOCtUZUI3TDVITEl6aXJnTWhEZDM5Rjlt?= =?utf-8?B?cGkrZGdXd1pFK2hOTUw1bndWMkc0YnN3elNLRjF5Uy9qZFd0S0JmaHVqTG1q?= =?utf-8?B?SnRFQUlWM1Evcis0ak5iV044QjJOOUdCVlpnTlJLZTNFaFdtSWlXcDEwd2RQ?= =?utf-8?B?QzNaZHBLVjVIVnZGV1J3WkZGNTFpbThDdkFyUVRJVGZ2UXdZN1VVZk5HYUoy?= =?utf-8?B?c2RhVGYvRVVBVEoxUnAwTzhFeHAzQVNYNVR3OER6blpySmkwVjFwV2pMTVBs?= =?utf-8?B?MmdpaG04czg0eC80TkZMNUxhM21TUFVoei94S3gxZ2VvYjUxOVZxRDJBbVRR?= =?utf-8?B?ZTQwSzB1M0VtSXp5NFJuSlN4VGZoU0pFY3IxMm02eXV2RWovVHJkenVnQWRY?= =?utf-8?B?MUNPZE5VQjkzMXJoYVVsQTdwU0l6b3gxekdkT3RESE5nNjkxNUJnSUNwa05F?= =?utf-8?B?TzBBT1FHdTNtajgrTEpZakNOaTJGeEZMcGJ0ZUF0UFJKelJEbzZ0R0lucFRa?= =?utf-8?B?ZjA2MHlBYml5NmNYR3Zyb3NCZjVvR1JGaU9ZVXFZZ1o4U1N0U1pWZHozZXFB?= =?utf-8?B?UzhoM0tSb0ZubGM4T3Bnang5alFwRkNXV25JK0h2TlV4RytZdDNBbCs1M053?= =?utf-8?B?K2ErNEt5aGdMMHhJUkl4OTlIWHNNc0VYWldhQmN0MHRHS0M2cit0MkZJLzB6?= =?utf-8?B?a1ZnTzBFRkh2b2V1SjVNbHREeUYxZWNPblhTVS9hM0NMSTN2RlUxYUdNSXps?= =?utf-8?B?Sm5XaS9RcGVDNG12ZjBQbXhHYnh5QlJ4eXVIR2RFb2prRWY5NXEyUm5zQWdo?= =?utf-8?B?SXR0Wlc3WHNXVWhDTXF4UlJoOCt0SHVja0M0QldGcjF6OFZzbFZ4MDhLOHQr?= =?utf-8?B?TDVIZXN5YmJjZldyUzEwNVoyMW0xMGRHV1hMOUh5WElWb0ZBdmVWSE5lc0RX?= =?utf-8?B?dnE5S2xQWFZQNmdsczBUUElGcktUVzJDT3J2blp6QnhmTFdjZmJBaUNid0NY?= =?utf-8?B?d1lNeVptaDAxdU1uN0drdTJMUTM5UjA4MmlDVnFXellTL3FMc1NzalJkU1dS?= =?utf-8?B?RFBpRkkwY29FczFEaG96T0J1dTAzRkczZ1ZGaEVzY3RvOFhDNU1jeFFZUXBI?= =?utf-8?B?MmEzTTN0QlNBU2VuT3p4WDY2TlpRNFliYkJCcW4rUUd4QWpYdDFZTWY5UW8y?= =?utf-8?B?L3IzMTZYdWdhcFhUeEdYcnhvd0NvNllrWndKS0R3K1dlNm5lVmJKcGxOYlht?= =?utf-8?B?dEIvdzhQZVF0Q3NDRXNJS3RzVjVRMGVIRHNxVjN0RTJWZ0E3cytERGRGaDNi?= =?utf-8?B?Q05VY3lFdmtmSmhMQ3NMWkx2S1NKSkFTMEF6amVLakI2SXdZQUN3V00vdTVO?= =?utf-8?B?ZjVXVzNDNW9EU0o1elFrUWFTVVFiaFhRQndaRGVqbjB2UU8wd0N5akVtMFFy?= =?utf-8?B?K09vbHMxSWdoazFaTkZHTG4yWlJLZkxkditEdGtGOC9sUGpnSkFJY21HZUpV?= =?utf-8?B?YVR6OFpJYURLSGh6SkV0WTVDYW5TMEkzNWNiZXlPVk5UQUxWM1NpT09vY1h1?= =?utf-8?B?ZVl3eWY4N0tYbFBxN3pQRktWTW1LbGFWSnpKTTdFSm1OQ25XWi9hUDJ4ZTEw?= =?utf-8?B?NERmcm8rMXlkK1RDbWZldmNNbWo2RGZaTndEb2VGUm5PcWpubmxPVWFUODN4?= =?utf-8?B?aHFrUWRZajRpNkZsRm9PK2pmaE4vU0VaZm5SYzc2M3JVem5DMTRnWVJTVkpJ?= =?utf-8?B?S1pHckRXeVhJai9VQjBUWUNHRnJ0MEtXUStCbFFSRG9TNWxNdHkrTlM1UHRO?= =?utf-8?B?LzdpSWx0bFkzaXcwUXp2VVRNd3FqYnowUG1pUEFCN01oSlhORENWSE0yQ2M1?= =?utf-8?B?ckE9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <77325048A88F7B40B66F7C5B729569B1@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 5tmGb9AEwnUtuSp9xSnthnDoNbIJMA/t0RIOaIk89Q2qhuHBWe7s6EohYMQEEhe87gQgo6hE3JkkuMzlfW0/v9/cCqzng0d0NcxqQxGBm+ch75dbyGMwzQd22Vd+oxSt5l+SEkvJJA+KgQ5uWGB4vTMjjWBBF//C+xREsoyvC1+R9n6ZDD5bmaPg8UF8rlO/Dngz1vALJuw4diE8MQEVXvzzdIZN8TXVYPOQ1rTFZK7LKKRVmjLY2Fiw1GOFjOmcLofxH2d2oopXFwJKxCcuGCCKF1sQZi2cEQ/XD4Ck8bkA2dM3tGmfkP5CjRpYQ4zDk0ekWTRtF/ceW5YbHiQWZcKBMMdUgOJjiOT/slt687EYWF+Gr0yrRzQkOQj552d6j4HMpTxWBCKQMdINXfOBaADIGJeqOrE3E3H/5C6UT6yF84CrPxO0Ewn+OiCT2MiZogvGshc31sSOKp4VmIAaHCtIYDjebOS4Mv5F4JYq+kmY8znJ04komLVDoDzyRU06vkXDYUXD7vra/tZJjdGUsqe1NYfX0AX7X0xFLFOckxAcOrnSBnPFZKd+Dlh6hq2apy3jEC65y+PjKJpUQlS/BtzbFpg53HO3R/Xg6Pj1IH9kT0/1vf632H5BYkqjtC8n3B01j3QaJYZVMTHTks3OBfMJIYsU5dwbSCdKoqVQ5VOwXKGDFxGaUJy/jVUg/mcK29+M1dQJAEHOztXF0dV7BUOfeGiRanXGDRzl0m1EH1a3YpS9j9hiNzD/FxvwSmU0qYq1Jv5BgZnj2ZrxzWR283TFYP+y+VRC7TscDakxn9g= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 87524891-defb-4ddb-ba05-08daf012de56 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jan 2023 18:21:45.6337 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cg555sAKZk4jhGAPWoIAqlD607JNU5IsEuu81gpycHzK3W51975ioaonRSVD4L/xHATO0kJxIc9TvNexwX6iHhYRFdWjxz7ox1RzwbpNApU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR03MB6019 SGVsbG8sDQoNClRlc3RpbmcgaGFzIGlkZW50aWZpZWQgdGhhdCBWTXMgb24gU1BSIHN0aWxsIGNy YXNoIHdoZW4gdHJ5aW5nIHRvIHR1cm4NCm9uIExCUiwgYW5kIHRoaXMgaXMgaW1taW5lbnRseSBn b2luZyB0byBjZWFzZSBiZWluZyBhICJmdXR1cmUiIHByb2JsZW0uDQoNClRoZXJlIGlzIGEgc2Vy aWVzIG91dCBhYm91dCB0aGlzLCBidXQgdGhlcmUgaXMgc29tZSBnZW5lcmFsIGNvbmZ1c2lvbg0K Y3JlYXRpbmcgbWlzdGFrZXMsIHNvIEkgd2FudCB0byB0cnkgYW5kIGxheSB0aGluZ3Mgb3V0IGNv aGVyZW50bHkgaGVyZQ0KaW4gb25lIGdvLg0KDQpSaWdodCBub3cgKGZvciBJbnRlbCksIHRoZSBQ RENNIENQVUlEIGJpdCBpcyBoaWRkZW4sIEhWTSB3aWxsICNHUCBmb3INCnJlYWRzLCB3aGlsZSBQ ViBibGluZGx5IHJldHVybnMgMC4NCg0KVGhlIGZpcnN0IHRpbWUgYSB2Q1BVIHRyaWVzIHRvIGVu YWJsZSBNU1JfREJHX0NUUkwuTEJSLCB3ZSBlaXRoZXIgc2V0IHVwDQp0aGUgTVNSIGxvYWQvc2F2 ZSBsaXN0cyBmb3IgdGhlIExCUiBNU1JzLCBhbmQgZGUtaW50ZXJjZXB0IHRoZW0sIG9yIHdlDQpj cmFzaCB0aGUgVk0gaWYgd2UgY2FuJ3QgZmlndXJlIG91dCB3aGF0IHRvIGRvLg0KDQpMQlIgTVNS cyBhcmUgbmV2ZXIgcHJlc2VydmVkIG9uIG1pZ3JhdGUuwqAgQSBWTSB0aGF0IGlzIG1pZ3JhdGVk IHdpbGwgKGF0DQpiZXN0KSBvbmx5IHNlZSBjb3JydXB0aW9uIG9mIGl0cyBkYXRhLsKgIElmIGl0 IG1pZ3JhdGVzIGJldHdlZW4gb3RoZXJ3aXNlDQppZGVudGljYWwgc3lzdGVtcyB0aGF0IGhhdmUg ZGlmZmVyaW5nIGh5cGVydGhyZWFkIHNldHRpbmdzLCBpdCBtYXkgZmluZA0KdGhhdCB0aGUgTEJS IHN0YWNrIGlzIGEgZGlmZmVyZW50IHNpemUuwqAgSWYgaXQgbWlncmF0ZXMgdG8gYSBzeXN0ZW0g d2l0aA0KYSBkaWZmZXJlbnQgTEJSIGZvcm1hdCwgdGhlbiBwcmV0dHkgbXVjaCBldmVyeXRoaW5n IHdpbGwgZXhwbG9kZS4NCg0KDQpMb25ndGVybSwgd2Ugd2FudCB0byBzdXBwb3J0IEFyY2ggTEJS LCBidXQgd2UncmUgYSBsb25nIHdheSBvZmYgYmVpbmcNCmFibGUgdG8gZG8gdGhhdC7CoCBJbiB0 aGUgbWVhbnRpbWUsIHdlIG5lZWQgdG8gbWFrZSBWTXMgbm90IGNyYXNoLsKgDQpJY2VMYWtlIChz ZXJ2ZXIgYXQgbGVhc3QsIG5vdCBzdXJlIGFib3V0IGNsaWVudCkgaGFzIGJvdGggQXJjaCBMQlIg YW5kDQptb2RlbCBzcGVjaWZpYyBMQlIuwqAgU2FwcGhpcmUgUmFwaWRzIGRvZXMgbm90IGhhdmUg bW9kZWwgc3BlY2lmaWMgTEJSLg0KDQpBbHNvLCB3ZSBjYW5ub3QgYWR2ZXJ0aXNlIHRoZSBQQ0RN IGJpdCB1bnRpbCB3ZSd2ZSBnb3QgTVNScyBwcm9wZXJseQ0KYWNjb3VudGVkIGZvciBpbiB0aGUg bWlncmF0aW9uIHNhZmV0eSBjaGVja3MgKHdoaWNoIGlzIHN0aWxsIGEgd29yayBpbg0KcHJvZ3Jl c3MpLg0KDQpGcm9tIGEgIm5vdCBjcmFzaGluZyBvbiBtaWdyYXRlIiBwb2ludCBvZiB2aWV3LCBt aWdyYXRpb24gbmVlZCB0byBiZQ0KYmxvY2tlZCBpbiBhbnkgY2FzZSB3aGVyZSB0aGUgTEJSIGZv cm1hdCBjaGFuZ2VzIChhbmQgb3RoZXIgY2FzZXMgdG9vKS7CoA0KV2hpY2ggYWxzbyBtZWFucyB0 aGF0IGJ5IGRlZmF1bHQsIFZNcyB3YW50IHRvIGJlIHRvbGQgIm5vIG1vZGVsLXNwZWNpZmljDQpM QlIiLsKgIEJ1dCBmb3IgYmFja3dhcmRzIGNvbXBhdGliaWxpdHkgd2UgYWxzbyBuZWVkIGEgd2F5 IGZvciB0aGUgdXNlcg0KdG8gc2F5ICJwbGVhc2UgbGV0IGl0IHN0aWxsIHVzZSBtb2RlbCBzcGVj aWZpYyBMQlIiLCBhbmQgdGhpcyBjYW4ndCBiZQ0KYW4gYXJjaGl0ZWN0dXJhbCBDUFVJRCBiaXTC oCAoQnV0IEkgdGhpbmsgaXQgY2FuIGJlIGV4cHJlc3NlZCBhcyBhDQpjb21iaW5hdGlvbiBvZiBQ RENNPTEsZm9ybWF0IT0weDNmLEFSQ0hfTEJSPTApDQoNCg0KQnV0IGl0IHN0aWxsIGRvZXNuJ3Qg aGVscCB3aXRoIFNQUiB0b2RheS4NCg0KT24gU1BSLCBNU1JfREJHX0NUUkwuTEJSIGlzIGEgd3Jp dGUtZGlzY2FyZCBiaXQuwqAgVGhlcmUgcmVhbGx5IGFyZSBubw0KbW9kZWwgc3BlY2lmaWMgTEJS cywgc28gd2Ugc2hvdWxkIGVtdWxhdGUgaXQgYXMgd3JpdGUgZGlzY2FyZCB0b28uwqAgTW9yZQ0K Z2VuZXJhbGx5LCBJIHRoaW5rIHdlIHNob3VsZCBhcHBseSB0aGF0IHRvIGFueSBzeXN0ZW0gd2Vy ZSB3ZSBkb24ndCBrbm93DQp0aGUgbW9kZWwtc3BlY2lmaWMgaW5kaWNlcy4NCg0KSSB0aGluayB0 aGlzIHdpbGwgYmUgc3VmZmljaWVudCB0byBhdm9pZCBjcmFzaGluZyBndWVzdHMgb24gU1BSLsKg IEFueQ0Kc29mdHdhcmUgYWN0dWFsbHkgZXhwZWN0aW5nIHRvIHVzZSBtb2RlbCBzcGVjaWZpYyBM QlIgd291bGQgbmVlZCBhIG1vZGVsDQp0YWJsZSBhbnl3YXkganVzdCBsaWtlIFhlbiBoYXMsIGFu ZCB3aWxsIG5vdCBnZXQgaXQgdXBkYXRlZCB3aXRoIFNQUidzDQptb2RlbCBudW1iZXIsIHNvIGZv ciB0aGUgKG1vcmUpIGNvbW1vbiBjYXNlIG9mIG5vdCBoYXZpbmcgbWlncmF0ZWQsDQp0aGluZ3Mg c2hvdWxkIHR1cm4gb2ZmIGNsZWFubHkuDQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Fri Jan 06 18:39:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 18:39:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472874.733272 (Exim 4.92) (envelope-from ) id 1pDrcd-0008IH-QX; Fri, 06 Jan 2023 18:39:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472874.733272; Fri, 06 Jan 2023 18:39:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDrcd-0008IA-No; Fri, 06 Jan 2023 18:39:19 +0000 Received: by outflank-mailman (input) for mailman id 472874; Fri, 06 Jan 2023 18:39:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDrcb-0008I4-3l for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 18:39:18 +0000 Received: from sonic304-24.consmr.mail.gq1.yahoo.com (sonic304-24.consmr.mail.gq1.yahoo.com [98.137.68.205]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 691ed5a2-8df1-11ed-b8d0-410ff93cb8f0; Fri, 06 Jan 2023 19:39:14 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.gq1.yahoo.com with HTTP; Fri, 6 Jan 2023 18:39:10 +0000 Received: by hermes--production-bf1-5458f64d4-bl5tb (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 90dc30dca055f6fc7430c5ec161196a7; Fri, 06 Jan 2023 18:39:07 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 691ed5a2-8df1-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1673030350; bh=ByxGwuLu/B4A3w3BivVK9fvPYeRgohNkEitT7jEThBM=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From:Subject:Reply-To; b=Q7bZzcO898sepwxtrzaC9YEj5BLAJ5g/LqzXEmKpvGwPAa1PdF6vTrUETxd89y2+BSwyEt7NS/OqgfrBrw+r576vtPuI4luvbtLVwglwso/dcdEpLw5v1nqw0vkL6U5Uugpl41ADIw7jBYiACxggu6WCJaLjToeTGpxQaY5AZs05O1ofiOY+ydtDYtkw0AoVEKG0H1cDZuPoDaJodjYiYcPsBWqLpRV/M2Rls3uaIxTv0xiun4AYqbajGhBo5Ct3Zh291k9GdcFXvolDjG9TS2TdRLFEL3e278PEt+uppBV4IQAiHtFa1nloDISBQ+we/RjWPe3QCO3KIIfLyfLkqg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1673030350; bh=jdDpriTmaKK322OkMVuZTh256ShgFjR0VXVJysXGec/=; h=X-Sonic-MF:Date:Subject:From:To:From:Subject; b=PHOt+GCwsQFKPbdXf7Ap0bW28SQ1JcAg14Jx2/23A1RcGGynxXzL42v/KJ63A3YDN4R2RAVjsjpArIzDkU5/C81yOQZgX0rWFc83AVJ6mqiIO0564z0vq45eF1pVQknJbHi7ZW0vgjpRrEGckRwMlXa4jTphOsFxDBhLx4pAAMpLtUB/2/tVYkFkhVjGllxohxy9Dx4TnuNEZR+9XoxVf2OUMrhPvIhhlI6XUrs//qX9OyJ4kY46/1rWZtxfU8o7KT8Ly8iO9KcoAj2MTFNG8X0hXMBTGAI9sUTpiT+x1K/WEVAhzTkr4G9TrpHWJIsXG1xgdGj39DzEGaPrXdwiVg== X-YMail-OSG: xytN2Q8VM1mZBpk1MsZy3FNWjf3FsAF8Ppe6zrirAut4WLJjyyEBBSUn8m.wtF8 9GG5GUBThPXGMjPVnLQt5ezUGjjcV_UjrQ7gsKJiuXuoxYF_h8qU9_UACINf7aSCqKmHEwsivGkF UIxtKQ5mp5kVCcgXq3nrKZa74S.vV_HWOTXH47qoKeccoOhIar4dQIY1jzZKQT_s5FSitFPEcBjP 6JYmjFeSMerF_1QRJ0HHdseT38eQ8HyhiK4GHCtnhr0jSkfU8twtOiFNiKnRXhmJ_Y1pnrQkTLD0 ZFDYQjubpbJxPTHy.ks95G3vBZBRYca7MciirZZo3sW390akVSlrZCkR5nYFrmI0vY_XVJs_CoDe PYBQCsGLOn1L1hN8pLFOVQn1uwvIjsEjy5.v3NncQ1ujB3RPCKAF.80FJoT0X.vEz2X1mSRq9qjs .01OncTLbiFnzOJzsLWaoWzwdGu2wuggoZJk3Polunqpk.NdksO4l9jU1SlxO8TuTPhSxat4Q6L. CA6alouZ6wDfUrtSf11EJrqx.O.8XFFCx15bx2isYbW7jYPdYDQVaK9r0zdrvnhdsAlqam18Z6gc oPxva6SReuQlsU13wZBsGwWQ6L5VtusOcElaF4lDg5SP5HgxsA_EjiUiiLCiaytuk0EL9oMna4xL RR4oUESW_UH.JI.dBswqCc0Acj.HKx4B.WK.pt1UWb4v318hA4vGtrvoeDZ1mif_5ozkMsaBrjwR IGfJmMyR8XJIGdtGqtAmK9eD1fys_d3wHLp0P7r7Q8f.DFUCUJF10YWSA8YeACgx6z_Cu8fbHTzd V7HLUTNzxbCCFYkqpivOyMpG6ZnBu9Rx0HhK4QPyQIhfDxnsdunt4WZ5miSCEHd8yITql6NgDeaG ZhXJKgxY2BzXCpFDFCgtpX627krdRq7yCzadlMabIryRMPVk7uh.4HwapC933iQAvHPlm22VSiRe TOCBbSbQ9Y7iwXBGIHvaM0uJItA5V1kSI02YLpZJxo2DdAhBP3F2Am0mtZG5ND9ZC7U7zToXf95Y O_xiZIgB0nJ4kXRwgrLUq_LAyL5Sdcz8BxakB.sL_uF.EG4hkGUnMXa1MT494TBsE.tj_cq7sIkF 8avx_r6_fNRh_wVvziEk_VZQYvWpOQCq5j1nX8Rc_ezgQtdS8M.5PUSfFwj6CaRDpLrvbdra3bA3 Lbkqgph9eZpqamha5w4yNTEZvotmxjY_5KTqLZDIuf0bjQA1ZOLaHkaW8wSpLtCcMJx8VZLTsC_v 8tru_Z.TT7FXh9R6NX9LIzW6CzkJlZtk8AwVa7qYKOyBqwgZcRlAHxpdFBXRa7n9XyXS2GPHKNuW PLFBwuBgtu9PwTc2AhEL2DHDziRRoTAf2HTSPuxTpc9LoSBeMji72VGsnDZAHWvRwkflHnZXVf1w 3omiMWoPu4QYbOPN0q.1jXLlojmVkfHesUH1YymYT1UECK9xsdcrlkEt_4dCaqKM_rKgpGUa.XeO 6y3L1N8L34UsSLr6kDefrGAa_UhhagN7hYDztgBKskeC1Up7PW_A00rx.EO7plMA6tKv7deUqbAF uapikbTWHqhzjnK_oGXSgYRr4m2EZUfQJSQOKYFZ_tyb5KgmGZgPdzvlb3yOBeeZbxpvqmlsiFzU aET757Svb1gkbpsFgbLdiJdfFeh2JmFntMX7L6Xj81BRNV2NEBl_UKQBHOINZq7DwSJQP9q9oIaz ZL0uKDpaad0tTzseZQ2fpF1Z_tToF16FcZ85ss3Em6tffvzyISID87gjbze.Bhu6WKJ5V_cCwHjz nfiENnHf1uXhhTATVQQsmCB9B_S3uoz637.Z0KBYC5j_MrJ5qzjVR74NUTiqppLWYxjbeQx1Ho8s QYz_gE1o58zfBCfXeiO1u07xuZauxIMgEmsM5_FKaOutv8iLoiDIAjGkA.ITgWk8dgnKFltyDf8_ vHRa_x08UxLf9mZLejf3mo6XBYVkglwAhXI..uBQT7udtiqaoKw1ubbH9g5mMjo05QwilOTQERT3 rhytkKQK8gOmh7n00HN.OyQ59vgyXRze3ZEParQQd9bl3ewzJ6elrToo.FiJPVftGfs8r_k8kZ06 YkF6bF7jnm1A7XtoCgjWVmgT_11UoWEAWxfUcNcIMFLYTUAkpW7ErAycbObYkaU3_V8BEh8xu129 vvsXlW8yrMD3GvUiFyb1THvlUBLb76SU15sUzSmV_QT.RXVGa9oUbCW8Nw4ntooNpfoWTk_RBm8n DQ9k8N3mg4L8eh0Uly08a X-Sonic-MF: Message-ID: <3f7527da-2f0a-2d26-95f2-23776d0ab141@aol.com> Date: Fri, 6 Jan 2023 13:39:05 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v2 3/6] hw/isa/piix: Wire up Xen PCI IRQ handling outside of PIIX3 Content-Language: en-US From: Chuck Zmudzinski To: David Woodhouse , Bernhard Beschow , qemu-devel@nongnu.org Cc: Richard Henderson , Stefano Stabellini , xen-devel@lists.xenproject.org, =?UTF-8?Q?Herv=c3=a9_Poussineau?= , Aurelien Jarno , Paul Durrant , Marcel Apfelbaum , Anthony Perard , "Michael S. Tsirkin" , Paolo Bonzini , Eduardo Habkost , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= References: <20230104144437.27479-1-shentey@gmail.com> <20230104144437.27479-4-shentey@gmail.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.20982 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 1256 On 1/6/23 12:46 PM, Chuck Zmudzinski wrote: > On 1/6/23 12:35 PM, David Woodhouse wrote: >> On Wed, 2023-01-04 at 15:44 +0100, Bernhard Beschow wrote: >>> +        if (xen_enabled()) { >> >> Could this perhaps be if (xen_mode != XEN_DISABLED) once we merge the >> Xen-on-KVM series? > > I am not an expert and just on here as a user/tester, but I think it > would depend on whether or not the Xen-on-KVM mode uses Xen PCI IRQ > handling or Linux/KVM PCI IRQ handling. > > Chuck I could try Bernhard's patches in a Xen-on-KVM configuration if that might help. I would need help configuring the Xen-on-KVM mode to do it, though, because I have never tried Xen-on-KVM before. The test I could do would be to: 1) Test my Xen guest that uses the current PIIX3-xen device in the Xen-on-KVM environment and get that working. 2) Apply Bernhard's patch series and see what, if anything, needs to be done to make Bernhard's patch work in Xen-on-KVM. I have already verified that Bernhard's patches work well with Xen on bare metal, so I don't think we need to answer this question before going forward with Bernhard's patches. This can be patched later to support Xen-on-KVM if necessary as part of or in addition to the Xen-on-KVM series. Chuck From xen-devel-bounces@lists.xenproject.org Fri Jan 06 18:55:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 18:55:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472881.733284 (Exim 4.92) (envelope-from ) id 1pDrrx-0002CH-4E; Fri, 06 Jan 2023 18:55:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472881.733284; Fri, 06 Jan 2023 18:55:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDrrx-0002CA-1R; Fri, 06 Jan 2023 18:55:09 +0000 Received: by outflank-mailman (input) for mailman id 472881; Fri, 06 Jan 2023 18:55:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDrrv-0002C0-Cw; Fri, 06 Jan 2023 18:55:07 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDrrv-0007fy-6G; Fri, 06 Jan 2023 18:55:07 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDrru-0002Xg-Qt; Fri, 06 Jan 2023 18:55:06 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pDrru-0000gT-QK; Fri, 06 Jan 2023 18:55:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=btEX+Y9FURyODiBxP1JET2mJ3sTKOYHbkqKQ09Qv/18=; b=aPDbQOPZJfyw9MkdlR36AWH6bK U5DPXIgJSl5QuXQSytYo7xEK+vWJSCiTAjwXwAap7o34DiEqDR7Ux1BhY59OL8reIthQVfKsbwNMV 4V32XYdKpaIfzrBqAWcgscqtHOzhXLpgYt92iEVg4RVzcsekof+Ueu8nFTGx5P+oVK7Y=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 175606: all pass - PUSHED X-Osstest-Versions-This: ovmf=d8d829b89dababf763ab33b8cdd852b2830db3cf X-Osstest-Versions-That: ovmf=5386c9e6dab2f6a555e679aff9f6a59f60c8e029 From: osstest service owner Date: Fri, 06 Jan 2023 18:55:06 +0000 flight 175606 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/175606/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf d8d829b89dababf763ab33b8cdd852b2830db3cf baseline version: ovmf 5386c9e6dab2f6a555e679aff9f6a59f60c8e029 Last test of basis 175604 2023-01-06 13:12:23 Z 0 days Testing same since 175606 2023-01-06 16:13:16 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: KasimX Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 5386c9e6da..d8d829b89d d8d829b89dababf763ab33b8cdd852b2830db3cf -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Jan 06 19:08:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 19:08:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472890.733295 (Exim 4.92) (envelope-from ) id 1pDs4b-0003kH-AB; Fri, 06 Jan 2023 19:08:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472890.733295; Fri, 06 Jan 2023 19:08:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDs4b-0003kA-77; Fri, 06 Jan 2023 19:08:13 +0000 Received: by outflank-mailman (input) for mailman id 472890; Fri, 06 Jan 2023 19:08:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDs4a-0003k4-Ti for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 19:08:12 +0000 Received: from sonic310-21.consmr.mail.gq1.yahoo.com (sonic310-21.consmr.mail.gq1.yahoo.com [98.137.69.147]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 751bff22-8df5-11ed-91b6-6bf2151ebd3b; Fri, 06 Jan 2023 20:08:11 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.gq1.yahoo.com with HTTP; Fri, 6 Jan 2023 19:08:08 +0000 Received: by hermes--production-bf1-5458f64d4-kq8fm (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 462c69a279a2e24d2afd89e95d1e005d; Fri, 06 Jan 2023 19:08:05 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 751bff22-8df5-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1673032088; bh=bGPA4yzFOwZB3mapZnZRp7YkIuMge68eikWnzp8C73A=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=L7ms3qqlnqmOSxzPL4GJR/DSQWufryfaP8W6xkdRkr8E0itME7qaaojNIvJvdlwKN7rI87ITSOfPsxwlTCr2iFgaykM56PEwcxwtUvgBUrltH3i0G4RRXCQKm1m1wO+qwxZzeMxGyr/wgIrYJkI3J5fJi/D7mQDX2BhDheR+AjnPbN9B3vWLCXZ3NEkdWb/8rGuj9y+BqHT7+OyGweW8PKWgWDBBM2fv/knyZg4G07JubdyZsdVxXP2p88XoUX6w4I5GakjiziOGPOjy0o+vdVVDBN4Im1RYIBmRuKDYumjgLRiIclVeqp2309SfF/UZiTZj/AOeTi0sgOh9Iasg8A== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1673032088; bh=W828f11+CRPmLujnXGHcpkkrKCf9aA7T0guyPLYK0YX=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=mgikH/Y55awpAMVoWqhvsi115jC2PtamCU5BtL15iF3FFG3QZPnN7Ymks0PuFn8kM4A71L9KYvuq2WyFUmQ5sEVUiGldgSulVCPxdnYgN0wMQ1DooTW8mGViPcZrbtrwupEsR7puMD0zFnkdSQpzIBxcbOFQrINFXxmNLGtxQVHovVTeppqU316rKTZ0CaPrA+KTgRzNtxWcFc8yZhVB/naBT7Qpydl/rgC0MA3f3Bim2ab45YOpzOR1XC7S+aTs1Z1ggUQWp5yhDC5r0mORLG4c3a41/hePdewsoOLZBFqiITUcI2EDUGO4GWXQWG8FTbm3yDy503LHNCA+Q1mgfg== X-YMail-OSG: TPustp8VM1n2dfKzoFYbXatnxmVYHD5VeyB1Pji9J7P.xLMjLELOyAxIAzXR.2e RVnvJHEmjufCpvav5UjEplhwOImdMeob6iaAg79.UXL_jFjoSkQXGpCchi8eZeVb5NXVLJRSr094 ofeTmcVjrUxAauhrjtTi5lQsoAsd7xWOYXvYbgwFYqwl7hbxzS4kx9qRGphIZKt544OKEWJxOGUs BNtBj8P10jOGgLZISdgJxIDT8p.GccYmQvVoiex7l6i0gCH7IHhEV4smtxt64yLApVSxrc0k1mvi WDGxjbd8iOsrMrmXz8TCP_guJkNPQ9HLZOkb.Hy5UwmcraW3807fC8lEDX9Fb72LmM9q0D55tNUR Xb5YdnSpZN1Tcf4XE0p_n9Z1pvYX0uELCM6.TbwWCxOiVjyKivkOVP8OhpqAzz_WiJJpIJZzCHeS f6Slsxwx2aXseNZakxS_.cjGh5mapfJv07c0O2bg3BFduPkh7zY.ZsjVbduAJ0IgrHADwOdhkz.H hMxfuupb9eBqFirHKckw5jeKwnRzYbkrmRMSFeEGM3fnnonFBkPF0oUk5QzQACyr1YII61umIbm0 A3jLiWmg4KzBSBqQvRSqyJOfziqPKDEv3mOe7BMmUW89eMtePhCMPeKPN5.8OM47WOcmDov9kEuj klInieFhbudKyJmtZ6qgG4pDxNS0E.An0oKc.mNsR9cchxgG4WQHqLcEiXJkSBCkIcmzR25vVPcG Ky.Y9S0pkhbELfEKTghh7NWHyV7lJ9cI6805KBv.T6FUdwlesvA_kVa7erbpxlpcT5nbMCoGF6ff G2f2mr7k80GYkwYwJqxVGyC6bJIteIWSwmPVk9.xYpwX5KwkpRBQkb6JRnUkxIZFumzg1dkIuUBa TG_6Z80tv0jfkTZM3Osr1kmsjTDKNwEe5s.w7yyevjk4Uh2_Duhg5FefQ6Y6.jMGviYmCqHWhaHP uoYFB5FKmh.oStx0g0X.Rf9Yhnw1HHeV1.09pX1ENk9GokQdmUgHfs_RFzUcaYw161fsgIVw2Iew 9Ku.IgDBCJ1HNgfbtWkQP_J7hjqSeYOPODlVjAeCX_hTwhCKF4OpApCz59wxHDvy2I7AFYUP4vDb Iod3.suW.QvtBCFrwdBEqBVZjOsi1tQgpAh2mKMJAbmcrEhfzInPNdY2BoAmHrcclwE1CSDJgSvF VbFNRsEGaZ_NLNuEdNKP8nwj7ViVfyt9qB.3DzyhJYLT8mJMcf5k3E_5xd_apwfsRyGGHYPqRF7z nvdVY2m40FgJumaHROGyrWOlKkbTC4yghypKhtqGHE1DjMm55rcC7RWwsbAkDbnJDLRVy_NXNpB2 bPkNc58AJAR9i2Sl67clenKqFnDcDRhG_EBqbWpN57GBY16VjO6j2TBCA.OxNUvhga.xIwZxT1Fm 02kX.ttrniZodyzpDAs._uwC9UYVuKqxME_PgEay.Cl5mwD4fUK1LhmPD.gX1S.b5dnLtZcTvOJ2 bd2S5o6KEO4cv.o6FQR72hO9sTG0Akt9hzy01bJqLcwJK8YfxhEUcVh7oiiPPdwTy5R6bk2F_5PU 1Gb9pxAE6G77ZpeQJHSr31NFAk5oGSz20mLmSALvJmYaMxT3Jw8hg_Rt6HGX6HTLCyuMdQQBzfmy 3WOqbM9mDTVXG6BI3gA1JsMFzqD6xf7AuD9vM.7f0J8wKMKgthlRqNGSs3jIgHMFFoR2iwROgCgX XlOYlT8OlQ7l9O.o7FbN0pNmUlKinzDML.dILkYVnTb8i1ivp4UkLx1f5tCA4WhFFHiMISy2hn4P 1N.mjdMX1SIWsLewN7XMV5aNwyQHgnqqCaj9H.XrpF_oLPI7hQ29BDNN1uKt9ks7KWU9qduyZRfp gxTqQUB2ck8kYejXb7KGiD4FdhF2qPyXoHiZnxzxH6xV43tk9_BIO_fY21iyRsKC4Lapevmdbpch ufTx6gJ_3hqZpIPxDxJyAt73ErICChmmL7naMyiOx7sTcipoNq01OSnP.2tLDXGh86vatQC.b8vs J5tPsPzEime6sDYIkhIPz6cII.iWoRv7TmzOC28LJHHP_.4vTaKpBINBP24lSf5qiic7WwgODs2. BfCKfyvaw6JfwY0KZkC4.rTAJR4PZkZ1tIc8mAuoqgFggA9WMQOtcM5jsE2Qrf63zTZ06sO.EbiB 51GwfSWeZJxBb.zVKeYNGd82MyAqs7GH5ah_MKfDsKWUQ6OXZQqWRZcQbp_nt3Z3ovHHBNEZ1JHK MOfdPK46i_M9ZMJsBVVyA X-Sonic-MF: Message-ID: Date: Fri, 6 Jan 2023 14:08:03 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v2 6/6] hw/isa/piix: Resolve redundant TYPE_PIIX3_XEN_DEVICE Content-Language: en-US To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Bernhard Beschow , qemu-devel@nongnu.org, Markus Armbruster Cc: Richard Henderson , Stefano Stabellini , xen-devel@lists.xenproject.org, =?UTF-8?Q?Herv=c3=a9_Poussineau?= , Aurelien Jarno , Paul Durrant , Marcel Apfelbaum , Anthony Perard , "Michael S. Tsirkin" , Paolo Bonzini , Eduardo Habkost , Thomas Huth References: <20230104144437.27479-1-shentey@gmail.com> <20230104144437.27479-7-shentey@gmail.com> <1c2e0780-e5fb-1321-0d84-b0591db9fec7@linaro.org> <6a1a6ed8-568d-c08b-91a7-1093a2b25929@linaro.org> From: Chuck Zmudzinski In-Reply-To: <6a1a6ed8-568d-c08b-91a7-1093a2b25929@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.20982 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 2137 On 1/6/23 7:25 AM, Philippe Mathieu-Daudé wrote: > On 6/1/23 12:57, Bernhard Beschow wrote: >> >> >> Am 4. Januar 2023 15:35:33 UTC schrieb "Philippe Mathieu-Daudé" : >>> +Markus/Thomas >>> >>> On 4/1/23 15:44, Bernhard Beschow wrote: >>>> During the last patches, TYPE_PIIX3_XEN_DEVICE turned into a clone of >>>> TYPE_PIIX3_DEVICE. Remove this redundancy. >>>> >>>> Signed-off-by: Bernhard Beschow >>>> --- >>>> hw/i386/pc_piix.c | 4 +--- >>>> hw/isa/piix.c | 20 -------------------- >>>> include/hw/southbridge/piix.h | 1 - >>>> 3 files changed, 1 insertion(+), 24 deletions(-) > > >>>> -static void piix3_xen_class_init(ObjectClass *klass, void *data) >>>> -{ >>>> - DeviceClass *dc = DEVICE_CLASS(klass); >>>> - PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); >>>> - >>>> - k->realize = piix3_realize; >>>> - /* 82371SB PIIX3 PCI-to-ISA bridge (Step A1) */ >>>> - k->device_id = PCI_DEVICE_ID_INTEL_82371SB_0; >>>> - dc->vmsd = &vmstate_piix3; >>> >>> IIUC, since this device is user-creatable, we can't simply remove it >>> without going thru the deprecation process. >> >> AFAICS this device is actually not user-creatable since dc->user_creatable is set to false once in the base class. I think it is safe to remove the Xen class unless there are ABI issues. > Great news! I don't know if this means the device is user-creatable: chuckz@bullseye:~$ qemu-system-i386 -device piix3-ide-xen,help piix3-ide-xen options: addr= - Slot and optional function number, example: 06.0 or 06 (default: -1) failover_pair_id= multifunction= - on/off (default: false) rombar= - (default: 1) romfile= x-pcie-extcap-init= - on/off (default: true) x-pcie-lnksta-dllla= - on/off (default: true) Today I am running qemu-5.2 on Debian 11, so this output is for qemu 5.2, and that version of qemu has a piix3-ide-xen device. Is that this same device that is being removed? If so, it seems to me that at least as of qemu 5.2, the device was user-creatable. Chuck From xen-devel-bounces@lists.xenproject.org Fri Jan 06 21:50:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 21:50:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472897.733306 (Exim 4.92) (envelope-from ) id 1pDubq-00032M-Pz; Fri, 06 Jan 2023 21:50:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472897.733306; Fri, 06 Jan 2023 21:50:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDubq-00032F-Ml; Fri, 06 Jan 2023 21:50:42 +0000 Received: by outflank-mailman (input) for mailman id 472897; Fri, 06 Jan 2023 21:50:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDubp-000325-7j; Fri, 06 Jan 2023 21:50:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDubp-0003SU-4k; Fri, 06 Jan 2023 21:50:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDubo-0006ea-2N; Fri, 06 Jan 2023 21:50:40 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pDubo-0005Vz-1h; Fri, 06 Jan 2023 21:50:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=h6zTPsL5iplcreE3c6x0M3u7gsvUdIpxd8P7eb2GRRU=; b=LWTJnOfXqwfzfIEiIMGIGoIysV bQ4ba8P0+6AtT+OIO89jgO0azmqiyZByYNzisUWg/lg1Hyep8nEIIwbK1vma0JYIZcK3VRVmmTTJe zCOFhIODGkGNQJqovOx1LmfVfDDOP5bhrc81eDmifLFAagIO4HTc3ncEpH1pxxo45Gtc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 175603: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=d365cb0b9d14eb562ce85d3acfe36e8aad13df3f X-Osstest-Versions-That: qemuu=d1852caab131ea898134fdcea8c14bc2ee75fbe9 From: osstest service owner Date: Fri, 06 Jan 2023 21:50:40 +0000 flight 175603 qemu-mainline real [real] flight 175608 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/175603/ http://logs.test-lab.xenproject.org/osstest/logs/175608/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail REGR. vs. 175595 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 175595 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 175595 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175595 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175595 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 175595 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 175595 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175595 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175595 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu d365cb0b9d14eb562ce85d3acfe36e8aad13df3f baseline version: qemuu d1852caab131ea898134fdcea8c14bc2ee75fbe9 Last test of basis 175595 2023-01-06 01:55:04 Z 0 days Testing same since 175603 2023-01-06 12:10:38 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alex Bennée Axel Heider Claudio Fontana Fabiano Rosas Jean-Christophe Dubois Peter Maydell Philippe Mathieu-Daudé Richard Henderson Stephen Longfield Tobias Röhmel Zhuojia Shen jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 631 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Jan 06 23:04:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 Jan 2023 23:04:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472908.733320 (Exim 4.92) (envelope-from ) id 1pDvlB-0001o8-Fj; Fri, 06 Jan 2023 23:04:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472908.733320; Fri, 06 Jan 2023 23:04:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDvlB-0001o1-BK; Fri, 06 Jan 2023 23:04:25 +0000 Received: by outflank-mailman (input) for mailman id 472908; Fri, 06 Jan 2023 23:04:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDvl9-0001nv-BK for xen-devel@lists.xenproject.org; Fri, 06 Jan 2023 23:04:23 +0000 Received: from sonic309-21.consmr.mail.gq1.yahoo.com (sonic309-21.consmr.mail.gq1.yahoo.com [98.137.65.147]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 72c0f768-8e16-11ed-91b6-6bf2151ebd3b; Sat, 07 Jan 2023 00:04:20 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic309.consmr.mail.gq1.yahoo.com with HTTP; Fri, 6 Jan 2023 23:04:17 +0000 Received: by hermes--production-bf1-5458f64d4-s52fb (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 73550f2f3ad1d326fe382ae3bf119149; Fri, 06 Jan 2023 23:04:16 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 72c0f768-8e16-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1673046257; bh=5EDETl/Bn40ksYDdHxFQPm8HxH4mlDcmh7uTqfmAZxw=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From:Subject:Reply-To; b=uUot1KD7m/rROeXRXcAneoVytEcn/YyvQzAOgceGEzlR5k3liW6unrbm3A686MBXXFJgkJae9qamIQpPVf/ZbpPhw1XIiG2aCA3YhZ9m53OgKMU15PfVBG5y8t2RHn3JnAy1bqj/Fz7d3ri5OKfPAeNWraQEiOaPbFV/kAAKLNdh/b0+F3VKrYc2yiS63riATrVqRxoSw0zWkQtKilHjfIhLMonWJd+bMDUASt7L95qJwm5cqIrQEHGGdtaqQeLH5NtgFZJVX4+VPhM+IvOA2PL/mTVWT/4RQIvLNoSNPXKpX6H7TwfTJv06JR9M+MPcNYXXxZAYiNWUKoBWk5Q9ww== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1673046257; bh=H8pCqt53rijduXGA/ATbxaUuckY3oh3NtPO5R2CHj6a=; h=X-Sonic-MF:Date:Subject:From:To:From:Subject; b=rWOpOIPg20sdwrwQWuAaLDFreFKshWlhfOfGWduypNVPkV94j/o/m4wIRKiNi30MP3aH492/+3x6lY/wqtVzhvwwrGpGsqMerYJuiFw93tA1BjOXetVaM54UqRS95PDhNR99PqXznrgLvsnDWpDdBNlti8S7ozZ0Rr1KdV43F+ZVtUULpq7lGV1k+BjB+BPjVORO5urC88/12GC9R4TJwcaVfXe0DZQ9yaFUgzcdK0a9LkuYFOa/a8VrqZlvaatQin+lkmmrRxnmzpyc1CSIlrKbZQbA9xlj2j0KH3gW2RchBCzmrbL3SdDXsjf2QDhp/yHCOH1qGgmfzPg3AW57Xw== X-YMail-OSG: w5.iMUIVM1l0eqGZQfenJKq0f3WWOoVU1G_PwzmLYayjTCdr5p_EL6nBnjFJgqa rDA7tjOPnqDGyMB94mV.fxfplHns2lCUBZRAg8osRBZaM.WwdM7Jpd2Ss2YHoI1IzlfFKvkSy9K4 A4wvuHYlJQ73AyvAB_n7XKjVl1OevIpQ2Jh5NZfPhnwzPm_0pa6FiOxyTJ8AJ.jB6vChfIqZm.Qp O7vaX.ubl.X9Ses4q082Eg3okm1J9MbLtOmM2h_nCh9s_T2mupXc.4ujZXmpheVkpqQwc5vOM5RH hYzPObcAS_v9RyuDTDDP6V869VHrJ6JBuT2g430TxIYovuuYa51an7ridQK22eo.Cv5npxcSrUw3 t4aOq_rcExrMjreScMYx0BFY6ccJYcAvrPq_ZBOwhgbl4NNikE.LIVWleYqi1fTmRbePh2t7NflP rDIprbzCihTdFc6X6h8KOVSRgKsPLNGidtawWu315IfQYrWGuhDcWDxt4zRSGY8MaLUcpXZUWAgv Kjfpqv8DXkpotVssAulyhrZKXGwI9KKONjuFD0uQmsQhcZeAeKXeJhxrcRXYucQDiqjgctOw.NZh wrSLgVUJOeUTmHncgyi4tm7nxb2FEKA47ZhppgoDGFRJhy5463d5QWtxzh1larSaiexRTpLgY4WM PQ_AMwXD8fDggq.XlnjWSLGg4_IFChEKzg7YgRtqj0GA_i0ey8kHTglvAqUg1Wn2KU2JWfSvQTyc iYroyzWpfvItkGx2ZeH6_XXbVQpUDAqsP2BdSVnt4fJ.Ct7RKwH4Jq1K_iby9zjIj7ZJsYfhCdFW 2xsRWJyxKeebG3.QIgtJARqrFmxdIzJRk0wdoW1rNwz1WHKEiVsN.7dQpSgUHdpuwZ4YaefdlVvZ SXVzqQLOevHZjrJ_gFI873PK.JHKFyMWfUxkdfVQLol73f93DNkSbrl0ClCDXATsMgp5_BCxhfGK h_4w0916KfWFkOf5kGaddnM7V_bAttxjCBOz9vq2EDHsHU0jK6AP76Q7a9_2cR3E.xRGk9fXCCaB bXGzu3q2i748rbm3mwcWvPJicS5DKi.MInmquPmkYkvSYy7Zd7S9FrHKY0tqzvI1Xe.VjycytL80 JdrkkB8vAIX_DL0YcIbF4NnDIlL.phu5kO1j6_MOjG1nf7OWhSoesUyognQYge_u76YpQ7DJKcOo kMDI8SK8g5gpw_pAMMpafG8tod8yDCD6XjJ0YlzHDr7iicYthWcQSXdedOtf9ooBYZsJqNZw3v9A wgJu45w40Lo_0RdkXsL4L1FzOaHqwXZqcbC4aXuOs8NfrmhB_RpvVKsx0Lhev1nNdIQPKS32X7dJ NgiKhA5b3L0HsteXprIGKyLxlEd6mP5_nnkL2qgVF9qE.vshx0c1wKTKsH2aCbGu03c._oqPoTWG GrBS_UK7A_U2XDU63.fq4CbsF57b0jbJH44rbNwZSMWXh5ER.PCa0p3U6ErCCgAhhFeX7qE_4vas QcRM3ZdRkXEZDXU8.LEfUQWoxKJetCOQF6.o43qJQEy8iBaLH09jz7uCZnOtd_dOHakcAzcjLXV8 XzQQbMnf5pxEhdFi7n0.cHixRpESkdUGX5dPa2_ofEaP1qcKrXkKqH6zj3xrlBSpqzn5EwVW04eb 67avXN5m_RVI0FUJgls0aXxF1MD.fRBhu1Pkpm5U7MERwU00XJircEYOTIdqueXUdGtHr2YolXWO _CiiVuEpVSJPJZ.c6QtdXUH3dO._5kAQ5MIHPcYI3FY0FFxCVmNBoEGFJxsOhymy5uUwPOtTLQG5 vOJVOBFy.yCuvtyaCJQN6Uj.47AdTOZd22p0MMIlCDhw1anAeTPIivksbwTX5ri8DWgYjzi6prX_ xyAVQ3neeiCvUJdxvXnjgspq9SFj6hcQgnAE8X5kT7icqm9tUiordUmXgm6jL.lK1P9S0au2YAzE QVP1vSX4wK9IOwjRb1HkZyTTxEYdrmJVoT59Kf1NrXRRic8.Au8JAsflprYiPFuo.c2U4C.QwnBu fB94511G7U.deu.EI4asowZUUXhuGvxg.iznHm2NlxOzJOIoL70.9BworJTQiO1QOiKgFheTN.dZ dQCiNXbk4A6YcpGHPviTW_PfSj2lLn589dJ4w2Zvmpl_ceC5aCmKFiQ1Uc6dQpujyp5VZZDRFEvr fCP_ZZG4cxQuNzlTavIuLKnFwfVA5NbqyH4Arl9fvPCX1aqtMAfgZccXJQnYZ9iMeFE4YTaEkkPO YkZxbL8J7RGaOGNUGZuU- X-Sonic-MF: Message-ID: <30337c62-a938-61c8-3ae5-092dbccf6302@aol.com> Date: Fri, 6 Jan 2023 18:04:13 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v2 6/6] hw/isa/piix: Resolve redundant TYPE_PIIX3_XEN_DEVICE From: Chuck Zmudzinski To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Bernhard Beschow , qemu-devel@nongnu.org, Markus Armbruster Cc: Richard Henderson , Stefano Stabellini , xen-devel@lists.xenproject.org, =?UTF-8?Q?Herv=c3=a9_Poussineau?= , Aurelien Jarno , Paul Durrant , Marcel Apfelbaum , Anthony Perard , "Michael S. Tsirkin" , Paolo Bonzini , Eduardo Habkost , Thomas Huth References: <20230104144437.27479-1-shentey@gmail.com> <20230104144437.27479-7-shentey@gmail.com> <1c2e0780-e5fb-1321-0d84-b0591db9fec7@linaro.org> <6a1a6ed8-568d-c08b-91a7-1093a2b25929@linaro.org> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.20982 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 2881 On 1/6/23 2:08 PM, Chuck Zmudzinski wrote: > On 1/6/23 7:25 AM, Philippe Mathieu-Daudé wrote: >> On 6/1/23 12:57, Bernhard Beschow wrote: >>> >>> >>> Am 4. Januar 2023 15:35:33 UTC schrieb "Philippe Mathieu-Daudé" : >>>> +Markus/Thomas >>>> >>>> On 4/1/23 15:44, Bernhard Beschow wrote: >>>>> During the last patches, TYPE_PIIX3_XEN_DEVICE turned into a clone of >>>>> TYPE_PIIX3_DEVICE. Remove this redundancy. >>>>> >>>>> Signed-off-by: Bernhard Beschow >>>>> --- >>>>> hw/i386/pc_piix.c | 4 +--- >>>>> hw/isa/piix.c | 20 -------------------- >>>>> include/hw/southbridge/piix.h | 1 - >>>>> 3 files changed, 1 insertion(+), 24 deletions(-) >> >> >>>>> -static void piix3_xen_class_init(ObjectClass *klass, void *data) >>>>> -{ >>>>> - DeviceClass *dc = DEVICE_CLASS(klass); >>>>> - PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); >>>>> - >>>>> - k->realize = piix3_realize; >>>>> - /* 82371SB PIIX3 PCI-to-ISA bridge (Step A1) */ >>>>> - k->device_id = PCI_DEVICE_ID_INTEL_82371SB_0; >>>>> - dc->vmsd = &vmstate_piix3; >>>> >>>> IIUC, since this device is user-creatable, we can't simply remove it >>>> without going thru the deprecation process. >>> >>> AFAICS this device is actually not user-creatable since dc->user_creatable is set to false once in the base class. I think it is safe to remove the Xen class unless there are ABI issues. >> Great news! > > I don't know if this means the device is user-creatable: > > chuckz@bullseye:~$ qemu-system-i386 -device piix3-ide-xen,help > piix3-ide-xen options: > addr= - Slot and optional function number, example: 06.0 or 06 (default: -1) > failover_pair_id= > multifunction= - on/off (default: false) > rombar= - (default: 1) > romfile= > x-pcie-extcap-init= - on/off (default: true) > x-pcie-lnksta-dllla= - on/off (default: true) > > Today I am running qemu-5.2 on Debian 11, so this output is for > qemu 5.2, and that version of qemu has a piix3-ide-xen device. > Is that this same device that is being removed? If so, it seems to > me that at least as of qemu 5.2, the device was user-creatable. > > Chuck Good news! It looks the device was removed as user-creatable since version 5.2: chuckz@debian:~$ qemu-system-i386-7.50 -device help | grep piix name "piix3-usb-uhci", bus PCI name "piix4-usb-uhci", bus PCI name "piix3-ide", bus PCI name "piix4-ide", bus PCI chuckz@debian:~$ qemu-system-i386-7.50-bernhard-v2 -device help | grep piix name "piix3-usb-uhci", bus PCI name "piix4-usb-uhci", bus PCI name "piix3-ide", bus PCI name "piix4-ide", bus PCI chuckz@debian:~$ The piix3-ide-xen device is not present either with or without Bernhard's patches for current qemu 7.50, the development version for qemu 8.0 Cheers, Chuck From xen-devel-bounces@lists.xenproject.org Sat Jan 07 01:09:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 Jan 2023 01:09:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472917.733337 (Exim 4.92) (envelope-from ) id 1pDxhj-0007mQ-To; Sat, 07 Jan 2023 01:08:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472917.733337; Sat, 07 Jan 2023 01:08:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDxhj-0007mJ-QU; Sat, 07 Jan 2023 01:08:59 +0000 Received: by outflank-mailman (input) for mailman id 472917; Sat, 07 Jan 2023 01:08:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDxhh-0007m8-Ta for xen-devel@lists.xenproject.org; Sat, 07 Jan 2023 01:08:58 +0000 Received: from sonic314-20.consmr.mail.gq1.yahoo.com (sonic314-20.consmr.mail.gq1.yahoo.com [98.137.69.83]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d989aa9b-8e27-11ed-b8d0-410ff93cb8f0; Sat, 07 Jan 2023 02:08:53 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.gq1.yahoo.com with HTTP; Sat, 7 Jan 2023 01:08:51 +0000 Received: by hermes--production-ne1-7b69748c4d-g8q5j (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 34031321042cfd49358cba9e2ea3354a; Sat, 07 Jan 2023 01:08:48 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d989aa9b-8e27-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1673053731; bh=RM3OQ5SqcJacBinVYA5gdpDbq4pClsj3VLZOZHffPJQ=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From:Subject:Reply-To; b=dq2vESZ00s4dsw8quVaRQcy0BZg2MMAe1up1U3Xu4SS+hChXr+soZoOJHNf72JNnUmRqIjZt7CPd2Wj4o16s1l3suRFko0+555Qm/GJQUZh2HjjSazpYQJ1/LAUbMkGqx/X3S0Vyo76UZOVcJAThz9ZyUTQGW1cI3dr9adL6PpCIvQC4ggbq00a0lnAVdZKtotM38ldmUgdci/qQaNVTEtphM6mYYxBNpEQu2sg4TsDl7SV6bqpWlskF008qPLCTG639brYeH26TDogN/Em/C+B1hg8vg7mu9Nxi7FakyqhUVtyHuVLLMEmF8PRhctor2tNjooWG5+wGk8BYxg9dyA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1673053731; bh=4KfaWLub71iH+DxRqHsT1oed9V4ykxAI+tvjzwupahF=; h=X-Sonic-MF:Date:Subject:From:To:From:Subject; b=dIzK4EfUtagvwewOlyDYJzaHBeOE1dd6FxKhqKRJHVS1XT7ETQpsMvLowXWgauUyCvsxFlGI6+6e8MFwk/TI50wNq1ZXzeXmDSV/iCDRkf3wY9R3KKl6vHknczVpZ0s4J74pn+B4GpUDjRbb/pQPBuYODrX4Gtq5FGvTUCaRcHaVL/T0BFDK4uTWqCteGzMw3NVAyCMYvuK4EkIMlCfg42OU0hB8vIClBrgKzep1tnt1/wpkZXo5zWhj2invPMg/vpZkWiLuudUfdQrRyCGTCvxybLAI5mkDjaDwBr5OoGLZgIAYWtBgUlRLVi3XqnuWQWdT2HWXS9uSzMvKnTIY9g== X-YMail-OSG: gR.45zEVM1llY6rhNVg5om7pz3Lkij.kCFZX_Kf25.wujBsPXCa1drYl9VuuuST YImZ77FlHMRfjIC1BGeqBxNRH7W2cztj2fMryxh1TrjLPKpqzStbkiTq.hAWlA60D_OK2aaB2H3K GQpHFXEbv_ZycZ4fsAl_bs6hf2RMs7uMzOnIwKScFbuh8uPFHt6Q8Q9TeP6ZiXV3TEDcES0CeW4S fKbH27Wltwp5WU3JxJ38ID_VEk4N9JCos4IpLgX4tMRhi7VAu4gnujuSOTdpE0wbSHjrMDpp02ng .CBmPYzGveJWvlhmuTyo12Bb0urBmQTv9ri0hiQBW7RMYkGiyJFWic7jjALj0obWu4jBVV5x_tmu lXIK6AvTTwSL1K4HwFUw5G3Qt9pvUYIT7D4scKSqI8Bp5BXSaC3Bg63AjTqkRKiH1Auoe7Tmafmt rPma.QIljJk2Xifb4BCnXGXIQE2TfH2jyZs6JYnIC2omcMLTFuzhdLIwg6iVyzyD0GMv2HpABup9 hhls2QFdnGr4w5SvNKcUR1fKdYwb9x.cGFVjGPrHOJbwlJnEjqJ.3vjXJRhfJRN9EyP9oUsCHj4Y 5e6eWr7KZdShlzd3M44mBNe_WKhNC36jzzaEwOWEXdoedNWAcE_4GSPbHFj0vQHYXINASFj2P2Bf 89w3EZvwOLctiVKy0DlINKGn5Phb391wMG7OGYrTBulQzHjZlFaoGvbK6b5Kxsp0Anv3Y2hpyOtq otM_OqibOXCPToBMd4gw2ZdfX3N_CsSUI9fx1emlXlr9bXDOnAet7Fgf2m0m4B14ZpFBFHNIC1NG 9p5Kra2XccUh6EaSc_UYsGRQZH1T.bdO_zFJdRlOF1RE2o6GaSuKYDuNUYRlRn_WSZWf5QbQDCK1 nzUuCJXeVkNfLQ_Klg5x_Hbs65CPm93SxWJh7_7tESbDRtAQk78slvLnIjA780llDOYgQ2AYMCox a90nymUlZw35b2LJItaQ7GczJMGKffoZJTrYrmTfIyCDdK0FpWQigQ3zcTi7XJVRLBSggobCiLMa U_G._NxtXd1N96SLaRrVw4kC7Gx67e9.Ft8uuwNKP2R5tzHceuO799VezVkW1KO2VydGrIalChkd u23.VU1wj2v_1B6edEJesBz_geqdMmsj5mhBRWoR21uYIMcn7YEyzSNA7TSZNVNTXqFeFPP_nedR 1KGzYcLklAbq0r7rb6MEvj64NaZXJK1NWaPg20O9sDLhkE9Q0UiyGfFmDN29jfIzA.WDcRRbnfxX oCnR8gpRN5BaOigpo823oPwNolA1hbQINhvseJYJNEt.zaBcRPA4mY1etTDo4CBRem.ebisB38CG UJpAZ.T2Eer6GG1T6O3vJ06TwxDDy1s_OQaDSknq8krl1ny1njz8L3wLlCaJU8L5uCc.b20SXTCu QErbEW0hCmlo5zZsOfisDKfc8qat0ifJda6jrddbx7u75idAVMrN.vvf_0Ve8D2PG5advZg1wr4. lOWkqxV9IBWo3uO2nWq3webNXgS7K3Uq61Xy4yOhWgtVvR.FmB66JFz9ppo6WeZaaw6IHU7C1cm8 zRGTErBUkx.Y24QPJWA7x8eI5JB4xr9tf9jPf7U52P1PcHab5_XrmjpNwZxKTmDhXpGgTstEvIoy E8oXy_NEBSLLWK5EPdBluUMiRVGDi61rUdnP7LFarcokxhBa0kAjdEtLOFXFqHQ0zA6oeKaEyYXX vHTOyE_6y_q3bYQzPL7p2ZfelWIVyqglLXgj25iK4N3ULo6tuowMO4YrJOs3DAir0XtgpfjasbCo NLCDLeY6.mWLYdSDitC_3jYBUYxkB5Gb6vl8gZ2Dq1V1eciYauuLzHVU7mZABDJStVjnSkZ2FUO0 ZaN.UZZDfEN_a.neb34EGqqOX_pb6j6EhLe7bny3xvMiRGmt7jWbdRedQPqMZ65LoErRHSLoqvaa hyIqXMnIUsJZFEF1Qbwmf57ZbINnAIB4rgiN0Gm7l04pzGNaGy1I1Wn5E5fUlI5ahJjhBmWjhQ_p GHq22mn6lmS6MAgwfiJIgEklqCtf7y44im619ABPT8PHX0LzFJ327Zl2E2FudwOrV_FzqOk17y8w BZXqo.YCW1jF50HKpvBIFepTKvzDe2hgn4IrnNoeDMy3kjDhCm3K80ab87O2e1HrnDjxoCerLOe3 E7_FDFwJAh16fA6KrQSKTbSM3sb4rcflYoDfrZa_VyVoRpIg8.ZGdQl.FCRg9Tf7CpzhMGLAEARJ zmXpMh4QfV3SA.BWDwKOCeQ-- X-Sonic-MF: Message-ID: <00ff4875-62e0-05c8-a13e-5a52d4195cc2@aol.com> Date: Fri, 6 Jan 2023 20:08:46 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v2 6/6] hw/isa/piix: Resolve redundant TYPE_PIIX3_XEN_DEVICE From: Chuck Zmudzinski To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Bernhard Beschow , qemu-devel@nongnu.org, Markus Armbruster Cc: Richard Henderson , Stefano Stabellini , xen-devel@lists.xenproject.org, =?UTF-8?Q?Herv=c3=a9_Poussineau?= , Aurelien Jarno , Paul Durrant , Marcel Apfelbaum , Anthony Perard , "Michael S. Tsirkin" , Paolo Bonzini , Eduardo Habkost , Thomas Huth References: <20230104144437.27479-1-shentey@gmail.com> <20230104144437.27479-7-shentey@gmail.com> <1c2e0780-e5fb-1321-0d84-b0591db9fec7@linaro.org> <6a1a6ed8-568d-c08b-91a7-1093a2b25929@linaro.org> <30337c62-a938-61c8-3ae5-092dbccf6302@aol.com> Content-Language: en-US In-Reply-To: <30337c62-a938-61c8-3ae5-092dbccf6302@aol.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.20982 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 3627 On 1/6/23 6:04 PM, Chuck Zmudzinski wrote: > On 1/6/23 2:08 PM, Chuck Zmudzinski wrote: >> On 1/6/23 7:25 AM, Philippe Mathieu-Daudé wrote: >>> On 6/1/23 12:57, Bernhard Beschow wrote: >>>> >>>> >>>> Am 4. Januar 2023 15:35:33 UTC schrieb "Philippe Mathieu-Daudé" : >>>>> +Markus/Thomas >>>>> >>>>> On 4/1/23 15:44, Bernhard Beschow wrote: >>>>>> During the last patches, TYPE_PIIX3_XEN_DEVICE turned into a clone of >>>>>> TYPE_PIIX3_DEVICE. Remove this redundancy. >>>>>> >>>>>> Signed-off-by: Bernhard Beschow >>>>>> --- >>>>>> hw/i386/pc_piix.c | 4 +--- >>>>>> hw/isa/piix.c | 20 -------------------- >>>>>> include/hw/southbridge/piix.h | 1 - >>>>>> 3 files changed, 1 insertion(+), 24 deletions(-) >>> >>> >>>>>> -static void piix3_xen_class_init(ObjectClass *klass, void *data) >>>>>> -{ >>>>>> - DeviceClass *dc = DEVICE_CLASS(klass); >>>>>> - PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); >>>>>> - >>>>>> - k->realize = piix3_realize; >>>>>> - /* 82371SB PIIX3 PCI-to-ISA bridge (Step A1) */ >>>>>> - k->device_id = PCI_DEVICE_ID_INTEL_82371SB_0; >>>>>> - dc->vmsd = &vmstate_piix3; >>>>> >>>>> IIUC, since this device is user-creatable, we can't simply remove it >>>>> without going thru the deprecation process. >>>> >>>> AFAICS this device is actually not user-creatable since dc->user_creatable is set to false once in the base class. I think it is safe to remove the Xen class unless there are ABI issues. >>> Great news! >> >> I don't know if this means the device is user-creatable: >> >> chuckz@bullseye:~$ qemu-system-i386 -device piix3-ide-xen,help >> piix3-ide-xen options: >> addr= - Slot and optional function number, example: 06.0 or 06 (default: -1) >> failover_pair_id= >> multifunction= - on/off (default: false) >> rombar= - (default: 1) >> romfile= >> x-pcie-extcap-init= - on/off (default: true) >> x-pcie-lnksta-dllla= - on/off (default: true) >> >> Today I am running qemu-5.2 on Debian 11, so this output is for >> qemu 5.2, and that version of qemu has a piix3-ide-xen device. >> Is that this same device that is being removed? If so, it seems to >> me that at least as of qemu 5.2, the device was user-creatable. >> >> Chuck > > Good news! It looks the device was removed as user-creatable since version 5.2: > > chuckz@debian:~$ qemu-system-i386-7.50 -device help | grep piix > name "piix3-usb-uhci", bus PCI > name "piix4-usb-uhci", bus PCI > name "piix3-ide", bus PCI > name "piix4-ide", bus PCI > chuckz@debian:~$ qemu-system-i386-7.50-bernhard-v2 -device help | grep piix > name "piix3-usb-uhci", bus PCI > name "piix4-usb-uhci", bus PCI > name "piix3-ide", bus PCI > name "piix4-ide", bus PCI > chuckz@debian:~$ > > The piix3-ide-xen device is not present either with or without Bernhard's patches > for current qemu 7.50, the development version for qemu 8.0 > > Cheers, > > Chuck I traced where the pciix3-ide-xen device was removed: It was 7851b21a81 (hw/ide/piix: Remove redundant "piix3-ide-xen" device class) https://gitlab.com/qemu-project/qemu/-/commit/7851b21a8192750adecbcf6e8780a20de5891ad6 about six months ago. That was between 7.0 and 7.1. So the device being removed here is definitely not user-creatable, but it appears that this piix3-ide-xen device that was removed between 7.0 and 7.1 was user-creatable. Does that one need to go through the deprecation process? Or, since no one has complained it is gone, maybe we don't need to worry about it? Cheers, Chuck From xen-devel-bounces@lists.xenproject.org Sat Jan 07 02:20:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 Jan 2023 02:20:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472924.733348 (Exim 4.92) (envelope-from ) id 1pDyoz-0007gU-3K; Sat, 07 Jan 2023 02:20:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472924.733348; Sat, 07 Jan 2023 02:20:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDyoy-0007gN-V3; Sat, 07 Jan 2023 02:20:32 +0000 Received: by outflank-mailman (input) for mailman id 472924; Sat, 07 Jan 2023 02:20:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDyoy-0007fx-6p; Sat, 07 Jan 2023 02:20:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDyoy-0004Cl-4R; Sat, 07 Jan 2023 02:20:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDyox-0000QX-FT; Sat, 07 Jan 2023 02:20:31 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pDyox-0003Mw-E6; Sat, 07 Jan 2023 02:20:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=isJGOt6dK2DTswjT/fAFqEH7SItEwJJE2GVNAf5yLM8=; b=hSOKNGRE2TRnIOElklDjawRC/K ZrwRxEixIkQyK+h/pxBf3S2l/1JvNtB05kJtsBSV+gytaUpMtVDOSlbwStHfhd0q6k3V90uK2Ycqg PCKolLWH0WOMC/1xLynNdeUQLP0jHVKAxM/YGfmDWtCuBobgYy896JHVmHnYEGo8e96U=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 175605: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=1f5abbd77e2c1787e74b7c2caffac97def78ba52 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Sat, 07 Jan 2023 02:20:31 +0000 flight 175605 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/175605/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine 8 reboot fail REGR. vs. 173462 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux 1f5abbd77e2c1787e74b7c2caffac97def78ba52 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 91 days Failing since 173470 2022-10-08 06:21:34 Z 90 days 189 attempts Testing same since 175599 2023-01-06 07:05:33 Z 0 days 2 attempts ------------------------------------------------------------ 3293 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 501982 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Jan 07 02:23:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 Jan 2023 02:23:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472934.733359 (Exim 4.92) (envelope-from ) id 1pDyrQ-0008LZ-K7; Sat, 07 Jan 2023 02:23:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472934.733359; Sat, 07 Jan 2023 02:23:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDyrQ-0008LS-Gn; Sat, 07 Jan 2023 02:23:04 +0000 Received: by outflank-mailman (input) for mailman id 472934; Sat, 07 Jan 2023 02:23:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pDyrO-0008LG-Q0 for xen-devel@lists.xenproject.org; Sat, 07 Jan 2023 02:23:02 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on2077.outbound.protection.outlook.com [40.107.8.77]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 34b0843e-8e32-11ed-91b6-6bf2151ebd3b; Sat, 07 Jan 2023 03:23:00 +0100 (CET) Received: from AS9PR06CA0780.eurprd06.prod.outlook.com (2603:10a6:20b:484::35) by DU2PR08MB10187.eurprd08.prod.outlook.com (2603:10a6:10:46d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.7; Sat, 7 Jan 2023 02:22:57 +0000 Received: from AM7EUR03FT032.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:484:cafe::91) by AS9PR06CA0780.outlook.office365.com (2603:10a6:20b:484::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Sat, 7 Jan 2023 02:22:56 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT032.mail.protection.outlook.com (100.127.140.65) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.14 via Frontend Transport; Sat, 7 Jan 2023 02:22:56 +0000 Received: ("Tessian outbound 43b0faad5a68:v132"); Sat, 07 Jan 2023 02:22:56 +0000 Received: from d27c0665e07f.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C4C22D3F-99C7-4350-BC67-73FC8926E703.1; Sat, 07 Jan 2023 02:22:46 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d27c0665e07f.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sat, 07 Jan 2023 02:22:46 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AS8PR08MB8994.eurprd08.prod.outlook.com (2603:10a6:20b:5b3::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.9; Sat, 7 Jan 2023 02:22:43 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::d1d7:166d:6c34:d19e]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::d1d7:166d:6c34:d19e%4]) with mapi id 15.20.5986.007; Sat, 7 Jan 2023 02:22:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 34b0843e-8e32-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Coaca47qk/N0rae4zzA1XwE4RCQ6I/ay8ADLcscw32E=; b=VsaGRwJvXJFxwkRCGFCGYDVFjQu5FdAxmZiEwd8ZRLLHkHSaKQQglwQn4OV8E5OCcCcrKA/IzVK1Fe18/XMnZvFK/IXAMeLB58maLDLcMreD3/5i1MlvAvzl6Ku6GCOKw/WLmucEBKQFucmyZWIn7Mopej3vEodGf7a3fiCG5Z8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cC9oGbMlyeECtaoiA/sxan9Rpy03LjTF+hP89PiRyZuhDHWOkQPoSksFa3z0SzzjAajHYbY2DVCIN3SapmMDOuf0dGml2rivc5F1yc//vuTZ03LtQp8HjTXweKqvFU6DXnrMMijZhi9NriIm/IuD3K2l0SCBTZpqlcQN5sc+0s9n4M+3Bb6ePSJT+aIVwpQj9SLba4SuCjSJ2yrpIvHJX8W58J1IsLhXvOFavFTj6wC3uVYuwYpVRMTL02Q2oO6qLvp0gTrm5IqQOFWi1aGid1Gi4tDzOoJPDf0c6pKxWquVscmZwx6lBkck7AHlyuhya94oRGa7IEVTLtGYbg6L4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Coaca47qk/N0rae4zzA1XwE4RCQ6I/ay8ADLcscw32E=; b=BuMTaCce4+5ReNlA4XyGcL3rD6h1ALsTl7sKO8m6oOSwvxWQ5kCxKLphFQUKVnSzxQxNbO/D9sJpusyJL8EVChGT4A1OohqnRvi/5C7Mb6bi0P02iFvJIKUfqVCRvCv0gh/Q9qtpsBZaLi3GnZ8xhCK7m+qdOSIwZ2DvInUl1x7+m7Qn9b+YVSZrLdaKW79RBKZ8vj4BWZegDqhL5HT6aiZqGvChV0A9Bh9n/ctPZLdYqvQEuYce24m20050ht5Pp55ZjxWOlxPoRoEJbPzrOxx44vJdob60Rj1rIcG0U3VkpIyZ+1z7pqQc7ukxk6y/IJd4qogRG+409l+Htgs87w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Coaca47qk/N0rae4zzA1XwE4RCQ6I/ay8ADLcscw32E=; b=VsaGRwJvXJFxwkRCGFCGYDVFjQu5FdAxmZiEwd8ZRLLHkHSaKQQglwQn4OV8E5OCcCcrKA/IzVK1Fe18/XMnZvFK/IXAMeLB58maLDLcMreD3/5i1MlvAvzl6Ku6GCOKw/WLmucEBKQFucmyZWIn7Mopej3vEodGf7a3fiCG5Z8= From: Henry Wang To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH 20/22] xen/arm64: mm: Use per-pCPU page-tables Thread-Topic: [PATCH 20/22] xen/arm64: mm: Use per-pCPU page-tables Thread-Index: AQHZEUh12RKmuw645EafAVdnfeFYOK6RkuHggAAV9gCAALFqIA== Date: Sat, 7 Jan 2023 02:22:42 +0000 Message-ID: References: <20221216114853.8227-1-julien@xen.org> <20221216114853.8227-21-julien@xen.org> <9c9099e2-dd7a-db37-4d0c-38f1dd8d3e48@xen.org> In-Reply-To: <9c9099e2-dd7a-db37-4d0c-38f1dd8d3e48@xen.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 671A181F4710F64494B838F57762C79B.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|AS8PR08MB8994:EE_|AM7EUR03FT032:EE_|DU2PR08MB10187:EE_ X-MS-Office365-Filtering-Correlation-Id: 065b479d-d2e0-4b80-1e7d-08daf05616b0 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: IQPiaSb+jdMZz4yZRL3EWx/2gGIGO5OfcCNPZCOn1EKHx+3v8D9TaH0PkwIjdQnUixV0MIKPcnNpeSw3BhP3JH95I5R/AdjfZOWwhdOkymJrYJTjI/zGfH5woIQrscDtZt5CodMjk7NJvcBJoB4lCPVBZqpw/vW5aDar98dMRrqH5RNwOkxfV77qDiRzOm4tBVS/haBZ66UwcymlTIGjEgCJpKQZJSXg/WD3i3YRrHKuNB1GB6+oPRhc1mOPVcBdCxYEzlQXu+Rxp9Eyhh+3o14wV8UyizsxQhZPfkMbrAtfQAwM6pGoTYKSlbJtL5bR24e/k0NhoiYudNc+Bjg8AhcHulrThxmbbitWZKn89fxo7sMQBok/BJ7M7HJJpvIXZxsDUMil7g06PKInsGl42tRlDUSuwF3wWBpP/f2H9nSvMxCswboynCCqDiZU408W4sL4vltg5AmMwZn6FK//yr+sD2Va2kZ8uv4lSSmlyF8d6McZnZQJXb6KzO+8BZ1AyrIfKPxJGOkfR/OM2V49sLYC8yS0KujKK6DEsxNCWyuYOO5cnVYMf/lj2Ue7+a0pmrEEJrLj5pWpMqD6MWTS9fOAxMQ5/gqRnvoeUPG8hq402XESNTy3TYHmPJiIyFXTeyefbKfscT21L+2TC6OcAhhFDdSEN7QjNiZn85OgmoCvIRlnJeX8t3TpL8P2sUdZWkq3rn/WTI4KhBG4hXaXOg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(366004)(346002)(376002)(136003)(451199015)(55016003)(9686003)(122000001)(86362001)(26005)(186003)(71200400001)(7696005)(478600001)(8676002)(66476007)(52536014)(66556008)(66446008)(64756008)(8936002)(66946007)(76116006)(4326008)(41300700001)(5660300002)(316002)(110136005)(2906002)(38100700002)(54906003)(6506007)(38070700005)(33656002)(83380400001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8994 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT032.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 5710ed0f-43c6-44d8-b70f-08daf0560e48 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZozwVpDQVhqmME44eo7KZIQccbSkMEOiGwhAVZKqIeOzW3Ih/3QYVbFGFhDtxpLFM8AFX0zWPM83HCwOKlgyI+1OBu1Yu8TQWC7fLb76VBPx0tVtdGtpqyePD2YNvSTiW/pKKioQcMFMHZdipVv09/BiZujRGgHdoEc9Bt2kjaT5TZj1T3Wb6ztapXMqnuwM1jE7kow298/LK3HZkXkYoDhxsnA6yk4XHbcR7wARvZnPNEMS0YgPfu7II6SRzTjalggYTTjTbbZIscOxAYIThHoTqWt5oSvEj3KmVyk34L9KRep3nTVdFrsbxgi6nc5ra0wkapHwiPz+OyMptRqHdHJM8XKtUE/e4vCIGutdQUXUmbtP5JxJk3h+QtY5Syz70tQRUNvVBE22ilvta3dpQ9khD7CvShp6JA3weGrIbuP2qHVR3sgMLkujoOf0GhnXY2wT3wm5lnYAnRy2yhob0iFM+vpe8vb41y8U6hxjt9APvjqvC9/66bB29dkw0ri5o9GatP9J1+nZsIsxVd36xI218D2dIbhqzAjFWEx7TEmahHi1zVF0jmtVjmXAL8XeT2AhSHtg/0efoeevLHOUBfvCeFUfKyi9d9BNb451gKLB04vKGIOuhYkl8HHBiSfjagBZFbhKDGpuN7aP6iTFCkGCyXwekVvYfZ68XGZyp3lgf246YaYWAGVU9sLEumR7lFKU2UDjVA4X2BEuozYT+Q== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(346002)(396003)(376002)(451199015)(40470700004)(36840700001)(46966006)(8936002)(52536014)(5660300002)(70586007)(7696005)(9686003)(8676002)(70206006)(41300700001)(186003)(26005)(4326008)(54906003)(110136005)(478600001)(356005)(33656002)(83380400001)(316002)(40460700003)(2906002)(47076005)(336012)(55016003)(86362001)(40480700001)(6506007)(82310400005)(107886003)(81166007)(82740400003)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jan 2023 02:22:56.4216 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 065b479d-d2e0-4b80-1e7d-08daf05616b0 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT032.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR08MB10187 SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IFN1YmplY3Q6IFJl OiBbUEFUQ0ggMjAvMjJdIHhlbi9hcm02NDogbW06IFVzZSBwZXItcENQVSBwYWdlLXRhYmxlcw0K PiANCj4gSGkgSGVucnksDQo+IA0KPiA+PiBTdWJqZWN0OiBbUEFUQ0ggMjAvMjJdIHhlbi9hcm02 NDogbW06IFVzZSBwZXItcENQVSBwYWdlLXRhYmxlcw0KPiA+Pg0KPiA+PiBGcm9tOiBKdWxpZW4g R3JhbGwgPGpncmFsbEBhbWF6b24uY29tPg0KPiA+Pg0KPiA+PiBBdCB0aGUgbW9tZW50LCBvbiBB cm02NCwgZXZlcnkgcENQVSBhcmUgc2hhcmluZyB0aGUgc2FtZSBwYWdlLXRhYmxlcy4NCj4gPg0K PiA+IE5pdDogcy9ldmVyeSBwQ1BVIGFyZS8gZXZlcnkgcENQVSBpcy8NCj4gDQo+IEkgd2lsbCBm aXggaXQuDQoNClRoYW5rIHlvdS4NCg0KPiANCj4gPj4gK2Jvb2wgaW5pdF9kb21oZWFwX21hcHBp bmdzKHVuc2lnbmVkIGludCBjcHUpOw0KPiA+DQo+ID4gSSB3b25kZXIgaWYgd2UgY2FuIG1ha2Ug dGhpcyBmdW5jdGlvbiAiX19pbml0IiBhcyBJSVJDIHRoaXMgZnVuY3Rpb24gaXMgb25seQ0KPiA+ IHVzZWQgYXQgWGVuIGJvb3QgdGltZSwgYnV0IHNpbmNlIHRoZSBvcmlnaW5hbCBpbml0X2RvbWhl YXBfbWFwcGluZ3MoKQ0KPiA+IGlzIG5vdCAiX19pbml0IiBhbnl3YXkgc28gdGhpcyBpcyBub3Qg YSBzdHJvbmcgYXJndW1lbnQuDQo+IA0KPiBXaGlsZSB0aGlzIGlzIG5vdCB5ZXQgc3VwcG9ydGVk IG9uIFhlbiBvbiBBcm0sIENQVXMgY2FuIGJlDQo+IG9ubGluZWQvb2ZmbGluZWQgYXQgcnVudGlt ZS4gU28geW91IHdhbnQgdG8ga2VlcCBpbml0X2RvbWhlYXBfbWFwcGluZ3MoKQ0KPiBhcm91bmQu DQoNClRoaXMgaXMgYSB2ZXJ5IGdvb2QgcG9pbnQuIEkgYWdyZWUgdGhlIHBDUFUgb25saW5lL29m ZmxpbmUgaXMgYWZmZWN0ZWQgYnkgdGhlDQoiX19pbml0IiBzbyBsZWF2aW5nIHRoZSBmdW5jdGlv biB3aXRob3V0IHRoZSAiX19pbml0IiBsaWtlIHdoYXQgd2UgYXJlIGRvaW5nDQpub3cgaXMgYSBn b29kIGlkZWEuDQoNCj4gDQo+IFdlIGNvdWxkIGNvbnNpZGVyIHRvIHByb3ZpZGUgYSBuZXcgYXR0 cmlidXRlIHRoYXQgd2lsbCBiZSBtYXRjaCBfX2luaXQNCj4gaWYgaG90cGx1ZyBpcyBzdXBwb3J0 ZWQgb3RoZXJ3aXJzZSBpdCB3b3VsZCBiZSBhIE5PUC4gQnV0IEkgZG9uJ3QgdGhpbmsNCj4gdGhp cyBpcyByZWxhdGVkIHRvIHRoaXMgc2VyaWVzIChtb3N0IG9mIHRoZSBmdW5jdGlvbiB1c2VkIGZv ciBicmluZ3VwDQo+IGFyZSBub3QgaW4gX19pbml0KS4NCg0KQWdyZWVkLg0KDQo+IA0KPiA+PiAr c3RhdGljIGlubGluZSBib29sIGluaXRfZG9taGVhcF9tYXBwaW5ncyh1bnNpZ25lZCBpbnQgY3B1 KQ0KPiA+DQo+ID4gKGFuZCBhbHNvIGhlcmUpDQo+ID4NCj4gPiBFaXRoZXIgeW91IGFncmVlIHdp dGggYWJvdmUgIl9faW5pdCIgY29tbWVudCBvciBub3Q6DQo+ID4gUmV2aWV3ZWQtYnk6IEhlbnJ5 IFdhbmcgPEhlbnJ5LldhbmdAYXJtLmNvbT4NCj4gDQo+IFRoYW5rcyENCg0KTm8gcHJvYmxlbS4g VG8gYXZvaWQgY29uZnVzaW9uLCBteSByZXZpZXdlZC1ieSB0YWcgc3RpbGwgaG9sZHMuDQoNCktp bmQgcmVnYXJkcywNCkhlbnJ5DQoNCj4gDQo+IENoZWVycywNCj4gDQo+IC0tDQo+IEp1bGllbiBH cmFsbA0K From xen-devel-bounces@lists.xenproject.org Sat Jan 07 03:51:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 Jan 2023 03:51:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472942.733373 (Exim 4.92) (envelope-from ) id 1pE0F2-0000JC-VH; Sat, 07 Jan 2023 03:51:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472942.733373; Sat, 07 Jan 2023 03:51:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pE0F2-0000J5-RJ; Sat, 07 Jan 2023 03:51:32 +0000 Received: by outflank-mailman (input) for mailman id 472942; Sat, 07 Jan 2023 03:51:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pE0F1-0000Iv-K1; Sat, 07 Jan 2023 03:51:31 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pE0F1-0006ED-HT; Sat, 07 Jan 2023 03:51:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pE0F1-0003Wb-1a; Sat, 07 Jan 2023 03:51:31 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pE0F1-00077S-0g; Sat, 07 Jan 2023 03:51:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=7yE10MTh8AUkLs7RuHSs2Em5Pcv9PvfdeglSPP/cc8Q=; b=LM5rBbEU5EqQcl1Kp/giigi7Zi PEO2+R0C0UZxyPwQmo0+3kBy9AwKEVLldUeSbWMlgUo8MLRSzX93TOSCRTAgFz3xIsi3tp1umjO6W YPocoaGJJNG3IoQ6AcCOFWGQ4h9FNa9rwE2exCpU9+5h6z65B2M6uHmN7zRELquc2BNk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 175610: regressions - trouble: broken/fail/pass X-Osstest-Failures: qemu-mainline:test-amd64-amd64-pair::broken:regression qemu-mainline:test-amd64-amd64-pair:host-install/src_host(6):broken:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression qemu-mainline:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=171033e8dbac356f9a84c2e7cc8556a4eb0a1359 X-Osstest-Versions-That: qemuu=d1852caab131ea898134fdcea8c14bc2ee75fbe9 From: osstest service owner Date: Sat, 07 Jan 2023 03:51:31 +0000 flight 175610 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/175610/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-pair broken test-amd64-amd64-pair 6 host-install/src_host(6) broken REGR. vs. 175595 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 175595 test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail REGR. vs. 175595 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 175595 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 175595 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175595 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175595 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 175595 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 175595 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175595 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175595 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu 171033e8dbac356f9a84c2e7cc8556a4eb0a1359 baseline version: qemuu d1852caab131ea898134fdcea8c14bc2ee75fbe9 Last test of basis 175595 2023-01-06 01:55:04 Z 1 days Failing since 175603 2023-01-06 12:10:38 Z 0 days 2 attempts Testing same since 175610 2023-01-06 22:08:24 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alessandro Di Federico Alex Bennée Axel Heider Claudio Fontana Fabiano Rosas Jean-Christophe Dubois Marco Liebel Matheus Tavares Bernardino Mukilan Thiyagarajan Peter Maydell Philippe Mathieu-Daudé Richard Henderson Stephen Longfield Taylor Simpson Tobias Röhmel Zhuojia Shen jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair broken test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-pair broken broken-step test-amd64-amd64-pair host-install/src_host(6) Not pushing. (No revision log; it would be 820 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Jan 07 08:44:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 Jan 2023 08:44:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472956.733384 (Exim 4.92) (envelope-from ) id 1pE4oD-0003ir-Og; Sat, 07 Jan 2023 08:44:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472956.733384; Sat, 07 Jan 2023 08:44:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pE4oD-0003ik-LI; Sat, 07 Jan 2023 08:44:09 +0000 Received: by outflank-mailman (input) for mailman id 472956; Sat, 07 Jan 2023 08:44:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pE4oC-0003ia-I5; Sat, 07 Jan 2023 08:44:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pE4oC-0005Dg-Fe; Sat, 07 Jan 2023 08:44:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pE4oB-00024m-TS; Sat, 07 Jan 2023 08:44:08 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pE4oB-0003A7-T0; Sat, 07 Jan 2023 08:44:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=iZSRkKUV23tjtvK8xwFvzH9D6U2Z6zcalKGHFEuwNxA=; b=OC2f2rmOaZQmruLyb/INxZs1P2 dUXEBmCublOqyAZEJjXO+vFbZqGUZ/eDLt55W4xQLOkZlcW8LP0XRX+6tje8JQOcihUI+tmRQKy3+ WtQsPf5a3CrnJy2YCOI14HTnU1J3CzFc/EbCi3hzLoeD/J3PNKmBX1Y7OfkcI0FtUICg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 175612: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-i386-xl-shadow:xen-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=2b21cbbb339fb14414f357a6683b1df74c36fda2 X-Osstest-Versions-That: xen=2b21cbbb339fb14414f357a6683b1df74c36fda2 From: osstest service owner Date: Sat, 07 Jan 2023 08:44:07 +0000 flight 175612 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/175612/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail in 175601 pass in 175612 test-amd64-i386-xl-shadow 7 xen-install fail pass in 175601 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail pass in 175601 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 175601 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175601 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 175601 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175601 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175601 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 175601 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail like 175601 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 175601 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 175601 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 175601 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 175601 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175601 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 175601 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen 2b21cbbb339fb14414f357a6683b1df74c36fda2 baseline version: xen 2b21cbbb339fb14414f357a6683b1df74c36fda2 Last test of basis 175612 2023-01-07 01:52:11 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Sat Jan 07 10:59:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 Jan 2023 10:59:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472965.733394 (Exim 4.92) (envelope-from ) id 1pE6uS-00083F-E2; Sat, 07 Jan 2023 10:58:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472965.733394; Sat, 07 Jan 2023 10:58:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pE6uS-000838-BI; Sat, 07 Jan 2023 10:58:44 +0000 Received: by outflank-mailman (input) for mailman id 472965; Sat, 07 Jan 2023 10:58:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pE6uQ-000832-Aq for xen-devel@lists.xenproject.org; Sat, 07 Jan 2023 10:58:42 +0000 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [2a00:1450:4864:20::632]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3e1d6bce-8e7a-11ed-91b6-6bf2151ebd3b; Sat, 07 Jan 2023 11:58:40 +0100 (CET) Received: by mail-ej1-x632.google.com with SMTP id qk9so8872544ejc.3 for ; Sat, 07 Jan 2023 02:58:40 -0800 (PST) Received: from ?IPv6:::1? (p200300faaf0bb200f901f42a62c21174.dip0.t-ipconnect.de. [2003:fa:af0b:b200:f901:f42a:62c2:1174]) by smtp.gmail.com with ESMTPSA id gc22-20020a1709072b1600b007c127e1511dsm1312119ejc.220.2023.01.07.02.58.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 07 Jan 2023 02:58:39 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3e1d6bce-8e7a-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=ojbJNP36CvrRWo22zSn32zK2y/pXsV+Mmkw5xGIK2Pg=; b=hEtdA4nME3eNcpjNgQ3F3dCNDNRy3K91tNQWFFKz8eYVdhYNamrTCdnub5/2uK22E+ otuEYgoHszVpnjT9ZZToFJ8dMPn51ocD2GU6W1XXPFU8K1W7fdCPCVQfr5x49H1hccF5 Zpi7ZlFeLP38+URxOL0BU6WLqVOb3aoNbhZnQLJYmldB8fDj8Uaz+0Pd2ApDbvpHbkqE 3k4WJogU4GwnqqrjLd2PO98f2IJw9TdGJaUWtJEQykq7lt3ujr4QNbgZ70Rn+cyqeji4 o/eX4vLZShAc+aj/A2DxCCcQIka9T3jPGFmN6I7Q9cwgwDhjA48MfPZbdF0CvnneLS8r H3iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ojbJNP36CvrRWo22zSn32zK2y/pXsV+Mmkw5xGIK2Pg=; b=jO3w1IFBlK/bMO2QDgTD/eT/GHzf4aOcXlpe7a9M693d2gKRDJUDQEq1JN6HHfkZum ZRFHU9EP9AKzswLYZK17QTBv9txH1vAYuoHl+o6Y6IxGuqaKdat5EIDU2LZo4BJnyKuK 83TMggy26xNpa8LEpwf1f/nK9uEGY4DAZLY9lmO2tJZkMtLv+PI/mnEP58ra4YssGRN3 1vgHStSyCGmI7PcSriU8L2K/MK12kezkccbuhM3Lp+M5iPFZRY7am7neKTV5BCXDXH6y QB28dRnQphrGQQ7/qxiGjWO6XBRHkmTUx/F2PInl0cPcyLCfe4rQ34vGo4uZSaVE8oXh QHbg== X-Gm-Message-State: AFqh2kqRdEcNnaJWw+RBhydkpZ6bxyDLOPgDbNKLRJrN54GmyFwwZLfB 6+JZEwhXwPI+hk/AJ46Io/I= X-Google-Smtp-Source: AMrXdXuVhiLxEGrharK3dUjrwBfNTxBrdm5SiG2nGWJW4zBv8CB5mvtoicCvREcZjQt+b9feh78vcw== X-Received: by 2002:a17:906:4a0c:b0:7c1:3018:73b6 with SMTP id w12-20020a1709064a0c00b007c1301873b6mr49497559eju.61.1673089119432; Sat, 07 Jan 2023 02:58:39 -0800 (PST) Date: Sat, 07 Jan 2023 10:58:29 +0000 From: Bernhard Beschow To: David Woodhouse , qemu-devel@nongnu.org CC: Richard Henderson , Stefano Stabellini , xen-devel@lists.xenproject.org, =?ISO-8859-1?Q?Herv=E9_Poussineau?= , Aurelien Jarno , Paul Durrant , Marcel Apfelbaum , Anthony Perard , "Michael S. Tsirkin" , Paolo Bonzini , Eduardo Habkost , =?ISO-8859-1?Q?Philippe_Mathieu-Daud=E9?= , Chuck Zmudzinski Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_v2_3/6=5D_hw/isa/piix=3A_Wire_u?= =?US-ASCII?Q?p_Xen_PCI_IRQ_handling_outside_of_PIIX3?= In-Reply-To: References: <20230104144437.27479-1-shentey@gmail.com> <20230104144437.27479-4-shentey@gmail.com> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Am 6=2E Januar 2023 17:35:18 UTC schrieb David Woodhouse : >On Wed, 2023-01-04 at 15:44 +0100, Bernhard Beschow wrote: >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (xen_enabled()) { > >Could this perhaps be if (xen_mode !=3D XEN_DISABLED) once we merge the >Xen-on-KVM series? It's the same condition which selected TYPE_PIIX3_XEN_DEVICE until the las= t patch of this series=2E If you had to change this condition in your serie= s then just perform the same change here instead=2E Best regards, Bernhard From xen-devel-bounces@lists.xenproject.org Sat Jan 07 11:05:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 Jan 2023 11:05:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472972.733405 (Exim 4.92) (envelope-from ) id 1pE713-00015O-3m; Sat, 07 Jan 2023 11:05:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472972.733405; Sat, 07 Jan 2023 11:05:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pE713-00015H-12; Sat, 07 Jan 2023 11:05:33 +0000 Received: by outflank-mailman (input) for mailman id 472972; Sat, 07 Jan 2023 11:05:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pE710-00015B-UR for xen-devel@lists.xenproject.org; Sat, 07 Jan 2023 11:05:31 +0000 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [2a00:1450:4864:20::635]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 32360c36-8e7b-11ed-91b6-6bf2151ebd3b; Sat, 07 Jan 2023 12:05:29 +0100 (CET) Received: by mail-ej1-x635.google.com with SMTP id t17so8899430eju.1 for ; Sat, 07 Jan 2023 03:05:29 -0800 (PST) Received: from ?IPv6:::1? (p200300faaf0bb200f901f42a62c21174.dip0.t-ipconnect.de. [2003:fa:af0b:b200:f901:f42a:62c2:1174]) by smtp.gmail.com with ESMTPSA id kw16-20020a170907771000b007adf2e4c6f7sm1310121ejc.195.2023.01.07.03.05.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 07 Jan 2023 03:05:28 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 32360c36-8e7b-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=p8znfIc5uTd1Ou5iVaebPJV/Az3nHisy/UQuipCCwyg=; b=pqpQ25EjgFzgKfoRnFjp4IMjSfLb5H/CQhHcoDR5YRXx0SOr1BzR8t8EpmRE81BL+y 0fiilZA4Bk9IEa39roFI0tL6WUtpsoPVtYCWDLw8uJeHLCd6s6UJjmcBXZdkkHISzxap wEyq9X0AuXWbDNZ2hti48n52SfyGxB00FYO+iOM62mykAeC/pMmJHfLhEcdihyxpPYeA jLuSjCv0+dzzl0tBD/9xKOCdERm1P10utZIxHMAU2EbzzTeICPQSfJWPrBjt8RjsuVRu xRfWnTSjBzUPeFB0HyrfDh9bESZN0jwLXfIiZ9p9Qr/eoO0qypGzTEAaOqbPevWY5MrS UWOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=p8znfIc5uTd1Ou5iVaebPJV/Az3nHisy/UQuipCCwyg=; b=xf/fdf7lPeLHZwrjtFzOLPlB/Q++Gf36eSuCxXu1a7+/zmQ4G7pmTUEmyJUyJq9OTG XhCat0KqfTZ+sjhUmnKpv3Bi+KuRu1GseyhPeUql2Es/OQ8JFyP1WEJK/efTREQylxGq /gIufvok9XKlOvgVC8vYf1l04Fkb84e8zdEv5NcRNs1UrumZT0oM4aOow6RffbjxVQ6k IS8iDpULQSQxP79zqcpjxXPr7cU2tzDSOLM/UE0AqDUKNq9E2A8fwtrjykjstkrEANrD LhvWKqEB+p9ZnaoDOEBk/fwOfY6dyCBF3YAi8wVA3LabmvyIYctUDwbdfY8jUhVYDedY 5+Hg== X-Gm-Message-State: AFqh2kriU6inNswU4Ctm4AE4eiHGDG+oAiTqhzQTq5r+ttT6qvZKAhQX rfmsz9pkCtvfpLKLKPPYxuY= X-Google-Smtp-Source: AMrXdXu3EvFsoaT/hHNtPJ6LgsuygrkUQxHjYjz32DZvgWWafo+QGIRF9hiULkUfK0ut69Re1Wwjvw== X-Received: by 2002:a17:906:883:b0:84d:134a:2076 with SMTP id n3-20020a170906088300b0084d134a2076mr7280855eje.44.1673089528882; Sat, 07 Jan 2023 03:05:28 -0800 (PST) Date: Sat, 07 Jan 2023 11:05:20 +0000 From: Bernhard Beschow To: Chuck Zmudzinski , =?ISO-8859-1?Q?Philippe_Mathieu-Daud=E9?= , qemu-devel@nongnu.org, Markus Armbruster CC: Richard Henderson , Stefano Stabellini , xen-devel@lists.xenproject.org, =?ISO-8859-1?Q?Herv=E9_Poussineau?= , Aurelien Jarno , Paul Durrant , Marcel Apfelbaum , Anthony Perard , "Michael S. Tsirkin" , Paolo Bonzini , Eduardo Habkost , Thomas Huth Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_v2_6/6=5D_hw/isa/piix=3A_Res?= =?US-ASCII?Q?olve_redundant_TYPE=5FPIIX3=5FXEN=5FDEVICE?= In-Reply-To: <00ff4875-62e0-05c8-a13e-5a52d4195cc2@aol.com> References: <20230104144437.27479-1-shentey@gmail.com> <20230104144437.27479-7-shentey@gmail.com> <1c2e0780-e5fb-1321-0d84-b0591db9fec7@linaro.org> <6a1a6ed8-568d-c08b-91a7-1093a2b25929@linaro.org> <30337c62-a938-61c8-3ae5-092dbccf6302@aol.com> <00ff4875-62e0-05c8-a13e-5a52d4195cc2@aol.com> Message-ID: <01A7F932-0DF1-4977-A111-0907A7FC6FF9@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Am 7=2E Januar 2023 01:08:46 UTC schrieb Chuck Zmudzinski : >On 1/6/23 6:04=E2=80=AFPM, Chuck Zmudzinski wrote: >> On 1/6/23 2:08=E2=80=AFPM, Chuck Zmudzinski wrote: >>> On 1/6/23 7:25=E2=80=AFAM, Philippe Mathieu-Daud=C3=A9 wrote: >>>> On 6/1/23 12:57, Bernhard Beschow wrote: >>>>>=20 >>>>>=20 >>>>> Am 4=2E Januar 2023 15:35:33 UTC schrieb "Philippe Mathieu-Daud=C3= =A9" : >>>>>> +Markus/Thomas >>>>>> >>>>>> On 4/1/23 15:44, Bernhard Beschow wrote: >>>>>>> During the last patches, TYPE_PIIX3_XEN_DEVICE turned into a clone= of >>>>>>> TYPE_PIIX3_DEVICE=2E Remove this redundancy=2E >>>>>>> >>>>>>> Signed-off-by: Bernhard Beschow >>>>>>> --- >>>>>>> hw/i386/pc_piix=2Ec | 4 +--- >>>>>>> hw/isa/piix=2Ec | 20 -------------------- >>>>>>> include/hw/southbridge/piix=2Eh | 1 - >>>>>>> 3 files changed, 1 insertion(+), 24 deletions(-) >>>>=20 >>>>=20 >>>>>>> -static void piix3_xen_class_init(ObjectClass *klass, void *dat= a) >>>>>>> -{ >>>>>>> - DeviceClass *dc =3D DEVICE_CLASS(klass); >>>>>>> - PCIDeviceClass *k =3D PCI_DEVICE_CLASS(klass); >>>>>>> - >>>>>>> - k->realize =3D piix3_realize; >>>>>>> - /* 82371SB PIIX3 PCI-to-ISA bridge (Step A1) */ >>>>>>> - k->device_id =3D PCI_DEVICE_ID_INTEL_82371SB_0; >>>>>>> - dc->vmsd =3D &vmstate_piix3; >>>>>> >>>>>> IIUC, since this device is user-creatable, we can't simply remove i= t >>>>>> without going thru the deprecation process=2E >>>>>=20 >>>>> AFAICS this device is actually not user-creatable since dc->user_cre= atable is set to false once in the base class=2E I think it is safe to remo= ve the Xen class unless there are ABI issues=2E >>>> Great news! >>>=20 >>> I don't know if this means the device is user-creatable: >>>=20 >>> chuckz@bullseye:~$ qemu-system-i386 -device piix3-ide-xen,help >>> piix3-ide-xen options: >>> addr=3D - Slot and optional function number, exampl= e: 06=2E0 or 06 (default: -1) >>> failover_pair_id=3D >>> multifunction=3D - on/off (default: false) >>> rombar=3D - (default: 1) >>> romfile=3D >>> x-pcie-extcap-init=3D - on/off (default: true) >>> x-pcie-lnksta-dllla=3D - on/off (default: true) >>>=20 >>> Today I am running qemu-5=2E2 on Debian 11, so this output is for >>> qemu 5=2E2, and that version of qemu has a piix3-ide-xen device=2E >>> Is that this same device that is being removed? If so, it seems to >>> me that at least as of qemu 5=2E2, the device was user-creatable=2E >>>=20 >>> Chuck >>=20 >> Good news! It looks the device was removed as user-creatable since vers= ion 5=2E2: >>=20 >> chuckz@debian:~$ qemu-system-i386-7=2E50 -device help | grep piix >> name "piix3-usb-uhci", bus PCI >> name "piix4-usb-uhci", bus PCI >> name "piix3-ide", bus PCI >> name "piix4-ide", bus PCI >> chuckz@debian:~$ qemu-system-i386-7=2E50-bernhard-v2 -device help | gre= p piix >> name "piix3-usb-uhci", bus PCI >> name "piix4-usb-uhci", bus PCI >> name "piix3-ide", bus PCI >> name "piix4-ide", bus PCI >> chuckz@debian:~$ >>=20 >> The piix3-ide-xen device is not present either with or without Bernhard= 's patches >> for current qemu 7=2E50, the development version for qemu 8=2E0 >>=20 >> Cheers, >>=20 >> Chuck > > >I traced where the pciix3-ide-xen device was removed: > >It was 7851b21a81 (hw/ide/piix: Remove redundant "piix3-ide-xen" device c= lass) > >https://gitlab=2Ecom/qemu-project/qemu/-/commit/7851b21a8192750adecbcf6e8= 780a20de5891ad6 > >about six months ago=2E That was between 7=2E0 and 7=2E1=2E So the device= being removed >here is definitely not user-creatable, but it appears that this piix3-ide= -xen >device that was removed between 7=2E0 and 7=2E1 was user-creatable=2E Doe= s that one >need to go through the deprecation process? Or, since no one has complain= ed >it is gone, maybe we don't need to worry about it? Good point! Looks like it fell through the cracks=2E=2E=2E There are voices who claim that this device and its non-Xen counterpart sh= ould have never been user-creatable in the firtst place: https://patchwork=2Ekernel=2Eorg/project/qemu-devel/patch/20190718091740= =2E6834-1-philmd@redhat=2Ecom/ Best regards, Bernhard > >Cheers, > >Chuck From xen-devel-bounces@lists.xenproject.org Sat Jan 07 13:34:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 Jan 2023 13:34:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472980.733417 (Exim 4.92) (envelope-from ) id 1pE9L6-0007IX-4b; Sat, 07 Jan 2023 13:34:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472980.733417; Sat, 07 Jan 2023 13:34:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pE9L6-0007IQ-1a; Sat, 07 Jan 2023 13:34:24 +0000 Received: by outflank-mailman (input) for mailman id 472980; Sat, 07 Jan 2023 13:34:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pE9L3-0007IG-V9; Sat, 07 Jan 2023 13:34:21 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pE9L3-0003LV-Ru; Sat, 07 Jan 2023 13:34:21 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pE9L3-0003Zi-Gq; Sat, 07 Jan 2023 13:34:21 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pE9L3-0004Ow-GP; Sat, 07 Jan 2023 13:34:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=JqunCl8n3bcebceswnm3DOO6Z30M9yvLbed2GUBTXhw=; b=lfnGrxzZs4VouedwrymubCSnFV sGn51UURwPNeU0YA7WDsmdy3F/Kc4FTZ4UdMFn7wQJJfeuqlXT7348qwD/KBfB5/ZJyQHWReGZIj6 4owkOPWnP45syHRIjb80b9VGF3hqIvupCk+v6qg7em4BUakkIxENx1v9m1kJqvQzxU1M=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 175615: tolerable all pass - PUSHED X-Osstest-Failures: libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: libvirt=7050dad5f92010720cc8e8b7d5c37eaad7696c5e X-Osstest-Versions-That: libvirt=6cd2b4e101cc0b60c6db83f763a08daea67ad6eb From: osstest service owner Date: Sat, 07 Jan 2023 13:34:21 +0000 flight 175615 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/175615/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 175597 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 175597 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 175597 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: libvirt 7050dad5f92010720cc8e8b7d5c37eaad7696c5e baseline version: libvirt 6cd2b4e101cc0b60c6db83f763a08daea67ad6eb Last test of basis 175597 2023-01-06 04:20:37 Z 1 days Testing same since 175615 2023-01-07 04:18:53 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jiang Jiacheng Jiri Denemark Martin Kletzander Michal Privoznik Peter Krempa Shaleen Bathla jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git 6cd2b4e101..7050dad5f9 7050dad5f92010720cc8e8b7d5c37eaad7696c5e -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sat Jan 07 14:15:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 Jan 2023 14:15:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472989.733427 (Exim 4.92) (envelope-from ) id 1pE9yt-0003CQ-6u; Sat, 07 Jan 2023 14:15:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472989.733427; Sat, 07 Jan 2023 14:15:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pE9yt-0003CJ-4G; Sat, 07 Jan 2023 14:15:31 +0000 Received: by outflank-mailman (input) for mailman id 472989; Sat, 07 Jan 2023 14:15:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pE9yr-0003C9-L2; Sat, 07 Jan 2023 14:15:29 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pE9yr-0004G1-HM; Sat, 07 Jan 2023 14:15:29 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pE9yq-0004SN-UL; Sat, 07 Jan 2023 14:15:29 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pE9yq-0005c7-Ts; Sat, 07 Jan 2023 14:15:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=B4K4Id2eUthO6Tz6qiP3YV2AMwGJ76ZcgnyMBb+giiE=; b=o0Y3KpFJHXZHeWb33i2m2rD+rM nIsM1a4xfU1o03CHOAfb80WqVSRahv/K6JZ4oHH44W0xdl9+3E1F0Vuchp8JC1EGp6l7gapsHE2ff qdkS+aR4RZV5iqcJ21uG+4sR8JNtKzXdvI5O3N6devH+vDKMfK7eNiD7yTz5SXO+X4N4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 175613: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=0a71553536d270e988580a3daa9fc87535908221 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Sat, 07 Jan 2023 14:15:28 +0000 flight 175613 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/175613/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine 8 reboot fail REGR. vs. 173462 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux 0a71553536d270e988580a3daa9fc87535908221 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 91 days Failing since 173470 2022-10-08 06:21:34 Z 91 days 190 attempts Testing same since 175613 2023-01-07 02:22:17 Z 0 days 1 attempts ------------------------------------------------------------ 3305 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 504416 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Jan 07 16:16:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 Jan 2023 16:16:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.472998.733439 (Exim 4.92) (envelope-from ) id 1pEBs9-0006yw-RB; Sat, 07 Jan 2023 16:16:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 472998.733439; Sat, 07 Jan 2023 16:16:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEBs9-0006yp-OE; Sat, 07 Jan 2023 16:16:41 +0000 Received: by outflank-mailman (input) for mailman id 472998; Sat, 07 Jan 2023 16:16:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEBs8-0006yL-RB; Sat, 07 Jan 2023 16:16:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEBs8-0007dJ-NN; Sat, 07 Jan 2023 16:16:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEBs8-0007ED-8r; Sat, 07 Jan 2023 16:16:40 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pEBs8-0002wK-8K; Sat, 07 Jan 2023 16:16:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=1a8hYTM5JnszGlchucaPY02b7ZSnksZ3SksDLDa2DuM=; b=SsTgAMgBhadDdFtMpqInY4UlLb Bh4qTSHXqvPkzsZLn1ZZyKNHg1+m7+vCqEZ+paA+pBbmPCzEqLuwADNvK/1/QkDKs1TqAziP/Iou/ jEMV1klEVz+XpGqPTOmwTiXF+D2wFkIRwmPKQkvL8R0uLaXtWvgzT99gx2JdLYtXtYpo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 175614: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=aaa90fede5d10e2a3c3fc7f2df608128d2cba761 X-Osstest-Versions-That: qemuu=d1852caab131ea898134fdcea8c14bc2ee75fbe9 From: osstest service owner Date: Sat, 07 Jan 2023 16:16:40 +0000 flight 175614 qemu-mainline real [real] flight 175617 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/175614/ http://logs.test-lab.xenproject.org/osstest/logs/175617/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail REGR. vs. 175595 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail pass in 175617-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 175595 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 175595 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175595 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175595 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 175595 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 175595 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175595 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175595 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu aaa90fede5d10e2a3c3fc7f2df608128d2cba761 baseline version: qemuu d1852caab131ea898134fdcea8c14bc2ee75fbe9 Last test of basis 175595 2023-01-06 01:55:04 Z 1 days Failing since 175603 2023-01-06 12:10:38 Z 1 days 3 attempts Testing same since 175614 2023-01-07 03:55:29 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alessandro Di Federico Alex Bennée Axel Heider Claudio Fontana Fabiano Rosas Ilya Leoshkevich Jean-Christophe Dubois Marco Liebel Mark Cave-Ayland Matheus Tavares Bernardino Mukilan Thiyagarajan Paolo Bonzini Peter Maydell Philippe Mathieu-Daudé Richard Henderson Stephen Longfield Taylor Simpson Tobias Röhmel Zhuojia Shen jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1486 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Jan 07 18:08:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 Jan 2023 18:08:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473009.733452 (Exim 4.92) (envelope-from ) id 1pEDcC-00011x-Sh; Sat, 07 Jan 2023 18:08:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473009.733452; Sat, 07 Jan 2023 18:08:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEDcC-00011q-Q4; Sat, 07 Jan 2023 18:08:20 +0000 Received: by outflank-mailman (input) for mailman id 473009; Sat, 07 Jan 2023 18:08:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEDcA-00011k-Pd for xen-devel@lists.xenproject.org; Sat, 07 Jan 2023 18:08:19 +0000 Received: from sonic308-55.consmr.mail.gq1.yahoo.com (sonic308-55.consmr.mail.gq1.yahoo.com [98.137.68.31]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 40027ada-8eb6-11ed-b8d0-410ff93cb8f0; Sat, 07 Jan 2023 19:08:14 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic308.consmr.mail.gq1.yahoo.com with HTTP; Sat, 7 Jan 2023 18:08:11 +0000 Received: by hermes--production-ne1-7b69748c4d-pm9xv (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 14ccf2a9c0a9dae2713d4c3fcc9e4744; Sat, 07 Jan 2023 18:08:06 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 40027ada-8eb6-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1673114891; bh=Q18RRjMQ2O5Mt1JGmUYM8swg2EPTEvKitcNzVDG+mic=; h=Date:From:Subject:To:Cc:References:In-Reply-To:From:Subject:Reply-To; b=fjZLMu/4N+qQkDDgJB0TSZO7e8Pry9AarIVXvSBjVwLKd/CCMn0NwNsZPq8giBgrhn+T72ilBMcxxutstnAM7877zlpi1VVbJdM2G8/bGXaskLoEqb/Mbuy+geuW2zuGJQ49fzWMOrUZS+kDWsptUmiRuusENddhbM46UtEn2rn7fg+i5VyqF+NoLQ2TGZ8tLEiR+NioEXGtLh7mlG6fhj8a2RNMHG5ulyLGnwdz6wSm45u8dHm+dDFj2YGTBp1glgl3dzftnRbzNagMhbKEjPn5RvxMqmubwq5Uzyo8RC8dX3haU6NCldk5CMN8S3VV7zO7BFvEt1PVTBFNVByzPg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1673114891; bh=EkH3Ky6RbP270JuPU3dSVegfYzgL45PaYO8+avJ1Ebs=; h=X-Sonic-MF:Date:From:Subject:To:From:Subject; b=RDudI94oDRtNQBMm0MK3ljhj0zRNvrRI5RAxiIrBJh+d1o2YG+hPjCSWs6oou/r+LptAIWF7OLkrOXwwvJBAhlgpkzOBRjYPVgcwDBME0yumrrhPpOj+wy2aLfldcO0GFTFE5m+2GAhS1EqQ3zFsPiqbfubao4+3hhLwxnegkN5+qgwv++GI3l7BC4THGIUIFTCD7DY6MYoAe8L0QuOGg77x3dNGAvqr3dGpUnplFq5i4+oYZ+Y0MRJgW4L00DGV2CokBjKafv4Tq/hmRB8cs1AVqXWtnBxV20Bqxa+WdWCRz5fqL6rjO88k324PX4apJfmBHD/vZjR3NyGnSCoi8Q== X-YMail-OSG: CxxQpWUVM1ldtrqoR4yjKv3_XMyGb7dsJmacpJpL6CPoJfYMMk4DXun3TyLUOWs hz25SdmCghqgAgdhqyles8WsOK_mSTWrD_rQaleE857SNz1CYXNHOePBj_6lzCy9b8pCLYGA3DFF pQrPZEXPG9lxylgxVIxi.3XdmSmclk3gxU6qnS0EJe9at4hkko6TtkgBzxSgn5CS7DsgUMK7mVr. Hlyk1Intzs2J.AGWuCJL2H4lGohdh0M3XhxXXUQGaauFO.fluYbrs61ef50jWjzZBtvCV1IMparr vEokkMk4M6Yw1q6gOF13pL9OD2P9fd40uuPagovNeGSopcly3uSXQFj8PgpCD_ss2L7m2udpxlr6 y1ZfYepDGv393B3m..oIrOGB8x7M6.MK45MIAn_yq2LTvS0XZZd6Wf56CY7s37pARk5QtakB1USm qdNPWW1VrEHYEBdXS64xkk.QZMXD56r9sh7m5Y769baT04XnxU9vbhm3odBZVXVF4jcwWXaJQihT dAWv7mdkVwD1Joc4FVoOPAGHBwPo3EGWga5JlvAI7_yOUWMBCz7lGvTvmH071ojJFso9Gl9F3dE8 VsJxGNtptu50epj8zwnlApvTeow5nRGbaNNtDLAp09TLekdnZWF02OxEehzZdoPNIlhts6sqQqSo iSqoHnRSAoYAWyfpwsp_nDe0TZauzRDE8_TyHsL0A.R9A9L2uIweYBNlteFgvNbjAGwp_QozyuZL wONCgNDOvEZa5QQDhH_kW3QChgKOb0firteEPIVNGorR5C6y0vGN65TxkA1XfwzORY7R9vZynidR lhJtZEb718z8aMBElt1nlFspfMLFxzBNWVWe6uV8h8olY9MUjsYtb5IwaiNc_i8TBU0_xpMUgd9p lNUS2kyGJaBX.I696yLnsg2AkMt4D0nr3ByyyA9TCTWK4ZA2r_oXZI6az48vjEvTVq1e0U7LIBND TzmdCd0GszoYMXK7ngPH8eajgJIgov1ues_5dA9M.MuE5h49_qntBmuUF_i1aKeyJfPsqebmT77b 2jc8sB6Dk_WRJsc_qsSktNjp._UN_V0bV71IB3E_Vscs84WM56psutehLVV24TVkDQhR4ZJgDh4b 7hZ2Gh2wI6oeTt2yC4Ydmx3_O1HfW4ygYf_lbtWxwW3HfwNl.C0sQAmj3dt6nJXayItAYDKlEYVi NsGwhW9QAoBncHs_7VJPs2XGfxp78ixi8D5Yb8dCWDGIpX4HohAecZ5p3XHIyvJy5kOO.kgsn1cj qomvFvfooFWuztIoVrNTO7zc8lOWbz7_gt85j7mN.8xaLloxyU.9PeSWn1zd6GghONrSNn2FYNfA VDB3iPQMw1HAJw94uiBPRtQM3u6bqoqJAsLhFw_rj69FPr1t7BR7pm.CZoEmbkZEw.ajpWTLVK58 bq4wZAjJ0ufXUS8YPg.bPie93xR4v5kE5_3lRB8HBtRMtjCGxC_iULoOzbdrVCje5F2HHYXI.33U Pb9bWu313vbonT3Kc8QyKMRqsJEq8fNhT_zpBTaj96.iRNqI7pn_29pIDAw6UIcCbdlcAVqJC10H 8O7jstgU9L2Yw4CkniHiTCCmmfcuyWHr.EhTygIEF4Idrq7ZLNBCkiqz.e9rMgEwEXYezKXuA3rG a0q48Hn5ogrNg.xHZAAVj46NbezGeJVLWagutBlaa2nO1Sc3ytgOgeCe74eaTEOEMQQ63YRcW9LW l1q9xxrFF4i_.1MtGxtgNC6Db3wZGD7b8Oi8LmFgXKMp3fMWhOOiwZduHzz7mgh3PrL8vuUnoZxF .Q0bL6UC_BfxRJCoqdpYGZYdql2T.ox8jbKCBhignqkGLo2LdoRx.BEGQgIzsNbOdDl8O7OU0qsT 9iQ_F_pyOsaNNUPg2k85zIHWuxXR_043uHSwrkQGiA6JedbJRJuAIo8qCtdvltr_GAg4OmtGogJK EuY1pmRdCwCu7yhDnU9crRbBYy3rbjUseaMERD_dR_CUGXsI2dPDkbcdWrlaZ9gzMuRIZH.WamKc 1SlKsuxAApUflAl2aQS4fvvgTFdObwFFEKVbVxvH9Nh.GreI3x65LASYKGHJoC3ITbYQTVZNppuE byx4ERQu9pd1nU8S74.rHGOHJIRHh7ZnD5iN4XEGnNEVtcO.VL74pjl6s2b.Pa.jISVcD31DGVYg 41p0V__VzbDJ5j59h1TTOJy1qKxPKcYhneSo4aeLsY1CDNrOR2bA0RdPbs0hU6RkZdXT4B_1cFP8 OVqLzLzdgmo_68fm.QgHrEg-- X-Sonic-MF: Message-ID: Date: Sat, 7 Jan 2023 13:08:03 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 From: Chuck Zmudzinski Subject: Re: [PATCH v2 6/6] hw/isa/piix: Resolve redundant TYPE_PIIX3_XEN_DEVICE To: Bernhard Beschow , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org, Markus Armbruster Cc: Richard Henderson , Stefano Stabellini , xen-devel@lists.xenproject.org, =?UTF-8?Q?Herv=c3=a9_Poussineau?= , Aurelien Jarno , Paul Durrant , Marcel Apfelbaum , Anthony Perard , "Michael S. Tsirkin" , Paolo Bonzini , Eduardo Habkost , Thomas Huth References: <20230104144437.27479-1-shentey@gmail.com> <20230104144437.27479-7-shentey@gmail.com> <1c2e0780-e5fb-1321-0d84-b0591db9fec7@linaro.org> <6a1a6ed8-568d-c08b-91a7-1093a2b25929@linaro.org> <30337c62-a938-61c8-3ae5-092dbccf6302@aol.com> <00ff4875-62e0-05c8-a13e-5a52d4195cc2@aol.com> <01A7F932-0DF1-4977-A111-0907A7FC6FF9@gmail.com> Content-Language: en-US In-Reply-To: <01A7F932-0DF1-4977-A111-0907A7FC6FF9@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.20982 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 4572 On 1/7/23 6:05 AM, Bernhard Beschow wrote: > Am 7. Januar 2023 01:08:46 UTC schrieb Chuck Zmudzinski : > >On 1/6/23 6:04 PM, Chuck Zmudzinski wrote: > >> On 1/6/23 2:08 PM, Chuck Zmudzinski wrote: > >>> On 1/6/23 7:25 AM, Philippe Mathieu-Daudé wrote: > >>>> On 6/1/23 12:57, Bernhard Beschow wrote: > >>>>> > >>>>> > >>>>> Am 4. Januar 2023 15:35:33 UTC schrieb "Philippe Mathieu-Daudé" : > >>>>>> +Markus/Thomas > >>>>>> > >>>>>> On 4/1/23 15:44, Bernhard Beschow wrote: > >>>>>>> During the last patches, TYPE_PIIX3_XEN_DEVICE turned into a clone of > >>>>>>> TYPE_PIIX3_DEVICE. Remove this redundancy. > >>>>>>> > >>>>>>> Signed-off-by: Bernhard Beschow > >>>>>>> --- > >>>>>>> hw/i386/pc_piix.c | 4 +--- > >>>>>>> hw/isa/piix.c | 20 -------------------- > >>>>>>> include/hw/southbridge/piix.h | 1 - > >>>>>>> 3 files changed, 1 insertion(+), 24 deletions(-) > >>>> > >>>> > >>>>>>> -static void piix3_xen_class_init(ObjectClass *klass, void *data) > >>>>>>> -{ > >>>>>>> - DeviceClass *dc = DEVICE_CLASS(klass); > >>>>>>> - PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); > >>>>>>> - > >>>>>>> - k->realize = piix3_realize; > >>>>>>> - /* 82371SB PIIX3 PCI-to-ISA bridge (Step A1) */ > >>>>>>> - k->device_id = PCI_DEVICE_ID_INTEL_82371SB_0; > >>>>>>> - dc->vmsd = &vmstate_piix3; > >>>>>> > >>>>>> IIUC, since this device is user-creatable, we can't simply remove it > >>>>>> without going thru the deprecation process. > >>>>> > >>>>> AFAICS this device is actually not user-creatable since dc->user_creatable is set to false once in the base class. I think it is safe to remove the Xen class unless there are ABI issues. > >>>> Great news! > >>> > >>> I don't know if this means the device is user-creatable: > >>> > >>> chuckz@bullseye:~$ qemu-system-i386 -device piix3-ide-xen,help > >>> piix3-ide-xen options: > >>> addr= - Slot and optional function number, example: 06.0 or 06 (default: -1) > >>> failover_pair_id= > >>> multifunction= - on/off (default: false) > >>> rombar= - (default: 1) > >>> romfile= > >>> x-pcie-extcap-init= - on/off (default: true) > >>> x-pcie-lnksta-dllla= - on/off (default: true) > >>> > >>> Today I am running qemu-5.2 on Debian 11, so this output is for > >>> qemu 5.2, and that version of qemu has a piix3-ide-xen device. > >>> Is that this same device that is being removed? If so, it seems to > >>> me that at least as of qemu 5.2, the device was user-creatable. > >>> > >>> Chuck > >> > >> Good news! It looks the device was removed as user-creatable since version 5.2: > >> > >> chuckz@debian:~$ qemu-system-i386-7.50 -device help | grep piix > >> name "piix3-usb-uhci", bus PCI > >> name "piix4-usb-uhci", bus PCI > >> name "piix3-ide", bus PCI > >> name "piix4-ide", bus PCI > >> chuckz@debian:~$ qemu-system-i386-7.50-bernhard-v2 -device help | grep piix > >> name "piix3-usb-uhci", bus PCI > >> name "piix4-usb-uhci", bus PCI > >> name "piix3-ide", bus PCI > >> name "piix4-ide", bus PCI > >> chuckz@debian:~$ > >> > >> The piix3-ide-xen device is not present either with or without Bernhard's patches > >> for current qemu 7.50, the development version for qemu 8.0 > >> > >> Cheers, > >> > >> Chuck > > > > > >I traced where the pciix3-ide-xen device was removed: > > > >It was 7851b21a81 (hw/ide/piix: Remove redundant "piix3-ide-xen" device class) > > > >https://gitlab.com/qemu-project/qemu/-/commit/7851b21a8192750adecbcf6e8780a20de5891ad6 > > > >about six months ago. That was between 7.0 and 7.1. So the device being removed > >here is definitely not user-creatable, but it appears that this piix3-ide-xen > >device that was removed between 7.0 and 7.1 was user-creatable. Does that one > >need to go through the deprecation process? Or, since no one has complained > >it is gone, maybe we don't need to worry about it? > > Good point! Looks like it fell through the cracks... > > There are voices who claim that this device and its non-Xen counterpart should have never been user-creatable in the firtst place: > https://patchwork.kernel.org/project/qemu-devel/patch/20190718091740.6834-1-philmd@redhat.com/ Of course, only the xen variant was removed, so only users of the xen variant were affected by the removal of the device. Any affected users probably just substituted the non-xen variant for the xen variant in their machines and didn't experience any problems. Kind regards, Chuck From xen-devel-bounces@lists.xenproject.org Sat Jan 07 22:07:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 Jan 2023 22:07:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473026.733509 (Exim 4.92) (envelope-from ) id 1pEHLa-0008Ku-EG; Sat, 07 Jan 2023 22:07:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473026.733509; Sat, 07 Jan 2023 22:07:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEHLa-0008Kl-BE; Sat, 07 Jan 2023 22:07:26 +0000 Received: by outflank-mailman (input) for mailman id 473026; Sat, 07 Jan 2023 22:07:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEHLY-0007Zv-9Q for xen-devel@lists.xenproject.org; Sat, 07 Jan 2023 22:07:24 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a7a36bb3-8ed7-11ed-91b6-6bf2151ebd3b; Sat, 07 Jan 2023 23:07:20 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id CCA885C00A3; Sat, 7 Jan 2023 17:07:19 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Sat, 07 Jan 2023 17:07:19 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 7 Jan 2023 17:07:18 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a7a36bb3-8ed7-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1673129239; x=1673215639; bh=KY3VkgyHYk1MHJ+JHUtQDqXke9gx/LY5Hil UBmVJC3E=; b=q0My5TYPQPe18oQO9hEvLKwKW4d5zSqUxAmpDHBGYJTZbjLsdMg d54+OrM2pLEeGZNx2T/uxC+8c7DyQtEQWx0q9G2yeTCMAlx+Fbjp3e0KyOSVm5YM LYsCVHOKrclVDK9FSuCJ71FjhNK5AjDQkqOfs3m2WNrU8ksXdVEyYIsnTnR3WJV2 nxi8dKxqAU+6FM0giP6m+8XWdoLF9TWTykok7WExRdx96/sfSb3gBltJiLXC20B7 BkQCdraxZqWqhf4OQUsm/Q5DyPtvxKyYg8vN46fuAAeq1dbqXAHUGqeNDnJ/qq/P +oBGQob73HEH9a2loAS6w/CAT04SIO7QOOQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1673129239; x=1673215639; bh=KY3VkgyHYk1MH J+JHUtQDqXke9gx/LY5HilUBmVJC3E=; b=AjOHpAmEwZB3gnpwa+jDY1P8wlWzL ropOlFa9K5T58Pl3kZi4eArD1izpdCbYooGZ6aLg3pDtuhSpNfZGdogbINRVkjb6 wz7Ghm7nN2qUSB1c0MqLQT8B2RL4tvYJzjG8kLJdaYKCB8rAtKb6W8QMCd1O3Vf0 5Be2CJ7i9qffwvMFtO+nvi0ROjkXh+A5cgGb2QoRL/0ebG74ozA8oFSX6J3pSx1L WMjrH7aSYCPa0iulETHO/STnVx/dPqkKg8hlduV0gKl9CiHHfdcCDkAOUHJYXXaO diQwrCrPsPyd0Ja1eI0jQD6jvJfiDvZQevHpXB1Dk8reMUqo2h+KAs3IA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrkedvgdduheegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepjeffjefggfeugeduvedvjeekgfeh gffhhfffjeetkeelueefffetfffhtdduheetnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhs lhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: xen-devel@lists.xenproject.org Cc: Demi Marie Obenour , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Tim Deegan Subject: [PATCH v7 3/4] x86/mm: make code robust to future PAT changes Date: Sat, 7 Jan 2023 17:07:05 -0500 Message-Id: <89201c66b0261b2f5ee83e7672830317fde21dfa.1673123823.git.demi@invisiblethingslab.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit It may be desirable to change Xen's PAT for various reasons. This requires changes to several _PAGE_* macros as well. Add static assertions to check that XEN_MSR_PAT is consistent with the _PAGE_* macros, and that _PAGE_WB is 0 as required by Linux. Signed-off-by: Demi Marie Obenour --- Changes since v6: - Remove overly-specific comment. - Remove double blank line. - Check that unused entries are distinct from higher entries that are used. - Have PTE_FLAGS_TO_CACHEATTR validate its argument. - Do not check if an unsigned number is negative. - Expand comment explaining why _PAGE_WB must be zero. Changes since v5: - Remove unhelpful comment. - Move a BUILD_BUG_ON. - Use fewer hardcoded constants in PTE_FLAGS_TO_CACHEATTR. - Fix coding style. Changes since v4: - Add lots of comments explaining what the various BUILD_BUG_ON()s mean. Changes since v3: - Refactor some macros - Avoid including a string literal in BUILD_BUG_ON Additional checks on PAT values Signed-off-by: Demi Marie Obenour --- xen/arch/x86/include/asm/page.h | 2 + xen/arch/x86/mm.c | 96 +++++++++++++++++++++++++++++++++ 2 files changed, 98 insertions(+) diff --git a/xen/arch/x86/include/asm/page.h b/xen/arch/x86/include/asm/page.h index b585235d064a567082582c8e92a4e8283fd949ca..c7d77ab2901aa5bdb03a719af810c6f8d8ba9d4e 100644 --- a/xen/arch/x86/include/asm/page.h +++ b/xen/arch/x86/include/asm/page.h @@ -338,6 +338,8 @@ void efi_update_l4_pgtable(unsigned int l4idx, l4_pgentry_t); #define _PAGE_UC ( _PAGE_PCD | _PAGE_PWT) #define _PAGE_WC (_PAGE_PAT ) #define _PAGE_WP (_PAGE_PAT | _PAGE_PWT) +#define _PAGE_RSVD_1 (_PAGE_PAT | _PAGE_PCD ) +#define _PAGE_RSVD_2 (_PAGE_PAT | _PAGE_PCD | _PAGE_PWT) /* * Debug option: Ensure that granted mappings are not implicitly unmapped. diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index a8f137925cba1846b97aee9321df6427f4dd1a94..d69e9bea6c30bc782ab4c331f42502f6e61a028a 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -890,6 +890,8 @@ get_page_from_l1e( case _PAGE_WT: case _PAGE_WP: break; + case _PAGE_RSVD_1: + case _PAGE_RSVD_2: default: /* * If we get here, a PV guest tried to use one of the @@ -6412,6 +6414,100 @@ static void __init __maybe_unused build_assertions(void) * using different PATs will not work. */ BUILD_BUG_ON(XEN_MSR_PAT != 0x050100070406ULL); + + /* + * _PAGE_WB must be zero. Linux PV guests assume that _PAGE_WB will be + * zero, and indeed Linux has a BUILD_BUG_ON validating that their version + * of _PAGE_WB *is* zero. Furthermore, since _PAGE_WB is zero, it is quite + * likely to be omitted from various parts of Xen, and indeed L1 PTE + * validation code checks that ((l1f & PAGE_CACHE_ATTRs) == 0), not + * ((l1f & PAGE_CACHE_ATTRs) == _PAGE_WB). + */ + BUILD_BUG_ON(_PAGE_WB); + + /* _PAGE_RSVD_1 must be less than _PAGE_RSVD_2 */ + BUILD_BUG_ON(_PAGE_RSVD_1 >= _PAGE_RSVD_2); + +#define PAT_ENTRY(v) \ + (BUILD_BUG_ON_ZERO(((v) < 0) || ((v) > 7)) + \ + (0xFF & (XEN_MSR_PAT >> (8 * (v))))) + + /* Validate at compile-time that v is a valid value for a PAT entry */ +#define CHECK_PAT_ENTRY_VALUE(v) \ + BUILD_BUG_ON((v) > X86_NUM_MT || (v) == X86_MT_RSVD_2 || \ + (v) == X86_MT_RSVD_3) + + /* Validate at compile-time that PAT entry v is valid */ +#define CHECK_PAT_ENTRY(v) CHECK_PAT_ENTRY_VALUE(PAT_ENTRY(v)) + + /* + * If one of these trips, the corresponding entry in XEN_MSR_PAT is invalid. + * This would cause Xen to crash (with #GP) at startup. + */ + CHECK_PAT_ENTRY(0); + CHECK_PAT_ENTRY(1); + CHECK_PAT_ENTRY(2); + CHECK_PAT_ENTRY(3); + CHECK_PAT_ENTRY(4); + CHECK_PAT_ENTRY(5); + CHECK_PAT_ENTRY(6); + CHECK_PAT_ENTRY(7); + + /* Macro version of pte_flags_to_cacheattr(), for use in BUILD_BUG_ON()s */ +#define PTE_FLAGS_TO_CACHEATTR(pte_value) \ + /* Check that the _PAGE_* macros only use bits from PAGE_CACHE_ATTRS */ \ + (BUILD_BUG_ON_ZERO(((pte_value) & PAGE_CACHE_ATTRS) != (pte_value)) | \ + (((pte_value) & _PAGE_PAT) >> 5) | \ + (((pte_value) & (_PAGE_PCD | _PAGE_PWT)) >> 3)) + + CHECK_PAT_ENTRY(PTE_FLAGS_TO_CACHEATTR(_PAGE_RSVD_1)); + CHECK_PAT_ENTRY(PTE_FLAGS_TO_CACHEATTR(_PAGE_RSVD_2)); +#define PAT_ENTRY_FROM_FLAGS(x) PAT_ENTRY(PTE_FLAGS_TO_CACHEATTR(x)) + + /* Validate at compile time that X does not duplicate a smaller PAT entry */ +#define CHECK_DUPLICATE_ENTRY(x, y) \ + BUILD_BUG_ON((x) >= (y) && \ + (PAT_ENTRY_FROM_FLAGS(x) == PAT_ENTRY_FROM_FLAGS(y))) + + /* Check that a PAT-related _PAGE_* macro is correct */ +#define CHECK_PAGE_VALUE(page_value) do { \ + /* Check that the _PAGE_* macros only use bits from PAGE_CACHE_ATTRS */ \ + BUILD_BUG_ON(((_PAGE_ ## page_value) & PAGE_CACHE_ATTRS) != \ + (_PAGE_ ## page_value)); \ + /* Check that the _PAGE_* are consistent with XEN_MSR_PAT */ \ + BUILD_BUG_ON(PAT_ENTRY(PTE_FLAGS_TO_CACHEATTR(_PAGE_ ## page_value)) != \ + (X86_MT_ ## page_value)); \ + case _PAGE_ ## page_value:; /* ensure no duplicate values */ \ + /* \ + * Check that the _PAGE_* entries do not duplicate a smaller reserved \ + * entry. \ + */ \ + CHECK_DUPLICATE_ENTRY(_PAGE_ ## page_value, _PAGE_RSVD_1); \ + CHECK_DUPLICATE_ENTRY(_PAGE_ ## page_value, _PAGE_RSVD_2); \ + CHECK_PAT_ENTRY(PTE_FLAGS_TO_CACHEATTR(_PAGE_ ## page_value)); \ +} while ( false ) + + /* + * If one of these trips, the corresponding _PAGE_* macro is inconsistent + * with XEN_MSR_PAT. This would cause Xen to use incorrect cacheability + * flags, with results that are unknown and possibly harmful. + */ + switch (0) { + CHECK_PAGE_VALUE(WT); + CHECK_PAGE_VALUE(WB); + CHECK_PAGE_VALUE(WC); + CHECK_PAGE_VALUE(UC); + CHECK_PAGE_VALUE(UCM); + CHECK_PAGE_VALUE(WP); + case _PAGE_RSVD_1: + case _PAGE_RSVD_2: + break; + } +#undef CHECK_PAT_ENTRY +#undef CHECK_PAT_ENTRY_VALUE +#undef CHECK_PAGE_VALUE +#undef PAGE_FLAGS_TO_CACHEATTR +#undef PAT_ENTRY } /* -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Sat Jan 07 22:07:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 Jan 2023 22:07:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473027.733519 (Exim 4.92) (envelope-from ) id 1pEHLb-0000AD-M2; Sat, 07 Jan 2023 22:07:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473027.733519; Sat, 07 Jan 2023 22:07:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEHLb-00009S-IY; Sat, 07 Jan 2023 22:07:27 +0000 Received: by outflank-mailman (input) for mailman id 473027; Sat, 07 Jan 2023 22:07:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEHLZ-0007Zv-9R for xen-devel@lists.xenproject.org; Sat, 07 Jan 2023 22:07:25 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a8363c73-8ed7-11ed-91b6-6bf2151ebd3b; Sat, 07 Jan 2023 23:07:21 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id C4D2E5C00A0; Sat, 7 Jan 2023 17:07:20 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sat, 07 Jan 2023 17:07:20 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 7 Jan 2023 17:07:19 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a8363c73-8ed7-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1673129240; x=1673215640; bh=POJFkOQt3y GloJZrLhIV9nkjsTfKozCDcDniLFyd4nI=; b=Oifh/nCYWga5HbxTHiQazgkc/l 33df31xXEvqm7IuHvb04cpwFAHVo3eY36wRdCX1Xov2Qt0xcoR+eTIz6f+u9Rqs0 uXeW9FDccKhntA3lYBsF/hdozXlbugTNJdcozNUBMEDebUqA/f9dE99EYMMJy3c+ cPObnEE5Y6QHgludXMJvmNCgag7OJLgPe7xxb2t9f30kZTXPf2m3aeGTxL3dpw0V XUKGJErAu8nNMsPf/ZHQZonny8a34/RfyDOaQqbvkCNI/IsJEVLDfW2hbiqhu3v3 kKtXIRO1uoV1ouOEB8PrAkh2cvbSwoXMauUsxRUst3Z8C0QqrRDhjAGCJo0A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1673129240; x= 1673215640; bh=POJFkOQt3yGloJZrLhIV9nkjsTfKozCDcDniLFyd4nI=; b=e ++Ev6cFb5oNXBg6Delfd4mJ6yWRBP9oYyPFvo+/UXkxif9fa0AJuMT2yrKRG7xSs iXV35wznh1y5awDMHnO8nt1KIJ4ooZg4LBtH3SxfdUZQQBbH8aZ8qrFTclW/0QK3 L7UkIt5nfBvZrPWw0FcHcFxShKWJ47dJpaM0BZlqECYlw2FqiAmvqkl4X9Pn2Pvx 6ZSSm163HjRVJZ6MmiIWtZ8cWhS5ssONXl8bQUCWs1t1+iTk9ti+9q/xtu3p3btS 3IH+jzSkMLCJPKa4/ctTLfPTIge7/uTFwdPVzoCJXZmozzju1SofvKsNaXIQqs+T 3fKZvlwjY+CQM+p0NE7YQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrkedvgdduheegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeffvghm ihcuofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinh hgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeeludekleeljeekveekfeeghfff gedvieegleeigeejffefieeviedvjeegveetieenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhg shhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: xen-devel@lists.xenproject.org Cc: Demi Marie Obenour , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Tim Deegan Subject: [PATCH v7 4/4] x86: Allow using Linux's PAT Date: Sat, 7 Jan 2023 17:07:06 -0500 Message-Id: <9fd0360dd914d93dab357d16b46b4290e6119d30.1673123823.git.demi@invisiblethingslab.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Due to a hardware errata, Intel integrated GPUs are incompatible with Xen's PAT. Using Linux's PAT is a workaround for this flaw. Signed-off-by: Demi Marie Obenour --- xen/arch/x86/Kconfig | 33 ++++++++++++++++++++++++++++ xen/arch/x86/include/asm/page.h | 12 ++++++++++ xen/arch/x86/include/asm/processor.h | 15 +++++++++++++ xen/arch/x86/mm.c | 2 ++ 4 files changed, 62 insertions(+) diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig index 6a7825f4ba3c98e0496415123fde79ee62f771fa..18efccedfd08873cd169a54825b0ba4256a12942 100644 --- a/xen/arch/x86/Kconfig +++ b/xen/arch/x86/Kconfig @@ -227,6 +227,39 @@ config XEN_ALIGN_2M endchoice +config LINUX_PAT + bool "Use Linux's PAT instead of Xen's default" + help + Use Linux's Page Attribute Table instead of the default Xen value. + + The Page Attribute Table (PAT) maps three bits in the page table entry + to the actual cacheability used by the processor. Many Intel + integrated GPUs have errata (bugs) that cause CPU access to GPU memory + to ignore the topmost bit. When using Xen's default PAT, this results + in caches not being flushed and incorrect images being displayed. The + default PAT used by Linux does not cause this problem. + + If you say Y here, you will be able to use Intel integrated GPUs that + are attached to your Linux dom0 or other Linux PV guests. However, + you will not be able to use non-Linux OSs in dom0, and attaching a PCI + device to a non-Linux PV guest will result in unpredictable guest + behavior. If you say N here, you will be able to use a non-Linux + dom0, and will be able to attach PCI devices to non-Linux PV guests. + + Note that saving a PV guest with an assigned PCI device on a machine + with one PAT and restoring it on a machine with a different PAT won't + work: the resulting guest may boot and even appear to work, but caches + will not be flushed when needed, with unpredictable results. HVM + (including PVH and PVHVM) guests and guests without assigned PCI + devices do not care what PAT Xen uses, and migration (even live) + between hypervisors with different PATs will work fine. Guests using + PV Shim care about the PAT used by the PV Shim firmware, not the + host’s PAT. Also, non-default PAT values are incompatible with the + (deprecated) qemu-traditional stubdomain. + + Say Y if you are building a hypervisor for a Linux distribution that + supports Intel iGPUs. Say N otherwise. + config X2APIC_PHYSICAL bool "x2APIC Physical Destination mode" help diff --git a/xen/arch/x86/include/asm/page.h b/xen/arch/x86/include/asm/page.h index c7d77ab2901aa5bdb03a719af810c6f8d8ba9d4e..03839eb2b78517332663daad2089677d7000852c 100644 --- a/xen/arch/x86/include/asm/page.h +++ b/xen/arch/x86/include/asm/page.h @@ -331,6 +331,7 @@ void efi_update_l4_pgtable(unsigned int l4idx, l4_pgentry_t); #define PAGE_CACHE_ATTRS (_PAGE_PAT | _PAGE_PCD | _PAGE_PWT) +#ifndef CONFIG_LINUX_PAT /* Memory types, encoded under Xen's choice of MSR_PAT. */ #define _PAGE_WB ( 0) #define _PAGE_WT ( _PAGE_PWT) @@ -340,6 +341,17 @@ void efi_update_l4_pgtable(unsigned int l4idx, l4_pgentry_t); #define _PAGE_WP (_PAGE_PAT | _PAGE_PWT) #define _PAGE_RSVD_1 (_PAGE_PAT | _PAGE_PCD ) #define _PAGE_RSVD_2 (_PAGE_PAT | _PAGE_PCD | _PAGE_PWT) +#else +/* Memory types, encoded under Linux's choice of MSR_PAT. */ +#define _PAGE_WB ( 0) +#define _PAGE_WC ( _PAGE_PWT) +#define _PAGE_UCM ( _PAGE_PCD ) +#define _PAGE_UC ( _PAGE_PCD | _PAGE_PWT) +#define _PAGE_RSVD_1 (_PAGE_PAT ) +#define _PAGE_WP (_PAGE_PAT | _PAGE_PWT) +#define _PAGE_RSVD_2 (_PAGE_PAT | _PAGE_PCD ) +#define _PAGE_WT (_PAGE_PAT | _PAGE_PCD | _PAGE_PWT) +#endif /* * Debug option: Ensure that granted mappings are not implicitly unmapped. diff --git a/xen/arch/x86/include/asm/processor.h b/xen/arch/x86/include/asm/processor.h index 60b902060914584957db8afa5c7c1e6abdad4d13..413b59ab284990cca192fa1dc44b437f58bd282f 100644 --- a/xen/arch/x86/include/asm/processor.h +++ b/xen/arch/x86/include/asm/processor.h @@ -92,6 +92,20 @@ X86_EFLAGS_NT|X86_EFLAGS_DF|X86_EFLAGS_IF| \ X86_EFLAGS_TF) +#ifdef CONFIG_LINUX_PAT +/* + * Host IA32_CR_PAT value to cover all memory types. This is not the default + * MSR_PAT value, but is the same as the one used by Linux. + */ +#define XEN_MSR_PAT ((_AC(X86_MT_WB, ULL) << 0x00) | \ + (_AC(X86_MT_WC, ULL) << 0x08) | \ + (_AC(X86_MT_UCM, ULL) << 0x10) | \ + (_AC(X86_MT_UC, ULL) << 0x18) | \ + (_AC(X86_MT_WB, ULL) << 0x20) | \ + (_AC(X86_MT_WP, ULL) << 0x28) | \ + (_AC(X86_MT_UCM, ULL) << 0x30) | \ + (_AC(X86_MT_WT, ULL) << 0x38)) +#else /* * Host IA32_CR_PAT value to cover all memory types. This is not the default * MSR_PAT value, and is an ABI with PV guests. @@ -104,6 +118,7 @@ (_AC(X86_MT_WP, ULL) << 0x28) | \ (_AC(X86_MT_UC, ULL) << 0x30) | \ (_AC(X86_MT_UC, ULL) << 0x38)) +#endif #ifndef __ASSEMBLY__ diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index d69e9bea6c30bc782ab4c331f42502f6e61a028a..042c1875a02092a3f19c293003ef12209d88a450 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -6407,6 +6407,7 @@ unsigned long get_upper_mfn_bound(void) static void __init __maybe_unused build_assertions(void) { +#ifndef CONFIG_LINUX_PAT /* * If this trips, any guests that blindly rely on the public API in xen.h * (instead of reading the PAT from Xen, as Linux 3.19+ does) will be @@ -6414,6 +6415,7 @@ static void __init __maybe_unused build_assertions(void) * using different PATs will not work. */ BUILD_BUG_ON(XEN_MSR_PAT != 0x050100070406ULL); +#endif /* * _PAGE_WB must be zero. Linux PV guests assume that _PAGE_WB will be -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Sat Jan 07 22:07:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 Jan 2023 22:07:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473024.733481 (Exim 4.92) (envelope-from ) id 1pEHLX-0007c4-UP; Sat, 07 Jan 2023 22:07:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473024.733481; Sat, 07 Jan 2023 22:07:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEHLX-0007bX-O1; Sat, 07 Jan 2023 22:07:23 +0000 Received: by outflank-mailman (input) for mailman id 473024; Sat, 07 Jan 2023 22:07:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEHLW-0007Zv-Ro for xen-devel@lists.xenproject.org; Sat, 07 Jan 2023 22:07:22 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a673a04f-8ed7-11ed-91b6-6bf2151ebd3b; Sat, 07 Jan 2023 23:07:19 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id CE6FC5C0070; Sat, 7 Jan 2023 17:07:17 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sat, 07 Jan 2023 17:07:17 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 7 Jan 2023 17:07:17 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a673a04f-8ed7-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1673129237; x=1673215637; bh=lFRjAyz2V8QJ7yU1YRzmTT1WULJJ6rEk/i2 CB/Rdt1o=; b=TcfGk5AK7ZARdCLVukNVb/Z5aT/jz9wzzUuiOrlE0r1WL2jGFpg vA3eRk53cB04tmhryKp4f3DUnv2jK9fCH1TjNtEpUhnAUvWqRu7G+KzcZJHibL2K pWAP7rYDXZl8CIAps8E04TYn6dbgKqcejusmBQBRK4MHGgVDLJZN/euE9gt9Tpjx lCYCfUXwWXyFVjsWnyD0quqe6P7rI06/yC5lF0aiuP9ET3mGkIfkET0k4kew4xa9 iRH9z3cNWYEM52O47fsG1F1cKLzO4j7SM3QKVjWky0LsLvLvA7IEIp43UXlFbuNP cXwFz4bjYf5UKGj+LNAT+u1Vssl7aVksESg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1673129237; x=1673215637; bh=lFRjAyz2V8QJ7 yU1YRzmTT1WULJJ6rEk/i2CB/Rdt1o=; b=AdLhRwqTNTZZqgenNh0x4w8h3eh6Y G+Zq5P8NlXojtpNaBHghUWWZsY8fZIL5LZ5K4V43tOFYFicwLqSzfNXWetyK/vFO iZyebRdy5EgtWaPgS/+S19r22V6vYfJSB8eOF9J3FBFfQpdwzo0nxt/H4LqPQUQJ YXTyeKfETokij1et7xogLh0NPxRBZ7SChOenZbdGMtF4fbRO0dZ45gOuEmza8pWL 6tYZBlMz69s8aTHn7Q+7o4ih3mAPOnv+WOkIUrz6R3RlR4GmWaZoX4fUQbql9OvU AiF0W/e7VUYuftYigqDLpeHS2qv8cwOs6U9cuuKwA5GnONHwcUVfiNbpw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrkedvgdduheegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepjeffjefggfeugeduvedvjeekgfeh gffhhfffjeetkeelueefffetfffhtdduheetnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhs lhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: xen-devel@lists.xenproject.org Cc: Demi Marie Obenour , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Tim Deegan Subject: [PATCH v7 1/4] x86: Remove MEMORY_NUM_TYPES and NO_HARDCODE_MEM_TYPE Date: Sat, 7 Jan 2023 17:07:03 -0500 Message-Id: X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit No functional change intended. Signed-off-by: Demi Marie Obenour --- Changes since v2: - Keep MTRR_NUM_TYPES and adjust commit message accordingly --- xen/arch/x86/hvm/mtrr.c | 18 +++++++++--------- xen/arch/x86/include/asm/mtrr.h | 2 -- xen/arch/x86/mm/shadow/multi.c | 2 +- 3 files changed, 10 insertions(+), 12 deletions(-) diff --git a/xen/arch/x86/hvm/mtrr.c b/xen/arch/x86/hvm/mtrr.c index 093103f6c768cf64f880d1b20e1c14f5918c1250..05e978041d62fd0d559462de181a04bef8a5bca9 100644 --- a/xen/arch/x86/hvm/mtrr.c +++ b/xen/arch/x86/hvm/mtrr.c @@ -38,7 +38,7 @@ static const uint8_t pat_entry_2_pte_flags[8] = { /* Effective mm type lookup table, according to MTRR and PAT. */ static const uint8_t mm_type_tbl[MTRR_NUM_TYPES][X86_NUM_MT] = { -#define RS MEMORY_NUM_TYPES +#define RS MTRR_NUM_TYPES #define UC X86_MT_UC #define WB X86_MT_WB #define WC X86_MT_WC @@ -66,9 +66,9 @@ static const uint8_t mm_type_tbl[MTRR_NUM_TYPES][X86_NUM_MT] = { * Reverse lookup table, to find a pat type according to MTRR and effective * memory type. This table is dynamically generated. */ -static uint8_t __read_mostly mtrr_epat_tbl[MTRR_NUM_TYPES][MEMORY_NUM_TYPES] = - { [0 ... MTRR_NUM_TYPES-1] = - { [0 ... MEMORY_NUM_TYPES-1] = INVALID_MEM_TYPE } +static uint8_t __read_mostly mtrr_epat_tbl[MTRR_NUM_TYPES][MTRR_NUM_TYPES] = + { [0 ... MTRR_NUM_TYPES - 1] = + { [0 ... MTRR_NUM_TYPES - 1] = INVALID_MEM_TYPE } }; /* Lookup table for PAT entry of a given PAT value in host PAT. */ @@ -85,7 +85,7 @@ static int __init cf_check hvm_mtrr_pat_init(void) { unsigned int tmp = mm_type_tbl[i][j]; - if ( tmp < MEMORY_NUM_TYPES ) + if ( tmp < MTRR_NUM_TYPES ) mtrr_epat_tbl[i][tmp] = j; } } @@ -317,11 +317,11 @@ static uint8_t effective_mm_type(struct mtrr_state *m, uint8_t gmtrr_mtype) { uint8_t mtrr_mtype, pat_value; - + /* if get_pat_flags() gives a dedicated MTRR type, * just use it - */ - if ( gmtrr_mtype == NO_HARDCODE_MEM_TYPE ) + */ + if ( gmtrr_mtype == MTRR_NUM_TYPES ) mtrr_mtype = mtrr_get_type(m, gpa, 0); else mtrr_mtype = gmtrr_mtype; @@ -346,7 +346,7 @@ uint32_t get_pat_flags(struct vcpu *v, /* 1. Get the effective memory type of guest physical address, * with the pair of guest MTRR and PAT */ - guest_eff_mm_type = effective_mm_type(g, pat, gpaddr, + guest_eff_mm_type = effective_mm_type(g, pat, gpaddr, gl1e_flags, gmtrr_mtype); /* 2. Get the memory type of host physical address, with MTRR */ shadow_mtrr_type = mtrr_get_type(&mtrr_state, spaddr, 0); diff --git a/xen/arch/x86/include/asm/mtrr.h b/xen/arch/x86/include/asm/mtrr.h index e4f6ca6048334b2094a1836cc2f298453641232f..4b7f840a965954cc4b59698327a37e47026893a4 100644 --- a/xen/arch/x86/include/asm/mtrr.h +++ b/xen/arch/x86/include/asm/mtrr.h @@ -4,8 +4,6 @@ #include #define MTRR_NUM_TYPES X86_MT_UCM -#define MEMORY_NUM_TYPES MTRR_NUM_TYPES -#define NO_HARDCODE_MEM_TYPE MTRR_NUM_TYPES #define NORMAL_CACHE_MODE 0 #define NO_FILL_CACHE_MODE 2 diff --git a/xen/arch/x86/mm/shadow/multi.c b/xen/arch/x86/mm/shadow/multi.c index f5f7ff021bd9e057c5b6f6329de7acb5ef05d58f..1faf9940db6b0afefc5977c00c00fb6a39cd27d2 100644 --- a/xen/arch/x86/mm/shadow/multi.c +++ b/xen/arch/x86/mm/shadow/multi.c @@ -578,7 +578,7 @@ _sh_propagate(struct vcpu *v, gflags, gfn_to_paddr(target_gfn), mfn_to_maddr(target_mfn), - NO_HARDCODE_MEM_TYPE); + MTRR_NUM_TYPES); } } -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Sat Jan 07 22:07:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 Jan 2023 22:07:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473023.733477 (Exim 4.92) (envelope-from ) id 1pEHLX-0007ae-NV; Sat, 07 Jan 2023 22:07:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473023.733477; Sat, 07 Jan 2023 22:07:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEHLX-0007aA-Fq; Sat, 07 Jan 2023 22:07:23 +0000 Received: by outflank-mailman (input) for mailman id 473023; Sat, 07 Jan 2023 22:07:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEHLW-0007Zv-0J for xen-devel@lists.xenproject.org; Sat, 07 Jan 2023 22:07:22 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a5fe16f2-8ed7-11ed-91b6-6bf2151ebd3b; Sat, 07 Jan 2023 23:07:19 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id E36BA5C0077; Sat, 7 Jan 2023 17:07:16 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Sat, 07 Jan 2023 17:07:16 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 7 Jan 2023 17:07:15 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a5fe16f2-8ed7-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to; s=fm2; t= 1673129236; x=1673215636; bh=GH9GoCF1lU7nE5K7/oncm4hQo/KJyvZaDda S9Bw1XBM=; b=v3ZYRJ7NH0g+bqOKNv61dDmt2+zjrneH1S9D0lyiuM5qBYChvdd XhZA+zL+nQEXqgPz9erA46quFg9EmAJEE53x+fyQKsTfTh3VGTJULUYkL99uPbt0 1AS4qL83aiwJl5EKKd+d16SbAErUSbYaVaaZPteR7f3Fs9yz/DyZLFL987W4MltA 3di+nkG/a5uJiXIO+N8yggqSrGdXdT06M8+dy+7TMqn0iKIFHVjX1ienmeF74j11 6VwU/dewHncE6Y2wm3q0HwiD0APtF2+2CbScvMgaRdfPBwTGUnEenJFdRAyyBhv5 OhviKA3CugVtIw+YvK3Y62MHQ29U560+4LQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1673129236; x=1673215636; bh=GH9GoCF1lU7nE 5K7/oncm4hQo/KJyvZaDdaS9Bw1XBM=; b=SXlteS+xEfpxleQtjTy4hLha6qRsX WD/l1H6nPIO/BaW663rTK38D+K4zromLewm6ywtOAdIYFMcEUPutpxNDFapSTL5E yf6Uiq7YAZwBGE9+RLe6S5VS/WmXRBksb7mKyCIN6Zt1K9RFnU/OBc1PVkro2yQs anxbChvqOfhhOFRPkaWZbqhZIom4cDqU7f3lRIZLvqWHcaKdWZgBx3lUmjtSttud vmLf1v0NxXz3ihvL5K22lL7VfD7uOguJRQ6ozmtlszS2srlhw6wqSuQ+K0YWtMmm gCsVoS32ByTcmFXeZLgZNWPqSlKNM/2RNFcXCBmab4d9j9SdxSQ7bA2/Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrkedvgdduheegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofggtgfgsehtkeertdertdejnecuhfhrohhmpeffvghmihcu ofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinhhgsh hlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefhgefgieeitdeijeeguddtkefgteeg heehgeetkeevhfefgfduhedtveelgeeugeenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhgshhl rggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: xen-devel@lists.xenproject.org Cc: Demi Marie Obenour , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Tim Deegan Subject: [PATCH v7 0/4] Make PAT handling less brittle Date: Sat, 7 Jan 2023 17:07:02 -0500 Message-Id: X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit While working on Qubes OS Marek found out that there were some PAT hacks in the Linux i195 driver. I decided to make Xen use Linux’s PAT to see if it solved the graphics glitches that were observed; it did. This required a substantial amount of preliminary work that is useful even without using Linux’s PAT. Furthermore, it turned out that the graphics glitches were due to a hardware bug, which means that Xen's PAT is fundamentally incompatible with the use of current-generation Intel integrated GPUs assigned to a PV guest (including dom0). Patches 1 through 3 are the preliminary work. Patch 3 does break ABI by rejecting the unused PAT entries, but this will only impact buggy PV guests and can be disabled with a Xen command-line option. Patch 4 provides a new Kconfig option (CONFIG_LINUX_PAT) to use Linux's PAT instead of Xen's default. Only patches 3 and 4 actually change Xen’s observable behavior. Patch 1 is strictly cleanup. Patch 2 makes changing the PAT much less error-prone, as problems with the PAT or with the associated _PAGE_* constants will be detected at compile time. Demi Marie Obenour (4): x86: Remove MEMORY_NUM_TYPES and NO_HARDCODE_MEM_TYPE x86/mm: Reject invalid cacheability in PV guests by default x86/mm: make code robust to future PAT changes x86: Allow using Linux's PAT docs/misc/xen-command-line.pandoc | 11 ++ xen/arch/x86/Kconfig | 33 ++++++ xen/arch/x86/hvm/mtrr.c | 18 ++-- xen/arch/x86/include/asm/mtrr.h | 2 - xen/arch/x86/include/asm/page.h | 14 +++ xen/arch/x86/include/asm/processor.h | 15 +++ xen/arch/x86/include/asm/pv/domain.h | 7 ++ xen/arch/x86/mm.c | 151 ++++++++++++++++++++++++++- xen/arch/x86/mm/shadow/multi.c | 2 +- xen/arch/x86/pv/domain.c | 18 +++- 10 files changed, 255 insertions(+), 16 deletions(-) -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Sat Jan 07 22:07:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 Jan 2023 22:07:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473025.733498 (Exim 4.92) (envelope-from ) id 1pEHLZ-00085K-3o; Sat, 07 Jan 2023 22:07:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473025.733498; Sat, 07 Jan 2023 22:07:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEHLY-00085D-V8; Sat, 07 Jan 2023 22:07:24 +0000 Received: by outflank-mailman (input) for mailman id 473025; Sat, 07 Jan 2023 22:07:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEHLX-0007Zv-DB for xen-devel@lists.xenproject.org; Sat, 07 Jan 2023 22:07:23 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a705382b-8ed7-11ed-91b6-6bf2151ebd3b; Sat, 07 Jan 2023 23:07:19 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id C14895C0076; Sat, 7 Jan 2023 17:07:18 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Sat, 07 Jan 2023 17:07:18 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 7 Jan 2023 17:07:17 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a705382b-8ed7-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1673129238; x=1673215638; bh=1qVsCevJ6z 1i8YffwrKngj5a2580Okyv9pEFojRJYNA=; b=pVheUbXFIxxTOWkRi7gSa6D9oG s8EdUmbeNUSwXHeyblgFwLhp93vkZ4MSeHaRLW2ouiCFkW5Ott+ptNZBplxltd93 3HLUZUblxDPPfgpUZgeVpF8ac6mYyuB4cfGSW2r9p3Vk9Sn1/FvsFGDvH+DEvYZa gqmP9eSxKOR3JpXmcxOzeVseTSBtx6cDWY/swLcC1iyRsyq1gm/RsgqiWQLb/Cvv 6T3m403W86Rf5zFc7NpjL5IweVUEuNFF6Nn5WKe/Si6dwZCmxmepHelVSTdDzI1f mjNzaue389LsJE6YY1rKcLo3tumGk132gj7RwitjpOpxKYOoxOm18dG90t1A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1673129238; x= 1673215638; bh=1qVsCevJ6z1i8YffwrKngj5a2580Okyv9pEFojRJYNA=; b=a bjm0RBaapBEXH0sQAmfiCSgHquGTUojGtDfX5R/19gmlFZ2A88xVRMegVn2zpQLo bLHOnntsNHe3ZFCW29NC8rlYUN1coPLxS9COC6ApFXfmR9igrTIh3Av/nqBZ6LbB r2tkIuHszo9Ul0omCXAjKgOfGzaeFSMZqUfu0niYZQKFinv/tMOe6IoRYZZFDH90 FrG/4l+92wha6ZKMlV9Ql4s95F39gkhPPp5UBOsNP/zmSqwe4l6BkffxWL9AmLIL RsUdBm52ZXTfVAl/B674s4jJMfsEwoWtsgDHP+g3eEz20O9ZoDol26dNxhWgWv/W JnoVS4A7PhBSYwEiphlbQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrkedvgdduheegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeffvghm ihcuofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinh hgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeeludekleeljeekveekfeeghfff gedvieegleeigeejffefieeviedvjeegveetieenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhg shhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: xen-devel@lists.xenproject.org Cc: Demi Marie Obenour , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Tim Deegan Subject: [PATCH v7 2/4] x86/mm: Reject invalid cacheability in PV guests by default Date: Sat, 7 Jan 2023 17:07:04 -0500 Message-Id: X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Setting cacheability flags that are not ones specified by Xen is a bug in the guest. By default, return -EINVAL if a guests attempts to do this. The invalid-cacheability= Xen command-line flag allows the administrator to allow such attempts or to produce Suggested-by: Andrew Cooper Signed-off-by: Demi Marie Obenour --- Changes since v6: - Make invalid-cacheability= a subflag of pv=. - Move check for invalid cacheability to get_page_from_l1e(). Changes since v5: - Make parameters static and __ro_after_init. - Replace boolean parameter allow_invalid_cacheability with string parameter invalid-cacheability. - Move parameter definitions to near where they are used. - Add documentation. Changes since v4: - Remove pointless BUILD_BUG_ON(). - Add comment explaining why an exception is being injected. Changes since v3: - Add Andrew Cooper’s Suggested-by --- docs/misc/xen-command-line.pandoc | 11 ++++++ xen/arch/x86/include/asm/pv/domain.h | 7 ++++ xen/arch/x86/mm.c | 53 +++++++++++++++++++++++++++- xen/arch/x86/pv/domain.c | 18 ++++++++-- 4 files changed, 85 insertions(+), 4 deletions(-) diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc index 424b12cfb27d6ade2ec63eacb8afe5df82465451..0230a7bc17cbd4362a42ea64cea695f31f5e0f86 100644 --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -1417,6 +1417,17 @@ detection of systems known to misbehave upon accesses to that port. ### idle_latency_factor (x86) > `= ` +### invalid-cacheability (x86) +> `= allow | deny | trap` + +> Default: `deny` in release builds, otherwise `trap` + +Specify what happens when a PV guest tries to use one of the reserved entries in +the PAT. `deny` causes the attempt to be rejected with -EINVAL, `allow` allows +the attempt, and `trap` causes a general protection fault to be raised. +Currently, the reserved entries are marked as uncacheable in Xen's PAT, but this +will change if new memory types are added, so guests must not rely on it. + ### ioapic_ack (x86) > `= old | new` diff --git a/xen/arch/x86/include/asm/pv/domain.h b/xen/arch/x86/include/asm/pv/domain.h index 924508bbb4f0c199b3cd2306d9d8f0bd0ef399f9..1c9ce259ab4ee23ea5d057f5dfa964effb169032 100644 --- a/xen/arch/x86/include/asm/pv/domain.h +++ b/xen/arch/x86/include/asm/pv/domain.h @@ -71,6 +71,13 @@ void pv_vcpu_destroy(struct vcpu *v); int pv_vcpu_initialise(struct vcpu *v); void pv_domain_destroy(struct domain *d); int pv_domain_initialise(struct domain *d); +extern __ro_after_init uint8_t invalid_cacheability; + +enum { + INVALID_CACHEABILITY_ALLOW, + INVALID_CACHEABILITY_DENY, + INVALID_CACHEABILITY_TRAP, +}; /* * Bits which a PV guest can toggle in its view of cr4. Some are loaded into diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index 3558ca215b02a517d55d75329d645ae5905424e4..a8f137925cba1846b97aee9321df6427f4dd1a94 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -879,6 +879,30 @@ get_page_from_l1e( return -EINVAL; } + if ( invalid_cacheability != INVALID_CACHEABILITY_ALLOW ) + { + switch ( l1e.l1 & PAGE_CACHE_ATTRS ) + { + case _PAGE_WB: + case _PAGE_UC: + case _PAGE_UCM: + case _PAGE_WC: + case _PAGE_WT: + case _PAGE_WP: + break; + default: + /* + * If we get here, a PV guest tried to use one of the + * reserved values in Xen's PAT. This indicates a bug + * in the guest. If requested by the user, inject #GP + * to cause the guest to log a stack trace. + */ + if ( invalid_cacheability == INVALID_CACHEABILITY_TRAP ) + pv_inject_hw_exception(TRAP_gp_fault, 0); + return -EINVAL; + } + } + valid = mfn_valid(_mfn(mfn)); if ( !valid || @@ -1324,6 +1348,31 @@ static int put_page_from_l4e(l4_pgentry_t l4e, mfn_t l4mfn, unsigned int flags) return put_pt_page(l4e_get_page(l4e), mfn_to_page(l4mfn), flags); } +#ifdef NDEBUG +#define INVALID_CACHEABILITY_DEFAULT INVALID_CACHEABILITY_DENY +#else +#define INVALID_CACHEABILITY_DEFAULT INVALID_CACHEABILITY_TRAP +#endif + +__ro_after_init uint8_t invalid_cacheability = + INVALID_CACHEABILITY_DEFAULT; + +static int __init cf_check set_invalid_cacheability(const char *str) +{ + if (strcmp("allow", str) == 0) + invalid_cacheability = INVALID_CACHEABILITY_ALLOW; + else if (strcmp("deny", str) == 0) + invalid_cacheability = INVALID_CACHEABILITY_DENY; + else if (strcmp("trap", str) == 0) + invalid_cacheability = INVALID_CACHEABILITY_TRAP; + else + return -EINVAL; + + return 0; +} + +custom_param("invalid-cacheability", set_invalid_cacheability); + static int promote_l1_table(struct page_info *page) { struct domain *d = page_get_owner(page); @@ -1343,7 +1392,9 @@ static int promote_l1_table(struct page_info *page) } else { - switch ( ret = get_page_from_l1e(pl1e[i], d, d) ) + l1_pgentry_t l1e = pl1e[i]; + + switch ( ret = get_page_from_l1e(l1e, d, d) ) { default: goto fail; diff --git a/xen/arch/x86/pv/domain.c b/xen/arch/x86/pv/domain.c index f94f28c8e271549acb449ef2e129b928751f765d..40b424351fd99fe1fb0a5faa5b20bf4070bb1d4a 100644 --- a/xen/arch/x86/pv/domain.c +++ b/xen/arch/x86/pv/domain.c @@ -28,9 +28,21 @@ static int __init cf_check parse_pv(const char *s) do { ss = strchr(s, ','); if ( !ss ) - ss = strchr(s, '\0'); - - if ( (val = parse_boolean("32", s, ss)) >= 0 ) + ss += strlen(s); + if ( !strncmp("invalid-cacheability=", s, + sizeof("invalid-cacheability=") - 1) ) + { + const char *p = s + (sizeof("invalid-cacheability=") - 1); + if (ss - p == 5 && !memcmp(p, "allow", 5)) + invalid_cacheability = INVALID_CACHEABILITY_ALLOW; + else if (ss - p == 4 && !memcmp(p, "deny", 4)) + invalid_cacheability = INVALID_CACHEABILITY_DENY; + else if (ss - p == 4 && !memcmp(p, "trap", 4)) + invalid_cacheability = INVALID_CACHEABILITY_TRAP; + else + rc = -EINVAL; + } + else if ( (val = parse_boolean("32", s, ss)) >= 0 ) { #ifdef CONFIG_PV32 opt_pv32 = val; -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Sat Jan 07 22:20:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 Jan 2023 22:20:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473064.733531 (Exim 4.92) (envelope-from ) id 1pEHYD-0003nZ-Sm; Sat, 07 Jan 2023 22:20:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473064.733531; Sat, 07 Jan 2023 22:20:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEHYD-0003nS-PZ; Sat, 07 Jan 2023 22:20:29 +0000 Received: by outflank-mailman (input) for mailman id 473064; Sat, 07 Jan 2023 22:20:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEHYC-0003nI-Ud; Sat, 07 Jan 2023 22:20:28 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEHYC-0007RO-S8; Sat, 07 Jan 2023 22:20:28 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEHYC-0003aY-7S; Sat, 07 Jan 2023 22:20:28 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pEHYC-0001Mw-6x; Sat, 07 Jan 2023 22:20:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=QBvnUNJmuDURAaJUNMjWW66DzyjdVfCotKeNP//3YfE=; b=sv3pv5EFc6dvMFSJXwkRn86evc gz80xjOiNwuBCr6iL0BrBXq1CjpNJojuA5HwIApNAsOnQHWkm+dRjS0PjZ4h4n5L27LTNYzQFUW3s EsOC2D2zseskt+GnchKmCkpuqbPR0GRVRxIT6nZAA3Ue184Z1dz8Y97InLSmK1aZPpPw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 175616: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=0a71553536d270e988580a3daa9fc87535908221 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Sat, 07 Jan 2023 22:20:28 +0000 flight 175616 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/175616/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine 8 reboot fail REGR. vs. 173462 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux 0a71553536d270e988580a3daa9fc87535908221 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 92 days Failing since 173470 2022-10-08 06:21:34 Z 91 days 191 attempts Testing same since 175613 2023-01-07 02:22:17 Z 0 days 2 attempts ------------------------------------------------------------ 3305 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 504416 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Jan 07 22:59:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 Jan 2023 22:59:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473074.733541 (Exim 4.92) (envelope-from ) id 1pEI9o-0007RA-0S; Sat, 07 Jan 2023 22:59:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473074.733541; Sat, 07 Jan 2023 22:59:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEI9n-0007R3-Th; Sat, 07 Jan 2023 22:59:19 +0000 Received: by outflank-mailman (input) for mailman id 473074; Sat, 07 Jan 2023 22:59:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEI9m-0007Qt-SJ; Sat, 07 Jan 2023 22:59:18 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEI9m-0008Gl-OZ; Sat, 07 Jan 2023 22:59:18 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEI9m-0004TT-6J; Sat, 07 Jan 2023 22:59:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pEI9m-0005Qw-5k; Sat, 07 Jan 2023 22:59:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=wRQNIE2tQIZzQPBChXRQflvwDzHAws6qj0q20uaYFkM=; b=OzzmBYbWhu6Ks0D9SzlNDdSoPM 4VBwUTX3/61kOFcznCv31LNmXJhKQR3kXk5UBAnqRiBxp5Td/B0ic6/f1L0scoAgpBNFI1ggokSCw W5OZwHrrerM7TwXC1YENqFE9Br21zO+N3fbXx7KA0gvb1Wt2sFn4DpjzxS19Z7jCYcGE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 175619: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=052e6534c49ebef8901824b77abc39271f0d852e X-Osstest-Versions-That: qemuu=d1852caab131ea898134fdcea8c14bc2ee75fbe9 From: osstest service owner Date: Sat, 07 Jan 2023 22:59:18 +0000 flight 175619 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/175619/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 175595 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 175595 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175595 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175595 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 175595 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 175595 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175595 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175595 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu 052e6534c49ebef8901824b77abc39271f0d852e baseline version: qemuu d1852caab131ea898134fdcea8c14bc2ee75fbe9 Last test of basis 175595 2023-01-06 01:55:04 Z 1 days Failing since 175603 2023-01-06 12:10:38 Z 1 days 4 attempts Testing same since 175619 2023-01-07 16:40:19 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alessandro Di Federico Alex Bennée Alistair Francis Anup Patel Atish Patra Axel Heider Bin Meng Christoph Muellner Christoph Müllner Claudio Fontana Conor Dooley Fabiano Rosas Frédéric Pétrot Ilya Leoshkevich Jean-Christophe Dubois Jim Shu LIU Zhiwei Marco Liebel Mark Cave-Ayland Matheus Tavares Bernardino Mayuresh Chitale Mukilan Thiyagarajan Paolo Bonzini Peter Maydell Philippe Mathieu-Daudé Richard Henderson Stephen Longfield Taylor Simpson Tobias Röhmel Wilfred Mallawa Zhuojia Shen jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git d1852caab1..052e6534c4 052e6534c49ebef8901824b77abc39271f0d852e -> upstream-tested From xen-devel-bounces@lists.xenproject.org Sun Jan 08 07:56:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 08 Jan 2023 07:56:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473086.733556 (Exim 4.92) (envelope-from ) id 1pEQXr-0003PF-Nq; Sun, 08 Jan 2023 07:56:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473086.733556; Sun, 08 Jan 2023 07:56:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEQXr-0003P8-LA; Sun, 08 Jan 2023 07:56:43 +0000 Received: by outflank-mailman (input) for mailman id 473086; Sun, 08 Jan 2023 07:56:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEQXq-0003Ox-6H; Sun, 08 Jan 2023 07:56:42 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEQXp-0007G4-UL; Sun, 08 Jan 2023 07:56:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEQXp-0006iR-JD; Sun, 08 Jan 2023 07:56:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pEQXp-0000DG-Ik; Sun, 08 Jan 2023 07:56:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=7GZZhe3XJ+8rH/vHlbowa+Ayy2MAp8E5cDRm7nyBw6U=; b=6wNHmzrNTthdCiaAsDjuclkgXU abmigufhH/iS+MBZl75ujXZHUD5EqRzUok0vzSrG7J/WsktUMJ38LSnsE6MknEssyyxTKAlHJLWRF jd3QziiJyR4AnxvLeRwjyJNeOOsoc9ocrc8P9QNLkF0pdts6BGjJmtdUg0ZzVYJ5W24g=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 175622: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=9b43a525db125799df81e6fbef712a2ae50bfc5d X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Sun, 08 Jan 2023 07:56:41 +0000 flight 175622 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/175622/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine 8 reboot fail REGR. vs. 173462 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux 9b43a525db125799df81e6fbef712a2ae50bfc5d baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 92 days Failing since 173470 2022-10-08 06:21:34 Z 92 days 192 attempts Testing same since 175622 2023-01-07 22:40:16 Z 0 days 1 attempts ------------------------------------------------------------ 3311 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 505194 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Jan 08 09:31:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 08 Jan 2023 09:31:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473104.733567 (Exim 4.92) (envelope-from ) id 1pES1M-0005WC-50; Sun, 08 Jan 2023 09:31:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473104.733567; Sun, 08 Jan 2023 09:31:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pES1M-0005W5-1d; Sun, 08 Jan 2023 09:31:16 +0000 Received: by outflank-mailman (input) for mailman id 473104; Sun, 08 Jan 2023 09:31:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pES1K-0005Vv-CN; Sun, 08 Jan 2023 09:31:14 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pES1K-0001YD-99; Sun, 08 Jan 2023 09:31:14 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pES1J-0000lC-Pb; Sun, 08 Jan 2023 09:31:13 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pES1J-0002pk-P1; Sun, 08 Jan 2023 09:31:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=zo0qSBLW2AZd2KAmUFUZbchSx+cRmLGieF7eUtHPMjQ=; b=dU0LNLXI2c4aHM6PyskV6+iaNl qX00uWknKir/7LbELUCQDX8B2Nlrv8ZBVWilLfBwHvBHYo0pefegezXiAmo0E8SS3F1AlXUPqoXj1 8akc2Ye2hDeaOE/Lpn/UpczFJBgxmF8r3CFSwK2XYkC9OOAaYcU5giU0QarE8lY1eqcE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 175624: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-xl-shadow:xen-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:windows-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=2b21cbbb339fb14414f357a6683b1df74c36fda2 X-Osstest-Versions-That: xen=2b21cbbb339fb14414f357a6683b1df74c36fda2 From: osstest service owner Date: Sun, 08 Jan 2023 09:31:13 +0000 flight 175624 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/175624/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-shadow 7 xen-install fail in 175612 pass in 175624 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail in 175612 pass in 175624 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 12 debian-hvm-install fail pass in 175612 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 175612 test-amd64-amd64-xl-qemuu-win7-amd64 12 windows-install fail pass in 175612 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 175612 like 175601 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail in 175612 like 175601 test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail like 175601 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 175612 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175612 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 175612 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175612 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175612 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 175612 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 175612 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 175612 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 175612 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 175612 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175612 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen 2b21cbbb339fb14414f357a6683b1df74c36fda2 baseline version: xen 2b21cbbb339fb14414f357a6683b1df74c36fda2 Last test of basis 175624 2023-01-08 01:53:38 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Sun Jan 08 09:39:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 08 Jan 2023 09:39:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473113.733577 (Exim 4.92) (envelope-from ) id 1pES8m-0006DI-Vw; Sun, 08 Jan 2023 09:38:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473113.733577; Sun, 08 Jan 2023 09:38:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pES8m-0006DB-TO; Sun, 08 Jan 2023 09:38:56 +0000 Received: by outflank-mailman (input) for mailman id 473113; Sun, 08 Jan 2023 09:38:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pES8l-0006D1-C2; Sun, 08 Jan 2023 09:38:55 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pES8l-0001hn-8h; Sun, 08 Jan 2023 09:38:55 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pES8k-0000uP-Pw; Sun, 08 Jan 2023 09:38:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pES8k-0002im-PS; Sun, 08 Jan 2023 09:38:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=XxQPPNXG0492sG9hg+AOO27aiipg9TW9vNatxeXMyRs=; b=LqSWybjPluIfkWbwTpmnEh1xY2 HRMk5rbVPxXl1Y75+LRgpHkBIUOxMf+yo90scsDpOVipcrsrh2TXQz2HzZDLWlZ71OloYd16bwvFU ABH67gWcT9uLU+eGt0cuVrjGg0aFzh1I3A+pDTmPPSy8t5HihCbDvO0MHPBQxRKJBbNc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 175623: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:heisenbug qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=0ab12aa32462817f0a53fa6f6ce4baf664ef1713 X-Osstest-Versions-That: qemuu=052e6534c49ebef8901824b77abc39271f0d852e From: osstest service owner Date: Sun, 08 Jan 2023 09:38:54 +0000 flight 175623 qemu-mainline real [real] flight 175626 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/175623/ http://logs.test-lab.xenproject.org/osstest/logs/175626/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-libvirt-pair 10 xen-install/src_host fail pass in 175626-retest test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail pass in 175626-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 175619 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 175619 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175619 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175619 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 175619 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 175619 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175619 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175619 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu 0ab12aa32462817f0a53fa6f6ce4baf664ef1713 baseline version: qemuu 052e6534c49ebef8901824b77abc39271f0d852e Last test of basis 175619 2023-01-07 16:40:19 Z 0 days Testing same since 175623 2023-01-07 23:09:00 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Peter Maydell Song Gao Tianrui Zhao jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 052e6534c4..0ab12aa324 0ab12aa32462817f0a53fa6f6ce4baf664ef1713 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Sun Jan 08 11:44:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 08 Jan 2023 11:44:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473123.733588 (Exim 4.92) (envelope-from ) id 1pEU6H-0002Ei-2M; Sun, 08 Jan 2023 11:44:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473123.733588; Sun, 08 Jan 2023 11:44:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEU6G-0002Eb-W1; Sun, 08 Jan 2023 11:44:28 +0000 Received: by outflank-mailman (input) for mailman id 473123; Sun, 08 Jan 2023 11:44:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEU6F-0002EV-S2 for xen-devel@lists.xenproject.org; Sun, 08 Jan 2023 11:44:27 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEU6F-0004sj-Il; Sun, 08 Jan 2023 11:44:27 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pEU6F-0002Uv-E1; Sun, 08 Jan 2023 11:44:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=6nVFpbwrs3F1UgLekW7AzPCT/IBWSWbJmXStwI/E5gg=; b=y1oHWd5NlqzrPTG8Lbg4tF4aRh nLFsuZEaoxiYhgxDoycVIqVIhV/xCCh+tkI5P28QbBAtFvFJ5XX6Z63brsjP5BYkjp/vhzvc8MvDe mU3cI+Y/r9S07lhpF7KEZ0oa/35CqQdvmDKF2/XHbINQp0JUxt0qWVTkDk+i7i9pKDp8=; Message-ID: Date: Sun, 8 Jan 2023 11:44:25 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 To: Penny Zheng , xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20221115025235.1378931-1-Penny.Zheng@arm.com> <20221115025235.1378931-2-Penny.Zheng@arm.com> From: Julien Grall Subject: Re: [PATCH v1 01/13] xen/arm: re-arrange the static shared memory region In-Reply-To: <20221115025235.1378931-2-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Penny, On 15/11/2022 02:52, Penny Zheng wrote: > This commit re-arranges the static shared memory regions into a separate array > shm_meminfo. And static shared memory region now would have its own structure > 'shm_membank' to hold all shm-related members, like shm_id, etc, and a pointer > to the normal memory bank 'membank'. This will avoid continuing to grow > 'membank'. > > Signed-off-by: Penny Zheng > --- > xen/arch/arm/bootfdt.c | 40 +++++++++++++++++++------------ > xen/arch/arm/domain_build.c | 35 ++++++++++++++++----------- > xen/arch/arm/include/asm/kernel.h | 2 +- > xen/arch/arm/include/asm/setup.h | 16 +++++++++---- > 4 files changed, 59 insertions(+), 34 deletions(-) > > diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c > index 6014c0f852..ccf281cd37 100644 > --- a/xen/arch/arm/bootfdt.c > +++ b/xen/arch/arm/bootfdt.c > @@ -384,6 +384,7 @@ static int __init process_shm_node(const void *fdt, int node, > const __be32 *cell; > paddr_t paddr, gaddr, size; > struct meminfo *mem = &bootinfo.reserved_mem; After this patch, 'mem' is barely going to be used. So I would recommend to remove it or restrict the scope. This will make easier to confirm that most of the use of 'mem' have been replaced with 'shm_mem' and reduce the risk of confusion between the two (the name are quite similar). [...] > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index bd30d3798c..c0fd13f6ed 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -757,20 +757,20 @@ static int __init acquire_nr_borrower_domain(struct domain *d, > { > unsigned int bank; > > - /* Iterate reserved memory to find requested shm bank. */ > - for ( bank = 0 ; bank < bootinfo.reserved_mem.nr_banks; bank++ ) > + /* Iterate static shared memory to find requested shm bank. */ > + for ( bank = 0 ; bank < bootinfo.shm_mem.nr_banks; bank++ ) > { > - paddr_t bank_start = bootinfo.reserved_mem.bank[bank].start; > - paddr_t bank_size = bootinfo.reserved_mem.bank[bank].size; > + paddr_t bank_start = bootinfo.shm_mem.bank[bank].membank->start; > + paddr_t bank_size = bootinfo.shm_mem.bank[bank].membank->size; I was expecting a "if (type == MEMBANK_STATIC_DOMAIN) ..." to be removed. But it looks like there was none. I guess that was a mistake in the existing code? > > if ( (pbase == bank_start) && (psize == bank_size) ) > break; > } > > - if ( bank == bootinfo.reserved_mem.nr_banks ) > + if ( bank == bootinfo.shm_mem.nr_banks ) > return -ENOENT; > > - *nr_borrowers = bootinfo.reserved_mem.bank[bank].nr_shm_borrowers; > + *nr_borrowers = bootinfo.shm_mem.bank[bank].nr_shm_borrowers; > > return 0; > } > @@ -907,11 +907,18 @@ static int __init append_shm_bank_to_domain(struct kernel_info *kinfo, > paddr_t start, paddr_t size, > const char *shm_id) > { > + struct membank *membank; > + > if ( kinfo->shm_mem.nr_banks >= NR_MEM_BANKS ) > return -ENOMEM; > > - kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].start = start; > - kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].size = size; > + membank = xmalloc_bytes(sizeof(struct membank)); You allocate memory but never free it. However, I think it would be better to avoid the dynamic allocation. So I would consider to not use the structure shm_membank and instead create a specific one for the domain construction. > + if ( membank == NULL ) > + return -ENOMEM; > + > + kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].membank = membank; > + kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].membank->start = start; > + kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].membank->size = size; The last two could be replaced with: membank->start = start; membank->size = size; This would make the code more readable. Also, while you are modifying the code, I would consider to introduce a local variable that points to kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks]. [...] > struct meminfo { > @@ -61,6 +57,17 @@ struct meminfo { > struct membank bank[NR_MEM_BANKS]; > }; > > +struct shm_membank { > + char shm_id[MAX_SHM_ID_LENGTH]; > + unsigned int nr_shm_borrowers; > + struct membank *membank; After the change I suggest above, I would expect that the field of membank will not be updated. So I would add const here. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Jan 08 11:57:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 08 Jan 2023 11:57:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473130.733600 (Exim 4.92) (envelope-from ) id 1pEUIM-0003me-7e; Sun, 08 Jan 2023 11:56:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473130.733600; Sun, 08 Jan 2023 11:56:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEUIM-0003mX-50; Sun, 08 Jan 2023 11:56:58 +0000 Received: by outflank-mailman (input) for mailman id 473130; Sun, 08 Jan 2023 11:56:57 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEUIK-0003mQ-W3 for xen-devel@lists.xenproject.org; Sun, 08 Jan 2023 11:56:57 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEUIK-0005HT-Jv; Sun, 08 Jan 2023 11:56:56 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pEUIK-0002nq-ED; Sun, 08 Jan 2023 11:56:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=xeNRan2TYy/Nfh0C3omfZfsutDQU4xaPHcI77DDdhBU=; b=MEn4IcqV0h89DF8dLI+aSo8Wv6 BxHRvl67ESoLzIvpgOaqjEoWMlx/liUvAShJ1/u5fbbGjNpCYy1opFodqaMimlXa8vp6PbDylTSB5 3v2XBj9Ski19qoIdyszin30jVyx3LvHRPODgSC6QVPDrG+0I0o+lJAe45QzBiHlvwl8w=; Message-ID: <670d3b0b-86fc-4673-5a3d-0417b9a002f8@xen.org> Date: Sun, 8 Jan 2023 11:56:54 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 To: Penny Zheng , xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20221115025235.1378931-1-Penny.Zheng@arm.com> <20221115025235.1378931-3-Penny.Zheng@arm.com> From: Julien Grall Subject: Re: [PATCH v1 02/13] xen/arm: switch to use shm_membank as function parameter In-Reply-To: <20221115025235.1378931-3-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Penny, On 15/11/2022 02:52, Penny Zheng wrote: > Instead of using multiple function parameters to deliver various shm-related > info, like host physical address, SHMID, etc, and with the introduction > of new struct "shm_membank", we could switch to use "shm_membank" as > function parameter to replace them all, to make codes more clear and > tidy. > > Signed-off-by: Penny Zheng > --- > xen/arch/arm/domain_build.c | 46 ++++++++++++++++++------------------- > 1 file changed, 23 insertions(+), 23 deletions(-) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index c0fd13f6ed..d2b9e60b5c 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -751,40 +751,31 @@ static void __init assign_static_memory_11(struct domain *d, > } > > #ifdef CONFIG_STATIC_SHM > -static int __init acquire_nr_borrower_domain(struct domain *d, > - paddr_t pbase, paddr_t psize, > - unsigned long *nr_borrowers) > +static struct shm_membank * __init acquire_shm_membank(const char *shm_id) You are returning bootinfo. AFAICT, nobody you modify it after it was populated. So can this be const? Also, I think the function wants to be renamed because this is too similar to the function acquire_shared_memory_bank(). I would rename it to find_shared_memory_bank(). > { > unsigned int bank; > > /* Iterate static shared memory to find requested shm bank. */ > for ( bank = 0 ; bank < bootinfo.shm_mem.nr_banks; bank++ ) > - { > - paddr_t bank_start = bootinfo.shm_mem.bank[bank].membank->start; > - paddr_t bank_size = bootinfo.shm_mem.bank[bank].membank->size; > - > - if ( (pbase == bank_start) && (psize == bank_size) ) > + if ( strcmp(shm_id, bootinfo.shm_mem.bank[bank].shm_id) == 0 ) > break; > - } > > if ( bank == bootinfo.shm_mem.nr_banks ) > - return -ENOENT; > - > - *nr_borrowers = bootinfo.shm_mem.bank[bank].nr_shm_borrowers; > + return NULL; > > - return 0; > + return &bootinfo.shm_mem.bank[bank]; > } > > /* > * This function checks whether the static shared memory region is > * already allocated to dom_io. > */ > -static bool __init is_shm_allocated_to_domio(paddr_t pbase) > +static bool __init is_shm_allocated_to_domio(struct shm_membank *shm_membank) AFAICT, the function will not modify shm_membank. So please use const. > { > struct page_info *page; > struct domain *d; > > - page = maddr_to_page(pbase); > + page = maddr_to_page(shm_membank->membank->start); > d = page_get_owner_and_reference(page); > if ( d == NULL ) > return false; > @@ -835,14 +826,17 @@ static mfn_t __init acquire_shared_memory_bank(struct domain *d, > } > > static int __init assign_shared_memory(struct domain *d, > - uint32_t addr_cells, uint32_t size_cells, > - paddr_t pbase, paddr_t psize, > + struct shm_membank *shm_membank, Same here. > paddr_t gbase) > { > mfn_t smfn; > int ret = 0; > unsigned long nr_pages, nr_borrowers, i; > struct page_info *page; > + paddr_t pbase, psize; > + > + pbase = shm_membank->membank->start; > + psize = shm_membank->membank->size; > > printk("%pd: allocate static shared memory BANK %#"PRIpaddr"-%#"PRIpaddr".\n", > d, pbase, pbase + psize); > @@ -871,9 +865,7 @@ static int __init assign_shared_memory(struct domain *d, > * Get the right amount of references per page, which is the number of > * borrower domains. > */ > - ret = acquire_nr_borrower_domain(d, pbase, psize, &nr_borrowers); > - if ( ret ) > - return ret; > + nr_borrowers = shm_membank->nr_shm_borrowers; > > /* > * Instead of letting borrower domain get a page ref, we add as many > @@ -941,6 +933,7 @@ static int __init process_shm(struct domain *d, struct kernel_info *kinfo, > const char *role_str; > const char *shm_id; > bool owner_dom_io = true; > + struct shm_membank *shm_membank; same here. > > if ( !dt_device_is_compatible(shm_node, "xen,domain-shared-memory-v1") ) > continue; > @@ -991,12 +984,20 @@ static int __init process_shm(struct domain *d, struct kernel_info *kinfo, > } > BUG_ON((strlen(shm_id) <= 0) || (strlen(shm_id) >= MAX_SHM_ID_LENGTH)); > > + shm_membank = acquire_shm_membank(shm_id); > + if ( !shm_membank ) > + { > + printk("%pd: failed to acquire %s shared memory bank\n", > + d, shm_id); > + return -ENOENT; > + } > + > /* > * DOMID_IO is a fake domain and is not described in the Device-Tree. > * Therefore when the owner of the shared region is DOMID_IO, we will > * only find the borrowers. > */ > - if ( (owner_dom_io && !is_shm_allocated_to_domio(pbase)) || > + if ( (owner_dom_io && !is_shm_allocated_to_domio(shm_membank)) || > (!owner_dom_io && strcmp(role_str, "owner") == 0) ) > { > /* > @@ -1004,8 +1005,7 @@ static int __init process_shm(struct domain *d, struct kernel_info *kinfo, > * specified, so they should be assigned to dom_io. > */ > ret = assign_shared_memory(owner_dom_io ? dom_io : d, > - addr_cells, size_cells, > - pbase, psize, gbase); > + shm_membank, gbase); > if ( ret ) > return ret; > } Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Jan 08 12:13:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 08 Jan 2023 12:13:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473138.733611 (Exim 4.92) (envelope-from ) id 1pEUYH-0006HT-QD; Sun, 08 Jan 2023 12:13:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473138.733611; Sun, 08 Jan 2023 12:13:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEUYH-0006HM-M2; Sun, 08 Jan 2023 12:13:25 +0000 Received: by outflank-mailman (input) for mailman id 473138; Sun, 08 Jan 2023 12:13:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEUYG-0006HG-Kq for xen-devel@lists.xenproject.org; Sun, 08 Jan 2023 12:13:24 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEUYG-0005cM-5L; Sun, 08 Jan 2023 12:13:24 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pEUYF-0003cA-Sh; Sun, 08 Jan 2023 12:13:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=8J4YsxLSyyEjda5xIkLHeBep8ikZw7KoQ0QgXbjTHhY=; b=BJiou41POJ4/8CqOQbzJv9JCu/ MG4YKthQUFoh28feDGPCq9NlHHltY9Da0Hi06UKAGUZzIcXBinm3sVldG8b+d2LV/u6daexAKbjdR nbLlXJ80m/SPr8tGZ+027bMUL8ZIx6CXCnzVctSWTHaiCV+NpLw0UKXAPrgX9d/IKDPk=; Message-ID: <3832d94f-6856-82b3-ea64-a9e79460c547@xen.org> Date: Sun, 8 Jan 2023 12:13:21 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v1 04/13] xen/arm: expand shm_membank for unprovided host address To: Penny Zheng , xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20221115025235.1378931-1-Penny.Zheng@arm.com> <20221115025235.1378931-5-Penny.Zheng@arm.com> From: Julien Grall In-Reply-To: <20221115025235.1378931-5-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Penny, On 15/11/2022 02:52, Penny Zheng wrote: > When host address is not provided in "xen,shared-mem", we let Xen > automatically allocate requested static shared memory from heap, and it > stands good chance of having multiple host memory banks allocated for the > requested static shared memory as a result. Therefore current membank is not > going to cover it. > > This commit introduces a new field "mem" to cover both scenarios. > "struct membank" is used when host address is provided, whereas > "struct meminfo" shall be used when host address not provided. From this patch, it is not clear to me how a user can know which part of the union should be used. However... I am not entirely sure why you need to create a union because in your new structure you can fit one bank. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Jan 08 12:22:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 08 Jan 2023 12:22:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473145.733622 (Exim 4.92) (envelope-from ) id 1pEUhC-0007ie-KP; Sun, 08 Jan 2023 12:22:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473145.733622; Sun, 08 Jan 2023 12:22:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEUhC-0007iX-Ho; Sun, 08 Jan 2023 12:22:38 +0000 Received: by outflank-mailman (input) for mailman id 473145; Sun, 08 Jan 2023 12:22:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEUhC-0007iR-2Z for xen-devel@lists.xenproject.org; Sun, 08 Jan 2023 12:22:38 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEUhB-0005vd-Mi; Sun, 08 Jan 2023 12:22:37 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pEUhB-0003tr-HP; Sun, 08 Jan 2023 12:22:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=J8OCN7wTNVpbOJr1mSt4M84BOP08M1gbQLNxXEpFxKo=; b=XlSfKSMWT0zhg8fVGW1Ah7Lk+F eRziJAxnghXqRHmL1sp5BHXiGLlT2dcBv0jbcZcpwfV9v467hFz6TOQW9ugzHanaS2AyUp2PMhOko VPZsUps26K5JSjmtEokHCAX3K7A06RAWbaBCpOd2hxpcGnsbTc0Ty2N24SeZwXRapCy4=; Message-ID: Date: Sun, 8 Jan 2023 12:22:35 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 To: Penny Zheng , xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20221115025235.1378931-1-Penny.Zheng@arm.com> <20221115025235.1378931-6-Penny.Zheng@arm.com> From: Julien Grall Subject: Re: [PATCH v1 05/13] xen/arm: allocate shared memory from heap when host address not provided In-Reply-To: <20221115025235.1378931-6-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Penny, On 15/11/2022 02:52, Penny Zheng wrote: > when host address is not provided in "xen,shared-mem", we let Xen > allocate requested shared memory from heap, and once the shared memory is > allocated, it will be marked as static(PGC_static), which means that it will be > reserved as static memory, and will not go back to heap even on freeing. Please don't move pages from the {xen,dom}heap to the static heap. If you need to keep the pages for longer, then get an extra reference so they will not be released. > > Signed-off-by: Penny Zheng > --- > xen/arch/arm/domain_build.c | 83 ++++++++++++++++++++++++++++++++++++- > 1 file changed, 82 insertions(+), 1 deletion(-) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index fbb196d8a4..3de96882a5 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -835,6 +835,72 @@ static bool __init is_shm_allocated_to_domio(struct shm_membank *shm_membank) > return true; > } > > +static int __init mark_shared_memory_static(struct shm_membank *shm_membank) > +{ > + unsigned int bank; > + unsigned long i, nr_mfns; > + struct page_info *pg; > + struct meminfo *meminfo; > + > + BUG_ON(!shm_membank->mem.banks.meminfo); > + meminfo = shm_membank->mem.banks.meminfo; > + for ( bank = 0; bank < meminfo->nr_banks; bank++ ) > + { > + pg = mfn_to_page(maddr_to_mfn(meminfo->bank[bank].start)); mfn_to_page(maddr_to_mfn(...)) is equivalent to maddr_to_page(..). > + nr_mfns = PFN_DOWN(meminfo->bank[bank].size); > + > + for ( i = 0; i < nr_mfns; i++ ) > + { > + /* The page should be already allocated from heap. */ > + if ( !pg[i].count_info & PGC_state_inuse ) I don't think this is doing what you want because ! will take precedence over &. You likely want to add parenthese: !(... & ...) > + { > + printk(XENLOG_ERR > + "pg[%lu] MFN %"PRI_mfn" c=%#lx\n", > + i, mfn_x(page_to_mfn(pg)) + i, pg[i].count_info); > + goto fail; > + } > + > + pg[i].count_info |= PGC_static; > + } > + } > + > + return 0; > + > + fail: > + while ( bank >= 0 ) > + { > + while ( --i >= 0 ) > + pg[i].count_info &= ~PGC_static; > + i = PFN_DOWN(meminfo->bank[--bank].size); > + } > + > + return -EINVAL; > +} > + > +static int __init allocate_shared_memory(struct shm_membank *shm_membank, > + paddr_t psize) > +{ > + struct meminfo *banks; > + int ret; > + > + BUG_ON(shm_membank->mem.banks.meminfo != NULL); > + > + banks = xmalloc_bytes(sizeof(struct meminfo)); Where is this freed? > + if ( banks == NULL ) > + return -ENOMEM; > + shm_membank->mem.banks.meminfo = banks; > + memset(shm_membank->mem.banks.meminfo, 0, sizeof(struct meminfo)); > + > + if ( !allocate_domheap_memory(NULL, psize, shm_membank->mem.banks.meminfo) ) > + return -EINVAL; > + > + ret = mark_shared_memory_static(shm_membank); > + if ( ret ) > + return ret; > + > + return 0; > +} > + > static mfn_t __init acquire_shared_memory_bank(struct domain *d, > paddr_t pbase, paddr_t psize) > { > @@ -975,7 +1041,7 @@ static int __init process_shm(struct domain *d, struct kernel_info *kinfo, > unsigned int i; > const char *role_str; > const char *shm_id; > - bool owner_dom_io = true; > + bool owner_dom_io = true, paddr_assigned = true; > struct shm_membank *shm_membank; > > if ( !dt_device_is_compatible(shm_node, "xen,domain-shared-memory-v1") ) > @@ -1035,6 +1101,21 @@ static int __init process_shm(struct domain *d, struct kernel_info *kinfo, > return -ENOENT; > } > > + /* > + * When host address is not provided in "xen,shared-mem", > + * we let Xen allocate requested memory from heap at first domain. > + */ > + if ( !paddr_assigned && !shm_membank->mem.banks.meminfo ) > + { > + ret = allocate_shared_memory(shm_membank, psize); > + if ( ret ) > + { > + printk("%pd: failed to allocate shared memory bank(%"PRIpaddr"MB) from heap: %d\n", > + d, psize >> 20, ret); > + return ret; > + } > + } > + > /* > * DOMID_IO is a fake domain and is not described in the Device-Tree. > * Therefore when the owner of the shared region is DOMID_IO, we will Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Jan 08 12:53:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 08 Jan 2023 12:53:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473152.733633 (Exim 4.92) (envelope-from ) id 1pEVAa-0002eG-WE; Sun, 08 Jan 2023 12:53:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473152.733633; Sun, 08 Jan 2023 12:53:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEVAa-0002e9-Te; Sun, 08 Jan 2023 12:53:00 +0000 Received: by outflank-mailman (input) for mailman id 473152; Sun, 08 Jan 2023 12:52:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEVAZ-0002e3-Kq for xen-devel@lists.xenproject.org; Sun, 08 Jan 2023 12:52:59 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEVAZ-0006YE-C2; Sun, 08 Jan 2023 12:52:59 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pEVAZ-0004sX-5w; Sun, 08 Jan 2023 12:52:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=Jle59iCiMsqHyxp4ZpisjmnJ5CRT/9Fb4pdXCheufD4=; b=L9dnkChRACQaoIFXmeMAfTP1tb 84VHd6rY3RfaSfLTaUiS+W1WKRtr9i8fSCw7aOxCVf2ua8s3rxAR7WY1AMTsxQ2Zawy2rA2I36l7Q 4Q9M7RglpY+N4bXXuup9UuzuGQ6eKV3TIY3Fpf0tEYpKUicN7jbWxVb4daOnCC50GC4c=; Message-ID: Date: Sun, 8 Jan 2023 12:52:57 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 To: Penny Zheng , xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20221115025235.1378931-1-Penny.Zheng@arm.com> <20221115025235.1378931-7-Penny.Zheng@arm.com> From: Julien Grall Subject: Re: [PATCH v1 06/13] xen/arm: assign shared memory to owner when host address not provided In-Reply-To: <20221115025235.1378931-7-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 15/11/2022 02:52, Penny Zheng wrote: > @@ -922,33 +927,82 @@ static mfn_t __init acquire_shared_memory_bank(struct domain *d, > d->max_pages += nr_pfns; > > smfn = maddr_to_mfn(pbase); > - res = acquire_domstatic_pages(d, smfn, nr_pfns, 0); > - if ( res ) > + page = mfn_to_page(smfn); > + /* > + * If page is allocated from heap as static shared memory, then we just > + * assign it to the owner domain > + */ > + if ( page->count_info == (PGC_state_inuse | PGC_static) ) I am a bit confused how this can help differentiating becaPGC_state_inuse is 0. So effectively, you are checking that count_info is equal to PGC_static. But as I wrote in a previous patch, I don't think you should convert {xen,dom}heap pages to a static pages. [...] > +static int __init assign_shared_memory(struct domain *d, > + struct shm_membank *shm_membank, > + paddr_t gbase) > +{ > + int ret = 0; > + unsigned long nr_pages, nr_borrowers; > + struct page_info *page; > + unsigned int i; > + struct meminfo *meminfo; > + > + /* Host address is not provided in "xen,shared-mem" */ > + if ( shm_membank->mem.banks.meminfo ) > + { > + meminfo = shm_membank->mem.banks.meminfo; > + for ( i = 0; i < meminfo->nr_banks; i++ ) > + { > + ret = acquire_shared_memory(d, > + meminfo->bank[i].start, > + meminfo->bank[i].size, > + gbase); > + if ( ret ) > + return ret; > + > + gbase += meminfo->bank[i].size; > + } > + } > + else > + { > + ret = acquire_shared_memory(d, > + shm_membank->mem.bank->start, > + shm_membank->mem.bank->size, gbase); > + if ( ret ) > + return ret; > + } Looking at this change and... > + > /* > * Get the right amount of references per page, which is the number of > * borrower domains. > @@ -984,23 +1076,37 @@ static int __init assign_shared_memory(struct domain *d, > * So if the borrower is created first, it will cause adding pages > * in the P2M without reference. > */ > - page = mfn_to_page(smfn); > - for ( i = 0; i < nr_pages; i++ ) > + if ( shm_membank->mem.banks.meminfo ) > { > - if ( !get_page_nr(page + i, d, nr_borrowers) ) > + meminfo = shm_membank->mem.banks.meminfo; > + for ( i = 0; i < meminfo->nr_banks; i++ ) > { > - printk(XENLOG_ERR > - "Failed to add %lu references to page %"PRI_mfn".\n", > - nr_borrowers, mfn_x(smfn) + i); > - goto fail; > + page = mfn_to_page(maddr_to_mfn(meminfo->bank[i].start)); > + nr_pages = PFN_DOWN(meminfo->bank[i].size); > + ret = add_shared_memory_ref(d, page, nr_pages, nr_borrowers); > + if ( ret ) > + goto fail; > } > } > + else > + { > + page = mfn_to_page( > + maddr_to_mfn(shm_membank->mem.bank->start)); > + nr_pages = shm_membank->mem.bank->size >> PAGE_SHIFT; > + ret = add_shared_memory_ref(d, page, nr_pages, nr_borrowers); > + if ( ret ) > + return ret; > + } ... this one. The code to deal with a bank is exactly the same. But you need the duplication because you special case "one bank". As I wrote in a previous patch, I don't think we should special case it. If the concern is memory usage, then we should look at reworking meminfo instead (or using a different structure). > > return 0; > > fail: > while ( --i >= 0 ) > - put_page_nr(page + i, nr_borrowers); > + { > + page = mfn_to_page(maddr_to_mfn(meminfo->bank[i].start)); > + nr_pages = PFN_DOWN(meminfo->bank[i].size); > + remove_shared_memory_ref(page, nr_pages, nr_borrowers); > + } > return ret; > } > Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Jan 08 12:54:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 08 Jan 2023 12:54:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473159.733644 (Exim 4.92) (envelope-from ) id 1pEVBq-0003As-BI; Sun, 08 Jan 2023 12:54:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473159.733644; Sun, 08 Jan 2023 12:54:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEVBq-0003Al-7O; Sun, 08 Jan 2023 12:54:18 +0000 Received: by outflank-mailman (input) for mailman id 473159; Sun, 08 Jan 2023 12:54:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEVBo-0003Ab-U6 for xen-devel@lists.xenproject.org; Sun, 08 Jan 2023 12:54:16 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEVBo-0006ZW-4E; Sun, 08 Jan 2023 12:54:16 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pEVBn-0004tf-VO; Sun, 08 Jan 2023 12:54:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: References:Cc:To:From:Subject:MIME-Version:Date:Message-ID; bh=mpwGGOGOV4+9snxHoL34MVzq/OouXdyYF0EdBGrWeZE=; b=QaKOzd2UTu+Lo9eoaRG+V/zb6r tTpuMAz6ZYEvjR6krF9+ne8+IWK/jFmHQSHPSEBhY3ccfPlIPtkZA/ObJDP1bWflIkHclejOyLKw8 F7s33PsONN3sZP5khxnLJ1j0L4OxFh7DBIfw6a7oG5/tbemiPG+tnmiHAeKpR3u0PoFo=; Message-ID: Date: Sun, 8 Jan 2023 12:54:14 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v1 04/13] xen/arm: expand shm_membank for unprovided host address From: Julien Grall To: Penny Zheng , xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20221115025235.1378931-1-Penny.Zheng@arm.com> <20221115025235.1378931-5-Penny.Zheng@arm.com> <3832d94f-6856-82b3-ea64-a9e79460c547@xen.org> In-Reply-To: <3832d94f-6856-82b3-ea64-a9e79460c547@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 08/01/2023 12:13, Julien Grall wrote: > Hi Penny, > > On 15/11/2022 02:52, Penny Zheng wrote: >> When host address is not provided in "xen,shared-mem", we let Xen >> automatically allocate requested static shared memory from heap, and it >> stands good chance of having multiple host memory banks allocated for the >> requested static shared memory as a result. Therefore current membank >> is not >> going to cover it. >> >> This commit introduces a new field "mem" to cover both scenarios. >> "struct membank" is used when host address is provided, whereas >> "struct meminfo" shall be used when host address not provided. > > From this patch, it is not clear to me how a user can know which part > of the union should be used. Ah it is a struct rather than an union. Yet... > > However... I am not entirely sure why you need to create a union because > in your new structure you can fit one bank. ... my point here stands. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Jan 08 13:18:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 08 Jan 2023 13:18:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473166.733655 (Exim 4.92) (envelope-from ) id 1pEVZK-0005j1-8o; Sun, 08 Jan 2023 13:18:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473166.733655; Sun, 08 Jan 2023 13:18:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEVZK-0005iu-5o; Sun, 08 Jan 2023 13:18:34 +0000 Received: by outflank-mailman (input) for mailman id 473166; Sun, 08 Jan 2023 13:18:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEVZI-0005io-HX for xen-devel@lists.xenproject.org; Sun, 08 Jan 2023 13:18:32 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEVZI-00078g-2f; Sun, 08 Jan 2023 13:18:32 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pEVZH-0005zV-Sb; Sun, 08 Jan 2023 13:18:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=7Q80rUEM6UxqVUpefjUUaTM3iolJdTQeW1ClY4I1A7c=; b=e9nO+s2xyHRlP92vbvMs1CwT6U Yfh6KjEdObwHMUbxKytiCXjfPh6L8j7H6RnNWXzecDxXrpnHcGghA/aka58VMwEfdwt8cmmQC4gv8 UUbuqlUFGsrQjZb6R9XZOA6CdkyVYURLQ2cVzWOC54pvs7r4ll6HQF/ryvBS+h4pJkwo=; Message-ID: <3de0f1fe-19a8-8cfe-4a50-f8905f64bdd6@xen.org> Date: Sun, 8 Jan 2023 13:18:29 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 To: Penny Zheng , xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Bertrand Marquis , Volodymyr Babchuk References: <20221115025235.1378931-1-Penny.Zheng@arm.com> <20221115025235.1378931-14-Penny.Zheng@arm.com> From: Julien Grall Subject: Re: [PATCH v1 13/13] xen: make static shared memory supported in SUPPORT.md In-Reply-To: <20221115025235.1378931-14-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Penny, On 15/11/2022 02:52, Penny Zheng wrote: > After patching previous commits, we could make feature of "static shared memory" Are you referring to the patch in this series? If so, they seem to had new features which I don't think are necessary to mark the "static shared memory". Instead, "static shared memory" could be marked as supported if we believe that the new code has no security hole. Looking below, the STATIC_SHM depends on STATIC_MEMORY which is currently unsupported. So it seems a bit strange to mark one supported but not the other. Now, in order to support them, we need to make sure that the XENMEM_* operations are working as intended. I know there are some works that were done in the past, but I can't exactly remember if we fixed everything. So what happen if the domain (consider the case where the domain is directmapped or not): 1) Remove the page? 2) Remove the page twice? (Only in the directmap case) 3) Request to map the page? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Jan 08 16:02:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 08 Jan 2023 16:02:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473175.733666 (Exim 4.92) (envelope-from ) id 1pEY7V-0005id-SS; Sun, 08 Jan 2023 16:02:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473175.733666; Sun, 08 Jan 2023 16:02:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEY7V-0005iW-Ny; Sun, 08 Jan 2023 16:02:01 +0000 Received: by outflank-mailman (input) for mailman id 473175; Sun, 08 Jan 2023 16:01:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEY7T-0005iQ-If for xen-devel@lists.xenproject.org; Sun, 08 Jan 2023 16:01:59 +0000 Received: from sonic307-55.consmr.mail.gq1.yahoo.com (sonic307-55.consmr.mail.gq1.yahoo.com [98.137.64.31]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c3e3a156-8f6d-11ed-91b6-6bf2151ebd3b; Sun, 08 Jan 2023 17:01:55 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.gq1.yahoo.com with HTTP; Sun, 8 Jan 2023 16:01:51 +0000 Received: by hermes--production-ne1-7b69748c4d-dzr9v (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 472b6276cf2cc0deb61dd8cd01ce9286; Sun, 08 Jan 2023 16:01:45 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c3e3a156-8f6d-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1673193711; bh=j/7REqUdpZNLaRsnWjMV+rHTABevisAIlRn8Ne5heHo=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From:Subject:Reply-To; b=CK566PHrpi57mTF6dEykqonSl4NCcWgRHD0SxIjg8azrvsHyAGsLgNL48tylANTWNMqT27z/qefWR5yk5FlwV7a12VP5J3ohequZNOgRv3GZxF2TUuwpGHapyfzTaj9mbxvKu11l2VLv4IsgW/88Zb6S/SvSjRnrAsD0dr1SJJ81EAOg/FjYjfpI+4CCJLLcH+NjUGQEuWxCaGK5i+HzsYG0KX2feA8ZaC8dlovA1hvNqcbrhjaU2CbpWoLZdA+l91auWfKxKeTf+8n2hfYuP+dN2PRF+vDoqCdOxwIZJg+DyZGPNysZ7j5NftIoQPaksWtWclrHCMwIi9ueUqi21w== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1673193711; bh=mwmcsLfD1qcJX5LwxSSnbsMwmw6uNLxC/Ndv5pDi2iH=; h=X-Sonic-MF:Date:Subject:From:To:From:Subject; b=t9cdDfsqNdFXrSZuy4KeRJ7oMspGv1IMnpARwxS3tmjcjbc7NCPPckPpZxq//d6mGQ+yaN8Jvsli1TnQm4IffSnbbhwAO/lbQrO5lveAwl1m9ol1kZGPXXgVeUX5ERxI5JKxgNCzYTvAQvH1QAlveyMsngmpm9yVjC3NU//PusBPS5yGtQvbbEb5rvgDbxYKPn05jHhfw9dmQHqR1pazcXmn6y30AhOYHRiIEXLjcFyfW2VBH9QIxJJn/8OCYXp6VQHA8MmJ9PHqaixbFIjUoKY7PnyQgR65hpuaKw/5ioKspNDkZk1qiSNgEv7un6zLBOVzQTt4Q9zXafAqQK5YEg== X-YMail-OSG: x9Gz0rUVM1lNIL_HEu9RrHIUXk4jsl6PSPnwtx.kmzvYoHOXSAjNMmto23elA2w TDtb22kmikRqJIJFY6hH96vw_AuwGnYbzsNjQI_3h6lJ.5GDFKIMIUNKCh2mdLTkvHd8tMLMnXMV SJYtETssrKviv8OJSAWOVd4MCmLEICYJ4VdIOXhBzChJwxjVKbljv6ggXsTJ.SXaqQQo85_FUBrO gZULtiCI7ULTNvh_NiRDUnubpwCIw2.isLQ8sFSH9NYd0OfiSjm_4pmcW9SCcEJVLzLst89A_dok R25xGJNiLMaKRGydtKFmjRbsBCgq2GE9y50hOUnNnZr2.TVBrdBI5y3HSfg2zwwoTwn4GPA4ynGP EKGk_n5Ep6BdUedGYgz4fwgYGbr59Szi7I1GKToR2fA2OKFYC39rCCp5mzk2HV8ZsNeeC36z6OCA SnD0Zz12__r9btmgO0L4hze5MFYG6BfN0x8eqbD_5HchMqSR8wE_UPGo9Pws_4CcpAslVzRlvpIK 5HYtUfd.g5yJmf7iWQKu.cKimrM5nR34nAlE38DgR1zyQkTC9lGzcTCd_KdGQhdWQq.lmfyDc3s7 l63F7FJdqukv5gn9zuzdtHCcRDJMOuujHEuZdirsyY1toZSiwDsHfbF0xPBK28ElafpTzDy7ojX8 gZQ8MFrbZUxcS02ycp48T6.9bJNv9tR6Q4H8By5kGi3ldmQm5IcAww374SSduBlfl47HZgMnInyP R9fzkaYbR34KCjK5sSQLjIhFoWVkW9cZe_rc9Ipq532Bi5nk2E59vmP0HQLbX9y.KamIEOt1sD_d BK5zefbGvYPEriM65sbWJ0Ab8vKayzS2tiSbN2r_hLJXXyMN0G05GQWnzoTez.irKAz5Bn45dAY8 QCCkHqCrvfxwm0WQRxJnhLX9ON2qARSkYuKf.ZMr0ClrioPTh_Aea6eZQD6VTMZALvPK3x8ZtYRL oJnwTWm5Mwz.PsLsedCZZM7L5DRq_U2FvrqBLRG.RmDMrNi2KsXLaTWZR4f.E_BbL2gCerX6nKgX SlA55qwFW0SQ4SsIbihXUOxn4XqvKTeUgI5wjMil_yKTcQiv0CmhZ2x1zF1Jwb3QQd7blPicH9oh iergd.UgHRIwHj0kvRxLl3Qzr6RkArcHKKkY2KapLHyIBsriGRzQrYkjAc91whiVZJHVs1mXaHul YwY1xxNm9Ro1mZt7fAMOCJ2Djkz7bkI.6S8GTmC_zb3Kygq3ikuJnvbnOUaoqWjXtp66a2P4piIG HPhQHCLhNM44RUNJoCWrIJfnMxqsFE1PLESV8OUjEdjgoy8EqMeETv6ER5hu4onIuQRIBiPtZf4P S0Np7j1GwGKXJH7B05UPqc4n1lH6cZ8mEQ7uFGvCXjgp48YmqTzC_7XJVFuHdPmngk9Xu4UlAOU9 BNNg7K.FEd2r.8gPxiRYxRwPRQV.PYRYsUKOnY.c6elbAnWfRUlXAOGJIns3isuOYcEt5QhOqpf0 uMYWyZy_o1jnTrIE8PEJmthNjxnxZ_qhacyo1j9isZQ3wCdOgxuVyIsniWulr3btMXXE0pOxenVu ir3d7ftco5Ho_FpRdnvEG4CVeXLS81DbCSYYbGJKAvJmSGLWbZ4Ba09EGUXSPqeekUi2C67XCBOs osZue6sQTE4aYYb5sV30i6XPveB_xXAXUWT9TEG6qpT8YCDFkNEDS_yP8R06KVb0N1GNv5TCozwW PZQUOeG3MzObYrKODEwBimRiUF._pkaJB84tlBlDsCj3t1.skRswlBiqO.YDWHmLCE7P1tRbAr2b .YibCfY0tq9j5HF2jQawxzo53M4Gy1OgifIH3RzP4asmqpkFTzOsVqv5VB5g2PSG0QwErlKy0Jyg f0QnIeSM1pRoZOSmJONNYrmQIhQa8.ep8BX.gwJJDSqOuvhq4cJiUTXkWmP1Mt3g36QmkS5NtQBg k2uvw7ED8aevoYi0vMR08mZOP4WERjem02oy0Vh4UnL4E6vJEndUqOoE67EFQhHgNzGthr1Su1tO q8kKYq4E1jzdPibGfattBdFBh.SQnUQZtwtsJwBfbgqtOXyzUHkuwS4M8Qk806sJyjcriefoBxrG 9Do6xMAfMEPDHcZXHRdYP3lAEQCg_W2Dq0MD9n8S6PrKOhVGWDcIXNOXQ8Sx3IeH6EUod8xXjDsv ZhFyhsbg7Szkh2BgXB4cSX6DuMywv9g.h6F9Z0daqM9o5hx2oAc9RRSCdq_aviX.GuOeL9kbcNU4 2rvCLBBA6cD8- X-Sonic-MF: Message-ID: <2772822b-cbd3-ea25-2742-a4de195e8dbd@aol.com> Date: Sun, 8 Jan 2023 11:01:44 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v6] xen/pt: reserve PCI slot 2 for Intel igd-passthru From: Chuck Zmudzinski To: Anthony PERARD Cc: qemu-devel@nongnu.org, Stefano Stabellini , Paul Durrant , Paolo Bonzini , Richard Henderson , Eduardo Habkost , "Michael S. Tsirkin" , Marcel Apfelbaum , xen-devel@lists.xenproject.org References: <830263507e8f1a24a94f81909d5102c4b204e938.1672615492.git.brchuckz.ref@aol.com> <830263507e8f1a24a94f81909d5102c4b204e938.1672615492.git.brchuckz@aol.com> <882652f8-ddda-a7d8-85b9-da46568036d3@aol.com> <6931ef9f-1978-97f5-2d32-003a9e64833c@aol.com> Content-Language: en-US In-Reply-To: <6931ef9f-1978-97f5-2d32-003a9e64833c@aol.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.20982 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 2493 On 1/6/2023 10:02 AM, Chuck Zmudzinski wrote: > On 1/6/23 9:31 AM, Chuck Zmudzinski wrote: > > On 1/6/23 9:10 AM, Chuck Zmudzinski wrote: > >> On 1/6/23 9:03 AM, Anthony PERARD wrote: > >>> On Sun, Jan 01, 2023 at 06:52:03PM -0500, Chuck Zmudzinski wrote: > >>>> ... > >>>> > >>>> Signed-off-by: Chuck Zmudzinski > >>> > >>> > >>> This patch looks good enough. It only changes the "xenfv" machine so it > >>> doesn't prevent a proper fix to be done in the toolstack libxl. > >>> > >>> The change in xen_pci_passthrough_class_init() to try to run some code > >>> before pci_qdev_realize() could potentially break in the future due to > >>> been uncommon but hopefully that will be ok. > >>> > >>> So if no work to fix libxl appear soon, I'm ok with this patch: I have a patch that fixes it in libxl. It still needs a few tweaks before it is ready for submission, but I plan to do that soon, perhaps later today or tomorrow at the latest. > > > > Well, I can tell you and others who use qemu are more comfortable > > fixing this in libxl, so hold off for a week or so. I should have > > a patch to fix this in libxl written and tested by then. If for > > some reason that does not work out, then we can fix it in qemu. > > One last thought: the only donwnside to fixing this in libxl is that > other toolstacks that configure qemu to use the xenfv machine will not > benefit from the fix in qemu that would simplify configuring the > guest correctly for the igd. Other toolstacks would still need to > override the default behavior of adding the xen platform device at > slot 2. I think no matter what, we should at least patch qemu to have > the xen-platform device use slot 3 instead of being automatically assigned > to slot 2 when igd-passthru=on. The rest of the fix could then be > implemented in libxl so that other pci devices such as emulated network > devices, other passed through pci devices, etc., do not take slot 2 when > gfx_passthru in xl.cfg is set. I decided to write the patch to libxl to fix this presuming no changes to qemu. I think dealing with the "qemu behaves differently starting from version 8 problem" is more trouble that it's worth, so I am OK with implementing the fix completely in libxl, which means libxl will now use the "pc" machine type when igd-passthru=on and xen_platform_pci is true, but my patch to libxl will still use the "xenfv" machine when xen_platform_pci is true and igd-passthru is disabled. Cheers, Chuck From xen-devel-bounces@lists.xenproject.org Sun Jan 08 16:07:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 08 Jan 2023 16:07:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473183.733677 (Exim 4.92) (envelope-from ) id 1pEYCM-0006Ox-Js; Sun, 08 Jan 2023 16:07:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473183.733677; Sun, 08 Jan 2023 16:07:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEYCM-0006Oq-GX; Sun, 08 Jan 2023 16:07:02 +0000 Received: by outflank-mailman (input) for mailman id 473183; Sun, 08 Jan 2023 16:07:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEYCL-0006Ok-MQ for xen-devel@lists.xenproject.org; Sun, 08 Jan 2023 16:07:01 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEYCL-0002oi-AO; Sun, 08 Jan 2023 16:07:01 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pEYCL-0003go-42; Sun, 08 Jan 2023 16:07:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=lLRsBB8Nv9xfhlmusdMdDlR0vRlqvO+R9Os1teUNfd0=; b=5wgzVLwFES9dTOFu3lJnIuiKzG LXRpr0o5mf228VhcGUiIpChjRph8QpFsvZf30LCPs0csfPdxIA544AKUl2NXD3xZ6eUzoMXduKxLQ pK2k+BzvpqTXB8+uWqG475hSiB6bPV8A8qHIqNfjISyJMEt/nTvws6H5E3DTwoD0A0Cs=; Message-ID: Date: Sun, 8 Jan 2023 16:06:59 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 To: Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefano.stabellini@amd.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, michal.orzel@amd.com, Oleksandr Tyshchenko References: <20221221185300.5309-1-ayan.kumar.halder@amd.com> From: Julien Grall Subject: Re: [XEN v4] xen/arm: Probe the load/entry point address of an uImage correctly In-Reply-To: <20221221185300.5309-1-ayan.kumar.halder@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Ayan, On 21/12/2022 18:53, Ayan Kumar Halder wrote: > Currently, kernel_uimage_probe() does not read the load/entry point address > set in the uImge header. Thus, info->zimage.start is 0 (default value). This > causes, kernel_zimage_place() to treat the binary (contained within uImage) > as position independent executable. Thus, it loads it at an incorrect > address. > > The correct approach would be to read "uimage.load" and set > info->zimage.start. This will ensure that the binary is loaded at the > correct address. Also, read "uimage.ep" and set info->entry (ie kernel entry > address). > > If user provides load address (ie "uimage.load") as 0x0, then the image is > treated as position independent executable. Xen can load such an image at > any address it considers appropriate. A position independent executable > cannot have a fixed entry point address. > > This behavior is applicable for both arm32 and arm64 platforms. > > Earlier for arm32 and arm64 platforms, Xen was ignoring the load and entry > point address set in the uImage header. With this commit, Xen will use them. > This makes the behavior of Xen consistent with uboot for uimage headers. The changes look good to me (with a few of comments below). That said, before acking the code, I would like an existing user of uImage (maybe EPAM or Arm?) to confirm they are happy with the change. > > Users who want to use Xen with statically partitioned domains, can provide > non zero load address and entry address for the dom0/domU kernel. It is > required that the load and entry address provided must be within the memory > region allocated by Xen. > > A deviation from uboot behaviour is that we consider load address == 0x0, > to denote that the image supports position independent execution. This > is to make the behavior consistent across uImage and zImage. > > Signed-off-by: Ayan Kumar Halder > --- > > Changes from v1 :- > 1. Added a check to ensure load address and entry address are the same. > 2. Considered load address == 0x0 as position independent execution. > 3. Ensured that the uImage header interpretation is consistent across > arm32 and arm64. > > v2 :- > 1. Mentioned the change in existing behavior in booting.txt. > 2. Updated booting.txt with a new section to document "Booting Guests". > > v3 :- > 1. Removed the constraint that the entry point should be same as the load > address. Thus, Xen uses both the load address and entry point to determine > where the image is to be copied and the start address. > 2. Updated documentation to denote that load address and start address > should be within the memory region allocated by Xen. > 3. Added constraint that user cannot provide entry point for a position > independent executable (PIE) image. > > docs/misc/arm/booting.txt | 26 ++++++++++++++++++ > xen/arch/arm/include/asm/kernel.h | 2 +- > xen/arch/arm/kernel.c | 45 ++++++++++++++++++++++++++++--- > 3 files changed, 69 insertions(+), 4 deletions(-) > > diff --git a/docs/misc/arm/booting.txt b/docs/misc/arm/booting.txt > index 3e0c03e065..12339dfecb 100644 > --- a/docs/misc/arm/booting.txt > +++ b/docs/misc/arm/booting.txt > @@ -23,6 +23,28 @@ The exceptions to this on 32-bit ARM are as follows: > > There are no exception on 64-bit ARM. > > +Booting Guests > +-------------- > + > +Xen supports the legacy image header[3], zImage protocol for 32-bit > +ARM Linux[1] and Image protocol defined for ARM64[2]. > + > +Earlier for legacy image protocol, Xen ignored the load address and We should explicitly say when the change was introduced. So please replace "Earlier" with "Until Xen 4.17...". The rest of the sentence may be reworded. > +entry point specified in the header. This has now changed. > + > +Now, it loads the image at the load address provided in the header. > +And the entry point is used as the kernel start address. > + > +A deviation from uboot is that, Xen treats "load address == 0x0" as > +position independent execution (PIE). Thus, Xen will load such an image > +at an address it considers appropriate. Also, user cannot specify the > +entry point of a PIE image since the start address cennot be > +predetermined. > + > +Users who want to use Xen with statically partitioned domains, can provide > +the fixed non zero load address and start address for the dom0/domU kernel. > +The load address and start address specified by the user in the header must > +be within the memory region allocated by Xen. > > Firmware/bootloader requirements > -------------------------------- > @@ -39,3 +61,7 @@ Latest version: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/t > > [2] linux/Documentation/arm64/booting.rst > Latest version: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/arm64/booting.rst > + > +[3] legacy format header > +Latest version: https://source.denx.de/u-boot/u-boot/-/blob/master/include/image.h#L315 > +https://linux.die.net/man/1/mkimage > diff --git a/xen/arch/arm/include/asm/kernel.h b/xen/arch/arm/include/asm/kernel.h > index 5bb30c3f2f..4617cdc83b 100644 > --- a/xen/arch/arm/include/asm/kernel.h > +++ b/xen/arch/arm/include/asm/kernel.h > @@ -72,7 +72,7 @@ struct kernel_info { > #ifdef CONFIG_ARM_64 > paddr_t text_offset; /* 64-bit Image only */ > #endif > - paddr_t start; /* 32-bit zImage only */ > + paddr_t start; /* Must be 0 for 64-bit Image */ > } zimage; > }; > }; > diff --git a/xen/arch/arm/kernel.c b/xen/arch/arm/kernel.c > index 23b840ea9e..58b3db0aa4 100644 > --- a/xen/arch/arm/kernel.c > +++ b/xen/arch/arm/kernel.c > @@ -127,7 +127,7 @@ static paddr_t __init kernel_zimage_place(struct kernel_info *info) > paddr_t load_addr; > > #ifdef CONFIG_ARM_64 > - if ( info->type == DOMAIN_64BIT ) > + if ( (info->type == DOMAIN_64BIT) && (info->zimage.start == 0) ) > return info->mem.bank[0].start + info->zimage.text_offset; > #endif > > @@ -162,7 +162,12 @@ static void __init kernel_zimage_load(struct kernel_info *info) > void *kernel; > int rc; > > - info->entry = load_addr; > + /* > + * If the image does not have a fixed entry point, then use the load > + * address as the entry point. > + */ > + if ( info->entry == 0 ) > + info->entry = load_addr; > > place_modules(info, load_addr, load_addr + len); > > @@ -223,10 +228,35 @@ static int __init kernel_uimage_probe(struct kernel_info *info, > if ( len > size - sizeof(uimage) ) > return -EINVAL; > > + info->zimage.start = be32_to_cpu(uimage.load); > + info->entry = be32_to_cpu(uimage.ep); > + > + /* > + * While uboot considers 0x0 to be a valid load/start address, for Xen > + * to mantain parity with zimage, we consider 0x0 to denote position s/mantain/maintain/ s/zimage/zImage/ > + * independent image. That means Xen is free to load such an image at > + * any valid address. > + * Thus, we will print an appropriate message. NIT: No need to say you will print a message. > + */ > + if ( info->zimage.start == 0 ) > + printk(XENLOG_INFO > + "No load address provided. Xen will decide where to load it.\n"); NIT: I would consider to add a else and printing the requested load address and entry point. > + > + /* > + * If the image supports position independent execution, then user cannot > + * provide an entry point as Xen will load such an image at any appropriate > + * memory address. Thus, we need to return error. > + */ > + if ( (info->zimage.start == 0) && (info->entry != 0) ) > + { > + printk(XENLOG_ERR > + "Entry point cannot be non zero for PIE image.\n"); > + return -EINVAL; > + } > + > info->zimage.kernel_addr = addr + sizeof(uimage); > info->zimage.len = len; > > - info->entry = info->zimage.start; > info->load = kernel_zimage_load; > > #ifdef CONFIG_ARM_64 > @@ -366,6 +396,7 @@ static int __init kernel_zimage64_probe(struct kernel_info *info, > info->zimage.kernel_addr = addr; > info->zimage.len = end - start; > info->zimage.text_offset = zimage.text_offset; > + info->zimage.start = 0; > > info->load = kernel_zimage_load; > > @@ -436,6 +467,14 @@ int __init kernel_probe(struct kernel_info *info, > u64 kernel_addr, initrd_addr, dtb_addr, size; > int rc; > > + /* We need to initialize start to 0. This field may be populated during Coding style: /* * Foo * Bar */ > + * kernel_xxx_probe() if the image has a fixed entry point (for eg s/eg/e.g./ > + * uimage.ep). > + * We will use this to determine if the image has a fixed entry point or > + * the load address should be used as the start address. > + */ > + info->entry = 0; > + > /* domain is NULL only for the hardware domain */ > if ( domain == NULL ) > { Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Jan 08 16:15:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 08 Jan 2023 16:15:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473190.733687 (Exim 4.92) (envelope-from ) id 1pEYKM-0007sA-DN; Sun, 08 Jan 2023 16:15:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473190.733687; Sun, 08 Jan 2023 16:15:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEYKM-0007s3-AV; Sun, 08 Jan 2023 16:15:18 +0000 Received: by outflank-mailman (input) for mailman id 473190; Sun, 08 Jan 2023 16:15:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEYKK-0007rx-Li for xen-devel@lists.xenproject.org; Sun, 08 Jan 2023 16:15:16 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEYKI-0002wD-B7; Sun, 08 Jan 2023 16:15:14 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pEYKI-00048z-4P; Sun, 08 Jan 2023 16:15:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=GmJ/zyeoEhIUHgdbR+I4UZJePj+rfIrAL48WhbxkeSM=; b=YC8sprd7xd+Z8RbQAxqCRoy4Xq leyu1wzrZhxoUx8sEQ4sfJn2JH5cknpVxYb1+/BpTRcV2QzQsVf56mBo9C8+vgTEn0jEVe1PTq/KM Y1kE4w1pYiD/KVpLF5GFUb2o9QYLfSBmlqp0Aa9ixynOhxeN9qwAcz8/8nLxP9rovoNw=; Message-ID: <611b0857-155a-a50b-5996-ce735ebce22d@xen.org> Date: Sun, 8 Jan 2023 16:15:12 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 To: Bertrand Marquis , Stefano Stabellini Cc: Henry Wang , Wei Chen , Volodymyr Babchuk , "xen-devel@lists.xenproject.org" References: <20221014080917.14980-1-Henry.Wang@arm.com> <9d5ab09e-650f-118d-0233-d7988f1504f1@xen.org> From: Julien Grall Subject: Re: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in arch_domain_create() In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Bertrand, On 03/01/2023 12:34, Bertrand Marquis wrote: > Hi, > > Sorry for the delay but I have very limited access to my mails right now. > >> On 9 Dec 2022, at 23:11, Stefano Stabellini > > wrote: >> >> On Fri, 9 Dec 2022, Julien Grall wrote: >>> Hi Henry, >>> >>> On 08/12/2022 03:06, Henry Wang wrote: >>>> I am trying to work on the follow-up improvements about the Arm P2M >>>> code, >>>> and while trying to address the comment below, I noticed there was an >>>> unfinished >>>> discussion between me and Julien which I would like to continue and here >>>> opinions from all of you (if possible). >>>> >>>>> -----Original Message----- >>>>> From: Julien Grall > >>>>> Subject: Re: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 >>>>> mapping in >>>>> arch_domain_create() >>>>>>> I also noticed that relinquish_p2m_mapping() is not called. This >>>>>>> should >>>>>>> be fine for us because arch_domain_create() should never create a >>>>>>> mapping that requires p2m_put_l3_page() to be called. >>>> >>>> For the background of the discussion, this was about the failure path of >>>> arch_domain_create(), where we only call p2m_final_teardown() which does >>>> not call relinquish_p2m_mapping()... >>> So all this mess with the P2M is necessary because we are mapping the >>> GICv2 >>> CPU interface in arch_domain_create(). I think we should consider to >>> defer the >>> mapping to later. >>> >>> Other than it makes the code simpler, it also means we could also the >>> P2M root >>> on the same numa node the domain is going to run (those information >>> are passed >>> later on). >>> >>> There is a couple of options: >>> 1. Introduce a new hypercall to finish the initialization of a domain >>> (e.g. >>> allocating the P2M and map the GICv2 CPU interface). This option was >>> briefly >>> discussed with Jan (see [2])./ >>> 2. Allocate the P2M when populate the P2M pool and defer the GICv2 CPU >>> interface mapping until the first access (similar to how with deal >>> with MMIO >>> access for ACPI). >>> >>> I find the second option is neater but it has the drawback that it >>> requires on >>> more trap to the hypervisor and we can't report any mapping failure >>> (which >>> should not happen if the P2M was correctly sized). So I am leaning >>> towards >>> option 2. >>> >>> Any opinions? >> >> Option 1 is not great due to the extra hypercall. But I worry that >> option 2 might make things harder for safety because the >> mapping/initialization becomes "dynamic". I don't know if this is a >> valid concern. >> >> I would love to hear Bertrand's thoughts about it. Putting him in To: > > How option 1 would work for dom0less ? Xen would call the function directly. Effectively, this would the same as all the other "hypercalls" we are using to build a dom0less domain. > > Option 2 would make safety more challenging but not impossible (we have > a lot of other use cases where we cannot map everything on boot). > > I would vote for option 2 as I think we will not certify gicv2 and it is > not adding an other hyper call. It sounds like option 2 is the preferred way for now. Henry, can you have a look? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Jan 08 16:30:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 08 Jan 2023 16:30:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473198.733698 (Exim 4.92) (envelope-from ) id 1pEYYy-0001lO-M6; Sun, 08 Jan 2023 16:30:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473198.733698; Sun, 08 Jan 2023 16:30:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEYYy-0001lH-JU; Sun, 08 Jan 2023 16:30:24 +0000 Received: by outflank-mailman (input) for mailman id 473198; Sun, 08 Jan 2023 16:30:23 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEYYx-0001lB-7b for xen-devel@lists.xenproject.org; Sun, 08 Jan 2023 16:30:23 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEYYu-0003KX-74; Sun, 08 Jan 2023 16:30:20 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pEYYu-0004dP-09; Sun, 08 Jan 2023 16:30:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=VqVrJAhAwMQZyArxthFYx4Bi7j19mKF+UQf2Vp0behw=; b=wyBgwnw1ukLAB2drrYM1VA2lQk fUiUHCf0C+5mDIzder8uOpk0YCHZyQbuhU781JBLgJcKQZXF/LBlJp7UPH1bQ4CrpliKw6Ey8JApk vAY9ZOuj0SyAbVbMWvdGSyzyd1NFXr1LoDANwQJANlArhatBwoF+M1QMeRp9HVjIeVLs=; Message-ID: <7b0435dd-bf2b-fa26-daba-7dec43f9c88e@xen.org> Date: Sun, 8 Jan 2023 16:30:17 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 To: Stefano Stabellini Cc: Demi Marie Obenour , "Smith, Jackson" , "Brookes, Scott" , Xen-devel , "bertrand.marquis@arm.com" , "jbeulich@suse.com" , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , "Daniel P. Smith" , "christopher.w.clark@gmail.com" References: <513d0cc3-a305-5029-32f7-67993ae83c55@xen.org> <7a7a7156-138d-a53c-fb65-a210e14bd8c1@xen.org> From: Julien Grall Subject: Re: [RFC 0/4] Adding Virtual Memory Fuses to Xen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Stefano, On 22/12/2022 21:28, Stefano Stabellini wrote: > On Thu, 22 Dec 2022, Julien Grall wrote: >>> What other hypervisors might or might not do should not be a factor in >>> this discussion and it would be best to leave it aside. >> >> To be honest, Demi has a point. At the moment, VMF is a very niche use-case >> (see more below). So you would end up to use less than 10% of the normal Xen >> on Arm code. A lot of people will likely wonder why using Xen in this case? > > [...] > >>> From an AMD/Xilinx point of view, most of our customers using Xen in >>> productions today don't use any hypercalls in one or more of their VMs. >> This suggests a mix of guests are running (some using hypercalls and other >> not). It would not be possible if you were using VMF. > > It is true that the current limitations are very restrictive. > > In embedded, we have a few pure static partitioning deployments where no > hypercalls are required (Linux is using hypercalls today but it could do > without), so maybe VMF could be enabled, but admittedly in those cases > the main focus today is safety and fault tolerance, rather than > confidential computing. > > >>> Xen is great for these use-cases and it is rather common in embedded. >>> It is certainly a different configuration from what most are come to >>> expect from Xen on the server/desktop x86 side. There is no question >>> that guests without hypercalls are important for Xen on ARM. > >>> As a Xen community we have a long history and strong interest in making >>> Xen more secure and also, more recently, safer (in the ISO 26262 >>> safety-certification sense). The VMF work is very well aligned with both >>> of these efforts and any additional burder to attackers is certainly >>> good for Xen. >> >> I agree that we have a strong focus on making Xen more secure. However, we >> also need to look at the use cases for it. As it stands, there will no: >> - IOREQ use (don't think about emulating TPM) >> - GICv3 ITS >> - stage-1 SMMUv3 >> - decoding of instructions when there is no syndrome >> - hypercalls (including event channels) >> - dom0 >> >> That's a lot of Xen features that can't be used. Effectively you will make Xen >> more "secure" for a very few users. > > Among these, the main problems affecting AMD/Xilinx users today would be: > - decoding of instructions > - hypercalls, especially event channels > > Decoding of instructions would affect all our deployments. For > hypercalls, even in static partitioning deployments, sometimes event > channels are used for VM-to-VM notifications. > > >>> Now the question is what changes are necessary and how to make them to >>> the codebase. And if it turns out that some of the changes are not >>> applicable or too complex to accept, the decision will be made purely >>> from a code maintenance point of view and will have nothing to do with >>> VMs making no hypercalls being unimportant (i.e. if we don't accept one >>> or more patches is not going to have anything to do with the use-case >>> being unimportant or what other hypervisors might or might not do). >> I disagree, I think this is also about use cases. On the paper VMF look very >> great, but so far it still has a big flaw (the TTBR can be changed) and it >> would restrict a lot what you can do. > > We would need to be very clear in the commit messages and documentation > that with the current version of VMF we do *not* achieve confidential > computing and we do *not* offer protections comparable to AMD SEV. It is > still possible for Xen to access guest data, it is just a bit harder. > > From an implementation perspective, if we can find a way to implement it > that would be easy to maintain, then it might still be worth it. It > would probably take only a small amount of changes on top of the "Remove > the directmap" series to make it so "map_domain_page" doesn't work > anymore after boot. None of the callers of map_domain_page() expect the function to fais. So some treewide changes will be needed in order to deal with map_domain_page() not working. This is not something I am willing to accept if the only user is VMF (at the moment I can't think of any other). So instead, we would need to come up with a way where map_domain_page() will never be called at runtime when VMF is in use (maybe by compiling out some code?). I haven't really looked in details to say whether that's feasiable. > > That might be worth exploring if you and Jackson agree? I am OK to continue explore it because I think some bits will be still useful for the general use. As for the full solution, I will wait and see the results before deciding whether this is something that I would be happy to merge/maintain. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Jan 08 16:54:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 08 Jan 2023 16:54:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473205.733710 (Exim 4.92) (envelope-from ) id 1pEYwP-0004Ca-KE; Sun, 08 Jan 2023 16:54:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473205.733710; Sun, 08 Jan 2023 16:54:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEYwP-0004CT-HN; Sun, 08 Jan 2023 16:54:37 +0000 Received: by outflank-mailman (input) for mailman id 473205; Sun, 08 Jan 2023 16:54:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEYwO-0004CJ-1e; Sun, 08 Jan 2023 16:54:36 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEYwN-0003rp-Uq; Sun, 08 Jan 2023 16:54:35 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEYwN-0004np-E5; Sun, 08 Jan 2023 16:54:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pEYwN-0008Jw-DJ; Sun, 08 Jan 2023 16:54:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=desVzAkbhywnJdfwHf3WYpQ1snGRZykxmVaKUSw5Ddo=; b=Er1uDf3Nhz6M9umu5bV95Y8+Lg VyACGTB63k72Sm2tMf80g7pPE0s6IwWJaA4gDaBpenxWh4TwE0FC+wQ1mYamSgTFCw73D00C0kGn2 474dyuNF0dGwQuo68aEE0lbH9/0exkuY1IUdWS5lDE8/vjvqW6pFEov6KuStMbmzcAQc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 175625: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=9b43a525db125799df81e6fbef712a2ae50bfc5d X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Sun, 08 Jan 2023 16:54:35 +0000 flight 175625 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/175625/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine 8 reboot fail REGR. vs. 173462 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux 9b43a525db125799df81e6fbef712a2ae50bfc5d baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 92 days Failing since 173470 2022-10-08 06:21:34 Z 92 days 193 attempts Testing same since 175622 2023-01-07 22:40:16 Z 0 days 2 attempts ------------------------------------------------------------ 3311 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 505194 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Jan 08 19:57:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 08 Jan 2023 19:57:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473267.733760 (Exim 4.92) (envelope-from ) id 1pEbmx-00070k-Kj; Sun, 08 Jan 2023 19:57:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473267.733760; Sun, 08 Jan 2023 19:57:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEbmx-00070d-Hg; Sun, 08 Jan 2023 19:57:03 +0000 Received: by outflank-mailman (input) for mailman id 473267; Sun, 08 Jan 2023 19:57:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEbmw-00070T-QZ; Sun, 08 Jan 2023 19:57:02 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEbmw-0008By-ND; Sun, 08 Jan 2023 19:57:02 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEbmw-0002Wk-4M; Sun, 08 Jan 2023 19:57:02 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pEbmw-0003LQ-3p; Sun, 08 Jan 2023 19:57:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=vuFWoXEQK0YC6GRfoj0lSn0ml8WP0jqgTBQOHLBu7nQ=; b=dZV1CGicLyrG5XGKIYToh1R7gK FwIn6QnBb6u4cbzX3xZnwB9X0ikwsAtgCB7omwHGLo4GTBhkrv5WKNy67db92t4Vjdet5n3MuJ1hF zaV0oKeE1tNNlDW1pzYJvPcp+Q3zWvKJptd8TWB9P3jaPSs/xbWABzj1xQ4soKiVmOrk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 175627: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression qemu-mainline:build-arm64-xsm:xen-build:fail:regression qemu-mainline:test-arm64-arm64-xl:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:regression qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=528d9f33cad5245c1099d77084c78bb2244d5143 X-Osstest-Versions-That: qemuu=0ab12aa32462817f0a53fa6f6ce4baf664ef1713 From: osstest service owner Date: Sun, 08 Jan 2023 19:57:02 +0000 flight 175627 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/175627/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 175623 build-arm64-xsm 6 xen-build fail REGR. vs. 175623 test-arm64-arm64-xl 18 guest-start/debian.repeat fail REGR. vs. 175623 test-amd64-amd64-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 175623 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 175623 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 175623 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175623 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175623 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 175623 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 175623 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175623 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175623 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu 528d9f33cad5245c1099d77084c78bb2244d5143 baseline version: qemuu 0ab12aa32462817f0a53fa6f6ce4baf664ef1713 Last test of basis 175623 2023-01-07 23:09:00 Z 0 days Testing same since 175627 2023-01-08 14:40:14 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Peter Maydell Richard Henderson jobs: build-amd64-xsm pass build-arm64-xsm fail build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm blocked test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 378 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Jan 09 01:32:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 01:32:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473287.733792 (Exim 4.92) (envelope-from ) id 1pEh1T-0008N0-Sk; Mon, 09 Jan 2023 01:32:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473287.733792; Mon, 09 Jan 2023 01:32:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEh1T-0008Ms-MY; Mon, 09 Jan 2023 01:32:23 +0000 Received: by outflank-mailman (input) for mailman id 473287; Mon, 09 Jan 2023 01:32:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEh1S-0008Mi-Et; Mon, 09 Jan 2023 01:32:22 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEh1S-0001si-CU; Mon, 09 Jan 2023 01:32:22 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEh1R-0006M0-Bi; Mon, 09 Jan 2023 01:32:21 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pEh1R-0004iI-9j; Mon, 09 Jan 2023 01:32:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=CcQ7YUgfX8GnSvWrI7mdAC5X6XqwrbR/DNYaueiSeM0=; b=1ORGlAKQiy+h0VrBmeImJpMkli W4paYqDaXaV+ehNa2zjA2hKoEVMpAtk/uDXz2g6Hb13dvtHTPjWysBr9KBkJZ1jGOnuEsWc4zvUEJ nARwyhq8PNZCr0YDiezkyoYu7jqbYrtVO+4k8QybDNHMnFZjeQPSi8UqPuc8elRG/39k=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 175628: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=93928d485d9df12be724cbdf1caa7d197b65001e X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Mon, 09 Jan 2023 01:32:21 +0000 flight 175628 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/175628/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine 8 reboot fail REGR. vs. 173462 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux 93928d485d9df12be724cbdf1caa7d197b65001e baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 93 days Failing since 173470 2022-10-08 06:21:34 Z 92 days 194 attempts Testing same since 175628 2023-01-08 17:13:25 Z 0 days 1 attempts ------------------------------------------------------------ 3313 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 505370 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Jan 09 01:41:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 01:41:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473299.733803 (Exim 4.92) (envelope-from ) id 1pEh9v-0001Uv-VH; Mon, 09 Jan 2023 01:41:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473299.733803; Mon, 09 Jan 2023 01:41:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEh9v-0001Uo-Rb; Mon, 09 Jan 2023 01:41:07 +0000 Received: by outflank-mailman (input) for mailman id 473299; Mon, 09 Jan 2023 01:41:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEh9u-0001Ui-Sw for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 01:41:07 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2087.outbound.protection.outlook.com [40.107.6.87]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ad9135d6-8fbe-11ed-91b6-6bf2151ebd3b; Mon, 09 Jan 2023 02:41:04 +0100 (CET) Received: from ZR0P278CA0157.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:41::22) by AS8PR08MB6341.eurprd08.prod.outlook.com (2603:10a6:20b:33f::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Mon, 9 Jan 2023 01:41:02 +0000 Received: from VI1EUR03FT055.eop-EUR03.prod.protection.outlook.com (2603:10a6:910:41:cafe::96) by ZR0P278CA0157.outlook.office365.com (2603:10a6:910:41::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Mon, 9 Jan 2023 01:41:02 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT055.mail.protection.outlook.com (100.127.144.130) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Mon, 9 Jan 2023 01:41:01 +0000 Received: ("Tessian outbound 0d7b2ab0f13d:v132"); Mon, 09 Jan 2023 01:41:00 +0000 Received: from 4d1961368fd6.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B9CB8763-F1E7-4A7F-BF3A-D8121F8A50BE.1; Mon, 09 Jan 2023 01:40:55 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4d1961368fd6.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 09 Jan 2023 01:40:55 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by PAWPR08MB10317.eurprd08.prod.outlook.com (2603:10a6:102:330::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Mon, 9 Jan 2023 01:40:47 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::d1d7:166d:6c34:d19e]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::d1d7:166d:6c34:d19e%5]) with mapi id 15.20.5986.018; Mon, 9 Jan 2023 01:40:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ad9135d6-8fbe-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gElYYVRIq6cb2IFc9bv0ot+K3mKiPjAQBlshZI0YrbY=; b=LwuMYO/RoNMUY/KYHCgKDTiIZ91Zlp/Uwbt/kCvOsGBoX+JPZTDJ3NjEZA/gqklO4hRCwCNx+vGmjGgOib7rup4sfg2GLijvaiyL3P2epMUkpu372v10YtJF7Ok2vCKhcTU8u3HDeHgjVoi9fQu6AkhsRjmraaJC7dW96c6TDIA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QPXIH5vrmiTndYmYAmug2xAUgVrAiqb7U35Di6qvwYiXKv0NnGP5JVicdJF/6XzVAMpuw34IFsI2W3vrOO/f90WMFeK8AqG8TUjsI0U8SuBJjUKKnWG4IAfqBgN8/opqLRRbtsKhOQPVywEh8tJSx29wH4T+CZ8hms1DOW/qafo3c84K/W434oYTA7xZsWmh03YXhRc2pr0z/I/EG+sM2uejzHpI89uA8l4GaHPp9JDWEMQKmf7oE/D73z+HAX9YYZivmYhbQ3VE9ZNajx2J5aTomVzMYvfZ+bo8K+XR2PMdrgUlxt5gdlx8EXB7Nk4XpMqLhCmlzABb2ZqXyxs6fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gElYYVRIq6cb2IFc9bv0ot+K3mKiPjAQBlshZI0YrbY=; b=gB+iPuV4z5yYYKmC64JICGQWV84A0ZKg9SBO5Gyqyazl+O4CJO6PJ7hp197aYVc7LfpZdZBo4tHOfOwDU2WcJX6EfojYn3dLdXOwUovsH/rE+pouemC/rUFaKYGTXhYdQpdDuMK6SXulmixl3d5uan5w7R9fbDQ/Ar3fXeDTnU2oIITCURD3K3Mj2F4BwZT1pmqUpz2kRNQ9wkMr6UPsV77jhs4GjfrD+1pZomhAZFONIaIQ2HktFgvPROQvpk0TT/QfyNc7EJFuBFFpDzYL0nXgCfrzsrQj1wa8PJ3XLgqo/Jg1y9uclVZaBohs9OATdordh06psSPW/eJQWT9fIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gElYYVRIq6cb2IFc9bv0ot+K3mKiPjAQBlshZI0YrbY=; b=LwuMYO/RoNMUY/KYHCgKDTiIZ91Zlp/Uwbt/kCvOsGBoX+JPZTDJ3NjEZA/gqklO4hRCwCNx+vGmjGgOib7rup4sfg2GLijvaiyL3P2epMUkpu372v10YtJF7Ok2vCKhcTU8u3HDeHgjVoi9fQu6AkhsRjmraaJC7dW96c6TDIA= From: Henry Wang To: Julien Grall , Bertrand Marquis , Stefano Stabellini CC: Wei Chen , Volodymyr Babchuk , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in arch_domain_create() Thread-Topic: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in arch_domain_create() Thread-Index: AQHY36RSrOIThkYtnEq9RrtWc+uYX64NsO2AgAACdYCAAZeJAIBUVNkAgAKflACAADe5AIAmqQQAgAgZZwCAAJ2dcA== Date: Mon, 9 Jan 2023 01:40:45 +0000 Message-ID: References: <20221014080917.14980-1-Henry.Wang@arm.com> <9d5ab09e-650f-118d-0233-d7988f1504f1@xen.org> <611b0857-155a-a50b-5996-ce735ebce22d@xen.org> In-Reply-To: <611b0857-155a-a50b-5996-ce735ebce22d@xen.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: A7E01A4412B29B418CE6B5E56B7E40E9.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|PAWPR08MB10317:EE_|VI1EUR03FT055:EE_|AS8PR08MB6341:EE_ X-MS-Office365-Filtering-Correlation-Id: 4b29914d-64ac-4c81-14b2-08daf1e2906b x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: s6EMuGyWFEz2wj2+xlPeCYuJu1E4/6ahNhwLCMkxIzpjMdLjKvKYHbSI8JICMU3Mp9axUZSJd1pzYWwusWHxWGr3wtxTpU6Rk2bgEqkgnJy8xp9dGGKU6XkoYv3YFole3OH0iRVEjyxHtf7smxb0ztwmmnynqEqZzWiuH2c/8NS52WFoUHMF9y6o0UyYYS0WUcDKo+TwxALBHLkmIl1jwIcyz3xtDn8K1TK46f1j39nr5SWnuN+4XJ3RNK9NiQT2Pm77n1XStzwDKZV+yrb988hgM12UqnPWmUx+8c95j+oUoQc4KOom4duF1242P3KIDkltGzmXnIMbci+ui449U9OhlfrQVEhmUAwh5z9iWdK7TRSVbsIq9TjezGXEtdQEk6Pw2I4nBIsfNWzol7JOw5o/kTwZ7hAUZseU0Tz3S17lCI5NWzfnAaF5qpO1KqytOu+0XBmyd+5MUWqIynzIcTkdTJuoNvDrv6sPFjJ/N3IxEL6it/BIpz6Z5IOHlWeaLEcDdpKzwmpB7ncqRDUghwq9A5cSa7KwfGdsElCr7+wIDWUjyMm9cxJh/DYd/flqO1hsmeJX20zPHLkQVjFnpkaOhd4XuHLkL+5VrW9f+Kfo9IIjp/m2K0eXmjZMLb2qw1K9iMgi4EWx+pgh7MI9zTVMb+DiBvHaEANVTYbA8InnIbNNanKTpDIMRUXD2Kl3iRH2uE70Hu5F+fA6FLcC/g== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(366004)(346002)(39860400002)(376002)(451199015)(38100700002)(122000001)(38070700005)(33656002)(66476007)(66556008)(66946007)(66446008)(8676002)(64756008)(4326008)(54906003)(76116006)(41300700001)(86362001)(110136005)(316002)(55016003)(5660300002)(2906002)(52536014)(8936002)(9686003)(83380400001)(478600001)(71200400001)(7696005)(6506007)(26005)(186003)(53546011)(66899015);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB10317 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 5c511e29-7120-4f37-506c-08daf1e28704 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eKwde+RqZGq4jXxZXBk0bx9Qmb/KPdIp/+LiGJkNLkvyp/6v6FW7nnk3SZod0M1mJ/EnMcwka5IXXCQ/WdtTJIp5Y24reeFE2Bzl5cj98jTe8dgkqJRe8p4kqb8Bc6z6YrWQpmH1VZv5M9GuB0PMwQ3Qk2zek/ZGypM5JgRZLN3agqBhr20L7w6lzC54Tbvtyjt0tHA8krLwOigwqnthswcbMvwEYmfniv2IOEhxNXwQvpTkPynS1n5/sArVyoEaZgeQWOkQk3yaDZo1yhEKQwMu+SJj/b20pR+uV81D2bObVeUMRxmWYXPYwgpY1IPw3hZ9tm7DO2SlJCW/glIxBLWeUDxzYtxVsGbiuj1UM3SHa6TRnchRp7rQsQJEFZuPsCLNhuMl2an7DO0lPbiOYaLb0iegOmk0BLJY44pBbkCSMtWmrYAkTw0MEo9czmzfqQdmFIPWMpMS0I5ls7flTX7MqJIo0gHq67g89upPo64C3AER4JFbp+2R46EcaZJpUO8a67ejuO46vLtPMsgR+eg18vBATMyrtznknhKzGOuqY9MZ528RncycYKWcQ2t85SvJN7wytawiSoGIDYEFtnfxGjIQ/P/+ll5akq1ZvV9sr7QQImckPSCPcOihfhO5kSyichVTFU+fczdKR6rajB09kv1Mn1N503CPazR8YDI= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(346002)(396003)(376002)(451199015)(46966006)(36840700001)(5660300002)(66899015)(8936002)(52536014)(41300700001)(110136005)(54906003)(2906002)(83380400001)(8676002)(70206006)(70586007)(316002)(4326008)(33656002)(7696005)(26005)(9686003)(186003)(478600001)(53546011)(6506007)(336012)(86362001)(55016003)(40480700001)(47076005)(82740400003)(81166007)(82310400005)(356005)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2023 01:41:01.2780 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4b29914d-64ac-4c81-14b2-08daf1e2906b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6341 SGkgSnVsaWVuIGFuZCBCZXJ0cmFuZCwNCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0K PiBGcm9tOiBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4ub3JnPg0KPiBTdWJqZWN0OiBSZTogW1BB VENIIHYyXSB4ZW4vYXJtOiBwMm06IFBvcHVsYXRlIHBhZ2VzIGZvciBHSUN2MiBtYXBwaW5nIGlu DQo+IGFyY2hfZG9tYWluX2NyZWF0ZSgpDQo+IA0KPiBIaSBCZXJ0cmFuZCwNCj4gDQo+IE9uIDAz LzAxLzIwMjMgMTI6MzQsIEJlcnRyYW5kIE1hcnF1aXMgd3JvdGU6DQo+ID4gSGksDQo+ID4NCj4g PiBTb3JyeSBmb3IgdGhlIGRlbGF5IGJ1dCBJIGhhdmUgdmVyeSBsaW1pdGVkIGFjY2VzcyB0byBt eSBtYWlscyByaWdodCBub3cuDQo+ID4NCj4gPj4gT24gOSBEZWMgMjAyMiwgYXQgMjM6MTEsIFN0 ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZw0KPiA+PiA8bWFpbHRvOnNz dGFiZWxsaW5pQGtlcm5lbC5vcmc+PiB3cm90ZToNCj4gPj4NCj4gPj4gT24gRnJpLCA5IERlYyAy MDIyLCBKdWxpZW4gR3JhbGwgd3JvdGU6DQo+ID4+PiBIaSBIZW5yeSwNCj4gPj4+DQo+ID4+PiBP biAwOC8xMi8yMDIyIDAzOjA2LCBIZW5yeSBXYW5nIHdyb3RlOg0KPiA+Pj4+IEkgYW0gdHJ5aW5n IHRvIHdvcmsgb24gdGhlIGZvbGxvdy11cCBpbXByb3ZlbWVudHMgYWJvdXQgdGhlIEFybSBQMk0N Cj4gPj4+PiBjb2RlLA0KPiA+Pj4+IGFuZCB3aGlsZSB0cnlpbmcgdG8gYWRkcmVzcyB0aGUgY29t bWVudCBiZWxvdywgSSBub3RpY2VkIHRoZXJlIHdhcyBhbg0KPiA+Pj4+IHVuZmluaXNoZWQNCj4g Pj4+PiBkaXNjdXNzaW9uIGJldHdlZW4gbWUgYW5kIEp1bGllbiB3aGljaCBJIHdvdWxkIGxpa2Ug dG8gY29udGludWUgYW5kDQo+IGhlcmUNCj4gPj4+PiBvcGluaW9ucyBmcm9tIGFsbCBvZiB5b3Ug KGlmIHBvc3NpYmxlKS4NCj4gPj4+Pg0KPiA+Pj4+IEZvciB0aGUgYmFja2dyb3VuZCBvZiB0aGUg ZGlzY3Vzc2lvbiwgdGhpcyB3YXMgYWJvdXQgdGhlIGZhaWx1cmUgcGF0aCBvZg0KPiA+Pj4+IGFy Y2hfZG9tYWluX2NyZWF0ZSgpLCB3aGVyZSB3ZSBvbmx5IGNhbGwgcDJtX2ZpbmFsX3RlYXJkb3du KCkgd2hpY2gNCj4gZG9lcw0KPiA+Pj4+IG5vdCBjYWxsIHJlbGlucXVpc2hfcDJtX21hcHBpbmco KS4uLg0KPiA+Pj4gU28gYWxsIHRoaXMgbWVzcyB3aXRoIHRoZSBQMk0gaXMgbmVjZXNzYXJ5IGJl Y2F1c2Ugd2UgYXJlIG1hcHBpbmcgdGhlDQo+ID4+PiBHSUN2Mg0KPiA+Pj4gQ1BVIGludGVyZmFj ZSBpbiBhcmNoX2RvbWFpbl9jcmVhdGUoKS4gSSB0aGluayB3ZSBzaG91bGQgY29uc2lkZXIgdG8N Cj4gPj4+IGRlZmVyIHRoZQ0KPiA+Pj4gbWFwcGluZyB0byBsYXRlci4NCj4gPj4+DQo+ID4+PiBP dGhlciB0aGFuIGl0IG1ha2VzIHRoZSBjb2RlIHNpbXBsZXIsIGl0IGFsc28gbWVhbnMgd2UgY291 bGQgYWxzbyB0aGUNCj4gPj4+IFAyTSByb290DQo+ID4+PiBvbiB0aGUgc2FtZSBudW1hIG5vZGUg dGhlIGRvbWFpbiBpcyBnb2luZyB0byBydW4gKHRob3NlIGluZm9ybWF0aW9uDQo+ID4+PiBhcmUg cGFzc2VkDQo+ID4+PiBsYXRlciBvbikuDQo+ID4+Pg0KPiA+Pj4gVGhlcmUgaXMgYSBjb3VwbGUg b2Ygb3B0aW9uczoNCj4gPj4+IDEuIEludHJvZHVjZSBhIG5ldyBoeXBlcmNhbGwgdG8gZmluaXNo IHRoZSBpbml0aWFsaXphdGlvbiBvZiBhIGRvbWFpbg0KPiA+Pj4gKGUuZy4NCj4gPj4+IGFsbG9j YXRpbmcgdGhlIFAyTSBhbmQgbWFwIHRoZSBHSUN2MiBDUFUgaW50ZXJmYWNlKS4gVGhpcyBvcHRp b24gd2FzDQo+ID4+PiBicmllZmx5DQo+ID4+PiBkaXNjdXNzZWQgd2l0aCBKYW4gKHNlZSBbMl0p Li8NCj4gPj4+IDIuIEFsbG9jYXRlIHRoZSBQMk0gd2hlbiBwb3B1bGF0ZSB0aGUgUDJNIHBvb2wg YW5kIGRlZmVyIHRoZSBHSUN2Mg0KPiBDUFUNCj4gPj4+IGludGVyZmFjZSBtYXBwaW5nIHVudGls IHRoZSBmaXJzdCBhY2Nlc3MgKHNpbWlsYXIgdG8gaG93IHdpdGggZGVhbA0KPiA+Pj4gd2l0aCBN TUlPDQo+ID4+PiBhY2Nlc3MgZm9yIEFDUEkpLg0KPiA+Pj4NCj4gPj4+IEkgZmluZCB0aGUgc2Vj b25kIG9wdGlvbiBpcyBuZWF0ZXIgYnV0IGl0IGhhcyB0aGUgZHJhd2JhY2sgdGhhdCBpdA0KPiA+ Pj4gcmVxdWlyZXMgb24NCj4gPj4+IG1vcmUgdHJhcCB0byB0aGUgaHlwZXJ2aXNvciBhbmQgd2Ug Y2FuJ3QgcmVwb3J0IGFueSBtYXBwaW5nIGZhaWx1cmUNCj4gPj4+ICh3aGljaA0KPiA+Pj4gc2hv dWxkIG5vdCBoYXBwZW4gaWYgdGhlIFAyTSB3YXMgY29ycmVjdGx5IHNpemVkKS4gU28gSSBhbSBs ZWFuaW5nDQo+ID4+PiB0b3dhcmRzDQo+ID4+PiBvcHRpb24gMi4NCj4gPj4+DQo+ID4+PiBBbnkg b3BpbmlvbnM/DQo+ID4+DQo+ID4+IE9wdGlvbiAxIGlzIG5vdCBncmVhdCBkdWUgdG8gdGhlIGV4 dHJhIGh5cGVyY2FsbC4gQnV0IEkgd29ycnkgdGhhdA0KPiA+PiBvcHRpb24gMiBtaWdodCBtYWtl IHRoaW5ncyBoYXJkZXIgZm9yIHNhZmV0eSBiZWNhdXNlIHRoZQ0KPiA+PiBtYXBwaW5nL2luaXRp YWxpemF0aW9uIGJlY29tZXMgImR5bmFtaWMiLiBJIGRvbid0IGtub3cgaWYgdGhpcyBpcyBhDQo+ ID4+IHZhbGlkIGNvbmNlcm4uDQo+ID4+DQo+ID4+IEkgd291bGQgbG92ZSB0byBoZWFyIEJlcnRy YW5kJ3MgdGhvdWdodHMgYWJvdXQgaXQuIFB1dHRpbmcgaGltIGluIFRvOg0KPiA+DQo+ID4gSG93 IG9wdGlvbiAxIHdvdWxkIHdvcmsgZm9yIGRvbTBsZXNzID8NCj4gDQo+IFhlbiB3b3VsZCBjYWxs IHRoZSBmdW5jdGlvbiBkaXJlY3RseS4gRWZmZWN0aXZlbHksIHRoaXMgd291bGQgdGhlIHNhbWUN Cj4gYXMgYWxsIHRoZSBvdGhlciAiaHlwZXJjYWxscyIgd2UgYXJlIHVzaW5nIHRvIGJ1aWxkIGEg ZG9tMGxlc3MgZG9tYWluLg0KPiANCj4gPg0KPiA+IE9wdGlvbiAyIHdvdWxkIG1ha2Ugc2FmZXR5 IG1vcmUgY2hhbGxlbmdpbmcgYnV0IG5vdCBpbXBvc3NpYmxlICh3ZSBoYXZlDQo+ID4gYSBsb3Qg b2Ygb3RoZXIgdXNlIGNhc2VzIHdoZXJlIHdlIGNhbm5vdCBtYXAgZXZlcnl0aGluZyBvbiBib290 KS4NCj4gPg0KPiA+IEkgd291bGQgdm90ZSBmb3Igb3B0aW9uIDIgYXMgSSB0aGluayB3ZSB3aWxs IG5vdCBjZXJ0aWZ5IGdpY3YyIGFuZCBpdCBpcw0KPiA+IG5vdCBhZGRpbmcgYW4gb3RoZXIgaHlw ZXIgY2FsbC4NCg0KVGhhbmtzIGZvciB0aGUgaW5wdXQuDQoNCj4gDQo+IEl0IHNvdW5kcyBsaWtl IG9wdGlvbiAyIGlzIHRoZSBwcmVmZXJyZWQgd2F5IGZvciBub3cuIEhlbnJ5LCBjYW4geW91DQo+ IGhhdmUgYSBsb29rPw0KDQpZZXMsIEkgd291bGQgbG92ZSB0byBwcmVwYXJlIHNvbWUgcGF0Y2hl cyB0byBmb2xsb3cgdGhlIG9wdGlvbiAyLg0KDQpLaW5kIHJlZ2FyZHMsDQpIZW5yeQ0KDQo+IA0K PiBDaGVlcnMsDQo+IA0KPiAtLQ0KPiBKdWxpZW4gR3JhbGwNCg== From xen-devel-bounces@lists.xenproject.org Mon Jan 09 03:11:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 03:11:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473310.733820 (Exim 4.92) (envelope-from ) id 1pEiYy-0002yT-Ix; Mon, 09 Jan 2023 03:11:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473310.733820; Mon, 09 Jan 2023 03:11:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEiYy-0002yM-Fs; Mon, 09 Jan 2023 03:11:04 +0000 Received: by outflank-mailman (input) for mailman id 473310; Mon, 09 Jan 2023 03:11:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEiYx-0002xu-Ad; Mon, 09 Jan 2023 03:11:03 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEiYx-0004vz-8g; Mon, 09 Jan 2023 03:11:03 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEiYw-0000Bo-SI; Mon, 09 Jan 2023 03:11:02 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pEiYw-00049b-Rq; Mon, 09 Jan 2023 03:11:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=2lHWD1fdzlJWE47m3fAVModD9B7f9OG9gdk4i0XACvE=; b=oFTPYXZEH/gCp+V29T0r6qB5dX teHZzT8gWBjz2fTgzT2K8eEagKbra5wKpHjeDhhuz5ektlospRr2EDNLlRraihY+bTNGuMSLz56+B AqNW8k/twhMhjPDm9LVwrN3BiQpGCy1FKFNnSL80ZrEpXDacZsKjrLU8wqtgNwiD5DTo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 175629: regressions - trouble: broken/fail/pass X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-credit2::broken:regression qemu-mainline:build-arm64-xsm:xen-build:fail:regression qemu-mainline:test-amd64-amd64-xl-credit2:host-install(5):broken:heisenbug qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug qemu-mainline:test-arm64-arm64-xl:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:heisenbug qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=528d9f33cad5245c1099d77084c78bb2244d5143 X-Osstest-Versions-That: qemuu=0ab12aa32462817f0a53fa6f6ce4baf664ef1713 From: osstest service owner Date: Mon, 09 Jan 2023 03:11:02 +0000 flight 175629 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/175629/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-credit2 broken build-arm64-xsm 6 xen-build fail in 175627 REGR. vs. 175623 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-credit2 5 host-install(5) broken pass in 175627 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail in 175627 pass in 175629 test-arm64-arm64-xl 18 guest-start/debian.repeat fail in 175627 pass in 175629 test-amd64-amd64-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail in 175627 pass in 175629 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked in 175627 n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked in 175627 n/a test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 175623 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 175623 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175623 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175623 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 175623 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 175623 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175623 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175623 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu 528d9f33cad5245c1099d77084c78bb2244d5143 baseline version: qemuu 0ab12aa32462817f0a53fa6f6ce4baf664ef1713 Last test of basis 175623 2023-01-07 23:09:00 Z 1 days Testing same since 175627 2023-01-08 14:40:14 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Peter Maydell Richard Henderson jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 broken test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-xl-credit2 broken broken-step test-amd64-amd64-xl-credit2 host-install(5) Not pushing. (No revision log; it would be 378 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Jan 09 06:35:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 06:35:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473322.733839 (Exim 4.92) (envelope-from ) id 1pElkq-0005wH-6D; Mon, 09 Jan 2023 06:35:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473322.733839; Mon, 09 Jan 2023 06:35:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pElkq-0005wA-3g; Mon, 09 Jan 2023 06:35:32 +0000 Received: by outflank-mailman (input) for mailman id 473322; Mon, 09 Jan 2023 06:35:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pElkp-0005w4-1K for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 06:35:31 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ceac5909-8fe7-11ed-91b6-6bf2151ebd3b; Mon, 09 Jan 2023 07:35:29 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 44CC329395; Mon, 9 Jan 2023 06:35:28 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E4B0F134AD; Mon, 9 Jan 2023 06:35:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id hsJENq+1u2OUIwAAMHmgww (envelope-from ); Mon, 09 Jan 2023 06:35:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ceac5909-8fe7-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1673246128; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3cpNAoTzx4mYIaRdBrMGabQXSJ35A+xG9+z4dCYHRHs=; b=s9ErdALrW00XQok62mNw/8rTGW2CPZT5VanCuBOfU2t9SX+O6twaig4ldnBCmbu7svcodi US61xk/DSj01wra/MEW1iw7TNmjm7kUe+tYDIsj+Ppv8hn8+JgPTXbe2lnwv3FGuGpiN8B XZXqWn9q/4KE7jDM+I11RfMfvjnbh9Y= Message-ID: Date: Mon, 9 Jan 2023 07:34:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2] x86/xen: Remove the unused function p2m_index() To: Jiapeng Chong Cc: boris.ostrovsky@oracle.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, Abaci Robot References: <20230105090141.36248-1-jiapeng.chong@linux.alibaba.com> Content-Language: en-US From: Juergen Gross In-Reply-To: <20230105090141.36248-1-jiapeng.chong@linux.alibaba.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------EewI0ZGsy7qxZ2dMrnpmluuY" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------EewI0ZGsy7qxZ2dMrnpmluuY Content-Type: multipart/mixed; boundary="------------K0aOUOdipexF2AKtyJOa40IA"; protected-headers="v1" From: Juergen Gross To: Jiapeng Chong Cc: boris.ostrovsky@oracle.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, Abaci Robot Message-ID: Subject: Re: [PATCH v2] x86/xen: Remove the unused function p2m_index() References: <20230105090141.36248-1-jiapeng.chong@linux.alibaba.com> In-Reply-To: <20230105090141.36248-1-jiapeng.chong@linux.alibaba.com> --------------K0aOUOdipexF2AKtyJOa40IA Content-Type: multipart/mixed; boundary="------------GKoe8SjNPT20lOoePu2aELwU" --------------GKoe8SjNPT20lOoePu2aELwU Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDUuMDEuMjMgMTA6MDEsIEppYXBlbmcgQ2hvbmcgd3JvdGU6DQo+IFRoZSBmdW5jdGlv biBwMm1faW5kZXggaXMgZGVmaW5lZCBpbiB0aGUgcDJtLmMgZmlsZSwgYnV0IG5vdCBjYWxs ZWQNCj4gZWxzZXdoZXJlLCBzbyByZW1vdmUgdGhpcyB1bnVzZWQgZnVuY3Rpb24uDQo+IA0K PiBhcmNoL3g4Ni94ZW4vcDJtLmM6MTM3OjI0OiB3YXJuaW5nOiB1bnVzZWQgZnVuY3Rpb24g J3AybV9pbmRleCcuDQo+IA0KPiBMaW5rOiBodHRwczovL2J1Z3ppbGxhLm9wZW5hbm9saXMu Y24vc2hvd19idWcuY2dpP2lkPTM1NTcNCj4gUmVwb3J0ZWQtYnk6IEFiYWNpIFJvYm90IDxh YmFjaUBsaW51eC5hbGliYWJhLmNvbT4NCj4gU2lnbmVkLW9mZi1ieTogSmlhcGVuZyBDaG9u ZyA8amlhcGVuZy5jaG9uZ0BsaW51eC5hbGliYWJhLmNvbT4NCg0KUmV2aWV3ZWQtYnk6IEp1 ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4NCg0KDQpKdWVyZ2VuDQoNCg== --------------GKoe8SjNPT20lOoePu2aELwU Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------GKoe8SjNPT20lOoePu2aELwU-- --------------K0aOUOdipexF2AKtyJOa40IA-- --------------EewI0ZGsy7qxZ2dMrnpmluuY Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmO7tXcFAwAAAAAACgkQsN6d1ii/Ey+N sgf/XR9GrAGEdbpZ0hQ7Pwqb9n7fjbuBP/LRDat2KloqfIVY/g6wXVpazTu/pP9QBbKfsKbmwGZT JldRX6f91xy+xKl2Rh/9fOIHKL19uvNmKJMNmMTIXcVGDH8lLffBNngyqVDMGNCGjV9CI4AtoIfq rD/FcfL+EiSsjITwBoqdH1oIaYolfrlGccPZ7v1+c5vSN6UzflBVmGU8buZrSdslq0tMHBtwPuAQ XetoH09lULfGo83mmNTZ6/O+gXOt3hzKFxkLIdcRRUMPCFtibqQSe2TadpuPCS0gw/oOwcFGUO0z y0618kgsKF+yPhL7B2wPVAe/MydQ3LsUex1kdax1JA== =qHuF -----END PGP SIGNATURE----- --------------EewI0ZGsy7qxZ2dMrnpmluuY-- From xen-devel-bounces@lists.xenproject.org Mon Jan 09 07:40:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 07:40:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473329.733854 (Exim 4.92) (envelope-from ) id 1pEmlP-0004Tu-Ud; Mon, 09 Jan 2023 07:40:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473329.733854; Mon, 09 Jan 2023 07:40:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEmlP-0004Tn-QR; Mon, 09 Jan 2023 07:40:11 +0000 Received: by outflank-mailman (input) for mailman id 473329; Mon, 09 Jan 2023 07:40:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEmlN-0004Th-Ra for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 07:40:09 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d6e8425d-8ff0-11ed-91b6-6bf2151ebd3b; Mon, 09 Jan 2023 08:40:08 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 7DB577688E; Mon, 9 Jan 2023 07:40:07 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5EC5A13583; Mon, 9 Jan 2023 07:40:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id JyK7FdfEu2MpPgAAMHmgww (envelope-from ); Mon, 09 Jan 2023 07:40:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d6e8425d-8ff0-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1673250007; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NSvDl3n0oqx37p6IpNF7M63u6VQ9OMHV69YCbkVaQ4M=; b=Z++I4M9J3r2vZzgao5n8Nv5kJxoqLIJLdYgGV/bbOfXdlK1uJnghIz+PEFc1/qLq4K9IA3 cLWDqq+UM2ByZ1RBkz8E65UnqJIvBlok+ig/XEy24JWABm6xEi8MvcZdL5KZ75iuVsEr/r xIsbvOGQCd2PkfnX/DUS65wMc2BQrcQ= Message-ID: Date: Mon, 9 Jan 2023 08:40:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Content-Language: en-US To: David Woodhouse , xen-devel@lists.xenproject.org Cc: Julien Grall References: <22a2352464be2df92dc0d30a955034c59fdf3927.camel@infradead.org> From: Juergen Gross Subject: Re: (Ab)using xenstored without Xen In-Reply-To: <22a2352464be2df92dc0d30a955034c59fdf3927.camel@infradead.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------ZWAth3w0qNbwl4AZad2QP00l" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------ZWAth3w0qNbwl4AZad2QP00l Content-Type: multipart/mixed; boundary="------------KL09YnqV00A0Z8RF2HctPEEv"; protected-headers="v1" From: Juergen Gross To: David Woodhouse , xen-devel@lists.xenproject.org Cc: Julien Grall Message-ID: Subject: Re: (Ab)using xenstored without Xen References: <22a2352464be2df92dc0d30a955034c59fdf3927.camel@infradead.org> In-Reply-To: <22a2352464be2df92dc0d30a955034c59fdf3927.camel@infradead.org> --------------KL09YnqV00A0Z8RF2HctPEEv Content-Type: multipart/mixed; boundary="------------bKnsV4VNMmfJvVAL63oPCe6j" --------------bKnsV4VNMmfJvVAL63oPCe6j Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 U29ycnkgZm9yIHRoZSBsYXRlIGFuc3dlciwgYnV0IEkgd2FzIHByZXR0eSBidXN5IGJlZm9y ZSBteSAzIHdlZWsgdGltZSBvZmYuIDotKQ0KDQpPbiAyMC4xMi4yMiAxMzowMiwgRGF2aWQg V29vZGhvdXNlIHdyb3RlOg0KPiBJJ3ZlIGJlZW4gd29ya2luZyBvbiBnZXR0aW5nIHFlbXUg dG8gc3VwcG9ydCBYZW4gSFZNIGd1ZXN0cyAnbmF0aXZlbHknDQo+IHVuZGVyIEtWTToNCj4g aHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvcWVtdS1kZXZlbC8yMDIyMTIxNjAwNDExNy44NjIx MDYtMS1kd213MkBpbmZyYWRlYWQub3JnL1QvDQo+IA0KPiBUaGUgYmFzaWMgcGxhdGZvcm0g aXMgbW9zdGx5IHdvcmtpbmcgYW5kIEkgY2FuIHN0YXJ0IFhURiB0ZXN0cyB3aXRoDQo+ICdx ZW11IC1rZXJuZWwnLiBOb3cgaXQgcmVhbGx5IG5lZWRzIGEgeGVuc3RvcmUuDQo+IA0KPiBJ J20gdGhpbmtpbmcgb2YgaW1wbGVtZW50aW5nIHRoZSBiYXNpYyBzaGFyZWQgcmluZyBzdXBw b3J0IG9uIHRoZSBxZW11DQo+IHNpZGUsIHRoZW4gY29tbXVuaWNhdGluZyB3aXRoIHRoZSBy ZWFsIHhlbnN0b3JlZCBvdmVyIGl0cyBzb2NrZXQNCj4gaW50ZXJmYWNlLiBJdCB3b3VsZCBu ZWVkIGEgJ1NVJyBjb21tYW5kIGluIHRoZSB4ZW5zdG9yZWQgcHJvdG9jb2wgdG8NCj4gbWFr ZSBpdCB0cmVhdCB0aGF0IGNvbm5lY3Rpb24gYXMgYW4gdW5wcml2aWxlZ2VkIGNvbm5lY3Rp b24gZnJvbSBhDQo+IHNwZWNpZmljIGRvbWlkLCBhbmFsb2dvdXMgdG8gJ0lOVFJPRFVDRScg YnV0IG92ZXIgdGhlIGV4aXN0aW5nDQo+IGNvbm5lY3Rpb24uDQoNCldvdWxkbid0IGFuICJ1 bnByaXZpbGVnZWQiIHNvY2tldCBtYWtlIG1vcmUgc2Vuc2U/DQoNCj4gSG93ZXZlciwgdGhl cmUgbWlnaHQgYmUgYSBiaXQgb2Ygd29yayB0byBkbyBmaXJzdC4gQXQgZmlyc3QsIGl0IHNl ZW1lZA0KPiBsaWtlIHhlbnN0b3JlZCBkaWQgc3RhcnQgdXAgT0sgYW5kIHFlbXUgY291bGQg ZXZlbiBjb25uZWN0IHRvIGl0IHdoZW4NCj4gbm90IHJ1bm5pbmcgdW5kZXIgWGVuLiBCdXQg dGhhdCB3YXMgYSBjaGVja291dCBmcm9tIGEgZmV3IG1vbnRocyBhZ28sDQo+IGFuZCBldmVu IHRoZW4gaXQgd291bGQgc2VnZmF1bHQgdGhlIGZpcnN0IHRpbWUgd2UgdHJ5IHRvIGFjdHVh bGx5DQo+ICp3cml0ZSogYW55IG5vZGVzLg0KPiANCj4gTmV3ZXIgeGVuc3RvcmVkIGJyZWFr cyBldmVuIHNvb25lciBiZWNhdXNlIHNpbmNlIGNvbW1pdCA2MGUyZjYwMjANCj4gKCJ0b29s cy94ZW5zdG9yZTogbW92ZSB0aGUgY2FsbCBvZiBzZXR1cF9zdHJ1Y3R1cmUoKSB0byBkb20w DQo+IGludHJvZHVjdGlvbiIpIGl0IGRvZXNuJ3QgZXZlbiBoYXZlIGEgdGRiX2N0eCBpZiB5 b3Ugc3RhcnQgaXQgd2l0aCB0aGUNCj4gLUQgb3B0aW9uLCBzbyBpdCBzZWdmYXVsdHMgZXZl biBvbiBydW5uaW5nIHhlbnN0b3JlLWxzLiBBbmQgaWYgSSBtb3ZlDQo+IHRoZSB0ZGIgcGFy dCBvZiBzZXR1cF9zdHJ1Y3R1cmUoKSBiYWNrIHRvIGJlIGNhbGxlZCBmcm9tIHdoZXJlIGl0 IHdhcywNCj4gd2UgZ2V0IGEgbGF0ZXIgY3Jhc2ggaW4gZ2V0X2RvbWFpbl9pbmZvKCkgYmVj YXVzZSB0aGUgeGNfaGFuZGxlIGlzDQo+IE5VTEwuDQo+IA0KPiBXaGljaCBpcyBraW5kIG9m IGZhaXIgZW5vdWdoLCBiZWNhdXNlIHhlbnN0b3JlZCBpcyBkZXNpZ25lZCB0byBydW4NCj4g dW5kZXIgWGVuIDopDQo+IA0KPiBCdXQgd2hhdCAqaXMqIHRoZSAtRCBvcHRpb24gZm9yPyBJ dCBnb2VzIGJhY2sgdG8gY29tbWl0IGJkZGQ0MTM2NiBpbg0KPiAyMDA1IHdoY2ggdGFsa3Mg YWJvdXQgYWxsb3dpbmcgbXVsdGlwbGUgY29uY3VycmVudCB0cmFuc2FjdGlvbnMsIGFuZA0K PiBkb2Vzbid0IG1lbnRpb24gdGhlIG5ldyBvcHRpb24gYXQgYWxsLiBJdCBzZWVtcyB0byBi ZSBmYWlybHkgaG9zZWQgYXQNCj4gdGhlIG1vbWVudC4NCg0KSSBndWVzcyB0aGlzIHdhcyBz b21lIGRlYnVnZ2luZyBhZGQtb24gd2hpY2ggaGFzbid0IGJlZW4gdXNlZCBmb3IgYWdlcy4N Cg0KSSdtIGluY2xpbmVkIHRvIGp1c3QgcmVtb3ZlIHRoZSAtRCBvcHRpb24uDQoNCj4gSXMg aXQgcmVhc29uYWJsZSB0byBhdHRlbXB0ICJmaXhpbmciIHhlbnN0b3JlZCB0byBydW4gd2l0 aG91dCBhY3R1YWwNCj4gWGVuLCBzbyB0aGF0IHdlIGNhbiB1c2UgaXQgZm9yIHZpcnR1YWwg WGVuIHN1cHBvcnQ/DQoNCkkgZG9uJ3Qgc2VlIGEgbWFqb3IgcHJvYmxlbSB3aXRoIHRoYXQu DQoNClRoZSByZXN1bHQgc2hvdWxkbid0IGJlIHRvbyB1Z2x5LCBvZiBjb3Vyc2UsIGFuZCBJ IGRvbid0IHNlZSBhbnkgZWZmb3J0DQpvbiBYZW4gc2lkZSB0byB0ZXN0IGFueSBjaGFuZ2Vz IGZvciBub3QgYnJlYWtpbmcgeW91ciB1c2UgY2FzZS4NCg0KDQpKdWVyZ2VuDQo= --------------bKnsV4VNMmfJvVAL63oPCe6j Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------bKnsV4VNMmfJvVAL63oPCe6j-- --------------KL09YnqV00A0Z8RF2HctPEEv-- --------------ZWAth3w0qNbwl4AZad2QP00l Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmO7xNYFAwAAAAAACgkQsN6d1ii/Ey/p fwf+IuKOn8kcvHYU4CBvgV/Qmri9ctxjGGmSCBQgMrmnHVuCs6WVZXdmpwWIgNXTuPYgPSiBUtJJ iLlo2ViuniKGYVeBBRbBX0C+S1p91RSDYPIQ3k/t7WH1pdpd2TK4wYb794KqLoqE8D9LJ7RHdwwg RwVOQbAIHYYlbfEJg/v1ljMOY8UmeUgZr/8q0ucQf3RWs2GvTHVYjKIKAf0SWe9Bl4LDTi4783Vn fyYAl1RignJYuKIf3pgKYeC8nreJMsY9n4uI9tiOMOuBlGL36vIuHEbzIGwiFjslnq4tnv6X+Sey fYwzIPCGME0i+GX+uqI2Ou9RiRkldzjsXttmYZvA7Q== =SOOS -----END PGP SIGNATURE----- --------------ZWAth3w0qNbwl4AZad2QP00l-- From xen-devel-bounces@lists.xenproject.org Mon Jan 09 07:49:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 07:49:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473335.733864 (Exim 4.92) (envelope-from ) id 1pEmuI-0005AG-O1; Mon, 09 Jan 2023 07:49:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473335.733864; Mon, 09 Jan 2023 07:49:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEmuI-0005A9-LP; Mon, 09 Jan 2023 07:49:22 +0000 Received: by outflank-mailman (input) for mailman id 473335; Mon, 09 Jan 2023 07:49:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEmuG-0005A0-89 for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 07:49:20 +0000 Received: from EUR03-VI1-obe.outbound.protection.outlook.com (mail-vi1eur03on2078.outbound.protection.outlook.com [40.107.103.78]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1d8e83a7-8ff2-11ed-b8d0-410ff93cb8f0; Mon, 09 Jan 2023 08:49:17 +0100 (CET) Received: from FR3P281CA0204.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a5::9) by PA4PR08MB6144.eurprd08.prod.outlook.com (2603:10a6:102:e3::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Mon, 9 Jan 2023 07:49:14 +0000 Received: from VI1EUR03FT016.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:a5:cafe::cc) by FR3P281CA0204.outlook.office365.com (2603:10a6:d10:a5::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.11 via Frontend Transport; Mon, 9 Jan 2023 07:49:14 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT016.mail.protection.outlook.com (100.127.144.158) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Mon, 9 Jan 2023 07:49:13 +0000 Received: ("Tessian outbound 8038f0863a52:v132"); Mon, 09 Jan 2023 07:49:12 +0000 Received: from 992d601173f9.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7360FF9E-90E4-47EF-A60E-D7F9330BDBDF.1; Mon, 09 Jan 2023 07:49:03 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 992d601173f9.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 09 Jan 2023 07:49:03 +0000 Received: from AM0PR08MB4530.eurprd08.prod.outlook.com (2603:10a6:208:13c::21) by AS8PR08MB8086.eurprd08.prod.outlook.com (2603:10a6:20b:54b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Mon, 9 Jan 2023 07:48:59 +0000 Received: from AM0PR08MB4530.eurprd08.prod.outlook.com ([fe80::ee26:4b5e:4334:b7ab]) by AM0PR08MB4530.eurprd08.prod.outlook.com ([fe80::ee26:4b5e:4334:b7ab%7]) with mapi id 15.20.5986.018; Mon, 9 Jan 2023 07:48:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1d8e83a7-8ff2-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AKAXuZ2ln55fEjAN4R5sFOXI/x6Y4sfBhXHBHo1uyiQ=; b=AAP78dGGludVtFDkbJmRU+EU6e6YOjd/rCBm22UCIU7GVRuT55Yg55n4qSc7LPvqCmfdl2MD9XfEy+DcTkE78KQqdiEQOAvykude1+13eANHJP4Vt07ysQWDdFpDFWUL5P48xecLdnwlJ+5IxZD5Hile3UFg/l2bTAUm8N5l2ZA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FIUxU/SsqmBKeN11QdSKzPD1xdXXbivyP38+sSER05jXzK+5kaacysVwgG5c7HaYvjd85tKGNGxTwDzLWkNoGMU2uKBq835/09PBXR1S2jokcy0gHr/9X0klKmBtSxY/loGTINWQMl2NZPfci/bK5VGt8zSj3IsuHKEbJAKRcWOnpUGseLYiTBcKHSKBXYW4zUFKflWo4EDWZFxnMqDJzHombPYEQ6IHgd8gt5oxm8USVo0EJKbCDn06w7LcdRDpn/fRXxk1ppnAEBGrBHqQFuGL+fNvkTb0dpCT0vpbwhIZWrQLPXDG2uvN1uQsuSpGE9U27r5nVWX6iT65f6I9zA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AKAXuZ2ln55fEjAN4R5sFOXI/x6Y4sfBhXHBHo1uyiQ=; b=KItY2d6wp3XmTl2tNndMyZcO3+pjdKwXp1+gRh4kwCbCzn8m/+IL6KwTyxXkfkSsitjdW+xrPSBHRKHUDPgvmp/pWP1Z4rC+0EZ5Lh7gqTJNV41xrP6g6EzrbxDdUGkaoAloCQOyIj2Z2l2+zEV1pQaZpUY9ZHEB+wqwG2YUK+J9KufIbwb1jeTYb+7WDW/uMoUOX0+6RsOCE1Xnz7RBoHCCXrYU/U6OlAWJwWYFxX1960meyyDA5Qv1Y6RpY25RELXcG0bt9h97R5J/dBKqp5Dogx0OqrVMDX+Bl5YvH8xrp5jU2JCLkK/zbplKZcjAASCJSTlEtoNuDdExdDVMZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AKAXuZ2ln55fEjAN4R5sFOXI/x6Y4sfBhXHBHo1uyiQ=; b=AAP78dGGludVtFDkbJmRU+EU6e6YOjd/rCBm22UCIU7GVRuT55Yg55n4qSc7LPvqCmfdl2MD9XfEy+DcTkE78KQqdiEQOAvykude1+13eANHJP4Vt07ysQWDdFpDFWUL5P48xecLdnwlJ+5IxZD5Hile3UFg/l2bTAUm8N5l2ZA= From: Penny Zheng To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Wei Chen , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH v1 01/13] xen/arm: re-arrange the static shared memory region Thread-Topic: [PATCH v1 01/13] xen/arm: re-arrange the static shared memory region Thread-Index: AQHY+J1fJT59o0hz5k65YJBzZn+QX66Uu+KAgAFK6sA= Date: Mon, 9 Jan 2023 07:48:59 +0000 Message-ID: References: <20221115025235.1378931-1-Penny.Zheng@arm.com> <20221115025235.1378931-2-Penny.Zheng@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 77C55A13AE0A2942AE889D654333364B.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM0PR08MB4530:EE_|AS8PR08MB8086:EE_|VI1EUR03FT016:EE_|PA4PR08MB6144:EE_ X-MS-Office365-Filtering-Correlation-Id: 802ccaa4-56dc-481e-a91f-08daf216002c x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: qR+k8egtqPC5/4MXYyif4xA2C0CBn4RzLOh8XsZLZ3nh4b4KMrZRW8p3ocvAe+sQ1cUw4TxEzYpcCIJlhBJzoHuLPAbst0GfVUSxNvNM/sFcNg9qVPQLEGTDfsDD77Bd0PlKW3BTRCQZfBFAgtacvQIzShJb49dbldZlBVH4GM+rKUfSRSstN+4u+FSx7WaHI2+LcwC227Fc/w3+cuiaDTrBEsTFMgYzSRTljZRk67VHZCrW+Acsl+9HBC/dxoHueWfq0FIoedrla6NtMmjQNqkJ1lP3yEV6aY6mTwzTa1avxbH4imdNPDbrXSXGnBf9je1oOz5uUFN0+cL2ZfmMY/igIdo326AXnV78OzlJfQtO1e7ydajYIkZbdVwKyBoIiZH0eF5mcdg82k4M6GebpZMxbnySruzA2NlHKx208VseurrqT4aJArRdQBQY64eUFDN+wPK01dUfN4gVIAAM+XpKfjDb9F0Ftj0vrze1+lnpKfSYUXMmofiTebHME/dInBtkXaJeiUCaRt60GWzJ9cC2FITujYo4qswUjwQ9JM6OY9Nz2pSgzH/lvsyK7D0ADMtbNVAm6PfXoG+TTZSKZx+WH9wE6HTBNN5rkQmuCbWHyyS7usw7q2RvEkGWlPgXbPz3EVjUTNFBVYKmRspjxp6GNmtvW0/atdT2EoYflw49Kifix/TLcelhIbei5Qof X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB4530.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(366004)(39860400002)(376002)(346002)(451199015)(86362001)(7696005)(478600001)(71200400001)(55016003)(316002)(54906003)(110136005)(38100700002)(122000001)(38070700005)(33656002)(186003)(26005)(53546011)(6506007)(9686003)(64756008)(41300700001)(76116006)(66946007)(66446008)(66476007)(66556008)(4326008)(5660300002)(8676002)(52536014)(2906002)(83380400001)(8936002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8086 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT016.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 24aaf046-90b7-479f-779c-08daf215f805 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +6AmQ5MuTUnkVHqRt2j/5BSsOLq6SAYZB3qcgHoa/lhAkJYpl5ul8uo38c/tvSWRfAnLRxc3dX3OEURfHrSvX+VKfKyUoPyC45UUuolEAW7wIV0VV5Bhkg/fzIyb+zto/vsV2bjLcxIr1fECtSlNmEkPFI9S7bzwk1ISvV1AQmbVeHXleAGq+xAzVZSeolY7c7hg6nIBb7o+TatBiQ4pqE7YzB4hFIa0svUgoLRZdILB6R+wX7B0bu4Q/VEWB/TK8H6MX1PykK1YKgLDc2o/uV6kzLvQgAf5wFQTr1yLTYvZazCt/f3DJ/P9o/2UnvUKjjzG6BZRO0BZhEWCXS0VYULe4TgyHmibPHibwwFu8z5E/WRkGrb/bBtMl0YzTI3Hh+BI/EXB8+CBCVPY/FXN+DR98M7bQd3v/9f+9W4jkIt4TwBmvMu558QndmBvjln5Lvxb9u3hnbjB1dNO8r60ecP6pK8R03lvSkk8/I7vQ7YVVgV5frNfFsH152lEUmsGVigmFfRJJ+3u1YFzVSSgZUEIqpmKKgOSEVrhGkP9yFVHj6zxPzZZADwKuY9bK2yurglTaFHr7hNdCJPK6FkwEkOL6iEEo9uj9RhmVm/LIb3U6t8tWoGCbhaWEUFxXX6XWCxavbjKJn1lg9FppsvX25MbYAunpcVbdqwJVv1VHGSlygj6UQ64j60MlDihuK9dqPNw/fjoj53+d5X7Nfx6Ag== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(346002)(136003)(376002)(451199015)(40470700004)(36840700001)(46966006)(33656002)(478600001)(316002)(4326008)(8676002)(110136005)(54906003)(70586007)(36860700001)(70206006)(86362001)(83380400001)(81166007)(82740400003)(7696005)(40480700001)(107886003)(356005)(6506007)(186003)(26005)(55016003)(9686003)(53546011)(40460700003)(336012)(82310400005)(47076005)(52536014)(8936002)(5660300002)(2906002)(41300700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2023 07:49:13.1069 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 802ccaa4-56dc-481e-a91f-08daf216002c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT016.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6144 DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSnVsaWVuIEdyYWxsIDxq dWxpZW5AeGVuLm9yZz4NCj4gU2VudDogU3VuZGF5LCBKYW51YXJ5IDgsIDIwMjMgNzo0NCBQTQ0K PiBUbzogUGVubnkgWmhlbmcgPFBlbm55LlpoZW5nQGFybS5jb20+OyB4ZW4tZGV2ZWxAbGlzdHMu eGVucHJvamVjdC5vcmcNCj4gQ2M6IFdlaSBDaGVuIDxXZWkuQ2hlbkBhcm0uY29tPjsgU3RlZmFu byBTdGFiZWxsaW5pDQo+IDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPjsgQmVydHJhbmQgTWFycXVp cyA8QmVydHJhbmQuTWFycXVpc0Bhcm0uY29tPjsNCj4gVm9sb2R5bXlyIEJhYmNodWsgPFZvbG9k eW15cl9CYWJjaHVrQGVwYW0uY29tPg0KPiBTdWJqZWN0OiBSZTogW1BBVENIIHYxIDAxLzEzXSB4 ZW4vYXJtOiByZS1hcnJhbmdlIHRoZSBzdGF0aWMgc2hhcmVkIG1lbW9yeQ0KPiByZWdpb24NCj4g DQo+IEhpIFBlbm55LA0KPiANCg0KSGkgSnVsaWVuDQoNCj4gT24gMTUvMTEvMjAyMiAwMjo1Miwg UGVubnkgWmhlbmcgd3JvdGU6DQo+ID4gVGhpcyBjb21taXQgcmUtYXJyYW5nZXMgdGhlIHN0YXRp YyBzaGFyZWQgbWVtb3J5IHJlZ2lvbnMgaW50byBhDQo+ID4gc2VwYXJhdGUgYXJyYXkgc2htX21l bWluZm8uIEFuZCBzdGF0aWMgc2hhcmVkIG1lbW9yeSByZWdpb24gbm93DQo+IHdvdWxkDQo+ID4g aGF2ZSBpdHMgb3duIHN0cnVjdHVyZSAnc2htX21lbWJhbmsnIHRvIGhvbGQgYWxsIHNobS1yZWxh dGVkIG1lbWJlcnMsDQo+ID4gbGlrZSBzaG1faWQsIGV0YywgYW5kIGEgcG9pbnRlciB0byB0aGUg bm9ybWFsIG1lbW9yeSBiYW5rICdtZW1iYW5rJy4NCj4gPiBUaGlzIHdpbGwgYXZvaWQgY29udGlu dWluZyB0byBncm93ICdtZW1iYW5rJy4NCj4gPg0KPiA+IFNpZ25lZC1vZmYtYnk6IFBlbm55IFpo ZW5nIDxwZW5ueS56aGVuZ0Bhcm0uY29tPg0KPiA+IC0tLQ0KPiA+ICAgeGVuL2FyY2gvYXJtL2Jv b3RmZHQuYyAgICAgICAgICAgIHwgNDAgKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLQ0K PiA+ICAgeGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jICAgICAgIHwgMzUgKysrKysrKysrKysr KysrKy0tLS0tLS0tLS0tDQo+ID4gICB4ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20va2VybmVsLmgg fCAgMiArLQ0KPiA+ICAgeGVuL2FyY2gvYXJtL2luY2x1ZGUvYXNtL3NldHVwLmggIHwgMTYgKysr KysrKysrLS0tLQ0KPiA+ICAgNCBmaWxlcyBjaGFuZ2VkLCA1OSBpbnNlcnRpb25zKCspLCAzNCBk ZWxldGlvbnMoLSkNCj4gPg0KPiA+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vYm9vdGZkdC5j IGIveGVuL2FyY2gvYXJtL2Jvb3RmZHQuYyBpbmRleA0KPiA+IDYwMTRjMGY4NTIuLmNjZjI4MWNk MzcgMTAwNjQ0DQo+ID4gLS0tIGEveGVuL2FyY2gvYXJtL2Jvb3RmZHQuYw0KPiA+ICsrKyBiL3hl bi9hcmNoL2FybS9ib290ZmR0LmMNCj4gPiBAQCAtMzg0LDYgKzM4NCw3IEBAIHN0YXRpYyBpbnQg X19pbml0IHByb2Nlc3Nfc2htX25vZGUoY29uc3Qgdm9pZCAqZmR0LA0KPiBpbnQgbm9kZSwNCj4g PiAgICAgICBjb25zdCBfX2JlMzIgKmNlbGw7DQo+ID4gICAgICAgcGFkZHJfdCBwYWRkciwgZ2Fk ZHIsIHNpemU7DQo+ID4gICAgICAgc3RydWN0IG1lbWluZm8gKm1lbSA9ICZib290aW5mby5yZXNl cnZlZF9tZW07DQo+IA0KPiBBZnRlciB0aGlzIHBhdGNoLCAnbWVtJyBpcyBiYXJlbHkgZ29pbmcg dG8gYmUgdXNlZC4gU28gSSB3b3VsZCByZWNvbW1lbmQgdG8NCj4gcmVtb3ZlIGl0IG9yIHJlc3Ry aWN0IHRoZSBzY29wZS4NCj4NCg0KSG9wZSBJIHVuZGVyc3RhbmQgY29ycmVjdGx5LCB5b3UgYXJl IHNheWluZyB0aGF0IGFsbCBzdGF0aWMgc2hhcmVkIG1lbW9yeSBiYW5rIHdpbGwgYmUNCmRlc2Ny aWJlZCBhcyAic3RydWN0IHNobV9tZW1iYW5rIi4gVGhhdCdzIHJpZ2h0Lg0KSG93ZXZlciB3aGVu IGhvc3QgYWRkcmVzcyBpcyBwcm92aWRlZCwgd2Ugc3RpbGwgbmVlZCBhbiBpbnN0YW5jZSBvZiAi c3RydWN0IG1lbWJhbmsiDQp0byByZWZlciB0byBpbiAiYm9vdGluZm8ucmVzZXJ2ZWRfbWVtIi4g T25seSBpbiB0aGlzIHdheSwgaXQgY291bGQgYmUgaW5pdGlhbGl6ZWQgcHJvcGVybHkgaW4NCmFz IHN0YXRpYyBwYWdlcy4NClRoYXQncyB3aHkgSSBwdXQgYSAic3RydWN0IG1lbWJhbmsqIiBwb2lu dGVyIGluICJzdHJ1Y3Qgc2htX21lbWJhbmsiIHRvIHJlZmVyIHRvIHRoZQ0Kc2FtZSBvYmplY3Qu DQpJZiBJIHJlbW92ZWQgaW5zdGFuY2UgaW4gYm9vdGluZm8ucmVzZXJ2ZWRfbWVtLCBhIGZldyBt b3JlIHBhdGggbmVlZHMgdG8gYmUgdXBkYXRlZCwgbGlrZQ0KSW5pdF9zdGF0aWNtZW1fcGFnZXMs IGR0X3VucmVzZXJ2ZWRfcmVnaW9ucywgZXRjDQogDQo+IFRoaXMgd2lsbCBtYWtlIGVhc2llciB0 byBjb25maXJtIHRoYXQgbW9zdCBvZiB0aGUgdXNlIG9mICdtZW0nIGhhdmUgYmVlbg0KPiByZXBs YWNlZCB3aXRoICdzaG1fbWVtJyBhbmQgcmVkdWNlIHRoZSByaXNrIG9mIGNvbmZ1c2lvbiBiZXR3 ZWVuIHRoZSB0d28NCj4gKHRoZSBuYW1lIGFyZSBxdWl0ZSBzaW1pbGFyKS4NCj4gDQo+IFsuLi5d DQo+IA0KPiA+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMgYi94ZW4v YXJjaC9hcm0vZG9tYWluX2J1aWxkLmMNCj4gPiBpbmRleCBiZDMwZDM3OThjLi5jMGZkMTNmNmVk IDEwMDY0NA0KPiA+IC0tLSBhL3hlbi9hcmNoL2FybS9kb21haW5fYnVpbGQuYw0KPiA+ICsrKyBi L3hlbi9hcmNoL2FybS9kb21haW5fYnVpbGQuYw0KPiA+IEBAIC03NTcsMjAgKzc1NywyMCBAQCBz dGF0aWMgaW50IF9faW5pdA0KPiBhY3F1aXJlX25yX2JvcnJvd2VyX2RvbWFpbihzdHJ1Y3QgZG9t YWluICpkLA0KPiA+ICAgew0KPiA+ICAgICAgIHVuc2lnbmVkIGludCBiYW5rOw0KPiA+DQo+ID4g LSAgICAvKiBJdGVyYXRlIHJlc2VydmVkIG1lbW9yeSB0byBmaW5kIHJlcXVlc3RlZCBzaG0gYmFu ay4gKi8NCj4gPiAtICAgIGZvciAoIGJhbmsgPSAwIDsgYmFuayA8IGJvb3RpbmZvLnJlc2VydmVk X21lbS5ucl9iYW5rczsgYmFuaysrICkNCj4gPiArICAgIC8qIEl0ZXJhdGUgc3RhdGljIHNoYXJl ZCBtZW1vcnkgdG8gZmluZCByZXF1ZXN0ZWQgc2htIGJhbmsuICovDQo+ID4gKyAgICBmb3IgKCBi YW5rID0gMCA7IGJhbmsgPCBib290aW5mby5zaG1fbWVtLm5yX2JhbmtzOyBiYW5rKysgKQ0KPiA+ ICAgICAgIHsNCj4gPiAtICAgICAgICBwYWRkcl90IGJhbmtfc3RhcnQgPSBib290aW5mby5yZXNl cnZlZF9tZW0uYmFua1tiYW5rXS5zdGFydDsNCj4gPiAtICAgICAgICBwYWRkcl90IGJhbmtfc2l6 ZSA9IGJvb3RpbmZvLnJlc2VydmVkX21lbS5iYW5rW2JhbmtdLnNpemU7DQo+ID4gKyAgICAgICAg cGFkZHJfdCBiYW5rX3N0YXJ0ID0gYm9vdGluZm8uc2htX21lbS5iYW5rW2JhbmtdLm1lbWJhbmst DQo+ID5zdGFydDsNCj4gPiArICAgICAgICBwYWRkcl90IGJhbmtfc2l6ZSA9DQo+ID4gKyBib290 aW5mby5zaG1fbWVtLmJhbmtbYmFua10ubWVtYmFuay0+c2l6ZTsNCj4gDQo+IEkgd2FzIGV4cGVj dGluZyBhICJpZiAodHlwZSA9PSBNRU1CQU5LX1NUQVRJQ19ET01BSU4pIC4uLiIgIHRvIGJlDQo+ IHJlbW92ZWQuIEJ1dCBpdCBsb29rcyBsaWtlIHRoZXJlIHdhcyBub25lLiBJIGd1ZXNzIHRoYXQg d2FzIGEgbWlzdGFrZSBpbiB0aGUNCj4gZXhpc3RpbmcgY29kZT8NCj4gDQoNCk9oLCB5b3UncmUg cmlnaHQsIHRoZSB0eXBlIHNoYWxsIGFsc28gYmUgY2hlY2tlZC4NCg0KPiA+DQo+ID4gICAgICAg ICAgIGlmICggKHBiYXNlID09IGJhbmtfc3RhcnQpICYmIChwc2l6ZSA9PSBiYW5rX3NpemUpICkN Cj4gPiAgICAgICAgICAgICAgIGJyZWFrOw0KPiA+ICAgICAgIH0NCj4gPg0KPiA+IC0gICAgaWYg KCBiYW5rID09IGJvb3RpbmZvLnJlc2VydmVkX21lbS5ucl9iYW5rcyApDQo+ID4gKyAgICBpZiAo IGJhbmsgPT0gYm9vdGluZm8uc2htX21lbS5ucl9iYW5rcyApDQo+ID4gICAgICAgICAgIHJldHVy biAtRU5PRU5UOw0KPiA+DQo+ID4gLSAgICAqbnJfYm9ycm93ZXJzID0NCj4gYm9vdGluZm8ucmVz ZXJ2ZWRfbWVtLmJhbmtbYmFua10ubnJfc2htX2JvcnJvd2VyczsNCj4gPiArICAgICpucl9ib3Jy b3dlcnMgPSBib290aW5mby5zaG1fbWVtLmJhbmtbYmFua10ubnJfc2htX2JvcnJvd2VyczsNCj4g Pg0KPiA+ICAgICAgIHJldHVybiAwOw0KPiA+ICAgfQ0KPiA+IEBAIC05MDcsMTEgKzkwNywxOCBA QCBzdGF0aWMgaW50IF9faW5pdA0KPiBhcHBlbmRfc2htX2JhbmtfdG9fZG9tYWluKHN0cnVjdCBr ZXJuZWxfaW5mbyAqa2luZm8sDQo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHBhZGRyX3Qgc3RhcnQsIHBhZGRyX3Qgc2l6ZSwNCj4gPiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3QgY2hhciAqc2htX2lkKQ0K PiA+ICAgew0KPiA+ICsgICAgc3RydWN0IG1lbWJhbmsgKm1lbWJhbms7DQo+ID4gKw0KPiA+ICAg ICAgIGlmICgga2luZm8tPnNobV9tZW0ubnJfYmFua3MgPj0gTlJfTUVNX0JBTktTICkNCj4gPiAg ICAgICAgICAgcmV0dXJuIC1FTk9NRU07DQo+ID4NCj4gPiAtICAgIGtpbmZvLT5zaG1fbWVtLmJh bmtba2luZm8tPnNobV9tZW0ubnJfYmFua3NdLnN0YXJ0ID0gc3RhcnQ7DQo+ID4gLSAgICBraW5m by0+c2htX21lbS5iYW5rW2tpbmZvLT5zaG1fbWVtLm5yX2JhbmtzXS5zaXplID0gc2l6ZTsNCj4g PiArICAgIG1lbWJhbmsgPSB4bWFsbG9jX2J5dGVzKHNpemVvZihzdHJ1Y3QgbWVtYmFuaykpOw0K PiANCj4gWW91IGFsbG9jYXRlIG1lbW9yeSBidXQgbmV2ZXIgZnJlZSBpdC4gSG93ZXZlciwgSSB0 aGluayBpdCB3b3VsZCBiZSBiZXR0ZXIgdG8NCj4gYXZvaWQgdGhlIGR5bmFtaWMgYWxsb2NhdGlv bi4gU28gSSB3b3VsZCBjb25zaWRlciB0byBub3QgdXNlIHRoZSBzdHJ1Y3R1cmUNCj4gc2htX21l bWJhbmsgYW5kIGluc3RlYWQgY3JlYXRlIGEgc3BlY2lmaWMgb25lIGZvciB0aGUgZG9tYWluIGNv bnN0cnVjdGlvbi4NCj4gDQoNClRydWUsIGEgbG9jYWwgdmFyaWFibGUgInN0cnVjdCBtZW1pbmZv IHNobV9iYW5rcyIgY291bGQgYmUgaW50cm9kdWNlZCBvbmx5DQpmb3IgZG9tYWluIGNvbnN0cnVj dGlvbiBpbiBmdW5jdGlvbiBjb25zdHJ1Y3RfZG9tVQ0KDQo+ID4gKyAgICBpZiAoIG1lbWJhbmsg PT0gTlVMTCApDQo+ID4gKyAgICAgICAgcmV0dXJuIC1FTk9NRU07DQo+ID4gKw0KPiA+ICsgICAg a2luZm8tPnNobV9tZW0uYmFua1traW5mby0+c2htX21lbS5ucl9iYW5rc10ubWVtYmFuayA9DQo+ IG1lbWJhbms7DQo+ID4gKyAgICBraW5mby0+c2htX21lbS5iYW5rW2tpbmZvLT5zaG1fbWVtLm5y X2JhbmtzXS5tZW1iYW5rLT5zdGFydCA9DQo+IHN0YXJ0Ow0KPiA+ICsgICAga2luZm8tPnNobV9t ZW0uYmFua1traW5mby0+c2htX21lbS5ucl9iYW5rc10ubWVtYmFuay0+c2l6ZSA9DQo+ID4gKyBz aXplOw0KPiANCj4gVGhlIGxhc3QgdHdvIGNvdWxkIGJlIHJlcGxhY2VkIHdpdGg6DQo+IA0KPiBt ZW1iYW5rLT5zdGFydCA9IHN0YXJ0Ow0KPiBtZW1iYW5rLT5zaXplID0gc2l6ZTsNCj4gDQo+IFRo aXMgd291bGQgbWFrZSB0aGUgY29kZSBtb3JlIHJlYWRhYmxlLiBBbHNvLCB3aGlsZSB5b3UgYXJl IG1vZGlmeWluZyB0aGUNCj4gY29kZSwgSSB3b3VsZCBjb25zaWRlciB0byBpbnRyb2R1Y2UgYSBs b2NhbCB2YXJpYWJsZSB0aGF0IHBvaW50cyB0bw0KPiBraW5mby0+c2htX21lbS5iYW5rW2tpbmZv LT5zaG1fbWVtLm5yX2JhbmtzXS4NCj4gDQo+IFsuLi5dDQo+IA0KPiA+ICAgc3RydWN0IG1lbWlu Zm8gew0KPiA+IEBAIC02MSw2ICs1NywxNyBAQCBzdHJ1Y3QgbWVtaW5mbyB7DQo+ID4gICAgICAg c3RydWN0IG1lbWJhbmsgYmFua1tOUl9NRU1fQkFOS1NdOw0KPiA+ICAgfTsNCj4gPg0KPiA+ICtz dHJ1Y3Qgc2htX21lbWJhbmsgew0KPiA+ICsgICAgY2hhciBzaG1faWRbTUFYX1NITV9JRF9MRU5H VEhdOw0KPiA+ICsgICAgdW5zaWduZWQgaW50IG5yX3NobV9ib3Jyb3dlcnM7DQo+ID4gKyAgICBz dHJ1Y3QgbWVtYmFuayAqbWVtYmFuazsNCj4gDQo+IEFmdGVyIHRoZSBjaGFuZ2UgSSBzdWdnZXN0 IGFib3ZlLCBJIHdvdWxkIGV4cGVjdCB0aGF0IHRoZSBmaWVsZCBvZg0KPiBtZW1iYW5rIHdpbGwg bm90IGJlIHVwZGF0ZWQuIFNvIEkgd291bGQgYWRkIGNvbnN0IGhlcmUuDQo+IA0KPiBDaGVlcnMs DQo+IA0KPiAtLQ0KPiBKdWxpZW4gR3JhbGwNCg== From xen-devel-bounces@lists.xenproject.org Mon Jan 09 07:50:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 07:50:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473342.733876 (Exim 4.92) (envelope-from ) id 1pEmv5-0006YH-73; Mon, 09 Jan 2023 07:50:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473342.733876; Mon, 09 Jan 2023 07:50:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEmv5-0006YA-3S; Mon, 09 Jan 2023 07:50:11 +0000 Received: by outflank-mailman (input) for mailman id 473342; Mon, 09 Jan 2023 07:50:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEmv3-0005jj-OU for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 07:50:09 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on2073.outbound.protection.outlook.com [40.107.8.73]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3c1bc36a-8ff2-11ed-91b6-6bf2151ebd3b; Mon, 09 Jan 2023 08:50:07 +0100 (CET) Received: from DB6PR07CA0089.eurprd07.prod.outlook.com (2603:10a6:6:2b::27) by AM9PR08MB5889.eurprd08.prod.outlook.com (2603:10a6:20b:2d5::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Mon, 9 Jan 2023 07:50:03 +0000 Received: from DBAEUR03FT043.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:2b:cafe::3) by DB6PR07CA0089.outlook.office365.com (2603:10a6:6:2b::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.10 via Frontend Transport; Mon, 9 Jan 2023 07:50:03 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT043.mail.protection.outlook.com (100.127.143.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Mon, 9 Jan 2023 07:50:03 +0000 Received: ("Tessian outbound 6e565e48ed4a:v132"); Mon, 09 Jan 2023 07:50:02 +0000 Received: from b24ff69f56c9.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4DEA6985-949A-4C8F-BB54-5328AB1B1B6E.1; Mon, 09 Jan 2023 07:49:52 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b24ff69f56c9.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 09 Jan 2023 07:49:52 +0000 Received: from AM0PR08MB4530.eurprd08.prod.outlook.com (2603:10a6:208:13c::21) by DBBPR08MB6297.eurprd08.prod.outlook.com (2603:10a6:10:20b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Mon, 9 Jan 2023 07:49:48 +0000 Received: from AM0PR08MB4530.eurprd08.prod.outlook.com ([fe80::ee26:4b5e:4334:b7ab]) by AM0PR08MB4530.eurprd08.prod.outlook.com ([fe80::ee26:4b5e:4334:b7ab%7]) with mapi id 15.20.5986.018; Mon, 9 Jan 2023 07:49:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3c1bc36a-8ff2-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JBX0aIpnIUaKUAwZTfrn7DzcMpOI+YfOn9QeJP7C4fE=; b=SpuAgp8f2VDmS0Tj6scUTJ1KDdjikTZdVVof7ApKotQUzeoGrpWTUH6iN5BQX1z5ZxwIW5QmK4DTRNHevSMGB+TXDsXBFxFvjoGQ9ddCKF9tNazRJq18324SLkJvSbykS1fUDhFnS5NA4K7MZMJWB7yDA8QR6s0nbKoyPyuMaZ4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W+0zfIY1jde15/jbvQZfi6gVTFcZCdh+LeJuRTj8nqIM36iOyeNEz5lcSFF172wGvYxAWNoGrubSvf0IxZuE8S33dKI+r5QEeqcx8giGwsw6XKKAZbPsbqv9KKcevLLHhrRlJ2CicjGOEUxTuZPFzEpH8gtPB/Qc7dvKr6LCciH08f0csumWgtOQD8tFYL+9rNd+pfNMBMW4Rp8qg0r8HG/yLCP/CtMbZmfnYlGDIVZHL3v0xIhd6VvVu4IRQz1uqAkR1gU7NR6PNn7f4ZIJoow4dBrpXwjJXomujfpsxpPPamypQAC7VSsiVgoUnmlGZSy1aRvPRgeVd9Ti6TYyvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JBX0aIpnIUaKUAwZTfrn7DzcMpOI+YfOn9QeJP7C4fE=; b=Qftwo7inCgg2wuNTT8sVGUrgkK/iTZ0TC1LelOzm2n/LkXEJ17V2byGnmw0k6xBGzfOVXHMGc5IFZ91zB3WeYQbHChAv62rtFBiZn3tkpy/u94QmFm5WPqSs0ONSo6bDzZJPk53x/74mWJ6sY7G3oCC/uRxI/HBV+/SXts7aAZe24ifK5gfzJ1awHD4hWYYl+9uYKPZXenNmRfPNwjrf4Z1NI3pMKB3duTR4y9D/52MkT0HEfhkweUHzBifmFX6YHoVGG42n69fneIOd06Gq9wsO8K7o+nYL/Ue1LlusLBUR7vY8WYh4GK9ucM1b+I7zAUU+2dXuX+222/lJpqttHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JBX0aIpnIUaKUAwZTfrn7DzcMpOI+YfOn9QeJP7C4fE=; b=SpuAgp8f2VDmS0Tj6scUTJ1KDdjikTZdVVof7ApKotQUzeoGrpWTUH6iN5BQX1z5ZxwIW5QmK4DTRNHevSMGB+TXDsXBFxFvjoGQ9ddCKF9tNazRJq18324SLkJvSbykS1fUDhFnS5NA4K7MZMJWB7yDA8QR6s0nbKoyPyuMaZ4= From: Penny Zheng To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Wei Chen , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH v1 06/13] xen/arm: assign shared memory to owner when host address not provided Thread-Topic: [PATCH v1 06/13] xen/arm: assign shared memory to owner when host address not provided Thread-Index: AQHY+J1pmmYEajWz5UynKX+c5rdEZK6UzwiAgAEQoXA= Date: Mon, 9 Jan 2023 07:49:48 +0000 Message-ID: References: <20221115025235.1378931-1-Penny.Zheng@arm.com> <20221115025235.1378931-7-Penny.Zheng@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 346C653763857F478338C32F81DBCC90.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM0PR08MB4530:EE_|DBBPR08MB6297:EE_|DBAEUR03FT043:EE_|AM9PR08MB5889:EE_ X-MS-Office365-Filtering-Correlation-Id: f06fa070-c870-43cd-c4ea-08daf2161de2 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 3CQWUNRbaIuJPXeSOGDKdCOwN3/TLoWtc1cRu+LGQrgiAYrjZq3GSayhx2aG7RVC938QSwLAvx4imlJlkmmNl2K1wQoseJIMN83sGt6LaA/ZVsI0QIa22oNiflF6jwiFEG76jEcfIzhr853CvTOb+bNGyTU0BNbq2Lyt+1Gp71L8bBONHQGRVQnEvJr7sRNfG/AsxayjQpLVSQSGAvgtv6Sr66lUmysEz6LmY66PIc7XnHhv73gMKViAJckJytOkti37Y8cYxG09m/DhhGIII+NUFL/0nIiRqgfv19Dw2ZOqfBV6plQhb5SkCuddGSFX/NYizfsPxo/0731hwzv9UT3EbT7nbf0dmRkOuu6jEkPCY0XF3Dau2SHUTWItB5kpAppmJ22Il9CYTEZbZbjQGd0A5zYQXRfdSJdp0GMyirkN2VVFffSkvlOVl/mI4/Jb3J9Ij/DTvypIa9K52udoLlKq2rxC3HsPJJVU2G1j9Gox9q7qJG9PImdCeOj1z7nNQVbaxp2fptIuwKE/lWY1pfcE2n3nytkYwf5zJiubUQNOvm3YOFCEhhWcBBjXrJ9I6ZT+aCV0P5LupHvQrNEaA3z61WLGS0lSXeA7PUjgFc8bVxDbobwADRQ8yArD1X+etYpNHyjDgQWvoHZNLvQJ/ry4XPgmHnKpNFFJEWaYwCIbUxRPRKN7At61jg7qxU5xbj0KU0bjqUTqAxgeUj8Feg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB4530.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(366004)(376002)(136003)(346002)(451199015)(33656002)(52536014)(41300700001)(83380400001)(64756008)(4326008)(76116006)(66946007)(66476007)(8676002)(38100700002)(66556008)(5660300002)(8936002)(66446008)(54906003)(110136005)(55016003)(9686003)(186003)(26005)(122000001)(7696005)(478600001)(38070700005)(53546011)(71200400001)(6506007)(86362001)(316002)(2906002)(66899015);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6297 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: d4f2de75-35b4-4ce7-c457-08daf2161539 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZWaYVQVRAFHk9cHwIouinG87iuoXAF6d06OCfVAMQahP/LHIzPVaHauoNYPbOODdAvyM5mhSaP9oPvHbzh6zeb6tuk2yZjA62YqzJcdi2n+OrYyqfhv3w0dHKPxWPeKFhqFab2yF2ymSKtl2NIDWjxk8Doj3+/COONt1SvoYMuPtCxMrGEYlFNAF4vPeX3D1nw4hprH+fQ9SqlBjUjZs8aCMwt4Os5TpQ/8USRXHP5s8hz8IwUahuzJCRSByGW0009lCiipt5KZYRSsVakiSPpoJlNgGHZkcLRlYMAFS+698Hj0EyWHbOVFN4Ia5rx+DPrcHBqnqa+qltvf0rfaLsPuLDgP/ZXUvC4aVOL6hZJM+7lhfVmUMQR2StG+i9dW44T8NSRWYoDXecc2tKsENL3JVCVIHnuhsPSqrbq2HirRr6r0bT6VVQqQ+JvlcFarC37Zh3ae9O5CRY2lnYthamB90cUZbLM3Gnv84zU2vqJP+UiSUxvGgF61C0G423Xf1VJqTU/XxEnJYKH3hvo49y/ChT0VjFvuez77agblp1Ic4udWGjy1/6PbHR5yJEnTeWIeQDkIHSGr8cpLyyJjNheb55sJbRQzkYnU1zms+Sd28auKNohiJOkPDCHYdxGy0FuyN2omqFLrAAMFkHdI3qfUoorjogFYQ7VXhpxlp73+zjLQTL1ArmHiqT2XhCn9rdDZUGCCBogPOpK6IaEGVNw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(346002)(376002)(136003)(451199015)(36840700001)(46966006)(40470700004)(33656002)(7696005)(2906002)(54906003)(110136005)(8676002)(70206006)(4326008)(316002)(70586007)(83380400001)(81166007)(82740400003)(47076005)(356005)(36860700001)(82310400005)(40460700003)(478600001)(9686003)(26005)(186003)(86362001)(40480700001)(55016003)(107886003)(6506007)(336012)(53546011)(66899015)(8936002)(52536014)(5660300002)(41300700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2023 07:50:03.0949 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f06fa070-c870-43cd-c4ea-08daf2161de2 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB5889 SGkgSnVsaWVuDQoNCkhhcHB5IG5ldyB5ZWFyfn5+fg0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2Fn ZS0tLS0tDQo+IEZyb206IEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+IFNlbnQ6IFN1 bmRheSwgSmFudWFyeSA4LCAyMDIzIDg6NTMgUE0NCj4gVG86IFBlbm55IFpoZW5nIDxQZW5ueS5a aGVuZ0Bhcm0uY29tPjsgeGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQo+IENjOiBXZWkg Q2hlbiA8V2VpLkNoZW5AYXJtLmNvbT47IFN0ZWZhbm8gU3RhYmVsbGluaQ0KPiA8c3N0YWJlbGxp bmlAa2VybmVsLm9yZz47IEJlcnRyYW5kIE1hcnF1aXMgPEJlcnRyYW5kLk1hcnF1aXNAYXJtLmNv bT47DQo+IFZvbG9keW15ciBCYWJjaHVrIDxWb2xvZHlteXJfQmFiY2h1a0BlcGFtLmNvbT4NCj4g U3ViamVjdDogUmU6IFtQQVRDSCB2MSAwNi8xM10geGVuL2FybTogYXNzaWduIHNoYXJlZCBtZW1v cnkgdG8gb3duZXINCj4gd2hlbiBob3N0IGFkZHJlc3Mgbm90IHByb3ZpZGVkDQo+IA0KPiBIaSwN Cj4gDQo+IE9uIDE1LzExLzIwMjIgMDI6NTIsIFBlbm55IFpoZW5nIHdyb3RlOg0KPiA+IEBAIC05 MjIsMzMgKzkyNyw4MiBAQCBzdGF0aWMgbWZuX3QgX19pbml0DQo+IGFjcXVpcmVfc2hhcmVkX21l bW9yeV9iYW5rKHN0cnVjdCBkb21haW4gKmQsDQo+ID4gICAgICAgZC0+bWF4X3BhZ2VzICs9IG5y X3BmbnM7DQo+ID4NCj4gPiAgICAgICBzbWZuID0gbWFkZHJfdG9fbWZuKHBiYXNlKTsNCj4gPiAt ICAgIHJlcyA9IGFjcXVpcmVfZG9tc3RhdGljX3BhZ2VzKGQsIHNtZm4sIG5yX3BmbnMsIDApOw0K PiA+IC0gICAgaWYgKCByZXMgKQ0KPiA+ICsgICAgcGFnZSA9IG1mbl90b19wYWdlKHNtZm4pOw0K PiA+ICsgICAgLyoNCj4gPiArICAgICAqIElmIHBhZ2UgaXMgYWxsb2NhdGVkIGZyb20gaGVhcCBh cyBzdGF0aWMgc2hhcmVkIG1lbW9yeSwgdGhlbiB3ZSBqdXN0DQo+ID4gKyAgICAgKiBhc3NpZ24g aXQgdG8gdGhlIG93bmVyIGRvbWFpbg0KPiA+ICsgICAgICovDQo+ID4gKyAgICBpZiAoIHBhZ2Ut PmNvdW50X2luZm8gPT0gKFBHQ19zdGF0ZV9pbnVzZSB8IFBHQ19zdGF0aWMpICkNCj4gSSBhbSBh IGJpdCBjb25mdXNlZCBob3cgdGhpcyBjYW4gaGVscCBkaWZmZXJlbnRpYXRpbmcgYmVjYVBHQ19z dGF0ZV9pbnVzZSBpcw0KPiAwLiBTbyBlZmZlY3RpdmVseSwgeW91IGFyZSBjaGVja2luZyB0aGF0 IGNvdW50X2luZm8gaXMgZXF1YWwgdG8gUEdDX3N0YXRpYy4NCj4gDQoNCldoZW4gaG9zdCBhZGRy ZXNzIGlzIHByb3ZpZGVkLCB0aGUgaG9zdCBhZGRyZXNzIHJhbmdlIGRlZmluZWQgaW4NCnhlbixz dGF0aWMtbWVtIHdpbGwgYmUgc3RvcmVkIGFzIGEgInN0cnVjdCBtZW1iYW5rIiB3aXRoIHR5cGUN Cm9mICJNRU1CQU5LX1NUQVRJQ19ET01BSU4iIGluICJib290aW5mby5yZXNlcnZlZF9tZW0iDQpU aGVuIGl0IHdpbGwgYmUgaW5pdGlhbGl6ZWQgYXMgc3RhdGljIG1lbW9yeSB0aHJvdWdoICJpbml0 X3N0YXRpY21lbV9wYWdlcyINClNvIGhlcmUgaXRzIHBhZ2UtPmNvdW50X2luZm8gaXMgUEdDX3N0 YXRlX2ZyZWUgfFBHQ19zdGF0aWMuDQpGb3IgcGFnZXMgYWxsb2NhdGVkIGZyb20gaGVhcCwgaXRz IHBhZ2Ugc3RhdGUgaXMgZGlmZmVyZW50LCBiZWluZyBQR0Nfc3RhdGVfaW51c2UuDQpTbyBhY3R1 YWxseSwgd2UgYXJlIGNoZWNraW5nIHBhZ2Ugc3RhdGUgdG8gdGVsbCB0aGUgZGlmZmVyZW5jZSAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAuDQoNCj4g QnV0IGFzIEkgd3JvdGUgaW4gYSBwcmV2aW91cyBwYXRjaCwgSSBkb24ndCB0aGluayB5b3Ugc2hv dWxkIGNvbnZlcnQNCj4ge3hlbixkb219aGVhcCBwYWdlcyB0byBhIHN0YXRpYyBwYWdlcy4NCj4N Cg0KSSBhZ3JlZSB0aGF0IHRha2luZyByZWZlcmVuY2UgY291bGQgYWxzbyBwcmV2ZW50IGdpdmlu ZyB0aGVzZSBwYWdlcyBiYWNrIHRvIGhlYXAuIA0KQnV0IG1heSBJIGFzayB3aGF0IGlzIHlvdXIg Y29uY2VybiBvbiBjb252ZXJ0aW5nIHt4ZW4sZG9tfWhlYXAgcGFnZXMgdG8gYSBzdGF0aWMgcGFn ZXM/DQogDQo+IFsuLi5dDQo+IA0KPiA+ICtzdGF0aWMgaW50IF9faW5pdCBhc3NpZ25fc2hhcmVk X21lbW9yeShzdHJ1Y3QgZG9tYWluICpkLA0KPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBzdHJ1Y3Qgc2htX21lbWJhbmsgKnNobV9tZW1iYW5rLA0KPiA+ICsgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwYWRkcl90IGdiYXNlKSB7DQo+ID4g KyAgICBpbnQgcmV0ID0gMDsNCj4gPiArICAgIHVuc2lnbmVkIGxvbmcgbnJfcGFnZXMsIG5yX2Jv cnJvd2VyczsNCj4gPiArICAgIHN0cnVjdCBwYWdlX2luZm8gKnBhZ2U7DQo+ID4gKyAgICB1bnNp Z25lZCBpbnQgaTsNCj4gPiArICAgIHN0cnVjdCBtZW1pbmZvICptZW1pbmZvOw0KPiA+ICsNCj4g PiArICAgIC8qIEhvc3QgYWRkcmVzcyBpcyBub3QgcHJvdmlkZWQgaW4gInhlbixzaGFyZWQtbWVt IiAqLw0KPiA+ICsgICAgaWYgKCBzaG1fbWVtYmFuay0+bWVtLmJhbmtzLm1lbWluZm8gKQ0KPiA+ ICsgICAgew0KPiA+ICsgICAgICAgIG1lbWluZm8gPSBzaG1fbWVtYmFuay0+bWVtLmJhbmtzLm1l bWluZm87DQo+ID4gKyAgICAgICAgZm9yICggaSA9IDA7IGkgPCBtZW1pbmZvLT5ucl9iYW5rczsg aSsrICkNCj4gPiArICAgICAgICB7DQo+ID4gKyAgICAgICAgICAgIHJldCA9IGFjcXVpcmVfc2hh cmVkX21lbW9yeShkLA0KPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgbWVtaW5mby0+YmFua1tpXS5zdGFydCwNCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIG1lbWluZm8tPmJhbmtbaV0uc2l6ZSwNCj4gPiArICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGdiYXNlKTsNCj4gPiArICAgICAgICAgICAgaWYg KCByZXQgKQ0KPiA+ICsgICAgICAgICAgICAgICAgcmV0dXJuIHJldDsNCj4gPiArDQo+ID4gKyAg ICAgICAgICAgIGdiYXNlICs9IG1lbWluZm8tPmJhbmtbaV0uc2l6ZTsNCj4gPiArICAgICAgICB9 DQo+ID4gKyAgICB9DQo+ID4gKyAgICBlbHNlDQo+ID4gKyAgICB7DQo+ID4gKyAgICAgICAgcmV0 ID0gYWNxdWlyZV9zaGFyZWRfbWVtb3J5KGQsDQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHNobV9tZW1iYW5rLT5tZW0uYmFuay0+c3RhcnQsDQo+ID4gKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHNobV9tZW1iYW5rLT5tZW0uYmFuay0+c2l6ZSwg Z2Jhc2UpOw0KPiA+ICsgICAgICAgIGlmICggcmV0ICkNCj4gPiArICAgICAgICAgICAgcmV0dXJu IHJldDsNCj4gPiArICAgIH0NCj4gDQo+IExvb2tpbmcgYXQgdGhpcyBjaGFuZ2UgYW5kLi4uDQo+ IA0KPiA+ICsNCj4gPiAgICAgICAvKg0KPiA+ICAgICAgICAqIEdldCB0aGUgcmlnaHQgYW1vdW50 IG9mIHJlZmVyZW5jZXMgcGVyIHBhZ2UsIHdoaWNoIGlzIHRoZSBudW1iZXIgb2YNCj4gPiAgICAg ICAgKiBib3Jyb3dlciBkb21haW5zLg0KPiA+IEBAIC05ODQsMjMgKzEwNzYsMzcgQEAgc3RhdGlj IGludCBfX2luaXQgYXNzaWduX3NoYXJlZF9tZW1vcnkoc3RydWN0DQo+IGRvbWFpbiAqZCwNCj4g PiAgICAgICAgKiBTbyBpZiB0aGUgYm9ycm93ZXIgaXMgY3JlYXRlZCBmaXJzdCwgaXQgd2lsbCBj YXVzZSBhZGRpbmcgcGFnZXMNCj4gPiAgICAgICAgKiBpbiB0aGUgUDJNIHdpdGhvdXQgcmVmZXJl bmNlLg0KPiA+ICAgICAgICAqLw0KPiA+IC0gICAgcGFnZSA9IG1mbl90b19wYWdlKHNtZm4pOw0K PiA+IC0gICAgZm9yICggaSA9IDA7IGkgPCBucl9wYWdlczsgaSsrICkNCj4gPiArICAgIGlmICgg c2htX21lbWJhbmstPm1lbS5iYW5rcy5tZW1pbmZvICkNCj4gPiAgICAgICB7DQo+ID4gLSAgICAg ICAgaWYgKCAhZ2V0X3BhZ2VfbnIocGFnZSArIGksIGQsIG5yX2JvcnJvd2VycykgKQ0KPiA+ICsg ICAgICAgIG1lbWluZm8gPSBzaG1fbWVtYmFuay0+bWVtLmJhbmtzLm1lbWluZm87DQo+ID4gKyAg ICAgICAgZm9yICggaSA9IDA7IGkgPCBtZW1pbmZvLT5ucl9iYW5rczsgaSsrICkNCj4gPiAgICAg ICAgICAgew0KPiA+IC0gICAgICAgICAgICBwcmludGsoWEVOTE9HX0VSUg0KPiA+IC0gICAgICAg ICAgICAgICAgICAgIkZhaWxlZCB0byBhZGQgJWx1IHJlZmVyZW5jZXMgdG8gcGFnZSAlIlBSSV9t Zm4iLlxuIiwNCj4gPiAtICAgICAgICAgICAgICAgICAgIG5yX2JvcnJvd2VycywgbWZuX3goc21m bikgKyBpKTsNCj4gPiAtICAgICAgICAgICAgZ290byBmYWlsOw0KPiA+ICsgICAgICAgICAgICBw YWdlID0gbWZuX3RvX3BhZ2UobWFkZHJfdG9fbWZuKG1lbWluZm8tPmJhbmtbaV0uc3RhcnQpKTsN Cj4gPiArICAgICAgICAgICAgbnJfcGFnZXMgPSBQRk5fRE9XTihtZW1pbmZvLT5iYW5rW2ldLnNp emUpOw0KPiA+ICsgICAgICAgICAgICByZXQgPSBhZGRfc2hhcmVkX21lbW9yeV9yZWYoZCwgcGFn ZSwgbnJfcGFnZXMsIG5yX2JvcnJvd2Vycyk7DQo+ID4gKyAgICAgICAgICAgIGlmICggcmV0ICkN Cj4gPiArICAgICAgICAgICAgICAgIGdvdG8gZmFpbDsNCj4gPiAgICAgICAgICAgfQ0KPiA+ICAg ICAgIH0NCj4gPiArICAgIGVsc2UNCj4gPiArICAgIHsNCj4gPiArICAgICAgICBwYWdlID0gbWZu X3RvX3BhZ2UoDQo+ID4gKyAgICAgICAgICAgICAgICBtYWRkcl90b19tZm4oc2htX21lbWJhbmst Pm1lbS5iYW5rLT5zdGFydCkpOw0KPiA+ICsgICAgICAgIG5yX3BhZ2VzID0gc2htX21lbWJhbmst Pm1lbS5iYW5rLT5zaXplID4+IFBBR0VfU0hJRlQ7DQo+ID4gKyAgICAgICAgcmV0ID0gYWRkX3No YXJlZF9tZW1vcnlfcmVmKGQsIHBhZ2UsIG5yX3BhZ2VzLCBucl9ib3Jyb3dlcnMpOw0KPiA+ICsg ICAgICAgIGlmICggcmV0ICkNCj4gPiArICAgICAgICAgICAgcmV0dXJuIHJldDsNCj4gPiArICAg IH0NCj4gDQo+IC4uLiB0aGlzIG9uZS4gVGhlIGNvZGUgdG8gZGVhbCB3aXRoIGEgYmFuayBpcyBl eGFjdGx5IHRoZSBzYW1lLiBCdXQgeW91IG5lZWQNCj4gdGhlIGR1cGxpY2F0aW9uIGJlY2F1c2Ug eW91IHNwZWNpYWwgY2FzZSAib25lIGJhbmsiLg0KPiANCj4gQXMgSSB3cm90ZSBpbiBhIHByZXZp b3VzIHBhdGNoLCBJIGRvbid0IHRoaW5rIHdlIHNob3VsZCBzcGVjaWFsIGNhc2UgaXQuDQo+IElm IHRoZSBjb25jZXJuIGlzIG1lbW9yeSB1c2FnZSwgdGhlbiB3ZSBzaG91bGQgbG9vayBhdCByZXdv cmtpbmcgbWVtaW5mbw0KPiBpbnN0ZWFkIChvciB1c2luZyBhIGRpZmZlcmVudCBzdHJ1Y3R1cmUp Lg0KPiANCg0KQSBmZXcgY29uY2VybnMgZXhwbGFpbmVkIHdoeSBJIGRpZG4ndCBjaG9vc2UgInN0 cnVjdCBtZW1pbmZvIiBvdmVyIHR3bw0KcG9pbnRlcnMgInN0cnVjdCBtZW1iYW5rKiIgYW5kICJz dHJ1Y3QgbWVtaW5mbyoiLg0KMSkgbWVtb3J5IHVzYWdlIGlzIHRoZSBtYWluIHJlYXNvbi4NCklm IHdlIHVzZSAic3RydWN0IG1lbWluZm8iIG92ZXIgdGhlIGN1cnJlbnQgInN0cnVjdCBtZW1iYW5r KiIgYW5kICJzdHJ1Y3QgbWVtaW5mbyoiLA0KInN0cnVjdCBzaG1fbWVtaW5mbyIgd2lsbCBiZWNv bWUgYSBhcnJheSBvZiAyNTYgInN0cnVjdCBzaG1fbWVtYmFuayIsIHdpdGgNCiJzdHJ1Y3Qgc2ht X21lbWJhbmsiIGJlaW5nIGFsc28gYW4gMjU2LWl0ZW0gYXJyYXksIHRoYXQgaXMgMjU2ICogMjU2 LCB0b28gYmlnIGZvcg0KYSBzdHJ1Y3R1cmUgYW5kIElmIEkgcmVtZW1iZXJlZCBjbGVhcmx5LCBp dCB3aWxsIGxlYWQgdG8gIm1vcmUgdGhhbiBQQUdFX1NJWkUiIGNvbXBpbGluZyBlcnJvci4gDQpG V0lULCBlaXRoZXIgcmV3b3JraW5nIG1lbWluZm8gb3IgdXNpbmcgYSBkaWZmZXJlbnQgc3RydWN0 dXJlLCBhcmUgYm90aCBsZWFkaW5nIHRvIHNpemluZyBkb3duDQp0aGUgYXJyYXksIGhtbW0sIEkg ZG9uJ3Qga25vdyB3aGljaCBzaXplIGlzIHN1aXRhYmxlLiBUaGF0J3Mgd2h5IEkgcHJlZmVyIHBv aW50ZXINCmFuZCBkeW5hbWljIGFsbG9jYXRpb24uDQoyKSBJZiB3ZSB1c2UgInN0cnVjdCBtZW1p bmZvKiIgb3ZlciB0aGUgY3VycmVudCAic3RydWN0IG1lbWJhbmsqIiBhbmQgInN0cnVjdCBtZW1p bmZvKiIsDQp3ZSB3aWxsIG5lZWQgYSBuZXcgZmxhZyB0byBkaWZmZXJlbnRpYXRlIHR3byBzY2Vu YXJpb3MoaG9zdCBhZGRyZXNzIHByb3ZpZGVkIG9yIG5vdCksIEFzDQp0aGUgc3BlY2lhbCBjYXNl ICJzdHJ1Y3QgbWVtYmFuayoiIGlzIGFscmVhZHkgaGVscGluZyB1cyBkaWZmZXJlbnRpYXRlLg0K QW5kIHNpbmNlIHdoZW4gaG9zdCBhZGRyZXNzIGlzIHByb3ZpZGVkLCB0aGUgcmVsYXRlZCAic3Ry dWN0IG1lbWJhbmsiIGFsc28gbmVlZHMgdG8gYmUNCnJlc2VydmVkIGluICJib290aW5mby5yZXNl cnZlZF9tZW0iLiBUaGF0J3Mgd2h5IEkgdXNlZCBwb2ludGVyICIgc3RydWN0IG1lbWJhbmsqIiB0 bw0KYXZvaWQgbWVtb3J5IHdhc3RlLg0KRm9yIHRoZSBkdXBsaWNhdGlvbiwgSSBjb3VsZCBleHRy YWN0IHRoZSBjb21tb24gY29kZXMgdG8gbWl0aWdhdGUgdGhlIGltcGFjdC4NCg0KPiA+DQo+ID4g ICAgICAgcmV0dXJuIDA7DQo+IA0KPg0KPiA+ICAgIGZhaWw6DQo+ID4gICAgICAgd2hpbGUgKCAt LWkgPj0gMCApDQo+ID4gLSAgICAgICAgcHV0X3BhZ2VfbnIocGFnZSArIGksIG5yX2JvcnJvd2Vy cyk7DQo+ID4gKyAgICB7DQo+ID4gKyAgICAgICAgcGFnZSA9IG1mbl90b19wYWdlKG1hZGRyX3Rv X21mbihtZW1pbmZvLT5iYW5rW2ldLnN0YXJ0KSk7DQo+ID4gKyAgICAgICAgbnJfcGFnZXMgPSBQ Rk5fRE9XTihtZW1pbmZvLT5iYW5rW2ldLnNpemUpOw0KPiA+ICsgICAgICAgIHJlbW92ZV9zaGFy ZWRfbWVtb3J5X3JlZihwYWdlLCBucl9wYWdlcywgbnJfYm9ycm93ZXJzKTsNCj4gPiArICAgIH0N Cj4gPiAgICAgICByZXR1cm4gcmV0Ow0KPiA+ICAgfQ0KPiA+DQo+IA0KPiBDaGVlcnMsDQo+IA0K PiAtLQ0KPiBKdWxpZW4gR3JhbGwNCg== From xen-devel-bounces@lists.xenproject.org Mon Jan 09 07:50:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 07:50:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473345.733887 (Exim 4.92) (envelope-from ) id 1pEmva-00071H-F7; Mon, 09 Jan 2023 07:50:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473345.733887; Mon, 09 Jan 2023 07:50:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEmva-00071A-CP; Mon, 09 Jan 2023 07:50:42 +0000 Received: by outflank-mailman (input) for mailman id 473345; Mon, 09 Jan 2023 07:50:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEmvY-00070q-Rl for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 07:50:40 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on2055.outbound.protection.outlook.com [40.107.8.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4f417093-8ff2-11ed-91b6-6bf2151ebd3b; Mon, 09 Jan 2023 08:50:39 +0100 (CET) Received: from AS8PR04CA0032.eurprd04.prod.outlook.com (2603:10a6:20b:312::7) by AS8PR08MB5926.eurprd08.prod.outlook.com (2603:10a6:20b:29d::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Mon, 9 Jan 2023 07:50:27 +0000 Received: from AM7EUR03FT022.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:312:cafe::7c) by AS8PR04CA0032.outlook.office365.com (2603:10a6:20b:312::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Mon, 9 Jan 2023 07:50:27 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT022.mail.protection.outlook.com (100.127.140.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Mon, 9 Jan 2023 07:50:27 +0000 Received: ("Tessian outbound 3ad958cd7492:v132"); Mon, 09 Jan 2023 07:50:26 +0000 Received: from 632d197bea05.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 3F94A596-AE24-47C1-B5F4-662D93B1B2E7.1; Mon, 09 Jan 2023 07:50:16 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 632d197bea05.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 09 Jan 2023 07:50:16 +0000 Received: from AM0PR08MB4530.eurprd08.prod.outlook.com (2603:10a6:208:13c::21) by DBBPR08MB6297.eurprd08.prod.outlook.com (2603:10a6:10:20b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Mon, 9 Jan 2023 07:50:14 +0000 Received: from AM0PR08MB4530.eurprd08.prod.outlook.com ([fe80::ee26:4b5e:4334:b7ab]) by AM0PR08MB4530.eurprd08.prod.outlook.com ([fe80::ee26:4b5e:4334:b7ab%7]) with mapi id 15.20.5986.018; Mon, 9 Jan 2023 07:50:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4f417093-8ff2-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LVK191TWGVu50zjP5zcg/o8vjQpCfDN8S9btledwHMg=; b=BiylJFlZ+NjNKj1x8vyNZ/29pzHx7mNpuvfoO/O8L3xlZuCHrLqwmBaNmbLmoxpPMCp91TfQOUHJT97Nv4bXbOZL/7fX1P/2AKoaMOPwuDXgyUZXym6iN4fnzBdiRPsYtbkAC7wFtwCQWbaJ7Z1hZJl7onvfnYRXH2vXuizhspM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Du20DoeOPqi3kaT8UzsB5UDfZShHAz45elGu1XQAsZ6Kzpglsz5Nik+R+Bjet5S0VwDl2g4bI5wkm7c5sa0fD3AqdYpY/Wm2VMLaXpP2hjOS/Jy+b0Dasvo8/3E3BjZlnVGxat3tlZvxDwVlVO0St2yxWIeNWC4pDNvwwYGGsNCnFjWKZOBDkk67NozqFdNX/VQMpofQY5r7QqKEhRAog9HBN41pznbrCJyDj3wYiL/zpRS2mKno9iRZIz23LFA5ntZlAp9w4iplRhu6xDEQGWEgYSJ62Q9u3Da/rQPjg3+cn7mXQn/z25stEVgVRNjvh+BS8E64oTwIVQa4AgJxkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LVK191TWGVu50zjP5zcg/o8vjQpCfDN8S9btledwHMg=; b=Wn7LtknKvssJbJq8ZQbTYoEN12GqDEU+KHVyQQaJQcrExW9sJp77wo49fvRR6AOKqLG1Q7jP5xUuwGg4Za5o6sRXDoJrQpd8ziAqd6ahStzDmyPPxS0Z1ymb/Ii6Yh5r/wdCQtaJ1YIFYoSUBoBiXrQEBiDWQH1KQwW1q2y5rfDLQYe8hZZayNOlvbI4J1vonyGz5GHYCCVuiw+e2CdnWAnyPNkh4MLlpIBRmXMQCi77P5nMw6uYx1GieVpJIToVFoVAu0vFhsxqbctncb2SpYGSTJx8Vq1heTArSpf++n8SqHP4hnM4iMVZD2NDN62eIersm8SG1VDSFGuipmzYfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LVK191TWGVu50zjP5zcg/o8vjQpCfDN8S9btledwHMg=; b=BiylJFlZ+NjNKj1x8vyNZ/29pzHx7mNpuvfoO/O8L3xlZuCHrLqwmBaNmbLmoxpPMCp91TfQOUHJT97Nv4bXbOZL/7fX1P/2AKoaMOPwuDXgyUZXym6iN4fnzBdiRPsYtbkAC7wFtwCQWbaJ7Z1hZJl7onvfnYRXH2vXuizhspM= From: Penny Zheng To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Wei Chen , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH v1 05/13] xen/arm: allocate shared memory from heap when host address not provided Thread-Topic: [PATCH v1 05/13] xen/arm: allocate shared memory from heap when host address not provided Thread-Index: AQHY+J1p2kGDrijhokmn3Ycm+ECYcK6UxoyAgAE5/KA= Date: Mon, 9 Jan 2023 07:50:13 +0000 Message-ID: References: <20221115025235.1378931-1-Penny.Zheng@arm.com> <20221115025235.1378931-6-Penny.Zheng@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 3B605AC35546304E89DBEC85BA01DC7D.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM0PR08MB4530:EE_|DBBPR08MB6297:EE_|AM7EUR03FT022:EE_|AS8PR08MB5926:EE_ X-MS-Office365-Filtering-Correlation-Id: 8fc0a4c0-92e4-4b1c-33ad-08daf2162c52 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: FRs+PTnF8EBW0OjHJ0bE6z+6fHSZ85EimSgMRSRX5gj6UNmL0mcUct9AAmoM9zqHcm11FsR6+nPsFlEb5ZaWXnbYHWPgmkzS/oBBHkXxxpFsQ9R9Btd6yPJOZG0hdxSPGa3NUULp2sW5BP+9Ms1u3rLjUHc0RAdBU+iyj0B4eZoeqySnRE1eei45ohqU4yq0KbJUsJde/m3U+sMBWHPkKKzbLkPVnnj/+SBQdM0L6Rk4XiHfWXHTGIgoFk3oxF9+FVaDqBFU8ebkst3t9II4cCOsve3aau+XDSkL83GN9cVNDjklYN0U2Hk2u1V7XscaT1ZGI7FldPFI41wDLgZRDDIgYf7H+o9VycqHLveB8SNKuy4vmnnPu4pJMURQbLG1u23ZhGdiT4Q9YB5FDAb/uUz076I2eQClCVNJc5zG69k3iCKV6dBxGmTkjq00HjJ16TLcFU0AHdbVvuZcHyPlk1cjSEd2O3G+I/e6NZXaMIy16OCKbClwV/vrUtjqLg/Ms+eK7YKMnlO15ogm7SiQfRsHT7Ja6bQYurPOmfKe01qAv4UtyIr935/f1iyv0QGZJfMvcLyrL1QBEPi76B5a58Seoa575no6gFtXfo3Ev/jjsPyG0wzmJEBYPmHOLE3JUeUVoLvVnFvR9yA0/1Lmke1brq7Pg0GOf6yUEeGg9U9Mb7slcCnW2AviUC9bOa6foJXdlWGfyLM61+QiA9vgxg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB4530.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(366004)(376002)(136003)(346002)(451199015)(33656002)(52536014)(41300700001)(83380400001)(64756008)(4326008)(76116006)(66946007)(66476007)(8676002)(38100700002)(66556008)(5660300002)(8936002)(66446008)(54906003)(110136005)(55016003)(9686003)(186003)(26005)(122000001)(7696005)(478600001)(38070700005)(53546011)(71200400001)(6506007)(86362001)(316002)(2906002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6297 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: f3fe3cac-3ef9-4e33-30c2-08daf216245e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KOFN0Qw2vGg7DUQBBjJurtTgPq5lUpo0qleKV/4MU+2UG+hHVvqNDWG5Q8U2SCNZ4qyeFaiMxMVJ6bDucctzFRn74MmSQp3mC2H8+YAShgz2e8GMr0OazNJ+oyOl44dX0tAcCFVHOPc2YUkOL+AtkDi1aBbLAcQ0EAITcDWjn2hriTaj/Jx1PKYMvyta31q+KmYHfddHugdHKQO5HXZ6f5CSNHbDcEdftAKsE8TF1pTIvhV/9NSiQIUxyRYpGLVo2h1F3Cux4/6vAPQWxqo+Vr0lBh8QfIejHxgXjrCADpHmL12iGjc49vn8EMBGb718HEUOSqd0vX71caJucB7PpKOrTRYXWa00kTjIaOFf/uJeI3rPh+N1rXX0v2LdIXQgnBsqKL2AtiXmGiwI56P3UBy29E23pshGQLSbNqgtlVlU5euRec5JhSxNBm2PHV9BQMy8jzqTJGGJuI/M0GNXtyK6TYKhq/v5m1Myr5GJydArEg4UI+zX08Cg6e6d/0Ct1Yc/9/LsMuh3dQSwHAqkLkUld2mC/b9IUdIDDuNjLBkNOw8fEOSmQhxLbk1jLz/AfRvdeYQge5y1cZ2ekRJLYfFVcajZHMeb+TT6OL+RhAYQGNQoomp7mvOSkMz/60LVfPscU6xbVFlGOLvXXOCm5ahtUQxYOCtMIpLU5F0DYNFfcSXltk2DMkcdlTg9rzo/X8b+8pxCedHI4K7yffZBMg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(346002)(376002)(136003)(451199015)(46966006)(40470700004)(36840700001)(33656002)(7696005)(2906002)(54906003)(110136005)(8676002)(70206006)(4326008)(316002)(70586007)(83380400001)(81166007)(82740400003)(47076005)(356005)(36860700001)(82310400005)(40460700003)(478600001)(9686003)(26005)(186003)(86362001)(40480700001)(55016003)(107886003)(6506007)(336012)(53546011)(8936002)(52536014)(5660300002)(41300700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2023 07:50:27.2508 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8fc0a4c0-92e4-4b1c-33ad-08daf2162c52 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB5926 PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBKdWxpZW4gR3JhbGwgPGp1bGll bkB4ZW4ub3JnPg0KPiBTZW50OiBTdW5kYXksIEphbnVhcnkgOCwgMjAyMyA4OjIzIFBNDQo+IFRv OiBQZW5ueSBaaGVuZyA8UGVubnkuWmhlbmdAYXJtLmNvbT47IHhlbi1kZXZlbEBsaXN0cy54ZW5w cm9qZWN0Lm9yZw0KPiBDYzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+OyBTdGVmYW5vIFN0 YWJlbGxpbmkNCj4gPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+OyBCZXJ0cmFuZCBNYXJxdWlzIDxC ZXJ0cmFuZC5NYXJxdWlzQGFybS5jb20+Ow0KPiBWb2xvZHlteXIgQmFiY2h1ayA8Vm9sb2R5bXly X0JhYmNodWtAZXBhbS5jb20+DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjEgMDUvMTNdIHhlbi9h cm06IGFsbG9jYXRlIHNoYXJlZCBtZW1vcnkgZnJvbSBoZWFwDQo+IHdoZW4gaG9zdCBhZGRyZXNz IG5vdCBwcm92aWRlZA0KPiANCj4gSGkgUGVubnksDQo+IA0KDQpIaSBKdWxpZW4sDQoNCj4gT24g MTUvMTEvMjAyMiAwMjo1MiwgUGVubnkgWmhlbmcgd3JvdGU6DQo+ID4gd2hlbiBob3N0IGFkZHJl c3MgaXMgbm90IHByb3ZpZGVkIGluICJ4ZW4sc2hhcmVkLW1lbSIsIHdlIGxldCBYZW4NCj4gPiBh bGxvY2F0ZSByZXF1ZXN0ZWQgc2hhcmVkIG1lbW9yeSBmcm9tIGhlYXAsIGFuZCBvbmNlIHRoZSBz aGFyZWQNCj4gbWVtb3J5DQo+ID4gaXMgYWxsb2NhdGVkLCBpdCB3aWxsIGJlIG1hcmtlZCBhcyBz dGF0aWMoUEdDX3N0YXRpYyksIHdoaWNoIG1lYW5zDQo+ID4gdGhhdCBpdCB3aWxsIGJlIHJlc2Vy dmVkIGFzIHN0YXRpYyBtZW1vcnksIGFuZCB3aWxsIG5vdCBnbyBiYWNrIHRvIGhlYXAgZXZlbg0K PiBvbiBmcmVlaW5nLg0KPiANCj4gUGxlYXNlIGRvbid0IG1vdmUgcGFnZXMgZnJvbSB0aGUge3hl bixkb219aGVhcCB0byB0aGUgc3RhdGljIGhlYXAuIElmIHlvdQ0KPiBuZWVkIHRvIGtlZXAgdGhl IHBhZ2VzIGZvciBsb25nZXIsIHRoZW4gZ2V0IGFuIGV4dHJhIHJlZmVyZW5jZSBzbyB0aGV5IHdp bGwNCj4gbm90IGJlIHJlbGVhc2VkLg0KPiANCj4gPg0KPiA+IFNpZ25lZC1vZmYtYnk6IFBlbm55 IFpoZW5nIDxwZW5ueS56aGVuZ0Bhcm0uY29tPg0KPiA+IC0tLQ0KPiA+ICAgeGVuL2FyY2gvYXJt L2RvbWFpbl9idWlsZC5jIHwgODMNCj4gKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrLQ0KPiA+ICAgMSBmaWxlIGNoYW5nZWQsIDgyIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24o LSkNCj4gPg0KPiA+ICtzdGF0aWMgaW50IF9faW5pdCBhbGxvY2F0ZV9zaGFyZWRfbWVtb3J5KHN0 cnVjdCBzaG1fbWVtYmFuaw0KPiAqc2htX21lbWJhbmssDQo+ID4gKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgcGFkZHJfdCBwc2l6ZSkgew0KPiA+ICsgICAgc3RydWN0 IG1lbWluZm8gKmJhbmtzOw0KPiA+ICsgICAgaW50IHJldDsNCj4gPiArDQo+ID4gKyAgICBCVUdf T04oc2htX21lbWJhbmstPm1lbS5iYW5rcy5tZW1pbmZvICE9IE5VTEwpOw0KPiA+ICsNCj4gPiAr ICAgIGJhbmtzID0geG1hbGxvY19ieXRlcyhzaXplb2Yoc3RydWN0IG1lbWluZm8pKTsNCj4gDQo+ IFdoZXJlIGlzIHRoaXMgZnJlZWQ/DQo+IA0KDQpUaGVzZSBraW5kcyBvZiBpbmZvIHdpbGwgYmUg b25seSB1c2VkIGluIGJvb3QtdGltZSwgc28gbWF5YmUgSSBzaGFsbCANCmZyZWUgdGhlbSBpbiBp bml0X2RvbmUoKT8NCk9yIGp1c3QgYWZ0ZXIgcHJvY2Vzc19zaG0oKSA/DQoNCj4gPiArICAgIGlm ICggYmFua3MgPT0gTlVMTCApDQo+ID4gKyAgICAgICAgcmV0dXJuIC1FTk9NRU07DQo+ID4gKyAg ICBzaG1fbWVtYmFuay0+bWVtLmJhbmtzLm1lbWluZm8gPSBiYW5rczsNCj4gPiArICAgIG1lbXNl dChzaG1fbWVtYmFuay0+bWVtLmJhbmtzLm1lbWluZm8sIDAsIHNpemVvZihzdHJ1Y3QNCj4gPiAr IG1lbWluZm8pKTsNCj4gPiArDQo+ID4gKyAgICBpZiAoICFhbGxvY2F0ZV9kb21oZWFwX21lbW9y eShOVUxMLCBwc2l6ZSwgc2htX21lbWJhbmstDQo+ID5tZW0uYmFua3MubWVtaW5mbykgKQ0KPiA+ ICsgICAgICAgIHJldHVybiAtRUlOVkFMOw0KPiA+ICsNCj4gPiArICAgIHJldCA9IG1hcmtfc2hh cmVkX21lbW9yeV9zdGF0aWMoc2htX21lbWJhbmspOw0KPiA+ICsgICAgaWYgKCByZXQgKQ0KPiA+ ICsgICAgICAgIHJldHVybiByZXQ7DQo+ID4gKw0KPiA+ICsgICAgcmV0dXJuIDA7DQo+ID4gK30N Cj4gPiArDQo+ID4gICBzdGF0aWMgbWZuX3QgX19pbml0IGFjcXVpcmVfc2hhcmVkX21lbW9yeV9i YW5rKHN0cnVjdCBkb21haW4gKmQsDQo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIHBhZGRyX3QgcGJhc2UsIHBhZGRyX3QgcHNpemUpDQo+ID4gICB7 DQo+ID4gQEAgLTk3NSw3ICsxMDQxLDcgQEAgc3RhdGljIGludCBfX2luaXQgcHJvY2Vzc19zaG0o c3RydWN0IGRvbWFpbiAqZCwNCj4gc3RydWN0IGtlcm5lbF9pbmZvICpraW5mbywNCj4gPiAgICAg ICAgICAgdW5zaWduZWQgaW50IGk7DQo+ID4gICAgICAgICAgIGNvbnN0IGNoYXIgKnJvbGVfc3Ry Ow0KPiA+ICAgICAgICAgICBjb25zdCBjaGFyICpzaG1faWQ7DQo+ID4gLSAgICAgICAgYm9vbCBv d25lcl9kb21faW8gPSB0cnVlOw0KPiA+ICsgICAgICAgIGJvb2wgb3duZXJfZG9tX2lvID0gdHJ1 ZSwgcGFkZHJfYXNzaWduZWQgPSB0cnVlOw0KPiA+ICAgICAgICAgICBzdHJ1Y3Qgc2htX21lbWJh bmsgKnNobV9tZW1iYW5rOw0KPiA+DQo+ID4gICAgICAgICAgIGlmICggIWR0X2RldmljZV9pc19j b21wYXRpYmxlKHNobV9ub2RlLA0KPiA+ICJ4ZW4sZG9tYWluLXNoYXJlZC1tZW1vcnktdjEiKSAp IEBAIC0xMDM1LDYgKzExMDEsMjEgQEAgc3RhdGljIGludA0KPiBfX2luaXQgcHJvY2Vzc19zaG0o c3RydWN0IGRvbWFpbiAqZCwgc3RydWN0IGtlcm5lbF9pbmZvICpraW5mbywNCj4gPiAgICAgICAg ICAgICAgIHJldHVybiAtRU5PRU5UOw0KPiA+ICAgICAgICAgICB9DQo+ID4NCj4gPiArICAgICAg ICAvKg0KPiA+ICsgICAgICAgICAqIFdoZW4gaG9zdCBhZGRyZXNzIGlzIG5vdCBwcm92aWRlZCBp biAieGVuLHNoYXJlZC1tZW0iLA0KPiA+ICsgICAgICAgICAqIHdlIGxldCBYZW4gYWxsb2NhdGUg cmVxdWVzdGVkIG1lbW9yeSBmcm9tIGhlYXAgYXQgZmlyc3QgZG9tYWluLg0KPiA+ICsgICAgICAg ICAqLw0KPiA+ICsgICAgICAgIGlmICggIXBhZGRyX2Fzc2lnbmVkICYmICFzaG1fbWVtYmFuay0+ bWVtLmJhbmtzLm1lbWluZm8gKQ0KPiA+ICsgICAgICAgIHsNCj4gPiArICAgICAgICAgICAgcmV0 ID0gYWxsb2NhdGVfc2hhcmVkX21lbW9yeShzaG1fbWVtYmFuaywgcHNpemUpOw0KPiA+ICsgICAg ICAgICAgICBpZiAoIHJldCApDQo+ID4gKyAgICAgICAgICAgIHsNCj4gPiArICAgICAgICAgICAg ICAgIHByaW50aygiJXBkOiBmYWlsZWQgdG8gYWxsb2NhdGUgc2hhcmVkIG1lbW9yeQ0KPiBiYW5r KCUiUFJJcGFkZHIiTUIpIGZyb20gaGVhcDogJWRcbiIsDQo+ID4gKyAgICAgICAgICAgICAgICAg ICAgICAgZCwgcHNpemUgPj4gMjAsIHJldCk7DQo+ID4gKyAgICAgICAgICAgICAgICByZXR1cm4g cmV0Ow0KPiA+ICsgICAgICAgICAgICB9DQo+ID4gKyAgICAgICAgfQ0KPiA+ICsNCj4gPiAgICAg ICAgICAgLyoNCj4gPiAgICAgICAgICAgICogRE9NSURfSU8gaXMgYSBmYWtlIGRvbWFpbiBhbmQg aXMgbm90IGRlc2NyaWJlZCBpbiB0aGUgRGV2aWNlLVRyZWUuDQo+ID4gICAgICAgICAgICAqIFRo ZXJlZm9yZSB3aGVuIHRoZSBvd25lciBvZiB0aGUgc2hhcmVkIHJlZ2lvbiBpcw0KPiA+IERPTUlE X0lPLCB3ZSB3aWxsDQo+IA0KPiBDaGVlcnMsDQo+IA0KPiAtLQ0KPiBKdWxpZW4gR3JhbGwNCg0K Q2hlZXJzLA0KDQotLQ0KUGVubnkgWmhlbmcNCg== From xen-devel-bounces@lists.xenproject.org Mon Jan 09 08:06:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 08:06:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473358.733898 (Exim 4.92) (envelope-from ) id 1pEnB7-0000vP-B4; Mon, 09 Jan 2023 08:06:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473358.733898; Mon, 09 Jan 2023 08:06:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEnB7-0000vI-82; Mon, 09 Jan 2023 08:06:45 +0000 Received: by outflank-mailman (input) for mailman id 473358; Mon, 09 Jan 2023 08:06:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEnB6-0000vC-Fa for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 08:06:44 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2061.outbound.protection.outlook.com [40.107.21.61]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8daac4b6-8ff4-11ed-91b6-6bf2151ebd3b; Mon, 09 Jan 2023 09:06:43 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VE1PR04MB7391.eurprd04.prod.outlook.com (2603:10a6:800:1b3::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Mon, 9 Jan 2023 08:06:41 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5986.018; Mon, 9 Jan 2023 08:06:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8daac4b6-8ff4-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Toj6OLK9+HcXevSZIphcQ+MOhw3bq+0nJgRois7oHE4CaVSHWthoD9hGtuRdkHhh5u6+v0mObArIWbnQM1W5cbZQFnzhMnOtogt5LPLwvq7b8XYZo11rqOE3/YyQcIG30dGw3oAVxb+K9GHkcshHA3jv4aWw1/q7S/MNaxJJeL6UZ2/p0dLXRR2is2QGiuc585QtuzODAYM4WPm3oy78T3CknFAQtqJug+Ro9QBMY4jIhTKRgqlTDZ5V3KAmgvSZYNcl9iRrfo1USTeWOR0+TbaQf5wSUVexRNkSgCeawXnHcpefTvcVm6drr7IrtQlpy7vnEC5GN3gX3QF97paHgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MTBO89uOjTyQTH7hk4wHEkjHNHDeznBX+XQQGm4IwBk=; b=GuRvzc4uS2yBxtIvr8VOPpO17rbgoIayKRnUqGi3NlCrJ0H6PdoW8vSVG7V9FCw0QTrnpEeQCwCiJrdzSw2cAI+jAtN5A2rxOw6BeX/KU++GeFakJ3S1qkfQVggnsN3+Ur8Tr17XD4gMgvYwyNVI42q10cuggoBS8bCnlhFOBchOK/r3aPX7qd+AM7SCITck6uYG13KPOIf2VI1oK6NhaGGBWB8ZUEDjQCYYXTTODitvzKn7gVViopPKDTzkxI686P8lS1VnXrod/sjg6YgzfNXSmAysUHxEi6Z2vNoPILNz+Fp1dkX3X4ZcyxGfsId4q9pwSg5NIrYxwiT5wVm+zQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MTBO89uOjTyQTH7hk4wHEkjHNHDeznBX+XQQGm4IwBk=; b=w3TiNdiEunxT/rscBj/dJ/71TBx3a9XB03AADii7/+4qE1Lt1x+anmQdV6cu+wdXQVzo6ObQ3lUrJxZ2aoOlTsBq/3QklSWcidb2B3WBcMsXnTRChY1XxGJ0J2l68XX9HASpQg94vlWG8RR3XsV/ZOhlEc+smnQsCTZY9iJpb+XDBW60gcNVl2HrdogSWWCAS3VBooZ1OZsVphPiSBAfdIgB0TGnnISByYKVNu2CHZrRxmVRhPeq+AdSbhsJh19xb/Syv2KTaLQsN1P0BNNKAOg4262044Lmj05J0ivq3W8V6dMOEIkoCNJ6stgLqmKzc3dH3DSkyHEQ4Z9HQOgSjw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <18366360-7bfd-0d27-fd32-e3064eaf9b7e@suse.com> Date: Mon, 9 Jan 2023 09:06:42 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 3/4] xen/version: Drop bogus return values for XENVER_platform_parameters Content-Language: en-US To: Andrew Cooper Cc: George Dunlap , Stefano Stabellini , Wei Liu , Julien Grall , Xen-devel References: <20230103200943.5801-1-andrew.cooper3@citrix.com> <20230103200943.5801-4-andrew.cooper3@citrix.com> <540a449d-f76d-eb16-4f98-c4fb3564ce98@suse.com> <7dd00ce3-a95b-2477-128c-de36e75c4a34@citrix.com> <9ce20298-5870-aa1b-ee5e-e16a623beadb@citrix.com> <5bb7382c-bed0-144c-2906-38bc08c76a52@citrix.com> From: Jan Beulich In-Reply-To: <5bb7382c-bed0-144c-2906-38bc08c76a52@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0046.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::23) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VE1PR04MB7391:EE_ X-MS-Office365-Filtering-Correlation-Id: ea05dff7-113d-4cb5-9694-08daf21870d8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mhnNTKH+pM4MX+DFjb4S2sal3p+xCKCWWODuJKgrHxZplxV99SF4/FWDP680dFgZ3LcFu6HvzOIGVuebIFkchKayJB+DD9lxWp+04gmSOy3j2b5CNpnkWCd7ByGcqlTTXny/33RE/Fo+c09NZSifWZDrUfUPek09U+w7fkIq8ysezP4DiEek1nbMms3mTscZlIT2w2NHp+Xm7yNrYT+0/HP1BKi3FLpS2w6yex3hX5zQAHrxXD6zAZ9miJagUPEPIVGWqxl4LFWhu8jWUyx19FujBnfXwhUdUyqQlU7SQQ1FBj5Y9TPDfZvKigwwM5EHuIYwksoz6/Cb9hiWQxLfJ4hxv/TYsekUWn+vT+F06UYqJhDrgYUWDR1hqUlaypb4DSvMZZxnLPwhMDJ1iqwFNzmAGzcQ5+f1VI2WaTZtX6rcEgocnhK/E+00Y7/jc/zfC/J1XaDA/v74TVKxze48jAopZObhRvEPAswMk9+YMt3X19x/K+IoN8tWvUHz22CNHy97vMI6BvjLGjVrC4jP0w/9oaKR0WNsyjcaznr8j5I9C9RlymNxsvVdkhAywTg60IG8DLEwsf4/yInhlwXzlw9L3q89Qtsq5g0xPvhGQlnpmabzTTHOQFMfga3H7pK6uZ8TrFxV3xG2MnSV+ucvgyDvSg5+7mr1w8EgiGZHGQ1tPfm3EfUhGqROD71TTobNzvX7TC+7K5HF/mRg3GPMWku1z+t/sAa7xCFxQNKBLOE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(366004)(136003)(346002)(39850400004)(376002)(451199015)(5660300002)(316002)(26005)(6512007)(186003)(6486002)(478600001)(2616005)(31696002)(41300700001)(8676002)(54906003)(66946007)(4326008)(66476007)(6916009)(66556008)(8936002)(36756003)(86362001)(53546011)(31686004)(6506007)(38100700002)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZE5oVXFTYW1mVXhoK1ZVYzZvR1lCRWRPbTcwQWRGdDBtYWl1b0J2S05aWDdU?= =?utf-8?B?TW1FN2I4Qkpmd3lDYWVIVUcyNGJ2VlNrRm5rVnRWUTlWWVArSVh2K0llczQy?= =?utf-8?B?ZVgvVDFqQXlWelp4UHo0SmcwUWtxYU1BUENwSVBkRFNObjYrcytDWGVUZnZv?= =?utf-8?B?VklxandVelhUa1JIbnVUcUNJRGVnb3c4QmY5Snp6Tnh5VzhXRG5HQmlmOXFG?= =?utf-8?B?UXZTOFV4WTZHcUFHNmRRdDRvdkFSZmlCTk5FS1ltNGtnUlFYell4eEZxUkJ4?= =?utf-8?B?WnVydDB0VGFsRjZia28rMERDQVVidWJlV0RIWWc3dWhrQjhCQjgzcjhkSUZC?= =?utf-8?B?S2dDVWpBNjhRVlRpakd1OUtuYzdOd1FpOEZBdmhvNXA0ajJ3NXVzMXphRGVG?= =?utf-8?B?U2pGVCtrajlnNDhmSmxQTkh6TlppYUFLZU5wd05SWmRYZ1dzYnNoQzR1NHdN?= =?utf-8?B?SnpiVzJQRnZ4MEZ6THlISHAxVHJONHQ3RnFOQTVIRGl1UzNOalFpazBFaXZs?= =?utf-8?B?bWZYa084bU1teHVCeXpvMHVmajBuZmZjNlFtMmZlNUgwWUQrM2xDYmlodHN4?= =?utf-8?B?Vlh0dWxzMkRIeHhDdHk4OXErSVZ4VDJwSFdwVEdVb0h3SFlQalBua1I3RjZW?= =?utf-8?B?RDgwcWpPQlhWRVpTYXZLYW1weTBKdXJnZkZJYU5qVkZuVngzbmxBQmwxZWhO?= =?utf-8?B?YU1CZWgzNzc1bTdvTzczbzdUMjFkbE1jTjNiMGpwQUpzeFVHaTZmYVJJS2NL?= =?utf-8?B?ZTBYdEt3YS9RUjB5UXZuVTB6dklNM2tSa3lUWDFHTWtCcjEvM1l4eGlWVmty?= =?utf-8?B?MnNIMW43a3dRTm0rRzl6UnZOQit5emlaRTl6RTdoZFBZRVVmcnVMY3dDenZC?= =?utf-8?B?Z2ZQdHFOK0NnbkdERE5nWVFDUncrU0lxa1BLZGRZWmZrcFhsZCtZeFA1SDFH?= =?utf-8?B?elZ4a3k2SWExWjhWU0JEM3pCaHhqUGg0ZmtMWmlCWCt2aEFiQ2RMek81ajFV?= =?utf-8?B?OWlXSE1vVkI3SjRUM0tBZTdBTnYwUFpLa0g5L3c4bVF5aEVZWncwTTN2OU8z?= =?utf-8?B?bDFKaG9WSFZkYXVOM1Ezc2U2UzMxNllZVmxvaDJPd3lxUEZ0OFhzTTlXZnpi?= =?utf-8?B?b0JBOXh0YXBVeW5Hekt3NXNHd1FwNU11eHhjczJqSk9FcFJwRkFRRmlnQzVl?= =?utf-8?B?S0FucmFyRjZFcWNJYURWZXl3VElvRlhTTG1JTW13WjZ1WnJjM1RmUHRpdG1G?= =?utf-8?B?ck0wTHNYSFlHbDZsN2kyc2prTzlXd3FDRzZJelpRUm4rRnRncU9yQ0NMYkRZ?= =?utf-8?B?WnlDSFVLSFJNOW5TRExzaVlTd3ZKSnFqOU10R1pnREVMcXlTcG1uUWFpN2NC?= =?utf-8?B?R05QQlJLMkVVYjdNQnlTRmxQUXhXcUU5bXZWbU5TQVUzRXEvYjBTdUxva3ha?= =?utf-8?B?LzlyS0FpUDFWYTNPdnVEbmxmMlR1amJTN2FyZlI1cmVaQTJkYjdxczZHdlow?= =?utf-8?B?T1B0UXU3aG1aY1lDVmwvSTI0VTcrMnJQV0V0emNWQnpFTEZrbjN5ZTlJa2Zw?= =?utf-8?B?UUhYb20xNUozZEZld3FJdVJOY1c3YWVoN2tsaENUc3JRdTczVzBjT0xyM0hz?= =?utf-8?B?cTBqTjJBTmtjRzlWd29RMTBBVTRHMUxkQzV4QUN4ZEdtbElDYjAvL2xteitz?= =?utf-8?B?aXVERW5GVWFGWGxoU3F4bk81SGFERHRqQUhhMFoxd2tlWG5pNkNLQ1B6L2RI?= =?utf-8?B?blZFM0lzZHZVOUJKMGx6S2hxajAxL0dVOW0rWmtWdncvY1NEeFJjOVNmYWlN?= =?utf-8?B?UjMxai9NdU9yR0lrby9ZRFd3ZDhDejlXRjdrZ001ZW1qQ05oQ0p1OGs5T0p3?= =?utf-8?B?d1FFeGtKT011MERXb2lMdGFJTW9PaU5nRmhEQmgyaG94cFBJUDNXbjEvMDIv?= =?utf-8?B?TlZqM2MzYm1POFNhcFNoRk51blJOQndXdmsxaWQzMStJdzJLMmFNeEVXZm9z?= =?utf-8?B?cGVJR3NNc3IzZ3hLUjdET1VYSXJrWHZBNTJ5eWNjMjJleUJjYXdmeEdQNjA3?= =?utf-8?B?am1kb0I2MFU1Y0hoajZmRTNHSi9hUzVrYmZqRkZycjNvT3JudkFnb3V4VzFZ?= =?utf-8?Q?WzVI4oEjl4plgQ/Sxs5Mtde40?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ea05dff7-113d-4cb5-9694-08daf21870d8 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2023 08:06:41.4600 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: maF30kX1GGKAf5TH3ix7noGSxLd94A2ukB/M/WLnle2g+OHyOEpOBUN/Kio1IwyTJAwORIhE/iPdxDRU4KHbUg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7391 On 06.01.2023 13:14, Andrew Cooper wrote: > On 06/01/2023 7:54 am, Jan Beulich wrote: >> On 05.01.2023 23:17, Andrew Cooper wrote: >>> On 05/01/2023 7:57 am, Jan Beulich wrote: >>>> On 04.01.2023 20:55, Andrew Cooper wrote: >>>>> On 04/01/2023 4:40 pm, Jan Beulich wrote: >>>>>> On 03.01.2023 21:09, Andrew Cooper wrote: >>>>>>> + * For all guest types using hardware virt extentions, Xen is not mapped into >>>>>>> + * the guest kernel virtual address space. This now return 0, where it >>>>>>> + * previously returned unrelated data. >>>>>>> + */ >>>>>>> #define XENVER_platform_parameters 5 >>>>>>> struct xen_platform_parameters { >>>>>>> xen_ulong_t virt_start; >>>>>> ... the field name tells me that all that is being conveyed is the virtual >>>>>> address of where the hypervisor area starts. >>>>> IMO, it doesn't matter what the name of the field is.  It dates from the >>>>> days when 32bit PV was the only type of guest. >>>>> >>>>> 32bit PV guests really do have a variable split, so the guest kernel >>>>> really does need to get this value from Xen. >>>>> >>>>> The split for 64bit PV guests is compile-time constant, hence why 64bit >>>>> PV kernels don't care. >>>> ... once we get to run Xen in 5-level mode, 4-level PV guests could also >>>> gain a variable split: Like for 32-bit guests now, only the r/o M2P would >>>> need to live in that area, and this may well occupy less than the full >>>> range presently reserved for the hypervisor. >>> ... you can't do this, because it only works for guests which have >>> chosen to find the M2P using XENMEM_machphys_mapping (e.g. Linux), and >>> doesn't for e.g. MiniOS which does: >>> >>> #define machine_to_phys_mapping ((unsigned long *)HYPERVISOR_VIRT_START) >> Hmm, looks like a misunderstanding? I certainly wasn't thinking about >> making the start of that region variable, but rather the end (i.e. not >> exactly like for 32-bit compat). > > But for what purpose?  You can't make 4-level guests have a variable range. That entirely depends on the kernel. Linux, for example, could put its direct map lower, ... > The best you can do is make a 5-level-aware guest running on 4-level Xen > have some new semantics, but a 4-level PV guest already owns the > overwhelming majority of virtual address space, so being able to hand > back a few extra TB is not interesting.  And for making that happen... ... allowing it to cover some more space. That's not a whole lot more, sure. >>>>> For compat HVM, it happens to pick up the -1 from: >>>>> >>>>> #ifdef CONFIG_PV32 >>>>>     HYPERVISOR_COMPAT_VIRT_START(d) = >>>>>         is_pv_domain(d) ? __HYPERVISOR_COMPAT_VIRT_START : ~0u; >>>>> #endif >>>>> >>>>> in arch_domain_create(), whereas for non-compat HVM, it gets a number in >>>>> an address space it has no connection to in the slightest.  ARM guests >>>>> end up getting XEN_VIRT_START (== 2M) handed back, but this absolutely >>>>> an internal detail that guests have no business knowing. >>>> Well, okay, this looks to be good enough an argument to make the adjustment >>>> you propose for !PV guests. >>> Right, HVM (on all architectures) is very cut and dry. >>> >>> But it feels wrong to not address the PV64 issue at the same time >>> because it is similar level of broken, despite there being (in theory) a >>> legitimate need for a PV guest kernel to know it. >> To me it feels wrong to address the 64-bit PV issue by removing information, >> when - as you also say - it is actually _missing_ information. To me the >> proper course of action would be to expose the upper bound as well (such >> that, down the road, it could become dynamic). There's also no info leak >> there, as the two (static) bounds are part of the PV ABI anyway. > > ... the absolute best you could do here is introduce a new > XENVER_platform_parameters2 that has a different structure. Indeed. > Which still leaves us with XENVER_platform_parameters providing data > which is somewhere between useless and actively unhelpful. If it's useless, there's still no reason to remove / alter the information, as you can never be absolutely certain that no-one uses this in some way. And for the "actively unhelpful" aspect it looks like our views simply differ. Is there no way we can settle on making the change affect HVM only? Jan From xen-devel-bounces@lists.xenproject.org Mon Jan 09 08:35:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 08:35:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473364.733908 (Exim 4.92) (envelope-from ) id 1pEndA-0004Dq-Ii; Mon, 09 Jan 2023 08:35:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473364.733908; Mon, 09 Jan 2023 08:35:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEndA-0004Dj-G1; Mon, 09 Jan 2023 08:35:44 +0000 Received: by outflank-mailman (input) for mailman id 473364; Mon, 09 Jan 2023 08:35:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEnd9-0004Dd-RW for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 08:35:43 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2072.outbound.protection.outlook.com [40.107.247.72]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9a5b8adc-8ff8-11ed-91b6-6bf2151ebd3b; Mon, 09 Jan 2023 09:35:42 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM7PR04MB7093.eurprd04.prod.outlook.com (2603:10a6:20b:11d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Mon, 9 Jan 2023 08:35:41 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5986.018; Mon, 9 Jan 2023 08:35:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9a5b8adc-8ff8-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XKzkWlUEBDcGqylYuWi/2iZl0ad3xGYBVOo2l62UWVFAiP1jTWP2FRv1b1m+1CcW2EbkdEUflZY/VQf7GizW3UIxD7VKedWUvcJvTwkuR8H7I0ZrauD4Qzpuw4M9Vzmz/U0GczMSKn5t0ikVcvyHQ8AQuUIHLWXbirCY6I8vwCWFNtRGxcYAgQkkZ8cfdAqWE8t/0YksClSFls5cTfY/1CX0RVkm52rgDJ8sErvr6yb5Fl0JtvZQdgx+a3fVAAMPuDPDTD9hAmogevz3FXWE+5zTD7Ih4aCIErdhbtUtXc5kX7ANJw6rrW+JsgHNUmfkSbX+vTx5jlEdANTTjnGI7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xcNPlZgRTW3qxOdChmYcm+u8tTQMcr/GLd+WO/WmLE4=; b=RGvVYL38Gylr4KLhV3ztUWtSPI0J98WiR8IIDP480w1gni/dcTyqxq09XrG+ZkntCv8q39KlcLpjGzHUsxIXgybD3FYg/lU1Fw7XfyMR91E55UTBxjphCMhlPoKDTympWNDapfTiApzA7fuKPeb5afcLRHv4sAABSiFWwTm55RfNHj67ObSCOhBV/EZ8pAlJiNj/bAerpX2XGCxWV0PEBvuy3YeF/rVYS/gRHdHLZwy1oyyUpxrS/MiA0XO50AmyS/Vq1A98lKe7tsdujNDPiMb2KUqbhJ3GcQ2Tq/4owT1rL/CTk+lD8dzh4HWFdJri6tPuAUk5xa/PRrlylpdieA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xcNPlZgRTW3qxOdChmYcm+u8tTQMcr/GLd+WO/WmLE4=; b=OGdka1zdhgF47qMwR7HmfcvrDipyzkXWtI5/X4bpQOzlIuIR4/P18rksJyi/ZmN3JABVoaEYFWquFxhp6TH5jpRTFgwKN69+X6LgbQWJZnUBwutdis3UfC+wPP7YR1mKVwW3scXQ4m7A/A7xedWkXP8OePSsqRzoxsrrfA9+lPo6M4XM0AnT5ePD/CRbn/e/cOig1r4GOnUSKvSMoznUOyFL4+XJE+TnTiSLA8TIvnbadb8v6t2KOykUzXG3ZWFD2Iw8PDDqcN9Uv6frp7A6fxF2O8hK6iZuXX8vkV8OYmjJm1yGkcvdN68IE7yBJnPGWJ4D6DuC0VwngWVbYCYsag== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <694bdf12-ab8f-9896-30b3-3b2d7bc3d892@suse.com> Date: Mon, 9 Jan 2023 09:35:42 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 01/11] x86/shadow: replace sh_reset_l3_up_pointers() Content-Language: en-US To: Andrew Cooper Cc: Wei Liu , Roger Pau Monne , "Tim (Xen.org)" , George Dunlap , "xen-devel@lists.xenproject.org" References: <074dc3bb-6057-4f61-d516-d0fe3551165c@suse.com> <03ae5a1a-4417-0aa0-27d8-833ade20cc0b@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0056.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:93::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM7PR04MB7093:EE_ X-MS-Office365-Filtering-Correlation-Id: 18e48e0b-6108-4028-1a5a-08daf21c7dca X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: l5r7Fh+Z2N16tMShuJ6ZY2BZCLnnU64v0LfSa4iHDGg52SOOtTBNIcjQiNJ9r8ITG2svKxDtt7XwA2jdiJVzgeGtkgDeAiDltKLibDgmpl9kjztXx1K7ylln8NZ5YhDIoy02iWu9ennjapLhP6Ff0aeeyylmC+/MlFGjwjjWRXQrDf5ZKDv3NGZ/24JaGG69XakTLzVYjvZP+MBKm5VTr9rfXo0/4gkPUm8gDmF5T54VEfLa00CaHNpO62QLIyKb/zGLDjflo/AUOJJ7LVRQZVFzEcr4uy5k76QBy7xp1Myt1p7qmjklgFwEIivLna4ekvgpTHRtx6x9Klaa1xHXvSRtCpeEl0f071FLWKeZMYrFUUm7FlxQJo8jr3UHFgXBjux02pSlmwA/MWQ/CzWPblaRVJviSSE9vAlJOsQnmm2Otds1Mg2HvN0yFeTXs17mBvp+XwZC7F8TgOCSr0I+Tn6aCUEsGL+nBbXFjdARpBdfPUZdWuk4w1iJ2hNjgh0QrhY3oH1Uz/dLO35lbEIAwHvo5qcMwhJ+qqxG5wMiZ8BB/6e6y136SprHtuSHoRsdbHRm74SApVTQBRYX/2MsI8lxSd/24KBLoDAXF8IzhtSmo1K/k6c8vUv1JepvJce4cwPSK06O497m6Kvkb+x3rQXK7PUaB7fZQHGj3/4qItcSP+LMpNhbCZ2KHXwST0bsjWRMLXb4WKMtxfZ2elRrtEANktlFm4k3T49+wSv03Oc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(136003)(376002)(346002)(396003)(39850400004)(451199015)(8936002)(2906002)(5660300002)(41300700001)(66556008)(66476007)(4326008)(6916009)(8676002)(316002)(66946007)(54906003)(186003)(26005)(6512007)(2616005)(38100700002)(31686004)(31696002)(83380400001)(86362001)(36756003)(6506007)(478600001)(6486002)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dkpEVEJ2N2g1WUlFWHh5Uy9PeThXUnFiRCtrZnI0ZnJpYVhJWDNuS1NCWk0r?= =?utf-8?B?MVdtRW14Q09lODBIOTlNVEVrOEtURkhWWXY4NGhNTUR1UjZUSGFSWlpEaVV2?= =?utf-8?B?U0RlYjdjQ29JZnJiVkdmblZScElxUGFvK0d2VUx3Rk8wYitmTzhPT2VIUTZ6?= =?utf-8?B?VEY5Ty9aZ0RzNVJUQmVVRkZFNDJTYnRHSGxqekI5Z1M2RVJGR3RGTVB0VE9V?= =?utf-8?B?OW1YQzRMZ0FTaUhoempWR2NLSUZxYlBRaUp5bmVpWW5STTloeE1kMlo1b3gv?= =?utf-8?B?TkFtak1jbEZoS3FsNmQxMEFnbFZ5V3cxL2Fxc0U2NkYvRE5MQlY0aEtKZkNP?= =?utf-8?B?bXZPaWxadGlhNkhONmpuSzFpVkM3Z0lrREVtWE01NXc4RmgxNWRUamFHOWhV?= =?utf-8?B?dzlCdXd6UW9rTzk4K0x5TDBibDVuT2F1Ym9wQzVZRHFFRjdxUWE3aGpJM0xM?= =?utf-8?B?Yk03QjU5NXkvYUFSR0c2Zm1pT0pmRWV4eVVRYmNsQWhiRHI5dVBGcjFkWHNO?= =?utf-8?B?aGpBQldKS1RQTy9qV1RvTWZpdjkvRmhQS3Zxb1RkOUd6VVdrRFV3N0hsZ3JF?= =?utf-8?B?Lzhhd2lER3RIcG1MTTdqM3V4ZEVoT1RpTTJWWFJiZnRoU1BtOXZKRDhTa1NZ?= =?utf-8?B?bVNSTWx4eFd2MnN6NEpTMnhycTlUNS9iWml2bDFqaEZLL1Fydmh5M2hScUR2?= =?utf-8?B?cE1VSU04MkhHS1NQZTJGVmhCcXhZRFlSTUZhY09kd1JNNU5JTEROZUxqMXBm?= =?utf-8?B?aHpqQjJQOXRKdTQ0bklyWGtKZjNoN040VnpFaURXYjVFWTBZZmhyd2FyUWpI?= =?utf-8?B?Q2d5cVB6S0x0Ulc4eGlXajR6cnNnMmdjZlJpaHc2bUF4OTBuN0RjQ2NHbmlS?= =?utf-8?B?OGticFRmbUdTalljUVNHN1pOcTgrZ1lhU1ZnM2l0MUF3NVhySG1sTURYTEF5?= =?utf-8?B?cFhTQXpWWkdYc0NMNDBxQTQ2QVVwN2JyS1AxZUJzWTZMVnRoblhXNzlyVWZQ?= =?utf-8?B?VVljS0FBSmUzSnd5VVVuZ05DVzBvQk5ZdWpmUWFvODlNWGV0Y2ZhcFUxZ2NL?= =?utf-8?B?SVB1Z2dvREZhaGtRWmg1NkpEVkxFRzNmbjIvdWJ5SUNKY2JlUTkzbVpwQmVk?= =?utf-8?B?Y21tZno0eTEvL0lBdFp2c1dlTnNaTzc1Vndwcy9rdmVwTVVNbUtFMzAvV3V1?= =?utf-8?B?Q2FuKzNLVEdNZ1U1ZHh3MDQ0QmpLUU11YlhVT3FpVDNKcG5tQWhhbTZPZ01j?= =?utf-8?B?MFNGMnFDMHVDbENOYkJ3dzFzdEk0ZkdUL1FidU80Sm91SFZPL1FzOE12RURC?= =?utf-8?B?NEZvcHdtWGNjMCt0WWUrTnQvV0pRaDZFdXM0b1JWTGpxVGJ6SDd2alNTblRV?= =?utf-8?B?RnY1cUpMNXJFVUF6d1AzR3hoYWcyR0lFZDAxZzN1c3FKNU11cUhVZlhaT1ZW?= =?utf-8?B?ejBiTHkvSkdMOVdBbmF6VEVSeHNOL1kvMURRRE9FNENzUHFNNGdPNklFR1RF?= =?utf-8?B?cUdCcUdaQjVseXFaWUtsOThrT3BMODV3NXVMSkJqVk5NNjZldUk4NWFFT21a?= =?utf-8?B?RXh4MTY1VUhtcU8vT0FqMmtwY0FhMVpocDY0ZVNETUZJemp5eXNvWUhyUEYr?= =?utf-8?B?anFZYlZ4MFJaOWdtTkxsN2lrMGxUeTAxOEY3Nit3cVVXZ3BYUlVhZi9uNzhZ?= =?utf-8?B?UjFrZklId1lhVC8yditiNS9RWXN1elRFSVlBa3l0UWNuU0IyaUU1VlVHR3hN?= =?utf-8?B?YlR5MnRoTUZkUWxrcGpYUlJRYm5VWnRmWUQxYS9RbjZ2Qlpma3doMHlibmFH?= =?utf-8?B?ZWxHa1JNajlNbUlZV0poZFZuS25memd0c2F4VFZGSGZpTFRvWW9RRURwVVZK?= =?utf-8?B?K0tyR0NVREdnczJNcngwVVFkWkl4UldzdFpFenZ2blJFeW9GTlgrVWhtWWhW?= =?utf-8?B?bmJFczNpNFhSVUNibVFLejVMdnlCZmdoY045YjZGR2c1dk42dDBWRXlTcVRN?= =?utf-8?B?RkxjMUdVWkwvaVZTTEJONmhUZjJmMldyRGVnVkVLT1M5UXl3R1J3MFIvai9B?= =?utf-8?B?SkNucmRYK0Jmc1JhTTdadGlEVjBkWEx3cHkwbm9nRUJIY0EycXhLNEw1Y3Rn?= =?utf-8?Q?pw3VqbaMl36YV85u8t2WtKIoa?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 18e48e0b-6108-4028-1a5a-08daf21c7dca X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2023 08:35:41.0999 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yV4JwE7l3dsEB8w6YWaHS5iquKftg+WFLYxvsv3hRKE+Hpt6YKKWQxAzx4o4cjVLhOePV/ecbj/2TKlecIwJ2A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7093 On 06.01.2023 01:55, Andrew Cooper wrote: > On 05/01/2023 3:59 pm, Jan Beulich wrote: >> Rather than doing a separate hash walk (and then even using the vCPU >> variant, which is to go away), do the up-pointer-clearing right in >> sh_unpin(), as an alternative to the (now further limited) enlisting on >> a "free floating" list fragment. This utilizes the fact that such list >> fragments are traversed only for multi-page shadows (in shadow_free()). >> Furthermore sh_terminate_list() is a safe guard only anyway, which isn't >> in use in the common case (it actually does anything only for BIGMEM >> configurations). >> >> Signed-off-by: Jan Beulich > > Acked-by: Andrew Cooper Thanks. > I think.  The reasoning seems plausible, but it would probably benefit > from someone else double checking. Okay, I'll wait some to see whether Tim or George may voice a view. Perhaps until the end of this week, committing early next week if no contrary indications appear. The "good" thing here is that all modern 64-bit guests undergo this transition aiui, so the code is / will be properly exercised. Jan From xen-devel-bounces@lists.xenproject.org Mon Jan 09 08:39:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 08:39:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473370.733919 (Exim 4.92) (envelope-from ) id 1pEnhF-0004p1-30; Mon, 09 Jan 2023 08:39:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473370.733919; Mon, 09 Jan 2023 08:39:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEnhF-0004ou-0N; Mon, 09 Jan 2023 08:39:57 +0000 Received: by outflank-mailman (input) for mailman id 473370; Mon, 09 Jan 2023 08:39:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEnhD-0004oo-To for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 08:39:55 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2087.outbound.protection.outlook.com [40.107.249.87]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 30c48fcb-8ff9-11ed-91b6-6bf2151ebd3b; Mon, 09 Jan 2023 09:39:55 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM7PR04MB7093.eurprd04.prod.outlook.com (2603:10a6:20b:11d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Mon, 9 Jan 2023 08:39:53 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5986.018; Mon, 9 Jan 2023 08:39:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 30c48fcb-8ff9-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OFssc1o728s/XI9pI/909eCPUbOjqfhLyRNGxBl9NEDRVlnu9TFc0rXgHeAv7P82t6u5lf0qfbwFPZrvng87iNHTXzkasl+p4Akag2J5V2ahLzKuQ2ZkeFSjvk/TTzIsnQJZ4/suR4lqHM0fLueP6JlMmZQmEt2f9tdp3kycDMPtf6lhUNeN7Sw4DG6Q5PXxR98thKIQYKW9UYJ7m0Bwqv7sNE/QcbvwEWIhzymr1jmtARs9Q3Gwuliz91O6ycigX3CPwVbVRG4NRVWkrYLgifqFrOy6Cx6d4HWGwmmivpP9bpfEO8sAx0KE8urPnJnKJcW72wAO+hnXsXnCxCUrFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O/vQoGlSzAJMqyZU02m9lIFhjHp/l09qgQro552DAa8=; b=ir2WkemBCq/kbWjgkvntvhYJGrNxIhNKt+qMmwXJQ/RZVuedNiYtFUUbxa+9IDDrKBgbJSZ3y508nBhL/RD+h7/3KPo9dyZveG0JqvazRxC6ks1ZW2PceT1aeDi6BKtjYMx/nFcSQYUMYtzZypF51F8s3KIekbmGOVnyxViyS5/FGbuG6kT8BNcZIjdUOZthXttdulhho1lzeJN1SP3LB4Mi8J0zK6K7dHpUIz8zXdvVmPJoR31xJRaAmn5ZQWBODVhlWgU1uEEVtdtntmqG5hKK1dyeQPeecwg87Vwak/C+5yiyHd/IdYvqB3y8EcuLdOiWuFYiJ1pdWizuqQ6p5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O/vQoGlSzAJMqyZU02m9lIFhjHp/l09qgQro552DAa8=; b=cbIyJCZqIDZ6H+JIDe9IiisFEG8GXbYwuwTmg5zprbMt5OO5hCiN9gDsb+naVuBEjkiqDAa/9zU7nSAqE6cYwjFcIZ3o9EJQbVOYeybwgYJU/3EZA9jsDKLLVEoT0S1VL9RT3/Q4G6uePDNxN0EcCuzJDkbf15mVbczsrAzQQxPHh2c2qqEabSfnzaKWAJ+o44WownImk68Loy5bMAOnTiPtiRiZCLnGNrWQkooW4TFsLlWWRiHaNq3TccuYYu8ixLllOqhHIBgBRkn9Lppnk4mzLmcbV93555qqpwBin7HlKhvyqy8hzAlYmVuLAucSM6IKKatNwxOCrBKeXCkwLQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <0a5da887-d1f5-5a50-306c-d60be95ccca4@suse.com> Date: Mon, 9 Jan 2023 09:39:53 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 05/11] x86/shadow: move bogus HVM checks in sh_pagetable_dying() Content-Language: en-US To: Andrew Cooper Cc: Wei Liu , Roger Pau Monne , "Tim (Xen.org)" , George Dunlap , "xen-devel@lists.xenproject.org" References: <074dc3bb-6057-4f61-d516-d0fe3551165c@suse.com> <76cc0b4a-27ca-21b7-841f-315f31833762@suse.com> <37bfe65b-d989-7c34-5e14-171a23df37f8@citrix.com> From: Jan Beulich In-Reply-To: <37bfe65b-d989-7c34-5e14-171a23df37f8@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0002.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM7PR04MB7093:EE_ X-MS-Office365-Filtering-Correlation-Id: 806feb09-f4c0-4ab6-4aa6-08daf21d13f2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: US750JBcwczqFONrfAtt1BfJJUj/2Cl4IIKiG3gRF9lyCbOe4LBCfMKSdwDdUA3JFawfclELYqoTDn/tNoQbVSIAWIubqbi98Xvl59cptAKL7fukE8tIoIn0uwkc/cyAgpvCGS77iEj02GOnJFnjd8HB0T6uZmS504OMxyzxvFi+OHgFBWr5SYdM9CL/RMaKfO+BMcYB5AbHGGXTjkxyzhBcdHWyv5JkDiXLJxirlJCdycvSd7fXrNurAWHQnbEKyw+KMz1OyTXb316RQRm8eFtYAAm6YhVpRCyRG7Gw6bN/ttbR8VYjILkq13Ykswn8+7aTRXB20O90JhKVJn+8PLyoGEm/G8TfQvf5oQnhhpbhkh3BHrN+0v7+ofHmn6/5sjfoMW5V9ZkboCBCGYGdZo5obyR0omLSJBycphN4riOSALensd9e5k2kzppGB9HY2rD6RRzAexYmhwTLWZ+aEWMeilqN8M70qFcSEBXsIqLeL4hWxvoDrtyeW19g01ghLpqMRdLuoAmbTKMEfh7TypuunRAJy7mRukl95fqysEcb5PKeFQ1VNtknXOjOaawXcUmdCIeDry6/mSOMS1knVv4b3JqBm2uBkYrPVOFgXuTwJEZdWCNJcllAukb6ySm+SFJhnT3v5QW2TcuvEKkMtCTQLY/VVHubsxYD+4AZj+mV4Dc95dBH1Pg0+DnBPIs4x3pRrCgtQMDE8Dn+giFYlbLFXpVO6ibCXss+IVrm0IY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39850400004)(346002)(376002)(136003)(366004)(396003)(451199015)(8676002)(4326008)(6916009)(316002)(66946007)(66476007)(66556008)(54906003)(4744005)(2906002)(5660300002)(8936002)(41300700001)(86362001)(36756003)(31696002)(83380400001)(53546011)(6506007)(6486002)(478600001)(38100700002)(2616005)(186003)(26005)(6512007)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cVh6T2REZTBCeStwdUp3TjlUYzh6RStWMU9Hck5pQXJSNVZ2enp0N2QxNUtw?= =?utf-8?B?WVh0WUpYTW1YUk9OZDRINmNFL2I2Q3JPZ2o1amFaWDFKUmg3b05EWWVDQUFJ?= =?utf-8?B?ejVERlArV2tkaGNUM1FkdHozKytHUEFRNjFmRHNHYnhJYkxOUzBvemc4dzV5?= =?utf-8?B?bGtKTkR1SGU5YnRsQXFCYStIVWEwemRqeEptNzZHU1lZeVh0RTVVUUFwK1Yz?= =?utf-8?B?VXdHSjlUQTJBeUViNFhTTzZRekNiRm02T2NuQUtuUEpsRGFGOUhlZkdiS0Vj?= =?utf-8?B?azc1Z21DcUtpSWJNQlhwcHZDSm44WUZBZ0FsS0pheUtEMnJYb0Z2RHA4djIy?= =?utf-8?B?TUVreHZoR3luRkt4bTFvNDRZMXhNYkdhWFhOc2g5amFhS25xMWFyQ1Bacmdp?= =?utf-8?B?Y1Fiend3Skw4T0RDbVArNkxSUFh1ai8wUFRzQnJsTXZtelVtTU11Y0MyOVdN?= =?utf-8?B?RXQrWlJPSkZQdURCQi9ONjE4RVRnQUNSK1NhdHdQZlFUZUIyTi9FelVhbGU1?= =?utf-8?B?U0dtblE3c0oyYi9vbUtTbnVwSWpqc240OGhRSXlDcytVSjBnK09MamlvR2dN?= =?utf-8?B?WnJYVnFvdU0rTENUdFZCam1yNGZrb2p4WEhiODAwN2JZZTZjVi93cWNMbGg1?= =?utf-8?B?VHo5Ky9YMHpjS2VJSFNBTlJNNGhxNFl5dyt3ZHRXWS9JZzRrUWxtSEJ4VWJJ?= =?utf-8?B?di9ZbE0xQUhyVDBQWVdtRW5DLzhUVGcyNFk2emIvbW51anFCSUc2OU9QNE1h?= =?utf-8?B?Qnc3QWhvRDlMWEVwWlVlUDlZZ2FiWDRYNXlSTUg2TDVEVFBnbTlQd3pXNkpP?= =?utf-8?B?VGJrM0Y4UDN1Rk1HOFAwQkVIblRCRjNIM0ZMOGlpZ0c1TGdCRVNRZFRadERF?= =?utf-8?B?by9tVW5LMkRLaXQxM3ZWN2gwbU5rVmNXVE12b3NlRjFiWURCTzJRYVZLZDhX?= =?utf-8?B?NVFQTTJQdDF6L0hBL3BqeDFxYlFHQTdiVXpXbDhoOGpwNHZUc0tTR3NkYTdl?= =?utf-8?B?RkJYWWtIdjhEdVhKV0pGaTlwOW1KejNudzhrR2w5My9DWkVYZnRnc1hDcG5o?= =?utf-8?B?UnR2REkyenEwZnE2d0hnbXNna1pSaWpTdUhNT2RDQllpUUZjNmFNOTZ4MmdW?= =?utf-8?B?elRUeGhxalFtQU1GbHVvMFRRNmc1eFhEc3h3OCtTVUlXWEVrM3hPTnE5U2Zy?= =?utf-8?B?ZFU2dmhVZENLZ3ZZTTdjb1cvYjZUMmdkT3JLNnZLcURCczZHa29SUklzY0M5?= =?utf-8?B?VDMzbnZLTm91aDBUZXpxZmM1OVEwcG5sTDB5SmN3YnVna20wMWFHVm5NdkxE?= =?utf-8?B?OVlEQUxKeGZLc0xCZkFaV0RWM0Q5NGs5dXZYdENHRjluWnpHbXpPWEJSb0h0?= =?utf-8?B?UkovWTZvMW5RQnpBT3htVUNza3lpL1Y1TlRhSEdyWEN6Y1B4Mm0wYmVheCtC?= =?utf-8?B?eFVhckYrdFJXdjU3TEJKaHEwdFE4Y0ZJR05DMEx0YW9xK09jS0dHRkppNy80?= =?utf-8?B?UWZ3bVMwZHdkR3p1TEtiTG05RWF1NGdwVnpsdTdYcEY0UG9aaVpVM1ovelpY?= =?utf-8?B?YnFDTUp1blJYQUVDOEpSNXdZUmQ3TEMvMnZlbEdnYy9ld2RsYnAxTGhOa3Qv?= =?utf-8?B?OG5IRFpTMGZHWnFMdlpTeUI0YmNYS0FOVWoyMWVvZGpGOGs0WVJhWjFUK0ho?= =?utf-8?B?OGV6c1h4S0N6QkZrd1o1ZnVpME8rM3dNYTl6MEZYU0xFaFNiQXppMGVreThT?= =?utf-8?B?dGRNNFE1eHVaSi9SczdJaGlpRmp3dDRvakJNY001akg2YjU2Z1dCRm5kbWE1?= =?utf-8?B?S2dNZ3hvQVM3RzJ0U1JGQlpQdHh0OTdXbGNIZXFYUEV6SDFuZ2c4azJnVVN4?= =?utf-8?B?dmhKZUszVEdHbVZseFVHSWFyNVZMQlNoTmgvWWgzMTRjSk5TcGpZc0UrZHlY?= =?utf-8?B?VzNjR29RemErLy9XclMxblNNRlMzRjJqWCtZRm5tYXhYU3NBU3ZjaEs0cnRF?= =?utf-8?B?WFFSekh4dHJCQzlWdmo1eHRVZ3dCcUxxM0djWEhhQzlZSzlLV0VIc25pdHZ2?= =?utf-8?B?M0hFWk92VjRSazN1UjFJaUsvcVFZbVFiMHI5c1NRU09tS3FMazkyaUtkbi9K?= =?utf-8?Q?/lEGbwzy567fm1Z9ZwdjtHGst?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 806feb09-f4c0-4ab6-4aa6-08daf21d13f2 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2023 08:39:53.2715 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +VVuD1v/xioKYOe/J9Azpjz9bbirBzhKmjrhPUbnElvBp9HjAh1WO2mZvdZMrNr55sOLOsDkKNSw1DVqS1v69g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7093 On 06.01.2023 02:00, Andrew Cooper wrote: > On 05/01/2023 4:04 pm, Jan Beulich wrote: >> Perhaps these should have been dropped right in 2fb2dee1ac62 ("x86/mm: >> pagetable_dying() is HVM-only"). Convert both to assertions, noting that >> in particular the one in the 3-level variant of the function comes too > > "came too late"? > > It doesn't any more with this change in place. Fine with me either way, so I've changed it. Iirc in particular George has been advocating for writing descriptions in present tense, even if in the course of a change the stated fact changes as well. >> late anyway - first thing there we access the HVM part of a union. >> >> Signed-off-by: Jan Beulich > > Acked-by: Andrew Cooper Thanks. Jan From xen-devel-bounces@lists.xenproject.org Mon Jan 09 08:42:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 08:42:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473377.733931 (Exim 4.92) (envelope-from ) id 1pEnja-0006Ha-LI; Mon, 09 Jan 2023 08:42:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473377.733931; Mon, 09 Jan 2023 08:42:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEnja-0006HT-IK; Mon, 09 Jan 2023 08:42:22 +0000 Received: by outflank-mailman (input) for mailman id 473377; Mon, 09 Jan 2023 08:42:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEnjZ-0006HN-7e for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 08:42:21 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2085.outbound.protection.outlook.com [40.107.7.85]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 87575a56-8ff9-11ed-91b6-6bf2151ebd3b; Mon, 09 Jan 2023 09:42:20 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS4PR04MB9481.eurprd04.prod.outlook.com (2603:10a6:20b:4ea::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Mon, 9 Jan 2023 08:42:17 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5986.018; Mon, 9 Jan 2023 08:42:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 87575a56-8ff9-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZrLxFM09aKt2gSNNsVBKYFe+OAbIls/JYGUFCX5ASOwc8DTaEBrqyYdSaNKI2uu74PsubJmrr1nkjZijYFIYgmm35kKwRUIfQ83yRBTvvBLBM2m0wvVYdHlbwu5V8QymUBj+TX3ZHyjPuMoNCnXpmk8bd240Czf0LaJC2vuBtW0VoH38g5yb697eqklbEfMqpI5ujXy5OakIqKi0gcyjdoIKpIVgYuI8pzfZl5wAyT7g5OjG73NcqzFXaVxGM3X+LSDDyqcu0C9Vo/yejllRiaF8Luz/rJTVJIx+OiegQysiOmJ6PuUotZ3oGi0WSSsEL9p0Ekg4WMusQFsEaQE7JQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p8TokGGxB94VKlVbvpTwqndAo8B/W2RsotoDsKDJ7KA=; b=JrOFo/Npa4d0+m6UE5XuSVKNCF5sIyCm0DZbFDPLruH02Ug8k3d0AFtasFL09Qe9rZomjy87x+T/PGRjW5QgJkZTbeGlpJvNmtGSTAiQZS6Dic0YiRVPQ6lU0Na54LzrWecRDlJbN7416HpArKurIDe5pHDKdEE4WsfvY+FC9SC1qZDLDjOWOc2jvF2AW9vNb4l3N4EbhstHx9ZrDUkafD0EDcjKHhsADdCMFbM90iFkby+ur6pqi6W9X2Ma4dubSKS8DFIQS2OEpKnTeZdFtUMCE/Zo9k3RkT47LxZz4gq0CHUUUD/2zZg4W95K4TIdeEQOiZSxkgzcDouEcRhLJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p8TokGGxB94VKlVbvpTwqndAo8B/W2RsotoDsKDJ7KA=; b=C8F+nWduWBPMXjWwqmQSEGlsXVqnVrVdxccq3fj8TnZJhoYrjYikmr6VPqBW81yMvDCF8M3aLRJYSyL6XpeClmLAOHTjjMEWN7qJYJETNir5majDLuI/D9QAzjbXs+vZ9nz95ivAOmsF3p3PepmFRjOyvk/dbmPzOYT6Cz4rJH7eNCD8i0kjfcESUEO45EivBRaf/xTWEZUWHl8NsjcCZoXqw2fka4jkqUJn8UR39ZqLzuQcxXgeO9z2qTxNnVWGsMSyJTLCeTZgf6rkAIRgBdyf3/gQpOD4d+cFeHS/1fHOfgngxezEVD28jcP8PQUiXPl92zknPe5OCTPR3hrMag== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2c333051-4c2b-fdcf-75bb-1a700bb3a3ca@suse.com> Date: Mon, 9 Jan 2023 09:42:18 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 06/11] x86/shadow: drop a few uses of mfn_valid() Content-Language: en-US To: Andrew Cooper Cc: Wei Liu , Roger Pau Monne , "Tim (Xen.org)" , George Dunlap , "xen-devel@lists.xenproject.org" References: <074dc3bb-6057-4f61-d516-d0fe3551165c@suse.com> <11758833-fb7a-f937-a847-fe79ba932679@citrix.com> From: Jan Beulich In-Reply-To: <11758833-fb7a-f937-a847-fe79ba932679@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0123.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9d::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS4PR04MB9481:EE_ X-MS-Office365-Filtering-Correlation-Id: 20f8b1fd-57f3-4394-5d8b-08daf21d6a3a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XRCL1r1SSzj/RlFLW9OMCOpNDPiiGcpvgLxUmDnOKIV+6pX9FQ0I9+OO2UcXnMu1nZ+ckW85+9Siw0CQ05ZWGn7RWxBYv1AehB2OarwR+9Lrtod4ZlqC7w288+tOHcPGnalfUKQQNtKH9f7EulECDocu3W23sxApeSJR4UrdSZUUtnAx9DqTcd4nc7143elmhhlsHg+DKHfJT1Y4VaAxOA4meadqzMxVpn9xchUIR6BO2s6YXUw0sxDdqZljYKIs9ncNw2hstYgPVHyuj/tPjk3Mq8XgyWX4p8XK16FyeU657VhWsYmHCAxf6DzlwldI2QdXWMdM6zOvF5d8KnvuHw3IrIXt+D2bUNlCvZqLlaJoJet6Dz1JQHW+TiQrnttEwrJUCVeaieNcAcB5kyDlh77HHzp3IsKPd7GlsHU9OCjyK00UdzvCoMuYNPO7qWeuo9P6CQ0KMKso1WlDm/X8xxSYDCiBXCEbAuwBDMjVfVphTb3A2Sxngk5VB0V2aSvY4q4lrLjXGhVaeqsz46CrWWFQ4nnAiNmMsPvF7tDHT6jv/FekNaP6w4fo1KIC+bolQDmmxNvkBKe2unJgjwCAtkbEj2vUQ8wSCykA4bVCHQEhfSV1suLw1zcyVc9iOhKQzFT/iCXVJflft4kuVgxcRdw5vsKVY8htBk2A/coQIHX2be1B+2f0F7OomKXMDxSPLm05VokKcg0mwlUiR0M0xDlx/3vKEjpyP7ewPcQMONs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(366004)(39860400002)(376002)(136003)(346002)(451199015)(5660300002)(4744005)(41300700001)(6916009)(8936002)(36756003)(66556008)(66946007)(4326008)(66476007)(8676002)(6512007)(2616005)(53546011)(26005)(186003)(6506007)(31696002)(54906003)(316002)(86362001)(478600001)(6486002)(38100700002)(31686004)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Tkt1Wm5MeXFsQXh1QjVwM1RnY0VsR1puZGRXU09pSFRaOGpYeEpzK0tTNFB2?= =?utf-8?B?WDRoOHd4T0h6ejNTMWVCa2k5MXQxRkhlbHRMaUxaOStndFJQNEFFZVdlZ0tK?= =?utf-8?B?WFpMcERlckx1U0hTRDB3VmtacytFdThRR1pUSjR6SURQWnpTTHJac2xSbnI3?= =?utf-8?B?dXFWb2VzMmlvOGl0bDBSc2tyTTBkamtvSHYyUTJqNklud2tSd204bUxjQ001?= =?utf-8?B?ZFI5bjJVdWhJQTBkNzlSZHFkM2pjWVpJU294VjN0Q3BQZ2o0aWFCamlKTEt6?= =?utf-8?B?emJnMGduVlZkajF1SnZiK0RwMHR6bDlSSmNuaXhDM3RuNE5sNzNxMnRaS3VF?= =?utf-8?B?L0dtaExFSlN2aUgwbGdFaHNZcTZoYXRxOHpZUkhBNFFSQndYVENlbUxUTG1U?= =?utf-8?B?ZERybWtNSW5MYkhzK0pqZzJlRGNoRkpBZnhoOHdQOUlEZTdwa3lhTk0zVm0y?= =?utf-8?B?N1EzVUhMdUpVNjQ2WVFXVS9tUCs0TFd6MzRhNm1NdkVMaHVvQmFCOE9qTElw?= =?utf-8?B?SWRaUHVRdEVFUG9PY1VHOXpRN3hWampKcGRBd2dST1F4c2xxUFM1TFlNV1V6?= =?utf-8?B?TVVTVjkvOGxtVkgveVVKYUV5bGdpZWxoZXVlcFF5c0czRHNySDk4MVhJTFpJ?= =?utf-8?B?ejBBVUNwaEE3WG1SVFBYRWpmYW9xNVoxelpGTXhTV1lOcVVGUXphYzhUTnZx?= =?utf-8?B?ZlNrSTdWb2FLMFRYOENUOFRZQlpwNk8wUmoxcXhNOHUrK21LbjZNRldUdnFV?= =?utf-8?B?b1htM1F3emM1dEl1QlJtNngvRHQ0WWdOblN5ZDdWS1hiSW43aE5VTmFJa2pY?= =?utf-8?B?NmpKYVZlVTBlN1F2dytkOElRUXVQQzRablo5eElmMlZJM3hKbW0ycCtVVnZj?= =?utf-8?B?VUo5UTJKYkdLTnFhSWhyUE9pekZpRE4rdzRqNmErWS9uQU50UUZJelE5NDdL?= =?utf-8?B?NkJBTjVOZklaNSsrajdGcEVFSjdDTk5lS2NhaC80WUNadW8vTTJDc2ZqOXBJ?= =?utf-8?B?ZjZrVEcvNlJ4cG14a1NxcE1lSm5mMi9ic09EQmtaSUhOcnpIUnBzSHdMT3pj?= =?utf-8?B?K292THdndmhUUFQ0Y0swRXNkc0YrQ2tjVjE4djVxQ2lWSjhtcEViVWphTmIv?= =?utf-8?B?aVFFT2hJOUNCVFIwdkpVejBBMHRXWmdISzliTiswL2xWWmJhd05rdEhURzA2?= =?utf-8?B?Myt4eVk1cHZoM0MxUnJ0Q1JrSXFaV3BwcU5kRytUWHpRR0dHTkRoR0NPUkdG?= =?utf-8?B?OHNGRFZUMkNiUVo4RUl5Y2Q1QW1HQ2hNTkpZNHFKQUF4cjBpWnFLdXcrTi8v?= =?utf-8?B?eTFtNGYvejloTy92bm1XeVVMNGY4MmhDRFhTWWswOC9RMU5tWFJuSUxEMVls?= =?utf-8?B?YmdPQThleEVrMlpMMjdxeURHZ0ZRZ0JncFMrSHlJSlBrbXhyQVJXdC9pYkVQ?= =?utf-8?B?My9zak1Fa3N2aFNEYVBPWnVxckE3OVg3cHkxblpYbTlSbnYxRkl2eHZDSFNF?= =?utf-8?B?TDZpa213SDFmYUR1c3U1Q3p4SGZKL2IwZlpIb3FZT1lFOUg4ci9xU3FVZ2pL?= =?utf-8?B?aU05WFVCUVlmQm9DempmVDBacmxkUzRzYXhmd2JIY01qR2ZhZlJDVDYzM0pG?= =?utf-8?B?T01Ld0xZWERIVnN5eWNKZk4wWitJTGdaVUtDRzFoWkViS3NIOUNYYmswNHl2?= =?utf-8?B?N1VNMDZRQmtnNlpLZG5wZy9MaVJ0UkwyTDU2UE90MGlDdUdWQ2F4Ukl5WUlP?= =?utf-8?B?VUc1NzFGUEVhOUE5eko1YmgxOWpLb0tmY2UwVlFlcUJ1MU0vTGZJcjFLTHZD?= =?utf-8?B?V044MGNkUHczbi9hU3pYZVJZb0t3WVYzRWdiU284MHZVK2tZYU13VEwvcHRq?= =?utf-8?B?TXRJN3ZwY1JTeUxLcndQdnBFOWpBY3VjSFIwS2xkQ0JLbkhwb1dLYWxuN0RB?= =?utf-8?B?Zk1MM2NvTk9VaEI0Mlg4cDUvODhuOE1VZ2lQaDVKN1ErZzhzeG1scHcvbFFy?= =?utf-8?B?cGxOWml3ektMZjg0eStjWXNXQ2lJNFlRMFE4emFkTEE2RFduSnBNeUNtMUNZ?= =?utf-8?B?d0I3bU1HUzYzeGNueDh3UGdzd1RYRDJuMU1tUm12WWU3NzdTMzNyRkVhSUY5?= =?utf-8?Q?qjo8vpBiCKvuf+SDG0a4Y3T4w?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 20f8b1fd-57f3-4394-5d8b-08daf21d6a3a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2023 08:42:17.7779 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4xexnsUkheh04hithoZeuD2EQvbz2+ufG/K0Yx7rainbDrLewa8PD7zxw+GUW6bLWViECzZWZeiPjVMH4jC81w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9481 On 06.01.2023 02:02, Andrew Cooper wrote: > On 05/01/2023 4:04 pm, Jan Beulich wrote: >> v->arch.paging.shadow.shadow_table[], v->arch.paging.shadow.oos[], >> v->arch.paging.shadow.oos_{snapshot[],fixup[].smfn[]} as well as the > > fixup[],smfn[] ? No. See e.g. shadow_vcpu_init(): for ( i = 0; i < SHADOW_OOS_PAGES; i++ ) { v->arch.paging.shadow.oos[i] = INVALID_MFN; v->arch.paging.shadow.oos_snapshot[i] = INVALID_MFN; for ( j = 0; j < SHADOW_OOS_FIXUPS; j++ ) v->arch.paging.shadow.oos_fixup[i].smfn[j] = INVALID_MFN; } Jan From xen-devel-bounces@lists.xenproject.org Mon Jan 09 08:45:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 08:45:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473384.733945 (Exim 4.92) (envelope-from ) id 1pEnn3-0006vr-5V; Mon, 09 Jan 2023 08:45:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473384.733945; Mon, 09 Jan 2023 08:45:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEnn3-0006vk-2M; Mon, 09 Jan 2023 08:45:57 +0000 Received: by outflank-mailman (input) for mailman id 473384; Mon, 09 Jan 2023 08:45:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEnn1-0006vZ-VZ for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 08:45:55 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 077914b5-8ffa-11ed-91b6-6bf2151ebd3b; Mon, 09 Jan 2023 09:45:55 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6D1EA3398C; Mon, 9 Jan 2023 08:45:54 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 54674134AD; Mon, 9 Jan 2023 08:45:54 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ZYAxE0LUu2NzXgAAMHmgww (envelope-from ); Mon, 09 Jan 2023 08:45:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 077914b5-8ffa-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1673253954; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OKc77BZ7jmVzkkEt05fVty6YJF7FntGuB3ivZJkm7/4=; b=FFNjB0y2bC0EskGxw5uSjfduhjy1VzFCJoSmFuc8KmvCaeXpd7ARpI+YlE6xzpLU+Kvdoy Ue+L6oqu51TP9OKkVHJwVn21ffVdwVj4RCfL0ptr7+/IoNQwe3AOlRlLNKAeEILQYBiOBl cGTzp8ZXV2mVDwaC6K7VnnkWUfKj21s= Message-ID: <8690f6fa-ff8d-7416-866a-7effa5cae72c@suse.com> Date: Mon, 9 Jan 2023 09:45:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [linux-linus test] 175625: regressions - FAIL Content-Language: en-US To: osstest service owner , xen-devel@lists.xenproject.org References: From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------HNJvX8s02B3jvvabVF0HFalX" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------HNJvX8s02B3jvvabVF0HFalX Content-Type: multipart/mixed; boundary="------------tY8fI00bzT6IVIp5R04hkNCh"; protected-headers="v1" From: Juergen Gross To: osstest service owner , xen-devel@lists.xenproject.org Message-ID: <8690f6fa-ff8d-7416-866a-7effa5cae72c@suse.com> Subject: Re: [linux-linus test] 175625: regressions - FAIL References: In-Reply-To: --------------tY8fI00bzT6IVIp5R04hkNCh Content-Type: multipart/mixed; boundary="------------8R4VdzGAmBj31La6YM1pdPJw" --------------8R4VdzGAmBj31La6YM1pdPJw Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDguMDEuMjMgMTc6NTQsIG9zc3Rlc3Qgc2VydmljZSBvd25lciB3cm90ZToNCj4gZmxp Z2h0IDE3NTYyNSBsaW51eC1saW51cyByZWFsIFtyZWFsXQ0KPiBodHRwOi8vbG9ncy50ZXN0 LWxhYi54ZW5wcm9qZWN0Lm9yZy9vc3N0ZXN0L2xvZ3MvMTc1NjI1Lw0KPiANCj4gUmVncmVz c2lvbnMgOi0oDQoNCkknbSBsb29raW5nIGF0IHRoZSB4ODYgZmFpbHVyZXMgcmlnaHQgbm93 Lg0KDQpJIGNhbiByZXByb2R1Y2UgdGhlIGlzc3VlIGxvY2FsbHkgdXNpbmcgdGhlIGxpbnVz IHRyZWUuDQoNCg0KSnVlcmdlbg0K --------------8R4VdzGAmBj31La6YM1pdPJw Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------8R4VdzGAmBj31La6YM1pdPJw-- --------------tY8fI00bzT6IVIp5R04hkNCh-- --------------HNJvX8s02B3jvvabVF0HFalX Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmO71EEFAwAAAAAACgkQsN6d1ii/Ey/j PggAgeKSGRrziGl9iKfleVwiJY7RIPlUp860WtpSsXDxBhI9sXOisoDezWG2QIMS0+wLRxh1myIW GfYwKh+M+MnPH6MWzUkutJnGvogTSqmQ85zOKS3NigRz7bmWdcN7MU0nkq7jtls292oIzOT7moAO 4midC35oKfpONBziKIcxG1tk9BCb2dEYM55aqieMd2OMvYcNuQ2VR+IMABkFaCln6acQ8l3GYuhC QKNFWLNlIZhIXc6zY/4jaIz7Vuht2Q7TpA9JYOy25IT+q9lmhypJV7svdTJhL9jTJSUTjM01A43+ 2rDphLViXa0adQZaKkPuyHuNV7kcuOLgbJ1m+q3oVw== =luNn -----END PGP SIGNATURE----- --------------HNJvX8s02B3jvvabVF0HFalX-- From xen-devel-bounces@lists.xenproject.org Mon Jan 09 08:53:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 08:53:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473391.733959 (Exim 4.92) (envelope-from ) id 1pEnuK-0008RG-Sw; Mon, 09 Jan 2023 08:53:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473391.733959; Mon, 09 Jan 2023 08:53:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEnuK-0008R9-QI; Mon, 09 Jan 2023 08:53:28 +0000 Received: by outflank-mailman (input) for mailman id 473391; Mon, 09 Jan 2023 08:53:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEnuK-0008R3-41 for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 08:53:28 +0000 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [2a00:1450:4864:20::133]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 144c49ba-8ffb-11ed-b8d0-410ff93cb8f0; Mon, 09 Jan 2023 09:53:25 +0100 (CET) Received: by mail-lf1-x133.google.com with SMTP id y25so11876765lfa.9 for ; Mon, 09 Jan 2023 00:53:25 -0800 (PST) Received: from [192.168.0.145] ([195.234.76.149]) by smtp.gmail.com with ESMTPSA id z3-20020a0565120c0300b004cb03999979sm1512441lfu.40.2023.01.09.00.53.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 00:53:24 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 144c49ba-8ffb-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=H6FchQyf5CB5ussTRx2mN0jjbocnfHQbf5QwEa2tL0Y=; b=nJdRXNf8vbCPVbpIkHSGAj+BncCPktEt1FFZFDhkFlWUSp/46Xz0t0kYD0AMEnU5Hh 7VKFy+ejJjJ8O2xoY4G6qIoTWCq960QLSAuMc0AeA7oi9N573ruGZ8MSaL/79baUfYUm pz4wraEETJPub4TQ6t/26Ga1IjVKwLeq9zdj/DLklOjYqPURBA/YONUzOeHjrvTYPdQS mi8lcbd6MYJOEodkfxY0xp9K4Oipbyz7syXE42cJZVEMM4rkm3Etm2ZQ41k13Gf6A2UY xAsCClpVFss8ZN4x7teE6SrsMZ7zmUnilSaUETeGsX7Z+haIaoNMNXAo4m3jSQF2JEcZ wmxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=H6FchQyf5CB5ussTRx2mN0jjbocnfHQbf5QwEa2tL0Y=; b=fmx32kq4aQJIzbrNYunDSxdJfEtUQ/d53k7r4qGKUvVkHbgexeLb5izgVGVGxatQz5 PJ3dUiIRmRQoRJStD/Ns4AZ5yZIBIOjGHZU+LQZchn9Wj7AH0e5CVftovYmSgTdJxd9A 5l67X7+w3sAkJiK5w3lgQqrV5dG2o4yWqz0fEiOOSOa/6rLjOmaQUcQQ0mLuXou6cHmS H1P5D9sOS48TLHf3jbf4ZAR6tPFJvDFjf5EW5J4m7NHIeigw6LdC0GyvM1rmYcSt15qV miju8wzQ3rK3OJzV0S0Crsddb2E1kK2haLQaRG95o6MFFeDiQI0g5lPnUrp7NcMWvfU2 c6LQ== X-Gm-Message-State: AFqh2kr2kfH2RRT4nBOK07tTfbmQ38BfwIJxE+3GvXCvAJLAZj2iaWsh cJHoPh/hoffplXztXry5ky4= X-Google-Smtp-Source: AMrXdXubr6vT7bcQ32NP1PlkH/uhp5KzoNbS5xjBB8VIi3OOeIREPdxCN9KnYVG44Z2h0/NGVjTeIQ== X-Received: by 2002:a05:6512:1049:b0:4b6:edce:a192 with SMTP id c9-20020a056512104900b004b6edcea192mr20185277lfb.4.1673254405308; Mon, 09 Jan 2023 00:53:25 -0800 (PST) Message-ID: <58d868b003f4a64922f3947cbf293c953471d8eb.camel@gmail.com> Subject: Re: [PATCH v1 1/8] xen/riscv: introduce dummy asm/init.h From: Oleksii To: Julien Grall , xen-devel@lists.xenproject.org Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis Date: Mon, 09 Jan 2023 10:53:24 +0200 In-Reply-To: <0da22900-63f0-b8fa-00b6-855e2a94485d@xen.org> References: <0da22900-63f0-b8fa-00b6-855e2a94485d@xen.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.1 (3.46.1-1.fc37) MIME-Version: 1.0 Thanks for the comments. I'll update commit message in the next patch series. ~Oleksii On Fri, 2023-01-06 at 13:42 +0000, Julien Grall wrote: > On 06/01/2023 13:14, Oleksii Kurochko wrote: >=20 > I am guessing this is necessary because you will use > will=20 > be used later on. >=20 > If so, then I think it would be useful for mention it in the commit > message. >=20 > > Signed-off-by: Oleksii Kurochko >=20 > Reviewed-by: Julien Grall >=20 > Cheers, >=20 From xen-devel-bounces@lists.xenproject.org Mon Jan 09 08:55:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 08:55:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473397.733970 (Exim 4.92) (envelope-from ) id 1pEnwB-0000a3-72; Mon, 09 Jan 2023 08:55:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473397.733970; Mon, 09 Jan 2023 08:55:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEnwB-0000Zw-4J; Mon, 09 Jan 2023 08:55:23 +0000 Received: by outflank-mailman (input) for mailman id 473397; Mon, 09 Jan 2023 08:55:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEnwA-0000Zq-2g for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 08:55:22 +0000 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [2a00:1450:4864:20::133]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 59026008-8ffb-11ed-91b6-6bf2151ebd3b; Mon, 09 Jan 2023 09:55:21 +0100 (CET) Received: by mail-lf1-x133.google.com with SMTP id bp15so11864142lfb.13 for ; Mon, 09 Jan 2023 00:55:21 -0800 (PST) Received: from [192.168.0.145] ([195.234.76.149]) by smtp.gmail.com with ESMTPSA id n26-20020a05651203fa00b0049464d89e40sm1502263lfq.72.2023.01.09.00.55.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 00:55:20 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 59026008-8ffb-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=nYOajGftRdTkdrjBSRQwUgFFIaAX9r6zGeq9XIW/ws4=; b=DdkCHQiSyTD2dFrDCmzf+zYN4WGp1iT2WSB2urYTar/CCN4vroT6ukONTKtx5PYcWA bu3A1mUs2SX74BOxqBjJw3XvWY+WhgLsXVqV9mMhkpr7bs+9g4amaer0Gq5EYo02/Uyz OQAm4s092ior6vzU5dPTLf06ED7doJ2QpPmhjXhAevABzNOBvuZ5A6YovJfTzyGs5jRx P0xqRhGh+5yzCXQliJSIoS6x1tSSjrEaiR5v1WhNFHW2RluDdoDc6MJENu3Z8sDH+aiF R64RRPAOs0d1nIqjPNcbKzPoUMkx5xvG2e68n+vvHckp+XzI8ad0kImALUzj4RR1XKRC 7eEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=nYOajGftRdTkdrjBSRQwUgFFIaAX9r6zGeq9XIW/ws4=; b=25RHpqYXefMdCFw3yaHFRzMuQsTMnrypurMyiltwaTY1UzcAc2ZK/pXk/X1MvIf12r ncY6cNk6bpMwjy0mthxNULiDY9AuLfFtdGoLNI8ntgPsyRE6WiY+G5Gx72wV/62Ca1Q6 7PzaIGfWdElkHRfhi1FOmlLq+9s16GgPxCtWyBJf/tGFNDmEkI5jKgWix5rbCUJH2igU H52mkv+1jFu6EPrFzMRsrHPIFzCyA9X0PTf4LZrScXimykHxeBnDJJ5r2bY41R74o7rC NNUwTFHbcxuQnGY6Q0owFomoXjXn7shgw7rcYevFwrcSH4u3vuyZQJKgWC+RrmPbfbx5 upnw== X-Gm-Message-State: AFqh2kqjl9//y0grZLllU/5BAPUfJCX26M+gwNxUJNtL40tBYviOW7nD /uk9LoV94nwwnOgqqyICnWM= X-Google-Smtp-Source: AMrXdXvhMxVXiiZqFaweyeLj5UV+VElqYeT2rSPHzTV9zTcfjhd6AHcMj6YW2lk4qTHMexNBt7Kj5A== X-Received: by 2002:a05:6512:6d6:b0:4a4:68b9:609b with SMTP id u22-20020a05651206d600b004a468b9609bmr21181328lff.38.1673254520712; Mon, 09 Jan 2023 00:55:20 -0800 (PST) Message-ID: <572f67e83b0da55acf28d15826a3ecde43b6c8a5.camel@gmail.com> Subject: Re: [PATCH v1 2/8] xen/riscv: introduce asm/types.h header file From: Oleksii To: Jan Beulich Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org Date: Mon, 09 Jan 2023 10:55:19 +0200 In-Reply-To: <204d2288-df9a-0d53-2c42-a52ad0c0c0f7@suse.com> References: <204d2288-df9a-0d53-2c42-a52ad0c0c0f7@suse.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.1 (3.46.1-1.fc37) MIME-Version: 1.0 On Fri, 2023-01-06 at 15:12 +0100, Jan Beulich wrote: > On 06.01.2023 14:14, Oleksii Kurochko wrote: > > Signed-off-by: Oleksii Kurochko > > --- > > =C2=A0xen/arch/riscv/include/asm/types.h | 73 > > ++++++++++++++++++++++++++++++ > > =C2=A01 file changed, 73 insertions(+) > > =C2=A0create mode 100644 xen/arch/riscv/include/asm/types.h > >=20 > > diff --git a/xen/arch/riscv/include/asm/types.h > > b/xen/arch/riscv/include/asm/types.h > > new file mode 100644 > > index 0000000000..48f27f97ba > > --- /dev/null > > +++ b/xen/arch/riscv/include/asm/types.h > > @@ -0,0 +1,73 @@ > > +#ifndef __RISCV_TYPES_H__ > > +#define __RISCV_TYPES_H__ > > + > > +#ifndef __ASSEMBLY__ > > + > > +typedef __signed__ char __s8; > > +typedef unsigned char __u8; > > + > > +typedef __signed__ short __s16; > > +typedef unsigned short __u16; > > + > > +typedef __signed__ int __s32; > > +typedef unsigned int __u32; > > + > > +#if defined(__GNUC__) && !defined(__STRICT_ANSI__) > > +#if defined(CONFIG_RISCV_32) > > +typedef __signed__ long long __s64; > > +typedef unsigned long long __u64; > > +#elif defined (CONFIG_RISCV_64) > > +typedef __signed__ long __s64; > > +typedef unsigned long __u64; > > +#endif > > +#endif >=20 > Of these, only the ones actually needed should be introduced. We're > in the process of phasing out especially the above, but also ... >=20 Got it. I will take it into account when the next version of patch series will be ready. > > +typedef signed char s8; > > +typedef unsigned char u8; > > + > > +typedef signed short s16; > > +typedef unsigned short u16; > > + > > +typedef signed int s32; > > +typedef unsigned int u32; > > + > > +#if defined(CONFIG_RISCV_32) > > +typedef signed long long s64; > > +typedef unsigned long long u64; >=20 > ... all of these. >=20 > > +typedef u32 vaddr_t; >=20 > (New) consumers of such types should therefore use {u,}int_t > instead. >=20 > Jan From xen-devel-bounces@lists.xenproject.org Mon Jan 09 08:57:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 08:57:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473403.733981 (Exim 4.92) (envelope-from ) id 1pEnxz-0001AP-K7; Mon, 09 Jan 2023 08:57:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473403.733981; Mon, 09 Jan 2023 08:57:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEnxz-0001AI-HT; Mon, 09 Jan 2023 08:57:15 +0000 Received: by outflank-mailman (input) for mailman id 473403; Mon, 09 Jan 2023 08:57:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEnxy-0001AC-Cn for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 08:57:14 +0000 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [2a00:1450:4864:20::12c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9bfca4dc-8ffb-11ed-91b6-6bf2151ebd3b; Mon, 09 Jan 2023 09:57:13 +0100 (CET) Received: by mail-lf1-x12c.google.com with SMTP id v25so11860451lfe.12 for ; Mon, 09 Jan 2023 00:57:13 -0800 (PST) Received: from [192.168.0.145] ([195.234.76.149]) by smtp.gmail.com with ESMTPSA id g21-20020a0565123b9500b004b585ff1fcdsm1498813lfv.273.2023.01.09.00.57.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 00:57:12 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9bfca4dc-8ffb-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=4wkF6tuT3ILdVALUx5K5GPfr+jHcvrDZ50Ltc77TZSE=; b=LT3y1fwmkcfrV19NBwv7MfcuvTFRXUz+aLUwjesC+sBDuo2Oz++WmAVAuBMXRAAGpA ++30qP5XudDO57RleTOFwSLFUSL36DHLeHJ5L3jWNKS52eI862L6arhv+HwmTsF8xav2 lte1aAQl1o97GSyzSCpTZ01j4r5B6DKsERe3uUJ2ncHSDzLwH5u7V7JVaUYoBD/TJbIw w7IFJ9kxI1DRJOhGozBKLHUp940QAx/f/KFZMQUN2lPm6Ijbs2fUnSgEODTeGkh1Il9j /w3ZLOxwR36qOjBsy9ao5O092jNOUT8nKs5FZp6iWRiiB6aKqDSaUmTw5cFucCi/VVHZ 8qxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=4wkF6tuT3ILdVALUx5K5GPfr+jHcvrDZ50Ltc77TZSE=; b=vKnkr9yn0hI+NL1M5XTv31wT59NIeZE/BS5+f5Zkw7MdpHs5c++ojcGdzSMcLgg7TW 7mGseQZybFb6BZYFi87K8Ncd52iTay6U9/Qsm36MWkmOxhUKjm2JH3SuFc25fgxON0S7 4Rb4sPf6XQAZZ+qikDCaWUAFAY1ZyxCd3Yl3sAPHK2YFJMSHw8JrgUjtbNt+WdQI76Qu jqOGE8OPz3IH9vfoCNS3ijEtX5Bj4Tqkp1WWT2MEyrIuSrJd5agXijPsI/+LeDKYOZ6N UDM/6HeBmQdkwnuvVqEx6LPs8mULya7dik8Hx4HOR58pHp48S4t819FlZ0EvSc+QxKHd 18jg== X-Gm-Message-State: AFqh2kok6UFyb/1CXhdoaXOEe1672wfmeorVoKl++sTpUw49cNUpWhRO 7zrc1zExKG9MxSuzAjgngdQ= X-Google-Smtp-Source: AMrXdXtqGBPuU4BYoI33w6HEcaGy2imRXOppDjWi32nk/MUffs9aCENlAC67IsuEO72f39cdKnYpjw== X-Received: by 2002:a05:6512:6d4:b0:4cb:1e1:f380 with SMTP id u20-20020a05651206d400b004cb01e1f380mr17009980lff.40.1673254633239; Mon, 09 Jan 2023 00:57:13 -0800 (PST) Message-ID: <572055bcc7b9716700fcb4139afe3697a04b7e98.camel@gmail.com> Subject: Re: [PATCH v1 3/8] xen/riscv: introduce stack stuff From: Oleksii To: Jan Beulich Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org Date: Mon, 09 Jan 2023 10:57:11 +0200 In-Reply-To: <9c93ee8c-1c7f-d1aa-c0fd-72518e37a74d@suse.com> References: <9c93ee8c-1c7f-d1aa-c0fd-72518e37a74d@suse.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.1 (3.46.1-1.fc37) MIME-Version: 1.0 On Fri, 2023-01-06 at 15:15 +0100, Jan Beulich wrote: > On 06.01.2023 14:14, Oleksii Kurochko wrote: > > --- a/xen/arch/riscv/riscv64/head.S > > +++ b/xen/arch/riscv/riscv64/head.S > > @@ -1,4 +1,10 @@ > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 .section .text.header,= "ax", %progbits > > =C2=A0 > > =C2=A0ENTRY(start) > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 j=C2=A0 start > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 la=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 sp, cpu0_boot_stack > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 li=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 t0, PAGE_SIZE > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 add=C2=A0=C2=A0=C2=A0=C2=A0= sp, sp, t0 > > + > > +_start_hang: > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 wfi > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 j=C2=A0 _start_hang >=20 > Nit: I think it would be nice if in a new port assembly code used > consistent padding between insn mnemonic and operand(s). >=20 Missed it. Actually it will be "fixed" in the later patches of the patch series but i'll fix this while working on a new version of the patch series. ~Oleksii > Jan From xen-devel-bounces@lists.xenproject.org Mon Jan 09 09:01:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 09:01:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473411.733992 (Exim 4.92) (envelope-from ) id 1pEo1a-0002gm-92; Mon, 09 Jan 2023 09:00:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473411.733992; Mon, 09 Jan 2023 09:00:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEo1a-0002gf-59; Mon, 09 Jan 2023 09:00:58 +0000 Received: by outflank-mailman (input) for mailman id 473411; Mon, 09 Jan 2023 09:00:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEo1Y-0002gX-FL for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 09:00:56 +0000 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [2a00:1450:4864:20::131]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1f51d740-8ffc-11ed-b8d0-410ff93cb8f0; Mon, 09 Jan 2023 10:00:53 +0100 (CET) Received: by mail-lf1-x131.google.com with SMTP id f34so11879769lfv.10 for ; Mon, 09 Jan 2023 01:00:53 -0800 (PST) Received: from [192.168.0.145] ([195.234.76.149]) by smtp.gmail.com with ESMTPSA id a14-20020ac25e6e000000b004cb0cf701bfsm1502848lfr.56.2023.01.09.01.00.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 01:00:53 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1f51d740-8ffc-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=OkSnczKg8DyifVN5v5YKXWTt1W4XmuFXNXvw+DyBKU0=; b=XDj9h2i19rAfolCNFCazX7w+18ZgxLxJS59w/t1gv/T28YR9U6aAjJEStqyTP9uM5R QmloYJA5WwDndpGqq3drWQ/MkUGuD1VZHCe/PUOkzV9UntQSftoKSkbEHE4CPpzephpb j6hwXavwY/qnkzEKwIcjAPbYVsTVOQO+XRvkfti+BHmsLg6Zt/BdA7dwAw5Loo9I8KyX hBJVHceUVONhV39V9jOwbNRmR/+saXFGkFZgecN90idMY8+dJxUZiZKLkj0T1Y4VzTM1 /rYCAg256LzQTexIfkD7YgXkQAc3q7q9z/UA+lYG+/5oQN5HlgoiR7WokiZ0hQtdBT6n 9mOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=OkSnczKg8DyifVN5v5YKXWTt1W4XmuFXNXvw+DyBKU0=; b=UrUmpqH7A3X215JVtaIL6CFJUIvi1UpOYG+MXiRaEgCqPlL21EVZpLavawEYQoXDxp eOQO62wFNvXYhAj+Cp3IC25du4Lxab+XBT3wfMUIjW3CdzS8DfqbTqZfdkw2q/eS1Sy/ ZLDJAPfkSjc+WfdWGz4vpEykjjevRWE3hNlMH86kj5ThK2g9sYTDKNkJ1d2nv+F+4+ey YbMpSbZgq3sepb5O9jJ1rF5HdCgv+yv8LdRL4Zl0dafXgWISHOJjxLYst3UR4YHimBR6 67uS3GBWlaZ3rdGnbgGZs33dv94pv4rEju3iqf/XjO+Er2qEBlrzV2Tw3lWuY8GYhhdS S5Jg== X-Gm-Message-State: AFqh2krNDZHRDIlBQTq21I1NFwYXmPsjhYa6HlnKLfbluKy81oKw7GT3 iuYhgOQA5rEEDsogd3dWaKM= X-Google-Smtp-Source: AMrXdXsSM0oFwJAP0FmpVn2BirfgZuTFma7hq5cErRpJJkZAP2wZrZnPHoZ5sCpaUAuZNx6pBfNRcw== X-Received: by 2002:a05:6512:3588:b0:4cb:1189:285a with SMTP id m8-20020a056512358800b004cb1189285amr12548844lfr.5.1673254853553; Mon, 09 Jan 2023 01:00:53 -0800 (PST) Message-ID: <53c3402164304ddc0b27d82aa6c1716cb99c4ccf.camel@gmail.com> Subject: Re: [PATCH v1 3/8] xen/riscv: introduce stack stuff From: Oleksii To: Julien Grall , xen-devel@lists.xenproject.org Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis Date: Mon, 09 Jan 2023 11:00:47 +0200 In-Reply-To: <4e577d78-ff2f-3258-99d6-712af3b6330d@xen.org> References: <4e577d78-ff2f-3258-99d6-712af3b6330d@xen.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.1 (3.46.1-1.fc37) MIME-Version: 1.0 Hi, On Fri, 2023-01-06 at 13:54 +0000, Julien Grall wrote: > Hi, >=20 > On 06/01/2023 13:14, Oleksii Kurochko wrote: > > The patch introduces and sets up a stack in order to go to C > > environment > >=20 > > Signed-off-by: Oleksii Kurochko > > --- > > =C2=A0 xen/arch/riscv/Makefile=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 1 = + > > =C2=A0 xen/arch/riscv/riscv64/head.S | 8 +++++++- > > =C2=A0 xen/arch/riscv/setup.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= | 6 ++++++ > > =C2=A0 3 files changed, 14 insertions(+), 1 deletion(-) > > =C2=A0 create mode 100644 xen/arch/riscv/setup.c > >=20 > > diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile > > index 248f2cbb3e..5a67a3f493 100644 > > --- a/xen/arch/riscv/Makefile > > +++ b/xen/arch/riscv/Makefile > > @@ -1,4 +1,5 @@ > > =C2=A0 obj-$(CONFIG_RISCV_64) +=3D riscv64/ > > +obj-y +=3D setup.o > > =C2=A0=20 > > =C2=A0 $(TARGET): $(TARGET)-syms > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0$(OBJCOPY) -O binary -S= $< $@ > > diff --git a/xen/arch/riscv/riscv64/head.S > > b/xen/arch/riscv/riscv64/head.S > > index 990edb70a0..ddc7104701 100644 > > --- a/xen/arch/riscv/riscv64/head.S > > +++ b/xen/arch/riscv/riscv64/head.S > > @@ -1,4 +1,10 @@ > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 .section .text.h= eader, "ax", %progbits > > =C2=A0=20 > > =C2=A0 ENTRY(start) > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 j=C2=A0 start > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 la=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 sp, cpu0_boot_stack > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 li=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 t0, PAGE_SIZE >=20 > I would recommend to a define STACK_SIZE. So you don't make > assumption=20 > on the size in the code and it is easier to update. >=20 Thanks. I decied to not define STACK_SIZE because it is used now only once and the STACK_SIZE that was introduced in Bobby's patch series was too big at least for current purpose. Any way it probably makes sensne to intrdouce STACK_SIZE from the start so will take it into account during a work at new patch series. > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 add=C2=A0=C2=A0=C2=A0=C2=A0= sp, sp, t0 > > + > > +_start_hang: > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 wfi > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 j=C2=A0 _start_hang > > diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c > > new file mode 100644 > > index 0000000000..2c7dca1daa > > --- /dev/null > > +++ b/xen/arch/riscv/setup.c > > @@ -0,0 +1,6 @@ > > +#include > > +#include > > + > > +/* Xen stack for bringing up the first CPU. */ > > +unsigned char __initdata cpu0_boot_stack[PAGE_SIZE] > > +=C2=A0=C2=A0=C2=A0 __aligned(PAGE_SIZE); >=20 > Cheers, >=20 From xen-devel-bounces@lists.xenproject.org Mon Jan 09 09:04:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 09:04:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473417.734003 (Exim 4.92) (envelope-from ) id 1pEo4a-0003Ho-Ni; Mon, 09 Jan 2023 09:04:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473417.734003; Mon, 09 Jan 2023 09:04:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEo4a-0003Hh-Kh; Mon, 09 Jan 2023 09:04:04 +0000 Received: by outflank-mailman (input) for mailman id 473417; Mon, 09 Jan 2023 09:04:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEo4Z-0003Hb-I9 for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 09:04:03 +0000 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [2a00:1450:4864:20::232]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8fdc65aa-8ffc-11ed-91b6-6bf2151ebd3b; Mon, 09 Jan 2023 10:04:02 +0100 (CET) Received: by mail-lj1-x232.google.com with SMTP id q2so8174328ljp.6 for ; Mon, 09 Jan 2023 01:04:02 -0800 (PST) Received: from [192.168.0.145] ([195.234.76.149]) by smtp.gmail.com with ESMTPSA id bj36-20020a2eaaa4000000b0027ff2fabcb5sm800824ljb.104.2023.01.09.01.04.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 01:04:01 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8fdc65aa-8ffc-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=XwOSHtC2Z1W6QBgrGVhCWI9Of2uz2+3UV4UHU0xmC2E=; b=VAJfE9vScem/y8hG5SFrPdtZ6BN+ZrlnvdkAyO3EzxZ2ONwJ21XfqOrIL/9HMOBAj2 UmXT+9mmUAlr4puFqdD2r7LDGOYEJEyCPfqNXdeFPTLda5FLoEkAxlttTaVGruO9PJ7O TmVjZu6rCMHmUJT0d8C7x0lUOPss04TSwBrhW1Z41Y3xr0Ns6sXzVau+Ir+XQGBAPKgS 9GPCmdoNySDAEaJY6debV3W1qBmhpnA61kUZweHpPZoW9IZa6+TsEHPjxvFY3DGgOOpR p5PAP5DHOAbxwBEKPG4Pe2Xr4PrQz9ZVVdkQ5Y6srgoRIyH5Jq7fBfCjdfGFfpGqgU0b M7ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=XwOSHtC2Z1W6QBgrGVhCWI9Of2uz2+3UV4UHU0xmC2E=; b=U5gequm/iOWv8n65Lz0G7gAOkreTmHtbODemZyVp4mFevd+WRAFHo499fhUhR8xC6G Fvd625bvvSJ0jZEWqanvuZW7DMIRGIOOruBalcZVq8o6hR33Xfg9TLU/gWoIwVINoRdS s2p3K6qMrTH4BpKqqKa01j9BdouKh7xWJRdTLHwQ1HL6kfWlk/E0eaav+2Hfe9iLbwEa NcyhQCXvGtn/owRolFVu0bnQAf4WaSoxH5UEPF7/RBWR8x4TCr+D1a6wd63US/+ctB0G FHJaJhcL39KcdTG8ObEQFOsa272CqUaSvOl6Xcfgh268f7JRvEH8vzCnUabdsGSju5qd sXeg== X-Gm-Message-State: AFqh2kr/bRHCsVcEGQq/PFgvR3XDO0vrWSiM6K0G+bWIoOFImGRvrbUE Gf2YnHl/1J6O69FwO2VFfVE= X-Google-Smtp-Source: AMrXdXtrEt8Zl7w+6S+A8Zrb1+1m71MEWc5BL3xoM7vK53fbLXYeQAmr+bVCVxBp8jSu05s830AlWQ== X-Received: by 2002:a2e:8882:0:b0:27f:ed3e:8c70 with SMTP id k2-20020a2e8882000000b0027fed3e8c70mr7521295lji.34.1673255042163; Mon, 09 Jan 2023 01:04:02 -0800 (PST) Message-ID: <0475c058d0655f5b7b245f19b20c5ef0f14b3618.camel@gmail.com> Subject: Re: [PATCH v1 4/8] xen/riscv: introduce sbi call to putchar to console From: Oleksii To: Julien Grall , xen-devel@lists.xenproject.org Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis Date: Mon, 09 Jan 2023 11:04:00 +0200 In-Reply-To: References: <09da5a3184242152af6af060720a007738a55d6e.1673009740.git.oleksii.kurochko@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.1 (3.46.1-1.fc37) MIME-Version: 1.0 Hi, On Fri, 2023-01-06 at 13:40 +0000, Julien Grall wrote: > Hi, >=20 > On 06/01/2023 13:14, Oleksii Kurochko wrote: > > The patch introduce sbi_putchar() SBI call which is necessary > > to implement initial early_printk > >=20 > > Signed-off-by: Oleksii Kurochko > > --- > > =C2=A0 xen/arch/riscv/Makefile=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 |=C2=A0 1 + > > =C2=A0 xen/arch/riscv/include/asm/sbi.h | 34 ++++++++++++++++++++++++ > > =C2=A0 xen/arch/riscv/sbi.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 44 > > ++++++++++++++++++++++++++++++++ >=20 > IMHO, it would be better to implement sbi.c in assembly so you can > use=20 > print in the console before you jump to C world. >=20 I thought that we can live with C version as we set up stack from the start and then we can call early_printk() from assembly code too. Is it bad approach? > > =C2=A0 3 files changed, 79 insertions(+) > > =C2=A0 create mode 100644 xen/arch/riscv/include/asm/sbi.h > > =C2=A0 create mode 100644 xen/arch/riscv/sbi.c > >=20 > > diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile > > index 5a67a3f493..60db415654 100644 > > --- a/xen/arch/riscv/Makefile > > +++ b/xen/arch/riscv/Makefile > > @@ -1,5 +1,6 @@ > > =C2=A0 obj-$(CONFIG_RISCV_64) +=3D riscv64/ > > =C2=A0 obj-y +=3D setup.o > > +obj-y +=3D sbi.o >=20 > Please order the filename alphabetically. >=20 > Cheers, >=20 From xen-devel-bounces@lists.xenproject.org Mon Jan 09 09:06:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 09:06:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473423.734014 (Exim 4.92) (envelope-from ) id 1pEo6t-0003sm-5W; Mon, 09 Jan 2023 09:06:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473423.734014; Mon, 09 Jan 2023 09:06:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEo6t-0003sf-0x; Mon, 09 Jan 2023 09:06:27 +0000 Received: by outflank-mailman (input) for mailman id 473423; Mon, 09 Jan 2023 09:06:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEo6r-0003sZ-UL for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 09:06:25 +0000 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [2a00:1450:4864:20::131]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e480c940-8ffc-11ed-91b6-6bf2151ebd3b; Mon, 09 Jan 2023 10:06:24 +0100 (CET) Received: by mail-lf1-x131.google.com with SMTP id y25so11929278lfa.9 for ; Mon, 09 Jan 2023 01:06:24 -0800 (PST) Received: from [192.168.0.145] ([195.234.76.149]) by smtp.gmail.com with ESMTPSA id m5-20020a056512114500b004a6f66eed7fsm1515230lfg.165.2023.01.09.01.06.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 01:06:23 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e480c940-8ffc-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=ldZV+qH6ZXr7RZBH0qLzar7l+uCmbf1eTyBjBz70T8Q=; b=hfIQEM3gqJz9V4DD8KXaZPv58twh+RjCL0/BOjTcMCh21W8Sm5c/S+l8mgdA/uupb8 CHOEJ2AI/dsVqnYpam1DP2uduywm42l+0g7yzcM2gxzcN0P362+xm5cHQBS7vvQVwN49 OYXWDcuXqBtFYUdIbSK/6lgOisZO5d9Bke7NEMX0+NhpT1FeubVEHjuQvcreETHuj8hA tHFbbjK6PBjm0fcJ3JAutv0uhy+25vm/9V6iAC8mLzEB4ICpl7cTweaRHqEfLNj+TMeL Ds8Q/MI/qrURLjus36Fr6DZ+m4aA9kPe6vSh9LNd0fPGuiQnTeI0JNN6QoIszh07734l DV1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ldZV+qH6ZXr7RZBH0qLzar7l+uCmbf1eTyBjBz70T8Q=; b=vJDMnCbfW5+O1FcYKlZFqoXjc/k9JXeiEBof7VrMbLcjoQ4LMg/0hKd//Xoc5np++D qfn8cFXexLdW23EutjSSg07E0fCFxCmCxMcjLdeNHmCo2k1NwNuj3TRtTWHjqFDi4wre UrKyCAffPNzXOiFivImL7bjC/nIXav1aa+iCfFXuoRrmZ+NAgjrepI+Ht0AfKA6aAaGM au0bCXAnWT6T1xgtIndaKd0OAm0K3F00dtokCJiGATLRsoCjgnHPuEpcR9Y6haFvlh+a k6DDUoQ9lbvL2rX7Wns9QSaLoq4ZUws8ZPUyCKTxscBaMcqaBoDYDHqBy+PQFX3foZc5 N6UQ== X-Gm-Message-State: AFqh2krJkrOCevFB5uUGotcTDaewh4gaNZmjak/FHlsLHqug3bYTIc4N NXxSlXQxdLagpxR+9CmZp78= X-Google-Smtp-Source: AMrXdXtYq5nJUVungVZkOKVSlDy4VxKpUU5/JWi9bv9wdziHsqW6Peis4hX9djXGZ69UQnpY+m0Z5w== X-Received: by 2002:a05:6512:318d:b0:4b5:70e0:f2e6 with SMTP id i13-20020a056512318d00b004b570e0f2e6mr22776856lfe.24.1673255184192; Mon, 09 Jan 2023 01:06:24 -0800 (PST) Message-ID: Subject: Re: [PATCH v1 4/8] xen/riscv: introduce sbi call to putchar to console From: Oleksii To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis Date: Mon, 09 Jan 2023 11:06:22 +0200 In-Reply-To: <420e9747-09ba-b6e4-d3c5-14f0f174c1d7@amd.com> References: <09da5a3184242152af6af060720a007738a55d6e.1673009740.git.oleksii.kurochko@gmail.com> <420e9747-09ba-b6e4-d3c5-14f0f174c1d7@amd.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.1 (3.46.1-1.fc37) MIME-Version: 1.0 Hi Michal, On Fri, 2023-01-06 at 16:19 +0100, Michal Orzel wrote: > Hi Oleksii, >=20 > On 06/01/2023 14:14, Oleksii Kurochko wrote: > >=20 > >=20 > > The patch introduce sbi_putchar() SBI call which is necessary > > to implement initial early_printk > >=20 > > Signed-off-by: Oleksii Kurochko > > --- > > =C2=A0xen/arch/riscv/Makefile=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 |=C2=A0 1 + > > =C2=A0xen/arch/riscv/include/asm/sbi.h | 34 ++++++++++++++++++++++++ > > =C2=A0xen/arch/riscv/sbi.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 | 44 > > ++++++++++++++++++++++++++++++++ > > =C2=A03 files changed, 79 insertions(+) > > =C2=A0create mode 100644 xen/arch/riscv/include/asm/sbi.h > > =C2=A0create mode 100644 xen/arch/riscv/sbi.c > >=20 > > diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile > > index 5a67a3f493..60db415654 100644 > > --- a/xen/arch/riscv/Makefile > > +++ b/xen/arch/riscv/Makefile > > @@ -1,5 +1,6 @@ > > =C2=A0obj-$(CONFIG_RISCV_64) +=3D riscv64/ > > =C2=A0obj-y +=3D setup.o > > +obj-y +=3D sbi.o > >=20 > > =C2=A0$(TARGET): $(TARGET)-syms > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 $(OBJCOPY) -O binary -S $< $= @ > > diff --git a/xen/arch/riscv/include/asm/sbi.h > > b/xen/arch/riscv/include/asm/sbi.h > > new file mode 100644 > > index 0000000000..34b53f8eaf > > --- /dev/null > > +++ b/xen/arch/riscv/include/asm/sbi.h > > @@ -0,0 +1,34 @@ > > +/* SPDX-License-Identifier: (GPL-2.0-or-later) */ > > +/* > > + * Copyright (c) 2021 Vates SAS. > > + * > > + * Taken from xvisor, modified by Bobby Eshleman > > (bobby.eshleman@gmail.com). > > + * > > + * Taken/modified from Xvisor project with the following > > copyright: > > + * > > + * Copyright (c) 2019 Western Digital Corporation or its > > affiliates. > > + */ > > + > > +#ifndef __CPU_SBI_H__ > > +#define __CPU_SBI_H__ > I wonder where does CPU come from. Shouldn't this be called > __ASM_RISCV_SBI_H__ ? >=20 I missed that when get this files from Bobby's patch series. It makes sense to rename the define. Thanks. > > + > > +#define SBI_EXT_0_1_CONSOLE_PUTCHAR=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 0x1 > > + > > +struct sbiret { > > +=C2=A0=C2=A0=C2=A0 long error; > > +=C2=A0=C2=A0=C2=A0 long value; > > +}; > > + > > +struct sbiret sbi_ecall(unsigned long ext, unsigned long fid, > > unsigned long arg0, > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unsigned long arg1, unsigne= d long arg2, > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unsigned long arg3, unsigne= d long arg4, > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unsigned long arg5); > The arguments needs to be aligned. >=20 > > + > > +/** > > + * Writes given character to the console device. > > + * > > + * @param ch The data to be written to the console. > > + */ > > +void sbi_console_putchar(int ch); > > + > > +#endif // __CPU_SBI_H__ > // should be replaced with /* */ >=20 > > diff --git a/xen/arch/riscv/sbi.c b/xen/arch/riscv/sbi.c > > new file mode 100644 > > index 0000000000..67cf5dd982 > > --- /dev/null > > +++ b/xen/arch/riscv/sbi.c > > @@ -0,0 +1,44 @@ > > +/* SPDX-License-Identifier: GPL-2.0-or-later */ > > +/* > > + * Taken and modified from the xvisor project with the copyright > > Copyright (c) > > + * 2019 Western Digital Corporation or its affiliates and author > > Anup Patel > > + * (anup.patel@wdc.com). > > + * > > + * Modified by Bobby Eshleman (bobby.eshleman@gmail.com). > > + * > > + * Copyright (c) 2019 Western Digital Corporation or its > > affiliates. > > + * Copyright (c) 2021 Vates SAS. > > + */ > > + > > +#include > > +#include > > + > > +struct sbiret sbi_ecall(unsigned long ext, unsigned long fid, > > unsigned long arg0, > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 uns= igned long arg1, unsigned long arg2, > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 uns= igned long arg3, unsigned long arg4, > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 uns= igned long arg5) > The arguments needs to be aligned. >=20 It looks that I mixed tabs with space or vice versa. Will double check. Thanks. > > +{ > > +=C2=A0=C2=A0=C2=A0 struct sbiret ret; > Could you please add an empty line here. >=20 > > +=C2=A0=C2=A0=C2=A0 register unsigned long a0 asm ("a0") =3D arg0; > > +=C2=A0=C2=A0=C2=A0 register unsigned long a1 asm ("a1") =3D arg1; > > +=C2=A0=C2=A0=C2=A0 register unsigned long a2 asm ("a2") =3D arg2; > > +=C2=A0=C2=A0=C2=A0 register unsigned long a3 asm ("a3") =3D arg3; > > +=C2=A0=C2=A0=C2=A0 register unsigned long a4 asm ("a4") =3D arg4; > > +=C2=A0=C2=A0=C2=A0 register unsigned long a5 asm ("a5") =3D arg5; > > +=C2=A0=C2=A0=C2=A0 register unsigned long a6 asm ("a6") =3D fid; > > +=C2=A0=C2=A0=C2=A0 register unsigned long a7 asm ("a7") =3D ext; > > + > > +=C2=A0=C2=A0=C2=A0 asm volatile ("ecall" > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 : "+r" (a0), "+r" (a1) > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 : "r" (a2), "r" (a3), "r" (a4), "r" (a5), "r" (a6), > > "r" (a7) > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 : "memory"); > > +=C2=A0=C2=A0=C2=A0 ret.error =3D a0; > > +=C2=A0=C2=A0=C2=A0 ret.value =3D a1; > > + > > +=C2=A0=C2=A0=C2=A0 return ret; > > +} > > + > > +void sbi_console_putchar(int ch) > > +{ > > +=C2=A0=C2=A0=C2=A0 sbi_ecall(SBI_EXT_0_1_CONSOLE_PUTCHAR, 0, ch, 0, 0,= 0, 0, 0); > > +} > > -- > > 2.38.1 > >=20 > >=20 >=20 > ~Michal ~Oleksii From xen-devel-bounces@lists.xenproject.org Mon Jan 09 09:10:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 09:10:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473429.734025 (Exim 4.92) (envelope-from ) id 1pEoAW-0005JN-KW; Mon, 09 Jan 2023 09:10:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473429.734025; Mon, 09 Jan 2023 09:10:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEoAW-0005JG-H5; Mon, 09 Jan 2023 09:10:12 +0000 Received: by outflank-mailman (input) for mailman id 473429; Mon, 09 Jan 2023 09:10:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEoAV-0005J8-FG for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 09:10:11 +0000 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [2a00:1450:4864:20::132]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6a6727c9-8ffd-11ed-b8d0-410ff93cb8f0; Mon, 09 Jan 2023 10:10:09 +0100 (CET) Received: by mail-lf1-x132.google.com with SMTP id cf42so11974699lfb.1 for ; Mon, 09 Jan 2023 01:10:09 -0800 (PST) Received: from [192.168.0.145] ([195.234.76.149]) by smtp.gmail.com with ESMTPSA id i7-20020ac25227000000b004ac6a444b26sm1514062lfl.141.2023.01.09.01.10.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 01:10:08 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6a6727c9-8ffd-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=ESdRJf7ipG0u+2VSciQ+mY4GL0Sloy+alwrd7Z0FJHQ=; b=caekt8SUz767Ip7U2HWOV+cA9HA8AlxKV6Y4vgom8TF4riKxo+KpDzTSEUzmNe596D DIqAak1XhGCuLAO2RLnEgrrOG/ZPhHXbiIg0+3OequXDPxMVsb699Qmqy+z2tUWGtxuq GpkN9JfbrobXUcXZyv28GvTVyHpuVOfzdgGsxwVm4d6DkSTdzqgivTYMBAQE+fbz6hgY WGh8Cqd7TYeBbnTFTxCvJChIeKJcDrYas2gNhxYxAxu/0epTHKzPu/rSC+uigo0xdKHz E6m3z+sgqhsL+FRusBfxrtb3GPp+N+b35SF1ELHK/CcmsSxTCnIt+jg0xIlEbna5qDnm Afyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ESdRJf7ipG0u+2VSciQ+mY4GL0Sloy+alwrd7Z0FJHQ=; b=zvhq4kTZfby0Ny6V3JwaKeBog7Nr4FM0R7UmyeYPnukKeAuXYkJGS9+IrKkPpgJIeO fyzk6Yjj/UMD104nC1125ywrERBbevtQuF+yH+soN04qm6rTKk65TNgWLiJhVPnzFVx8 1FaUg+9apb0PNvXuGuIlMQZd46cJZlbjBj39RnM2e5ya06jsz0HD5iy3G61pIXYRH3uy 7StIHV9NeCY3tzy5zS7yKre0on3Dje466wXx3LB1e+VZl62AYx8G1qOHcKhjkqNId4Cg izX3E8cLeGOVrsvitPDPJ7UJMlHMU0ZiwHsLiCNmfwGUqL/GK1ChJ3EIkhB/CLlB00sV ZEaQ== X-Gm-Message-State: AFqh2kqrlmGSRN28PwctwZP1g4jUBFcVdn0ZE0WeKoFva8wRWkDaDXem 4p3lEZbRhP+ZWrB7aoCdzx0= X-Google-Smtp-Source: AMrXdXsrX12RVMgm7xzFs7RLSnMQdkqbrqYByDYOSg8cvE8JP2MqZEmQYYRjVlmj8Q8zvtYSzgqFQg== X-Received: by 2002:a05:6512:2356:b0:4cb:4416:1e7d with SMTP id p22-20020a056512235600b004cb44161e7dmr8781564lfu.48.1673255409001; Mon, 09 Jan 2023 01:10:09 -0800 (PST) Message-ID: Subject: Re: [PATCH v1 6/8] xen/riscv: introduce early_printk basic stuff From: Oleksii To: Julien Grall , xen-devel@lists.xenproject.org Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis Date: Mon, 09 Jan 2023 11:10:07 +0200 In-Reply-To: References: <3f30a60729b45ee01adc2d4c0eec5a89bb083abd.1673009740.git.oleksii.kurochko@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.1 (3.46.1-1.fc37) MIME-Version: 1.0 Hi, On Fri, 2023-01-06 at 13:51 +0000, Julien Grall wrote: > Hi, >=20 > On 06/01/2023 13:14, Oleksii Kurochko wrote: > > The patch introduces a basic stuff of early_printk functionality > > which will be enough to print 'hello from C environment" > >=20 > > Signed-off-by: Oleksii Kurochko > > --- > > =C2=A0 xen/arch/riscv/Kconfig.debug=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 7 ++++++ > > =C2=A0 xen/arch/riscv/Makefile=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2= =A0 1 + > > =C2=A0 xen/arch/riscv/early_printk.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 27 > > +++++++++++++++++++++++ > > =C2=A0 xen/arch/riscv/include/asm/early_printk.h | 12 ++++++++++ > > =C2=A0 4 files changed, 47 insertions(+) > > =C2=A0 create mode 100644 xen/arch/riscv/early_printk.c > > =C2=A0 create mode 100644 xen/arch/riscv/include/asm/early_printk.h > >=20 > > diff --git a/xen/arch/riscv/Kconfig.debug > > b/xen/arch/riscv/Kconfig.debug > > index e69de29bb2..940630fd62 100644 > > --- a/xen/arch/riscv/Kconfig.debug > > +++ b/xen/arch/riscv/Kconfig.debug > > @@ -0,0 +1,7 @@ > > +config EARLY_PRINTK > > +=C2=A0=C2=A0=C2=A0 bool "Enable early printk config" > > +=C2=A0=C2=A0=C2=A0 default DEBUG > > +=C2=A0=C2=A0=C2=A0 depends on RISCV_64 >=20 > OOI, why can't this be used for RISCV_32? >=20 We can. It's my fault we wanted to start from RISCV_64 support so I totally forgot about RISCV_32 =3D) > > +=C2=A0=C2=A0=C2=A0 help > > + > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Enables early printk debug messages > > diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile > > index 60db415654..e8630fe68d 100644 > > --- a/xen/arch/riscv/Makefile > > +++ b/xen/arch/riscv/Makefile > > @@ -1,6 +1,7 @@ > > =C2=A0 obj-$(CONFIG_RISCV_64) +=3D riscv64/ > > =C2=A0 obj-y +=3D setup.o > > =C2=A0 obj-y +=3D sbi.o > > +obj-$(CONFIG_EARLY_PRINTK) +=3D early_printk.o >=20 > Please order the files alphabetically. >=20 > > =C2=A0=20 > > =C2=A0 $(TARGET): $(TARGET)-syms > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0$(OBJCOPY) -O binary -S= $< $@ > > diff --git a/xen/arch/riscv/early_printk.c > > b/xen/arch/riscv/early_printk.c > > new file mode 100644 > > index 0000000000..f357f3220b > > --- /dev/null > > +++ b/xen/arch/riscv/early_printk.c > > @@ -0,0 +1,27 @@ >=20 > Please add an SPDX license (the default for Xen is GPLv2). >=20 > > +/* > > + * RISC-V early printk using SBI > > + * > > + * Copyright (C) 2021 Bobby Eshleman >=20 > So the copyright here is from Bobby. But I don't see any mention in > the=20 > commit message. Where is this coming from? >=20 Could you please share with me an example how it should be look like? Signed-off: ... ? Or "this file was taken from patch series ..."? > > + */ > > +#include > > +#include >=20 > Please order the files alphabetically. >=20 > > + > > +void early_puts(const char *s, size_t nr) > > +{ > > +=C2=A0=C2=A0=C2=A0 while ( nr-- > 0 ) > > +=C2=A0=C2=A0=C2=A0 { > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (*s =3D=3D '\n') > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 sbi= _console_putchar('\r'); > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 sbi_console_putchar(*s); > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 s++; > > +=C2=A0=C2=A0=C2=A0 } > > +} > > + > > +void early_printk(const char *str) > > +{ > > +=C2=A0=C2=A0=C2=A0 while (*str) > > +=C2=A0=C2=A0=C2=A0 { > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 early_puts(str, 1); > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 str++; > > +=C2=A0=C2=A0=C2=A0 } > > +} > > diff --git a/xen/arch/riscv/include/asm/early_printk.h > > b/xen/arch/riscv/include/asm/early_printk.h > > new file mode 100644 > > index 0000000000..05106e160d > > --- /dev/null > > +++ b/xen/arch/riscv/include/asm/early_printk.h > > @@ -0,0 +1,12 @@ > > +#ifndef __EARLY_PRINTK_H__ > > +#define __EARLY_PRINTK_H__ > > + > > +#include > > + > > +#ifdef CONFIG_EARLY_PRINTK > > +void early_printk(const char *str); > > +#else > > +static inline void early_printk(const char *s) {}; > > +#endif > > + > > +#endif /* __EARLY_PRINTK_H__ */ >=20 From xen-devel-bounces@lists.xenproject.org Mon Jan 09 09:12:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 09:12:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473436.734035 (Exim 4.92) (envelope-from ) id 1pEoCL-0005wq-4L; Mon, 09 Jan 2023 09:12:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473436.734035; Mon, 09 Jan 2023 09:12:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEoCL-0005wj-0u; Mon, 09 Jan 2023 09:12:05 +0000 Received: by outflank-mailman (input) for mailman id 473436; Mon, 09 Jan 2023 09:12:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEoCJ-0005wZ-4Y for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 09:12:03 +0000 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [2a00:1450:4864:20::135]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ad01c3e8-8ffd-11ed-b8d0-410ff93cb8f0; Mon, 09 Jan 2023 10:12:01 +0100 (CET) Received: by mail-lf1-x135.google.com with SMTP id bu8so11961102lfb.4 for ; Mon, 09 Jan 2023 01:12:01 -0800 (PST) Received: from [192.168.0.145] ([195.234.76.149]) by smtp.gmail.com with ESMTPSA id bp22-20020a056512159600b004cc800b1f2csm742680lfb.238.2023.01.09.01.11.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 01:11:59 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ad01c3e8-8ffd-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=F6yvyptlUCAsacDdikFfhnC9npXRFDLTNFsf28a75Wg=; b=FxZ4jcCi8mZ8rEMAPmd0IXgws7BmViiQsT+Kv0oqrS/UTm07Ov1DPGZ236zidT89DA mlKSkKreSrR3gPEHZq9dMyyF3RkT/90gQ9cb/WSw2OZTiGSe6sn5FjFDM9arH/LgDLBN 4bGI7MOh3GGr4BYi+vGG+/MLUxbwDVFWPu7pfmDcH774EehRkmcGtGuMcMJ0Njia4NZl UGWjQbJZXNrT5aKooEnOe1fSeum54MAtk630WyGAwhV8GVVrSwgUrP7h0/5FHAieTZpG qxfOQEnotjelP/2GoQcH16+27bTHMfuFmDRC8hVMdWI5PwnvuJFeMzXnsGc0FJjDAiKb kqcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=F6yvyptlUCAsacDdikFfhnC9npXRFDLTNFsf28a75Wg=; b=iNAAYa5wYWGFJAF70q8MAtMBluC3h5zGGsY6zMwvke0l13KGqVFylf5JqQXa6AxUgY D3y1QlUQwTBldLPwhMZ7zp73HfdUwq0lQ7WHw5s3xq75dnBovFqtZKNkQCDwHD4maZyu 818w8vRKPwxg+nvNSTNXCuUZsTgH3DNXvCqudludEi5ff5tF2MPnLD3G4Mhij80msyM0 M3UQsJfXw0IHFCwtXJ2Mq1XDUpypEK6Cw/ZuCd3Anv7EETwVHVZSdnwEHjgrU+XGF2/q qhiWLZboFPr8LIct07+W8ubcbOBdCW5yr5xrprAUg/EXoi6cEyCIeP/jgTExLto79dS9 N1Rw== X-Gm-Message-State: AFqh2krx28ftZ3ZtRRsaQ+zzI4OKfQxmrQeq2Wr0+wUTOKUzrrX1uMZ0 KIJYFNjjh5V9ckowwRPkzzrDEM/fmiThNLFJ X-Google-Smtp-Source: AMrXdXt2V3ufGnlWIbDre7Yx0eC6+4r8m61TMSXXthy6fhu+7nWEYEC0UgA/8vxJm8C4cuuMyW/xeg== X-Received: by 2002:a05:6512:4014:b0:4b6:f22c:8001 with SMTP id br20-20020a056512401400b004b6f22c8001mr27849177lfb.56.1673255520584; Mon, 09 Jan 2023 01:12:00 -0800 (PST) Message-ID: <2904df5d2d0882dc53ffb1da74072cb3956911ff.camel@gmail.com> Subject: Re: [PATCH v1 8/8] automation: add RISC-V smoke test From: Oleksii To: Andrew Cooper , "xen-devel@lists.xenproject.org" Cc: Stefano Stabellini , Gianluca Guida , Doug Goldstein Date: Mon, 09 Jan 2023 11:11:58 +0200 In-Reply-To: References: <90078a83982b37846e9845c8ffc50c92f3be1f47.1673009740.git.oleksii.kurochko@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.1 (3.46.1-1.fc37) MIME-Version: 1.0 On Fri, 2023-01-06 at 15:05 +0000, Andrew Cooper wrote: > On 06/01/2023 1:14 pm, Oleksii Kurochko wrote: > > Add check if there is a message 'Hello from C env' presents > > in log file to be sure that stack is set and C part of early printk > > is working. > >=20 > > Also qemu-system-riscv was added to riscv64.dockerfile as it is > > required for RISC-V smoke test. > >=20 > > Signed-off-by: Oleksii Kurochko > > --- > > =C2=A0automation/build/archlinux/riscv64.dockerfile |=C2=A0 3 ++- > > =C2=A0automation/scripts/qemu-smoke-riscv64.sh=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 | 20 > > +++++++++++++++++++ > > =C2=A02 files changed, 22 insertions(+), 1 deletion(-) > > =C2=A0create mode 100755 automation/scripts/qemu-smoke-riscv64.sh >=20 > Looking through the entire series, aren't we missing a hunk to > test.yml > to wire up the smoke test? >=20 Missed that. Will update test.yml in the next patch series. > It wants to live in this patch along with the introduction of > qemu-smoke-riscv64.sh >=20 > However, the modification to the dockerfile want breaking out and > submitted separately.=C2=A0 It will involve rebuilding and redeploying th= e > container, which is a) fine to do separately, and b) a necessary > prerequisite for anyone else to take this series and test it. >=20 I am going to send a patch with the dockerfle modification today. Thanks. > ~Andrew ~ Oleksii From xen-devel-bounces@lists.xenproject.org Mon Jan 09 09:12:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 09:12:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473440.734047 (Exim 4.92) (envelope-from ) id 1pEoCn-0006Sa-DW; Mon, 09 Jan 2023 09:12:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473440.734047; Mon, 09 Jan 2023 09:12:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEoCn-0006ST-9i; Mon, 09 Jan 2023 09:12:33 +0000 Received: by outflank-mailman (input) for mailman id 473440; Mon, 09 Jan 2023 09:12:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEoCm-0005wZ-HX for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 09:12:32 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on2052.outbound.protection.outlook.com [40.107.8.52]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id be1d729d-8ffd-11ed-b8d0-410ff93cb8f0; Mon, 09 Jan 2023 10:12:30 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8321.eurprd04.prod.outlook.com (2603:10a6:20b:3ed::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Mon, 9 Jan 2023 09:12:28 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5986.018; Mon, 9 Jan 2023 09:12:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: be1d729d-8ffd-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Pbreo01RYKT1B/6AAl0X9Vg0gaD/l5PDs/zR0o1gvkZrIBQNm6I2jxU+WXmwJs8BHrlhAzs8K2ZXdBjnS7HM17u6Z7ocJyi0EkczE9m1nlRg3f1e6mJFqinZ3zHjxlN6TSbTPnRHhp/Ssk2MN86Vrct3lNUXMJvzEP5v1aH+7YY00ziPkeqYJbV+eElPgis60DVSM/QzRFbDRfIEy8sWj/dkDt4wJ8188buMM/cHrJSKn+lJLZl6xWzGGca5csOYRr9mNpEJ9qL8RqxUkBtAGW3j8txOlFVhC+ArOBtJkx2HRNxsGKoS7Jd/NODDPC7/hug+9+syHiWBBOqhxobcCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zltIqmOu9avvin4Lknq+ZL4sWOJEvhYdePJIffPVP0w=; b=gp5xerPkiY0IkV/+dzXIA/+IkhemAt/WGddun7+YZEoy+zd1XHm2wBvtYYF/pmKWRR2po0Y6k8SknIODwl4jsRfVua/2ZDPdjGHPzt/Eu8C1QQLJCrONMJ4cjqqgZAwa4I4NKLswzKv4RVRpyUKAVe6S6igf8410QtgQVj7V4iBx25JLosIwchPSN2MvRtpvyIEmHD7Rxvrn12DZztJVtoStDqYtqcBHVvsxevpvTqMlG1lJ+7jzBY/mY2vdzdjJltAAwFumv+CbNMaWOodt+VJblnp7z0lPIeo8Ql7F2tzLWn3JWD60xPPTffFWkHyqNW5F+UYQjoTTYqqo0UPKOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zltIqmOu9avvin4Lknq+ZL4sWOJEvhYdePJIffPVP0w=; b=AhCd43YETew4/jDGg1+tay8E0hhTfuVEMY52CzFH5NKmlPJ8L/CrgVCCyAcWKsymFEXcLlH41DggFGdYeLuP5Rz4QgeP50FaNwm5aQPzog385k3tZ6vgPR8Z2Aa+xFirMtDz8wvFRI0Du2EziaUJQ3HerqKumJCeJ9GH6I1eDQQGZJIhKXoxfYxO6voYkf+STbsLD/Ms46qeFaEhJ0IGzUKDM3lzsY0NsqY8vMmkTX57+MX15TKUkDTCtV7Q+2SXrUJn493drvci1PNbduI3KTS85tb4qn8JSJjguuYcahP0qI83ZXgIj4tyF4sS7o+lsVEmS2w0L07x1HhfjErErA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <50fe40ce-56d7-4184-7677-53bb1f1cbf22@suse.com> Date: Mon, 9 Jan 2023 10:12:29 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 07/11] x86/shadow: L2H shadow type is PV32-only Content-Language: en-US To: Andrew Cooper Cc: Wei Liu , Roger Pau Monne , "Tim (Xen.org)" , George Dunlap , "xen-devel@lists.xenproject.org" References: <074dc3bb-6057-4f61-d516-d0fe3551165c@suse.com> <2743393d-852d-b385-9eba-e22806b1c4af@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0069.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::22) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8321:EE_ X-MS-Office365-Filtering-Correlation-Id: 47c39ab3-7ee9-4cae-9594-08daf221a14f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oExBowF7lkbTFfyXp1B72R/6rGJ5XyTz88lAjhVgqt1OGEKY3/Q6JA0WNFjeJfrJUnhPsdHi7bNE1+h5dTEhwyKt0H7yPak64M/n2QFtLi2hAsMx1IXWCxA3LiR6cnk+8Dda8aQrjcIA4b5It+zshYvAouRY/oymmr25c3TVMMullemoI5UJ252Vf84VuyiShEdqJuWWWkqnerr2nJc9FBbGEz23phMkZnVfS/rd+iReimL2Kq1AxyQRP2z+oBTJbvFQdQZTqBeMRN2bz+4j5CNoKqJ+ErUF2iyrngsWO1cCgHF9YhYTub6hqe0BWAIAtCejyQuEjK8lqhssWd2j869gRytmOR30zRkrU8p8d9oeZNnVdXEaYQap3JWMQgrnl8tb5y+lauOzrnsj+S9xk7WGupMO4Q5NNmzk2r1VhpAerS6kTkQF/6DSpaca1MXToQqneUCJY8MhGQeyVu7m9Q1PUQDY55HS5K3L1qbICdqZr81ViKcP033YTaFI4SYVEOzcAt8IrjAhD+YkiB0MnJPhCJWijAaflPlwwAnTthA4qw4ShAcGddd+4re6GlMkKHo8KUA5AoQyDH4LFF7NCiuDd8tfQy6BCA7Bpd3MNDOhkDScTaRMucSrbawFBZRqCLIZQfG5S4LZWw/45u/ZA1XxAj+vitWSrwXkzyfSBXhnnXth/Zt7s4Qeb+L6IrAsl8OX17g2Zuf087XZaZy1209aou0PcQgAZy+KnizUj34= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(366004)(346002)(136003)(396003)(39860400002)(451199015)(2906002)(83380400001)(54906003)(2616005)(66476007)(66556008)(5660300002)(66946007)(26005)(186003)(53546011)(36756003)(8936002)(6506007)(6512007)(478600001)(38100700002)(8676002)(41300700001)(31686004)(6486002)(86362001)(6916009)(4326008)(316002)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dzBaTVdVL1hRK3ZoSkxLTDNtenAxWjl3cjVQU2ZlUUZYbHR1eHlZaHJXRlAx?= =?utf-8?B?UisyQWFwUzlvUTExR3NoVGo1S1lWaGswdjF4MUZCTUYybFluMks5SmNmTzVy?= =?utf-8?B?NmNyMmZjZU5tajduSzRJSThlbGFTMFhVS1BlMFU0Yi9xOXFPZENOaVhDcjBT?= =?utf-8?B?cHRNOGVFMDljWUs2eWxnWTlkZkhZVDZ4VFJ3cGZoWjZ1UVpVZEtKb0pwNVI5?= =?utf-8?B?ZmUrVERuQnJEY3Fvekh0cG4wQjJaYUJOcGtURlA3ajdGMFJjQjI2bGRVY3Zo?= =?utf-8?B?S00wMGVrRDJiZytzdlVjT0wyQ2ZIdmJxRFUyNCtPWk1nQUlXbm8xSmxmY3ZJ?= =?utf-8?B?eXE2VmRGaEUxdXVuTFpsVUkyT2loK2tIYlVZK1RGZlpJTUlaRVhUNnBYWHZx?= =?utf-8?B?d2VDRUNYaXlRbTVMWTc4VVY5ejJNZVRPaGdLdHJVbldyZkZidXJuWW9SMkYx?= =?utf-8?B?aFROSlBhQ2RBb2JCY0R4c1Fhd1huVit2RlEwcnJWTzFnSkR1OEdPVWpadVFm?= =?utf-8?B?ZzR2bEtGWDFnd1FYTzVieGZnM2p2UnBLcy91Zk9lNzJad0tHaEt4NEdnVUFk?= =?utf-8?B?WVpnZmMwZ1Y1ZGZIK1h0dXhzTWJKeUh0ZVFLU2twRDdnSS9WTDNyYWd4TVpx?= =?utf-8?B?QWN3dkVoL1lXQlhObmRIZDZqenk2aDltZWRhREQzY2NMbXFYS0p2ZnJaQmhm?= =?utf-8?B?WVY0VDVuNVFrS2Z3UitKeml6Q0t5bVk1dFlpQTMwRFh3UWFRTlJORStGRXZx?= =?utf-8?B?MXhDeWJyZXgvUVMrdDd2bUMxUHR2NTUrZUlUWHJSNndZTlNZV1RoeWRmbThj?= =?utf-8?B?SVJFNXpUcGd3NW9QakxqZjFEa1lkZEJMeDQvRDVlN2RmZXYwdHJidCtXU1dL?= =?utf-8?B?SFlkakg1NExkR1ZvdTVzMHhJY2h3MmRxZkEzRmtGcndQeERCWVAvWVgrY2NU?= =?utf-8?B?RW8yOVR3ckhaeFkwNXFMNWNVbXNIVy9zS0hqcjltTytnMEJ3cisxTTk1SHJS?= =?utf-8?B?OEl6aUdBOW94U0ViSGlqNEVQQVZ4NCticXpJL0J2ZEdibHRSTlBiejlielBU?= =?utf-8?B?ZlY4QUhtdFNTZkd5S2FGZmpTUyt3WVg1dXp6cnZKYnp4azF1Y2hDQWJMSXhw?= =?utf-8?B?c2paRWFwU1k4S0k0UE45dS90eHdkdXZ5ZkQrYkVhUW93U3pLTXZIS3RPeEgy?= =?utf-8?B?VnFudG5QdmlHeVlkcjhMVFVtaGR3a2J4bWliaUVmcXdyVlJVL0RIRm56TFpl?= =?utf-8?B?MFZLbjEwLytCaTJ6QWlQQU41ZkRzd1NmdXlkeTU2RmZvZXRzZFdLd24yOXlu?= =?utf-8?B?Rjg1OXpvWHdPOWxseEFjbC9wYTFaR2JLVi9lRmRiUGUyUU41eklNbGZmemZu?= =?utf-8?B?Y2ZmTXp0VWNlK25sOTBoWFhMZ2ZHckQ5WFpqUDdKWkFubUs5V3Q5MG1yZm8r?= =?utf-8?B?WFQwc2dZbG1hSnVHM0RGb3BOYmcxRjBBRkExWTBnNWpXZ3dwdy8vTS81RGpV?= =?utf-8?B?S1JuRjVjdFJici94dGN6a2ViRXJKT2lZdzdaamxJcTcvK1M3MXdxN1hCSmJJ?= =?utf-8?B?TjhMb3l0Z3Q3Znp0RVY5VDVTUzNvSGM3bzRvVmJqeTNBWlQyU2hINWd3d3Js?= =?utf-8?B?S1NVN1hZVVp3NkJHdnlZVzM2VzVIbG5oR0EwVXhiMW93NkFidVNyYmZnVWFp?= =?utf-8?B?cUpoQ2xScUtaMW5XZWFyR3hTQ3ZiRFVIK3dpN3hkb1FRc1B6THh1K1JhSU13?= =?utf-8?B?bDk5TnprZzdnOEhPT2QxWW9aNjkzQUZORmpwcndML09zb1htbE9iOXpDYk9F?= =?utf-8?B?ck5DQzc1cXV0b1ZybCswZzZobHlMa1cxMlBjK1BCVVQwbURsOUljV2lpU2Ri?= =?utf-8?B?R1FNUkZoVUo5a3BISUFXV3NlczBLNGEvZytTdTdORzdoenFwbFRxN2NxNC9s?= =?utf-8?B?bzZKWVhZaUVVY3dHNmxCZnBoUlZMUTE3NG9PVFVzMDM3bTg5SWFjbDZxaDFR?= =?utf-8?B?a1psRTRBSWYzOWdxSUMrZWQ5RU04aUlCUXRnRkJuZXBmelhWOURyUlFjMWtz?= =?utf-8?B?dC9KQUh4U21VUFVrVTNCUUMyVCtJRzBML1BLK3M0Sm1GTmlQTDJvSWZYMjVI?= =?utf-8?Q?12XGZvdo/iJeoJRS0+bwVecjE?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 47c39ab3-7ee9-4cae-9594-08daf221a14f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2023 09:12:28.1786 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mk9kXQR+QIKXjj/mnalL+ehT36gcfeObZE3KVMFvwbMxQ+6uwMKOo9PJ+t0XYz67shrWsTJFUx7fk+1QAAQJBw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8321 On 06.01.2023 02:31, Andrew Cooper wrote: > On 05/01/2023 4:05 pm, Jan Beulich wrote: >> Like for the various HVM-only types, save a little bit of code by suitably >> "masking" this type out when !PV32. > > add/remove: 0/1 grow/shrink: 2/4 up/down: 544/-922 (-378) > Function                                     old     new   delta > sh_map_and_validate_gl2e__guest_4            136     666    +530 > sh_destroy_shadow                            289     303     +14 > sh_clear_shadow_entry__guest_4               178     176      -2 > sh_validate_guest_entry                      521     472     -49 > sh_map_and_validate_gl2he__guest_4           136       2    -134 > sh_remove_shadows                           4757    4545    -212 > validate_gl2e                                525       -    -525 > Total: Before=3914702, After=3914324, chg -0.01% > > Marginal... Talk wasn't of only size, but also of what actually is being executed for no gain e.g. in sh_remove_shadows(). I think "a little bit" is a fair statement. >> Signed-off-by: Jan Beulich >> --- >> I wasn't really sure whether it would be worthwhile to also update the >> "#else" part of shadow_size(). Doing so would be a little tricky, as the >> type to return 0 for has no name right now; I'd need to move down the >> #undef to allow for that. Thoughts? > > This refers to the straight deletion from sh_type_to_size[] ? Not really, no, but ... > I was confused by that at first.  The shadow does have a size of 1.  Might > > /*   [SH_type_l2h_64_shadow]  = 1,  PV32 only */ > > work better?  That leaves it clearly in there as a 1, but not needing > any further ifdefary. ... I've made this adjustment anyway. I'd like to note though that such commenting is being disliked by Misra. The remark is rather about shadow_size() itself which already doesn't return the "correct" size for all of the types when !HVM, utilizing that the returned size is of no real interest for types which aren't used in that case (and which then also don't really exist anymore as "distinguishable" types). Plus the connection to assertions like this ASSERT(pages); in shadow_alloc(): "pages" is the return value from shadow_size(), and I think it wouldn't be bad to trigger for "dead" types, requiring the function to return zero for this type despite it not becoming aliased to SH_type_unused (i.e. unlike the types unavailable when !HVM). Which makes me notice that with HVM=y shadow_size() would probably better use array_access_nospec(). I'll add another patch for this. >> --- a/xen/arch/x86/mm/shadow/multi.c >> +++ b/xen/arch/x86/mm/shadow/multi.c >> @@ -859,13 +866,12 @@ do { >> int _i; \ >> int _xen = !shadow_mode_external(_dom); \ >> shadow_l2e_t *_sp = map_domain_page((_sl2mfn)); \ >> - ASSERT(mfn_to_page(_sl2mfn)->u.sh.type == SH_type_l2_64_shadow ||\ >> - mfn_to_page(_sl2mfn)->u.sh.type == SH_type_l2h_64_shadow);\ >> + ASSERT_VALID_L2(mfn_to_page(_sl2mfn)->u.sh.type); \ >> for ( _i = 0; _i < SHADOW_L2_PAGETABLE_ENTRIES; _i++ ) \ >> { \ >> if ( (!(_xen)) \ >> || !is_pv_32bit_domain(_dom) \ >> - || mfn_to_page(_sl2mfn)->u.sh.type != SH_type_l2h_64_shadow \ >> + || mfn_to_page(_sl2mfn)->u.sh.type == SH_type_l2_64_shadow \ > > Isn't this redundant with the ASSERT_VALID_L2() now? How would that be? ASSERT_VALID_L2(), when PV32=y allows for both l2 and l2h, whereas here we strictly mean only l2. The sole reason for the change is that the l2h constant simply doesn't exist anymore when !PV32. > Per your other question, yes this desperately wants rearranging, but I > would agree with it being another patch. > > I did previously play at trying to simplify the PV pagetable loops in a > similar way.  Code-gen wise, I think the L2 loops what to calculate an > upper bound which is either 512, or compat_first_slot, while the L4 > loops what an "if(i == 256) i += 7; continue;" rather than having > LFENCE-ing predicates on each iteration. I'll see what I can do without getting distracted too much. (I also guess you mean "i += 15".) Jan From xen-devel-bounces@lists.xenproject.org Mon Jan 09 09:37:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 09:37:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473452.734063 (Exim 4.92) (envelope-from ) id 1pEoaG-0002gR-QW; Mon, 09 Jan 2023 09:36:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473452.734063; Mon, 09 Jan 2023 09:36:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEoaG-0002gI-LE; Mon, 09 Jan 2023 09:36:48 +0000 Received: by outflank-mailman (input) for mailman id 473452; Mon, 09 Jan 2023 09:36:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEoaF-0002gC-WA for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 09:36:48 +0000 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [2a00:1450:4864:20::634]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 21ba2e36-9001-11ed-b8d0-410ff93cb8f0; Mon, 09 Jan 2023 10:36:45 +0100 (CET) Received: by mail-ej1-x634.google.com with SMTP id fc4so18483436ejc.12 for ; Mon, 09 Jan 2023 01:36:45 -0800 (PST) Received: from [192.168.0.106] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id s17-20020a1709060c1100b0084d21db0691sm3499300ejf.179.2023.01.09.01.36.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Jan 2023 01:36:44 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 21ba2e36-9001-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=B/99t8qgIMvqhTeD4zkjN62XwwCpzj4U7vSzDxnnCDc=; b=Wr6wSX47NhAaHWDBxrRzP3g44XWLE7Sy4kLqNdnb4foosqDf+nLDomsCssY2zOOFog NXPtAcnszBjFC9BS097w7hd8JmxrV8iNjfl9n7AZGkrK3EgI5EYIZeDrPqokl4jqwOvc +j2Hxtw3xlpjURIxGkdnfvWzCUxvpQAY3PxkreiLVHXCL6UBUtGr9Iq20YUW0vici0NI kzgVzZC5tNRTd6takvgAt90yusSH2cV89CQeoEPCx6XWQmBls8ewonRT1cpYKsOCV8ej Jdknn++muHOcvJZCFsNHJM73JecI5DumceEo8ZZN/duRaVt0CSnb5FAVWarGefsUczRr gYFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=B/99t8qgIMvqhTeD4zkjN62XwwCpzj4U7vSzDxnnCDc=; b=5wOiGOX/p5ztpHw+s1ivzWaOE0TV1qCnYu94RaEdRzGs++ZPwJk/Y6fwfVloZmv/kI pdMPmxQHOFmv8h5Wyrzgp7ThZbETIswKgLkAOvFY7oVO2UrzOfFLOBr0L3xDeHQ2W77M 5ITsJ4dIYUNxm97SYTeoCSvfa3EjtN0Hczv5xcLn0TzXluZvnWQ9s/Iwl6Z1ImBE1zMl ZoJ8E3IgFwhfFb6LVBN6qrQar2n/KaWQEeShMKpQftqHA/eF2zCPPymCmK62KlO0s3Pl O/mzADqTQxLWlIsfmaCb9HkZhTcCAID9+9cvkMULG8dn88E4U2HiWtdwdiaw45wvJF/I E0CQ== X-Gm-Message-State: AFqh2krKytZ1t6L6TiPADzw4zfQgNFIoohBivaRurIT1mbxcJfy3yrm0 m/r539nZv+PMOphfEY0jSL0= X-Google-Smtp-Source: AMrXdXs0p4wKdR5+FK+UzVIUwLWzUEefxJdL4gN93AyqKDIsqVQkT7sg4nqObI5zLUjwfACLEYyPJw== X-Received: by 2002:a17:906:1583:b0:83f:384f:ea23 with SMTP id k3-20020a170906158300b0083f384fea23mr51928606ejd.57.1673257004921; Mon, 09 Jan 2023 01:36:44 -0800 (PST) Message-ID: <20b15211-492b-713e-288c-14bd5e137ed7@gmail.com> Date: Mon, 9 Jan 2023 11:36:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [XEN v4] xen/arm: Probe the load/entry point address of an uImage correctly To: Julien Grall , Ayan Kumar Halder , xen-devel@lists.xenproject.org, Dmytro_Firsov@epam.com Cc: sstabellini@kernel.org, stefano.stabellini@amd.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, michal.orzel@amd.com, Oleksandr Tyshchenko References: <20221221185300.5309-1-ayan.kumar.halder@amd.com> Content-Language: en-US From: Oleksandr Tyshchenko In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 08.01.23 18:06, Julien Grall wrote: Hello Julien, Ayan, all > Hi Ayan, > > On 21/12/2022 18:53, Ayan Kumar Halder wrote: >> Currently, kernel_uimage_probe() does not read the load/entry point >> address >> set in the uImge header. Thus, info->zimage.start is 0 (default >> value). This >> causes, kernel_zimage_place() to treat the binary (contained within >> uImage) >> as position independent executable. Thus, it loads it at an incorrect >> address. >> >> The correct approach would be to read "uimage.load" and set >> info->zimage.start. This will ensure that the binary is loaded at the >> correct address. Also, read "uimage.ep" and set info->entry (ie kernel >> entry >> address). >> >> If user provides load address (ie "uimage.load") as 0x0, then the >> image is >> treated as position independent executable. Xen can load such an image at >> any address it considers appropriate. A position independent executable >> cannot have a fixed entry point address. >> >> This behavior is applicable for both arm32 and arm64 platforms. >> >> Earlier for arm32 and arm64 platforms, Xen was ignoring the load and >> entry >> point address set in the uImage header. With this commit, Xen will use >> them. >> This makes the behavior of Xen consistent with uboot for uimage headers. > > The changes look good to me (with a few of comments below). That said, > before acking the code, I would like an existing user of uImage (maybe > EPAM or Arm?) to confirm they are happy with the change. I have just re-checked current patch in our typical Xen based environment (no dom0less, Linux in Dom0) and didn't notice issues with it. But we use zImage for Dom0's kernel, so kernel_uimage_probe() is not called. I CCed Dmytro Firsov who is playing with Zephyr in Dom0 and *might* use uImage. [snip] From xen-devel-bounces@lists.xenproject.org Mon Jan 09 09:48:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 09:48:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473458.734074 (Exim 4.92) (envelope-from ) id 1pEolm-0004DU-Q3; Mon, 09 Jan 2023 09:48:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473458.734074; Mon, 09 Jan 2023 09:48:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEolm-0004DN-Mr; Mon, 09 Jan 2023 09:48:42 +0000 Received: by outflank-mailman (input) for mailman id 473458; Mon, 09 Jan 2023 09:48:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEoll-0004DH-J4 for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 09:48:41 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2051.outbound.protection.outlook.com [40.107.7.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cb13073a-9002-11ed-b8d0-410ff93cb8f0; Mon, 09 Jan 2023 10:48:39 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8908.eurprd04.prod.outlook.com (2603:10a6:20b:40b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Mon, 9 Jan 2023 09:48:37 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5986.018; Mon, 9 Jan 2023 09:48:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cb13073a-9002-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Xo64tgn/sivb8DgDWuQ1gopVmjLgmtIIXqD3ASdtyzsseqUiemf9H4taxs16wpK08In6h7Dg1rgF0TvFEMIlEVjr8VO89W84Cwe7bgQza3KHVVvge5bzlPIZXffX4+J/kf7LNUbwRHh80gaOcfkOcnrJBPQXsL2NTNVOWMjuux1xSWS1MIMdwW0Cy9lWzhDNigeyjS6ql+Q0Sa0QamEumVUfiBmk4UZeEVc+7JB9rMalVxXLPpTjxRCxrIXrc0aLofoxQsfVjI2iyDt+Xauq0amNFwzso3c4HKgSMi3i1eehCrPz8lzIMtHaUXWirjZvX7yonW3IjrdQ6HFwBjQ59Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MMHx9wpBRn012eK/sOZhbqy2uXhf9JMI/fRvQnuW4bg=; b=oaQT+O9CrhpCUOg/7Yye2TJAW7UWoSmnsVcRJUpAvYNv2Om+J0p/x1xqgzzzZACFvMAHK2vv1VmFqAgHhZ1co2TRiHAmyb6BIusrvbyjyC5mrFuUEJ/r1O5mQVxfTaMADOAis9HreuZuZExh7Im3wQkBSjhRWV14ZMIhaeEzYTriUF4dLq7ZZFmskVCvPa5mMHq5QRoIYAi/wUI06+e51QeVuzIPL6wx+fcy4aLBwxjZ7TkHvuJf5Zq0jmmwJOxPMDNi+cirHVWslN+V1nPmx6bb++M2aRI+TewDJ2vdq4mcGSaKb35ECXXDentMXbaxNqfJJId1URtGYs9vnzJSkg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MMHx9wpBRn012eK/sOZhbqy2uXhf9JMI/fRvQnuW4bg=; b=SEylff1mwt7Cfm+NgX4SOGrdEPTlipD7mhLpIdrH/5SGxycSP+AQ6iIuDErsPmt/wVfGmkCHqBX3l6XuYK//IrCpprDYKonZjcI91iFcbKhrYMdXS9hXobNaFT49vBmTSoFj9jN1E9X8NPE39M6O/2yY0JPvd8SH2/yEE2MZz/lUKPsicr6tgtE/sXUgmpVIP7ouoaWkjilHZKcPaG0I+08amQqlY0nUe3RGDi8ZpywO2RTAAHQrIm+mii28BoWiw9oX76rPmePpa23wnyMZsNLZA85w0VleeaTyosQn5wWalAsqihPHVvet5/8UzeWamCKnx5ZPACfkS2bqxamEjg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <8b65788c-9815-6526-a023-3c1c64699d8f@suse.com> Date: Mon, 9 Jan 2023 10:48:38 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 08/11] x86/shadow: reduce effort of hash calculation Content-Language: en-US To: Andrew Cooper Cc: Wei Liu , Roger Pau Monne , "Tim (Xen.org)" , George Dunlap , "xen-devel@lists.xenproject.org" References: <074dc3bb-6057-4f61-d516-d0fe3551165c@suse.com> <20c268c0-979b-5ac9-da16-7cb7322552a6@citrix.com> From: Jan Beulich In-Reply-To: <20c268c0-979b-5ac9-da16-7cb7322552a6@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0079.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9a::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8908:EE_ X-MS-Office365-Filtering-Correlation-Id: 5d419066-a30e-4949-112b-08daf226ae6d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BELkF1sJgRNzFLnYmimgwZHadSrauKFRyX177OQ6sgqETg64PtMv9rzU01pFLf8uVro003GeoaN03kJlJ1y/FBkZJJoqPBOpGmOZdikQTW1Zu0NKfI9LzXrPXYLs10ANp7IvSSoNZoBqUEG5gMgDbnOwi1369E292YK5L3h9S/c34msi2O4BP5X35hhWRKnYn9skFlDpBqV+hKrheODqXzv90pwLgyv1aqKXwAU7zoPmdqwcL0UXUvohJSKsA24CfAKK+Ab1Ow6n0zr0uCmt8syg6CUQTpZZ7+oT3Efr9NUnfeinVE7y4PmhdbbLYq0I6evPCKZXIX27FpELfdzSAyGTGBoLYZ4GB7+KWQGLxDKqtz0yAlabxnP06rZm5LphM0g94AkdEuDJBSnlHsE/2xakDOTgJmknPb4sF9pKWt8fANTnLO/0IkJmloJKUCUiES3yRbPygz6hOFYurvn1gOYW5jP5xAbaSi+BZaeehUww9AtIzrkkmHbqNiN64XHRiS4Zc4m/TgWQoA45oNC/tWb2xgOyDbAegMnOhp+aUevPSr4XKf9usjuM7VmDl4GAA5iP9WCpJVVHYN1L3JOs3QrzlzoWiK7wVa2VtXxVKeDAE6YO1GXci6c0qq/U5X/rW5qXEsb/ZuIMP4RXe4YVTCDitmUXu7x9OJN5put/RzuKNIsuKx1D+n/nJQtTg1WQ/zvKMxfbg4HzoxBS9viF8XIti6ZgXukTfkfDF1BfgDY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(366004)(346002)(136003)(396003)(39860400002)(451199015)(2906002)(83380400001)(54906003)(2616005)(66476007)(66556008)(5660300002)(66946007)(26005)(186003)(53546011)(36756003)(8936002)(6506007)(6512007)(478600001)(38100700002)(8676002)(41300700001)(31686004)(6486002)(86362001)(6916009)(4326008)(316002)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dEhkUGpDOTVlS1hvSldtbUlVaVNQQnpKTWdYcTgrdmJQSkpFbFZGRmRHdzNK?= =?utf-8?B?bExZTEh4TGxjSDBNZ2NuUWhGWXNyTXhNdVlZbXlNZFYxZW1INWpuM2tXRUY4?= =?utf-8?B?b3YwRCtaTTAveUo0U0dzdHJ4UU5BUHhVb2xQL1R0aWVYUThXWW9WZnd3WlZi?= =?utf-8?B?MWI2VkxhamdJYzNvSU1MUWdBZkYxTG9qeVlGNFZlamRoRHJaYis5QVExV3Uw?= =?utf-8?B?a1AveXcrT2E5OVROdVR6YTFTcWdDcmt3MXI3RTZxdHgyOXVLR2hLQnlySEhk?= =?utf-8?B?VWpxVjk4TXJEQk1hK0hFQ2szY0JqVzFkVDhKbG9yS2hyR0RNRXNKSU8xQ3M0?= =?utf-8?B?d0VYem5wcktJVitjV2NMYit5ZitaQU51emlMb2c0TTdOSXpMOGZYaEhaYU00?= =?utf-8?B?V3hlNUFiR3JWYUo3Ni9qYW5SSURIZDFid1lRZDM2N3lDUFhsZUNlWUV5Q0d0?= =?utf-8?B?c1ZpaWNUQldIanl3aU9ZU0twV1pTZDhMNmdYWldGVDZSd3hNcVV6UHRNcmZD?= =?utf-8?B?M2hOWktUMzhnbDlUb2tJYXFob0ltOGtGVzRvTFdQclRiYm1iRWZvRUN0Uk5S?= =?utf-8?B?NmxaNFgrdDRpVlE3UU1kdTBqVThBVVdodWZmMmxReHdJMUd2ZWJyUllnVGl2?= =?utf-8?B?VVJMbm5jMnEyaTZ3aVNadDU3aDJoYTR6VTlWYXBDdHBMUlF4TE1rVGtHb2xW?= =?utf-8?B?dWVjakhUUGtVb1ErYWxXZFVzUGJCRGFwblB5blE3UVNWdGxHTUo3SDVYQitj?= =?utf-8?B?a2toTmZWMVRwVFdBTXorTHlrQmtkWjExaTlpbzUyaVlJQTZVZFNpQU5Yc0lk?= =?utf-8?B?N1JVVWw5c2VKZmh6R2M0cEdMbWVzclZWNDVVTTB6bTNvZFZmSE41Vk4ydkc4?= =?utf-8?B?bnlpbEJkbGEvcjZJc0psWnpRaVVBVlZBejAzYmJrVmRveXB5bVV0aWJxUThx?= =?utf-8?B?V2ozdUFTWEtKQjBwVy83bURFbVhXRmYwMjB3dmhBRFg0ci9EQjI4VHd0a0Rj?= =?utf-8?B?Vmh0dEdmdUw1VXJYWjNrdXEybThVUEhibDVuMVl3cTBKdWpiVUhibjFzcVFp?= =?utf-8?B?clUvZzc5QjVGSnZYUmZrMmV0Q1FrR0R3ZTFyU0hLTnlVWSt1K0R5YXZEbGsy?= =?utf-8?B?ZGpoTlJhUCtHbmlHeGNwUi9GTVJsd2tzN3ZHaml4NnVSQ3pGTkhIdy84a3h5?= =?utf-8?B?aENEUFRrQm9Dbkxjc056dGdkZnhYMU12RFVrTWgzMkJTQW00a3J5dmZsMS8v?= =?utf-8?B?YnR5cDlOdjlDV3lkMytTeERuSTFtRTVLbVNxQVFGUVRTSGVscVUrNFpsdTNF?= =?utf-8?B?ZEd3YmFreGk0Z1BpZXJsRlNNVTViTWQxU0htcVdscC9IVi9rMW90ekZ3bkIw?= =?utf-8?B?QXBxMW1PTDlCTmJUaFRoWm5ySjRmeisrcDIrNUVqN3M3M080MFQ2Wlg2QW9Q?= =?utf-8?B?RHRSOFppWWpwR2QyQkxOaldvTytVOUgxSmVrc1FnSU91YUwyRUNQWGFPZlhh?= =?utf-8?B?K3Q0c3RueWFlckdpUlFsbERCejNsTS9mS21oMytKQ3p3UWhENllnYUUyWXVX?= =?utf-8?B?ZThEWW41UzhXK0dObHdhRGxFdG9DS3BybnJiWVE0QmU0MjhSK3hiVmFJZ0k0?= =?utf-8?B?dkljVWp5MWVoVjVGQnJyNFFSTU4vbkpkRm8wMzlucGlkNlJIRmVwRWpPM0NE?= =?utf-8?B?UHlGTVk2cjJwcUg0cFVZNWNSYUo3cFgwZGdEa250RXRaQktMd1F1UERlTXp5?= =?utf-8?B?K1JOeXBCT3ZONFhoU1pqNmI4cXRJZHNLQ3Q5ZTNuY3F1RDUzdjc4SWI5cys5?= =?utf-8?B?V2FKdUMwZ2dNT0NWQVI0MDRTdGxDUXlER2hOU1c3TEo3OFA0d29qUUNhcUZr?= =?utf-8?B?N3F1ckZaeW5vOUR0MU9VdTNDQUVRTnN0WVoyc1c2OGg3SHZMa0lMbWpnVzFP?= =?utf-8?B?ZHlYSzUrWVJ4M0NOb1dxYnQvNmdtV0ZEY0o0VCtDWlUwTnJGUnZxVVMvWW9l?= =?utf-8?B?ZTFESVo4clVSUU5ab3U0MjltRlVKZUFmdWxvVGhNSitWVW1qc21mb0p0L044?= =?utf-8?B?aUQrYWFBUnU4S0M0ZlZSdHJ3TS9aRkVXZmNITE4xaUNwcDZaemFlUndSSENm?= =?utf-8?Q?ksk7j8bBxRLBmMAjq4eAPhbd5?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5d419066-a30e-4949-112b-08daf226ae6d X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2023 09:48:37.6971 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 393mA7+MeNtuYYLN0SZcNVhchjH8HpROUNfP/+o4r1ZvN0nynSqDkYsOjycMGGNBpq0Oc9D5+F2yb8Zcw6AIbQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8908 On 06.01.2023 03:03, Andrew Cooper wrote: > On 05/01/2023 4:05 pm, Jan Beulich wrote: >> The "n" input is a GFN value and hence bounded by the physical address >> bits in use on a system. > > The one case where this isn't obviously true is in sh_audit().  It comes > from a real MFN in the system, not a GFN, which will have the same > property WRT PADDR_BITS. I'm afraid I was more wrong with that than just for the audit case. Only FL1 shadows use GFNs. All other shadows us MFNs. I'll update the sentence. >> The hash quality won't improve by also >> including the upper always-zero bits in the calculation. To keep things >> as compile-time-constant as they were before, use PADDR_BITS (not >> paddr_bits) for loop bounding. This reduces loop iterations from 8 to 5. > > While this is all true, you'll get a much better improvement by not > forcing 'n' onto the stack just to access it bytewise.  Right now, the > loop looks like: > > : >     48 83 ec 10                 sub    $0x10,%rsp >     49 89 c9                    mov    %rcx,%r9 >     41 89 d0                    mov    %edx,%r8d >     48 8d 44 24 08              lea    0x8(%rsp),%rax >     48 8d 4c 24 10              lea    0x10(%rsp),%rcx >     48 89 74 24 08              mov    %rsi,0x8(%rsp) >     0f 1f 80 00 00 00 00        nopl   0x0(%rax) > /-> 0f b6 10                    movzbl (%rax),%edx > |   48 83 c0 01                 add    $0x1,%rax > |   45 69 c0 3f 00 01 00        imul   $0x1003f,%r8d,%r8d > |   41 01 d0                    add    %edx,%r8d > |   48 39 c1                    cmp    %rax,%rcx > \-- 75 ea                       jne    ffff82d0402efda0 > > > > which doesn't even have a compile-time constant loop bound.  It's > runtime calculated by the second lea constructing the upper pointer bound. > > Given this further delta: > > diff --git a/xen/arch/x86/mm/shadow/common.c > b/xen/arch/x86/mm/shadow/common.c > index 4a8bcec10fe8..902c749f2724 100644 > --- a/xen/arch/x86/mm/shadow/common.c > +++ b/xen/arch/x86/mm/shadow/common.c > @@ -1397,13 +1397,12 @@ static unsigned int shadow_get_allocation(struct > domain *d) >  typedef u32 key_t; >  static inline key_t sh_hash(unsigned long n, unsigned int t) >  { > -    unsigned char *p = (unsigned char *)&n; >      key_t k = t; >      int i; >   >      BUILD_BUG_ON(PADDR_BITS > BITS_PER_LONG + PAGE_SHIFT); > -    for ( i = 0; i < (PADDR_BITS - PAGE_SHIFT + 7) / 8; i++ ) > -        k = p[i] + (k << 6) + (k << 16) - k; > +    for ( i = 0; i < (PADDR_BITS - PAGE_SHIFT + 7) / 8; i++, n >>= 8 ) > +        k = (uint8_t)n + (k << 6) + (k << 16) - k; >   >      return k % SHADOW_HASH_BUCKETS; >  } > > the code gen becomes: > > : >     41 89 d0                    mov    %edx,%r8d >     49 89 c9                    mov    %rcx,%r9 >     b8 05 00 00 00              mov    $0x5,%eax > /-> 45 69 c0 3f 00 01 00        imul   $0x1003f,%r8d,%r8d > |   40 0f b6 d6                 movzbl %sil,%edx > |   48 c1 ee 08                 shr    $0x8,%rsi > |   41 01 d0                    add    %edx,%r8d > |   83 e8 01                    sub    $0x1,%eax > \-- 75 e9                       jne    ffff82d0402efd8b > > > with an actual constant loop bound, and not a memory operand in sight.  > This form (even at 8 iterations) will easily execute faster than the > stack-spilled form. Oh, yes, good idea. Will adjust. Jan From xen-devel-bounces@lists.xenproject.org Mon Jan 09 09:50:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 09:50:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473465.734084 (Exim 4.92) (envelope-from ) id 1pEong-0005c6-8n; Mon, 09 Jan 2023 09:50:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473465.734084; Mon, 09 Jan 2023 09:50:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEong-0005bz-6B; Mon, 09 Jan 2023 09:50:40 +0000 Received: by outflank-mailman (input) for mailman id 473465; Mon, 09 Jan 2023 09:50:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEone-0005bt-UQ for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 09:50:38 +0000 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [2a00:1450:4864:20::130]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1118a50e-9003-11ed-b8d0-410ff93cb8f0; Mon, 09 Jan 2023 10:50:37 +0100 (CET) Received: by mail-lf1-x130.google.com with SMTP id bq39so12138925lfb.0 for ; Mon, 09 Jan 2023 01:50:37 -0800 (PST) Received: from fedora.. ([195.234.76.149]) by smtp.gmail.com with ESMTPSA id f16-20020a056512361000b004cb27d8edd1sm1535009lfs.85.2023.01.09.01.50.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 01:50:35 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1118a50e-9003-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=2Jj8LyZa6YPi4Y5Mz4SQwLw+I42jookzrxO26/BlN8E=; b=llpOJVMyHx+hqMj5pMpxIXiU+htmQ7fma61iraWV72ZjNHDWRIWSllbF+5ubvNGIfS K3l9U7PtOK5+zYjsGx9cpnpX0hjMLkMegvEaLrt9h8dxVcJoW0eiN1RUdgqn0+qVn1vb BnRK10fAYiohdPbq9dOmiiWbZD0ptqa7BX3ClMOdXwzJz8yVqMdsBjlwqECqh/tzZFGM 3QG9JrWIBHDL2Xs1lVXwyDeWGLQtfE5C9RvyyVF++fI+ntJGuXbm1wr63ZU+qMvHSO01 Q8ARP0/eziV9SerpRxMp0OBNJBcXKRV8d5jg0Di3wYWsGPGCoXPY8Sr0vTP9ihb2+flz FYmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2Jj8LyZa6YPi4Y5Mz4SQwLw+I42jookzrxO26/BlN8E=; b=P2cTZeTkiWpwOiEGzY61D8saRF3fDyNXHUhkg7FoofzHW4ykA3XEy1UHWKro/ZteJA 1j3Z0UMloZ3R/Jfa3ZXNIO8bJ3BQnQhszDjra3tMl+dvPo9nTQgzuk9ceObwBWFumnTZ 5MBA8W0T/PUCrEIu1tjc/Fr2NMRAhLNvFG/X2a9X5CEmHd90dVl6Q2UegSVCVR1XEcV3 DAG5hrXcuetDTqjBZBAqCDi2cR5EHrr+fxit5TbyYuJffocZBQmaPVg1wzLwckoDBjLo D4mFlowRrb0D7JyNmNZYWIL1pL0wB+URKxrqc3mQgn4c37/4WU7azTjeNfPbyUIE7ONe ZukA== X-Gm-Message-State: AFqh2kpqjK3Q+kXI8mfltGrw3uv1sQ1IObGMFJaBlwgBqKG1FFnsksE1 EIp9JSuvwQJh7VI83Uglm5ErVy/c796gg1lP X-Google-Smtp-Source: AMrXdXup80ZX2b/beLFfkhYOyCb8R29k7q8npzgK5+aPorkhb7HhFH98ZY/WPMv4yf4i0qwHpyHASQ== X-Received: by 2002:a05:6512:2393:b0:4a4:68b9:1a00 with SMTP id c19-20020a056512239300b004a468b91a00mr21786223lfv.40.1673257835889; Mon, 09 Jan 2023 01:50:35 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Doug Goldstein Subject: [PATCH] automation: add qemu-system-riscv to riscv64.dockerfile Date: Mon, 9 Jan 2023 11:50:32 +0200 Message-Id: <8badde729e97ef6508204c5229199b7247c7a3da.1673257832.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit qemu-system-riscv will be used to run RISC-V Xen binary and gather logs for smoke tests. Signed-off-by: Oleksii Kurochko --- automation/build/archlinux/riscv64.dockerfile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/automation/build/archlinux/riscv64.dockerfile b/automation/build/archlinux/riscv64.dockerfile index ff8b2b955d..375c78ecd5 100644 --- a/automation/build/archlinux/riscv64.dockerfile +++ b/automation/build/archlinux/riscv64.dockerfile @@ -9,7 +9,8 @@ RUN pacman --noconfirm --needed -Syu \ inetutils \ riscv64-linux-gnu-binutils \ riscv64-linux-gnu-gcc \ - riscv64-linux-gnu-glibc + riscv64-linux-gnu-glibc \ + qemu-system-riscv # Add compiler path ENV CROSS_COMPILE=riscv64-linux-gnu- -- 2.38.1 From xen-devel-bounces@lists.xenproject.org Mon Jan 09 10:01:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 10:01:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473471.734095 (Exim 4.92) (envelope-from ) id 1pEoyE-0007EN-8M; Mon, 09 Jan 2023 10:01:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473471.734095; Mon, 09 Jan 2023 10:01:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEoyE-0007EG-5a; Mon, 09 Jan 2023 10:01:34 +0000 Received: by outflank-mailman (input) for mailman id 473471; Mon, 09 Jan 2023 10:01:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEoyC-0007EA-Ar for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 10:01:32 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEoyB-0001fy-Vb; Mon, 09 Jan 2023 10:01:31 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=[192.168.1.158]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pEoyB-0002YM-Pm; Mon, 09 Jan 2023 10:01:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=dfINzAzh++LGzgBuhBGmyhM9SrR6FkgJApXtlpHnQNU=; b=vqWeODwC/lqjLuIrPBOXCv02it AGBEd0fi/1DEqgKSbdplhKfHBjegu0UKjZRPkUuWzQvWkqgjn5W1sjINC249sDUXKAif//x0fa1E6 xx6CINl1qff8tE0fCbPM1phqFqkZwmJz2v0D/madtDe8uF7KTBqpCfYwrz7EqJSl6dJs=; Message-ID: <1ff6107c-bcfe-353a-04ed-b429ac65a81d@xen.org> Date: Mon, 9 Jan 2023 10:01:29 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v1 01/13] xen/arm: re-arrange the static shared memory region Content-Language: en-US To: Penny Zheng , "xen-devel@lists.xenproject.org" Cc: Wei Chen , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20221115025235.1378931-1-Penny.Zheng@arm.com> <20221115025235.1378931-2-Penny.Zheng@arm.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Penny, On 09/01/2023 07:48, Penny Zheng wrote: >> -----Original Message----- >> From: Julien Grall >> Sent: Sunday, January 8, 2023 7:44 PM >> To: Penny Zheng ; xen-devel@lists.xenproject.org >> Cc: Wei Chen ; Stefano Stabellini >> ; Bertrand Marquis ; >> Volodymyr Babchuk >> Subject: Re: [PATCH v1 01/13] xen/arm: re-arrange the static shared memory >> region >> On 15/11/2022 02:52, Penny Zheng wrote: >>> This commit re-arranges the static shared memory regions into a >>> separate array shm_meminfo. And static shared memory region now >> would >>> have its own structure 'shm_membank' to hold all shm-related members, >>> like shm_id, etc, and a pointer to the normal memory bank 'membank'. >>> This will avoid continuing to grow 'membank'. >>> >>> Signed-off-by: Penny Zheng >>> --- >>> xen/arch/arm/bootfdt.c | 40 +++++++++++++++++++------------ >>> xen/arch/arm/domain_build.c | 35 ++++++++++++++++----------- >>> xen/arch/arm/include/asm/kernel.h | 2 +- >>> xen/arch/arm/include/asm/setup.h | 16 +++++++++---- >>> 4 files changed, 59 insertions(+), 34 deletions(-) >>> >>> diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c index >>> 6014c0f852..ccf281cd37 100644 >>> --- a/xen/arch/arm/bootfdt.c >>> +++ b/xen/arch/arm/bootfdt.c >>> @@ -384,6 +384,7 @@ static int __init process_shm_node(const void *fdt, >> int node, >>> const __be32 *cell; >>> paddr_t paddr, gaddr, size; >>> struct meminfo *mem = &bootinfo.reserved_mem; >> >> After this patch, 'mem' is barely going to be used. So I would recommend to >> remove it or restrict the scope. >> > > Hope I understand correctly, you are saying that all static shared memory bank will be > described as "struct shm_membank". That's right. > However when host address is provided, we still need an instance of "struct membank" > to refer to in "bootinfo.reserved_mem". Only in this way, it could be initialized properly in > as static pages. > That's why I put a "struct membank*" pointer in "struct shm_membank" to refer to the > same object. I wasn't talking about the field in "struct shm_membank". Instead, I was referring to the local variable: struct meminfo *mem = &bootinfo.reserved_mem; AFAICT, the only use after this patch is when you add a new bank in shm_mem. So you could restrict the scope of the local variable. > If I removed instance in bootinfo.reserved_mem, a few more path needs to be updated, like > Init_staticmem_pages, dt_unreserved_regions, etc > >> This will make easier to confirm that most of the use of 'mem' have been >> replaced with 'shm_mem' and reduce the risk of confusion between the two >> (the name are quite similar). >> >> [...] >> >>> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c >>> index bd30d3798c..c0fd13f6ed 100644 >>> --- a/xen/arch/arm/domain_build.c >>> +++ b/xen/arch/arm/domain_build.c >>> @@ -757,20 +757,20 @@ static int __init >> acquire_nr_borrower_domain(struct domain *d, >>> { >>> unsigned int bank; >>> >>> - /* Iterate reserved memory to find requested shm bank. */ >>> - for ( bank = 0 ; bank < bootinfo.reserved_mem.nr_banks; bank++ ) >>> + /* Iterate static shared memory to find requested shm bank. */ >>> + for ( bank = 0 ; bank < bootinfo.shm_mem.nr_banks; bank++ ) >>> { >>> - paddr_t bank_start = bootinfo.reserved_mem.bank[bank].start; >>> - paddr_t bank_size = bootinfo.reserved_mem.bank[bank].size; >>> + paddr_t bank_start = bootinfo.shm_mem.bank[bank].membank- >>> start; >>> + paddr_t bank_size = >>> + bootinfo.shm_mem.bank[bank].membank->size; >> >> I was expecting a "if (type == MEMBANK_STATIC_DOMAIN) ..." to be >> removed. But it looks like there was none. I guess that was a mistake in the >> existing code? >> > > Oh, you're right, the type shall also be checked. Just to clarify, with this patch you don't need to check the type. I was pointing out a latent error in the existing code. > >>> >>> if ( (pbase == bank_start) && (psize == bank_size) ) >>> break; >>> } >>> >>> - if ( bank == bootinfo.reserved_mem.nr_banks ) >>> + if ( bank == bootinfo.shm_mem.nr_banks ) >>> return -ENOENT; >>> >>> - *nr_borrowers = >> bootinfo.reserved_mem.bank[bank].nr_shm_borrowers; >>> + *nr_borrowers = bootinfo.shm_mem.bank[bank].nr_shm_borrowers; >>> >>> return 0; >>> } >>> @@ -907,11 +907,18 @@ static int __init >> append_shm_bank_to_domain(struct kernel_info *kinfo, >>> paddr_t start, paddr_t size, >>> const char *shm_id) >>> { >>> + struct membank *membank; >>> + >>> if ( kinfo->shm_mem.nr_banks >= NR_MEM_BANKS ) >>> return -ENOMEM; >>> >>> - kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].start = start; >>> - kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].size = size; >>> + membank = xmalloc_bytes(sizeof(struct membank)); >> >> You allocate memory but never free it. However, I think it would be better to >> avoid the dynamic allocation. So I would consider to not use the structure >> shm_membank and instead create a specific one for the domain construction. >> > > True, a local variable "struct meminfo shm_banks" could be introduced only > for domain construction in function construct_domU Hmmm... I didn't suggest to introduce a local variable. I would still much prefer if we keep using 'kinfo' because we keep all the domain building information in one place. So ``struct meninfo`` should want to be defined in ``kinfo``. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Jan 09 10:07:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 10:07:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473477.734106 (Exim 4.92) (envelope-from ) id 1pEp49-0007s8-TP; Mon, 09 Jan 2023 10:07:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473477.734106; Mon, 09 Jan 2023 10:07:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEp49-0007s1-Qp; Mon, 09 Jan 2023 10:07:41 +0000 Received: by outflank-mailman (input) for mailman id 473477; Mon, 09 Jan 2023 10:07:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEp49-0007rv-8t for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 10:07:41 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEp48-0001lq-UR; Mon, 09 Jan 2023 10:07:40 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=[192.168.1.158]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pEp48-0002mi-OT; Mon, 09 Jan 2023 10:07:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=k5BdFwjEDTMlEnnae9Dcz9y3S/+ffqN3Ib5N2Jhcr9Y=; b=ufQqEnTzUhf+V5fqms0QRn46Vz MfLbjmIZtZrmNFaqX9JFTw2fy0ZS/cSm7E+bXehMhQE4nTR61MpCsGJ+1G+Ew9KeoMcnbv83MEpxP pX/xSSN6MD+M5DTfktTCgMif8ynGsmYTUQCByTwqd+r3cJZM1Or9xLYP76dedIEPUwhk=; Message-ID: <23983bc4-8868-dfed-d58d-ca6baa6d05d4@xen.org> Date: Mon, 9 Jan 2023 10:07:39 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v1 05/13] xen/arm: allocate shared memory from heap when host address not provided Content-Language: en-US To: Penny Zheng , "xen-devel@lists.xenproject.org" Cc: Wei Chen , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20221115025235.1378931-1-Penny.Zheng@arm.com> <20221115025235.1378931-6-Penny.Zheng@arm.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Penny, On 09/01/2023 07:50, Penny Zheng wrote: >> -----Original Message----- >> From: Julien Grall >> Sent: Sunday, January 8, 2023 8:23 PM >> To: Penny Zheng ; xen-devel@lists.xenproject.org >> Cc: Wei Chen ; Stefano Stabellini >> ; Bertrand Marquis ; >> Volodymyr Babchuk >> Subject: Re: [PATCH v1 05/13] xen/arm: allocate shared memory from heap >> when host address not provided >> >> Hi Penny, >> > > Hi Julien, > >> On 15/11/2022 02:52, Penny Zheng wrote: >>> when host address is not provided in "xen,shared-mem", we let Xen >>> allocate requested shared memory from heap, and once the shared >> memory >>> is allocated, it will be marked as static(PGC_static), which means >>> that it will be reserved as static memory, and will not go back to heap even >> on freeing. >> >> Please don't move pages from the {xen,dom}heap to the static heap. If you >> need to keep the pages for longer, then get an extra reference so they will >> not be released. >> >>> >>> Signed-off-by: Penny Zheng >>> --- >>> xen/arch/arm/domain_build.c | 83 >> ++++++++++++++++++++++++++++++++++++- >>> 1 file changed, 82 insertions(+), 1 deletion(-) >>> >>> +static int __init allocate_shared_memory(struct shm_membank >> *shm_membank, >>> + paddr_t psize) { >>> + struct meminfo *banks; >>> + int ret; >>> + >>> + BUG_ON(shm_membank->mem.banks.meminfo != NULL); >>> + >>> + banks = xmalloc_bytes(sizeof(struct meminfo)); >> >> Where is this freed? >> > > These kinds of info will be only used in boot-time, so maybe I shall > free them in init_done()? I don't think you can free it in init_done() because we don't keep a pointer to kinfo past construct_dom*(). > Or just after process_shm() ? This might work. But I think it would be better to avoid the dynamic memory allocation if we can. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Jan 09 10:57:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 10:57:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473492.734126 (Exim 4.92) (envelope-from ) id 1pEpqb-0004ui-Tc; Mon, 09 Jan 2023 10:57:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473492.734126; Mon, 09 Jan 2023 10:57:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEpqb-0004ub-Q9; Mon, 09 Jan 2023 10:57:45 +0000 Received: by outflank-mailman (input) for mailman id 473492; Mon, 09 Jan 2023 10:57:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEpqa-0004uV-Pl for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 10:57:44 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEpqa-0002tO-Fc; Mon, 09 Jan 2023 10:57:44 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=[192.168.1.158]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pEpqa-0004em-8b; Mon, 09 Jan 2023 10:57:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=DisyklBe5soDqZmTSfIpDs6EqXU/3Me8FA8/h5eys9I=; b=Qph4OWtpGLVxVOXnm5PrShrxF7 qRyy02FRJnJykqEouy1kzDF51o2Cgq10ynAV2t+R7sLNfqwMmpF2hXAznUqjoa9BIYio0m+S3B8zY 0S3IHpgTydzLQLUekLLAHCgjcevxP9kymFypkMtUmWAjZ8MLO2FeJoLZDW+PNOIibLSE=; Message-ID: <6db41bd2-ab71-422a-4235-a9209e984915@xen.org> Date: Mon, 9 Jan 2023 10:57:42 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v1 06/13] xen/arm: assign shared memory to owner when host address not provided Content-Language: en-US To: Penny Zheng , "xen-devel@lists.xenproject.org" Cc: Wei Chen , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20221115025235.1378931-1-Penny.Zheng@arm.com> <20221115025235.1378931-7-Penny.Zheng@arm.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 09/01/2023 07:49, Penny Zheng wrote: > Hi Julien Hi Penny, > Happy new year~~~~ Happy new year too! >> -----Original Message----- >> From: Julien Grall >> Sent: Sunday, January 8, 2023 8:53 PM >> To: Penny Zheng ; xen-devel@lists.xenproject.org >> Cc: Wei Chen ; Stefano Stabellini >> ; Bertrand Marquis ; >> Volodymyr Babchuk >> Subject: Re: [PATCH v1 06/13] xen/arm: assign shared memory to owner >> when host address not provided >> >> Hi, >> >> On 15/11/2022 02:52, Penny Zheng wrote: >>> @@ -922,33 +927,82 @@ static mfn_t __init >> acquire_shared_memory_bank(struct domain *d, >>> d->max_pages += nr_pfns; >>> >>> smfn = maddr_to_mfn(pbase); >>> - res = acquire_domstatic_pages(d, smfn, nr_pfns, 0); >>> - if ( res ) >>> + page = mfn_to_page(smfn); >>> + /* >>> + * If page is allocated from heap as static shared memory, then we just >>> + * assign it to the owner domain >>> + */ >>> + if ( page->count_info == (PGC_state_inuse | PGC_static) ) >> I am a bit confused how this can help differentiating becaPGC_state_inuse is >> 0. So effectively, you are checking that count_info is equal to PGC_static. >> > > When host address is provided, the host address range defined in > xen,static-mem will be stored as a "struct membank" with type > of "MEMBANK_STATIC_DOMAIN" in "bootinfo.reserved_mem" > Then it will be initialized as static memory through "init_staticmem_pages" > So here its page->count_info is PGC_state_free |PGC_static. > For pages allocated from heap, its page state is different, being PGC_state_inuse. > So actually, we are checking page state to tell the difference . Ok. This is definitely not obvious from the code. But I think this is a very fragile assumption. Instead, it would be better if we allocate the memory in acquire_shared_memory_bank() when the host address is not provided. > >> But as I wrote in a previous patch, I don't think you should convert >> {xen,dom}heap pages to a static pages. >> > > I agree that taking reference could also prevent giving these pages back to heap. > But may I ask what is your concern on converting {xen,dom}heap pages to a static pages? A few reasons: 1) I consider them as two distinct allocators. So far they have the same behavior, but in the future this may change. 2) If the page is freed you really don't want the domain to be able to re-use the page for a different purpose. I realize that 2) is already a problem today with static pages. So I think the best is to ensure that pages allocated for shared memory never reach the any of the allocators. > >> [...] >> >>> +static int __init assign_shared_memory(struct domain *d, >>> + struct shm_membank *shm_membank, >>> + paddr_t gbase) { >>> + int ret = 0; >>> + unsigned long nr_pages, nr_borrowers; >>> + struct page_info *page; >>> + unsigned int i; >>> + struct meminfo *meminfo; >>> + >>> + /* Host address is not provided in "xen,shared-mem" */ >>> + if ( shm_membank->mem.banks.meminfo ) >>> + { >>> + meminfo = shm_membank->mem.banks.meminfo; >>> + for ( i = 0; i < meminfo->nr_banks; i++ ) >>> + { >>> + ret = acquire_shared_memory(d, >>> + meminfo->bank[i].start, >>> + meminfo->bank[i].size, >>> + gbase); >>> + if ( ret ) >>> + return ret; >>> + >>> + gbase += meminfo->bank[i].size; >>> + } >>> + } >>> + else >>> + { >>> + ret = acquire_shared_memory(d, >>> + shm_membank->mem.bank->start, >>> + shm_membank->mem.bank->size, gbase); >>> + if ( ret ) >>> + return ret; >>> + } >> >> Looking at this change and... >> >>> + >>> /* >>> * Get the right amount of references per page, which is the number of >>> * borrower domains. >>> @@ -984,23 +1076,37 @@ static int __init assign_shared_memory(struct >> domain *d, >>> * So if the borrower is created first, it will cause adding pages >>> * in the P2M without reference. >>> */ >>> - page = mfn_to_page(smfn); >>> - for ( i = 0; i < nr_pages; i++ ) >>> + if ( shm_membank->mem.banks.meminfo ) >>> { >>> - if ( !get_page_nr(page + i, d, nr_borrowers) ) >>> + meminfo = shm_membank->mem.banks.meminfo; >>> + for ( i = 0; i < meminfo->nr_banks; i++ ) >>> { >>> - printk(XENLOG_ERR >>> - "Failed to add %lu references to page %"PRI_mfn".\n", >>> - nr_borrowers, mfn_x(smfn) + i); >>> - goto fail; >>> + page = mfn_to_page(maddr_to_mfn(meminfo->bank[i].start)); >>> + nr_pages = PFN_DOWN(meminfo->bank[i].size); >>> + ret = add_shared_memory_ref(d, page, nr_pages, nr_borrowers); >>> + if ( ret ) >>> + goto fail; >>> } >>> } >>> + else >>> + { >>> + page = mfn_to_page( >>> + maddr_to_mfn(shm_membank->mem.bank->start)); >>> + nr_pages = shm_membank->mem.bank->size >> PAGE_SHIFT; >>> + ret = add_shared_memory_ref(d, page, nr_pages, nr_borrowers); >>> + if ( ret ) >>> + return ret; >>> + } >> >> ... this one. The code to deal with a bank is exactly the same. But you need >> the duplication because you special case "one bank". >> >> As I wrote in a previous patch, I don't think we should special case it. >> If the concern is memory usage, then we should look at reworking meminfo >> instead (or using a different structure). >> > > A few concerns explained why I didn't choose "struct meminfo" over two > pointers "struct membank*" and "struct meminfo*". > 1) memory usage is the main reason. > If we use "struct meminfo" over the current "struct membank*" and "struct meminfo*", > "struct shm_meminfo" will become a array of 256 "struct shm_membank", with > "struct shm_membank" being also an 256-item array, that is 256 * 256, too big for > a structure and If I remembered clearly, it will lead to "more than PAGE_SIZE" compiling error. I am not aware of any place where we would restrict the size of kinfo in upstream. Can you give me a pointer? > FWIT, either reworking meminfo or using a different structure, are both leading to sizing down > the array, hmmm, I don't know which size is suitable. That's why I prefer pointer > and dynamic allocation. I would expect that in most cases, you will need only one bank when the host address is not provided. So I think this is a bit odd to me to impose a "large" allocation for them. > 2) If we use "struct meminfo*" over the current "struct membank*" and "struct meminfo*", > we will need a new flag to differentiate two scenarios(host address provided or not), As > the special case "struct membank*" is already helping us differentiate. > And since when host address is provided, the related "struct membank" also needs to be > reserved in "bootinfo.reserved_mem". That's why I used pointer " struct membank*" to > avoid memory waste. I am confused... Today you are defining as: struct { struct membank *; struct { struct meminfo *; unsigned long total_size; } } So on arm64 host, you would use 24 bytes. If we were using an union instead. We would use 16 bytes. Adding a 32-bit fields, would bring to 20 bytes (assuming we can re-use a padding). Therefore, there is no memory waste here with a flag... Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Jan 09 11:10:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 11:10:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473500.734137 (Exim 4.92) (envelope-from ) id 1pEq2k-0007He-2c; Mon, 09 Jan 2023 11:10:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473500.734137; Mon, 09 Jan 2023 11:10:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEq2j-0007HX-WC; Mon, 09 Jan 2023 11:10:18 +0000 Received: by outflank-mailman (input) for mailman id 473500; Mon, 09 Jan 2023 11:10:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEq2i-0007HN-6z; Mon, 09 Jan 2023 11:10:16 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEq2i-00038n-4n; Mon, 09 Jan 2023 11:10:16 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEq2h-0000oq-Lg; Mon, 09 Jan 2023 11:10:15 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pEq2h-0004ao-LI; Mon, 09 Jan 2023 11:10:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=F7ACoF2OZCLPMZoWzsjW2slpCkD72ziB/ykI8p9d6m4=; b=zPFcgQxQFCDl0T4TVcuKDVyOM6 xA/QS+EON76UGznQqYrxWOOYJV5xmS7j8KkGcL2BS+vA0xtUdg/7ZxUNns3gjk1XcI3HhHRUBDGbB QKtFbJoQcIil0L7gY6Olx1EuzjwrOv6O6mX0KJr59BO/QiwXtkXMR7DZDbaRthvp46UI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 175634: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=1fe4fd6f5cad346e598593af36caeadc4f5d4fa9 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Mon, 09 Jan 2023 11:10:15 +0000 flight 175634 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/175634/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine 8 reboot fail REGR. vs. 173462 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux 1fe4fd6f5cad346e598593af36caeadc4f5d4fa9 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 93 days Failing since 173470 2022-10-08 06:21:34 Z 93 days 195 attempts Testing same since 175634 2023-01-09 01:40:59 Z 0 days 1 attempts ------------------------------------------------------------ 3317 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 505645 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Jan 09 11:11:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 11:11:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473509.734148 (Exim 4.92) (envelope-from ) id 1pEq3Z-0007rz-HC; Mon, 09 Jan 2023 11:11:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473509.734148; Mon, 09 Jan 2023 11:11:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEq3Z-0007rs-EP; Mon, 09 Jan 2023 11:11:09 +0000 Received: by outflank-mailman (input) for mailman id 473509; Mon, 09 Jan 2023 11:11:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEq3X-0007rP-DZ for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 11:11:07 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEq3W-0003AP-VX; Mon, 09 Jan 2023 11:11:06 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=[192.168.1.158]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pEq3W-0005QZ-Pg; Mon, 09 Jan 2023 11:11:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=jLnrsMX/pCyW46cSp4wgU/f2FHoQ8Rm/20It4O8+GC8=; b=qwUKTfCHQclWFAHe3ZmCwvqcBd 06+n2WR1UnIaPq7+t1BJoKYHH3a0mg6mer6lsuNnPI50YnMqLyt8adP0KZhOBNybboLiF+W4nmcac 42me4AxxdRKNlIQMkywhoQ/2aJ4JnV9Y5h4O7gJIEMWBbjjolMO7i6qCCptQqFMSUf+M=; Message-ID: <5531505f-b04b-7b70-68da-18d804790c25@xen.org> Date: Mon, 9 Jan 2023 11:11:04 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v1 4/8] xen/riscv: introduce sbi call to putchar to console Content-Language: en-US To: Oleksii , xen-devel@lists.xenproject.org Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis References: <09da5a3184242152af6af060720a007738a55d6e.1673009740.git.oleksii.kurochko@gmail.com> <0475c058d0655f5b7b245f19b20c5ef0f14b3618.camel@gmail.com> From: Julien Grall In-Reply-To: <0475c058d0655f5b7b245f19b20c5ef0f14b3618.camel@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Oleksii, On 09/01/2023 09:04, Oleksii wrote: > On Fri, 2023-01-06 at 13:40 +0000, Julien Grall wrote: >> Hi, >> >> On 06/01/2023 13:14, Oleksii Kurochko wrote: >>> The patch introduce sbi_putchar() SBI call which is necessary >>> to implement initial early_printk >>> >>> Signed-off-by: Oleksii Kurochko >>> --- >>>   xen/arch/riscv/Makefile          |  1 + >>>   xen/arch/riscv/include/asm/sbi.h | 34 ++++++++++++++++++++++++ >>>   xen/arch/riscv/sbi.c             | 44 >>> ++++++++++++++++++++++++++++++++ >> >> IMHO, it would be better to implement sbi.c in assembly so you can >> use >> print in the console before you jump to C world. >> > I thought that we can live with C version as we set up stack from the > start and then we can call early_printk() from assembly code too. > Is it bad approach? It depends on how early you want to call it. For Arm, we chose to use assembly because the C code may not be PIE (and even with PIE it may need some relocation work). Andrew suggested that this may not be a problem with RISC-V. I have looked a bit more around and notice that the kernel is also calling some C function very early (like setup_vm()). But they ensure that the code is built with -mcmodel=medany. It looks like you are already building Xen with this option. So all looks good for RISC-V. That said, I would suggest to check that __riscv_cmodel_medany is defined in files where you implement C function called from early assembly code. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Jan 09 11:13:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 11:13:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473515.734159 (Exim 4.92) (envelope-from ) id 1pEq68-0008VJ-Tz; Mon, 09 Jan 2023 11:13:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473515.734159; Mon, 09 Jan 2023 11:13:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEq68-0008VC-Qp; Mon, 09 Jan 2023 11:13:48 +0000 Received: by outflank-mailman (input) for mailman id 473515; Mon, 09 Jan 2023 11:13:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEq67-0008V4-UI for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 11:13:48 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2073.outbound.protection.outlook.com [40.107.104.73]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ae9c549e-900e-11ed-b8d0-410ff93cb8f0; Mon, 09 Jan 2023 12:13:45 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB7043.eurprd04.prod.outlook.com (2603:10a6:208:19b::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Mon, 9 Jan 2023 11:13:44 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5986.018; Mon, 9 Jan 2023 11:13:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ae9c549e-900e-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dhbA+xF5F9F0s1xVFYRMqPNzCKXaC1w9xi2LIfUOMOoDpfGAKKEpLCpi2peH3Qx9yAWjd461nOTNGgwGRFiicZW5+VCGg3LLTVJLW4QYdBhsv0jFSCm9tQEBcYFb0oDy62XFhMgBl6kjskJ0z5W+dIZHWD9PsSb0REdbzZt0jIHJ4DXotY1EqU8kJlAVLwwl/ntoFBkF3o5YyRZ96cLG/7VJmiC/QZgio9PYkti/CjERGstwE1dhTPTO9SV4reMANy6Hy4/2mqb4IS38Diyak5YbB2pEwDwtX2CzbAOyZcc+UfWyumz40HWBV43a4UyuFJadppQWZmq0NMNiGYGxjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N7NX/w/IBF0btVz6DIEesT3r76F6LqndQWtRaYgCeiU=; b=AJ8oo8EyeJFy5//LG4xnC/POfw4l54Pqia4MCqO2I+8acB+w4kJ3slG7dxfcF2Y2I2JYjgbxIqc065DsLQlkDPv8O5poXzCDsvrEX9Bn8ZWj7ZPXi1leocp9DdntEGhqyOzGBO/rx8ONARn6UC5pQMcthSt1wQPAM9J9g/wntBStN2eSnGPZI53gNsL1Id/UX7w1qdTX4V9Vm9s6USqqMLuaqHEUb5SN/0gjRwadVzNGIr45x2Hfb1Db/fGXr+Hh4Z7WO7voh+uFhikapFekfv9bn6vUcP4FnKgkDoTeP4b3Ckf2YZqcJ4SjoWBWuDOCYiWpQKZF8lofBO9miyR93g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N7NX/w/IBF0btVz6DIEesT3r76F6LqndQWtRaYgCeiU=; b=iqqUeP7Z/2E+ZgCQG3tUTqyxqN3zhliLWpjsjWyyzDDKiR1P9oDCmaOtBbOBb482eM9y11kAzXdRsuOm8BOjilWzAfMUUxyW+k4NVH0QwmoS7bn00NiMmxDyIUl5K2dmVMq7syyI66LvWLJiVb588jWKqWngRJm/9nkj5wlNlFpqT6J5beqKY6L+7eph7trTTqpRtmEVSFCbhGrUhKM6EwtnD6E5TbwAwXSoNAM0tfqN7FcQC3WO3R1DoOz6vtf8x89UjI76ORf8pwpCzEEJnR+VgFJEBptGJIJG398BkssZWREwGWiNAMgAddfC/gAw2LVgZAuLGoDJTHRMqWwIgw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 9 Jan 2023 12:13:42 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: LBR and Sapphire Rapids Content-Language: en-US To: Andrew Cooper References: <3a80b974-1ddd-2063-863f-8aff3453d545@citrix.com> Cc: xen-devel , Roger Pau Monne From: Jan Beulich In-Reply-To: <3a80b974-1ddd-2063-863f-8aff3453d545@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0077.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM0PR04MB7043:EE_ X-MS-Office365-Filtering-Correlation-Id: b80541d4-406b-44c4-150a-08daf23291dc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dLLpeHc7J4IiVywpeHdNEEVS70oFymKLLWDymlQuUb1xaqkrXmiMjaygX1m6bMvQDj9RQsUYuregeaBpaQ1OYv209+NhZnCmqER0uWFMV21zpeGddt1iPz4th93NLCNHD7g6TElEaoSvbTfjpAb+aQMGuLhXba2ATElLFW34aR/dgkRGROQgbF23BDS5lyMZk5Ax238hsRx7NrEpIKceFguaekA25FuXY/oIq0I4PEHLgUp2XziC2572JrMtjrXcyy77CzeoIy3hfplqkA9iHbyd8cRb72oFtxteqU1rFPz334Lty7z8tCXjVZRk+wX5MogQwFrqW4P7K5iUjwwfXVoMhIzNWss2ooRifj2HkdMEHbVy4LUjW3RXWYQqWpng7Pgbg+2+Wsaa4PeUcinniDsT2Csz2DlZV4lU3tKlN7DjTw7tkW7p+/pNjsXYJQSRcLJj8VGTQul9zn102QnUvu6MNL55hb77QAmFXne/qTDt0/AaNR1kEL5IEgiDEZRn6Qp7+uBJfgXPnl0bvQTnX8xp5f7L6mNsKnnm+ZXfLf4Fdv1sFfScCJgFrnul3z+jPUejRC+nDBXvEqj9yrvzhT8yQWWNKonqMMOi8YvhYupVTxuPQeCUhrOdRPulYnP+uwquye7oaRc160gIV1gsI1uowKdraUC3owNT3onkic65cqlc/WWfRO3b63SSQjNhDSS0c3sRonGtaN4oJiS3WopXQ5LFU2YDMHz5lTnv13U= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(366004)(396003)(39860400002)(136003)(346002)(451199015)(3480700007)(2906002)(83380400001)(54906003)(2616005)(66476007)(66556008)(5660300002)(66946007)(26005)(186003)(53546011)(36756003)(8936002)(4744005)(6506007)(6512007)(478600001)(38100700002)(8676002)(41300700001)(31686004)(6486002)(86362001)(6916009)(4326008)(316002)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MVBweHV0Ynk1YS9jQ0Z3ZFJZaDJ2R0dxRmNSRjlJQUQwNVRtOWY5MkxoM1Ar?= =?utf-8?B?VjJBYzNzeDZGbVpvOWdXRmNqcnAvUW9UYlBMa2Nnc2xzejFuOHhzYlptUTJo?= =?utf-8?B?RDB2eldVRnV6S3AxZEVHZkVCZ280RVpOMkVJNzZJUW5zT0t6YkFYSFFiRjZE?= =?utf-8?B?bGp3dGdvNHJaenEzSHgyV0w0b2ZNeUtWL25xeEtsTU1iSXMrdWNVckJvZisv?= =?utf-8?B?WWhTSkszdjFNT1JFL1hWbzkyTWFOYUdpdE56Vm51b3FYYWhqVWpCOUUzQVFQ?= =?utf-8?B?N1pJNFRnNms5ZE5MamxqSitmaFEyOURMdlhxQ2tKbXFIMVhTeFhBTkdMUlRl?= =?utf-8?B?MmluMDNtNEFiTkdSN2dHLzROL1JWTEdDRWFPUmJ5ZE5Ua1hRQm52M1JiZHd1?= =?utf-8?B?Vk1OV3MxMURCQkJwdzgzaTJ5K0wzNzV4K1FsMCtOTXN0V1JEeitraW11dW0w?= =?utf-8?B?QlErOW9mZmszZjNXajRsTEJiQVJEdUc3ZGVSQjJTN3RSdkRBQzNkNDRJSmpY?= =?utf-8?B?Rlc4dytIMTgxSEtFUzFFV3B6ZzU4QlVCZk1QcFpkS2FmV2h4MkJLVCtSSkVM?= =?utf-8?B?OFd5NVRiR25Sb3Ntay96cTY1RUN5RGs5azNya3kxejlHNFUzeXNaM041MlN4?= =?utf-8?B?NnY2NEZZWDc2ckt4em9EWGNZcVBDNlZFUlJ0by84VmtkNUtkNkZmQkVoWW44?= =?utf-8?B?QTAyOVROMUN0d3g3TkdJMTVKTnYxWDBrOGZQRWlnZlZXMFhlQjV0enE4Vi81?= =?utf-8?B?WUx3Rk56U1hxRzZOY2RINEFsOFFOMlJWZnRaNXI2Rk5wd2ZTUWU5QW9GYm9x?= =?utf-8?B?anR5YU9ZbVZLSmpJWWtyTVFzdEVNcXptM2pDTFJlN1p2UFB3SSs1UEZOYVo4?= =?utf-8?B?akJoajNGWGE5Q2VVdTNXTmJpV1FZZHZEemhCWWV3blJQOTlaQXlxOVo0OGVL?= =?utf-8?B?TVZkYzRDVjVOd2FQbEpHeG1tRDI3ekhaTEVGZHkyNVRJZU1jb2FKbGFSMlJx?= =?utf-8?B?SmVkU0F1K0Y0OGl0ZFNEQTV4YmxvaEptWGRIb3QrNmtaMEJlRDJoclpWdm5N?= =?utf-8?B?NjFQeWtWZFdQZWtyaGxRV2V4a3k0ZUxJUzNJbXJiOHhmQTM0NGVGMWliVVFE?= =?utf-8?B?em0xTjB5d2hHdmEwVW1kM0QvMVBjWVpnTEFIUXg4SHZQdU83SG4yQ3hWWFBq?= =?utf-8?B?MWY0UXRORDZCOW05MHhKMjdYTkU5Sk51YnBkNENDVjd1NW5nRTRDazcxcDdB?= =?utf-8?B?akhNMTlRZ0RoeTdWd1NqOHM0SFZwZW9MSmxBREVCeXEvaG1NZlloZUNiNDFO?= =?utf-8?B?L2pDZzZFdTFHMEdiWG5aTnNHcE1nVkY3dWkwZ1U1Y1RKaTRkbkdwS1VSRDBP?= =?utf-8?B?cFZ4Q0o2SHZVZXVldWZ3b2FSam14UlNSSVBzdXZIUmI3U1FyVmlmcXZIM3NP?= =?utf-8?B?SEg2cjBGakM1T3RqNUo3UjFOaitNeGdxNER2TXFqUE8wdW1CMStFZUE5d1B2?= =?utf-8?B?OURaZXV4ZjlNRk1wRVlCcFRBd2lmUmVLVnZoZlJpV2Z2KzFQOTErU0RSM1N3?= =?utf-8?B?RzNwV1RkR3ZNakh4RVYzZi9iTm5MRTB1WGQvL2pOLzVqNHNHQ0YvOEUzUlM1?= =?utf-8?B?OHNYWkJrTzJZeXBhTTlGY0k1RFlFUXR6MDNuSkJQZ25neFhGTk15RXo4NTJh?= =?utf-8?B?bnFUVDgzK1Z1ZGhRdEgxVUlFTUVRTENHTWRsZnR1ZWw2dysrZTF3Rnd4c3hL?= =?utf-8?B?VUxOOVluc3AzR05qa1VGYjEvRUQ2K0JOQUZEQ09waHp1RC9GdFBhMzZvM3l0?= =?utf-8?B?L1N6S2s1VDE4TE1sblozSHc5dGE5aWE1alB2N1FEMitWUzRzK1R2a3NaUWlN?= =?utf-8?B?a0JURFdML0FCV2U2YjdoWC96Uy8xSjFKZWkrM2JPejEwdGNMK1R5ZE5vN2w2?= =?utf-8?B?d2RVUTIzVi9PT3N2SjBPWmxDa082YWFtY2Q5ckdRL3AvMlRVd0lzR2Q4ak1u?= =?utf-8?B?S3dZNnRxK01TeHh2S3lTTDVOQjhmN2lGSDFxSG5QaVpwSkVPT3pUVjR2Vksx?= =?utf-8?B?THNVb0V0VEE5SkM5cmcwc253NmtQeTRIeXZuSURDSlIzU1lNaTRhalpnQmtJ?= =?utf-8?Q?n++Sxu8r35sOhYbLU7atCLA5P?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b80541d4-406b-44c4-150a-08daf23291dc X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2023 11:13:44.0127 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wj4PbyWldqr1VVJoXCez8QvC16zLZAYQQUS9w+wUQKVy9Of2eyWscF5KdPA925MuHieKd2UDvbKLhUzi0cF09A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7043 On 06.01.2023 19:21, Andrew Cooper wrote: > On SPR, MSR_DBG_CTRL.LBR is a write-discard bit.  There really are no > model specific LBRs, so we should emulate it as write discard too.  More > generally, I think we should apply that to any system were we don't know > the model-specific indices. > > I think this will be sufficient to avoid crashing guests on SPR.  Any > software actually expecting to use model specific LBR would need a model > table anyway just like Xen has, and will not get it updated with SPR's > model number, so for the (more) common case of not having migrated, > things should turn off cleanly. Sounds reasonable as a plan. Jan From xen-devel-bounces@lists.xenproject.org Mon Jan 09 11:14:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 11:14:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473518.734169 (Exim 4.92) (envelope-from ) id 1pEq6h-0000aZ-63; Mon, 09 Jan 2023 11:14:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473518.734169; Mon, 09 Jan 2023 11:14:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEq6h-0000aS-3O; Mon, 09 Jan 2023 11:14:23 +0000 Received: by outflank-mailman (input) for mailman id 473518; Mon, 09 Jan 2023 11:14:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEq6g-0000aI-GE for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 11:14:22 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEq6f-0003Dl-RB; Mon, 09 Jan 2023 11:14:21 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=[192.168.1.158]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pEq6f-0005UR-LS; Mon, 09 Jan 2023 11:14:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=bpMEbxC0C/EchsSeg1PKvRuvBtnvzv7EgYhijVCgq4c=; b=A8mw0AwuLBabsFTTLabdZ5ukUO sF+L/DU/ZQyeFTZZhdOq+/b2XGBcYaspI0reac9JaXN8HfLsSY2KwO9xjhWxEfc1pyFNZmpIYmMla EPGHYD3wVf8+oeAvh98TSIxSElET2JAPfHrQuNdJPKAunFZeyra1pKTkVHmqjwQzTMc0=; Message-ID: <82388ac9-784b-d13a-a0db-36d2fffb7cfb@xen.org> Date: Mon, 9 Jan 2023 11:14:19 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v1 6/8] xen/riscv: introduce early_printk basic stuff Content-Language: en-US To: Oleksii , xen-devel@lists.xenproject.org Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis References: <3f30a60729b45ee01adc2d4c0eec5a89bb083abd.1673009740.git.oleksii.kurochko@gmail.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, On 09/01/2023 09:10, Oleksii wrote: > On Fri, 2023-01-06 at 13:51 +0000, Julien Grall wrote: >> Hi, >> >> On 06/01/2023 13:14, Oleksii Kurochko wrote: >>> The patch introduces a basic stuff of early_printk functionality >>> which will be enough to print 'hello from C environment" >>> >>> Signed-off-by: Oleksii Kurochko >>> --- >>>   xen/arch/riscv/Kconfig.debug              |  7 ++++++ >>>   xen/arch/riscv/Makefile                   |  1 + >>>   xen/arch/riscv/early_printk.c             | 27 >>> +++++++++++++++++++++++ >>>   xen/arch/riscv/include/asm/early_printk.h | 12 ++++++++++ >>>   4 files changed, 47 insertions(+) >>>   create mode 100644 xen/arch/riscv/early_printk.c >>>   create mode 100644 xen/arch/riscv/include/asm/early_printk.h >>> >>> diff --git a/xen/arch/riscv/Kconfig.debug >>> b/xen/arch/riscv/Kconfig.debug >>> index e69de29bb2..940630fd62 100644 >>> --- a/xen/arch/riscv/Kconfig.debug >>> +++ b/xen/arch/riscv/Kconfig.debug >>> @@ -0,0 +1,7 @@ >>> +config EARLY_PRINTK >>> +    bool "Enable early printk config" >>> +    default DEBUG >>> +    depends on RISCV_64 >> >> OOI, why can't this be used for RISCV_32? >> > We can. It's my fault we wanted to start from RISCV_64 support so I > totally forgot about RISCV_32 =) >>> +    help >>> + >>> +      Enables early printk debug messages >>> diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile >>> index 60db415654..e8630fe68d 100644 >>> --- a/xen/arch/riscv/Makefile >>> +++ b/xen/arch/riscv/Makefile >>> @@ -1,6 +1,7 @@ >>>   obj-$(CONFIG_RISCV_64) += riscv64/ >>>   obj-y += setup.o >>>   obj-y += sbi.o >>> +obj-$(CONFIG_EARLY_PRINTK) += early_printk.o >> >> Please order the files alphabetically. >> >>> >>>   $(TARGET): $(TARGET)-syms >>>         $(OBJCOPY) -O binary -S $< $@ >>> diff --git a/xen/arch/riscv/early_printk.c >>> b/xen/arch/riscv/early_printk.c >>> new file mode 100644 >>> index 0000000000..f357f3220b >>> --- /dev/null >>> +++ b/xen/arch/riscv/early_printk.c >>> @@ -0,0 +1,27 @@ >> >> Please add an SPDX license (the default for Xen is GPLv2). >> >>> +/* >>> + * RISC-V early printk using SBI >>> + * >>> + * Copyright (C) 2021 Bobby Eshleman >> >> So the copyright here is from Bobby. But I don't see any mention in >> the >> commit message. Where is this coming from? >> > Could you please share with me an example how it should be look like? > Signed-off: ... ? Or "this file was taken from patch series ..."? This depends on the context. Do you have a pointer to the original work? If you are taking the patch mostly as-is, then the author should be Bobby. The first signed-off-by would be Bobby and you will be the second one. Otherwise, you could credit him with "Based on the original work from ...". A link could be added in the commit message or after ---. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Jan 09 11:15:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 11:15:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473527.734180 (Exim 4.92) (envelope-from ) id 1pEq7b-0001Bd-F9; Mon, 09 Jan 2023 11:15:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473527.734180; Mon, 09 Jan 2023 11:15:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEq7b-0001BW-CL; Mon, 09 Jan 2023 11:15:19 +0000 Received: by outflank-mailman (input) for mailman id 473527; Mon, 09 Jan 2023 11:15:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEq7Z-0000Uj-P8 for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 11:15:18 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2076.outbound.protection.outlook.com [40.107.243.76]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e4565d2f-900e-11ed-91b6-6bf2151ebd3b; Mon, 09 Jan 2023 12:15:16 +0100 (CET) Received: from MW4PR03CA0101.namprd03.prod.outlook.com (2603:10b6:303:b7::16) by PH7PR12MB7869.namprd12.prod.outlook.com (2603:10b6:510:27e::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Mon, 9 Jan 2023 11:15:12 +0000 Received: from CO1NAM11FT020.eop-nam11.prod.protection.outlook.com (2603:10b6:303:b7:cafe::f7) by MW4PR03CA0101.outlook.office365.com (2603:10b6:303:b7::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Mon, 9 Jan 2023 11:15:12 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT020.mail.protection.outlook.com (10.13.174.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5986.18 via Frontend Transport; Mon, 9 Jan 2023 11:15:12 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 9 Jan 2023 05:15:10 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 9 Jan 2023 03:15:09 -0800 Received: from [10.71.193.39] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Mon, 9 Jan 2023 05:15:07 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e4565d2f-900e-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K1/+2q7QWZHrBzeI83U4dvkmjyRXXPMNuyccV+cP+S9qq5zXz9s8TolbEL9HHpYcBeFQwAFOGJJJ9rwBwRllSkTvrDp9CsFgoz8RIePboDZyn5yPyU+b6OlL6xwJzBREVVKhPB9tta/o5SOueEsgLRTT8LG3VfNWhzTSOdG5ByRorSqJIp3c74mQZcG5nP7wWcHWpiJdkzygbnbHD4TClFLr0aJEIRBqceMUOjoWrFRQVJdMohuE3cZUHN4tsGgPk92G0o7B7BAJX27zOMKhCHgWQIeoOm0V9/N9A21IHk4799rkG+GfnpNDpJZVHKa2rdRA1JTblmDSA/qgSWJ8gA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SxPfohhAy9Pfz20exhjw8wrurETc87GXeKs0KT+jF6s=; b=PovTWRX9ik1Ysh+NbGNPglzQhIaH+u8k+vRQhw6GMidSebVDWY8PrD81TZ3V5HAChTqsI3/ojp6NJ3w6HXbw8rqKiS7sjilQ0SRIFdtoa7cVUoGwAn9TlJrYsFmayu4xnc5A9NiVdfG1HUecAHXS2aIXX1nJVYIZ6me3UyjJVmY1V1GpwRWFGHwUxidp22sGKy6pwCCBNaBISTGZhGcDKlCJXE/Mgmh0BdasrITWnh71cHbodes3RgIv+Nt/6tuEq1S6GgQR+pnHE2+ccQ/3rtNzcAn6bL2yMAfwVvx6ji7O/Ip2cnrkg6C+CL/WyL5LHznfggtXvIxpMmAlvtMNVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SxPfohhAy9Pfz20exhjw8wrurETc87GXeKs0KT+jF6s=; b=exYPtEsf6nAR5X7o4U9Gi/Ja4Oost7tRYjFl5rBFOwSMEJlKD59PfGfxMvLYmIG80V5OvXdLT1Ss5Cg33Do6h3Q2zBo4dUO6JmF2IR4Lbo+mcMdFovOn/ZBZVQYbaR8QSSSktbLdIPyiNccTNd0OuBbNdoFlZuIByluIPQZAhbw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <6373383d-d6d3-3d92-b09e-6434c5b5d15b@amd.com> Date: Mon, 9 Jan 2023 12:15:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 1/2] xen/cppcheck: sort alphabetically cppcheck report entries Content-Language: en-US To: Luca Fancellu , CC: , Andrew Cooper , "George Dunlap" , Jan Beulich , "Julien Grall" , Stefano Stabellini , Wei Liu References: <20230106104108.14740-1-luca.fancellu@arm.com> <20230106104108.14740-2-luca.fancellu@arm.com> From: Michal Orzel In-Reply-To: <20230106104108.14740-2-luca.fancellu@arm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT020:EE_|PH7PR12MB7869:EE_ X-MS-Office365-Filtering-Correlation-Id: 5e715692-6bc9-481b-1535-08daf232c6d5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: W9TL+z4cfEa+hSAGxMhbrV7dQZkzoWSohH2eFzkT16VHHCe6vIDfIigIQTjy/Sz8+iq8ym6AAr+At8pyoq+hCUVwZR4eGfqcee9ye8UUZk/Bw1iLhfrK7mwk14SjHp2jw8b1rGaaZdOSao6m1cCjPgPoZ4Yjc2Hw6rkG2SneExZZ5Lng757PVBzYH36/EUc+E3+3UGEplF+4hPNMwdsfJ9OkycHAdxfI6B5pyxZ5vqovuFTkDk1C8IHDScw2LTjg2IzTg0/aHsjMCAuQmuFnohnbrxVQzM1ki8VMOe2W1ZQ0pft+GA6y8Ei/Fxgne6+2XW3E2KCQv+Yis3VkrMU8TAeX4ldIBMHXo5K5uQEB8kOHUMZjtUKQwL+11Vo4ZEu4D6ZAgpMF47zlyk1PjfNY9s1MyGLOpgn0FOibwDYDEgjvyOe3JsLuJ+qK6XnV8Dtq+F2BctWmFHo9Io3fpXyRbkXewErIiltuIgO+zsL3AJdkT8EsvH8eN6D2CRGzr6XFJC+0OUNE5eJ3srcKsIH4Al20lICyE6J0G9VLa8MCTlDBv/x3NgdIx/QvbHNYzsnPW1xnR1AwDsh9dG0YrLzjDzhM5ytlOQgeG0QH71mvLsAK6FR1G2o+irLaS3WVeJGP3ZV0pdT0w9543vRFLeU499LiAzkzUCZiUryx6Rga+jf5IbxikpcEh59y3+joVyVDpDSmOswaXrcm/IY+UzfuhKVOakC0BmhpRIPhoQrEIcH+zzKiq9wRlFeR0zibz85xyu/qeNGO5FXmi6se+NZ4HA== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(136003)(396003)(39860400002)(451199015)(36840700001)(40470700004)(46966006)(36756003)(86362001)(2906002)(356005)(81166007)(8936002)(5660300002)(82310400005)(44832011)(41300700001)(82740400003)(36860700001)(47076005)(426003)(31696002)(110136005)(70206006)(70586007)(54906003)(31686004)(53546011)(6666004)(40480700001)(186003)(40460700003)(8676002)(26005)(4326008)(16576012)(316002)(2616005)(336012)(478600001)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2023 11:15:12.2924 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5e715692-6bc9-481b-1535-08daf232c6d5 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT020.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7869 Hi Luca, On 06/01/2023 11:41, Luca Fancellu wrote: > > > Sort alphabetically cppcheck report entries when producing the text > report, this will help comparing different reports and will group > together findings from the same file. > > Signed-off-by: Luca Fancellu > --- > xen/scripts/xen_analysis/cppcheck_report_utils.py | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/xen/scripts/xen_analysis/cppcheck_report_utils.py b/xen/scripts/xen_analysis/cppcheck_report_utils.py > index 02440aefdfec..f02166ed9d19 100644 > --- a/xen/scripts/xen_analysis/cppcheck_report_utils.py > +++ b/xen/scripts/xen_analysis/cppcheck_report_utils.py > @@ -104,6 +104,8 @@ def cppcheck_merge_txt_fragments(fragments_list, out_txt_file, strip_paths): > for path in strip_paths: > text_report_content[i] = text_report_content[i].replace( > path + "/", "") > + # sort alphabetically the entries > + text_report_content.sort() > # Write the final text report > outfile.writelines(text_report_content) > except OSError as e: > -- > 2.17.1 > > Having the report sorted is certainly a good idea. I am just thinking whether it should be done per file or per finding (e.g. rule). When fixing MISRA issues, best approach is to try to fix all the issues for a given rule (i.e. a series fixing one rule) rather than all the issues in a file from different rules. Having a report sorted per finding would make this process easier. We could add a custom key to sort function to take the second element (after splitting with ':' separator) which is the name of the finding to achieve this goal. Let me know your thoughts. ~Michal From xen-devel-bounces@lists.xenproject.org Mon Jan 09 11:37:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 11:37:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473534.734192 (Exim 4.92) (envelope-from ) id 1pEqTF-0003kD-DD; Mon, 09 Jan 2023 11:37:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473534.734192; Mon, 09 Jan 2023 11:37:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEqTF-0003k6-AJ; Mon, 09 Jan 2023 11:37:41 +0000 Received: by outflank-mailman (input) for mailman id 473534; Mon, 09 Jan 2023 11:37:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEqTD-0003ju-I0 for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 11:37:39 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2072.outbound.protection.outlook.com [40.107.20.72]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 04879000-9012-11ed-91b6-6bf2151ebd3b; Mon, 09 Jan 2023 12:37:37 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8591.eurprd04.prod.outlook.com (2603:10a6:102:21a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Mon, 9 Jan 2023 11:37:36 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5986.018; Mon, 9 Jan 2023 11:37:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 04879000-9012-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dX8oNcqXQ0REezT1XQaLyhmHRlRZmUcmJkqy8ZBwwIA1COjnCrIDoNXnggbF7yr4GIgwjEmzJSnc/etlxmEAokVuqXtAkyRmoNO32C+wYoEDGQnUhFW8W7VUMpaQ0+rOCqmk3iDwP6nEFzUfhbccalajIuzJUYKve/IfcPUIkh68Xh+iqz9Yx32oWdUkFL5H99S5DB+Jt6aZ9kmWbj5DlgfGCOxxG94/1gLhlgPktPwEdJx4JsgNr8ORaGV+oCNh24Eb/denaXaaz7u6Kof2/ul0h3wfkFlmbXWAn8A7qVez18WSyCd+O0VXDlEILeZEEpaIPPbJc8gWWQzETVELRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qeasBoJ8JVmoBzjjKM2kVe3eIn/F5S+BWSxWiQtk0UQ=; b=gFU98fARG9RCgLOc5pUIEISQMSD6hDjcp9IcipgolaoRpk8i6rsKxOb+ZQKO6ay345rBIWgNbOaKcjdGogguubZvcRWMHMVPNiOCqg0zp+2QYsT9Ph/7BVf29zCRbpBC5aXdKFFKZYIX0hEaZRLb/wV4ncdBHYtrvUayGe38c+eittMi97QM3SMgVDeb8Q5YjR+xdLPFcqM/stkVRQg58uLGFzZaHVvKMN9ha8ThScYI4gHwj98R9Fs8YQbuJtbp7rTq0J98LrtaSPcW6Ka+CVJCsV21Nkt/70VtWgHhYEYkBMKNleDqu1wtXAStpRJ/QyL5LhwEgthr/Y+bO9NREw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qeasBoJ8JVmoBzjjKM2kVe3eIn/F5S+BWSxWiQtk0UQ=; b=UkzOA3Krzp26Ducr1JivXXE7/2UG4nBJ1xwl8hw3Q5AVnm8HD1eTksZPkXsH4A971FVxp5ADNtPbESyq5sIEJnBicIcEEdr77caaO50bQoT7cNL/BVxm77ZBxk12XVRlLbH/q4avMtnGRQCUcRbltaxP7sWW/zvPtRFkKOXKVUGV2iPwQok5+HQDaGbXHbb1QFUcyEWv7W9VYfLbUJOAi3UMa07Bsk8ehr+s2cfyqOQ4As2gX/El5RoeJJGkTdP1npMw99hBjXtJDDX4m4RJ0XqdaWu03NUtl6P6v6fzZwKHVqSW9E3nyL2EPCRvPsFNx3YFHzHuWjDSHhWRlYNO6A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2b46602a-f518-c191-946d-3b343b46dc87@suse.com> Date: Mon, 9 Jan 2023 12:37:34 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v7 4/4] x86: Allow using Linux's PAT Content-Language: en-US To: Demi Marie Obenour Cc: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Tim Deegan , xen-devel@lists.xenproject.org References: <9fd0360dd914d93dab357d16b46b4290e6119d30.1673123823.git.demi@invisiblethingslab.com> From: Jan Beulich In-Reply-To: <9fd0360dd914d93dab357d16b46b4290e6119d30.1673123823.git.demi@invisiblethingslab.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0183.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9f::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8591:EE_ X-MS-Office365-Filtering-Correlation-Id: ce3ef517-1964-4f8b-431d-08daf235e7b0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RpZyaufuPRObXfmKbM/ZsNaiBh7jdYG9GvQOhzKU9REhq0mLCwrPGD9fm/nLRO/jGZgNF1TF5A7kNodWRktjND0BweoTMSNIi5h/RCnBB52o0wznLa4a/xMfQ2yQsWCUbQ5Qfo5q/5rSR3GjwUnPTSijpHBQsL0DLqC7JDsyLk/ITtCCUpwJbGDQgqLvnasyvX0NrMyO4OSrjUZREHmCyf52bOq4dOEmATHIGLx/wtAJAmR06bss8oVlUQYTJx6+RjVLlx1sbtzVZ8ZeilBVRw+WHb2yIys/xjzHbKWvK3c5/EQa944RmWIkNwmsbi2u19Dv8yb8/91gLs1jckrDfVDMTdqQFEukhhJZNYjsa5shIEFqHr23YYH0jrabSyQiOK4/9rlJuC9HdSHALcnF9inVUW1/BkqmtUgMr1Cmfcb41tDqL8DmnIiBlZhsGTK3Mw08k/xORfV+BdlrJZsT9krZ0G6egusoPT0nJWWFvQpyi68S7YLtgxyygA1ITprAFh9svT2UVcMFGccr8JaFZdfVVC25vPGai3yfVA5xujYY6czxEwOzEma6/MNmqs6T+V5HkvZ4SHnqPAwK4IC555Me3+1GxiXoGQefg+1PIgS6Eyz6BMFwgmkjDgVxk/FPgUzo1qYgBeLhVIgskjoilVe8clAdnX1Sb+5wVIWfSOpNEYl1lZyKdPhOlQXP6LdsMrz1AN/DlCCzZsIl1+fVHXmWWSIhE4yLhs0uDhnljlg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(346002)(396003)(376002)(136003)(366004)(451199015)(6506007)(38100700002)(53546011)(31686004)(2906002)(478600001)(6486002)(2616005)(26005)(6512007)(186003)(5660300002)(316002)(7416002)(83380400001)(8936002)(36756003)(86362001)(31696002)(41300700001)(66946007)(8676002)(54906003)(66556008)(4326008)(6916009)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MG84UW1aa2prc0dlYzFjWElSdkZYTXFJZ3llRi9GV1RkYnhDeWdseVpnbVdk?= =?utf-8?B?bmUrZlVIdytHSVRxTCtnT0h3MmJvcHJjOWY0TkpYQXpCd3JoVmRqaXQyTWVp?= =?utf-8?B?SE1kbWNEU0xpb1p0NW5iV2pkVDR6ZU4wNUdzSGorYUJXTXZ5Vm1mSUd3Lyt4?= =?utf-8?B?VXNvMUppVUE5NjAwc3IzN0M3TnRzbHZtWGtzMlBtQ1ZoUUNKbWYvdHgxbjNv?= =?utf-8?B?aHNWNDRac2pjQnJWNUNIaWtIWk1YLzV3bGtlN3p4eFkyNGJtS1NZMEJscWcy?= =?utf-8?B?S3NEK2RvUTJKN0xGeHdHWTdiWk5kV3JlaGxpV3JjbkZOdDNTUjdkYWZUZXpk?= =?utf-8?B?OTEyNTBEQUpCcnZRYW5HWDgxUWZydVJpcUFVb3REYVpUelQrMlJaVkVrdDNo?= =?utf-8?B?cFRaQ3RZUytOejZRdU1NTzZ4ei9aaW95VHlwSDV1cTBkVVUwTjQwZXV4K094?= =?utf-8?B?OURuOFk0dTVzNSt2NVNYTzJDbWRuQmdKNHRMWitsNmJZU0xDbDR1dnlIaVNE?= =?utf-8?B?Nnc1SXRJVENGRGRoOElmWTAzbm9aWThZOEF1SzN5a1Z0dWxBY2ZaUjF4UUFT?= =?utf-8?B?Y3BIbzRJYkFoRUFRaW9HOEp2MUVYZjJIWXoyMEQwMG45c2FwNitzd01tUnR2?= =?utf-8?B?QUY1bDk1Q0RrVXJBQkhEUGtWNGpGa0g0ZVFqT1hUSzBGby9yaFpGMGpMWkZ1?= =?utf-8?B?Ty9jL2FoK2hBQ3pMemxoSGNQenIzSlBycDkzSWZhK05YU0NoRHlXcnhUYnNv?= =?utf-8?B?V3Y3MEpoaHV4VlZyT2JLcHdHbVhEdGhJa0t4NVdPVHhHNkxGbzZETTRpbGpG?= =?utf-8?B?bWFReXp6bjBPdkVZQmRadktIV25IL3BsLzFTL21BRkFjVXI2UzVpR3lTS1FE?= =?utf-8?B?dk0yM1dFdG9MVmtaWTV1aDRXOVNxSlZ4ZG5ITXZlcUdKMFd4bVY5c2lDQVZN?= =?utf-8?B?RHE0V0srRVFEMHprMEdLYUpmTnJMSStaTXRHMWZRdm4yQWF6ZzQvWUYrRUtO?= =?utf-8?B?U0NJTWJ2eWhTeVlFckRoR3BPbFh5SFJRS1IxeVBpRkcvb20zbFJ1SjJXWXUv?= =?utf-8?B?VmVSSVoxU21ZYVBUYzBXVVV4MWlvREM5b05abW83Y2VJY1kyWVJjellnNXFm?= =?utf-8?B?U09haW5vQWd6YzFMakl1SmZFdXRhL3NLQTg5YmtGL1dnRE1iV0k2ZVpjbEVH?= =?utf-8?B?aThuSng1VjBsR1F6MEJFUEcvTk5iSzFVaG9kUmFNQmVmVmFwNlN0L01LZklr?= =?utf-8?B?ZHI0YWRRczUxU1kxTWlwTXhSOFZBbnJ3aFZqWVFJeGNwREZHNW0vNDRqd25k?= =?utf-8?B?ZGZsMHFEdWtHR1dnK256UkZyYksycUpVdTJzZGlKU0lBNS9lL1AzUGJ2MnBE?= =?utf-8?B?NlZBMHhiLzhSdWdURUhpd2k4Z1BSZEFpMlc4YWZTd3hGVjRRWjZaS25JMTZF?= =?utf-8?B?dmcvUmszMld4alFNZW9pWlgramhVbkpkSmpUdG5SYlUybVVldm5uU01ocVdG?= =?utf-8?B?NEQrbC93V1lVYnZ3NjdmK3ZGM2xTRlpZU1R3eVhsN002aExtMmtiS1RhQXJa?= =?utf-8?B?UE5kZXVkWjRMdFBjbjZPYUhYQWRtSjBVSFQzSy9YRDFPa3RveDlYLzE3dklx?= =?utf-8?B?QTZ1NnBRZTFIeGRTN2ZUaFh6cndPSVROZTVDeER0RzdEVEhaTzBQbXo2QlRu?= =?utf-8?B?ZW8xZzluRDV5bmZTZTJaNjBmenJiV2xCbWl6bUF5MS91YkptdmhtWnpVK05W?= =?utf-8?B?Mm9MZzUrbmI2ODYyZTJYc056Zkxjd2FJVXIrTmVDS2NjNUVGYTJjenU0Tzl2?= =?utf-8?B?bXh5cUhIc3JWYnI2Mk96eG9mM3dVOEpyVllrUGNhUU1rZlhUMDRhYk01bmRD?= =?utf-8?B?SWJ4YitGZGhrREk3dTJMZ0Vqb0lFYkd5SzBWQVVWT0JWM3JMSGRDSlpodTdW?= =?utf-8?B?WDVTL2RQSDY0eEd3QVpUOGlCOCtCaW1mcXV0YlJKYjNHUlhGSW8xUVRva1V0?= =?utf-8?B?ekU1ZnM4Z25mWjNaclRqRUIxRTZrb3FpYkFQazJ0UGlsNEhOUlcydE93bG02?= =?utf-8?B?YndvTlN3WnVDMGEyZXU0cGcwYkZLdk5icGRFcS9qdWhIbzNEK2xYZU9GUzdJ?= =?utf-8?Q?9DJxA2dTt4dee2kbn4gW5iFj9?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ce3ef517-1964-4f8b-431d-08daf235e7b0 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2023 11:37:36.2498 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JH3Dmsl19TbZ1OBesapdipF0LHRVO+Mlcs7YDyZEBGnBj6oplof87T9e2popt4YkgTv9Ao58theuc4vzVlixbg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8591 On 07.01.2023 23:07, Demi Marie Obenour wrote: > --- a/xen/arch/x86/Kconfig > +++ b/xen/arch/x86/Kconfig > @@ -227,6 +227,39 @@ config XEN_ALIGN_2M > > endchoice > > +config LINUX_PAT > + bool "Use Linux's PAT instead of Xen's default" > + help > + Use Linux's Page Attribute Table instead of the default Xen value. > + > + The Page Attribute Table (PAT) maps three bits in the page table entry > + to the actual cacheability used by the processor. Many Intel > + integrated GPUs have errata (bugs) that cause CPU access to GPU memory > + to ignore the topmost bit. When using Xen's default PAT, this results > + in caches not being flushed and incorrect images being displayed. The > + default PAT used by Linux does not cause this problem. > + > + If you say Y here, you will be able to use Intel integrated GPUs that > + are attached to your Linux dom0 or other Linux PV guests. However, > + you will not be able to use non-Linux OSs in dom0, and attaching a PCI > + device to a non-Linux PV guest will result in unpredictable guest > + behavior. If you say N here, you will be able to use a non-Linux > + dom0, and will be able to attach PCI devices to non-Linux PV guests. > + > + Note that saving a PV guest with an assigned PCI device on a machine > + with one PAT and restoring it on a machine with a different PAT won't > + work: the resulting guest may boot and even appear to work, but caches > + will not be flushed when needed, with unpredictable results. HVM > + (including PVH and PVHVM) guests and guests without assigned PCI > + devices do not care what PAT Xen uses, and migration (even live) > + between hypervisors with different PATs will work fine. Guests using > + PV Shim care about the PAT used by the PV Shim firmware, not the > + host’s PAT. Also, non-default PAT values are incompatible with the > + (deprecated) qemu-traditional stubdomain. > + > + Say Y if you are building a hypervisor for a Linux distribution that > + supports Intel iGPUs. Say N otherwise. I'm not convinced we want this; if other maintainers think differently, then I don't mean to stand in the way though. If so, however, - the above likely wants guarding by EXPERT and/or UNSUPPORTED - the support status of using this setting wants to be made crystal clear, perhaps by an addition to ./SUPPORT.md. Jan From xen-devel-bounces@lists.xenproject.org Mon Jan 09 11:41:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 11:41:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473540.734202 (Exim 4.92) (envelope-from ) id 1pEqXI-00058u-VA; Mon, 09 Jan 2023 11:41:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473540.734202; Mon, 09 Jan 2023 11:41:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEqXI-00058n-SX; Mon, 09 Jan 2023 11:41:52 +0000 Received: by outflank-mailman (input) for mailman id 473540; Mon, 09 Jan 2023 11:41:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEqXH-00058h-Hv for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 11:41:51 +0000 Received: from EUR03-VI1-obe.outbound.protection.outlook.com (mail-vi1eur03on2052.outbound.protection.outlook.com [40.107.103.52]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9b0dc2f1-9012-11ed-91b6-6bf2151ebd3b; Mon, 09 Jan 2023 12:41:50 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM7PR04MB7143.eurprd04.prod.outlook.com (2603:10a6:20b:112::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Mon, 9 Jan 2023 11:41:48 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5986.018; Mon, 9 Jan 2023 11:41:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9b0dc2f1-9012-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dPaYxXm471tiT+NlC/PqDcVZ4B/n9IoQmquFif2yYGhkcEqxT8JEdlQjxG695tpsfp1BwxpKTd/9sT/1UliBX01SBAHKXn5s/NF6zuOBFcRd0/wRNHtZRHQLccXBzf9e9CP7TF2QUPUdPzRl6ONdi/H7mx8zDKVIW09xJpKa8A9DnFJASaoShQDfdqt6QJM/+Q/kvKsvhVkM/5IiZ0Ne5avQYWDnE3v0SvKwAduMqzhAOpsurlZygszHDVCE4cW/t0qA4cH++nO/M0hxKaY+eke97kEQDVd7qqZfbcFY3W0m1FjFhX5wX+4HdI5/o/uCV9nIIUWIqtMk6F/3Dx3X9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=60wc/vwFvoq+aOfiArChDicj2kOicqX9zYbvV3rdDSQ=; b=Ws1F3wXP2F5oHCYRWD76Xn05vww4AO6TsE9scpoY/9LIqI0dvXiwKV/LJIm9GX4IQnwNsudSOx+iLg2PdJNGuGlreqxZ6v0zP6xIqECN/WcytVsCjQf6CPfHDHpnczfncvDRkWklbtdESXRN2ZxJppIyqZVJp/tndsreblVi4Zbepxs2Tg27yaqsnXsOMKI3MbI5br4xo30Lg/hHPnGo/COFAArbGmveKUSCDsYMO5JF54fl+vvNMRF9mKYkFEqY3Um87WvzROOQX76DQ6Nq9eeO6gZBk4OtQG++8qHeEk3xPED3+l1jnTsiiD0O5rBk8edbaZfG9uRjoHwbzwgl5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=60wc/vwFvoq+aOfiArChDicj2kOicqX9zYbvV3rdDSQ=; b=mjMeHYn/NggfvIBewv3bqrSwKJ93h9t3cHg1Z5VVeeB5+1wrkIRDyA1uzj8SKW1hQ6PkRff+STgAnk6Jgo+f63PhzL4CqAnBglimL3yLE0h9OOLzQtd4G/XXE4C58ugQWeAKiF2nPV7z9qY8W4oVFR547Rx7+RRPzjhrJs8Lm4cPoBvokzeGShJKXljeGWslmBJsj9aLrY601gk+KwjBDi7zjMsqPN7ZbqSn9qD+T0gxkHZnXSwt5ZoyIVS3IpQPjn/noeRWfthuFSJ1MiTInuAKowgT7OEFsoEvJDD5X3QgT3Wuvv+jIYlFXOZaApI3JNR8pgNaAmnn8yXWaB8cOQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 9 Jan 2023 12:41:46 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 1/2] xen/cppcheck: sort alphabetically cppcheck report entries Content-Language: en-US To: Michal Orzel , Luca Fancellu Cc: wei.chen@arm.com, Andrew Cooper , xen-devel@lists.xenproject.org, George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu References: <20230106104108.14740-1-luca.fancellu@arm.com> <20230106104108.14740-2-luca.fancellu@arm.com> <6373383d-d6d3-3d92-b09e-6434c5b5d15b@amd.com> From: Jan Beulich In-Reply-To: <6373383d-d6d3-3d92-b09e-6434c5b5d15b@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0114.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9d::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM7PR04MB7143:EE_ X-MS-Office365-Filtering-Correlation-Id: a7797b28-b92e-4564-f83f-08daf2367de1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eh3AeoVXIcMhB5QFLvsXNGzXTRNpAnPaWoWx60pp8LqbdxrYPucCLbp/PFiS/1T1ZcQ3ge1FWxt4z4lsErazR/BW9cV0okRhaqFadVGaYiF8C0VUhP7P++LUYyq0OTO89XN5TerlCgUO4T4CqKEFx1HLPRM5XuQhAbCuP3yn+2Qp5XZNGCPyXkMbMgx4+SHkFIvfKgLYvqBjScv8g2m06Xk7nbwWrZCmTJ+ElffjcGyL5ICDZOVV3oQ4lPwDOroe2W+wjzQkeXxRer7ToNrVy5QQ6l3YMPtE17MeHWPbyW2TgTD6NbntRn3L1x2shuzMNOK9djgelrlVOXq5XyeTasiJ8v55SQn5z4zs3bTkSgsrg3PtbrqDsq6rk93gYFb8GGPtWSkxwUs+SC9Zjg3tDcfUyq5ofafuAkVU1fC9STsedywPQ+VWvVlQVAB4xAUhcaLBLGHg++Z1FSsJO8cannB1jPV3PeYbrZ+jY4VK9ZepDOTkdbOuKc+MNkcZpvO9r+cOTHLdpWeMOV3uP+m0d5lSFK1vOfpolGLdHR6zzG+lY40uIuYz4DdQJDFwpmmKgDCJEmxiKyMbC68z0Rix0Vf4EaiiLPCDWElmkiSd7pHKRWs+o/SkLq/YM1YH252eFii1M3RriQMRH7ErpmzTNMkkktaZUi3r+6JpYfbsp6nEnxG7K/CATRKt97fGcUXV23bwPN40D2e8Zvv4l/ZBK0DfzdI/gfjPNH1jeVVbxlQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39850400004)(346002)(376002)(366004)(396003)(136003)(451199015)(6506007)(478600001)(53546011)(6486002)(26005)(2616005)(4326008)(186003)(66556008)(66476007)(6512007)(8676002)(110136005)(54906003)(316002)(86362001)(38100700002)(31696002)(66946007)(41300700001)(31686004)(36756003)(5660300002)(2906002)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cWRqS3hQdkEzaVRpZ1pRcTREZzlVMFpwdHRkMmpHSHBTMzlWRi91MU1JdlZP?= =?utf-8?B?ajBVWTV2bU5JQ1FaVG9yOXUxZkRZUnJJaVlNK0lveHlRUDErT3BLbVAvWC9R?= =?utf-8?B?UGluckExWDl3VVMwb0hqN244VEROck94MVU3RzY5cE51bzZUQSsyZzJ4eEo5?= =?utf-8?B?eFdWMzhkSkRtclBXQ2FqQXVJTndpQTNpa2hlQUVnYmZDRWlPbW5vcFpDNW00?= =?utf-8?B?WU1yMkFWdHZMUGRzdU1wVGp2R05lblBab2I2aWNveVVKYWFORXVkRVoxZ0Yv?= =?utf-8?B?MHp6UDNDUEc1Z2JjeXdGRHN1bWVoeHR1cDMyRTI4eGhuUDY3YXdocUs1dW5r?= =?utf-8?B?amlwZUlmcVpPOEJ1SEFyMlozaTNBS2E3V2Q3Y3VRSnRZQWRMdGN6d3BUWXpJ?= =?utf-8?B?VEFOVHZjVzQxM2ljS0Z4L29nRUZVcHg0K1R6M25MVnJHeWx3RUdIanJ6QXFW?= =?utf-8?B?cVpZYzQvVksrd0hJWkNaM0owWmdOQ0xsdFptemlJdHVTWkZQNUdwUS9kRUlV?= =?utf-8?B?R1ZnRmFiWkpqUjNNamVPQ1h1WUwremR2Tkt5VlN6WVpUMUtzaUI0N2xTY1p2?= =?utf-8?B?Q3Z2Zk9JalJSREpIK2x5MjYyZ0w4MVl6ZzY0MFlZR0xjcGxudkRpc0R3ekE2?= =?utf-8?B?MENJc3REbmFUZGVuTmJJS0IvZUZNR0pPNGw2emc4Q0NESmRKNGlPZ2tSR0lh?= =?utf-8?B?QUJWOWJoU1QzbDYxY1J1Y3dZdnRrcEo4UG02dnVpem9vR1NEM0w5RS9TYXgz?= =?utf-8?B?UzdHUXNiSzdOMVl6b3NoRXZ0VjBZRmlucDdLTzZaWGpwSzZGNWlEeDRqb3VI?= =?utf-8?B?eEtIT1M0cVZia2NqZVNrMVJGWkdhdEhLUWQvbFZUYTVJRGVKMVBzbzB4clpO?= =?utf-8?B?bHc0NXpvZENqNDZuMWlCZTZ1blJITXA2c0JGMVY4YUk3ZERBaTlNdnJTTkd5?= =?utf-8?B?d1ZWUFJvSFdGQXE1OE9halErTTMvTS9kUGdDcjExc2VMTkFIK2RmMmxuSUwx?= =?utf-8?B?WkNMVFFQUXJZNHRNQkJ4SjJQSFRqN2RGUlVNYWJsVEFJOEVUQVNta1A3R3gw?= =?utf-8?B?MjhGb1k4NlFjZ0dzWTBoOWs2WjFCdEVtQ2VyTVZYcnFVdkMzbDRjMnBuSjBF?= =?utf-8?B?a0FnZ3FaVE9wQU1EZ3M2ZEkxNVloWENIbHZOMzdXSGluZGJvQlFFZk13S0Jo?= =?utf-8?B?bU1qNEMya0VzcDBLUkh4cHlGSkxCUmt6ckVraDluWjAweFpacHR4cXBrMDY1?= =?utf-8?B?L0dkV0ZzNXA2bnNoY3NNcHBBRE1WRkVRY3h5OG85UzZTT3g0bTVJQmM4eUxO?= =?utf-8?B?ZVdxdlJTak1ESTVCblZSMmtaRDBnRW1zNFJNK0hHRU1CZlhsUUlxUEM3TEg3?= =?utf-8?B?WUZWUjZZTHRsM0hBaHh4Y3dWb1B5RjhYanJwTkFETGpkUVl5NG9vRWhGMUNl?= =?utf-8?B?ZDlPdzlVUXJRTStYOEZ3TWk5cnFEcXkwUThtR0tKTHBSVkxSeFVCaE42S2tD?= =?utf-8?B?SmJwNWNIaDY0NkQ2cVhQVlFOTXZkR1RpN2JDM3ovVm82TnpTNStGNFdYazE5?= =?utf-8?B?Wkc4VDdjSk9xamgvd0JMYW1aKzVha0xrWTNNVU5Jd1ZnUlZ0ZlVtN1RNWXRr?= =?utf-8?B?eCs3ZmhDeGttYUx3SndmekMwY1BUb28yY2xIcTAvQUYvenh2OHF4WldUNEhW?= =?utf-8?B?NitGbHlPNi9YWkxkcDRuOTEvVUFXZVpJTXZsKzBuaEg1SDZtS0tWc3lEQUk3?= =?utf-8?B?c08rV1BjSWZTN3FQc1pYaVZrRzlkSDZ5QlVZQ3ZLVlB5ZjQ2S1J2YmpLYUs1?= =?utf-8?B?bGV4TGJvQS9ubXZNbTdkV0hRL3Azc0czSk9yVytHeHBEWG5lZ1ExWDNkNDZL?= =?utf-8?B?M3lNbi9OOUdZMWtFblZpQXU1c1MyT2Z1b1I2eXE5Q3UvOXZlTWVrdFZyV2VQ?= =?utf-8?B?L1I0TUdlNy9NZ0RSOG5FSjV6WGxzUXhKZ01LWkhKcjJLckJLWDJGbUg5TG9V?= =?utf-8?B?M3hwV3lxeE9rS0hkTUs2R1hRVHpXYWhTcmdGK05OT1lIc2lXSUY1ZDhYSUl1?= =?utf-8?B?SHFDdkphMmUzckU4Qk9TTXB6Z3R1V1FQM05qamg3ek5TczBVYXdveWxuTEtW?= =?utf-8?Q?3XZyEfJwkduNHecBnZD34c8Pr?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a7797b28-b92e-4564-f83f-08daf2367de1 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2023 11:41:48.1713 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7eMtJ43cd32SEtkYcIx46bXhAxUffL5bt57FnPNN5ApH/lPpejJOeBRAl4KxMBmY1hmlaqk0SSGAx8SzqBB9PQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7143 On 09.01.2023 12:15, Michal Orzel wrote: > On 06/01/2023 11:41, Luca Fancellu wrote: >> Sort alphabetically cppcheck report entries when producing the text >> report, this will help comparing different reports and will group >> together findings from the same file. >> >> Signed-off-by: Luca Fancellu >> --- >> xen/scripts/xen_analysis/cppcheck_report_utils.py | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/xen/scripts/xen_analysis/cppcheck_report_utils.py b/xen/scripts/xen_analysis/cppcheck_report_utils.py >> index 02440aefdfec..f02166ed9d19 100644 >> --- a/xen/scripts/xen_analysis/cppcheck_report_utils.py >> +++ b/xen/scripts/xen_analysis/cppcheck_report_utils.py >> @@ -104,6 +104,8 @@ def cppcheck_merge_txt_fragments(fragments_list, out_txt_file, strip_paths): >> for path in strip_paths: >> text_report_content[i] = text_report_content[i].replace( >> path + "/", "") >> + # sort alphabetically the entries >> + text_report_content.sort() >> # Write the final text report >> outfile.writelines(text_report_content) >> except OSError as e: >> -- >> 2.17.1 >> >> > > Having the report sorted is certainly a good idea. I am just thinking whether it should be done > per file or per finding (e.g. rule). When fixing MISRA issues, best approach is to try to fix all > the issues for a given rule (i.e. a series fixing one rule) rather than all the issues in a file > from different rules. Having a report sorted per finding would make this process easier. We could > add a custom key to sort function to take the second element (after splitting with ':' separator) > which is the name of the finding to achieve this goal. Let me know your thoughts. +1 - sorting by file name wants to be the 2nd sorting criteria, i.e. only among all instances of the same finding. Jan From xen-devel-bounces@lists.xenproject.org Mon Jan 09 11:51:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 11:51:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473546.734214 (Exim 4.92) (envelope-from ) id 1pEqgE-0006cm-Rh; Mon, 09 Jan 2023 11:51:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473546.734214; Mon, 09 Jan 2023 11:51:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEqgE-0006cf-Ob; Mon, 09 Jan 2023 11:51:06 +0000 Received: by outflank-mailman (input) for mailman id 473546; Mon, 09 Jan 2023 11:51:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEqgE-0006cV-01; Mon, 09 Jan 2023 11:51:06 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEqgD-0004EX-ST; Mon, 09 Jan 2023 11:51:05 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEqgD-0001wG-EB; Mon, 09 Jan 2023 11:51:05 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pEqgD-0000sw-Dm; Mon, 09 Jan 2023 11:51:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=zlILV5HZMdcoQMn06wy5JfrKcgGmAjOBQDraPW001wY=; b=5aLfPgrWdzfk6W7N3FzWu41ReQ JTUmHUwinr7I62V7vVZkDSYvf8k6M3SdFwCiLF9dzL5Bq2r7jTfT9dXBje4WSthvxcd0ggH271ARo yY45VBwfd0DQOjXh4Z4jwhvO955wulJCzdUKB6iPzXnWdfMJ2V7NxhzACvPmMsl164C8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 175635: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:windows-install:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=2b21cbbb339fb14414f357a6683b1df74c36fda2 X-Osstest-Versions-That: xen=2b21cbbb339fb14414f357a6683b1df74c36fda2 From: osstest service owner Date: Mon, 09 Jan 2023 11:51:05 +0000 flight 175635 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/175635/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 175624 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175624 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 175624 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175624 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 175624 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175624 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 175624 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 175624 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 175624 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 175624 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175624 test-amd64-amd64-xl-qemuu-win7-amd64 12 windows-install fail like 175624 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen 2b21cbbb339fb14414f357a6683b1df74c36fda2 baseline version: xen 2b21cbbb339fb14414f357a6683b1df74c36fda2 Last test of basis 175635 2023-01-09 01:51:57 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Mon Jan 09 11:55:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 11:55:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473554.734225 (Exim 4.92) (envelope-from ) id 1pEqkT-0007JM-GF; Mon, 09 Jan 2023 11:55:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473554.734225; Mon, 09 Jan 2023 11:55:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEqkT-0007JF-Dg; Mon, 09 Jan 2023 11:55:29 +0000 Received: by outflank-mailman (input) for mailman id 473554; Mon, 09 Jan 2023 11:55:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEqkS-0007J9-40 for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 11:55:28 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 802e7c60-9014-11ed-b8d0-410ff93cb8f0; Mon, 09 Jan 2023 12:55:25 +0100 (CET) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-496-1tSs-3KtOzSxT7itYk1Mjw-1; Mon, 09 Jan 2023 06:55:20 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E5B4C858F0E; Mon, 9 Jan 2023 11:55:19 +0000 (UTC) Received: from redhat.com (unknown [10.33.37.5]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 51B4D2026D4B; Mon, 9 Jan 2023 11:55:07 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 802e7c60-9014-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673265324; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2Bax02BSkvxaOEt2CRhklLybKGV/xR8mYNLZmlYBdyg=; b=iZ1vw41NOfSmJlm+VPfFnXYnGMs6gnAeQ716TUqyu63V9hqbjmvtDBFk6gbcZrmUad45lT pwmI2TxnnLHhfCIXaI0p8OKnnmfzVA+52FExnVifAqVlHY2/EzW97TJ7miQDe5dKzkEcau WrMC9On41xRaf9OSanPuR+QBd1t3mN4= X-MC-Unique: 1tSs-3KtOzSxT7itYk1Mjw-1 Date: Mon, 9 Jan 2023 11:55:00 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Thomas Huth Cc: qemu-devel@nongnu.org, "Dr. David Alan Gilbert" , qemu-ppc@nongnu.org, xen-devel@lists.xenproject.org, Laurent Vivier , Markus Armbruster , Daniel Henrique Barboza , virtio-fs@redhat.com, Michael Roth , Alex =?utf-8?Q?Benn=C3=A9e?= , qemu-block@nongnu.org, Peter Maydell , qemu-arm@nongnu.org, Paul Durrant , Anthony Perard , David Gibson , =?utf-8?Q?C=C3=A9dric?= Le Goater , John Snow , Stefan Hajnoczi , Paolo Bonzini , Stefano Stabellini , Gerd Hoffmann , Greg Kurz Subject: Re: [PATCH 5/6] tests: add G_GNUC_PRINTF for various functions Message-ID: Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20221219130205.687815-1-berrange@redhat.com> <20221219130205.687815-6-berrange@redhat.com> <27da4d93-38e6-1c40-4a60-92f3343f380f@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <27da4d93-38e6-1c40-4a60-92f3343f380f@redhat.com> User-Agent: Mutt/2.2.7 (2022-08-07) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 On Thu, Dec 29, 2022 at 10:34:55AM +0100, Thomas Huth wrote: > On 19/12/2022 14.02, Daniel P. Berrangé wrote: > > Signed-off-by: Daniel P. Berrangé > > --- > > tests/qtest/ahci-test.c | 3 +++ > > tests/qtest/arm-cpu-features.c | 1 + > > tests/qtest/erst-test.c | 2 +- > > tests/qtest/ide-test.c | 3 ++- > > tests/qtest/ivshmem-test.c | 4 ++-- > > tests/qtest/libqmp.c | 2 +- > > tests/qtest/libqos/libqos-pc.h | 6 ++++-- > > tests/qtest/libqos/libqos-spapr.h | 6 ++++-- > > tests/qtest/libqos/libqos.h | 6 ++++-- > > tests/qtest/libqos/virtio-9p.c | 1 + > > tests/qtest/migration-helpers.h | 1 + > > tests/qtest/rtas-test.c | 2 +- > > tests/qtest/usb-hcd-uhci-test.c | 4 ++-- > > tests/unit/test-qmp-cmds.c | 13 +++++++++---- > > 14 files changed, 36 insertions(+), 18 deletions(-) > ... > > diff --git a/tests/unit/test-qmp-cmds.c b/tests/unit/test-qmp-cmds.c > > index 2373cd64cb..6d52b4e5d8 100644 > > --- a/tests/unit/test-qmp-cmds.c > > +++ b/tests/unit/test-qmp-cmds.c > > @@ -138,6 +138,7 @@ void qmp___org_qemu_x_command(__org_qemu_x_EnumList *a, > > } > > +G_GNUC_PRINTF(2, 3) > > static QObject *do_qmp_dispatch(bool allow_oob, const char *template, ...) > > { > > va_list ap; > > @@ -160,6 +161,7 @@ static QObject *do_qmp_dispatch(bool allow_oob, const char *template, ...) > > return ret; > > } > > +G_GNUC_PRINTF(3, 4) > > static void do_qmp_dispatch_error(bool allow_oob, ErrorClass cls, > > const char *template, ...) > > { > > @@ -269,7 +271,7 @@ static void test_dispatch_cmd_io(void) > > static void test_dispatch_cmd_deprecated(void) > > { > > - const char *cmd = "{ 'execute': 'test-command-features1' }"; > > + #define cmd "{ 'execute': 'test-command-features1' }" > > QDict *ret; > > That looks weird, why is this required? This means that the compiler can see we're passing a constant string into the API call a few lines lower. Without it, the compiler can't see that 'cmd' doesn't contain any printf format specifiers, and thus it would force us to use func('%s', cmd)... except that's not actually possible since our crazy json printf formatter doesn't allow arbitrary '%s', the '%s' can only occur at well defined points in the JSON doc. Using a constant string via #define was the easiest way to give the compiler visibility of the safety. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| From xen-devel-bounces@lists.xenproject.org Mon Jan 09 11:55:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 11:55:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473555.734235 (Exim 4.92) (envelope-from ) id 1pEqkc-0007bK-Nf; Mon, 09 Jan 2023 11:55:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473555.734235; Mon, 09 Jan 2023 11:55:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEqkc-0007bD-L3; Mon, 09 Jan 2023 11:55:38 +0000 Received: by outflank-mailman (input) for mailman id 473555; Mon, 09 Jan 2023 11:55:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEqkb-0007J9-Gt for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 11:55:37 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on2057.outbound.protection.outlook.com [40.107.8.57]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 86a8a279-9014-11ed-b8d0-410ff93cb8f0; Mon, 09 Jan 2023 12:55:35 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9400.eurprd04.prod.outlook.com (2603:10a6:102:2b2::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Mon, 9 Jan 2023 11:55:33 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5986.018; Mon, 9 Jan 2023 11:55:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 86a8a279-9014-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=crr5/fVaSMfV8/izX594wQZNidv+u79DFNfTsG9LI3y6C4Z4DUOhHyV+TUTTJ3NQXuVC30jocpCVKkowTZRxeSIrnxKnH9msbhZhVKUpgJPbXUfwGcSAVZ1NEaKc9vrLd5Z8khIKxSqCHOcCQ6SBRKrRi1kOboLKpEj+oMrmh4xhNr64ZJ/2nD1MZ2wRReByq3srDPogPxnieJTtHKZI6EWllmpiMbM6kKozTjxPLOwx19ALWYqkdXSbY+WjDMjVF9f+WrwfcEtWR8JF+zu6jjcfXYvZrbm0/T0BCgYQPqVN3V/vj4NHhbSwLNeGdRsYSl3CD3iFON8tgEsB8nCLFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0FwTL+KLmDvFMFlT0Yz3dMkCUPBpwkY5q/+tUnrTZl8=; b=De8y2WucBoSmmYNMTqnM46DpPXgd1F3QdSEtMhErnS8PSGk/HFg3MAQpnoGAMpwWCz9EmjUiLz6Gp4iWlVhYw6bmO9uMM0NxYVeNzmHv5Gz3rfNgch7sqUUydpoxktNZiyu3uIHJ7/dgeHjLDoWSrvNSnDvtmRO8v2L+F1w3Gqz5jUJ31yDrNmnWWh1aeGmpAHS1m4RY98XKAJ/Fe3KEdfC6F4iR2RhQZ6X1vfXNt6uQRMZ1hldLBrg6x1vGhOwOGt0Gyeyr9oHBgbqHg6ibbi8bPe5VX+IVqwD+MLbp7I3G8cmmBHZ41lNfQI6PJ3B0wOzzkJuc2bGXNOvAS4zT4g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0FwTL+KLmDvFMFlT0Yz3dMkCUPBpwkY5q/+tUnrTZl8=; b=XmTPTlhqJurksy9GqtyefS4o4280jpcvUqH3Mzw+ZXjs/AVjinLYIeiO4QLvXu7uKJZbFaEoBW2+LC6H2OuBCEOY+MnRbjGFSE44enWmEMTDKQG5BhSNGaVM5WOYXINwzCrjMQ2E6kD24RVlMlCCcxReLbBR+pOXjvVIiLBA+RtgEDNb4ziRicEGidEfQ7P3yHM8dsZLSc0Af9vk0jIgfnqLrC9kOscMe0K/fm7B7lLBOMzyBJ7Jd+Vov82baXjn8uYhGt5OXYBu5ZbgQsU3y6xB2gvpqYVyaqNB6n3VpG5IUWCOi9JuH2dYTgdIjSrIgKMXomLABnat1BM8zpHOsw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 9 Jan 2023 12:55:31 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 2/8] x86/paging: fold most HAP and shadow final teardown Content-Language: en-US To: Andrew Cooper Cc: Wei Liu , Roger Pau Monne , George Dunlap , "Tim (Xen.org)" , "xen-devel@lists.xenproject.org" References: <8d519e00-83c6-aee9-e7ba-523aa4265e1e@suse.com> <780eb542-34b9-c64f-0a40-acc462b87c72@suse.com> <4de3cf99-f8ab-c439-b383-859a41e90517@citrix.com> From: Jan Beulich In-Reply-To: <4de3cf99-f8ab-c439-b383-859a41e90517@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FRYP281CA0011.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::21) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9400:EE_ X-MS-Office365-Filtering-Correlation-Id: e465f2dc-006c-4373-97f4-08daf2386994 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IVPgEcMNuAabCFFoJtKbCOF9VG6EB/Qf8GxGQRySmCdrRuT8EIMRvdN8cb36F9VDoQNIfF+k1yu+srMux2+JAVqLV51XCW5/pUFTYfzGNboYeCqqNbMn67VwH8j4x11Ngu0LahP6yKdqmmf/QNx0Vtift3U0rMzU+u/OzB6xdzWuZdL99MWkWv2TT7cMdQRkkvMSmlK1oNi4F06Kge/hRJ2tDsG8xTGAPa1EQC4aI528lWwL0uLph7SjcZ8Pu4VY3PAk3XxJaARBv5vfObsEHG55sDZwALSnpF5UL8oCWMpAEeF5To3/XPrkXV1MEfRw8khlwjgWiO8D3PgHRvAWRP13+u2/AG1GdmQrkGehgyfJcIM2QNsDptrAVDBwC2O8w3ry1QACemvQIJIzMY2ffGUiPVAx1JmglNKWdyRJugTRcZ3Fa1SO4Snsvou15cu9/GLDJ9uuOXHWQe8Uq4MT0lOTD27RS9ODsgrQjDO40QFtGjePvImdvp8Ryp/hdKBKmUPismFfllm/1BOgP5S5OZhuoaOLEhPxypqH0TCbyJ7FR/VsleB/y1nfPhVEupE6vqptAmKtCKCqEVf9gPYbPSm6SJkD6eX2beWwwGn9VoTPxpB4C3yYFtz1hjk8E2RnLqxnauX0ZF4ptgmAZmPBWl7ULVMdNOsLvQl9svBZY/EE/mAjEZxu36AfKkjTXtePjo4XClIzOA6VOY/EfPMKuaqcE8CdmdvxkmhnHGnhlD0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(136003)(39860400002)(396003)(366004)(376002)(451199015)(36756003)(186003)(53546011)(8936002)(26005)(6506007)(6512007)(2616005)(54906003)(5660300002)(66946007)(66476007)(66556008)(6916009)(4326008)(316002)(86362001)(31696002)(6486002)(38100700002)(478600001)(31686004)(41300700001)(8676002)(2906002)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QUkvMHV1YWlJT2VHODExcVpiV0dtY1kwbjFER2p2QS9LL0JaS0xvUXNLOXpi?= =?utf-8?B?WVlvcm9QWmxDU3VINzRNZUFlSDhoREhiU0RPaEhGbUFZaXoxNCtweWVyNy9p?= =?utf-8?B?SVFTOGdzRUN4alBZeHdFZVVpcFpOVzV2QU43U1hGRkRGMDh0UnhpTzMxSnVY?= =?utf-8?B?RFFjb3ZyUml2OFg2RXE0a3BXYlpIQnRMNVdsc1BWZ3NVc1dOd1pDUktRSnJi?= =?utf-8?B?TjhudHB1ci9zYld1UmsxSFIxLzNaUVM3TEFvMDlwWWNYVWNZV253d0RVWkxF?= =?utf-8?B?ajlJeXpHZ3MwenNDQ25mUEliK1ovbm5sc3NNNXd3SmtKcGJvbythRjVCblJw?= =?utf-8?B?cDdnMm1vTzBKNnJEd3Q0RkRUbVJkUlZkYlhjN1RpVG9yb01Ic0ZqeDQ2SWxO?= =?utf-8?B?K3lWNHpneXp1WGZTdE1wTG1RcTlRL05idlBWeC9VeVAvTVFqMzJtTEtmTlp6?= =?utf-8?B?WG95Z3A3SVRTTlZMbWtLYWluUjREd1h1U3Z4aFExckZXU1NNMGJLUDVwR0Uz?= =?utf-8?B?aGQwYXNxeWVyYzFLOEdEWXN1TlRTc1JOdFNROEZjRXN6VDkyQkxjenNveHh3?= =?utf-8?B?M0lzNy9QZnhBQitSY1NrbWN3YWo5SmIxeTFDL3RDOHhCZHRpejdnczFhK0Ri?= =?utf-8?B?N21pYnVLNG9FYmFqMlBoMjlNei8xQnd6bWgyblV1a3FNU0VKcnNDQTRKc3NU?= =?utf-8?B?eHFGaXc1aEYzeUo3TFZ1d3NwL2JCSUlMazdIVFM5YnRlcGhhL0dOWDhyU0F5?= =?utf-8?B?djcyTHlBYytpNkpQcCt0eHZ3eEd6SmVDTmsrNk9HMnE3ZjB6aGd6S1ZUcFZU?= =?utf-8?B?Q3lYVitDL2hRdGI2ZnlGa2VGbUtKcU53OUlVWFhJYS9zT2JKMWJkdXhjM2FX?= =?utf-8?B?aTNKeFg1WVJ5eTNsY0d0T2N0VTdWNEZYNW5FRHd3STNCd1k5akdLaTJqQk5H?= =?utf-8?B?SWtidUlrRkJPbkZGL094cjVmMFBhNUlHamhBUjk3NU9HYmRXTUJZbXB0Yzdn?= =?utf-8?B?RjJOd2NIU3ROMFJVNU4wUU9PU3AvQXhlVktHQi80bS8zSVkxbE5vdWppeFpJ?= =?utf-8?B?aFJUY1Jva3hKYzZoM2tLOUc1Sy84bGNvaGVVRkhOUkJkVEVRQ2RPMjZ6ZitJ?= =?utf-8?B?Sjg3M3BBSks2UzdYdUdTZnlBTzI0ZDJ0WEtaT0J1MitPaDNRMm9VaW54NGRS?= =?utf-8?B?cksrSGF2RnU1U3hnOVprMG1pUUxjMUNrcUEwZFlLVU5TOVVQcXVWRUd6a1lB?= =?utf-8?B?K0tXM1lDTHF3cUViZEtpYzgrczU3OWVya3RNVzkwaWVXbTE4Yi9oYi9LZkVr?= =?utf-8?B?U1plQ0RQellJS0c2anhEZXAvVEJpVEg4NisyYWxVWW5VdENyVFJlZ240WFps?= =?utf-8?B?MjJFVW5IdnJWT0pITU95d3NHaVQzTDA4TUtMaEIzTEw5WVYyekx5L3QzOEp6?= =?utf-8?B?OFBwdU53aldMakt4T0VxZTUzc3h6c2NoNHRiSHNWUzNpY3VxU1dzQTdmcWMz?= =?utf-8?B?WnBUR21jU0o0V2pRRElTMWtFamNZT1Y4c2N2TGpGV1J6T0l4aERJVFdJZUZh?= =?utf-8?B?anRINm81ZjhzYkllOS83L05ON2hzcUdmVnJ1VTN6MXRUVktoSHhPVTZDbnda?= =?utf-8?B?ay92UEtEb3g1b2ZIT0VVaVQveDlkalJjVFpJeVVoWDJPK1YzbXJEZTIxQ0pK?= =?utf-8?B?ZElRSEhmMS9mZ2ZuTHNTUWJuenZzT0ZDbjFVYzZlbkVrL2o3UDhRb0Mva3Qx?= =?utf-8?B?dzZUT0M5OWhMdCttSFNTdXZ0VTdOOWhkVVhGSHpuRy9hUWdVOGZVNGQ0UXFL?= =?utf-8?B?ZjljOUNvR3JBcW9zSE80NmpOOW1oV1c0eVBKdFVKTzNZaWYyZitsQU5LUEFj?= =?utf-8?B?Q3dOaS9FRWNNckpScTQvMlFEdWV5NXVxbnpwWW5zY2h6Zzd0bGNYSmxkVVhB?= =?utf-8?B?UnJHbE9waWR2S20zdHZid1BiVC9zd0lzY2Z2eFcvM3pFTUhCQ3Jmc1VOY3FP?= =?utf-8?B?QlhGQW5WaXUyc2FMa2FpbGkwRXZGZHIxaEVvVGl1TjFQUWx3d1VDNFdzSE8r?= =?utf-8?B?bVBVam42dWtHVmp3SkprN2UwY0pMU3VvOTJZZXh5YzU3Vk9Cay9kbDlLT09I?= =?utf-8?Q?O68vnlFMdNJbnWWYm2ccbxTps?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e465f2dc-006c-4373-97f4-08daf2386994 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2023 11:55:33.2751 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Lmq3W3luSVdb4fUE+wCZKY6ranJlBVhzo+ouP1/Je5iBR/PB6rod/ibN6QTkBmBRCrMOmG/HrRzuCKy3+R2BsA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9400 On 05.01.2023 18:56, Andrew Cooper wrote: > On 22/12/2022 7:51 am, Jan Beulich wrote: >> On 21.12.2022 18:16, Andrew Cooper wrote: >>> On 21/12/2022 1:25 pm, Jan Beulich wrote: >>>> + d, d->arch.paging.total_pages, >>>> + d->arch.paging.free_pages, d->arch.paging.p2m_pages); >>>> + >>>> + if ( hap ) >>>> hap_final_teardown(d); >>>> + >>>> + /* >>>> + * Double-check that the domain didn't have any paging memory. >>>> + * It is possible for a domain that never got domain_kill()ed >>>> + * to get here with its paging allocation intact. >>> I know you're mostly just moving this comment, but it's misleading. >>> >>> This path is used for the domain_create() error path, and there will be >>> a nonzero allocation for HVM guests. >>> >>> I think we do want to rework this eventually - we will simplify things >>> massively by splitting the things can can only happen for a domain which >>> has run into relinquish_resources. >>> >>> At a minimum, I'd suggest dropping the first sentence.  "double check" >>> implies it's an extraordinary case, which isn't warranted here IMO. >> Instead of dropping I think I would prefer to make it start "Make sure >> ...". > > That's still awkward grammar, and a bit misleading IMO.  How about > rewriting it entirely? > > /* Remove remaining paging memory.  This can be nonzero on certain error > paths. */ Fine with me, changed. >>>> + */ >>>> + if ( d->arch.paging.total_pages ) >>>> + { >>>> + if ( hap ) >>>> + hap_teardown(d, NULL); >>>> + else >>>> + shadow_teardown(d, NULL); >>>> + } >>>> + >>>> + /* It is now safe to pull down the p2m map. */ >>>> + p2m_teardown(p2m_get_hostp2m(d), true, NULL); >>>> + >>>> + /* Free any paging memory that the p2m teardown released. */ >>> I don't think this isn't true any more.  410 also made HAP/shadow free >>> pages fully for a dying domain, so p2m_teardown() at this point won't >>> add to the free memory pool. >>> >>> I think the subsequent *_set_allocation() can be dropped, and the >>> assertions left. >> I agree, but if anything this will want to be a separate patch then. > > I'd be happy putting that in this patch, but if you don't want to > combine it, then it should be a prerequisite IMO, so we don't have a > "clean up $X" patch which is shuffling buggy code around. Well, doing it the other way around (as I already had it before your reply) also has its advantages. Are you feeling very strong about the order? Jan From xen-devel-bounces@lists.xenproject.org Mon Jan 09 11:58:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 11:58:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473567.734247 (Exim 4.92) (envelope-from ) id 1pEqnf-0008U4-6w; Mon, 09 Jan 2023 11:58:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473567.734247; Mon, 09 Jan 2023 11:58:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEqnf-0008Tx-4G; Mon, 09 Jan 2023 11:58:47 +0000 Received: by outflank-mailman (input) for mailman id 473567; Mon, 09 Jan 2023 11:58:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEqnd-0008Tr-Ct for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 11:58:45 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2042.outbound.protection.outlook.com [40.107.105.42]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f6816b93-9014-11ed-b8d0-410ff93cb8f0; Mon, 09 Jan 2023 12:58:43 +0100 (CET) Received: from FR0P281CA0014.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::19) by DU0PR08MB9370.eurprd08.prod.outlook.com (2603:10a6:10:420::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Mon, 9 Jan 2023 11:58:37 +0000 Received: from VI1EUR03FT055.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:15:cafe::6f) by FR0P281CA0014.outlook.office365.com (2603:10a6:d10:15::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.11 via Frontend Transport; Mon, 9 Jan 2023 11:58:36 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT055.mail.protection.outlook.com (100.127.144.130) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Mon, 9 Jan 2023 11:58:36 +0000 Received: ("Tessian outbound 6e565e48ed4a:v132"); Mon, 09 Jan 2023 11:58:35 +0000 Received: from 650a6f315a8d.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A68F06F4-1A8C-421B-99BA-F79F4A4991A7.1; Mon, 09 Jan 2023 11:58:29 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 650a6f315a8d.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 09 Jan 2023 11:58:29 +0000 Received: from AM0PR08MB4530.eurprd08.prod.outlook.com (2603:10a6:208:13c::21) by AS2PR08MB10156.eurprd08.prod.outlook.com (2603:10a6:20b:64e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Mon, 9 Jan 2023 11:58:28 +0000 Received: from AM0PR08MB4530.eurprd08.prod.outlook.com ([fe80::ee26:4b5e:4334:b7ab]) by AM0PR08MB4530.eurprd08.prod.outlook.com ([fe80::ee26:4b5e:4334:b7ab%7]) with mapi id 15.20.5986.018; Mon, 9 Jan 2023 11:58:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f6816b93-9014-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mso8kklQ8Xtd7MdJcZvsl0oNwRmlZTQARRAzdSnXFls=; b=1rj0/wAR5l+cfJlEIFT6tChlNOMi4AO5oKtUMnABlaXblh3Nc+d53Y6zjbKGgWSqiXGE5qVICRd8hU70K2uxOQFHrdvO0TmuuhubBsBeJ+oUWR4c8SY9GCOyJMiDKTVQxGcdGcGUjHHBSfdazhZAsCJ1965HGf2QlFUU05bFHwU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Fh6bQe1ISWjVQz5sKuDjU5rYItbpkwoojcdYRAJVp2P5OIukw9CUbzZWy7wIHsaA/Oo/tFxvq9m8eHiKUYRyIIy4PJ4AdRG3jC21ZmNnEk2LYo1V0HG5Cy+So2QMVzoe7RU6JUqQxR6so8+qnYwjZ/x59c6XU3zZZHRWBHSrNvqtJUeS9ohgmrdfo34Q1eLTCqrzPb5zWr1k6k75F3WaYugUJfW8ookD3fXwJlxAQfWXuXSvXNr7P44LZ3jisLi4T2Bq4swmYD9sdVP+t0UsQYpnu4ET3CYShmcqLluOngh+T7jLzrSg+1H+xzHb/YxXE7sKWvCdr4edE6amEEiG3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mso8kklQ8Xtd7MdJcZvsl0oNwRmlZTQARRAzdSnXFls=; b=M9by6Y/Xf43w6XylRpIvTLgWIKHiGm4eKszfjPFjra5Ggj3c68jzY+KbXMQN4yDE14cOj6QnVRegjfCGwlRUotC/jfTVr7mzVEYs74Vh8faj67Tfd9F/EntaM9M9JHL0OjWZVtrTCrGD4BDBIUVm4IxYvV9RCNTfHSjKEIdoq30KzHjBtUQSLeVZwwdAs85N0f9Enkz0CNKSmW6fzGxj2gVjLBG8Z2NnX0kvI8so833RL9Wz2zidZI5FziOOUtr99Ta5euFJf7nXKZ7DJq3fG/nR+RxgQFt+Np2NQl/dWfyQ8DyQEa/VJdIxbds7DjSfAQQzh9e9wfvjWhcynAHVsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mso8kklQ8Xtd7MdJcZvsl0oNwRmlZTQARRAzdSnXFls=; b=1rj0/wAR5l+cfJlEIFT6tChlNOMi4AO5oKtUMnABlaXblh3Nc+d53Y6zjbKGgWSqiXGE5qVICRd8hU70K2uxOQFHrdvO0TmuuhubBsBeJ+oUWR4c8SY9GCOyJMiDKTVQxGcdGcGUjHHBSfdazhZAsCJ1965HGf2QlFUU05bFHwU= From: Penny Zheng To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Wei Chen , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH v1 06/13] xen/arm: assign shared memory to owner when host address not provided Thread-Topic: [PATCH v1 06/13] xen/arm: assign shared memory to owner when host address not provided Thread-Index: AQHY+J1pmmYEajWz5UynKX+c5rdEZK6UzwiAgAEQoXCAAGGAAIAACRWA Date: Mon, 9 Jan 2023 11:58:28 +0000 Message-ID: References: <20221115025235.1378931-1-Penny.Zheng@arm.com> <20221115025235.1378931-7-Penny.Zheng@arm.com> <6db41bd2-ab71-422a-4235-a9209e984915@xen.org> In-Reply-To: <6db41bd2-ab71-422a-4235-a9209e984915@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 31865A1BCDB07F428FCE5A5A1FA00D2F.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM0PR08MB4530:EE_|AS2PR08MB10156:EE_|VI1EUR03FT055:EE_|DU0PR08MB9370:EE_ X-MS-Office365-Filtering-Correlation-Id: 511d1500-78db-43ce-526b-08daf238d6cf x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: oyzQBFRJWcbgxsly5DSZ3uHhM26NnIL/SVn2l8KPOiKXhn0Bb1IpGyo0w5snISB8EwCMcIU/Z6Dd8C/6wOddNqxOcdsamH6fZMbtb804si+lKpuHFYRL0EwQdUgyiK2h+Ggkd5ewYRaK9rhjjm9WJCD4DBF8nVjQhVtFwBxgh3APW8aVGQ/vPT78HF7YWkD0t7xT/i4upkBAKr4GFhdQKHy4UutLjYzNsi9oGJI+psb32mxYnJG5FoY1dqNzCQLVJv30cYvsy3AA1OMbqQZubcxiT39e7zOf0/yoQ2lOi5N/g/2dGroJ2XFfcGHG0lBBis8LU+PgZqW6pmUJubo607LQGw9Y0kiCIUXPsmIdLTXfpCOaWo/Obv8eQ26MQinn61YmTkwPT9h/6wfLkkb6hCnGcaQqYpuX5tP45KkiG+yjUrxmUP+5En8/xc+ZZVqiAWl7Sxfhpa+nV2qQVtPcAYfA3aKq2MG7Bhzg64TBpESLYRbbP0nhhWPCrUn+oSYPfbU2ayX2c0Rs4cj+9Q2Q3whQttbZu4Wd56SJWFhjl9rFMuVzHPcxx8IDTfLwGUQB4BW/qJNqtXhkXaxP3ytM+ocrud4Bky60LH6oWphXOehm8t+frafMfN6an11ssfcO1POwz/G+2mMJf93SnG+dUC8+E4CLmGjIzBPRu95joiHphEnvrH7EeabWTZlJb1AE28NX+lyCTUzx2QZZW1jECA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB4530.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(376002)(366004)(396003)(136003)(451199015)(86362001)(54906003)(110136005)(41300700001)(76116006)(66556008)(66946007)(66476007)(66446008)(4326008)(64756008)(8676002)(38100700002)(33656002)(122000001)(38070700005)(26005)(478600001)(7696005)(186003)(71200400001)(53546011)(6506007)(2906002)(5660300002)(8936002)(52536014)(316002)(55016003)(83380400001)(9686003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB10156 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ceabb286-bc94-40b5-7b21-08daf238d200 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CA1dfNgqVzTJlC1qQy5OcPAx8W3E6CKQ5/9RoPQiigACLe3YwGCOjJa2udCJ9WMGis3xH8F4FMre2IUtFfrGUTx8PCw31xOCjOLvyQlc5swgjA8G4tBr1V7zcD57TV4fdvNysKupKbRHbPPuUW3KaCyc1iBnRldSbqKn50+XN2JccxKizbR+UF3FNoyp4T6ETC78BG4oEnNWnKbzWz4RR1gIt6TKmUQmuCQHsbZeh/M0BDC4DtHUbSNS2IGAjRbgrsLbE5ceKN32046wyM57yah0zqNrERGU2yhtVZ3eiNlA96KQsMy5vUpb1f4SklP38QDbeWdVL1dRfJwAmwG++UQADerj6VB2sZ+Yt8Ni6LivG+1bPPbDXSlLO2xDnmTN6JVng7WvPH63SG3rB1IkjWa20B6F9pERHRNS7qh+4mO04Evr544qQB0yLD/cvdKNQjC2TiKRywaBA/Wqi3YBj7vNbtmuiAHkLvppNxL22MU6LukdbEkBMcxfXlKTMBvfb8Ewy7GK/t/a+A3JK82CU9lSwJyso93ehG7Ow4qJoNPVSOMFprePlKGy0fbfNcv3IbkkqhJzFa27bxZUroTq4tW4DtuuxhUwaeVLLjpgULhuHydKtwbnxS88x343VjnPhRMkfG/nq4rcJpSo7Jz+GRdQTbSh/hynJhZQUmsvj5pnVZ6K12ZQrms7RDYwE+LinBufUADfpct9z2AWVZo3jw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(39860400002)(396003)(346002)(451199015)(36840700001)(46966006)(40470700004)(70586007)(8676002)(4326008)(70206006)(316002)(7696005)(54906003)(110136005)(356005)(2906002)(5660300002)(40460700003)(8936002)(41300700001)(81166007)(47076005)(52536014)(86362001)(36860700001)(83380400001)(53546011)(6506007)(107886003)(33656002)(478600001)(40480700001)(55016003)(336012)(9686003)(186003)(82740400003)(26005)(82310400005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2023 11:58:36.0941 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 511d1500-78db-43ce-526b-08daf238d6cf X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9370 PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBKdWxpZW4gR3JhbGwgPGp1bGll bkB4ZW4ub3JnPg0KPiBTZW50OiBNb25kYXksIEphbnVhcnkgOSwgMjAyMyA2OjU4IFBNDQo+IFRv OiBQZW5ueSBaaGVuZyA8UGVubnkuWmhlbmdAYXJtLmNvbT47IHhlbi1kZXZlbEBsaXN0cy54ZW5w cm9qZWN0Lm9yZw0KPiBDYzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+OyBTdGVmYW5vIFN0 YWJlbGxpbmkNCj4gPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+OyBCZXJ0cmFuZCBNYXJxdWlzIDxC ZXJ0cmFuZC5NYXJxdWlzQGFybS5jb20+Ow0KPiBWb2xvZHlteXIgQmFiY2h1ayA8Vm9sb2R5bXly X0JhYmNodWtAZXBhbS5jb20+DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjEgMDYvMTNdIHhlbi9h cm06IGFzc2lnbiBzaGFyZWQgbWVtb3J5IHRvIG93bmVyDQo+IHdoZW4gaG9zdCBhZGRyZXNzIG5v dCBwcm92aWRlZA0KPiANCj4gDQo+IA0KPiBPbiAwOS8wMS8yMDIzIDA3OjQ5LCBQZW5ueSBaaGVu ZyB3cm90ZToNCj4gPiBIaSBKdWxpZW4NCj4gDQo+IEhpIFBlbm55LA0KPiANCj4gPiBIYXBweSBu ZXcgeWVhcn5+fn4NCj4gDQo+IEhhcHB5IG5ldyB5ZWFyIHRvbyENCj4gDQo+ID4+IC0tLS0tT3Jp Z2luYWwgTWVzc2FnZS0tLS0tDQo+ID4+IEZyb206IEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5v cmc+DQo+ID4+IFNlbnQ6IFN1bmRheSwgSmFudWFyeSA4LCAyMDIzIDg6NTMgUE0NCj4gPj4gVG86 IFBlbm55IFpoZW5nIDxQZW5ueS5aaGVuZ0Bhcm0uY29tPjsgeGVuLQ0KPiBkZXZlbEBsaXN0cy54 ZW5wcm9qZWN0Lm9yZw0KPiA+PiBDYzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+OyBTdGVm YW5vIFN0YWJlbGxpbmkNCj4gPj4gPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+OyBCZXJ0cmFuZCBN YXJxdWlzDQo+ID4+IDxCZXJ0cmFuZC5NYXJxdWlzQGFybS5jb20+OyBWb2xvZHlteXIgQmFiY2h1 aw0KPiA+PiA8Vm9sb2R5bXlyX0JhYmNodWtAZXBhbS5jb20+DQo+ID4+IFN1YmplY3Q6IFJlOiBb UEFUQ0ggdjEgMDYvMTNdIHhlbi9hcm06IGFzc2lnbiBzaGFyZWQgbWVtb3J5IHRvIG93bmVyDQo+ ID4+IHdoZW4gaG9zdCBhZGRyZXNzIG5vdCBwcm92aWRlZA0KPiA+Pg0KPiA+PiBIaSwNCj4gPj4N Cj4gPg0KPiA+IEEgZmV3IGNvbmNlcm5zIGV4cGxhaW5lZCB3aHkgSSBkaWRuJ3QgY2hvb3NlICJz dHJ1Y3QgbWVtaW5mbyIgb3ZlciB0d28NCj4gPiBwb2ludGVycyAic3RydWN0IG1lbWJhbmsqIiBh bmQgInN0cnVjdCBtZW1pbmZvKiIuDQo+ID4gMSkgbWVtb3J5IHVzYWdlIGlzIHRoZSBtYWluIHJl YXNvbi4NCj4gPiBJZiB3ZSB1c2UgInN0cnVjdCBtZW1pbmZvIiBvdmVyIHRoZSBjdXJyZW50ICJz dHJ1Y3QgbWVtYmFuayoiIGFuZA0KPiA+ICJzdHJ1Y3QgbWVtaW5mbyoiLCAic3RydWN0IHNobV9t ZW1pbmZvIiB3aWxsIGJlY29tZSBhIGFycmF5IG9mIDI1Ng0KPiA+ICJzdHJ1Y3Qgc2htX21lbWJh bmsiLCB3aXRoICJzdHJ1Y3Qgc2htX21lbWJhbmsiIGJlaW5nIGFsc28gYW4gMjU2LQ0KPiBpdGVt DQo+ID4gYXJyYXksIHRoYXQgaXMgMjU2ICogMjU2LCB0b28gYmlnIGZvciBhIHN0cnVjdHVyZSBh bmQgSWYgSSByZW1lbWJlcmVkIGNsZWFybHksDQo+IGl0IHdpbGwgbGVhZCB0byAibW9yZSB0aGFu IFBBR0VfU0laRSIgY29tcGlsaW5nIGVycm9yLg0KPiANCj4gSSBhbSBub3QgYXdhcmUgb2YgYW55 IHBsYWNlIHdoZXJlIHdlIHdvdWxkIHJlc3RyaWN0IHRoZSBzaXplIG9mIGtpbmZvIGluDQo+IHVw c3RyZWFtLiBDYW4geW91IGdpdmUgbWUgYSBwb2ludGVyPw0KPiANCg0KSWYgSSByZW1lbWJlcmVk IGNvcnJlY3RseSwgbXkgZmlyc3QgdmVyc2lvbiBvZiAic3RydWN0IHNobV9tZW1pbmZvIiBpcyB0 aGlzDQoiYmlnIigyNTYgKiAyNTYpIHN0cnVjdHVyZSwgYW5kIGl0IGxlYWRzIHRvIHRoZSB3aG9s ZSB4ZW4gYmluYXJ5IGlzIGJpZ2dlciB0aGFuIDJNQi4gO1wNCg0KPiA+IEZXSVQsIGVpdGhlciBy ZXdvcmtpbmcgbWVtaW5mbyBvciB1c2luZyBhIGRpZmZlcmVudCBzdHJ1Y3R1cmUsIGFyZQ0KPiA+ IGJvdGggbGVhZGluZyB0byBzaXppbmcgZG93biB0aGUgYXJyYXksIGhtbW0sIEkgZG9uJ3Qga25v dyB3aGljaCBzaXplDQo+ID4gaXMgc3VpdGFibGUuIFRoYXQncyB3aHkgSSBwcmVmZXIgcG9pbnRl ciBhbmQgZHluYW1pYyBhbGxvY2F0aW9uLg0KPiANCj4gSSB3b3VsZCBleHBlY3QgdGhhdCBpbiBt b3N0IGNhc2VzLCB5b3Ugd2lsbCBuZWVkIG9ubHkgb25lIGJhbmsgd2hlbiB0aGUgaG9zdA0KPiBh ZGRyZXNzIGlzIG5vdCBwcm92aWRlZC4gU28gSSB0aGluayB0aGlzIGlzIGEgYml0IG9kZCB0byBt ZSB0byBpbXBvc2UgYSAibGFyZ2UiDQo+IGFsbG9jYXRpb24gZm9yIHRoZW0uDQo+IA0KDQpPbmx5 IGlmIHVzZXIgaXMgbm90IGRlZmluaW5nIHNpemUgYXMgc29tZXRoaW5nIGxpa2UgKDJeYSArIDJe YiArIDJeYyArIC4uLikuIDtcDQpTbyBtYXliZSA4IG9yIDE2IGlzIGVub3VnaD8NCnN0cnVjdCBu ZXdfbWVtaW5mbyB7DQogICAgdW5zaWduZWQgaW50IG5yX2JhbmtzOw0KICAgIHN0cnVjdCBtZW1i YW5rIGJhbmtbOF07DQp9Ow0KDQpDb3JyZWN0IG1lIGlmIEknbSB3cm9uZzoNClRoZSAic3RydWN0 IHNobV9tZW1iYW5rIiB5b3UgYXJlIHN1Z2dlc3RpbmcgaXMgbG9va2luZyBsaWtlIHRoaXMsIHJp Z2h0Pw0Kc3RydWN0IHNobV9tZW1iYW5rIHsNCiAgICBjaGFyIHNobV9pZFtNQVhfU0hNX0lEX0xF TkdUSF07DQogICAgdW5zaWduZWQgaW50IG5yX3NobV9ib3Jyb3dlcnM7DQogICAgc3RydWN0IG5l d19tZW1pbmZvIHNobV9iYW5rczsNCiAgICB1bnNpZ25lZCBsb25nIHRvdGFsX3NpemU7DQp9Ow0K TGV0IG1lIHRyeX4NCg0KPiA+IDIpIElmIHdlIHVzZSAic3RydWN0IG1lbWluZm8qIiBvdmVyIHRo ZSBjdXJyZW50ICJzdHJ1Y3QgbWVtYmFuayoiIGFuZA0KPiA+ICJzdHJ1Y3QgbWVtaW5mbyoiLCB3 ZSB3aWxsIG5lZWQgYSBuZXcgZmxhZyB0byBkaWZmZXJlbnRpYXRlIHR3bw0KPiA+IHNjZW5hcmlv cyhob3N0IGFkZHJlc3MgcHJvdmlkZWQgb3Igbm90KSwgQXMgdGhlIHNwZWNpYWwgY2FzZSAic3Ry dWN0DQo+IG1lbWJhbmsqIiBpcyBhbHJlYWR5IGhlbHBpbmcgdXMgZGlmZmVyZW50aWF0ZS4NCj4g PiBBbmQgc2luY2Ugd2hlbiBob3N0IGFkZHJlc3MgaXMgcHJvdmlkZWQsIHRoZSByZWxhdGVkICJz dHJ1Y3QgbWVtYmFuayINCj4gPiBhbHNvIG5lZWRzIHRvIGJlIHJlc2VydmVkIGluICJib290aW5m by5yZXNlcnZlZF9tZW0iLiBUaGF0J3Mgd2h5IEkNCj4gPiB1c2VkIHBvaW50ZXIgIiBzdHJ1Y3Qg bWVtYmFuayoiIHRvIGF2b2lkIG1lbW9yeSB3YXN0ZS4NCj4gDQo+IEkgYW0gY29uZnVzZWQuLi4g VG9kYXkgeW91IGFyZSBkZWZpbmluZyBhczoNCj4gDQo+IHN0cnVjdCB7DQo+ICAgICAgc3RydWN0 IG1lbWJhbmsgKjsNCj4gICAgICBzdHJ1Y3Qgew0KPiAgICAgICAgIHN0cnVjdCBtZW1pbmZvICo7 DQo+ICAgICAgICAgdW5zaWduZWQgbG9uZyB0b3RhbF9zaXplOw0KPiAgICAgIH0NCj4gfQ0KPiAN Cj4gU28gb24gYXJtNjQgaG9zdCwgeW91IHdvdWxkIHVzZSAyNCBieXRlcy4gSWYgd2Ugd2VyZSB1 c2luZyBhbiB1bmlvbiBpbnN0ZWFkLg0KPiBXZSB3b3VsZCB1c2UgMTYgYnl0ZXMuIEFkZGluZyBh IDMyLWJpdCBmaWVsZHMsIHdvdWxkIGJyaW5nIHRvDQo+IDIwIGJ5dGVzIChhc3N1bWluZyB3ZSBj YW4gcmUtdXNlIGEgcGFkZGluZykuDQo+IA0KPiBUaGVyZWZvcmUsIHRoZXJlIGlzIG5vIG1lbW9y eSB3YXN0ZSBoZXJlIHdpdGggYSBmbGFnLi4uDQo+IA0KPiBDaGVlcnMsDQo+IA0KPiAtLQ0KPiBK dWxpZW4gR3JhbGwNCg== From xen-devel-bounces@lists.xenproject.org Mon Jan 09 12:08:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 12:08:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473583.734257 (Exim 4.92) (envelope-from ) id 1pEqx7-0001pn-Df; Mon, 09 Jan 2023 12:08:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473583.734257; Mon, 09 Jan 2023 12:08:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEqx7-0001pg-B7; Mon, 09 Jan 2023 12:08:33 +0000 Received: by outflank-mailman (input) for mailman id 473583; Mon, 09 Jan 2023 12:08:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEqx5-0001pa-Es for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 12:08:32 +0000 Received: from desiato.infradead.org (desiato.infradead.org [2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 51dc7caa-9016-11ed-91b6-6bf2151ebd3b; Mon, 09 Jan 2023 13:08:29 +0100 (CET) Received: from [2001:8b0:10b:1:b916:482e:69fd:b8ad] (helo=[IPv6:::1]) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1pEqwq-002iBc-0V; Mon, 09 Jan 2023 12:08:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 51dc7caa-9016-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:Message-ID:References:In-Reply-To:Subject:CC:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=9a7cthhMBn+fiERgH4CK4Ki4YEtD9TG5jpHvDi/tOEo=; b=Fo9zpnpI7UBzufJvu5HcNTrO/D 6QBdJtaAOHdTslw5o6E0XWsT6VMss13MKp6+ADHiDU6VpOky+qlQ0VkjwwFL6/SDwDwrGD7YWY4LU sjQ2AUV+O3lRkYjw8pLWpZAPzojaPGee6H3i7sr0WjVCYZ5C1SGH7CJYqb0o66y8+g+IzenxGOkTY TqNSuDjjgltdWDqlv1NgC0LiUNWk4K7JqWl33rjR9Fae5PSHYtQNXbDEhSYV21iUc/8kubRoXd13U LKLGQdNJabdRlaRBycKKqZ0qJdQv38HLZmX5liwpUNn5DK02NFuta37DrNTcGTm/Dj4FE4AmZrvAT RQXRdNgw==; Date: Mon, 09 Jan 2023 12:08:19 +0000 From: David Woodhouse To: Juergen Gross , xen-devel@lists.xenproject.org CC: Julien Grall Subject: Re: (Ab)using xenstored without Xen User-Agent: K-9 Mail for Android In-Reply-To: References: <22a2352464be2df92dc0d30a955034c59fdf3927.camel@infradead.org> Message-ID: <60DDB54B-41CC-4DE9-83C9-FA20AEEAA9E8@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SRS-Rewrite: SMTP reverse-path rewritten from by desiato.infradead.org. See http://www.infradead.org/rpr.html On 9 January 2023 07:40:06 GMT, Juergen Gross wrote: >Sorry for the late answer, but I was pretty busy before my 3 week time of= f=2E :-) No problem, I had lots of other things to work on, including my own time o= ff=2E Hope you enjoyed it! >On 20=2E12=2E22 13:02, David Woodhouse wrote: >> I've been working on getting qemu to support Xen HVM guests 'natively' >> under KVM: >> https://lore=2Ekernel=2Eorg/qemu-devel/20221216004117=2E862106-1-dwmw2@= infradead=2Eorg/T/ >>=20 >> The basic platform is mostly working and I can start XTF tests with >> 'qemu -kernel'=2E Now it really needs a xenstore=2E >>=20 >> I'm thinking of implementing the basic shared ring support on the qemu >> side, then communicating with the real xenstored over its socket >> interface=2E It would need a 'SU' command in the xenstored protocol to >> make it treat that connection as an unprivileged connection from a >> specific domid, analogous to 'INTRODUCE' but over the existing >> connection=2E > >Wouldn't an "unprivileged" socket make more sense? Not sure=2E I think we still need a privileged operation to "introduce" th= e client domain anyway, don't we? >> However, there might be a bit of work to do first=2E At first, it seeme= d >> like xenstored did start up OK and qemu could even connect to it when >> not running under Xen=2E But that was a checkout from a few months ago, >> and even then it would segfault the first time we try to actually >> *write* any nodes=2E >>=20 >> Newer xenstored breaks even sooner because since commit 60e2f6020 >> ("tools/xenstore: move the call of setup_structure() to dom0 >> introduction") it doesn't even have a tdb_ctx if you start it with the >> -D option, so it segfaults even on running xenstore-ls=2E And if I move >> the tdb part of setup_structure() back to be called from where it was, >> we get a later crash in get_domain_info() because the xc_handle is >> NULL=2E >>=20 >> Which is kind of fair enough, because xenstored is designed to run >> under Xen :) >>=20 >> But what *is* the -D option for? It goes back to commit bddd41366 in >> 2005 whch talks about allowing multiple concurrent transactions, and >> doesn't mention the new option at all=2E It seems to be fairly hosed at >> the moment=2E > >I guess this was some debugging add-on which hasn't been used for ages=2E > >I'm inclined to just remove the -D option=2E Or use it for the new Xenless behaviour perhaps? >> Is it reasonable to attempt "fixing" xenstored to run without actual >> Xen, so that we can use it for virtual Xen support? > >I don't see a major problem with that=2E > >The result shouldn't be too ugly, of course, and I don't see any effort >on Xen side to test any changes for not breaking your use case=2E If anything it possibly makes some test cases a lot easier to run? From xen-devel-bounces@lists.xenproject.org Mon Jan 09 12:08:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 12:08:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473584.734269 (Exim 4.92) (envelope-from ) id 1pEqxB-00025Y-Kb; Mon, 09 Jan 2023 12:08:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473584.734269; Mon, 09 Jan 2023 12:08:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEqxB-00025R-HV; Mon, 09 Jan 2023 12:08:37 +0000 Received: by outflank-mailman (input) for mailman id 473584; Mon, 09 Jan 2023 12:08:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEqx9-0001pa-TV for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 12:08:35 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 55e40d19-9016-11ed-91b6-6bf2151ebd3b; Mon, 09 Jan 2023 13:08:34 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 55e40d19-9016-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1673266114; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=X8smxQVa1GygRZF5ef4Zl6tvClnyvVfOZsr0vV3ltfY=; b=BiV2jukolb08yYA/QWyzghyCjCzr+5Z6jrdpS5UiKpsiJLcaeGvc+P+t RiKLmL3wpDLTMyP6JDtcLW+OCuhdVTPwdx8km3LZOACaoTnuYVIEw7brk L4XkeKptryhzQVcd2pV/f66jqtKPiRUIkT9vHNKihIoZRle45R1vHTQ1p g=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 91779490 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:ibDDP6vE42Pzcz5M42V/L+ChJ+fnVJdeMUV32f8akzHdYApBsoF/q tZmKWHSb//ZYjP2c9t2ad+/pk0G68TWy4VlSws9+Hs3FXwV+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg0HVU/IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj5lv0gnRkPaoQ5AaGxiFPZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwCyI0UkuEld6MwrOSSLFO3NQbcfjbM9ZK0p1g5Wmx4fcORJnCR+PB5MNC3Sd2jcdLdRrcT 5NHM3w1Nk2GOkARfAdMYH49tL7Aan3XWjtUsl+K44Ew5HDe1ldZ27nxKtvFPNeNQK25m27J/ z2ZrjioWnn2MvTB+H254yy9hdblkAnEV6c7KOOc19Bl1Qj7Kms7V0RNCArTTeOColG6c8JSL QoT4CVGhaov8gqtR9r0XRy9qVaFuAIRX5xbFOhSwAKA1KvSpRqYD24sTzhdZdhgv8gzLRQ62 1nMk973CDhHtLyOVWnb5rqStSm1OyUeMSkFfyBsZSkv7sTnoYozpgnSVdslG6mw5uAZAhmpn WrM9nJnwexO04hbjM1X4GwrnRqPtKH1FQkn2j/VX0untiEjdLb4VrynvA2zAel7EK6VSVyIv X4hkseY7fwTAZzlqBFhUNnhD5nyua/bbWS0bUpHWsB4qm/zoyLLkZV4umkWGat/DioTldYFi mf3sBgZ2pJcNWDCgURfM9PoUJRCIUQN+L3YuhHogjhmOMUZmOyvpnsGiausM4fFziARfVkXY 8vzTCpVJS9y5V5b5DS3XfwB9rQg2zozw2jeLbiikUv8i+LEOyLOGehZWLdrUgzfxPneyOky2 48BX/ZmNj0FCLGuCsUp2dJ7wa82wYgTWsmt9p0/mh+rKQt6AmAxY8I9Mpt4E7GJa599z7+Sl lnkAx8w9bYKrSGfQel8Qiw5OeyHsFcWhS5TABHAyn70gSNyOdb+svhCH3b1FJF+nNFeITdPZ 6FtU6297j5nEFwrJxx1gUHBkbFf IronPort-HdrOrdr: A9a23:u444lqq2KJ+jeL4UZyF9KyQaV5rieYIsimQD101hICG9Ffbo9P xG/c566faQsl0ssR4b8+xoVJPsfZr3z+8I3WBpB8bbYOCEggqVxeNZgrcKqgeIcxEWndQy6U 4PScRD4PeZNykfsS/x2njGLz9x+qj/zEiF7d2uqkuEYGlRGsZdBygQMHf4LqVWLDM2Y6bQT/ Knl7F6T2jJQwVsUizsbkN1ItT+mw== X-IronPort-AV: E=Sophos;i="5.96,311,1665460800"; d="scan'208";a="91779490" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Jun Nakajima , Kevin Tian Subject: [PATCH 0/2] x86/vmx: Don't crash guests when there is no model-specific LBRs available Date: Mon, 9 Jan 2023 12:08:26 +0000 Message-ID: <20230109120828.344-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit This is the minimum bodge required to stop guests crashing on Sapphire Rapids hardware. Note that both Arch LBR and safely (in terms of migration) enumerating PDCM/MSR_PERF_CAPS depend on improved MSR levelling support which is still not yet complete. i.e. We cannot do the second half (enumerating LBR_FORMAT=0x3f) yet because we'll make it more likely for VMs to crash in migrate. Andrew Cooper (2): x86/vmx: Calculate model-specific LBRs once at start of day x86/vmx: Support for CPUs without model-specific LBR xen/arch/x86/hvm/vmx/vmx.c | 307 +++++++++++++++++++++++---------------------- 1 file changed, 155 insertions(+), 152 deletions(-) -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Mon Jan 09 12:08:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 12:08:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473585.734280 (Exim 4.92) (envelope-from ) id 1pEqxC-0002M1-V5; Mon, 09 Jan 2023 12:08:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473585.734280; Mon, 09 Jan 2023 12:08:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEqxC-0002Lu-QY; Mon, 09 Jan 2023 12:08:38 +0000 Received: by outflank-mailman (input) for mailman id 473585; Mon, 09 Jan 2023 12:08:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEqxB-0001pa-35 for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 12:08:37 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 57ecce77-9016-11ed-91b6-6bf2151ebd3b; Mon, 09 Jan 2023 13:08:36 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 57ecce77-9016-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1673266116; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=8U+oMbjFcnCWKV1GHRn181dRulE+W90T2RctIPLLxek=; b=iEvuOkm38xhLg8CC9uODx5ELqS16A68TvM18bHfSTo1i6WgGPr6HwmY4 BfIg73wcQkpshyJ9QddV3THqckAaMtbYZDwfQDBmO2llR4hIKLLS9eLqq 27yhkvUvv0VxUEGFqarik2TREkH/q3ApD613PtIKEcuW0hQ4tMUKnJpck 4=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 91779491 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:b+85kq0sNJ2BzgzCevbD5RJxkn2cJEfYwER7XKvMYLTBsI5bp2YCy 2QWWj3UOf6PN2b8eox/OYu/oxkOvZSHyN9jHQc9pC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK5ULSfUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS9nuDgNyo4GlD5gVmNKgR1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfJjkR1 eE+KSg3MgmnoeCy27S5dOJeiZF2RCXrFNt3VnBIyDjYCbAtQIzZQrWM7thdtNsyrpkQR7CEP ZNfMGcxKkSbC/FMEg5/5JYWteGknHTgNRZfr0qYv/Ef6GnP1g1hlrPqNbI5f/TbHJoKzxrJ/ woq+UzGIiMLMM2T0wGq73yni+zgvQflf5orQejQGvlC3wTImz175ActfVmmp7+/g023WdNaI mQV/DYjqe4580nDZtrwQRy+5mKFtxg0WtxMHul84waIooLL5y6JC25CSSROAPQ2uclzSTE02 1uhm9LyGScpoLCTUWia9LqfsXW1Iyd9BU0oaDIATAAFy8L+u4x1hRXKJuuPC4bs0IezQ2uph WnX8m5u3N3/kPLnyY2cpQ/nnhStvqKVVyoT5AHMWGCb5TF2MdvNi5OT1XDX6vNJLYC8R1aHv WQZl8X20N3iHa1hhwTWHrxTQejBC+KtdWSF3AUxR8VJGyGFoSbLQGxG3N1pyK6F2O4gcCShX kLcsBg5CHR7bCrzNv8fj25c5q0XIUnc+TbNDK28gjlmOMIZmOq7EMZGOyatM5jFyhRErE3GE c7znTyQJXgbE7976zG9Wv0Q17QmrghnmzyIH8ihkEj8geXCDJJwdVvjGAHUBgzexPrayDg5D v4Fb5fao/mheLGWjtbrHX47cglRcClT6WHeoM1LbO+TSjeK60l4Y8I9NYgJItQ/94wMz7egw 51IchMAoLYJrSGdeFrih7EKQO+HYKuTWlpnZ3d9ZQb5hSd+CWtthY9GH6YKkXAc3LQL5ZZJo zMtIq1s3twnpuz7xgkg IronPort-HdrOrdr: A9a23:hjsV8KM0FOT0JcBcTgijsMiBIKoaSvp037BN7TETdfU1SKylfq WV98jzuiWftN98YhwdcPq7SdW9qArnhOZICOoqXItKPjOIhILAFugL0WKI+VPd8kPFmtK0/8 9bAsxD4dfLfCdHZJbBkXCF+/pJ+qjjzEiE7d2uqEuEYmlRGsNdByYQMHf8LqUsLDM2fqbQRv Knl7B6T2zJQwVrUviG X-IronPort-AV: E=Sophos;i="5.96,311,1665460800"; d="scan'208";a="91779491" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Jun Nakajima , Kevin Tian Subject: [PATCH 2/2] x86/vmx: Support for CPUs without model-specific LBR Date: Mon, 9 Jan 2023 12:08:28 +0000 Message-ID: <20230109120828.344-3-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20230109120828.344-1-andrew.cooper3@citrix.com> References: <20230109120828.344-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Ice Lake (server at least) has both Arch LBR and model-specific LBR. Sapphire Rapids does not have model-specific LBR at all. I.e. On SPR and later, model_specific_lbr will always be NULL, so we must make changes to avoid reliably hitting the domain_crash(). The Arch LBR spec states that CPUs without model-specific LBR implement MSR_DBG_CTL.LBR by discarding writes and always returning 0. Do this for any CPU for which we lack model-specific LBR information. Adjust the now-stale comment, now that the Arch LBR spec has created a way to signal "no model specific LBR" to guests. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu CC: Jun Nakajima CC: Kevin Tian --- xen/arch/x86/hvm/vmx/vmx.c | 31 ++++++++++++++++--------------- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index 17320f9fb267..c76b09391c76 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -3555,17 +3555,25 @@ static int cf_check vmx_msr_write_intercept( goto gp_fault; /* + * The Arch LBR spec (new in Ice Lake) states that CPUs with no + * model-specific LBRs implement MSR_DBG_CTL.LBR by discarding writes + * and always returning 0. + * + * Use this property in all cases where we don't know any + * model-specific LBR information, as it matches real hardware + * behaviour on post-Ice Lake systems. + */ + if ( !model_specific_lbr ) + msr_content &= ~IA32_DEBUGCTLMSR_LBR; + + /* * When a guest first enables LBR, arrange to save and restore the LBR * MSRs and allow the guest direct access. * - * MSR_DEBUGCTL and LBR has existed almost as long as MSRs have - * existed, and there is no architectural way to hide the feature, or - * fail the attempt to enable LBR. - * - * Unknown host LBR MSRs or hitting -ENOSPC with the guest load/save - * list are definitely hypervisor bugs, whereas -ENOMEM for allocating - * the load/save list is simply unlucky (and shouldn't occur with - * sensible management by the toolstack). + * Hitting -ENOSPC with the guest load/save list is definitely a + * hypervisor bug, whereas -ENOMEM for allocating the load/save list + * is simply unlucky (and shouldn't occur with sensible management by + * the toolstack). * * Either way, there is nothing we can do right now to recover, and * the guest won't execute correctly either. Simply crash the domain @@ -3576,13 +3584,6 @@ static int cf_check vmx_msr_write_intercept( { const struct lbr_info *lbr = model_specific_lbr; - if ( unlikely(!lbr) ) - { - gprintk(XENLOG_ERR, "Unknown Host LBR MSRs\n"); - domain_crash(v->domain); - return X86EMUL_OKAY; - } - for ( ; lbr->count; lbr++ ) { unsigned int i; -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Mon Jan 09 12:09:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 12:09:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473593.734291 (Exim 4.92) (envelope-from ) id 1pEqxb-00038x-7O; Mon, 09 Jan 2023 12:09:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473593.734291; Mon, 09 Jan 2023 12:09:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEqxb-00038q-47; Mon, 09 Jan 2023 12:09:03 +0000 Received: by outflank-mailman (input) for mailman id 473593; Mon, 09 Jan 2023 12:09:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEqxa-00031g-9t for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 12:09:02 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 64b2d057-9016-11ed-b8d0-410ff93cb8f0; Mon, 09 Jan 2023 13:08:59 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 64b2d057-9016-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1673266139; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=m7oq3+yXJxv1JJKdBmmrPVeWQ6KupvyHV6r1iw6a5S0=; b=TQDax71N9I1YY3Aa3vI4IbSXYhyEryNjpaZK31Buv/jM+wDYVhFCNajn P5cz36zMF/Nh9ipMjKDxoPoQylAhmzBos8F4CG8k8rIxq7q6fv60KSm1m cVOYieWBT41ULMcosx31+UohSnx9vSEJTXvJA1Aa4maS5rgV+g6LENsuf U=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 91739042 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:mAtMeKmQx3zQ/QYF4pNKpdno5gxAJkRdPkR7XQ2eYbSJt1+Wr1Gzt xIYWTrUbP3fYWr8LdxxYd+1/UsFuJHdmtUyTwY/+ythFCMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icf3grHmeIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aqaVA8w5ARkPqgS5A6GzRH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 fIAC2knSAGpvfy3wK38esVmg+RyDuC+aevzulk4pd3YJfMvQJSFSKTW/95Imjw3g6iiH96HO ZBfM2A2Kk2dPVsfYT/7C7pn9AusrlD5fydVtxS+oq0v7nKI5AdwzKLsIJzefdniqcB9zx/H/ TOeoz6R7hcyKey1lgLY9FKVq+rXrTLYebBCV4D/+as/6LGU7jNKU0BHPbehmtGmjmauVtQZL FYbkgIssK508kWoR9v8WhSQoXiYsxpaUN1Ve8U55R+MzOzI4g+fLmkCUjNFLtchsaceVTEsk 1OEgd7tLThuq6GOD2KQ8K+OqjG/MjRTKnUNDQcmZwYY59jooKkokwnCCN1kFcaIYsbdQG+qh WrQ9W5n2utV3ZVjO7iHEU7vjSqP/7LvXyQP+ATXQSWVwgl8RN+HTtn9gbTE1spoIIGcR1iHm XELncmC8ewDZa2weDyxrPYlR+/wuavcWNHIqRs2RsR6qWzxk5K2VdoIiAySMnuFJSrtldXBR EbI8T1c65ZIVJdBRf8mOtnhYyjGIEWJKDgEahw2RoATCnSSXFXdlM2LWaJ39z6FraTUuftjU ap3iO71ZZrgNYxpzSCtW8AW2qIxyyY1yAv7HM6klE7/i+XCPy7KFd/p1WdiiMhjtstoRy2Mr b5i2zaikU0DAIUSnAGLmWLsEbz6BSdiXs2nwyCmXuWCPhBnCAkc5wz5mNscl3het/0NzI/gp yjtMnK0PXKj3RUr3y3WMCE8AF4uNL4jxU8G0dsEYQzziiBzMNjwsc/ytfIfJNEayQCq9tYsJ 9FtRilKKq4npujvk9jFUaTAkQ== IronPort-HdrOrdr: A9a23:OBj1za4xFFZ6abg+IQPXwPDXdLJyesId70hD6qhwISY6TiX+rb HWoB17726TtN9/YhEdcLy7VJVoBEmskKKdgrNhWotKPjOW21dARbsKheCJrgEIWReOktK1vZ 0QC5SWY+eQMbEVt6nHCXGDYrQd/OU= X-IronPort-AV: E=Sophos;i="5.96,311,1665460800"; d="scan'208";a="91739042" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Jun Nakajima , Kevin Tian Subject: [PATCH 1/2] x86/vmx: Calculate model-specific LBRs once at start of day Date: Mon, 9 Jan 2023 12:08:27 +0000 Message-ID: <20230109120828.344-2-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20230109120828.344-1-andrew.cooper3@citrix.com> References: <20230109120828.344-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit There is no point repeating this calculation at runtime, especially as it is in the fallback path of the WRSMR/RDMSR handlers. Move the infrastructure higher in vmx.c to avoid forward declarations, renaming last_branch_msr_get() to get_model_specific_lbr() to highlight that these are model-specific only. No practical change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu CC: Jun Nakajima CC: Kevin Tian --- xen/arch/x86/hvm/vmx/vmx.c | 276 +++++++++++++++++++++++---------------------- 1 file changed, 139 insertions(+), 137 deletions(-) diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index 43a4865d1c76..17320f9fb267 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -396,6 +396,142 @@ void vmx_pi_hooks_deassign(struct domain *d) domain_unpause(d); } +static const struct lbr_info { + u32 base, count; +} p4_lbr[] = { + { MSR_P4_LER_FROM_LIP, 1 }, + { MSR_P4_LER_TO_LIP, 1 }, + { MSR_P4_LASTBRANCH_TOS, 1 }, + { MSR_P4_LASTBRANCH_0_FROM_LIP, NUM_MSR_P4_LASTBRANCH_FROM_TO }, + { MSR_P4_LASTBRANCH_0_TO_LIP, NUM_MSR_P4_LASTBRANCH_FROM_TO }, + { 0, 0 } +}, c2_lbr[] = { + { MSR_IA32_LASTINTFROMIP, 1 }, + { MSR_IA32_LASTINTTOIP, 1 }, + { MSR_C2_LASTBRANCH_TOS, 1 }, + { MSR_C2_LASTBRANCH_0_FROM_IP, NUM_MSR_C2_LASTBRANCH_FROM_TO }, + { MSR_C2_LASTBRANCH_0_TO_IP, NUM_MSR_C2_LASTBRANCH_FROM_TO }, + { 0, 0 } +}, nh_lbr[] = { + { MSR_IA32_LASTINTFROMIP, 1 }, + { MSR_IA32_LASTINTTOIP, 1 }, + { MSR_NHL_LBR_SELECT, 1 }, + { MSR_NHL_LASTBRANCH_TOS, 1 }, + { MSR_P4_LASTBRANCH_0_FROM_LIP, NUM_MSR_P4_LASTBRANCH_FROM_TO }, + { MSR_P4_LASTBRANCH_0_TO_LIP, NUM_MSR_P4_LASTBRANCH_FROM_TO }, + { 0, 0 } +}, sk_lbr[] = { + { MSR_IA32_LASTINTFROMIP, 1 }, + { MSR_IA32_LASTINTTOIP, 1 }, + { MSR_NHL_LBR_SELECT, 1 }, + { MSR_NHL_LASTBRANCH_TOS, 1 }, + { MSR_SKL_LASTBRANCH_0_FROM_IP, NUM_MSR_SKL_LASTBRANCH }, + { MSR_SKL_LASTBRANCH_0_TO_IP, NUM_MSR_SKL_LASTBRANCH }, + { MSR_SKL_LASTBRANCH_0_INFO, NUM_MSR_SKL_LASTBRANCH }, + { 0, 0 } +}, at_lbr[] = { + { MSR_IA32_LASTINTFROMIP, 1 }, + { MSR_IA32_LASTINTTOIP, 1 }, + { MSR_C2_LASTBRANCH_TOS, 1 }, + { MSR_C2_LASTBRANCH_0_FROM_IP, NUM_MSR_ATOM_LASTBRANCH_FROM_TO }, + { MSR_C2_LASTBRANCH_0_TO_IP, NUM_MSR_ATOM_LASTBRANCH_FROM_TO }, + { 0, 0 } +}, sm_lbr[] = { + { MSR_IA32_LASTINTFROMIP, 1 }, + { MSR_IA32_LASTINTTOIP, 1 }, + { MSR_SM_LBR_SELECT, 1 }, + { MSR_SM_LASTBRANCH_TOS, 1 }, + { MSR_C2_LASTBRANCH_0_FROM_IP, NUM_MSR_ATOM_LASTBRANCH_FROM_TO }, + { MSR_C2_LASTBRANCH_0_TO_IP, NUM_MSR_ATOM_LASTBRANCH_FROM_TO }, + { 0, 0 } +}, gm_lbr[] = { + { MSR_IA32_LASTINTFROMIP, 1 }, + { MSR_IA32_LASTINTTOIP, 1 }, + { MSR_SM_LBR_SELECT, 1 }, + { MSR_SM_LASTBRANCH_TOS, 1 }, + { MSR_GM_LASTBRANCH_0_FROM_IP, NUM_MSR_GM_LASTBRANCH_FROM_TO }, + { MSR_GM_LASTBRANCH_0_TO_IP, NUM_MSR_GM_LASTBRANCH_FROM_TO }, + { 0, 0 } +}; +static const struct lbr_info * __ro_after_init model_specific_lbr; + +static const struct __init lbr_info *get_model_specific_lbr(void) +{ + switch ( boot_cpu_data.x86 ) + { + case 6: + switch ( boot_cpu_data.x86_model ) + { + /* Core2 Duo */ + case 0x0f: + /* Enhanced Core */ + case 0x17: + /* Xeon 7400 */ + case 0x1d: + return c2_lbr; + /* Nehalem */ + case 0x1a: case 0x1e: case 0x1f: case 0x2e: + /* Westmere */ + case 0x25: case 0x2c: case 0x2f: + /* Sandy Bridge */ + case 0x2a: case 0x2d: + /* Ivy Bridge */ + case 0x3a: case 0x3e: + /* Haswell */ + case 0x3c: case 0x3f: case 0x45: case 0x46: + /* Broadwell */ + case 0x3d: case 0x47: case 0x4f: case 0x56: + return nh_lbr; + /* Skylake */ + case 0x4e: case 0x5e: + /* Xeon Scalable */ + case 0x55: + /* Cannon Lake */ + case 0x66: + /* Goldmont Plus */ + case 0x7a: + /* Ice Lake */ + case 0x6a: case 0x6c: case 0x7d: case 0x7e: + /* Tiger Lake */ + case 0x8c: case 0x8d: + /* Tremont */ + case 0x86: + /* Kaby Lake */ + case 0x8e: case 0x9e: + /* Comet Lake */ + case 0xa5: case 0xa6: + return sk_lbr; + /* Atom */ + case 0x1c: case 0x26: case 0x27: case 0x35: case 0x36: + return at_lbr; + /* Silvermont */ + case 0x37: case 0x4a: case 0x4d: case 0x5a: case 0x5d: + /* Xeon Phi Knights Landing */ + case 0x57: + /* Xeon Phi Knights Mill */ + case 0x85: + /* Airmont */ + case 0x4c: + return sm_lbr; + /* Goldmont */ + case 0x5c: case 0x5f: + return gm_lbr; + } + break; + + case 15: + switch ( boot_cpu_data.x86_model ) + { + /* Pentium4/Xeon with em64t */ + case 3: case 4: case 6: + return p4_lbr; + } + break; + } + + return NULL; +} + static int cf_check vmx_domain_initialise(struct domain *d) { static const struct arch_csw csw = { @@ -2846,6 +2982,7 @@ const struct hvm_function_table * __init start_vmx(void) vmx_function_table.tsc_scaling.setup = vmx_setup_tsc_scaling; } + model_specific_lbr = get_model_specific_lbr(); lbr_tsx_fixup_check(); ler_to_fixup_check(); @@ -2992,141 +3129,6 @@ static int vmx_cr_access(cr_access_qual_t qual) return X86EMUL_OKAY; } -static const struct lbr_info { - u32 base, count; -} p4_lbr[] = { - { MSR_P4_LER_FROM_LIP, 1 }, - { MSR_P4_LER_TO_LIP, 1 }, - { MSR_P4_LASTBRANCH_TOS, 1 }, - { MSR_P4_LASTBRANCH_0_FROM_LIP, NUM_MSR_P4_LASTBRANCH_FROM_TO }, - { MSR_P4_LASTBRANCH_0_TO_LIP, NUM_MSR_P4_LASTBRANCH_FROM_TO }, - { 0, 0 } -}, c2_lbr[] = { - { MSR_IA32_LASTINTFROMIP, 1 }, - { MSR_IA32_LASTINTTOIP, 1 }, - { MSR_C2_LASTBRANCH_TOS, 1 }, - { MSR_C2_LASTBRANCH_0_FROM_IP, NUM_MSR_C2_LASTBRANCH_FROM_TO }, - { MSR_C2_LASTBRANCH_0_TO_IP, NUM_MSR_C2_LASTBRANCH_FROM_TO }, - { 0, 0 } -}, nh_lbr[] = { - { MSR_IA32_LASTINTFROMIP, 1 }, - { MSR_IA32_LASTINTTOIP, 1 }, - { MSR_NHL_LBR_SELECT, 1 }, - { MSR_NHL_LASTBRANCH_TOS, 1 }, - { MSR_P4_LASTBRANCH_0_FROM_LIP, NUM_MSR_P4_LASTBRANCH_FROM_TO }, - { MSR_P4_LASTBRANCH_0_TO_LIP, NUM_MSR_P4_LASTBRANCH_FROM_TO }, - { 0, 0 } -}, sk_lbr[] = { - { MSR_IA32_LASTINTFROMIP, 1 }, - { MSR_IA32_LASTINTTOIP, 1 }, - { MSR_NHL_LBR_SELECT, 1 }, - { MSR_NHL_LASTBRANCH_TOS, 1 }, - { MSR_SKL_LASTBRANCH_0_FROM_IP, NUM_MSR_SKL_LASTBRANCH }, - { MSR_SKL_LASTBRANCH_0_TO_IP, NUM_MSR_SKL_LASTBRANCH }, - { MSR_SKL_LASTBRANCH_0_INFO, NUM_MSR_SKL_LASTBRANCH }, - { 0, 0 } -}, at_lbr[] = { - { MSR_IA32_LASTINTFROMIP, 1 }, - { MSR_IA32_LASTINTTOIP, 1 }, - { MSR_C2_LASTBRANCH_TOS, 1 }, - { MSR_C2_LASTBRANCH_0_FROM_IP, NUM_MSR_ATOM_LASTBRANCH_FROM_TO }, - { MSR_C2_LASTBRANCH_0_TO_IP, NUM_MSR_ATOM_LASTBRANCH_FROM_TO }, - { 0, 0 } -}, sm_lbr[] = { - { MSR_IA32_LASTINTFROMIP, 1 }, - { MSR_IA32_LASTINTTOIP, 1 }, - { MSR_SM_LBR_SELECT, 1 }, - { MSR_SM_LASTBRANCH_TOS, 1 }, - { MSR_C2_LASTBRANCH_0_FROM_IP, NUM_MSR_ATOM_LASTBRANCH_FROM_TO }, - { MSR_C2_LASTBRANCH_0_TO_IP, NUM_MSR_ATOM_LASTBRANCH_FROM_TO }, - { 0, 0 } -}, gm_lbr[] = { - { MSR_IA32_LASTINTFROMIP, 1 }, - { MSR_IA32_LASTINTTOIP, 1 }, - { MSR_SM_LBR_SELECT, 1 }, - { MSR_SM_LASTBRANCH_TOS, 1 }, - { MSR_GM_LASTBRANCH_0_FROM_IP, NUM_MSR_GM_LASTBRANCH_FROM_TO }, - { MSR_GM_LASTBRANCH_0_TO_IP, NUM_MSR_GM_LASTBRANCH_FROM_TO }, - { 0, 0 } -}; - -static const struct lbr_info *last_branch_msr_get(void) -{ - switch ( boot_cpu_data.x86 ) - { - case 6: - switch ( boot_cpu_data.x86_model ) - { - /* Core2 Duo */ - case 0x0f: - /* Enhanced Core */ - case 0x17: - /* Xeon 7400 */ - case 0x1d: - return c2_lbr; - /* Nehalem */ - case 0x1a: case 0x1e: case 0x1f: case 0x2e: - /* Westmere */ - case 0x25: case 0x2c: case 0x2f: - /* Sandy Bridge */ - case 0x2a: case 0x2d: - /* Ivy Bridge */ - case 0x3a: case 0x3e: - /* Haswell */ - case 0x3c: case 0x3f: case 0x45: case 0x46: - /* Broadwell */ - case 0x3d: case 0x47: case 0x4f: case 0x56: - return nh_lbr; - /* Skylake */ - case 0x4e: case 0x5e: - /* Xeon Scalable */ - case 0x55: - /* Cannon Lake */ - case 0x66: - /* Goldmont Plus */ - case 0x7a: - /* Ice Lake */ - case 0x6a: case 0x6c: case 0x7d: case 0x7e: - /* Tiger Lake */ - case 0x8c: case 0x8d: - /* Tremont */ - case 0x86: - /* Kaby Lake */ - case 0x8e: case 0x9e: - /* Comet Lake */ - case 0xa5: case 0xa6: - return sk_lbr; - /* Atom */ - case 0x1c: case 0x26: case 0x27: case 0x35: case 0x36: - return at_lbr; - /* Silvermont */ - case 0x37: case 0x4a: case 0x4d: case 0x5a: case 0x5d: - /* Xeon Phi Knights Landing */ - case 0x57: - /* Xeon Phi Knights Mill */ - case 0x85: - /* Airmont */ - case 0x4c: - return sm_lbr; - /* Goldmont */ - case 0x5c: case 0x5f: - return gm_lbr; - } - break; - - case 15: - switch ( boot_cpu_data.x86_model ) - { - /* Pentium4/Xeon with em64t */ - case 3: case 4: case 6: - return p4_lbr; - } - break; - } - - return NULL; -} - enum { LBR_FORMAT_32 = 0x0, /* 32-bit record format */ @@ -3233,7 +3235,7 @@ static void __init ler_to_fixup_check(void) static int is_last_branch_msr(u32 ecx) { - const struct lbr_info *lbr = last_branch_msr_get(); + const struct lbr_info *lbr = model_specific_lbr; if ( lbr == NULL ) return 0; @@ -3572,7 +3574,7 @@ static int cf_check vmx_msr_write_intercept( if ( !(v->arch.hvm.vmx.lbr_flags & LBR_MSRS_INSERTED) && (msr_content & IA32_DEBUGCTLMSR_LBR) ) { - const struct lbr_info *lbr = last_branch_msr_get(); + const struct lbr_info *lbr = model_specific_lbr; if ( unlikely(!lbr) ) { -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Mon Jan 09 13:02:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 13:02:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473610.734302 (Exim 4.92) (envelope-from ) id 1pErmu-0001II-72; Mon, 09 Jan 2023 13:02:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473610.734302; Mon, 09 Jan 2023 13:02:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pErmu-0001IB-3i; Mon, 09 Jan 2023 13:02:04 +0000 Received: by outflank-mailman (input) for mailman id 473610; Mon, 09 Jan 2023 13:02:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pErms-0001I5-Kc for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 13:02:02 +0000 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [2a00:1450:4864:20::52d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ce42a66c-901d-11ed-91b6-6bf2151ebd3b; Mon, 09 Jan 2023 14:02:00 +0100 (CET) Received: by mail-ed1-x52d.google.com with SMTP id 18so12376231edw.7 for ; Mon, 09 Jan 2023 05:02:00 -0800 (PST) Received: from 2a02.2378.102e.bce5.ip.kyivstar.net ([2a02:2378:102e:bce5:dfc0:9312:b994:6b21]) by smtp.gmail.com with ESMTPSA id ch17-20020a0564021bd100b004585eba4baesm3707013edb.80.2023.01.09.05.01.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 05:01:59 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ce42a66c-901d-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=VL3jfDiNUYbqOELuZt5dZ3P1mshWkZMGXFgg0J+f4Qg=; b=YCHzlmY8elUGdxQDlNgEocdnRTVqJFqqPrQtJzJGjMd98YTvCpEbEwWUSaLlOTDNwX NhrKwwLyKwgvDjeHJqF1WBBO8jpo2gjDvnAJJjpNVxMMsvCgHYPqJ3f7uI3j2BGVG+IB 4jHZmPyE4OX0j2MIaWlzb1WCs02fk7WvkFzr45dHjNTnyp/SmhM6jcb4FKJUjV7DuIkq SUsNAFyB20GGUdgnpmDkuomwLiBaEuIYoQyWmH74gxyPDjFmMsNjNEDJE9VYJZ+VuKBj SOSBNNRzxRkR6MfTCFKF/lTEkWyEVH9BhCQ6Qq1CZsvukzVXZOYuUSjfE7MB2RnQ095f j1sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=VL3jfDiNUYbqOELuZt5dZ3P1mshWkZMGXFgg0J+f4Qg=; b=3EUf57WYj/YCwOZlvkMNpbEQ2T2AcOj8mso5hil3Hx6cc7KZ82iL9Fzw0f7a3gi2WU Y8ZNEkCiQyopCCOBwHoMy4nzidlpojKpWoEHRz8w8TNsaGjEed4OlpfXJtdTRf1wY21W oDFavHADv1CcVMNcuXe4CUseEbRSc4FJnFFJ1c9ZB21EXmNhLP8adtsYktRYJ6QkqRAp r1SF46NvQN7p4w3WYU1Jc02QyAu/psU/b4AtsseZLrzAFJIWtsglWlc/JDycXAH6LKvu Oe01eXVaZoGNQeYFrZrn/+b35xoxsKS1bFd0LdcqvERbnE2EawHjuUF1nEuGGMkqg0T0 cWIw== X-Gm-Message-State: AFqh2koN1kq+eTyZBLlbsklL4rjs0u0UQlCES02YQ0F4aNSmtzVIOts0 ONcPh9ssE+ko8DQ+2XRltu8= X-Google-Smtp-Source: AMrXdXsPP2m+OTQBykqALpdCEv2sU9yIgaVoNx24f2Dv27Y0z1oh6SHNAuEylft9mxjswOnYbylfWg== X-Received: by 2002:a05:6402:2202:b0:48e:bb08:c96 with SMTP id cq2-20020a056402220200b0048ebb080c96mr20115152edb.28.1673269320300; Mon, 09 Jan 2023 05:02:00 -0800 (PST) Message-ID: <7abe43df7db5a7ec969cca9ec360c0de6fbf523d.camel@gmail.com> Subject: Re: [PATCH v1 4/8] xen/riscv: introduce sbi call to putchar to console From: Oleksii To: Andrew Cooper , Bobby Eshleman Cc: "xen-devel@lists.xenproject.org" , Stefano Stabellini , Gianluca Guida , Alistair Francis , Connor Davis Date: Mon, 09 Jan 2023 15:01:57 +0200 In-Reply-To: <320cc1b3-f03f-ad87-205f-d3c5db446f7d@citrix.com> References: <09da5a3184242152af6af060720a007738a55d6e.1673009740.git.oleksii.kurochko@gmail.com> <320cc1b3-f03f-ad87-205f-d3c5db446f7d@citrix.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.1 (3.46.1-1.fc37) MIME-Version: 1.0 On Fri, 2023-01-06 at 17:16 +0000, Andrew Cooper wrote: > On 20/12/2022 6:23 am, Bobby Eshleman wrote: > > On Fri, Jan 06, 2023 at 03:14:25PM +0200, Oleksii Kurochko wrote: > > > The patch introduce sbi_putchar() SBI call which is necessary > > > to implement initial early_printk > > >=20 > > I think that it might be wise to start off with an alternative to > > sbi_putchar() since it is already planned for deprecation. I > > realize > > that this will require rework, but it is almost guaranteed that > > early_printk() will break on future SBI implementations if using > > this > > SBI call. IIRC, Xen/ARM's early printk looked like a reasonable > > analogy > > for how it could work on RISC-V, IMHO. >=20 > Hmm, we're using it as a stopgap right now in CI so we can break > "upstream RISC-V support" into manageable chunks. >=20 > So perhaps we want to forgo plumbing sbi_putchar() into > early_printk()=C2=A0 > (to avoid giving the impression that this will stay around in the > future) and use sbi_putchar() directly for the hello world print. >=20 > Next, we focus on getting the real uart driver working along with > real > printk (rather than focusing on exceptions which was going to be the > next task), and we can drop sbi_putchar() entirely. >=20 > Thoughts? >=20 I think it would be better to remain it as it is done now and add TODO comment "TODO: rewrite early_printk() to use uart directly as sbi_putchar() is already planned for deprecation" and update the commit message too. After real uart will be ready it will be easy to remove sbi_putchar() and do something similar to ARM early printk implementation. > ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Jan 09 13:10:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 13:10:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473615.734313 (Exim 4.92) (envelope-from ) id 1pErv6-0002n2-1v; Mon, 09 Jan 2023 13:10:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473615.734313; Mon, 09 Jan 2023 13:10:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pErv5-0002mv-V3; Mon, 09 Jan 2023 13:10:31 +0000 Received: by outflank-mailman (input) for mailman id 473615; Mon, 09 Jan 2023 13:10:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pErv4-0002ml-Rv; Mon, 09 Jan 2023 13:10:30 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pErv4-0005sw-Pi; Mon, 09 Jan 2023 13:10:30 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pErv4-0003xz-Cf; Mon, 09 Jan 2023 13:10:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pErv4-0002GM-CF; Mon, 09 Jan 2023 13:10:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=7UgZepBJVEQhjpUbIeMGhEmr0z8B9mwKmFT/rr1IwIU=; b=IZWV/ID/2QCC2o0vYGQWxs7l7G tyGly7jBeUa7LOTvaagb5HGuOEMqS8RVB/uSvg9MCX7yWkbGhZ7j/LZVttyFWp70wJOQGCTHOUPWo RnjBwKdaebKEZHhaQCZM44Ud4MIs8/jBNL9NlTMqzDD9B2hu9SBrq89C6vyOLBKQ8IwQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 175637: FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-credit2::broken:regression qemu-mainline:test-amd64-amd64-xl-credit2:host-install(5):broken:heisenbug qemu-mainline:test-arm64-arm64-xl:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=528d9f33cad5245c1099d77084c78bb2244d5143 X-Osstest-Versions-That: qemuu=0ab12aa32462817f0a53fa6f6ce4baf664ef1713 From: osstest service owner Date: Mon, 09 Jan 2023 13:10:30 +0000 flight 175637 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/175637/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-credit2 broken in 175629 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-credit2 5 host-install(5) broken in 175629 pass in 175637 test-arm64-arm64-xl 18 guest-start/debian.repeat fail pass in 175629 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 175623 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 175623 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175623 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175623 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 175623 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 175623 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175623 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175623 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu 528d9f33cad5245c1099d77084c78bb2244d5143 baseline version: qemuu 0ab12aa32462817f0a53fa6f6ce4baf664ef1713 Last test of basis 175623 2023-01-07 23:09:00 Z 1 days Testing same since 175627 2023-01-08 14:40:14 Z 0 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Peter Maydell Richard Henderson jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-xl-credit2 broken Not pushing. (No revision log; it would be 378 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Jan 09 13:38:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 13:38:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473626.734324 (Exim 4.92) (envelope-from ) id 1pEsLp-0005NZ-M6; Mon, 09 Jan 2023 13:38:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473626.734324; Mon, 09 Jan 2023 13:38:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEsLp-0005NS-JJ; Mon, 09 Jan 2023 13:38:09 +0000 Received: by outflank-mailman (input) for mailman id 473626; Mon, 09 Jan 2023 13:38:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEsLo-0005N6-7R for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 13:38:08 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2088.outbound.protection.outlook.com [40.107.22.88]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d8a57d8d-9022-11ed-b8d0-410ff93cb8f0; Mon, 09 Jan 2023 14:38:05 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM7PR04MB6936.eurprd04.prod.outlook.com (2603:10a6:20b:106::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Mon, 9 Jan 2023 13:38:04 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5986.018; Mon, 9 Jan 2023 13:38:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d8a57d8d-9022-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=azxAq4dpjPYPh1WxjdhC7LKnUkyoq4ctCCAc+zjR7bW40oWrXYmf5E1HwhTO3ccX1Z3rsBlULiqxf3qwt7ESus8XeZ98Qk6Z+bLeU7eEypi1OcULV+HLY2bvCDFnnaKyVB3yrUWGUmoYIgIPbOlXlB2chMYK0sm/GnElQYLVoIPLllyHg4c1N+bjbio3qY4iZOsdvTIfaq2yPz7hfEXHShd+6h4+/iyHB/id7cy5oHbIIrbBUUz4b/7O3+owYLFfKNMTi6WieY0bdz2CwWroMr/h9PMphrDWKglSm68+c3dX426AY/z8jYxW6Wub88y2Hz7PRLT3QhTyfJfb7/gTwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=m9o4UrkbsEgoHelMxnH7a7O4Qq+EJzc3EuuaLl0O0G8=; b=hbI3qgqYIgFE5oDcly9xKHvsCs6hqFql/pR+KeFg3VFAzbEGC9hOLXb8QTjcrnoIzsS7raa8XWH52iNps51dtzz4ThdYjUjU1iryYKvsKBnVeug4FWvmOfWUXEpkKpKpXq6lxoMNcJFdXvtMoR1BoRAl8yRcW9ltWFXXSEFiyOiZgVB7LKHzrn7GW8M6wppTan/JV7AvBqhjgEwD3ynmrpmbSfUJu0P1OULhfRPhS4PyOP5AX9lW8l818FWLEmhTGysZZWWvkORayr/3o7lrahLQkTwg2Uk4k1HiX70V56GmWQQoNwXqojnih97Uru/nAoQWZzGyxvzpet5UEyLOlw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m9o4UrkbsEgoHelMxnH7a7O4Qq+EJzc3EuuaLl0O0G8=; b=VuHszqQ3az6uUEek1rWCetPlt5PxfgGPvqgHDPXimnD/GJqigyBgdaQldBhP8mXv8E6pLcMjPsn/kYBNLUkKAHBO9nCk/6Q1Jr9VLvcV338BqFCu4wk4wktfGUCFvXHTASL5yg3XpsymvJLSTn4qxSoH2TFBsFrtKjcPOyOgagXjW9uSPj/YlWIDz30IT+LaZx0llbxymV7H44u6e+cGs5jfkiBwKIKmB9TfWlEhCWCrDFGFr0e3U/AV7jsvMZ3xT6e3VN/NSqG2AU+4JOsSPCkNOVLeYqdRsBo91CM8sizXz5ONb+7Aj248tvhcAIvA+Yq4QJTOCEijIUjDHQoW4w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <882f700f-9d79-67d5-7e13-e42c3c79ba11@suse.com> Date: Mon, 9 Jan 2023 14:38:01 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 From: Jan Beulich Subject: [PATCH v2 0/5] x86/mm: address aspects noticed during XSA-410 work To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Tim Deegan Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0128.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM7PR04MB6936:EE_ X-MS-Office365-Filtering-Correlation-Id: c1ddda3e-760b-4912-83ed-08daf246bb90 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /shlvZKMYuhF+/bbG2r5tfckaNFP/46uupUT0U0bcTY0zf22j+5L7+PXFKmy+kHZgrCMxbpepl+YeR+h8RPvL6YnY9LFgWR/KZ0Uc6dsz0VsG4iF7ny0NUkUziIFnPifCRyu3ZQo4o+6sEhYgLi/JUOFrbYZ143BiYuZ9G6svmZv14I4Itf1QlShNZpohUQmbt9AMoU+vTyqSeg0NBv1lFOnTC+UD419rL87/c4g4BMv/bayCShcL85ZPEyz3giu1lC0lAxmp4e+r5qHTJduTYswbOePS7WI6qWrRxgU91GBEw5OahSuxQyDZZMrxNnxYzaOT4f1U4Ng9Ae5jD6+IRsyXl3IC2zKZFPeu5Pd82/h3A1T143XRIYUD9vDpnxAS9Fi75GwS72pheDBZ7X0XjONg2stDS9+ewPifShkZns5Nc5iHZbaShTH1HNxwYlJXEb9gWsW0AI+9LXwT1n1bMAASgUkkghxGP94cUsKkbPLP6uL+z4oGheDhHchUf3R0yRSr0eqQxZrldzQhE0vjJTlkyUDwgdGcZt8VmWDpaskrADjsp4I1Invuf9DOp6jki3hg9y8SFe2Jpynknu5zWLPOxF1zP2GvUovHF8eAeqnXFMW43jEgHub1Lxi9gwW3UfSpBoz4Z5orTNGRib0BYrrEgElvdOb/Gllfi5GgUErSpehW3T1Qe4BBnqKrn0CnF4eL96ttCEQvXWNQZHLGJp3FMn9CjM150iZTFuwOHM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39850400004)(396003)(136003)(366004)(346002)(376002)(451199015)(83380400001)(86362001)(31696002)(38100700002)(5660300002)(41300700001)(4744005)(15650500001)(2616005)(8676002)(478600001)(6512007)(6506007)(316002)(4326008)(66476007)(186003)(26005)(66946007)(6486002)(6916009)(2906002)(66556008)(54906003)(31686004)(8936002)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NTAvMEJvdTlGTEVIdW9WSkk0MTZScmQySk9XTFVxWXNOekJUNytYL3A3OWZk?= =?utf-8?B?L3B5NmZaeWJnV2p6aHRNZTlpZ0ZCT3ZyWHFXNHZURHFRMEV2bnB2L0RZVm0y?= =?utf-8?B?Vnh2WXNoOGE3RlRpSjloejdBeUNJTWg5Ly9YWXpybW90QmJ6QmgwaXEzUG41?= =?utf-8?B?dU42K3JvNEZxdGE0bWJIc1NPZXNaQWpGaldEaGtIZXMyVzRXQXhUdUxIOFhQ?= =?utf-8?B?TWM1dGw1SWJlTm9lVzBraDgxU2pBYmVGWE5EcXNxU0NYdzdRcFgrK0FkVFpD?= =?utf-8?B?YjBrOWMrWjJ4am5NUWhLY1BQYmVVT09ISlIwK01CKzkyazQvNVlhcElFek9j?= =?utf-8?B?MzN0amhIVjFtVC8weit0R2dVT3BpN2N3THZrOVUyb1JDYUQ4TVRwWStNL3dt?= =?utf-8?B?WlZCMHc2MUJVcTV3UDVmZ3U1dUpCSy9ZQkZrQVducGJmMy9hTGpYdFZGUGVh?= =?utf-8?B?VmFkTHlUYUR5UDhpN3JLUy9NaWZ5bUdvYmxFK1RzOExvR3ZKQXZTcm9haVdp?= =?utf-8?B?VUQ2VkJ2eWRYZGxoV255Ti9sMTZsOVpFb2IrbE5ITVZvVDBibUpRblhWN0Nq?= =?utf-8?B?LzB3aHhjMUp3TEQ4MzdiR21IL3ExcEEzcExYT09wYm5BQ2REbis1eGk4YUln?= =?utf-8?B?aXJlVTRERXYyS1lpcWVndlpvQzhUa241SXREYnRzQzRuRzI4QTRlRldRVWd1?= =?utf-8?B?TGRJWEJZeWlPbUhVdE9VaW1xVDhNL3RSNGt1ZVQvaSs4K09vWmtiK1krVk1k?= =?utf-8?B?WDk3Vldqam5zNXZuSFpOekJub21SMVJqZFR4MFVzRXhBVWdzVmp1aU9mMWMr?= =?utf-8?B?VFpYM3JISnZJRkxUeFcxem02WWt6V1FjZFEydi96UHZLRm5vcktPSHlUNEw5?= =?utf-8?B?WHI4QkwwNW4zdFRpOU1FY3dsS1h6OW1sTWtJWTZaTS84VEpzejdCY2pjeGNE?= =?utf-8?B?cTJ0bjdROVRrWk9RR1JNV0dVMlAzbmErOFNBL2hxbFZxT0NQOGxVV2c1QTFB?= =?utf-8?B?ZnFqODAxY0NXc3l4NngxTzJRaFRRcjQ4azArRGNoYlZlYzQrbzRPc3pwcFV4?= =?utf-8?B?Z0tRVnYvdm0xOEs1d245RXlxL2o1N0JFa1hxZVBjeVNpOHd6Zll2YTY3M2xE?= =?utf-8?B?bmdsRXcySlZTenBvRnFURU83Z3FUUnlVL3EzSVRGN29hdEczWjUweGIyMWRZ?= =?utf-8?B?cHZ1ZTAvTVdYOWh5L0RxUG05b2hOSFhpNzFtUEM5N0VOUmNjaC9aWko1Y2V6?= =?utf-8?B?bkdSUFhweWVqeDExRkg4OTdHQkI2UW9adWljYisxclFxNktGczF4cCtvd2tp?= =?utf-8?B?LzVBWmQzNWNycnJaZ2FiNFZ1WTltYW9LRkc5Y0kxQlJVZ1NvZkJEVzV2VDMr?= =?utf-8?B?emF5UjR5R1R1NkNyOFZORVNqNkF0WStZa2RNUHZYNFBaayszclV4Qk9yaHRh?= =?utf-8?B?Rm9TM2lPVjNxTmNWVjZ4aEV4Y0dDNVlTN1Y0Q3kwNlE3MHlVT2hhM2ErNXIv?= =?utf-8?B?azBXL0Z0aDRQVzYwNFdpV1FicUo0NzBCWDBMVU9qbEt4YzhKeDNNZlRoR1pS?= =?utf-8?B?anJNcjNMZmtvUkd5MXFwdWJaZnIyME9DK0NnbXY4ajk4RTVHWFEyZ0M3ZXAy?= =?utf-8?B?YlBlWlFuUktLT0p6REZBc0Z2dXBzcnpPZ1BsREFOZUJIZ0kzWFZ1clFrS3li?= =?utf-8?B?WldvQUtFNUVrZ0cvZmZlcFJGUnpKK1NUUXh5RzVZV2N6UVBUQThKY0FqczZm?= =?utf-8?B?bElUaElKdTBzazhIWlRWUVJ5aUpJaDBOZENTM3lFYjdTQzYvQzIySTliTXdw?= =?utf-8?B?a25wWjNmRUpkOVdVU1NWR2RoS08yU2tHcUxuMzY1K3R4c05KeFFNc0U0Ri8z?= =?utf-8?B?YnJsL05pVnNwUGhmQzFWaDlwSDJiWEU0Y0JzbnpYUW1FMkYzdWU0bDl6YndG?= =?utf-8?B?eGxiSWRYOWpmbm9RRUNlWjhiOVRQb3dST2gzR1ZHK1dYcFM1OTVxb09pNS94?= =?utf-8?B?QlRDS2VIRDlhMUp3dlhaaityTXRWaCtSU09LdmpMOEZjaWo1SVdoMW5YbTlZ?= =?utf-8?B?enpZOVU5RGVKMm1aK2VxbUM5b1M3cjFFSkZhVE5RYUxTdFk0YnNUVzZxbTFq?= =?utf-8?Q?9tz4zZK7+pANlFCfOZ52u5Bvj?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c1ddda3e-760b-4912-83ed-08daf246bb90 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2023 13:38:03.6976 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: N1ContN+gIzUX6HF0u/AJh0mz1t1CLlwQY8HNvZhlQ8GMqm4H2mL7ZEXSWCX0iTOcxXxF53/kNAXGu6MOlEZeA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6936 Various tidying changes accumulated during that effort. They're all functionally independent afaict, but there may be contextual interactions between some of them. v2 addresses review comments, which however goes as far as introducing a new patch (2). 1: paging: fold most HAP and shadow final teardown 2: paging: drop set-allocation from final-teardown 3: paging: move update_paging_modes() hook 4: paging: move and conditionalize flush_tlb() hook 5: shadow: drop zero initialization from shadow_domain_init() Jan From xen-devel-bounces@lists.xenproject.org Mon Jan 09 13:39:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 13:39:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473633.734335 (Exim 4.92) (envelope-from ) id 1pEsN4-0005zc-4Z; Mon, 09 Jan 2023 13:39:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473633.734335; Mon, 09 Jan 2023 13:39:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEsN4-0005zV-1s; Mon, 09 Jan 2023 13:39:26 +0000 Received: by outflank-mailman (input) for mailman id 473633; Mon, 09 Jan 2023 13:39:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEsN3-0005zN-HI for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 13:39:25 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2055.outbound.protection.outlook.com [40.107.21.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 06bc94a5-9023-11ed-b8d0-410ff93cb8f0; Mon, 09 Jan 2023 14:39:23 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM7PR04MB6936.eurprd04.prod.outlook.com (2603:10a6:20b:106::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Mon, 9 Jan 2023 13:39:21 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5986.018; Mon, 9 Jan 2023 13:39:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 06bc94a5-9023-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JJ4khDbk3cVq5YTxYUB4dk52fiu5dfEC2JdUpW/bgZv2WY4hGFK1tBOFRAKW6PERxDS3fGqBKaU5o3WgW9kF91NC79dhBf/lmHYJ/El8M1LQrCJgrghnQd+Oj2ZFAXVZN2/h1HQ7HfdDqrBZp8VJpfWXm2zBF7Y57ccWVL9ylBPuplVn7cSABZiTj3X7vrEIE1vjV1D/4K3Fmu6GFNN/oyyxwvzi0GbjPx2MYoVs2Ln7voabdMqnq0u4dHlgTQiSxvpx3IiuOQjZfYu8rGE5IZP51NCjeBB4OhMEgAfamRRA4waQ3TleAM+axyU+f4GO76YEnbi7jxfG1gfQesa5Sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yskimPD3tXl4FmikgAtMvcJ03/xUebDIDOeJX91rW+Q=; b=KHg1zGii2t2RB72aGsH9fmlw3vmZPlqXjVHO7pzslCdobHcGatCoTv9lqqku7VPFh7EH0C7B/P468G781vvy+zF+HzikvP/D2mdGQTXzrXbJFzE7/G1X5bgVwPxoJZGtTdUk1+5FwOt0OhUQGEng+ols/27ZQDIIyiLC74le5KUwrGV1SjiOSH3OzDFc0gxqDFFF59UHCY7GNjZC4FhKvSWx6cq7SGR/8l4rqmyHlcP8yarDoSbhidczflPHj/FVmWXtMxr6h3COwwG4qRG/iJ/WOPIbG2oQHTXSn1FTsT86LoGpKEHvIbxJaBOIl3+Zj3VRx3NtBXRMuWDLFawBgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yskimPD3tXl4FmikgAtMvcJ03/xUebDIDOeJX91rW+Q=; b=Xr6MwYYcMAQZp0cWnSjmdvTPUgEAldOpZaNZi1DcyPVEvdasfK2vGAWgDyMGlhDcT94jY9xLTtQWC3Upnw0ERYe7RrOBRBNmpzxygdr5eaQ2D93NcWLZuD8SvNb/+Dc8u2gLzzqTVq0RToVwkB7YHKmCAPJJdr5SePdVcPSLvTxw4BIR8fdel1N6zPRA2Keu6O5raCcgjOd/fUBGoVrJfuLrT1xmmhwPW/q4ICsUPRsEpMZ8xw3PCN06hNt1WCl6rhvnrVDjCMDUgF74nJA9fJoainBEWPJfZnEwK2dlCRCy5u7cagri84AngwnuRkPvtLRhhRwNo12ctg853aw8yA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <67b9378f-cf4a-f210-aa2d-85af51c51ab0@suse.com> Date: Mon, 9 Jan 2023 14:39:19 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: [PATCH v2 1/5] x86/paging: fold most HAP and shadow final teardown Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Tim Deegan References: <882f700f-9d79-67d5-7e13-e42c3c79ba11@suse.com> In-Reply-To: <882f700f-9d79-67d5-7e13-e42c3c79ba11@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0208.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a5::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM7PR04MB6936:EE_ X-MS-Office365-Filtering-Correlation-Id: a8da4fec-62f9-4d64-4f16-08daf246e9ff X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: X8wAcUZhned8iPJmlDUNadU0pDJVOBRfbCBt5jvVCZK43MGOY4X9xudFhiswrm6j9hbeWHRQ4C1EW3QILnI7s1A76WawJvgtGfVTA8w02zeYcDflNQbCOH1UtNbVMqxZUe3pWb0s112qQqKTITaZ5gqIr62dXjI+IaAUZK/0UovstgPdoBIuiJ7Bx5QBNCo0MeYVhg6i9e4o4TN4xfg9P6EDOVygnaaqVR/dyKkxA4XBwi6+WjZ7QwJU+bHHgWb62mbvJeBt3aGQg6u6qD27skqKJZYAqEzq5q55bY8hu6HuEFxmCyQjGMTgsZtkjCezDndY1Egw4JKuKPzMDLm5I2KkWjQXuoh6HHmK8F/AGehnyBz0Bsv58O4eb0YOCZIVCsfBwDm6BNlmLR2Eg1wmh3pSbN3GZPg3YsxAyr+mzFM+J3U973K73e4j/+lV3WHSOxvSjI+F1SptEMegEu9OIuFlqU5jgGYPlwut3QUQiywqx4yhnjjfnOb7jVI1yQOgMxVrftHcY21n64I7JOFQTr4bz1xmznEtS/9G4krLAkgj43x4OeOtGORzavZbbg3Q6vogR1pOTHoI4/h44mKKAGyLIaupwoYWQ6lkyo0g3FmrIsTOfPalB01L9BEKmbDArqm/0VgHfHZxv1T6C5YcJ/bCxbHuIVIbUHqxgUu142wHyN58wgSuODM5qu2ml9iUOhI9cwVXmOwotOtQItiO+KxG5ARLzCNWumqnEbraIl0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39850400004)(396003)(136003)(366004)(346002)(376002)(451199015)(83380400001)(86362001)(31696002)(38100700002)(5660300002)(41300700001)(2616005)(8676002)(478600001)(6512007)(6506007)(316002)(4326008)(66476007)(186003)(26005)(66946007)(6486002)(6916009)(2906002)(66556008)(54906003)(31686004)(8936002)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ak5lcDF2RTFQck9BV3Q2NDZNU1ZpZnRodHhCUTZjaDZNOURvQXF3MmtPdjRG?= =?utf-8?B?MEgwTVp2WUpoQWxiQnFLck12SExheEYveXIyT2ZSaGtSQ3kyb2FWY2RZRUpG?= =?utf-8?B?ZkV4RFlWT2hTM2crcUNEcnZQMXp2WHlsUGxrMkxTZ0xwV0JVakJMZnZDSlMr?= =?utf-8?B?S21tMzVKQjREZlZFdk42S0trOG9Ja2tJTDNJZE00UUJZZHowNDhxZ1FTWTg1?= =?utf-8?B?KzFkalZkdkQ2LzRNM1lGbTA5eWFnYVVYSHZHUVdHTHMzOWJxQ1VSSkU2bkRF?= =?utf-8?B?R3dtZnI0Z0hFSlJlUUplZkRMNkZHNmFqMDV1cXkyS2pUNWlJYTQ3UlEzQlR2?= =?utf-8?B?TmEya0xIQVhnRkFORzFZdTlUVm43VGQ1Y0pJVXBCUStidG9nazhOc0hwTk8x?= =?utf-8?B?eE1XWk8rQld2MU1OM08rS2g0a2xGdHFwWVl3eVE4bUJaaTJ1Yk0xcE9iczcr?= =?utf-8?B?VDdRajlEeDJxa2V5YVRPb0l5L0JCamV2N1QrcjJyUzBxQlZ0Q1hmY1Jlekc5?= =?utf-8?B?UVBxV1I2NEF6ZDRFdktKMTJ1dW0rTkNHOXZsMWYrcDRpOGdJSkxwSmdjYlJI?= =?utf-8?B?TlR6bXh4U1NxVldHWlFrVGdzTnFwYzNrZnIwOE40L2srbGVFZldJRlZMRnNj?= =?utf-8?B?SVpSRjJESXVINStUdjJsaWFTM0czKzRXK0xWZjc0Q0J3WktsQVNyUEFHNXRS?= =?utf-8?B?L1MzdkZTaDJrbU5yajVhZ1QyRW8zZVU2TDBmTmdnYnl3aXpuY1U1ck9MVEpG?= =?utf-8?B?MW8rL2Flcy9Nc0xxb2tUMTQ5UUJoOS9HRGpKenhCQzM1TDlzRWlzQnV0VjhN?= =?utf-8?B?SnZ0Z1B6QitJU0prYWlIa0dMZm5RZ1cwOFc1bEZsTzNLUzVZaDhtSm1wRlRh?= =?utf-8?B?bVdJaGN0cmg3NG11UTJQZit2anlpWTJpTkN2ektzdVlRcFJBeW1QT0VqMHhI?= =?utf-8?B?cUlEd0R0OE5VNXJIaVFPRXJMWjlRampLUlNzVWtwbnI1ZzNaVkhwZThvb2Vu?= =?utf-8?B?WVhYeEtqMHlrZC9pV29rU1J2SnVOWU1Jb2lHN3RQUnp6NWlGREtCeU8zOW1l?= =?utf-8?B?cHNtV1FkdVVrNmNDSWJRT3RNUnQ4NExoWmZWbjVVM0pXUVo5L2ZNd3Q2UTZ2?= =?utf-8?B?OXMxaERaRzk0R1gvSGJZZDFNSXk5RVpqNDF3M0trZDl2QTZsblhZQXJjeFlh?= =?utf-8?B?RXhscHJWcXVBVzNGUjdjWmRNMHhxdGUyQy9sNmUrSUZhcDJyT0lqREVMNVFh?= =?utf-8?B?d1RXZHVQODJ3VUFDK3EwNXBSeUk0V0VIdEZjazBub1dBSUpFM2JSN08wdzdp?= =?utf-8?B?NTVDUUVmZFN5N3BneUZKbFc4Uy9aMzlWcCs5T0hYT0JQTmVabE92cTNrOU5o?= =?utf-8?B?YVhLV3h4Zk1yMHVoSkdweWxnckpGMng1MUhneHhFa09rQlp1bXlNYjZFV2w2?= =?utf-8?B?Tk5JVnJmcnVSZUFVWjM4eDl4WFpJNnIvNnUyN2l6NC95U25xVUtWWkU5Y3U5?= =?utf-8?B?d0pvdm9yd1VvdDIxU3lGeGxXYmdTRUg0eHdPc2lEWnFqaStqRWduTDNDd1hE?= =?utf-8?B?VEdqUTNmZGNnZkVWcUlVZ1VUUkduSStnd085UmplVEY4Y2p6NjRHa3U5WnlJ?= =?utf-8?B?d2tTbGpSTlNPazE2MVhISEVCaEttRUpWaDlzalF5ZWQ2bUZYKzg3U0lac2tr?= =?utf-8?B?U3JaNnpzQWNTMzdQVzdMYk84MHBSRTJVbS9WbWNkRGl0SXhmdDFmRHRUV29w?= =?utf-8?B?Uy9FQU9rMDd6eEV5Z0dSNWtKZFV2WVBzOXUzN1dseG1aY2o2L0tXV1ZkOTVK?= =?utf-8?B?WEl5SVNsRE9mZEkrRFRPeUVGZXpMSXc2NTJ5MkJ3K1Y3SEljYVZBNnN2WGRJ?= =?utf-8?B?SXg2WHUzZXBkTkFYMnBCS3lEaFJ4U1ZPcmRPb3Q3Ym0rd09Xc0NCb0tnd0N2?= =?utf-8?B?MWdlbUVFSTZVMkZ3ZDJuWlpzL1M0clA0MHdXVmM0T0JjSTErVnV3cEhPS0lC?= =?utf-8?B?R0tZQ01PcTUrV1lpeHBoMGxMdHhHV3dnODM1WTJTUEFsVzViWnM5Y1Z0WCtE?= =?utf-8?B?dFFISEFCbnduSzlWV0l2N2Y0Tmdzc3BlNGRiVFFEWGhUUDJoNzNSdlpkR1Iw?= =?utf-8?Q?1CsJJKI1TfDgxsQ/fNL6vJZQP?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a8da4fec-62f9-4d64-4f16-08daf246e9ff X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2023 13:39:21.5677 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Uyl3MhlNygBrjHdR+lDpUwNRec7MV4mrWTXFOA6NSVVpznR13HuBvtfkBhV67UpiqcvBCM5WTvZkk3foDuueAA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6936 HAP does a few things beyond what's common, which are left there at least for now. Common operations, however, are moved to paging_final_teardown(), allowing shadow_final_teardown() to go away. While moving (and hence generalizing) the respective SHADOW_PRINTK() drop the logging of total_pages from the 2nd instance - the value is necessarily zero after {hap,shadow}_set_allocation() - and shorten the messages, in part accounting for PAGING_PRINTK() logging __func__ already. Signed-off-by: Jan Beulich --- The remaining parts of hap_final_teardown() could be moved as well, at the price of a CONFIG_HVM conditional. I wasn't sure whether that was deemed reasonable. --- v2: Shorten PAGING_PRINTK() messages. Adjust comments while being moved. --- a/xen/arch/x86/include/asm/shadow.h +++ b/xen/arch/x86/include/asm/shadow.h @@ -78,9 +78,6 @@ int shadow_domctl(struct domain *d, void shadow_vcpu_teardown(struct vcpu *v); void shadow_teardown(struct domain *d, bool *preempted); -/* Call once all of the references to the domain have gone away */ -void shadow_final_teardown(struct domain *d); - void sh_remove_shadows(struct domain *d, mfn_t gmfn, int fast, int all); /* Adjust shadows ready for a guest page to change its type. */ --- a/xen/arch/x86/mm/hap/hap.c +++ b/xen/arch/x86/mm/hap/hap.c @@ -268,8 +268,8 @@ static void hap_free(struct domain *d, m /* * For dying domains, actually free the memory here. This way less work is - * left to hap_final_teardown(), which cannot easily have preemption checks - * added. + * left to paging_final_teardown(), which cannot easily have preemption + * checks added. */ if ( unlikely(d->is_dying) ) { @@ -552,18 +552,6 @@ void hap_final_teardown(struct domain *d for (i = 0; i < MAX_NESTEDP2M; i++) { p2m_teardown(d->arch.nested_p2m[i], true, NULL); } - - if ( d->arch.paging.total_pages != 0 ) - hap_teardown(d, NULL); - - p2m_teardown(p2m_get_hostp2m(d), true, NULL); - /* Free any memory that the p2m teardown released */ - paging_lock(d); - hap_set_allocation(d, 0, NULL); - ASSERT(d->arch.paging.p2m_pages == 0); - ASSERT(d->arch.paging.free_pages == 0); - ASSERT(d->arch.paging.total_pages == 0); - paging_unlock(d); } void hap_vcpu_teardown(struct vcpu *v) --- a/xen/arch/x86/mm/paging.c +++ b/xen/arch/x86/mm/paging.c @@ -842,10 +842,45 @@ int paging_teardown(struct domain *d) /* Call once all of the references to the domain have gone away */ void paging_final_teardown(struct domain *d) { - if ( hap_enabled(d) ) + bool hap = hap_enabled(d); + + PAGING_PRINTK("%pd start: total = %u, free = %u, p2m = %u\n", + d, d->arch.paging.total_pages, + d->arch.paging.free_pages, d->arch.paging.p2m_pages); + + if ( hap ) hap_final_teardown(d); + + /* + * Remove remaining paging memory. This can be nonzero on certain error + * paths. + */ + if ( d->arch.paging.total_pages ) + { + if ( hap ) + hap_teardown(d, NULL); + else + shadow_teardown(d, NULL); + } + + /* It is now safe to pull down the p2m map. */ + p2m_teardown(p2m_get_hostp2m(d), true, NULL); + + /* Free any paging memory that the p2m teardown released. */ + paging_lock(d); + + if ( hap ) + hap_set_allocation(d, 0, NULL); else - shadow_final_teardown(d); + shadow_set_allocation(d, 0, NULL); + + PAGING_PRINTK("%pd done: free = %u, p2m = %u\n", + d, d->arch.paging.free_pages, d->arch.paging.p2m_pages); + ASSERT(!d->arch.paging.p2m_pages); + ASSERT(!d->arch.paging.free_pages); + ASSERT(!d->arch.paging.total_pages); + + paging_unlock(d); p2m_final_teardown(d); } --- a/xen/arch/x86/mm/shadow/common.c +++ b/xen/arch/x86/mm/shadow/common.c @@ -1194,7 +1194,7 @@ void shadow_free(struct domain *d, mfn_t /* * For dying domains, actually free the memory here. This way less - * work is left to shadow_final_teardown(), which cannot easily have + * work is left to paging_final_teardown(), which cannot easily have * preemption checks added. */ if ( unlikely(dying) ) @@ -2898,35 +2898,6 @@ out: } } -void shadow_final_teardown(struct domain *d) -/* Called by arch_domain_destroy(), when it's safe to pull down the p2m map. */ -{ - SHADOW_PRINTK("dom %u final teardown starts." - " Shadow pages total = %u, free = %u, p2m=%u\n", - d->domain_id, d->arch.paging.total_pages, - d->arch.paging.free_pages, d->arch.paging.p2m_pages); - - /* Double-check that the domain didn't have any shadow memory. - * It is possible for a domain that never got domain_kill()ed - * to get here with its shadow allocation intact. */ - if ( d->arch.paging.total_pages != 0 ) - shadow_teardown(d, NULL); - - /* It is now safe to pull down the p2m map. */ - p2m_teardown(p2m_get_hostp2m(d), true, NULL); - /* Free any shadow memory that the p2m teardown released */ - paging_lock(d); - shadow_set_allocation(d, 0, NULL); - SHADOW_PRINTK("dom %u final teardown done." - " Shadow pages total = %u, free = %u, p2m=%u\n", - d->domain_id, d->arch.paging.total_pages, - d->arch.paging.free_pages, d->arch.paging.p2m_pages); - ASSERT(d->arch.paging.p2m_pages == 0); - ASSERT(d->arch.paging.free_pages == 0); - ASSERT(d->arch.paging.total_pages == 0); - paging_unlock(d); -} - static int shadow_one_bit_enable(struct domain *d, u32 mode) /* Turn on a single shadow mode feature */ { From xen-devel-bounces@lists.xenproject.org Mon Jan 09 13:40:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 13:40:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473637.734346 (Exim 4.92) (envelope-from ) id 1pEsNg-0006yt-Ew; Mon, 09 Jan 2023 13:40:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473637.734346; Mon, 09 Jan 2023 13:40:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEsNg-0006y3-Aj; Mon, 09 Jan 2023 13:40:04 +0000 Received: by outflank-mailman (input) for mailman id 473637; Mon, 09 Jan 2023 13:40:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEsNe-0006U7-QZ for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 13:40:02 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2072.outbound.protection.outlook.com [40.107.22.72]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1d298941-9023-11ed-b8d0-410ff93cb8f0; Mon, 09 Jan 2023 14:40:00 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8550.eurprd04.prod.outlook.com (2603:10a6:10:2d5::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Mon, 9 Jan 2023 13:39:58 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5986.018; Mon, 9 Jan 2023 13:39:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1d298941-9023-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NIhcv3sj7hHMzNyVFwdLe1PWuBigcoIRGMpDC8tsMA/bODvEVSAaL27RqYaMEImUl13K4mpaxLlGbj/rmL52XmaVssCUuUWA/TTZkZb3yFTshLar+yv2ORSjothtefUNEebr4RVkJ5rmju1xgDE0zZUMWGUZaxvGPBttKwp+jkWM8LOPQ1O6cfmXRXYGdNoJwdE/wu/42364wwAj+d3emm0VeeBuxa5uGbxZQqe41ZQijNRkBuev5PqeYiegxtdZVo7vMsFOgSMt6rYyoOO8JRPXiO3x/N8+atwLovccpyQuBmMb2pwxfPlKIh8hJVCFoF9ps8Q/lCSaaY3oUXXA5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qCeUlm4/DsmO3G3gcntNt7cjbvdyT3iGeg4tOoUssFE=; b=Mb28XGvCoXUrcF1+Lw16yDhoZmXYAcfjSlEQK9Q9E9/7QkQ6VL84YzTOuRTmnmxNGgzYx58HTUZcdMdVGw3LK397B4UGXJ0SxAQ1lKxNhYSw1VFxwQEtOVG9sIfQfVKktS5UffBB3HKpuOtY61vkRuRxHn5KuZcMEK63+vqkt/8C2H7rbFNrYQrsakeq/N9EUWjPe2eeHj9XTpOU4znF7W/Ae+PALX26xWXRFs2HyyOFFxWsqfw05bffkg+e+MIOnZFnw7/zRmeJwYFtC17tF4EKzUU1PUgzaH/bdrDGQTgH6d1JILea/upUPDSqUIVsmNQNCj2mwqgS7adLaOzaIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qCeUlm4/DsmO3G3gcntNt7cjbvdyT3iGeg4tOoUssFE=; b=RQLvGu4kdQVpYmpAfMhbQ8clm6tM9gVB2KHZAo+K+VXk+RA0TY1xDLpoIroxA9l7dQY2MgLklH+CL+C4oHerutN92UD+eKaIgYykQ8DXr+tJDc+zaP7gmYUWvkJaGjkffTgPHUtxpDT7V1P8kmKsK75b1Z1jCgNu5Htfqy/Ul35SBCVH/ZLQ52DSwnAzlJ4FkdZamytXuVpSBEkEwJiwzDR8xd/MZFTwwjeBEhe6jZ4556QGBF7fkcVXmvBp5Uu1Tif/LA8xpK5xpoQLTXPsSV5JaL4guXRkoZiOqfOu0FCLi+yOidWbnHRk3+0WniymMsnNMJaPM9j/pLyvn6r1Yg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <99270ce9-39d8-1f3e-f922-afc2c0289205@suse.com> Date: Mon, 9 Jan 2023 14:39:52 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: [PATCH v2 2/5] x86/paging: drop set-allocation from final-teardown Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Tim Deegan References: <882f700f-9d79-67d5-7e13-e42c3c79ba11@suse.com> In-Reply-To: <882f700f-9d79-67d5-7e13-e42c3c79ba11@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0198.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a5::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8550:EE_ X-MS-Office365-Filtering-Correlation-Id: f2aad4a9-77f8-42c4-650d-08daf246fd8b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: m9tBaVBaKZbhgx18EP3tSG9OpEvRjlycY+WpeubIJEdOPBtQPibYDHuzJ1Y2C+gatL/vlWPQde7TAS0PWRY4bD4JrXpMslTtAttWfh384sPLqnvx5Xya3z6bOA3+8Ll2S0RIpRFAyDM8jygW2I4PiEbuL/m6CaMZPfQ5VCeSOOSGpVzgK8joMdowooy9QY1XqhDu0+WOGhoCCjt4KQApghc7SPLraXgUvIGNgzE9UiEENC94tEP0q1m+fMDG2fkct/Lu+38tkIZN5Wn9mZw5opMSCfeIlWSXsxJIF/9JouiBlctiSj6PrJofM1joULwUBkrBPaKobxIbGgzGw85h/ljSXszZHlHDuYGTpOUquNhLQ28Ji6RpMB3usbiEVjLJHOoDkJ+naEavCjZAJLzJRC8J4Le10VfgA1B3jYQHFJX8DBt2eZJERTrpWYf8Q/6oyImPHPTXlIRTxtXtJOsiaBs+/pT9KVLsvB8gAiVVSwzT/N8KT9Isn8Bj+F1ugyo3+SCtyoetSfGu7DoDXfeALfIzE7uAvlMJikajcP/2uoXlYIdTSP/rn/wslHhN1MvnqxkF+okSH40aYrumVy/zfk51IPlfoCFFx5WzwevMPpo3B2APjtP8YYBm51/BmR9K36uwvkugwyQ6qYNSyzmG8reH2c3OIoj7qug89HIFDyjJ9BGbisZLSRc/P5eS82gUplTfRDIPt7X1j79TGU27p/h1eSKbbMLAPk1bEbbY7/o= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(136003)(39860400002)(366004)(396003)(346002)(451199015)(4326008)(316002)(66476007)(66946007)(8676002)(6916009)(66556008)(54906003)(2906002)(5660300002)(8936002)(41300700001)(86362001)(478600001)(83380400001)(31696002)(6486002)(6666004)(6506007)(186003)(6512007)(38100700002)(26005)(2616005)(31686004)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WXJPTVRlbVA3OVk3VkV0YWdscTJvZVRSWndHUmdHVDQrOEoxWEdrMmRoZ2hZ?= =?utf-8?B?MlpMd3VGWTlhV291MXUzcDNSY2lpNjhFN0J0S1V1RzAwcklOV3hUSktzaFlz?= =?utf-8?B?L0E4VlpOZkd0ZXluZ0RJNWZvQ0ZzVTh4WVh0V1hsVHk0Y3Mwa2ZlbWxwYXRJ?= =?utf-8?B?NUh4c1NVYnVMMCtmemJ0SjFyVG1BTkZEVTRjb0plblpUMndCK0hQbkp2Mm5w?= =?utf-8?B?M00xM0lBTlMrbkc4dVR4elROTWlsMVNUN1FoeFJmdUxmZjlHTUFUN040a2ts?= =?utf-8?B?UytNNlVzTzJibEtETUpyRmxzSlpMR1ZIdTg4UTc4SkF6b2ZoaHVyN0d2SkVO?= =?utf-8?B?bW9WUWNBU1YrWXFRbkZsKy9IeTloT0dDYk1GS2MzbEU1RUs1bjhiRnJQZitZ?= =?utf-8?B?QnIxSWh1MTF2cFIyd1dkSEZXVlEyLzNvUDh1aFJKNUloTW40UXhOajhvbzlh?= =?utf-8?B?WW82QnlrS0JvQzllMnk0dTQzMEdyQTgrMms2QUdKTXpjclVBWFhyS043YzVG?= =?utf-8?B?TzU3aWExalZ4TGtwalh1azhONUlJK05oVTFEbGhMc1llMkFieTVqWXkwdkJG?= =?utf-8?B?djZ1SlYzTkNsNmczRERKczd4MnR6MkZHUW9SN1FmWkxLRmk1bzBoVlZLdGRZ?= =?utf-8?B?TEJyY2ZpMWNaRVk3ZDNOTytWa0tRaHd4TXNuYVUvTkoyMlJrMWFoaC9ZNnFX?= =?utf-8?B?UGJHb1dvdFhVWUxZRTRCcCtoZXV5NG0wdnYrVUJSY2FET2tPdGZxZEh3TDIv?= =?utf-8?B?d2M0VWY0cjFJZE1FRzU2WGF1UUpUc2FXaEIyRGxZNFYxNG5IZjRmek43YXY2?= =?utf-8?B?RDFaendrQ2dHaXMzS0FHb2s5ZDhBbG1IWjNwNlRpbzZoUjJtay9ITmtVWjJh?= =?utf-8?B?RkFRdzQ5SmVveU9GOEdwQmJ1UEpJTnlOcGF3NkhKREN6SEJrSGdnbWd0NDlI?= =?utf-8?B?S3BqQzRseHE0bjFUYUUxTEdEdVFKbXEwMGMvU2pmRXZNN2VRUjczQ3FCc1NN?= =?utf-8?B?Z3NjSEtDNmtXMWZZYmJnU0tDc0VkeFBTQ3RwSVh3eWdaaE00MDJoL05nNjE5?= =?utf-8?B?b3QrZ3UvM0JVcGtER1BDK2h5NWNLTWwraWd4cFZwNXU4WXhyYWoxYzhMOEFM?= =?utf-8?B?aFEwclloQ0VqNUkrUHE4U240WTY5OExyZnhKTk5YUDdmaXBmV1IvZUZnZHJn?= =?utf-8?B?SEZ6a3Y1dHFXSFI1UlVqRW9va2dlVDhjRG83czVXQlArRlpZYmtXMUN5bCt3?= =?utf-8?B?bm1XeG9CZ2tJZENoUWl6Z2c0UDg3RFFzY3RIcjZKL2pMamhPdUJ1WmZ3ZmVI?= =?utf-8?B?SHBFaWIrcnhvZGg5Q25GUVJSVWg3QVRxdFVEcG85RmoydmFQODl2UkVGVUN4?= =?utf-8?B?YVg4ck5EOS8yZ3hIRWZmTU5na2NDRzNHT256MXhRNEkwKzFFNUtJV3VRUzJ0?= =?utf-8?B?Vjl4THM1UVRuOEVGU3A0bFkxQzdwVDhXbEF1RHB3V3l3WHhVd3dBN0dwb1V6?= =?utf-8?B?QmZnS01jSWpiQnJIRkxuaVlLckJ5S3FHZC82TiswYXAvUjBFUkFWVHpUdWZt?= =?utf-8?B?ZE5BRUFvc2NvenlPdEtDY3lZRW04VmNHU3R4eVppVkU2U3FpakhRTi94akRo?= =?utf-8?B?dUh4NHgrRW5Qc2VCbExpMFA0bFdkVGRMbnY3VTVoUGZyZ3kxc0FJWFpPUHVi?= =?utf-8?B?ZEpVbzRvSWVVUjFoSUNuS28rcHoyOHA0aHYza20rRGpOdFZhenozK2hjazlC?= =?utf-8?B?cll6ZmxsM0hYR3BQOXlSZlRqVFptMWJtV2VSWk1FZnhSMXpEU1VTTUp6Yno3?= =?utf-8?B?bzB2NG9LWTlqWDJmdGF3Nms5MU5ZaTA5SWtYMG9ZOFFqaTVyWXVlM0Rsd1RL?= =?utf-8?B?dDYwWFNHTEl3eHpyK2UzS1J5Q012UHl1bVJjVFFTV3Zjckk2M2dmZ3I0aUNZ?= =?utf-8?B?ZElEZDZQbDBUNUdaNFUxVU0xaCtzRnIvODNFMFFqSU9LTzRnTzNmT3p2VTJR?= =?utf-8?B?VlpjdzByNHFNMk03Z1J3RllWUGRndGN6bkJrQTJtbDRwN0hGeUVFeGphQkJE?= =?utf-8?B?a2FBMENSL01oZURqV2JaeXh0T25NeHA3c0FYOG1qTXRZR2pYM3J0ZW5rR0l4?= =?utf-8?Q?yZONNtxRgBOSOyIQltmDDN5NW?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f2aad4a9-77f8-42c4-650d-08daf246fd8b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2023 13:39:58.3309 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ko1/NrRBmWHa3rQMRF+oY26kiEWQWNFhraKKk9YOkZnubMeS/nEGTkBpjxHs/sqO8BSa0lkBY7KJk5iTyy0dNA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8550 The fixes for XSA-410 have arranged for P2M pages being freed by P2M code to be properly freed directly, rather than being put back on the paging pool list. Therefore whatever p2m_teardown() may return will no longer need taking care of here. Drop the code, leaving the assertions in place and adding "total" back to the PAGING_PRINTK() message. With merely the (optional) log message and the assertions left, there's really no point anymore to hold the paging lock there, so drop that too. Requested-by: Andrew Cooper Signed-off-by: Jan Beulich --- The remaining parts of hap_final_teardown() could be moved as well, at the price of a CONFIG_HVM conditional. I wasn't sure whether that was deemed reasonable. --- v2: New. --- a/xen/arch/x86/mm/paging.c +++ b/xen/arch/x86/mm/paging.c @@ -866,22 +866,13 @@ void paging_final_teardown(struct domain /* It is now safe to pull down the p2m map. */ p2m_teardown(p2m_get_hostp2m(d), true, NULL); - /* Free any paging memory that the p2m teardown released. */ - paging_lock(d); - - if ( hap ) - hap_set_allocation(d, 0, NULL); - else - shadow_set_allocation(d, 0, NULL); - - PAGING_PRINTK("%pd done: free = %u, p2m = %u\n", - d, d->arch.paging.free_pages, d->arch.paging.p2m_pages); + PAGING_PRINTK("%pd done: total = %u, free = %u, p2m = %u\n", + d, d->arch.paging.total_pages, + d->arch.paging.free_pages, d->arch.paging.p2m_pages); ASSERT(!d->arch.paging.p2m_pages); ASSERT(!d->arch.paging.free_pages); ASSERT(!d->arch.paging.total_pages); - paging_unlock(d); - p2m_final_teardown(d); } From xen-devel-bounces@lists.xenproject.org Mon Jan 09 13:40:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 13:40:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473645.734356 (Exim 4.92) (envelope-from ) id 1pEsOW-0007rv-OO; Mon, 09 Jan 2023 13:40:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473645.734356; Mon, 09 Jan 2023 13:40:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEsOW-0007ro-Lc; Mon, 09 Jan 2023 13:40:56 +0000 Received: by outflank-mailman (input) for mailman id 473645; Mon, 09 Jan 2023 13:40:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEsOV-0007rg-5U for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 13:40:55 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2065.outbound.protection.outlook.com [40.107.22.65]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3c310292-9023-11ed-b8d0-410ff93cb8f0; Mon, 09 Jan 2023 14:40:52 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8550.eurprd04.prod.outlook.com (2603:10a6:10:2d5::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Mon, 9 Jan 2023 13:40:51 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5986.018; Mon, 9 Jan 2023 13:40:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3c310292-9023-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QQpHT/Nv3OY2ry+Y8Ale1DrdmBcnB0vBQjPagKUY7FTV9Cru5ZtKL2Zg2Rz7tNKu1qvQA+iaYDfNzxwaUL6FXlD2g7/6qysoNA7SfID0PgQu+lO936x8d9F8H7iucmN/IgxWQndhTd/2CxBF/GFaK/ZmKHmqHH2vWudnOj/lxX/dTHK9TxlGRqvZku9AUtk8xpiHTMoYinnbXrHPAbtkR9J6PA6gJ5U4cPU2RYhcGv66Zmw4I+vkEt8tZJ1t9fWcpXfL7/lgKVUZB/Y+AoB4Fo9cKaLIuwK4X0nwj18A+oizjVWbyDrYBV6ya+mxGxpl9p1PwpK6xhCdwcSuuOcHCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vUyDk05ke+Lt65CNEbe0BSHjvjrpHd5u/KRVoCvKhts=; b=lGP7OYN1LiCKVZ9k0E2X2/mb+8MceoRYqBkqiSeXrzHy3wbwoLV9E9kM+pBNZUEAneOojnq+FRJQCoA2BWjS0P3cSY94RfzXeZBS/uriivXaHg5rblEHqDArzITfNYsHHW1ntmwcjc1cLNWiQ9KGcj0rWDgidgbt7FBgUPSpAusCXLrOtOQiOI37IpMlscqJ0VMK5XXxWiYQeTncNFTsaEeqm/rKyZ/XA3sMB6OUkgzEXRWXKIulth38O1aeK5MqFdWSmPWoB+KvLRjdZogFNvqnFeIk/IgddG2+2/WePbIoyKqYuASBe7/OM/1WBUCDI/A3t7QPwChCuCIpktfKJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vUyDk05ke+Lt65CNEbe0BSHjvjrpHd5u/KRVoCvKhts=; b=Tm5yIrxHS+9jHq2W4Jw1DNVTJkJGuTJJ6jzLXMQAiJEkCFNkCG8SXYXfI87/uvgBMjRj9CCZ8WPzpA5ox4jVM/Qm3po/BJ48y7Y2pQelTwimAl9FRuuXvCTLVQP1w/15ZMkX0bWIkfgY36EJU3/rGW4zTVOGhWgzrW6KztdsO4o21mIf1Oe7Ett1TgI53tgsOVtRbteVkhXZ+v8msOns8wInO8U8blQ/rGk+04FPR7wB0U7WCv3yHVCQK2CMdTBglD+OL3wX8d5TT3vfy7KMr0xO5PYv2uPu2duJ4oWoeyI7a7LhEi7r/ZoFO03+/f2VAeOn5v6sb+m16XSq1lKsYg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <032e81c2-ac86-638a-1611-43bc3bea6d0e@suse.com> Date: Mon, 9 Jan 2023 14:40:50 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: [PATCH v2 3/5] x86/paging: move update_paging_modes() hook Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Tim Deegan References: <882f700f-9d79-67d5-7e13-e42c3c79ba11@suse.com> In-Reply-To: <882f700f-9d79-67d5-7e13-e42c3c79ba11@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0085.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::22) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8550:EE_ X-MS-Office365-Filtering-Correlation-Id: f09e2cb6-95b1-4992-45f2-08daf2471faf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sdWw33qHo136i0GX5j/Fo0xqKIOXT/zIlUFUuz864Q2aKElOBFPZBz4NHScC2F60po4BLRovpDpjylu8UZbbZB6r7jCRQjU9xpwc1NFDJMFiYeoEsdVFZuU3n4vFwuQ2HuOP7kpNzHWWqUJFx793qAiUYb2O4ESV3ludPTv0M0L0zZBd7CYThDnaCs9qurWt7WgurTN9GMYFIQjL3ywqRdXAuQ2cDWLwiWtJd9Mzsor3rMYj7ynv33S0LJ+d18Z/bCuNTq0a/sNbclpUGWobvRP/SDcn9QunVs1F3mb9uB6lJjv31O2YdLwBdRhAhfkou05SRiglWdGZGW901blgctH0Q0QYCnzGY/A7sYjxeNy6gcVbPfvJo3R0ZVBJMC6lRIspHNsHB8mTdO1z1lFTRZxnAaW0R5PlGd4cB53F1zE9NX++JrcKwShi1kvAbBIlutpknYyI4Rzk7XnurB+q0PLGdvui9wt5HQ/beDZdyjmXDTbBE/YqDm+rtoNqU1qeVZ5x8sMtT2lPKZ2TEG9gGYYIe1EJoqwyZNCob+F6xkBS0cPReZ7FyiHl6Kk8dN4Mb7x2lkpXq4dn7xbUfvoAELepild6pKcCDFwgyab0RyTmkeaA7mWBODb5He16YUBavB2zQ3BiUSI+uvwWUv7itUl/lruUosQUgCs19AnLkPUN2u4JuA2XxydbpIfnQJImb6/FpS4wjrTGVAI8B6oWuil4xMVjrjp0aJOnOzt2Awc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(136003)(39860400002)(366004)(396003)(346002)(451199015)(4326008)(316002)(66476007)(66946007)(8676002)(6916009)(66556008)(54906003)(15650500001)(2906002)(5660300002)(8936002)(41300700001)(86362001)(478600001)(83380400001)(31696002)(6486002)(6506007)(186003)(6512007)(38100700002)(26005)(2616005)(31686004)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RjZHZ0pHSllWQVRhbkY4dWpLY3lSRmRXZEE2dUE3OVdXZkJzRG94eFprZ1VK?= =?utf-8?B?aXpLbGJ2MDhqTHdoVlorWHJoWjlCOGdybWV1QWJQMkcvbVhmT0NuOU85WkY5?= =?utf-8?B?OG0xd29FVERrVXFwY0dMSTBZbnAvakFFM1dyUmRUa2c1cnd1VEZvdm5vQXdI?= =?utf-8?B?ZHVuOUZWeThVV3EzWVk3bG00QUZnaGZYbmw1d1F0eTVKSVV5U2tIYk1ZNm5m?= =?utf-8?B?eWhIUUdVNHZqRVN1WU95YUJUbmQ2UEc3RHBjMGZFVXU0UmJBSGxUU0ZoOUwz?= =?utf-8?B?am45Zi9LY1lyY0pkUEErYWZ6TTNjaVYvcFZxQmNPRHRXb2N5TXdHdnlwTEdw?= =?utf-8?B?OHZKZWpzODhnMzVzbVFMK0F0QjU1TWZJVmc2dTRjNERWT2hHSnh2cm9TWnZy?= =?utf-8?B?MUk5NUE2NFZGRjRKSkthTHFuQ1JPb3h1MndYL3dVL1JabU1qM0tsWk9wL1ZF?= =?utf-8?B?L0RQTlJEaFRESmZRUitiNWI1QlBnRk9xQlhZeFFCRXE2SVZQc3RjZUp5eXJH?= =?utf-8?B?L1ZzWjNNbzU4V09relFjM2E0WDBnMG53MHJLa3JEWlFDQ3B3Z0pzUGpTb29n?= =?utf-8?B?UmhrcS9VVUtKWTA2SjFFdS96MStlaGdYbGxhMjdaSFJWcUxxV0J5akk0WmpW?= =?utf-8?B?cUQwRVlKUXdPM2lTa1I5NVh5MTg5WHFSRFppRVRZMUNnaUcweHNrSTZNekQy?= =?utf-8?B?anJnZXd1bEU5bzlxU21wcUgwVm9JN3ErVm85RC9LY3pNZktZVGhSS2RUS21Y?= =?utf-8?B?M0cxK0l3eXlGQUlHVEQvaXpYVkZnNDVXTGNtam41a3I5R2VjSXJYR0RwSmZH?= =?utf-8?B?eHV4ZHVxQ1JOVEE4ZDR0QTFEQnowR05qQm5yWVVLUTQ2bFZ1Z2dYZGdNT2NN?= =?utf-8?B?eWVaWVZOdWZZTDhuekZsQ012V3pSck50VGE3THRCZHhXd2hpYzBLUDUvWmZZ?= =?utf-8?B?Z2Z4eTI5akF2cytHR1pUaU0wdThyTHBLd1VjNG9sSzhETEtUWmJvVFFpNXdP?= =?utf-8?B?b1JiQjV4QVBRaC8xbnFxVTgrVTRqaTdNOGVDREd4dmMyNVJWL0VQVkpBWG1B?= =?utf-8?B?S0FCS0g0TVNCd2RNWHNaMDViUXVHWXBsQVNIZ051L1pmcGJSVmMycm9SRjVM?= =?utf-8?B?azdpaUZHVm9TK0lZOFB0anROWkh0NmVmMjN0amc4cDJtVEF1UDRLUHBHVXE2?= =?utf-8?B?Y2J5bmVSNEpHR1VrMC92TGUyQ0MvSmRwWDc4RVBLaXB5MU5yVWhGMVp6YW44?= =?utf-8?B?amxLWTlnR3FZTGpFTnZicHlPak1uMnNVSmgwQktIT3dOOTlkd3gzbmRGUUU0?= =?utf-8?B?SVJrbWV4VW5md1dUZG1zTStHenRqWDlObUdlUmVkTDVmZGtkb2dvRy90c01V?= =?utf-8?B?R2Jyd2VUUklBUzJTeGthbnBXTXFHSjEwYkd1clRoa3lrRGNHQTZCbkxsMjVC?= =?utf-8?B?cjhHYVhvUFRDLzQ2eWw1cVhpSXZLV3VuTktYVXdZMnNXYmRLbkN2b0MxZ01M?= =?utf-8?B?ZXA2RTJTY2k4YXBvS3FFZjYxUEN5SzVTZ3JPOUhoZGx0anZibXlBb0M2ZWIr?= =?utf-8?B?c2JXSHczT01XQ2tYOGxvK04wVFZobVZGcVNxdzlWeC9pU1NxTm5TTlVXY3k2?= =?utf-8?B?ZTJSdFJzNUZENXV2SGFsb3hya3VqOERwODBqWnFHd2wzMVZEUlJ6Q1NuUmNE?= =?utf-8?B?VlNQOTdkNUdza3Y0MUNYZlY4OVJVSGh2SEpvTnI2RmdkazBFOStJS3JsVCtO?= =?utf-8?B?M2VlbjJlYkkrdUhRcm5KRjBJNElIRzFPaWlDc0paTFd6bEhGWHpHUHp3blNE?= =?utf-8?B?bGJ5UG4vcS8rSHcweG40eWFaY2RJQVdqZzV5c2ZVdVByMlFBeWUvSWsveHN6?= =?utf-8?B?SG1aSlRmR3pLbjlVV1IxU1lBU0lLdkV2dHptSzYvSDlvNElsTUt2NXFOZkFF?= =?utf-8?B?VXpWM3htMHlzRkh1Q3JWZGFveWNkUW1vbnVWVGhneERIczNZVFh5dStCZHdB?= =?utf-8?B?TG5CcmRxZTNicmlST2dQOUZhOHNnbG91WnR5eENCSlFUaU1PWElBUE5XNU45?= =?utf-8?B?Mi9yTE5LenBZYzFNUDYrMnBYcTh5MGlvMmJRY3VpTEpnTGw4c1hGVm0zRW53?= =?utf-8?Q?XqDRkBkAkOyFyBat4RTGQVx4i?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f09e2cb6-95b1-4992-45f2-08daf2471faf X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2023 13:40:51.5307 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JTgmkumJEz7iXBQOIbUDj5bHglMfbJ2w36hZK77H9b5qicC8w9rKmsMNeG6CLc/xecGtgpRE7g4YDHgyRmAquA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8550 The hook isn't mode dependent, hence it's misplaced in struct paging_mode. (Or alternatively I see no reason why the alloc_page() and free_page() hooks don't also live there.) Move it to struct paging_domain. Signed-off-by: Jan Beulich --- v2: Undo rename (plural -> singular). Add a comment in shadow/none.c. --- a/xen/arch/x86/include/asm/domain.h +++ b/xen/arch/x86/include/asm/domain.h @@ -235,6 +235,8 @@ struct paging_domain { * (used by p2m and log-dirty code for their tries) */ struct page_info * (*alloc_page)(struct domain *d); void (*free_page)(struct domain *d, struct page_info *pg); + + void (*update_paging_modes)(struct vcpu *v); }; struct paging_vcpu { --- a/xen/arch/x86/include/asm/paging.h +++ b/xen/arch/x86/include/asm/paging.h @@ -140,7 +140,6 @@ struct paging_mode { #endif void (*update_cr3 )(struct vcpu *v, int do_locking, bool noflush); - void (*update_paging_modes )(struct vcpu *v); bool (*flush_tlb )(const unsigned long *vcpu_bitmap); unsigned int guest_levels; @@ -316,7 +315,7 @@ static inline void paging_update_cr3(str * has changed, and when bringing up a VCPU for the first time. */ static inline void paging_update_paging_modes(struct vcpu *v) { - paging_get_hostmode(v)->update_paging_modes(v); + v->domain->arch.paging.update_paging_modes(v); } #ifdef CONFIG_PV --- a/xen/arch/x86/mm/hap/hap.c +++ b/xen/arch/x86/mm/hap/hap.c @@ -443,6 +443,9 @@ static void hap_destroy_monitor_table(st /************************************************/ /* HAP DOMAIN LEVEL FUNCTIONS */ /************************************************/ + +static void cf_check hap_update_paging_modes(struct vcpu *v); + void hap_domain_init(struct domain *d) { static const struct log_dirty_ops hap_ops = { @@ -453,6 +456,8 @@ void hap_domain_init(struct domain *d) /* Use HAP logdirty mechanism. */ paging_log_dirty_init(d, &hap_ops); + + d->arch.paging.update_paging_modes = hap_update_paging_modes; } /* return 0 for success, -errno for failure */ @@ -842,7 +847,6 @@ static const struct paging_mode hap_pagi .gva_to_gfn = hap_gva_to_gfn_real_mode, .p2m_ga_to_gfn = hap_p2m_ga_to_gfn_real_mode, .update_cr3 = hap_update_cr3, - .update_paging_modes = hap_update_paging_modes, .flush_tlb = flush_tlb, .guest_levels = 1 }; @@ -853,7 +857,6 @@ static const struct paging_mode hap_pagi .gva_to_gfn = hap_gva_to_gfn_2_levels, .p2m_ga_to_gfn = hap_p2m_ga_to_gfn_2_levels, .update_cr3 = hap_update_cr3, - .update_paging_modes = hap_update_paging_modes, .flush_tlb = flush_tlb, .guest_levels = 2 }; @@ -864,7 +867,6 @@ static const struct paging_mode hap_pagi .gva_to_gfn = hap_gva_to_gfn_3_levels, .p2m_ga_to_gfn = hap_p2m_ga_to_gfn_3_levels, .update_cr3 = hap_update_cr3, - .update_paging_modes = hap_update_paging_modes, .flush_tlb = flush_tlb, .guest_levels = 3 }; @@ -875,7 +877,6 @@ static const struct paging_mode hap_pagi .gva_to_gfn = hap_gva_to_gfn_4_levels, .p2m_ga_to_gfn = hap_p2m_ga_to_gfn_4_levels, .update_cr3 = hap_update_cr3, - .update_paging_modes = hap_update_paging_modes, .flush_tlb = flush_tlb, .guest_levels = 4 }; --- a/xen/arch/x86/mm/shadow/common.c +++ b/xen/arch/x86/mm/shadow/common.c @@ -45,6 +45,8 @@ static int cf_check sh_enable_log_dirty( static int cf_check sh_disable_log_dirty(struct domain *); static void cf_check sh_clean_dirty_bitmap(struct domain *); +static void cf_check shadow_update_paging_modes(struct vcpu *); + /* Set up the shadow-specific parts of a domain struct at start of day. * Called for every domain from arch_domain_create() */ int shadow_domain_init(struct domain *d) @@ -60,6 +62,8 @@ int shadow_domain_init(struct domain *d) /* Use shadow pagetables for log-dirty support */ paging_log_dirty_init(d, &sh_ops); + d->arch.paging.update_paging_modes = shadow_update_paging_modes; + #if (SHADOW_OPTIMIZATIONS & SHOPT_OUT_OF_SYNC) d->arch.paging.shadow.oos_active = 0; #endif @@ -2516,7 +2520,12 @@ static void sh_update_paging_modes(struc v->arch.paging.mode->update_cr3(v, 0, false); } -void cf_check shadow_update_paging_modes(struct vcpu *v) +/* + * Update all the things that are derived from the guest's CR0/CR3/CR4. + * Called to initialize paging structures if the paging mode has changed, + * and when bringing up a VCPU for the first time. + */ +static void cf_check shadow_update_paging_modes(struct vcpu *v) { paging_lock(v->domain); sh_update_paging_modes(v); --- a/xen/arch/x86/mm/shadow/multi.c +++ b/xen/arch/x86/mm/shadow/multi.c @@ -4203,7 +4203,6 @@ const struct paging_mode sh_paging_mode .gva_to_gfn = sh_gva_to_gfn, #endif .update_cr3 = sh_update_cr3, - .update_paging_modes = shadow_update_paging_modes, .flush_tlb = shadow_flush_tlb, .guest_levels = GUEST_PAGING_LEVELS, .shadow.detach_old_tables = sh_detach_old_tables, --- a/xen/arch/x86/mm/shadow/none.c +++ b/xen/arch/x86/mm/shadow/none.c @@ -18,8 +18,14 @@ static void cf_check _clean_dirty_bitmap ASSERT(is_pv_domain(d)); } +static void cf_check _update_paging_modes(struct vcpu *v) +{ + ASSERT_UNREACHABLE(); +} + int shadow_domain_init(struct domain *d) { + /* For HVM set up pointers for safety, then fail. */ static const struct log_dirty_ops sh_none_ops = { .enable = _enable_log_dirty, .disable = _disable_log_dirty, @@ -27,6 +33,9 @@ int shadow_domain_init(struct domain *d) }; paging_log_dirty_init(d, &sh_none_ops); + + d->arch.paging.update_paging_modes = _update_paging_modes; + return is_hvm_domain(d) ? -EOPNOTSUPP : 0; } @@ -57,11 +66,6 @@ static void cf_check _update_cr3(struct ASSERT_UNREACHABLE(); } -static void cf_check _update_paging_modes(struct vcpu *v) -{ - ASSERT_UNREACHABLE(); -} - static const struct paging_mode sh_paging_none = { .page_fault = _page_fault, .invlpg = _invlpg, @@ -69,7 +73,6 @@ static const struct paging_mode sh_pagin .gva_to_gfn = _gva_to_gfn, #endif .update_cr3 = _update_cr3, - .update_paging_modes = _update_paging_modes, }; void shadow_vcpu_init(struct vcpu *v) --- a/xen/arch/x86/mm/shadow/private.h +++ b/xen/arch/x86/mm/shadow/private.h @@ -426,11 +426,6 @@ void cf_check sh_write_guest_entry( intpte_t cf_check sh_cmpxchg_guest_entry( struct vcpu *v, intpte_t *p, intpte_t old, intpte_t new, mfn_t gmfn); -/* Update all the things that are derived from the guest's CR0/CR3/CR4. - * Called to initialize paging structures if the paging mode - * has changed, and when bringing up a VCPU for the first time. */ -void cf_check shadow_update_paging_modes(struct vcpu *v); - /* Unhook the non-Xen mappings in this top-level shadow mfn. * With user_only == 1, unhooks only the user-mode mappings. */ void shadow_unhook_mappings(struct domain *d, mfn_t smfn, int user_only); From xen-devel-bounces@lists.xenproject.org Mon Jan 09 13:41:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 13:41:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473650.734368 (Exim 4.92) (envelope-from ) id 1pEsP7-0008RK-4x; Mon, 09 Jan 2023 13:41:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473650.734368; Mon, 09 Jan 2023 13:41:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEsP7-0008RD-1T; Mon, 09 Jan 2023 13:41:33 +0000 Received: by outflank-mailman (input) for mailman id 473650; Mon, 09 Jan 2023 13:41:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEsP4-0008Qk-WE for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 13:41:31 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2079.outbound.protection.outlook.com [40.107.20.79]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 51afb927-9023-11ed-91b6-6bf2151ebd3b; Mon, 09 Jan 2023 14:41:29 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8348.eurprd04.prod.outlook.com (2603:10a6:10:25c::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Mon, 9 Jan 2023 13:41:27 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5986.018; Mon, 9 Jan 2023 13:41:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 51afb927-9023-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LtmaXcXgS4IYt11xQ1Y8vbtpaMjDLWD9QtxAfrLcN2h22vqk1LIYlXhlwrAJengpnqQype31VEk70YlCffD0DQOTesj351CGLyoA1KUtZ9q288HPoZdTjGTKjmzt6cwP8oqkpI1NVJO/1MiKk56KMbWwcAu5/a1G8WjhUEww+AaMEnm4xGenu3ZpQ+UX5sxHHIPKxHlRY7YwVdXPFE4dNi+Kp3Iakj3CAEv8d0vv2DHSRIp/sm4hbZKwuIjcPTM91Zkx31dtWKlBSMM5dqZhNtOI74jVDbjygQKXRTb5Ou8HWzEEnE1uue9LAxxYUOBkLzhOOx42BJcFGhlKd7VLlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jKVxpWRnLLsiXUS1L42o6OfU5C2lD6jrUePiBTdkwDc=; b=iHbeyBn/ssFl0VWeJAeZ/KS9Tio7CdbHTyepVjQzUqgOQyYhW2P95xCyvU6HGcqxwBmG5OwvOEt34tN6QFiIuvHLr9EoIP+aPBl4MJ/fyKlj9vK6knCqX5LJX66nKff+wplprgVxeriDgIZ2qgVXTGaNbEUrfdNc/E12d8xdBOQ8mcEqE63lDCv7ftGnLfHaAMepTB2KK9VZUEjTUywHrTL9HM4bg/kGi+AUhTGsTDQtPOG2iAgFWhT1dIu4tMo38AOuSm/SASQgYYZCks2GfE6/YNNasOPo36zAadOCJ+RmHEXctyjiCvqIk9NjCOoz6evex/kEC+fpJlDuIBxTPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jKVxpWRnLLsiXUS1L42o6OfU5C2lD6jrUePiBTdkwDc=; b=vMcMN10EbPFfT4G1KVaVUqa9ZSuTYv00rVEh7EAlmIcvHyfwZddIQ6VtD/EZCXVfpRYz3buWTr1ruyrZRDZO52FS8DsKkcirQ/2U5Zl+P1C9dTfAp4hIY478Go014eDjFSXTtTrUkotMYN3+frr27UfzY+Qyvkixu/FRrF1t5il1yTXyu0jtofT/acYuNmn3ZOTVSJhC29Fh6RrVz8jhu1kHsAIIuD2HOBr01JDRX2HR3toPSOSFXVSzSFzKZqyYZxqML2vg6SIk1VLET0SFIsHfJj3wcNIFxJ+M7sDXotNJPUguJWKjSBJantpXixdR5nuKIuvXsNIqi/ZtOX+Dpg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 9 Jan 2023 14:41:25 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: [PATCH v2 4/5] x86/paging: move and conditionalize flush_tlb() hook Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Tim Deegan References: <882f700f-9d79-67d5-7e13-e42c3c79ba11@suse.com> In-Reply-To: <882f700f-9d79-67d5-7e13-e42c3c79ba11@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0151.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8348:EE_ X-MS-Office365-Filtering-Correlation-Id: bfde1e5e-1d07-4bc2-69fd-08daf24734f4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0unLGsazmk15rLIvSqnFfWdz5C1osJOQGM1aoaq8KPwUdnc8n5+Abhqz+YpnFOPry4ZNZ56XAZiZz9AEERMkoJpayuTgOmnd9kBYS8G/ukVsHBKCiZXHcUcA4RaKhj3ZTv7NP9vMJUjxjiLo965cw+mFKGqgst2U/sJflSxb/rLL0txNlJD+G7nKYLBsIiiIkQPWXz1tP9SHF2iCoelV8PgBB5oc00SkiV+Obffjp/E6f39Xohf8+qhJweEhkNk6HxSFbTy8+768XSoP8Ji6iv8ECrieHApxorqSrlv1BfXwZTTKnVWTlO6QKyFlQ69GoKWPxyo/8QrwZ+06zAv/bfTyP/tC0Pb9vnAl3mbMxlztpXP40K/VFj9tnaYlFU6BhlYQ3tX6SkJyzWcYbelx3sm51dTTDd9N59xvgLWPWZPnTRvX5Tbn1jEr8UGB6OjXQfhBHy3iguns61+Xl6nLlGZg84niKnXEDJhwnR9YXkrH6NjV0FmIyi9EvoR2tMdnYybxwHNMHW9vDVsRkLLYv8RVYtWbp4ghjActDeGJfwLxLcrkmyK8QPI4f2Rxd4aRa7UYOkyRexj7mwFmjZHGUAI5AmCSQyPV+XNpfEHzk13i385t1uQ0cfNtxeqrrXa1H5Y85NEy6xqnqQfWJdVAyLLw7yCi6OAQF5e8ZU8Vxu7J/K/TY/qDC+I73FexcetisPHGTpQOx68NJaBDaMLtecNN/aOHn/WNrY7TwCl56ZQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(376002)(39860400002)(136003)(346002)(366004)(451199015)(478600001)(36756003)(86362001)(54906003)(5660300002)(31696002)(4326008)(66556008)(66946007)(8676002)(66476007)(38100700002)(41300700001)(316002)(26005)(8936002)(6486002)(83380400001)(2906002)(6916009)(31686004)(66899015)(6506007)(6512007)(186003)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y0owdkk1eXM1TjFOUW0vTFByZllScUU0MjQ1RWkyNWpmODNRYnRrc3E5RDVX?= =?utf-8?B?YytJRlRaa0toQm9aVy9aWHNLUFJQbUFsYXFVSktuQWdtcTgvWGV2R0wvbURX?= =?utf-8?B?M2dkUmZnWTAyWjZuUDJzTmRXM0UraTlUaFM5eGRqSjM4czBUUjViQ0dRSFUz?= =?utf-8?B?ZWgxNEI2dXpjZ3kraHhjOEs3S29GbWx2cmprMDZCc1gwdjJJTGRjdGZ3WHdG?= =?utf-8?B?ODM5cm5tcmV4TWw0d3hpYTN5aWhJQVNoRk1FR0RCamM5akoyZ3pBTUwvZFBZ?= =?utf-8?B?ellkdlN3OFE0TFdydWtUbTRrUEpQK2pmRTZ5R3VLRkMvZW42dmRacVpKUXZl?= =?utf-8?B?dVd3azhpR3BNVEJPLzlsR0NxSHBIZm1IczVhekF6OG5nclJtcUoxbnpET3lp?= =?utf-8?B?U21QdG9yMGtreEpib2w2bG1JUHFwY3JYNTJxY00vTHcydEVoREVqY2ZEakc3?= =?utf-8?B?b1FUUVNlWmJCeVBPQTJ5WmJDM2VhZWFHakozaGNBakcxR2E3OFhtN1Q2ZGNO?= =?utf-8?B?Yk5Nd1l5elIwdmhlN0M2SGlhUnVlQkRqMFYwT0VQckdEcE45dVJjWk5QY3Ux?= =?utf-8?B?WjRCS0kzWmZ6dk9ncmEwQStXb1UzWkp5a01xVUdWR3Y4Q2dYMUcvYTFKclI5?= =?utf-8?B?bjVGZXdSQ25STnpLdENSclZHTmZESHppcUxqVmJubDc2Q2p3cDU2Q1lIenpJ?= =?utf-8?B?UFdyRXVJa0tNNlArcXZOTHd4dkFjV09sSWtNRFJCZ0d5YTlFQXdieS9CdDgw?= =?utf-8?B?VnJPMXpwZ2h5aU9wTDUvTlE0ZVhmZjVWZzRYYkFzUEE3M3VIaEUzbnk2SVF4?= =?utf-8?B?NnpSMis1NlZYekF6RE5MdFQxSEdhYmhRME9vYndlb3VCSmkxUGYxMGpiWXND?= =?utf-8?B?cDl1eEc1T213ZkVPVjNPbmVFRVpjN3l0Yk13bGlFdTFGbVM2c3k5YVRXN2Zv?= =?utf-8?B?RHg2N01OWUNxd2h6dDdGcHNaTmwvVTdXbWE3MUhiVmRIM3gvamdaZmt3U2lj?= =?utf-8?B?WDdFcWNoMlEySC9ST2U3LzJLclR1d0crVExpSDlpWUxFM3ZUTlMxYXM1bXho?= =?utf-8?B?VGxnSFF3VVhDOStSUmVsMXFYamZoMDBybC8xU09CbncydFN5MGxpMjV3VUlL?= =?utf-8?B?TVcyOHgzamsyanIzcWNMRnVIcW81NXZ4MURyWFEzS1RJbkR3dC9OemNvWGUw?= =?utf-8?B?N0tjYXhRU2tFMG1IR0IrU01qR3pHdUxCcnJVaW9kZGpTNWxhMm9WTE52K0NC?= =?utf-8?B?dTlycFBjSEh3dEMwdlZNeC82K0pta2VBZmVKYlNCVHIra1hjNjJnaEFnTm9C?= =?utf-8?B?ZDBkeldNVXhpUXBZbWdpZDRhcnl6VS80M1pyS1ZlR21UU3lrdVFHZVEyL0Y0?= =?utf-8?B?SkJ5bUI0ZkNacmhma1F2Uy9YQUZzVTJOL0xORXpha1Z0WDZkWFVla1hTQ0V6?= =?utf-8?B?Y0tzVlYyUkU4UGJiZkQrWnp5SDFBb2NxWXBLdUNlR2UwNnZ2bnNvRTNnYzNR?= =?utf-8?B?ODk5VzkxS1hOYmVNZXhGYVhDazFoaGZXeDlmb2IwWEdkWDRrRWVTeEcyQ3ZQ?= =?utf-8?B?V1lmMjZnRDBCTFl4cURuamVZRThpT2tYUHU0aWJuc1dHdXdSWlFBd1NjdFJ6?= =?utf-8?B?dU9zZms2dDhBUGx4aUNqamFSOEV1VjJMZlIva1ZXRysrdFphZ3dRK2tMdUZ3?= =?utf-8?B?cmRVKzM0OTljTHBMTURGWmZzK3V5bFZtUXZaZ1NSalVJc1VYMjhkUFVPb0Fm?= =?utf-8?B?TytTR1NmS2tiRS9hd1pPcm5kSURObUJ3NUNaZVlyUDZQSU9LdUhUMVhTd09K?= =?utf-8?B?dFFCQ3dMaG93NUhMU3FKL0c4cllNMkJ0MHpJNWh0cy9acm5LNmJIWnpNMVVh?= =?utf-8?B?NFVxVkg2R2ZGZU5Xcm9ZcHYyL3NzNG1PZ0dBR0pxd1ZtRC9zN2JBeHJpZ2c3?= =?utf-8?B?VGlncXFxa2xlUTNDZEZZcmxSUDk5TkNITFVJVGFyT2dzdnZxU1NDQ3F1LzYr?= =?utf-8?B?dVBaczlsMEl4bzYrVFUyL2dUR3c3OXlDQmZBc2VHRHF2a0xMVytnaHhmZC9v?= =?utf-8?B?QXNla1VObFN2STRqSFMvcjVLWUdOZ3EwaElieFhRSlZlWjVPTEVjQ09vSFh6?= =?utf-8?Q?27WHGR8KeH/U0QQGCA+UcojOG?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: bfde1e5e-1d07-4bc2-69fd-08daf24734f4 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2023 13:41:27.2316 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 81YsYPoRvEOYWZRseE3AHjHUeqUF1GH5K++BWi6muNxpn31yw4f1XSTE/Rrw8M/wv0Qy4yZ+TTkqECabKDkKAw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8348 The hook isn't mode dependent, hence it's misplaced in struct paging_mode. (Or alternatively I see no reason why the alloc_page() and free_page() hooks don't also live there.) Move it to struct paging_domain. The hook also is used for HVM guests only, so make respective pieces conditional upon CONFIG_HVM. While there also add __must_check to the hook declaration, as it's imperative that callers deal with getting back "false". While moving the shadow implementation, introduce a "curr" local variable. Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper --- v2: Re-base over changes earlier in the series. --- a/xen/arch/x86/include/asm/domain.h +++ b/xen/arch/x86/include/asm/domain.h @@ -237,6 +237,11 @@ struct paging_domain { void (*free_page)(struct domain *d, struct page_info *pg); void (*update_paging_modes)(struct vcpu *v); + +#ifdef CONFIG_HVM + /* Flush selected vCPUs TLBs. NULL for all. */ + bool __must_check (*flush_tlb)(const unsigned long *vcpu_bitmap); +#endif }; struct paging_vcpu { --- a/xen/arch/x86/include/asm/paging.h +++ b/xen/arch/x86/include/asm/paging.h @@ -140,7 +140,6 @@ struct paging_mode { #endif void (*update_cr3 )(struct vcpu *v, int do_locking, bool noflush); - bool (*flush_tlb )(const unsigned long *vcpu_bitmap); unsigned int guest_levels; @@ -300,6 +299,12 @@ static inline unsigned long paging_ga_to page_order); } +/* Flush selected vCPUs TLBs. NULL for all. */ +static inline bool paging_flush_tlb(const unsigned long *vcpu_bitmap) +{ + return current->domain->arch.paging.flush_tlb(vcpu_bitmap); +} + #endif /* CONFIG_HVM */ /* Update all the things that are derived from the guest's CR3. @@ -408,12 +413,6 @@ static always_inline unsigned int paging return bits; } -/* Flush selected vCPUs TLBs. NULL for all. */ -static inline bool paging_flush_tlb(const unsigned long *vcpu_bitmap) -{ - return paging_get_hostmode(current)->flush_tlb(vcpu_bitmap); -} - #endif /* XEN_PAGING_H */ /* --- a/xen/arch/x86/mm/hap/hap.c +++ b/xen/arch/x86/mm/hap/hap.c @@ -445,6 +445,7 @@ static void hap_destroy_monitor_table(st /************************************************/ static void cf_check hap_update_paging_modes(struct vcpu *v); +static bool cf_check flush_tlb(const unsigned long *vcpu_bitmap); void hap_domain_init(struct domain *d) { @@ -458,6 +459,7 @@ void hap_domain_init(struct domain *d) paging_log_dirty_init(d, &hap_ops); d->arch.paging.update_paging_modes = hap_update_paging_modes; + d->arch.paging.flush_tlb = flush_tlb; } /* return 0 for success, -errno for failure */ @@ -847,7 +849,6 @@ static const struct paging_mode hap_pagi .gva_to_gfn = hap_gva_to_gfn_real_mode, .p2m_ga_to_gfn = hap_p2m_ga_to_gfn_real_mode, .update_cr3 = hap_update_cr3, - .flush_tlb = flush_tlb, .guest_levels = 1 }; @@ -857,7 +858,6 @@ static const struct paging_mode hap_pagi .gva_to_gfn = hap_gva_to_gfn_2_levels, .p2m_ga_to_gfn = hap_p2m_ga_to_gfn_2_levels, .update_cr3 = hap_update_cr3, - .flush_tlb = flush_tlb, .guest_levels = 2 }; @@ -867,7 +867,6 @@ static const struct paging_mode hap_pagi .gva_to_gfn = hap_gva_to_gfn_3_levels, .p2m_ga_to_gfn = hap_p2m_ga_to_gfn_3_levels, .update_cr3 = hap_update_cr3, - .flush_tlb = flush_tlb, .guest_levels = 3 }; @@ -877,7 +876,6 @@ static const struct paging_mode hap_pagi .gva_to_gfn = hap_gva_to_gfn_4_levels, .p2m_ga_to_gfn = hap_p2m_ga_to_gfn_4_levels, .update_cr3 = hap_update_cr3, - .flush_tlb = flush_tlb, .guest_levels = 4 }; --- a/xen/arch/x86/mm/shadow/common.c +++ b/xen/arch/x86/mm/shadow/common.c @@ -68,6 +68,7 @@ int shadow_domain_init(struct domain *d) d->arch.paging.shadow.oos_active = 0; #endif #ifdef CONFIG_HVM + d->arch.paging.flush_tlb = shadow_flush_tlb; d->arch.paging.shadow.pagetable_dying_op = 0; #endif @@ -3092,66 +3093,6 @@ static void cf_check sh_clean_dirty_bitm paging_unlock(d); } - -static bool flush_vcpu(const struct vcpu *v, const unsigned long *vcpu_bitmap) -{ - return !vcpu_bitmap || test_bit(v->vcpu_id, vcpu_bitmap); -} - -/* Flush TLB of selected vCPUs. NULL for all. */ -bool cf_check shadow_flush_tlb(const unsigned long *vcpu_bitmap) -{ - static DEFINE_PER_CPU(cpumask_t, flush_cpumask); - cpumask_t *mask = &this_cpu(flush_cpumask); - struct domain *d = current->domain; - struct vcpu *v; - - /* Avoid deadlock if more than one vcpu tries this at the same time. */ - if ( !spin_trylock(&d->hypercall_deadlock_mutex) ) - return false; - - /* Pause all other vcpus. */ - for_each_vcpu ( d, v ) - if ( v != current && flush_vcpu(v, vcpu_bitmap) ) - vcpu_pause_nosync(v); - - /* Now that all VCPUs are signalled to deschedule, we wait... */ - for_each_vcpu ( d, v ) - if ( v != current && flush_vcpu(v, vcpu_bitmap) ) - while ( !vcpu_runnable(v) && v->is_running ) - cpu_relax(); - - /* All other vcpus are paused, safe to unlock now. */ - spin_unlock(&d->hypercall_deadlock_mutex); - - cpumask_clear(mask); - - /* Flush paging-mode soft state (e.g., va->gfn cache; PAE PDPE cache). */ - for_each_vcpu ( d, v ) - { - unsigned int cpu; - - if ( !flush_vcpu(v, vcpu_bitmap) ) - continue; - - paging_update_cr3(v, false); - - cpu = read_atomic(&v->dirty_cpu); - if ( is_vcpu_dirty_cpu(cpu) ) - __cpumask_set_cpu(cpu, mask); - } - - /* Flush TLBs on all CPUs with dirty vcpu state. */ - guest_flush_tlb_mask(d, mask); - - /* Done. */ - for_each_vcpu ( d, v ) - if ( v != current && flush_vcpu(v, vcpu_bitmap) ) - vcpu_unpause(v); - - return true; -} - /**************************************************************************/ /* Shadow-control XEN_DOMCTL dispatcher */ --- a/xen/arch/x86/mm/shadow/hvm.c +++ b/xen/arch/x86/mm/shadow/hvm.c @@ -719,6 +719,66 @@ static void sh_emulate_unmap_dest(struct atomic_inc(&v->domain->arch.paging.shadow.gtable_dirty_version); } +static bool flush_vcpu(const struct vcpu *v, const unsigned long *vcpu_bitmap) +{ + return !vcpu_bitmap || test_bit(v->vcpu_id, vcpu_bitmap); +} + +/* Flush TLB of selected vCPUs. NULL for all. */ +bool cf_check shadow_flush_tlb(const unsigned long *vcpu_bitmap) +{ + static DEFINE_PER_CPU(cpumask_t, flush_cpumask); + cpumask_t *mask = &this_cpu(flush_cpumask); + const struct vcpu *curr = current; + struct domain *d = curr->domain; + struct vcpu *v; + + /* Avoid deadlock if more than one vcpu tries this at the same time. */ + if ( !spin_trylock(&d->hypercall_deadlock_mutex) ) + return false; + + /* Pause all other vcpus. */ + for_each_vcpu ( d, v ) + if ( v != curr && flush_vcpu(v, vcpu_bitmap) ) + vcpu_pause_nosync(v); + + /* Now that all VCPUs are signalled to deschedule, we wait... */ + for_each_vcpu ( d, v ) + if ( v != curr && flush_vcpu(v, vcpu_bitmap) ) + while ( !vcpu_runnable(v) && v->is_running ) + cpu_relax(); + + /* All other vcpus are paused, safe to unlock now. */ + spin_unlock(&d->hypercall_deadlock_mutex); + + cpumask_clear(mask); + + /* Flush paging-mode soft state (e.g., va->gfn cache; PAE PDPE cache). */ + for_each_vcpu ( d, v ) + { + unsigned int cpu; + + if ( !flush_vcpu(v, vcpu_bitmap) ) + continue; + + paging_update_cr3(v, false); + + cpu = read_atomic(&v->dirty_cpu); + if ( is_vcpu_dirty_cpu(cpu) ) + __cpumask_set_cpu(cpu, mask); + } + + /* Flush TLBs on all CPUs with dirty vcpu state. */ + guest_flush_tlb_mask(d, mask); + + /* Done. */ + for_each_vcpu ( d, v ) + if ( v != curr && flush_vcpu(v, vcpu_bitmap) ) + vcpu_unpause(v); + + return true; +} + mfn_t sh_make_monitor_table(const struct vcpu *v, unsigned int shadow_levels) { struct domain *d = v->domain; --- a/xen/arch/x86/mm/shadow/multi.c +++ b/xen/arch/x86/mm/shadow/multi.c @@ -4203,7 +4203,6 @@ const struct paging_mode sh_paging_mode .gva_to_gfn = sh_gva_to_gfn, #endif .update_cr3 = sh_update_cr3, - .flush_tlb = shadow_flush_tlb, .guest_levels = GUEST_PAGING_LEVELS, .shadow.detach_old_tables = sh_detach_old_tables, #ifdef CONFIG_PV From xen-devel-bounces@lists.xenproject.org Mon Jan 09 13:41:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 13:41:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473652.734379 (Exim 4.92) (envelope-from ) id 1pEsPS-0000We-Ch; Mon, 09 Jan 2023 13:41:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473652.734379; Mon, 09 Jan 2023 13:41:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEsPS-0000WX-9q; Mon, 09 Jan 2023 13:41:54 +0000 Received: by outflank-mailman (input) for mailman id 473652; Mon, 09 Jan 2023 13:41:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEsPR-0000WK-Tt for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 13:41:53 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2088.outbound.protection.outlook.com [40.107.20.88]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5f5c314d-9023-11ed-b8d0-410ff93cb8f0; Mon, 09 Jan 2023 14:41:52 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8348.eurprd04.prod.outlook.com (2603:10a6:10:25c::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Mon, 9 Jan 2023 13:41:50 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5986.018; Mon, 9 Jan 2023 13:41:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5f5c314d-9023-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=My+JoqO6h5y27qEa+gNkIzD5XbmjuEeij+vbmCg7+wb+oDbVVbZmF+k8hPhK3yujbhBr21qZLHItaForEQSwG9QtC4WklzHJwa7qaFp4HXgLG4HwqA5JtsEHw57C3Ua2vCFxTe2JCaH1TqQ+GBHZ274vONz3eHlEr6u39etx28WmMED5srjoMKmdAJkwGsmD0mrq3WtHI5cu6X+u0GFo/n0o3DsYiZE7sf3Z2Xkdi+HEvqor9t4dAKuezNmbBCvWxUnEJfCubtekRKfjAY4f46pjYxn7yOsWR51GVMiXah3u4gfAxodMCVVeHyigp8hzrVW622mj6xc4ZZe2s2jYgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ldmrcBpaOs88X5aWnm3c9XzMTqcT0z7U/BEsg7rlocA=; b=oOpP5kcDhrQNgTmKSkFoukYGoyZ5AeCfPw8RHlKIP28B/2cMUN/EIVwJlJbI99T3l/tmBqTCRTYIBSD9F/gxT4WmfT8DwO7CF5mHMgiE17H22BmAMolr4H+BkKtHvBHkGGQLU2T5zS3jaRCHg7iGZNx3//jM1HeJv28rhyQgg6cVPOrFs+dkIgOCt38jVDLNOdvIXuCIr+rBnXSVm+wgoSVpxBtYIR+JvS8Xzl/hw9oERG4zqj/4opGmSc6ZA/iSJ0SMy0tx7UcovYF2iFyLBGWttTjcvIyevk8tGySfqeBw7mxuxDldUOvc3axY2VfFPoyH1lLZ2OvVGKF6lEfeSw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ldmrcBpaOs88X5aWnm3c9XzMTqcT0z7U/BEsg7rlocA=; b=4AWJ/z4QMmbuE+TdW4gHklaV7jUuMXm4kCBH5TEScwQ2pH+leo9Qlfy8kKfztQEjz5doiBGb9nsx7WlE2iJsIPWGt/CWf5+EZKpC3PnEM/HuPPEdgyRU2yyJ4SneWmI9ZE/2owoXVNut7QL6medqo62wR2eMASBREimJpCGkTsgQB3GfoV65eWRGzmIQjD15O+4u02hbYaKCMlTAWFU9qNftZe1KcacDm/vJN0hymupxdIWGj7jydJH2b4XPhHxqIHjdU8MSN6dzpbmhZ36HN4okSU6cn3qbiGF3MM121AbFWPmLeGUJRS7iKL6Gu/CN5TxeRUCrLfYThG6uGC1YlQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 9 Jan 2023 14:41:49 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: [PATCH v2 5/5] x86/shadow: drop zero initialization from shadow_domain_init() Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Tim Deegan References: <882f700f-9d79-67d5-7e13-e42c3c79ba11@suse.com> In-Reply-To: <882f700f-9d79-67d5-7e13-e42c3c79ba11@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0016.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::21) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8348:EE_ X-MS-Office365-Filtering-Correlation-Id: eebc57dd-0faa-4bb9-2a30-08daf24742de X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /g5Fhg/WFGQ3i6EQjIuIAJrgx6d+r9ywCwbB+v8XzL0fn21OiVNDh1YoO3qgfd284PczrIxwKp/ISWhMeA6SWTD+fc7h4qOERKFWHZ3FiFu43P1snWsQwaEFLDxoFg7Xz/RnWsxVy2gzDJtjprBBLjWy1pApzjpFuO1n7hyAE98GFMF/6s7gVbJJsHGYp3ixwmrtyQb/D6+aD2gGJw+zaKuHH2WYteZDDvkR1sPGWO66G9hbUCgaiDQMeAKZKDgrzfFF67DulJ5LNXNQR2F2rUhthshatkOAomcq71fIJX6SlpYv3XBDLJA7YnBraa3zt+JnnuQN5QnpPqJwAJ3BNAtlg/Vt1kQ4tVOEGvSBHgfVIBbI/cggmOYDRmGYk7c65Mr0ETZAok6awTwcy+ZYT1SSPwS7IVsHA15CKSzYDue2XwOoVEIJwcBZl4jfqVETb23RUA4ut5EOMFjufpLG0ykBOBG0XPgHsg2toEr19TY3E0aTReC1ZbKB2uCZLQV0JjL3jVqwT7Mc+vyh+K2d6jupE647EUwTweV0QDRkj7lYt8Xu6KZ14JoJXEen84GgdurfxFl3So9H2DUOB2+JisEhqdpGLCoRZxIstVR49NOwgP82ZcDsij3gwt5QTccWUYen1TaMjKnu4lBOO2t8fOqui/mWKwWXsbYFcHAJQmNZ03a8uCUQAF/4lvPv2zTkrERHupkxKMzmVqOhyUQtjAAESjYfAwZFHnn4vlxPq+A= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(376002)(39860400002)(136003)(346002)(366004)(451199015)(478600001)(36756003)(86362001)(4744005)(54906003)(5660300002)(31696002)(4326008)(66556008)(66946007)(8676002)(66476007)(38100700002)(41300700001)(316002)(26005)(8936002)(6486002)(83380400001)(2906002)(6916009)(31686004)(6506007)(6512007)(186003)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Ukp0RUxqdUp5aWp6RjRQSTVTR2piZFhScFhLSVdzOTVTZm1HY01La3M0QjQz?= =?utf-8?B?R2xDd1ZLWkxZYmVoM2xFMlZnbTJKMWpnRkhsOFV0cE8rMWZVUExMRld1dW9r?= =?utf-8?B?bm5VN3VoSTk0QnlNWE5tdjVkeEJIZlZUc1VBcHE1b3c2aUFFeEExUHpFVm1l?= =?utf-8?B?OUxNM2NMTlNla0pMbnNkQVJZZzZRb1pnR05nTDdaTmtMVnMyaG1rYzhIWldi?= =?utf-8?B?RlFTQjRFdW1YL3ZCa3o0UGNSVnF6ZWdRUC85TGhiNkVtc2loZ1A4d29vbUZi?= =?utf-8?B?aHdpZk1VRUNGL1hLcmpGWFUzUE1CUDBha2lLTE1lNVB3clE2VXh2UnNWL2xh?= =?utf-8?B?dFZoMjgvZ3ZRYW9HVFVyOFBENXJjTzUzOVVkbzNCd0YwNGVTSjFybkhKNU93?= =?utf-8?B?ZzRUbUhJcDJQQUJPRzVSYTJyNVl4V0NVK01xL0dOZitQbHA2M3lsdzF6eSs0?= =?utf-8?B?VjJiS0NpUkZPam1JZG9SK3lQRklOWXZSeTBpMC92NHNBTHdDTERJYVd3RGEv?= =?utf-8?B?bnNaNmJ5RUJPTHdQbEJzYXVHb2dZYXhxcFN0NjcwSFZhUk8rWkhlZ2tQREI4?= =?utf-8?B?ZVcxdytyZVJJblQ4M2gwRHdOYjhFYTZYVGpoNXQ5Y1M0a2xiT1kwQjJSUVVN?= =?utf-8?B?a2pkeXVtOWt5VGRJRDNpeE5KZStYOGpTaEc2d1ZvLytkQUxyU0VTaG02VVRB?= =?utf-8?B?Sm1sR2d2WThOcURheDFpV2k1OHk4WkpHdDBWdEtLbjhqZzB1STI2RkxPa1Ir?= =?utf-8?B?SzRNSnZOR1ZwY0hoWEl0T2pmSHkxbGlBZGgvdFIzN0ZhMzhTdHpzYUZ2ZVdF?= =?utf-8?B?YkFKL3RXRzFaUFRCVkpWR21oNTYrZ2NnVkpWWUMyODFzQlJuSldaNytNdXUv?= =?utf-8?B?eEZXT0Q5ZzY0TjEvQ2xubEJnU0ptTDRMRWlRcmc1dnFBMC9UWmFWWWd1d3ZC?= =?utf-8?B?M0ZVT3c5UUU5R3VEbUhIZ0NZdW43YngyV2p3N296ZGZDU0U1MWptYk9xNy9U?= =?utf-8?B?UU8wK3lWWTQzNmFmUXJvbVRPRTc3TnVvY3JFVlB6YTM3SzgvazBKcXlEbW95?= =?utf-8?B?U3RlUlNKM2h3TEZoQTI1cldPSXFGalI2VlFFQ01nMFZQSkxZbVQvcmxRbzdk?= =?utf-8?B?R1BZeTZPdEoraDJ2R0FHc1RvamExanpaMDA5MTdSTm5DZzZzT3JoRk5hQ1Ey?= =?utf-8?B?VmFIaU9qZXFjeTVsbVU2bzNQUDBUZ2dBbllieXdWd3JtV1FzbFE3NjNydmRB?= =?utf-8?B?RUVnMUREZkVNZWJJTmZaSS9RTnNEbG1xREZhU0RJZ0NMcnFiQTNlcExJbGxD?= =?utf-8?B?V2JNUTFHSlNtVjgwM014Y2gxM1laSGJ5ejF3ZjVBb05oNUpZQmNlOXd6WnVP?= =?utf-8?B?UnZTS0NSSTlrVCtmcnBFaVhFM0V4R2VZaFlMMDdzZCtzZFlNRnBpc3lybVBy?= =?utf-8?B?TmVSemhLQ1J0Tkh5dUkwSXY3czB4Wmd3d01PKzBOZ0R4Nis5bG12Qlo3dk10?= =?utf-8?B?dy9aalZaWW80WG1VV0dUTHJmdDhJNXhZc05jUnpuWGZjdzBSZ0cxVnM1MExo?= =?utf-8?B?UmYxeEprajQvR2RaK1c2WnlBWEdUR003MTFPa0JzZHNjY0k2RE8vNXdPdktK?= =?utf-8?B?dENKQk5tVE9iTVh0d0dORnZmaC9XRWU1L1dkVDMxTXZVSTJpeFdoT25xekxw?= =?utf-8?B?S2xtZk0wLzVPQUtwSU9zZm5iVFZrVElMdlVWY0wvMFFWS2xiNEdsLytOTWpl?= =?utf-8?B?RjhEZ01RT0xTRWNNc0M2THp0eVdHaHdGN3k5UkFlRnZkS2FyM0tKZ2xsUmpD?= =?utf-8?B?dStLaHMvYmhXemdMZS9SdEt0OWg5RGpSaitEZDAvbm9xc295cmlpZlVkaDBF?= =?utf-8?B?MTV4YW1ad3IwZ1g4TlpkYXlvZEQwOHRIc1ZzWXZENEVKdmdTV3pzb0dNOXR0?= =?utf-8?B?Z2pKL2NnWnRVdFNnbkJUeWV6RzIwckYwVTFDbFdLRzlSbWYwZVFJTURabldO?= =?utf-8?B?Rk45dVEvVUFIUE1jR0R2ZExteWkyRnA5bjVSd0JIUWs3eURsR3pxbnkyT1Iz?= =?utf-8?B?R0xack92M0dETitVQzJ4eklUT3JuUEc5UmU0ak5DbVh6U01NaitJQ3orSlVz?= =?utf-8?Q?wmbRvaLJsG4vzq7dGK4JXPJeQ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: eebc57dd-0faa-4bb9-2a30-08daf24742de X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2023 13:41:50.6364 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ydGtY3AoJ3GhLG0asHd4xt16nog1wJxntn0TmoVTnoRM71INdJBM91TvfEUzCA5g2D5o2E8wImVHh8qTUVmHuA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8348 There's no need for this as struct domain starts out zero-filled. Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper --- v2: Re-base over changes earlier in the series. --- a/xen/arch/x86/mm/shadow/common.c +++ b/xen/arch/x86/mm/shadow/common.c @@ -64,12 +64,8 @@ int shadow_domain_init(struct domain *d) d->arch.paging.update_paging_modes = shadow_update_paging_modes; -#if (SHADOW_OPTIMIZATIONS & SHOPT_OUT_OF_SYNC) - d->arch.paging.shadow.oos_active = 0; -#endif #ifdef CONFIG_HVM d->arch.paging.flush_tlb = shadow_flush_tlb; - d->arch.paging.shadow.pagetable_dying_op = 0; #endif return 0; From xen-devel-bounces@lists.xenproject.org Mon Jan 09 13:53:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 13:53:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473664.734390 (Exim 4.92) (envelope-from ) id 1pEsav-0002G3-DT; Mon, 09 Jan 2023 13:53:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473664.734390; Mon, 09 Jan 2023 13:53:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEsav-0002Fw-AJ; Mon, 09 Jan 2023 13:53:45 +0000 Received: by outflank-mailman (input) for mailman id 473664; Mon, 09 Jan 2023 13:53:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEsau-0002Fq-Dt for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 13:53:44 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on2083.outbound.protection.outlook.com [40.107.14.83]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 06b0a9cb-9025-11ed-b8d0-410ff93cb8f0; Mon, 09 Jan 2023 14:53:42 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB7183.eurprd04.prod.outlook.com (2603:10a6:800:128::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Mon, 9 Jan 2023 13:53:40 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5986.018; Mon, 9 Jan 2023 13:53:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 06b0a9cb-9025-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E0tEHTExiuTOqFnDhL6pPEkwBOcPREzl45Bmkgu3wQO0wDdZzHuHcHEqxjQhM3v9/WLp9PC5IaSek0fbuZC3gq7IzcrUHtGeZRRCtWcJIefHuD4n+Ns87ACaS6uBDZCTFi/3qAk2Js+Ff/2k5hKhmnL0WS3tAcHjucvCgnVd3X21MEhO4LDoUPsI6FOd+TWDTf/mc5L/gIz+0EQkHse01/LdmkSzwBRntC2RiKVnvvnzrV23eKdorIsiggWNQygaA8Pq9h1J6XlWXa6TU8L41gsKAUf2Z1V9X6iLWkXyX6GArDN/TeUP6/awqvmcKNV2EI9KYOmjJHz0YR69POm7Fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UB+XLs3uTRl0EN98OjmZEzYQQmFrZx6LJBm6WUg9zXQ=; b=Cdi8zp/OdcgF8wqFKhiZboYamcqJ5cUUCw01XU7M8YUPEvdBPp/AZVoVSHGec+6onJWys7oteWwLFBx0FGMM+WVAm6kjEOYdoaqLHGV/uNIlOJoRmml30SYqIbr59fxkiMmLiPEoDVeBZismINScXzwu9bHVfLkmiA3EtHMEKoSqijzI7g7in9U/IpMkMV2POH8G/MeYpwjnC+YF+8Od0Uqmh+V4NZDX/gbRV9a4RNZZr/oRyU6nH/SWZW+2hxwjhhkQ3ksby4VV1OxG22ufUGRbLwcSDs/xrmDS8+aH/utmTXiXufCtpkx5RsaFtIZx3TD5s4uuuPuK0+I0fP+hqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UB+XLs3uTRl0EN98OjmZEzYQQmFrZx6LJBm6WUg9zXQ=; b=E//Up1tmz51BFj0CvPMV3O7zhzXCh/ipiVodjWL7l8I/P3v6wiJWXrmUgA6kENIMeCvXO7A6NnHAHlos+d9g60Pwi77Kd1MlUmZYNXZBwr9+qxMRO03tVsAFhT7VxDcATVpEhwmc+IGYuajeQZod6Uqp1m1mvOz1LsPb6QOjVbA7yTAfWC+OrH0MdPwEalJfLZfjd+esEQj9GRJ/9nCC9OnhrauMXHkDHdCbIM/77/d9RK0q5GcXB/F/7SuG6a9h2fPcBD/jFzdjP4rMY19o4rknJp6peua0j86Y3opMFxRm77urL3YbmZCnOeNPzE846AxtY1Gtp4LPY86bxOwwMg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9b2a41ca-f801-7188-e961-b29f577b8d78@suse.com> Date: Mon, 9 Jan 2023 14:53:37 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v7 2/4] x86/mm: Reject invalid cacheability in PV guests by default Content-Language: en-US To: Demi Marie Obenour Cc: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Tim Deegan , xen-devel@lists.xenproject.org References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0159.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:99::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VI1PR04MB7183:EE_ X-MS-Office365-Filtering-Correlation-Id: 8c85d9ff-4a18-44ee-ddd4-08daf248e974 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 23cjNQZz7xzlHnSCtkZ6zY/GBy1qbAENCqe7n3KKAucGlbQqtAh0Boo2RaX7N/oV7EWM7aFpXnYiuzOTnaNfToyY8XIMPfjsKWLnIYV5mjoy9AOFW4+BnZ8727skM8vbDHLF1GZWlbzSAvpH+D7Uyp/P9IggXwHmwo/USPYncaKEW9bikinqVkfF+yReIzCN7i7m9UmRmsv9Iwe6/t570S/aw7y0/6f1+cIVFeiA0MuHwURlxAnQdYR0ALErv20PtOHXcIJoQ+CJkDlNk11wvzUcKL08gA5K7jBSybuoZWCzoa16mtvY5/tEBpHDJyAxrulR3Ran7mlB2+Id6apbMAhafQpqFRGJzMhlZrQouyPjsK3uy3nrtqSIfYvlfHOk6/pNniKebtlqxQ6vuVm4bzZjiL0XAVlJTM2mVrwlpjc3rTh+dcNztzt5kpx5oUTRXqYgQEWxc7rGhAZi6248LmnyFWbuncjOtdVdujoLmiSPgmutxTJpmsg4bmNZmMRXdtxPilLweA/vU4+WQT+nI6p/XRi0MkblBi8Hu9gP+FKwfTOGBC+IbsHe1iKxETV2B1Fct3bGeDidnbIiVNkXvuynBCx1vVMaIxy/YS/bKxCUTJ/JnbuxUb0qqpm9GswOBoMucIGgh8YabpmK5x21kOEFWmy5JmtbacDAAmF/wE+0ShaJb4hCYVfXBKCyV8zoj4dhkOdpZHMg09HTm+HFUDzlIL7NBlv+nKJC/D1Mq0k= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(396003)(366004)(39850400004)(376002)(346002)(451199015)(316002)(5660300002)(7416002)(26005)(6512007)(186003)(6486002)(478600001)(2616005)(31696002)(41300700001)(6916009)(54906003)(4326008)(66556008)(66946007)(66476007)(8676002)(8936002)(83380400001)(86362001)(36756003)(31686004)(53546011)(6506007)(38100700002)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NGZIcDhtR0xCYmJiNCt3SDd3dkZZMENKQVVlOTcxenphOW1RZEFUMk05RVVY?= =?utf-8?B?anRneksveTdJK3lGNXNZNEhpTXlQaWlZcEZhMHVVU3hJVnVlaEVUdTY0NkZr?= =?utf-8?B?YUczWWZMNmlucnFCSmdYMFFGSkJHTjRIcXJ0R1QzWUI2ai9TRkI3Z2ZjdjNO?= =?utf-8?B?aFRPekMwa0RXUTI0aUhHSWdTdkpnWmRaY0VyekF2QVZ1SktLT254ZGxPNFoy?= =?utf-8?B?R3lzei96eWRBKzdEU1RiOU1UQVI0SkFYbkdHL0hvTGxmbytQRG02SFpHT2Rp?= =?utf-8?B?L0NaaTNQREU3UDRnRTRGemhpTFlOQkUxSmkydnlMbTZUSjZwcWUvRDhmU2t6?= =?utf-8?B?N0J3RW1kUHVJTXNmREdYNVR3aHl3bGpSdWY3TGRqYTRUWm1ObWNlZzQrdzZ5?= =?utf-8?B?cWNtMGRiVHNlRWt5VXhlbTdhWmJzM2l0M2F4ZnVzeDJ5QVlBZmFSOWZ5Rm5C?= =?utf-8?B?RXNOemhkWm81V0laeHArM2lvV2IzYlV3amRlNmNGRFY3TUZ0bzZGN1JlVDRy?= =?utf-8?B?Y2gxVGtmY2JMbnArKzJOY1JrbVNhcXVpczNVeXgvV3JpWEw4ODM5YVhyR29a?= =?utf-8?B?TXFYYS9YNmNIRjg5dGFpbTltUlhaaHJ5djM0MXNSbkFtSWJHWEFTZlEyRHJX?= =?utf-8?B?ZUk4WXh6L042bXNOQkQyQVdZWTUydGRzOUhPV2ZSSWk5TmRwQWNjZmlnRXAw?= =?utf-8?B?MGRoZVNYaExMenJJZ1FxVWxnTG1XZ0xUSmRyL2owZk9ESFBoQ3NQME1PckJt?= =?utf-8?B?TVZKY0FQeTBYNVFobUxLcFo3ZUpRaFZuZ0YwL0l5bnVuNEFKcnFnQWNiaEk2?= =?utf-8?B?dENoc3EyQ0t2di9CeWpuWkd5bDBZVU9kTlpManlLUTdYYlJqYlVycFZCK1Nl?= =?utf-8?B?TS9oV2lLbU1TR21xZjZMeVgrOWpmaG9YOFM4RUM1SEd4Y0FaZUh4WDlpZUtL?= =?utf-8?B?enhIdG9iUUo5MmJUTlY3cERMU1RTNXgzY1hRODgrVk9qaldLUTY2WllZb05Y?= =?utf-8?B?d2RTTjcvelR2YzdHbUxyNGlkVHdhLzFwQUFDNmgzWjJ4eWRIc0ppM0ZZVDJs?= =?utf-8?B?Yy9RZk15eUVGSkRVZnljR3BPdmFZaTFWdmd3bW1mVWVIZmJDdXRnc1EweFlp?= =?utf-8?B?RTA1QXd4cDgzdjdYN3h6ek4xQ2ZXUUJhRmY2RGZMM0ZucGlvYlpJYTE4c01F?= =?utf-8?B?U3FlUkVCdkRJSXVaMmw5TVNqb0VtVFRyQWdpV296bklkOVpvek0xbkwyZUhV?= =?utf-8?B?ejhIdEJtTjNVTDV5emVsQ0R5WnI1dkY4N25KM09aekpZd1FscUQzWk5kTUIy?= =?utf-8?B?b08zdVMvcDdZUVhOSTF5bzlOREpnVEhZem11STFWNUtLQlRMTzg2Z2VrejNI?= =?utf-8?B?V25kUDlwV1ZEdS84Um9Qa3NxV1JQS2xidXdzalozWGpDUWJNNCt4RjZPU3dm?= =?utf-8?B?V3ZSZUR1cEFjbXdqQzMvakczdkdiNDNLSUpLODN1ZHplWC9MR3BYSTZWb0Y4?= =?utf-8?B?U3ZwbUdrWkRVaENTc2YwamFUcXVSY3hlbXprS0xtQ3h2ckFFanl1SndOSWJG?= =?utf-8?B?R1ZtalprRndvbUFGcnFvUUo1RlpXcDVrRjRRMXU0b2Y4cy9PcCtzeVZXT09C?= =?utf-8?B?RG83eE8xeHhpdTBoN0Y3UVlIOW1CWkdVaXJETDNnTmo5QVh3bVNFUE9seGxq?= =?utf-8?B?WEpwQWxONEVKMW9ZVUsrYmZMenRDcDVyR092cmN3ckwzUEZKSkRvcUJjVnlP?= =?utf-8?B?dEpOM0g5cUpOYUNkRzhXK09NTlg0ZW54c1QzbW9UUmR0NStCNjVNUjZJT3Ur?= =?utf-8?B?cDBURGRWTTcrVlVIM1cvVmRlbDhhVGlQMkduNjlTSHd6d213emd0TUZXb0ht?= =?utf-8?B?UmJremkxK3R3Y29aUVBoMkFsL0FHdVdPenlXYUh1V1ZpZnpmS05COUUrdEhu?= =?utf-8?B?dk9nVDAzY1FKbkJHSWhBUHJGNE81dy9hNjUxUjlodFlBT3NFTWRGcDNjejJP?= =?utf-8?B?dFlvYTdwNDMvN2JJakhuZjJpZ1Awa0J2TzlRSzZPWGJmV2M4dGZBTitZM2lY?= =?utf-8?B?YWFnbjJsYTZuQVhtN1plY3h4Z2NBVThmdUZmTFdnWmF1QjlQQkx5Q3ZITk1X?= =?utf-8?Q?dmGN4iXiaCgyJSFopc9mCbecx?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8c85d9ff-4a18-44ee-ddd4-08daf248e974 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2023 13:53:39.8257 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pySXsT2j8WdRsShPXwI5gWWgoI8ou9SEWUpX+atwyw1v+TD11+9ORZk1JKzilV9HlVRT46TjTt8K+gfQ8hE+0Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7183 On 07.01.2023 23:07, Demi Marie Obenour wrote: > Setting cacheability flags that are not ones specified by Xen is a bug > in the guest. By default, return -EINVAL if a guests attempts to do > this. The invalid-cacheability= Xen command-line flag allows the > administrator to allow such attempts or to produce Like in v6: Unfinished sentence? > Suggested-by: Andrew Cooper > Signed-off-by: Demi Marie Obenour > --- > Changes since v6: > - Make invalid-cacheability= a subflag of pv=. While you did this, you've retained the standalone option, and documentation also continues to describe that one instead of the new sub-option. You will then also want to move where invalid_cacheability is defined, I think. > @@ -1343,7 +1392,9 @@ static int promote_l1_table(struct page_info *page) > } > else > { > - switch ( ret = get_page_from_l1e(pl1e[i], d, d) ) > + l1_pgentry_t l1e = pl1e[i]; > + > + switch ( ret = get_page_from_l1e(l1e, d, d) ) > { > default: > goto fail; Stale (and now pointless) change? > --- a/xen/arch/x86/pv/domain.c > +++ b/xen/arch/x86/pv/domain.c > @@ -28,9 +28,21 @@ static int __init cf_check parse_pv(const char *s) > do { > ss = strchr(s, ','); > if ( !ss ) > - ss = strchr(s, '\0'); > - > - if ( (val = parse_boolean("32", s, ss)) >= 0 ) > + ss += strlen(s); > + if ( !strncmp("invalid-cacheability=", s, > + sizeof("invalid-cacheability=") - 1) ) > + { > + const char *p = s + (sizeof("invalid-cacheability=") - 1); > + if (ss - p == 5 && !memcmp(p, "allow", 5)) Nit: Blank line please between declaration(s) and statement(s). Jan From xen-devel-bounces@lists.xenproject.org Mon Jan 09 14:07:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 14:07:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473672.734401 (Exim 4.92) (envelope-from ) id 1pEsoN-0003xj-Nc; Mon, 09 Jan 2023 14:07:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473672.734401; Mon, 09 Jan 2023 14:07:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEsoN-0003xc-Ji; Mon, 09 Jan 2023 14:07:39 +0000 Received: by outflank-mailman (input) for mailman id 473672; Mon, 09 Jan 2023 14:07:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEsoL-0003xW-OD for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 14:07:37 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2076.outbound.protection.outlook.com [40.107.20.76]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f754497c-9026-11ed-b8d0-410ff93cb8f0; Mon, 09 Jan 2023 15:07:35 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8235.eurprd04.prod.outlook.com (2603:10a6:10:243::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Mon, 9 Jan 2023 14:07:32 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5986.018; Mon, 9 Jan 2023 14:07:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f754497c-9026-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fwZI4rFMY0PVzOQo1uqO3xH05hO5Vqpk+NbIUBmOHcpU2wZ+4Ix4O7SN8/FcXKRpYT8R7WaaabmIC0ryx0IphKy6aJCFWNMUVXyq/rHWQ6Je3qD8SZub2LwgX3BWhen93ZEDsqmYvfcBRtUMoDPp5/j8DNTCw28ViGCbvqIbmoOIEdzy+9wgX4PzXfl19SJ4uYxPHiqpNNMcsIVV4R2YXjm48lN6hdqlXX1NoaVT4MULf7WNiqupEf3YNbXu445PBVuDYgonM9QxJcKeHWkbC8mfJ+Tk/o7XF3EXClUFxnNN/Lwwe/WKuhIlulXLWcWot/MZl6HzFBxz6D3Hh8+u4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8FY854m4Y8kLI3rt7W99QdLxDdx4/YRm4M4xbOMZp9M=; b=I7SUOeEVyHhhug+Dn//bs413ewH+qaiF5sFXU9Q+ikwMfQGvSlSmQcJjQEwcoo07xxH57B/+TGnIBVuvFTZYUA2G3xU+bU/G3LxPGDOVg10i/qwHkZAJLY1Vl3rp1/Y2TV/dF1Ozqbt9dEf0KgsMPHRqkU1sHQxdYgAwy+vcoQ9oByTIo5FnCC+XhNtiHt+fVssP0oe/d4KpioeE/g8pXf5OSQlFyTGPdrEbf8qiKROQ2pWZXsUHagBzJK5bI/LJZTmQ7uWTadJNpzK51Rq6mslz5b2eH1gkubKZ1yAICZZLWCUu2+GuIaamv7FzuGUBGFbtgCscV/BV9qwKKNlv4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8FY854m4Y8kLI3rt7W99QdLxDdx4/YRm4M4xbOMZp9M=; b=oHy/nRgnCxtvvTl8nKA1fMyHpToYIw2HysRNKHPUvdDRRr5crUx6RAeXsyDSWz3wpeebwiiteAqj0IyptCQAap9Y9ZZ4D7No9LlZ7Zoa5fJ1VBwj6gVGE7jmdwcYJoEnoMKRE9Sv55XMbJljWxWjE9V2g+1UHqr/D8FAbHtKpZs++R/nwzcgfkvE0QaDzsva+iOMUDXhWBMFKxwo56QmnNRUj9gpMyyH6xE2qJrUBgYNFJP2sthpnCqAX3Hcda54x2CknEyIBigxWqXDOmbqqW4VapBVrmTufYtsNJ8+9o7++KRVinMT6GACmLm6bSXKY2BWall/Ho9oavT0isZA1A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3792c32f-06a9-4fd0-9d7a-c02bb38aa739@suse.com> Date: Mon, 9 Jan 2023 15:07:29 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v7 3/4] x86/mm: make code robust to future PAT changes Content-Language: en-US To: Demi Marie Obenour Cc: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Tim Deegan , xen-devel@lists.xenproject.org References: <89201c66b0261b2f5ee83e7672830317fde21dfa.1673123823.git.demi@invisiblethingslab.com> From: Jan Beulich In-Reply-To: <89201c66b0261b2f5ee83e7672830317fde21dfa.1673123823.git.demi@invisiblethingslab.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0135.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8235:EE_ X-MS-Office365-Filtering-Correlation-Id: ebd233b5-24d3-4105-fc07-08daf24ad974 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: opTRco/sh5p1kYxbYY7mi7Wz/25hcCsYKuln6b6NAdoTOL5J6H0bnH8LQynDLoKc8kVcCeGLn/PvzJ4pq4pUkhti80ZygQ7LtIKesJeju8oraFMFv2i7X3dIbplQh5mD/yGQuUVuVqY2mQU5sDy/uU16u1wtExdnBi9tZaEYkN7spBA+GNC6gGF3va3vcrMC5gtRwOFI5WTCjfKQGjRau6n/fy5iPzJnUorbowMDOA6tXGgwATN589HJD/5KLLhgg92gvk10U2PvPzLa3fpi+xefwYIRWDchVl5gY/Qq5/MmT+HrBPc0LnP+OZMczx+RxNrZV4wm/Qbmnv2Fl3fzDpapH2DnbZ/FHUJCUjFZavMHw9Y2pUNG5kn6ac2fr2HhUU8ehDhc2JKxYb2ddTZdqChiccUIjlC9XnbXuNDRJGkhChzxB8b2xbhtCPQ7i9cPn+wTlxM/4cC6MwrwxUXj1jACpTbZ/m8JuORoyjqV0bGqZxXuph0Aeh+Hzkhr2sUx4kFwGVBkO2VDsnjFO023/ftDIkFPn/EkOQsQEa4RubjyutMdkvfHGR7tiFT32ZKKZVj00ntOfGLs06SghOK+tYX5COr0ayTYKPdhnzwV3s5QJCM+j8UrolEjAxoZ5SpgCbUYeF7Gf0Wy39OuAwJX2F8wJ4h/kI2Z0PsPITDWm3vTVx5Lz1pKvxe+8sEBoFZ629VwsqBqVQRdOjUXiaB+mOhAURkR2s/zZEejFYYbVlU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(366004)(346002)(136003)(39850400004)(376002)(451199015)(36756003)(53546011)(186003)(8936002)(26005)(6506007)(6512007)(2616005)(54906003)(5660300002)(66946007)(7416002)(66476007)(66556008)(6916009)(4326008)(316002)(86362001)(31696002)(38100700002)(478600001)(41300700001)(6486002)(31686004)(8676002)(2906002)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?THRvVE5tREtpZVprOW85N3FXUSs4N2t5OTB5YWlsSi9QSk5Sc3d0RDFUeW5C?= =?utf-8?B?MjdyR3R0a2tOV2prMm1qZWh3aFE2TnZBTGE2cVUyRkE3WUhuZk9NeXpZc0pU?= =?utf-8?B?UlBuK041WCtKdUsvMnFWSWZ2eEpkbHdac1pjaXJvRGMxd1c5NXYrQW5FcWEv?= =?utf-8?B?LzlvTGVLZnkwdVpNeDZTQW5qUEhiNE53OWlqZ3VHSzBJQkdLcnMySXJtOW9n?= =?utf-8?B?TFVZZnJpZXNGSmF4Q3ljT1EwbVJXakVjNi9LcU9oV3FacGRLSThiY29VL0Zo?= =?utf-8?B?dkhwQU1SeHVCYVlDd04wZkZsSVFqNDNJNFRnem9RcW5rbFNLcUFQYnQrdEJP?= =?utf-8?B?S2tMQmxqWU5QTjVUYmI1MWpNN3h1TE1vUHIwUXBPNzA5ZE9kQjkzV3I0QU51?= =?utf-8?B?YVo2RmpZN0dYN1pIeWxMYm1Jd0JrOGN1TjVxUHVtSktRN3ZkU2ZjSThsdWY4?= =?utf-8?B?bjZJRDQ1aDVMdDJVN3ZVZXAwckl4cTFScXYyM1FNNTRiWXJvVDlFZXZmb0NH?= =?utf-8?B?MHpoanJ5N3pHRGxKOFgrejhmUTlnNDU2dFBnUWJzQ1pmeGxNWUE3MkFiNVZs?= =?utf-8?B?aGNTTHZ6ZXllZGpzU0UreGpjay8rdEVOSlRranBVLzR0OGdET3lYekcvQWFj?= =?utf-8?B?U3htaUFNOUlhYkFOUFBRMTFqN2RKcTJERkJMbDNzcHo1WDhBNnJlMWtlNXZO?= =?utf-8?B?cFNPUmppU3lrak9BalQyUWxITlRlVmd5NE4reWZpMW8yOUpsbDlSclA2aHh2?= =?utf-8?B?d3dvNUd2aTNjZGV1N1FuSFpzMTVUaEJid01YN2t1Yno4ZGJseVpseHFOazRH?= =?utf-8?B?bVg2U016bWJwRVFOS3Jrc0xPNGxPUmJsSzBFaFVKSnVONEQwdnpEZ0RhMk5K?= =?utf-8?B?RGcwZ2hROTI1QTN5V25ONmg3Z05ndE5qOHVlWlNwdFdRSHJJTDI4VmU1MGYr?= =?utf-8?B?S1ppYlZsU0d5U2Q1S3NCU2RBNTRURmVaSzQ0eGQ0OEEvSG54VmJYVEpPVDlS?= =?utf-8?B?dENvRlpYa2pENHB1aUlmQ1Q3dDdxZytPd2hZYmY4RzRVSmVrYWpoekFPRG9G?= =?utf-8?B?d0x6ZnV0cFVVaFhHT3hJbDd3MWpEY2xINk9VMlNEbFBrUmVoVXBQSU5TU2Zw?= =?utf-8?B?cUtRLzk0WkRyY0Q5YU9waXp4aSt6dDFFVmhDWFlrTkFQb29JL1I5aHNKNWEy?= =?utf-8?B?bTk5WnhOT2xKME5wbUE5TlhYYjh5aW9YenFUeGFqeDdWNDRDR2pTRjNjOVdw?= =?utf-8?B?R09WU3NiMlg4RmxtZE5BK2tqNmJNV3VZcmpqR0w2by9kVEdQeEVSRjBBdGk0?= =?utf-8?B?ZzgxWlhSRzBlb2h5bDZ6Q1hGSnhibXZaR0NLeEhVRlg2MytvUTkxQUxoOEN1?= =?utf-8?B?aG9ZVFRXWW9rZFVZM3h2d294OS9vUERyQkJKWGJocGwxSXorQU1yaGlIajg3?= =?utf-8?B?WTBUWXEvY2Z4dzZjcTdRUU1YbEdhbnZUMGQ2bFUxUUhtS1hJLzVSVm5lbndl?= =?utf-8?B?TlJkTDdhaTRCWnJCYmRwUzg1UXo1ZTBzbUlRYUtiaVZMT0Y5T1c1TWJUYTRn?= =?utf-8?B?RFRJOXV3RUo0S285WjI5WS9uR3BYTWt5QTNnZk1iL0NiclJiU0JXaWlSeW15?= =?utf-8?B?Mi9FdHJuazNscUIyaytYY0R4aVl1NXUyeUwwNHByQjJjWnhta2YyOWZtMmgr?= =?utf-8?B?WEZjV3dSamV0bFVVUXBCRFlzK1UzSi9weE4rUXFVUXpQSVdyNEFndmxTVjJw?= =?utf-8?B?RlIydjBWb1FvZ2g1MkkrZFZqOC9BeVB5RnhaZkQvcEFzSUlLK1JoS0JBclhi?= =?utf-8?B?R3JPWHNOVTc3dXQ1dzFuQTdiSWoxWjRtUjNvajl3SUx0VCtoNkxyOEEvOElG?= =?utf-8?B?bzI0a0ZMUXBTQis2Tjhwc0V3WVoyTmpRUWs0UDZBdXB4aUFoOEJQOWlTbTla?= =?utf-8?B?dFpXNjErMlI5bEMwZVRDTTBzYXQ3VVNWZVl4cUZzNi9CdDloNGd1aVlTTk9C?= =?utf-8?B?QmdPeTFNbGpQbnplQkVGNFpGUE1iZmFTbUFzYkc2RVNuYVZLYXZMWmN0WCtJ?= =?utf-8?B?aGR4ZUROQ2F1YWVpaVpXZ01OTjgwL1pwQkNaTnJMQWlCRHBmbm56QjdJUEs0?= =?utf-8?Q?J7/O5TLILTR9aphETHuwO5pUf?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ebd233b5-24d3-4105-fc07-08daf24ad974 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2023 14:07:31.8514 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /OmlMuPmaKVbOT8VyRAO7vE7SJB2ioGb8qpdTEjA8GIc7ngRT+ItY2cEGp5IK9SajLCoky7XMKUg45eMdPX+mg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8235 On 07.01.2023 23:07, Demi Marie Obenour wrote: > @@ -6412,6 +6414,100 @@ static void __init __maybe_unused build_assertions(void) > * using different PATs will not work. > */ > BUILD_BUG_ON(XEN_MSR_PAT != 0x050100070406ULL); > + > + /* > + * _PAGE_WB must be zero. Linux PV guests assume that _PAGE_WB will be > + * zero, and indeed Linux has a BUILD_BUG_ON validating that their version > + * of _PAGE_WB *is* zero. Furthermore, since _PAGE_WB is zero, it is quite > + * likely to be omitted from various parts of Xen, and indeed L1 PTE > + * validation code checks that ((l1f & PAGE_CACHE_ATTRs) == 0), not > + * ((l1f & PAGE_CACHE_ATTRs) == _PAGE_WB). > + */ > + BUILD_BUG_ON(_PAGE_WB); > + > + /* _PAGE_RSVD_1 must be less than _PAGE_RSVD_2 */ > + BUILD_BUG_ON(_PAGE_RSVD_1 >= _PAGE_RSVD_2); > + > +#define PAT_ENTRY(v) \ > + (BUILD_BUG_ON_ZERO(((v) < 0) || ((v) > 7)) + \ > + (0xFF & (XEN_MSR_PAT >> (8 * (v))))) > + > + /* Validate at compile-time that v is a valid value for a PAT entry */ > +#define CHECK_PAT_ENTRY_VALUE(v) \ > + BUILD_BUG_ON((v) > X86_NUM_MT || (v) == X86_MT_RSVD_2 || \ > + (v) == X86_MT_RSVD_3) > + > + /* Validate at compile-time that PAT entry v is valid */ > +#define CHECK_PAT_ENTRY(v) CHECK_PAT_ENTRY_VALUE(PAT_ENTRY(v)) > + > + /* > + * If one of these trips, the corresponding entry in XEN_MSR_PAT is invalid. > + * This would cause Xen to crash (with #GP) at startup. > + */ > + CHECK_PAT_ENTRY(0); > + CHECK_PAT_ENTRY(1); > + CHECK_PAT_ENTRY(2); > + CHECK_PAT_ENTRY(3); > + CHECK_PAT_ENTRY(4); > + CHECK_PAT_ENTRY(5); > + CHECK_PAT_ENTRY(6); > + CHECK_PAT_ENTRY(7); > + > + /* Macro version of pte_flags_to_cacheattr(), for use in BUILD_BUG_ON()s */ > +#define PTE_FLAGS_TO_CACHEATTR(pte_value) \ > + /* Check that the _PAGE_* macros only use bits from PAGE_CACHE_ATTRS */ \ > + (BUILD_BUG_ON_ZERO(((pte_value) & PAGE_CACHE_ATTRS) != (pte_value)) | \ Slightly cheaper as BUILD_BUG_ON_ZERO((pte_value) & ~PAGE_CACHE_ATTRS)? > + (((pte_value) & _PAGE_PAT) >> 5) | \ > + (((pte_value) & (_PAGE_PCD | _PAGE_PWT)) >> 3)) > + > + CHECK_PAT_ENTRY(PTE_FLAGS_TO_CACHEATTR(_PAGE_RSVD_1)); > + CHECK_PAT_ENTRY(PTE_FLAGS_TO_CACHEATTR(_PAGE_RSVD_2)); What do these two check that the 8 instances above don't already check? > +#define PAT_ENTRY_FROM_FLAGS(x) PAT_ENTRY(PTE_FLAGS_TO_CACHEATTR(x)) > + > + /* Validate at compile time that X does not duplicate a smaller PAT entry */ > +#define CHECK_DUPLICATE_ENTRY(x, y) \ > + BUILD_BUG_ON((x) >= (y) && \ > + (PAT_ENTRY_FROM_FLAGS(x) == PAT_ENTRY_FROM_FLAGS(y))) Imo nothing says that the reserved entries come last. I'm therefore not convinced of the usefulness of the two uses of this macro. > + /* Check that a PAT-related _PAGE_* macro is correct */ > +#define CHECK_PAGE_VALUE(page_value) do { \ > + /* Check that the _PAGE_* macros only use bits from PAGE_CACHE_ATTRS */ \ > + BUILD_BUG_ON(((_PAGE_ ## page_value) & PAGE_CACHE_ATTRS) != \ > + (_PAGE_ ## page_value)); \ > + /* Check that the _PAGE_* are consistent with XEN_MSR_PAT */ \ > + BUILD_BUG_ON(PAT_ENTRY(PTE_FLAGS_TO_CACHEATTR(_PAGE_ ## page_value)) != \ > + (X86_MT_ ## page_value)); \ > + case _PAGE_ ## page_value:; /* ensure no duplicate values */ \ Wouldn't this better come first in the macro? The semicolon looks unnecessary in any event. > + /* \ > + * Check that the _PAGE_* entries do not duplicate a smaller reserved \ > + * entry. \ > + */ \ > + CHECK_DUPLICATE_ENTRY(_PAGE_ ## page_value, _PAGE_RSVD_1); \ > + CHECK_DUPLICATE_ENTRY(_PAGE_ ## page_value, _PAGE_RSVD_2); \ > + CHECK_PAT_ENTRY(PTE_FLAGS_TO_CACHEATTR(_PAGE_ ## page_value)); \ > +} while ( false ) > + > + /* > + * If one of these trips, the corresponding _PAGE_* macro is inconsistent > + * with XEN_MSR_PAT. This would cause Xen to use incorrect cacheability > + * flags, with results that are unknown and possibly harmful. > + */ > + switch (0) { Nit: Style. > + CHECK_PAGE_VALUE(WT); > + CHECK_PAGE_VALUE(WB); > + CHECK_PAGE_VALUE(WC); > + CHECK_PAGE_VALUE(UC); > + CHECK_PAGE_VALUE(UCM); > + CHECK_PAGE_VALUE(WP); All of these are lacking "break" and hence are liable to trigger static checker warnings. > + case _PAGE_RSVD_1: > + case _PAGE_RSVD_2: > + break; > + } > +#undef CHECK_PAT_ENTRY > +#undef CHECK_PAT_ENTRY_VALUE > +#undef CHECK_PAGE_VALUE > +#undef PAGE_FLAGS_TO_CACHEATTR PTE_FLAGS_TO_CACHEATTR? > +#undef PAT_ENTRY You also #define more than these 5 macros now (but as per above e.g. CHECK_DUPLICATE_ENTRY() may go away again). Jan From xen-devel-bounces@lists.xenproject.org Mon Jan 09 14:26:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 14:26:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473680.734412 (Exim 4.92) (envelope-from ) id 1pEt6a-0006O6-81; Mon, 09 Jan 2023 14:26:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473680.734412; Mon, 09 Jan 2023 14:26:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEt6a-0006Nz-5H; Mon, 09 Jan 2023 14:26:28 +0000 Received: by outflank-mailman (input) for mailman id 473680; Mon, 09 Jan 2023 14:26:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEt6Y-0006Nn-AI for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 14:26:26 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on2081.outbound.protection.outlook.com [40.107.14.81]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 97c89f7d-9029-11ed-91b6-6bf2151ebd3b; Mon, 09 Jan 2023 15:26:23 +0100 (CET) Received: from AS9PR01CA0047.eurprd01.prod.exchangelabs.com (2603:10a6:20b:542::28) by DU0PR08MB9437.eurprd08.prod.outlook.com (2603:10a6:10:42f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Mon, 9 Jan 2023 14:26:21 +0000 Received: from VI1EUR03FT021.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:542:cafe::3d) by AS9PR01CA0047.outlook.office365.com (2603:10a6:20b:542::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Mon, 9 Jan 2023 14:26:21 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT021.mail.protection.outlook.com (100.127.144.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Mon, 9 Jan 2023 14:26:19 +0000 Received: ("Tessian outbound b1d3ffe56e73:v132"); Mon, 09 Jan 2023 14:26:19 +0000 Received: from 1329edeb07ec.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 243FDD70-51F1-4DFF-9D52-C59224BC8222.1; Mon, 09 Jan 2023 14:26:13 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1329edeb07ec.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 09 Jan 2023 14:26:13 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by DBBPR08MB6076.eurprd08.prod.outlook.com (2603:10a6:10:1f5::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Mon, 9 Jan 2023 14:26:09 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::b14f:1c13:afa:4eda]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::b14f:1c13:afa:4eda%3]) with mapi id 15.20.5986.018; Mon, 9 Jan 2023 14:26:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 97c89f7d-9029-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+3bVSUkzFmxk0AlM4PzpGnlkh7s26gh58imKCbjKBkM=; b=XBAZmsaNGUzdJRaripfs2JpoBlpGYEgzKON0kvYNJd6s8JqdHyLO5yBAt5YONOdMz6BizjidXzoZlYbBOgEDGHQseGSwCanPIxWe8oKeV2lP2GLy10Rw/zSwKPRsaFtASzVwQA66rT3lb/Xdfn4ErB+GU4VV2Vd9wU13DSQW/SE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 3294e52b668071c5 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aotWyTUWM/zHOa6IMaZd0fnPscRN+QscPodxHs4dvVDd0IbSAbn2IEOd/vmx57ao6j2p4xFoV5PxR1bthqt3GLYKTXW8WWfUHUkIKDI5Rzb5bsyrY+uxE68CAGQDf7vEXObaiVd1230m9KiuVPuXXST5vcypkz/yLMUL0/jOmSx8S/hPDYGMdFLnRb8soKjiN72Dq71xn0FfD+9/x+wLI5IZFzufwzD+VYsUE/pioJMn8gu3rSQiqJMaScQI00tnCoRY5YAjxu1SpIub00r1a9PKyCBvD9caOrdB9eDJ9k+Szx7rYip9Qo7R+O4XEJXoZ9t04Fo4LXNLIh+ZkpBtcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+3bVSUkzFmxk0AlM4PzpGnlkh7s26gh58imKCbjKBkM=; b=HoYNfgN6Xm0gRCjf6z8/8OwuAVnty+ouRCY+F1B3hiFL+Lryh5v6hXKBrXetd7qQq1ZNnj0/s4otdoDC8K0EJOrO5fpjrtf8v3FVfornm/72uTW69So7DnZyFZepB9Aat+zFkdtcq8tX8793pDJ4/6WSCpANfhH+533yIqqZcmFeps/57kFK2o4i1IsXFr1ewlR5r2APcI3i7qHGgkVUTdITs5a2r08kH+Re8y0rbf7VOZxUuiLMeO2GvNUhE9/EXU2ZryUS/xdj2CTDCCij5lPpPkoJtHBM2m1uO1I39gThhHvssfyXlpfrIftEf8A+7G+SK9x/MNQ1HH/py3QcxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+3bVSUkzFmxk0AlM4PzpGnlkh7s26gh58imKCbjKBkM=; b=XBAZmsaNGUzdJRaripfs2JpoBlpGYEgzKON0kvYNJd6s8JqdHyLO5yBAt5YONOdMz6BizjidXzoZlYbBOgEDGHQseGSwCanPIxWe8oKeV2lP2GLy10Rw/zSwKPRsaFtASzVwQA66rT3lb/Xdfn4ErB+GU4VV2Vd9wU13DSQW/SE= From: Luca Fancellu To: Jan Beulich , Michal Orzel CC: Wei Chen , Andrew Cooper , Xen-devel , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [PATCH 1/2] xen/cppcheck: sort alphabetically cppcheck report entries Thread-Topic: [PATCH 1/2] xen/cppcheck: sort alphabetically cppcheck report entries Thread-Index: AQHZIbt/3GyhUKyUOka+bjXcc10z+K6V88UAgAAHeACAAC3gAA== Date: Mon, 9 Jan 2023 14:26:09 +0000 Message-ID: References: <20230106104108.14740-1-luca.fancellu@arm.com> <20230106104108.14740-2-luca.fancellu@arm.com> <6373383d-d6d3-3d92-b09e-6434c5b5d15b@amd.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.300.101.1.3) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|DBBPR08MB6076:EE_|VI1EUR03FT021:EE_|DU0PR08MB9437:EE_ X-MS-Office365-Filtering-Correlation-Id: 1eff4c37-d097-428a-2188-08daf24d7a00 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: cElD3GHZC5ZUYu77aj+PjyZLdF5pJSwvJtyNowvL5kcBfMXgB95eD64rICOcKgpP5OSlDvPWQgrcNUz8M9kGoYlGtKDroyuDCIlM0w71K8p6NB9wYAzCgAXw4zffvye62rRrHXVM6t8rXrv6nzrxS/S5E6SNBnbcPk+Bkv4m+9RtwFkK4O2ECB/HL3DxsDTFGUDfxZojhaY1FuocQP6cDaNuYOYXLQEPOMv6L7UA9nvuBrni2IGKOAn+0Ku417AkcKLB5kfu5BeRX73/uxolGK8FG9ltOGdyvW+Q5ejSZ3FDoPFuOnrRRVxm6IJRhNpKydzsnUkou8vXVscPIpbmyxwWpuQWJ/dP0ZPFTt/K1VbgGinqrE9gYgIfJ9WYJGj4pNb3T/sq0Xn2ES00oAoNPVY5Yvp5yzYD8uzZ18jU+7t8Qj8A+c5VpGznfEOB1bE1tM9AwDFOTttUiJ8fE7TtyfFEmyeMyK7LVzQ6gSU8BTlC/HuHqI/MhpYq8iXaOLhbqi3icxR5RYxbjHhGYN3px7TniKAgRUAvP2Ul8RvB/YVmEOFwu16hQJRmcbD2Blt/HkHaju0GvED4vJOmyf8iwJhHwaRnN+twmmoa8cTfqMdavU5SG6fRRTpFMP47G9UieLly+GAsrCckvar34MHhi/YgWjrSxvHWEj2ywGYrrYuk8BMigg3DSDYEHtFkCgbRz5RhXdNiD8hS7+eO9CQ/UpusFNqOITUX2VadsmsYoa4= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(346002)(366004)(376002)(39860400002)(451199015)(71200400001)(110136005)(54906003)(86362001)(316002)(8936002)(2616005)(6486002)(2906002)(38100700002)(478600001)(66476007)(66946007)(76116006)(64756008)(66446008)(53546011)(41300700001)(66556008)(26005)(186003)(91956017)(6512007)(4326008)(38070700005)(8676002)(6506007)(33656002)(36756003)(122000001)(5660300002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <7D68142F30AF674399477BECF5595652@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6076 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT021.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: de4f6c6a-1dc0-4268-056f-08daf24d73e4 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: V3Y+qsdXRU5chpQ18VzViR+ZqZDkoJEZ9qvqLJHA5sFtlRDLhcqpcslDzHnR/+SYVdr2Tj9eXGSZQkq5rYj+nm93OeT6LNuPdj/9ovi/fYlB+u58KK8kmcOVtC0C16OYHTOPdz5AffEYgqNUI0oiOnFzXxpQn2C2zUVMBbaipaBBrXCxihu0k3VzwQt3G9AONhFht2zgzxUYGlNxIUGOZBg9QiYIEzG8LuHQKInMeSfpGTlPrHDlbG2LGUgpGi6fjnumTculJxPw7p0/3sqcmUAEWI4M/IjeNMbpKsyEBEwbQHPbPby0r+hNStDtNy6toBz0OvQkeTh8LfN0Y1csfAgMQjXENUfx57QAyXmBXjr4HN2UhRMOiUPg9slCidGMj2TDVsv5f+D02rDMItsFgSTmTg0vtVLM2QkUl3ZQAEpsDXjK1euLhnbnHmUh9E0yAYdZoRZbbVUct3GzB4cBg9aAQrknROg6N1trY2x1G+Ou5j+ErvjJR1TiPkpolrPcyYA/M0D+6ZCvMBZ8Csi7y6XOjME0dqMBZOfbUXzDgy5wZJcQCE7QbNkaqc5nKRiqnsZE/VfHEIL8POmEZT2L1C2V9XSLB0rWaPLLgoE3CxfGdX07oM2bBMAPo4fH96ENqE4iStLxwNkuJQfcA69We2s7ezM7nqia/kqmwETABqMtsymfWoOdwE60ugHr3LVODOglU+kifCesGmhP4rW0og== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(136003)(396003)(376002)(451199015)(40470700004)(46966006)(36840700001)(40480700001)(36756003)(33656002)(86362001)(40460700003)(6486002)(54906003)(110136005)(316002)(6506007)(5660300002)(478600001)(2906002)(4326008)(70586007)(8676002)(70206006)(41300700001)(8936002)(36860700001)(82740400003)(356005)(81166007)(2616005)(336012)(26005)(53546011)(6512007)(186003)(82310400005)(47076005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2023 14:26:19.8641 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1eff4c37-d097-428a-2188-08daf24d7a00 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT021.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9437 > On 9 Jan 2023, at 11:41, Jan Beulich wrote: >=20 > On 09.01.2023 12:15, Michal Orzel wrote: >> On 06/01/2023 11:41, Luca Fancellu wrote: >>> Sort alphabetically cppcheck report entries when producing the text >>> report, this will help comparing different reports and will group >>> together findings from the same file. >>>=20 >>> Signed-off-by: Luca Fancellu >>> --- >>> xen/scripts/xen_analysis/cppcheck_report_utils.py | 2 ++ >>> 1 file changed, 2 insertions(+) >>>=20 >>> diff --git a/xen/scripts/xen_analysis/cppcheck_report_utils.py b/xen/sc= ripts/xen_analysis/cppcheck_report_utils.py >>> index 02440aefdfec..f02166ed9d19 100644 >>> --- a/xen/scripts/xen_analysis/cppcheck_report_utils.py >>> +++ b/xen/scripts/xen_analysis/cppcheck_report_utils.py >>> @@ -104,6 +104,8 @@ def cppcheck_merge_txt_fragments(fragments_list, ou= t_txt_file, strip_paths): >>> for path in strip_paths: >>> text_report_content[i] =3D text_report_content[i].r= eplace( >>> path + = "/", "") >>> + # sort alphabetically the entries >>> + text_report_content.sort() >>> # Write the final text report >>> outfile.writelines(text_report_content) >>> except OSError as e: >>> -- >>> 2.17.1 >>>=20 >>>=20 >>=20 Hi Michal, Jan, >> Having the report sorted is certainly a good idea. I am just thinking wh= ether it should be done >> per file or per finding (e.g. rule). When fixing MISRA issues, best appr= oach is to try to fix all >> the issues for a given rule (i.e. a series fixing one rule) rather than = all the issues in a file >> from different rules. Having a report sorted per finding would make this= process easier. We could >> add a custom key to sort function to take the second element (after spli= tting with ':' separator) >> which is the name of the finding to achieve this goal. Let me know your = thoughts. >=20 > +1 - sorting by file name wants to be the 2nd sorting criteria, i.e. only= among > all instances of the same finding. Yes both suggestions make sense to me. >=20 > Jan From xen-devel-bounces@lists.xenproject.org Mon Jan 09 14:58:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 14:58:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473717.734440 (Exim 4.92) (envelope-from ) id 1pEtay-0002Vj-8Z; Mon, 09 Jan 2023 14:57:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473717.734440; Mon, 09 Jan 2023 14:57:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEtay-0002Vc-5M; Mon, 09 Jan 2023 14:57:52 +0000 Received: by outflank-mailman (input) for mailman id 473717; Mon, 09 Jan 2023 14:57:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEtaw-0002VW-8M for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 14:57:50 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f9c29b50-902d-11ed-91b6-6bf2151ebd3b; Mon, 09 Jan 2023 15:57:47 +0100 (CET) Received: from mail-dm6nam12lp2170.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.170]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 Jan 2023 09:57:44 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by PH0PR03MB6979.namprd03.prod.outlook.com (2603:10b6:510:169::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Mon, 9 Jan 2023 14:57:42 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5986.018; Mon, 9 Jan 2023 14:57:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f9c29b50-902d-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1673276268; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=S/j8qZxd5fo4q8BxZa+uetjPoTsTEamnOrI9iHm6nnQ=; b=UCCgfsguBmdHqYKgEbvEBvcmkg6rqORHXlvhhjVH2COFcKOfnzlJ2OLD NMZH6VXnixvHiZYN2zvP2pchOgXG+uSroGz+RcYWMtdv2b+HC0JPGDJYD xCtHSfSVjVvsrujCt+AqVpbq6KQ+wSO5zI2LbD1oHCJgz3VdCLpmig8+A 0=; X-IronPort-RemoteIP: 104.47.59.170 X-IronPort-MID: 91806294 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:NQwJ/6zk0Rh5+842AX96t+cVxyrEfRIJ4+MujC+fZmUNrF6WrkUAz 2QdCG/Vb/mMZ2HxfN4nOtiwpxxVsJfXnIVkSQc5+SAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTbaeYUidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+U0HUMja4mtC5QRnPaET5zcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KUJ/2 tYgLgEjVCGaxKGTyYvjeONchP12eaEHPKtH0p1h5RfwKK98BLzmHeDN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvjmVlVMpuFTuGIO9ltiibMNZhEuH4 EnB+Hz0GEoyP92D0zuVtHmrg4cjmAuqAdJKSufpqpaGhnWi1HMCCEAsD2G9/6bk1UGCacllC BILr39GQa8asRbDosPGdx+yrWOAvxUcc8FNCOB84waIooLL5y6JC25CSSROAPQ2uclzSTE02 1uhm9LyGScpoLCTUWia9LqfsXW1Iyd9EIMZTSoNTA9A79y9pog210jLVow6T/bzicDpEzbtx TzMtDI5m7gYkc8M0eO84EzDhDWv4JPOS2bZ+znqY45s1SshDKbNWmBiwQKzASpoRGpBcmS8g Q== IronPort-HdrOrdr: A9a23:KROsfaioaJy/LUz2+WpEwtMK8XBQX6F13DAbv31ZSRFFG/FwWf re+MjztCWE/Ar5PUtK9+xoV5PhfZqiz+8L3WB8B9aftWrdyRmVxf9ZnOnfKlTbckWVygc379 YCT0ERMqyUMbBw5fyKnjVRe7wbrOVum8qT6ts3AB1WID1CWuVYy0NcNy7eK0txQWB9dO8E/F j33Ls3m9JlE05nHfhSwxM+Lpj+Tqbw5fXbSC9DPQcj9A6NyRuw8dfBYmCl9yZbaSpL3bAhtU PYkwn1j5/Tz82T+1vnzmrO6JYTv9PkxrJ4daqxo/lQECzolgGrIKJ+XLGY1QpF2d2H2RIRid zRpBVlBeRfgkmhBV2dkF/Wwgz91zRr0XP41lOCpnPmraXCNUgHIvsEv5tdbhzar3Utp8t91q Uj5RPli6Zq X-IronPort-AV: E=Sophos;i="5.96,311,1665460800"; d="scan'208";a="91806294" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gasRM56Dn463+ByYL/Vj063gtgAzJpLOiWJoN0xc46gh4vrXbzp9TlEdeODii+IfeKg9jx/oDYQzCNtfUdujH1Z06LzwAMnMJIdFQnZynWbrTOQWm4s3Wy+77gA7ljObke85SN9uhIOIr9qO7W1PH0Jpa/51P2ntygVKHYFPTF5RXHtkYAA/iVKVedqfSjg62NuktuXZDZx/k5/oKOs5bvTu7zY19v7iX8cm02yGCHH43OowsOEEEgWnWuoFhJWZtyxWMAgy+UWgObH/HkVSXieTg6r6u1sjKTco4PKR1GjL1oXpisGMdd1AQyqiUfhMhsbL3Kw8ExeegvwymCwsrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=S/j8qZxd5fo4q8BxZa+uetjPoTsTEamnOrI9iHm6nnQ=; b=hhIA679/9WQdXy3t0NRzNPefOX41VjmU/4EN+C6+vU0nQm7Aw1+Vn8R/g7OtvfqWoI7/Rf5gPj5Joe1F3+BDoGTV6hks3gk3cLVX/dF8e363vTM0TbFZf/JcZdbmUXtPMIoPlJWkEkvx+SKe8MlY988573G4WrwBM8kWkLXmE8CjyeftKOO0UJMzuxMwmCIHwjSKsmsoK0LdNu4z+qNsW7CLk99VV9swZnbmy92Ry+sEc2QTlNM87mvQjZj6jIIiZTi6hsgME4HVkyArl8UMnBqvL9LyB5m4uI03HFLi9hEKaLyuFmbkL27o3qJLsiLC7rC/fh3FEs69ueL+KYVWoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S/j8qZxd5fo4q8BxZa+uetjPoTsTEamnOrI9iHm6nnQ=; b=kT8IO3h1Lha2LZWZVEUl4toqdParjrKAoUioteVGF/S8K0pTmNgipEbvl1XL0sNzVL/Hpy0B6wNDPFvL8pRSre4zcptOzIb/K0wpK51VyCSCBHS+q2qjzhh5DW16yj1CvJp4ruKXNg8oO/qzDFiOSmGJpR/U/n2ErTAMxh5NtsA= From: Andrew Cooper To: Jan Beulich CC: Roger Pau Monne , Wei Liu , Xen-devel Subject: Re: [PATCH 2/6] x86/prot-key: Split PKRU infrastructure out of asm/processor.h Thread-Topic: [PATCH 2/6] x86/prot-key: Split PKRU infrastructure out of asm/processor.h Thread-Index: AQHX8mMDkacqheDKokOTUkSgUg9d2qw81wgAglu5ogA= Date: Mon, 9 Jan 2023 14:57:41 +0000 Message-ID: References: <20211216095421.12871-1-andrew.cooper3@citrix.com> <20211216095421.12871-3-andrew.cooper3@citrix.com> <427dc257-b318-de55-7126-0446264401f8@suse.com> In-Reply-To: <427dc257-b318-de55-7126-0446264401f8@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|PH0PR03MB6979:EE_ x-ms-office365-filtering-correlation-id: d3716add-b3f4-4468-d33f-08daf251db40 x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8ssqwxJ5AQJ2VNADvIqSqIlbQRirifDLafZuDCLD9aAusRdmVHzHaPpvdwiW9x1D2Cc9fHO8D2Cr+T4o2ZtbzltAxshLPpcpU4k9WV8Pl4MXTItT13QFB3F+mehp3HPBcNsG+DNy15nZLrbqS6TEFhn/XyjPzvI7p9WWpG4nUYny7KMW/cBj0F/0+8QOK8rHemqgWg5lZrVQDJH+u7ZIVb9E0vHIHIpj+B5S1s4vve1Pw4U5TGgr3XP8doTfUy9NehtwPqZAflgcXah3Nz4HX/WELgQwlsladW35m7rycPRdqRRMscMRR/9Zu2xpWlMw0/PCtWGDdJam+2eG7PyDKpIncb4igjFkvjBTITLctA5Mn8KQvGgmvo3RKoSQq4FI1PXX4N1xccyoOyYGt4+nspdzsbr0RjOWa40gI+Q3t4jEHyaMdomOKDOCjAQ/lMDY9a3+Q2XmK6VOsBMQPY0Zau7x9VrgWtZKNDD5WVG2alWhbjkO5c9oey7FzI+m55xorEl5sZhzAOdtjB84f0X0060aE8iqyg2FJrF1iG/wCX7dpq5f1nboAn/yf2640HLiMZBAX7lsa94sIVQFcLNtg2oRSin0ycdVAyDq+UXB046xZ+zo0CTa+CfB4HNcyXLwgsAsDiwASivrvFW7SY64Hmp6a8xMgx/kD7pwK/qpTCOcZfWl4a/ea4Ax6yloDgPb3MWubdo/znvf91K2HgCV+7riOCSM9n/JFJmcNzA3BQMWmouZZ1ALVlta4VD/ZxS323L+eJIKvup2eLFJhm21BSHZq1Wwg271hrXl28CAAC6BW9wPHgj4ELV56yyPRIJi x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(136003)(39860400002)(376002)(366004)(451199015)(41300700001)(2616005)(316002)(54906003)(8676002)(66446008)(36756003)(66556008)(4326008)(6916009)(64756008)(76116006)(66476007)(66946007)(91956017)(86362001)(31696002)(38070700005)(38100700002)(122000001)(82960400001)(8936002)(5660300002)(83380400001)(6506007)(2906002)(71200400001)(53546011)(31686004)(6486002)(186003)(26005)(6512007)(478600001)(2004002)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?M2pUL3ZFZ2NoaEtOSFZpNzFDcGxWMTRtNmJSakxtRXM2ajdGdTNLZDdNakZ5?= =?utf-8?B?UXpocnRsZkx2MjlrOUNuWEx3eVBCVFhuTjlZUzNLdWFLQjdERlNTUFdtaHVu?= =?utf-8?B?SDBrT2xRaTlFRm5SQ3phZE94cVJxWVY2UlNscVlCK0ZDUWRoNHZLRFBha3FT?= =?utf-8?B?WXJOaXlDMkJER1J5NVZtbG91WVN6aEZadHphY2Nmd0JVdWs1eXk3U09iRFI5?= =?utf-8?B?K2ZEZWpFQUczZzVUN1BOYlRNWVdOenNZQmh2WGpiTUlOc0lRRHU5RWhMWEtu?= =?utf-8?B?a3BtOXozUmlHbDd3aXNBdm5mVk51UE5QUWEzTXFKYmdPZ1AvdW9UeERkZkU4?= =?utf-8?B?SEFxdGN2TEMyZ01HcENjMHJ6ekdoR1U0dTRpMjhjNW52dEtlTjNLZVZwTzJY?= =?utf-8?B?UVgwdERYL1pnUHFzMzk3ODBTcnZzRlZUc3Z4ai9uZVBVR1Jjbkg0SHB6dmF5?= =?utf-8?B?K0ZlMGwzeHR0TVYxL2NBdU42QXVOTzBBbjVVT1htYzFnYkQ3ektrakI4S29X?= =?utf-8?B?d2RySElxdlhGdnNhSEp3Rk1ENHdwWklsVW8zN0VRYURhNEJ2SkhUMUVnOVpm?= =?utf-8?B?Y2hUMVVXT2ZEdFc4QTVHNFZYL0tlUVNTaWlRWUQwWmtSNlNKdFgrTnhpditp?= =?utf-8?B?Yy9kcTdlUVBTS1pLYnlUL25NT1F4SVV0RXNjTUxFSStpbHhSOW1tejFYeHhL?= =?utf-8?B?SFZGTjZadnFqNjZ0aUZKUXVpL1ZVV2tPd25GNXQ1SFNXRE1YbENaaDJuZXNw?= =?utf-8?B?NWVVMUxObUxpaUJueGFBZGZUcis2cXVKZG9UUVFMbmMzbFNtdDBMMis5eURZ?= =?utf-8?B?OXZPaFJiNno4dEhWQUMydjVXdWZzUUdXNG5pbnJpZ0QxQUg4WldlS21OdE1h?= =?utf-8?B?RDExRzF2ODlJcm95WFl3Vk5jaC9qWVNrUXpmRldWWmtMa1ZmKzUxbDJ3T1RT?= =?utf-8?B?Z09YRkZ5RVpNZTdLQUd1RnVLYlc5WVFEaE8xR1FVdityZWFNbXZCY0JpVEpl?= =?utf-8?B?VDN4dnhzcURQWWRScFdEL0lhN0FJcDFsRWkrVVBHYWdmcmJ5Z24rM1d1dkha?= =?utf-8?B?YlcvMWM1WnRrTjF4LzB5MytTUENlQkc1bTMwSFlNanNRUEprNlg2ZmY1T0dq?= =?utf-8?B?YXM3NW9RaTRYQjBqS3JFZ3Rza0kvRUFqUGFVZVczQldidDM5Vnl6Qk1BZmV2?= =?utf-8?B?anFyYjZ5UGNqTmZScEhiUEQrcDk4cnRCYTF6aXFMZnh5SUdERDUrY0pqS1Fz?= =?utf-8?B?bG5oU25zdWE1eHE3Q1RXSVlSc1R0eGIvRzNqeDZiMHZPcWpia0tSZDJMb0xN?= =?utf-8?B?ZnFrQUk3eTNLNzdFcjFqNlNuSnJsMDBWT290SUpMWkJYdnZ1M2Zxb0tib0t0?= =?utf-8?B?MTNWYjg1aUowQU1qWkJYK0F0N2FPZXV0TmRSU1pubGVDMklpQy9CT2RDQ1NL?= =?utf-8?B?ODB1V1B0Z05yWDZYNHJyNm43SVdXTVRwdGpBdW5DWHdVUm93emtQakFFOEJj?= =?utf-8?B?c3U3cWM1ZS82VElnT3E4YTZZZXBsTHlOZTZiUThTOXZMRXZSM3JFaUdpVUZH?= =?utf-8?B?RElSWXVEOEpUdktxTWdKb2p2TkJpVk5FdjUvNXRHdXk0bGxGZitRQW9ML1Rm?= =?utf-8?B?UCsvYWZRVEhlUTNkb1kxaDhYeG9EMDV4T2pyU08vZHdmOWY3WGNPcVp6QXFZ?= =?utf-8?B?Q1NKQ2V6SGtYNklYRzVFZFZTcnZtL0xJQkswV3dmZS8xQjhjQmF0RCtwYmkw?= =?utf-8?B?RzI1VEJPQ3BoQTVRMHhJcHkzZnNxT3JqRlZqMDRRQUxsSVRtRDhHc3oxUk5C?= =?utf-8?B?VmtteUpTNHR3ZUNXaVVlbVlwTGtYblpuRWV0VUhFRHNwTGFpdlpEdy9qK3NN?= =?utf-8?B?bDZXRmJ4R3BhZGYvYWQrV0FNWGpVV2E2dG94TE5Pd1Y1SUVNc3RzcmxOVkZi?= =?utf-8?B?eE9HWU1ZOHZnM2FJUDYwUzMrYS9EQXd2YjRDWFhXcFo4YldycnZqb3YwNGtX?= =?utf-8?B?c0FONmxBRjdVMitOK1JJcTVkdDh2SDQxWVJ5bmlSZzdSemNCWEdlMzhmRUNo?= =?utf-8?B?TC8zeFVYckJ1ZzVSd0RyWHYyeEo1T0k4b1Nnc3BqbTJtcFdpTGdhVDA0WGsw?= =?utf-8?Q?trkwh0Mqr2QRSJc5h6Sa+jb1E?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: TJOxBeYW+ga1xsVFbo8Wv7QaY7a0Z59cuNCFhF0dBlCA2cmUiJ0UYfVkNK1Did/tZprEDO3LYo45v4DNGjWMzhdv5nfLFHm18yiLxATNJ1++tEM3oirFtPcjzbv87QlW+HHncMIhvlzMtZA8VRhwQS4I560DFFRkYvYHlx2+vzi/VEZqZkJFLpnSFpFkUNhjJ4+fvFEZRWjeTIfttQ1VpsGifOYrSHH4EqIFmENd0lXmHfnQ3vcdLsQLQo8tPgmD3nKb5eGBYbM51nyQ0VXUk9DDEcx5eCG/HOD2YlW0MZ8aYf5/89P5u2UZVR8E9nPOp+klnM8kAePDvCdFbjZDeKP7RHnHl+gHEiFsQ3pnaX3Jaj6WpfvjPqeZ5SfaC5cMj5wP8g0okLDBXIBKdoUGwjip0eD2yYyOcIxzmCn1rJbDwbVGPKfjv/m5ksVFpTpgRg9MeuvNlHo1YBpXAKUVTzD3n2kEl/p0mLwR0TXZoO3oOWCwmtdcK9RKOVGcfRuS8N8U42oYNA5673FFecMLfQjV1SC7mX4qCKo6ozNRP+L6V5A6uXqCAYgZt2j3mui4c7KXyrKLho32PAFXUrDiM0ve8xg+GWQU9JK/22SAxSbnW+nkBDEFJ+svB1//CtsmWB26gNCRVD+prQ7hB72wpi+Xb45UQiIEffwCrXNfLgjinlxWSyn4g1UjzvH8MgIVcmk6zZXFgJF2MaISHGZu0kUNirKNiR5rlpHs9tFiVb0gUlZjKNTZnI7NdmBLLttrJi1H8UfuE65AaGXmbdYRLZPwjHR+ihUXlGVniZ4UXTabImpFlrqPG0jfY2ezmAdj X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d3716add-b3f4-4468-d33f-08daf251db40 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jan 2023 14:57:41.0609 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BSjV6k1FP4sfLF+3jePk5NkdaZy4o6di6NP/o6BO9f3wg3udcVeeX16R0ivZjsqr4J7Nwn4BqEqyQ+3S/LjhLrQI5YY/uUWdRAlyXGf8F4M= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6979 T24gMjEvMTIvMjAyMSAxMToyOCBhbSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDE2LjEyLjIw MjEgMTA6NTQsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiAtLS0gL2Rldi9udWxsDQo+PiArKysg Yi94ZW4vYXJjaC94ODYvaW5jbHVkZS9hc20vcHJvdC1rZXkuaA0KPj4gQEAgLTAsMCArMSw0NSBA QA0KPj4gKy8qKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqKioqKioNCj4+ICsgKiBhcmNoL3g4Ni9pbmNsdWRlL2Fz bS9zcGVjX2N0cmwuaA0KPj4gKyAqDQo+PiArICogVGhpcyBwcm9ncmFtIGlzIGZyZWUgc29mdHdh cmU7IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vciBtb2RpZnkNCj4+ICsgKiBpdCB1bmRl ciB0aGUgdGVybXMgb2YgdGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGFzIHB1Ymxpc2hl ZCBieQ0KPj4gKyAqIHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb247IGVpdGhlciB2ZXJzaW9u IDIgb2YgdGhlIExpY2Vuc2UsIG9yDQo+PiArICogKGF0IHlvdXIgb3B0aW9uKSBhbnkgbGF0ZXIg dmVyc2lvbi4NCj4+ICsgKg0KPj4gKyAqIFRoaXMgcHJvZ3JhbSBpcyBkaXN0cmlidXRlZCBpbiB0 aGUgaG9wZSB0aGF0IGl0IHdpbGwgYmUgdXNlZnVsLA0KPj4gKyAqIGJ1dCBXSVRIT1VUIEFOWSBX QVJSQU5UWTsgd2l0aG91dCBldmVuIHRoZSBpbXBsaWVkIHdhcnJhbnR5IG9mDQo+PiArICogTUVS Q0hBTlRBQklMSVRZIG9yIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFLiAgU2VlIHRo ZQ0KPj4gKyAqIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGZvciBtb3JlIGRldGFpbHMuDQo+ PiArICoNCj4+ICsgKiBZb3Ugc2hvdWxkIGhhdmUgcmVjZWl2ZWQgYSBjb3B5IG9mIHRoZSBHTlUg R2VuZXJhbCBQdWJsaWMgTGljZW5zZQ0KPj4gKyAqIGFsb25nIHdpdGggdGhpcyBwcm9ncmFtOyBJ ZiBub3QsIHNlZSA8aHR0cDovL3d3dy5nbnUub3JnL2xpY2Vuc2VzLz4uDQo+PiArICoNCj4+ICsg KiBDb3B5cmlnaHQgKGMpIDIwMjEgQ2l0cml4IFN5c3RlbXMgTHRkLg0KPj4gKyAqLw0KPj4gKyNp Zm5kZWYgQVNNX1BST1RfS0VZX0gNCj4+ICsjZGVmaW5lIEFTTV9QUk9UX0tFWV9IDQo+PiArDQo+ PiArI2luY2x1ZGUgPHhlbi90eXBlcy5oPg0KPj4gKw0KPj4gKyNkZWZpbmUgUEtFWV9BRCAxIC8q IEFjY2VzcyBEaXNhYmxlICovDQo+PiArI2RlZmluZSBQS0VZX1dEIDIgLyogV3JpdGUgRGlzYWJs ZSAqLw0KPj4gKw0KPj4gKyNkZWZpbmUgUEtFWV9XSURUSCAyIC8qIFR3byBiaXRzIHBlciBwcm90 ZWN0aW9uIGtleSAqLw0KPj4gKw0KPj4gK3N0YXRpYyBpbmxpbmUgdWludDMyX3QgcmRwa3J1KHZv aWQpDQo+PiArew0KPj4gKyAgICB1aW50MzJfdCBwa3J1Ow0KPiBJIGFncmVlIHRoaXMgd2FudHMg dG8gYmUgdWludDMyX3QgKGkuZS4gdW5saWtlIHRoZSBvcmlnaW5hbCBmdW5jdGlvbiksDQo+IGJ1 dCBJIGRvbid0IHNlZSB3aHkgdGhlIGZ1bmN0aW9uJ3MgcmV0dXJuIHR5cGUgbmVlZHMgdG8gYmUs IHRoZSBtb3JlDQo+IHRoYXQgdGhlIHNvbGUgY2FsbGVyIGFsc28gdXNlcyB1bnNpZ25lZCBpbnQg Zm9yIHRoZSB2YXJpYWJsZSB0byBzdG9yZQ0KPiB0aGUgcmVzdWx0IGluLg0KDQpUaGlzIGlzIHRo aW5uZXN0LXBvc3NpYmxlIHdyYXBwZXIgYXJvdW5kIGFuIGluc3RydWN0aW9uIHdoaWNoDQphcmNo aXRlY3R1cmFsbHkgcmV0dXJucyBleGFjdGx5IDMyIGJpdHMgb2YgZGF0YS4NCg0KSXQgaXMgbGl0 ZXJhbGx5IHRoZSBleGFtcGxlIHRoYXQgQ09ESU5HX1NUWUxFIHVzZXMgdG8gZGVtb25zdHJhdGUg d2hlbg0KZml4ZWQgd2lkdGggdHlwZXMgc2hvdWxkIGJlIHVzZWQuDQoNCj4+IC0tLSBhL3hlbi9h cmNoL3g4Ni9tbS9ndWVzdF93YWxrLmMNCj4+ICsrKyBiL3hlbi9hcmNoL3g4Ni9tbS9ndWVzdF93 YWxrLmMNCj4+IEBAIC0yNiw3ICsyNiw5IEBADQo+PiAgI2luY2x1ZGUgPHhlbi9wYWdpbmcuaD4N Cj4+ICAjaW5jbHVkZSA8eGVuL2RvbWFpbl9wYWdlLmg+DQo+PiAgI2luY2x1ZGUgPHhlbi9zY2hl ZC5oPg0KPj4gKw0KPj4gICNpbmNsdWRlIDxhc20vcGFnZS5oPg0KPj4gKyNpbmNsdWRlIDxhc20v cHJvdC1rZXkuaD4NCj4+ICAjaW5jbHVkZSA8YXNtL2d1ZXN0X3B0Lmg+DQo+PiAgI2luY2x1ZGUg PGFzbS9odm0vZW11bGF0ZS5oPg0KPj4gIA0KPj4gQEAgLTQxMywxMCArNDE1LDExIEBAIGd1ZXN0 X3dhbGtfdGFibGVzKGNvbnN0IHN0cnVjdCB2Y3B1ICp2LCBzdHJ1Y3QgcDJtX2RvbWFpbiAqcDJt LA0KPj4gICAgICAgICAgIGd1ZXN0X3BrdV9lbmFibGVkKHYpICkNCj4+ICAgICAgew0KPj4gICAg ICAgICAgdW5zaWduZWQgaW50IHBrZXkgPSBndWVzdF9sMWVfZ2V0X3BrZXkoZ3ctPmwxZSk7DQo+ PiAtICAgICAgICB1bnNpZ25lZCBpbnQgcGtydSA9IHJkcGtydSgpOw0KPj4gKyAgICAgICAgdW5z aWduZWQgaW50IHBrciA9IHJkcGtydSgpOw0KPj4gKyAgICAgICAgdW5zaWduZWQgaW50IHBrX2Fy ID0gcGtyID4+IChwa2V5ICogUEtFWV9XSURUSCk7DQo+IFRoaXMgaXMgY29ycmVjdCBvbmx5IGJl Y2F1c2UgYmVsb3cgeW91IG9ubHkgaW5zcGVjdCB0aGUgbG93IHR3byBiaXRzLg0KPiBTaW5jZSBJ IGRvbid0IHRoaW5rIG1hc2tpbmcgb2ZmIHRoZSB1cHBlciBiaXRzIGlzIHJlYWxseSB1c2VmdWwg aGVyZSwNCj4gSSdkIGxpa2UgdG8gc3VnZ2VzdCB0byBub3QgY2FsbCB0aGUgdmFyaWFibGUgInBr X2FyIi4gUGVyaGFwcw0KPiBzb21ldGhpbmcgYXMgZ2VuZXJpYyBhcyAidGVtcCI/DQoNClRoaXMg dmFyaWFibGUgYmVpbmcgbmFtZWQgcGtfYXIgKG9yIHRoZXJlYWJvdXRzKSBpcyB2ZXJ5IGltcG9y dGFudCBmb3INCmNsYXJpdHkgYmVsb3cuDQoNCkkndmUgbWFza2VkIHRoZW0gLSBzZWVtcyB0aGUg Y29tcGlsZXIgaXMgY2xldmVyIGVub3VnaCB0byB1bmRvIHRoYXQgZXZlbg0KYXQgLU8xLg0KDQp+ QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Mon Jan 09 15:05:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 15:05:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473725.734451 (Exim 4.92) (envelope-from ) id 1pEti9-00048P-5k; Mon, 09 Jan 2023 15:05:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473725.734451; Mon, 09 Jan 2023 15:05:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEti9-00048I-1y; Mon, 09 Jan 2023 15:05:17 +0000 Received: by outflank-mailman (input) for mailman id 473725; Mon, 09 Jan 2023 15:05:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEti7-00048B-53 for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 15:05:15 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0499697b-902f-11ed-91b6-6bf2151ebd3b; Mon, 09 Jan 2023 16:05:13 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D18E14680; Mon, 9 Jan 2023 15:05:12 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id AA32C134AD; Mon, 9 Jan 2023 15:05:12 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id fK85KCgtvGMGQwAAMHmgww (envelope-from ); Mon, 09 Jan 2023 15:05:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0499697b-902f-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1673276712; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=r5AchZgkjBMvT1rTdbO0/ZY4pyGy39ipbS0uUdkYcRY=; b=ALlw8jrDaBsAMeOsxe37gz788mxvsiIal84uC3vh8oCPb/RUOGaMrHPWS4u/XZ7YaTrojO /0vL7JTxDXcpiY4JVHHOHWSEoBC2rfvC7jt/VeA1fco6NMz+r9weMsFMOgQlN3Lxf7gIPR Wxpn6kaoTqLV/lIjIHJInWbL6UGGQMA= Message-ID: <055adce8-ceba-983a-19cc-b09ec30bb3c3@suse.com> Date: Mon, 9 Jan 2023 16:05:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 0/4] xen/blkback: some cleanups Content-Language: en-US To: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Jens Axboe , xen-devel@lists.xenproject.org References: <20221216145816.27374-1-jgross@suse.com> From: Juergen Gross In-Reply-To: <20221216145816.27374-1-jgross@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------Bn9el70qiXK9dBtQDHvkBxHs" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------Bn9el70qiXK9dBtQDHvkBxHs Content-Type: multipart/mixed; boundary="------------5FtRzSy4gpSehjOHS0zh00HX"; protected-headers="v1" From: Juergen Gross To: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Jens Axboe , xen-devel@lists.xenproject.org Message-ID: <055adce8-ceba-983a-19cc-b09ec30bb3c3@suse.com> Subject: Re: [PATCH 0/4] xen/blkback: some cleanups References: <20221216145816.27374-1-jgross@suse.com> In-Reply-To: <20221216145816.27374-1-jgross@suse.com> --------------5FtRzSy4gpSehjOHS0zh00HX Content-Type: multipart/mixed; boundary="------------KfBHdy9WwI9ryEeh1hcoeXvF" --------------KfBHdy9WwI9ryEeh1hcoeXvF Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTYuMTIuMjIgMTU6NTgsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+IFNvbWUgc21hbGwg Y2xlYW51cCBwYXRjaGVzIEkgaGFkIGx5aW5nIGFyb3VuZCBmb3Igc29tZSB0aW1lIG5vdy4N Cj4gDQo+IEp1ZXJnZW4gR3Jvc3MgKDQpOg0KPiAgICB4ZW4vYmxrYmFjazogZml4IHdoaXRl IHNwYWNlIGNvZGUgc3R5bGUgaXNzdWVzDQo+ICAgIHhlbi9ibGtiYWNrOiByZW1vdmUgc3Rh bGUgcHJvdG90eXBlDQo+ICAgIHhlbi9ibGtiYWNrOiBzaW1wbGlmeSBmcmVlX3BlcnNpc3Rl bnRfZ250cygpIGludGVyZmFjZQ0KPiAgICB4ZW4vYmxrYmFjazogbW92ZSBibGtpZl9nZXRf eDg2XypfcmVxKCkgaW50byBibGtiYWNrLmMNCj4gDQo+ICAgZHJpdmVycy9ibG9jay94ZW4t YmxrYmFjay9ibGtiYWNrLmMgfCAxMjYgKysrKysrKysrKysrKysrKysrKysrKysrKy0tLQ0K PiAgIGRyaXZlcnMvYmxvY2sveGVuLWJsa2JhY2svY29tbW9uLmggIHwgMTAzICstLS0tLS0t LS0tLS0tLS0tLS0tLS0tDQo+ICAgMiBmaWxlcyBjaGFuZ2VkLCAxMTggaW5zZXJ0aW9ucygr KSwgMTExIGRlbGV0aW9ucygtKQ0KPiANCg0KUGluZz8NCg0KDQpKdWVyZ2VuDQo= --------------KfBHdy9WwI9ryEeh1hcoeXvF Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------KfBHdy9WwI9ryEeh1hcoeXvF-- --------------5FtRzSy4gpSehjOHS0zh00HX-- --------------Bn9el70qiXK9dBtQDHvkBxHs Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmO8LSgFAwAAAAAACgkQsN6d1ii/Ey8T rgf/YPspae1H6xxWZbx8KKP2yS3WylDZF0YoQUBMlTxslcwhIiRltIckPFalUVdJclpwj8v2DyXK gIqKYpP1LJvXxIwty70hNd7lsWtSUeG633XCeEmkm/UlxGtk901ELOiPC6Pz4kHOS2Q+24CumPyV Cto1pzmm4K0PiXaAZyLLJ1B9GBpKnoOBJoL4H9Gxoq3lNr+FATjxbIQaPNS45hKx9qFhlVqAsDUX s+KMdJQsyhXcIakEzwBiqpZ0A4DAP7I8zHuoMeELoPR7DpZB+rPh8MlobYvQfv/eR1hIRjlq8zeB 5UV+XYYQGFDp1Z2p4QHR4IerT9sRCNCqyiQ8/AlYjw== =sGDi -----END PGP SIGNATURE----- --------------Bn9el70qiXK9dBtQDHvkBxHs-- From xen-devel-bounces@lists.xenproject.org Mon Jan 09 15:09:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 15:09:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473731.734462 (Exim 4.92) (envelope-from ) id 1pEtmA-0004lL-KX; Mon, 09 Jan 2023 15:09:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473731.734462; Mon, 09 Jan 2023 15:09:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEtmA-0004lE-HZ; Mon, 09 Jan 2023 15:09:26 +0000 Received: by outflank-mailman (input) for mailman id 473731; Mon, 09 Jan 2023 15:09:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEtm9-0004l8-R5 for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 15:09:25 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9a20b14f-902f-11ed-91b6-6bf2151ebd3b; Mon, 09 Jan 2023 16:09:24 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BF9EF34300; Mon, 9 Jan 2023 15:09:23 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 788C2134AD; Mon, 9 Jan 2023 15:09:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id diIQHCMuvGORRQAAMHmgww (envelope-from ); Mon, 09 Jan 2023 15:09:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9a20b14f-902f-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1673276963; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=bvld8zPnYDTnQIG1YqFCYb/KZpQyo3ITt9siNGCo5AU=; b=vFJ4c9PD8hUN1mARIMwxWF3d/NZ/pc8pC3MQlSRQRs0Sikg/ojs58lhAE4+cVRT9SEL5Lt UqCOuBfA+OZ0KtIVPDjs94DZnYPv5X6A8k7wQ1G8tbRh3i+f1FV1MsMlcHcXUyFptlc1T+ M4AJqrOad/ZUJ+3AhGSlF0oacbYL6LM= From: Juergen Gross To: linux-kernel@vger.kernel.org, x86@kernel.org Cc: xen-devel@lists.xenproject.org, Juergen Gross , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" Subject: [PATCH] x86/mm: fix poking_init() for Xen PV guests Date: Mon, 9 Jan 2023 16:09:22 +0100 Message-Id: <20230109150922.10578-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Commit 3f4c8211d982 ("x86/mm: Use mm_alloc() in poking_init()") broke the kernel for running as Xen PV guest. It seems as if the new address space is never activated before being used, resulting in Xen rejecting to accept the new CR3 value (the PGD isn't pinned). Fix that by adding the now missing call of paravirt_arch_dup_mmap() to poking_init(). That call was previously done by dup_mm()->dup_mmap() and it is a NOP for all cases but for Xen PV, where it is just doing the pinning of the PGD. Fixes: 3f4c8211d982 ("x86/mm: Use mm_alloc() in poking_init()") Signed-off-by: Juergen Gross --- arch/x86/mm/init.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c index d3987359d441..5f8ba537d9d3 100644 --- a/arch/x86/mm/init.c +++ b/arch/x86/mm/init.c @@ -804,6 +804,9 @@ void __init poking_init(void) poking_mm = mm_alloc(); BUG_ON(!poking_mm); + /* Xen PV guests need the PGD to be pinned. */ + paravirt_arch_dup_mmap(NULL, poking_mm); + /* * Randomize the poking address, but make sure that the following page * will be mapped at the same PMD. We need 2 pages, so find space for 3, -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon Jan 09 15:42:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 15:42:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473737.734472 (Exim 4.92) (envelope-from ) id 1pEuI5-0000gy-Vk; Mon, 09 Jan 2023 15:42:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473737.734472; Mon, 09 Jan 2023 15:42:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEuI5-0000gr-Ss; Mon, 09 Jan 2023 15:42:25 +0000 Received: by outflank-mailman (input) for mailman id 473737; Mon, 09 Jan 2023 15:42:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEuI5-0000gh-Fr; Mon, 09 Jan 2023 15:42:25 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEuI4-00011X-Vt; Mon, 09 Jan 2023 15:42:25 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEuI4-0007V1-JY; Mon, 09 Jan 2023 15:42:24 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pEuI4-0002kk-J4; Mon, 09 Jan 2023 15:42:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=jA0yvhez32OeCmtzp05Jy8HY2/RDxk7UhvH1Vikp3hA=; b=AgU8exHCApozfsWCmyLm1HbC/f /CGLL5AkGwiKFQkVBSg+AjSh96Pk7FiGsbnOaWFW/44HOyw7q6WWig0k7bi+pzH/CX9nJa/pqCBXG kgxzr8pTO8q1reIHWTbsmZAqUYqD2nvQSeYVBaTs7AXOuPoGHEcRIRcu7NRwqPnvnZNE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 175643: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-amd64-xsm:xen-build:fail:regression qemu-mainline:build-amd64:xen-build:fail:regression qemu-mainline:build-i386:xen-build:fail:regression qemu-mainline:build-arm64-xsm:xen-build:fail:regression qemu-mainline:build-i386-xsm:xen-build:fail:regression qemu-mainline:build-arm64:xen-build:fail:regression qemu-mainline:build-armhf:xen-build:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-coresched-amd64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:build-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-rtds:build-check(1):blocked:nonblocking qemu-mainline:build-arm64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking qemu-mainline:build-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking qemu-mainline:build-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-dom0pvh-xl-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-dom0pvh-xl-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvshim:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-pygrub:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvhv2-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-freebsd11-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-freebsd12-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvhv2-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-multivcpu:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: qemuu=3d83b78285d6e96636130f7d449fd02e2d4deee0 X-Osstest-Versions-That: qemuu=0ab12aa32462817f0a53fa6f6ce4baf664ef1713 From: osstest service owner Date: Mon, 09 Jan 2023 15:42:24 +0000 flight 175643 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/175643/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 175623 build-amd64 6 xen-build fail REGR. vs. 175623 build-i386 6 xen-build fail REGR. vs. 175623 build-arm64-xsm 6 xen-build fail REGR. vs. 175623 build-i386-xsm 6 xen-build fail REGR. vs. 175623 build-arm64 6 xen-build fail REGR. vs. 175623 build-armhf 6 xen-build fail REGR. vs. 175623 Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-win7-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ws16-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-shadow 1 build-check(1) blocked n/a test-amd64-i386-xl-vhd 1 build-check(1) blocked n/a test-amd64-i386-xl-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) blocked n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) blocked n/a test-armhf-armhf-xl-rtds 1 build-check(1) blocked n/a test-armhf-armhf-xl-vhd 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-amd 1 build-check(1) blocked n/a test-amd64-i386-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-i386 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-amd64 1 build-check(1) blocked n/a test-amd64-coresched-i386-xl 1 build-check(1) blocked n/a test-amd64-coresched-amd64-xl 1 build-check(1) blocked n/a test-amd64-amd64-xl-xsm 1 build-check(1) blocked n/a build-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-shadow 1 build-check(1) blocked n/a test-amd64-amd64-xl-rtds 1 build-check(1) blocked n/a build-arm64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ws16-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a build-armhf-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-amd64-dom0pvh-xl-amd 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 1 build-check(1) blocked n/a test-amd64-amd64-dom0pvh-xl-intel 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvshim 1 build-check(1) blocked n/a test-amd64-amd64-pair 1 build-check(1) blocked n/a test-amd64-amd64-pygrub 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvhv2-intel 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-freebsd11-amd64 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-freebsd12-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvhv2-amd 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-nested-amd 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-nested-intel 1 build-check(1) blocked n/a test-amd64-amd64-xl-multivcpu 1 build-check(1) blocked n/a test-amd64-amd64-xl 1 build-check(1) blocked n/a test-amd64-amd64-xl-credit1 1 build-check(1) blocked n/a test-amd64-amd64-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-arndale 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-intel 1 build-check(1) blocked n/a test-amd64-i386-xl 1 build-check(1) blocked n/a test-amd64-i386-xl-pvshim 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a version targeted for testing: qemuu 3d83b78285d6e96636130f7d449fd02e2d4deee0 baseline version: qemuu 0ab12aa32462817f0a53fa6f6ce4baf664ef1713 Last test of basis 175623 2023-01-07 23:09:00 Z 1 days Failing since 175627 2023-01-08 14:40:14 Z 1 days 4 attempts Testing same since 175643 2023-01-09 13:40:19 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Greg Kurz Kai Huang Lubomir Rintel Paolo Bonzini Peter Maydell Philippe Mathieu-Daudé Richard Henderson jobs: build-amd64-xsm fail build-arm64-xsm fail build-i386-xsm fail build-amd64 fail build-arm64 fail build-armhf fail build-i386 fail build-amd64-libvirt blocked build-arm64-libvirt blocked build-armhf-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl blocked test-amd64-coresched-amd64-xl blocked test-arm64-arm64-xl blocked test-armhf-armhf-xl blocked test-amd64-i386-xl blocked test-amd64-coresched-i386-xl blocked test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm blocked test-amd64-i386-xl-qemuu-debianhvm-i386-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm blocked test-arm64-arm64-xl-xsm blocked test-amd64-i386-xl-xsm blocked test-amd64-amd64-qemuu-nested-amd blocked test-amd64-amd64-xl-pvhv2-amd blocked test-amd64-i386-qemuu-rhel6hvm-amd blocked test-amd64-amd64-dom0pvh-xl-amd blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64 blocked test-amd64-i386-xl-qemuu-debianhvm-amd64 blocked test-amd64-i386-freebsd10-amd64 blocked test-amd64-amd64-qemuu-freebsd11-amd64 blocked test-amd64-amd64-qemuu-freebsd12-amd64 blocked test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked test-amd64-amd64-xl-qemuu-win7-amd64 blocked test-amd64-i386-xl-qemuu-win7-amd64 blocked test-amd64-amd64-xl-qemuu-ws16-amd64 blocked test-amd64-i386-xl-qemuu-ws16-amd64 blocked test-armhf-armhf-xl-arndale blocked test-amd64-amd64-xl-credit1 blocked test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 blocked test-amd64-amd64-xl-credit2 blocked test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 blocked test-armhf-armhf-xl-cubietruck blocked test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict blocked test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict blocked test-amd64-i386-freebsd10-i386 blocked test-amd64-amd64-qemuu-nested-intel blocked test-amd64-amd64-xl-pvhv2-intel blocked test-amd64-i386-qemuu-rhel6hvm-intel blocked test-amd64-amd64-dom0pvh-xl-intel blocked test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu blocked test-armhf-armhf-xl-multivcpu blocked test-amd64-amd64-pair blocked test-amd64-i386-pair blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim blocked test-amd64-i386-xl-pvshim blocked test-amd64-amd64-pygrub blocked test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds blocked test-armhf-armhf-xl-rtds blocked test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow blocked test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow blocked test-amd64-amd64-xl-shadow blocked test-amd64-i386-xl-shadow blocked test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd blocked test-amd64-i386-xl-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 799 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Jan 09 15:47:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 15:47:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473746.734484 (Exim 4.92) (envelope-from ) id 1pEuMa-0001Ox-MA; Mon, 09 Jan 2023 15:47:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473746.734484; Mon, 09 Jan 2023 15:47:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEuMa-0001Oq-JL; Mon, 09 Jan 2023 15:47:04 +0000 Received: by outflank-mailman (input) for mailman id 473746; Mon, 09 Jan 2023 15:47:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEuMZ-0001Ok-RX for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 15:47:03 +0000 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [2a00:1450:4864:20::630]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id db81c3f9-9034-11ed-b8d0-410ff93cb8f0; Mon, 09 Jan 2023 16:47:01 +0100 (CET) Received: by mail-ej1-x630.google.com with SMTP id az20so2095181ejc.1 for ; Mon, 09 Jan 2023 07:47:01 -0800 (PST) Received: from 2a02.2378.102e.bce5.ip.kyivstar.net ([2a02:2378:102e:bce5:dfc0:9312:b994:6b21]) by smtp.gmail.com with ESMTPSA id 22-20020a170906311600b0082535e2da13sm3851561ejx.6.2023.01.09.07.46.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 07:47:00 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: db81c3f9-9034-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=82ki1vMowwI70MnBQW3UbvNHNyHvE7BkIpy4+UwdStM=; b=P6CKvK20Bj18bBrI07gAlkAo+Yh+biv8P2wsY4XBiE17W9/VOgxQwXj4WfxZ8GgF9b jb5+vCJoOWc5JhSskjJ4rNOWFjyjdn0157mn6PM5ZJhrhCsPRkBR7mGK5rBky6YHu0zQ FDsbwqYM2NFzdrEKZTIRNzXE/k+WyGWCVbaWARwLtSl+hA1UqtkpCxJTDgIVJpbcN5do ew++PrS2RxFx89d2KNVKIirztg0CKZmpgVtlwv8iPr8Y8WmBAXarw7WPF9VrlwnJblY6 xDl+zjil2q58/ROXxJcg61H5N5kpYC/tzQEFBiheLSto0T5Nt09iLb7IRbZQwF3kkfAe +UOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=82ki1vMowwI70MnBQW3UbvNHNyHvE7BkIpy4+UwdStM=; b=S2QxqoRYEkrTgpHaTsKHKYumuExZ+cmKOY6nVRajCji9L5PZguBOY+fs65ZlNo9sZ4 d6XK2+51dYkQlce5mH8tSRWAkFHiWzOHUwDAKTsL6FjVV2bjfLrZO0Kyc5QbspqnW2j7 hw8HEnrTsjjeHv+TXG3jxYcOpqQSo0ebl8MjbtkOrluz+C7BytkWEl6ePHXQTN3/swz7 s7ycCHeUjpy3N46MePmG8GPd+x7zANR4VLbqKL9rnk4XL+EGqlRhjOZhAwwfEt8zgqei w2FdCufjPXNfZgXKfAlrwZM73WBQJfAp1uiW3yAlpNGsg4N5NZmauWot1aahgO1BrvjB BBKA== X-Gm-Message-State: AFqh2kpz3VnOBglCDJFV052Pzu9+Fs/Y6lKzKKdBPB5AUMgy/T10jgXE Tnz5uDoPOSynMbsNdp5szh1QpBbPSMV/ZA== X-Google-Smtp-Source: AMrXdXvU+k7sC2FPfjiMKXaK/O1B58hpm9yxbI09VnM1XbVfxplgRx4xurEdUsRiaY2jyMDcRpRgbQ== X-Received: by 2002:a17:907:a782:b0:7c1:6430:e5d0 with SMTP id vx2-20020a170907a78200b007c16430e5d0mr57971201ejc.4.1673279221035; Mon, 09 Jan 2023 07:47:01 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis , George Dunlap , Wei Liu , Doug Goldstein Subject: [PATCH v2 0/8] Basic early_printk and smoke test implementation Date: Mon, 9 Jan 2023 17:46:47 +0200 Message-Id: X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The patch series introduces the following: - the minimal set of headers and changes inside them. - SBI (RISC-V Supervisor Binary Interface) things necessary for basic early_printk implementation. - things needed to set up the stack. - early_printk() function to print only strings. - RISC-V smoke test which checks if "Hello from C env" message is present in serial.tmp --- Changes in V2: - update commit patches commit messages according to the mailing list comments - Remove unneeded types in - Introduce definition of STACK_SIZE - order the files alphabetically in Makefile - Add license to early_printk.c - Add RISCV_32 dependecy to config EARLY_PRINTK in Kconfig.debug - Move dockerfile changes to separate config and sent them as separate patch to mailing list. - Update test.yaml to wire up smoke test --- Oleksii Kurochko (8): xen/riscv: introduce dummy asm/init.h xen/riscv: introduce asm/types.h header file xen/riscv: introduce stack stuff xen/riscv: introduce sbi call to putchar to console xen/include: include in xen/riscv: introduce early_printk basic stuff xen/riscv: print hello message from C env automation: add RISC-V smoke test automation/gitlab-ci/test.yaml | 20 +++++++++++ automation/scripts/qemu-smoke-riscv64.sh | 20 +++++++++++ xen/arch/riscv/Kconfig.debug | 7 ++++ xen/arch/riscv/Makefile | 3 ++ xen/arch/riscv/early_printk.c | 33 +++++++++++++++++ xen/arch/riscv/include/asm/config.h | 2 ++ xen/arch/riscv/include/asm/early_printk.h | 12 +++++++ xen/arch/riscv/include/asm/init.h | 12 +++++++ xen/arch/riscv/include/asm/sbi.h | 34 ++++++++++++++++++ xen/arch/riscv/include/asm/types.h | 22 ++++++++++++ xen/arch/riscv/riscv64/head.S | 6 +++- xen/arch/riscv/sbi.c | 44 +++++++++++++++++++++++ xen/arch/riscv/setup.c | 18 ++++++++++ xen/include/xen/early_printk.h | 2 ++ 14 files changed, 234 insertions(+), 1 deletion(-) create mode 100755 automation/scripts/qemu-smoke-riscv64.sh create mode 100644 xen/arch/riscv/early_printk.c create mode 100644 xen/arch/riscv/include/asm/early_printk.h create mode 100644 xen/arch/riscv/include/asm/init.h create mode 100644 xen/arch/riscv/include/asm/sbi.h create mode 100644 xen/arch/riscv/include/asm/types.h create mode 100644 xen/arch/riscv/sbi.c create mode 100644 xen/arch/riscv/setup.c -- 2.38.1 From xen-devel-bounces@lists.xenproject.org Mon Jan 09 15:47:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 15:47:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473747.734495 (Exim 4.92) (envelope-from ) id 1pEuMb-0001eS-VJ; Mon, 09 Jan 2023 15:47:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473747.734495; Mon, 09 Jan 2023 15:47:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEuMb-0001eL-Ri; Mon, 09 Jan 2023 15:47:05 +0000 Received: by outflank-mailman (input) for mailman id 473747; Mon, 09 Jan 2023 15:47:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEuMa-0001Ok-VG for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 15:47:04 +0000 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [2a00:1450:4864:20::636]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id dc623eab-9034-11ed-b8d0-410ff93cb8f0; Mon, 09 Jan 2023 16:47:03 +0100 (CET) Received: by mail-ej1-x636.google.com with SMTP id jo4so21168042ejb.7 for ; Mon, 09 Jan 2023 07:47:03 -0800 (PST) Received: from 2a02.2378.102e.bce5.ip.kyivstar.net ([2a02:2378:102e:bce5:dfc0:9312:b994:6b21]) by smtp.gmail.com with ESMTPSA id 22-20020a170906311600b0082535e2da13sm3851561ejx.6.2023.01.09.07.47.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 07:47:02 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dc623eab-9034-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yxR8yQrVeJYFYtv18lIm8lC/4hVNKMWmQGoHK/HMNYg=; b=MbfkYVQ21dyKLh0n1Yq8pvnM6WE4dqWitMH1Q14NyKLDFl9bDMfQKTQDnwjA2JmXDc 99p/3TMEdJ5o+TUivAORi3ew2+4FRY0D3NvOGwi1nUkMa402TjOowdFxlZgaqRnjz0dX AmASVl2pEpkya66dzeJ9Beua3rAIbKil93GWaoMsluzUMhkCjkehqXp4rrC1Q04RPciy kqweKCTzoRzNadmxtEK8rgOpoChkJssmd4GV6M8siXBJ1cgM9k+Fr6+mMkKhmNprBYs2 9gy9fGkhqDMI35pcyw+Vx0KgzW3RddIg4yk7WbQk8ESfVbUalfBMvQC7SQNCuTZmqHlG Yxfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yxR8yQrVeJYFYtv18lIm8lC/4hVNKMWmQGoHK/HMNYg=; b=JQnDK2sNoOv3d/OgIMwxQusymbKmCIUuI6df0MyKTXBz4lyI6/WMYoyNcjF1oKV4/M 0kGGX5uviMHNIuJVJRtyOq7Xpv2CdnTYat7b615AV3ScyaR3vi1X+cgADWAKjvSTr+7q CV3mHzb7sn+Ro2OQKWA39Jkqz8m+HZIlayBeAjPj8UquNWbpQG15Trt1LALDlIuYQcIy clFoiScw06gv3pJnCAkWl6lXZSrdjhS6fJoROZfNzbu4jbq93JvX4I30QbTuuVj005Tw Tm9IyvsgP9vi6cbfg7vzZNgCzVdz5Y1cqI/u2m2nW9HC4Qb1cxdiVDDo9ZQza2o4HzJX +u1A== X-Gm-Message-State: AFqh2koVgebcjP8fihLk/snYU2SvDj74AT5TTnWhYRdPDtvYmBeY4Poy uJRBo6AQsbWt5nY7/6rTGvS977EELL8c5A== X-Google-Smtp-Source: AMrXdXvkuJjLqc1ipzuRLKNWMvua3yBg6XMcbn6YVmn6JREdqV4ci4d6f62zaxqkCK+t4sEfWHylHQ== X-Received: by 2002:a17:907:a0cc:b0:78d:f455:b5fa with SMTP id hw12-20020a170907a0cc00b0078df455b5famr55538052ejc.58.1673279222751; Mon, 09 Jan 2023 07:47:02 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH v2 1/8] xen/riscv: introduce dummy asm/init.h Date: Mon, 9 Jan 2023 17:46:48 +0200 Message-Id: X-Mailer: git-send-email 2.38.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The following patches require which includes Signed-off-by: Oleksii Kurochko --- Changes in V2: - Add explanation comment to the comment message --- xen/arch/riscv/include/asm/init.h | 12 ++++++++++++ 1 file changed, 12 insertions(+) create mode 100644 xen/arch/riscv/include/asm/init.h diff --git a/xen/arch/riscv/include/asm/init.h b/xen/arch/riscv/include/asm/init.h new file mode 100644 index 0000000000..237ec25e4e --- /dev/null +++ b/xen/arch/riscv/include/asm/init.h @@ -0,0 +1,12 @@ +#ifndef _XEN_ASM_INIT_H +#define _XEN_ASM_INIT_H + +#endif /* _XEN_ASM_INIT_H */ +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ -- 2.38.1 From xen-devel-bounces@lists.xenproject.org Mon Jan 09 15:47:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 15:47:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473748.734506 (Exim 4.92) (envelope-from ) id 1pEuMe-0001vT-8B; Mon, 09 Jan 2023 15:47:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473748.734506; Mon, 09 Jan 2023 15:47:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEuMe-0001vF-2z; Mon, 09 Jan 2023 15:47:08 +0000 Received: by outflank-mailman (input) for mailman id 473748; Mon, 09 Jan 2023 15:47:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEuMc-0001Ok-Jv for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 15:47:06 +0000 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [2a00:1450:4864:20::633]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id dd5f96aa-9034-11ed-b8d0-410ff93cb8f0; Mon, 09 Jan 2023 16:47:04 +0100 (CET) Received: by mail-ej1-x633.google.com with SMTP id gh17so21186565ejb.6 for ; Mon, 09 Jan 2023 07:47:05 -0800 (PST) Received: from 2a02.2378.102e.bce5.ip.kyivstar.net ([2a02:2378:102e:bce5:dfc0:9312:b994:6b21]) by smtp.gmail.com with ESMTPSA id 22-20020a170906311600b0082535e2da13sm3851561ejx.6.2023.01.09.07.47.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 07:47:03 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dd5f96aa-9034-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MwR1sb54ILTyXGbtU2ZO9pB2xjozIDX5an4zwc8vv24=; b=L7QA222PU0VUvuvMGGBDEY5WIvlPUOE7OnFknuP1vJWZ+5DsSu77SARWSBKusBvSlF VU1828ahEjw5maLmBJNeq0NvYEOVv7cN4Yc+7Wpk6f5gCQHbI6zMLWtEMeM4f+rJbGUU GLADZG2QCj6M1aaCP4RMM8FZxZlEXBozg/y87Fk0OIpQ+4UqwJzzDbdpRU5LhHzLtbdR FnmLP4SWJWlwYO+OXKR/tPpoNmMDgyB7yJnD8osLu0y33H5iVrXt0XqvsDb1K0yyEwY1 6KXhM4Yc5YJBeqRd+XxHwQq3GTR7VDRERVYx26NiJWfltrnzQXI9gMkolZimFpwHKb4I KRkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MwR1sb54ILTyXGbtU2ZO9pB2xjozIDX5an4zwc8vv24=; b=zwWgHIcYvFw6d94iT7lfj5qeUoj6dCvq+peAHTu/RK/9apxrWeYRsO7/esFgu+cK0E sPnfDz984IYcGoTZ0WcgEm6wVpcjpsCejPjDZxPWntcggaCalxRKASC45TGrToh4Vv/Q EX2QYDsGVKpmr4d6VenaDWcyau7cIf73qu0Q7U3vXMINb6w+kvxhwEkX7CisOktnjstD f2hdKwV5QCG0UI0OWK0xpTvekU6aryD4Ry++hNC8SAQKTas27m1BIpvuXmpV/Y+6OZ6l Nu4OIwjxq7dQO5i7tEjxTzA/Vl0Hq9D4ojaHKpAfPaNkoFqvvlm1bzB763mBaXwGTCKA 0TbA== X-Gm-Message-State: AFqh2koCt9f8BE/bFL1FWOCvDxWO5QxG7o3t2SqwbNxHJYmlMIY0MBJ/ YNhFK22wgSBJEbMRClg8TBZ43rb9ozbo4w== X-Google-Smtp-Source: AMrXdXvL4MYDqwCFCVKx5v3neXASMMTKKrCJr293/g3qz2bXcc55OuB2ZHUZv2Yb9p0KAYzdzrRApA== X-Received: by 2002:a17:907:c018:b0:7c1:bb3:45e4 with SMTP id ss24-20020a170907c01800b007c10bb345e4mr55092176ejc.21.1673279224277; Mon, 09 Jan 2023 07:47:04 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH v2 2/8] xen/riscv: introduce asm/types.h header file Date: Mon, 9 Jan 2023 17:46:49 +0200 Message-Id: X-Mailer: git-send-email 2.38.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Signed-off-by: Oleksii Kurochko --- Changes in V2: - Remove unneeded now types from --- xen/arch/riscv/include/asm/types.h | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) create mode 100644 xen/arch/riscv/include/asm/types.h diff --git a/xen/arch/riscv/include/asm/types.h b/xen/arch/riscv/include/asm/types.h new file mode 100644 index 0000000000..fbe352ef20 --- /dev/null +++ b/xen/arch/riscv/include/asm/types.h @@ -0,0 +1,22 @@ +#ifndef __RISCV_TYPES_H__ +#define __RISCV_TYPES_H__ + +#ifndef __ASSEMBLY__ + +#if defined(__SIZE_TYPE__) +typedef __SIZE_TYPE__ size_t; +#else +typedef unsigned long size_t; +#endif + +#endif /* __ASSEMBLY__ */ + +#endif /* __RISCV_TYPES_H__ */ +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ -- 2.38.1 From xen-devel-bounces@lists.xenproject.org Mon Jan 09 15:47:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 15:47:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473749.734517 (Exim 4.92) (envelope-from ) id 1pEuMf-0002CT-G8; Mon, 09 Jan 2023 15:47:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473749.734517; Mon, 09 Jan 2023 15:47:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEuMf-0002CK-Bq; Mon, 09 Jan 2023 15:47:09 +0000 Received: by outflank-mailman (input) for mailman id 473749; Mon, 09 Jan 2023 15:47:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEuMd-0001Ok-W7 for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 15:47:08 +0000 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [2a00:1450:4864:20::633]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id de4035cc-9034-11ed-b8d0-410ff93cb8f0; Mon, 09 Jan 2023 16:47:05 +0100 (CET) Received: by mail-ej1-x633.google.com with SMTP id gh17so21186770ejb.6 for ; Mon, 09 Jan 2023 07:47:06 -0800 (PST) Received: from 2a02.2378.102e.bce5.ip.kyivstar.net ([2a02:2378:102e:bce5:dfc0:9312:b994:6b21]) by smtp.gmail.com with ESMTPSA id 22-20020a170906311600b0082535e2da13sm3851561ejx.6.2023.01.09.07.47.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 07:47:05 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: de4035cc-9034-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=C4pVVB8xi310OysZICNFUHzxHNt1nf/1tEIawtEgWpc=; b=kNznxBbLQ/4OzsvHOcyh305lnTxgPvZLv3vD3O3+3t2rvt6aQlK2jR9FWI/YWgccMR VnOLnSUqE5mRKfrWnTx5LnR/uY5RTG19nJbjQfeRGpP0HroB+cNeuq8kvYvuzNEfB6Y7 LZeBtMr4+OT/q2y9RcYnguf9AzjQTdSysXaxgLNDRiMHDFCmdoBu6CX3Wdx0bxeknvRh 514Z27ruElHq0nZnD8Pjg8TwsRlmHZzzJq4Nz7TqjZixZRCcEg7ywvHVv1ofF6s/ImLU c+3L4nvMpi46mwBb/xzHI7WBKmzYuKFltG4gvld1iYtB+M7EE/5rMUt5glnSFpteonxa mjKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=C4pVVB8xi310OysZICNFUHzxHNt1nf/1tEIawtEgWpc=; b=ypIV5VZkjbRbd6nY6erMjqjPBMsfvBzBnPeyzvti10vbBJLwmOk/zVd/Wg4KRLD9mG BCRvQ3Kuz1iDtcgvlpkfwWNzO3irgTAPT+1w+AkdQIJEV+fZRGha9z1z+pyGJTvI3buZ Lo1E1WgcfOB4NAmDV6UmrAMPWesXyIjIJ340S46tNwBMtew6rC2TDFNcR3HSbO5C1H7t 1+CGFfWl3OGcN0NDT5s9wbFwGGjPRTi08LsNRtuxzLf529CCOM8c+6NJll9qipwm5bie hFYGPaXaQjCDOh/erx348I5nebmIgK3Ye6qv3nm1yTl+3nqyNfmE4wC7DFyPiEmcg0q0 yXxg== X-Gm-Message-State: AFqh2kpvM/1U/h//2TsdLUtO3mcgpfQ/4Zp5f+C/EtN+GnmNcsAHgPUO QueGCrR40cOxKUeXZ8x7QjBoSmYujhaIOg== X-Google-Smtp-Source: AMrXdXt8ZBw2EErZkpU2Gr1NDyBk7nJqtVGI5o2yHEP4kiLKvjxrGf5Shm7rPDwNPBmK4Z4OloPCAQ== X-Received: by 2002:a17:907:d604:b0:7ad:d62d:9d31 with SMTP id wd4-20020a170907d60400b007add62d9d31mr58787345ejc.67.1673279225854; Mon, 09 Jan 2023 07:47:05 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH v2 3/8] xen/riscv: introduce stack stuff Date: Mon, 9 Jan 2023 17:46:50 +0200 Message-Id: X-Mailer: git-send-email 2.38.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The patch introduces and sets up a stack in order to go to C environment Signed-off-by: Oleksii Kurochko --- Changes in V2: - introduce STACK_SIZE define. - use consistent padding between instruction mnemonic and operand(s) --- xen/arch/riscv/Makefile | 1 + xen/arch/riscv/include/asm/config.h | 2 ++ xen/arch/riscv/riscv64/head.S | 8 +++++++- xen/arch/riscv/setup.c | 6 ++++++ 4 files changed, 16 insertions(+), 1 deletion(-) create mode 100644 xen/arch/riscv/setup.c diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile index 248f2cbb3e..5a67a3f493 100644 --- a/xen/arch/riscv/Makefile +++ b/xen/arch/riscv/Makefile @@ -1,4 +1,5 @@ obj-$(CONFIG_RISCV_64) += riscv64/ +obj-y += setup.o $(TARGET): $(TARGET)-syms $(OBJCOPY) -O binary -S $< $@ diff --git a/xen/arch/riscv/include/asm/config.h b/xen/arch/riscv/include/asm/config.h index 0370f865f3..bdd2237f01 100644 --- a/xen/arch/riscv/include/asm/config.h +++ b/xen/arch/riscv/include/asm/config.h @@ -43,6 +43,8 @@ #define SMP_CACHE_BYTES (1 << 6) +#define STACK_SIZE (PAGE_SIZE) + #endif /* __RISCV_CONFIG_H__ */ /* * Local variables: diff --git a/xen/arch/riscv/riscv64/head.S b/xen/arch/riscv/riscv64/head.S index 990edb70a0..c1f33a1934 100644 --- a/xen/arch/riscv/riscv64/head.S +++ b/xen/arch/riscv/riscv64/head.S @@ -1,4 +1,10 @@ .section .text.header, "ax", %progbits ENTRY(start) - j start + la sp, cpu0_boot_stack + li t0, STACK_SIZE + add sp, sp, t0 + +_start_hang: + wfi + j _start_hang diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c new file mode 100644 index 0000000000..41ef4912bd --- /dev/null +++ b/xen/arch/riscv/setup.c @@ -0,0 +1,6 @@ +#include +#include + +/* Xen stack for bringing up the first CPU. */ +unsigned char __initdata cpu0_boot_stack[STACK_SIZE] + __aligned(STACK_SIZE); -- 2.38.1 From xen-devel-bounces@lists.xenproject.org Mon Jan 09 15:47:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 15:47:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473750.734528 (Exim 4.92) (envelope-from ) id 1pEuMg-0002U6-Ss; Mon, 09 Jan 2023 15:47:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473750.734528; Mon, 09 Jan 2023 15:47:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEuMg-0002Tr-N2; Mon, 09 Jan 2023 15:47:10 +0000 Received: by outflank-mailman (input) for mailman id 473750; Mon, 09 Jan 2023 15:47:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEuMf-0001Ok-Td for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 15:47:10 +0000 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [2a00:1450:4864:20::636]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id df406b08-9034-11ed-b8d0-410ff93cb8f0; Mon, 09 Jan 2023 16:47:07 +0100 (CET) Received: by mail-ej1-x636.google.com with SMTP id u19so21089343ejm.8 for ; Mon, 09 Jan 2023 07:47:08 -0800 (PST) Received: from 2a02.2378.102e.bce5.ip.kyivstar.net ([2a02:2378:102e:bce5:dfc0:9312:b994:6b21]) by smtp.gmail.com with ESMTPSA id 22-20020a170906311600b0082535e2da13sm3851561ejx.6.2023.01.09.07.47.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 07:47:07 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: df406b08-9034-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UWY8J8kAj1GiWYViPSk623jkw9JIRhe7Xct39qK260A=; b=faYE9gRMjOWUAZnlxR0n2k9ulExL3BU8gI18/Go4uLkUS4fR5scoMfT35S9KZX6uOZ HYcsprc8PFa524gIL0PuYzj83/O0v76JhM9H0K71qV4HBkB1VbcvsHS9CsBandHEWM6v h6RSj/hpZPc6kaZrGllx0TIOL5weII6SDKKXrdHybOsF0lkyVfqUnyMR+QA4cpiiNvAH jJykCOSQewTcwUzVCbX8SQHJeNvHvrZovH3LDTsOph02VLCdUgOFaLKIQ15PUsNNoKTf c4vgdZn2MqTMN0j/Th5xBT2e2TryjD1gKV9oV+Ni4u/sO3SC56gvlhVsd5lqKmhT3lyt Vngw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UWY8J8kAj1GiWYViPSk623jkw9JIRhe7Xct39qK260A=; b=gXMB/0PkkuIUe3w+qUiNu0M81ModaJNGFYTQpRUVuFb9TO70Dgp0Ehz0w6XeOIIuOA AtiKyP8It5zziN7zdb69VmHkGBdUYg6L5ZQxPO/f7LqVsA5Ytd80QP6JQDZ0fhbvCvpr iwdoMdqj9LNiIzMndFwVt/JptU8GLWf7xpCFSIlXH1ZfuovW0dg2HxjvA5sruDmK/tcC hpU40rnLfKETMyPHiyiJMw8Q17WRZLnNgyhRWjIsgGvM1kVZbjPVRGu0OhM0FDx1EcqN uIA0HmoETt52I1e0d069Zs3Ckg9kt+pkML9hRPIHsiEqfeqIq1XjlWTVD1fcAolwZtmC Kvgg== X-Gm-Message-State: AFqh2kodYfOoFdBZB3XrolJPVZdCVJFnOT3DXg+7mTP6otPUxQhe0r7h rH5i3cRBi17eSh0n1Y3AF7Rp+9UTmrO53w== X-Google-Smtp-Source: AMrXdXs1yjbXpCwoz+bkJ3Hs45mkL4PCi7WcVeUtjcR0VS78Hau/5cELtha3tptBw3sIe+pxnYA3NA== X-Received: by 2002:a17:907:d48e:b0:7ae:b2e4:7b3f with SMTP id vj14-20020a170907d48e00b007aeb2e47b3fmr60936186ejc.8.1673279227517; Mon, 09 Jan 2023 07:47:07 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH v2 4/8] xen/riscv: introduce sbi call to putchar to console Date: Mon, 9 Jan 2023 17:46:51 +0200 Message-Id: <9b85a963db538e4735a9f99fc9090ad79508cb2c.1673278109.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The patch introduce sbi_putchar() SBI call which is necessary to implement initial early_printk Signed-off-by: Oleksii Kurochko --- Changes in V2: - add an explanatory comment about sbi_console_putchar() function. - order the files alphabetically in Makefile --- xen/arch/riscv/Makefile | 1 + xen/arch/riscv/include/asm/sbi.h | 34 ++++++++++++++++++++++++ xen/arch/riscv/sbi.c | 44 ++++++++++++++++++++++++++++++++ 3 files changed, 79 insertions(+) create mode 100644 xen/arch/riscv/include/asm/sbi.h create mode 100644 xen/arch/riscv/sbi.c diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile index 5a67a3f493..fd916e1004 100644 --- a/xen/arch/riscv/Makefile +++ b/xen/arch/riscv/Makefile @@ -1,4 +1,5 @@ obj-$(CONFIG_RISCV_64) += riscv64/ +obj-y += sbi.o obj-y += setup.o $(TARGET): $(TARGET)-syms diff --git a/xen/arch/riscv/include/asm/sbi.h b/xen/arch/riscv/include/asm/sbi.h new file mode 100644 index 0000000000..34b53f8eaf --- /dev/null +++ b/xen/arch/riscv/include/asm/sbi.h @@ -0,0 +1,34 @@ +/* SPDX-License-Identifier: (GPL-2.0-or-later) */ +/* + * Copyright (c) 2021 Vates SAS. + * + * Taken from xvisor, modified by Bobby Eshleman (bobby.eshleman@gmail.com). + * + * Taken/modified from Xvisor project with the following copyright: + * + * Copyright (c) 2019 Western Digital Corporation or its affiliates. + */ + +#ifndef __CPU_SBI_H__ +#define __CPU_SBI_H__ + +#define SBI_EXT_0_1_CONSOLE_PUTCHAR 0x1 + +struct sbiret { + long error; + long value; +}; + +struct sbiret sbi_ecall(unsigned long ext, unsigned long fid, unsigned long arg0, + unsigned long arg1, unsigned long arg2, + unsigned long arg3, unsigned long arg4, + unsigned long arg5); + +/** + * Writes given character to the console device. + * + * @param ch The data to be written to the console. + */ +void sbi_console_putchar(int ch); + +#endif // __CPU_SBI_H__ diff --git a/xen/arch/riscv/sbi.c b/xen/arch/riscv/sbi.c new file mode 100644 index 0000000000..67cf5dd982 --- /dev/null +++ b/xen/arch/riscv/sbi.c @@ -0,0 +1,44 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* + * Taken and modified from the xvisor project with the copyright Copyright (c) + * 2019 Western Digital Corporation or its affiliates and author Anup Patel + * (anup.patel@wdc.com). + * + * Modified by Bobby Eshleman (bobby.eshleman@gmail.com). + * + * Copyright (c) 2019 Western Digital Corporation or its affiliates. + * Copyright (c) 2021 Vates SAS. + */ + +#include +#include + +struct sbiret sbi_ecall(unsigned long ext, unsigned long fid, unsigned long arg0, + unsigned long arg1, unsigned long arg2, + unsigned long arg3, unsigned long arg4, + unsigned long arg5) +{ + struct sbiret ret; + register unsigned long a0 asm ("a0") = arg0; + register unsigned long a1 asm ("a1") = arg1; + register unsigned long a2 asm ("a2") = arg2; + register unsigned long a3 asm ("a3") = arg3; + register unsigned long a4 asm ("a4") = arg4; + register unsigned long a5 asm ("a5") = arg5; + register unsigned long a6 asm ("a6") = fid; + register unsigned long a7 asm ("a7") = ext; + + asm volatile ("ecall" + : "+r" (a0), "+r" (a1) + : "r" (a2), "r" (a3), "r" (a4), "r" (a5), "r" (a6), "r" (a7) + : "memory"); + ret.error = a0; + ret.value = a1; + + return ret; +} + +void sbi_console_putchar(int ch) +{ + sbi_ecall(SBI_EXT_0_1_CONSOLE_PUTCHAR, 0, ch, 0, 0, 0, 0, 0); +} -- 2.38.1 From xen-devel-bounces@lists.xenproject.org Mon Jan 09 15:47:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 15:47:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473751.734539 (Exim 4.92) (envelope-from ) id 1pEuMj-0002om-7b; Mon, 09 Jan 2023 15:47:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473751.734539; Mon, 09 Jan 2023 15:47:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEuMj-0002od-4H; Mon, 09 Jan 2023 15:47:13 +0000 Received: by outflank-mailman (input) for mailman id 473751; Mon, 09 Jan 2023 15:47:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEuMh-0001Ok-E9 for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 15:47:11 +0000 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [2a00:1450:4864:20::633]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e03e858f-9034-11ed-b8d0-410ff93cb8f0; Mon, 09 Jan 2023 16:47:09 +0100 (CET) Received: by mail-ej1-x633.google.com with SMTP id vm8so21174205ejc.2 for ; Mon, 09 Jan 2023 07:47:09 -0800 (PST) Received: from 2a02.2378.102e.bce5.ip.kyivstar.net ([2a02:2378:102e:bce5:dfc0:9312:b994:6b21]) by smtp.gmail.com with ESMTPSA id 22-20020a170906311600b0082535e2da13sm3851561ejx.6.2023.01.09.07.47.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 07:47:08 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e03e858f-9034-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bfnD404WY8hoWXz7M6QxUrNZUgpeIm9YCOZjEZ67MZU=; b=kCxCCMt//j+fO82VIWosCsH70bh7+2l51ewWKYmVjIJfFuALEKC6RrRaFxKMsNOt4u mjuZaTPIjMiAaysnpjOfy8Y3sEkrHlR7Oam+CrJ6Axc9x0SVjGV/b/BbWsFHm9jLJk4C h6Jxz1ee4Er1T0sYNM76oBiJYz5GJcC/Oi/yn+WiE7TAayD57bkjlkipn8eTTdtA3Mda 8jN+ffqM/G/pOQo7PkWw5pcIoyRztRVxBOyozQ6qQt9g8X0P57tELOcajQaAdFgG5NjN VRFtwC9G3baHMpe5qGiXbG9ibx0wWj++cniJ4OomX1iPIb3q9Fxrfg9y17pQQ/oMdDlt 5ABg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bfnD404WY8hoWXz7M6QxUrNZUgpeIm9YCOZjEZ67MZU=; b=Km+BtszLjgFniMVsMY8mgkx2qZk6XqPEL4hokzUdgxOx1q8gJywT4w/Iqna9VWFDGF KHK2W1p7OubGUmpMLb13rxQjn/mire/1lmahExJFeMoMnambOAELyxRUPpEgbtYV9U9V CyBFNHjECFVtx5Y/HWQF6wem1Jf0nqIKp/hwK3Ng7SimXZjyn/hjPxl61UCnxbe13BMC C0oh0wqh+N5rf6+vBFeDtP2OR2aE1qxYea2SRUiblN1eoERjTD5nbfwIcjT2K+qD7wzn q0HxdHFfl8k+55ci2vTNLEiXkOddQuVKm2Js1thPsvzBKxfuJ1T6QqYf0JiDtBsM7qX7 0BeQ== X-Gm-Message-State: AFqh2kqTpZgHe36wmdhEVOCG2lrDJl2ZvlBUhxGYB6fFWRnceXW1yGJp G2mEOuHe6hEtzB6hfwMOt69alDR0yLjGWQ== X-Google-Smtp-Source: AMrXdXuqaCYbURIHqb86DXSLX04rTZYHXx+kJoChkuf3VUW7/sB/PJn0ZlqOSpiYG/s00ciULywomQ== X-Received: by 2002:a17:906:8447:b0:7c8:9f04:ae7e with SMTP id e7-20020a170906844700b007c89f04ae7emr55018487ejy.22.1673279229209; Mon, 09 Jan 2023 07:47:09 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , George Dunlap , Wei Liu , Julien Grall Subject: [PATCH v2 5/8] xen/include: include in Date: Mon, 9 Jan 2023 17:46:52 +0200 Message-Id: <3b292b680a02e2413ad6d9bd7c64bbe6a71e0d5b.1673278109.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit should be included because second argument of early_puts has type 'size_t' which is defined in Signed-off-by: Oleksii Kurochko Acked-by: Julien Grall --- Changes in V2: - add Acked-by: Julien Grall --- xen/include/xen/early_printk.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/include/xen/early_printk.h b/xen/include/xen/early_printk.h index 0f76c3a74f..abb34687da 100644 --- a/xen/include/xen/early_printk.h +++ b/xen/include/xen/early_printk.h @@ -4,6 +4,8 @@ #ifndef __XEN_EARLY_PRINTK_H__ #define __XEN_EARLY_PRINTK_H__ +#include + #ifdef CONFIG_EARLY_PRINTK void early_puts(const char *s, size_t nr); #else -- 2.38.1 From xen-devel-bounces@lists.xenproject.org Mon Jan 09 15:47:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 15:47:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473752.734550 (Exim 4.92) (envelope-from ) id 1pEuMk-00037L-MO; Mon, 09 Jan 2023 15:47:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473752.734550; Mon, 09 Jan 2023 15:47:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEuMk-000373-Hs; Mon, 09 Jan 2023 15:47:14 +0000 Received: by outflank-mailman (input) for mailman id 473752; Mon, 09 Jan 2023 15:47:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEuMi-0002mL-IQ for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 15:47:12 +0000 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [2a00:1450:4864:20::532]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e18a58d2-9034-11ed-91b6-6bf2151ebd3b; Mon, 09 Jan 2023 16:47:11 +0100 (CET) Received: by mail-ed1-x532.google.com with SMTP id s5so13089777edc.12 for ; Mon, 09 Jan 2023 07:47:11 -0800 (PST) Received: from 2a02.2378.102e.bce5.ip.kyivstar.net ([2a02:2378:102e:bce5:dfc0:9312:b994:6b21]) by smtp.gmail.com with ESMTPSA id 22-20020a170906311600b0082535e2da13sm3851561ejx.6.2023.01.09.07.47.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 07:47:10 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e18a58d2-9034-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=a/b1TrvDNNnrrBRjP6bD1TxMqmwHjv5FMfqQgK0ByUg=; b=RHU8wslsnUIOk0uJuOjVkpeHjI2zvT+TuWTUPIQBT8VG0gCJcnsUUdUqL0zrx7BlRA Ja4DMX7g8dlejSPSJdZnwcpTPDsROkFouutpy9jfH0AUv9F7DWb7fWnUgiMOgnhcN+cA K4Hj+xck+8lKZu1dWSshADexdjJBAQTgOwlC/i1NBhQIi3kZ/o2eoH6DgZztxByv5P1w DHwTWlWoPPteVHZhczHDwcDpyOGl6QpRVZK6yopgpRQw/CTHxukX5xICpq7Or3ph5OqF KlAilXyN5qRL2hzgdmMicADniLRmtR5lKVR7E7UE+WCLqEsEL/siJoPu+75ViPSuTA2C INCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=a/b1TrvDNNnrrBRjP6bD1TxMqmwHjv5FMfqQgK0ByUg=; b=GfSymHcjSt7Xu7MTBR5v4/x7ncEsdBno0kGeSUMzEFRL48NkdOdmiYZPtHRuYpgu8K cW01tiXfzoLG3OV9ZtKrS5bUalqgFKxJkaB+IfrR5ckR6qiOEQc2/nRrmLpmWDPKOk3p qUkkvS4nITiZKZ7qCTLlGjWNf1BxKoFIqozYddFL6zBqSalDF0+uIst9nStmSAf90uZL EULUqJLAM4ghr2rPlUpzUe2L3S9XP3DRu3RkNxRI7VBuGvHyXpBOHDl/Nvf/ALJp/RT1 SfpX1GhCuBJpJO5xaWfb1NrscgvLgRx8Z8diNfTfHtcDPPQKVkmwU1M7nLX3fTMlC4ga suIg== X-Gm-Message-State: AFqh2koch8JGsQkwHPsAykOgv7SQ/imDE119Oqn7TxWmSFBk5VvsLuy1 ALBWlZ9DDguDQelsB4AJkED5LruIh0dfAA== X-Google-Smtp-Source: AMrXdXsMBfaLg7SGeLcx3dyX1xcH85/vA1FA9saSCXMCHzMRkNQd/aKJMn8Y/yKpnXpS2+KReFwA5Q== X-Received: by 2002:a05:6402:1f89:b0:47b:16c7:492c with SMTP id c9-20020a0564021f8900b0047b16c7492cmr63677275edc.25.1673279230974; Mon, 09 Jan 2023 07:47:10 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis , Bobby Eshleman Subject: [PATCH v2 6/8] xen/riscv: introduce early_printk basic stuff Date: Mon, 9 Jan 2023 17:46:53 +0200 Message-Id: <527727b2c9e26e6ef7714fe9a3fbe580caf1ae13.1673278109.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The patch introduces a basic stuff of early_printk functionality which will be enough to print 'hello from C environment". early_printk() function was changed in comparison with original as common isn't being built now so there is no vscnprintf. Because printk() relies on a serial driver (like the ns16550 driver) and drivers require working virtual memory (ioremap()) there is not print functionality early in Xen boot. This commit adds early printk implementation built on the putc SBI call. As sbi_console_putchar() is being already planned for deprecation it is used temporary now and will be removed or reworked after real uart will be ready. Signed-off-by: Bobby Eshleman Signed-off-by: Oleksii Kurochko --- Changes in V2: - add license to early_printk.c - add signed-off-by Bobby - add RISCV_32 to Kconfig.debug to EARLY_PRINTK config - update commit message - order the files alphabetically in Makefile --- xen/arch/riscv/Kconfig.debug | 7 +++++ xen/arch/riscv/Makefile | 1 + xen/arch/riscv/early_printk.c | 33 +++++++++++++++++++++++ xen/arch/riscv/include/asm/early_printk.h | 12 +++++++++ 4 files changed, 53 insertions(+) create mode 100644 xen/arch/riscv/early_printk.c create mode 100644 xen/arch/riscv/include/asm/early_printk.h diff --git a/xen/arch/riscv/Kconfig.debug b/xen/arch/riscv/Kconfig.debug index e69de29bb2..6ba0bd1e5a 100644 --- a/xen/arch/riscv/Kconfig.debug +++ b/xen/arch/riscv/Kconfig.debug @@ -0,0 +1,7 @@ +config EARLY_PRINTK + bool "Enable early printk config" + default DEBUG + depends on RISCV_64 || RISCV_32 + help + + Enables early printk debug messages diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile index fd916e1004..1a4f1a6015 100644 --- a/xen/arch/riscv/Makefile +++ b/xen/arch/riscv/Makefile @@ -1,3 +1,4 @@ +obj-$(CONFIG_EARLY_PRINTK) += early_printk.o obj-$(CONFIG_RISCV_64) += riscv64/ obj-y += sbi.o obj-y += setup.o diff --git a/xen/arch/riscv/early_printk.c b/xen/arch/riscv/early_printk.c new file mode 100644 index 0000000000..88da5169ed --- /dev/null +++ b/xen/arch/riscv/early_printk.c @@ -0,0 +1,33 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * RISC-V early printk using SBI + * + * Copyright (C) 2021 Bobby Eshleman + */ +#include +#include + +/* + * TODO: + * sbi_console_putchar is already planned for deprication + * so it should be reworked to use UART directly. +*/ +void early_puts(const char *s, size_t nr) +{ + while ( nr-- > 0 ) + { + if (*s == '\n') + sbi_console_putchar('\r'); + sbi_console_putchar(*s); + s++; + } +} + +void early_printk(const char *str) +{ + while (*str) + { + early_puts(str, 1); + str++; + } +} diff --git a/xen/arch/riscv/include/asm/early_printk.h b/xen/arch/riscv/include/asm/early_printk.h new file mode 100644 index 0000000000..05106e160d --- /dev/null +++ b/xen/arch/riscv/include/asm/early_printk.h @@ -0,0 +1,12 @@ +#ifndef __EARLY_PRINTK_H__ +#define __EARLY_PRINTK_H__ + +#include + +#ifdef CONFIG_EARLY_PRINTK +void early_printk(const char *str); +#else +static inline void early_printk(const char *s) {}; +#endif + +#endif /* __EARLY_PRINTK_H__ */ -- 2.38.1 From xen-devel-bounces@lists.xenproject.org Mon Jan 09 15:47:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 15:47:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473753.734562 (Exim 4.92) (envelope-from ) id 1pEuMm-0003PR-0m; Mon, 09 Jan 2023 15:47:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473753.734562; Mon, 09 Jan 2023 15:47:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEuMl-0003Or-QA; Mon, 09 Jan 2023 15:47:15 +0000 Received: by outflank-mailman (input) for mailman id 473753; Mon, 09 Jan 2023 15:47:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEuMk-0001Ok-UG for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 15:47:15 +0000 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [2a00:1450:4864:20::62e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e24e44e0-9034-11ed-b8d0-410ff93cb8f0; Mon, 09 Jan 2023 16:47:12 +0100 (CET) Received: by mail-ej1-x62e.google.com with SMTP id qk9so21190192ejc.3 for ; Mon, 09 Jan 2023 07:47:13 -0800 (PST) Received: from 2a02.2378.102e.bce5.ip.kyivstar.net ([2a02:2378:102e:bce5:dfc0:9312:b994:6b21]) by smtp.gmail.com with ESMTPSA id 22-20020a170906311600b0082535e2da13sm3851561ejx.6.2023.01.09.07.47.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 07:47:12 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e24e44e0-9034-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fIal1kdq10TTB4IAGmI/j0NwEpx7kAoI5BB7eBhw2c4=; b=X6IzhvtXWr5L9CiA8iGBX4kCz93hvBhLwnP8ZtqJPSMr76fMAiVYmZ3vg8QaDnCgvr bzwQrLc6TMtZ/rCzBEcamajk03RWeXoiecRRdaQr6BEVq3QVGvSmZ3MlC0e+BqMEXQ7D T3ddrQktmO/+w4+jQGLGio6IxcQVEM0hiT1o2QhyTMbxG3FPcUJvpUhCOiiiZ1nmG2zy bWsy+dUeI8em63dtTOkABTf/0UGzBUa4PbGPuqqMPH8LUaRugXDXzCjoX2PE26OrEKSj JJrl2u/i6PzGKJf7mUVVvJtbgD75uTEaqsktxMjEgNXnnnV3vZceIWP0OvdthFtZUK+2 +LYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fIal1kdq10TTB4IAGmI/j0NwEpx7kAoI5BB7eBhw2c4=; b=7WHJDpAeOZNYZgFBgcO2Ydv7njRYvGPPJSxFo6KwTfzCSiRZkk5IJCd3XawluLW62k sQbZXDk3wSiJlz4G6XrwUhJY+TUVhFwo7fc6cygYAqy5aBBigi7oarrOYH7V7j0C65g0 RtE+afdI2tqnGWvJz7lqx4jzy3XPB0WIOMm905b82uunhuiQ7xyAy71dz8lOobbOcYbF k6+cfQAQ+FbmPKIqXbf219Z8lyvccXKssLaUMbnFaTNCN40oWMm8VG5XHY1aFybdxhlR uz7IWUuhd/2hdG3TgvJ8e4oCn57RIKY5MpycTAFF5JN8pPM6/eJuQwre1vedPNSTgNnC 34EA== X-Gm-Message-State: AFqh2kppSZQifeejXVtBRYlcnubmeDriv9urXX878EWBIaldsb2QSY5K US5CYU3zDW8VkI759ReQt6EekzcLzDObng== X-Google-Smtp-Source: AMrXdXsjwJwsKL7IqSx/UEmA78Tx6k+7Bgr/10WtTZ8nfNqziQbzWADBp4e3VxAIHznhJt2Cos4E5A== X-Received: by 2002:a17:906:4892:b0:84d:489b:f1b1 with SMTP id v18-20020a170906489200b0084d489bf1b1mr3172007ejq.75.1673279232532; Mon, 09 Jan 2023 07:47:12 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH v2 7/8] xen/riscv: print hello message from C env Date: Mon, 9 Jan 2023 17:46:54 +0200 Message-Id: <837bb553a539713d4aa15bb169142018bf508afe.1673278109.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Signed-off-by: Oleksii Kurochko --- xen/arch/riscv/riscv64/head.S | 4 +--- xen/arch/riscv/setup.c | 12 ++++++++++++ 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/xen/arch/riscv/riscv64/head.S b/xen/arch/riscv/riscv64/head.S index c1f33a1934..d444dd8aad 100644 --- a/xen/arch/riscv/riscv64/head.S +++ b/xen/arch/riscv/riscv64/head.S @@ -5,6 +5,4 @@ ENTRY(start) li t0, STACK_SIZE add sp, sp, t0 -_start_hang: - wfi - j _start_hang + tail start_xen diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c index 41ef4912bd..586060c7e5 100644 --- a/xen/arch/riscv/setup.c +++ b/xen/arch/riscv/setup.c @@ -1,6 +1,18 @@ #include #include +#include + /* Xen stack for bringing up the first CPU. */ unsigned char __initdata cpu0_boot_stack[STACK_SIZE] __aligned(STACK_SIZE); + +void __init noreturn start_xen(void) +{ + early_printk("Hello from C env\n"); + + for ( ;; ) + asm volatile ("wfi"); + + unreachable(); +} -- 2.38.1 From xen-devel-bounces@lists.xenproject.org Mon Jan 09 15:47:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 15:47:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473754.734568 (Exim 4.92) (envelope-from ) id 1pEuMm-0003Vk-If; Mon, 09 Jan 2023 15:47:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473754.734568; Mon, 09 Jan 2023 15:47:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEuMm-0003Ut-7N; Mon, 09 Jan 2023 15:47:16 +0000 Received: by outflank-mailman (input) for mailman id 473754; Mon, 09 Jan 2023 15:47:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEuMl-0002mL-C1 for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 15:47:15 +0000 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [2a00:1450:4864:20::62a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e35c2200-9034-11ed-91b6-6bf2151ebd3b; Mon, 09 Jan 2023 16:47:14 +0100 (CET) Received: by mail-ej1-x62a.google.com with SMTP id tz12so21150288ejc.9 for ; Mon, 09 Jan 2023 07:47:14 -0800 (PST) Received: from 2a02.2378.102e.bce5.ip.kyivstar.net ([2a02:2378:102e:bce5:dfc0:9312:b994:6b21]) by smtp.gmail.com with ESMTPSA id 22-20020a170906311600b0082535e2da13sm3851561ejx.6.2023.01.09.07.47.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 07:47:13 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e35c2200-9034-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=h4Pz1P177MM0Pgd5YIF5gjJ+E47uWjB6mT+S1Msdqus=; b=mvHWZ/Po8AsyALfPQ85VY4fsnq1mIOxUKh2/XXSLd3JqbaJ92Olup/1digm91cv0gC dZd2m45lB+qnUO7N3+Gpcrwsi95TSD6CfQv+6Ep4f/qviDGTQatchaK9RnzN856UYvTM Xt3Mj9juPPGHHILnnAtGCP8COymH5VVhJ5vR+FaxO23lgxlb0ZhBbDxMpsGg+HQ8x8Jb 9+eRg3CdQNLj+QUXl5SAPitFz6YudBRxknhEgxm+FQZ1VmDACgnkUpj2St8/xlCyAkNY KFyWSRmajDq/RxQ3gGmnBhn4XwCHuPqHZJppN41GxpyEbmKR7LPEYAlt3AAe4shjRGEU sTEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=h4Pz1P177MM0Pgd5YIF5gjJ+E47uWjB6mT+S1Msdqus=; b=iI1MeWRHQbc1qwod58ewcEhSs6J8rq82oCNWKkw/ENJ2y6Rwoa3JyW31UTcaQxDXDy 8AMCXrOXbHJUFoIWL0ozGf5enYlSxRHoRbLJN/MJkipxusm6Gp1nW21gZZ5tpcc7kIZd +gM8eCzorMTV1/DyV1A7edcfvUXmuR9FxZdOZ/shCOrAWderQUtKz9BE1ftOH92qTjLq Kp9TKSP5sciIywWKVhbxjiYP180GSANmdA2Q759+G5I2xnhDsrq1VE0cjkVEPBYaAXzV jgZ2TIJKqUSkFtJY03MfksGe9ChQ5rtGdCImvMaiDSn31dh8ByHujq47yF+3jkZvnuhp 7XBg== X-Gm-Message-State: AFqh2kp6LlHRyk3/FPa0cdH00+IrQKFw32TaWLSBt7SGCYcecRAA61sf /GZjhIEYnFE3mX97rx0lOPmMaie2U9kR6Q== X-Google-Smtp-Source: AMrXdXuPy+TC91tuEc1UgylA0Yqd8RJGvEiIih4KUnWHYbKwDvuGdEfAw/R1yhKsNCju7XVZMT5xYg== X-Received: by 2002:a17:907:c007:b0:7ad:f165:70c2 with SMTP id ss7-20020a170907c00700b007adf16570c2mr77178927ejc.27.1673279233938; Mon, 09 Jan 2023 07:47:13 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Doug Goldstein Subject: [PATCH v2 8/8] automation: add RISC-V smoke test Date: Mon, 9 Jan 2023 17:46:55 +0200 Message-Id: <494c2fd1e046de20c2fa24be3989cc6adde8fdbe.1673278109.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add check if there is a message 'Hello from C env' presents in log file to be sure that stack is set and C part of early printk is working. Signed-off-by: Oleksii Kurochko --- Changes in V2: - Move changes in the dockerfile to separate patch and send it to mailing list separately: [PATCH] automation: add qemu-system-riscv to riscv64.dockerfile - Update test.yaml to wire up smoke test --- automation/gitlab-ci/test.yaml | 20 ++++++++++++++++++++ automation/scripts/qemu-smoke-riscv64.sh | 20 ++++++++++++++++++++ 2 files changed, 40 insertions(+) create mode 100755 automation/scripts/qemu-smoke-riscv64.sh diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml index afd80adfe1..64f47a0ab9 100644 --- a/automation/gitlab-ci/test.yaml +++ b/automation/gitlab-ci/test.yaml @@ -54,6 +54,19 @@ tags: - x86_64 +.qemu-riscv64: + extends: .test-jobs-common + variables: + CONTAINER: archlinux:riscv64 + LOGFILE: qemu-smoke-riscv64.log + artifacts: + paths: + - smoke.serial + - '*.log' + when: always + tags: + - x86_64 + .yocto-test: extends: .test-jobs-common script: @@ -234,6 +247,13 @@ qemu-smoke-x86-64-clang-pvh: needs: - debian-unstable-clang-debug +qemu-smoke-riscv64-gcc: + extends: .qemu-riscv64 + script: + - ./automation/scripts/qemu-smoke-riscv64.sh 2>&1 | tee ${LOGFILE} + needs: + - riscv64-cross-gcc + # Yocto test jobs yocto-qemuarm64: extends: .yocto-test-arm64 diff --git a/automation/scripts/qemu-smoke-riscv64.sh b/automation/scripts/qemu-smoke-riscv64.sh new file mode 100755 index 0000000000..e0f06360bc --- /dev/null +++ b/automation/scripts/qemu-smoke-riscv64.sh @@ -0,0 +1,20 @@ +#!/bin/bash + +set -ex + +# Run the test +rm -f smoke.serial +set +e + +timeout -k 1 2 \ +qemu-system-riscv64 \ + -M virt \ + -smp 1 \ + -nographic \ + -m 2g \ + -kernel binaries/xen \ + |& tee smoke.serial + +set -e +(grep -q "Hello from C env" smoke.serial) || exit 1 +exit 0 -- 2.38.1 From xen-devel-bounces@lists.xenproject.org Mon Jan 09 16:00:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 16:00:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473803.734586 (Exim 4.92) (envelope-from ) id 1pEuZU-0000N8-JM; Mon, 09 Jan 2023 16:00:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473803.734586; Mon, 09 Jan 2023 16:00:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEuZU-0000N1-Fp; Mon, 09 Jan 2023 16:00:24 +0000 Received: by outflank-mailman (input) for mailman id 473803; Mon, 09 Jan 2023 16:00:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEuZS-0000Js-Mu for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 16:00:22 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2077.outbound.protection.outlook.com [40.107.20.77]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b780baee-9036-11ed-b8d0-410ff93cb8f0; Mon, 09 Jan 2023 17:00:20 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8077.eurprd04.prod.outlook.com (2603:10a6:102:1c3::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Mon, 9 Jan 2023 16:00:18 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5986.018; Mon, 9 Jan 2023 16:00:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b780baee-9036-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f51LNE/+/DbmVlACFhsNpjEqZxev6I+1p86RVwLGorIztBLPtx9Rc7y54LOa3OvqQDdDpCpFZaJC9Axlqgidbu1r7HAelbvuWFEEuK249jjA/vrMLoi1MrI5iueSTTU6sHCNBJPvg1zZasPC+/Z2kwQ6xO3tPEvP24UV7xQM+ptI5M4EAkyT1rO5bUfo5C7V9TwgAD5YveAXZxwfhUBbK8c0Zt9/7det4Dib8Rn26XsSex7XG55d/Qqs7OLvCMZMmjJaAHQ2OytwqHRZSVMlT9zid6jr+IpZCM68zpesX3TNfJjNapufW5RoLjo/dbTnrhtpLzA4cADkBAvLio14GQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Qkg86uDjDm9pfxdD297SKw77Vr9JODE/mSN58hBFiZk=; b=DuLECOgZT7Sq26TqfS32tedJIy/0AJYaA5ltkclBGjQuXgrChVymGl94E2hINFfr/QOA+TFcO2eyAO1asCH6sAmCr6b4YJg4s8R5+sGoB1F+p8t1L1FhDCt0qEWWo+wIEtcXY1C8UHFnawIFymFySYC39DGZSA26ifv3dP/Pk2rxma9ll6J1YFOSDOFBapMJ/VtDZipUpAFdX63tTCakIoL4DUzqvyleO5vLDebgOCe9mZN+ke5xzoEMIMGrIwkEIDu8ZyzGpmBDs9w/+hUm+ot//mT/w/UCTobbPuQ1krxkjOXgDKmCaB4kN1g+gwE3gLfIIxIGPbGp/9e5q253LQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Qkg86uDjDm9pfxdD297SKw77Vr9JODE/mSN58hBFiZk=; b=fGndejE86VLIzmBonqZdeEizFlivV/fjEW0NFhBoH+GxZUycRNIOT4VSUc/iPMNFmYrjombGB8D5jOSLt8of79+QiKFeGLalSxbHs0W2OZMdrMAn3TilJaGTGKrY4KSHczdI96p7tkjldRkxyyVujoHtPzPw4LA5HdfOraIRiPQeRhmVkhSRlDJiIDq1+con5bJfNF7WNtNdMdQXpejUfe/jBgWvKjl0cMLJYvsHwMB6N6vWRLa+cIdn/93exWPHDO7UnmILLUAZ6pHVhKXiLqjyHR+NXojhqgYH0WZuYey/RTIxAx3ikPjtrfTmD3mjeO2G5HtaiEPCHwxJNnKVqQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 9 Jan 2023 17:00:16 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 4/8] xen/riscv: introduce sbi call to putchar to console Content-Language: en-US To: Oleksii Kurochko Cc: Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org References: <9b85a963db538e4735a9f99fc9090ad79508cb2c.1673278109.git.oleksii.kurochko@gmail.com> From: Jan Beulich In-Reply-To: <9b85a963db538e4735a9f99fc9090ad79508cb2c.1673278109.git.oleksii.kurochko@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0110.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8077:EE_ X-MS-Office365-Filtering-Correlation-Id: 7b7a78c8-7113-48fe-7ffb-08daf25a9a8d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6dX0rWGCZdWJYYSymrIE/Y0NfqEnMN0ucFB9OLmaWDWssfr8ag7OMs9AxbQpBcmc5TDUixtrF64C3d4t+a0vao9MTiHB54NU3SztyQaddgCf7TVS2lmO31Q8FEMBj8p3+aTI6fpFO7H2Na3ySHNHId6w+XP6ohG0V0Ig1bHpddqGnr39uGWLw4UOo/9Nzud3LLwjtk4l1ZMKOKCN0CKyWFTKsns3uyMtDxDZmUEN6xwDAKfsjNg9QNz9FoM08RhOTTENLhssuRyKU9IO7QnRTwDdDf3OgrVu+RkX+RkVoKwuJ2NvAVoia6omU+bE3ZilGFZ7yIAYg/lOqaVbfnNDChEKW0SQxCdm9tXd3G6cY3LlXz0curhwkgHL1vqjvm4RK7dM4G98/BILvx44jhsr7jbn/09MZr30RmKGhjFDr5CQnfbMqKUEtPQ/PnE4GcpfYN4gogvRsjO4MLMDrxXgXf9Ttc1B3m6WlQDfRh1nU0sPny7aCpIM49MDBghll63juJE7gmQ7sguA22lrfWSZpSw3zaZ1sIvj1THYTJj5LaRg9wnkwFl1OFL8H8h0ARq9sOH2LhO8krtU/A89J9E5foH9qmBWIAGJaf41R8ypECILQzTXx5MgL0sAzBy22g1jdV+JhvIcSjfQSdsQAswXRbbSXU49xUyu/qqCvTS1+OhlsBfnw/1HnwJ50+gg3VfD51L53D/fGgekcNSY0k1SuE22R7icDxEyxefKJRVDuCU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(136003)(376002)(346002)(39860400002)(366004)(451199015)(8676002)(4326008)(6916009)(316002)(66946007)(66476007)(66556008)(54906003)(2906002)(5660300002)(8936002)(41300700001)(36756003)(31696002)(53546011)(6486002)(6506007)(478600001)(38100700002)(2616005)(186003)(26005)(6512007)(86362001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y2cybWk1MmVXU1FsZ1p4K2lRaDhTWFdmcnRuRkRnbGdubHVjSk55U1N0amtZ?= =?utf-8?B?SXZlTjN5UnFiRS9kOXh4MFBGbm1KSFcwZ3BEYzNGOEpyVE1IYmMyU1hPeis1?= =?utf-8?B?RmxuUWR2RllvSFNtbXdXV1kxOWIzd0hwTGduMExQZEVXaXhhZGFkTHhqWTNV?= =?utf-8?B?ZE1oVVBra0N6YXcrN3hHSVZFU3hzOU0yaUsyQ213N25LNEYrTytyelF0L2tF?= =?utf-8?B?bE4wYlVDOGJONW9zV3l6UVIzeDNGZDQxN2hZcGtUOUxENGdpUzZ5MXNPR1V5?= =?utf-8?B?Y0VjUFA0cSt4K0NxTXdNdjhPaEl6K1B4VU1FOERpN3ZYdWcxZWZBYjVwTzZW?= =?utf-8?B?T1Z4c2VaZFRQMG9peHc3TjZzWGF4M0tScmRUZGZsZzdxeXhEUFgydU83N2Zq?= =?utf-8?B?dHIwa0tLcFdEeUlkeUhLeHZCYnhaNzFhRFp3RUNDMHlIeTdjdk9aVmtDNk16?= =?utf-8?B?R1NGK0g0dE5BcEw4UEh4UVpaTkFHSUNzVDlDQnlGSlhMZ3RnMVFBMVZZQTgz?= =?utf-8?B?b0Z0UHZyOFo4SHBRRzRJVlRIZklHR0RYRnJBMHB2MFlQWWNSU29DYW9DdlVY?= =?utf-8?B?aWtVeWQ2TnVwYnc0dElkVEplZ2xYM3Vpbys5ZGhxYSt5WkVXWlA4eWs3Zmgw?= =?utf-8?B?Z21PTlZRck9HWFZVbEZ0M2xPQ0F5aDhPckJPck9STmNWUTB5ZWlVSit6MU16?= =?utf-8?B?Sm9IWjRQcGxoODZmZUJpUWVPK211TXdNbU5NNUt6M3hTL3plcVhsUkkwNko5?= =?utf-8?B?Q2NHSUg1aFpPdmtraDBvTW9xM2VzZmtrcW5yWkpFM1FJZ2FUNVNTVmJmdi9k?= =?utf-8?B?eDNwTkRIeWNIRGt2RG5GVVFSd29uQ09aVmhoTXVHUTR1UlVZTDRzNnYwMU5s?= =?utf-8?B?eXVBUkJGVFl1cDFwVG9rWXh3Vzk0eTM2UVZId3NZRnpKeTIzVURGcnVDOTNp?= =?utf-8?B?V1c5Y2ZKbVNiSUxFU05jWWdmbVpwWi9LZENvcmw3anRJNGJWQjZnb25QMzZp?= =?utf-8?B?a1RGaDV2T29FR3VOR0pYanN6L0Fob3lkVGZOeHVkRXhRRmRCQXRCYWhsUVMw?= =?utf-8?B?SGxuZTB3dHAwSWg3Mit6NjZlZ2JxT1g5S2dhdFZYVHlYaC81aXhxdXBIZnVO?= =?utf-8?B?dkRteXY2TEliM0lJSG5XYjVsS0h6eG41dWMwTHJjYVlGL3VLckUrWFRzUEhC?= =?utf-8?B?RW1KcTRvOFJrYnBBRTJUZk9xUmtVM1VBWWhLdmtZUFI4ZHRyMFFzMUYwaCtW?= =?utf-8?B?cUUrR1FOcnIrZWlSWDExa1NaWklhdUNSbTNTYmFFUCtjSmI3L2NVbmhFaUo5?= =?utf-8?B?VmVTdTB4dUM5bFZpdlFVNWZPLzNQRXVBd0xiVmxtUzlhME5MUjdzV1dtNFQr?= =?utf-8?B?OTk0QVZZVk82V0tadDRET1QwUm1EQ1oxa082SzdpTlJDZ1lpc05LOEtxbVUw?= =?utf-8?B?azU1Z2V4MlZxdGRxT1Z5cHZXbHdmVWw5ZVBtQ2YzOUR3SUF4TXcydEp5Q3dw?= =?utf-8?B?MmZGd2Z0ZmFxVFM3bVoyVFVFUUhxeGU5ZlZlVWUxS01UaTF3eW14UE1OWmh0?= =?utf-8?B?Q09Da1RsRThCWis5MHgweWFtOEFOZDU2R1JZbUQ0TGlWMFltRVFnTmc1WWhp?= =?utf-8?B?djBka1FHMlo0WVhqYmxmdWxIVFZreWhYTm5HSE9UOHBmc2tuZW9BUVlhaVov?= =?utf-8?B?eDRONnRrcUt3YTFlYUlNRFNlSmlnb2NySWhPSUFZT2gvRFRzTXZVWTY1Zkxt?= =?utf-8?B?MmRYaVJxWllUeWJIaThPTEg3cW5rdEROZU9FQWVDeHFsU1BJZ1FHZWE0Um1r?= =?utf-8?B?OStEeFpHckFsZVJrV3l3QXIrU1JMY21leHg1bE01eFlreTc3N3hsRGZVTDcx?= =?utf-8?B?MEJIcXNkN1NGenBDcyt5T1RvcVpFS0lYT05nVFBnZ1NmTUpQTHZhalRBa2ww?= =?utf-8?B?VFllM2p4cWc2bHRxTFRPaDhUMWVWTGRJTHVMZDd3QWF2emdmL2ZIeWhxeWJm?= =?utf-8?B?VDBWL2ZxcEVhR0ErOUVMRkcxeFpLUUw2WXVBdU10KzZrbW1vUkk2OUdUdlRm?= =?utf-8?B?MXJjWTJSVWZ6VTZPVndrRGZBSFRHaWZiZ1g4VzdoM1lhWnY0L2RVVXdiOTZI?= =?utf-8?Q?un9Jj2t/dZLs4zxeWm+YQ2Lj4?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7b7a78c8-7113-48fe-7ffb-08daf25a9a8d X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2023 16:00:18.1851 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: txdMB7csWxGp+TjQD8WtPk1neVtl2FqoaVWEtc2T3kNlKBWQRUOpIa5Tu9qHVOVKkRrOoTqh2ieEEVR0CIgLlA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8077 On 09.01.2023 16:46, Oleksii Kurochko wrote: > --- /dev/null > +++ b/xen/arch/riscv/include/asm/sbi.h > @@ -0,0 +1,34 @@ > +/* SPDX-License-Identifier: (GPL-2.0-or-later) */ > +/* > + * Copyright (c) 2021 Vates SAS. > + * > + * Taken from xvisor, modified by Bobby Eshleman (bobby.eshleman@gmail.com). > + * > + * Taken/modified from Xvisor project with the following copyright: > + * > + * Copyright (c) 2019 Western Digital Corporation or its affiliates. > + */ > + > +#ifndef __CPU_SBI_H__ > +#define __CPU_SBI_H__ Didn't you mean to change this? > +#define SBI_EXT_0_1_CONSOLE_PUTCHAR 0x1 > + > +struct sbiret { > + long error; > + long value; > +}; > + > +struct sbiret sbi_ecall(unsigned long ext, unsigned long fid, unsigned long arg0, > + unsigned long arg1, unsigned long arg2, > + unsigned long arg3, unsigned long arg4, > + unsigned long arg5); Please get indentation right here as well as for the definition. Possible forms are struct sbiret sbi_ecall(unsigned long ext, unsigned long fid, unsigned long arg0, unsigned long arg1, unsigned long arg2, unsigned long arg3, unsigned long arg4, unsigned long arg5); or struct sbiret sbi_ecall(unsigned long ext, unsigned long fid, unsigned long arg0, unsigned long arg1, unsigned long arg2, unsigned long arg3, unsigned long arg4, unsigned long arg5); Jan From xen-devel-bounces@lists.xenproject.org Mon Jan 09 16:03:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 16:03:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473810.734597 (Exim 4.92) (envelope-from ) id 1pEuch-00017t-5B; Mon, 09 Jan 2023 16:03:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473810.734597; Mon, 09 Jan 2023 16:03:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEuch-00017m-2D; Mon, 09 Jan 2023 16:03:43 +0000 Received: by outflank-mailman (input) for mailman id 473810; Mon, 09 Jan 2023 16:03:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEucg-00017g-0L for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 16:03:42 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEucf-00026D-JK; Mon, 09 Jan 2023 16:03:41 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=[192.168.1.158]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pEucf-0000hu-CG; Mon, 09 Jan 2023 16:03:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=r0hI2Lg1QMOkm1f5XcDf81indRAxlLTDU1kH8NhnuHc=; b=Eo4/j+cuX2ypI1r2XrbvSsfnBs s/ytfU3ft5EfOTpfO7usvNc+8m6n2A2HxYSHGbIPDAwyP/IHoPbO5CeTz6QAcO8XauYZy/2nXZCIE LKADJrTPaO5wBvsC5VXJ3tVZTxu/nA9gfUj0TqFz6SuObydnTNqTDAO+TYWwbGoTXth4=; Message-ID: <7990322c-639b-38d4-ff6c-221988532c33@xen.org> Date: Mon, 9 Jan 2023 16:03:38 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 4/8] xen/riscv: introduce sbi call to putchar to console Content-Language: en-US To: Oleksii Kurochko , xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis References: <9b85a963db538e4735a9f99fc9090ad79508cb2c.1673278109.git.oleksii.kurochko@gmail.com> From: Julien Grall In-Reply-To: <9b85a963db538e4735a9f99fc9090ad79508cb2c.1673278109.git.oleksii.kurochko@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 09/01/2023 15:46, Oleksii Kurochko wrote: > The patch introduce sbi_putchar() SBI call which is necessary > to implement initial early_printk > > Signed-off-by: Oleksii Kurochko > --- > Changes in V2: > - add an explanatory comment about sbi_console_putchar() function. > - order the files alphabetically in Makefile > --- > xen/arch/riscv/Makefile | 1 + > xen/arch/riscv/include/asm/sbi.h | 34 ++++++++++++++++++++++++ > xen/arch/riscv/sbi.c | 44 ++++++++++++++++++++++++++++++++ > 3 files changed, 79 insertions(+) > create mode 100644 xen/arch/riscv/include/asm/sbi.h > create mode 100644 xen/arch/riscv/sbi.c > > diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile > index 5a67a3f493..fd916e1004 100644 > --- a/xen/arch/riscv/Makefile > +++ b/xen/arch/riscv/Makefile > @@ -1,4 +1,5 @@ > obj-$(CONFIG_RISCV_64) += riscv64/ > +obj-y += sbi.o > obj-y += setup.o > > $(TARGET): $(TARGET)-syms > diff --git a/xen/arch/riscv/include/asm/sbi.h b/xen/arch/riscv/include/asm/sbi.h > new file mode 100644 > index 0000000000..34b53f8eaf > --- /dev/null > +++ b/xen/arch/riscv/include/asm/sbi.h > @@ -0,0 +1,34 @@ > +/* SPDX-License-Identifier: (GPL-2.0-or-later) */ > +/* > + * Copyright (c) 2021 Vates SAS. > + * > + * Taken from xvisor, modified by Bobby Eshleman (bobby.eshleman@gmail.com). Hmmm... I missed this one in v1. Is this mostly code from Bobby? If so, please update the commit message accordingly. FAOD, this comment applies for any future code you take from anyone. I will try to remember to mention it but please take pro-active action to check/mention where the code is coming from. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Jan 09 16:05:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 16:05:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473815.734608 (Exim 4.92) (envelope-from ) id 1pEueX-0001iE-H0; Mon, 09 Jan 2023 16:05:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473815.734608; Mon, 09 Jan 2023 16:05:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEueX-0001i7-E3; Mon, 09 Jan 2023 16:05:37 +0000 Received: by outflank-mailman (input) for mailman id 473815; Mon, 09 Jan 2023 16:05:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEueX-0001hx-0v; Mon, 09 Jan 2023 16:05:37 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEueW-00029Y-Vp; Mon, 09 Jan 2023 16:05:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEueW-00082M-H7; Mon, 09 Jan 2023 16:05:36 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pEueW-0001fP-Gf; Mon, 09 Jan 2023 16:05:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=hzMp4kf7ewhiebxZJhujzGBOUE6QnW3wQl+VrAby+2o=; b=jS04LdynFfKl9FzZzZjaX4fFNw K5COQZ5C6gN7CLpt0rTR/6DNf1JPDVK/4dVzefGxpgXGHqnqXIVnXthflafThAvf8CU3b++eJbZ3R UqKoGTCZqm5unTCnXFeQiyu0jQhVx26akMk4qDqqDzfQ7t0hy6vex7Ee+kntr0Aq+Mnk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 175638: tolerable FAIL - PUSHED X-Osstest-Failures: libvirt:test-arm64-arm64-libvirt-qcow2:guest-start/debian.repeat:fail:heisenbug libvirt:test-arm64-arm64-libvirt-raw:guest-start/debian.repeat:fail:heisenbug libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: libvirt=ffd286ac6f25374d16f4eaa7ff64e30c77541b41 X-Osstest-Versions-That: libvirt=7050dad5f92010720cc8e8b7d5c37eaad7696c5e From: osstest service owner Date: Mon, 09 Jan 2023 16:05:36 +0000 flight 175638 libvirt real [real] flight 175645 libvirt real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/175638/ http://logs.test-lab.xenproject.org/osstest/logs/175645/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-arm64-arm64-libvirt-qcow2 17 guest-start/debian.repeat fail pass in 175645-retest test-arm64-arm64-libvirt-raw 17 guest-start/debian.repeat fail pass in 175645-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 175615 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 175615 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 175615 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: libvirt ffd286ac6f25374d16f4eaa7ff64e30c77541b41 baseline version: libvirt 7050dad5f92010720cc8e8b7d5c37eaad7696c5e Last test of basis 175615 2023-01-07 04:18:53 Z 2 days Testing same since 175638 2023-01-09 04:18:55 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jiang Jiacheng Ján Tomko jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git 7050dad5f9..ffd286ac6f ffd286ac6f25374d16f4eaa7ff64e30c77541b41 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Mon Jan 09 16:07:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 16:07:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473822.734618 (Exim 4.92) (envelope-from ) id 1pEufz-0002Hq-S0; Mon, 09 Jan 2023 16:07:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473822.734618; Mon, 09 Jan 2023 16:07:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEufz-0002Hj-PR; Mon, 09 Jan 2023 16:07:07 +0000 Received: by outflank-mailman (input) for mailman id 473822; Mon, 09 Jan 2023 16:07:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEufz-0002Hd-Cm for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 16:07:07 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEufy-0002B3-RV; Mon, 09 Jan 2023 16:07:06 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=[192.168.1.158]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pEufy-0000ri-L0; Mon, 09 Jan 2023 16:07:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=h+ucAGSqSnprEn74b8uqbOL5dKAdNpX+IN8afJ1FO9c=; b=rQYsFLllnDmUOWkyS6M08PcLTT KiUlNT4fZvPc99ntVY93Siwn7yVKf4BaiLHhEUn5YxYM90N95lDOL8oRlNgPIbjq0hy9Qpqj3NEpM 6nDXSs+Oq4CBxj/Mmzo0d8Wb2YvhPLTzaBzUCG8dh4uBpVJOlsyTZ8nbvptyJ2QObKA4=; Message-ID: <215518b9-7ced-26bb-b64d-5cbae11342bd@xen.org> Date: Mon, 9 Jan 2023 16:07:04 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 6/8] xen/riscv: introduce early_printk basic stuff Content-Language: en-US To: Oleksii Kurochko , xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , Bobby Eshleman References: <527727b2c9e26e6ef7714fe9a3fbe580caf1ae13.1673278109.git.oleksii.kurochko@gmail.com> From: Julien Grall In-Reply-To: <527727b2c9e26e6ef7714fe9a3fbe580caf1ae13.1673278109.git.oleksii.kurochko@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 09/01/2023 15:46, Oleksii Kurochko wrote: > The patch introduces a basic stuff of early_printk functionality > which will be enough to print 'hello from C environment". > early_printk() function was changed in comparison with original as > common isn't being built now so there is no vscnprintf. > > Because printk() relies on a serial driver (like the ns16550 driver) > and drivers require working virtual memory (ioremap()) there is not > print functionality early in Xen boot. > > This commit adds early printk implementation built on the putc SBI call. > > As sbi_console_putchar() is being already planned for deprecation > it is used temporary now and will be removed or reworked after > real uart will be ready. > > Signed-off-by: Bobby Eshleman From the previous discussion, I was under the impression you agreed that the code was mainly written by Bobby. And indeed you put him as the first signed-off. So you want to also add a From tag right at the top of the patch so when we commit it, the author tag will be Bobby. > Signed-off-by: Oleksii Kurochko > --- > Changes in V2: > - add license to early_printk.c > - add signed-off-by Bobby > - add RISCV_32 to Kconfig.debug to EARLY_PRINTK config > - update commit message > - order the files alphabetically in Makefile > --- > xen/arch/riscv/Kconfig.debug | 7 +++++ > xen/arch/riscv/Makefile | 1 + > xen/arch/riscv/early_printk.c | 33 +++++++++++++++++++++++ > xen/arch/riscv/include/asm/early_printk.h | 12 +++++++++ > 4 files changed, 53 insertions(+) > create mode 100644 xen/arch/riscv/early_printk.c > create mode 100644 xen/arch/riscv/include/asm/early_printk.h > > diff --git a/xen/arch/riscv/Kconfig.debug b/xen/arch/riscv/Kconfig.debug > index e69de29bb2..6ba0bd1e5a 100644 > --- a/xen/arch/riscv/Kconfig.debug > +++ b/xen/arch/riscv/Kconfig.debug > @@ -0,0 +1,7 @@ > +config EARLY_PRINTK > + bool "Enable early printk config" > + default DEBUG > + depends on RISCV_64 || RISCV_32 > + help > + > + Enables early printk debug messages > diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile > index fd916e1004..1a4f1a6015 100644 > --- a/xen/arch/riscv/Makefile > +++ b/xen/arch/riscv/Makefile > @@ -1,3 +1,4 @@ > +obj-$(CONFIG_EARLY_PRINTK) += early_printk.o > obj-$(CONFIG_RISCV_64) += riscv64/ > obj-y += sbi.o > obj-y += setup.o > diff --git a/xen/arch/riscv/early_printk.c b/xen/arch/riscv/early_printk.c > new file mode 100644 > index 0000000000..88da5169ed > --- /dev/null > +++ b/xen/arch/riscv/early_printk.c > @@ -0,0 +1,33 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * RISC-V early printk using SBI > + * > + * Copyright (C) 2021 Bobby Eshleman > + */ > +#include > +#include > + > +/* > + * TODO: > + * sbi_console_putchar is already planned for deprication s/deprication/deprecation/ > + * so it should be reworked to use UART directly. > +*/ > +void early_puts(const char *s, size_t nr) > +{ > + while ( nr-- > 0 ) > + { > + if (*s == '\n') > + sbi_console_putchar('\r'); > + sbi_console_putchar(*s); > + s++; > + } > +} > + > +void early_printk(const char *str) > +{ > + while (*str) > + { > + early_puts(str, 1); > + str++; > + } > +} > diff --git a/xen/arch/riscv/include/asm/early_printk.h b/xen/arch/riscv/include/asm/early_printk.h > new file mode 100644 > index 0000000000..05106e160d > --- /dev/null > +++ b/xen/arch/riscv/include/asm/early_printk.h > @@ -0,0 +1,12 @@ > +#ifndef __EARLY_PRINTK_H__ > +#define __EARLY_PRINTK_H__ > + > +#include > + > +#ifdef CONFIG_EARLY_PRINTK > +void early_printk(const char *str); > +#else > +static inline void early_printk(const char *s) {}; > +#endif > + > +#endif /* __EARLY_PRINTK_H__ */ Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Jan 09 16:11:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 16:11:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473830.734629 (Exim 4.92) (envelope-from ) id 1pEukR-0003lx-DR; Mon, 09 Jan 2023 16:11:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473830.734629; Mon, 09 Jan 2023 16:11:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEukR-0003lq-Ab; Mon, 09 Jan 2023 16:11:43 +0000 Received: by outflank-mailman (input) for mailman id 473830; Mon, 09 Jan 2023 16:11:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEukQ-0003li-AJ for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 16:11:42 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEukO-0002GF-KN; Mon, 09 Jan 2023 16:11:40 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=[192.168.1.158]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pEukO-0001C3-Du; Mon, 09 Jan 2023 16:11:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=ZOnG/ZtCnORamGdA/bymsKSaCteFH1kKCRTB4TBz6Fc=; b=2iQODrpyy6jueEd77l8+s2TNcT DPoHF57QnXVobTXb9OQcl5VWpjvL9OGKadgsjrethnUXZOpUn2OjmdfPfTNws3Z3gY4oOcVZidYPN 70k90J5qLSOT3WplbB+6+Buf3CtC1Xpz1yDuzyNmJK3m9IM4dw1T8U4OScRGTGbJUAvw=; Message-ID: Date: Mon, 9 Jan 2023 16:11:38 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 3/8] xen/riscv: introduce stack stuff Content-Language: en-US To: Oleksii Kurochko , xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis References: From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 09/01/2023 15:46, Oleksii Kurochko wrote: > The patch introduces and sets up a stack in order to go to C environment > > Signed-off-by: Oleksii Kurochko It looks like the comments from Andrew were missed. > --- > Changes in V2: > - introduce STACK_SIZE define. > - use consistent padding between instruction mnemonic and operand(s) > --- > xen/arch/riscv/Makefile | 1 + > xen/arch/riscv/include/asm/config.h | 2 ++ > xen/arch/riscv/riscv64/head.S | 8 +++++++- > xen/arch/riscv/setup.c | 6 ++++++ > 4 files changed, 16 insertions(+), 1 deletion(-) > create mode 100644 xen/arch/riscv/setup.c > > diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile > index 248f2cbb3e..5a67a3f493 100644 > --- a/xen/arch/riscv/Makefile > +++ b/xen/arch/riscv/Makefile > @@ -1,4 +1,5 @@ > obj-$(CONFIG_RISCV_64) += riscv64/ > +obj-y += setup.o > > $(TARGET): $(TARGET)-syms > $(OBJCOPY) -O binary -S $< $@ > diff --git a/xen/arch/riscv/include/asm/config.h b/xen/arch/riscv/include/asm/config.h > index 0370f865f3..bdd2237f01 100644 > --- a/xen/arch/riscv/include/asm/config.h > +++ b/xen/arch/riscv/include/asm/config.h > @@ -43,6 +43,8 @@ > > #define SMP_CACHE_BYTES (1 << 6) > > +#define STACK_SIZE (PAGE_SIZE) > + > #endif /* __RISCV_CONFIG_H__ */ > /* > * Local variables: > diff --git a/xen/arch/riscv/riscv64/head.S b/xen/arch/riscv/riscv64/head.S > index 990edb70a0..c1f33a1934 100644 > --- a/xen/arch/riscv/riscv64/head.S > +++ b/xen/arch/riscv/riscv64/head.S > @@ -1,4 +1,10 @@ > .section .text.header, "ax", %progbits > > ENTRY(start) > - j start > + la sp, cpu0_boot_stack > + li t0, STACK_SIZE > + add sp, sp, t0 > + > +_start_hang: > + wfi > + j _start_hang > diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c > new file mode 100644 > index 0000000000..41ef4912bd > --- /dev/null > +++ b/xen/arch/riscv/setup.c > @@ -0,0 +1,6 @@ > +#include > +#include Why do you need to include ? In any case, please order the include alphabetically. I haven't look at the rest of the series. But please go through the series and check that generic comments (like this one) are addressed everywhere. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Jan 09 16:14:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 16:14:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473838.734647 (Exim 4.92) (envelope-from ) id 1pEunO-0004OR-Uk; Mon, 09 Jan 2023 16:14:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473838.734647; Mon, 09 Jan 2023 16:14:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEunO-0004OK-Rw; Mon, 09 Jan 2023 16:14:46 +0000 Received: by outflank-mailman (input) for mailman id 473838; Mon, 09 Jan 2023 16:14:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEunM-0004OE-NJ for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 16:14:45 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b89d383d-9038-11ed-91b6-6bf2151ebd3b; Mon, 09 Jan 2023 17:14:42 +0100 (CET) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 7B72B5C01AC; Mon, 9 Jan 2023 11:14:40 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Mon, 09 Jan 2023 11:14:40 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 9 Jan 2023 11:14:39 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b89d383d-9038-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1673280880; x= 1673367280; bh=1GGy41zJtcnIKoNV4zriEHhvQgYGglkS78ucKnWeKLk=; b=d xXuIip7xiWdi4SBSprYRK10+E0SDAP8/dxuyBD3V7HP3fz75FGDP/06FBGQDR3Dd 681/t39T2kfUvgDqCnzB4JYUOxJGJJyPZ7jFI33ODFXFMXr5lYD43EK/5CcbiK/s XA5aR5iPEbI8n5tV8lanEyiz8+GG1NvdK1znQUwXA5vpYZh2ng0gB23g84j1bHDg 8YI8xIapCq6Ur6QxW7+t/EVQtmrAOglBnNa7sW8VHAu+tIKu9QlCi+GIfeMp5lPp mjICH48JfJUxa3k3FcaiAb9+TjuGeuaYF/Nlr9q/H+g1m1foYDhz2QySwB038pz1 sXfDLz1awrn6Cf422rlDQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1673280880; x=1673367280; bh=1GGy41zJtcnIKoNV4zriEHhvQgYG glkS78ucKnWeKLk=; b=InLrfATdM2Jwxsd1QadJpxehdSzjAInH0f7vQBPu5qmx VsTs9lu3piNkPYHO8R4IQGfZojdaFrnTiIMjjKr25QvttPteQ0R+IId8L+ASnzJ9 makmG32u3Rg1yD6UE6Q23LrR+JRThuJa66cMcVBoGDR8y/5ubPxZcjQ30UYug0s6 UpIXoHAprly1Zw+msRU4cuCMAa8iVL6yV+udrUo1ohZQz19sqPPcIOdnVxS1pVTv 2ckl3OuRlekZHsLTr0OFGz68gC6IIBcBueY2eor+DQOUHwLp2zpZ7jDrqPNIRCHI udF/dTa0UqAuwVHzb2kY52yWuOlBXkn5EpgQ/napdg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrkeeigdekvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeffvghmihcu ofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinhhgsh hlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpedvjeetgeekhfetudfhgfetffegfffg uddvgffhffeifeeikeektdehgeetheffleenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhgshhl rggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Mon, 9 Jan 2023 11:14:28 -0500 From: Demi Marie Obenour To: Jan Beulich Cc: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Roger Pau =?utf-8?B?TW9ubsOp?= , Tim Deegan , xen-devel@lists.xenproject.org Subject: Re: [PATCH v7 4/4] x86: Allow using Linux's PAT Message-ID: References: <9fd0360dd914d93dab357d16b46b4290e6119d30.1673123823.git.demi@invisiblethingslab.com> <2b46602a-f518-c191-946d-3b343b46dc87@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="PuiekJm17OZlMUMK" Content-Disposition: inline In-Reply-To: <2b46602a-f518-c191-946d-3b343b46dc87@suse.com> --PuiekJm17OZlMUMK Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Mon, 9 Jan 2023 11:14:28 -0500 From: Demi Marie Obenour To: Jan Beulich Cc: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Roger Pau =?utf-8?B?TW9ubsOp?= , Tim Deegan , xen-devel@lists.xenproject.org Subject: Re: [PATCH v7 4/4] x86: Allow using Linux's PAT On Mon, Jan 09, 2023 at 12:37:34PM +0100, Jan Beulich wrote: > On 07.01.2023 23:07, Demi Marie Obenour wrote: > > --- a/xen/arch/x86/Kconfig > > +++ b/xen/arch/x86/Kconfig > > @@ -227,6 +227,39 @@ config XEN_ALIGN_2M > > =20 > > endchoice > > =20 > > +config LINUX_PAT > > + bool "Use Linux's PAT instead of Xen's default" > > + help > > + Use Linux's Page Attribute Table instead of the default Xen value. > > + > > + The Page Attribute Table (PAT) maps three bits in the page table en= try > > + to the actual cacheability used by the processor. Many Intel > > + integrated GPUs have errata (bugs) that cause CPU access to GPU mem= ory > > + to ignore the topmost bit. When using Xen's default PAT, this resu= lts > > + in caches not being flushed and incorrect images being displayed. = The > > + default PAT used by Linux does not cause this problem. > > + > > + If you say Y here, you will be able to use Intel integrated GPUs th= at > > + are attached to your Linux dom0 or other Linux PV guests. However, > > + you will not be able to use non-Linux OSs in dom0, and attaching a = PCI > > + device to a non-Linux PV guest will result in unpredictable guest > > + behavior. If you say N here, you will be able to use a non-Linux > > + dom0, and will be able to attach PCI devices to non-Linux PV guests. > > + > > + Note that saving a PV guest with an assigned PCI device on a machine > > + with one PAT and restoring it on a machine with a different PAT won= 't > > + work: the resulting guest may boot and even appear to work, but cac= hes > > + will not be flushed when needed, with unpredictable results. HVM > > + (including PVH and PVHVM) guests and guests without assigned PCI > > + devices do not care what PAT Xen uses, and migration (even live) > > + between hypervisors with different PATs will work fine. Guests usi= ng > > + PV Shim care about the PAT used by the PV Shim firmware, not the > > + host=E2=80=99s PAT. Also, non-default PAT values are incompatible = with the > > + (deprecated) qemu-traditional stubdomain. > > + > > + Say Y if you are building a hypervisor for a Linux distribution that > > + supports Intel iGPUs. Say N otherwise. >=20 > I'm not convinced we want this; if other maintainers think differently, > then I don't mean to stand in the way though. If so, however, > - the above likely wants guarding by EXPERT and/or UNSUPPORTED I considered this, but decided against it. Recent Intel iGPUs are simply incompatible with Xen=E2=80=99s default PAT, so anyone wanting to us= e Xen in a desktop environment must say Y here. Guarding this with EXPERT or UNSUPPORTED will not prevent distribution maintainers from enabling it, because the alternative is building a hypervisor that does not support the hardware their users actually have. Qubes OS is *already* shipping a patch to use Linux=E2=80=99s PAT, so you don=E2=80=99t need to worry that= this code will go untested. And if there was a vulnerability that requires CONFIG_LINUX_PAT=3Dy, I=E2=80=99d rather it not be dropped on Qubes users a= s a 0day. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --PuiekJm17OZlMUMK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmO8PWwACgkQsoi1X/+c IsEJgBAAyuVY6uST5cWxL/JvZwJFwUaxZpys3NuNGGKFciAwb5UF1UBCFcA9DNG5 cACYAq3oU9c2fwVrvz+Rbvsx3F/yLXcbnnJ+3dlnxV3aejcOget52JPwBjC+7RJP HYZwuPk+mObqfNc8DZ2eyfEN3nNZT0dDiGs55EesFpGp46TAuMnt3ajX6GUEl3OT +auxdHKpYScOiObKKz5mklGR0hHRET73NlKRrsJB+Z0J88XYX3m/3kksQyDr51aC n7IaixuvkdQHVFwU0l8AlcPjLmv8mdbb34yg9mDVM4Vf4Kmj3qCAUY/tzCnNoPff RiDjEpaHMft7GdHrbYbk+ArpgE4dtV3Snk19zvUPr5LtYmKUjuGsY1RuxNx5fwDo W73nFH8bfzStX1/UYz5xSbmiuKG4XUsWJ7JUP19hFK6jrA9nm/WnBoCkleYmfKEd Q1Ua0vhwbapH2h5UkWobuy043RaWiH4WP4JN6AsAYqPvGlj/NdrKrFRUNzMfmGtm nziEetZAGZ0sPCpBTcprVGeOMwQitseQyV1OP6qmuyLIbn5P/VL8utzBDS15TUBL OKVLrppiQxVbEUTsa7zBV3UJBnj6NQ27ucbMRRDMxx7FKEBOmkG9CRptiFu2k9R7 qG/z/klN2pKWuR37hrjp9pUdLAIhTofuHzLSc/ybfszgLBvlcm4= =CX+6 -----END PGP SIGNATURE----- --PuiekJm17OZlMUMK-- From xen-devel-bounces@lists.xenproject.org Mon Jan 09 16:20:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 16:20:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473846.734657 (Exim 4.92) (envelope-from ) id 1pEusS-0005AB-KU; Mon, 09 Jan 2023 16:20:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473846.734657; Mon, 09 Jan 2023 16:20:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEusS-0005A4-Hn; Mon, 09 Jan 2023 16:20:00 +0000 Received: by outflank-mailman (input) for mailman id 473846; Mon, 09 Jan 2023 16:19:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEusR-00059y-1z for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 16:19:59 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2047.outbound.protection.outlook.com [40.107.249.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 757287c2-9039-11ed-91b6-6bf2151ebd3b; Mon, 09 Jan 2023 17:19:58 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB7651.eurprd04.prod.outlook.com (2603:10a6:20b:280::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Mon, 9 Jan 2023 16:19:56 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5986.018; Mon, 9 Jan 2023 16:19:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 757287c2-9039-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DS6MVoscLNinHaz1t76NJ7UQfKOcw0J1N9Q3RTH+XjWvX0bjNqqYEgCQoLc3rvdXSmz/Wzpuglq8yaOp5Gsjww9PDjyJgYlV5BLZsulDi+olIwxefB7bZ7gOA0wOOycwzoNDNxoiG3UDXFxUn21wrXfdP74OW9hDhiZL+eyDGOGfpxLeZoLm7NBNxVPeW1BczsyMX0TIuDGoAiY8eTvagRhv2ll+0sEGT/KPGYxXgr8o5WY6dXw7bfkiI7zZYQzmo8aWKPzY9sZ+nn+YCoLUye/MP5oWLBqBTGBRzZnTuFpq8eCoMXhvWnDwka6Um1hs72UaTHYSmxNy0sXROSzbgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+zO+SgpjnIs9Q1ArPETmSVByQZEhBHEBoCmzzLQ0/Es=; b=MAKJ7vpeIruZYkFEWeaaHYatNvAGPzL4NoFLsOAepMcW7YrQxFuMjO1FoR9uA//EVcB+A+K0j9WRoQy5zRdLBiOAsx/liUHqL0RAIpW9/3dH7SSwmURVhNZE8WKKGsreBqeqLVeVWtvE+5lOmYavejgCMG/Y9qdqfTFG6KnxAOgNHzSPFpOlj6j+RyRhDfoDm0D6cfZDkPwAX+bo07TDt7DjshGM+ybuAfKh+7KqtSS9Mb3MhqFTe+75wlauDZlGQ5GsMIw+GurYMaeh7gt6ikew3k5JfzsWdb2hQDelfc2TobaumUnK6ydM8ebvmZpQRxqM8GVJYqhinxwW2neA3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+zO+SgpjnIs9Q1ArPETmSVByQZEhBHEBoCmzzLQ0/Es=; b=GfOzEc6S55qqxZvSvvVFZDQPWwDd3zxDQ3McgnqGEKnWMkXHvM+VwnJ+yERGpn3ZIOkEA0ueQwUcGq0WjO01cUVTD+pjQMD9XKTmeeukum3pZfRXD3mPiD8kl4vBNyvXIlXzY3GI+J/xYVKj6cE0YiUDBAWw9UhQI7+uHHboLaNBMD9pe30ZKX56AQm7AloYESL+vhzQv1fNqeTX0Puo4/A4XjPhxA1HhHzER6go5vpw4ov1qa+zE1+JySDq0dcLibIAodGtWzhdJR8FeL1DV/R+/Ahhcy58fHlbu5gCcnnLKfgD77pWCxJY7+08hwcbipdQKKad52C/6ytOCm6XSw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 9 Jan 2023 17:19:18 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 3/8] xen/riscv: introduce stack stuff Content-Language: en-US To: Oleksii Kurochko Cc: Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0047.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB7651:EE_ X-MS-Office365-Filtering-Correlation-Id: 390b73f8-e9bd-4816-c87f-08daf25d58df X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SEdbCYIQ1+50KBCdHVvliUbscqiyJGwAwUvAI0Um6TCo7jYgztfR+qgU/KN5XBQWuzZ34QBw2fyuyeMExPX3bT5n0zpeztz20K4u+3yAGwiXPFfl8JjjDacDajijUzki39epEkhZ9RnA+gk8BdAUJmb1+ACMMiwdt0bKxSJfU4KmROY6iENqUVNC1O2YFGXEyO91D2SkFlNUtOIZhFmaYo0rMWpKHKkbygHdALdH1X/BHpKdFhyAkA9+uL/6bjMsYAXnfTN7xI58zEtpuOONutvLxaJw3mLCZY/glAs+ikiJIrZz4acG/Vw/7bv7qKPgmTgWpHQC+kRxDUUZJOeF5m1Ygu1hVe8ilk5NB1riJKMh7+TVdWEGJbDI4awY5ctzjlwJiMuZzV/uXfvKR8sdPAPl0VZ/AX00tARumxpY/HUDmR/JvbGu9lqxQjVK7lNXxQ4Kt19OtZuQmpTzlrpP/gr1oFXpB1E5ViGfWXAFlc/8svxLqfAaz5Yc59NzpyV/7exRFiNHxqzS4df1dP4qVB/em58IFK9X/5LGS4DeQvNPPDQjBUVwk8Kpi569ecMULCrjQagF4ZtKyUwlIBJyZk2IJLlwXuTPs8Ka06qMSSMRJNZTsDgONxFXQVr9HBBhEVX94GNcgbykG96xR3wdkQYtVFyVzkkzzX8/T0jf36pktjZuROEVJmjZj0ZcZkGgNKS2m/kodVfQ+BYV548l7cLNvtfksHDL2eTPoAmTKck= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(136003)(376002)(346002)(39860400002)(366004)(451199015)(8676002)(4326008)(6916009)(316002)(66946007)(66476007)(66556008)(54906003)(2906002)(5660300002)(8936002)(41300700001)(36756003)(31696002)(53546011)(558084003)(6666004)(6486002)(6506007)(478600001)(38100700002)(2616005)(186003)(26005)(6512007)(86362001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZDFVUTVOdmtmd0tqVHhIa3o5Q1IzWmNvVlhGYklmNnZocy9Xay95akdTM3c0?= =?utf-8?B?dzJQOW5BSXM3M2laSXUzZU9IMkVyK3A3ZVUwVnpUcUFsNGZWODRkYUR6RFYz?= =?utf-8?B?UTFYRFlUWENGUHlFUUU2RC9ld3lSc09ycS9sSEJoaHNzQ3NFcVlUQ1hLNThn?= =?utf-8?B?d2dScUoyQzhIQ1VXYWdFa2VTdzBFVFhRZlh2MUh0cjJTUFdWbzlOYzhYVkZY?= =?utf-8?B?WFh5akdvZFFjeUJSZmFuTCt3anNlZEJ5eVdyWFFDa3c0bEIzTzM2Rk04eS9i?= =?utf-8?B?bzRCN09rMTlEYTBubVhwN2w2emxwK015VzIwVmcxbXZsSm9EeFI1TWh0WWk5?= =?utf-8?B?RGxXb0xlUWovSXRjUy9rRFgwWnlidW1HUE9pVU9QVWw4TWJxdkd2RlBuUkN1?= =?utf-8?B?czAzWklRMFNERThEZStLSEV4M2pnaTU3YitVTUpmZ2diQ1JaeE83S0pLbkE3?= =?utf-8?B?Y0d0R1VucWsrTGoxRkVCekVMNVFKd1N1OFkvcXV2NjJNeEFlMnU1SGxKY0Ev?= =?utf-8?B?WC9tZUpNdXk2QXdSWDRvbDZkU2M2RGNHZWpMMjEzUUpUajVzd3FHSGE1RjNz?= =?utf-8?B?S0RmMEtjSTZoclZpVHNqVmtmcmt1MjBRMjd2SDlUbzBqUW52STFJTHNFM1g4?= =?utf-8?B?NFRHUmx2c3J3YkQwZ3VJREpGMjVWU3Jta0QxaXNjNGRIS09mSm83ODZTTTJL?= =?utf-8?B?bDFaNHYxRnBVNTNJbjRHaFpacGw0dFJQcDk3MHF2QlpRV0l5YzhlL1hTRUZp?= =?utf-8?B?Z2dkdzFITmVzMVBHdFlnMkVwMVE1YWx0UjQ5UGFscGZPSEhlMTF4R2JSSmZI?= =?utf-8?B?b3BsYlZraHZxNjdPVVRYMEtZeUtEbmNlS2FBbEZiT0dRM0dycEw5NVdzWkhD?= =?utf-8?B?QktsSDhaSXBtSUtUWlJHZjM5SmFtSVh5a1R6K2FFWmZnK3FxMFJaKzZRRUw5?= =?utf-8?B?OE50cWs3ZmZsOSt5ZDhOVzAxS1JEeEZackk1czhjclNrNVA5REswT2FCNmlj?= =?utf-8?B?YUJhdDI4RHFqVGRBcTRzS1k3VkhsSmplUGwyL000aXYxUnFUR0dqYlFGc1dC?= =?utf-8?B?SUUvWEVuTGRnVXFhbldBTG94dnJqQnhidTIyb3ZiZlJERld6VXJvODNsTTBV?= =?utf-8?B?bXdjdnJ6VzhhNFBPRnFLUlJJQzVYR3FQcHFsaW5kV0RZNGI5cCtWQThxWFVI?= =?utf-8?B?UzhyaUlNdGQ5Yk5Rdlg5Q1AvYzlVWVlnTFhsOEtEMENXZGtzSk1vdDJOTW5Y?= =?utf-8?B?bnBIYnlPbDlTZkdoWmN4bDZlZGdRRUhxL2ZHZENDSXdOZVhxYTdjaXdhNTlJ?= =?utf-8?B?dnVKUWFRNjlDbFBWYVIvVXRHZ3ZweEdVUzQyN2VscllaNXhLa0tGUjhtN0NY?= =?utf-8?B?RnFYeVRhclNEMlNOaHFXZ2JtaFA3dVdITjg1RXJ4N0lhVzl5ejZLSjBIS1ZK?= =?utf-8?B?cDdncHlhY2FPNGVoZHVqL0YzZGNwV09TU0FOTEppeFNjZ1ZzY2EzMWU2ZVg0?= =?utf-8?B?cDFUUzRjUVJoRG1nMkVGZXkrdC9JTFNoWE4xK05TTDFyVmw3WFZ1TGNlODBk?= =?utf-8?B?Qmhqdm5wbmJ2SjRpYitTTlpSYk8yazdPRnZHdmZrMmRGOXBQMUxkdGxyZjNh?= =?utf-8?B?MXJwTTVDTjBGeTF0Q3F4azZXYVNMSTNTVXA4WllwTTZhaFpjVXRyRnFWNmhR?= =?utf-8?B?R3k0SHBOY3Bza0U1RDhGQWFCa2I1K1d2dXp5WGhwK3c0MWQ3TlZjY0dibXh0?= =?utf-8?B?WVYvL2RtZG10QVdTZFBnZEdVRHRLYi9jVzVGbTYrallmQ0g2ZzJaOVFhcHBn?= =?utf-8?B?WWdUUkZiWTZFTUNWeXJVS2N1cTgvZkJGTm8rWDZENXQ0NWRiSDFQNmxSVzEz?= =?utf-8?B?VG1PQXkxZlAwYk51eEtDdktNRllnNmpBdGlpRjY0bXd4UXRSRDZsdkRsSHBq?= =?utf-8?B?RDd6ZWJhTUdSeCt4SEY1OGQxY045bHlHRk94bmptUG10L1BFVDdHR2ozTW56?= =?utf-8?B?bTVDTWo1M014Qit2UXM3d29jTXpYcDNNTWkwcmJIWmZ6a0RuRVBTNmQ0ZUli?= =?utf-8?B?cS95OFk1L3hXc0IzNGdKa21FdDFZU2Y1dXhBK3IreWRwOENTd0JRdm9HbnNm?= =?utf-8?Q?uGAuXivF0sOzeYa/CQlrbpxdD?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 390b73f8-e9bd-4816-c87f-08daf25d58df X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2023 16:19:56.5631 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QhTlM6hHPGLJokD2xBSei21hInNYHsIP8cpRe22aCIyIU35npjj53v8FQaLeNA6DjHlqZ27kCAwdDovxmVqUSw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7651 On 09.01.2023 16:46, Oleksii Kurochko wrote: > --- a/xen/arch/riscv/include/asm/config.h > +++ b/xen/arch/riscv/include/asm/config.h > @@ -43,6 +43,8 @@ > > #define SMP_CACHE_BYTES (1 << 6) > > +#define STACK_SIZE (PAGE_SIZE) Btw, nit: No need for parentheses here. Jan From xen-devel-bounces@lists.xenproject.org Mon Jan 09 16:21:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 16:21:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473852.734669 (Exim 4.92) (envelope-from ) id 1pEuta-0006US-Um; Mon, 09 Jan 2023 16:21:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473852.734669; Mon, 09 Jan 2023 16:21:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEuta-0006UL-S0; Mon, 09 Jan 2023 16:21:10 +0000 Received: by outflank-mailman (input) for mailman id 473852; Mon, 09 Jan 2023 16:21:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEuta-0006Qp-AJ for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 16:21:10 +0000 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [2a00:1450:4864:20::636]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9b8143d0-9039-11ed-b8d0-410ff93cb8f0; Mon, 09 Jan 2023 17:21:01 +0100 (CET) Received: by mail-ej1-x636.google.com with SMTP id hw16so9557889ejc.10 for ; Mon, 09 Jan 2023 08:21:01 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9b8143d0-9039-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=mxgcZWNI8GkETKKVvGw9joJznCW2xAb+qxghzX2Za40=; b=lLFP4XvctU/mUmolQf5pX9Tob4E0YQZsrxEo2ehASHnGfI5tkLWoVUqp7nHNWXv/YP JEv+du/aGO3LEuLqPcO6jSF6KBFBqz20VHSbnh9KIi6hObv7sxv25TkRRFiy+i4invC2 JpE1Xw5W8zGSoFCMsZcmvUeO89PR+lCw3J148= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mxgcZWNI8GkETKKVvGw9joJznCW2xAb+qxghzX2Za40=; b=b2UumJaGoVesuiT4DhaExh/vdNoGj+MM8BYTBqTE4fVf5YKJmUPm0FpZLrtTCAASnI LQUMVsov5b40XJqNgESUFoakoEW8p0ILOVbwzYSzc9R8Dcss0a1A8pbv9nfriNO7tIqc Kjs9XJ+M7HHGWTHXEUaUv58sZSaBJG05f4HNpnOngUIqZ/hc7KFRVP48amOLPTVjT/k1 jfVHZs2NuziLAWk77Cbfr/shkFeYqWqgJIK3hs6mOYyg/ShrmGVdMe9egr5xF6CxoJiR AmU7VK/cErFsl5FxCxt6pIuKV2M4LrG9PSENnN90FcwlsbfR27aTobS6PqUCI6aMztQ9 zcaQ== X-Gm-Message-State: AFqh2kqFvh/vPEa26znwrSh1B0DtgwmtFMDQvgUEh+pR321hqAgKJ4Z9 hVJxSjg1ISoy+Pfr3825d5xYJI0XWdX1krGsQT4lVQ== X-Google-Smtp-Source: AMrXdXsZrHw3jRmSmMYwJi/qT1DFme5rV5+bvSZRUUeAggiRXKQmsZUj94ky1Tdl8MeZJsZYCO+U/5GPhFbdR+JjtoY= X-Received: by 2002:a17:907:3987:b0:84d:3721:53b0 with SMTP id sr7-20020a170907398700b0084d372153b0mr599785ejc.534.1673281261204; Mon, 09 Jan 2023 08:21:01 -0800 (PST) MIME-Version: 1.0 References: <20230105132004.7750-1-sergey.dyasli@citrix.com> <55cccf9d-e4c9-6dec-ee9d-fec56f521931@citrix.com> In-Reply-To: <55cccf9d-e4c9-6dec-ee9d-fec56f521931@citrix.com> From: Sergey Dyasli Date: Mon, 9 Jan 2023 16:20:49 +0000 Message-ID: Subject: Re: [PATCH] x86/ucode/AMD: apply the patch early on every logical thread To: Andrew Cooper Cc: Sergey Dyasli , "xen-devel@lists.xenproject.org" , Jan Beulich , Roger Pau Monne , Wei Liu Content-Type: text/plain; charset="UTF-8" On Thu, Jan 5, 2023 at 10:56 PM Andrew Cooper wrote: > > diff --git a/xen/arch/x86/cpu/microcode/private.h b/xen/arch/x86/cpu/microcode/private.h > > index 73b095d5bf..c4c6729f56 100644 > > --- a/xen/arch/x86/cpu/microcode/private.h > > +++ b/xen/arch/x86/cpu/microcode/private.h > > @@ -7,6 +7,7 @@ extern bool opt_ucode_allow_same; > > > > enum microcode_match_result { > > OLD_UCODE, /* signature matched, but revision id is older or equal */ > > + SAME_UCODE, /* signature matched, but revision id is the same */ > > NEW_UCODE, /* signature matched, but revision id is newer */ > > MIS_UCODE, /* signature mismatched */ > > }; > > I don't think this is a clever idea. For one, OLD and SAME are now > ambiguous (at least as far as the comments go), and having the > difference between the two depend on allow_same is unexpected to say the > least. Sorry I missed that "equal" comment which is easily removable. What I don't follow is your concern about allow_same. It's already changing if OLD/NEW is returned and my patch makes it SAME/NEW. > I never really liked the enum to begin with, and I think the logic would > be cleaner without it. > > > We depend entirely on there being one ucode blob which is applicable > globally across the system, so MIS_UCODE can be expressed as returning > NULL from the initial searches. Everything else can then be expressed > in a normal {mem,str}cmp() way (i.e. -1/0/+1). This idea sounds good but in practice there are vendor-specific functions which return enum microcode_match_result and I don't see how it could be easily replaced with NULL/-1/0/+1 without code changes. I also find the enum values easier to read. Sergey From xen-devel-bounces@lists.xenproject.org Mon Jan 09 16:22:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 16:22:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473858.734680 (Exim 4.92) (envelope-from ) id 1pEuut-000748-AV; Mon, 09 Jan 2023 16:22:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473858.734680; Mon, 09 Jan 2023 16:22:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEuut-000740-5s; Mon, 09 Jan 2023 16:22:31 +0000 Received: by outflank-mailman (input) for mailman id 473858; Mon, 09 Jan 2023 16:22:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEuus-00073u-HU for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 16:22:30 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2040.outbound.protection.outlook.com [40.107.22.40]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cf5acc09-9039-11ed-b8d0-410ff93cb8f0; Mon, 09 Jan 2023 17:22:28 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8829.eurprd04.prod.outlook.com (2603:10a6:102:20c::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Mon, 9 Jan 2023 16:22:27 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5986.018; Mon, 9 Jan 2023 16:22:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cf5acc09-9039-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MT2kpAYyIb/PIcLodx9f2xKXPnIjq9crKeuRTXuRpSIhNlkQqC1kBuOm0MQHpA0zL1USfCJ1LYmPdov+zP4SaKpy9YojJQcLMpWWKE7ZFNvLQJS5YrJNLuIrpg5/Um0bMHt5Dq2J3XGiWWZLqLmfkF8jcxOfhUpDGfu/SkMdOvvG0/HmkdzzBtveCxQDaFDZkNQe+hsLXtLUrKsd2gPF01ueXQUMQHM/2TYfKwdhkCYSJOKqPpgb2R89LY4gKbOP9V/wap/a/BdJuM4rdzwVPUnouBp20CNr6aW84So2IRJOMbUsQ2cIq/XkGD0v/kmV1ipk1oV3/alSoS+gxHsirQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FgBFsUxeRhZbi1wZLbZ5QCUDhhErovrhDaq3a7acFbg=; b=URfuJg7BpvKIEp5dN5uKbFQKXAemcDE8iXZONegRu4dpmSeeWFFA/AwF/2O30/zzVWKTqdmZahn1Pr14HfY9PQKt3JuBJS3tl77NGjyNR/sn8qhVm5agoiCrxEuZtypIkp5BZlpuwQaoo58ttLFkhsnMCD/7YD9gJI+5IXHpf0bow3eFuq2vHoIKbrtLKXdyWrjHqoxYqyfHgCImatNkE8NI8QIuX6r4pvwRctk4yyoNyVqCAwVDp//EiZZleD1tuc+28jmGWa/Fhr6FMjgpMMAQ+lpv+Rd5SL9S6xn5j5/Z5bFnQ3C2rexPw8dIhqZ8rV48eDxNcKU6cHm76EwF/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FgBFsUxeRhZbi1wZLbZ5QCUDhhErovrhDaq3a7acFbg=; b=W4PlZbtl7C/DaYSVXQkhCsTKFlr5+dHyjazXnTvg9/RBu1TC10eT/3udjsuQABS7Jov6TVjvT8PIpMyHFG7OLNxYFols7IM1jGX3cRjyPKlemgjHUf+5B1OayVdAc+ta8KyxxMyouaMiEhEajNpH00BcmPt8f6jxTW/H1A4me+97kc7M7iK2ob0IinEBcpCokdV4T0MIlg2YMamaian4ZR0570A3fAAZvZcf1dHHoo3R+nc4nj4ZWt42mp/Bgz6gSAzm0F7PF/O16fes6U5h6AYfcD20yUS8lBASaxvmqNmwJ3PkFDgrhZWg8dqabC1kIEoAyzI+TQyFDguGF6inDg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9bfbfdc1-e3e8-a634-26b2-eb48c5e1d646@suse.com> Date: Mon, 9 Jan 2023 17:22:25 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 6/8] xen/riscv: introduce early_printk basic stuff Content-Language: en-US To: Oleksii Kurochko Cc: Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , Bobby Eshleman , xen-devel@lists.xenproject.org References: <527727b2c9e26e6ef7714fe9a3fbe580caf1ae13.1673278109.git.oleksii.kurochko@gmail.com> From: Jan Beulich In-Reply-To: <527727b2c9e26e6ef7714fe9a3fbe580caf1ae13.1673278109.git.oleksii.kurochko@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0084.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9b::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8829:EE_ X-MS-Office365-Filtering-Correlation-Id: 176e1609-12cb-4a7e-cb53-08daf25db292 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KrnoI/kqUIr3j7d2lUizfM8cRAfi8UyFv4zJnKIo8Fu3Kx3V1EG3yo8btWUe6dxDTJgb58Lourvb3XX5AEYvR/AjRiFfpDiaMJOwIcITVA3ImsodXSLd05e9HMxHCO/oJp+EUOP3KefJ1lgWjvRYA9+He8XiQc9CRlh7txxnfOJY2et0HvQI0W+wKI39P5XQcHYTSXLfi1I6MTpk4oZVwg77HB2vo/Z3vfxF8ZTNQMTwti0r94u/OZqB7vzgyNWTtltWYoFiex4bLm82bnoJoDNkt29E0l7uTzud8ABfawMwcTiCfnOhK6K5OoXqNlueEnZIWCDnvwoO4cIDu3BzIYvnXx2cRN30g9iMRohyInkjQNBRrnlPNfkltcrg0Ak0t5bGAzjgs2boxJRaRZK7mWC9EBx9ifYFf9zXifRVxSn15FHeLfUpseJJAeN4YVkUQi9rnlpkRIi1TaifOTk7WwZ4355Uj+DORaaQw6nzd35Md6anEn9qexfCPbpIe2AhEQfnfI8Yo2efCeRWioUSM+43MWAiZ+zV2XR4/RbbqLUzCBwbRA7i2UtESi0NiLwVS5uNiyn/f9ixhYZgHsmf+oCP9w+OgFQKKI4TMI1xBIPCC8kOn1KzlhXdKd33/03Dsn30NTPLPl44Szq+pifY9cRg1DwXV00JUaNSRmomk+oUxrpGyILCYWlDuu8avrJyKWG6fZug/+PU59XeTe30EGDTFHr1zKM7Jd4KokgHjBI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(396003)(366004)(136003)(346002)(376002)(451199015)(36756003)(53546011)(186003)(8936002)(26005)(6506007)(6512007)(2616005)(54906003)(66946007)(5660300002)(7416002)(66476007)(66556008)(4326008)(6916009)(316002)(86362001)(31696002)(38100700002)(478600001)(41300700001)(6486002)(31686004)(8676002)(558084003)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QjRXL25QZitDT1ZnQjBKQUdwSDYyOHYzUDIyV0pRaUJBS2RCeFVrVTRmaHF4?= =?utf-8?B?U3dvQ2hvM2tOT2lkWnp0QVk3YmFyb1IrVEt0NDRzeW5hMHcxV0ZLaTg3Ymdl?= =?utf-8?B?REIyc1NSREd0SFVrY1ZucnZNVHdHVGxnOHp4UUlPZTNYd1dEN3VxcEI2OGxq?= =?utf-8?B?Tm5yLzJNSFJTa1hJWlFNVkY3T2pXUWNtaGNMdCsvcUU5Y2dEYU02THdOL0o2?= =?utf-8?B?MVhiTCsyMUxidFdrTFY5dk5sK21FeDRBVE1MVFdFSzRiWk1kbXoxWkdnRUNE?= =?utf-8?B?TmdGbm03SkJGVmp2YnlvRFIxV0NxZVlwTmdMNElDQTF1ejcyR1doOVVURXAx?= =?utf-8?B?eUsvSGcrWlpiV1M5d3h1YzFuSW9vcUppb0VMZVZ5RjJHcmRUSUxlQ2cyckNo?= =?utf-8?B?WE4vRm1FclNzZnNMNXhuQ3hvdFVwZ0VBeWh1M1JFRW8yUnNpenlzVk9qUW9U?= =?utf-8?B?bGNDdzM0M0lqRUUyN0RmNkVZWk56blBUWmg2OVNkSytMYTZBeWk3N010eVhZ?= =?utf-8?B?RXg1VkpFR0ZhcWV4cXFGeDE4YWJoYmFMRlZIaSt4T3ExRzNKak40WDhCZllE?= =?utf-8?B?VzRJWWNXczlVRHkzejZrVi8zNXQ5MUtiTVNOejdJS0NrOGNsOWNrMjFaNEhN?= =?utf-8?B?WlBicG8zZFl4MCtEbG5lZFBlbXRza2ZWbjY5RDhOeVZGYzB1MVRtVzY4NUx2?= =?utf-8?B?SUVmWHNFR0xBS2xjQUtYb0x0K0xjcllPZHpIdThudUFJRTdMR3UzTXhwbkV2?= =?utf-8?B?M0ROT2ZscUY2V2xPNlluYjBIUkFNQXhRUkJzU0RldDBPNmFoSkE1M1RhL1JU?= =?utf-8?B?YnM5dEd4NG92ZVFBNDlkOTd5VHh6bFAxeEJ1Zk0xRFZtS2M4Nktlb2VTb1d3?= =?utf-8?B?UlQvRklmQk52MUZEZjBMZjh3RnZ0Y0g2NytSQmVMRHV6aWl3OXB5dGljU1pu?= =?utf-8?B?MXBZbC9hS0d6NUtxYjJKeFpPUFpLRklsdlhvWDhtblNJY3FSUVRsVWR6Sklv?= =?utf-8?B?bEtMaHNabktGQ3dhNXJ4QzVBT3N4ZzhsSTE2QU1iRFpsbW9hbUZRQVI0MFBG?= =?utf-8?B?Y0ZnMnhmSWFGc0ptMlAyRUgxVk9hWmRWczVvcUNtUFo4c21odzVKL1hOalBS?= =?utf-8?B?ejBXeWdDRUJ6WFBtc3hKOHFkZFFtRDZML3ZQSG9RMlFMeUk1SCtKOUNqdllZ?= =?utf-8?B?VTlMUUVNQXNza2RzdVZJaVViejc2YlozcnNuMWcvcEFvNHVERHRXbm5vVGlQ?= =?utf-8?B?NTV1Mkc1eUxQUVB1Zk5IV1R3SkRNQXlYcElZbTdtSzFvdjVjT2JKUEFqcFMw?= =?utf-8?B?ZnhPUkJUa1hjTEgxL1k4bEtMZzZ0c2VkRTRVWVBVZVRTU0FnWjMzSDY4Rzc1?= =?utf-8?B?VUlhcTg3RGFBaTJFUDBCM2ZoVStxS2pYT0ZEK0l4ZG5RcnJvRzd1U3Bvd3Vm?= =?utf-8?B?VVBMSlVxYi9BVXlaOFcySFR0SDYrT003R2dRRzN1dUk2azZYajMzUjNTWDh2?= =?utf-8?B?cHVNUU1jMFR1NXB5THhBNG1jZFdFTXhSbFllUnZ5R0pLNjJDdklveVhMSWpE?= =?utf-8?B?VXBPWGJDeVYzN3RIYktPT2xKbFlhdW1IRlAzOXZOZWxUbm5GSU55L3hIQkpq?= =?utf-8?B?cWx6ZWEwbWo0UUZQdzlYaHRWTU1tV0NhekdIQXZwZWZGMjBiVStFa2VWbDRY?= =?utf-8?B?cGN2SnVFRnU4TkgzTWovWmliMVdjS0tEK1hqNW9sdmVGeUd0dDlOYnUwdG1F?= =?utf-8?B?SExSdVhaYWpqWXhubDFMaWd0cnE5ck95U2FCV2tnUmZsSzZNZHFDM09DUzM5?= =?utf-8?B?M0hoV2FmYVpqUVpDZ0F6cmU4cFVMbCs3KzdTQTcxS1FHMG1sL0tTRmlndjkr?= =?utf-8?B?dTZuMkZuaU10Z0dIRVU3TXpZalVLQUlMdFNnL2srNmt1UXFGZU1VWnJuWDdt?= =?utf-8?B?azlBU2x1WlJkN3YxVTJvY1FpcHYvQnFOSjBEU3dVWkRUaFRtcjNUSitNQzRv?= =?utf-8?B?YW9tbVBJSnpIdUpqQTRGWHc5OHl4TUNvYm1MUTFmakFUcUUwa2FtMDgwVVZh?= =?utf-8?B?Tldvc2MxbkdmRUU3VkZid1RWZ2haNzF6b3N3SC9zTkZrNUxySGZXd082aS9Q?= =?utf-8?Q?KvNgpBkwlzzP43U8+EVLrhc8y?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 176e1609-12cb-4a7e-cb53-08daf25db292 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2023 16:22:27.0066 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LxMaC6Ei2fcjh8NVJxyDT364JilGtcpojPVmFJ+GASxz2Brsr27gYVZZh9TJhG0vI4KPOiU6OofCv5c+HGhlEQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8829 On 09.01.2023 16:46, Oleksii Kurochko wrote: > --- a/xen/arch/riscv/Kconfig.debug > +++ b/xen/arch/riscv/Kconfig.debug > @@ -0,0 +1,7 @@ > +config EARLY_PRINTK > + bool "Enable early printk config" Nit: Stray "config" in the prompt text. Jan From xen-devel-bounces@lists.xenproject.org Mon Jan 09 16:30:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 16:30:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473864.734691 (Exim 4.92) (envelope-from ) id 1pEv2l-0000AX-3Z; Mon, 09 Jan 2023 16:30:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473864.734691; Mon, 09 Jan 2023 16:30:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEv2k-0000AQ-W2; Mon, 09 Jan 2023 16:30:38 +0000 Received: by outflank-mailman (input) for mailman id 473864; Mon, 09 Jan 2023 16:30:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEv2j-0000AJ-8L for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 16:30:37 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2088.outbound.protection.outlook.com [40.107.20.88]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f1bc7c91-903a-11ed-91b6-6bf2151ebd3b; Mon, 09 Jan 2023 17:30:36 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8882.eurprd04.prod.outlook.com (2603:10a6:20b:42d::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Mon, 9 Jan 2023 16:30:34 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5986.018; Mon, 9 Jan 2023 16:30:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f1bc7c91-903a-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P08qqfpkV3nR2yLxeo2XiTX3EaTtPuUaTcZvOnfdakfF1TDN9MWn2flYaMXEQIMRVCK2GurN5tnFxcRJ3Is9lOqP9RwxL3ZjbfjfkDueRoo4nnFDPzwoKY/m84NNQRd45qvVL9q/uWNtk6sXw4q+JqLurJFUkbvoFW3yqznsCfXWMFr5OeXTKUqBhVudlNIXttNuxJASFoYriEaoYZwSbNRbvqm/uK6SB9DrKD6DzDxPEI662cSav/cCqZc0Z6wabJ3lZ4Q1g9CpJB1TjPl0N0F8oU43gLINPkCk2ks1ynXIS1F1EDKIK7kCTTtUjuQ+XgIUwZ9cneiyaJxk12Xytw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VgMU/SgV6KX0g0UGb94kr9WJ66aNKxszDwcL6jaddWQ=; b=FszD5OIaCx1xFPdMxglqcygRyVkvtpM0CzZzosp1ot8qsZhy9vTN2e+Ae+V7hyQDqSHafr3ntNXbhGUSFq0e6+v0J4NaDZKKQMwMciZuH+9s1y7LFpONvX8zKtmydwvJjdHXrQnBUzPnIN1NoLA8+oqas/N5akwoDngc44Fek+ItQ+trCY5e0gnq1/ZSeaaoA8XoiYatvMQ6PvK7O5ckcprrw388/8rI121gJEHSN5VB0180EXsdZ4agO7CVBfUGcpGwEqoVaRz/hHsr/WSGK/eNrWhEmUHSqxXDNFmPiGQGcKLMh3nlKMIqaQxXSvdFxQmc2I3emQm/FTXhOGIskQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VgMU/SgV6KX0g0UGb94kr9WJ66aNKxszDwcL6jaddWQ=; b=ENKrlq++bOWJaC/Wl58fYWYUu3Wu9R/XP/Q/aaFr5PDlFRBiM+vPkCbJ/HTI5rPhb5mkFgkyYSpbpI06Zr3byrjZe5MNC/JncpkSdD8pTDRgRG4bQjedHaAFHBTt2F+d9dY34YqBs1KPnX8w7FKp8EydwOax6oz0I0ShaTSKdK3nPW5eqYuab6Zl6zlxKkpareOa2VhYH4jcPIP0KTK4dd7qUw9OSv6ym2yBgTAgPB02wOm3c0EnLk+80TATSY1FMxrlilMO45VxoQ7frsrCyj0g4TkV/XhVgXOkIhqgKpq9pxu6knpNz7JPKWvfh5Zc6q5wRonsc4ccd6y715oESg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 9 Jan 2023 17:30:21 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 2/6] x86/prot-key: Split PKRU infrastructure out of asm/processor.h Content-Language: en-US To: Andrew Cooper Cc: Roger Pau Monne , Wei Liu , Xen-devel References: <20211216095421.12871-1-andrew.cooper3@citrix.com> <20211216095421.12871-3-andrew.cooper3@citrix.com> <427dc257-b318-de55-7126-0446264401f8@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0002.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8882:EE_ X-MS-Office365-Filtering-Correlation-Id: 986730dc-34ef-4064-0ba9-08daf25ed4a7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: t2xMNLbuWQAsK5GJPk9m3ApsT/QG3Xxs8AAdEzqigA3jQD6oLjVjGhAwNeJtdffzMrwzk7SF7sl3j2qhht+ax8TriouXhoBszY73QaRX4zQtTOXH+XDuYsEq/RWnLQgkQzjqIFNdCxbdiLaEURfsVmXI/bpF338sVOIUpkML9c1nyQfed7HfP38F+hO3MPQLIyVgK6TxmG6xgvmx3cMmhVVQd5jXFl44ZXb60AMhzZP83jUzbgzV5R3VdOSPvdcZX/c+ywktzPWEUKaRxj5w3tOFdnBhZvwjYQ3thZE4cQkP66MJ/PzOs6tefF3X+Rbx0tTZLuxbM9OMwsI21UhGtEQmMwjZo+o6in/6RD5FaWxM0w7P4OgdV6YN7vQzTKLwJu+dNtFWEsaC2USUhYL1Hw8ez8z1rtyOSClSElUH73etAiLa8VelnSCDHJLzIewlSw/Osy0xN70VE6pvv8JiprsTCwTM4gQWH0nEtHt9cB73/VkGd4ddYcoltvWEKC61LaZKIsdHayA+mczjAa2ukngHLeK7mgw4Mbtrwg5bpJtMfhfQD3NTvs7sZNGlDDNhd2jJP0yGEEsnY81m2SgVTND2VMbOXRcpTGzvLTZHJfz7gqC4U4tUakYGSVvf637EayuEABttL2DiG+rRpEFXud9tiVmtSVptB4mDlDpG9eQ4ydaVqoWU5Lv15Lh6zW8XsYXcnInp5MQSMmR+2vY5ms1K7JI1jd7M2QmMqewu1Suar5ufMFpwHcG2es4T4JrPx5A0xhND/F0j8Ftzkh1vO3YiUUFML4g2qcQPGqcePpI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(366004)(39860400002)(376002)(136003)(396003)(451199015)(8936002)(2906002)(5660300002)(41300700001)(66556008)(4326008)(6916009)(8676002)(66476007)(316002)(66946007)(54906003)(186003)(26005)(6512007)(2616005)(38100700002)(31686004)(86362001)(83380400001)(36756003)(31696002)(478600001)(6486002)(6506007)(53546011)(6666004)(2004002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SFA0WGZlRDZmaE5sdFRPOUlpZmtoNlNSZ0lFQk5sL0lLWnFNakR1WEpFd2ky?= =?utf-8?B?TzB2Yk1rTEt6a2liRWVvTnpIL0k2STRjWmVDcGtzYnJ6dXRhaklFYmpMdE81?= =?utf-8?B?TTRyV1B2OWtaRVRPczdkc0pta3ZxaGtjMUZOSVYzY1hqY0QxaEZGNmI4YVVX?= =?utf-8?B?VlJaTmwrR1AwSVdlZExzTUN6bmhvSU5ub2RkU1dETUhiUVdYbVlyM3Nod1Mv?= =?utf-8?B?akpNUjRhZWpUbnViUlM4czB2Rk1oeDd6TzRteTQ1UEVqb0lDSFg4SGhXREsv?= =?utf-8?B?SytKTENlSHU4elI5YXYxSWl5R09FeG5QWGhlSTRUKzFZbkszZU4rcmE4M0FZ?= =?utf-8?B?dnNXTkgrcWxSZVhxczU3Tk1FKzlFYUVsK0lLb2ppU3ZMRExIQURlQ3BDSG00?= =?utf-8?B?RHFBNnBRTHlqaWJWMUtvN1JYSllTYzd4UTFNWFdORmpnN2FhSnNSblJTNmk1?= =?utf-8?B?NEJTbHNzYmswNFlHblFzVW1UUmdmYjZ4cTFvRVRhUktITU4vOHJzWWVlUzVM?= =?utf-8?B?TDh6dExabHhKSFlBc1grMXJCeHZVRmE2dVgrTzV0bUhqdG5iY2RmK1pTKzNp?= =?utf-8?B?YXc3dVpldjk4TlA1akhGbzRja0l4QXUvWVRBcUdHcjIxNTNsYjJwanl3RStw?= =?utf-8?B?YXQ2YVBKNjVpZmk4dzRmb0Rnb1dGYUtldGMzUUVBeElJTFJqQW16ekJFTlJy?= =?utf-8?B?SXIvZFlqWmNKWmd2bktPV1lEOUdYS3J2N1pqL3B0MUF2T3JUd2Y3aDZwbWxx?= =?utf-8?B?V3hldXo0WWs4NlprQ25URS9SMGdUTDVtcS9YaUw5VVBSVWJTZFFnZmljV1RZ?= =?utf-8?B?dzk4MU9vL0hiTk52ejlZZTM0YlVGRDJOMWJ6MW85eG8rcG8vcW9pT2hiQkNa?= =?utf-8?B?YWxDandnV0h6Z2RtTjM0Snp3QmpkOEQwQTUxK05tWjhnM0x4b21HTHY1SUlr?= =?utf-8?B?c3BjZCtqQ0NwQnhONFlDVWQ3SEJydTVrZVNZeDQ1Ynpoc1VLeTJiZVVyQlJl?= =?utf-8?B?UDgxeTF3cEVLRTZPUG9zK1NCczFnTHNlN3lTblFvUVNCY0pnVktuaXgyREpU?= =?utf-8?B?c2NodEJnemo4dWs3UG5BRWUzNytVcnZzR2tFakdSa3VzTFVNa2IybEtqNnBP?= =?utf-8?B?cEZNdHhwVlc2VlZvN0VjQWlqc0NlaVJTRWh5czhxM3pkV2E4Mm5iMHNmYi9K?= =?utf-8?B?dk43Yms3R0dyZEkrWUhEMXdDV0pveVlwcjVYMjdnQ3ozZHZCNEoxMStQbGNw?= =?utf-8?B?Mi96cHNka2hTSXcwc3dTMS9ValI1YmR0UElOTnBTTkN5YUxkRGhRaTZxdTVE?= =?utf-8?B?cHl6SW1McFVrMFE5MzM1Z3ZPTndZenJ0M3hKWGRUL3Y1Z3VqVFZ2cDNyenVI?= =?utf-8?B?WEdXYWdrcnltK3ZnNUh6aklDQW10Qzc1M21SQUZneWQ0NGZwbEVFRjJWT0l6?= =?utf-8?B?MzFCSll1TUhrc3JyR1l3Um5idXVMZ2pqbGF5WXBQM3lkUnpqU1dRRTA0TGxt?= =?utf-8?B?MGZvczdUb3Q3VkMyZjl2R044Z25wTXo0UzBaY2RCMFc2TktzQjE2VXZscS8w?= =?utf-8?B?VE1zc3J2a1RMTEEzMHZWNlZHL2srR0cwRHBrRmN5L2RrMEFNR0NxN1ZJUUdG?= =?utf-8?B?WVFEdlgvV1ozMEJEcXB1T1I5Yko2NGExSHRmc0trQzZuVFVvRnkydEQwL3FD?= =?utf-8?B?UlZsZVFNRFY0Q1Q1WDFKTUVIS1NCYXJ6c1pZQlpBVzJFcjczVWhFZ3lUa3pE?= =?utf-8?B?YUtDMWxacmk5S3lqZkFuTmVYdkJPdytqbGxBTmZtVGs4UU9TVitGREErbUpW?= =?utf-8?B?R2hjeWlKT0tWRm9FZUpsVytrNTlxTU1TU2U1RzJ2R2NtcU5wSFdCcE1RQTVo?= =?utf-8?B?cTZFdHdMNllHUmcxU2dOQ3l6UkFGaXEwK1ZMeG4wTHZ1azc0QVRkTGUwN3dN?= =?utf-8?B?QllSU3NNZmwya1hDbmdCRWU0L0N5ZVpvNUlrbDBtQlo3YXd2VXhRZ2Q4ckor?= =?utf-8?B?dDdYK1U4WHRqUVQrRDNLdnVHOEJiOEdhRVg5cEJ5enFCL3pRcWhKNmMyeUlQ?= =?utf-8?B?eHRRRFozekUzNkpwUHVITHdaWVlsd0RBdjFldXdKVGl2TnMvcmhab0czZWRl?= =?utf-8?Q?Eah3Gblf1m+M4KCovhHT73+TQ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 986730dc-34ef-4064-0ba9-08daf25ed4a7 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2023 16:30:33.7098 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +L2lHc1DcyLzi6F0nb0S1soPtBkBkT1rFKLfWnRzpzLDo5QPqa5TdoBaKxUO1kK0RrvR0XQtDOeubbO02OEMrA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8882 On 09.01.2023 15:57, Andrew Cooper wrote: > On 21/12/2021 11:28 am, Jan Beulich wrote: >> On 16.12.2021 10:54, Andrew Cooper wrote: >>> --- /dev/null >>> +++ b/xen/arch/x86/include/asm/prot-key.h >>> @@ -0,0 +1,45 @@ >>> +/****************************************************************************** >>> + * arch/x86/include/asm/spec_ctrl.h >>> + * >>> + * This program is free software; you can redistribute it and/or modify >>> + * it under the terms of the GNU General Public License as published by >>> + * the Free Software Foundation; either version 2 of the License, or >>> + * (at your option) any later version. >>> + * >>> + * This program is distributed in the hope that it will be useful, >>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >>> + * GNU General Public License for more details. >>> + * >>> + * You should have received a copy of the GNU General Public License >>> + * along with this program; If not, see . >>> + * >>> + * Copyright (c) 2021 Citrix Systems Ltd. >>> + */ >>> +#ifndef ASM_PROT_KEY_H >>> +#define ASM_PROT_KEY_H >>> + >>> +#include >>> + >>> +#define PKEY_AD 1 /* Access Disable */ >>> +#define PKEY_WD 2 /* Write Disable */ >>> + >>> +#define PKEY_WIDTH 2 /* Two bits per protection key */ >>> + >>> +static inline uint32_t rdpkru(void) >>> +{ >>> + uint32_t pkru; >> I agree this wants to be uint32_t (i.e. unlike the original function), >> but I don't see why the function's return type needs to be, the more >> that the sole caller also uses unsigned int for the variable to store >> the result in. > > This is thinnest-possible wrapper around an instruction which > architecturally returns exactly 32 bits of data. > > It is literally the example that CODING_STYLE uses to demonstrate when > fixed width types should be used. I don't read it like that, but I guess we're simply drawing the line in different places (and agreeing on one place would be nice). To me using uint32_t for a variable accessed by an asm() is what is meant. But that then (to me) doesn't extend to the function return type here. But no, I don't mean to block this change just because of this aspect. We've got many far worse uses of types, which bother me more. It merely would be nice if new code (regardless of the contributor) ended up all consistent in this regard. Jan From xen-devel-bounces@lists.xenproject.org Mon Jan 09 16:33:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 16:33:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473871.734702 (Exim 4.92) (envelope-from ) id 1pEv5R-0000rX-KF; Mon, 09 Jan 2023 16:33:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473871.734702; Mon, 09 Jan 2023 16:33:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEv5R-0000rQ-HO; Mon, 09 Jan 2023 16:33:25 +0000 Received: by outflank-mailman (input) for mailman id 473871; Mon, 09 Jan 2023 16:33:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEv5P-0000rI-OO for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 16:33:23 +0000 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [2a00:1450:4864:20::52a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 54a76ad2-903b-11ed-b8d0-410ff93cb8f0; Mon, 09 Jan 2023 17:33:21 +0100 (CET) Received: by mail-ed1-x52a.google.com with SMTP id s5so13318235edc.12 for ; Mon, 09 Jan 2023 08:33:21 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 54a76ad2-903b-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Zpopwb8KrQWBXzBjPf9ZHOHK5nNkCWT6pVvIG4FyUoE=; b=H8Pl71SJ5f7aqxRvGqq/bFEXF26SjbnF6m0XUI83tTieEDfb2mVzv82XW7Jwq2VU1T AdZPo7+FlMGmXWouyOEkYlD3xoq9Hd/9G/UANGMK8KrqQSdk0UyCBCdPR7KoVJasdVgk VoR3myf1srd7KCnIiLrTn41YPcEpPB9qWLEBE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Zpopwb8KrQWBXzBjPf9ZHOHK5nNkCWT6pVvIG4FyUoE=; b=bbWcy3aUMC2a3xmsD4AZ0G17j6EyCZsN/lTYBSH8mbkEM62xFonJZZKiXlXyvq0ciH asIlIbJAoqTHLnQqICMuDf1yo/FFAtDexJt21t6MnvLeWQ5Qe59tHtzq6YMIhYQsNs35 9KPtqLawerZrDGzKi2rNkeVS2sbPT7ctZ6Zwbd9ZdUf0IYJfNIL5UwI+g+Zci8kz60Fp izisgsF9Jj1TcT3BgH5QE0vP9f4x3lZMAoMOhgyG3lL40Yie1NESgUr6UHsQ8u1IHP1q esgaEv8dQ0tZLzLMEGwfJq+IX5JWcDVUp+TSflUpkZm2A1H1w6Gwst1s4tDSnl+/yyp2 cZdw== X-Gm-Message-State: AFqh2kp/Fl4La6flcsnAivaRH4Uzbukw8l6GzikPAKL7mj6lf8RMVpdq 2f28+cypffcZPOyRMACZJqcdyNWURts4Hu6ARuIu1g== X-Google-Smtp-Source: AMrXdXvC+aTYlGOLRuOjXHLpOfr0ey/W1GaCHKISSZRkiLP8yi/g2FsVydgIYKsenZ88MxmOw+CGpf+WKp1Muj6PfPw= X-Received: by 2002:a05:6402:78f:b0:499:9dfa:4388 with SMTP id d15-20020a056402078f00b004999dfa4388mr656297edy.106.1673282001371; Mon, 09 Jan 2023 08:33:21 -0800 (PST) MIME-Version: 1.0 References: <20221208104924.76637-1-george.dunlap@cloud.com> <9b8cace3-1593-8400-0633-da04f12b9849@xen.org> In-Reply-To: From: George Dunlap Date: Mon, 9 Jan 2023 16:33:10 +0000 Message-ID: Subject: Re: [PATCH] MAINTAINERS: Clarify check-in requirements for mixed-author patches To: Julien Grall Cc: xen-devel@lists.xenproject.org, George Dunlap , Andrew Cooper , Jan Beulich , Stefano Stabellini , Wei Liu Content-Type: multipart/alternative; boundary="0000000000004d14cc05f1d75381" --0000000000004d14cc05f1d75381 Content-Type: text/plain; charset="UTF-8" On Thu, Dec 8, 2022 at 2:26 PM George Dunlap wrote: > > > On Thu, Dec 8, 2022 at 1:58 PM Julien Grall wrote: > >> Hi George, >> >> On 08/12/2022 10:49, George Dunlap wrote: >> > From: George Dunlap >> > >> > There was a question raised recently about the requriements for >> >> Typo: s/requriements/requirements/ > > ... > >> Typo: s/non-maintiners/maintainers/ >> > > Thanks, I've changed these locally. > > >> Acked-by: Julien Grall >> > > Great, thanks. > This has now been checked in. -George --0000000000004d14cc05f1d75381 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Thu, Dec 8, 2022 at 2:26 PM George= Dunlap <george.dunlap@cloud.= com> wrote:


On Thu, Dec 8, 2022 at 1:58 PM Jul= ien Grall <julien@xe= n.org> wrote:
Hi George,

On 08/12/2022 10:49, George Dunlap wrote:
> From: George Dunlap <george.dunlap@citrix.com>
>
> There was a question raised recently about the requriements for

Typo: s/requriements/requirements/
...=C2=A0
Typo: s/non-maintiners/maintainers/

Tha= nks, I've changed these locally.
=C2=A0
Acked-by: Julien Grall <jgrall@amazon.com>

Great,= thanks.

This has now bee= n checked in.

=C2=A0-George

--0000000000004d14cc05f1d75381-- From xen-devel-bounces@lists.xenproject.org Mon Jan 09 16:55:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 16:55:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473885.734717 (Exim 4.92) (envelope-from ) id 1pEvQn-0003db-Fa; Mon, 09 Jan 2023 16:55:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473885.734717; Mon, 09 Jan 2023 16:55:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEvQn-0003dU-Cz; Mon, 09 Jan 2023 16:55:29 +0000 Received: by outflank-mailman (input) for mailman id 473885; Mon, 09 Jan 2023 16:55:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEvQm-0003dO-9G for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 16:55:28 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 68f5307d-903e-11ed-91b6-6bf2151ebd3b; Mon, 09 Jan 2023 17:55:26 +0100 (CET) Received: from mail-co1nam11lp2175.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.175]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 Jan 2023 11:55:22 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SJ0PR03MB7027.namprd03.prod.outlook.com (2603:10b6:a03:4e3::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Mon, 9 Jan 2023 16:55:19 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5986.018; Mon, 9 Jan 2023 16:55:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 68f5307d-903e-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1673283325; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=pATHQcznDD7E4YnvVRui+umjWBsKGx9P56qzl2XFL7s=; b=T4tJIHe6gqz9gl74eDe0DWf6MUZLf7CFkt+HsHyGeMKtbvNm6ll9xYez kOsq+B/lN73Pwd7TV8nTsGHPgJnDkMACCbGPzNuG43IKJJs10G9G3T5uW MzoMP4rE0HybmkF59iAS/FgmkyD3MEDoSzialx7wCqVN3CDWPaR399Dnf E=; X-IronPort-RemoteIP: 104.47.56.175 X-IronPort-MID: 91786498 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:unsM9qBUjYjI+RVW/xHiw5YqxClBgxIJ4kV8jS/XYbTApDMh0WBWx jdMWW6CaKzfYTPyfI0ja9vi9UxXupKAzIQ2QQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nNHuCnYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtcpvlDs15K6p4GpA7wRlDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw3bhqXXEU7 /ojJDkTLRze2OTm7K6+Vbw57igjBJGD0II3nFhFlGicJtF/BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI++xuvDW7IA9ZidABNPL8fNCQSNoTtUGfv m/cpEzyAw0ANczZwj2Amp6prr6WwnOlBNNCfFG+3v5zwwas2m89MSFIfBi2oNqcmnGTAesKf iT4/QJr98De7neDTNPwQhm5q36spQMHVpxbFOhSwB6J4rrZ5UCeHGdsZj1Mdt0g8tM3TDoC1 1mVktevDjtq2JWFRHTY+rqKoDeaPSkOMXREdSICVREC4dTovMc0lB2nczp4OKu8j9mwEjapx TmP9XE6n+9K0pNN0Lin91fahT7qvoLOUgM++gTQWCSi8x99Y4mmIYev7DA38Mp9EWpQdXHZ1 FBspiRUxLpm4U2l/MBVfNgwIQ== IronPort-HdrOrdr: A9a23:4Wti2K/ax8+Q1zoBBgZuk+DcI+orL9Y04lQ7vn2ZLiY4TiX4ra +TdZEgviMc5wx+ZJhNo7G90cu7MBDhHO9OgbX5VI3KNGOKhILCFvAB0WKN+UyFJwTOssJbyK d8Y+xfJbTLfD9HZB/BkWyFL+o= X-IronPort-AV: E=Sophos;i="5.96,311,1665460800"; d="scan'208";a="91786498" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lGlAGjlDW6g/Gn/CR7frhd8ZnApQJxjrnIBFnK9n8kbjYzlyYjKff4q4Xs4l3KA0lKyjVJ9nkuJzSy0vT390KVKViZO76mM2MySHukuG2fultcwZUsWKg4ElZ++NTFtbSh88iGeOef8Rd3V+BMgDMsSsQbwgyWpG4VqFY9xbaq7CcwgNpcQcLmE54vS8P3JpmdDt7TbWPXf47+RofKujQz67ZdOvyjsn1PMKmZd2+we8qIt0OPHj9MsQiqTpQM4sgula/pe61o+zxZEDGgvonWfLbpGG+ainF1+4kqHetRLGA6pvBHWMPSE/lQoWOOYWkAw1y7YqL0we5x0CxxRsAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pATHQcznDD7E4YnvVRui+umjWBsKGx9P56qzl2XFL7s=; b=dCzKNwRkV2Tp0yxG/4/tXPOZsMwWlCkFcBsaBB4mRai+VLUzK/uHeCjnMdbh1lSrE8g83dFKnfX8sIS7iZ+oj083mK3RNGTBm/eaUcBV+ZmGhwNTqpb5QAFKFus5E4FHcom7jpf+An66qGNUJBGO+Xqod8uVyG0gl16pLEJ8bYwblv/URztNO8RG3j+GaTeAsqqRS9GQ4a3682Y+yiKM81aXG1qJvY9AsXtkcMaw2RIeuxV2okcNnnKmiWm1eAyJY9GNuKl6ARh08qmaJ0avKDpeiiIQDIS+7C8iX+EiOdyDADZBwXJMs9KSGkyac9m4myeyNHe7eG1sURoXplD62w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pATHQcznDD7E4YnvVRui+umjWBsKGx9P56qzl2XFL7s=; b=O/K1KIJHdxOj4zBbC/YYw2PHiH0ecBTGQyLBoBBq3UPl8FBLXjNIgNAKzXc1mJJHDbsuFXoGn32V7WAwq6w3ngKC7BS9Y32R6rAqgNFredxuGS4EehNUicFOhJ694aQjxW1B8Y3lyhKyT/Bh5TyxlhhVFDdQnGNhvuRd/8ElARk= From: Andrew Cooper To: Jan Beulich CC: Roger Pau Monne , Wei Liu , Kevin Tian , Xen-devel Subject: Re: [PATCH 3/6] x86/hvm: Context switch MSR_PKRS Thread-Topic: [PATCH 3/6] x86/hvm: Context switch MSR_PKRS Thread-Index: AQHX8mME5A98miRws0CbcM4WT1rTvaw83q0AglvS2wA= Date: Mon, 9 Jan 2023 16:55:19 +0000 Message-ID: <83a08e78-cbee-8486-479a-5255c42e8239@citrix.com> References: <20211216095421.12871-1-andrew.cooper3@citrix.com> <20211216095421.12871-4-andrew.cooper3@citrix.com> <6efed2d5-e7a0-139a-a2b3-6f0696f711d1@suse.com> In-Reply-To: <6efed2d5-e7a0-139a-a2b3-6f0696f711d1@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|SJ0PR03MB7027:EE_ x-ms-office365-filtering-correlation-id: 3d684fd2-1f24-4ef1-f117-08daf2624a4c x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rIkqS7cfvhK9nD3zb3I1zF3dAZ06UgXJdwpPUU+Od8zGsRvZr9b6TNHIDETKzTD6wwlZfZgpSipHqbK1NL6iie8PAXke1i+IF0gXK5fOL8CN3I2Y1McTlWAaAXwUMujIrIdTgSrjJ3WQ2gNF3uwie0pw3t7PClERPp3Ovmcul6Vi/ce+wN7kYUnShu77Oj16acO2IMW6s0JV5RvauUXoeEJiZMYhx2oBvCTOgG9ahML9H5wXEtfq/syZUb7Rze9cVYbWExbBhxdM57qavl4aT+qIB/ilKgQfiVMYazkjmyDEi/Z1RsY7WCL9yfdK6ctY7NDGKWrbZBGE8hTkSQgeyS8FFkSfAbtAENloaRpxElwGBFkW2HE67jkbtPGg0earfp91MlpL1THyfEnFNcQPVsmLR12pJxnt91FlLGJHlZa5hXM4e3phsHJr3EahKR+kaXWDA1AlI42+C0ttFr8R4/ORbScwW7jvLSKoIj43SPAAQDhSqHLQTap75BvCTLvqn2Sy2WdQXe9pZ8soL9/pXXYG1GRVc53IvW2oSa1XHxWQuZ261nB/4TvoBlsDlRN9zyysr1vhHtW1U31daQ3unURCOIE3+hWOKyfMHi9TXwTQ9HRonEh8DOp1QIc5iE2XMq5OKGaV3VaWyrcOR4+yvfod4x2b8zUjWRD/yRVUbBwe91ddJklPxle59BUCGFoKUIoKmEB+LZIB8vL0Yqq4F4IpX+lbZg12Q8/eyHykp/KGV8r5x1QKKuPg40ZRbo3KtgE7KPn9fAr2ew5lfnDtbQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(39860400002)(366004)(396003)(376002)(451199015)(66946007)(41300700001)(31686004)(8936002)(36756003)(5660300002)(2906002)(8676002)(6916009)(91956017)(64756008)(66446008)(66476007)(66556008)(76116006)(6512007)(316002)(71200400001)(54906003)(6486002)(478600001)(6506007)(53546011)(4326008)(186003)(26005)(2616005)(31696002)(86362001)(83380400001)(38100700002)(82960400001)(122000001)(38070700005)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?MW0wbzRCVEgvYkk3VWQ1YWcwdTZtbndDMnJrMW5XV3hTdVNuVXdVYWRNNFZZ?= =?utf-8?B?OWNXU2VlK1FGdWhCRS93YmhlN3dscUxUbk9DVElKTnlYajRyb2wvV1E0TzJU?= =?utf-8?B?UjV3R21INzZFVGlMTWV1TzJJWm5oL1h4QzBMR2RVSHdGa01xNVR3Ym9mUXBp?= =?utf-8?B?bFZ1eVphRDBDT2VHRDM5SEJ2Y21peFIyY0ppcis1K2hyYmtzV0FMZVc3N0o0?= =?utf-8?B?MS9vNldVVzdYcXpSWlA3aEx3UXg2TFRaejhWNjdOVFJuVEE1cDZZR3N6WHVs?= =?utf-8?B?Q213RCtsNTlHRmloOVpjZ0NKODlEMUlFVEFYU2daYWROWHZESnY3Qm9QTE5v?= =?utf-8?B?WVpRbHFJT2tIanNMdjZHYjFQOEJLRFdFNEUxYmtMcE1PWEhzVGtzNEFqQzB3?= =?utf-8?B?cmZRbWhVQWxQYUw1MElWVWlXZkxYYlJvWHBVLy8rQUI0Z2U5dEhRT0p1amVw?= =?utf-8?B?alc0Q051VFhLSnFtbVB4RVl1dHU4RG0zZFJPRW9jV21OMlg1RFYyQW9RamNm?= =?utf-8?B?c0JIdHFNS3U5RjBlVmxEVXNXdXA4M2JXZU1FUHhlVWs0a2g4R0hmTkFYMDdY?= =?utf-8?B?ZjdKYlRhT3k5V0tPYlUwNXZPTWYwSU0vUDlKOUF1OENUQ3F6UE9yUlhGeUxs?= =?utf-8?B?aVZadEdraWpVa3VTTGlPUE51MXMzOU9RTlZlV0lucCtZREtZVm9sbXJ4VGto?= =?utf-8?B?K2RaL1N4U3ZiTXk4UzFSQTBkaEo5Uk9mdCtuTWV3YXllSDdNN3NXQTVleWZv?= =?utf-8?B?RGVTall3eUt5SzdmSHJzYVgvSStqRWxWQ2ZvWXhVdEY2dlRlbVIzWEw3RlhW?= =?utf-8?B?UnVlNktpajduZ3NoUEVWQ3lRL0lXeHIvYS80dWJJRG1QMGNLUkZZOVVTMElP?= =?utf-8?B?ejRuUjBnV1B0NjRvb09JM2xvYU5KSjhsZUtsamtzek5ZWU1tZkpIWlpGOW9p?= =?utf-8?B?ZzJuYTMyVzZRdGdwRWtHbys1TFFXaFhvMVpnejlRSkxkZW56d3V1YXZSaVY4?= =?utf-8?B?bjg1bS9hQXlLakxuZGZIQXFac0JvOXkzU096YkRQSTdCQWoyejA0d29weHJQ?= =?utf-8?B?WVV0ekc2UEMrcWF3Y01DdTY5bWFkN2t6TXJDZzlMM0E2dVpCTlFCTDVPREl2?= =?utf-8?B?MnlzVkU5N3NiWmsyaThpai9JVk8yTTBIZzEyZElEZVBuM2RkU1VNWGV6V3hO?= =?utf-8?B?dXNETTZjcy92QW5nbXRyREJwVFZ2aFhORkdCT1ZKWGZQclo2MkpCeDdCWVlP?= =?utf-8?B?SzlmNkR2blpQT2xWM3JoM1E1cG5ZR254VDM1d3Q0YWY1dVRFTGw0akd2bm92?= =?utf-8?B?TkNod2lkazY0dXgyQmtjTnBhVHExQk12Wmppd25PanptczhaQ3ZNdUphVmZL?= =?utf-8?B?VVJHdEVxVXN6QTYrN0NjWDFxSGZGNlhIVDc3SkVuODRmbCswZ3I4NzZyVTk4?= =?utf-8?B?Yk5OSnJobEc4eUZaNnU3anpnRWx4VmxoRGNwTEk0dkgvSzJXa1phVnBocUJX?= =?utf-8?B?d24wUXFUVTFqNXl6dC9TRVN0VGdMOHJuVzROUXo4MGFHb2w3QjRIU2hla3dt?= =?utf-8?B?SzF5UDM4NHpHeUFKNjRQdHpYSGFPSmhtZlAxMXoyR1dEUGNCbno0SlFDTEtW?= =?utf-8?B?WWU0SDJNbGNUckt1OCtHVVNFelV3c2VOZk9FeGpEYmpXMVh6MjNzNlBHWktS?= =?utf-8?B?dnFlVi9EYVkyUE1TNTJRUmE0TjVLcFBKVm9WalA2MldXSkpSMi82b0M3a1FJ?= =?utf-8?B?MFFyWUkyemcwOGpvSytPVFRmUk9waCszRFBoQTFVNkNFdmxma2hwWFlodnYz?= =?utf-8?B?VVZKamk1bUI3U3RtbzBvRDQ4dWZRWjBTRWY3SDFpaUlnSEsyeWRTTm9IQlo0?= =?utf-8?B?UWpvMHVYdDRQRGZXN1hWOFF0Zk05VFB2WXV5YWZBSm80cEFzT0VqUkJHbTV1?= =?utf-8?B?Q2prMit5K0dsVk5QZGhscXdITjJmOHd5YkpCeERNOVVESjRJTklValk3aXU5?= =?utf-8?B?RWZYd2JnbW80cDUycmpMN0w0YkNZdVpRY1pybG9GWmlNZE14bW9xVDhmL0FS?= =?utf-8?B?QUpVRTJzSWVYVWNsNHVzZ1lHTnRaWEJXUnorQ0FuNVRFd1drUDdJQWNYaFJx?= =?utf-8?Q?dvb/cviaDf3tGW1QroK/jJD1N?= Content-Type: text/plain; charset="utf-8" Content-ID: <6FBFE4C814FB8F40A325845BAAF94C8D@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Ai3Oek7kiBXsaMqxSnBy898he84sZFr9eI7YszqsVyCpEjYOlXIS/1m08FBfBG9yqIy77PnIaTMG276l/48Rzm5cNRMme0FLvC6gJGeVdjZGi3QkYBmv+4SnKcU7ck+DqPErM0tjkLmyj0THLTB+aeg+lfI4LOoNUYEIAcIZY9R4iWQ1rLq2vkhVpkRsr/JiJHyOdpDVa+PK+A87LKpr3K+zIFmJNu36iVA8lLuqBFVODJsiIOaMyNdKWKcJmVGdk4n4Hs0w/+TSMekeAEyJ/uCJWWVnxOUYmKM8CLCt1b47F1+9Ns2HE6CqtBVma9hnE+XgQM5g8l3sIXY8ttnOsbMajueoyY4EW8QG2aRYdlz6jhsGVz2mn8VhkKrCp26+XK9qKZSAprVXTJE5UywcVeyVgsF8mtFBygHF0wY2++eNz8cZnE/nvsX4+qhjMY762Ehk3o+r/tB0Z3k5WQiZcRldCNnJrpmuHEhlhPJwVVjdjZHVkimnGDSIBIzEBl7n4c0o+IZFtUDF1216zsE8Owb5EvLMbUMtbqnCXxpur4S1amhoSV0/7qE/7vyQZcEKbPr5reAIOEEBJvr4NXH0Cz9CjR4H8iPjVoeG1YmwB/lmqNB3ajV2fmRL+m9ajnXsdBd/N1IC8S6+VgsS++CxReJvhqg6q3NPSwZ8W7eYpMsV9RZsucx7UWEHVYoi8Z0k2M1jcEB0YclDMeo8z509kYip9HBegSUOg0u9Ii35RF64wpLv8p1iVJoT6oouvLdfCfIC6/XH32JGlcXPX+OpXJLGCaA/FIkuKRl0ucVvJOhCkHFoJztm3rhbeXHKdC7VfSvs1qACkyWTVsFIzSSx/kss7Zw6X/YWo9ZXfYkv4/Q= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3d684fd2-1f24-4ef1-f117-08daf2624a4c X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jan 2023 16:55:19.3307 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: W1x6LmHIW5Hr3X3gkmuddVbjnoUJJ/XsUB8q3uaHKKaFIzBc+k3jMhHmfRL2+Hz0f1zhy7JvOdLGnnbxWn3hswanDnAcP5gSzaXlbUzir1A= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB7027 T24gMjEvMTIvMjAyMSAxMTo1NiBhbSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDE2LjEyLjIw MjEgMTA6NTQsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBAQCAtNDIsNCArNDUsNDkgQEAgc3Rh dGljIGlubGluZSB2b2lkIHdycGtydSh1aW50MzJfdCBwa3J1KQ0KPj4gICAgICAgICAgICAgICAg ICAgICA6OiAiYSIgKHBrcnUpLCAiZCIgKDApLCAiYyIgKDApICk7DQo+PiAgfQ0KPj4gIA0KPj4g Ky8qDQo+PiArICogWGVuIGRvZXMgbm90IHVzZSBQS1MuDQo+PiArICoNCj4+ICsgKiBHdWVzdCBr ZXJuZWwgdXNlIGlzIGV4cGVjdGVkIHRvIGJlIG9uZSBkZWZhdWx0IGtleSwgZXhjZXB0IGZvciB0 aW55IHdpbmRvd3MNCj4+ICsgKiB3aXRoIGEgZG91YmxlIHdyaXRlIHRvIHN3aXRjaCB0byBhIG5v bi1kZWZhdWx0IGtleSBpbiBhIHBlcm1pdHRlZCBjcml0aWNhbA0KPj4gKyAqIHNlY3Rpb24uDQo+ PiArICoNCj4+ICsgKiBBcyBzdWNoLCB3ZSB3YW50IE1TUl9QS1JTIHVuLWludGVyY2VwdGVkLiAg RnVydGhlcm1vcmUsIGFzIHdlIG9ubHkgbmVlZCBpdA0KPj4gKyAqIGluIFhlbiBmb3IgZW11bGF0 aW9uIG9yIG1pZ3JhdGlvbiBwdXJwb3NlcyAoaS5lLiBwb3NzaWJseSBuZXZlciBpbiBhDQo+PiAr ICogZG9tYWluJ3MgbGlmZXRpbWUpLCB3ZSBkb24ndCB3YW50IHRvIHJlLXN5bmMgdGhlIGhhcmR3 YXJlIHZhbHVlIG9uIGV2ZXJ5DQo+PiArICogdm1leGl0Lg0KPj4gKyAqDQo+PiArICogVGhlcmVm b3JlLCB3ZSByZWFkIGFuZCBjYWNoZSB0aGUgZ3Vlc3QgdmFsdWUgaW4gY3R4dF9zd2l0Y2hfZnJv bSgpLCBpbiB0aGUNCj4+ICsgKiBleHBlY3RhdGlvbiB0aGF0IHdlIGNhbiBzaG9ydC1jaXJjdWl0 IHRoZSB3cml0ZSBpbiBjdHh0X3N3aXRjaF90bygpLg0KPj4gKyAqIER1cmluZyByZWd1bGFyIG9w ZXJhdGlvbnMgaW4gY3VycmVudCBjb250ZXh0LCB0aGUgZ3Vlc3QgdmFsdWUgaXMgaW4NCj4+ICsg KiBoYXJkd2FyZSBhbmQgdGhlIHBlci1jcHUgY2FjaGUgaXMgc3RhbGUuDQo+PiArICovDQo+PiAr REVDTEFSRV9QRVJfQ1BVKHVpbnQzMl90LCBwa3JzKTsNCj4+ICsNCj4+ICtzdGF0aWMgaW5saW5l IHVpbnQzMl90IHJkcGtycyh2b2lkKQ0KPj4gK3sNCj4+ICsgICAgdWludDMyX3QgcGtycywgdG1w Ow0KPj4gKw0KPj4gKyAgICByZG1zcihNU1JfUEtSUywgcGtycywgdG1wKTsNCj4+ICsNCj4+ICsg ICAgcmV0dXJuIHBrcnM7DQo+PiArfQ0KPj4gKw0KPj4gK3N0YXRpYyBpbmxpbmUgdWludDMyX3Qg cmRwa3JzX2FuZF9jYWNoZSh2b2lkKQ0KPj4gK3sNCj4+ICsgICAgcmV0dXJuIHRoaXNfY3B1KHBr cnMpID0gcmRwa3JzKCk7DQo+PiArfQ0KPj4gKw0KPj4gK3N0YXRpYyBpbmxpbmUgdm9pZCB3cnBr cnModWludDMyX3QgcGtycykNCj4+ICt7DQo+PiArICAgIHVpbnQzMl90ICp0aGlzX3BrcnMgPSAm dGhpc19jcHUocGtycyk7DQo+PiArDQo+PiArICAgIGlmICggKnRoaXNfcGtycyAhPSBwa3JzICkN Cj4gRm9yIHRoaXMgdG8gd29yaywgSSB0aGluayB3ZSBuZWVkIHRvIGNsZWFyIFBLUlMgZHVyaW5n IENQVSBpbml0OyBJDQo+IGFkbWl0IEkgZGlkbid0IHBlZWsgYWhlYWQgaW4gdGhlIHNlcmllcyB0 byBjaGVjayB3aGV0aGVyIHlvdSBkbyBzbw0KPiBsYXRlciBvbiBpbiB0aGUgc2VyaWVzLiBBdCBs ZWFzdCB0aGUgdmVyc2lvbiBvZiB0aGUgU0RNIEknbSBsb29raW5nDQo+IGF0IGRvZXNuJ3QgZXZl biBzcGVjaWZ5IHJlc2V0IHN0YXRlIG9mIDAgZm9yIHRoaXMgTVNSLiBCdXQgZXZlbiBpZg0KPiBp dCBkaWQsIGl0IHdvdWxkIGxpa2VseSBiZSBhcyBmb3IgUEtSVSAtIHVuY2hhbmdlZCBhZnRlciBJ TklULiBZZXQNCj4gSU5JVCBpcyBhbGwgdGhhdCBDUFVzIGdvIHRocm91Z2ggd2hlbiBlLmcuIHBh cmtpbmcgLyB1bnBhcmtpbmcgdGhlbS4NCg0KV2hpbGUgdHJ5aW5nIHRvIGFkZHJlc3MgdGhpcywg SSd2ZSBub3RpY2VkIHRoYXQgd2UgZG9uJ3Qgc2FuaXRpc2UgUEtSVQ0KZHVyaW5nIENQVSBpbml0 IGVpdGhlci4NCg0KVGhpcyB3aWxsIGV4cGxvZGUgaW4gYSBmdW4gd2F5IGlmIGUuZy4gd2Uga2V4 ZWMgaW50byBhIG5ldyBYZW4sIGJ1dA0KbGVhdmUgUEtFWSAwIHdpdGggQUQvV0QsIGFuZCB0cnkg YnVpbGRpbmcgYSBQViBkb20wLg0KDQpBcyBzb29uIGFzIHdlJ3ZlIGZ1bGx5IGNvbnRleHQgc3dp dGNoZWQgaW50byBhIHZDUFUgY29udGV4dCwgd2UnbGwgcGljaw0KdXAgdGhlIDAgZnJvbSBYU1RB VEUgYW5kIGRvIHRoZSByaWdodCB0aGluZyBieSBkZWZhdWx0Lg0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Mon Jan 09 17:01:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 17:01:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473891.734729 (Exim 4.92) (envelope-from ) id 1pEvWz-000552-5E; Mon, 09 Jan 2023 17:01:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473891.734729; Mon, 09 Jan 2023 17:01:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEvWz-00054v-22; Mon, 09 Jan 2023 17:01:53 +0000 Received: by outflank-mailman (input) for mailman id 473891; Mon, 09 Jan 2023 17:01:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEvWx-00054p-Kz for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 17:01:51 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4df174a1-903f-11ed-91b6-6bf2151ebd3b; Mon, 09 Jan 2023 18:01:49 +0100 (CET) Received: from mail-bn8nam04lp2049.outbound.protection.outlook.com (HELO NAM04-BN8-obe.outbound.protection.outlook.com) ([104.47.74.49]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 Jan 2023 12:01:47 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DM4PR03MB5998.namprd03.prod.outlook.com (2603:10b6:5:389::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Mon, 9 Jan 2023 17:01:43 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5986.018; Mon, 9 Jan 2023 17:01:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4df174a1-903f-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1673283709; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=R/0Vk+33U8Ao4aCiSMmv1v9fvlZ/B4rPwFCHz8IDlcc=; b=D5UqDEcpmjSFquNmPXwLzjvjjp9TYPxyUqsYfzMaFSU5EpbRz+/cXQDL JSMQhSdvI8w61rfCFVoWYIa3gHz2TxdaZgu2kZmFodXrnqcCM9fJabB1e ng8kM5jeaDPX+ZEmvfqm1ikoC0u6MKB5x9YZLPuljaCoBxdlSMzkmhfjz c=; X-IronPort-RemoteIP: 104.47.74.49 X-IronPort-MID: 91829678 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:dETh6aA9i9GOJxVW/wriw5YqxClBgxIJ4kV8jS/XYbTApDwr1WZVy GAdDD/XMviONGqkf99zbIi1/UlXsJKGn95nQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nNHuCnYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtcpvlDs15K6p4GpA7wRlDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIwvaVwKFtCt sEieCkkVzfboce9g56VY7w57igjBJGD0II3nFhFlW2cJ9B2BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTK+exrsgA/zyQouFTpGPPTdsaHWoN+mUGAq 3id12/4HgsbJJqUzj/tHneE17afx3KlB9J6+LuQ6/51g2SOyE8pVDoXX1+ap7rnjBW/YocKQ 6AT0m90xUQoz2SpRNTgWxyzoFafowURHdFXFoUS9wWl2qfSpQGDCQAsXjNHLdArqsIybTgrz UOS2cPkAyR1t7+YQm7b8a2bxQ5eIgAQJG4GICUCHQ0M5oG/pJlp1k6eCNF+DKSyk9v5Xynqx CyHpzQ/gLNVitMX06K8/hbMhDfESoX1czPZLz7/BgqNhj6Vrqb/D2B0wTA3Ncp9Ebs= IronPort-HdrOrdr: A9a23:jUbozq0uZVY5aAggPg71egqjBLwkLtp133Aq2lEZdPU1SKClfq WV98jzuiWatN98Yh8dcLK7WJVoMEm8yXcd2+B4V9qftWLdyQiVxe9ZnO7f6gylNyri9vNMkY dMGpIObOEY1GIK7/rH3A== X-IronPort-AV: E=Sophos;i="5.96,311,1665460800"; d="scan'208";a="91829678" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lt0DUxG460tfBmNnHh1Q6av9KIRW69CcraKUjYeOM7VIZuKn7HJfJjziwcAWVGSA/qpMdm7eUt0wGa5IcK4tTXiv5oXnaRKBrAkf2Y88tYbFdbfPzOW3uSsj42i4Cm7ImRSCAfmnwlxLYPRb4+IK9d4R8SG9qfw7omZMvtUVzqd/cXVR0t0Eu55yZHiQ1N148yRQAS1NGBhJvQMCykjHd7hM2RywRvtWZcFzVDv7bqwPH7bmxVUBfvHuiZJxpErTCpQWJExXnNnrbyr7dSV7nuSaPY/BuTznfHZeFVmQwo+uP/nrHyXiGNDLTzciATROABpele9+WuD8gabMMDGIBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=R/0Vk+33U8Ao4aCiSMmv1v9fvlZ/B4rPwFCHz8IDlcc=; b=FNrcjecLDJY5FPR7crHgMFhUY/h16LecuxnqIxHVBjhZ9alkaBKAp+2GL+1R1CjUSM1gFPGau9WBHLybWyl+yCD8lZFrjHLjFWiZu19egpSqMju9NZhdjW83IxN+C2GJP+6iRhRL7/wLqxZPSfYHgx885lLOzXAfNjPKvFacbYVTqolbe/JBgVmhlraa3F5nrvxqOQIXc/vjW9STOZAw0ESqlYjH/Xn/HZ74m1IpUHls19xM2hTra1jrj/u6g1hoA7uaTJf7oyO3Ma2jUGQu1ocDcMgqat9j4p4+rcxllewea6KJd6bWY4qE2zB6CRzvvHWVsLe3j3904YljbwrS0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R/0Vk+33U8Ao4aCiSMmv1v9fvlZ/B4rPwFCHz8IDlcc=; b=FCzUQXcz1pdhVeHJHKACc5MVzOTQCGQCg0iTgkuZ1M5H/XaSYp2X4eFgCUpYqia+NnM49xvjxtV4jV9j7OswMitNzv8QXA+GrHeJaG0subXCB4MIGvoYYvxBbjOOhwVCY/+qBDNCrdjcHsaD/xWv3rC07PvsUoAFP/OVAYRwsm8= From: Andrew Cooper To: Jan Beulich CC: Roger Pau Monne , Wei Liu , Xen-devel Subject: Re: [PATCH 6/6] x86/hvm: Support PKS Thread-Topic: [PATCH 6/6] x86/hvm: Support PKS Thread-Index: AQHX8mMBaDBKE3ERDkqjj25vs7mo16w85QUAglvOTAA= Date: Mon, 9 Jan 2023 17:01:43 +0000 Message-ID: References: <20211216095421.12871-1-andrew.cooper3@citrix.com> <20211216095421.12871-7-andrew.cooper3@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|DM4PR03MB5998:EE_ x-ms-office365-filtering-correlation-id: 00fee7e4-3012-43ba-3a62-08daf2632f1c x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7zPoP3nXOPgEaqlN1CKTHSvOSAzReyv6I6AIgfjX9v0WfLUiFKfq+Z0/SQXmfuN4FDmskp836XswE8u8v0aUNsK8+N7Ejhgx9tD2QwAOH/rdVlYiKlNb64TnmphQWLdJOXp0Nha3hurRePLtAbnkjNg/NsFjvhtOFoEgZwdvXCQ4LEwQYSIcMBd5CkHNv4gDxwIvtexz1Z45m5928CIz8R8zVOSEXpKih8+2QnqHlkUOKYWeUSR4ib3N0L49g0x0FOwvqg51UVIyHQmmx7jY0gcTv2S0Ts26hcUkHEI/j30aBIG/EmYdSyP212abfu95BtyvL1dsab/9cU1gxOKu2b1guacmEQd6Y8RnA1fuubZL8UqRtT+46WKzpPSEcpa2UKh633JObBmWyfCcZQufOAbjF8jL5Z2c2J1gpNQ3PIy2xbNRQWMOTm2QfmbWIllbrzNUp+a5znAzFGjssuLJ24LZKsHponBF8N+O3LJbVavPYY+cldcUPrh2i4pCpMb4O3NWAe8VeMrSg4yoQFOtquiKiIk4hBMtTHeUB/L/Y/4gZOXl6j8hxN1CmlgHKTVC600dNfNnh9wY0THbfzm3ORC6gpt9tWdIoNnhAJII/cyT0NHqGWLWLquM/IqQFGqatiQmVDsi12S+FMYUwO4QDwGITuoCiWICs2WLw0k5k9ZOESNxfWyWBsn9nYryf5oQNcSm2krEQfOP8oIsQ78F7y5EHFKbo1KE+v+WZqke0SU3W6fNjZGEEbacWNQRApIV/i5Nyf0i7Bhyp+xc6/y4tA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(39860400002)(136003)(366004)(376002)(451199015)(6506007)(38100700002)(82960400001)(122000001)(31686004)(53546011)(2906002)(478600001)(6486002)(2616005)(26005)(6512007)(186003)(5660300002)(316002)(71200400001)(8936002)(38070700005)(36756003)(86362001)(41300700001)(31696002)(8676002)(54906003)(76116006)(91956017)(66476007)(66556008)(66946007)(66446008)(6916009)(64756008)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ZTJiR2hMd1B2dFdRdDRDRmJQUXFWbU5DT0syUlJvWGJQb1F1TmVQOGZSQ3RZ?= =?utf-8?B?R3pnSjNvdG9CS1JqRTdyaWp6LzNWSjFNMHJoR2JQRXN5RGpqU28xVG5jVXNZ?= =?utf-8?B?c0JNZWY5VjVPQ1hLV2dHQWI1d3oxaWpkQXM2akFaUWxscmNheXhITXI1N21z?= =?utf-8?B?ejNvdnMzNUtZamkrQlZaRXBLcmxTdEE0RkpINGFCajhsUXFGWnNSNUNvN2Z5?= =?utf-8?B?T3ZoVEJucERCeFlmZEQzbjBobzV3WWdocGZPQnYxL0xrRERtTmdxMGpzeS8w?= =?utf-8?B?a3FJb2RIQWxqbjBJbER1Q1NCWXpXb2Uwdk9aUGpkc0N0UzRKbVdaQU5sZjNO?= =?utf-8?B?WlpkTTlMRVJSNTBLcVhSTjlvZTI2eU0rVEtENUtoRWxPTmZsVG1kZWwyR2kw?= =?utf-8?B?aG54Q0pUN1hveHVGWlpIZGJ2VTFmdWx5Mk93NGN2MDYxSkJNeGhXV3ozUVNF?= =?utf-8?B?RG9zQVhhUlhydWh3cjYvcEpoSWhTc3JEWGVsazZVU2NMdjhFL0hWYnJ2eGlN?= =?utf-8?B?NHpaWlhiNmt5L3poZE8zQXQzZ3ZJTVQ5MG1Ub3RscXc4eXljTkxtUDJLQVNr?= =?utf-8?B?SkMrU2MzaUVjbkUyVTZvZVkwM0E0MFlSaU9IYVQxRjh2Ymtma0VVQVBDU3JL?= =?utf-8?B?TStrcUt0L1JDVFR3NUdERnptZDhrZWRoWGhTK1FoNzRkZjI5bTVBM2F3N3NT?= =?utf-8?B?Sm5uUHFUZ0pCUlNORHRZbHVPbHdSSlQ4bGtMeTB5NnlsTDZGZ0lqYzdTTVVn?= =?utf-8?B?L0VnQU9XNUdmWGhTbElGeUVGWjdmMG9CNlk3dlV1TVpuK0hlYzBVMU1xd3dh?= =?utf-8?B?MVY1V21ueE53Zk5HZEZoYys5bHBxYjRiWHpac0tlOHlqeWNOU1ppUy84T1Fo?= =?utf-8?B?cnhTNHJ1c2Q0QW5oMmJ1Q09sOFpjMWNFYW9UZWJJbkZuRmYwcXJMNUl2Zjd3?= =?utf-8?B?SnIyYzk1cm11TlFOSy9EczNYMVgvMTRMVXZNUEhJVXBjNDhnQXpreTNRcWh0?= =?utf-8?B?am9jNGZDRWI1R3BsNjJBenBKUFVaRVU1OFUvUm4rU2ZtZlpPU0d1ZDlqQWd6?= =?utf-8?B?bzJ1eG4vbkpJWmdpUk50S0tMeThOd3JsOGFjWVNGUnZwUC9tOHdzQUlqZ2pH?= =?utf-8?B?UmRFaU00ZExrdWJnanpJbDVYSkNORlJ5OExiUnhZVnpvRkZvOHdIanVJL1FG?= =?utf-8?B?ZjdLYkN2MWczMUFYSHYrZ1N4MUlNRS84dE93WE0ybGRHWWRoSXhwWFdtMW56?= =?utf-8?B?WHBkZnA3UnhiN0pYdWdHcmpRTHFlZWZNYmROOVpadmduMzRvQm1ZVG9ySzRl?= =?utf-8?B?ZkhIWHFoSk1ZV1lWWU5DWGxqaDNNbmtua1FBbGJEWnpTcDV4RWdNRklrZnZO?= =?utf-8?B?TStNTjN0UDNCMkxKYWQ2bmM0NDRvWnVEY1RGbWtLb1FHaDVuQzFPWFNZZmF6?= =?utf-8?B?RTViOURFcFF3YjRzSXZvWURrMEVFNEwwQTJUT1RwcVd1SjhQcm1ueW0rOTRW?= =?utf-8?B?MWVCei91UVI3RDJiVUwvWlEyWnFEN3VZZGd5TzZiNWQ0SHB2VjBibjR5aUMx?= =?utf-8?B?UmVIN1hEZzBDS3VXUGhKQWQyS2JTc0kwODVrMWsvQzc3ZCtRTzVUeTk3Mm9C?= =?utf-8?B?QlN1SVJPRmtSZzE1QkFVOGt6cVVsUXpieGtrTjhodVg5aXhCeS9jNUtrbDla?= =?utf-8?B?QzRtYWRxNlhYL2FwbDlwTHZXbGF1SkhyZ1lxNWlHdkoyUGU4RkpKcTR6dVNk?= =?utf-8?B?Zk5wY01Ia2tjWkhvcHRORFhIVjNvaDIxMnhJOHJDdkY2eVlDZ0lQek03R1JI?= =?utf-8?B?bzZYdDR3bVFHaFhpS2hDZFAvMXdNVU5sWE9taDNpaG1ObHpNWHJwM202MEJu?= =?utf-8?B?cG1mM1FBbEJLMWhMZU9tSk1jZ21yY1FZVzRhUERMMmplaWpNM1hSZE1pVHBK?= =?utf-8?B?WnVZR1FhOUlKTENPVnJpYTRvdnA4dms4Y2k2eXBlN3Y5Ui9Rc0dzMFcyLzJF?= =?utf-8?B?ZEhhd3hWd1dRYWw2YjlwbVNBcDI0dmVzOUJWcDlxd09hNy9MRnl5RTR0S3lR?= =?utf-8?B?bTNTQUVQcnUyVXpZcWhvMHBJOWFpYW9vMzh6UFJPeC8rNkovOENHWTNRSlBw?= =?utf-8?Q?LwwYCYJawzUmXAl/cLfF4jZkF?= Content-Type: text/plain; charset="utf-8" Content-ID: <24AA875F96FAE14097171D7FC883E2B1@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: ENYMlNz8s+NnWJH+N5gWZ6j9PCZpCCNCK6NorTdB5k2kDqwGEYRorcd+xc3oe/JhyJKJ3/Q9e1I/DRAQxSyEDb5kq/k/IdR5CS47f5/iye1BI7ckXmvq50tpMXFGcpTgx65Dmew5053Q8r3wgNfeitZ9RgllX7Qdw2znmttFlbwXoPvqbadH2BeZoIsq059ywl13+Ptz4oKr8PUVLChfD2yBvHCf3C4nlVFWQpqTmvNU1lCRk+cassDUXMLkH8SGKUGHCTgkKHjdFmE1c5lQ1MUEcULkgCZLPcvIG02ukesSbTYJzx2XQFyZI/I1HcHBWqsjqb94GIoUQGtXwmCjI9xsuEKViACyMOgMRwzJuhMubBcHPCaYIOgO1DxnqsoZ1eeUwhD/G0t9OinbEeafdnQZgdaWHDrRq7eZLWIPViKnKdk74ZLn2jxMYGH3+CoPwoyvJzwtXqe1HkaFR0jOORcyjbpHF3k5o2W2d+Ixe8zZXJvq0w+jcQRAbriGzAgrkVEG2pTjEkjWAG5Y93ih5dxTIP2wyshtABUz77dnjRV0HP+4qvYKtyjU2c8QXoC81942PgwT8HTUAsk5/XAZenqKyBNIj3psDNVJOH2TWADX9q0U/sM9cvQqYSUWsk2oaaMYypCxtj6O0Gd5qaY18I71K0ViKXDHKCD1pKDpKVEBTEfgNR/LLWFpSmRd9+44GwyimzM4hQ0efYFTdCRnnmR+xoy3OW7NnnL0TD44hptWq1YhDvpNLQUvfpSc0ZH3xePGgi5yDM1BwpONCCiQZDX8PUvl/8QjXICrbMGx4q2XM7VEj+cIwkK6pjVpfFXA X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 00fee7e4-3012-43ba-3a62-08daf2632f1c X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jan 2023 17:01:43.1941 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Ja+7lKe3zMaYIq/YUSf0h/SAURmRCHscCEYyceKuzqvybDc24T6YfCun2gbq9rj1Zg6KXzs3gSXD0EHPOuwDu5VDQ10ucSCjhe0myUA2wtg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB5998 T24gMjEvMTIvMjAyMSAxMjoxOCBwbSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDE2LjEyLjIw MjEgMTA6NTQsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBXaXRoIGFsbCBpbmZyYXN0cnVjdHVy ZSBpbiBwbGFjZSwgYWR2ZXJ0aXNlIHRoZSBQS1MgQ1BVSUQgYml0IHRvIGd1ZXN0cywgYW5kDQo+ PiBsZXQgdGhlbSBzZXQgQ1I0LlBLUy4NCj4+DQo+PiBFeHBlcmltZW50IHdpdGggYSB0d2VhayB0 byB0aGUgbGF5b3V0IG9mIGh2bV9jcjRfZ3Vlc3RfdmFsaWRfYml0cygpIHNvIGZ1dHVyZQ0KPj4g YWRkaXRpb25zIHdpbGwgYmUganVzdCBhIHNpbmdsZSBhZGRlZCBsaW5lLg0KPj4NCj4+IFRoZSBj dXJyZW50IGNvbnRleHQgc3dpdGNoaW5nIGJlaGF2aW91ciBpcyB0aWVkIHRvIGhvdyBWVC14IHdv cmtzLCBzbyBsZWF2ZSBhDQo+PiBzYWZldHkgY2hlY2sgaW4gdGhlIHNob3J0IHRlcm0uDQo+Pg0K Pj4gU2lnbmVkLW9mZi1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4NCj4gUmV2aWV3ZWQtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCg0KVGhh bmtzLg0KDQo+DQo+IEkgd291bGQgbGlrZSB0byBhc2sgdGhvdWdoIHRoYXQgeW91IC4uLg0KPg0K Pj4gLS0tIGEveGVuL2luY2x1ZGUvcHVibGljL2FyY2gteDg2L2NwdWZlYXR1cmVzZXQuaA0KPj4g KysrIGIveGVuL2luY2x1ZGUvcHVibGljL2FyY2gteDg2L2NwdWZlYXR1cmVzZXQuaA0KPj4gQEAg LTI0NCw3ICsyNDQsNyBAQCBYRU5fQ1BVRkVBVFVSRShDTERFTU9URSwgICAgICA2KjMyKzI1KSAv KkEgIENMREVNT1RFIGluc3RydWN0aW9uICovDQo+PiAgWEVOX0NQVUZFQVRVUkUoTU9WRElSSSwg ICAgICAgNiozMisyNykgLyphICBNT1ZESVJJIGluc3RydWN0aW9uICovDQo+PiAgWEVOX0NQVUZF QVRVUkUoTU9WRElSNjRCLCAgICAgNiozMisyOCkgLyphICBNT1ZESVI2NEIgaW5zdHJ1Y3Rpb24g Ki8NCj4+ICBYRU5fQ1BVRkVBVFVSRShFTlFDTUQsICAgICAgICA2KjMyKzI5KSAvKiAgIEVOUUNN RHssU30gaW5zdHJ1Y3Rpb25zICovDQo+PiAtWEVOX0NQVUZFQVRVUkUoUEtTLCAgICAgICAgICAg NiozMiszMSkgLyogICBQcm90ZWN0aW9uIEtleSBmb3IgU3VwZXJ2aXNvciAqLw0KPj4gK1hFTl9D UFVGRUFUVVJFKFBLUywgICAgICAgICAgIDYqMzIrMzEpIC8qSCAgUHJvdGVjdGlvbiBLZXkgZm9y IFN1cGVydmlzb3IgKi8NCj4gLi4uIGNsYXJpZnkgdGhpcyByZXN0cmljdGlvbiBvZiBub3QgY292 ZXJpbmcgc2hhZG93IG1vZGUgZ3Vlc3RzIGJ5DQo+IGFuIGFkanVzdG1lbnQgdG8gdGl0bGUgb3Ig ZGVzY3JpcHRpb24uIEFpdWkgdGhlIHNvbGUgcmVhc29uIGZvcg0KPiB0aGUgcmVzdHJpY3Rpb24g aXMgdGhhdCBzaGFkb3cgY29kZSBkb2Vzbid0IHByb3BhZ2F0ZSB0aGUga2V5IGJpdHMNCj4gZnJv bSBndWVzdCB0byBzaGFkb3cgUFRFcz8NCg0KUEtVIGlzIG9ubHkgZXhwb3NlZCBvbiBIQVAsIHNv IFBLUyByZWFsbHkgb3VnaHQgdG8gbWF0Y2guDQoNCldlIGluZGVlZCBkb24ndCBjb3B5IHRoZSBs ZWFmIFBLRVkgaW50byB0aGUgc2hhZG93cy7CoCBXaGlsZSB0aGF0IG91Z2h0DQp0byBiZSByZWxh dGl2ZWx5IHRvIGFkanVzdCwgd2Ugd291bGQgdGhlbiBoYXZlIHRvIG1ha2Ugc2hfcGFnZV9mYXVs dCgpDQpjb3BlIHdpdGggc2VlaW5nIFBGRUNfcHJvdF9rZXkuDQoNCkJ1dCBob25lc3RseSwgdGhl cmUgYXJlIGZhciBmYXIgbW9yZSBpbXBvcnRhbnQgdGhpbmdzIHRvIHNwZW5kIHRpbWUgb24uDQoN Cn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Mon Jan 09 17:34:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 17:34:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473922.734768 (Exim 4.92) (envelope-from ) id 1pEw2i-0001Ap-9k; Mon, 09 Jan 2023 17:34:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473922.734768; Mon, 09 Jan 2023 17:34:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEw2i-0001Ai-7E; Mon, 09 Jan 2023 17:34:40 +0000 Received: by outflank-mailman (input) for mailman id 473922; Mon, 09 Jan 2023 17:34:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEw2g-0001AU-S9; Mon, 09 Jan 2023 17:34:38 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEw2g-0004Ja-RZ; Mon, 09 Jan 2023 17:34:38 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEw2g-0001dG-IM; Mon, 09 Jan 2023 17:34:38 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pEw2g-0001Q3-Hp; Mon, 09 Jan 2023 17:34:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=bm4+xQZPeismvCZ6fSoVnBkCP82UfyiJyB+/a3WbQAI=; b=O0gjJhXUgqQ82IH/u0XFukdOYn sjuA/VoheqY5mh+9ByAtFM9nzwYIiju1f+M2Q7TECUKs2z/oE5VvSrjkeCIgm6WC2BLDKnPJtmRlW Z5cBlWaA5ztEgvXNbhoNgi+1584rfhAJee2CO9+gGkmNoFLTHZuGPcfvLZUn7mRUJq6g=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 175644: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=38525f6f73f906699f77a1af86c16b4eaad48e04 X-Osstest-Versions-That: xen=2b21cbbb339fb14414f357a6683b1df74c36fda2 From: osstest service owner Date: Mon, 09 Jan 2023 17:34:38 +0000 flight 175644 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/175644/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 38525f6f73f906699f77a1af86c16b4eaad48e04 baseline version: xen 2b21cbbb339fb14414f357a6683b1df74c36fda2 Last test of basis 175593 2023-01-05 20:00:28 Z 3 days Testing same since 175644 2023-01-09 14:00:27 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich Julien Grall Oleksii Kurochko jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 2b21cbbb33..38525f6f73 38525f6f73f906699f77a1af86c16b4eaad48e04 -> smoke From xen-devel-bounces@lists.xenproject.org Mon Jan 09 17:40:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 17:40:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473932.734780 (Exim 4.92) (envelope-from ) id 1pEw80-0002d2-Tl; Mon, 09 Jan 2023 17:40:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473932.734780; Mon, 09 Jan 2023 17:40:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEw80-0002cv-QR; Mon, 09 Jan 2023 17:40:08 +0000 Received: by outflank-mailman (input) for mailman id 473932; Mon, 09 Jan 2023 17:40:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEw7z-0002cl-Iy; Mon, 09 Jan 2023 17:40:07 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEw7z-0004QH-EB; Mon, 09 Jan 2023 17:40:07 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEw7z-0001kK-42; Mon, 09 Jan 2023 17:40:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pEw7z-0002Cg-3W; Mon, 09 Jan 2023 17:40:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To; bh=KRdMCemvCA0LBp8ZLkzySDygNsIFdx2hVtjAUWw/oKk=; b=Fd12oRO4aXNj2X0cDQSP/8eV5w ODQX2B3ij++9E8lfkB9ktrayPHHyeges0oKHow55wwHHLKeVnuviwusxcoHTqMeLBVh3bf2/B3gZN ZUzMzlbdxrdMrwvorXPd2Rld3xfY35z1btOlh9AgcjtXXqmSDrBhlOCtjWFziuE/tDfg=; To: xen-devel@lists.xenproject.org Subject: [qemu-mainline bisection] complete build-amd64-xsm Message-Id: From: osstest service owner Date: Mon, 09 Jan 2023 17:40:07 +0000 branch xen-unstable xenbranch xen-unstable job build-amd64-xsm testid xen-build Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://git.qemu.org/qemu.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git *** Found and reproduced problem changeset *** Bug is in tree: qemuu git://git.qemu.org/qemu.git Bug introduced: 3d83b78285d6e96636130f7d449fd02e2d4deee0 Bug not present: 528d9f33cad5245c1099d77084c78bb2244d5143 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/175650/ commit 3d83b78285d6e96636130f7d449fd02e2d4deee0 Merge: 528d9f33ca fb418b51b7 Author: Peter Maydell Date: Sun Jan 8 14:27:40 2023 +0000 Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging * Atomic memslot updates for KVM (Emanuele, David) * Always send errors to logfile when daemonized (Greg) * Add support for IDE CompactFlash card (Lubomir) * First round of build system cleanups (myself) * First round of feature removals (myself) * Reduce "qemu/accel.h" inclusion (Philippe) # gpg: Signature made Thu 05 Jan 2023 23:51:09 GMT # gpg: using RSA key F13338574B662389866C7682BFFBD25F78C7AE83 # gpg: issuer "pbonzini@redhat.com" # gpg: Good signature from "Paolo Bonzini " [full] # gpg: aka "Paolo Bonzini " [full] # Primary key fingerprint: 46F5 9FBD 57D6 12E7 BFD4 E2F7 7E15 100C CD36 69B1 # Subkey fingerprint: F133 3857 4B66 2389 866C 7682 BFFB D25F 78C7 AE83 * tag 'for-upstream' of https://gitlab.com/bonzini/qemu: (24 commits) i386: SGX: remove deprecated member of SGXInfo target/i386: Add SGX aex-notify and EDECCSSA support util: remove support -chardev tty and -chardev parport util: remove support for hex numbers with a scaling suffix KVM: remove support for kernel-irqchip=off docs: do not talk about past removal as happening in the future meson: accept relative symlinks in "meson introspect --installed" data meson: cleanup compiler detection meson: support meson 0.64 -Doptimization=plain configure: test all warnings tests/qapi-schema: remove Meson workaround meson: cleanup dummy-cpus.c rules meson: tweak hardening options for Windows configure: remove backwards-compatibility and obsolete options configure: preserve qemu-ga variables configure: cleanup $cpu tests configure: remove dead function configure: remove useless write_c_skeleton ide: Add "ide-cf" driver, a CompactFlash card ide: Add 8-bit data mode ... Signed-off-by: Peter Maydell commit fb418b51b7b43c34873f4b9af3da7031b7452115 Author: Paolo Bonzini Date: Fri Dec 16 11:02:48 2022 +0100 i386: SGX: remove deprecated member of SGXInfo Signed-off-by: Paolo Bonzini commit d45f24fe7525d8a8aaa4ca6d9d214dc41819caa5 Author: Kai Huang Date: Wed Nov 9 15:48:34 2022 +1300 target/i386: Add SGX aex-notify and EDECCSSA support The new SGX Asynchronous Exit (AEX) notification mechanism (AEX-notify) allows one enclave to receive a notification in the ERESUME after the enclave exit due to an AEX. EDECCSSA is a new SGX user leaf function (ENCLU[EDECCSSA]) to facilitate the AEX notification handling. Whether the hardware supports to create enclave with AEX-notify support is enumerated via CPUID.(EAX=0x12,ECX=0x1):EAX[10]. The new EDECCSSA user leaf function is enumerated via CPUID.(EAX=0x12,ECX=0x0):EAX[11]. Add support to allow to expose the new SGX AEX-notify feature and the new EDECCSSA user leaf function to KVM guest. Link: https://lore.kernel.org/lkml/166760360549.4906.809756297092548496.tip-bot2@tip-bot2/ Link: https://lore.kernel.org/lkml/166760360934.4906.2427175408052308969.tip-bot2@tip-bot2/ Reviewed-by: Yang Zhong Signed-off-by: Kai Huang Message-Id: <20221109024834.172705-1-kai.huang@intel.com> Signed-off-by: Paolo Bonzini commit 6f9f630836df355b9ca3f4641e6b7be71f6af076 Author: Paolo Bonzini Date: Fri Dec 16 10:56:53 2022 +0100 util: remove support -chardev tty and -chardev parport These were deprecated in 6.0 and can now be removed. Signed-off-by: Paolo Bonzini commit 8b902e3d2309595567e4957b96e971c4f3ca455e Author: Paolo Bonzini Date: Fri Dec 16 10:50:05 2022 +0100 util: remove support for hex numbers with a scaling suffix This was deprecated in 6.0 and can now be removed. Signed-off-by: Paolo Bonzini commit eaaaf8abdc9a9f3493f2cb6a751660dff3f9db57 Author: Paolo Bonzini Date: Fri Dec 16 10:39:32 2022 +0100 KVM: remove support for kernel-irqchip=off -machine kernel-irqchip=off is broken for many guest OSes; kernel-irqchip=split is the replacement that works, so remove the deprecated support for the former. Signed-off-by: Paolo Bonzini commit 9d3f8b3247795ae8f482700bbbace04b04421d5b Author: Paolo Bonzini Date: Fri Dec 16 11:05:20 2022 +0100 docs: do not talk about past removal as happening in the future KVM guest support on 32-bit Arm hosts *has* been removed, so rephrase the sentence describing it. Signed-off-by: Paolo Bonzini commit f32eb0021a85efaca97f69b0e9201737562a8e4f Author: Paolo Bonzini Date: Wed Dec 14 13:25:00 2022 +0100 meson: accept relative symlinks in "meson introspect --installed" data When installing shared libraries, as is the case for libvfio-user.so, Meson will include relative symbolic links in the output of "meson introspect --installed": { "libvfio-user.so": "/usr/local/lib64/libvfio-user.so", ... } In the case of scripts/symlink-install-tree.py, this will be a symbolic link to a symbolic link but, in any case, there is no issue in creating it. Cc: qemu-stable@nongnu.org Signed-off-by: Paolo Bonzini commit e51340243687a2cd7ffcf0d6e2de030bed4b8720 Author: Paolo Bonzini Date: Wed Oct 12 14:15:06 2022 +0200 meson: cleanup compiler detection Detect all compilers at the beginning of meson.build, and store the available languages in an array. Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit 6a97f3939240977e66e90862419911666956a76a Author: Paolo Bonzini Date: Wed Nov 2 13:07:23 2022 +0100 meson: support meson 0.64 -Doptimization=plain In Meson 0.64, the optimization built-in option now accepts the "plain" value, which will not set any optimization flags. While QEMU does not check the contents of the option and therefore does not suffer any ill effect from the new value, it uses get_option to print the optimization flags in the summary. Clean the code up to remove duplication, and check for -Doptimization=plain at the same time. Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit ca9b5c2ebf1aca87677a24c208bf3d0345c0b1aa Author: Paolo Bonzini Date: Wed Oct 12 14:21:22 2022 +0200 configure: test all warnings Some warnings are hardcoded in QEMU_CFLAGS and not tested. There is no particular reason to single out these five, as many more -W flags are present on all the supported compilers. For homogeneity when moving the detection to meson, make them use the same warn_flags infrastructure. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Paolo Bonzini commit 7bef93ff064f540e24a36a31263ae3db2d06b3d2 Author: Paolo Bonzini Date: Wed Dec 14 12:29:11 2022 +0100 tests/qapi-schema: remove Meson workaround The referenced issue has been fixed since version 0.61, so remove the workaround. Signed-off-by: Paolo Bonzini commit 9c9b85d705abdcce0b63f9182d8140dd67bd13fb Author: Paolo Bonzini Date: Thu Jul 22 10:43:00 2021 +0200 meson: cleanup dummy-cpus.c rules Now that qtest is available on all targets including Windows, dummy-cpus.c is included unconditionally in the build. It also does not need to be compiled per-target. Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit 2d73fa74728dccde5cc29c4e56b4d781e4ead7c4 Author: Paolo Bonzini Date: Wed Nov 2 13:03:51 2022 +0100 meson: tweak hardening options for Windows meson.build has been enabling ASLR _only_ for debug builds since commit d2147e04f95f ("configure: move Windows flags detection to meson", 2022-05-07); instead it was supposed to disable it for debug builds. However, the flag has been enabled for DLLs upstream for roughly 2 years (https://sourceware.org/bugzilla/show_bug.cgi?id=19011), and also by some distros including Debian for 6 years even (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=836365). Enable it unconditionally; we can fix the reversed logic of commit d2147e04f95f later if there are any reports, but for now just enable the hardening. Also add -Wl,--high-entropy-va, which also controls ASLR. Signed-off-by: Paolo Bonzini commit 10229ec3b0ff77c4894cefa312c21e65a761dcde Author: Paolo Bonzini Date: Tue Oct 18 10:17:46 2022 +0200 configure: remove backwards-compatibility and obsolete options Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit 954ed68f9934a3e08f904acb93ce168505995e95 Author: Paolo Bonzini Date: Wed Oct 12 11:35:17 2022 +0200 configure: preserve qemu-ga variables Ensure that qemu-ga variables set at configure time are kept later when the script is rerun. For preserve_env to work, the variables need to be empty so move the default values to config-host.mak generation. Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit f9c77801f4992fae99392ccbb60596dfa1fcf04a Author: Paolo Bonzini Date: Wed Oct 12 15:27:03 2022 +0200 configure: cleanup $cpu tests $cpu is derived from preprocessor defines rather than uname these days, so do not bother using isainfo on Solaris. Likewise do not recognize BeOS's uname -m output. Keep the other, less OS-specific canonicalizations for the benefit of people using --cpu. Reviewed-by: Peter Maydell Signed-off-by: Paolo Bonzini commit 91cd485a6dcbc8210666d19146fe73b8664f0418 Author: Paolo Bonzini Date: Tue Oct 18 10:17:25 2022 +0200 configure: remove dead function Reviewed-by: Peter Maydell Signed-off-by: Paolo Bonzini commit c5634e822416e71e00f08f55a521362d8d21264d Author: Paolo Bonzini Date: Thu Oct 20 14:20:06 2022 +0200 configure: remove useless write_c_skeleton This is not needed ever since QEMU stopped detecting -liberty; this happened with the Meson switch but it is quite likely that the library was not really necessary years before. Reviewed-by: Peter Maydell Signed-off-by: Paolo Bonzini commit cec79db38df72ce74d0296b831e90547111bc13c Author: Lubomir Rintel Date: Wed Nov 30 13:03:19 2022 +0100 ide: Add "ide-cf" driver, a CompactFlash card This allows attaching IDE_CFATA device to an IDE bus. Behaves like a CompactFlash card in True IDE mode. Tested with: qemu-system-i386 \$ -device driver=ide-cf,drive=cf,bus=ide.0 \$ -drive id=cf,index=0,format=raw,if=none,file=cf.img Signed-off-by: Lubomir Rintel Message-Id: <20221130120319.706885-1-lkundrak@v3.sk> Signed-off-by: Paolo Bonzini commit 1ea17d228e582b1cfbf6f61e9da5fafef4063be8 Author: Lubomir Rintel Date: Wed Nov 30 13:02:38 2022 +0100 ide: Add 8-bit data mode CompactFlash uses features 0x01 and 0x81 to enable/disable 8-bit data path. Implement them. Signed-off-by: Lubomir Rintel Message-Id: <20221130120238.706717-1-lkundrak@v3.sk> Signed-off-by: Paolo Bonzini commit 9b063b7ea697d796914b3651d15c3457b7b1135c Author: Greg Kurz Date: Tue Nov 8 15:00:32 2022 +0100 util/log: Always send errors to logfile when daemonized When QEMU is started with `-daemonize`, all stdio descriptors get redirected to `/dev/null`. This basically means that anything printed with error_report() and friends is lost. Current logging code allows to redirect to a file with `-D` but this requires to enable some logging item with `-d` as well to be functional. Relax the check on the log flags when QEMU is daemonized, so that other users of stderr can benefit from the redirection, without the need to enable unwanted debug logs. Previous behaviour is retained for the non-daemonized case. The logic is unrolled as an `if` for better readability. The qemu_log_level and log_per_thread globals reflect the state we want to transition to at this point : use them instead of the intermediary locals for correctness. qemu_set_log_internal() is adapted to open a per-thread log file when '-d tid' is passed. This is done by hijacking qemu_try_lock() which seems simpler that refactoring the code. Signed-off-by: Greg Kurz Message-Id: <20221108140032.1460307-3-groug@kaod.org> Signed-off-by: Paolo Bonzini commit 59bde2137445b63c822720d069d91d38190c6540 Author: Paolo Bonzini Date: Tue Nov 8 15:00:31 2022 +0100 util/log: do not close and reopen log files when flags are turned off log_append makes sure that if you turn off the logging (which clears log_flags and makes need_to_open_file false) the old log is not overwritten. The usecase is that if you remove or move the file QEMU will not keep writing to the old file. However, this is not always the desited behavior, in particular having log_append==1 after changing the file name makes little sense. When qemu_set_log_internal is called from the logfile monitor command, filename must be non-NULL and therefore changed_name must be true. Therefore, the only case where the file is closed and need_to_open_file == false is indeed when log_flags becomes zero. In this case, just flush the file and do not bother closing it, thus faking the same append behavior as previously. The behavioral change is that changing the logfile twice, for example log1 -> log2 -> log1, will cause log1 to be overwritten. This can simply be documented, since it is not a particularly surprising behavior. Suggested-by: Alex Bennée Signed-off-by: Paolo Bonzini Reviewed-by: Richard Henderson Reviewed-by: Greg Kurz Message-Id: <20221025092119.236224-1-pbonzini@redhat.com> [groug: nullify global_file before actually closing the file] Signed-off-by: Greg Kurz Message-Id: <20221108140032.1460307-2-groug@kaod.org> Signed-off-by: Paolo Bonzini commit cc6ff741123216550997b12cdd991beeed47bd0d Author: Philippe Mathieu-Daudé Date: Wed Nov 30 14:56:41 2022 +0100 hw: Reduce "qemu/accel.h" inclusion Move "qemu/accel.h" include from the heavily included "hw/boards.h" to hw/core/machine.c, the single file using the AccelState definition. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Fabiano Rosas Message-Id: <20221130135641.85328-3-philmd@linaro.org> Signed-off-by: Paolo Bonzini commit 3d277871f39d4de42f56b7b0cef5721e525b2d31 Author: Philippe Mathieu-Daudé Date: Wed Nov 30 14:56:40 2022 +0100 typedefs: Forward-declare AccelState Forward-declare AccelState in "qemu/typedefs.h" so structures using a reference of it (like MachineState in "hw/boards.h") don't have to include "qemu/accel.h". Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Fabiano Rosas Message-Id: <20221130135641.85328-2-philmd@linaro.org> Signed-off-by: Paolo Bonzini For bisection revision-tuple graph see: http://logs.test-lab.xenproject.org/osstest/results/bisect/qemu-mainline/build-amd64-xsm.xen-build.html Revision IDs in each graph node refer, respectively, to the Trees above. ---------------------------------------- Running cs-bisection-step --graph-out=/home/logs/results/bisect/qemu-mainline/build-amd64-xsm.xen-build --summary-out=tmp/175650.bisection-summary --basis-template=175623 --blessings=real,real-bisect,real-retry qemu-mainline build-amd64-xsm xen-build Searching for failure / basis pass: 175643 fail [host=himrod0] / 175637 [host=himrod2] 175627 ok. Failure / basis pass flights: 175643 / 175627 (tree with no url: minios) Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://git.qemu.org/qemu.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git Latest d8d829b89dababf763ab33b8cdd852b2830db3cf 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 3d83b78285d6e96636130f7d449fd02e2d4deee0 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 Basis pass d8d829b89dababf763ab33b8cdd852b2830db3cf 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 528d9f33cad5245c1099d77084c78bb2244d5143 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 Generating revisions with ./adhoc-revtuple-generator git://xenbits.xen.org/osstest/ovmf.git#d8d829b89dababf763ab33b8cdd852b2830db3cf-d8d829b89dababf763ab33b8cdd852b2830db3cf git://xenbits.xen.org/qemu-xen-traditional.git#3d273dd05e51e5a1ffba3d98c7437ee84e8f8764-3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 git://git.qemu.org/qemu.git#528d9f33cad5245c1099d77084c78bb2244d5143-3d83b78285d6e96636130f7d449fd02e2d4deee0 git://xenbits.xen.org/osstest/seabios.git#645a64b4911d7cadf5749d7375544fc2384e70ba-645\ a64b4911d7cadf5749d7375544fc2384e70ba git://xenbits.xen.org/xen.git#2b21cbbb339fb14414f357a6683b1df74c36fda2-2b21cbbb339fb14414f357a6683b1df74c36fda2 Loaded 5002 nodes in revision graph Searching for test results: 175627 pass d8d829b89dababf763ab33b8cdd852b2830db3cf 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 528d9f33cad5245c1099d77084c78bb2244d5143 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 175637 [host=himrod2] 175643 fail d8d829b89dababf763ab33b8cdd852b2830db3cf 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 3d83b78285d6e96636130f7d449fd02e2d4deee0 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 175646 pass d8d829b89dababf763ab33b8cdd852b2830db3cf 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 528d9f33cad5245c1099d77084c78bb2244d5143 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 175648 fail d8d829b89dababf763ab33b8cdd852b2830db3cf 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 3d83b78285d6e96636130f7d449fd02e2d4deee0 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 175649 pass d8d829b89dababf763ab33b8cdd852b2830db3cf 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 528d9f33cad5245c1099d77084c78bb2244d5143 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 175650 fail d8d829b89dababf763ab33b8cdd852b2830db3cf 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 3d83b78285d6e96636130f7d449fd02e2d4deee0 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 Searching for interesting versions Result found: flight 175627 (pass), for basis pass Result found: flight 175643 (fail), for basis failure Repro found: flight 175646 (pass), for basis pass Repro found: flight 175648 (fail), for basis failure 0 revisions at d8d829b89dababf763ab33b8cdd852b2830db3cf 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 528d9f33cad5245c1099d77084c78bb2244d5143 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 No revisions left to test, checking graph state. Result found: flight 175627 (pass), for last pass Result found: flight 175643 (fail), for first failure Repro found: flight 175646 (pass), for last pass Repro found: flight 175648 (fail), for first failure Repro found: flight 175649 (pass), for last pass Repro found: flight 175650 (fail), for first failure *** Found and reproduced problem changeset *** Bug is in tree: qemuu git://git.qemu.org/qemu.git Bug introduced: 3d83b78285d6e96636130f7d449fd02e2d4deee0 Bug not present: 528d9f33cad5245c1099d77084c78bb2244d5143 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/175650/ commit 3d83b78285d6e96636130f7d449fd02e2d4deee0 Merge: 528d9f33ca fb418b51b7 Author: Peter Maydell Date: Sun Jan 8 14:27:40 2023 +0000 Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging * Atomic memslot updates for KVM (Emanuele, David) * Always send errors to logfile when daemonized (Greg) * Add support for IDE CompactFlash card (Lubomir) * First round of build system cleanups (myself) * First round of feature removals (myself) * Reduce "qemu/accel.h" inclusion (Philippe) # gpg: Signature made Thu 05 Jan 2023 23:51:09 GMT # gpg: using RSA key F13338574B662389866C7682BFFBD25F78C7AE83 # gpg: issuer "pbonzini@redhat.com" # gpg: Good signature from "Paolo Bonzini " [full] # gpg: aka "Paolo Bonzini " [full] # Primary key fingerprint: 46F5 9FBD 57D6 12E7 BFD4 E2F7 7E15 100C CD36 69B1 # Subkey fingerprint: F133 3857 4B66 2389 866C 7682 BFFB D25F 78C7 AE83 * tag 'for-upstream' of https://gitlab.com/bonzini/qemu: (24 commits) i386: SGX: remove deprecated member of SGXInfo target/i386: Add SGX aex-notify and EDECCSSA support util: remove support -chardev tty and -chardev parport util: remove support for hex numbers with a scaling suffix KVM: remove support for kernel-irqchip=off docs: do not talk about past removal as happening in the future meson: accept relative symlinks in "meson introspect --installed" data meson: cleanup compiler detection meson: support meson 0.64 -Doptimization=plain configure: test all warnings tests/qapi-schema: remove Meson workaround meson: cleanup dummy-cpus.c rules meson: tweak hardening options for Windows configure: remove backwards-compatibility and obsolete options configure: preserve qemu-ga variables configure: cleanup $cpu tests configure: remove dead function configure: remove useless write_c_skeleton ide: Add "ide-cf" driver, a CompactFlash card ide: Add 8-bit data mode ... Signed-off-by: Peter Maydell commit fb418b51b7b43c34873f4b9af3da7031b7452115 Author: Paolo Bonzini Date: Fri Dec 16 11:02:48 2022 +0100 i386: SGX: remove deprecated member of SGXInfo Signed-off-by: Paolo Bonzini commit d45f24fe7525d8a8aaa4ca6d9d214dc41819caa5 Author: Kai Huang Date: Wed Nov 9 15:48:34 2022 +1300 target/i386: Add SGX aex-notify and EDECCSSA support The new SGX Asynchronous Exit (AEX) notification mechanism (AEX-notify) allows one enclave to receive a notification in the ERESUME after the enclave exit due to an AEX. EDECCSSA is a new SGX user leaf function (ENCLU[EDECCSSA]) to facilitate the AEX notification handling. Whether the hardware supports to create enclave with AEX-notify support is enumerated via CPUID.(EAX=0x12,ECX=0x1):EAX[10]. The new EDECCSSA user leaf function is enumerated via CPUID.(EAX=0x12,ECX=0x0):EAX[11]. Add support to allow to expose the new SGX AEX-notify feature and the new EDECCSSA user leaf function to KVM guest. Link: https://lore.kernel.org/lkml/166760360549.4906.809756297092548496.tip-bot2@tip-bot2/ Link: https://lore.kernel.org/lkml/166760360934.4906.2427175408052308969.tip-bot2@tip-bot2/ Reviewed-by: Yang Zhong Signed-off-by: Kai Huang Message-Id: <20221109024834.172705-1-kai.huang@intel.com> Signed-off-by: Paolo Bonzini commit 6f9f630836df355b9ca3f4641e6b7be71f6af076 Author: Paolo Bonzini Date: Fri Dec 16 10:56:53 2022 +0100 util: remove support -chardev tty and -chardev parport These were deprecated in 6.0 and can now be removed. Signed-off-by: Paolo Bonzini commit 8b902e3d2309595567e4957b96e971c4f3ca455e Author: Paolo Bonzini Date: Fri Dec 16 10:50:05 2022 +0100 util: remove support for hex numbers with a scaling suffix This was deprecated in 6.0 and can now be removed. Signed-off-by: Paolo Bonzini commit eaaaf8abdc9a9f3493f2cb6a751660dff3f9db57 Author: Paolo Bonzini Date: Fri Dec 16 10:39:32 2022 +0100 KVM: remove support for kernel-irqchip=off -machine kernel-irqchip=off is broken for many guest OSes; kernel-irqchip=split is the replacement that works, so remove the deprecated support for the former. Signed-off-by: Paolo Bonzini commit 9d3f8b3247795ae8f482700bbbace04b04421d5b Author: Paolo Bonzini Date: Fri Dec 16 11:05:20 2022 +0100 docs: do not talk about past removal as happening in the future KVM guest support on 32-bit Arm hosts *has* been removed, so rephrase the sentence describing it. Signed-off-by: Paolo Bonzini commit f32eb0021a85efaca97f69b0e9201737562a8e4f Author: Paolo Bonzini Date: Wed Dec 14 13:25:00 2022 +0100 meson: accept relative symlinks in "meson introspect --installed" data When installing shared libraries, as is the case for libvfio-user.so, Meson will include relative symbolic links in the output of "meson introspect --installed": { "libvfio-user.so": "/usr/local/lib64/libvfio-user.so", ... } In the case of scripts/symlink-install-tree.py, this will be a symbolic link to a symbolic link but, in any case, there is no issue in creating it. Cc: qemu-stable@nongnu.org Signed-off-by: Paolo Bonzini commit e51340243687a2cd7ffcf0d6e2de030bed4b8720 Author: Paolo Bonzini Date: Wed Oct 12 14:15:06 2022 +0200 meson: cleanup compiler detection Detect all compilers at the beginning of meson.build, and store the available languages in an array. Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit 6a97f3939240977e66e90862419911666956a76a Author: Paolo Bonzini Date: Wed Nov 2 13:07:23 2022 +0100 meson: support meson 0.64 -Doptimization=plain In Meson 0.64, the optimization built-in option now accepts the "plain" value, which will not set any optimization flags. While QEMU does not check the contents of the option and therefore does not suffer any ill effect from the new value, it uses get_option to print the optimization flags in the summary. Clean the code up to remove duplication, and check for -Doptimization=plain at the same time. Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit ca9b5c2ebf1aca87677a24c208bf3d0345c0b1aa Author: Paolo Bonzini Date: Wed Oct 12 14:21:22 2022 +0200 configure: test all warnings Some warnings are hardcoded in QEMU_CFLAGS and not tested. There is no particular reason to single out these five, as many more -W flags are present on all the supported compilers. For homogeneity when moving the detection to meson, make them use the same warn_flags infrastructure. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Paolo Bonzini commit 7bef93ff064f540e24a36a31263ae3db2d06b3d2 Author: Paolo Bonzini Date: Wed Dec 14 12:29:11 2022 +0100 tests/qapi-schema: remove Meson workaround The referenced issue has been fixed since version 0.61, so remove the workaround. Signed-off-by: Paolo Bonzini commit 9c9b85d705abdcce0b63f9182d8140dd67bd13fb Author: Paolo Bonzini Date: Thu Jul 22 10:43:00 2021 +0200 meson: cleanup dummy-cpus.c rules Now that qtest is available on all targets including Windows, dummy-cpus.c is included unconditionally in the build. It also does not need to be compiled per-target. Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit 2d73fa74728dccde5cc29c4e56b4d781e4ead7c4 Author: Paolo Bonzini Date: Wed Nov 2 13:03:51 2022 +0100 meson: tweak hardening options for Windows meson.build has been enabling ASLR _only_ for debug builds since commit d2147e04f95f ("configure: move Windows flags detection to meson", 2022-05-07); instead it was supposed to disable it for debug builds. However, the flag has been enabled for DLLs upstream for roughly 2 years (https://sourceware.org/bugzilla/show_bug.cgi?id=19011), and also by some distros including Debian for 6 years even (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=836365). Enable it unconditionally; we can fix the reversed logic of commit d2147e04f95f later if there are any reports, but for now just enable the hardening. Also add -Wl,--high-entropy-va, which also controls ASLR. Signed-off-by: Paolo Bonzini commit 10229ec3b0ff77c4894cefa312c21e65a761dcde Author: Paolo Bonzini Date: Tue Oct 18 10:17:46 2022 +0200 configure: remove backwards-compatibility and obsolete options Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit 954ed68f9934a3e08f904acb93ce168505995e95 Author: Paolo Bonzini Date: Wed Oct 12 11:35:17 2022 +0200 configure: preserve qemu-ga variables Ensure that qemu-ga variables set at configure time are kept later when the script is rerun. For preserve_env to work, the variables need to be empty so move the default values to config-host.mak generation. Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit f9c77801f4992fae99392ccbb60596dfa1fcf04a Author: Paolo Bonzini Date: Wed Oct 12 15:27:03 2022 +0200 configure: cleanup $cpu tests $cpu is derived from preprocessor defines rather than uname these days, so do not bother using isainfo on Solaris. Likewise do not recognize BeOS's uname -m output. Keep the other, less OS-specific canonicalizations for the benefit of people using --cpu. Reviewed-by: Peter Maydell Signed-off-by: Paolo Bonzini commit 91cd485a6dcbc8210666d19146fe73b8664f0418 Author: Paolo Bonzini Date: Tue Oct 18 10:17:25 2022 +0200 configure: remove dead function Reviewed-by: Peter Maydell Signed-off-by: Paolo Bonzini commit c5634e822416e71e00f08f55a521362d8d21264d Author: Paolo Bonzini Date: Thu Oct 20 14:20:06 2022 +0200 configure: remove useless write_c_skeleton This is not needed ever since QEMU stopped detecting -liberty; this happened with the Meson switch but it is quite likely that the library was not really necessary years before. Reviewed-by: Peter Maydell Signed-off-by: Paolo Bonzini commit cec79db38df72ce74d0296b831e90547111bc13c Author: Lubomir Rintel Date: Wed Nov 30 13:03:19 2022 +0100 ide: Add "ide-cf" driver, a CompactFlash card This allows attaching IDE_CFATA device to an IDE bus. Behaves like a CompactFlash card in True IDE mode. Tested with: qemu-system-i386 \$ -device driver=ide-cf,drive=cf,bus=ide.0 \$ -drive id=cf,index=0,format=raw,if=none,file=cf.img Signed-off-by: Lubomir Rintel Message-Id: <20221130120319.706885-1-lkundrak@v3.sk> Signed-off-by: Paolo Bonzini commit 1ea17d228e582b1cfbf6f61e9da5fafef4063be8 Author: Lubomir Rintel Date: Wed Nov 30 13:02:38 2022 +0100 ide: Add 8-bit data mode CompactFlash uses features 0x01 and 0x81 to enable/disable 8-bit data path. Implement them. Signed-off-by: Lubomir Rintel Message-Id: <20221130120238.706717-1-lkundrak@v3.sk> Signed-off-by: Paolo Bonzini commit 9b063b7ea697d796914b3651d15c3457b7b1135c Author: Greg Kurz Date: Tue Nov 8 15:00:32 2022 +0100 util/log: Always send errors to logfile when daemonized When QEMU is started with `-daemonize`, all stdio descriptors get redirected to `/dev/null`. This basically means that anything printed with error_report() and friends is lost. Current logging code allows to redirect to a file with `-D` but this requires to enable some logging item with `-d` as well to be functional. Relax the check on the log flags when QEMU is daemonized, so that other users of stderr can benefit from the redirection, without the need to enable unwanted debug logs. Previous behaviour is retained for the non-daemonized case. The logic is unrolled as an `if` for better readability. The qemu_log_level and log_per_thread globals reflect the state we want to transition to at this point : use them instead of the intermediary locals for correctness. qemu_set_log_internal() is adapted to open a per-thread log file when '-d tid' is passed. This is done by hijacking qemu_try_lock() which seems simpler that refactoring the code. Signed-off-by: Greg Kurz Message-Id: <20221108140032.1460307-3-groug@kaod.org> Signed-off-by: Paolo Bonzini commit 59bde2137445b63c822720d069d91d38190c6540 Author: Paolo Bonzini Date: Tue Nov 8 15:00:31 2022 +0100 util/log: do not close and reopen log files when flags are turned off log_append makes sure that if you turn off the logging (which clears log_flags and makes need_to_open_file false) the old log is not overwritten. The usecase is that if you remove or move the file QEMU will not keep writing to the old file. However, this is not always the desited behavior, in particular having log_append==1 after changing the file name makes little sense. When qemu_set_log_internal is called from the logfile monitor command, filename must be non-NULL and therefore changed_name must be true. Therefore, the only case where the file is closed and need_to_open_file == false is indeed when log_flags becomes zero. In this case, just flush the file and do not bother closing it, thus faking the same append behavior as previously. The behavioral change is that changing the logfile twice, for example log1 -> log2 -> log1, will cause log1 to be overwritten. This can simply be documented, since it is not a particularly surprising behavior. Suggested-by: Alex Bennée Signed-off-by: Paolo Bonzini Reviewed-by: Richard Henderson Reviewed-by: Greg Kurz Message-Id: <20221025092119.236224-1-pbonzini@redhat.com> [groug: nullify global_file before actually closing the file] Signed-off-by: Greg Kurz Message-Id: <20221108140032.1460307-2-groug@kaod.org> Signed-off-by: Paolo Bonzini commit cc6ff741123216550997b12cdd991beeed47bd0d Author: Philippe Mathieu-Daudé Date: Wed Nov 30 14:56:41 2022 +0100 hw: Reduce "qemu/accel.h" inclusion Move "qemu/accel.h" include from the heavily included "hw/boards.h" to hw/core/machine.c, the single file using the AccelState definition. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Fabiano Rosas Message-Id: <20221130135641.85328-3-philmd@linaro.org> Signed-off-by: Paolo Bonzini commit 3d277871f39d4de42f56b7b0cef5721e525b2d31 Author: Philippe Mathieu-Daudé Date: Wed Nov 30 14:56:40 2022 +0100 typedefs: Forward-declare AccelState Forward-declare AccelState in "qemu/typedefs.h" so structures using a reference of it (like MachineState in "hw/boards.h") don't have to include "qemu/accel.h". Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Fabiano Rosas Message-Id: <20221130135641.85328-2-philmd@linaro.org> Signed-off-by: Paolo Bonzini Revision graph left in /home/logs/results/bisect/qemu-mainline/build-amd64-xsm.xen-build.{dot,ps,png,html,svg}. ---------------------------------------- 175650: tolerable ALL FAIL flight 175650 qemu-mainline real-bisect [real] http://logs.test-lab.xenproject.org/osstest/logs/175650/ Failures :-/ but no regressions. Tests which did not succeed, including tests which could not be run: build-amd64-xsm 6 xen-build fail baseline untested jobs: build-amd64-xsm fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary From xen-devel-bounces@lists.xenproject.org Mon Jan 09 17:53:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 17:53:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473942.734794 (Exim 4.92) (envelope-from ) id 1pEwKe-0004DJ-6Z; Mon, 09 Jan 2023 17:53:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473942.734794; Mon, 09 Jan 2023 17:53:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEwKe-0004DC-2a; Mon, 09 Jan 2023 17:53:12 +0000 Received: by outflank-mailman (input) for mailman id 473942; Mon, 09 Jan 2023 17:53:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEwKc-0004D6-Cu for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 17:53:10 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 78b69883-9046-11ed-91b6-6bf2151ebd3b; Mon, 09 Jan 2023 18:53:08 +0100 (CET) Received: from mail-mw2nam04lp2172.outbound.protection.outlook.com (HELO NAM04-MW2-obe.outbound.protection.outlook.com) ([104.47.73.172]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 Jan 2023 12:53:05 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BLAPR03MB5394.namprd03.prod.outlook.com (2603:10b6:208:294::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Mon, 9 Jan 2023 17:53:03 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5986.018; Mon, 9 Jan 2023 17:53:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 78b69883-9046-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1673286788; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=kgC5ZqTfr1fu+DVV7X2WRGv6Vbzidx9rgyxhFEl4Ccc=; b=hTfd++tqjjak7HRcffvGsCB708/NvnighnSknIU+9b5GlDpMcO7R2eMY 5U1aF2pzevnEkwULE/IXPnSjPJmjbJuiRsFMXc8HSgdFYeLH5FCMonqdP l4vFOL6CTrHnhZaOb+kD6ba/B7kTveHcBOo35XtMxomgcjLojy46aIrBp 0=; X-IronPort-RemoteIP: 104.47.73.172 X-IronPort-MID: 92216088 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:BW2HBanPy56B5i6uARHeWino5gxiJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xIfC2qOMq3cNjD8Ldpza4nn9U0FusfTyoBjGQVoqCo0RiMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icf3grHmeIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aqaVA8w5ARkPqgS5A6GzBH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 aQIKxoKVAGnvO2r8OKkeuRRt8oIF+C+aevzulk4pd3YJdAPZMifBoD1v5pf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVk1c3iee3WDbWUoXiqcF9t0CUv G/ZuU/+BQkXLoe3wjuZ6HO8wOTImEsXXapDTufhqKY60DV/wEQMDywyd3G0vMOSqXDjae5Wc HFT4AYH+P1aGEuDC4OVsweDiHmAsx0HWtsWEPAg7wqNya387AOQB2xCRTlEAPQ2uclzSTE02 1uhm9LyGScpoLCTUWia9LqfsXW1Iyd9BXQZeSYOQA8B4t/iiII+lBTCSpBkCqHdptL0EDf03 juDhDI/mbIIjMgAka68+DjviDu2qp/EZgU8/AnQUySu6QYRWWK+T4mh6Fye6OkaKo+cFgWFp CJdxJLY6/0SB5aQkiDLWP8KALyi+/eCNnvbnEJrGJ4isT+q/hZPYLxt3d23H28xWu5sRNMjS Ba7Vd95jHOLAEaXUA== IronPort-HdrOrdr: A9a23:RGwWD6p+XaPBUQS4NcJo5LwaV5oteYIsimQD101hICG9E/bo8f xG+c5x6faaslkssR0b9+xoW5PwIk80l6QV3WB5B97LNmSLhILPFvAB0WKI+V3d8kPFh4pg/J YlX69iCMDhSXhW5PyKhzVQyuxQpeW6zA== X-IronPort-AV: E=Sophos;i="5.96,311,1665460800"; d="scan'208";a="92216088" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AG/2JUCQ0GqhD2S+brMhc0rqSXpNscDO3P4gXZCQJXlKKtHFLB2Q+1ROmwMrubvJ+KM6F0tdkdEz34eeT/ahp+FNVtsi01MPkhuLjy5RQ/EWfr3OwBz8V9k4acRatpmcH9JLDnb0opacxPiw0bJBJ6rsyH5l2DPcVKe7maeV4F9XCLHLYkATsVk2owsF63DtenDTeQPBw7/cUtyghReglz+6egdZBheAX7KZx0pDCZva4s+BOtIPX7KC/WWK7aCPC/2o/IUQBCH85BZzZGQ3CqEmA6dhP1Lzwwho/V4z0RQ/HKRd9rjclkQQOfZXfhS0ZNJ7EayWeagjF7+Yh6sJkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kgC5ZqTfr1fu+DVV7X2WRGv6Vbzidx9rgyxhFEl4Ccc=; b=LBna5Lxd+LE8D5yGlRXS72XTW2v2QorV9oBpxBqwfVrgTxmYGFE1DKsbOMlDjW5YiNyWCpCeIBEu7h3x7p0XhfEzBhX37vnN7SqziyCZmu8OLJTwtMOttOP8wkDmQ2TARz2VRXOj0LUq65nXqGp5z6g+tAkbtkpopvrxuOmfpMCsof+29vs4tlS4GbsjPxtDvlW8VwZj0vPL15hu/7kTBq+8gqu1hYxR5st2o219KNy0XmsTBUplhVkbOtR/budYwkQGCI8pmA7jwle65HcRkpRFaqoO5jAdfZZQbjIDRuGL/ABYqDmbcXWDs2Yy8kZ+Zcjf1uukcsKixsEeVbL2Fw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kgC5ZqTfr1fu+DVV7X2WRGv6Vbzidx9rgyxhFEl4Ccc=; b=uRinbe7OT1DOIDcki2zlFg0nMI3yPKx06V54usdO5wFlXPzpWT8Uz5LZtspggmUKjOsem9VsFxh5XBpcAR5N7X8+EdigJNi3KPA02Ign/T2wL6F+6iQmBXrwZhigL3y2gfQl5FwHvZnD4e+hdkA28eGo4pv/BK48lXI1263K/ms= From: Andrew Cooper To: Oleksii Kurochko , "xen-devel@lists.xenproject.org" CC: Stefano Stabellini , Gianluca Guida , Doug Goldstein Subject: Re: [PATCH] automation: add qemu-system-riscv to riscv64.dockerfile Thread-Topic: [PATCH] automation: add qemu-system-riscv to riscv64.dockerfile Thread-Index: AQHZJA/Xy2J+QEhgpUWfMMxFgz4kLK6WXk8A Date: Mon, 9 Jan 2023 17:53:03 +0000 Message-ID: References: <8badde729e97ef6508204c5229199b7247c7a3da.1673257832.git.oleksii.kurochko@gmail.com> In-Reply-To: <8badde729e97ef6508204c5229199b7247c7a3da.1673257832.git.oleksii.kurochko@gmail.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|BLAPR03MB5394:EE_ x-ms-office365-filtering-correlation-id: e496bc68-4bed-42af-19f5-08daf26a5ae0 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QBMAxYpgf9J58EOfTSfI9i7s5MmEZL4RQjGo2zHZ/D/Yg9PFyjQlPhzFL1urIk0UVaDRjco9R6Z5gKvCJPH3AfE3Ycx1te1WaMSnmUgHn9jagfCrk5RR9I/kyPfvYazJf74MQblnBxGYZpVBVGSm0622kO+uQCL/brTi7Aq7Z4bUrCH4i2UzyfuGPSqdNRRqn2SKoGk61mlvVUnxRbskUcVCqGsSfQU8+bG+sL5lxKUFJs4b1ejiMiqLGg7EaOoNiMQ1iraViHhhsbF9Hi97xP7HhChaFzrsALoeHRpjgPL5Dx5aUoFHWbwpjbZROSCXOKAWXe7MaXPfHj+YRdT25R0dRDrroKiqxNiiRbq5R34UqpzqwHgPaMWU63Rp9/yddDe2d4y2QBF33xCoIloHvWJqC+Rc0pkMfOHE8ytGIPof099cvoui/I0Y2ubpr9cI6sn6o2hMgDrvNJdXtoJJXOJdvxvtN0pHX/zxbjk9yFWjHWIsj19ncjGTEx9qagjz5fJkJKmXpUbpnkR0Ifv0DmxTvQqO5Oq/r3OwkKWOv5783vFyPlpn2ikynwpoKtICYpFD4VJE9TQM9MQGDgfAvIopJCvi+wTzAk+PDzw5U8+nqRsm2mQCjkq0wokey41ZaQDfXpS2Br2jgem/fhoH4suG8qvuEAEsVEe71j5liTMF9oBTb7RLE6Yc7MPz2KIUPMNOug0l9I/W+4SSinLfWwPlNdvCuupOG8bblsPCycRJs1fwJe3x2d4Ux83YxVXu1nDcS85VMUjnnxAACa97/Q== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(39860400002)(366004)(346002)(376002)(451199015)(66446008)(76116006)(4326008)(8676002)(66556008)(66476007)(66946007)(316002)(64756008)(91956017)(54906003)(110136005)(4744005)(38070700005)(71200400001)(2906002)(5660300002)(8936002)(41300700001)(86362001)(478600001)(31696002)(6486002)(53546011)(82960400001)(6506007)(122000001)(2616005)(26005)(38100700002)(186003)(31686004)(6512007)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?d3IzdE16ZVdVOGhVZ3hDSjlXVVRCSVpnUE1Ra0xjNGV2d08xSDZrZngvM1Rq?= =?utf-8?B?TGRETUZ1YkNWb2Mvb2dKZ3pObmNIcW1MMTROWG5EYW5mNllXYzJmSkhveWJB?= =?utf-8?B?QWpEOVYwc0lZSHh3Qi9ydEFadExnbmEvWFFFcERoU250OXlHaitzYVVZK2Ew?= =?utf-8?B?dDdoMDVVMENSMG1oajlYYWtKMitpQU9xK0xQZlN5M1MvODJab0gyN0NVM2Nl?= =?utf-8?B?cjVOMVhHd3JDYVRvbHBES0FuQzdHN01kU3AxUXZtKzZwZEdzRW5WR1RQUzl0?= =?utf-8?B?QldhUE1pVW5pNGlLemdmUDRVdkN6YkI4Mzl6c2h1T24walkxdHAvQWY2VExR?= =?utf-8?B?aExRSS9RREV5RGZqR1VhRWJSbzMzTnA2SExmRFBsanpHcS9iRFYxWXJvMHkw?= =?utf-8?B?TXA5ZWgxMDN3SVovcmhVWjJBazRoK2YxZzNrYWNtbnJGSW1NQThtT3Y0cndk?= =?utf-8?B?MnNPdmZqeWhpL3dMa2hBVW82TGNxanJuSnFtU1NMblNJVWVLd3JwaCtPdlFR?= =?utf-8?B?RVR2WUNxU0VKcGFjMDNTMUEvamZISDBwN1lsQ1UvQXppYy9ocXFON2RZZnRM?= =?utf-8?B?THNDR21Pb3ZONlZ5MWdCWEF2NnIyWFViQSt5YnJYMk5XMVJudzRFSDdHZHZN?= =?utf-8?B?NXk1bnlHUWlhdXRGQ0x5UGFvbTZTWmdhaGxhZzhuOVFXaEJCK1dDa3J3QXFS?= =?utf-8?B?UmJ2a2tDbC9PUmM1bnovY0dyS3Vmdk11bDhUUTNoNWhONWN6eFMrK1k3dVpL?= =?utf-8?B?REo2dFl0dzkrbWRvZWtOaG5OYk9KZ3o5NU8yT2hFb0d2aVQ4THcrTW8vZXFU?= =?utf-8?B?OXdUU1F6aTBVMm43c0RDYW93NHBMTXQxZ0RmYXdBWlJLU08rdnRzeFEwZ0l4?= =?utf-8?B?MkF6ZHVocXp0aThPaExOK3oreUR6VHpMbnVzWmtHdUI5dGcvVkROSmxpQXVO?= =?utf-8?B?MHBWb1o4anFBS2g1YzF1K2ZHMk40ZkQ4TDFrMllMUzIycTVPeXI4bFF4T2lu?= =?utf-8?B?NDlpZTB5bWc1QXY4cVYvcm0zdXlxV2dUemdobHNXY0lMbjdYcWN4YnZIa0N0?= =?utf-8?B?aVNyQ2NUWHdOQld5QXhaSlBFaEo1Y2FEQlJnaGlkejlYTHRKeU4xcXNpbVcv?= =?utf-8?B?cC9tRmFmdTZ5RHlRUEx5d2luYmF1QmtDVW9qT2hRS1Y1L1RxZXhyd3ZqOFBp?= =?utf-8?B?MjJINnJMYlBSZUZPVUNkU0N1emhZeEhlSTlMdmdKekZDSVJob0FDRDRvK1I0?= =?utf-8?B?eGQvYWpZRlZBYjlDMGdvU1FORWtYNExveXljV2RDN3VDZHZpcnpXaXFZYnNs?= =?utf-8?B?U1FaUXBHbFZueEtYeUxxMDQxbFJLQWNrNE9HNk9LSXdBQUgzWFJDV2Q2VHBY?= =?utf-8?B?ZlR5R2N4dGdNeWtFbWVMeU5GMmlNYzgyWnpoeEcxOVBtUDdRbEhpazVlMXkx?= =?utf-8?B?R01IN2w2YzRZaXNsVUFWSXRvQUVmRzYwRGRZRnpjUTJwT0VKcTFNc2JhaFR0?= =?utf-8?B?eUk5MmxwbWtBMlM3dmZiZGVDWEU4d1Q2OXVuOGtORTVyR200UStHcGtnbS8y?= =?utf-8?B?WnZaNjJnZFliclRyK0t4dEhXd2VvOUpRZWY0eWpXcWcwa0ZjV0NXZmpGMUpJ?= =?utf-8?B?NmthR2hTcW9ZV3JqZjRMTGQ2VlhsWjQ0ZTlOSy9vTXA3RHJ5TWZhZXdHa3lC?= =?utf-8?B?N2tpcUREMlZZUTlyMWZ6VEdhTi9FOUZYbXpWWVlSc0xHQVQ0bTB3cFpvQ0Jy?= =?utf-8?B?Qm4xcDc2dVBFcE1rR21kTVo1RzJkV2RRa3NvSEozTTY3cEc3WnNSc09GVUpt?= =?utf-8?B?cS9XT0tSS1FFMjBlWXJ5eWVvRjg5bDN0bnhiZDVkTEVtd2xENTFzWjFNTmVI?= =?utf-8?B?bit1VGdia3EwMEFjVWtIMGlvZkdURlJHeDM3aDdhMFlmTlFvaEJjbnFxU01K?= =?utf-8?B?QVJQK0huaHBnU2syQTFKRkdtYW9OSVhISkRyc2Fad0ROeDBYeXVsOGtzK1JJ?= =?utf-8?B?U1FKeWo0K3o0T1NyeVlLTTVwbC9jN3owK2ZxdGUrY0NsMUZNMExpczFxQ2s0?= =?utf-8?B?Ylh0VTZNN3V1TGt5bURXQytCOC9nb3k0NUV5U0dxMjNDZEM0MVZteGFTd0FY?= =?utf-8?Q?HDq48pq+mtuu/SNEjjdwgehCJ?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: XZMxGzQI8NQmnK7LwzxCUwK5q59Ql30oorCKVjbi9alsm6Qvy/Rzx7jCtSqEIy2oLSIXsi++9U0BAlaq2oi6WIJ4Gbok1p/M+BJ90s10bZ5qPNMs/2O48Ak/OZdMFJwXClfKazrKVwCFfKcsQaef5oyjgYMBtSiF2WxjrWtBjgEgARw9TLU70+UOEvs0eo+2uCEc1W+EAuUkmS/tqRt/KYy4gSS6vQUvb9VsjCyS7t1HmO/wHGM/FrE5Fj08ce+9W4OScEyUI517ol0Ca/+aTZOkxL5wedpitICBhqkRIToL1XDHgxnZ6JihHRk8C2cfsgPZeIWNUtmLdrM9vWRAn5Q3v5GqbG/5GReOLapIlA2LGylOTvXNiTtFjOO24Xjd42fvoOwHVjtUFzyMvk6L+AJmV70Buycrz62uT/sDAz26/3X8Jam9Afb01SKrV13Y8epCi6c4tCv5wtbdIvNGT5ysU+FHfAC62e1hAJT67JOjuf0a6e/B0g9snpB9rdjAFjbuGyO3WSVQZpyvQxB7yBZoyK4VWWhUOoAso4lv8AHNN53fBu14F/hpYopRs0ZAA4fPzDtOJ8Yc1wBSU+RETaWbDQHlwh5rdXCcZA7f8E4vnk3jh7ahP5G64gddV9+hJWRWc+FLMkvOKSXw9R723vyU+t9zWhOmRVB8gtEd1WfO4a3yiu4AlND6w6s1e4PFCvTYApdHylXa+OdCxZyMFmJgiRD58hFUCqW6WFwN7od4r9F7bkFTLfn4WnA6UAGDncUTGb5Qoh+AxneQUM3/eKbbEpxUcAr/nAFYvjSIvDe8amqWS7sEz8qZfc4N2pUOQVUjxBKozBbBlC34wA7KAETvqg0MZEQgcqkxYU0iTGngMR8x7c981XXnRzi6emGlrN7ehm5V7C6FumLPH5QrPg== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e496bc68-4bed-42af-19f5-08daf26a5ae0 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jan 2023 17:53:03.0969 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IJTDlVSU1dmV9OslntvwEtTWD/1etGH0ydN5M9AKkj2dUTaKl1eBqWtb3ihtvlmliS7pnMSCyAMjGss++TVs7Y780CncQ6JmY1AuL6btrJI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5394 T24gMDkvMDEvMjAyMyA5OjUwIGFtLCBPbGVrc2lpIEt1cm9jaGtvIHdyb3RlOg0KPiBxZW11LXN5 c3RlbS1yaXNjdiB3aWxsIGJlIHVzZWQgdG8gcnVuIFJJU0MtViBYZW4gYmluYXJ5IGFuZA0KPiBn YXRoZXIgbG9ncyBmb3Igc21va2UgdGVzdHMuDQo+DQo+IFNpZ25lZC1vZmYtYnk6IE9sZWtzaWkg S3Vyb2Noa28gPG9sZWtzaWkua3Vyb2Noa29AZ21haWwuY29tPg0KDQpJJ3ZlIGNvbW1pdHRlZCB0 aGlzLCBhbmQgcmVidWlsdCB0aGUgY29udGFpbmVyLsKgIFN1YnNlcXVlbnQgR2l0bGFiLUNJDQpy dW5zIHNob3VsZCBiZSBhYmxlIHRvIHJ1biB0aGUgUklTQy1WIHNtb2tlIHRlc3RzLg0KDQp+QW5k cmV3DQo= From xen-devel-bounces@lists.xenproject.org Mon Jan 09 18:04:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 18:04:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473949.734805 (Exim 4.92) (envelope-from ) id 1pEwVP-0005oJ-4X; Mon, 09 Jan 2023 18:04:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473949.734805; Mon, 09 Jan 2023 18:04:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEwVP-0005oC-0T; Mon, 09 Jan 2023 18:04:19 +0000 Received: by outflank-mailman (input) for mailman id 473949; Mon, 09 Jan 2023 18:04:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEwVN-0005o2-NE; Mon, 09 Jan 2023 18:04:17 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEwVN-00056A-L7; Mon, 09 Jan 2023 18:04:17 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEwVN-0002HK-AE; Mon, 09 Jan 2023 18:04:17 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pEwVN-0005Yw-9k; Mon, 09 Jan 2023 18:04:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=dBv++21dR6feO+FEuiTzE45YhW2D/JkJ/QuYMkTmFII=; b=wJBdpnP8zY+cScrnAKxJj6EAjr 3RN4hY6QbEm7VBVKJZuQeseUbailJpq4NzOmdB16EXcn9+hJmWgksHa8Aj3xh6lL04xGJSdLPuf4J uranoH7iVcp/WZZZ8z/MjxHNylZuQf/PX38ljBcK47okhXTPQd8a7GXNLMqrUAFTlyl0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 175647: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-amd64-xsm:xen-build:fail:regression qemu-mainline:build-amd64:xen-build:fail:regression qemu-mainline:build-i386:xen-build:fail:regression qemu-mainline:build-arm64-xsm:xen-build:fail:regression qemu-mainline:build-i386-xsm:xen-build:fail:regression qemu-mainline:build-arm64:xen-build:fail:regression qemu-mainline:build-armhf:xen-build:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-coresched-amd64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:build-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-rtds:build-check(1):blocked:nonblocking qemu-mainline:build-arm64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking qemu-mainline:build-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking qemu-mainline:build-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-dom0pvh-xl-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-dom0pvh-xl-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvshim:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-pygrub:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvhv2-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-freebsd11-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-freebsd12-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvhv2-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-multivcpu:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: qemuu=d6271b657286de80260413684a1f2a63f44ea17b X-Osstest-Versions-That: qemuu=0ab12aa32462817f0a53fa6f6ce4baf664ef1713 From: osstest service owner Date: Mon, 09 Jan 2023 18:04:17 +0000 flight 175647 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/175647/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 175623 build-amd64 6 xen-build fail REGR. vs. 175623 build-i386 6 xen-build fail REGR. vs. 175623 build-arm64-xsm 6 xen-build fail REGR. vs. 175623 build-i386-xsm 6 xen-build fail REGR. vs. 175623 build-arm64 6 xen-build fail REGR. vs. 175623 build-armhf 6 xen-build fail REGR. vs. 175623 Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-win7-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ws16-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-shadow 1 build-check(1) blocked n/a test-amd64-i386-xl-vhd 1 build-check(1) blocked n/a test-amd64-i386-xl-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) blocked n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) blocked n/a test-armhf-armhf-xl-rtds 1 build-check(1) blocked n/a test-armhf-armhf-xl-vhd 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-amd 1 build-check(1) blocked n/a test-amd64-i386-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-i386 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-amd64 1 build-check(1) blocked n/a test-amd64-coresched-i386-xl 1 build-check(1) blocked n/a test-amd64-coresched-amd64-xl 1 build-check(1) blocked n/a test-amd64-amd64-xl-xsm 1 build-check(1) blocked n/a build-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-shadow 1 build-check(1) blocked n/a test-amd64-amd64-xl-rtds 1 build-check(1) blocked n/a build-arm64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ws16-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a build-armhf-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-amd64-dom0pvh-xl-amd 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 1 build-check(1) blocked n/a test-amd64-amd64-dom0pvh-xl-intel 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvshim 1 build-check(1) blocked n/a test-amd64-amd64-pair 1 build-check(1) blocked n/a test-amd64-amd64-pygrub 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvhv2-intel 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-freebsd11-amd64 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-freebsd12-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvhv2-amd 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-nested-amd 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-nested-intel 1 build-check(1) blocked n/a test-amd64-amd64-xl-multivcpu 1 build-check(1) blocked n/a test-amd64-amd64-xl 1 build-check(1) blocked n/a test-amd64-amd64-xl-credit1 1 build-check(1) blocked n/a test-amd64-amd64-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-arndale 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-intel 1 build-check(1) blocked n/a test-amd64-i386-xl 1 build-check(1) blocked n/a test-amd64-i386-xl-pvshim 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a version targeted for testing: qemuu d6271b657286de80260413684a1f2a63f44ea17b baseline version: qemuu 0ab12aa32462817f0a53fa6f6ce4baf664ef1713 Last test of basis 175623 2023-01-07 23:09:00 Z 1 days Failing since 175627 2023-01-08 14:40:14 Z 1 days 5 attempts Testing same since 175647 2023-01-09 16:07:23 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ard Biesheuvel Bernhard Beschow Cindy Lu Dongli Zhang Eugenio Pérez Greg Kurz Guoyi Tu Hyman Huang(黄勇) Igor Mammedov Jason Wang Jonathan Cameron Kai Huang Laszlo Ersek Lei Xiang leixiang Liuxiangdong Longpeng Lubomir Rintel Markus Armbruster Michael S. Tsirkin Paolo Bonzini Peter Maydell Philippe Mathieu-Daudé Richard Henderson Yanan Wang Yicong Yang Zeng Chi jobs: build-amd64-xsm fail build-arm64-xsm fail build-i386-xsm fail build-amd64 fail build-arm64 fail build-armhf fail build-i386 fail build-amd64-libvirt blocked build-arm64-libvirt blocked build-armhf-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl blocked test-amd64-coresched-amd64-xl blocked test-arm64-arm64-xl blocked test-armhf-armhf-xl blocked test-amd64-i386-xl blocked test-amd64-coresched-i386-xl blocked test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm blocked test-amd64-i386-xl-qemuu-debianhvm-i386-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm blocked test-arm64-arm64-xl-xsm blocked test-amd64-i386-xl-xsm blocked test-amd64-amd64-qemuu-nested-amd blocked test-amd64-amd64-xl-pvhv2-amd blocked test-amd64-i386-qemuu-rhel6hvm-amd blocked test-amd64-amd64-dom0pvh-xl-amd blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64 blocked test-amd64-i386-xl-qemuu-debianhvm-amd64 blocked test-amd64-i386-freebsd10-amd64 blocked test-amd64-amd64-qemuu-freebsd11-amd64 blocked test-amd64-amd64-qemuu-freebsd12-amd64 blocked test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked test-amd64-amd64-xl-qemuu-win7-amd64 blocked test-amd64-i386-xl-qemuu-win7-amd64 blocked test-amd64-amd64-xl-qemuu-ws16-amd64 blocked test-amd64-i386-xl-qemuu-ws16-amd64 blocked test-armhf-armhf-xl-arndale blocked test-amd64-amd64-xl-credit1 blocked test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 blocked test-amd64-amd64-xl-credit2 blocked test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 blocked test-armhf-armhf-xl-cubietruck blocked test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict blocked test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict blocked test-amd64-i386-freebsd10-i386 blocked test-amd64-amd64-qemuu-nested-intel blocked test-amd64-amd64-xl-pvhv2-intel blocked test-amd64-i386-qemuu-rhel6hvm-intel blocked test-amd64-amd64-dom0pvh-xl-intel blocked test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu blocked test-armhf-armhf-xl-multivcpu blocked test-amd64-amd64-pair blocked test-amd64-i386-pair blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim blocked test-amd64-i386-xl-pvshim blocked test-amd64-amd64-pygrub blocked test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds blocked test-armhf-armhf-xl-rtds blocked test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow blocked test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow blocked test-amd64-amd64-xl-shadow blocked test-amd64-i386-xl-shadow blocked test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd blocked test-amd64-i386-xl-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2297 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Jan 09 18:23:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 18:23:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473960.734821 (Exim 4.92) (envelope-from ) id 1pEwnk-0008Fc-PP; Mon, 09 Jan 2023 18:23:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473960.734821; Mon, 09 Jan 2023 18:23:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEwnk-0008FV-Mf; Mon, 09 Jan 2023 18:23:16 +0000 Received: by outflank-mailman (input) for mailman id 473960; Mon, 09 Jan 2023 18:23:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEwnj-0008FP-Ko for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 18:23:15 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEwnj-0005bY-Ac; Mon, 09 Jan 2023 18:23:15 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=[192.168.1.158]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pEwnj-0003Pv-4p; Mon, 09 Jan 2023 18:23:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=N4kCznmep3NleYZso+r94HWGYmbX1dCPtioYPKAmcpY=; b=Wr+Lap0RKVgN2uy2wPA9GqmFzL P3fRBug9i6YqBxSCNW5tJlKKxvLUNGLUNLMol2f8gO8qNvchKa/VNzO5YIrRwfPMrRh0vWExNHdzB THJjaTcOa3vkulJcP5CPcwPBRkmK+BzxGiUYKU9dT3qEWmJjrF5Ta3PpsvQ6dNg9aig8=; Message-ID: <8ae9e898-55ba-7fba-6ccc-883bd8b3e7ee@xen.org> Date: Mon, 9 Jan 2023 18:23:13 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v1 06/13] xen/arm: assign shared memory to owner when host address not provided Content-Language: en-US To: Penny Zheng , "xen-devel@lists.xenproject.org" Cc: Wei Chen , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20221115025235.1378931-1-Penny.Zheng@arm.com> <20221115025235.1378931-7-Penny.Zheng@arm.com> <6db41bd2-ab71-422a-4235-a9209e984915@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Penny, On 09/01/2023 11:58, Penny Zheng wrote: >> -----Original Message----- >> From: Julien Grall >> Sent: Monday, January 9, 2023 6:58 PM >> To: Penny Zheng ; xen-devel@lists.xenproject.org >> Cc: Wei Chen ; Stefano Stabellini >> ; Bertrand Marquis ; >> Volodymyr Babchuk >> Subject: Re: [PATCH v1 06/13] xen/arm: assign shared memory to owner >> when host address not provided >> >> >> >> On 09/01/2023 07:49, Penny Zheng wrote: >>> Hi Julien >> >> Hi Penny, >> >>> Happy new year~~~~ >> >> Happy new year too! >> >>>> -----Original Message----- >>>> From: Julien Grall >>>> Sent: Sunday, January 8, 2023 8:53 PM >>>> To: Penny Zheng ; xen- >> devel@lists.xenproject.org >>>> Cc: Wei Chen ; Stefano Stabellini >>>> ; Bertrand Marquis >>>> ; Volodymyr Babchuk >>>> >>>> Subject: Re: [PATCH v1 06/13] xen/arm: assign shared memory to owner >>>> when host address not provided >>>> >>>> Hi, >>>> >>> >>> A few concerns explained why I didn't choose "struct meminfo" over two >>> pointers "struct membank*" and "struct meminfo*". >>> 1) memory usage is the main reason. >>> If we use "struct meminfo" over the current "struct membank*" and >>> "struct meminfo*", "struct shm_meminfo" will become a array of 256 >>> "struct shm_membank", with "struct shm_membank" being also an 256- >> item >>> array, that is 256 * 256, too big for a structure and If I remembered clearly, >> it will lead to "more than PAGE_SIZE" compiling error. >> >> I am not aware of any place where we would restrict the size of kinfo in >> upstream. Can you give me a pointer? >> > > If I remembered correctly, my first version of "struct shm_meminfo" is this > "big"(256 * 256) structure, and it leads to the whole xen binary is bigger than 2MB. ;\ Ah so the problem is because shm_mem is used in bootinfo. Then I think we should create a distinct structure when dealing with domain information. > >>> FWIT, either reworking meminfo or using a different structure, are >>> both leading to sizing down the array, hmmm, I don't know which size >>> is suitable. That's why I prefer pointer and dynamic allocation. >> >> I would expect that in most cases, you will need only one bank when the host >> address is not provided. So I think this is a bit odd to me to impose a "large" >> allocation for them. >> > > Only if user is not defining size as something like (2^a + 2^b + 2^c + ...). ;\ > So maybe 8 or 16 is enough? > struct new_meminfo { "new" is a bit strange. The name would want to be changed. Or maybe better the structure been defined within the next structure and anonymized. > unsigned int nr_banks; > struct membank bank[8]; > }; > > Correct me if I'm wrong: > The "struct shm_membank" you are suggesting is looking like this, right? > struct shm_membank { > char shm_id[MAX_SHM_ID_LENGTH]; > unsigned int nr_shm_borrowers; > struct new_meminfo shm_banks; > unsigned long total_size; > }; AFAIU, shm_membank would still be used to get the information from the host device-tree. If so, then I am afraid this is not an option to me because it would make the code to reserve memory more complex. Instead, we should create a separate structure that will only be used for domain shared memory information. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Jan 09 18:28:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 18:28:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473966.734833 (Exim 4.92) (envelope-from ) id 1pEwsh-0000UQ-Bd; Mon, 09 Jan 2023 18:28:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473966.734833; Mon, 09 Jan 2023 18:28:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEwsh-0000UJ-8F; Mon, 09 Jan 2023 18:28:23 +0000 Received: by outflank-mailman (input) for mailman id 473966; Mon, 09 Jan 2023 18:28:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEwsf-0000UD-5T for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 18:28:21 +0000 Received: from DM5PR00CU002-vft-obe.outbound.protection.outlook.com (mail-centralusazon11021023.outbound.protection.outlook.com [52.101.62.23]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6386d6d5-904b-11ed-91b6-6bf2151ebd3b; Mon, 09 Jan 2023 19:28:19 +0100 (CET) Received: from BYAPR21MB1688.namprd21.prod.outlook.com (2603:10b6:a02:bf::26) by DM6PR21MB1324.namprd21.prod.outlook.com (2603:10b6:5:175::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6023.3; Mon, 9 Jan 2023 18:28:15 +0000 Received: from BYAPR21MB1688.namprd21.prod.outlook.com ([fe80::db1a:4e71:c688:b7b1]) by BYAPR21MB1688.namprd21.prod.outlook.com ([fe80::db1a:4e71:c688:b7b1%5]) with mapi id 15.20.6002.009; Mon, 9 Jan 2023 18:28:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6386d6d5-904b-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DY2U6W+n1ubaPGlp8RZxACN0MDJF+DS+DG8VaQ3eSk+8/5CjKQEwjNX3xccctI0qB1wyr9ijPat7dzlWX8daI8KveCS0LkrDL887qfjJp0nmG5qli7hTspPdETDPMME5/iA6WK0zbXWVXCTchbybaGyctRybIHWkAjZPcPH+0RsqoGyc71hRog/vk3Ka+ERw+HREDdXx/6O+90unILVzeYt3ZWJtfQZtGDc+cE8UlKcoFUnnCRGxujwwPuRPVdPvTbtbkEkftn74FZJDGVqZybG0VN7ZEeLxL4gnylFk2PuWJYp43l6kwoM11JDxD3DllVBKjzQ/VZI22zK2AvYQZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EILYjBVO3TVH8Ko5wjRUBk5n4pb4VQ0+5EcJsTroldY=; b=cw0pz7bapB1x5b2tnwxJ7eIQfylFTTQw4un/oSasfYLApqC8e3pXho/0AEPHgzwN4Ns4NjOycLwJcQSalDNI9iZzrCBEpp6eHh9ZYQKbUZgTh/f1/s+sTPe7n0trvQTsbErhWLTYB1DEnfy25vtYQlhzKtSLM9wh2+cFVXy9sCeAhnjgZzLPyJaZH7fJ9wimal1MuYODJvsE3SIe2j2hHyDIQqL412uKsjwIOxU/M2g/sc6rUcbYCNh4d2Y5fNDchQyBuoTnqIHojcDoHv18+b/3IvOczOzgit4XDMAg8heutwi6/34nwX4qpTen1tSM3A7po1iW2WQrfdG7GTBJOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EILYjBVO3TVH8Ko5wjRUBk5n4pb4VQ0+5EcJsTroldY=; b=JfO+sfhixC+W+fe0jtKhiG7i6ehSU2eYdkj+pXsdhIswSGiLgS3uG4IkYyDYeo/Z5tuf2T6W9C1w6dHa350uD/KY6gOfbz9eS1fRLOA5QR7m/2AkMEirVSst33W2FBS++zR3Itrl3/C8XxiGbURNvngcAd7jJY4cBRGw/CSs2q4= From: "Michael Kelley (LINUX)" To: Andrew Lutomirski , Jan Beulich , Dave Hansen , Peter Zijlstra CC: "linux-kernel@vger.kernel.org" , "xen-devel@lists.xenproject.org" Subject: Problem with pat_enable() and commit 72cbc8f04fe2 Thread-Topic: Problem with pat_enable() and commit 72cbc8f04fe2 Thread-Index: AdkkUwD6aRGwmsjgQS+RzXLKsHA1TA== Date: Mon, 9 Jan 2023 18:28:15 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=00dc8fc2-24d1-4fce-9fff-420171fb08f5;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2023-01-09T17:47:38Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR21MB1688:EE_|DM6PR21MB1324:EE_ x-ms-office365-filtering-correlation-id: 4ea63db1-8ae9-4be2-2474-08daf26f45b2 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /S0hSRZ3kks6ZlIjLxSNf+0y2KR2/w8sxlw3yukQtzfTPK43/V5HE/gMiw6emuN0VXD895iKbEVnljVYuPdrTszgmVzupCFn/hBWWtJw17H+dg5BdE7N4G7o28bN4AaPB3EyqYTXyxbE0ACUgO0vYEwnjW3bFkPa8mqpLQcIbm6/SQpb/lGH+TCCiyFWTYHyQexSD4MVC+Q47zfa1bd6CT65Iao9yVqUVkSbXFe8e5IQk09yc3JxtPnVwFA99BNTUddmK2J3Qu18bvj1N4Ef2bHYqyW53Cd9lHnlnPN8iE+PB2hksdb3lqOv9ljaw0V153UpMXuYMn2zQ4L+7bQHmKaH19p0TM/o2sMgQJE00uMpcwlMNOG1InZDt5Hfu9EmBWt14IOPGHCK3HmRDl4kpgStZQAhmpa7qhco44KVuqsYGGQfSiibWKNHQJ6pP5Tftn7GaQjmQ3oAiVqfVEBPYZaT+N41/Oo5ofVJXCjRQi45ayS4TG7kklFOSkRvVL1DVcLBZzEDmp/x+T9GrlpjWs0NjsRgM8VRCVpnNnn6n7Jlj0Qc/QsH0AQRIYFEku1ee5v+8shxBeUSvZJNgb2yd2/Lepg5kA+TyMrjEN2vANemJ+EazhTMWeoiSrpyiNbSYMeDQKS5IsOyOSy55L0V/h0Pue8klGp+XU3k1qp9f7qroZHZnZA91NgqJlfAUGT4i2Av1eGDY81D6zzoczi4jKK9BgnWSFVSyXW0X370tpqgtFxmMVyeuPkkPFi8rmcd1NxAQ3vK1IwVAkuPnWXbqw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR21MB1688.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(396003)(136003)(366004)(376002)(451199015)(9686003)(6506007)(186003)(55016003)(54906003)(82960400001)(82950400001)(86362001)(110136005)(66476007)(64756008)(8676002)(66556008)(38070700005)(66946007)(4326008)(76116006)(5660300002)(66446008)(38100700002)(122000001)(478600001)(2906002)(10290500003)(8936002)(26005)(71200400001)(52536014)(316002)(41300700001)(83380400001)(7696005)(8990500004)(33656002)(98903001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?UhePUQmo4pcNB93+LJA+ab4VyqBcZaklXjsfTUWOpomAu3I5B0M/wl52B2wR?= =?us-ascii?Q?s/qtuxhJ/xnZf49/7phYJpUUxAFlwPlcRaITETyDK6t+AiTtQ5n6OEpGAEhE?= =?us-ascii?Q?EWWZMCwHeFFDfYcztLDTZ/OzStfRlnW/S9zJ+8VJ27rhj5h+nVld7MMyvsdG?= =?us-ascii?Q?ZTmQGy/xp9fq3csKrt4t9a7fTeAyrB1spJZn2K7G4j2i8SsXZHKPIMeYVc6Q?= =?us-ascii?Q?RaUwqhZF8ZsRvhPdvza3VNo5WtFLk9FWfRRtHWREd76YyDUzdmH0TqMHUYSn?= =?us-ascii?Q?UQXkTmJ7W/iPn/P1ndIs+USd5Mw3xrDMBVmmb/DbjlYuPZkOo0v85AMA0nzR?= =?us-ascii?Q?tM6gV3NmDkVp3SPGyP3GE6MM6oFOvnov+XBRFIVfGikGYYWWOwYfsJiJcJbD?= =?us-ascii?Q?bo26a8v0pacik7bfC7X4eoK0Z1bZt3omlFuS9toSZ5+2vsiFtbcXDmVPZtXv?= =?us-ascii?Q?/naKw2IL62GKSGrodlkTiH2hbcagie42PmJetCom7rl5jSpxhVVz8f5b1IDO?= =?us-ascii?Q?NsgABXc/bPQ7dXrXaKURNjmSLma1VlP+RjyCqvviXCbizA8TSauf8xkdvc15?= =?us-ascii?Q?50BtAr8EIOjHpMOq42wdk/2LNk+wQEK8HNvoJsGKhRxnWbclABt04O9vrClr?= =?us-ascii?Q?LjSattkauptquADmERxi7vc13TRa91aS8NBARPdaKUn5xrb0L5HAD4LJMqGc?= =?us-ascii?Q?nc66jguSh4hxolCWeExQeyjnmBXUwbDxOfZmZUG+P54s4jHo29oQiCL5P+r4?= =?us-ascii?Q?L9p7OHHJD/Dx4iLLoDO8LBzey5ETDp92u8F5rnij/lkIX3TP2s/c/i78Qvt2?= =?us-ascii?Q?XPh6EXJM/RnNaFxqWoHkmNcFw9mSUMg83U+DqtqvmiQncDRgyKzcCXxpq2MJ?= =?us-ascii?Q?DMCvLc6utWHmXbT7L9vr4Vbej1USWUSnxQX+s3ZLbu14eZuf+w1ozpfkw4T9?= =?us-ascii?Q?uTMOcCRvkVhdnoODt0uInIon22SwTI7gtCbKN4Xz/9IUSWmF8X0zrVl+7JG6?= =?us-ascii?Q?IugCcxe5xvT4rZqilo7TV+UXYAEi0UqFxMpz0aVj436Tnbv5IBlzsOVCKMyy?= =?us-ascii?Q?znP0rFaQDOkPaZRgm0LONdhsSpYd9OuRCmpsWmmr/tQahyPQgl/SU1B6rak9?= =?us-ascii?Q?pS1tjRrnMw4Xm6zl21pwInBuxAfNHLaJa0iSwpvQO118u7fkd5OhKWj8b70R?= =?us-ascii?Q?GPTLsicCow1vyh9rY7pcj4ruFhUEY9nThs0dtoL/fL3mva81mZEHDhwq8/f0?= =?us-ascii?Q?y5hujW2Fbhx5IJ/1xl6+U6TZ0LHKHFv5nkxEEroCRC0CVog281fk59CF/o12?= =?us-ascii?Q?UuQnSGjygytJ4B3u8Dp+8EJ/fWt4XVlBiLx5eVv/ItbrsWRFKIPrKRUAOcYM?= =?us-ascii?Q?aw9Z0spVvl27eBSfSfamj6ZqrL9CMp5SPdtrRwuZR/MYwRcZ14m5+gUnkRRD?= =?us-ascii?Q?4gH+UqKNuiRegGsCwej7bXsUJD1KL8AvRayFb9vwoH5VFYrVoYY6EP4WBJzj?= =?us-ascii?Q?ORsBj98VkV1mJCREzBHknGiZ6Ngc3VG8yo4pgE0XvZJB6VPvyRSifBDHxJQ3?= =?us-ascii?Q?WlphnwnTRpcHpEwrbXE2M/uGmw+Yf3J96IEnboCk1Svha8FBQoe69NVLEaq4?= =?us-ascii?Q?2w=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR21MB1688.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4ea63db1-8ae9-4be2-2474-08daf26f45b2 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jan 2023 18:28:15.0628 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eK4J3fGSxNtkhQDYvymBtQasQIIX9wrGiCtwIydOXfwHy6ypllp5CWpp6v7+zD/nHxgxm1hm14XFlOdB0gW97SYjZfFz0yiQItTIIyHiK6s= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR21MB1324 I've come across a case with a VM running on Hyper-V that doesn't get MTRRs, but the PAT is functional. (This is a Confidential VM using AMD's SEV-SNP encryption technology with the vTOM option.) In this case, the changes in commit 72cbc8f04fe2 ("x86/PAT: Have pat_enabled() properly reflect state when running on Xen") apply. pat_enabled() returns "true", but the MTRRs are not enabled. But with this commit, there's a problem. Consider memremap() on a RAM region, called with MEMREMAP_WB plus MEMREMAP_DEC as the 3rd argument. Because of the request for a decrypted mapping, arch_memremap_can_ram_remap() returns false, and a new mapping must be created, which is appropriate. The following call stack results: memremap() arch_memremap_wb() ioremap_cache() __ioremap_caller() memtype_reserve() <--- pcm is _PAGE_CACHE_MODE_WB pat_x_mtrr_type() <-- only called after commit 72cbc8f04fe2 pat_x_mtrr_type() returns _PAGE_CACHE_MODE_UC_MINUS because mtrr_type_lookup() fails. As a result, memremap() erroneously creates the new mapping as uncached. This uncached mapping is causing a significant performance problem in certain Hyper-V Confidential VM configurations. Any thoughts on resolving this? Should memtype_reserve() be checking both pat_enabled() *and* whether MTRRs are enabled before calling pat_x_mtrr_type()? Or does that defeat the purpose of commit 72cbc8f04fe2 in the Xen environment? I'm also looking at how to avoid this combination in a Hyper-V Confidential VM, but that doesn't address underlying the flaw. Michael From xen-devel-bounces@lists.xenproject.org Mon Jan 09 18:31:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 18:31:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.473972.734844 (Exim 4.92) (envelope-from ) id 1pEwvf-0001r5-PH; Mon, 09 Jan 2023 18:31:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 473972.734844; Mon, 09 Jan 2023 18:31:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEwvf-0001qy-Mk; Mon, 09 Jan 2023 18:31:27 +0000 Received: by outflank-mailman (input) for mailman id 473972; Mon, 09 Jan 2023 18:31:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEwve-0001qq-DM for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 18:31:26 +0000 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [2a00:1450:4864:20::12f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d2a547a0-904b-11ed-91b6-6bf2151ebd3b; Mon, 09 Jan 2023 19:31:25 +0100 (CET) Received: by mail-lf1-x12f.google.com with SMTP id bq39so14412048lfb.0 for ; Mon, 09 Jan 2023 10:31:25 -0800 (PST) Received: from [192.168.0.145] ([195.234.76.149]) by smtp.gmail.com with ESMTPSA id x28-20020a056512131c00b004b549ad99adsm1723527lfu.304.2023.01.09.10.31.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 10:31:24 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d2a547a0-904b-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=VcxOyx9+PmxK4qZSaoSOrWjjYSYft//gzQqweATZcy8=; b=oynIdUOT+KjJkD8zZLtAql3p2xI2v2o2kGwq+YKPCoznCZxcI7TiQ6gTgWsrDKRtkc s9r01t/jiGI+Pj6eCiPpKLQgHY4eeVFNa1Lxm3LL8tgqr65+mIcEIiyhFNEeAkz3t9h+ dcDUbrMDXJwFBTcA+eltL8YtGeMPs8+fo0zE5KEwBtPyu+semx796a0X/QsPM7HAuYZK J88VvQqlBIPcjvMhkJamNGcIXYQvqSu60RRWIyCI66bCYUCkP09+u1lX2paTQXPq9zuA r+Eq7Br93Sh2U7SchoBxfOlwxSFuXJPDSCSuxkTAeQU9m1czOi7JS36GtN6T4ZtbGraE bldQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=VcxOyx9+PmxK4qZSaoSOrWjjYSYft//gzQqweATZcy8=; b=aa/oNhNpUZir2qKkWJecOOKckD/0KCLyt8VGMxcEFsICVbl2bvg6y4IolIU2HvebIA poHJXRUI+qIs08zKw1yfkAjbXrdxpXGwKRpjTdiA0KYvfesARXkUAuYaPkGNtWLye7sY e5YIL4fcltyO1xNybwGPyX4mOrFmcohO8CygayP1heBXbHqzMkY5JCSKo9tpTxnvN4/u wJv7dViOhTJmJioCC2BylYNExGCaTiWuspqutjAZuclGcv4ASIerNk42MhvraW7eHFrp K8sz7O9aRdnloQICYbqxWCt3Syv2+LQtf3Bd00PYZC5ghNndg7tUO/hy1rQblpolJQMX 9DuQ== X-Gm-Message-State: AFqh2kqvIEyPQHCa0kZaeyUwQTzFNSxEeZwvV8JP3iyb5dUEo3vBFEUP UNTBwwqG0ww8byf40c0tW8U= X-Google-Smtp-Source: AMrXdXvWxnbV6EwtbOnYEE5/iFtjNgu+m0d/Ad9RiZJUwW5+8u79+XbokHa7+XHlCg7Pt/DXY3KZhw== X-Received: by 2002:ac2:5f46:0:b0:4c2:7049:5fae with SMTP id 6-20020ac25f46000000b004c270495faemr15867776lfz.20.1673289084514; Mon, 09 Jan 2023 10:31:24 -0800 (PST) Message-ID: <3075b5f9b180c72bb6736640c54efafcb840d571.camel@gmail.com> Subject: Re: [PATCH] automation: add qemu-system-riscv to riscv64.dockerfile From: Oleksii To: Andrew Cooper , "xen-devel@lists.xenproject.org" Cc: Stefano Stabellini , Gianluca Guida , Doug Goldstein Date: Mon, 09 Jan 2023 20:31:22 +0200 In-Reply-To: References: <8badde729e97ef6508204c5229199b7247c7a3da.1673257832.git.oleksii.kurochko@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.1 (3.46.1-1.fc37) MIME-Version: 1.0 On Mon, 2023-01-09 at 17:53 +0000, Andrew Cooper wrote: > On 09/01/2023 9:50 am, Oleksii Kurochko wrote: > > qemu-system-riscv will be used to run RISC-V Xen binary and > > gather logs for smoke tests. > >=20 > > Signed-off-by: Oleksii Kurochko >=20 > I've committed this, and rebuilt the container.=C2=A0 Subsequent Gitlab-C= I > runs should be able to run the RISC-V smoke tests. >=20 Thanks a lot. Will check soon. > ~Andrew ~Oleksii From xen-devel-bounces@lists.xenproject.org Mon Jan 09 19:45:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 19:45:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474000.734890 (Exim 4.92) (envelope-from ) id 1pEy56-0001X5-OT; Mon, 09 Jan 2023 19:45:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474000.734890; Mon, 09 Jan 2023 19:45:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEy56-0001Wy-Ld; Mon, 09 Jan 2023 19:45:16 +0000 Received: by outflank-mailman (input) for mailman id 474000; Mon, 09 Jan 2023 19:45:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEy55-0001Wi-4a; Mon, 09 Jan 2023 19:45:15 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEy55-0007Pt-1u; Mon, 09 Jan 2023 19:45:15 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEy54-0008Cz-MV; Mon, 09 Jan 2023 19:45:14 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pEy54-0001fP-KT; Mon, 09 Jan 2023 19:45:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To; bh=JHXTgRpQBy4NZyEQ8cTu4SVMpHSqEwL4iBaoQdfDF2Y=; b=ZcLUMgfU6orzzydI8/kX66uwSD WAqBdpcWWDjzaOs74ZflTrGD4ZwE9IfLjBzclbQsZfHR+c0Xq0K/hsyQLy2a78PnibUJgzGYmoy1R Cso41RB/nqxvee/yO9DTj+W5SKsKJaPJ+yPbDoJ0EUbGdy2ZfZwG5uedlPmwajBTSlmk=; To: xen-devel@lists.xenproject.org Subject: [qemu-mainline bisection] complete build-amd64 Message-Id: From: osstest service owner Date: Mon, 09 Jan 2023 19:45:14 +0000 branch xen-unstable xenbranch xen-unstable job build-amd64 testid xen-build Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://git.qemu.org/qemu.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git *** Found and reproduced problem changeset *** Bug is in tree: qemuu git://git.qemu.org/qemu.git Bug introduced: 3d83b78285d6e96636130f7d449fd02e2d4deee0 Bug not present: 528d9f33cad5245c1099d77084c78bb2244d5143 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/175659/ commit 3d83b78285d6e96636130f7d449fd02e2d4deee0 Merge: 528d9f33ca fb418b51b7 Author: Peter Maydell Date: Sun Jan 8 14:27:40 2023 +0000 Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging * Atomic memslot updates for KVM (Emanuele, David) * Always send errors to logfile when daemonized (Greg) * Add support for IDE CompactFlash card (Lubomir) * First round of build system cleanups (myself) * First round of feature removals (myself) * Reduce "qemu/accel.h" inclusion (Philippe) # gpg: Signature made Thu 05 Jan 2023 23:51:09 GMT # gpg: using RSA key F13338574B662389866C7682BFFBD25F78C7AE83 # gpg: issuer "pbonzini@redhat.com" # gpg: Good signature from "Paolo Bonzini " [full] # gpg: aka "Paolo Bonzini " [full] # Primary key fingerprint: 46F5 9FBD 57D6 12E7 BFD4 E2F7 7E15 100C CD36 69B1 # Subkey fingerprint: F133 3857 4B66 2389 866C 7682 BFFB D25F 78C7 AE83 * tag 'for-upstream' of https://gitlab.com/bonzini/qemu: (24 commits) i386: SGX: remove deprecated member of SGXInfo target/i386: Add SGX aex-notify and EDECCSSA support util: remove support -chardev tty and -chardev parport util: remove support for hex numbers with a scaling suffix KVM: remove support for kernel-irqchip=off docs: do not talk about past removal as happening in the future meson: accept relative symlinks in "meson introspect --installed" data meson: cleanup compiler detection meson: support meson 0.64 -Doptimization=plain configure: test all warnings tests/qapi-schema: remove Meson workaround meson: cleanup dummy-cpus.c rules meson: tweak hardening options for Windows configure: remove backwards-compatibility and obsolete options configure: preserve qemu-ga variables configure: cleanup $cpu tests configure: remove dead function configure: remove useless write_c_skeleton ide: Add "ide-cf" driver, a CompactFlash card ide: Add 8-bit data mode ... Signed-off-by: Peter Maydell commit fb418b51b7b43c34873f4b9af3da7031b7452115 Author: Paolo Bonzini Date: Fri Dec 16 11:02:48 2022 +0100 i386: SGX: remove deprecated member of SGXInfo Signed-off-by: Paolo Bonzini commit d45f24fe7525d8a8aaa4ca6d9d214dc41819caa5 Author: Kai Huang Date: Wed Nov 9 15:48:34 2022 +1300 target/i386: Add SGX aex-notify and EDECCSSA support The new SGX Asynchronous Exit (AEX) notification mechanism (AEX-notify) allows one enclave to receive a notification in the ERESUME after the enclave exit due to an AEX. EDECCSSA is a new SGX user leaf function (ENCLU[EDECCSSA]) to facilitate the AEX notification handling. Whether the hardware supports to create enclave with AEX-notify support is enumerated via CPUID.(EAX=0x12,ECX=0x1):EAX[10]. The new EDECCSSA user leaf function is enumerated via CPUID.(EAX=0x12,ECX=0x0):EAX[11]. Add support to allow to expose the new SGX AEX-notify feature and the new EDECCSSA user leaf function to KVM guest. Link: https://lore.kernel.org/lkml/166760360549.4906.809756297092548496.tip-bot2@tip-bot2/ Link: https://lore.kernel.org/lkml/166760360934.4906.2427175408052308969.tip-bot2@tip-bot2/ Reviewed-by: Yang Zhong Signed-off-by: Kai Huang Message-Id: <20221109024834.172705-1-kai.huang@intel.com> Signed-off-by: Paolo Bonzini commit 6f9f630836df355b9ca3f4641e6b7be71f6af076 Author: Paolo Bonzini Date: Fri Dec 16 10:56:53 2022 +0100 util: remove support -chardev tty and -chardev parport These were deprecated in 6.0 and can now be removed. Signed-off-by: Paolo Bonzini commit 8b902e3d2309595567e4957b96e971c4f3ca455e Author: Paolo Bonzini Date: Fri Dec 16 10:50:05 2022 +0100 util: remove support for hex numbers with a scaling suffix This was deprecated in 6.0 and can now be removed. Signed-off-by: Paolo Bonzini commit eaaaf8abdc9a9f3493f2cb6a751660dff3f9db57 Author: Paolo Bonzini Date: Fri Dec 16 10:39:32 2022 +0100 KVM: remove support for kernel-irqchip=off -machine kernel-irqchip=off is broken for many guest OSes; kernel-irqchip=split is the replacement that works, so remove the deprecated support for the former. Signed-off-by: Paolo Bonzini commit 9d3f8b3247795ae8f482700bbbace04b04421d5b Author: Paolo Bonzini Date: Fri Dec 16 11:05:20 2022 +0100 docs: do not talk about past removal as happening in the future KVM guest support on 32-bit Arm hosts *has* been removed, so rephrase the sentence describing it. Signed-off-by: Paolo Bonzini commit f32eb0021a85efaca97f69b0e9201737562a8e4f Author: Paolo Bonzini Date: Wed Dec 14 13:25:00 2022 +0100 meson: accept relative symlinks in "meson introspect --installed" data When installing shared libraries, as is the case for libvfio-user.so, Meson will include relative symbolic links in the output of "meson introspect --installed": { "libvfio-user.so": "/usr/local/lib64/libvfio-user.so", ... } In the case of scripts/symlink-install-tree.py, this will be a symbolic link to a symbolic link but, in any case, there is no issue in creating it. Cc: qemu-stable@nongnu.org Signed-off-by: Paolo Bonzini commit e51340243687a2cd7ffcf0d6e2de030bed4b8720 Author: Paolo Bonzini Date: Wed Oct 12 14:15:06 2022 +0200 meson: cleanup compiler detection Detect all compilers at the beginning of meson.build, and store the available languages in an array. Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit 6a97f3939240977e66e90862419911666956a76a Author: Paolo Bonzini Date: Wed Nov 2 13:07:23 2022 +0100 meson: support meson 0.64 -Doptimization=plain In Meson 0.64, the optimization built-in option now accepts the "plain" value, which will not set any optimization flags. While QEMU does not check the contents of the option and therefore does not suffer any ill effect from the new value, it uses get_option to print the optimization flags in the summary. Clean the code up to remove duplication, and check for -Doptimization=plain at the same time. Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit ca9b5c2ebf1aca87677a24c208bf3d0345c0b1aa Author: Paolo Bonzini Date: Wed Oct 12 14:21:22 2022 +0200 configure: test all warnings Some warnings are hardcoded in QEMU_CFLAGS and not tested. There is no particular reason to single out these five, as many more -W flags are present on all the supported compilers. For homogeneity when moving the detection to meson, make them use the same warn_flags infrastructure. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Paolo Bonzini commit 7bef93ff064f540e24a36a31263ae3db2d06b3d2 Author: Paolo Bonzini Date: Wed Dec 14 12:29:11 2022 +0100 tests/qapi-schema: remove Meson workaround The referenced issue has been fixed since version 0.61, so remove the workaround. Signed-off-by: Paolo Bonzini commit 9c9b85d705abdcce0b63f9182d8140dd67bd13fb Author: Paolo Bonzini Date: Thu Jul 22 10:43:00 2021 +0200 meson: cleanup dummy-cpus.c rules Now that qtest is available on all targets including Windows, dummy-cpus.c is included unconditionally in the build. It also does not need to be compiled per-target. Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit 2d73fa74728dccde5cc29c4e56b4d781e4ead7c4 Author: Paolo Bonzini Date: Wed Nov 2 13:03:51 2022 +0100 meson: tweak hardening options for Windows meson.build has been enabling ASLR _only_ for debug builds since commit d2147e04f95f ("configure: move Windows flags detection to meson", 2022-05-07); instead it was supposed to disable it for debug builds. However, the flag has been enabled for DLLs upstream for roughly 2 years (https://sourceware.org/bugzilla/show_bug.cgi?id=19011), and also by some distros including Debian for 6 years even (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=836365). Enable it unconditionally; we can fix the reversed logic of commit d2147e04f95f later if there are any reports, but for now just enable the hardening. Also add -Wl,--high-entropy-va, which also controls ASLR. Signed-off-by: Paolo Bonzini commit 10229ec3b0ff77c4894cefa312c21e65a761dcde Author: Paolo Bonzini Date: Tue Oct 18 10:17:46 2022 +0200 configure: remove backwards-compatibility and obsolete options Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit 954ed68f9934a3e08f904acb93ce168505995e95 Author: Paolo Bonzini Date: Wed Oct 12 11:35:17 2022 +0200 configure: preserve qemu-ga variables Ensure that qemu-ga variables set at configure time are kept later when the script is rerun. For preserve_env to work, the variables need to be empty so move the default values to config-host.mak generation. Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit f9c77801f4992fae99392ccbb60596dfa1fcf04a Author: Paolo Bonzini Date: Wed Oct 12 15:27:03 2022 +0200 configure: cleanup $cpu tests $cpu is derived from preprocessor defines rather than uname these days, so do not bother using isainfo on Solaris. Likewise do not recognize BeOS's uname -m output. Keep the other, less OS-specific canonicalizations for the benefit of people using --cpu. Reviewed-by: Peter Maydell Signed-off-by: Paolo Bonzini commit 91cd485a6dcbc8210666d19146fe73b8664f0418 Author: Paolo Bonzini Date: Tue Oct 18 10:17:25 2022 +0200 configure: remove dead function Reviewed-by: Peter Maydell Signed-off-by: Paolo Bonzini commit c5634e822416e71e00f08f55a521362d8d21264d Author: Paolo Bonzini Date: Thu Oct 20 14:20:06 2022 +0200 configure: remove useless write_c_skeleton This is not needed ever since QEMU stopped detecting -liberty; this happened with the Meson switch but it is quite likely that the library was not really necessary years before. Reviewed-by: Peter Maydell Signed-off-by: Paolo Bonzini commit cec79db38df72ce74d0296b831e90547111bc13c Author: Lubomir Rintel Date: Wed Nov 30 13:03:19 2022 +0100 ide: Add "ide-cf" driver, a CompactFlash card This allows attaching IDE_CFATA device to an IDE bus. Behaves like a CompactFlash card in True IDE mode. Tested with: qemu-system-i386 \$ -device driver=ide-cf,drive=cf,bus=ide.0 \$ -drive id=cf,index=0,format=raw,if=none,file=cf.img Signed-off-by: Lubomir Rintel Message-Id: <20221130120319.706885-1-lkundrak@v3.sk> Signed-off-by: Paolo Bonzini commit 1ea17d228e582b1cfbf6f61e9da5fafef4063be8 Author: Lubomir Rintel Date: Wed Nov 30 13:02:38 2022 +0100 ide: Add 8-bit data mode CompactFlash uses features 0x01 and 0x81 to enable/disable 8-bit data path. Implement them. Signed-off-by: Lubomir Rintel Message-Id: <20221130120238.706717-1-lkundrak@v3.sk> Signed-off-by: Paolo Bonzini commit 9b063b7ea697d796914b3651d15c3457b7b1135c Author: Greg Kurz Date: Tue Nov 8 15:00:32 2022 +0100 util/log: Always send errors to logfile when daemonized When QEMU is started with `-daemonize`, all stdio descriptors get redirected to `/dev/null`. This basically means that anything printed with error_report() and friends is lost. Current logging code allows to redirect to a file with `-D` but this requires to enable some logging item with `-d` as well to be functional. Relax the check on the log flags when QEMU is daemonized, so that other users of stderr can benefit from the redirection, without the need to enable unwanted debug logs. Previous behaviour is retained for the non-daemonized case. The logic is unrolled as an `if` for better readability. The qemu_log_level and log_per_thread globals reflect the state we want to transition to at this point : use them instead of the intermediary locals for correctness. qemu_set_log_internal() is adapted to open a per-thread log file when '-d tid' is passed. This is done by hijacking qemu_try_lock() which seems simpler that refactoring the code. Signed-off-by: Greg Kurz Message-Id: <20221108140032.1460307-3-groug@kaod.org> Signed-off-by: Paolo Bonzini commit 59bde2137445b63c822720d069d91d38190c6540 Author: Paolo Bonzini Date: Tue Nov 8 15:00:31 2022 +0100 util/log: do not close and reopen log files when flags are turned off log_append makes sure that if you turn off the logging (which clears log_flags and makes need_to_open_file false) the old log is not overwritten. The usecase is that if you remove or move the file QEMU will not keep writing to the old file. However, this is not always the desited behavior, in particular having log_append==1 after changing the file name makes little sense. When qemu_set_log_internal is called from the logfile monitor command, filename must be non-NULL and therefore changed_name must be true. Therefore, the only case where the file is closed and need_to_open_file == false is indeed when log_flags becomes zero. In this case, just flush the file and do not bother closing it, thus faking the same append behavior as previously. The behavioral change is that changing the logfile twice, for example log1 -> log2 -> log1, will cause log1 to be overwritten. This can simply be documented, since it is not a particularly surprising behavior. Suggested-by: Alex Bennée Signed-off-by: Paolo Bonzini Reviewed-by: Richard Henderson Reviewed-by: Greg Kurz Message-Id: <20221025092119.236224-1-pbonzini@redhat.com> [groug: nullify global_file before actually closing the file] Signed-off-by: Greg Kurz Message-Id: <20221108140032.1460307-2-groug@kaod.org> Signed-off-by: Paolo Bonzini commit cc6ff741123216550997b12cdd991beeed47bd0d Author: Philippe Mathieu-Daudé Date: Wed Nov 30 14:56:41 2022 +0100 hw: Reduce "qemu/accel.h" inclusion Move "qemu/accel.h" include from the heavily included "hw/boards.h" to hw/core/machine.c, the single file using the AccelState definition. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Fabiano Rosas Message-Id: <20221130135641.85328-3-philmd@linaro.org> Signed-off-by: Paolo Bonzini commit 3d277871f39d4de42f56b7b0cef5721e525b2d31 Author: Philippe Mathieu-Daudé Date: Wed Nov 30 14:56:40 2022 +0100 typedefs: Forward-declare AccelState Forward-declare AccelState in "qemu/typedefs.h" so structures using a reference of it (like MachineState in "hw/boards.h") don't have to include "qemu/accel.h". Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Fabiano Rosas Message-Id: <20221130135641.85328-2-philmd@linaro.org> Signed-off-by: Paolo Bonzini For bisection revision-tuple graph see: http://logs.test-lab.xenproject.org/osstest/results/bisect/qemu-mainline/build-amd64.xen-build.html Revision IDs in each graph node refer, respectively, to the Trees above. ---------------------------------------- Running cs-bisection-step --graph-out=/home/logs/results/bisect/qemu-mainline/build-amd64.xen-build --summary-out=tmp/175659.bisection-summary --basis-template=175623 --blessings=real,real-bisect,real-retry qemu-mainline build-amd64 xen-build Searching for failure / basis pass: 175647 fail [host=himrod0] / 175637 [host=himrod2] 175627 ok. Failure / basis pass flights: 175647 / 175627 (tree with no url: minios) Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://git.qemu.org/qemu.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git Latest d8d829b89dababf763ab33b8cdd852b2830db3cf 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 d6271b657286de80260413684a1f2a63f44ea17b 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 Basis pass d8d829b89dababf763ab33b8cdd852b2830db3cf 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 528d9f33cad5245c1099d77084c78bb2244d5143 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 Generating revisions with ./adhoc-revtuple-generator git://xenbits.xen.org/osstest/ovmf.git#d8d829b89dababf763ab33b8cdd852b2830db3cf-d8d829b89dababf763ab33b8cdd852b2830db3cf git://xenbits.xen.org/qemu-xen-traditional.git#3d273dd05e51e5a1ffba3d98c7437ee84e8f8764-3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 git://git.qemu.org/qemu.git#528d9f33cad5245c1099d77084c78bb2244d5143-d6271b657286de80260413684a1f2a63f44ea17b git://xenbits.xen.org/osstest/seabios.git#645a64b4911d7cadf5749d7375544fc2384e70ba-645\ a64b4911d7cadf5749d7375544fc2384e70ba git://xenbits.xen.org/xen.git#2b21cbbb339fb14414f357a6683b1df74c36fda2-2b21cbbb339fb14414f357a6683b1df74c36fda2 Loaded 5002 nodes in revision graph Searching for test results: 175627 pass d8d829b89dababf763ab33b8cdd852b2830db3cf 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 528d9f33cad5245c1099d77084c78bb2244d5143 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 175631 [host=himrod2] 175640 [host=himrod2] 175637 [host=himrod2] 175643 fail d8d829b89dababf763ab33b8cdd852b2830db3cf 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 3d83b78285d6e96636130f7d449fd02e2d4deee0 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 175647 fail d8d829b89dababf763ab33b8cdd852b2830db3cf 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 d6271b657286de80260413684a1f2a63f44ea17b 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 175652 pass d8d829b89dababf763ab33b8cdd852b2830db3cf 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 528d9f33cad5245c1099d77084c78bb2244d5143 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 175656 fail d8d829b89dababf763ab33b8cdd852b2830db3cf 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 d6271b657286de80260413684a1f2a63f44ea17b 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 175657 fail d8d829b89dababf763ab33b8cdd852b2830db3cf 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 3d83b78285d6e96636130f7d449fd02e2d4deee0 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 175658 pass d8d829b89dababf763ab33b8cdd852b2830db3cf 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 528d9f33cad5245c1099d77084c78bb2244d5143 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 175659 fail d8d829b89dababf763ab33b8cdd852b2830db3cf 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 3d83b78285d6e96636130f7d449fd02e2d4deee0 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 Searching for interesting versions Result found: flight 175627 (pass), for basis pass Result found: flight 175647 (fail), for basis failure Repro found: flight 175652 (pass), for basis pass Repro found: flight 175656 (fail), for basis failure 0 revisions at d8d829b89dababf763ab33b8cdd852b2830db3cf 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 528d9f33cad5245c1099d77084c78bb2244d5143 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 No revisions left to test, checking graph state. Result found: flight 175627 (pass), for last pass Result found: flight 175643 (fail), for first failure Repro found: flight 175652 (pass), for last pass Repro found: flight 175657 (fail), for first failure Repro found: flight 175658 (pass), for last pass Repro found: flight 175659 (fail), for first failure *** Found and reproduced problem changeset *** Bug is in tree: qemuu git://git.qemu.org/qemu.git Bug introduced: 3d83b78285d6e96636130f7d449fd02e2d4deee0 Bug not present: 528d9f33cad5245c1099d77084c78bb2244d5143 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/175659/ commit 3d83b78285d6e96636130f7d449fd02e2d4deee0 Merge: 528d9f33ca fb418b51b7 Author: Peter Maydell Date: Sun Jan 8 14:27:40 2023 +0000 Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging * Atomic memslot updates for KVM (Emanuele, David) * Always send errors to logfile when daemonized (Greg) * Add support for IDE CompactFlash card (Lubomir) * First round of build system cleanups (myself) * First round of feature removals (myself) * Reduce "qemu/accel.h" inclusion (Philippe) # gpg: Signature made Thu 05 Jan 2023 23:51:09 GMT # gpg: using RSA key F13338574B662389866C7682BFFBD25F78C7AE83 # gpg: issuer "pbonzini@redhat.com" # gpg: Good signature from "Paolo Bonzini " [full] # gpg: aka "Paolo Bonzini " [full] # Primary key fingerprint: 46F5 9FBD 57D6 12E7 BFD4 E2F7 7E15 100C CD36 69B1 # Subkey fingerprint: F133 3857 4B66 2389 866C 7682 BFFB D25F 78C7 AE83 * tag 'for-upstream' of https://gitlab.com/bonzini/qemu: (24 commits) i386: SGX: remove deprecated member of SGXInfo target/i386: Add SGX aex-notify and EDECCSSA support util: remove support -chardev tty and -chardev parport util: remove support for hex numbers with a scaling suffix KVM: remove support for kernel-irqchip=off docs: do not talk about past removal as happening in the future meson: accept relative symlinks in "meson introspect --installed" data meson: cleanup compiler detection meson: support meson 0.64 -Doptimization=plain configure: test all warnings tests/qapi-schema: remove Meson workaround meson: cleanup dummy-cpus.c rules meson: tweak hardening options for Windows configure: remove backwards-compatibility and obsolete options configure: preserve qemu-ga variables configure: cleanup $cpu tests configure: remove dead function configure: remove useless write_c_skeleton ide: Add "ide-cf" driver, a CompactFlash card ide: Add 8-bit data mode ... Signed-off-by: Peter Maydell commit fb418b51b7b43c34873f4b9af3da7031b7452115 Author: Paolo Bonzini Date: Fri Dec 16 11:02:48 2022 +0100 i386: SGX: remove deprecated member of SGXInfo Signed-off-by: Paolo Bonzini commit d45f24fe7525d8a8aaa4ca6d9d214dc41819caa5 Author: Kai Huang Date: Wed Nov 9 15:48:34 2022 +1300 target/i386: Add SGX aex-notify and EDECCSSA support The new SGX Asynchronous Exit (AEX) notification mechanism (AEX-notify) allows one enclave to receive a notification in the ERESUME after the enclave exit due to an AEX. EDECCSSA is a new SGX user leaf function (ENCLU[EDECCSSA]) to facilitate the AEX notification handling. Whether the hardware supports to create enclave with AEX-notify support is enumerated via CPUID.(EAX=0x12,ECX=0x1):EAX[10]. The new EDECCSSA user leaf function is enumerated via CPUID.(EAX=0x12,ECX=0x0):EAX[11]. Add support to allow to expose the new SGX AEX-notify feature and the new EDECCSSA user leaf function to KVM guest. Link: https://lore.kernel.org/lkml/166760360549.4906.809756297092548496.tip-bot2@tip-bot2/ Link: https://lore.kernel.org/lkml/166760360934.4906.2427175408052308969.tip-bot2@tip-bot2/ Reviewed-by: Yang Zhong Signed-off-by: Kai Huang Message-Id: <20221109024834.172705-1-kai.huang@intel.com> Signed-off-by: Paolo Bonzini commit 6f9f630836df355b9ca3f4641e6b7be71f6af076 Author: Paolo Bonzini Date: Fri Dec 16 10:56:53 2022 +0100 util: remove support -chardev tty and -chardev parport These were deprecated in 6.0 and can now be removed. Signed-off-by: Paolo Bonzini commit 8b902e3d2309595567e4957b96e971c4f3ca455e Author: Paolo Bonzini Date: Fri Dec 16 10:50:05 2022 +0100 util: remove support for hex numbers with a scaling suffix This was deprecated in 6.0 and can now be removed. Signed-off-by: Paolo Bonzini commit eaaaf8abdc9a9f3493f2cb6a751660dff3f9db57 Author: Paolo Bonzini Date: Fri Dec 16 10:39:32 2022 +0100 KVM: remove support for kernel-irqchip=off -machine kernel-irqchip=off is broken for many guest OSes; kernel-irqchip=split is the replacement that works, so remove the deprecated support for the former. Signed-off-by: Paolo Bonzini commit 9d3f8b3247795ae8f482700bbbace04b04421d5b Author: Paolo Bonzini Date: Fri Dec 16 11:05:20 2022 +0100 docs: do not talk about past removal as happening in the future KVM guest support on 32-bit Arm hosts *has* been removed, so rephrase the sentence describing it. Signed-off-by: Paolo Bonzini commit f32eb0021a85efaca97f69b0e9201737562a8e4f Author: Paolo Bonzini Date: Wed Dec 14 13:25:00 2022 +0100 meson: accept relative symlinks in "meson introspect --installed" data When installing shared libraries, as is the case for libvfio-user.so, Meson will include relative symbolic links in the output of "meson introspect --installed": { "libvfio-user.so": "/usr/local/lib64/libvfio-user.so", ... } In the case of scripts/symlink-install-tree.py, this will be a symbolic link to a symbolic link but, in any case, there is no issue in creating it. Cc: qemu-stable@nongnu.org Signed-off-by: Paolo Bonzini commit e51340243687a2cd7ffcf0d6e2de030bed4b8720 Author: Paolo Bonzini Date: Wed Oct 12 14:15:06 2022 +0200 meson: cleanup compiler detection Detect all compilers at the beginning of meson.build, and store the available languages in an array. Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit 6a97f3939240977e66e90862419911666956a76a Author: Paolo Bonzini Date: Wed Nov 2 13:07:23 2022 +0100 meson: support meson 0.64 -Doptimization=plain In Meson 0.64, the optimization built-in option now accepts the "plain" value, which will not set any optimization flags. While QEMU does not check the contents of the option and therefore does not suffer any ill effect from the new value, it uses get_option to print the optimization flags in the summary. Clean the code up to remove duplication, and check for -Doptimization=plain at the same time. Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit ca9b5c2ebf1aca87677a24c208bf3d0345c0b1aa Author: Paolo Bonzini Date: Wed Oct 12 14:21:22 2022 +0200 configure: test all warnings Some warnings are hardcoded in QEMU_CFLAGS and not tested. There is no particular reason to single out these five, as many more -W flags are present on all the supported compilers. For homogeneity when moving the detection to meson, make them use the same warn_flags infrastructure. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Paolo Bonzini commit 7bef93ff064f540e24a36a31263ae3db2d06b3d2 Author: Paolo Bonzini Date: Wed Dec 14 12:29:11 2022 +0100 tests/qapi-schema: remove Meson workaround The referenced issue has been fixed since version 0.61, so remove the workaround. Signed-off-by: Paolo Bonzini commit 9c9b85d705abdcce0b63f9182d8140dd67bd13fb Author: Paolo Bonzini Date: Thu Jul 22 10:43:00 2021 +0200 meson: cleanup dummy-cpus.c rules Now that qtest is available on all targets including Windows, dummy-cpus.c is included unconditionally in the build. It also does not need to be compiled per-target. Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit 2d73fa74728dccde5cc29c4e56b4d781e4ead7c4 Author: Paolo Bonzini Date: Wed Nov 2 13:03:51 2022 +0100 meson: tweak hardening options for Windows meson.build has been enabling ASLR _only_ for debug builds since commit d2147e04f95f ("configure: move Windows flags detection to meson", 2022-05-07); instead it was supposed to disable it for debug builds. However, the flag has been enabled for DLLs upstream for roughly 2 years (https://sourceware.org/bugzilla/show_bug.cgi?id=19011), and also by some distros including Debian for 6 years even (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=836365). Enable it unconditionally; we can fix the reversed logic of commit d2147e04f95f later if there are any reports, but for now just enable the hardening. Also add -Wl,--high-entropy-va, which also controls ASLR. Signed-off-by: Paolo Bonzini commit 10229ec3b0ff77c4894cefa312c21e65a761dcde Author: Paolo Bonzini Date: Tue Oct 18 10:17:46 2022 +0200 configure: remove backwards-compatibility and obsolete options Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit 954ed68f9934a3e08f904acb93ce168505995e95 Author: Paolo Bonzini Date: Wed Oct 12 11:35:17 2022 +0200 configure: preserve qemu-ga variables Ensure that qemu-ga variables set at configure time are kept later when the script is rerun. For preserve_env to work, the variables need to be empty so move the default values to config-host.mak generation. Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit f9c77801f4992fae99392ccbb60596dfa1fcf04a Author: Paolo Bonzini Date: Wed Oct 12 15:27:03 2022 +0200 configure: cleanup $cpu tests $cpu is derived from preprocessor defines rather than uname these days, so do not bother using isainfo on Solaris. Likewise do not recognize BeOS's uname -m output. Keep the other, less OS-specific canonicalizations for the benefit of people using --cpu. Reviewed-by: Peter Maydell Signed-off-by: Paolo Bonzini commit 91cd485a6dcbc8210666d19146fe73b8664f0418 Author: Paolo Bonzini Date: Tue Oct 18 10:17:25 2022 +0200 configure: remove dead function Reviewed-by: Peter Maydell Signed-off-by: Paolo Bonzini commit c5634e822416e71e00f08f55a521362d8d21264d Author: Paolo Bonzini Date: Thu Oct 20 14:20:06 2022 +0200 configure: remove useless write_c_skeleton This is not needed ever since QEMU stopped detecting -liberty; this happened with the Meson switch but it is quite likely that the library was not really necessary years before. Reviewed-by: Peter Maydell Signed-off-by: Paolo Bonzini commit cec79db38df72ce74d0296b831e90547111bc13c Author: Lubomir Rintel Date: Wed Nov 30 13:03:19 2022 +0100 ide: Add "ide-cf" driver, a CompactFlash card This allows attaching IDE_CFATA device to an IDE bus. Behaves like a CompactFlash card in True IDE mode. Tested with: qemu-system-i386 \$ -device driver=ide-cf,drive=cf,bus=ide.0 \$ -drive id=cf,index=0,format=raw,if=none,file=cf.img Signed-off-by: Lubomir Rintel Message-Id: <20221130120319.706885-1-lkundrak@v3.sk> Signed-off-by: Paolo Bonzini commit 1ea17d228e582b1cfbf6f61e9da5fafef4063be8 Author: Lubomir Rintel Date: Wed Nov 30 13:02:38 2022 +0100 ide: Add 8-bit data mode CompactFlash uses features 0x01 and 0x81 to enable/disable 8-bit data path. Implement them. Signed-off-by: Lubomir Rintel Message-Id: <20221130120238.706717-1-lkundrak@v3.sk> Signed-off-by: Paolo Bonzini commit 9b063b7ea697d796914b3651d15c3457b7b1135c Author: Greg Kurz Date: Tue Nov 8 15:00:32 2022 +0100 util/log: Always send errors to logfile when daemonized When QEMU is started with `-daemonize`, all stdio descriptors get redirected to `/dev/null`. This basically means that anything printed with error_report() and friends is lost. Current logging code allows to redirect to a file with `-D` but this requires to enable some logging item with `-d` as well to be functional. Relax the check on the log flags when QEMU is daemonized, so that other users of stderr can benefit from the redirection, without the need to enable unwanted debug logs. Previous behaviour is retained for the non-daemonized case. The logic is unrolled as an `if` for better readability. The qemu_log_level and log_per_thread globals reflect the state we want to transition to at this point : use them instead of the intermediary locals for correctness. qemu_set_log_internal() is adapted to open a per-thread log file when '-d tid' is passed. This is done by hijacking qemu_try_lock() which seems simpler that refactoring the code. Signed-off-by: Greg Kurz Message-Id: <20221108140032.1460307-3-groug@kaod.org> Signed-off-by: Paolo Bonzini commit 59bde2137445b63c822720d069d91d38190c6540 Author: Paolo Bonzini Date: Tue Nov 8 15:00:31 2022 +0100 util/log: do not close and reopen log files when flags are turned off log_append makes sure that if you turn off the logging (which clears log_flags and makes need_to_open_file false) the old log is not overwritten. The usecase is that if you remove or move the file QEMU will not keep writing to the old file. However, this is not always the desited behavior, in particular having log_append==1 after changing the file name makes little sense. When qemu_set_log_internal is called from the logfile monitor command, filename must be non-NULL and therefore changed_name must be true. Therefore, the only case where the file is closed and need_to_open_file == false is indeed when log_flags becomes zero. In this case, just flush the file and do not bother closing it, thus faking the same append behavior as previously. The behavioral change is that changing the logfile twice, for example log1 -> log2 -> log1, will cause log1 to be overwritten. This can simply be documented, since it is not a particularly surprising behavior. Suggested-by: Alex Bennée Signed-off-by: Paolo Bonzini Reviewed-by: Richard Henderson Reviewed-by: Greg Kurz Message-Id: <20221025092119.236224-1-pbonzini@redhat.com> [groug: nullify global_file before actually closing the file] Signed-off-by: Greg Kurz Message-Id: <20221108140032.1460307-2-groug@kaod.org> Signed-off-by: Paolo Bonzini commit cc6ff741123216550997b12cdd991beeed47bd0d Author: Philippe Mathieu-Daudé Date: Wed Nov 30 14:56:41 2022 +0100 hw: Reduce "qemu/accel.h" inclusion Move "qemu/accel.h" include from the heavily included "hw/boards.h" to hw/core/machine.c, the single file using the AccelState definition. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Fabiano Rosas Message-Id: <20221130135641.85328-3-philmd@linaro.org> Signed-off-by: Paolo Bonzini commit 3d277871f39d4de42f56b7b0cef5721e525b2d31 Author: Philippe Mathieu-Daudé Date: Wed Nov 30 14:56:40 2022 +0100 typedefs: Forward-declare AccelState Forward-declare AccelState in "qemu/typedefs.h" so structures using a reference of it (like MachineState in "hw/boards.h") don't have to include "qemu/accel.h". Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Fabiano Rosas Message-Id: <20221130135641.85328-2-philmd@linaro.org> Signed-off-by: Paolo Bonzini Revision graph left in /home/logs/results/bisect/qemu-mainline/build-amd64.xen-build.{dot,ps,png,html,svg}. ---------------------------------------- 175659: tolerable ALL FAIL flight 175659 qemu-mainline real-bisect [real] http://logs.test-lab.xenproject.org/osstest/logs/175659/ Failures :-/ but no regressions. Tests which did not succeed, including tests which could not be run: build-amd64 6 xen-build fail baseline untested jobs: build-amd64 fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary From xen-devel-bounces@lists.xenproject.org Mon Jan 09 21:32:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 21:32:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474026.734910 (Exim 4.92) (envelope-from ) id 1pEzkf-0004b2-Jf; Mon, 09 Jan 2023 21:32:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474026.734910; Mon, 09 Jan 2023 21:32:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEzkf-0004av-Gq; Mon, 09 Jan 2023 21:32:17 +0000 Received: by outflank-mailman (input) for mailman id 474026; Mon, 09 Jan 2023 21:32:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEzkd-0004ai-EE; Mon, 09 Jan 2023 21:32:15 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEzkd-0001aU-CE; Mon, 09 Jan 2023 21:32:15 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEzkd-00073e-1h; Mon, 09 Jan 2023 21:32:15 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pEzkd-0001C5-1E; Mon, 09 Jan 2023 21:32:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=9czV+nBOby4ICdg3XPJWfbPzEZ89NPCMWILMffFC6u4=; b=axsfg0Arm98aTmjyObsDeQH36v 4/HCPuaasOU44VoN216HuNkx4+vkdTQ82lMK+igwVWWokr6illRHtJus1onlRE2qnOnIp7bvnSWUv T3rq5bUrHFUbGZF6CYmpV8y/2xthEZ7Kx9Hq9/Fv4EtXwuu8rnwCGxcEJ1JAHuC4wC68=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 175655: all pass - PUSHED X-Osstest-Versions-This: ovmf=33a3408fbbf988aaa8ecc6e721cf83e3ae810e54 X-Osstest-Versions-That: ovmf=d8d829b89dababf763ab33b8cdd852b2830db3cf From: osstest service owner Date: Mon, 09 Jan 2023 21:32:15 +0000 flight 175655 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/175655/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 33a3408fbbf988aaa8ecc6e721cf83e3ae810e54 baseline version: ovmf d8d829b89dababf763ab33b8cdd852b2830db3cf Last test of basis 175606 2023-01-06 16:13:16 Z 3 days Testing same since 175655 2023-01-09 18:11:29 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Yuanhao Xie jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git d8d829b89d..33a3408fbb 33a3408fbbf988aaa8ecc6e721cf83e3ae810e54 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Mon Jan 09 21:40:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 21:40:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474034.734922 (Exim 4.92) (envelope-from ) id 1pEzsX-00064j-GV; Mon, 09 Jan 2023 21:40:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474034.734922; Mon, 09 Jan 2023 21:40:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEzsX-00064c-B6; Mon, 09 Jan 2023 21:40:25 +0000 Received: by outflank-mailman (input) for mailman id 474034; Mon, 09 Jan 2023 21:40:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEzsW-00064S-K6; Mon, 09 Jan 2023 21:40:24 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEzsW-0001jG-GF; Mon, 09 Jan 2023 21:40:24 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEzsV-0007Rb-Ve; Mon, 09 Jan 2023 21:40:24 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pEzsV-0003kt-VB; Mon, 09 Jan 2023 21:40:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=3wbJTSmdyVMqOHzJ1ipHrDrtfp4kc76rtJtyXwaXbdU=; b=nqGHjOE/FyV+AnbQUGkpVSpwgJ OZXUAfY7QpM1T/pLy5Ky21FKmvWuTNoR1VWpk+YlndYM2fdXnGD75sir2QEwsRK4FKLoHwe/F4++m E4p1ZEBKhBXB3HYdpLowwvTfDSPIF/d11Xd/NKBDcOcfgWDQtIFrmmCsmAXqUGZKUD20=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 175654: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-amd64-xsm:xen-build:fail:regression qemu-mainline:build-amd64:xen-build:fail:regression qemu-mainline:build-i386:xen-build:fail:regression qemu-mainline:build-arm64-xsm:xen-build:fail:regression qemu-mainline:build-i386-xsm:xen-build:fail:regression qemu-mainline:build-arm64:xen-build:fail:regression qemu-mainline:build-armhf:xen-build:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-coresched-amd64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:build-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-rtds:build-check(1):blocked:nonblocking qemu-mainline:build-arm64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking qemu-mainline:build-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking qemu-mainline:build-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-dom0pvh-xl-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-dom0pvh-xl-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvshim:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-pygrub:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvhv2-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-freebsd11-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-freebsd12-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvhv2-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-multivcpu:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: qemuu=aa96ab7c9df59c615ca82b49c9062819e0a1c287 X-Osstest-Versions-That: qemuu=0ab12aa32462817f0a53fa6f6ce4baf664ef1713 From: osstest service owner Date: Mon, 09 Jan 2023 21:40:23 +0000 flight 175654 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/175654/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 175623 build-amd64 6 xen-build fail REGR. vs. 175623 build-i386 6 xen-build fail REGR. vs. 175623 build-arm64-xsm 6 xen-build fail REGR. vs. 175623 build-i386-xsm 6 xen-build fail REGR. vs. 175623 build-arm64 6 xen-build fail REGR. vs. 175623 build-armhf 6 xen-build fail REGR. vs. 175623 Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-win7-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ws16-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-shadow 1 build-check(1) blocked n/a test-amd64-i386-xl-vhd 1 build-check(1) blocked n/a test-amd64-i386-xl-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) blocked n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) blocked n/a test-armhf-armhf-xl-rtds 1 build-check(1) blocked n/a test-armhf-armhf-xl-vhd 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-amd 1 build-check(1) blocked n/a test-amd64-i386-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-i386 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-amd64 1 build-check(1) blocked n/a test-amd64-coresched-i386-xl 1 build-check(1) blocked n/a test-amd64-coresched-amd64-xl 1 build-check(1) blocked n/a test-amd64-amd64-xl-xsm 1 build-check(1) blocked n/a build-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-shadow 1 build-check(1) blocked n/a test-amd64-amd64-xl-rtds 1 build-check(1) blocked n/a build-arm64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ws16-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a build-armhf-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-amd64-dom0pvh-xl-amd 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 1 build-check(1) blocked n/a test-amd64-amd64-dom0pvh-xl-intel 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvshim 1 build-check(1) blocked n/a test-amd64-amd64-pair 1 build-check(1) blocked n/a test-amd64-amd64-pygrub 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvhv2-intel 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-freebsd11-amd64 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-freebsd12-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvhv2-amd 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-nested-amd 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-nested-intel 1 build-check(1) blocked n/a test-amd64-amd64-xl-multivcpu 1 build-check(1) blocked n/a test-amd64-amd64-xl 1 build-check(1) blocked n/a test-amd64-amd64-xl-credit1 1 build-check(1) blocked n/a test-amd64-amd64-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 1 build-check(1) blocked n/a test-armhf-armhf-xl-arndale 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-intel 1 build-check(1) blocked n/a test-amd64-i386-xl 1 build-check(1) blocked n/a test-amd64-i386-xl-pvshim 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a version targeted for testing: qemuu aa96ab7c9df59c615ca82b49c9062819e0a1c287 baseline version: qemuu 0ab12aa32462817f0a53fa6f6ce4baf664ef1713 Last test of basis 175623 2023-01-07 23:09:00 Z 1 days Failing since 175627 2023-01-08 14:40:14 Z 1 days 6 attempts Testing same since 175654 2023-01-09 18:08:58 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ard Biesheuvel Bernhard Beschow Christian Borntraeger Cindy Lu Dongli Zhang Eugenio Pérez Greg Kurz Guoyi Tu Hyman Huang(黄勇) Igor Mammedov Jason Wang Jonathan Cameron Kai Huang Laszlo Ersek Lei Xiang leixiang Liuxiangdong Longpeng Lubomir Rintel Marc-André Lureau Markus Armbruster Michael S. Tsirkin Nikita Ivanov Paolo Bonzini Peter Maydell Philippe Mathieu-Daudé Richard Henderson Thomas Huth Yanan Wang Yicong Yang Zeng Chi jobs: build-amd64-xsm fail build-arm64-xsm fail build-i386-xsm fail build-amd64 fail build-arm64 fail build-armhf fail build-i386 fail build-amd64-libvirt blocked build-arm64-libvirt blocked build-armhf-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl blocked test-amd64-coresched-amd64-xl blocked test-arm64-arm64-xl blocked test-armhf-armhf-xl blocked test-amd64-i386-xl blocked test-amd64-coresched-i386-xl blocked test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm blocked test-amd64-i386-xl-qemuu-debianhvm-i386-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm blocked test-arm64-arm64-xl-xsm blocked test-amd64-i386-xl-xsm blocked test-amd64-amd64-qemuu-nested-amd blocked test-amd64-amd64-xl-pvhv2-amd blocked test-amd64-i386-qemuu-rhel6hvm-amd blocked test-amd64-amd64-dom0pvh-xl-amd blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64 blocked test-amd64-i386-xl-qemuu-debianhvm-amd64 blocked test-amd64-i386-freebsd10-amd64 blocked test-amd64-amd64-qemuu-freebsd11-amd64 blocked test-amd64-amd64-qemuu-freebsd12-amd64 blocked test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked test-amd64-amd64-xl-qemuu-win7-amd64 blocked test-amd64-i386-xl-qemuu-win7-amd64 blocked test-amd64-amd64-xl-qemuu-ws16-amd64 blocked test-amd64-i386-xl-qemuu-ws16-amd64 blocked test-armhf-armhf-xl-arndale blocked test-amd64-amd64-xl-credit1 blocked test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 blocked test-amd64-amd64-xl-credit2 blocked test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 blocked test-armhf-armhf-xl-cubietruck blocked test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict blocked test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict blocked test-amd64-i386-freebsd10-i386 blocked test-amd64-amd64-qemuu-nested-intel blocked test-amd64-amd64-xl-pvhv2-intel blocked test-amd64-i386-qemuu-rhel6hvm-intel blocked test-amd64-amd64-dom0pvh-xl-intel blocked test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu blocked test-armhf-armhf-xl-multivcpu blocked test-amd64-amd64-pair blocked test-amd64-i386-pair blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim blocked test-amd64-i386-xl-pvshim blocked test-amd64-amd64-pygrub blocked test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds blocked test-armhf-armhf-xl-rtds blocked test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow blocked test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow blocked test-amd64-amd64-xl-shadow blocked test-amd64-i386-xl-shadow blocked test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd blocked test-amd64-i386-xl-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2556 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Jan 09 21:42:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 21:42:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474042.734932 (Exim 4.92) (envelope-from ) id 1pEzuR-0006dL-R3; Mon, 09 Jan 2023 21:42:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474042.734932; Mon, 09 Jan 2023 21:42:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEzuR-0006dE-OK; Mon, 09 Jan 2023 21:42:23 +0000 Received: by outflank-mailman (input) for mailman id 474042; Mon, 09 Jan 2023 21:42:23 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEzuR-0006d4-4I; Mon, 09 Jan 2023 21:42:23 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEzuR-0001ku-3N; Mon, 09 Jan 2023 21:42:23 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pEzuQ-0007Wx-O3; Mon, 09 Jan 2023 21:42:22 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pEzuQ-0005Sx-Nd; Mon, 09 Jan 2023 21:42:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=5ozE18a5DxhD1Vctwz2eDCpPSk7dtuuJ9PuXDUSgAfs=; b=3FQ3dVz+/on0EODJs2YLaRb8Qy zUy3S7ukcpocvOAtTC3ObOu4DRhVh41ie5bqoiEODNezG0FTiNuOoVuktC8nQJSqBCH2co2e9pEf/ E+QtJeEEaXOIT/j4xDD6Sha5GZCzOMM0zq6vuLAe9xxunmPnXV6LFAenLP9EJZ0V+3KA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 175653: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=692d04a9ca429ca574d859fa8f43578e03b9f8b3 X-Osstest-Versions-That: xen=38525f6f73f906699f77a1af86c16b4eaad48e04 From: osstest service owner Date: Mon, 09 Jan 2023 21:42:22 +0000 flight 175653 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/175653/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 692d04a9ca429ca574d859fa8f43578e03b9f8b3 baseline version: xen 38525f6f73f906699f77a1af86c16b4eaad48e04 Last test of basis 175644 2023-01-09 14:00:27 Z 0 days Testing same since 175653 2023-01-09 18:05:52 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper George Dunlap Jan Beulich Julien Grall Oleksii Kurochko jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 38525f6f73..692d04a9ca 692d04a9ca429ca574d859fa8f43578e03b9f8b3 -> smoke From xen-devel-bounces@lists.xenproject.org Mon Jan 09 21:56:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 21:56:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474053.734949 (Exim 4.92) (envelope-from ) id 1pF07o-0008IQ-3J; Mon, 09 Jan 2023 21:56:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474053.734949; Mon, 09 Jan 2023 21:56:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF07o-0008IJ-0E; Mon, 09 Jan 2023 21:56:12 +0000 Received: by outflank-mailman (input) for mailman id 474053; Mon, 09 Jan 2023 21:56:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF07l-0008ID-UZ for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 21:56:10 +0000 Received: from sonic312-24.consmr.mail.gq1.yahoo.com (sonic312-24.consmr.mail.gq1.yahoo.com [98.137.69.205]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 69b3da00-9068-11ed-91b6-6bf2151ebd3b; Mon, 09 Jan 2023 22:56:06 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.gq1.yahoo.com with HTTP; Mon, 9 Jan 2023 21:56:03 +0000 Received: by hermes--production-ne1-7b69748c4d-drrwg (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 3063e915763b79494c5a1a49c3c8038d; Mon, 09 Jan 2023 21:55:58 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 69b3da00-9068-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1673301363; bh=XmjEY3smFSBeH1GvhJfSTsSYJbxF46CwAKG5dAKcmRI=; h=From:To:Cc:Subject:Date:References:From:Subject:Reply-To; b=XQ4jxMvUKo2m81vt7fXP25qsUhR1PI6kigX4sFvJZ89oiNMiM0L1oeUygYTBH2w/MnnXB6LLsgprZ1eETJsBJUZU7unMRYVFvuQgiqKSfGq6k0lfkLJA/XuPjLw/OVCPMwELYfwhfWvqJhRygAW2g21Onrw4Kdjo0yOI5Hc0dr5X0Y+qMuutFrGDVLUOFIjiOfwXvLISDGUrKqH4QWciOB9bpYFw1UsQiax8pWoKDgTEM7SqdJH8jMcOdo62agw/QY2eYzmMTZLv8wfSxF7izdB90v6dCbENHe5FqRFKmjMyMZK+wFUodJE1LWuv3CBfY3fD0Bnn/qlBrqb3PPtrbQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1673301363; bh=lcJGVb/afW/9QWvR+7d3BL+WwFDW/zQtJ9DNlrryTAD=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=QOgQo3tegk8jmBv3Ng7w79LJ/aNZzX5ERi9ymMQFCrWbayQ8uUhDFy0obt6l2lWh2qOHi1fd0LHR93v7XeI9OREnDWnXEVMs2yUZJk5NYDwKtqMRsBjK+TRmMq5lLv0YjnlPIN+FuBaa/P8esnQ3iFqaJ6kEmLPH/ebhYypsHFaL7EhDWTj2YdS6910kIBJo1yUbfe7V3bRH1GAszdULZEUUNHZ2kM8CcksfbHeK0b2CRgIK/aWdevby31waCzAPrfnCwxt6HHtKovcC4b162AwrEyWXRaXdRAIYomU5Wu2aLZ5dFxZ7nPjOKAi2c5y0/SlzRy2xCD8cDmj766CObg== X-YMail-OSG: jD7hKu8VM1l0oOLuaqgRaeb30aQv6Qp.ODCmKP8f6Q9mBSVWzcsfDNYVsykA2ho behgY_jMFk_aXME9xrjnRS_UbMzJzOjYrDdoHuBBzXjRybX5ZJpAKTcm5mQC_sDQTYgOe.ec_iAM Myn.yvyAZfixP0ZhyiSdQHFTK4O7S1mYEbP_EnvNTk1wCOGbXUWhRrwUwfT7ysui.KhNPs4WfHNE ss69qDq30QYPN.igM4i96y25hYBsFq9PPfxFB7Lj07UuZt7Y9dzwZo14h77gQ6KOw4p0GuHrcNIp OL_JGjZOopff5u5r__uhwXfmZVS9mH5QdZf4HePHJbfgydDeo8DCbqlxl9FSCeMBB.8ly6bOnY1L fNW9Mq5UyvPhekEHUZa.cr1Plr6__p3mLtRSkefaiL8NldguAqJxo7J.2GWQjFItbcRwNuekenlP uqfUoZ_WITspASb_vkBokN3PhGG7UwY.4InnuWo3wNlez3CtngNLdJy0n59mgEb9ODF3tv96dXAx 2Z3OEyVG7Rx4F0ceHoO9l4h_GVKrkX326EfaLiYvWeqAxw27WRowzgPWhcJjnk90pQSacKJnQhgV YUUDyV13LFZmhT56JVJ5ZsS8hOh0b3O1lFxsrUcP17XrLk1cd3ExodjeHQy9KqmVQUftBIGeXOhC wi8zEb.Og9kAVPf88sGf0uCFmn8egoa4F03lP4p0bBLeIUWPc19V9Nxoq0ubKb77g0ZDNbGM6WgP TzOou3wKPVh6EVSQFmExoBO.KvctLL5GwwwUtb1U4joolbv2p.AIeleTYmoetMIF7vWRhnsnffXj PnxAYJSGenBv17Y6fL9GsxI6VEQDYEUwgkCB_IZnFQIVz4j2eAfjV46LMX7kfAqPTvMQ0fjRet1L .4PDQda5tboB8o1lJN29wjT7m_LI_.y5MY33uUWbqS87og.ChzviNmVN8R3MQwYtFecpX0PhyvnP 4kOnn5qRgEaC0aL9wSR6G6X44ucjrtWUXvsjLxRib91kWnnvxP3qajCnnUMbCgG51Q1ZByeE6zpW YdJO.EFMvbsk_P1uCPdJY2ruXmtNf6NhfiSQBXd9Rc.sCZXJz38sR0_Yj2IXUuIVWGVTo.KyIbwa aKctdmpnN0MLzBy4SxVkXP9RmSAXpKDQDDqkSI3_FmU_2jYvrSlEORoJUta44jh_CmzLGD9D9RpE GtYlfbu73Wvr_OR3UqtG97pTwxWzct9qsFmGqcTrnJ1jSVqCHvFXpZMYfQ10Fs5UzBalA5qi01zC u7DJo2ajgyrXRVAHpMatMXzxXVTSOJaI2o6b_5NADyxHasar5U8EfUQxOA2T9mm9jwwnei9kaPuH X19Poc7zTetiMVRLtEgBfMYJfOyq2CTMpOpaWRD6Uh6ZgWi8l9NysycpuGVsH.ecj2KqwtZ5oJFW KcnTKZUoL8epoDkWNWXNQxAgUcJPHwtDzoogyzwTqpEf1SQBQ0QRH4Ec7XacoBtCYNXfFCs28x_o eBVi9bI0v8e8u6TtjoN9gumUJ5RBlvxoMd90_CdiQ3Kki5XA1yDZKNPEDogWz1n2rqbppweaOIjx LibIevRK3I86zHkKsWZc4I5XDQCOpNm7oiPn2kuvDstRyZM.TVLVC3FbZEO.oV2z7pMdLeVVj_uq ncCUF1idA.F1GO3HcwrmBWdPzlNjxIt_Iy.jlgrNBCMLadpHitdH7vEK2LptFnVlmLIvug1EYBO. sDyWyOOPhrH_N07SPb2UnXVnT4YHflcctzylOwYjtZoiDaSX1fuhiUwt1OFopV2la7OTn0cOPBKS qF8mpGMgHwAHLd.4Z5U.QsTaSvLwTn.o3twGe0jZ4PqP1bAXGFNn4rIZMoRfcUZbwUxlNRhtfvLP wkmzXtBeNTcgzlwsJTBOXU9cSb3ufinbkNSBzifJsp49v4jCV4cPTchJtB1xbu5S3ikvCpvNILpI MX_XcDsT7s.YlEqNQYFtA6vILJifBpdjyErNLDcVyru7a9CvXniTmoJebP.gF8al7iHYJiSVUAG2 Vrz_zgbHeYkJvq6Wa1hERRnpXFjSXOOC36mIep93Mpy4QDHLRagXhPJURx7znW._g989jDQjb0oO Nq7_Fza3JFyu2L2y75ql9ZE8IlrcIoF0da8gd8KrS_b7jWGHQ7K0LWi9GnomoOcMs1b26_Q_Ir1n FOHmWVywIISIOGTISU2ulzbCuvDunxL6flF5FMPvYLqr0hs4RFfQEJPaahPD1GXbDmudEP2YvCR9 Yhgn1kyE- X-Sonic-MF: From: Chuck Zmudzinski To: qemu-devel@nongnu.org Cc: Stefano Stabellini , Anthony Perard , Paul Durrant , Paolo Bonzini , Richard Henderson , Eduardo Habkost , "Michael S. Tsirkin" , Marcel Apfelbaum , xen-devel@lists.xenproject.org Subject: [PATCH v7] xen/pt: reserve PCI slot 2 for Intel igd-passthru Date: Mon, 9 Jan 2023 16:55:42 -0500 Message-Id: <8349506149de6d81b0762f17623552c248439e93.1673297742.git.brchuckz@aol.com> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit References: <8349506149de6d81b0762f17623552c248439e93.1673297742.git.brchuckz.ref@aol.com> Content-Length: 19875 Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, as noted in docs/igd-assign.txt in the Qemu source code. Currently, when the xl toolstack is used to configure a Xen HVM guest with Intel IGD passthrough to the guest with the Qemu upstream device model, a Qemu emulated PCI device will occupy slot 2 and the Intel IGD will occupy a different slot. This problem often prevents the guest from booting. The only available workaround is not good: Configure Xen HVM guests to use the old and no longer maintained Qemu traditional device model available from xenbits.xen.org which does reserve slot 2 for the Intel IGD. To implement this feature in the Qemu upstream device model for Xen HVM guests, introduce the following new functions, types, and macros: * XEN_PT_DEVICE_CLASS declaration, based on the existing TYPE_XEN_PT_DEVICE * XEN_PT_DEVICE_GET_CLASS macro helper function for XEN_PT_DEVICE_CLASS * typedef XenPTQdevRealize function pointer * XEN_PCI_IGD_SLOT_MASK, the value of slot_reserved_mask to reserve slot 2 * xen_igd_reserve_slot and xen_igd_clear_slot functions The new xen_igd_reserve_slot function uses the existing slot_reserved_mask member of PCIBus to reserve PCI slot 2 for Xen HVM guests configured using the xl toolstack with the gfx_passthru option enabled, which sets the igd-passthru=on option to Qemu for the Xen HVM machine type. The new xen_igd_reserve_slot function also needs to be implemented in hw/xen/xen_pt_stub.c to prevent FTBFS during the link stage for the case when Qemu is configured with --enable-xen and --disable-xen-pci-passthrough, in which case it does nothing. The new xen_igd_clear_slot function overrides qdev->realize of the parent PCI device class to enable the Intel IGD to occupy slot 2 on the PCI bus since slot 2 was reserved by xen_igd_reserve_slot when the PCI bus was created in hw/i386/pc_piix.c for the case when igd-passthru=on. Move the call to xen_host_pci_device_get, and the associated error handling, from xen_pt_realize to the new xen_igd_clear_slot function to initialize the device class and vendor values which enables the checks for the Intel IGD to succeed. The verification that the host device is an Intel IGD to be passed through is done by checking the domain, bus, slot, and function values as well as by checking that gfx_passthru is enabled, the device class is VGA, and the device vendor in Intel. Signed-off-by: Chuck Zmudzinski --- Notes that might be helpful to reviewers of patched code in hw/xen: The new functions and types are based on recommendations from Qemu docs: https://qemu.readthedocs.io/en/latest/devel/qom.html Notes that might be helpful to reviewers of patched code in hw/i386: The small patch to hw/i386/pc_piix.c is protected by CONFIG_XEN so it does not affect builds that do not have CONFIG_XEN defined. xen_igd_gfx_pt_enabled() in the patched hw/i386/pc_piix.c file is an existing function that is only true when Qemu is built with xen-pci-passthrough enabled and the administrator has configured the Xen HVM guest with Qemu's igd-passthru=on option. v2: Remove From: tag at top of commit message v3: Changed the test for the Intel IGD in xen_igd_clear_slot: if (is_igd_vga_passthrough(&s->real_device) && (s->real_device.vendor_id == PCI_VENDOR_ID_INTEL)) { is changed to if (xen_igd_gfx_pt_enabled() && (s->hostaddr.slot == 2) && (s->hostaddr.function == 0)) { I hoped that I could use the test in v2, since it matches the other tests for the Intel IGD in Qemu and Xen, but those tests do not work because the necessary data structures are not set with their values yet. So instead use the test that the administrator has enabled gfx_passthru and the device address on the host is 02.0. This test does detect the Intel IGD correctly. v4: Use brchuckz@aol.com instead of brchuckz@netscape.net for the author's email address to match the address used by the same author in commits be9c61da and c0e86b76 Change variable for XEN_PT_DEVICE_CLASS: xptc changed to xpdc v5: The patch of xen_pt.c was re-worked to allow a more consistent test for the Intel IGD that uses the same criteria as in other places. This involved moving the call to xen_host_pci_device_get from xen_pt_realize to xen_igd_clear_slot and updating the checks for the Intel IGD in xen_igd_clear_slot: if (xen_igd_gfx_pt_enabled() && (s->hostaddr.slot == 2) && (s->hostaddr.function == 0)) { is changed to if (is_igd_vga_passthrough(&s->real_device) && s->real_device.domain == 0 && s->real_device.bus == 0 && s->real_device.dev == 2 && s->real_device.func == 0 && s->real_device.vendor_id == PCI_VENDOR_ID_INTEL) { Added an explanation for the move of xen_host_pci_device_get from xen_pt_realize to xen_igd_clear_slot to the commit message. Rebase. v6: Fix logging by removing these lines from the move from xen_pt_realize to xen_igd_clear_slot that was done in v5: XEN_PT_LOG(d, "Assigning real physical device %02x:%02x.%d" " to devfn 0x%x\n", s->hostaddr.bus, s->hostaddr.slot, s->hostaddr.function, s->dev.devfn); This log needs to be in xen_pt_realize because s->dev.devfn is not set yet in xen_igd_clear_slot. v7: Inhibit out of context log message and needless processing by adding 2 lines at the top of the new xen_igd_clear_slot function: if (!(pci_bus->slot_reserved_mask & XEN_PCI_IGD_SLOT_MASK)) return; Rebase. This removed an unnecessary header file from xen_pt.h hw/i386/pc_piix.c | 127 ++++++++++++++++++++++++++++++++----------- hw/xen/xen_pt.c | 49 ++++++++++++++--- hw/xen/xen_pt.h | 16 ++++++ hw/xen/xen_pt_stub.c | 4 ++ 4 files changed, 154 insertions(+), 42 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index b48047f50c..34a9736b5e 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -32,6 +32,7 @@ #include "hw/i386/pc.h" #include "hw/i386/apic.h" #include "hw/pci-host/i440fx.h" +#include "hw/rtc/mc146818rtc.h" #include "hw/southbridge/piix.h" #include "hw/display/ramfb.h" #include "hw/firmware/smbios.h" @@ -40,16 +41,16 @@ #include "hw/usb.h" #include "net/net.h" #include "hw/ide/pci.h" -#include "hw/ide/piix.h" #include "hw/irq.h" #include "sysemu/kvm.h" #include "hw/kvm/clock.h" #include "hw/sysbus.h" +#include "hw/i2c/i2c.h" #include "hw/i2c/smbus_eeprom.h" #include "hw/xen/xen-x86.h" +#include "hw/xen/xen.h" #include "exec/memory.h" #include "hw/acpi/acpi.h" -#include "hw/acpi/piix4.h" #include "qapi/error.h" #include "qemu/error-report.h" #include "sysemu/xen.h" @@ -66,6 +67,7 @@ #include "kvm/kvm-cpu.h" #define MAX_IDE_BUS 2 +#define XEN_IOAPIC_NUM_PIRQS 128ULL #ifdef CONFIG_IDE_ISA static const int ide_iobase[MAX_IDE_BUS] = { 0x1f0, 0x170 }; @@ -73,6 +75,32 @@ static const int ide_iobase2[MAX_IDE_BUS] = { 0x3f6, 0x376 }; static const int ide_irq[MAX_IDE_BUS] = { 14, 15 }; #endif +/* + * Return the global irq number corresponding to a given device irq + * pin. We could also use the bus number to have a more precise mapping. + */ +static int pci_slot_get_pirq(PCIDevice *pci_dev, int pci_intx) +{ + int slot_addend; + slot_addend = PCI_SLOT(pci_dev->devfn) - 1; + return (pci_intx + slot_addend) & 3; +} + +static void piix_intx_routing_notifier_xen(PCIDevice *dev) +{ + int i; + + /* Scan for updates to PCI link routes (0x60-0x63). */ + for (i = 0; i < PIIX_NUM_PIRQS; i++) { + uint8_t v = dev->config_read(dev, PIIX_PIRQCA + i, 1); + if (v & 0x80) { + v = 0; + } + v &= 0xf; + xen_set_pci_link_route(i, v); + } +} + /* PC hardware initialisation */ static void pc_init1(MachineState *machine, const char *host_type, const char *pci_type) @@ -84,7 +112,7 @@ static void pc_init1(MachineState *machine, MemoryRegion *system_io = get_system_io(); PCIBus *pci_bus; ISABus *isa_bus; - int piix3_devfn = -1; + Object *piix4_pm; qemu_irq smi_irq; GSIState *gsi_state; BusState *idebus[MAX_IDE_BUS]; @@ -205,10 +233,9 @@ static void pc_init1(MachineState *machine, gsi_state = pc_gsi_create(&x86ms->gsi, pcmc->pci_enabled); if (pcmc->pci_enabled) { - PIIX3State *piix3; + DeviceState *dev; PCIDevice *pci_dev; - const char *type = xen_enabled() ? TYPE_PIIX3_XEN_DEVICE - : TYPE_PIIX3_DEVICE; + int i; pci_bus = i440fx_init(pci_type, i440fx_host, @@ -216,21 +243,65 @@ static void pc_init1(MachineState *machine, x86ms->below_4g_mem_size, x86ms->above_4g_mem_size, pci_memory, ram_memory); + pci_bus_map_irqs(pci_bus, + xen_enabled() ? xen_pci_slot_get_pirq + : pci_slot_get_pirq); pcms->bus = pci_bus; - pci_dev = pci_create_simple_multifunction(pci_bus, -1, true, type); - piix3 = PIIX3_PCI_DEVICE(pci_dev); - piix3->pic = x86ms->gsi; - piix3_devfn = piix3->dev.devfn; - isa_bus = ISA_BUS(qdev_get_child_bus(DEVICE(piix3), "isa.0")); + pci_dev = pci_new_multifunction(-1, true, TYPE_PIIX3_DEVICE); + object_property_set_bool(OBJECT(pci_dev), "has-usb", + machine_usb(machine), &error_abort); + object_property_set_bool(OBJECT(pci_dev), "has-acpi", + x86_machine_is_acpi_enabled(x86ms), + &error_abort); + qdev_prop_set_uint32(DEVICE(pci_dev), "smb_io_base", 0xb100); + object_property_set_bool(OBJECT(pci_dev), "smm-enabled", + x86_machine_is_smm_enabled(x86ms), + &error_abort); + pci_realize_and_unref(pci_dev, pci_bus, &error_fatal); + + if (xen_enabled()) { + pci_device_set_intx_routing_notifier( + pci_dev, piix_intx_routing_notifier_xen); + + /* + * Xen supports additional interrupt routes from the PCI devices to + * the IOAPIC: the four pins of each PCI device on the bus are also + * connected to the IOAPIC directly. + * These additional routes can be discovered through ACPI. + */ + pci_bus_irqs(pci_bus, xen_intx_set_irq, pci_dev, + XEN_IOAPIC_NUM_PIRQS); + } + + dev = DEVICE(object_resolve_path_component(OBJECT(pci_dev), "pic")); + for (i = 0; i < ISA_NUM_IRQS; i++) { + qdev_connect_gpio_out(dev, i, x86ms->gsi[i]); + } + isa_bus = ISA_BUS(qdev_get_child_bus(DEVICE(pci_dev), "isa.0")); + rtc_state = ISA_DEVICE(object_resolve_path_component(OBJECT(pci_dev), + "rtc")); + piix4_pm = object_resolve_path_component(OBJECT(pci_dev), "pm"); + dev = DEVICE(object_resolve_path_component(OBJECT(pci_dev), "ide")); + pci_ide_create_devs(PCI_DEVICE(dev)); + idebus[0] = qdev_get_child_bus(dev, "ide.0"); + idebus[1] = qdev_get_child_bus(dev, "ide.1"); } else { pci_bus = NULL; + piix4_pm = NULL; isa_bus = isa_bus_new(NULL, get_system_memory(), system_io, &error_abort); + isa_bus_irqs(isa_bus, x86ms->gsi); + + rtc_state = isa_new(TYPE_MC146818_RTC); + qdev_prop_set_int32(DEVICE(rtc_state), "base_year", 2000); + isa_realize_and_unref(rtc_state, isa_bus, &error_fatal); + i8257_dma_init(isa_bus, 0); pcms->hpet_enabled = false; + idebus[0] = NULL; + idebus[1] = NULL; } - isa_bus_irqs(isa_bus, x86ms->gsi); if (x86ms->pic == ON_OFF_AUTO_ON || x86ms->pic == ON_OFF_AUTO_AUTO) { pc_i8259_create(isa_bus, gsi_state->i8259_irq); @@ -252,18 +323,12 @@ static void pc_init1(MachineState *machine, } /* init basic PC hardware */ - pc_basic_device_init(pcms, isa_bus, x86ms->gsi, &rtc_state, true, + pc_basic_device_init(pcms, isa_bus, x86ms->gsi, rtc_state, true, 0x4); pc_nic_init(pcmc, isa_bus, pci_bus); if (pcmc->pci_enabled) { - PCIDevice *dev; - - dev = pci_create_simple(pci_bus, piix3_devfn + 1, TYPE_PIIX3_IDE); - pci_ide_create_devs(dev); - idebus[0] = qdev_get_child_bus(&dev->qdev, "ide.0"); - idebus[1] = qdev_get_child_bus(&dev->qdev, "ide.1"); pc_cmos_init(pcms, idebus[0], idebus[1], rtc_state); } #ifdef CONFIG_IDE_ISA @@ -289,21 +354,9 @@ static void pc_init1(MachineState *machine, } #endif - if (pcmc->pci_enabled && machine_usb(machine)) { - pci_create_simple(pci_bus, piix3_devfn + 2, "piix3-usb-uhci"); - } - - if (pcmc->pci_enabled && x86_machine_is_acpi_enabled(X86_MACHINE(pcms))) { - PCIDevice *piix4_pm; - + if (piix4_pm) { smi_irq = qemu_allocate_irq(pc_acpi_smi_interrupt, first_cpu, 0); - piix4_pm = pci_new(piix3_devfn + 3, TYPE_PIIX4_PM); - qdev_prop_set_uint32(DEVICE(piix4_pm), "smb_io_base", 0xb100); - qdev_prop_set_bit(DEVICE(piix4_pm), "smm-enabled", - x86_machine_is_smm_enabled(x86ms)); - pci_realize_and_unref(piix4_pm, pci_bus, &error_fatal); - qdev_connect_gpio_out(DEVICE(piix4_pm), 0, x86ms->gsi[9]); qdev_connect_gpio_out_named(DEVICE(piix4_pm), "smi-irq", 0, smi_irq); pcms->smbus = I2C_BUS(qdev_get_child_bus(DEVICE(piix4_pm), "i2c")); /* TODO: Populate SPD eeprom data. */ @@ -315,7 +368,7 @@ static void pc_init1(MachineState *machine, object_property_allow_set_link, OBJ_PROP_LINK_STRONG); object_property_set_link(OBJECT(machine), PC_MACHINE_ACPI_DEVICE_PROP, - OBJECT(piix4_pm), &error_abort); + piix4_pm, &error_abort); } if (machine->nvdimms_state->is_enabled) { @@ -405,6 +458,9 @@ static void pc_xen_hvm_init(MachineState *machine) } pc_xen_hvm_init_pci(machine); + if (xen_igd_gfx_pt_enabled()) { + xen_igd_reserve_slot(pcms->bus); + } pci_create_simple(pcms->bus, -1, "xen-platform"); } #endif @@ -441,6 +497,11 @@ static void pc_i440fx_8_0_machine_options(MachineClass *m) pc_i440fx_machine_options(m); m->alias = "pc"; m->is_default = true; +#ifdef CONFIG_MICROVM_DEFAULT + m->is_default = false; +#else + m->is_default = true; +#endif } DEFINE_I440FX_MACHINE(v8_0, "pc-i440fx-8.0", NULL, diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c index 0ec7e52183..eff38155ef 100644 --- a/hw/xen/xen_pt.c +++ b/hw/xen/xen_pt.c @@ -780,15 +780,6 @@ static void xen_pt_realize(PCIDevice *d, Error **errp) s->hostaddr.bus, s->hostaddr.slot, s->hostaddr.function, s->dev.devfn); - xen_host_pci_device_get(&s->real_device, - s->hostaddr.domain, s->hostaddr.bus, - s->hostaddr.slot, s->hostaddr.function, - errp); - if (*errp) { - error_append_hint(errp, "Failed to \"open\" the real pci device"); - return; - } - s->is_virtfn = s->real_device.is_virtfn; if (s->is_virtfn) { XEN_PT_LOG(d, "%04x:%02x:%02x.%d is a SR-IOV Virtual Function\n", @@ -950,11 +941,50 @@ static void xen_pci_passthrough_instance_init(Object *obj) PCI_DEVICE(obj)->cap_present |= QEMU_PCI_CAP_EXPRESS; } +void xen_igd_reserve_slot(PCIBus *pci_bus) +{ + XEN_PT_LOG(0, "Reserving PCI slot 2 for IGD\n"); + pci_bus->slot_reserved_mask |= XEN_PCI_IGD_SLOT_MASK; +} + +static void xen_igd_clear_slot(DeviceState *qdev, Error **errp) +{ + ERRP_GUARD(); + PCIDevice *pci_dev = (PCIDevice *)qdev; + XenPCIPassthroughState *s = XEN_PT_DEVICE(pci_dev); + XenPTDeviceClass *xpdc = XEN_PT_DEVICE_GET_CLASS(s); + PCIBus *pci_bus = pci_get_bus(pci_dev); + + if (!(pci_bus->slot_reserved_mask & XEN_PCI_IGD_SLOT_MASK)) + return; + + xen_host_pci_device_get(&s->real_device, + s->hostaddr.domain, s->hostaddr.bus, + s->hostaddr.slot, s->hostaddr.function, + errp); + if (*errp) { + error_append_hint(errp, "Failed to \"open\" the real pci device"); + return; + } + + if (is_igd_vga_passthrough(&s->real_device) && + s->real_device.domain == 0 && s->real_device.bus == 0 && + s->real_device.dev == 2 && s->real_device.func == 0 && + s->real_device.vendor_id == PCI_VENDOR_ID_INTEL) { + pci_bus->slot_reserved_mask &= ~XEN_PCI_IGD_SLOT_MASK; + XEN_PT_LOG(pci_dev, "Intel IGD found, using slot 2\n"); + } + xpdc->pci_qdev_realize(qdev, errp); +} + static void xen_pci_passthrough_class_init(ObjectClass *klass, void *data) { DeviceClass *dc = DEVICE_CLASS(klass); PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); + XenPTDeviceClass *xpdc = XEN_PT_DEVICE_CLASS(klass); + xpdc->pci_qdev_realize = dc->realize; + dc->realize = xen_igd_clear_slot; k->realize = xen_pt_realize; k->exit = xen_pt_unregister_device; k->config_read = xen_pt_pci_read_config; @@ -977,6 +1007,7 @@ static const TypeInfo xen_pci_passthrough_info = { .instance_size = sizeof(XenPCIPassthroughState), .instance_finalize = xen_pci_passthrough_finalize, .class_init = xen_pci_passthrough_class_init, + .class_size = sizeof(XenPTDeviceClass), .instance_init = xen_pci_passthrough_instance_init, .interfaces = (InterfaceInfo[]) { { INTERFACE_CONVENTIONAL_PCI_DEVICE }, diff --git a/hw/xen/xen_pt.h b/hw/xen/xen_pt.h index cf10fc7bbf..8c25932b4b 100644 --- a/hw/xen/xen_pt.h +++ b/hw/xen/xen_pt.h @@ -2,6 +2,7 @@ #define XEN_PT_H #include "hw/xen/xen_common.h" +#include "hw/pci/pci_bus.h" #include "xen-host-pci-device.h" #include "qom/object.h" @@ -40,7 +41,20 @@ typedef struct XenPTReg XenPTReg; #define TYPE_XEN_PT_DEVICE "xen-pci-passthrough" OBJECT_DECLARE_SIMPLE_TYPE(XenPCIPassthroughState, XEN_PT_DEVICE) +#define XEN_PT_DEVICE_CLASS(klass) \ + OBJECT_CLASS_CHECK(XenPTDeviceClass, klass, TYPE_XEN_PT_DEVICE) +#define XEN_PT_DEVICE_GET_CLASS(obj) \ + OBJECT_GET_CLASS(XenPTDeviceClass, obj, TYPE_XEN_PT_DEVICE) + +typedef void (*XenPTQdevRealize)(DeviceState *qdev, Error **errp); + +typedef struct XenPTDeviceClass { + PCIDeviceClass parent_class; + XenPTQdevRealize pci_qdev_realize; +} XenPTDeviceClass; + uint32_t igd_read_opregion(XenPCIPassthroughState *s); +void xen_igd_reserve_slot(PCIBus *pci_bus); void igd_write_opregion(XenPCIPassthroughState *s, uint32_t val); void xen_igd_passthrough_isa_bridge_create(XenPCIPassthroughState *s, XenHostPCIDevice *dev); @@ -75,6 +89,8 @@ typedef int (*xen_pt_conf_byte_read) #define XEN_PCI_INTEL_OPREGION 0xfc +#define XEN_PCI_IGD_SLOT_MASK 0x4UL /* Intel IGD slot_reserved_mask */ + typedef enum { XEN_PT_GRP_TYPE_HARDWIRED = 0, /* 0 Hardwired reg group */ XEN_PT_GRP_TYPE_EMU, /* emul reg group */ diff --git a/hw/xen/xen_pt_stub.c b/hw/xen/xen_pt_stub.c index 2d8cac8d54..5c108446a8 100644 --- a/hw/xen/xen_pt_stub.c +++ b/hw/xen/xen_pt_stub.c @@ -20,3 +20,7 @@ void xen_igd_gfx_pt_set(bool value, Error **errp) error_setg(errp, "Xen PCI passthrough support not built in"); } } + +void xen_igd_reserve_slot(PCIBus *pci_bus) +{ +} -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Mon Jan 09 22:00:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 22:00:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474059.734960 (Exim 4.92) (envelope-from ) id 1pF0Br-0001JX-Jv; Mon, 09 Jan 2023 22:00:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474059.734960; Mon, 09 Jan 2023 22:00:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF0Br-0001JQ-H2; Mon, 09 Jan 2023 22:00:23 +0000 Received: by outflank-mailman (input) for mailman id 474059; Mon, 09 Jan 2023 22:00:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF0Bq-0001JG-S3; Mon, 09 Jan 2023 22:00:22 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF0Bq-0002GV-Ng; Mon, 09 Jan 2023 22:00:22 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF0Bq-0008IL-C7; Mon, 09 Jan 2023 22:00:22 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pF0Bq-0004rA-Bf; Mon, 09 Jan 2023 22:00:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Vkt45SE6wJg2tjX9ASRsMHcHdNfpSIYzkeVea+jaqto=; b=BE7GnJ26ysNbgumMNMxOJDtvny GnOKK/Q1oU1jkBTsBXgh97q1MNfSHtBR4aoZl58FcSYHnSLhXaYft6lSpNPaUgRhKoUQ1x6kKABVi oXaUKiBTIvX6bd5DDYDozJvh6HDz8O3qcH9qzPYBa63wtiAlEkeAdoc5dPsu0sgNZD10=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 175642: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=1fe4fd6f5cad346e598593af36caeadc4f5d4fa9 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Mon, 09 Jan 2023 22:00:22 +0000 flight 175642 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/175642/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine 8 reboot fail REGR. vs. 173462 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux 1fe4fd6f5cad346e598593af36caeadc4f5d4fa9 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 94 days Failing since 173470 2022-10-08 06:21:34 Z 93 days 196 attempts Testing same since 175634 2023-01-09 01:40:59 Z 0 days 2 attempts ------------------------------------------------------------ 3317 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 505645 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Jan 09 22:33:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 22:33:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474072.734982 (Exim 4.92) (envelope-from ) id 1pF0i1-0004mm-Bt; Mon, 09 Jan 2023 22:33:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474072.734982; Mon, 09 Jan 2023 22:33:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF0i1-0004mf-9H; Mon, 09 Jan 2023 22:33:37 +0000 Received: by outflank-mailman (input) for mailman id 474072; Mon, 09 Jan 2023 22:33:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF0hz-0004mZ-Or for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 22:33:36 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a5a7225e-906d-11ed-91b6-6bf2151ebd3b; Mon, 09 Jan 2023 23:33:33 +0100 (CET) Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-182-R8Lh8twDPVOy9RSSsUdPwQ-1; Mon, 09 Jan 2023 17:33:31 -0500 Received: by mail-qv1-f70.google.com with SMTP id q17-20020a056214019100b004b1d3c9f3acso5946286qvr.0 for ; Mon, 09 Jan 2023 14:33:30 -0800 (PST) Received: from redhat.com ([185.199.102.79]) by smtp.gmail.com with ESMTPSA id k14-20020ac8478e000000b003a820f9fb70sm5183013qtq.36.2023.01.09.14.33.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 14:33:29 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a5a7225e-906d-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673303612; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RsiJAtB/qcJ8ifOYLs4heG+cPPY9pzvbSF2Y9UT+p6c=; b=LY0irCJlRCLrpsFuoUoUmJJktUyCrJxICmbd4H+mV6nfNAGl0xGCvaK4bva7nQUoUTZ5Ct eX2XDCPJyUQpD7areMvSSSjmov8NSaeUqaALPFYhEmugIamp+pQ0Tw8aPdlBx518eBytqY B+TE9F3voyt0EH5LDlkiTTeA4yAs3JM= X-MC-Unique: R8Lh8twDPVOy9RSSsUdPwQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RsiJAtB/qcJ8ifOYLs4heG+cPPY9pzvbSF2Y9UT+p6c=; b=1lh6DfJ6yhVJLofPcI7tdGTw0Eo+OwMiuBg1gEMHyiQPx4g2+i5SpfQdFoAbQoSqdi AAoTjPyTmH7mxuiqjjS7lddnWEDUgbuOKy1D/0UgqGDQRlqAI7ZryK/n3vSQTnWtEI5B G1c/8ipxj8SR6SSwDnxJtIf8h07iBEH4hDdQO7DO3IjXvGWS8BuSol79Lhu89WOOQSwP zZzujVg5KICyP2Q6dBp6Ly3jyGGHROcNcia3BF0EmZPRMFHGVfqDVX9WdfAvVw8phdM4 ER05QOC6wbAjL4RtVuqAFVT6LnZSnXb8sAC4ev8UmD6ajfCNvwvL4gHZm6T6YiGn7MFD EvAA== X-Gm-Message-State: AFqh2kqmcSE2YQgtpjGv0k5yYEdLd0IdwycuJwqQ7vJ2gQI/ENTFgt5O RLjN1BkTW54n+9j2mj3/4nF47N5KQC5pgGFStF5Tb2ehI9TQVolmXI5Ah4LkVRiNto0EhPMPHAw fFt6iB5iNQi9PJnNhKxfFAMajrpA= X-Received: by 2002:ac8:7ef7:0:b0:3a7:e2a1:331f with SMTP id r23-20020ac87ef7000000b003a7e2a1331fmr93987532qtc.7.1673303610312; Mon, 09 Jan 2023 14:33:30 -0800 (PST) X-Google-Smtp-Source: AMrXdXtaob7RqRhF9iLiwcSc/zFn5EOlap6OIsPq92ia5ApkVxX2ABZ01lPSYcmGbVjA+riWVsTScA== X-Received: by 2002:ac8:7ef7:0:b0:3a7:e2a1:331f with SMTP id r23-20020ac87ef7000000b003a7e2a1331fmr93987489qtc.7.1673303609817; Mon, 09 Jan 2023 14:33:29 -0800 (PST) Date: Mon, 9 Jan 2023 17:33:23 -0500 From: "Michael S. Tsirkin" To: Chuck Zmudzinski Cc: qemu-devel@nongnu.org, Stefano Stabellini , Anthony Perard , Paul Durrant , Paolo Bonzini , Richard Henderson , Eduardo Habkost , Marcel Apfelbaum , xen-devel@lists.xenproject.org Subject: Re: [PATCH v7] xen/pt: reserve PCI slot 2 for Intel igd-passthru Message-ID: <20230109172738-mutt-send-email-mst@kernel.org> References: <8349506149de6d81b0762f17623552c248439e93.1673297742.git.brchuckz.ref@aol.com> <8349506149de6d81b0762f17623552c248439e93.1673297742.git.brchuckz@aol.com> MIME-Version: 1.0 In-Reply-To: <8349506149de6d81b0762f17623552c248439e93.1673297742.git.brchuckz@aol.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jan 09, 2023 at 04:55:42PM -0500, Chuck Zmudzinski wrote: > Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, > as noted in docs/igd-assign.txt in the Qemu source code. > > Currently, when the xl toolstack is used to configure a Xen HVM guest with > Intel IGD passthrough to the guest with the Qemu upstream device model, > a Qemu emulated PCI device will occupy slot 2 and the Intel IGD will occupy > a different slot. This problem often prevents the guest from booting. > > The only available workaround is not good: Configure Xen HVM guests to use > the old and no longer maintained Qemu traditional device model available > from xenbits.xen.org which does reserve slot 2 for the Intel IGD. > > To implement this feature in the Qemu upstream device model for Xen HVM > guests, introduce the following new functions, types, and macros: > > * XEN_PT_DEVICE_CLASS declaration, based on the existing TYPE_XEN_PT_DEVICE > * XEN_PT_DEVICE_GET_CLASS macro helper function for XEN_PT_DEVICE_CLASS > * typedef XenPTQdevRealize function pointer > * XEN_PCI_IGD_SLOT_MASK, the value of slot_reserved_mask to reserve slot 2 > * xen_igd_reserve_slot and xen_igd_clear_slot functions > > The new xen_igd_reserve_slot function uses the existing slot_reserved_mask > member of PCIBus to reserve PCI slot 2 for Xen HVM guests configured using > the xl toolstack with the gfx_passthru option enabled, which sets the > igd-passthru=on option to Qemu for the Xen HVM machine type. I don't like how slot_reserved_mask is set initially then cleared on device realize. To me this looks like a fragile hack. I suggest one of the following 1. adding a new mask "slot-manual-mask" or some such blocking auto-allocation of a given slot without blocking its use if address is specified on command line. 2. adding a special property that overrides slot_reserved_mask for a given device. both need changes in pci core but look like something generally useful. > > The new xen_igd_reserve_slot function also needs to be implemented in > hw/xen/xen_pt_stub.c to prevent FTBFS during the link stage for the case > when Qemu is configured with --enable-xen and --disable-xen-pci-passthrough, > in which case it does nothing. > > The new xen_igd_clear_slot function overrides qdev->realize of the parent > PCI device class to enable the Intel IGD to occupy slot 2 on the PCI bus > since slot 2 was reserved by xen_igd_reserve_slot when the PCI bus was > created in hw/i386/pc_piix.c for the case when igd-passthru=on. > > Move the call to xen_host_pci_device_get, and the associated error > handling, from xen_pt_realize to the new xen_igd_clear_slot function to > initialize the device class and vendor values which enables the checks for > the Intel IGD to succeed. The verification that the host device is an > Intel IGD to be passed through is done by checking the domain, bus, slot, > and function values as well as by checking that gfx_passthru is enabled, > the device class is VGA, and the device vendor in Intel. > > Signed-off-by: Chuck Zmudzinski > --- > Notes that might be helpful to reviewers of patched code in hw/xen: > > The new functions and types are based on recommendations from Qemu docs: > https://qemu.readthedocs.io/en/latest/devel/qom.html > > Notes that might be helpful to reviewers of patched code in hw/i386: > > The small patch to hw/i386/pc_piix.c is protected by CONFIG_XEN so it does > not affect builds that do not have CONFIG_XEN defined. > > xen_igd_gfx_pt_enabled() in the patched hw/i386/pc_piix.c file is an > existing function that is only true when Qemu is built with > xen-pci-passthrough enabled and the administrator has configured the Xen > HVM guest with Qemu's igd-passthru=on option. > > v2: Remove From: tag at top of commit message > > v3: Changed the test for the Intel IGD in xen_igd_clear_slot: > > if (is_igd_vga_passthrough(&s->real_device) && > (s->real_device.vendor_id == PCI_VENDOR_ID_INTEL)) { > > is changed to > > if (xen_igd_gfx_pt_enabled() && (s->hostaddr.slot == 2) > && (s->hostaddr.function == 0)) { > > I hoped that I could use the test in v2, since it matches the > other tests for the Intel IGD in Qemu and Xen, but those tests > do not work because the necessary data structures are not set with > their values yet. So instead use the test that the administrator > has enabled gfx_passthru and the device address on the host is > 02.0. This test does detect the Intel IGD correctly. > > v4: Use brchuckz@aol.com instead of brchuckz@netscape.net for the author's > email address to match the address used by the same author in commits > be9c61da and c0e86b76 > > Change variable for XEN_PT_DEVICE_CLASS: xptc changed to xpdc > > v5: The patch of xen_pt.c was re-worked to allow a more consistent test > for the Intel IGD that uses the same criteria as in other places. > This involved moving the call to xen_host_pci_device_get from > xen_pt_realize to xen_igd_clear_slot and updating the checks for the > Intel IGD in xen_igd_clear_slot: > > if (xen_igd_gfx_pt_enabled() && (s->hostaddr.slot == 2) > && (s->hostaddr.function == 0)) { > > is changed to > > if (is_igd_vga_passthrough(&s->real_device) && > s->real_device.domain == 0 && s->real_device.bus == 0 && > s->real_device.dev == 2 && s->real_device.func == 0 && > s->real_device.vendor_id == PCI_VENDOR_ID_INTEL) { > > Added an explanation for the move of xen_host_pci_device_get from > xen_pt_realize to xen_igd_clear_slot to the commit message. > > Rebase. > > v6: Fix logging by removing these lines from the move from xen_pt_realize > to xen_igd_clear_slot that was done in v5: > > XEN_PT_LOG(d, "Assigning real physical device %02x:%02x.%d" > " to devfn 0x%x\n", > s->hostaddr.bus, s->hostaddr.slot, s->hostaddr.function, > s->dev.devfn); > > This log needs to be in xen_pt_realize because s->dev.devfn is not > set yet in xen_igd_clear_slot. > > v7: Inhibit out of context log message and needless processing by > adding 2 lines at the top of the new xen_igd_clear_slot function: > > if (!(pci_bus->slot_reserved_mask & XEN_PCI_IGD_SLOT_MASK)) > return; > > Rebase. This removed an unnecessary header file from xen_pt.h > > hw/i386/pc_piix.c | 127 ++++++++++++++++++++++++++++++++----------- > hw/xen/xen_pt.c | 49 ++++++++++++++--- > hw/xen/xen_pt.h | 16 ++++++ > hw/xen/xen_pt_stub.c | 4 ++ > 4 files changed, 154 insertions(+), 42 deletions(-) > > diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c > index b48047f50c..34a9736b5e 100644 > --- a/hw/i386/pc_piix.c > +++ b/hw/i386/pc_piix.c > @@ -32,6 +32,7 @@ > #include "hw/i386/pc.h" > #include "hw/i386/apic.h" > #include "hw/pci-host/i440fx.h" > +#include "hw/rtc/mc146818rtc.h" > #include "hw/southbridge/piix.h" > #include "hw/display/ramfb.h" > #include "hw/firmware/smbios.h" > @@ -40,16 +41,16 @@ > #include "hw/usb.h" > #include "net/net.h" > #include "hw/ide/pci.h" > -#include "hw/ide/piix.h" > #include "hw/irq.h" > #include "sysemu/kvm.h" > #include "hw/kvm/clock.h" > #include "hw/sysbus.h" > +#include "hw/i2c/i2c.h" > #include "hw/i2c/smbus_eeprom.h" > #include "hw/xen/xen-x86.h" > +#include "hw/xen/xen.h" > #include "exec/memory.h" > #include "hw/acpi/acpi.h" > -#include "hw/acpi/piix4.h" > #include "qapi/error.h" > #include "qemu/error-report.h" > #include "sysemu/xen.h" > @@ -66,6 +67,7 @@ > #include "kvm/kvm-cpu.h" > > #define MAX_IDE_BUS 2 > +#define XEN_IOAPIC_NUM_PIRQS 128ULL > > #ifdef CONFIG_IDE_ISA > static const int ide_iobase[MAX_IDE_BUS] = { 0x1f0, 0x170 }; > @@ -73,6 +75,32 @@ static const int ide_iobase2[MAX_IDE_BUS] = { 0x3f6, 0x376 }; > static const int ide_irq[MAX_IDE_BUS] = { 14, 15 }; > #endif > > +/* > + * Return the global irq number corresponding to a given device irq > + * pin. We could also use the bus number to have a more precise mapping. > + */ > +static int pci_slot_get_pirq(PCIDevice *pci_dev, int pci_intx) > +{ > + int slot_addend; > + slot_addend = PCI_SLOT(pci_dev->devfn) - 1; > + return (pci_intx + slot_addend) & 3; > +} > + > +static void piix_intx_routing_notifier_xen(PCIDevice *dev) > +{ > + int i; > + > + /* Scan for updates to PCI link routes (0x60-0x63). */ > + for (i = 0; i < PIIX_NUM_PIRQS; i++) { > + uint8_t v = dev->config_read(dev, PIIX_PIRQCA + i, 1); > + if (v & 0x80) { > + v = 0; > + } > + v &= 0xf; > + xen_set_pci_link_route(i, v); > + } > +} > + > /* PC hardware initialisation */ > static void pc_init1(MachineState *machine, > const char *host_type, const char *pci_type) > @@ -84,7 +112,7 @@ static void pc_init1(MachineState *machine, > MemoryRegion *system_io = get_system_io(); > PCIBus *pci_bus; > ISABus *isa_bus; > - int piix3_devfn = -1; > + Object *piix4_pm; > qemu_irq smi_irq; > GSIState *gsi_state; > BusState *idebus[MAX_IDE_BUS]; > @@ -205,10 +233,9 @@ static void pc_init1(MachineState *machine, > gsi_state = pc_gsi_create(&x86ms->gsi, pcmc->pci_enabled); > > if (pcmc->pci_enabled) { > - PIIX3State *piix3; > + DeviceState *dev; > PCIDevice *pci_dev; > - const char *type = xen_enabled() ? TYPE_PIIX3_XEN_DEVICE > - : TYPE_PIIX3_DEVICE; > + int i; > > pci_bus = i440fx_init(pci_type, > i440fx_host, > @@ -216,21 +243,65 @@ static void pc_init1(MachineState *machine, > x86ms->below_4g_mem_size, > x86ms->above_4g_mem_size, > pci_memory, ram_memory); > + pci_bus_map_irqs(pci_bus, > + xen_enabled() ? xen_pci_slot_get_pirq > + : pci_slot_get_pirq); > pcms->bus = pci_bus; > > - pci_dev = pci_create_simple_multifunction(pci_bus, -1, true, type); > - piix3 = PIIX3_PCI_DEVICE(pci_dev); > - piix3->pic = x86ms->gsi; > - piix3_devfn = piix3->dev.devfn; > - isa_bus = ISA_BUS(qdev_get_child_bus(DEVICE(piix3), "isa.0")); > + pci_dev = pci_new_multifunction(-1, true, TYPE_PIIX3_DEVICE); > + object_property_set_bool(OBJECT(pci_dev), "has-usb", > + machine_usb(machine), &error_abort); > + object_property_set_bool(OBJECT(pci_dev), "has-acpi", > + x86_machine_is_acpi_enabled(x86ms), > + &error_abort); > + qdev_prop_set_uint32(DEVICE(pci_dev), "smb_io_base", 0xb100); > + object_property_set_bool(OBJECT(pci_dev), "smm-enabled", > + x86_machine_is_smm_enabled(x86ms), > + &error_abort); > + pci_realize_and_unref(pci_dev, pci_bus, &error_fatal); > + > + if (xen_enabled()) { > + pci_device_set_intx_routing_notifier( > + pci_dev, piix_intx_routing_notifier_xen); > + > + /* > + * Xen supports additional interrupt routes from the PCI devices to > + * the IOAPIC: the four pins of each PCI device on the bus are also > + * connected to the IOAPIC directly. > + * These additional routes can be discovered through ACPI. > + */ > + pci_bus_irqs(pci_bus, xen_intx_set_irq, pci_dev, > + XEN_IOAPIC_NUM_PIRQS); > + } > + > + dev = DEVICE(object_resolve_path_component(OBJECT(pci_dev), "pic")); > + for (i = 0; i < ISA_NUM_IRQS; i++) { > + qdev_connect_gpio_out(dev, i, x86ms->gsi[i]); > + } > + isa_bus = ISA_BUS(qdev_get_child_bus(DEVICE(pci_dev), "isa.0")); > + rtc_state = ISA_DEVICE(object_resolve_path_component(OBJECT(pci_dev), > + "rtc")); > + piix4_pm = object_resolve_path_component(OBJECT(pci_dev), "pm"); > + dev = DEVICE(object_resolve_path_component(OBJECT(pci_dev), "ide")); > + pci_ide_create_devs(PCI_DEVICE(dev)); > + idebus[0] = qdev_get_child_bus(dev, "ide.0"); > + idebus[1] = qdev_get_child_bus(dev, "ide.1"); > } else { > pci_bus = NULL; > + piix4_pm = NULL; > isa_bus = isa_bus_new(NULL, get_system_memory(), system_io, > &error_abort); > + isa_bus_irqs(isa_bus, x86ms->gsi); > + > + rtc_state = isa_new(TYPE_MC146818_RTC); > + qdev_prop_set_int32(DEVICE(rtc_state), "base_year", 2000); > + isa_realize_and_unref(rtc_state, isa_bus, &error_fatal); > + > i8257_dma_init(isa_bus, 0); > pcms->hpet_enabled = false; > + idebus[0] = NULL; > + idebus[1] = NULL; > } > - isa_bus_irqs(isa_bus, x86ms->gsi); > > if (x86ms->pic == ON_OFF_AUTO_ON || x86ms->pic == ON_OFF_AUTO_AUTO) { > pc_i8259_create(isa_bus, gsi_state->i8259_irq); > @@ -252,18 +323,12 @@ static void pc_init1(MachineState *machine, > } > > /* init basic PC hardware */ > - pc_basic_device_init(pcms, isa_bus, x86ms->gsi, &rtc_state, true, > + pc_basic_device_init(pcms, isa_bus, x86ms->gsi, rtc_state, true, > 0x4); > > pc_nic_init(pcmc, isa_bus, pci_bus); > > if (pcmc->pci_enabled) { > - PCIDevice *dev; > - > - dev = pci_create_simple(pci_bus, piix3_devfn + 1, TYPE_PIIX3_IDE); > - pci_ide_create_devs(dev); > - idebus[0] = qdev_get_child_bus(&dev->qdev, "ide.0"); > - idebus[1] = qdev_get_child_bus(&dev->qdev, "ide.1"); > pc_cmos_init(pcms, idebus[0], idebus[1], rtc_state); > } > #ifdef CONFIG_IDE_ISA > @@ -289,21 +354,9 @@ static void pc_init1(MachineState *machine, > } > #endif > > - if (pcmc->pci_enabled && machine_usb(machine)) { > - pci_create_simple(pci_bus, piix3_devfn + 2, "piix3-usb-uhci"); > - } > - > - if (pcmc->pci_enabled && x86_machine_is_acpi_enabled(X86_MACHINE(pcms))) { > - PCIDevice *piix4_pm; > - > + if (piix4_pm) { > smi_irq = qemu_allocate_irq(pc_acpi_smi_interrupt, first_cpu, 0); > - piix4_pm = pci_new(piix3_devfn + 3, TYPE_PIIX4_PM); > - qdev_prop_set_uint32(DEVICE(piix4_pm), "smb_io_base", 0xb100); > - qdev_prop_set_bit(DEVICE(piix4_pm), "smm-enabled", > - x86_machine_is_smm_enabled(x86ms)); > - pci_realize_and_unref(piix4_pm, pci_bus, &error_fatal); > > - qdev_connect_gpio_out(DEVICE(piix4_pm), 0, x86ms->gsi[9]); > qdev_connect_gpio_out_named(DEVICE(piix4_pm), "smi-irq", 0, smi_irq); > pcms->smbus = I2C_BUS(qdev_get_child_bus(DEVICE(piix4_pm), "i2c")); > /* TODO: Populate SPD eeprom data. */ > @@ -315,7 +368,7 @@ static void pc_init1(MachineState *machine, > object_property_allow_set_link, > OBJ_PROP_LINK_STRONG); > object_property_set_link(OBJECT(machine), PC_MACHINE_ACPI_DEVICE_PROP, > - OBJECT(piix4_pm), &error_abort); > + piix4_pm, &error_abort); > } > > if (machine->nvdimms_state->is_enabled) { > @@ -405,6 +458,9 @@ static void pc_xen_hvm_init(MachineState *machine) > } > > pc_xen_hvm_init_pci(machine); > + if (xen_igd_gfx_pt_enabled()) { > + xen_igd_reserve_slot(pcms->bus); > + } > pci_create_simple(pcms->bus, -1, "xen-platform"); > } > #endif > @@ -441,6 +497,11 @@ static void pc_i440fx_8_0_machine_options(MachineClass *m) > pc_i440fx_machine_options(m); > m->alias = "pc"; > m->is_default = true; > +#ifdef CONFIG_MICROVM_DEFAULT > + m->is_default = false; > +#else > + m->is_default = true; > +#endif > } > > DEFINE_I440FX_MACHINE(v8_0, "pc-i440fx-8.0", NULL, > diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c > index 0ec7e52183..eff38155ef 100644 > --- a/hw/xen/xen_pt.c > +++ b/hw/xen/xen_pt.c > @@ -780,15 +780,6 @@ static void xen_pt_realize(PCIDevice *d, Error **errp) > s->hostaddr.bus, s->hostaddr.slot, s->hostaddr.function, > s->dev.devfn); > > - xen_host_pci_device_get(&s->real_device, > - s->hostaddr.domain, s->hostaddr.bus, > - s->hostaddr.slot, s->hostaddr.function, > - errp); > - if (*errp) { > - error_append_hint(errp, "Failed to \"open\" the real pci device"); > - return; > - } > - > s->is_virtfn = s->real_device.is_virtfn; > if (s->is_virtfn) { > XEN_PT_LOG(d, "%04x:%02x:%02x.%d is a SR-IOV Virtual Function\n", > @@ -950,11 +941,50 @@ static void xen_pci_passthrough_instance_init(Object *obj) > PCI_DEVICE(obj)->cap_present |= QEMU_PCI_CAP_EXPRESS; > } > > +void xen_igd_reserve_slot(PCIBus *pci_bus) > +{ > + XEN_PT_LOG(0, "Reserving PCI slot 2 for IGD\n"); > + pci_bus->slot_reserved_mask |= XEN_PCI_IGD_SLOT_MASK; > +} > + > +static void xen_igd_clear_slot(DeviceState *qdev, Error **errp) > +{ > + ERRP_GUARD(); > + PCIDevice *pci_dev = (PCIDevice *)qdev; > + XenPCIPassthroughState *s = XEN_PT_DEVICE(pci_dev); > + XenPTDeviceClass *xpdc = XEN_PT_DEVICE_GET_CLASS(s); > + PCIBus *pci_bus = pci_get_bus(pci_dev); > + > + if (!(pci_bus->slot_reserved_mask & XEN_PCI_IGD_SLOT_MASK)) > + return; > + > + xen_host_pci_device_get(&s->real_device, > + s->hostaddr.domain, s->hostaddr.bus, > + s->hostaddr.slot, s->hostaddr.function, > + errp); > + if (*errp) { > + error_append_hint(errp, "Failed to \"open\" the real pci device"); > + return; > + } > + > + if (is_igd_vga_passthrough(&s->real_device) && > + s->real_device.domain == 0 && s->real_device.bus == 0 && > + s->real_device.dev == 2 && s->real_device.func == 0 && > + s->real_device.vendor_id == PCI_VENDOR_ID_INTEL) { > + pci_bus->slot_reserved_mask &= ~XEN_PCI_IGD_SLOT_MASK; > + XEN_PT_LOG(pci_dev, "Intel IGD found, using slot 2\n"); > + } > + xpdc->pci_qdev_realize(qdev, errp); > +} > + > static void xen_pci_passthrough_class_init(ObjectClass *klass, void *data) > { > DeviceClass *dc = DEVICE_CLASS(klass); > PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); > > + XenPTDeviceClass *xpdc = XEN_PT_DEVICE_CLASS(klass); > + xpdc->pci_qdev_realize = dc->realize; > + dc->realize = xen_igd_clear_slot; > k->realize = xen_pt_realize; > k->exit = xen_pt_unregister_device; > k->config_read = xen_pt_pci_read_config; > @@ -977,6 +1007,7 @@ static const TypeInfo xen_pci_passthrough_info = { > .instance_size = sizeof(XenPCIPassthroughState), > .instance_finalize = xen_pci_passthrough_finalize, > .class_init = xen_pci_passthrough_class_init, > + .class_size = sizeof(XenPTDeviceClass), > .instance_init = xen_pci_passthrough_instance_init, > .interfaces = (InterfaceInfo[]) { > { INTERFACE_CONVENTIONAL_PCI_DEVICE }, > diff --git a/hw/xen/xen_pt.h b/hw/xen/xen_pt.h > index cf10fc7bbf..8c25932b4b 100644 > --- a/hw/xen/xen_pt.h > +++ b/hw/xen/xen_pt.h > @@ -2,6 +2,7 @@ > #define XEN_PT_H > > #include "hw/xen/xen_common.h" > +#include "hw/pci/pci_bus.h" > #include "xen-host-pci-device.h" > #include "qom/object.h" > > @@ -40,7 +41,20 @@ typedef struct XenPTReg XenPTReg; > #define TYPE_XEN_PT_DEVICE "xen-pci-passthrough" > OBJECT_DECLARE_SIMPLE_TYPE(XenPCIPassthroughState, XEN_PT_DEVICE) > > +#define XEN_PT_DEVICE_CLASS(klass) \ > + OBJECT_CLASS_CHECK(XenPTDeviceClass, klass, TYPE_XEN_PT_DEVICE) > +#define XEN_PT_DEVICE_GET_CLASS(obj) \ > + OBJECT_GET_CLASS(XenPTDeviceClass, obj, TYPE_XEN_PT_DEVICE) > + > +typedef void (*XenPTQdevRealize)(DeviceState *qdev, Error **errp); > + > +typedef struct XenPTDeviceClass { > + PCIDeviceClass parent_class; > + XenPTQdevRealize pci_qdev_realize; > +} XenPTDeviceClass; > + > uint32_t igd_read_opregion(XenPCIPassthroughState *s); > +void xen_igd_reserve_slot(PCIBus *pci_bus); > void igd_write_opregion(XenPCIPassthroughState *s, uint32_t val); > void xen_igd_passthrough_isa_bridge_create(XenPCIPassthroughState *s, > XenHostPCIDevice *dev); > @@ -75,6 +89,8 @@ typedef int (*xen_pt_conf_byte_read) > > #define XEN_PCI_INTEL_OPREGION 0xfc > > +#define XEN_PCI_IGD_SLOT_MASK 0x4UL /* Intel IGD slot_reserved_mask */ > + > typedef enum { > XEN_PT_GRP_TYPE_HARDWIRED = 0, /* 0 Hardwired reg group */ > XEN_PT_GRP_TYPE_EMU, /* emul reg group */ > diff --git a/hw/xen/xen_pt_stub.c b/hw/xen/xen_pt_stub.c > index 2d8cac8d54..5c108446a8 100644 > --- a/hw/xen/xen_pt_stub.c > +++ b/hw/xen/xen_pt_stub.c > @@ -20,3 +20,7 @@ void xen_igd_gfx_pt_set(bool value, Error **errp) > error_setg(errp, "Xen PCI passthrough support not built in"); > } > } > + > +void xen_igd_reserve_slot(PCIBus *pci_bus) > +{ > +} > -- > 2.39.0 From xen-devel-bounces@lists.xenproject.org Mon Jan 09 23:08:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 23:08:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474080.735000 (Exim 4.92) (envelope-from ) id 1pF1Fu-0008Eu-4v; Mon, 09 Jan 2023 23:08:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474080.735000; Mon, 09 Jan 2023 23:08:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF1Fu-0008En-1S; Mon, 09 Jan 2023 23:08:38 +0000 Received: by outflank-mailman (input) for mailman id 474080; Mon, 09 Jan 2023 23:08:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF1Fs-0008EZ-Aa for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 23:08:36 +0000 Received: from sonic313-20.consmr.mail.gq1.yahoo.com (sonic313-20.consmr.mail.gq1.yahoo.com [98.137.65.83]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 897301bb-9072-11ed-91b6-6bf2151ebd3b; Tue, 10 Jan 2023 00:08:34 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.gq1.yahoo.com with HTTP; Mon, 9 Jan 2023 23:08:31 +0000 Received: by hermes--production-ne1-7b69748c4d-bgkrh (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 21a3ec8339abfccbadeaea4f5ef812e7; Mon, 09 Jan 2023 23:08:29 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 897301bb-9072-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1673305711; bh=PUsS/L6kSgEs9TSDYOSdibVZnoomFtUQ/2FTOn4ShZk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From:Subject:Reply-To; b=elXzfvBDLs+x3PQygRw4UOuVqtKHJNztSmeANXFZPKbkjXODD9HVpM6UngsfZNCsUNy2JDgYBHu+ln6Crtg2AcIwICBkBig4MOQJgkIIALddShN1H8ppOWXhxpZFtNqAuktS00wFZqfg6lJ6O7PfrQUbnQy0ZmqYChoK6Pm/JDcuDg8YuX85J6rdPWZxmc4dFbvcBTZ8lNd98XtbK9IBE9yBkNvF1HtzZ7S1SL46zDEXLUHwWJPNfgXiTkS5gbbxVINtGupzdxS50bsCoBeI//O5rV9YHJX+IKfI4jk4NELWBvL+SQWSxj+i/SA3aO3s1dV/gFfSo1b5xBUMVvwpEg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1673305711; bh=Du1eQd5e3lE/n5cyxqbZF1SqsJq9/TIrud4RmL1t+rv=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=EqV1L9DzWBpmfjNT6DFmkvoslb9Tg0hh8943F8fvkbDYhCgCHBpJqoQVumBZeY08ibePhnHlkXpveZRSrdMUqytQo4u9kfYqyZ4+ckXTdRhBMZv7gbcYA4SVCYJzBsWUZrnkJqGHd6LaUdQljLqlh2ca1JDIcwOebu/Q4QCMXuclPnkF3S/gfpmaGRd47J7SkG26zqaQs1o0fFU4LOtcyjB+qFZU4ihv2pYSF+teGpMfou11wxdiAS3urJWtN5XJDa2ihQFKWPTaP7N/OnZLYjGVSxtdtH1+jBssGCcUyUE5/mA2qT3gnDHnEU2swYrLfP09hCiITR5uyu9QWabHzw== X-YMail-OSG: PJkcDlwVM1lwBDfcA1m84Ixzd3yJi0Uf9wXfCxi14xWsP7d2Dz_7xD4xwfXISN0 S4FRMFHbwmhIgyW8dmdIzZoWOsKWjLgoF26iGIv8uIDAfyJvT1rFijVrMyqxzUy5akZQJUkz9Fw0 HCaX84s2BoEsxvktlpclY_yQ5h0JUyqRm4UCim69OvADBtF69i8Ab8cUEg6JUDTA6QqU_3JyEMWB Zs3v48oGLjN72Ais3RueIiHIVLjJZ3LYIE6Ekv_jUimru4MItuEzesvjXWCtFnHBTHS8QnXCa2Mt 6MyniOP7xTFs6nrXWMdJBSOHjYKIIYlYI4iLRR7NwXDKQRq1MSLfDazgHluwHu1B.XrcdZTg6kbW nUVvV7KmS43Ut6hhA_pdqxx7O7HVOZU_8.On6FPb.sA4OpM1YPV.8LNMmvGKIIv25KGoPBTjOCw0 Hhf5aAFSYxXr2.dLa6Ibdl5tCW4IRpnl.Wr_Uj69kG561wt_ZpuvMgwx.t4iz5kj9w8nY8lMB_sh 7ehNLAskNXHSfN7.vbPVIP4Nf6P6xvoBHUkyY8RrmWOm8uZz0IXmTm5dk37fE.M8RMreIizdqhYA 8wmnK.xMHeuQqWTp6fySym01Oi95JDpuRyGzB5sUVkV7CbFj.B_0oIkQuvyyvu714Gps1rPQ8ghE _Jp4XciK2Yd9LAkcBG2us9uscEWVU.dnKOnOIovxJjy.2RE4M5qKGqJY_owlS5Aov8Qn9gS2H_Gc 6sMfwa1K0P_uIS00zid89Vz8EkSL_Pz9z84DQkGGaTxHIXTAWgdP10mprFJEedPpJK1klo4_ZOpq 152jGan8ZavdZkAlnUSh8OcsU32EWsJZ3giSDVzIR9doWzfk1WG4Ds7poOWoYmYSwWPWqquP1p0u 235z7EbNoLQNSoWKkcc9F1sbc9NwrQ9y.Z2Fl.FNKLi0tvy7gv70wEO10DBnxi5FIGjxFOVlwYuj U4m0kPQ5xMyxWJyIOk.SyXGqQZykyPO05HpBCe2qefOU.PC7hWAYIHUPesan24nndXEPjHrq7OSh 5xq6bsijRSCjG3kUkBKvBrRwJslhnVQihmIO8Pf4M69MbR8qWYF0Oo6_v3SQdRym6nXSne0vcekx xn0DQFqdBWWNp1qY2zq5hJR33nq88w.xlyLsGeo95aw5Zmybm_BjKH8PF7kpbPcGP7LKEgJ44EZq vK06TfWuqMhOFc5C9vVQNgWF.6C2LP6Fx9ROsICTEwwNvbFedYHHfoUX1Fp_KWk0oWATok7Hi9wt TpCCR1WKnKZiFj.mdJ6V0EFtC7xuhySoRzISE3offXLCjfA3GUAyJz2kwaFi2_Ktx1QBDNqBM4OY LzSh40kEefxWiQKIeWgtJEIwlHHRtFVd3OQN8CAsKQNqzKrUo6iXweRhLtebWryw9SW72ZMDIZ0x qPQI80yamRENR5vvAbn9jc1ZB.2fT9pVrvkHekVkctLUnykNHZIK5zRzqn5t3KesTAAbagjFvGAj .sVXeSTT1p1CWJ_EaVxHi76Vu5.5SuD.QCMOHnZKhzYydG0QVA8hTMSzAv8.FrVFubj1zAsvzhc4 Wv7evMcbCTkZVnQIKLUvfFiWUYcTATWbTYB72kTqwuiag34m9DTdF3TGv3usYpNCufF8L.PSXZbu YG7onspgwGcxqrBYJ72t_xZ07YyzgZX2ao1yl1U.dcUkbbHYPdtr.ThkapBpFfuTLoxxfqU70ug2 cHmSgF9Ftgxb8tXIQsWjGJFt8F5pZJukq8h3ymGMywD35Ga1SFcxNLjwDmuZufEXJfsm4qlF_8gy FMZTnw80uNNLhAKM0XqaZpO2LuFC5JicviG0wilgsRH9kepIKWlwy3JqfUJtk2Ppsvqei0yumIhk ixUKrFiSOAEDyutmFkY6_VHIDLSoiC6CWmwyB5cYSPLLeL0oPpg0JBiU8lEi.PTkvvrndoMMkcNT FKNq3xtVB9mbkLGjx8sAacZ2EKKgW7CWr00ZiKJ4i1HAr07bBOr3_XHixAPdjvatOjV2v7gZx0Ck aZFUySehhNN1lNz5X8EswtAZFZq5T2lH9HLQ2S4i75t4Q2cNs7ODtY.g3jKIMDhqLn4A9_yKNiGJ XMeJayOJhqZPcG5XrpWz4z9UXG58tS9o_Ya_Dtfa.34.FheRV02vFB6U5PxAmgzQDh8uiUwNSxag oaut6Sy1dy9cuOPNcK6SsGMswTpB5v9zuBBiHSObxx9i.GtyqTuPLrMU5Jvv4un9CeKPy X-Sonic-MF: From: Chuck Zmudzinski To: anthony.perard@citrix.com Cc: xen-devel@lists.xenproject.org, Wei Liu , Juergen Gross , qemu-devel@nongnu.org Subject: [XEN PATCH 1/3] libxl/dm: Use "pc" machine type for Intel IGD passthrough Date: Mon, 9 Jan 2023 18:08:11 -0500 Message-Id: X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Length: 4647 The default qemu upstream "xenfv" machine type that is used when an HVM guest is configured for Intel IGD passthrough assigns slot 2 to the xen platform pci device. It is a requirement that slot 2 be assigned to the Intel IGD when it is passed through as the primary graphics adapter. Using the "pc" machine type instead of the "xenfv" machine type in that case makes it possible for qemu upstream to assign slot 2 to the IGD. Using the qemu "pc" machine and adding the xen platform device on the qemu command line instead of using the qemu "xenfv" machine which automatically adds the xen platform device earlier in the guest creation process does come with some degredation of startup performance: startup is slower and some vga drivers in use during early boot are unable to display the screen at the native resolution of the monitor, but once the guest operating system (Windows or Linux) is fully loaded, there is no noticeable difference in the performance of the guest when using the "pc" machine type instead of the "xenfv" machine type. With this patch, libxl continues to use default "xenfv" machine type with the default settings of xen_platform_pci enabled and igd gfx_passthru disabled. The patch only affects machines configured with gfx_passthru enabled. Signed-off-by: Chuck Zmudzinski --- Reviewers might find this patch easier to review by looking at the resulting code in the patched file instead of looking at the diff because it is hard to follow the logical flow of the resulting code in the diff because the patch moves the check for igd gfx_passthru before the check for disabling the xen platform device. That change was made because it results in a more simplified logical flow in the resulting code. tools/libs/light/libxl_dm.c | 37 ++++++++++++++++++++----------------- 1 file changed, 20 insertions(+), 17 deletions(-) diff --git a/tools/libs/light/libxl_dm.c b/tools/libs/light/libxl_dm.c index fc264a3a13..2048815611 100644 --- a/tools/libs/light/libxl_dm.c +++ b/tools/libs/light/libxl_dm.c @@ -1809,7 +1809,26 @@ static int libxl__build_device_model_args_new(libxl__gc *gc, flexarray_append(dm_args, b_info->extra_pv[i]); break; case LIBXL_DOMAIN_TYPE_HVM: - if (!libxl_defbool_val(b_info->u.hvm.xen_platform_pci)) { + if (libxl_defbool_val(b_info->u.hvm.gfx_passthru)) { + enum libxl_gfx_passthru_kind gfx_passthru_kind = + libxl__detect_gfx_passthru_kind(gc, guest_config); + switch (gfx_passthru_kind) { + case LIBXL_GFX_PASSTHRU_KIND_IGD: + /* + * Using the machine "pc" because with the default machine "xenfv" + * the xen-platform device will be assigned to slot 2, but with + * GFX_PASSTHRU_KIND_IGD, slot 2 needs to be reserved for the Intel IGD. + */ + machinearg = libxl__strdup(gc, "pc,accel=xen,suppress-vmdesc=on,igd-passthru=on"); + break; + case LIBXL_GFX_PASSTHRU_KIND_DEFAULT: + LOGD(ERROR, guest_domid, "unable to detect required gfx_passthru_kind"); + return ERROR_FAIL; + default: + LOGD(ERROR, guest_domid, "invalid value for gfx_passthru_kind"); + return ERROR_INVAL; + } + } else if (!libxl_defbool_val(b_info->u.hvm.xen_platform_pci)) { /* Switching here to the machine "pc" which does not add * the xen-platform device instead of the default "xenfv" machine. */ @@ -1831,22 +1850,6 @@ static int libxl__build_device_model_args_new(libxl__gc *gc, } } - if (libxl_defbool_val(b_info->u.hvm.gfx_passthru)) { - enum libxl_gfx_passthru_kind gfx_passthru_kind = - libxl__detect_gfx_passthru_kind(gc, guest_config); - switch (gfx_passthru_kind) { - case LIBXL_GFX_PASSTHRU_KIND_IGD: - machinearg = GCSPRINTF("%s,igd-passthru=on", machinearg); - break; - case LIBXL_GFX_PASSTHRU_KIND_DEFAULT: - LOGD(ERROR, guest_domid, "unable to detect required gfx_passthru_kind"); - return ERROR_FAIL; - default: - LOGD(ERROR, guest_domid, "invalid value for gfx_passthru_kind"); - return ERROR_INVAL; - } - } - flexarray_append(dm_args, machinearg); for (i = 0; b_info->extra_hvm && b_info->extra_hvm[i] != NULL; i++) flexarray_append(dm_args, b_info->extra_hvm[i]); -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Mon Jan 09 23:08:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 23:08:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474081.735006 (Exim 4.92) (envelope-from ) id 1pF1Fu-0008IQ-Gt; Mon, 09 Jan 2023 23:08:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474081.735006; Mon, 09 Jan 2023 23:08:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF1Fu-0008I1-AN; Mon, 09 Jan 2023 23:08:38 +0000 Received: by outflank-mailman (input) for mailman id 474081; Mon, 09 Jan 2023 23:08:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF1Ft-0008EZ-2c for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 23:08:37 +0000 Received: from sonic314-20.consmr.mail.gq1.yahoo.com (sonic314-20.consmr.mail.gq1.yahoo.com [98.137.69.83]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 88dcb11c-9072-11ed-91b6-6bf2151ebd3b; Tue, 10 Jan 2023 00:08:34 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.gq1.yahoo.com with HTTP; Mon, 9 Jan 2023 23:08:30 +0000 Received: by hermes--production-ne1-7b69748c4d-bgkrh (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 21a3ec8339abfccbadeaea4f5ef812e7; Mon, 09 Jan 2023 23:08:28 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 88dcb11c-9072-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1673305710; bh=H7TDF5iwsM6S2zN42hlPdvBls2tMhLzS10FXdEhr034=; h=From:To:Cc:Subject:Date:References:From:Subject:Reply-To; b=WyvKkHyI9WmtiUVWL7RhhUB2bUuuMOWtxhbuujprdUVNbGvFlmrbWeQzZtBVFRXQgzXd6YnHv2TQS2sBLkRMwIgDa5aqK9SvPrToX4Y/17QGKsWYCSxkt0OayOddFM1WABQUulp7lITjKI4gkwjR7nOSBzwba+7aDqNLtAdjgSs5z/A8iZ49bCblGt1VtS4X2uZQlAkW32/oIhW9JTQcaNpYKJLxJkKkeKg56uwCLNkgUd8poCFD8cuQgr6nvgkzMRMW8Q8mKelbtkN9JSaD/XnBt5U0pLPQFK+W5d0dPDriK7c6AYbSs42yCWMAlqzdioTBUl3yZhdHpjO1g+6MQw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1673305710; bh=PrWJ3S59N3HCaCyYCnpa2+rJpwHbO8m3Bitt+4YB6Pl=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=fqOl1PKOUnvafKXce0G+T+Z4srjLJB9XxRyHnUQ8MGKq2fMTtlJXVK0YJ1vdp1lizY5OKQYfenBVE4QrbjmJRKdxe+GB/DEloJKCfLtlNCJCfS8wYZRZVffSNqWQFz2M+cvlzVMAhbdnGVarD8ejTY1oRd829SubqXoo9z3mfbD2WkHgUwoU+otrn3GcgFYXgsQp0Biw2jld9+O1ok//129gr4jAB0IYMRW0JPzupP1qTCV23XrnBNk6pOb1ybmV9I0jMgOhnnFPoUmcb5fsf4DlFeZzcfV3eGnFPsormfBeH2R9KoTMOvO8hbz4FDS0AP+kmqFRVLSbt7EyAR386A== X-YMail-OSG: mLmWokQVM1nd4ulBj7SEMVyO0AKJcP1LGJB6Lv13bPdjONFUJyA758Q9z_tDvsH EaDw22J.X0QvmLKE_mEjNj7qxrjMsyecS4dHtX887JN2s.F67n2v6gtN5hfAonv9_Hh_FFvgp8oQ jS3_wxawPyqqes6WtJD_LEyj5cp062RlelUHhwDNAOfvO0wJvAK5gddv1jPCBOp2k3qsnFAwXDJy bIdrF5ZVGqj0EY7zMNO1L217sOJG7C0ce93pPqq8ZN8wmWddaobqSE5to5qU1VPwgmx_whKvc0W0 3OuPoBxEJlmoFWcxmxldRkuZ3iMRN_m_ulxeifYEFWvwRhKYpCW3iKqiN4WUXQiJnD7YSA9lM.w8 wU117bcrPFaefV2usS6GwtsS00yMXb5wXHt36QdZEcEOOIsdyA6w37V4Y6OnhCJTTTn2UP.KCWT9 xUBmMfOQhpY66zDS7ueObfX4zUKYVfiPIiCsb8a1KME0yM9DUn9gN94hLBLudRF7Ff.XJvHqz0Dk 0AIafvTAmrnWG6TGE_YRk_NXBET5Z.1QfHGUMFrb44Ja46mnvG9AGkxF7aR1kI6tqAacEmSv11xi hHYNH.lNLG8zOTHJp3bK5qhcjL2ddwF5TCWJG5.oGI__XD8fY8NH3r5s0nwaVBwzQyO5LG9JJ1vr vNEHIEdpfA7bGrJQmpBBCR0PZc5EPJk8FLtK97R98mloQkpHLj2voIX3X.mzIuq1_SbTELlFWq5_ yOlnlGPtsQ.NZFnp7GgM1eT0Ctzu9_o6gnZXThutfUlIjFSWGyqrUTblPwnkkj_RgKZJFNJlfS5x ooB6jC_rl_jqPAoyQfGwXGe8vVXoqfcDi0KY59SPa3fMKM47UcYKFcP2kyYAwfEk7wO6iAVXESht 66ZEJ3QwpIpDyb50sKrmeoHq8HRG1mVy0M4Ehrrj_TsSCmr_Dh2TJofZa5BOIWTUr76XoyTxX2E_ o55GdOJzZelXPoA3LwyyPqTCfgMFK_h4PBsP26t5pdqgMTeDZJMqL55_ZAplg1RRXbN5hMK1lE1O oJx1XuMIo6rXqfacFyuL2QRNC1LS.f2tdptbb5MJZAztcv3HAuL6MWktNQE2nw_mOzy0vxBb7x.G 29JDig4Ewv.chBkitUygFDVDaq9_HlTH9AST8pfIcJvU.covWzj1kj_41bmOKYWodw9mCz3s9h_O 8ki1eEWd7jWlikN2HXovImwVRDKHArsGADRRUp_aN5Zf2wTCvlxFNXkv5clU2Cl1TOhepa7M9ahp s2TUzlijxNCugcBwdjA1Wtm3Rk4MK0aO_AkAEZNRVYQbYcckAv3hcAFCpW3caKDhaj0jtesM38sv Frf9JiWkGaJ8T6OhzIoyOzRZh07qV_7g9V9GDiNk1cQCXsUwg7Tpl0dHoTonAkx13KeeEqRHg9Dm YyhOQY2OdWZqrHBWY3eGvfOcSSeyX8sryJu3SYP57D7xeBfXaXBdFAL3_Wh7nT1sVnTFoYr3.Jhx zWOpuLZaJMoFWglaYK9hj37HxgmUz0.3p3ZYNrVSp.uNHaVFj2EwnYFiOqL0PEOYhWmInLx79iV0 lej49k1a.ZuL3JW.OXeX34kc1bR8JSXDRdetiN2Z4wW3UuMtcfWsHWtCEkNk2S3C2e1hQZeiZU.O w1qQSI8tNFVpm53pRrDaGkcdvvm0FZQzx_VldD43HZ9wryrfhZf7hQwnK0DV.F4bNJqdXClUgKt5 tZfM5wr0LWLxnBiEi2Mw.72n1ts2Osm2nCpApGhndNcsOqX70TITAjq_HATkcUYhboyPyBicquz9 Mg1xNs3r0yTPmLUGqXfewaGWWnk_zP5GGqkl4tUzlMBhpk6YAD8wJRcR0P6RvFaq3vPDCFs9wxWh 6.Ua7Y375zpt39PjJM7Qgf3Wot0DOzjzJtjRjYEQQiIqLtY9GXvBxk_YEYf2kU2C68L46TyipzRb jFmFcx2ftRjxPbwvYGRDtlfI1IQ4nmPzBpddLhnwreQv4Hl3_mehcKQ8NOrDz159BFn8y7dItGt0 EuHt4B5jtFCcih2nxvqMPgrewfuenVk309ZkY3wJ1RTEUzCU7Evb6vi3Lrpx.24Fti30A1bHZkZd MTNfK6XGF22HHvR9aUDEbs0L1pLES8jSkMrULYY4310P0OmJdkSzmvGqqXt3b6cadjxv2Frq7Kso 99hfHXfW9npPnBprkYHbO5HAC5tMc5LtX9SfMUpfFDbU6GKp6pDCeIJxVJyzbpaZbyD0JhRwZwhE X_w-- X-Sonic-MF: From: Chuck Zmudzinski To: anthony.perard@citrix.com Cc: xen-devel@lists.xenproject.org, Wei Liu , Juergen Gross , qemu-devel@nongnu.org Subject: [XEN PATCH 0/3] Configure qemu upstream correctly by default for igd-passthru Date: Mon, 9 Jan 2023 18:08:10 -0500 Message-Id: X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit References: Content-Length: 9696 Sorry for the length of this cover letter but it is helpful to put all the pros and cons of the two different approaches to solving the problem of configuring the Intel IGD with qemu upstream and libxl in one place, which I attempt to do here. Of course the other approach involves a patch to qemu [1] instead of using this patch series for libxl. The quick answer: I think the other patch to qemu is the better option, but I would be OK if you use this patch series instead. Details with my reasons for preferring the other patch to qemu over this patch series to libxl: I call attention to the commit message of the first patch which points out that using the "pc" machine and adding the xen platform device on the qemu upstream command line is not functionally equivalent to using the "xenfv" machine which automatically adds the xen platform device earlier in the guest creation process. As a result, there is a noticeable reduction in the performance of the guest during startup with the "pc" machne type even if the xen platform device is added via the qemu command line options, although eventually both Linux and Windows guests perform equally well once the guest operating system is fully loaded. Specifically, startup time is longer and neither the grub vga drivers nor the windows vga drivers in early startup perform as well when the xen platform device is added via the qemu command line instead of being added immediately after the other emulated i440fx pci devices when the "xenfv" machine type is used. For example, when using the "pc" machine, which adds the xen platform device using a command line option, the Linux guest could not display the grub boot menu at the native resolution of the monitor, but with the "xenfv" machine, the grub menu is displayed at the full 1920x1080 native resolution of the monitor for testing. So improved startup performance is an advantage for the patch for qemu. I also call attention to the last point of the commit message of the second patch and the comments for reviewers section of the second patch. This approach, as opposed to fixing this in qemu upstream, makes maintaining the code in libxl__build_device_model_args_new more difficult and therefore increases the chances of problems caused by coding errors and typos for users of libxl. So that is another advantage of the patch for qemu. OTOH, fixing this in qemu causes newer qemu versions to behave differently than previous versions of qemu, which the qemu community does not like, although they seem OK with the other patch since it only affects qemu "xenfv" machine types, but they do not want the patch to affect toolstacks like libvirt that do not use qemu upstream's autoconfiguration options as much as libxl does, and, of course, libvirt can manage qemu "xenfv" machines so exising "xenfv" guests configured manually by libvirt could be adversely affected by the patch to qemu, but only if those same guests are also configured for igd-passthrough, which is likely a very small number of possibly affected libvirt users of qemu. A year or two ago I tried to configure guests for pci passthrough on xen using libvirt's tool to convert a libxl xl.cfg file to libvirt xml. It could not convert an xl.cfg file with a configuration item pci = [ "PCI_SPEC_STRING", "PCI_SPEC_STRING", ...] for pci passthrough. So it is unlikely there are any users out there using libvirt to configure xen hvm guests for igd passthrough on xen, and those are the only users that could be adversely affected by the simpler patch to qemu to fix this. The only advantage of this patch series over the qemu patch is that this patch series does not need any patches to qemu to make Intel IGD configuration easier with libxl so the risk of affecting other qemu users is entirely eliminated if we use this patch instead of patching qemu. The cost of patching libxl instead of qemu is reduced startup performance compared to what could be achieved by patching qemu instead and an increased risk that the tedious process of manually managing the slot addresses of all the emulated devices will make it more difficult to keep the libxl code free of bugs. I will leave it to the maintainer of the code in both qemu and libxl (Anthony) to decide which, if any, of the patches to apply. I am OK with either this patch series to libxl or the proposed patch to qemu to fix this problem, but I do recommend the other patch to qemu over this patch series because of the improved performance during startup with that patch and the relatively low risk that any libvirt users will be adversely affected by that patch. Brief statement of the problem this patch series solves: Currently only the qemu traditional device model reserves slot 2 for the Intel Integrated Graphics Device (IGD) with default settings. Assigning the Intel IGD to slot 2 is necessary for the device to operate properly when passed through as the primary graphics adapter. The qemu traditional device model takes care of this by reserving slot 2 for the Intel IGD, but the upstream qemu device model currently does not reserve slot 2 for the Intel IGD. This patch series modifies libxl so the upstream qemu device model will also, with default settings, assign slot 2 for the Intel IGD. There are three reasons why it is difficult to configure the guest so the Intel IGD is assigned to slot 2 in the guest using libxl and the upstream device model, so the patch series is logically organized in three separate patches; each patch resolves one of the three reasons that cause problems: The description of what each of the three libxl patches do: 1. With the default "xenfv" machine type, qemu upstream is hard-coded to assign the xen platform device to slot 2. The first patch fixes that by using the "pc" machine instead when gfx_passthru type is igd and, if xen_platform_pci is set in the guest config, libxl now assigns the xen platform device to slot 3, making it possible to assign the IGD to slot 2. The patch only affects guests with the gfx_passthru option enabled. The default behavior (xen_platform_pci is enabled but gfx_passthru option is disabled) of using the "xenfv" machine type is preserved. Another way to describe what the patch does is to say that it adds a second exception to the default choice of the "xenfv" machine type, with the first exception being that the "pc" machine type is also used instead of "xenfv" if the xen platform pci device is disabled in the guest xl.cfg file. 2. Currently, with libxl and qemu upstream, most emulated pci devices are by default automatically assigned a pci slot, and the emulated ones are assigned before the passed through ones, which means that even if libxl is patched so the xen platform device will not be assigned to slot 2, any other emulated device will be assigned slot 2 unless libxl explicitly assigns the slot address of each emulated pci device in such a way that the IGD will be assigned slot 2. The second patch fixes this by hard coding the slot assignment for the emulated devices instead of deferring to qemu upstream's auto-assignment which does not do what is necessary to configure the Intel IGD correctly. With the second patch applied, it is possible to configure the Intel IGD correctly by using the @VSLOT parameter in xl.cfg to specify the slot address of each passed through pci device in the guest. The second patch is also designed to not change the default behavior of letting qemu autoconfigure the pci slot addresses when igd gfx_pasthru is disabled in xl.cfg. 3. For convenience, the third patch automatically assigns slot 2 to the Intel IGD when the gfx_passthru type is igd so with the third patch appled it is not necessary to set the @VSLOT parameter to configure the Intel IGD correctly. Testing: I tested a system with Intel IGD passthrough and two other pci devices passed through, with and without the xen platform device. I also did tests on guests without any pci passthrough configured. In all cases tested, libxl behaved as expected. For example, the device model arguments are only changed if gfx_passthru is set for the IGD, libxl respected administrator settings such as @VSLOT and xen_platform_pci with the patch series applied, and not adding the xen platform device to the guest caused reduced performance because in that case the guest could not take advantage of the improvements offered by the Xen PV drivers in the guest. I tested the following emulated devices on my setup: xen-platform, e1000, and VGA. I also verified the device that is added by the "hdtype = 'ahci'" xl.cfg option is configured correctly with the patch applied. I did not test all 12 devices that could be affected by patch 2 of the series. These include the intel-hda high definition audio device, a virtio-serial, device, etc. Once can look at the second patch for the full list of qemu emulated devices whose behavior is affected by the second patch of the series when the guest is configured for igd gfx_passthru. These devices are also subject to mistakes in the patch not discovered by the compiler, as mentioned in the comments for reviewers section of the second patch. [1] https://lore.kernel.org/qemu-devel/8349506149de6d81b0762f17623552c248439e93.1673297742.git.brchuckz@aol.com/ Chuck Zmudzinski (3): libxl/dm: Use "pc" machine type for Intel IGD passthrough libxl/dm: Manage pci slot assignment for Intel IGD passthrough libxl/dm: Assign slot 2 by default for Intel IGD passthrough tools/libs/light/libxl_dm.c | 227 +++++++++++++++++++++++++++++------- 1 file changed, 183 insertions(+), 44 deletions(-) -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Mon Jan 09 23:08:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 23:08:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474082.735022 (Exim 4.92) (envelope-from ) id 1pF1Fx-0000KR-U2; Mon, 09 Jan 2023 23:08:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474082.735022; Mon, 09 Jan 2023 23:08:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF1Fx-0000KE-P5; Mon, 09 Jan 2023 23:08:41 +0000 Received: by outflank-mailman (input) for mailman id 474082; Mon, 09 Jan 2023 23:08:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF1Fx-0000Gp-3m for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 23:08:41 +0000 Received: from sonic315-55.consmr.mail.gq1.yahoo.com (sonic315-55.consmr.mail.gq1.yahoo.com [98.137.65.31]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8b4624a4-9072-11ed-b8d0-410ff93cb8f0; Tue, 10 Jan 2023 00:08:37 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic315.consmr.mail.gq1.yahoo.com with HTTP; Mon, 9 Jan 2023 23:08:34 +0000 Received: by hermes--production-ne1-7b69748c4d-bgkrh (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 21a3ec8339abfccbadeaea4f5ef812e7; Mon, 09 Jan 2023 23:08:30 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8b4624a4-9072-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1673305714; bh=6KQQVKXjX5bPI5/yTS20Ov1Ty8T7qISVmf3UrSeOprM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From:Subject:Reply-To; b=PEM0aNGEXQPaqvoOKMU9QyD96JQr5zHZqkD3XdTeUDsr8UOaeO2eUCcfQC8eUzj6YvlHwhREB8BQeTAA/fQhhnLV0bKpwkosy3XaDR0++D6Wq93pLvBsp+lRLNsFhCuWe3S83y3GIsiZEoApYIhP38XFQgkU+V+71RWck/3sk4kRGGMqtlH6sKiY363PxXu0Pp6blaUbHk86dzsEIsJFAniHkUC4t6o9EUP0FenDRBc96qq8e1/py4lFl3kNKV8Uqbxi+kTSq/tFpbRpA7+M1GnZe1jb8gvYAevKFVGgBhSszHjhIDGF8HSfj4sU+V0J9DwCKKpmQ016z3jZHkau7Q== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1673305714; bh=TWHL1z/CiE8ohTN0zQTQknjD74chjKnA+HPUBhabmew=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=I437GwK+vEuJyjpv7CsRTSm8h0S7JdolI9aSALXd3nUkdhdF0+9Rw+S3/c17bfn02+Y5ASvsOvQtH3sCGgDN5YQui32Fwk2uF4YB7bwAHB5oBhaYbLqJSIIWY+tf527R72vhgT8WtiEXzgFI/fBkgXYzw7oQtnd6Ol627Da5KIO5w23DDfeK6CIGwR1BWaFCoRVXVV/6MZjS+vVeyk9rYAAcDUKK1iWBX2HbRAFODD0C3RbeKWslcXDmab4ENB9jJ3WKua2B4tKlT9787hAHNbi3rANRTgSvQ+DU7jxNLxMtocnfpavdKqWTUA+PNkNwUZZMttoQXtgD9tHKNa8sqg== X-YMail-OSG: TbIfoPMVM1nDGed1NwkTCQurEHl4PZPKruQylL5Hfy_lsaQ34xXGdbcXGGcz8am 8KJ3zw1NlRjxXHSr1eJ2CCCcc8cQXw9nuJOxp.Y4tDdG9CilO4rrYXGde8Dfq1reHiJI_i.yqRCx XH6.YOOuxme2R5T.xbG0cSV.Tumu_kxNn9.WFFwc.TSc.29n0butPjuBbKl3.txxAnvr4sDB62h2 3C7eLySTsMLflK5qUt.kXrUVnHscxQP5tuInMo3Va6QDqqaL6I2O9pP8kZmLQg8NHETXfDmfNsyE NoMlZ2bInDyLN83vRWmC.fjInk6BU6f7eIsBe0OimYgnJEDZr8rv8VSTdi4rZspZNKQ9pX8P7Vjd d26N6Eoq4q_SvEgRukC4zGKG3w4.0pwgDOGAm73WrglGtDStfxu1jIH.G0zlp.IK_6JT6d6ScOxA qBCDD2crReqSBoNN_TzI6kWyaOdFEzEsMb.8gSrdmllucEwAIQ.fPLAgG262ujb6dOR84CwPygqX XjGFubEyFEWcmqiCADQ1FNwfWatojDAkTExNRDXdUxzb.Xlxnd_sXWRaukLy9MFuKN5SeKlGta85 KsHUJtjeC6azaYF2f0UpwaQCgunfxGsKdWgIeSTfBOp0mv.laMaeWZIpyrHsKJMbMzRdmAZDPkK6 tetP.YQw0kFRdANd_dr.._hfKRwQNDMvcA9QpL6Fs2elpdZb5iOLD7yZKa2rGIjhUwdLP.ctmqXB pIVDGknG5jbjwWtkJ9eHu5vImPnyYrRosnL.bv6KYZ10UbhQvOis2r14LSOmYG9QGg8crk4DCX0J YpU6RQlIDSb9rYQfrZ1.47Al3y7xSUPJjGZNxBdwF6NvpbbxM_v3N8ke2r_HEDuLqw9xxbmV3bfk Lj1N7rit_LaGiBkEJ.fVR5leLuFP.3bhp35g3PErXf_3ZkQcsu3mMjHbr0JXPCuOIkc4rhha4yBj 08LJUWfGhkWbtunQ6sEroWoB6QksKPI9ONH6y7e9btZE0dkzcXylmSFec8Y22Rm0d.kM0aJzd0yH wpyq.aNkTmKVyu394N17gULzDAHnO23jRsss6c5BN6AVZyrnxnYn._HJItmMaW5BrOSiebL4mlFa rs4zckGkbgNP8tfoc1ox6fSKVqB3ss9r8aW4OpXTgviIfLtQOda85apY02DCIq_lgukBHdNocZKC WM2fw8XlHdgm.vOTjHZGqmXbOPL27Mdw7HdyxGRHZMHIDpSRFhrH8JuFdJ_L.nc8kIFaBponEOAV OLbC_jieWUmMdKXlWv7j1bJnl84nPcawtY6T4ajxMdnBOtEy6QfBF.dNM1mHTeZdKm4xUtevFTec ntLNdcVkRs1SFJH6S5KjAiIFQbgSUSdSJ14FN2H9PyeYUGgHTddjB6pQ27KfnR5z1gupN8WN.esE UCY098ePhnithkcajn.c_tABPP4HIe_jNXZXH0PDLDEEVeQS95xIsEPIzyxfYizHF56kuq60KYe4 h9WcjhSXPLtidm_fyK0dbdKhiimScIsrirgxSy6WZ8sHYFJ0IX1SsjYiMeq7lox.lNEk8CREHM92 bgcOG88uyw.KsK2cFD.lj0TFlfG2Rpb2s0UJwrco7Nnpr.lCpn.ByvGSr.C6HVRCT530cLhI_vUs EqdwmNCasN.zcYmqUVH4LD7_zM07vZju7CkxHfP__3pWP.Q8bcX4oRWUgTxlZOQuK5e9iVzPElLO bzTHZzlbLc.0v7dX5dV95Zba9M395Yo0HdgyKGR7NUnF1VGd7Y0qFlC5tJ7ei5c_vkq6fGvP6E04 s2b7n7IgIMZgq_WJ2_kFQ1i5t7tmpqNjOsqn5.yQz3KL1d555sYEuku.aqF1sbBwDQNF9M.Tfjkw UsW1h6xASufEA_XmYbd4eQuRz3UJF551d.qvx.DiWZyXxP39hJhXnk_IGsArpAsI2MGxd_CngflA o8b4LEfjVUjev696HkHyZD0UG_Ydm.58C8_5km2VzkCOdKQM8Ula61X.ld84oFv83N3Gxcf82MXW mN0lwv9_y8DoWZoL6Kq5AtcAEjx5CNQRD2vz2GFNd8D5XgsxqZrV3JaR0B6RAG84OKk1v4.6FVvT EDyCdVXuhrqTy7RWME1YAyMfWQHxrhOqZ4dpxw7uTBG367fnglB1.JdIKvdS6C9EC3wXmBolmi1y XEwACp5xf8ktCagD_XZauILSdQ7gL46G_f2W3EDrW9EcleRLg083XsJAc6sxAYSNMy5yKEanA3rc - X-Sonic-MF: From: Chuck Zmudzinski To: anthony.perard@citrix.com Cc: xen-devel@lists.xenproject.org, Wei Liu , Juergen Gross , qemu-devel@nongnu.org Subject: [XEN PATCH 2/3] libxl/dm: Manage pci slot assignment for Intel IGD passthrough Date: Mon, 9 Jan 2023 18:08:12 -0500 Message-Id: <76d06f5d01e01df316230def4f31037695f11c1a.1673300848.git.brchuckz@aol.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Length: 15129 By default, except for the ich9-usb-uhci device which libxl assigns to slot 29 (0xid), libxl defers to qemu upstream's automatic slot assignment process, which is simply to assign each emulated device to the next available slot on the pci bus. With this default behavior, libxl and qemu will not configure the Intel IGD correctly. Specifically, the Intel IGD must be assigned to slot 2, but the current default behavior is to assign one of the emulated devices to slot 2. With this patch libxl uses qemu command line options to specify the slot address of each pci device in the guest when gfx_passthru is enabled for the Intel IGD. It uses the same simple algorithm of assigning the next available slot, except that it starts with slot 3 instead of slot 2 for the emulated devices. This process of slot assignment aims to simulate the behavior of existing machines as much as possible. The default behavior (when igd gfx_passthru is disabled) of letting qemu manage the slot addresses of emulated pci devices is preserved. The patch also preserves the special treatment for the ich9 usb2 controller (ich9-usb-ehci1) that libxl currently assigns to slot.function 29.7 and the associated ich9-usb-uhciN devices to slot 29 (0x1d). For future maintainance of this code, it is important that pci devices that are managed by the libxl__build_device_model_args_new function follow the logic of this patch and use the new local counter next_slot to assign the slot address instead of letting upstream qemu assign the slot if the guest is configured for Intel IGD passthrough, and preserve the current behavior of letting qemu assign the slot address otherwise. Signed-off-by: Chuck Zmudzinski --- The diff of this patch is easier to review if it is generated using the -b (aka --ignore-space-change) option of diff/git-diff to filter out some of the changes that are only due to white space. This patch is difficult to verify for correctness without testing all the devices that could be added by the libxl__build_device_model_args_new function. There are 12 places where the addr=%x option needed to be added to the arguments of the "-device" qemu option that adds an emulated pci device which corresponds to at least 12 different devices that could be affected by this patch if the patch contains mistakes that the compiler did not notice. One mistake the compiler would not notice is a missing next_slot++; statement that would result in qemu trying to assign a device to a slot that is already assigned, which is an error in qemu. I did enough tests to find some mistakes in the patch which of course I fixed before submitting the patch. So I cannot guarantee that there are not any other mistakes in the patch because I don't have the resources to do the necessary testing of the many possible configurations that could be affected by this patch. tools/libs/light/libxl_dm.c | 168 ++++++++++++++++++++++++++++++------ 1 file changed, 141 insertions(+), 27 deletions(-) diff --git a/tools/libs/light/libxl_dm.c b/tools/libs/light/libxl_dm.c index 2048815611..2720b5d4d0 100644 --- a/tools/libs/light/libxl_dm.c +++ b/tools/libs/light/libxl_dm.c @@ -1205,6 +1205,20 @@ static int libxl__build_device_model_args_new(libxl__gc *gc, const char *path, *chardev; bool is_stubdom = libxl_defbool_val(b_info->device_model_stubdomain); int rc; + int next_slot; + bool configure_pci_for_igd = false; + /* + * next_slot is only used when we need to configure the pci + * slots for the Intel IGD. Slot 2 will be for the Intel IGD. + */ + next_slot = 3; + if (libxl_defbool_val(b_info->u.hvm.gfx_passthru)) { + enum libxl_gfx_passthru_kind gfx_passthru_kind = + libxl__detect_gfx_passthru_kind(gc, guest_config); + if (gfx_passthru_kind == LIBXL_GFX_PASSTHRU_KIND_IGD) { + configure_pci_for_igd = true; + } + } dm_args = flexarray_make(gc, 16, 1); dm_envs = flexarray_make(gc, 16, 1); @@ -1372,6 +1386,20 @@ static int libxl__build_device_model_args_new(libxl__gc *gc, if (b_info->cmdline) flexarray_vappend(dm_args, "-append", b_info->cmdline, NULL); + /* + * When the Intel IGD is configured for primary graphics + * passthrough, we need to manually add the xen platform + * device because the QEMU machine type is "pc". Add it first to + * simulate the behavior of the "xenfv" QEMU machine type which + * always adds the xen platform device first. But in this case it + * will be at slot 3 because we are reserving slot 2 for the IGD. + */ + if (configure_pci_for_igd && + libxl_defbool_val(b_info->u.hvm.xen_platform_pci)) { + flexarray_append_pair(dm_args, "-device", + GCSPRINTF("xen-platform,addr=%x", next_slot)); + next_slot++; + } /* Find out early if one of the disk is on the scsi bus and add a scsi * controller. This is done ahead to keep the same behavior as previous @@ -1381,7 +1409,14 @@ static int libxl__build_device_model_args_new(libxl__gc *gc, continue; } if (strncmp(disks[i].vdev, "sd", 2) == 0) { - flexarray_vappend(dm_args, "-device", "lsi53c895a", NULL); + if (configure_pci_for_igd) { + flexarray_vappend(dm_args, "-device", + GCSPRINTF("lsi53c895a,addr=%x", next_slot), NULL); + next_slot++; + } else { + flexarray_vappend(dm_args, "-device", "lsi53c895a", + NULL); + } break; } } @@ -1436,31 +1471,67 @@ static int libxl__build_device_model_args_new(libxl__gc *gc, flexarray_append(dm_args, "-spice"); flexarray_append(dm_args, spiceoptions); if (libxl_defbool_val(b_info->u.hvm.spice.vdagent)) { - flexarray_vappend(dm_args, "-device", "virtio-serial", - "-chardev", "spicevmc,id=vdagent,name=vdagent", "-device", - "virtserialport,chardev=vdagent,name=com.redhat.spice.0", - NULL); + if (configure_pci_for_igd) { + flexarray_vappend(dm_args, "-device", + GCSPRINTF("virtio-serial,addr=%x", next_slot), + "-chardev", "spicevmc,id=vdagent,name=vdagent", + "-device", + "virtserialport,chardev=vdagent,name=com.redhat.spice.0", + NULL); + next_slot++; + } else { + flexarray_vappend(dm_args, "-device", "virtio-serial", + "-chardev", "spicevmc,id=vdagent,name=vdagent", + "-device", + "virtserialport,chardev=vdagent,name=com.redhat.spice.0", + NULL); + } } } switch (b_info->u.hvm.vga.kind) { case LIBXL_VGA_INTERFACE_TYPE_STD: - flexarray_append_pair(dm_args, "-device", - GCSPRINTF("VGA,vgamem_mb=%d", - libxl__sizekb_to_mb(b_info->video_memkb))); + if (configure_pci_for_igd) { + flexarray_append_pair(dm_args, "-device", + GCSPRINTF("VGA,addr=%x,vgamem_mb=%d", next_slot, + libxl__sizekb_to_mb(b_info->video_memkb))); + next_slot++; + } else { + flexarray_append_pair(dm_args, "-device", + GCSPRINTF("VGA,vgamem_mb=%d", + libxl__sizekb_to_mb(b_info->video_memkb))); + } break; case LIBXL_VGA_INTERFACE_TYPE_CIRRUS: - flexarray_append_pair(dm_args, "-device", - GCSPRINTF("cirrus-vga,vgamem_mb=%d", - libxl__sizekb_to_mb(b_info->video_memkb))); + if (configure_pci_for_igd) { + flexarray_append_pair(dm_args, "-device", + GCSPRINTF("cirrus-vga,addr=%x,vgamem_mb=%d", next_slot, + libxl__sizekb_to_mb(b_info->video_memkb))); + next_slot++; + } else { + flexarray_append_pair(dm_args, "-device", + GCSPRINTF("cirrus-vga,vgamem_mb=%d", + libxl__sizekb_to_mb(b_info->video_memkb))); + } break; case LIBXL_VGA_INTERFACE_TYPE_NONE: break; case LIBXL_VGA_INTERFACE_TYPE_QXL: /* QXL have 2 ram regions, ram and vram */ - flexarray_append_pair(dm_args, "-device", - GCSPRINTF("qxl-vga,vram_size_mb=%"PRIu64",ram_size_mb=%"PRIu64, - (b_info->video_memkb/2/1024), (b_info->video_memkb/2/1024) ) ); + if (configure_pci_for_igd) { + flexarray_append_pair(dm_args, "-device", + GCSPRINTF("qxl-vga,addr=%x,vram_size_mb=%"PRIu64 + ",ram_size_mb=%"PRIu64, next_slot, + (b_info->video_memkb/2/1024), + (b_info->video_memkb/2/1024) ) ); + next_slot++; + } else { + flexarray_append_pair(dm_args, "-device", + GCSPRINTF("qxl-vga,vram_size_mb=%"PRIu64 + ",ram_size_mb=%"PRIu64, + (b_info->video_memkb/2/1024), + (b_info->video_memkb/2/1024) ) ); + } break; default: LOGD(ERROR, guest_domid, "Invalid emulated video card specified"); @@ -1496,8 +1567,15 @@ static int libxl__build_device_model_args_new(libxl__gc *gc, } else if (b_info->u.hvm.usbversion) { switch (b_info->u.hvm.usbversion) { case 1: - flexarray_vappend(dm_args, - "-device", "piix3-usb-uhci,id=usb", NULL); + if (configure_pci_for_igd) { + flexarray_vappend(dm_args, "-device", + GCSPRINTF("piix3-usb-uhci,addr=%x,id=usb", + next_slot), NULL); + next_slot++; + } else { + flexarray_vappend(dm_args, + "-device", "piix3-usb-uhci,id=usb", NULL); + } break; case 2: flexarray_append_pair(dm_args, "-device", @@ -1509,8 +1587,15 @@ static int libxl__build_device_model_args_new(libxl__gc *gc, i, 2*(i-1), i-1)); break; case 3: - flexarray_vappend(dm_args, - "-device", "nec-usb-xhci,id=usb", NULL); + if (configure_pci_for_igd) { + flexarray_vappend(dm_args, "-device", + GCSPRINTF("nec-usb-xhci,addr=%x,id=usb", + next_slot), NULL); + next_slot++; + } else { + flexarray_vappend(dm_args, + "-device", "nec-usb-xhci,id=usb", NULL); + } break; default: LOGD(ERROR, guest_domid, "usbversion parameter is invalid, " @@ -1542,8 +1627,15 @@ static int libxl__build_device_model_args_new(libxl__gc *gc, switch (soundhw) { case LIBXL__QEMU_SOUNDHW_HDA: - flexarray_vappend(dm_args, "-device", "intel-hda", - "-device", "hda-duplex", NULL); + if (configure_pci_for_igd) { + flexarray_vappend(dm_args, "-device", + GCSPRINTF("intel-hda,addr=%x", next_slot), + "-device", "hda-duplex", NULL); + next_slot++; + } else { + flexarray_vappend(dm_args, "-device", "intel-hda", + "-device", "hda-duplex", NULL); + } break; default: flexarray_append_pair(dm_args, "-device", @@ -1573,10 +1665,18 @@ static int libxl__build_device_model_args_new(libxl__gc *gc, guest_domid, nics[i].devid, LIBXL_NIC_TYPE_VIF_IOEMU); flexarray_append(dm_args, "-device"); - flexarray_append(dm_args, - GCSPRINTF("%s,id=nic%d,netdev=net%d,mac=%s", - nics[i].model, nics[i].devid, - nics[i].devid, smac)); + if (configure_pci_for_igd) { + flexarray_append(dm_args, + GCSPRINTF("%s,addr=%x,id=nic%d,netdev=net%d,mac=%s", + nics[i].model, next_slot, nics[i].devid, + nics[i].devid, smac)); + next_slot++; + } else { + flexarray_append(dm_args, + GCSPRINTF("%s,id=nic%d,netdev=net%d,mac=%s", + nics[i].model, nics[i].devid, + nics[i].devid, smac)); + } flexarray_append(dm_args, "-netdev"); flexarray_append(dm_args, GCSPRINTF("type=tap,id=net%d,ifname=%s," @@ -1865,8 +1965,15 @@ static int libxl__build_device_model_args_new(libxl__gc *gc, if (b_info->type == LIBXL_DOMAIN_TYPE_HVM) { flexarray_append_pair(dm_envs, "XEN_DOMAIN_ID", GCSPRINTF("%d", guest_domid)); - if (b_info->u.hvm.hdtype == LIBXL_HDTYPE_AHCI) - flexarray_append_pair(dm_args, "-device", "ahci,id=ahci0"); + if (b_info->u.hvm.hdtype == LIBXL_HDTYPE_AHCI) { + if (configure_pci_for_igd) { + flexarray_append_pair(dm_args, "-device", + GCSPRINTF("ahci,addr=%x,id=ahci0", next_slot)); + next_slot++; + } else { + flexarray_append_pair(dm_args, "-device", "ahci,id=ahci0"); + } + } for (i = 0; i < num_disks; i++) { int disk, part; int dev_number = @@ -2043,7 +2150,14 @@ static int libxl__build_device_model_args_new(libxl__gc *gc, switch (b_info->u.hvm.vendor_device) { case LIBXL_VENDOR_DEVICE_XENSERVER: flexarray_append(dm_args, "-device"); - flexarray_append(dm_args, "xen-pvdevice,device-id=0xc000"); + if (configure_pci_for_igd) { + flexarray_append(dm_args, + GCSPRINTF("xen-pvdevice,addr=%x,device-id=0xc000", + next_slot)); + next_slot++; + } else { + flexarray_append(dm_args, "xen-pvdevice,device-id=0xc000"); + } break; default: break; -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Mon Jan 09 23:08:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 23:08:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474083.735033 (Exim 4.92) (envelope-from ) id 1pF1Fz-0000bq-9r; Mon, 09 Jan 2023 23:08:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474083.735033; Mon, 09 Jan 2023 23:08:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF1Fz-0000bd-6T; Mon, 09 Jan 2023 23:08:43 +0000 Received: by outflank-mailman (input) for mailman id 474083; Mon, 09 Jan 2023 23:08:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF1Fx-0000Gp-O1 for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 23:08:41 +0000 Received: from sonic308-8.consmr.mail.gq1.yahoo.com (sonic308-8.consmr.mail.gq1.yahoo.com [98.137.68.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8be2d2cc-9072-11ed-b8d0-410ff93cb8f0; Tue, 10 Jan 2023 00:08:37 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic308.consmr.mail.gq1.yahoo.com with HTTP; Mon, 9 Jan 2023 23:08:35 +0000 Received: by hermes--production-ne1-7b69748c4d-bgkrh (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 21a3ec8339abfccbadeaea4f5ef812e7; Mon, 09 Jan 2023 23:08:32 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8be2d2cc-9072-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1673305715; bh=ywgbO8lubWpnCassvIu6bBFzCJ/Z2sgLUfL80HdpzLE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From:Subject:Reply-To; b=pxzV/H1HM06MpAMRVFL0ssYCJXP59bXc5GrKUx/QcQJz7S71dqm4BINX2rzahxX81MtJ3y6CVWoFA+Z+Yvgmo6ZVoj16k+n0jLXlMLmUGbVqJE84JQ4p85+kGNkvkZ+CV3G3IVhDqZXv8Dr2rU0tVBF9iP1z0HwzRVp6x8KAHGEMS7q2ZCfeFIysV2I3RHAkuX8M4I5xj4vKnkI7rl/dsIfHsF+8921Wr5K1wPt2gMyHI+eTg8B2Lwfenjxuz9UX2sw8CglGE+K7lJLFfjSPx6RSsEPaGgY5LceZhom1Eg4fk0O1PK2D4Q/HnAm9NnGscRgslm01AHt6AiaU1UA4ZQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1673305715; bh=keMjmw88+NB73GNZ0YN7HfypUkwkByV4+3fnszfn8CF=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=o5oc++gedcFxnVQru4ndLDTH+4PHQV48uZlZYgPEpbc9FMkTUtRJaY8ZIkTBLQ9efm7MNUoNRoYQnfOqkxARaYxTn/ztbDwwrODbc224H2IWyAX+TBSF1kLYjVlyGY6omgdm0a7VCaxl0USk+DiuFfy7uCVCauu1/xE9QsAb+cGlcbD+60pewrrq1aKWcKGuCZ2nPcelXtbFD9hyDybbZ/tCH1FtccsiuUBwWONs0gVITU8DORaBTRcDW9rQNQ5RCGYm5So2t35HzP30oAv5CjIuBFRrupoQ9UF26cgAB8YIBmCnsldzZZipBmKZq9RxiDZGaXsJ9YEBnZ0/lwvPCQ== X-YMail-OSG: vQZpqCcVM1mUk8i0Yg6trsInc6cIWbw5_m7__7CkDb5NTL8YxNrrPG2YebLlzam cbBzvm1Qfug0CdK_EKzy9o7NDqNQ.oDx1dGzXpsW1UizBPvq8F5GwcOBS.9eepfelo2Hc068dSZg PFRNQRvtTcgxfA9dR.lOLBFOP25MpPq4pTWjtTC5DdLdlcdEDFg14WJHM_ruSYuLeOJMwtm8r6c9 t0_IxRGikpcmywJ8l0GYmNert7SRfUAh_TwQKxpjYgoh0C5DBiJs.sXBqpZqmoCfw98iOO8F0B1v BDe8VwfbQ9LyLe6R9qNFsHW_4CylMgaDyfi6F1L6YUuHVzkGTL.zvCPjrPxZo1JhUkI9pbrlEjVq QZ07JAl9zztA3m_F9mdSrNIShZML8F7D8biOje2C.zDIdxp.wOwCMXbp5TAahcygh2q9AmJfItAd w3krBHXcXWT5UrE00TTFA_MVSoqQhqomFTu3x5VWZUSJGjXc4BEXiMxf.K_yT7uX4jtA.k0rAdHX jWw1b7zXKomaPLHmV3Hjg576CP0BeS.v2Owvv1ymlnWXvQNeWFVj10av1tH_9FXoT5BkGhNtGaxK q6aRWbSlcpT6lACd8EXQjUig6HuYvzGGYDIpm_L8R3wA_XKdCuzSxpFfHJ9oqaNyp0F_mNPQ7xfY H_OMYWsTwp0wIRtnUE3epufHf_ZwrqgVz7E.CVtvi_lQWBBMCO6zQsaaRWzver3NRHhDqJKzdllU Ki9Q6ypU1sKtHeCDN6uQivu0LUl3m3kXOLrDa8fIz4Hx23rrvtZ2y5feJ7mvXxEEqBRLjxBrSqBH usd0r_3usqyCBDIXyEU6yCm4G9lr8R1bhjdcdGEVxYbnGcQ22yqgQkisyrCjJhk2wlm1BnXFibeM bVIm6sis5av5BHgjo6FZkg02DT34K56H725bfkaGTGSm6hIsHYSTKa5TLoD3uLUtj.tObqcSdYuT mI4qH.3ADGN8fWZHaSnbmWl.S_5JucXWDsQrX.6eXSFhBX_anNtCFkCbUkihkXZV1Sva8EmqHs3R DBHRUidj68bGpq6rC6HGpakt55ONoI1_iiQGSAklpsBEaXB8GTqrBWQyEgy8mKdMHQn9.cDBkhn4 YQQ8GIjjyzmbNWkNkTZmUw7F6lZ8Rsi8P4_RX1Cmg0h3AZ2o3DldWH8NUIIjzxVSAydONH8cYVCi _KCuEbj6K9MtQJtiAi8mWVIAHZMtngEcXb4vetP6QXoa3bscDARG8c3DrlrKeV0xWJh9IsPn_fO6 lCKp7_j6NqmTG3oNlVhfZCpwNXDsWWmkw0zCBwxMxX_C0kDjoHK42ePacU4DtKyU5ggLQzPjoBZR 8MIjGW9HtAzBnQyXoNK5iHTMx6hk8mDXEGvucUmkG6bSOk5iHb4bZuaDyibxfjnn1gu2vErd._91 k8GmjuSozC_fApfkJ.yolqbPpOWW2dKb2vtwl3q78PlTqTbFzMGVVg.p_Zx8kt1ePl7x97FNTy1L YU5t77MmDasd5dfcapCgontTo.7eKb6EtANIjKOZF.IGxD0FSSPTKtRJiraMZrW1xThL3pjzBXy_ idlDgeBz4V_.RbOd1GpUGTiZkTKP34mpwQ8aLNPXsEFSuX7yz4gPbrVSsRowIaus2sJxQnvbkQlf hG7JcMfmePc.u4hu7clkU23J3HU3KRyV8Zc3nJZLYXG8LFtWGYqdAdBDgjm0LV_KByE36kM3YgCW vrrmyF3IateQLwYucxGimj5zcjl8t9bAYDcEtIsZSg8DPWjty1LbAmJdxoj2WPbquYvnktxGBfdg 0QznWRWZGIrkjLNC2QloR.OOMnb09ahDk9nJ9q9xtJ4voF05Q8c2Jvzg0FvkezRWl8LK2VhYpFs9 W4M631i9xLc6yU5aZnWRrsB7joBr4FEDvkSxCzU_cBhRAjHfUTyoByUkBxTxMb9yt6ZM2ghZoX7M 4X44tPVu604f.o9ZuWAJy7zhT2IAzwp1aYlqfKywOZ8iwK89zwurgxNux8odcJGe8wTK_NaFL1kI 4UFtlTJ3XYeRL6fjGS6415Z5PVgwMpQ9qwVDnoW7fmctSGop.iWJO6ImljqeBecgMRDO0UFB.hbn rpzFDd3it6GvDxcNBoCdQDUkXIw_RwrNeqgzjAP2cKVqLBVt7Ft1u.ciEP9bWBj0_nhtGG.lPkDG y9c_Poj1g_5DWY9FwycTRu2KCaslyzwI2.DyIuP23TmQA0qm41xKWUkKkiK6wucoCyxzfS8lCYQ- - X-Sonic-MF: From: Chuck Zmudzinski To: anthony.perard@citrix.com Cc: xen-devel@lists.xenproject.org, Wei Liu , Juergen Gross , qemu-devel@nongnu.org Subject: [XEN PATCH 3/3] libxl/dm: Assign slot 2 by default for Intel IGD passthrough Date: Mon, 9 Jan 2023 18:08:13 -0500 Message-Id: <27bb3979f234c8de6b51be7bb8195e3cacb5181c.1673300848.git.brchuckz@aol.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Length: 2519 It is possible for the administrator to manually specify the virtual slot addresses of passed through pci devices on the guest's pci bus using the @VSLOT parameter in xl.cfg. With this patch, libxl will by default assign the Intel IGD to slot 2 when gfx_passthru is configured for the Intel IGD so it will no longer be necessary to use the @VSLOT setting to configure the IGD correctly. Also, with this patch, libxl will not override explicit @VSLOT settings by the administrator so in that case the patch will have no effect on guest behavior. The default behavior of letting qemu manage the slot addresses of passed through pci devices when gfx_passthru is disabled and the administrator does not set @VSLOT for passed through pci devices is also preserved. Signed-off-by: Chuck Zmudzinski --- tools/libs/light/libxl_dm.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/tools/libs/light/libxl_dm.c b/tools/libs/light/libxl_dm.c index 2720b5d4d0..b51ebae643 100644 --- a/tools/libs/light/libxl_dm.c +++ b/tools/libs/light/libxl_dm.c @@ -1207,6 +1207,7 @@ static int libxl__build_device_model_args_new(libxl__gc *gc, int rc; int next_slot; bool configure_pci_for_igd = false; + const int igd_slot = 2; /* * next_slot is only used when we need to configure the pci * slots for the Intel IGD. Slot 2 will be for the Intel IGD. @@ -2173,6 +2174,27 @@ static int libxl__build_device_model_args_new(libxl__gc *gc, flexarray_append(dm_envs, NULL); if (envs) *envs = (char **) flexarray_contents(dm_envs); + if (configure_pci_for_igd) { + libxl_device_pci *pci = NULL; + for (i = 0; i < guest_config->num_pcidevs; i++) { + pci = &guest_config->pcidevs[i]; + if (!pci->vdevfn) { + /* + * Find the Intel IGD and configure it for slot 2. + * Configure any other devices for slot next_slot. + * Since the guest is configured for IGD passthrough, + * assume the device on the host at slot 2 is the IGD. + */ + if (pci->domain == 0 && pci->bus == 0 && + pci->dev == igd_slot && pci->func == 0) { + pci->vdevfn = PCI_DEVFN(igd_slot, 0); + } else { + pci->vdevfn = PCI_DEVFN(next_slot, 0); + next_slot++; + } + } + } + } return 0; } -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Mon Jan 09 23:18:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 23:18:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474106.735044 (Exim 4.92) (envelope-from ) id 1pF1Pa-00035O-8P; Mon, 09 Jan 2023 23:18:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474106.735044; Mon, 09 Jan 2023 23:18:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF1Pa-00035H-5J; Mon, 09 Jan 2023 23:18:38 +0000 Received: by outflank-mailman (input) for mailman id 474106; Mon, 09 Jan 2023 23:18:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF1PY-000354-TB; Mon, 09 Jan 2023 23:18:36 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF1PY-0003yp-PK; Mon, 09 Jan 2023 23:18:36 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF1PY-00031m-J5; Mon, 09 Jan 2023 23:18:36 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pF1PY-0003xB-Ia; Mon, 09 Jan 2023 23:18:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To; bh=FHRTWuZiU08PVVHIifyRcHWR/5PdIvZqRQy4FyP6s78=; b=oYRZNBPHKljCTQbWTJl4zrp5nD xHuaE6HXJLc0CyCnt05nwQVuvT5r7+Duu8gpegEiS0ZmqTyemup9aWKPof/m4mBzjVWs3qrS8rYy2 Tuhi6oDfHwXrkmsAubPj6SGuWboSaAhwiLjvOPGf5WZxs7XEk/1eFmwaNuEg9snvx3/M=; To: xen-devel@lists.xenproject.org Subject: [qemu-mainline bisection] complete build-i386 Message-Id: From: osstest service owner Date: Mon, 09 Jan 2023 23:18:36 +0000 branch xen-unstable xenbranch xen-unstable job build-i386 testid xen-build Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://git.qemu.org/qemu.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git *** Found and reproduced problem changeset *** Bug is in tree: qemuu git://git.qemu.org/qemu.git Bug introduced: 3d83b78285d6e96636130f7d449fd02e2d4deee0 Bug not present: 528d9f33cad5245c1099d77084c78bb2244d5143 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/175667/ commit 3d83b78285d6e96636130f7d449fd02e2d4deee0 Merge: 528d9f33ca fb418b51b7 Author: Peter Maydell Date: Sun Jan 8 14:27:40 2023 +0000 Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging * Atomic memslot updates for KVM (Emanuele, David) * Always send errors to logfile when daemonized (Greg) * Add support for IDE CompactFlash card (Lubomir) * First round of build system cleanups (myself) * First round of feature removals (myself) * Reduce "qemu/accel.h" inclusion (Philippe) # gpg: Signature made Thu 05 Jan 2023 23:51:09 GMT # gpg: using RSA key F13338574B662389866C7682BFFBD25F78C7AE83 # gpg: issuer "pbonzini@redhat.com" # gpg: Good signature from "Paolo Bonzini " [full] # gpg: aka "Paolo Bonzini " [full] # Primary key fingerprint: 46F5 9FBD 57D6 12E7 BFD4 E2F7 7E15 100C CD36 69B1 # Subkey fingerprint: F133 3857 4B66 2389 866C 7682 BFFB D25F 78C7 AE83 * tag 'for-upstream' of https://gitlab.com/bonzini/qemu: (24 commits) i386: SGX: remove deprecated member of SGXInfo target/i386: Add SGX aex-notify and EDECCSSA support util: remove support -chardev tty and -chardev parport util: remove support for hex numbers with a scaling suffix KVM: remove support for kernel-irqchip=off docs: do not talk about past removal as happening in the future meson: accept relative symlinks in "meson introspect --installed" data meson: cleanup compiler detection meson: support meson 0.64 -Doptimization=plain configure: test all warnings tests/qapi-schema: remove Meson workaround meson: cleanup dummy-cpus.c rules meson: tweak hardening options for Windows configure: remove backwards-compatibility and obsolete options configure: preserve qemu-ga variables configure: cleanup $cpu tests configure: remove dead function configure: remove useless write_c_skeleton ide: Add "ide-cf" driver, a CompactFlash card ide: Add 8-bit data mode ... Signed-off-by: Peter Maydell commit fb418b51b7b43c34873f4b9af3da7031b7452115 Author: Paolo Bonzini Date: Fri Dec 16 11:02:48 2022 +0100 i386: SGX: remove deprecated member of SGXInfo Signed-off-by: Paolo Bonzini commit d45f24fe7525d8a8aaa4ca6d9d214dc41819caa5 Author: Kai Huang Date: Wed Nov 9 15:48:34 2022 +1300 target/i386: Add SGX aex-notify and EDECCSSA support The new SGX Asynchronous Exit (AEX) notification mechanism (AEX-notify) allows one enclave to receive a notification in the ERESUME after the enclave exit due to an AEX. EDECCSSA is a new SGX user leaf function (ENCLU[EDECCSSA]) to facilitate the AEX notification handling. Whether the hardware supports to create enclave with AEX-notify support is enumerated via CPUID.(EAX=0x12,ECX=0x1):EAX[10]. The new EDECCSSA user leaf function is enumerated via CPUID.(EAX=0x12,ECX=0x0):EAX[11]. Add support to allow to expose the new SGX AEX-notify feature and the new EDECCSSA user leaf function to KVM guest. Link: https://lore.kernel.org/lkml/166760360549.4906.809756297092548496.tip-bot2@tip-bot2/ Link: https://lore.kernel.org/lkml/166760360934.4906.2427175408052308969.tip-bot2@tip-bot2/ Reviewed-by: Yang Zhong Signed-off-by: Kai Huang Message-Id: <20221109024834.172705-1-kai.huang@intel.com> Signed-off-by: Paolo Bonzini commit 6f9f630836df355b9ca3f4641e6b7be71f6af076 Author: Paolo Bonzini Date: Fri Dec 16 10:56:53 2022 +0100 util: remove support -chardev tty and -chardev parport These were deprecated in 6.0 and can now be removed. Signed-off-by: Paolo Bonzini commit 8b902e3d2309595567e4957b96e971c4f3ca455e Author: Paolo Bonzini Date: Fri Dec 16 10:50:05 2022 +0100 util: remove support for hex numbers with a scaling suffix This was deprecated in 6.0 and can now be removed. Signed-off-by: Paolo Bonzini commit eaaaf8abdc9a9f3493f2cb6a751660dff3f9db57 Author: Paolo Bonzini Date: Fri Dec 16 10:39:32 2022 +0100 KVM: remove support for kernel-irqchip=off -machine kernel-irqchip=off is broken for many guest OSes; kernel-irqchip=split is the replacement that works, so remove the deprecated support for the former. Signed-off-by: Paolo Bonzini commit 9d3f8b3247795ae8f482700bbbace04b04421d5b Author: Paolo Bonzini Date: Fri Dec 16 11:05:20 2022 +0100 docs: do not talk about past removal as happening in the future KVM guest support on 32-bit Arm hosts *has* been removed, so rephrase the sentence describing it. Signed-off-by: Paolo Bonzini commit f32eb0021a85efaca97f69b0e9201737562a8e4f Author: Paolo Bonzini Date: Wed Dec 14 13:25:00 2022 +0100 meson: accept relative symlinks in "meson introspect --installed" data When installing shared libraries, as is the case for libvfio-user.so, Meson will include relative symbolic links in the output of "meson introspect --installed": { "libvfio-user.so": "/usr/local/lib64/libvfio-user.so", ... } In the case of scripts/symlink-install-tree.py, this will be a symbolic link to a symbolic link but, in any case, there is no issue in creating it. Cc: qemu-stable@nongnu.org Signed-off-by: Paolo Bonzini commit e51340243687a2cd7ffcf0d6e2de030bed4b8720 Author: Paolo Bonzini Date: Wed Oct 12 14:15:06 2022 +0200 meson: cleanup compiler detection Detect all compilers at the beginning of meson.build, and store the available languages in an array. Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit 6a97f3939240977e66e90862419911666956a76a Author: Paolo Bonzini Date: Wed Nov 2 13:07:23 2022 +0100 meson: support meson 0.64 -Doptimization=plain In Meson 0.64, the optimization built-in option now accepts the "plain" value, which will not set any optimization flags. While QEMU does not check the contents of the option and therefore does not suffer any ill effect from the new value, it uses get_option to print the optimization flags in the summary. Clean the code up to remove duplication, and check for -Doptimization=plain at the same time. Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit ca9b5c2ebf1aca87677a24c208bf3d0345c0b1aa Author: Paolo Bonzini Date: Wed Oct 12 14:21:22 2022 +0200 configure: test all warnings Some warnings are hardcoded in QEMU_CFLAGS and not tested. There is no particular reason to single out these five, as many more -W flags are present on all the supported compilers. For homogeneity when moving the detection to meson, make them use the same warn_flags infrastructure. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Paolo Bonzini commit 7bef93ff064f540e24a36a31263ae3db2d06b3d2 Author: Paolo Bonzini Date: Wed Dec 14 12:29:11 2022 +0100 tests/qapi-schema: remove Meson workaround The referenced issue has been fixed since version 0.61, so remove the workaround. Signed-off-by: Paolo Bonzini commit 9c9b85d705abdcce0b63f9182d8140dd67bd13fb Author: Paolo Bonzini Date: Thu Jul 22 10:43:00 2021 +0200 meson: cleanup dummy-cpus.c rules Now that qtest is available on all targets including Windows, dummy-cpus.c is included unconditionally in the build. It also does not need to be compiled per-target. Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit 2d73fa74728dccde5cc29c4e56b4d781e4ead7c4 Author: Paolo Bonzini Date: Wed Nov 2 13:03:51 2022 +0100 meson: tweak hardening options for Windows meson.build has been enabling ASLR _only_ for debug builds since commit d2147e04f95f ("configure: move Windows flags detection to meson", 2022-05-07); instead it was supposed to disable it for debug builds. However, the flag has been enabled for DLLs upstream for roughly 2 years (https://sourceware.org/bugzilla/show_bug.cgi?id=19011), and also by some distros including Debian for 6 years even (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=836365). Enable it unconditionally; we can fix the reversed logic of commit d2147e04f95f later if there are any reports, but for now just enable the hardening. Also add -Wl,--high-entropy-va, which also controls ASLR. Signed-off-by: Paolo Bonzini commit 10229ec3b0ff77c4894cefa312c21e65a761dcde Author: Paolo Bonzini Date: Tue Oct 18 10:17:46 2022 +0200 configure: remove backwards-compatibility and obsolete options Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit 954ed68f9934a3e08f904acb93ce168505995e95 Author: Paolo Bonzini Date: Wed Oct 12 11:35:17 2022 +0200 configure: preserve qemu-ga variables Ensure that qemu-ga variables set at configure time are kept later when the script is rerun. For preserve_env to work, the variables need to be empty so move the default values to config-host.mak generation. Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit f9c77801f4992fae99392ccbb60596dfa1fcf04a Author: Paolo Bonzini Date: Wed Oct 12 15:27:03 2022 +0200 configure: cleanup $cpu tests $cpu is derived from preprocessor defines rather than uname these days, so do not bother using isainfo on Solaris. Likewise do not recognize BeOS's uname -m output. Keep the other, less OS-specific canonicalizations for the benefit of people using --cpu. Reviewed-by: Peter Maydell Signed-off-by: Paolo Bonzini commit 91cd485a6dcbc8210666d19146fe73b8664f0418 Author: Paolo Bonzini Date: Tue Oct 18 10:17:25 2022 +0200 configure: remove dead function Reviewed-by: Peter Maydell Signed-off-by: Paolo Bonzini commit c5634e822416e71e00f08f55a521362d8d21264d Author: Paolo Bonzini Date: Thu Oct 20 14:20:06 2022 +0200 configure: remove useless write_c_skeleton This is not needed ever since QEMU stopped detecting -liberty; this happened with the Meson switch but it is quite likely that the library was not really necessary years before. Reviewed-by: Peter Maydell Signed-off-by: Paolo Bonzini commit cec79db38df72ce74d0296b831e90547111bc13c Author: Lubomir Rintel Date: Wed Nov 30 13:03:19 2022 +0100 ide: Add "ide-cf" driver, a CompactFlash card This allows attaching IDE_CFATA device to an IDE bus. Behaves like a CompactFlash card in True IDE mode. Tested with: qemu-system-i386 \$ -device driver=ide-cf,drive=cf,bus=ide.0 \$ -drive id=cf,index=0,format=raw,if=none,file=cf.img Signed-off-by: Lubomir Rintel Message-Id: <20221130120319.706885-1-lkundrak@v3.sk> Signed-off-by: Paolo Bonzini commit 1ea17d228e582b1cfbf6f61e9da5fafef4063be8 Author: Lubomir Rintel Date: Wed Nov 30 13:02:38 2022 +0100 ide: Add 8-bit data mode CompactFlash uses features 0x01 and 0x81 to enable/disable 8-bit data path. Implement them. Signed-off-by: Lubomir Rintel Message-Id: <20221130120238.706717-1-lkundrak@v3.sk> Signed-off-by: Paolo Bonzini commit 9b063b7ea697d796914b3651d15c3457b7b1135c Author: Greg Kurz Date: Tue Nov 8 15:00:32 2022 +0100 util/log: Always send errors to logfile when daemonized When QEMU is started with `-daemonize`, all stdio descriptors get redirected to `/dev/null`. This basically means that anything printed with error_report() and friends is lost. Current logging code allows to redirect to a file with `-D` but this requires to enable some logging item with `-d` as well to be functional. Relax the check on the log flags when QEMU is daemonized, so that other users of stderr can benefit from the redirection, without the need to enable unwanted debug logs. Previous behaviour is retained for the non-daemonized case. The logic is unrolled as an `if` for better readability. The qemu_log_level and log_per_thread globals reflect the state we want to transition to at this point : use them instead of the intermediary locals for correctness. qemu_set_log_internal() is adapted to open a per-thread log file when '-d tid' is passed. This is done by hijacking qemu_try_lock() which seems simpler that refactoring the code. Signed-off-by: Greg Kurz Message-Id: <20221108140032.1460307-3-groug@kaod.org> Signed-off-by: Paolo Bonzini commit 59bde2137445b63c822720d069d91d38190c6540 Author: Paolo Bonzini Date: Tue Nov 8 15:00:31 2022 +0100 util/log: do not close and reopen log files when flags are turned off log_append makes sure that if you turn off the logging (which clears log_flags and makes need_to_open_file false) the old log is not overwritten. The usecase is that if you remove or move the file QEMU will not keep writing to the old file. However, this is not always the desited behavior, in particular having log_append==1 after changing the file name makes little sense. When qemu_set_log_internal is called from the logfile monitor command, filename must be non-NULL and therefore changed_name must be true. Therefore, the only case where the file is closed and need_to_open_file == false is indeed when log_flags becomes zero. In this case, just flush the file and do not bother closing it, thus faking the same append behavior as previously. The behavioral change is that changing the logfile twice, for example log1 -> log2 -> log1, will cause log1 to be overwritten. This can simply be documented, since it is not a particularly surprising behavior. Suggested-by: Alex Bennée Signed-off-by: Paolo Bonzini Reviewed-by: Richard Henderson Reviewed-by: Greg Kurz Message-Id: <20221025092119.236224-1-pbonzini@redhat.com> [groug: nullify global_file before actually closing the file] Signed-off-by: Greg Kurz Message-Id: <20221108140032.1460307-2-groug@kaod.org> Signed-off-by: Paolo Bonzini commit cc6ff741123216550997b12cdd991beeed47bd0d Author: Philippe Mathieu-Daudé Date: Wed Nov 30 14:56:41 2022 +0100 hw: Reduce "qemu/accel.h" inclusion Move "qemu/accel.h" include from the heavily included "hw/boards.h" to hw/core/machine.c, the single file using the AccelState definition. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Fabiano Rosas Message-Id: <20221130135641.85328-3-philmd@linaro.org> Signed-off-by: Paolo Bonzini commit 3d277871f39d4de42f56b7b0cef5721e525b2d31 Author: Philippe Mathieu-Daudé Date: Wed Nov 30 14:56:40 2022 +0100 typedefs: Forward-declare AccelState Forward-declare AccelState in "qemu/typedefs.h" so structures using a reference of it (like MachineState in "hw/boards.h") don't have to include "qemu/accel.h". Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Fabiano Rosas Message-Id: <20221130135641.85328-2-philmd@linaro.org> Signed-off-by: Paolo Bonzini For bisection revision-tuple graph see: http://logs.test-lab.xenproject.org/osstest/results/bisect/qemu-mainline/build-i386.xen-build.html Revision IDs in each graph node refer, respectively, to the Trees above. ---------------------------------------- Running cs-bisection-step --graph-out=/home/logs/results/bisect/qemu-mainline/build-i386.xen-build --summary-out=tmp/175667.bisection-summary --basis-template=175623 --blessings=real,real-bisect,real-retry qemu-mainline build-i386 xen-build Searching for failure / basis pass: 175654 fail [host=nobling1] / 175637 ok. Failure / basis pass flights: 175654 / 175637 (tree with no url: minios) Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://git.qemu.org/qemu.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git Latest d8d829b89dababf763ab33b8cdd852b2830db3cf 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 aa96ab7c9df59c615ca82b49c9062819e0a1c287 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 Basis pass d8d829b89dababf763ab33b8cdd852b2830db3cf 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 528d9f33cad5245c1099d77084c78bb2244d5143 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 Generating revisions with ./adhoc-revtuple-generator git://xenbits.xen.org/osstest/ovmf.git#d8d829b89dababf763ab33b8cdd852b2830db3cf-d8d829b89dababf763ab33b8cdd852b2830db3cf git://xenbits.xen.org/qemu-xen-traditional.git#3d273dd05e51e5a1ffba3d98c7437ee84e8f8764-3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 git://git.qemu.org/qemu.git#528d9f33cad5245c1099d77084c78bb2244d5143-aa96ab7c9df59c615ca82b49c9062819e0a1c287 git://xenbits.xen.org/osstest/seabios.git#645a64b4911d7cadf5749d7375544fc2384e70ba-645\ a64b4911d7cadf5749d7375544fc2384e70ba git://xenbits.xen.org/xen.git#2b21cbbb339fb14414f357a6683b1df74c36fda2-2b21cbbb339fb14414f357a6683b1df74c36fda2 Loaded 5002 nodes in revision graph Searching for test results: 175627 [host=albana1] 175631 [host=debina1] 175637 pass d8d829b89dababf763ab33b8cdd852b2830db3cf 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 528d9f33cad5245c1099d77084c78bb2244d5143 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 175643 fail d8d829b89dababf763ab33b8cdd852b2830db3cf 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 3d83b78285d6e96636130f7d449fd02e2d4deee0 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 175647 fail d8d829b89dababf763ab33b8cdd852b2830db3cf 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 d6271b657286de80260413684a1f2a63f44ea17b 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 175654 fail d8d829b89dababf763ab33b8cdd852b2830db3cf 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 aa96ab7c9df59c615ca82b49c9062819e0a1c287 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 175660 pass d8d829b89dababf763ab33b8cdd852b2830db3cf 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 528d9f33cad5245c1099d77084c78bb2244d5143 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 175661 fail d8d829b89dababf763ab33b8cdd852b2830db3cf 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 d6271b657286de80260413684a1f2a63f44ea17b 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 175662 fail d8d829b89dababf763ab33b8cdd852b2830db3cf 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 aa96ab7c9df59c615ca82b49c9062819e0a1c287 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 175663 fail d8d829b89dababf763ab33b8cdd852b2830db3cf 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 3d83b78285d6e96636130f7d449fd02e2d4deee0 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 175666 pass d8d829b89dababf763ab33b8cdd852b2830db3cf 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 528d9f33cad5245c1099d77084c78bb2244d5143 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 175667 fail d8d829b89dababf763ab33b8cdd852b2830db3cf 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 3d83b78285d6e96636130f7d449fd02e2d4deee0 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 Searching for interesting versions Result found: flight 175637 (pass), for basis pass Result found: flight 175654 (fail), for basis failure Repro found: flight 175660 (pass), for basis pass Repro found: flight 175662 (fail), for basis failure 0 revisions at d8d829b89dababf763ab33b8cdd852b2830db3cf 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 528d9f33cad5245c1099d77084c78bb2244d5143 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 No revisions left to test, checking graph state. Result found: flight 175637 (pass), for last pass Result found: flight 175643 (fail), for first failure Repro found: flight 175660 (pass), for last pass Repro found: flight 175663 (fail), for first failure Repro found: flight 175666 (pass), for last pass Repro found: flight 175667 (fail), for first failure *** Found and reproduced problem changeset *** Bug is in tree: qemuu git://git.qemu.org/qemu.git Bug introduced: 3d83b78285d6e96636130f7d449fd02e2d4deee0 Bug not present: 528d9f33cad5245c1099d77084c78bb2244d5143 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/175667/ commit 3d83b78285d6e96636130f7d449fd02e2d4deee0 Merge: 528d9f33ca fb418b51b7 Author: Peter Maydell Date: Sun Jan 8 14:27:40 2023 +0000 Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging * Atomic memslot updates for KVM (Emanuele, David) * Always send errors to logfile when daemonized (Greg) * Add support for IDE CompactFlash card (Lubomir) * First round of build system cleanups (myself) * First round of feature removals (myself) * Reduce "qemu/accel.h" inclusion (Philippe) # gpg: Signature made Thu 05 Jan 2023 23:51:09 GMT # gpg: using RSA key F13338574B662389866C7682BFFBD25F78C7AE83 # gpg: issuer "pbonzini@redhat.com" # gpg: Good signature from "Paolo Bonzini " [full] # gpg: aka "Paolo Bonzini " [full] # Primary key fingerprint: 46F5 9FBD 57D6 12E7 BFD4 E2F7 7E15 100C CD36 69B1 # Subkey fingerprint: F133 3857 4B66 2389 866C 7682 BFFB D25F 78C7 AE83 * tag 'for-upstream' of https://gitlab.com/bonzini/qemu: (24 commits) i386: SGX: remove deprecated member of SGXInfo target/i386: Add SGX aex-notify and EDECCSSA support util: remove support -chardev tty and -chardev parport util: remove support for hex numbers with a scaling suffix KVM: remove support for kernel-irqchip=off docs: do not talk about past removal as happening in the future meson: accept relative symlinks in "meson introspect --installed" data meson: cleanup compiler detection meson: support meson 0.64 -Doptimization=plain configure: test all warnings tests/qapi-schema: remove Meson workaround meson: cleanup dummy-cpus.c rules meson: tweak hardening options for Windows configure: remove backwards-compatibility and obsolete options configure: preserve qemu-ga variables configure: cleanup $cpu tests configure: remove dead function configure: remove useless write_c_skeleton ide: Add "ide-cf" driver, a CompactFlash card ide: Add 8-bit data mode ... Signed-off-by: Peter Maydell commit fb418b51b7b43c34873f4b9af3da7031b7452115 Author: Paolo Bonzini Date: Fri Dec 16 11:02:48 2022 +0100 i386: SGX: remove deprecated member of SGXInfo Signed-off-by: Paolo Bonzini commit d45f24fe7525d8a8aaa4ca6d9d214dc41819caa5 Author: Kai Huang Date: Wed Nov 9 15:48:34 2022 +1300 target/i386: Add SGX aex-notify and EDECCSSA support The new SGX Asynchronous Exit (AEX) notification mechanism (AEX-notify) allows one enclave to receive a notification in the ERESUME after the enclave exit due to an AEX. EDECCSSA is a new SGX user leaf function (ENCLU[EDECCSSA]) to facilitate the AEX notification handling. Whether the hardware supports to create enclave with AEX-notify support is enumerated via CPUID.(EAX=0x12,ECX=0x1):EAX[10]. The new EDECCSSA user leaf function is enumerated via CPUID.(EAX=0x12,ECX=0x0):EAX[11]. Add support to allow to expose the new SGX AEX-notify feature and the new EDECCSSA user leaf function to KVM guest. Link: https://lore.kernel.org/lkml/166760360549.4906.809756297092548496.tip-bot2@tip-bot2/ Link: https://lore.kernel.org/lkml/166760360934.4906.2427175408052308969.tip-bot2@tip-bot2/ Reviewed-by: Yang Zhong Signed-off-by: Kai Huang Message-Id: <20221109024834.172705-1-kai.huang@intel.com> Signed-off-by: Paolo Bonzini commit 6f9f630836df355b9ca3f4641e6b7be71f6af076 Author: Paolo Bonzini Date: Fri Dec 16 10:56:53 2022 +0100 util: remove support -chardev tty and -chardev parport These were deprecated in 6.0 and can now be removed. Signed-off-by: Paolo Bonzini commit 8b902e3d2309595567e4957b96e971c4f3ca455e Author: Paolo Bonzini Date: Fri Dec 16 10:50:05 2022 +0100 util: remove support for hex numbers with a scaling suffix This was deprecated in 6.0 and can now be removed. Signed-off-by: Paolo Bonzini commit eaaaf8abdc9a9f3493f2cb6a751660dff3f9db57 Author: Paolo Bonzini Date: Fri Dec 16 10:39:32 2022 +0100 KVM: remove support for kernel-irqchip=off -machine kernel-irqchip=off is broken for many guest OSes; kernel-irqchip=split is the replacement that works, so remove the deprecated support for the former. Signed-off-by: Paolo Bonzini commit 9d3f8b3247795ae8f482700bbbace04b04421d5b Author: Paolo Bonzini Date: Fri Dec 16 11:05:20 2022 +0100 docs: do not talk about past removal as happening in the future KVM guest support on 32-bit Arm hosts *has* been removed, so rephrase the sentence describing it. Signed-off-by: Paolo Bonzini commit f32eb0021a85efaca97f69b0e9201737562a8e4f Author: Paolo Bonzini Date: Wed Dec 14 13:25:00 2022 +0100 meson: accept relative symlinks in "meson introspect --installed" data When installing shared libraries, as is the case for libvfio-user.so, Meson will include relative symbolic links in the output of "meson introspect --installed": { "libvfio-user.so": "/usr/local/lib64/libvfio-user.so", ... } In the case of scripts/symlink-install-tree.py, this will be a symbolic link to a symbolic link but, in any case, there is no issue in creating it. Cc: qemu-stable@nongnu.org Signed-off-by: Paolo Bonzini commit e51340243687a2cd7ffcf0d6e2de030bed4b8720 Author: Paolo Bonzini Date: Wed Oct 12 14:15:06 2022 +0200 meson: cleanup compiler detection Detect all compilers at the beginning of meson.build, and store the available languages in an array. Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit 6a97f3939240977e66e90862419911666956a76a Author: Paolo Bonzini Date: Wed Nov 2 13:07:23 2022 +0100 meson: support meson 0.64 -Doptimization=plain In Meson 0.64, the optimization built-in option now accepts the "plain" value, which will not set any optimization flags. While QEMU does not check the contents of the option and therefore does not suffer any ill effect from the new value, it uses get_option to print the optimization flags in the summary. Clean the code up to remove duplication, and check for -Doptimization=plain at the same time. Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit ca9b5c2ebf1aca87677a24c208bf3d0345c0b1aa Author: Paolo Bonzini Date: Wed Oct 12 14:21:22 2022 +0200 configure: test all warnings Some warnings are hardcoded in QEMU_CFLAGS and not tested. There is no particular reason to single out these five, as many more -W flags are present on all the supported compilers. For homogeneity when moving the detection to meson, make them use the same warn_flags infrastructure. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Paolo Bonzini commit 7bef93ff064f540e24a36a31263ae3db2d06b3d2 Author: Paolo Bonzini Date: Wed Dec 14 12:29:11 2022 +0100 tests/qapi-schema: remove Meson workaround The referenced issue has been fixed since version 0.61, so remove the workaround. Signed-off-by: Paolo Bonzini commit 9c9b85d705abdcce0b63f9182d8140dd67bd13fb Author: Paolo Bonzini Date: Thu Jul 22 10:43:00 2021 +0200 meson: cleanup dummy-cpus.c rules Now that qtest is available on all targets including Windows, dummy-cpus.c is included unconditionally in the build. It also does not need to be compiled per-target. Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit 2d73fa74728dccde5cc29c4e56b4d781e4ead7c4 Author: Paolo Bonzini Date: Wed Nov 2 13:03:51 2022 +0100 meson: tweak hardening options for Windows meson.build has been enabling ASLR _only_ for debug builds since commit d2147e04f95f ("configure: move Windows flags detection to meson", 2022-05-07); instead it was supposed to disable it for debug builds. However, the flag has been enabled for DLLs upstream for roughly 2 years (https://sourceware.org/bugzilla/show_bug.cgi?id=19011), and also by some distros including Debian for 6 years even (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=836365). Enable it unconditionally; we can fix the reversed logic of commit d2147e04f95f later if there are any reports, but for now just enable the hardening. Also add -Wl,--high-entropy-va, which also controls ASLR. Signed-off-by: Paolo Bonzini commit 10229ec3b0ff77c4894cefa312c21e65a761dcde Author: Paolo Bonzini Date: Tue Oct 18 10:17:46 2022 +0200 configure: remove backwards-compatibility and obsolete options Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit 954ed68f9934a3e08f904acb93ce168505995e95 Author: Paolo Bonzini Date: Wed Oct 12 11:35:17 2022 +0200 configure: preserve qemu-ga variables Ensure that qemu-ga variables set at configure time are kept later when the script is rerun. For preserve_env to work, the variables need to be empty so move the default values to config-host.mak generation. Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit f9c77801f4992fae99392ccbb60596dfa1fcf04a Author: Paolo Bonzini Date: Wed Oct 12 15:27:03 2022 +0200 configure: cleanup $cpu tests $cpu is derived from preprocessor defines rather than uname these days, so do not bother using isainfo on Solaris. Likewise do not recognize BeOS's uname -m output. Keep the other, less OS-specific canonicalizations for the benefit of people using --cpu. Reviewed-by: Peter Maydell Signed-off-by: Paolo Bonzini commit 91cd485a6dcbc8210666d19146fe73b8664f0418 Author: Paolo Bonzini Date: Tue Oct 18 10:17:25 2022 +0200 configure: remove dead function Reviewed-by: Peter Maydell Signed-off-by: Paolo Bonzini commit c5634e822416e71e00f08f55a521362d8d21264d Author: Paolo Bonzini Date: Thu Oct 20 14:20:06 2022 +0200 configure: remove useless write_c_skeleton This is not needed ever since QEMU stopped detecting -liberty; this happened with the Meson switch but it is quite likely that the library was not really necessary years before. Reviewed-by: Peter Maydell Signed-off-by: Paolo Bonzini commit cec79db38df72ce74d0296b831e90547111bc13c Author: Lubomir Rintel Date: Wed Nov 30 13:03:19 2022 +0100 ide: Add "ide-cf" driver, a CompactFlash card This allows attaching IDE_CFATA device to an IDE bus. Behaves like a CompactFlash card in True IDE mode. Tested with: qemu-system-i386 \$ -device driver=ide-cf,drive=cf,bus=ide.0 \$ -drive id=cf,index=0,format=raw,if=none,file=cf.img Signed-off-by: Lubomir Rintel Message-Id: <20221130120319.706885-1-lkundrak@v3.sk> Signed-off-by: Paolo Bonzini commit 1ea17d228e582b1cfbf6f61e9da5fafef4063be8 Author: Lubomir Rintel Date: Wed Nov 30 13:02:38 2022 +0100 ide: Add 8-bit data mode CompactFlash uses features 0x01 and 0x81 to enable/disable 8-bit data path. Implement them. Signed-off-by: Lubomir Rintel Message-Id: <20221130120238.706717-1-lkundrak@v3.sk> Signed-off-by: Paolo Bonzini commit 9b063b7ea697d796914b3651d15c3457b7b1135c Author: Greg Kurz Date: Tue Nov 8 15:00:32 2022 +0100 util/log: Always send errors to logfile when daemonized When QEMU is started with `-daemonize`, all stdio descriptors get redirected to `/dev/null`. This basically means that anything printed with error_report() and friends is lost. Current logging code allows to redirect to a file with `-D` but this requires to enable some logging item with `-d` as well to be functional. Relax the check on the log flags when QEMU is daemonized, so that other users of stderr can benefit from the redirection, without the need to enable unwanted debug logs. Previous behaviour is retained for the non-daemonized case. The logic is unrolled as an `if` for better readability. The qemu_log_level and log_per_thread globals reflect the state we want to transition to at this point : use them instead of the intermediary locals for correctness. qemu_set_log_internal() is adapted to open a per-thread log file when '-d tid' is passed. This is done by hijacking qemu_try_lock() which seems simpler that refactoring the code. Signed-off-by: Greg Kurz Message-Id: <20221108140032.1460307-3-groug@kaod.org> Signed-off-by: Paolo Bonzini commit 59bde2137445b63c822720d069d91d38190c6540 Author: Paolo Bonzini Date: Tue Nov 8 15:00:31 2022 +0100 util/log: do not close and reopen log files when flags are turned off log_append makes sure that if you turn off the logging (which clears log_flags and makes need_to_open_file false) the old log is not overwritten. The usecase is that if you remove or move the file QEMU will not keep writing to the old file. However, this is not always the desited behavior, in particular having log_append==1 after changing the file name makes little sense. When qemu_set_log_internal is called from the logfile monitor command, filename must be non-NULL and therefore changed_name must be true. Therefore, the only case where the file is closed and need_to_open_file == false is indeed when log_flags becomes zero. In this case, just flush the file and do not bother closing it, thus faking the same append behavior as previously. The behavioral change is that changing the logfile twice, for example log1 -> log2 -> log1, will cause log1 to be overwritten. This can simply be documented, since it is not a particularly surprising behavior. Suggested-by: Alex Bennée Signed-off-by: Paolo Bonzini Reviewed-by: Richard Henderson Reviewed-by: Greg Kurz Message-Id: <20221025092119.236224-1-pbonzini@redhat.com> [groug: nullify global_file before actually closing the file] Signed-off-by: Greg Kurz Message-Id: <20221108140032.1460307-2-groug@kaod.org> Signed-off-by: Paolo Bonzini commit cc6ff741123216550997b12cdd991beeed47bd0d Author: Philippe Mathieu-Daudé Date: Wed Nov 30 14:56:41 2022 +0100 hw: Reduce "qemu/accel.h" inclusion Move "qemu/accel.h" include from the heavily included "hw/boards.h" to hw/core/machine.c, the single file using the AccelState definition. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Fabiano Rosas Message-Id: <20221130135641.85328-3-philmd@linaro.org> Signed-off-by: Paolo Bonzini commit 3d277871f39d4de42f56b7b0cef5721e525b2d31 Author: Philippe Mathieu-Daudé Date: Wed Nov 30 14:56:40 2022 +0100 typedefs: Forward-declare AccelState Forward-declare AccelState in "qemu/typedefs.h" so structures using a reference of it (like MachineState in "hw/boards.h") don't have to include "qemu/accel.h". Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Fabiano Rosas Message-Id: <20221130135641.85328-2-philmd@linaro.org> Signed-off-by: Paolo Bonzini Revision graph left in /home/logs/results/bisect/qemu-mainline/build-i386.xen-build.{dot,ps,png,html,svg}. ---------------------------------------- 175667: tolerable ALL FAIL flight 175667 qemu-mainline real-bisect [real] http://logs.test-lab.xenproject.org/osstest/logs/175667/ Failures :-/ but no regressions. Tests which did not succeed, including tests which could not be run: build-i386 6 xen-build fail baseline untested jobs: build-i386 fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary From xen-devel-bounces@lists.xenproject.org Mon Jan 09 23:29:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 23:29:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474116.735058 (Exim 4.92) (envelope-from ) id 1pF1Zc-0004eT-Dl; Mon, 09 Jan 2023 23:29:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474116.735058; Mon, 09 Jan 2023 23:29:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF1Zc-0004eM-9g; Mon, 09 Jan 2023 23:29:00 +0000 Received: by outflank-mailman (input) for mailman id 474116; Mon, 09 Jan 2023 23:28:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF1ZZ-0004eF-Uk for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 23:28:58 +0000 Received: from sonic311-25.consmr.mail.gq1.yahoo.com (sonic311-25.consmr.mail.gq1.yahoo.com [98.137.65.206]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 60c807cb-9075-11ed-b8d0-410ff93cb8f0; Tue, 10 Jan 2023 00:28:54 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.gq1.yahoo.com with HTTP; Mon, 9 Jan 2023 23:28:52 +0000 Received: by hermes--production-ne1-7b69748c4d-g8q5j (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 71c008aaac249b928d42463620cb772e; Mon, 09 Jan 2023 23:28:47 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 60c807cb-9075-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1673306932; bh=0rNGSoRWRSYnXN1sucMLBASe31ssmBptcK0GtyMBgtY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=LL60Xu8nvrLq7p5WHbhl7D+xOw5Lf3YirLMgMhGxi+uCLwXiC1v/Gn7eHlB54U0ejQ1aI3Fmc2GWJEJ7qcYjS7IMV1XYqPfftAnV+2PcNnL/iZf9O/f7SBX+NtalBVJSxzZv5nO/esK9GIYyw1dVmUYjW4Vos2tbMb4hN5Nz69zYSLyR+/CPI52n3bXYcIVfOVdjQcjInghS12UbMJdjWmEgAI8Qc32BfbSBhIDMnf45RaI7B+w28e+S9lp19tzuvppxqANgMfRum9eM90Bhw3NXh9t10QdzsLVQRtbBkH8W2TfPedET9kX0i9dwmcsyUVi6Z3RomG0lqSEzgMQazA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1673306932; bh=kD/AoFy5IB1tKFWmzyI4mNYcXIY4+IXvNvwP4zZ19aT=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=f5LYYnxs87oMTlIihCwgCII2apF4ULUME2UUD/cWpOGhkv4NKjTuXZgEqahTBWcDriiSOv1tchnqnGaI1A8cD/OYhY23IYYq7C0YayO8KsqDnNq9El19OAIEtlu16Pr+zYUVjZLH1qevDUY3NIS4BSGJ1ym5rRGTvAPFExhmtaJHLYSOLkK5EFWMmjWL+SfxjCfP2L5a/Gi+xdmJpe9wO6nx4SussD2sN8K5z/DlyXo306zscnJjBSeiArwkKw1LX+kBGZO7x9F2WQMOQu+I9BEtXUpdeeKSMdsDRj6s16nm52evyNJnzVhfmgsv64d76hdBvdArf6m/AvwU88a6Cg== X-YMail-OSG: EVJ7IyoVM1nPiTEhoWVTpOh3ClkvNmucZ0pYiS.kzUE8a3aKrFGfHbqoGOOlmr9 ec9VMkCd79k80WI8D2AfOWAhcTriyrV4NlXYTYxXLRsitDphRfTWlZ1Se1XMihQDKI_0_FRPKWom sNcHDOlKzFO6Gpqpn8.Or54J.midAVSb2c3OLfU5ePGUpBlVdOEqBaRV7miUtSGeE_zjzktP6m7. JQ1HQjx9P5UpDO2WgUmTpEZY4e35GDhYX6OYy4dxmk211f.Cr2zHcvh6766.2rpN2JKEfhF2GDap pXjjYONOFyDRLhDUOZRHgoOnBYKT0XggfRlpvhnlxheeBcTLRgAKnYFjsfdObNlvr3RHz_1HBBPB psxMESVmwpQH9.3phlz3yjw33lUWRvN4McRoeDbMBS4tfTxnRgJHMQjEYGwcG.EhZcfv_PIUbrHW CjYj_U9MDzZKRyJ.MVxu0NQIG4JuyVNZrrkRHOt3lAQSSFaFGJ9SjWg8WbItmKKlPAbSfzjzG_t1 RnUXMP5.5EfD10EAz8gh2IDzVv0zzO.hfEds.ggru0dAbGdnE4kFQJG8T_jGG5MhbX1FfeqyPrxD Nnu4FYaF_KPUMlmM0UJiHUlvaZ6PL3dwHH9s4fr11iSBJnlp7wLxVWV0SEIE4i4_AA3MtPQAjrtR qUuIa9Ft2WCa08FHC1kI6OeVk52SboWppKTX7BOyB17E1S.YSIUHhnDZX5W53ABONd8oWf9rQ00Z YZr2qUE.GYwyCpUkSjbpojXqBvCS.tADKQqr6wjLEqpIDHB1rJoe..iXdxcRDgg8vDjSsou5iLew .refke8_q9zNTJZcQfl8dZzV.4Ri8FYRk3G.nbY1zNNhynG7s69hkvPqAJspqiaecpwbXZ6K_ApQ 0NfrdYQNbGhD809dD0iw02lLnGENMmPaYE1L8Q9Th9u7HOi5UgjiCWrHvlbhzEIv.RulnNg7Q80k T7fS8WTm1anRA6WaTiLFM99Vk5GOcvxZh35Ud9BvCokF3FAXsbYr9VRvX99XC3iK0azeaE0E3Eeo M9YHJcY.0d7odEhYVIKUBVznFv0xAI4BHDkJqBQd9J6HOWQRec7lpIugrsQs1HMgb1GgfYeHFLML dncg_e7pR1n3qWw9OSI9Iu0ZnGzGFq3JMQKQMq_MTtzvVb7HuUVTPBxt.ErofgO_ITgLRqqwZ_Ca X7E9Wt20KrMCr0zT_UxX79IROM6gIh2c1MPV7f0QG7xhOEqIuPvvZUMfk4kcQL3b_SlhTy5wGbzg J9pjPWTIeggyYazgxaOb9f9_2qKdpJ0bhghyp0ZxmKoE30XiCG6fiXinYd_RNX7p_0k2pf54eAiu RHUyu3TAj3_uQ3ccLMleTt.CkCI9HxeFtVuU9qX2ONM66kh3CkIQReXuyiQdk2WiL073OETLu0cF kRlrUHyFB7yHkakobSO09egjP_Ihtp4Nyw_ihIraImUGARgpxILHFBTABEOl1v0BlqHZZ9DED50f 2NF7.VLdhoXLlTecgvy8hYOIZ.KLBi1S72DOp6VBGa53.iMmWSU7916p7ZCL4XuppxiRm7CGhPYs zatQ90GOYCf583DB7p0Ry8u_uuhYlOQ9BfsPhmzfJepRUoDMpEKVkWfk_rrITxQUvGsS.L5cFZxl ._hsh.HGgUWAm5Izpub6NZP_exTZ5lPcMApO3D6Sa6SxgtAirpfGweIoDqjSQMj5FBEVWSX.vmaq MIQHCfcXHrYT6j2x_08M5UELGgtWRErV2qaz1WXdjWfmhQGTjQRAxDyNkOeD8xbokXODYK0LOyCf 4VNMbGaVnB7CRue0oet3WQ92gZ_GFxiWPR7Hnw4GIso9H4sByrkjBk04Vv0oGpBMFmLV6wvjjhAR Sq2_aodo5x1PXmW4gysS5KZhtmf4LfK5xeLS4oqoDpfxHlAtwQrJMqGaSkVCoemsw6sm_MWYE2zj BpziyjQsnziCsjeft8qKpKLom_KNK38.xxbysA5snKBbKYqKfjHCnv8KwWaeqkvYHwqCJR0U6ojn sf9_2SwNOW_kYLLug40kLWOZWE3YVdyepESfBRlzR5jEIl2yBrLrRiQ3CcdC0xxuOmw0taRMgB0P yO1qrXEuVRRlZp4wv5eKVQ5..sY9.rBwVSoJBuFep8bvAaJjgbGt8lrrCpSiYPKr9kXRO.vP4bGE r2fB4YJ_ypgKEgLYaqQ1LZvh7IRhlSXoAIIZZbr6qHJhp6xtkIraqmo3n_kGuT7giXjpZGJr3uAm VYhhzaxPQnFHMQg65P_I- X-Sonic-MF: Message-ID: <8c2531a8-ce99-7593-99f8-222076fe6bd6@aol.com> Date: Mon, 9 Jan 2023 18:28:44 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v7] xen/pt: reserve PCI slot 2 for Intel igd-passthru To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org, Stefano Stabellini , Anthony Perard , Paul Durrant , Paolo Bonzini , Richard Henderson , Eduardo Habkost , Marcel Apfelbaum , xen-devel@lists.xenproject.org References: <8349506149de6d81b0762f17623552c248439e93.1673297742.git.brchuckz.ref@aol.com> <8349506149de6d81b0762f17623552c248439e93.1673297742.git.brchuckz@aol.com> <20230109172738-mutt-send-email-mst@kernel.org> Content-Language: en-US From: Chuck Zmudzinski In-Reply-To: <20230109172738-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.20982 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 22856 On 1/9/23 5:33 PM, Michael S. Tsirkin wrote: > On Mon, Jan 09, 2023 at 04:55:42PM -0500, Chuck Zmudzinski wrote: >> Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, >> as noted in docs/igd-assign.txt in the Qemu source code. >> >> Currently, when the xl toolstack is used to configure a Xen HVM guest with >> Intel IGD passthrough to the guest with the Qemu upstream device model, >> a Qemu emulated PCI device will occupy slot 2 and the Intel IGD will occupy >> a different slot. This problem often prevents the guest from booting. >> >> The only available workaround is not good: Configure Xen HVM guests to use >> the old and no longer maintained Qemu traditional device model available >> from xenbits.xen.org which does reserve slot 2 for the Intel IGD. >> >> To implement this feature in the Qemu upstream device model for Xen HVM >> guests, introduce the following new functions, types, and macros: >> >> * XEN_PT_DEVICE_CLASS declaration, based on the existing TYPE_XEN_PT_DEVICE >> * XEN_PT_DEVICE_GET_CLASS macro helper function for XEN_PT_DEVICE_CLASS >> * typedef XenPTQdevRealize function pointer >> * XEN_PCI_IGD_SLOT_MASK, the value of slot_reserved_mask to reserve slot 2 >> * xen_igd_reserve_slot and xen_igd_clear_slot functions >> >> The new xen_igd_reserve_slot function uses the existing slot_reserved_mask >> member of PCIBus to reserve PCI slot 2 for Xen HVM guests configured using >> the xl toolstack with the gfx_passthru option enabled, which sets the >> igd-passthru=on option to Qemu for the Xen HVM machine type. > > I don't like how slot_reserved_mask is set initially then cleared on > device realize. > To me this looks like a fragile hack. I suggest one of the following > 1. adding a new mask > "slot-manual-mask" or some such blocking auto-allocation of a given > slot without blocking its use if address is specified on command line. > 2. adding a special property that overrides slot_reserved_mask > for a given device. > > both need changes in pci core but look like something generally > useful. I was hoping to not need to touch pci core but I understand it would be better for this patch to not affect machines that are manually configured on the command line. However, keep in mind that this patch will only actually reserve the slot initially for xen hvm machines (machine type "xenfv") that also are configured with the qemu igd-passthru=on option which, AFAIK, only applies to machines witn accel=xen. It will not affect kvm users at all. So I don't think this patch will break many machines out there that manually specify the pci slots. The only machines it could affect are machines configured for igd-passthru on xen. This patch also does *not* reserve the slot initially for "xenfv" machines that are not configured with igd passthrough which I am sure is the vast majority of all the xen virtual machines out in the wild. > > >> >> The new xen_igd_reserve_slot function also needs to be implemented in >> hw/xen/xen_pt_stub.c to prevent FTBFS during the link stage for the case >> when Qemu is configured with --enable-xen and --disable-xen-pci-passthrough, >> in which case it does nothing. >> >> The new xen_igd_clear_slot function overrides qdev->realize of the parent >> PCI device class to enable the Intel IGD to occupy slot 2 on the PCI bus >> since slot 2 was reserved by xen_igd_reserve_slot when the PCI bus was >> created in hw/i386/pc_piix.c for the case when igd-passthru=on. >> >> Move the call to xen_host_pci_device_get, and the associated error >> handling, from xen_pt_realize to the new xen_igd_clear_slot function to >> initialize the device class and vendor values which enables the checks for >> the Intel IGD to succeed. The verification that the host device is an >> Intel IGD to be passed through is done by checking the domain, bus, slot, >> and function values as well as by checking that gfx_passthru is enabled, >> the device class is VGA, and the device vendor in Intel. >> >> Signed-off-by: Chuck Zmudzinski >> --- >> Notes that might be helpful to reviewers of patched code in hw/xen: >> >> The new functions and types are based on recommendations from Qemu docs: >> https://qemu.readthedocs.io/en/latest/devel/qom.html >> >> Notes that might be helpful to reviewers of patched code in hw/i386: >> >> The small patch to hw/i386/pc_piix.c is protected by CONFIG_XEN so it does >> not affect builds that do not have CONFIG_XEN defined. >> >> xen_igd_gfx_pt_enabled() in the patched hw/i386/pc_piix.c file is an >> existing function that is only true when Qemu is built with >> xen-pci-passthrough enabled and the administrator has configured the Xen >> HVM guest with Qemu's igd-passthru=on option. >> >> v2: Remove From: tag at top of commit message >> >> v3: Changed the test for the Intel IGD in xen_igd_clear_slot: >> >> if (is_igd_vga_passthrough(&s->real_device) && >> (s->real_device.vendor_id == PCI_VENDOR_ID_INTEL)) { >> >> is changed to >> >> if (xen_igd_gfx_pt_enabled() && (s->hostaddr.slot == 2) >> && (s->hostaddr.function == 0)) { >> >> I hoped that I could use the test in v2, since it matches the >> other tests for the Intel IGD in Qemu and Xen, but those tests >> do not work because the necessary data structures are not set with >> their values yet. So instead use the test that the administrator >> has enabled gfx_passthru and the device address on the host is >> 02.0. This test does detect the Intel IGD correctly. >> >> v4: Use brchuckz@aol.com instead of brchuckz@netscape.net for the author's >> email address to match the address used by the same author in commits >> be9c61da and c0e86b76 >> >> Change variable for XEN_PT_DEVICE_CLASS: xptc changed to xpdc >> >> v5: The patch of xen_pt.c was re-worked to allow a more consistent test >> for the Intel IGD that uses the same criteria as in other places. >> This involved moving the call to xen_host_pci_device_get from >> xen_pt_realize to xen_igd_clear_slot and updating the checks for the >> Intel IGD in xen_igd_clear_slot: >> >> if (xen_igd_gfx_pt_enabled() && (s->hostaddr.slot == 2) >> && (s->hostaddr.function == 0)) { >> >> is changed to >> >> if (is_igd_vga_passthrough(&s->real_device) && >> s->real_device.domain == 0 && s->real_device.bus == 0 && >> s->real_device.dev == 2 && s->real_device.func == 0 && >> s->real_device.vendor_id == PCI_VENDOR_ID_INTEL) { >> >> Added an explanation for the move of xen_host_pci_device_get from >> xen_pt_realize to xen_igd_clear_slot to the commit message. >> >> Rebase. >> >> v6: Fix logging by removing these lines from the move from xen_pt_realize >> to xen_igd_clear_slot that was done in v5: >> >> XEN_PT_LOG(d, "Assigning real physical device %02x:%02x.%d" >> " to devfn 0x%x\n", >> s->hostaddr.bus, s->hostaddr.slot, s->hostaddr.function, >> s->dev.devfn); >> >> This log needs to be in xen_pt_realize because s->dev.devfn is not >> set yet in xen_igd_clear_slot. >> >> v7: Inhibit out of context log message and needless processing by >> adding 2 lines at the top of the new xen_igd_clear_slot function: >> >> if (!(pci_bus->slot_reserved_mask & XEN_PCI_IGD_SLOT_MASK)) >> return; >> >> Rebase. This removed an unnecessary header file from xen_pt.h >> >> hw/i386/pc_piix.c | 127 ++++++++++++++++++++++++++++++++----------- >> hw/xen/xen_pt.c | 49 ++++++++++++++--- >> hw/xen/xen_pt.h | 16 ++++++ >> hw/xen/xen_pt_stub.c | 4 ++ >> 4 files changed, 154 insertions(+), 42 deletions(-) >> >> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c >> index b48047f50c..34a9736b5e 100644 >> --- a/hw/i386/pc_piix.c >> +++ b/hw/i386/pc_piix.c >> @@ -32,6 +32,7 @@ >> #include "hw/i386/pc.h" >> #include "hw/i386/apic.h" >> #include "hw/pci-host/i440fx.h" >> +#include "hw/rtc/mc146818rtc.h" >> #include "hw/southbridge/piix.h" >> #include "hw/display/ramfb.h" >> #include "hw/firmware/smbios.h" >> @@ -40,16 +41,16 @@ >> #include "hw/usb.h" >> #include "net/net.h" >> #include "hw/ide/pci.h" >> -#include "hw/ide/piix.h" >> #include "hw/irq.h" >> #include "sysemu/kvm.h" >> #include "hw/kvm/clock.h" >> #include "hw/sysbus.h" >> +#include "hw/i2c/i2c.h" >> #include "hw/i2c/smbus_eeprom.h" >> #include "hw/xen/xen-x86.h" >> +#include "hw/xen/xen.h" >> #include "exec/memory.h" >> #include "hw/acpi/acpi.h" >> -#include "hw/acpi/piix4.h" >> #include "qapi/error.h" >> #include "qemu/error-report.h" >> #include "sysemu/xen.h" >> @@ -66,6 +67,7 @@ >> #include "kvm/kvm-cpu.h" >> >> #define MAX_IDE_BUS 2 >> +#define XEN_IOAPIC_NUM_PIRQS 128ULL >> >> #ifdef CONFIG_IDE_ISA >> static const int ide_iobase[MAX_IDE_BUS] = { 0x1f0, 0x170 }; >> @@ -73,6 +75,32 @@ static const int ide_iobase2[MAX_IDE_BUS] = { 0x3f6, 0x376 }; >> static const int ide_irq[MAX_IDE_BUS] = { 14, 15 }; >> #endif >> >> +/* >> + * Return the global irq number corresponding to a given device irq >> + * pin. We could also use the bus number to have a more precise mapping. >> + */ >> +static int pci_slot_get_pirq(PCIDevice *pci_dev, int pci_intx) >> +{ >> + int slot_addend; >> + slot_addend = PCI_SLOT(pci_dev->devfn) - 1; >> + return (pci_intx + slot_addend) & 3; >> +} >> + >> +static void piix_intx_routing_notifier_xen(PCIDevice *dev) >> +{ >> + int i; >> + >> + /* Scan for updates to PCI link routes (0x60-0x63). */ >> + for (i = 0; i < PIIX_NUM_PIRQS; i++) { >> + uint8_t v = dev->config_read(dev, PIIX_PIRQCA + i, 1); >> + if (v & 0x80) { >> + v = 0; >> + } >> + v &= 0xf; >> + xen_set_pci_link_route(i, v); >> + } >> +} >> + >> /* PC hardware initialisation */ >> static void pc_init1(MachineState *machine, >> const char *host_type, const char *pci_type) >> @@ -84,7 +112,7 @@ static void pc_init1(MachineState *machine, >> MemoryRegion *system_io = get_system_io(); >> PCIBus *pci_bus; >> ISABus *isa_bus; >> - int piix3_devfn = -1; >> + Object *piix4_pm; >> qemu_irq smi_irq; >> GSIState *gsi_state; >> BusState *idebus[MAX_IDE_BUS]; >> @@ -205,10 +233,9 @@ static void pc_init1(MachineState *machine, >> gsi_state = pc_gsi_create(&x86ms->gsi, pcmc->pci_enabled); >> >> if (pcmc->pci_enabled) { >> - PIIX3State *piix3; >> + DeviceState *dev; >> PCIDevice *pci_dev; >> - const char *type = xen_enabled() ? TYPE_PIIX3_XEN_DEVICE >> - : TYPE_PIIX3_DEVICE; >> + int i; >> >> pci_bus = i440fx_init(pci_type, >> i440fx_host, >> @@ -216,21 +243,65 @@ static void pc_init1(MachineState *machine, >> x86ms->below_4g_mem_size, >> x86ms->above_4g_mem_size, >> pci_memory, ram_memory); >> + pci_bus_map_irqs(pci_bus, >> + xen_enabled() ? xen_pci_slot_get_pirq >> + : pci_slot_get_pirq); >> pcms->bus = pci_bus; >> >> - pci_dev = pci_create_simple_multifunction(pci_bus, -1, true, type); >> - piix3 = PIIX3_PCI_DEVICE(pci_dev); >> - piix3->pic = x86ms->gsi; >> - piix3_devfn = piix3->dev.devfn; >> - isa_bus = ISA_BUS(qdev_get_child_bus(DEVICE(piix3), "isa.0")); >> + pci_dev = pci_new_multifunction(-1, true, TYPE_PIIX3_DEVICE); >> + object_property_set_bool(OBJECT(pci_dev), "has-usb", >> + machine_usb(machine), &error_abort); >> + object_property_set_bool(OBJECT(pci_dev), "has-acpi", >> + x86_machine_is_acpi_enabled(x86ms), >> + &error_abort); >> + qdev_prop_set_uint32(DEVICE(pci_dev), "smb_io_base", 0xb100); >> + object_property_set_bool(OBJECT(pci_dev), "smm-enabled", >> + x86_machine_is_smm_enabled(x86ms), >> + &error_abort); >> + pci_realize_and_unref(pci_dev, pci_bus, &error_fatal); >> + >> + if (xen_enabled()) { >> + pci_device_set_intx_routing_notifier( >> + pci_dev, piix_intx_routing_notifier_xen); >> + >> + /* >> + * Xen supports additional interrupt routes from the PCI devices to >> + * the IOAPIC: the four pins of each PCI device on the bus are also >> + * connected to the IOAPIC directly. >> + * These additional routes can be discovered through ACPI. >> + */ >> + pci_bus_irqs(pci_bus, xen_intx_set_irq, pci_dev, >> + XEN_IOAPIC_NUM_PIRQS); >> + } >> + >> + dev = DEVICE(object_resolve_path_component(OBJECT(pci_dev), "pic")); >> + for (i = 0; i < ISA_NUM_IRQS; i++) { >> + qdev_connect_gpio_out(dev, i, x86ms->gsi[i]); >> + } >> + isa_bus = ISA_BUS(qdev_get_child_bus(DEVICE(pci_dev), "isa.0")); >> + rtc_state = ISA_DEVICE(object_resolve_path_component(OBJECT(pci_dev), >> + "rtc")); >> + piix4_pm = object_resolve_path_component(OBJECT(pci_dev), "pm"); >> + dev = DEVICE(object_resolve_path_component(OBJECT(pci_dev), "ide")); >> + pci_ide_create_devs(PCI_DEVICE(dev)); >> + idebus[0] = qdev_get_child_bus(dev, "ide.0"); >> + idebus[1] = qdev_get_child_bus(dev, "ide.1"); >> } else { >> pci_bus = NULL; >> + piix4_pm = NULL; >> isa_bus = isa_bus_new(NULL, get_system_memory(), system_io, >> &error_abort); >> + isa_bus_irqs(isa_bus, x86ms->gsi); >> + >> + rtc_state = isa_new(TYPE_MC146818_RTC); >> + qdev_prop_set_int32(DEVICE(rtc_state), "base_year", 2000); >> + isa_realize_and_unref(rtc_state, isa_bus, &error_fatal); >> + >> i8257_dma_init(isa_bus, 0); >> pcms->hpet_enabled = false; >> + idebus[0] = NULL; >> + idebus[1] = NULL; >> } >> - isa_bus_irqs(isa_bus, x86ms->gsi); >> >> if (x86ms->pic == ON_OFF_AUTO_ON || x86ms->pic == ON_OFF_AUTO_AUTO) { >> pc_i8259_create(isa_bus, gsi_state->i8259_irq); >> @@ -252,18 +323,12 @@ static void pc_init1(MachineState *machine, >> } >> >> /* init basic PC hardware */ >> - pc_basic_device_init(pcms, isa_bus, x86ms->gsi, &rtc_state, true, >> + pc_basic_device_init(pcms, isa_bus, x86ms->gsi, rtc_state, true, >> 0x4); >> >> pc_nic_init(pcmc, isa_bus, pci_bus); >> >> if (pcmc->pci_enabled) { >> - PCIDevice *dev; >> - >> - dev = pci_create_simple(pci_bus, piix3_devfn + 1, TYPE_PIIX3_IDE); >> - pci_ide_create_devs(dev); >> - idebus[0] = qdev_get_child_bus(&dev->qdev, "ide.0"); >> - idebus[1] = qdev_get_child_bus(&dev->qdev, "ide.1"); >> pc_cmos_init(pcms, idebus[0], idebus[1], rtc_state); >> } >> #ifdef CONFIG_IDE_ISA >> @@ -289,21 +354,9 @@ static void pc_init1(MachineState *machine, >> } >> #endif >> >> - if (pcmc->pci_enabled && machine_usb(machine)) { >> - pci_create_simple(pci_bus, piix3_devfn + 2, "piix3-usb-uhci"); >> - } >> - >> - if (pcmc->pci_enabled && x86_machine_is_acpi_enabled(X86_MACHINE(pcms))) { >> - PCIDevice *piix4_pm; >> - >> + if (piix4_pm) { >> smi_irq = qemu_allocate_irq(pc_acpi_smi_interrupt, first_cpu, 0); >> - piix4_pm = pci_new(piix3_devfn + 3, TYPE_PIIX4_PM); >> - qdev_prop_set_uint32(DEVICE(piix4_pm), "smb_io_base", 0xb100); >> - qdev_prop_set_bit(DEVICE(piix4_pm), "smm-enabled", >> - x86_machine_is_smm_enabled(x86ms)); >> - pci_realize_and_unref(piix4_pm, pci_bus, &error_fatal); >> >> - qdev_connect_gpio_out(DEVICE(piix4_pm), 0, x86ms->gsi[9]); >> qdev_connect_gpio_out_named(DEVICE(piix4_pm), "smi-irq", 0, smi_irq); >> pcms->smbus = I2C_BUS(qdev_get_child_bus(DEVICE(piix4_pm), "i2c")); >> /* TODO: Populate SPD eeprom data. */ >> @@ -315,7 +368,7 @@ static void pc_init1(MachineState *machine, >> object_property_allow_set_link, >> OBJ_PROP_LINK_STRONG); >> object_property_set_link(OBJECT(machine), PC_MACHINE_ACPI_DEVICE_PROP, >> - OBJECT(piix4_pm), &error_abort); >> + piix4_pm, &error_abort); >> } >> >> if (machine->nvdimms_state->is_enabled) { >> @@ -405,6 +458,9 @@ static void pc_xen_hvm_init(MachineState *machine) >> } >> >> pc_xen_hvm_init_pci(machine); >> + if (xen_igd_gfx_pt_enabled()) { >> + xen_igd_reserve_slot(pcms->bus); >> + } >> pci_create_simple(pcms->bus, -1, "xen-platform"); >> } >> #endif >> @@ -441,6 +497,11 @@ static void pc_i440fx_8_0_machine_options(MachineClass *m) >> pc_i440fx_machine_options(m); >> m->alias = "pc"; >> m->is_default = true; >> +#ifdef CONFIG_MICROVM_DEFAULT >> + m->is_default = false; >> +#else >> + m->is_default = true; >> +#endif >> } >> >> DEFINE_I440FX_MACHINE(v8_0, "pc-i440fx-8.0", NULL, >> diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c >> index 0ec7e52183..eff38155ef 100644 >> --- a/hw/xen/xen_pt.c >> +++ b/hw/xen/xen_pt.c >> @@ -780,15 +780,6 @@ static void xen_pt_realize(PCIDevice *d, Error **errp) >> s->hostaddr.bus, s->hostaddr.slot, s->hostaddr.function, >> s->dev.devfn); >> >> - xen_host_pci_device_get(&s->real_device, >> - s->hostaddr.domain, s->hostaddr.bus, >> - s->hostaddr.slot, s->hostaddr.function, >> - errp); >> - if (*errp) { >> - error_append_hint(errp, "Failed to \"open\" the real pci device"); >> - return; >> - } >> - >> s->is_virtfn = s->real_device.is_virtfn; >> if (s->is_virtfn) { >> XEN_PT_LOG(d, "%04x:%02x:%02x.%d is a SR-IOV Virtual Function\n", >> @@ -950,11 +941,50 @@ static void xen_pci_passthrough_instance_init(Object *obj) >> PCI_DEVICE(obj)->cap_present |= QEMU_PCI_CAP_EXPRESS; >> } >> >> +void xen_igd_reserve_slot(PCIBus *pci_bus) >> +{ >> + XEN_PT_LOG(0, "Reserving PCI slot 2 for IGD\n"); >> + pci_bus->slot_reserved_mask |= XEN_PCI_IGD_SLOT_MASK; >> +} >> + >> +static void xen_igd_clear_slot(DeviceState *qdev, Error **errp) >> +{ >> + ERRP_GUARD(); >> + PCIDevice *pci_dev = (PCIDevice *)qdev; >> + XenPCIPassthroughState *s = XEN_PT_DEVICE(pci_dev); >> + XenPTDeviceClass *xpdc = XEN_PT_DEVICE_GET_CLASS(s); >> + PCIBus *pci_bus = pci_get_bus(pci_dev); >> + >> + if (!(pci_bus->slot_reserved_mask & XEN_PCI_IGD_SLOT_MASK)) >> + return; >> + >> + xen_host_pci_device_get(&s->real_device, >> + s->hostaddr.domain, s->hostaddr.bus, >> + s->hostaddr.slot, s->hostaddr.function, >> + errp); >> + if (*errp) { >> + error_append_hint(errp, "Failed to \"open\" the real pci device"); >> + return; >> + } >> + >> + if (is_igd_vga_passthrough(&s->real_device) && >> + s->real_device.domain == 0 && s->real_device.bus == 0 && >> + s->real_device.dev == 2 && s->real_device.func == 0 && >> + s->real_device.vendor_id == PCI_VENDOR_ID_INTEL) { >> + pci_bus->slot_reserved_mask &= ~XEN_PCI_IGD_SLOT_MASK; >> + XEN_PT_LOG(pci_dev, "Intel IGD found, using slot 2\n"); >> + } >> + xpdc->pci_qdev_realize(qdev, errp); >> +} >> + >> static void xen_pci_passthrough_class_init(ObjectClass *klass, void *data) >> { >> DeviceClass *dc = DEVICE_CLASS(klass); >> PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); >> >> + XenPTDeviceClass *xpdc = XEN_PT_DEVICE_CLASS(klass); >> + xpdc->pci_qdev_realize = dc->realize; >> + dc->realize = xen_igd_clear_slot; >> k->realize = xen_pt_realize; >> k->exit = xen_pt_unregister_device; >> k->config_read = xen_pt_pci_read_config; >> @@ -977,6 +1007,7 @@ static const TypeInfo xen_pci_passthrough_info = { >> .instance_size = sizeof(XenPCIPassthroughState), >> .instance_finalize = xen_pci_passthrough_finalize, >> .class_init = xen_pci_passthrough_class_init, >> + .class_size = sizeof(XenPTDeviceClass), >> .instance_init = xen_pci_passthrough_instance_init, >> .interfaces = (InterfaceInfo[]) { >> { INTERFACE_CONVENTIONAL_PCI_DEVICE }, >> diff --git a/hw/xen/xen_pt.h b/hw/xen/xen_pt.h >> index cf10fc7bbf..8c25932b4b 100644 >> --- a/hw/xen/xen_pt.h >> +++ b/hw/xen/xen_pt.h >> @@ -2,6 +2,7 @@ >> #define XEN_PT_H >> >> #include "hw/xen/xen_common.h" >> +#include "hw/pci/pci_bus.h" >> #include "xen-host-pci-device.h" >> #include "qom/object.h" >> >> @@ -40,7 +41,20 @@ typedef struct XenPTReg XenPTReg; >> #define TYPE_XEN_PT_DEVICE "xen-pci-passthrough" >> OBJECT_DECLARE_SIMPLE_TYPE(XenPCIPassthroughState, XEN_PT_DEVICE) >> >> +#define XEN_PT_DEVICE_CLASS(klass) \ >> + OBJECT_CLASS_CHECK(XenPTDeviceClass, klass, TYPE_XEN_PT_DEVICE) >> +#define XEN_PT_DEVICE_GET_CLASS(obj) \ >> + OBJECT_GET_CLASS(XenPTDeviceClass, obj, TYPE_XEN_PT_DEVICE) >> + >> +typedef void (*XenPTQdevRealize)(DeviceState *qdev, Error **errp); >> + >> +typedef struct XenPTDeviceClass { >> + PCIDeviceClass parent_class; >> + XenPTQdevRealize pci_qdev_realize; >> +} XenPTDeviceClass; >> + >> uint32_t igd_read_opregion(XenPCIPassthroughState *s); >> +void xen_igd_reserve_slot(PCIBus *pci_bus); >> void igd_write_opregion(XenPCIPassthroughState *s, uint32_t val); >> void xen_igd_passthrough_isa_bridge_create(XenPCIPassthroughState *s, >> XenHostPCIDevice *dev); >> @@ -75,6 +89,8 @@ typedef int (*xen_pt_conf_byte_read) >> >> #define XEN_PCI_INTEL_OPREGION 0xfc >> >> +#define XEN_PCI_IGD_SLOT_MASK 0x4UL /* Intel IGD slot_reserved_mask */ >> + >> typedef enum { >> XEN_PT_GRP_TYPE_HARDWIRED = 0, /* 0 Hardwired reg group */ >> XEN_PT_GRP_TYPE_EMU, /* emul reg group */ >> diff --git a/hw/xen/xen_pt_stub.c b/hw/xen/xen_pt_stub.c >> index 2d8cac8d54..5c108446a8 100644 >> --- a/hw/xen/xen_pt_stub.c >> +++ b/hw/xen/xen_pt_stub.c >> @@ -20,3 +20,7 @@ void xen_igd_gfx_pt_set(bool value, Error **errp) >> error_setg(errp, "Xen PCI passthrough support not built in"); >> } >> } >> + >> +void xen_igd_reserve_slot(PCIBus *pci_bus) >> +{ >> +} >> -- >> 2.39.0 > From xen-devel-bounces@lists.xenproject.org Mon Jan 09 23:33:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 23:33:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474124.735075 (Exim 4.92) (envelope-from ) id 1pF1eF-00064o-Vn; Mon, 09 Jan 2023 23:33:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474124.735075; Mon, 09 Jan 2023 23:33:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF1eF-00064h-T7; Mon, 09 Jan 2023 23:33:47 +0000 Received: by outflank-mailman (input) for mailman id 474124; Mon, 09 Jan 2023 23:33:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF1eE-00064b-Ir for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 23:33:46 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0e1be3c4-9076-11ed-91b6-6bf2151ebd3b; Tue, 10 Jan 2023 00:33:44 +0100 (CET) Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-645-gmyzOA9_M-e2Fq7cS1mCBA-1; Mon, 09 Jan 2023 18:33:42 -0500 Received: by mail-qt1-f199.google.com with SMTP id cm18-20020a05622a251200b003ad06656adaso1834303qtb.22 for ; Mon, 09 Jan 2023 15:33:42 -0800 (PST) Received: from redhat.com ([191.101.160.154]) by smtp.gmail.com with ESMTPSA id de19-20020a05620a371300b006fa16fe93bbsm6221201qkb.15.2023.01.09.15.33.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 15:33:40 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0e1be3c4-9076-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673307223; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PWTun7gSxXXaZNLHwrimRZlxaWoC/MDjCF+Tw/aPQTM=; b=FTOuhuPOeFSgEQPlcI2AUd3UcVw8WZqFJTPWaTfQYGzN0CsU765bdbZ6A1lIhbRod4WNUU YX4L5MQV7DQOQE6H9AREAC/onFqmJJiOlQP8B0PeTGGys6iLheU/q9175xTpU+if4bisLa i/tguOaWRum/I328wMaxAVNoSNwCa0U= X-MC-Unique: gmyzOA9_M-e2Fq7cS1mCBA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PWTun7gSxXXaZNLHwrimRZlxaWoC/MDjCF+Tw/aPQTM=; b=sdX9ndwDl5kmDAHiJz3KQevUwJzvMEkcji4lDewDi+bU3H9J1hXAwI8MUU2juG0E5i mPM+oRwWpMIsWNVPoRfVIuVd+0P2KZHfJUv0N1Ssrt1AR6J+PMmcFypNiKI2llai24y1 gM+SWT3uyHu/YeFLiyQOScC4xmBD+EjsU8qefvd8KHOh8cFZbcONHxBGYDLbj4wWDf2O Nc85sYcUvVkUY53/iHqauPm6SjynPpAx7Ae3P6FBbdxp1+BeIaT/muKPRjdxhBl07l2j XQ3SjlatFJ/KDQ6nMz2yX5CvGemyLmmUgWFu1H2I3SR4QpqbYHTKA9bsD58RMX/aONDo +ATw== X-Gm-Message-State: AFqh2kprRlxYUYvnHQ2aThTIc/ceRlLT8tfNK4JJMMazsVssmxYIaXdm ItGGZbRuIkpVa8n9z7R2q484RHPz+0htwQFIliZfNU2NrR/cD4dfwfxe+crCxlgqMZqNbJHBVBT GIcwe9tJ8VbC/yCDL1dbdaQj3YS0= X-Received: by 2002:a05:6214:4208:b0:4c7:2ab5:9268 with SMTP id nd8-20020a056214420800b004c72ab59268mr23099304qvb.12.1673307221553; Mon, 09 Jan 2023 15:33:41 -0800 (PST) X-Google-Smtp-Source: AMrXdXuVby5CmKuzjuLrLrmk9a1V/EZDhdj7ltp0WXPdabpLV9eoBzjA6L7KQkbuyuinh/yO8oAxKQ== X-Received: by 2002:a05:6214:4208:b0:4c7:2ab5:9268 with SMTP id nd8-20020a056214420800b004c72ab59268mr23099277qvb.12.1673307221171; Mon, 09 Jan 2023 15:33:41 -0800 (PST) Date: Mon, 9 Jan 2023 18:33:35 -0500 From: "Michael S. Tsirkin" To: Chuck Zmudzinski Cc: qemu-devel@nongnu.org, Stefano Stabellini , Anthony Perard , Paul Durrant , Paolo Bonzini , Richard Henderson , Eduardo Habkost , Marcel Apfelbaum , xen-devel@lists.xenproject.org Subject: Re: [PATCH v7] xen/pt: reserve PCI slot 2 for Intel igd-passthru Message-ID: <20230109183132-mutt-send-email-mst@kernel.org> References: <8349506149de6d81b0762f17623552c248439e93.1673297742.git.brchuckz.ref@aol.com> <8349506149de6d81b0762f17623552c248439e93.1673297742.git.brchuckz@aol.com> MIME-Version: 1.0 In-Reply-To: <8349506149de6d81b0762f17623552c248439e93.1673297742.git.brchuckz@aol.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jan 09, 2023 at 04:55:42PM -0500, Chuck Zmudzinski wrote: > Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, > as noted in docs/igd-assign.txt in the Qemu source code. > > Currently, when the xl toolstack is used to configure a Xen HVM guest with > Intel IGD passthrough to the guest with the Qemu upstream device model, > a Qemu emulated PCI device will occupy slot 2 and the Intel IGD will occupy > a different slot. This problem often prevents the guest from booting. > > The only available workaround is not good: Configure Xen HVM guests to use > the old and no longer maintained Qemu traditional device model available > from xenbits.xen.org which does reserve slot 2 for the Intel IGD. > > To implement this feature in the Qemu upstream device model for Xen HVM > guests, introduce the following new functions, types, and macros: > > * XEN_PT_DEVICE_CLASS declaration, based on the existing TYPE_XEN_PT_DEVICE > * XEN_PT_DEVICE_GET_CLASS macro helper function for XEN_PT_DEVICE_CLASS > * typedef XenPTQdevRealize function pointer > * XEN_PCI_IGD_SLOT_MASK, the value of slot_reserved_mask to reserve slot 2 > * xen_igd_reserve_slot and xen_igd_clear_slot functions > > The new xen_igd_reserve_slot function uses the existing slot_reserved_mask > member of PCIBus to reserve PCI slot 2 for Xen HVM guests configured using > the xl toolstack with the gfx_passthru option enabled, which sets the > igd-passthru=on option to Qemu for the Xen HVM machine type. > > The new xen_igd_reserve_slot function also needs to be implemented in > hw/xen/xen_pt_stub.c to prevent FTBFS during the link stage for the case > when Qemu is configured with --enable-xen and --disable-xen-pci-passthrough, > in which case it does nothing. > > The new xen_igd_clear_slot function overrides qdev->realize of the parent > PCI device class to enable the Intel IGD to occupy slot 2 on the PCI bus > since slot 2 was reserved by xen_igd_reserve_slot when the PCI bus was > created in hw/i386/pc_piix.c for the case when igd-passthru=on. > > Move the call to xen_host_pci_device_get, and the associated error > handling, from xen_pt_realize to the new xen_igd_clear_slot function to > initialize the device class and vendor values which enables the checks for > the Intel IGD to succeed. The verification that the host device is an > Intel IGD to be passed through is done by checking the domain, bus, slot, > and function values as well as by checking that gfx_passthru is enabled, > the device class is VGA, and the device vendor in Intel. > > Signed-off-by: Chuck Zmudzinski > --- > Notes that might be helpful to reviewers of patched code in hw/xen: > > The new functions and types are based on recommendations from Qemu docs: > https://qemu.readthedocs.io/en/latest/devel/qom.html > > Notes that might be helpful to reviewers of patched code in hw/i386: > > The small patch to hw/i386/pc_piix.c is protected by CONFIG_XEN so it does > not affect builds that do not have CONFIG_XEN defined. I'm not sure how you can claim that. ... > diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c > index b48047f50c..34a9736b5e 100644 > --- a/hw/i386/pc_piix.c > +++ b/hw/i386/pc_piix.c > @@ -32,6 +32,7 @@ > #include "hw/i386/pc.h" > #include "hw/i386/apic.h" > #include "hw/pci-host/i440fx.h" > +#include "hw/rtc/mc146818rtc.h" > #include "hw/southbridge/piix.h" > #include "hw/display/ramfb.h" > #include "hw/firmware/smbios.h" > @@ -40,16 +41,16 @@ > #include "hw/usb.h" > #include "net/net.h" > #include "hw/ide/pci.h" > -#include "hw/ide/piix.h" > #include "hw/irq.h" > #include "sysemu/kvm.h" > #include "hw/kvm/clock.h" > #include "hw/sysbus.h" > +#include "hw/i2c/i2c.h" > #include "hw/i2c/smbus_eeprom.h" > #include "hw/xen/xen-x86.h" > +#include "hw/xen/xen.h" > #include "exec/memory.h" > #include "hw/acpi/acpi.h" > -#include "hw/acpi/piix4.h" > #include "qapi/error.h" > #include "qemu/error-report.h" > #include "sysemu/xen.h" > @@ -66,6 +67,7 @@ > #include "kvm/kvm-cpu.h" > > #define MAX_IDE_BUS 2 > +#define XEN_IOAPIC_NUM_PIRQS 128ULL > > #ifdef CONFIG_IDE_ISA > static const int ide_iobase[MAX_IDE_BUS] = { 0x1f0, 0x170 }; > @@ -73,6 +75,32 @@ static const int ide_iobase2[MAX_IDE_BUS] = { 0x3f6, 0x376 }; > static const int ide_irq[MAX_IDE_BUS] = { 14, 15 }; > #endif > > +/* > + * Return the global irq number corresponding to a given device irq > + * pin. We could also use the bus number to have a more precise mapping. > + */ > +static int pci_slot_get_pirq(PCIDevice *pci_dev, int pci_intx) > +{ > + int slot_addend; > + slot_addend = PCI_SLOT(pci_dev->devfn) - 1; > + return (pci_intx + slot_addend) & 3; > +} > + > +static void piix_intx_routing_notifier_xen(PCIDevice *dev) > +{ > + int i; > + > + /* Scan for updates to PCI link routes (0x60-0x63). */ > + for (i = 0; i < PIIX_NUM_PIRQS; i++) { > + uint8_t v = dev->config_read(dev, PIIX_PIRQCA + i, 1); > + if (v & 0x80) { > + v = 0; > + } > + v &= 0xf; > + xen_set_pci_link_route(i, v); > + } > +} > + > /* PC hardware initialisation */ > static void pc_init1(MachineState *machine, > const char *host_type, const char *pci_type) > @@ -84,7 +112,7 @@ static void pc_init1(MachineState *machine, > MemoryRegion *system_io = get_system_io(); > PCIBus *pci_bus; > ISABus *isa_bus; > - int piix3_devfn = -1; > + Object *piix4_pm; > qemu_irq smi_irq; > GSIState *gsi_state; > BusState *idebus[MAX_IDE_BUS]; > @@ -205,10 +233,9 @@ static void pc_init1(MachineState *machine, > gsi_state = pc_gsi_create(&x86ms->gsi, pcmc->pci_enabled); > > if (pcmc->pci_enabled) { > - PIIX3State *piix3; > + DeviceState *dev; > PCIDevice *pci_dev; > - const char *type = xen_enabled() ? TYPE_PIIX3_XEN_DEVICE > - : TYPE_PIIX3_DEVICE; > + int i; > > pci_bus = i440fx_init(pci_type, > i440fx_host, > @@ -216,21 +243,65 @@ static void pc_init1(MachineState *machine, > x86ms->below_4g_mem_size, > x86ms->above_4g_mem_size, > pci_memory, ram_memory); > + pci_bus_map_irqs(pci_bus, > + xen_enabled() ? xen_pci_slot_get_pirq > + : pci_slot_get_pirq); > pcms->bus = pci_bus; > > - pci_dev = pci_create_simple_multifunction(pci_bus, -1, true, type); > - piix3 = PIIX3_PCI_DEVICE(pci_dev); > - piix3->pic = x86ms->gsi; > - piix3_devfn = piix3->dev.devfn; > - isa_bus = ISA_BUS(qdev_get_child_bus(DEVICE(piix3), "isa.0")); > + pci_dev = pci_new_multifunction(-1, true, TYPE_PIIX3_DEVICE); > + object_property_set_bool(OBJECT(pci_dev), "has-usb", > + machine_usb(machine), &error_abort); > + object_property_set_bool(OBJECT(pci_dev), "has-acpi", > + x86_machine_is_acpi_enabled(x86ms), > + &error_abort); > + qdev_prop_set_uint32(DEVICE(pci_dev), "smb_io_base", 0xb100); > + object_property_set_bool(OBJECT(pci_dev), "smm-enabled", > + x86_machine_is_smm_enabled(x86ms), > + &error_abort); > + pci_realize_and_unref(pci_dev, pci_bus, &error_fatal); > + > + if (xen_enabled()) { > + pci_device_set_intx_routing_notifier( > + pci_dev, piix_intx_routing_notifier_xen); > + > + /* > + * Xen supports additional interrupt routes from the PCI devices to > + * the IOAPIC: the four pins of each PCI device on the bus are also > + * connected to the IOAPIC directly. > + * These additional routes can be discovered through ACPI. > + */ > + pci_bus_irqs(pci_bus, xen_intx_set_irq, pci_dev, > + XEN_IOAPIC_NUM_PIRQS); > + } > + > + dev = DEVICE(object_resolve_path_component(OBJECT(pci_dev), "pic")); > + for (i = 0; i < ISA_NUM_IRQS; i++) { > + qdev_connect_gpio_out(dev, i, x86ms->gsi[i]); > + } > + isa_bus = ISA_BUS(qdev_get_child_bus(DEVICE(pci_dev), "isa.0")); > + rtc_state = ISA_DEVICE(object_resolve_path_component(OBJECT(pci_dev), > + "rtc")); > + piix4_pm = object_resolve_path_component(OBJECT(pci_dev), "pm"); > + dev = DEVICE(object_resolve_path_component(OBJECT(pci_dev), "ide")); > + pci_ide_create_devs(PCI_DEVICE(dev)); > + idebus[0] = qdev_get_child_bus(dev, "ide.0"); > + idebus[1] = qdev_get_child_bus(dev, "ide.1"); > } else { > pci_bus = NULL; > + piix4_pm = NULL; > isa_bus = isa_bus_new(NULL, get_system_memory(), system_io, > &error_abort); > + isa_bus_irqs(isa_bus, x86ms->gsi); > + > + rtc_state = isa_new(TYPE_MC146818_RTC); > + qdev_prop_set_int32(DEVICE(rtc_state), "base_year", 2000); > + isa_realize_and_unref(rtc_state, isa_bus, &error_fatal); > + > i8257_dma_init(isa_bus, 0); > pcms->hpet_enabled = false; > + idebus[0] = NULL; > + idebus[1] = NULL; > } > - isa_bus_irqs(isa_bus, x86ms->gsi); > > if (x86ms->pic == ON_OFF_AUTO_ON || x86ms->pic == ON_OFF_AUTO_AUTO) { > pc_i8259_create(isa_bus, gsi_state->i8259_irq); > @@ -252,18 +323,12 @@ static void pc_init1(MachineState *machine, > } > > /* init basic PC hardware */ > - pc_basic_device_init(pcms, isa_bus, x86ms->gsi, &rtc_state, true, > + pc_basic_device_init(pcms, isa_bus, x86ms->gsi, rtc_state, true, > 0x4); > > pc_nic_init(pcmc, isa_bus, pci_bus); > > if (pcmc->pci_enabled) { > - PCIDevice *dev; > - > - dev = pci_create_simple(pci_bus, piix3_devfn + 1, TYPE_PIIX3_IDE); > - pci_ide_create_devs(dev); > - idebus[0] = qdev_get_child_bus(&dev->qdev, "ide.0"); > - idebus[1] = qdev_get_child_bus(&dev->qdev, "ide.1"); > pc_cmos_init(pcms, idebus[0], idebus[1], rtc_state); > } > #ifdef CONFIG_IDE_ISA > @@ -289,21 +354,9 @@ static void pc_init1(MachineState *machine, > } > #endif > > - if (pcmc->pci_enabled && machine_usb(machine)) { > - pci_create_simple(pci_bus, piix3_devfn + 2, "piix3-usb-uhci"); > - } > - > - if (pcmc->pci_enabled && x86_machine_is_acpi_enabled(X86_MACHINE(pcms))) { > - PCIDevice *piix4_pm; > - > + if (piix4_pm) { > smi_irq = qemu_allocate_irq(pc_acpi_smi_interrupt, first_cpu, 0); > - piix4_pm = pci_new(piix3_devfn + 3, TYPE_PIIX4_PM); > - qdev_prop_set_uint32(DEVICE(piix4_pm), "smb_io_base", 0xb100); > - qdev_prop_set_bit(DEVICE(piix4_pm), "smm-enabled", > - x86_machine_is_smm_enabled(x86ms)); > - pci_realize_and_unref(piix4_pm, pci_bus, &error_fatal); > > - qdev_connect_gpio_out(DEVICE(piix4_pm), 0, x86ms->gsi[9]); > qdev_connect_gpio_out_named(DEVICE(piix4_pm), "smi-irq", 0, smi_irq); > pcms->smbus = I2C_BUS(qdev_get_child_bus(DEVICE(piix4_pm), "i2c")); > /* TODO: Populate SPD eeprom data. */ > @@ -315,7 +368,7 @@ static void pc_init1(MachineState *machine, > object_property_allow_set_link, > OBJ_PROP_LINK_STRONG); > object_property_set_link(OBJECT(machine), PC_MACHINE_ACPI_DEVICE_PROP, > - OBJECT(piix4_pm), &error_abort); > + piix4_pm, &error_abort); > } > > if (machine->nvdimms_state->is_enabled) { > @@ -405,6 +458,9 @@ static void pc_xen_hvm_init(MachineState *machine) > } > > pc_xen_hvm_init_pci(machine); > + if (xen_igd_gfx_pt_enabled()) { > + xen_igd_reserve_slot(pcms->bus); > + } > pci_create_simple(pcms->bus, -1, "xen-platform"); > } > #endif > @@ -441,6 +497,11 @@ static void pc_i440fx_8_0_machine_options(MachineClass *m) > pc_i440fx_machine_options(m); > m->alias = "pc"; > m->is_default = true; > +#ifdef CONFIG_MICROVM_DEFAULT > + m->is_default = false; > +#else > + m->is_default = true; > +#endif > } > > DEFINE_I440FX_MACHINE(v8_0, "pc-i440fx-8.0", NULL, Lots of changes here not guarded by CONFIG_XEN. -- MST From xen-devel-bounces@lists.xenproject.org Mon Jan 09 23:35:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 23:35:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474131.735085 (Exim 4.92) (envelope-from ) id 1pF1fs-0006h3-Dx; Mon, 09 Jan 2023 23:35:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474131.735085; Mon, 09 Jan 2023 23:35:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF1fs-0006gw-BH; Mon, 09 Jan 2023 23:35:28 +0000 Received: by outflank-mailman (input) for mailman id 474131; Mon, 09 Jan 2023 23:35:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF1fq-0006gn-Pk for xen-devel@lists.xenproject.org; Mon, 09 Jan 2023 23:35:26 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 49a99b1e-9076-11ed-b8d0-410ff93cb8f0; Tue, 10 Jan 2023 00:35:24 +0100 (CET) Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-203-3wPotfuDMTurSReKuHDI0g-1; Mon, 09 Jan 2023 18:35:22 -0500 Received: by mail-qt1-f198.google.com with SMTP id e18-20020ac84912000000b003a96d6f436fso4652339qtq.0 for ; Mon, 09 Jan 2023 15:35:22 -0800 (PST) Received: from redhat.com ([191.101.160.154]) by smtp.gmail.com with ESMTPSA id bp37-20020a05620a45a500b006e99290e83fsm6136992qkb.107.2023.01.09.15.35.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 15:35:20 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 49a99b1e-9076-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673307323; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uCQhuqCyYYrUwYidZOjnRFW4Stp0dkql6Y3/FGUFmkM=; b=eifz0V98wZjFoHIKZt/cOd7cMh8FjXNCD14ijfFm6XNhr5Ja3A3+IsyFWge5clVHheTWYN BV1kHpbT3fCs1dq/kE+PrTw3xNFLWxGiGDj0R4Q3/jC/1adRGXaj69o+BAHFxU5id/iGEt 4Qny/cetFObW9SjCcuqxCzlwLFN7zNE= X-MC-Unique: 3wPotfuDMTurSReKuHDI0g-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uCQhuqCyYYrUwYidZOjnRFW4Stp0dkql6Y3/FGUFmkM=; b=ssvI4b1mGQgaMRTslBdc3xul5A/okouYC13fWBipQy0FeTHCOvRO8vFZy2539Thv1D T7dP7xDkxHdbqwCElUxKxzOQiCOc22/qTok5Vj2cyMOXRt1sYsZQ7N7MBSHvF7n61NWa Bmlz93bk8Y3b7wt2OshvhD9ABkX7HYibkT9C/nLLDlgu5cUWUFInYyjdh1rkPI5Bgr+B HSLj9bEDd68MN6fLF5hJFB9E6IFicDEqZZbtqnnrEU3n6Cp+9oUEhGpuEieuAKLAvFh0 OnpD7p3wh+JYuSf4lIw4S2S5G84qRXoSImftZTBaFGfmkbxJ6zvK3m2UvHK1V030S+63 wL7Q== X-Gm-Message-State: AFqh2kpnxR2nzRYgSyRNfnLUS3JgxAODeztO6izrVAOicYLn4z8G6yUE 3Oa2ca8XA7iK/vATrN4mE1MRJKzG70nqgwuc90KoEN+IbZFIAr0xmqxq1McdsS4h94yVVn1sYdt qgijwqMxhXr8pAKljGdchFFAVFP8= X-Received: by 2002:ac8:5e06:0:b0:3ab:5bb4:ae6d with SMTP id h6-20020ac85e06000000b003ab5bb4ae6dmr121013954qtx.43.1673307321689; Mon, 09 Jan 2023 15:35:21 -0800 (PST) X-Google-Smtp-Source: AMrXdXsxRfx2SIl26nDoOzTKTEQ+9/jl7hcSlDyR1SFYdSQ4Zm7h7aG56hVi/f4qStCQE9iwRXD6Ow== X-Received: by 2002:ac8:5e06:0:b0:3ab:5bb4:ae6d with SMTP id h6-20020ac85e06000000b003ab5bb4ae6dmr121013936qtx.43.1673307321427; Mon, 09 Jan 2023 15:35:21 -0800 (PST) Date: Mon, 9 Jan 2023 18:35:15 -0500 From: "Michael S. Tsirkin" To: Chuck Zmudzinski Cc: qemu-devel@nongnu.org, Stefano Stabellini , Anthony Perard , Paul Durrant , Paolo Bonzini , Richard Henderson , Eduardo Habkost , Marcel Apfelbaum , xen-devel@lists.xenproject.org Subject: Re: [PATCH v7] xen/pt: reserve PCI slot 2 for Intel igd-passthru Message-ID: <20230109183413-mutt-send-email-mst@kernel.org> References: <8349506149de6d81b0762f17623552c248439e93.1673297742.git.brchuckz.ref@aol.com> <8349506149de6d81b0762f17623552c248439e93.1673297742.git.brchuckz@aol.com> <20230109172738-mutt-send-email-mst@kernel.org> <8c2531a8-ce99-7593-99f8-222076fe6bd6@aol.com> MIME-Version: 1.0 In-Reply-To: <8c2531a8-ce99-7593-99f8-222076fe6bd6@aol.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Mon, Jan 09, 2023 at 06:28:44PM -0500, Chuck Zmudzinski wrote: > On 1/9/23 5:33 PM, Michael S. Tsirkin wrote: > > On Mon, Jan 09, 2023 at 04:55:42PM -0500, Chuck Zmudzinski wrote: > >> Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, > >> as noted in docs/igd-assign.txt in the Qemu source code. > >> > >> Currently, when the xl toolstack is used to configure a Xen HVM guest with > >> Intel IGD passthrough to the guest with the Qemu upstream device model, > >> a Qemu emulated PCI device will occupy slot 2 and the Intel IGD will occupy > >> a different slot. This problem often prevents the guest from booting. > >> > >> The only available workaround is not good: Configure Xen HVM guests to use > >> the old and no longer maintained Qemu traditional device model available > >> from xenbits.xen.org which does reserve slot 2 for the Intel IGD. > >> > >> To implement this feature in the Qemu upstream device model for Xen HVM > >> guests, introduce the following new functions, types, and macros: > >> > >> * XEN_PT_DEVICE_CLASS declaration, based on the existing TYPE_XEN_PT_DEVICE > >> * XEN_PT_DEVICE_GET_CLASS macro helper function for XEN_PT_DEVICE_CLASS > >> * typedef XenPTQdevRealize function pointer > >> * XEN_PCI_IGD_SLOT_MASK, the value of slot_reserved_mask to reserve slot 2 > >> * xen_igd_reserve_slot and xen_igd_clear_slot functions > >> > >> The new xen_igd_reserve_slot function uses the existing slot_reserved_mask > >> member of PCIBus to reserve PCI slot 2 for Xen HVM guests configured using > >> the xl toolstack with the gfx_passthru option enabled, which sets the > >> igd-passthru=on option to Qemu for the Xen HVM machine type. > > > > I don't like how slot_reserved_mask is set initially then cleared on > > device realize. > > To me this looks like a fragile hack. I suggest one of the following > > 1. adding a new mask > > "slot-manual-mask" or some such blocking auto-allocation of a given > > slot without blocking its use if address is specified on command line. > > 2. adding a special property that overrides slot_reserved_mask > > for a given device. > > > > both need changes in pci core but look like something generally > > useful. > > I was hoping to not need to touch pci core but I understand it would be > better for this patch to not affect machines that are manually configured > on the command line. > > However, keep in mind that this patch will only actually reserve the slot > initially for xen hvm machines (machine type "xenfv") that also are configured > with the qemu igd-passthru=on option which, AFAIK, only applies to machines > witn accel=xen. It will not affect kvm users at all. So I don't think this patch > will break many machines out there that manually specify the pci slots. The > only machines it could affect are machines configured for igd-passthru on xen. > This patch also does *not* reserve the slot initially for "xenfv" machines that > are not configured with igd passthrough which I am sure is the vast majority > of all the xen virtual machines out in the wild. I'm just saying that adding a capability that is generally useful as opposed to xen specific means less technical debt. -- MST From xen-devel-bounces@lists.xenproject.org Mon Jan 09 23:45:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 Jan 2023 23:45:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474143.735121 (Exim 4.92) (envelope-from ) id 1pF1pr-0008Sz-IV; Mon, 09 Jan 2023 23:45:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474143.735121; Mon, 09 Jan 2023 23:45:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF1pr-0008Ss-Fb; Mon, 09 Jan 2023 23:45:47 +0000 Received: by outflank-mailman (input) for mailman id 474143; Mon, 09 Jan 2023 23:45:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF1pq-0008Sg-44; Mon, 09 Jan 2023 23:45:46 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF1pq-0004SN-1o; Mon, 09 Jan 2023 23:45:46 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF1pp-0003kU-Mr; Mon, 09 Jan 2023 23:45:45 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pF1pp-0007fn-MN; Mon, 09 Jan 2023 23:45:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=wKYmamS0FEmE1IciCbsAyFi5G/MKaCWk7J7ky4TNnt0=; b=h7gOUIlBqufE7lESaZbp+tvURI +rEYe67DNzDIGrnUewWxCX4Gzy3U+4rXPRkse+LE8L4Kv1pRdwV+OV5VrNTNPklB3b46KSwYkh8K1 5eOkKIZMEPjHV8aKXvIKn0p0GpkNgXbmu9AmR38BA/u2R/vQ7ULaw6xD8T/FEEA2qcpI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 175651: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:windows-install:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=38525f6f73f906699f77a1af86c16b4eaad48e04 X-Osstest-Versions-That: xen=2b21cbbb339fb14414f357a6683b1df74c36fda2 From: osstest service owner Date: Mon, 09 Jan 2023 23:45:45 +0000 flight 175651 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/175651/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail like 175624 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 175635 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175635 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 175635 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175635 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 175635 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175635 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 175635 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 175635 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 175635 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 175635 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175635 test-amd64-amd64-xl-qemuu-win7-amd64 12 windows-install fail like 175635 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen 38525f6f73f906699f77a1af86c16b4eaad48e04 baseline version: xen 2b21cbbb339fb14414f357a6683b1df74c36fda2 Last test of basis 175635 2023-01-09 01:51:57 Z 0 days Testing same since 175651 2023-01-09 17:37:04 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich Julien Grall Oleksii Kurochko jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 2b21cbbb33..38525f6f73 38525f6f73f906699f77a1af86c16b4eaad48e04 -> master From xen-devel-bounces@lists.xenproject.org Tue Jan 10 00:05:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 00:05:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474153.735138 (Exim 4.92) (envelope-from ) id 1pF29D-00036D-7K; Tue, 10 Jan 2023 00:05:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474153.735138; Tue, 10 Jan 2023 00:05:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF29D-000366-3f; Tue, 10 Jan 2023 00:05:47 +0000 Received: by outflank-mailman (input) for mailman id 474153; Tue, 10 Jan 2023 00:05:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF29B-000360-1W for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 00:05:45 +0000 Received: from sonic307-8.consmr.mail.gq1.yahoo.com (sonic307-8.consmr.mail.gq1.yahoo.com [98.137.64.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 851e7592-907a-11ed-91b6-6bf2151ebd3b; Tue, 10 Jan 2023 01:05:42 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.gq1.yahoo.com with HTTP; Tue, 10 Jan 2023 00:05:40 +0000 Received: by hermes--production-ne1-7b69748c4d-drrwg (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 7a6ec1fe15f013b8e5a1b92f9096e4a4; Tue, 10 Jan 2023 00:05:38 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 851e7592-907a-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1673309140; bh=xiK5KiqCfiN1A6VOg2adTua1q58rEf/Dco968cQ11hc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=kO1KzrtO+4XcKbOjzzAqScu+K3AwYFKsLzP+XLE3nHtCFuPT3cFewPvO/aJo1V/RI+aJfQx4wdGMhmrfOWtpQBPmfcjfuN0mpNsJaw06IUcLiV/B9mGWFQno/p+zB/kgAkN2tpLTZRHeVbyMRJHSLG5U3zHj70vV8NGc+vJiBnXTopqeK/526JZtq0TAEmeLswooyGc6NUNPs2FjfoR8WL7FO6PbDUZJSBfSSwPMOpY/MwuUZFHQ7YxoabLqfzlNWKolykBelvzFQl9NfTYDAzhWfBO5rR2KXhBh4pe356AwYQKa0Y2Q19X3n6yyqCRBYqP0C7WxfLvL1QnMSMdYJA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1673309140; bh=PCF+XPvsmO4dujDdrFfKM6wN/EXN9jjbZLFIWTFrSaX=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=ktlTFUsATzh6kYl4Bb4FXawzFtxRq7BS32w2DjlgBTeDOs3pevkR5GH3L2Lofy0amnx5/lwUO2835aBoGQWwFm5ZGP3uOWvYdpVfA80/dyH5Grq1zhbgnB8UU3qTqcZ/UZjsJ8ngN783W4Lq5rkEvIZzkREI23HU0ZDxJQ6KZ10Jt9LiEtS7YZu9GYoTcB3z9tEA3kS0mKDFDrsPotC4exFevW0phcVhlW5pRFHxTPnIOaXFHuw7tQOIDpDBGCaxvTbF1WF2niHzSEmjAfQWioTbzDGpbUM0XTqoNGeY3mk7+Q4ipfdZsUCEvXmC7kI4b9q4Vn7Gq6LySjFnTw5lLA== X-YMail-OSG: qd69w.cVM1l2Y4YzytTaJ3hrOAhZ8NRYMKdfRqq8figUbSbVmltPRzcQNpSOcK4 aaeHAGxLDxCqOI7aybhgkKqMxlQviYFTcZbDJs6TYaB__QlBATZ41IdXYO4tl9c7SdeUtpJ9cu_K E3NojDeMWoJSuoX4Bi5HO1OSiiKrs7rEXVTvCV_RXnPadagMgWhC7bjiXxO.AhzsoOb1gFNlWkUp Ae3yzxjpko3Hm_hIMFTJ8YQOQ4IYnnQZc8g7h.KeqnbCMB19jYExVZckySJNnrd2zNl3NovPMc2e bdLwFWENpcff80GX1iHBLN.9slrowBgu4dWc_7lMnluBQ6ENs5onXgpbLi7bGKMHCOXxe6wT089Q 0zJaeVcGFf0VIfSgoHoczazwYlcy5CNCxtHhig3zkfAWC.LcQzP8qijHeviB8hFThVgzGfum99XP 2gJfpmCc4j.RX_KlTb0peQtYCSdLvdGt_vBqATmD_TNoAfdZbkRbr3LM9YYs5WmOLnymMQ1RNaYZ bqNAnH9gWSslUtkMgbkIWMsdAGa20r18prttMh2NcDdmD14BAW5fdsc0ZVYsP5t1U4rOy8JpXb2N QJR99siH7YMFi7E6.hfWRB4Ce4AV.GyHjlw14rHnLC4w0RKko1scjrifqFpyxSafiHPcVjMOnnfF yBj0AQPlR4lRHka8TsWBh2ODT1ymyvJeTl3n3hK0Y7tqdwa6xzM.Y1SWNX3hHoU1RosaoLK6CAPo Z0bHDrNtoeZfQb6UJLj4.oFqhY495.cA.ep8kTT2K7.Y.DeVd2ZTBmCoJczpBJAWUBqMxwkb6FmV O5m5ZoOEUlANrahGyA4dmqZCbaRjrTLQnTCMPIeZ3qqPdrNQlpZZ._GzWn5P9U_DftwgXMjkneXz y_ZFc7yPwY9O25ga00Q8YDWPzGa_vvvJ5HX6oHKr021V9ca6jCOejSKXS0DLMfQ9yH09QRZ1IaUI 2qrL.MJB6nAKfNZEdBKx8Zb_ANcYGeLvNGKodg1N.y96i.fzBs4M0DRyLRYrqDiXF0o93MLPvS42 iJm3n5ijNnyAqdicw_yZhAjLI1Z41arMeh75Kz30nwPgh_bZrEGgODmdDfQd6GV6h44kk1Wck6TC 52Ar9PQlMtoV7tK1kgfEmW8tfAI4wuaqxYYIO74nV9sqe5U8c4F8eO08YCseyu_KoZ68IllFu6Gb OTS4fHzL5fPBtcQg.i647S9.gpq5OtW0O1PLuYgquK1HiC50KE0qeQADuoDOHf_ClXXgDOLh6VnJ 1w5CpZQ0PSZSiigg8mFwE8EOHJifXJAwjbuIhiZCyhrOeZcZiWtAVQF7NS7HLvkx5L3q28rsyo1r jhHp.fyw.slUg9dhIbQjdvHrCBNP4QYU8ZQFYFNaBXqmk.iLADV6zuaeqSorYKBDRF0RSmNOEGdN kVxRM0dA5gL03VOOw8ugqb_jvCIijz76G1hSIApQEhOThxAr2b3LPhPG_gDrLd_yEbekjqt34YRI weDd4Up2MU9SvqM9SEnA_GwnTmWi5lg_fic.Y7Sbj.a8ZTcHjwuI7xYnUuxURa9PJSLlALxPujC8 hBvuLwPkoNIlB7Bz9ECJHo0HMnczSq1toZvWfOPBIiOOzmnBjTwB_Mn3FXSDm5Rp4ixOPNFWrbUT Aahg9bVlc_5ohi7R6yiRDYD4y1QT8qJcgcVSKj7wOE7FqNnvLyeOReAhLc0yetegPwL2FebIsP5x u040sy4CRjxEF7f4DqseSbGNM9wnOGUrM.Eky8ew_cNlX_mNnnxLZh9VsaFdn_TYJrqH.AuLVb_L SJEMvz7pXFo5OJNarazkn48kAn54143JMiK4c0_PF7R_vE9NWwnZmtXoOavIOn0NmMImoLP0II0i GUsCECLYmdDgRpUP4w_OlDrtU6lDMmdQyQbpUNro6ol_EBEGcf.chNPIWJFMBIuLwRc22kL0W74v aQUWljcVQ0wWY9oFbf7F9B.QhFtEEGchLNfVFShkPSf4PFHyB5K_01HuWLoPUHWGf0xjNyqFsvcn D6Feybu8eRcHNwngdUHqLdJyQ6xMQYAErbXb3z_nd_QzpQYvpK0bW0WAoWMAVHCuR5LHTwDGKF2N q_Y3NxGHlJHNU1x4T0l.tdqEmyWhgrG07inVckmQYte.Fltv.HCZo8dn0bWteJ.eM29tcfj0OsAr 1UMILR8FNcXAKXPONB3Yhf0IbDlCyLsR8SY4t3sz0Gw9BAveR4zUKQVQGLf5bsdzp5WBPVPHR_Iw 6I6QU3bhxnPE- X-Sonic-MF: Message-ID: Date: Mon, 9 Jan 2023 19:05:35 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v7] xen/pt: reserve PCI slot 2 for Intel igd-passthru Content-Language: en-US To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org, Stefano Stabellini , Anthony Perard , Paul Durrant , Paolo Bonzini , Richard Henderson , Eduardo Habkost , Marcel Apfelbaum , xen-devel@lists.xenproject.org References: <8349506149de6d81b0762f17623552c248439e93.1673297742.git.brchuckz.ref@aol.com> <8349506149de6d81b0762f17623552c248439e93.1673297742.git.brchuckz@aol.com> <20230109183132-mutt-send-email-mst@kernel.org> From: Chuck Zmudzinski In-Reply-To: <20230109183132-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.20982 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 13336 On 1/9/23 6:33 PM, Michael S. Tsirkin wrote: > On Mon, Jan 09, 2023 at 04:55:42PM -0500, Chuck Zmudzinski wrote: >> Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, >> as noted in docs/igd-assign.txt in the Qemu source code. >> >> Currently, when the xl toolstack is used to configure a Xen HVM guest with >> Intel IGD passthrough to the guest with the Qemu upstream device model, >> a Qemu emulated PCI device will occupy slot 2 and the Intel IGD will occupy >> a different slot. This problem often prevents the guest from booting. >> >> The only available workaround is not good: Configure Xen HVM guests to use >> the old and no longer maintained Qemu traditional device model available >> from xenbits.xen.org which does reserve slot 2 for the Intel IGD. >> >> To implement this feature in the Qemu upstream device model for Xen HVM >> guests, introduce the following new functions, types, and macros: >> >> * XEN_PT_DEVICE_CLASS declaration, based on the existing TYPE_XEN_PT_DEVICE >> * XEN_PT_DEVICE_GET_CLASS macro helper function for XEN_PT_DEVICE_CLASS >> * typedef XenPTQdevRealize function pointer >> * XEN_PCI_IGD_SLOT_MASK, the value of slot_reserved_mask to reserve slot 2 >> * xen_igd_reserve_slot and xen_igd_clear_slot functions >> >> The new xen_igd_reserve_slot function uses the existing slot_reserved_mask >> member of PCIBus to reserve PCI slot 2 for Xen HVM guests configured using >> the xl toolstack with the gfx_passthru option enabled, which sets the >> igd-passthru=on option to Qemu for the Xen HVM machine type. >> >> The new xen_igd_reserve_slot function also needs to be implemented in >> hw/xen/xen_pt_stub.c to prevent FTBFS during the link stage for the case >> when Qemu is configured with --enable-xen and --disable-xen-pci-passthrough, >> in which case it does nothing. >> >> The new xen_igd_clear_slot function overrides qdev->realize of the parent >> PCI device class to enable the Intel IGD to occupy slot 2 on the PCI bus >> since slot 2 was reserved by xen_igd_reserve_slot when the PCI bus was >> created in hw/i386/pc_piix.c for the case when igd-passthru=on. >> >> Move the call to xen_host_pci_device_get, and the associated error >> handling, from xen_pt_realize to the new xen_igd_clear_slot function to >> initialize the device class and vendor values which enables the checks for >> the Intel IGD to succeed. The verification that the host device is an >> Intel IGD to be passed through is done by checking the domain, bus, slot, >> and function values as well as by checking that gfx_passthru is enabled, >> the device class is VGA, and the device vendor in Intel. >> >> Signed-off-by: Chuck Zmudzinski >> --- >> Notes that might be helpful to reviewers of patched code in hw/xen: >> >> The new functions and types are based on recommendations from Qemu docs: >> https://qemu.readthedocs.io/en/latest/devel/qom.html >> >> Notes that might be helpful to reviewers of patched code in hw/i386: >> >> The small patch to hw/i386/pc_piix.c is protected by CONFIG_XEN so it does >> not affect builds that do not have CONFIG_XEN defined. > > I'm not sure how you can claim that. I mean the small patch to pc_piix.c in this patch sits between an "#ifdef CONFIG_XEN" and the corresponding "#endif" so the preprocessor will exclude it when CONFIG_XEN is not defined. In other words, my patch is part of the xen-specific code in pc_piix.c. Or am I missing something? > > ... > >> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c >> index b48047f50c..34a9736b5e 100644 >> --- a/hw/i386/pc_piix.c >> +++ b/hw/i386/pc_piix.c >> @@ -32,6 +32,7 @@ >> #include "hw/i386/pc.h" >> #include "hw/i386/apic.h" >> #include "hw/pci-host/i440fx.h" >> +#include "hw/rtc/mc146818rtc.h" >> #include "hw/southbridge/piix.h" >> #include "hw/display/ramfb.h" >> #include "hw/firmware/smbios.h" >> @@ -40,16 +41,16 @@ >> #include "hw/usb.h" >> #include "net/net.h" >> #include "hw/ide/pci.h" >> -#include "hw/ide/piix.h" >> #include "hw/irq.h" >> #include "sysemu/kvm.h" >> #include "hw/kvm/clock.h" >> #include "hw/sysbus.h" >> +#include "hw/i2c/i2c.h" >> #include "hw/i2c/smbus_eeprom.h" >> #include "hw/xen/xen-x86.h" >> +#include "hw/xen/xen.h" >> #include "exec/memory.h" >> #include "hw/acpi/acpi.h" >> -#include "hw/acpi/piix4.h" >> #include "qapi/error.h" >> #include "qemu/error-report.h" >> #include "sysemu/xen.h" >> @@ -66,6 +67,7 @@ >> #include "kvm/kvm-cpu.h" >> >> #define MAX_IDE_BUS 2 >> +#define XEN_IOAPIC_NUM_PIRQS 128ULL >> >> #ifdef CONFIG_IDE_ISA >> static const int ide_iobase[MAX_IDE_BUS] = { 0x1f0, 0x170 }; >> @@ -73,6 +75,32 @@ static const int ide_iobase2[MAX_IDE_BUS] = { 0x3f6, 0x376 }; >> static const int ide_irq[MAX_IDE_BUS] = { 14, 15 }; >> #endif >> >> +/* >> + * Return the global irq number corresponding to a given device irq >> + * pin. We could also use the bus number to have a more precise mapping. >> + */ >> +static int pci_slot_get_pirq(PCIDevice *pci_dev, int pci_intx) >> +{ >> + int slot_addend; >> + slot_addend = PCI_SLOT(pci_dev->devfn) - 1; >> + return (pci_intx + slot_addend) & 3; >> +} >> + >> +static void piix_intx_routing_notifier_xen(PCIDevice *dev) >> +{ >> + int i; >> + >> + /* Scan for updates to PCI link routes (0x60-0x63). */ >> + for (i = 0; i < PIIX_NUM_PIRQS; i++) { >> + uint8_t v = dev->config_read(dev, PIIX_PIRQCA + i, 1); >> + if (v & 0x80) { >> + v = 0; >> + } >> + v &= 0xf; >> + xen_set_pci_link_route(i, v); >> + } >> +} >> + >> /* PC hardware initialisation */ >> static void pc_init1(MachineState *machine, >> const char *host_type, const char *pci_type) >> @@ -84,7 +112,7 @@ static void pc_init1(MachineState *machine, >> MemoryRegion *system_io = get_system_io(); >> PCIBus *pci_bus; >> ISABus *isa_bus; >> - int piix3_devfn = -1; >> + Object *piix4_pm; >> qemu_irq smi_irq; >> GSIState *gsi_state; >> BusState *idebus[MAX_IDE_BUS]; >> @@ -205,10 +233,9 @@ static void pc_init1(MachineState *machine, >> gsi_state = pc_gsi_create(&x86ms->gsi, pcmc->pci_enabled); >> >> if (pcmc->pci_enabled) { >> - PIIX3State *piix3; >> + DeviceState *dev; >> PCIDevice *pci_dev; >> - const char *type = xen_enabled() ? TYPE_PIIX3_XEN_DEVICE >> - : TYPE_PIIX3_DEVICE; >> + int i; >> >> pci_bus = i440fx_init(pci_type, >> i440fx_host, >> @@ -216,21 +243,65 @@ static void pc_init1(MachineState *machine, >> x86ms->below_4g_mem_size, >> x86ms->above_4g_mem_size, >> pci_memory, ram_memory); >> + pci_bus_map_irqs(pci_bus, >> + xen_enabled() ? xen_pci_slot_get_pirq >> + : pci_slot_get_pirq); >> pcms->bus = pci_bus; >> >> - pci_dev = pci_create_simple_multifunction(pci_bus, -1, true, type); >> - piix3 = PIIX3_PCI_DEVICE(pci_dev); >> - piix3->pic = x86ms->gsi; >> - piix3_devfn = piix3->dev.devfn; >> - isa_bus = ISA_BUS(qdev_get_child_bus(DEVICE(piix3), "isa.0")); >> + pci_dev = pci_new_multifunction(-1, true, TYPE_PIIX3_DEVICE); >> + object_property_set_bool(OBJECT(pci_dev), "has-usb", >> + machine_usb(machine), &error_abort); >> + object_property_set_bool(OBJECT(pci_dev), "has-acpi", >> + x86_machine_is_acpi_enabled(x86ms), >> + &error_abort); >> + qdev_prop_set_uint32(DEVICE(pci_dev), "smb_io_base", 0xb100); >> + object_property_set_bool(OBJECT(pci_dev), "smm-enabled", >> + x86_machine_is_smm_enabled(x86ms), >> + &error_abort); >> + pci_realize_and_unref(pci_dev, pci_bus, &error_fatal); >> + >> + if (xen_enabled()) { >> + pci_device_set_intx_routing_notifier( >> + pci_dev, piix_intx_routing_notifier_xen); >> + >> + /* >> + * Xen supports additional interrupt routes from the PCI devices to >> + * the IOAPIC: the four pins of each PCI device on the bus are also >> + * connected to the IOAPIC directly. >> + * These additional routes can be discovered through ACPI. >> + */ >> + pci_bus_irqs(pci_bus, xen_intx_set_irq, pci_dev, >> + XEN_IOAPIC_NUM_PIRQS); >> + } >> + >> + dev = DEVICE(object_resolve_path_component(OBJECT(pci_dev), "pic")); >> + for (i = 0; i < ISA_NUM_IRQS; i++) { >> + qdev_connect_gpio_out(dev, i, x86ms->gsi[i]); >> + } >> + isa_bus = ISA_BUS(qdev_get_child_bus(DEVICE(pci_dev), "isa.0")); >> + rtc_state = ISA_DEVICE(object_resolve_path_component(OBJECT(pci_dev), >> + "rtc")); >> + piix4_pm = object_resolve_path_component(OBJECT(pci_dev), "pm"); >> + dev = DEVICE(object_resolve_path_component(OBJECT(pci_dev), "ide")); >> + pci_ide_create_devs(PCI_DEVICE(dev)); >> + idebus[0] = qdev_get_child_bus(dev, "ide.0"); >> + idebus[1] = qdev_get_child_bus(dev, "ide.1"); >> } else { >> pci_bus = NULL; >> + piix4_pm = NULL; >> isa_bus = isa_bus_new(NULL, get_system_memory(), system_io, >> &error_abort); >> + isa_bus_irqs(isa_bus, x86ms->gsi); >> + >> + rtc_state = isa_new(TYPE_MC146818_RTC); >> + qdev_prop_set_int32(DEVICE(rtc_state), "base_year", 2000); >> + isa_realize_and_unref(rtc_state, isa_bus, &error_fatal); >> + >> i8257_dma_init(isa_bus, 0); >> pcms->hpet_enabled = false; >> + idebus[0] = NULL; >> + idebus[1] = NULL; >> } >> - isa_bus_irqs(isa_bus, x86ms->gsi); >> >> if (x86ms->pic == ON_OFF_AUTO_ON || x86ms->pic == ON_OFF_AUTO_AUTO) { >> pc_i8259_create(isa_bus, gsi_state->i8259_irq); >> @@ -252,18 +323,12 @@ static void pc_init1(MachineState *machine, >> } >> >> /* init basic PC hardware */ >> - pc_basic_device_init(pcms, isa_bus, x86ms->gsi, &rtc_state, true, >> + pc_basic_device_init(pcms, isa_bus, x86ms->gsi, rtc_state, true, >> 0x4); >> >> pc_nic_init(pcmc, isa_bus, pci_bus); >> >> if (pcmc->pci_enabled) { >> - PCIDevice *dev; >> - >> - dev = pci_create_simple(pci_bus, piix3_devfn + 1, TYPE_PIIX3_IDE); >> - pci_ide_create_devs(dev); >> - idebus[0] = qdev_get_child_bus(&dev->qdev, "ide.0"); >> - idebus[1] = qdev_get_child_bus(&dev->qdev, "ide.1"); >> pc_cmos_init(pcms, idebus[0], idebus[1], rtc_state); >> } >> #ifdef CONFIG_IDE_ISA >> @@ -289,21 +354,9 @@ static void pc_init1(MachineState *machine, >> } >> #endif >> >> - if (pcmc->pci_enabled && machine_usb(machine)) { >> - pci_create_simple(pci_bus, piix3_devfn + 2, "piix3-usb-uhci"); >> - } >> - >> - if (pcmc->pci_enabled && x86_machine_is_acpi_enabled(X86_MACHINE(pcms))) { >> - PCIDevice *piix4_pm; >> - >> + if (piix4_pm) { >> smi_irq = qemu_allocate_irq(pc_acpi_smi_interrupt, first_cpu, 0); >> - piix4_pm = pci_new(piix3_devfn + 3, TYPE_PIIX4_PM); >> - qdev_prop_set_uint32(DEVICE(piix4_pm), "smb_io_base", 0xb100); >> - qdev_prop_set_bit(DEVICE(piix4_pm), "smm-enabled", >> - x86_machine_is_smm_enabled(x86ms)); >> - pci_realize_and_unref(piix4_pm, pci_bus, &error_fatal); >> >> - qdev_connect_gpio_out(DEVICE(piix4_pm), 0, x86ms->gsi[9]); >> qdev_connect_gpio_out_named(DEVICE(piix4_pm), "smi-irq", 0, smi_irq); >> pcms->smbus = I2C_BUS(qdev_get_child_bus(DEVICE(piix4_pm), "i2c")); >> /* TODO: Populate SPD eeprom data. */ >> @@ -315,7 +368,7 @@ static void pc_init1(MachineState *machine, >> object_property_allow_set_link, >> OBJ_PROP_LINK_STRONG); >> object_property_set_link(OBJECT(machine), PC_MACHINE_ACPI_DEVICE_PROP, >> - OBJECT(piix4_pm), &error_abort); >> + piix4_pm, &error_abort); >> } >> >> if (machine->nvdimms_state->is_enabled) { >> @@ -405,6 +458,9 @@ static void pc_xen_hvm_init(MachineState *machine) >> } >> >> pc_xen_hvm_init_pci(machine); >> + if (xen_igd_gfx_pt_enabled()) { >> + xen_igd_reserve_slot(pcms->bus); >> + } >> pci_create_simple(pcms->bus, -1, "xen-platform"); >> } >> #endif >> @@ -441,6 +497,11 @@ static void pc_i440fx_8_0_machine_options(MachineClass *m) >> pc_i440fx_machine_options(m); >> m->alias = "pc"; >> m->is_default = true; >> +#ifdef CONFIG_MICROVM_DEFAULT >> + m->is_default = false; >> +#else >> + m->is_default = true; >> +#endif >> } >> >> DEFINE_I440FX_MACHINE(v8_0, "pc-i440fx-8.0", NULL, > > > Lots of changes here not guarded by CONFIG_XEN. > What diff is this? How is my patch related to it? From xen-devel-bounces@lists.xenproject.org Tue Jan 10 00:07:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 00:07:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474160.735149 (Exim 4.92) (envelope-from ) id 1pF2B0-0003iF-Ns; Tue, 10 Jan 2023 00:07:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474160.735149; Tue, 10 Jan 2023 00:07:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF2B0-0003i8-LA; Tue, 10 Jan 2023 00:07:38 +0000 Received: by outflank-mailman (input) for mailman id 474160; Tue, 10 Jan 2023 00:07:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF2Az-0003i2-Tu for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 00:07:37 +0000 Received: from sonic306-21.consmr.mail.gq1.yahoo.com (sonic306-21.consmr.mail.gq1.yahoo.com [98.137.68.84]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c804ffd0-907a-11ed-b8d0-410ff93cb8f0; Tue, 10 Jan 2023 01:07:35 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic306.consmr.mail.gq1.yahoo.com with HTTP; Tue, 10 Jan 2023 00:07:32 +0000 Received: by hermes--production-ne1-7b69748c4d-pm9xv (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 3690a7ed7136d7d2ab4095291adae14f; Tue, 10 Jan 2023 00:07:27 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c804ffd0-907a-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1673309252; bh=TjWRQ3XDQ9v5XBbBlXFg/nqc2AKrVM/5dbL4mDfhkpE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=JfA1QQc4IuZWn2q/0AwE8zlAE1hfXOHaXiKe8imLX/Ytrn4nLV2TMHnnMkwQdVJW5c5/zbVtxlJQtkCxzG2sE5Jv63uwlrk3/DuZF98BZAJvAAwEAbECmD/4YPsk8ksSaZHtDPIPFzbv5Twlt9GiZR0A1iOMElk5nd9SC1XiicMc06sGIcj9DdM/njYUzgbx4/8D8OL3nT9JPPp/o3YbFuxUcsTFX7oKyXe7AZL39bL7gRx+Xl5YhUbV6sQFPPCdovcfKeAiBd2ZAO8sCaMa7JgVz/M8RG5/3qn5GibUavkMR88dJQVZuk/I7Y33+R9qOwk20NItOngS612jnt2hZw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1673309252; bh=nFCRAALOdJVOepdExywB8v7RnknYNQlGAfr1ya85Pc8=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=DSa7JwuwBkLV6l00NXnOyIr44e+lEFFZ8a4P3EMPcMpGbInWVh77BgrFCaoAKEQiIeumScpMUVSlL+m8o0vzX2l4XtU4ZCemJoddMwgFC6djS842HQZpleoBgK1cPj0fgjQUCIDNEHVPpHYxFHDkVpeBUEIXdoiPFu0bGnPRDRwCQ9Uhh9viyqyaz8d/b2LZExDKRyRTHf4LhYgLe88Zi6w8vF9r9V4uBAHouqDhzrGdArUobuFaBX/JScII3k22xm0k8TeEegABB0npmvB2Z0lBN7ttY+dj75tqxOo7Wt8xP/1Dj/+aUEjuqmEatQ7zuvBTrj/6UcxCojqd5ZvD2w== X-YMail-OSG: 6VYIDtwVM1lfvejDjOPjsXuG7.vU5smWRTykHeFd1cl8ReMGrrANGFkQ1BAxjVH 1bmhLyTI23B2OvNGBNdzClwcTSbq5g5BK8wpNw0ReoobjaK23Yi6EZ5AH6fXHMkRYUibFhbFMGGY S_Jv9bwoILhVVL1_UedMVme6K0YIKKNJ3KOnZvJrE8zugxX5twB9SNmuMBBIf8L32Jq6scwnA8Vc ET4UbAI5w5BEwEwQh4T91be9hIoopXyHVVC51ywi.Co0QZAgiCgzPACF.vtwJqq2tEP9GNGJLnnQ h7IRRoV1jLxSltR7ZY8KzjotWQ1SUydMzRhrQTMktfRGCCRswUckkDwMikB9OSPO9a3TwWlButHI J.nVbxJoN50G6uKn0uh_nQGGQ0RsONEfwe73zLB2Qy7_k3TdKaGGZ02GrCGGo5mj0eZqWe48qwjY aVtqElY0zrQGgbFIIDbt1BIkQ0p1oFcmUvJ2YvdGteM0CDSfV7qYxX2IH6e_1sIDDi1l0DBUkrP4 nBZKV5Yfh3gWN4WbhTHJLJYc1l4LNrawQei8sFxkg3RqcHbUcXKjYfwSEGAWM86hzGyPBk9gwbfx qkI1hky9OSx1AHZNfRbq9Yhh_WkAhv1dQS4sRnC8xtYyTBtN3RljIsLXEN76.Zf.xJHvfR3Rkapj .o_YcXt7xA5ahkHKfwsAXdAzouBd.SRka1_URRhHbavUF_Kv5xILxDcbV.N2r9rTo7ZZelz8Yth1 wi2Of8JsXEsyh5BRfK5bfh.puxWUtTxOVSqRg1dvQszXTBfHiggtPQM03yRnV44IIvwVZqXzdVQO kYXjM_T4RMFGeHMXmW2HavEMrmDgevuEPqZH5LViLh5ZAMY4.kys6GmaO3elB4ZkrWmK.1pnh4EC ekORxTg6OH9let0ZfG5NMX.1dZcTFLNMupDNwa89axi8DHTCzhrc_alYTVpr8wD.ObKFflQdNZcR a0WW5wjvrACPbphsOhgBWqFpO2MDTllyU7.Unnfo1EmZ0qbJCqkYUXjRa1Qn4oS8dFU9j9gKjQWB pVtPkJ55_46j41PiaGXI8hLD7MQczSzYawx3XKA9fBf8fv1Q9QypKqFaORsz1hJPRbMDgVee9hBC FVpM2WsEVYY.gEnWD_tCa2se1Bv2kw9s4u5pc3X3VOzfLHN8EI8fXd_4I6pvs1jqHy4UqduZ7W6Y EOwoTERAeBhMAi051Vm3FM9oIDWFDy9Dw6DYGY3qnmGYCdsRIQdzbT1XvbKOdFrUuc8btwPIwytn jlnDBpsqRRk89DbsytuzVgVovCn2T5xbuaFdKKq8ra1BWsAhT.8gp3T6wmsgDbhoWgpUOszyGsId w3m5YJ_zUzAYHrzRKtBZbVMRoOGwREe0.h_57gSWA9tlcoiRWl_.XFr2jG0i9FF59p0oGrBMXp.B HTRFVYQfgSP9nE4KGiK64bpifTypcvpIMN0nD2YhMp2QzP8DvjZT3HO1i4pYXTM4ghbg2q6S_tL. _mvqeyyzwtZkOpV8Gg6tjHLIF6ITZxVVGcCmKnGXBK.VnJuAWs4b1eQwKBTdbBqT4BQUgxuJvGxX 1H8VQGsivLP.sq6Qk6DTMSSY4tO58QVRH_RMY1gm_iAdI8SIWeTwAkyU9DW.CN4AFKfL5NtffD0O j5RfFM_EE5DcnBjXqX.1nzLCQ_zGaSIHKYVRidoy8yifpdtNUzDv9.aS35ns_ktZ9dWizsur0Zem A.X28ii3y1r4egEJMQzur5yEp9WV0X704yiEb_8dp4aetjyWIKHmYdkQ0G0ZEAYSEjd9oJr5FOLP UJPd5NXTUNJ3RHG9V1jSRP38MOaFJOpAlSW_Po08.w8skQvkqCGgHEgVPL7GOPGl8RK.1KyBXFKT VznE9kIYac06bU77TZw2lVBMbvgLr7Nik8i2gTGjHTdCGA4nEiAbEq2fgyJ7pUkI60vOWrkUkKnM XtoCA2u_gmdX4Z3OTH0NFHAPjOStYiLwLNhbcVTOPcQn45FNffbSQMEs87YVIXCf3qDwr8fGTxzo ifJmNovycWkzV3RSTHRSM3MSsWDulkSVOqffSJ6Tz6a7_7m9g_V1f62FPh_nJ37oK6AOGlWaagYw ZsZtzTTGan7lhspITmnfZXjsqpsObHpbbFlukcDSgx9aML2ep4cYPU03GQtg71mfMpi_vI50IG9A OQLuCG_xlVgELCjCf22DM4Ys.XTXb2cxVOqkD8tqBGNVlYA_HKlB_wNgTmktAm2gjnZ.r2OQql9s qtlHn1sTQsw-- X-Sonic-MF: Message-ID: <024b9ab9-4204-aebb-9f89-95cbabdfe868@aol.com> Date: Mon, 9 Jan 2023 19:07:25 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v7] xen/pt: reserve PCI slot 2 for Intel igd-passthru Content-Language: en-US To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org, Stefano Stabellini , Anthony Perard , Paul Durrant , Paolo Bonzini , Richard Henderson , Eduardo Habkost , Marcel Apfelbaum , xen-devel@lists.xenproject.org References: <8349506149de6d81b0762f17623552c248439e93.1673297742.git.brchuckz.ref@aol.com> <8349506149de6d81b0762f17623552c248439e93.1673297742.git.brchuckz@aol.com> <20230109172738-mutt-send-email-mst@kernel.org> <8c2531a8-ce99-7593-99f8-222076fe6bd6@aol.com> <20230109183413-mutt-send-email-mst@kernel.org> From: Chuck Zmudzinski In-Reply-To: <20230109183413-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.20982 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 3331 On 1/9/23 6:35 PM, Michael S. Tsirkin wrote: > On Mon, Jan 09, 2023 at 06:28:44PM -0500, Chuck Zmudzinski wrote: >> On 1/9/23 5:33 PM, Michael S. Tsirkin wrote: >> > On Mon, Jan 09, 2023 at 04:55:42PM -0500, Chuck Zmudzinski wrote: >> >> Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, >> >> as noted in docs/igd-assign.txt in the Qemu source code. >> >> >> >> Currently, when the xl toolstack is used to configure a Xen HVM guest with >> >> Intel IGD passthrough to the guest with the Qemu upstream device model, >> >> a Qemu emulated PCI device will occupy slot 2 and the Intel IGD will occupy >> >> a different slot. This problem often prevents the guest from booting. >> >> >> >> The only available workaround is not good: Configure Xen HVM guests to use >> >> the old and no longer maintained Qemu traditional device model available >> >> from xenbits.xen.org which does reserve slot 2 for the Intel IGD. >> >> >> >> To implement this feature in the Qemu upstream device model for Xen HVM >> >> guests, introduce the following new functions, types, and macros: >> >> >> >> * XEN_PT_DEVICE_CLASS declaration, based on the existing TYPE_XEN_PT_DEVICE >> >> * XEN_PT_DEVICE_GET_CLASS macro helper function for XEN_PT_DEVICE_CLASS >> >> * typedef XenPTQdevRealize function pointer >> >> * XEN_PCI_IGD_SLOT_MASK, the value of slot_reserved_mask to reserve slot 2 >> >> * xen_igd_reserve_slot and xen_igd_clear_slot functions >> >> >> >> The new xen_igd_reserve_slot function uses the existing slot_reserved_mask >> >> member of PCIBus to reserve PCI slot 2 for Xen HVM guests configured using >> >> the xl toolstack with the gfx_passthru option enabled, which sets the >> >> igd-passthru=on option to Qemu for the Xen HVM machine type. >> > >> > I don't like how slot_reserved_mask is set initially then cleared on >> > device realize. >> > To me this looks like a fragile hack. I suggest one of the following >> > 1. adding a new mask >> > "slot-manual-mask" or some such blocking auto-allocation of a given >> > slot without blocking its use if address is specified on command line. >> > 2. adding a special property that overrides slot_reserved_mask >> > for a given device. >> > >> > both need changes in pci core but look like something generally >> > useful. >> >> I was hoping to not need to touch pci core but I understand it would be >> better for this patch to not affect machines that are manually configured >> on the command line. >> >> However, keep in mind that this patch will only actually reserve the slot >> initially for xen hvm machines (machine type "xenfv") that also are configured >> with the qemu igd-passthru=on option which, AFAIK, only applies to machines >> witn accel=xen. It will not affect kvm users at all. So I don't think this patch >> will break many machines out there that manually specify the pci slots. The >> only machines it could affect are machines configured for igd-passthru on xen. >> This patch also does *not* reserve the slot initially for "xenfv" machines that >> are not configured with igd passthrough which I am sure is the vast majority >> of all the xen virtual machines out in the wild. > > I'm just saying that adding a capability that is generally useful > as opposed to xen specific means less technical debt. > I agree with that. From xen-devel-bounces@lists.xenproject.org Tue Jan 10 00:17:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 00:17:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474166.735160 (Exim 4.92) (envelope-from ) id 1pF2Kg-0005D5-NR; Tue, 10 Jan 2023 00:17:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474166.735160; Tue, 10 Jan 2023 00:17:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF2Kg-0005Cy-KU; Tue, 10 Jan 2023 00:17:38 +0000 Received: by outflank-mailman (input) for mailman id 474166; Tue, 10 Jan 2023 00:17:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF2Kf-0005Co-L8; Tue, 10 Jan 2023 00:17:37 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF2Kf-0005v7-I8; Tue, 10 Jan 2023 00:17:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF2Kf-0004Rx-6A; Tue, 10 Jan 2023 00:17:37 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pF2Kf-0003EC-5l; Tue, 10 Jan 2023 00:17:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=P3PEUlpPfGYvhrI+5O2g3+h8o+ytp3+GaGAYrHXmpZY=; b=m8VqvhTocGQVFIZEBpzBjcDnC8 CyXMZJqKpwPXyPgnloJht/A7L4EZCIng5ZDY0LiTHw8xlomsAPku2Mvnu0JvpHz5HKV1JXJhZ5YvF YfUayoztU4HjFxMLs4jxi9tnVyqzAe1NI/KRpos+NQY/4Nv79U/vlkAMqHg0Zt4TxZ60=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 175664: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-amd64-xsm:xen-build:fail:regression qemu-mainline:build-amd64:xen-build:fail:regression qemu-mainline:build-i386:xen-build:fail:regression qemu-mainline:build-arm64-xsm:xen-build:fail:regression qemu-mainline:build-i386-xsm:xen-build:fail:regression qemu-mainline:build-arm64:xen-build:fail:regression qemu-mainline:build-armhf:xen-build:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-coresched-amd64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:build-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-rtds:build-check(1):blocked:nonblocking qemu-mainline:build-arm64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking qemu-mainline:build-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking qemu-mainline:build-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-dom0pvh-xl-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-dom0pvh-xl-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvshim:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-pygrub:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvhv2-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-freebsd11-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-freebsd12-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvhv2-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-multivcpu:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: qemuu=aa96ab7c9df59c615ca82b49c9062819e0a1c287 X-Osstest-Versions-That: qemuu=0ab12aa32462817f0a53fa6f6ce4baf664ef1713 From: osstest service owner Date: Tue, 10 Jan 2023 00:17:37 +0000 flight 175664 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/175664/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 175623 build-amd64 6 xen-build fail REGR. vs. 175623 build-i386 6 xen-build fail REGR. vs. 175623 build-arm64-xsm 6 xen-build fail REGR. vs. 175623 build-i386-xsm 6 xen-build fail REGR. vs. 175623 build-arm64 6 xen-build fail REGR. vs. 175623 build-armhf 6 xen-build fail REGR. vs. 175623 Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-win7-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ws16-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-shadow 1 build-check(1) blocked n/a test-amd64-i386-xl-vhd 1 build-check(1) blocked n/a test-amd64-i386-xl-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) blocked n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) blocked n/a test-armhf-armhf-xl-rtds 1 build-check(1) blocked n/a test-armhf-armhf-xl-vhd 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-amd 1 build-check(1) blocked n/a test-amd64-i386-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-i386 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-amd64 1 build-check(1) blocked n/a test-amd64-coresched-i386-xl 1 build-check(1) blocked n/a test-amd64-coresched-amd64-xl 1 build-check(1) blocked n/a test-amd64-amd64-xl-xsm 1 build-check(1) blocked n/a build-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-shadow 1 build-check(1) blocked n/a test-amd64-amd64-xl-rtds 1 build-check(1) blocked n/a build-arm64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ws16-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a build-armhf-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-amd64-dom0pvh-xl-amd 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 1 build-check(1) blocked n/a test-amd64-amd64-dom0pvh-xl-intel 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvshim 1 build-check(1) blocked n/a test-amd64-amd64-pair 1 build-check(1) blocked n/a test-amd64-amd64-pygrub 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvhv2-intel 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-freebsd11-amd64 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-freebsd12-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvhv2-amd 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-nested-amd 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-nested-intel 1 build-check(1) blocked n/a test-amd64-amd64-xl-multivcpu 1 build-check(1) blocked n/a test-amd64-amd64-xl 1 build-check(1) blocked n/a test-amd64-amd64-xl-credit1 1 build-check(1) blocked n/a test-amd64-amd64-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-arndale 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-intel 1 build-check(1) blocked n/a test-amd64-i386-xl 1 build-check(1) blocked n/a test-amd64-i386-xl-pvshim 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a version targeted for testing: qemuu aa96ab7c9df59c615ca82b49c9062819e0a1c287 baseline version: qemuu 0ab12aa32462817f0a53fa6f6ce4baf664ef1713 Last test of basis 175623 2023-01-07 23:09:00 Z 2 days Failing since 175627 2023-01-08 14:40:14 Z 1 days 7 attempts Testing same since 175654 2023-01-09 18:08:58 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Ard Biesheuvel Bernhard Beschow Christian Borntraeger Cindy Lu Dongli Zhang Eugenio Pérez Greg Kurz Guoyi Tu Hyman Huang(黄勇) Igor Mammedov Jason Wang Jonathan Cameron Kai Huang Laszlo Ersek Lei Xiang leixiang Liuxiangdong Longpeng Lubomir Rintel Marc-André Lureau Markus Armbruster Michael S. Tsirkin Nikita Ivanov Paolo Bonzini Peter Maydell Philippe Mathieu-Daudé Richard Henderson Thomas Huth Yanan Wang Yicong Yang Zeng Chi jobs: build-amd64-xsm fail build-arm64-xsm fail build-i386-xsm fail build-amd64 fail build-arm64 fail build-armhf fail build-i386 fail build-amd64-libvirt blocked build-arm64-libvirt blocked build-armhf-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl blocked test-amd64-coresched-amd64-xl blocked test-arm64-arm64-xl blocked test-armhf-armhf-xl blocked test-amd64-i386-xl blocked test-amd64-coresched-i386-xl blocked test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm blocked test-amd64-i386-xl-qemuu-debianhvm-i386-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm blocked test-arm64-arm64-xl-xsm blocked test-amd64-i386-xl-xsm blocked test-amd64-amd64-qemuu-nested-amd blocked test-amd64-amd64-xl-pvhv2-amd blocked test-amd64-i386-qemuu-rhel6hvm-amd blocked test-amd64-amd64-dom0pvh-xl-amd blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64 blocked test-amd64-i386-xl-qemuu-debianhvm-amd64 blocked test-amd64-i386-freebsd10-amd64 blocked test-amd64-amd64-qemuu-freebsd11-amd64 blocked test-amd64-amd64-qemuu-freebsd12-amd64 blocked test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked test-amd64-amd64-xl-qemuu-win7-amd64 blocked test-amd64-i386-xl-qemuu-win7-amd64 blocked test-amd64-amd64-xl-qemuu-ws16-amd64 blocked test-amd64-i386-xl-qemuu-ws16-amd64 blocked test-armhf-armhf-xl-arndale blocked test-amd64-amd64-xl-credit1 blocked test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 blocked test-amd64-amd64-xl-credit2 blocked test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 blocked test-armhf-armhf-xl-cubietruck blocked test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict blocked test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict blocked test-amd64-i386-freebsd10-i386 blocked test-amd64-amd64-qemuu-nested-intel blocked test-amd64-amd64-xl-pvhv2-intel blocked test-amd64-i386-qemuu-rhel6hvm-intel blocked test-amd64-amd64-dom0pvh-xl-intel blocked test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu blocked test-armhf-armhf-xl-multivcpu blocked test-amd64-amd64-pair blocked test-amd64-i386-pair blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim blocked test-amd64-i386-xl-pvshim blocked test-amd64-amd64-pygrub blocked test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds blocked test-armhf-armhf-xl-rtds blocked test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow blocked test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow blocked test-amd64-amd64-xl-shadow blocked test-amd64-i386-xl-shadow blocked test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd blocked test-amd64-i386-xl-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2556 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Jan 10 00:29:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 00:29:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474175.735170 (Exim 4.92) (envelope-from ) id 1pF2Vh-0006mh-Pq; Tue, 10 Jan 2023 00:29:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474175.735170; Tue, 10 Jan 2023 00:29:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF2Vh-0006ma-N7; Tue, 10 Jan 2023 00:29:01 +0000 Received: by outflank-mailman (input) for mailman id 474175; Tue, 10 Jan 2023 00:29:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF2Vg-0006mU-N4 for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 00:29:00 +0000 Received: from mail-vk1-xa36.google.com (mail-vk1-xa36.google.com [2607:f8b0:4864:20::a36]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c577b713-907d-11ed-b8d0-410ff93cb8f0; Tue, 10 Jan 2023 01:28:58 +0100 (CET) Received: by mail-vk1-xa36.google.com with SMTP id w72so4849940vkw.7 for ; Mon, 09 Jan 2023 16:28:58 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c577b713-907d-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=SGOLN4L23AISJAYP2mb4TczTko7Qm/ptrKoRepXprRE=; b=AFBsG7uWOPQh5GjM8gNJxVCD0aL0hoKK7sbEQNiV7AMIVKrIb+GH2YSHRUE3Ko7rI1 BcwtSwJN25Alg3nNY79MxqKw+afcTxSoGdRNPti3JSg4vQCnd6V7NDLX83RPpAtuc3fb Bv4Y6RnczOdeQeRrlKuIt8/k5uL2AMD5To8pniZRKY1X8NiXXrLw1up/231qX1YiZKp3 pZLK6UKnXti9gjAfqtKo/AdkXmT7+I+Uhz9yIoId1s5lXB/HXbcUpYOwBb5dV6MTKDgN BLu1lSIOiKcD4EoGDinM4fxGSC3pu7jDCmq2sfHPH6ZuuNoYywYvwhonFEaHHQDQVpl+ mRAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SGOLN4L23AISJAYP2mb4TczTko7Qm/ptrKoRepXprRE=; b=LgQwlYyJCaVvbsADAKT8mUglij9JMEHWeNI7/14D3ykbYCseOaR1UUImTbDTasnx3u lCjgGYJw4P5fWC/zOLYKavMgxijSK+Cb4ZwZ/IOrH5csd9mEQSQ8Rc1uq5GOKDCFTLWF EfY2Dtyb/3T5lXIE2NQEr9lRz0YLC2T812EyMAIudfMoiv7IoxLIUpw+quxaqB0omRQN wN7iHcShqdnMDOagDMV9ykI1IDHvp/xjWHdZXL90My16fsbkS8h4NsgR66Y2gJOBk2L5 GH+QswqCe7Ps7kKsMPPZafoC+on/r2Gih1jYidDqeiws9JOyzlovNtlseaM1QhkqYNqF rBfQ== X-Gm-Message-State: AFqh2kquc5xfDXcAOFJJbWCOfhh+v6exbAArtnpijEa3MIoKfTvF0FIB tMbbAc+0E18XL5nM+ctFRbskXVLeRdEDxydra5Q= X-Google-Smtp-Source: AMrXdXvJTtjn/avlGGgsNUpAucdZpkVW+3PjRmuldxgTr47AVrU/8YnXmDCRnhJy3ttHhZDle2IAxOnSVBWIbE4+qXI= X-Received: by 2002:a1f:c703:0:b0:3d5:6ccb:8748 with SMTP id x3-20020a1fc703000000b003d56ccb8748mr6418658vkf.26.1673310537196; Mon, 09 Jan 2023 16:28:57 -0800 (PST) MIME-Version: 1.0 References: <527727b2c9e26e6ef7714fe9a3fbe580caf1ae13.1673278109.git.oleksii.kurochko@gmail.com> In-Reply-To: <527727b2c9e26e6ef7714fe9a3fbe580caf1ae13.1673278109.git.oleksii.kurochko@gmail.com> From: Alistair Francis Date: Tue, 10 Jan 2023 10:28:31 +1000 Message-ID: Subject: Re: [PATCH v2 6/8] xen/riscv: introduce early_printk basic stuff To: Oleksii Kurochko Cc: xen-devel@lists.xenproject.org, Jan Beulich , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , Bobby Eshleman Content-Type: text/plain; charset="UTF-8" On Tue, Jan 10, 2023 at 1:47 AM Oleksii Kurochko wrote: > > The patch introduces a basic stuff of early_printk functionality > which will be enough to print 'hello from C environment". > early_printk() function was changed in comparison with original as > common isn't being built now so there is no vscnprintf. > > Because printk() relies on a serial driver (like the ns16550 driver) > and drivers require working virtual memory (ioremap()) there is not > print functionality early in Xen boot. > > This commit adds early printk implementation built on the putc SBI call. > > As sbi_console_putchar() is being already planned for deprecation > it is used temporary now and will be removed or reworked after > real uart will be ready. There was a discussion to add a new SBI putchar replacement. It doesn't seem to be completed yet, but there might be an SBI replacement for this in the future as well. Alistair > > Signed-off-by: Bobby Eshleman > Signed-off-by: Oleksii Kurochko > --- > Changes in V2: > - add license to early_printk.c > - add signed-off-by Bobby > - add RISCV_32 to Kconfig.debug to EARLY_PRINTK config > - update commit message > - order the files alphabetically in Makefile > --- > xen/arch/riscv/Kconfig.debug | 7 +++++ > xen/arch/riscv/Makefile | 1 + > xen/arch/riscv/early_printk.c | 33 +++++++++++++++++++++++ > xen/arch/riscv/include/asm/early_printk.h | 12 +++++++++ > 4 files changed, 53 insertions(+) > create mode 100644 xen/arch/riscv/early_printk.c > create mode 100644 xen/arch/riscv/include/asm/early_printk.h > > diff --git a/xen/arch/riscv/Kconfig.debug b/xen/arch/riscv/Kconfig.debug > index e69de29bb2..6ba0bd1e5a 100644 > --- a/xen/arch/riscv/Kconfig.debug > +++ b/xen/arch/riscv/Kconfig.debug > @@ -0,0 +1,7 @@ > +config EARLY_PRINTK > + bool "Enable early printk config" > + default DEBUG > + depends on RISCV_64 || RISCV_32 > + help > + > + Enables early printk debug messages > diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile > index fd916e1004..1a4f1a6015 100644 > --- a/xen/arch/riscv/Makefile > +++ b/xen/arch/riscv/Makefile > @@ -1,3 +1,4 @@ > +obj-$(CONFIG_EARLY_PRINTK) += early_printk.o > obj-$(CONFIG_RISCV_64) += riscv64/ > obj-y += sbi.o > obj-y += setup.o > diff --git a/xen/arch/riscv/early_printk.c b/xen/arch/riscv/early_printk.c > new file mode 100644 > index 0000000000..88da5169ed > --- /dev/null > +++ b/xen/arch/riscv/early_printk.c > @@ -0,0 +1,33 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * RISC-V early printk using SBI > + * > + * Copyright (C) 2021 Bobby Eshleman > + */ > +#include > +#include > + > +/* > + * TODO: > + * sbi_console_putchar is already planned for deprication > + * so it should be reworked to use UART directly. > +*/ > +void early_puts(const char *s, size_t nr) > +{ > + while ( nr-- > 0 ) > + { > + if (*s == '\n') > + sbi_console_putchar('\r'); > + sbi_console_putchar(*s); > + s++; > + } > +} > + > +void early_printk(const char *str) > +{ > + while (*str) > + { > + early_puts(str, 1); > + str++; > + } > +} > diff --git a/xen/arch/riscv/include/asm/early_printk.h b/xen/arch/riscv/include/asm/early_printk.h > new file mode 100644 > index 0000000000..05106e160d > --- /dev/null > +++ b/xen/arch/riscv/include/asm/early_printk.h > @@ -0,0 +1,12 @@ > +#ifndef __EARLY_PRINTK_H__ > +#define __EARLY_PRINTK_H__ > + > +#include > + > +#ifdef CONFIG_EARLY_PRINTK > +void early_printk(const char *str); > +#else > +static inline void early_printk(const char *s) {}; > +#endif > + > +#endif /* __EARLY_PRINTK_H__ */ > -- > 2.38.1 > > From xen-devel-bounces@lists.xenproject.org Tue Jan 10 00:29:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 00:29:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474180.735181 (Exim 4.92) (envelope-from ) id 1pF2WP-0007IF-1m; Tue, 10 Jan 2023 00:29:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474180.735181; Tue, 10 Jan 2023 00:29:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF2WO-0007I8-VN; Tue, 10 Jan 2023 00:29:44 +0000 Received: by outflank-mailman (input) for mailman id 474180; Tue, 10 Jan 2023 00:29:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF2WN-0007Ck-Ev for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 00:29:43 +0000 Received: from mail-vs1-xe2d.google.com (mail-vs1-xe2d.google.com [2607:f8b0:4864:20::e2d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id dfdf769c-907d-11ed-91b6-6bf2151ebd3b; Tue, 10 Jan 2023 01:29:42 +0100 (CET) Received: by mail-vs1-xe2d.google.com with SMTP id n190so6749524vsc.11 for ; Mon, 09 Jan 2023 16:29:42 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dfdf769c-907d-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=eilaCtkBAmz2kS2wmB1ZZ+vUiTwTrEsVsNPmPjJb+lw=; b=m8mPtcFkKDEZ7LNPyapf1VWpZVk5ILpNQQiBFgHcppCOVBUiCHtIuTpyskfeEMhf8d SjpYD9G3pgHuU7WYAok7IOehwBtfN/rDv6rchYZP0rE3l8MSpiy720x9+eg5IboIITSa Vz6jVR+7RY99OHdFm1yPBLJrccsT4eJ6HK6jEcurYHKzwT0B+KvUrn2suCP7DtLxtAKR 4S42L2m7A0rzmFusMNeG+l2Y9j9DtnM/VKsSE/11TXOzeKFrB2LXydssx4jHh0uPBRHr YGdnm1k+Sv06cJTB5uLAa94mHGG6Jjmpero/Xbplzfi6jbPFuj26PSCuugNUAxmcP3AJ Zt+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=eilaCtkBAmz2kS2wmB1ZZ+vUiTwTrEsVsNPmPjJb+lw=; b=rUWVhjJlZ27sKZDgNoivjA634vvI/dobpBU+2i5+UGPoi4FNIkh0jxGUeR8hmWlKfW gW1yHGNvf+VtPTKpd9PrncN07FZOe9/5/gvJQSroiubltd3fP2GTWC3d9jX3ia5zBUCX m2I9KbTFCopIbXqzRa1g7Oj3RM8BxQ1ki9fRFgjDUegoqXbwmOajG4t/K5cSXLuV0s5i e8OLi4hSZwVI72bt5AUHcbtIPX8Pcv6E++Oe59X2d+KxwSfs0FLwuS3Y15Bz93fYO1H3 x/JR3dwkNTgvv1BFnHWcxWJMr82bOQy5Xb3tZ+okbPPv0lBt23VKIVv9gSnid/dDHQQI 1D0g== X-Gm-Message-State: AFqh2krF1kJyJVrKE+2OLl/7sjM0252BarTOSc1f8s9QKBzE2EUqLtq5 gCdFnR2oSehRGBViVHhMs39kGPtzyFojDBEFBp4= X-Google-Smtp-Source: AMrXdXuulYEaUvGd4+oZ43DaWUmRvtWUb4V7wXrDOlcrTLfH4+TtNKibAwr17T9JXLOZ+Dov/cGG6ZMFGDkH8V/Qs50= X-Received: by 2002:a05:6102:f8c:b0:3c9:8cc2:dd04 with SMTP id e12-20020a0561020f8c00b003c98cc2dd04mr7246662vsv.73.1673310581572; Mon, 09 Jan 2023 16:29:41 -0800 (PST) MIME-Version: 1.0 References: <837bb553a539713d4aa15bb169142018bf508afe.1673278109.git.oleksii.kurochko@gmail.com> In-Reply-To: <837bb553a539713d4aa15bb169142018bf508afe.1673278109.git.oleksii.kurochko@gmail.com> From: Alistair Francis Date: Tue, 10 Jan 2023 10:29:15 +1000 Message-ID: Subject: Re: [PATCH v2 7/8] xen/riscv: print hello message from C env To: Oleksii Kurochko Cc: xen-devel@lists.xenproject.org, Jan Beulich , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis Content-Type: text/plain; charset="UTF-8" On Tue, Jan 10, 2023 at 1:47 AM Oleksii Kurochko wrote: > > Signed-off-by: Oleksii Kurochko Reviewed-by: Alistair Francis Alistair > --- > xen/arch/riscv/riscv64/head.S | 4 +--- > xen/arch/riscv/setup.c | 12 ++++++++++++ > 2 files changed, 13 insertions(+), 3 deletions(-) > > diff --git a/xen/arch/riscv/riscv64/head.S b/xen/arch/riscv/riscv64/head.S > index c1f33a1934..d444dd8aad 100644 > --- a/xen/arch/riscv/riscv64/head.S > +++ b/xen/arch/riscv/riscv64/head.S > @@ -5,6 +5,4 @@ ENTRY(start) > li t0, STACK_SIZE > add sp, sp, t0 > > -_start_hang: > - wfi > - j _start_hang > + tail start_xen > diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c > index 41ef4912bd..586060c7e5 100644 > --- a/xen/arch/riscv/setup.c > +++ b/xen/arch/riscv/setup.c > @@ -1,6 +1,18 @@ > #include > #include > > +#include > + > /* Xen stack for bringing up the first CPU. */ > unsigned char __initdata cpu0_boot_stack[STACK_SIZE] > __aligned(STACK_SIZE); > + > +void __init noreturn start_xen(void) > +{ > + early_printk("Hello from C env\n"); > + > + for ( ;; ) > + asm volatile ("wfi"); > + > + unreachable(); > +} > -- > 2.38.1 > > From xen-devel-bounces@lists.xenproject.org Tue Jan 10 01:46:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 01:46:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474193.735211 (Exim 4.92) (envelope-from ) id 1pF3iS-0005Fc-OO; Tue, 10 Jan 2023 01:46:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474193.735211; Tue, 10 Jan 2023 01:46:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF3iS-0005FD-I2; Tue, 10 Jan 2023 01:46:16 +0000 Received: by outflank-mailman (input) for mailman id 474193; Tue, 10 Jan 2023 01:46:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF3iR-0005F3-Bf; Tue, 10 Jan 2023 01:46:15 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF3iR-0006OO-6p; Tue, 10 Jan 2023 01:46:15 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF3iQ-0007LJ-S9; Tue, 10 Jan 2023 01:46:14 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pF3iQ-0002zg-Qv; Tue, 10 Jan 2023 01:46:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To; bh=2f+4UnnW2L0E78oK3XKT0P04CWg/J3/IH9hbTWv20yI=; b=MiN2pKzuTq2+sH4gBx8527trrI DM39To0e/IUKgmiqZno2FHRxQc9D/RYMKeIDgC4fthtaM0a0HbyGG6rKIDyQWraTfPLHOxroQQhUP vaRLa1Zy5ysRHGHEO7YMmO/JdCGgklgd2YHMwOWOHWibyRP6FFjE0dkJznw5sP6Z4TeQ=; To: xen-devel@lists.xenproject.org Subject: [qemu-mainline bisection] complete build-i386-xsm Message-Id: From: osstest service owner Date: Tue, 10 Jan 2023 01:46:14 +0000 branch xen-unstable xenbranch xen-unstable job build-i386-xsm testid xen-build Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://git.qemu.org/qemu.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git *** Found and reproduced problem changeset *** Bug is in tree: qemuu git://git.qemu.org/qemu.git Bug introduced: 3d83b78285d6e96636130f7d449fd02e2d4deee0 Bug not present: 528d9f33cad5245c1099d77084c78bb2244d5143 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/175675/ commit 3d83b78285d6e96636130f7d449fd02e2d4deee0 Merge: 528d9f33ca fb418b51b7 Author: Peter Maydell Date: Sun Jan 8 14:27:40 2023 +0000 Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging * Atomic memslot updates for KVM (Emanuele, David) * Always send errors to logfile when daemonized (Greg) * Add support for IDE CompactFlash card (Lubomir) * First round of build system cleanups (myself) * First round of feature removals (myself) * Reduce "qemu/accel.h" inclusion (Philippe) # gpg: Signature made Thu 05 Jan 2023 23:51:09 GMT # gpg: using RSA key F13338574B662389866C7682BFFBD25F78C7AE83 # gpg: issuer "pbonzini@redhat.com" # gpg: Good signature from "Paolo Bonzini " [full] # gpg: aka "Paolo Bonzini " [full] # Primary key fingerprint: 46F5 9FBD 57D6 12E7 BFD4 E2F7 7E15 100C CD36 69B1 # Subkey fingerprint: F133 3857 4B66 2389 866C 7682 BFFB D25F 78C7 AE83 * tag 'for-upstream' of https://gitlab.com/bonzini/qemu: (24 commits) i386: SGX: remove deprecated member of SGXInfo target/i386: Add SGX aex-notify and EDECCSSA support util: remove support -chardev tty and -chardev parport util: remove support for hex numbers with a scaling suffix KVM: remove support for kernel-irqchip=off docs: do not talk about past removal as happening in the future meson: accept relative symlinks in "meson introspect --installed" data meson: cleanup compiler detection meson: support meson 0.64 -Doptimization=plain configure: test all warnings tests/qapi-schema: remove Meson workaround meson: cleanup dummy-cpus.c rules meson: tweak hardening options for Windows configure: remove backwards-compatibility and obsolete options configure: preserve qemu-ga variables configure: cleanup $cpu tests configure: remove dead function configure: remove useless write_c_skeleton ide: Add "ide-cf" driver, a CompactFlash card ide: Add 8-bit data mode ... Signed-off-by: Peter Maydell commit fb418b51b7b43c34873f4b9af3da7031b7452115 Author: Paolo Bonzini Date: Fri Dec 16 11:02:48 2022 +0100 i386: SGX: remove deprecated member of SGXInfo Signed-off-by: Paolo Bonzini commit d45f24fe7525d8a8aaa4ca6d9d214dc41819caa5 Author: Kai Huang Date: Wed Nov 9 15:48:34 2022 +1300 target/i386: Add SGX aex-notify and EDECCSSA support The new SGX Asynchronous Exit (AEX) notification mechanism (AEX-notify) allows one enclave to receive a notification in the ERESUME after the enclave exit due to an AEX. EDECCSSA is a new SGX user leaf function (ENCLU[EDECCSSA]) to facilitate the AEX notification handling. Whether the hardware supports to create enclave with AEX-notify support is enumerated via CPUID.(EAX=0x12,ECX=0x1):EAX[10]. The new EDECCSSA user leaf function is enumerated via CPUID.(EAX=0x12,ECX=0x0):EAX[11]. Add support to allow to expose the new SGX AEX-notify feature and the new EDECCSSA user leaf function to KVM guest. Link: https://lore.kernel.org/lkml/166760360549.4906.809756297092548496.tip-bot2@tip-bot2/ Link: https://lore.kernel.org/lkml/166760360934.4906.2427175408052308969.tip-bot2@tip-bot2/ Reviewed-by: Yang Zhong Signed-off-by: Kai Huang Message-Id: <20221109024834.172705-1-kai.huang@intel.com> Signed-off-by: Paolo Bonzini commit 6f9f630836df355b9ca3f4641e6b7be71f6af076 Author: Paolo Bonzini Date: Fri Dec 16 10:56:53 2022 +0100 util: remove support -chardev tty and -chardev parport These were deprecated in 6.0 and can now be removed. Signed-off-by: Paolo Bonzini commit 8b902e3d2309595567e4957b96e971c4f3ca455e Author: Paolo Bonzini Date: Fri Dec 16 10:50:05 2022 +0100 util: remove support for hex numbers with a scaling suffix This was deprecated in 6.0 and can now be removed. Signed-off-by: Paolo Bonzini commit eaaaf8abdc9a9f3493f2cb6a751660dff3f9db57 Author: Paolo Bonzini Date: Fri Dec 16 10:39:32 2022 +0100 KVM: remove support for kernel-irqchip=off -machine kernel-irqchip=off is broken for many guest OSes; kernel-irqchip=split is the replacement that works, so remove the deprecated support for the former. Signed-off-by: Paolo Bonzini commit 9d3f8b3247795ae8f482700bbbace04b04421d5b Author: Paolo Bonzini Date: Fri Dec 16 11:05:20 2022 +0100 docs: do not talk about past removal as happening in the future KVM guest support on 32-bit Arm hosts *has* been removed, so rephrase the sentence describing it. Signed-off-by: Paolo Bonzini commit f32eb0021a85efaca97f69b0e9201737562a8e4f Author: Paolo Bonzini Date: Wed Dec 14 13:25:00 2022 +0100 meson: accept relative symlinks in "meson introspect --installed" data When installing shared libraries, as is the case for libvfio-user.so, Meson will include relative symbolic links in the output of "meson introspect --installed": { "libvfio-user.so": "/usr/local/lib64/libvfio-user.so", ... } In the case of scripts/symlink-install-tree.py, this will be a symbolic link to a symbolic link but, in any case, there is no issue in creating it. Cc: qemu-stable@nongnu.org Signed-off-by: Paolo Bonzini commit e51340243687a2cd7ffcf0d6e2de030bed4b8720 Author: Paolo Bonzini Date: Wed Oct 12 14:15:06 2022 +0200 meson: cleanup compiler detection Detect all compilers at the beginning of meson.build, and store the available languages in an array. Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit 6a97f3939240977e66e90862419911666956a76a Author: Paolo Bonzini Date: Wed Nov 2 13:07:23 2022 +0100 meson: support meson 0.64 -Doptimization=plain In Meson 0.64, the optimization built-in option now accepts the "plain" value, which will not set any optimization flags. While QEMU does not check the contents of the option and therefore does not suffer any ill effect from the new value, it uses get_option to print the optimization flags in the summary. Clean the code up to remove duplication, and check for -Doptimization=plain at the same time. Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit ca9b5c2ebf1aca87677a24c208bf3d0345c0b1aa Author: Paolo Bonzini Date: Wed Oct 12 14:21:22 2022 +0200 configure: test all warnings Some warnings are hardcoded in QEMU_CFLAGS and not tested. There is no particular reason to single out these five, as many more -W flags are present on all the supported compilers. For homogeneity when moving the detection to meson, make them use the same warn_flags infrastructure. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Paolo Bonzini commit 7bef93ff064f540e24a36a31263ae3db2d06b3d2 Author: Paolo Bonzini Date: Wed Dec 14 12:29:11 2022 +0100 tests/qapi-schema: remove Meson workaround The referenced issue has been fixed since version 0.61, so remove the workaround. Signed-off-by: Paolo Bonzini commit 9c9b85d705abdcce0b63f9182d8140dd67bd13fb Author: Paolo Bonzini Date: Thu Jul 22 10:43:00 2021 +0200 meson: cleanup dummy-cpus.c rules Now that qtest is available on all targets including Windows, dummy-cpus.c is included unconditionally in the build. It also does not need to be compiled per-target. Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit 2d73fa74728dccde5cc29c4e56b4d781e4ead7c4 Author: Paolo Bonzini Date: Wed Nov 2 13:03:51 2022 +0100 meson: tweak hardening options for Windows meson.build has been enabling ASLR _only_ for debug builds since commit d2147e04f95f ("configure: move Windows flags detection to meson", 2022-05-07); instead it was supposed to disable it for debug builds. However, the flag has been enabled for DLLs upstream for roughly 2 years (https://sourceware.org/bugzilla/show_bug.cgi?id=19011), and also by some distros including Debian for 6 years even (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=836365). Enable it unconditionally; we can fix the reversed logic of commit d2147e04f95f later if there are any reports, but for now just enable the hardening. Also add -Wl,--high-entropy-va, which also controls ASLR. Signed-off-by: Paolo Bonzini commit 10229ec3b0ff77c4894cefa312c21e65a761dcde Author: Paolo Bonzini Date: Tue Oct 18 10:17:46 2022 +0200 configure: remove backwards-compatibility and obsolete options Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit 954ed68f9934a3e08f904acb93ce168505995e95 Author: Paolo Bonzini Date: Wed Oct 12 11:35:17 2022 +0200 configure: preserve qemu-ga variables Ensure that qemu-ga variables set at configure time are kept later when the script is rerun. For preserve_env to work, the variables need to be empty so move the default values to config-host.mak generation. Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit f9c77801f4992fae99392ccbb60596dfa1fcf04a Author: Paolo Bonzini Date: Wed Oct 12 15:27:03 2022 +0200 configure: cleanup $cpu tests $cpu is derived from preprocessor defines rather than uname these days, so do not bother using isainfo on Solaris. Likewise do not recognize BeOS's uname -m output. Keep the other, less OS-specific canonicalizations for the benefit of people using --cpu. Reviewed-by: Peter Maydell Signed-off-by: Paolo Bonzini commit 91cd485a6dcbc8210666d19146fe73b8664f0418 Author: Paolo Bonzini Date: Tue Oct 18 10:17:25 2022 +0200 configure: remove dead function Reviewed-by: Peter Maydell Signed-off-by: Paolo Bonzini commit c5634e822416e71e00f08f55a521362d8d21264d Author: Paolo Bonzini Date: Thu Oct 20 14:20:06 2022 +0200 configure: remove useless write_c_skeleton This is not needed ever since QEMU stopped detecting -liberty; this happened with the Meson switch but it is quite likely that the library was not really necessary years before. Reviewed-by: Peter Maydell Signed-off-by: Paolo Bonzini commit cec79db38df72ce74d0296b831e90547111bc13c Author: Lubomir Rintel Date: Wed Nov 30 13:03:19 2022 +0100 ide: Add "ide-cf" driver, a CompactFlash card This allows attaching IDE_CFATA device to an IDE bus. Behaves like a CompactFlash card in True IDE mode. Tested with: qemu-system-i386 \$ -device driver=ide-cf,drive=cf,bus=ide.0 \$ -drive id=cf,index=0,format=raw,if=none,file=cf.img Signed-off-by: Lubomir Rintel Message-Id: <20221130120319.706885-1-lkundrak@v3.sk> Signed-off-by: Paolo Bonzini commit 1ea17d228e582b1cfbf6f61e9da5fafef4063be8 Author: Lubomir Rintel Date: Wed Nov 30 13:02:38 2022 +0100 ide: Add 8-bit data mode CompactFlash uses features 0x01 and 0x81 to enable/disable 8-bit data path. Implement them. Signed-off-by: Lubomir Rintel Message-Id: <20221130120238.706717-1-lkundrak@v3.sk> Signed-off-by: Paolo Bonzini commit 9b063b7ea697d796914b3651d15c3457b7b1135c Author: Greg Kurz Date: Tue Nov 8 15:00:32 2022 +0100 util/log: Always send errors to logfile when daemonized When QEMU is started with `-daemonize`, all stdio descriptors get redirected to `/dev/null`. This basically means that anything printed with error_report() and friends is lost. Current logging code allows to redirect to a file with `-D` but this requires to enable some logging item with `-d` as well to be functional. Relax the check on the log flags when QEMU is daemonized, so that other users of stderr can benefit from the redirection, without the need to enable unwanted debug logs. Previous behaviour is retained for the non-daemonized case. The logic is unrolled as an `if` for better readability. The qemu_log_level and log_per_thread globals reflect the state we want to transition to at this point : use them instead of the intermediary locals for correctness. qemu_set_log_internal() is adapted to open a per-thread log file when '-d tid' is passed. This is done by hijacking qemu_try_lock() which seems simpler that refactoring the code. Signed-off-by: Greg Kurz Message-Id: <20221108140032.1460307-3-groug@kaod.org> Signed-off-by: Paolo Bonzini commit 59bde2137445b63c822720d069d91d38190c6540 Author: Paolo Bonzini Date: Tue Nov 8 15:00:31 2022 +0100 util/log: do not close and reopen log files when flags are turned off log_append makes sure that if you turn off the logging (which clears log_flags and makes need_to_open_file false) the old log is not overwritten. The usecase is that if you remove or move the file QEMU will not keep writing to the old file. However, this is not always the desited behavior, in particular having log_append==1 after changing the file name makes little sense. When qemu_set_log_internal is called from the logfile monitor command, filename must be non-NULL and therefore changed_name must be true. Therefore, the only case where the file is closed and need_to_open_file == false is indeed when log_flags becomes zero. In this case, just flush the file and do not bother closing it, thus faking the same append behavior as previously. The behavioral change is that changing the logfile twice, for example log1 -> log2 -> log1, will cause log1 to be overwritten. This can simply be documented, since it is not a particularly surprising behavior. Suggested-by: Alex Bennée Signed-off-by: Paolo Bonzini Reviewed-by: Richard Henderson Reviewed-by: Greg Kurz Message-Id: <20221025092119.236224-1-pbonzini@redhat.com> [groug: nullify global_file before actually closing the file] Signed-off-by: Greg Kurz Message-Id: <20221108140032.1460307-2-groug@kaod.org> Signed-off-by: Paolo Bonzini commit cc6ff741123216550997b12cdd991beeed47bd0d Author: Philippe Mathieu-Daudé Date: Wed Nov 30 14:56:41 2022 +0100 hw: Reduce "qemu/accel.h" inclusion Move "qemu/accel.h" include from the heavily included "hw/boards.h" to hw/core/machine.c, the single file using the AccelState definition. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Fabiano Rosas Message-Id: <20221130135641.85328-3-philmd@linaro.org> Signed-off-by: Paolo Bonzini commit 3d277871f39d4de42f56b7b0cef5721e525b2d31 Author: Philippe Mathieu-Daudé Date: Wed Nov 30 14:56:40 2022 +0100 typedefs: Forward-declare AccelState Forward-declare AccelState in "qemu/typedefs.h" so structures using a reference of it (like MachineState in "hw/boards.h") don't have to include "qemu/accel.h". Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Fabiano Rosas Message-Id: <20221130135641.85328-2-philmd@linaro.org> Signed-off-by: Paolo Bonzini For bisection revision-tuple graph see: http://logs.test-lab.xenproject.org/osstest/results/bisect/qemu-mainline/build-i386-xsm.xen-build.html Revision IDs in each graph node refer, respectively, to the Trees above. ---------------------------------------- Running cs-bisection-step --graph-out=/home/logs/results/bisect/qemu-mainline/build-i386-xsm.xen-build --summary-out=tmp/175675.bisection-summary --basis-template=175623 --blessings=real,real-bisect,real-retry qemu-mainline build-i386-xsm xen-build Searching for failure / basis pass: 175664 fail [host=nobling1] / 175637 ok. Failure / basis pass flights: 175664 / 175637 (tree with no url: minios) Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://git.qemu.org/qemu.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git Latest 33a3408fbbf988aaa8ecc6e721cf83e3ae810e54 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 aa96ab7c9df59c615ca82b49c9062819e0a1c287 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 Basis pass d8d829b89dababf763ab33b8cdd852b2830db3cf 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 528d9f33cad5245c1099d77084c78bb2244d5143 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 Generating revisions with ./adhoc-revtuple-generator git://xenbits.xen.org/osstest/ovmf.git#d8d829b89dababf763ab33b8cdd852b2830db3cf-33a3408fbbf988aaa8ecc6e721cf83e3ae810e54 git://xenbits.xen.org/qemu-xen-traditional.git#3d273dd05e51e5a1ffba3d98c7437ee84e8f8764-3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 git://git.qemu.org/qemu.git#528d9f33cad5245c1099d77084c78bb2244d5143-aa96ab7c9df59c615ca82b49c9062819e0a1c287 git://xenbits.xen.org/osstest/seabios.git#645a64b4911d7cadf5749d7375544fc2384e70ba-645\ a64b4911d7cadf5749d7375544fc2384e70ba git://xenbits.xen.org/xen.git#2b21cbbb339fb14414f357a6683b1df74c36fda2-2b21cbbb339fb14414f357a6683b1df74c36fda2 Loaded 14998 nodes in revision graph Searching for test results: 175627 [host=albana1] 175637 pass d8d829b89dababf763ab33b8cdd852b2830db3cf 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 528d9f33cad5245c1099d77084c78bb2244d5143 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 175643 fail d8d829b89dababf763ab33b8cdd852b2830db3cf 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 3d83b78285d6e96636130f7d449fd02e2d4deee0 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 175647 fail d8d829b89dababf763ab33b8cdd852b2830db3cf 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 d6271b657286de80260413684a1f2a63f44ea17b 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 175654 fail d8d829b89dababf763ab33b8cdd852b2830db3cf 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 aa96ab7c9df59c615ca82b49c9062819e0a1c287 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 175668 pass d8d829b89dababf763ab33b8cdd852b2830db3cf 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 528d9f33cad5245c1099d77084c78bb2244d5143 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 175669 fail d8d829b89dababf763ab33b8cdd852b2830db3cf 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 aa96ab7c9df59c615ca82b49c9062819e0a1c287 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 175664 fail 33a3408fbbf988aaa8ecc6e721cf83e3ae810e54 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 aa96ab7c9df59c615ca82b49c9062819e0a1c287 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 175670 fail d8d829b89dababf763ab33b8cdd852b2830db3cf 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 3d83b78285d6e96636130f7d449fd02e2d4deee0 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 175673 fail 33a3408fbbf988aaa8ecc6e721cf83e3ae810e54 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 aa96ab7c9df59c615ca82b49c9062819e0a1c287 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 175674 pass d8d829b89dababf763ab33b8cdd852b2830db3cf 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 528d9f33cad5245c1099d77084c78bb2244d5143 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 175675 fail d8d829b89dababf763ab33b8cdd852b2830db3cf 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 3d83b78285d6e96636130f7d449fd02e2d4deee0 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 Searching for interesting versions Result found: flight 175637 (pass), for basis pass Result found: flight 175654 (fail), for basis failure (at ancestor ~4) Repro found: flight 175668 (pass), for basis pass Repro found: flight 175673 (fail), for basis failure 0 revisions at d8d829b89dababf763ab33b8cdd852b2830db3cf 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 528d9f33cad5245c1099d77084c78bb2244d5143 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 No revisions left to test, checking graph state. Result found: flight 175637 (pass), for last pass Result found: flight 175643 (fail), for first failure Repro found: flight 175668 (pass), for last pass Repro found: flight 175670 (fail), for first failure Repro found: flight 175674 (pass), for last pass Repro found: flight 175675 (fail), for first failure *** Found and reproduced problem changeset *** Bug is in tree: qemuu git://git.qemu.org/qemu.git Bug introduced: 3d83b78285d6e96636130f7d449fd02e2d4deee0 Bug not present: 528d9f33cad5245c1099d77084c78bb2244d5143 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/175675/ commit 3d83b78285d6e96636130f7d449fd02e2d4deee0 Merge: 528d9f33ca fb418b51b7 Author: Peter Maydell Date: Sun Jan 8 14:27:40 2023 +0000 Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging * Atomic memslot updates for KVM (Emanuele, David) * Always send errors to logfile when daemonized (Greg) * Add support for IDE CompactFlash card (Lubomir) * First round of build system cleanups (myself) * First round of feature removals (myself) * Reduce "qemu/accel.h" inclusion (Philippe) # gpg: Signature made Thu 05 Jan 2023 23:51:09 GMT # gpg: using RSA key F13338574B662389866C7682BFFBD25F78C7AE83 # gpg: issuer "pbonzini@redhat.com" # gpg: Good signature from "Paolo Bonzini " [full] # gpg: aka "Paolo Bonzini " [full] # Primary key fingerprint: 46F5 9FBD 57D6 12E7 BFD4 E2F7 7E15 100C CD36 69B1 # Subkey fingerprint: F133 3857 4B66 2389 866C 7682 BFFB D25F 78C7 AE83 * tag 'for-upstream' of https://gitlab.com/bonzini/qemu: (24 commits) i386: SGX: remove deprecated member of SGXInfo target/i386: Add SGX aex-notify and EDECCSSA support util: remove support -chardev tty and -chardev parport util: remove support for hex numbers with a scaling suffix KVM: remove support for kernel-irqchip=off docs: do not talk about past removal as happening in the future meson: accept relative symlinks in "meson introspect --installed" data meson: cleanup compiler detection meson: support meson 0.64 -Doptimization=plain configure: test all warnings tests/qapi-schema: remove Meson workaround meson: cleanup dummy-cpus.c rules meson: tweak hardening options for Windows configure: remove backwards-compatibility and obsolete options configure: preserve qemu-ga variables configure: cleanup $cpu tests configure: remove dead function configure: remove useless write_c_skeleton ide: Add "ide-cf" driver, a CompactFlash card ide: Add 8-bit data mode ... Signed-off-by: Peter Maydell commit fb418b51b7b43c34873f4b9af3da7031b7452115 Author: Paolo Bonzini Date: Fri Dec 16 11:02:48 2022 +0100 i386: SGX: remove deprecated member of SGXInfo Signed-off-by: Paolo Bonzini commit d45f24fe7525d8a8aaa4ca6d9d214dc41819caa5 Author: Kai Huang Date: Wed Nov 9 15:48:34 2022 +1300 target/i386: Add SGX aex-notify and EDECCSSA support The new SGX Asynchronous Exit (AEX) notification mechanism (AEX-notify) allows one enclave to receive a notification in the ERESUME after the enclave exit due to an AEX. EDECCSSA is a new SGX user leaf function (ENCLU[EDECCSSA]) to facilitate the AEX notification handling. Whether the hardware supports to create enclave with AEX-notify support is enumerated via CPUID.(EAX=0x12,ECX=0x1):EAX[10]. The new EDECCSSA user leaf function is enumerated via CPUID.(EAX=0x12,ECX=0x0):EAX[11]. Add support to allow to expose the new SGX AEX-notify feature and the new EDECCSSA user leaf function to KVM guest. Link: https://lore.kernel.org/lkml/166760360549.4906.809756297092548496.tip-bot2@tip-bot2/ Link: https://lore.kernel.org/lkml/166760360934.4906.2427175408052308969.tip-bot2@tip-bot2/ Reviewed-by: Yang Zhong Signed-off-by: Kai Huang Message-Id: <20221109024834.172705-1-kai.huang@intel.com> Signed-off-by: Paolo Bonzini commit 6f9f630836df355b9ca3f4641e6b7be71f6af076 Author: Paolo Bonzini Date: Fri Dec 16 10:56:53 2022 +0100 util: remove support -chardev tty and -chardev parport These were deprecated in 6.0 and can now be removed. Signed-off-by: Paolo Bonzini commit 8b902e3d2309595567e4957b96e971c4f3ca455e Author: Paolo Bonzini Date: Fri Dec 16 10:50:05 2022 +0100 util: remove support for hex numbers with a scaling suffix This was deprecated in 6.0 and can now be removed. Signed-off-by: Paolo Bonzini commit eaaaf8abdc9a9f3493f2cb6a751660dff3f9db57 Author: Paolo Bonzini Date: Fri Dec 16 10:39:32 2022 +0100 KVM: remove support for kernel-irqchip=off -machine kernel-irqchip=off is broken for many guest OSes; kernel-irqchip=split is the replacement that works, so remove the deprecated support for the former. Signed-off-by: Paolo Bonzini commit 9d3f8b3247795ae8f482700bbbace04b04421d5b Author: Paolo Bonzini Date: Fri Dec 16 11:05:20 2022 +0100 docs: do not talk about past removal as happening in the future KVM guest support on 32-bit Arm hosts *has* been removed, so rephrase the sentence describing it. Signed-off-by: Paolo Bonzini commit f32eb0021a85efaca97f69b0e9201737562a8e4f Author: Paolo Bonzini Date: Wed Dec 14 13:25:00 2022 +0100 meson: accept relative symlinks in "meson introspect --installed" data When installing shared libraries, as is the case for libvfio-user.so, Meson will include relative symbolic links in the output of "meson introspect --installed": { "libvfio-user.so": "/usr/local/lib64/libvfio-user.so", ... } In the case of scripts/symlink-install-tree.py, this will be a symbolic link to a symbolic link but, in any case, there is no issue in creating it. Cc: qemu-stable@nongnu.org Signed-off-by: Paolo Bonzini commit e51340243687a2cd7ffcf0d6e2de030bed4b8720 Author: Paolo Bonzini Date: Wed Oct 12 14:15:06 2022 +0200 meson: cleanup compiler detection Detect all compilers at the beginning of meson.build, and store the available languages in an array. Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit 6a97f3939240977e66e90862419911666956a76a Author: Paolo Bonzini Date: Wed Nov 2 13:07:23 2022 +0100 meson: support meson 0.64 -Doptimization=plain In Meson 0.64, the optimization built-in option now accepts the "plain" value, which will not set any optimization flags. While QEMU does not check the contents of the option and therefore does not suffer any ill effect from the new value, it uses get_option to print the optimization flags in the summary. Clean the code up to remove duplication, and check for -Doptimization=plain at the same time. Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit ca9b5c2ebf1aca87677a24c208bf3d0345c0b1aa Author: Paolo Bonzini Date: Wed Oct 12 14:21:22 2022 +0200 configure: test all warnings Some warnings are hardcoded in QEMU_CFLAGS and not tested. There is no particular reason to single out these five, as many more -W flags are present on all the supported compilers. For homogeneity when moving the detection to meson, make them use the same warn_flags infrastructure. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Paolo Bonzini commit 7bef93ff064f540e24a36a31263ae3db2d06b3d2 Author: Paolo Bonzini Date: Wed Dec 14 12:29:11 2022 +0100 tests/qapi-schema: remove Meson workaround The referenced issue has been fixed since version 0.61, so remove the workaround. Signed-off-by: Paolo Bonzini commit 9c9b85d705abdcce0b63f9182d8140dd67bd13fb Author: Paolo Bonzini Date: Thu Jul 22 10:43:00 2021 +0200 meson: cleanup dummy-cpus.c rules Now that qtest is available on all targets including Windows, dummy-cpus.c is included unconditionally in the build. It also does not need to be compiled per-target. Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit 2d73fa74728dccde5cc29c4e56b4d781e4ead7c4 Author: Paolo Bonzini Date: Wed Nov 2 13:03:51 2022 +0100 meson: tweak hardening options for Windows meson.build has been enabling ASLR _only_ for debug builds since commit d2147e04f95f ("configure: move Windows flags detection to meson", 2022-05-07); instead it was supposed to disable it for debug builds. However, the flag has been enabled for DLLs upstream for roughly 2 years (https://sourceware.org/bugzilla/show_bug.cgi?id=19011), and also by some distros including Debian for 6 years even (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=836365). Enable it unconditionally; we can fix the reversed logic of commit d2147e04f95f later if there are any reports, but for now just enable the hardening. Also add -Wl,--high-entropy-va, which also controls ASLR. Signed-off-by: Paolo Bonzini commit 10229ec3b0ff77c4894cefa312c21e65a761dcde Author: Paolo Bonzini Date: Tue Oct 18 10:17:46 2022 +0200 configure: remove backwards-compatibility and obsolete options Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit 954ed68f9934a3e08f904acb93ce168505995e95 Author: Paolo Bonzini Date: Wed Oct 12 11:35:17 2022 +0200 configure: preserve qemu-ga variables Ensure that qemu-ga variables set at configure time are kept later when the script is rerun. For preserve_env to work, the variables need to be empty so move the default values to config-host.mak generation. Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit f9c77801f4992fae99392ccbb60596dfa1fcf04a Author: Paolo Bonzini Date: Wed Oct 12 15:27:03 2022 +0200 configure: cleanup $cpu tests $cpu is derived from preprocessor defines rather than uname these days, so do not bother using isainfo on Solaris. Likewise do not recognize BeOS's uname -m output. Keep the other, less OS-specific canonicalizations for the benefit of people using --cpu. Reviewed-by: Peter Maydell Signed-off-by: Paolo Bonzini commit 91cd485a6dcbc8210666d19146fe73b8664f0418 Author: Paolo Bonzini Date: Tue Oct 18 10:17:25 2022 +0200 configure: remove dead function Reviewed-by: Peter Maydell Signed-off-by: Paolo Bonzini commit c5634e822416e71e00f08f55a521362d8d21264d Author: Paolo Bonzini Date: Thu Oct 20 14:20:06 2022 +0200 configure: remove useless write_c_skeleton This is not needed ever since QEMU stopped detecting -liberty; this happened with the Meson switch but it is quite likely that the library was not really necessary years before. Reviewed-by: Peter Maydell Signed-off-by: Paolo Bonzini commit cec79db38df72ce74d0296b831e90547111bc13c Author: Lubomir Rintel Date: Wed Nov 30 13:03:19 2022 +0100 ide: Add "ide-cf" driver, a CompactFlash card This allows attaching IDE_CFATA device to an IDE bus. Behaves like a CompactFlash card in True IDE mode. Tested with: qemu-system-i386 \$ -device driver=ide-cf,drive=cf,bus=ide.0 \$ -drive id=cf,index=0,format=raw,if=none,file=cf.img Signed-off-by: Lubomir Rintel Message-Id: <20221130120319.706885-1-lkundrak@v3.sk> Signed-off-by: Paolo Bonzini commit 1ea17d228e582b1cfbf6f61e9da5fafef4063be8 Author: Lubomir Rintel Date: Wed Nov 30 13:02:38 2022 +0100 ide: Add 8-bit data mode CompactFlash uses features 0x01 and 0x81 to enable/disable 8-bit data path. Implement them. Signed-off-by: Lubomir Rintel Message-Id: <20221130120238.706717-1-lkundrak@v3.sk> Signed-off-by: Paolo Bonzini commit 9b063b7ea697d796914b3651d15c3457b7b1135c Author: Greg Kurz Date: Tue Nov 8 15:00:32 2022 +0100 util/log: Always send errors to logfile when daemonized When QEMU is started with `-daemonize`, all stdio descriptors get redirected to `/dev/null`. This basically means that anything printed with error_report() and friends is lost. Current logging code allows to redirect to a file with `-D` but this requires to enable some logging item with `-d` as well to be functional. Relax the check on the log flags when QEMU is daemonized, so that other users of stderr can benefit from the redirection, without the need to enable unwanted debug logs. Previous behaviour is retained for the non-daemonized case. The logic is unrolled as an `if` for better readability. The qemu_log_level and log_per_thread globals reflect the state we want to transition to at this point : use them instead of the intermediary locals for correctness. qemu_set_log_internal() is adapted to open a per-thread log file when '-d tid' is passed. This is done by hijacking qemu_try_lock() which seems simpler that refactoring the code. Signed-off-by: Greg Kurz Message-Id: <20221108140032.1460307-3-groug@kaod.org> Signed-off-by: Paolo Bonzini commit 59bde2137445b63c822720d069d91d38190c6540 Author: Paolo Bonzini Date: Tue Nov 8 15:00:31 2022 +0100 util/log: do not close and reopen log files when flags are turned off log_append makes sure that if you turn off the logging (which clears log_flags and makes need_to_open_file false) the old log is not overwritten. The usecase is that if you remove or move the file QEMU will not keep writing to the old file. However, this is not always the desited behavior, in particular having log_append==1 after changing the file name makes little sense. When qemu_set_log_internal is called from the logfile monitor command, filename must be non-NULL and therefore changed_name must be true. Therefore, the only case where the file is closed and need_to_open_file == false is indeed when log_flags becomes zero. In this case, just flush the file and do not bother closing it, thus faking the same append behavior as previously. The behavioral change is that changing the logfile twice, for example log1 -> log2 -> log1, will cause log1 to be overwritten. This can simply be documented, since it is not a particularly surprising behavior. Suggested-by: Alex Bennée Signed-off-by: Paolo Bonzini Reviewed-by: Richard Henderson Reviewed-by: Greg Kurz Message-Id: <20221025092119.236224-1-pbonzini@redhat.com> [groug: nullify global_file before actually closing the file] Signed-off-by: Greg Kurz Message-Id: <20221108140032.1460307-2-groug@kaod.org> Signed-off-by: Paolo Bonzini commit cc6ff741123216550997b12cdd991beeed47bd0d Author: Philippe Mathieu-Daudé Date: Wed Nov 30 14:56:41 2022 +0100 hw: Reduce "qemu/accel.h" inclusion Move "qemu/accel.h" include from the heavily included "hw/boards.h" to hw/core/machine.c, the single file using the AccelState definition. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Fabiano Rosas Message-Id: <20221130135641.85328-3-philmd@linaro.org> Signed-off-by: Paolo Bonzini commit 3d277871f39d4de42f56b7b0cef5721e525b2d31 Author: Philippe Mathieu-Daudé Date: Wed Nov 30 14:56:40 2022 +0100 typedefs: Forward-declare AccelState Forward-declare AccelState in "qemu/typedefs.h" so structures using a reference of it (like MachineState in "hw/boards.h") don't have to include "qemu/accel.h". Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Fabiano Rosas Message-Id: <20221130135641.85328-2-philmd@linaro.org> Signed-off-by: Paolo Bonzini Revision graph left in /home/logs/results/bisect/qemu-mainline/build-i386-xsm.xen-build.{dot,ps,png,html,svg}. ---------------------------------------- 175675: tolerable ALL FAIL flight 175675 qemu-mainline real-bisect [real] http://logs.test-lab.xenproject.org/osstest/logs/175675/ Failures :-/ but no regressions. Tests which did not succeed, including tests which could not be run: build-i386-xsm 6 xen-build fail baseline untested jobs: build-i386-xsm fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary From xen-devel-bounces@lists.xenproject.org Tue Jan 10 02:11:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 02:11:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474203.735225 (Exim 4.92) (envelope-from ) id 1pF46v-0000YH-Rh; Tue, 10 Jan 2023 02:11:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474203.735225; Tue, 10 Jan 2023 02:11:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF46v-0000YA-N9; Tue, 10 Jan 2023 02:11:33 +0000 Received: by outflank-mailman (input) for mailman id 474203; Tue, 10 Jan 2023 02:11:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF46u-0000Y4-M4 for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 02:11:33 +0000 Received: from sonic301-20.consmr.mail.gq1.yahoo.com (sonic301-20.consmr.mail.gq1.yahoo.com [98.137.64.146]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 16f7ee39-908c-11ed-b8d0-410ff93cb8f0; Tue, 10 Jan 2023 03:11:28 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.gq1.yahoo.com with HTTP; Tue, 10 Jan 2023 02:11:26 +0000 Received: by hermes--production-ne1-7b69748c4d-55l5b (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 1a4c1345234cf01d6eb27377ae8cdc42; Tue, 10 Jan 2023 02:11:24 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 16f7ee39-908c-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1673316686; bh=7QkjhmpzJKIE7K6fWXoMGD50xZfWbV2q4lJFRzYCwz0=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From:Subject:Reply-To; b=SuLJXzBIvmaPGU4/7UAInN4vmpHqidslwU5vGr7BJuTDvpCKjL6cX8sJXjoaWJVGxDdmCXy/u/QbJdcSYcdE33YlmY7BQ8jSkc/ZlustiOhIWkFbZU1Eim3Jjl9rL4ymJGsCOWZcPBS6wjB/w41M35etW+FsxjiVo/LyOqNQU/nS1Hz7RdlFWt96AutEDO+qs9+tR9cYehmf4IbQSNJF1Ue0UQsnSgtma04JkA3M1DzOKk+4kwZXipyqcNGKXxY0gCgupoGlqM+oGOBtg3OzNwy5it6VjnLfYGP6VI1KHuCcP7jTo1NpBIz/jTfW/lPz+w6EtT5JYE3y/RQxM1d4CA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1673316686; bh=BEwSlhJwTePxyg+41CHEKfeAHlvHKT5e4gskjlhJiWo=; h=X-Sonic-MF:Date:Subject:From:To:From:Subject; b=tdViyb53ly9roW7VuHUEy1/nFSww5xxl0KSqu2lcpHoyCSihfPiwqJR4QmHo2f5gcpfDFV2B552T1th/p7TfAZzILCYWwABU7uETysYp8LZcX6RvY0TUIhs0Iuvtti5Ig7jN18OLKTxlrFAt9yc++e1KOEETlo8iOVI/WfKzKvw4LAv29pS+IhBt+RcMNAxWIJZ1/P2yVUEuPFOyTF5wZ3xvU7QKXqFq3AM9lpEJp6r9HWKW3+/CWSVD13LtTaV1D81WnDpFAB8KRgxAVoViwvbIKhCMlXkGekcoK2N6tBmNucm/Kz90msUYQMZQghCIjqL+2+5NtjZPkbibueQT2g== X-YMail-OSG: 35CxZAcVM1lZMUWXJQtaooaptdpLsLjLj53wxdUyWpdCaRGmP17swB4qW3yzr8e Zv4OIHGnnd6LoDqqAhWFR0Xu9ENP7gGOzqLgzYwP5B8EXSqNv2QOP6u3JDbAAp8uqwq3Hg9LNXED f868PiHt_xX0QPD9R5O4FmqgttXZfG_bqgkm.gSA5LkSpjjtJA8eqmrQ9Cbvn8c81J0PajooDjlo U_bOuXqA_ueQ805CP9zjAH6LZHAOiPjQeGL9W67wWIFbPXm1Kw6HfNDM_1vcCRBr15oFTP.jUhwJ weO360hKMsxZzrcobIcDyGK6ZJliNOY8kcMi3v8Dwm3bP8gfTYjm9AbGbR5RClC469HKhAOoPqQR 4Mfo9w27xaw0.zzxtQKcBFi0qA396ge6H1U6F099Q6Vqk3JDKjZ8X3q0SYvttCyyDboprbEJSDka QAarVhhm9iVAKL9cKLGnYcjA6tVQ4.Vk3am2WJfOH7jH7e0NdjClA6e3Mo2by3EflMOdO2_qFWo_ 9ZCiPiHpLau9IUfEoqv1zWGHi3N3dA0Rwov.rEVsbvwTwTO0gAo7dmwQ0tp8dxppVOysXJYleFBK d0Q7tLw0xtVWDJuL.TVUQA7kswt0I2dOkiKiG54RbdiaNkwbdIg.JUu8JjhgeaG72AovByODBz03 SezF8Q4TNwWWgpTu.m7LFIr7r8huOOQOABbknBRt_40YQ_2WguFf9blnpTxvGsV9e.VnrvBOXHBH w4PcyKnhBq1R23MszMGALFx0dM2LJvT0ay2Th6D3iJ_UfbzilQrcKakoEku0oi7iK1qrJUPImYvo vxZK2Z9I2KHNEpnvRrs.7jybiZudOJbO.yic9NzwGqp9DUODd46Es5X23gyVfUWKt2hHj.YF9Kaq Txyk2.EchmKgwf9Kjts59OlabKAlRlqky_UIQTkFu7hvaqNDpz3RGW_7RbHe.Jj5kjkCt5U6RjhN nkcMFcOSt9c66BiUz2at3ByeUtA4jVLyfvMzIW4NB5dbVpKOGelXZt_i3OuHLBYfBc4fteBhd4n8 kQfdkd1Q2ux.CpO2viGblbbdaQHyt4KkVYcs85GeUt4eMfPje796NKl0BMmsppAn9JYbtQnNPRHI R4FlXuy23wiytu..du88BIQp_nzEmSGbTI6U_BU_lLy4bZBYoqZoC.zO4gEUV7wITS_40KeB_Vfp k7K_cDREhmv5Ak.RPjNHwHGJb0uLPThEy8632FddBdHpO5ZufwubOoXfsa2qtS9QPvb0JlCZDix1 srAPwhB0Q3oRvYvUfIMRGVyFlJw055MGZvt.eqR0UZbxKCkf5kfSytnhk0cCsSbcj1z2AhB2j0FF 0mfjOco3g9809lTqJ47ygeW8jLv6YiyBbttOZBcFYj4YDmNuMbYFXh8s0pzkGp3FkmlVZpRU5.ru 5HlD2cCZHvsrlrZh5jZ72vgvEZeN3CMJi_MsjCusSiFVxBp5323wsvHDg9UW5iWIRPiQugMI.naT MVYbXsHnGms7KiHjPmwBYA.zwVurIExq6J4w4qdnMcQ_xh8e9g.0oL7p4IblHEsC09Q7xzQcLALW 8XZRRikQFINTpx3c.tGXJOwcPX64MwgTkvuOmE7w1CSPBOvMvmHBaieS6DcL6lsj2q53fALkq_07 dASPThG56DoGobRvy5TC5x67jyGqEClXdStEPKXqDJGpPjpEirgc3ZiZPuYrHceFZ9_bRzBlPhf1 880SF7LZ2BjoHCy3mTdA6KMzA_7OENHJnolN6hw4CrqfsKI2a1BN_y2F_vYINQDcRc7asMCMZ7Kc GwgXG_51YmviGOMGiBFc2nFtIM__TkLZxJLXpClhdKBzAdOWt3B5.GECz4Sc2TI5h82kElOPx6i7 ssPuRg7OK6iWF05hNtmO.8aStctDIarZ8._R5x0Ca5m.6RJXdEbAkhzcDAHDjhqOfltAB3V11UPd sxjHiZ4m6yUekcB1nrcZZ2JTjDuAAnLh33XZE1alQomssOdQ0xnmbEzIJHxRBMEbNbW79Gd56rjl TW2FLzilRBMebGLaVqO0YQpQSwvp9We1aby8DATbG0gyjW.2uXMCYNe0eLpAsigj.8TL_OuiJupo VyDjk.1iEyiGttOySsKDGSJm_p6_.W.6LRlNo1RbbrgZXsNfHfhwBGZdjRjoze68L8OCNniUhMVI .jWtauilMJQWRDP4iKtdcbyhdUyAjVxad6D0tMj0iQaZXM3JvBa7PmVjs3SHRnhTkZrKyNQ8_5Kn 2uHpJzDJWROk- X-Sonic-MF: Message-ID: <1542de4a-3b42-0ca4-777a-ce01f75b5532@aol.com> Date: Mon, 9 Jan 2023 21:11:22 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v7] xen/pt: reserve PCI slot 2 for Intel igd-passthru Content-Language: en-US From: Chuck Zmudzinski To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org, Stefano Stabellini , Anthony Perard , Paul Durrant , Paolo Bonzini , Richard Henderson , Eduardo Habkost , Marcel Apfelbaum , xen-devel@lists.xenproject.org References: <8349506149de6d81b0762f17623552c248439e93.1673297742.git.brchuckz.ref@aol.com> <8349506149de6d81b0762f17623552c248439e93.1673297742.git.brchuckz@aol.com> <20230109183132-mutt-send-email-mst@kernel.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.20982 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 14738 On 1/9/2023 7:05 PM, Chuck Zmudzinski wrote: > On 1/9/23 6:33 PM, Michael S. Tsirkin wrote: > > On Mon, Jan 09, 2023 at 04:55:42PM -0500, Chuck Zmudzinski wrote: > >> Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, > >> as noted in docs/igd-assign.txt in the Qemu source code. > >> > >> Currently, when the xl toolstack is used to configure a Xen HVM guest with > >> Intel IGD passthrough to the guest with the Qemu upstream device model, > >> a Qemu emulated PCI device will occupy slot 2 and the Intel IGD will occupy > >> a different slot. This problem often prevents the guest from booting. > >> > >> The only available workaround is not good: Configure Xen HVM guests to use > >> the old and no longer maintained Qemu traditional device model available > >> from xenbits.xen.org which does reserve slot 2 for the Intel IGD. > >> > >> To implement this feature in the Qemu upstream device model for Xen HVM > >> guests, introduce the following new functions, types, and macros: > >> > >> * XEN_PT_DEVICE_CLASS declaration, based on the existing TYPE_XEN_PT_DEVICE > >> * XEN_PT_DEVICE_GET_CLASS macro helper function for XEN_PT_DEVICE_CLASS > >> * typedef XenPTQdevRealize function pointer > >> * XEN_PCI_IGD_SLOT_MASK, the value of slot_reserved_mask to reserve slot 2 > >> * xen_igd_reserve_slot and xen_igd_clear_slot functions > >> > >> The new xen_igd_reserve_slot function uses the existing slot_reserved_mask > >> member of PCIBus to reserve PCI slot 2 for Xen HVM guests configured using > >> the xl toolstack with the gfx_passthru option enabled, which sets the > >> igd-passthru=on option to Qemu for the Xen HVM machine type. > >> > >> The new xen_igd_reserve_slot function also needs to be implemented in > >> hw/xen/xen_pt_stub.c to prevent FTBFS during the link stage for the case > >> when Qemu is configured with --enable-xen and --disable-xen-pci-passthrough, > >> in which case it does nothing. > >> > >> The new xen_igd_clear_slot function overrides qdev->realize of the parent > >> PCI device class to enable the Intel IGD to occupy slot 2 on the PCI bus > >> since slot 2 was reserved by xen_igd_reserve_slot when the PCI bus was > >> created in hw/i386/pc_piix.c for the case when igd-passthru=on. > >> > >> Move the call to xen_host_pci_device_get, and the associated error > >> handling, from xen_pt_realize to the new xen_igd_clear_slot function to > >> initialize the device class and vendor values which enables the checks for > >> the Intel IGD to succeed. The verification that the host device is an > >> Intel IGD to be passed through is done by checking the domain, bus, slot, > >> and function values as well as by checking that gfx_passthru is enabled, > >> the device class is VGA, and the device vendor in Intel. > >> > >> Signed-off-by: Chuck Zmudzinski > >> --- > >> Notes that might be helpful to reviewers of patched code in hw/xen: > >> > >> The new functions and types are based on recommendations from Qemu docs: > >> https://qemu.readthedocs.io/en/latest/devel/qom.html > >> > >> Notes that might be helpful to reviewers of patched code in hw/i386: > >> > >> The small patch to hw/i386/pc_piix.c is protected by CONFIG_XEN so it does > >> not affect builds that do not have CONFIG_XEN defined. > > > > I'm not sure how you can claim that. > > I mean the small patch to pc_piix.c in this patch sits > between an "#ifdef CONFIG_XEN" and the corresponding > "#endif" so the preprocessor will exclude it when CONFIG_XEN > is not defined. In other words, my patch is part of the > xen-specific code in pc_piix.c. Or am I missing something? > > > > > > ... > > > >> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c > >> index b48047f50c..34a9736b5e 100644 > >> --- a/hw/i386/pc_piix.c > >> +++ b/hw/i386/pc_piix.c > >> @@ -32,6 +32,7 @@ > >> #include "hw/i386/pc.h" > >> #include "hw/i386/apic.h" > >> #include "hw/pci-host/i440fx.h" > >> +#include "hw/rtc/mc146818rtc.h" > >> #include "hw/southbridge/piix.h" > >> #include "hw/display/ramfb.h" > >> #include "hw/firmware/smbios.h" > >> @@ -40,16 +41,16 @@ > >> #include "hw/usb.h" > >> #include "net/net.h" > >> #include "hw/ide/pci.h" > >> -#include "hw/ide/piix.h" > >> #include "hw/irq.h" > >> #include "sysemu/kvm.h" > >> #include "hw/kvm/clock.h" > >> #include "hw/sysbus.h" > >> +#include "hw/i2c/i2c.h" > >> #include "hw/i2c/smbus_eeprom.h" > >> #include "hw/xen/xen-x86.h" > >> +#include "hw/xen/xen.h" > >> #include "exec/memory.h" > >> #include "hw/acpi/acpi.h" > >> -#include "hw/acpi/piix4.h" > >> #include "qapi/error.h" > >> #include "qemu/error-report.h" > >> #include "sysemu/xen.h" > >> @@ -66,6 +67,7 @@ > >> #include "kvm/kvm-cpu.h" > >> > >> #define MAX_IDE_BUS 2 > >> +#define XEN_IOAPIC_NUM_PIRQS 128ULL > >> > >> #ifdef CONFIG_IDE_ISA > >> static const int ide_iobase[MAX_IDE_BUS] = { 0x1f0, 0x170 }; > >> @@ -73,6 +75,32 @@ static const int ide_iobase2[MAX_IDE_BUS] = { 0x3f6, 0x376 }; > >> static const int ide_irq[MAX_IDE_BUS] = { 14, 15 }; > >> #endif > >> > >> +/* > >> + * Return the global irq number corresponding to a given device irq > >> + * pin. We could also use the bus number to have a more precise mapping. > >> + */ > >> +static int pci_slot_get_pirq(PCIDevice *pci_dev, int pci_intx) > >> +{ > >> + int slot_addend; > >> + slot_addend = PCI_SLOT(pci_dev->devfn) - 1; > >> + return (pci_intx + slot_addend) & 3; > >> +} > >> + > >> +static void piix_intx_routing_notifier_xen(PCIDevice *dev) > >> +{ > >> + int i; > >> + > >> + /* Scan for updates to PCI link routes (0x60-0x63). */ > >> + for (i = 0; i < PIIX_NUM_PIRQS; i++) { > >> + uint8_t v = dev->config_read(dev, PIIX_PIRQCA + i, 1); > >> + if (v & 0x80) { > >> + v = 0; > >> + } > >> + v &= 0xf; > >> + xen_set_pci_link_route(i, v); > >> + } > >> +} > >> + > >> /* PC hardware initialisation */ > >> static void pc_init1(MachineState *machine, > >> const char *host_type, const char *pci_type) > >> @@ -84,7 +112,7 @@ static void pc_init1(MachineState *machine, > >> MemoryRegion *system_io = get_system_io(); > >> PCIBus *pci_bus; > >> ISABus *isa_bus; > >> - int piix3_devfn = -1; > >> + Object *piix4_pm; > >> qemu_irq smi_irq; > >> GSIState *gsi_state; > >> BusState *idebus[MAX_IDE_BUS]; > >> @@ -205,10 +233,9 @@ static void pc_init1(MachineState *machine, > >> gsi_state = pc_gsi_create(&x86ms->gsi, pcmc->pci_enabled); > >> > >> if (pcmc->pci_enabled) { > >> - PIIX3State *piix3; > >> + DeviceState *dev; > >> PCIDevice *pci_dev; > >> - const char *type = xen_enabled() ? TYPE_PIIX3_XEN_DEVICE > >> - : TYPE_PIIX3_DEVICE; > >> + int i; > >> > >> pci_bus = i440fx_init(pci_type, > >> i440fx_host, > >> @@ -216,21 +243,65 @@ static void pc_init1(MachineState *machine, > >> x86ms->below_4g_mem_size, > >> x86ms->above_4g_mem_size, > >> pci_memory, ram_memory); > >> + pci_bus_map_irqs(pci_bus, > >> + xen_enabled() ? xen_pci_slot_get_pirq > >> + : pci_slot_get_pirq); > >> pcms->bus = pci_bus; > >> > >> - pci_dev = pci_create_simple_multifunction(pci_bus, -1, true, type); > >> - piix3 = PIIX3_PCI_DEVICE(pci_dev); > >> - piix3->pic = x86ms->gsi; > >> - piix3_devfn = piix3->dev.devfn; > >> - isa_bus = ISA_BUS(qdev_get_child_bus(DEVICE(piix3), "isa.0")); > >> + pci_dev = pci_new_multifunction(-1, true, TYPE_PIIX3_DEVICE); > >> + object_property_set_bool(OBJECT(pci_dev), "has-usb", > >> + machine_usb(machine), &error_abort); > >> + object_property_set_bool(OBJECT(pci_dev), "has-acpi", > >> + x86_machine_is_acpi_enabled(x86ms), > >> + &error_abort); > >> + qdev_prop_set_uint32(DEVICE(pci_dev), "smb_io_base", 0xb100); > >> + object_property_set_bool(OBJECT(pci_dev), "smm-enabled", > >> + x86_machine_is_smm_enabled(x86ms), > >> + &error_abort); > >> + pci_realize_and_unref(pci_dev, pci_bus, &error_fatal); > >> + > >> + if (xen_enabled()) { > >> + pci_device_set_intx_routing_notifier( > >> + pci_dev, piix_intx_routing_notifier_xen); > >> + > >> + /* > >> + * Xen supports additional interrupt routes from the PCI devices to > >> + * the IOAPIC: the four pins of each PCI device on the bus are also > >> + * connected to the IOAPIC directly. > >> + * These additional routes can be discovered through ACPI. > >> + */ > >> + pci_bus_irqs(pci_bus, xen_intx_set_irq, pci_dev, > >> + XEN_IOAPIC_NUM_PIRQS); > >> + } > >> + > >> + dev = DEVICE(object_resolve_path_component(OBJECT(pci_dev), "pic")); > >> + for (i = 0; i < ISA_NUM_IRQS; i++) { > >> + qdev_connect_gpio_out(dev, i, x86ms->gsi[i]); > >> + } > >> + isa_bus = ISA_BUS(qdev_get_child_bus(DEVICE(pci_dev), "isa.0")); > >> + rtc_state = ISA_DEVICE(object_resolve_path_component(OBJECT(pci_dev), > >> + "rtc")); > >> + piix4_pm = object_resolve_path_component(OBJECT(pci_dev), "pm"); > >> + dev = DEVICE(object_resolve_path_component(OBJECT(pci_dev), "ide")); > >> + pci_ide_create_devs(PCI_DEVICE(dev)); > >> + idebus[0] = qdev_get_child_bus(dev, "ide.0"); > >> + idebus[1] = qdev_get_child_bus(dev, "ide.1"); > >> } else { > >> pci_bus = NULL; > >> + piix4_pm = NULL; > >> isa_bus = isa_bus_new(NULL, get_system_memory(), system_io, > >> &error_abort); > >> + isa_bus_irqs(isa_bus, x86ms->gsi); > >> + > >> + rtc_state = isa_new(TYPE_MC146818_RTC); > >> + qdev_prop_set_int32(DEVICE(rtc_state), "base_year", 2000); > >> + isa_realize_and_unref(rtc_state, isa_bus, &error_fatal); > >> + > >> i8257_dma_init(isa_bus, 0); > >> pcms->hpet_enabled = false; > >> + idebus[0] = NULL; > >> + idebus[1] = NULL; > >> } > >> - isa_bus_irqs(isa_bus, x86ms->gsi); > >> > >> if (x86ms->pic == ON_OFF_AUTO_ON || x86ms->pic == ON_OFF_AUTO_AUTO) { > >> pc_i8259_create(isa_bus, gsi_state->i8259_irq); > >> @@ -252,18 +323,12 @@ static void pc_init1(MachineState *machine, > >> } > >> > >> /* init basic PC hardware */ > >> - pc_basic_device_init(pcms, isa_bus, x86ms->gsi, &rtc_state, true, > >> + pc_basic_device_init(pcms, isa_bus, x86ms->gsi, rtc_state, true, > >> 0x4); > >> > >> pc_nic_init(pcmc, isa_bus, pci_bus); > >> > >> if (pcmc->pci_enabled) { > >> - PCIDevice *dev; > >> - > >> - dev = pci_create_simple(pci_bus, piix3_devfn + 1, TYPE_PIIX3_IDE); > >> - pci_ide_create_devs(dev); > >> - idebus[0] = qdev_get_child_bus(&dev->qdev, "ide.0"); > >> - idebus[1] = qdev_get_child_bus(&dev->qdev, "ide.1"); > >> pc_cmos_init(pcms, idebus[0], idebus[1], rtc_state); > >> } > >> #ifdef CONFIG_IDE_ISA > >> @@ -289,21 +354,9 @@ static void pc_init1(MachineState *machine, > >> } > >> #endif > >> > >> - if (pcmc->pci_enabled && machine_usb(machine)) { > >> - pci_create_simple(pci_bus, piix3_devfn + 2, "piix3-usb-uhci"); > >> - } > >> - > >> - if (pcmc->pci_enabled && x86_machine_is_acpi_enabled(X86_MACHINE(pcms))) { > >> - PCIDevice *piix4_pm; > >> - > >> + if (piix4_pm) { > >> smi_irq = qemu_allocate_irq(pc_acpi_smi_interrupt, first_cpu, 0); > >> - piix4_pm = pci_new(piix3_devfn + 3, TYPE_PIIX4_PM); > >> - qdev_prop_set_uint32(DEVICE(piix4_pm), "smb_io_base", 0xb100); > >> - qdev_prop_set_bit(DEVICE(piix4_pm), "smm-enabled", > >> - x86_machine_is_smm_enabled(x86ms)); > >> - pci_realize_and_unref(piix4_pm, pci_bus, &error_fatal); > >> > >> - qdev_connect_gpio_out(DEVICE(piix4_pm), 0, x86ms->gsi[9]); > >> qdev_connect_gpio_out_named(DEVICE(piix4_pm), "smi-irq", 0, smi_irq); > >> pcms->smbus = I2C_BUS(qdev_get_child_bus(DEVICE(piix4_pm), "i2c")); > >> /* TODO: Populate SPD eeprom data. */ > >> @@ -315,7 +368,7 @@ static void pc_init1(MachineState *machine, > >> object_property_allow_set_link, > >> OBJ_PROP_LINK_STRONG); > >> object_property_set_link(OBJECT(machine), PC_MACHINE_ACPI_DEVICE_PROP, > >> - OBJECT(piix4_pm), &error_abort); > >> + piix4_pm, &error_abort); > >> } > >> > >> if (machine->nvdimms_state->is_enabled) { > >> @@ -405,6 +458,9 @@ static void pc_xen_hvm_init(MachineState *machine) > >> } > >> > >> pc_xen_hvm_init_pci(machine); > >> + if (xen_igd_gfx_pt_enabled()) { > >> + xen_igd_reserve_slot(pcms->bus); > >> + } These are the three lines from my patch that are added to pc_piix.c. IIUC, this diff is showing the differences in pc_piix.c without and with CONFIG_XEN defined. If so, then the fact that the lines in my patch are added when CONFIG_XEN is defined means they are not included as part of the build when CONFIG_XEN is not defined. That is how I can claim that my small patch to pc_piix.c does not affect builds without CONFIG_XEN defined. I also think the rest of the files touched by my patch are only included by the meson build system with the --enable-xen an option to configure. So the entire patch is xen-specific and can easily be eliminated from any build with the --disable-xen configure option. Kind regards, Chuck > >> pci_create_simple(pcms->bus, -1, "xen-platform"); > >> } > >> #endif > >> @@ -441,6 +497,11 @@ static void pc_i440fx_8_0_machine_options(MachineClass *m) > >> pc_i440fx_machine_options(m); > >> m->alias = "pc"; > >> m->is_default = true; > >> +#ifdef CONFIG_MICROVM_DEFAULT > >> + m->is_default = false; > >> +#else > >> + m->is_default = true; > >> +#endif > >> } > >> > >> DEFINE_I440FX_MACHINE(v8_0, "pc-i440fx-8.0", NULL, > > > > > > Lots of changes here not guarded by CONFIG_XEN. > > > > What diff is this? How is my patch related to it? > From xen-devel-bounces@lists.xenproject.org Tue Jan 10 02:21:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 02:21:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474210.735236 (Exim 4.92) (envelope-from ) id 1pF4GL-00022g-Nu; Tue, 10 Jan 2023 02:21:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474210.735236; Tue, 10 Jan 2023 02:21:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF4GL-00022Z-Kt; Tue, 10 Jan 2023 02:21:17 +0000 Received: by outflank-mailman (input) for mailman id 474210; Tue, 10 Jan 2023 02:21:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF4GK-00022A-5b for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 02:21:16 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 73fe561a-908d-11ed-91b6-6bf2151ebd3b; Tue, 10 Jan 2023 03:21:13 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 842C4B810A8; Tue, 10 Jan 2023 02:21:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 02EB7C433D2; Tue, 10 Jan 2023 02:21:09 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 73fe561a-908d-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673317271; bh=g98YC6afw2raunyf2JttUHkwKLNQSW/goayP6h1YPKM=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=I1+3tbcPXAch+Pit8m90QWM0vPTyjHqH/XbzasS06NVatE1ntE1H1uCr69rjcC69Q HL2TInNRiMHt48M0O8wMa6udz/CKxEzf32pQWs3BnZj6ug9fDPyMDFthSfCrYkDDx7 n2WgNfNI0mgs6TjnB9rEV/S/vkpTEJYzPQ6a4tRvlzxa7EvTbhc21X1z31jSoTFuYt TAAH99giAKAPRMY55xYb8eJHi1euKvtv9Wq1Rhhj3ePIOcxCCi6wyJFf4QxXCVw8Mg p7kg1C5+e8UmiWIgIiiD2P+0Jobgq3+VqBNB8UZ2naf0qKSTafNR1iq/8ohCFLpaWL snN6mdgeSksCg== Date: Mon, 9 Jan 2023 18:21:04 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Oleksii Kurochko cc: xen-devel@lists.xenproject.org, Jan Beulich , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Doug Goldstein Subject: Re: [PATCH v2 8/8] automation: add RISC-V smoke test In-Reply-To: <494c2fd1e046de20c2fa24be3989cc6adde8fdbe.1673278109.git.oleksii.kurochko@gmail.com> Message-ID: References: <494c2fd1e046de20c2fa24be3989cc6adde8fdbe.1673278109.git.oleksii.kurochko@gmail.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Mon, 9 Jan 2023, Oleksii Kurochko wrote: > Add check if there is a message 'Hello from C env' presents > in log file to be sure that stack is set and C part of early printk > is working. > > Signed-off-by: Oleksii Kurochko > --- > Changes in V2: > - Move changes in the dockerfile to separate patch and send it to > mailing list separately: > [PATCH] automation: add qemu-system-riscv to riscv64.dockerfile > - Update test.yaml to wire up smoke test > --- > automation/gitlab-ci/test.yaml | 20 ++++++++++++++++++++ > automation/scripts/qemu-smoke-riscv64.sh | 20 ++++++++++++++++++++ > 2 files changed, 40 insertions(+) > create mode 100755 automation/scripts/qemu-smoke-riscv64.sh > > diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml > index afd80adfe1..64f47a0ab9 100644 > --- a/automation/gitlab-ci/test.yaml > +++ b/automation/gitlab-ci/test.yaml > @@ -54,6 +54,19 @@ > tags: > - x86_64 > > +.qemu-riscv64: > + extends: .test-jobs-common > + variables: > + CONTAINER: archlinux:riscv64 I realize that it is committed now, but following the arm32 convention the name of the arch container (currently archlinux:riscv64) would be: CONTAINER: archlinux:current-riscv64 I know this is not related to this patch, but I am taking the opportunity to mention it now in case we get an opportunity to fix it in the future for consistency. > + LOGFILE: qemu-smoke-riscv64.log > + artifacts: > + paths: > + - smoke.serial > + - '*.log' > + when: always > + tags: > + - x86_64 > + > .yocto-test: > extends: .test-jobs-common > script: > @@ -234,6 +247,13 @@ qemu-smoke-x86-64-clang-pvh: > needs: > - debian-unstable-clang-debug > > +qemu-smoke-riscv64-gcc: > + extends: .qemu-riscv64 > + script: > + - ./automation/scripts/qemu-smoke-riscv64.sh 2>&1 | tee ${LOGFILE} > + needs: > + - riscv64-cross-gcc Similarly here the "needs" dependency should be called arch-current-gcc-riscv for consistency with arm32. Basically we already have a crossbuild and crosstest environment up and running in gitlab-ci and it is the one for arm32. You can just base all the naming convention on that. I realize that riscv64-cross-gcc is also already exported by build.yaml, but I am mentioning it in case we get an opportunity to fix it in the future. Nonetheless this patch on its own is OK so Acked-by: Stefano Stabellini > # Yocto test jobs > yocto-qemuarm64: > extends: .yocto-test-arm64 > diff --git a/automation/scripts/qemu-smoke-riscv64.sh b/automation/scripts/qemu-smoke-riscv64.sh > new file mode 100755 > index 0000000000..e0f06360bc > --- /dev/null > +++ b/automation/scripts/qemu-smoke-riscv64.sh > @@ -0,0 +1,20 @@ > +#!/bin/bash > + > +set -ex > + > +# Run the test > +rm -f smoke.serial > +set +e > + > +timeout -k 1 2 \ > +qemu-system-riscv64 \ > + -M virt \ > + -smp 1 \ > + -nographic \ > + -m 2g \ > + -kernel binaries/xen \ > + |& tee smoke.serial > + > +set -e > +(grep -q "Hello from C env" smoke.serial) || exit 1 > +exit 0 > -- > 2.38.1 > From xen-devel-bounces@lists.xenproject.org Tue Jan 10 03:38:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 03:38:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474225.735268 (Exim 4.92) (envelope-from ) id 1pF5TF-0000t4-Ox; Tue, 10 Jan 2023 03:38:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474225.735268; Tue, 10 Jan 2023 03:38:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF5TF-0000sr-Kk; Tue, 10 Jan 2023 03:38:41 +0000 Received: by outflank-mailman (input) for mailman id 474225; Tue, 10 Jan 2023 03:38:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF5TE-0000sS-6J for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 03:38:40 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on2047.outbound.protection.outlook.com [40.107.8.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 43ec73c1-9098-11ed-91b6-6bf2151ebd3b; Tue, 10 Jan 2023 04:38:37 +0100 (CET) Received: from DB6PR0802CA0025.eurprd08.prod.outlook.com (2603:10a6:4:a3::11) by PAVPR08MB9038.eurprd08.prod.outlook.com (2603:10a6:102:32d::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 03:38:34 +0000 Received: from DBAEUR03FT034.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:a3:cafe::2) by DB6PR0802CA0025.outlook.office365.com (2603:10a6:4:a3::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 03:38:34 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT034.mail.protection.outlook.com (100.127.142.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 03:38:33 +0000 Received: ("Tessian outbound baf1b7a96f25:v132"); Tue, 10 Jan 2023 03:38:33 +0000 Received: from 292c8d7ca3d8.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7440E39D-8D33-473A-A682-1730D4CAFD7D.1; Tue, 10 Jan 2023 03:38:27 +0000 Received: from EUR03-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 292c8d7ca3d8.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 10 Jan 2023 03:38:27 +0000 Received: from AM0PR08MB4530.eurprd08.prod.outlook.com (2603:10a6:208:13c::21) by AS4PR08MB7555.eurprd08.prod.outlook.com (2603:10a6:20b:4fd::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 03:38:25 +0000 Received: from AM0PR08MB4530.eurprd08.prod.outlook.com ([fe80::ee26:4b5e:4334:b7ab]) by AM0PR08MB4530.eurprd08.prod.outlook.com ([fe80::ee26:4b5e:4334:b7ab%7]) with mapi id 15.20.5986.018; Tue, 10 Jan 2023 03:38:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 43ec73c1-9098-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3e9AB8zKSikcyZ/BJHR3Insf+vBAyU5ZbNaFxgDySyY=; b=IFjxtRJyKBAg0XLW7qmqSyZqOs8LXNWwMYjAlRHrKersWBl/sSIrzyOY8MQcosdKOltGCwT8tZEB4fP+sCz8RUfDEWpWU4b8za/Zur8ftVGJDOsYwSgCR1HODXv3V0Ls1ABF+IUUboZMpCjTKggV6PUb3B/9QALm6/Kh8pLnqYI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cMa+DMhSjSeids7d8uTD+vobVs+TebXxHUZZbFPBzkRot52ZUlw36Zf/BnIesVFEmdIsKGMBEeYuCqpfyF3LYjRjfv1AC2PhjPOXy2k0IEa0i+n7FvoBSAh3plGHNhEMmtJbr1mLW/nXTjXkWsYEPf39IDY4oZ3ahC6OLe13RR74f1woJ6VSlV5dNNkH/A/GJ5EIq4Efl1c08zJWr2sPjcDeDmGcLtmUbygjj/ct9ekGgMv0KiT3vGnC6uzWBLgUBUgzYdW4kGSTIyNBE/V6dv7ik33FBwUcKX65CIBjM0FRf8z2zFOdyCMn2fLZ9MVMqTB+4Uu3Gg4yL/uvgALotQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3e9AB8zKSikcyZ/BJHR3Insf+vBAyU5ZbNaFxgDySyY=; b=ifkVRWah4P9d/Cosh9S1jsy7nPqJqaRMR+AOxdXe4aDmPm3psmCHxEIJa8i7nYTCqGauQRvPlX2xXLyPEbRDv1TQ6+B2Xh9i7gsFa4pUxrIkPNYtiuvTjJd4EVOqIdB83G8+p8WZ0+KnCtS+t/P8414WpI2JdaLAlrh8eMAEC3B3IwNw97J3Boewc5ZMSvOGIun4DtiD1ng5Hg8GQiMszfsMk5FbeORcB0bkE5LwUo01IRQkGgUhBkC6IzcfvDmQ+6T6WIcU8U4BcEfSeM+79+PnYOIFx1WCeO6qJ8cysk3s7f/2gYMdXTi7MSiwIBP5TJxZD6gXBxGX7XauPUShTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3e9AB8zKSikcyZ/BJHR3Insf+vBAyU5ZbNaFxgDySyY=; b=IFjxtRJyKBAg0XLW7qmqSyZqOs8LXNWwMYjAlRHrKersWBl/sSIrzyOY8MQcosdKOltGCwT8tZEB4fP+sCz8RUfDEWpWU4b8za/Zur8ftVGJDOsYwSgCR1HODXv3V0Ls1ABF+IUUboZMpCjTKggV6PUb3B/9QALm6/Kh8pLnqYI= From: Penny Zheng To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Wei Chen , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH v1 06/13] xen/arm: assign shared memory to owner when host address not provided Thread-Topic: [PATCH v1 06/13] xen/arm: assign shared memory to owner when host address not provided Thread-Index: AQHY+J1pmmYEajWz5UynKX+c5rdEZK6UzwiAgAEQoXCAAGGAAIAACRWAgABzZYCAAJEhAA== Date: Tue, 10 Jan 2023 03:38:24 +0000 Message-ID: References: <20221115025235.1378931-1-Penny.Zheng@arm.com> <20221115025235.1378931-7-Penny.Zheng@arm.com> <6db41bd2-ab71-422a-4235-a9209e984915@xen.org> <8ae9e898-55ba-7fba-6ccc-883bd8b3e7ee@xen.org> In-Reply-To: <8ae9e898-55ba-7fba-6ccc-883bd8b3e7ee@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: CF29401C2B1D2C42BC3A37E0A469BFEB.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM0PR08MB4530:EE_|AS4PR08MB7555:EE_|DBAEUR03FT034:EE_|PAVPR08MB9038:EE_ X-MS-Office365-Filtering-Correlation-Id: d7d9df03-0d25-451c-0b14-08daf2bc265d x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: oHpCca9YR+Sx/V6/TwiK/Sdty8D8zMJuRMyLlzQIGR6PR9w0tdPHziky9c818JUK1PPvz52MkxQCY6wfsnLOpwH1t33JzVM9DaJrt3Rfb/66qdKAurn2wk3v4i2FitIRRpMyXSm4kkNuoTdMikHKjgEpBd9IVAR+2mbQp4vcGHKRToqDA1iNqrvbSbtp3cXxik7pmKUAow+HPMllKwpZkuhejWMyc48G0JP4/unzUDuN5H7MMWLQMeS7T9I6VCgMeKTg1jjoTRsz3EhgUcfCaNVPivTiDNdrQT3MdFw6hab+UrZwiwpG369yH0ntoeMiVy5FuFinkt+0FYZoXi7J9Wj3WP7ccJDNAM+bQlN3m49UAv2DhPrqxeJrqw+wtviqX9UJuYufxaKnS7MjDZUar5AmEyRhpNliUfXGkfUHfKq2iLiIpiFto45XEgtFHgkQJ4/Rd8mGF/ittBD7zKgqHGuk27xwtClQt8+BWft2Blo3hvle2EDwpQstc+agZYbt3+eluDQ7PrWUovWjNmXY1s9uLfVOjCI282gG5oXlRCUeKW/pIx2/hqMIccJvPGXr39WAW3tdnuUAdQqs98rI11p8QZvigShuEGB+lW02NvVxutj2KysKuE3R/n+031XxQI059zBgV3DBT9FwpwAas33qzsMQzNJm5kGcAkxek2Zw2VOitXO/KpJA8YcGWl9wg+jIKHZckLyOQEF4cjn7yw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB4530.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(376002)(396003)(39860400002)(136003)(346002)(451199015)(66899015)(83380400001)(26005)(6506007)(110136005)(86362001)(316002)(54906003)(71200400001)(55016003)(33656002)(7696005)(38100700002)(122000001)(38070700005)(9686003)(53546011)(186003)(66446008)(2906002)(478600001)(5660300002)(8936002)(76116006)(66946007)(8676002)(64756008)(66476007)(41300700001)(4326008)(66556008)(52536014);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB7555 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT034.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 9f9f0909-e664-4261-79a4-08daf2bc2126 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SnFjPvC5oPZZi7ia/hCp+PEJw3pmehWqKmAaxqLfeI/5enDtPja63EurdITNtOea/fCMk81gnaID6382kCqt5LVWixjSW1j0jDSd+CZqskOksPknD/QOFACdXa+afElznezEN0EE75vBh6tQNkS8iHN20uiv0xQjxg9P2Yubp9s7br7zN6tIhPzkuZ3vGfUfdGWDELyGOvH8ONPBASnxbuuHxAGrOWDPMDal5sXRa0/twz3QCeMB7Ahhrqsn+WzJKDPJ06sEsEDstK+tRRzDql2dqzi/iSQLeAmyBSHl3Nrkqs6str1XhF/i7zLMeSVyVLdfKdNbxcjWs39HQNzW50NmcXYsURhrdz8RFE2zCA7qQt5JmvmG2/2rvDo/qcx5rc6dEv+YjEy17uVAgmd/GJZoanetkt3z/MVvuiGVvYBqPM1ImNhBnudXDTYesU+pcm7wOG/gQUJJDJAyNTXXdVwNDHQfcdWBLEZvCDr2LTPGft12oEuSLMOy+GC7BLA4n7xOH1QQ1Ah//QXCBHU8umfB2cQM9gs8SbC4rtwaPAIooWBASdt2cdQmeMwLQ6nTOycG75i0fVQoCo1vUuq/ZllhmUVIf+uSu0+r1cvhbGz9kpTyRbf8KhfLUzuVV/UY0wtZzc3qnKdg5DLEQ7qcxiklWFeFP7VG/bTRH6MVrmBwbRVtEERRicOzsHsAHnJyHx6qn51aIIjCXbBsVcZX7w== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(346002)(39860400002)(376002)(451199015)(40470700004)(46966006)(36840700001)(66899015)(7696005)(86362001)(110136005)(40480700001)(316002)(54906003)(40460700003)(33656002)(55016003)(478600001)(82740400003)(356005)(81166007)(9686003)(107886003)(53546011)(6506007)(186003)(26005)(82310400005)(8676002)(70586007)(4326008)(8936002)(70206006)(41300700001)(5660300002)(2906002)(52536014)(36860700001)(336012)(47076005)(83380400001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2023 03:38:33.7595 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d7d9df03-0d25-451c-0b14-08daf2bc265d X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT034.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9038 PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBKdWxpZW4gR3JhbGwgPGp1bGll bkB4ZW4ub3JnPg0KPiBTZW50OiBUdWVzZGF5LCBKYW51YXJ5IDEwLCAyMDIzIDI6MjMgQU0NCj4g VG86IFBlbm55IFpoZW5nIDxQZW5ueS5aaGVuZ0Bhcm0uY29tPjsgeGVuLWRldmVsQGxpc3RzLnhl bnByb2plY3Qub3JnDQo+IENjOiBXZWkgQ2hlbiA8V2VpLkNoZW5AYXJtLmNvbT47IFN0ZWZhbm8g U3RhYmVsbGluaQ0KPiA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz47IEJlcnRyYW5kIE1hcnF1aXMg PEJlcnRyYW5kLk1hcnF1aXNAYXJtLmNvbT47DQo+IFZvbG9keW15ciBCYWJjaHVrIDxWb2xvZHlt eXJfQmFiY2h1a0BlcGFtLmNvbT4NCj4gU3ViamVjdDogUmU6IFtQQVRDSCB2MSAwNi8xM10geGVu L2FybTogYXNzaWduIHNoYXJlZCBtZW1vcnkgdG8gb3duZXINCj4gd2hlbiBob3N0IGFkZHJlc3Mg bm90IHByb3ZpZGVkDQo+IA0KPiBIaSBQZW5ueSwNCg0KSGkgSnVsaWVuLA0KDQo+IA0KPiBPbiAw OS8wMS8yMDIzIDExOjU4LCBQZW5ueSBaaGVuZyB3cm90ZToNCj4gPj4gLS0tLS1PcmlnaW5hbCBN ZXNzYWdlLS0tLS0NCj4gPj4gRnJvbTogSnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4NCj4g Pj4gU2VudDogTW9uZGF5LCBKYW51YXJ5IDksIDIwMjMgNjo1OCBQTQ0KPiA+PiBUbzogUGVubnkg WmhlbmcgPFBlbm55LlpoZW5nQGFybS5jb20+OyB4ZW4tDQo+IGRldmVsQGxpc3RzLnhlbnByb2pl Y3Qub3JnDQo+ID4+IENjOiBXZWkgQ2hlbiA8V2VpLkNoZW5AYXJtLmNvbT47IFN0ZWZhbm8gU3Rh YmVsbGluaQ0KPiA+PiA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz47IEJlcnRyYW5kIE1hcnF1aXMN Cj4gPj4gPEJlcnRyYW5kLk1hcnF1aXNAYXJtLmNvbT47IFZvbG9keW15ciBCYWJjaHVrDQo+ID4+ IDxWb2xvZHlteXJfQmFiY2h1a0BlcGFtLmNvbT4NCj4gPj4gU3ViamVjdDogUmU6IFtQQVRDSCB2 MSAwNi8xM10geGVuL2FybTogYXNzaWduIHNoYXJlZCBtZW1vcnkgdG8gb3duZXINCj4gPj4gd2hl biBob3N0IGFkZHJlc3Mgbm90IHByb3ZpZGVkDQo+ID4+DQo+ID4+DQo+ID4+DQo+ID4+IE9uIDA5 LzAxLzIwMjMgMDc6NDksIFBlbm55IFpoZW5nIHdyb3RlOg0KPiA+Pj4gSGkgSnVsaWVuDQo+ID4+ DQo+ID4+IEhpIFBlbm55LA0KPiA+Pg0KPiA+Pj4gSGFwcHkgbmV3IHllYXJ+fn5+DQo+ID4+DQo+ ID4+IEhhcHB5IG5ldyB5ZWFyIHRvbyENCj4gPj4NCj4gPj4+PiAtLS0tLU9yaWdpbmFsIE1lc3Nh Z2UtLS0tLQ0KPiA+Pj4+IEZyb206IEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+ID4+ Pj4gU2VudDogU3VuZGF5LCBKYW51YXJ5IDgsIDIwMjMgODo1MyBQTQ0KPiA+Pj4+IFRvOiBQZW5u eSBaaGVuZyA8UGVubnkuWmhlbmdAYXJtLmNvbT47IHhlbi0NCj4gPj4gZGV2ZWxAbGlzdHMueGVu cHJvamVjdC5vcmcNCj4gPj4+PiBDYzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+OyBTdGVm YW5vIFN0YWJlbGxpbmkNCj4gPj4+PiA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz47IEJlcnRyYW5k IE1hcnF1aXMNCj4gPj4+PiA8QmVydHJhbmQuTWFycXVpc0Bhcm0uY29tPjsgVm9sb2R5bXlyIEJh YmNodWsNCj4gPj4+PiA8Vm9sb2R5bXlyX0JhYmNodWtAZXBhbS5jb20+DQo+ID4+Pj4gU3ViamVj dDogUmU6IFtQQVRDSCB2MSAwNi8xM10geGVuL2FybTogYXNzaWduIHNoYXJlZCBtZW1vcnkgdG8N Cj4gPj4+PiBvd25lciB3aGVuIGhvc3QgYWRkcmVzcyBub3QgcHJvdmlkZWQNCj4gPj4+Pg0KPiA+ Pj4+IEhpLA0KPiA+Pj4+DQo+ID4+Pg0KPiA+Pj4gQSBmZXcgY29uY2VybnMgZXhwbGFpbmVkIHdo eSBJIGRpZG4ndCBjaG9vc2UgInN0cnVjdCBtZW1pbmZvIiBvdmVyDQo+ID4+PiB0d28gcG9pbnRl cnMgInN0cnVjdCBtZW1iYW5rKiIgYW5kICJzdHJ1Y3QgbWVtaW5mbyoiLg0KPiA+Pj4gMSkgbWVt b3J5IHVzYWdlIGlzIHRoZSBtYWluIHJlYXNvbi4NCj4gPj4+IElmIHdlIHVzZSAic3RydWN0IG1l bWluZm8iIG92ZXIgdGhlIGN1cnJlbnQgInN0cnVjdCBtZW1iYW5rKiIgYW5kDQo+ID4+PiAic3Ry dWN0IG1lbWluZm8qIiwgInN0cnVjdCBzaG1fbWVtaW5mbyIgd2lsbCBiZWNvbWUgYSBhcnJheSBv ZiAyNTYNCj4gPj4+ICJzdHJ1Y3Qgc2htX21lbWJhbmsiLCB3aXRoICJzdHJ1Y3Qgc2htX21lbWJh bmsiIGJlaW5nIGFsc28gYW4gMjU2LQ0KPiA+PiBpdGVtDQo+ID4+PiBhcnJheSwgdGhhdCBpcyAy NTYgKiAyNTYsIHRvbyBiaWcgZm9yIGEgc3RydWN0dXJlIGFuZCBJZiBJDQo+ID4+PiByZW1lbWJl cmVkIGNsZWFybHksDQo+ID4+IGl0IHdpbGwgbGVhZCB0byAibW9yZSB0aGFuIFBBR0VfU0laRSIg Y29tcGlsaW5nIGVycm9yLg0KPiA+Pg0KPiA+PiBJIGFtIG5vdCBhd2FyZSBvZiBhbnkgcGxhY2Ug d2hlcmUgd2Ugd291bGQgcmVzdHJpY3QgdGhlIHNpemUgb2Yga2luZm8NCj4gPj4gaW4gdXBzdHJl YW0uIENhbiB5b3UgZ2l2ZSBtZSBhIHBvaW50ZXI/DQo+ID4+DQo+ID4NCj4gPiBJZiBJIHJlbWVt YmVyZWQgY29ycmVjdGx5LCBteSBmaXJzdCB2ZXJzaW9uIG9mICJzdHJ1Y3Qgc2htX21lbWluZm8i IGlzDQo+ID4gdGhpcw0KPiA+ICJiaWciKDI1NiAqIDI1Nikgc3RydWN0dXJlLCBhbmQgaXQgbGVh ZHMgdG8gdGhlIHdob2xlIHhlbiBiaW5hcnkgaXMNCj4gPi4gO1wNCj4gDQo+IEFoIHNvIHRoZSBw cm9ibGVtIGlzIGJlY2F1c2Ugc2htX21lbSBpcyB1c2VkIGluIGJvb3RpbmZvLiBUaGVuIEkgdGhp bmsgd2UNCj4gc2hvdWxkIGNyZWF0ZSBhIGRpc3RpbmN0IHN0cnVjdHVyZSB3aGVuIGRlYWxpbmcg d2l0aCBkb21haW4gaW5mb3JtYXRpb24uDQo+IA0KDQpZZXMsIElmIEkgdXNlIHRoZSBsYXR0ZXIg InN0cnVjdCBzaG1faW5mbyIsIGtlZXBpbmcgdGhlIHNobSBtZW1vcnkgaW5mbyBvdXQgb2YgdGhl IGJvb3RpbmZvLA0KSSB0aGluayB3ZSBjb3VsZCBhdm9pZCAiYmlnZ2VyIHRoYW4gMk1CIiBlcnJv ci4NCg0KSG1tLCBvdXQgb2YgY3VyaW9zaXR5LCBUaGUgd2F5IHRvIGNyZWF0ZSAiZGlzdGluY3Qi IHN0cnVjdHVyZSBpcyBsaWtlIGNyZWF0aW5nIGFub3RoZXIgc2VjdGlvbg0KZm9yIHRoZXNlIGRp c3RpbmN0IHN0cnVjdHVyZXMgaW4gbGRzLCBqdXN0IGxpa2UgdGhlIGV4aXN0aW5nIC5kdGIgc2Vj dGlvbj8NCiANCj4gPg0KPiA+Pj4gRldJVCwgZWl0aGVyIHJld29ya2luZyBtZW1pbmZvIG9yIHVz aW5nIGEgZGlmZmVyZW50IHN0cnVjdHVyZSwgYXJlDQo+ID4+PiBib3RoIGxlYWRpbmcgdG8gc2l6 aW5nIGRvd24gdGhlIGFycmF5LCBobW1tLCBJIGRvbid0IGtub3cgd2hpY2ggc2l6ZQ0KPiA+Pj4g aXMgc3VpdGFibGUuIFRoYXQncyB3aHkgSSBwcmVmZXIgcG9pbnRlciBhbmQgZHluYW1pYyBhbGxv Y2F0aW9uLg0KPiA+Pg0KPiA+PiBJIHdvdWxkIGV4cGVjdCB0aGF0IGluIG1vc3QgY2FzZXMsIHlv dSB3aWxsIG5lZWQgb25seSBvbmUgYmFuayB3aGVuDQo+ID4+IHRoZSBob3N0IGFkZHJlc3MgaXMg bm90IHByb3ZpZGVkLiBTbyBJIHRoaW5rIHRoaXMgaXMgYSBiaXQgb2RkIHRvIG1lIHRvDQo+IGlt cG9zZSBhICJsYXJnZSINCj4gPj4gYWxsb2NhdGlvbiBmb3IgdGhlbS4NCj4gPj4NCj4gPg0KPiA+ IE9ubHkgaWYgdXNlciBpcyBub3QgZGVmaW5pbmcgc2l6ZSBhcyBzb21ldGhpbmcgbGlrZSAoMl5h ICsgMl5iICsgMl5jICsNCj4gPiAuLi4pLiA7XCBTbyBtYXliZSA4IG9yIDE2IGlzIGVub3VnaD8N Cj4gPiBzdHJ1Y3QgbmV3X21lbWluZm8gew0KPiANCj4gIm5ldyIgaXMgYSBiaXQgc3RyYW5nZS4g VGhlIG5hbWUgd291bGQgd2FudCB0byBiZSBjaGFuZ2VkLiBPciBtYXliZSBiZXR0ZXINCj4gdGhl IHN0cnVjdHVyZSBiZWVuIGRlZmluZWQgd2l0aGluIHRoZSBuZXh0IHN0cnVjdHVyZSBhbmQgYW5v bnltaXplZC4NCj4gDQo+ID4gICAgICB1bnNpZ25lZCBpbnQgbnJfYmFua3M7DQo+ID4gICAgICBz dHJ1Y3QgbWVtYmFuayBiYW5rWzhdOw0KPiA+IH07DQo+ID4NCj4gPiBDb3JyZWN0IG1lIGlmIEkn bSB3cm9uZzoNCj4gPiBUaGUgInN0cnVjdCBzaG1fbWVtYmFuayIgeW91IGFyZSBzdWdnZXN0aW5n IGlzIGxvb2tpbmcgbGlrZSB0aGlzLCByaWdodD8NCj4gPiBzdHJ1Y3Qgc2htX21lbWJhbmsgew0K PiA+ICAgICAgY2hhciBzaG1faWRbTUFYX1NITV9JRF9MRU5HVEhdOw0KPiA+ICAgICAgdW5zaWdu ZWQgaW50IG5yX3NobV9ib3Jyb3dlcnM7DQo+ID4gICAgICBzdHJ1Y3QgbmV3X21lbWluZm8gc2ht X2JhbmtzOw0KPiA+ICAgICAgdW5zaWduZWQgbG9uZyB0b3RhbF9zaXplOw0KPiA+IH07DQo+IA0K PiBBRkFJVSwgc2htX21lbWJhbmsgd291bGQgc3RpbGwgYmUgdXNlZCB0byBnZXQgdGhlIGluZm9y bWF0aW9uIGZyb20gdGhlDQo+IGhvc3QgZGV2aWNlLXRyZWUuIElmIHNvLCB0aGVuIEkgYW0gYWZy YWlkIHRoaXMgaXMgbm90IGFuIG9wdGlvbiB0byBtZSBiZWNhdXNlIGl0DQo+IHdvdWxkIG1ha2Ug dGhlIGNvZGUgdG8gcmVzZXJ2ZSBtZW1vcnkgbW9yZSBjb21wbGV4Lg0KPiANCj4gSW5zdGVhZCwg d2Ugc2hvdWxkIGNyZWF0ZSBhIHNlcGFyYXRlIHN0cnVjdHVyZSB0aGF0IHdpbGwgb25seSBiZSB1 c2VkIGZvcg0KPiBkb21haW4gc2hhcmVkIG1lbW9yeSBpbmZvcm1hdGlvbi4NCj4NCg0KQWgsIHNv IHlvdSBhcmUgc3VnZ2VzdGluZyB3ZSBzaG91bGQgZXh0cmFjdCB0aGUgZG9tYWluIHNoYXJlZCBt ZW1vcnkgaW5mb3JtYXRpb24gb25seQ0Kd2hlbiBkZWFsaW5nIHdpdGggdGhlIGluZm9ybWF0aW9u IGZyb20gdGhlIGhvc3QgZGV2aWNlLXRyZWUsIHNvbWV0aGluZyBsaWtlIHRoaXM6DQpzdHJ1Y3Qg c2htX2luZm8gew0KICAgICAgY2hhciBzaG1faWRbTUFYX1NITV9JRF9MRU5HVEhdOw0KICAgICAg dW5zaWduZWQgaW50IG5yX3NobV9ib3Jyb3dlcnM7DQp9DQoNCkknbGwgdHJ5IGFuZCBtYXkgKmJv dGhlciogeW91IHdoZW4gZW5jb3VudGVyaW5nIGFueSBwcm9ibGVtfiANCiANCj4gQ2hlZXJzLA0K PiANCj4gLS0NCj4gSnVsaWVuIEdyYWxsDQo= From xen-devel-bounces@lists.xenproject.org Tue Jan 10 03:51:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 03:51:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474233.735282 (Exim 4.92) (envelope-from ) id 1pF5fz-0003Gt-10; Tue, 10 Jan 2023 03:51:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474233.735282; Tue, 10 Jan 2023 03:51:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF5fy-0003Gm-TK; Tue, 10 Jan 2023 03:51:50 +0000 Received: by outflank-mailman (input) for mailman id 474233; Tue, 10 Jan 2023 03:51:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF5fx-0003Gc-Sw; Tue, 10 Jan 2023 03:51:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF5fx-00018f-PL; Tue, 10 Jan 2023 03:51:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF5fx-0005V1-8Y; Tue, 10 Jan 2023 03:51:49 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pF5fx-0003az-84; Tue, 10 Jan 2023 03:51:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Fc/XcGNtYMkIXBTbYkCxDzOzfA1HN9tLBKS8whlUkGE=; b=vVRkvAv/xIUedsD2U5GCI9E3Wk SG3T4mhITFLDwYUC1DSDPXE9OYBCN6R56f92C3alK0sdn7wvVQbhTDT0CsEyhSp7/7TepeptvU5tA jLfVqn5g3nuUw3AYmqOWff1foK2SlukpXrKEMswfsPbnqeUOvt9Cz0ee+JRjbnOFRQ5A=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 175672: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-amd64-xsm:xen-build:fail:regression qemu-mainline:build-amd64:xen-build:fail:regression qemu-mainline:build-i386:xen-build:fail:regression qemu-mainline:build-arm64-xsm:xen-build:fail:regression qemu-mainline:build-i386-xsm:xen-build:fail:regression qemu-mainline:build-arm64:xen-build:fail:regression qemu-mainline:build-armhf:xen-build:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-coresched-amd64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:build-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-rtds:build-check(1):blocked:nonblocking qemu-mainline:build-arm64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking qemu-mainline:build-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking qemu-mainline:build-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-dom0pvh-xl-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-dom0pvh-xl-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvshim:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-pygrub:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvhv2-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-freebsd11-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-freebsd12-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvhv2-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-multivcpu:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: qemuu=aa96ab7c9df59c615ca82b49c9062819e0a1c287 X-Osstest-Versions-That: qemuu=0ab12aa32462817f0a53fa6f6ce4baf664ef1713 From: osstest service owner Date: Tue, 10 Jan 2023 03:51:49 +0000 flight 175672 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/175672/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 175623 build-amd64 6 xen-build fail REGR. vs. 175623 build-i386 6 xen-build fail REGR. vs. 175623 build-arm64-xsm 6 xen-build fail REGR. vs. 175623 build-i386-xsm 6 xen-build fail REGR. vs. 175623 build-arm64 6 xen-build fail REGR. vs. 175623 build-armhf 6 xen-build fail REGR. vs. 175623 Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-win7-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ws16-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-shadow 1 build-check(1) blocked n/a test-amd64-i386-xl-vhd 1 build-check(1) blocked n/a test-amd64-i386-xl-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) blocked n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) blocked n/a test-armhf-armhf-xl-rtds 1 build-check(1) blocked n/a test-armhf-armhf-xl-vhd 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-amd 1 build-check(1) blocked n/a test-amd64-i386-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-i386 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-amd64 1 build-check(1) blocked n/a test-amd64-coresched-i386-xl 1 build-check(1) blocked n/a test-amd64-coresched-amd64-xl 1 build-check(1) blocked n/a test-amd64-amd64-xl-xsm 1 build-check(1) blocked n/a build-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-shadow 1 build-check(1) blocked n/a test-amd64-amd64-xl-rtds 1 build-check(1) blocked n/a build-arm64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ws16-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a build-armhf-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-amd64-dom0pvh-xl-amd 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 1 build-check(1) blocked n/a test-amd64-amd64-dom0pvh-xl-intel 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvshim 1 build-check(1) blocked n/a test-amd64-amd64-pair 1 build-check(1) blocked n/a test-amd64-amd64-pygrub 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvhv2-intel 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-freebsd11-amd64 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-freebsd12-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvhv2-amd 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-nested-amd 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-nested-intel 1 build-check(1) blocked n/a test-amd64-amd64-xl-multivcpu 1 build-check(1) blocked n/a test-amd64-amd64-xl 1 build-check(1) blocked n/a test-amd64-amd64-xl-credit1 1 build-check(1) blocked n/a test-amd64-amd64-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 1 build-check(1) blocked n/a test-armhf-armhf-xl-arndale 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-intel 1 build-check(1) blocked n/a test-amd64-i386-xl 1 build-check(1) blocked n/a test-amd64-i386-xl-pvshim 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a version targeted for testing: qemuu aa96ab7c9df59c615ca82b49c9062819e0a1c287 baseline version: qemuu 0ab12aa32462817f0a53fa6f6ce4baf664ef1713 Last test of basis 175623 2023-01-07 23:09:00 Z 2 days Failing since 175627 2023-01-08 14:40:14 Z 1 days 8 attempts Testing same since 175654 2023-01-09 18:08:58 Z 0 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Ard Biesheuvel Bernhard Beschow Christian Borntraeger Cindy Lu Dongli Zhang Eugenio Pérez Greg Kurz Guoyi Tu Hyman Huang(黄勇) Igor Mammedov Jason Wang Jonathan Cameron Kai Huang Laszlo Ersek Lei Xiang leixiang Liuxiangdong Longpeng Lubomir Rintel Marc-André Lureau Markus Armbruster Michael S. Tsirkin Nikita Ivanov Paolo Bonzini Peter Maydell Philippe Mathieu-Daudé Richard Henderson Thomas Huth Yanan Wang Yicong Yang Zeng Chi jobs: build-amd64-xsm fail build-arm64-xsm fail build-i386-xsm fail build-amd64 fail build-arm64 fail build-armhf fail build-i386 fail build-amd64-libvirt blocked build-arm64-libvirt blocked build-armhf-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl blocked test-amd64-coresched-amd64-xl blocked test-arm64-arm64-xl blocked test-armhf-armhf-xl blocked test-amd64-i386-xl blocked test-amd64-coresched-i386-xl blocked test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm blocked test-amd64-i386-xl-qemuu-debianhvm-i386-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm blocked test-arm64-arm64-xl-xsm blocked test-amd64-i386-xl-xsm blocked test-amd64-amd64-qemuu-nested-amd blocked test-amd64-amd64-xl-pvhv2-amd blocked test-amd64-i386-qemuu-rhel6hvm-amd blocked test-amd64-amd64-dom0pvh-xl-amd blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64 blocked test-amd64-i386-xl-qemuu-debianhvm-amd64 blocked test-amd64-i386-freebsd10-amd64 blocked test-amd64-amd64-qemuu-freebsd11-amd64 blocked test-amd64-amd64-qemuu-freebsd12-amd64 blocked test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked test-amd64-amd64-xl-qemuu-win7-amd64 blocked test-amd64-i386-xl-qemuu-win7-amd64 blocked test-amd64-amd64-xl-qemuu-ws16-amd64 blocked test-amd64-i386-xl-qemuu-ws16-amd64 blocked test-armhf-armhf-xl-arndale blocked test-amd64-amd64-xl-credit1 blocked test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 blocked test-amd64-amd64-xl-credit2 blocked test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 blocked test-armhf-armhf-xl-cubietruck blocked test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict blocked test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict blocked test-amd64-i386-freebsd10-i386 blocked test-amd64-amd64-qemuu-nested-intel blocked test-amd64-amd64-xl-pvhv2-intel blocked test-amd64-i386-qemuu-rhel6hvm-intel blocked test-amd64-amd64-dom0pvh-xl-intel blocked test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu blocked test-armhf-armhf-xl-multivcpu blocked test-amd64-amd64-pair blocked test-amd64-i386-pair blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim blocked test-amd64-i386-xl-pvshim blocked test-amd64-amd64-pygrub blocked test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds blocked test-armhf-armhf-xl-rtds blocked test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow blocked test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow blocked test-amd64-amd64-xl-shadow blocked test-amd64-i386-xl-shadow blocked test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd blocked test-amd64-i386-xl-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2556 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Jan 10 04:58:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 04:58:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474243.735299 (Exim 4.92) (envelope-from ) id 1pF6iS-0001IE-VS; Tue, 10 Jan 2023 04:58:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474243.735299; Tue, 10 Jan 2023 04:58:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF6iS-0001I7-R6; Tue, 10 Jan 2023 04:58:28 +0000 Received: by outflank-mailman (input) for mailman id 474243; Tue, 10 Jan 2023 04:58:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF6iQ-0001Hz-3J for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 04:58:27 +0000 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [2a00:1450:4864:20::62c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 65cf9b72-90a3-11ed-b8d0-410ff93cb8f0; Tue, 10 Jan 2023 05:58:18 +0100 (CET) Received: by mail-ej1-x62c.google.com with SMTP id fy8so25529944ejc.13 for ; Mon, 09 Jan 2023 20:58:18 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 65cf9b72-90a3-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=oaOewmfSeYePVpf6Vcv0RW6UCzStuvGNQs9auxSLeQM=; b=CcjeblesSGSj/sMxe/RzZfljUQg7dE1wPDmksLHJEbu60d4BARBRM++wYJrbvzduji m7Hv76c+2nlDh+hmZKChA3ggbIrKK7WeYQ+XS70vPLP+7okiqFDjumA0PDIAJqXaaOfc pmwBN9vJAbZDEhextYv6N2xvPMyswkzOwCN0LytVd4Puu6YCLBgPJEjomPCBmvtAdAUB xAhVJ6AS7Hr8bJ+wxb4R0Xms3SoovldeSjctShE/X5CwqcmQu/Mvpa0IRzw/+oOcmLJJ Nx0mRAuzggHMa6nQ/G1xHv1xFI/egsFdNMxI71M27Y85STeLGgtNsSwkVe5b2ZE0sX4+ sp3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oaOewmfSeYePVpf6Vcv0RW6UCzStuvGNQs9auxSLeQM=; b=mYQb/hD7rtMY3OR3f9oI2Cp75QF8grMNmlc/2qDCONbshbMu8bcLfh4tNgZS4J2g5y uEvalGOj3Vy42y2IYLtppzWH1mIGzmimcDjeOP8XWZy05iaxKOzqoROyveNNVD0L5VDH nHNiOFjPnXShCt4k37kzvGQ+y5oZM9/SjnFn0hYZiA2SuXbKQdr62CAkok8qDPwNRZfV 1LeWHl5jZYuKGsPkK/UdZBNJbMJF7L/5kAIuAeLx+UtvsB4CjeKbApkMZd8OaUujWTl/ fIohoxhV+NzDgRlLCAV0U/IJCiCnqBFZYIXT+Ay/+9kHMn2QU4apPgGNiQVa7F7b9Gzx NenA== X-Gm-Message-State: AFqh2krslrenXiScvmZ1YdemRo2Ls2QC4UMXGea5RwE4j5LlSnsJ9+Q6 WN9tjjAlwrArq7Vef3WgkrqBXp7dvR8zL+FtnFQ= X-Google-Smtp-Source: AMrXdXtqpBpWxptVz+OnnSsCnAlLP6i6Neh/9tksCYA7axiPmWBunDvEU9wB3eFEZJS9/5DM1quawOagOlCojTBsyLs= X-Received: by 2002:a17:906:281b:b0:7c1:98f:be57 with SMTP id r27-20020a170906281b00b007c1098fbe57mr3786498ejc.97.1673326697625; Mon, 09 Jan 2023 20:58:17 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Vipul Suneja Date: Tue, 10 Jan 2023 10:28:03 +0530 Message-ID: Subject: Re: Porting Xen in raspberry pi4B To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, oleksandr_andrushchenko@epam.com, oleksandr_tyshchenko@epam.com, jgross@suse.com, boris.ostrovsky@oracle.com, Bertrand.Marquis@arm.com, Stewart.Hildebrand@amd.com, michal.orzel@amd.com, vikram.garhwal@amd.com Content-Type: multipart/alternative; boundary="00000000000067bdb605f1e1bbce" --00000000000067bdb605f1e1bbce Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Stefano, Thanks! Any input further as per the logs attached? Regards, Vipul Kumar On Mon, Dec 26, 2022 at 11:30 PM Vipul Suneja wrote: > Hi Stefano, > > Thanks! > > As you have mention function call qemu_create_displaysurface, > qemu_create_displaysurface_from, dpy_gfx_replace_surface, dpy_gfx_update > and dpy_gfx_check_format, i found that > these functions are not part of /ui/vnc.c source but they are defined in > /ui/console.c source. Even none of these functions have been called from > the vnc.c source. I have included debug logs for > all of these functions in console.c but could see in the logs that only > qemu_create_displaysurface & dpy_gfx_replace_surface functions are > invoked. Even i tried vncviewer > on the host machine but other functions are not invoked. Attaching the lo= g > file, any other suggestion as per log file or any input for debugging vnc > source file. > > *You can also try to use another QEMU UI like SDL to see if the problem i= s > specific to VNC only.* > I already tried with SDL, by adding "vfb=3D[ 'type=3Dsdl' ]" in the guest > configuration file but it failed & didn't start the guest machine. Correc= t > me if I am wrong with configuration or steps to use SDL? > > Thanks & Regards, > Vipul Kumar > > On Fri, Dec 23, 2022 at 5:13 AM Stefano Stabellini > wrote: > >> Hi Vipul, >> >> Great that you managed to setup a debugging environment. The logs look >> very promising: it looks like xenfb.c is handling events as expected. >> So it would apparently seem that xen-fbfront.c -> xenfb.c connection is >> working. >> >> So the next step is the xenfb.c -> ./ui/vnc.c is working. >> >> It could be that the pixels and mouse events arrive just fine in >> xenfb.c, but then there is an issue with exporting them to the vncserver >> implementation inside QEMU, which is ./ui/vnc.c. The interesting >> functions there are qemu_create_displaysurface, >> qemu_create_displaysurface_from, dpy_gfx_replace_surface, >> dpy_gfx_update, and dpy_gfx_check_format. >> >> Specifically dpy_gfx_update should cause VNC to render the new area. >> >> qemu_create_displaysurface_from let VNC use the xenfb buffer directly >> with VNC, rather than using a secondary buffer and memory copies. >> Interestingly, dpy_gfx_check_format should be used to check if it is >> appropriate to share the buffer (qemu_create_displaysurface_from) or not >> (qemu_create_displaysurface) but we don't call it. >> >> I think it would be good to add a call to dpy_gfx_check_format in >> xenfb_update where we call qemu_create_displaysurface_from and also add >> a printk. >> >> You can try to disable the buffer sharing by replacing >> qemu_create_displaysurface_from with qemu_create_displaysurface. You can >> also try to use another QEMU UI like SDL to see if the problem is >> specific to VNC only. >> >> Cheers, >> >> Stefano >> >> >> On Mon, 19 Dec 2022, Vipul Suneja wrote: >> > Hi Stefano, >> > >> > Thanks! >> > >> > I could prepare a patch for adding debug printf logs in xenfb.c & >> re-compile QEMU in yocto image. Just for reference, I have included logs >> > in all the functions. >> > Attaching qemu log file, could see the entry & exit logs coming up for >> "xenfb_handle_events" & "xenfb_map_fb" also after the host machine >> > boots up. Can you please further assist, which parameters has to be >> cross checked or any other input as per logs? >> > >> > Thanks & Regards, >> > Vipul Kumar >> > >> > On Thu, Dec 15, 2022 at 4:17 AM Stefano Stabellini < >> sstabellini@kernel.org> wrote: >> > Hi Vipul, >> > >> > For QEMU you actually need to follow the Yocto build process to >> update >> > the QEMU binary. That is because QEMU is a userspace application >> with >> > lots of library dependencies so we cannot just do "make" with a >> > cross-compiler like in the case of Xen. >> > >> > So you need to make changes to QEMU and then add those changes a= s >> a >> > patch to the Yocto QEMU build recipe, or configure Yocto to your >> local >> > tree to build QEMU. I am not a Yocto expert and the Yocto >> community >> > would be a better place to ask for advice there. You can see fro= m >> here >> > some instructions on how to build Xen using a local tree, see th= e >> usage >> > of EXTERNALSRC (note that this is *not* what you need: you need >> to build >> > QEMU with a local tree, not Xen. But I thought that the wikipage >> might >> > still be a starting point) >> > >> > https://wiki.xenproject.org/wiki/Xen_on_ARM_and_Yocto >> > >> > Cheers, >> > >> > Stefano >> > >> > >> > On Thu, 15 Dec 2022, Vipul Suneja wrote: >> > > Hi Stefano, >> > > >> > > Thanks! >> > > >> > > I could see QEMU 6.2.0 compiled & installed in the host image >> xen-image-minimal. I could find xenfb.c source file also & >> > modified the same >> > > with debug logs. >> > > I have set up a cross compile environment, did 'make clean' & >> 'make all' to recompile but it's failing. In case i am doing >> > wrong, Can you >> > > please assist me >> > > with the correct steps to compile qemu? Below are the error >> logs: >> > > >> > > >> > agl@agl-OptiPlex-7010 >> :~/Automotive/ADAS_Infotainment/Platform/Poky_Kirkstone/build/tmp/work/c= ortexa72-poky-linux/qemu/6.2.0-r0/build$ >> > make >> > > all >> > > [1/3864] Compiling C object libslirp.a.p/slirp_src_arp_table.c= .o >> > > [2/3864] Compiling C object >> subprojects/libvhost-user/libvhost-user.a.p/libvhost-user.c.o >> > > [3/3864] Linking static target >> subprojects/libvhost-user/libvhost-user.a >> > > [4/3864] Compiling C object libslirp.a.p/slirp_src_vmstate.c.o >> > > [5/3864] Compiling C object libslirp.a.p/slirp_src_dhcpv6.c.o >> > > [6/3864] Compiling C object libslirp.a.p/slirp_src_dnssearch.c= .o >> > > [7/3864] Compiling C object libslirp.a.p/slirp_src_bootp.c.o >> > > [8/3864] Compiling C object libslirp.a.p/slirp_src_cksum.c.o >> > > [9/3864] Compiling C object libslirp.a.p/slirp_src_if.c.o >> > > [10/3864] Compiling C object libslirp.a.p/slirp_src_ip6_icmp.c= .o >> > > [11/3864] Compiling C object >> libslirp.a.p/slirp_src_ip6_input.c.o >> > > [12/3864] Compiling C object >> libslirp.a.p/slirp_src_ip6_output.c.o >> > > [13/3864] Compiling C object libslirp.a.p/slirp_src_ip_icmp.c.= o >> > > [14/3864] Compiling C object libslirp.a.p/slirp_src_ip_input.c= .o >> > > [15/3864] Compiling C object >> libslirp.a.p/slirp_src_ip_output.c.o >> > > [16/3864] Compiling C object libslirp.a.p/slirp_src_mbuf.c.o >> > > [17/3864] Compiling C object libslirp.a.p/slirp_src_misc.c.o >> > > [18/3864] Compiling C object libslirp.a.p/slirp_src_ncsi.c.o >> > > [19/3864] Compiling C object >> libslirp.a.p/slirp_src_ndp_table.c.o >> > > [20/3864] Compiling C object libslirp.a.p/slirp_src_sbuf.c.o >> > > [21/3864] Compiling C object libslirp.a.p/slirp_src_slirp.c.o >> > > [22/3864] Compiling C object libslirp.a.p/slirp_src_socket.c.o >> > > [23/3864] Compiling C object libslirp.a.p/slirp_src_state.c.o >> > > [24/3864] Compiling C object libslirp.a.p/slirp_src_stream.c.o >> > > [25/3864] Compiling C object >> libslirp.a.p/slirp_src_tcp_input.c.o >> > > [26/3864] Compiling C object >> libslirp.a.p/slirp_src_tcp_output.c.o >> > > [27/3864] Compiling C object libslirp.a.p/slirp_src_tcp_subr.c= .o >> > > [28/3864] Compiling C object >> libslirp.a.p/slirp_src_tcp_timer.c.o >> > > [29/3864] Compiling C object libslirp.a.p/slirp_src_tftp.c.o >> > > [30/3864] Compiling C object libslirp.a.p/slirp_src_udp.c.o >> > > [31/3864] Compiling C object libslirp.a.p/slirp_src_udp6.c.o >> > > [32/3864] Compiling C object libslirp.a.p/slirp_src_util.c.o >> > > [33/3864] Compiling C object libslirp.a.p/slirp_src_version.c.= o >> > > [34/3864] Linking static target libslirp.a >> > > [35/3864] Generating qemu-version.h with a custom command >> (wrapped by meson to capture output) >> > > FAILED: qemu-version.h >> > >> >/home/agl/Automotive/ADAS_Infotainment/Platform/Poky_Kirkstone/build/t= mp/work/cortexa72-poky-linux/qemu/6.2.0-r0/recipe-sysroot-native/usr >> > >> > > /bin/meson --internal exe --capture >> qemu-version.h--/home/agl/Automotive/ADAS_Infotainment/Platform/Poky_Kir= kstone/build/tmp/work/cortexa72-poky-linux/qemu/6.2.0-r0/qemu-6.2.0/scripts= /qemu >> > -v >> > > ersion.sh >> > >> /home/agl/Automotive/ADAS_Infotainment/Platform/Poky_Kirkstone/build/tm= p/work/cortexa72-poky-linux/qemu/6.2.0-r0/qemu-6.2.0 >> '' >> > > 6.2.0 >> > > /usr/bin/env: =E2=80=98nativepython3=E2=80=99: No such file or= directory >> > > ninja: build stopped: subcommand failed. >> > > make: *** [Makefile:162: run-ninja] Error 1 >> > > >> > > Thanks & Regards, >> > > Vipul Kumar >> > > >> > > On Wed, Dec 14, 2022 at 4:55 AM Stefano Stabellini < >> sstabellini@kernel.org> wrote: >> > > Hi Vipul, >> > > >> > > Good progress! The main function we should check is >> "xenfb_refresh" but >> > > from the logs it looks like it is called several times. >> Which means that >> > > everything seems to be working as expected on the Linux >> side. >> > > >> > > It is time to investigate the QEMU side: >> > > ./hw/display/xenfb.c:xenfb_handle_events >> > > ./hw/display/xenfb.c:xenfb_map_fb >> > > >> > > I wonder if the issue is internal to QEMU. You might wan= t >> to use an >> > > older QEMU version to check if it works, maybe 6.0 or 5.= 0 >> or even 4.0. >> > > I also wonder if it is a problem between xenfb.c and the >> rest of QEMU. I >> > > would investigate how xenfb->pixels is rendered by the >> rest of QEMU. >> > > Specifically you might want to look at the call to >> > > qemu_create_displaysurface, >> qemu_create_displaysurface_from and >> > > dpy_gfx_replace_surface in xenfb_update. >> > > >> > > I hope this helps. >> > > >> > > Cheers, >> > > >> > > Stefano >> > > >> > > >> > > On Tue, 13 Dec 2022, Vipul Suneja wrote: >> > > > Hi Stefano, >> > > > >> > > > Thanks! >> > > > >> > > > I modified xen-fbfront.c source file, included printk >> debug logs & cross compiled it. I included the printk debug log >> > at the >> > > entry & exit >> > > > of all functions of xen-fbfront.c file. >> > > > Generated kernel module & loaded in guest machine at >> bootup. I could see lots of logs coming up, and could see >> > multiple >> > > functions being >> > > > invoked even if I have not used vncviewer in the host. >> Attaching the log file for reference. Any specific function or >> > > parameters that have >> > > > to be checked or any other suggestion as per logs? >> > > > >> > > > Thanks & Regards, >> > > > Vipul Kumar >> > > > >> > > > On Tue, Dec 13, 2022 at 3:44 AM Stefano Stabellini < >> sstabellini@kernel.org> wrote: >> > > > Hi Vipul, >> > > > >> > > > I am online on IRC OFTC #xendevel ( >> https://www.oftc.net/, you need a >> > > > registered nickname to join #xendevel). >> > > > >> > > > For development and debugging I find that it is = a >> lot easier to >> > > > crosscompile the kernel "by hand", and do a >> monolithic build, rather >> > > > than going through Yocto. >> > > > >> > > > For instance the following builds for me: >> > > > >> > > > cd linux.git >> > > > export ARCH=3Darm64 >> > > > export CROSS_COMPILE=3D/path/to/cross-compiler >> > > > make defconfig >> > > > [add printks to drivers/video/fbdev/xen-fbfront.= c] >> > > > make -j8 Image.gz >> > > > >> > > > And Image.gz boots on Xen as DomU kernel without >> issues. >> > > > >> > > > Cheers, >> > > > >> > > > Stefano >> > > > >> > > > On Sat, 10 Dec 2022, Vipul Suneja wrote: >> > > > > Hi Stefano, >> > > > > >> > > > > Thanks! >> > > > > >> > > > > I have included printk debug logs in the >> xen-fbfront.c source file. While cross compiling to generate .ko >> > with >> > > > "xen-guest-image-minimal" >> > > > > toolchain it's throwing a modpost >> > > > > not found error. I could see the modpost.c >> source file but the final script is missing. Any input on this, >> > Below are >> > > the >> > > > logs: >> > > > > >> > > > > agl@agl-OptiPlex-7010:~/Automotive/ADAS_Infota= inment/project/Application/Xen/Framebuffer$ >> make >> > > > > make ARCH=3Darm64 >> -I/opt/poky/4.0.5/sysroots/cortexa72-poky-linux/usr/include/asm -C >> > > > > >> /opt/poky/4.0.5/sysroots/cortexa72-poky-linux/lib/modules/5.15.72-yocto-= standard/build >> > > > > >> M=3D/home/agl/Automotive/ADAS_Infotainment/project/Application/Xen/Frame= buffer >> modules >> > > > > make[1]: Entering directory >> > >> '/opt/poky/4.0.5/sysroots/cortexa72-poky-linux/lib/modules/5.15.72-yoct= o-standard/build' >> > > > > arch/arm64/Makefile:36: Detected assembler wit= h >> broken .inst; disassembly will be unreliable >> > > > > warning: the compiler differs from the one use= d >> to build the kernel >> > > > > The kernel was built by: gcc (Ubuntu >> 9.4.0-1ubuntu1~20.04.1) 9.4.0 >> > > > > You are using: >> aarch64-poky-linux-gcc (GCC) 11.3.0 >> > > > > CC [M] >> /home/agl/Automotive/ADAS_Infotainment/project/Application/Xen/Framebuf= fer/xen-fbfront.o >> > > > > MODPOST >> /home/agl/Automotive/ADAS_Infotainment/project/Application/Xen/Framebuff= er/Module.symvers >> > > > > /bin/sh: 1: scripts/mod/modpost: not found >> > > > > make[2]: *** [scripts/Makefile.modpost:133: >> > > > >> /home/agl/Automotive/ADAS_Infotainment/project/Application/Xen/Framebuf= fer/Module.symvers] >> > > > > Error 127 >> > > > > make[1]: *** [Makefile:1813: modules] Error 2 >> > > > > make[1]: Leaving directory >> > >> '/opt/poky/4.0.5/sysroots/cortexa72-poky-linux/lib/modules/5.15.72-yoct= o-standard/build' >> > > > > make: *** [Makefile:5: all] Error 2 >> > > > > agl@agl-OptiPlex-7010:~/Automotive/ADAS_Infota= inment/project/Application/Xen/Framebuffer$ >> ls -l >> > > > > total 324 >> > > > > -rwxrwxrwx 1 agl agl 359 Dec 10 22:41 >> Makefile >> > > > > -rw-rw-r-- 1 agl agl 90 Dec 10 22:49 >> modules.order >> > > > > -rw-r--r-- 1 agl agl 18331 Dec 1 20:32 >> xen-fbfront.c >> > > > > -rw-rw-r-- 1 agl agl 90 Dec 10 22:49 >> xen-fbfront.mod >> > > > > -rw-rw-r-- 1 agl agl 297832 Dec 10 22:49 >> xen-fbfront.o >> > > > > agl@agl-OptiPlex-7010:~/Automotive/ADAS_Infota= inment/project/Application/Xen/Framebuffer$ >> file xen-fbfront.o >> > > > > xen-fbfront.o: ELF 64-bit LSB relocatable, ARM >> aarch64, version 1 (SYSV), with debug_info, not stripped >> > > > > agl@agl-OptiPlex-7010 >> :~/Automotive/ADAS_Infotainment/project/Application/Xen/Framebuffer$ >> > > > > >> > > > > I have connected a HDMI based 1980x1024 >> resolution display screen to raspberrypi4 for testing purposes. I >> > hope >> > > connecting >> > > > this display to >> > > > > rpi4 should be ok. >> > > > > >> > > > > Is there any other way we can connect also for >> detailed discussion on the display bringup issue? This will >> > really >> > > help to >> > > > resolve this >> > > > > issue. >> > > > > >> > > > > Thanks & Regards, >> > > > > Vipul Kumar >> > > > > >> > > > > On Fri, Dec 2, 2022 at 1:02 AM Stefano >> Stabellini wrote: >> > > > > On Thu, 1 Dec 2022, Vipul Suneja wrote: >> > > > > > Hi Stefano, >> > > > > > Thanks! >> > > > > > >> > > > > > I am exploring both options here, >> modification of framebuffer source file & setting up x11vnc server >> > in >> > > guest. >> > > > > > Other than these I would like to share >> a few findings with you. >> > > > > > >> > > > > > 1. If i keep >> "CONFIG_XEN_FBDEV_FRONTEND=3Dy" then xen-fbfront.ko is not generating bu= t if >> i keep >> > > > "CONFIG_XEN_FBDEV_FRONTEND=3Dm" >> > > > > > then could see xen-fbfront.ko & its >> loading also. Same things with other frontend/backend drivers >> > also. Do we >> > > need to >> > > > > configure these >> > > > > > drivers as a module(m) only? >> > > > > >> > > > > xen-fbfront should work both as a module >> (xen-fbfront.ko) or built-in >> > > > > (CONFIG_XEN_FBDEV_FRONTEND=3Dy). >> > > > > >> > > > > >> > > > > >> > > > > > 2. I could see xenstored service is >> running for the host but it's always failing for the >> > guest machine. I >> > > could see >> > > > it in >> > > > > bootup logs & via >> > > > > > systemctl status also. >> > > > > >> > > > > That is normal. xenstored is only meant >> to be run in Dom0, not in the >> > > > > domUs. If you use the same rootfs for >> Dom0 and DomU then xenstored will >> > > > > fail starting in the DomU (but should >> succeed in Dom0), which is what we >> > > > > want. >> > > > > >> > > > > If you run "xenstore-ls" in Dom0, you'll >> see a bunch of entries, >> > > > > including some of them related to "vfb" >> which is the virtual framebuffer >> > > > > protocol. You should also see an entry >> called "state" set to "4" which >> > > > > means "connected". state =3D 4 is usuall= y >> when everything works. Normally >> > > > > when things don't work state !=3D 4. >> > > > > >> > > > > >> > > > > >> > > > > > Below are the logs: >> > > > > > [ OK ] Reached target Basic System. >> > > > > > [ OK ] Started Kernel Logging Servic= e. >> > > > > > [ OK ] Started System Logging Servic= e. >> > > > > > Starting D-Bus System Message >> Bus... >> > > > > > Starting User Login >> Management... >> > > > > > Starting Permit User >> Sessions... >> > > > > > Starting The Xen xenstore... >> > > > > > Starting OpenSSH Key >> Generation... >> > > > > > [FAILED] Failed to start The Xen >> xenstore. >> > > > > > See 'systemctl status >> xenstored.service' for details. >> > > > > > [DEPEND] Dependency failed for qemu fo= r >> xen dom0 disk backend. >> > > > > > [DEPEND] Dependency failed for Xend=E2= =80=A6p >> guests on boot and shutdown. >> > > > > > [DEPEND] Dependency failed for >> xen-=E2=80=A6des, JSON configuration stub). >> > > > > > [DEPEND] Dependency failed for >> Xenc=E2=80=A6guest consoles and hypervisor. >> > > > > > [ OK ] Finished Permit User Sessions= . >> > > > > > [ OK ] Started Getty on tty1. >> > > > > > [ OK ] Started Serial Getty on hvc0. >> > > > > > [ OK ] Started Serial Getty on ttyS0= . >> > > > > > [ OK ] Reached target Login Prompts. >> > > > > > Starting Xen-watchdog - run >> xen watchdog daemon... >> > > > > > [ OK ] Started D-Bus System Message >> Bus. >> > > > > > [ OK ] Started Xen-watchdog - run xe= n >> watchdog daemon. >> > > > > > [ OK ] Finished OpenSSH Key >> Generation. >> > > > > > [ OK ] Started User Login Management= . >> > > > > > [ OK ] Reached target Multi-User >> System. >> > > > > > Starting Record Runlevel >> Change in UTMP... >> > > > > > [ OK ] Finished Record Runlevel >> Change in UTMP. >> > > > > > fbcon: Taking over console >> > > > > > >> > > > > > Poky (Yocto Project Reference Distro) >> 4.0.4 raspberrypi4-64 hvc0 >> > > > > > >> > > > > > raspberrypi4-64 login: root >> > > > > > root@raspberrypi4-64:~# >> > > > > > root@raspberrypi4-64:~# >> > > > > > root@raspberrypi4-64:~# systemctl >> status xenstored.service >> > > > > > x xenstored.service - The Xen xenstore >> > > > > > Loaded: loaded >> (/lib/systemd/system/xenstored.service; enabled; vendor preset: enabled) >> > > > > > Active: failed (Result: exit-code= ) >> since Thu 2022-12-01 06:12:05 UTC; 26s ago >> > > > > > Process: 195 ExecStartPre=3D/bin/g= rep >> -q control_d /proc/xen/capabilities (code=3Dexited, >> > status=3D1/FAILURE) >> > > > > > >> > > > > > Dec 01 06:12:04 raspberrypi4-64 >> systemd[1]: Starting The Xen xenstore... >> > > > > > Dec 01 06:12:05 raspberrypi4-64 >> systemd[1]: xenstored.service: Control pro...URE >> > > > > > Dec 01 06:12:05 raspberrypi4-64 >> systemd[1]: xenstored.service: Failed with...e'. >> > > > > > Dec 01 06:12:05 raspberrypi4-64 >> systemd[1]: Failed to start The Xen xenstore. >> > > > > > Hint: Some lines were ellipsized, use >> -l to show in full. >> > > > > > root@raspberrypi4-64:~# >> > > > > > >> > > > > > Any input on these? >> > > > > > >> > > > > > Thanks & Regards, >> > > > > > Vipul Kumar >> > > > > > >> > > > > > On Wed, Nov 23, 2022 at 5:41 AM Stefan= o >> Stabellini wrote: >> > > > > > Hi Vipul, >> > > > > > >> > > > > > I cannot spot any issue in the >> configuration, in particual you have: >> > > > > > >> > > > > > CONFIG_XEN_FBDEV_FRONTEND=3Dy >> > > > > > >> > > > > > which is what you need. >> > > > > > >> > > > > > The only thing I can suggest is >> to add printks to the Linux frontend >> > > > > > driver (the one running in the >> domU) which is >> > > > > > drivers/video/fbdev/xen-fbfront.= c >> and printfs to the QEMU backend >> > > > > > (running in Dom0) which is >> hw/display/xenfb.c to figure out what is >> > > > > > going on. >> > > > > > >> > > > > > >> > > > > > Alternatively, you can setup PV >> network with the domU, such as: >> > > > > > >> > > > > > vif=3D[''] >> > > > > > >> > > > > > and then run x11 and a x11vnc >> server in your domU. You should be able to >> > > > > > connect to it using vncviewer at >> the network IP of your domU. >> > > > > > >> > > > > > Basically you are skipping the >> problem because instead of using the PV >> > > > > > framebuffer protocol, you just >> use VNC over the network with the domU. >> > > > > > >> > > > > > >> > > > > > Cheers, >> > > > > > >> > > > > > Stefano >> > > > > > >> > > > > > >> > > > > > On Tue, 22 Nov 2022, Vipul Sunej= a >> wrote: >> > > > > > > Hi Stefano, >> > > > > > > Thanks for the support! >> > > > > > > >> > > > > > > Looks like I have tried all th= e >> combinations & possible ways to get display up but failed. Is >> > there >> > > any >> > > > document or >> > > > > pdf for >> > > > > > porting xen on >> > > > > > > raspberrypi4. >> > > > > > > I could find lot's of links >> telling the same but couldn't see any official user guide or >> > document >> > > from the >> > > > xen >> > > > > community on >> > > > > > the same. If >> > > > > > > there is something to refer >> > > > > > > to please share with me. >> > > > > > > I am attaching the kernel >> configuration file also, just take a look if i have missed >> > anything. >> > > > > > > Any other suggestions or input >> from your end could be really helpful? >> > > > > > > >> > > > > > > Regards, >> > > > > > > Vipul Kumar >> > > > > > > >> > > > > > > On Fri, Nov 11, 2022 at 6:40 A= M >> Stefano Stabellini wrote: >> > > > > > > Hi Vipul, >> > > > > > > >> > > > > > > Sorry for the late reply= . >> From the earlier logs that you sent, it looks >> > > > > > > like everything should b= e >> working correctly. Specifically: >> > > > > > > >> > > > > > > vfb =3D "" >> > > > > > > 1 =3D "" >> > > > > > > 0 =3D "" >> > > > > > > frontend =3D >> "/local/domain/1/device/vfb/0" >> > > > > > > frontend-id =3D = "1" >> > > > > > > online =3D "1" >> > > > > > > state =3D "4" >> > > > > > > vnc =3D "1" >> > > > > > > vnclisten =3D >> "127.0.0.1" >> > > > > > > vncdisplay =3D "= 0" >> > > > > > > vncunused =3D "1= " >> > > > > > > sdl =3D "0" >> > > > > > > opengl =3D "0" >> > > > > > > feature-resize = =3D >> "1" >> > > > > > > hotplug-status = =3D >> "connected" >> > > > > > > request-update = =3D >> "1" >> > > > > > > >> > > > > > > state "4" means >> "connected". So I would expect that you should be able >> > > > > > > to connect to the vnc >> server using vncviewer. You might not see anything >> > > > > > > (black screen) but you >> should definitely be able to connect. >> > > > > > > >> > > > > > > I wouldn't try to launch >> x11 in the guest just yet. fbcon in Linux is >> > > > > > > enough to render >> something on the screen. You should be able to see the >> > > > > > > Linux text-based console >> rendered graphically, connecting to it via vnc. >> > > > > > > >> > > > > > > Sorry for the basic >> question, but have you tried all the following? >> > > > > > > >> > > > > > > vncviewer 127.0.0.1:0 >> > > > > > > vncviewer 127.0.0.1:1 >> > > > > > > vncviewer 127.0.0.1:2 >> > > > > > > vncviewer 127.0.0.1:5900 >> > > > > > > vncviewer 127.0.0.1:5901 >> > > > > > > vncviewer 127.0.0.1:5902 >> > > > > > > >> > > > > > > Given that from the >> xenstore-ls logs everything seems to work correctly >> > > > > > > I am not sure what else >> to suggest. You might have to add printf to QEMU >> > > > > > > ui/vnc.c and >> hw/display/xenfb.c to see what is going wrong. >> > > > > > > >> > > > > > > Cheers, >> > > > > > > >> > > > > > > Stefano >> > > > > > > >> > > > > > > >> > > > > > > On Mon, 7 Nov 2022, Vipu= l >> Suneja wrote: >> > > > > > > > Hi Stefano, >> > > > > > > > Thanks! >> > > > > > > > >> > > > > > > > Any input further on >> "xenstore-ls" logs? >> > > > > > > > >> > > > > > > > I am trying to run the >> x0vncserver & x11vnc server manually on guest >> > > machine(xen_guest_image_minimal) >> > > > image >> > > > > but it's >> > > > > > failing >> > > > > > > with the below >> > > > > > > > error. >> > > > > > > > >> > > > > > > > root@raspberrypi4-64:/= usr/bin# >> x0vncserver >> > > > > > > > x0vncserver: unable to >> open display "" >> > > > > > > > root@raspberrypi4-64 >> :/usr/bin# >> > > > > > > > root@raspberrypi4-64:/= usr/bin# >> x11vnc >> > > > > > > > >> ############################################################### >> > > > > > > > >> #@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@# >> > > > > > > > #@ >> @# >> > > > > > > > #@ ** WARNING ** >> WARNING ** WARNING ** WARNING ** @# >> > > > > > > > #@ >> @# >> > > > > > > > #@ YOU ARE >> RUNNING X11VNC WITHOUT A PASSWORD!! @# >> > > > > > > > #@ >> @# >> > > > > > > > #@ This means anyone >> with network access to this computer @# >> > > > > > > > #@ may be able to vie= w >> and control your desktop. @# >> > > > > > > > #@ >> @# >> > > > > > > > #@ >>> If you did not >> mean to do this Press CTRL-C now!! <<< @# >> > > > > > > > #@ >> @# >> > > > > > > > >> #@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@# >> > > > > > > > #@ >> @# >> > > > > > > > #@ You can create an >> x11vnc password file by running: @# >> > > > > > > > #@ >> @# >> > > > > > > > #@ x11vnc >> -storepasswd password /path/to/passfile @# >> > > > > > > > #@ or x11vnc >> -storepasswd /path/to/passfile @# >> > > > > > > > #@ or x11vnc >> -storepasswd @# >> > > > > > > > #@ >> @# >> > > > > > > > #@ (the last one will >> use ~/.vnc/passwd) @# >> > > > > > > > #@ >> @# >> > > > > > > > #@ and then starting >> x11vnc via: @# >> > > > > > > > #@ >> @# >> > > > > > > > #@ x11vnc -rfbaut= h >> /path/to/passfile @# >> > > > > > > > #@ >> @# >> > > > > > > > #@ an existing >> ~/.vnc/passwd file from another VNC @# >> > > > > > > > #@ application will >> work fine too. @# >> > > > > > > > #@ >> @# >> > > > > > > > #@ You can also use >> the -passwdfile or -passwd options. @# >> > > > > > > > #@ (note -passwd is >> unsafe if local users are not trusted) @# >> > > > > > > > #@ >> @# >> > > > > > > > #@ Make sure any >> -rfbauth and -passwdfile password files @# >> > > > > > > > #@ cannot be read by >> untrusted users. @# >> > > > > > > > #@ >> @# >> > > > > > > > #@ Use x11vnc -usepw >> to automatically use your @# >> > > > > > > > #@ ~/.vnc/passwd or >> ~/.vnc/passwdfile password files. @# >> > > > > > > > #@ (and prompt you to >> create ~/.vnc/passwd if neither @# >> > > > > > > > #@ file exists.) >> Under -usepw, x11vnc will exit if it @# >> > > > > > > > #@ cannot find a >> password to use. @# >> > > > > > > > #@ >> @# >> > > > > > > > #@ >> @# >> > > > > > > > #@ Even with a >> password, the subsequent VNC traffic is @# >> > > > > > > > #@ sent in the clear. >> Consider tunnelling via ssh(1): @# >> > > > > > > > #@ >> @# >> > > > > > > > #@ >> http://www.karlrunge.com/x11vnc/#tunnelling @# >> > > > > > > > #@ >> @# >> > > > > > > > #@ Or using the x11vn= c >> SSL options: -ssl and -stunnel @# >> > > > > > > > #@ >> @# >> > > > > > > > #@ Please Read the >> documentation for more info about @# >> > > > > > > > #@ passwords, >> security, and encryption. @# >> > > > > > > > #@ >> @# >> > > > > > > > #@ >> http://www.karlrunge.com/x11vnc/faq.html#faq-passwd @# >> > > > > > > > #@ >> @# >> > > > > > > > #@ To disable this >> warning use the -nopw option, or put @# >> > > > > > > > #@ 'nopw' on a line i= n >> your ~/.x11vncrc file. @# >> > > > > > > > #@ >> @# >> > > > > > > > >> #@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@# >> > > > > > > > >> ############################################################### >> > > > > > > > 09/03/2018 12:58:41 >> x11vnc version: 0.9.16 lastmod: 2019-01-05 pid: 424 >> > > > > > > > 09/03/2018 12:58:41 >> XOpenDisplay("") failed. >> > > > > > > > 09/03/2018 12:58:41 >> Trying again with XAUTHLOCALHOSTNAME=3Dlocalhost ... >> > > > > > > > 09/03/2018 12:58:41 >> > > > > > > > 09/03/2018 12:58:41 **= * >> XOpenDisplay failed. No -display or DISPLAY. >> > > > > > > > 09/03/2018 12:58:41 **= * >> Trying ":0" in 4 seconds. Press Ctrl-C to abort. >> > > > > > > > 09/03/2018 12:58:41 **= * >> 1 2 3 4 >> > > > > > > > 09/03/2018 12:58:45 >> XOpenDisplay(":0") failed. >> > > > > > > > 09/03/2018 12:58:45 >> Trying again with XAUTHLOCALHOSTNAME=3Dlocalhost ... >> > > > > > > > 09/03/2018 12:58:45 >> XOpenDisplay(":0") failed. >> > > > > > > > 09/03/2018 12:58:45 >> Trying again with unset XAUTHLOCALHOSTNAME ... >> > > > > > > > 09/03/2018 12:58:45 >> > > > > > > > >> > > > > > > > 09/03/2018 12:58:45 >> *************************************** >> > > > > > > > 09/03/2018 12:58:45 **= * >> XOpenDisplay failed (:0) >> > > > > > > > >> > > > > > > > *** x11vnc was unable >> to open the X DISPLAY: ":0", it cannot continue. >> > > > > > > > *** There may be >> "Xlib:" error messages above with details about the failure. >> > > > > > > > >> > > > > > > > Some tips and >> guidelines: >> > > > > > > > >> > > > > > > > ** An X server (the on= e >> you wish to view) must be running before x11vnc is >> > > > > > > > started: x11vnc doe= s >> not start the X server. (however, see the -create >> > > > > > > > option if that is >> what you really want). >> > > > > > > > >> > > > > > > > ** You must use >> -display , -OR- set and export your $DISPLAY >> > > > > > > > environment variabl= e >> to refer to the display of the desired X server. >> > > > > > > > - Usually the display >> is simply ":0" (in fact x11vnc uses this if you forget >> > > > > > > > to specify it), but >> in some multi-user situations it could be ":1", ":2", >> > > > > > > > or even ":137". As= k >> your administrator or a guru if you are having >> > > > > > > > difficulty >> determining what your X DISPLAY is. >> > > > > > > > >> > > > > > > > ** Next, you need to >> have sufficient permissions (Xauthority) >> > > > > > > > to connect to the X >> DISPLAY. Here are some Tips: >> > > > > > > > >> > > > > > > > - Often, you just nee= d >> to run x11vnc as the user logged into the X session. >> > > > > > > > So make sure to be >> that user when you type x11vnc. >> > > > > > > > - Being root is >> usually not enough because the incorrect MIT-MAGIC-COOKIE >> > > > > > > > file may be >> accessed. The cookie file contains the secret key that >> > > > > > > > allows x11vnc to >> connect to the desired X DISPLAY. >> > > > > > > > - You can explicitly >> indicate which MIT-MAGIC-COOKIE file should be used >> > > > > > > > by the -auth option= , >> e.g.: >> > > > > > > > x11vnc -auth >> /home/someuser/.Xauthority -display :0 >> > > > > > > > x11vnc -auth >> /tmp/.gdmzndVlR -display :0 >> > > > > > > > you must have read >> permission for the auth file. >> > > > > > > > See also '-auth >> guess' and '-findauth' discussed below. >> > > > > > > > >> > > > > > > > ** If NO ONE is logged >> into an X session yet, but there is a greeter login >> > > > > > > > program like "gdm", >> "kdm", "xdm", or "dtlogin" running, you will need >> > > > > > > > to find and use the >> raw display manager MIT-MAGIC-COOKIE file. >> > > > > > > > Some examples for >> various display managers: >> > > > > > > > >> > > > > > > > gdm: -auth >> /var/gdm/:0.Xauth >> > > > > > > > -auth >> /var/lib/gdm/:0.Xauth >> > > > > > > > kdm: -auth >> /var/lib/kdm/A:0-crWk72 >> > > > > > > > -auth >> /var/run/xauth/A:0-crWk72 >> > > > > > > > xdm: -auth >> /var/lib/xdm/authdir/authfiles/A:0-XQvaJk >> > > > > > > > dtlogin: -auth >> /var/dt/A:0-UgaaXa >> > > > > > > > >> > > > > > > > Sometimes the >> command "ps wwwwaux | grep auth" can reveal the file location. >> > > > > > > > >> > > > > > > > Starting with x11vn= c >> 0.9.9 you can have it try to guess by using: >> > > > > > > > >> > > > > > > > -auth >> guess >> > > > > > > > >> > > > > > > > (see also the x11vn= c >> -findauth option.) >> > > > > > > > >> > > > > > > > Only root will have >> read permission for the file, and so x11vnc must be run >> > > > > > > > as root (or copy >> it). The random characters in the filenames will of course >> > > > > > > > change and the >> directory the cookie file resides in is system dependent. >> > > > > > > > >> > > > > > > > See also: >> http://www.karlrunge.com/x11vnc/faq.html >> > > > > > > > >> > > > > > > > Regards, >> > > > > > > > Vipul Kumar >> > > > > > > > >> > > > > > > > On Thu, Nov 3, 2022 at >> 10:27 PM Vipul Suneja wrote: >> > > > > > > > Hi Stefano, >> > > > > > > > Thanks! >> > > > > > > > >> > > > > > > > I used >> xen-guest-image-minimal(simple console based image) as a guest with fbco= n & >> > fbdev >> > > enabled in >> > > > kernel >> > > > > > configurations but >> > > > > > > still >> > > > > > > > the same error can't >> open the display. >> > > > > > > > below are the outcome >> of "xenstore-ls": >> > > > > > > > >> > > > > > > > root@raspberrypi4-64:~= /guest1# >> xenstore-ls >> > > > > > > > tool =3D "" >> > > > > > > > xenstored =3D "" >> > > > > > > > local =3D "" >> > > > > > > > domain =3D "" >> > > > > > > > 0 =3D "" >> > > > > > > > control =3D "" >> > > > > > > > feature-poweroff = =3D >> "1" >> > > > > > > > feature-reboot =3D= "1" >> > > > > > > > domid =3D "0" >> > > > > > > > name =3D "Domain-0" >> > > > > > > > device-model =3D "" >> > > > > > > > 0 =3D "" >> > > > > > > > backends =3D "" >> > > > > > > > console =3D "" >> > > > > > > > vkbd =3D "" >> > > > > > > > vfb =3D "" >> > > > > > > > qnic =3D "" >> > > > > > > > state =3D "runnin= g" >> > > > > > > > 1 =3D "" >> > > > > > > > backends =3D "" >> > > > > > > > console =3D "" >> > > > > > > > vkbd =3D "" >> > > > > > > > vfb =3D "" >> > > > > > > > qnic =3D "" >> > > > > > > > state =3D "runnin= g" >> > > > > > > > backend =3D "" >> > > > > > > > vbd =3D "" >> > > > > > > > 1 =3D "" >> > > > > > > > 51712 =3D "" >> > > > > > > > frontend =3D >> "/local/domain/1/device/vbd/51712" >> > > > > > > > params =3D >> "/home/root/guest2/xen-guest-image-minimal-raspberrypi4-64.ext3" >> > > > > > > > script =3D >> "/etc/xen/scripts/block" >> > > > > > > > frontend-id =3D= "1" >> > > > > > > > online =3D "1" >> > > > > > > > removable =3D "= 0" >> > > > > > > > bootable =3D "1= " >> > > > > > > > state =3D "4" >> > > > > > > > dev =3D "xvda" >> > > > > > > > type =3D "phy" >> > > > > > > > mode =3D "w" >> > > > > > > > device-type =3D >> "disk" >> > > > > > > > discard-enable = =3D >> "1" >> > > > > > > > >> feature-max-indirect-segments =3D "256" >> > > > > > > > >> multi-queue-max-queues =3D "4" >> > > > > > > > >> max-ring-page-order =3D "4" >> > > > > > > > node =3D >> "/dev/loop0" >> > > > > > > > physical-device >> =3D "7:0" >> > > > > > > > >> physical-device-path =3D "/dev/loop0" >> > > > > > > > hotplug-status = =3D >> "connected" >> > > > > > > > >> feature-flush-cache =3D "1" >> > > > > > > > >> discard-granularity =3D "4096" >> > > > > > > > >> discard-alignment =3D "0" >> > > > > > > > discard-secure = =3D >> "0" >> > > > > > > > feature-discard >> =3D "1" >> > > > > > > > feature-barrier >> =3D "1" >> > > > > > > > >> feature-persistent =3D "1" >> > > > > > > > sectors =3D >> "1794048" >> > > > > > > > info =3D "0" >> > > > > > > > sector-size =3D >> "512" >> > > > > > > > >> physical-sector-size =3D "512" >> > > > > > > > vfb =3D "" >> > > > > > > > 1 =3D "" >> > > > > > > > 0 =3D "" >> > > > > > > > frontend =3D >> "/local/domain/1/device/vfb/0" >> > > > > > > > frontend-id =3D= "1" >> > > > > > > > online =3D "1" >> > > > > > > > state =3D "4" >> > > > > > > > vnc =3D "1" >> > > > > > > > vnclisten =3D >> "127.0.0.1" >> > > > > > > > vncdisplay =3D = "0" >> > > > > > > > vncunused =3D "= 1" >> > > > > > > > sdl =3D "0" >> > > > > > > > opengl =3D "0" >> > > > > > > > feature-resize = =3D >> "1" >> > > > > > > > hotplug-status = =3D >> "connected" >> > > > > > > > request-update = =3D >> "1" >> > > > > > > > vkbd =3D "" >> > > > > > > > 1 =3D "" >> > > > > > > > 0 =3D "" >> > > > > > > > frontend =3D >> "/local/domain/1/device/vkbd/0" >> > > > > > > > frontend-id =3D= "1" >> > > > > > > > online =3D "1" >> > > > > > > > state =3D "4" >> > > > > > > > >> feature-abs-pointer =3D "1" >> > > > > > > > >> feature-raw-pointer =3D "1" >> > > > > > > > hotplug-status = =3D >> "connected" >> > > > > > > > console =3D "" >> > > > > > > > 1 =3D "" >> > > > > > > > 0 =3D "" >> > > > > > > > frontend =3D >> "/local/domain/1/console" >> > > > > > > > frontend-id =3D= "1" >> > > > > > > > online =3D "1" >> > > > > > > > state =3D "1" >> > > > > > > > protocol =3D >> "vt100" >> > > > > > > > vif =3D "" >> > > > > > > > 1 =3D "" >> > > > > > > > 0 =3D "" >> > > > > > > > frontend =3D >> "/local/domain/1/device/vif/0" >> > > > > > > > frontend-id =3D= "1" >> > > > > > > > online =3D "1" >> > > > > > > > state =3D "4" >> > > > > > > > script =3D >> "/etc/xen/scripts/vif-bridge" >> > > > > > > > mac =3D >> "e4:5f:01:cd:7b:dd" >> > > > > > > > bridge =3D "xen= br0" >> > > > > > > > handle =3D "0" >> > > > > > > > type =3D "vif" >> > > > > > > > hotplug-status = =3D >> "connected" >> > > > > > > > feature-sg =3D = "1" >> > > > > > > > >> feature-gso-tcpv4 =3D "1" >> > > > > > > > >> feature-gso-tcpv6 =3D "1" >> > > > > > > > >> feature-ipv6-csum-offload =3D "1" >> > > > > > > > feature-rx-copy >> =3D "1" >> > > > > > > > >> feature-xdp-headroom =3D "1" >> > > > > > > > feature-rx-flip >> =3D "0" >> > > > > > > > >> feature-multicast-control =3D "1" >> > > > > > > > >> feature-dynamic-multicast-control =3D "1" >> > > > > > > > >> feature-split-event-channels =3D "1" >> > > > > > > > >> multi-queue-max-queues =3D "4" >> > > > > > > > >> feature-ctrl-ring =3D "1" >> > > > > > > > 1 =3D "" >> > > > > > > > vm =3D >> "/vm/d81ec5a9-5bf9-4f2b-89e8-0f60d6da948f" >> > > > > > > > name =3D "guest2" >> > > > > > > > cpu =3D "" >> > > > > > > > 0 =3D "" >> > > > > > > > availability =3D >> "online" >> > > > > > > > 1 =3D "" >> > > > > > > > availability =3D >> "online" >> > > > > > > > memory =3D "" >> > > > > > > > static-max =3D >> "2097152" >> > > > > > > > target =3D "209715= 2" >> > > > > > > > videoram =3D "0" >> > > > > > > > device =3D "" >> > > > > > > > suspend =3D "" >> > > > > > > > event-channel =3D= "" >> > > > > > > > vbd =3D "" >> > > > > > > > 51712 =3D "" >> > > > > > > > backend =3D >> "/local/domain/0/backend/vbd/1/51712" >> > > > > > > > backend-id =3D "= 0" >> > > > > > > > state =3D "4" >> > > > > > > > virtual-device = =3D >> "51712" >> > > > > > > > device-type =3D >> "disk" >> > > > > > > > >> multi-queue-num-queues =3D "2" >> > > > > > > > queue-0 =3D "" >> > > > > > > > ring-ref =3D "8= " >> > > > > > > > event-channel = =3D >> "4" >> > > > > > > > queue-1 =3D "" >> > > > > > > > ring-ref =3D "9= " >> > > > > > > > event-channel = =3D >> "5" >> > > > > > > > protocol =3D >> "arm-abi" >> > > > > > > > >> feature-persistent =3D "1" >> > > > > > > > vfb =3D "" >> > > > > > > > 0 =3D "" >> > > > > > > > backend =3D >> "/local/domain/0/backend/vfb/1/0" >> > > > > > > > backend-id =3D "= 0" >> > > > > > > > state =3D "4" >> > > > > > > > page-ref =3D >> "275022" >> > > > > > > > event-channel = =3D >> "3" >> > > > > > > > protocol =3D >> "arm-abi" >> > > > > > > > feature-update = =3D >> "1" >> > > > > > > > vkbd =3D "" >> > > > > > > > 0 =3D "" >> > > > > > > > backend =3D >> "/local/domain/0/backend/vkbd/1/0" >> > > > > > > > backend-id =3D "= 0" >> > > > > > > > state =3D "4" >> > > > > > > > >> request-abs-pointer =3D "1" >> > > > > > > > page-ref =3D >> "275322" >> > > > > > > > page-gref =3D "1= 284" >> > > > > > > > event-channel = =3D >> "10" >> > > > > > > > vif =3D "" >> > > > > > > > 0 =3D "" >> > > > > > > > backend =3D >> "/local/domain/0/backend/vif/1/0" >> > > > > > > > backend-id =3D "= 0" >> > > > > > > > state =3D "4" >> > > > > > > > handle =3D "0" >> > > > > > > > mac =3D >> "e4:5f:01:cd:7b:dd" >> > > > > > > > mtu =3D "1500" >> > > > > > > > xdp-headroom =3D= "0" >> > > > > > > > >> multi-queue-num-queues =3D "2" >> > > > > > > > queue-0 =3D "" >> > > > > > > > tx-ring-ref =3D >> "1280" >> > > > > > > > rx-ring-ref =3D >> "1281" >> > > > > > > > event-channel-t= x >> =3D "6" >> > > > > > > > event-channel-r= x >> =3D "7" >> > > > > > > > queue-1 =3D "" >> > > > > > > > tx-ring-ref =3D >> "1282" >> > > > > > > > rx-ring-ref =3D >> "1283" >> > > > > > > > event-channel-t= x >> =3D "8" >> > > > > > > > event-channel-r= x >> =3D "9" >> > > > > > > > request-rx-copy = =3D >> "1" >> > > > > > > > feature-rx-notif= y >> =3D "1" >> > > > > > > > feature-sg =3D "= 1" >> > > > > > > > feature-gso-tcpv= 4 >> =3D "1" >> > > > > > > > feature-gso-tcpv= 6 >> =3D "1" >> > > > > > > > >> feature-ipv6-csum-offload =3D "1" >> > > > > > > > control =3D "" >> > > > > > > > shutdown =3D "" >> > > > > > > > feature-poweroff = =3D >> "1" >> > > > > > > > feature-reboot =3D= "1" >> > > > > > > > feature-suspend = =3D "" >> > > > > > > > sysrq =3D "" >> > > > > > > > >> platform-feature-multiprocessor-suspend =3D "1" >> > > > > > > > >> platform-feature-xs_reset_watches =3D "1" >> > > > > > > > data =3D "" >> > > > > > > > drivers =3D "" >> > > > > > > > feature =3D "" >> > > > > > > > attr =3D "" >> > > > > > > > error =3D "" >> > > > > > > > domid =3D "1" >> > > > > > > > store =3D "" >> > > > > > > > port =3D "1" >> > > > > > > > ring-ref =3D "2334= 73" >> > > > > > > > console =3D "" >> > > > > > > > backend =3D >> "/local/domain/0/backend/console/1/0" >> > > > > > > > backend-id =3D "0" >> > > > > > > > limit =3D "1048576= " >> > > > > > > > type =3D "xenconso= led" >> > > > > > > > output =3D "pty" >> > > > > > > > tty =3D "/dev/pts/= 1" >> > > > > > > > port =3D "2" >> > > > > > > > ring-ref =3D "2334= 72" >> > > > > > > > vnc-listen =3D >> "127.0.0.1" >> > > > > > > > vnc-port =3D "5900= " >> > > > > > > > image =3D "" >> > > > > > > > device-model-pid = =3D >> "788" >> > > > > > > > vm =3D "" >> > > > > > > > >> d81ec5a9-5bf9-4f2b-89e8-0f60d6da948f =3D "" >> > > > > > > > name =3D "guest2" >> > > > > > > > uuid =3D >> "d81ec5a9-5bf9-4f2b-89e8-0f60d6da948f" >> > > > > > > > start_time =3D >> "1520600274.27" >> > > > > > > > libxl =3D "" >> > > > > > > > 1 =3D "" >> > > > > > > > device =3D "" >> > > > > > > > vbd =3D "" >> > > > > > > > 51712 =3D "" >> > > > > > > > frontend =3D >> "/local/domain/1/device/vbd/51712" >> > > > > > > > backend =3D >> "/local/domain/0/backend/vbd/1/51712" >> > > > > > > > params =3D >> "/home/root/guest2/xen-guest-image-minimal-raspberrypi4-64.ext3" >> > > > > > > > script =3D >> "/etc/xen/scripts/block" >> > > > > > > > frontend-id =3D "= 1" >> > > > > > > > online =3D "1" >> > > > > > > > removable =3D "0" >> > > > > > > > bootable =3D "1" >> > > > > > > > state =3D "1" >> > > > > > > > dev =3D "xvda" >> > > > > > > > type =3D "phy" >> > > > > > > > mode =3D "w" >> > > > > > > > device-type =3D >> "disk" >> > > > > > > > discard-enable = =3D >> "1" >> > > > > > > > vfb =3D "" >> > > > > > > > 0 =3D "" >> > > > > > > > frontend =3D >> "/local/domain/1/device/vfb/0" >> > > > > > > > backend =3D >> "/local/domain/0/backend/vfb/1/0" >> > > > > > > > frontend-id =3D "= 1" >> > > > > > > > online =3D "1" >> > > > > > > > state =3D "1" >> > > > > > > > vnc =3D "1" >> > > > > > > > vnclisten =3D >> "127.0.0.1" >> > > > > > > > vncdisplay =3D "0= " >> > > > > > > > vncunused =3D "1" >> > > > > > > > sdl =3D "0" >> > > > > > > > opengl =3D "0" >> > > > > > > > vkbd =3D "" >> > > > > > > > 0 =3D "" >> > > > > > > > frontend =3D >> "/local/domain/1/device/vkbd/0" >> > > > > > > > backend =3D >> "/local/domain/0/backend/vkbd/1/0" >> > > > > > > > frontend-id =3D "= 1" >> > > > > > > > online =3D "1" >> > > > > > > > state =3D "1" >> > > > > > > > console =3D "" >> > > > > > > > 0 =3D "" >> > > > > > > > frontend =3D >> "/local/domain/1/console" >> > > > > > > > backend =3D >> "/local/domain/0/backend/console/1/0" >> > > > > > > > frontend-id =3D "= 1" >> > > > > > > > online =3D "1" >> > > > > > > > state =3D "1" >> > > > > > > > protocol =3D "vt1= 00" >> > > > > > > > vif =3D "" >> > > > > > > > 0 =3D "" >> > > > > > > > frontend =3D >> "/local/domain/1/device/vif/0" >> > > > > > > > backend =3D >> "/local/domain/0/backend/vif/1/0" >> > > > > > > > frontend-id =3D "= 1" >> > > > > > > > online =3D "1" >> > > > > > > > state =3D "1" >> > > > > > > > script =3D >> "/etc/xen/scripts/vif-bridge" >> > > > > > > > mac =3D >> "e4:5f:01:cd:7b:dd" >> > > > > > > > bridge =3D "xenbr= 0" >> > > > > > > > handle =3D "0" >> > > > > > > > type =3D "vif" >> > > > > > > > hotplug-status = =3D "" >> > > > > > > > type =3D "pvh" >> > > > > > > > dm-version =3D >> "qemu_xen" >> > > > > > > > root@raspberrypi4-64 >> :~/guest1# >> > > > > > > > >> > > > > > > > Any input as per above= ? >> Looking forward to hearing from you. >> > > > > > > > >> > > > > > > > Regards, >> > > > > > > > Vipul Kumar >> > > > > > > > >> > > > > > > > On Wed, Oct 26, 2022 a= t >> 5:21 AM Stefano Stabellini wrote: >> > > > > > > > Hi Vipul, >> > > > > > > > >> > > > > > > > If you look at >> the QEMU logs, it says: >> > > > > > > > >> > > > > > > > VNC server >> running on 127.0.0.1:5900 >> > > > > > > > >> > > > > > > > That is the VNC >> server you need to connect to. So in theory: >> > > > > > > > >> > > > > > > > vncviewer >> 127.0.0.1:5900 >> > > > > > > > >> > > > > > > > should work >> correctly. >> > > > > > > > >> > > > > > > > >> > > > > > > > If you have: >> > > > > > > > >> > > > > > > > vfb =3D >> ["type=3Dvnc"] >> > > > > > > > >> > > > > > > > in your xl confi= g >> file and you have "fbdev" in your Linux guest, it >> > > > > > > > should work. >> > > > > > > > >> > > > > > > > If you connect t= o >> the VNC server but you get a black screen, it might be >> > > > > > > > a guest >> configuration issue. I would try with a simpler guest, text only >> > > > > > > > (no X11, no >> Wayland) and enable the fbdev console (fbcon). See >> > > > > > > > >> Documentation/fb/fbcon.rst in Linux. You should be able to see a >> > > > > > > > graphical consol= e >> over VNC. >> > > > > > > > >> > > > > > > > If that works, >> then you know that the fbdev kernel driver (xen-fbfront) >> > > > > > > > works correctly. >> > > > > > > > >> > > > > > > > If it doesn't >> work, the output of "xenstore-ls" would be interesting. >> > > > > > > > >> > > > > > > > Cheers, >> > > > > > > > >> > > > > > > > Stefano >> > > > > > > > >> > > > > > > > >> > > > > > > > On Wed, 19 Oct >> 2022, Vipul Suneja wrote: >> > > > > > > > > Hi Stefano, >> > > > > > > > > >> > > > > > > > > Thanks for the >> response! >> > > > > > > > > >> > > > > > > > > I am following >> the same link you shared from the beginning. Tried the command >> > > "vncviewer >> > > > localhost:0" >> > > > > in DOM0 >> > > > > > but >> > > > > > > same >> > > > > > > > issue "Can't ope= n >> > > > > > > > > display", belo= w >> are the logs: >> > > > > > > > > >> > > > > > > > > >> root@raspberrypi4-64:~# vncviewer localhost:0 >> > > > > > > > > >> > > > > > > > > TigerVNC Viewe= r >> 64-bit v1.11.0 >> > > > > > > > > Built on: >> 2020-09-08 12:16 >> > > > > > > > > Copyright (C) >> 1999-2020 TigerVNC Team and many others (see README.rst) >> > > > > > > > > See >> https://www.tigervnc.org for information on TigerVNC. >> > > > > > > > > Can't open >> display: >> > > > > > > > > >> > > > > > > > > Below are the >> netstat logs, i couldn't see anything running at port 5900 or >> > 5901: >> > > > > > > > > >> > > > > > > > > >> root@raspberrypi4-64:~# netstat -tuwx >> > > > > > > > > Active Interne= t >> connections (w/o servers) >> > > > > > > > > Proto Recv-Q >> Send-Q Local Address Foreign Address State >> > >> > > > > > > > > tcp 0 >> 164 192.168.1.39:ssh 192.168.1.38:37472 >> > ESTABLISHED >> > > > > > > > > Active UNIX >> domain sockets (w/o servers) >> > > > > > > > > Proto RefCnt >> Flags Type State I-Node Path >> > > > > > > > > unix 8 [ >> ] DGRAM CONNECTED 10565 /dev/log >> > > > > > > > > unix 3 [ >> ] STREAM CONNECTED 10891 >> > /var/run/xenstored/socket >> > > > > > > > > unix 3 [ >> ] STREAM CONNECTED 13791 >> > > > > > > > > unix 3 [ >> ] STREAM CONNECTED 10843 >> > /var/run/xenstored/socket >> > > > > > > > > unix 3 [ >> ] STREAM CONNECTED 10573 >> > /var/run/xenstored/socket >> > > > > > > > > unix 2 [ >> ] DGRAM CONNECTED 14510 >> > > > > > > > > unix 3 [ >> ] STREAM CONNECTED 13249 >> > > > > > > > > unix 2 [ >> ] DGRAM CONNECTED 13887 >> > > > > > > > > unix 2 [ >> ] DGRAM CONNECTED 10599 >> > > > > > > > > unix 3 [ >> ] STREAM CONNECTED 14005 >> > > > > > > > > unix 3 [ >> ] STREAM CONNECTED 13258 >> > > > > > > > > unix 3 [ >> ] STREAM CONNECTED 13248 >> > > > > > > > > unix 3 [ >> ] STREAM CONNECTED 14003 >> > > > > > > > > unix 3 [ >> ] STREAM CONNECTED 10572 >> > /var/run/xenstored/socket >> > > > > > > > > unix 3 [ >> ] STREAM CONNECTED 10786 >> > /var/run/xenstored/socket >> > > > > > > > > unix 3 [ >> ] DGRAM CONNECTED 13186 >> > > > > > > > > unix 3 [ >> ] STREAM CONNECTED 10864 >> > /var/run/xenstored/socket >> > > > > > > > > unix 3 [ >> ] STREAM CONNECTED 10812 >> > /var/run/xenstored/socket >> > > > > > > > > unix 2 [ >> ] DGRAM CONNECTED 14083 >> > > > > > > > > unix 3 [ >> ] STREAM CONNECTED 10813 >> > /var/run/xenstored/socket >> > > > > > > > > unix 3 [ >> ] STREAM CONNECTED 14068 >> > > > > > > > > unix 3 [ >> ] STREAM CONNECTED 13256 >> > > > > > > > > unix 3 [ >> ] STREAM CONNECTED 10571 >> > /var/run/xenstored/socket >> > > > > > > > > unix 3 [ >> ] STREAM CONNECTED 10842 >> > > > > > > > > unix 3 [ >> ] STREAM CONNECTED 13985 >> > > > > > > > > unix 3 [ >> ] DGRAM CONNECTED 13185 >> > > > > > > > > unix 2 [ >> ] STREAM CONNECTED 13884 >> > > > > > > > > unix 2 [ >> ] DGRAM CONNECTED 14528 >> > > > > > > > > unix 2 [ >> ] DGRAM CONNECTED 13785 >> > > > > > > > > unix 3 [ >> ] STREAM CONNECTED 14034 >> > > > > > > > > >> > > > > > > > > Attaching xen >> log files of /var/log/xen. >> > > > > > > > > I didn't get >> the role of QEMU here because as mentioned earlier, I am porting >> > in >> > > raspberrypi >> > > > 4B. >> > > > > > > > > >> > > > > > > > > Regards, >> > > > > > > > > Vipul Kumar >> > > > > > > > > >> > > > > > > > > On Wed, Oct 19= , >> 2022 at 12:43 AM Stefano Stabellini >> > wrote: >> > > > > > > > > It >> usually works the way it is described in the guide: >> > > > > > > > > >> > > > > > > > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > >> > >> https://www.virtuatopia.com/index.php?title=3DConfiguring_a_VNC_based_Gr= aphical_Console_for_a_Xen_Paravirtualized_domainU_Guest >> > > > > > > > > >> > > > > > > > > You don'= t >> need to install any VNC-related server software because it is >> > > > > > > > > already >> provided by Xen (to be precise it is provided by QEMU working >> > > > > > > > > together >> with Xen.) >> > > > > > > > > >> > > > > > > > > You only >> need the vnc client in dom0 so that you can connect, but you >> > > > > > > > > could >> also run the vnc client outside from another host. So basically >> > > > > > > > > the >> following should work when executed in Dom0 after creating DomU: >> > > > > > > > > >> > > > > > > > > >> vncviewer localhost:0 >> > > > > > > > > >> > > > > > > > > Can you >> attach the Xen and QEMU logs (/var/log/xen/*)? And also use >> > > > > > > > > netstat >> -taunp to check if there is anything running at port 5900 or >> > > > > > > > > 5901? >> > > > > > > > > >> > > > > > > > > Cheers, >> > > > > > > > > >> > > > > > > > > Stefano >> > > > > > > > > >> > > > > > > > > >> > > > > > > > > On Tue, >> 18 Oct 2022, Vipul Suneja wrote: >> > > > > > > > > > Hi >> Stefano, >> > > > > > > > > > >> > > > > > > > > > Thanks >> for the response! >> > > > > > > > > > >> > > > > > > > > > I coul= d >> install tigerVNC, x11vnc & libvncserver in Dom0 >> > xen-image-minimal but >> > > only >> > > > manage to >> > > > > install >> > > > > > > > >> libvncserver(couldn't >> > > > > > > > > install >> tigervnc >> > > > > > > > > > & >> x11vnc because of x11 >> > > > > > > > > > suppor= t >> missing, it's wayland) in DOMU custom graphical image. I >> > tried >> > > running >> > > > vncviewer with >> > > > > IP >> > > > > > address & >> > > > > > > port >> > > > > > > > in dom0 to >> > > > > > > > > access >> the domu >> > > > > > > > > > >> graphical image display as per below commands. >> > > > > > > > > > >> > > > > > > > > > >> vncviewer 192.168.1.42:5901 >> > > > > > > > > > >> > > > > > > > > > But i= t >> showing can't open display, below are the logs: >> > > > > > > > > > >> > > > > > > > > > >> root@raspberrypi4-64:~/guest1# vncviewer 192.168.1.42:5901 >> > > > > > > > > > >> > > > > > > > > > >> TigerVNC Viewer 64-bit v1.11.0 >> > > > > > > > > > Built >> on: 2020-09-08 12:16 >> > > > > > > > > > >> Copyright (C) 1999-2020 TigerVNC Team and many others (see >> > README.rst) >> > > > > > > > > > See >> https://www.tigervnc.org for information on TigerVNC. >> > > > > > > > > > Can't >> open display: >> > > > > > > > > > >> root@raspberrypi4-64:~/guest1# >> > > > > > > > > > >> > > > > > > > > > I am >> not exactly sure what the issue is but I thought only >> > libvncserver in >> > > DOMU could >> > > > work to >> > > > > get >> > > > > > access but >> > > > > > > it >> > > > > > > > did not >> > > > > > > > > work. >> > > > > > > > > > If >> TigerVNC is the issue here then is there any other VNC source >> > which could >> > > be >> > > > installed for >> > > > > both >> > > > > > x11 & >> > > > > > > > wayland supporte= d >> > > > > > > > > images? >> > > > > > > > > > >> > > > > > > > > > Regard= s, >> > > > > > > > > > Vipul >> Kumar >> > > > > > > > > > >> > > > > > > > > > On Tue= , >> Oct 18, 2022 at 2:40 AM Stefano Stabellini >> > >> > > wrote: >> > > > > > > > > > >> VNC is typically easier to setup, because SDL needs extra >> > libraries at >> > > > > > > > > > >> build time and runtime. If QEMU is built without SDL support it >> > won't >> > > > > > > > > > >> start when you ask for SDL. >> > > > > > > > > > >> > > > > > > > > > >> VNC should work with both x11 and wayland in your domU. It >> > doesn't work >> > > > > > > > > > >> at the x11 level, it exposes a special fbdev device in your >> > domU that >> > > > > > > > > > >> should work with: >> > > > > > > > > > = - >> a graphical console in Linux domU >> > > > > > > > > > = - >> x11 >> > > > > > > > > > = - >> wayland (but I haven't tested this so I am not 100% sure >> > about it) >> > > > > > > > > > >> > > > > > > > > > >> When you say "it doesn't work", what do you mean? Do you get a >> > black >> > > > > > > > > > >> window? >> > > > > > > > > > >> > > > > > > > > > >> You need CONFIG_XEN_FBDEV_FRONTEND in Linux domU >> > > > > > > > > > >> (drivers/video/fbdev/xen-fbfront.c). I would try to get a >> > graphical >> > > text >> > > > > > > > > > >> console up and running in your domU before attempting >> > x11/wayland. >> > > > > > > > > > >> > > > > > > > > > >> Cheers, >> > > > > > > > > > >> > > > > > > > > > >> Stefano >> > > > > > > > > > >> > > > > > > > > > >> On Mon, 17 Oct 2022, Vipul Suneja wrote: >> > > > > > > > > > = > >> Hi, >> > > > > > > > > > = > >> Thanks! >> > > > > > > > > > = > >> > > > > > > > > > = > >> I have ported xen minimal image as DOM0 & custom wayland GUI >> > based >> > > image as >> > > > DOMU in >> > > > > raspberry >> > > > > > pi4B. I >> > > > > > > > am trying to >> > > > > > > > > make GUI >> > > > > > > > > > >> display up >> > > > > > > > > > = > >> for guest machine. I tried using sdl, included below line in >> > > guest.conf file >> > > > > > > > > > = > >> vfb=3D [ 'sdl=3D1' ] >> > > > > > > > > > = > >> > > > > > > > > > = > >> But it is throwing below error: >> > > > > > > > > > = > >> > > > > > > > > > = > >> root@raspberrypi4-64:~/guest1# xl create -c guest1.cfg >> > > > > > > > > > = > >> Parsing config from guest1.cfg >> > > > > > > > > > = > >> libxl: error: libxl_qmp.c:1400:qmp_ev_fd_callback: Domain >> > 3:error on >> > > QMP >> > > > socket: >> > > > > Connection >> > > > > > reset by >> > > > > > > > peer >> > > > > > > > > > = > >> libxl: error: libxl_qmp.c:1439:qmp_ev_fd_callback: Domain >> > 3:Error >> > > happened >> > > > with the >> > > > > QMP >> > > > > > connection to >> > > > > > > > QEMU >> > > > > > > > > > = > >> libxl: error: libxl_dm.c:3351:device_model_postconfig_done: >> > Domain >> > > 3:Post DM >> > > > startup >> > > > > configs >> > > > > > failed, >> > > > > > > > rc=3D-26 >> > > > > > > > > > = > >> libxl: error: libxl_create.c:1867:domcreate_devmodel_started: >> > Domain >> > > 3:device >> > > > model >> > > > > did not >> > > > > > start: >> > > > > > > -26 >> > > > > > > > > > = > >> libxl: error: libxl_aoutils.c:646:libxl__kill_xs_path: Device >> > Model >> > > already >> > > > exited >> > > > > > > > > > = > >> libxl: error: libxl_domain.c:1183:libxl__destroy_domid: >> > Domain >> > > 3:Non-existant >> > > > domain >> > > > > > > > > > = > >> libxl: error: libxl_domain.c:1137:domain_destroy_callback: >> > Domain >> > > 3:Unable to >> > > > destroy >> > > > > guest >> > > > > > > > > > = > >> libxl: error: libxl_domain.c:1064:domain_destroy_cb: Domain >> > > 3:Destruction of >> > > > domain >> > > > > failed >> > > > > > > > > > = > >> > > > > > > > > > = > >> Another way is VNC, i could install tigervnc in DOM0 but same >> > i >> > > couldn't in >> > > > guest >> > > > > machine >> > > > > > because it >> > > > > > > > doesn't support >> > > > > > > > > > >> x11(supports wayland >> > > > > > > > > > = > >> only). I am completely blocked here, Need your support to >> > enable the >> > > display >> > > > up. >> > > > > > > > > > = > >> Any alternative of VNC which could work in both x11 & wayland >> > > supported >> > > > images? >> > > > > > > > > > = > >> > > > > > > > > > = > >> Any input on VNC, SDL or any other way to proceed on this? >> > Looking >> > > forward to >> > > > hearing >> > > > > from >> > > > > > you. >> > > > > > > > > > = > >> > > > > > > > > > = > >> Regards, >> > > > > > > > > > = > >> Vipul Kumar >> > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > >> > > > > > > > > >> > > > > > > > > >> > > > > > > > >> > > > > > > > >> > > > > > > > >> > > > > > > >> > > > > > > >> > > > > > > >> > > > > > >> > > > > > >> > > > > > >> > > > > >> > > > > >> > > > > >> > > > >> > > > >> > > > >> > > >> > > >> > > >> > >> > >> > > > --00000000000067bdb605f1e1bbce Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: base64 PGRpdiBkaXI9Imx0ciI+SGkgU3RlZmFubyw8ZGl2Pjxicj48L2Rpdj48ZGl2PlRoYW5rcyE8L2Rp dj48ZGl2Pjxicj48L2Rpdj48ZGl2PkFueSBpbnB1dCBmdXJ0aGVyIGFzIHBlciB0aGUgbG9ncyBh dHRhY2hlZD88L2Rpdj48ZGl2Pjxicj48L2Rpdj48ZGl2PlJlZ2FyZHMsPC9kaXY+PGRpdj5WaXB1 bCBLdW1hcjwvZGl2PjwvZGl2Pjxicj48ZGl2IGNsYXNzPSJnbWFpbF9xdW90ZSI+PGRpdiBkaXI9 Imx0ciIgY2xhc3M9ImdtYWlsX2F0dHIiPk9uIE1vbiwgRGVjIDI2LCAyMDIyIGF0IDExOjMwIFBN IFZpcHVsIFN1bmVqYSAmbHQ7PGEgaHJlZj0ibWFpbHRvOnZzdW5lamE2M0BnbWFpbC5jb20iPnZz dW5lamE2M0BnbWFpbC5jb208L2E+Jmd0OyB3cm90ZTo8YnI+PC9kaXY+PGJsb2NrcXVvdGUgY2xh c3M9ImdtYWlsX3F1b3RlIiBzdHlsZT0ibWFyZ2luOjBweCAwcHggMHB4IDAuOGV4O2JvcmRlci1s ZWZ0OjFweCBzb2xpZCByZ2IoMjA0LDIwNCwyMDQpO3BhZGRpbmctbGVmdDoxZXgiPjxkaXYgZGly PSJsdHIiPkhpIFN0ZWZhbm8sPGJyPjxicj5UaGFua3MhPGJyPjxicj5BcyB5b3UgaGF2ZSBtZW50 aW9uIGZ1bmN0aW9uIGNhbGwgcWVtdV9jcmVhdGVfZGlzcGxheXN1cmZhY2UsIHFlbXVfY3JlYXRl X2Rpc3BsYXlzdXJmYWNlX2Zyb20sIGRweV9nZnhfcmVwbGFjZV9zdXJmYWNlLCBkcHlfZ2Z4X3Vw ZGF0ZSBhbmQgZHB5X2dmeF9jaGVja19mb3JtYXQsIGkgZm91bmQgdGhhdCA8YnI+dGhlc2UgZnVu Y3Rpb25zIGFyZSBub3QgcGFydCBvZiAvdWkvdm5jLmMgc291cmNlIGJ1dCB0aGV5IGFyZSBkZWZp bmVkIGluIC91aS9jb25zb2xlLmMgc291cmNlLiBFdmVuIG5vbmUgb2YgdGhlc2UgZnVuY3Rpb25z IGhhdmUgYmVlbiBjYWxsZWQgZnJvbSB0aGUgdm5jLmMgc291cmNlLiBJIGhhdmUgaW5jbHVkZWQg ZGVidWcgbG9ncyBmb3IgPGJyPmFsbCBvZiB0aGVzZSBmdW5jdGlvbnMgaW4gY29uc29sZS5jIGJ1 dCBjb3VsZCBzZWUgaW4gdGhlIGxvZ3MgdGhhdCBvbmx5IHFlbXVfY3JlYXRlX2Rpc3BsYXlzdXJm YWNlICZhbXA7wqANCg0KZHB5X2dmeF9yZXBsYWNlX3N1cmZhY2XCoGZ1bmN0aW9ucyBhcmUgaW52 b2tlZC4gRXZlbiBpIHRyaWVkIHZuY3ZpZXdlcjxicj5vbiB0aGUgaG9zdCBtYWNoaW5lIGJ1dCBv dGhlciBmdW5jdGlvbnMgYXJlIG5vdCBpbnZva2VkLiBBdHRhY2hpbmcgdGhlIGxvZyBmaWxlLCBh bnkgb3RoZXIgc3VnZ2VzdGlvbiBhcyBwZXIgbG9nIGZpbGUgb3IgYW55IGlucHV0IGZvciBkZWJ1 Z2dpbmcgdm5jIHNvdXJjZSBmaWxlLjxkaXY+wqA8L2Rpdj48ZGl2PjxiPjxpPllvdSBjYW4gYWxz byB0cnkgdG8gdXNlIGFub3RoZXIgUUVNVSBVSSBsaWtlIFNETCB0byBzZWUgaWYgdGhlIHByb2Js ZW0gaXMgc3BlY2lmaWMgdG8gVk5DIG9ubHkuPC9pPjwvYj48L2Rpdj48ZGl2PkkgYWxyZWFkeSB0 cmllZCB3aXRoIFNETCwgYnkgYWRkaW5nICZxdW90O3ZmYj1bICYjMzk7dHlwZT1zZGwmIzM5OyBd JnF1b3Q7IGluIHRoZSBndWVzdCBjb25maWd1cmF0aW9uIGZpbGUgYnV0IGl0IGZhaWxlZCAmYW1w OyBkaWRuJiMzOTt0IHN0YXJ0IHRoZSBndWVzdMKgbWFjaGluZS4gQ29ycmVjdCBtZSBpZiBJIGFt IHdyb25nIHdpdGggY29uZmlndXJhdGlvbiBvciBzdGVwcyB0byB1c2UgU0RMPzwvZGl2PjxkaXY+ PGJyPlRoYW5rcyAmYW1wOyBSZWdhcmRzLDxicj5WaXB1bCBLdW1hcjxicj48L2Rpdj48L2Rpdj48 YnI+PGRpdiBjbGFzcz0iZ21haWxfcXVvdGUiPjxkaXYgZGlyPSJsdHIiIGNsYXNzPSJnbWFpbF9h dHRyIj5PbiBGcmksIERlYyAyMywgMjAyMiBhdCA1OjEzIEFNIFN0ZWZhbm8gU3RhYmVsbGluaSAm bHQ7PGEgaHJlZj0ibWFpbHRvOnNzdGFiZWxsaW5pQGtlcm5lbC5vcmciIHRhcmdldD0iX2JsYW5r Ij5zc3RhYmVsbGluaUBrZXJuZWwub3JnPC9hPiZndDsgd3JvdGU6PGJyPjwvZGl2PjxibG9ja3F1 b3RlIGNsYXNzPSJnbWFpbF9xdW90ZSIgc3R5bGU9Im1hcmdpbjowcHggMHB4IDBweCAwLjhleDti b3JkZXItbGVmdDoxcHggc29saWQgcmdiKDIwNCwyMDQsMjA0KTtwYWRkaW5nLWxlZnQ6MWV4Ij5I aSBWaXB1bCw8YnI+DQo8YnI+DQpHcmVhdCB0aGF0IHlvdSBtYW5hZ2VkIHRvIHNldHVwIGEgZGVi dWdnaW5nIGVudmlyb25tZW50LiBUaGUgbG9ncyBsb29rPGJyPg0KdmVyeSBwcm9taXNpbmc6IGl0 IGxvb2tzIGxpa2UgeGVuZmIuYyBpcyBoYW5kbGluZyBldmVudHMgYXMgZXhwZWN0ZWQuPGJyPg0K U28gaXQgd291bGQgYXBwYXJlbnRseSBzZWVtIHRoYXQgeGVuLWZiZnJvbnQuYyAtJmd0OyB4ZW5m Yi5jIGNvbm5lY3Rpb24gaXM8YnI+DQp3b3JraW5nLjxicj4NCjxicj4NClNvIHRoZSBuZXh0IHN0 ZXAgaXMgdGhlIHhlbmZiLmMgLSZndDsgLi91aS92bmMuYyBpcyB3b3JraW5nLjxicj4NCjxicj4N Ckl0IGNvdWxkIGJlIHRoYXQgdGhlIHBpeGVscyBhbmQgbW91c2UgZXZlbnRzIGFycml2ZSBqdXN0 IGZpbmUgaW48YnI+DQp4ZW5mYi5jLCBidXQgdGhlbiB0aGVyZSBpcyBhbiBpc3N1ZSB3aXRoIGV4 cG9ydGluZyB0aGVtIHRvIHRoZSB2bmNzZXJ2ZXI8YnI+DQppbXBsZW1lbnRhdGlvbiBpbnNpZGUg UUVNVSwgd2hpY2ggaXMgLi91aS92bmMuYy4gVGhlIGludGVyZXN0aW5nPGJyPg0KZnVuY3Rpb25z IHRoZXJlIGFyZSBxZW11X2NyZWF0ZV9kaXNwbGF5c3VyZmFjZSw8YnI+DQpxZW11X2NyZWF0ZV9k aXNwbGF5c3VyZmFjZV9mcm9tLCBkcHlfZ2Z4X3JlcGxhY2Vfc3VyZmFjZSw8YnI+DQpkcHlfZ2Z4 X3VwZGF0ZSwgYW5kIGRweV9nZnhfY2hlY2tfZm9ybWF0Ljxicj4NCjxicj4NClNwZWNpZmljYWxs eSBkcHlfZ2Z4X3VwZGF0ZSBzaG91bGQgY2F1c2UgVk5DIHRvIHJlbmRlciB0aGUgbmV3IGFyZWEu PGJyPg0KPGJyPg0KcWVtdV9jcmVhdGVfZGlzcGxheXN1cmZhY2VfZnJvbSBsZXQgVk5DIHVzZSB0 aGUgeGVuZmIgYnVmZmVyIGRpcmVjdGx5PGJyPg0Kd2l0aCBWTkMsIHJhdGhlciB0aGFuIHVzaW5n IGEgc2Vjb25kYXJ5IGJ1ZmZlciBhbmQgbWVtb3J5IGNvcGllcy48YnI+DQpJbnRlcmVzdGluZ2x5 LCBkcHlfZ2Z4X2NoZWNrX2Zvcm1hdCBzaG91bGQgYmUgdXNlZCB0byBjaGVjayBpZiBpdCBpczxi cj4NCmFwcHJvcHJpYXRlIHRvIHNoYXJlIHRoZSBidWZmZXIgKHFlbXVfY3JlYXRlX2Rpc3BsYXlz dXJmYWNlX2Zyb20pIG9yIG5vdDxicj4NCihxZW11X2NyZWF0ZV9kaXNwbGF5c3VyZmFjZSkgYnV0 IHdlIGRvbiYjMzk7dCBjYWxsIGl0Ljxicj4NCjxicj4NCkkgdGhpbmsgaXQgd291bGQgYmUgZ29v ZCB0byBhZGQgYSBjYWxsIHRvIGRweV9nZnhfY2hlY2tfZm9ybWF0IGluPGJyPg0KeGVuZmJfdXBk YXRlIHdoZXJlIHdlIGNhbGwgcWVtdV9jcmVhdGVfZGlzcGxheXN1cmZhY2VfZnJvbSBhbmQgYWxz byBhZGQ8YnI+DQphIHByaW50ay48YnI+DQo8YnI+DQpZb3UgY2FuIHRyeSB0byBkaXNhYmxlIHRo ZSBidWZmZXIgc2hhcmluZyBieSByZXBsYWNpbmc8YnI+DQpxZW11X2NyZWF0ZV9kaXNwbGF5c3Vy ZmFjZV9mcm9tIHdpdGggcWVtdV9jcmVhdGVfZGlzcGxheXN1cmZhY2UuIFlvdSBjYW48YnI+DQph bHNvIHRyeSB0byB1c2UgYW5vdGhlciBRRU1VIFVJIGxpa2UgU0RMIHRvIHNlZSBpZiB0aGUgcHJv YmxlbSBpczxicj4NCnNwZWNpZmljIHRvIFZOQyBvbmx5Ljxicj4NCjxicj4NCkNoZWVycyw8YnI+ DQo8YnI+DQpTdGVmYW5vPGJyPg0KPGJyPg0KPGJyPg0KT24gTW9uLCAxOSBEZWMgMjAyMiwgVmlw dWwgU3VuZWphIHdyb3RlOjxicj4NCiZndDsgSGkgU3RlZmFubyw8YnI+DQomZ3Q7IDxicj4NCiZn dDsgVGhhbmtzITxicj4NCiZndDsgPGJyPg0KJmd0OyBJIGNvdWxkIHByZXBhcmUgYSBwYXRjaCBm b3IgYWRkaW5nIGRlYnVnIHByaW50ZiBsb2dzIGluIHhlbmZiLmMgJmFtcDsgcmUtY29tcGlsZSBR RU1VIGluIHlvY3RvIGltYWdlLiBKdXN0IGZvciByZWZlcmVuY2UsIEkgaGF2ZSBpbmNsdWRlZCBs b2dzPGJyPg0KJmd0OyBpbiBhbGwgdGhlIGZ1bmN0aW9ucy48YnI+DQomZ3Q7IEF0dGFjaGluZyBx ZW11IGxvZyBmaWxlLCBjb3VsZCBzZWUgdGhlIGVudHJ5ICZhbXA7IGV4aXQgbG9ncyBjb21pbmcg dXAgZm9yICZxdW90O3hlbmZiX2hhbmRsZV9ldmVudHMmcXVvdDsgJmFtcDsgJnF1b3Q7eGVuZmJf bWFwX2ZiJnF1b3Q7IGFsc28gYWZ0ZXIgdGhlIGhvc3TCoG1hY2hpbmU8YnI+DQomZ3Q7IGJvb3Rz wqB1cC4gQ2FuIHlvdcKgcGxlYXNlIGZ1cnRoZXIgYXNzaXN0LCB3aGljaCBwYXJhbWV0ZXJzIGhh cyB0byBiZSBjcm9zcyBjaGVja2VkIG9yIGFueSBvdGhlciBpbnB1dCBhcyBwZXIgbG9ncz/CoMKg PGJyPg0KJmd0OyA8YnI+DQomZ3Q7IFRoYW5rcyAmYW1wOyBSZWdhcmRzLDxicj4NCiZndDsgVmlw dWwgS3VtYXI8YnI+DQomZ3Q7IDxicj4NCiZndDsgT24gVGh1LCBEZWMgMTUsIDIwMjIgYXQgNDox NyBBTSBTdGVmYW5vIFN0YWJlbGxpbmkgJmx0OzxhIGhyZWY9Im1haWx0bzpzc3RhYmVsbGluaUBr ZXJuZWwub3JnIiB0YXJnZXQ9Il9ibGFuayI+c3N0YWJlbGxpbmlAa2VybmVsLm9yZzwvYT4mZ3Q7 IHdyb3RlOjxicj4NCiZndDvCoCDCoCDCoCDCoEhpIFZpcHVsLDxicj4NCiZndDsgPGJyPg0KJmd0 O8KgIMKgIMKgIMKgRm9yIFFFTVUgeW91IGFjdHVhbGx5IG5lZWQgdG8gZm9sbG93IHRoZSBZb2N0 byBidWlsZCBwcm9jZXNzIHRvIHVwZGF0ZTxicj4NCiZndDvCoCDCoCDCoCDCoHRoZSBRRU1VIGJp bmFyeS4gVGhhdCBpcyBiZWNhdXNlIFFFTVUgaXMgYSB1c2Vyc3BhY2UgYXBwbGljYXRpb24gd2l0 aDxicj4NCiZndDvCoCDCoCDCoCDCoGxvdHMgb2YgbGlicmFyeSBkZXBlbmRlbmNpZXMgc28gd2Ug Y2Fubm90IGp1c3QgZG8gJnF1b3Q7bWFrZSZxdW90OyB3aXRoIGE8YnI+DQomZ3Q7wqAgwqAgwqAg wqBjcm9zcy1jb21waWxlciBsaWtlIGluIHRoZSBjYXNlIG9mIFhlbi48YnI+DQomZ3Q7IDxicj4N CiZndDvCoCDCoCDCoCDCoFNvIHlvdSBuZWVkIHRvIG1ha2UgY2hhbmdlcyB0byBRRU1VIGFuZCB0 aGVuIGFkZCB0aG9zZSBjaGFuZ2VzIGFzIGE8YnI+DQomZ3Q7wqAgwqAgwqAgwqBwYXRjaCB0byB0 aGUgWW9jdG8gUUVNVSBidWlsZCByZWNpcGUsIG9yIGNvbmZpZ3VyZSBZb2N0byB0byB5b3VyIGxv Y2FsPGJyPg0KJmd0O8KgIMKgIMKgIMKgdHJlZSB0byBidWlsZCBRRU1VLiBJIGFtIG5vdCBhIFlv Y3RvIGV4cGVydCBhbmQgdGhlIFlvY3RvIGNvbW11bml0eTxicj4NCiZndDvCoCDCoCDCoCDCoHdv dWxkIGJlIGEgYmV0dGVyIHBsYWNlIHRvIGFzayBmb3IgYWR2aWNlIHRoZXJlLiBZb3UgY2FuIHNl ZSBmcm9tIGhlcmU8YnI+DQomZ3Q7wqAgwqAgwqAgwqBzb21lIGluc3RydWN0aW9ucyBvbiBob3cg dG8gYnVpbGQgWGVuIHVzaW5nIGEgbG9jYWwgdHJlZSwgc2VlIHRoZSB1c2FnZTxicj4NCiZndDvC oCDCoCDCoCDCoG9mIEVYVEVSTkFMU1JDIChub3RlIHRoYXQgdGhpcyBpcyAqbm90KiB3aGF0IHlv dSBuZWVkOiB5b3UgbmVlZCB0byBidWlsZDxicj4NCiZndDvCoCDCoCDCoCDCoFFFTVUgd2l0aCBh IGxvY2FsIHRyZWUsIG5vdCBYZW4uIEJ1dCBJIHRob3VnaHQgdGhhdCB0aGUgd2lraXBhZ2UgbWln aHQ8YnI+DQomZ3Q7wqAgwqAgwqAgwqBzdGlsbCBiZSBhIHN0YXJ0aW5nIHBvaW50KTxicj4NCiZn dDsgPGJyPg0KJmd0O8KgIMKgIMKgIMKgPGEgaHJlZj0iaHR0cHM6Ly93aWtpLnhlbnByb2plY3Qu b3JnL3dpa2kvWGVuX29uX0FSTV9hbmRfWW9jdG8iIHJlbD0ibm9yZWZlcnJlciIgdGFyZ2V0PSJf YmxhbmsiPmh0dHBzOi8vd2lraS54ZW5wcm9qZWN0Lm9yZy93aWtpL1hlbl9vbl9BUk1fYW5kX1lv Y3RvPC9hPjxicj4NCiZndDsgPGJyPg0KJmd0O8KgIMKgIMKgIMKgQ2hlZXJzLDxicj4NCiZndDsg PGJyPg0KJmd0O8KgIMKgIMKgIMKgU3RlZmFubzxicj4NCiZndDsgPGJyPg0KJmd0OyA8YnI+DQom Z3Q7wqAgwqAgwqAgwqBPbiBUaHUsIDE1IERlYyAyMDIyLCBWaXB1bCBTdW5lamEgd3JvdGU6PGJy Pg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBIaSBTdGVmYW5vLDxicj4NCiZndDvCoCDCoCDCoCDCoCZn dDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFRoYW5rcyE8YnI+DQomZ3Q7wqAgwqAgwqAgwqAm Z3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBJIGNvdWxkIHNlZSBRRU1VIDYuMi4wIGNvbXBp bGVkICZhbXA7IGluc3RhbGxlZCBpbiB0aGUgaG9zdCBpbWFnZSB4ZW4taW1hZ2UtbWluaW1hbC4g SSBjb3VsZCBmaW5kIHhlbmZiLmMgc291cmNlIGZpbGUgYWxzbyAmYW1wOzxicj4NCiZndDvCoCDC oCDCoCDCoG1vZGlmaWVkIHRoZSBzYW1lPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyB3aXRoIGRl YnVnIGxvZ3MuPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBJIGhhdmUgc2V0IHVwIGEgY3Jvc3Mg Y29tcGlsZSBlbnZpcm9ubWVudCwgZGlkICYjMzk7bWFrZSBjbGVhbiYjMzk7ICZhbXA7ICYjMzk7 bWFrZSBhbGwmIzM5OyB0byByZWNvbXBpbGUgYnV0IGl0JiMzOTtzIGZhaWxpbmcuIEluIGNhc2Ug aSBhbSBkb2luZzxicj4NCiZndDvCoCDCoCDCoCDCoHdyb25nLCBDYW4geW91PGJyPg0KJmd0O8Kg IMKgIMKgIMKgJmd0OyBwbGVhc2UgYXNzaXN0IG1lPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyB3 aXRoIHRoZSBjb3JyZWN0IHN0ZXBzIHRvIGNvbXBpbGUgcWVtdT/CoEJlbG93IGFyZSB0aGUgZXJy b3IgbG9nczo8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0 Ozxicj4NCiZndDvCoCDCoCDCoCDCoGFnbEBhZ2wtT3B0aVBsZXgtNzAxMDp+L0F1dG9tb3RpdmUv QURBU19JbmZvdGFpbm1lbnQvUGxhdGZvcm0vUG9reV9LaXJrc3RvbmUvYnVpbGQvdG1wL3dvcmsv Y29ydGV4YTcyLXBva3ktbGludXgvcWVtdS82LjIuMC1yMC9idWlsZCQ8YnI+DQomZ3Q7wqAgwqAg wqAgwqBtYWtlPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBhbGw8YnI+DQomZ3Q7wqAgwqAgwqAg wqAmZ3Q7IFsxLzM4NjRdIENvbXBpbGluZyBDIG9iamVjdCBsaWJzbGlycC5hLnAvc2xpcnBfc3Jj X2FycF90YWJsZS5jLm88YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsyLzM4NjRdIENvbXBpbGlu ZyBDIG9iamVjdCBzdWJwcm9qZWN0cy9saWJ2aG9zdC11c2VyL2xpYnZob3N0LXVzZXIuYS5wL2xp YnZob3N0LXVzZXIuYy5vPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbMy8zODY0XSBMaW5raW5n IHN0YXRpYyB0YXJnZXQgc3VicHJvamVjdHMvbGlidmhvc3QtdXNlci9saWJ2aG9zdC11c2VyLmE8 YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFs0LzM4NjRdIENvbXBpbGluZyBDIG9iamVjdCBsaWJz bGlycC5hLnAvc2xpcnBfc3JjX3Ztc3RhdGUuYy5vPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBb NS8zODY0XSBDb21waWxpbmcgQyBvYmplY3QgbGlic2xpcnAuYS5wL3NsaXJwX3NyY19kaGNwdjYu Yy5vPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbNi8zODY0XSBDb21waWxpbmcgQyBvYmplY3Qg bGlic2xpcnAuYS5wL3NsaXJwX3NyY19kbnNzZWFyY2guYy5vPGJyPg0KJmd0O8KgIMKgIMKgIMKg Jmd0OyBbNy8zODY0XSBDb21waWxpbmcgQyBvYmplY3QgbGlic2xpcnAuYS5wL3NsaXJwX3NyY19i b290cC5jLm88YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFs4LzM4NjRdIENvbXBpbGluZyBDIG9i amVjdCBsaWJzbGlycC5hLnAvc2xpcnBfc3JjX2Nrc3VtLmMubzxicj4NCiZndDvCoCDCoCDCoCDC oCZndDsgWzkvMzg2NF0gQ29tcGlsaW5nIEMgb2JqZWN0IGxpYnNsaXJwLmEucC9zbGlycF9zcmNf aWYuYy5vPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbMTAvMzg2NF0gQ29tcGlsaW5nIEMgb2Jq ZWN0IGxpYnNsaXJwLmEucC9zbGlycF9zcmNfaXA2X2ljbXAuYy5vPGJyPg0KJmd0O8KgIMKgIMKg IMKgJmd0OyBbMTEvMzg2NF0gQ29tcGlsaW5nIEMgb2JqZWN0IGxpYnNsaXJwLmEucC9zbGlycF9z cmNfaXA2X2lucHV0LmMubzxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWzEyLzM4NjRdIENvbXBp bGluZyBDIG9iamVjdCBsaWJzbGlycC5hLnAvc2xpcnBfc3JjX2lwNl9vdXRwdXQuYy5vPGJyPg0K Jmd0O8KgIMKgIMKgIMKgJmd0OyBbMTMvMzg2NF0gQ29tcGlsaW5nIEMgb2JqZWN0IGxpYnNsaXJw LmEucC9zbGlycF9zcmNfaXBfaWNtcC5jLm88YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsxNC8z ODY0XSBDb21waWxpbmcgQyBvYmplY3QgbGlic2xpcnAuYS5wL3NsaXJwX3NyY19pcF9pbnB1dC5j Lm88YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsxNS8zODY0XSBDb21waWxpbmcgQyBvYmplY3Qg bGlic2xpcnAuYS5wL3NsaXJwX3NyY19pcF9vdXRwdXQuYy5vPGJyPg0KJmd0O8KgIMKgIMKgIMKg Jmd0OyBbMTYvMzg2NF0gQ29tcGlsaW5nIEMgb2JqZWN0IGxpYnNsaXJwLmEucC9zbGlycF9zcmNf bWJ1Zi5jLm88YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsxNy8zODY0XSBDb21waWxpbmcgQyBv YmplY3QgbGlic2xpcnAuYS5wL3NsaXJwX3NyY19taXNjLmMubzxicj4NCiZndDvCoCDCoCDCoCDC oCZndDsgWzE4LzM4NjRdIENvbXBpbGluZyBDIG9iamVjdCBsaWJzbGlycC5hLnAvc2xpcnBfc3Jj X25jc2kuYy5vPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbMTkvMzg2NF0gQ29tcGlsaW5nIEMg b2JqZWN0IGxpYnNsaXJwLmEucC9zbGlycF9zcmNfbmRwX3RhYmxlLmMubzxicj4NCiZndDvCoCDC oCDCoCDCoCZndDsgWzIwLzM4NjRdIENvbXBpbGluZyBDIG9iamVjdCBsaWJzbGlycC5hLnAvc2xp cnBfc3JjX3NidWYuYy5vPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbMjEvMzg2NF0gQ29tcGls aW5nIEMgb2JqZWN0IGxpYnNsaXJwLmEucC9zbGlycF9zcmNfc2xpcnAuYy5vPGJyPg0KJmd0O8Kg IMKgIMKgIMKgJmd0OyBbMjIvMzg2NF0gQ29tcGlsaW5nIEMgb2JqZWN0IGxpYnNsaXJwLmEucC9z bGlycF9zcmNfc29ja2V0LmMubzxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgWzIzLzM4NjRdIENv bXBpbGluZyBDIG9iamVjdCBsaWJzbGlycC5hLnAvc2xpcnBfc3JjX3N0YXRlLmMubzxicj4NCiZn dDvCoCDCoCDCoCDCoCZndDsgWzI0LzM4NjRdIENvbXBpbGluZyBDIG9iamVjdCBsaWJzbGlycC5h LnAvc2xpcnBfc3JjX3N0cmVhbS5jLm88YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsyNS8zODY0 XSBDb21waWxpbmcgQyBvYmplY3QgbGlic2xpcnAuYS5wL3NsaXJwX3NyY190Y3BfaW5wdXQuYy5v PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbMjYvMzg2NF0gQ29tcGlsaW5nIEMgb2JqZWN0IGxp YnNsaXJwLmEucC9zbGlycF9zcmNfdGNwX291dHB1dC5jLm88YnI+DQomZ3Q7wqAgwqAgwqAgwqAm Z3Q7IFsyNy8zODY0XSBDb21waWxpbmcgQyBvYmplY3QgbGlic2xpcnAuYS5wL3NsaXJwX3NyY190 Y3Bfc3Vici5jLm88YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsyOC8zODY0XSBDb21waWxpbmcg QyBvYmplY3QgbGlic2xpcnAuYS5wL3NsaXJwX3NyY190Y3BfdGltZXIuYy5vPGJyPg0KJmd0O8Kg IMKgIMKgIMKgJmd0OyBbMjkvMzg2NF0gQ29tcGlsaW5nIEMgb2JqZWN0IGxpYnNsaXJwLmEucC9z bGlycF9zcmNfdGZ0cC5jLm88YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFszMC8zODY0XSBDb21w aWxpbmcgQyBvYmplY3QgbGlic2xpcnAuYS5wL3NsaXJwX3NyY191ZHAuYy5vPGJyPg0KJmd0O8Kg IMKgIMKgIMKgJmd0OyBbMzEvMzg2NF0gQ29tcGlsaW5nIEMgb2JqZWN0IGxpYnNsaXJwLmEucC9z bGlycF9zcmNfdWRwNi5jLm88YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFszMi8zODY0XSBDb21w aWxpbmcgQyBvYmplY3QgbGlic2xpcnAuYS5wL3NsaXJwX3NyY191dGlsLmMubzxicj4NCiZndDvC oCDCoCDCoCDCoCZndDsgWzMzLzM4NjRdIENvbXBpbGluZyBDIG9iamVjdCBsaWJzbGlycC5hLnAv c2xpcnBfc3JjX3ZlcnNpb24uYy5vPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBbMzQvMzg2NF0g TGlua2luZyBzdGF0aWMgdGFyZ2V0IGxpYnNsaXJwLmE8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7 IFszNS8zODY0XSBHZW5lcmF0aW5nIHFlbXUtdmVyc2lvbi5oIHdpdGggYSBjdXN0b20gY29tbWFu ZCAod3JhcHBlZCBieSBtZXNvbiB0byBjYXB0dXJlIG91dHB1dCk8YnI+DQomZ3Q7wqAgwqAgwqAg wqAmZ3Q7IEZBSUxFRDogcWVtdS12ZXJzaW9uLmg8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7L2hv bWUvYWdsL0F1dG9tb3RpdmUvQURBU19JbmZvdGFpbm1lbnQvUGxhdGZvcm0vUG9reV9LaXJrc3Rv bmUvYnVpbGQvdG1wL3dvcmsvY29ydGV4YTcyLXBva3ktbGludXgvcWVtdS82LjIuMC1yMC9yZWNp cGUtc3lzcm9vdC1uYXRpdmUvdXNyPGJyPg0KJmd0O8KgIMKgIMKgIMKgPGJyPg0KJmd0O8KgIMKg IMKgIMKgJmd0OyAvYmluL21lc29uIC0taW50ZXJuYWwgZXhlIC0tY2FwdHVyZSBxZW11LXZlcnNp b24uaC0tL2hvbWUvYWdsL0F1dG9tb3RpdmUvQURBU19JbmZvdGFpbm1lbnQvUGxhdGZvcm0vUG9r eV9LaXJrc3RvbmUvYnVpbGQvdG1wL3dvcmsvY29ydGV4YTcyLXBva3ktbGludXgvcWVtdS82LjIu MC1yMC9xZW11LTYuMi4wL3NjcmlwdHMvcWVtdTxicj4NCiZndDvCoCDCoCDCoCDCoC12PGJyPg0K Jmd0O8KgIMKgIMKgIMKgJmd0OyBlcnNpb24uc2g8YnI+DQomZ3Q7wqAgwqAgwqAgwqAvaG9tZS9h Z2wvQXV0b21vdGl2ZS9BREFTX0luZm90YWlubWVudC9QbGF0Zm9ybS9Qb2t5X0tpcmtzdG9uZS9i dWlsZC90bXAvd29yay9jb3J0ZXhhNzItcG9reS1saW51eC9xZW11LzYuMi4wLXIwL3FlbXUtNi4y LjAgJiMzOTsmIzM5Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgNi4yLjA8YnI+DQomZ3Q7wqAg wqAgwqAgwqAmZ3Q7IC91c3IvYmluL2Vudjog4oCYbmF0aXZlcHl0aG9uM+KAmTogTm8gc3VjaCBm aWxlIG9yIGRpcmVjdG9yeTxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgbmluamE6IGJ1aWxkIHN0 b3BwZWQ6IHN1YmNvbW1hbmQgZmFpbGVkLjxicj4NCiZndDvCoCDCoCDCoCDCoCZndDsgbWFrZTog KioqIFtNYWtlZmlsZToxNjI6IHJ1bi1uaW5qYV0gRXJyb3IgMTxicj4NCiZndDvCoCDCoCDCoCDC oCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFRoYW5rcyAmYW1wOyBSZWdhcmRzLDxicj4N CiZndDvCoCDCoCDCoCDCoCZndDsgVmlwdWwgS3VtYXI8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7 PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0OyBPbiBXZWQsIERlYyAxNCwgMjAyMiBhdCA0OjU1IEFN IFN0ZWZhbm8gU3RhYmVsbGluaSAmbHQ7PGEgaHJlZj0ibWFpbHRvOnNzdGFiZWxsaW5pQGtlcm5l bC5vcmciIHRhcmdldD0iX2JsYW5rIj5zc3RhYmVsbGluaUBrZXJuZWwub3JnPC9hPiZndDsgd3Jv dGU6PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgSGkgVmlwdWwsPGJyPg0KJmd0 O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoEdvb2Qg cHJvZ3Jlc3MhIFRoZSBtYWluIGZ1bmN0aW9uIHdlIHNob3VsZCBjaGVjayBpcyAmcXVvdDt4ZW5m Yl9yZWZyZXNoJnF1b3Q7IGJ1dDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoGZy b20gdGhlIGxvZ3MgaXQgbG9va3MgbGlrZSBpdCBpcyBjYWxsZWQgc2V2ZXJhbCB0aW1lcy4gV2hp Y2ggbWVhbnMgdGhhdDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoGV2ZXJ5dGhp bmcgc2VlbXMgdG8gYmUgd29ya2luZyBhcyBleHBlY3RlZCBvbiB0aGUgTGludXggc2lkZS48YnI+ DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg SXQgaXMgdGltZSB0byBpbnZlc3RpZ2F0ZSB0aGUgUUVNVSBzaWRlOjxicj4NCiZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoC4vaHcvZGlzcGxheS94ZW5mYi5jOnhlbmZiX2hhbmRsZV9ldmVu dHM8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAuL2h3L2Rpc3BsYXkveGVuZmIu Yzp4ZW5mYl9tYXBfZmI8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgSSB3b25kZXIgaWYgdGhlIGlzc3VlIGlzIGludGVybmFsIHRvIFFF TVUuIFlvdSBtaWdodCB3YW50IHRvIHVzZSBhbjxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoG9sZGVyIFFFTVUgdmVyc2lvbiB0byBjaGVjayBpZiBpdCB3b3JrcywgbWF5YmUgNi4w IG9yIDUuMCBvciBldmVuIDQuMC48YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBJ IGFsc28gd29uZGVyIGlmIGl0IGlzIGEgcHJvYmxlbSBiZXR3ZWVuIHhlbmZiLmMgYW5kIHRoZSBy ZXN0IG9mIFFFTVUuIEk8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqB3b3VsZCBp bnZlc3RpZ2F0ZSBob3cgeGVuZmItJmd0O3BpeGVscyBpcyByZW5kZXJlZCBieSB0aGUgcmVzdCBv ZiBRRU1VLjxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoFNwZWNpZmljYWxseSB5 b3UgbWlnaHQgd2FudCB0byBsb29rIGF0IHRoZSBjYWxsIHRvPGJyPg0KJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgcWVtdV9jcmVhdGVfZGlzcGxheXN1cmZhY2UsIHFlbXVfY3JlYXRlX2Rp c3BsYXlzdXJmYWNlX2Zyb20gYW5kPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg ZHB5X2dmeF9yZXBsYWNlX3N1cmZhY2UgaW4geGVuZmJfdXBkYXRlLjxicj4NCiZndDvCoCDCoCDC oCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBJIGhvcGUgdGhpcyBo ZWxwcy48YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgQ2hlZXJzLDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqBTdGVmYW5vPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4N CiZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBP biBUdWUsIDEzIERlYyAyMDIyLCBWaXB1bCBTdW5lamEgd3JvdGU6PGJyPg0KJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBIaSBTdGVmYW5vLDxicj4NCiZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 IFRoYW5rcyE8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBJIG1vZGlmaWVkIHhlbi1mYmZyb250LmMg c291cmNlIGZpbGUsIGluY2x1ZGVkIHByaW50ayBkZWJ1ZyBsb2dzICZhbXA7IGNyb3NzIGNvbXBp bGVkIGl0LiBJIGluY2x1ZGVkIHRoZSBwcmludGsgZGVidWcgbG9nPGJyPg0KJmd0O8KgIMKgIMKg IMKgYXQgdGhlPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgZW50cnkgJmFtcDsg ZXhpdDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgb2YgYWxsIGZ1bmN0 aW9ucyBvZiB4ZW4tZmJmcm9udC5jIGZpbGUuPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0OyBHZW5lcmF0ZWQga2VybmVsIG1vZHVsZSAmYW1wOyBsb2FkZWQgaW4gZ3Vlc3Qg bWFjaGluZSBhdCBib290dXAuIEkgY291bGQgc2VlIGxvdHMgb2YgbG9ncyBjb21pbmcgdXAsIGFu ZCBjb3VsZCBzZWU8YnI+DQomZ3Q7wqAgwqAgwqAgwqBtdWx0aXBsZTxicj4NCiZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoGZ1bmN0aW9ucyBiZWluZzxicj4NCiZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDsgaW52b2tlZCBldmVuIGlmIEkgaGF2ZcKgbm90IHVzZWTCoHZuY3Zp ZXdlciBpbiB0aGUgaG9zdC4gQXR0YWNoaW5nIHRoZSBsb2cgZmlsZSBmb3IgcmVmZXJlbmNlLiBB bnkgc3BlY2lmaWMgZnVuY3Rpb24gb3I8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqBwYXJhbWV0ZXJzIHRoYXQgaGF2ZTxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDsgdG8gYmUgY2hlY2tlZCBvciBhbnkgb3RoZXIgc3VnZ2VzdGlvbiBhcyBwZXIgbG9ncz88 YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBUaGFua3MgJmFtcDsgUmVnYXJkcyw8YnI+DQomZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFZpcHVsIEt1bWFyPGJyPg0KJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDsgT24gVHVlLCBEZWMgMTMsIDIwMjIgYXQgMzo0NCBBTSBTdGVmYW5vIFN0YWJlbGxpbmkg Jmx0OzxhIGhyZWY9Im1haWx0bzpzc3RhYmVsbGluaUBrZXJuZWwub3JnIiB0YXJnZXQ9Il9ibGFu ayI+c3N0YWJlbGxpbmlAa2VybmVsLm9yZzwvYT4mZ3Q7IHdyb3RlOjxicj4NCiZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoEhpIFZpcHVsLDxicj4NCiZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqBJIGFtIG9ubGluZSBvbiBJUkMgT0ZUQyAjeGVuZGV2ZWwgKDxh IGhyZWY9Imh0dHBzOi8vd3d3Lm9mdGMubmV0LyIgcmVsPSJub3JlZmVycmVyIiB0YXJnZXQ9Il9i bGFuayI+aHR0cHM6Ly93d3cub2Z0Yy5uZXQvPC9hPiwgeW91IG5lZWQgYTxicj4NCiZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoHJlZ2lzdGVyZWQgbmlja25hbWUg dG8gam9pbiAjeGVuZGV2ZWwpLjxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBGb3Ig ZGV2ZWxvcG1lbnQgYW5kIGRlYnVnZ2luZyBJIGZpbmQgdGhhdCBpdCBpcyBhIGxvdCBlYXNpZXIg dG88YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBjcm9z c2NvbXBpbGUgdGhlIGtlcm5lbCAmcXVvdDtieSBoYW5kJnF1b3Q7LCBhbmQgZG8gYSBtb25vbGl0 aGljIGJ1aWxkLCByYXRoZXI8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqB0aGFuIGdvaW5nIHRocm91Z2ggWW9jdG8uPGJyPg0KJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoEZvciBpbnN0YW5jZSB0aGUgZm9sbG93aW5nIGJ1aWxkcyBmb3IgbWU6PGJy Pg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoGNkIGxpbnV4LmdpdDxicj4NCiZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoGV4cG9ydCBBUkNIPWFybTY0PGJy Pg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgZXhwb3J0IENS T1NTX0NPTVBJTEU9L3BhdGgvdG8vY3Jvc3MtY29tcGlsZXI8YnI+DQomZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBtYWtlIGRlZmNvbmZpZzxicj4NCiZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoFthZGQgcHJpbnRrcyB0byBkcml2 ZXJzL3ZpZGVvL2ZiZGV2L3hlbi1mYmZyb250LmNdPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgbWFrZSAtajggSW1hZ2UuZ3o8YnI+DQomZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgQW5kIEltYWdlLmd6IGJvb3RzIG9uIFhlbiBhcyBEb21VIGtlcm5l bCB3aXRob3V0IGlzc3Vlcy48YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgQ2hlZXJz LDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBTdGVmYW5vPGJyPg0KJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoE9uIFNhdCwgMTAgRGVjIDIwMjIsIFZpcHVsIFN1bmVqYSB3cm90 ZTo8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 IEhpIFN0ZWZhbm8sPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDsgVGhhbmtzITxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7IEkgaGF2ZSBpbmNsdWRlZCBwcmludGsgZGVidWcgbG9ncyBpbiB0aGUgeGVu LWZiZnJvbnQuYyBzb3VyY2UgZmlsZS4gV2hpbGUgY3Jvc3MgY29tcGlsaW5nIHRvIGdlbmVyYXRl IC5rbzxicj4NCiZndDvCoCDCoCDCoCDCoHdpdGg8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmcXVvdDt4ZW4tZ3Vlc3QtaW1hZ2UtbWluaW1hbCZxdW90 Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsg dG9vbGNoYWluIGl0JiMzOTtzIHRocm93aW5nIGEgbW9kcG9zdDxicj4NCiZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgbm90IGZvdW5kIGVycm9yLiBJIGNv dWxkIHNlZSB0aGUgbW9kcG9zdC5jIHNvdXJjZSBmaWxlIGJ1dCB0aGUgZmluYWwgc2NyaXB0IGlz IG1pc3NpbmcuIEFueSBpbnB1dCBvbiB0aGlzLDxicj4NCiZndDvCoCDCoCDCoCDCoEJlbG93IGFy ZTxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoHRoZTxicj4NCiZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoGxvZ3M6PGJyPg0KJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgYWdsQGFnbC1PcHRpUGxleC03MDEw On4vQXV0b21vdGl2ZS9BREFTX0luZm90YWlubWVudC9wcm9qZWN0L0FwcGxpY2F0aW9uL1hlbi9G cmFtZWJ1ZmZlciQgbWFrZTxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDsgbWFrZSBBUkNIPWFybTY0IC1JL29wdC9wb2t5LzQuMC41L3N5c3Jvb3Rz L2NvcnRleGE3Mi1wb2t5LWxpbnV4L3Vzci9pbmNsdWRlL2FzbSAtQzxicj4NCiZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgL29wdC9wb2t5LzQuMC41L3N5 c3Jvb3RzL2NvcnRleGE3Mi1wb2t5LWxpbnV4L2xpYi9tb2R1bGVzLzUuMTUuNzIteW9jdG8tc3Rh bmRhcmQvYnVpbGQ8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7IE09L2hvbWUvYWdsL0F1dG9tb3RpdmUvQURBU19JbmZvdGFpbm1lbnQvcHJvamVj dC9BcHBsaWNhdGlvbi9YZW4vRnJhbWVidWZmZXIgbW9kdWxlczxicj4NCiZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgbWFrZVsxXTogRW50ZXJpbmcgZGly ZWN0b3J5PGJyPg0KJmd0O8KgIMKgIMKgIMKgJiMzOTsvb3B0L3Bva3kvNC4wLjUvc3lzcm9vdHMv Y29ydGV4YTcyLXBva3ktbGludXgvbGliL21vZHVsZXMvNS4xNS43Mi15b2N0by1zdGFuZGFyZC9i dWlsZCYjMzk7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0OyBhcmNoL2FybTY0L01ha2VmaWxlOjM2OiBEZXRlY3RlZCBhc3NlbWJsZXIgd2l0aCBi cm9rZW4gLmluc3Q7IGRpc2Fzc2VtYmx5IHdpbGwgYmUgdW5yZWxpYWJsZTxicj4NCiZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgd2FybmluZzogdGhlIGNv bXBpbGVyIGRpZmZlcnMgZnJvbSB0aGUgb25lIHVzZWQgdG8gYnVpbGQgdGhlIGtlcm5lbDxicj4N CiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgVGhl IGtlcm5lbCB3YXMgYnVpbHQgYnk6IGdjYyAoVWJ1bnR1IDkuNC4wLTF1YnVudHUxfjIwLjA0LjEp IDkuNC4wPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0OyDCoCBZb3UgYXJlIHVzaW5nOiDCoCDCoCDCoCDCoCDCoCBhYXJjaDY0LXBva3ktbGludXgt Z2NjIChHQ0MpIDExLjMuMDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDsgwqAgQ0MgW01dIMKgL2hvbWUvYWdsL0F1dG9tb3RpdmUvQURBU19JbmZv dGFpbm1lbnQvcHJvamVjdC9BcHBsaWNhdGlvbi9YZW4vRnJhbWVidWZmZXIveGVuLWZiZnJvbnQu bzxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsg wqAgTU9EUE9TVCAvaG9tZS9hZ2wvQXV0b21vdGl2ZS9BREFTX0luZm90YWlubWVudC9wcm9qZWN0 L0FwcGxpY2F0aW9uL1hlbi9GcmFtZWJ1ZmZlci9Nb2R1bGUuc3ltdmVyczxicj4NCiZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgL2Jpbi9zaDogMTogc2Ny aXB0cy9tb2QvbW9kcG9zdDogbm90IGZvdW5kPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBtYWtlWzJdOiAqKiogW3NjcmlwdHMvTWFrZWZpbGUu bW9kcG9zdDoxMzM6PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgL2hvbWUvYWdsL0F1dG9tb3RpdmUvQURBU19JbmZvdGFpbm1lbnQvcHJvamVjdC9BcHBs aWNhdGlvbi9YZW4vRnJhbWVidWZmZXIvTW9kdWxlLnN5bXZlcnNdPGJyPg0KJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBFcnJvciAxMjc8YnI+DQomZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IG1ha2VbMV06ICoq KiBbTWFrZWZpbGU6MTgxMzogbW9kdWxlc10gRXJyb3IgMjxicj4NCiZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgbWFrZVsxXTogTGVhdmluZyBkaXJlY3Rv cnk8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmIzM5Oy9vcHQvcG9reS80LjAuNS9zeXNyb290cy9jb3J0 ZXhhNzItcG9reS1saW51eC9saWIvbW9kdWxlcy81LjE1LjcyLXlvY3RvLXN0YW5kYXJkL2J1aWxk JiMzOTs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7IG1ha2U6ICoqKiBbTWFrZWZpbGU6NTogYWxsXSBFcnJvciAyPGJyPg0KJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBhZ2xAYWdsLU9wdGlQbGV4LTcw MTA6fi9BdXRvbW90aXZlL0FEQVNfSW5mb3RhaW5tZW50L3Byb2plY3QvQXBwbGljYXRpb24vWGVu L0ZyYW1lYnVmZmVyJCBscyAtbDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDsgdG90YWwgMzI0PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAtcnd4cnd4cnd4IDEgYWdsIGFnbCDCoCDCoDM1OSBE ZWMgMTAgMjI6NDEgTWFrZWZpbGU8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7IC1ydy1ydy1yLS0gMSBhZ2wgYWdsIMKgIMKgIDkwIERlYyAxMCAy Mjo0OSBtb2R1bGVzLm9yZGVyPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0OyAtcnctci0tci0tIDEgYWdsIGFnbCDCoDE4MzMxIERlYyDCoDEgMjA6 MzIgeGVuLWZiZnJvbnQuYzxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDsgLXJ3LXJ3LXItLSAxIGFnbCBhZ2wgwqAgwqAgOTAgRGVjIDEwIDIyOjQ5 IHhlbi1mYmZyb250Lm1vZDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDsgLXJ3LXJ3LXItLSAxIGFnbCBhZ2wgMjk3ODMyIERlYyAxMCAyMjo0OSB4 ZW4tZmJmcm9udC5vPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0OyBhZ2xAYWdsLU9wdGlQbGV4LTcwMTA6fi9BdXRvbW90aXZlL0FEQVNfSW5mb3Rh aW5tZW50L3Byb2plY3QvQXBwbGljYXRpb24vWGVuL0ZyYW1lYnVmZmVyJCBmaWxlIHhlbi1mYmZy b250Lm88YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7IHhlbi1mYmZyb250Lm86IEVMRiA2NC1iaXQgTFNCIHJlbG9jYXRhYmxlLCBBUk0gYWFyY2g2 NCwgdmVyc2lvbiAxIChTWVNWKSwgd2l0aCBkZWJ1Z19pbmZvLCBub3Qgc3RyaXBwZWQ8YnI+DQom Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IGFnbEBhZ2wt T3B0aVBsZXgtNzAxMDp+L0F1dG9tb3RpdmUvQURBU19JbmZvdGFpbm1lbnQvcHJvamVjdC9BcHBs aWNhdGlvbi9YZW4vRnJhbWVidWZmZXIkPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDsgSSBoYXZlIGNvbm5lY3RlZCBhIEhETUkgYmFzZWQgMTk4MHgx MDI0IHJlc29sdXRpb24gZGlzcGxheSBzY3JlZW4gdG8gcmFzcGJlcnJ5cGk0IGZvciB0ZXN0aW5n IHB1cnBvc2VzLiBJPGJyPg0KJmd0O8KgIMKgIMKgIMKgaG9wZTxicj4NCiZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoGNvbm5lY3Rpbmc8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqB0aGlzIGRpc3BsYXkgdG88YnI+DQomZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IHJwaTQgc2hvdWxkIGJlIG9rLjxicj4N CiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQom Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IElzIHRoZXJl IGFueSBvdGhlciB3YXkgd2UgY2FuIGNvbm5lY3QgYWxzbyBmb3IgZGV0YWlsZWQgZGlzY3Vzc2lv biBvbiB0aGUgZGlzcGxheSBicmluZ3VwIGlzc3VlPyBUaGlzIHdpbGw8YnI+DQomZ3Q7wqAgwqAg wqAgwqByZWFsbHk8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBoZWxwIHRvPGJy Pg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgcmVzb2x2ZSB0 aGlzPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 OyBpc3N1ZS48YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0OyBUaGFua3MgJmFtcDsgUmVnYXJkcyw8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFZpcHVsIEt1bWFyPGJyPg0KJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgT24gRnJpLCBEZWMgMiwgMjAyMiBhdCAx OjAyIEFNIFN0ZWZhbm8gU3RhYmVsbGluaSAmbHQ7PGEgaHJlZj0ibWFpbHRvOnNzdGFiZWxsaW5p QGtlcm5lbC5vcmciIHRhcmdldD0iX2JsYW5rIj5zc3RhYmVsbGluaUBrZXJuZWwub3JnPC9hPiZn dDsgd3JvdGU6PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgT24gVGh1LCAxIERlYyAyMDIyLCBWaXB1bCBTdW5lamEgd3JvdGU6 PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0OyBIaSBTdGVmYW5vLDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgVGhhbmtzITxicj4NCiZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7IEkgYW0gZXhwbG9yaW5nIGJvdGggb3B0aW9ucyBoZXJlLCBtb2RpZmlj YXRpb24gb2YgZnJhbWVidWZmZXIgc291cmNlIGZpbGUgJmFtcDsgc2V0dGluZyB1cCB4MTF2bmMg c2VydmVyPGJyPg0KJmd0O8KgIMKgIMKgIMKgaW48YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqBndWVzdC48YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IE90aGVyIHRoYW4gdGhlc2UgSSB3b3VsZCBsaWtl IHRvIHNoYXJlIGEgZmV3IGZpbmRpbmdzIHdpdGggeW91Ljxicj4NCiZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7IDEuIElmIGkga2VlcCAmcXVvdDtDT05GSUdfWEVOX0ZCREVWX0ZST05URU5EPXkmcXVvdDsg dGhlbiB4ZW4tZmJmcm9udC5rbyBpcyBub3QgZ2VuZXJhdGluZyBidXQgaWYgaSBrZWVwPGJyPg0K Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJnF1b3Q7Q09ORklH X1hFTl9GQkRFVl9GUk9OVEVORD1tJnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyB0aGVuIGNvdWxkIHNlZSB4 ZW4tZmJmcm9udC5rbyAmYW1wOyBpdHMgbG9hZGluZyBhbHNvLiBTYW1lIHRoaW5ncyB3aXRoIG90 aGVyIGZyb250ZW5kL2JhY2tlbmQgZHJpdmVyczxicj4NCiZndDvCoCDCoCDCoCDCoGFsc28uIERv IHdlPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgbmVlZCB0bzxicj4NCiZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoGNv bmZpZ3VyZcKgdGhlc2U8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IGRyaXZlcnMgYXMgYSBtb2R1bGUobSkgb25seT88 YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJy Pg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgeGVuLWZiZnJvbnQgc2hvdWxkIHdvcmsgYm90aCBhcyBhIG1vZHVsZSAoeGVuLWZiZnJv bnQua28pIG9yIGJ1aWx0LWluPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgKENPTkZJR19YRU5fRkJERVZfRlJPTlRFTkQ9eSku PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxi cj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+ DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0K Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0OyAyLiBJIGNvdWxkIHNlZSB4ZW5zdG9yZWQgc2VydmljZSBpcyBydW5uaW5nIGZvciB0 aGUgaG9zdCBidXQgaXQmIzM5O3MgYWx3YXlzIGZhaWxpbmcgZm9yIHRoZTxicj4NCiZndDvCoCDC oCDCoCDCoGd1ZXN0wqBtYWNoaW5lLiBJPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgY291bGQgc2VlPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgaXQgaW48YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqBib290dXAgbG9ncyAmYW1wOyB2aWE8YnI+DQomZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IHN5 c3RlbWN0bCBzdGF0dXMgYWxzby48YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgVGhhdCBpcyBub3JtYWwuIHhlbnN0b3JlZCBpcyBv bmx5IG1lYW50IHRvIGJlIHJ1biBpbiBEb20wLCBub3QgaW4gdGhlPGJyPg0KJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgZG9tVXMuIElm IHlvdSB1c2UgdGhlIHNhbWUgcm9vdGZzIGZvciBEb20wIGFuZCBEb21VIHRoZW4geGVuc3RvcmVk IHdpbGw8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqBmYWlsIHN0YXJ0aW5nIGluIHRoZSBEb21VIChidXQgc2hvdWxkIHN1Y2Nl ZWQgaW4gRG9tMCksIHdoaWNoIGlzIHdoYXQgd2U8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqB3YW50Ljxicj4NCiZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBJZiB5b3Ug cnVuICZxdW90O3hlbnN0b3JlLWxzJnF1b3Q7IGluIERvbTAsIHlvdSYjMzk7bGwgc2VlIGEgYnVu Y2ggb2YgZW50cmllcyw8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBpbmNsdWRpbmcgc29tZSBvZiB0aGVtIHJlbGF0ZWQgdG8g JnF1b3Q7dmZiJnF1b3Q7IHdoaWNoIGlzIHRoZSB2aXJ0dWFsIGZyYW1lYnVmZmVyPGJyPg0KJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg cHJvdG9jb2wuIFlvdSBzaG91bGQgYWxzbyBzZWUgYW4gZW50cnkgY2FsbGVkICZxdW90O3N0YXRl JnF1b3Q7IHNldCB0byAmcXVvdDs0JnF1b3Q7IHdoaWNoPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgbWVhbnMgJnF1b3Q7Y29u bmVjdGVkJnF1b3Q7LiBzdGF0ZSA9IDQgaXMgdXN1YWxseSB3aGVuIGV2ZXJ5dGhpbmcgd29ya3Mu IE5vcm1hbGx5PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgd2hlbiB0aGluZ3MgZG9uJiMzOTt0IHdvcmsgc3RhdGUgIT0gNC48 YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJy Pg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4N CiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQom Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7IEJlbG93IGFyZSB0aGUgbG9nczo8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqBPSyDCoF0gUmVhY2hl ZCB0YXJnZXQgQmFzaWMgU3lzdGVtLjxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoE9LIMKgXSBTdGFydGVkIEtl cm5lbCBMb2dnaW5nIFNlcnZpY2UuPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgT0sgwqBdIFN0YXJ0ZWQgU3lz dGVtIExvZ2dpbmcgU2VydmljZS48YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIMKgIMKgIMKgU3RhcnRpbmcg RC1CdXMgU3lzdGVtIE1lc3NhZ2UgQnVzLi4uPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCDCoCDCoCDCoFN0 YXJ0aW5nIFVzZXIgTG9naW4gTWFuYWdlbWVudC4uLjxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqAgwqAgwqAg wqBTdGFydGluZyBQZXJtaXQgVXNlciBTZXNzaW9ucy4uLjxicj4NCiZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqAgwqAg wqAgwqBTdGFydGluZyBUaGUgWGVuIHhlbnN0b3JlLi4uPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCDCoCDC oCDCoFN0YXJ0aW5nIE9wZW5TU0ggS2V5IEdlbmVyYXRpb24uLi48YnI+DQomZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFtGQUlM RURdIEZhaWxlZCB0byBzdGFydCBUaGUgWGVuIHhlbnN0b3JlLjxicj4NCiZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgU2VlICYj Mzk7c3lzdGVtY3RsIHN0YXR1cyB4ZW5zdG9yZWQuc2VydmljZSYjMzk7IGZvciBkZXRhaWxzLjxi cj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDsgW0RFUEVORF0gRGVwZW5kZW5jeSBmYWlsZWQgZm9yIHFlbXUgZm9yIHhlbiBk b20wIGRpc2sgYmFja2VuZC48YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFtERVBFTkRdIERlcGVuZGVuY3kgZmFpbGVk IGZvciBYZW5k4oCmcCBndWVzdHMgb24gYm9vdCBhbmQgc2h1dGRvd24uPGJyPg0KJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBb REVQRU5EXSBEZXBlbmRlbmN5IGZhaWxlZCBmb3IgeGVuLeKApmRlcywgSlNPTiBjb25maWd1cmF0 aW9uIHN0dWIpLjxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDsgW0RFUEVORF0gRGVwZW5kZW5jeSBmYWlsZWQgZm9yIFhl bmPigKZndWVzdCBjb25zb2xlcyBhbmQgaHlwZXJ2aXNvci48YnI+DQomZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqBPSyDC oF0gRmluaXNoZWQgUGVybWl0IFVzZXIgU2Vzc2lvbnMuPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgT0sgwqBd IFN0YXJ0ZWQgR2V0dHkgb24gdHR5MS48YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqBPSyDCoF0gU3RhcnRlZCBT ZXJpYWwgR2V0dHkgb24gaHZjMC48YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFsgwqBPSyDCoF0gU3RhcnRlZCBTZXJp YWwgR2V0dHkgb24gdHR5UzAuPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgT0sgwqBdIFJlYWNoZWQgdGFyZ2V0 IExvZ2luIFByb21wdHMuPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCDCoCDCoCDCoFN0YXJ0aW5nIFhlbi13 YXRjaGRvZyAtIHJ1biB4ZW4gd2F0Y2hkb2cgZGFlbW9uLi4uPGJyPg0KJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBbIMKgT0sg wqBdIFN0YXJ0ZWQgRC1CdXMgU3lzdGVtIE1lc3NhZ2UgQnVzLjxicj4NCiZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoE9L IMKgXSBTdGFydGVkIFhlbi13YXRjaGRvZyAtIHJ1biB4ZW4gd2F0Y2hkb2cgZGFlbW9uLjxicj4N CiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDsgWyDCoE9LIMKgXSBGaW5pc2hlZCBPcGVuU1NIIEtleSBHZW5lcmF0aW9uLjxicj4N CiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDsgWyDCoE9LIMKgXSBTdGFydGVkIFVzZXIgTG9naW4gTWFuYWdlbWVudC48YnI+DQom Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7IFsgwqBPSyDCoF0gUmVhY2hlZCB0YXJnZXQgTXVsdGktVXNlciBTeXN0ZW0uPGJyPg0K Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0OyDCoCDCoCDCoCDCoCDCoFN0YXJ0aW5nIFJlY29yZCBSdW5sZXZlbCBDaGFuZ2UgaW4g VVRNUC4uLjxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDsgWyDCoE9LIMKgXSBGaW5pc2hlZCBSZWNvcmQgUnVubGV2ZWwg Q2hhbmdlIGluIFVUTVAuPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBmYmNvbjogVGFraW5nIG92ZXIgY29uc29sZTxi cj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFBva3kgKFlvY3RvIFByb2plY3QgUmVmZXJlbmNlIERp c3RybykgNC4wLjQgcmFzcGJlcnJ5cGk0LTY0IGh2YzA8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 OyByYXNwYmVycnlwaTQtNjQgbG9naW46IHJvb3Q8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IHJvb3RAcmFzcGJlcnJ5 cGk0LTY0On4jPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0OyByb290QHJhc3BiZXJyeXBpNC02NDp+Izxicj4NCiZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDsgcm9vdEByYXNwYmVycnlwaTQtNjQ6fiMgc3lzdGVtY3RsIHN0YXR1cyB4ZW5zdG9yZWQuc2Vy dmljZTxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDsgeCB4ZW5zdG9yZWQuc2VydmljZSAtIFRoZSBYZW4geGVuc3RvcmU8 YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7IMKgIMKgIMKgTG9hZGVkOiBsb2FkZWQgKC9saWIvc3lzdGVtZC9zeXN0ZW0v eGVuc3RvcmVkLnNlcnZpY2U7IGVuYWJsZWQ7IHZlbmRvciBwcmVzZXQ6IGVuYWJsZWQpPGJyPg0K Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0OyDCoCDCoCDCoEFjdGl2ZTogZmFpbGVkIChSZXN1bHQ6IGV4aXQtY29kZSkgc2luY2Ug VGh1IDIwMjItMTItMDEgMDY6MTI6MDUgVVRDOyAyNnMgYWdvPGJyPg0KJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCBQ cm9jZXNzOiAxOTUgRXhlY1N0YXJ0UHJlPS9iaW4vZ3JlcCAtcSBjb250cm9sX2QgL3Byb2MveGVu L2NhcGFiaWxpdGllcyAoY29kZT1leGl0ZWQsPGJyPg0KJmd0O8KgIMKgIMKgIMKgc3RhdHVzPTEv RkFJTFVSRSk8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBEZWMgMDEgMDY6MTI6MDQgcmFzcGJl cnJ5cGk0LTY0IHN5c3RlbWRbMV06IFN0YXJ0aW5nIFRoZSBYZW4geGVuc3RvcmUuLi48YnI+DQom Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7IERlYyAwMSAwNjoxMjowNSByYXNwYmVycnlwaTQtNjQgc3lzdGVtZFsxXTogeGVuc3Rv cmVkLnNlcnZpY2U6IENvbnRyb2wgcHJvLi4uVVJFPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBEZWMgMDEgMDY6MTI6 MDUgcmFzcGJlcnJ5cGk0LTY0IHN5c3RlbWRbMV06IHhlbnN0b3JlZC5zZXJ2aWNlOiBGYWlsZWQg d2l0aC4uLmUmIzM5Oy48YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IERlYyAwMSAwNjoxMjowNSByYXNwYmVycnlwaTQt NjQgc3lzdGVtZFsxXTogRmFpbGVkIHRvIHN0YXJ0IFRoZSBYZW4geGVuc3RvcmUuPGJyPg0KJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0OyBIaW50OiBTb21lIGxpbmVzIHdlcmUgZWxsaXBzaXplZCwgdXNlIC1sIHRvIHNob3cgaW4g ZnVsbC48YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7IHJvb3RAcmFzcGJlcnJ5cGk0LTY0On4jwqA8YnI+DQomZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0OyBBbnkgaW5wdXQgb24gdGhlc2U/PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDsgVGhhbmtzICZhbXA7IFJlZ2FyZHMsPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBWaXB1bCBLdW1hcjxicj4NCiZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7IE9uIFdlZCwgTm92IDIzLCAyMDIyIGF0IDU6NDEgQU0gU3RlZmFu byBTdGFiZWxsaW5pICZsdDs8YSBocmVmPSJtYWlsdG86c3N0YWJlbGxpbmlAa2VybmVsLm9yZyIg dGFyZ2V0PSJfYmxhbmsiPnNzdGFiZWxsaW5pQGtlcm5lbC5vcmc8L2E+Jmd0OyB3cm90ZTo8YnI+ DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqBIaSBWaXB1bCw8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgSSBjYW5ub3Qgc3BvdCBhbnkgaXNzdWUgaW4gdGhlIGNvbmZpZ3VyYXRpb24sIGlu IHBhcnRpY3VhbCB5b3UgaGF2ZTo8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Q09ORklHX1hFTl9GQkRFVl9GUk9OVEVORD15PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoHdoaWNoIGlzIHdoYXQgeW91IG5lZWQuPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoFRoZSBvbmx5IHRoaW5nIEkgY2FuIHN1Z2dlc3QgaXMgdG8gYWRkIHByaW50a3Mg dG8gdGhlIExpbnV4IGZyb250ZW5kPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgZHJpdmVyICh0aGUg b25lIHJ1bm5pbmcgaW4gdGhlIGRvbVUpIHdoaWNoIGlzPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg ZHJpdmVycy92aWRlby9mYmRldi94ZW4tZmJmcm9udC5jIGFuZCBwcmludGZzIHRvIHRoZSBRRU1V IGJhY2tlbmQ8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAocnVubmluZyBpbiBEb20wKSB3aGljaCBp cyBody9kaXNwbGF5L3hlbmZiLmMgdG8gZmlndXJlIG91dCB3aGF0IGlzPGJyPg0KJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgZ29pbmcgb24uPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqBBbHRlcm5hdGl2ZWx5LCB5b3UgY2FuIHNldHVwIFBWIG5ldHdvcmsgd2l0aCB0 aGUgZG9tVSwgc3VjaCBhczo8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgwqAg dmlmPVsmIzM5OyYjMzk7XTxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBhbmQg dGhlbiBydW4geDExIGFuZCBhIHgxMXZuYyBzZXJ2ZXIgaW4geW91ciBkb21VLiBZb3Ugc2hvdWxk IGJlIGFibGUgdG88YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBjb25uZWN0IHRvIGl0IHVzaW5nIHZu Y3ZpZXdlciBhdCB0aGUgbmV0d29yayBJUCBvZiB5b3VyIGRvbVUuPGJyPg0KJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4N CiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoEJhc2ljYWxseSB5b3UgYXJlIHNraXBwaW5nIHRoZSBwcm9ibGVt IGJlY2F1c2UgaW5zdGVhZCBvZiB1c2luZyB0aGUgUFY8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBm cmFtZWJ1ZmZlciBwcm90b2NvbCwgeW91IGp1c3QgdXNlIFZOQyBvdmVyIHRoZSBuZXR3b3JrIHdp dGggdGhlIGRvbVUuPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqBDaGVlcnMsPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoFN0ZWZhbm88 YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoE9uIFR1ZSwg MjIgTm92IDIwMjIsIFZpcHVsIFN1bmVqYSB3cm90ZTo8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7IEhpIFN0ZWZhbm8sPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBUaGFua3MgZm9yIHRo ZcKgc3VwcG9ydCE8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0OyBMb29rcyBsaWtlIEkgaGF2ZSB0cmllZCBhbGwgdGhlIGNvbWJpbmF0aW9uc8Kg JmFtcDsgcG9zc2libGUgd2F5cyB0byBnZXQgZGlzcGxheSB1cCBidXQgZmFpbGVkLiBJczxicj4N CiZndDvCoCDCoCDCoCDCoHRoZXJlPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg YW55PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgZG9j dW1lbnQgb3I8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqBwZGYgZm9yPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgcG9ydGluZyB4 ZW4gb248YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IHJhc3BiZXJyeXBpNC48YnI+DQomZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7IEkgY291bGQgZmluZCBsb3QmIzM5O3Mgb2YgbGlua3MgdGVsbGlu ZyB0aGUgc2FtZSBidXQgY291bGRuJiMzOTt0IHNlZSBhbnkgb2ZmaWNpYWwgdXNlciBndWlkZSBv cjxicj4NCiZndDvCoCDCoCDCoCDCoGRvY3VtZW50PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgZnJvbSB0aGU8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqB4ZW48YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBjb21tdW5pdHkgb248YnI+DQomZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqB0aGUgc2FtZS4gSWY8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IHRoZXJlIGlzIHNvbWV0 aGluZyB0byByZWZlcsKgPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyB0byBwbGVhc2Ugc2hh cmUgd2l0aCBtZS48YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IEkgYW0gYXR0YWNoaW5nIHRo ZSBrZXJuZWwgY29uZmlndXJhdGlvbiBmaWxlIGFsc28sIGp1c3QgdGFrZSBhIGxvb2sgaWYgaSBo YXZlIG1pc3NlZDxicj4NCiZndDvCoCDCoCDCoCDCoGFueXRoaW5nLjxicj4NCiZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDsgQW55IG90aGVyIHN1Z2dlc3Rpb25zIG9yIGlucHV0IGZyb20geW91ciBlbmQg Y291bGQgYmUgcmVhbGx5IGhlbHBmdWw/PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4N CiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDsgUmVnYXJkcyw8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7IFZpcHVsIEt1bWFyPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDsgT24gRnJpLCBOb3YgMTEsIDIwMjIgYXQgNjo0MCBBTSBTdGVmYW5vIFN0 YWJlbGxpbmkgJmx0OzxhIGhyZWY9Im1haWx0bzpzc3RhYmVsbGluaUBrZXJuZWwub3JnIiB0YXJn ZXQ9Il9ibGFuayI+c3N0YWJlbGxpbmlAa2VybmVsLm9yZzwvYT4mZ3Q7IHdyb3RlOjxicj4NCiZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoEhpIFZpcHVsLDxicj4NCiZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBTb3JyeSBm b3IgdGhlIGxhdGUgcmVwbHkuIEZyb20gdGhlIGVhcmxpZXIgbG9ncyB0aGF0IHlvdSBzZW50LCBp dCBsb29rczxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoGxpa2UgZXZlcnl0 aGluZyBzaG91bGQgYmUgd29ya2luZyBjb3JyZWN0bHkuIFNwZWNpZmljYWxseTo8YnI+DQomZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg wqDCoCDCoCB2ZmIgPSAmcXVvdDsmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqDCoMKgIMKgIMKgMSA9ICZxdW90OyZxdW90Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoMKgwqAgwqAgwqAgMCA9ICZxdW90OyZxdW90Ozxicj4NCiZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoMKgwqAgwqAgwqAgwqBmcm9udGVuZCA9ICZxdW90Oy9s b2NhbC9kb21haW4vMS9kZXZpY2UvdmZiLzAmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqDCoMKgIMKgIMKgIMKgZnJvbnRlbmQtaWQgPSAmcXVvdDsxJnF1b3Q7PGJy Pg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgwqDCoCDCoCDCoCDCoG9ubGluZSA9 ICZxdW90OzEmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqDCoMKg IMKgIMKgIMKgc3RhdGUgPSAmcXVvdDs0JnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgwqDCoCDCoCDCoCDCoHZuYyA9ICZxdW90OzEmcXVvdDs8YnI+DQomZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqDCoMKgIMKgIMKgIMKgdm5jbGlzdGVuID0gJnF1b3Q7 MTI3LjAuMC4xJnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgwqDC oCDCoCDCoCDCoHZuY2Rpc3BsYXkgPSAmcXVvdDswJnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgwqDCoCDCoCDCoCDCoHZuY3VudXNlZCA9ICZxdW90OzEmcXVvdDs8 YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqDCoMKgIMKgIMKgIMKgc2RsID0g JnF1b3Q7MCZxdW90Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoMKgwqAg wqAgwqAgwqBvcGVuZ2wgPSAmcXVvdDswJnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgwqDCoCDCoCDCoCDCoGZlYXR1cmUtcmVzaXplID0gJnF1b3Q7MSZxdW90Ozxi cj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoMKgwqAgwqAgwqAgwqBob3RwbHVn LXN0YXR1cyA9ICZxdW90O2Nvbm5lY3RlZCZxdW90Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoMKgwqAgwqAgwqAgwqByZXF1ZXN0LXVwZGF0ZSA9ICZxdW90OzEmcXVvdDs8 YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgc3RhdGUgJnF1b3Q7NCZxdW90OyBtZWFucyAmcXVvdDtjb25uZWN0ZWQmcXVvdDsu IFNvIEkgd291bGQgZXhwZWN0IHRoYXQgeW91IHNob3VsZCBiZSBhYmxlPGJyPg0KJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgdG8gY29ubmVjdCB0byB0aGUgdm5jIHNlcnZlciB1c2lu ZyB2bmN2aWV3ZXIuIFlvdSBtaWdodCBub3Qgc2VlIGFueXRoaW5nPGJyPg0KJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgKGJsYWNrIHNjcmVlbikgYnV0IHlvdSBzaG91bGQgZGVmaW5p dGVseSBiZSBhYmxlIHRvIGNvbm5lY3QuPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4N CiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoEkgd291bGRuJiMzOTt0IHRyeSB0byBs YXVuY2ggeDExIGluIHRoZSBndWVzdCBqdXN0IHlldC4gZmJjb24gaW4gTGludXggaXM8YnI+DQom Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBlbm91Z2ggdG8gcmVuZGVyIHNvbWV0aGlu ZyBvbiB0aGUgc2NyZWVuLiBZb3Ugc2hvdWxkIGJlIGFibGUgdG8gc2VlIHRoZTxicj4NCiZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoExpbnV4IHRleHQtYmFzZWQgY29uc29sZSByZW5k ZXJlZCBncmFwaGljYWxseSwgY29ubmVjdGluZyB0byBpdCB2aWEgdm5jLjxicj4NCiZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBTb3Jy eSBmb3IgdGhlIGJhc2ljIHF1ZXN0aW9uLCBidXQgaGF2ZSB5b3UgdHJpZWQgYWxsIHRoZSBmb2xs b3dpbmc/PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoHZuY3ZpZXdlciA8YSBocmVmPSJodHRwOi8vMTI3LjAuMC4xOjAiIHJl bD0ibm9yZWZlcnJlciIgdGFyZ2V0PSJfYmxhbmsiPjEyNy4wLjAuMTowPC9hPjxicj4NCiZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoHZuY3ZpZXdlciA8YSBocmVmPSJodHRwOi8vMTI3 LjAuMC4xOjEiIHJlbD0ibm9yZWZlcnJlciIgdGFyZ2V0PSJfYmxhbmsiPjEyNy4wLjAuMToxPC9h Pjxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoHZuY3ZpZXdlciA8YSBocmVm PSJodHRwOi8vMTI3LjAuMC4xOjIiIHJlbD0ibm9yZWZlcnJlciIgdGFyZ2V0PSJfYmxhbmsiPjEy Ny4wLjAuMToyPC9hPjxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoHZuY3Zp ZXdlciA8YSBocmVmPSJodHRwOi8vMTI3LjAuMC4xOjU5MDAiIHJlbD0ibm9yZWZlcnJlciIgdGFy Z2V0PSJfYmxhbmsiPjEyNy4wLjAuMTo1OTAwPC9hPjxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoHZuY3ZpZXdlciA8YSBocmVmPSJodHRwOi8vMTI3LjAuMC4xOjU5MDEiIHJl bD0ibm9yZWZlcnJlciIgdGFyZ2V0PSJfYmxhbmsiPjEyNy4wLjAuMTo1OTAxPC9hPjxicj4NCiZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoHZuY3ZpZXdlciA8YSBocmVmPSJodHRwOi8v MTI3LjAuMC4xOjU5MDIiIHJlbD0ibm9yZWZlcnJlciIgdGFyZ2V0PSJfYmxhbmsiPjEyNy4wLjAu MTo1OTAyPC9hPjxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqBHaXZlbiB0aGF0IGZyb20gdGhlIHhlbnN0b3JlLWxzIGxvZ3Mg ZXZlcnl0aGluZyBzZWVtcyB0byB3b3JrIGNvcnJlY3RseTxicj4NCiZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoEkgYW0gbm90IHN1cmUgd2hhdCBlbHNlIHRvIHN1Z2dlc3QuIFlvdSBt aWdodCBoYXZlIHRvIGFkZCBwcmludGYgdG8gUUVNVTxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoHVpL3ZuYy5jIGFuZCBody9kaXNwbGF5L3hlbmZiLmMgdG8gc2VlIHdoYXQg aXMgZ29pbmcgd3JvbmcuPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoENoZWVycyw8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgU3RlZmFubzxicj4NCiZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgT24gTW9uLCA3IE5vdiAyMDIyLCBWaXB1bCBT dW5lamEgd3JvdGU6PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBI aSBTdGVmYW5vLDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgVGhh bmtzITxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IEFueSBpbnB1dCBmdXJ0aGVyIG9uICZx dW90O3hlbnN0b3JlLWxzJnF1b3Q7IGxvZ3M/PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsg SSBhbSB0cnlpbmcgdG8gcnVuIHRoZSB4MHZuY3NlcnZlciAmYW1wOyB4MTF2bmMgc2VydmVyIG1h bnVhbGx5IG9uIGd1ZXN0PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgbWFjaGlu ZSh4ZW5fZ3Vlc3RfaW1hZ2VfbWluaW1hbCk8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqBpbWFnZTxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoGJ1dCBpdCYjMzk7czxicj4NCiZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoGZhaWxpbmc8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqB3aXRoIHRoZSBiZWxvdzxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDsgZXJyb3IuPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4N CiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgcm9vdEByYXNwYmVycnlwaTQt NjQ6L3Vzci9iaW4jIHgwdm5jc2VydmVyPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0OyB4MHZuY3NlcnZlcjogdW5hYmxlIHRvIG9wZW4gZGlzcGxheSAmcXVvdDsmcXVv dDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IHJvb3RAcmFzcGJl cnJ5cGk0LTY0Oi91c3IvYmluIzxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDsgcm9vdEByYXNwYmVycnlwaTQtNjQ6L3Vzci9iaW4jIHgxMXZuYzxicj4NCiZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMj IyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjPGJyPg0KJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAjQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBA QEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQCM8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7ICNAIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIEAjPGJyPg0K Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAjQCDCoCoqIMKgV0FSTklORyDC oCoqIMKgV0FSTklORyDCoCoqIMKgV0FSTklORyDCoCoqIMKgV0FSTklORyDCoCoqIMKgIEAjPGJy Pg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAjQCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCBAIzxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDsgI0AgwqAgwqAgwqAgwqBZT1UgQVJFIFJVTk5JTkcgWDExVk5DIFdJVEhPVVQgQSBQQVNT V09SRCEhIMKgIMKgIMKgIMKgQCM8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7ICNAIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIEAjPGJyPg0KJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAjQCDCoFRoaXMgbWVhbnMgYW55b25lIHdpdGgg bmV0d29yayBhY2Nlc3MgdG8gdGhpcyBjb21wdXRlciDCoCBAIzxicj4NCiZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDsgI0AgwqBtYXkgYmUgYWJsZSB0byB2aWV3IGFuZCBjb250 cm9sIHlvdXIgZGVza3RvcC4gwqAgwqAgwqAgwqAgwqAgwqBAIzxicj4NCiZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDsgI0AgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg QCM8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7ICNAICZndDsmZ3Q7 Jmd0OyBJZiB5b3UgZGlkIG5vdCBtZWFuIHRvIGRvIHRoaXMgUHJlc3MgQ1RSTC1DIG5vdyEhICZs dDsmbHQ7Jmx0OyBAIzxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsg I0AgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgQCM8YnI+DQomZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7ICNAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBA QEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAIzxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDsgI0AgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgQCM8YnI+DQom Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7ICNAIMKgWW91IGNhbiBjcmVhdGUg YW4geDExdm5jIHBhc3N3b3JkIGZpbGUgYnkgcnVubmluZzogwqAgwqAgwqAgQCM8YnI+DQomZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7ICNAIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgIEAjPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAj QCDCoCDCoCDCoCB4MTF2bmMgLXN0b3JlcGFzc3dkIHBhc3N3b3JkIC9wYXRoL3RvL3Bhc3NmaWxl IMKgIMKgIMKgQCM8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7ICNA IMKgb3IgwqAgeDExdm5jIC1zdG9yZXBhc3N3ZCAvcGF0aC90by9wYXNzZmlsZSDCoCDCoCDCoCDC oCDCoCDCoCDCoCBAIzxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsg I0AgwqBvciDCoCB4MTF2bmMgLXN0b3JlcGFzc3dkIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIEAjPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0OyAjQCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCBAIzxicj4NCiZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgI0AgwqAodGhlIGxhc3Qgb25lIHdpbGwg dXNlIH4vLnZuYy9wYXNzd2QpIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgQCM8YnI+DQom Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7ICNAIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgIMKgIEAjPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 OyAjQCDCoGFuZCB0aGVuIHN0YXJ0aW5nIHgxMXZuYyB2aWE6IMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgQCM8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7ICNAIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIEAjPGJyPg0KJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAjQCDCoCDCoCDCoHgxMXZuYyAtcmZiYXV0 aCAvcGF0aC90by9wYXNzZmlsZSDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoEAjPGJyPg0K Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAjQCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCBAIzxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDsgI0AgwqBhbiBleGlzdGluZyB+Ly52bmMvcGFzc3dkIGZpbGUgZnJvbSBhbm90aGVyIFZOQyDC oCDCoCDCoCDCoCDCoEAjPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 OyAjQCDCoGFwcGxpY2F0aW9uIHdpbGwgd29yayBmaW5lIHRvby4gwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqBAIzxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDsgI0AgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgQCM8YnI+DQomZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7ICNAIMKgWW91IGNhbiBhbHNvIHVzZSB0aGUg LXBhc3N3ZGZpbGUgb3IgLXBhc3N3ZCBvcHRpb25zLiDCoCDCoCBAIzxicj4NCiZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgI0AgwqAobm90ZSAtcGFzc3dkIGlzIHVuc2FmZSBp ZiBsb2NhbCB1c2VycyBhcmUgbm90IHRydXN0ZWQpIMKgQCM8YnI+DQomZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7ICNAIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIEAj PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAjQCDCoE1ha2Ugc3Vy ZSBhbnkgLXJmYmF1dGggYW5kIC1wYXNzd2RmaWxlIHBhc3N3b3JkIGZpbGVzIMKgIMKgQCM8YnI+ DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7ICNAIMKgY2Fubm90IGJlIHJl YWQgYnkgdW50cnVzdGVkIHVzZXJzLiDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCBA Izxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgI0AgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgQCM8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7ICNAIMKgVXNlIHgxMXZuYyAtdXNlcHcgdG8gYXV0b21hdGljYWxseSB1c2UgeW91 ciDCoCDCoCDCoCDCoCDCoCDCoCDCoEAjPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0OyAjQCDCoH4vLnZuYy9wYXNzd2Qgb3Igfi8udm5jL3Bhc3N3ZGZpbGUgcGFzc3dv cmQgZmlsZXMuIMKgIMKgIMKgIEAjPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0OyAjQCDCoChhbmQgcHJvbXB0IHlvdSB0byBjcmVhdGUgfi8udm5jL3Bhc3N3ZCBpZiBu ZWl0aGVyIMKgIMKgIMKgIEAjPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0OyAjQCDCoGZpbGUgZXhpc3RzLikgwqBVbmRlciAtdXNlcHcsIHgxMXZuYyB3aWxsIGV4aXQg aWYgaXQgwqAgwqAgwqBAIzxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDsgI0AgwqBjYW5ub3QgZmluZCBhIHBhc3N3b3JkIHRvIHVzZS4gwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgQCM8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7ICNAIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIEAjPGJyPg0KJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAjQCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCBAIzxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgI0Ag wqBFdmVuIHdpdGggYSBwYXNzd29yZCwgdGhlIHN1YnNlcXVlbnQgVk5DIHRyYWZmaWMgaXMgwqAg wqAgwqBAIzxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgI0AgwqBz ZW50IGluIHRoZSBjbGVhci7CoCBDb25zaWRlciB0dW5uZWxsaW5nIHZpYSBzc2goMSk6IMKgIMKg IMKgQCM8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7ICNAIMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIEAjPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0OyAjQCDCoCDCoDxhIGhyZWY9Imh0dHA6Ly93d3cua2FybHJ1bmdlLmNvbS94 MTF2bmMvI3R1bm5lbGxpbmciIHJlbD0ibm9yZWZlcnJlciIgdGFyZ2V0PSJfYmxhbmsiPmh0dHA6 Ly93d3cua2FybHJ1bmdlLmNvbS94MTF2bmMvI3R1bm5lbGxpbmc8L2E+IMKgIMKgIMKgIMKgIMKg IMKgQCM8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7ICNAIMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIEAjPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0OyAjQCDCoE9yIHVzaW5nIHRoZSB4MTF2bmMgU1NMIG9wdGlvbnM6IC1zc2wg YW5kIC1zdHVubmVsIMKgIMKgIMKgIEAjPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0OyAjQCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCBAIzxicj4NCiZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgI0AgwqBQbGVhc2UgUmVhZCB0aGUgZG9j dW1lbnRhdGlvbiBmb3IgbW9yZSBpbmZvIGFib3V0IMKgIMKgIMKgIMKgQCM8YnI+DQomZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7ICNAIMKgcGFzc3dvcmRzLCBzZWN1cml0eSwg YW5kIGVuY3J5cHRpb24uIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIEAjPGJyPg0KJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAjQCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCBAIzxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsg I0AgwqAgwqA8YSBocmVmPSJodHRwOi8vd3d3LmthcmxydW5nZS5jb20veDExdm5jL2ZhcS5odG1s I2ZhcS1wYXNzd2QiIHJlbD0ibm9yZWZlcnJlciIgdGFyZ2V0PSJfYmxhbmsiPmh0dHA6Ly93d3cu a2FybHJ1bmdlLmNvbS94MTF2bmMvZmFxLmh0bWwjZmFxLXBhc3N3ZDwvYT4gwqAgwqBAIzxicj4N CiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgI0AgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgQCM8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7ICNAIMKgVG8gZGlzYWJsZSB0aGlzIHdhcm5pbmcgdXNlIHRoZSAtbm9wdyBvcHRpb24sIG9y IHB1dCDCoCDCoCBAIzxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsg I0AgwqAmIzM5O25vcHcmIzM5OyBvbiBhIGxpbmUgaW4geW91ciB+Ly54MTF2bmNyYyBmaWxlLiDC oCDCoCDCoCDCoCDCoCDCoCDCoCBAIzxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDsgI0AgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgQCM8YnI+DQomZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7ICNAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBA QEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAIzxicj4NCiZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDsgIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMj IyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0OyAwOS8wMy8yMDE4IDEyOjU4OjQxIHgxMXZuYyB2ZXJzaW9uOiAwLjku MTYgbGFzdG1vZDogMjAxOS0wMS0wNSDCoHBpZDogNDI0PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0OyAwOS8wMy8yMDE4IDEyOjU4OjQxIFhPcGVuRGlzcGxheSgmcXVv dDsmcXVvdDspIGZhaWxlZC48YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7IDA5LzAzLzIwMTggMTI6NTg6NDEgVHJ5aW5nIGFnYWluIHdpdGggWEFVVEhMT0NBTEhPU1RO QU1FPWxvY2FsaG9zdCAuLi48YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7IDA5LzAzLzIwMTggMTI6NTg6NDE8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7IDA5LzAzLzIwMTggMTI6NTg6NDEgKioqIFhPcGVuRGlzcGxheSBmYWlsZWQuIE5v IC1kaXNwbGF5IG9yIERJU1BMQVkuPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0OyAwOS8wMy8yMDE4IDEyOjU4OjQxICoqKiBUcnlpbmcgJnF1b3Q7OjAmcXVvdDsgaW4g NCBzZWNvbmRzLsKgIFByZXNzIEN0cmwtQyB0byBhYm9ydC48YnI+DQomZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IDA5LzAzLzIwMTggMTI6NTg6NDEgKioqIDEgMiAzIDQ8YnI+ DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IDA5LzAzLzIwMTggMTI6NTg6 NDUgWE9wZW5EaXNwbGF5KCZxdW90OzowJnF1b3Q7KSBmYWlsZWQuPGJyPg0KJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAwOS8wMy8yMDE4IDEyOjU4OjQ1IFRyeWluZyBhZ2Fp biB3aXRoIFhBVVRITE9DQUxIT1NUTkFNRT1sb2NhbGhvc3QgLi4uPGJyPg0KJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAwOS8wMy8yMDE4IDEyOjU4OjQ1IFhPcGVuRGlzcGxh eSgmcXVvdDs6MCZxdW90OykgZmFpbGVkLjxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDsgMDkvMDMvMjAxOCAxMjo1ODo0NSBUcnlpbmcgYWdhaW4gd2l0aCB1bnNldCBY QVVUSExPQ0FMSE9TVE5BTUUgLi4uPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0OyAwOS8wMy8yMDE4IDEyOjU4OjQ1PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsg MDkvMDMvMjAxOCAxMjo1ODo0NSAqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq Kio8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IDA5LzAzLzIwMTgg MTI6NTg6NDUgKioqIFhPcGVuRGlzcGxheSBmYWlsZWQgKDowKTxicj4NCiZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7ICoqKiB4MTF2bmMgd2FzIHVuYWJsZSB0byBvcGVuIHRoZSBYIERJU1BMQVk6ICZx dW90OzowJnF1b3Q7LCBpdCBjYW5ub3QgY29udGludWUuPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0OyAqKiogVGhlcmUgbWF5IGJlICZxdW90O1hsaWI6JnF1b3Q7IGVy cm9yIG1lc3NhZ2VzIGFib3ZlIHdpdGggZGV0YWlscyBhYm91dCB0aGUgZmFpbHVyZS48YnI+DQom Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBTb21lIHRpcHMgYW5kIGd1aWRlbGluZXM6PGJyPg0KJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDsgKiogQW4gWCBzZXJ2ZXIgKHRoZSBvbmUgeW91IHdpc2ggdG8g dmlldykgbXVzdCBiZSBydW5uaW5nIGJlZm9yZSB4MTF2bmMgaXM8YnI+DQomZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgc3RhcnRlZDogeDExdm5jIGRvZXMgbm90IHN0 YXJ0IHRoZSBYIHNlcnZlci4gwqAoaG93ZXZlciwgc2VlIHRoZSAtY3JlYXRlPGJyPg0KJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoG9wdGlvbiBpZiB0aGF0IGlzIHdo YXQgeW91IHJlYWxseSB3YW50KS48YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyAqKiBZb3Ug bXVzdCB1c2UgLWRpc3BsYXkgJmx0O2Rpc3AmZ3Q7LCAtT1ItIHNldCBhbmQgZXhwb3J0IHlvdXIg JERJU1BMQVk8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKg ZW52aXJvbm1lbnQgdmFyaWFibGUgdG8gcmVmZXIgdG8gdGhlIGRpc3BsYXkgb2YgdGhlIGRlc2ly ZWQgWCBzZXJ2ZXIuPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDC oC0gVXN1YWxseSB0aGUgZGlzcGxheSBpcyBzaW1wbHkgJnF1b3Q7OjAmcXVvdDsgKGluIGZhY3Qg eDExdm5jIHVzZXMgdGhpcyBpZiB5b3UgZm9yZ2V0PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0OyDCoCDCoHRvIHNwZWNpZnkgaXQpLCBidXQgaW4gc29tZSBtdWx0aS11 c2VyIHNpdHVhdGlvbnMgaXQgY291bGQgYmUgJnF1b3Q7OjEmcXVvdDssICZxdW90OzoyJnF1b3Q7 LDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqBvciBldmVu ICZxdW90OzoxMzcmcXVvdDsuwqAgQXNrIHlvdXIgYWRtaW5pc3RyYXRvciBvciBhIGd1cnUgaWYg eW91IGFyZSBoYXZpbmc8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 IMKgIMKgZGlmZmljdWx0eSBkZXRlcm1pbmluZyB3aGF0IHlvdXIgWCBESVNQTEFZIGlzLjxicj4N CiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7ICoqIE5leHQsIHlvdSBuZWVkIHRvIGhhdmUgc3VmZmlj aWVudCBwZXJtaXNzaW9ucyAoWGF1dGhvcml0eSk8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgdG8gY29ubmVjdCB0byB0aGUgWCBESVNQTEFZLiDCoCBIZXJl IGFyZSBzb21lIFRpcHM6PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAtIE9mdGVuLCB5 b3UganVzdCBuZWVkIHRvIHJ1biB4MTF2bmMgYXMgdGhlIHVzZXIgbG9nZ2VkIGludG8gdGhlIFgg c2Vzc2lvbi48YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKg U28gbWFrZSBzdXJlIHRvIGJlIHRoYXQgdXNlciB3aGVuIHlvdSB0eXBlIHgxMXZuYy48YnI+DQom Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgLSBCZWluZyByb290IGlzIHVz dWFsbHkgbm90IGVub3VnaCBiZWNhdXNlIHRoZSBpbmNvcnJlY3QgTUlULU1BR0lDLUNPT0tJRTxi cj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqBmaWxlIG1heSBi ZSBhY2Nlc3NlZC7CoCBUaGUgY29va2llIGZpbGUgY29udGFpbnMgdGhlIHNlY3JldCBrZXkgdGhh dDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqBhbGxvd3Mg eDExdm5jIHRvIGNvbm5lY3QgdG8gdGhlIGRlc2lyZWQgWCBESVNQTEFZLjxicj4NCiZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAtIFlvdSBjYW4gZXhwbGljaXRseSBpbmRp Y2F0ZSB3aGljaCBNSVQtTUFHSUMtQ09PS0lFIGZpbGUgc2hvdWxkIGJlIHVzZWQ8YnI+DQomZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgYnkgdGhlIC1hdXRoIG9wdGlv biwgZS5nLjo8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKg IMKgIMKgeDExdm5jIC1hdXRoIC9ob21lL3NvbWV1c2VyLy5YYXV0aG9yaXR5IC1kaXNwbGF5IDow PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCDCoCDCoHgx MXZuYyAtYXV0aCAvdG1wLy5nZG16bmRWbFIgLWRpc3BsYXkgOjA8YnI+DQomZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgeW91IG11c3QgaGF2ZSByZWFkIHBlcm1pc3Np b24gZm9yIHRoZSBhdXRoIGZpbGUuPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0OyDCoCDCoFNlZSBhbHNvICYjMzk7LWF1dGggZ3Vlc3MmIzM5OyBhbmQgJiMzOTstZmlu ZGF1dGgmIzM5OyBkaXNjdXNzZWQgYmVsb3cuPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsg KiogSWYgTk8gT05FIGlzIGxvZ2dlZCBpbnRvIGFuIFggc2Vzc2lvbiB5ZXQsIGJ1dCB0aGVyZSBp cyBhIGdyZWV0ZXIgbG9naW48YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7IMKgIMKgcHJvZ3JhbSBsaWtlICZxdW90O2dkbSZxdW90OywgJnF1b3Q7a2RtJnF1b3Q7LCAm cXVvdDt4ZG0mcXVvdDssIG9yICZxdW90O2R0bG9naW4mcXVvdDsgcnVubmluZywgeW91IHdpbGwg bmVlZDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqB0byBm aW5kIGFuZCB1c2UgdGhlIHJhdyBkaXNwbGF5IG1hbmFnZXIgTUlULU1BR0lDLUNPT0tJRSBmaWxl Ljxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqBTb21lIGV4 YW1wbGVzIGZvciB2YXJpb3VzIGRpc3BsYXkgbWFuYWdlcnM6PGJyPg0KJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDsgwqAgwqAgwqBnZG06IMKgIMKgIC1hdXRoIC92YXIvZ2RtLzowLlhhdXRoPGJyPg0K Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCDCoCDCoCDCoCDCoCDC oCAtYXV0aCAvdmFyL2xpYi9nZG0vOjAuWGF1dGg8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIMKga2RtOiDCoCDCoCAtYXV0aCAvdmFyL2xpYi9rZG0vQTow LWNyV2s3Mjxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqAg wqAgwqAgwqAgwqAgwqAgLWF1dGggL3Zhci9ydW4veGF1dGgvQTowLWNyV2s3Mjxicj4NCiZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqAgwqB4ZG06IMKgIMKgIC1hdXRo IC92YXIvbGliL3hkbS9hdXRoZGlyL2F1dGhmaWxlcy9BOjAtWFF2YUprPGJyPg0KJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCDCoGR0bG9naW46IC1hdXRoIC92YXIv ZHQvQTowLVVnYWFYYTxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8 YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgU29tZXRpbWVz IHRoZSBjb21tYW5kICZxdW90O3BzIHd3d3dhdXggfCBncmVwIGF1dGgmcXVvdDsgY2FuIHJldmVh bCB0aGUgZmlsZSBsb2NhdGlvbi48YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoFN0 YXJ0aW5nIHdpdGggeDExdm5jIDAuOS45IHlvdSBjYW4gaGF2ZSBpdCB0cnkgdG8gZ3Vlc3MgYnkg dXNpbmc6PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqAgwqAgwqAgwqAgwqAgwqAg LWF1dGggZ3Vlc3M8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJy Pg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoChzZWUgYWxzbyB0 aGUgeDExdm5jIC1maW5kYXV0aCBvcHRpb24uKTxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 IMKgIMKgT25seSByb290IHdpbGwgaGF2ZSByZWFkIHBlcm1pc3Npb24gZm9yIHRoZSBmaWxlLCBh bmQgc28geDExdm5jIG11c3QgYmUgcnVuPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0OyDCoCDCoGFzIHJvb3QgKG9yIGNvcHkgaXQpLsKgIFRoZSByYW5kb20gY2hhcmFj dGVycyBpbiB0aGUgZmlsZW5hbWVzIHdpbGwgb2YgY291cnNlPGJyPg0KJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoGNoYW5nZSBhbmQgdGhlIGRpcmVjdG9yeSB0aGUg Y29va2llIGZpbGUgcmVzaWRlcyBpbiBpcyBzeXN0ZW0gZGVwZW5kZW50Ljxicj4NCiZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7IFNlZSBhbHNvOiA8YSBocmVmPSJodHRwOi8vd3d3LmthcmxydW5nZS5j b20veDExdm5jL2ZhcS5odG1sIiByZWw9Im5vcmVmZXJyZXIiIHRhcmdldD0iX2JsYW5rIj5odHRw Oi8vd3d3LmthcmxydW5nZS5jb20veDExdm5jL2ZhcS5odG1sPC9hPjxicj4NCiZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7IFJlZ2FyZHMsPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0OyBWaXB1bCBLdW1hcjxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IE9uIFRodSwg Tm92IDMsIDIwMjIgYXQgMTA6MjcgUE0gVmlwdWwgU3VuZWphICZsdDs8YSBocmVmPSJtYWlsdG86 dnN1bmVqYTYzQGdtYWlsLmNvbSIgdGFyZ2V0PSJfYmxhbmsiPnZzdW5lamE2M0BnbWFpbC5jb208 L2E+Jmd0OyB3cm90ZTo8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqBIaSBTdGVmYW5vLDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDsgVGhhbmtzITxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IEkgdXNlZCB4ZW4t Z3Vlc3QtaW1hZ2UtbWluaW1hbChzaW1wbGUgY29uc29sZSBiYXNlZCBpbWFnZSkgYXMgYSBndWVz dCB3aXRoIGZiY29uICZhbXA7PGJyPg0KJmd0O8KgIMKgIMKgIMKgZmJkZXY8YnI+DQomZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBlbmFibGVkIGluPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKga2VybmVsPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Y29uZmlndXJhdGlvbnMgYnV0PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg c3RpbGw8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IHRoZSBzYW1l IGVycm9yIGNhbiYjMzk7dCBvcGVuIHRoZSBkaXNwbGF5Ljxicj4NCiZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDsgYmVsb3cgYXJlIHRoZSBvdXRjb21lIG9mICZxdW90O3hlbnN0 b3JlLWxzJnF1b3Q7Ojxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8 YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IHJvb3RAcmFzcGJlcnJ5 cGk0LTY0On4vZ3Vlc3QxIyB4ZW5zdG9yZS1sczxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDsgdG9vbCA9ICZxdW90OyZxdW90Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDsgwqB4ZW5zdG9yZWQgPSAmcXVvdDsmcXVvdDs8YnI+DQomZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IGxvY2FsID0gJnF1b3Q7JnF1b3Q7PGJy Pg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoGRvbWFpbiA9ICZxdW90 OyZxdW90Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgMCA9 ICZxdW90OyZxdW90Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsg wqAgwqBjb250cm9sID0gJnF1b3Q7JnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0OyDCoCDCoCBmZWF0dXJlLXBvd2Vyb2ZmID0gJnF1b3Q7MSZxdW90Ozxicj4N CiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqAgZmVhdHVyZS1yZWJv b3QgPSAmcXVvdDsxJnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0OyDCoCDCoGRvbWlkID0gJnF1b3Q7MCZxdW90Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDsgwqAgwqBuYW1lID0gJnF1b3Q7RG9tYWluLTAmcXVvdDs8YnI+DQom Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgZGV2aWNlLW1vZGVsID0g JnF1b3Q7JnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDC oCDCoCAwID0gJnF1b3Q7JnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0OyDCoCDCoCDCoGJhY2tlbmRzID0gJnF1b3Q7JnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCDCoCBjb25zb2xlID0gJnF1b3Q7JnF1b3Q7 PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCDCoCB2a2Jk ID0gJnF1b3Q7JnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 OyDCoCDCoCDCoCB2ZmIgPSAmcXVvdDsmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIMKgIHFuaWMgPSAmcXVvdDsmcXVvdDs8YnI+DQomZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIMKgc3RhdGUgPSAmcXVvdDtydW5u aW5nJnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDC oCAxID0gJnF1b3Q7JnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0OyDCoCDCoCDCoGJhY2tlbmRzID0gJnF1b3Q7JnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCDCoCBjb25zb2xlID0gJnF1b3Q7JnF1b3Q7PGJy Pg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCDCoCB2a2JkID0g JnF1b3Q7JnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDC oCDCoCDCoCB2ZmIgPSAmcXVvdDsmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7IMKgIMKgIMKgIHFuaWMgPSAmcXVvdDsmcXVvdDs8YnI+DQomZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIMKgc3RhdGUgPSAmcXVvdDtydW5uaW5n JnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoGJh Y2tlbmQgPSAmcXVvdDsmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7IMKgIMKgIHZiZCA9ICZxdW90OyZxdW90Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDsgwqAgwqAgwqAxID0gJnF1b3Q7JnF1b3Q7PGJyPg0KJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCDCoCA1MTcxMiA9ICZxdW90OyZxdW90 Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqAgwqAgwqBm cm9udGVuZCA9ICZxdW90Oy9sb2NhbC9kb21haW4vMS9kZXZpY2UvdmJkLzUxNzEyJnF1b3Q7PGJy Pg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCDCoCDCoHBhcmFt cyA9ICZxdW90Oy9ob21lL3Jvb3QvZ3Vlc3QyL3hlbi1ndWVzdC1pbWFnZS1taW5pbWFsLXJhc3Bi ZXJyeXBpNC02NC5leHQzJnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0OyDCoCDCoCDCoCDCoHNjcmlwdCA9ICZxdW90Oy9ldGMveGVuL3NjcmlwdHMvYmxvY2sm cXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIMKg IMKgZnJvbnRlbmQtaWQgPSAmcXVvdDsxJnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCDCoCDCoG9ubGluZSA9ICZxdW90OzEmcXVvdDs8YnI+DQom Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIMKgIMKgcmVtb3ZhYmxl ID0gJnF1b3Q7MCZxdW90Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDsgwqAgwqAgwqAgwqBib290YWJsZSA9ICZxdW90OzEmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIMKgIMKgc3RhdGUgPSAmcXVvdDs0JnF1b3Q7 PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCDCoCDCoGRl diA9ICZxdW90O3h2ZGEmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7IMKgIMKgIMKgIMKgdHlwZSA9ICZxdW90O3BoeSZxdW90Ozxicj4NCiZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqAgwqAgwqBtb2RlID0gJnF1b3Q7dyZxdW90 Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqAgwqAgwqBk ZXZpY2UtdHlwZSA9ICZxdW90O2Rpc2smcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIMKgIMKgZGlzY2FyZC1lbmFibGUgPSAmcXVvdDsxJnF1b3Q7 PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCDCoCDCoGZl YXR1cmUtbWF4LWluZGlyZWN0LXNlZ21lbnRzID0gJnF1b3Q7MjU2JnF1b3Q7PGJyPg0KJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCDCoCDCoG11bHRpLXF1ZXVlLW1h eC1xdWV1ZXMgPSAmcXVvdDs0JnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0OyDCoCDCoCDCoCDCoG1heC1yaW5nLXBhZ2Utb3JkZXIgPSAmcXVvdDs0JnF1b3Q7 PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCDCoCDCoG5v ZGUgPSAmcXVvdDsvZGV2L2xvb3AwJnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0OyDCoCDCoCDCoCDCoHBoeXNpY2FsLWRldmljZSA9ICZxdW90Ozc6MCZxdW90 Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqAgwqAgwqBw aHlzaWNhbC1kZXZpY2UtcGF0aCA9ICZxdW90Oy9kZXYvbG9vcDAmcXVvdDs8YnI+DQomZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIMKgIMKgaG90cGx1Zy1zdGF0dXMg PSAmcXVvdDtjb25uZWN0ZWQmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7IMKgIMKgIMKgIMKgZmVhdHVyZS1mbHVzaC1jYWNoZSA9ICZxdW90OzEmcXVvdDs8 YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIMKgIMKgZGlz Y2FyZC1ncmFudWxhcml0eSA9ICZxdW90OzQwOTYmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIMKgIMKgZGlzY2FyZC1hbGlnbm1lbnQgPSAmcXVv dDswJnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDC oCDCoCDCoGRpc2NhcmQtc2VjdXJlID0gJnF1b3Q7MCZxdW90Ozxicj4NCiZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqAgwqAgwqBmZWF0dXJlLWRpc2NhcmQgPSAmcXVv dDsxJnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDC oCDCoCDCoGZlYXR1cmUtYmFycmllciA9ICZxdW90OzEmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIMKgIMKgZmVhdHVyZS1wZXJzaXN0ZW50ID0g JnF1b3Q7MSZxdW90Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsg wqAgwqAgwqAgwqBzZWN0b3JzID0gJnF1b3Q7MTc5NDA0OCZxdW90Ozxicj4NCiZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqAgwqAgwqBpbmZvID0gJnF1b3Q7MCZxdW90 Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqAgwqAgwqBz ZWN0b3Itc2l6ZSA9ICZxdW90OzUxMiZxdW90Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDsgwqAgwqAgwqAgwqBwaHlzaWNhbC1zZWN0b3Itc2l6ZSA9ICZxdW90OzUx MiZxdW90Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqAg dmZiID0gJnF1b3Q7JnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0OyDCoCDCoCDCoDEgPSAmcXVvdDsmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIMKgIDAgPSAmcXVvdDsmcXVvdDs8YnI+DQomZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIMKgIMKgZnJvbnRlbmQgPSAmcXVvdDsv bG9jYWwvZG9tYWluLzEvZGV2aWNlL3ZmYi8wJnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCDCoCDCoGZyb250ZW5kLWlkID0gJnF1b3Q7MSZxdW90 Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqAgwqAgwqBv bmxpbmUgPSAmcXVvdDsxJnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0OyDCoCDCoCDCoCDCoHN0YXRlID0gJnF1b3Q7NCZxdW90Ozxicj4NCiZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqAgwqAgwqB2bmMgPSAmcXVvdDsxJnF1b3Q7 PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCDCoCDCoHZu Y2xpc3RlbiA9ICZxdW90OzEyNy4wLjAuMSZxdW90Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDsgwqAgwqAgwqAgwqB2bmNkaXNwbGF5ID0gJnF1b3Q7MCZxdW90Ozxi cj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqAgwqAgwqB2bmN1 bnVzZWQgPSAmcXVvdDsxJnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0OyDCoCDCoCDCoCDCoHNkbCA9ICZxdW90OzAmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIMKgIMKgb3BlbmdsID0gJnF1b3Q7MCZxdW90 Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqAgwqAgwqBm ZWF0dXJlLXJlc2l6ZSA9ICZxdW90OzEmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIMKgIMKgaG90cGx1Zy1zdGF0dXMgPSAmcXVvdDtjb25uZWN0 ZWQmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKg IMKgIMKgcmVxdWVzdC11cGRhdGUgPSAmcXVvdDsxJnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCB2a2JkID0gJnF1b3Q7JnF1b3Q7PGJyPg0KJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCDCoDEgPSAmcXVvdDsmcXVv dDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIMKgIDAg PSAmcXVvdDsmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 IMKgIMKgIMKgIMKgZnJvbnRlbmQgPSAmcXVvdDsvbG9jYWwvZG9tYWluLzEvZGV2aWNlL3ZrYmQv MCZxdW90Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqAg wqAgwqBmcm9udGVuZC1pZCA9ICZxdW90OzEmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIMKgIMKgb25saW5lID0gJnF1b3Q7MSZxdW90Ozxicj4N CiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqAgwqAgwqBzdGF0ZSA9 ICZxdW90OzQmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 IMKgIMKgIMKgIMKgZmVhdHVyZS1hYnMtcG9pbnRlciA9ICZxdW90OzEmcXVvdDs8YnI+DQomZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIMKgIMKgZmVhdHVyZS1yYXct cG9pbnRlciA9ICZxdW90OzEmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7IMKgIMKgIMKgIMKgaG90cGx1Zy1zdGF0dXMgPSAmcXVvdDtjb25uZWN0ZWQmcXVv dDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIGNvbnNv bGUgPSAmcXVvdDsmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7IMKgIMKgIMKgMSA9ICZxdW90OyZxdW90Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDsgwqAgwqAgwqAgMCA9ICZxdW90OyZxdW90Ozxicj4NCiZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqAgwqAgwqBmcm9udGVuZCA9ICZxdW90Oy9s b2NhbC9kb21haW4vMS9jb25zb2xlJnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0OyDCoCDCoCDCoCDCoGZyb250ZW5kLWlkID0gJnF1b3Q7MSZxdW90Ozxicj4N CiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqAgwqAgwqBvbmxpbmUg PSAmcXVvdDsxJnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 OyDCoCDCoCDCoCDCoHN0YXRlID0gJnF1b3Q7MSZxdW90Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqAgwqAgwqBwcm90b2NvbCA9ICZxdW90O3Z0MTAwJnF1 b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCB2aWYg PSAmcXVvdDsmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 IMKgIMKgIMKgMSA9ICZxdW90OyZxdW90Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDsgwqAgwqAgwqAgMCA9ICZxdW90OyZxdW90Ozxicj4NCiZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqAgwqAgwqBmcm9udGVuZCA9ICZxdW90Oy9sb2Nh bC9kb21haW4vMS9kZXZpY2UvdmlmLzAmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIMKgIMKgZnJvbnRlbmQtaWQgPSAmcXVvdDsxJnF1b3Q7PGJy Pg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCDCoCDCoG9ubGlu ZSA9ICZxdW90OzEmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7IMKgIMKgIMKgIMKgc3RhdGUgPSAmcXVvdDs0JnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCDCoCDCoHNjcmlwdCA9ICZxdW90Oy9ldGMveGVu L3NjcmlwdHMvdmlmLWJyaWRnZSZxdW90Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDsgwqAgwqAgwqAgwqBtYWMgPSAmcXVvdDtlNDo1ZjowMTpjZDo3YjpkZCZxdW90 Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqAgwqAgwqBi cmlkZ2UgPSAmcXVvdDt4ZW5icjAmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7IMKgIMKgIMKgIMKgaGFuZGxlID0gJnF1b3Q7MCZxdW90Ozxicj4NCiZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqAgwqAgwqB0eXBlID0gJnF1b3Q7 dmlmJnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDC oCDCoCDCoGhvdHBsdWctc3RhdHVzID0gJnF1b3Q7Y29ubmVjdGVkJnF1b3Q7PGJyPg0KJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCDCoCDCoGZlYXR1cmUtc2cgPSAm cXVvdDsxJnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDC oCDCoCDCoCDCoGZlYXR1cmUtZ3NvLXRjcHY0ID0gJnF1b3Q7MSZxdW90Ozxicj4NCiZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqAgwqAgwqBmZWF0dXJlLWdzby10Y3B2 NiA9ICZxdW90OzEmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7IMKgIMKgIMKgIMKgZmVhdHVyZS1pcHY2LWNzdW0tb2ZmbG9hZCA9ICZxdW90OzEmcXVvdDs8 YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIMKgIMKgZmVh dHVyZS1yeC1jb3B5ID0gJnF1b3Q7MSZxdW90Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDsgwqAgwqAgwqAgwqBmZWF0dXJlLXhkcC1oZWFkcm9vbSA9ICZxdW90OzEm cXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIMKg IMKgZmVhdHVyZS1yeC1mbGlwID0gJnF1b3Q7MCZxdW90Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqAgwqAgwqBmZWF0dXJlLW11bHRpY2FzdC1jb250cm9s ID0gJnF1b3Q7MSZxdW90Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDsgwqAgwqAgwqAgwqBmZWF0dXJlLWR5bmFtaWMtbXVsdGljYXN0LWNvbnRyb2wgPSAmcXVvdDsx JnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCDC oCDCoGZlYXR1cmUtc3BsaXQtZXZlbnQtY2hhbm5lbHMgPSAmcXVvdDsxJnF1b3Q7PGJyPg0KJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCDCoCDCoG11bHRpLXF1ZXVl LW1heC1xdWV1ZXMgPSAmcXVvdDs0JnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0OyDCoCDCoCDCoCDCoGZlYXR1cmUtY3RybC1yaW5nID0gJnF1b3Q7MSZxdW90 Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgMSA9ICZxdW90 OyZxdW90Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqB2 bSA9ICZxdW90Oy92bS9kODFlYzVhOS01YmY5LTRmMmItODllOC0wZjYwZDZkYTk0OGYmcXVvdDs8 YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgbmFtZSA9ICZx dW90O2d1ZXN0MiZxdW90Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDsgwqAgwqBjcHUgPSAmcXVvdDsmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7IMKgIMKgIDAgPSAmcXVvdDsmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIMKgYXZhaWxhYmlsaXR5ID0gJnF1b3Q7b25saW5l JnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCAx ID0gJnF1b3Q7JnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 OyDCoCDCoCDCoGF2YWlsYWJpbGl0eSA9ICZxdW90O29ubGluZSZxdW90Ozxicj4NCiZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqBtZW1vcnkgPSAmcXVvdDsmcXVvdDs8 YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIHN0YXRpYy1t YXggPSAmcXVvdDsyMDk3MTUyJnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0OyDCoCDCoCB0YXJnZXQgPSAmcXVvdDsyMDk3MTUyJnF1b3Q7PGJyPg0KJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCB2aWRlb3JhbSA9ICZxdW90OzAm cXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgZGV2 aWNlID0gJnF1b3Q7JnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0OyDCoCDCoCBzdXNwZW5kID0gJnF1b3Q7JnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCDCoGV2ZW50LWNoYW5uZWwgPSAmcXVvdDsmcXVvdDs8 YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIHZiZCA9ICZx dW90OyZxdW90Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAg wqAgwqA1MTcxMiA9ICZxdW90OyZxdW90Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDsgwqAgwqAgwqAgYmFja2VuZCA9ICZxdW90Oy9sb2NhbC9kb21haW4vMC9iYWNr ZW5kL3ZiZC8xLzUxNzEyJnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0OyDCoCDCoCDCoCBiYWNrZW5kLWlkID0gJnF1b3Q7MCZxdW90Ozxicj4NCiZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqAgwqAgc3RhdGUgPSAmcXVvdDs0JnF1 b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCDCoCB2 aXJ0dWFsLWRldmljZSA9ICZxdW90OzUxNzEyJnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCDCoCBkZXZpY2UtdHlwZSA9ICZxdW90O2Rpc2smcXVv dDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIMKgIG11 bHRpLXF1ZXVlLW51bS1xdWV1ZXMgPSAmcXVvdDsyJnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCDCoCBxdWV1ZS0wID0gJnF1b3Q7JnF1b3Q7PGJy Pg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCDCoCDCoHJpbmct cmVmID0gJnF1b3Q7OCZxdW90Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDsgwqAgwqAgwqAgwqBldmVudC1jaGFubmVsID0gJnF1b3Q7NCZxdW90Ozxicj4NCiZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqAgwqAgcXVldWUtMSA9ICZxdW90 OyZxdW90Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqAg wqAgwqByaW5nLXJlZiA9ICZxdW90OzkmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIMKgIMKgZXZlbnQtY2hhbm5lbCA9ICZxdW90OzUmcXVvdDs8 YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIMKgIHByb3Rv Y29sID0gJnF1b3Q7YXJtLWFiaSZxdW90Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDsgwqAgwqAgwqAgZmVhdHVyZS1wZXJzaXN0ZW50ID0gJnF1b3Q7MSZxdW90Ozxi cj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqAgdmZiID0gJnF1 b3Q7JnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDC oCDCoDAgPSAmcXVvdDsmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7IMKgIMKgIMKgIGJhY2tlbmQgPSAmcXVvdDsvbG9jYWwvZG9tYWluLzAvYmFja2VuZC92 ZmIvMS8wJnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDC oCDCoCDCoCBiYWNrZW5kLWlkID0gJnF1b3Q7MCZxdW90Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqAgwqAgc3RhdGUgPSAmcXVvdDs0JnF1b3Q7PGJyPg0K Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCDCoCBwYWdlLXJlZiA9 ICZxdW90OzI3NTAyMiZxdW90Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDsgwqAgwqAgwqAgZXZlbnQtY2hhbm5lbCA9ICZxdW90OzMmcXVvdDs8YnI+DQomZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIMKgIHByb3RvY29sID0gJnF1b3Q7 YXJtLWFiaSZxdW90Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsg wqAgwqAgwqAgZmVhdHVyZS11cGRhdGUgPSAmcXVvdDsxJnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCB2a2JkID0gJnF1b3Q7JnF1b3Q7PGJyPg0K Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCDCoDAgPSAmcXVvdDsm cXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIMKg IGJhY2tlbmQgPSAmcXVvdDsvbG9jYWwvZG9tYWluLzAvYmFja2VuZC92a2JkLzEvMCZxdW90Ozxi cj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqAgwqAgYmFja2Vu ZC1pZCA9ICZxdW90OzAmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7IMKgIMKgIMKgIHN0YXRlID0gJnF1b3Q7NCZxdW90Ozxicj4NCiZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqAgwqAgcmVxdWVzdC1hYnMtcG9pbnRlciA9ICZx dW90OzEmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKg IMKgIMKgIHBhZ2UtcmVmID0gJnF1b3Q7Mjc1MzIyJnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCDCoCBwYWdlLWdyZWYgPSAmcXVvdDsxMjg0JnF1 b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCDCoCBl dmVudC1jaGFubmVsID0gJnF1b3Q7MTAmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIHZpZiA9ICZxdW90OyZxdW90Ozxicj4NCiZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqAgwqAwID0gJnF1b3Q7JnF1b3Q7PGJyPg0K Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCDCoCBiYWNrZW5kID0g JnF1b3Q7L2xvY2FsL2RvbWFpbi8wL2JhY2tlbmQvdmlmLzEvMCZxdW90Ozxicj4NCiZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqAgwqAgYmFja2VuZC1pZCA9ICZxdW90 OzAmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKg IMKgIHN0YXRlID0gJnF1b3Q7NCZxdW90Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDsgwqAgwqAgwqAgaGFuZGxlID0gJnF1b3Q7MCZxdW90Ozxicj4NCiZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqAgwqAgbWFjID0gJnF1b3Q7ZTQ6NWY6 MDE6Y2Q6N2I6ZGQmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7IMKgIMKgIMKgIG10dSA9ICZxdW90OzE1MDAmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIMKgIHhkcC1oZWFkcm9vbSA9ICZxdW90OzAmcXVv dDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIMKgIG11 bHRpLXF1ZXVlLW51bS1xdWV1ZXMgPSAmcXVvdDsyJnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCDCoCBxdWV1ZS0wID0gJnF1b3Q7JnF1b3Q7PGJy Pg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCDCoCDCoHR4LXJp bmctcmVmID0gJnF1b3Q7MTI4MCZxdW90Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDsgwqAgwqAgwqAgwqByeC1yaW5nLXJlZiA9ICZxdW90OzEyODEmcXVvdDs8YnI+ DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIMKgIMKgZXZlbnQt Y2hhbm5lbC10eCA9ICZxdW90OzYmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7IMKgIMKgIMKgIMKgZXZlbnQtY2hhbm5lbC1yeCA9ICZxdW90OzcmcXVvdDs8 YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIMKgIHF1ZXVl LTEgPSAmcXVvdDsmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7IMKgIMKgIMKgIMKgdHgtcmluZy1yZWYgPSAmcXVvdDsxMjgyJnF1b3Q7PGJyPg0KJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCDCoCDCoHJ4LXJpbmctcmVmID0g JnF1b3Q7MTI4MyZxdW90Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDsgwqAgwqAgwqAgwqBldmVudC1jaGFubmVsLXR4ID0gJnF1b3Q7OCZxdW90Ozxicj4NCiZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqAgwqAgwqBldmVudC1jaGFubmVs LXJ4ID0gJnF1b3Q7OSZxdW90Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDsgwqAgwqAgwqAgcmVxdWVzdC1yeC1jb3B5ID0gJnF1b3Q7MSZxdW90Ozxicj4NCiZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqAgwqAgZmVhdHVyZS1yeC1ub3Rp ZnkgPSAmcXVvdDsxJnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0OyDCoCDCoCDCoCBmZWF0dXJlLXNnID0gJnF1b3Q7MSZxdW90Ozxicj4NCiZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqAgwqAgZmVhdHVyZS1nc28tdGNwdjQgPSAm cXVvdDsxJnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDC oCDCoCDCoCBmZWF0dXJlLWdzby10Y3B2NiA9ICZxdW90OzEmcXVvdDs8YnI+DQomZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIMKgIGZlYXR1cmUtaXB2Ni1jc3VtLW9m ZmxvYWQgPSAmcXVvdDsxJnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0OyDCoCDCoGNvbnRyb2wgPSAmcXVvdDsmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIHNodXRkb3duID0gJnF1b3Q7JnF1b3Q7PGJyPg0K Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCBmZWF0dXJlLXBvd2Vy b2ZmID0gJnF1b3Q7MSZxdW90Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDsgwqAgwqAgZmVhdHVyZS1yZWJvb3QgPSAmcXVvdDsxJnF1b3Q7PGJyPg0KJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCBmZWF0dXJlLXN1c3BlbmQgPSAmcXVv dDsmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKg IHN5c3JxID0gJnF1b3Q7JnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0OyDCoCDCoCBwbGF0Zm9ybS1mZWF0dXJlLW11bHRpcHJvY2Vzc29yLXN1c3BlbmQgPSAm cXVvdDsxJnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDC oCDCoCBwbGF0Zm9ybS1mZWF0dXJlLXhzX3Jlc2V0X3dhdGNoZXMgPSAmcXVvdDsxJnF1b3Q7PGJy Pg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoGRhdGEgPSAmcXVv dDsmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKg ZHJpdmVycyA9ICZxdW90OyZxdW90Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDsgwqAgwqBmZWF0dXJlID0gJnF1b3Q7JnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoGF0dHIgPSAmcXVvdDsmcXVvdDs8YnI+DQomZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgZXJyb3IgPSAmcXVvdDsmcXVv dDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgZG9taWQg PSAmcXVvdDsxJnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 OyDCoCDCoHN0b3JlID0gJnF1b3Q7JnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0OyDCoCDCoCBwb3J0ID0gJnF1b3Q7MSZxdW90Ozxicj4NCiZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqAgcmluZy1yZWYgPSAmcXVvdDsyMzM0NzMm cXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgY29u c29sZSA9ICZxdW90OyZxdW90Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDsgwqAgwqAgYmFja2VuZCA9ICZxdW90Oy9sb2NhbC9kb21haW4vMC9iYWNrZW5kL2NvbnNv bGUvMS8wJnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDC oCDCoCBiYWNrZW5kLWlkID0gJnF1b3Q7MCZxdW90Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDsgwqAgwqAgbGltaXQgPSAmcXVvdDsxMDQ4NTc2JnF1b3Q7PGJyPg0K Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCB0eXBlID0gJnF1b3Q7 eGVuY29uc29sZWQmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7IMKgIMKgIG91dHB1dCA9ICZxdW90O3B0eSZxdW90Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqAgdHR5ID0gJnF1b3Q7L2Rldi9wdHMvMSZxdW90Ozxi cj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqAgcG9ydCA9ICZx dW90OzImcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKg IMKgIHJpbmctcmVmID0gJnF1b3Q7MjMzNDcyJnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCB2bmMtbGlzdGVuID0gJnF1b3Q7MTI3LjAuMC4xJnF1 b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCB2bmMt cG9ydCA9ICZxdW90OzU5MDAmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7IMKgIMKgaW1hZ2UgPSAmcXVvdDsmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIGRldmljZS1tb2RlbC1waWQgPSAmcXVvdDs3ODgm cXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IHZtID0gJnF1 b3Q7JnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoGQ4 MWVjNWE5LTViZjktNGYyYi04OWU4LTBmNjBkNmRhOTQ4ZiA9ICZxdW90OyZxdW90Ozxicj4NCiZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgbmFtZSA9ICZxdW90O2d1ZXN0 MiZxdW90Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgdXVp ZCA9ICZxdW90O2Q4MWVjNWE5LTViZjktNGYyYi04OWU4LTBmNjBkNmRhOTQ4ZiZxdW90Ozxicj4N CiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgc3RhcnRfdGltZSA9ICZx dW90OzE1MjA2MDAyNzQuMjcmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7IGxpYnhsID0gJnF1b3Q7JnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0OyDCoDEgPSAmcXVvdDsmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIGRldmljZSA9ICZxdW90OyZxdW90Ozxicj4NCiZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqB2YmQgPSAmcXVvdDsmcXVvdDs8 YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIDUxNzEyID0g JnF1b3Q7JnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDC oCDCoCDCoGZyb250ZW5kID0gJnF1b3Q7L2xvY2FsL2RvbWFpbi8xL2RldmljZS92YmQvNTE3MTIm cXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIMKg YmFja2VuZCA9ICZxdW90Oy9sb2NhbC9kb21haW4vMC9iYWNrZW5kL3ZiZC8xLzUxNzEyJnF1b3Q7 PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCDCoHBhcmFt cyA9ICZxdW90Oy9ob21lL3Jvb3QvZ3Vlc3QyL3hlbi1ndWVzdC1pbWFnZS1taW5pbWFsLXJhc3Bi ZXJyeXBpNC02NC5leHQzJnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0OyDCoCDCoCDCoHNjcmlwdCA9ICZxdW90Oy9ldGMveGVuL3NjcmlwdHMvYmxvY2smcXVv dDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIMKgZnJv bnRlbmQtaWQgPSAmcXVvdDsxJnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0OyDCoCDCoCDCoG9ubGluZSA9ICZxdW90OzEmcXVvdDs8YnI+DQomZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIMKgcmVtb3ZhYmxlID0gJnF1b3Q7MCZx dW90Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqAgwqBi b290YWJsZSA9ICZxdW90OzEmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7IMKgIMKgIMKgc3RhdGUgPSAmcXVvdDsxJnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCDCoGRldiA9ICZxdW90O3h2ZGEmcXVvdDs8 YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIMKgdHlwZSA9 ICZxdW90O3BoeSZxdW90Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDsgwqAgwqAgwqBtb2RlID0gJnF1b3Q7dyZxdW90Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDsgwqAgwqAgwqBkZXZpY2UtdHlwZSA9ICZxdW90O2Rpc2smcXVvdDs8 YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIMKgZGlzY2Fy ZC1lbmFibGUgPSAmcXVvdDsxJnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0OyDCoCDCoHZmYiA9ICZxdW90OyZxdW90Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqAgMCA9ICZxdW90OyZxdW90Ozxicj4NCiZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqAgwqBmcm9udGVuZCA9ICZxdW90Oy9s b2NhbC9kb21haW4vMS9kZXZpY2UvdmZiLzAmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIMKgYmFja2VuZCA9ICZxdW90Oy9sb2NhbC9kb21haW4v MC9iYWNrZW5kL3ZmYi8xLzAmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7IMKgIMKgIMKgZnJvbnRlbmQtaWQgPSAmcXVvdDsxJnF1b3Q7PGJyPg0KJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCDCoG9ubGluZSA9ICZxdW90OzEm cXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIMKg c3RhdGUgPSAmcXVvdDsxJnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0OyDCoCDCoCDCoHZuYyA9ICZxdW90OzEmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIMKgdm5jbGlzdGVuID0gJnF1b3Q7MTI3LjAuMC4x JnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCDC oHZuY2Rpc3BsYXkgPSAmcXVvdDswJnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0OyDCoCDCoCDCoHZuY3VudXNlZCA9ICZxdW90OzEmcXVvdDs8YnI+DQomZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIMKgc2RsID0gJnF1b3Q7MCZx dW90Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqAgwqBv cGVuZ2wgPSAmcXVvdDswJnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0OyDCoCDCoHZrYmQgPSAmcXVvdDsmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIDAgPSAmcXVvdDsmcXVvdDs8YnI+DQomZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIMKgZnJvbnRlbmQgPSAmcXVvdDsvbG9j YWwvZG9tYWluLzEvZGV2aWNlL3ZrYmQvMCZxdW90Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDsgwqAgwqAgwqBiYWNrZW5kID0gJnF1b3Q7L2xvY2FsL2RvbWFpbi8w L2JhY2tlbmQvdmtiZC8xLzAmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7IMKgIMKgIMKgZnJvbnRlbmQtaWQgPSAmcXVvdDsxJnF1b3Q7PGJyPg0KJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCDCoG9ubGluZSA9ICZxdW90OzEm cXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIMKg c3RhdGUgPSAmcXVvdDsxJnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0OyDCoCDCoGNvbnNvbGUgPSAmcXVvdDsmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIDAgPSAmcXVvdDsmcXVvdDs8YnI+DQomZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIMKgZnJvbnRlbmQgPSAmcXVvdDsv bG9jYWwvZG9tYWluLzEvY29uc29sZSZxdW90Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDsgwqAgwqAgwqBiYWNrZW5kID0gJnF1b3Q7L2xvY2FsL2RvbWFpbi8wL2Jh Y2tlbmQvY29uc29sZS8xLzAmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7IMKgIMKgIMKgZnJvbnRlbmQtaWQgPSAmcXVvdDsxJnF1b3Q7PGJyPg0KJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCDCoG9ubGluZSA9ICZxdW90OzEm cXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIMKg c3RhdGUgPSAmcXVvdDsxJnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0OyDCoCDCoCDCoHByb3RvY29sID0gJnF1b3Q7dnQxMDAmcXVvdDs8YnI+DQomZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgdmlmID0gJnF1b3Q7JnF1b3Q7PGJy Pg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCAwID0gJnF1b3Q7 JnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCDC oGZyb250ZW5kID0gJnF1b3Q7L2xvY2FsL2RvbWFpbi8xL2RldmljZS92aWYvMCZxdW90Ozxicj4N CiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqAgwqBiYWNrZW5kID0g JnF1b3Q7L2xvY2FsL2RvbWFpbi8wL2JhY2tlbmQvdmlmLzEvMCZxdW90Ozxicj4NCiZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqAgwqAgwqBmcm9udGVuZC1pZCA9ICZxdW90 OzEmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKg IMKgb25saW5lID0gJnF1b3Q7MSZxdW90Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDsgwqAgwqAgwqBzdGF0ZSA9ICZxdW90OzEmcXVvdDs8YnI+DQomZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIMKgc2NyaXB0ID0gJnF1b3Q7L2V0Yy94 ZW4vc2NyaXB0cy92aWYtYnJpZGdlJnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0OyDCoCDCoCDCoG1hYyA9ICZxdW90O2U0OjVmOjAxOmNkOjdiOmRkJnF1b3Q7 PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCDCoGJyaWRn ZSA9ICZxdW90O3hlbmJyMCZxdW90Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDsgwqAgwqAgwqBoYW5kbGUgPSAmcXVvdDswJnF1b3Q7PGJyPg0KJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDCoCDCoCDCoHR5cGUgPSAmcXVvdDt2aWYmcXVvdDs8 YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIMKgIMKgaG90cGx1 Zy1zdGF0dXMgPSAmcXVvdDsmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7IMKgIHR5cGUgPSAmcXVvdDtwdmgmcXVvdDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgIGRtLXZlcnNpb24gPSAmcXVvdDtxZW11X3hlbiZxdW90 Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgcm9vdEByYXNwYmVy cnlwaTQtNjQ6fi9ndWVzdDEjPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgQW55IGlucHV0 IGFzIHBlciBhYm92ZT8gTG9va2luZyBmb3J3YXJkIHRvIGhlYXJpbmcgZnJvbSB5b3UuPGJyPg0K Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDsgUmVnYXJkcyw8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7IFZpcHVsIEt1bWFyPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDsgT24gV2VkLCBPY3QgMjYsIDIwMjIgYXQgNToyMSBBTSBTdGVmYW5vIFN0YWJlbGxpbmkgJmx0 OzxhIGhyZWY9Im1haWx0bzpzc3RhYmVsbGluaUBrZXJuZWwub3JnIiB0YXJnZXQ9Il9ibGFuayI+ c3N0YWJlbGxpbmlAa2VybmVsLm9yZzwvYT4mZ3Q7IHdyb3RlOjxicj4NCiZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoEhpIFZpcHVsLDxicj4NCiZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBJZiB5b3UgbG9vayBhdCB0aGUgUUVNVSBsb2dzLCBp dCBzYXlzOjxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQom Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBWTkMgc2VydmVy IHJ1bm5pbmcgb24gPGEgaHJlZj0iaHR0cDovLzEyNy4wLjAuMTo1OTAwIiByZWw9Im5vcmVmZXJy ZXIiIHRhcmdldD0iX2JsYW5rIj4xMjcuMC4wLjE6NTkwMDwvYT48YnI+DQomZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgVGhhdCBpcyB0aGUgVk5DIHNlcnZlciB5b3UgbmVlZCB0byBj b25uZWN0IHRvLiBTbyBpbiB0aGVvcnk6PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoMKgIHZuY3ZpZXdlciA8YSBocmVmPSJodHRwOi8vMTI3LjAuMC4xOjU5MDAiIHJlbD0i bm9yZWZlcnJlciIgdGFyZ2V0PSJfYmxhbmsiPjEyNy4wLjAuMTo1OTAwPC9hPjxicj4NCiZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBzaG91bGQgd29yayBjb3JyZWN0bHkuPGJyPg0K Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqBJZiB5b3UgaGF2ZTo8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgwqAgdmZiID0gWyZxdW90O3R5cGU9dm5jJnF1b3Q7XTxicj4NCiZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBpbiB5b3VyIHhsIGNvbmZpZyBmaWxlIGFuZCB5 b3UgaGF2ZSAmcXVvdDtmYmRldiZxdW90OyBpbiB5b3VyIExpbnV4IGd1ZXN0LCBpdDxicj4NCiZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoHNob3VsZCB3b3Jr Ljxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBJZiB5b3UgY29ubmVjdCB0 byB0aGUgVk5DIHNlcnZlciBidXQgeW91IGdldCBhIGJsYWNrIHNjcmVlbiwgaXQgbWlnaHQgYmU8 YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBhIGd1 ZXN0IGNvbmZpZ3VyYXRpb24gaXNzdWUuIEkgd291bGQgdHJ5IHdpdGggYSBzaW1wbGVyIGd1ZXN0 LCB0ZXh0IG9ubHk8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAobm8gWDExLCBubyBXYXlsYW5kKSBhbmQgZW5hYmxlIHRoZSBmYmRldiBjb25zb2xl IChmYmNvbikuIFNlZTxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoERvY3VtZW50YXRpb24vZmIvZmJjb24ucnN0IGluIExpbnV4LiBZb3Ugc2hvdWxk IGJlIGFibGUgdG8gc2VlIGE8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqBncmFwaGljYWwgY29uc29sZSBvdmVyIFZOQy48YnI+DQomZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgSWYgdGhhdCB3b3JrcywgdGhlbiB5b3Uga25vdyB0aGF0 IHRoZSBmYmRldiBrZXJuZWwgZHJpdmVyICh4ZW4tZmJmcm9udCk8YnI+DQomZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqB3b3JrcyBjb3JyZWN0bHkuPGJyPg0K Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoElmIGl0IGRvZXNuJiMzOTt0IHdvcmss IHRoZSBvdXRwdXQgb2YgJnF1b3Q7eGVuc3RvcmUtbHMmcXVvdDsgd291bGQgYmUgaW50ZXJlc3Rp bmcuPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoENoZWVycyw8YnI+DQom Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgU3RlZmFubzxicj4NCiZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgT24gV2VkLCAxOSBPY3QgMjAyMiwgVmlwdWwgU3VuZWphIHdyb3RlOjxicj4NCiZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgSGkgU3Rl ZmFubyw8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0OyBUaGFua3MgZm9yIHRoZSByZXNwb25zZSE8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBJIGFtIGZvbGxvd2luZyB0aGUgc2Ft ZSBsaW5rIHlvdSBzaGFyZWQgZnJvbSB0aGUgYmVnaW5uaW5nLiBUcmllZCB0aGUgY29tbWFuZDxi cj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZxdW90O3ZuY3ZpZXdlcjxicj4NCiZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoGxvY2FsaG9zdDowJnF1 b3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgaW4gRE9NMDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoGJ1dDxicj4NCiZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoHNhbWU8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBpc3N1ZSAmcXVvdDtDYW4mIzM5O3Qgb3Blbjxi cj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsg ZGlzcGxheSZxdW90OywgYmVsb3cgYXJlIHRoZSBsb2dzOjxicj4NCiZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IHJvb3RAcmFzcGJlcnJ5cGk0LTY0 On4jIHZuY3ZpZXdlciBsb2NhbGhvc3Q6MDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFRpZ2VyVk5DIFZpZXdlciA2NC1iaXQgdjEuMTEu MDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDsgQnVpbHQgb246IDIwMjAtMDktMDggMTI6MTY8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IENvcHlyaWdodCAoQykgMTk5OS0yMDIwIFRp Z2VyVk5DIFRlYW0gYW5kIG1hbnkgb3RoZXJzIChzZWUgUkVBRE1FLnJzdCk8YnI+DQomZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFNlZSA8YSBocmVm PSJodHRwczovL3d3dy50aWdlcnZuYy5vcmciIHJlbD0ibm9yZWZlcnJlciIgdGFyZ2V0PSJfYmxh bmsiPmh0dHBzOi8vd3d3LnRpZ2Vydm5jLm9yZzwvYT4gZm9yIGluZm9ybWF0aW9uIG9uIFRpZ2Vy Vk5DLjxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDsgQ2FuJiMzOTt0IG9wZW4gZGlzcGxheTo8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBCZWxvdyBhcmUgdGhlIG5ldHN0YXQgbG9n cywgaSBjb3VsZG4mIzM5O3Qgc2VlIGFueXRoaW5nIHJ1bm5pbmcgYXQgcG9ydCA1OTAwIG9yPGJy Pg0KJmd0O8KgIMKgIMKgIMKgNTkwMTo8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyByb290QHJhc3BiZXJyeXBpNC02NDp+IyBuZXRzdGF0 IC10dXd4PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0OyBBY3RpdmUgSW50ZXJuZXQgY29ubmVjdGlvbnMgKHcvbyBzZXJ2ZXJzKTxicj4NCiZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgUHJvdG8g UmVjdi1RIFNlbmQtUSBMb2NhbCBBZGRyZXNzIMKgIMKgIMKgIMKgIMKgIEZvcmVpZ24gQWRkcmVz cyDCoCDCoCDCoCDCoCBTdGF0ZSDCoCDCoDxicj4NCiZndDvCoCDCoCDCoCDCoMKgPGJyPg0KJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyB0Y3AgwqAg wqAgwqAgwqAwIMKgIMKgMTY0IDE5Mi4xNjguMS4zOTpzc2ggwqAgwqAgwqAgwqA8YSBocmVmPSJo dHRwOi8vMTkyLjE2OC4xLjM4OjM3NDcyIiByZWw9Im5vcmVmZXJyZXIiIHRhcmdldD0iX2JsYW5r Ij4xOTIuMTY4LjEuMzg6Mzc0NzI8L2E+IMKgIMKgPGJyPg0KJmd0O8KgIMKgIMKgIMKgwqBFU1RB QkxJU0hFRDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDsgQWN0aXZlIFVOSVggZG9tYWluIHNvY2tldHMgKHcvbyBzZXJ2ZXJzKTxicj4NCiZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgUHJvdG8g UmVmQ250IEZsYWdzIMKgIMKgIMKgIFR5cGUgwqAgwqAgwqAgU3RhdGUgwqAgwqAgwqAgwqAgSS1O b2RlIFBhdGg8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7IHVuaXggwqA4IMKgIMKgIMKgWyBdIMKgIMKgIMKgIMKgIERHUkFNIMKgIMKgIMKg Q09OTkVDVEVEIMKgIMKgIMKgMTA1NjUgL2Rldi9sb2c8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IHVuaXggwqAzIMKgIMKgIMKgWyBdIMKg IMKgIMKgIMKgIFNUUkVBTSDCoCDCoCBDT05ORUNURUQgwqAgwqAgwqAxMDg5MTxicj4NCiZndDvC oCDCoCDCoCDCoC92YXIvcnVuL3hlbnN0b3JlZC9zb2NrZXQ8YnI+DQomZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IHVuaXggwqAzIMKgIMKgIMKgWyBd IMKgIMKgIMKgIMKgIFNUUkVBTSDCoCDCoCBDT05ORUNURUQgwqAgwqAgwqAxMzc5MTxicj4NCiZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgdW5peCDC oDMgwqAgwqAgwqBbIF0gwqAgwqAgwqAgwqAgU1RSRUFNIMKgIMKgIENPTk5FQ1RFRCDCoCDCoCDC oDEwODQzPGJyPg0KJmd0O8KgIMKgIMKgIMKgL3Zhci9ydW4veGVuc3RvcmVkL3NvY2tldDxicj4N CiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgdW5p eCDCoDMgwqAgwqAgwqBbIF0gwqAgwqAgwqAgwqAgU1RSRUFNIMKgIMKgIENPTk5FQ1RFRCDCoCDC oCDCoDEwNTczPGJyPg0KJmd0O8KgIMKgIMKgIMKgL3Zhci9ydW4veGVuc3RvcmVkL3NvY2tldDxi cj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsg dW5peCDCoDIgwqAgwqAgwqBbIF0gwqAgwqAgwqAgwqAgREdSQU0gwqAgwqAgwqBDT05ORUNURUQg wqAgwqAgwqAxNDUxMDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDsgdW5peCDCoDMgwqAgwqAgwqBbIF0gwqAgwqAgwqAgwqAgU1RSRUFNIMKg IMKgIENPTk5FQ1RFRCDCoCDCoCDCoDEzMjQ5PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyB1bml4IMKgMiDCoCDCoCDCoFsgXSDCoCDCoCDC oCDCoCBER1JBTSDCoCDCoCDCoENPTk5FQ1RFRCDCoCDCoCDCoDEzODg3PGJyPg0KJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyB1bml4IMKgMiDCoCDC oCDCoFsgXSDCoCDCoCDCoCDCoCBER1JBTSDCoCDCoCDCoENPTk5FQ1RFRCDCoCDCoCDCoDEwNTk5 PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 OyB1bml4IMKgMyDCoCDCoCDCoFsgXSDCoCDCoCDCoCDCoCBTVFJFQU0gwqAgwqAgQ09OTkVDVEVE IMKgIMKgIMKgMTQwMDU8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7IHVuaXggwqAzIMKgIMKgIMKgWyBdIMKgIMKgIMKgIMKgIFNUUkVBTSDC oCDCoCBDT05ORUNURUQgwqAgwqAgwqAxMzI1ODxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgdW5peCDCoDMgwqAgwqAgwqBbIF0gwqAgwqAg wqAgwqAgU1RSRUFNIMKgIMKgIENPTk5FQ1RFRCDCoCDCoCDCoDEzMjQ4PGJyPg0KJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyB1bml4IMKgMyDCoCDC oCDCoFsgXSDCoCDCoCDCoCDCoCBTVFJFQU0gwqAgwqAgQ09OTkVDVEVEIMKgIMKgIMKgMTQwMDM8 YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 IHVuaXggwqAzIMKgIMKgIMKgWyBdIMKgIMKgIMKgIMKgIFNUUkVBTSDCoCDCoCBDT05ORUNURUQg wqAgwqAgwqAxMDU3Mjxicj4NCiZndDvCoCDCoCDCoCDCoC92YXIvcnVuL3hlbnN0b3JlZC9zb2Nr ZXQ8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7IHVuaXggwqAzIMKgIMKgIMKgWyBdIMKgIMKgIMKgIMKgIFNUUkVBTSDCoCDCoCBDT05ORUNU RUQgwqAgwqAgwqAxMDc4Njxicj4NCiZndDvCoCDCoCDCoCDCoC92YXIvcnVuL3hlbnN0b3JlZC9z b2NrZXQ8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7IHVuaXggwqAzIMKgIMKgIMKgWyBdIMKgIMKgIMKgIMKgIERHUkFNIMKgIMKgIMKgQ09O TkVDVEVEIMKgIMKgIMKgMTMxODY8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IHVuaXggwqAzIMKgIMKgIMKgWyBdIMKgIMKgIMKgIMKgIFNU UkVBTSDCoCDCoCBDT05ORUNURUQgwqAgwqAgwqAxMDg2NDxicj4NCiZndDvCoCDCoCDCoCDCoC92 YXIvcnVuL3hlbnN0b3JlZC9zb2NrZXQ8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IHVuaXggwqAzIMKgIMKgIMKgWyBdIMKgIMKgIMKgIMKg IFNUUkVBTSDCoCDCoCBDT05ORUNURUQgwqAgwqAgwqAxMDgxMjxicj4NCiZndDvCoCDCoCDCoCDC oC92YXIvcnVuL3hlbnN0b3JlZC9zb2NrZXQ8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IHVuaXggwqAyIMKgIMKgIMKgWyBdIMKgIMKgIMKg IMKgIERHUkFNIMKgIMKgIMKgQ09OTkVDVEVEIMKgIMKgIMKgMTQwODM8YnI+DQomZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IHVuaXggwqAzIMKgIMKg IMKgWyBdIMKgIMKgIMKgIMKgIFNUUkVBTSDCoCDCoCBDT05ORUNURUQgwqAgwqAgwqAxMDgxMzxi cj4NCiZndDvCoCDCoCDCoCDCoC92YXIvcnVuL3hlbnN0b3JlZC9zb2NrZXQ8YnI+DQomZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IHVuaXggwqAzIMKg IMKgIMKgWyBdIMKgIMKgIMKgIMKgIFNUUkVBTSDCoCDCoCBDT05ORUNURUQgwqAgwqAgwqAxNDA2 ODxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDsgdW5peCDCoDMgwqAgwqAgwqBbIF0gwqAgwqAgwqAgwqAgU1RSRUFNIMKgIMKgIENPTk5FQ1RF RCDCoCDCoCDCoDEzMjU2PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0OyB1bml4IMKgMyDCoCDCoCDCoFsgXSDCoCDCoCDCoCDCoCBTVFJFQU0g wqAgwqAgQ09OTkVDVEVEIMKgIMKgIMKgMTA1NzE8YnI+DQomZ3Q7wqAgwqAgwqAgwqAvdmFyL3J1 bi94ZW5zdG9yZWQvc29ja2V0PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0OyB1bml4IMKgMyDCoCDCoCDCoFsgXSDCoCDCoCDCoCDCoCBTVFJF QU0gwqAgwqAgQ09OTkVDVEVEIMKgIMKgIMKgMTA4NDI8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IHVuaXggwqAzIMKgIMKgIMKgWyBdIMKg IMKgIMKgIMKgIFNUUkVBTSDCoCDCoCBDT05ORUNURUQgwqAgwqAgwqAxMzk4NTxicj4NCiZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgdW5peCDCoDMg wqAgwqAgwqBbIF0gwqAgwqAgwqAgwqAgREdSQU0gwqAgwqAgwqBDT05ORUNURUQgwqAgwqAgwqAx MzE4NTxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDsgdW5peCDCoDIgwqAgwqAgwqBbIF0gwqAgwqAgwqAgwqAgU1RSRUFNIMKgIMKgIENPTk5F Q1RFRCDCoCDCoCDCoDEzODg0PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0OyB1bml4IMKgMiDCoCDCoCDCoFsgXSDCoCDCoCDCoCDCoCBER1JB TSDCoCDCoCDCoENPTk5FQ1RFRCDCoCDCoCDCoDE0NTI4PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyB1bml4IMKgMiDCoCDCoCDCoFsgXSDC oCDCoCDCoCDCoCBER1JBTSDCoCDCoCDCoENPTk5FQ1RFRCDCoCDCoCDCoDEzNzg1PGJyPg0KJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyB1bml4IMKg MyDCoCDCoCDCoFsgXSDCoCDCoCDCoCDCoCBTVFJFQU0gwqAgwqAgQ09OTkVDVEVEIMKgIMKgIMKg MTQwMzQ8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0OyBBdHRhY2hpbmcgeGVuIGxvZyBmaWxlcyBvZiAvdmFyL2xvZy94ZW4uPGJyPg0KJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBJIGRpZG4m IzM5O3QgZ2V0IHRoZSByb2xlIG9mIFFFTVUgaGVyZSBiZWNhdXNlIGFzIG1lbnRpb25lZCBlYXJs aWVyLCBJIGFtIHBvcnRpbmc8YnI+DQomZ3Q7wqAgwqAgwqAgwqBpbjxicj4NCiZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoHJhc3BiZXJyeXBpPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgNEIuPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgUmVnYXJkcyw8YnI+DQomZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFZpcHVsIEt1bWFyPGJyPg0K Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4N CiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgT24g V2VkLCBPY3QgMTksIDIwMjIgYXQgMTI6NDMgQU0gU3RlZmFubyBTdGFiZWxsaW5pICZsdDs8YSBo cmVmPSJtYWlsdG86c3N0YWJlbGxpbmlAa2VybmVsLm9yZyIgdGFyZ2V0PSJfYmxhbmsiPnNzdGFi ZWxsaW5pQGtlcm5lbC5vcmc8L2E+Jmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoHdyb3RlOjxicj4N CiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoEl0IHVzdWFsbHkgd29ya3MgdGhlIHdheSBpdCBpcyBkZXNjcmliZWQgaW4gdGhlIGd1 aWRlOjxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqA8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqA8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqA8YnI+DQomZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqA8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqA8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqA8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqA8YnI+DQomZ3Q7wqAgwqAgwqAg wqDCoMKgwqDCoMKgwqDCoDxhIGhyZWY9Imh0dHBzOi8vd3d3LnZpcnR1YXRvcGlhLmNvbS9pbmRl eC5waHA/dGl0bGU9Q29uZmlndXJpbmdfYV9WTkNfYmFzZWRfR3JhcGhpY2FsX0NvbnNvbGVfZm9y X2FfWGVuX1BhcmF2aXJ0dWFsaXplZF9kb21haW5VX0d1ZXN0IiByZWw9Im5vcmVmZXJyZXIiIHRh cmdldD0iX2JsYW5rIj5odHRwczovL3d3dy52aXJ0dWF0b3BpYS5jb20vaW5kZXgucGhwP3RpdGxl PUNvbmZpZ3VyaW5nX2FfVk5DX2Jhc2VkX0dyYXBoaWNhbF9Db25zb2xlX2Zvcl9hX1hlbl9QYXJh dmlydHVhbGl6ZWRfZG9tYWluVV9HdWVzdDwvYT48YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgWW91IGRvbiYjMzk7dCBu ZWVkIHRvIGluc3RhbGwgYW55IFZOQy1yZWxhdGVkIHNlcnZlciBzb2Z0d2FyZSBiZWNhdXNlIGl0 IGlzPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgYWxyZWFkeSBwcm92aWRlZCBieSBYZW4gKHRvIGJlIHByZWNpc2UgaXQg aXMgcHJvdmlkZWQgYnkgUUVNVSB3b3JraW5nPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgdG9nZXRoZXIgd2l0aCBYZW4u KTxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqBZb3Ugb25seSBuZWVkIHRoZSB2bmMgY2xpZW50IGluIGRvbTAgc28gdGhh dCB5b3UgY2FuIGNvbm5lY3QsIGJ1dCB5b3U8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBjb3VsZCBhbHNvIHJ1biB0aGUg dm5jIGNsaWVudCBvdXRzaWRlIGZyb20gYW5vdGhlciBob3N0LiBTbyBiYXNpY2FsbHk8YnI+DQom Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqB0aGUgZm9sbG93aW5nIHNob3VsZCB3b3JrIHdoZW4gZXhlY3V0ZWQgaW4gRG9tMCBhZnRl ciBjcmVhdGluZyBEb21VOjxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqDCoCB2bmN2aWV3ZXIgbG9jYWxob3N0OjA8YnI+ DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJy Pg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgQ2FuIHlvdSBhdHRhY2ggdGhlIFhlbiBhbmQgUUVNVSBsb2dzICgvdmFyL2xvZy94 ZW4vKik/IEFuZCBhbHNvIHVzZTxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoG5ldHN0YXQgLXRhdW5wIHRvIGNoZWNrIGlm IHRoZXJlIGlzIGFueXRoaW5nIHJ1bm5pbmcgYXQgcG9ydCA1OTAwIG9yPGJyPg0KJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgNTkw MT88YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgQ2hlZXJzLDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBTdGVmYW5vPGJyPg0KJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBP biBUdWUsIDE4IE9jdCAyMDIyLCBWaXB1bCBTdW5lamEgd3JvdGU6PGJyPg0KJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBI aSBTdGVmYW5vLDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFRoYW5rcyBmb3IgdGhl IHJlc3BvbnNlITxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IEkgY291bGQgaW5zdGFs bCB0aWdlclZOQywgeDExdm5jICZhbXA7IGxpYnZuY3NlcnZlciBpbiBEb20wPGJyPg0KJmd0O8Kg IMKgIMKgIMKgeGVuLWltYWdlLW1pbmltYWwgYnV0PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgb25seTxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoG1hbmFnZSB0bzxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoGluc3RhbGw8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBsaWJ2bmNzZXJ2ZXIoY291bGRuJiMzOTt0PGJy Pg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgaW5zdGFsbCB0aWdlcnZuYzxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgJmFtcDsgeDExdm5jIGJl Y2F1c2Ugb2YgeDExPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBzdXBwb3J0IG1pc3NpbmcsIGl0JiMzOTtzIHdh eWxhbmQpIGluIERPTVUgY3VzdG9tIGdyYXBoaWNhbCBpbWFnZS4gSTxicj4NCiZndDvCoCDCoCDC oCDCoHRyaWVkPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgcnVubmluZzxicj4N CiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoHZuY3ZpZXdlciB3 aXRoPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgSVA8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBhZGRyZXNzICZhbXA7PGJyPg0K Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgcG9ydDxicj4NCiZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoGluIGRvbTAgdG88YnI+DQomZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBh Y2Nlc3MgdGhlIGRvbXU8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IGdyYXBoaWNhbCBpbWFnZSBkaXNwbGF5IGFz IHBlciBiZWxvdyBjb21tYW5kcy48YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgPGJyPg0KJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyDC oHZuY3ZpZXdlciA8YSBocmVmPSJodHRwOi8vMTkyLjE2OC4xLjQyOjU5MDEiIHJlbD0ibm9yZWZl cnJlciIgdGFyZ2V0PSJfYmxhbmsiPjE5Mi4xNjguMS40Mjo1OTAxPC9hPjxicj4NCiZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDsgwqA8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IMKgQnV0IGl0IHNob3dpbmcgY2FuJiMzOTt0IG9wZW4gZGlz cGxheSwgYmVsb3cgYXJlIHRoZSBsb2dzOjxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgwqA8YnI+DQomZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7IHJvb3RAcmFzcGJlcnJ5cGk0LTY0On4vZ3Vlc3QxIyB2bmN2aWV3ZXIgPGEgaHJlZj0iaHR0 cDovLzE5Mi4xNjguMS40Mjo1OTAxIiByZWw9Im5vcmVmZXJyZXIiIHRhcmdldD0iX2JsYW5rIj4x OTIuMTY4LjEuNDI6NTkwMTwvYT48YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBUaWdl clZOQyBWaWV3ZXIgNjQtYml0IHYxLjExLjA8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IEJ1aWx0IG9uOiAyMDIw LTA5LTA4IDEyOjE2PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBDb3B5cmlnaHQgKEMpIDE5OTktMjAyMCBUaWdl clZOQyBUZWFtIGFuZCBtYW55IG90aGVycyAoc2VlPGJyPg0KJmd0O8KgIMKgIMKgIMKgUkVBRE1F LnJzdCk8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFNlZSA8YSBocmVmPSJodHRwczovL3d3dy50aWdlcnZuYy5v cmciIHJlbD0ibm9yZWZlcnJlciIgdGFyZ2V0PSJfYmxhbmsiPmh0dHBzOi8vd3d3LnRpZ2Vydm5j Lm9yZzwvYT4gZm9yIGluZm9ybWF0aW9uIG9uIFRpZ2VyVk5DLjxicj4NCiZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgQ2Fu JiMzOTt0IG9wZW4gZGlzcGxheTo8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IHJvb3RAcmFzcGJlcnJ5cGk0LTY0 On4vZ3Vlc3QxIzxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IEkgYW0gbm90IGV4YWN0 bHnCoHN1cmUgd2hhdCB0aGUgaXNzdWUgaXMgYnV0IEkgdGhvdWdodCBvbmx5PGJyPg0KJmd0O8Kg IMKgIMKgIMKgbGlidm5jc2VydmVyIGluPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgRE9NVSBjb3VsZDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoHdvcmsgdG88YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBnZXQ8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBhY2Nlc3Mg YnV0PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgaXQ8YnI+DQomZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBkaWQgbm90PGJyPg0KJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgd29yay7CoDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgSWYgVGlnZXJWTkMgaXMgdGhlIGlzc3VlIGhlcmUg dGhlbiBpcyB0aGVyZSBhbnkgb3RoZXIgVk5DIHNvdXJjZTxicj4NCiZndDvCoCDCoCDCoCDCoHdo aWNoIGNvdWxkPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgYmU8YnI+DQomZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBpbnN0YWxsZWQgZm9yPGJy Pg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgYm90aDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoHgxMSAmYW1wOzxicj4NCiZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoHdheWxhbmQgc3VwcG9ydGVk PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgaW1hZ2VzPzxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFJlZ2Fy ZHMsPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0OyBWaXB1bCBLdW1hcjxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7IE9uIFR1ZSwgT2N0IDE4LCAyMDIyIGF0IDI6NDAgQU0gU3RlZmFubyBTdGFiZWxsaW5p PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmx0OzxhIGhyZWY9Im1haWx0bzpzc3RhYmVsbGluaUBrZXJu ZWwub3JnIiB0YXJnZXQ9Il9ibGFuayI+c3N0YWJlbGxpbmlAa2VybmVsLm9yZzwvYT4mZ3Q7PGJy Pg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgd3JvdGU6PGJyPg0KJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgVk5DIGlzIHR5cGljYWxseSBlYXNpZXIgdG8gc2V0dXAsIGJlY2F1c2UgU0RMIG5l ZWRzIGV4dHJhPGJyPg0KJmd0O8KgIMKgIMKgIMKgbGlicmFyaWVzIGF0PGJyPg0KJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgYnVpbGQgdGltZSBhbmQgcnVudGltZS4gSWYgUUVNVSBpcyBidWlsdCB3aXRo b3V0IFNETCBzdXBwb3J0IGl0PGJyPg0KJmd0O8KgIMKgIMKgIMKgd29uJiMzOTt0PGJyPg0KJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgc3RhcnQgd2hlbiB5b3UgYXNrIGZvciBTREwuPGJyPg0KJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoFZOQyBzaG91bGQgd29yayB3aXRoIGJvdGgg eDExIGFuZCB3YXlsYW5kIGluIHlvdXIgZG9tVS4gSXQ8YnI+DQomZ3Q7wqAgwqAgwqAgwqBkb2Vz biYjMzk7dCB3b3JrPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgYXQgdGhlIHgxMSBsZXZlbCwg aXQgZXhwb3NlcyBhIHNwZWNpYWwgZmJkZXYgZGV2aWNlIGluIHlvdXI8YnI+DQomZ3Q7wqAgwqAg wqAgwqBkb21VIHRoYXQ8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBzaG91bGQgd29yayB3aXRo Ojxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoC0gYSBncmFwaGljYWwgY29uc29sZSBpbiBMaW51 eCBkb21VPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgLSB4MTE8YnI+DQomZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAtIHdheWxhbmQgKGJ1dCBJIGhhdmVuJiMzOTt0IHRlc3RlZCB0aGlzIHNvIEkgYW0g bm90IDEwMCUgc3VyZTxicj4NCiZndDvCoCDCoCDCoCDCoGFib3V0IGl0KTxicj4NCiZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBXaGVuIHlvdSBzYXkgJnF1b3Q7aXQgZG9lc24m IzM5O3Qgd29yayZxdW90Oywgd2hhdCBkbyB5b3UgbWVhbj8gRG8geW91IGdldCBhPGJyPg0KJmd0 O8KgIMKgIMKgIMKgYmxhY2s8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqB3aW5kb3c/PGJyPg0K Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoFlvdSBuZWVkIENPTkZJR19YRU5f RkJERVZfRlJPTlRFTkQgaW4gTGludXggZG9tVTxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoChk cml2ZXJzL3ZpZGVvL2ZiZGV2L3hlbi1mYmZyb250LmMpLiBJIHdvdWxkIHRyeSB0byBnZXQgYTxi cj4NCiZndDvCoCDCoCDCoCDCoGdyYXBoaWNhbDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoHRleHQ8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBjb25zb2xlIHVwIGFuZCBydW5u aW5nIGluIHlvdXIgZG9tVSBiZWZvcmUgYXR0ZW1wdGluZzxicj4NCiZndDvCoCDCoCDCoCDCoHgx MS93YXlsYW5kLjxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBDaGVl cnMsPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoFN0ZWZhbm88YnI+ DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgT24gTW9uLCAxNyBPY3QgMjAy MiwgVmlwdWwgU3VuZWphIHdyb3RlOjxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgSGks PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBUaGFua3MhPGJyPg0KJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgSSBoYXZlIHBvcnRl ZCB4ZW4gbWluaW1hbCBpbWFnZSBhcyBET00wICZhbXA7IGN1c3RvbSB3YXlsYW5kIEdVSTxicj4N CiZndDvCoCDCoCDCoCDCoGJhc2VkPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg aW1hZ2UgYXM8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqBET01VIGluPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgcmFzcGJlcnJ5PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgcGk0Qi4g STxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoGFt IHRyeWluZyB0bzxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoG1ha2UgR1VJPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg ZGlzcGxheSB1cDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgZm9ywqBndWVzdCBtYWNo aW5lLiBJIHRyaWVkIHVzaW5nwqBzZGwsIGluY2x1ZGVkIGJlbG93IGxpbmUgaW48YnI+DQomZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBndWVzdC5jb25mIGZpbGU8YnI+DQomZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7IHZmYj0gWyAmIzM5O3NkbD0xJiMzOTsgXTxicj4NCiZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IEJ1dCBpdCBpcyB0 aHJvd2luZyBiZWxvdyBlcnJvcjo8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0K Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyByb290QHJhc3BiZXJyeXBpNC02NDp+L2d1ZXN0MSMg eGwgY3JlYXRlIC1jIGd1ZXN0MS5jZmc8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFBh cnNpbmcgY29uZmlnIGZyb20gZ3Vlc3QxLmNmZzxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDsgbGlieGw6IGVycm9yOiBsaWJ4bF9xbXAuYzoxNDAwOnFtcF9ldl9mZF9jYWxsYmFjazogRG9t YWluPGJyPg0KJmd0O8KgIMKgIMKgIMKgMzplcnJvciBvbjxicj4NCiZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoFFNUDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoHNvY2tldDo8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBDb25uZWN0aW9uPGJyPg0KJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgcmVzZXQgYnk8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqBwZWVyPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBsaWJ4bDogZXJyb3I6 IGxpYnhsX3FtcC5jOjE0Mzk6cW1wX2V2X2ZkX2NhbGxiYWNrOiBEb21haW48YnI+DQomZ3Q7wqAg wqAgwqAgwqAzOkVycm9yPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgaGFwcGVu ZWQ8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqB3aXRo IHRoZTxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoFFNUDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoGNvbm5lY3Rpb24gdG88YnI+ DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBRRU1VPGJy Pg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBsaWJ4bDogZXJyb3I6IGxpYnhsX2RtLmM6MzM1 MTpkZXZpY2VfbW9kZWxfcG9zdGNvbmZpZ19kb25lOjxicj4NCiZndDvCoCDCoCDCoCDCoERvbWFp bjxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoDM6UG9zdCBETTxicj4NCiZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoHN0YXJ0dXA8YnI+DQomZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBj b25maWdzPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgZmFpbGVkLDxicj4NCiZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoHJjPS0yNjxicj4NCiZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDsgbGlieGw6IGVycm9yOiBsaWJ4bF9jcmVhdGUuYzoxODY3OmRvbWNyZWF0 ZV9kZXZtb2RlbF9zdGFydGVkOjxicj4NCiZndDvCoCDCoCDCoCDCoERvbWFpbjxicj4NCiZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoDM6ZGV2aWNlPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgbW9kZWw8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBkaWQgbm90PGJyPg0KJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgc3RhcnQ6PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgLTI2PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBsaWJ4bDogZXJyb3I6IGxpYnhs X2FvdXRpbHMuYzo2NDY6bGlieGxfX2tpbGxfeHNfcGF0aDogRGV2aWNlPGJyPg0KJmd0O8KgIMKg IMKgIMKgTW9kZWw8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBhbHJlYWR5PGJy Pg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgZXhpdGVkPGJy Pg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBsaWJ4bDogZXJyb3I6IGxpYnhsX2RvbWFpbi5j OjExODM6bGlieGxfX2Rlc3Ryb3lfZG9taWQ6PGJyPg0KJmd0O8KgIMKgIMKgIMKgRG9tYWluPGJy Pg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgMzpOb24tZXhpc3RhbnQ8YnI+DQomZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBkb21haW48YnI+DQomZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAm Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IGxpYnhsOiBlcnJvcjogbGlieGxfZG9tYWluLmM6MTEzNzpk b21haW5fZGVzdHJveV9jYWxsYmFjazo8YnI+DQomZ3Q7wqAgwqAgwqAgwqBEb21haW48YnI+DQom Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAzOlVuYWJsZSB0bzxicj4NCiZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoGRlc3Ryb3k8YnI+DQomZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBndWVzdDxi cj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgbGlieGw6IGVycm9yOiBsaWJ4bF9kb21haW4u YzoxMDY0OmRvbWFpbl9kZXN0cm95X2NiOiBEb21haW48YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAzOkRlc3RydWN0aW9uIG9mPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgZG9tYWluPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgZmFpbGVkPGJyPg0KJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgQW5vdGhlciB3 YXkgaXMgVk5DLCBpIGNvdWxkIGluc3RhbGwgdGlnZXJ2bmMgaW4gRE9NMCBidXQgc2FtZTxicj4N CiZndDvCoCDCoCDCoCDCoGk8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBjb3Vs ZG4mIzM5O3QgaW48YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqBndWVzdDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoG1hY2hpbmU8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBiZWNhdXNl IGl0PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKg ZG9lc24mIzM5O3Qgc3VwcG9ydDxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDC oCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoHgxMShzdXBwb3J0 cyB3YXlsYW5kPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0OyBvbmx5KS4gSSBhbSBjb21w bGV0ZWx5IGJsb2NrZWQgaGVyZSwgTmVlZCB5b3VyIHN1cHBvcnQgdG88YnI+DQomZ3Q7wqAgwqAg wqAgwqBlbmFibGUgdGhlPGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgZGlzcGxh eTxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoHVwLjxi cj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgQW55IGFsdGVybmF0aXZlIG9mIFZOQyB3aGlj aCBjb3VsZCB3b3JrIGluIGJvdGggeDExICZhbXA7IHdheWxhbmQ8YnI+DQomZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqBzdXBwb3J0ZWQ8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqBpbWFnZXM/PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgQW55IGlucHV0IG9uIFZOQywgU0RMIG9y IGFueSBvdGhlciB3YXkgdG8gcHJvY2VlZCBvbiB0aGlzPzxicj4NCiZndDvCoCDCoCDCoCDCoExv b2tpbmc8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqBmb3J3YXJkIHRvPGJyPg0K Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgaGVhcmluZzxicj4N CiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoGZyb208YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqB5b3UuPGJyPg0KJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDsgUmVnYXJkcyw8YnI+DQom Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAg wqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7IFZpcHVsIEt1bWFyPGJyPg0KJmd0O8KgIMKgIMKgIMKg Jmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKg IMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4N CiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDC oCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKg IMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZn dDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0 O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAg wqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7 wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8Kg IMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvCoCDC oCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAg wqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJy Pg0KJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4N CiZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQom Z3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0 O8KgIMKgIMKgIMKgJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDvC oCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAmZ3Q7wqAgwqAgwqAgwqAmZ3Q7PGJy Pg0KJmd0O8KgIMKgIMKgIMKgJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCZndDs8YnI+DQomZ3Q7 wqAgwqAgwqAgwqAmZ3Q7PGJyPg0KJmd0OyA8YnI+DQomZ3Q7IDxicj4NCiZndDsgPC9ibG9ja3F1 b3RlPjwvZGl2Pg0KPC9ibG9ja3F1b3RlPjwvZGl2Pg0K --00000000000067bdb605f1e1bbce-- From xen-devel-bounces@lists.xenproject.org Tue Jan 10 05:28:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 05:28:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474252.735315 (Exim 4.92) (envelope-from ) id 1pF7BI-000546-Gu; Tue, 10 Jan 2023 05:28:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474252.735315; Tue, 10 Jan 2023 05:28:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF7BI-00053z-EC; Tue, 10 Jan 2023 05:28:16 +0000 Received: by outflank-mailman (input) for mailman id 474252; Tue, 10 Jan 2023 05:28:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF7BG-00053t-Py for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 05:28:15 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 928f8a23-90a7-11ed-91b6-6bf2151ebd3b; Tue, 10 Jan 2023 06:28:12 +0100 (CET) Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-480-jqTb_xDJMKy4wR-t5aJCAw-1; Tue, 10 Jan 2023 00:28:09 -0500 Received: by mail-qv1-f72.google.com with SMTP id pm24-20020ad446d8000000b0053233e46a00so1649774qvb.23 for ; Mon, 09 Jan 2023 21:28:09 -0800 (PST) Received: from redhat.com ([191.101.160.154]) by smtp.gmail.com with ESMTPSA id l13-20020ac84a8d000000b003a6947863e1sm5557653qtq.11.2023.01.09.21.28.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 21:28:06 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 928f8a23-90a7-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673328490; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0ansxmlLRWtTb0gFcB9ey2Q9eN1Orq6xeC0CbSQE8rs=; b=ip2tYMMYGm1CRwj7DEnMyMvs5GOWRh2MFy+TJYwxwRRpD3NjYwlE6NJwexL2oLdidG3WZ9 H4c+DIVBGQnboiHwq5Db1lK8CsA9qFD5hGWEP0OZW8o0at+bgPToa0Ew5Sezpkm/jkVE3n evH00InwQ+qL6i3fMNb/yaSwijvD5Vw= X-MC-Unique: jqTb_xDJMKy4wR-t5aJCAw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0ansxmlLRWtTb0gFcB9ey2Q9eN1Orq6xeC0CbSQE8rs=; b=m9cMfh+3G901mMBbtyyYCXxbtP0XlukoDd/H5a+imf8Lq376nAXvt03GPwvyMfWGDB QjsjOsl7kq9fPHVaEMqmTN6n14FCpAGUp1ycUvcpGQ0cgpvWd7P3+YHTmiMqSvM7Uy2+ AJOCDgVQPTuihj30/zLsGOPwwZSVIVes73AWTv6AQ3OqGWC4vnQzozsEf/OIZcgHgSnx nxPkphYFYcIymofT+Jl96vragO86bzftwZhjmXaUnqinaUSm9actFtQnxleekPtfV0FX bHthArgaqYRjaRNbMjjlHpRk5lNB3oX15nBEH0g2GfFTGMFCQdvLiB0TXxjdZNYiqN1O Qs5A== X-Gm-Message-State: AFqh2kowhEQ4A8LZEDUXNiydosA4h52XxNj9imcj1avj/JxWWG1s8hTz QZtVMVneoSq3C9K3wgmxW8cXjHqZvgz7CyDc2HrfyEuxA5n3EKIhFiYjzVloXlf9DEJnwKV2mgu aQG+x/P9jGYTMFwzq4GqpK2bM0nU= X-Received: by 2002:ac8:704b:0:b0:3a7:e110:81e5 with SMTP id y11-20020ac8704b000000b003a7e11081e5mr95042235qtm.53.1673328486968; Mon, 09 Jan 2023 21:28:06 -0800 (PST) X-Google-Smtp-Source: AMrXdXucbIbhjgPdiRynWq9rFbx7j1yJ4QMzUzRKinQH4QGXmaDZxzMzBDCzNEHfjSWPBWUViD+pJA== X-Received: by 2002:ac8:704b:0:b0:3a7:e110:81e5 with SMTP id y11-20020ac8704b000000b003a7e11081e5mr95042217qtm.53.1673328486642; Mon, 09 Jan 2023 21:28:06 -0800 (PST) Date: Tue, 10 Jan 2023 00:27:59 -0500 From: "Michael S. Tsirkin" To: Chuck Zmudzinski Cc: qemu-devel@nongnu.org, Stefano Stabellini , Anthony Perard , Paul Durrant , Paolo Bonzini , Richard Henderson , Eduardo Habkost , Marcel Apfelbaum , xen-devel@lists.xenproject.org Subject: Re: [PATCH v7] xen/pt: reserve PCI slot 2 for Intel igd-passthru Message-ID: <20230110002712-mutt-send-email-mst@kernel.org> References: <8349506149de6d81b0762f17623552c248439e93.1673297742.git.brchuckz.ref@aol.com> <8349506149de6d81b0762f17623552c248439e93.1673297742.git.brchuckz@aol.com> <20230109183132-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Mon, Jan 09, 2023 at 07:05:35PM -0500, Chuck Zmudzinski wrote: > On 1/9/23 6:33 PM, Michael S. Tsirkin wrote: > > On Mon, Jan 09, 2023 at 04:55:42PM -0500, Chuck Zmudzinski wrote: > >> Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, > >> as noted in docs/igd-assign.txt in the Qemu source code. > >> > >> Currently, when the xl toolstack is used to configure a Xen HVM guest with > >> Intel IGD passthrough to the guest with the Qemu upstream device model, > >> a Qemu emulated PCI device will occupy slot 2 and the Intel IGD will occupy > >> a different slot. This problem often prevents the guest from booting. > >> > >> The only available workaround is not good: Configure Xen HVM guests to use > >> the old and no longer maintained Qemu traditional device model available > >> from xenbits.xen.org which does reserve slot 2 for the Intel IGD. > >> > >> To implement this feature in the Qemu upstream device model for Xen HVM > >> guests, introduce the following new functions, types, and macros: > >> > >> * XEN_PT_DEVICE_CLASS declaration, based on the existing TYPE_XEN_PT_DEVICE > >> * XEN_PT_DEVICE_GET_CLASS macro helper function for XEN_PT_DEVICE_CLASS > >> * typedef XenPTQdevRealize function pointer > >> * XEN_PCI_IGD_SLOT_MASK, the value of slot_reserved_mask to reserve slot 2 > >> * xen_igd_reserve_slot and xen_igd_clear_slot functions > >> > >> The new xen_igd_reserve_slot function uses the existing slot_reserved_mask > >> member of PCIBus to reserve PCI slot 2 for Xen HVM guests configured using > >> the xl toolstack with the gfx_passthru option enabled, which sets the > >> igd-passthru=on option to Qemu for the Xen HVM machine type. > >> > >> The new xen_igd_reserve_slot function also needs to be implemented in > >> hw/xen/xen_pt_stub.c to prevent FTBFS during the link stage for the case > >> when Qemu is configured with --enable-xen and --disable-xen-pci-passthrough, > >> in which case it does nothing. > >> > >> The new xen_igd_clear_slot function overrides qdev->realize of the parent > >> PCI device class to enable the Intel IGD to occupy slot 2 on the PCI bus > >> since slot 2 was reserved by xen_igd_reserve_slot when the PCI bus was > >> created in hw/i386/pc_piix.c for the case when igd-passthru=on. > >> > >> Move the call to xen_host_pci_device_get, and the associated error > >> handling, from xen_pt_realize to the new xen_igd_clear_slot function to > >> initialize the device class and vendor values which enables the checks for > >> the Intel IGD to succeed. The verification that the host device is an > >> Intel IGD to be passed through is done by checking the domain, bus, slot, > >> and function values as well as by checking that gfx_passthru is enabled, > >> the device class is VGA, and the device vendor in Intel. > >> > >> Signed-off-by: Chuck Zmudzinski > >> --- > >> Notes that might be helpful to reviewers of patched code in hw/xen: > >> > >> The new functions and types are based on recommendations from Qemu docs: > >> https://qemu.readthedocs.io/en/latest/devel/qom.html > >> > >> Notes that might be helpful to reviewers of patched code in hw/i386: > >> > >> The small patch to hw/i386/pc_piix.c is protected by CONFIG_XEN so it does > >> not affect builds that do not have CONFIG_XEN defined. > > > > I'm not sure how you can claim that. > > I mean the small patch to pc_piix.c in this patch sits > between an "#ifdef CONFIG_XEN" and the corresponding > "#endif" so the preprocessor will exclude it when CONFIG_XEN > is not defined. In other words, my patch is part of the > xen-specific code in pc_piix.c. Or am I missing something? > > > > > > ... > > > >> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c > >> index b48047f50c..34a9736b5e 100644 > >> --- a/hw/i386/pc_piix.c > >> +++ b/hw/i386/pc_piix.c > >> @@ -32,6 +32,7 @@ > >> #include "hw/i386/pc.h" > >> #include "hw/i386/apic.h" > >> #include "hw/pci-host/i440fx.h" > >> +#include "hw/rtc/mc146818rtc.h" > >> #include "hw/southbridge/piix.h" > >> #include "hw/display/ramfb.h" > >> #include "hw/firmware/smbios.h" > >> @@ -40,16 +41,16 @@ > >> #include "hw/usb.h" > >> #include "net/net.h" > >> #include "hw/ide/pci.h" > >> -#include "hw/ide/piix.h" > >> #include "hw/irq.h" > >> #include "sysemu/kvm.h" > >> #include "hw/kvm/clock.h" > >> #include "hw/sysbus.h" > >> +#include "hw/i2c/i2c.h" > >> #include "hw/i2c/smbus_eeprom.h" > >> #include "hw/xen/xen-x86.h" > >> +#include "hw/xen/xen.h" > >> #include "exec/memory.h" > >> #include "hw/acpi/acpi.h" > >> -#include "hw/acpi/piix4.h" > >> #include "qapi/error.h" > >> #include "qemu/error-report.h" > >> #include "sysemu/xen.h" > >> @@ -66,6 +67,7 @@ > >> #include "kvm/kvm-cpu.h" > >> > >> #define MAX_IDE_BUS 2 > >> +#define XEN_IOAPIC_NUM_PIRQS 128ULL > >> > >> #ifdef CONFIG_IDE_ISA > >> static const int ide_iobase[MAX_IDE_BUS] = { 0x1f0, 0x170 }; > >> @@ -73,6 +75,32 @@ static const int ide_iobase2[MAX_IDE_BUS] = { 0x3f6, 0x376 }; > >> static const int ide_irq[MAX_IDE_BUS] = { 14, 15 }; > >> #endif > >> > >> +/* > >> + * Return the global irq number corresponding to a given device irq > >> + * pin. We could also use the bus number to have a more precise mapping. > >> + */ > >> +static int pci_slot_get_pirq(PCIDevice *pci_dev, int pci_intx) > >> +{ > >> + int slot_addend; > >> + slot_addend = PCI_SLOT(pci_dev->devfn) - 1; > >> + return (pci_intx + slot_addend) & 3; > >> +} > >> + > >> +static void piix_intx_routing_notifier_xen(PCIDevice *dev) > >> +{ > >> + int i; > >> + > >> + /* Scan for updates to PCI link routes (0x60-0x63). */ > >> + for (i = 0; i < PIIX_NUM_PIRQS; i++) { > >> + uint8_t v = dev->config_read(dev, PIIX_PIRQCA + i, 1); > >> + if (v & 0x80) { > >> + v = 0; > >> + } > >> + v &= 0xf; > >> + xen_set_pci_link_route(i, v); > >> + } > >> +} > >> + > >> /* PC hardware initialisation */ > >> static void pc_init1(MachineState *machine, > >> const char *host_type, const char *pci_type) > >> @@ -84,7 +112,7 @@ static void pc_init1(MachineState *machine, > >> MemoryRegion *system_io = get_system_io(); > >> PCIBus *pci_bus; > >> ISABus *isa_bus; > >> - int piix3_devfn = -1; > >> + Object *piix4_pm; > >> qemu_irq smi_irq; > >> GSIState *gsi_state; > >> BusState *idebus[MAX_IDE_BUS]; > >> @@ -205,10 +233,9 @@ static void pc_init1(MachineState *machine, > >> gsi_state = pc_gsi_create(&x86ms->gsi, pcmc->pci_enabled); > >> > >> if (pcmc->pci_enabled) { > >> - PIIX3State *piix3; > >> + DeviceState *dev; > >> PCIDevice *pci_dev; > >> - const char *type = xen_enabled() ? TYPE_PIIX3_XEN_DEVICE > >> - : TYPE_PIIX3_DEVICE; > >> + int i; > >> > >> pci_bus = i440fx_init(pci_type, > >> i440fx_host, > >> @@ -216,21 +243,65 @@ static void pc_init1(MachineState *machine, > >> x86ms->below_4g_mem_size, > >> x86ms->above_4g_mem_size, > >> pci_memory, ram_memory); > >> + pci_bus_map_irqs(pci_bus, > >> + xen_enabled() ? xen_pci_slot_get_pirq > >> + : pci_slot_get_pirq); > >> pcms->bus = pci_bus; > >> > >> - pci_dev = pci_create_simple_multifunction(pci_bus, -1, true, type); > >> - piix3 = PIIX3_PCI_DEVICE(pci_dev); > >> - piix3->pic = x86ms->gsi; > >> - piix3_devfn = piix3->dev.devfn; > >> - isa_bus = ISA_BUS(qdev_get_child_bus(DEVICE(piix3), "isa.0")); > >> + pci_dev = pci_new_multifunction(-1, true, TYPE_PIIX3_DEVICE); > >> + object_property_set_bool(OBJECT(pci_dev), "has-usb", > >> + machine_usb(machine), &error_abort); > >> + object_property_set_bool(OBJECT(pci_dev), "has-acpi", > >> + x86_machine_is_acpi_enabled(x86ms), > >> + &error_abort); > >> + qdev_prop_set_uint32(DEVICE(pci_dev), "smb_io_base", 0xb100); > >> + object_property_set_bool(OBJECT(pci_dev), "smm-enabled", > >> + x86_machine_is_smm_enabled(x86ms), > >> + &error_abort); > >> + pci_realize_and_unref(pci_dev, pci_bus, &error_fatal); > >> + > >> + if (xen_enabled()) { > >> + pci_device_set_intx_routing_notifier( > >> + pci_dev, piix_intx_routing_notifier_xen); > >> + > >> + /* > >> + * Xen supports additional interrupt routes from the PCI devices to > >> + * the IOAPIC: the four pins of each PCI device on the bus are also > >> + * connected to the IOAPIC directly. > >> + * These additional routes can be discovered through ACPI. > >> + */ > >> + pci_bus_irqs(pci_bus, xen_intx_set_irq, pci_dev, > >> + XEN_IOAPIC_NUM_PIRQS); > >> + } > >> + > >> + dev = DEVICE(object_resolve_path_component(OBJECT(pci_dev), "pic")); > >> + for (i = 0; i < ISA_NUM_IRQS; i++) { > >> + qdev_connect_gpio_out(dev, i, x86ms->gsi[i]); > >> + } > >> + isa_bus = ISA_BUS(qdev_get_child_bus(DEVICE(pci_dev), "isa.0")); > >> + rtc_state = ISA_DEVICE(object_resolve_path_component(OBJECT(pci_dev), > >> + "rtc")); > >> + piix4_pm = object_resolve_path_component(OBJECT(pci_dev), "pm"); > >> + dev = DEVICE(object_resolve_path_component(OBJECT(pci_dev), "ide")); > >> + pci_ide_create_devs(PCI_DEVICE(dev)); > >> + idebus[0] = qdev_get_child_bus(dev, "ide.0"); > >> + idebus[1] = qdev_get_child_bus(dev, "ide.1"); > >> } else { > >> pci_bus = NULL; > >> + piix4_pm = NULL; > >> isa_bus = isa_bus_new(NULL, get_system_memory(), system_io, > >> &error_abort); > >> + isa_bus_irqs(isa_bus, x86ms->gsi); > >> + > >> + rtc_state = isa_new(TYPE_MC146818_RTC); > >> + qdev_prop_set_int32(DEVICE(rtc_state), "base_year", 2000); > >> + isa_realize_and_unref(rtc_state, isa_bus, &error_fatal); > >> + > >> i8257_dma_init(isa_bus, 0); > >> pcms->hpet_enabled = false; > >> + idebus[0] = NULL; > >> + idebus[1] = NULL; > >> } > >> - isa_bus_irqs(isa_bus, x86ms->gsi); > >> > >> if (x86ms->pic == ON_OFF_AUTO_ON || x86ms->pic == ON_OFF_AUTO_AUTO) { > >> pc_i8259_create(isa_bus, gsi_state->i8259_irq); > >> @@ -252,18 +323,12 @@ static void pc_init1(MachineState *machine, > >> } > >> > >> /* init basic PC hardware */ > >> - pc_basic_device_init(pcms, isa_bus, x86ms->gsi, &rtc_state, true, > >> + pc_basic_device_init(pcms, isa_bus, x86ms->gsi, rtc_state, true, > >> 0x4); > >> > >> pc_nic_init(pcmc, isa_bus, pci_bus); > >> > >> if (pcmc->pci_enabled) { > >> - PCIDevice *dev; > >> - > >> - dev = pci_create_simple(pci_bus, piix3_devfn + 1, TYPE_PIIX3_IDE); > >> - pci_ide_create_devs(dev); > >> - idebus[0] = qdev_get_child_bus(&dev->qdev, "ide.0"); > >> - idebus[1] = qdev_get_child_bus(&dev->qdev, "ide.1"); > >> pc_cmos_init(pcms, idebus[0], idebus[1], rtc_state); > >> } > >> #ifdef CONFIG_IDE_ISA > >> @@ -289,21 +354,9 @@ static void pc_init1(MachineState *machine, > >> } > >> #endif > >> > >> - if (pcmc->pci_enabled && machine_usb(machine)) { > >> - pci_create_simple(pci_bus, piix3_devfn + 2, "piix3-usb-uhci"); > >> - } > >> - > >> - if (pcmc->pci_enabled && x86_machine_is_acpi_enabled(X86_MACHINE(pcms))) { > >> - PCIDevice *piix4_pm; > >> - > >> + if (piix4_pm) { > >> smi_irq = qemu_allocate_irq(pc_acpi_smi_interrupt, first_cpu, 0); > >> - piix4_pm = pci_new(piix3_devfn + 3, TYPE_PIIX4_PM); > >> - qdev_prop_set_uint32(DEVICE(piix4_pm), "smb_io_base", 0xb100); > >> - qdev_prop_set_bit(DEVICE(piix4_pm), "smm-enabled", > >> - x86_machine_is_smm_enabled(x86ms)); > >> - pci_realize_and_unref(piix4_pm, pci_bus, &error_fatal); > >> > >> - qdev_connect_gpio_out(DEVICE(piix4_pm), 0, x86ms->gsi[9]); > >> qdev_connect_gpio_out_named(DEVICE(piix4_pm), "smi-irq", 0, smi_irq); > >> pcms->smbus = I2C_BUS(qdev_get_child_bus(DEVICE(piix4_pm), "i2c")); > >> /* TODO: Populate SPD eeprom data. */ > >> @@ -315,7 +368,7 @@ static void pc_init1(MachineState *machine, > >> object_property_allow_set_link, > >> OBJ_PROP_LINK_STRONG); > >> object_property_set_link(OBJECT(machine), PC_MACHINE_ACPI_DEVICE_PROP, > >> - OBJECT(piix4_pm), &error_abort); > >> + piix4_pm, &error_abort); > >> } > >> > >> if (machine->nvdimms_state->is_enabled) { > >> @@ -405,6 +458,9 @@ static void pc_xen_hvm_init(MachineState *machine) > >> } > >> > >> pc_xen_hvm_init_pci(machine); > >> + if (xen_igd_gfx_pt_enabled()) { > >> + xen_igd_reserve_slot(pcms->bus); > >> + } > >> pci_create_simple(pcms->bus, -1, "xen-platform"); > >> } > >> #endif > >> @@ -441,6 +497,11 @@ static void pc_i440fx_8_0_machine_options(MachineClass *m) > >> pc_i440fx_machine_options(m); > >> m->alias = "pc"; > >> m->is_default = true; > >> +#ifdef CONFIG_MICROVM_DEFAULT > >> + m->is_default = false; > >> +#else > >> + m->is_default = true; > >> +#endif > >> } > >> > >> DEFINE_I440FX_MACHINE(v8_0, "pc-i440fx-8.0", NULL, > > > > > > Lots of changes here not guarded by CONFIG_XEN. > > > > What diff is this? How is my patch related to it? This is what you posted, take a look: https://lore.kernel.org/all/8349506149de6d81b0762f17623552c248439e93.1673297742.git.brchuckz@aol.com/ -- MST From xen-devel-bounces@lists.xenproject.org Tue Jan 10 05:34:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 05:34:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474258.735328 (Exim 4.92) (envelope-from ) id 1pF7Gt-0006Vc-6v; Tue, 10 Jan 2023 05:34:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474258.735328; Tue, 10 Jan 2023 05:34:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF7Gt-0006VV-1m; Tue, 10 Jan 2023 05:34:03 +0000 Received: by outflank-mailman (input) for mailman id 474258; Tue, 10 Jan 2023 05:34:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF7Gr-0006VP-4w for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 05:34:01 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 61a98727-90a8-11ed-91b6-6bf2151ebd3b; Tue, 10 Jan 2023 06:33:59 +0100 (CET) Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-544-LseaCMcvMbiLxusax2YNaQ-1; Tue, 10 Jan 2023 00:33:56 -0500 Received: by mail-qv1-f69.google.com with SMTP id o20-20020a0ccb14000000b005321d865fbbso6199771qvk.17 for ; Mon, 09 Jan 2023 21:33:56 -0800 (PST) Received: from redhat.com ([191.101.160.154]) by smtp.gmail.com with ESMTPSA id t11-20020a05620a034b00b006fa31bf2f3dsm6536546qkm.47.2023.01.09.21.33.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 21:33:54 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 61a98727-90a8-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673328838; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n2rrvtY6YACF2A594KZFjWGGgNjo+s7enLD/esRvyA4=; b=Ml1Iv8hI4ycHX46CjmJ+l638N1UNmAH94YJdVRuHl7tWdlS7y5n25k+uoG3g6u/rlgJeyN pnUisQeNaScKIHuzJ0n6FjZFIVJIS+LiBCrITubpurkEzlEq7JS+hdvSF1YWIt7V4PdOqU vxx8yJ5zjhIHlHxNGClObVJSaC3h/3E= X-MC-Unique: LseaCMcvMbiLxusax2YNaQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=n2rrvtY6YACF2A594KZFjWGGgNjo+s7enLD/esRvyA4=; b=hxJJXI1GZ/yer0ybGKgDfHwL7idQhLFlre6k3OX31hzA3obyrZjhpKcMpVjExlhAIY +6QXKnSzyzMX4XbQgyZ0wXjWMrgE5/7gVt8wBM0CkNIgZUkRoqJ58ThUTD0zuP1faY4c Caa1i54bTzELAwpeLQi9idC0XdYq79so6WeKHiFAt2QUA4KiZDGMd82yfG69aMkNNlJI hnc7ft5W0Zh4s86Nv/JZso3gq1slsivrEhDR41TRiRSV//X1uW8+QSEjWISYa6qhtQSr 9WekMaEPBa3iG0qDD0ll9OjGx8aOi8LgZlq3WBMa17B+7ZIhRyJAVyLFHtgeu8dJFuXk IcnQ== X-Gm-Message-State: AFqh2kpD2CHTOMnhlEqGxRBb/tTbZThjPgn+vUE3Dz4KF4K6wgPNsBHk fOrx+ZXzXaQnjfLnSgFZ31HvKhfirIsTEcwa2TxLSLXij6GBig1VKvOP0V98NeiaouT/uzODmmt 2qTrB5PA7HEIN/JZb/PU/Doegfuc= X-Received: by 2002:a0c:e989:0:b0:532:25bf:1e5b with SMTP id z9-20020a0ce989000000b0053225bf1e5bmr14527069qvn.13.1673328835969; Mon, 09 Jan 2023 21:33:55 -0800 (PST) X-Google-Smtp-Source: AMrXdXutkVsyyurgzYuTtqQs1bSdqx8vpXhBqsggh24leTy+BR7awDoq2WW1vhRn+V38P68mLmdiAg== X-Received: by 2002:a0c:e989:0:b0:532:25bf:1e5b with SMTP id z9-20020a0ce989000000b0053225bf1e5bmr14527054qvn.13.1673328835619; Mon, 09 Jan 2023 21:33:55 -0800 (PST) Date: Tue, 10 Jan 2023 00:33:48 -0500 From: "Michael S. Tsirkin" To: Chuck Zmudzinski Cc: qemu-devel@nongnu.org, Stefano Stabellini , Anthony Perard , Paul Durrant , Paolo Bonzini , Richard Henderson , Eduardo Habkost , Marcel Apfelbaum , xen-devel@lists.xenproject.org Subject: Re: [PATCH v7] xen/pt: reserve PCI slot 2 for Intel igd-passthru Message-ID: <20230110002809-mutt-send-email-mst@kernel.org> References: <8349506149de6d81b0762f17623552c248439e93.1673297742.git.brchuckz.ref@aol.com> <8349506149de6d81b0762f17623552c248439e93.1673297742.git.brchuckz@aol.com> <20230109183132-mutt-send-email-mst@kernel.org> <1542de4a-3b42-0ca4-777a-ce01f75b5532@aol.com> MIME-Version: 1.0 In-Reply-To: <1542de4a-3b42-0ca4-777a-ce01f75b5532@aol.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Mon, Jan 09, 2023 at 09:11:22PM -0500, Chuck Zmudzinski wrote: > On 1/9/2023 7:05 PM, Chuck Zmudzinski wrote: > > On 1/9/23 6:33 PM, Michael S. Tsirkin wrote: > > > On Mon, Jan 09, 2023 at 04:55:42PM -0500, Chuck Zmudzinski wrote: > > >> Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, > > >> as noted in docs/igd-assign.txt in the Qemu source code. > > >> > > >> Currently, when the xl toolstack is used to configure a Xen HVM guest with > > >> Intel IGD passthrough to the guest with the Qemu upstream device model, > > >> a Qemu emulated PCI device will occupy slot 2 and the Intel IGD will occupy > > >> a different slot. This problem often prevents the guest from booting. > > >> > > >> The only available workaround is not good: Configure Xen HVM guests to use > > >> the old and no longer maintained Qemu traditional device model available > > >> from xenbits.xen.org which does reserve slot 2 for the Intel IGD. > > >> > > >> To implement this feature in the Qemu upstream device model for Xen HVM > > >> guests, introduce the following new functions, types, and macros: > > >> > > >> * XEN_PT_DEVICE_CLASS declaration, based on the existing TYPE_XEN_PT_DEVICE > > >> * XEN_PT_DEVICE_GET_CLASS macro helper function for XEN_PT_DEVICE_CLASS > > >> * typedef XenPTQdevRealize function pointer > > >> * XEN_PCI_IGD_SLOT_MASK, the value of slot_reserved_mask to reserve slot 2 > > >> * xen_igd_reserve_slot and xen_igd_clear_slot functions > > >> > > >> The new xen_igd_reserve_slot function uses the existing slot_reserved_mask > > >> member of PCIBus to reserve PCI slot 2 for Xen HVM guests configured using > > >> the xl toolstack with the gfx_passthru option enabled, which sets the > > >> igd-passthru=on option to Qemu for the Xen HVM machine type. > > >> > > >> The new xen_igd_reserve_slot function also needs to be implemented in > > >> hw/xen/xen_pt_stub.c to prevent FTBFS during the link stage for the case > > >> when Qemu is configured with --enable-xen and --disable-xen-pci-passthrough, > > >> in which case it does nothing. > > >> > > >> The new xen_igd_clear_slot function overrides qdev->realize of the parent > > >> PCI device class to enable the Intel IGD to occupy slot 2 on the PCI bus > > >> since slot 2 was reserved by xen_igd_reserve_slot when the PCI bus was > > >> created in hw/i386/pc_piix.c for the case when igd-passthru=on. > > >> > > >> Move the call to xen_host_pci_device_get, and the associated error > > >> handling, from xen_pt_realize to the new xen_igd_clear_slot function to > > >> initialize the device class and vendor values which enables the checks for > > >> the Intel IGD to succeed. The verification that the host device is an > > >> Intel IGD to be passed through is done by checking the domain, bus, slot, > > >> and function values as well as by checking that gfx_passthru is enabled, > > >> the device class is VGA, and the device vendor in Intel. > > >> > > >> Signed-off-by: Chuck Zmudzinski > > >> --- > > >> Notes that might be helpful to reviewers of patched code in hw/xen: > > >> > > >> The new functions and types are based on recommendations from Qemu docs: > > >> https://qemu.readthedocs.io/en/latest/devel/qom.html > > >> > > >> Notes that might be helpful to reviewers of patched code in hw/i386: > > >> > > >> The small patch to hw/i386/pc_piix.c is protected by CONFIG_XEN so it does > > >> not affect builds that do not have CONFIG_XEN defined. > > > > > > I'm not sure how you can claim that. > > > > I mean the small patch to pc_piix.c in this patch sits > > between an "#ifdef CONFIG_XEN" and the corresponding > > "#endif" so the preprocessor will exclude it when CONFIG_XEN > > is not defined. In other words, my patch is part of the > > xen-specific code in pc_piix.c. Or am I missing something? > > > > > > > > > > ... > > > > > >> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c > > >> index b48047f50c..34a9736b5e 100644 > > >> --- a/hw/i386/pc_piix.c > > >> +++ b/hw/i386/pc_piix.c > > >> @@ -32,6 +32,7 @@ > > >> #include "hw/i386/pc.h" > > >> #include "hw/i386/apic.h" > > >> #include "hw/pci-host/i440fx.h" > > >> +#include "hw/rtc/mc146818rtc.h" > > >> #include "hw/southbridge/piix.h" > > >> #include "hw/display/ramfb.h" > > >> #include "hw/firmware/smbios.h" > > >> @@ -40,16 +41,16 @@ > > >> #include "hw/usb.h" > > >> #include "net/net.h" > > >> #include "hw/ide/pci.h" > > >> -#include "hw/ide/piix.h" > > >> #include "hw/irq.h" > > >> #include "sysemu/kvm.h" > > >> #include "hw/kvm/clock.h" > > >> #include "hw/sysbus.h" > > >> +#include "hw/i2c/i2c.h" > > >> #include "hw/i2c/smbus_eeprom.h" > > >> #include "hw/xen/xen-x86.h" > > >> +#include "hw/xen/xen.h" > > >> #include "exec/memory.h" > > >> #include "hw/acpi/acpi.h" > > >> -#include "hw/acpi/piix4.h" > > >> #include "qapi/error.h" > > >> #include "qemu/error-report.h" > > >> #include "sysemu/xen.h" > > >> @@ -66,6 +67,7 @@ > > >> #include "kvm/kvm-cpu.h" > > >> > > >> #define MAX_IDE_BUS 2 > > >> +#define XEN_IOAPIC_NUM_PIRQS 128ULL > > >> > > >> #ifdef CONFIG_IDE_ISA > > >> static const int ide_iobase[MAX_IDE_BUS] = { 0x1f0, 0x170 }; > > >> @@ -73,6 +75,32 @@ static const int ide_iobase2[MAX_IDE_BUS] = { 0x3f6, 0x376 }; > > >> static const int ide_irq[MAX_IDE_BUS] = { 14, 15 }; > > >> #endif > > >> > > >> +/* > > >> + * Return the global irq number corresponding to a given device irq > > >> + * pin. We could also use the bus number to have a more precise mapping. > > >> + */ > > >> +static int pci_slot_get_pirq(PCIDevice *pci_dev, int pci_intx) > > >> +{ > > >> + int slot_addend; > > >> + slot_addend = PCI_SLOT(pci_dev->devfn) - 1; > > >> + return (pci_intx + slot_addend) & 3; > > >> +} > > >> + > > >> +static void piix_intx_routing_notifier_xen(PCIDevice *dev) > > >> +{ > > >> + int i; > > >> + > > >> + /* Scan for updates to PCI link routes (0x60-0x63). */ > > >> + for (i = 0; i < PIIX_NUM_PIRQS; i++) { > > >> + uint8_t v = dev->config_read(dev, PIIX_PIRQCA + i, 1); > > >> + if (v & 0x80) { > > >> + v = 0; > > >> + } > > >> + v &= 0xf; > > >> + xen_set_pci_link_route(i, v); > > >> + } > > >> +} > > >> + > > >> /* PC hardware initialisation */ > > >> static void pc_init1(MachineState *machine, > > >> const char *host_type, const char *pci_type) > > >> @@ -84,7 +112,7 @@ static void pc_init1(MachineState *machine, > > >> MemoryRegion *system_io = get_system_io(); > > >> PCIBus *pci_bus; > > >> ISABus *isa_bus; > > >> - int piix3_devfn = -1; > > >> + Object *piix4_pm; > > >> qemu_irq smi_irq; > > >> GSIState *gsi_state; > > >> BusState *idebus[MAX_IDE_BUS]; > > >> @@ -205,10 +233,9 @@ static void pc_init1(MachineState *machine, > > >> gsi_state = pc_gsi_create(&x86ms->gsi, pcmc->pci_enabled); > > >> > > >> if (pcmc->pci_enabled) { > > >> - PIIX3State *piix3; > > >> + DeviceState *dev; > > >> PCIDevice *pci_dev; > > >> - const char *type = xen_enabled() ? TYPE_PIIX3_XEN_DEVICE > > >> - : TYPE_PIIX3_DEVICE; > > >> + int i; > > >> > > >> pci_bus = i440fx_init(pci_type, > > >> i440fx_host, > > >> @@ -216,21 +243,65 @@ static void pc_init1(MachineState *machine, > > >> x86ms->below_4g_mem_size, > > >> x86ms->above_4g_mem_size, > > >> pci_memory, ram_memory); > > >> + pci_bus_map_irqs(pci_bus, > > >> + xen_enabled() ? xen_pci_slot_get_pirq > > >> + : pci_slot_get_pirq); > > >> pcms->bus = pci_bus; > > >> > > >> - pci_dev = pci_create_simple_multifunction(pci_bus, -1, true, type); > > >> - piix3 = PIIX3_PCI_DEVICE(pci_dev); > > >> - piix3->pic = x86ms->gsi; > > >> - piix3_devfn = piix3->dev.devfn; > > >> - isa_bus = ISA_BUS(qdev_get_child_bus(DEVICE(piix3), "isa.0")); > > >> + pci_dev = pci_new_multifunction(-1, true, TYPE_PIIX3_DEVICE); > > >> + object_property_set_bool(OBJECT(pci_dev), "has-usb", > > >> + machine_usb(machine), &error_abort); > > >> + object_property_set_bool(OBJECT(pci_dev), "has-acpi", > > >> + x86_machine_is_acpi_enabled(x86ms), > > >> + &error_abort); > > >> + qdev_prop_set_uint32(DEVICE(pci_dev), "smb_io_base", 0xb100); > > >> + object_property_set_bool(OBJECT(pci_dev), "smm-enabled", > > >> + x86_machine_is_smm_enabled(x86ms), > > >> + &error_abort); > > >> + pci_realize_and_unref(pci_dev, pci_bus, &error_fatal); > > >> + > > >> + if (xen_enabled()) { > > >> + pci_device_set_intx_routing_notifier( > > >> + pci_dev, piix_intx_routing_notifier_xen); > > >> + > > >> + /* > > >> + * Xen supports additional interrupt routes from the PCI devices to > > >> + * the IOAPIC: the four pins of each PCI device on the bus are also > > >> + * connected to the IOAPIC directly. > > >> + * These additional routes can be discovered through ACPI. > > >> + */ > > >> + pci_bus_irqs(pci_bus, xen_intx_set_irq, pci_dev, > > >> + XEN_IOAPIC_NUM_PIRQS); > > >> + } > > >> + > > >> + dev = DEVICE(object_resolve_path_component(OBJECT(pci_dev), "pic")); > > >> + for (i = 0; i < ISA_NUM_IRQS; i++) { > > >> + qdev_connect_gpio_out(dev, i, x86ms->gsi[i]); > > >> + } > > >> + isa_bus = ISA_BUS(qdev_get_child_bus(DEVICE(pci_dev), "isa.0")); > > >> + rtc_state = ISA_DEVICE(object_resolve_path_component(OBJECT(pci_dev), > > >> + "rtc")); > > >> + piix4_pm = object_resolve_path_component(OBJECT(pci_dev), "pm"); > > >> + dev = DEVICE(object_resolve_path_component(OBJECT(pci_dev), "ide")); > > >> + pci_ide_create_devs(PCI_DEVICE(dev)); > > >> + idebus[0] = qdev_get_child_bus(dev, "ide.0"); > > >> + idebus[1] = qdev_get_child_bus(dev, "ide.1"); > > >> } else { > > >> pci_bus = NULL; > > >> + piix4_pm = NULL; > > >> isa_bus = isa_bus_new(NULL, get_system_memory(), system_io, > > >> &error_abort); > > >> + isa_bus_irqs(isa_bus, x86ms->gsi); > > >> + > > >> + rtc_state = isa_new(TYPE_MC146818_RTC); > > >> + qdev_prop_set_int32(DEVICE(rtc_state), "base_year", 2000); > > >> + isa_realize_and_unref(rtc_state, isa_bus, &error_fatal); > > >> + > > >> i8257_dma_init(isa_bus, 0); > > >> pcms->hpet_enabled = false; > > >> + idebus[0] = NULL; > > >> + idebus[1] = NULL; > > >> } > > >> - isa_bus_irqs(isa_bus, x86ms->gsi); > > >> > > >> if (x86ms->pic == ON_OFF_AUTO_ON || x86ms->pic == ON_OFF_AUTO_AUTO) { > > >> pc_i8259_create(isa_bus, gsi_state->i8259_irq); > > >> @@ -252,18 +323,12 @@ static void pc_init1(MachineState *machine, > > >> } > > >> > > >> /* init basic PC hardware */ > > >> - pc_basic_device_init(pcms, isa_bus, x86ms->gsi, &rtc_state, true, > > >> + pc_basic_device_init(pcms, isa_bus, x86ms->gsi, rtc_state, true, > > >> 0x4); > > >> > > >> pc_nic_init(pcmc, isa_bus, pci_bus); > > >> > > >> if (pcmc->pci_enabled) { > > >> - PCIDevice *dev; > > >> - > > >> - dev = pci_create_simple(pci_bus, piix3_devfn + 1, TYPE_PIIX3_IDE); > > >> - pci_ide_create_devs(dev); > > >> - idebus[0] = qdev_get_child_bus(&dev->qdev, "ide.0"); > > >> - idebus[1] = qdev_get_child_bus(&dev->qdev, "ide.1"); > > >> pc_cmos_init(pcms, idebus[0], idebus[1], rtc_state); > > >> } > > >> #ifdef CONFIG_IDE_ISA > > >> @@ -289,21 +354,9 @@ static void pc_init1(MachineState *machine, > > >> } > > >> #endif > > >> > > >> - if (pcmc->pci_enabled && machine_usb(machine)) { > > >> - pci_create_simple(pci_bus, piix3_devfn + 2, "piix3-usb-uhci"); > > >> - } > > >> - > > >> - if (pcmc->pci_enabled && x86_machine_is_acpi_enabled(X86_MACHINE(pcms))) { > > >> - PCIDevice *piix4_pm; > > >> - > > >> + if (piix4_pm) { > > >> smi_irq = qemu_allocate_irq(pc_acpi_smi_interrupt, first_cpu, 0); > > >> - piix4_pm = pci_new(piix3_devfn + 3, TYPE_PIIX4_PM); > > >> - qdev_prop_set_uint32(DEVICE(piix4_pm), "smb_io_base", 0xb100); > > >> - qdev_prop_set_bit(DEVICE(piix4_pm), "smm-enabled", > > >> - x86_machine_is_smm_enabled(x86ms)); > > >> - pci_realize_and_unref(piix4_pm, pci_bus, &error_fatal); > > >> > > >> - qdev_connect_gpio_out(DEVICE(piix4_pm), 0, x86ms->gsi[9]); > > >> qdev_connect_gpio_out_named(DEVICE(piix4_pm), "smi-irq", 0, smi_irq); > > >> pcms->smbus = I2C_BUS(qdev_get_child_bus(DEVICE(piix4_pm), "i2c")); > > >> /* TODO: Populate SPD eeprom data. */ > > >> @@ -315,7 +368,7 @@ static void pc_init1(MachineState *machine, > > >> object_property_allow_set_link, > > >> OBJ_PROP_LINK_STRONG); > > >> object_property_set_link(OBJECT(machine), PC_MACHINE_ACPI_DEVICE_PROP, > > >> - OBJECT(piix4_pm), &error_abort); > > >> + piix4_pm, &error_abort); > > >> } > > >> > > >> if (machine->nvdimms_state->is_enabled) { > > >> @@ -405,6 +458,9 @@ static void pc_xen_hvm_init(MachineState *machine) > > >> } > > >> > > >> pc_xen_hvm_init_pci(machine); > > >> + if (xen_igd_gfx_pt_enabled()) { > > >> + xen_igd_reserve_slot(pcms->bus); > > >> + } > > These are the three lines from my patch that are added to > pc_piix.c. IIUC, this diff is showing the differences in pc_piix.c > without and with CONFIG_XEN defined. changing configure flags does not modify pc_piix.c IIUC. configure changes compiler flags and some generated files (mostly headers). AFAIK pc_piix.c is not one of them. > If so, then the fact that > the lines in my patch are added when CONFIG_XEN is defined > means they are not included as part of the build when CONFIG_XEN > is not defined. That is how I can claim that my small patch to > pc_piix.c does not affect builds without CONFIG_XEN defined. > Doesn't make sense to me, sorry. > I also think the rest of the files touched by my patch are only included > by the meson build system with the --enable-xen an option to configure. > So the entire patch is xen-specific and can easily be eliminated from > any build with the --disable-xen configure option. > > Kind regards, > > Chuck > > > >> pci_create_simple(pcms->bus, -1, "xen-platform"); > > >> } > > >> #endif > > >> @@ -441,6 +497,11 @@ static void pc_i440fx_8_0_machine_options(MachineClass *m) > > >> pc_i440fx_machine_options(m); > > >> m->alias = "pc"; > > >> m->is_default = true; > > >> +#ifdef CONFIG_MICROVM_DEFAULT > > >> + m->is_default = false; > > >> +#else > > >> + m->is_default = true; > > >> +#endif > > >> } > > >> > > >> DEFINE_I440FX_MACHINE(v8_0, "pc-i440fx-8.0", NULL, > > > > > > > > > Lots of changes here not guarded by CONFIG_XEN. > > > > > > > What diff is this? How is my patch related to it? > > From xen-devel-bounces@lists.xenproject.org Tue Jan 10 05:48:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 05:48:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474267.735338 (Exim 4.92) (envelope-from ) id 1pF7UP-00085M-Ft; Tue, 10 Jan 2023 05:48:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474267.735338; Tue, 10 Jan 2023 05:48:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF7UP-00085F-Ct; Tue, 10 Jan 2023 05:48:01 +0000 Received: by outflank-mailman (input) for mailman id 474267; Tue, 10 Jan 2023 05:48:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF7UP-000859-0G for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 05:48:01 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5645e610-90aa-11ed-b8d0-410ff93cb8f0; Tue, 10 Jan 2023 06:47:58 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id DF75E4DC62; Tue, 10 Jan 2023 05:47:57 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A3B3713458; Tue, 10 Jan 2023 05:47:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id uVKCJg38vGNyRgAAMHmgww (envelope-from ); Tue, 10 Jan 2023 05:47:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5645e610-90aa-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1673329677; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6nR2J48veGxgqbDtj3mpE0l8hzEZ8e4y9D3DftLzn5w=; b=sQmGPAehePLtDdoBg7Pz/MNCfPqEDN2lQqd0h1bQhgM/4WgUu/kr39MOv8woNuhkfOlpwO Cdd39ALB9rCo2dyWVve2DeT4dFriFkOAo0xf0q5zCtkku7XqiMjSW4G+52+Nl509NSwvee XZxc0R38z/drh22FG/QIYp617jXQAKU= Message-ID: <03edcbc5-2dd7-1ddb-bafe-8412d8fc95aa@suse.com> Date: Tue, 10 Jan 2023 06:47:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: Problem with pat_enable() and commit 72cbc8f04fe2 Content-Language: en-US To: "Michael Kelley (LINUX)" , Andrew Lutomirski , Jan Beulich , Dave Hansen , Peter Zijlstra Cc: "linux-kernel@vger.kernel.org" , "xen-devel@lists.xenproject.org" References: From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------s2hryonzbwnhOTjl3olsUKO7" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------s2hryonzbwnhOTjl3olsUKO7 Content-Type: multipart/mixed; boundary="------------Az9IynJ4vGV7ZPasu5p0pfX8"; protected-headers="v1" From: Juergen Gross To: "Michael Kelley (LINUX)" , Andrew Lutomirski , Jan Beulich , Dave Hansen , Peter Zijlstra Cc: "linux-kernel@vger.kernel.org" , "xen-devel@lists.xenproject.org" Message-ID: <03edcbc5-2dd7-1ddb-bafe-8412d8fc95aa@suse.com> Subject: Re: Problem with pat_enable() and commit 72cbc8f04fe2 References: In-Reply-To: --------------Az9IynJ4vGV7ZPasu5p0pfX8 Content-Type: multipart/mixed; boundary="------------PVNmTecz6Ude3kl9G08cGM1s" --------------PVNmTecz6Ude3kl9G08cGM1s Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDkuMDEuMjMgMTk6MjgsIE1pY2hhZWwgS2VsbGV5IChMSU5VWCkgd3JvdGU6DQo+IEkn dmUgY29tZSBhY3Jvc3MgYSBjYXNlIHdpdGggYSBWTSBydW5uaW5nIG9uIEh5cGVyLVYgdGhh dCBkb2Vzbid0IGdldA0KPiBNVFJScywgYnV0IHRoZSBQQVQgaXMgZnVuY3Rpb25hbC4gIChU aGlzIGlzIGEgQ29uZmlkZW50aWFsIFZNIHVzaW5nDQo+IEFNRCdzIFNFVi1TTlAgZW5jcnlw dGlvbiB0ZWNobm9sb2d5IHdpdGggdGhlIHZUT00gb3B0aW9uLikgIEluIHRoaXMNCj4gY2Fz ZSwgdGhlIGNoYW5nZXMgaW4gY29tbWl0IDcyY2JjOGYwNGZlMiAoIng4Ni9QQVQ6IEhhdmUg cGF0X2VuYWJsZWQoKQ0KPiBwcm9wZXJseSByZWZsZWN0IHN0YXRlIHdoZW4gcnVubmluZyBv biBYZW4iKSBhcHBseS4gICBwYXRfZW5hYmxlZCgpIHJldHVybnMNCj4gInRydWUiLCBidXQg dGhlIE1UUlJzIGFyZSBub3QgZW5hYmxlZC4NCj4gDQo+IEJ1dCB3aXRoIHRoaXMgY29tbWl0 LCB0aGVyZSdzIGEgcHJvYmxlbS4gIENvbnNpZGVyIG1lbXJlbWFwKCkgb24gYSBSQU0NCj4g cmVnaW9uLCBjYWxsZWQgd2l0aCBNRU1SRU1BUF9XQiBwbHVzIE1FTVJFTUFQX0RFQyBhcyB0 aGUgM3JkDQo+IGFyZ3VtZW50LiBCZWNhdXNlIG9mIHRoZSByZXF1ZXN0IGZvciBhIGRlY3J5 cHRlZCBtYXBwaW5nLA0KPiBhcmNoX21lbXJlbWFwX2Nhbl9yYW1fcmVtYXAoKSByZXR1cm5z IGZhbHNlLCBhbmQgYSBuZXcgbWFwcGluZw0KPiBtdXN0IGJlIGNyZWF0ZWQsIHdoaWNoIGlz IGFwcHJvcHJpYXRlLg0KPiANCj4gVGhlIGZvbGxvd2luZyBjYWxsIHN0YWNrIHJlc3VsdHM6 DQo+IA0KPiAgICBtZW1yZW1hcCgpDQo+ICAgIGFyY2hfbWVtcmVtYXBfd2IoKQ0KPiAgICBp b3JlbWFwX2NhY2hlKCkNCj4gICAgX19pb3JlbWFwX2NhbGxlcigpDQo+ICAgIG1lbXR5cGVf cmVzZXJ2ZSgpICA8LS0tIHBjbSBpcyBfUEFHRV9DQUNIRV9NT0RFX1dCDQo+ICAgIHBhdF94 X210cnJfdHlwZSgpICA8LS0gb25seSBjYWxsZWQgYWZ0ZXIgY29tbWl0IDcyY2JjOGYwNGZl Mg0KPiANCj4gcGF0X3hfbXRycl90eXBlKCkgcmV0dXJucyBfUEFHRV9DQUNIRV9NT0RFX1VD X01JTlVTIGJlY2F1c2UNCj4gbXRycl90eXBlX2xvb2t1cCgpIGZhaWxzLiAgQXMgYSByZXN1 bHQsIG1lbXJlbWFwKCkgZXJyb25lb3VzbHkgY3JlYXRlcyB0aGUNCj4gbmV3IG1hcHBpbmcg YXMgdW5jYWNoZWQuICAgVGhpcyB1bmNhY2hlZCBtYXBwaW5nIGlzIGNhdXNpbmcgYSBzaWdu aWZpY2FudA0KPiBwZXJmb3JtYW5jZSBwcm9ibGVtIGluIGNlcnRhaW4gSHlwZXItViBDb25m aWRlbnRpYWwgVk0gY29uZmlndXJhdGlvbnMuDQo+IA0KPiBBbnkgdGhvdWdodHMgb24gcmVz b2x2aW5nIHRoaXM/ICBTaG91bGQgbWVtdHlwZV9yZXNlcnZlKCkgYmUgY2hlY2tpbmcNCj4g Ym90aCBwYXRfZW5hYmxlZCgpICphbmQqIHdoZXRoZXIgTVRSUnMgYXJlIGVuYWJsZWQgYmVm b3JlIGNhbGxpbmcNCj4gcGF0X3hfbXRycl90eXBlKCk/ICBPciBkb2VzIHRoYXQgZGVmZWF0 IHRoZSBwdXJwb3NlIG9mIGNvbW1pdA0KPiA3MmNiYzhmMDRmZTIgaW4gdGhlIFhlbiBlbnZp cm9ubWVudD8NCg0KSSB0aGluayBwYXRfeF9tdHJyX3R5cGUoKSBzaG91bGQgcmV0dXJuIF9Q QUdFX0NBQ0hFX01PREVfVUNfTUlOVVMgb25seSBpZg0KbXRycl90eXBlX2xvb2t1cCgpIGlz IG5vdCBmYWlsaW5nIGFuZCBpcyByZXR1cm5pbmcgYSBtb2RlIG90aGVyIHRoYW4gV0IuDQoN CkknbGwgc2VuZCBhIHBhdGNoLg0KDQo+IEknbSBhbHNvIGxvb2tpbmcgYXQgaG93IHRvIGF2 b2lkIHRoaXMgY29tYmluYXRpb24gaW4gYSBIeXBlci1WIENvbmZpZGVudGlhbA0KPiBWTSwg YnV0IHRoYXQgZG9lc24ndCBhZGRyZXNzIHVuZGVybHlpbmcgdGhlIGZsYXcuDQoNClllcy4N Cg0KDQpKdWVyZ2VuDQo= --------------PVNmTecz6Ude3kl9G08cGM1s Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------PVNmTecz6Ude3kl9G08cGM1s-- --------------Az9IynJ4vGV7ZPasu5p0pfX8-- --------------s2hryonzbwnhOTjl3olsUKO7 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmO8/A0FAwAAAAAACgkQsN6d1ii/Ey+E XQf9FXFccfJOnG/tmPwFInZjxEORcoptE0XtMp96Sp5kVPsgPzBj4Tgmx1bVlxG8UNrAtIl18Txy 7M6k2SbkWOsoLPqM2USmvmYDlBAhjbUDvrSh16HTzQDrfAO8YT5MDAIrwtcBNJ6D6mggFIOAbg7G 9rfHHcuA6U1+zNXOlvZWIcjOEqRLkOYH21eYczxBQZYf+nbgA31kOPqf7l58RQBHbn1ThUIzsEDl 2PS4cxMwwgIsvFeXP586iuaBTMIS+YFkJ4haajpguYMWtql0332j9a0eWSwlHUomWFbrSGConyrS WgAgSWeC7BNIT7B19vM3UKZXnQsAcrr/d0NWC36cxA== =lv3X -----END PGP SIGNATURE----- --------------s2hryonzbwnhOTjl3olsUKO7-- From xen-devel-bounces@lists.xenproject.org Tue Jan 10 05:59:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 05:59:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474273.735349 (Exim 4.92) (envelope-from ) id 1pF7fj-0001Af-Gu; Tue, 10 Jan 2023 05:59:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474273.735349; Tue, 10 Jan 2023 05:59:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF7fj-0001AY-E2; Tue, 10 Jan 2023 05:59:43 +0000 Received: by outflank-mailman (input) for mailman id 474273; Tue, 10 Jan 2023 05:59:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF7fi-0001AS-4r for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 05:59:42 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f8879c41-90ab-11ed-91b6-6bf2151ebd3b; Tue, 10 Jan 2023 06:59:40 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 17595612FE; Tue, 10 Jan 2023 05:59:38 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D371E1358A; Tue, 10 Jan 2023 05:59:37 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id IcYgMsn+vGMASwAAMHmgww (envelope-from ); Tue, 10 Jan 2023 05:59:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f8879c41-90ab-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1673330378; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aF338VeMd8mOG+zXjPDXJGd2RkUVJK3TeF08hiwUm6Q=; b=KTZbsyV6KslH4Fbu+GLkmPyl0I184Qoa384lQ+XFvMCkiTwfx9siYJHO1uC18cre/Q41fI pEv6pUPPn52RcJXlDAsOouwV0Bsf+aXRydGHD53GVkuvnoGf7O88AEHI1EZCih9EOkvTU6 xc9ws0/gr5QH/OW+4DZqxLVnmRKvg1k= Message-ID: Date: Tue, 10 Jan 2023 06:59:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: Problem with pat_enable() and commit 72cbc8f04fe2 Content-Language: en-US From: Juergen Gross To: "Michael Kelley (LINUX)" , Andrew Lutomirski , Jan Beulich , Dave Hansen , Peter Zijlstra Cc: "linux-kernel@vger.kernel.org" , "xen-devel@lists.xenproject.org" References: <03edcbc5-2dd7-1ddb-bafe-8412d8fc95aa@suse.com> In-Reply-To: <03edcbc5-2dd7-1ddb-bafe-8412d8fc95aa@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------NCcMP466BJPyiDVM1qKkw022" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------NCcMP466BJPyiDVM1qKkw022 Content-Type: multipart/mixed; boundary="------------Q25iRST94k8C9636ZAsL0ppF"; protected-headers="v1" From: Juergen Gross To: "Michael Kelley (LINUX)" , Andrew Lutomirski , Jan Beulich , Dave Hansen , Peter Zijlstra Cc: "linux-kernel@vger.kernel.org" , "xen-devel@lists.xenproject.org" Message-ID: Subject: Re: Problem with pat_enable() and commit 72cbc8f04fe2 References: <03edcbc5-2dd7-1ddb-bafe-8412d8fc95aa@suse.com> In-Reply-To: <03edcbc5-2dd7-1ddb-bafe-8412d8fc95aa@suse.com> --------------Q25iRST94k8C9636ZAsL0ppF Content-Type: multipart/mixed; boundary="------------HvmiliKnfQFHcSOjC0mQZzph" --------------HvmiliKnfQFHcSOjC0mQZzph Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTAuMDEuMjMgMDY6NDcsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+IE9uIDA5LjAxLjIz IDE5OjI4LCBNaWNoYWVsIEtlbGxleSAoTElOVVgpIHdyb3RlOg0KPj4gSSd2ZSBjb21lIGFj cm9zcyBhIGNhc2Ugd2l0aCBhIFZNIHJ1bm5pbmcgb24gSHlwZXItViB0aGF0IGRvZXNuJ3Qg Z2V0DQo+PiBNVFJScywgYnV0IHRoZSBQQVQgaXMgZnVuY3Rpb25hbC7CoCAoVGhpcyBpcyBh IENvbmZpZGVudGlhbCBWTSB1c2luZw0KPj4gQU1EJ3MgU0VWLVNOUCBlbmNyeXB0aW9uIHRl Y2hub2xvZ3kgd2l0aCB0aGUgdlRPTSBvcHRpb24uKcKgIEluIHRoaXMNCj4+IGNhc2UsIHRo ZSBjaGFuZ2VzIGluIGNvbW1pdCA3MmNiYzhmMDRmZTIgKCJ4ODYvUEFUOiBIYXZlIHBhdF9l bmFibGVkKCkNCj4+IHByb3Blcmx5IHJlZmxlY3Qgc3RhdGUgd2hlbiBydW5uaW5nIG9uIFhl biIpIGFwcGx5LsKgwqAgcGF0X2VuYWJsZWQoKSByZXR1cm5zDQo+PiAidHJ1ZSIsIGJ1dCB0 aGUgTVRSUnMgYXJlIG5vdCBlbmFibGVkLg0KPj4NCj4+IEJ1dCB3aXRoIHRoaXMgY29tbWl0 LCB0aGVyZSdzIGEgcHJvYmxlbS7CoCBDb25zaWRlciBtZW1yZW1hcCgpIG9uIGEgUkFNDQo+ PiByZWdpb24sIGNhbGxlZCB3aXRoIE1FTVJFTUFQX1dCIHBsdXMgTUVNUkVNQVBfREVDIGFz IHRoZSAzcmQNCj4+IGFyZ3VtZW50LiBCZWNhdXNlIG9mIHRoZSByZXF1ZXN0IGZvciBhIGRl Y3J5cHRlZCBtYXBwaW5nLA0KPj4gYXJjaF9tZW1yZW1hcF9jYW5fcmFtX3JlbWFwKCkgcmV0 dXJucyBmYWxzZSwgYW5kIGEgbmV3IG1hcHBpbmcNCj4+IG11c3QgYmUgY3JlYXRlZCwgd2hp Y2ggaXMgYXBwcm9wcmlhdGUuDQo+Pg0KPj4gVGhlIGZvbGxvd2luZyBjYWxsIHN0YWNrIHJl c3VsdHM6DQo+Pg0KPj4gwqDCoCBtZW1yZW1hcCgpDQo+PiDCoMKgIGFyY2hfbWVtcmVtYXBf d2IoKQ0KPj4gwqDCoCBpb3JlbWFwX2NhY2hlKCkNCj4+IMKgwqAgX19pb3JlbWFwX2NhbGxl cigpDQo+PiDCoMKgIG1lbXR5cGVfcmVzZXJ2ZSgpwqAgPC0tLSBwY20gaXMgX1BBR0VfQ0FD SEVfTU9ERV9XQg0KPj4gwqDCoCBwYXRfeF9tdHJyX3R5cGUoKcKgIDwtLSBvbmx5IGNhbGxl ZCBhZnRlciBjb21taXQgNzJjYmM4ZjA0ZmUyDQo+Pg0KPj4gcGF0X3hfbXRycl90eXBlKCkg cmV0dXJucyBfUEFHRV9DQUNIRV9NT0RFX1VDX01JTlVTIGJlY2F1c2UNCj4+IG10cnJfdHlw ZV9sb29rdXAoKSBmYWlscy7CoCBBcyBhIHJlc3VsdCwgbWVtcmVtYXAoKSBlcnJvbmVvdXNs eSBjcmVhdGVzIHRoZQ0KPj4gbmV3IG1hcHBpbmcgYXMgdW5jYWNoZWQuwqDCoCBUaGlzIHVu Y2FjaGVkIG1hcHBpbmcgaXMgY2F1c2luZyBhIHNpZ25pZmljYW50DQo+PiBwZXJmb3JtYW5j ZSBwcm9ibGVtIGluIGNlcnRhaW4gSHlwZXItViBDb25maWRlbnRpYWwgVk0gY29uZmlndXJh dGlvbnMuDQo+Pg0KPj4gQW55IHRob3VnaHRzIG9uIHJlc29sdmluZyB0aGlzP8KgIFNob3Vs ZCBtZW10eXBlX3Jlc2VydmUoKSBiZSBjaGVja2luZw0KPj4gYm90aCBwYXRfZW5hYmxlZCgp ICphbmQqIHdoZXRoZXIgTVRSUnMgYXJlIGVuYWJsZWQgYmVmb3JlIGNhbGxpbmcNCj4+IHBh dF94X210cnJfdHlwZSgpP8KgIE9yIGRvZXMgdGhhdCBkZWZlYXQgdGhlIHB1cnBvc2Ugb2Yg Y29tbWl0DQo+PiA3MmNiYzhmMDRmZTIgaW4gdGhlIFhlbiBlbnZpcm9ubWVudD8NCj4gDQo+ IEkgdGhpbmsgcGF0X3hfbXRycl90eXBlKCkgc2hvdWxkIHJldHVybiBfUEFHRV9DQUNIRV9N T0RFX1VDX01JTlVTIG9ubHkgaWYNCj4gbXRycl90eXBlX2xvb2t1cCgpIGlzIG5vdCBmYWls aW5nIGFuZCBpcyByZXR1cm5pbmcgYSBtb2RlIG90aGVyIHRoYW4gV0IuDQoNCkFub3RoZXIg aWRlYSB3b3VsZCBiZSB0byBsZXQgdGhlIG10cnJfdHlwZV9sb29rdXAoKSBzdHViIGluDQph cmNoL3g4Ni9pbmNsdWRlL2FzbS9tdHJyLmggcmV0dXJuIE1UUlJfVFlQRV9XUkJBQ0ssIGVu YWJsaW5nIHRvIHNpbXBsaWZ5DQpwdWRfc2V0X2h1Z2UoKSBhbmQgcG1kX3NldF9odWdlKCkg YnkgcmVtb3ZpbmcgdGhlIGNoZWNrIGZvciBNVFJSX1RZUEVfSU5WQUxJRC4NCg0KDQpKdWVy Z2VuDQo= --------------HvmiliKnfQFHcSOjC0mQZzph Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------HvmiliKnfQFHcSOjC0mQZzph-- --------------Q25iRST94k8C9636ZAsL0ppF-- --------------NCcMP466BJPyiDVM1qKkw022 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmO8/skFAwAAAAAACgkQsN6d1ii/Ey84 Cwf9G/P++wHlaCcX8j+JRBcoA9jKCSsN2iWkWtxi0WC9kZpybt58HDx1D2QPHYD2raTtF5s+NAkr IDXa8QMCVXWDsDEzXbrDjjascvUtG2HViGemQe4YDNbqNqSRH43pu9qiF7aR6GC87w/aV5Ma0bwZ FYfbGJsqT8wkH0IjMYglU63GCQw4sjjoR7V1sXR+SYVqHH7dy1PTj7XBcwEDw/Lk6mS4ihor79Zk voE3hwtt8VfY8sHSTC5AAr1vIt3i2DaAN8cDqGX2ah//JUvI9PwsbwW+wqPhjaLc9/GGxm6m4+5Q qrjZdGfbfw1smAfHptLkYsBB4c4E9eTzt40UI8nOkA== =ff7s -----END PGP SIGNATURE----- --------------NCcMP466BJPyiDVM1qKkw022-- From xen-devel-bounces@lists.xenproject.org Tue Jan 10 05:59:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 05:59:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474274.735360 (Exim 4.92) (envelope-from ) id 1pF7fv-0001SH-Ok; Tue, 10 Jan 2023 05:59:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474274.735360; Tue, 10 Jan 2023 05:59:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF7fv-0001SA-M6; Tue, 10 Jan 2023 05:59:55 +0000 Received: by outflank-mailman (input) for mailman id 474274; Tue, 10 Jan 2023 05:59:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF7fu-0001AS-7W for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 05:59:54 +0000 Received: from sonic317-22.consmr.mail.gq1.yahoo.com (sonic317-22.consmr.mail.gq1.yahoo.com [98.137.66.148]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fe31a185-90ab-11ed-91b6-6bf2151ebd3b; Tue, 10 Jan 2023 06:59:51 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic317.consmr.mail.gq1.yahoo.com with HTTP; Tue, 10 Jan 2023 05:59:48 +0000 Received: by hermes--production-ne1-7b69748c4d-bgkrh (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID a8406ef0cbcbedb2d3599d546f1be4ba; Tue, 10 Jan 2023 05:59:46 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fe31a185-90ab-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1673330388; bh=IQswRJ3mNTU2rW5CB8ekxkuMTpc6VFiPyScNDj65O6E=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=uDAO4jcip6hhG13sRDD1TCwo0Uy/ZDmUpsQI5dm6JQeRwMERoUDWoefNyRxPifmxaggFFP7k+Klch+9QGaefYYZjP8wGtpPRBm8LkkUH9JJHOvmgGWjvWSKRq0ArOnuJrReNrYwkQ5Ym9C6/Z8zr3J70MfvrFS+tKTPx3Ry3JCwvCuqIMMDkSPI4d3H2xAThT0XlCvna6iRc+wO9gNbDsdQ9avTo8OPMPSBa4LKKtOehMEltjciFzvl6RqBFKS4t2ntuw8vAoEJ/yLLnLoXltaq7WUm1lpArzqU3tKsWCCajiSnfBjxikpYcSMF67SaOgH2q8erCgSXhTY+MjlxbbQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1673330388; bh=LZqtAdaC54vL/ejVGshCmWeWyIi/se6my3VUn5Dvwku=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=riia0ZVjp6RfB8x36IDIyJla5JSgDYpM0brW+qZKNvGQduPP+3hW6fTptr9Fe7wLst4DmdyMTRnfEoZd15fNojl/Igcu97YD5WsxFloHZt9cpOVxxhIzhhb8R6o0BRJzypgEFGhHU4SFrQS7QRKpYit0635OhZ3fC7rNn3Nwy994hNUYBiKXCH1bRjbi+4aYJJztwVW6i/AZXNrLDOrZ2IUGpa9KSQoMZbR7OQdSC8YJCSCP8mjYiQtD8ezAqUrjFyNq1Rdm4LffKIsG7bGs1TWF31DU/x7Xb9UyV3KlSDQJucbD914Tz1PiToTyGbuuLN9jbiqCyFXbzZ+ik6T9+A== X-YMail-OSG: L4UlU_MVM1leDEms_BcRLMUJc.6udPFe1VgzSYs9.g3zFCK3S7ZEr18nxUJJtnY ciVYSmIVPGDtams3XtAwHf_5Q6ILQOZ6zcYHq_fDFTVYAWlQw_cz_79xklgKkisEhs8PLATiILFk zLPiUqdQ3WF2Kbde9ZLavisvZkcmb_EEq2JXMTGqX47_mbuGqqsXVAwWCC7F6FQ0YBM3qEx_cr8A dgIhYpGvipfbYcew6KQFDt13QfdTMb0X92chYEX7F_Qq40JSYXhcyF2I2yEfhHnJLiXOHCFU4qCd Ani6DWHP9.sRfmmmvb0BGKSlGg7she7RQRZRc9fByontYFDIVOVE58jlv8hUG8IvyK8dPGTtu8E3 MBx_tKSaAUg928xVgxYsEE_lF9Wsx6h7ZdJxa5SM1ycc75GkXtjEWUAiIu1UEtypcrZbrklXsWZT KebkKCKtklzLYJbEWDSgqtZe1zHu6yZ1UE6jrQjcAl.EkGC6T48gJVy_q60Qz7A0GXtZjFEuUvoA lF.yk0YgTxRMxsxhhkd.1Ra4366vn_hEbvtswegcdSLYp5jTzni_Qz4eWhh4JnpzpPA0EMDMwmSP Rgb9YsWyhQHCGx4O6SLIxBI.LK8.2PN0rMIWwojeMHF4lheGmO2FD3wT606w770xIeEgRdE07W2C BHrLKQ_vYR3pAilt.l_Ds66Aar47ZgGhcYvL.ArirvAsD94OotjqNLxMWso_iG16xOaan0RzJ4Aq aOT1h3QiMehNdF4_P3roQJnRkCpzaEiPtcMW_z.ZBCq.kYaWM4bIqo9V78ugAKYYWSe.tS3QOMgt BKUgw1dKYse7cBe7hnrCEqhkjW0yXvFOrsUlCoEO2l.njf71KoAwFmvit6XYL02MTqomPqBCXNpH mCBzaF_8E6gzQebzU0yX3FRBW3k4MrfylZTji1pN69uOl_9mdcH10mGdiBPIio7v7MtZup3JPr2n fAhet_x77uZq9CSoLwIhxEVcZChfkCADN7vMEabiLVuZNtKPXrHdsYNeXSLoOld1wR.Sufddxs.A DtfeXcEUqvbBgBc4970Y7UTWNCd2N72hHOTgClYNUOW0zPi10SRL0UTYjw8ZrzUDrHnAPqikvcnx XSow69zQJqdcFSajakkka_cBVWTf9AO1kL2pfZuF1DOZPbMdIMRLXerym0lR2DhapuGriv5n8LhI .KBr9EDrLeTj9HRwBnOgzi3BKX9sgSEoDrlmxP5A7SV2crk1TbPwXFmWkIeO15Wey37E0ADYmLEO rIOLwF_qq3Lwj5JCOSHX30uFdax64CCdHAlZmBi5mXANvGGi6R8GY8ley7mbcT0K6CK5s_y3qGGN oGD.QPsapvby01QGSdJdZLKClSJRtkxVYQ54_Fuc15LVuwAatxQWbsBY3HZ5JFd8CMFaNE0NT9MV j6aGCl9UYQaF27OwcWFoaIGXevW3htJXIQLbBirn5Ked75fWyiwJBHSPawVNTgLPtNgkH4lOt51S KaXCn8rPmX.DqsyhCAXOA0csJEY_HIZpQUbkMrqSGDp_7ivRmda65e90cgbwOLfxXhqVrRctpT.T D4mxvFwthNKrE0vXJ6w4HcmINGhe2LI.lBdZcPgUg0ik24xbURgymsCHYi17gE23r9f3N0JK65dc DO735PWN5eJLQ_pLWO7BFkiP8E_EjBqPXT6EC_6NXKueHEkm5ay_Y12DN2dZZ0Hv_7zMFZAlZQLC upAERu.3Salf5p3hvF_JWl82VllHqNO2XaZNMYQzPrtxcuBGzLKSUEe06cOMs1Orkbo1yQ.JfR1I rjVbnY6eCU3N3Jk0KhtnVsvO_wisdhBRGU.iq4DvYNHNfGcuzZr5op69jZ9vi.UdL8oCfkUb8JjI i0jva1QxsasNWFRtmzwySoyFdW6Y2xexRJztBR2I_U1qAfHaWY194dxSh07lbTEPB_WCF3CoA42o O6e5ZiVQETuEp4iJZxjf53z0QcxbgEu1EmydIfZwwUQq.sb4EB8QGygdZ4QGIPmHwxwpduXmDnnb SHPd_nDD3FoGCybQ6RUF6Q5mCr9BFRouIicx_F_3IBZqhZA2smKMZNSd9PCCGSj5g9RFJbm.uqO3 .BORoGiJ8GR7Rveyl_fIbeTMSqVIMTlKZ0781olKwxCz5_qNiZlT_pKzvbc2wyuoC_9dkBf3eGxC NQnqnYR1CDuOt_ZQTZrfbA73JBiw0uWzSlWzOLkx7MOPj.jDzbKBZHp_sxGrqQthnbJb5jAlNzKM dJzKAOfDMkHUg X-Sonic-MF: Message-ID: <5d8b4bfd-92b3-e63a-58fa-b2dc953a7ee5@aol.com> Date: Tue, 10 Jan 2023 00:59:44 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v7] xen/pt: reserve PCI slot 2 for Intel igd-passthru Content-Language: en-US To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org, Stefano Stabellini , Anthony Perard , Paul Durrant , Paolo Bonzini , Richard Henderson , Eduardo Habkost , Marcel Apfelbaum , xen-devel@lists.xenproject.org References: <8349506149de6d81b0762f17623552c248439e93.1673297742.git.brchuckz.ref@aol.com> <8349506149de6d81b0762f17623552c248439e93.1673297742.git.brchuckz@aol.com> <20230109183132-mutt-send-email-mst@kernel.org> <20230110002712-mutt-send-email-mst@kernel.org> From: Chuck Zmudzinski In-Reply-To: <20230110002712-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.20982 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 15531 On 1/10/2023 12:27 AM, Michael S. Tsirkin wrote: > On Mon, Jan 09, 2023 at 07:05:35PM -0500, Chuck Zmudzinski wrote: > > On 1/9/23 6:33 PM, Michael S. Tsirkin wrote: > > > On Mon, Jan 09, 2023 at 04:55:42PM -0500, Chuck Zmudzinski wrote: > > >> Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, > > >> as noted in docs/igd-assign.txt in the Qemu source code. > > >> > > >> Currently, when the xl toolstack is used to configure a Xen HVM guest with > > >> Intel IGD passthrough to the guest with the Qemu upstream device model, > > >> a Qemu emulated PCI device will occupy slot 2 and the Intel IGD will occupy > > >> a different slot. This problem often prevents the guest from booting. > > >> > > >> The only available workaround is not good: Configure Xen HVM guests to use > > >> the old and no longer maintained Qemu traditional device model available > > >> from xenbits.xen.org which does reserve slot 2 for the Intel IGD. > > >> > > >> To implement this feature in the Qemu upstream device model for Xen HVM > > >> guests, introduce the following new functions, types, and macros: > > >> > > >> * XEN_PT_DEVICE_CLASS declaration, based on the existing TYPE_XEN_PT_DEVICE > > >> * XEN_PT_DEVICE_GET_CLASS macro helper function for XEN_PT_DEVICE_CLASS > > >> * typedef XenPTQdevRealize function pointer > > >> * XEN_PCI_IGD_SLOT_MASK, the value of slot_reserved_mask to reserve slot 2 > > >> * xen_igd_reserve_slot and xen_igd_clear_slot functions > > >> > > >> The new xen_igd_reserve_slot function uses the existing slot_reserved_mask > > >> member of PCIBus to reserve PCI slot 2 for Xen HVM guests configured using > > >> the xl toolstack with the gfx_passthru option enabled, which sets the > > >> igd-passthru=on option to Qemu for the Xen HVM machine type. > > >> > > >> The new xen_igd_reserve_slot function also needs to be implemented in > > >> hw/xen/xen_pt_stub.c to prevent FTBFS during the link stage for the case > > >> when Qemu is configured with --enable-xen and --disable-xen-pci-passthrough, > > >> in which case it does nothing. > > >> > > >> The new xen_igd_clear_slot function overrides qdev->realize of the parent > > >> PCI device class to enable the Intel IGD to occupy slot 2 on the PCI bus > > >> since slot 2 was reserved by xen_igd_reserve_slot when the PCI bus was > > >> created in hw/i386/pc_piix.c for the case when igd-passthru=on. > > >> > > >> Move the call to xen_host_pci_device_get, and the associated error > > >> handling, from xen_pt_realize to the new xen_igd_clear_slot function to > > >> initialize the device class and vendor values which enables the checks for > > >> the Intel IGD to succeed. The verification that the host device is an > > >> Intel IGD to be passed through is done by checking the domain, bus, slot, > > >> and function values as well as by checking that gfx_passthru is enabled, > > >> the device class is VGA, and the device vendor in Intel. > > >> > > >> Signed-off-by: Chuck Zmudzinski > > >> --- > > >> Notes that might be helpful to reviewers of patched code in hw/xen: > > >> > > >> The new functions and types are based on recommendations from Qemu docs: > > >> https://qemu.readthedocs.io/en/latest/devel/qom.html > > >> > > >> Notes that might be helpful to reviewers of patched code in hw/i386: > > >> > > >> The small patch to hw/i386/pc_piix.c is protected by CONFIG_XEN so it does > > >> not affect builds that do not have CONFIG_XEN defined. > > > > > > I'm not sure how you can claim that. > > > > I mean the small patch to pc_piix.c in this patch sits > > between an "#ifdef CONFIG_XEN" and the corresponding > > "#endif" so the preprocessor will exclude it when CONFIG_XEN > > is not defined. In other words, my patch is part of the > > xen-specific code in pc_piix.c. Or am I missing something? > > > > > > > > > > ... > > > > > >> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c > > >> index b48047f50c..34a9736b5e 100644 > > >> --- a/hw/i386/pc_piix.c > > >> +++ b/hw/i386/pc_piix.c > > >> @@ -32,6 +32,7 @@ > > >> #include "hw/i386/pc.h" > > >> #include "hw/i386/apic.h" > > >> #include "hw/pci-host/i440fx.h" > > >> +#include "hw/rtc/mc146818rtc.h" > > >> #include "hw/southbridge/piix.h" > > >> #include "hw/display/ramfb.h" > > >> #include "hw/firmware/smbios.h" > > >> @@ -40,16 +41,16 @@ > > >> #include "hw/usb.h" > > >> #include "net/net.h" > > >> #include "hw/ide/pci.h" > > >> -#include "hw/ide/piix.h" > > >> #include "hw/irq.h" > > >> #include "sysemu/kvm.h" > > >> #include "hw/kvm/clock.h" > > >> #include "hw/sysbus.h" > > >> +#include "hw/i2c/i2c.h" > > >> #include "hw/i2c/smbus_eeprom.h" > > >> #include "hw/xen/xen-x86.h" > > >> +#include "hw/xen/xen.h" > > >> #include "exec/memory.h" > > >> #include "hw/acpi/acpi.h" > > >> -#include "hw/acpi/piix4.h" > > >> #include "qapi/error.h" > > >> #include "qemu/error-report.h" > > >> #include "sysemu/xen.h" > > >> @@ -66,6 +67,7 @@ > > >> #include "kvm/kvm-cpu.h" > > >> > > >> #define MAX_IDE_BUS 2 > > >> +#define XEN_IOAPIC_NUM_PIRQS 128ULL > > >> > > >> #ifdef CONFIG_IDE_ISA > > >> static const int ide_iobase[MAX_IDE_BUS] = { 0x1f0, 0x170 }; > > >> @@ -73,6 +75,32 @@ static const int ide_iobase2[MAX_IDE_BUS] = { 0x3f6, 0x376 }; > > >> static const int ide_irq[MAX_IDE_BUS] = { 14, 15 }; > > >> #endif > > >> > > >> +/* > > >> + * Return the global irq number corresponding to a given device irq > > >> + * pin. We could also use the bus number to have a more precise mapping. > > >> + */ > > >> +static int pci_slot_get_pirq(PCIDevice *pci_dev, int pci_intx) > > >> +{ > > >> + int slot_addend; > > >> + slot_addend = PCI_SLOT(pci_dev->devfn) - 1; > > >> + return (pci_intx + slot_addend) & 3; > > >> +} > > >> + > > >> +static void piix_intx_routing_notifier_xen(PCIDevice *dev) > > >> +{ > > >> + int i; > > >> + > > >> + /* Scan for updates to PCI link routes (0x60-0x63). */ > > >> + for (i = 0; i < PIIX_NUM_PIRQS; i++) { > > >> + uint8_t v = dev->config_read(dev, PIIX_PIRQCA + i, 1); > > >> + if (v & 0x80) { > > >> + v = 0; > > >> + } > > >> + v &= 0xf; > > >> + xen_set_pci_link_route(i, v); > > >> + } > > >> +} > > >> + > > >> /* PC hardware initialisation */ > > >> static void pc_init1(MachineState *machine, > > >> const char *host_type, const char *pci_type) > > >> @@ -84,7 +112,7 @@ static void pc_init1(MachineState *machine, > > >> MemoryRegion *system_io = get_system_io(); > > >> PCIBus *pci_bus; > > >> ISABus *isa_bus; > > >> - int piix3_devfn = -1; > > >> + Object *piix4_pm; > > >> qemu_irq smi_irq; > > >> GSIState *gsi_state; > > >> BusState *idebus[MAX_IDE_BUS]; > > >> @@ -205,10 +233,9 @@ static void pc_init1(MachineState *machine, > > >> gsi_state = pc_gsi_create(&x86ms->gsi, pcmc->pci_enabled); > > >> > > >> if (pcmc->pci_enabled) { > > >> - PIIX3State *piix3; > > >> + DeviceState *dev; > > >> PCIDevice *pci_dev; > > >> - const char *type = xen_enabled() ? TYPE_PIIX3_XEN_DEVICE > > >> - : TYPE_PIIX3_DEVICE; > > >> + int i; > > >> > > >> pci_bus = i440fx_init(pci_type, > > >> i440fx_host, > > >> @@ -216,21 +243,65 @@ static void pc_init1(MachineState *machine, > > >> x86ms->below_4g_mem_size, > > >> x86ms->above_4g_mem_size, > > >> pci_memory, ram_memory); > > >> + pci_bus_map_irqs(pci_bus, > > >> + xen_enabled() ? xen_pci_slot_get_pirq > > >> + : pci_slot_get_pirq); > > >> pcms->bus = pci_bus; > > >> > > >> - pci_dev = pci_create_simple_multifunction(pci_bus, -1, true, type); > > >> - piix3 = PIIX3_PCI_DEVICE(pci_dev); > > >> - piix3->pic = x86ms->gsi; > > >> - piix3_devfn = piix3->dev.devfn; > > >> - isa_bus = ISA_BUS(qdev_get_child_bus(DEVICE(piix3), "isa.0")); > > >> + pci_dev = pci_new_multifunction(-1, true, TYPE_PIIX3_DEVICE); > > >> + object_property_set_bool(OBJECT(pci_dev), "has-usb", > > >> + machine_usb(machine), &error_abort); > > >> + object_property_set_bool(OBJECT(pci_dev), "has-acpi", > > >> + x86_machine_is_acpi_enabled(x86ms), > > >> + &error_abort); > > >> + qdev_prop_set_uint32(DEVICE(pci_dev), "smb_io_base", 0xb100); > > >> + object_property_set_bool(OBJECT(pci_dev), "smm-enabled", > > >> + x86_machine_is_smm_enabled(x86ms), > > >> + &error_abort); > > >> + pci_realize_and_unref(pci_dev, pci_bus, &error_fatal); > > >> + > > >> + if (xen_enabled()) { > > >> + pci_device_set_intx_routing_notifier( > > >> + pci_dev, piix_intx_routing_notifier_xen); > > >> + > > >> + /* > > >> + * Xen supports additional interrupt routes from the PCI devices to > > >> + * the IOAPIC: the four pins of each PCI device on the bus are also > > >> + * connected to the IOAPIC directly. > > >> + * These additional routes can be discovered through ACPI. > > >> + */ > > >> + pci_bus_irqs(pci_bus, xen_intx_set_irq, pci_dev, > > >> + XEN_IOAPIC_NUM_PIRQS); > > >> + } > > >> + > > >> + dev = DEVICE(object_resolve_path_component(OBJECT(pci_dev), "pic")); > > >> + for (i = 0; i < ISA_NUM_IRQS; i++) { > > >> + qdev_connect_gpio_out(dev, i, x86ms->gsi[i]); > > >> + } > > >> + isa_bus = ISA_BUS(qdev_get_child_bus(DEVICE(pci_dev), "isa.0")); > > >> + rtc_state = ISA_DEVICE(object_resolve_path_component(OBJECT(pci_dev), > > >> + "rtc")); > > >> + piix4_pm = object_resolve_path_component(OBJECT(pci_dev), "pm"); > > >> + dev = DEVICE(object_resolve_path_component(OBJECT(pci_dev), "ide")); > > >> + pci_ide_create_devs(PCI_DEVICE(dev)); > > >> + idebus[0] = qdev_get_child_bus(dev, "ide.0"); > > >> + idebus[1] = qdev_get_child_bus(dev, "ide.1"); > > >> } else { > > >> pci_bus = NULL; > > >> + piix4_pm = NULL; > > >> isa_bus = isa_bus_new(NULL, get_system_memory(), system_io, > > >> &error_abort); > > >> + isa_bus_irqs(isa_bus, x86ms->gsi); > > >> + > > >> + rtc_state = isa_new(TYPE_MC146818_RTC); > > >> + qdev_prop_set_int32(DEVICE(rtc_state), "base_year", 2000); > > >> + isa_realize_and_unref(rtc_state, isa_bus, &error_fatal); > > >> + > > >> i8257_dma_init(isa_bus, 0); > > >> pcms->hpet_enabled = false; > > >> + idebus[0] = NULL; > > >> + idebus[1] = NULL; > > >> } > > >> - isa_bus_irqs(isa_bus, x86ms->gsi); > > >> > > >> if (x86ms->pic == ON_OFF_AUTO_ON || x86ms->pic == ON_OFF_AUTO_AUTO) { > > >> pc_i8259_create(isa_bus, gsi_state->i8259_irq); > > >> @@ -252,18 +323,12 @@ static void pc_init1(MachineState *machine, > > >> } > > >> > > >> /* init basic PC hardware */ > > >> - pc_basic_device_init(pcms, isa_bus, x86ms->gsi, &rtc_state, true, > > >> + pc_basic_device_init(pcms, isa_bus, x86ms->gsi, rtc_state, true, > > >> 0x4); > > >> > > >> pc_nic_init(pcmc, isa_bus, pci_bus); > > >> > > >> if (pcmc->pci_enabled) { > > >> - PCIDevice *dev; > > >> - > > >> - dev = pci_create_simple(pci_bus, piix3_devfn + 1, TYPE_PIIX3_IDE); > > >> - pci_ide_create_devs(dev); > > >> - idebus[0] = qdev_get_child_bus(&dev->qdev, "ide.0"); > > >> - idebus[1] = qdev_get_child_bus(&dev->qdev, "ide.1"); > > >> pc_cmos_init(pcms, idebus[0], idebus[1], rtc_state); > > >> } > > >> #ifdef CONFIG_IDE_ISA > > >> @@ -289,21 +354,9 @@ static void pc_init1(MachineState *machine, > > >> } > > >> #endif > > >> > > >> - if (pcmc->pci_enabled && machine_usb(machine)) { > > >> - pci_create_simple(pci_bus, piix3_devfn + 2, "piix3-usb-uhci"); > > >> - } > > >> - > > >> - if (pcmc->pci_enabled && x86_machine_is_acpi_enabled(X86_MACHINE(pcms))) { > > >> - PCIDevice *piix4_pm; > > >> - > > >> + if (piix4_pm) { > > >> smi_irq = qemu_allocate_irq(pc_acpi_smi_interrupt, first_cpu, 0); > > >> - piix4_pm = pci_new(piix3_devfn + 3, TYPE_PIIX4_PM); > > >> - qdev_prop_set_uint32(DEVICE(piix4_pm), "smb_io_base", 0xb100); > > >> - qdev_prop_set_bit(DEVICE(piix4_pm), "smm-enabled", > > >> - x86_machine_is_smm_enabled(x86ms)); > > >> - pci_realize_and_unref(piix4_pm, pci_bus, &error_fatal); > > >> > > >> - qdev_connect_gpio_out(DEVICE(piix4_pm), 0, x86ms->gsi[9]); > > >> qdev_connect_gpio_out_named(DEVICE(piix4_pm), "smi-irq", 0, smi_irq); > > >> pcms->smbus = I2C_BUS(qdev_get_child_bus(DEVICE(piix4_pm), "i2c")); > > >> /* TODO: Populate SPD eeprom data. */ > > >> @@ -315,7 +368,7 @@ static void pc_init1(MachineState *machine, > > >> object_property_allow_set_link, > > >> OBJ_PROP_LINK_STRONG); > > >> object_property_set_link(OBJECT(machine), PC_MACHINE_ACPI_DEVICE_PROP, > > >> - OBJECT(piix4_pm), &error_abort); > > >> + piix4_pm, &error_abort); > > >> } > > >> > > >> if (machine->nvdimms_state->is_enabled) { > > >> @@ -405,6 +458,9 @@ static void pc_xen_hvm_init(MachineState *machine) > > >> } > > >> > > >> pc_xen_hvm_init_pci(machine); > > >> + if (xen_igd_gfx_pt_enabled()) { > > >> + xen_igd_reserve_slot(pcms->bus); > > >> + } > > >> pci_create_simple(pcms->bus, -1, "xen-platform"); > > >> } > > >> #endif > > >> @@ -441,6 +497,11 @@ static void pc_i440fx_8_0_machine_options(MachineClass *m) > > >> pc_i440fx_machine_options(m); > > >> m->alias = "pc"; > > >> m->is_default = true; > > >> +#ifdef CONFIG_MICROVM_DEFAULT > > >> + m->is_default = false; > > >> +#else > > >> + m->is_default = true; > > >> +#endif > > >> } > > >> > > >> DEFINE_I440FX_MACHINE(v8_0, "pc-i440fx-8.0", NULL, > > > > > > > > > Lots of changes here not guarded by CONFIG_XEN. > > > > > > > What diff is this? How is my patch related to it? > > > This is what you posted, take a look: > https://lore.kernel.org/all/8349506149de6d81b0762f17623552c248439e93.1673297742.git.brchuckz@aol.com/ > > Oops, I think I sent the wrong patch here. I must have used the wrong git branch. Sorry. I wouldn't blame you if you ignore future messages from me. I will get it right next time if there is a next time with v8. Linus named git a stupid content tracker. And in this case, it was too stupid to warn me that the patch it sent on my behalf is not what I expected it to be. Or maybe I am the stupid one, LOL. I hope no one is stupid enough to consider v7 of my patch any further! And the fact that this stupidity of mine is preserved for all future generations is so sweet - one of the benefits of trying to help out in FLOSS projects, LOL. Kind regards, Chuck From xen-devel-bounces@lists.xenproject.org Tue Jan 10 06:33:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 06:33:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474286.735371 (Exim 4.92) (envelope-from ) id 1pF8C5-00060v-EF; Tue, 10 Jan 2023 06:33:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474286.735371; Tue, 10 Jan 2023 06:33:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF8C5-00060o-BR; Tue, 10 Jan 2023 06:33:09 +0000 Received: by outflank-mailman (input) for mailman id 474286; Tue, 10 Jan 2023 06:33:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF8C4-00060e-6Q; Tue, 10 Jan 2023 06:33:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF8C4-0005NB-4k; Tue, 10 Jan 2023 06:33:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF8C3-000453-QV; Tue, 10 Jan 2023 06:33:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pF8C3-0004Fg-Q2; Tue, 10 Jan 2023 06:33:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=WdlUsvcVpUq0yb8vkNYIC/1KpAixJ84JyYzg8o6ilpE=; b=yGOTvb3xuZaH47H8qzGvs/+6OV bI/YKanHe/zMDtfK3h+BP0IM1YMSWvkyYNEDr2CjDfF0W4HzRLJL8v85pU7zHl3zThOCmfQhHhZMO 5Df7xFF9DmQiAPcYZmf+biHWg/J32mqXKDm3j1gZQea07pxO1sMTVaU0zfWFoJwGZzaQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 175683: all pass - PUSHED X-Osstest-Versions-This: ovmf=2cc6d4c8ed54e36fd9638dafdb293dd9a4c54cf9 X-Osstest-Versions-That: ovmf=33a3408fbbf988aaa8ecc6e721cf83e3ae810e54 From: osstest service owner Date: Tue, 10 Jan 2023 06:33:07 +0000 flight 175683 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/175683/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 2cc6d4c8ed54e36fd9638dafdb293dd9a4c54cf9 baseline version: ovmf 33a3408fbbf988aaa8ecc6e721cf83e3ae810e54 Last test of basis 175655 2023-01-09 18:11:29 Z 0 days Testing same since 175683 2023-01-10 04:10:46 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ning Feng jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 33a3408fbb..2cc6d4c8ed 2cc6d4c8ed54e36fd9638dafdb293dd9a4c54cf9 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue Jan 10 07:09:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 07:09:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474296.735388 (Exim 4.92) (envelope-from ) id 1pF8kn-00018p-6E; Tue, 10 Jan 2023 07:09:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474296.735388; Tue, 10 Jan 2023 07:09:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF8kn-00018i-3H; Tue, 10 Jan 2023 07:09:01 +0000 Received: by outflank-mailman (input) for mailman id 474296; Tue, 10 Jan 2023 07:08:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF8kl-00018Z-DL for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 07:08:59 +0000 Received: from sonic308-54.consmr.mail.gq1.yahoo.com (sonic308-54.consmr.mail.gq1.yahoo.com [98.137.68.30]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a4412fec-90b5-11ed-b8d0-410ff93cb8f0; Tue, 10 Jan 2023 08:08:55 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic308.consmr.mail.gq1.yahoo.com with HTTP; Tue, 10 Jan 2023 07:08:52 +0000 Received: by hermes--production-bf1-5458f64d4-c7wsl (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 685679c689afdd034d61b58b257d2b66; Tue, 10 Jan 2023 07:08:46 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a4412fec-90b5-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1673334532; bh=KuWJYIFENPkHWbAOvcCiwKQm/Xx2ED603nRvGGU94Ig=; h=From:To:Cc:Subject:Date:References:From:Subject:Reply-To; b=FfPNwFdGlr/JEBG8LpuBgUR4pP8x+J1GCalVPRus3zAXJ/rwTVkg37O6Kn+NzOKHI2SJZNmWkvellckj/KKyJUpdfPfK9otQkVlrfk145vWBo6GAGZGdFHIRP/sOEDOcaCPh3cRTyPEjyz2uvTaKk6K1/BaVzQ2scp0mmTkWPgatVjd6MBRDwuRABCwmUKZ5GJKfk96WV5Dz7jHzzqES1a+OOEMSDk5y5BOEfuq9t0F5sUZcEeK9cZMD2doH16ZArmU1Wwhfmron0ZD8zj1xmF2YHsL8h2PUa1htGxwYReH1J4CZVKCWA3r/RT/jp+WCjWwRWxhnO1231PRL6sNSZg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1673334532; bh=mFeK+N6el/Uveabs+Ic/qDm85kO91cY93TU7fteohwD=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=osFbjclQ98zHsNwWrC1Bz6Nh6SexcWqDziCA/ShandMHF4rrNpq3Inq9uWI7LyM7pSSXzyyl6q5NB8xDtWw3j+H3Dwdib3PblkO6ojjJMXlc06Mh1tmMUXGRDFD7YsNsc5JPEvvD7/Kr9KrwKWZjBnqQQGieict1a3oYvLx57q78YAj8DibvAbzHhWDN7N0YrZgWUtJUWSR0/iAta8qH/grdMw0tL3PT7xkAUok07Lixg2jPHNqX9LGqXc5ZWIUN9nky7O61WopPRYlMo0juKRNGZ+ttDrLiZc6dF1OChLGkc+XRuDshLeyjLcGBL5LFoH8gpHBMmfbas7WjUB1aGQ== X-YMail-OSG: auhjzb0VM1lZiBqxL1p4B_eR6C.6nYduSpSAXeEvBtNl8ew1jZGRz95R8kj8pls 9xgM65wpRxnoWwSI6HDcFsDfsXdrVeMw1fmxMsC0AmOn9TQItZEnUgjkls0s0Qv.LiHsm2bBX8pz TDzC7lAP00xw8nH66NZff0j3xqarkzzu7oc8JQ7YV9H3wuQM5diQGw8HQUHSm_dNjF9wSpVb1Nq5 lNlNG4dP3_k0wnpoCqd0_j1GgN.IDqShVvHh5H5zwhG9L6NnN0VWACekknFxmRaN0G5a2xQUTUqS 31GiJrOPibgImZVyUjosrtwPlmpCcI3zAA.65IgKCLsTOCiB64F2tlBJkWl_1Rs2EEJYhWwYF8SE wpFnRDC3_dMxB6ZwEH8yZ1g2iJkH6oDL2tkFZp6hHUWJvmeceCvyTxfNaawHamYmWHnFadSvDOwf KVcLDd8R3paNgn0LLYbTLrP_hbgkWACQr1f3RnRYkgUvDExolWL.qKiEwWhc4mz0wXG2IIly_3A6 XmV3y2._jv7dqJj7FbCCUG1DIVtWVNohiDS4l8N4B5ch.e5dg3OPnscNYAinKppGSFrX884fkeoC 8iQFgtVddi.ouLH6T5SLQPFcZhnvEVYACibIAS8uC1kXGvQG_O._kqaJS1diNTKTuZ3yh1DiGxdH b_18wOvyG64g1TzIIavhtpn4h6mStbRxGEoEEW3IAH_Wzgh3w5e2LV8Vtag055d6iV4WNGAooQuE fEeTvUldgA9NRbRW7_aVZoreyg.TnONatnU9X1IM9NTFq5UJsz1MMIIoGHS4xZil8BxXk0Fbdf3X uUAj54gJ7saOi9F9O93R4sJOzaj9UGMDZ5XeLe8uLNXUB_DfUA01HOFb3s7emhtK0rXfPivrI5ng d738G7pu_3A9.OLydaUK6e3xYnn0GFfvFX11LiWemqkdEtykcntZO_RXHJUsJxZvtXRJv1u54wle fpgFepNLmA5_UEFmnz3MCKuIL0DYUKwyAaKGVBB2i0putP_WKGwudYTt7MI9Y_Xt5470NpzMT0lI HubRWwWMRlFUejLzDJNJtcaVGrhtnNAOgkVbx6XvzHNaiL4hNWTTzrG3aTSO.J7Z1MhIlm4T4gc8 mJiJ7kaJRYYqBuvI9bmYqTape4Q9F3dXgaGbCsys7rkCnMvicbSUt4zg5zS3Ybf.qgTw3dT0NWSh k2kUjA1SOTJt_AKVQHnkdw57xvhkeFj0yh492_6.CKfgBiPvnoOZmCEKbH6I_45Bj3neS2Vmr.x9 NeuNA8qn3fy1vBm6bpaIkd6x_UMYrt438Ycq84Idiako5Z9sBVBxCXpu9PFBz9GofbUfly9Qau6j ZmqqS6DydwxoVN7OTP5o5w49x1Hk7zgXBbrg8b_.NN1qZll9.lGOOg5DkCtyDYyeR2L0vUE8CcNf kUUTVNLkFJoNOVQTuSjuyBc3lOmjG9cKkURTFh7V1OappEVlG19e4keOBv9cWt2BCdxw5PdoIRF1 kmfIlIVD7IAX1h9yLaMpOpZmGsgO8G2FG57AWE4SPpiFNuFjIRunrSkzaLRcaJN6C41lMghvkgPa 6nc73Tuf3KeZ_DhuchzjzlgNOQ1n451L1W01x91w9qd6veBKAtfPOaLzqEq6I9Yxv26KAfNlfY8Z zkdh5TBU0aTozVjyfGY_PqcPmYtM8BB6zGJ6Dn0NSwnUcmiQV5bTcO4I8mez1ADbghF1HstKMbl3 xD3DyCC1kiEkeLyl2OWis96F4K7GdaXPTsdsi8KbxnwYmLaABRGENqVxXAbKQFHu8M9U_8bFYKFN ES7iNEOj0YT2WeFnV3Jou.MjHk4fkFAq4sUWnbAVt0jo4UX_CTkixWHV853ka_LUqi2jizlzO0WK oROCiEKyZhdItFZfXcyTPCbprX5pPJvwg1jeHwgNZTejDuaX9DX37Sh1yvGAYkmYJ66D7txwzhyg He7Oo7xZTHdjE43RGFC3wTzfXkQ_QKiaihsOEURKAOriCcWwVXYAFL9BlHr84hPUertLTPvdM4Vm ezEnZg30S.wRB1gT1MmWRmfbla9q_NfnTvVrj11lfJRPz3E9b7PxLp9bcTxDLSOCvnokDoKqtgT3 uD.LMgR.AUhZJDdYTSAfEAprMeqXdz9E_7R1KZIippQJKCVs9_65mclJw1pocO2S9KqPKkXyCOm0 hgYcSVrtK9Vsl8TKFe_Rjs9qfV_XHooxoXQZfCYmOSoRg.3Ff5Jc2Hza1jebssXD2qr2uXFWnTu9 It0QAUUZFUg-- X-Sonic-MF: From: Chuck Zmudzinski To: qemu-devel@nongnu.org Cc: Stefano Stabellini , Anthony Perard , Paul Durrant , Paolo Bonzini , Richard Henderson , Eduardo Habkost , "Michael S. Tsirkin" , Marcel Apfelbaum , xen-devel@lists.xenproject.org Subject: [PATCH v8] xen/pt: reserve PCI slot 2 for Intel igd-passthru Date: Tue, 10 Jan 2023 02:08:34 -0500 Message-Id: X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit References: Content-Length: 11344 Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, as noted in docs/igd-assign.txt in the Qemu source code. Currently, when the xl toolstack is used to configure a Xen HVM guest with Intel IGD passthrough to the guest with the Qemu upstream device model, a Qemu emulated PCI device will occupy slot 2 and the Intel IGD will occupy a different slot. This problem often prevents the guest from booting. The only available workaround is not good: Configure Xen HVM guests to use the old and no longer maintained Qemu traditional device model available from xenbits.xen.org which does reserve slot 2 for the Intel IGD. To implement this feature in the Qemu upstream device model for Xen HVM guests, introduce the following new functions, types, and macros: * XEN_PT_DEVICE_CLASS declaration, based on the existing TYPE_XEN_PT_DEVICE * XEN_PT_DEVICE_GET_CLASS macro helper function for XEN_PT_DEVICE_CLASS * typedef XenPTQdevRealize function pointer * XEN_PCI_IGD_SLOT_MASK, the value of slot_reserved_mask to reserve slot 2 * xen_igd_reserve_slot and xen_igd_clear_slot functions The new xen_igd_reserve_slot function uses the existing slot_reserved_mask member of PCIBus to reserve PCI slot 2 for Xen HVM guests configured using the xl toolstack with the gfx_passthru option enabled, which sets the igd-passthru=on option to Qemu for the Xen HVM machine type. The new xen_igd_reserve_slot function also needs to be implemented in hw/xen/xen_pt_stub.c to prevent FTBFS during the link stage for the case when Qemu is configured with --enable-xen and --disable-xen-pci-passthrough, in which case it does nothing. The new xen_igd_clear_slot function overrides qdev->realize of the parent PCI device class to enable the Intel IGD to occupy slot 2 on the PCI bus since slot 2 was reserved by xen_igd_reserve_slot when the PCI bus was created in hw/i386/pc_piix.c for the case when igd-passthru=on. Move the call to xen_host_pci_device_get, and the associated error handling, from xen_pt_realize to the new xen_igd_clear_slot function to initialize the device class and vendor values which enables the checks for the Intel IGD to succeed. The verification that the host device is an Intel IGD to be passed through is done by checking the domain, bus, slot, and function values as well as by checking that gfx_passthru is enabled, the device class is VGA, and the device vendor in Intel. Signed-off-by: Chuck Zmudzinski --- Notes that might be helpful to reviewers of patched code in hw/xen: The new functions and types are based on recommendations from Qemu docs: https://qemu.readthedocs.io/en/latest/devel/qom.html Notes that might be helpful to reviewers of patched code in hw/i386: The small patch to hw/i386/pc_piix.c is protected by CONFIG_XEN so it does not affect builds that do not have CONFIG_XEN defined. xen_igd_gfx_pt_enabled() in the patched hw/i386/pc_piix.c file is an existing function that is only true when Qemu is built with xen-pci-passthrough enabled and the administrator has configured the Xen HVM guest with Qemu's igd-passthru=on option. v2: Remove From: tag at top of commit message v3: Changed the test for the Intel IGD in xen_igd_clear_slot: if (is_igd_vga_passthrough(&s->real_device) && (s->real_device.vendor_id == PCI_VENDOR_ID_INTEL)) { is changed to if (xen_igd_gfx_pt_enabled() && (s->hostaddr.slot == 2) && (s->hostaddr.function == 0)) { I hoped that I could use the test in v2, since it matches the other tests for the Intel IGD in Qemu and Xen, but those tests do not work because the necessary data structures are not set with their values yet. So instead use the test that the administrator has enabled gfx_passthru and the device address on the host is 02.0. This test does detect the Intel IGD correctly. v4: Use brchuckz@aol.com instead of brchuckz@netscape.net for the author's email address to match the address used by the same author in commits be9c61da and c0e86b76 Change variable for XEN_PT_DEVICE_CLASS: xptc changed to xpdc v5: The patch of xen_pt.c was re-worked to allow a more consistent test for the Intel IGD that uses the same criteria as in other places. This involved moving the call to xen_host_pci_device_get from xen_pt_realize to xen_igd_clear_slot and updating the checks for the Intel IGD in xen_igd_clear_slot: if (xen_igd_gfx_pt_enabled() && (s->hostaddr.slot == 2) && (s->hostaddr.function == 0)) { is changed to if (is_igd_vga_passthrough(&s->real_device) && s->real_device.domain == 0 && s->real_device.bus == 0 && s->real_device.dev == 2 && s->real_device.func == 0 && s->real_device.vendor_id == PCI_VENDOR_ID_INTEL) { Added an explanation for the move of xen_host_pci_device_get from xen_pt_realize to xen_igd_clear_slot to the commit message. Rebase. v6: Fix logging by removing these lines from the move from xen_pt_realize to xen_igd_clear_slot that was done in v5: XEN_PT_LOG(d, "Assigning real physical device %02x:%02x.%d" " to devfn 0x%x\n", s->hostaddr.bus, s->hostaddr.slot, s->hostaddr.function, s->dev.devfn); This log needs to be in xen_pt_realize because s->dev.devfn is not set yet in xen_igd_clear_slot. v7: The v7 that was posted to the mailing list was incorrect. v8 is what v7 was intended to be. v8: Inhibit out of context log message and needless processing by adding 2 lines at the top of the new xen_igd_clear_slot function: if (!(pci_bus->slot_reserved_mask & XEN_PCI_IGD_SLOT_MASK)) return; Rebase. This removed an unnecessary header file from xen_pt.h hw/i386/pc_piix.c | 3 +++ hw/xen/xen_pt.c | 49 ++++++++++++++++++++++++++++++++++++-------- hw/xen/xen_pt.h | 16 +++++++++++++++ hw/xen/xen_pt_stub.c | 4 ++++ 4 files changed, 63 insertions(+), 9 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index b48047f50c..bc5efa4f59 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -405,6 +405,9 @@ static void pc_xen_hvm_init(MachineState *machine) } pc_xen_hvm_init_pci(machine); + if (xen_igd_gfx_pt_enabled()) { + xen_igd_reserve_slot(pcms->bus); + } pci_create_simple(pcms->bus, -1, "xen-platform"); } #endif diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c index 0ec7e52183..eff38155ef 100644 --- a/hw/xen/xen_pt.c +++ b/hw/xen/xen_pt.c @@ -780,15 +780,6 @@ static void xen_pt_realize(PCIDevice *d, Error **errp) s->hostaddr.bus, s->hostaddr.slot, s->hostaddr.function, s->dev.devfn); - xen_host_pci_device_get(&s->real_device, - s->hostaddr.domain, s->hostaddr.bus, - s->hostaddr.slot, s->hostaddr.function, - errp); - if (*errp) { - error_append_hint(errp, "Failed to \"open\" the real pci device"); - return; - } - s->is_virtfn = s->real_device.is_virtfn; if (s->is_virtfn) { XEN_PT_LOG(d, "%04x:%02x:%02x.%d is a SR-IOV Virtual Function\n", @@ -950,11 +941,50 @@ static void xen_pci_passthrough_instance_init(Object *obj) PCI_DEVICE(obj)->cap_present |= QEMU_PCI_CAP_EXPRESS; } +void xen_igd_reserve_slot(PCIBus *pci_bus) +{ + XEN_PT_LOG(0, "Reserving PCI slot 2 for IGD\n"); + pci_bus->slot_reserved_mask |= XEN_PCI_IGD_SLOT_MASK; +} + +static void xen_igd_clear_slot(DeviceState *qdev, Error **errp) +{ + ERRP_GUARD(); + PCIDevice *pci_dev = (PCIDevice *)qdev; + XenPCIPassthroughState *s = XEN_PT_DEVICE(pci_dev); + XenPTDeviceClass *xpdc = XEN_PT_DEVICE_GET_CLASS(s); + PCIBus *pci_bus = pci_get_bus(pci_dev); + + if (!(pci_bus->slot_reserved_mask & XEN_PCI_IGD_SLOT_MASK)) + return; + + xen_host_pci_device_get(&s->real_device, + s->hostaddr.domain, s->hostaddr.bus, + s->hostaddr.slot, s->hostaddr.function, + errp); + if (*errp) { + error_append_hint(errp, "Failed to \"open\" the real pci device"); + return; + } + + if (is_igd_vga_passthrough(&s->real_device) && + s->real_device.domain == 0 && s->real_device.bus == 0 && + s->real_device.dev == 2 && s->real_device.func == 0 && + s->real_device.vendor_id == PCI_VENDOR_ID_INTEL) { + pci_bus->slot_reserved_mask &= ~XEN_PCI_IGD_SLOT_MASK; + XEN_PT_LOG(pci_dev, "Intel IGD found, using slot 2\n"); + } + xpdc->pci_qdev_realize(qdev, errp); +} + static void xen_pci_passthrough_class_init(ObjectClass *klass, void *data) { DeviceClass *dc = DEVICE_CLASS(klass); PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); + XenPTDeviceClass *xpdc = XEN_PT_DEVICE_CLASS(klass); + xpdc->pci_qdev_realize = dc->realize; + dc->realize = xen_igd_clear_slot; k->realize = xen_pt_realize; k->exit = xen_pt_unregister_device; k->config_read = xen_pt_pci_read_config; @@ -977,6 +1007,7 @@ static const TypeInfo xen_pci_passthrough_info = { .instance_size = sizeof(XenPCIPassthroughState), .instance_finalize = xen_pci_passthrough_finalize, .class_init = xen_pci_passthrough_class_init, + .class_size = sizeof(XenPTDeviceClass), .instance_init = xen_pci_passthrough_instance_init, .interfaces = (InterfaceInfo[]) { { INTERFACE_CONVENTIONAL_PCI_DEVICE }, diff --git a/hw/xen/xen_pt.h b/hw/xen/xen_pt.h index cf10fc7bbf..8c25932b4b 100644 --- a/hw/xen/xen_pt.h +++ b/hw/xen/xen_pt.h @@ -2,6 +2,7 @@ #define XEN_PT_H #include "hw/xen/xen_common.h" +#include "hw/pci/pci_bus.h" #include "xen-host-pci-device.h" #include "qom/object.h" @@ -40,7 +41,20 @@ typedef struct XenPTReg XenPTReg; #define TYPE_XEN_PT_DEVICE "xen-pci-passthrough" OBJECT_DECLARE_SIMPLE_TYPE(XenPCIPassthroughState, XEN_PT_DEVICE) +#define XEN_PT_DEVICE_CLASS(klass) \ + OBJECT_CLASS_CHECK(XenPTDeviceClass, klass, TYPE_XEN_PT_DEVICE) +#define XEN_PT_DEVICE_GET_CLASS(obj) \ + OBJECT_GET_CLASS(XenPTDeviceClass, obj, TYPE_XEN_PT_DEVICE) + +typedef void (*XenPTQdevRealize)(DeviceState *qdev, Error **errp); + +typedef struct XenPTDeviceClass { + PCIDeviceClass parent_class; + XenPTQdevRealize pci_qdev_realize; +} XenPTDeviceClass; + uint32_t igd_read_opregion(XenPCIPassthroughState *s); +void xen_igd_reserve_slot(PCIBus *pci_bus); void igd_write_opregion(XenPCIPassthroughState *s, uint32_t val); void xen_igd_passthrough_isa_bridge_create(XenPCIPassthroughState *s, XenHostPCIDevice *dev); @@ -75,6 +89,8 @@ typedef int (*xen_pt_conf_byte_read) #define XEN_PCI_INTEL_OPREGION 0xfc +#define XEN_PCI_IGD_SLOT_MASK 0x4UL /* Intel IGD slot_reserved_mask */ + typedef enum { XEN_PT_GRP_TYPE_HARDWIRED = 0, /* 0 Hardwired reg group */ XEN_PT_GRP_TYPE_EMU, /* emul reg group */ diff --git a/hw/xen/xen_pt_stub.c b/hw/xen/xen_pt_stub.c index 2d8cac8d54..5c108446a8 100644 --- a/hw/xen/xen_pt_stub.c +++ b/hw/xen/xen_pt_stub.c @@ -20,3 +20,7 @@ void xen_igd_gfx_pt_set(bool value, Error **errp) error_setg(errp, "Xen PCI passthrough support not built in"); } } + +void xen_igd_reserve_slot(PCIBus *pci_bus) +{ +} -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Tue Jan 10 07:29:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 07:29:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474302.735399 (Exim 4.92) (envelope-from ) id 1pF94K-0003ZL-QV; Tue, 10 Jan 2023 07:29:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474302.735399; Tue, 10 Jan 2023 07:29:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF94K-0003ZE-My; Tue, 10 Jan 2023 07:29:12 +0000 Received: by outflank-mailman (input) for mailman id 474302; Tue, 10 Jan 2023 07:29:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF94I-0003Z8-Fc for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 07:29:10 +0000 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [2a00:1450:4864:20::630]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 77ef4fcd-90b8-11ed-b8d0-410ff93cb8f0; Tue, 10 Jan 2023 08:29:08 +0100 (CET) Received: by mail-ej1-x630.google.com with SMTP id fc4so26233009ejc.12 for ; Mon, 09 Jan 2023 23:29:07 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 77ef4fcd-90b8-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=9ssIX2bpuLjHtHr5+BBTQqOChORvzTDNQnsLLcvt2qg=; b=e7oCwnl55++94Q2FyIhXiOCmNMMWEE7hSeTcjnM0OwwZ7iZMByeN4dDjGkAaCzTSN+ A+tUo3V6c6bqBLWWMJUZKKcPp79cNKGBrQ/1KRKyIb2mTPooruC9hx4w2QXm17FKfmmw eh3F0FZD4LFseycTQZF/n9uSMZqPRBU+oGrHj786Tx4tJSs9CWPLu9Ds6Iu0wjVGa0LU MQTmmPR0ka59gBy23Q6qvq4hRs7BvqTCWGUenKwuvKl/RhDtqGxEP2zBgLStq/e+/4VW dFAptn70skTjRrbIBGhG7AsqzPbMZN0IQklb2gZkFprPDWo7Il1U0/peARTjzbWAoAog dJ6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9ssIX2bpuLjHtHr5+BBTQqOChORvzTDNQnsLLcvt2qg=; b=xA52JBM/GRL5wQkKmCkdRRSGrsHILgb04CVfeZDz8P6R+t81NZ/TI19BffyHGQU2BI W25O1P48NhipYuyZshkv16gDyvTOUuWHMWLHA44BU9vPqMhaoO/L4NdUaQBmLzpaQodr M+ba9LNiGR8dOryw13TL3mwJAtguLHSAVRuutGywdDSPyeRxGz/TYU9pEPl4Wyb6rmcy DqY/teP0cT64fnu6qP5gafBjYkXch0OraGTVhksOpV0AceT5RPLxFvFYVQxIzg3/WKIF zXvR9Cm+g7tamzH0dHTELXyE2ZdyfVvady+O3DsFNExgMTwzadEaV1D+iYGAriywgkW0 HZ1w== X-Gm-Message-State: AFqh2koK3fa8pGmnEFXFgtPugHVvDjLF9TFkwRxcb//h7HPB9dqqrfR9 xXBQg053xeC2AiZlYJKQf1CKLYgrwKDezCJIdx8= X-Google-Smtp-Source: AMrXdXs0ZjD9l52k6wjoRYK84dhQ5fuBp/z+R2mnzmEK3FIS0kye8yaVmQ+EiNEJQKbIhhqMW3V/y85D2ea9g8InJlM= X-Received: by 2002:a17:906:ac2:b0:78d:dddb:3974 with SMTP id z2-20020a1709060ac200b0078ddddb3974mr6322536ejf.411.1673335747386; Mon, 09 Jan 2023 23:29:07 -0800 (PST) MIME-Version: 1.0 References: <527727b2c9e26e6ef7714fe9a3fbe580caf1ae13.1673278109.git.oleksii.kurochko@gmail.com> In-Reply-To: From: Bobby Eshleman Date: Mon, 9 Jan 2023 23:28:56 -0800 Message-ID: Subject: Re: [PATCH v2 6/8] xen/riscv: introduce early_printk basic stuff To: Alistair Francis Cc: Alistair Francis , Andrew Cooper , Connor Davis , Gianluca Guida , Jan Beulich , Julien Grall , Oleksii Kurochko , Stefano Stabellini , xen-devel@lists.xenproject.org Content-Type: multipart/alternative; boundary="000000000000d0230205f1e3d6f0" --000000000000d0230205f1e3d6f0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Jan 9, 2023 at 4:28 PM Alistair Francis wrote: > On Tue, Jan 10, 2023 at 1:47 AM Oleksii Kurochko > wrote: > > > > The patch introduces a basic stuff of early_printk functionality > > which will be enough to print 'hello from C environment". > > early_printk() function was changed in comparison with original as > > common isn't being built now so there is no vscnprintf. > > > > Because printk() relies on a serial driver (like the ns16550 driver) > > and drivers require working virtual memory (ioremap()) there is not > > print functionality early in Xen boot. > > > > This commit adds early printk implementation built on the putc SBI call= . > > > > As sbi_console_putchar() is being already planned for deprecation > > it is used temporary now and will be removed or reworked after > > real uart will be ready. > > There was a discussion to add a new SBI putchar replacement. It > doesn't seem to be completed yet, but there might be an SBI > replacement for this in the future as well. > > Alistair > Are you referring to the Debug Console Extension (EID #0x4442434E "DBCN")= =E2=80=9D? https://lists.riscv.org/g/tech-prs/topic/96051183#84 Best, Bobby > > > > Signed-off-by: Bobby Eshleman > > Signed-off-by: Oleksii Kurochko > > --- > > Changes in V2: > > - add license to early_printk.c > > - add signed-off-by Bobby > > - add RISCV_32 to Kconfig.debug to EARLY_PRINTK config > > - update commit message > > - order the files alphabetically in Makefile > > --- > > xen/arch/riscv/Kconfig.debug | 7 +++++ > > xen/arch/riscv/Makefile | 1 + > > xen/arch/riscv/early_printk.c | 33 +++++++++++++++++++++++ > > xen/arch/riscv/include/asm/early_printk.h | 12 +++++++++ > > 4 files changed, 53 insertions(+) > > create mode 100644 xen/arch/riscv/early_printk.c > > create mode 100644 xen/arch/riscv/include/asm/early_printk.h > > > > diff --git a/xen/arch/riscv/Kconfig.debug b/xen/arch/riscv/Kconfig.debu= g > > index e69de29bb2..6ba0bd1e5a 100644 > > --- a/xen/arch/riscv/Kconfig.debug > > +++ b/xen/arch/riscv/Kconfig.debug > > @@ -0,0 +1,7 @@ > > +config EARLY_PRINTK > > + bool "Enable early printk config" > > + default DEBUG > > + depends on RISCV_64 || RISCV_32 > > + help > > + > > + Enables early printk debug messages > > diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile > > index fd916e1004..1a4f1a6015 100644 > > --- a/xen/arch/riscv/Makefile > > +++ b/xen/arch/riscv/Makefile > > @@ -1,3 +1,4 @@ > > +obj-$(CONFIG_EARLY_PRINTK) +=3D early_printk.o > > obj-$(CONFIG_RISCV_64) +=3D riscv64/ > > obj-y +=3D sbi.o > > obj-y +=3D setup.o > > diff --git a/xen/arch/riscv/early_printk.c > b/xen/arch/riscv/early_printk.c > > new file mode 100644 > > index 0000000000..88da5169ed > > --- /dev/null > > +++ b/xen/arch/riscv/early_printk.c > > @@ -0,0 +1,33 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +/* > > + * RISC-V early printk using SBI > > + * > > + * Copyright (C) 2021 Bobby Eshleman > > + */ > > +#include > > +#include > > + > > +/* > > + * TODO: > > + * sbi_console_putchar is already planned for deprication > > + * so it should be reworked to use UART directly. > > +*/ > > +void early_puts(const char *s, size_t nr) > > +{ > > + while ( nr-- > 0 ) > > + { > > + if (*s =3D=3D '\n') > > + sbi_console_putchar('\r'); > > + sbi_console_putchar(*s); > > + s++; > > + } > > +} > > + > > +void early_printk(const char *str) > > +{ > > + while (*str) > > + { > > + early_puts(str, 1); > > + str++; > > + } > > +} > > diff --git a/xen/arch/riscv/include/asm/early_printk.h > b/xen/arch/riscv/include/asm/early_printk.h > > new file mode 100644 > > index 0000000000..05106e160d > > --- /dev/null > > +++ b/xen/arch/riscv/include/asm/early_printk.h > > @@ -0,0 +1,12 @@ > > +#ifndef __EARLY_PRINTK_H__ > > +#define __EARLY_PRINTK_H__ > > + > > +#include > > + > > +#ifdef CONFIG_EARLY_PRINTK > > +void early_printk(const char *str); > > +#else > > +static inline void early_printk(const char *s) {}; > > +#endif > > + > > +#endif /* __EARLY_PRINTK_H__ */ > > -- > > 2.38.1 > > > > > --000000000000d0230205f1e3d6f0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Mon, Jan 9, 2023 at 4:28 PM Alistair F= rancis <alistair23@gmail.com= > wrote:
On Tue, Jan 10, 2023 at 1:47 AM Oleks= ii Kurochko
<oleksii= .kurochko@gmail.com> wrote:
>
> The patch introduces a basic stuff of early_printk functionality
> which will be enough to print 'hello from C environment".
> early_printk() function was changed in comparison with original as
> common isn't being built now so there is no vscnprintf.
>
> Because printk() relies on a serial driver (like the ns16550 driver) > and drivers require working virtual memory (ioremap()) there is not > print functionality early in Xen boot.
>
> This commit adds early printk implementation built on the putc SBI cal= l.
>
> As sbi_console_putchar() is being already planned for deprecation
> it is used temporary now and will be removed or reworked after
> real uart will be ready.

There was a discussion to add a new SBI putchar replacement. It
doesn't seem to be completed yet, but there might be an SBI
replacement for this in the future as well.

Alistair

Are you= referring to the=C2=A0Debug Console Extension (EID #0x4442434E "DBCN")=E2=80=9D= ?


Best,
Bobby<= /div>


>
> Signed-off-by: Bobby Eshleman <bobby.eshleman@gmail.com>
> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>
> ---
> Changes in V2:
>=C2=A0 =C2=A0 =C2=A0- add license to early_printk.c
>=C2=A0 =C2=A0 =C2=A0- add signed-off-by Bobby
>=C2=A0 =C2=A0 =C2=A0- add RISCV_32 to Kconfig.debug to EARLY_PRINTK con= fig
>=C2=A0 =C2=A0 =C2=A0- update commit message
>=C2=A0 =C2=A0 =C2=A0- order the files alphabetically in Makefile
> ---
>=C2=A0 xen/arch/riscv/Kconfig.debug=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 |=C2=A0 7 +++++
>=C2=A0 xen/arch/riscv/Makefile=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 1 +
>=C2=A0 xen/arch/riscv/early_printk.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0| 33 +++++++++++++++++++++++
>=C2=A0 xen/arch/riscv/include/asm/early_printk.h | 12 +++++++++
>=C2=A0 4 files changed, 53 insertions(+)
>=C2=A0 create mode 100644 xen/arch/riscv/early_printk.c
>=C2=A0 create mode 100644 xen/arch/riscv/include/asm/early_printk.h
>
> diff --git a/xen/arch/riscv/Kconfig.debug b/xen/arch/riscv/Kconfig.deb= ug
> index e69de29bb2..6ba0bd1e5a 100644
> --- a/xen/arch/riscv/Kconfig.debug
> +++ b/xen/arch/riscv/Kconfig.debug
> @@ -0,0 +1,7 @@
> +config EARLY_PRINTK
> +=C2=A0 =C2=A0 bool "Enable early printk config"
> +=C2=A0 =C2=A0 default DEBUG
> +=C2=A0 =C2=A0 depends on RISCV_64 || RISCV_32
> +=C2=A0 =C2=A0 help
> +
> +=C2=A0 =C2=A0 =C2=A0 Enables early printk debug messages
> diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile
> index fd916e1004..1a4f1a6015 100644
> --- a/xen/arch/riscv/Makefile
> +++ b/xen/arch/riscv/Makefile
> @@ -1,3 +1,4 @@
> +obj-$(CONFIG_EARLY_PRINTK) +=3D early_printk.o
>=C2=A0 obj-$(CONFIG_RISCV_64) +=3D riscv64/
>=C2=A0 obj-y +=3D sbi.o
>=C2=A0 obj-y +=3D setup.o
> diff --git a/xen/arch/riscv/early_printk.c b/xen/arch/riscv/early_prin= tk.c
> new file mode 100644
> index 0000000000..88da5169ed
> --- /dev/null
> +++ b/xen/arch/riscv/early_printk.c
> @@ -0,0 +1,33 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * RISC-V early printk using SBI
> + *
> + * Copyright (C) 2021 Bobby Eshleman <bobbyeshleman@gmail.com>
> + */
> +#include <asm/sbi.h>
> +#include <asm/early_printk.h>
> +
> +/*
> + * TODO:
> + *=C2=A0 =C2=A0sbi_console_putchar is already planned for deprication=
> + *=C2=A0 =C2=A0so it should be reworked to use UART directly.
> +*/
> +void early_puts(const char *s, size_t nr)
> +{
> +=C2=A0 =C2=A0 while ( nr-- > 0 )
> +=C2=A0 =C2=A0 {
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 if (*s =3D=3D '\n')
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 sbi_console_putchar('\r= ');
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 sbi_console_putchar(*s);
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 s++;
> +=C2=A0 =C2=A0 }
> +}
> +
> +void early_printk(const char *str)
> +{
> +=C2=A0 =C2=A0 while (*str)
> +=C2=A0 =C2=A0 {
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 early_puts(str, 1);
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 str++;
> +=C2=A0 =C2=A0 }
> +}
> diff --git a/xen/arch/riscv/include/asm/early_printk.h b/xen/arch/risc= v/include/asm/early_printk.h
> new file mode 100644
> index 0000000000..05106e160d
> --- /dev/null
> +++ b/xen/arch/riscv/include/asm/early_printk.h
> @@ -0,0 +1,12 @@
> +#ifndef __EARLY_PRINTK_H__
> +#define __EARLY_PRINTK_H__
> +
> +#include <xen/early_printk.h>
> +
> +#ifdef CONFIG_EARLY_PRINTK
> +void early_printk(const char *str);
> +#else
> +static inline void early_printk(const char *s) {};
> +#endif
> +
> +#endif /* __EARLY_PRINTK_H__ */
> --
> 2.38.1
>
>
--000000000000d0230205f1e3d6f0-- From xen-devel-bounces@lists.xenproject.org Tue Jan 10 07:32:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 07:32:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474309.735410 (Exim 4.92) (envelope-from ) id 1pF97Z-0005MM-D6; Tue, 10 Jan 2023 07:32:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474309.735410; Tue, 10 Jan 2023 07:32:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF97Z-0005ME-9n; Tue, 10 Jan 2023 07:32:33 +0000 Received: by outflank-mailman (input) for mailman id 474309; Tue, 10 Jan 2023 07:32:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF97Y-0005Lu-5D for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 07:32:32 +0000 Received: from sonic308-54.consmr.mail.gq1.yahoo.com (sonic308-54.consmr.mail.gq1.yahoo.com [98.137.68.30]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ef4ba9c2-90b8-11ed-b8d0-410ff93cb8f0; Tue, 10 Jan 2023 08:32:29 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic308.consmr.mail.gq1.yahoo.com with HTTP; Tue, 10 Jan 2023 07:32:27 +0000 Received: by hermes--production-ne1-7b69748c4d-bxfkx (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 00995f78f0d4fd001b9b8f1699ee7ed7; Tue, 10 Jan 2023 07:32:21 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ef4ba9c2-90b8-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1673335947; bh=06K19SzqcQMh+hYhDSeIvS+A1/F0qrYWujU3+eUpzVU=; h=From:To:Cc:Subject:Date:References:From:Subject:Reply-To; b=P4bfXUJ/Oj1sE4kdQK8QT7e6pQLcH4DLBCs17Yh/tS3Ez3cmciomWmb4LuLRhJP1HfsHObKGh6HOOeS8Xe1evZLESy46Ke0IIZOfyvR5TaowAotPqoqW6K8HwPOz6F6+d9Zkq41rYMNbI7t3I16CFg+6oiLVrAxCDtgX5cRXYol54on/6QCG/l/56UPQEQV7Zs8WuItBQ4W/BkHZGfwLeMuEnYAWq90yTqwhHgvIZ33idYcDJAMv8V82mJtyyygNeXnbde2mkOhR/l0OD3iJ6I2lQrOTQFIjl/1K9AQHNTODe0mRxaIO+FZqH5Y3V2mOWRgfJRigw1damskw5/JFGw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1673335947; bh=qiEct4R8jT0mwdX7UpFLVNjLYCi7GJda04po0C6cY4K=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=dxATIrmQpuS93tvMUICVaqOLCSFREPVzQm4SQQugtK1YPeVS2q9ps0WdrqXcNA8JnZS14CuT5D3lf2bkSjPAiF2AI5xHeCRjMg76cBu9DT/26QyKjNCKe9oqKduMHlne1lVSzDriGhPOL7edrRGwo6a0SaSAUFW/PgDguRFaBrzLE3nd6L5IN79QIBKK7Le/RcC4nEFjBBA+WcuupHF4ahPLaVmENgVLfiC1kdL/YdHkwSYVkmp94whzGeKAaY4P+gd+5GeTj7G4GicfViEaRlpFNaW62hOrDky620gTBUi6UYJTHfhsnY5oDssexMHQWe5b/Ol5NlzjhGmwiR4kaQ== X-YMail-OSG: zDrCPGAVM1nKO6q4JEwQd0TLn_dx5z3NGvb.UsTIFqQDWW2_QU9Eu2G7qEfPxvn XkCvt4XXYgZtyeSQWLmALXZwrgXq95f3.TgppA__RxHl2_GQTuNqOntSLARx7z16_SZOC405wb5P dmzs_SLzVX_qv_XAe1e_6SyqumXPBj6g5GY5vJ32bommQhqlbh3CGW6MD.fVzKl9NgGDN3HrNgSQ uAqOsLTA6yprOwHUOp.jPAXpcTvCi9d324aATxwhzSvleqjnwVkZn7.qn0qv7hkItw6WyBsQrxW9 GkGE44Ly9UU7y5vUQJkskGkygQhAgs9AHjhRT7nJwtN__Pvcksfu_wlX8yqABQ7_G9iqculoxG4y 3N76GrDm4ukxhPx_WZhnzWpNyRzz80UhhRKJHmfr2SDpWhQyPbl_CKpFXgKNHmvYrAb.9_0WV8LG sfGzj5axvp6izZZcH8i9jRrLGhbeXoO3ntqGWtVmSG8h_H87yu779IndHgls17iUGtFSMaQQaren wCXzNwj8Mbr4CgzwbasQQNRRKLivGLBw0c_I1mnFBjK475kVyMxgQ_DQP2oeB5s5jAspyM7QUfbH Shsn6NMbJotgQEYehpNI7sI6b6hHan.fcaD9pZanWen2QJQ89bYCqEyrIZigK_pUUS0.WfhsD_lZ I.uembUWw4jBGrAeesqFtmiyr6Ww7CeQqsdhWtbuk3FQZZQffz5nznf0rql2k0YcWpsAteOzHDTJ FwSYM3hZPqRbZQ9WMON8xK9a.MMPp87IIDpufxohXIgG4MUocFZrK7jblRzdpVZibGJt6IDf2kPe LgZI24cRTUnet.inN02WTYM8RAOG_6P4CYRbbnWiCKnHE3Qx2R7yr4WPETBJCOVUlA2jODAoovrw fe0vpIdUqJONkeZGwY29p4dDU4c3NsMsDrh_9KUDZJBq78vq6_5dOHXMf3VC8MOP3dhqXLPK.gX7 pzIIJ2l0CzzWntdcoP0Q87sdfoLzjX3VyrxNW4foh07rf0Yaa0KWDpNRWhvNozVVaGInDjlbM.cA oKZiuwxYjtAz0ODQWXWcV0rAKZeLpaMoMY2z6vennE2mZ45bnr7m8II3joniWnTraAQPmpQNUSn. qggbLLzSlv3UZTl_F.0EXeo6egH.Pj8QT_2xomUopIk707Fk9iKnf17dOicMfMA6fBFKQTmdjx1L .fNEoRI86hN1VZQeWgLNOYr4xdXY.R7gTT5En8.yX8HynE62Z9gNja16xDbj4vzgnwJ0KX3oqKNN Jik3xHuCy7j7pKO_iJCnAHxOB5v4MWP6v9oIozpMARdeUxxQ83_gBcT6XOvQLJ0oH9ScGCwqgTGr OzOXeWZ7XMTcamXOkKlxaF01ZaMBVLtJulpLcbV2pPN0wrDCPBG5cVf1xavIlH87eQmkif_junML 9.0qn0OePyv06EnHlmaWnGTtQoL.zk56j0DYmI0ib2L3CBN5mDL.eSuW0X4b4HGbQVvtOgstUX5y XmAJ9Sp6UPd0rdKwidP5cjPkhLo6Sr6xInsgVBJ_EvRNI1JMEojo9yED6ekX_tSyRvjETuPSRLVb sdtAdswCL3FueL6z0nVCay0k92c_neQjcW0jXN8R935uG_oQzaZwtjEpxD2lxN7jrn9zD0ursLDO 6TVFTGaih3SthGsIFisrTjLbPrbaltMDqAcMLbV9gtHNSnlnZVzCnbZETFA021MCzqIwNZ.evpmB IqSEl0LWxCUt2aq5MTQ7nHxG3b7vFLRuMbLiNPTIMOOui8SRv34t2hJ3zyjuTBuh5OvuBBnCS820 z7H6ZgNdO.Q_.S7YUny5YRmfs1V7GIherasBf_Q8rceMnWouTuYeZyhkIIjmCNdGeHvTq9bFUPaZ 4N7zIVUNH8RGLjLS4EaE8RZNJcG.nY2MikLlUaWkuqD6yOJtIvAEMfzKCaCRaPVZUPREFB_in47z kCICh4y3IQ0euEB8rs.nhin7kauvYXZUUKfQeeciiRXauvgOmVYavlYsHCBCVJMLVzKFQ9tnT0XX MRCnKbyhcI.VwF36AOBqf2gpGWxikKtYCqVADkDFLWh3Bs5zgBn7xtkk3TU8W_e8Gu8435nZShSM dEuZiEJ4mNfNwSbbIW9ZgD7duiaGPWXC92mTj.gih4ivW7mIlqPGFuAx4ycrvLpyjAIjpJFEysoF 7ieCCClAAdBj.mrJ1DBCuQ7LxIHICbkPjXE04JWObdFgFypR1OhTpAyHTnxk1g23nynNljo4aAU8 - X-Sonic-MF: From: Chuck Zmudzinski To: anthony.perard@citrix.com Cc: xen-devel@lists.xenproject.org, Wei Liu , Juergen Gross , qemu-devel@nongnu.org Subject: [XEN PATCH v2 0/3] Configure qemu upstream correctly by default for igd-passthru Date: Tue, 10 Jan 2023 02:32:01 -0500 Message-Id: X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit References: Content-Length: 9798 Sorry for the length of this cover letter but it is helpful to put all the pros and cons of the two different approaches to solving the problem of configuring the Intel IGD with qemu upstream and libxl in one place, which I attempt to do here. Of course the other approach involves a patch to qemu [1] instead of using this patch series for libxl. The quick answer: I think the other patch to qemu is the better option, but I would be OK if you use this patch series instead. Details with my reasons for preferring the other patch to qemu over this patch series to libxl: I call attention to the commit message of the first patch which points out that using the "pc" machine and adding the xen platform device on the qemu upstream command line is not functionally equivalent to using the "xenfv" machine which automatically adds the xen platform device earlier in the guest creation process. As a result, there is a noticeable reduction in the performance of the guest during startup with the "pc" machne type even if the xen platform device is added via the qemu command line options, although eventually both Linux and Windows guests perform equally well once the guest operating system is fully loaded. Specifically, startup time is longer and neither the grub vga drivers nor the windows vga drivers in early startup perform as well when the xen platform device is added via the qemu command line instead of being added immediately after the other emulated i440fx pci devices when the "xenfv" machine type is used. For example, when using the "pc" machine, which adds the xen platform device using a command line option, the Linux guest could not display the grub boot menu at the native resolution of the monitor, but with the "xenfv" machine, the grub menu is displayed at the full 1920x1080 native resolution of the monitor for testing. So improved startup performance is an advantage for the patch for qemu. I also call attention to the last point of the commit message of the second patch and the comments for reviewers section of the second patch. This approach, as opposed to fixing this in qemu upstream, makes maintaining the code in libxl__build_device_model_args_new more difficult and therefore increases the chances of problems caused by coding errors and typos for users of libxl. So that is another advantage of the patch for qemu. OTOH, fixing this in qemu causes newer qemu versions to behave differently than previous versions of qemu, which the qemu community does not like, although they seem OK with the other patch since it only affects qemu "xenfv" machine types, but they do not want the patch to affect toolstacks like libvirt that do not use qemu upstream's autoconfiguration options as much as libxl does, and, of course, libvirt can manage qemu "xenfv" machines so exising "xenfv" guests configured manually by libvirt could be adversely affected by the patch to qemu, but only if those same guests are also configured for igd-passthrough, which is likely a very small number of possibly affected libvirt users of qemu. A year or two ago I tried to configure guests for pci passthrough on xen using libvirt's tool to convert a libxl xl.cfg file to libvirt xml. It could not convert an xl.cfg file with a configuration item pci = [ "PCI_SPEC_STRING", "PCI_SPEC_STRING", ...] for pci passthrough. So it is unlikely there are any users out there using libvirt to configure xen hvm guests for igd passthrough on xen, and those are the only users that could be adversely affected by the simpler patch to qemu to fix this. The only advantage of this patch series over the qemu patch is that this patch series does not need any patches to qemu to make Intel IGD configuration easier with libxl so the risk of affecting other qemu users is entirely eliminated if we use this patch instead of patching qemu. The cost of patching libxl instead of qemu is reduced startup performance compared to what could be achieved by patching qemu instead and an increased risk that the tedious process of manually managing the slot addresses of all the emulated devices will make it more difficult to keep the libxl code free of bugs. I will leave it to the maintainer of the code in both qemu and libxl (Anthony) to decide which, if any, of the patches to apply. I am OK with either this patch series to libxl or the proposed patch to qemu to fix this problem, but I do recommend the other patch to qemu over this patch series because of the improved performance during startup with that patch and the relatively low risk that any libvirt users will be adversely affected by that patch. Brief statement of the problem this patch series solves: Currently only the qemu traditional device model reserves slot 2 for the Intel Integrated Graphics Device (IGD) with default settings. Assigning the Intel IGD to slot 2 is necessary for the device to operate properly when passed through as the primary graphics adapter. The qemu traditional device model takes care of this by reserving slot 2 for the Intel IGD, but the upstream qemu device model currently does not reserve slot 2 for the Intel IGD. This patch series modifies libxl so the upstream qemu device model will also, with default settings, assign slot 2 for the Intel IGD. There are three reasons why it is difficult to configure the guest so the Intel IGD is assigned to slot 2 in the guest using libxl and the upstream device model, so the patch series is logically organized in three separate patches; each patch resolves one of the three reasons that cause problems: The description of what each of the three libxl patches do: 1. With the default "xenfv" machine type, qemu upstream is hard-coded to assign the xen platform device to slot 2. The first patch fixes that by using the "pc" machine instead when gfx_passthru type is igd and, if xen_platform_pci is set in the guest config, libxl now assigns the xen platform device to slot 3, making it possible to assign the IGD to slot 2. The patch only affects guests with the gfx_passthru option enabled. The default behavior (xen_platform_pci is enabled but gfx_passthru option is disabled) of using the "xenfv" machine type is preserved. Another way to describe what the patch does is to say that it adds a second exception to the default choice of the "xenfv" machine type, with the first exception being that the "pc" machine type is also used instead of "xenfv" if the xen platform pci device is disabled in the guest xl.cfg file. 2. Currently, with libxl and qemu upstream, most emulated pci devices are by default automatically assigned a pci slot, and the emulated ones are assigned before the passed through ones, which means that even if libxl is patched so the xen platform device will not be assigned to slot 2, any other emulated device will be assigned slot 2 unless libxl explicitly assigns the slot address of each emulated pci device in such a way that the IGD will be assigned slot 2. The second patch fixes this by hard coding the slot assignment for the emulated devices instead of deferring to qemu upstream's auto-assignment which does not do what is necessary to configure the Intel IGD correctly. With the second patch applied, it is possible to configure the Intel IGD correctly by using the @VSLOT parameter in xl.cfg to specify the slot address of each passed through pci device in the guest. The second patch is also designed to not change the default behavior of letting qemu autoconfigure the pci slot addresses when igd gfx_pasthru is disabled in xl.cfg. 3. For convenience, the third patch automatically assigns slot 2 to the Intel IGD when the gfx_passthru type is igd so with the third patch appled it is not necessary to set the @VSLOT parameter to configure the Intel IGD correctly. Testing: I tested a system with Intel IGD passthrough and two other pci devices passed through, with and without the xen platform device. I also did tests on guests without any pci passthrough configured. In all cases tested, libxl behaved as expected. For example, the device model arguments are only changed if gfx_passthru is set for the IGD, libxl respected administrator settings such as @VSLOT and xen_platform_pci with the patch series applied, and not adding the xen platform device to the guest caused reduced performance because in that case the guest could not take advantage of the improvements offered by the Xen PV drivers in the guest. I tested the following emulated devices on my setup: xen-platform, e1000, and VGA. I also verified the device that is added by the "hdtype = 'ahci'" xl.cfg option is configured correctly with the patch applied. I did not test all 12 devices that could be affected by patch 2 of the series. These include the intel-hda high definition audio device, a virtio-serial, device, etc. Once can look at the second patch for the full list of qemu emulated devices whose behavior is affected by the second patch of the series when the guest is configured for igd gfx_passthru. These devices are also subject to mistakes in the patch not discovered by the compiler, as mentioned in the comments for reviewers section of the second patch. [1] https://lore.kernel.org/qemu-devel/a09d2427397621eaecee4c46b33507a99cc5f161.1673334040.git.brchuckz@aol.com/ v2: correct the link to the qemu patch - the link in v1 was to an incorrect version of the patch Chuck Zmudzinski (3): libxl/dm: Use "pc" machine type for Intel IGD passthrough libxl/dm: Manage pci slot assignment for Intel IGD passthrough libxl/dm: Assign slot 2 by default for Intel IGD passthrough tools/libs/light/libxl_dm.c | 227 +++++++++++++++++++++++++++++------- 1 file changed, 183 insertions(+), 44 deletions(-) -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Tue Jan 10 07:32:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 07:32:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474310.735417 (Exim 4.92) (envelope-from ) id 1pF97Z-0005Po-PN; Tue, 10 Jan 2023 07:32:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474310.735417; Tue, 10 Jan 2023 07:32:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF97Z-0005PV-HW; Tue, 10 Jan 2023 07:32:33 +0000 Received: by outflank-mailman (input) for mailman id 474310; Tue, 10 Jan 2023 07:32:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF97X-0005Lt-Rx for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 07:32:32 +0000 Received: from sonic314-21.consmr.mail.gq1.yahoo.com (sonic314-21.consmr.mail.gq1.yahoo.com [98.137.69.84]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id eee044ef-90b8-11ed-91b6-6bf2151ebd3b; Tue, 10 Jan 2023 08:32:29 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.gq1.yahoo.com with HTTP; Tue, 10 Jan 2023 07:32:26 +0000 Received: by hermes--production-ne1-7b69748c4d-bxfkx (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 00995f78f0d4fd001b9b8f1699ee7ed7; Tue, 10 Jan 2023 07:32:22 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eee044ef-90b8-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1673335946; bh=MlYqfxn4vwPKUpewBFfsPqn045LoqxLP6nhibRvkmMQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From:Subject:Reply-To; b=E/1qai2PiOIqbUTF+XBOHFQuXUBMbVzW1ho8Ij2gjZ27xRD1dwjXCtNrNQ4E0unkmGIUM3s8WmahRg0TmTsyf4yQMF2t1SpFRc3gh5fUOS6Mijgvqp4JcPgWC/3Uw/0puNm2BNIrF26KL/OwkwKFiwnWU29U9Or0WK1uj75QiHplwK8ho9cMZiFmmi5Jko0yavTTPJa3jHOY3KFr5sZoyLo2LY4CH4jllmRO0630p210u+u2NSTbj7atbAJAM0dseG9/9MGkWMRqwYhC37K4NB7tUvweCDC/cKsQ5Kif53rXB/aQIV5VV+B+iidUvyby/jUEV/l3ysCP3mMmsbaf3Q== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1673335946; bh=LQMlvZQo4JgVkUeUOy2EtUHA3/Ts7yg0JQfMLc1ODBG=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=beDqLG/dZStPkhBKkGVBGhI6zDoDXQyqQKA8cmNBIWiB9Omm6MFO/BIE63xINC/+2lowa2lyXFhXBVaR9pvEm45TmpGaZJlgdonwD4LggH3kdzy+ji5+M+keoV0WS0ABPIX3YR79EUq4M+Y//skWtGKY+WDiaQfImZMkUhYE4/u9U+GJImKG+0gCm8RpdraoON62pKwrfgm9j/rf/roST/Z5BypVOR2kuzaxeIaMjglqaZyoHifWYf68zNB9bDvbSSI0I4wUVy3aWM6BFF6/TRRvbX7PlMQHDv/7KJRS90ZR1J8IaSW4k+ns0Qo6uTw9NqRDtQ+3rdYPTkZ3mQjQMA== X-YMail-OSG: NoXoiVwVM1kCuc.PBP0ELv0IIHyBv1HK6yJ2Lb_Fz4clgpQN0YG76Zddmac7_wE gpkPS9B_wOnXL8pAzvaCN.zNUKJP8cB6x0aW9l1HF1isRiT8qqQnue2kFc_lRJ5mTteg.y48E9Aq GYBT29zIY7VV7kW1o32BWktJpw7WeCla6YHPvbgh.2Nn5ZM0GDr3ndaVJmE0vWlHLJrgfcuYv0.L HsU2SKoU400M5oJFNdlYhMHTyroMhWjsnYeHbM1sct8bahMzUkcyaYAZmUdYkwukPMo0svsgg6AS RUbq_sWRLmRSixhUP1MwuIzniBITSnImNcyCbtt_roM9ghP3bStEolgGKXTZvpztFPMo8UOaXM7Y E.5StQWhJzLDg8Oip0zZG6bH3XJ8j3ECh07NkVAjkuDxR72Nt4KkTXrd2YypaW4N5lzi5uMr5F3a OoZy7Qn.PZHHdPX_6vq6mnRz1tNe05lm8TBU.OcUCnonIpaztC8aXIHKgmIQA2Xiw8iVQLNtM9C2 28zX41nMJXB.JNbPJ94Q6YGq.D_U5HyBArYs63x8M3FyIohVkSiAbWJrQ4jEzO.cb.UESZM5LfrX alBUsclrwrmJRV1LvSJwVyglIhmMrt04YUF0LOcdtGrvX9cdqGFO4QuTVjdBTcXn7RgstJjwVfSB kiJd7r6a2lWUDfgar6s7YVYwHJ0pk20R0zeVUnuwTcQsI7rSu4xS0VL2JI00vpPXsLpXoKGbKPVn q_1zKTpQfq9n3D1ES9HSQD_3XuEgI3Upj123ZaCRgV1mrpalLR9NBfsUPUYSfA.L8Cl_aGa8uGxc OMAPtIFDY9efAPC3Zp_HlHvWmW78HCxg4DK07Q7HvLS_BHcMm_ci3zhgXZrrle7XpagyMYLOtOsx m18kjlhJSRhPB30I8i8ENOKx7j9HoarE2vq_Xl_11S4LJObtjJhuoJpIa3k19BzJqLV9tLLHNsMx i_IPHj3oQzhW3Jf8xf0LNnk8JdIhEU5w07FRDDM_6VimJPwqo3E_HWpTk3yDvPQWQ.7lb0pLJlvt 0sAjTrep.pQn.giv_Hmd89zC72hk_4hZ9af9oaVeyQ8dXuctLkcAQRR5x51dlSU2vPY2uPSZNt5. B2kDGecbM9epAIDdLDgrDAC8haTbZn4vyYW_zrhYDyCC3VwxmiX4Fi2V6PQ.l2gXDH5x80V7NM1P 3hrsXFqUgFtu_cOYiQ3a3JbIIb59LZQydW0QQ4CwQ2umXq8.0.EsR4ij1mm.2hUR9I.cHSo.IOzF rOa.dFPnYnhStCVBnG1MLhouPMisnYTuBLcKcrTy0yzYRRaoBpq8dRwTOXze4njJm2wSiDxrzSfX r8qk_TyNN1kB6h.cdkIwMxzFbtQF7bKp4xNdk_ECLFwq2lUZETLfTO89K1Avi1TxVGPagXHkJKLv _UpNNamE48S7i58YRPeOdwCzxm831xnjrTsBF8xz5s0VSxx8NM5dV9TDI16131NsYBPY6RUeW4.b eRWDNK96BUZ1R5lYze7x2F3sG7OuzXCIWbuvmzbbHBOr9lbWbdrxugDIj08qoFbFdB_38mZvxhYz 93vUjhUXEosfadOst79puBRaSOm0pTTNXe2myi.RbO2jIPfF9upgFPkSUQljgmNCEYBBFFsBTrtY so96vfCP71FeP5c6kevt0_FhRjUCRjGJEcU1rzxlI.jaCo6Oj6LiGF_c5s9647dm9PAVHWrePYH4 oNTV98kNV1CsB76YWAI8bS1Q1oLiqZVPjxjX8aCm2yn4RXc82SqNJwe2n9Z.1F2EHQ.HCUcfQmNE fK5Bsw3_twAjydKfRgpHWCnCeA.eKLDwF9_KR1RP15av78qzqgq8rRZkFoTONYn6fEXJoMja8O4C ItrN.NM1y72uYwIwiHH84SGjP.V0kVyYPLIrnyOngIyX5Fe3gUIaZZ4XExVwQ2KcWLR4GHiXyicB TmvoTVH04sRXtrq3SXEjl4khM1tyz0xXpXONjoxQmD.JXsRgy01l8zLeowf32n7ACsGCn8nMc4LB cJlSgeKNgzjTtJbidSO5tuGBlp2qARmzPYLcVavbUL3noLUPDsdEuzAYzmkPcS37ANV0hAcFsRtH KJVt3WeZoDSM.MghiRdv01.NZRsLVtO148we1u6dT12SdC9QmMz8B0zza8ht383rutR9W2eY_WWK s2xAYRSQp7AciLUKiNHfO9Vpe6hXALoz5N3Kh2L51YNzKvGVUeZAsuTGjd5kHt7CSqyy4arVRclg - X-Sonic-MF: From: Chuck Zmudzinski To: anthony.perard@citrix.com Cc: xen-devel@lists.xenproject.org, Wei Liu , Juergen Gross , qemu-devel@nongnu.org Subject: [XEN PATCH v2 1/3] libxl/dm: Use "pc" machine type for Intel IGD passthrough Date: Tue, 10 Jan 2023 02:32:02 -0500 Message-Id: X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Length: 4686 The default qemu upstream "xenfv" machine type that is used when an HVM guest is configured for Intel IGD passthrough assigns slot 2 to the xen platform pci device. It is a requirement that slot 2 be assigned to the Intel IGD when it is passed through as the primary graphics adapter. Using the "pc" machine type instead of the "xenfv" machine type in that case makes it possible for qemu upstream to assign slot 2 to the IGD. Using the qemu "pc" machine and adding the xen platform device on the qemu command line instead of using the qemu "xenfv" machine which automatically adds the xen platform device earlier in the guest creation process does come with some degredation of startup performance: startup is slower and some vga drivers in use during early boot are unable to display the screen at the native resolution of the monitor, but once the guest operating system (Windows or Linux) is fully loaded, there is no noticeable difference in the performance of the guest when using the "pc" machine type instead of the "xenfv" machine type. With this patch, libxl continues to use default "xenfv" machine type with the default settings of xen_platform_pci enabled and igd gfx_passthru disabled. The patch only affects machines configured with gfx_passthru enabled. Signed-off-by: Chuck Zmudzinski --- Reviewers might find this patch easier to review by looking at the resulting code in the patched file instead of looking at the diff because it is hard to follow the logical flow of the resulting code in the diff because the patch moves the check for igd gfx_passthru before the check for disabling the xen platform device. That change was made because it results in a more simplified logical flow in the resulting code. v2: No changes to this patch since v1 tools/libs/light/libxl_dm.c | 37 ++++++++++++++++++++----------------- 1 file changed, 20 insertions(+), 17 deletions(-) diff --git a/tools/libs/light/libxl_dm.c b/tools/libs/light/libxl_dm.c index fc264a3a13..2048815611 100644 --- a/tools/libs/light/libxl_dm.c +++ b/tools/libs/light/libxl_dm.c @@ -1809,7 +1809,26 @@ static int libxl__build_device_model_args_new(libxl__gc *gc, flexarray_append(dm_args, b_info->extra_pv[i]); break; case LIBXL_DOMAIN_TYPE_HVM: - if (!libxl_defbool_val(b_info->u.hvm.xen_platform_pci)) { + if (libxl_defbool_val(b_info->u.hvm.gfx_passthru)) { + enum libxl_gfx_passthru_kind gfx_passthru_kind = + libxl__detect_gfx_passthru_kind(gc, guest_config); + switch (gfx_passthru_kind) { + case LIBXL_GFX_PASSTHRU_KIND_IGD: + /* + * Using the machine "pc" because with the default machine "xenfv" + * the xen-platform device will be assigned to slot 2, but with + * GFX_PASSTHRU_KIND_IGD, slot 2 needs to be reserved for the Intel IGD. + */ + machinearg = libxl__strdup(gc, "pc,accel=xen,suppress-vmdesc=on,igd-passthru=on"); + break; + case LIBXL_GFX_PASSTHRU_KIND_DEFAULT: + LOGD(ERROR, guest_domid, "unable to detect required gfx_passthru_kind"); + return ERROR_FAIL; + default: + LOGD(ERROR, guest_domid, "invalid value for gfx_passthru_kind"); + return ERROR_INVAL; + } + } else if (!libxl_defbool_val(b_info->u.hvm.xen_platform_pci)) { /* Switching here to the machine "pc" which does not add * the xen-platform device instead of the default "xenfv" machine. */ @@ -1831,22 +1850,6 @@ static int libxl__build_device_model_args_new(libxl__gc *gc, } } - if (libxl_defbool_val(b_info->u.hvm.gfx_passthru)) { - enum libxl_gfx_passthru_kind gfx_passthru_kind = - libxl__detect_gfx_passthru_kind(gc, guest_config); - switch (gfx_passthru_kind) { - case LIBXL_GFX_PASSTHRU_KIND_IGD: - machinearg = GCSPRINTF("%s,igd-passthru=on", machinearg); - break; - case LIBXL_GFX_PASSTHRU_KIND_DEFAULT: - LOGD(ERROR, guest_domid, "unable to detect required gfx_passthru_kind"); - return ERROR_FAIL; - default: - LOGD(ERROR, guest_domid, "invalid value for gfx_passthru_kind"); - return ERROR_INVAL; - } - } - flexarray_append(dm_args, machinearg); for (i = 0; b_info->extra_hvm && b_info->extra_hvm[i] != NULL; i++) flexarray_append(dm_args, b_info->extra_hvm[i]); -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Tue Jan 10 07:32:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 07:32:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474311.735432 (Exim 4.92) (envelope-from ) id 1pF97a-0005qc-Ul; Tue, 10 Jan 2023 07:32:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474311.735432; Tue, 10 Jan 2023 07:32:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF97a-0005pf-Qr; Tue, 10 Jan 2023 07:32:34 +0000 Received: by outflank-mailman (input) for mailman id 474311; Tue, 10 Jan 2023 07:32:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF97Z-0005Lt-0H for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 07:32:33 +0000 Received: from sonic307-54.consmr.mail.gq1.yahoo.com (sonic307-54.consmr.mail.gq1.yahoo.com [98.137.64.30]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f0cd5c42-90b8-11ed-91b6-6bf2151ebd3b; Tue, 10 Jan 2023 08:32:32 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.gq1.yahoo.com with HTTP; Tue, 10 Jan 2023 07:32:29 +0000 Received: by hermes--production-ne1-7b69748c4d-bxfkx (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 00995f78f0d4fd001b9b8f1699ee7ed7; Tue, 10 Jan 2023 07:32:25 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f0cd5c42-90b8-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1673335949; bh=IXWL0zBe+TGnnQx6f+FhHQ+rLQndNCxwY9B4xdroKxQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From:Subject:Reply-To; b=PNwFrlYzMqzEwT/E+oGS8Q3uNQiE/OwLQvqWhehSCNsxbDjavxCS2Sx8ioWWaFwUYqodd3doNUaSKpxANvRfBKu8kh5Zbfgr4KVEACUx2bt97TACZILrnvWl+ERevY7hkGQtPlr6wRnpAxmXcVqkSHDwUZNcv548y4ZowDS9k4bV0knixD185V9gY89QyzzvaGA2hwU9sf0fiGgpdUb18kkIw3C2tSD2Y98q3/PHf40hCTOoePRgx7yzME6wE8pDJ/0HnuKh6CntYEpgCOVJQRMVec2VDvXVRFOyM7r0P982BJI6wbXPu2tJ22h0N8ryoSZSqYA+QJ6z8ggtESDi+w== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1673335949; bh=AcbauxwS4/wmmJiS90weiJNhYtz0Z33GTuCvWkIVR9N=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=R+0zo2IvCY4Wdqy39uABgWGBzxRkNsP/6w02TVt8zAAEAJ7qaxYix6aANJFwgSo9bs/3YvGyROciezOFt9kh4hauvB0kd/dcihnAmt+9uPQFfA3otKnUArLgypXRE9CCW9XiR51i56IS8MSOUjDlPClbnleiURDdHDUtVnPm2hZwpUY1dU8+1JnTJXESdxmE4hwqOSQjxXOVKKom+Q/fmWAY6oPM8famKfl7kmZQ12UluEuw1agvKsOylMxAlDaWWYeDkRESZIxOtLAC/uXrJikGcB+MXwAE+ijoi6iQghdV+ZCHLuOCBqgEL3Nhlfwc35XVXxb70P93FbhtsLa4JA== X-YMail-OSG: RPsCyUQVM1k.LODvx.GNliRJADa_2tXrnOIqgPgucpoj5u6.CpSyWjRtcPImtju 339tm95k_C7yv8umF6C71xfAWUd84RoLbc6nKjHQm7oHCkh_6njsVKVs_qSt2wwA1aPzbx8CFgG2 zJ.agJbugSWvNtkov7LFHNe86z8fXnWdEAllAD3OwKDFVLq9lQ296y5G8B61ZeLMmrJ_v36XcGRR OWbxebwCkNmUUZ.RA09YkBG97TQ1nXfDGt7QQCU543EQuGe4cJMP2sZ.7eB1a2FHvdp3AWGR9JAc 4.sGgwA22xa1rBuAPJ7TUK38k64iWJ8K1hGy5uVr9o4yQcBpw_E7plLwUY38fdX6CrT5QDC_Pt3U ahEljvRm34WeTm_vmH9cTF9l8ZV.oNXtBUtiGPt1lURtvx41uh35KYkW_9bEumxZfM7fEN3UaOtl phHDSNJREvg17vG851M9ZL_WkFslVK.RhZeNG0e85Fm9A3pHr0IwevJPd3GMG5C06Kegz_D8_XKm Xut4nGyC5I.Lmq8mrtfdHHeUDXIEO4izHBCFLDX5EImJoTsR70Jct8zUqe882WUlg.5FjtiU2Rk3 gf7Wmr7DperFZ0DJHiF8vOPshIND3UeGxiGmdq0C7BVF7Z4N10IujB.QMKPC19X4omLZEvVtQl0V 4LAV8l_88rrbE8elgun25dKvNzV3J5T1mVwxBInc._djySsUDklDq28dDTf8TOc4PT9liwaxmeWZ gCflHuVx6CgDhM6YQfBJQXBpDfdqJrlZYww902ziQykuqJ5ZyHQGBuxUJq6MuwyPTvd69G14vpk9 1qxeb94lNfReWZjAzTeB0lz6wGFOfqgDDrnbeQ9rsMvd9mqhB7ZS_m6dN.5r1uoKqFoMZvkMHCrC tC2KYlaPwxLpSZjjbApkXiAdb5C2tYddx8jO8MMPdjgPOMR0vox14Qqsxi9oTWdYobYd6T2e.f85 srZBVJPzHCbsaJyP655r7jmnvBSVmH1FwTnDrOKl51fXWS_3v1w1Ax_2fktc4uAKpayeztPgZsYl y8c8cwopkSEz23LS.NVlJBYlbdY0paxHJDUhCnQZWGlqjxgmlqJDpwaFHjYXosY2QBZc3gW4_Q05 J9hezO0y82shqUdUxC2bFtq2thdd65Y73aWNFIo5LbPN0ltqdAgXSWuDK8OygZi2gEmLp2cAE4EW HL2gUYnie_iiLC94uA0O_BF37MjpBh_AtNaTc7eYUXZkdPyJ3T6QY1K14OUhKsIFqPbtJ08tlE2x C8g.aMBsaFJK3_khjKclTj7V4T_2S5hChdXUWnIHW62dmF_KBjfnJBSPor9U.9XiXuOT7I9n4poA I.aOXMaQuecUE96diL01U2Cfx70M5buWt2RfwVno5H.GBD3_JmCuOhjJMPPdEFGAn7jEc0MPbNoH .cds9poGCLn6wJ_..nGMl_axjUiX4AJqovtaVNczhiw4zU6Wru01tAtxDRX3BoNPMCkLn9BvcP8x YZnaxjCclwuDtrt13TrAIFHwQwGPERQyNfZsRVgXNepSmpWTNKTnskrB542Vyu61XuQAOPldhJFQ nmyGACKPtvnIob2kUw8PRz8IK2Q_eAPqq2q_5Q8T8oMK21TbZn5DT_GnXHkQh5CtRHBFSC01aTcX na7ok0e96Ocm39RqobRCeRXrbPaHOb4vTPds88eEN1FYYvWJBdmagzeO53SVpd4yPAj9q0_zxTa. 9GrKIu.Hw.9SjsW_KVZqxNva9lQScce13CdQpWw8seKlvUHLlQZYUOJwBEJLgsovBbwwfz5Evk23 eCdyO9xo1stpB952fx.Y57qR3hLRbi0HqMSk2LWfA9FF9mk.UepVv7i1cyKQ62RYT8L0817RKpJ4 rxp.XDq9G3kkqHxoZ6DytIMoxi_e7Z3fYVhyXIqb7ms3HZIo5iCaLtGmB.6Xze.pPB6cBmYdgVuU OeypV.6piH64Onmwy7tN_N28ldOdHsvQ_kuON2I9s.oMprO4Ryw2oBgILQ1_tNfxVJjKJdQtxd_2 vx3Vl3MI.XRnJfz2kii6_CirNVs1qPRZL5K7s4Y_SryUouAwLV77xuU9fW5hdVMn6YbbrpACscUV QJxcZ5JjX58rSZsS1dRi36MVCpmYKZm9s5jAWegD.V8l.VYVSAIK.avN_LtLfexcX3hZYnauiAMn qoDCQ08ni_riiw5jhegOlF41Q.mQJKPebCYe.hEzPnHhN7LxLJDDOyDbGpUQ3QftcAci4SKCErh8 - X-Sonic-MF: From: Chuck Zmudzinski To: anthony.perard@citrix.com Cc: xen-devel@lists.xenproject.org, Wei Liu , Juergen Gross , qemu-devel@nongnu.org Subject: [XEN PATCH v2 3/3] libxl/dm: Assign slot 2 by default for Intel IGD passthrough Date: Tue, 10 Jan 2023 02:32:04 -0500 Message-Id: <27bb3979f234c8de6b51be7bb8195e3cacb5181c.1673300848.git.brchuckz@aol.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Length: 2558 It is possible for the administrator to manually specify the virtual slot addresses of passed through pci devices on the guest's pci bus using the @VSLOT parameter in xl.cfg. With this patch, libxl will by default assign the Intel IGD to slot 2 when gfx_passthru is configured for the Intel IGD so it will no longer be necessary to use the @VSLOT setting to configure the IGD correctly. Also, with this patch, libxl will not override explicit @VSLOT settings by the administrator so in that case the patch will have no effect on guest behavior. The default behavior of letting qemu manage the slot addresses of passed through pci devices when gfx_passthru is disabled and the administrator does not set @VSLOT for passed through pci devices is also preserved. Signed-off-by: Chuck Zmudzinski --- v2: No changes to this patch since v1 tools/libs/light/libxl_dm.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/tools/libs/light/libxl_dm.c b/tools/libs/light/libxl_dm.c index 2720b5d4d0..b51ebae643 100644 --- a/tools/libs/light/libxl_dm.c +++ b/tools/libs/light/libxl_dm.c @@ -1207,6 +1207,7 @@ static int libxl__build_device_model_args_new(libxl__gc *gc, int rc; int next_slot; bool configure_pci_for_igd = false; + const int igd_slot = 2; /* * next_slot is only used when we need to configure the pci * slots for the Intel IGD. Slot 2 will be for the Intel IGD. @@ -2173,6 +2174,27 @@ static int libxl__build_device_model_args_new(libxl__gc *gc, flexarray_append(dm_envs, NULL); if (envs) *envs = (char **) flexarray_contents(dm_envs); + if (configure_pci_for_igd) { + libxl_device_pci *pci = NULL; + for (i = 0; i < guest_config->num_pcidevs; i++) { + pci = &guest_config->pcidevs[i]; + if (!pci->vdevfn) { + /* + * Find the Intel IGD and configure it for slot 2. + * Configure any other devices for slot next_slot. + * Since the guest is configured for IGD passthrough, + * assume the device on the host at slot 2 is the IGD. + */ + if (pci->domain == 0 && pci->bus == 0 && + pci->dev == igd_slot && pci->func == 0) { + pci->vdevfn = PCI_DEVFN(igd_slot, 0); + } else { + pci->vdevfn = PCI_DEVFN(next_slot, 0); + next_slot++; + } + } + } + } return 0; } -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Tue Jan 10 07:32:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 07:32:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474312.735437 (Exim 4.92) (envelope-from ) id 1pF97b-0005tx-9n; Tue, 10 Jan 2023 07:32:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474312.735437; Tue, 10 Jan 2023 07:32:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF97b-0005tP-3V; Tue, 10 Jan 2023 07:32:35 +0000 Received: by outflank-mailman (input) for mailman id 474312; Tue, 10 Jan 2023 07:32:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF97Z-0005Lt-Kw for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 07:32:33 +0000 Received: from sonic307-54.consmr.mail.gq1.yahoo.com (sonic307-54.consmr.mail.gq1.yahoo.com [98.137.64.30]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f0ce17e0-90b8-11ed-91b6-6bf2151ebd3b; Tue, 10 Jan 2023 08:32:32 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.gq1.yahoo.com with HTTP; Tue, 10 Jan 2023 07:32:29 +0000 Received: by hermes--production-ne1-7b69748c4d-bxfkx (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 00995f78f0d4fd001b9b8f1699ee7ed7; Tue, 10 Jan 2023 07:32:23 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f0ce17e0-90b8-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1673335949; bh=uHirQOlWVuB6Lr5OlbeNFyBvByaNMmueHYWxVEP496s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From:Subject:Reply-To; b=Oy5ECqB7RYxQ0xeY4XwHq6G+IpuDYUzxomzFfXpdKV2LtdbwjeL9SXK/vXNrjubU6nMMkJ4n+OZrZEi14hoqkCQJ46oh+MKfExW2o1V4CLoRoBSMzglUgLRPp3LcH7mYBmvmuJaroqQcRgozg6CyZjq/ORQtcLEtawJhCq/KKQvVPDw/AfbZkPQYiwJS7531vFgL9yVD4YShHpk7uE2zQo+80xC2ogQ8Z0dm+D/qrKUCEMjsBJwHXf1FK5pZHgitc522JtJHhhqPTpDaFoy/tfvLHhF6tEgYb/dqEpFNUG65uuL1XXfqPelbUvdoKR4R2zN6j3RjLmURk8kDHF3j9A== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1673335949; bh=yjV/LpRrRp+Rn9XEJsZO0kH4qFFobZTwzfyhX1BZbge=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=TZcDZVjqG3+t0g2pfpzGnWXqRfH1Cc5fOII707cXJHnx1Q5brSzUiKUwRw7bEn2XcAXt+qfWazxqbGJ5Einu9fowzTvGQvi0M1ECq6JMxuDFcod+BhuyXtt30wRlx+77suhqBdSDYY7IZcC8aRFkCbrC9THGtUJWpC0wO+YPyEmqlQPeKh8hjTail0MdDVQ8YyzydYt32l8rnyWuutfyspYgsNoz33eOw7CYpisipMigeapZ2k7hN4ATrVdTusI4MVe4+AMd+e/Vpv8sio29lwrG+p2ZHo/gRoHnr6kavHHQVptvghGdyhan7ByQ+UnN7a/i3xe46E+djMTQwPNjNw== X-YMail-OSG: yZ4M3AEVM1kN1QlAmfPoevpe4f29EyvqCohc3s_6hBnPd0be3FNSakkqdwsNxTR yAnQv0jlwMF9zdc_HKDnrSch4S16zjzvcfC6ii8WtwsxSKxcYEbLm7gfwQHoUVSkUmlzdSHjayXI Pofoud_gufFHy4Vm4lNqHacZxSLiimBnYNOCt3mj9SeqVjtAMoL4FpspAtHRozlrFT0eth.VS8wt 5XkopSMS40ycAHezFpVOLstBQm5S1nsBm6HpP_wXLJ8QvDjFoDQTbjtMkObBgPXn1to3kjFFdrNS j4ojBx1GtxSFkMOwrqEgwzmSpRQPPIj7XLx4fRG0NtstD5MpuEE7mpQB1thHh0ZxMrTFnHp9EIPB SIKLNIvF5LRxiPKxAU6L2bW1JEtreokUghfMvj.gZrLRkuml5hBrVIF8EYgKLGJyS_2ly2uo8Ni. My3IPdifOnRpwTEAK9eiwWWw3adOvhddwxzo_L8Z4MnxqqnIdBhUGZVUCdE6AzVdxvYJc6M2vumG S4RsokRdqv4inDs892xy4oKN_LtkDakHtFjMyY9j4aZaBAhUHv2VUmWRtmmWxZYNAiew9r8Dlc4s Cna2.nOfSJ6H1lpVxGCxhFjmYapUgjJIRZkdvWbtmTMXnmk6.e1CxCXbLmdSMsO9ilA8O6e6v5Ud Q.rQXmdxlC4_Cr.IzQjqXRkUJx1T1R_TvV7OjiV192edsverOOsgxZNq5hDcyf0DayuAGK3Dq29Y xnlBvinG0leh39PAsR5zryrjswtbDAbT_dEkiHa.avWrWJvAg1XOJpdgSZSZ58mmZ0XYAt3pEyhK YCmvHDxP88woYb1v7fxu2pNHnQOxkiq3MJItb3eE9msDkeVaT5oEWfx7SPMwAauxLC6yRW3Cb1SP xtiEjAbKE0MMA60rDbECGg9btz0JHSb8vIna.RDTdcLjaoTSd1blgE7yQMexCUA7gTdv0zqoQoWU 1FuRMYptn.U_S1H6dAChrdxTlAIeYbw8hvaxisP31pt0e0YWIma4AomHiBPij9tSNOKoiBxMqEgX yc1GEMR290QVCBedlaXWwOEOb4qrirUtW7T_Hmnyaf8QTM8DanS6aKtJ7DLv.ZXTf7GGT3MHUdDm PkNyr6WHOyabAUtPR5ay_e1k7XMZTu8WSwONg6RHkSxAKU96JCjIFcX0VEVouj4SYkL9a6Cc9qHZ d_fezAMX2.dSvDNMzP7Eq4GcfoWA8BT_cw.4VTVOlhHgiatCY5570Odn87zm6RAkZ613gwUpxxtI PnIIYRreVKwZih7ox0DnVZT5jwmdl3rXFUU5Ym6m8UWKCXmIB_OwvXqAWBFoXvg7REwzB4ob0Udu daKNOm.TN5LCdCrX6e.Vd89cGNtF_SxhkxtjBcBjWrPZhimn5AYMshcwwz4cb3vfLXxaiE_mdcoa ZZ.egpqNTgGF76H9uJRT7UkTTMy3TPNiN4d4YnQ1ffSLyrFumqv79HP9GUDYV6vjWGijmD2Kw5ZP JkHv.bpXU4KId7IgD3r6eg7oUmQhDXFJ.vnlCnw0ePWs9ktfddsLp5Qfd4.GRN0PswikgiZyhWm3 1ABuE6m_8OdvZm5u3LsnbCKq0tv9E6P9VIvgHKk5X_YbKtBRp0G0GkSyLsz32Q4hrvBxNNSSBUF6 LAPsA_cewW5m0_ZfKXohYeyWnX.pc3T.IMH2DCqd.9lz.PvIi2vhv0QIkpS.CrpYJG_9loDZGkTd AA2PMuntDqwW597eY0Y9H7CHxsH1d3UF8WSd4AbIXO1OB0JOuA8ux4ULj._oioDRaoDazgkCiiZS FZs51NOrV7IO.swtfcaw_j4dYkKE299YRbBeNGBk4WjgKzLAWIl9jgVdG9G8xkw5.wpHtt9Elatm 5U_F8fe393Lm_C2kHNYtvd7ial8TQP.l9gJkck5I4K7r8rxxQRjYFhbqoRhijQSpCIJ8E0_ytXD0 m4KpsJBzK16g4tCV7qW2BXDBauT7Rpa3jzTAFBjRTkbZEu192fWxc9iHkxCWFQgZeEk8Au8OmONH HJvNlWBdL.b52sRA1sIAxaq0dsvSQ6wua1mz27Bgy4XviOIEkB1UTePwqx3vYzyvpiOgQ1eCYu7N ek_dS.wInV9pcuwZSUD76MsF4jRAhqoEVGdW.bYi_pYblcf357H_6ucFw2wOSNVFguOYSM8g63Oe YZA4m1aJcLWAqU7zJc7HWPSrnMfXebmrijIA6h3Y7qSNegbG2IRGnnu1mil4FWtSBDTYjAN9E4EA - X-Sonic-MF: From: Chuck Zmudzinski To: anthony.perard@citrix.com Cc: xen-devel@lists.xenproject.org, Wei Liu , Juergen Gross , qemu-devel@nongnu.org Subject: [XEN PATCH v2 2/3] libxl/dm: Manage pci slot assignment for Intel IGD passthrough Date: Tue, 10 Jan 2023 02:32:03 -0500 Message-Id: <76d06f5d01e01df316230def4f31037695f11c1a.1673300848.git.brchuckz@aol.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Length: 15168 By default, except for the ich9-usb-uhci device which libxl assigns to slot 29 (0xid), libxl defers to qemu upstream's automatic slot assignment process, which is simply to assign each emulated device to the next available slot on the pci bus. With this default behavior, libxl and qemu will not configure the Intel IGD correctly. Specifically, the Intel IGD must be assigned to slot 2, but the current default behavior is to assign one of the emulated devices to slot 2. With this patch libxl uses qemu command line options to specify the slot address of each pci device in the guest when gfx_passthru is enabled for the Intel IGD. It uses the same simple algorithm of assigning the next available slot, except that it starts with slot 3 instead of slot 2 for the emulated devices. This process of slot assignment aims to simulate the behavior of existing machines as much as possible. The default behavior (when igd gfx_passthru is disabled) of letting qemu manage the slot addresses of emulated pci devices is preserved. The patch also preserves the special treatment for the ich9 usb2 controller (ich9-usb-ehci1) that libxl currently assigns to slot.function 29.7 and the associated ich9-usb-uhciN devices to slot 29 (0x1d). For future maintainance of this code, it is important that pci devices that are managed by the libxl__build_device_model_args_new function follow the logic of this patch and use the new local counter next_slot to assign the slot address instead of letting upstream qemu assign the slot if the guest is configured for Intel IGD passthrough, and preserve the current behavior of letting qemu assign the slot address otherwise. Signed-off-by: Chuck Zmudzinski --- The diff of this patch is easier to review if it is generated using the -b (aka --ignore-space-change) option of diff/git-diff to filter out some of the changes that are only due to white space. This patch is difficult to verify for correctness without testing all the devices that could be added by the libxl__build_device_model_args_new function. There are 12 places where the addr=%x option needed to be added to the arguments of the "-device" qemu option that adds an emulated pci device which corresponds to at least 12 different devices that could be affected by this patch if the patch contains mistakes that the compiler did not notice. One mistake the compiler would not notice is a missing next_slot++; statement that would result in qemu trying to assign a device to a slot that is already assigned, which is an error in qemu. I did enough tests to find some mistakes in the patch which of course I fixed before submitting the patch. So I cannot guarantee that there are not any other mistakes in the patch because I don't have the resources to do the necessary testing of the many possible configurations that could be affected by this patch. v2: No changes to this patch since v1 tools/libs/light/libxl_dm.c | 168 ++++++++++++++++++++++++++++++------ 1 file changed, 141 insertions(+), 27 deletions(-) diff --git a/tools/libs/light/libxl_dm.c b/tools/libs/light/libxl_dm.c index 2048815611..2720b5d4d0 100644 --- a/tools/libs/light/libxl_dm.c +++ b/tools/libs/light/libxl_dm.c @@ -1205,6 +1205,20 @@ static int libxl__build_device_model_args_new(libxl__gc *gc, const char *path, *chardev; bool is_stubdom = libxl_defbool_val(b_info->device_model_stubdomain); int rc; + int next_slot; + bool configure_pci_for_igd = false; + /* + * next_slot is only used when we need to configure the pci + * slots for the Intel IGD. Slot 2 will be for the Intel IGD. + */ + next_slot = 3; + if (libxl_defbool_val(b_info->u.hvm.gfx_passthru)) { + enum libxl_gfx_passthru_kind gfx_passthru_kind = + libxl__detect_gfx_passthru_kind(gc, guest_config); + if (gfx_passthru_kind == LIBXL_GFX_PASSTHRU_KIND_IGD) { + configure_pci_for_igd = true; + } + } dm_args = flexarray_make(gc, 16, 1); dm_envs = flexarray_make(gc, 16, 1); @@ -1372,6 +1386,20 @@ static int libxl__build_device_model_args_new(libxl__gc *gc, if (b_info->cmdline) flexarray_vappend(dm_args, "-append", b_info->cmdline, NULL); + /* + * When the Intel IGD is configured for primary graphics + * passthrough, we need to manually add the xen platform + * device because the QEMU machine type is "pc". Add it first to + * simulate the behavior of the "xenfv" QEMU machine type which + * always adds the xen platform device first. But in this case it + * will be at slot 3 because we are reserving slot 2 for the IGD. + */ + if (configure_pci_for_igd && + libxl_defbool_val(b_info->u.hvm.xen_platform_pci)) { + flexarray_append_pair(dm_args, "-device", + GCSPRINTF("xen-platform,addr=%x", next_slot)); + next_slot++; + } /* Find out early if one of the disk is on the scsi bus and add a scsi * controller. This is done ahead to keep the same behavior as previous @@ -1381,7 +1409,14 @@ static int libxl__build_device_model_args_new(libxl__gc *gc, continue; } if (strncmp(disks[i].vdev, "sd", 2) == 0) { - flexarray_vappend(dm_args, "-device", "lsi53c895a", NULL); + if (configure_pci_for_igd) { + flexarray_vappend(dm_args, "-device", + GCSPRINTF("lsi53c895a,addr=%x", next_slot), NULL); + next_slot++; + } else { + flexarray_vappend(dm_args, "-device", "lsi53c895a", + NULL); + } break; } } @@ -1436,31 +1471,67 @@ static int libxl__build_device_model_args_new(libxl__gc *gc, flexarray_append(dm_args, "-spice"); flexarray_append(dm_args, spiceoptions); if (libxl_defbool_val(b_info->u.hvm.spice.vdagent)) { - flexarray_vappend(dm_args, "-device", "virtio-serial", - "-chardev", "spicevmc,id=vdagent,name=vdagent", "-device", - "virtserialport,chardev=vdagent,name=com.redhat.spice.0", - NULL); + if (configure_pci_for_igd) { + flexarray_vappend(dm_args, "-device", + GCSPRINTF("virtio-serial,addr=%x", next_slot), + "-chardev", "spicevmc,id=vdagent,name=vdagent", + "-device", + "virtserialport,chardev=vdagent,name=com.redhat.spice.0", + NULL); + next_slot++; + } else { + flexarray_vappend(dm_args, "-device", "virtio-serial", + "-chardev", "spicevmc,id=vdagent,name=vdagent", + "-device", + "virtserialport,chardev=vdagent,name=com.redhat.spice.0", + NULL); + } } } switch (b_info->u.hvm.vga.kind) { case LIBXL_VGA_INTERFACE_TYPE_STD: - flexarray_append_pair(dm_args, "-device", - GCSPRINTF("VGA,vgamem_mb=%d", - libxl__sizekb_to_mb(b_info->video_memkb))); + if (configure_pci_for_igd) { + flexarray_append_pair(dm_args, "-device", + GCSPRINTF("VGA,addr=%x,vgamem_mb=%d", next_slot, + libxl__sizekb_to_mb(b_info->video_memkb))); + next_slot++; + } else { + flexarray_append_pair(dm_args, "-device", + GCSPRINTF("VGA,vgamem_mb=%d", + libxl__sizekb_to_mb(b_info->video_memkb))); + } break; case LIBXL_VGA_INTERFACE_TYPE_CIRRUS: - flexarray_append_pair(dm_args, "-device", - GCSPRINTF("cirrus-vga,vgamem_mb=%d", - libxl__sizekb_to_mb(b_info->video_memkb))); + if (configure_pci_for_igd) { + flexarray_append_pair(dm_args, "-device", + GCSPRINTF("cirrus-vga,addr=%x,vgamem_mb=%d", next_slot, + libxl__sizekb_to_mb(b_info->video_memkb))); + next_slot++; + } else { + flexarray_append_pair(dm_args, "-device", + GCSPRINTF("cirrus-vga,vgamem_mb=%d", + libxl__sizekb_to_mb(b_info->video_memkb))); + } break; case LIBXL_VGA_INTERFACE_TYPE_NONE: break; case LIBXL_VGA_INTERFACE_TYPE_QXL: /* QXL have 2 ram regions, ram and vram */ - flexarray_append_pair(dm_args, "-device", - GCSPRINTF("qxl-vga,vram_size_mb=%"PRIu64",ram_size_mb=%"PRIu64, - (b_info->video_memkb/2/1024), (b_info->video_memkb/2/1024) ) ); + if (configure_pci_for_igd) { + flexarray_append_pair(dm_args, "-device", + GCSPRINTF("qxl-vga,addr=%x,vram_size_mb=%"PRIu64 + ",ram_size_mb=%"PRIu64, next_slot, + (b_info->video_memkb/2/1024), + (b_info->video_memkb/2/1024) ) ); + next_slot++; + } else { + flexarray_append_pair(dm_args, "-device", + GCSPRINTF("qxl-vga,vram_size_mb=%"PRIu64 + ",ram_size_mb=%"PRIu64, + (b_info->video_memkb/2/1024), + (b_info->video_memkb/2/1024) ) ); + } break; default: LOGD(ERROR, guest_domid, "Invalid emulated video card specified"); @@ -1496,8 +1567,15 @@ static int libxl__build_device_model_args_new(libxl__gc *gc, } else if (b_info->u.hvm.usbversion) { switch (b_info->u.hvm.usbversion) { case 1: - flexarray_vappend(dm_args, - "-device", "piix3-usb-uhci,id=usb", NULL); + if (configure_pci_for_igd) { + flexarray_vappend(dm_args, "-device", + GCSPRINTF("piix3-usb-uhci,addr=%x,id=usb", + next_slot), NULL); + next_slot++; + } else { + flexarray_vappend(dm_args, + "-device", "piix3-usb-uhci,id=usb", NULL); + } break; case 2: flexarray_append_pair(dm_args, "-device", @@ -1509,8 +1587,15 @@ static int libxl__build_device_model_args_new(libxl__gc *gc, i, 2*(i-1), i-1)); break; case 3: - flexarray_vappend(dm_args, - "-device", "nec-usb-xhci,id=usb", NULL); + if (configure_pci_for_igd) { + flexarray_vappend(dm_args, "-device", + GCSPRINTF("nec-usb-xhci,addr=%x,id=usb", + next_slot), NULL); + next_slot++; + } else { + flexarray_vappend(dm_args, + "-device", "nec-usb-xhci,id=usb", NULL); + } break; default: LOGD(ERROR, guest_domid, "usbversion parameter is invalid, " @@ -1542,8 +1627,15 @@ static int libxl__build_device_model_args_new(libxl__gc *gc, switch (soundhw) { case LIBXL__QEMU_SOUNDHW_HDA: - flexarray_vappend(dm_args, "-device", "intel-hda", - "-device", "hda-duplex", NULL); + if (configure_pci_for_igd) { + flexarray_vappend(dm_args, "-device", + GCSPRINTF("intel-hda,addr=%x", next_slot), + "-device", "hda-duplex", NULL); + next_slot++; + } else { + flexarray_vappend(dm_args, "-device", "intel-hda", + "-device", "hda-duplex", NULL); + } break; default: flexarray_append_pair(dm_args, "-device", @@ -1573,10 +1665,18 @@ static int libxl__build_device_model_args_new(libxl__gc *gc, guest_domid, nics[i].devid, LIBXL_NIC_TYPE_VIF_IOEMU); flexarray_append(dm_args, "-device"); - flexarray_append(dm_args, - GCSPRINTF("%s,id=nic%d,netdev=net%d,mac=%s", - nics[i].model, nics[i].devid, - nics[i].devid, smac)); + if (configure_pci_for_igd) { + flexarray_append(dm_args, + GCSPRINTF("%s,addr=%x,id=nic%d,netdev=net%d,mac=%s", + nics[i].model, next_slot, nics[i].devid, + nics[i].devid, smac)); + next_slot++; + } else { + flexarray_append(dm_args, + GCSPRINTF("%s,id=nic%d,netdev=net%d,mac=%s", + nics[i].model, nics[i].devid, + nics[i].devid, smac)); + } flexarray_append(dm_args, "-netdev"); flexarray_append(dm_args, GCSPRINTF("type=tap,id=net%d,ifname=%s," @@ -1865,8 +1965,15 @@ static int libxl__build_device_model_args_new(libxl__gc *gc, if (b_info->type == LIBXL_DOMAIN_TYPE_HVM) { flexarray_append_pair(dm_envs, "XEN_DOMAIN_ID", GCSPRINTF("%d", guest_domid)); - if (b_info->u.hvm.hdtype == LIBXL_HDTYPE_AHCI) - flexarray_append_pair(dm_args, "-device", "ahci,id=ahci0"); + if (b_info->u.hvm.hdtype == LIBXL_HDTYPE_AHCI) { + if (configure_pci_for_igd) { + flexarray_append_pair(dm_args, "-device", + GCSPRINTF("ahci,addr=%x,id=ahci0", next_slot)); + next_slot++; + } else { + flexarray_append_pair(dm_args, "-device", "ahci,id=ahci0"); + } + } for (i = 0; i < num_disks; i++) { int disk, part; int dev_number = @@ -2043,7 +2150,14 @@ static int libxl__build_device_model_args_new(libxl__gc *gc, switch (b_info->u.hvm.vendor_device) { case LIBXL_VENDOR_DEVICE_XENSERVER: flexarray_append(dm_args, "-device"); - flexarray_append(dm_args, "xen-pvdevice,device-id=0xc000"); + if (configure_pci_for_igd) { + flexarray_append(dm_args, + GCSPRINTF("xen-pvdevice,addr=%x,device-id=0xc000", + next_slot)); + next_slot++; + } else { + flexarray_append(dm_args, "xen-pvdevice,device-id=0xc000"); + } break; default: break; -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Tue Jan 10 07:48:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 07:48:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474340.735460 (Exim 4.92) (envelope-from ) id 1pF9NA-0000GF-VT; Tue, 10 Jan 2023 07:48:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474340.735460; Tue, 10 Jan 2023 07:48:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF9NA-0000G3-R5; Tue, 10 Jan 2023 07:48:40 +0000 Received: by outflank-mailman (input) for mailman id 474340; Tue, 10 Jan 2023 07:48:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF9N9-0000Ft-6l; Tue, 10 Jan 2023 07:48:39 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF9N9-0007Bi-5E; Tue, 10 Jan 2023 07:48:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF9N8-0005zr-QE; Tue, 10 Jan 2023 07:48:38 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pF9N8-0000iy-Pj; Tue, 10 Jan 2023 07:48:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=TVToy+jeKt1DzVB1dJuKD4F62A8Wmozc/5IZ0Lufei0=; b=kecf6nYbxH0Tl2ytRQCxO04XMF akS4Z5BDMVUxvooJ9riSr0DF8kolT9MpLAFqmps20nXh4K5TSPLdKeWXml2JwFhkcXTlNHaBb4qC5 LKrQsXfQ8nORsDMgkQILUxvkIL3F+ioHkJwDnPxv+ewb/A47qOfN6dcHF5MUg8T0exV8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 175665: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=1fe4fd6f5cad346e598593af36caeadc4f5d4fa9 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Tue, 10 Jan 2023 07:48:38 +0000 flight 175665 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/175665/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine 8 reboot fail REGR. vs. 173462 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux 1fe4fd6f5cad346e598593af36caeadc4f5d4fa9 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 94 days Failing since 173470 2022-10-08 06:21:34 Z 94 days 197 attempts Testing same since 175634 2023-01-09 01:40:59 Z 1 days 3 attempts ------------------------------------------------------------ 3317 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 505645 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Jan 10 08:05:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 08:05:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474355.735477 (Exim 4.92) (envelope-from ) id 1pF9cv-0003Gy-Q0; Tue, 10 Jan 2023 08:04:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474355.735477; Tue, 10 Jan 2023 08:04:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF9cv-0003Gr-Mp; Tue, 10 Jan 2023 08:04:57 +0000 Received: by outflank-mailman (input) for mailman id 474355; Tue, 10 Jan 2023 08:04:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF9ct-0003Gh-PM; Tue, 10 Jan 2023 08:04:55 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF9ct-0007zY-Mq; Tue, 10 Jan 2023 08:04:55 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF9ct-0006NO-GU; Tue, 10 Jan 2023 08:04:55 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pF9ct-0007nW-G0; Tue, 10 Jan 2023 08:04:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=NrXu3tLBKgJjiFNZg1YGlt3SnSBYSoFCmFAOLEvkgtI=; b=E10PODYds9/trZMSGCQKJlkOyK cgibozrgVtnevO+9JtY1FFE1/1uAZ+enRAV8SxveTwHfuXP4RCxiT4HQGHvtRbuY72+sM0uBx+0hH hl/9TdaVPf9dVIEvy1jekoo32LMIDkvA+omM+UAhG2/DjVFGRufIpW0cEy/doMWPauPA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 175681: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-amd64-xsm:xen-build:fail:regression qemu-mainline:build-amd64:xen-build:fail:regression qemu-mainline:build-i386:xen-build:fail:regression qemu-mainline:build-arm64-xsm:xen-build:fail:regression qemu-mainline:build-i386-xsm:xen-build:fail:regression qemu-mainline:build-arm64:xen-build:fail:regression qemu-mainline:build-armhf:xen-build:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-coresched-amd64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:build-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-rtds:build-check(1):blocked:nonblocking qemu-mainline:build-arm64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking qemu-mainline:build-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking qemu-mainline:build-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-dom0pvh-xl-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-dom0pvh-xl-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvshim:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-pygrub:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvhv2-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-freebsd11-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-freebsd12-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvhv2-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-multivcpu:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: qemuu=aa96ab7c9df59c615ca82b49c9062819e0a1c287 X-Osstest-Versions-That: qemuu=0ab12aa32462817f0a53fa6f6ce4baf664ef1713 From: osstest service owner Date: Tue, 10 Jan 2023 08:04:55 +0000 flight 175681 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/175681/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 175623 build-amd64 6 xen-build fail REGR. vs. 175623 build-i386 6 xen-build fail REGR. vs. 175623 build-arm64-xsm 6 xen-build fail REGR. vs. 175623 build-i386-xsm 6 xen-build fail REGR. vs. 175623 build-arm64 6 xen-build fail REGR. vs. 175623 build-armhf 6 xen-build fail REGR. vs. 175623 Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-win7-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ws16-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-shadow 1 build-check(1) blocked n/a test-amd64-i386-xl-vhd 1 build-check(1) blocked n/a test-amd64-i386-xl-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) blocked n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) blocked n/a test-armhf-armhf-xl-rtds 1 build-check(1) blocked n/a test-armhf-armhf-xl-vhd 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-amd 1 build-check(1) blocked n/a test-amd64-i386-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-i386 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-amd64 1 build-check(1) blocked n/a test-amd64-coresched-i386-xl 1 build-check(1) blocked n/a test-amd64-coresched-amd64-xl 1 build-check(1) blocked n/a test-amd64-amd64-xl-xsm 1 build-check(1) blocked n/a build-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-shadow 1 build-check(1) blocked n/a test-amd64-amd64-xl-rtds 1 build-check(1) blocked n/a build-arm64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ws16-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a build-armhf-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-amd64-dom0pvh-xl-amd 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 1 build-check(1) blocked n/a test-amd64-amd64-dom0pvh-xl-intel 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvshim 1 build-check(1) blocked n/a test-amd64-amd64-pair 1 build-check(1) blocked n/a test-amd64-amd64-pygrub 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvhv2-intel 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-freebsd11-amd64 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-freebsd12-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvhv2-amd 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-nested-amd 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-nested-intel 1 build-check(1) blocked n/a test-amd64-amd64-xl-multivcpu 1 build-check(1) blocked n/a test-amd64-amd64-xl 1 build-check(1) blocked n/a test-amd64-amd64-xl-credit1 1 build-check(1) blocked n/a test-amd64-amd64-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-arndale 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-intel 1 build-check(1) blocked n/a test-amd64-i386-xl 1 build-check(1) blocked n/a test-amd64-i386-xl-pvshim 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a version targeted for testing: qemuu aa96ab7c9df59c615ca82b49c9062819e0a1c287 baseline version: qemuu 0ab12aa32462817f0a53fa6f6ce4baf664ef1713 Last test of basis 175623 2023-01-07 23:09:00 Z 2 days Failing since 175627 2023-01-08 14:40:14 Z 1 days 9 attempts Testing same since 175654 2023-01-09 18:08:58 Z 0 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: Ard Biesheuvel Bernhard Beschow Christian Borntraeger Cindy Lu Dongli Zhang Eugenio Pérez Greg Kurz Guoyi Tu Hyman Huang(黄勇) Igor Mammedov Jason Wang Jonathan Cameron Kai Huang Laszlo Ersek Lei Xiang leixiang Liuxiangdong Longpeng Lubomir Rintel Marc-André Lureau Markus Armbruster Michael S. Tsirkin Nikita Ivanov Paolo Bonzini Peter Maydell Philippe Mathieu-Daudé Richard Henderson Thomas Huth Yanan Wang Yicong Yang Zeng Chi jobs: build-amd64-xsm fail build-arm64-xsm fail build-i386-xsm fail build-amd64 fail build-arm64 fail build-armhf fail build-i386 fail build-amd64-libvirt blocked build-arm64-libvirt blocked build-armhf-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl blocked test-amd64-coresched-amd64-xl blocked test-arm64-arm64-xl blocked test-armhf-armhf-xl blocked test-amd64-i386-xl blocked test-amd64-coresched-i386-xl blocked test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm blocked test-amd64-i386-xl-qemuu-debianhvm-i386-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm blocked test-arm64-arm64-xl-xsm blocked test-amd64-i386-xl-xsm blocked test-amd64-amd64-qemuu-nested-amd blocked test-amd64-amd64-xl-pvhv2-amd blocked test-amd64-i386-qemuu-rhel6hvm-amd blocked test-amd64-amd64-dom0pvh-xl-amd blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64 blocked test-amd64-i386-xl-qemuu-debianhvm-amd64 blocked test-amd64-i386-freebsd10-amd64 blocked test-amd64-amd64-qemuu-freebsd11-amd64 blocked test-amd64-amd64-qemuu-freebsd12-amd64 blocked test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked test-amd64-amd64-xl-qemuu-win7-amd64 blocked test-amd64-i386-xl-qemuu-win7-amd64 blocked test-amd64-amd64-xl-qemuu-ws16-amd64 blocked test-amd64-i386-xl-qemuu-ws16-amd64 blocked test-armhf-armhf-xl-arndale blocked test-amd64-amd64-xl-credit1 blocked test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 blocked test-amd64-amd64-xl-credit2 blocked test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 blocked test-armhf-armhf-xl-cubietruck blocked test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict blocked test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict blocked test-amd64-i386-freebsd10-i386 blocked test-amd64-amd64-qemuu-nested-intel blocked test-amd64-amd64-xl-pvhv2-intel blocked test-amd64-i386-qemuu-rhel6hvm-intel blocked test-amd64-amd64-dom0pvh-xl-intel blocked test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu blocked test-armhf-armhf-xl-multivcpu blocked test-amd64-amd64-pair blocked test-amd64-i386-pair blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim blocked test-amd64-i386-xl-pvshim blocked test-amd64-amd64-pygrub blocked test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds blocked test-armhf-armhf-xl-rtds blocked test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow blocked test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow blocked test-amd64-amd64-xl-shadow blocked test-amd64-i386-xl-shadow blocked test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd blocked test-amd64-i386-xl-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2556 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Jan 10 08:07:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 08:07:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474363.735488 (Exim 4.92) (envelope-from ) id 1pF9ex-0003qe-6n; Tue, 10 Jan 2023 08:07:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474363.735488; Tue, 10 Jan 2023 08:07:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF9ex-0003qX-3P; Tue, 10 Jan 2023 08:07:03 +0000 Received: by outflank-mailman (input) for mailman id 474363; Tue, 10 Jan 2023 08:07:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF9ev-0003qN-OP for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 08:07:01 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c272e00a-90bd-11ed-91b6-6bf2151ebd3b; Tue, 10 Jan 2023 09:07:00 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E669438644; Tue, 10 Jan 2023 08:06:59 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 42E641358A; Tue, 10 Jan 2023 08:06:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id OCfgDqMcvWP8BQAAMHmgww (envelope-from ); Tue, 10 Jan 2023 08:06:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c272e00a-90bd-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1673338019; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zFXGBYfEGk+Jg1p3t9ncmeM1OkJ5SOgglsWjtD+4D3E=; b=MU0PDUFJ2NOK1/QtTmhG08jj+/hc3DiAuRHDHTX1+NVJc1guSrtQvC8BVMTDUdfLTtyHGF 6APJegbUQMpu/JSlQUeDOXjwRXvediBWLPQiIOxWIiWdsx/2uu14gNsCvHo9CWNCj9U567 FAJqat2f5hJEHt/USBs7CM7dZZ25UOc= Message-ID: <76596dba-efb7-eab1-bca9-60ab67823ade@suse.com> Date: Tue, 10 Jan 2023 09:06:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2] hvc/xen: lock console list traversal Content-Language: en-US To: Roger Pau Monne , linux-kernel@vger.kernel.org Cc: xen-devel@lists.xenproject.org, Greg Kroah-Hartman , Jiri Slaby , Boris Ostrovsky , Jan Beulich , Stefano Stabellini , Konrad Rzeszutek Wilk , linuxppc-dev@lists.ozlabs.org References: <20221130163611.14686-1-roger.pau@citrix.com> From: Juergen Gross In-Reply-To: <20221130163611.14686-1-roger.pau@citrix.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------6nQNq6G02bf1dW0c6lDPjjkY" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------6nQNq6G02bf1dW0c6lDPjjkY Content-Type: multipart/mixed; boundary="------------Kb0uGwizoLvibEvRPqCzPKl8"; protected-headers="v1" From: Juergen Gross To: Roger Pau Monne , linux-kernel@vger.kernel.org Cc: xen-devel@lists.xenproject.org, Greg Kroah-Hartman , Jiri Slaby , Boris Ostrovsky , Jan Beulich , Stefano Stabellini , Konrad Rzeszutek Wilk , linuxppc-dev@lists.ozlabs.org Message-ID: <76596dba-efb7-eab1-bca9-60ab67823ade@suse.com> Subject: Re: [PATCH v2] hvc/xen: lock console list traversal References: <20221130163611.14686-1-roger.pau@citrix.com> In-Reply-To: <20221130163611.14686-1-roger.pau@citrix.com> --------------Kb0uGwizoLvibEvRPqCzPKl8 Content-Type: multipart/mixed; boundary="------------gP0Ef10fixcPW6kf2HHiGOoT" --------------gP0Ef10fixcPW6kf2HHiGOoT Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMzAuMTEuMjIgMTc6MzYsIFJvZ2VyIFBhdSBNb25uZSB3cm90ZToNCj4gVGhlIGN1cnJl bnRseSBsb2NrbGVzcyBhY2Nlc3MgdG8gdGhlIHhlbiBjb25zb2xlIGxpc3QgaW4NCj4gdnRl cm1ub190b194ZW5jb25zKCkgaXMgaW5jb3JyZWN0LCBhcyBhZGRpdGlvbnMgYW5kIHJlbW92 YWxzIGZyb20gdGhlDQo+IGxpc3QgY2FuIGhhcHBlbiBhbnl0aW1lLCBhbmQgYXMgc3VjaCB0 aGUgdHJhdmVyc2FsIG9mIHRoZSBsaXN0IHRvIGdldA0KPiB0aGUgcHJpdmF0ZSBjb25zb2xl IGRhdGEgZm9yIGEgZ2l2ZW4gdGVybW5vIG5lZWRzIHRvIGhhcHBlbiB3aXRoIHRoZQ0KPiBs b2NrIGhlbGQuICBOb3RlIHVzZXJzIHRoYXQgbW9kaWZ5IHRoZSBsaXN0IGFscmVhZHkgZG8g c28gd2l0aCB0aGUNCj4gbG9jayB0YWtlbi4NCj4gDQo+IEFkanVzdCBjdXJyZW50IGxvY2sg dGFrZXJzIHRvIHVzZSB0aGUgX2lycXtzYXZlLHJlc3RvcmV9IGhlbHBlcnMsDQo+IHNpbmNl IHRoZSBjb250ZXh0IGluIHdoaWNoIHZ0ZXJtbm9fdG9feGVuY29ucygpIGlzIGNhbGxlZCBj YW4gaGF2ZQ0KPiBpbnRlcnJ1cHRzIGRpc2FibGVkLiAgVXNlIHRoZSBfaXJxe3NhdmUscmVz dG9yZX0gc2V0IG9mIGhlbHBlcnMgdG8NCj4gc3dpdGNoIHRoZSBjdXJyZW50IGNhbGxlcnMg dG8gZGlzYWJsZSBpbnRlcnJ1cHRzIGluIHRoZSBsb2NrZWQgcmVnaW9uLg0KPiBJIGhhdmVu J3QgY2hlY2tlZCBpZiBleGlzdGluZyB1c2VycyBjb3VsZCBpbnN0ZWFkIHVzZSB0aGUgX2ly cQ0KPiB2YXJpYW50LCBhcyBJIHRoaW5rIGl0J3Mgc2FmZXIgdG8gdXNlIF9pcnF7c2F2ZSxy ZXN0b3JlfSB1cGZyb250Lg0KPiANCj4gV2hpbGUgdGhlcmUgc3dpdGNoIGZyb20gdXNpbmcg bGlzdF9mb3JfZWFjaF9lbnRyeV9zYWZlIHRvDQo+IGxpc3RfZm9yX2VhY2hfZW50cnk6IHRo ZSBjdXJyZW50IGVudHJ5IGN1cnNvciB3b24ndCBiZSByZW1vdmVkIGFzDQo+IHBhcnQgb2Yg dGhlIGNvZGUgaW4gdGhlIGxvb3AgYm9keSwgc28gdXNpbmcgdGhlIF9zYWZlIHZhcmlhbnQg aXMNCj4gcG9pbnRsZXNzLg0KPiANCj4gRml4ZXM6IDAyZTE5ZjljN2NhYyAoJ2h2Y194ZW46 IGltcGxlbWVudCBtdWx0aWNvbnNvbGUgc3VwcG9ydCcpDQo+IFNpZ25lZC1vZmYtYnk6IFJv Z2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPg0KDQpQdXNoZWQgdG8geGVu L3RpcC5naXQgZm9yLWxpbnVzLTYuMg0KDQoNCkp1ZXJnZW4NCg0K --------------gP0Ef10fixcPW6kf2HHiGOoT Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------gP0Ef10fixcPW6kf2HHiGOoT-- --------------Kb0uGwizoLvibEvRPqCzPKl8-- --------------6nQNq6G02bf1dW0c6lDPjjkY Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmO9HKIFAwAAAAAACgkQsN6d1ii/Ey+t twf/SCL+Qbrvyi0dgYX3s8xBkFvBU9UzEaa6MxDE1aev/pt1IndKUcFrciE11V00rdeqb+jb/PbR K5b1n843/V+EbAEFfAIV9K9LCH9YiDFqUJ49yKQEL58vieL2FVD4OvZTWuKTgeTwu1kPrD4O4m7V UVhWsedPcHGFHWvLs3e8oujnke1Jhj2lfD5DqGWdht1X/4te+j6Owzy3JO69M3FYVRZYzn+72qv/ NON65BQg2FuDujwdzvDP4Vvsqz684JxVc3qi9bI9JH7VJH1FbwApJ1mQKU5xmWx24MxfAPgNEajB uaJ48m4NrF4BTw4QmhmEQ4vlGS2Ilb4GalWyksQypA== =E2fh -----END PGP SIGNATURE----- --------------6nQNq6G02bf1dW0c6lDPjjkY-- From xen-devel-bounces@lists.xenproject.org Tue Jan 10 08:07:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 08:07:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474369.735499 (Exim 4.92) (envelope-from ) id 1pF9fZ-0004Qv-Kz; Tue, 10 Jan 2023 08:07:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474369.735499; Tue, 10 Jan 2023 08:07:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF9fZ-0004Qk-I3; Tue, 10 Jan 2023 08:07:41 +0000 Received: by outflank-mailman (input) for mailman id 474369; Tue, 10 Jan 2023 08:07:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF9fY-0004IQ-Cn for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 08:07:40 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d8637e25-90bd-11ed-b8d0-410ff93cb8f0; Tue, 10 Jan 2023 09:07:38 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A68AB4D6EE; Tue, 10 Jan 2023 08:07:36 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 374CE1358A; Tue, 10 Jan 2023 08:07:36 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id LNETDMgcvWNKBgAAMHmgww (envelope-from ); Tue, 10 Jan 2023 08:07:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d8637e25-90bd-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1673338056; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xohioAh1kapJutPJWQnyJIvtrut+K4fCdUNvyrvvEps=; b=F/1x9PdCXjPQpN04iGPzwZgJ9ewZMUL6Am2p+uO7S6oRkx1yxxHLC2OkN2nirzqHxJ/eiO lkmdc9OI/RFJP8wF1UH6d3f1vS4dNjAaB2KDnNinVFybpOkVE9FUHcIiTtwx/x5UwgvwJP 3X8qReklSQNoZijRLpF81364vnxmPVA= Message-ID: <8a2abe27-361a-aab1-60fe-00a3cc8684ff@suse.com> Date: Tue, 10 Jan 2023 09:07:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2] xen: make remove callback of xen driver void returned Content-Language: en-US To: Dawei Li , sstabellini@kernel.org, oleksandr_tyshchenko@epam.com Cc: roger.pau@citrix.com, peterhuewe@gmx.de, oleksandr_andrushchenko@epam.com, airlied@gmail.com, dmitry.torokhov@gmail.com, wei.liu@kernel.org, bhelgaas@google.com, jejb@linux.ibm.com, gregkh@linuxfoundation.org, ericvh@gmail.com, tiwai@suse.com, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org References: From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------0lgsG4DjM2bogqj9tDjcsDeD" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------0lgsG4DjM2bogqj9tDjcsDeD Content-Type: multipart/mixed; boundary="------------r84Y64pzyXf8LsYbXQjpT04r"; protected-headers="v1" From: Juergen Gross To: Dawei Li , sstabellini@kernel.org, oleksandr_tyshchenko@epam.com Cc: roger.pau@citrix.com, peterhuewe@gmx.de, oleksandr_andrushchenko@epam.com, airlied@gmail.com, dmitry.torokhov@gmail.com, wei.liu@kernel.org, bhelgaas@google.com, jejb@linux.ibm.com, gregkh@linuxfoundation.org, ericvh@gmail.com, tiwai@suse.com, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Message-ID: <8a2abe27-361a-aab1-60fe-00a3cc8684ff@suse.com> Subject: Re: [PATCH v2] xen: make remove callback of xen driver void returned References: In-Reply-To: --------------r84Y64pzyXf8LsYbXQjpT04r Content-Type: multipart/mixed; boundary="------------BJxvnO001IhyRZyK5BKNLhzp" --------------BJxvnO001IhyRZyK5BKNLhzp Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTMuMTIuMjIgMTY6NDYsIERhd2VpIExpIHdyb3RlOg0KPiBTaW5jZSBjb21taXQgZmM3 YTYyMDlkNTcxICgiYnVzOiBNYWtlIHJlbW92ZSBjYWxsYmFjayByZXR1cm4gdm9pZCIpDQo+ IGZvcmNlcyBidXNfdHlwZTo6cmVtb3ZlIGJlIHZvaWQtcmV0dXJuZWQsIGl0IGRvZXNuJ3Qg bWFrZSBtdWNoIHNlbnNlIGZvcg0KPiBhbnkgYnVzIGJhc2VkIGRyaXZlciBpbXBsZW1lbnRp bmcgcmVtb3ZlIGNhbGxiYWxrIHRvIHJldHVybiBub24tdm9pZCB0bw0KPiBpdHMgY2FsbGVy Lg0KPiANCj4gVGhpcyBjaGFuZ2UgaXMgZm9yIHhlbiBidXMgYmFzZWQgZHJpdmVycy4NCj4g DQo+IEFja2VkLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQo+IFNpZ25l ZC1vZmYtYnk6IERhd2VpIExpIDxzZXRfcHRlX2F0QG91dGxvb2suY29tPg0KDQpQdXNoZWQg dG8geGVuL3RpcC5naXQgZm9yLWxpbnVzLTYuMg0KDQoNCkp1ZXJnZW4NCg0K --------------BJxvnO001IhyRZyK5BKNLhzp Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------BJxvnO001IhyRZyK5BKNLhzp-- --------------r84Y64pzyXf8LsYbXQjpT04r-- --------------0lgsG4DjM2bogqj9tDjcsDeD Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmO9HMcFAwAAAAAACgkQsN6d1ii/Ey+f 1wf+K+5GUrDsbaaoBFao/iA/yd9cCF6PTSRa8C28Z0Xu+s5K30n0thAK7JjyRMZJmzbemu4XZVA6 OxCGIQdrkLTmgoGRTZjdYbFhz7C4ByTAEqkgk72umn3WZEqthOfZY1EE2Imd1beYJzeLfjM6U32h DuUK14cuf7PbMVfAxpMgPvk+awBFO7fjD5gdNRpAE/F1eseawanTnJSeD5AVm4MRJCwnQr9/8xWA M0lm0kk3xCfAu1tlqV2XXuAXF8pZCdXr6/heuDpg2UwwakevfI3rHCsGO85anJ1vWiWJR+5N3hrz 8f7fsLu5VuBRJPVziQO8zwQUNBXYTCjlBj7/Ba8lJQ== =VY/4 -----END PGP SIGNATURE----- --------------0lgsG4DjM2bogqj9tDjcsDeD-- From xen-devel-bounces@lists.xenproject.org Tue Jan 10 08:08:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 08:08:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474375.735510 (Exim 4.92) (envelope-from ) id 1pF9fu-0004sH-Tm; Tue, 10 Jan 2023 08:08:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474375.735510; Tue, 10 Jan 2023 08:08:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF9fu-0004s8-QH; Tue, 10 Jan 2023 08:08:02 +0000 Received: by outflank-mailman (input) for mailman id 474375; Tue, 10 Jan 2023 08:08:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF9ft-0004Qe-Ml for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 08:08:01 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e627c658-90bd-11ed-91b6-6bf2151ebd3b; Tue, 10 Jan 2023 09:08:00 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A12B03E6DB; Tue, 10 Jan 2023 08:07:59 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 58EC01358A; Tue, 10 Jan 2023 08:07:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id RSjlE98cvWN8BgAAMHmgww (envelope-from ); Tue, 10 Jan 2023 08:07:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e627c658-90bd-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1673338079; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=w0R2jA+ecFgshta3vkDpZTjBNhdF5coLo4TxsrYpzyw=; b=GYs+Bd0xk7tL3+jMhddK1YqdH0y8+YWKn/QW0Usjy068JSSa3m2T1TIYuNDR/J5RDDBt34 qPBzDL4Hj17EH6WuSyKzKJbmp/bl0a1C+YJfn7kapTvp3vGqQdbnJik8osI+6bIiYmYwP7 2RxpB0T9FicBnqLefEhE0gSrceVH9Os= Message-ID: Date: Tue, 10 Jan 2023 09:07:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v1] xen/pvcalls: free active map buffer on pvcalls_front_free_map Content-Language: en-US To: Oleksii Moisieiev , "sstabellini@kernel.org" Cc: Oleksandr Tyshchenko , "xen-devel@lists.xenproject.org" , "linux-kernel@vger.kernel.org" References: <6a762ee32dd655cbb09a4aa0e2307e8919761311.1671531297.git.oleksii_moisieiev@epam.com> From: Juergen Gross In-Reply-To: <6a762ee32dd655cbb09a4aa0e2307e8919761311.1671531297.git.oleksii_moisieiev@epam.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------8gQ0uGiBiOXOeEGU0HSLL09N" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------8gQ0uGiBiOXOeEGU0HSLL09N Content-Type: multipart/mixed; boundary="------------u9z5dqxRb0ujLeyXzcx9HgSU"; protected-headers="v1" From: Juergen Gross To: Oleksii Moisieiev , "sstabellini@kernel.org" Cc: Oleksandr Tyshchenko , "xen-devel@lists.xenproject.org" , "linux-kernel@vger.kernel.org" Message-ID: Subject: Re: [PATCH v1] xen/pvcalls: free active map buffer on pvcalls_front_free_map References: <6a762ee32dd655cbb09a4aa0e2307e8919761311.1671531297.git.oleksii_moisieiev@epam.com> In-Reply-To: <6a762ee32dd655cbb09a4aa0e2307e8919761311.1671531297.git.oleksii_moisieiev@epam.com> --------------u9z5dqxRb0ujLeyXzcx9HgSU Content-Type: multipart/mixed; boundary="------------KYcv5NY9RdtDLbyPZBpgAZJU" --------------KYcv5NY9RdtDLbyPZBpgAZJU Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjAuMTIuMjIgMTU6NTAsIE9sZWtzaWkgTW9pc2llaWV2IHdyb3RlOg0KPiBEYXRhIGJ1 ZmZlciBmb3IgYWN0aXZlIG1hcCBpcyBhbGxvY2F0ZWQgaW4gYWxsb2NfYWN0aXZlX3Jpbmcg YW5kIGZyZWVkDQo+IGluIGZyZWVfYWN0aXZlX3JpbmcgZnVuY3Rpb24sIHdoaWNoIGlzIHVz ZWQgb25seSBmb3IgdGhlIGVycm9yDQo+IGNsZWFudXAuIHB2Y2FsbHNfZnJvbnRfcmVsZWFz ZSBpcyBjYWxsaW5nIHB2Y2FsbHNfZnJvbnRfZnJlZV9tYXAgd2hpY2gNCj4gZW5kcyBmb3Jl aWduIGFjY2VzcyBmb3IgdGhpcyBidWZmZXIsIGJ1dCBkb2Vzbid0IGZyZWUgYWxsb2NhdGVk IHBhZ2VzLg0KPiBDYWxsIGZyZWVfYWN0aXZlX3JpbmcgdG8gY2xlYW4gYWxsIGFsbG9jYXRl ZCByZXNvdXJjZXMuDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBPbGVrc2lpIE1vaXNpZWlldiA8 b2xla3NpaV9tb2lzaWVpZXZAZXBhbS5jb20+DQoNClB1c2hlZCB0byB4ZW4vdGlwLmdpdCBm b3ItbGludXMtNi4yDQoNCg0KSnVlcmdlbg0KDQo= --------------KYcv5NY9RdtDLbyPZBpgAZJU Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------KYcv5NY9RdtDLbyPZBpgAZJU-- --------------u9z5dqxRb0ujLeyXzcx9HgSU-- --------------8gQ0uGiBiOXOeEGU0HSLL09N Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmO9HN4FAwAAAAAACgkQsN6d1ii/Ey+7 5AgAhFX4FfJ6FhYGxjTFPefYV/e5GSvSZuMf+G8RGk5j6ehl8KBdnWO+m4l9T+lXGSLrxJZ8phvl Heo2Z6UvTHmaoYajeIDfdmdwDfJxiNHWygW2qAFkBypCd8pKeZhk9VPiEYpsCpLDEjOlth+ggViX wbzNwmUAslTbrWZniHPaqVdsCFV/JPdKf5/olC37FaRoVy26U4PYkUcnflMSq8jaXFfLNedOlGva TvYd/zyEsROKkSuzBpbxRp3lcng41lzlYZcT/ZFiXECdnU4t9iHtBraYZXySbfbuCW/E4UvHWP43 02ip9dMJCiy8mzOYcO4OABjVJNr4JZad80XtOxqFBA== =BVWP -----END PGP SIGNATURE----- --------------8gQ0uGiBiOXOeEGU0HSLL09N-- From xen-devel-bounces@lists.xenproject.org Tue Jan 10 08:08:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 08:08:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474377.735521 (Exim 4.92) (envelope-from ) id 1pF9gJ-0005Th-6r; Tue, 10 Jan 2023 08:08:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474377.735521; Tue, 10 Jan 2023 08:08:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF9gJ-0005Ta-46; Tue, 10 Jan 2023 08:08:27 +0000 Received: by outflank-mailman (input) for mailman id 474377; Tue, 10 Jan 2023 08:08:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF9gH-0004IQ-OG for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 08:08:25 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f3e1ec29-90bd-11ed-b8d0-410ff93cb8f0; Tue, 10 Jan 2023 09:08:24 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1FE54676B3; Tue, 10 Jan 2023 08:08:23 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BD4431358A; Tue, 10 Jan 2023 08:08:22 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id GNjLLPYcvWO+BgAAMHmgww (envelope-from ); Tue, 10 Jan 2023 08:08:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f3e1ec29-90bd-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1673338103; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EOLvc5pnec6Qvz0IU+meu3lE65aCc308JtHNKiojSLY=; b=RdVtED4QkMdawYnUheFwonqrPjjaeMxanOr0oKCs0M9/UOFRKUnxjmXEqvW9/yH9KdH1jN rc3H8Mhp9GwaScjUMpfXNXZWSHUkwc+HSfMRBmMoyLwYk8q3mXAnRNNyaokzfo9lsWOJ5G 3obgGgtI7piKJWWw/dclODpSkreYogY= Message-ID: <7c844c39-2ca0-0ee7-0c05-66932403fa30@suse.com> Date: Tue, 10 Jan 2023 09:08:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2] x86/xen: Remove the unused function p2m_index() Content-Language: en-US To: Jiapeng Chong Cc: boris.ostrovsky@oracle.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, Abaci Robot References: <20230105090141.36248-1-jiapeng.chong@linux.alibaba.com> From: Juergen Gross In-Reply-To: <20230105090141.36248-1-jiapeng.chong@linux.alibaba.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------0PNXtjnnvM7ewaD6a96IAjRq" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------0PNXtjnnvM7ewaD6a96IAjRq Content-Type: multipart/mixed; boundary="------------F5pGtvD6Hmk9tBX0D0MdPuj0"; protected-headers="v1" From: Juergen Gross To: Jiapeng Chong Cc: boris.ostrovsky@oracle.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, Abaci Robot Message-ID: <7c844c39-2ca0-0ee7-0c05-66932403fa30@suse.com> Subject: Re: [PATCH v2] x86/xen: Remove the unused function p2m_index() References: <20230105090141.36248-1-jiapeng.chong@linux.alibaba.com> In-Reply-To: <20230105090141.36248-1-jiapeng.chong@linux.alibaba.com> --------------F5pGtvD6Hmk9tBX0D0MdPuj0 Content-Type: multipart/mixed; boundary="------------pRGhk8J2LAf4W2eEJiqH0h3E" --------------pRGhk8J2LAf4W2eEJiqH0h3E Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDUuMDEuMjMgMTA6MDEsIEppYXBlbmcgQ2hvbmcgd3JvdGU6DQo+IFRoZSBmdW5jdGlv biBwMm1faW5kZXggaXMgZGVmaW5lZCBpbiB0aGUgcDJtLmMgZmlsZSwgYnV0IG5vdCBjYWxs ZWQNCj4gZWxzZXdoZXJlLCBzbyByZW1vdmUgdGhpcyB1bnVzZWQgZnVuY3Rpb24uDQo+IA0K PiBhcmNoL3g4Ni94ZW4vcDJtLmM6MTM3OjI0OiB3YXJuaW5nOiB1bnVzZWQgZnVuY3Rpb24g J3AybV9pbmRleCcuDQo+IA0KPiBMaW5rOiBodHRwczovL2J1Z3ppbGxhLm9wZW5hbm9saXMu Y24vc2hvd19idWcuY2dpP2lkPTM1NTcNCj4gUmVwb3J0ZWQtYnk6IEFiYWNpIFJvYm90IDxh YmFjaUBsaW51eC5hbGliYWJhLmNvbT4NCj4gU2lnbmVkLW9mZi1ieTogSmlhcGVuZyBDaG9u ZyA8amlhcGVuZy5jaG9uZ0BsaW51eC5hbGliYWJhLmNvbT4NCg0KUHVzaGVkIHRvIHhlbi90 aXAuZ2l0IGZvci1saW51cy02LjINCg0KDQpKdWVyZ2VuDQoNCg== --------------pRGhk8J2LAf4W2eEJiqH0h3E Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------pRGhk8J2LAf4W2eEJiqH0h3E-- --------------F5pGtvD6Hmk9tBX0D0MdPuj0-- --------------0PNXtjnnvM7ewaD6a96IAjRq Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmO9HPYFAwAAAAAACgkQsN6d1ii/Ey9F lwgAimMoYe0xETfpgDsSG8zRtW6MWXY+2UTVahqK1Y1e7wgJxgCKy8vumEKadDLlxOl+z2e40y1q RfL7syF3t6hhWbqt/VlsBSYSoaVdC0Wi9ML1VGcI5BGng7QNwr6alTmtUN4kqVY/z4Es2NDU14VK Exnp2y4vK1J1jNcOOPLppcewbtbmC9beSlHAQ3Z2fHKOSJb/vejUAxXQPWc30LHZl8HgDjF2TMz7 sIhvRMVU5RcmQn/RlUBSEu08SWXrB86iFiuS33jMYC+iKU1INTDPLiV7iFQp//9GWR3EZkk+PbMf i11oUoPUcXSQn0gNErHuNZLVAptfo9os5n2UvBpS1Q== =IQpu -----END PGP SIGNATURE----- --------------0PNXtjnnvM7ewaD6a96IAjRq-- From xen-devel-bounces@lists.xenproject.org Tue Jan 10 08:09:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 08:09:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474387.735532 (Exim 4.92) (envelope-from ) id 1pF9hW-0006Ah-GZ; Tue, 10 Jan 2023 08:09:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474387.735532; Tue, 10 Jan 2023 08:09:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF9hW-0006Aa-Dl; Tue, 10 Jan 2023 08:09:42 +0000 Received: by outflank-mailman (input) for mailman id 474387; Tue, 10 Jan 2023 08:09:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF9hV-0006AM-47 for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 08:09:41 +0000 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [2a00:1450:4864:20::636]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 213f1f2f-90be-11ed-91b6-6bf2151ebd3b; Tue, 10 Jan 2023 09:09:39 +0100 (CET) Received: by mail-ej1-x636.google.com with SMTP id hw16so14615723ejc.10 for ; Tue, 10 Jan 2023 00:09:39 -0800 (PST) Received: from 2a02.2378.1014.d6d9.ip.kyivstar.net ([2a02:2378:1014:d6d9:98bb:6889:a785:5d8c]) by smtp.gmail.com with ESMTPSA id 14-20020a170906308e00b0084d3acda5fasm3165190ejv.189.2023.01.10.00.09.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jan 2023 00:09:38 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 213f1f2f-90be-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=1wqDTBTYa0JxVyZO5wjAE7AZ1AFSwlVaPJIYsCDPwwE=; b=LB+V2D1ACwno6eZ0473SRU+SA1WtKlU85/d5U6OJO+5P0QYajaCNkpekazAruO6cJm uHGWIaBYAFxDPJpwxnrJuEemYwqtKFJziDMfEwbeV3yqt62xfqBIvnW21LBiXI7ee7gq 1CS5IIBF3nnj5IsM8y6IhTqCUXw/+mqmXXw0TvmfySZZo7IUWGO9qq+G54/hv/XQpvD7 JTG96E8qh/3wJpiPpvAChKBG4E7omT/y9B/JoL0k7QcizfD0GZg82JGO0RjqFrIR60cv Z3ZTlOtcuj4ofHR3lq/5vBVR7NY961dWPOZ0ss7TIj8WSfzoThlQNyLyeQjO8WsVqFML HJZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=1wqDTBTYa0JxVyZO5wjAE7AZ1AFSwlVaPJIYsCDPwwE=; b=GDfz3HaILMOHRynyjbnCmWhLq9WG/bsUi8wQvJ0OxqGxlP+0mACGkervbHn/M1qxY9 yXZyeDewZ1Hzm2Bs0DUawkdPb8AVfk4ATH/A2lBO1OHM9nYs5rjMlfFf5t/Xnb465k7R flJVBbuSC2Mi9TBrS2yci4nAr8JrrZQLxLBgmTC/Z+d68+U3/U7IztYZELduVzc2mRw2 TLD9fSV2f/z7jV3N/LTJijnamf1pQ6TJ60EHWQ1rMpcPsksTF9qq5sYtWIUbmz5U3ZLb 2MhuQZeDm6NAJtFLXouf9PL6BwvQDCDanowFEkLcsWabwXNZDkcy+T2hMLZDAer7FKHb qASw== X-Gm-Message-State: AFqh2kpUSe6pqhzkRNTln2Wy+IkIyL1UDpRmywXefAVaXsabxJMfDuOc 93MUTwnrLCWcBYguKzaimU0= X-Google-Smtp-Source: AMrXdXs4j6+OHvVyZWiZxdSan/h33AzijSxyP2fAtJ+jxhDsyI/qow+wWYt7uGbXC5vU4ngVJ8O9KA== X-Received: by 2002:a17:906:8492:b0:7c1:6b46:a722 with SMTP id m18-20020a170906849200b007c16b46a722mr59135972ejx.56.1673338179013; Tue, 10 Jan 2023 00:09:39 -0800 (PST) Message-ID: <8488a52b2e15944b8882c9c93344fb1ced171056.camel@gmail.com> Subject: Re: [PATCH v2 8/8] automation: add RISC-V smoke test From: Oleksii To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, Jan Beulich , Julien Grall , Andrew Cooper , Gianluca Guida , Doug Goldstein Date: Tue, 10 Jan 2023 10:09:37 +0200 In-Reply-To: References: <494c2fd1e046de20c2fa24be3989cc6adde8fdbe.1673278109.git.oleksii.kurochko@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.1 (3.46.1-1.fc37) MIME-Version: 1.0 On Mon, 2023-01-09 at 18:21 -0800, Stefano Stabellini wrote: > On Mon, 9 Jan 2023, Oleksii Kurochko wrote: > > Add check if there is a message 'Hello from C env' presents > > in log file to be sure that stack is set and C part of early printk > > is working. > >=20 > > Signed-off-by: Oleksii Kurochko > > --- > > Changes in V2: > > =C2=A0=C2=A0=C2=A0 - Move changes in the dockerfile to separate patch a= nd=C2=A0 send it > > to > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 mailing list separately: > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 [PATCH] automation: add qemu= -system-riscv to > > riscv64.dockerfile > > =C2=A0=C2=A0=C2=A0 - Update test.yaml to wire up smoke test > > --- > > =C2=A0automation/gitlab-ci/test.yaml=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 | 20 ++++++++++++++++++++ > > =C2=A0automation/scripts/qemu-smoke-riscv64.sh | 20 +++++++++++++++++++= + > > =C2=A02 files changed, 40 insertions(+) > > =C2=A0create mode 100755 automation/scripts/qemu-smoke-riscv64.sh > >=20 > > diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab- > > ci/test.yaml > > index afd80adfe1..64f47a0ab9 100644 > > --- a/automation/gitlab-ci/test.yaml > > +++ b/automation/gitlab-ci/test.yaml > > @@ -54,6 +54,19 @@ > > =C2=A0=C2=A0 tags: > > =C2=A0=C2=A0=C2=A0=C2=A0 - x86_64 > > =C2=A0 > > +.qemu-riscv64: > > +=C2=A0 extends: .test-jobs-common > > +=C2=A0 variables: > > +=C2=A0=C2=A0=C2=A0 CONTAINER: archlinux:riscv64 >=20 > I realize that it is committed now, but following the arm32 > convention > the name of the arch container (currently archlinux:riscv64) would > be: >=20 > CONTAINER: archlinux:current-riscv64 >=20 > I know this is not related to this patch, but I am taking the > opportunity to mention it now in case we get an opportunity to fix it > in > the future for consistency. >=20 >=20 > > +=C2=A0=C2=A0=C2=A0 LOGFILE: qemu-smoke-riscv64.log > > +=C2=A0 artifacts: > > +=C2=A0=C2=A0=C2=A0 paths: > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - smoke.serial > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - '*.log' > > +=C2=A0=C2=A0=C2=A0 when: always > > +=C2=A0 tags: > > +=C2=A0=C2=A0=C2=A0 - x86_64 > > + > > =C2=A0.yocto-test: > > =C2=A0=C2=A0 extends: .test-jobs-common > > =C2=A0=C2=A0 script: > > @@ -234,6 +247,13 @@ qemu-smoke-x86-64-clang-pvh: > > =C2=A0=C2=A0 needs: > > =C2=A0=C2=A0=C2=A0=C2=A0 - debian-unstable-clang-debug > > =C2=A0 > > +qemu-smoke-riscv64-gcc: > > +=C2=A0 extends: .qemu-riscv64 > > +=C2=A0 script: > > +=C2=A0=C2=A0=C2=A0 - ./automation/scripts/qemu-smoke-riscv64.sh 2>&1 |= tee > > ${LOGFILE} > > +=C2=A0 needs: > > +=C2=A0=C2=A0=C2=A0 - riscv64-cross-gcc >=20 > Similarly here the "needs" dependency should be called > arch-current-gcc-riscv for consistency with arm32. >=20 > Basically we already have a crossbuild and crosstest environment up > and > running in gitlab-ci and it is the one for arm32. You can just base > all > the naming convention on that. >=20 > I realize that riscv64-cross-gcc is also already exported by > build.yaml, > but I am mentioning it in case we get an opportunity to fix it in the > future. >=20 > Nonetheless this patch on its own is OK so >=20 > Acked-by: Stefano Stabellini >=20 Thanks for the comments. I think it will be nice to fix that from the start so I will do a separete patch out of this patch series (when it will be merged) which will fix all this names related to RISCV. >=20 > > =C2=A0# Yocto test jobs > > =C2=A0yocto-qemuarm64: > > =C2=A0=C2=A0 extends: .yocto-test-arm64 > > diff --git a/automation/scripts/qemu-smoke-riscv64.sh > > b/automation/scripts/qemu-smoke-riscv64.sh > > new file mode 100755 > > index 0000000000..e0f06360bc > > --- /dev/null > > +++ b/automation/scripts/qemu-smoke-riscv64.sh > > @@ -0,0 +1,20 @@ > > +#!/bin/bash > > + > > +set -ex > > + > > +# Run the test > > +rm -f smoke.serial > > +set +e > > + > > +timeout -k 1 2 \ > > +qemu-system-riscv64 \ > > +=C2=A0=C2=A0=C2=A0 -M virt \ > > +=C2=A0=C2=A0=C2=A0 -smp 1 \ > > +=C2=A0=C2=A0=C2=A0 -nographic \ > > +=C2=A0=C2=A0=C2=A0 -m 2g \ > > +=C2=A0=C2=A0=C2=A0 -kernel binaries/xen \ > > +=C2=A0=C2=A0=C2=A0 |& tee smoke.serial > > + > > +set -e > > +(grep -q "Hello from C env" smoke.serial) || exit 1 > > +exit 0 > > --=20 > > 2.38.1 > >=20 ~Oleksii From xen-devel-bounces@lists.xenproject.org Tue Jan 10 08:16:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 08:16:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474395.735543 (Exim 4.92) (envelope-from ) id 1pF9o8-0007km-A5; Tue, 10 Jan 2023 08:16:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474395.735543; Tue, 10 Jan 2023 08:16:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF9o8-0007kf-7K; Tue, 10 Jan 2023 08:16:32 +0000 Received: by outflank-mailman (input) for mailman id 474395; Tue, 10 Jan 2023 08:16:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF9o6-0007kZ-RJ for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 08:16:31 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 13963517-90bf-11ed-b8d0-410ff93cb8f0; Tue, 10 Jan 2023 09:16:27 +0100 (CET) Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-374-UJXH8I9wOKCKdZ50-_WKXQ-1; Tue, 10 Jan 2023 03:16:24 -0500 Received: by mail-wm1-f71.google.com with SMTP id n8-20020a05600c294800b003d1cc68889dso2265835wmd.7 for ; Tue, 10 Jan 2023 00:16:24 -0800 (PST) Received: from redhat.com ([2.52.155.142]) by smtp.gmail.com with ESMTPSA id i13-20020adffdcd000000b002a91572638csm10285640wrs.75.2023.01.10.00.16.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jan 2023 00:16:21 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 13963517-90bf-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673338585; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fdfdV2mGPZFbQYgeIp74EWeax4bjPbcYuP1ixJmlo6w=; b=Q3kEzwAsht7/IVVQMf6E40bIoMyFR150CNbIDIiNu1TY06PqJ25BS7x07sDpsIJy4WjmFQ yXbARH/9yTtkKcjvhfbdBIoYS/flAKH+qilxl3QXYRWovbdGHfanAiTHzP9RSQAK4dxusq GnjhgLpTgZzRemB6pZ5D1DaejMODVsY= X-MC-Unique: UJXH8I9wOKCKdZ50-_WKXQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fdfdV2mGPZFbQYgeIp74EWeax4bjPbcYuP1ixJmlo6w=; b=u7o4wzNAz6IofWAlHy7KjYAMwDsVYvDuItjBB56FMdU5CvSGu82S6atGWx2fRbK0OT 4x2TFC1ibaQMm2vqyUDW6pFxuJwbOEWaTL5i/pcB4CgENJKDkWY6JPCEFAXtD01As9UE 2y/E+w1gPLiK7dkrqe4ao7mAIxJLC+b9MoeP+ob8afC2f/pbrRVqkhcxZGmO8zsWw2mF Rzt4sAowNK3ehBtDeBGtr0sQ/O2TKzznfCFNK3lJJeB4nGf3ZnO2SBPcfL3CWoYk8R6j lER62F7lcTeD1Uld2+rWjCMQLIoWKSTWbpn1VzhdCYzZY99d63bx0YyYjv8zoCfIqyyo pdEA== X-Gm-Message-State: AFqh2kqg3nTSH3TFILX2jlnTDX5xD24YECUjf3jSItpR0RJF6dTHdHAW 54lZ8EiAZZhxj0ZoXm4U5+0IhbxHNhoGQHK0VK5uU93x6FfctNqpCt5NjRYm4ff5JUAepMIeRTZ 9FxsGEi4Z02FvD7wEDZlXUzylnY8= X-Received: by 2002:a05:6000:a19:b0:2b1:c393:cbe with SMTP id co25-20020a0560000a1900b002b1c3930cbemr13525500wrb.11.1673338582839; Tue, 10 Jan 2023 00:16:22 -0800 (PST) X-Google-Smtp-Source: AMrXdXv4CeJ65urswcTquNnKzwMVxiexQ61lL8ZVID0TxM/EtuK9pODIr7IFSCXKmw7b02ueWsWl4A== X-Received: by 2002:a05:6000:a19:b0:2b1:c393:cbe with SMTP id co25-20020a0560000a1900b002b1c3930cbemr13525485wrb.11.1673338582488; Tue, 10 Jan 2023 00:16:22 -0800 (PST) Date: Tue, 10 Jan 2023 03:16:17 -0500 From: "Michael S. Tsirkin" To: Chuck Zmudzinski Cc: qemu-devel@nongnu.org, Stefano Stabellini , Anthony Perard , Paul Durrant , Paolo Bonzini , Richard Henderson , Eduardo Habkost , Marcel Apfelbaum , xen-devel@lists.xenproject.org Subject: Re: [PATCH v8] xen/pt: reserve PCI slot 2 for Intel igd-passthru Message-ID: <20230110030331-mutt-send-email-mst@kernel.org> References: MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jan 10, 2023 at 02:08:34AM -0500, Chuck Zmudzinski wrote: > Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, > as noted in docs/igd-assign.txt in the Qemu source code. > > Currently, when the xl toolstack is used to configure a Xen HVM guest with > Intel IGD passthrough to the guest with the Qemu upstream device model, > a Qemu emulated PCI device will occupy slot 2 and the Intel IGD will occupy > a different slot. This problem often prevents the guest from booting. > > The only available workaround is not good: Configure Xen HVM guests to use > the old and no longer maintained Qemu traditional device model available > from xenbits.xen.org which does reserve slot 2 for the Intel IGD. > > To implement this feature in the Qemu upstream device model for Xen HVM > guests, introduce the following new functions, types, and macros: > > * XEN_PT_DEVICE_CLASS declaration, based on the existing TYPE_XEN_PT_DEVICE > * XEN_PT_DEVICE_GET_CLASS macro helper function for XEN_PT_DEVICE_CLASS > * typedef XenPTQdevRealize function pointer > * XEN_PCI_IGD_SLOT_MASK, the value of slot_reserved_mask to reserve slot 2 > * xen_igd_reserve_slot and xen_igd_clear_slot functions > > The new xen_igd_reserve_slot function uses the existing slot_reserved_mask > member of PCIBus to reserve PCI slot 2 for Xen HVM guests configured using > the xl toolstack with the gfx_passthru option enabled, which sets the > igd-passthru=on option to Qemu for the Xen HVM machine type. > > The new xen_igd_reserve_slot function also needs to be implemented in > hw/xen/xen_pt_stub.c to prevent FTBFS during the link stage for the case > when Qemu is configured with --enable-xen and --disable-xen-pci-passthrough, > in which case it does nothing. > > The new xen_igd_clear_slot function overrides qdev->realize of the parent > PCI device class to enable the Intel IGD to occupy slot 2 on the PCI bus > since slot 2 was reserved by xen_igd_reserve_slot when the PCI bus was > created in hw/i386/pc_piix.c for the case when igd-passthru=on. > > Move the call to xen_host_pci_device_get, and the associated error > handling, from xen_pt_realize to the new xen_igd_clear_slot function to > initialize the device class and vendor values which enables the checks for > the Intel IGD to succeed. The verification that the host device is an > Intel IGD to be passed through is done by checking the domain, bus, slot, > and function values as well as by checking that gfx_passthru is enabled, > the device class is VGA, and the device vendor in Intel. > > Signed-off-by: Chuck Zmudzinski > --- > Notes that might be helpful to reviewers of patched code in hw/xen: > > The new functions and types are based on recommendations from Qemu docs: > https://qemu.readthedocs.io/en/latest/devel/qom.html > > Notes that might be helpful to reviewers of patched code in hw/i386: > > The small patch to hw/i386/pc_piix.c is protected by CONFIG_XEN so it does > not affect builds that do not have CONFIG_XEN defined. > > xen_igd_gfx_pt_enabled() in the patched hw/i386/pc_piix.c file is an > existing function that is only true when Qemu is built with > xen-pci-passthrough enabled and the administrator has configured the Xen > HVM guest with Qemu's igd-passthru=on option. > > v2: Remove From: tag at top of commit message > > v3: Changed the test for the Intel IGD in xen_igd_clear_slot: > > if (is_igd_vga_passthrough(&s->real_device) && > (s->real_device.vendor_id == PCI_VENDOR_ID_INTEL)) { > > is changed to > > if (xen_igd_gfx_pt_enabled() && (s->hostaddr.slot == 2) > && (s->hostaddr.function == 0)) { > > I hoped that I could use the test in v2, since it matches the > other tests for the Intel IGD in Qemu and Xen, but those tests > do not work because the necessary data structures are not set with > their values yet. So instead use the test that the administrator > has enabled gfx_passthru and the device address on the host is > 02.0. This test does detect the Intel IGD correctly. > > v4: Use brchuckz@aol.com instead of brchuckz@netscape.net for the author's > email address to match the address used by the same author in commits > be9c61da and c0e86b76 > > Change variable for XEN_PT_DEVICE_CLASS: xptc changed to xpdc > > v5: The patch of xen_pt.c was re-worked to allow a more consistent test > for the Intel IGD that uses the same criteria as in other places. > This involved moving the call to xen_host_pci_device_get from > xen_pt_realize to xen_igd_clear_slot and updating the checks for the > Intel IGD in xen_igd_clear_slot: > > if (xen_igd_gfx_pt_enabled() && (s->hostaddr.slot == 2) > && (s->hostaddr.function == 0)) { > > is changed to > > if (is_igd_vga_passthrough(&s->real_device) && > s->real_device.domain == 0 && s->real_device.bus == 0 && > s->real_device.dev == 2 && s->real_device.func == 0 && > s->real_device.vendor_id == PCI_VENDOR_ID_INTEL) { > > Added an explanation for the move of xen_host_pci_device_get from > xen_pt_realize to xen_igd_clear_slot to the commit message. > > Rebase. > > v6: Fix logging by removing these lines from the move from xen_pt_realize > to xen_igd_clear_slot that was done in v5: > > XEN_PT_LOG(d, "Assigning real physical device %02x:%02x.%d" > " to devfn 0x%x\n", > s->hostaddr.bus, s->hostaddr.slot, s->hostaddr.function, > s->dev.devfn); > > This log needs to be in xen_pt_realize because s->dev.devfn is not > set yet in xen_igd_clear_slot. > > v7: The v7 that was posted to the mailing list was incorrect. v8 is what > v7 was intended to be. > > v8: Inhibit out of context log message and needless processing by > adding 2 lines at the top of the new xen_igd_clear_slot function: > > if (!(pci_bus->slot_reserved_mask & XEN_PCI_IGD_SLOT_MASK)) > return; > > Rebase. This removed an unnecessary header file from xen_pt.h > > hw/i386/pc_piix.c | 3 +++ > hw/xen/xen_pt.c | 49 ++++++++++++++++++++++++++++++++++++-------- > hw/xen/xen_pt.h | 16 +++++++++++++++ > hw/xen/xen_pt_stub.c | 4 ++++ > 4 files changed, 63 insertions(+), 9 deletions(-) > > diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c > index b48047f50c..bc5efa4f59 100644 > --- a/hw/i386/pc_piix.c > +++ b/hw/i386/pc_piix.c > @@ -405,6 +405,9 @@ static void pc_xen_hvm_init(MachineState *machine) > } > > pc_xen_hvm_init_pci(machine); > + if (xen_igd_gfx_pt_enabled()) { > + xen_igd_reserve_slot(pcms->bus); > + } > pci_create_simple(pcms->bus, -1, "xen-platform"); > } > #endif I would even maybe go further and move the whole logic into xen_igd_reserve_slot. And I would even just name it xen_hvm_init_reserved_slots without worrying about the what or why at the pc level. At this point it will be up to Xen maintainers. > diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c > index 0ec7e52183..eff38155ef 100644 > --- a/hw/xen/xen_pt.c > +++ b/hw/xen/xen_pt.c > @@ -780,15 +780,6 @@ static void xen_pt_realize(PCIDevice *d, Error **errp) > s->hostaddr.bus, s->hostaddr.slot, s->hostaddr.function, > s->dev.devfn); > > - xen_host_pci_device_get(&s->real_device, > - s->hostaddr.domain, s->hostaddr.bus, > - s->hostaddr.slot, s->hostaddr.function, > - errp); > - if (*errp) { > - error_append_hint(errp, "Failed to \"open\" the real pci device"); > - return; > - } > - > s->is_virtfn = s->real_device.is_virtfn; > if (s->is_virtfn) { > XEN_PT_LOG(d, "%04x:%02x:%02x.%d is a SR-IOV Virtual Function\n", > @@ -950,11 +941,50 @@ static void xen_pci_passthrough_instance_init(Object *obj) > PCI_DEVICE(obj)->cap_present |= QEMU_PCI_CAP_EXPRESS; > } > > +void xen_igd_reserve_slot(PCIBus *pci_bus) > +{ > + XEN_PT_LOG(0, "Reserving PCI slot 2 for IGD\n"); > + pci_bus->slot_reserved_mask |= XEN_PCI_IGD_SLOT_MASK; > +} > + > +static void xen_igd_clear_slot(DeviceState *qdev, Error **errp) > +{ > + ERRP_GUARD(); > + PCIDevice *pci_dev = (PCIDevice *)qdev; > + XenPCIPassthroughState *s = XEN_PT_DEVICE(pci_dev); > + XenPTDeviceClass *xpdc = XEN_PT_DEVICE_GET_CLASS(s); > + PCIBus *pci_bus = pci_get_bus(pci_dev); > + > + if (!(pci_bus->slot_reserved_mask & XEN_PCI_IGD_SLOT_MASK)) > + return; > + > + xen_host_pci_device_get(&s->real_device, > + s->hostaddr.domain, s->hostaddr.bus, > + s->hostaddr.slot, s->hostaddr.function, > + errp); > + if (*errp) { > + error_append_hint(errp, "Failed to \"open\" the real pci device"); > + return; > + } > + > + if (is_igd_vga_passthrough(&s->real_device) && > + s->real_device.domain == 0 && s->real_device.bus == 0 && > + s->real_device.dev == 2 && s->real_device.func == 0 && > + s->real_device.vendor_id == PCI_VENDOR_ID_INTEL) { how about macros for these? #define XEN_PCI_IGD_DOMAIN 0 #define XEN_PCI_IGD_BUS 0 #define XEN_PCI_IGD_DEV 2 #define XEN_PCI_IGD_FN 0 > + pci_bus->slot_reserved_mask &= ~XEN_PCI_IGD_SLOT_MASK; If you are going to do this, you should set it back either after pci_qdev_realize or in unrealize, for symmetry. > + XEN_PT_LOG(pci_dev, "Intel IGD found, using slot 2\n"); > + } > + xpdc->pci_qdev_realize(qdev, errp); > +} > + > static void xen_pci_passthrough_class_init(ObjectClass *klass, void *data) > { > DeviceClass *dc = DEVICE_CLASS(klass); > PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); > > + XenPTDeviceClass *xpdc = XEN_PT_DEVICE_CLASS(klass); > + xpdc->pci_qdev_realize = dc->realize; > + dc->realize = xen_igd_clear_slot; > k->realize = xen_pt_realize; > k->exit = xen_pt_unregister_device; > k->config_read = xen_pt_pci_read_config; > @@ -977,6 +1007,7 @@ static const TypeInfo xen_pci_passthrough_info = { > .instance_size = sizeof(XenPCIPassthroughState), > .instance_finalize = xen_pci_passthrough_finalize, > .class_init = xen_pci_passthrough_class_init, > + .class_size = sizeof(XenPTDeviceClass), > .instance_init = xen_pci_passthrough_instance_init, > .interfaces = (InterfaceInfo[]) { > { INTERFACE_CONVENTIONAL_PCI_DEVICE }, > diff --git a/hw/xen/xen_pt.h b/hw/xen/xen_pt.h > index cf10fc7bbf..8c25932b4b 100644 > --- a/hw/xen/xen_pt.h > +++ b/hw/xen/xen_pt.h > @@ -2,6 +2,7 @@ > #define XEN_PT_H > > #include "hw/xen/xen_common.h" > +#include "hw/pci/pci_bus.h" > #include "xen-host-pci-device.h" > #include "qom/object.h" > > @@ -40,7 +41,20 @@ typedef struct XenPTReg XenPTReg; > #define TYPE_XEN_PT_DEVICE "xen-pci-passthrough" > OBJECT_DECLARE_SIMPLE_TYPE(XenPCIPassthroughState, XEN_PT_DEVICE) > > +#define XEN_PT_DEVICE_CLASS(klass) \ > + OBJECT_CLASS_CHECK(XenPTDeviceClass, klass, TYPE_XEN_PT_DEVICE) > +#define XEN_PT_DEVICE_GET_CLASS(obj) \ > + OBJECT_GET_CLASS(XenPTDeviceClass, obj, TYPE_XEN_PT_DEVICE) > + > +typedef void (*XenPTQdevRealize)(DeviceState *qdev, Error **errp); > + > +typedef struct XenPTDeviceClass { > + PCIDeviceClass parent_class; > + XenPTQdevRealize pci_qdev_realize; > +} XenPTDeviceClass; > + > uint32_t igd_read_opregion(XenPCIPassthroughState *s); > +void xen_igd_reserve_slot(PCIBus *pci_bus); > void igd_write_opregion(XenPCIPassthroughState *s, uint32_t val); > void xen_igd_passthrough_isa_bridge_create(XenPCIPassthroughState *s, > XenHostPCIDevice *dev); > @@ -75,6 +89,8 @@ typedef int (*xen_pt_conf_byte_read) > > #define XEN_PCI_INTEL_OPREGION 0xfc > > +#define XEN_PCI_IGD_SLOT_MASK 0x4UL /* Intel IGD slot_reserved_mask */ > + I think you want to calculate this based on dev fn: #define XEN_PCI_IGD_SLOT_MASK \ (0x1 << PCI_SLOT(PCI_DEVFN(XEN_PCI_IGD_DEV, XEN_PCI_IGD_FN))) > typedef enum { > XEN_PT_GRP_TYPE_HARDWIRED = 0, /* 0 Hardwired reg group */ > XEN_PT_GRP_TYPE_EMU, /* emul reg group */ > diff --git a/hw/xen/xen_pt_stub.c b/hw/xen/xen_pt_stub.c > index 2d8cac8d54..5c108446a8 100644 > --- a/hw/xen/xen_pt_stub.c > +++ b/hw/xen/xen_pt_stub.c > @@ -20,3 +20,7 @@ void xen_igd_gfx_pt_set(bool value, Error **errp) > error_setg(errp, "Xen PCI passthrough support not built in"); > } > } > + > +void xen_igd_reserve_slot(PCIBus *pci_bus) > +{ > +} > -- > 2.39.0 From xen-devel-bounces@lists.xenproject.org Tue Jan 10 08:18:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 08:18:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474401.735554 (Exim 4.92) (envelope-from ) id 1pF9pe-0008Iq-Ks; Tue, 10 Jan 2023 08:18:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474401.735554; Tue, 10 Jan 2023 08:18:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF9pe-0008Ih-Ht; Tue, 10 Jan 2023 08:18:06 +0000 Received: by outflank-mailman (input) for mailman id 474401; Tue, 10 Jan 2023 08:18:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF9pd-0008Ib-Ol for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 08:18:05 +0000 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [2a00:1450:4864:20::52b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4dc47d54-90bf-11ed-b8d0-410ff93cb8f0; Tue, 10 Jan 2023 09:18:03 +0100 (CET) Received: by mail-ed1-x52b.google.com with SMTP id j16so16328972edw.11 for ; Tue, 10 Jan 2023 00:18:03 -0800 (PST) Received: from 2a02.2378.1014.d6d9.ip.kyivstar.net ([2a02:2378:1014:d6d9:98bb:6889:a785:5d8c]) by smtp.gmail.com with ESMTPSA id b15-20020aa7c90f000000b004615f7495e0sm4644581edt.8.2023.01.10.00.18.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jan 2023 00:18:02 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4dc47d54-90bf-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=kFUxWJzeM2COHFWq5okhVHEx6N/a8Nas9W0hsl1vXtg=; b=LtU5mRIo0+RkUXzDAFazQKGaYSBgyYdirWMwYf++OGsu6ktHJ5LA54G8jnQUyl0fm/ gvqMwgFGGvlq8W+KSW8niC1TzQaNdAS9yM54cej+e1USn0Ak9u/Yl7f5mtNsx5UXWXGU 9dMfETLWzgWvQzH03FX7Mi9tz4ZjJZO8lJvO//njHgVTyuF55Wnvrhvc4aYQ181glSdj BpTzkJz4O9ILntSbe0u+zD0Hb6A3ajwmyM1ous8YKseyEc4s15ISxKa6Plivjl4x96rA 4n38vOWkd5YPwTfnlEne8jOV3Z28iylN+cbav/sjZ0ruj10jK21SzcsggRxUuxoKeCIX MSWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=kFUxWJzeM2COHFWq5okhVHEx6N/a8Nas9W0hsl1vXtg=; b=HJ7uu8hHWrZJ1Nu6haKeYExdQqDFGJOerHtZr2B5S7Sa2X5SyrW709ZX3eAw7m80HE qiYhLRXvhpuYQBV5xx568Tya0ObENYqjK4iXV1stSFu77C6brOraEBeIoncd6uLb3hgr Kh9W1mwA1sg/2YC1MUpYaka+3Nx8oZ8IOv/LU5/HAenZhpe6IHp1R02N1iqJt1igxxE3 g5YbBUEH/hkaL6w32s6doLorGc7Z2wH81Tr51izw/vy4jVBG1lfXGdVLU/eBFt8G31en vcwYZO7dW0qQH9rI39e1HM/BVWMJSmLSuxzNGZJdvByrmWK3vn9QmNhCvrsj9NZcZB20 fYxw== X-Gm-Message-State: AFqh2kpxxtGJmcyI+9sqE+oNAvZon2HVdSbY0BM3vQIBmlUvYCTC7YRk rZQMOAJ6QTtl2PeIG6HaW5o= X-Google-Smtp-Source: AMrXdXuePFplV6NusJbeKCkigvpa4LjqkET2uRLMDyYLyHVvu9nDOYGvB0NWxdXFBh2jLiZlkd5GxQ== X-Received: by 2002:a05:6402:e81:b0:48c:afae:9331 with SMTP id h1-20020a0564020e8100b0048cafae9331mr31101907eda.10.1673338683196; Tue, 10 Jan 2023 00:18:03 -0800 (PST) Message-ID: <474c92a9b26ba8a404db997e1646f1892fa857e0.camel@gmail.com> Subject: Re: [PATCH v2 4/8] xen/riscv: introduce sbi call to putchar to console From: Oleksii To: Jan Beulich Cc: Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org Date: Tue, 10 Jan 2023 10:18:01 +0200 In-Reply-To: References: <9b85a963db538e4735a9f99fc9090ad79508cb2c.1673278109.git.oleksii.kurochko@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.1 (3.46.1-1.fc37) MIME-Version: 1.0 On Mon, 2023-01-09 at 17:00 +0100, Jan Beulich wrote: > On 09.01.2023 16:46, Oleksii Kurochko wrote: > > --- /dev/null > > +++ b/xen/arch/riscv/include/asm/sbi.h > > @@ -0,0 +1,34 @@ > > +/* SPDX-License-Identifier: (GPL-2.0-or-later) */ > > +/* > > + * Copyright (c) 2021 Vates SAS. > > + * > > + * Taken from xvisor, modified by Bobby Eshleman > > (bobby.eshleman@gmail.com). > > + * > > + * Taken/modified from Xvisor project with the following > > copyright: > > + * > > + * Copyright (c) 2019 Western Digital Corporation or its > > affiliates. > > + */ > > + > > +#ifndef __CPU_SBI_H__ > > +#define __CPU_SBI_H__ >=20 > Didn't you mean to change this? Thanks. My fault. Missed that. I will double check that and take into account in new patch series. >=20 > > +#define SBI_EXT_0_1_CONSOLE_PUTCHAR=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A00x1 > > + > > +struct sbiret { > > +=C2=A0=C2=A0=C2=A0 long error; > > +=C2=A0=C2=A0=C2=A0 long value; > > +}; > > + > > +struct sbiret sbi_ecall(unsigned long ext, unsigned long fid, > > unsigned long arg0, > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unsigned long arg1, unsigne= d long arg2, > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unsigned long arg3, unsigne= d long arg4, > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unsigned long arg5); >=20 > Please get indentation right here as well as for the definition. Thanks for clarification. > Possible > forms are >=20 > struct sbiret sbi_ecall(unsigned long ext, unsigned long fid, > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unsigned= long arg0, unsigned long arg1, > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unsigned= long arg2, unsigned long arg3, > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unsigned= long arg4, unsigned long arg5); >=20 > or >=20 > struct sbiret sbi_ecall(unsigned long ext, unsigned long fid, > =C2=A0=C2=A0=C2=A0 unsigned long arg0, unsigned long arg1, > =C2=A0=C2=A0=C2=A0 unsigned long arg2, unsigned long arg3, > =C2=A0=C2=A0=C2=A0 unsigned long arg4, unsigned long arg5); >=20 > Jan From xen-devel-bounces@lists.xenproject.org Tue Jan 10 08:22:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 08:22:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474407.735565 (Exim 4.92) (envelope-from ) id 1pF9tS-0001JZ-5x; Tue, 10 Jan 2023 08:22:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474407.735565; Tue, 10 Jan 2023 08:22:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF9tS-0001JS-2c; Tue, 10 Jan 2023 08:22:02 +0000 Received: by outflank-mailman (input) for mailman id 474407; Tue, 10 Jan 2023 08:22:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pF9tR-0001JM-5b for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 08:22:01 +0000 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [2a00:1450:4864:20::52f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id daac699d-90bf-11ed-91b6-6bf2151ebd3b; Tue, 10 Jan 2023 09:22:00 +0100 (CET) Received: by mail-ed1-x52f.google.com with SMTP id v30so16348322edb.9 for ; Tue, 10 Jan 2023 00:22:00 -0800 (PST) Received: from 2a02.2378.1014.d6d9.ip.kyivstar.net ([2a02:2378:1014:d6d9:98bb:6889:a785:5d8c]) by smtp.gmail.com with ESMTPSA id en6-20020a056402528600b00499b3d09bd2sm2474641edb.91.2023.01.10.00.21.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jan 2023 00:21:59 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: daac699d-90bf-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=AprDi40x/B80KDuPx8u+X/GyU8Jo6blaRoC7zSOcKw4=; b=h5YpWVidwuM0qgPb2qCMupmtLX9SXIs+I2Nf9bvovkS390D6Y3AIQrUWJwonaxQC65 FOA26Ujm1yE91LWK+m6aU1cNLmm0gvags3JuDk1CTUkOs2heBbFNYpOFqhz3W92FBmPX 2MHz23+OUQ7rDgDRzw5a6MestAjubiEdatGdgXqNiqvrq1CldkJr8DV9LhjJ2ShIJRGk eFgWHtZ5n9OLWbuVlk+0GF+CK7yGhgJ4wDV27M7Ii96PbJWV06J/8nbw4nJU804Ns6OP /QBoOu8yNRyEBYsfRoFKzrSPNwLnFhp5J28U0MNg+NXygR1TIK3ULkITzsODQEK0k4Wk Kz9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=AprDi40x/B80KDuPx8u+X/GyU8Jo6blaRoC7zSOcKw4=; b=s/i7a5vxAF4QqdH2g9HK4UkqZplVWaQnQmMg2dcolGUbWqhH2LJmEWRUJ70zPrfnJd DyeSifx/zGoLp0XEe0wZPaQTi/nNt3054a3EkjroUq35rtJoAxOI3sTNQ/RKzZr5yrf3 tv828j4jDPatfO12hiShGHPbG7r/5/t6WRKyRBeFc5BlIpJoLEWuMqpRRCqKb5aE+MI+ 9KpElr1IKk/W5Ftz9h3yirbpBgq8C2DlKOeZyo/jh0uU/PVzfSsZYbfYF2JVaKFPd2fg bfCnoPw8QPNSptDQ63kY94ZUy1rykIRxq7U3uk8c0228RFmhobEZddViUMOtDIKqTr6q 5k4Q== X-Gm-Message-State: AFqh2kpmgl1Om7xTEDCT4ScGkYrMvFQsP9MyfcsaXHv5R3euO3aSx6dh ug1Zn0Fb+o9uiWZ45yYgpuw= X-Google-Smtp-Source: AMrXdXstGyqSI4HjuPwNOAdTiabyj0wqZZms2KkgU/NzSPCAxyYERHCUnD7LRVoAo0o49mb5WUtpWw== X-Received: by 2002:aa7:db8d:0:b0:45c:835c:3679 with SMTP id u13-20020aa7db8d000000b0045c835c3679mr58769549edt.2.1673338919802; Tue, 10 Jan 2023 00:21:59 -0800 (PST) Message-ID: Subject: Re: [PATCH v2 4/8] xen/riscv: introduce sbi call to putchar to console From: Oleksii To: Julien Grall , xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis Date: Tue, 10 Jan 2023 10:21:57 +0200 In-Reply-To: <7990322c-639b-38d4-ff6c-221988532c33@xen.org> References: <9b85a963db538e4735a9f99fc9090ad79508cb2c.1673278109.git.oleksii.kurochko@gmail.com> <7990322c-639b-38d4-ff6c-221988532c33@xen.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.1 (3.46.1-1.fc37) MIME-Version: 1.0 Hi, On Mon, 2023-01-09 at 16:03 +0000, Julien Grall wrote: > Hi, >=20 > On 09/01/2023 15:46, Oleksii Kurochko wrote: > > The patch introduce sbi_putchar() SBI call which is necessary > > to implement initial early_printk > >=20 > > Signed-off-by: Oleksii Kurochko > > --- > > Changes in V2: > > =C2=A0=C2=A0=C2=A0=C2=A0 - add an explanatory comment about sbi_console= _putchar() > > function. > > =C2=A0=C2=A0=C2=A0=C2=A0 - order the files alphabetically in Makefile > > --- > > =C2=A0 xen/arch/riscv/Makefile=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 |=C2=A0 1 + > > =C2=A0 xen/arch/riscv/include/asm/sbi.h | 34 ++++++++++++++++++++++++ > > =C2=A0 xen/arch/riscv/sbi.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 44 > > ++++++++++++++++++++++++++++++++ > > =C2=A0 3 files changed, 79 insertions(+) > > =C2=A0 create mode 100644 xen/arch/riscv/include/asm/sbi.h > > =C2=A0 create mode 100644 xen/arch/riscv/sbi.c > >=20 > > diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile > > index 5a67a3f493..fd916e1004 100644 > > --- a/xen/arch/riscv/Makefile > > +++ b/xen/arch/riscv/Makefile > > @@ -1,4 +1,5 @@ > > =C2=A0 obj-$(CONFIG_RISCV_64) +=3D riscv64/ > > +obj-y +=3D sbi.o > > =C2=A0 obj-y +=3D setup.o > > =C2=A0=20 > > =C2=A0 $(TARGET): $(TARGET)-syms > > diff --git a/xen/arch/riscv/include/asm/sbi.h > > b/xen/arch/riscv/include/asm/sbi.h > > new file mode 100644 > > index 0000000000..34b53f8eaf > > --- /dev/null > > +++ b/xen/arch/riscv/include/asm/sbi.h > > @@ -0,0 +1,34 @@ > > +/* SPDX-License-Identifier: (GPL-2.0-or-later) */ > > +/* > > + * Copyright (c) 2021 Vates SAS. > > + * > > + * Taken from xvisor, modified by Bobby Eshleman > > (bobby.eshleman@gmail.com). > Hmmm... I missed this one in v1. Is this mostly code from Bobby? If > so,=20 > please update the commit message accordingly. >=20 > FAOD, this comment applies for any future code you take from anyone. > I=20 > will try to remember to mention it but please take pro-active action > to=20 > check/mention where the code is coming from. >=20 Sure, I will try to be more attentive next time. Probably it is out of scope a little bit but could you please share with me a link or clarify in which cases I have to add Copytrigt(c) or should I add a new comment with "Modfied by Oleksii ... ", or it is not necessary at all? Maybe have I to put some other information related to copyrigts? Thanks in advance. > Cheers, >=20 ~Oleksii From xen-devel-bounces@lists.xenproject.org Tue Jan 10 08:29:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 08:29:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474414.735575 (Exim 4.92) (envelope-from ) id 1pFA0V-00023j-0F; Tue, 10 Jan 2023 08:29:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474414.735575; Tue, 10 Jan 2023 08:29:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFA0U-00023c-Tw; Tue, 10 Jan 2023 08:29:18 +0000 Received: by outflank-mailman (input) for mailman id 474414; Tue, 10 Jan 2023 08:29:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFA0T-00023U-Lz for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 08:29:17 +0000 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [2a00:1450:4864:20::632]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id de2bb332-90c0-11ed-b8d0-410ff93cb8f0; Tue, 10 Jan 2023 09:29:15 +0100 (CET) Received: by mail-ej1-x632.google.com with SMTP id cf18so20261186ejb.5 for ; Tue, 10 Jan 2023 00:29:15 -0800 (PST) Received: from 2a02.2378.1014.d6d9.ip.kyivstar.net ([2a02:2378:1014:d6d9:98bb:6889:a785:5d8c]) by smtp.gmail.com with ESMTPSA id y19-20020a1709060a9300b0084debc351b3sm1401014ejf.20.2023.01.10.00.29.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jan 2023 00:29:14 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: de2bb332-90c0-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=PbwEnvP28IXrNyfma1R9wMCLoHMIHS4QeFEg6V+6yGo=; b=HwwzIy2qZCXgfhG6Zms6XS2miKZBCfF+vA5UbZQe6jrpYzPELMhVCS2S9/5t/GSikF YNr8RWmA/SEfq6phnuEtsmczXXi6VG7qnnbRodVUYjiGO9OQOx3s64MA49Nua4P10vrc 3NZSdoGpebwIaMOiayIjProyULY4jlnBhEoEq5MbjhrzLrqiSd42fM720v5IG7paulZ3 4+3pIPtX8f9z/TpcVu0DYLelq2J9aKan5WgqgcKRLbO7UuUZ+yoivn8/PSy0wmcGTC9i Osq4chsk4lG8mK+MkFckl4cq2xcn/Gl21PBTCX5/rrLoJxTZbRqn1bV4C/DAfsCQQmav 9ykA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=PbwEnvP28IXrNyfma1R9wMCLoHMIHS4QeFEg6V+6yGo=; b=GqmyAfgxYxcWvhqbkw4dHDD+rYxV86vVUtCFfic1o7WHjesuSRZgjR10tZq9tQhRqN 5Gkgy3/fv4fCK4JcWaelDK1qkvJ7PqQZXSs58uPCPDybdxWVMmtHKRn4ZSZVljDSH6/v HkRCQ+t4zbT7hw7Z3+2StE/LEZpFaE228TV2RM17hoxr+6dlknQ/nNqQD9NfwxLGCp+y GcRjLcWgTEgkspw8NG8lbvyXYPsLjfYOT3gV5mHArM5GeGIUBDj3oTfW/F1Pn8uKwNgW VfOd/wIuKJz7ZKl8vwZEDeF+csSoWflCKE5FUr96rik3qj6kGqi7HExYSgtKPuJQILr5 FqFA== X-Gm-Message-State: AFqh2krRW2T/OdHRECHUg1STQc/AuqRTeYE0T/gL+3GVaR9E0cKgVZvW 6OhBG01k0wKmYtsM4hcBCU0= X-Google-Smtp-Source: AMrXdXscl0HAHCTAtCsYQF87Oc/mdzKLVYF1+arZzHCjbrD7bhBYyixaaxHPTwrSVEe7Qjngd4Fjag== X-Received: by 2002:a17:906:700f:b0:7c0:b79c:7d5f with SMTP id n15-20020a170906700f00b007c0b79c7d5fmr74184064ejj.68.1673339355096; Tue, 10 Jan 2023 00:29:15 -0800 (PST) Message-ID: <13d7161756f1eb4cd359f2fb7694eb398814235b.camel@gmail.com> Subject: Re: [PATCH v2 3/8] xen/riscv: introduce stack stuff From: Oleksii To: Julien Grall , xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis Date: Tue, 10 Jan 2023 10:29:13 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.1 (3.46.1-1.fc37) MIME-Version: 1.0 On Mon, 2023-01-09 at 16:11 +0000, Julien Grall wrote: > Hi, >=20 > On 09/01/2023 15:46, Oleksii Kurochko wrote: > > The patch introduces and sets up a stack in order to go to C > > environment > >=20 > > Signed-off-by: Oleksii Kurochko >=20 > It looks like the comments from Andrew were missed. >=20 I will double check which one. Thanks. > > --- > > Changes in V2: > > =C2=A0=C2=A0=C2=A0=C2=A0 - introduce STACK_SIZE define. > > =C2=A0=C2=A0=C2=A0=C2=A0 - use consistent padding between instruction m= nemonic and > > operand(s) > > --- > > =C2=A0 xen/arch/riscv/Makefile=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 1 + > > =C2=A0 xen/arch/riscv/include/asm/config.h | 2 ++ > > =C2=A0 xen/arch/riscv/riscv64/head.S=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 | 8 +++++++- > > =C2=A0 xen/arch/riscv/setup.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 6 ++++++ > > =C2=A0 4 files changed, 16 insertions(+), 1 deletion(-) > > =C2=A0 create mode 100644 xen/arch/riscv/setup.c > >=20 > > diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile > > index 248f2cbb3e..5a67a3f493 100644 > > --- a/xen/arch/riscv/Makefile > > +++ b/xen/arch/riscv/Makefile > > @@ -1,4 +1,5 @@ > > =C2=A0 obj-$(CONFIG_RISCV_64) +=3D riscv64/ > > +obj-y +=3D setup.o > > =C2=A0=20 > > =C2=A0 $(TARGET): $(TARGET)-syms > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0$(OBJCOPY) -O binary -S= $< $@ > > diff --git a/xen/arch/riscv/include/asm/config.h > > b/xen/arch/riscv/include/asm/config.h > > index 0370f865f3..bdd2237f01 100644 > > --- a/xen/arch/riscv/include/asm/config.h > > +++ b/xen/arch/riscv/include/asm/config.h > > @@ -43,6 +43,8 @@ > > =C2=A0=20 > > =C2=A0 #define SMP_CACHE_BYTES (1 << 6) > > =C2=A0=20 > > +#define STACK_SIZE (PAGE_SIZE) > > + > > =C2=A0 #endif /* __RISCV_CONFIG_H__ */ > > =C2=A0 /* > > =C2=A0=C2=A0 * Local variables: > > diff --git a/xen/arch/riscv/riscv64/head.S > > b/xen/arch/riscv/riscv64/head.S > > index 990edb70a0..c1f33a1934 100644 > > --- a/xen/arch/riscv/riscv64/head.S > > +++ b/xen/arch/riscv/riscv64/head.S > > @@ -1,4 +1,10 @@ > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 .section .text.h= eader, "ax", %progbits > > =C2=A0=20 > > =C2=A0 ENTRY(start) > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 j=C2=A0 start > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 la=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 sp, cpu0_boot_stack > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 li=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 t0, STACK_SIZE > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 add=C2=A0=C2=A0=C2=A0=C2=A0= sp, sp, t0 > > + > > +_start_hang: > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 wfi > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 j=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 _start_hang > > diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c > > new file mode 100644 > > index 0000000000..41ef4912bd > > --- /dev/null > > +++ b/xen/arch/riscv/setup.c > > @@ -0,0 +1,6 @@ > > +#include > > +#include >=20 > Why do you need to include ? >=20 It is needed to use __aligned define which looks better then __attribute__((__aligned__(SOMETHING)))=20 > In any case, please order the include alphabetically. I haven't look > at=20 Thanks. I didn't now that headers should be in alphabetic order too. > the rest of the series. But please go through the series and check > that=20 > generic comments (like this one) are addressed everywhere. >=20 > Cheers, >=20 ~Oleksii From xen-devel-bounces@lists.xenproject.org Tue Jan 10 08:53:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 08:53:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474420.735587 (Exim 4.92) (envelope-from ) id 1pFANf-0005Kv-TG; Tue, 10 Jan 2023 08:53:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474420.735587; Tue, 10 Jan 2023 08:53:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFANf-0005Kh-Pk; Tue, 10 Jan 2023 08:53:15 +0000 Received: by outflank-mailman (input) for mailman id 474420; Tue, 10 Jan 2023 08:53:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFANd-0005KI-K4; Tue, 10 Jan 2023 08:53:13 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFANd-0000jv-IQ; Tue, 10 Jan 2023 08:53:13 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFANd-0007aC-BQ; Tue, 10 Jan 2023 08:53:13 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pFANd-0007s9-B1; Tue, 10 Jan 2023 08:53:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=hvMd7o/GEpMrztcOZ57Yr3bQ4vz6nPLHEKgbykUzC+8=; b=GKCiIGZmGY5+yKFGlroQBriXwa CaBuHfDuqB8SbQduIlb3lYd7VT17ZMeEo6I8E0odooUJT9Qu7Cg1x0R2EjuMm0Y96gL7KkM6wUnFP 5EI4rNXV2ksQ2IxeIU+08prxWQ2c0UsHZF10rBhcPiqGjHC95g5BbLsY7v7ruUsWLllE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 175686: all pass - PUSHED X-Osstest-Versions-This: ovmf=82dd766f25225b0812bbac628c60d2b48f2346e4 X-Osstest-Versions-That: ovmf=2cc6d4c8ed54e36fd9638dafdb293dd9a4c54cf9 From: osstest service owner Date: Tue, 10 Jan 2023 08:53:13 +0000 flight 175686 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/175686/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 82dd766f25225b0812bbac628c60d2b48f2346e4 baseline version: ovmf 2cc6d4c8ed54e36fd9638dafdb293dd9a4c54cf9 Last test of basis 175683 2023-01-10 04:10:46 Z 0 days Testing same since 175686 2023-01-10 06:40:46 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Chao Li jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 2cc6d4c8ed..82dd766f25 82dd766f25225b0812bbac628c60d2b48f2346e4 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue Jan 10 08:54:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 08:54:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474427.735598 (Exim 4.92) (envelope-from ) id 1pFAOQ-0005sR-5b; Tue, 10 Jan 2023 08:54:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474427.735598; Tue, 10 Jan 2023 08:54:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFAOQ-0005sK-2l; Tue, 10 Jan 2023 08:54:02 +0000 Received: by outflank-mailman (input) for mailman id 474427; Tue, 10 Jan 2023 08:54:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFAOO-0005s6-0z for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 08:54:00 +0000 Received: from EUR03-VI1-obe.outbound.protection.outlook.com (mail-vi1eur03on2064.outbound.protection.outlook.com [40.107.103.64]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 512b99b4-90c4-11ed-91b6-6bf2151ebd3b; Tue, 10 Jan 2023 09:53:57 +0100 (CET) Received: from ZR2P278CA0062.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:52::10) by AS4PR08MB7902.eurprd08.prod.outlook.com (2603:10a6:20b:51d::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 08:53:54 +0000 Received: from VI1EUR03FT043.eop-EUR03.prod.protection.outlook.com (2603:10a6:910:52:cafe::c8) by ZR2P278CA0062.outlook.office365.com (2603:10a6:910:52::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:53:54 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT043.mail.protection.outlook.com (100.127.145.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:53:53 +0000 Received: ("Tessian outbound 3ad958cd7492:v132"); Tue, 10 Jan 2023 08:53:53 +0000 Received: from 08576f30d8c9.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 84897C40-18DE-4F73-9AF2-423B309F9F89.1; Tue, 10 Jan 2023 08:53:46 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 08576f30d8c9.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 10 Jan 2023 08:53:46 +0000 Received: from AS4PR09CA0005.eurprd09.prod.outlook.com (2603:10a6:20b:5e0::11) by DB9PR08MB7469.eurprd08.prod.outlook.com (2603:10a6:10:36f::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 08:53:43 +0000 Received: from VI1EUR03FT058.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:5e0:cafe::b8) by AS4PR09CA0005.outlook.office365.com (2603:10a6:20b:5e0::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:53:43 +0000 Received: from nebula.arm.com (40.67.248.234) by VI1EUR03FT058.mail.protection.outlook.com (100.127.144.186) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:53:42 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 10 Jan 2023 08:53:40 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.16 via Frontend Transport; Tue, 10 Jan 2023 08:53:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 512b99b4-90c4-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4WSflx/hlaylWKbeI/bAsqdI9Oj43SHHqevu0JMLugA=; b=FBeAWyPCV9uxh7Sjl1M/oQYLVvmiGjnPnoncypDlejGUmST244mgA6KpPhj/VjrvTkK/lcI3RnsufxOZsmmrGh84EGlQznv5PuA8AyGwoWUUp9ezkSvJdNlO2c6K8kaPav6A+AmVZ5961xUcVT590JEKkX7bYUFr+vgvey7RX+8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 4eea29087c37b2c3 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GGHgxSMrI9u7eYO32RDvDSlUvQmV2l+0scFQJgc1mUF3K+D4vpoO9RByzYFyfoCk5bgWl3z/msz/gYTXJyVjvI+O56wxhpkHyN8HvU1uPUTeupiPquiH7pWXSV7bPcadaek6qiw4UlI2mtT3srLGZUDY/jYZx2sjU77g1FmPEaKP3IxSHNWe+/28h4SzrxFKVp3ZtCG1403Wx78I452LB0Fqw06CssLu4oMLqwif1OqRyOnAFMacfP2BSNY2qy5SivKabuHzqdSS8mEaq7XjmFebLNLPQYmKAG8/DsMu12/ZXobkJmyrvkEc5lIf9TGTOFUEn4yGqErxawTS/7kUEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4WSflx/hlaylWKbeI/bAsqdI9Oj43SHHqevu0JMLugA=; b=b70iTjx9mgONZMx1/HZUUnNZ8mubxSRDoAaBDRY7aaGGPmkXSSGJHeMAgvzxK9NupRo7PjtIUXlB9RPVhc3/yVKErJIpO78BHSGdWOasbAS0PNjBGG9tWzsk7pAIFKcQrZOwRq8GfmtTxwwnwhDYIlT2t2f1iD1RXr9j13vgjcoTN5RYfsjJBlpq00awh3uzJQqGdgDtDpXgWPUWmpBp6ZKXwatHwiG8mEeAzsGKQ0O8+UsINRpCeAE6qySmHO9jBIneKmE2FWPcg3ad4mip6lN6WRWKFi79d0rpXerxu4VlLrPvJnK2qLhki6XputnbI1puBWnIEHM4b/FeNH3RwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4WSflx/hlaylWKbeI/bAsqdI9Oj43SHHqevu0JMLugA=; b=FBeAWyPCV9uxh7Sjl1M/oQYLVvmiGjnPnoncypDlejGUmST244mgA6KpPhj/VjrvTkK/lcI3RnsufxOZsmmrGh84EGlQznv5PuA8AyGwoWUUp9ezkSvJdNlO2c6K8kaPav6A+AmVZ5961xUcVT590JEKkX7bYUFr+vgvey7RX+8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v2 00/17] Device tree based NUMA support for Arm - Part#3 Date: Tue, 10 Jan 2023 16:49:13 +0800 Message-ID: <20230110084930.1095203-1-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: VI1EUR03FT058:EE_|DB9PR08MB7469:EE_|VI1EUR03FT043:EE_|AS4PR08MB7902:EE_ X-MS-Office365-Filtering-Correlation-Id: 7f8555fd-9467-4ee2-b15b-08daf2e833bc x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 9svjhQ5Sr68UXSLb6JGH3nUC5D4jhvyepAmsNbz8rti37G54FUbtxAvXYy2Z3bFqSfunZRKSQ7QQVarB9YTXTkoavV3po/qTNSOhOcac0XOuCUSfuGQf8VuVxTdDt7KEMqhrt0Y3ITpVCBtY7+jw0XJnivRSCvFK/PCDoQnO9rPmZ3IFuDnxYBz5KGHrVlzQGTlJT9Xyg3CZKLsVnfn+94olskiW1uOZNaqrtqJ+MwCn/bai25M4jGvePVCT+9xTFFhvC1xSwaYxlE1bra57eAnUJ/ptdK6692sNWNddPqRTyKRm8cFppf3yjxuHAjr/PXIeVOrfDLEvVqKtip/JUDweLCaauZEEs2RNfkDiGDefERzEHckXzproJO5fbxP6ps2jDUQMxXboM1mb/jBXUwvbTF1Vcr1tGEKZMfAIf07q9XPjW7Fnrur3qcBo01q4Uo7VOwarxk/u76WPAXVyqsYaA067TyCrFdZgD2QNo6vjxGaLUsPY3jGbpvtFd69HAeMEPAqnjwP8OEI8vIS15auYYyq8QTY6IoEVRKUhwGJzkuJQQrw+ujLLIqX1Ej5xOrrjg2qemquXTs2L6CzM2e9xQChDY7bHW4zhDPbDXybahzppaO4e5ReYZ9E+wGpTAapOMP2E7Nbx4ZaxuLVeBL2bBXlAd/xYmspRn0gQhvSeN0kTHIRcjm1+cS0e+BHh/8gcHfzqU0xXaqXJtAqudphP6MIJXPNAna5OwpwRMNb/kaX2hVqKY+XNYK43ntCQLklYyLI73F6oNFGpbj9Drg== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(376002)(346002)(39860400002)(451199015)(36840700001)(46966006)(36756003)(86362001)(40480700001)(316002)(54906003)(6916009)(478600001)(82740400003)(356005)(81166007)(2616005)(6666004)(1076003)(966005)(186003)(26005)(82310400005)(7696005)(8676002)(70586007)(4326008)(8936002)(70206006)(41300700001)(5660300002)(2906002)(44832011)(36860700001)(336012)(47076005)(83380400001)(426003)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7469 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 7aac53ca-4b2a-45bd-7845-08daf2e82cf1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7Zlvd+WWdPiUT4wY8UiD9taF81l/UArfvLrY1AHJnGTyOaBglRNsxSmi6FyEePCQZu3RDxso4rnGSeBKfe+tZtYUJ9yqnQ0sfbW8ObMUY6L6dv/u2kuKug/fxk9GLJrgCyk6leOt22ZJ0N8enOabnN8pHR87UfmNkXDkj861sNnpldC/3iTqkkPj9rbZ/9aLTa4OpX1nv8GH41F8B2naRrMTmMoQZV6nQd6TlFBA8mWTGCuE6cMaVlie6rkCtQc3cwuUB19Ierd9SXim6n3O8yNgZA4+nVAfqQnT1B4GBygu9by9pMJMw9h6h1IK7l32U532C4wZsq6hYf8QjvQeIoh8O8zFfQn6xKFcVJgitB25KCa5q2jJ+rDM1KnH4Fi1g9qPytsW1clF//y2J9YcTWenbfTWDdLPUiu4ZxoAb+OR4JSySOQdAfmyvFowjyJGJUUSXz1U5lprvbm92pLOfiyk3yMiyUC8oIEo2XK4n49Ho2+7huc1L3hm6BvzhYzD1yNTDTyo0RQPUTCRrHjUOLqKjmSt7dfKYvUFbknRuYFqDSHs6o0gtM0qREr3udSr/iBjMf8oUZFbXYIcJP/iBZoF1Q/x0ljpEcs7gpfvOumCiXtJmVPNXJyw1UJ+IzreTzPvD8Z5vCJfJp4kFXjxPV2EpEbejd/ZE4SCToAJNvVJEHZnJUio280LauSJPOwVnV6XxqUMZD9y7U1uOt9DkI6z1lA+OmBC77uI8bEcEA3zssjrI1rHGcpJu+mRhiFmmKKlmAnuYtzamx9k4ZEy3A== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(136003)(346002)(396003)(451199015)(36840700001)(40470700004)(46966006)(70586007)(70206006)(8676002)(336012)(4326008)(186003)(82310400005)(83380400001)(41300700001)(426003)(2906002)(47076005)(82740400003)(36860700001)(36756003)(44832011)(81166007)(5660300002)(40460700003)(8936002)(966005)(478600001)(6666004)(107886003)(2616005)(26005)(1076003)(6916009)(316002)(54906003)(40480700001)(86362001)(7696005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2023 08:53:53.9747 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7f8555fd-9467-4ee2-b15b-08daf2e833bc X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB7902 (The Arm device tree based NUMA support patch set contains 35 patches. In order to make stuff easier for reviewers, I split them into 3 parts: 1. Preparation. I have re-sorted the patch series. And moved independent patches to the head of the series - merged in [1] 2. Move generically usable code from x86 to common - merged in [2] 3. Add new code to support Arm - this series. This series only contains the third part patches. As the whole NUMA series has been reviewed for 1 round in [3], so this series would be v2) Xen memory allocation and scheduler modules are NUMA aware. But actually, on x86 has implemented the architecture APIs to support NUMA. Arm was providing a set of fake architecture APIs to make it compatible with NUMA awared memory allocation and scheduler. Arm system was working well as a single node NUMA system with these fake APIs, because we didn't have multiple nodes NUMA system on Arm. But in recent years, more and more Arm devices support multiple nodes NUMA system. So now we have a new problem. When Xen is running on these Arm devices, Xen still treat them as single node SMP systems. The NUMA affinity capability of Xen memory allocation and scheduler becomes meaningless. Because they rely on input data that does not reflect real NUMA layout. Xen still think the access time for all of the memory is the same for all CPUs. However, Xen may allocate memory to a VM from different NUMA nodes with different access speeds. This difference can be amplified in workloads inside VM, causing performance instability and timeouts. So in this patch series, we implement a set of NUMA API to use device tree to describe the NUMA layout. We reuse most of the code of x86 NUMA to create and maintain the mapping between memory and CPU, create the matrix between any two NUMA nodes. Except ACPI and some x86 specified code, we have moved other code to common. In next stage, when we implement ACPI based NUMA for Arm64, we may move the ACPI NUMA code to common too, but in current stage, we keep it as x86 only. This patch serires has been tested and booted well on one Arm64 NUMA machine and one HPE x86 NUMA machine. [1] https://lists.xenproject.org/archives/html/xen-devel/2022-06/msg00499.html [2] https://lists.xenproject.org/archives/html/xen-devel/2022-11/msg01043.html [3] https://lists.xenproject.org/archives/html/xen-devel/2021-09/msg01903.html Henry Wang (1): xen/arm: Set correct per-cpu cpu_core_mask Wei Chen (16): xen/arm: use NR_MEM_BANKS to override default NR_NODE_MEMBLKS xen/arm: implement helpers to get and update NUMA status xen/arm: implement node distance helpers for Arm xen/arm: use arch_get_ram_range to memory ranges from bootinfo xen/arm: build NUMA cpu_to_node map in dt_smp_init_cpus xen/arm: Add boot and secondary CPU to NUMA system xen/arm: introduce a helper to parse device tree processor node xen/arm: introduce a helper to parse device tree memory node xen/arm: introduce a helper to parse device tree NUMA distance map xen/arm: unified entry to parse all NUMA data from device tree xen/arm: keep guest still be NUMA unware xen/arm: enable device tree based NUMA in system init xen/arm: implement numa_node_to_arch_nid for device tree NUMA xen/arm: use CONFIG_NUMA to gate node_online_map in smpboot xen/arm: Provide Kconfig options for Arm to enable NUMA docs: update numa command line to support Arm SUPPORT.md | 1 + docs/misc/xen-command-line.pandoc | 2 +- xen/arch/arm/Kconfig | 11 ++ xen/arch/arm/Makefile | 2 + xen/arch/arm/domain_build.c | 6 + xen/arch/arm/include/asm/numa.h | 87 ++++++++- xen/arch/arm/numa.c | 183 +++++++++++++++++++ xen/arch/arm/numa_device_tree.c | 290 ++++++++++++++++++++++++++++++ xen/arch/arm/setup.c | 17 ++ xen/arch/arm/smpboot.c | 38 ++++ xen/arch/x86/include/asm/numa.h | 2 - xen/arch/x86/srat.c | 2 +- xen/include/xen/numa.h | 11 ++ 13 files changed, 647 insertions(+), 5 deletions(-) create mode 100644 xen/arch/arm/numa.c create mode 100644 xen/arch/arm/numa_device_tree.c -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Jan 10 08:54:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 08:54:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474429.735609 (Exim 4.92) (envelope-from ) id 1pFAOX-0006AO-E2; Tue, 10 Jan 2023 08:54:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474429.735609; Tue, 10 Jan 2023 08:54:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFAOX-0006AD-As; Tue, 10 Jan 2023 08:54:09 +0000 Received: by outflank-mailman (input) for mailman id 474429; Tue, 10 Jan 2023 08:54:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFAOW-0005s6-8W for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 08:54:08 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2054.outbound.protection.outlook.com [40.107.22.54]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 577127da-90c4-11ed-91b6-6bf2151ebd3b; Tue, 10 Jan 2023 09:54:07 +0100 (CET) Received: from AS8PR07CA0035.eurprd07.prod.outlook.com (2603:10a6:20b:459::27) by AS4PR08MB7687.eurprd08.prod.outlook.com (2603:10a6:20b:506::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 08:54:05 +0000 Received: from AM7EUR03FT009.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:459:cafe::2c) by AS8PR07CA0035.outlook.office365.com (2603:10a6:20b:459::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.12 via Frontend Transport; Tue, 10 Jan 2023 08:54:05 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT009.mail.protection.outlook.com (100.127.140.130) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:54:05 +0000 Received: ("Tessian outbound 8038f0863a52:v132"); Tue, 10 Jan 2023 08:54:05 +0000 Received: from 1a530aeacf9f.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E72D6A2F-6BE3-4CAD-BE82-F07CD82351F6.1; Tue, 10 Jan 2023 08:53:58 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1a530aeacf9f.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 10 Jan 2023 08:53:58 +0000 Received: from AS9PR05CA0329.eurprd05.prod.outlook.com (2603:10a6:20b:491::35) by PA4PR08MB7572.eurprd08.prod.outlook.com (2603:10a6:102:271::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 08:53:57 +0000 Received: from AM7EUR03FT031.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:491:cafe::6e) by AS9PR05CA0329.outlook.office365.com (2603:10a6:20b:491::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:53:57 +0000 Received: from nebula.arm.com (40.67.248.234) by AM7EUR03FT031.mail.protection.outlook.com (100.127.140.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:53:56 +0000 Received: from AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 10 Jan 2023 08:53:56 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 10 Jan 2023 08:53:55 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.16 via Frontend Transport; Tue, 10 Jan 2023 08:53:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 577127da-90c4-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ukOHSyYJNGo1PvmsWwUlZnhKUtTLLuyk3pl7Z1kqbYk=; b=IQfayMYuPhAh9yCaVERhL4zea685Z/8WMvbuqmwEdwVpuGd3xSOYqqDfJ0QZKaXrmspo2Ik3eDSAOuKhtOJoUkhYVD5q98QbRmJLz17wzMNkusDnMfdsZGS9IWSpQq2H+WO7ANTOTBBcLuTPtCw/qEbfrgT5q7qPpY2PxbnMbg0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 8e0d06204b1326e9 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k49p0Ga7YSHbcTaLM2Yf/9a9ZP59cMtgjQBkE/WVtAwtE6NDu9XURdL5qrg5bD8UW78p6fcIbG59CItouubUY0kmPxs0YzEnCmYGas70O16RrdilfYOjNVLWCiqkMm8J0lzMZkN8JXc4GYCHgA6mVZucgnigC2pArN4eqQpEJNnhFkU5jgHeJxZDLwaXm77S9y8L4kX5YMaLntwieu/WBLnTKxSPcUJMzlkpqivGZOIUFkPvowpcIXk3PjpVJMUB8gseDMtMC30Yngbb3B1++NpgF+iMd9TYzd3cjZCQuX1Z13m0w5JbiVNZgEHALyKPKoeqTt8hAgdzYL0KNtFJmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ukOHSyYJNGo1PvmsWwUlZnhKUtTLLuyk3pl7Z1kqbYk=; b=K7UlsP3WRXewE0HeGJh5m024Fc5+fKKtRzVbukGfy7iG4POxJJhgmuuA6tgkq5mY+odNsSXRoDc7/eORIwWftKFT3PlzNp2eUsD3j7IBLoy7QDkDKvurZSw/ftNi66BziT1NU0Hzx21yRXXllUrsSHAHrfJPzfoEKNm6Lj/Djvr3ohwAxoiTEWhWyWR0ivRvFLsfwS8f+noK23b4X11BXyFjSjTb9BEkAiJ4fpWejf+DamYUCOIX2j4Wk+SK93e/MEnDYpoeQUo/EFhBkVJOy1H+apMnbEqx5vuh2NcTpWu2iVTQrwtmc31bVBjlAu5WEPnRcuXJVZ5Cts6xaR5zDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ukOHSyYJNGo1PvmsWwUlZnhKUtTLLuyk3pl7Z1kqbYk=; b=IQfayMYuPhAh9yCaVERhL4zea685Z/8WMvbuqmwEdwVpuGd3xSOYqqDfJ0QZKaXrmspo2Ik3eDSAOuKhtOJoUkhYVD5q98QbRmJLz17wzMNkusDnMfdsZGS9IWSpQq2H+WO7ANTOTBBcLuTPtCw/qEbfrgT5q7qPpY2PxbnMbg0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v2 04/17] xen/arm: use arch_get_ram_range to memory ranges from bootinfo Date: Tue, 10 Jan 2023 16:49:17 +0800 Message-ID: <20230110084930.1095203-5-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230110084930.1095203-1-wei.chen@arm.com> References: <20230110084930.1095203-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: AM7EUR03FT031:EE_|PA4PR08MB7572:EE_|AM7EUR03FT009:EE_|AS4PR08MB7687:EE_ X-MS-Office365-Filtering-Correlation-Id: b38d74bf-f550-4b63-7f18-08daf2e83a9a x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 8qWH3Cdk6TooUHnWV6bBmMqkiv8YlWmA95yuq/P/7tr80IVpC33v1tU3OEGP/5k9QMS/p20oGjydcTymTScaaPE2ucdSZTq63pAe2W9F2EpLgXjXiz1FLLytfl/+Ekjn2A+WyHQiiBVeuvfC15zoh6ROuDg2ldcokeoeeYfjlRssS6mb1K6pewsHBTJBm+LQq36szooRGhqVAW1xqSN3hQIXhRckRWWsv2ZbmrSSY81XLYb/9lxciIRoGweteF3VM23a8OwblX3sCyWzSCQOo+Ms4fdGrwXclVflGt9HrjTEhSixh2R5vvm8L5E8lzHhYGQNmqggty7ivZ5Kv90HwhLCK/AqSvjCM0q2DbCk8NNtWYBbQaWMNE+xbLO2Flofu30lyQKL66QE4QYFART+mmjO8ynL9lxcbAntix0IxFsa+dLPvoXs5ka2YH8Q1a9eqickxuJuQhfYaLVl5NKosOrjifNfViehb3NDdQQNsPcHg56YVdJ40ZF9Tf3d9HAT9l1fd7Vds7gmAMUliUuA+EMrrKZhGP7N6SwsU6E6SAbc8++EAIRKhlMkOLVtWKSllzKjcOC+p6xAs3vTa1+A/wgNuiNQCQR5uODPtPn9uxxpR6w77cTIUVbQmDM6RfXlbltga6846yFqzBRYQqBAcyQX+BOLBX8GrtNnCZEt6aWeRkQFzNgAWRVzR9giCxF4MbEMIFDrkV1LbYKd/PpXqA== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(396003)(136003)(346002)(451199015)(46966006)(36840700001)(83380400001)(36860700001)(41300700001)(70586007)(8676002)(70206006)(4326008)(5660300002)(4744005)(8936002)(36756003)(26005)(2616005)(186003)(54906003)(1076003)(81166007)(478600001)(7696005)(356005)(47076005)(86362001)(6666004)(82740400003)(82310400005)(40480700001)(6916009)(336012)(316002)(426003)(44832011)(2906002)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB7572 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT009.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ae21e75f-961f-4e03-646b-08daf2e83555 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xVon1AF4OQ+FXef+6denCz3kTho9IgTteDaY9XB8cmZvWT/3Ep6ZrNsnDLY/zAxxmc7bo4P32Y/jzDE609bcqRd+Eo5xlmmMaD7eYCEgrtT9avQiuqynDz/tZPo54FrNLhLrOhxCNqw9qfvel3Pc33DRLlXfP/JLuOMIojtoRiWnkfviHbV9ReMA9GNUVEo9FuuDkTeGh1jIVbq1NaCXr1jrT0JjE3TFQ1nKx4DaJpvN4Wm8iboXiyQVL7HahssI5XjlWGDLzRWPQZUWVdIvlR43zLIHjoeejBxNG+jVSdAKSa4L2VM7zES4keCouwbya4WhOvAwJsLmXLoxrXYOufzB9fk/RMZTsmaNwfR7znKol+hen1tDpe3dko1lp+emClDAea3nKHWm7+O1ECmQO7zh9Afv5/dORSAzjGpjncANXw2GcjGn2wheMyC/oJqRDWwMC23TbH7yyJD4hYHkcM7qH1HXusNdR/y2FmWC+PZa0TiBDyv37J1HRiIGHEKGWIpfzePFgz8rCzciON6kpqsT3SLkvPe5z1KdxHlI+Gn2s6fpx2kvAyj14G4HqVIqLRlFSAj89vV4BeeyWMvqvMhHcfAvnwwgNh342n/LFMcSOFrwuWdJw5HJUSCq9wpsEbvSr1M3PYGTPbzgxRLMGkQyNEzYfXF0H4XG+4kDIfc+WAZdkM/RyyzH2OLg1H3op2Hrw8xFs2ipfmwmhXQ03Q== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(39860400002)(346002)(376002)(451199015)(40470700004)(36840700001)(46966006)(2906002)(36860700001)(44832011)(5660300002)(4744005)(7696005)(41300700001)(8936002)(36756003)(4326008)(83380400001)(70206006)(70586007)(8676002)(40460700003)(86362001)(47076005)(82310400005)(1076003)(336012)(2616005)(6916009)(426003)(26005)(81166007)(40480700001)(478600001)(186003)(82740400003)(316002)(6666004)(107886003)(54906003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2023 08:54:05.5259 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b38d74bf-f550-4b63-7f18-08daf2e83a9a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT009.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB7687 Implement the same helper "arch_get_ram_range" as x86 for NUMA code to get memory bank from Arm bootinfo. Signed-off-by: Wei Chen --- v2 -> v3: 1. Use arch_get_ram_range instead of arch_get_memory_map. v1 -> v2: 1. Use arch_get_memory_map to replace arch_get_memory_bank_range and arch_get_memory_bank_number. --- xen/arch/arm/numa.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/xen/arch/arm/numa.c b/xen/arch/arm/numa.c index 34851ceacf..dcfcd85fcf 100644 --- a/xen/arch/arm/numa.c +++ b/xen/arch/arm/numa.c @@ -92,3 +92,14 @@ unsigned char __node_distance(nodeid_t from, nodeid_t to) } EXPORT_SYMBOL(__node_distance); + +int __init arch_get_ram_range(unsigned int idx, paddr_t *start, paddr_t *end) +{ + if ( idx >= bootinfo.mem.nr_banks ) + return -ENOENT; + + *start = bootinfo.mem.bank[idx].start; + *end = *start + bootinfo.mem.bank[idx].size; + + return 0; +} -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Jan 10 08:54:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 08:54:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474430.735620 (Exim 4.92) (envelope-from ) id 1pFAOY-0006Qg-Q4; Tue, 10 Jan 2023 08:54:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474430.735620; Tue, 10 Jan 2023 08:54:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFAOY-0006QV-N9; Tue, 10 Jan 2023 08:54:10 +0000 Received: by outflank-mailman (input) for mailman id 474430; Tue, 10 Jan 2023 08:54:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFAOX-0005s6-5v for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 08:54:09 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2061.outbound.protection.outlook.com [40.107.249.61]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 57c40165-90c4-11ed-91b6-6bf2151ebd3b; Tue, 10 Jan 2023 09:54:08 +0100 (CET) Received: from AS9PR01CA0020.eurprd01.prod.exchangelabs.com (2603:10a6:20b:540::25) by PAXPR08MB7646.eurprd08.prod.outlook.com (2603:10a6:102:241::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 08:54:05 +0000 Received: from AM7EUR03FT008.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:540:cafe::e4) by AS9PR01CA0020.outlook.office365.com (2603:10a6:20b:540::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:54:05 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT008.mail.protection.outlook.com (100.127.141.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:54:05 +0000 Received: ("Tessian outbound 333ca28169fa:v132"); Tue, 10 Jan 2023 08:54:04 +0000 Received: from cd1a513c34a0.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 736A2ED2-55B1-41D7-A47A-6BC14235A46A.1; Tue, 10 Jan 2023 08:53:57 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cd1a513c34a0.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 10 Jan 2023 08:53:57 +0000 Received: from FR0P281CA0063.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::11) by AS8PR08MB9315.eurprd08.prod.outlook.com (2603:10a6:20b:5a6::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 08:53:51 +0000 Received: from VI1EUR03FT014.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:49:cafe::73) by FR0P281CA0063.outlook.office365.com (2603:10a6:d10:49::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.11 via Frontend Transport; Tue, 10 Jan 2023 08:53:50 +0000 Received: from nebula.arm.com (40.67.248.234) by VI1EUR03FT014.mail.protection.outlook.com (100.127.145.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:53:50 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 10 Jan 2023 08:53:48 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.16 via Frontend Transport; Tue, 10 Jan 2023 08:53:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 57c40165-90c4-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PmYoezE2IW59ME1CxZnlcTEIFj+1tLggVIMbia4uvmE=; b=S+xLDEACULP7+KdH+nj/G3VV5LHgo4ymITLwjnMgopxVbrXQXWhbUyVRz9ogi53sk2bNSHD7T/TGduW+f/9T00ohftgTkiuDvUHGYD5oXeN2++KvwKo2agN5w2ycRJ/mA9Sn5qmzfO9hXnC7+yleeh1mNMmfODCpbvjGACVDPU8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 83c795689737a32a X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RPYvj2k1Lj2CdVKjNkT7p0alj6ZJiiZyFUrQ0HV4Mmtyd1ese3R+OykyIpydt7iUFzgnIdYeXmBQLelrIl9+PnlKb3aaIDNnTBrb0FWosBzCdHcwihxA5FbmT2HiQYLSVK01XAOb3Y5RwrWpuO+7SGLqTefQQiPaPNdXrEXHwIaF5vo+MZNH6CBS0AdYcMU2zNsOLcN7vuWc3jy5affe5q1b29n4pFcSweETtkDoucXGhY8VPRv9XG87iQiIWtaY8KgMKFFtu6f5HslJE1kLQeJJxbKFG+dex3stozwASNCHqAf1e3fa32oAtzl9KI2JMOsgduzSPvzjnHHFKiUyIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PmYoezE2IW59ME1CxZnlcTEIFj+1tLggVIMbia4uvmE=; b=aCKm87ysa2saUVVLDBReWk2HgbAmJVGPn7fGA0UPXpPL9r7BZFJicp7bpp3ugFFaUGQfdM4NT+rlpLb7wYqXL8iseW38JQQHtCooDPJWw/zLq2G+LOHFPNCSUPs9f8GJNfmI0Wf051UFhsE6H7J0O4cdKvdvoPD4wpbPT8qncDiEvTFHFRV9qFfRiSeXzaRv9xq7JOo/CCt888ICD6/p2RKhfpISLuE+z37uasNRZ2SGG8QQFq/Qn/65D9wYRKZCj+LVF0hGLP4x/YSE6OZ0uXXf0NF9BbZsA0b09Z6bTrX95BhGXpc9W84x1+js5Ym3VpbZSPl68BzSSs+gMbkMqA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PmYoezE2IW59ME1CxZnlcTEIFj+1tLggVIMbia4uvmE=; b=S+xLDEACULP7+KdH+nj/G3VV5LHgo4ymITLwjnMgopxVbrXQXWhbUyVRz9ogi53sk2bNSHD7T/TGduW+f/9T00ohftgTkiuDvUHGYD5oXeN2++KvwKo2agN5w2ycRJ/mA9Sn5qmzfO9hXnC7+yleeh1mNMmfODCpbvjGACVDPU8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v2 02/17] xen/arm: implement helpers to get and update NUMA status Date: Tue, 10 Jan 2023 16:49:15 +0800 Message-ID: <20230110084930.1095203-3-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230110084930.1095203-1-wei.chen@arm.com> References: <20230110084930.1095203-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: VI1EUR03FT014:EE_|AS8PR08MB9315:EE_|AM7EUR03FT008:EE_|PAXPR08MB7646:EE_ X-MS-Office365-Filtering-Correlation-Id: 1d688aa0-011f-468c-06a2-08daf2e83a58 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: bTZm+HdFMjwpjFhk74ZmuJGg3uJLNaJNRMl7VjLMOaUlJGDCQ0bWSEj/1dMcyUn0K24XpZVKImbVi4f9ymRMHp/qiagmo4jJ1BkkLQU40ZEcPIg6HqZIUQHWtaEJQlNauWimUUHaks2nwBCa0rO4Nd8+x7/G3vDwhUQcGzKg3aOE8csafVk2vNtVboeqxB/rPA4hlpTOD8a8GWB1z/QR98Dusg2pleIPFZ0WIb9RcOdsaxpERwWejbTE8mypQ26I3u6qB4o5+vxtup5eRJcxOsOvMEqk0cVxXo0QQaXH5eEF5AztxTQgj0TJLm7xly0c+xAYrBbsq6Mkkuc1wt6JEymO9ZlCvda+slC5f5qizknvzINBR1TpHtgXM1MHcR9VnYAPzd1Qm/8viOxuynD9NrD1mEBvXQN55ZuHkIAa5vcuPgLJYevQIbJ0rwd4WDiZnIxNb5tTB4ho4V9NtuO0YkmGXL+wHIhP5nmTOwK1sxvuK6kHK52JBvCOsemSZkFHRRiOQHiUfxBpER8TvGqlq1F/gO69QUpssYTMPmk0nO5eAAWccnJ9WRuscqARP8+DLw/IFPcdSrtVbYlZiq0QZBptM2PrFgfozIcJt2JtB91eFvP+iWcj7clzkh+vqBk1/9GBY4TXbXQHEJI3lwtpC+zgAg8aGkKKgwTLf3AiDAygTmbM8yUTT0WSfgYiw0hU8+aFyU+3UEkwHZrMpwX65fNr4Ywe9D/u23QFOvPsl3R0WeKrdJXU8C4Kt37bmS94 X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(376002)(346002)(39860400002)(451199015)(46966006)(36840700001)(356005)(81166007)(82740400003)(36860700001)(6916009)(41300700001)(8676002)(4326008)(54906003)(70586007)(86362001)(40480700001)(44832011)(8936002)(5660300002)(15650500001)(1076003)(83380400001)(2616005)(47076005)(336012)(426003)(186003)(26005)(7696005)(478600001)(82310400005)(6666004)(2906002)(316002)(70206006)(36756003)(2004002)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9315 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT008.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 6c62addc-70e8-4869-cea6-08daf2e831a2 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JQG2fUK/dot99yd9QECpImJCMJouuwXf4n5gOoRIOxfRxI6U5YDUNguNm4rOeUsBKfHahET3UpoGq0XTBFPNSDH9K9DuE4OY7xtlVPG5rlnUVbvu9OTYJEWaD4IDFUwFfpZVEsd8WtuJwZuy9c7bPEI5EoXfixMZmJGFaWO8A5ltQOsm0dG0Ngl+d40iZfmoIuA1HE5+y9MQALfVGSZH9Q+4VLUe/KPJHEW2DJnJeFKtTHmSXcefbaKnO3sxiAf9+X8EV+1pACTje19/Mm2r5mFU9QDCZ0MxAhz32q5YjkRdRyWgzlx1vz+JEjdWol0AjQ1gRaHUT8U+7vnwmLAMFkaM7g8UQ5e6nrq6VZmY8eeuyyf/Bnwe70ktAZ9knirYqSlTd+4xuLJWaRKSx+aJLcIWaJdpZVfpWorSG+R8rthp9yYj97TXtsBu+wjoEGWG/9qSx6MlpaF38Ac4YkAfSV0j01gQaOCkHXHh7miLuN3iXAKA1uwKnzf9orGSVBVsZKqwxY0+iCuukHmuus7wGcWN4Jikdar8QrdTDGknSmLX2UJYDM8gSKWo5sL3Vv1M7b0eDqRqdrkPVW6KypYqMZXbFY4f3TNJrxN0AW2tM5i/6ctA/GHX531o8wIt9CvxEv9wY9hpKLdmHK3voUmU7j1IJdOK91dPe8pcr0tIWNc/JtZVB+GMcheUL4Grj7I0XASAmLn5issHE1vJfbNQQQCeRzc9+haf2mIYxhecDjzsAcRk7symhfQEh80I0vGa X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(396003)(136003)(346002)(451199015)(36840700001)(46966006)(40470700004)(83380400001)(426003)(82310400005)(47076005)(316002)(86362001)(54906003)(6916009)(36756003)(40480700001)(7696005)(81166007)(107886003)(82740400003)(186003)(336012)(26005)(40460700003)(2616005)(1076003)(2906002)(44832011)(478600001)(6666004)(5660300002)(15650500001)(8936002)(36860700001)(70206006)(41300700001)(4326008)(70586007)(8676002)(2004002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2023 08:54:05.1059 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1d688aa0-011f-468c-06a2-08daf2e83a58 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT008.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7646 NUMA has one global and one implementation specific switches. For ACPI NUMA implementation, Xen has acpi_numa, so we introduce device_tree_numa for device tree NUMA implementation. And use enumerations to indicate init, off and on status. arch_numa_disabled will get device_tree_numa status, but for arch_numa_setup we have not provided boot arguments to setup device_tree_numa. So we just return -EINVAL in this patch. Signed-off-by: Wei Chen --- v1 -> v2: 1. Use arch_numa_disabled to replace numa_enable_with_firmware. 2. Introduce enumerations for device tree numa status. 3. Use common numa_disabled, drop Arm version numa_disabled. 4. Introduce arch_numa_setup for Arm. 5. Rename bad_srat to numa_bad. 6. Add numa_enable_with_firmware helper. 7. Add numa_disabled helper. 8. Refine commit message. --- xen/arch/arm/include/asm/numa.h | 17 +++++++++++++ xen/arch/arm/numa.c | 44 +++++++++++++++++++++++++++++++++ xen/arch/x86/include/asm/numa.h | 1 - xen/include/xen/numa.h | 1 + 4 files changed, 62 insertions(+), 1 deletion(-) create mode 100644 xen/arch/arm/numa.c diff --git a/xen/arch/arm/include/asm/numa.h b/xen/arch/arm/include/asm/numa.h index 7d6ae36a19..52ca414e47 100644 --- a/xen/arch/arm/include/asm/numa.h +++ b/xen/arch/arm/include/asm/numa.h @@ -22,6 +22,12 @@ typedef u8 nodeid_t; */ #define NR_NODE_MEMBLKS NR_MEM_BANKS +enum dt_numa_status { + DT_NUMA_INIT, + DT_NUMA_ON, + DT_NUMA_OFF, +}; + #else /* Fake one node for now. See also node_online_map. */ @@ -39,6 +45,17 @@ extern mfn_t first_valid_mfn; #define node_start_pfn(nid) (mfn_x(first_valid_mfn)) #define __node_distance(a, b) (20) +#define numa_disabled() (true) +static inline bool arch_numa_unavailable(void) +{ + return true; +} + +static inline bool arch_numa_broken(void) +{ + return true; +} + #endif #define arch_want_default_dmazone() (false) diff --git a/xen/arch/arm/numa.c b/xen/arch/arm/numa.c new file mode 100644 index 0000000000..1c02b6a25d --- /dev/null +++ b/xen/arch/arm/numa.c @@ -0,0 +1,44 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * Arm Architecture support layer for NUMA. + * + * Copyright (C) 2021 Arm Ltd + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program. If not, see . + * + */ +#include +#include + +static enum dt_numa_status __read_mostly device_tree_numa; + +void __init numa_fw_bad(void) +{ + printk(KERN_ERR "NUMA: device tree numa info table not used.\n"); + device_tree_numa = DT_NUMA_OFF; +} + +bool __init arch_numa_unavailable(void) +{ + return device_tree_numa != DT_NUMA_ON; +} + +bool arch_numa_disabled(void) +{ + return device_tree_numa == DT_NUMA_OFF; +} + +int __init arch_numa_setup(const char *opt) +{ + return -EINVAL; +} diff --git a/xen/arch/x86/include/asm/numa.h b/xen/arch/x86/include/asm/numa.h index 7866afa408..61efe60a95 100644 --- a/xen/arch/x86/include/asm/numa.h +++ b/xen/arch/x86/include/asm/numa.h @@ -12,7 +12,6 @@ extern unsigned int numa_node_to_arch_nid(nodeid_t n); #define ZONE_ALIGN (1UL << (MAX_ORDER+PAGE_SHIFT)) -extern bool numa_disabled(void); extern nodeid_t setup_node(unsigned int pxm); extern void srat_detect_node(int cpu); diff --git a/xen/include/xen/numa.h b/xen/include/xen/numa.h index b86d0851fc..7d7aeb3a3c 100644 --- a/xen/include/xen/numa.h +++ b/xen/include/xen/numa.h @@ -55,6 +55,7 @@ extern void numa_init_array(void); extern void numa_set_node(unsigned int cpu, nodeid_t node); extern void numa_initmem_init(unsigned long start_pfn, unsigned long end_pfn); extern void numa_fw_bad(void); +extern bool numa_disabled(void); extern int arch_numa_setup(const char *opt); extern bool arch_numa_unavailable(void); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Jan 10 08:54:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 08:54:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474431.735631 (Exim 4.92) (envelope-from ) id 1pFAOc-0006k0-3W; Tue, 10 Jan 2023 08:54:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474431.735631; Tue, 10 Jan 2023 08:54:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFAOc-0006jt-0I; Tue, 10 Jan 2023 08:54:14 +0000 Received: by outflank-mailman (input) for mailman id 474431; Tue, 10 Jan 2023 08:54:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFAOa-0005oC-41 for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 08:54:12 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on2073.outbound.protection.outlook.com [40.107.8.73]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 58b01ba2-90c4-11ed-b8d0-410ff93cb8f0; Tue, 10 Jan 2023 09:54:09 +0100 (CET) Received: from ZR2P278CA0066.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:52::20) by GVXPR08MB8234.eurprd08.prod.outlook.com (2603:10a6:150:17::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 08:53:56 +0000 Received: from VI1EUR03FT043.eop-EUR03.prod.protection.outlook.com (2603:10a6:910:52:cafe::96) by ZR2P278CA0066.outlook.office365.com (2603:10a6:910:52::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:53:56 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT043.mail.protection.outlook.com (100.127.145.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:53:55 +0000 Received: ("Tessian outbound 3ad958cd7492:v132"); Tue, 10 Jan 2023 08:53:55 +0000 Received: from 61d7f55ca79f.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E6FA4810-2017-46FE-9DD2-24C2ADEF3DDC.1; Tue, 10 Jan 2023 08:53:49 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 61d7f55ca79f.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 10 Jan 2023 08:53:49 +0000 Received: from FR2P281CA0121.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9d::12) by PAWPR08MB9892.eurprd08.prod.outlook.com (2603:10a6:102:342::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 08:53:47 +0000 Received: from VI1EUR03FT013.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:9d:cafe::45) by FR2P281CA0121.outlook.office365.com (2603:10a6:d10:9d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.12 via Frontend Transport; Tue, 10 Jan 2023 08:53:47 +0000 Received: from nebula.arm.com (40.67.248.234) by VI1EUR03FT013.mail.protection.outlook.com (100.127.145.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:53:46 +0000 Received: from AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 10 Jan 2023 08:53:45 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 10 Jan 2023 08:53:44 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.16 via Frontend Transport; Tue, 10 Jan 2023 08:53:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 58b01ba2-90c4-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0ghbs3NMlTW31HC7fLfGV4BVVb2uAXdN3Yk6On4z3OE=; b=UYdjnt2KxskTOhh7CnrBqDiDOI8770guG9plfdw15gHHXoftHCwkLhzPmeougr81rLEhrQU0Ht3a5lEcK/wtM5x8HWdFrjShiv4Ej0Fz86uH6eVgm2sJBsiOu0BCHbmpA+xqDkFhcrbda7wQ/ahkESkrr206RgCaIBNHd1gX2n0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 57ba30604fec6c7a X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Edm4yXDsKlHYiMNb9jWW0nNxhTpCGzJ4YgvTRozhkCAt0VQc3J5Kaii9ijiH0O0L6GldnHuiXWSBtnSCpXGhQJ9/sGPvoXxPCKd9y1bZCBFhHB/i1uWzkBvHX9ypx4lT0NnkDUqcmL54BPPnjwH2PYRnv57cJChPS2YZSVMHcAhzt6nb2pp4/UkBaeyD+PU0Kp5SLQojzh3ADIPtPnhI4D8smHR8iiL5Fcgr6TIHuCMQiJxoglvVxfsPcXwpNc1oG8G2hZUXLani2lt9K9H+sL+KhIzj5KBV0yf2pTAgl1JM2aXzVeuk64XrLgBDwrmrjWFwBhc3Zn/zIWIcc28H4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0ghbs3NMlTW31HC7fLfGV4BVVb2uAXdN3Yk6On4z3OE=; b=CqpK6TLUP71Bphk0tmVXmS0cf3PWLb7rARR4AD0VdJodz6gTy9X9YX/lOJFDz+4VdqXv81KB/+FeBm+33O4KPzyxOWduQo3VGHURLiCPg6ihxrxR02uiE+fYiWnXiA7yJUXeXKAUCBwU/x1wEvDsI1sE6vxY30jEC+VUCbBl7EuENT/6kutf83QbZ0KxY72xsySAw0QiaySo9xGErzAfE2MwFCV66GW9wy2kwyIt1Ae0mR3al+ajvrdHbrRDPETle2wOQgibSYcOUUeFJOiHrp6lyJuemlPWNa2E7C+2DtgWyCKZEregffJdhC04gtGeUjZFG0wXGlsSVE6RucGHjw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0ghbs3NMlTW31HC7fLfGV4BVVb2uAXdN3Yk6On4z3OE=; b=UYdjnt2KxskTOhh7CnrBqDiDOI8770guG9plfdw15gHHXoftHCwkLhzPmeougr81rLEhrQU0Ht3a5lEcK/wtM5x8HWdFrjShiv4Ej0Fz86uH6eVgm2sJBsiOu0BCHbmpA+xqDkFhcrbda7wQ/ahkESkrr206RgCaIBNHd1gX2n0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: [PATCH v2 01/17] xen/arm: use NR_MEM_BANKS to override default NR_NODE_MEMBLKS Date: Tue, 10 Jan 2023 16:49:14 +0800 Message-ID: <20230110084930.1095203-2-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230110084930.1095203-1-wei.chen@arm.com> References: <20230110084930.1095203-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: VI1EUR03FT013:EE_|PAWPR08MB9892:EE_|VI1EUR03FT043:EE_|GVXPR08MB8234:EE_ X-MS-Office365-Filtering-Correlation-Id: e59497f9-d102-4d6d-c5a6-08daf2e834da x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: WmhDGC8koXn0vc2EKsYtnqaU3vxpgT8bGu8QEnhxMUGAvItMSU8IeAoeuiW0L35D6Kmfy79qepNiMM/g9j+WFdi8pNKFTZ7aWKAPLOPR+Kfo6hkFyL9Hc7pei4RzxWXwf3C3BKo+FXhl9I9+Rs5XK+rNaBGxQDZYm6yQA1Eln+9wvNUU/bVkVqTXQY/Ps4D3nYDNx2lrXeWjTB8oapjt8DMDtB1KmBKZhVO4JIYbpYwuQYYKrERYvuZn0h9cZ5+MqQ+yOsHhOElwl4PMm8AH4AxFbLxXyV/1envd2QaMOrVLfj0SFXTTj5nBB3E7ir94ohHxUL9NHwhDa88s7OdXb7frPXf0imzqYQAt80sQqh7QlJSP5M6pQ/bWK9IoMZUsEwbS0NK5IuEnwg2JGu2L1i4T509j6aA3w0AzOYEPQDG6ibaf9EksB7R1p8qQEJTglK8H7EdfXnXmgEWff4g/CbEOBj82/QknNaELMz11PNfkMeQf7tR4cJtLPu4McMyrUHJ7gnclDi1zMpflH7rDYC9cbsSmhGaML0Vo1+tueY25QFPHmR3oz3buSpKQsg16FAaptOFGM2A+cSsoJfAF0y/6s6Bzml2zdbOEZSobjnRq1htY+Bpt+RVNrHIUIHKCqitsvsCryyFsumfQhfja8GXegcn5JDMvivb9rDJIyHyamdBFNVVm9VPW8ee2BwTk6b73+GLzw5IYNBgV/auJe/KiSKOHpoToCn/1vWcdCzg= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(136003)(396003)(346002)(451199015)(36840700001)(46966006)(36756003)(356005)(41300700001)(2906002)(81166007)(8936002)(82740400003)(82310400005)(5660300002)(44832011)(47076005)(426003)(36860700001)(83380400001)(86362001)(966005)(54906003)(6916009)(7696005)(40480700001)(6666004)(26005)(186003)(8676002)(478600001)(70586007)(70206006)(4326008)(316002)(2616005)(336012)(1076003)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9892 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: d3ed03b6-9734-450f-b86c-08daf2e82f2e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: I+MnnlNnQvnqdKm6zsWgIJW3MNVJVlkk7+0GI33nv61Qa1ttsYj3sTMuo8vJ5nbTxKpMP/t7HzHZSTA0OSU8sJANMbdqvLwoQhInbzjJHkqR9A9itdF/8tfGxUyfsrSLRy8+V5cKG94O+DUyapBJT6HXcly1q3ICEZAkMQV4TVdUOlJDAFMWa9HSPhBJGKjRxhpgKSi/oRKRBgG2y/pZHaNlGUMZxzJKX5G+aL5GK4I3nVzeMqIPnALYrt+kseAeKy8qV/0wK/TGLr1BURQUS/sB6yGr6EsnF9YqEJVHlBso/o5iZC0vs+Gn/Db32w+EfNESq8mejmhDIDsk8jyX7XYKKlEjAHbiF+16kmJC5Ypk1nGG3/Zhsi89kUI/x5m04frEpVD6DsmDjR8u7Btzc+wo6WF1yu0JY4iTTJdNZpvfYyXvOOW5Td5REMZSpk+hO3j6jl0nOdmP4x0T0Tjb3WoNKXq2VzgtBHcgbEj13DgFL1GbCUnM/ppKDGMt1x2afUCHH0pK/4l17BGFoNEtWR9fY0TuEMAvFnpzIkrXjqarRCaGCv94HIyc9AnXR5qdQg3tJ9GMiiCOxLNhQkDOyCkxMTsPbPV5Ca+sPgCYP3M7zICxegNj/NHrVFwLO/PqiIuEKcRblaaEm010mFN3ICeq7AbmkD8i3xp9CDBeHpLFwDNCAUirfGjaenKMOVPypyy0OyfT+VMapGJ9trwuIblmHpzc330s4fXgaK3uzSs= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(39860400002)(376002)(346002)(451199015)(46966006)(40470700004)(36840700001)(82740400003)(81166007)(36860700001)(54906003)(8676002)(4326008)(40460700003)(86362001)(6916009)(41300700001)(70586007)(70206006)(316002)(8936002)(40480700001)(44832011)(5660300002)(2906002)(1076003)(2616005)(336012)(83380400001)(426003)(47076005)(82310400005)(966005)(7696005)(186003)(478600001)(6666004)(26005)(36756003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2023 08:53:55.8339 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e59497f9-d102-4d6d-c5a6-08daf2e834da X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR08MB8234 As a memory range described in device tree cannot be split across multiple nodes. And it is very likely than if you have more than 64 nodes, you may need a lot more than 2 regions per node. So the default NR_NODE_MEMBLKS value (MAX_NUMNODES * 2) makes no sense on Arm. So, for Arm, we would just define NR_NODE_MEMBLKS as an alias to NR_MEM_BANKS. And in the future NR_MEM_BANKS will be user-configurable via kconfig, but for now leave NR_MEM_BANKS as 128 on Arm. This avoid to have different way to define the value based NUMA vs non-NUMA. Further discussions can be found here[1]. [1] https://lists.xenproject.org/archives/html/xen-devel/2021-09/msg02322.html Signed-off-by: Wei Chen --- v1 -> v2: 1. Add code comments to explain using NR_MEM_BANKS for Arm 2. Refine commit messages. --- xen/arch/arm/include/asm/numa.h | 19 ++++++++++++++++++- xen/include/xen/numa.h | 9 +++++++++ 2 files changed, 27 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/include/asm/numa.h b/xen/arch/arm/include/asm/numa.h index e2bee2bd82..7d6ae36a19 100644 --- a/xen/arch/arm/include/asm/numa.h +++ b/xen/arch/arm/include/asm/numa.h @@ -3,9 +3,26 @@ #include +#include + typedef u8 nodeid_t; -#ifndef CONFIG_NUMA +#ifdef CONFIG_NUMA + +/* + * It is very likely that if you have more than 64 nodes, you may + * need a lot more than 2 regions per node. So, for Arm, we would + * just define NR_NODE_MEMBLKS as an alias to NR_MEM_BANKS. + * And in the future NR_MEM_BANKS will be bumped for new platforms, + * but for now leave NR_MEM_BANKS as it is on Arm. This avoid to + * have different way to define the value based NUMA vs non-NUMA. + * + * Further discussions can be found here: + * https://lists.xenproject.org/archives/html/xen-devel/2021-09/msg02322.html + */ +#define NR_NODE_MEMBLKS NR_MEM_BANKS + +#else /* Fake one node for now. See also node_online_map. */ #define cpu_to_node(cpu) 0 diff --git a/xen/include/xen/numa.h b/xen/include/xen/numa.h index 29b8c2df89..b86d0851fc 100644 --- a/xen/include/xen/numa.h +++ b/xen/include/xen/numa.h @@ -13,7 +13,16 @@ #define MAX_NUMNODES 1 #endif +/* + * Some architectures may have different considerations for + * number of node memory blocks. They can define their + * NR_NODE_MEMBLKS in asm/numa.h to reflect their architectural + * implementation. If the arch does not have specific implementation, + * the following default NR_NODE_MEMBLKS will be used. + */ +#ifndef NR_NODE_MEMBLKS #define NR_NODE_MEMBLKS (MAX_NUMNODES * 2) +#endif #define vcpu_to_node(v) (cpu_to_node((v)->processor)) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Jan 10 08:54:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 08:54:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474433.735642 (Exim 4.92) (envelope-from ) id 1pFAOi-0007FW-I6; Tue, 10 Jan 2023 08:54:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474433.735642; Tue, 10 Jan 2023 08:54:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFAOi-0007FL-EN; Tue, 10 Jan 2023 08:54:20 +0000 Received: by outflank-mailman (input) for mailman id 474433; Tue, 10 Jan 2023 08:54:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFAOh-0005s6-EJ for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 08:54:19 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2044.outbound.protection.outlook.com [40.107.7.44]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5e05ba28-90c4-11ed-91b6-6bf2151ebd3b; Tue, 10 Jan 2023 09:54:18 +0100 (CET) Received: from DB6P195CA0006.EURP195.PROD.OUTLOOK.COM (2603:10a6:4:cb::16) by PR3PR08MB5722.eurprd08.prod.outlook.com (2603:10a6:102:8f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 08:54:14 +0000 Received: from DBAEUR03FT036.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:cb:cafe::5b) by DB6P195CA0006.outlook.office365.com (2603:10a6:4:cb::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:54:14 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT036.mail.protection.outlook.com (100.127.142.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:54:13 +0000 Received: ("Tessian outbound 6e565e48ed4a:v132"); Tue, 10 Jan 2023 08:54:13 +0000 Received: from e119c51c4a8a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 51145894-0177-4CE7-B3C7-5A664C129EB9.1; Tue, 10 Jan 2023 08:54:07 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e119c51c4a8a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 10 Jan 2023 08:54:07 +0000 Received: from AM6PR01CA0070.eurprd01.prod.exchangelabs.com (2603:10a6:20b:e0::47) by DBAPR08MB5830.eurprd08.prod.outlook.com (2603:10a6:10:1a7::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 08:54:00 +0000 Received: from VI1EUR03FT017.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:e0:cafe::6e) by AM6PR01CA0070.outlook.office365.com (2603:10a6:20b:e0::47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:54:00 +0000 Received: from nebula.arm.com (40.67.248.234) by VI1EUR03FT017.mail.protection.outlook.com (100.127.145.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:53:59 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 10 Jan 2023 08:53:58 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.16 via Frontend Transport; Tue, 10 Jan 2023 08:53:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5e05ba28-90c4-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OmlC5wFOoSJu90l/OLm3xFQ5JzZOfdDA0L7vWkxPHDc=; b=Sy43EBjYcLq8aF4up6RexB9Ji6rFuvibh5nUWFOJsnY6cMDnUZD8UnFjsuXT0/DrtY26YjebUFNJh9QhblDTyKkj6lYjnAeOVZcFBIK1tFoQ8+/ZawjAc9qkDtl47S8Zxj2v2D20Cu5YlLpgAZeAmblg4Hd9qY58nARxQ/cu6Qk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 598d340d54c7d6d4 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aEGZGb6/zZt5fGplWpgxZUBCQ+6cLrMMtFP5+0Kuh0mqcjdk+0sE0z618V/BSDCjwqx34pqXB0WJTk7lUnsvJAvWlIqdWe/OVwU6qWt83e1WcD+oxQTeo3v6KA0SMTHo9fJzJ2NmqEEfDmhIvL0+e4ErSZU5Em+PYtPz7P7R+3Zs/s5jyOfDN1f3BtIqkKzEW/c3RxCDUZ6fJxSb2yIwFeeeriU1xrZQzcIGsEIu5gL67tS7h6vpioNoD/xEV+loIUFnc62yMQVEJTgnM1/qfTquG4luUk/RRkgPXL6BTZ1Uxaidwd+kPoJsximRbXvajTq5NA4GMJpcrF5uvxzS4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OmlC5wFOoSJu90l/OLm3xFQ5JzZOfdDA0L7vWkxPHDc=; b=ZF93L2XywmOEbBeFqAwIAZy8HIv1U1Fgqr9DS5hkQC1o4Fl/4kIYGDBznbqwFoHlfmo3tzBP1ZY7reQdTJZldEjgp0clozdoVxGdlcO2GqFSHDDOqdZAhTMfdO0F+ahyQinWuKPJr8nHwJtYDmcv2avIJJ5KyVlReoseNKBR8ydle+LieZDR2EXHjIwGKfZuoZ5VVyAehrnGutzvcrQmpsrktlbb4uqXv4Thep5eHwi5mqufS/SW7zcC+7EDA5qK40ReqBbk3IGGDtg0kwzMP+oJrJ5CUWxEHtPJgyyvx7TyXKsxo6PiHr90e0NiygL7bnqq+u7jkstMIXeMZU+Nxg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OmlC5wFOoSJu90l/OLm3xFQ5JzZOfdDA0L7vWkxPHDc=; b=Sy43EBjYcLq8aF4up6RexB9Ji6rFuvibh5nUWFOJsnY6cMDnUZD8UnFjsuXT0/DrtY26YjebUFNJh9QhblDTyKkj6lYjnAeOVZcFBIK1tFoQ8+/ZawjAc9qkDtl47S8Zxj2v2D20Cu5YlLpgAZeAmblg4Hd9qY58nARxQ/cu6Qk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v2 05/17] xen/arm: build NUMA cpu_to_node map in dt_smp_init_cpus Date: Tue, 10 Jan 2023 16:49:18 +0800 Message-ID: <20230110084930.1095203-6-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230110084930.1095203-1-wei.chen@arm.com> References: <20230110084930.1095203-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: VI1EUR03FT017:EE_|DBAPR08MB5830:EE_|DBAEUR03FT036:EE_|PR3PR08MB5722:EE_ X-MS-Office365-Filtering-Correlation-Id: bd4cf88b-290a-448c-d48c-08daf2e83f7a x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: SI51p/Vk9meZPDmXBPqoFHt6ZfyI+gLA1ABYTrtNS/85Ed1RuiafFjLa8TzMtnbg+IQ/iKGoUhM8y7MzbJqqzV+lZx9+xlI9GVOVbdG+rEwZo0mYO9jJkkPaKy9RIKo2IF82ejktwJmEgnpzHaGr7FWnOUSTeemIBZdmryOIP7K6ku4RsGZo1lRqiSsVE7K5zFmbzK3V9430c+b8iepZ1CGAPtkh7XnQ8f6m2MzjfY/EX01I97NemBiTlCrdNXC/qt6NPQYsqiMmsYVFn8YRyqtRuZVsdiqql2ArAlUC+mvKyBPnZRGHozB1j0cGxa+ul+Vtqt9BEYrz8V3Q6LBJNWLzCIuvLEUWBxxsCwpv0ENf2KfGz7OzXjkhkQ6E8j6fkWIqw5r+zVnbgA+aAfR4p5cq+owJsGTA8naXLErTiS+tqMFV6Dg9BPssAfwDW8EVt3zgYTPVjeAD5E4C+oXHgAJFJymN4pW0ds1I+CEeFx1hhf7GI+nNwY1r5GUzAS3lAFrIkcyZbJ6zuc4ktsK9gObITApriMVUcZwQnMdk6nc+5fk+2/Ay7bIBWT9fGpaRbJQnJ7UX5oQR4RsoaFl/ql/Y0WR9IbE9wIqWYYvLZ2X8V1D3TRSAk11qoBP90ZSW46kdo0Na2v2GuQ6zdpchMP3SCmlYjt8KvC83cTImtr72gdQ7+mq2w0jB3ccMsXMMKxfAm375n6+/v4vrv2YztQ== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(136003)(39860400002)(396003)(451199015)(46966006)(36840700001)(5660300002)(44832011)(8936002)(41300700001)(2906002)(36756003)(54906003)(83380400001)(8676002)(70586007)(70206006)(4326008)(316002)(6916009)(7696005)(26005)(81166007)(186003)(6666004)(86362001)(478600001)(336012)(1076003)(2616005)(40480700001)(47076005)(82740400003)(356005)(426003)(82310400005)(36860700001)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5830 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT036.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 6a57a722-ad5f-4226-b963-08daf2e8370f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lVQCwmOzH206DPJaw9vKdCl72MM1bNLoqu86R3ShS2+5Gf/tKqLwZLYp10Xk3oWlocpPaEMmhS7ZWcOi8ShIXMzqgk5nUrJYys9CDQNuQ/VoGgfb0HHnk2cNALPQitqNnv2qFMdndJNjAe2byaVIWljeyY6OVh/FGljnowLupVelDdwE5TxQlcZFIEDP7wVzXaC1p+aADa7bxyLszjTu2lQAyXlOwnOV201YNe4PzBcm+YDJTOmkP2G8asAo8XL3b87jntriroiLjLqrCCpIcxip+tjyM1A7K/iIow4zgDbNrRvRvre0WeOKj4qnTMwl2ZYyDExFfKJiwo/uc1F/91OoY1YfGOBbTZwccDxhNMEVOTljCeo74j5gswZn3DkZymZPT+Imbc8EzEC2cJMkdPbQlJqGz5yo+8X3Y6Y3kCAI1WZrE611/LduHtPCSVd1DxN4uLcST/nJyLSpq9JsPMoESZ2B9tLP9OWK9X/OUEOa/CGe01mAtdEd+oRsIjxjX8SjjcSq0iXhfCNjaXxo50u+bFqn7k03fDVpq9I1vQ901AZ/1rrhOmEBH1BigVj/PEPg8elmN7i2oDZJ0J8ykHoPuyppqml/qHINr888cp3B0X3Q4sG3J0vtNm5k4PrAX31XcfzKxI7Xca5ShayBGNColbB1t4IjYxWda0QsdAf5hwQg91bGz4uzSssBBkV1Z69svS7AGaOtPzisAype9Q== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(136003)(396003)(39860400002)(451199015)(40470700004)(36840700001)(46966006)(44832011)(2906002)(5660300002)(70206006)(36860700001)(8676002)(41300700001)(7696005)(8936002)(36756003)(70586007)(83380400001)(4326008)(316002)(86362001)(2616005)(82310400005)(426003)(336012)(6916009)(47076005)(186003)(40460700003)(1076003)(40480700001)(478600001)(81166007)(107886003)(26005)(82740400003)(54906003)(6666004);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2023 08:54:13.7539 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bd4cf88b-290a-448c-d48c-08daf2e83f7a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT036.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5722 NUMA implementation has a cpu_to_node array to store CPU to NODE map. Xen is using CPU logical ID in runtime components, so we use CPU logical ID as CPU index in cpu_to_node. In device tree case, cpu_logical_map is created in dt_smp_init_cpus. So, when NUMA is enabled, dt_smp_init_cpus will fetch CPU NUMA id at the same time for cpu_to_node. Signed-off-by: Wei Chen --- v1 -> v2: 1. Use static inline to replace macros to perform function paramerters type check. 2. Add numa_disabled to gate the numa-node-id check for CONFIG_NUMA on but numa disabled user case. 3. Use macro instead of static inline function to stub numa_set_node. --- xen/arch/arm/include/asm/numa.h | 4 ++++ xen/arch/arm/smpboot.c | 36 +++++++++++++++++++++++++++++++++ 2 files changed, 40 insertions(+) diff --git a/xen/arch/arm/include/asm/numa.h b/xen/arch/arm/include/asm/numa.h index dbdb632711..3bc28416b4 100644 --- a/xen/arch/arm/include/asm/numa.h +++ b/xen/arch/arm/include/asm/numa.h @@ -70,6 +70,10 @@ static inline bool arch_numa_broken(void) return true; } +static inline void numa_set_node(unsigned int cpu, nodeid_t node) +{ +} + #endif #define arch_want_default_dmazone() (false) diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c index 412ae22869..5ee6ab11e9 100644 --- a/xen/arch/arm/smpboot.c +++ b/xen/arch/arm/smpboot.c @@ -118,7 +118,12 @@ static void __init dt_smp_init_cpus(void) { [0 ... NR_CPUS - 1] = MPIDR_INVALID }; + static nodeid_t node_map[NR_CPUS] __initdata = + { + [0 ... NR_CPUS - 1] = NUMA_NO_NODE + }; bool bootcpu_valid = false; + unsigned int nid = 0; int rc; mpidr = system_cpuinfo.mpidr.bits & MPIDR_HWID_MASK; @@ -169,6 +174,28 @@ static void __init dt_smp_init_cpus(void) continue; } + if ( IS_ENABLED(CONFIG_NUMA) ) + { + /* + * When CONFIG_NUMA is set, try to fetch numa infomation + * from CPU dts node, otherwise the nid is always 0. + */ + if ( !dt_property_read_u32(cpu, "numa-node-id", &nid) ) + { + printk(XENLOG_WARNING + "cpu[%d] dts path: %s: doesn't have numa information!\n", + cpuidx, dt_node_full_name(cpu)); + /* + * During the early stage of NUMA initialization, when Xen + * found any CPU dts node doesn't have numa-node-id info, the + * NUMA will be treated as off, all CPU will be set to a FAKE + * node 0. So if we get numa-node-id failed here, we should + * set nid to 0. + */ + nid = 0; + } + } + /* * 8 MSBs must be set to 0 in the DT since the reg property * defines the MPIDR[23:0] @@ -228,9 +255,13 @@ static void __init dt_smp_init_cpus(void) { printk("cpu%d init failed (hwid %"PRIregister"): %d\n", i, hwid, rc); tmp_map[i] = MPIDR_INVALID; + node_map[i] = NUMA_NO_NODE; } else + { tmp_map[i] = hwid; + node_map[i] = nid; + } } if ( !bootcpu_valid ) @@ -246,6 +277,11 @@ static void __init dt_smp_init_cpus(void) continue; cpumask_set_cpu(i, &cpu_possible_map); cpu_logical_map(i) = tmp_map[i]; + + nid = node_map[i]; + if ( nid >= MAX_NUMNODES ) + nid = 0; + numa_set_node(i, nid); } } -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Jan 10 08:54:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 08:54:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474437.735653 (Exim 4.92) (envelope-from ) id 1pFAOk-0007cx-SI; Tue, 10 Jan 2023 08:54:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474437.735653; Tue, 10 Jan 2023 08:54:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFAOk-0007cl-O3; Tue, 10 Jan 2023 08:54:22 +0000 Received: by outflank-mailman (input) for mailman id 474437; Tue, 10 Jan 2023 08:54:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFAOj-0005oC-LX for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 08:54:21 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2040.outbound.protection.outlook.com [40.107.247.40]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5e93e1ff-90c4-11ed-b8d0-410ff93cb8f0; Tue, 10 Jan 2023 09:54:19 +0100 (CET) Received: from AS9PR0301CA0045.eurprd03.prod.outlook.com (2603:10a6:20b:469::13) by AS4PR08MB7783.eurprd08.prod.outlook.com (2603:10a6:20b:517::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 08:54:08 +0000 Received: from AM7EUR03FT005.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:469:cafe::5) by AS9PR0301CA0045.outlook.office365.com (2603:10a6:20b:469::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:54:07 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT005.mail.protection.outlook.com (100.127.140.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:54:07 +0000 Received: ("Tessian outbound 8038f0863a52:v132"); Tue, 10 Jan 2023 08:54:07 +0000 Received: from 506abfabed72.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 67DB3E74-75F4-498C-8913-675EE63F1492.1; Tue, 10 Jan 2023 08:54:00 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 506abfabed72.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 10 Jan 2023 08:54:00 +0000 Received: from FR3P281CA0049.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::22) by AS2PR08MB9570.eurprd08.prod.outlook.com (2603:10a6:20b:60a::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 08:53:54 +0000 Received: from VI1EUR03FT035.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:4a:cafe::56) by FR3P281CA0049.outlook.office365.com (2603:10a6:d10:4a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.11 via Frontend Transport; Tue, 10 Jan 2023 08:53:54 +0000 Received: from nebula.arm.com (40.67.248.234) by VI1EUR03FT035.mail.protection.outlook.com (100.127.145.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:53:54 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 10 Jan 2023 08:53:52 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.16 via Frontend Transport; Tue, 10 Jan 2023 08:53:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5e93e1ff-90c4-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3aUeRUGBRNGaCgpSKVEFEGKe8AB9JhLLaUj+oRdym0E=; b=PAO6IshgIncgfGpUvO35veBmTVm6f6P1LLu6onpE7NfrSnPDrdh+lQhwumbTJXEwfS3wzlZxUsykqlflANNOZD8wxn65JCFb84NiA4pfsxNM9TqL3HATUHEMnCwMJyqLTmc25KpLynD+f0ueIKiG9lISXLRuBHFav4JONxcExeQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 2bad1a70c48d8a12 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V/lx093Rgg1VIfShjwQq1ohzRNs9oSNa+HDWmUcxAfm7vDJVR4R59yQiHZZwWQ4H2fQEjrLcxvcBKUUgdFtzDpaBYOMfN3rnQmfnjR7YA5Ih2lAmEpBncAyPWV75eB0LlEL+dhuosJD9kDHDB3NT8+uJH5Nj6EJtG3yQcu9efP5fLq3Xn/Ky9woedVIuh5WvZkTDim0CkWT0Ni3kJYY/E4fbuOOIC6CXMmzHA51olccHyqira4+ht4+alRSRiYDmgzVAAwHYATv8T6P/dynmv8iMcsdEIToBNlvkZpdYLRFmtWu2TOkVcIXD6GQd4MDuiQRN/h7rJN/O3RFmo7A6jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3aUeRUGBRNGaCgpSKVEFEGKe8AB9JhLLaUj+oRdym0E=; b=Yie0lS5hpUE7rzC0dKy8sIdh25NRAb60PPW+2f9IXL36IBGKfeU4QxUSP+wSoxcYvr2BpJa4Mly/q/J9kniMoSkADxOAMqTxkX5hQmkencgKhKVvz9DiEmwQTd5q9cxXW4q4qqPISRIeLVxWxEtIIuLmDTouY1uE97JieeUkI/baOnQ+d3v7wRVeyp76uLL04LJ/WzftFpwfgvLzDHVDzzDVX+QyZTceZY3ige9d++ZfQa3nmIMNrgbp5XagIEGnbvF5DYmLLY29td/0Nekd2sDWKxnXf4M4rwmY7T5jpSNhT8yX2DAyCh9X2HmeeRMJh0NxyWiGoRpEfRRuPqejlQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3aUeRUGBRNGaCgpSKVEFEGKe8AB9JhLLaUj+oRdym0E=; b=PAO6IshgIncgfGpUvO35veBmTVm6f6P1LLu6onpE7NfrSnPDrdh+lQhwumbTJXEwfS3wzlZxUsykqlflANNOZD8wxn65JCFb84NiA4pfsxNM9TqL3HATUHEMnCwMJyqLTmc25KpLynD+f0ueIKiG9lISXLRuBHFav4JONxcExeQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v2 03/17] xen/arm: implement node distance helpers for Arm Date: Tue, 10 Jan 2023 16:49:16 +0800 Message-ID: <20230110084930.1095203-4-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230110084930.1095203-1-wei.chen@arm.com> References: <20230110084930.1095203-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: VI1EUR03FT035:EE_|AS2PR08MB9570:EE_|AM7EUR03FT005:EE_|AS4PR08MB7783:EE_ X-MS-Office365-Filtering-Correlation-Id: d6ff6283-0e07-422c-adb8-08daf2e83bc8 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: hbjNgsCSK8+bVz4REmlbUM3es/jUHi81a7rooPo68FJU8b4Z6G5bBfPCxPZvJ97ZKjHpzFXi3nSejLOfCRO4ac0GVMdonoHFJCtH4GaG8gPHdtPWOqyMGr9f4ecTTc2bHCU8EOsEmOAla56E5dhE8CuJI6LvAjLqPJ+zOW/Q2lhA0oXOTxkM/iWa7W6FJG/6MExdzZmRR02CCTQrQtjzxiiZi0NDD4R16nK4ypkVx7MUtHcwkPTN2x4JSDry63ATDcUKzwMrnrk36ByKA3oz9YFmMQzletrmwwtTQpgdX+6DHbc6eqZEGNOjrvpraDgAEV1j7XdCyD7y6VhtHwjA7P5snhl74qbdP/BHQJht6VATcISOE1qscMdH6DbkgHceXnfhw4F0c/kE9/HJVWUr+BUZMZnVBBCdbjvmHxRrPwCU5xl5KLE5zQj4kC/swUHFUpUJd6d214GxLqvgPx4UpQfd3MbwI+hwfMeL7pFHqriqFWxMIuGJOCM/jz0xqB0k8yqxc2zs49hfItZdsUCGZ+tDlJ9GfL9M5AZOfKkqlZeHHAG0mnCJyQ2idVgF0e+9PLFI1F8wGB+JYhWT6MlOV231G5tZQ/ExnXfzZ+relYMme9Ph6YD5vUcVAPAFgvc3lHho0e7dYVAMUsCJ8qjwh3feahAHQJ7Vcj+e9cd7+GDZjQP7QPvVQrsaSj/NguCGH1XRSLBOvfuIdSrS4OSWo/E+P3K8plxMzsKapolStjY= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(346002)(136003)(396003)(451199015)(36840700001)(46966006)(83380400001)(36860700001)(86362001)(356005)(2906002)(4326008)(82740400003)(81166007)(44832011)(8676002)(5660300002)(70586007)(8936002)(70206006)(426003)(40480700001)(41300700001)(82310400005)(186003)(26005)(336012)(2616005)(47076005)(1076003)(7696005)(316002)(6916009)(478600001)(54906003)(6666004)(36756003)(2004002)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9570 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: cf03f6e2-3636-4159-bfff-08daf2e833c9 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VW7TrlGt2fVdKZarcjmXloyKk/QCj/J9JvtDmZ2/okup7iEfY7akz2qC0DmF6+RdD1RP54n0c7gqawZrFgSyyIvma6H58oRx0CmsWUzDh+tBVXudK7b67xIshwAaYlM64qeSPf2vVuyGfJGLgBB2yyZLr+ODA4wKYjK2M+mxiArJ7ojWiCjCTUme9A6tdFi/oftRuALDNED2osE9ZD+3QPAjjG9pubjl2lTkYC7MYiOp2l126iQ08W/RET4t5qNFes2N3MC97nSOG1pUNkQJgY96Wlg4A9DajdCILzC0a8LnMepQGUdj8xcQLJC5NfsWK2m+TiM3ey6Udr2iBlMlYVe1qUuHDB18AzIhUz82AI4b6Gl6seEDe39ifLkdxmoenGLMGKnraUb+Ssh4WDDmYbbxgm6Jw7/SZfNuoxbDIDfylfkSx90CHf/Jxfrclv9QPcDNJzmvCVfAHWtzlholCRuI72RT4pPIhUFz2R/r8fCu41dyyFWTgvF6+ZKBMGJcM0zRxKtuDtFGjghhzOMOtKccss0MWnud/PGtagX6BOpAL7gaHp+sk2WYHvjsRID2v+RorESu5UM55BglGnqAwdFtcnTJIv2weQA7MYezHeTCbjxV4U6etP1tGZP4i16HSacuuU8VjDznsoHR8JjGzASKedseA/o6QvmezuDY0blGpp+0deKC8v40iIxM/l7YfAPltgYowYr0OSb5omfLmyMUKiOz66JfAtT02PfjnHs= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(396003)(136003)(376002)(451199015)(36840700001)(40470700004)(46966006)(40480700001)(36756003)(86362001)(40460700003)(316002)(7696005)(54906003)(6916009)(478600001)(6666004)(5660300002)(2906002)(44832011)(70586007)(107886003)(70206006)(8676002)(4326008)(41300700001)(36860700001)(83380400001)(82740400003)(2616005)(81166007)(26005)(8936002)(1076003)(186003)(47076005)(426003)(336012)(82310400005)(2004002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2023 08:54:07.5219 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d6ff6283-0e07-422c-adb8-08daf2e83bc8 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB7783 We will parse NUMA nodes distances from device tree. So we need a matrix to record the distances between any two nodes we parsed. Accordingly, we provide this node_set_distance API for device tree NUMA to set the distance for any two nodes in this patch. When NUMA initialization failed, __node_distance will return NUMA_REMOTE_DISTANCE, this will help us avoid doing rollback for distance maxtrix when NUMA initialization failed. As both x86 and Arm have implemented __node_distance, so we move its definition from asm/numa.h to xen/numa.h. At same time, the outdated u8 return value of x86 has been changed to unsigned char. Signed-off-by: Wei Chen --- v1 -> v2: 1. Use unsigned int/char instead of uint32_t/u8. 2. Re-org the commit message. --- xen/arch/arm/Makefile | 1 + xen/arch/arm/include/asm/numa.h | 14 +++++++++ xen/arch/arm/numa.c | 52 ++++++++++++++++++++++++++++++++- xen/arch/x86/include/asm/numa.h | 1 - xen/arch/x86/srat.c | 2 +- xen/include/xen/numa.h | 1 + 6 files changed, 68 insertions(+), 3 deletions(-) diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile index 4d076b278b..9073398d6e 100644 --- a/xen/arch/arm/Makefile +++ b/xen/arch/arm/Makefile @@ -38,6 +38,7 @@ obj-$(CONFIG_LIVEPATCH) += livepatch.o obj-y += mem_access.o obj-y += mm.o obj-y += monitor.o +obj-$(CONFIG_NUMA) += numa.o obj-y += p2m.o obj-y += percpu.o obj-y += platform.o diff --git a/xen/arch/arm/include/asm/numa.h b/xen/arch/arm/include/asm/numa.h index 52ca414e47..dbdb632711 100644 --- a/xen/arch/arm/include/asm/numa.h +++ b/xen/arch/arm/include/asm/numa.h @@ -28,6 +28,20 @@ enum dt_numa_status { DT_NUMA_OFF, }; +/* + * In ACPI spec, 0-9 are the reserved values for node distance, + * 10 indicates local node distance, 20 indicates remote node + * distance. Set node distance map in device tree will follow + * the ACPI's definition. + */ +#define NUMA_DISTANCE_UDF_MIN 0 +#define NUMA_DISTANCE_UDF_MAX 9 +#define NUMA_LOCAL_DISTANCE 10 +#define NUMA_REMOTE_DISTANCE 20 + +extern void numa_set_distance(nodeid_t from, nodeid_t to, + unsigned int distance); + #else /* Fake one node for now. See also node_online_map. */ diff --git a/xen/arch/arm/numa.c b/xen/arch/arm/numa.c index 1c02b6a25d..34851ceacf 100644 --- a/xen/arch/arm/numa.c +++ b/xen/arch/arm/numa.c @@ -2,7 +2,7 @@ /* * Arm Architecture support layer for NUMA. * - * Copyright (C) 2021 Arm Ltd + * Copyright (C) 2022 Arm Ltd * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License version 2 as @@ -22,6 +22,11 @@ static enum dt_numa_status __read_mostly device_tree_numa; +static unsigned char __read_mostly +node_distance_map[MAX_NUMNODES][MAX_NUMNODES] = { + { 0 } +}; + void __init numa_fw_bad(void) { printk(KERN_ERR "NUMA: device tree numa info table not used.\n"); @@ -42,3 +47,48 @@ int __init arch_numa_setup(const char *opt) { return -EINVAL; } + +void __init numa_set_distance(nodeid_t from, nodeid_t to, + unsigned int distance) +{ + if ( from >= MAX_NUMNODES || to >= MAX_NUMNODES ) + { + printk(KERN_WARNING + "NUMA: invalid nodes: from=%"PRIu8" to=%"PRIu8" MAX=%"PRIu8"\n", + from, to, MAX_NUMNODES); + return; + } + + /* NUMA defines 0xff as an unreachable node and 0-9 are undefined */ + if ( distance >= NUMA_NO_DISTANCE || + (distance >= NUMA_DISTANCE_UDF_MIN && + distance <= NUMA_DISTANCE_UDF_MAX) || + (from == to && distance != NUMA_LOCAL_DISTANCE) ) + { + printk(KERN_WARNING + "NUMA: invalid distance: from=%"PRIu8" to=%"PRIu8" distance=%"PRIu32"\n", + from, to, distance); + return; + } + + node_distance_map[from][to] = distance; +} + +unsigned char __node_distance(nodeid_t from, nodeid_t to) +{ + /* When NUMA is off, any distance will be treated as remote. */ + if ( numa_disabled() ) + return NUMA_REMOTE_DISTANCE; + + /* + * Check whether the nodes are in the matrix range. + * When any node is out of range, except from and to nodes are the + * same, we treat them as unreachable (return 0xFF) + */ + if ( from >= MAX_NUMNODES || to >= MAX_NUMNODES ) + return from == to ? NUMA_LOCAL_DISTANCE : NUMA_NO_DISTANCE; + + return node_distance_map[from][to]; +} + +EXPORT_SYMBOL(__node_distance); diff --git a/xen/arch/x86/include/asm/numa.h b/xen/arch/x86/include/asm/numa.h index 61efe60a95..18b71ddfef 100644 --- a/xen/arch/x86/include/asm/numa.h +++ b/xen/arch/x86/include/asm/numa.h @@ -21,7 +21,6 @@ extern void init_cpu_to_node(void); #define arch_want_default_dmazone() (num_online_nodes() > 1) void srat_parse_regions(paddr_t addr); -extern u8 __node_distance(nodeid_t a, nodeid_t b); unsigned int arch_get_dma_bitsize(void); #endif diff --git a/xen/arch/x86/srat.c b/xen/arch/x86/srat.c index 56749ddca5..50faf5d352 100644 --- a/xen/arch/x86/srat.c +++ b/xen/arch/x86/srat.c @@ -328,7 +328,7 @@ unsigned int numa_node_to_arch_nid(nodeid_t n) return 0; } -u8 __node_distance(nodeid_t a, nodeid_t b) +unsigned char __node_distance(nodeid_t a, nodeid_t b) { unsigned index; u8 slit_val; diff --git a/xen/include/xen/numa.h b/xen/include/xen/numa.h index 7d7aeb3a3c..cff4fb8ccc 100644 --- a/xen/include/xen/numa.h +++ b/xen/include/xen/numa.h @@ -115,6 +115,7 @@ extern bool numa_memblks_available(void); extern bool numa_update_node_memblks(nodeid_t node, unsigned int arch_nid, paddr_t start, paddr_t size, bool hotplug); extern void numa_set_processor_nodes_parsed(nodeid_t node); +extern unsigned char __node_distance(nodeid_t a, nodeid_t b); #else -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Jan 10 08:54:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 08:54:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474438.735664 (Exim 4.92) (envelope-from ) id 1pFAOm-0007vw-F3; Tue, 10 Jan 2023 08:54:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474438.735664; Tue, 10 Jan 2023 08:54:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFAOm-0007v2-AD; Tue, 10 Jan 2023 08:54:24 +0000 Received: by outflank-mailman (input) for mailman id 474438; Tue, 10 Jan 2023 08:54:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFAOk-0005oC-ED for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 08:54:22 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2051.outbound.protection.outlook.com [40.107.20.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5eadc0bb-90c4-11ed-b8d0-410ff93cb8f0; Tue, 10 Jan 2023 09:54:19 +0100 (CET) Received: from AS9P251CA0024.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:50f::26) by AS8PR08MB10272.eurprd08.prod.outlook.com (2603:10a6:20b:62b::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 08:54:17 +0000 Received: from AM7EUR03FT020.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:50f:cafe::a0) by AS9P251CA0024.outlook.office365.com (2603:10a6:20b:50f::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:54:17 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT020.mail.protection.outlook.com (100.127.140.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:54:17 +0000 Received: ("Tessian outbound 43b0faad5a68:v132"); Tue, 10 Jan 2023 08:54:17 +0000 Received: from ce7d68c79393.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id DCA68D6C-84A1-4841-B4DA-AE16FA9E8149.1; Tue, 10 Jan 2023 08:54:10 +0000 Received: from EUR03-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ce7d68c79393.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 10 Jan 2023 08:54:10 +0000 Received: from AS9PR04CA0143.eurprd04.prod.outlook.com (2603:10a6:20b:48a::24) by AS4PR08MB8021.eurprd08.prod.outlook.com (2603:10a6:20b:584::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 08:54:07 +0000 Received: from AM7EUR03FT045.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:48a:cafe::74) by AS9PR04CA0143.outlook.office365.com (2603:10a6:20b:48a::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:54:07 +0000 Received: from nebula.arm.com (40.67.248.234) by AM7EUR03FT045.mail.protection.outlook.com (100.127.140.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:54:07 +0000 Received: from AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 10 Jan 2023 08:54:07 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 10 Jan 2023 08:54:06 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.16 via Frontend Transport; Tue, 10 Jan 2023 08:54:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5eadc0bb-90c4-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OKOqbwKgR3BpQXq2D8GZb/uo0PrVqRyZlKb7VkWKCUg=; b=AXnC8dht/q3saI6VzXewmyQIF1ygQWApxX737ntEYgSF1qsK0vD6c2sA1RwMWmPf+SCr2xHX2aP0c+uPjVufXv4LGxXiZicbyTVPFVLFUqb8Bi6zbndNDBHYEpua9CfhXTpHhIgEvgs3u4qmS9b9dp6XsAV4wrltkq/IVBZcCDg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 7cb5e6b944ac46a3 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZVvzccwh/3zGxJOsUbts1FUGLsjFolK0rMjB/BlvVlK//6wTHke8+1th5q8ij6DxZrh/QsjLpR+UxOmunx6+PQQKD9jCt1L8M5j+wGeKlEXn62p6SFRn+yg0GB0Q6dnIwdD+axbqn5aWghkmlOu/oSr9Bvz/ktJ3HdFcnCCyiBSotmaLi5a9MSTrZ1lk1g/IuqNL+PwnLNz7Wu8heDRJxTLoKj6eLD83N6gVYby2iBKosPeRz0E4l3xwI6TPGUT0qMiGdBh8Wcq37uUHA69z/rQbQ/4EXT5/xMxX5vHgk1fmI6iNPM6WBQbMG61c5719+PL+lXOg5NAAtgQDZpj8Sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OKOqbwKgR3BpQXq2D8GZb/uo0PrVqRyZlKb7VkWKCUg=; b=XfnTSQv3AhqoRJm55lqZgy4/BvOzddIojFoX+9svsbb+3WTmYzyinyeIH2vhOZ9sfDN9WSGWmztDbj2Fo0LNX9tSDIRqQ27J9eWAyursULHI+BL/iJRZfhDZftRgiPIu3NcuH2ElxbjWmrg2VO+MLqDyydvMztkaWDFng4CEjce4l9EjXBkik4sakk6afa3vePd1o2AnuW4Dw68Ac4BF9O2AqZTFn9l3RWeD1gKrxGf6RviO3N/Kn12TgLV18uc6sTgoyYIpI14n5eKrvCL/bMxYuF9CFT7m1CSRDN8iwUGpN6uFuyoqcuDQXkzgUqYSMYjsEInmV4W1QEo51z/3tA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OKOqbwKgR3BpQXq2D8GZb/uo0PrVqRyZlKb7VkWKCUg=; b=AXnC8dht/q3saI6VzXewmyQIF1ygQWApxX737ntEYgSF1qsK0vD6c2sA1RwMWmPf+SCr2xHX2aP0c+uPjVufXv4LGxXiZicbyTVPFVLFUqb8Bi6zbndNDBHYEpua9CfhXTpHhIgEvgs3u4qmS9b9dp6XsAV4wrltkq/IVBZcCDg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v2 08/17] xen/arm: introduce a helper to parse device tree memory node Date: Tue, 10 Jan 2023 16:49:21 +0800 Message-ID: <20230110084930.1095203-9-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230110084930.1095203-1-wei.chen@arm.com> References: <20230110084930.1095203-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: AM7EUR03FT045:EE_|AS4PR08MB8021:EE_|AM7EUR03FT020:EE_|AS8PR08MB10272:EE_ X-MS-Office365-Filtering-Correlation-Id: 804971e2-82c8-4155-85b5-08daf2e841d4 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: cYC1f+ENHyJAnlqwLMSVrd/QKZpp8bFQw/NYKKG7PF23sg5hOcL8aXy9meIimpkmkmoX0f108tkj+WLiA8zoksBm92kundWXXBtANT3EFsrL05GmUeibh+Rb6td7vJf1lZOnIhC5NvpF6u8h76EadVhTDTNS9nrHyMH04Z3tzFRI7jefglp/b7ZvgJTnBqWXCNzxWtsGkQHP0eX8+RFvzhblIsgg8j5if/EPGHbXA01umoe9wYjjaQeQBcxwbbNoN3cioqZMGPkYQaPL7/OqC3EwheIoyucUdgNtMWD50gK+5T33/aDVPITtDE/HPYR+0lGkHM2hLbj2Af5mRvnlRDXWRpY5qfz0Gr4JwjAGyF9TcANP53AAD2scNH/pbhgOQYlQCVyrYQmU2p4OXHPKxHrF307cQ064ST5RmCnxdx0F9HUjDrTjGRD1L6ax/P3dhi9cZkw6YKPRXvql9F7jeI/OflVpXCAQuzHMQJ3VmNzHvrAVUFDiJu1V9XCClHQ0DkMj1jLCnQg/j+bqX7FhHj3FWkPr2gBUaixh+wHECaPQo4wrZDnY4f44BqbUUe2+xXwuqQ0DmGGQ7f+XjmakcNq9gvYAAQp+Cg4yOtkyatSPpm0n6cy+NG5v/RXg/mSpeuRfFTy/QRVYhORYWOJIkHgOrqgANSi2YG/F9tDR+x42xwGZ7DQFN3WniF3oZHjkwiOi8SgirOb2EzSYyS8vSw== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(39860400002)(376002)(346002)(451199015)(36840700001)(46966006)(36756003)(82740400003)(81166007)(356005)(86362001)(2906002)(44832011)(8676002)(70206006)(70586007)(4326008)(5660300002)(8936002)(83380400001)(36860700001)(7696005)(316002)(54906003)(6666004)(6916009)(40480700001)(82310400005)(41300700001)(1076003)(47076005)(336012)(426003)(478600001)(186003)(2616005)(26005)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB8021 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT020.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ed89b6d8-b1b3-4969-9475-08daf2e83bcb X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tASn4v6OG2BoFMYZF9AgW2RWMlFlKpGv9j/M0edEIiWzE4w4kB/48VYlPsavsFGiSwzxeXl4GGIMqH7P53um9SQqgoag6SyOikYCnS/WuzPqQ1YsVnFTf6yVE8icJiU4zANRc5hkkCeM+HlGN0MBGUUersvOKdyJOg98t872jSEdCgv9P5Bn9uRbC6ekrKg6UOM/RGUD2QvG4UoHuK99HMhVl+1GAxWxX/JcJU26h38nSX5PEz1FJFqkz8umipHIPG/wGhvnn7k9vYKkIMmMuJ2zKMcrneVyXiTEJ697+Y6r71RV8ETCltuKwSfyqZg8IzEC+AwJejMd/AvjE83dufsElbdhf7myh2z9yNHCFwzc3OM3xs5om7Jd7Zlvu4o2AWLvcyhm9ozRrEJn9Rj3SSUj/79yBbMh/BvkbPOYQ8IrRSzMnPKYddZCuTIHH8JIi8AylqPAcMJmzBTZvjFb1Zd/rwAAuMWIYnqKMa2IYxQ+boHa+56k9KyIB+MbAgquPy7BhZK2BYwcryI7u1rDO7YWjQrDQnX120qxht6DJs1VkUHTXyB6f4q1B+eHPUFQSCXkAiI0n51KEyVtUUvFmPFak4FieMd+InFxlZ2SYnK9330M39OHbJHbF51/2l/1suyWYMC2WI/I9GmSThjdoTnNuSxgCrvwzfDQ74g/3T7j+qHkZ/LGoS+wRxQCAzRL2wen8cE2/iHQ3OPyHwfnyw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(376002)(346002)(39860400002)(451199015)(46966006)(36840700001)(40470700004)(82740400003)(81166007)(36860700001)(54906003)(41300700001)(70586007)(86362001)(8676002)(40460700003)(6916009)(70206006)(6666004)(5660300002)(316002)(40480700001)(2906002)(44832011)(2616005)(1076003)(426003)(336012)(47076005)(83380400001)(7696005)(82310400005)(26005)(107886003)(186003)(8936002)(478600001)(4326008)(36756003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2023 08:54:17.6502 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 804971e2-82c8-4155-85b5-08daf2e841d4 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT020.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB10272 Memory blocks' NUMA ID information is stored in device tree's memory nodes as "numa-node-id". We need a new helper to parse and verify this ID from memory nodes. Signed-off-by: Wei Chen --- v1->v2: 1. Move numa_disabled check to fdt_parse_numa_memory_node. 2. Use numa_bad to replace bad_srat. 3. Replace tabs by spaces. 4. Align parameters. 5. return ENODATA for a normal dtb without numa info. 6. Un-addressed comment: "Why not parse numa-node-id and call fdt_numa_memory_affinity_init from xen/arch/arm/bootfdt.c:device_tree_get_meminfo. Is it because device_tree_get_meminfo is called too early?" I checked the device_tree_get_meminfo code and I think the answer is similar as I reply in RFC. I prefer a unify numa initialization entry. Don't want to make numa parse code in different places. 7. Use node id as dummy PXM for numa_update_node_memblks. --- xen/arch/arm/numa_device_tree.c | 89 +++++++++++++++++++++++++++++++++ 1 file changed, 89 insertions(+) diff --git a/xen/arch/arm/numa_device_tree.c b/xen/arch/arm/numa_device_tree.c index c031053d24..793a410fd4 100644 --- a/xen/arch/arm/numa_device_tree.c +++ b/xen/arch/arm/numa_device_tree.c @@ -34,6 +34,26 @@ static int __init fdt_numa_processor_affinity_init(nodeid_t node) return 0; } +/* Callback for parsing of the memory regions affinity */ +static int __init fdt_numa_memory_affinity_init(nodeid_t node, + paddr_t start, paddr_t size) +{ + if ( !numa_memblks_available() ) + { + dprintk(XENLOG_WARNING, + "Too many numa entry, try bigger NR_NODE_MEMBLKS\n"); + return -EINVAL; + } + + numa_fw_nid_name = "numa-node-id"; + if ( !numa_update_node_memblks(node, node, start, size, false) ) + return -EINVAL; + + device_tree_numa = DT_NUMA_ON; + + return 0; +} + /* Parse CPU NUMA node info */ static int __init fdt_parse_numa_cpu_node(const void *fdt, int node) { @@ -62,3 +82,72 @@ static int __init fdt_parse_numa_cpu_node(const void *fdt, int node) return fdt_numa_processor_affinity_init(nid); } + +/* Parse memory node NUMA info */ +static int __init fdt_parse_numa_memory_node(const void *fdt, int node, + const char *name, + unsigned int addr_cells, + unsigned int size_cells) +{ + unsigned int nid; + int ret = 0, len; + paddr_t addr, size; + const struct fdt_property *prop; + unsigned int idx, ranges; + const __be32 *addresses; + + if ( numa_disabled() ) + return -EINVAL; + + /* + * device_tree_get_u32 will return NUMA_NO_NODE when this memory + * DT node doesn't have numa-node-id. This can help us to + * distinguish a bad DTB and a normal DTB without NUMA info. + */ + nid = device_tree_get_u32(fdt, node, "numa-node-id", NUMA_NO_NODE); + if ( node == NUMA_NO_NODE ) + { + numa_fw_bad(); + return -ENODATA; + } + else if ( nid >= MAX_NUMNODES ) + { + printk(XENLOG_WARNING "Node id %u exceeds maximum value\n", nid); + goto invalid_data; + } + + prop = fdt_get_property(fdt, node, "reg", &len); + if ( !prop ) + { + printk(XENLOG_WARNING + "fdt: node `%s': missing `reg' property\n", name); + goto invalid_data; + } + + addresses = (const __be32 *)prop->data; + ranges = len / (sizeof(__be32)* (addr_cells + size_cells)); + for ( idx = 0; idx < ranges; idx++ ) + { + device_tree_get_reg(&addresses, addr_cells, size_cells, &addr, &size); + /* Skip zero size ranges */ + if ( !size ) + continue; + + ret = fdt_numa_memory_affinity_init(nid, addr, size); + if ( ret ) + goto invalid_data; + } + + if ( idx == 0 ) + { + printk(XENLOG_ERR + "bad property in memory node, idx=%d ret=%d\n", idx, ret); + goto invalid_data; + } + + return 0; + +invalid_data: + numa_fw_bad(); + return -EINVAL; +} -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Jan 10 08:54:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 08:54:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474443.735675 (Exim 4.92) (envelope-from ) id 1pFAOo-0008Lv-O9; Tue, 10 Jan 2023 08:54:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474443.735675; Tue, 10 Jan 2023 08:54:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFAOo-0008Ll-K6; Tue, 10 Jan 2023 08:54:26 +0000 Received: by outflank-mailman (input) for mailman id 474443; Tue, 10 Jan 2023 08:54:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFAOn-0005oC-LN for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 08:54:25 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2074.outbound.protection.outlook.com [40.107.7.74]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 610301df-90c4-11ed-b8d0-410ff93cb8f0; Tue, 10 Jan 2023 09:54:23 +0100 (CET) Received: from AS9P251CA0012.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:50f::14) by AS8PR08MB6023.eurprd08.prod.outlook.com (2603:10a6:20b:291::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 08:54:21 +0000 Received: from AM7EUR03FT020.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:50f:cafe::a0) by AS9P251CA0012.outlook.office365.com (2603:10a6:20b:50f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:54:20 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT020.mail.protection.outlook.com (100.127.140.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:54:20 +0000 Received: ("Tessian outbound 43b0faad5a68:v132"); Tue, 10 Jan 2023 08:54:20 +0000 Received: from 6c9be4230c91.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B72E062C-9E7F-45B2-933D-CA866276CC5D.1; Tue, 10 Jan 2023 08:54:13 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 6c9be4230c91.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 10 Jan 2023 08:54:13 +0000 Received: from AM6PR01CA0063.eurprd01.prod.exchangelabs.com (2603:10a6:20b:e0::40) by GV2PR08MB7956.eurprd08.prod.outlook.com (2603:10a6:150:a9::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 08:54:09 +0000 Received: from VI1EUR03FT017.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:e0:cafe::f4) by AM6PR01CA0063.outlook.office365.com (2603:10a6:20b:e0::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:54:08 +0000 Received: from nebula.arm.com (40.67.248.234) by VI1EUR03FT017.mail.protection.outlook.com (100.127.145.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:54:08 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 10 Jan 2023 08:54:00 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.16 via Frontend Transport; Tue, 10 Jan 2023 08:53:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 610301df-90c4-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DetB4lMCYSGFHbQ+S23R1nmvP6AkNk5bezLoeuNo2NQ=; b=CjYW9OA5MiITfPRLeAQJdBtRhIIzXkoXUeLTsylRqosW0eZ5fT1/96spS8RcdECNGzla6LAu1pnAvPEJws6jZTKutIQh25/plhP6g5Q+g2qq6lLH30tl6Z2xbjAY2McqQ7OhYemVvH39LQAyf05iqCUlnd9hdLqPZ2TydNKt76c= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 138f2759a09173da X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k/UZejh/sDhmr1GIIVrikmdsspgU0j0oko0y7Pq0nmGe9UN8Uju5V0Y3Fr0TF7F9NAoQGYHx+b9EO7YznfB0lyAKduICwGn+nyydzUSSeEOtlEW7KTjN/s3SbqpAzCI8Mka+g0jAOePvva6uok91EkDqRIkdO/LFo3u4tSK4G05vq2GdhABgAMGDvMRDpGDXwLV4tTda2s5fiRvbxGKES6BeJhD22w500pY64ERUjqjAIgeYU5Rv1ynzVjP58WlCOGOPo2f9W3dbAHymnBTheeMQHF+Vp48S9S8aeTU2NVHLa5ZrmirPaGOUaX4mLRf5zObTfw9Ll0xDlhK7DY1lWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DetB4lMCYSGFHbQ+S23R1nmvP6AkNk5bezLoeuNo2NQ=; b=h81WCsFZthOa9TZtRLQfeHFDvD/QJEonb5RqdioAp6nVhSMKyWiatu3BlTi/uQvSvnT1EbG9ce9uFGuHFZzbby4gHzIOXEkez4g2lnCmH7DO6YiNkd4caR9mDBDpNqaOKKaxzihBqrcEbIw6udJdjl7AM65kkHtHiTZxscFMUAgnfmgSlJTaP8axt49B7MhvErq/L4TakHSXMcxo3K2pHkzs1YYSHh0mlY5Dv6PijnnubTp2WyXAIm9d4jtIt9TQA5tgHPSLzzVl4Fg2ucDC9ECMbPIUfM8mmEH3+qIwWyD2iJK9NVtZBCt9cpwhBGoVJVatuEbVGdQdlbS9x63lVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DetB4lMCYSGFHbQ+S23R1nmvP6AkNk5bezLoeuNo2NQ=; b=CjYW9OA5MiITfPRLeAQJdBtRhIIzXkoXUeLTsylRqosW0eZ5fT1/96spS8RcdECNGzla6LAu1pnAvPEJws6jZTKutIQh25/plhP6g5Q+g2qq6lLH30tl6Z2xbjAY2McqQ7OhYemVvH39LQAyf05iqCUlnd9hdLqPZ2TydNKt76c= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v2 06/17] xen/arm: Add boot and secondary CPU to NUMA system Date: Tue, 10 Jan 2023 16:49:19 +0800 Message-ID: <20230110084930.1095203-7-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230110084930.1095203-1-wei.chen@arm.com> References: <20230110084930.1095203-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: VI1EUR03FT017:EE_|GV2PR08MB7956:EE_|AM7EUR03FT020:EE_|AS8PR08MB6023:EE_ X-MS-Office365-Filtering-Correlation-Id: 6f6f6376-5ef1-4973-1930-08daf2e84397 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: aS+J3UKHWPXZoOTlJwyBHwOsVJ8zE3h4K0qY36ZEiw2IY+Pf0ED6kCVnVdrfC3unMz2KM62mpTtbZGeTF2tO844Xu5iSI77dqUiNvIcDSksnfQm4W5a54jG2UWxMUqRhN/8y2cbCOO7KzZgxsUYw2OTODNt2KxKSW1GL/dd8BXbVfeWLfkBaYRx1GsyTx3fRSnP0vliGuhPOfm6Uj90dzBoK5WXhM6jK8xHkNp6I/3GkF8FBT2+8LVWzT6V5L7/BdWt5tgkT+NF8lO/XqMsMCzGAcYHBulTSI9sMpTL1WlJq8vq21WNnH6O382DhiAxKjDms9TEI0cVbHKYvAlMXgw5xZKE0MhfvYAB0ehXEJEf+kGwocVHSKRmC+JmALb7HgclQc0zOpr0Y4wK7Z6J47zig7oH9BNc6za4jUITLZS80c41auYKQGMM+hz6vsVPrATH3uWlTn6jSBXUQLEKlneWG/RfUcBmQ42/wumqIqFcQFIxdN3LkROU3Ia/Hm/wOrXTE9n/5MXq17US2Z/fSvC8enSE8W8TaehuJZwu+GH1HHGFGxFFRDer+1e27bxQk3VCzf0xW1TuXpMUUcHKFMzhgAzCss6iuLiwryEdEQxcaENeVT+T6JW7P32ihYAWTNNRO/XJwrbD5IiiQ9jEjesuG9BujlpUW0yoiy0Dd/XrNI23Qro0pJgJD75sZ7dZ0HCEw+/Gtz1XSyi6IeH8GzQ== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(396003)(136003)(346002)(451199015)(46966006)(36840700001)(83380400001)(426003)(82310400005)(47076005)(316002)(86362001)(54906003)(6916009)(40480700001)(36756003)(7696005)(356005)(81166007)(82740400003)(186003)(336012)(26005)(2616005)(1076003)(2906002)(44832011)(478600001)(6666004)(5660300002)(8936002)(36860700001)(70206006)(41300700001)(4326008)(70586007)(8676002)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB7956 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT020.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: aa82329a-87e4-4135-0f00-08daf2e83c93 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GVNyi/5bICXOl0fQBUzMg1x3cmPpCFtJw1r5zASEgFs6re1mKVZzDYlPhnlISFnO20hcGGp9WdGRpt8cBiN5mqbxMTbnibjBg5+A3doKjH7phhCZUAN3EMUTHCGLeiGa37yCYgz9jVIADZHeNS/mCWtZHXV9DcsN220hgGwBG1PbJfvJ6YoUwG5NSZU7JAT4dRQQmENeYUCTtyubhYZ86YOuA4vv68LL+suzLAuLLQzt2SrpTPzWUJKxqlsUOvDEJzxgjkIkiilEHW+DM+PR7vS0e37UGHU2qTL3uL3Mr0cadlgJUqntvn2Xfr/m3CQgzRBh9pfsh/JmwIkRmzMltqFAWablQ2BECaoWBfd7Mtf9BKPm3JCCGJIhbtKC4Jykh/b2j1I+0Xt9pdehD5hNrOzZJl3Rz/NyJcdcUKg/YmSvV5TmVBnwHPum+RE6+FJncXSSfi2yZPej0K685FI3AWGBX+TUSllKkBKvOQ45FV7jp76hiDRQozKq0iTOcRDTSF9/OSN8RvSy1g06dNvf7mGqll1QYiFWXRZAVJNf7zwc8MMEmcWeh8499mhp/Gb2nHCQ+QmtoDIe9CSpROXuRytyWUbhHBZDtSg+CrHT4ITNGbzjlVFUirAgpVRE8VpAVHpVIBobu39YZear4q+wcuzpyfcTqO8AxPdYFNvqxdJRSdfV4KBPN2SPMtcEo74pSs+ya6tk1yQxao1DJwwhYw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(136003)(39860400002)(396003)(451199015)(46966006)(40470700004)(36840700001)(5660300002)(44832011)(8936002)(41300700001)(2906002)(36756003)(54906003)(83380400001)(8676002)(70586007)(70206006)(4326008)(316002)(6916009)(7696005)(26005)(81166007)(186003)(6666004)(86362001)(478600001)(107886003)(336012)(1076003)(2616005)(40480700001)(47076005)(82740400003)(426003)(82310400005)(36860700001)(40460700003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2023 08:54:20.6031 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6f6f6376-5ef1-4973-1930-08daf2e84397 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT020.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6023 In this patch, we make NUMA node online and add cpu to its NUMA node. This will make NUMA-aware components have NUMA affinity data to support their work. To keep the mostly the same behavior of x86, we use numa_detect_cpu_node to online node. The difference is that, we have prepared cpu_to_node in dt_smp_init_cpus, so we don't need to setup cpu_to_node in numa_detect_cpu_node. Signed-off-by: Wei Chen --- v2 -> v3: 1. Use unsigned int instead of int for cpu id. 2. Use static inline for stub to do type check. v1 -> v2: 1. Use numa_detect_cpu_node to online node. 2. Use macros instead of static inline functions to stub numa_detect_cpu_node. --- xen/arch/arm/include/asm/numa.h | 9 +++++++++ xen/arch/arm/numa.c | 10 ++++++++++ xen/arch/arm/setup.c | 5 +++++ 3 files changed, 24 insertions(+) diff --git a/xen/arch/arm/include/asm/numa.h b/xen/arch/arm/include/asm/numa.h index 3bc28416b4..e0c909cbb7 100644 --- a/xen/arch/arm/include/asm/numa.h +++ b/xen/arch/arm/include/asm/numa.h @@ -41,6 +41,7 @@ enum dt_numa_status { extern void numa_set_distance(nodeid_t from, nodeid_t to, unsigned int distance); +extern void numa_detect_cpu_node(unsigned int cpu); #else @@ -74,6 +75,14 @@ static inline void numa_set_node(unsigned int cpu, nodeid_t node) { } +static inline void numa_add_cpu(unsigned int cpu) +{ +} + +static inline void numa_detect_cpu_node(unsigned int cpu) +{ +} + #endif #define arch_want_default_dmazone() (false) diff --git a/xen/arch/arm/numa.c b/xen/arch/arm/numa.c index dcfcd85fcf..4dd7cf10ba 100644 --- a/xen/arch/arm/numa.c +++ b/xen/arch/arm/numa.c @@ -74,6 +74,16 @@ void __init numa_set_distance(nodeid_t from, nodeid_t to, node_distance_map[from][to] = distance; } +void numa_detect_cpu_node(unsigned int cpu) +{ + nodeid_t node = cpu_to_node[cpu]; + + if ( node == NUMA_NO_NODE ) + node = 0; + + node_set_online(node); +} + unsigned char __node_distance(nodeid_t from, nodeid_t to) { /* When NUMA is off, any distance will be treated as remote. */ diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 1f26f67b90..8c02cf6cd4 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -1115,6 +1115,11 @@ void __init start_xen(unsigned long boot_phys_offset, for_each_present_cpu ( i ) { + /* Detect and online node based on cpu_to_node[]. */ + numa_detect_cpu_node(i); + /* Set up node_to_cpumask based on cpu_to_node[]. */ + numa_add_cpu(i); + if ( (num_online_cpus() < nr_cpu_ids) && !cpu_online(i) ) { int ret = cpu_up(i); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Jan 10 08:54:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 08:54:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474446.735686 (Exim 4.92) (envelope-from ) id 1pFAOt-0000bL-6k; Tue, 10 Jan 2023 08:54:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474446.735686; Tue, 10 Jan 2023 08:54:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFAOt-0000b3-1n; Tue, 10 Jan 2023 08:54:31 +0000 Received: by outflank-mailman (input) for mailman id 474446; Tue, 10 Jan 2023 08:54:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFAOr-0005s6-Jv for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 08:54:29 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2074.outbound.protection.outlook.com [40.107.105.74]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 62a65bd2-90c4-11ed-91b6-6bf2151ebd3b; Tue, 10 Jan 2023 09:54:26 +0100 (CET) Received: from DB8PR06CA0045.eurprd06.prod.outlook.com (2603:10a6:10:120::19) by DBAPR08MB5861.eurprd08.prod.outlook.com (2603:10a6:10:1a3::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 08:54:23 +0000 Received: from DBAEUR03FT011.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:120:cafe::32) by DB8PR06CA0045.outlook.office365.com (2603:10a6:10:120::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:54:23 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT011.mail.protection.outlook.com (100.127.142.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:54:23 +0000 Received: ("Tessian outbound 3ad958cd7492:v132"); Tue, 10 Jan 2023 08:54:23 +0000 Received: from f4bffd900317.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 3AA26FAB-2024-4733-AA56-034F6642273B.1; Tue, 10 Jan 2023 08:54:16 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f4bffd900317.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 10 Jan 2023 08:54:16 +0000 Received: from AM6PR0502CA0059.eurprd05.prod.outlook.com (2603:10a6:20b:56::36) by AS2PR08MB8973.eurprd08.prod.outlook.com (2603:10a6:20b:5f9::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 08:54:13 +0000 Received: from AM7EUR03FT064.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:56:cafe::93) by AM6PR0502CA0059.outlook.office365.com (2603:10a6:20b:56::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:54:13 +0000 Received: from nebula.arm.com (40.67.248.234) by AM7EUR03FT064.mail.protection.outlook.com (100.127.140.127) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:54:13 +0000 Received: from AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 10 Jan 2023 08:54:12 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 10 Jan 2023 08:54:12 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.16 via Frontend Transport; Tue, 10 Jan 2023 08:54:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 62a65bd2-90c4-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xRix1bFfBrxEVUq1lAzsdtefn4r0M5T6xXFzQdn7bOs=; b=TByQ2A56Oj+s/Q6qPo4M1+1wWWTRJP8X2fVKh+IQHP3B/WKRsvf9jZ0VlDv6ES1VuxwSYkTmrlYSM2rmhGWmyKcpf599z/IdUUejg4sHtk0DXfXcQPbq4bJGpYibW9qv9153PefoZpFiCU6SaXKczprLOBeENXiyJcyospIs78s= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 85e75a5faba983db X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iQbR3ZzRCvzDAoHp4L9ive+hsvhmUcqg97wd8xHLFRBHE3Jn3bTCmj7Za8dhzUoKW88Qi2CWZKqrsILSci+3yjTPhGpVmEFXMMtQprrYJ+M0ZTvu5GiPg3VUzSqXPEUsXvtxumzkJ6TMppWGroCmPI0xEYlIh7WfD6JcN7u84KTPaL32/dLOPPp9JgurcUwXFYuTV5BuShvQJvJ+K/rlnSl8hVrMoswB4ZIrELS5JoNY1uJJhaC3Px7VeceMkdh3w5slb35hMzFHB52ARVo3vrMvwi8RFtE3Bdf8F+KRpVpQFuX3FVjCAWNuOOO1bJ3j5MdXk8NoJriGVlySeufdXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xRix1bFfBrxEVUq1lAzsdtefn4r0M5T6xXFzQdn7bOs=; b=GYLnOcdNRdhrW+SrPEnQPEETok8PHeTjMS+JWMVVMnv362bV++O/JD2R1SgpR9sJcnEjHA2X/k//u0XOFohBE+9woEiaYne/3gDmOlOLdlLhQ7K6cy9t0darbqAfdaogW3/9x1lh3BgqMn+Y9G2BPuTSwpcDkDIR2cqZ9kvfDFEIuXUAi4wcmFwH9hbZoOzYgqvvpUgqau4PHj63pk7gS00J71Gkzdm4XT7dZUNUOmST/E302/2eZJ0eyXioCFDsVS76zdYtXRbyK+FaZIbnzrwWLHCEMAqour7rQcRBBJn5aTJ7zICVU/Y2RQ2kYVlbYf/wWFxv1xY61j0KFtRzbQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xRix1bFfBrxEVUq1lAzsdtefn4r0M5T6xXFzQdn7bOs=; b=TByQ2A56Oj+s/Q6qPo4M1+1wWWTRJP8X2fVKh+IQHP3B/WKRsvf9jZ0VlDv6ES1VuxwSYkTmrlYSM2rmhGWmyKcpf599z/IdUUejg4sHtk0DXfXcQPbq4bJGpYibW9qv9153PefoZpFiCU6SaXKczprLOBeENXiyJcyospIs78s= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v2 10/17] xen/arm: unified entry to parse all NUMA data from device tree Date: Tue, 10 Jan 2023 16:49:23 +0800 Message-ID: <20230110084930.1095203-11-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230110084930.1095203-1-wei.chen@arm.com> References: <20230110084930.1095203-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: AM7EUR03FT064:EE_|AS2PR08MB8973:EE_|DBAEUR03FT011:EE_|DBAPR08MB5861:EE_ X-MS-Office365-Filtering-Correlation-Id: b7d5f511-aa9a-4fd2-2bbe-08daf2e84513 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: eDEPRIrXslnvkQzfPCa7Vo7kc3fEslyGVOTpJ8Nu4WNjk9ENPS73j6L7txDMvh7u821zMtsxApJG9MCb5dblNLZLoTAgF5G2NM39iAhYUA7/JcPFMc7fCVzosCky4iqIR3OGSQ7IzScGPMFKYSVQ3D7gfo6Lc22Izc7GJVUJa3uM+1K+avAFhcKpHNWUbXWUd9sLCOrPnA3geNPbJznX/ahBG27r/ebviWuXneoJxJv/tTAowbPUaF0ybLyutx2WtiD55kPaRJkQjcfMGGJtoH43286ppH+D8gEI/7PgfTrGExzuLGKr/xq559QvzMnAdA9hK3o49gyD3ATEu+zr35+GRlU3StarhgiMKDubpES0ku7/4SrzI6YRMukxd3fyNz5+VJWnDfFrWH1Pcj54X2JhpdWs1KvEq2nqwqC3F/XGDHekgNoJUrVAfjeDu+rvtoPydCA2I/z/jt18rN5eYpuWEXI3Y/prPboUmlXFm1Z9rge6tm2bBI4KRHzc+ykw7LOZtauYcV7oJf+H5TnpEUwCDHMNgq0nxBCuQKnz7EGduf7bbQ1C836zIVGlR6nl/GiJGLMYWOq1XB8p039G2PjUbufRJ0RYL3WdYWPh+jy2bXgCfYE+xX887MD+F6uPDwdPA95kFVcZ/LthRgijhR/FXmdIWvFZq+tcUhQGT+jviu3PILC+KBQ/cMQKxjqmSY69T4MbGZY69osAfC20Pw== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(346002)(136003)(376002)(451199015)(36840700001)(46966006)(82310400005)(36860700001)(478600001)(83380400001)(5660300002)(36756003)(54906003)(44832011)(2906002)(86362001)(82740400003)(8676002)(4326008)(6916009)(426003)(41300700001)(2616005)(1076003)(6666004)(40480700001)(186003)(26005)(336012)(70206006)(316002)(356005)(70586007)(47076005)(7696005)(8936002)(81166007)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB8973 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT011.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 5fb67014-4de0-43c8-fbb0-08daf2e83f34 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cMzoiPRsPavEwZ/zgF2cTpX8F7zk8zzKFzSN7Db5mKz2Wn4wLhak1nod52Oqz86buv1TNLZq9L7rc6+soQoYnV694g/lrhmDy5hYiOPdSur3GZXp4PRhtA++LN5lHmKGDPt+L/qcSCsJvZUUcaH1abkF3mN8USAI+fj7HjisGPty55nMx/wzjWtq9C8mBo45hNz9HxJ45fxSDuOOAUQZArsGr5BKkPsb+eCxfz/itAaQFnvTQzrZg6+oeeG0Lj6pCSOazIrAwDe1z4QE2Aix+A06XM3i1I2TbkjGmIIi5utxqwVcblAP5bVla+ySyM8dmvRRCNonwv+HlONUL2mVaY08K0mnioNvCZwPdqWeCTQ5de/XgrZsdfHf0d4FhIWxQmhagn14l0SFoldmWOfWgHhkLfL8Bj0JWPptGoMdc5L3gHXqVmR7OpHEUpCsMOY+GQZFJ2hf/S+xSChODfIN3SOZei4iO0HlnAm8dc5iae1GVqDinvEnclE3rIGJhtHMprAYnsMQ7Pr+07UiCabvJWIhBjwN5ZXYBNiQyEWCRtxnwEYMsbP2ClORnUTz7STxy2r06VYj7zDn65kOr8ocqmcTq3bWu98ElD95U4SWtmIejoN/xYJ33XpqVynS4XjO017D14X9ZJLvFbnDaQDngqGvr4G5ebXB3lC6UUw4O1W74SHQfKzKa6z2BKnvAJUjCLbTr6/MEdrPnBoDvJI+nQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(376002)(136003)(346002)(451199015)(40470700004)(46966006)(36840700001)(70586007)(70206006)(83380400001)(8676002)(4326008)(5660300002)(7696005)(36756003)(8936002)(41300700001)(186003)(40480700001)(81166007)(26005)(6666004)(54906003)(6916009)(82740400003)(107886003)(426003)(82310400005)(47076005)(316002)(86362001)(40460700003)(1076003)(478600001)(2616005)(336012)(44832011)(2906002)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2023 08:54:23.1565 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b7d5f511-aa9a-4fd2-2bbe-08daf2e84513 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT011.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5861 In this function, we scan the whole device tree to parse CPU node id, memory node id and distance-map. Though early_scan_node will invoke a handler to process memory nodes. If we want to parse memory node id in that handler, we have to embed NUMA parse code in that handler. But we still need to scan whole device tree to find CPU NUMA id and distance-map. In this case, we include memory NUMA id parse in this function too. Another benefit is that we have a unique entry for device tree NUMA data parse. Signed-off-by: Wei Chen --- v1->v2: 1. Fix typos in commit message. 2. Fix code style and align parameters. 3. Use strncmp to replace memcmp. --- xen/arch/arm/include/asm/numa.h | 1 + xen/arch/arm/numa_device_tree.c | 30 ++++++++++++++++++++++++++++++ 2 files changed, 31 insertions(+) diff --git a/xen/arch/arm/include/asm/numa.h b/xen/arch/arm/include/asm/numa.h index 923ffbfd42..1213d30ce0 100644 --- a/xen/arch/arm/include/asm/numa.h +++ b/xen/arch/arm/include/asm/numa.h @@ -44,6 +44,7 @@ extern enum dt_numa_status device_tree_numa; extern void numa_set_distance(nodeid_t from, nodeid_t to, unsigned int distance); extern void numa_detect_cpu_node(unsigned int cpu); +extern int numa_device_tree_init(const void *fdt); #else diff --git a/xen/arch/arm/numa_device_tree.c b/xen/arch/arm/numa_device_tree.c index 88056e7ef8..4009b9b6de 100644 --- a/xen/arch/arm/numa_device_tree.c +++ b/xen/arch/arm/numa_device_tree.c @@ -258,3 +258,33 @@ invalid_data: numa_fw_bad(); return -EINVAL; } + +static int __init fdt_scan_numa_nodes(const void *fdt, int node, + const char *uname, int depth, + unsigned int address_cells, + unsigned int size_cells, void *data) +{ + int len, ret = 0; + const void *prop; + + prop = fdt_getprop(fdt, node, "device_type", &len); + if ( prop ) + { + if ( strncmp(prop, "cpu", len) == 0 ) + ret = fdt_parse_numa_cpu_node(fdt, node); + else if ( strncmp(prop, "memory", len) == 0 ) + ret = fdt_parse_numa_memory_node(fdt, node, uname, + address_cells, size_cells); + } + else if ( fdt_node_check_compatible(fdt, node, + "numa-distance-map-v1") == 0 ) + ret = fdt_parse_numa_distance_map_v1(fdt, node); + + return ret; +} + +/* Initialize NUMA from device tree */ +int __init numa_device_tree_init(const void *fdt) +{ + return device_tree_for_each_node(fdt, 0, fdt_scan_numa_nodes, NULL); +} -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Jan 10 08:54:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 08:54:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474450.735697 (Exim 4.92) (envelope-from ) id 1pFAOv-0000yq-HB; Tue, 10 Jan 2023 08:54:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474450.735697; Tue, 10 Jan 2023 08:54:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFAOv-0000yX-CQ; Tue, 10 Jan 2023 08:54:33 +0000 Received: by outflank-mailman (input) for mailman id 474450; Tue, 10 Jan 2023 08:54:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFAOt-0005s6-KG for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 08:54:31 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2080.outbound.protection.outlook.com [40.107.21.80]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 64a89fc5-90c4-11ed-91b6-6bf2151ebd3b; Tue, 10 Jan 2023 09:54:29 +0100 (CET) Received: from AS9PR0301CA0031.eurprd03.prod.outlook.com (2603:10a6:20b:469::31) by DBBPR08MB5994.eurprd08.prod.outlook.com (2603:10a6:10:20d::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 08:54:28 +0000 Received: from AM7EUR03FT005.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:469:cafe::b8) by AS9PR0301CA0031.outlook.office365.com (2603:10a6:20b:469::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:54:28 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT005.mail.protection.outlook.com (100.127.140.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:54:27 +0000 Received: ("Tessian outbound 6e565e48ed4a:v132"); Tue, 10 Jan 2023 08:54:27 +0000 Received: from bf9eea3806c2.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 09505C98-CD7C-42E8-8219-4CA26EC3D753.1; Tue, 10 Jan 2023 08:54:22 +0000 Received: from EUR03-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id bf9eea3806c2.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 10 Jan 2023 08:54:22 +0000 Received: from FR3P281CA0138.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::17) by PAVPR08MB9796.eurprd08.prod.outlook.com (2603:10a6:102:2f8::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 08:54:19 +0000 Received: from VI1EUR03FT039.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:95:cafe::60) by FR3P281CA0138.outlook.office365.com (2603:10a6:d10:95::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.11 via Frontend Transport; Tue, 10 Jan 2023 08:54:19 +0000 Received: from nebula.arm.com (40.67.248.234) by VI1EUR03FT039.mail.protection.outlook.com (100.127.144.77) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:54:18 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 10 Jan 2023 08:54:17 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.16 via Frontend Transport; Tue, 10 Jan 2023 08:54:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 64a89fc5-90c4-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0tafurYy+S0foZPSXVs4MXxTgGOhH6a719Sg+5VUNEA=; b=5/AeyROb+LeKOthAZWhDuLaaOHSdhHoqXe89J+OFwYmqaEHJbQ/p26ThxEdc7/oeHPuOc2WIbPW3IHdbJMS0SvF18Vbd+UMyH1PGVR6Yzq1OFIiafVYEWOnCoPZYnm9uDaCatD3x81Uh2oP/4KHrvvQnA9UgBFTO4xlJG0iIw3Y= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 827b35e3b0659489 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Yd640jTkooDsJVKnYpwGL2IyfeIc+q89tWKjGoRO2+++EWCtkw0cL5hOIvZ4TA9Oswvxi9QZYzLw5m73tnIV/FNqnfLkD5k54IpA33ovMJQytgg6n43eMZ20W+43lOCkWbNhs1YI4gDMz1O0TmQWyzXRjL7TJuvt4A7lLqHnlhJbb2wI2x3L5iJjYw8fSjw1M6R274S76TuxjHLtIxlGypGK8yEQCZNizc11d0Z9GIZfZMOwjit6EAHk8aNpiC71GVNyR74jwilKOHFI9E8+ocCKHC/FJy5f/1eVmIdDEEiQh/iaM3k6SrOp55qd1gQ9N/47akDEs2N3y2aHO1p6/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0tafurYy+S0foZPSXVs4MXxTgGOhH6a719Sg+5VUNEA=; b=nsX61tnhkj6pgZa0K1lwVigNsujVBQSGZLIL+b1pqLR3UVX5bK3GejX/Xr1HJkvkxHZmZ3SZbyfGMg9qzb1qQtxbDqDCIEVQwE6/Xb9n7zHMohOVJBHRtvHhrx9T68KcUvC3vk/wFXclGyAj/4bu84rr8iCWuv9ciX3go+eNbrhDY6u6ifpEB738nOiDLDz7FMf8/dzU6EbYx56W1NVj69yjoaQOL11EgBmLKyJKwClLLNXgY4HpW1p9uJn/F2MsV4k6VClknhWz0DM9UeY05Z7xAgSqEJlxBWUhiE1ouXeIZLywVzj/NqWZrYAlxBmVTsQQu5sgPgEv4qZZs9mUXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0tafurYy+S0foZPSXVs4MXxTgGOhH6a719Sg+5VUNEA=; b=5/AeyROb+LeKOthAZWhDuLaaOHSdhHoqXe89J+OFwYmqaEHJbQ/p26ThxEdc7/oeHPuOc2WIbPW3IHdbJMS0SvF18Vbd+UMyH1PGVR6Yzq1OFIiafVYEWOnCoPZYnm9uDaCatD3x81Uh2oP/4KHrvvQnA9UgBFTO4xlJG0iIw3Y= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v2 12/17] xen/arm: enable device tree based NUMA in system init Date: Tue, 10 Jan 2023 16:49:25 +0800 Message-ID: <20230110084930.1095203-13-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230110084930.1095203-1-wei.chen@arm.com> References: <20230110084930.1095203-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: VI1EUR03FT039:EE_|PAVPR08MB9796:EE_|AM7EUR03FT005:EE_|DBBPR08MB5994:EE_ X-MS-Office365-Filtering-Correlation-Id: 138bac64-1cf9-491f-337e-08daf2e847fe x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: tFL1VHCIgog4EcjhUb5e1C+fl4yWwZDlNsu8Lz4J9UzPyTrIpY1uVdEg0imcGH7oFjObb43VZurc+6X6FrLeCPzSySIhqtzQpr0O1vlO7wFm+PcKfpysIGh7hZQxoPCXo+x+sfAhBz8P+T6ZWOqKOV/JTPGJ3BJhLnRZDb/k8UqIZsIByPeBtvqHFkRi1bqODETcn81a5Wpmyl6ngrPu/55Z+BHU6inJxr0fH+FLIWktwzc+/9FnDXROzYIPb6/h/QUp0/Reut6ORPGTksBog7vZeHWGoNhX7liMo7MIHvJX/WLe9Ur9z8nLc3XoHqE9cQgbj8GfWPprC1yeDIaBXsY+a09dQqFoiwB3hyrFwRbmpO5FXYbUq2X8uK2TZyw7lmJIAbAg8c7FJtmXf3oKwnRsWGxBb+u8HR65vz1IIHq3+BiVkYSiOpNkV0r12daMObaizryWLKHrKQbmCIUJihlVNc2cT97UkDnLodmbaD2PokC5lGr52/k9tdM034PDcsIddHvOZYQ9rl91Eg+G4H+4q6l2UJnqESKlHydVsDEmuAFC18iI95nwkgocrIublHEt2tXXhi+P2u9aCAnsQYmfS/RMMRzQqd73/eSykzhhdrcNveij7+SLgOMZezcGGB2he0cU1xpPFn9PHyDoxt1Q+irKC9SvAhq7bnsBkyCM91nPliiiADnWDy0joenzTQ2buVtU/KNwhOQzTriM/Q== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(39860400002)(396003)(136003)(451199015)(36840700001)(46966006)(6916009)(356005)(54906003)(82310400005)(41300700001)(478600001)(2906002)(316002)(82740400003)(6666004)(36860700001)(44832011)(336012)(1076003)(83380400001)(4326008)(8676002)(86362001)(186003)(26005)(40480700001)(7696005)(5660300002)(36756003)(2616005)(81166007)(70206006)(70586007)(47076005)(426003)(8936002)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9796 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: df9ab331-527d-4f18-6fef-08daf2e84297 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /AuKOjvJa5ALwIqEwyKhhk9yBW10GhuhWy/H3Qr9VfJd045mSfOaRD2Z8dW65j2KsiDwNzi5W1k+us/bJbxxETGL1jcmauSeo5bp5wtu4M/QMuwBuovrDbFaLmAaq7btrIu7FTX2oPSEXzsYY3ELTz8DCj6ry8P1Lq/lRJ/kEv/Xi9H9CoUjgu9g7b82jxKRv+G7F3N+1+d2O/DWgENB/64WWGMN47+FAHCt597r7PSyQ9upCLeHlAuGlmjVKGXOG9lrT5pGVL1MCXZ34z8OMisLGUPb6Uw+nvTPRc/EDtYw7d9MZY78rp2h4uUreN2+X10NvdDXd9ofU6WWtxbSjQ4p9QwaEAH5BgBHrnofcYTawVMeqNcsUDMFmUgiBZtwfOkcdnlPD89JK8PhMYvFihBoowAGBRTYiuZPlphwoXBz+HBhliGKy8a8jrM6I00xybKp6TMAJA0xXyVfstIHcPZVycLtyLxRcTINf3clhwt2MzSG5wLyUssAF2wXEkiKw/FTJE80dmTG3Q19+lq1jHcTNig7K51hbjVk3sX1d30mFG+TfFj6u5g+Led3/HMeI6OXp2hn7Z5vGe/cco5iJu4lUpnbGuXf+VTpSa0EuFhEBRPhPO2hiRQKOA8tjzr3CxjLvTR7Gvj4YIeNNy2OjuOb+ca6Bec7imD3PfwLIAHz5CmsMXS73ArJSvrsDB4fHte/gWHGYRkj/36EpoaMWw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(396003)(346002)(376002)(451199015)(36840700001)(46966006)(40470700004)(8676002)(8936002)(4326008)(41300700001)(82310400005)(70206006)(70586007)(5660300002)(86362001)(40480700001)(6666004)(82740400003)(107886003)(316002)(2906002)(54906003)(6916009)(44832011)(36756003)(81166007)(36860700001)(40460700003)(478600001)(1076003)(7696005)(83380400001)(47076005)(426003)(26005)(2616005)(186003)(336012);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2023 08:54:27.9897 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 138bac64-1cf9-491f-337e-08daf2e847fe X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB5994 In this patch, we can start to create NUMA system that is based on device tree. Signed-off-by: Wei Chen --- v1->v2: 1. replace ~0 by INVALID_PADDR. 2. only print error messages for invalid dtb data. 3. remove unnecessary return. 4. remove the parameter of numa_init. --- xen/arch/arm/include/asm/numa.h | 5 +++ xen/arch/arm/numa.c | 57 +++++++++++++++++++++++++++++++++ xen/arch/arm/setup.c | 7 ++++ 3 files changed, 69 insertions(+) diff --git a/xen/arch/arm/include/asm/numa.h b/xen/arch/arm/include/asm/numa.h index 1213d30ce0..34eec9378c 100644 --- a/xen/arch/arm/include/asm/numa.h +++ b/xen/arch/arm/include/asm/numa.h @@ -45,6 +45,7 @@ extern void numa_set_distance(nodeid_t from, nodeid_t to, unsigned int distance); extern void numa_detect_cpu_node(unsigned int cpu); extern int numa_device_tree_init(const void *fdt); +extern void numa_init(void); #else @@ -86,6 +87,10 @@ static inline void numa_detect_cpu_node(unsigned int cpu) { } +static inline void numa_init(void) +{ +} + #endif #define arch_want_default_dmazone() (false) diff --git a/xen/arch/arm/numa.c b/xen/arch/arm/numa.c index 3e02cec646..e9081d45ce 100644 --- a/xen/arch/arm/numa.c +++ b/xen/arch/arm/numa.c @@ -18,7 +18,11 @@ * */ #include +#include +#include #include +#include +#include enum dt_numa_status __read_mostly device_tree_numa; @@ -103,6 +107,59 @@ unsigned char __node_distance(nodeid_t from, nodeid_t to) EXPORT_SYMBOL(__node_distance); +void __init numa_init(void) +{ + unsigned int idx; + paddr_t ram_start = INVALID_PADDR; + paddr_t ram_size = 0; + paddr_t ram_end = 0; + + /* NUMA has been turned off through Xen parameters */ + if ( numa_off ) + goto mem_init; + + /* Initialize NUMA from device tree when system is not ACPI booted */ + if ( acpi_disabled ) + { + int ret = numa_device_tree_init(device_tree_flattened); + if ( ret ) + { + numa_off = true; + if ( ret == -EINVAL ) + printk(XENLOG_WARNING + "Init NUMA from device tree failed, ret=%d\n", ret); + } + } + else + { + /* We don't support NUMA for ACPI boot currently */ + printk(XENLOG_WARNING + "ACPI NUMA has not been supported yet, NUMA off!\n"); + numa_off = true; + } + +mem_init: + /* + * Find the minimal and maximum address of RAM, NUMA will + * build a memory to node mapping table for the whole range. + */ + ram_start = bootinfo.mem.bank[0].start; + ram_size = bootinfo.mem.bank[0].size; + ram_end = ram_start + ram_size; + for ( idx = 1 ; idx < bootinfo.mem.nr_banks; idx++ ) + { + paddr_t bank_start = bootinfo.mem.bank[idx].start; + paddr_t bank_size = bootinfo.mem.bank[idx].size; + paddr_t bank_end = bank_start + bank_size; + + ram_size = ram_size + bank_size; + ram_start = min(ram_start, bank_start); + ram_end = max(ram_end, bank_end); + } + + numa_initmem_init(PFN_UP(ram_start), PFN_DOWN(ram_end)); +} + int __init arch_get_ram_range(unsigned int idx, paddr_t *start, paddr_t *end) { if ( idx >= bootinfo.mem.nr_banks ) diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 8c02cf6cd4..4cdc7e2edb 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -1031,6 +1031,13 @@ void __init start_xen(unsigned long boot_phys_offset, /* Parse the ACPI tables for possible boot-time configuration */ acpi_boot_table_init(); + /* + * Try to initialize NUMA system, if failed, the system will + * fallback to uniform system which means system has only 1 + * NUMA node. + */ + numa_init(); + end_boot_allocator(); /* -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Jan 10 08:55:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 08:55:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474465.735708 (Exim 4.92) (envelope-from ) id 1pFAPX-0002uf-5W; Tue, 10 Jan 2023 08:55:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474465.735708; Tue, 10 Jan 2023 08:55:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFAPX-0002uV-2V; Tue, 10 Jan 2023 08:55:11 +0000 Received: by outflank-mailman (input) for mailman id 474465; Tue, 10 Jan 2023 08:55:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFAPE-0005oC-5t for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 08:54:52 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2079.outbound.protection.outlook.com [40.107.104.79]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 706f88ee-90c4-11ed-b8d0-410ff93cb8f0; Tue, 10 Jan 2023 09:54:50 +0100 (CET) Received: from DUZPR01CA0078.eurprd01.prod.exchangelabs.com (2603:10a6:10:46a::20) by AM9PR08MB6034.eurprd08.prod.outlook.com (2603:10a6:20b:2db::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 08:54:47 +0000 Received: from DBAEUR03FT025.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:46a:cafe::fd) by DUZPR01CA0078.outlook.office365.com (2603:10a6:10:46a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:54:47 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT025.mail.protection.outlook.com (100.127.142.226) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:54:47 +0000 Received: ("Tessian outbound b1d3ffe56e73:v132"); Tue, 10 Jan 2023 08:54:47 +0000 Received: from 6209e2cc19c6.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D5B9000A-951A-4E52-BADB-5DAEA1383FC3.1; Tue, 10 Jan 2023 08:54:36 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 6209e2cc19c6.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 10 Jan 2023 08:54:36 +0000 Received: from DU2PR04CA0216.eurprd04.prod.outlook.com (2603:10a6:10:2b1::11) by DU0PR08MB9347.eurprd08.prod.outlook.com (2603:10a6:10:41f::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 08:54:33 +0000 Received: from DBAEUR03FT041.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2b1:cafe::a1) by DU2PR04CA0216.outlook.office365.com (2603:10a6:10:2b1::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:54:33 +0000 Received: from nebula.arm.com (40.67.248.234) by DBAEUR03FT041.mail.protection.outlook.com (100.127.142.233) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:54:32 +0000 Received: from AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 10 Jan 2023 08:54:32 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 10 Jan 2023 08:54:31 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.16 via Frontend Transport; Tue, 10 Jan 2023 08:54:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 706f88ee-90c4-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DCO0fihkDCNBhO3hhRTkyjVzUW8pv9QuwCGAw2orFHo=; b=9snf656RL62LLV3QLMlqWRD1bA5sBjsdFifN0MCcM1kyoGFw0u4By3BaDPFZpUWGBxuJGTnPKzMeXGodh6NujH9l7nphIP6Eqd+Q66122+c0bU1bo1s8HH6/cZfDjCGyX2Wp/YTuQIj3kUd84oShKtt98HWrwzT8KxPCcD+mX70= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: e1e887521e64c94f X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T9RTdtytLXmYRaeWcnThNla6A+vtkm0MCJ05xG4ycM2uUbvMSe+GIjQIwDIuBMNGGsiSYYoCqG3EvEoJYnG21/+bpgpaQonoWoLyQ37gCWZEzaonbkHTs4lWiCVp8Agfgbh6hZVU+WbkmfR0Gfv8TYPumvgu7JZ+NGJ+C3oi8QDJ+cZh8m2JUgd1pv7dgK/z4ytxp03ShKm5fF779FwuCGWEukjPd4saDwnbjo27UVaFQ3YTws98KkmXqAVHS8EugE7iCJYC6wHd2RihHaVgz0DVY4EPmGaRS78nOQ4eZ6COfjSKHCOsYNxuM/L2ukSna+WmE0MhLIrFIUm8/7Fb6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DCO0fihkDCNBhO3hhRTkyjVzUW8pv9QuwCGAw2orFHo=; b=AKNXnO3yPkNYTdleVc27vHUcs8IUpvjA6riOPIOQzNzTCy/8SswijdK/5vpYGBfCsafh1H3twNJnk1CCwCLsDgqr7CAU4A6szPwZg5xtGtZtzzpFqDYmi19loDjJybNI+v3WmNA9ECnb9WeOW6DP+nok58u3qOyQKL4s2/qYkVk74SjCvsyVIloG++ElXl1uU+p709K5GgXlejK/uq1yq7pGBFIqs58T79/XJjwPoQs7lcbn7uPyJ7ePb2HAPOBLr0Luj50TTpJbBK2jhSauzRQMSvz9rBf1f6yGQfFg6oJJ6P8pdfpEwuU1LVG15KdMqdQhYoeTxL2hCQaBKrWEwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DCO0fihkDCNBhO3hhRTkyjVzUW8pv9QuwCGAw2orFHo=; b=9snf656RL62LLV3QLMlqWRD1bA5sBjsdFifN0MCcM1kyoGFw0u4By3BaDPFZpUWGBxuJGTnPKzMeXGodh6NujH9l7nphIP6Eqd+Q66122+c0bU1bo1s8HH6/cZfDjCGyX2Wp/YTuQIj3kUd84oShKtt98HWrwzT8KxPCcD+mX70= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Andrew Cooper , George Dunlap , "Jan Beulich" , Julien Grall , "Stefano Stabellini" , Wei Liu Subject: [PATCH v2 17/17] docs: update numa command line to support Arm Date: Tue, 10 Jan 2023 16:49:30 +0800 Message-ID: <20230110084930.1095203-18-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230110084930.1095203-1-wei.chen@arm.com> References: <20230110084930.1095203-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: DBAEUR03FT041:EE_|DU0PR08MB9347:EE_|DBAEUR03FT025:EE_|AM9PR08MB6034:EE_ X-MS-Office365-Filtering-Correlation-Id: a233f2fa-3505-4379-13df-08daf2e8537d x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: gYqbdJxhb49crfW6S5nQgUv+h9haKLbcdOx/n4owFnl/MnlejUmKJzuoDv9TxMTMd2nmJiuJWa5+joXUP5YDBGOui1hPv84lfTa7sWIbXbSC6I0Fvk44cfW4zfMy/GbupT3hu5m5cIPh1cvcjmz0eos3FzHhakigrI+wVylRLRC9Kq4H6XHoa7xHRjS9BOi43SlGf9awimkKpK00JU4m9TzpOdg6ySIvzemXwa9J3qKu8huTPvXVY2+96r2195eAEX2UxY8cvPjPVY3Ga/YQjDTG1G1yBc2fwFdZpiCIcOr8F0qFhzJI+6zHhBing5sU+zNgFqXHj0l9Z+geGvHzuYZe3dToka/N0eDToAVctWqc1/JPlMKJobJtwyqwl2LfkVZBDcFjB9OxDKw/ks28KyrgThG8QIaVdoA+5DxIlxJZdTCcWh6i66ykzvxwL8WxZRvU8ZQM3rm0TmNcUib1cUxtXUqTlx0qrLmRL5ltx/xD3p/oRn20q2fIySxS8lZQwWRSWKlnI3dMpI10ucFzHF0sEgyWpSBEMzKv7ipwy4nVODBl60RFVEoX0R0I3h7lchCnVgBi8qtbP0IPzykFAwAGlcVt7dIpd5a1eM+JHfI9wTvwhB6W9wcwZ12zLy2UV+pxwyLXpwymxxOTMervjm1JipskKyUZF0JaTKF0qsvhLDPw+PpkWe/QG/HV699R5lEkDhm+1p4WE+S0DVX88Q== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(136003)(396003)(39860400002)(451199015)(36840700001)(46966006)(40480700001)(356005)(36756003)(86362001)(54906003)(478600001)(316002)(15650500001)(44832011)(5660300002)(7696005)(2906002)(8936002)(70206006)(70586007)(36860700001)(8676002)(6916009)(41300700001)(4326008)(82740400003)(81166007)(6666004)(82310400005)(426003)(26005)(186003)(47076005)(1076003)(83380400001)(2616005)(336012)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9347 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT025.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 6b91dd04-ff36-4b04-0c74-08daf2e84adb X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AWhCG1PH88NBGFSOzjFy6h3+pWSWTjsZHeeH0PagxRz8JmgmAnz/Bn08a+oKGxV69CI4uuQAjcmyKwwQ0rl+DHur3AzklMy9KJF8OE+HB4MDHAN6pLWaSMuqcTNO7NjlRpNILT3fNxOS4CEMO9+uxiqcg3O4j1Y7iDupQbU+94oLSc5G6gq58Vax4ksXwInAIyEA6dtKrMAxOZQIKYA9JCJPExRLonvwIRBoypjGr+r5chc1UphkWxgNHGOM2r4olhW9VWUXHFNPT8wv3MS94Md5cVUky67p6Nx/Dl7bKIk9P5sF2wlk0dBYuZhRJaLjbaUspJmvJEOH9oZZ0m4nLM33H4nJWeRzVysttygn4fG+QWOXGvWB8gIwdENrSIU+94Th18vMSO3QgD9smwt6zLSwD+Qdo2cSi/qvFuG0FwqXrvougE1hnlctXXmGmn1KdoJAbUC22CtDMqQtiHdzIzQyp57zh84zHHVsKtwluyH5ucKRcRaGy8cEdehnL6xA9lKVQCMRRLr57fmel57b7fglHtkJBXn5/70+Qfdd2LpZ/7b9DF7u/fx5sLRnawezXlhSWUUX0Jo5frlEcblEzeHiKewvDxR9VeAzX8HsBSCcR7v1U81fe93WFIyJnM5agyuAXJblE1C2ORfOr5+eCxkJWSSI0ZdX6N7be80+yDOjO9sRHk9YS6GIClWQrzEvTRCK/hVK19pJ+pK5Pq7pOA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(396003)(346002)(136003)(451199015)(46966006)(40470700004)(36840700001)(1076003)(336012)(426003)(70586007)(4326008)(47076005)(44832011)(70206006)(8936002)(8676002)(5660300002)(82310400005)(26005)(186003)(2616005)(6916009)(6666004)(86362001)(82740400003)(316002)(15650500001)(36860700001)(54906003)(2906002)(83380400001)(40480700001)(81166007)(36756003)(41300700001)(478600001)(40460700003)(7696005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2023 08:54:47.3386 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a233f2fa-3505-4379-13df-08daf2e8537d X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT025.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6034 Current numa command in documentation is x86 only. Remove x86 from numa command's arch limitation in this patch. Signed-off-by: Wei Chen --- v1 -> v2: 1. Update Arm NUMA status in SUPPORT.md to "Tech Preview". --- SUPPORT.md | 1 + docs/misc/xen-command-line.pandoc | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/SUPPORT.md b/SUPPORT.md index 295369998e..b73d04a028 100644 --- a/SUPPORT.md +++ b/SUPPORT.md @@ -401,6 +401,7 @@ on embedded platforms and the x86 PV shim. Enables NUMA aware scheduling in Xen Status, x86: Supported + Status, Arm: Tech Preview ## Scalability diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc index 923910f553..40da980b67 100644 --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -1878,7 +1878,7 @@ i.e. a limit on the number of guests it is possible to start each having assigned a device sharing a common interrupt line. Accepts values between 1 and 255. -### numa (x86) +### numa > `= on | off | fake= | noacpi` > Default: `on` -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Jan 10 08:55:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 08:55:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474467.735719 (Exim 4.92) (envelope-from ) id 1pFAPY-0003Ac-EC; Tue, 10 Jan 2023 08:55:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474467.735719; Tue, 10 Jan 2023 08:55:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFAPY-0003AT-A1; Tue, 10 Jan 2023 08:55:12 +0000 Received: by outflank-mailman (input) for mailman id 474467; Tue, 10 Jan 2023 08:55:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFAP6-0005s6-5Q for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 08:54:44 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2083.outbound.protection.outlook.com [40.107.7.83]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6c11ee8f-90c4-11ed-91b6-6bf2151ebd3b; Tue, 10 Jan 2023 09:54:42 +0100 (CET) Received: from DB6PR0402CA0024.eurprd04.prod.outlook.com (2603:10a6:4:91::34) by AM7PR08MB5350.eurprd08.prod.outlook.com (2603:10a6:20b:101::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 08:54:38 +0000 Received: from DBAEUR03FT057.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:91:cafe::7e) by DB6PR0402CA0024.outlook.office365.com (2603:10a6:4:91::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:54:38 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT057.mail.protection.outlook.com (100.127.142.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:54:38 +0000 Received: ("Tessian outbound b1d3ffe56e73:v132"); Tue, 10 Jan 2023 08:54:38 +0000 Received: from 046c96facb57.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 28559E46-02F6-4DE6-8E01-5DBAA055C8FF.1; Tue, 10 Jan 2023 08:54:29 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 046c96facb57.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 10 Jan 2023 08:54:29 +0000 Received: from FR0P281CA0052.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::20) by DBAPR08MB5671.eurprd08.prod.outlook.com (2603:10a6:10:1a1::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 08:54:27 +0000 Received: from VI1EUR03FT047.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:48:cafe::ae) by FR0P281CA0052.outlook.office365.com (2603:10a6:d10:48::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.11 via Frontend Transport; Tue, 10 Jan 2023 08:54:27 +0000 Received: from nebula.arm.com (40.67.248.234) by VI1EUR03FT047.mail.protection.outlook.com (100.127.144.198) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:54:27 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 10 Jan 2023 08:54:25 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.16 via Frontend Transport; Tue, 10 Jan 2023 08:54:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6c11ee8f-90c4-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZFycWCyr9eafMdsIRMXDpPfZgceLANbgQsKdH29zQUg=; b=FUgjPEH3SDw0CgNr7/SQou9XAWOj4pzs2LG6xfK7CTKzT+fl9NmbGQ2WAvdWJDAdd/UWS9wwkup5u8/3AUI2eWytTN4kXUJN69bmq/J4+GeyMXIKdG04QsrS3dZJBQrPXAUWpFmMvrTlGoifsmdjtpxbld8UT5fegDKGHD3Wdh8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 8325e71c2a7c0b30 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KlmSe6nJSBejfbUbmXXV7b0fPyc1BbokKF+EBW8tapVmuweOXelR7KLstQ3g8Y5PpR/HR0FnJXbPEWqUaKjDQ6+P+S4hcCjcdGRYWtUxrnlaQG1p+Ftq8KveKUOLY1VlISXdAi9LaGvS53CgT1Hm/6PscyYl5XAx8RdkgqSNdIbvhAwSrhl1ryyL5hoavca3qoF5TobrhtyQg0X4ncWrytQIJab4vhOXCPRYuEbQQVRa7IinOM+9yIqE58FQIA9ZNjgBqed8g9HW3N7KGjvUewco1A95twxwAy7EtzOE9vDJvPMvfMp4+ehtJMlwfK3JqomfZvf6RHDZjerDKSdvMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZFycWCyr9eafMdsIRMXDpPfZgceLANbgQsKdH29zQUg=; b=IeSbP0rIOSno/G6f4Qp2LgoGkCZC49cfkV4eUVi5WoxPHaYApMCrdjZzh6mSGWTM4hBS3I/Uv1/LDM6ULoBE7Q+zjDSePxMfaB13AiFaODMdsEv7VghGVIB9WUHIG77o/PPLb1qNuBpj5L335rJVSZcpiDYSNydf0MwIL1+kP+Hqvn9Y+A/zQVPqRYLmayQrHoo8pxjhGpont7mPoOnfnXfekSTdLtfs6cJIS1yE7opdJPwb5fo6KB/HtVTUUM+aSF7M2Qx3XFYey5giisGDW61CX3rdzb1PqrgCxDmva0PdROvAoKQ9LEd/M+tFKbVKU6rNzhtBPE/SjcdUhy+JEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZFycWCyr9eafMdsIRMXDpPfZgceLANbgQsKdH29zQUg=; b=FUgjPEH3SDw0CgNr7/SQou9XAWOj4pzs2LG6xfK7CTKzT+fl9NmbGQ2WAvdWJDAdd/UWS9wwkup5u8/3AUI2eWytTN4kXUJN69bmq/J4+GeyMXIKdG04QsrS3dZJBQrPXAUWpFmMvrTlGoifsmdjtpxbld8UT5fegDKGHD3Wdh8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Henry Wang , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v2 15/17] xen/arm: Set correct per-cpu cpu_core_mask Date: Tue, 10 Jan 2023 16:49:28 +0800 Message-ID: <20230110084930.1095203-16-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230110084930.1095203-1-wei.chen@arm.com> References: <20230110084930.1095203-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: VI1EUR03FT047:EE_|DBAPR08MB5671:EE_|DBAEUR03FT057:EE_|AM7PR08MB5350:EE_ X-MS-Office365-Filtering-Correlation-Id: 25f7d896-3a2e-4a1b-a068-08daf2e84e16 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 1nVaoo9E+GFvT+cClWsW/NG/w3IzVI+3KObds7Prvv0MZgL3umrok29TqA/gqKByCXR7gsQOZSP85XS5mPn1DKM7qYyWQalFFc6miKFk0Ok/WSXu1GNDvZfdJAEDl7wdS/b3AMB2n6smdTJ8IAomyMO5PDmypf5SMN+0kOP0GeBXd2s+A/WzH4IDhfScDyNSCzzNvvpuyuqrFIf9h6fU4hC2D0d0IO1huIE2Wz+Zc7HoUk6LfUbxlR+hwi/TGbzCGgVBqYQIygKav9jC6HmH1OvpqrpVsev6RdvffLb2r5vdM9oi6YzXfcQxRRZjzJT+5D7N4/9VhdV4E08k0ZXGrsyBkmn8CtNNFsVvScCtalPfHNP3fTW/INL9B4xOZs1WAo3mz2KM/ng76ndQfal0V72PuWyodnn/+ys8+Z0FeD0ZejLEuIAzbqlsBjyqgCJiRY8MAcbB1JuAEgtN4A0Arqwun3/4RhqVcHa7/PCs8M1h4MpGG67qPev9q2DlmplBRHZZVm7qDLA63ng/2bhukBd3n7HWmmSJeO0pf3s71EM81+1tncuYmiq1s3nXgkFWDFPVWGgDxOaWMdbqeBHn6EIUAXhWxo5NdNcQ9VhwRLft19grdmi8iSrir9ELGuE8G0q/KlodOkZ+RVDUUll8wb11+ln9DU/bo412ip0g4KrlkZptPGDeISw8OlW+5c18egnVfp9/h9mXTWTR6OX4Zw== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(396003)(376002)(346002)(451199015)(46966006)(36840700001)(83380400001)(40480700001)(47076005)(44832011)(426003)(82310400005)(36860700001)(5660300002)(336012)(2616005)(356005)(2906002)(81166007)(54906003)(86362001)(8936002)(1076003)(6916009)(316002)(8676002)(36756003)(186003)(4326008)(478600001)(41300700001)(7696005)(70586007)(82740400003)(70206006)(26005)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5671 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT057.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 2dce9913-8214-4290-eb64-08daf2e847ba X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CEB9qhTi6/UWTS54LBvP+c+c/wgi2X12rvajZwqx0nJSbg6b6nWaHG0N43VAohOvXNSkpysg1OAwGB4LjLfz8U6wmYL3eNvVZzwgz3DNwK8ChHBFrC8p60RiWCHkmI8IxqOG4yqgplhY+vwRf07onIdkJdCuNL1gopPlhC5igNk1QWwKGmOYRp9axNix5gzXu2VIv7FfeYHyEE7UjvdnW1nEh7zOiNSAvG8c3fGYyw+Uqf8UKZETFDgzZWnrItsrvbCdDhYlgUPHIjZaOLDQqbIA8CoiX1sgh/QJ9vth/j0jGCXMmePdCcMLd1IsItEYBGstwSiLmJBup+XqL+mX22Je8bj9yWU6yYMV3QtMNdjuo2+sHDx6rpChSic9aW2ccuzkj6g7ZK5uhgbIoNWPxXaseah2qVPPa6DpyDXJsPx7Bh3i3etEK8mL6kd6IO3HoR1rACm2yko7SCy4K7LKIU8ZIrF+GcQYtSZo483OoSHI5EyKIk7D/WEus5UQdCrKRKMbT099DKhEEyuhPHuU9pWScDMEC9GD+By7XvsLiNiq0vG3SZLIQTC3yYsVtEKLutqDhkjzlOBrFGaQoSNKzNXSd478TkjfP6lk1VLj95UxPAaLh1vmeYjYj66if39mOgwqpyCD5cXRabssu61IdR1lMA07A50DVVIKBKoHXwDQlSXz/zkYJgaG6MDh4OK/yqtnjceXVizEJ8zjPWE0Tw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(136003)(396003)(39860400002)(451199015)(36840700001)(46966006)(40470700004)(44832011)(2906002)(5660300002)(36860700001)(7696005)(41300700001)(8936002)(36756003)(70206006)(83380400001)(70586007)(4326008)(8676002)(316002)(47076005)(86362001)(2616005)(336012)(82310400005)(426003)(40460700003)(1076003)(81166007)(478600001)(186003)(40480700001)(26005)(6916009)(54906003)(107886003)(82740400003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2023 08:54:38.2786 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 25f7d896-3a2e-4a1b-a068-08daf2e84e16 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT057.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5350 From: Henry Wang In the common sysctl command XEN_SYSCTL_physinfo, the cores_per_socket is calculated based on the cpu_core_mask of CPU0. Currently on Arm this is a fixed value 1 (can be checked via xl info), which is not correct. This is because during the Arm cpu online process, set_cpu_sibling_map() only sets the per-cpu cpu_core_mask for itself. cores_per_socket refers to the number of cores that belong to the same socket (NUMA node). Therefore, this commit introduces a helper function numa_set_cpu_core_mask(cpu), which sets the per-cpu cpu_core_mask to the cpus in the same NUMA node as cpu. Calling this function at the boot time can ensure the correct cpu_core_mask, leading to the correct cores_per_socket to be returned by XEN_SYSCTL_physinfo. Signed-off-by: Henry Wang --- v1 -> v2: 1. New patch --- xen/arch/arm/include/asm/numa.h | 7 +++++++ xen/arch/arm/numa.c | 11 +++++++++++ xen/arch/arm/setup.c | 5 +++++ 3 files changed, 23 insertions(+) diff --git a/xen/arch/arm/include/asm/numa.h b/xen/arch/arm/include/asm/numa.h index a0b8d7a11c..e66fb0a11f 100644 --- a/xen/arch/arm/include/asm/numa.h +++ b/xen/arch/arm/include/asm/numa.h @@ -46,6 +46,7 @@ extern void numa_set_distance(nodeid_t from, nodeid_t to, extern void numa_detect_cpu_node(unsigned int cpu); extern int numa_device_tree_init(const void *fdt); extern void numa_init(void); +extern void numa_set_cpu_core_mask(int cpu); /* * Device tree NUMA doesn't have architecural node id. @@ -62,6 +63,12 @@ static inline unsigned int numa_node_to_arch_nid(nodeid_t n) #define cpu_to_node(cpu) 0 #define node_to_cpumask(node) (cpu_online_map) +static inline void numa_set_cpu_core_mask(int cpu) +{ + cpumask_or(per_cpu(cpu_core_mask, cpu), + per_cpu(cpu_core_mask, cpu), &cpu_possible_map); +} + /* * TODO: make first_valid_mfn static when NUMA is supported on Arm, this * is required because the dummy helpers are using it. diff --git a/xen/arch/arm/numa.c b/xen/arch/arm/numa.c index e9081d45ce..ef245e39a8 100644 --- a/xen/arch/arm/numa.c +++ b/xen/arch/arm/numa.c @@ -52,6 +52,17 @@ int __init arch_numa_setup(const char *opt) return -EINVAL; } +void numa_set_cpu_core_mask(int cpu) +{ + nodeid_t node = cpu_to_node[cpu]; + + if ( node == NUMA_NO_NODE ) + node = 0; + + cpumask_or(per_cpu(cpu_core_mask, cpu), + per_cpu(cpu_core_mask, cpu), &node_to_cpumask(node)); +} + void __init numa_set_distance(nodeid_t from, nodeid_t to, unsigned int distance) { diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 4cdc7e2edb..d45becedee 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -1136,6 +1136,11 @@ void __init start_xen(unsigned long boot_phys_offset, } printk("Brought up %ld CPUs\n", (long)num_online_cpus()); + + /* Set per-cpu cpu_core_mask to cpus that belongs to the same NUMA node. */ + for_each_online_cpu ( i ) + numa_set_cpu_core_mask(i); + /* TODO: smp_cpus_done(); */ /* This should be done in a vpmu driver but we do not have one yet. */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Jan 10 08:55:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 08:55:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474471.735730 (Exim 4.92) (envelope-from ) id 1pFAPe-0003Yu-PV; Tue, 10 Jan 2023 08:55:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474471.735730; Tue, 10 Jan 2023 08:55:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFAPe-0003Yg-Lr; Tue, 10 Jan 2023 08:55:18 +0000 Received: by outflank-mailman (input) for mailman id 474471; Tue, 10 Jan 2023 08:55:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFAP2-0005s6-6C for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 08:54:40 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2040.outbound.protection.outlook.com [40.107.13.40]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6a8f16e9-90c4-11ed-91b6-6bf2151ebd3b; Tue, 10 Jan 2023 09:54:39 +0100 (CET) Received: from AM5PR1001CA0039.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:206:15::16) by AS2PR08MB9546.eurprd08.prod.outlook.com (2603:10a6:20b:60d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 08:54:31 +0000 Received: from AM7EUR03FT013.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:15:cafe::f8) by AM5PR1001CA0039.outlook.office365.com (2603:10a6:206:15::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:54:31 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT013.mail.protection.outlook.com (100.127.140.191) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:54:30 +0000 Received: ("Tessian outbound 8038f0863a52:v132"); Tue, 10 Jan 2023 08:54:30 +0000 Received: from e1b2afb5b038.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4B3EF0B9-F4C2-42BD-BA0C-7BA60B2A73B3.1; Tue, 10 Jan 2023 08:54:24 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e1b2afb5b038.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 10 Jan 2023 08:54:24 +0000 Received: from FR3P281CA0152.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::6) by AM9PR08MB5972.eurprd08.prod.outlook.com (2603:10a6:20b:280::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 08:54:23 +0000 Received: from VI1EUR03FT037.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:a2:cafe::fa) by FR3P281CA0152.outlook.office365.com (2603:10a6:d10:a2::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.11 via Frontend Transport; Tue, 10 Jan 2023 08:54:23 +0000 Received: from nebula.arm.com (40.67.248.234) by VI1EUR03FT037.mail.protection.outlook.com (100.127.145.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:54:22 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 10 Jan 2023 08:54:20 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.16 via Frontend Transport; Tue, 10 Jan 2023 08:54:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6a8f16e9-90c4-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A2FodgFJQlHN+jEOT1icBJJm4ueZE52nEYnjQXW8aSU=; b=5ngaVJMMfdKPRJlMeUfRk87msXv9iG3rhV8PHtIs0yLFbAQw+JyiFdmkhk9lmlnZDxvL0knByp0c8fDtUfkBtPGsDImLyA73TktN8cvfK4V+dBTGMkRW+Pb/DYrWdnfj1leJotguqtOh3r6CAM5ZkpdiEDXC3Qh4PeqOt3KzZFY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 48f0738268577f07 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gujj+nN2Tey337Kxfu8v7LxzA1GHQGNgyOxScgmPs4VFlQSubR3PJqovA6W8jzFw1QJvS8hRPa2o4Bl0AseM1RIa2b65qX7NkR0xpaVo7yu8o8TDR8E/cvaiRfoCUVN5mBLp/r7Ss53ed1FA+2fxNeLw9+xPpBInTUxhvZOe4l2oI1W/VkNhNiL9jIrPG+zgGoncNTMpVNNiHcKmCrqAZDAX4ysxhwDzao8/G/gBwulqiC8PEYiXejY/RbeXTDy4h3gfr6QIs3u2dU7dfcFmcEQaizfLQ1+qlkUWQgOUV8VBra5dTs6GaVFb0kGdHG+30ez70uHnSei4VxaADegBZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A2FodgFJQlHN+jEOT1icBJJm4ueZE52nEYnjQXW8aSU=; b=eOcBKIioqxKMO2/XlvTtP7J6moNy8nfLr9220mQ29ujOm8cTT8YKQXZtkC3PID2Y7y+9d40qmDPsNVjnObb96n2Lz9rl5QRwnRJuM5Sgl7ZOmClXvnU5s2qhHZwW/I/lV9YAETaJ4lxclLwh1PulVG+d3EhT3/IoMToyMtaX62+prFI5ULh3gARcl5hMnZh+n4UIs6iREgG6ECu8Gui7zXrh4/0ICWcEBqWLIiBNeE0BLCyXEot2PBxj68S+ZhfjUWrz/G/Y7mq/VWqntoBhpX3w/0//5d9dLLk0iCeHFu5UxH3FEtG8Y+C/35XDHve4foKfV9CUsMxIhjowK5EsHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A2FodgFJQlHN+jEOT1icBJJm4ueZE52nEYnjQXW8aSU=; b=5ngaVJMMfdKPRJlMeUfRk87msXv9iG3rhV8PHtIs0yLFbAQw+JyiFdmkhk9lmlnZDxvL0knByp0c8fDtUfkBtPGsDImLyA73TktN8cvfK4V+dBTGMkRW+Pb/DYrWdnfj1leJotguqtOh3r6CAM5ZkpdiEDXC3Qh4PeqOt3KzZFY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v2 13/17] xen/arm: implement numa_node_to_arch_nid for device tree NUMA Date: Tue, 10 Jan 2023 16:49:26 +0800 Message-ID: <20230110084930.1095203-14-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230110084930.1095203-1-wei.chen@arm.com> References: <20230110084930.1095203-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: VI1EUR03FT037:EE_|AM9PR08MB5972:EE_|AM7EUR03FT013:EE_|AS2PR08MB9546:EE_ X-MS-Office365-Filtering-Correlation-Id: f51d712c-b003-4132-0f9a-08daf2e849c5 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: KRxgqa5aoyZuuqh55H8XFhW9AR9ToiSWX1xcdhlzXNSg8e2OnrXSELdc9ro+dfZrIeaDHQQfKY6jdl/hCHOfY9KTC7y+eBTH66fwp2yNFOZKgnBVfTYrFPQA2hKxFfYezNJogunfDSLH7gdAOaxgd12hoNYDg5xEKMBmO4kQoK19ihwUlgjZOoO3CaL4pE/9vAzPHzXP7oWFFN2Z+GYJujreylGNLJuUvPs1M5ywaXcPFA+AmS8lXgwu9yxiFkZQpBLAmkCL/8tw7P9O4UhH/9TBSAsE2li4WA9WSWOAt+frdMgoGqqtr13xaOU7w/KZ3jutEHKFbQzlxCXGXPqcRkiQj1HTBlNj0XcHOyxiZ9mrMh9U4G32ufaRBytgSeActm0RJ4iXOBD/LotuXkS1tkefsylm7b1INBzjHdTOgzR0mh+JxBQWPRI2GxX4ugpPU0x5e6Q8rL7Ujz51v+jcvWnr525AxdH9P8U4M5ZKhGLv5ioPHx+bAMyLkS5C1Py4O5t6d5qCPYXOhyqC4abojlK1JF9w8W2uvc/dgI8ndQM5VhHyWsedHVtDH4m/sDpX5PT1b5gjI10hnieKfAAAy4hW9yvxlsQqqGo5ySIfwkBBEc6GbK9T2ahrVIL1dEqi+XqvHZCaLfBvNHV/V2f0B8CM4OAAtQesZqgKjxaf2zXOaNQG5P+66t5ZbJVdBJ7c88GH2QhP2Q7zFKKirYq5Vw== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(136003)(39860400002)(396003)(451199015)(46966006)(36840700001)(5660300002)(4744005)(44832011)(8936002)(41300700001)(2906002)(36756003)(54906003)(83380400001)(8676002)(70586007)(70206006)(4326008)(316002)(6916009)(7696005)(26005)(81166007)(186003)(6666004)(86362001)(478600001)(336012)(1076003)(2616005)(40480700001)(47076005)(82740400003)(356005)(426003)(82310400005)(36860700001)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB5972 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: fe8c08a8-489c-4652-ba7a-08daf2e844b3 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jssQLk84BYGbldLfDpzDNyi8hXCoJrKgNGph29yW253pBcFp8/j/11QDHeiM0ReBjjJHXFD2u7rz5vMTt1mITL6TYSBgKiNPMvim7Tju1F/hshB7lAsU90AlIaLuRX3Z6QEt9M6XV+DJNXTala26ADwGlCF49LpeJH1FO5jZ9Byerpts5v7vzs6INWnVw2srBvvA83bparPt04yodbjQbXEwMPqRQwa1hhw/IUK4WBixGdlnykCoIhQsOh8hjse1qi8lQKjofCAtmDOsNn22fcsOIXJncqydGh7fyxTH7czdF3UShQ5ulOMD+I9VoMWA9ANb0M6WLx7XsSsLn9x1iMSFtLjLJXG/V1xWY1MBYmKOdXzGPKFuOOSz/mNkuxML00oZggh8L/oWdyG7Pp8pJ7ChAuItRyzRm2fFpAkCulZ2vDRCyzG8h4EFSQETrtxSpk+15zlEPYsQmBAYGz5VYV1NZce+6P6vqTOZWesUbCgNZk4D7Wwd0mE1FJD6RDFsk8uvuumSr7TlV04tjSDaoQNl9JCyyeSXIeCCA2jt8VeTevL0DAcShX5fm2iScZ389gd4dbwecRMhIcByhGlP4D0JKWumK3tQANvlywQNxDuQtt3C0ECevmaE/xHHQobzZb56TGbtyvjIyJvBMULdh2wUaRdZ/AfkmkFOzSENRUXDvBgKbPmYVgLMa5Y/0ivcoxGD1nHlaj1UwWgmZ/HHHA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(136003)(376002)(346002)(451199015)(46966006)(36840700001)(40470700004)(36860700001)(1076003)(86362001)(5660300002)(4744005)(44832011)(186003)(2906002)(26005)(36756003)(40480700001)(7696005)(6666004)(83380400001)(478600001)(40460700003)(107886003)(70586007)(8676002)(4326008)(41300700001)(336012)(70206006)(47076005)(54906003)(81166007)(426003)(6916009)(316002)(82740400003)(8936002)(82310400005)(2616005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2023 08:54:30.9707 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f51d712c-b003-4132-0f9a-08daf2e849c5 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9546 Device tree based NUMA doesn't have the proximity domain like ACPI. So we can return node id directly as arch nid. Signed-off-by: Wei Chen --- v1 -> v2: 1. Use numa_node_to_arch_nid instead of dummy node_to_pxm. --- xen/arch/arm/include/asm/numa.h | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/xen/arch/arm/include/asm/numa.h b/xen/arch/arm/include/asm/numa.h index 34eec9378c..a0b8d7a11c 100644 --- a/xen/arch/arm/include/asm/numa.h +++ b/xen/arch/arm/include/asm/numa.h @@ -47,6 +47,15 @@ extern void numa_detect_cpu_node(unsigned int cpu); extern int numa_device_tree_init(const void *fdt); extern void numa_init(void); +/* + * Device tree NUMA doesn't have architecural node id. + * So we can just return node id as arch nid. + */ +static inline unsigned int numa_node_to_arch_nid(nodeid_t n) +{ + return n; +} + #else /* Fake one node for now. See also node_online_map. */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Jan 10 08:55:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 08:55:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474478.735741 (Exim 4.92) (envelope-from ) id 1pFAPh-0003t7-7W; Tue, 10 Jan 2023 08:55:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474478.735741; Tue, 10 Jan 2023 08:55:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFAPh-0003st-42; Tue, 10 Jan 2023 08:55:21 +0000 Received: by outflank-mailman (input) for mailman id 474478; Tue, 10 Jan 2023 08:55:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFAP0-0005oC-BY for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 08:54:38 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2047.outbound.protection.outlook.com [40.107.7.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 682860ce-90c4-11ed-b8d0-410ff93cb8f0; Tue, 10 Jan 2023 09:54:35 +0100 (CET) Received: from AM5PR0601CA0030.eurprd06.prod.outlook.com (2603:10a6:203:68::16) by DU0PR08MB7437.eurprd08.prod.outlook.com (2603:10a6:10:354::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 08:54:34 +0000 Received: from AM7EUR03FT006.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:68:cafe::b5) by AM5PR0601CA0030.outlook.office365.com (2603:10a6:203:68::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:54:33 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT006.mail.protection.outlook.com (100.127.141.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:54:33 +0000 Received: ("Tessian outbound baf1b7a96f25:v132"); Tue, 10 Jan 2023 08:54:33 +0000 Received: from 43b39c5aa916.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5A10E8F6-007D-4BC4-A4BA-549E0BED9E3A.1; Tue, 10 Jan 2023 08:54:26 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 43b39c5aa916.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 10 Jan 2023 08:54:26 +0000 Received: from AM6PR10CA0030.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:89::43) by PAVPR08MB9139.eurprd08.prod.outlook.com (2603:10a6:102:30c::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 08:54:24 +0000 Received: from AM7EUR03FT035.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:89:cafe::e3) by AM6PR10CA0030.outlook.office365.com (2603:10a6:209:89::43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:54:24 +0000 Received: from nebula.arm.com (40.67.248.234) by AM7EUR03FT035.mail.protection.outlook.com (100.127.141.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:54:24 +0000 Received: from AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 10 Jan 2023 08:54:23 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 10 Jan 2023 08:54:23 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.16 via Frontend Transport; Tue, 10 Jan 2023 08:54:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 682860ce-90c4-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OOWzVhGTnAA1jwh+NIzceBycXKs2uJrzXGAp2en5qCg=; b=ql6UJYSdbgZcWz8+l6VSXPK8eTaGaH0KPHn8TkWej7SiQQ8JTlaaYdkZ+9SxkLeSrGxxrowXNIyLy0GAkgC9BOPwhrehnbMgAvoMz0g3Pw6MxufzQVSPCn2kPsHGeYE8ulkfRvy1AmglSoWk+hxHw5Qet+b+sDCIziRfUUnxx08= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: f238819d235296e5 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gd7GKiDkGt9PFTjucYpmx4GyWQ3ML7j4he/JrXK4WgtoV1sgjMSOxLMl7MXYot9g+Dv+3Uq1/Z9JTgcPKqf3Sqi5sFtZ6wEdZ527Vsn6AklmcXqPHt/OZmg1IMck7X3PlkRWDqNCLPmH7mzE9n+XiJKUQGwPJ3u4VgXiGnbsfMB6tgqL/XQqiKmbqfM4gmem5Ym106HQm7Txlw9hwxJp2tjaP5NiuCjUY3qy8YGmhsvYuHRawjzZKmV4TOTSH4ifkOowalHzLG1biIbN26teZ3uP7RNFx9s8MU+E5xkSKJNq9zQbtcAgA/wSF1sb5BODpmGw9YD+xcnG9xNZYElf3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OOWzVhGTnAA1jwh+NIzceBycXKs2uJrzXGAp2en5qCg=; b=At+zLhsyvGZFQ4O3UhMi+eTK/YWeXLjnUQZrVxPZBqtBKyY38ImSGDFOBYtneWUvvZB8r4kUyulW571NAL8jsdM1JpelPO8nkATmg8ELekBK2KMnXHP5igqp7wb1W0dAcKeQZZEr4SfYx3kPd+Te8Ab3BSNlQw59DWtvZxnujsfWR3QEoOdoZuguGpVCa7dbiq3D+WsSvlSictCwBHhC9Ac5A4He+52Qu8IHYpF9YKf6tsCqVwaEtA8w16onO+t5pfSePTK8WP7LsRdsbrzo5b1wkmmHnmATfgeg/ejh52s1Qrj+I9mv5aFt9ovYFhR/xOBGv/XSSudbDwQEWUWykQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OOWzVhGTnAA1jwh+NIzceBycXKs2uJrzXGAp2en5qCg=; b=ql6UJYSdbgZcWz8+l6VSXPK8eTaGaH0KPHn8TkWej7SiQQ8JTlaaYdkZ+9SxkLeSrGxxrowXNIyLy0GAkgC9BOPwhrehnbMgAvoMz0g3Pw6MxufzQVSPCn2kPsHGeYE8ulkfRvy1AmglSoWk+hxHw5Qet+b+sDCIziRfUUnxx08= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v2 14/17] xen/arm: use CONFIG_NUMA to gate node_online_map in smpboot Date: Tue, 10 Jan 2023 16:49:27 +0800 Message-ID: <20230110084930.1095203-15-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230110084930.1095203-1-wei.chen@arm.com> References: <20230110084930.1095203-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: AM7EUR03FT035:EE_|PAVPR08MB9139:EE_|AM7EUR03FT006:EE_|DU0PR08MB7437:EE_ X-MS-Office365-Filtering-Correlation-Id: 4411b4f5-03de-41d3-14b1-08daf2e84b7a x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: yzynJM8x5/DVIwBjxxTpsnQWlFGNjs6xlB4sbUSGq4TipO54VwCaiNPESxMAnowximu87EVKQ9KSighewqWb1h6CA8vzQN2OGqcEommpKw+pXaJcxhdUac8Ly1/Ye6Tf44cNl6/HrWRCFwh4hK8mgaGqdOEd8ibYUS/wBm5ao8r8XIsCYg65OWmCObl2btkvRHqgp8784WTHhIOR9be9f3GYWfvohYwbm3wVwUKmpx95vYzJGWMxj860dgSHxQTR8A2YTbyheddY6jyaor02WwRir91wMj+QQCzYf/+aWMUikCN8/6DHez3qBh+Y4JKjZANUiGh1U1dj2sVlpfaxgGLLKivxSzkcsgRVc+u+oCKobrEUltI+RBf+jwKmLksPMX+mo/XnIL6j9ss5xbqximchZI7DnnNbOqIMzDYA7UFVKVX7VYjngRKPvGktC+NtUgXavGs+RRv5S406S7CT3esqJX4lGOTVrI+pBPA+GrOSyKiDdC5gYN4kNDBXLikbWClOId1t6lhcfTzJmP1pHfyofDbKReUOLTjGUXQGeoYEN9v/cc6OCY/twQHft88/Nq/KacpEEIFfk4vFh2dlRmXSkJLEbzZFuulOspslr11XxxdlgfqZXznyl0BDeBYJHUo9qlosllmR6JD1bkfU2/A+vYSNPv7yHiKNQyFBJeXhNsp+u2CfyXkl5PwcGOCi2xVG3Gq7WbRbNxdJPrkDPg== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(376002)(396003)(136003)(451199015)(46966006)(36840700001)(356005)(81166007)(82740400003)(7696005)(86362001)(6916009)(478600001)(40480700001)(316002)(54906003)(4744005)(8676002)(2906002)(44832011)(70586007)(41300700001)(70206006)(4326008)(426003)(336012)(8936002)(36860700001)(47076005)(83380400001)(26005)(2616005)(186003)(82310400005)(1076003)(5660300002)(36756003)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9139 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT006.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ba758de7-8bd5-4a2e-969f-08daf2e845e1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NNfJFR1/W4tHDaJY+Lk9QP3yBA+yjex+vi7DT3afDPklW5c8LfUZtJDYWlcqJthoTJNdaq775ZB5g6q8wv8NZUCs7X4am5hTkkgxxWpHAA19/ju7sqd4AbjXslfmitJ44typlTJhBCqUx8TrPDoR1hN63ZloBeVfPgdMCuD9RFXlWFWNCwpOjaRWxeijDEAGwS7Wy494hZOm8l41pQY3LnAaQV3F52eqNLr8yd46iivG3Qvwq/RVSUnBoztN3lszgzZZU6NWEw2JPFWs3Z/GktmrQ0LZPXHccw0uRcxAbT5bPZThrhcqs4lH1UkdTqaMNz+/efXeKfXOqwY1K/hs+9NcjnVXy324AOL2+paTovM+kvxHtU/2mq5+0rX65FJAkarP1r+XTIZ3pIfj4/OHcuqb3QaFucfy4DnYBEbcPkmrziaJpRUdBEU0+n5HjkurQbojTnNF0xyFiOO4ds/AEc68vMC/9+1HcscGsAgfwqESgPGi8nBhRgkcv0xRlLqQT0Asg1AfZH8utZ43e4p3ErerglgDm/h9OlQjTUIb67jfn3H1G57QpqnvQr+Lh59xo4h8AUdxOOgM1dZef3uHTShp80wlGNpAw55ni4b33tIkIRVscnvBEYiCrJxLHl+y+HTxCP08/OhZc2rDqEfETvhAay0rfXJQaYnl6GU1qjBmscXt5xXGNIi1xEhJPet/VA7FJPmEbzDMyEn4oNXUtw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(396003)(376002)(39860400002)(451199015)(40470700004)(46966006)(36840700001)(82310400005)(6916009)(83380400001)(36860700001)(478600001)(5660300002)(44832011)(4744005)(86362001)(36756003)(2906002)(40460700003)(316002)(54906003)(4326008)(82740400003)(26005)(186003)(336012)(8936002)(2616005)(1076003)(7696005)(40480700001)(426003)(107886003)(70586007)(8676002)(70206006)(41300700001)(47076005)(81166007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2023 08:54:33.8347 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4411b4f5-03de-41d3-14b1-08daf2e84b7a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT006.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7437 node_online_map in smpboot still need for Arm when NUMA is turn off by Kconfig. Signed-off-by: Wei Chen --- v1 -> v2: 1. No change. --- xen/arch/arm/smpboot.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c index 5ee6ab11e9..3ae359bbeb 100644 --- a/xen/arch/arm/smpboot.c +++ b/xen/arch/arm/smpboot.c @@ -41,8 +41,10 @@ integer_param("maxcpus", max_cpus); /* CPU logical map: map xen cpuid to an MPIDR */ register_t __cpu_logical_map[NR_CPUS] = { [0 ... NR_CPUS-1] = MPIDR_INVALID }; +#ifndef CONFIG_NUMA /* Fake one node for now. See also asm/numa.h */ nodemask_t __read_mostly node_online_map = { { [0] = 1UL } }; +#endif /* Xen stack for bringing up the first CPU. */ static unsigned char __initdata cpu0_boot_stack[STACK_SIZE] -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Jan 10 08:55:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 08:55:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474482.735752 (Exim 4.92) (envelope-from ) id 1pFAPj-0004Gp-JP; Tue, 10 Jan 2023 08:55:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474482.735752; Tue, 10 Jan 2023 08:55:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFAPj-0004Gc-DX; Tue, 10 Jan 2023 08:55:23 +0000 Received: by outflank-mailman (input) for mailman id 474482; Tue, 10 Jan 2023 08:55:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFAP7-0005s6-5R for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 08:54:45 +0000 Received: from EUR03-VI1-obe.outbound.protection.outlook.com (mail-vi1eur03on2070.outbound.protection.outlook.com [40.107.103.70]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6c85df74-90c4-11ed-91b6-6bf2151ebd3b; Tue, 10 Jan 2023 09:54:43 +0100 (CET) Received: from DB7PR02CA0006.eurprd02.prod.outlook.com (2603:10a6:10:52::19) by DB4PR08MB9864.eurprd08.prod.outlook.com (2603:10a6:10:3cf::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 08:54:40 +0000 Received: from DBAEUR03FT032.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:52:cafe::2a) by DB7PR02CA0006.outlook.office365.com (2603:10a6:10:52::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:54:40 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT032.mail.protection.outlook.com (100.127.142.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:54:40 +0000 Received: ("Tessian outbound 8038f0863a52:v132"); Tue, 10 Jan 2023 08:54:39 +0000 Received: from b094e260e48b.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 3D2E68E8-747C-4449-9205-D2B044856754.1; Tue, 10 Jan 2023 08:54:34 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b094e260e48b.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 10 Jan 2023 08:54:34 +0000 Received: from AS8P189CA0042.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:458::12) by DU0PR08MB7638.eurprd08.prod.outlook.com (2603:10a6:10:31f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 08:54:31 +0000 Received: from AM7EUR03FT052.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:458:cafe::af) by AS8P189CA0042.outlook.office365.com (2603:10a6:20b:458::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:54:31 +0000 Received: from nebula.arm.com (40.67.248.234) by AM7EUR03FT052.mail.protection.outlook.com (100.127.140.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:54:31 +0000 Received: from AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 10 Jan 2023 08:54:29 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 10 Jan 2023 08:54:28 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.16 via Frontend Transport; Tue, 10 Jan 2023 08:54:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6c85df74-90c4-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A9xXZMbekjt/tql+kzQOe7eglF3L9li7hx3d+MOMfTs=; b=wStOQAtR9wr3xfjETfijXVkPoK6EjofHsjwj4GezKJ4hg3PfSwYIPFKFpA8QuZPm14Fa4ucszy2WmkJLHSnnBYKiKfiXsElSDF7OedleAmuwx4I8cADpSZod4MK5deiRnIWknCNiWiq7qfNnlhSWXgvtbo1QHzaRrtCZKYInBn0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 8f436cb93478cc52 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cENsEWAd+moxKaD55/XfUjNcxkB3d0km+dUiiyBnjidvB9M2rKkXh6BORZaYgRq0+3e+d9IPlSUe0PexA2S0XB6qBM9wSloOYN/WVO0y00VEPRv/6VOLFPCybf0xZSI1CwSg3wSBrKmx9hRoOWSaXHB4HnRsWivFmeIFXq/zXUrUk6w52+WzSC39xZA3DwoATN/cKIsSfk4RBsufhhXYiGw+7RXauP4Dtl2HLzu5agewHRtVwmLzEv41JfkddPWVcgFPWAgUmtpwobTDao1K3g41rIF3OpOPmMyIT2MaODJ1cqjFi7SEqUVY8G7HNYeEs1X6WyPJYgNDkPk2e64dfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A9xXZMbekjt/tql+kzQOe7eglF3L9li7hx3d+MOMfTs=; b=GA35AQ0XgoLhZ3XdZD0y4jXu5wM4OddFCtVmlluTg9AwFPoIc3suuBCgGAYI4HjbOj6AG1VVazA/B2ofGNXXIHCFKD6SkE55pzZqPORysHZAqCgDmNfn6QrjDJE40ZqUNxFS77KSfgb9miy1UmTfYpkTKZkuSbfsP0RLLGMBT0CpodehwuDS/fyBbGQHCaBDLrD1UTNHhWCtY1tz9L8xGcJAFY4LZDgcoqiv5j5o7VvkoF9zpfUELqkfYEaEnt8mho6pywNVF3w3zJwne83lRf5hyR8ffKONPRFebEfj2bNL+rGeNffh17N1AxyQ1VzRpHzWpR1j0eOT2TLvsmbCvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A9xXZMbekjt/tql+kzQOe7eglF3L9li7hx3d+MOMfTs=; b=wStOQAtR9wr3xfjETfijXVkPoK6EjofHsjwj4GezKJ4hg3PfSwYIPFKFpA8QuZPm14Fa4ucszy2WmkJLHSnnBYKiKfiXsElSDF7OedleAmuwx4I8cADpSZod4MK5deiRnIWknCNiWiq7qfNnlhSWXgvtbo1QHzaRrtCZKYInBn0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v2 16/17] xen/arm: Provide Kconfig options for Arm to enable NUMA Date: Tue, 10 Jan 2023 16:49:29 +0800 Message-ID: <20230110084930.1095203-17-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230110084930.1095203-1-wei.chen@arm.com> References: <20230110084930.1095203-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: AM7EUR03FT052:EE_|DU0PR08MB7638:EE_|DBAEUR03FT032:EE_|DB4PR08MB9864:EE_ X-MS-Office365-Filtering-Correlation-Id: 87f9161b-9e2a-4ef4-bbd3-08daf2e84f2b x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Ai2Nn49kHTWarRWtw0dy8bx2KRkaTSdeT2IEQHS6UjuznaMHQ5V+eNZqKeMGTFZhM2Dw2wWx3YmhADU92G3I/bg/9lEnJdubKjUjC8awrnVsZMKE2YmwBKeyKyx5iBuGJfTXWym79bGIkvWaSJZ3c8bburSI5SKXbpXNzth4NdMNSEq/vWnJDAOpN83FygPao93MBwpyplt+W3mrZQZaine+yu5a2iEDz1Ai2/QKBV+E7bmwEa38C+YGMWLs+TNTk4zqoyIVENWLwT/spNYA/tzzgc+rYdD0StLQgJDb1rpyh8BxA0In+WsfG0RktEkqF+jMbhflFczUphUekj3gwskhctfDnr4kfIRrqaTtB/Utro09kxKve44ZynoMLFMdhIcPErnEcrfwwvvU/vJ90FaPZNTfF/h1G0r3gU3NVkuCQmQXB0diCc7f+VEFDwhJCoE+RqHMbjwMLGNAIYBMiMiWGtFB8q3gKtahxW3+F5lP+Kj7U/ajs9lYwxChjScg4lOIMtbfSuetyfO4VpGmR+SgmT/v0e2EHxMR2wcCq6IN5nLfCvMX+uOQ/lrdlQ4/HScm31NfJxHHOwuMO2pl10LnLwJH3Y4Z3aCmWzkxVbKCK6LVo5GahWXuRbRqOB4ss79GX1GegkyjpLhD7TktJiSoR+wWeinFIa8usJN/XwMntY1jYODJaw0/HW6dbuuJamm8Be4/gtuoJWwgsaGYHQ== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(136003)(396003)(39860400002)(451199015)(36840700001)(46966006)(2906002)(44832011)(36860700001)(2616005)(5660300002)(7696005)(41300700001)(8936002)(36756003)(70586007)(70206006)(83380400001)(8676002)(356005)(4326008)(316002)(47076005)(86362001)(336012)(82310400005)(1076003)(426003)(40480700001)(26005)(81166007)(478600001)(186003)(54906003)(6916009)(82740400003)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7638 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT032.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 7767b79c-f5eb-4540-bbee-08daf2e84a03 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: V0m2pag9oMWbbSsjJbj1ryiPS2w1nNx8mcKAKATcBt6/8yU3xIZ/cHjNvtcKniHUiLU4V3w+Vl8ICyOqcIVtQJNEkTBtQBaPdeut62oB4ZGA+84jjC80sk1i/hd2CcbCK88TEJtjgk4p1RcIUdr3cg0IwtT1U156W6YHZjz9gtL5FqW35Ew5ELgTOVD2mv8chzbDfeopJf6xxyT8G5DKmevLakKW1sCFakFfHK24wnUsC3tS7xdV6I/x/fD8c5T2uMo8OSqql+oYA1pIraUVA3BLzTgmFgorhbVbuUyJYqB3tB4CRpcOu2l28xBlSMwj0DcKHqDCUmCL+ZLGZ3vmqGwbeSyTl9qVH1FwohP+oCoO0O96Re4c8uVHantGHeXTCmKV/7d4YayOLyQm0zED/MST3sgeYj/3LtKQ1b/D0GH68jlAXCd7UBviRTLyeXU+BhhEJIDA0JPLDnEqwQUky+KLH7fQiKlkaURHkFl3Yk+iuWib5cQn6i1dr82Yll9iYYrjUdvCNgt5owEWkV9M9ZrymE3bkJGlZ2VwLuPCGHhU7frJHqo1g/4HKRG/uPWNzlCKYsM9D6q+GHb6i2DKEIiEDG7v5b4NPXAEm4CSOOxLUjnsJsyeaeDmymb/NpvbpyFMrQuNjDlQ4oVK0QD8aipSBe7DnunJlns6k/9i3nzMkzgqXN2SuRcQjSgpN7zUBu0JG3rRxNtgI9EjNcZdsw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(39860400002)(136003)(376002)(451199015)(40470700004)(46966006)(36840700001)(107886003)(47076005)(70206006)(36860700001)(1076003)(70586007)(8676002)(82740400003)(41300700001)(86362001)(426003)(4326008)(336012)(2616005)(81166007)(478600001)(40460700003)(5660300002)(40480700001)(316002)(44832011)(6916009)(26005)(186003)(7696005)(2906002)(54906003)(36756003)(83380400001)(82310400005)(8936002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2023 08:54:40.0790 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 87f9161b-9e2a-4ef4-bbd3-08daf2e84f2b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT032.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR08MB9864 Arm platforms support both ACPI and device tree. We don't want users to select device tree NUMA or ACPI NUMA manually. We hope users can just enable NUMA for Arm, and device tree NUMA and ACPI NUMA can be selected depends on device tree feature and ACPI feature status automatically. In this case, these two kinds of NUMA support code can be co-exist in one Xen binary. Xen can check feature flags to decide using device tree or ACPI as NUMA based firmware. So in this patch, we introduce a generic option: CONFIG_ARM_NUMA for users to enable NUMA for Arm. And one CONFIG_DEVICE_TREE_NUMA option for ARM_NUMA to select when HAS_DEVICE_TREE option is enabled. Once when ACPI NUMA for Arm is supported, ACPI_NUMA can be selected here too. Signed-off-by: Wei Chen --- v1 -> v2: 1. Remove the condition of selecting DEVICE_TREE_NUMA. --- xen/arch/arm/Kconfig | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index 239d3aed3c..e751ad50d1 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -39,6 +39,17 @@ config ACPI config ARM_EFI bool +config ARM_NUMA + bool "Arm NUMA (Non-Uniform Memory Access) Support (UNSUPPORTED)" if UNSUPPORTED + depends on HAS_DEVICE_TREE + select DEVICE_TREE_NUMA + help + Enable Non-Uniform Memory Access (NUMA) for Arm architecutres + +config DEVICE_TREE_NUMA + bool + select NUMA + config GICV3 bool "GICv3 driver" depends on !NEW_VGIC -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Jan 10 08:55:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 08:55:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474487.735763 (Exim 4.92) (envelope-from ) id 1pFAPl-0004fJ-WC; Tue, 10 Jan 2023 08:55:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474487.735763; Tue, 10 Jan 2023 08:55:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFAPl-0004eR-Rc; Tue, 10 Jan 2023 08:55:25 +0000 Received: by outflank-mailman (input) for mailman id 474487; Tue, 10 Jan 2023 08:55:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFAP1-0005oC-60 for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 08:54:39 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2040.outbound.protection.outlook.com [40.107.6.40]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 684407f9-90c4-11ed-b8d0-410ff93cb8f0; Tue, 10 Jan 2023 09:54:36 +0100 (CET) Received: from AS9PR07CA0032.eurprd07.prod.outlook.com (2603:10a6:20b:46b::26) by AS8PR08MB9930.eurprd08.prod.outlook.com (2603:10a6:20b:564::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 08:54:34 +0000 Received: from AM7EUR03FT025.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:46b:cafe::e8) by AS9PR07CA0032.outlook.office365.com (2603:10a6:20b:46b::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.11 via Frontend Transport; Tue, 10 Jan 2023 08:54:34 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT025.mail.protection.outlook.com (100.127.140.199) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:54:34 +0000 Received: ("Tessian outbound 43b0faad5a68:v132"); Tue, 10 Jan 2023 08:54:33 +0000 Received: from 3390037eb137.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2F7B9D46-02EF-44CB-AE26-D0F4CB766B0F.1; Tue, 10 Jan 2023 08:54:26 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 3390037eb137.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 10 Jan 2023 08:54:26 +0000 Received: from FR3P281CA0159.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::19) by DU0PR08MB9875.eurprd08.prod.outlook.com (2603:10a6:10:423::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 08:54:15 +0000 Received: from VI1EUR03FT055.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:a2:cafe::a3) by FR3P281CA0159.outlook.office365.com (2603:10a6:d10:a2::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.12 via Frontend Transport; Tue, 10 Jan 2023 08:54:15 +0000 Received: from nebula.arm.com (40.67.248.234) by VI1EUR03FT055.mail.protection.outlook.com (100.127.144.130) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:54:15 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 10 Jan 2023 08:54:09 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.16 via Frontend Transport; Tue, 10 Jan 2023 08:54:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 684407f9-90c4-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JD7QrIfD9JHz3fTuQsCfz4zF77DrQ2+h/779Q8LcaQg=; b=lZ9tyBRNocxLf39gyHK2PqW0/wInK5F7UD9wUV46pvLMvVjblxMPVLloJt341jM5uNGD7puh7H76ky3qYG3tRd2+3Aj72TTxrTCf7BvAfyQYTwP3m8icL+GSXYynQYx69XaUtEySS9Wy5yzX1bzK7T7iTkp1LLKzLpBsF/4eZCw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 6e8560d985ecbcc9 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Maa6RscqbOXNhihsTbC3V4BIiMLxNz4ex48uAer04W/YxSLBW4l34l9d84ao67Z+rljmRddGrOrEB0fBQz9tOJZ5Ewx1BaYSrHxCT83vaOJXV+7hHh+GsqLiuzZ5fM3Xowqsf9enwpemcM6Gss6UiMi3qm/AVOSnY0U9TGsTnjvtCHcZRNyM8a+i5pHt++rRpVtbF7CKqfIpm+riOg2Qa03h31aLkcRNXjZjiaAuoHtRQUckIPLXZnO92N5LKDBbzhRNoV813Ea4kuTl/gitNCiT6QnDga27W1eVHz/Id279lG4mCYH7JSsVTinbYKZut/vcPxSo2/YALU/7970VCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JD7QrIfD9JHz3fTuQsCfz4zF77DrQ2+h/779Q8LcaQg=; b=l8b/PBbDnukDhWNv9cJ0dia+1FmJCzQEZZ5O43lesbsfOdeqvSj+hdxdpp+hVKty5fUrQklIpicaM9iBJCEb4kL2Jnp8tx48S/MXtATUCjifaxUJoZwch/FnKikbXZXkh6iY9e2nn/zEnsvFyL2G2+OEpti+lbu1EDHO5+/QvHyHv4eTOeKiBGj4sCr7i3iRP6w8O9uL9b0P7P2vFTH1mc3CcsylUOL6mpST02dAuXcBZfJmlJ2dMCVx6CepzvseBoOn7WV418K3l9dMpuU9BijkexOTI/S0ieBe2/XGfjYBNbv83gzCHP5dYAisWx8Gp+JllFpAFxguwmsvz0NBkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JD7QrIfD9JHz3fTuQsCfz4zF77DrQ2+h/779Q8LcaQg=; b=lZ9tyBRNocxLf39gyHK2PqW0/wInK5F7UD9wUV46pvLMvVjblxMPVLloJt341jM5uNGD7puh7H76ky3qYG3tRd2+3Aj72TTxrTCf7BvAfyQYTwP3m8icL+GSXYynQYx69XaUtEySS9Wy5yzX1bzK7T7iTkp1LLKzLpBsF/4eZCw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v2 09/17] xen/arm: introduce a helper to parse device tree NUMA distance map Date: Tue, 10 Jan 2023 16:49:22 +0800 Message-ID: <20230110084930.1095203-10-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230110084930.1095203-1-wei.chen@arm.com> References: <20230110084930.1095203-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: VI1EUR03FT055:EE_|DU0PR08MB9875:EE_|AM7EUR03FT025:EE_|AS8PR08MB9930:EE_ X-MS-Office365-Filtering-Correlation-Id: c3ae5224-0cd0-4e27-de41-08daf2e84baf x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: SirlqwtpLwHm2mWKsAdonfyzexqmkx2lbTAa6R1FFEe4+2+b43/bJrXeYmWZj5M7CE6/XjyuAn7BGq89ebRYbbE81EzQzL5Ob8Bw7Tp5fbHFzSZSgNpVK3fM61RQ1j3XzN08LNXSwOgH9jWNHCX5jKZ4AGOu7KxIZppUDCgy6RIMoXYylyOnBOLEllRuTn/see1sL0G1vq3uLW1cED8d/ndCvcEGs66HaP90qmRcPtY/qrG+Mvmab+VyvaahwiP9+5qdsd2rocpNj9TNBO87Py2g4vXIiQdLy9yLujxNslYNFneegDlZmIkjieubwxhTxiBSPKUndNZ9Srih8ur+WNl0PKmFN3YEhiubM+WPUu2yF7+UCU9+hsNdKVlgzykPN9TmiMq6/mgky0QxAi/16YJvxI+XAO4go+6cm+1NkwwWHeZvFWESRawMwsM8+Dx0LpheydWvnTXTydbEY4oiIGZ/WmFfYhKmWSM9KzG9bCz7mePNXiERfUo0CMODjxnS9zFvZvsdr2y+vY4SL33yKLu6gyrmW1OyNqUK05ab7R3BBWpXY/rUXz6EerjKHQZxkVwpBK4J/2/pQErpw85DUu3JXvnhdpb/WEyWYDBz/ZMGVsfnCcunwRV8Ulv6n2E8u+oYCKmnDaK/IA5uU4ZbEB2yrg+ub+O0Iv/P2Y3CwUuNppmqdL/9fGq5M/qBt/Z1KJYlVf93etvMRfOwMYTuY+ymWo5xo9fKk4KuVRj3IuI= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(136003)(39860400002)(346002)(451199015)(36840700001)(46966006)(356005)(81166007)(82740400003)(36860700001)(86362001)(54906003)(8676002)(4326008)(6916009)(41300700001)(70586007)(70206006)(8936002)(40480700001)(5660300002)(2906002)(44832011)(1076003)(2616005)(336012)(83380400001)(426003)(47076005)(82310400005)(966005)(186003)(6666004)(26005)(316002)(7696005)(478600001)(36756003)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9875 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT025.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ec34f7cc-6957-4d43-a18f-08daf2e8408c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dOx2p4Nbu+Qq5yYF0i5m0xeM29ARRXdYzMPCVCdajFldRVlNWJDW+KFKTum7j+koVXpD8KtLgucfKy+Steb0nwTcSSu2g5T0vquGTjyykTd6i5d6z8GHAaedbUiev+BWtAKkp3XU0sRSZFkZiruPHPsaZgV57dWz2c6tRMQdIAUbloxktZp7qoXtiPFq3lXFimvUmG9mTavjO7xziNxoZsWPVK4csh2HgHDWxyygym7m3oHmIAa8s8EM7ifuX4vdAP5yD6rbg20tyiCv9aeSMj+Sve3ue42SjyG6rH2eM9OCdP/rEqKALDW7xV8xKqrOdm/qS8K6FeDkraj2AJ/iiu8Smm53JIIO/UF3lQbmSFcHQ+5TgzRccl3I1b8nnDvC3uRO+vTeSVdByxiL2pKWQf8ztuBxhtQBxrK2JjSaWVR9jFwpljkAd3AVh56qxWWJE23A8XrvmaCHG8F516HL1LtEM3CYBso3VEg1tLNetj5d2VElyAnIbBiqASv8SofF+cSpHkOFJjiwoxG0g9QhfrAaZYl5i7a8h7xuQQBTBb9muwarmvwKqFnHP9IXQ8ysc2PcDb132yYosPayw9C42eLuBJDXbEdsnrMiGQEcKeeHOrGFL9UrFaObDIeWe8/HHBnTlY83WuvvY1CgmVhmxlSc668UbDKpZ7ZiOS68sSitWEhEGPxSqbPh7CF2i573Svlr1WWk/CiW3ROsSb0FDwZO/8eF7264B6gCpJZsZVI= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(39860400002)(346002)(376002)(451199015)(40470700004)(36840700001)(46966006)(2906002)(36860700001)(44832011)(5660300002)(7696005)(41300700001)(8936002)(36756003)(4326008)(83380400001)(70206006)(70586007)(8676002)(40460700003)(86362001)(47076005)(82310400005)(1076003)(336012)(2616005)(6916009)(426003)(26005)(81166007)(40480700001)(478600001)(186003)(966005)(82740400003)(316002)(6666004)(107886003)(54906003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2023 08:54:34.1716 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c3ae5224-0cd0-4e27-de41-08daf2e84baf X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT025.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9930 A NUMA aware device tree will provide a "distance-map" node to describe distance between any two nodes. This patch introduce a new helper to parse this distance map. Signed-off-by: Wei Chen --- v1 -> v2: 1. Get rid of useless braces. 2. Use new NUMA status helper. 3. Use PRIu32 to replace u in print messages. 4. Fix opposite = __node_distance(to, from). 5. disable dtb numa info table when we find an invalid data in dtb. --- xen/arch/arm/numa_device_tree.c | 107 ++++++++++++++++++++++++++++++++ 1 file changed, 107 insertions(+) diff --git a/xen/arch/arm/numa_device_tree.c b/xen/arch/arm/numa_device_tree.c index 793a410fd4..88056e7ef8 100644 --- a/xen/arch/arm/numa_device_tree.c +++ b/xen/arch/arm/numa_device_tree.c @@ -151,3 +151,110 @@ invalid_data: numa_fw_bad(); return -EINVAL; } + +/* Parse NUMA distance map v1 */ +static int __init fdt_parse_numa_distance_map_v1(const void *fdt, int node) +{ + const struct fdt_property *prop; + const __be32 *matrix; + unsigned int i, entry_count; + int len; + + printk(XENLOG_INFO "NUMA: parsing numa-distance-map\n"); + + prop = fdt_get_property(fdt, node, "distance-matrix", &len); + if ( !prop ) + { + printk(XENLOG_WARNING + "NUMA: No distance-matrix property in distance-map\n"); + goto invalid_data; + } + + if ( len % sizeof(__be32) != 0 ) + { + printk(XENLOG_WARNING + "distance-matrix in node is not a multiple of u32\n"); + goto invalid_data; + } + + entry_count = len / sizeof(__be32); + if ( entry_count == 0 ) + { + printk(XENLOG_WARNING "NUMA: Invalid distance-matrix\n"); + goto invalid_data; + } + + matrix = (const __be32 *)prop->data; + for ( i = 0; i + 2 < entry_count; i += 3 ) + { + unsigned int from, to, distance, opposite; + + from = dt_next_cell(1, &matrix); + to = dt_next_cell(1, &matrix); + distance = dt_next_cell(1, &matrix); + if ( (from == to && distance != NUMA_LOCAL_DISTANCE) || + (from != to && distance <= NUMA_LOCAL_DISTANCE) ) + { + printk(XENLOG_WARNING + "NUMA: Invalid distance: NODE#%"PRIu32"->NODE#%"PRIu32":%"PRIu32"\n", + from, to, distance); + goto invalid_data; + } + + printk(XENLOG_INFO "NUMA: distance: NODE#%"PRIu32"->NODE#%"PRIu32":%"PRIu32"\n", + from, to, distance); + + /* Get opposite way distance */ + opposite = __node_distance(to, from); + if ( opposite == 0 ) + { + /* Bi-directions are not set, set both */ + numa_set_distance(from, to, distance); + numa_set_distance(to, from, distance); + } + else + { + /* + * Opposite way distance has been set to a different value. + * It may be a firmware device tree bug? + */ + if ( opposite != distance ) + { + /* + * In device tree NUMA distance-matrix binding: + * https://www.kernel.org/doc/Documentation/devicetree/bindings/numa.txt + * There is a notes mentions: + * "Each entry represents distance from first node to + * second node. The distances are equal in either + * direction." + * + * That means device tree doesn't permit this case. + * But in ACPI spec, it cares to specifically permit this + * case: + * "Except for the relative distance from a System Locality + * to itself, each relative distance is stored twice in the + * matrix. This provides the capability to describe the + * scenario where the relative distances for the two + * directions between System Localities is different." + * + * That means a real machine allows such NUMA configuration. + * So, place a WARNING here to notice system administrators, + * is it the specail case that they hijack the device tree + * to support their rare machines? + */ + printk(XENLOG_WARNING + "Un-matched bi-direction! NODE#%"PRIu32"->NODE#%"PRIu32":%"PRIu32", NODE#%"PRIu32"->NODE#%"PRIu32":%"PRIu32"\n", + from, to, distance, to, from, opposite); + } + + /* Opposite way distance has been set, just set this way */ + numa_set_distance(from, to, distance); + } + } + + return 0; + +invalid_data: + numa_fw_bad(); + return -EINVAL; +} -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Jan 10 08:55:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 08:55:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474490.735768 (Exim 4.92) (envelope-from ) id 1pFAPm-0004l2-Fj; Tue, 10 Jan 2023 08:55:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474490.735768; Tue, 10 Jan 2023 08:55:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFAPm-0004jr-7T; Tue, 10 Jan 2023 08:55:26 +0000 Received: by outflank-mailman (input) for mailman id 474490; Tue, 10 Jan 2023 08:55:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFAOt-0005oC-Vo for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 08:54:32 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2060.outbound.protection.outlook.com [40.107.241.60]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 64252c3d-90c4-11ed-b8d0-410ff93cb8f0; Tue, 10 Jan 2023 09:54:29 +0100 (CET) Received: from DB3PR08CA0023.eurprd08.prod.outlook.com (2603:10a6:8::36) by AS8PR08MB8014.eurprd08.prod.outlook.com (2603:10a6:20b:573::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 08:54:23 +0000 Received: from DBAEUR03FT046.eop-EUR03.prod.protection.outlook.com (2603:10a6:8:0:cafe::7f) by DB3PR08CA0023.outlook.office365.com (2603:10a6:8::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:54:23 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT046.mail.protection.outlook.com (100.127.142.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:54:23 +0000 Received: ("Tessian outbound 43b0faad5a68:v132"); Tue, 10 Jan 2023 08:54:23 +0000 Received: from 2c054ce7be9b.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 905571E1-3E67-479C-9FC7-959B1C3C0CE3.1; Tue, 10 Jan 2023 08:54:16 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2c054ce7be9b.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 10 Jan 2023 08:54:16 +0000 Received: from FR3P281CA0152.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::6) by AM8PR08MB5570.eurprd08.prod.outlook.com (2603:10a6:20b:1d2::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 08:54:14 +0000 Received: from VI1EUR03FT055.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:a2:cafe::9) by FR3P281CA0152.outlook.office365.com (2603:10a6:d10:a2::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.11 via Frontend Transport; Tue, 10 Jan 2023 08:54:14 +0000 Received: from nebula.arm.com (40.67.248.234) by VI1EUR03FT055.mail.protection.outlook.com (100.127.144.130) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:54:14 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 10 Jan 2023 08:54:03 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.16 via Frontend Transport; Tue, 10 Jan 2023 08:54:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 64252c3d-90c4-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M0LsJ5CSUqhuJ+jKKH9S6bS+xUQ/jDtaI6zjdX/HcC4=; b=WgH4ZFzxCtwfDNF2TYm+Q3vSBwWD9rEQb4TbvG0TOlzyuovBK158ivFlfQksCTuKqgZatB1Cz8A+f8Nn1k0lhiJm52dmcxykXXCdncAAz86PloSxBXTHHgv/9kiQifdq13ZBwyaeOKUJo8sfZksjaRJqCjlzvRGgjxX9NYVqzF0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 7d9229752571d865 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R6jgDNrWZ3RsmHR7P4XYzN/NdlYbwODLleULfn9UNAYMir2VIF7zBlO7Ls27pwSvg5oIx/q7PCuQ5edJrwtAdwT46/QZLpb76MPqSVkitkvSFGOi5dH/qOtHb2jCJ9MFsvb6ObRYcQsrat8y8nVVPr4T9e0zHRAQZIXyu2z175WSSE240ZAeQWwh9Rt7GylPisUm6DxHRNA8UU0nOrLOyyszn323yM2xJ4M7zyoLvVqRkUdYPfNk7niwTR+f48MWsqnFLG/1lzgAfgWsEUK5roCx1xP9ZeHfWHsRuuxRWB4VXDMwUW0iQzBxRfHUrvuLlotJ/pLY+CjViN2X05XjoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=M0LsJ5CSUqhuJ+jKKH9S6bS+xUQ/jDtaI6zjdX/HcC4=; b=UTf5mljz33ND6pukkxyxuZg5BTqGNlTcWhypwwBfqzDDXsDjDZpHn06FfjKnZZY86SOdGH2j6B7UDOIjlwSEbdT8JmHRd12NkYiMaWWfLbK2nwzQc4Qqm3aZ5vEDtpBvaLbADi3NwDn0EsHHvQCFiO5ZNnC85vutBlzp0iLltQT28FZ+Lgq98EfjjtKFKyve5sPE5a4LJEcP8g0zRIPp7y/FuwHvMEr8tpqx7rwDyWHTTuQbwSKfi371zw7v9OWw+2g4Kmgb20CCCI5kkchlG36l0dBxt2yU3TBTNw8i0fUcDXorvpBCmXD2zKbGxlTN8OXdn9Ag7xnfakOlb05NaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M0LsJ5CSUqhuJ+jKKH9S6bS+xUQ/jDtaI6zjdX/HcC4=; b=WgH4ZFzxCtwfDNF2TYm+Q3vSBwWD9rEQb4TbvG0TOlzyuovBK158ivFlfQksCTuKqgZatB1Cz8A+f8Nn1k0lhiJm52dmcxykXXCdncAAz86PloSxBXTHHgv/9kiQifdq13ZBwyaeOKUJo8sfZksjaRJqCjlzvRGgjxX9NYVqzF0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v2 07/17] xen/arm: introduce a helper to parse device tree processor node Date: Tue, 10 Jan 2023 16:49:20 +0800 Message-ID: <20230110084930.1095203-8-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230110084930.1095203-1-wei.chen@arm.com> References: <20230110084930.1095203-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: VI1EUR03FT055:EE_|AM8PR08MB5570:EE_|DBAEUR03FT046:EE_|AS8PR08MB8014:EE_ X-MS-Office365-Filtering-Correlation-Id: 1f7a8fcb-cf41-4814-5cb6-08daf2e84566 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 1dn9LWEKyH0NMvNktotZQO1LMC0LUoKoNrL0OaDJ1rCVnG+XJJKj8ABBXnDcO40W00Rrb08qt9fWJgMn33fBt6OA/aWxVjazCfgpaelNlDGUn7ZrC1DIZDM3iTOudKyk9TOeiQOOfwV9UsjuWZ7oCRCnEhfY+woXV8k6EMT5ER5PSR/llt+2gv1QVoPSyIFiWNUYYkCKDgU+bUPrdoQdnO/FFfdAPU+gaYOiehCsfIGsPcWpHvLgkf7BAPSQmZXXzvfv7CdCVCRzU0eVVH8ZcRYr28fvtG7Gam5wfQIgclhxtcf7c3lLMlPItWnn/ySFmprS9ZRkP04vSAmCr33K1mzg9r/0q61ytraN74SS/l2h4maQRR44iMbjLVgf/9lIUh0CM2ACG9aslS4XDRQSFrsiKs4REGMk+Q3iIlELYdlgaLb+nvrX6Zdwc8FXOowA5NwsUZHIJqfGmql+lMNWe2k++lsnokavl65lsK3ppFG6bT1NtIAmcKsLRdS8j2D1zRtYs4pidexvMVU2Y2Y1TDLqtHnEh7YeUzD+vX2sSvmXDpqqOB/4qvkGH5JtCzclh8jtIDj0FxCgwnKPmvXqebMQ3GJKaOXlk9slre9qPUUMrhPXJWcsZt3BVnsWVOYr9ApVmfsGUw9OwBWwk5rHHdThKc1Jq5OQPxUGDvQGcrEcBFchpv677RV0So09ll1xS+b+PdQqO4VDf0IgCHKvB6c1EEkDSVLSHPP2uf1vmhQHdwTZKbx98Q2pKtU0yg1j X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(136003)(39860400002)(396003)(451199015)(46966006)(36840700001)(5660300002)(44832011)(8936002)(41300700001)(2906002)(36756003)(54906003)(83380400001)(8676002)(70586007)(70206006)(4326008)(316002)(6916009)(7696005)(26005)(81166007)(186003)(6666004)(86362001)(478600001)(336012)(1076003)(2616005)(40480700001)(47076005)(82740400003)(356005)(426003)(82310400005)(36860700001)(2004002)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5570 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 397c67c1-6fe2-499a-0e00-08daf2e83ff4 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UO7Y7HN+aYDoyYCIxAQOUE9CJxW5LrZTDETgW7GLoZt54HIhkzx53jEXBrev3EaQMKlHSBh1DLNIj6UJxmJg5RYkIGZqMQUNT8B32pWJ1k/JJviFUm2M5dM19v1NZP76hSTWj5tgS4oJJm/cZfWethdMjYucOsEGa501MZeSn0OWfsWYzqVP84wrG/cx5+L5BiLBI39KQpIMCP03/H9Kps969UqXRUUMYg+zLNi+535naJQLnRSlI0LxECG+sr7x3qrKF9dXFvMIkd/J82lfRZ8s4GI3Z3cekFnoq3on3z30MqxiHIUSenddJg7BqyjOvYE4EbMCINs7sbo2fvn3w91YT/Wi20gzJkukTULDiaormFudITFD1ixepUiMsP6U4xkeByEyKWe5751RdEOKFGOyzGwWBdxbfswcULAoLJhPpMRCKoOobGcQdBRHxxyFinwo1eA3OyhLyFn2wscBCRR4vt3AsmcU6YpD9y9mbfuYV+u6rRUGdwt1svJgV/FY9hl0Do0jsygfsV/rMEjMn8m3MCv9TgWkM60rVZcJUVV91eIYTffds71wv5aCmY2MQu1EvdQSMNM7ps8jRaSRTi7yqRD8w3kAdZuDcNRNBpiMKYpGTleXlcLWrlj+Q82i4/AdVPzTWadeNK7qIuwadUDRGPO3jymwFvPeo1e+xLJQIFYd/dhDCqSZWoXklYO17mbSOiNYw++IMCCBV2j4vncFphA+6xy9EhZ9FMl7fIuZmdRmua7V6mYpkM4MXHNe X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(39860400002)(376002)(346002)(451199015)(36840700001)(46966006)(40470700004)(36756003)(81166007)(70206006)(4326008)(5660300002)(44832011)(8676002)(2906002)(8936002)(70586007)(83380400001)(82740400003)(36860700001)(86362001)(7696005)(478600001)(316002)(6666004)(6916009)(54906003)(40460700003)(40480700001)(82310400005)(41300700001)(336012)(107886003)(47076005)(1076003)(26005)(186003)(2616005)(426003)(2004002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2023 08:54:23.6861 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1f7a8fcb-cf41-4814-5cb6-08daf2e84566 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8014 Processor NUMA ID information is stored in device tree's processor node as "numa-node-id". We need a new helper to parse this ID from processor node. If we get this ID from processor node, this ID's validity still need to be checked. Once we got a invalid NUMA ID from any processor node, the device tree will be marked as NUMA information invalid. Signed-off-by: Wei Chen --- v1 -> v2: 1. Move numa_disabled from fdt_numa_processor_affinity_init to fdt_parse_numa_cpu_node. 2. Move invalid NUMA id check to fdt_parse_numa_cpu_node. 3. Return ENODATA for normal dtb without NUMA info. 4. Use NUMA status helpers instead of SRAT functions. --- xen/arch/arm/Makefile | 1 + xen/arch/arm/include/asm/numa.h | 2 ++ xen/arch/arm/numa.c | 2 +- xen/arch/arm/numa_device_tree.c | 64 +++++++++++++++++++++++++++++++++ 4 files changed, 68 insertions(+), 1 deletion(-) create mode 100644 xen/arch/arm/numa_device_tree.c diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile index 9073398d6e..bbc68e3735 100644 --- a/xen/arch/arm/Makefile +++ b/xen/arch/arm/Makefile @@ -39,6 +39,7 @@ obj-y += mem_access.o obj-y += mm.o obj-y += monitor.o obj-$(CONFIG_NUMA) += numa.o +obj-$(CONFIG_DEVICE_TREE_NUMA) += numa_device_tree.o obj-y += p2m.o obj-y += percpu.o obj-y += platform.o diff --git a/xen/arch/arm/include/asm/numa.h b/xen/arch/arm/include/asm/numa.h index e0c909cbb7..923ffbfd42 100644 --- a/xen/arch/arm/include/asm/numa.h +++ b/xen/arch/arm/include/asm/numa.h @@ -28,6 +28,8 @@ enum dt_numa_status { DT_NUMA_OFF, }; +extern enum dt_numa_status device_tree_numa; + /* * In ACPI spec, 0-9 are the reserved values for node distance, * 10 indicates local node distance, 20 indicates remote node diff --git a/xen/arch/arm/numa.c b/xen/arch/arm/numa.c index 4dd7cf10ba..3e02cec646 100644 --- a/xen/arch/arm/numa.c +++ b/xen/arch/arm/numa.c @@ -20,7 +20,7 @@ #include #include -static enum dt_numa_status __read_mostly device_tree_numa; +enum dt_numa_status __read_mostly device_tree_numa; static unsigned char __read_mostly node_distance_map[MAX_NUMNODES][MAX_NUMNODES] = { diff --git a/xen/arch/arm/numa_device_tree.c b/xen/arch/arm/numa_device_tree.c new file mode 100644 index 0000000000..c031053d24 --- /dev/null +++ b/xen/arch/arm/numa_device_tree.c @@ -0,0 +1,64 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * Arm Architecture support layer for device tree NUMA. + * + * Copyright (C) 2022 Arm Ltd + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program. If not, see . + * + */ +#include +#include +#include +#include +#include + +/* Callback for device tree processor affinity */ +static int __init fdt_numa_processor_affinity_init(nodeid_t node) +{ + numa_set_processor_nodes_parsed(node); + device_tree_numa = DT_NUMA_ON; + + printk(KERN_INFO "DT: NUMA node %"PRIu8" processor parsed\n", node); + + return 0; +} + +/* Parse CPU NUMA node info */ +static int __init fdt_parse_numa_cpu_node(const void *fdt, int node) +{ + unsigned int nid; + + if ( numa_disabled() ) + return -EINVAL; + + /* + * device_tree_get_u32 will return NUMA_NO_NODE when this CPU + * DT node doesn't have numa-node-id. This can help us to + * distinguish a bad DTB and a normal DTB without NUMA info. + */ + nid = device_tree_get_u32(fdt, node, "numa-node-id", NUMA_NO_NODE); + if ( nid == NUMA_NO_NODE ) + { + numa_fw_bad(); + return -ENODATA; + } + else if ( nid >= MAX_NUMNODES ) + { + printk(XENLOG_ERR "DT: CPU numa node id %u is invalid\n", nid); + numa_fw_bad(); + return -EINVAL; + } + + return fdt_numa_processor_affinity_init(nid); +} -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Jan 10 08:55:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 08:55:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474495.735785 (Exim 4.92) (envelope-from ) id 1pFAPy-0006B9-5P; Tue, 10 Jan 2023 08:55:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474495.735785; Tue, 10 Jan 2023 08:55:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFAPy-0006As-1k; Tue, 10 Jan 2023 08:55:38 +0000 Received: by outflank-mailman (input) for mailman id 474495; Tue, 10 Jan 2023 08:55:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFAOs-0005oC-Ve for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 08:54:31 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2065.outbound.protection.outlook.com [40.107.105.65]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 64046635-90c4-11ed-b8d0-410ff93cb8f0; Tue, 10 Jan 2023 09:54:28 +0100 (CET) Received: from DB8PR06CA0066.eurprd06.prod.outlook.com (2603:10a6:10:120::40) by PR3PR08MB5691.eurprd08.prod.outlook.com (2603:10a6:102:82::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 08:54:26 +0000 Received: from DBAEUR03FT030.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:120:cafe::8) by DB8PR06CA0066.outlook.office365.com (2603:10a6:10:120::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:54:26 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT030.mail.protection.outlook.com (100.127.142.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:54:26 +0000 Received: ("Tessian outbound baf1b7a96f25:v132"); Tue, 10 Jan 2023 08:54:26 +0000 Received: from fdeca5795d80.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 61AE824B-371A-47A1-A627-6D734A3DBD48.1; Tue, 10 Jan 2023 08:54:18 +0000 Received: from EUR03-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id fdeca5795d80.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 10 Jan 2023 08:54:18 +0000 Received: from FR3P281CA0152.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::6) by PAXPR08MB6752.eurprd08.prod.outlook.com (2603:10a6:102:131::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 08:54:17 +0000 Received: from VI1EUR03FT055.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:a2:cafe::ac) by FR3P281CA0152.outlook.office365.com (2603:10a6:d10:a2::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.11 via Frontend Transport; Tue, 10 Jan 2023 08:54:17 +0000 Received: from nebula.arm.com (40.67.248.234) by VI1EUR03FT055.mail.protection.outlook.com (100.127.144.130) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:54:17 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 10 Jan 2023 08:54:14 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.16 via Frontend Transport; Tue, 10 Jan 2023 08:54:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 64046635-90c4-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0gPXnqAOqOIvOq2SZnrFV2Z6dU7bFkyDMdqIXXj4RZE=; b=dLHUYEMdck3Q7r4mNSrbppoSU3bhtYwYDwjvaa+hA5dIeRLEJVpawJfFwo8QidcIDwOszznDj6q2Pqegjo2Xy5jOZcvVtf77336sjcFvo17oDHzsLyM/kEMUERFc9jXxeHrpsfW8ycI2WreiCr0tpXh8RmztRwLJfK1JKnWMIZY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: fdb4868fb50ca0cb X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ea+N/6nIfTQX1zQDTrZPfLnRLTDx0+uMl03K9gBFLueweRyVU5+svrm63ncWD0Nj5p/tN6c4w+BhBAPLdmw9DnQ0JRl3fpDxlyItIL0tPSPnEgWf7CLMn+JefwPqEbX0u2EBysX2QPcfF5tb9ZeEoVWCNYeJbe8hlFC3fAnhw5vb1gkgAXs9yiWQDe5ZVw8qSkWmn9r1VPxuxcgy1cfyADHBD7PzKJTuAGEAXkiLqAOxBU53jeprvYBWD27PQ28VSupj9ucH6IhIzKiHL2VFsTT2BLxTjGccR6kuky32XOM8L7LOkyfZRjuc+bUrJfDHPaJ3FTSX7glml6WNly2ofQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0gPXnqAOqOIvOq2SZnrFV2Z6dU7bFkyDMdqIXXj4RZE=; b=Yjs+/qYvY3LWbPPqt1nOwUT+ND+0HA/2TDbVwfwejFYNbHjUKu3FlpI1tOKXABfnIGw/e+B0KVTnlo9HDIeaBnyW3BIgh8e4kI/itxDwHhowP3aFACRITi6K+0lqxCGFs6iZ05TAFrcyWzyGI1hXNkjivc52DMHAGLukD5fAAVZRq1PoXhQ0j0zDXuqA3azmZ52UkLAai4u2K+ou0Bl2yI1HckamsJjobuFx8kOvWXp8Dbbs2NSyNjOy64Q988BNklB/9OOetFF87RqDQR7mHsdX5NKuQGlfnBDBgpgRJHZNAvXwg53zQtcezdLbwZFIQXPk5qner1XTYG6sg5Rg5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0gPXnqAOqOIvOq2SZnrFV2Z6dU7bFkyDMdqIXXj4RZE=; b=dLHUYEMdck3Q7r4mNSrbppoSU3bhtYwYDwjvaa+hA5dIeRLEJVpawJfFwo8QidcIDwOszznDj6q2Pqegjo2Xy5jOZcvVtf77336sjcFvo17oDHzsLyM/kEMUERFc9jXxeHrpsfW8ycI2WreiCr0tpXh8RmztRwLJfK1JKnWMIZY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v2 11/17] xen/arm: keep guest still be NUMA unware Date: Tue, 10 Jan 2023 16:49:24 +0800 Message-ID: <20230110084930.1095203-12-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230110084930.1095203-1-wei.chen@arm.com> References: <20230110084930.1095203-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: VI1EUR03FT055:EE_|PAXPR08MB6752:EE_|DBAEUR03FT030:EE_|PR3PR08MB5691:EE_ X-MS-Office365-Filtering-Correlation-Id: aabd66b6-910a-4179-fa55-08daf2e8471c x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: WqGNSjQkcwE3hYhgl/i6TMKH6hKLRoqTgSWclNzJfnGSOP+jsoIm6RNyuxaM786eFrwi9upp3E/1vpFLtVTHpuTWEeFyFmweubKoOlVnUekjGEbYPioFVuTEQj9y1egjCcloOCh9FcP/r++oCEGHAno5WEQ675aJr6+A4iEzY4XAr6lUuSHflKUORdRVgIM8PWhhnZXg6qKbxLTjbKNSrp+ZeLT1Iv0H7GH3J/fTBiwAv/4UpDAReqTEbba+Y57cyPgHoer+4+ghJ0HoW6pNoQV8lDv+RS0QRTMhKBqNcB7BQRZnZt78vU+kcQS71EUwyJlUHDRciVJTtxYvEFhvStajLFMGFAXyoYIAQuKC+Vak5i0YbaN3rvcB9qhmbG8DCkkr18Ez+TX1amT6ZbcRXkJu6JTa4fba/NKUEUsUwmIwTuIVRV7XUz+9herG2n7kmslcs1kMQRowlg8HDl2aho6L2xgze58uX7NtyxSUlV7aaf+aDtkCJaoKpU2Zv2KEjz6/xMfbV1PtzG58Ya8DLe0tN00bkjuADq35lNp027nAploN6jsflbFJuQLdi7byCmy4KZn6nrzuy1PovYa0eaZ6LLMf10B+YyLiqRbRyRk03zNjR+YGESUlL3jVLEqjd4ysGLC+3y2JiJT96AUvil3S+aWPCnrAnMkh/jGwgjRGSTRkHj5qm3fT2TtVhBsXm5sUgt9G/NoVvIjgdGOTaQ== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(136003)(39860400002)(396003)(451199015)(46966006)(36840700001)(5660300002)(44832011)(8936002)(41300700001)(2906002)(36756003)(54906003)(8676002)(70586007)(70206006)(4326008)(316002)(6916009)(7696005)(26005)(81166007)(186003)(6666004)(86362001)(478600001)(336012)(1076003)(2616005)(40480700001)(47076005)(82740400003)(356005)(426003)(82310400005)(36860700001)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6752 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 317a562a-0aab-4700-6a6b-08daf2e8417d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ALt0lGf7OtNh/WjofST4kIl941WpNam3+GFl6K343w6KEQW/H7I+hAODHHZGVxzpt38jYmG/NT37eUmy8WwGlQkecs13NBYfqquQ7Lp1ycG7aBcgh5Xmk4HziZM535+2bAhfr6e5FK1V9eRSPoBTyssNincfZTqgdfh5r+y1qsMK1NbwrNYmQOXEwF68Wt944Btb7zl3QhpcdLnHnZMQA1H9EoWUml7Ix/0KCkmDMibjC2e+ME5Icd4FjZM47uqv3utbJfgNcc2JXv4AZ0S842CtxvQ9PDMY3ITOa/NaV7t5dSDQlbvxX8/jiihL7zLJh9hb1wNoVrcwrwzeaHb1E0Swh8dGneUQ1sQCRvYv0cqwv24e1GyVu41JSCM4BoVGq/HFcBThl11sGi5DMObJ5i5l4mNCZ+gt8cMIRu9fXhQLjI7EEmPPGKNm3nCKAAj5bXy38e3esnqtu6OM85U9t2JUVNmI3Ht6aspBmY0HZM7hPWvJmAlVko6nnBwDQN9W3MHLlMOsbtrCLb90ogksg2aUFh5JR0CZcANWHEQzp7epbVHtkCTGruv4l/E5iELaaap0zoV+/QOI+RalZq8Md/JtXHho69bN8cUKIClYX7ApUChD67+6jBc+2sNsWISz3DRF2iEcMRA+BmwkWLPU2v6j27ootAxhu2evIz6uXDrzw8mxa0MQaQbMwq55627D/QJHDv0zlcZvuNi9YE52zA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(39860400002)(376002)(346002)(451199015)(36840700001)(40470700004)(46966006)(82740400003)(81166007)(36860700001)(54906003)(8676002)(4326008)(70206006)(40460700003)(86362001)(6916009)(41300700001)(70586007)(316002)(8936002)(40480700001)(44832011)(5660300002)(2906002)(1076003)(2616005)(336012)(426003)(47076005)(82310400005)(186003)(7696005)(6666004)(478600001)(107886003)(26005)(36756003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2023 08:54:26.5762 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: aabd66b6-910a-4179-fa55-08daf2e8471c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5691 The NUMA information provided in the host Device-Tree are only for Xen. For dom0, we want to hide them as they may be different (for now, dom0 is still not aware of NUMA) The CPU and memory nodes are recreated from scratch for the domain. So we already skip the "numa-node-id" property for these two types of nodes. However, some devices like PCIe may have "numa-node-id" property too. We have to skip them as well. Signed-off-by: Wei Chen Reviewed-by: Stefano Stabellini --- v1 -> v2: 1. Add Rb --- xen/arch/arm/domain_build.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 829cea8de8..8258048d0e 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -1185,6 +1185,10 @@ static int __init write_properties(struct domain *d, struct kernel_info *kinfo, continue; } + /* Dom0 is currently NUMA unaware */ + if ( dt_property_name_is_equal(prop, "numa-node-id") ) + continue; + res = fdt_property(kinfo->fdt, prop->name, prop_data, prop_len); if ( res ) @@ -2540,6 +2544,8 @@ static int __init handle_node(struct domain *d, struct kernel_info *kinfo, DT_MATCH_TYPE("memory"), /* The memory mapped timer is not supported by Xen. */ DT_MATCH_COMPATIBLE("arm,armv7-timer-mem"), + /* Numa info doesn't need to be exposed to Domain-0 */ + DT_MATCH_COMPATIBLE("numa-distance-map-v1"), { /* sentinel */ }, }; static const struct dt_device_match timer_matches[] __initconst = -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Jan 10 09:31:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 09:31:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474571.735803 (Exim 4.92) (envelope-from ) id 1pFAyk-0003OK-0r; Tue, 10 Jan 2023 09:31:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474571.735803; Tue, 10 Jan 2023 09:31:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFAyj-0003OD-R6; Tue, 10 Jan 2023 09:31:33 +0000 Received: by outflank-mailman (input) for mailman id 474571; Tue, 10 Jan 2023 09:31:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFAyi-0003O3-OR; Tue, 10 Jan 2023 09:31:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFAyi-0001ek-L6; Tue, 10 Jan 2023 09:31:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFAyi-000096-BA; Tue, 10 Jan 2023 09:31:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pFAyi-0000qY-Al; Tue, 10 Jan 2023 09:31:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=mMUeHK7Ly81MCiQFaeLTSciSQ0R5yxSlgKIOOypV8RY=; b=gZV62RInZoKruH/c5N7ELUq3sd ss91ERjuc2idEB7b+WTZzrGJd1b83QKuVPzuD30Waw9VO2kMlV7E6UO+hkV6xSCB2Y515RX+y9cRr JF9Y18hdojIwEDtMldO2Krtmdk5g091c50ob0kTGXqb6pgzCvDtUN6NkG/EjkWc775jI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 175671: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=692d04a9ca429ca574d859fa8f43578e03b9f8b3 X-Osstest-Versions-That: xen=38525f6f73f906699f77a1af86c16b4eaad48e04 From: osstest service owner Date: Tue, 10 Jan 2023 09:31:32 +0000 flight 175671 xen-unstable real [real] flight 175692 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/175671/ http://logs.test-lab.xenproject.org/osstest/logs/175692/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail pass in 175692-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail blocked in 175651 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 175651 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 175651 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175651 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175651 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 175651 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175651 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 175651 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 175651 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 175651 test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail like 175651 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 175651 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175651 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen 692d04a9ca429ca574d859fa8f43578e03b9f8b3 baseline version: xen 38525f6f73f906699f77a1af86c16b4eaad48e04 Last test of basis 175651 2023-01-09 17:37:04 Z 0 days Testing same since 175671 2023-01-10 00:08:32 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper George Dunlap Jan Beulich Julien Grall Oleksii Kurochko jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 38525f6f73..692d04a9ca 692d04a9ca429ca574d859fa8f43578e03b9f8b3 -> master From xen-devel-bounces@lists.xenproject.org Tue Jan 10 09:39:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 09:39:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474583.735824 (Exim 4.92) (envelope-from ) id 1pFB63-0004GW-2e; Tue, 10 Jan 2023 09:39:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474583.735824; Tue, 10 Jan 2023 09:39:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFB63-0004GP-04; Tue, 10 Jan 2023 09:39:07 +0000 Received: by outflank-mailman (input) for mailman id 474583; Tue, 10 Jan 2023 09:39:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFB61-0004GJ-Od for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 09:39:05 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2051.outbound.protection.outlook.com [40.107.21.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9e6fdf76-90ca-11ed-b8d0-410ff93cb8f0; Tue, 10 Jan 2023 10:39:03 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PR3PR04MB7386.eurprd04.prod.outlook.com (2603:10a6:102:85::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 09:39:01 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5986.018; Tue, 10 Jan 2023 09:39:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9e6fdf76-90ca-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L5ot5e+fyTFJl10hHH2zNFBcd+L6Tp8bmnCN/NLItreBH1uf6vR78S9YUJHnxTp6f777fP3qXPIpb/zEd/QNsKlD1msvfVBLES2fE51BiQgzwTlg/KFf5Q3YxljM6TU81khylg3s4BDERJ24IGbkxRQJoIZFAPmaFBgQbJUeIHG8E5SGjt3kNXj6tmC6hOKWHY4eMYCBxGYkp2HAHhpPiEu5QOHw5DkUkfgkd09q7cWMek4APWYvbjj4NNwq+CjiYC65tJE8XgYrl9Cl9Qh+9siHmRPlbfMvV7uudwcaYluc939DTmQxzYF+Hzx9HH0STsgKTi7or0V5oSkm67TYbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cQeJ+AwqmXPde5CI4yD7WgZRUy/cEGl1FvE9Pxjw4uo=; b=Pb5kvVqbkdul5nXndrGV/glMMGxVlJLV1kxCJ8JeGneI6jiCUR9muX3qwug4nfFAKPVIgsOxkuYaS9/GAApaWcpNoGd+O2/vxq99QIgyV7RhnrR/jQE+UKD+8Ejjgi2FqWNW86te8ePn49lBSRhf7czh+oyv6jQFrtI2nrfcXCviyAwB47Mup8cKjv96z2JdlyXKlPE7b/Q2w7rsY8//lOmPi0CiQ7mZggaIQPuj7w7h2ugU1kxieHK7R49ZVSYyXoeqlGPDQnVh0YqEakyjgcbtIxRvbMeJgLLKfCh2VhoU9igl1XOtGpjllL7J9dCJMIiOIXgOAiQ1GFD3sW+LEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cQeJ+AwqmXPde5CI4yD7WgZRUy/cEGl1FvE9Pxjw4uo=; b=AteIyDUY35v6sNQXDEXADM+I5fLAivyxFCQkxJuHeIgbb0PJIMaUq7C5aXeJsLGfcCkY4UEskbxEvR4mct6MeIAvUso0NBOSyeVWWLitVEs70/JgGgqxh0r5z7NzUBr6WrXecwrkbd9s+9MbF1uCKCusHBAc5O0R2bJvAniierTYBi2FTY4zW7i2fYHbvRnmMpeund51zQ2KFE2rAHQwNVKnEeckTo9bWNBhXwsUikZT69tfTg642IMk4kaejXKbFFEdpM4VA1ZRxDtN67r6oY9i/2llJTIujh+Pnr1AA4S6S86g9H4Nlmt9LxjnmO7I55JdlZc1Kk1bfOuahZUteg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <1653609a-42af-b7cd-9d30-fb2bd5721080@suse.com> Date: Tue, 10 Jan 2023 10:38:58 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: Problem with pat_enable() and commit 72cbc8f04fe2 Content-Language: en-US To: Juergen Gross Cc: "linux-kernel@vger.kernel.org" , "xen-devel@lists.xenproject.org" , "Michael Kelley (LINUX)" , Andrew Lutomirski , Dave Hansen , Peter Zijlstra References: <03edcbc5-2dd7-1ddb-bafe-8412d8fc95aa@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0113.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PR3PR04MB7386:EE_ X-MS-Office365-Filtering-Correlation-Id: 55782c39-384c-4f77-2050-08daf2ee8100 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YWwdvNqmi4VLZRsO850o7cAGqXNxBJp/iDYaK0szVM9qDDM/JSxUShrwD7EfeOFfKtpC68EVujTJTywHHbjp3R9xV31CnP/yQsltHvFa/tV091KOlW0DxeVvRDFBCQOhHE/4PnWXfXImxObK6SCJ7Y7cZtWpC2faXK0h3gA1r1C3SFp2G5NQBdP/aFMctZS0NYC3HjidSxkN+3BFGKnvs4nWNxhpyiR6XUzKc++PPOuEa92wZYaSk+Gmn60C76oecf8G6iEwDmMxlryEHk4dyEE3bI2KM+Xg7GTSe1J+9sFs7SGYmMHiD6iPgTq1k6t1CKc2tc5NLBphcdXMC5bgh6/0xQ65Emj6JdhiShf1NsQi52Pk6RvPnW8NTmDJcD53DUKp8pJ63NMYRpsy39sR9Zohf0m0+U5rNYPPfidBiNEWDRoEz4wtO7pBfhDMZWYbHvQ86IojViDiDPkNd/obKuJkKk4wS+tWQOe6XQ8PmlYIEYfTEU4bhpqNQ6h6iU991EEwLm3tRe/galLe4YLCv3r6BolA642Ltpy/Rpfu8GvZMVMjqVksqKY963TlW4gI/2vFCMZvc0wE/BDJMSBhXk2DCPi2pDdKC12lLuiXk7FKMvXUZPh9h1xb+Y51LHlvfZZciCtQ5lRwVdy5SAwfThe8IMPTObcSOnfrhk+ztwZfE1KyTwKJ5qs1D/XVJQw3uL0gcVUTvpkfHedK7uv4MkvVkK0OIjnYnYRZ4SHZmTxu5nIhzqJlasxO87xyPxec X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(366004)(39860400002)(396003)(376002)(346002)(451199015)(53546011)(2906002)(6506007)(6512007)(26005)(6666004)(478600001)(31686004)(6486002)(186003)(6636002)(2616005)(316002)(54906003)(37006003)(66556008)(36756003)(66946007)(8676002)(66476007)(4326008)(41300700001)(5660300002)(8936002)(38100700002)(86362001)(83380400001)(6862004)(31696002)(98903001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YzU2ZFd2S2l6TmdlQkw0a2JONkppY3dQVTBCZzNQV212SFI5UlU3TjhCYnFR?= =?utf-8?B?QlFTVmNtZzNIWnlVR0J3UU5JazdwSnZFaEtGcTlsZnRxK3A2RkZFeThDc2Zq?= =?utf-8?B?Z05LMHZRZHZ6QVQ1M21nTXdYeVZkUWd3SC9lTFdpNXZraVV5bW05R1praFhT?= =?utf-8?B?aVZGbjhUNmxVbERudHVSK003L3pTTDZIeGdTU2VIVmp4OS9TaUZQRlV6Y1dW?= =?utf-8?B?RXk4NSt0Yzkwb0VkalJMSGtEQWZIWXlKY1JTb2ZhcHRBemJhOURpbGgrQ0x1?= =?utf-8?B?aDNTZllDSjE2M0Flbk9zUUF4d0Y0ak5nd2NjM3p0a1hEdlpWT09NT2RXeFYw?= =?utf-8?B?NVExQjNCRmJwQUpNcHJrck93SHY2UitsZU1aWWFxRjB1Z3Z2MnRLTkduYVk3?= =?utf-8?B?VW1hUktJWGxMZURKYWFWRHdnRWdWbWZZNjVVZytYS3hEVEZzdENLbTFYR1Ex?= =?utf-8?B?QnN1NHJqMG4rRWh4Q0k2bkFRWm1UZmxIZlk5VFBWZXZYSTdGUlp6aEg2cjg2?= =?utf-8?B?Q21jNkxGRG90UXpqelZiOVhSVVcyL1NTYWhNRk14N1hYY1RxWjFKdHQ2LzFk?= =?utf-8?B?bjdrREZWTTA2MmVlOUNGcTBnQ2tXeG1heVpKTzl3dkpmaDViTXhOVE14TFNG?= =?utf-8?B?cTlZL29MQmNSTS9jRTZZZnBXbjlRNEdRdjhJWkk5RVY1bDdLWlkrc1NrK0Rr?= =?utf-8?B?NG4xbUw3aTB2L2s5cWlRMm9LcGZCUDU4UWVxL0Y4NXgyS0IycEtMaFpjdDZD?= =?utf-8?B?Wlpib2poWWJvKzFMK2FLeHpHYkJLTDV2WmVTdWRFWndzQWF3RWtlekEyVnl5?= =?utf-8?B?WDJOWURLNm9Gb0JKU3dkYVBYRXczamMxNXNVV1Z4eE9VU3YxcGRDY3M5MlJK?= =?utf-8?B?U2FzOFpUbXZCQXVwNElwdysyN3NXRjFLbmErUVdSdnNBQi9wUm45ZU5iQngz?= =?utf-8?B?eDRMSXR1S2p2cDRNaTFjRFNZVUhvT0ZhMWVaWXZ0RlZZMjQvdi9ablZ1cWI5?= =?utf-8?B?T09uVi9pMGJkUi9VU3BNVVJ5K2h2OFNNMUhiRkxpKzd4WG91dnpUenNvUUZi?= =?utf-8?B?dG9VcmladU5iVFRDTytuR1JwN25nWkdmQzRpSzRFTS8zWmhqTld5ZC9nY2ov?= =?utf-8?B?UDBMQW1mdWVUdXFRYVV1QmtPVUQ4TytIc2grRzRXRm5YWTU4UyttUnc0eHBH?= =?utf-8?B?UW1aZ3R2bWNKdnNtcGQ5a0J6STdVbnVLbHRsK3hla1BDZjFUSDdTQ3VsRSs0?= =?utf-8?B?Wk1YUHJwL3haVS9rbVBhZjJreURweit0Mm9kK3JFK0VQeldvNnhDSy9UV1JM?= =?utf-8?B?WExSQlNUcHdhZjA5KzAyKzhLOVZaQkJYSnVzbHA2RU5YU0RNaFRvK1ZhdHdO?= =?utf-8?B?VVp0dktFVzMzU2NHNFZ3bHNJNkdjMWx5SGJ3RDdWRWtPYnMrU0N3dlA5UVpi?= =?utf-8?B?TVpjd1ZVMHM3ajJtQkZ2c2JJbFI4TmQ3Wm1TSGRPV0lGZndpbnA1d0lRWXpX?= =?utf-8?B?ZVBwL29vbmNoMEpRZE9GcmRpeDNRMFJrWHNIVVFMU0wzQ05vZ0hEN0lSaEha?= =?utf-8?B?Y0JOekJrWWdwY1Y0NzNHSmhiTzdlbmphUXVNQ3lDQ0tqMXhYYm9lVDQ0QXVV?= =?utf-8?B?ZW9Pa0RQYXVaOVpER2tXNE5qeitBenIzRytoOWF1Mm9IZmNHcUdSeEQ2VVFS?= =?utf-8?B?c25iVEZWdEEwV1FlNExIODVVUUJlSkxQbUI4c3IwVUQwVTJ1WXlrUFU1N0t0?= =?utf-8?B?RHhJQkR3SW1wb2RIVjQweTFCOGJrMzFMcWFjS0J1elQwWVRtc0hURkRTaFZC?= =?utf-8?B?aG5MeU9SU215RjJVcWNyb0JJZWlpV21EY2ZyMEdIdnZmbmZucWhEbXhWdC90?= =?utf-8?B?dFJvdm16TFFtd2IrK1ZwZE5Qc1VqVTMxWW5MdDV3N0txZWVZMHJIeVVyNFZj?= =?utf-8?B?U0xtU3pSRjE2T3FFd0R4UjdQY0IyNnJONHFhV0FLMlZST3JmRkxpTTg5K2o3?= =?utf-8?B?NEpYRDU3NzJENGoySHdYZGJFK3RkT1Y0QlpFK2ZtOEo4ZGpuNkJBVUxnUWxk?= =?utf-8?B?Vm43Y2VKZlM4VklMdUdjSW16MUdoNnc2NC91Q2N2eklubm5TMGRxU0doWGNC?= =?utf-8?Q?D2kDcCAVBwI7eUHpP6LGiI7FW?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 55782c39-384c-4f77-2050-08daf2ee8100 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2023 09:39:01.2691 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iMB3rXEu78pG8LBmIHS4jDVRaIiPhrtDa/I3UNm/tVSsJDkFEijEKrLZeJ3Ns1FjQadP39iWz2IN5Q3Bry4Uwg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7386 On 10.01.2023 06:59, Juergen Gross wrote: > On 10.01.23 06:47, Juergen Gross wrote: >> On 09.01.23 19:28, Michael Kelley (LINUX) wrote: >>> I've come across a case with a VM running on Hyper-V that doesn't get >>> MTRRs, but the PAT is functional.  (This is a Confidential VM using >>> AMD's SEV-SNP encryption technology with the vTOM option.)  In this >>> case, the changes in commit 72cbc8f04fe2 ("x86/PAT: Have pat_enabled() >>> properly reflect state when running on Xen") apply.   pat_enabled() returns >>> "true", but the MTRRs are not enabled. >>> >>> But with this commit, there's a problem.  Consider memremap() on a RAM >>> region, called with MEMREMAP_WB plus MEMREMAP_DEC as the 3rd >>> argument. Because of the request for a decrypted mapping, >>> arch_memremap_can_ram_remap() returns false, and a new mapping >>> must be created, which is appropriate. >>> >>> The following call stack results: >>> >>>    memremap() >>>    arch_memremap_wb() >>>    ioremap_cache() >>>    __ioremap_caller() >>>    memtype_reserve()  <--- pcm is _PAGE_CACHE_MODE_WB >>>    pat_x_mtrr_type()  <-- only called after commit 72cbc8f04fe2 >>> >>> pat_x_mtrr_type() returns _PAGE_CACHE_MODE_UC_MINUS because >>> mtrr_type_lookup() fails.  As a result, memremap() erroneously creates the >>> new mapping as uncached.   This uncached mapping is causing a significant >>> performance problem in certain Hyper-V Confidential VM configurations. >>> >>> Any thoughts on resolving this?  Should memtype_reserve() be checking >>> both pat_enabled() *and* whether MTRRs are enabled before calling >>> pat_x_mtrr_type()?  Or does that defeat the purpose of commit >>> 72cbc8f04fe2 in the Xen environment? >> >> I think pat_x_mtrr_type() should return _PAGE_CACHE_MODE_UC_MINUS only if >> mtrr_type_lookup() is not failing and is returning a mode other than WB. I agree. > Another idea would be to let the mtrr_type_lookup() stub in > arch/x86/include/asm/mtrr.h return MTRR_TYPE_WRBACK, enabling to simplify > pud_set_huge() and pmd_set_huge() by removing the check for MTRR_TYPE_INVALID. But that has a risk of ending up misleading: When there are no MTRRs, there simply is no default type (in the absence of inspecting other criteria). Jan From xen-devel-bounces@lists.xenproject.org Tue Jan 10 09:59:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 09:59:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474592.735842 (Exim 4.92) (envelope-from ) id 1pFBQ7-0006nn-R3; Tue, 10 Jan 2023 09:59:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474592.735842; Tue, 10 Jan 2023 09:59:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFBQ7-0006ng-NS; Tue, 10 Jan 2023 09:59:51 +0000 Received: by outflank-mailman (input) for mailman id 474592; Tue, 10 Jan 2023 09:59:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFBQ6-0006nY-Jq for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 09:59:50 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on2083.outbound.protection.outlook.com [40.107.14.83]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8430f5a3-90cd-11ed-b8d0-410ff93cb8f0; Tue, 10 Jan 2023 10:59:48 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8955.eurprd04.prod.outlook.com (2603:10a6:20b:40a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 09:59:45 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5986.018; Tue, 10 Jan 2023 09:59:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8430f5a3-90cd-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bxj/6fZwYIWRMudwi7gdaPMN2iZyfxm/Rq3QNmNZqcQ3sa+MN/PwQkHd/oOyJhyxPQTwkOJTdSbjPKF16Prr5CKRmEUML9dXEvc4PcFaIlSGsP0O2J9Ge/kO8RoFDi8hE3htlmMetgJjwfVIc4j5BcM2SIVlW3ajKlBJUFZu6W/JW+of12tMwoIacQhc9xENqjgCb5eomG8eKdDdA55rl/ZcpopVLiBFQbRxarlv0gqzAsw8hOHx6P+4n+PJ6jENeD9IUVPb+1YIB65pzMMkzrdilJwBljLOwTBZkYhNoDmaNcMMAmqXAO1WSFnhjhRYPPmCvZzOAQ3OBgp1uopYtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oJgTaLj0E3C8Gvf+1diGzcKyvH9w8oRVYT/kyGbpfTc=; b=S8UED2Ap7qGpA8x9aL7yQvdPARETgEYEBGXsQ5OOKDdp9GcwMcHyJ85VtQZjcqumDjAnJ1Mi57C9Z1a8NakOYjMBn01VPWZ5zsaOJGLR1POXgwdUj6fjVlgMz9OEIHzWUE/gJWzbCLsHDQNjVopnkblunHie5vBMVmFg1ElSKHXipokfnytccdUEbajqEM0KTcqDhPRqqpHYt6Lwm0t/pWJUxak3DFcKfF3CPoNnCqPO5OStyaPvHapmlEctoWfQQqFfKBii429vaEcsaskx1IW+hEtYC/JU3BasLCvv4kd627zmZgwriv52ju9FQUvwemZ9LhebyfBGNkOKo5k1Tg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oJgTaLj0E3C8Gvf+1diGzcKyvH9w8oRVYT/kyGbpfTc=; b=uPpslDZ+4ipztEd4Rdt59p02JiVjUfXN34EiYL0cG/mHy8esQsSG/tnTivos11oshGuPaeWZ2FCwvTXrQ5BanudgzyxYqAsmSryHGQSd3mh4mlO3fZS5utPpxtL0xfhKAnh3xa4OzuYi1Mq6xd0HfVXo/PdQpMseqP+hqvgNv49dV3+ZxFmYjLZq6wlGkeXieDLiT/r26zq51ePFWxIt7ZKyIVRTAYO5nrGnP4o7kUhtWxBoU0vR94erOKTEiNnc4T5GSxNGPp7H95zmHlZxiky7VHqk53iG1MuSNkwPV1v6fsk3Hv2IwG3Gs+CSIXIti+ujYacSdmS9vtUfvaPMuQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3c664437-7184-d4be-63e2-335942bb6a46@suse.com> Date: Tue, 10 Jan 2023 10:59:43 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 01/17] xen/arm: use NR_MEM_BANKS to override default NR_NODE_MEMBLKS Content-Language: en-US To: Wei Chen Cc: nd@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , xen-devel@lists.xenproject.org References: <20230110084930.1095203-1-wei.chen@arm.com> <20230110084930.1095203-2-wei.chen@arm.com> From: Jan Beulich In-Reply-To: <20230110084930.1095203-2-wei.chen@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0101.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9c::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8955:EE_ X-MS-Office365-Filtering-Correlation-Id: 5441a8fc-d943-4dde-c07e-08daf2f166ed X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SXEPyk+mO0fh5mGjXjS8qFeXyGX+DHLbGwh6+2/wzCSDGtCmncq+UWtjYKRriwzEX3W7rtkMa5uocqnpjMs4g9LqT9SqFjGjT44YlbndfQ9ctpXya9XBFAGxElR8AcUaEswEpVjQzq+TAgeXiRXNcy9QUCn0wk8DHH2iroXQy8GA0phcx8HGDAGcFepA+kGQRoXv0dUR0mAEkB/NgzeK3OxHX2pQV6FwWYEfTTxP1t4+TO2mBa95rqp18jdhOxLFqfSuDWsRpIw/BvOofyOHyohgX32EyWL/UU4/UJcW+DUDDZ5cROGWE/wuHw+FfXSY2fy2q2HgjH4UJzoOfhideYumGMlGa2gzl3Qc2dpe/BMS6yZ47MQYLibgXPCa1M18YY7EMOgNabaREykNJEAAiMoU7u9akrUUvigTW9Bp3McnN/gf7l8FEGmF5EihE+l7Cvk5SbwRPEv23czIbFVFm3lqMsuBZzod7NeamwoEa6nSUp0s2KaVvDO3mdM73CyKZStJ8fmBlgHkPSlNrvZsdc63Po3G00iABfUSt8mFp+26i9uqZmu0K+GqrFsBWBECdAo6rGQ6J8TJqsrfUe9taskGmQrzICig1BBkBgEZ7KTdCBGWWL9zkcd0Eh8L4goZ2YZU6vC5s5fbNzzsqyGYr6vTgpEKfEHTN2GX4uPcotnwcoY04SAEi//dQ0YRxYg5lMq9TC3v/v0RvSeZnQK/cev4JBK6b394GV+wRyiZjqRyGHdmspHbCTWygWvEVpHBMqKfDq3Ezaq8r7B3bhiE4w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(136003)(39860400002)(366004)(376002)(346002)(451199015)(66556008)(66899015)(31686004)(7416002)(2906002)(8936002)(5660300002)(36756003)(41300700001)(66946007)(8676002)(66476007)(316002)(4326008)(54906003)(6486002)(53546011)(6506007)(478600001)(26005)(186003)(6916009)(6512007)(2616005)(966005)(31696002)(86362001)(83380400001)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bmFXVDdsV2tTaEU5SHA5S1R1T2E1bWJMVm5aU25ibDJaaERXdUNybzc4OW9v?= =?utf-8?B?SVJoLytCVVA5eXZNOTdGWlM0enRGME5hMUJRWnBhNjROY3pRNVJxMGZJQ3pz?= =?utf-8?B?emZuRWhxVFdSaTNScGJ2Z3FzbmptU242Q2x5WFRaSWpDc25wYTIvUGtBaHNU?= =?utf-8?B?eDJBN2dqWk5PRUVUOUIwQ0ZHU3R0Z29vN29uUXdPQ0JNRk9JY3ROd3NwN2xt?= =?utf-8?B?RjFCSUZFY3FlRGJYdHpsb2k1TkdpQ054QmNkVHZEN2NnNzJXRkZkeU5ibk9l?= =?utf-8?B?U0pNeUlvaW1lZEMxVE5kT2lxYmNDTm1PVW1maE8za1BEM1VNa25ZYVpCR2Y3?= =?utf-8?B?bGtYeU5kNjhHNFRrWVpKRkxWQnlvYnJSeHd1UUswYytqNjFjbWRibXQ4aUtX?= =?utf-8?B?ZHRWd2NYUWVWaFo0SmU0dGFlRGVXVFVSaHVqWmozMXQ4RkdMcGFZblhDemt3?= =?utf-8?B?alZWVVI2Sit3aGxKZExOT0R5K3VFSnB6YW9tdDY5MHp5K0hYQVl3c2lGTGkv?= =?utf-8?B?TlhxMlZtMDJFUlFlWmUvUlczQm0rNzlHRG9FRWZQSjhqSTZpemxvaGRKM3ox?= =?utf-8?B?a1Nmeld6OFlwYWZDdGFxNVA1cEJXOUtYSFlPbFZOdkY0bVNpMmdJdlk4VTFs?= =?utf-8?B?V2tzU1RtaHZaRmhWTWZ2RUMyZjd6NGM5SjNNa095dllQNW51elhrTG5BYlBa?= =?utf-8?B?SXpzbXVsa293YjcvTzBYUjZMQWUxVHFIRC9iM0tIRGpjS0FzOTRIUTE3Slh6?= =?utf-8?B?cFpXQVAvVmpHcFQ3Q004dE9icmkyQzIxSDR1czdpbjRWQ1BSamVySm9oZ1VJ?= =?utf-8?B?RGVFVjVWRDlXWWFZZTg0dldLWTE4U2s0Y0xrQXlsUDU4ZDlYd2loLzg3SzZU?= =?utf-8?B?eGdYUjFtNWFLV0lIdHV0WWtsZGRxUUZ2WFo0bmRiVGpteUpaZW8xcTI1NGZP?= =?utf-8?B?SkMzN2tMWk10TUFPU3dPSzYzeDRQSmphNUdUYWk3VVhJazI5RHF1M2pCdWE3?= =?utf-8?B?a084Wmh4eGsxVWJ0c0NLbUc4eGpSVVQvU0ZvWUZlbEE3SEFWakZIcXJCREVj?= =?utf-8?B?bEZWWWo1SjVITW1IczhJcElITU9EYisyUjVpbG9oR3pPSnZlNDNJak5xMXp6?= =?utf-8?B?VUhrclBsUUpSRk9EcjYyNEQvOWVTamRDU0tKUUdpL0xITWJkUVE5WHFZN3JO?= =?utf-8?B?QjdFb0NZbVROMFJFa2dyU3hHaEtOUExGN0ViUFdReVJZZUJYNEdpOVg0ZUha?= =?utf-8?B?NzBXUXBnam0yK0p4UDdYUHlkSE1aNjRKY3BpSVUrOVhZSlFiN0ZtR0ZoQlFi?= =?utf-8?B?YmRYNTdwc0NtRFVqR2hRM1dFdGNoRXFiMHlSZHpjbFBPR3ZJbnVHVlJnQUZk?= =?utf-8?B?NEpEYjBzcHh0bFZXTXRXK3NqMFBHUklRU2taUlZCektkMFhMUXNoOHAvNTQ1?= =?utf-8?B?WDdVdTNwTDI1dVZMS29vVDNNalRMaUtDNVBDOHI2d0UreTNmUUxKUVFXMWFp?= =?utf-8?B?OWlXNGNNTDZZeEVjOHk4RnNjeG5HT1hJYWtDN2JDYXVTU3ZaVUE0eU5kM3Yr?= =?utf-8?B?WEIvSUZ6TVBYMGhvWS8wMEdRcTFybnZtMWZRdGRWTlZpM2FYQys0OFBTaDAw?= =?utf-8?B?emROUjJyRW9YckZmOVJuSmV0TDZRd1JJZ0dPSWxMOC9OcFg2cExQeWdCQVFp?= =?utf-8?B?Sm1rVkh1eDJJSEpYT0ZITWtLb0o5c2VnTGZIcU5FbS9jRGF4ZFBPcWpQaTZR?= =?utf-8?B?bWc2RElNMDFaaFc3cysyRTQ3anRkZTV3UVJXU0R6VSsxa0NMQkkwbFdaOXND?= =?utf-8?B?enp1SVpVN2svdmxYaEZFZzRtV09UZUFNVHR3WC9LTTY5TER5TXlVRUU3bmJj?= =?utf-8?B?Q1FZSEpsQmF4aWN2YUV3STIzNktzN3NSZEhzRWgyckxTaWQ4S0NoLzh4MU1w?= =?utf-8?B?SXRhV0d0ZTBSaWhNZ255aWFNamkvQWZrY0s0aWtPWlo5QlhFaWlWc1VUZFRu?= =?utf-8?B?STk3ZFF6Y1A5bEpoSkYyNEd2U0pGdFJKN2dnU2lTRmNYQzZoV3pyNytNY1B5?= =?utf-8?B?YzY4UXpEdmN1cDR6dndPNmE5ME1PeGFEcWNHdVlaRFY5b1NLcEEwTFA4NHAv?= =?utf-8?Q?TAGb2KGgLh6eJ9JWs9AHloJ7Y?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5441a8fc-d943-4dde-c07e-08daf2f166ed X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2023 09:59:45.5493 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mnAqYjHZ+v0NpntBDFARzaegHXnSgNdYOWLrbv+BqR4nVQWs8SKKdbHPelrhCeDctE61zidTYExZwU40hunjuw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8955 On 10.01.2023 09:49, Wei Chen wrote: > --- a/xen/arch/arm/include/asm/numa.h > +++ b/xen/arch/arm/include/asm/numa.h > @@ -3,9 +3,26 @@ > > #include > > +#include > + > typedef u8 nodeid_t; > > -#ifndef CONFIG_NUMA > +#ifdef CONFIG_NUMA > + > +/* > + * It is very likely that if you have more than 64 nodes, you may > + * need a lot more than 2 regions per node. So, for Arm, we would > + * just define NR_NODE_MEMBLKS as an alias to NR_MEM_BANKS. > + * And in the future NR_MEM_BANKS will be bumped for new platforms, > + * but for now leave NR_MEM_BANKS as it is on Arm. This avoid to > + * have different way to define the value based NUMA vs non-NUMA. > + * > + * Further discussions can be found here: > + * https://lists.xenproject.org/archives/html/xen-devel/2021-09/msg02322.html > + */ > +#define NR_NODE_MEMBLKS NR_MEM_BANKS But isn't NR_MEM_BANKS a system-wide setting, which doesn't really make sense to use as a per-node one? IOW aren't you now allowing NR_MEM_BANKS regions on each node, which taken together will be much more than NR_MEM_BANKS that you can deal with on the whole system? Jan From xen-devel-bounces@lists.xenproject.org Tue Jan 10 10:01:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 10:01:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474598.735853 (Exim 4.92) (envelope-from ) id 1pFBRL-0008Cu-55; Tue, 10 Jan 2023 10:01:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474598.735853; Tue, 10 Jan 2023 10:01:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFBRL-0008Cn-1o; Tue, 10 Jan 2023 10:01:07 +0000 Received: by outflank-mailman (input) for mailman id 474598; Tue, 10 Jan 2023 10:01:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFBRJ-0008Ch-AY for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 10:01:05 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b199fd20-90cd-11ed-91b6-6bf2151ebd3b; Tue, 10 Jan 2023 11:01:04 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id BB39968094; Tue, 10 Jan 2023 10:01:03 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 846B41358A; Tue, 10 Jan 2023 10:01:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id YPT8Hl83vWPrRgAAMHmgww (envelope-from ); Tue, 10 Jan 2023 10:01:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b199fd20-90cd-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1673344863; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UwDp5XYDAC2Q9q+rKMqs99kfvtsDPmiiS62MPkYcPFg=; b=uV35YrM8vCb/3Yuy98VTRDwPJ3S8FEJxA2CzXaVSVHOi+6DZ+hoDgzpEC6oHKTedPIykJw kKtEO71vvi4QER9/xBEHygk3emUBiS7cystV35PJ15yR3YqwJ61SkXv7n8xgleYiNSt9yv 1FTW4yr/XTnha8aPnX16oJWoWx5YVzo= Message-ID: <00df09fe-bd71-9204-18f2-6479c91dc4b0@suse.com> Date: Tue, 10 Jan 2023 11:01:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Content-Language: en-US To: Jan Beulich Cc: "linux-kernel@vger.kernel.org" , "xen-devel@lists.xenproject.org" , "Michael Kelley (LINUX)" , Andrew Lutomirski , Dave Hansen , Peter Zijlstra References: <03edcbc5-2dd7-1ddb-bafe-8412d8fc95aa@suse.com> <1653609a-42af-b7cd-9d30-fb2bd5721080@suse.com> From: Juergen Gross Subject: Re: Problem with pat_enable() and commit 72cbc8f04fe2 In-Reply-To: <1653609a-42af-b7cd-9d30-fb2bd5721080@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------orkPXvNaufX9x9hz0ec9o6vR" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------orkPXvNaufX9x9hz0ec9o6vR Content-Type: multipart/mixed; boundary="------------vYkKADx0yfD0N7Rcj8wnZweX"; protected-headers="v1" From: Juergen Gross To: Jan Beulich Cc: "linux-kernel@vger.kernel.org" , "xen-devel@lists.xenproject.org" , "Michael Kelley (LINUX)" , Andrew Lutomirski , Dave Hansen , Peter Zijlstra Message-ID: <00df09fe-bd71-9204-18f2-6479c91dc4b0@suse.com> Subject: Re: Problem with pat_enable() and commit 72cbc8f04fe2 References: <03edcbc5-2dd7-1ddb-bafe-8412d8fc95aa@suse.com> <1653609a-42af-b7cd-9d30-fb2bd5721080@suse.com> In-Reply-To: <1653609a-42af-b7cd-9d30-fb2bd5721080@suse.com> --------------vYkKADx0yfD0N7Rcj8wnZweX Content-Type: multipart/mixed; boundary="------------KeddABKumQSF93NckVqhMfMH" --------------KeddABKumQSF93NckVqhMfMH Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTAuMDEuMjMgMTA6MzgsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAxMC4wMS4yMDIz IDA2OjU5LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gT24gMTAuMDEuMjMgMDY6NDcsIEp1 ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+Pj4gT24gMDkuMDEuMjMgMTk6MjgsIE1pY2hhZWwgS2Vs bGV5IChMSU5VWCkgd3JvdGU6DQo+Pj4+IEkndmUgY29tZSBhY3Jvc3MgYSBjYXNlIHdpdGgg YSBWTSBydW5uaW5nIG9uIEh5cGVyLVYgdGhhdCBkb2Vzbid0IGdldA0KPj4+PiBNVFJScywg YnV0IHRoZSBQQVQgaXMgZnVuY3Rpb25hbC7CoCAoVGhpcyBpcyBhIENvbmZpZGVudGlhbCBW TSB1c2luZw0KPj4+PiBBTUQncyBTRVYtU05QIGVuY3J5cHRpb24gdGVjaG5vbG9neSB3aXRo IHRoZSB2VE9NIG9wdGlvbi4pwqAgSW4gdGhpcw0KPj4+PiBjYXNlLCB0aGUgY2hhbmdlcyBp biBjb21taXQgNzJjYmM4ZjA0ZmUyICgieDg2L1BBVDogSGF2ZSBwYXRfZW5hYmxlZCgpDQo+ Pj4+IHByb3Blcmx5IHJlZmxlY3Qgc3RhdGUgd2hlbiBydW5uaW5nIG9uIFhlbiIpIGFwcGx5 LsKgwqAgcGF0X2VuYWJsZWQoKSByZXR1cm5zDQo+Pj4+ICJ0cnVlIiwgYnV0IHRoZSBNVFJS cyBhcmUgbm90IGVuYWJsZWQuDQo+Pj4+DQo+Pj4+IEJ1dCB3aXRoIHRoaXMgY29tbWl0LCB0 aGVyZSdzIGEgcHJvYmxlbS7CoCBDb25zaWRlciBtZW1yZW1hcCgpIG9uIGEgUkFNDQo+Pj4+ IHJlZ2lvbiwgY2FsbGVkIHdpdGggTUVNUkVNQVBfV0IgcGx1cyBNRU1SRU1BUF9ERUMgYXMg dGhlIDNyZA0KPj4+PiBhcmd1bWVudC4gQmVjYXVzZSBvZiB0aGUgcmVxdWVzdCBmb3IgYSBk ZWNyeXB0ZWQgbWFwcGluZywNCj4+Pj4gYXJjaF9tZW1yZW1hcF9jYW5fcmFtX3JlbWFwKCkg cmV0dXJucyBmYWxzZSwgYW5kIGEgbmV3IG1hcHBpbmcNCj4+Pj4gbXVzdCBiZSBjcmVhdGVk LCB3aGljaCBpcyBhcHByb3ByaWF0ZS4NCj4+Pj4NCj4+Pj4gVGhlIGZvbGxvd2luZyBjYWxs IHN0YWNrIHJlc3VsdHM6DQo+Pj4+DQo+Pj4+ICDCoMKgIG1lbXJlbWFwKCkNCj4+Pj4gIMKg wqAgYXJjaF9tZW1yZW1hcF93YigpDQo+Pj4+ICDCoMKgIGlvcmVtYXBfY2FjaGUoKQ0KPj4+ PiAgwqDCoCBfX2lvcmVtYXBfY2FsbGVyKCkNCj4+Pj4gIMKgwqAgbWVtdHlwZV9yZXNlcnZl KCnCoCA8LS0tIHBjbSBpcyBfUEFHRV9DQUNIRV9NT0RFX1dCDQo+Pj4+ICDCoMKgIHBhdF94 X210cnJfdHlwZSgpwqAgPC0tIG9ubHkgY2FsbGVkIGFmdGVyIGNvbW1pdCA3MmNiYzhmMDRm ZTINCj4+Pj4NCj4+Pj4gcGF0X3hfbXRycl90eXBlKCkgcmV0dXJucyBfUEFHRV9DQUNIRV9N T0RFX1VDX01JTlVTIGJlY2F1c2UNCj4+Pj4gbXRycl90eXBlX2xvb2t1cCgpIGZhaWxzLsKg IEFzIGEgcmVzdWx0LCBtZW1yZW1hcCgpIGVycm9uZW91c2x5IGNyZWF0ZXMgdGhlDQo+Pj4+ IG5ldyBtYXBwaW5nIGFzIHVuY2FjaGVkLsKgwqAgVGhpcyB1bmNhY2hlZCBtYXBwaW5nIGlz IGNhdXNpbmcgYSBzaWduaWZpY2FudA0KPj4+PiBwZXJmb3JtYW5jZSBwcm9ibGVtIGluIGNl cnRhaW4gSHlwZXItViBDb25maWRlbnRpYWwgVk0gY29uZmlndXJhdGlvbnMuDQo+Pj4+DQo+ Pj4+IEFueSB0aG91Z2h0cyBvbiByZXNvbHZpbmcgdGhpcz/CoCBTaG91bGQgbWVtdHlwZV9y ZXNlcnZlKCkgYmUgY2hlY2tpbmcNCj4+Pj4gYm90aCBwYXRfZW5hYmxlZCgpICphbmQqIHdo ZXRoZXIgTVRSUnMgYXJlIGVuYWJsZWQgYmVmb3JlIGNhbGxpbmcNCj4+Pj4gcGF0X3hfbXRy cl90eXBlKCk/wqAgT3IgZG9lcyB0aGF0IGRlZmVhdCB0aGUgcHVycG9zZSBvZiBjb21taXQN Cj4+Pj4gNzJjYmM4ZjA0ZmUyIGluIHRoZSBYZW4gZW52aXJvbm1lbnQ/DQo+Pj4NCj4+PiBJ IHRoaW5rIHBhdF94X210cnJfdHlwZSgpIHNob3VsZCByZXR1cm4gX1BBR0VfQ0FDSEVfTU9E RV9VQ19NSU5VUyBvbmx5IGlmDQo+Pj4gbXRycl90eXBlX2xvb2t1cCgpIGlzIG5vdCBmYWls aW5nIGFuZCBpcyByZXR1cm5pbmcgYSBtb2RlIG90aGVyIHRoYW4gV0IuDQo+IA0KPiBJIGFn cmVlLg0KPiANCj4+IEFub3RoZXIgaWRlYSB3b3VsZCBiZSB0byBsZXQgdGhlIG10cnJfdHlw ZV9sb29rdXAoKSBzdHViIGluDQo+PiBhcmNoL3g4Ni9pbmNsdWRlL2FzbS9tdHJyLmggcmV0 dXJuIE1UUlJfVFlQRV9XUkJBQ0ssIGVuYWJsaW5nIHRvIHNpbXBsaWZ5DQo+PiBwdWRfc2V0 X2h1Z2UoKSBhbmQgcG1kX3NldF9odWdlKCkgYnkgcmVtb3ZpbmcgdGhlIGNoZWNrIGZvciBN VFJSX1RZUEVfSU5WQUxJRC4NCj4gDQo+IEJ1dCB0aGF0IGhhcyBhIHJpc2sgb2YgZW5kaW5n IHVwIG1pc2xlYWRpbmc6IFdoZW4gdGhlcmUgYXJlIG5vIE1UUlJzLCB0aGVyZQ0KPiBzaW1w bHkgaXMgbm8gZGVmYXVsdCB0eXBlIChpbiB0aGUgYWJzZW5jZSBvZiBpbnNwZWN0aW5nIG90 aGVyIGNyaXRlcmlhKS4NCg0KSSd2ZSBzZW50IGEgcGF0Y2ggY2hlY2tpbmcgZm9yIE1UUlJf VFlQRV9JTlZBTElEIGluIHBhdF94X210cnJfdHlwZSgpLiBUaGlzDQpzZWVtZWQgdG8gYmUg YSBsZXNzIGludHJ1c2l2ZSBjaGFuZ2UuDQoNClRoZSBpZGVhIHRvIG1vZGlmeSB0aGUgc3R1 YiBjYW1lIHVwIGFzIGEgcmVzdWx0IG9mIGxvb2tpbmcgYXQgbXRycl90eXBlX2xvb2t1cCgp DQp1c2UgY2FzZXMgYWZ0ZXIgd3JpdGluZyBteSBwYXRjaC4gQWxsIHVzZXJzIG5vdyB0YWtl IGFuIGFjdGlvbiBpZiB0aGUgcmV0dXJuZWQNCnR5cGUgaXMgbm90IFdCIGFuZCBub3QgSU5W QUxJRC4gU28gaXQgd291bGQgYmUgYSBtb2RpZmljYXRpb24gdGFpbG9yZWQgZm9yDQp0b2Rh eSdzIG10cnJfdHlwZV9sb29rdXAoKSB1c2VycyBvbmx5Lg0KDQoNCkp1ZXJnZW4NCg== --------------KeddABKumQSF93NckVqhMfMH Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------KeddABKumQSF93NckVqhMfMH-- --------------vYkKADx0yfD0N7Rcj8wnZweX-- --------------orkPXvNaufX9x9hz0ec9o6vR Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmO9N18FAwAAAAAACgkQsN6d1ii/Ey9A 6wf/QDNuFDIZkOpSywJRLkULG6bKCjqnvQ7JbuaoaxVkVj3Nm+umRDzQw+UMWdrhDM8rPSAAPRma buW5agDFnucjo1JRNjzoE9VVQJkGkWvZksYX5dx2Zkh0dI3rARgV73+/kXcWb2r4XXEYnpwFcYXf H9aCrCndCoIllJWrKZDP3TYNTiA7VzfPsuOvcmRfkr0bQM2NsBPfApM28UQ5h/Kb7CMCzUJ/ZS6S mdE2bxqZoAn06jEPqK6hEB3wS5FSg9rjt2qSAOjASXVf79LCqE8clE3HIqzkrqR85lv/qF4B2nbi Yqq6O1y8BxRMqWnxTdi4wf6v2LZ0LKiweubtf3Ipbw== =t3Ib -----END PGP SIGNATURE----- --------------orkPXvNaufX9x9hz0ec9o6vR-- From xen-devel-bounces@lists.xenproject.org Tue Jan 10 10:01:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 10:01:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474605.735864 (Exim 4.92) (envelope-from ) id 1pFBS8-0000NP-IF; Tue, 10 Jan 2023 10:01:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474605.735864; Tue, 10 Jan 2023 10:01:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFBS8-0000NI-EW; Tue, 10 Jan 2023 10:01:56 +0000 Received: by outflank-mailman (input) for mailman id 474605; Tue, 10 Jan 2023 10:01:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFBS7-0000HN-Fb for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 10:01:55 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2056.outbound.protection.outlook.com [40.107.21.56]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cefc20db-90cd-11ed-b8d0-410ff93cb8f0; Tue, 10 Jan 2023 11:01:53 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PR3PR04MB7403.eurprd04.prod.outlook.com (2603:10a6:102:8b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 10:01:52 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5986.018; Tue, 10 Jan 2023 10:01:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cefc20db-90cd-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FRrD8XeNmm81lZ6RzH90uLTYgwD69Ss4T/Qu0mz0AaMy+AMpRt2MxCRcfQ1Xusa0L/D0Cdi++XpZPLLhzBKg5546I3xowsMEg/D9aarGrYWa2UFVLn7D44G8dmD1qxBLAvY7EFdo+8+DOIvKNXaETui9XEp7Fozc9tzl8sSAIjqahlRfrBKA1RX5sQjVBrdyLH8OaiXOkVtl5THLCB026DNr/YjLsI64yI5jB629TYEiOh4Ur0Oo6gCHjZ5463IN56QLsMpY7ph078ccEpsWImj5/ze5YxkoX4yuu9aZu/b7oIn2msItXd4Td7xSq3yib0cqssJiXh6QuYeWW3iqAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BlSIp38KmCDogYRPIN4hEZ5Ie+tbUo38UsCscNJhcl8=; b=LGFVhoflcgqO6E3kRG6d5cJGubFGb33FcFuIsUDCpTKo03mdkCSgt8rYd8OOWdj+JKwq43hFZHqXRvhqpqipBReUn+dR5oV2wpf/lwcsElYh+16T632XqoacRyGxW16OWa7Luq+qOTWs/xWGU8CP113k+9z95cB27ikamhqx9VCqMCOXsLlVvxoRx4FUZQkXsTE3X9RfK20i4dKowLJ6ze5Rpq3W1UvbtEK72WrGqMwZlxiOvucf62CR64Q8TW/vabtQroKP9NQPr35aDI368ZatqLAs5GayHBuk63uZ4QwMWDWoHCkDl7eiaIfcYj/2FPnjU5CwOHQR5j4YgKtecA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BlSIp38KmCDogYRPIN4hEZ5Ie+tbUo38UsCscNJhcl8=; b=qzWPmXXGc6DCblYDLXBnO4MNxHKbp2Hy+rtDaSrYRLT5nSEHQ6e5x8MaaengdMrEVVdOk6KTTRAlxZGr3oHrng3klZzUQFBqu0GQnZyov68IHcASXni9ygcyqwI2F6Q5VnnAnz3WYZwWX0W4L1s16aBxtshRW6u04c3//Vu1Al0w1NPcr2uRBdO4fJTN6Lm5GfPn1VIOWu0koLl55jHUjxFb6iYc82p3pt9TK2DGBpF6qGyvuknmbwUpD6jA22JRfmq2PG00sAfPcgwHnJYuAYgPX6UGwPpsvOui3mDJPZZ0SrsFVivr9AojMZCR+NLcgibFD9ozPfm2clVm++1zAw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <379a86b8-837c-9b95-7737-1446c1967666@suse.com> Date: Tue, 10 Jan 2023 11:01:49 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 17/17] docs: update numa command line to support Arm Content-Language: en-US To: Wei Chen Cc: nd@arm.com, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20230110084930.1095203-1-wei.chen@arm.com> <20230110084930.1095203-18-wei.chen@arm.com> From: Jan Beulich In-Reply-To: <20230110084930.1095203-18-wei.chen@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DBBPR09CA0031.eurprd09.prod.outlook.com (2603:10a6:10:d4::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PR3PR04MB7403:EE_ X-MS-Office365-Filtering-Correlation-Id: 672bc308-14f8-40fd-bda3-08daf2f1b24b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Nl2weA04A0dXcOoqWbdb7ab25RqBYZtkNzYEExEc83oNv52tgKdhuoqfD3dyf+Qu//YyfRdSbJSVE4hIgOCIVoiay+LRoUhDRHJPCtekNJ7kL2yW66Xoejdi3pCUCToEo+9iFUH0d/GxjjHmvTfVy/izoocCpsyO7g4bIzZnB9kkcl5yRVqRDOaE3mfbwRUVSDo7ljfAyY3Jzew7tJ/h1Pmmq7lh5mZ+RjsLt41lj8UXWflL/0Ne4s8UMCbiAQ53kzsoQwlOCbZmn0+iLGlcng+6FI8CKGpeMmNJrFlXJ5/XBdR3n/uYfglkDZTWdgXVlP0KNUIuNk0Lwc+u6N7DmTWY8ErObUTk+GJQ4zDLhPjdS2V7Fyl0f1EMkGepovyBdnXabIl6qn1XvYehSAJaAGPYC1KR9r6RE0h8tJ28urK9G02vjEmXKB/1fOhO3lV9TZkP3t9/IfeMrClO/AsXReqYoGsvjUZpmdzA4nV0xK1SdGA/zhNc5fV2dm9DWX2l4XsgFRL/qpjD60qYEXH7qFJE69exPTWVjvrOOwdMDTj/1+SPMPqpMh4i9/K7M4brgSTNx4Y02tPnawyaFsVY3rbURyq4XZ+wGlLxlAlVDpR57qQ+IxHula8F76AgLXxm1jqD8k9H/p/CMrqXLu7e6YWvbWPdmSmgRBr6zIYm5gTBZOGIY9Ehv608vt94IdLYfvY3lqhJVvsd2YuZtJn3mt8NLpEDUHsEtHID2022zkI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(366004)(346002)(396003)(376002)(39860400002)(451199015)(66946007)(31686004)(41300700001)(2906002)(8936002)(36756003)(5660300002)(4744005)(8676002)(66476007)(6916009)(6512007)(66556008)(316002)(54906003)(6666004)(6486002)(53546011)(478600001)(6506007)(186003)(4326008)(26005)(2616005)(31696002)(83380400001)(86362001)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Uk5XemFLQXRqQm9EVkNoSUtnM0pKeVVhcllRV1lEcWZrVW81anpUQkcyN3B0?= =?utf-8?B?R05RdWZQd0MzZHlSTzNWNFlLdzZwZ2UxekJFT3RjVXFNSnlUTVYyK3NnRk9D?= =?utf-8?B?dFdQWHoxYnoyVnVhUWw1UlhCay9KMW55VHlNeVljUFFpZk8rVHVQVlJycEhZ?= =?utf-8?B?RkFqQkxUUE0zd0VJQVJFTmFIYzFCUXBQeXRNTGZoTVBmaVhiOU5abXlMdWdW?= =?utf-8?B?MmlTR1RrUmlDdzF6L0ZLcUtkRVpTa2g2WnBNdTNPdHFpcUZIb3hLa01kaUhm?= =?utf-8?B?R0dMSDhEV1JNQkhlVXN2cjRTWmt0bzlxM29Oc0kzblY4Y2lNelBHZkJmOHg4?= =?utf-8?B?cUZpVy9kbTRoYWNUSUs0WlZNK05pMXFabzZuV1ZRS0FzeW15TEJPQWNoL0NX?= =?utf-8?B?UFR1eXRCTnRVS094VnZPQS9CYjErZDZGb1Q0SG50UW5qK0wrc250ZGExdGJt?= =?utf-8?B?U3ZFR3RiS2N2UG1uK1ovUzlldXVJYWV1d0FWRWN6ODhnWDVaNHBpYnduaDRr?= =?utf-8?B?blV5QWdrM0pGRTU2a2EweVZwdmR0RWtnOUlHdzZraWQzOTVUcmVhZElwek12?= =?utf-8?B?cHdIM3VEd1VrbkZ4bVMzRlZpaGtCajdWSHBJNmtPUmR5SHBrbXRrUHpqNEJG?= =?utf-8?B?RzRqeUNSNHI4U1p2ZUJWR2xYWVNxTGE1N056UU5wanhRSTJXSXM5UkNQN1l3?= =?utf-8?B?djVMVnpHSHBCQndxTFVHODFQdUgwK1ZpL3NZMVdkZ1FWd01JY3BJbEhOdW1W?= =?utf-8?B?Y3ZpcElBdUNXMHNCWDc2NTk5dU9yQmd3Q1FIMFJ5MHVsclh3Q3UyOTlGamwz?= =?utf-8?B?K2NHMHN2Qm9BR1BLTUNKdmNGamVQNTRhcWZXYlFET1AzQlFNeDNRZTIyV0xU?= =?utf-8?B?eG5YU2U5RGsyTXV5V1NtYVI0Snc3V0hldmRCY2xQMlRnVEFOMFJVRFFoZTZ0?= =?utf-8?B?WmdiMXVGTlhEbEkrbWxpaXRPWjlRYjRGSjJSVVkrSjlTdVMzVEJOcHZZaDBz?= =?utf-8?B?UlEyWksrSTU0b3I4VHZUKzErYzVuSDFKQjROcWlaeG1zZzh3VWtDQks4R2tp?= =?utf-8?B?QXZwZjU2bkpOVk9JM3pDMFB5eVlGbm03TFo3M01wc0FSSGI5RkR4b2ExaVdR?= =?utf-8?B?cWJsMWRTQjVzV09HVjhPbG1mY3JYdHVBcjQ0ejNUMGFKbVZOQ2RyS2xvUThr?= =?utf-8?B?NjVzMHBReFVGczJZQmx6eWIxbGdFazZrbW9aSXlwTXl5bnRYdVVkVkwvWFNR?= =?utf-8?B?ZmZsQ0tJVmgyb2c4NGRmVm1pN2lkblVjUnpGbnhZOU1rUEpZM0d5WGE2Ylds?= =?utf-8?B?dEdkd2JjZzVGbjZOU25kTWp0U08zYkFMMm1vZFBYMjI2Z3dLd0dpcmFkdVE2?= =?utf-8?B?VHIvcEZaZnczaXlRZ09mck53RGhqSUlKWitid2Z2Rm5OKzA0RDNCR0Q1bVA0?= =?utf-8?B?OElNSVZzeDc3aTJLQTZDQUpQbDlMV3NDYjVrM2IxVkR4U3FjNlR1OTVPQmJT?= =?utf-8?B?cXczUVhIV1l1YjNJdFNZMVJnQWhBZkRwa1Z5dXBKV0UrUFRBc0J0MS9WUWcx?= =?utf-8?B?eXlYYnViZnYzQ0pDTmpiQXI2OEJKZEdPN00xU2lvcEhPNC8reHNqVlozTkJW?= =?utf-8?B?SFY2N29JaCt0NWRneHUrdGFwSXAxV1E3NytEeVVzNnRreDR4bUFrUldydVBj?= =?utf-8?B?eDJHa0JEWnova1F2WEdGRmpiMEQ2Y1JBWi9BYlhqdnQ2THRQQnNNSnREaVQz?= =?utf-8?B?N0J0R05RcEhmVXRFSzVTZElSVlVwUVFUOXhPZ1p0TDlSRzBmc2N0RndpRi9U?= =?utf-8?B?dXd5TW1GVmFWbUFyNzZhK2RqNy83SzFmV3I5Y08zNVhMZThVcG93eVZNa3N4?= =?utf-8?B?a2Z0YlZla2prdGh2VDE2TDJ3TjBZVUhYNXVGdFZKck4zdzBPaEEzYzhObnBQ?= =?utf-8?B?c1V5T3NoVlZwZTZRVXNqTDJ1Wi9iMndHMDhBOFZMTFNVeWd6clFHZHhhNEJS?= =?utf-8?B?YjdQRW12cDlyZld4Y1NKTEJ2eFBNYW5Va04veGVRUW5NK1ZXZ2JoRFRjYnQ0?= =?utf-8?B?dkdsQXA0Z3FiSEQvQkM5K2hnZkUwTHp0MUd2cFFMalF4d25EeUdXNlhuck5O?= =?utf-8?Q?ayDW9BScEkbBz3I37p/2k0oGa?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 672bc308-14f8-40fd-bda3-08daf2f1b24b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2023 10:01:52.0569 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WvnTVH31MzmFEJ2zdc8g+YndeLbhJc39BGHbNSZ0AssLTuz8xrgA3tr2WzpWSlE3ziWG9vycEDwEa5ZXOAloYg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7403 On 10.01.2023 09:49, Wei Chen wrote: > Current numa command in documentation is x86 only. Remove > x86 from numa command's arch limitation in this patch. > > Signed-off-by: Wei Chen Acked-by: Jan Beulich Of course not on its own, only on top of all the earlier patches. Jan From xen-devel-bounces@lists.xenproject.org Tue Jan 10 10:47:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 10:47:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474617.735886 (Exim 4.92) (envelope-from ) id 1pFCAL-00050j-4A; Tue, 10 Jan 2023 10:47:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474617.735886; Tue, 10 Jan 2023 10:47:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFCAL-00050c-1c; Tue, 10 Jan 2023 10:47:37 +0000 Received: by outflank-mailman (input) for mailman id 474617; Tue, 10 Jan 2023 10:47:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFCAJ-00050W-Pu for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 10:47:35 +0000 Received: from mail-vs1-xe2e.google.com (mail-vs1-xe2e.google.com [2607:f8b0:4864:20::e2e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3048550d-90d4-11ed-91b6-6bf2151ebd3b; Tue, 10 Jan 2023 11:47:34 +0100 (CET) Received: by mail-vs1-xe2e.google.com with SMTP id t10so1219570vsr.3 for ; Tue, 10 Jan 2023 02:47:34 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3048550d-90d4-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=B77Khf8eYDJk70YMPWZP9aMu4CFf5/qt+dAtcpnZZjE=; b=GsSkzKr/BqvZWNZbiH6lpNMNzTtOwRClmyeSVkEviNpZrSWpXIQt5rmbownh6RQRMj d4RyhpGx9ygjqV7Dt3T7YnaA3yqgycGhRO41Pb4l9hhbWxOXLb5EHaVun9Dr3TW8n2Ek skLYxjVlEXa087vZzbXBciQ3UrvhAdUXl9/3q3OUjyGr+MbwgaiDm7W2fJcx/dcK58qP Z196Ee4/8CoFfkwL9JFT+5HbPzGW4xYngK4IcnSNJhADdb/Z3z6wBa0zxETBH5xCpAzg tcojBpGofBwUbcNESBYUDAxvGkN7iSXiblTQtI2+ElUJYxBoY/zIHRNe0553e/DXn6Cj POUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=B77Khf8eYDJk70YMPWZP9aMu4CFf5/qt+dAtcpnZZjE=; b=79OSWwLs4OAyMO94MU+v/aQ4weIOjrubNF36MiBguDLCRgC9ORjkDf99QbXRgcnJeL iTBzsNRli/G6UblumlkiG57Ro2u31mmLSXIuQzjt4icWvCYLMBP2jLg8zezE+MKCM6cl bz72BE8isCm7yN3YZliZqsu8684qX0Oc7cn4YjdXbY4kRMLMj33/jFpFTUc3ciFtn33J s9NC2Gl6Q36HmhyxyZw36hvxl6wXkONwoM5yivceUClIdcrUm7cILVuLpix/mmQ00Azm 83mF/m+yobZLZtz3ee8Fj2S0h+liUqsx/5nGkGV1k4ncVs3y09MXNE73SbxPRZ+nnLGO V2zg== X-Gm-Message-State: AFqh2kpnev6+4xLf54tg6NfxLHaZSt7tZxukcNTWB6UecftgmL9GF8fs F3x8beuJQy3T0kL88ku+SY2qj9cfDHR5Uhq+104= X-Google-Smtp-Source: AMrXdXswGahfWIyssunSTOjj4V0CO295VYHGFOc99NduNK0ZNED4UV62lz+Xttu1SaKmFWAnGj97AoIcQKsSpdTv8e4= X-Received: by 2002:a05:6102:f8c:b0:3c9:8cc2:dd04 with SMTP id e12-20020a0561020f8c00b003c98cc2dd04mr7492001vsv.73.1673347653105; Tue, 10 Jan 2023 02:47:33 -0800 (PST) MIME-Version: 1.0 References: <527727b2c9e26e6ef7714fe9a3fbe580caf1ae13.1673278109.git.oleksii.kurochko@gmail.com> In-Reply-To: From: Alistair Francis Date: Tue, 10 Jan 2023 20:47:06 +1000 Message-ID: Subject: Re: [PATCH v2 6/8] xen/riscv: introduce early_printk basic stuff To: Bobby Eshleman Cc: Alistair Francis , Andrew Cooper , Connor Davis , Gianluca Guida , Jan Beulich , Julien Grall , Oleksii Kurochko , Stefano Stabellini , xen-devel@lists.xenproject.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Jan 10, 2023 at 5:29 PM Bobby Eshleman w= rote: > > > > On Mon, Jan 9, 2023 at 4:28 PM Alistair Francis wr= ote: >> >> On Tue, Jan 10, 2023 at 1:47 AM Oleksii Kurochko >> wrote: >> > >> > The patch introduces a basic stuff of early_printk functionality >> > which will be enough to print 'hello from C environment". >> > early_printk() function was changed in comparison with original as >> > common isn't being built now so there is no vscnprintf. >> > >> > Because printk() relies on a serial driver (like the ns16550 driver) >> > and drivers require working virtual memory (ioremap()) there is not >> > print functionality early in Xen boot. >> > >> > This commit adds early printk implementation built on the putc SBI cal= l. >> > >> > As sbi_console_putchar() is being already planned for deprecation >> > it is used temporary now and will be removed or reworked after >> > real uart will be ready. >> >> There was a discussion to add a new SBI putchar replacement. It >> doesn't seem to be completed yet, but there might be an SBI >> replacement for this in the future as well. >> >> Alistair > > > Are you referring to the Debug Console Extension (EID #0x4442434E "DBCN")= =E2=80=9D? > > https://lists.riscv.org/g/tech-prs/topic/96051183#84 That's the one! Alistair > > Best, > Bobby > >> >> > >> > Signed-off-by: Bobby Eshleman >> > Signed-off-by: Oleksii Kurochko >> > --- >> > Changes in V2: >> > - add license to early_printk.c >> > - add signed-off-by Bobby >> > - add RISCV_32 to Kconfig.debug to EARLY_PRINTK config >> > - update commit message >> > - order the files alphabetically in Makefile >> > --- >> > xen/arch/riscv/Kconfig.debug | 7 +++++ >> > xen/arch/riscv/Makefile | 1 + >> > xen/arch/riscv/early_printk.c | 33 ++++++++++++++++++++++= + >> > xen/arch/riscv/include/asm/early_printk.h | 12 +++++++++ >> > 4 files changed, 53 insertions(+) >> > create mode 100644 xen/arch/riscv/early_printk.c >> > create mode 100644 xen/arch/riscv/include/asm/early_printk.h >> > >> > diff --git a/xen/arch/riscv/Kconfig.debug b/xen/arch/riscv/Kconfig.deb= ug >> > index e69de29bb2..6ba0bd1e5a 100644 >> > --- a/xen/arch/riscv/Kconfig.debug >> > +++ b/xen/arch/riscv/Kconfig.debug >> > @@ -0,0 +1,7 @@ >> > +config EARLY_PRINTK >> > + bool "Enable early printk config" >> > + default DEBUG >> > + depends on RISCV_64 || RISCV_32 >> > + help >> > + >> > + Enables early printk debug messages >> > diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile >> > index fd916e1004..1a4f1a6015 100644 >> > --- a/xen/arch/riscv/Makefile >> > +++ b/xen/arch/riscv/Makefile >> > @@ -1,3 +1,4 @@ >> > +obj-$(CONFIG_EARLY_PRINTK) +=3D early_printk.o >> > obj-$(CONFIG_RISCV_64) +=3D riscv64/ >> > obj-y +=3D sbi.o >> > obj-y +=3D setup.o >> > diff --git a/xen/arch/riscv/early_printk.c b/xen/arch/riscv/early_prin= tk.c >> > new file mode 100644 >> > index 0000000000..88da5169ed >> > --- /dev/null >> > +++ b/xen/arch/riscv/early_printk.c >> > @@ -0,0 +1,33 @@ >> > +/* SPDX-License-Identifier: GPL-2.0 */ >> > +/* >> > + * RISC-V early printk using SBI >> > + * >> > + * Copyright (C) 2021 Bobby Eshleman >> > + */ >> > +#include >> > +#include >> > + >> > +/* >> > + * TODO: >> > + * sbi_console_putchar is already planned for deprication >> > + * so it should be reworked to use UART directly. >> > +*/ >> > +void early_puts(const char *s, size_t nr) >> > +{ >> > + while ( nr-- > 0 ) >> > + { >> > + if (*s =3D=3D '\n') >> > + sbi_console_putchar('\r'); >> > + sbi_console_putchar(*s); >> > + s++; >> > + } >> > +} >> > + >> > +void early_printk(const char *str) >> > +{ >> > + while (*str) >> > + { >> > + early_puts(str, 1); >> > + str++; >> > + } >> > +} >> > diff --git a/xen/arch/riscv/include/asm/early_printk.h b/xen/arch/risc= v/include/asm/early_printk.h >> > new file mode 100644 >> > index 0000000000..05106e160d >> > --- /dev/null >> > +++ b/xen/arch/riscv/include/asm/early_printk.h >> > @@ -0,0 +1,12 @@ >> > +#ifndef __EARLY_PRINTK_H__ >> > +#define __EARLY_PRINTK_H__ >> > + >> > +#include >> > + >> > +#ifdef CONFIG_EARLY_PRINTK >> > +void early_printk(const char *str); >> > +#else >> > +static inline void early_printk(const char *s) {}; >> > +#endif >> > + >> > +#endif /* __EARLY_PRINTK_H__ */ >> > -- >> > 2.38.1 >> > >> > From xen-devel-bounces@lists.xenproject.org Tue Jan 10 11:55:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 11:55:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474623.735898 (Exim 4.92) (envelope-from ) id 1pFDE9-00043f-6r; Tue, 10 Jan 2023 11:55:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474623.735898; Tue, 10 Jan 2023 11:55:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFDE9-00043Y-3a; Tue, 10 Jan 2023 11:55:37 +0000 Received: by outflank-mailman (input) for mailman id 474623; Tue, 10 Jan 2023 11:55:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFDE7-00043O-Ly; Tue, 10 Jan 2023 11:55:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFDE7-0005Aq-Hz; Tue, 10 Jan 2023 11:55:35 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFDE7-0005zw-3P; Tue, 10 Jan 2023 11:55:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pFDE7-0002Xz-2v; Tue, 10 Jan 2023 11:55:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To; bh=uMdF5BZsojLPZd2+PP36lLb5iZ/vB15gXlSDAGbhDfg=; b=YfNaJX/zQ7JCp7FHxPaaVN1E9s x47+RuXN8nH4nm588pgFmHJ3zKzty0pRsTPLJR8mhURsXqHRmojXKglrRDgdAZBzSCuspF+5UlHG1 kklS8XQXr/V7yQmPVFOlbNiNnNyErd6A/dsCg+ZlgexkE16mjXnsyNRVa/SqkxaHVDHQ=; To: xen-devel@lists.xenproject.org Subject: [qemu-mainline bisection] complete build-arm64 Message-Id: From: osstest service owner Date: Tue, 10 Jan 2023 11:55:35 +0000 branch xen-unstable xenbranch xen-unstable job build-arm64 testid xen-build Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemuu git://git.qemu.org/qemu.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git *** Found and reproduced problem changeset *** Bug is in tree: qemuu git://git.qemu.org/qemu.git Bug introduced: 3d83b78285d6e96636130f7d449fd02e2d4deee0 Bug not present: 528d9f33cad5245c1099d77084c78bb2244d5143 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/175697/ commit 3d83b78285d6e96636130f7d449fd02e2d4deee0 Merge: 528d9f33ca fb418b51b7 Author: Peter Maydell Date: Sun Jan 8 14:27:40 2023 +0000 Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging * Atomic memslot updates for KVM (Emanuele, David) * Always send errors to logfile when daemonized (Greg) * Add support for IDE CompactFlash card (Lubomir) * First round of build system cleanups (myself) * First round of feature removals (myself) * Reduce "qemu/accel.h" inclusion (Philippe) # gpg: Signature made Thu 05 Jan 2023 23:51:09 GMT # gpg: using RSA key F13338574B662389866C7682BFFBD25F78C7AE83 # gpg: issuer "pbonzini@redhat.com" # gpg: Good signature from "Paolo Bonzini " [full] # gpg: aka "Paolo Bonzini " [full] # Primary key fingerprint: 46F5 9FBD 57D6 12E7 BFD4 E2F7 7E15 100C CD36 69B1 # Subkey fingerprint: F133 3857 4B66 2389 866C 7682 BFFB D25F 78C7 AE83 * tag 'for-upstream' of https://gitlab.com/bonzini/qemu: (24 commits) i386: SGX: remove deprecated member of SGXInfo target/i386: Add SGX aex-notify and EDECCSSA support util: remove support -chardev tty and -chardev parport util: remove support for hex numbers with a scaling suffix KVM: remove support for kernel-irqchip=off docs: do not talk about past removal as happening in the future meson: accept relative symlinks in "meson introspect --installed" data meson: cleanup compiler detection meson: support meson 0.64 -Doptimization=plain configure: test all warnings tests/qapi-schema: remove Meson workaround meson: cleanup dummy-cpus.c rules meson: tweak hardening options for Windows configure: remove backwards-compatibility and obsolete options configure: preserve qemu-ga variables configure: cleanup $cpu tests configure: remove dead function configure: remove useless write_c_skeleton ide: Add "ide-cf" driver, a CompactFlash card ide: Add 8-bit data mode ... Signed-off-by: Peter Maydell commit fb418b51b7b43c34873f4b9af3da7031b7452115 Author: Paolo Bonzini Date: Fri Dec 16 11:02:48 2022 +0100 i386: SGX: remove deprecated member of SGXInfo Signed-off-by: Paolo Bonzini commit d45f24fe7525d8a8aaa4ca6d9d214dc41819caa5 Author: Kai Huang Date: Wed Nov 9 15:48:34 2022 +1300 target/i386: Add SGX aex-notify and EDECCSSA support The new SGX Asynchronous Exit (AEX) notification mechanism (AEX-notify) allows one enclave to receive a notification in the ERESUME after the enclave exit due to an AEX. EDECCSSA is a new SGX user leaf function (ENCLU[EDECCSSA]) to facilitate the AEX notification handling. Whether the hardware supports to create enclave with AEX-notify support is enumerated via CPUID.(EAX=0x12,ECX=0x1):EAX[10]. The new EDECCSSA user leaf function is enumerated via CPUID.(EAX=0x12,ECX=0x0):EAX[11]. Add support to allow to expose the new SGX AEX-notify feature and the new EDECCSSA user leaf function to KVM guest. Link: https://lore.kernel.org/lkml/166760360549.4906.809756297092548496.tip-bot2@tip-bot2/ Link: https://lore.kernel.org/lkml/166760360934.4906.2427175408052308969.tip-bot2@tip-bot2/ Reviewed-by: Yang Zhong Signed-off-by: Kai Huang Message-Id: <20221109024834.172705-1-kai.huang@intel.com> Signed-off-by: Paolo Bonzini commit 6f9f630836df355b9ca3f4641e6b7be71f6af076 Author: Paolo Bonzini Date: Fri Dec 16 10:56:53 2022 +0100 util: remove support -chardev tty and -chardev parport These were deprecated in 6.0 and can now be removed. Signed-off-by: Paolo Bonzini commit 8b902e3d2309595567e4957b96e971c4f3ca455e Author: Paolo Bonzini Date: Fri Dec 16 10:50:05 2022 +0100 util: remove support for hex numbers with a scaling suffix This was deprecated in 6.0 and can now be removed. Signed-off-by: Paolo Bonzini commit eaaaf8abdc9a9f3493f2cb6a751660dff3f9db57 Author: Paolo Bonzini Date: Fri Dec 16 10:39:32 2022 +0100 KVM: remove support for kernel-irqchip=off -machine kernel-irqchip=off is broken for many guest OSes; kernel-irqchip=split is the replacement that works, so remove the deprecated support for the former. Signed-off-by: Paolo Bonzini commit 9d3f8b3247795ae8f482700bbbace04b04421d5b Author: Paolo Bonzini Date: Fri Dec 16 11:05:20 2022 +0100 docs: do not talk about past removal as happening in the future KVM guest support on 32-bit Arm hosts *has* been removed, so rephrase the sentence describing it. Signed-off-by: Paolo Bonzini commit f32eb0021a85efaca97f69b0e9201737562a8e4f Author: Paolo Bonzini Date: Wed Dec 14 13:25:00 2022 +0100 meson: accept relative symlinks in "meson introspect --installed" data When installing shared libraries, as is the case for libvfio-user.so, Meson will include relative symbolic links in the output of "meson introspect --installed": { "libvfio-user.so": "/usr/local/lib64/libvfio-user.so", ... } In the case of scripts/symlink-install-tree.py, this will be a symbolic link to a symbolic link but, in any case, there is no issue in creating it. Cc: qemu-stable@nongnu.org Signed-off-by: Paolo Bonzini commit e51340243687a2cd7ffcf0d6e2de030bed4b8720 Author: Paolo Bonzini Date: Wed Oct 12 14:15:06 2022 +0200 meson: cleanup compiler detection Detect all compilers at the beginning of meson.build, and store the available languages in an array. Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit 6a97f3939240977e66e90862419911666956a76a Author: Paolo Bonzini Date: Wed Nov 2 13:07:23 2022 +0100 meson: support meson 0.64 -Doptimization=plain In Meson 0.64, the optimization built-in option now accepts the "plain" value, which will not set any optimization flags. While QEMU does not check the contents of the option and therefore does not suffer any ill effect from the new value, it uses get_option to print the optimization flags in the summary. Clean the code up to remove duplication, and check for -Doptimization=plain at the same time. Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit ca9b5c2ebf1aca87677a24c208bf3d0345c0b1aa Author: Paolo Bonzini Date: Wed Oct 12 14:21:22 2022 +0200 configure: test all warnings Some warnings are hardcoded in QEMU_CFLAGS and not tested. There is no particular reason to single out these five, as many more -W flags are present on all the supported compilers. For homogeneity when moving the detection to meson, make them use the same warn_flags infrastructure. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Paolo Bonzini commit 7bef93ff064f540e24a36a31263ae3db2d06b3d2 Author: Paolo Bonzini Date: Wed Dec 14 12:29:11 2022 +0100 tests/qapi-schema: remove Meson workaround The referenced issue has been fixed since version 0.61, so remove the workaround. Signed-off-by: Paolo Bonzini commit 9c9b85d705abdcce0b63f9182d8140dd67bd13fb Author: Paolo Bonzini Date: Thu Jul 22 10:43:00 2021 +0200 meson: cleanup dummy-cpus.c rules Now that qtest is available on all targets including Windows, dummy-cpus.c is included unconditionally in the build. It also does not need to be compiled per-target. Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit 2d73fa74728dccde5cc29c4e56b4d781e4ead7c4 Author: Paolo Bonzini Date: Wed Nov 2 13:03:51 2022 +0100 meson: tweak hardening options for Windows meson.build has been enabling ASLR _only_ for debug builds since commit d2147e04f95f ("configure: move Windows flags detection to meson", 2022-05-07); instead it was supposed to disable it for debug builds. However, the flag has been enabled for DLLs upstream for roughly 2 years (https://sourceware.org/bugzilla/show_bug.cgi?id=19011), and also by some distros including Debian for 6 years even (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=836365). Enable it unconditionally; we can fix the reversed logic of commit d2147e04f95f later if there are any reports, but for now just enable the hardening. Also add -Wl,--high-entropy-va, which also controls ASLR. Signed-off-by: Paolo Bonzini commit 10229ec3b0ff77c4894cefa312c21e65a761dcde Author: Paolo Bonzini Date: Tue Oct 18 10:17:46 2022 +0200 configure: remove backwards-compatibility and obsolete options Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit 954ed68f9934a3e08f904acb93ce168505995e95 Author: Paolo Bonzini Date: Wed Oct 12 11:35:17 2022 +0200 configure: preserve qemu-ga variables Ensure that qemu-ga variables set at configure time are kept later when the script is rerun. For preserve_env to work, the variables need to be empty so move the default values to config-host.mak generation. Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit f9c77801f4992fae99392ccbb60596dfa1fcf04a Author: Paolo Bonzini Date: Wed Oct 12 15:27:03 2022 +0200 configure: cleanup $cpu tests $cpu is derived from preprocessor defines rather than uname these days, so do not bother using isainfo on Solaris. Likewise do not recognize BeOS's uname -m output. Keep the other, less OS-specific canonicalizations for the benefit of people using --cpu. Reviewed-by: Peter Maydell Signed-off-by: Paolo Bonzini commit 91cd485a6dcbc8210666d19146fe73b8664f0418 Author: Paolo Bonzini Date: Tue Oct 18 10:17:25 2022 +0200 configure: remove dead function Reviewed-by: Peter Maydell Signed-off-by: Paolo Bonzini commit c5634e822416e71e00f08f55a521362d8d21264d Author: Paolo Bonzini Date: Thu Oct 20 14:20:06 2022 +0200 configure: remove useless write_c_skeleton This is not needed ever since QEMU stopped detecting -liberty; this happened with the Meson switch but it is quite likely that the library was not really necessary years before. Reviewed-by: Peter Maydell Signed-off-by: Paolo Bonzini commit cec79db38df72ce74d0296b831e90547111bc13c Author: Lubomir Rintel Date: Wed Nov 30 13:03:19 2022 +0100 ide: Add "ide-cf" driver, a CompactFlash card This allows attaching IDE_CFATA device to an IDE bus. Behaves like a CompactFlash card in True IDE mode. Tested with: qemu-system-i386 \$ -device driver=ide-cf,drive=cf,bus=ide.0 \$ -drive id=cf,index=0,format=raw,if=none,file=cf.img Signed-off-by: Lubomir Rintel Message-Id: <20221130120319.706885-1-lkundrak@v3.sk> Signed-off-by: Paolo Bonzini commit 1ea17d228e582b1cfbf6f61e9da5fafef4063be8 Author: Lubomir Rintel Date: Wed Nov 30 13:02:38 2022 +0100 ide: Add 8-bit data mode CompactFlash uses features 0x01 and 0x81 to enable/disable 8-bit data path. Implement them. Signed-off-by: Lubomir Rintel Message-Id: <20221130120238.706717-1-lkundrak@v3.sk> Signed-off-by: Paolo Bonzini commit 9b063b7ea697d796914b3651d15c3457b7b1135c Author: Greg Kurz Date: Tue Nov 8 15:00:32 2022 +0100 util/log: Always send errors to logfile when daemonized When QEMU is started with `-daemonize`, all stdio descriptors get redirected to `/dev/null`. This basically means that anything printed with error_report() and friends is lost. Current logging code allows to redirect to a file with `-D` but this requires to enable some logging item with `-d` as well to be functional. Relax the check on the log flags when QEMU is daemonized, so that other users of stderr can benefit from the redirection, without the need to enable unwanted debug logs. Previous behaviour is retained for the non-daemonized case. The logic is unrolled as an `if` for better readability. The qemu_log_level and log_per_thread globals reflect the state we want to transition to at this point : use them instead of the intermediary locals for correctness. qemu_set_log_internal() is adapted to open a per-thread log file when '-d tid' is passed. This is done by hijacking qemu_try_lock() which seems simpler that refactoring the code. Signed-off-by: Greg Kurz Message-Id: <20221108140032.1460307-3-groug@kaod.org> Signed-off-by: Paolo Bonzini commit 59bde2137445b63c822720d069d91d38190c6540 Author: Paolo Bonzini Date: Tue Nov 8 15:00:31 2022 +0100 util/log: do not close and reopen log files when flags are turned off log_append makes sure that if you turn off the logging (which clears log_flags and makes need_to_open_file false) the old log is not overwritten. The usecase is that if you remove or move the file QEMU will not keep writing to the old file. However, this is not always the desited behavior, in particular having log_append==1 after changing the file name makes little sense. When qemu_set_log_internal is called from the logfile monitor command, filename must be non-NULL and therefore changed_name must be true. Therefore, the only case where the file is closed and need_to_open_file == false is indeed when log_flags becomes zero. In this case, just flush the file and do not bother closing it, thus faking the same append behavior as previously. The behavioral change is that changing the logfile twice, for example log1 -> log2 -> log1, will cause log1 to be overwritten. This can simply be documented, since it is not a particularly surprising behavior. Suggested-by: Alex Bennée Signed-off-by: Paolo Bonzini Reviewed-by: Richard Henderson Reviewed-by: Greg Kurz Message-Id: <20221025092119.236224-1-pbonzini@redhat.com> [groug: nullify global_file before actually closing the file] Signed-off-by: Greg Kurz Message-Id: <20221108140032.1460307-2-groug@kaod.org> Signed-off-by: Paolo Bonzini commit cc6ff741123216550997b12cdd991beeed47bd0d Author: Philippe Mathieu-Daudé Date: Wed Nov 30 14:56:41 2022 +0100 hw: Reduce "qemu/accel.h" inclusion Move "qemu/accel.h" include from the heavily included "hw/boards.h" to hw/core/machine.c, the single file using the AccelState definition. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Fabiano Rosas Message-Id: <20221130135641.85328-3-philmd@linaro.org> Signed-off-by: Paolo Bonzini commit 3d277871f39d4de42f56b7b0cef5721e525b2d31 Author: Philippe Mathieu-Daudé Date: Wed Nov 30 14:56:40 2022 +0100 typedefs: Forward-declare AccelState Forward-declare AccelState in "qemu/typedefs.h" so structures using a reference of it (like MachineState in "hw/boards.h") don't have to include "qemu/accel.h". Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Fabiano Rosas Message-Id: <20221130135641.85328-2-philmd@linaro.org> Signed-off-by: Paolo Bonzini For bisection revision-tuple graph see: http://logs.test-lab.xenproject.org/osstest/results/bisect/qemu-mainline/build-arm64.xen-build.html Revision IDs in each graph node refer, respectively, to the Trees above. ---------------------------------------- Running cs-bisection-step --graph-out=/home/logs/results/bisect/qemu-mainline/build-arm64.xen-build --summary-out=tmp/175697.bisection-summary --basis-template=175623 --blessings=real,real-bisect,real-retry qemu-mainline build-arm64 xen-build Searching for failure / basis pass: 175681 fail [host=rochester0] / 175637 [host=laxton1] 175627 [host=rochester1] 175623 ok. Failure / basis pass flights: 175681 / 175623 Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemuu git://git.qemu.org/qemu.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git Latest 33a3408fbbf988aaa8ecc6e721cf83e3ae810e54 aa96ab7c9df59c615ca82b49c9062819e0a1c287 645a64b4911d7cadf5749d7375544fc2384e70ba 38525f6f73f906699f77a1af86c16b4eaad48e04 Basis pass d8d829b89dababf763ab33b8cdd852b2830db3cf 0ab12aa32462817f0a53fa6f6ce4baf664ef1713 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 Generating revisions with ./adhoc-revtuple-generator git://xenbits.xen.org/osstest/ovmf.git#d8d829b89dababf763ab33b8cdd852b2830db3cf-33a3408fbbf988aaa8ecc6e721cf83e3ae810e54 git://git.qemu.org/qemu.git#0ab12aa32462817f0a53fa6f6ce4baf664ef1713-aa96ab7c9df59c615ca82b49c9062819e0a1c287 git://xenbits.xen.org/osstest/seabios.git#645a64b4911d7cadf5749d7375544fc2384e70ba-645a64b4911d7cadf5749d7375544fc2384e70ba git://xenbits.xen.org/xen.git#2b21cbbb339fb14414f357a6683b1df74c36fda2-38525f6f73f906699f77\ a1af86c16b4eaad48e04 Loaded 24998 nodes in revision graph Searching for test results: 175619 pass irrelevant 175623 pass d8d829b89dababf763ab33b8cdd852b2830db3cf 0ab12aa32462817f0a53fa6f6ce4baf664ef1713 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 175627 [host=rochester1] 175636 [host=rochester1] 175639 [host=laxton1] 175637 [host=laxton1] 175643 [host=rochester1] 175647 fail d8d829b89dababf763ab33b8cdd852b2830db3cf d6271b657286de80260413684a1f2a63f44ea17b 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 175654 fail irrelevant 175664 fail irrelevant 175676 pass d8d829b89dababf763ab33b8cdd852b2830db3cf 0ab12aa32462817f0a53fa6f6ce4baf664ef1713 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 175677 fail irrelevant 175678 pass d8d829b89dababf763ab33b8cdd852b2830db3cf dd92cbb3665a47b9118cbd06a60ff0c75ad1f442 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 175679 pass d8d829b89dababf763ab33b8cdd852b2830db3cf bf7a2ad8b6dfab4adb40db44022e4c424b56421e 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 175672 fail 33a3408fbbf988aaa8ecc6e721cf83e3ae810e54 aa96ab7c9df59c615ca82b49c9062819e0a1c287 645a64b4911d7cadf5749d7375544fc2384e70ba 38525f6f73f906699f77a1af86c16b4eaad48e04 175680 pass d8d829b89dababf763ab33b8cdd852b2830db3cf 97f4effeb6083f3c15f48cf4eea0c16552a9330a 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 175682 fail 33a3408fbbf988aaa8ecc6e721cf83e3ae810e54 aa96ab7c9df59c615ca82b49c9062819e0a1c287 645a64b4911d7cadf5749d7375544fc2384e70ba 38525f6f73f906699f77a1af86c16b4eaad48e04 175685 pass d8d829b89dababf763ab33b8cdd852b2830db3cf 46bda3e4de4f78f1d905107d7da34d97e1c3cb1d 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 175687 pass d8d829b89dababf763ab33b8cdd852b2830db3cf dab30fbef3896bb652a09d46c37d3f55657cbcbb 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 175688 pass d8d829b89dababf763ab33b8cdd852b2830db3cf 528d9f33cad5245c1099d77084c78bb2244d5143 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 175681 fail 33a3408fbbf988aaa8ecc6e721cf83e3ae810e54 aa96ab7c9df59c615ca82b49c9062819e0a1c287 645a64b4911d7cadf5749d7375544fc2384e70ba 38525f6f73f906699f77a1af86c16b4eaad48e04 175690 fail d8d829b89dababf763ab33b8cdd852b2830db3cf 3d83b78285d6e96636130f7d449fd02e2d4deee0 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 175693 pass d8d829b89dababf763ab33b8cdd852b2830db3cf 528d9f33cad5245c1099d77084c78bb2244d5143 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 175695 fail d8d829b89dababf763ab33b8cdd852b2830db3cf 3d83b78285d6e96636130f7d449fd02e2d4deee0 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 175696 pass d8d829b89dababf763ab33b8cdd852b2830db3cf 528d9f33cad5245c1099d77084c78bb2244d5143 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 175697 fail d8d829b89dababf763ab33b8cdd852b2830db3cf 3d83b78285d6e96636130f7d449fd02e2d4deee0 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 Searching for interesting versions Result found: flight 175623 (pass), for basis pass Result found: flight 175672 (fail), for basis failure (at ancestor ~4) Repro found: flight 175676 (pass), for basis pass Repro found: flight 175681 (fail), for basis failure 0 revisions at d8d829b89dababf763ab33b8cdd852b2830db3cf 528d9f33cad5245c1099d77084c78bb2244d5143 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 No revisions left to test, checking graph state. Result found: flight 175688 (pass), for last pass Result found: flight 175690 (fail), for first failure Repro found: flight 175693 (pass), for last pass Repro found: flight 175695 (fail), for first failure Repro found: flight 175696 (pass), for last pass Repro found: flight 175697 (fail), for first failure *** Found and reproduced problem changeset *** Bug is in tree: qemuu git://git.qemu.org/qemu.git Bug introduced: 3d83b78285d6e96636130f7d449fd02e2d4deee0 Bug not present: 528d9f33cad5245c1099d77084c78bb2244d5143 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/175697/ commit 3d83b78285d6e96636130f7d449fd02e2d4deee0 Merge: 528d9f33ca fb418b51b7 Author: Peter Maydell Date: Sun Jan 8 14:27:40 2023 +0000 Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging * Atomic memslot updates for KVM (Emanuele, David) * Always send errors to logfile when daemonized (Greg) * Add support for IDE CompactFlash card (Lubomir) * First round of build system cleanups (myself) * First round of feature removals (myself) * Reduce "qemu/accel.h" inclusion (Philippe) # gpg: Signature made Thu 05 Jan 2023 23:51:09 GMT # gpg: using RSA key F13338574B662389866C7682BFFBD25F78C7AE83 # gpg: issuer "pbonzini@redhat.com" # gpg: Good signature from "Paolo Bonzini " [full] # gpg: aka "Paolo Bonzini " [full] # Primary key fingerprint: 46F5 9FBD 57D6 12E7 BFD4 E2F7 7E15 100C CD36 69B1 # Subkey fingerprint: F133 3857 4B66 2389 866C 7682 BFFB D25F 78C7 AE83 * tag 'for-upstream' of https://gitlab.com/bonzini/qemu: (24 commits) i386: SGX: remove deprecated member of SGXInfo target/i386: Add SGX aex-notify and EDECCSSA support util: remove support -chardev tty and -chardev parport util: remove support for hex numbers with a scaling suffix KVM: remove support for kernel-irqchip=off docs: do not talk about past removal as happening in the future meson: accept relative symlinks in "meson introspect --installed" data meson: cleanup compiler detection meson: support meson 0.64 -Doptimization=plain configure: test all warnings tests/qapi-schema: remove Meson workaround meson: cleanup dummy-cpus.c rules meson: tweak hardening options for Windows configure: remove backwards-compatibility and obsolete options configure: preserve qemu-ga variables configure: cleanup $cpu tests configure: remove dead function configure: remove useless write_c_skeleton ide: Add "ide-cf" driver, a CompactFlash card ide: Add 8-bit data mode ... Signed-off-by: Peter Maydell commit fb418b51b7b43c34873f4b9af3da7031b7452115 Author: Paolo Bonzini Date: Fri Dec 16 11:02:48 2022 +0100 i386: SGX: remove deprecated member of SGXInfo Signed-off-by: Paolo Bonzini commit d45f24fe7525d8a8aaa4ca6d9d214dc41819caa5 Author: Kai Huang Date: Wed Nov 9 15:48:34 2022 +1300 target/i386: Add SGX aex-notify and EDECCSSA support The new SGX Asynchronous Exit (AEX) notification mechanism (AEX-notify) allows one enclave to receive a notification in the ERESUME after the enclave exit due to an AEX. EDECCSSA is a new SGX user leaf function (ENCLU[EDECCSSA]) to facilitate the AEX notification handling. Whether the hardware supports to create enclave with AEX-notify support is enumerated via CPUID.(EAX=0x12,ECX=0x1):EAX[10]. The new EDECCSSA user leaf function is enumerated via CPUID.(EAX=0x12,ECX=0x0):EAX[11]. Add support to allow to expose the new SGX AEX-notify feature and the new EDECCSSA user leaf function to KVM guest. Link: https://lore.kernel.org/lkml/166760360549.4906.809756297092548496.tip-bot2@tip-bot2/ Link: https://lore.kernel.org/lkml/166760360934.4906.2427175408052308969.tip-bot2@tip-bot2/ Reviewed-by: Yang Zhong Signed-off-by: Kai Huang Message-Id: <20221109024834.172705-1-kai.huang@intel.com> Signed-off-by: Paolo Bonzini commit 6f9f630836df355b9ca3f4641e6b7be71f6af076 Author: Paolo Bonzini Date: Fri Dec 16 10:56:53 2022 +0100 util: remove support -chardev tty and -chardev parport These were deprecated in 6.0 and can now be removed. Signed-off-by: Paolo Bonzini commit 8b902e3d2309595567e4957b96e971c4f3ca455e Author: Paolo Bonzini Date: Fri Dec 16 10:50:05 2022 +0100 util: remove support for hex numbers with a scaling suffix This was deprecated in 6.0 and can now be removed. Signed-off-by: Paolo Bonzini commit eaaaf8abdc9a9f3493f2cb6a751660dff3f9db57 Author: Paolo Bonzini Date: Fri Dec 16 10:39:32 2022 +0100 KVM: remove support for kernel-irqchip=off -machine kernel-irqchip=off is broken for many guest OSes; kernel-irqchip=split is the replacement that works, so remove the deprecated support for the former. Signed-off-by: Paolo Bonzini commit 9d3f8b3247795ae8f482700bbbace04b04421d5b Author: Paolo Bonzini Date: Fri Dec 16 11:05:20 2022 +0100 docs: do not talk about past removal as happening in the future KVM guest support on 32-bit Arm hosts *has* been removed, so rephrase the sentence describing it. Signed-off-by: Paolo Bonzini commit f32eb0021a85efaca97f69b0e9201737562a8e4f Author: Paolo Bonzini Date: Wed Dec 14 13:25:00 2022 +0100 meson: accept relative symlinks in "meson introspect --installed" data When installing shared libraries, as is the case for libvfio-user.so, Meson will include relative symbolic links in the output of "meson introspect --installed": { "libvfio-user.so": "/usr/local/lib64/libvfio-user.so", ... } In the case of scripts/symlink-install-tree.py, this will be a symbolic link to a symbolic link but, in any case, there is no issue in creating it. Cc: qemu-stable@nongnu.org Signed-off-by: Paolo Bonzini commit e51340243687a2cd7ffcf0d6e2de030bed4b8720 Author: Paolo Bonzini Date: Wed Oct 12 14:15:06 2022 +0200 meson: cleanup compiler detection Detect all compilers at the beginning of meson.build, and store the available languages in an array. Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit 6a97f3939240977e66e90862419911666956a76a Author: Paolo Bonzini Date: Wed Nov 2 13:07:23 2022 +0100 meson: support meson 0.64 -Doptimization=plain In Meson 0.64, the optimization built-in option now accepts the "plain" value, which will not set any optimization flags. While QEMU does not check the contents of the option and therefore does not suffer any ill effect from the new value, it uses get_option to print the optimization flags in the summary. Clean the code up to remove duplication, and check for -Doptimization=plain at the same time. Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit ca9b5c2ebf1aca87677a24c208bf3d0345c0b1aa Author: Paolo Bonzini Date: Wed Oct 12 14:21:22 2022 +0200 configure: test all warnings Some warnings are hardcoded in QEMU_CFLAGS and not tested. There is no particular reason to single out these five, as many more -W flags are present on all the supported compilers. For homogeneity when moving the detection to meson, make them use the same warn_flags infrastructure. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Paolo Bonzini commit 7bef93ff064f540e24a36a31263ae3db2d06b3d2 Author: Paolo Bonzini Date: Wed Dec 14 12:29:11 2022 +0100 tests/qapi-schema: remove Meson workaround The referenced issue has been fixed since version 0.61, so remove the workaround. Signed-off-by: Paolo Bonzini commit 9c9b85d705abdcce0b63f9182d8140dd67bd13fb Author: Paolo Bonzini Date: Thu Jul 22 10:43:00 2021 +0200 meson: cleanup dummy-cpus.c rules Now that qtest is available on all targets including Windows, dummy-cpus.c is included unconditionally in the build. It also does not need to be compiled per-target. Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit 2d73fa74728dccde5cc29c4e56b4d781e4ead7c4 Author: Paolo Bonzini Date: Wed Nov 2 13:03:51 2022 +0100 meson: tweak hardening options for Windows meson.build has been enabling ASLR _only_ for debug builds since commit d2147e04f95f ("configure: move Windows flags detection to meson", 2022-05-07); instead it was supposed to disable it for debug builds. However, the flag has been enabled for DLLs upstream for roughly 2 years (https://sourceware.org/bugzilla/show_bug.cgi?id=19011), and also by some distros including Debian for 6 years even (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=836365). Enable it unconditionally; we can fix the reversed logic of commit d2147e04f95f later if there are any reports, but for now just enable the hardening. Also add -Wl,--high-entropy-va, which also controls ASLR. Signed-off-by: Paolo Bonzini commit 10229ec3b0ff77c4894cefa312c21e65a761dcde Author: Paolo Bonzini Date: Tue Oct 18 10:17:46 2022 +0200 configure: remove backwards-compatibility and obsolete options Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit 954ed68f9934a3e08f904acb93ce168505995e95 Author: Paolo Bonzini Date: Wed Oct 12 11:35:17 2022 +0200 configure: preserve qemu-ga variables Ensure that qemu-ga variables set at configure time are kept later when the script is rerun. For preserve_env to work, the variables need to be empty so move the default values to config-host.mak generation. Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit f9c77801f4992fae99392ccbb60596dfa1fcf04a Author: Paolo Bonzini Date: Wed Oct 12 15:27:03 2022 +0200 configure: cleanup $cpu tests $cpu is derived from preprocessor defines rather than uname these days, so do not bother using isainfo on Solaris. Likewise do not recognize BeOS's uname -m output. Keep the other, less OS-specific canonicalizations for the benefit of people using --cpu. Reviewed-by: Peter Maydell Signed-off-by: Paolo Bonzini commit 91cd485a6dcbc8210666d19146fe73b8664f0418 Author: Paolo Bonzini Date: Tue Oct 18 10:17:25 2022 +0200 configure: remove dead function Reviewed-by: Peter Maydell Signed-off-by: Paolo Bonzini commit c5634e822416e71e00f08f55a521362d8d21264d Author: Paolo Bonzini Date: Thu Oct 20 14:20:06 2022 +0200 configure: remove useless write_c_skeleton This is not needed ever since QEMU stopped detecting -liberty; this happened with the Meson switch but it is quite likely that the library was not really necessary years before. Reviewed-by: Peter Maydell Signed-off-by: Paolo Bonzini commit cec79db38df72ce74d0296b831e90547111bc13c Author: Lubomir Rintel Date: Wed Nov 30 13:03:19 2022 +0100 ide: Add "ide-cf" driver, a CompactFlash card This allows attaching IDE_CFATA device to an IDE bus. Behaves like a CompactFlash card in True IDE mode. Tested with: qemu-system-i386 \$ -device driver=ide-cf,drive=cf,bus=ide.0 \$ -drive id=cf,index=0,format=raw,if=none,file=cf.img Signed-off-by: Lubomir Rintel Message-Id: <20221130120319.706885-1-lkundrak@v3.sk> Signed-off-by: Paolo Bonzini commit 1ea17d228e582b1cfbf6f61e9da5fafef4063be8 Author: Lubomir Rintel Date: Wed Nov 30 13:02:38 2022 +0100 ide: Add 8-bit data mode CompactFlash uses features 0x01 and 0x81 to enable/disable 8-bit data path. Implement them. Signed-off-by: Lubomir Rintel Message-Id: <20221130120238.706717-1-lkundrak@v3.sk> Signed-off-by: Paolo Bonzini commit 9b063b7ea697d796914b3651d15c3457b7b1135c Author: Greg Kurz Date: Tue Nov 8 15:00:32 2022 +0100 util/log: Always send errors to logfile when daemonized When QEMU is started with `-daemonize`, all stdio descriptors get redirected to `/dev/null`. This basically means that anything printed with error_report() and friends is lost. Current logging code allows to redirect to a file with `-D` but this requires to enable some logging item with `-d` as well to be functional. Relax the check on the log flags when QEMU is daemonized, so that other users of stderr can benefit from the redirection, without the need to enable unwanted debug logs. Previous behaviour is retained for the non-daemonized case. The logic is unrolled as an `if` for better readability. The qemu_log_level and log_per_thread globals reflect the state we want to transition to at this point : use them instead of the intermediary locals for correctness. qemu_set_log_internal() is adapted to open a per-thread log file when '-d tid' is passed. This is done by hijacking qemu_try_lock() which seems simpler that refactoring the code. Signed-off-by: Greg Kurz Message-Id: <20221108140032.1460307-3-groug@kaod.org> Signed-off-by: Paolo Bonzini commit 59bde2137445b63c822720d069d91d38190c6540 Author: Paolo Bonzini Date: Tue Nov 8 15:00:31 2022 +0100 util/log: do not close and reopen log files when flags are turned off log_append makes sure that if you turn off the logging (which clears log_flags and makes need_to_open_file false) the old log is not overwritten. The usecase is that if you remove or move the file QEMU will not keep writing to the old file. However, this is not always the desited behavior, in particular having log_append==1 after changing the file name makes little sense. When qemu_set_log_internal is called from the logfile monitor command, filename must be non-NULL and therefore changed_name must be true. Therefore, the only case where the file is closed and need_to_open_file == false is indeed when log_flags becomes zero. In this case, just flush the file and do not bother closing it, thus faking the same append behavior as previously. The behavioral change is that changing the logfile twice, for example log1 -> log2 -> log1, will cause log1 to be overwritten. This can simply be documented, since it is not a particularly surprising behavior. Suggested-by: Alex Bennée Signed-off-by: Paolo Bonzini Reviewed-by: Richard Henderson Reviewed-by: Greg Kurz Message-Id: <20221025092119.236224-1-pbonzini@redhat.com> [groug: nullify global_file before actually closing the file] Signed-off-by: Greg Kurz Message-Id: <20221108140032.1460307-2-groug@kaod.org> Signed-off-by: Paolo Bonzini commit cc6ff741123216550997b12cdd991beeed47bd0d Author: Philippe Mathieu-Daudé Date: Wed Nov 30 14:56:41 2022 +0100 hw: Reduce "qemu/accel.h" inclusion Move "qemu/accel.h" include from the heavily included "hw/boards.h" to hw/core/machine.c, the single file using the AccelState definition. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Fabiano Rosas Message-Id: <20221130135641.85328-3-philmd@linaro.org> Signed-off-by: Paolo Bonzini commit 3d277871f39d4de42f56b7b0cef5721e525b2d31 Author: Philippe Mathieu-Daudé Date: Wed Nov 30 14:56:40 2022 +0100 typedefs: Forward-declare AccelState Forward-declare AccelState in "qemu/typedefs.h" so structures using a reference of it (like MachineState in "hw/boards.h") don't have to include "qemu/accel.h". Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Fabiano Rosas Message-Id: <20221130135641.85328-2-philmd@linaro.org> Signed-off-by: Paolo Bonzini Revision graph left in /home/logs/results/bisect/qemu-mainline/build-arm64.xen-build.{dot,ps,png,html,svg}. ---------------------------------------- 175697: tolerable ALL FAIL flight 175697 qemu-mainline real-bisect [real] http://logs.test-lab.xenproject.org/osstest/logs/175697/ Failures :-/ but no regressions. Tests which did not succeed, including tests which could not be run: build-arm64 6 xen-build fail baseline untested jobs: build-arm64 fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary From xen-devel-bounces@lists.xenproject.org Tue Jan 10 12:20:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 12:20:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474643.735911 (Exim 4.92) (envelope-from ) id 1pFDcK-0007cj-Qh; Tue, 10 Jan 2023 12:20:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474643.735911; Tue, 10 Jan 2023 12:20:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFDcK-0007cc-O2; Tue, 10 Jan 2023 12:20:36 +0000 Received: by outflank-mailman (input) for mailman id 474643; Tue, 10 Jan 2023 12:20:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFDcJ-0007cS-Ur; Tue, 10 Jan 2023 12:20:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFDcJ-0005rl-Qn; Tue, 10 Jan 2023 12:20:35 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFDcJ-00077i-GE; Tue, 10 Jan 2023 12:20:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pFDcJ-0006mW-Fl; Tue, 10 Jan 2023 12:20:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=LL0MLTEoEhtkILTrMvkCMszj1Ovh2ok2D/0JUbnLijM=; b=3/8Ij3p/72mG21XAwSv8s4Vlzo RKe9++NDQeEZz+GrUit9qa9mvrDhXiOcKaZzR96/69HEBwrP9X8lag2i3JlzY+g83OXkglP55PfXC myivXVYFJAnNg0diDjwwHI4FKGgOb0HBsuM7hGNICpVat3o+RvCDhQbpG4OoTN1BtsDw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 175684: tolerable FAIL - PUSHED X-Osstest-Failures: libvirt:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:guest-start/debian.repeat:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: libvirt=49ff47269b71a762ca5de4595f6ec915043e05ce X-Osstest-Versions-That: libvirt=ffd286ac6f25374d16f4eaa7ff64e30c77541b41 From: osstest service owner Date: Tue, 10 Jan 2023 12:20:35 +0000 flight 175684 libvirt real [real] flight 175698 libvirt real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/175684/ http://logs.test-lab.xenproject.org/osstest/logs/175698/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail pass in 175698-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 175638 test-arm64-arm64-libvirt-qcow2 17 guest-start/debian.repeat fail like 175638 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 175638 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 175638 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: libvirt 49ff47269b71a762ca5de4595f6ec915043e05ce baseline version: libvirt ffd286ac6f25374d16f4eaa7ff64e30c77541b41 Last test of basis 175638 2023-01-09 04:18:55 Z 1 days Testing same since 175684 2023-01-10 04:18:53 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrea Bolognani Erik Skultety Jiang Jiacheng Ján Tomko Pavel Hrdina Peter Krempa jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git ffd286ac6f..49ff47269b 49ff47269b71a762ca5de4595f6ec915043e05ce -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue Jan 10 12:32:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 12:32:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474652.735924 (Exim 4.92) (envelope-from ) id 1pFDng-0000hj-0m; Tue, 10 Jan 2023 12:32:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474652.735924; Tue, 10 Jan 2023 12:32:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFDnf-0000hc-U3; Tue, 10 Jan 2023 12:32:19 +0000 Received: by outflank-mailman (input) for mailman id 474652; Tue, 10 Jan 2023 12:31:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFDmc-0000ge-Tw for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 12:31:15 +0000 Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id aa3e1930-90e2-11ed-91b6-6bf2151ebd3b; Tue, 10 Jan 2023 13:31:12 +0100 (CET) Received: from pps.filterd (m0174677.ppops.net [127.0.0.1]) by mx0a-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 30ABkmv0026793; Tue, 10 Jan 2023 12:30:59 GMT Received: from eur05-db8-obe.outbound.protection.outlook.com (mail-db8eur05lp2111.outbound.protection.outlook.com [104.47.17.111]) by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3n17err4t8-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 10 Jan 2023 12:30:58 +0000 Received: from AM9PR03MB7236.eurprd03.prod.outlook.com (2603:10a6:20b:260::7) by VI1PR03MB6254.eurprd03.prod.outlook.com (2603:10a6:800:13c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 12:30:54 +0000 Received: from AM9PR03MB7236.eurprd03.prod.outlook.com ([fe80::68ef:4767:a0c1:1e3d]) by AM9PR03MB7236.eurprd03.prod.outlook.com ([fe80::68ef:4767:a0c1:1e3d%8]) with mapi id 15.20.5986.018; Tue, 10 Jan 2023 12:30:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aa3e1930-90e2-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RGzgA29UvOkm1k4l4psEE/DOudvnTyBOgoEN2DTcBCuZlrQGPGQqLTcH0onnD/tS7jp9elG55GtWCrv064SPPcNg81DiJIxs3gVrtjtM4BA9cuBpuuJCXYx2zNHZ8VZHyfEnUduNE4abF8Oi5PUiSzUmVDaY7GUWBWAKFbm6OTdBA5lYWeG3leiLyEGNHQNVTY1v3xEBmC9bZNy1y8ofviUz1yGCUCxh55hdWuzbXlFCRKiNBfHhyoJIdxa1GypAAPs3Fz/d4H9t8Uf19N04VZuM4AweqPB9IJOfPdojFigAG2lh3AUYjRB5g6zngiROWUKKXdjtysu/rjIL8vPHyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Lf7/dU6ySl6QfRKApcvqrJXLdvlk5ei2aKPHk45OpGY=; b=G0e/Mx3IOdM6akqM6KozJG52Dx4/FwLI5LWea/0zErQcst2HDqbAbhJKb7ARUhAWRTFmvdxFbyttmML1Lxj7y7FDLF0zfC1HcCrthlkbAZrSQNOWOm6Zgb3oKdUSjV6pu69KgXet92u+oQe046KFl/fc+Z4q5FxsX1taAyfh9FmOI3yVs98QSh/JX8FB/PsVFSqWcxvBwrOHnwEfG9ppqpj2KWdohSv+IJLqu7jV7s0WrfGiy7WdCMqXF94DApUuR+A38WynG4rxk60XzWRBtNPNShJoNVqak504afi+6K1Ga8ey/niMwoz1kkEnU1vGsUvfS8Fj9LuId6EgCaqaOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Lf7/dU6ySl6QfRKApcvqrJXLdvlk5ei2aKPHk45OpGY=; b=nQQ74AdvvwPVJe7JKLRcwTUv33g8D+IElg+m1ulQwuyWkckzZ0cZzvBbexelZsG2wiMLDKG6pnlkCn7aIqG0FmghUqw4h2P+OxyGDNnG5j6gBYgyfWXQbzgZh/ImqosJ87Sa92ycfS2XRFTj4TcgKzwLJkS6+PjNSx4kSBA8j2q6tbGPsoNkZtQE8wi8WW9g/vKlupKt6EhMJhUTcoZnd79jHKvv66lu9oGq7YSSQNKwOTI/ac4R5tvpdMthH8KVsPLbhMDPkSQmwuMScuNhlgEe5QJS9IE05nvhJtO5qXqiJQrGSq3eC/KHvo5pWFIO9EfLQBa+oHwD+bp4N1/Y/Q== From: Dmytro Firsov To: Oleksandr Tyshchenko , Julien Grall , Ayan Kumar Halder , "xen-devel@lists.xenproject.org" CC: "sstabellini@kernel.org" , "stefano.stabellini@amd.com" , Volodymyr Babchuk , Bertrand Marquis , "michal.orzel@amd.com" , Oleksandr Tyshchenko Subject: Re: [XEN v4] xen/arm: Probe the load/entry point address of an uImage correctly Thread-Topic: [XEN v4] xen/arm: Probe the load/entry point address of an uImage correctly Thread-Index: AQHZJA3n+pyXLJ9LxUm8V6NVh68Qyq6Xk1OA Date: Tue, 10 Jan 2023 12:30:54 +0000 Message-ID: References: <20221221185300.5309-1-ayan.kumar.halder@amd.com> <20b15211-492b-713e-288c-14bd5e137ed7@gmail.com> In-Reply-To: <20b15211-492b-713e-288c-14bd5e137ed7@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AM9PR03MB7236:EE_|VI1PR03MB6254:EE_ x-ms-office365-filtering-correlation-id: 12fc838d-69c3-48a3-2a12-08daf30684a1 x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ktbrtuoYGznAsYVqL0O7ZIclHWX8hL2PEvXLSq15BNsEmx0GsrNPzm+20OzycSr2dnum/k3MBQDABC60dgMezjiTRDWTOtygMBYbM3uH+s6ovmPZFV/6DUS4mAO5hcc/cSIhEDVqo1dXv8C0gmIAzfR7bZqkkkJ/UTtIPtZx+vP2H7wCNkw2hxb4S3nbPuOgpTIkhzXUEKJbI44DCzt7u121wRw/fQqevPTCqBalf+MBlKtjq2rVlWVJwvQArg1csYN2n0eXguclprn1ghQOm7aGjZZX2hFW9E+ll1oVS7yr0qwqWz0Dblq3qxp4xXr2b5tIBXCvnfDDLAeSVptDDSsJxPaprTQ0cucfEaGumjK5CCbCrHQ0GWkub3vu2gkiBett4pHAnzkqOZ24ZdEhvGNThft02UKjLuIxBT0Sp+hGhAFH8PpUea6+Mb9M+loXsBSmsTcUZIVSGrzbU9LVmBm49F7sk6MArqSZ+OL1llvqRgOnUdz3A291+JJt3iTBOwOo1nWEfcc2e1AU5UGeUyTqNN3a2JORTz6tqrEfyr2UkgNNTmVIjIex5usGqDD2QGZYFqIo7erYCKUB1+d6TbqlGp8G1ce8UvhRGCd8GRS+tY8Y+6tOJ1vWK5/F3gQXxI4zExY26lwWwoAi71rtOW7xCOY/EsuVzAj+bk0iML/owQbQjScP3qBQycDIa7grUTfXUHVHY4ey3kJr/3xJgm3QUxGzNROMYYSuF1Ng4oE= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM9PR03MB7236.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(39860400002)(346002)(366004)(136003)(451199015)(41300700001)(31696002)(36756003)(8936002)(26005)(186003)(5660300002)(4744005)(6512007)(53546011)(6506007)(83380400001)(107886003)(6486002)(2616005)(316002)(38070700005)(54906003)(110136005)(76116006)(8676002)(66946007)(66476007)(66446008)(4326008)(86362001)(64756008)(66556008)(71200400001)(122000001)(91956017)(478600001)(38100700002)(31686004)(2906002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?ujXXo7wbXC1RvQnSm2U8C+UedyT6gblLWo/PCNuqEYtRDrx4ZN/3MruVjD?= =?iso-8859-1?Q?n+C/aGNvChrm2tiqBQ5Pa9o1AyX85PPMEanyykQKZCooviszjPoebAMYY1?= =?iso-8859-1?Q?i1SgnNy+LaVcI2SB1GNb/dJcU3HUonXriXehPywA9AiVHHWEz3QPPrxO9h?= =?iso-8859-1?Q?QeYV9sbe7l2dpingaBmmji0HhjmmXeHusFGRhNiBzPHlVBE7eNWTI0rer9?= =?iso-8859-1?Q?n/0rPcD5ARjd+e7ja1O6xdGOWAluvvoyNszFr8msWFjLF0JRSTRJ9gS73v?= =?iso-8859-1?Q?TuNbHnQaI+92Kb/ubLtUgM7XOdhNM0E0I/nxsNujCOLY8sgBymajNH2Qeb?= =?iso-8859-1?Q?TkTVfPYtPLRZEOCzG7rZfNRF0VZP+vT3shxjjKLjWPW/X3sM93wQu5YXtF?= =?iso-8859-1?Q?GFE/iLLUTfCo6tS8H1VwwX2Vc9sJZdjtmcHg5/1iIgvyJqHjQzgulyWCMq?= =?iso-8859-1?Q?8eobr4VS/emxOl9wsA1tkpX/beD11invdjQAh0l964GhGESabtW80F66s5?= =?iso-8859-1?Q?rwd2Ago3ZXCXzPVIxSh4PNUQakHl6YRwPGiDlpfo+vFFNFgc0p0edELHuG?= =?iso-8859-1?Q?BnrLz1iOBMPp1hWKIMWWO3974tQYBVzUWCYAReYgObOQOMAicBkdEofTV0?= =?iso-8859-1?Q?asS4IsfV0b/zWzxfQbRgcuRMuo81fd3idG/jX0oSoIE58IVoarVTgWPbks?= =?iso-8859-1?Q?8enDKC7V3zyWjGojiv6kIGZIBlvQi8iDPwD2M8YqADKRvD7KgHGWloJ2IS?= =?iso-8859-1?Q?M/DcJblGpH0aynZkQyvcquWRtP+K81XdOGyPOgWaVGQacHv+lIZ7EZRbAO?= =?iso-8859-1?Q?9axgb5P1Nx1dgnrjvuiVWFQJLAqnh2kFvkrrw+o8OteCDScIm172ViEBjH?= =?iso-8859-1?Q?vQd1JaTlqB/cF8XkZbMLDLsGt3fE6XctyrFvDptRSEYl7aulMThRIkwUgO?= =?iso-8859-1?Q?ETi9Qmzir4KG9MsLj8EMAPzYr15CvvM58BSzK9j36DFBKhVsupemoK9sLa?= =?iso-8859-1?Q?ETMea7hIOyWbvqyQHiI1wf9XgvND0NVaTdDky8v0cIH2gu1ABsWTfGB1BH?= =?iso-8859-1?Q?QuDNZwx+jI7uHvair8RiMsI7gPHnNQAUFmsUeTcRcJJklL8dVXBCCIfaBC?= =?iso-8859-1?Q?qGFjpsjRf1bHJke/ac0UymWolb8r0dR5jsAy/YL3lBthaS+9NCw1NG2Njk?= =?iso-8859-1?Q?T6yyVv2WprfNcE1nfd6HbU4+UgB4yCatVVV1/kIoVip3YiKzjeBpc/qn80?= =?iso-8859-1?Q?qAAXC5wrQVmeRqD28meabpmvx3sDI0Fiqmj77ZQ4u3QZqBXAWX/nlebgmG?= =?iso-8859-1?Q?TcMRWZbxj397+MeA15bcyUSyCVA1XeWTPMVLaQ/YpY8OPxQ3iwDUklIgys?= =?iso-8859-1?Q?MtPmlP+jVUzzpXWKytUPPcrkVGJ+RvGXOFg8gIJXlA1LB/walPy0BjYNm7?= =?iso-8859-1?Q?2tH2PGtuea0Mby0wu21e2zrnPKogGWxkFLGT2SqBqxbywWgvAPTmtL/Hn3?= =?iso-8859-1?Q?qpikg4sIcSWmGAbsRYiFGa2/MnhURH7JTI4apnCdv01rS5R7463gYdZgkM?= =?iso-8859-1?Q?xLgkTMPT9unIEbfrY15B92oO9UXHVg2Cr60BA9MiqWxgNC28CBm5wNbhUa?= =?iso-8859-1?Q?w3GDle5MiA6O+kDurOU6XLO3KjpwydTVXY?= Content-Type: text/plain; charset="iso-8859-1" Content-ID: <7A3D33046E4EBE488E4E03D2A1218C03@eurprd03.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM9PR03MB7236.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 12fc838d-69c3-48a3-2a12-08daf30684a1 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jan 2023 12:30:54.6541 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 79kGecerfhfBG0RfSJ0OwPqxhf+bGisESPibmJEMbxSFhfXAygPfKJbiZkd1cvLd2EqqN6pzE6phnFox1a4dNg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR03MB6254 X-Proofpoint-ORIG-GUID: z3H8DiKX1ZkaGBd0ItTS3ZR0S0FCwxjP X-Proofpoint-GUID: z3H8DiKX1ZkaGBd0ItTS3ZR0S0FCwxjP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2023-01-10_04,2023-01-10_03,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 lowpriorityscore=0 malwarescore=0 bulkscore=0 phishscore=0 spamscore=0 mlxlogscore=671 suspectscore=0 adultscore=0 impostorscore=0 priorityscore=1501 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301100076 On 09.01.23 11:36, Oleksandr Tyshchenko wrote:=0A= >=0A= >=0A= > On 08.01.23 18:06, Julien Grall wrote:=0A= >=0A= > Hello Julien, Ayan, all=0A= >=0A= >> Hi Ayan,=0A= >> ...=0A= >> The changes look good to me (with a few of comments below). That =0A= >> said, before acking the code, I would like an existing user of uImage = =0A= >> (maybe EPAM or Arm?) to confirm they are happy with the change.=0A= >=0A= > I have just re-checked current patch in our typical Xen based =0A= > environment (no dom0less, Linux in Dom0) and didn't notice issues with = =0A= > it. But we use zImage for Dom0's kernel, so kernel_uimage_probe() is =0A= > not called.=0A= >=0A= >=0A= > I CCed Dmytro Firsov who is playing with Zephyr in Dom0 and *might* =0A= > use uImage.=0A= =0A= Hi Oleksandr, Julien, all=0A= =0A= Current Xenutils/Zephyr Dom0 setup uses standard format for Zephyr on =0A= arm64 which is zImage. Thus uImage changes will not affect me.=0A= =0A= From xen-devel-bounces@lists.xenproject.org Tue Jan 10 12:44:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 12:44:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474659.735935 (Exim 4.92) (envelope-from ) id 1pFDyu-0002EL-2d; Tue, 10 Jan 2023 12:43:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474659.735935; Tue, 10 Jan 2023 12:43:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFDyt-0002EE-VN; Tue, 10 Jan 2023 12:43:55 +0000 Received: by outflank-mailman (input) for mailman id 474659; Tue, 10 Jan 2023 12:43:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFDys-0002E8-Ed for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 12:43:54 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFDyr-0006G4-RA; Tue, 10 Jan 2023 12:43:53 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.2.225]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pFDyr-0007ny-Jr; Tue, 10 Jan 2023 12:43:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=Tx8YHT2rVSoZMZQj6HL8AY94qQPEXLZ9E10ABuADxIY=; b=CLnkfRF4zuA3JULBhnH9cUKbnS Teuc0kc873AapYt249CbCrmkGwBa5YsT04PCud/4CX0f9MFnA5ZXWSTE81qt+5Y92jDDhNkNYOTwy r9Jwt8wd4tRjoX6iqrT3DQIabmS401VL4Wbmm0gZfFTmI3GvfIIt64hCxq2noiRN9FQc=; Message-ID: Date: Tue, 10 Jan 2023 12:43:50 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 4/8] xen/riscv: introduce sbi call to putchar to console Content-Language: en-US To: Oleksii , xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis References: <9b85a963db538e4735a9f99fc9090ad79508cb2c.1673278109.git.oleksii.kurochko@gmail.com> <7990322c-639b-38d4-ff6c-221988532c33@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 10/01/2023 08:21, Oleksii wrote: > Hi, Hi Oleksii, > On Mon, 2023-01-09 at 16:03 +0000, Julien Grall wrote: >> Hi, >> >> On 09/01/2023 15:46, Oleksii Kurochko wrote: >>> The patch introduce sbi_putchar() SBI call which is necessary >>> to implement initial early_printk >>> >>> Signed-off-by: Oleksii Kurochko >>> --- >>> Changes in V2: >>>      - add an explanatory comment about sbi_console_putchar() >>> function. >>>      - order the files alphabetically in Makefile >>> --- >>>   xen/arch/riscv/Makefile          |  1 + >>>   xen/arch/riscv/include/asm/sbi.h | 34 ++++++++++++++++++++++++ >>>   xen/arch/riscv/sbi.c             | 44 >>> ++++++++++++++++++++++++++++++++ >>>   3 files changed, 79 insertions(+) >>>   create mode 100644 xen/arch/riscv/include/asm/sbi.h >>>   create mode 100644 xen/arch/riscv/sbi.c >>> >>> diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile >>> index 5a67a3f493..fd916e1004 100644 >>> --- a/xen/arch/riscv/Makefile >>> +++ b/xen/arch/riscv/Makefile >>> @@ -1,4 +1,5 @@ >>>   obj-$(CONFIG_RISCV_64) += riscv64/ >>> +obj-y += sbi.o >>>   obj-y += setup.o >>> >>>   $(TARGET): $(TARGET)-syms >>> diff --git a/xen/arch/riscv/include/asm/sbi.h >>> b/xen/arch/riscv/include/asm/sbi.h >>> new file mode 100644 >>> index 0000000000..34b53f8eaf >>> --- /dev/null >>> +++ b/xen/arch/riscv/include/asm/sbi.h >>> @@ -0,0 +1,34 @@ >>> +/* SPDX-License-Identifier: (GPL-2.0-or-later) */ >>> +/* >>> + * Copyright (c) 2021 Vates SAS. >>> + * >>> + * Taken from xvisor, modified by Bobby Eshleman >>> (bobby.eshleman@gmail.com). >> Hmmm... I missed this one in v1. Is this mostly code from Bobby? If >> so, >> please update the commit message accordingly. >> >> FAOD, this comment applies for any future code you take from anyone. >> I >> will try to remember to mention it but please take pro-active action >> to >> check/mention where the code is coming from. >> > Sure, I will try to be more attentive next time. > > Probably it is out of scope a little bit but could you please share > with me a link or clarify in which cases I have to add Copytrigt(c) or > should I add a new comment with "Modfied by Oleksii ... ", or it is not > necessary at all? Maybe have I to put some other information related to > copyrigts? From my experience, in Xen, we tend to use the signed-off-by rather in-file copyright. So I don't exactly know what would be the rule. Maybe George can help here? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Jan 10 12:44:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 12:44:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474663.735946 (Exim 4.92) (envelope-from ) id 1pFDzQ-0002jK-9Q; Tue, 10 Jan 2023 12:44:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474663.735946; Tue, 10 Jan 2023 12:44:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFDzQ-0002jD-6f; Tue, 10 Jan 2023 12:44:28 +0000 Received: by outflank-mailman (input) for mailman id 474663; Tue, 10 Jan 2023 12:44:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFDzP-0002hp-3x for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 12:44:27 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFDzP-0006HB-3C for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 12:44:27 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.2.225]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pFDzO-0007xO-TP; Tue, 10 Jan 2023 12:44:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: References:Cc:To:From:Subject:MIME-Version:Date:Message-ID; bh=s89S+/0Tw5JkM6SbysGCe35/dE77wWYNqa5KmJ+xXaw=; b=CexUFMK0KKQqCvf4s09suUEkJg cE7CT1+Qw+92Wd9SvNOeRfGrECeKXvcUYPXJAHfKcStS9LrE008lN+9L2fwwmNUW5GDTtTSAVuFNu yDrGNMkOnPXydWd7e6w0UTuVshWezI75Yp+jAWSm4CLcPSlZO4ihiJFjpxQA20hWWTTE=; Message-ID: Date: Tue, 10 Jan 2023 12:44:24 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 4/8] xen/riscv: introduce sbi call to putchar to console Content-Language: en-US From: Julien Grall To: Oleksii , xen-devel@lists.xenproject.org, George Dunlap Cc: Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis References: <9b85a963db538e4735a9f99fc9090ad79508cb2c.1673278109.git.oleksii.kurochko@gmail.com> <7990322c-639b-38d4-ff6c-221988532c33@xen.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit (+ George) On 10/01/2023 12:43, Julien Grall wrote: > > > On 10/01/2023 08:21, Oleksii wrote: >> Hi, > > Hi Oleksii, > >> On Mon, 2023-01-09 at 16:03 +0000, Julien Grall wrote: >>> Hi, >>> >>> On 09/01/2023 15:46, Oleksii Kurochko wrote: >>>> The patch introduce sbi_putchar() SBI call which is necessary >>>> to implement initial early_printk >>>> >>>> Signed-off-by: Oleksii Kurochko >>>> --- >>>> Changes in V2: >>>>       - add an explanatory comment about sbi_console_putchar() >>>> function. >>>>       - order the files alphabetically in Makefile >>>> --- >>>>    xen/arch/riscv/Makefile          |  1 + >>>>    xen/arch/riscv/include/asm/sbi.h | 34 ++++++++++++++++++++++++ >>>>    xen/arch/riscv/sbi.c             | 44 >>>> ++++++++++++++++++++++++++++++++ >>>>    3 files changed, 79 insertions(+) >>>>    create mode 100644 xen/arch/riscv/include/asm/sbi.h >>>>    create mode 100644 xen/arch/riscv/sbi.c >>>> >>>> diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile >>>> index 5a67a3f493..fd916e1004 100644 >>>> --- a/xen/arch/riscv/Makefile >>>> +++ b/xen/arch/riscv/Makefile >>>> @@ -1,4 +1,5 @@ >>>>    obj-$(CONFIG_RISCV_64) += riscv64/ >>>> +obj-y += sbi.o >>>>    obj-y += setup.o >>>>    $(TARGET): $(TARGET)-syms >>>> diff --git a/xen/arch/riscv/include/asm/sbi.h >>>> b/xen/arch/riscv/include/asm/sbi.h >>>> new file mode 100644 >>>> index 0000000000..34b53f8eaf >>>> --- /dev/null >>>> +++ b/xen/arch/riscv/include/asm/sbi.h >>>> @@ -0,0 +1,34 @@ >>>> +/* SPDX-License-Identifier: (GPL-2.0-or-later) */ >>>> +/* >>>> + * Copyright (c) 2021 Vates SAS. >>>> + * >>>> + * Taken from xvisor, modified by Bobby Eshleman >>>> (bobby.eshleman@gmail.com). >>> Hmmm... I missed this one in v1. Is this mostly code from Bobby? If >>> so, >>> please update the commit message accordingly. >>> >>> FAOD, this comment applies for any future code you take from anyone. >>> I >>> will try to remember to mention it but please take pro-active action >>> to >>> check/mention where the code is coming from. >>> >> Sure, I will try to be more attentive next time. >> >> Probably it is out of scope a little bit but could you please share >> with me a link or clarify in which cases I have to add Copytrigt(c) or >> should I add a new comment with "Modfied by Oleksii ... ", or it is not >> necessary at all? Maybe have I to put some other information related to >> copyrigts? > > From my experience, in Xen, we tend to use the signed-off-by rather > in-file copyright. So I don't exactly know what would be the rule. > > Maybe George can help here? > > Cheers, > -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Jan 10 12:47:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 12:47:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474672.735957 (Exim 4.92) (envelope-from ) id 1pFE22-0003Qx-QT; Tue, 10 Jan 2023 12:47:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474672.735957; Tue, 10 Jan 2023 12:47:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFE22-0003Qq-Nj; Tue, 10 Jan 2023 12:47:10 +0000 Received: by outflank-mailman (input) for mailman id 474672; Tue, 10 Jan 2023 12:47:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFE21-0003Qg-HL for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 12:47:09 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFE21-0006Zp-6z; Tue, 10 Jan 2023 12:47:09 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.2.225]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pFE21-00080n-1V; Tue, 10 Jan 2023 12:47:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=E7vvzdqWpXhtaNOOWAA3uWfbjk16x5NUFhROFipET3U=; b=F51I1WRIoYZ5jjV2lJfoZTQR/J H5yIaDVB41ItV6vKawADszOvw+tH94tqGcLBRCqLdb4EvcWvYsRSlszHAHv382d40M4K/tRuqvsoN Us4QgCXVNay/zDGKl9mw9VQM+gl7BHPNkkM59pDrDqEjEcZU2TZkvgD5/y4qD6FoJSYA=; Message-ID: <23bcfd2b-7482-c181-8520-3d4945386b8d@xen.org> Date: Tue, 10 Jan 2023 12:47:07 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v1 06/13] xen/arm: assign shared memory to owner when host address not provided Content-Language: en-US To: Penny Zheng , "xen-devel@lists.xenproject.org" Cc: Wei Chen , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20221115025235.1378931-1-Penny.Zheng@arm.com> <20221115025235.1378931-7-Penny.Zheng@arm.com> <6db41bd2-ab71-422a-4235-a9209e984915@xen.org> <8ae9e898-55ba-7fba-6ccc-883bd8b3e7ee@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Penny, On 10/01/2023 03:38, Penny Zheng wrote: >> -----Original Message----- >> From: Julien Grall >> Sent: Tuesday, January 10, 2023 2:23 AM >> To: Penny Zheng ; xen-devel@lists.xenproject.org >> Cc: Wei Chen ; Stefano Stabellini >> ; Bertrand Marquis ; >> Volodymyr Babchuk >> Subject: Re: [PATCH v1 06/13] xen/arm: assign shared memory to owner >> when host address not provided >> >> Hi Penny, > > Hi Julien, > >> >> On 09/01/2023 11:58, Penny Zheng wrote: >>>> -----Original Message----- >>>> From: Julien Grall >>>> Sent: Monday, January 9, 2023 6:58 PM >>>> To: Penny Zheng ; xen- >> devel@lists.xenproject.org >>>> Cc: Wei Chen ; Stefano Stabellini >>>> ; Bertrand Marquis >>>> ; Volodymyr Babchuk >>>> >>>> Subject: Re: [PATCH v1 06/13] xen/arm: assign shared memory to owner >>>> when host address not provided >>>> >>>> >>>> >>>> On 09/01/2023 07:49, Penny Zheng wrote: >>>>> Hi Julien >>>> >>>> Hi Penny, >>>> >>>>> Happy new year~~~~ >>>> >>>> Happy new year too! >>>> >>>>>> -----Original Message----- >>>>>> From: Julien Grall >>>>>> Sent: Sunday, January 8, 2023 8:53 PM >>>>>> To: Penny Zheng ; xen- >>>> devel@lists.xenproject.org >>>>>> Cc: Wei Chen ; Stefano Stabellini >>>>>> ; Bertrand Marquis >>>>>> ; Volodymyr Babchuk >>>>>> >>>>>> Subject: Re: [PATCH v1 06/13] xen/arm: assign shared memory to >>>>>> owner when host address not provided >>>>>> >>>>>> Hi, >>>>>> >>>>> >>>>> A few concerns explained why I didn't choose "struct meminfo" over >>>>> two pointers "struct membank*" and "struct meminfo*". >>>>> 1) memory usage is the main reason. >>>>> If we use "struct meminfo" over the current "struct membank*" and >>>>> "struct meminfo*", "struct shm_meminfo" will become a array of 256 >>>>> "struct shm_membank", with "struct shm_membank" being also an 256- >>>> item >>>>> array, that is 256 * 256, too big for a structure and If I >>>>> remembered clearly, >>>> it will lead to "more than PAGE_SIZE" compiling error. >>>> >>>> I am not aware of any place where we would restrict the size of kinfo >>>> in upstream. Can you give me a pointer? >>>> >>> >>> If I remembered correctly, my first version of "struct shm_meminfo" is >>> this >>> "big"(256 * 256) structure, and it leads to the whole xen binary is >>> . ;\ >> >> Ah so the problem is because shm_mem is used in bootinfo. Then I think we >> should create a distinct structure when dealing with domain information. >> > > Yes, If I use the latter "struct shm_info", keeping the shm memory info out of the bootinfo, > I think we could avoid "bigger than 2MB" error. > > Hmm, out of curiosity, The way to create "distinct" structure is like creating another section > for these distinct structures in lds, just like the existing .dtb section? No. I meant defining a new structure (i.e. struct {}) that would be used in kernel_info. So you don't grow the one used by bootinfo. > >>> >>>>> FWIT, either reworking meminfo or using a different structure, are >>>>> both leading to sizing down the array, hmmm, I don't know which size >>>>> is suitable. That's why I prefer pointer and dynamic allocation. >>>> >>>> I would expect that in most cases, you will need only one bank when >>>> the host address is not provided. So I think this is a bit odd to me to >> impose a "large" >>>> allocation for them. >>>> >>> >>> Only if user is not defining size as something like (2^a + 2^b + 2^c + >>> ...). ;\ So maybe 8 or 16 is enough? >>> struct new_meminfo { >> >> "new" is a bit strange. The name would want to be changed. Or maybe better >> the structure been defined within the next structure and anonymized. >> >>> unsigned int nr_banks; >>> struct membank bank[8]; >>> }; >>> >>> Correct me if I'm wrong: >>> The "struct shm_membank" you are suggesting is looking like this, right? >>> struct shm_membank { >>> char shm_id[MAX_SHM_ID_LENGTH]; >>> unsigned int nr_shm_borrowers; >>> struct new_meminfo shm_banks; >>> unsigned long total_size; >>> }; >> >> AFAIU, shm_membank would still be used to get the information from the >> host device-tree. If so, then I am afraid this is not an option to me because it >> would make the code to reserve memory more complex. >> >> Instead, we should create a separate structure that will only be used for >> domain shared memory information. >> > > Ah, so you are suggesting we should extract the domain shared memory information only > when dealing with the information from the host device-tree, something like this: > struct shm_info { > char shm_id[MAX_SHM_ID_LENGTH]; > unsigned int nr_shm_borrowers; > } I am not entirely sure what you are suggesting. So I will wait for the code to understand. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Jan 10 13:09:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 13:09:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474678.735968 (Exim 4.92) (envelope-from ) id 1pFENX-0005wy-Jm; Tue, 10 Jan 2023 13:09:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474678.735968; Tue, 10 Jan 2023 13:09:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFENX-0005wr-Ge; Tue, 10 Jan 2023 13:09:23 +0000 Received: by outflank-mailman (input) for mailman id 474678; Tue, 10 Jan 2023 13:09:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFENW-0005wk-BM for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 13:09:22 +0000 Received: from sonic316-54.consmr.mail.gq1.yahoo.com (sonic316-54.consmr.mail.gq1.yahoo.com [98.137.69.30]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fc845035-90e7-11ed-b8d0-410ff93cb8f0; Tue, 10 Jan 2023 14:09:18 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic316.consmr.mail.gq1.yahoo.com with HTTP; Tue, 10 Jan 2023 13:09:16 +0000 Received: by hermes--production-bf1-5458f64d4-x4bxm (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID de83800b43f3da3b8dbb82366d9f0a6c; Tue, 10 Jan 2023 13:09:11 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fc845035-90e7-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1673356156; bh=xPxK0N/c7OIZ3S47koGswtv5h8DdNmsgPJE9fA0o+04=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=jGCO6TUPD0nJtcyssryZVuYZtFVJcyPjBUjNQT2g7xLC4oLXqjMybRn4qd/7D37CoVgs0Dhv1euZ9rIocRF5JlwC54GWuYDgUCYnIjzM176wJC+W1dfuZoBiJyZWIkk0aVuTamKTLN1rXbNwKQAPYTyuPdwBBw73u/ZuQ3i36B43ggLVFD6cvrbGjwxbtkQ1GKwQXl7DXHzMXmU/PhfE0GygtLnXFNug6aW5rsa6d5FSLbN5z431GJKyle5qRwDDBEdt59yvGyrR21qkmdbjKhO7ynWowRAfWYip7n3gf/c4n7irg2qqt4Tpnf3mh8ckBX0z1JfkDi1rkQnbVpoUjg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1673356156; bh=xZ1//y5QUMtnD0uQm4jIk+IlVK2ENED2z9z6FebXnH9=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=r9Vbs1RUBsIabd6vbS/4QDcb0iSI/TLZ5RvUocmMd3Btbu/t6nY6iyjKpxs27H4riOjC2kaxZuU7lqa6EUmtlCwhnDhgFZbvNwtfh1/ohzamU/xjU1y7z/94/9VGO1BNq9u6LeG/x7mUb28XfenQIljEyQdFIC737lK4aN2kiWYhXFN1ef32LziyfPC9q9K7+eHFgJebRprPWjkRP9Xtsmbqnyk2oGZGouKGVkBC/uYBwgTl47PuqAt8PQkChp4jIFSQOJ3abl1zX6TpIwNagMCQC5ZGp/t+a5KK5LewiskqphRQ8HAKdpI0p3znMDtWG67IliEZ601bNgsoU8/oMA== X-YMail-OSG: RRrQYqgVM1mtJQxO.V8_ljUdVLqrV67aiRiAzws5CkNAmmdaUhLwgx9UveX7Net 6Zwx0BawIRZIBqDZlsBk.wIDsbPzVheKuBawppBV81QJA_qAjT0Z1ToE3qSUc1MCBlCj7I8gj9af j_RgWHN.LmgPDrNt5Qkz1pKwl.r07OJV7BqvYNyyg788KZcL2lz_dt38ph7lLt6CwbPE3K.zI4DW doCnmgK6dI73IWfTzvDqWpstamMDc.tAD8Nmo5WIhS43YfcEGws9OjUYEjzh2ayvy3jZG4lFo8eG GKWoT50mrYkZYhKL3KSWDBzoU7yCMU_Jvl96ncRjnJQq7sPaLaodHqccRcfidYUFP34SzD4b4iBM mh1FNcC6Zj7kWND00EqrnuyBTnCIPTcRB7G5cHBQL4sinM5VI9euuE13zLfYHI4cS24RIHw5LmLG jyv7KDg9MIWa04Zp.feFDHb1Y8FPEvd3YKc732OIUyYcw7prhufXohDTNGoELoun2LJmfADlUPVD MfFqzwNPrE4HrD2_C.9OtLCa0tUxwDQB10QwyXGQ_uRpM1MhTcYvyh5xFCubli3rArINChPWf47a Plic6roXX348LITPuz8sEzXDp99qoe0NDAPwwSOmn7J1e0FvL4svGV2j.L1ldENHZzsE3MUa8lgr pA.TRs2Bsa36r3W8msi_QQprxFdWLsENZSOOkD4WyBOcpLIZ4neZC5VjpoQWPQf0ZEG67J8MnQfm iKekUH0ZJCd6nM2JEQ2Vs_zmxB_VR6g_3Y0nhrg8C4sPbh_C69xfQI8x542J86Xze.GheW1JazQS 0Se3JC4cAWvc25NZ5eXVN.9lbC6b7JIuRPdHBKMuSS_yA.VmqrYzyMx.a_y.EMwCM3yhWG5jqIKJ 7Yi8kqmLzPbhtI1t.J3Ep_xWQCnbv5ugF8aGzbtQPy5m7l5ZgqrATtVdOXwNFfH1PsmIxNPAH6XH N6_DPXLwg2xQcrIx5L4RM470t934eTbu_L06PReFP4DjQnwJ8N1w9k4CtlTYFDzo06Su0N6PZq6r Z4qkuue3x9RyuYwaSVKE07OmFnA9cUEGy_5RYDn3nZl6DL3xNuRxeZ5d6SF6t7fZmrsyRgWC5Lkl g5E7EjcvLW2mcOZaVa5HntrfokQnfTxk6lM.pJPOXUtcuwuZR12UmdiwNNta1gfogDIXaysjBs0s E8aUFeNRufVyID2_KWVy_9iHoZUnAEOvauWdD8FlaIlKIEmUj3i37uhyCvcGmnFUy6ExiY1_ct3e bPut9_stPl6g_hFf4O34GutT2HtZ_6QaBDmcC1B.dmGZNfcN0N_VBa5JurTl1GGFzg76kUHAPrtT tZtyAKFQQwrCPxyVffIIpEHISSItbxFQTUY8Wiz_IknzMATu822uumUxQEDP4Ls8B2ryvY8StuTr cRZ_Ra6AaZ66ZrG8pQJa8UGKNog4t.8wEy4j0RCD7WtVWT9iRJ9.rXM5bomkGxXv9OZugVjsaL7U 1TMM4Qujkorv0zOeVjHhANwU_C8xpWSIx.1Oe8te8twG.tYSH6ch8uW.PyJKg_czkJUGj.bII3wr Vl.F9Tp9PyjF3MV0J_iwAHR0dXZXOs9k5HcQff62SMcLxXJ4nYU47O7RzefTKx83AVkxVrPDFjrW gGoifTRJjOXNW.Yf6tmjZyBkvJPZaZqUonPkNia2EOX0pEVhwIiTuTs14peZp5Eq7q.Kll0az7Be L8rQd0O.s8Z9f33TysA3bJMj129c2QLNmQ96rKncqHH93R.ZCO.lYmv2S0JWI2Co95yUuOkzCiOC lklZcL57zEIFCE.JWJdgAD3m2AIw.HLIY18iOpgHe2M_j3qKdukq.hUrLa0wbk2_i9TuDaNj6ymp CbFKn27R5n7q9ysQcwZ2UcRhQG6PVXErb3abD2fFK9mkRnED6pz9D945DheYOdXtLXue5kkoDPH_ Rxtsj4u04OVlLz84Huva0wF81XfZb8IkySR4vcRRLKwBtyDmdp.zpQJSGRNgxFUOuseiAdXwwOcl Obkep2oAWPtI74GevSoG5w6IFDDnSq8kMuR7cXr7bi4LmGnBUJ7FW1afQETD5VMCiFM_XBY838jT f1GsSnXQnDLC1roS9J_Wbwbzv.rXVSIFadzhTJiIJ_0H53TVrW80LMN0yBoG9k0u6x7vyhqYaWFU dpQpGfYjinLETlu5BlACbDOU_tbiucSFy.BIsA92v7v973E8aB5iOxkh6flSkUjNlPTh2EyBErj9 ZeLpYzDnoLEG53BsQZ1qyrmI- X-Sonic-MF: Message-ID: <8d5a0277-cfb0-169f-671a-0437118f7afb@aol.com> Date: Tue, 10 Jan 2023 08:09:10 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v8] xen/pt: reserve PCI slot 2 for Intel igd-passthru To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org, Stefano Stabellini , Anthony Perard , Paul Durrant , Paolo Bonzini , Richard Henderson , Eduardo Habkost , Marcel Apfelbaum , xen-devel@lists.xenproject.org References: <20230110030331-mutt-send-email-mst@kernel.org> Content-Language: en-US From: Chuck Zmudzinski In-Reply-To: <20230110030331-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailer: WebService/1.1.20982 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 13894 On 1/10/2023 3:16 AM, Michael S. Tsirkin wrote: > On Tue, Jan 10, 2023 at 02:08:34AM -0500, Chuck Zmudzinski wrote: > > Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, > > as noted in docs/igd-assign.txt in the Qemu source code. > > > > Currently, when the xl toolstack is used to configure a Xen HVM guest with > > Intel IGD passthrough to the guest with the Qemu upstream device model, > > a Qemu emulated PCI device will occupy slot 2 and the Intel IGD will occupy > > a different slot. This problem often prevents the guest from booting. > > > > The only available workaround is not good: Configure Xen HVM guests to use > > the old and no longer maintained Qemu traditional device model available > > from xenbits.xen.org which does reserve slot 2 for the Intel IGD. > > > > To implement this feature in the Qemu upstream device model for Xen HVM > > guests, introduce the following new functions, types, and macros: > > > > * XEN_PT_DEVICE_CLASS declaration, based on the existing TYPE_XEN_PT_DEVICE > > * XEN_PT_DEVICE_GET_CLASS macro helper function for XEN_PT_DEVICE_CLASS > > * typedef XenPTQdevRealize function pointer > > * XEN_PCI_IGD_SLOT_MASK, the value of slot_reserved_mask to reserve slot 2 > > * xen_igd_reserve_slot and xen_igd_clear_slot functions > > > > The new xen_igd_reserve_slot function uses the existing slot_reserved_mask > > member of PCIBus to reserve PCI slot 2 for Xen HVM guests configured using > > the xl toolstack with the gfx_passthru option enabled, which sets the > > igd-passthru=on option to Qemu for the Xen HVM machine type. > > > > The new xen_igd_reserve_slot function also needs to be implemented in > > hw/xen/xen_pt_stub.c to prevent FTBFS during the link stage for the case > > when Qemu is configured with --enable-xen and --disable-xen-pci-passthrough, > > in which case it does nothing. > > > > The new xen_igd_clear_slot function overrides qdev->realize of the parent > > PCI device class to enable the Intel IGD to occupy slot 2 on the PCI bus > > since slot 2 was reserved by xen_igd_reserve_slot when the PCI bus was > > created in hw/i386/pc_piix.c for the case when igd-passthru=on. > > > > Move the call to xen_host_pci_device_get, and the associated error > > handling, from xen_pt_realize to the new xen_igd_clear_slot function to > > initialize the device class and vendor values which enables the checks for > > the Intel IGD to succeed. The verification that the host device is an > > Intel IGD to be passed through is done by checking the domain, bus, slot, > > and function values as well as by checking that gfx_passthru is enabled, > > the device class is VGA, and the device vendor in Intel. > > > > Signed-off-by: Chuck Zmudzinski > > --- > > Notes that might be helpful to reviewers of patched code in hw/xen: > > > > The new functions and types are based on recommendations from Qemu docs: > > https://qemu.readthedocs.io/en/latest/devel/qom.html > > > > Notes that might be helpful to reviewers of patched code in hw/i386: > > > > The small patch to hw/i386/pc_piix.c is protected by CONFIG_XEN so it does > > not affect builds that do not have CONFIG_XEN defined. > > > > xen_igd_gfx_pt_enabled() in the patched hw/i386/pc_piix.c file is an > > existing function that is only true when Qemu is built with > > xen-pci-passthrough enabled and the administrator has configured the Xen > > HVM guest with Qemu's igd-passthru=on option. > > > > v2: Remove From: tag at top of commit message > > > > v3: Changed the test for the Intel IGD in xen_igd_clear_slot: > > > > if (is_igd_vga_passthrough(&s->real_device) && > > (s->real_device.vendor_id == PCI_VENDOR_ID_INTEL)) { > > > > is changed to > > > > if (xen_igd_gfx_pt_enabled() && (s->hostaddr.slot == 2) > > && (s->hostaddr.function == 0)) { > > > > I hoped that I could use the test in v2, since it matches the > > other tests for the Intel IGD in Qemu and Xen, but those tests > > do not work because the necessary data structures are not set with > > their values yet. So instead use the test that the administrator > > has enabled gfx_passthru and the device address on the host is > > 02.0. This test does detect the Intel IGD correctly. > > > > v4: Use brchuckz@aol.com instead of brchuckz@netscape.net for the author's > > email address to match the address used by the same author in commits > > be9c61da and c0e86b76 > > > > Change variable for XEN_PT_DEVICE_CLASS: xptc changed to xpdc > > > > v5: The patch of xen_pt.c was re-worked to allow a more consistent test > > for the Intel IGD that uses the same criteria as in other places. > > This involved moving the call to xen_host_pci_device_get from > > xen_pt_realize to xen_igd_clear_slot and updating the checks for the > > Intel IGD in xen_igd_clear_slot: > > > > if (xen_igd_gfx_pt_enabled() && (s->hostaddr.slot == 2) > > && (s->hostaddr.function == 0)) { > > > > is changed to > > > > if (is_igd_vga_passthrough(&s->real_device) && > > s->real_device.domain == 0 && s->real_device.bus == 0 && > > s->real_device.dev == 2 && s->real_device.func == 0 && > > s->real_device.vendor_id == PCI_VENDOR_ID_INTEL) { > > > > Added an explanation for the move of xen_host_pci_device_get from > > xen_pt_realize to xen_igd_clear_slot to the commit message. > > > > Rebase. > > > > v6: Fix logging by removing these lines from the move from xen_pt_realize > > to xen_igd_clear_slot that was done in v5: > > > > XEN_PT_LOG(d, "Assigning real physical device %02x:%02x.%d" > > " to devfn 0x%x\n", > > s->hostaddr.bus, s->hostaddr.slot, s->hostaddr.function, > > s->dev.devfn); > > > > This log needs to be in xen_pt_realize because s->dev.devfn is not > > set yet in xen_igd_clear_slot. > > > > v7: The v7 that was posted to the mailing list was incorrect. v8 is what > > v7 was intended to be. > > > > v8: Inhibit out of context log message and needless processing by > > adding 2 lines at the top of the new xen_igd_clear_slot function: > > > > if (!(pci_bus->slot_reserved_mask & XEN_PCI_IGD_SLOT_MASK)) > > return; > > > > Rebase. This removed an unnecessary header file from xen_pt.h > > > > hw/i386/pc_piix.c | 3 +++ > > hw/xen/xen_pt.c | 49 ++++++++++++++++++++++++++++++++++++-------- > > hw/xen/xen_pt.h | 16 +++++++++++++++ > > hw/xen/xen_pt_stub.c | 4 ++++ > > 4 files changed, 63 insertions(+), 9 deletions(-) > > > > diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c > > index b48047f50c..bc5efa4f59 100644 > > --- a/hw/i386/pc_piix.c > > +++ b/hw/i386/pc_piix.c > > @@ -405,6 +405,9 @@ static void pc_xen_hvm_init(MachineState *machine) > > } > > > > pc_xen_hvm_init_pci(machine); > > + if (xen_igd_gfx_pt_enabled()) { > > + xen_igd_reserve_slot(pcms->bus); > > + } > > pci_create_simple(pcms->bus, -1, "xen-platform"); > > } > > #endif > > I would even maybe go further and move the whole logic into > xen_igd_reserve_slot. And I would even just name it > xen_hvm_init_reserved_slots without worrying about the what > or why at the pc level. At this point it will be up to Xen maintainers. I will try to do that for v9. That would reduce, rather than increase, the technical debt. I actually wanted to move all the xen specific stuff in pc_piix.c to xen-hvm.c. That would reduce the technical debt that has accumulated over the years. I just couldn't see how to do it easily. It looked I would need to do violence to pc_init1. But, I suppose, pc_init1 is the kind of function that has accumulated lots of technical debt and needs some violence done to it! I will give it a try, but it might take me a while. I think if it was easy, someone would have done it by now. Thanks, Chuck > > > diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c > > index 0ec7e52183..eff38155ef 100644 > > --- a/hw/xen/xen_pt.c > > +++ b/hw/xen/xen_pt.c > > @@ -780,15 +780,6 @@ static void xen_pt_realize(PCIDevice *d, Error **errp) > > s->hostaddr.bus, s->hostaddr.slot, s->hostaddr.function, > > s->dev.devfn); > > > > - xen_host_pci_device_get(&s->real_device, > > - s->hostaddr.domain, s->hostaddr.bus, > > - s->hostaddr.slot, s->hostaddr.function, > > - errp); > > - if (*errp) { > > - error_append_hint(errp, "Failed to \"open\" the real pci device"); > > - return; > > - } > > - > > s->is_virtfn = s->real_device.is_virtfn; > > if (s->is_virtfn) { > > XEN_PT_LOG(d, "%04x:%02x:%02x.%d is a SR-IOV Virtual Function\n", > > @@ -950,11 +941,50 @@ static void xen_pci_passthrough_instance_init(Object *obj) > > PCI_DEVICE(obj)->cap_present |= QEMU_PCI_CAP_EXPRESS; > > } > > > > +void xen_igd_reserve_slot(PCIBus *pci_bus) > > +{ > > + XEN_PT_LOG(0, "Reserving PCI slot 2 for IGD\n"); > > + pci_bus->slot_reserved_mask |= XEN_PCI_IGD_SLOT_MASK; > > +} > > + > > +static void xen_igd_clear_slot(DeviceState *qdev, Error **errp) > > +{ > > + ERRP_GUARD(); > > + PCIDevice *pci_dev = (PCIDevice *)qdev; > > + XenPCIPassthroughState *s = XEN_PT_DEVICE(pci_dev); > > + XenPTDeviceClass *xpdc = XEN_PT_DEVICE_GET_CLASS(s); > > + PCIBus *pci_bus = pci_get_bus(pci_dev); > > + > > + if (!(pci_bus->slot_reserved_mask & XEN_PCI_IGD_SLOT_MASK)) > > + return; > > + > > + xen_host_pci_device_get(&s->real_device, > > + s->hostaddr.domain, s->hostaddr.bus, > > + s->hostaddr.slot, s->hostaddr.function, > > + errp); > > + if (*errp) { > > + error_append_hint(errp, "Failed to \"open\" the real pci device"); > > + return; > > + } > > + > > + if (is_igd_vga_passthrough(&s->real_device) && > > + s->real_device.domain == 0 && s->real_device.bus == 0 && > > + s->real_device.dev == 2 && s->real_device.func == 0 && > > + s->real_device.vendor_id == PCI_VENDOR_ID_INTEL) { > > how about macros for these? > > #define XEN_PCI_IGD_DOMAIN 0 > #define XEN_PCI_IGD_BUS 0 > #define XEN_PCI_IGD_DEV 2 > #define XEN_PCI_IGD_FN 0 > > > + pci_bus->slot_reserved_mask &= ~XEN_PCI_IGD_SLOT_MASK; > > If you are going to do this, you should set it back > either after pci_qdev_realize or in unrealize, > for symmetry. > > > + XEN_PT_LOG(pci_dev, "Intel IGD found, using slot 2\n"); > > + } > > > > + xpdc->pci_qdev_realize(qdev, errp); > > +} > > + > > > > > static void xen_pci_passthrough_class_init(ObjectClass *klass, void *data) > > { > > DeviceClass *dc = DEVICE_CLASS(klass); > > PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); > > > > + XenPTDeviceClass *xpdc = XEN_PT_DEVICE_CLASS(klass); > > + xpdc->pci_qdev_realize = dc->realize; > > + dc->realize = xen_igd_clear_slot; > > k->realize = xen_pt_realize; > > k->exit = xen_pt_unregister_device; > > k->config_read = xen_pt_pci_read_config; > > @@ -977,6 +1007,7 @@ static const TypeInfo xen_pci_passthrough_info = { > > .instance_size = sizeof(XenPCIPassthroughState), > > .instance_finalize = xen_pci_passthrough_finalize, > > .class_init = xen_pci_passthrough_class_init, > > + .class_size = sizeof(XenPTDeviceClass), > > .instance_init = xen_pci_passthrough_instance_init, > > .interfaces = (InterfaceInfo[]) { > > { INTERFACE_CONVENTIONAL_PCI_DEVICE }, > > diff --git a/hw/xen/xen_pt.h b/hw/xen/xen_pt.h > > index cf10fc7bbf..8c25932b4b 100644 > > --- a/hw/xen/xen_pt.h > > +++ b/hw/xen/xen_pt.h > > @@ -2,6 +2,7 @@ > > #define XEN_PT_H > > > > #include "hw/xen/xen_common.h" > > +#include "hw/pci/pci_bus.h" > > #include "xen-host-pci-device.h" > > #include "qom/object.h" > > > > @@ -40,7 +41,20 @@ typedef struct XenPTReg XenPTReg; > > #define TYPE_XEN_PT_DEVICE "xen-pci-passthrough" > > OBJECT_DECLARE_SIMPLE_TYPE(XenPCIPassthroughState, XEN_PT_DEVICE) > > > > +#define XEN_PT_DEVICE_CLASS(klass) \ > > + OBJECT_CLASS_CHECK(XenPTDeviceClass, klass, TYPE_XEN_PT_DEVICE) > > +#define XEN_PT_DEVICE_GET_CLASS(obj) \ > > + OBJECT_GET_CLASS(XenPTDeviceClass, obj, TYPE_XEN_PT_DEVICE) > > + > > +typedef void (*XenPTQdevRealize)(DeviceState *qdev, Error **errp); > > + > > +typedef struct XenPTDeviceClass { > > + PCIDeviceClass parent_class; > > + XenPTQdevRealize pci_qdev_realize; > > +} XenPTDeviceClass; > > + > > uint32_t igd_read_opregion(XenPCIPassthroughState *s); > > +void xen_igd_reserve_slot(PCIBus *pci_bus); > > void igd_write_opregion(XenPCIPassthroughState *s, uint32_t val); > > void xen_igd_passthrough_isa_bridge_create(XenPCIPassthroughState *s, > > XenHostPCIDevice *dev); > > @@ -75,6 +89,8 @@ typedef int (*xen_pt_conf_byte_read) > > > > #define XEN_PCI_INTEL_OPREGION 0xfc > > > > +#define XEN_PCI_IGD_SLOT_MASK 0x4UL /* Intel IGD slot_reserved_mask */ > > + > > I think you want to calculate this based on dev fn: > > #define XEN_PCI_IGD_SLOT_MASK \ > (0x1 << PCI_SLOT(PCI_DEVFN(XEN_PCI_IGD_DEV, XEN_PCI_IGD_FN))) > > > > typedef enum { > > XEN_PT_GRP_TYPE_HARDWIRED = 0, /* 0 Hardwired reg group */ > > XEN_PT_GRP_TYPE_EMU, /* emul reg group */ > > diff --git a/hw/xen/xen_pt_stub.c b/hw/xen/xen_pt_stub.c > > index 2d8cac8d54..5c108446a8 100644 > > --- a/hw/xen/xen_pt_stub.c > > +++ b/hw/xen/xen_pt_stub.c > > @@ -20,3 +20,7 @@ void xen_igd_gfx_pt_set(bool value, Error **errp) > > error_setg(errp, "Xen PCI passthrough support not built in"); > > } > > } > > + > > +void xen_igd_reserve_slot(PCIBus *pci_bus) > > +{ > > +} > > -- > > 2.39.0 > From xen-devel-bounces@lists.xenproject.org Tue Jan 10 13:33:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 13:33:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474709.736002 (Exim 4.92) (envelope-from ) id 1pFEkv-0001nb-2Q; Tue, 10 Jan 2023 13:33:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474709.736002; Tue, 10 Jan 2023 13:33:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFEku-0001nU-VF; Tue, 10 Jan 2023 13:33:32 +0000 Received: by outflank-mailman (input) for mailman id 474709; Tue, 10 Jan 2023 13:33:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFEkt-0001nO-As for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 13:33:31 +0000 Received: from mail-io1-xd35.google.com (mail-io1-xd35.google.com [2607:f8b0:4864:20::d35]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5e910951-90eb-11ed-91b6-6bf2151ebd3b; Tue, 10 Jan 2023 14:33:30 +0100 (CET) Received: by mail-io1-xd35.google.com with SMTP id p9so6044386iod.13 for ; Tue, 10 Jan 2023 05:33:30 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5e910951-90eb-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=V3B/LM8ZUGd4RO9vFOApASAS0OMkoE1zSbESnKwfo80=; b=TCfM9fZvFXL8U2n2TDqCunyJLRqPI+LzBxBx7rN4GmAw99Clh+0jHGKDPKg/ATX4Mm vYh1nBAXKRvPYKRfZTzWhxu1DbxogJToYli2+DAABy2AMsdKdQv+XiuFLrX8oqIQvi6k OayzLCeP+DnUIfT+ihn9/ItOu7YbAUoryvsvz39qjyYl397Y2T3aV08VuYWvCHL04IKH pC1TPaTpGnPIFI0+vGGSlHweYo7Qi9o2MNKz+d2l4perteGjlOOWXVanXn7pGMG1nq+J HM+uf9evLOroNbpdaeEKW3tfDYpICieOSLWAS5nzrSszenoKgCoUCVzBGUI3RjgH2gQL dCKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=V3B/LM8ZUGd4RO9vFOApASAS0OMkoE1zSbESnKwfo80=; b=XCQvfBPw8dZ3bDOz6OF9+2p2l474nfCsfYhHrpSwrDzje8363uWJLlHVEVAuP58Krr rD/Oie9dwETmxLzvuENsv3W+B8BFXXETu5xmrvX1q2UCR9PATp06uXc2H6hF5t2P+hR9 gwZWT0KZ35tmXRFgek4kEnK+JDlpAiXGqE+knG7D/DfvmcB9CopolhU/Ia9MNRXO5ckA UFlSHGeTbKGHBK9RhAPgaMnqu6W/Cx32POZZj7NFmRL/f3W535Q/brhCFxPpZ4ZmB8aA GmrVBdKVqn/B8NpLK9EBTGPXTVyJdKRQC3Heq4HMlo7biq4Gm27DjqRzyTskzJujitKq VgBg== X-Gm-Message-State: AFqh2kqCd28Q0Mwzap3zFDWHkqC/w6X2SsPGPRp/MGMLhvzJ6hTJm2G2 vcViRPQIF00XbmoMsEMGiY4EA1SA+tMa1wlQMbCabelWO64kRZnC X-Google-Smtp-Source: AMrXdXvqZlt8jWkcNV1EmfKGs/OFDLp8qvjNoyUc8wXHMbDIhYCX91ej8+/jLFnzebcEoszfKJWR7VIyX2vNomoGDT8= X-Received: by 2002:a02:ce97:0:b0:38c:886a:2140 with SMTP id y23-20020a02ce97000000b0038c886a2140mr7253968jaq.224.1673357608791; Tue, 10 Jan 2023 05:33:28 -0800 (PST) MIME-Version: 1.0 From: Tushar Goel Date: Tue, 10 Jan 2023 19:03:17 +0530 Message-ID: Subject: Usage of Xen Security Data in VulnerableCode To: xen-devel@lists.xenproject.org Content-Type: text/plain; charset="UTF-8" Hey, We would like to integrate the xen security data[1][2] data in vulnerablecode[3] which is a FOSS db of FOSS vulnerability data. We were not able to know under which license this security data comes. We would be grateful to have your acknowledgement over usage of the xen security data in vulnerablecode and have some kind of licensing declaration from your side. [1] - https://xenbits.xen.org/xsa/xsa.json [2] - https://github.com/nexB/vulnerablecode/pull/1044 [3] - https://github.com/nexB/vulnerablecode Regards, From xen-devel-bounces@lists.xenproject.org Tue Jan 10 13:46:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 13:46:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474716.736013 (Exim 4.92) (envelope-from ) id 1pFEwt-0003O4-A5; Tue, 10 Jan 2023 13:45:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474716.736013; Tue, 10 Jan 2023 13:45:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFEwt-0003Nx-6L; Tue, 10 Jan 2023 13:45:55 +0000 Received: by outflank-mailman (input) for mailman id 474716; Tue, 10 Jan 2023 13:45:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFEwr-0003Nr-Ug for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 13:45:54 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 173c59d0-90ed-11ed-b8d0-410ff93cb8f0; Tue, 10 Jan 2023 14:45:50 +0100 (CET) Received: from mail-sn1nam02lp2043.outbound.protection.outlook.com (HELO NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.57.43]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 10 Jan 2023 08:45:48 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BY5PR03MB5250.namprd03.prod.outlook.com (2603:10b6:a03:220::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 13:45:43 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5986.018; Tue, 10 Jan 2023 13:45:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 173c59d0-90ed-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1673358351; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=XWb0VbvPm8jSmoBaGDxroV2OdrW4JuVkM0w5nXMnJO4=; b=X53CPFZKZmZMUsjzt1LZAHaN85Ric6YQ7NLLDg7U5uWowZslwbmc+ZiY PZKK0hcUavpVliurE0Qmcwc7hrMtpJNVZd31jibRDy5gwXWQZnkjZJZPT 0nFFzt/klyGlKHox/DaXcgeU2rZpnsO9njAWfoy1Gqcy+MSeF7ie+sxdV Y=; X-IronPort-RemoteIP: 104.47.57.43 X-IronPort-MID: 92348887 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:gUcC2Kvp9FjimHzRsW9w23dvfOfnVGdfMUV32f8akzHdYApBsoF/q tZmKWvUbKuMYTH8fo91ao6zpExTuMLQzd43TlBq+Cw3FXtH+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg0HVU/IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj5lv0gnRkPaoQ5AaHzyFOZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwBCFQSjWl2/2N4J2rSOByiNQDdpioM9ZK0p1g5Wmx4fcOZ7nmG/+P3vkBmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osj/6xa7I5efTTLSlRtm+eq njL4CLSBRYCOcbE4TGE7mitlqnEmiaTtIc6Refjqq460AL7Kmo7GFood0OcntKAkFO+UtdxF EBP5Q8Usv1nnKCsZpynN/Gim1aYowUcUsAWHOo37EeBw7T87AOQB2xCRTlEAPQ2uclzSTE02 1uhm9LyGScpoLCTUWia9LqfsXW1Iyd9BXQPbjIeTBcUy8nupsc0lB2nczp4OKu8j9mwAjepx TmP9HI6n+9L0ZVN0Lin91fahT7qvoLOUgM++gTQWCSi8x99Y4mmIYev7DA38Mp9EWpQdXHZ1 FBspiRUxLlm4U2l/MBVfNgwIQ== IronPort-HdrOrdr: A9a23:rAjPc6iW7iWs32AbL5WfZVr7FXBQXh4ji2hC6mlwRA09TyX5ra 2TdZUgpHrJYVMqMk3I9uruBEDtex3hHP1OkOss1NWZPDUO0VHARO1fBOPZqAEIcBeOldK1u5 0AT0B/YueAd2STj6zBkXSF+wBL+qj6zEiq792usEuEVWtRGsVdB58SMHfiLqVxLjM2YqYRJd 6nyedsgSGvQngTZtTTPAh/YwCSz+e78q4PeHQ9dmca1DU= X-IronPort-AV: E=Sophos;i="5.96,315,1665460800"; d="scan'208";a="92348887" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ArmuJbaWL5dF4AtiXAj/CyftoyrRfkeV9iVcuT1d9GFryF4AdBLyUxypgoUxmQbSJtdaTjhZQT2y029kZWSKirksNfaN95BQ2C7YOrWpWLPvBtaeI+tL6RnU5O9Blxy6fyEUXSmTa4Ootq5kD4g074t4cEv0EEIrOzMLWe0LRRf4NbEg0dOKtZZ7lmZ5TiGkwTTCU7iHbOWI3UjnQOyYJwLaaAAMHxTbl9S+bIaZMOybRv+avYU00fZvz6x6p2ULPke61FVA/42E3kfpnVzflag5Vg+ZaC7OwBmd0ox3rIdPuUhD7dppYu8qVBZ4ySlA4nB9ygxbW/C2n+cff1XloQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XWb0VbvPm8jSmoBaGDxroV2OdrW4JuVkM0w5nXMnJO4=; b=PfA4Cwqb50p7UHGZFL+DntnEHZ1jdbRqhgKgjK7SwFpcXalwp8eYlQxr0FfagFeEC+Zo2Tn+p26+ayxgzuYyWzlXGG25iL/AL6Kr2MLmtnngh8FkIBwrAMdOxspzr8BNKoHFw7yMb9NXaCLDVu1xfJf8ggx+qDxkVlOSpwHYeBOh0jTXq7+KPFUrVt4JIG+lOkiDbun23FbiBqujQbPV+oPLoZXTA2WuauLyIervS6+FC4M8eAsNWMekAXNPpcLw81vlgL9y8MgT3+yz+l5rJHJMCQmIAY02JepUy2DgeOL5jN6ELjQ0QKrgxi2W+7b+ucdeYxZykwkw517EPgKVnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XWb0VbvPm8jSmoBaGDxroV2OdrW4JuVkM0w5nXMnJO4=; b=na61Dt86T2gfMO6VMx+5eOLCOkaeEj+gNN0HgNjPvqqxqtxwBq7shZ0yu0CdmTfKMnOHUn+hABCohX1rGZwWmDw3/wSZykndxqt0UTuYc3u+TwMypqHw+M5l1AUpQFH9gKKrreE8Nn+RtRXL9aZuF+8Z7hQpRourRtjFCM3WCiA= From: Andrew Cooper To: Tushar Goel , "xen-devel@lists.xenproject.org" CC: Xen Security Subject: Re: Usage of Xen Security Data in VulnerableCode Thread-Topic: Usage of Xen Security Data in VulnerableCode Thread-Index: AQHZJPgyisjAiCiXW0uW9I6mR5F/Cq6XqbkA Date: Tue, 10 Jan 2023 13:45:42 +0000 Message-ID: <7ddac120-29c5-d4fa-2bc7-9da6b1cf2dd9@citrix.com> References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|BY5PR03MB5250:EE_ x-ms-office365-filtering-correlation-id: febf5bd6-f66d-4a11-89bc-08daf310f7d9 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: VsjqMAxcq2gMIfzzUCHg+451kfqN8lWUsm1BOFkODv4zYLI95k4v7cGcV+AJnYMnDPjYqiyWuMN0B0+bYzRQXqMJlI6AqNeGP0pa2TgWuzRT0wwtRJrm5ZfDL3l/+6wwDDoLCGwnMYEMs2gClwpufQWyT7Ot+wgztM5Pywryb1lcOGfUscoy+lVfu5m0g2mN/sWlac/MLTDB5B7/tH5nWBmGv6i0FEogoIHklET0DhJN6wdUUXu862l0O3ALIF4Xm0nOy073dMdUlY+x7aq86nv9caCgMn2DghDxeo1htsDPm5q/XykxezUseV4CLrHfSS1av/ERufsxtI66ehMG32CrPidurVuqg5+nbUzI3pVybPQu6/TVbqnTxhBJoRMNaZZ/UHOA0bQQpzJ85eR7BK1JeM8Oq0ekhc8qOQs/5tXsD3wFBk2OHwlAsGv7D9zuu0EfS/1u1mMAYhS2KFs5IH8Pgo6NkweQ5+l7aJ4D4ZBKXPHAxzzgCpD6nAQAwBqhFMaDn5zHX4gGZyJY7nraozCOfFatkWLuuDHQPp1AOQ6ZA8h0wZWYOG3HDT6cDdetxx4J4EZXD+mH3agPIkr46XWj1f+uu4lVEoji0ffBps61F3vM/mM8SHGBDCK8y0bu6iEfa47vR4LY0X5toDNkTIhWaFIP7H2mSincRdMpc17bsydZzCoJNzP+U1GcsfZyBCX9jJ8rbt0w2G7ovjQr9PtPiRhWVTmjteh7y9bSo0YihlzOnhMDpW9MR9Ioda2suL+YZ18LJ6tOzYv0Kmj3C0ZegsXGjRXF3tMtCyHNGt1LLGucs+sTYe3HCz4VSMFXGRBqjZ5OqezUf+n5mUj1nw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(396003)(346002)(136003)(39860400002)(376002)(451199015)(8936002)(2906002)(5660300002)(41300700001)(71200400001)(4744005)(66446008)(4326008)(91956017)(316002)(8676002)(64756008)(76116006)(66556008)(66476007)(66946007)(15650500001)(110136005)(38070700005)(26005)(6512007)(2616005)(122000001)(38100700002)(31686004)(186003)(86362001)(83380400001)(31696002)(966005)(36756003)(82960400001)(478600001)(6486002)(53546011)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?RlNuRHI2TUFrUkRFK04xQkVoNm1vYy9CVkl0T2d2SE54Y2FtWTN2b2lQUXV6?= =?utf-8?B?VjA1blo2UWFzYU5FZ0VDcWFqQTFPaEJzU01vSVhGK0piRnB5b2NBZGk5b1FP?= =?utf-8?B?eVRUd3RZYmZReXVROG5OdW1iV1IrWmlXZ0dpN2czRUtYOGhqNi9acWZpUUFL?= =?utf-8?B?SVozbkhESkYyT0JmUE5sVG9yUFlNRUhQNmc1eEQ5Snd1dXY1TGdSS3E5QTZ2?= =?utf-8?B?a21ObmNxZGZaa2NmM0hucXlVYkJwQmFrRTlSTUFzZUdKbWRWaEdaWU5zZUEx?= =?utf-8?B?dThuMFJ0OUd4UmZYTlQreUZmZnZGZmpYS0NmU3N0d1BoK3Z4N2JVWUFRVVE4?= =?utf-8?B?Y0V3dEFzUHBZc29VTXRMQVE0cnZVT1VRd3F1Qk1BWXpPbTU2NCt5WEhHazFx?= =?utf-8?B?U3hXRDRBMGMrZmx5bmFFY3hiK1ZWSzVWdGc5YjRCaVVlVGpudm05WVo3czRB?= =?utf-8?B?MWNOSlJDYkFxUlpNN0VSaHVTZ0VsdjN0dklTYU04Z1N0T0tsRStwOFZFQmRV?= =?utf-8?B?eFI0dzJGQ1N0S09PV1BUTHM3enRMcFF0NkR5RGUwZm4rR2psVmRXTjJiK2xk?= =?utf-8?B?TnZhSW5OWVNmNDh1dzFvaExJR0YrTHNCdzFGbHhXeFZIMml3ME9CZHU1c1po?= =?utf-8?B?MDVRZ1U2WWNGbk02RE03YTFJeitEeityQjVadTF0R1JBL2tidHY1OHp5YlR5?= =?utf-8?B?eVltY2VHWU9LVk42Tk9oTGhRYUYvbXE2djRUaVlNM1NReWpwTEMyOVdLbENi?= =?utf-8?B?WTB6WHlSMitoWG1BYTBPajl3VEdJdkZqZlZ2YjZpeTA2eVhnT1FtTTFEaEJL?= =?utf-8?B?M1VRNmxRRnlaaEk0L1Y1bXphZFRUZTVVUUZLaFhOeFJzVkUvU2ZGS1dvREZF?= =?utf-8?B?VzJWTHdrSkhTb1RMVFBib3lJQXUrNmhqZlhJN2drUjQvaHBtLy9jeHc4czVz?= =?utf-8?B?R2JJak9JMlNHaW9qcFFuU3RKdEZHUzVRZzlSVExpZXhpSGE1VVRJbVRMaXo5?= =?utf-8?B?MlkzOHhjdG8xUXgwdFhkdHNSdzVsdnpGN21ySFNJdEU4RkZNRUFYbXR4WTZH?= =?utf-8?B?dzdWaEx4RTl2RmR3MXE2eWx4YWsyeTRxTXlGa0xpYTlJRnNvc0V4WFlzeWtx?= =?utf-8?B?b3MvcW1ZT0V4MW5PTGRFSDhOWkw5K1pHUTFZR05SZ29PUFl5dVovZFhzOEZN?= =?utf-8?B?KzY5QXE5M0RaaXNmSHd5WFZrT2svK2cvTFB2dEUrWlJMaFlVYzlPNmZHMEN0?= =?utf-8?B?UDZkaGdvYUM0WSs1Um1tWldRR1hsZnVCKytJb1QzbVVIaHkvVE9yZEhZRGhD?= =?utf-8?B?UWovUHFzaDR0YmNwZnh6eHgvRnBuL1VrNTk4elJlSk0yY3VCdEd1WWErZVVV?= =?utf-8?B?bUJDY1JsSEdMckxwS04vbis2WkFpMTB5bHowOU1YdGw0bHFTbHB3Q0wxdnlj?= =?utf-8?B?Vm16N3R0dGNUNWU5ZzVWNG0xS3M4c3ZZVzVPMmc0amtaQ3hUVGNDMVBoei9o?= =?utf-8?B?UzROdWNSTFlOUzhsNkErMTkzV0hQL3FDSGhMcGdYREIwdlhTVFU3UXdiREp5?= =?utf-8?B?bVB4UjBhNW1YZWZTZHhHZTNBZkJVeS9hdktHMHE5bmJleTR4ZWt0TjZuQWw4?= =?utf-8?B?QzY0eE9jRGgzanlGcnNsUmx6SDg2TzdEZVVuUEd3cHptQmFWT09UNVR0Y0tC?= =?utf-8?B?QUJ6ZFZ4bXl4N2dTOFQ2NEx3SGZ6YWp5RmVIMUdVNFdpcWUzWGtDTjJrSlVq?= =?utf-8?B?TWNqcUxjbWg1RGVvOXlOdkpiSlo1N1p4UkFkWnlQWS9ueGZnQUlFR2RBZkZ2?= =?utf-8?B?VlFhRWcrZnYvM1FxYTJzeG5ic001eW91MnBhVVNTZTk0aFZONndKdUNsM0dX?= =?utf-8?B?aGdYb2RURXJjYmtPWGFzK3RseVppcittWm5OeGNBZ2NNVXhPQnVYcTZCQzU5?= =?utf-8?B?NjdrUGhtMEpJVnNLS0U4ZW16S2NER3VPU1ZZNC9QSUcwQ2dOR0RJSGtwNTBD?= =?utf-8?B?WkZsVlVpcE5ZaThNSHJvN0ViMmJXMWNuZTBGK1hsRHBDakZQL3V5dUlRTEto?= =?utf-8?B?R2JjVHRGTmFJbW5TY2dEVjZZV2Zmdm04R0RtMGVzd0w3ckM0STBROHZReEwz?= =?utf-8?Q?oPjgy92QpDvj2HG6lX/qHciqM?= Content-Type: text/plain; charset="utf-8" Content-ID: <7F47F6EBD01EA6479DC2ED3CDBCEC819@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: x9IYZizMc2cg96k2SiyzVYkVef9BdagCdfwPuqpYjp1gpOiV0b08QN/0/IjGqQVzFvkct+8cViPv3WdmN6H8TW390bWq0Y2Qr1+jFfVRV7w15mk8I+B4SkQm6M9TXzq/ih4BCMV1GMeFCoWyoTuP5Uh69a0+bJlJ/adRknJeObply9r9lOr/+VAzIJMUCbyghxPMrGOtQ98PhF4kBsYVsotkzGAi6rNKPfJW7XCki/6HMzfB8Ft80YrAnMwlGE2edPexmOWDeRTMEaGeoOXAT7adbSqB+QfaWvnVsbVXK60I5RMhOX54Iy1GLAxemQib90ysfD9IRZWSxI7DLMGaunKGTrv8+f9Vh+epowh8YpRfKVCwhQ8AiXv02nJYvzsIqKiBnpIELGSjAbA43sf35C3CouUn06aQ4OJqEHvTM2R6R2e0qOKoa1gj7gZoBQ5ykVAQIdRztrspOZgBJXOWaYyv8fH5irarT7HNS/soNdZ5R94NKPwVDx0vQUEbQaFvY9SwpqXCF7zJULGPPw2dyVLXH3cgy530yG9jmO/VDCGmmTs50XGx6FZNARFUZjwCEckhhIW0grcmztNOMejsKyzxZEhr6lvh7/sJH3+JNfIoXfKKYKost2PTAI5d1LS6j1IatIQddQby3DjV2jP4XrNR9iwpMlOQzRnOaOrab8Mkly5Ua6ACecknaCI7R6lN9+pl+gBGBRFBRU8zBdlht0eH/N1o93oBpycfJR6zheUfTrhHpPn/+e9XGtD55Ko7dru9uyUIeFhUtvQtD0N4OTcK0RXhqIg0t06NE4+Haq+V5TzuZmwxybp2efGxTZNdBPyBJUOmEHOMKY+p227vgA== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: febf5bd6-f66d-4a11-89bc-08daf310f7d9 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jan 2023 13:45:42.8976 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: b5UC8YmDpikbovroZxI/ADB9skZOJ36wzPpRz4vwzIFmSLXSzhB3Z7JcriYD05aY1OCaDDLZHkEJYSVtERjgaOl5DeYFPuMegmCsUcebXu8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5250 T24gMTAvMDEvMjAyMyAxOjMzIHBtLCBUdXNoYXIgR29lbCB3cm90ZToNCj4gSGV5LA0KPg0KPiBX ZSB3b3VsZCBsaWtlIHRvIGludGVncmF0ZSB0aGUgeGVuIHNlY3VyaXR5IGRhdGFbMV1bMl0gZGF0 YQ0KPiBpbiB2dWxuZXJhYmxlY29kZVszXSB3aGljaCBpcyBhIEZPU1MgZGIgb2YgRk9TUyB2dWxu ZXJhYmlsaXR5IGRhdGEuDQo+IFdlIHdlcmUgbm90IGFibGUgdG8ga25vdyB1bmRlciB3aGljaCBs aWNlbnNlIHRoaXMgc2VjdXJpdHkgZGF0YSBjb21lcy4NCj4gV2Ugd291bGQgYmUgZ3JhdGVmdWwg dG8gaGF2ZSB5b3VyIGFja25vd2xlZGdlbWVudCBvdmVyDQo+IHVzYWdlIG9mIHRoZSB4ZW4gc2Vj dXJpdHkgZGF0YSBpbiB2dWxuZXJhYmxlY29kZSBhbmQNCj4gaGF2ZSBzb21lIGtpbmQgb2YgbGlj ZW5zaW5nIGRlY2xhcmF0aW9uIGZyb20geW91ciBzaWRlLg0KPg0KPiBbMV0gLSBodHRwczovL3hl bmJpdHMueGVuLm9yZy94c2EveHNhLmpzb24NCj4gWzJdIC0gaHR0cHM6Ly9naXRodWIuY29tL25l eEIvdnVsbmVyYWJsZWNvZGUvcHVsbC8xMDQ0DQo+IFszXSAtIGh0dHBzOi8vZ2l0aHViLmNvbS9u ZXhCL3Z1bG5lcmFibGVjb2RlDQoNCkhtbSwgZ29vZCBxdWVzdGlvbi4uLg0KDQpJbiBwcmFjdGlj ZSwgaXQgaXMgcHVibGljIGRvbWFpbiwgbm90IGxlYXN0IGJlY2F1c2Ugd2UgcHVibGlzaCBpdCB0 bw0KTWl0cmUgYW5kIHZhcmlvdXMgcHVibGljIG1haWxpbmcgbGlzdHMsIGJ1dCBJJ20gbm90IGF3 YXJlIG9mIGhhdmluZw0KZXhwbGljaXRseSB0cmllZCB0byBjaG9vc2UgYSBsaWNlbnNlLg0KDQpN YXliZSB3ZSB3YW50IHRvIG1ha2UgaXQgQ0MtQlktNCB0byByZXF1aXJlIHBlb3BsZSB0byByZWZl cmVuY2UgYmFjayB0bw0KdGhlIGNhbm9uaWNhbCB1cHN0cmVhbSA/DQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Tue Jan 10 14:20:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 14:20:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474724.736024 (Exim 4.92) (envelope-from ) id 1pFFUI-0007g8-To; Tue, 10 Jan 2023 14:20:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474724.736024; Tue, 10 Jan 2023 14:20:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFFUI-0007g1-QR; Tue, 10 Jan 2023 14:20:26 +0000 Received: by outflank-mailman (input) for mailman id 474724; Tue, 10 Jan 2023 14:20:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFFUH-0007ff-Bg for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 14:20:25 +0000 Received: from de-smtp-delivery-114.mimecast.com (de-smtp-delivery-114.mimecast.com [194.104.109.114]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id eb86f9b9-90f1-11ed-91b6-6bf2151ebd3b; Tue, 10 Jan 2023 15:20:23 +0100 (CET) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2109.outbound.protection.outlook.com [104.47.17.109]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-41-ae_4dJ7pNuSO1jSvk4bUKQ-1; Tue, 10 Jan 2023 15:20:20 +0100 Received: from AM5PR0802MB2578.eurprd08.prod.outlook.com (2603:10a6:203:9e::22) by PA4PR08MB6047.eurprd08.prod.outlook.com (2603:10a6:102:e3::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 14:20:18 +0000 Received: from AM5PR0802MB2578.eurprd08.prod.outlook.com ([fe80::f7f1:3b45:d707:62b7]) by AM5PR0802MB2578.eurprd08.prod.outlook.com ([fe80::f7f1:3b45:d707:62b7%2]) with mapi id 15.20.5986.018; Tue, 10 Jan 2023 14:20:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eb86f9b9-90f1-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zf.com; s=mczfcom20220728; t=1673360423; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=/cGjmQeA5LXT2I8FikypkzEeMiaptjZePldsNjHLTvk=; b=ZI9gtnFDc+uInj7CBMdSYF4Zz8dxD9nEsiU+UHjoZ+XbQlvJE8tebgZxWvcxeGVf5+im82 EstPNq0Z3ar6VQ9yBYHk8H90yh8CBL1WLYZK3/6DNiYQYvN3ce1zJsVwb+Czj+/79g0baE Rs6WS4xmdY1aofkrhsTSNqwzSfNsQUE= X-MC-Unique: ae_4dJ7pNuSO1jSvk4bUKQ-1 From: El Mesdadi Youssef ESK UILD7 To: "xen-devel@lists.xenproject.org" Subject: Xenalyze on ARM ( NXP S32G3 with Cortex-A53) Thread-Topic: Xenalyze on ARM ( NXP S32G3 with Cortex-A53) Thread-Index: Adkk/qg7kRGuW6KDReaFxxX6SSJ/1g== Date: Tue, 10 Jan 2023 14:20:18 +0000 Message-ID: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_7294a1c8-9899-41e7-8f6e-8b1b3c79592a_Enabled=true; MSIP_Label_7294a1c8-9899-41e7-8f6e-8b1b3c79592a_SetDate=2023-01-10T14:20:17Z; MSIP_Label_7294a1c8-9899-41e7-8f6e-8b1b3c79592a_Method=Privileged; MSIP_Label_7294a1c8-9899-41e7-8f6e-8b1b3c79592a_Name=Internal sub2 (no marking); MSIP_Label_7294a1c8-9899-41e7-8f6e-8b1b3c79592a_SiteId=eb70b763-b6d7-4486-8555-8831709a784e; MSIP_Label_7294a1c8-9899-41e7-8f6e-8b1b3c79592a_ActionId=eeca7847-45f1-4c89-8855-4db1e219313e; MSIP_Label_7294a1c8-9899-41e7-8f6e-8b1b3c79592a_ContentBits=0 x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AM5PR0802MB2578:EE_|PA4PR08MB6047:EE_ x-ms-office365-filtering-correlation-id: 3b6818af-14ca-44af-c33f-08daf315cd30 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0 x-microsoft-antispam-message-info: XozK9bbrrn0qoH9EPF6QWM3hGHTVJqsoSh3MWK2ZpFukXThZ1zC8wRmU/n4I6xGel4jr+OiSYKdRfqQ5uqNFaQHBpHtm1OP135/PmflG83xYd7WsyqwSviYOVYi+AgLc5QqymMtU7keD482WPN6kgftvKE34PEjicEDRTUly5cNh/eLNqqwbzm5D/NX/093T7W2mepXSaMtk2HiJC/52BywCAxmJQ7W3PHTjmMoj34k2PqHj30BaQz2j5rENcD5fPy1lyhADhLm+G38kLgdDW7ZeN+cTdqTwcKfL8ti6J7D4+IAPRWNoMwzIvD+sjPgoOHuUY7ZT8EKYBOloX4tk6pfAI/7JYRf1xGhDS+bbM3h6zkbQtNzebZ/wWIW/rtrBr1eq9yNJQMRjLInbx5C/SXfZ7uU9j7eu5O0vOw1NY+0XHNmsFEQDEBEx0eQyTv95aUwoJmhSu7tPgCyF9gf0I2KdBH0MgkgeJeExIKoyfA86XgXdOvfr+uCIs7M4tmCEMWLcNlu0+v5ThQQ2E1PNQM51PVTrKQmJdsLy+2kLWuLjAITeo/BeGWOKp69BGM5YYDeXj+wFDS/5/Jfg6r/e33oh6sfk0LE3eQssr5mFd2NDmrfKC870l3nqMQwo/cFVTpgvvweCc64pePifAxxD+q4NOJT4Vxy2NlyyN9CjQt0iUMp6Fgo7P1xD+M/c7q4o+8qjj7S0eY7P5HQQtEluiQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM5PR0802MB2578.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(136003)(39860400002)(376002)(366004)(451199015)(71200400001)(86362001)(6916009)(316002)(8936002)(52536014)(2906002)(38100700002)(478600001)(82960400001)(19627235002)(66556008)(66476007)(66446008)(7696005)(64756008)(26005)(76116006)(66946007)(41300700001)(186003)(9686003)(8676002)(33656002)(6506007)(38070700005)(122000001)(55016003)(83380400001)(5660300002);DIR:OUT;SFP:1102 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wz0MOUEKUg3eF8xUCfV5oZOCIDuVDpQEXspbJFGwkbl2/V2Z2kmMF5jOkLIE?= =?us-ascii?Q?OAaZXAZtZio9gcwOWgtQW+tsCYRkzbo5AnyQ4XUm0ClSbP0yrshiwn4DcOM/?= =?us-ascii?Q?i2CjiAToaTu36fX3QHlG9UJZBjM1zegzoDaxpplLH3mleaydj5Dy6WShnFl0?= =?us-ascii?Q?uG9yHRPNj8c63IdhdiwbbiAxY3WWErHCLsfNInSU5EfNx5eef1vKUSqDSnNy?= =?us-ascii?Q?UXiNFf4IxHiOZihxXVVv1rTcM9YnQiYrm3ALof0TF+MJflPGXRd3pnygt09H?= =?us-ascii?Q?dt1iDUowMEcYBWz1HfMSrrg+qoGsJgnvW3GXmr4T8C9GBPbJ2POYsWC4ylCL?= =?us-ascii?Q?luW8qUhEbSbCz76ccIlWLlOYQcSye4cUv4ZOwjNjhaIq/F4Y8e/Ljd/javKE?= =?us-ascii?Q?OhbAoX+TR2j6h0wub2JJc1LKCmsZZOEwCY9P5e7W7cRT8jeeR3kKS/8V34Lt?= =?us-ascii?Q?iY67BfuhE5w8v0FH5SGObo6GF+5rsUOSYWX2a4nek7lM8K2pbfNdWmVhGCca?= =?us-ascii?Q?t/njdpqX48lyTiggTFMhpZJdvQJ7HrajLSxNF0QeKovNrzfXR4CiNxt/avIX?= =?us-ascii?Q?dxUpmrBiKIkzBdwrMvN6cHP3/HlIG6DV+k8BXKp1yIWuUyE2Flfx8Q3quXcs?= =?us-ascii?Q?n/0PLtxnX93iZRd1r8AOIJtLqiOchsEcu/uMlQBRo/QVNTASIFPKVENUGQq/?= =?us-ascii?Q?i6mWMEcs25qxH1C6vnZGb5W1SM9afXpwkn0hYMVNguOxKnQCKAstKVW/jxHC?= =?us-ascii?Q?DoYV2qqLpx6hiGHIrBPPMdW/mqGDD4vCrgs6SfTbGUhQjXiO3xDplxFDcjE5?= =?us-ascii?Q?VE/u3NPu8+av8S9UtxIkOJCaKCts/2zvirDjJ0vK2noc4+KFAzXyaV2Ou8Ls?= =?us-ascii?Q?F2uq0UklNfo9HRZCv6w502esmLC1s8wQTsp0hqHKakmzuuxuWsQIlWTsRclV?= =?us-ascii?Q?xyovW7rUlovxvmYBFeEK+XSyaNPWxFlgKREZelM+BO5cxNH7qzd1hKFTJ4by?= =?us-ascii?Q?E7ukfZzFJMEyQSXE72PB6po1T5aE3frQ29QEHyaZ7uYy1XWZVhffNhAf5JEa?= =?us-ascii?Q?bNcfZnfXcI8TUBt/kJRjPV62wrV83TpbTzz9/YhXgx157TF4XuhefnNCj679?= =?us-ascii?Q?8JpgL0nvBj++WDw+tvpUIuIM15Vl1kYwinDhkM8ypWjfu1q16mLDQdu67pLF?= =?us-ascii?Q?JFevruxtt0TUBhkWJa90yxDyQ/AGLhor85JIHzKxbu3X/QLe4YiFRNIQc0zm?= =?us-ascii?Q?Ie51Ma+qqjm2PEytOh5M0T48kqsxz4Tu8X6rBnC1CVvfAze8DoZzyL5ZlJBF?= =?us-ascii?Q?HkVTucjHlVGkl5PDTPa01WclfSULpbaddJLISipMeNdU8Lu4VRs3d6NGZ06l?= =?us-ascii?Q?vCE9smrqexuABEgAIGUOUNKVafavBXsbzbUCIDY6v2/hUu3MDNZFvUyEd41S?= =?us-ascii?Q?dJGD93sW9a3GM+pt7zYDyUM/1k+TFA8KkTS7Wm8GMtOsrWTZSUIAX8Q09v4+?= =?us-ascii?Q?oZl0Kj2toIGHIFooqTtO/9RcndhZ2CFu0SxXwqCFklNHv8Bf/R+cIEDF0p0S?= =?us-ascii?Q?XcmyCFAb2HMWNHNg527ZPEpy4iC/bu4kb1f1PAyV?= MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: VXmaIekqeDtV+ii4zkHKR0cjZAFYivVT3QqZi+xD6M2dd8B36cKWbh9gGhP/voyRsmXN/aTf7E0aTQRdl1IElVXlgoBfeAaxoXwxki1GMGgWa3u8W2jVRe9ksBJJklzVaxkCnIaBLOtPTCWxumLK01b7y+5F0KJUVkyN/q3dGLBcalooDWHx5Gy7VMU3JNl+eLS24jyuEtRW8I5JGtWkB7IGpr3brsynhaUn1zVTG6JZpJBw5bGEfIF7qUsClec9hJ9MaZFDv2Vi5dAzfFnf/NwEOoMEp6iTZw0GWgTU6a9GEl5yrhmTs6UmRnjCdRpiQERdy4jXorLzHlaj0aQqxDiDiRqiES1N8C8XPrNyGMtGJb+NtWHd216unGJrP3YSXVI97F4HL7RdXZW46+vm09pZHYQgeyDIqMP8NKs3Qlgp6jdsnUcprfXL5cxDu5NVCx0WLql2hV+K6FsqoKdFWLmRKrs5kQaK02tJfukPRZHbuu6sSGbw9Uf6Fjk4cGovwHvaKKZ1qojlmuZHYnoN9qa0wFwgFwO1wwQv8rD87UrXb7bMhuoGDzTYqT3o9OFc0yoLeu+xYTqN+vXgDrU9odQUkNYyi5RmtjAyRJtwjSpisgz7Ocrxc2e10FkiX4mV4tJBgSnnSje+POzGG5cCMD1RLMAxSrrSsi8RVlg2S/mds99Knk6Mp9T2dmtAF/x27kbA4EuttsyJGya0pUt3H+js6Nmd4sQoLdAY/ZRyloTsS2q6CEuAvBb0agVeUgu8XZQUJ9RQslAK3D2M1intGA== X-OriginatorOrg: zf.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM5PR0802MB2578.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3b6818af-14ca-44af-c33f-08daf315cd30 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jan 2023 14:20:18.8109 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: eb70b763-b6d7-4486-8555-8831709a784e X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NoUccbDIVHxkqpltGYfAZqaHsSbYy3SYNlLPlL29wEMg1jxySax1PI0Bza+tzJhSMMkT24ISK4SSWasbMxb+McshRAnPioBK9pjLbI7sEbg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6047 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: zf.com Content-Language: de-DE Content-Type: multipart/alternative; boundary="_000_AM5PR0802MB25781717167B5BFC980BF2A49DFF9AM5PR0802MB2578_" --_000_AM5PR0802MB25781717167B5BFC980BF2A49DFF9AM5PR0802MB2578_ Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable >> Hello, >> I'm trying to measure the performance of Xen on the S32G3 microprocessor, u= nfortunately, after following the BSP-Linux to install Xen, I found that Xe= ntrace is not available or not compatible with ARM architecture. I have see= n some studies on Xilinx, and how they made Xentrace compatible with ARM, = but I have no resources or access to get that and make it work on my Board.= If there is any help I would appreciate it and thanks in advance. >> I have some extra questions, and it will be helpful to share your ideas = with me, * Is it possible to run a native application ( C-code) on the virtual m= achine, turn on a LED, have access to the GPIO, or send some messages usin= g Can-Interface? * My Board has no Ethernet, and no Extern SD Card, is there any method = I can use to build a kernel for an operating system with my laptop, and tra= nsfer it to the board? * Any suggestions in detail to measure the interrupt latency, Xen Overh= ead, and switch context (time to switch from one VM to another, that's what= I wanted to measure with Xenalyze) >> Best regards >> Youssef El Mesdadi --_000_AM5PR0802MB25781717167B5BFC980BF2A49DFF9AM5PR0802MB2578_ Content-Type: text/html; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable

>> Hello,

 

>>

I’m trying to measure the= performance of Xen on the S32G3 microprocessor, unfortunately, after follo= wing the BSP-Linux to install Xen, I found that Xentrace is not available o= r not compatible with ARM architecture. I have seen some studies on  Xilinx, and how they made Xentrace compati= ble with ARM, but I have no resources or access to get that and make it wor= k on my Board. If there is any help I would appreciate it and thanks in adv= ance.

 

>> I have some extra ques= tions, and it will be helpful to share your ideas with me,

 

  • Is it possible to run a native application ( C-c= ode) on the virtual machine, turn on a LED,  have access to the GPIO, = or send some messages using Can-Interface?
  • My Board has no Ethernet, and no Extern SD Card, is there= any method I can use to build a kernel for an operating system with my lap= top, and transfer it to the board?
  • Any suggestions in detail to measure the interrupt latency, Xen = Overhead, and switch context (time to switch from one VM to another, that&#= 8217;s what I wanted to measure with Xenalyze)

 

>> Best regards

>> Youssef El Mesdadi

 

--_000_AM5PR0802MB25781717167B5BFC980BF2A49DFF9AM5PR0802MB2578_-- From xen-devel-bounces@lists.xenproject.org Tue Jan 10 15:04:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 15:04:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474733.736040 (Exim 4.92) (envelope-from ) id 1pFGAp-0003kg-BM; Tue, 10 Jan 2023 15:04:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474733.736040; Tue, 10 Jan 2023 15:04:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFGAp-0003kZ-8l; Tue, 10 Jan 2023 15:04:23 +0000 Received: by outflank-mailman (input) for mailman id 474733; Tue, 10 Jan 2023 15:04:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFGAn-0003kP-Bp; Tue, 10 Jan 2023 15:04:21 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFGAn-0001Do-9C; Tue, 10 Jan 2023 15:04:21 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFGAm-0006Hb-VC; Tue, 10 Jan 2023 15:04:21 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pFGAm-0006TS-Ug; Tue, 10 Jan 2023 15:04:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=gShHeZwpUPtVRY+/OJyvx/WPMcOr392XPikRBy+l5MI=; b=GknK0HyEBW4jXUaIfpHSGlvPVA 4s7tyFxbJ4+Z9Wkik+n3rqr6Q2JARgHmBwD1zkq/z30JTpbFFwl6hJfem/tccPHjO0jbyjFF/x4Ix iWaUdBgvXW4AXDZNZbol45g5AifTUGvMXMAYu5k1rZ3TGp2WHjx8qr9JhYznKHBz1U1U=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 175691: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-amd64-xsm:xen-build:fail:regression qemu-mainline:build-amd64:xen-build:fail:regression qemu-mainline:build-i386:xen-build:fail:regression qemu-mainline:build-arm64-xsm:xen-build:fail:regression qemu-mainline:build-i386-xsm:xen-build:fail:regression qemu-mainline:build-arm64:xen-build:fail:regression qemu-mainline:build-armhf:xen-build:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-coresched-amd64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:build-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-rtds:build-check(1):blocked:nonblocking qemu-mainline:build-arm64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking qemu-mainline:build-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking qemu-mainline:build-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-dom0pvh-xl-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-dom0pvh-xl-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvshim:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-pygrub:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvhv2-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-freebsd11-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-freebsd12-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvhv2-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-multivcpu:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: qemuu=aa96ab7c9df59c615ca82b49c9062819e0a1c287 X-Osstest-Versions-That: qemuu=0ab12aa32462817f0a53fa6f6ce4baf664ef1713 From: osstest service owner Date: Tue, 10 Jan 2023 15:04:20 +0000 flight 175691 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/175691/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 175623 build-amd64 6 xen-build fail REGR. vs. 175623 build-i386 6 xen-build fail REGR. vs. 175623 build-arm64-xsm 6 xen-build fail REGR. vs. 175623 build-i386-xsm 6 xen-build fail REGR. vs. 175623 build-arm64 6 xen-build fail REGR. vs. 175623 build-armhf 6 xen-build fail REGR. vs. 175623 Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-win7-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ws16-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-shadow 1 build-check(1) blocked n/a test-amd64-i386-xl-vhd 1 build-check(1) blocked n/a test-amd64-i386-xl-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) blocked n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) blocked n/a test-armhf-armhf-xl-rtds 1 build-check(1) blocked n/a test-armhf-armhf-xl-vhd 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-amd 1 build-check(1) blocked n/a test-amd64-i386-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-i386 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-amd64 1 build-check(1) blocked n/a test-amd64-coresched-i386-xl 1 build-check(1) blocked n/a test-amd64-coresched-amd64-xl 1 build-check(1) blocked n/a test-amd64-amd64-xl-xsm 1 build-check(1) blocked n/a build-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-shadow 1 build-check(1) blocked n/a test-amd64-amd64-xl-rtds 1 build-check(1) blocked n/a build-arm64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ws16-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a build-armhf-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-amd64-dom0pvh-xl-amd 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 1 build-check(1) blocked n/a test-amd64-amd64-dom0pvh-xl-intel 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvshim 1 build-check(1) blocked n/a test-amd64-amd64-pair 1 build-check(1) blocked n/a test-amd64-amd64-pygrub 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvhv2-intel 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-freebsd11-amd64 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-freebsd12-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvhv2-amd 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-nested-amd 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-nested-intel 1 build-check(1) blocked n/a test-amd64-amd64-xl-multivcpu 1 build-check(1) blocked n/a test-amd64-amd64-xl 1 build-check(1) blocked n/a test-amd64-amd64-xl-credit1 1 build-check(1) blocked n/a test-amd64-amd64-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-arndale 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-intel 1 build-check(1) blocked n/a test-amd64-i386-xl 1 build-check(1) blocked n/a test-amd64-i386-xl-pvshim 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a version targeted for testing: qemuu aa96ab7c9df59c615ca82b49c9062819e0a1c287 baseline version: qemuu 0ab12aa32462817f0a53fa6f6ce4baf664ef1713 Last test of basis 175623 2023-01-07 23:09:00 Z 2 days Failing since 175627 2023-01-08 14:40:14 Z 2 days 10 attempts Testing same since 175654 2023-01-09 18:08:58 Z 0 days 5 attempts ------------------------------------------------------------ People who touched revisions under test: Ard Biesheuvel Bernhard Beschow Christian Borntraeger Cindy Lu Dongli Zhang Eugenio Pérez Greg Kurz Guoyi Tu Hyman Huang(黄勇) Igor Mammedov Jason Wang Jonathan Cameron Kai Huang Laszlo Ersek Lei Xiang leixiang Liuxiangdong Longpeng Lubomir Rintel Marc-André Lureau Markus Armbruster Michael S. Tsirkin Nikita Ivanov Paolo Bonzini Peter Maydell Philippe Mathieu-Daudé Richard Henderson Thomas Huth Yanan Wang Yicong Yang Zeng Chi jobs: build-amd64-xsm fail build-arm64-xsm fail build-i386-xsm fail build-amd64 fail build-arm64 fail build-armhf fail build-i386 fail build-amd64-libvirt blocked build-arm64-libvirt blocked build-armhf-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl blocked test-amd64-coresched-amd64-xl blocked test-arm64-arm64-xl blocked test-armhf-armhf-xl blocked test-amd64-i386-xl blocked test-amd64-coresched-i386-xl blocked test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm blocked test-amd64-i386-xl-qemuu-debianhvm-i386-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm blocked test-arm64-arm64-xl-xsm blocked test-amd64-i386-xl-xsm blocked test-amd64-amd64-qemuu-nested-amd blocked test-amd64-amd64-xl-pvhv2-amd blocked test-amd64-i386-qemuu-rhel6hvm-amd blocked test-amd64-amd64-dom0pvh-xl-amd blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64 blocked test-amd64-i386-xl-qemuu-debianhvm-amd64 blocked test-amd64-i386-freebsd10-amd64 blocked test-amd64-amd64-qemuu-freebsd11-amd64 blocked test-amd64-amd64-qemuu-freebsd12-amd64 blocked test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked test-amd64-amd64-xl-qemuu-win7-amd64 blocked test-amd64-i386-xl-qemuu-win7-amd64 blocked test-amd64-amd64-xl-qemuu-ws16-amd64 blocked test-amd64-i386-xl-qemuu-ws16-amd64 blocked test-armhf-armhf-xl-arndale blocked test-amd64-amd64-xl-credit1 blocked test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 blocked test-amd64-amd64-xl-credit2 blocked test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 blocked test-armhf-armhf-xl-cubietruck blocked test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict blocked test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict blocked test-amd64-i386-freebsd10-i386 blocked test-amd64-amd64-qemuu-nested-intel blocked test-amd64-amd64-xl-pvhv2-intel blocked test-amd64-i386-qemuu-rhel6hvm-intel blocked test-amd64-amd64-dom0pvh-xl-intel blocked test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu blocked test-armhf-armhf-xl-multivcpu blocked test-amd64-amd64-pair blocked test-amd64-i386-pair blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim blocked test-amd64-i386-xl-pvshim blocked test-amd64-amd64-pygrub blocked test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds blocked test-armhf-armhf-xl-rtds blocked test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow blocked test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow blocked test-amd64-amd64-xl-shadow blocked test-amd64-i386-xl-shadow blocked test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd blocked test-amd64-i386-xl-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2556 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Jan 10 15:18:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 15:18:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474745.736090 (Exim 4.92) (envelope-from ) id 1pFGOA-00063d-WD; Tue, 10 Jan 2023 15:18:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474745.736090; Tue, 10 Jan 2023 15:18:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFGOA-00062R-OB; Tue, 10 Jan 2023 15:18:10 +0000 Received: by outflank-mailman (input) for mailman id 474745; Tue, 10 Jan 2023 15:18:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFGO9-0005G6-6Y for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 15:18:09 +0000 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [2a00:1450:4864:20::12e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fcf25e3e-90f9-11ed-91b6-6bf2151ebd3b; Tue, 10 Jan 2023 16:18:08 +0100 (CET) Received: by mail-lf1-x12e.google.com with SMTP id cf42so18983025lfb.1 for ; Tue, 10 Jan 2023 07:18:08 -0800 (PST) Received: from fedora.. ([195.234.76.149]) by smtp.gmail.com with ESMTPSA id y19-20020a0565123f1300b00498fc3d4cfdsm2203396lfa.189.2023.01.10.07.18.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jan 2023 07:18:07 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fcf25e3e-90f9-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TVqSKi3nBOpTA6dXyBr5PLcPAxdksP3ri3d2O1B85MY=; b=e2u5zuLmD7mk4FxQARC1xRPXgyKyXnF3t4Yk95+zbf8PkkCQhdV7QU9z0YjZZsD6qI cmAw/MNs2iw1wZEbQjHLjeNOigxMPX6cmixeVIZaCwIHK51wKDb5nvrDcObYubWFzD+c S6Sz7Fw8ztE40Cb7wBCn1cyN9Tx72k28cD1nISynFxkcqfn4Dd87EuQkZavg0ihrrxKO ue29Tp3yoyJFBy4tf8D8kG02PwjrGx1CWtqcelIw+lqiZ0WQj1vSq9WBFKJJ6IJxDFin W7tiSBtmRyADQyhuTHq+BjTYMVQXlVtQdIoKUC6vyp7pzUrLAwgT/GusaQNxQLwX1nxD m7+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TVqSKi3nBOpTA6dXyBr5PLcPAxdksP3ri3d2O1B85MY=; b=JCDwHbqrIfGjLo9FFcjyizeL3hFM3uyD34c+yAM/aCRpfGVo0iQpYh4Nwu+D7dYSYJ T8+l61DkQY7+Cnu8yIITv69qnVH+b8/dAX2iELTOqz3nMJX4Mf7nAoKm4/kAKbFIlG+m lkLnnl4npQg/B5Y5cb8tpzd4HF319z1T6LICFumeKaml5EhIM0laadYMhlnA+/wdKpgG Cu6lj8cK62hF8aqY4tpqvX6AFhZuys+66/8Xo/+1vPoIkI5VeuvHg6ahKFIGsUf3LPft LmTufIJR8RHIjzUTeLyoRI+vG3TEBvH/T+3c4hl5+LVhqfghIpevS5Q9O5qTVJg6yZ9b 2lSQ== X-Gm-Message-State: AFqh2kpIBfUlN8e0soFnwZICXrL4Z3XMY2aKlAw9ant4ErMWM9/2CEN1 uUg1URpynkBpDLitIoyrGUFUdUwGM+6FGP12 X-Google-Smtp-Source: AMrXdXvEEnHVFscJyoj3h6ACK+mgIxiDwomDke1B0mbazKc+zfgoTaWIWDhMTSP1SuM7C7x5V83Fkw== X-Received: by 2002:a05:6512:3d11:b0:4b5:2ef3:fd2a with SMTP id d17-20020a0565123d1100b004b52ef3fd2amr32153648lfv.47.1673363887859; Tue, 10 Jan 2023 07:18:07 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bobby Eshleman , Bob Eshleman , Alistair Francis , Connor Davis , Oleksii Kurochko Subject: [PATCH v3 4/6] xen/riscv: introduce sbi call to putchar to console Date: Tue, 10 Jan 2023 17:17:57 +0200 Message-Id: X-Mailer: git-send-email 2.38.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Bobby Eshleman Originally SBI implementation for Xen was introduced by Bobby Eshleman but it was removed all the stuff for simplicity except SBI call for putting character to console. The patch introduces sbi_putchar() SBI call which is necessary to implement initial early_printk. Signed-off-by: Bobby Eshleman Signed-off-by: Oleksii Kurochko --- Changes in V3: - update copyright's year - rename define __CPU_SBI_H__ to __ASM_RISCV_SBI_H__ - fix identations - change an author of the commit --- Changes in V2: - add an explanatory comment about sbi_console_putchar() function. - order the files alphabetically in Makefile --- xen/arch/riscv/Makefile | 1 + xen/arch/riscv/include/asm/sbi.h | 34 ++++++++++++++++++++++++ xen/arch/riscv/sbi.c | 45 ++++++++++++++++++++++++++++++++ 3 files changed, 80 insertions(+) create mode 100644 xen/arch/riscv/include/asm/sbi.h create mode 100644 xen/arch/riscv/sbi.c diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile index 5a67a3f493..fd916e1004 100644 --- a/xen/arch/riscv/Makefile +++ b/xen/arch/riscv/Makefile @@ -1,4 +1,5 @@ obj-$(CONFIG_RISCV_64) += riscv64/ +obj-y += sbi.o obj-y += setup.o $(TARGET): $(TARGET)-syms diff --git a/xen/arch/riscv/include/asm/sbi.h b/xen/arch/riscv/include/asm/sbi.h new file mode 100644 index 0000000000..0e6820a4ed --- /dev/null +++ b/xen/arch/riscv/include/asm/sbi.h @@ -0,0 +1,34 @@ +/* SPDX-License-Identifier: (GPL-2.0-or-later) */ +/* + * Copyright (c) 2021-2023 Vates SAS. + * + * Taken from xvisor, modified by Bobby Eshleman (bobby.eshleman@gmail.com). + * + * Taken/modified from Xvisor project with the following copyright: + * + * Copyright (c) 2019 Western Digital Corporation or its affiliates. + */ + +#ifndef __ASM_RISCV_SBI_H__ +#define __ASM_RISCV_SBI_H__ + +#define SBI_EXT_0_1_CONSOLE_PUTCHAR 0x1 + +struct sbiret { + long error; + long value; +}; + +struct sbiret sbi_ecall(unsigned long ext, unsigned long fid, + unsigned long arg0, unsigned long arg1, + unsigned long arg2, unsigned long arg3, + unsigned long arg4, unsigned long arg5); + +/** + * Writes given character to the console device. + * + * @param ch The data to be written to the console. + */ +void sbi_console_putchar(int ch); + +#endif /* __ASM_RISCV_SBI_H__ */ diff --git a/xen/arch/riscv/sbi.c b/xen/arch/riscv/sbi.c new file mode 100644 index 0000000000..dc0eb44bc6 --- /dev/null +++ b/xen/arch/riscv/sbi.c @@ -0,0 +1,45 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* + * Taken and modified from the xvisor project with the copyright Copyright (c) + * 2019 Western Digital Corporation or its affiliates and author Anup Patel + * (anup.patel@wdc.com). + * + * Modified by Bobby Eshleman (bobby.eshleman@gmail.com). + * + * Copyright (c) 2019 Western Digital Corporation or its affiliates. + * Copyright (c) 2021-2023 Vates SAS. + */ + +#include +#include + +struct sbiret sbi_ecall(unsigned long ext, unsigned long fid, + unsigned long arg0, unsigned long arg1, + unsigned long arg2, unsigned long arg3, + unsigned long arg4, unsigned long arg5) +{ + struct sbiret ret; + + register unsigned long a0 asm ("a0") = arg0; + register unsigned long a1 asm ("a1") = arg1; + register unsigned long a2 asm ("a2") = arg2; + register unsigned long a3 asm ("a3") = arg3; + register unsigned long a4 asm ("a4") = arg4; + register unsigned long a5 asm ("a5") = arg5; + register unsigned long a6 asm ("a6") = fid; + register unsigned long a7 asm ("a7") = ext; + + asm volatile ("ecall" + : "+r" (a0), "+r" (a1) + : "r" (a2), "r" (a3), "r" (a4), "r" (a5), "r" (a6), "r" (a7) + : "memory"); + ret.error = a0; + ret.value = a1; + + return ret; +} + +void sbi_console_putchar(int ch) +{ + sbi_ecall(SBI_EXT_0_1_CONSOLE_PUTCHAR, 0, ch, 0, 0, 0, 0, 0); +} -- 2.38.1 From xen-devel-bounces@lists.xenproject.org Tue Jan 10 15:18:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 15:18:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474746.736096 (Exim 4.92) (envelope-from ) id 1pFGOB-00068P-Ap; Tue, 10 Jan 2023 15:18:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474746.736096; Tue, 10 Jan 2023 15:18:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFGOB-00065E-0t; Tue, 10 Jan 2023 15:18:11 +0000 Received: by outflank-mailman (input) for mailman id 474746; Tue, 10 Jan 2023 15:18:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFGOA-0005G6-AI for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 15:18:10 +0000 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [2a00:1450:4864:20::134]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fd9ff4e1-90f9-11ed-91b6-6bf2151ebd3b; Tue, 10 Jan 2023 16:18:09 +0100 (CET) Received: by mail-lf1-x134.google.com with SMTP id v25so18922394lfe.12 for ; Tue, 10 Jan 2023 07:18:09 -0800 (PST) Received: from fedora.. ([195.234.76.149]) by smtp.gmail.com with ESMTPSA id y19-20020a0565123f1300b00498fc3d4cfdsm2203396lfa.189.2023.01.10.07.18.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jan 2023 07:18:08 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fd9ff4e1-90f9-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+4b0mCw5TWzzOfe9k1UrEZyIfTtwrFP3j0Uq+Wi1atU=; b=XvQ0/I+z48juzNDTq8nzooq2ZPekH2xUSqZvlbohxfYhFJZ81wYOyb19SIA/idZOET 1LSYl7gVq2SJgJDIeDVMmj8OLR6bvModgWrPzFBBngFOChV4+SYXxO9/gxkKwm2EUikJ 6seJ1954bJ4UVpnCtNHN2g3te/FnsdUEgj92ZKZNWevHNUqWgTOrErEybjqAVHdDkoLg cy6MKyKYXyEsEChdUziQU2BxLcb1JXg+nnb6WWP7Ryh4veGy2x00te/wwlWrUhREEcG6 JkJKI/ceOiTsKHPaG68MNGuHGhZ6o4ZTrfXwWbqiD1NNnfrV7hP9e148/5puEI9xrj7q ot3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+4b0mCw5TWzzOfe9k1UrEZyIfTtwrFP3j0Uq+Wi1atU=; b=GPBQlco/ktccUHrALcHrWZC8Q81cWryEH0oKPRgTqzbo5pLOlamJTM1CpHX5B5v6o9 CFjF6cw+efEn0Qw4oWxnZSQfo4e0n36/3TXjgaXicnhezlXDvqgjFJGo9Jrsz3x3qRFr mx7V5AeQDSXdr8ZaFAji02DMiokFIYD+EAOuiimZdGL/eN8U1vDL5OyVlAghlNkYIwer QwSJhXD4ukQuurrttGeq3eDHfbSatqcqWSxGVQO3u05otvwXLzqfXh5DVf7KZCYQOYAW 3UgoXqsOZrOEqypvfPv69HP0XSn730OD/P9sp0rRSwVY4VswQB5nkBKd+zdsPnes5vzX Bdhw== X-Gm-Message-State: AFqh2koRSiNbEksNL8Fon5RkYz5lwU3fA0EIP+m0SLzFbqaoZCv32KKH tdJ7W3WLcmwgRy9S0UOyFz+tgdCtwnYUU6cG X-Google-Smtp-Source: AMrXdXsaqM3PTnIRlw1RNlmG8XdcZtW5YW9PgDIR2zm2mvrS1lTxNUQV4v/ttVeXp1U7869rBWk4Yw== X-Received: by 2002:a05:6512:3d94:b0:4a4:68b8:f4f4 with SMTP id k20-20020a0565123d9400b004a468b8f4f4mr24770124lfv.58.1673363889023; Tue, 10 Jan 2023 07:18:09 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bobby Eshleman , Bob Eshleman , Alistair Francis , Connor Davis , Oleksii Kurochko Subject: [PATCH v3 5/6] xen/riscv: introduce early_printk basic stuff Date: Tue, 10 Jan 2023 17:17:58 +0200 Message-Id: <25cd3586fa51980279f25a82eed5ded1622bc212.1673362493.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Bobby Eshleman The patch introduces a basic stuff of early_printk functionality which will be enough to print 'hello from C environment". early_printk() function was changed in comparison with original as common isn't being built now so there is no vscnprintf. Because printk() relies on a serial driver (like the ns16550 driver) and drivers require working virtual memory (ioremap()) there is not print functionality early in Xen boot. This commit adds early printk implementation built on the putc SBI call. As sbi_console_putchar() is being already planned for deprecation it is used temporary now and will be removed or reworked after real uart will be ready. Signed-off-by: Bobby Eshleman Signed-off-by: Oleksii Kurochko --- Changes in V3: - reorder "include
" in erly_printk.c - change an author of the commit --- Changes in V2: - add license to early_printk.c - add signed-off-by Bobby - add RISCV_32 to Kconfig.debug to EARLY_PRINTK config - update commit message - order the files alphabetically in Makefile --- xen/arch/riscv/Kconfig.debug | 7 +++++ xen/arch/riscv/Makefile | 1 + xen/arch/riscv/early_printk.c | 33 +++++++++++++++++++++++ xen/arch/riscv/include/asm/early_printk.h | 12 +++++++++ xen/arch/riscv/setup.c | 4 +++ 5 files changed, 57 insertions(+) create mode 100644 xen/arch/riscv/early_printk.c create mode 100644 xen/arch/riscv/include/asm/early_printk.h diff --git a/xen/arch/riscv/Kconfig.debug b/xen/arch/riscv/Kconfig.debug index e69de29bb2..e21649781d 100644 --- a/xen/arch/riscv/Kconfig.debug +++ b/xen/arch/riscv/Kconfig.debug @@ -0,0 +1,7 @@ +config EARLY_PRINTK + bool "Enable early printk" + default DEBUG + depends on RISCV_64 || RISCV_32 + help + + Enables early printk debug messages diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile index fd916e1004..1a4f1a6015 100644 --- a/xen/arch/riscv/Makefile +++ b/xen/arch/riscv/Makefile @@ -1,3 +1,4 @@ +obj-$(CONFIG_EARLY_PRINTK) += early_printk.o obj-$(CONFIG_RISCV_64) += riscv64/ obj-y += sbi.o obj-y += setup.o diff --git a/xen/arch/riscv/early_printk.c b/xen/arch/riscv/early_printk.c new file mode 100644 index 0000000000..348c21bdaa --- /dev/null +++ b/xen/arch/riscv/early_printk.c @@ -0,0 +1,33 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * RISC-V early printk using SBI + * + * Copyright (C) 2021 Bobby Eshleman + */ +#include +#include + +/* + * TODO: + * sbi_console_putchar is already planned for deprecation + * so it should be reworked to use UART directly. +*/ +void early_puts(const char *s, size_t nr) +{ + while ( nr-- > 0 ) + { + if (*s == '\n') + sbi_console_putchar('\r'); + sbi_console_putchar(*s); + s++; + } +} + +void early_printk(const char *str) +{ + while (*str) + { + early_puts(str, 1); + str++; + } +} diff --git a/xen/arch/riscv/include/asm/early_printk.h b/xen/arch/riscv/include/asm/early_printk.h new file mode 100644 index 0000000000..05106e160d --- /dev/null +++ b/xen/arch/riscv/include/asm/early_printk.h @@ -0,0 +1,12 @@ +#ifndef __EARLY_PRINTK_H__ +#define __EARLY_PRINTK_H__ + +#include + +#ifdef CONFIG_EARLY_PRINTK +void early_printk(const char *str); +#else +static inline void early_printk(const char *s) {}; +#endif + +#endif /* __EARLY_PRINTK_H__ */ diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c index 13e24e2fe1..d09ffe1454 100644 --- a/xen/arch/riscv/setup.c +++ b/xen/arch/riscv/setup.c @@ -1,12 +1,16 @@ #include #include +#include + /* Xen stack for bringing up the first CPU. */ unsigned char __initdata cpu0_boot_stack[STACK_SIZE] __aligned(STACK_SIZE); void __init noreturn start_xen(void) { + early_printk("Hello from C env\n"); + for ( ;; ) asm volatile ("wfi"); -- 2.38.1 From xen-devel-bounces@lists.xenproject.org Tue Jan 10 15:18:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 15:18:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474741.736051 (Exim 4.92) (envelope-from ) id 1pFGO8-0005GS-H5; Tue, 10 Jan 2023 15:18:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474741.736051; Tue, 10 Jan 2023 15:18:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFGO8-0005GE-EP; Tue, 10 Jan 2023 15:18:08 +0000 Received: by outflank-mailman (input) for mailman id 474741; Tue, 10 Jan 2023 15:18:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFGO6-0005Fu-Jq for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 15:18:06 +0000 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [2a00:1450:4864:20::12c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fa8d639d-90f9-11ed-b8d0-410ff93cb8f0; Tue, 10 Jan 2023 16:18:04 +0100 (CET) Received: by mail-lf1-x12c.google.com with SMTP id m6so18936872lfj.11 for ; Tue, 10 Jan 2023 07:18:04 -0800 (PST) Received: from fedora.. ([195.234.76.149]) by smtp.gmail.com with ESMTPSA id y19-20020a0565123f1300b00498fc3d4cfdsm2203396lfa.189.2023.01.10.07.18.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jan 2023 07:18:03 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fa8d639d-90f9-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=YBsjKUp8Q0MJVa4U8jLERfOVLa8Dy11fP2YftT+HK8o=; b=kq/zQiOkycbQd2vJsbKmXLcsas+LrxbnyQrtti3+ZDmfMEZMkEWAGYSZN8yPXmTKUZ AQQ3E36PmaXQWHSzjpKqRaplR2iVAw8JkJHRnjXhnt3glv1pX4SltIBZJuTO3hMNHBu8 bmOpy0E5keYh74mqjJzuiPVZA5elE1E9ToloXjt+VJt21ax86XZDbIaDp0aHp+VXtuHK uEW7GaGMn9maChekZ4CvlXtFl34uEQ+iwRdhFuwJScWBUws6219KwhImILBu2HLTRnVy 8g3KoGY7M77bUEO/f+WuHcelqExclqk+++fylbW3z8LOyZ+faIcLbrKmkXvzZH7/TdcE rKRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YBsjKUp8Q0MJVa4U8jLERfOVLa8Dy11fP2YftT+HK8o=; b=22Lhz3XcryslhVXCJq4dBhyTMw/aqyZHvZLgvaxCOWC1oX/WndsbNH9XVl26Am6oln mOeJtqIZzZNfJWWe6txm1PIB25ibMCsWJP3WXzS7XVSlSFFF+/uIqDmv8JtgDEA7dPBE obel0aLcjQd1hZaScx9FEYCwY8CLp34wTHoiPOCqTIq0zyacy7JZfTpTJTybU112v+qt K3lVZ7e5P3MKPpPBSZwX08cuSF7h0nX+ENR/K8XdqhIIFa2FZnRzGe1ZMoQgzSDCZnPf v6tWxnIzEnRtiWol6IB/e1jazLJKPoQTmlOX3733o+nMNLPLZs9DJEycKkwihAJKmLhi kSOA== X-Gm-Message-State: AFqh2kpLC8W/hB0p2AOvMin+xSJLt+k7el6GXv13O+3DJ40okQJLThvw PggheFIa3lv6iWDkuy7bj3kzNi6WgKUS3GNn X-Google-Smtp-Source: AMrXdXvXpC0EKi01o6/2pO961wMBIghk3H0JjKUb10Q2NykRSL8BarfmO5dt1oElN7Azs6RW7MuXTg== X-Received: by 2002:ac2:4ac3:0:b0:4b5:7e4c:dcea with SMTP id m3-20020ac24ac3000000b004b57e4cdceamr23303366lfp.51.1673363883688; Tue, 10 Jan 2023 07:18:03 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis , Doug Goldstein Subject: [PATCH v3 0/6] Basic early_printk and smoke test implementation Date: Tue, 10 Jan 2023 17:17:53 +0200 Message-Id: X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The patch series introduces the following: - the minimal set of headers and changes inside them. - SBI (RISC-V Supervisor Binary Interface) things necessary for basic early_printk implementation. - things needed to set up the stack. - early_printk() function to print only strings. - RISC-V smoke test which checks if "Hello from C env" message is present in serial.tmp --- Changes in V3: - Most of "[PATCH v2 7/8] xen/riscv: print hello message from C env" was merged with [PATCH v2 3/6] xen/riscv: introduce stack stuff. - "[PATCH v2 7/8] xen/riscv: print hello message from C env" was merged with "[PATCH v2 6/8] xen/riscv: introduce early_printk basic stuff". - "[PATCH v2 5/8] xen/include: include in " was removed as it has been already merged to mainline staging. - code style fixes. --- Changes in V2: - update commit patches commit messages according to the mailing list comments - Remove unneeded types in - Introduce definition of STACK_SIZE - order the files alphabetically in Makefile - Add license to early_printk.c - Add RISCV_32 dependecy to config EARLY_PRINTK in Kconfig.debug - Move dockerfile changes to separate config and sent them as separate patch to mailing list. - Update test.yaml to wire up smoke test --- Bobby Eshleman (2): xen/riscv: introduce sbi call to putchar to console xen/riscv: introduce early_printk basic stuff Oleksii Kurochko (4): xen/riscv: introduce dummy asm/init.h xen/riscv: introduce asm/types.h header file xen/riscv: introduce stack stuff automation: add RISC-V smoke test automation/gitlab-ci/test.yaml | 20 ++++++++++ automation/scripts/qemu-smoke-riscv64.sh | 20 ++++++++++ xen/arch/riscv/Kconfig.debug | 7 ++++ xen/arch/riscv/Makefile | 3 ++ xen/arch/riscv/early_printk.c | 33 +++++++++++++++++ xen/arch/riscv/include/asm/config.h | 2 + xen/arch/riscv/include/asm/early_printk.h | 12 ++++++ xen/arch/riscv/include/asm/init.h | 12 ++++++ xen/arch/riscv/include/asm/sbi.h | 34 +++++++++++++++++ xen/arch/riscv/include/asm/types.h | 22 +++++++++++ xen/arch/riscv/riscv64/head.S | 6 ++- xen/arch/riscv/sbi.c | 45 +++++++++++++++++++++++ xen/arch/riscv/setup.c | 18 +++++++++ 13 files changed, 233 insertions(+), 1 deletion(-) create mode 100755 automation/scripts/qemu-smoke-riscv64.sh create mode 100644 xen/arch/riscv/early_printk.c create mode 100644 xen/arch/riscv/include/asm/early_printk.h create mode 100644 xen/arch/riscv/include/asm/init.h create mode 100644 xen/arch/riscv/include/asm/sbi.h create mode 100644 xen/arch/riscv/include/asm/types.h create mode 100644 xen/arch/riscv/sbi.c create mode 100644 xen/arch/riscv/setup.c -- 2.38.1 From xen-devel-bounces@lists.xenproject.org Tue Jan 10 15:18:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 15:18:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474742.736059 (Exim 4.92) (envelope-from ) id 1pFGO9-0005PR-0L; Tue, 10 Jan 2023 15:18:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474742.736059; Tue, 10 Jan 2023 15:18:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFGO8-0005Nl-Rl; Tue, 10 Jan 2023 15:18:08 +0000 Received: by outflank-mailman (input) for mailman id 474742; Tue, 10 Jan 2023 15:18:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFGO7-0005Fu-CE for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 15:18:07 +0000 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [2a00:1450:4864:20::135]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fb20730a-90f9-11ed-b8d0-410ff93cb8f0; Tue, 10 Jan 2023 16:18:05 +0100 (CET) Received: by mail-lf1-x135.google.com with SMTP id g13so18965052lfv.7 for ; Tue, 10 Jan 2023 07:18:05 -0800 (PST) Received: from fedora.. ([195.234.76.149]) by smtp.gmail.com with ESMTPSA id y19-20020a0565123f1300b00498fc3d4cfdsm2203396lfa.189.2023.01.10.07.18.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jan 2023 07:18:04 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fb20730a-90f9-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=u7sI+87rn5yOEodXtae6iqX6/XNkgcCetji6u3zffsM=; b=Wcd+e1vaZ7jCFWNGH/6ZmgG8lMqmO5xhPnKN3ktZfI/PnHoeOzqYtwbZUeK5YQQekf Bz4qNhSrO8EAwQih9+bzTsTAVeEmzIC9aVW4edgZNrLDVMu5nsQTnoi0MnDdYo4QpgwM IKV1zFPVZdfctGAafPDgpzEQrwSkQmMWNIpSk6PBpVShrD1B2JcgLwdidmx2wR0h16yr tceSmVuJcbWls4L16BoDbD9tsqkZHI986vyx2Q6P7KpHproyAV6Wj94ndIQ9M6qu+ZWQ tvNQiQutSpyc4deTvrAn5PGz1eJCn7JOjyJREbamG7WbXx9E+ZdhpH6eNaoNl8LwKgqu 8INw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=u7sI+87rn5yOEodXtae6iqX6/XNkgcCetji6u3zffsM=; b=8J26y+XR2RHbK1gRxuPFHR2TgJKmYXmDqFmcwumAEraL4wnPTAWgL/9s/kuyvOtD7y cLztmqosxfjQnAsUdXhguB6+aYkA7qXYlRtKSvS3bFfn/3cZ4KGdlYT+bx0scig6m7zf hMeQF8y3WcXZylhnmgw2euRh7YWXJ+1+6l9egbtsfoVC01B/nsW850UyRUhGhnoTWWeG rpOlaf4mgZ1Y6uyHA58S4faly8+DkimGsPH+gRXRsQal6es5CuFg9SsXhFPhPS8MXOWf NgA/h1LYYMKwXK10muIjFt6/Eark+a3oRHDUf9wEubHexqklYRS5j4l+FmIDwj+llebW Oo/Q== X-Gm-Message-State: AFqh2krfKYRRxYMRYmDfuj+9qLKMkonAQX/FwCk7nWU2UFLEinn9T/pM ABpjwf2URQvqmbEDpnwVcdJr6UTjJTLKUEUq X-Google-Smtp-Source: AMrXdXu6J6iJ2CHmwuWTqgPYwkvNGDt8B1Nj6qG/RDyMjRIDl6ZmqknoP7CuZmRNXuvTQOHUt8Aeqw== X-Received: by 2002:a05:6512:b27:b0:4b6:eaed:f18f with SMTP id w39-20020a0565120b2700b004b6eaedf18fmr21721242lfu.38.1673363884715; Tue, 10 Jan 2023 07:18:04 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH v3 1/6] xen/riscv: introduce dummy asm/init.h Date: Tue, 10 Jan 2023 17:17:54 +0200 Message-Id: X-Mailer: git-send-email 2.38.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The following patches require which includes Signed-off-by: Oleksii Kurochko --- Changes in V3: - Nothing changed --- Changes in V2: - Add explanation comment to the comment message --- xen/arch/riscv/include/asm/init.h | 12 ++++++++++++ 1 file changed, 12 insertions(+) create mode 100644 xen/arch/riscv/include/asm/init.h diff --git a/xen/arch/riscv/include/asm/init.h b/xen/arch/riscv/include/asm/init.h new file mode 100644 index 0000000000..237ec25e4e --- /dev/null +++ b/xen/arch/riscv/include/asm/init.h @@ -0,0 +1,12 @@ +#ifndef _XEN_ASM_INIT_H +#define _XEN_ASM_INIT_H + +#endif /* _XEN_ASM_INIT_H */ +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ -- 2.38.1 From xen-devel-bounces@lists.xenproject.org Tue Jan 10 15:18:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 15:18:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474744.736085 (Exim 4.92) (envelope-from ) id 1pFGOA-0005zt-Kw; Tue, 10 Jan 2023 15:18:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474744.736085; Tue, 10 Jan 2023 15:18:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFGOA-0005z7-Fu; Tue, 10 Jan 2023 15:18:10 +0000 Received: by outflank-mailman (input) for mailman id 474744; Tue, 10 Jan 2023 15:18:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFGO8-0005G6-L7 for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 15:18:08 +0000 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [2a00:1450:4864:20::131]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fc4704db-90f9-11ed-91b6-6bf2151ebd3b; Tue, 10 Jan 2023 16:18:07 +0100 (CET) Received: by mail-lf1-x131.google.com with SMTP id bt23so18918759lfb.5 for ; Tue, 10 Jan 2023 07:18:07 -0800 (PST) Received: from fedora.. ([195.234.76.149]) by smtp.gmail.com with ESMTPSA id y19-20020a0565123f1300b00498fc3d4cfdsm2203396lfa.189.2023.01.10.07.18.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jan 2023 07:18:06 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fc4704db-90f9-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=k39j5USYdhYFET9upYnjISkYGgRbZovPpm53v/syNJU=; b=K0+5gplvcbHPCg9qsE3dFmBBiOcnrjo7e6fXQMSMTGWGGAkkmvAC0kMBUKdVS2/g/U odrC33pI1EF18bSUdwqhQKOffPEh/O4yIR5P8EOrxbxTeK/jDhC8EqSvgqu6kuQaeke5 14M5BY4Pmc4xSv3ceefcgEzduhQHIbbd9E7WXat//1mle4drpoRcN9dj3077OkcNEQPo 6fYJyXpFSwlGVYBmZLNwdLk6u9Pzlr0YpLMtwxwQOjvBqI+HkfJ8Q9oFx1gH/PFUqRwP xhYSl/sWvt8fli6ksgToIm3RPkCvqF47ovfn/wqXcCfP0GQjsHG2UwzEWzxmH1orYIRo EnLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k39j5USYdhYFET9upYnjISkYGgRbZovPpm53v/syNJU=; b=mP7fzz2MW/qWLlpjwZjRhZhmXMWDprpLQehnlXc6czbdVBoRnO0DRGlyhPe+BjbuVj 0F6LUDUWb8wCFX6sN/dVeQtbPWrvnHqTm5RgAg/MvJjzA0TWJjQGks7hys6vU9AVIGam JLVrEvFvB8POwgOp0u8hJcA7i7oT/uhLRPlcH3q/zjNhGYxDhs6j2Nqi/p37Quncp7Bh +pa9Z3NeO0qt5M/jQyXKC4rd88DKRmTD/MrWDs/db+fSzaKHXemT793NQXIATUmIdu23 Fh04BPUtyaLxEFDcVKL5JezKk2GA5VvjSDeU8hRrNtVwlOmEAws63jY1xbRUPa8dQPQC LmqA== X-Gm-Message-State: AFqh2ko2X7k5DRI2zeWRRpebcawh/xYKCrVRhzaWfnpX/Sq/V9jNdnBY x5Szv3+MhWSjrjWFnpErV1kStT/gxmThqIFU X-Google-Smtp-Source: AMrXdXv0v/qAB6MI2pI2Ns3onWDvlHjYdHBeV1ydTInGa27X5jo6bnrF+YFaC+5dYBGgv/vaRENlvA== X-Received: by 2002:ac2:446b:0:b0:4b5:8504:feea with SMTP id y11-20020ac2446b000000b004b58504feeamr16675149lfl.24.1673363886777; Tue, 10 Jan 2023 07:18:06 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH v3 3/6] xen/riscv: introduce stack stuff Date: Tue, 10 Jan 2023 17:17:56 +0200 Message-Id: <7d89e3811e6ea4f307862d6552ad7c7e58176518.1673362493.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The patch introduces and sets up a stack in order to go to C environment Signed-off-by: Oleksii Kurochko --- Changes in V3: - reorder headers in alphabetical order - merge changes related to start_xen() function from "[PATCH v2 7/8] xen/riscv: print hello message from C env" to this patch - remove unneeded parentheses in definition of STACK_SIZE --- Changes in V2: - introduce STACK_SIZE define. - use consistent padding between instruction mnemonic and operand(s) --- xen/arch/riscv/Makefile | 1 + xen/arch/riscv/include/asm/config.h | 2 ++ xen/arch/riscv/riscv64/head.S | 6 +++++- xen/arch/riscv/setup.c | 14 ++++++++++++++ 4 files changed, 22 insertions(+), 1 deletion(-) create mode 100644 xen/arch/riscv/setup.c diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile index 248f2cbb3e..5a67a3f493 100644 --- a/xen/arch/riscv/Makefile +++ b/xen/arch/riscv/Makefile @@ -1,4 +1,5 @@ obj-$(CONFIG_RISCV_64) += riscv64/ +obj-y += setup.o $(TARGET): $(TARGET)-syms $(OBJCOPY) -O binary -S $< $@ diff --git a/xen/arch/riscv/include/asm/config.h b/xen/arch/riscv/include/asm/config.h index 0370f865f3..763a922a04 100644 --- a/xen/arch/riscv/include/asm/config.h +++ b/xen/arch/riscv/include/asm/config.h @@ -43,6 +43,8 @@ #define SMP_CACHE_BYTES (1 << 6) +#define STACK_SIZE PAGE_SIZE + #endif /* __RISCV_CONFIG_H__ */ /* * Local variables: diff --git a/xen/arch/riscv/riscv64/head.S b/xen/arch/riscv/riscv64/head.S index 990edb70a0..d444dd8aad 100644 --- a/xen/arch/riscv/riscv64/head.S +++ b/xen/arch/riscv/riscv64/head.S @@ -1,4 +1,8 @@ .section .text.header, "ax", %progbits ENTRY(start) - j start + la sp, cpu0_boot_stack + li t0, STACK_SIZE + add sp, sp, t0 + + tail start_xen diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c new file mode 100644 index 0000000000..13e24e2fe1 --- /dev/null +++ b/xen/arch/riscv/setup.c @@ -0,0 +1,14 @@ +#include +#include + +/* Xen stack for bringing up the first CPU. */ +unsigned char __initdata cpu0_boot_stack[STACK_SIZE] + __aligned(STACK_SIZE); + +void __init noreturn start_xen(void) +{ + for ( ;; ) + asm volatile ("wfi"); + + unreachable(); +} -- 2.38.1 From xen-devel-bounces@lists.xenproject.org Tue Jan 10 15:18:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 15:18:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474743.736064 (Exim 4.92) (envelope-from ) id 1pFGO9-0005Re-7W; Tue, 10 Jan 2023 15:18:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474743.736064; Tue, 10 Jan 2023 15:18:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFGO9-0005Qw-2b; Tue, 10 Jan 2023 15:18:09 +0000 Received: by outflank-mailman (input) for mailman id 474743; Tue, 10 Jan 2023 15:18:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFGO8-0005Fu-CU for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 15:18:08 +0000 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [2a00:1450:4864:20::12c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fba76ff9-90f9-11ed-b8d0-410ff93cb8f0; Tue, 10 Jan 2023 16:18:06 +0100 (CET) Received: by mail-lf1-x12c.google.com with SMTP id m6so18937020lfj.11 for ; Tue, 10 Jan 2023 07:18:06 -0800 (PST) Received: from fedora.. ([195.234.76.149]) by smtp.gmail.com with ESMTPSA id y19-20020a0565123f1300b00498fc3d4cfdsm2203396lfa.189.2023.01.10.07.18.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jan 2023 07:18:05 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fba76ff9-90f9-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GDdmAaTmfRPA7/hoydJZPcOqFW6WO2Afa2sA0FosFio=; b=NEM8j9tyoYg5poO13W2TCJj3Us3bcZztoSFaeK51xO9v2vjzt/4x/SAKmRlJDzpp6J wD7Ws/2wnbVb8EYWs1Hn1RE9SPTb/mKzgWwvtZs814huxoBRsBgBvQsrrjxYUAXfzb4t o028CXIN+4Ofa4UM8B6PhJFmnIme18puLhWbYEmOMHbR97mTwtrmkBRIczssJEFhRO2s 0QqzKSA+1r+qYq0W16LsB8Ou0hJ7lkXdjb9dYGdV9QBc319Uzz7TglhmqKn5z8gpc/t1 FQKkFXRiRlWxpcCurzLJxbIkeUxR15z9QtlmUCA1lRKihUMUBoVkGSPyWBhO/oMZWJPw itXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GDdmAaTmfRPA7/hoydJZPcOqFW6WO2Afa2sA0FosFio=; b=bNUBWrFyWg1L0KawxXVYPn8CPmT6v89FiA1Q+1sqgIiuiAt3L7HMhbt+jKJdi4Sn86 YqXRWiWKaFKtJZMXX1P860x+bufJfwq1B/NbtK6knXsOmjhPeIGjYQhq7RXLSsygQIEp b9ypry9Mc9qD1aDS8oRiaCGwsfzR5oH5JvaKCVG2xmjSdPeJQO82c0rVNN6l8kyz0DB5 kFCFLfN78JoZPCSikzyQKn4kfXdzzAoq8noCZe48mHYX0dUDwJS6rKOPzJTmGSvuMFZ3 4jV6euxS900YAQXDjEOIXJYLITbaaWUDi/OefFvWrz+CemExP1xfiozBqDRPwxPpSmHt 1qYQ== X-Gm-Message-State: AFqh2kq7p4NqOS7OPN62x3U7V3r3ob3j6ELD/lC5Irz1iZuTFJIztu6m Mkk71k9451NlZtlWHvOX4h33pwhv5mb6wj6T X-Google-Smtp-Source: AMrXdXvWG7xcUGOUpgh3YFTt+CPFUf7TwcKA+mL7/QGv6LAVJKwcJ5XHoU93PSXd60PvcRq90rS7Bw== X-Received: by 2002:ac2:5dce:0:b0:4b5:b988:b409 with SMTP id x14-20020ac25dce000000b004b5b988b409mr18504737lfq.21.1673363885739; Tue, 10 Jan 2023 07:18:05 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH v3 2/6] xen/riscv: introduce asm/types.h header file Date: Tue, 10 Jan 2023 17:17:55 +0200 Message-Id: X-Mailer: git-send-email 2.38.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Signed-off-by: Oleksii Kurochko --- Changes in V3: - Nothing changed --- Changes in V2: - Remove unneeded now types from --- xen/arch/riscv/include/asm/types.h | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) create mode 100644 xen/arch/riscv/include/asm/types.h diff --git a/xen/arch/riscv/include/asm/types.h b/xen/arch/riscv/include/asm/types.h new file mode 100644 index 0000000000..fbe352ef20 --- /dev/null +++ b/xen/arch/riscv/include/asm/types.h @@ -0,0 +1,22 @@ +#ifndef __RISCV_TYPES_H__ +#define __RISCV_TYPES_H__ + +#ifndef __ASSEMBLY__ + +#if defined(__SIZE_TYPE__) +typedef __SIZE_TYPE__ size_t; +#else +typedef unsigned long size_t; +#endif + +#endif /* __ASSEMBLY__ */ + +#endif /* __RISCV_TYPES_H__ */ +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ -- 2.38.1 From xen-devel-bounces@lists.xenproject.org Tue Jan 10 15:18:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 15:18:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474747.736118 (Exim 4.92) (envelope-from ) id 1pFGOD-0006rO-Oj; Tue, 10 Jan 2023 15:18:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474747.736118; Tue, 10 Jan 2023 15:18:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFGOD-0006qz-KG; Tue, 10 Jan 2023 15:18:13 +0000 Received: by outflank-mailman (input) for mailman id 474747; Tue, 10 Jan 2023 15:18:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFGOB-0005G6-E0 for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 15:18:11 +0000 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [2a00:1450:4864:20::12a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fe5a9a3b-90f9-11ed-91b6-6bf2151ebd3b; Tue, 10 Jan 2023 16:18:10 +0100 (CET) Received: by mail-lf1-x12a.google.com with SMTP id d30so14048152lfv.8 for ; Tue, 10 Jan 2023 07:18:10 -0800 (PST) Received: from fedora.. ([195.234.76.149]) by smtp.gmail.com with ESMTPSA id y19-20020a0565123f1300b00498fc3d4cfdsm2203396lfa.189.2023.01.10.07.18.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jan 2023 07:18:09 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fe5a9a3b-90f9-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0syX+Z8ZsLO1K+qpK4hh/FiHzxvRksi171obTN3jJ5s=; b=Seey/dkCQRMk/iJocB/HBc0GgJnYzseGgxmfJDzEi5gt6+ob6lcNEkTYzUt+FwXLLG qXUCORaM5iafVcoX8VoTRr5loffmCABlS2bqkcTCtW9lt92+CRD8pzuuuDbRMuvo0nqN OFuf+ihwuoohMSMxzc7qjx0pZ7ksSdIjysXs3HvSSHe92nm61P0QwvswqVKUUd4i47Zz 4cTmCmK0ftorLJzQvV2smQgFZfGCyDDBJYE1WLaJB4f9Ps1JnLDSJDbZ99oArjjNwrXO gFknI3JZAL8zCz4R5wsa2pkM6VMdxpcQBk3yYqCy2FpsVfUUOKGMzZegd8sSplxS4+it pWnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0syX+Z8ZsLO1K+qpK4hh/FiHzxvRksi171obTN3jJ5s=; b=FZ75vsgLIvgYPXaIxSIiNlWf0Eav7MNooaOKN+ijmY08Mj8xshKi1LHNMiIL2rXRNt HVU2HUobHmZVPu0NtnkFcPoaV3dcthIlHawyk2+H0cNlyqE4nMJbox4sJemXF4bNGrGE 4qVpisfsgZgNRL2HI6eT9fWxH59JV0T/+SWiau30q3nuJWs53TjCXmiB0q9bACs3a8Oa GUWJsN9O1bEHN/3+RLfJdagOchrbim0PHrvm1b9h7lZAhSIev6kObrOYDgtMQQ1Y545D +aq+GwgV9wrRrls1v/nR2JEz6Dr85YaWSVkyDDydK7/457cK0jeNWc73zZMZh4PMvrQe Gj1g== X-Gm-Message-State: AFqh2kprWF0rW0Y1KmsaygF2UGSxVca1kOZA14SOAMMKVmVwC1wtrRLe 8hmb8TpbynUEjBSh8TYrZXkZi6jJddwvo2Le X-Google-Smtp-Source: AMrXdXsFr5BRkDWcCuVCxV1t9ah3Jggix5v9K7BgRPKnGRUnn6vsP+toxhtmFOCv3YC5BZh9d6NRBg== X-Received: by 2002:a05:6512:400d:b0:4b5:936e:69df with SMTP id br13-20020a056512400d00b004b5936e69dfmr22497064lfb.53.1673363890034; Tue, 10 Jan 2023 07:18:10 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Doug Goldstein Subject: [PATCH v3 6/6] automation: add RISC-V smoke test Date: Tue, 10 Jan 2023 17:17:59 +0200 Message-Id: <7a7eeba57589465e34be00f3d031866abe53e466.1673362493.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add check if there is a message 'Hello from C env' presents in log file to be sure that stack is set and C part of early printk is working. Signed-off-by: Oleksii Kurochko Acked-by: Stefano Stabellini --- Changes in V3: - Nothing changed - All mentioned comments by Stefano in Xen mailing list will be fixed as a separate patch out of this patch series. --- Changes in V2: - Move changes in the dockerfile to separate patch and send it to mailing list separately: [PATCH] automation: add qemu-system-riscv to riscv64.dockerfile - Update test.yaml to wire up smoke test --- automation/gitlab-ci/test.yaml | 20 ++++++++++++++++++++ automation/scripts/qemu-smoke-riscv64.sh | 20 ++++++++++++++++++++ 2 files changed, 40 insertions(+) create mode 100755 automation/scripts/qemu-smoke-riscv64.sh diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml index afd80adfe1..64f47a0ab9 100644 --- a/automation/gitlab-ci/test.yaml +++ b/automation/gitlab-ci/test.yaml @@ -54,6 +54,19 @@ tags: - x86_64 +.qemu-riscv64: + extends: .test-jobs-common + variables: + CONTAINER: archlinux:riscv64 + LOGFILE: qemu-smoke-riscv64.log + artifacts: + paths: + - smoke.serial + - '*.log' + when: always + tags: + - x86_64 + .yocto-test: extends: .test-jobs-common script: @@ -234,6 +247,13 @@ qemu-smoke-x86-64-clang-pvh: needs: - debian-unstable-clang-debug +qemu-smoke-riscv64-gcc: + extends: .qemu-riscv64 + script: + - ./automation/scripts/qemu-smoke-riscv64.sh 2>&1 | tee ${LOGFILE} + needs: + - riscv64-cross-gcc + # Yocto test jobs yocto-qemuarm64: extends: .yocto-test-arm64 diff --git a/automation/scripts/qemu-smoke-riscv64.sh b/automation/scripts/qemu-smoke-riscv64.sh new file mode 100755 index 0000000000..e0f06360bc --- /dev/null +++ b/automation/scripts/qemu-smoke-riscv64.sh @@ -0,0 +1,20 @@ +#!/bin/bash + +set -ex + +# Run the test +rm -f smoke.serial +set +e + +timeout -k 1 2 \ +qemu-system-riscv64 \ + -M virt \ + -smp 1 \ + -nographic \ + -m 2g \ + -kernel binaries/xen \ + |& tee smoke.serial + +set -e +(grep -q "Hello from C env" smoke.serial) || exit 1 +exit 0 -- 2.38.1 From xen-devel-bounces@lists.xenproject.org Tue Jan 10 15:25:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 15:25:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474783.736129 (Exim 4.92) (envelope-from ) id 1pFGV9-0001mX-MZ; Tue, 10 Jan 2023 15:25:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474783.736129; Tue, 10 Jan 2023 15:25:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFGV9-0001mQ-IP; Tue, 10 Jan 2023 15:25:23 +0000 Received: by outflank-mailman (input) for mailman id 474783; Tue, 10 Jan 2023 15:25:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFGPK-0005Fu-9l for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 15:19:22 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2648f661-90fa-11ed-b8d0-410ff93cb8f0; Tue, 10 Jan 2023 16:19:20 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2648f661-90fa-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1673363960; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=1vxXrw+ay3HT99goYjfDAu2oDeD/VzXJvgzuA0z439k=; b=BFjmJjSMMtyf2feYHUvQz3HVeZR8VZDgt75a1kIiXvkjmXLdAsSpEHGB DicRcv+pzhLsE76AzSAtRbldUGJXTMlXiBh/TNqEGzihp4b3fYlEhuQKw sFuylNQhPT6kNkKWq7t5/iAV5g0yZzUrj8rNnxr3Buo7Zgiq3OFiTZZcu k=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 92366405 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:CRPCiaqOfry98Q54OLmzdnqhhyNeBmIeZRIvgKrLsJaIsI4StFCzt garIBmEaf3ZZjH0KdpxOtvj/U4DuJ7Ry4cxHAZrrXg9ESIaopuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpAFc+E0/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06W1wUmAWP6gR5weHziFNV/rzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXAGkiTw6bnufu+rT4WNllpMMNd86xGIxK7xmMzRmBZRonaZXKQqGM7t5ExjYgwMtJGJ4yZ eJAN2ApNk6ZJUQSZBFHU/rSn8/x7pX7WzRetFKSo7tx+2XJxRZ9+LPsLMDUapqBQsA9ckOw9 zidoTqlWkxy2Nq32AGU3Cur2df0nCbVCbMWGbyc2aNRuQjGroAUIEJPDgbqyRWjsWahX/pPJ kpS/TAhxYAi+UruQtTjUhmQpH+fogVaS9dWC/c96gyG1uzT+QnxO4QfZmcfMpp87pZwHGF0k A/S9z/0OdBxmOS6aGyF77LMlzXxKxgcD2gsPiheaQRQtrEPv7oPph7IS99iFou8gdv0BSz8z li2kcQuu1kApZVVjvvmpDgrlxrp/8GUFVBtum07S0r/tmtEiJiZi5tEALQxxdJJN86nQ1aIp xDocODOvblVXflheMFgKdjh/Y1FBd7fa1UwYnY1RfHNEghBHFb9Fb28GBkkeC9U3j8sIFcFm nP7twJL/4N0N3C3d6JxaI/ZI510kvO6RYW9Ca2JN4Amjn1NmOmvpnkGiam4hj6FraTRuftnZ cfznTiEUR729piLPBLpHrxAgNfHNwg1xH/JRICT8vhU+eP2WZJhcp9caAHmRrlgvMu5TPD9r 4432z2il08OD4UTo0D/reYuELz9BSFnXsir9pUKL7brz8gPMDhJNsI9CIgJI+RN95m5XM+Sl p1hcie0EGbCuEA= IronPort-HdrOrdr: A9a23:dJU/Y634c0bgCnZ56wzLpwqjBAkkLtp133Aq2lEZdPWaSK2lfq eV7ZImPH7P+VEssRQb8+xoV5PsfZqxz/JICMwqTNSftOePghrVEGgg1/qe/9XYcxeOidK1rJ 0QDZSWaueRMbEKt7ef3ODiKadY/DDvysnB7ts2jU0dLz2CDZsO0+4TMHf/LqQZfmd77LMCZe uhz/sCiTq8WGgdKv+2DmMCWIH41qf2vaOjTx4aJgItrDKDhzOw6LL8DnGjr2wjegIK77c+0H TP1zf07KW7s/2911v12mLJ445N8eGRuudrNYijitU1Nj6psAquaYh7MofyxAwInA== X-IronPort-AV: E=Sophos;i="5.96,315,1665460800"; d="scan'208";a="92366405" From: Anthony PERARD To: CC: Anthony PERARD , Wei Liu Subject: [XEN PATCH] tools: Fix build with recent QEMU, use "--enable-trace-backends" Date: Tue, 10 Jan 2023 15:18:54 +0000 Message-ID: <20230110151854.50746-1-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain The configure option "--enable-trace-backend" isn't accepted anymore and we should use "--enable-trace-backends" instead which was introduce in 2014 and allow multiple backends. "--enable-trace-backends" was introduced by: 5b808275f3bb ("trace: Multi-backend tracing") The backward compatible option "--enable-trace-backend" is removed by 10229ec3b0ff ("configure: remove backwards-compatibility and obsolete options") As we already use ./configure options that wouldn't be accepted by older version of QEMU's configure, we will simply use the new spelling for the option and avoid trying to detect which spelling to use. We already make use if "--firmwarepath=" which was introduced by 3d5eecab4a5a ("Add --firmwarepath to configure") which already include the new spelling for "--enable-trace-backends". Signed-off-by: Anthony PERARD --- tools/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/Makefile b/tools/Makefile index 9e28027835..4906fdbc23 100644 --- a/tools/Makefile +++ b/tools/Makefile @@ -218,9 +218,9 @@ subdir-all-qemu-xen-dir: qemu-xen-dir-find mkdir -p qemu-xen-build; \ cd qemu-xen-build; \ if $$source/scripts/tracetool.py --check-backend --backend log ; then \ - enable_trace_backend='--enable-trace-backend=log'; \ + enable_trace_backend="--enable-trace-backends=log"; \ elif $$source/scripts/tracetool.py --check-backend --backend stderr ; then \ - enable_trace_backend='--enable-trace-backend=stderr'; \ + enable_trace_backend='--enable-trace-backends=stderr'; \ else \ enable_trace_backend='' ; \ fi ; \ -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue Jan 10 15:48:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 15:48:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474793.736145 (Exim 4.92) (envelope-from ) id 1pFGr4-0004DH-H5; Tue, 10 Jan 2023 15:48:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474793.736145; Tue, 10 Jan 2023 15:48:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFGr4-0004DA-Dm; Tue, 10 Jan 2023 15:48:02 +0000 Received: by outflank-mailman (input) for mailman id 474793; Tue, 10 Jan 2023 15:48:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFGr2-0004D4-SC for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 15:48:00 +0000 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [2a00:1450:4864:20::635]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 26e5a169-90fe-11ed-b8d0-410ff93cb8f0; Tue, 10 Jan 2023 16:47:56 +0100 (CET) Received: by mail-ej1-x635.google.com with SMTP id ud5so29802976ejc.4 for ; Tue, 10 Jan 2023 07:47:56 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 26e5a169-90fe-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=K9zFij6mcz/5EjbhUw4rVwr2bV1YHqurcc0Zhp61PdA=; b=lGnK5ikqxgW2LT21/K1L03RqZw22csPgayOQPywKPrXj/PUk/llgT4yYraB9McgByq t4fKoY4aqlf5mCVUsA4e6xu7RE0MiuWoNToUqjykUB0PuPYMT9wTvUZ+nxIZmqGUt54T 9zcCo9Onl6n3i2/+cXtVUpB7wF5SEmcC/PDsa5E1OJflqcljdXHnu3TDPcYvWmFgU+vx UkA9Ema/mEn+vbDPxx80icJIA6+B4Bo2lyPzj3OeEVgE8oEGMDQsA4Skw+ToRK1GcR3a 0kf/QuO0B0gNC8/sp1dlsFRKknnSMQbv82jltuQ7g1mVdPHm3mgL1VR9F6j0sgtQPDSA XWFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=K9zFij6mcz/5EjbhUw4rVwr2bV1YHqurcc0Zhp61PdA=; b=ql55Wj1/qhYKPbecTkYT7Uqe7sXmZEi1SgkcnayK+S8Rm602BAZxHZPUJyN3h3zRNS jkqTbVelpL3cPQla5R/3qR/+LIeUYlP1Q0dTk0SNz90Kj81sLua6juUFfsucpWxiAy9V s0XbDW1whtWZLM4RTgAxGipsFM/sUMWf3X0Rin/WeKpQ4n7XJuAoGoG5IsAcCtK2+E1k U51LDZVMzDPUzqZ7nzJeVgrusULlOY8e8lsZHqq4XHSc2mI3YCW7vnRznjzbaNkZvE4K ZJ5v+6yyhb9EA+qAi6347GWOmPmiLZXbn85Wksdbc0IZOLUW8dSOf4NQJZCl3fUSecqg jkIw== X-Gm-Message-State: AFqh2kqHyE6zrzHc+WG4YbSQ9hiSjpaUq/c3VWao59+lNq5+0PlMfynQ qFocHpuNEds8A5KAdeqY4i+U9ELt9NWO6oAHsVc= X-Google-Smtp-Source: AMrXdXtZCjmz2eEYGUuQtsjAmvIANrsSpe4d8dJvKJijER8DPcqmuDmusth+yawebeTjAUFsi8iKeAQdCI4B1/trC0s= X-Received: by 2002:a17:906:3b5a:b0:82c:356c:c4c8 with SMTP id h26-20020a1709063b5a00b0082c356cc4c8mr3777148ejf.649.1673365676310; Tue, 10 Jan 2023 07:47:56 -0800 (PST) MIME-Version: 1.0 References: <20230110151854.50746-1-anthony.perard@citrix.com> In-Reply-To: <20230110151854.50746-1-anthony.perard@citrix.com> From: Jason Andryuk Date: Tue, 10 Jan 2023 10:47:43 -0500 Message-ID: Subject: Re: [XEN PATCH] tools: Fix build with recent QEMU, use "--enable-trace-backends" To: Anthony PERARD Cc: xen-devel@lists.xenproject.org, Wei Liu Content-Type: text/plain; charset="UTF-8" On Tue, Jan 10, 2023 at 10:25 AM Anthony PERARD wrote: > > The configure option "--enable-trace-backend" isn't accepted anymore > and we should use "--enable-trace-backends" instead which was > introduce in 2014 and allow multiple backends. > > "--enable-trace-backends" was introduced by: > 5b808275f3bb ("trace: Multi-backend tracing") > The backward compatible option "--enable-trace-backend" is removed by > 10229ec3b0ff ("configure: remove backwards-compatibility and obsolete options") > > As we already use ./configure options that wouldn't be accepted by > older version of QEMU's configure, we will simply use the new spelling > for the option and avoid trying to detect which spelling to use. > > We already make use if "--firmwarepath=" which was introduced by > 3d5eecab4a5a ("Add --firmwarepath to configure") > which already include the new spelling for "--enable-trace-backends". > > Signed-off-by: Anthony PERARD Reviewed-by: Jason Andryuk Thanks, Jason From xen-devel-bounces@lists.xenproject.org Tue Jan 10 15:57:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 15:57:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474799.736157 (Exim 4.92) (envelope-from ) id 1pFH0b-0005jP-F2; Tue, 10 Jan 2023 15:57:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474799.736157; Tue, 10 Jan 2023 15:57:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFH0b-0005jI-BJ; Tue, 10 Jan 2023 15:57:53 +0000 Received: by outflank-mailman (input) for mailman id 474799; Tue, 10 Jan 2023 15:57:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFH0a-0005jC-4R for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 15:57:52 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2042.outbound.protection.outlook.com [40.107.6.42]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 88c1b9a9-90ff-11ed-91b6-6bf2151ebd3b; Tue, 10 Jan 2023 16:57:50 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8147.eurprd04.prod.outlook.com (2603:10a6:20b:3e0::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 15:57:49 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5986.018; Tue, 10 Jan 2023 15:57:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 88c1b9a9-90ff-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dq1wicav9BQVE8MDHlBgk+XxmNZ+eu75xmWxHjw3bqat/FgSb771DBkZLItnHYfUHZ9MRZO137dkqBggJUtswsJmpYqHkEhv53LIcjrvtB2ReIGeXr35OHSEIzOtHjQbGoeDOInCO8KY6mrnurmZsJDs+qFNxJPPaQj4qUAe47zwubG3sakqOCP0qmHFBQGOxQIDQETArHmbR5jjjxkXORCNw79f4F3cBVog62M8BtzmpGVjuiUi4yEMsSg9MPQ6uB15l6JC02NTFggoWaYPuy7qMB8pa5hvL5hW7TDhrIC+cDNd4+I59q7r21q8Zy6M4o0kEoabHGPb8GzH+yFozg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gaQPbytk+9sWancaNFfbsyIA0wu03ZervPJ+QZzmKQY=; b=EdKxGGJ1aKpQEhepsQ1+TNtPvyvjXpr96wk4uSRxYVYFpLKIVa2yMymmrwYilTev996+608phBAqa4Vyfz/OfJPBwmZ+2lV7ULLoM6EA6u8SgVYSUvq0CNDrWMt4Hz9YCfkhtMwQkc9qmfqCfsssmazauSeYabLOQ/SXLPYTRhTL8XlNVu+dZT902dxHaommDRHbQMDwqawC9/8Z9Nis4tHTmEP8rt9tJ0ObMdQrnE1yH7Eh/v5joet0gdpP1MJ4cge0gxM9Hh/BXRNPPjOk0fnjLH7Bw4f03NoQRrEIFWfGcInac80E5ibA6GC6ttJS99IVAIzHxtEGbUVELk6nJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gaQPbytk+9sWancaNFfbsyIA0wu03ZervPJ+QZzmKQY=; b=oVA2rLnhOHIuZj+yj+XGluUOKZPtNAwDb/j1iCRmKAFt64DUMAKDtx82igfwW09VrIsNFyzEBsogiiqFa2FBllnlvjgVRKrCzsbElJJJloPtf+G0q++9G7gjtBZ5Mo5WpcEK5fVG+fy0k6O2lAAyFzSVoE60FNDvaBhEpaTnYJBuJUeAVWotzGE7Zk/6dD2zqRgqehNHiyOUAOn3FfhEE4PctH2o3ui2cXrAIeXSrgTogiP0x2g+1kWqHPZuHU1kuxkOe0dlhz9NtH4Q0FRzBx3drI7H+hNMryST9YdhQ3+BsOc/kr1PV9EhS1BCJsHC+rReW+RzhE/sg/nxVlzXhQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2420503a-48d3-f975-beea-7e37e4ecd04a@suse.com> Date: Tue, 10 Jan 2023 16:57:47 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v3 5/6] xen/riscv: introduce early_printk basic stuff Content-Language: en-US To: Oleksii Kurochko Cc: Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bobby Eshleman , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org References: <25cd3586fa51980279f25a82eed5ded1622bc212.1673362493.git.oleksii.kurochko@gmail.com> From: Jan Beulich In-Reply-To: <25cd3586fa51980279f25a82eed5ded1622bc212.1673362493.git.oleksii.kurochko@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0005.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8147:EE_ X-MS-Office365-Filtering-Correlation-Id: 87ef407a-9da6-423a-7c6d-08daf3236be5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WOPOGoK+8yPcRUxCc2IoUZA5ghrOoK2EK7kbsdyGiyyjuWXBSel1Kiz8ApN6G0d1bGBCNBCbExKAhdAfhdLc/25OxEGUp6+OC/frMkQ02vM+wvF8XTHKQZHV3iaWmm/M96CwTmPVPHpVL8T8e4OCLbXL1ILkQTIUm4XGsN7eTtaXOKpVOD/tkOmXWItqvaZPd2NUFSeCUUy9uhqg8IdDp84BxZwtywpR96o5dFdAXwiiXqLLvdE1HYL44x3sZMAp4xeNG06bNmyEBir6C2uNOuPBBbRKuzLWyFJ6jHdRYgMTIMfCElj7Bp33O4JfqPFu8nrWGvjEcSCtBshcsAkA0ZZOE9mytIg7Tcm3j3EtAPa2HjRBD2lmsftWmDe1C1EHBAxiYyzpKdGaWsea7Jj9yTTteGXYl+R9msC/k+jBmIeAXiKicazxLYYtjo701r4iQr85id3Z4T7i++QIdSwgisTlNElRwFglOTHCA8PPNsxxZrGWD7B9GcIiNZ4h2dsZsjzUhj6SnguUM4ak5CqkDToDB3q1tF4WuvAM3I1X9DCSQ+yuw/aUlfHqR3xMVNqLawBgPqAQKV981EYJzqAlOGp3+FOx5quRq+iVVX3UrEvaomxMwuYioP4Cyyhc7rtQU3DKkJZdFW63kEuLOGCD5Zv8OAWBLxMJrDo7Rfgl78sogQJIip41MOyiTNmtGM0/R3FxvN9zonS/KUproDxlhq8VRM1cJBMH/g9Eih287gQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(366004)(39860400002)(396003)(376002)(136003)(451199015)(8936002)(2906002)(5660300002)(41300700001)(7416002)(4326008)(316002)(6916009)(8676002)(66556008)(66476007)(66946007)(54906003)(26005)(6512007)(2616005)(38100700002)(31686004)(86362001)(186003)(31696002)(36756003)(53546011)(478600001)(6506007)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dnMzQnJaNTRUcWlPVHozbUw0VFdJS1ZBSFRjVmNpN2w0VFhTZWdIeVZJWnQv?= =?utf-8?B?UVBXcmlLNXVya3VoT2tvbEpQaGVvTHVqUjYyRDFhZEI0bmZIeHhYRE8xYjFn?= =?utf-8?B?R0Y4SFBqK3BNRHltMHcrMUhDMERjZERwUzNtY1IzcGxnbzRUci85NkVneXpm?= =?utf-8?B?V0oxL1ErbXU5eFBpWnVCMUVGZGpHMlJaSnpJSmY2cEQ1d01YWkdFZ0lBckFX?= =?utf-8?B?R0llbytnT1J0cGFKM3l1N1VWZzJTOGgwWGpobFIwZ2kwSnZrTHFnUnIzZlkz?= =?utf-8?B?dFd2YjdjZ1hOWHA4UGVPNUJvaE9aZEduVldQNmRnYi9scC9rd0dyVUtIMmE4?= =?utf-8?B?Mk5nWlhCOGdGSEZYbUwydGhxMVlPcUE0Q1RiZXdxaGEwWHRrN25TMVVsKzBo?= =?utf-8?B?bEdKMW9xWkJhV28yMFY3cUhmL1JhdkpVY0xWWm9nUkRjWFRhaUdjc091N1hj?= =?utf-8?B?Mkt5N1ZIT0hOZ004eDhXR1QzUFFUSi9KWlpZdTlPQVhHZkZST3pWbVU2aUo2?= =?utf-8?B?YWd0RE51VU50ckhUK29VcFNTbnFIeER3ZjhUZEh2Nk9zWHk0SHlKWmZFbnc5?= =?utf-8?B?Nm4rWjgxUFpaWjFBNXAxVm1UMEtDTnpOSGNxWUNueGZFWWw0NVpYZllobW5w?= =?utf-8?B?K1dNdTdZYTZ1TnZ0YVJhekRKbk1sQ0pVdTZDRXgvdm5Celovem93cG9pM3BO?= =?utf-8?B?TG4vVldHZlg1VXJFZGVIMHJIcERLNEJhby9NMlVvMVE1eWtWbHZpTkdKZUd4?= =?utf-8?B?d29sblg1Um5yMFJ5SmxPMnJhMHhvSlhsWUttMnRGYXR6amM2S2VhZlpkRXJC?= =?utf-8?B?bG9ZanhYclFQcDFRU0pHUE9ML1RIcGxmYlE4N3h4S2ZsditMeHNUcWZFa1Na?= =?utf-8?B?ZjRLaGVoaGEwZ0MzcUVkK0VJK0pDNWx1QStCVjhJUzRFK08xanhoZVJMUkVO?= =?utf-8?B?RWVHVGwvUVdlSnpNVXNHMk12bGZNMlFNb3M5NGtyNmllMnRNMEFidVF5ektX?= =?utf-8?B?ZnFQYWNYYlpiQzc3NTR3VWJIYkNnZ3Q5dmZ1Uzc0eTJXKzBQYnVQTWNMcUhv?= =?utf-8?B?VUZiNHQ0ZWFGM2QxVUZrSDBFWmVpa1pLSHo5VStOOUkxOXMzZzZ2VjE0d0dw?= =?utf-8?B?OUczOTJDNUgyYVNlc2ZTUHZoYXFSc1krMkVCNUJPQnpUcHJIK2JBcEp5RTRM?= =?utf-8?B?WUR5MXFhZUpPdTA4N2ZkN3hSUXlkN0FoYXhuMnA5VndtVG5UdWVIWGV0UHpK?= =?utf-8?B?dlpjbHI4cmRrMk1YTmFtOEYzY3BIMy9OMm5rNE1EWW9RZTJsN1ZFRVRidEdy?= =?utf-8?B?L09ReDMxZU9uc045L2RPODNLdzVML1dwMGVnTkNTTExzWlhkSzUzQjdnZTlX?= =?utf-8?B?eTE0Ui9lQ3N6b2pIZU9sTUpCTlJlTG5FUWdKTjlQTExJcVVPS0E4TDFqSWZn?= =?utf-8?B?YUVSM1VEcUExK3k0VE81WjFtbzk4VFlYSVh6dGpTdmZjSXNBenZoQ2NvNVNy?= =?utf-8?B?SjFFdmhKc0pGaWxpYzZzWkhCNjBWYXJCR0t3cFVjdVdSTnFxUFA4UE51K3pO?= =?utf-8?B?RVU4YUFLSnlrUHoxYVdEWm4weDFmdUJtaHNBNVo0K1g5ZjY2bFpaaUcycXNp?= =?utf-8?B?WWRVYTFUc0Z5dGl6dFhhejIvRktFa0xhWGNzRy8ybmI1RjVxamU1eUZBYkNa?= =?utf-8?B?VnFUK0g3NDRCbjlGNFY3a3kvTzR6RjZpSVBWc1E5R0JPbGg2WElJQll2Ui9U?= =?utf-8?B?QmF6U0srdENkOVNKYURac1N1emVvNDlNbGp6dGJ0cklvNVlwQVhaeEhSSjVH?= =?utf-8?B?WTY2WElIeGVVc0hheDZhTDgxbmpVRy9CQ0YvVGNwNDNKZEFnVnc4WDIzTjlt?= =?utf-8?B?azFTNmwvMFdxU1Jza3FhdVhQa1Q5dUsvU2M3Ukp1ZVRDd1k0RXd2bTF1dzJq?= =?utf-8?B?TDI0UjRFOEdqWXlxS3duMFhyL0lWQVFEb04xZ3dHUkozUVk5dWs5STVQUlR0?= =?utf-8?B?LzA5OVdXOHJ3R1ErSzRkV1F6MkhnR29nZ1RRVmRwN1A3S0RwaC8xNEZXdk5u?= =?utf-8?B?U05nQmxvTzJ6QzB6Q0JMcXpFWENjMWhCU1pWMkgwYmxZdkdxOE03VTN3YzY3?= =?utf-8?Q?0e6TNHFTY/ILhMJ/4nhgryQGd?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 87ef407a-9da6-423a-7c6d-08daf3236be5 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2023 15:57:49.0484 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HrSlNZrl38slOoNVqoKRr67fwLjtL0onONaMsS7rwIjc29p3D2RZ+zAQGJWwWMkEDUNvy+NARnzYA2H8OWROhg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8147 On 10.01.2023 16:17, Oleksii Kurochko wrote: > --- a/xen/arch/riscv/Kconfig.debug > +++ b/xen/arch/riscv/Kconfig.debug > @@ -0,0 +1,7 @@ > +config EARLY_PRINTK > + bool "Enable early printk" > + default DEBUG > + depends on RISCV_64 || RISCV_32 You're in a RISC-V-specific Kconfig - do you really need this line? > --- /dev/null > +++ b/xen/arch/riscv/early_printk.c > @@ -0,0 +1,33 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * RISC-V early printk using SBI > + * > + * Copyright (C) 2021 Bobby Eshleman > + */ > +#include > +#include > + > +/* > + * TODO: > + * sbi_console_putchar is already planned for deprecation > + * so it should be reworked to use UART directly. > +*/ > +void early_puts(const char *s, size_t nr) > +{ > + while ( nr-- > 0 ) > + { > + if (*s == '\n') Nit (style): Missing blanks. > + sbi_console_putchar('\r'); > + sbi_console_putchar(*s); > + s++; > + } > +} > + > +void early_printk(const char *str) > +{ > + while (*str) Again. > --- a/xen/arch/riscv/setup.c > +++ b/xen/arch/riscv/setup.c > @@ -1,12 +1,16 @@ > #include > #include > > +#include > + > /* Xen stack for bringing up the first CPU. */ > unsigned char __initdata cpu0_boot_stack[STACK_SIZE] > __aligned(STACK_SIZE); > > void __init noreturn start_xen(void) > { > + early_printk("Hello from C env\n"); > + > for ( ;; ) > asm volatile ("wfi"); While this is only context here, it affects an earlier patch in the series; this wants to be for ( ; ; ) asm volatile ( "wfi" ); Jan From xen-devel-bounces@lists.xenproject.org Tue Jan 10 16:25:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 16:25:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474806.736168 (Exim 4.92) (envelope-from ) id 1pFHRQ-0001C7-I5; Tue, 10 Jan 2023 16:25:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474806.736168; Tue, 10 Jan 2023 16:25:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFHRQ-0001C0-FE; Tue, 10 Jan 2023 16:25:36 +0000 Received: by outflank-mailman (input) for mailman id 474806; Tue, 10 Jan 2023 16:25:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFHRO-0001Bu-KF for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 16:25:34 +0000 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [2a00:1450:4864:20::629]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 675bf3d7-9103-11ed-b8d0-410ff93cb8f0; Tue, 10 Jan 2023 17:25:32 +0100 (CET) Received: by mail-ej1-x629.google.com with SMTP id tz12so30093187ejc.9 for ; Tue, 10 Jan 2023 08:25:32 -0800 (PST) Received: from 2a02.2378.1019.479a.ip.kyivstar.net ([2a02:2378:1019:479a:6357:b59e:a085:4bb7]) by smtp.gmail.com with ESMTPSA id gn19-20020a1709070d1300b00816edcb4e59sm5124252ejc.146.2023.01.10.08.25.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jan 2023 08:25:31 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 675bf3d7-9103-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=wlw7+zZsV9HauSQ/SQ7cPTLqSUwEPYqT2Dxcx8+og0U=; b=hb4Foy4vLmPXkGwIKWaQt/tC6ky+ux0Q1UhIGphk0mSolL2r/AzmOfmSfRJsyIcyfu XHuNLHUuUeu4PFdfQol+mSln9HSNpDJCquRVXeIDW+SIgElApSyT+IuL6p/E8TKm4I7S cYIGgaFN4+ILVIzHDs2NmhYXOyP1R2grnPgvZL5seSLfpaseqrT+jgER2Z/zCs9sUdXf NhaMuVZiXdAy2I+gm/vh1m0R1LioLiOCb9/HQ8l6/ZVhEZaHFQpM4+r++fhdOOy8x6pf 7DooVt+qOxTN+KbWZ3MkhSAaIPQTJK3sNQ70kn8GHWb9bnEUJ3t17eNR4Cq7TrDqYrc5 BpOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wlw7+zZsV9HauSQ/SQ7cPTLqSUwEPYqT2Dxcx8+og0U=; b=oWBVGhB8szmk1/PnwavCvR7jj2ZX2HOYNGsfBPMcxH+IA+2uwwwMZfblzLyM1eIhoB Mw3U9jWKGDi3DzKRG5RfWEArogjGl6y+WBwDR8I11EON5DCoQxVvBxqum758kTDX1AjI rWOkXQ8X85naU2kG4plmZrJ35Yn279o+v6JYjpEapsu4KWnerY39gf/5Ils0aoct7+4G iNKE5/Rzo3EFhL6HunKMO+2F5WJwVD39Zd0yArl+3Cva3p/yv8qITQGejiTtO0S8nGk3 ZZxFbTFMqOmDZZ64FWZWSUKje1H1jS1gwVlLbAfhjwcNpLNxE2S7dqFTAvb8xHP8v57V 2v7Q== X-Gm-Message-State: AFqh2kp/s9u7ylFxkXeG/FFAhHc80ZczGuTSLEbdlsMFlv5fjHPHSTWd C1K90YsW9uQxgI3Pv5+Sat+oWnU2E3TjNQ== X-Google-Smtp-Source: AMrXdXuyPgoH9gFzS8SK3KK4mYnl0Z/eZqsMjUP2WjuoFP+9PXyOZrzw8qmLceDgTUJyKQWVgFDdhQ== X-Received: by 2002:a17:906:3084:b0:7c1:5ee1:4c57 with SMTP id 4-20020a170906308400b007c15ee14c57mr56274536ejv.8.1673367931694; Tue, 10 Jan 2023 08:25:31 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Doug Goldstein Subject: [PATCH] automation: rename RISCV_64 container and jobs Date: Tue, 10 Jan 2023 18:25:23 +0200 Message-Id: X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit All RISCV_64-related stuff was renamed to be consistent with ARM (arm32 is cross build as RISCV_64). The patch is based on the following patch series: [PATCH *] Basic early_printk and smoke test implementation Signed-off-by: Oleksii Kurochko --- ...v64.dockerfile => current-riscv64.dockerfile} | 0 automation/gitlab-ci/build.yaml | 16 ++++++++-------- automation/gitlab-ci/test.yaml | 4 ++-- automation/scripts/containerize | 2 +- 4 files changed, 11 insertions(+), 11 deletions(-) rename automation/build/archlinux/{riscv64.dockerfile => current-riscv64.dockerfile} (100%) diff --git a/automation/build/archlinux/riscv64.dockerfile b/automation/build/archlinux/current-riscv64.dockerfile similarity index 100% rename from automation/build/archlinux/riscv64.dockerfile rename to automation/build/archlinux/current-riscv64.dockerfile diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml index 6784974619..7ccd153375 100644 --- a/automation/gitlab-ci/build.yaml +++ b/automation/gitlab-ci/build.yaml @@ -647,31 +647,31 @@ alpine-3.12-gcc-debug-arm64-boot-cpupools: CONFIG_BOOT_TIME_CPUPOOLS=y # RISC-V 64 cross-build -riscv64-cross-gcc: +archlinux-current-gcc-riscv64: extends: .gcc-riscv64-cross-build variables: - CONTAINER: archlinux:riscv64 + CONTAINER: archlinux:current-riscv64 KBUILD_DEFCONFIG: tiny64_defconfig HYPERVISOR_ONLY: y -riscv64-cross-gcc-debug: +archlinux-current-gcc-riscv64-debug: extends: .gcc-riscv64-cross-build-debug variables: - CONTAINER: archlinux:riscv64 + CONTAINER: archlinux:current-riscv64 KBUILD_DEFCONFIG: tiny64_defconfig HYPERVISOR_ONLY: y -riscv64-cross-gcc-randconfig: +archlinux-current-gcc-riscv64-randconfig: extends: .gcc-riscv64-cross-build variables: - CONTAINER: archlinux:riscv64 + CONTAINER: archlinux:current-riscv64 KBUILD_DEFCONFIG: tiny64_defconfig RANDCONFIG: y -riscv64-cross-gcc-debug-randconfig: +archlinux-current-gcc-riscv64-debug-randconfig: extends: .gcc-riscv64-cross-build-debug variables: - CONTAINER: archlinux:riscv64 + CONTAINER: archlinux:current-riscv64 KBUILD_DEFCONFIG: tiny64_defconfig RANDCONFIG: y diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml index 64f47a0ab9..4ca3e54862 100644 --- a/automation/gitlab-ci/test.yaml +++ b/automation/gitlab-ci/test.yaml @@ -57,7 +57,7 @@ .qemu-riscv64: extends: .test-jobs-common variables: - CONTAINER: archlinux:riscv64 + CONTAINER: archlinux:current-riscv64 LOGFILE: qemu-smoke-riscv64.log artifacts: paths: @@ -252,7 +252,7 @@ qemu-smoke-riscv64-gcc: script: - ./automation/scripts/qemu-smoke-riscv64.sh 2>&1 | tee ${LOGFILE} needs: - - riscv64-cross-gcc + - archlinux-current-gcc-riscv64 # Yocto test jobs yocto-qemuarm64: diff --git a/automation/scripts/containerize b/automation/scripts/containerize index 0f4645c4cc..9e508918bf 100755 --- a/automation/scripts/containerize +++ b/automation/scripts/containerize @@ -27,7 +27,7 @@ case "_${CONTAINER}" in _alpine) CONTAINER="${BASE}/alpine:3.12" ;; _alpine-arm64v8) CONTAINER="${BASE}/alpine:3.12-arm64v8" ;; _archlinux|_arch) CONTAINER="${BASE}/archlinux:current" ;; - _riscv64) CONTAINER="${BASE}/archlinux:riscv64" ;; + _riscv64) CONTAINER="${BASE}/archlinux:current-riscv64" ;; _centos7) CONTAINER="${BASE}/centos:7" ;; _centos72) CONTAINER="${BASE}/centos:7.2" ;; _fedora) CONTAINER="${BASE}/fedora:29";; -- 2.38.1 From xen-devel-bounces@lists.xenproject.org Tue Jan 10 16:26:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 16:26:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474812.736179 (Exim 4.92) (envelope-from ) id 1pFHSC-0001kt-0A; Tue, 10 Jan 2023 16:26:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474812.736179; Tue, 10 Jan 2023 16:26:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFHSB-0001km-TG; Tue, 10 Jan 2023 16:26:23 +0000 Received: by outflank-mailman (input) for mailman id 474812; Tue, 10 Jan 2023 16:26:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFHSA-0001Yc-Nd for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 16:26:22 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2040.outbound.protection.outlook.com [40.107.21.40]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 82f000bb-9103-11ed-91b6-6bf2151ebd3b; Tue, 10 Jan 2023 17:26:21 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8369.eurprd04.prod.outlook.com (2603:10a6:20b:3b0::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 16:26:17 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5986.018; Tue, 10 Jan 2023 16:26:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 82f000bb-9103-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qp603CpyuUIuk6v2fWazQ3C+jU5EgSaqMbi2t4EgzmCR5B3klYpcgH/aC6uu9wnbwJAgPzEbbRgVMaKgEdigbHDXxD3MnTVNrarwCp7Mqkct5VeApCIwhLTk/j5G/Gr/4cMVN/VelsoKlnWR9wWEq28p6h9QImKjre1vqBOT61Fik5tzWNjRGlLYxC+cgO2jcmdfFMBNFrZjkLQINrcrTZ7Gb0M1iZYtXXkpx8eemGc0pQnVcjw3vpFE5KkNGUc9rO6Fj3TSZ7eSvhvgXtjYzOI13GL8lcH3ATXW06uZhu0rfLu30P4lQxiJSPTo7kegnlENCqPTFkAkdZx24/lACA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J9J1WlR7LO6Tw6yrMCIzapZHEArRLyuLNDKQFmwiito=; b=hDIX5+MFN9P+odkOOG0m9I/7TmFlrbzFbkbp/DJW+Q/iC9lECbGf7AYeTl/ki4BR9RiDfCu7rgF1TEFF8TejN7VgTNGWoFsx/2cmy4hzr4F6CqLMHVkEHpeWrc1yyvQEccxIIEINmSilkXiI8Ll9HkRilN/LZXf3S1Ddt5OcPzPXqcWIFvHJBBFSW6ejgEGu5FCGJuSWcY2/vmvmxtYSjMegRdzbSRiTXZDAqiWabWjhNJVVJzzKy/tZGPzyfMB2R58jR+BfBeaVg/ABFXOY0FtDuvHD5P8evGRJUbgAubBlGE2i2RB3AVrzFLL92EVIi19ZU4mFCnJfHc9tu2wHBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J9J1WlR7LO6Tw6yrMCIzapZHEArRLyuLNDKQFmwiito=; b=cKSti12YLkATAtUMByco8iWisRaAeYexBCdEDfO1ASI8IbvU4NMHV0xo1KkES4iPwuPt/7Nr7NRqP2wzhRHwU7n62essm2dfkeqUyZRxSzzbAt3aSYIjYOvdybBCQpSjg4Dbc2l+K4CJDmg6EdF2k0tzbSOnM5Mwuwy1L3yZE9cTFW3ZS8sCJZCltVLV76ECcjJBFMcnMjEt4rPXvDvOX/c/u+TIs0fQwJcuFqrYYTzHhDizFXALINpaJtjxT9LU7HmzdqDoJi2ww1RcBTPpvTvDkxUlh83uy7WaggpdCGfGpAoK9bn08xXqmHtihy+qdgrrDJ11/iA6hZlWlJOUbQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <80b2ea4d-d52b-14c5-38ea-b8ab7e3a713c@suse.com> Date: Tue, 10 Jan 2023 17:26:15 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 1/2] x86/vmx: Calculate model-specific LBRs once at start of day Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Jun Nakajima , Kevin Tian , Xen-devel References: <20230109120828.344-1-andrew.cooper3@citrix.com> <20230109120828.344-2-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20230109120828.344-2-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0136.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8369:EE_ X-MS-Office365-Filtering-Correlation-Id: 7aee1e9c-b77c-4761-69ba-08daf327665f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qlKMGVvM7cQaofyTqfo3BMrO/4HeVhEdWOtik139efI/cv9d9dmITgYXHy2OHTCYxm/SycAMecGpThO1PsgCed1uU7y7P7KpUR6EYmVYsL98eoXNRPAFpGk90RfVUCBdDdqaPlEAUUDoPIE5MBu09A4jCW2VjLrOJjA0bHuTHVQXCTFTdm8sLP7BrIBTltoByUHKb/mTmlKPcNahh7WOs8sMxjtQHlnudL97gwNspNCrkCFmBZGFa8EFXvqzsiadG670gi8fOnbAGpoueMfLrGJWMR+2EH1nGSwH7dA3LeSxLEM/yNvVoz3NrgWKFbS3MxCBJt+xsSJO39MCISmh4XZ7VjLQOmJdBpcekcUVrtZn4XgeXb7H6628t19ltL79jicv/GD3ag3OUkX8nVvgjQoUbqg+9jWdV2pNmShRYjDPdT8cvfptT9s0rDi/KTm2lH8huGr2YHl4e0fnDYZiN/i5vLRrUlq7cv5O07HY5VIr1w8eu1Gne2Pcii0YH/7Am4xj4+TOwd1DLuK+YE6PsqjQmWG3SX7zluIb5+aLjM1Nv4Ea9BIhATMbJqyqbuo3RiX/qvDKSw/XVobYq6BMvjyjIhMTXQeKt6AYcna4bmIbp/WGL1RqV9nPWGIZef0dr2OJS96DBb7/OgBH+rOo6LYCSenQ3Gfo9Yd4XWS6TQpUC0v/CS7J9Th6HW7BVYjiZmNCZjelKivZA4kD+4YnwefgQCsHjB1sAc4FS9xw/C4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(136003)(396003)(346002)(376002)(366004)(451199015)(66946007)(31686004)(41300700001)(2906002)(8936002)(36756003)(5660300002)(8676002)(6916009)(66476007)(66556008)(6512007)(316002)(54906003)(478600001)(6486002)(53546011)(6506007)(186003)(4326008)(26005)(2616005)(31696002)(86362001)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?akxRajBoWHRCNktuMk1NSWdsbktTM1RtUmpMLytrSG1yNWp3N2JVVHZKK3Iv?= =?utf-8?B?dHUvNW9qNEdieUx4T3RIN0kxMjZwOWpyaEdVVm5HNFdJRlVYUXkrL0xMaTQ5?= =?utf-8?B?WTNhdHNuMDBQUEo2TG1zanBzZWpQbDdQeXM2ZVlGMC9NVjY5cndqTXBXdlNG?= =?utf-8?B?WVVuQkZPeHlKNVk2RTFTMUNsSHJLNjBUV1g4YnYvZjFicHRnSktQcHhtSUNO?= =?utf-8?B?cmpJYnNXeVd1dzFwQjA2Tm9zU3JOeG5FZzVzWVcxTjVGNS90OHhVcjBxOGgy?= =?utf-8?B?cnprTGJSRGlKUFIyaXJocXlXQ1U4VWZocktjY2k4dnVRYmlpYXVyb3dHUmFy?= =?utf-8?B?MDFTN0grZklkTDFsbjZvYWlBNiswaEU1VmpQdk9uaHFUVDRMb1FNT2M1ZmFC?= =?utf-8?B?UitSRFNuL3FJY2lEbXAzQmVZRmFGKzBtZitYQXI0emZTU0M2YmV2ZlZPelBl?= =?utf-8?B?UDlrQ2dUVFFPTGszMGxCSDRUQ21xaHcxcWlKcEoraWg3dzU1cms0Y0FHdXlw?= =?utf-8?B?aElTN0s2dnNuOVBjOHpXRzFpN0NTRVNCbC9tbklONXUzUjBwMDM3MFdLOG1O?= =?utf-8?B?NDRZRy82bEorWUZpeFhWWndaYjVXS1I0amI3VzBPblZ4UUNLMUl0cXdMVER1?= =?utf-8?B?dVdXL0tzMWFxSWJKazlQbEd1UWRQVTZKVmExV2xmZGs1Z3hDY202TkxIdSta?= =?utf-8?B?MFpjWWVFTFlFK2RoSFFZLzJOTkdlSEVxYysxV1JsQVBoQ3hacklEQWNHR1Ft?= =?utf-8?B?Y3VOQzkyYXVtTWxIWUtuQVhIbDZuZ0lPMWFpSnhYaUFaR1RjM2ZicVo4VVIx?= =?utf-8?B?cW1XczhPWG1NblVXckhCMlRQZGg5L0NqQzBESS9jZjAvRHZvUG9QUkFGSVVu?= =?utf-8?B?N2NmMXNwK1p2VTVva3NxV3JtVkhEUFdtNG1DbXdqQW5MUGJqTU05R1FONmhE?= =?utf-8?B?Q1FEMzJ0Smw2akIvVXY4UzFxNGtONmp5NXFsVisxRWo3ZHhkdGROcTYraFYv?= =?utf-8?B?MHVXYklad2NOSzdoM2tQTkZZblpJRlVIOUorTnBpNnR1L3R5V3hlTER3azJs?= =?utf-8?B?TGx2ZDFYdnQ0UGpxMnVkRmFEWmVjV1VtU3hVM3dkRTM5SWJHS1VRZWo5QTBl?= =?utf-8?B?OGlwREhDbU5veVNRY3JUZWNwRDFHbmtJZDVuYVBSK1l1aWZIZlhIWWV3cGZP?= =?utf-8?B?SWY0dWZkcTdoZVR1TTRCMzdxbnEwclVBaHN3aG5Ob25wNkdBZ3oyZFNqc0lG?= =?utf-8?B?Y1dUL1RRUStaRWpXc3JlRkpEbEU0dVhFdS91YlFRdU4yekhtRG9KRDhJU0E0?= =?utf-8?B?ZS9DR005T1lYdk1USFR4a0YwUVBuQzJBVzhraVZtaXk0ZVU4TFV2VkFsMHU3?= =?utf-8?B?bEdWdjBzb3NxSEFtOWp5NUwvN1hRcnZkSlJqMFdLaVVwb2licEFOb0RER1lU?= =?utf-8?B?QjZLV2lDbFh0SUh5ajJmaW1MM2pEb20yZHlGZ3krUy9lZllrRlVTZERCKzdo?= =?utf-8?B?Sk9aOVRFZnhHZy9LNFNRLzFpYm11T1hBYzRnU3ZzeUtTRC9tbWIzaVZJakE1?= =?utf-8?B?UVUwek9mUSsxOVZwWTBMTlluQWJ6SmpVSUxxNnZLa2Nzc2FranFGZ2N1ajBt?= =?utf-8?B?MXpnSjNZRjFaQW1DS1pzdEZBVFcvVUE0bHgvQnNZYzEyTmVoNzNuYTFteDk1?= =?utf-8?B?WEJRM1lORzlWNDZGbWxZRkxqVGJ1THRzNDRFS295M2xMQWNRZlBWMmpFU2Jl?= =?utf-8?B?TzNoUkR3QjFzdkJ1aFFEU1J4MXRkeWpZYUU2NnZCYWszUEVMQVlBUUtJbWRB?= =?utf-8?B?UjlQSjhBaGY0OEwzb2NzY0I5S1VZemlmUXFnYTRNME9aMW1HMWFncUVyLy94?= =?utf-8?B?TDA0bXFoV3A0czdidHhqaExXUWNLWFJiOUxVVFVWeFJoUVpESUJ6c0JZQXY3?= =?utf-8?B?YmRsazdva1pCaUQzWDNTWStPUkxwYlpza3JxK3NRNlZZMGFWanF4NnQ2WDRH?= =?utf-8?B?dVpyQkZwUTJwSWt1RnB3bzdsdFo1aWp1VWNFbWVjb1F2K2NIUjhTYmNZcWNm?= =?utf-8?B?Wm9jYlBCZlJLUnF5V1g5MHdjWU1kb3VrRVBzbDkyQys3NW5qaUVUdGJNeWNJ?= =?utf-8?Q?GDqhqQ2LbIn2hHnS9G6pK/Uk5?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7aee1e9c-b77c-4761-69ba-08daf327665f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2023 16:26:17.5024 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GpreWjj9xJCQKH71Kl+xskiY9jyqsb42J70dZ7EcOWW6q7ZhyVxVbhpD9Jj61dJeysERbtwRc6oguKcYqC6tgw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8369 On 09.01.2023 13:08, Andrew Cooper wrote: > There is no point repeating this calculation at runtime, especially as it is > in the fallback path of the WRSMR/RDMSR handlers. > > Move the infrastructure higher in vmx.c to avoid forward declarations, > renaming last_branch_msr_get() to get_model_specific_lbr() to highlight that > these are model-specific only. > > No practical change. > > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich with one nit: > --- a/xen/arch/x86/hvm/vmx/vmx.c > +++ b/xen/arch/x86/hvm/vmx/vmx.c > @@ -396,6 +396,142 @@ void vmx_pi_hooks_deassign(struct domain *d) > domain_unpause(d); > } > > +static const struct lbr_info { > + u32 base, count; > +} p4_lbr[] = { > + { MSR_P4_LER_FROM_LIP, 1 }, > + { MSR_P4_LER_TO_LIP, 1 }, > + { MSR_P4_LASTBRANCH_TOS, 1 }, > + { MSR_P4_LASTBRANCH_0_FROM_LIP, NUM_MSR_P4_LASTBRANCH_FROM_TO }, > + { MSR_P4_LASTBRANCH_0_TO_LIP, NUM_MSR_P4_LASTBRANCH_FROM_TO }, > + { 0, 0 } > +}, c2_lbr[] = { > + { MSR_IA32_LASTINTFROMIP, 1 }, > + { MSR_IA32_LASTINTTOIP, 1 }, > + { MSR_C2_LASTBRANCH_TOS, 1 }, > + { MSR_C2_LASTBRANCH_0_FROM_IP, NUM_MSR_C2_LASTBRANCH_FROM_TO }, > + { MSR_C2_LASTBRANCH_0_TO_IP, NUM_MSR_C2_LASTBRANCH_FROM_TO }, > + { 0, 0 } > +}, nh_lbr[] = { > + { MSR_IA32_LASTINTFROMIP, 1 }, > + { MSR_IA32_LASTINTTOIP, 1 }, > + { MSR_NHL_LBR_SELECT, 1 }, > + { MSR_NHL_LASTBRANCH_TOS, 1 }, > + { MSR_P4_LASTBRANCH_0_FROM_LIP, NUM_MSR_P4_LASTBRANCH_FROM_TO }, > + { MSR_P4_LASTBRANCH_0_TO_LIP, NUM_MSR_P4_LASTBRANCH_FROM_TO }, > + { 0, 0 } > +}, sk_lbr[] = { > + { MSR_IA32_LASTINTFROMIP, 1 }, > + { MSR_IA32_LASTINTTOIP, 1 }, > + { MSR_NHL_LBR_SELECT, 1 }, > + { MSR_NHL_LASTBRANCH_TOS, 1 }, > + { MSR_SKL_LASTBRANCH_0_FROM_IP, NUM_MSR_SKL_LASTBRANCH }, > + { MSR_SKL_LASTBRANCH_0_TO_IP, NUM_MSR_SKL_LASTBRANCH }, > + { MSR_SKL_LASTBRANCH_0_INFO, NUM_MSR_SKL_LASTBRANCH }, > + { 0, 0 } > +}, at_lbr[] = { > + { MSR_IA32_LASTINTFROMIP, 1 }, > + { MSR_IA32_LASTINTTOIP, 1 }, > + { MSR_C2_LASTBRANCH_TOS, 1 }, > + { MSR_C2_LASTBRANCH_0_FROM_IP, NUM_MSR_ATOM_LASTBRANCH_FROM_TO }, > + { MSR_C2_LASTBRANCH_0_TO_IP, NUM_MSR_ATOM_LASTBRANCH_FROM_TO }, > + { 0, 0 } > +}, sm_lbr[] = { > + { MSR_IA32_LASTINTFROMIP, 1 }, > + { MSR_IA32_LASTINTTOIP, 1 }, > + { MSR_SM_LBR_SELECT, 1 }, > + { MSR_SM_LASTBRANCH_TOS, 1 }, > + { MSR_C2_LASTBRANCH_0_FROM_IP, NUM_MSR_ATOM_LASTBRANCH_FROM_TO }, > + { MSR_C2_LASTBRANCH_0_TO_IP, NUM_MSR_ATOM_LASTBRANCH_FROM_TO }, > + { 0, 0 } > +}, gm_lbr[] = { > + { MSR_IA32_LASTINTFROMIP, 1 }, > + { MSR_IA32_LASTINTTOIP, 1 }, > + { MSR_SM_LBR_SELECT, 1 }, > + { MSR_SM_LASTBRANCH_TOS, 1 }, > + { MSR_GM_LASTBRANCH_0_FROM_IP, NUM_MSR_GM_LASTBRANCH_FROM_TO }, > + { MSR_GM_LASTBRANCH_0_TO_IP, NUM_MSR_GM_LASTBRANCH_FROM_TO }, > + { 0, 0 } > +}; > +static const struct lbr_info * __ro_after_init model_specific_lbr; > + > +static const struct __init lbr_info *get_model_specific_lbr(void) Please move __init: static const struct lbr_info *__init get_model_specific_lbr(void) Jan From xen-devel-bounces@lists.xenproject.org Tue Jan 10 16:28:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 16:28:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474819.736190 (Exim 4.92) (envelope-from ) id 1pFHUY-0002O0-Di; Tue, 10 Jan 2023 16:28:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474819.736190; Tue, 10 Jan 2023 16:28:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFHUY-0002Nt-A2; Tue, 10 Jan 2023 16:28:50 +0000 Received: by outflank-mailman (input) for mailman id 474819; Tue, 10 Jan 2023 16:28:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFHUW-0002Nj-N7 for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 16:28:48 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d7780029-9103-11ed-b8d0-410ff93cb8f0; Tue, 10 Jan 2023 17:28:45 +0100 (CET) Received: from mail-sn1nam02lp2040.outbound.protection.outlook.com (HELO NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.57.40]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 10 Jan 2023 11:28:34 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BL1PR03MB6152.namprd03.prod.outlook.com (2603:10b6:208:319::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.12; Tue, 10 Jan 2023 16:28:30 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5986.018; Tue, 10 Jan 2023 16:28:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d7780029-9103-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1673368125; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=2+qcYU4UZAVz66L4Kyc9H4n1d6XZgfoIpmG0t1Jr0c4=; b=fEfDqcpz7yOBN5xBeBUm2P9k471CqayzU0yIQNS1HiaQkwALBfrx3L9X w9J7s6fEWTXwQK/XMsTmFTipjJpAhsN2x6J4ED/U8fo0kEIS8FJbSa2no BgdHtGPf80AvPoQqIb3lmHHQ3LOXlq/O+s3jxf8LvMbYWccBPArEvihPj k=; X-IronPort-RemoteIP: 104.47.57.40 X-IronPort-MID: 92002746 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:38j9TqlkxtYV1tD8TzN9LYzo5gxRJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xIWUD/Ta62DN2KjfIgjaI2190sBuceHyt5qGQNq+C1kQSMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icf3grHmeIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aqaVA8w5ARkPqgS5QeGzBH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 cQCLTtXUzaDvPP10qC0QfZLrMQOKeC+aevzulk4pd3YJdAPZMiZBp7svJpf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkVM3jOCF3Nn9I7RmQe18mEqCq 32A1GP+GhwAb/SUyCaf82LqjejK9c/+cNNITOXiqaI06LGV7nFLECVVSEKXm+nnj3O1We9PC mJX4QN7+MDe82TuFLERRSaQonSJoxodUNp4CPAh5UeGza+8yxmdLngJSHhGctNOnM0rQ3os3 1yAndLsDBRutqGYTTSW8bL8hTC/JykTa3MDbCksTA0Z7t2lq4Y25jrfQ9AmHKOrg9ndHTDr3 yvMvCU4n68Uj8MAy+O851+vvt63jp3ATwpw/QOOWGugtll9fNT9O9Tu7kXH5/FdKorfVkOGo HUPh8mZ6qYJEI2JkyuOBu4KGdlF+sq4DdEVunY3d7FJythn0yTyFWyMyFmS/HtUD/s= IronPort-HdrOrdr: A9a23:UdxFhaofos3pBEv4+QSmJG0aV5oReYIsimQD101hICG9JPbo8P xG+85rtiMc6QxwZJhOo7u90cW7K080lqQV3WByB9iftVLdyQ+VxehZhOPfKlvbdhEWndQy6U 4PScRD4HKbNykdsS5XijPIcerJYbO8gcWVuds= X-IronPort-AV: E=Sophos;i="5.96,315,1665460800"; d="scan'208";a="92002746" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gKVNRsikJofMAuxFMCazZQ/8Cn9/k7LfAg8UNl43nd5X8advfHg2KUUyeQMes+Ds4wERlaNNF937U46CtjIih0g7Hq12P0mFuk0lbcqk3GoySCYEAH09uogdRS1dIZG/3uCS016SKX0PLLnNQhK1Fcxfqh8G3mIpJ0xzkDbZuVv2ue11HRdYVh1RX2GsJVJLtfHFFdR7Cukqhsj/LHORYNJYLXRGzyTnGrZJmM+9ETMtrzUEW/kESa4KdQPBXQgUKSXx7UdOPI+SHQlfu556ls/g1Hg9h9LlyXwTm9bg/E3YM2WfODQsiP2N47SxZXbK5k99SyJLBESjkSgySjbTyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2+qcYU4UZAVz66L4Kyc9H4n1d6XZgfoIpmG0t1Jr0c4=; b=nf/7FVjxemscHXp/rjCgDdwlEbsBMNLWqOFsM9LIPw2rqS5d9rq3K0sgMGT1P4ctKyZH5REVYyOQbE8II/UXylEDsSHXlw7hHkfaESF3/giWmjuZQuhI56grVvSjMKj30pQf6WWyFrAOjVsMp5GwAtH/dPLDWgYPtIFvb6Osaml/7CXf9XWVV+lly1drRgtZSei2pwWH1Tij267DkewcjsM0/+UpSXyArBhGYHs7xM52Y/z2sSR162D3vORnEXypmaV1h9cz0RL07tOqKB/zaHBbWUCcuqgFSev9jXIJ4mg4lHhhtwstZvle7WOiE4t+JZFa9Y8SKjR/Bo6j3jjIRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2+qcYU4UZAVz66L4Kyc9H4n1d6XZgfoIpmG0t1Jr0c4=; b=aF1By0RK4TPOhH44Z8LezJVJJ4k9czfJxV21bTbHrWg6+WrxziWtgCinRQpl9i/9vqqMd+KuzPtHTn/v465oV8C0e7N2iV0MO8epC3sLZ/RAf8cmRGtO8X9rGiGLz+obeVYNsNgK+ikOJoD4gezxSCcQJcvQbyoa8dtIRvkvTzw= From: Andrew Cooper To: Jan Beulich , Andrew Cooper CC: Roger Pau Monne , Wei Liu , Jun Nakajima , Kevin Tian , Xen-devel Subject: Re: [PATCH 1/2] x86/vmx: Calculate model-specific LBRs once at start of day Thread-Topic: [PATCH 1/2] x86/vmx: Calculate model-specific LBRs once at start of day Thread-Index: AQHZJCMapaYe8MLA1UOWoaXJDH0eEq6X2D6AgAAAnoA= Date: Tue, 10 Jan 2023 16:28:28 +0000 Message-ID: <433003aa-e3a9-b717-76f2-c62b0a31003f@citrix.com> References: <20230109120828.344-1-andrew.cooper3@citrix.com> <20230109120828.344-2-andrew.cooper3@citrix.com> <80b2ea4d-d52b-14c5-38ea-b8ab7e3a713c@suse.com> In-Reply-To: <80b2ea4d-d52b-14c5-38ea-b8ab7e3a713c@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|BL1PR03MB6152:EE_ x-ms-office365-filtering-correlation-id: 3051b1bd-e71d-42d8-3f47-08daf327b491 x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: F43vuGmoZAz64MIVsoTk7wHo3FQd+ndIKQS7AqLizJ8vW1scoUFNxTubdQQdph3ydHhF7oFZ3oZCTW+wXqE3gj/AEMhB0YKGqNA5eMG2Ac+E0cZNa9Mw26ugQy5/21sVvknURd3MBZQr9GLH1WH8Qk+JgjyWtBSpZwV1cYZVgjrg8anA80XkylEuJoHgrWqaoQ5T/dTKKcceaR1CrlGSpg/2kd8uM52fB1C2J02gLjhqVM57zfE/XAzM9Qo9UsNDos+mearAx6wJAw7OYME+SJsvzM6zuGWLZIBYpy6nOvkGSrsTygZaEgUQ3Y7551BF8mzDmGZA42aYuld2YonvxM9fzM/sDiyMki9al17odcXzYCP/tTvRfPucJCQRtn6RILzgI/dvr4nQaNxZBVVyOawVy4QoDzfE03KKbhkx8RBc9e93TZ2177816HpvLQ68in5IWCmDd+6suKt8F+x3OTtOysvBDhTn60RppTQTnrm/WmHy/QmD4oeYEFk8Fl1GmVb77WBiVXPl0olGwoICRHMpngrKga7431rGOMmqgebWh70Yws0m+cYfoZ31LQQyPKE1P273evk79dLcRy50MD2BgImwOfZyFXkunhXLiXT/HQhopqFuD7z/b3STqW4TGQ1tXqeqs4loaExxsN8vTTTcUcVikqoHC7a4FSlpbwIInej4gEwo04adw31VmMHkZh4+3pWgyjM0nhs9jzrkr0T+wjxV/Co3MIgEgyn5Bo8EH8Os/BRPEzNFMiFWxnHfh/MFJNwpf+gU/oz18UVE8A== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(366004)(346002)(376002)(396003)(451199015)(6512007)(26005)(186003)(53546011)(6506007)(31696002)(71200400001)(38100700002)(86362001)(54906003)(2616005)(316002)(110136005)(82960400001)(2906002)(122000001)(41300700001)(38070700005)(66946007)(66556008)(66476007)(66446008)(64756008)(4326008)(8676002)(76116006)(91956017)(5660300002)(36756003)(8936002)(83380400001)(478600001)(31686004)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SkFnbTZOTS8xYjV4TTBvTkdIRGk3RDFWZTBRWWNlKzVNQ05NTmFJa0JmbVpG?= =?utf-8?B?T3prbXh0cjFiTjZYMzJHWlI2d01iSHFYaklXWW1na3ZkTWtOMFpkMzRHbTR6?= =?utf-8?B?Mm51ejZtNXU4NHZ2ZlBkaU5hekhGOThXRWRpSnhIcTZxRFdjSDNzMjhzMlNo?= =?utf-8?B?cVgraXJkMDczUDc0SEhEUk1peWFUQzEvTkt5akkwUGUwMVJRdjRJZnUzSGNO?= =?utf-8?B?UVRnWGtSS3dBYStoM3dPaE53U05zak4yTHh5M3Y5SE5IQkxObDVuQ2p4TE9t?= =?utf-8?B?UE1LK09zNVhEczVlUnkzVmwycnhaV2RMd2FSNTM0MEZ3bG8wNm5PS2ozc1Qw?= =?utf-8?B?dzBoQ3JDWDhGeHRaamJNZnJiT1FiUWhubmt1WVFCQlN3ZEdEdXVoZzV5dFVm?= =?utf-8?B?ZmYyc3NkWm91ZnJhQUUxRVFxVE43aC9YVk8vWElrNm9qM0xIc1JHVG1zZkdk?= =?utf-8?B?bFF5bEJpUGgxTjZweVlTeGJORXVkZVNIbFlYL0llRG9VTlp2ZEJOS0I3V0N2?= =?utf-8?B?WmJqdkpXaWZZRkRKL29hSXhKVk5nRStNMkZKMmZMdzRwNDN5QVNJMS9EYmNs?= =?utf-8?B?cnlad3M3Y0VzQ3NCOUFpaWNMTG9NV05LRnBYMWNQbnJ1NDI3TEl3L1ZDekpD?= =?utf-8?B?STliMmgrZlVpaGtSZXVITFYxZndwdXoyc1hJdUpBMnc0bHhXejd2d3V4dU9B?= =?utf-8?B?Rzc3cEtWWFFHYm1DKy9mdFpySUJPSWwwb1NRTG9kL1ZhNHZOZjRwNWZjVjZu?= =?utf-8?B?T3BsZGpzVHV3VU9pT29HL3U2b084YXAvUEthdjZnVURodkgzQ3dKR1JmNHFp?= =?utf-8?B?UVplbUNhK2VJMGkxdjBhckJtMnVJcUNiVktXcmRYZysyZ0p4VFdMamlOUldZ?= =?utf-8?B?dVZRSzRQc08wZEpEMEg0cW5DZlUwa3pkSVdNcEtHSHZMNmo2NDZGR1dOSjZx?= =?utf-8?B?Y3I5RW4zOGJTeW8xakdRTjduZkZRQ0NYRWZvRGJFRVFzM1FaYmxFYS9YYXpt?= =?utf-8?B?VjU0UndBYmVSd0hkZWlINnc5OGZnUlhDNnAweHZoSlYwMkZ6OElYbWE3NTVM?= =?utf-8?B?Rys3TldjL1BGZ3hZYzZqWGNSZmZvWk1tcUVza0IzcDlJYmJxSjBHS3ZaOTFr?= =?utf-8?B?d3FzdmF4UitDYWFUUE51SzB3bXZRZngycEhRNDRpTFJzR0kvM2VZUXR2WEZD?= =?utf-8?B?K1RSQTJDTDE3aHNaVmRFMUdvVWJ3d0YyTHU1QTduOUh1Mjd3eGg0M01VTWRV?= =?utf-8?B?OTBIdVJZNE5JdVFxaUtFTjFtcUxjWGNSdHdCVjhPN0M4N0lVazRLaDJLelFs?= =?utf-8?B?YVpGSUpGR2kwdzdXaHhoRHVLZ0dKa2N4MXJNT1VqdkpwNXhpK1dlSHVRY240?= =?utf-8?B?U1lhL2N4UlhzcUVya205aEpYQVlSSnozNG9ZaU0zUFN0TDUya08zVjQrRFBv?= =?utf-8?B?a25yTDdUQW1MNDBOUGNObEZMY0U3TWtudDhDWXQ5WlpybStNU2w0NHMvNEli?= =?utf-8?B?Skp3ZXptL3Y0eUpGeHV0V1FFazF1VEhBM1RGaGRLcUZGQmJ6Vmk0ek5HVCtZ?= =?utf-8?B?ZXB6cTVaNnJiRzdlOW56NzVobFh0NVJkK2sybi9FSzFEZUFucDZLTHgyNlFl?= =?utf-8?B?OU04WXlNc3Z3MGMwc2o3WVhLSEVyaTQyMHFmSkl1RktwR2VJanRXQSs3cFFJ?= =?utf-8?B?VUJKbi90QVJ0Q09WeU42enFibUhsSklsOEIvRUpsU1UyaUEvKzlZcVJiYStD?= =?utf-8?B?U3VtaFZtVTVXWDMzOVQxcFRaZVM1ZGhqK2RQU3lLVUt6YWk5MktmYUF5c2xQ?= =?utf-8?B?bEJaZnB4NnNlWkZaK05VTFNmeW9YVEhLbENWSjJiNVdUcGVEdXA3TGY0Z2xV?= =?utf-8?B?WW1kV3cwMGVwQjdOdm42SGJaOTR5cm5MREZZZlVsQkdGZkF4MVdmQ3F5S1pR?= =?utf-8?B?T28rYXBZSnJuYkxLYzk3RHlqRzkxRDQwTGpmYmhCaVYwRXpuY09xaDdKaFcr?= =?utf-8?B?bmJsK2NmenBHSG0zU0ZlcHZVYm4xZjJVaThhZDZCUUJrOVNoMXNwZHRqWS9Q?= =?utf-8?B?eUowbXpENjVJSUhoTjQ4YWZaeXlPcVZ3dTRuWDNsMGJMajROS2dpRjlTNTRB?= =?utf-8?Q?OZYFccdLwPmng+PNqPbP03ZFD?= Content-Type: text/plain; charset="utf-8" Content-ID: <852B1E7D7C17AC468791B1F49CE3F942@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: pF6Fzb0BOBtQRtC2KwF3R6X4K8GzZrVyxMg1Mm3prZRq0pZq3C7zoF5rWi2HUPsbGaKq8Gv4HEe3RTQK8wP/4B5wJ8M0oN0d4kUGV7hJ8A1e2+rPjIdel4gv0bvLhXR86fNDYpm4HGGgfW2123xGgkF1+8gijp918ot1R6O1X2SlWBnQjJYM7v5BvUbz2LGeAC+9CZxJS3MHAeXQQmwjL1BMGAcdbuKcWNPlaAJJ/0NYFwmQvT/C9boLTR7VYc0gqWThdFwz0BqewUaQPosPnkm/BWYLX1nS7nkpahCyhI6nMi7mp9EtOhZtTXVI2tBg/c2jP44Yh6RdbCVCzRmmIfbpp7e3GGJYMFi9w1CRyqFcD5DxNFAw+z1RHx76Be6RI2itmQIFLVd03GOY7SZUmctJhlWP3Vy9fWOHy4P5lbBdWwioUXfmHtwO+KmlNAXtiaG0cTuuh3VoZPI+f+j4MkUZYUkaLdXlLF9AVh0pt+SppCHlBwn0vFz7qNVzs13nXneWsnTgEVqw/hZwfR+oD2UvHKI4lw8+OnT3lICujGxJhuTYg+YuqhEMtlV9ydNlHBMWkBFDl/quUgmiTmuheBs4qX8TWaKOy1fSfgbsjBhV8ya9A6uCD4eLCS/KEB/lE+6dH/OESnmcATzz11yTJYRIgs0Dc387DdBw4OfR0lsPtM5hvUidfnaY5ru7a3WT2GHT9Euf78e0duHEtbvsPjqTEBrWKjkYYtwJEbR1naqO3r4KA72Q7LvF8S4PKPzpTIjbjZoWEPCXuyv91vpY0w9JxZdOCaldzygGnrwdgRlnMzeI6swtEHE1C5/VGkoLEDdQEuQ9VMB290AawRpdl5PVWFKE3WX2PdOXx+vtrq0= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3051b1bd-e71d-42d8-3f47-08daf327b491 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jan 2023 16:28:28.4569 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sXPl21UYC0HtA2lVbGt2Azk93qhqmMczRSa0SaSlTxIHaLrFzLZFRmZ+puZGgZYWMExwqYqEXcSKwCX1vakRLTRw2e/iBv4yHUwIszg2zsI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR03MB6152 T24gMTAvMDEvMjAyMyA0OjI2IHBtLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMDkuMDEuMjAy MyAxMzowOCwgQW5kcmV3IENvb3BlciB3cm90ZToNCj4+IFRoZXJlIGlzIG5vIHBvaW50IHJlcGVh dGluZyB0aGlzIGNhbGN1bGF0aW9uIGF0IHJ1bnRpbWUsIGVzcGVjaWFsbHkgYXMgaXQgaXMNCj4+ IGluIHRoZSBmYWxsYmFjayBwYXRoIG9mIHRoZSBXUlNNUi9SRE1TUiBoYW5kbGVycy4NCj4+DQo+ PiBNb3ZlIHRoZSBpbmZyYXN0cnVjdHVyZSBoaWdoZXIgaW4gdm14LmMgdG8gYXZvaWQgZm9yd2Fy ZCBkZWNsYXJhdGlvbnMsDQo+PiByZW5hbWluZyBsYXN0X2JyYW5jaF9tc3JfZ2V0KCkgdG8gZ2V0 X21vZGVsX3NwZWNpZmljX2xicigpIHRvIGhpZ2hsaWdodCB0aGF0DQo+PiB0aGVzZSBhcmUgbW9k ZWwtc3BlY2lmaWMgb25seS4NCj4+DQo+PiBObyBwcmFjdGljYWwgY2hhbmdlLg0KPj4NCj4+IFNp Z25lZC1vZmYtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+DQo+ IFJldmlld2VkLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+IHdpdGggb25l IG5pdDoNCj4NCj4+IC0tLSBhL3hlbi9hcmNoL3g4Ni9odm0vdm14L3ZteC5jDQo+PiArKysgYi94 ZW4vYXJjaC94ODYvaHZtL3ZteC92bXguYw0KPj4gQEAgLTM5Niw2ICszOTYsMTQyIEBAIHZvaWQg dm14X3BpX2hvb2tzX2RlYXNzaWduKHN0cnVjdCBkb21haW4gKmQpDQo+PiAgICAgIGRvbWFpbl91 bnBhdXNlKGQpOw0KPj4gIH0NCj4+ICANCj4+ICtzdGF0aWMgY29uc3Qgc3RydWN0IGxicl9pbmZv IHsNCj4+ICsgICAgdTMyIGJhc2UsIGNvdW50Ow0KPj4gK30gcDRfbGJyW10gPSB7DQo+PiArICAg IHsgTVNSX1A0X0xFUl9GUk9NX0xJUCwgICAgICAgICAgMSB9LA0KPj4gKyAgICB7IE1TUl9QNF9M RVJfVE9fTElQLCAgICAgICAgICAgIDEgfSwNCj4+ICsgICAgeyBNU1JfUDRfTEFTVEJSQU5DSF9U T1MsICAgICAgICAxIH0sDQo+PiArICAgIHsgTVNSX1A0X0xBU1RCUkFOQ0hfMF9GUk9NX0xJUCwg TlVNX01TUl9QNF9MQVNUQlJBTkNIX0ZST01fVE8gfSwNCj4+ICsgICAgeyBNU1JfUDRfTEFTVEJS QU5DSF8wX1RPX0xJUCwgICBOVU1fTVNSX1A0X0xBU1RCUkFOQ0hfRlJPTV9UTyB9LA0KPj4gKyAg ICB7IDAsIDAgfQ0KPj4gK30sIGMyX2xicltdID0gew0KPj4gKyAgICB7IE1TUl9JQTMyX0xBU1RJ TlRGUk9NSVAsICAgICAgIDEgfSwNCj4+ICsgICAgeyBNU1JfSUEzMl9MQVNUSU5UVE9JUCwgICAg ICAgICAxIH0sDQo+PiArICAgIHsgTVNSX0MyX0xBU1RCUkFOQ0hfVE9TLCAgICAgICAgMSB9LA0K Pj4gKyAgICB7IE1TUl9DMl9MQVNUQlJBTkNIXzBfRlJPTV9JUCwgIE5VTV9NU1JfQzJfTEFTVEJS QU5DSF9GUk9NX1RPIH0sDQo+PiArICAgIHsgTVNSX0MyX0xBU1RCUkFOQ0hfMF9UT19JUCwgICAg TlVNX01TUl9DMl9MQVNUQlJBTkNIX0ZST01fVE8gfSwNCj4+ICsgICAgeyAwLCAwIH0NCj4+ICt9 LCBuaF9sYnJbXSA9IHsNCj4+ICsgICAgeyBNU1JfSUEzMl9MQVNUSU5URlJPTUlQLCAgICAgICAx IH0sDQo+PiArICAgIHsgTVNSX0lBMzJfTEFTVElOVFRPSVAsICAgICAgICAgMSB9LA0KPj4gKyAg ICB7IE1TUl9OSExfTEJSX1NFTEVDVCwgICAgICAgICAgIDEgfSwNCj4+ICsgICAgeyBNU1JfTkhM X0xBU1RCUkFOQ0hfVE9TLCAgICAgICAxIH0sDQo+PiArICAgIHsgTVNSX1A0X0xBU1RCUkFOQ0hf MF9GUk9NX0xJUCwgTlVNX01TUl9QNF9MQVNUQlJBTkNIX0ZST01fVE8gfSwNCj4+ICsgICAgeyBN U1JfUDRfTEFTVEJSQU5DSF8wX1RPX0xJUCwgICBOVU1fTVNSX1A0X0xBU1RCUkFOQ0hfRlJPTV9U TyB9LA0KPj4gKyAgICB7IDAsIDAgfQ0KPj4gK30sIHNrX2xicltdID0gew0KPj4gKyAgICB7IE1T Ul9JQTMyX0xBU1RJTlRGUk9NSVAsICAgICAgIDEgfSwNCj4+ICsgICAgeyBNU1JfSUEzMl9MQVNU SU5UVE9JUCwgICAgICAgICAxIH0sDQo+PiArICAgIHsgTVNSX05ITF9MQlJfU0VMRUNULCAgICAg ICAgICAgMSB9LA0KPj4gKyAgICB7IE1TUl9OSExfTEFTVEJSQU5DSF9UT1MsICAgICAgIDEgfSwN Cj4+ICsgICAgeyBNU1JfU0tMX0xBU1RCUkFOQ0hfMF9GUk9NX0lQLCBOVU1fTVNSX1NLTF9MQVNU QlJBTkNIIH0sDQo+PiArICAgIHsgTVNSX1NLTF9MQVNUQlJBTkNIXzBfVE9fSVAsICAgTlVNX01T Ul9TS0xfTEFTVEJSQU5DSCB9LA0KPj4gKyAgICB7IE1TUl9TS0xfTEFTVEJSQU5DSF8wX0lORk8s ICAgIE5VTV9NU1JfU0tMX0xBU1RCUkFOQ0ggfSwNCj4+ICsgICAgeyAwLCAwIH0NCj4+ICt9LCBh dF9sYnJbXSA9IHsNCj4+ICsgICAgeyBNU1JfSUEzMl9MQVNUSU5URlJPTUlQLCAgICAgICAxIH0s DQo+PiArICAgIHsgTVNSX0lBMzJfTEFTVElOVFRPSVAsICAgICAgICAgMSB9LA0KPj4gKyAgICB7 IE1TUl9DMl9MQVNUQlJBTkNIX1RPUywgICAgICAgIDEgfSwNCj4+ICsgICAgeyBNU1JfQzJfTEFT VEJSQU5DSF8wX0ZST01fSVAsICBOVU1fTVNSX0FUT01fTEFTVEJSQU5DSF9GUk9NX1RPIH0sDQo+ PiArICAgIHsgTVNSX0MyX0xBU1RCUkFOQ0hfMF9UT19JUCwgICAgTlVNX01TUl9BVE9NX0xBU1RC UkFOQ0hfRlJPTV9UTyB9LA0KPj4gKyAgICB7IDAsIDAgfQ0KPj4gK30sIHNtX2xicltdID0gew0K Pj4gKyAgICB7IE1TUl9JQTMyX0xBU1RJTlRGUk9NSVAsICAgICAgIDEgfSwNCj4+ICsgICAgeyBN U1JfSUEzMl9MQVNUSU5UVE9JUCwgICAgICAgICAxIH0sDQo+PiArICAgIHsgTVNSX1NNX0xCUl9T RUxFQ1QsICAgICAgICAgICAgMSB9LA0KPj4gKyAgICB7IE1TUl9TTV9MQVNUQlJBTkNIX1RPUywg ICAgICAgIDEgfSwNCj4+ICsgICAgeyBNU1JfQzJfTEFTVEJSQU5DSF8wX0ZST01fSVAsICBOVU1f TVNSX0FUT01fTEFTVEJSQU5DSF9GUk9NX1RPIH0sDQo+PiArICAgIHsgTVNSX0MyX0xBU1RCUkFO Q0hfMF9UT19JUCwgICAgTlVNX01TUl9BVE9NX0xBU1RCUkFOQ0hfRlJPTV9UTyB9LA0KPj4gKyAg ICB7IDAsIDAgfQ0KPj4gK30sIGdtX2xicltdID0gew0KPj4gKyAgICB7IE1TUl9JQTMyX0xBU1RJ TlRGUk9NSVAsICAgICAgIDEgfSwNCj4+ICsgICAgeyBNU1JfSUEzMl9MQVNUSU5UVE9JUCwgICAg ICAgICAxIH0sDQo+PiArICAgIHsgTVNSX1NNX0xCUl9TRUxFQ1QsICAgICAgICAgICAgMSB9LA0K Pj4gKyAgICB7IE1TUl9TTV9MQVNUQlJBTkNIX1RPUywgICAgICAgIDEgfSwNCj4+ICsgICAgeyBN U1JfR01fTEFTVEJSQU5DSF8wX0ZST01fSVAsICBOVU1fTVNSX0dNX0xBU1RCUkFOQ0hfRlJPTV9U TyB9LA0KPj4gKyAgICB7IE1TUl9HTV9MQVNUQlJBTkNIXzBfVE9fSVAsICAgIE5VTV9NU1JfR01f TEFTVEJSQU5DSF9GUk9NX1RPIH0sDQo+PiArICAgIHsgMCwgMCB9DQo+PiArfTsNCj4+ICtzdGF0 aWMgY29uc3Qgc3RydWN0IGxicl9pbmZvICogX19yb19hZnRlcl9pbml0IG1vZGVsX3NwZWNpZmlj X2xicjsNCj4+ICsNCj4+ICtzdGF0aWMgY29uc3Qgc3RydWN0IF9faW5pdCBsYnJfaW5mbyAqZ2V0 X21vZGVsX3NwZWNpZmljX2xicih2b2lkKQ0KPiBQbGVhc2UgbW92ZSBfX2luaXQ6DQo+DQo+IHN0 YXRpYyBjb25zdCBzdHJ1Y3QgbGJyX2luZm8gKl9faW5pdCBnZXRfbW9kZWxfc3BlY2lmaWNfbGJy KHZvaWQpDQoNClllYWgsIEkgbm90aWNlZCBhbmQgZml4ZWQgYm90aCBzdHlsZSBlcnJvcnMgaGVy ZS7CoCBBbHNvIGFuIGV4dHJhbmVvdXMNCnNwYWNlIGJlZm9yZSBfX3JvX2FmdGVyX2luaXQuDQoN Cn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Tue Jan 10 16:28:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 16:28:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474820.736201 (Exim 4.92) (envelope-from ) id 1pFHUf-0002gl-OK; Tue, 10 Jan 2023 16:28:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474820.736201; Tue, 10 Jan 2023 16:28:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFHUf-0002ge-LW; Tue, 10 Jan 2023 16:28:57 +0000 Received: by outflank-mailman (input) for mailman id 474820; Tue, 10 Jan 2023 16:28:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFHUd-0002Nj-V0 for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 16:28:56 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2042.outbound.protection.outlook.com [40.107.7.42]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id df73bbd6-9103-11ed-b8d0-410ff93cb8f0; Tue, 10 Jan 2023 17:28:53 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB7087.eurprd04.prod.outlook.com (2603:10a6:800:12a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 16:28:52 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5986.018; Tue, 10 Jan 2023 16:28:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: df73bbd6-9103-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C8sPbhbivOcO48IZOunKrVoXUbPtEvavt5C2gCaqRRyQ5o+9QWHRmFMXU6nDVXju5a/GNiHl5eOsgt8Qsryl0tYN4jBZgyTfCthDxrNuUADebKQJJngTx8GFBTu/QgECT2a8zkiM49SWlvY3XJ7dz3fHji6R9Zs2KCyeQQKdJQugf6wYS/oyMHER8brc9BlywtqMgpHvPbddCw1KdIjAO8Ut+fPlTyfZSb7b1y7vnFYgLx0MvG94TEZKlupNX66n4oC7MnS0jwkP1NJPK/q33P7PuzL/lOKm9VEq5oJr3GyzUMCFuqDSNP9HGeJ3Pnx9v4P7tDBFSy3JmDx+G5KTWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YIVMyZpviGvd+DtKXNdgcxEVV4JpxCQF5jkJDsFuoPo=; b=SD+3gfL3bG2rmDnX2+k9MnMeQ2JWEy/o4qcOlnKjcxJvOjntBdeznBOItERC/lnUVruW2S56RkeCXovlNnp4Yz2lCexoxV1ghoNq01xGk9VsvIst9NIF/NR8Al0gUdOEcNLi9o53wSBz/c2LcL7yVkLwCLxZeSucwys+G13+9Y8ViHK5VS6NxeU3mv84pND0lv27IaDtpaxBIPQGPTrs/d2hN+oMbhpgALDg9Yuv7sAdntSd6f4ZzPJAPliM2OiyxKZoMIMPLoWsMxlM13fsz4kfVQ7RYcoP21Elsa0AfhmHnYw3sxZD/1vbBv2KZGEWUZ+4DJozo/nkuSx8zFRSCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YIVMyZpviGvd+DtKXNdgcxEVV4JpxCQF5jkJDsFuoPo=; b=HCLWSd55e7/87mVXyknnvWG0moy4DL4x8GAsH4ekoy6sx5+l8FfnquwtuXT4VNcUVg8oR14iPpMcFpAVXGsXrfau4JEbF4zDNr3SlvA4CyPbepTQ8HliyBcFk3rrYJZnsN10w2MBjN4huV44FNIqfdDcmZ7Lo4mGPRkvuSuvfaK3kwSJII5w9Q0k0fMdVSrpIxqnOryMV9iQsDuQmZmRb3GZcoNtremeXzcAg3UpL0BHzOIGStu/Oe9fR3hFtGmn1kiPrZnFxotfM3GarzT5uv4R+NGWLYkEEXaz0juGr9O4qioB2OmhKmc5cMVY5DzDRyxWBLg4mM+4l6G5c55W4A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 10 Jan 2023 17:28:50 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 2/2] x86/vmx: Support for CPUs without model-specific LBR Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Jun Nakajima , Kevin Tian , Xen-devel References: <20230109120828.344-1-andrew.cooper3@citrix.com> <20230109120828.344-3-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20230109120828.344-3-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0094.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a9::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VI1PR04MB7087:EE_ X-MS-Office365-Filtering-Correlation-Id: 82541215-5bf8-4f39-97d2-08daf327c26d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WeCwC7iO+TZIFyhKzLqwbXZYUZykVRkzbPc+KShMmDHyLZ4w3hZ2ANLRG1ruP0j0Gxtrzk8DD9U5Pwsyj9WtOaVfcsWDIJIYMYKK4elaT+dsuEGLn7Zgz5xQRHfMq+GMAdWPs4rQp3nZXygTtQiQFuhwpIjWXrUgSaMxdqBmm67Q9GPEexYPhBpFYBaEn9FWR4w6w9Vc4AnayE8mWsVvFV+RMRx+7hyPaHCu8nBT8LgclO1WTGDBX/z/a+pV7epowM0NOTxZGXfSgisUisT8dvexYrLEB6l7f+6NvvsTYqxfEWcNgLmYkacEHiCyiOVFgmoov3fvTGadh/09lvx+entjBWvitUuE31z0O7Z0a8yMdvycaru6Gmpw50VkYPPudhUsazOYP2bP5u3nYCeF5g/2HLySTq6lhv4EyG22+guceOAq24lN08JTUJzjPMrqnNaPfSy9impbfimI5NdzG7Ej6r5kzo0hhultNy3bPberNSRovXUNdbPBX9eSDMIM2vvw99ux2yq1Nu7+pv7P+q9dy9Foo9ZUvDfuEXKHsWT6QrPLY7jh30zSwrnCsenuwEN6jRAaHBMT0bgY7yEPPrW1Qn75AuOxL2xbi037ActV89oSM2YulCOiU7zPTz0NKj7sgl3kI9Gq+BKOzGL/JSJdjjj26d8wZ+kUfidvHalxkSk19l1fWr73gZtUsQ/2XbDbBIIk8xyAQALGor0b204fvcX7ICpzCI/wKtFVhBE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(366004)(39860400002)(396003)(376002)(136003)(451199015)(8936002)(2906002)(5660300002)(41300700001)(4744005)(4326008)(316002)(6916009)(8676002)(66556008)(66476007)(66946007)(54906003)(26005)(6512007)(2616005)(38100700002)(31686004)(86362001)(186003)(31696002)(36756003)(53546011)(478600001)(6506007)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L2dPbmNnNFRCQmdwWk1vNDRBYXZMSXk0K3IwSVdGZG1KNE9yK3pwV1JUeDFR?= =?utf-8?B?NWU0QXNHTU9CVlpTMzYxN3ZsOEtxbEp5bFd2UkN1cDRMTG5TU1hWS2diRmNn?= =?utf-8?B?TXFxaEJiUkxNT01pZTBQRm12NFdPNVZ6SmxoT25HaXZhYnA4eGNUNWcxaTZh?= =?utf-8?B?OWZMSi9rZjAvYVU2c1pUNW5wRVgwVXFMdm5uTG9SMTJkK3Y1Z213d0JycFZn?= =?utf-8?B?SG0raThMejlhTm1mNC9pSitSMFhFbC9kSmRZRWRveXNUcjc3M0V6YlZuSXpY?= =?utf-8?B?M2cyTEpCU3JmMWJyRW9NYjZ6bzJqb2x0SkdhcWFSNzlTNkdnUmRFdXpJWXo0?= =?utf-8?B?UVYydmp1YjFuR0RYWCtWSWN4eWZDNUQzcTNLbFA4dFdSZ0tGRC9YejRmSldz?= =?utf-8?B?bE9uaS9yRDVzZ2NPM1dLWEpRMUx4VnlobDVWR25KY3dIWStaU2J6M3JjVVg5?= =?utf-8?B?Tm8wbU5GL0kxS29mVEhBenNyUUg0L2o2WjFDdWZ5Zm5SU0dtQ1RjY1dMU1BP?= =?utf-8?B?UkJlRHVLdUZTc0NsUDBMN2d3aEFtWFlHV3NEbkV1VnpQYk5sN0V6NG5tbFds?= =?utf-8?B?WW81MGgrOUdJOE1RYlF4RzNacUlSLzFSOEdnb29KVGJaQkw0ZnZLY0FFRWVN?= =?utf-8?B?R2RsYWttVnV0M3VwL09FU001a1c1cSsxOGsxM3RpY3VGeml0WHZnZTRPVUt1?= =?utf-8?B?NjMvNERxc0wyT1p2QTZDbzAxbFU4V2JlLzBqeldYUThGQ3hNN2NlTUdQUjdE?= =?utf-8?B?RmFvdXFlTkxpNzFlL21WeDRIb2pJeSs2OWJSNVgzU1F1VWF0c0I0Y1dxWkQ5?= =?utf-8?B?WFl4KzVlVnhjbnYrZFVxSCtqRy9yM3hrVzRKMms1STRFbk05OFZ4ckxtRWFa?= =?utf-8?B?T2kxZUYvbTRVc3FsNnJ4ZmxSTDkzZjRqRldTdjZiQ3o1WDNUT0JiVTduUzJZ?= =?utf-8?B?WnJBNThvbmRLdHA3WWZKTWZwRjAwa3h6MWl2ZEtBeGdmampIQ3AxZUhxODJ3?= =?utf-8?B?WWQ3Tno4eHRuSFZwZG5sTVRBQlRYMW52bEhYeEx3SzY0ZXV3RUVrbnllZHpF?= =?utf-8?B?YWdOQ2dmbXZuNm5EZ215VWtreC83bDQ3WW1QZTJtbHViVVBRTmJNc1NRUWc4?= =?utf-8?B?WHZjalVWSFlrdlR1RGUyUysyWVZWK2RwYmF6KzVEdk5oVVM5WjhubXNScVNy?= =?utf-8?B?S3c1VjVjdzVhZHdISWR0dktqeEVCM09md1JDdTE3ZGIrbmRDQy9IUGpOUGJJ?= =?utf-8?B?UXVsQU9hd3NTeXVUendKVmxBSmYzb0ViMXQzSVVWM1I1MHRsVnRiVDBJU0Nm?= =?utf-8?B?azdIMmRHaTFnR09ZM3VyelJSdXY0ZlA1TFZkVW9FUDg1RGMrV1dNN3FxSXpW?= =?utf-8?B?UXJOelQrUG50NE1IeEcwTVROTE50dko1VWplMDY0SmhIb21pS1BqZWFHU1FN?= =?utf-8?B?S1Z5NFJGK3Z4ZmJtMGhEbHdaZUtmQXlVVXZMOTZBS3djUWFzb0hZdkFHSG1S?= =?utf-8?B?NEtxcU5Jd2d5LzFVTUx4MHZDK2U1SFpIaFkzU0Q5OHNOb2tJMkc0QXJ2UnF0?= =?utf-8?B?bzg0ZVhLOTl0ekhBWENEbHI0TURnK2p1T0JsZnRIV1BpSlZwUzVnQjVWbmNo?= =?utf-8?B?aG1xR3k0QTg3d292cXE5clRCcHZYNlo0MXRXWWhURHIyK2ZJZzNLcWZTN1Mr?= =?utf-8?B?MzRubHh3TDAzQkIxU3lYbkdZaStlVDBrbkM2ejRHbmZ4eFBNazgyalVQUnRF?= =?utf-8?B?MW85RXJnNTNGeVZxclc4bnpraHRqNVZka0FIQ3lIa0gySW5PeUVZU0pMTEhm?= =?utf-8?B?cVNOdVZlTEF1UThMUkhMajNwamtzLzFhMmcrajJpd1QvOGVLTForLzhWcGNF?= =?utf-8?B?MjJNSmdoSnFPZ3BMRXpCTTVyYnJ3NGk1NnF6VDByMlJqK09OeGpoRlBvTnhB?= =?utf-8?B?YmdCQXRLTUhsOTFUUGVDeTRGeS9jRFREb1hLdzg3U01aM3g2YlVBVG9EOFFl?= =?utf-8?B?RkZUSk4wdVZpV0JudW5Tc0FjbVJ0NlJLNWRQUUlWY3ZVUXIyZTFRaXVNK09S?= =?utf-8?B?QXBLOUl3ckJINStFcUl5YkFra3FGRnI1YTdLNXVzWU1leVEvMTd6TGVHSU80?= =?utf-8?Q?VCjOHm8sgCaePcnK4mhMfRxzO?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 82541215-5bf8-4f39-97d2-08daf327c26d X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2023 16:28:51.8832 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 34psCZcaThLG8CiW7Bzj/dfDuT7FO91r15ijWZxfoEtPAR3XV9mfQFd6IufBoxpovf5vV5wKaGwHlnMswAUnbg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7087 On 09.01.2023 13:08, Andrew Cooper wrote: > Ice Lake (server at least) has both Arch LBR and model-specific LBR. Sapphire > Rapids does not have model-specific LBR at all. I.e. On SPR and later, > model_specific_lbr will always be NULL, so we must make changes to avoid > reliably hitting the domain_crash(). > > The Arch LBR spec states that CPUs without model-specific LBR implement > MSR_DBG_CTL.LBR by discarding writes and always returning 0. > > Do this for any CPU for which we lack model-specific LBR information. > > Adjust the now-stale comment, now that the Arch LBR spec has created a way to > signal "no model specific LBR" to guests. > > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Tue Jan 10 16:37:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 16:37:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474832.736212 (Exim 4.92) (envelope-from ) id 1pFHdH-0004WR-Ie; Tue, 10 Jan 2023 16:37:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474832.736212; Tue, 10 Jan 2023 16:37:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFHdH-0004WK-Ez; Tue, 10 Jan 2023 16:37:51 +0000 Received: by outflank-mailman (input) for mailman id 474832; Tue, 10 Jan 2023 16:37:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFHdF-0004WA-EH; Tue, 10 Jan 2023 16:37:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFHdF-0003rW-DE; Tue, 10 Jan 2023 16:37:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFHdF-0000J4-1c; Tue, 10 Jan 2023 16:37:49 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pFHdF-0005PN-17; Tue, 10 Jan 2023 16:37:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ld/FBqqdyPjBtfa6Zipt83I+c+IhUAJgw1P7URAlTvc=; b=gvyJNkxhlViGva/ywSY9+5rmAy Nn5FsEZEK/V2u+irGJjuYMqVX7YKqW2TC3ECqTHKAihh3Z5haoANJACdzk5+dlKVSfH1dhgd1wNyM CXRwNEzV1SrXnsWgCZmVvEywdE+YuaKy7xH4nBi2sDS7n4ThyC5I+Lwwb4ukGHwOCNqc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 175702: all pass - PUSHED X-Osstest-Versions-This: ovmf=717f35a9f2d883a74998f7deb3d2cdf95bddf039 X-Osstest-Versions-That: ovmf=82dd766f25225b0812bbac628c60d2b48f2346e4 From: osstest service owner Date: Tue, 10 Jan 2023 16:37:49 +0000 flight 175702 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/175702/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 717f35a9f2d883a74998f7deb3d2cdf95bddf039 baseline version: ovmf 82dd766f25225b0812bbac628c60d2b48f2346e4 Last test of basis 175686 2023-01-10 06:40:46 Z 0 days Testing same since 175702 2023-01-10 14:40:41 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Moritz Fischer jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 82dd766f25..717f35a9f2 717f35a9f2d883a74998f7deb3d2cdf95bddf039 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue Jan 10 16:38:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 16:38:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474836.736222 (Exim 4.92) (envelope-from ) id 1pFHdb-0004v7-QG; Tue, 10 Jan 2023 16:38:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474836.736222; Tue, 10 Jan 2023 16:38:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFHdb-0004v0-NV; Tue, 10 Jan 2023 16:38:11 +0000 Received: by outflank-mailman (input) for mailman id 474836; Tue, 10 Jan 2023 16:38:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFHda-0004ta-4B for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 16:38:10 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2071.outbound.protection.outlook.com [40.107.6.71]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 29d26e67-9105-11ed-91b6-6bf2151ebd3b; Tue, 10 Jan 2023 17:38:08 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB8048.eurprd04.prod.outlook.com (2603:10a6:102:c4::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 16:38:06 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5986.018; Tue, 10 Jan 2023 16:38:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 29d26e67-9105-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HVJo87biQRb3gIcZULgx52UfzVo2zJWsn+kRGQBsCGXivOQr9fipfs9p5doVHk8SV5NKLQB3thYMfXSb90Cg1qJJiT1HO4GQP44HaZ6tAB4m3by76BLeNNRAX02bpdKSUjfwMvDqKPC5VlFCvElYtbtSAwRMmHhEbThjaUsO6O/ezzoZlFAEkmzuXL0cN/q7N/cyfQYrbERLZFY1w69yvQ5w1NZQR9YJwBjw21e5gzS84lZFqBXaz4vN+xeGdsxqjiEZ6JLq1tp4PNkYZDeNohqGpXxcFV25RCPPG60AMO5h4xA5RvD3+VvLiMXGHtyRD6ojaJpbfWZlRFOl68mIxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zCkOyY0jrVWt+HO5L1tUBGiWYJiPHwjxrjh8Tz7gjjc=; b=h4v5CcAF784LOKKT2eAqpP49Xskv7HkQS992tbzz1kHye+1tL8UY73Narsrblv0d/0+6TPxC7S8e1qEXsJ+kgAJE9vaLchsE3d91KA4NlxSARBjsRDohsooTwyYAcaEx8PBoP8V8fA9LmSfYbsD9aou8kgNMaMYqQfIenDzGk1qL3ZPA2rpyzLi5OhCbC+vFoNKteTfFNRiNawzNNLYO2mtciNQuLiqIO4w0MiMatpXPq9L7hep2Rd03o7UZZ0F/KzKnpw3PAYJR0P476XmVSvVPgSBfdXHra3v4dcstXoHgrjthx4jN562gZUz9NMC52ZO6jOwRPBc0wRbFEDDfKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zCkOyY0jrVWt+HO5L1tUBGiWYJiPHwjxrjh8Tz7gjjc=; b=ceUicv+mgLVAfCBk6ahpvCcI1ENvx7k7+gbQBECuVhGLxg/uAVrqpP1BAYKkHK+7EbY4vJxuRSgJ9oCLe/cln7ZkQscGBKspX7aPWiTC7kz59Cd1qlLPC/M7zbHWvQK64JjWwBCqgiXtIxAYmZ3xIicmpI/G+PQpW9YSh6ld/gQIJ4FoL9DL1A6ZNQVhoRBjBmRAcB/IzatQxeVVG2258lbX0x/6dRnpD3oBinnifnJZH8xqEH/IeyIcUY0/OnH7J8LQzBDg9k8LOV2wAbX6jTJenRb0QcdsSgP5ffe5J65zfb/IWxpjwV70wpGBAT0AqjaGCBftZStIUyU43yeM+g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9e32ffa1-1499-f9cd-7ca8-f9493b1269cb@suse.com> Date: Tue, 10 Jan 2023 17:38:03 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 02/17] xen/arm: implement helpers to get and update NUMA status Content-Language: en-US To: Wei Chen Cc: nd@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20230110084930.1095203-1-wei.chen@arm.com> <20230110084930.1095203-3-wei.chen@arm.com> From: Jan Beulich In-Reply-To: <20230110084930.1095203-3-wei.chen@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0154.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:98::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB8048:EE_ X-MS-Office365-Filtering-Correlation-Id: db4e456d-7419-4215-139f-08daf3290c86 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KyS4bCLfEWqUCkvFbLru780/hpq16fmj7CDKtBHdPjUMpzTRgVB8O2t5MFdmANTJkDE3s7oD4Q6zdIexQli34vC2Gy46qfzLz5sxktdfvR5YOWDXSGSpFQnPiOTuQ6Rj2fYC+WJlVN3bh6emD/YhGEkrCyP/KjUhY953kkmkp878+CrWr9gVZ89BSk6K0slnws2DiVysbcPiu3kheeH1EcgNflhcaIaLtHHO2oYFxeEmTSrH/bXJc/EIntbDlxgAYr3WugBXWDaSGzVsSJtNr+ogym4J2MmQ3yFll6ofIH8ITEWj6e7RmN/OAkCCG1WO2fNtO0a0zj4YZyZz4R5+gXFii05uMoA+FOm8e+sKN9YBosjLqYv0xO1gXR60uDnGY/vFjdXfgjHta1RERaa2UR8j0ptYWO3d+gkVS8Y+h2UEKs/OBD7nt6WUMl/W1gHSQ+4OrFy/uJakrOPwhZlpvcyo1uK73/2SenxLy6RP3MImLvY8rOLghCAqBmk+hKbNdEnkTbxBFjsS86Y6U9wX7HOS6IyIpiVzkzx08FsSBwsgNoz5i/QYlKyL32RCEiZpgbJ1uhGlpaYYYLnflisRuiQu7nA33K4n5cs0kLF9Q522cWwQaKahz2iPkD/B+D3DWDZ5NLrD32eg2IIrPVsMrBKYFlsomZDS8ppJH5PohVQYtsjId5w/mlebqUAnpsf9hi4saRTb+Kc03QULWGN0ZXmlO2SnpOZxyp/Vt8LjqpX8EbJY7+0Wh8zppCN2FPv12UsdOIMduZh1174S4+eTEKfdNd3jSWZ8G6wBcBxJZas= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(136003)(396003)(346002)(39860400002)(366004)(451199015)(2906002)(83380400001)(2616005)(7416002)(66476007)(66556008)(6916009)(5660300002)(66946007)(6666004)(53546011)(8936002)(26005)(186003)(36756003)(6506007)(6512007)(31686004)(478600001)(38100700002)(6486002)(54906003)(8676002)(41300700001)(86362001)(316002)(4326008)(31696002)(2004002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MDlNNU9ZMlJOK0lXbUlwM0p6azlXeG9zcHNhZEtuNTVSTG9pRVNPazVVb0di?= =?utf-8?B?S2VVUTZmeGJiZkdmNGVTVklYTWFZU0MzSWlkRitnZkc4ZFJhY3JVZkd3NzBQ?= =?utf-8?B?bnM5cFVUNjBLZVBubU5oMlRMWEhsWFFPd1doeGdHK0krWjFRUXMwRVZUNzl2?= =?utf-8?B?MnRuUnQrWlJQTFFZdTBnN1Q1VFdPV2pTZlpZSC9uVzYyaHJ1eGZ1K2ZoNFdk?= =?utf-8?B?OVZab29zU05OUFgyZzNJVTVhdExJcjFGMXRGbHp6ZFhPWDFiU0RpMVFDQzgr?= =?utf-8?B?Y28xTVM1THN2aTZzVkFMeXZaQlgwclhZTkJFdjR0Zno4NGVDazBWVFZybTlH?= =?utf-8?B?ZE5WUElzaThkMXF2VTEyRTAybVhXZlhlbDdhbUZyUFpQNXQ2ZTF3WmlwcjdN?= =?utf-8?B?VTN4ZHJyMCs1M0x0ZlFXYzl5TGUwdkZkd3Bpa1RFeVZRMmdwNXRjbzdZOEJm?= =?utf-8?B?eDNteHhhKzhQZWNkVDl5Q1A4YzVXNUxpdW5sQlVOd3c1aTJvbkx3eGN0Y1V5?= =?utf-8?B?SStVWXVKVDRHQ3R2VTZId3pQRkVHTjM0aHAvbDRudWRSQ1pQYmFLNmg4R1Ir?= =?utf-8?B?UHN3eDFGRkpSUW0yV1Rnei9tbURVdllxOGxsL2swRFFhdVVyMmFOSHB0cTNK?= =?utf-8?B?a0toOGhHR2xIR1pDMkV0Sy9ESkM0QU5UZnBlYy9ZcXQ5OU1ZYWhqR0xYNXVN?= =?utf-8?B?eUdCdFAxbm5ZRlJGbjJBRlZJODkvb2dHNWdCazREb3A3OGtKY1lmVWpPMk9r?= =?utf-8?B?N0JzRmF5YkJ5VmtyVFhva3NsMkZMYjJ3ajJPWDJMU1lkUnZ2djgrV1YwV1VO?= =?utf-8?B?QldsOVJXSVRzWFlEU3lTVjU3T0lWRHNoNERoZ0RDbyt5RHczZGhlTWt0TVZh?= =?utf-8?B?Um5XY1NkRmd5bXpjcnJHNnNyNDJYY21pZUQ0RDF2YUpQNlVEdXlUTGdCVVd6?= =?utf-8?B?TU13SDhnc3h6VGUvb3hBTmZaN2V4d01WMExsWFE1cUxyUzR0VjVER2piZ0tj?= =?utf-8?B?WlZUOGRNT2NBRmZBMExvS2dVQndHV09pd1VUVUoxZkt5ZlVHN3BseWphZDMy?= =?utf-8?B?aklYNldtTlJ3ZGdzQTdFbFc1RTEzUHRPSDRsM0hyckdpa1NhNjEzazJOdXZj?= =?utf-8?B?YlpKZ1V3NkhCWGE1K2V0TkVqM1NEZFlMeXltVk9qY0pzcTBab3JucExFMU1O?= =?utf-8?B?c3d3Y1VTbzFBbVNTYmQ5Ykh3cmNvQ1I1RHA4b3VqeXQ4aEZpV3ROUmg1TkJB?= =?utf-8?B?OE4wOWdFazVPdzhNSGVaZitZNzdFVjJoSUJFajdMWFB1VVNWVmhjejBaUlhO?= =?utf-8?B?a29BZkU0YkZXUFdiSjEzRldWajc3YVRiMFhPcmpIZ2xNcDBNWWxpQW5zVWZ1?= =?utf-8?B?b2t5R05BK01uYXJ1OFAwRGJKUVR2VWEyTy9WNXUvYW12S1JLYjNrOXkvTmxM?= =?utf-8?B?ZmNabmI5VldMbjBwMTFmaitMMjJrcG40Vnltb29KM2l1eFM1TzZidlJwS2hP?= =?utf-8?B?MFA1UGNYcVo3dm5XdXRsK09pVnlQREdPNnpHR2t2bFAybkRDanR0M2tCcXll?= =?utf-8?B?eVZnU1hkdDJJVFpnTUR1TkJzU3hER1c3cG4vV0FwVE1ONGt2QlJXbXhkSmVF?= =?utf-8?B?K0VDWWsvU0Nld3ZMQ1U3SEQ1MXJ1NWhSalRTb0tsbTFRS1I3MUZsL2dEdFZl?= =?utf-8?B?ZkhJMkM1eHBNLzBEQVpOMTRsRDhUaW00UnZFR3o3NmVnU3U0VFhtTjQ5TDc3?= =?utf-8?B?cHJnRUY4enJOTi9taCtWU3d4T2UrOFFFSm5vYjFVazh3R3VXNFRFazBHOWdR?= =?utf-8?B?U0FDZ0d0YndibWJMZXJzQ042SEh4SG5vS1VDOUJVbXlsZmRxdXByM3hRbWd4?= =?utf-8?B?YndDb1dRa1RyclIvc3c2cWZuTVJLTEJ5RTRFcHBIM2lqcWNXWjFEU2NFN0Nv?= =?utf-8?B?aXhBdmd4QnN2S3VUTGxHYmZOQytwSVhPM0pnbHR0NXFGNllMdkE5KzgvS2lk?= =?utf-8?B?Ymh3azVaN1VNbWJmRW1kdFc1eVpzVzdiVHhXeUN1UXBNY0xTdzVmdXBuRzRh?= =?utf-8?B?bklVUnZNODBCTHZqZlBjcFlmdVFOVm1NNGxQd3p4eTVjTTBqMWNCZ1J6UjNj?= =?utf-8?Q?82U6jkcX209hRhVhfSWNR33KN?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: db4e456d-7419-4215-139f-08daf3290c86 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2023 16:38:06.1293 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2hoTFKYwW6voa7wUCykcL1/kpS2uH/CEKC0HCjYu5FZNpXYCicyEobutxzZQECHMXHrUjlrjqhmnF2b6pXIEsA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB8048 On 10.01.2023 09:49, Wei Chen wrote: > --- a/xen/arch/arm/include/asm/numa.h > +++ b/xen/arch/arm/include/asm/numa.h > @@ -22,6 +22,12 @@ typedef u8 nodeid_t; > */ > #define NR_NODE_MEMBLKS NR_MEM_BANKS > > +enum dt_numa_status { > + DT_NUMA_INIT, I don't see any use of this. I also think the name isn't good, as INIT can be taken for "initializer" as well as "initialized". Suggesting an alternative would require knowing what the future plans with this are; right now ... > + DT_NUMA_ON, > + DT_NUMA_OFF, > +}; ... the other two are also used only in a single file, at which point their placing in a header is also questionable. > --- /dev/null > +++ b/xen/arch/arm/numa.c > @@ -0,0 +1,44 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Arm Architecture support layer for NUMA. > + * > + * Copyright (C) 2021 Arm Ltd > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program. If not, see . > + * > + */ > +#include > +#include > + > +static enum dt_numa_status __read_mostly device_tree_numa; __ro_after_init? > --- a/xen/arch/x86/include/asm/numa.h > +++ b/xen/arch/x86/include/asm/numa.h > @@ -12,7 +12,6 @@ extern unsigned int numa_node_to_arch_nid(nodeid_t n); > > #define ZONE_ALIGN (1UL << (MAX_ORDER+PAGE_SHIFT)) > > -extern bool numa_disabled(void); > extern nodeid_t setup_node(unsigned int pxm); > extern void srat_detect_node(int cpu); > > --- a/xen/include/xen/numa.h > +++ b/xen/include/xen/numa.h > @@ -55,6 +55,7 @@ extern void numa_init_array(void); > extern void numa_set_node(unsigned int cpu, nodeid_t node); > extern void numa_initmem_init(unsigned long start_pfn, unsigned long end_pfn); > extern void numa_fw_bad(void); > +extern bool numa_disabled(void); > > extern int arch_numa_setup(const char *opt); > extern bool arch_numa_unavailable(void); How is this movement of a declaration related to the subject of the patch? Jan From xen-devel-bounces@lists.xenproject.org Tue Jan 10 16:47:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 16:47:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474846.736234 (Exim 4.92) (envelope-from ) id 1pFHmX-0006bs-OV; Tue, 10 Jan 2023 16:47:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474846.736234; Tue, 10 Jan 2023 16:47:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFHmX-0006bl-K3; Tue, 10 Jan 2023 16:47:25 +0000 Received: by outflank-mailman (input) for mailman id 474846; Tue, 10 Jan 2023 16:47:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFHmW-0006bf-MU for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 16:47:24 +0000 Received: from EUR03-VI1-obe.outbound.protection.outlook.com (mail-vi1eur03on2050.outbound.protection.outlook.com [40.107.103.50]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 749b1ae6-9106-11ed-91b6-6bf2151ebd3b; Tue, 10 Jan 2023 17:47:23 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7943.eurprd04.prod.outlook.com (2603:10a6:20b:2a1::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 16:47:21 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5986.018; Tue, 10 Jan 2023 16:47:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 749b1ae6-9106-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NgThEWgjoFPllKuoXUB1P1KHjjj0b9pVgwjReThtvIWZx8vsEnf9tdYlz9LnOigd/hNAIhvZzhPHQrNzkTCSwe1Wpa4Ee9UPt2jvno2yHEquCfpfzBVKqHAtAj/nb7j7mhF2/GhinQz4MTBGEi0bxVTHRWfpktut1zA5EvBzbwkgPMroLcjd4lHzGUj3UKm85pEjJ1pIEpxNz9eCirvoMCjv3b8MykqwhEpWSHbdxfmJQSl1tEb3AOUKTTv0ciTLMIAAMOeeEhB3aFhvp2Uq5b731me2tjRVFlUNc3S+XUnJLrF0I8YXgVCjZYuCG5WCvWzO2tb2b7mMnmdo57QE8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WyrbLmWIaFQ9duchQ4U5/ihs6OxxaDIeV8/qU/RNEsk=; b=C1cD70m2M1ko8SvcXJbMcMk4kKd+PmT0QYpxaJUW38enVmnaZnjZkjitgP0u1Vl7hXL4jVq/FR92vHKCwGcZQ8wi7JclYSB2bp3bNNZduZKV943Q4P0wtqV4Jfhxm7wNhUsLWMoRVumNuo8aajxJ4xjGeG5sCLgwT6Q1pDOt2qkDOiL7OtPdAX3H9GABw489VzyHsG01kisJclae99+IzmwkPlaV0mYdwGmPfUQT5hENP2K6cBvOk8oklu+JG3hQPs3WQNsR03AeTjtrID5z6X+LrvzjnqSmg04fXfo3aym7cyGm1UDFGvkuZyHL8Cv8IiojWq42pE6gsYkPKfXdDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WyrbLmWIaFQ9duchQ4U5/ihs6OxxaDIeV8/qU/RNEsk=; b=aZF0qGX64WdzkT5Q6iOo9vr+Y616ICmiOEgIXju5mXhMaSkAu/+fGGZOXW1dgVBlqiEEqzNU0sA6xUi1YHDoZWFADv7YUZXc18yvrtiXa1pcu325AwsMt3YS6/2RAgeWNRpSCRd84U8ha/2EIElD3YvJ32z3e0Zga/sbe2XL8/AFmBaeTUm93zSJb0eJ1PIT7gUcwOnHI4zANB7FFWuafQ6S551FinNaUyg9trZs9eqzHMo3YY+ddBTTg6ACLyBgPRiFAPgIRZFYNrJflgYGshVnHNpZtsWS9ZeJAz8djLbijG03npWtdu5jAtAGZ5lJHcAyyaLbieX8+Jo6S/yOPQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9fd67aa2-0bd5-16a2-1e19-139504c2090f@suse.com> Date: Tue, 10 Jan 2023 17:47:18 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 03/17] xen/arm: implement node distance helpers for Arm Content-Language: en-US To: Wei Chen Cc: nd@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20230110084930.1095203-1-wei.chen@arm.com> <20230110084930.1095203-4-wei.chen@arm.com> From: Jan Beulich In-Reply-To: <20230110084930.1095203-4-wei.chen@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0167.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB7943:EE_ X-MS-Office365-Filtering-Correlation-Id: 7254ad4d-955c-434f-af84-08daf32a575f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /AFOIHNlT6P6HB0V0CmKos66CQ+8j1r5S0044rEu1wj+vmOfYCo4dfRt5ZZk1hfDGcW4QmOPllNYVcvkXloXDaaj2nOEHU1c1SnaOJHLJAQrxYheJsOOTn8Fu00AfM/SjOtlpOOPwVF5b8nMbPHWvjwe6n6fyhxweh9R4DN2cKWwYIqJ05J4hULeJwb/3N33t3oxyUSJB0hHt18QdrmyH16y+GvewqQ0JSZMugZQv0D3qb5dwQanTCSQHtraHb/f7TTS7PITDtd3JCtwVWpWk8dRPePhtCKfPe3EVfO+v1p7IRE3TJsNDzjkltMMHiXq4mwoJGAk9jxCKseTHhAl6nSDLGrpCZee9dn0bFE/vLfXiTYDoILnrUsrwXMYdFokqCSaBWNJhOXVHpNiMZgElmC6fzANuFRIJCJjilbhJ5y+NN8V623VotNppoOJZIjPRfBeZiiKZc8Q5UPOz5UcIpNfa9XBkozSMoKpJOvwUwlmXzEAasVrrhtx00Pca+OslqA6s53AUexP/79MyFfCgsWx3Hw6WW5lBnVdHEGSUqUFklHVLiv12u/RFZIDyHNi46sZtProuW15gfr1O4k61VATxCIF9HlSQAr5FDmrJd/Go1tGZT9sINs0rZBkFj031aK0nblDveZB9w7M7z5aEAFw97GMm2WAnBshSfw1M6KEh25sTk+gBkArT05xku0Oq0FMWVTqWhrXF+o30/N0YKxTyRS9GvSIe1fxbCC1Ago= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(136003)(396003)(346002)(376002)(366004)(451199015)(66946007)(31686004)(41300700001)(2906002)(8936002)(36756003)(5660300002)(7416002)(8676002)(6916009)(66476007)(66556008)(6512007)(316002)(54906003)(6666004)(478600001)(6486002)(53546011)(6506007)(186003)(4326008)(26005)(2616005)(31696002)(83380400001)(86362001)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V1pVOGVGTHprMDRwK3NXRWRrbmNmWWtETVlKU3NvQ3JQeUppcnpkWTQ0MVRY?= =?utf-8?B?dWZnbHRMSVlCWVhRbUdINlhkRW5TMERXRUlJditRWm5ZWHRMUEFJY05Md05G?= =?utf-8?B?aWJCM3NCMUZqY2tua2tLRG9VVU9xWVExWEMwd0ZzUzc5cklpdXVwZm80ajVj?= =?utf-8?B?RmUwQ0c1NjYwRjhJZHVuUkxWSnhWVUZtQis4SEVtbVp5TU56ZDhPK2lERnRj?= =?utf-8?B?Y3NIOS91TExvTTZsUTN6cGdMQ0FQU0Y2Q1RabDhNbmZIZ05TNjc2TU9ZWCsy?= =?utf-8?B?ZUtDTm1nQkxlRzJBOVdMSDc5YU9OVFM2RTZJZm81c24rYitvcmdQVFM4NWk3?= =?utf-8?B?RjNZSDVjT1Q4NHpIQVNvWktQcWUrVGNRTk1vblplR2lXV1ZnSG9uTlVaeUtH?= =?utf-8?B?RFVVTEFkMHJBeXRkeUp4aVI0TWo1MnJuOW45NnBmcys2ZGVrODlwTWY1MWFC?= =?utf-8?B?MFBWTVZNT3BnTGRuZUhPNGxkYlpDTkNyQ3daOGF3WXMzN2UwdVFMYXU5aHhR?= =?utf-8?B?bG40blN6ZlJvODFhTXk5V2lkNXdJZGttTjBETWR6M09GeWlvaEVMRi9kNDc5?= =?utf-8?B?Rk1VVU5aWnBhZ21sU1NsU2xBTW5SUTVqclJXREcraWM0TzZ2WVdLamJWNSs2?= =?utf-8?B?VksrOEExME1rYnJFcWxqYm4vUFB0eXBRWEw0eEhHaFRWYWpaMS9pTUZNN1hI?= =?utf-8?B?VHlyV3VNMEI5UGhjTW5CRzBDMWNTQTd5THRFMXRxdVl2Qk1DZ3V0Ni9CaDcr?= =?utf-8?B?SE1KNGFaUHpUUXJWYk44cHo1SXJVWDdoSmp0dUxxbkE1OUdUNkx5VzZLcXlR?= =?utf-8?B?ZXIxNHVsUmpHUG10OHdrbTlTM3NWa1lraEU1dnBkbDhNT3R1UTlYTmZvNW13?= =?utf-8?B?QUJSQVZUS3NEREZ5SHN0cDJTSlltRmNMVUE2TGlDRFN1V0d2d2YzNVZaZHA3?= =?utf-8?B?Smt1NDVIWmNYZENObk9rME01SkU5SHR1eWl2cysvcXQvOTNWQThIcmo4VDhO?= =?utf-8?B?T2FqQXBWaWRTT3BWVTRLbHk5WE5TQ2FPcVZmcEV4OVpZK1g0VldTT2ljRExw?= =?utf-8?B?MEJmQllzOWliRmdlQTNQTjY3K2c0SytIRW16dTJLRU9KbmMzb2Zqd0JMRk9H?= =?utf-8?B?MVRneEMyUktsK1JqMDd5Y3A4MjRyWUUwQW1meWtWbFJKT1p2OENWL25scWx6?= =?utf-8?B?N0FqYVBGcTNuWmJUMlg2VDhQUGRjdy80MHB0ZHplNElqRlZPamdIWFppcmQ0?= =?utf-8?B?Sk1oS1lqd3l1bmMxSitpakdOKzFiQnlRd2VIU2tmKzk3Y1o1UzZiUFY0Y0o0?= =?utf-8?B?NUVXQVYzT0xpY2hBc1pIZTRlUnJuZDRLbFdyUzc4ZTdoZ3pQeGZsWVZFN1hY?= =?utf-8?B?QjZpVHFCZmVEVW95T01hZlpGSU41bUNsbzI0aGhBT3d5Q1gwVkV3UVZ2cC8x?= =?utf-8?B?bTJCbTBSTmhxY2tYNFM2QmhidjRaRG9XbW1GRlhzSUhhSzc3ZTgxVzdqY2k5?= =?utf-8?B?R2V5YnBtU1BPeFNKbUg5eWFaaWhFZ2dIbVZPS05oUlhGVCtNSWs3VklTaWxF?= =?utf-8?B?ckpocFpzYmFXaEQ0aWNCMWkrbVV2My8vd0JPMUZPUVpNWkwzeFNVanc4ZEQy?= =?utf-8?B?djlGc0gwa3ErT0RDaTJrWnlVamNPVkxGdkdBR1FZaHFvUjRPQU5EM1l2WVRZ?= =?utf-8?B?TjByWm9vc3NMT0VHNWhhVFlBYzF1dkluMXBYZk9UVWxPdUdXYVVscnJDVHV1?= =?utf-8?B?MndJTTltWkdhQnhKQ1djQUJIU0p4emNCaGlsM0l2ekxvNkg2ODRaRGVjQXFW?= =?utf-8?B?dXRuelVEd251MklLaDRBcGJ5ckpkRUtvNy9nd3hFMnF2aWJtN0libkxFbTdC?= =?utf-8?B?azVCMmRHcE0rV1l5aDhFWXV3cGNRcksrZ3N6aURER0NpaTJhMm9HalhWVFBx?= =?utf-8?B?SGorU3d3VFNLN3ZZelFxald2Wmo5RFZSNk9mY0E0a3F6RUZvVUZseTcvZWt5?= =?utf-8?B?b2xHd21LWm1BcFNJbzlWZHVoa2NHNVJQTENGeWJQVkMzcW9FWTltcFpNVStJ?= =?utf-8?B?ZytnL1NLZzk2S2JEdlI0L0tzaFVCbGgxRURaQnEyNDdaYlB0VklQeU1ra3d6?= =?utf-8?Q?efB5c5Rh5vDvcU8TbPNmlMn2d?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7254ad4d-955c-434f-af84-08daf32a575f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2023 16:47:21.2504 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lzGKUi7VqECw2RRjf1uMbs9GK9b7cz0Enoq16azo7iMX8Ff9WPfc5B3KFR5GY2RM+OxpZWNK974N644bWOHqXA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7943 On 10.01.2023 09:49, Wei Chen wrote: > --- a/xen/arch/arm/include/asm/numa.h > +++ b/xen/arch/arm/include/asm/numa.h > @@ -28,6 +28,20 @@ enum dt_numa_status { > DT_NUMA_OFF, > }; > > +/* > + * In ACPI spec, 0-9 are the reserved values for node distance, > + * 10 indicates local node distance, 20 indicates remote node > + * distance. Set node distance map in device tree will follow > + * the ACPI's definition. > + */ > +#define NUMA_DISTANCE_UDF_MIN 0 > +#define NUMA_DISTANCE_UDF_MAX 9 > +#define NUMA_LOCAL_DISTANCE 10 > +#define NUMA_REMOTE_DISTANCE 20 In the absence of a caller of numa_set_distance() it is entirely unclear whether this tying to ACPI used values is actually appropriate. > --- a/xen/arch/arm/numa.c > +++ b/xen/arch/arm/numa.c > @@ -2,7 +2,7 @@ > /* > * Arm Architecture support layer for NUMA. > * > - * Copyright (C) 2021 Arm Ltd > + * Copyright (C) 2022 Arm Ltd I don't think it makes sense to change such after the fact. And certainly not in an unrelated patch. > @@ -22,6 +22,11 @@ > > static enum dt_numa_status __read_mostly device_tree_numa; > > +static unsigned char __read_mostly > +node_distance_map[MAX_NUMNODES][MAX_NUMNODES] = { > + { 0 } > +}; __ro_after_init? > @@ -42,3 +47,48 @@ int __init arch_numa_setup(const char *opt) > { > return -EINVAL; > } > + > +void __init numa_set_distance(nodeid_t from, nodeid_t to, > + unsigned int distance) > +{ > + if ( from >= MAX_NUMNODES || to >= MAX_NUMNODES ) > + { > + printk(KERN_WARNING > + "NUMA: invalid nodes: from=%"PRIu8" to=%"PRIu8" MAX=%"PRIu8"\n", > + from, to, MAX_NUMNODES); > + return; > + } > + > + /* NUMA defines 0xff as an unreachable node and 0-9 are undefined */ > + if ( distance >= NUMA_NO_DISTANCE || > + (distance >= NUMA_DISTANCE_UDF_MIN && Nit: Indentation. > + distance <= NUMA_DISTANCE_UDF_MAX) || > + (from == to && distance != NUMA_LOCAL_DISTANCE) ) > + { > + printk(KERN_WARNING > + "NUMA: invalid distance: from=%"PRIu8" to=%"PRIu8" distance=%"PRIu32"\n", > + from, to, distance); > + return; > + } > + > + node_distance_map[from][to] = distance; > +} > + > +unsigned char __node_distance(nodeid_t from, nodeid_t to) > +{ > + /* When NUMA is off, any distance will be treated as remote. */ > + if ( numa_disabled() ) > + return NUMA_REMOTE_DISTANCE; > + > + /* > + * Check whether the nodes are in the matrix range. > + * When any node is out of range, except from and to nodes are the > + * same, we treat them as unreachable (return 0xFF) > + */ > + if ( from >= MAX_NUMNODES || to >= MAX_NUMNODES ) I guess using ARRAY_SIZE() here would be more future-proof. Jan From xen-devel-bounces@lists.xenproject.org Tue Jan 10 16:58:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 16:58:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474853.736245 (Exim 4.92) (envelope-from ) id 1pFHww-0008Ba-R1; Tue, 10 Jan 2023 16:58:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474853.736245; Tue, 10 Jan 2023 16:58:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFHww-0008BT-O1; Tue, 10 Jan 2023 16:58:10 +0000 Received: by outflank-mailman (input) for mailman id 474853; Tue, 10 Jan 2023 16:58:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFHwv-0008BL-0l for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 16:58:09 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2080.outbound.protection.outlook.com [40.107.249.80]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f39dcc7e-9107-11ed-b8d0-410ff93cb8f0; Tue, 10 Jan 2023 17:58:06 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8867.eurprd04.prod.outlook.com (2603:10a6:20b:42e::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 16:58:04 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5986.018; Tue, 10 Jan 2023 16:58:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f39dcc7e-9107-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WphBUvhP/IUpgtfvJvwzelBQ9Nci9NL9zHwpRLQqzPeX4pFOvfyeSh8vJ8t2T1nPOHErVhy+IQKw5VtqhEhCcZFJhGmy3r+lCvm4uTcocS9YB9f2NHWzuAH8pkzQ6ceeF9y9xXqcrjQt3AOAJucSviRIcX7Dzv+OeAuIuAX1kd5l/B92KPykF5rrlucQqFzRY3iN0R9Xbvitu17iLF1IbkmWk1VAcdTd79sW10mpEAqMz/UhJYN8QAeyb6ofwYs2BuvWftsQ0CMa/B3TsbxXzSqtdkv4sdLtbvg/dJhSOMOHGDw7ahBZM0OHSOpVi/9ZUhAcAYyZDKwaeZ1OX++ayA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fk+UgjwtsWqSfKJ+chmrOVNVaUuKHHNOX4IOpLZmjNQ=; b=QRDAHvLTVS6RfkL0Py4BT0MY2linMNqoUQgaqetbMVWf2lVpE2e/UpQKbnFcwkVS6y693uWe7YWnfMKTuY/2M2cqRlUN1qLGkSelsts6Vs7qp/Is+GHgARUuIMumfm+9see8NbZVoZRQuPFt+4RCCBH8GZsAgt1WWw8GiMJ6s6eVq0JgNpxvuDFhpr/WdDjJSB1PtkDVJXTd1sn3/fRkqEOSqZnvjABojkAUnzI4+4wVKUopCIO5rYQ9lpLA7zt22S4u/dKhTRIBYQftNKtcN9O33C4IzRr9geUA8tqFnV+VPKTgYQ9UkU9KSuR66tRj6mfb2yqnEg8SbJFolUBhGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fk+UgjwtsWqSfKJ+chmrOVNVaUuKHHNOX4IOpLZmjNQ=; b=Q2zx6AKgW0yMPvy0xHiqLcJoGJsue5qQVAJRVOHnRl0wgyD1rYJ8qH/xk7nbCltKO/gct3a04wRQJyNx+QuDb9+4yNtK4laLXb+Ien4vJHufWXFoB9aquDH0hXsP56iCFqUvhfYCfuVG6Pxt3zBhNnVZMd9vNh+zOCy+4V6YGZkfSfw+7o7GU5zCegyNer3Rxh3pl0yn1mxEHCLIwrSvLLuhueMeFdkkqCwi8pPVVOVAE2RfxbcmjizyOFyyqtlfmslLclBPGzuj1H1gMqcFNnIXUFmA7XWtybjStDPMttt6CQixTE12if4Fet5zKN/56xx1KvTyDQFz50BrHrveBw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 10 Jan 2023 17:58:02 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v3 2/6] xen/riscv: introduce asm/types.h header file Content-Language: en-US To: Oleksii Kurochko Cc: Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0119.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9d::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8867:EE_ X-MS-Office365-Filtering-Correlation-Id: 09b03cab-4929-4747-73a8-08daf32bd6f8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PsKPvJSylOuFAx82eqbkLeJ9l3N3Gg8dkjijFH2mnNxybHuvGpZlgxOWV8swXkKa3W+lZ3UfErdwRXSYR19EJPp6CmpngcJcBTGQLZTl+3FOEVzMAq4PUBjYaqaBqsprxCDKzcKGQMOWdu30RqYBZFrNwUMl57ipNCEkLKOjd1L38qQnB3iH9MF4dI2Vq5Lfqqz6LctftkuudhZlWVcExxp2AIomICr2UZ1xidwdNhMKuHdSJHrPXb+Iet0NKrlBJRKlV6MKghJsPhuMlaJkDbkzxMepj2ajUMKEt1EJ8DFNgFx5XlZyNaLMK+gWvGuf4GumXuDi3q7NpC0K0GHdaFQCswfVj+rYlU9j2MCk4JWsrWZDSIIez7CBpvrDSKJnAxQG3mrvt61gRoFHafTZK9DrwVBJ7QtoPbRM7KmYg6b4M1aXcrPWC8PbPsFh2iI8ow2yoPC6fDlWiQaZBsgbOilRlebdC4KOkPNLNiF42ULe+yNW0B0+/MtRS+RuyAUpwHNHVTG8iPkjoES+vXE3+oYjpbj6pjGDjl9k/HDzklgEjvr+fFvULo9T0DirhnOXzDx2Z1i84o+Qkil2M5nTfh/rxf4TonxlfCdODenkyAfw5kiquWqz4b/LGRLwchd76M39C1Qq8W3AY8aGZH5elvOUvUMRIxyQQMHNWAad65M36mTe+4pTJ7hCOvm2r2pc5hZpe30Y6uKB1Iogt04y2IAruoU+5uc4JHlU2FMvRpE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(366004)(39860400002)(396003)(376002)(136003)(451199015)(36756003)(8936002)(186003)(2906002)(41300700001)(5660300002)(4326008)(6916009)(66476007)(8676002)(66556008)(66946007)(316002)(4744005)(54906003)(38100700002)(26005)(2616005)(6512007)(31686004)(31696002)(86362001)(478600001)(53546011)(6486002)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TFhVM05YcVFxdXkvSVBiRUJnbWgzZFM1Vm00Q1F6aXJEZWhlVm9hRzhPbStq?= =?utf-8?B?WFpOSVJsbWh0aU92OWRiMlozZlBMb0pacG55OFU3WHBmQTdKS05vNmFhbmdv?= =?utf-8?B?bmhUMnBFdk5tZktjdnVNUUxmMllRMUxsUjZvSGlYT1dBQzRWMWJkL2ZDc2VM?= =?utf-8?B?WkxZQXl2QVVCUDVqTHJYYnVjTHlqL2lCOTNFNy9oMkhWcDFCbEFlVGZNd3ZX?= =?utf-8?B?aDdDV1Z2cVY2VVhuWXNweUZKVTlZb3Iram5hajh1TkdWUldNZkY1eUdma1FE?= =?utf-8?B?WUhrbG5aNDgxbFdLK2N2RDdUd1hOVUI1aHBrVHllOXBnMkM5elJlNlJPQ1Ri?= =?utf-8?B?TWhzYkQrVHN2b1pCUkFTNGQwTDVHU1BFTEMwcVcwZGtELy9HanoxN21UZkla?= =?utf-8?B?NkN3WDg1WCs3dTJCa0dJRjlsa05iQnE3ZlFzcXFDTGpTZ0ZVc3NhU3MzQlIw?= =?utf-8?B?d3RYcEdjNk5wU1d2V3YzendtSGFjVlFPYjFIUFNLYTJ0K2diemNkVzE5TEpV?= =?utf-8?B?ZHZBM2dFa0dkS05tVmxEU29kbkxld2JrdFFHK1pWbVRWK0Q4YlY3QnMrSlps?= =?utf-8?B?R0lGazErYWZ6QjgxU3UrellwVUpmeGE3eUlRajdCc0x3NjJGU3R3VTdzb3Fw?= =?utf-8?B?WG5YdUozYlZhRlFaTU45M0Z5a2FjYVNjNDRZTWJKNXZqcHhaemwyNk1SM29x?= =?utf-8?B?N01GeENmMjYwMk8xYUNmaW5CbnVEVTdIbmE3MllFc3BSWFVGZGM4UUFJbmFo?= =?utf-8?B?cnh2Y01YZmIvT1ZBR0FyWjJPZDdEc2ptOWxOKzYvYjJPTFRXUm1NbnQyZ3Bw?= =?utf-8?B?WnRxbm9iTktLNjg3T0JIZ2MzTU56RkIyMkZrSGVpQi9yeEZPRUl3V0N6UzVv?= =?utf-8?B?QVRtL2g5M3FBNWo1bEhEY0RYNStnN1JWWUxrRjVVZmdQSXg0ODhvcmVqUktt?= =?utf-8?B?VGZPM3h3MlJQdE9ieFVFblQzczFhU1JVaWFCKy8vMjZYMnl4cThCU3Q1Q2hh?= =?utf-8?B?YjI0cytsaWswRW9xSERBdHVxdGFYKy9XNDBOQkEybHpSL2tDbVhvb1EzYlhv?= =?utf-8?B?RS9XL0hWMmpZekd4UGRvdGNUSEVrVExWY0c3OSthRk1Zb05kS3ppK0U5eEkr?= =?utf-8?B?NWZydy93eGVQcC9qaExXU1IwSDNSOFFsb0wxWDV3aVMvTzh0TmxmTEU4aVlG?= =?utf-8?B?aFFJdCtFcFVqSFV0NWxZSVU3N1dlYnhvZndjV1IrbzZyU3MwT1gzZFQzRFNw?= =?utf-8?B?MWxMdVJtTDBjdG5NRzNHa0ZWVXNPbmQ0bVUyeHk5WXVqOFc4c2M3SWcycWNJ?= =?utf-8?B?T3MzQTBkRHJiYlBXQWMzYXgxamE4azc3eE95REF2WnVscld5T0oyblVHWFcw?= =?utf-8?B?alBBNHA3NEFoS01HZkZwZ3F6dFB5ZVIzN3FNd0MvVjZTdDJYd1BYV29Zaitm?= =?utf-8?B?Qy9xdDEvekNCdGpNVmZCQTIwZkpDeWpSWGV1bVhVem1TSHVMOUJ0MDREZTBW?= =?utf-8?B?anlXVnA4c3V3WDF0Nkk0ZEEySDN4M3hOeFpxV2VGZW5rUktjZ1ozdE90Q0wz?= =?utf-8?B?ODVncEJuclMwNzRpdWF1MWpEekNKeHdFMG5KcDJ3K056N3FXK3NVSHE1VlBH?= =?utf-8?B?bWRBR0htVTdhc09ucFZ0ZkpFTnFnZXZPcVQwakUrWm1EemE4aGdqbkUzSGlT?= =?utf-8?B?Z1F2QjJVSWNzVHdKdmtYTE5YV1FFTWc1VjlMSlpnSWZ3WmJtallYY2g3d09p?= =?utf-8?B?YU1zZXpwamExZUtXV1FTdW8vOVRvaFQvUnRRb0ZRSnArZ2Zyek52UXd2NUl1?= =?utf-8?B?cThyMzJ2M2R2aVJyQzlXVFNjNUxTZlZ5Q1hIbUxkQyt4SDNpQXUzMDNYNXVH?= =?utf-8?B?T3k2WXdjVnNjbERHTmJMejVVTmtTNnJXbzcySm1pYmFHZHltRG9rSEpqUUVm?= =?utf-8?B?Vit5azhVMnZDbnBTZXRPdU9POXJDQUhCOHJiaFFLNUlBR01tZktKS0hMNzNS?= =?utf-8?B?NDU5QUVDVkFuSUhXSm96OGdGakNHNENEdGZBN0xoZU41Znl4dC9hZnRmVFVx?= =?utf-8?B?ZkxkaTExUk9tMHZmdWhiYTBpU3ZFQVBFSHQyMUY5QmgzS2tSYWhMMmE2ckhy?= =?utf-8?Q?+h3B3SIIWjRv2E6NudnjkuWdB?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 09b03cab-4929-4747-73a8-08daf32bd6f8 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2023 16:58:04.3815 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rTLhwhXds+fwdPVHE80x4/Bju6K8YDfeRC6pT4JxffManHtNatiwqB4mC3zqfAIOsWbtIESpwo+t7SBuUIBvuw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8867 On 10.01.2023 16:17, Oleksii Kurochko wrote: > Signed-off-by: Oleksii Kurochko > --- > Changes in V3: > - Nothing changed > --- > Changes in V2: > - Remove unneeded now types from I guess you went a little too far: Types used in common code, even if you do not build that yet, will want declaring right away imo. Of course I should finally try and get rid of at least some of the being-phased-out ones (s8 and s16 look to be relatively low hanging fruit, for example, and of these only s16 looks to be used in common code) ... Jan From xen-devel-bounces@lists.xenproject.org Tue Jan 10 17:03:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 17:03:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474859.736256 (Exim 4.92) (envelope-from ) id 1pFI1c-0001DB-DF; Tue, 10 Jan 2023 17:03:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474859.736256; Tue, 10 Jan 2023 17:03:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFI1c-0001D4-9w; Tue, 10 Jan 2023 17:03:00 +0000 Received: by outflank-mailman (input) for mailman id 474859; Tue, 10 Jan 2023 17:02:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFI1b-0001Cy-7y for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 17:02:59 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2087.outbound.protection.outlook.com [40.107.241.87]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a1267c03-9108-11ed-b8d0-410ff93cb8f0; Tue, 10 Jan 2023 18:02:57 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8867.eurprd04.prod.outlook.com (2603:10a6:20b:42e::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 17:02:55 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5986.018; Tue, 10 Jan 2023 17:02:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a1267c03-9108-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jkohcWCfECVyCb6zKOCfQ4xFq40VD3aOkssTdTOc3V92DV4oyOosKsQ3T1uWQTqWYALxmBwuA0aEqcVPYwF13vabvqPrAcMgVIK4JMaU9DpQZ9NHPm5tWhbrauQQMzgFKix7GJIqTNKNVBA3hslltXWSuucQtLSFPmf2eXOqWJ9yiI8FORj3N9iBP6R6PFmh4hgMwMh3TluoNbDrod1ObVqF9nNeFfpY50TNXc1E0WtjrpGtIZNUntAFCjRx+geL8OX2q65Y2jy94ol4LZPidZCFyKhukueOei3YE/wj6c9qqYH91sU+ooS+bCEnGxm8BizVoT/m/JTQyJrpD8neCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vsvIstwP9A5FBf1MATw/te3HnzA+g/ivPO9HJCk33A0=; b=S7fKIWiJnK4hUzYza0p61ZaL+YYBY7UfaVVUDTrZLMF2HfCd5itiHj1VtvXUMrKhIQyoKni9wvBhL8iBOBGyvSDw+EmybGa7FuU+7l0nYxU9/zFrb6dQwfGeT7NCFFjK+4crXvQc0SjbW0rRgZvXjuWfAvODO+PdtXDgObNYBZzXM2dM/ynArArJems5W3VXeUiesROCe25/H5yBaXqE5rVt716uh1xy/59EynFMxGPrThGH3mLDhXa8qlcJ1x7P8hwoR6u2RiyOQdp2o4E6PxenRH4YKRmO2s7uMKXZRA0Qou94tvOmwv7Cmh4lpCorp25UkoNDuCEFfkyrWc4sdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vsvIstwP9A5FBf1MATw/te3HnzA+g/ivPO9HJCk33A0=; b=MHOUpJchMY2aKAt7pZ/XzrO/glwxQLHvF0x7IovDYXCX0cFI5sS21RRDI+hzAgTgR9rS0dylhlyxDHhR5QJUVkcZbn1AcgGv1qUm7L4ej75m2JxLDcO0lGXLMYqnHC59moSofCdvaFVdQJDg3dfTqodEa7h3xZF2cb6qGNJ3Wwn41QjA+iea+Sr3d9hvf7+gNnfvG0v8zInjuTc4SYp2768hk7ZHZybMokO8pVoI4OXuvs714QFabXLrMCH9c8tcyaz+lGekOvAz0FMbNIOliwDUSroPLXuZySki93RO6wUshmYKGG7K4uDYFqrVbKwMc54YVET7AiyHD7jLm0UajQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <891d0830-7fdc-202a-5f12-2364cae5bce5@suse.com> Date: Tue, 10 Jan 2023 18:02:53 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v3 1/6] xen/riscv: introduce dummy asm/init.h Content-Language: en-US To: Julien Grall , Stefano Stabellini , Bertrand Marquis Cc: Andrew Cooper , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org, Oleksii Kurochko References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0101.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9c::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8867:EE_ X-MS-Office365-Filtering-Correlation-Id: eac8c3eb-386c-4242-d14b-08daf32c847b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sPDQEnOnDMusjKjxsxZY24UIDfaNw1Xct/XDpkZk6KWQ/OxOC5x4Mt5jlzQEKAt3K6AUbgbHehmi/g1WjLitrLWFHHiQTBxh4j6+e7fBhIuVmoljT8zUG8hMlel7NPF7VPF+nGvt6j4HYx/EfpMLX1N9lce8/gg8Hzy9rfflYhyylH3ZJes2FIvZ+aUzsRyNN5upViaoT6XGisTcqxIA1PoNMDl73X6WHzyrw2Z8652+4TUmEWOwHwdU+Q4OME0DVMRPWEaGGNzdy18noSDA3IwWzZQImk/k2/d9Lmc1f7rqDrRH4yIYdiNdcaJRBzTqEolVdNSMfObKxu4BDF5jP+5tSIsoOKQvY7hWNbsSKCFK91LyPAkCq1sKc7L60T5j+D9pH/A/rmesHszGRm8cc+i7W62ks1M9KBlKknxY7qDbi83hjIMQbFvexVuxOyUAOTcKUQB3YPCa6jQSzqeKN3ugjQLbfWSVe5Z3YqDlAs9W5NM9cuhYpQyBPa4fjCkoGDpC1Qr8qtj9TlHLayrBhuw2y5Ti0ea7Gc6dEoTf2MPSKa6GDmy3at6pCrlUs+GYDAK45R2ShKUOejbgTgYWqGifqmxEddZvxt3coxlbaxg/tcjW3zokvXDcTQ7ISkndFj91efxNo/SHo9JOaemoSVbja/0rbUD2OkoUlweE79vG748XrXr8B7HbnW/laB/PwEPIzEiXTg/wPyLWSKSquic1c63WekjbOaV/npP45KI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(366004)(39860400002)(396003)(376002)(136003)(451199015)(36756003)(8936002)(186003)(2906002)(7416002)(41300700001)(5660300002)(4326008)(66476007)(8676002)(66556008)(66946007)(316002)(4744005)(54906003)(110136005)(38100700002)(26005)(2616005)(6512007)(31686004)(31696002)(83380400001)(86362001)(478600001)(53546011)(6486002)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Qjl5V2RSYXlJeFM0YTQ4Sys3V3lSQ1gwUWV2eU1ZcFYwU3czWUpoZVR4ckxz?= =?utf-8?B?Uyt4bldzcmpFTUVuNDVVVm9VaWJwaUtEdyszMkg2OHlqSEVQVVJtZ3RFNGVR?= =?utf-8?B?dWtXM3VnZmFQcSs5ZG5kVXJBTVNmM2pQM3dmMzQ4UFRQcXo5Wk5sYnlxYldM?= =?utf-8?B?clZQM3dybzZ3VFpmWXZ2M0xGUVZ4SG1ZYlNGaWJ5dzJwalZoNjRzdWRWNXFz?= =?utf-8?B?Y05xVWsyS1d4blJJU0haR0dmemZhSFFQbUVzZVUrSmphREVHbW1TQUEvKzds?= =?utf-8?B?MVVHcW1DNDAwUlhzQlk1clBpSWFBSmxxRmN2THhQUU9Va3Vza1JzUElOOVpJ?= =?utf-8?B?OGFKVGpUZ3dDTjkzU1ZBMEFLbnhqelEvYmN1Tm40UEZPb2JLTElXdUtLK3pp?= =?utf-8?B?RFJXQkFwMm5hQm9hejBpOWc2T3lhT0RybXZXQnBBN1BlMmJZbGtnRUtpdnM0?= =?utf-8?B?NXZzTmF5OUYzOVEvaEVsL0xsUnRKTlltNXcrYlJ5Y2EreEUveVRaRDRDWjdV?= =?utf-8?B?YUVCcDFTeGZ0UXVnakt5eDZTVlpDeEpoS0FZdHJRSzlPdUw4NUlFczBaSllv?= =?utf-8?B?ODkwY3BSVUNQdTJNT1IvU2ZRU2IvVjZtQUJzOWhyMXErZFlhSGhkNnFmN29y?= =?utf-8?B?aTdxUmtvWlB6R211cWJPdHVmMkhDd3FKdENQekJzUUZzZ0ZUbVJuNitDUy9p?= =?utf-8?B?ak5iU1hMQjhXZ3pFbncyemRzNG5XRjhKVkRRcHNGZ2JOQXJldjRKNTZxRWVj?= =?utf-8?B?WVpEODBTbFVYMlVmYWgrUkloc2doYVBaOTR0ZSs2RW9ZaVFRKzhaWE1XTHBI?= =?utf-8?B?VW9GL3FjeFY5T25VZ01ibXhqNXBNWHlJY2l6Mkx3b3BJWHZqbDFCUnBrUVI1?= =?utf-8?B?ZlZRTlFzWlBIR1pYZmZaa3lhTWdBRTEwOFEwWWg1bDFybGVMemlOcFp2N1Bv?= =?utf-8?B?dHdWOXZDT0hiZERNUVFrQXBtL2NoNnlrcGs5bE1DTExnZVhTYnl1RlBPWXNq?= =?utf-8?B?Ym5nN01xL1RWcnE4NXd2U0swWmkybmJ1WEVnamJ6NTJpK3p0cm1FYlhxcHJv?= =?utf-8?B?SlhnNEs1OXA1bXVadVF6UWE1bEZCbmVqQU5GelMzc1hESEtSNjVZRGxqYUxD?= =?utf-8?B?RVNGY2pDaEhlZGU4eVp2WUVuN2NQa2pobXlzeFpBVWhmVHRROGxNTVArQUNX?= =?utf-8?B?b2ZDSkZvRlh0N2REL0VES01xcU84aFpsOWhDR1VXd0cwSE1SdlQyWmFJaDhI?= =?utf-8?B?TkFPeWl2c29ra2oyYlhJQkpyaGsydUpJeWZ3MDR4Z1NRN1kzK0tTVEZ5Tlda?= =?utf-8?B?SDhUVDdURG1lVlV3K0pnVEZxNXpIMElLWFAwYmFjblQ3dVljanhMWnNVdkVj?= =?utf-8?B?Y2h0S2dwVmYvU0g1TjdaM3BOWmFsc01Na3VOaUI1L2pUZ0RJTStNeDBWSGtB?= =?utf-8?B?YW9YMDNoWXlvcHlaa3I0eElZOUViT0VyUWJZekk3ZW5YYUsraTc3dHVMbTNq?= =?utf-8?B?SHpYSmN4Q3dpdzJMQmUwVDZQUVZPSFJDbVZJZnBubTAwTmkxWndqejk5VThN?= =?utf-8?B?K3N0cVpqb1U2UVJST0FxaytKaGFHWkwxaTBYTld0WUIvclBpczY2QjFRYmhv?= =?utf-8?B?VDRlMjV6dEJ5anJ2ZStUVURiUlBzdHRJbDUyNWsrSkpyVU40YndQZjdXbVB5?= =?utf-8?B?YTFrVXVGenVXNjJ5ZkxQbVZIRkVsV2QvQ0ErOUh6cDhCSzd3VitkcFp0N3Ft?= =?utf-8?B?QzVnamlvc0VtOExxMk0zSjVoYUxyNFlpNEJpRXlocjAra2pxUlIwd0JoWjM5?= =?utf-8?B?QjRJd1FSTlJnWFFzZ3k3OXRVWWVLL2ltd2NmdlIvNEV3Qi93SFVZNU9kTlVm?= =?utf-8?B?a080ZjNPaXhYNkdYdTBoL1IvcmpPaTNaSXVBbGk0dXJEdmVWUnFtbHlrbGxh?= =?utf-8?B?K2N5RFJjbVF1WUxZZUJNQjY4Z2Q5QlF2bG5Kbzk1M2thRlF2TFNhek9FNTVK?= =?utf-8?B?alFqc2pSckYrN3FTZ3BGQ3p6SWRPOFJHTVlsUTc2SkdOYUxXV3VKVElhY2x0?= =?utf-8?B?aW5DYjhyR0RCVVNJU0JMWnpESGRLQnZ6SkRIejRFNUQ3ZU40TkJIQXhRcmt1?= =?utf-8?Q?tM9CPaMStMpAiwTbqNgjXRRVj?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: eac8c3eb-386c-4242-d14b-08daf32c847b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2023 17:02:55.5976 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FR0ci2buY+BbuFMclTtxuqEknftc9FvGQo3OR1nKyDK/RsscWZ++PyKZ+9+tL6q/Ww+1nLNXuF0SC4N8/uBx7A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8867 Arm maintainers, On 10.01.2023 16:17, Oleksii Kurochko wrote: > --- /dev/null > +++ b/xen/arch/riscv/include/asm/init.h > @@ -0,0 +1,12 @@ > +#ifndef _XEN_ASM_INIT_H > +#define _XEN_ASM_INIT_H > + > +#endif /* _XEN_ASM_INIT_H */ instead of having RISC-V introduce an empty stub matching what x86 has, what would it take to empty Arm's as well, allowing both present ones to go away and no new one to be introduced? The only thing you have in there is struct init_info, which doesn't feel like it's properly placed in this header (x86 has such stuff in setup.h) ... Jan From xen-devel-bounces@lists.xenproject.org Tue Jan 10 17:13:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 17:13:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474865.736266 (Exim 4.92) (envelope-from ) id 1pFIBJ-0002iM-BK; Tue, 10 Jan 2023 17:13:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474865.736266; Tue, 10 Jan 2023 17:13:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFIBJ-0002iF-8Y; Tue, 10 Jan 2023 17:13:01 +0000 Received: by outflank-mailman (input) for mailman id 474865; Tue, 10 Jan 2023 17:12:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFIBH-0002i5-Ec; Tue, 10 Jan 2023 17:12:59 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFIBH-0004ea-AD; Tue, 10 Jan 2023 17:12:59 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFIBG-000154-Ob; Tue, 10 Jan 2023 17:12:58 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pFIBG-000269-OA; Tue, 10 Jan 2023 17:12:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=m7MdvrMlHzHn4A6gsKjK6RvpiR/dipGcbaZOiB7yvK8=; b=r+u1Wf4meoCEFnGll0gv6o38RQ LUsMdLYQast0R2meIAf6N0C6lIUyuzXCidyXCFIC7trcQrPD7K33e11mSx6Mn6s3WUYiX1RnxXbSm 25mIdR6nxgXfxld4Ib7Skv2FVilXr23yktK8bL82Ezva6XfUOAqvxG1LZq6M18CUwZNg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 175689: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=5a41237ad1d4b62008f93163af1d9b1da90729d8 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Tue, 10 Jan 2023 17:12:58 +0000 flight 175689 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/175689/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine 8 reboot fail REGR. vs. 173462 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux 5a41237ad1d4b62008f93163af1d9b1da90729d8 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 94 days Failing since 173470 2022-10-08 06:21:34 Z 94 days 198 attempts Testing same since 175689 2023-01-10 07:51:40 Z 0 days 1 attempts ------------------------------------------------------------ 3317 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 505667 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Jan 10 17:18:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 17:18:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474874.736278 (Exim 4.92) (envelope-from ) id 1pFIH2-0003SN-5B; Tue, 10 Jan 2023 17:18:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474874.736278; Tue, 10 Jan 2023 17:18:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFIH2-0003SG-2G; Tue, 10 Jan 2023 17:18:56 +0000 Received: by outflank-mailman (input) for mailman id 474874; Tue, 10 Jan 2023 17:18:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFIH0-0003Rz-Lx for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 17:18:54 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d99b1fde-910a-11ed-b8d0-410ff93cb8f0; Tue, 10 Jan 2023 18:18:52 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d99b1fde-910a-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1673371131; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=nlcu1l1czYrvkQ6yAjB0ab/hxX/LNf+c8nxTwGFVhRM=; b=arkGuz02Y/TSqhJka3P0D7BPkhsPmZs/BAcU4ELfx/tMfyrNSAYwtAH+ mXEiN9eQtMeNPCPEYSHLQIlBuVbnSthuw50vp8dc3IKpPcK+mncDFmETz x1y4EObzV/TGWZcgj5NTNIqtSxLkl+ka6NYRMftbZt9Tce9sGQhh+OUD/ I=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 92390969 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:MnqQCa2gwGaBC4Zd3vbD5cBxkn2cJEfYwER7XKvMYLTBsI5bp2QGy WEfCDiCMq2JZzP1L9siPo6z/ENU78fcndRmSVNlpC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK5ULSfUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS9nuDgNyo4GlD5gVnPagQ1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfDX112 tcoER00TxmDgfu9y5eUT8pHr5F2RCXrFNt3VnBIyDjYCbAtQIzZQrWM7thdtNsyrpkQR7CEP ZNfMGcxKkSbC/FMEg5/5JYWteGknHTgNRZfr0qYv/Ef6GnP1g1hlrPqNbI5f/TbH54ExhfG9 woq+UzFJAxEHtu5xQGdsW+pg8LQuRK4eKM7QejQGvlC3wTImz175ActfUS/iem0jAi5Qd03A 24+9zcqrKMy3Fe2VdS7VBq9yFaUsxhZV9dOHukS7ACW1rGS8wufHnIDTDNKdJohrsBeeNAx/ gbXxZWzX2Up6eDLDyLGnluJkd+sESQJFkApVRYpdCoM49/6q4oWoRfsZf82RcZZkebJMT33x jmLqg03iLMSkdMH2s2HwLzXv96/jsOXF1Bov207Skrgt1okP9D9O+RE/HCBtZ59wJClok5tV ZTus+yX96gwAJ6Ej0Rhq81dTejyt55p3NAx6GOD/qXNFRz3oBZPnqgKulmSwXuF1e5aEQIFm GeJ5WtsCGZ7ZRNGl5NfbYOrENgNxqP9D9njXf28RoMQPcMrJF7fo3wzPBT4M4XRfK4Ey/lX1 XCzKJjEMJrnIf4/kGreqxk1jdfHORzSNUuMHMumnnxLIJKVZWKPSKdtDbd9RrlR0U9wmy2Mq 4w3H5LTm31ivBjWPnG/HXg7cQpbchDWxPne96RqSwJ0ClE6RDBwWqKMn+hJlk4Mt/09q9okN 0qVAidwoGcTT1WeQelWQhiPsI/SYKs= IronPort-HdrOrdr: A9a23:Xj6syKk04uxO5DNMXQHtoTXZa7XpDfIi3DAbv31ZSRFFG/Fw9v rDoB1/73TJYVkqN03I9ervBEDjexPhHO9OgLX5VI3KNGOKhILCFvAA0WKN+UyEJwTOssJbyK d8Y+xfJbTLfDxHZB/BkWuFL+o= X-IronPort-AV: E=Sophos;i="5.96,315,1665460800"; d="scan'208";a="92390969" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v2 4/8] x86: Initial support for WRMSRNS Date: Tue, 10 Jan 2023 17:18:41 +0000 Message-ID: <20230110171845.20542-5-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20230110171845.20542-1-andrew.cooper3@citrix.com> References: <20230110171845.20542-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit WRMSR Non-Serialising is an optimisation intended for cases where an MSR needs updating, but architectural serialising properties are not needed. In is anticipated that this will apply to most if not all MSRs modified on context switch paths. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu v2: * New --- tools/libs/light/libxl_cpuid.c | 1 + tools/misc/xen-cpuid.c | 1 + xen/arch/x86/include/asm/msr.h | 12 ++++++++++++ xen/include/public/arch-x86/cpufeatureset.h | 1 + 4 files changed, 15 insertions(+) diff --git a/tools/libs/light/libxl_cpuid.c b/tools/libs/light/libxl_cpuid.c index cbd4e511e8ab..8da78773a886 100644 --- a/tools/libs/light/libxl_cpuid.c +++ b/tools/libs/light/libxl_cpuid.c @@ -235,6 +235,7 @@ int libxl_cpuid_parse_config(libxl_cpuid_policy_list *cpuid, const char* str) {"fzrm", 0x00000007, 1, CPUID_REG_EAX, 10, 1}, {"fsrs", 0x00000007, 1, CPUID_REG_EAX, 11, 1}, {"fsrcs", 0x00000007, 1, CPUID_REG_EAX, 12, 1}, + {"wrmsrns", 0x00000007, 1, CPUID_REG_EAX, 19, 1}, {"intel-psfd", 0x00000007, 2, CPUID_REG_EDX, 0, 1}, {"mcdt-no", 0x00000007, 2, CPUID_REG_EDX, 5, 1}, diff --git a/tools/misc/xen-cpuid.c b/tools/misc/xen-cpuid.c index ea7ff320e0e4..f482c4e28f30 100644 --- a/tools/misc/xen-cpuid.c +++ b/tools/misc/xen-cpuid.c @@ -189,6 +189,7 @@ static const char *const str_7a1[32] = [10] = "fzrm", [11] = "fsrs", [12] = "fsrcs", + /* 18 */ [19] = "wrmsrns", }; static const char *const str_e21a[32] = diff --git a/xen/arch/x86/include/asm/msr.h b/xen/arch/x86/include/asm/msr.h index dd1eee04a637..191e54068856 100644 --- a/xen/arch/x86/include/asm/msr.h +++ b/xen/arch/x86/include/asm/msr.h @@ -38,6 +38,18 @@ static inline void wrmsrl(unsigned int msr, __u64 val) wrmsr(msr, lo, hi); } +/* Non-serialising WRMSR, when available. Falls back to a serialising WRMSR. */ +static inline void wrmsr_ns(uint32_t msr, uint32_t lo, uint32_t hi) +{ + /* + * WRMSR is 2 bytes. WRMSRNS is 3 bytes. Pad WRMSR with a redundant CS + * prefix to avoid a trailing NOP. + */ + alternative_input(".byte 0x2e; wrmsr", + ".byte 0x0f,0x01,0xc6", X86_FEATURE_WRMSRNS, + "c" (msr), "a" (lo), "d" (hi)); +} + /* rdmsr with exception handling */ #define rdmsr_safe(msr,val) ({\ int rc_; \ diff --git a/xen/include/public/arch-x86/cpufeatureset.h b/xen/include/public/arch-x86/cpufeatureset.h index ad7e89dd4c40..5444bc5d8374 100644 --- a/xen/include/public/arch-x86/cpufeatureset.h +++ b/xen/include/public/arch-x86/cpufeatureset.h @@ -281,6 +281,7 @@ XEN_CPUFEATURE(AVX512_BF16, 10*32+ 5) /*A AVX512 BFloat16 Instructions */ XEN_CPUFEATURE(FZRM, 10*32+10) /*A Fast Zero-length REP MOVSB */ XEN_CPUFEATURE(FSRS, 10*32+11) /*A Fast Short REP STOSB */ XEN_CPUFEATURE(FSRCS, 10*32+12) /*A Fast Short REP CMPSB/SCASB */ +XEN_CPUFEATURE(WRMSRNS, 10*32+19) /* WRMSR Non-Serialising */ /* AMD-defined CPU features, CPUID level 0x80000021.eax, word 11 */ XEN_CPUFEATURE(LFENCE_DISPATCH, 11*32+ 2) /*A LFENCE always serializing */ -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Tue Jan 10 17:18:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 17:18:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474878.736322 (Exim 4.92) (envelope-from ) id 1pFIH5-0004TH-D0; Tue, 10 Jan 2023 17:18:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474878.736322; Tue, 10 Jan 2023 17:18:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFIH5-0004T2-8v; Tue, 10 Jan 2023 17:18:59 +0000 Received: by outflank-mailman (input) for mailman id 474878; Tue, 10 Jan 2023 17:18:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFIH3-0003S0-Pt for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 17:18:57 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id dc1f739e-910a-11ed-91b6-6bf2151ebd3b; Tue, 10 Jan 2023 18:18:55 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dc1f739e-910a-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1673371135; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=OplqtOF2TCVepI2xNnGz4FHobV4vVNUxy+l935bIbyE=; b=N6+J8k6yv34EOg1DTFfVyosztgSqztT/sVz7NenGSHSyAiebnS15G7Nt 18xjxRWzaXgQxzqBICXtTxTS/30NvvzrBbnbfFHbHETeQK/v0EgLRGclq YVYUl/biioriDNNaAyyP2OZQMO+JwmxcdNggiqGoza2oc4MStePNxPYUt A=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 91449594 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:POXL86vAUteEsYTc3GrAQvmQR+fnVEVeMUV32f8akzHdYApBsoF/q tZmKTuEa/+PZDf9f4wjaoSw8R8D7JPTmNRiGlRrrn8zQStD+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg0HVU/IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj5lv0gnRkPaoQ5AaHzyFOZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwBBsARw+D3s2Nz+yWZ8hpjIc4CPLxI9ZK0p1g5Wmx4fcORJnCR+PB5MNC3Sd2jcdLdRrcT 5NHM3w1Nk2GOkARfAdMYH49tL7Aan3XWjtUsl+K44Ew5HDe1ldZ27nxKtvFPNeNQK25m27J/ z6arjmoXnn2MvTD6QSq+0i1v9X9gArDaNgrKZGU3Nx11Qj7Kms7V0RNCArTTeOColG6c8JSL QoT4CVGhYoY+VGvT9L9dwalu3PCtRkZM/JAHut/5AyTx6785weCGnNCXjNHcMYhtsI9WXotz FDhoj/yLWUx6vvPEyvbr+rK62PpUcQIEYMcTQMvQCIa44DMm45toz/uS9wgC4qOlMKgTFkc3 Au2hCQ5grwSi+sC2KO64U3LjlqQm3TZcuImzl6JBzz4t2uVcKbgPtX1sgaDsZ6sOa7DFjG8U G44d99yBQzkJbWEj2SzTeoEB9lFDN7VYWSH0TaD83TMnglBGkJPn6gKu1mSx28zaK7onAMFh 2eN0T69HLcJYBOXgVZfOupd8fgCw6n6DsjCXfvJdNdIaZUZXFbZo3o0NR/IgD2wyRJEfUQD1 XGzK57E4ZEyUPoP8dZLb71Fje9DKt4WmQs/uqwXPzz4iOHDNRZ5uJ8OMUeUb/BR0U93iFy9z jqrDOPTk083eLSnMkHqHXs7cQhiwY4TWcqn9KS6t4erfmJbJY3WI6SNneJwKtE4wf89eyWh1 ijVZ3K0AWHX3RXvQThmoFg4AF8zdf6TdU4GABE= IronPort-HdrOrdr: A9a23:YMCwkqysP/VV8RpyfE9PKrPw6L1zdoMgy1knxilNoHxuH/Bw9v re+cjzsCWftN9/Yh4dcLy7VpVoIkmsl6Kdg7NwAV7KZmCP1FdARLsI0WKI+UyCJ8SRzI9gPa cLSdkFNDXzZ2IK8PoTNmODYqodKNrsytHWuQ/HpU0dKT2D88tbnn9E4gDwKDwQeCB2QaAXOb C7/cR9qz+paR0sH7+G7ilsZZmkmzXT/qiWGCI7Ow== X-IronPort-AV: E=Sophos;i="5.96,315,1665460800"; d="scan'208";a="91449594" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v2 2/8] x86/prot-key: Enumeration for Protection Key Supervisor Date: Tue, 10 Jan 2023 17:18:39 +0000 Message-ID: <20230110171845.20542-3-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20230110171845.20542-1-andrew.cooper3@citrix.com> References: <20230110171845.20542-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Protection Key Supervisor works in a very similar way to Protection Key User, except that instead of a PKRU register used by the {RD,WR}PKRU instructions, the supervisor protection settings live in MSR_PKRS and is accessed using normal {RD,WR}MSR instructions. PKS has the same problematic interactions with PV guests as PKU (more infact, given the guest kernel's CPL), so we'll only support this for HVM guests for now. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu --- tools/libs/light/libxl_cpuid.c | 1 + tools/misc/xen-cpuid.c | 2 +- xen/arch/x86/include/asm/cpufeature.h | 1 + xen/arch/x86/include/asm/msr-index.h | 2 ++ xen/arch/x86/include/asm/x86-defns.h | 1 + xen/include/public/arch-x86/cpufeatureset.h | 1 + 6 files changed, 7 insertions(+), 1 deletion(-) diff --git a/tools/libs/light/libxl_cpuid.c b/tools/libs/light/libxl_cpuid.c index 2aa23225f42c..cbd4e511e8ab 100644 --- a/tools/libs/light/libxl_cpuid.c +++ b/tools/libs/light/libxl_cpuid.c @@ -211,6 +211,7 @@ int libxl_cpuid_parse_config(libxl_cpuid_policy_list *cpuid, const char* str) {"avx512-vpopcntdq",0x00000007,0,CPUID_REG_ECX, 14, 1}, {"rdpid", 0x00000007, 0, CPUID_REG_ECX, 22, 1}, {"cldemote", 0x00000007, 0, CPUID_REG_ECX, 25, 1}, + {"pks", 0x00000007, 0, CPUID_REG_ECX, 31, 1}, {"avx512-4vnniw",0x00000007, 0, CPUID_REG_EDX, 2, 1}, {"avx512-4fmaps",0x00000007, 0, CPUID_REG_EDX, 3, 1}, diff --git a/tools/misc/xen-cpuid.c b/tools/misc/xen-cpuid.c index d5833e9ce879..ea7ff320e0e4 100644 --- a/tools/misc/xen-cpuid.c +++ b/tools/misc/xen-cpuid.c @@ -134,7 +134,7 @@ static const char *const str_7c0[32] = /* 24 */ [25] = "cldemote", /* 26 */ [27] = "movdiri", [28] = "movdir64b", [29] = "enqcmd", - [30] = "sgx-lc", + [30] = "sgx-lc", [31] = "pks", }; static const char *const str_e7d[32] = diff --git a/xen/arch/x86/include/asm/cpufeature.h b/xen/arch/x86/include/asm/cpufeature.h index 044cfd9f882d..0a301013c3d9 100644 --- a/xen/arch/x86/include/asm/cpufeature.h +++ b/xen/arch/x86/include/asm/cpufeature.h @@ -121,6 +121,7 @@ #define cpu_has_movdiri boot_cpu_has(X86_FEATURE_MOVDIRI) #define cpu_has_movdir64b boot_cpu_has(X86_FEATURE_MOVDIR64B) #define cpu_has_enqcmd boot_cpu_has(X86_FEATURE_ENQCMD) +#define cpu_has_pks boot_cpu_has(X86_FEATURE_PKS) /* CPUID level 0x80000007.edx */ #define cpu_has_hw_pstate boot_cpu_has(X86_FEATURE_HW_PSTATE) diff --git a/xen/arch/x86/include/asm/msr-index.h b/xen/arch/x86/include/asm/msr-index.h index 0a8852f3c246..7615d8087f46 100644 --- a/xen/arch/x86/include/asm/msr-index.h +++ b/xen/arch/x86/include/asm/msr-index.h @@ -148,6 +148,8 @@ #define MSR_PL3_SSP 0x000006a7 #define MSR_INTERRUPT_SSP_TABLE 0x000006a8 +#define MSR_PKRS 0x000006e1 + #define MSR_X2APIC_FIRST 0x00000800 #define MSR_X2APIC_LAST 0x000008ff diff --git a/xen/arch/x86/include/asm/x86-defns.h b/xen/arch/x86/include/asm/x86-defns.h index 42b5f382d438..fe1caba6f819 100644 --- a/xen/arch/x86/include/asm/x86-defns.h +++ b/xen/arch/x86/include/asm/x86-defns.h @@ -74,6 +74,7 @@ #define X86_CR4_SMAP 0x00200000 /* enable SMAP */ #define X86_CR4_PKE 0x00400000 /* enable PKE */ #define X86_CR4_CET 0x00800000 /* Control-flow Enforcement Technology */ +#define X86_CR4_PKS 0x01000000 /* Protection Key Supervisor */ /* * XSTATE component flags in XCR0 diff --git a/xen/include/public/arch-x86/cpufeatureset.h b/xen/include/public/arch-x86/cpufeatureset.h index 7915f5826f57..ad7e89dd4c40 100644 --- a/xen/include/public/arch-x86/cpufeatureset.h +++ b/xen/include/public/arch-x86/cpufeatureset.h @@ -227,6 +227,7 @@ XEN_CPUFEATURE(CLDEMOTE, 6*32+25) /*A CLDEMOTE instruction */ XEN_CPUFEATURE(MOVDIRI, 6*32+27) /*a MOVDIRI instruction */ XEN_CPUFEATURE(MOVDIR64B, 6*32+28) /*a MOVDIR64B instruction */ XEN_CPUFEATURE(ENQCMD, 6*32+29) /* ENQCMD{,S} instructions */ +XEN_CPUFEATURE(PKS, 6*32+31) /* Protection Key for Supervisor */ /* AMD-defined CPU features, CPUID level 0x80000007.edx, word 7 */ XEN_CPUFEATURE(HW_PSTATE, 7*32+ 7) /* Hardware Pstates */ -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Tue Jan 10 17:18:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 17:18:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474875.736283 (Exim 4.92) (envelope-from ) id 1pFIH2-0003VX-EV; Tue, 10 Jan 2023 17:18:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474875.736283; Tue, 10 Jan 2023 17:18:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFIH2-0003Ur-8v; Tue, 10 Jan 2023 17:18:56 +0000 Received: by outflank-mailman (input) for mailman id 474875; Tue, 10 Jan 2023 17:18:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFIH1-0003S0-01 for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 17:18:55 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id dab2f6fd-910a-11ed-91b6-6bf2151ebd3b; Tue, 10 Jan 2023 18:18:53 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dab2f6fd-910a-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1673371133; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=eCREFamTt0EoYJNm1E/bfKdghUubXSF6+VcYofNVBO0=; b=Y4HzCWa3dNjZ8nxtp9pKn19MxQtoCOFlnOVfbf91miE0xYt0OBdnuYED 8fs3uZeiaJ58vRpQCII3FnCMDgHcAynLeXWJId7RivDyRbDRoRwkxKQyE WyVXlfaWKtu+T/HWI0hcdfpQJF8aZV6n4nAHCvHAu3ycgam7XSrgtQzQQ I=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 90908184 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:HlOFja6Ym/vZ55ltzfpHKgxRtCvHchMFZxGqfqrLsTDasY5as4F+v jFNX2rQPanbMDDzKdp0OYni8UlSu5XSyIBhGwtk/i40Hi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraBYnoqLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+4pwehBtC5gZlPakS5AeF/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m6 NwkEiJWUw+/gLyV+ZSaQKpXh/8uI5y+VG8fkikIITDxCP8nRdbIQrnQ5M8e1zA17ixMNa+AP YxDM2MpNUmeJU0UUrsUIMtWcOOAr3/zaTBH7nmSorI6+TP7xw1tyrn9dtHSf7RmQO0ExhfA9 juWowwVBDkhHs7B0iOU0kixubGMsTzjCaxNBuOno6sCbFq7mTVIVUx+uUGAiea9ol6zXZRYM UN80jojq+0++VKmSvH5XgakuziUsxgEQd1SHuYmrgaXxcL8wSyUG2wFRT5pc8E9uYk9QjlC6 7OSt4q3X3o16uTTEC/DsOfPxd+vBcQLBXIiWRUWFjYa3969g7gVrxiMdddYHaHg27UZBgrM6 zyNqSE/gZAagsgKy7i38Dj7vt68mnTaZlVrv1uKBwpJ+is8Pdf4PNLwtTA3+N4adO6kok+9U G/ociR0xMQHFtmzmSOEW43h95n5tq/eYFUwbbOCdqTNFghBGVb5Jui8Axkkfi+F1/ronhe3C HI/QSsLuPdu0IKCNMebmb6ZBcUw1rTHHt/4TP3SZdcmSsEvK1TdrHA2OhPNhjqFfK0QfUcXY 8/znSGEVChyNEia5GDuG7d1PUEDmkjSOl8/tbiklk/6gNJylVaeSKsfMUvmUwzKxPrsnekhy P4Gb5Hi40wGAIXDjtz/rdZ7waYicSJqWvgbaqV/Koa+H+aRMDp9V66AkO58JdcNcmY8vr6gw 0xRk3RwkDLX7UAr4y3WApy/QNsDhapCkE8= IronPort-HdrOrdr: A9a23:VNaTBao4kH69+E0mjWyyoxkaV5oleYIsimQD101hICG9E/b1qy nKpp8mPHDP5wr5NEtPpTnjAsm9qALnlKKdiLN5Vd3OYOCMghrKEGgN1/qG/xTQXwH46+5Bxe NBXsFFebnN5IFB/KTH3DU= X-IronPort-AV: E=Sophos;i="5.96,315,1665460800"; d="scan'208";a="90908184" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v2 1/8] x86/boot: Sanitise PKRU on boot Date: Tue, 10 Jan 2023 17:18:38 +0000 Message-ID: <20230110171845.20542-2-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20230110171845.20542-1-andrew.cooper3@citrix.com> References: <20230110171845.20542-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit While the reset value of the register is 0, it might not be after kexec/etc. If PKEY0.{WD,AD} have leaked in from an earlier context, construction of a PV dom0 will explode. Sequencing wise, this must come after setting CR4.PKE, and before we touch any user mappings. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu For sequencing, it could also come after setting XCR0.PKRU too, but then we'd need to construct an empty XSAVE area to XRSTOR from, and that would be even more horrible to arrange. --- xen/arch/x86/cpu/common.c | 3 +++ xen/arch/x86/include/asm/cpufeature.h | 1 + xen/arch/x86/setup.c | 2 +- 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/xen/arch/x86/cpu/common.c b/xen/arch/x86/cpu/common.c index 0412dbc915e5..fe92f29c2dc6 100644 --- a/xen/arch/x86/cpu/common.c +++ b/xen/arch/x86/cpu/common.c @@ -936,6 +936,9 @@ void cpu_init(void) write_debugreg(6, X86_DR6_DEFAULT); write_debugreg(7, X86_DR7_DEFAULT); + if (cpu_has_pku) + wrpkru(0); + /* * If the platform is performing a Secure Launch via SKINIT, GIF is * clear to prevent external interrupts interfering with Secure diff --git a/xen/arch/x86/include/asm/cpufeature.h b/xen/arch/x86/include/asm/cpufeature.h index a3ad9ebee4e9..044cfd9f882d 100644 --- a/xen/arch/x86/include/asm/cpufeature.h +++ b/xen/arch/x86/include/asm/cpufeature.h @@ -109,6 +109,7 @@ /* CPUID level 0x00000007:0.ecx */ #define cpu_has_avx512_vbmi boot_cpu_has(X86_FEATURE_AVX512_VBMI) +#define cpu_has_pku boot_cpu_has(X86_FEATURE_PKU) #define cpu_has_avx512_vbmi2 boot_cpu_has(X86_FEATURE_AVX512_VBMI2) #define cpu_has_gfni boot_cpu_has(X86_FEATURE_GFNI) #define cpu_has_vaes boot_cpu_has(X86_FEATURE_VAES) diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index 566422600d94..6deadcf74763 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -1798,7 +1798,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) if ( boot_cpu_has(X86_FEATURE_FSGSBASE) ) set_in_cr4(X86_CR4_FSGSBASE); - if ( boot_cpu_has(X86_FEATURE_PKU) ) + if ( cpu_has_pku ) set_in_cr4(X86_CR4_PKE); if ( opt_invpcid && cpu_has_invpcid ) -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Tue Jan 10 17:18:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 17:18:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474876.736290 (Exim 4.92) (envelope-from ) id 1pFIH2-0003cI-Ny; Tue, 10 Jan 2023 17:18:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474876.736290; Tue, 10 Jan 2023 17:18:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFIH2-0003Zm-I0; Tue, 10 Jan 2023 17:18:56 +0000 Received: by outflank-mailman (input) for mailman id 474876; Tue, 10 Jan 2023 17:18:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFIH1-0003S0-PK for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 17:18:55 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id da896568-910a-11ed-91b6-6bf2151ebd3b; Tue, 10 Jan 2023 18:18:53 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: da896568-910a-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1673371133; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=QpOw3C6VwM8FcX6hHOXRu7/mibwXlAuu3I7T3tZcU2Y=; b=OgrY0uZ3A7NGVTz6QwsutsL1L79JMqEB2hMV9187F5tbW+a/OlZmv5t5 NLWm93VR+G3t7qjJsM9cL2EvgEtahExvhYQNHh+i684lJd0oZS7agFOg0 Z5XBmBlqnpF43xvsQlNNcA9cvzx1ZwhM0GJknMX3Z/iCIWngK4NAs+MdM I=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 91449590 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:Li9XpKpB6kbN4mSMqhYPLdNVOKZeBmIxZRIvgKrLsJaIsI4StFCzt garIBnTaavYajekfdp3b4u+908H7JHdzNUwSws4/y0xFH8T9puZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpAFc+E0/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06W1wUmAWP6gR5weHziFNV/rzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXAB9TV1egpr+4++rlWuQ2i8lyHOW3M7pK7xmMzRmBZRonaZXKQqGM7t5ExjYgwMtJGJ4yZ eJAN2ApNk6ZJUQSZBFHU/rSn8/x7pX7WxRepEiYuuwc5G/LwRYq+LPsLMDUapqBQsA9ckOw9 zuaozWkU0ly2Nq3wDi7wFCsjNHzrxj3UpgYMLL7r65YuQjGroAUIEJPDgbqyRWjsWahX/pPJ kpS/TAhxYAx+VKqSJ/hXhS+iH+CohMYHdFXFoUS+AyLj6bZ/QudLmwFVSJaLswrstcsQj4n3 UPPmMnmbRRNmrCITXOW9p+PsCi/fyMSKAc/iTQsFFVfpYO5+cdq00yJHo0L/LOJYsPdNm/Jh BOr8SYF3+sDgJQG2vSL0QzIumf5znTWdTId6gLSV2Ojywp2Yo+5eoClgWTmAeZ8wJWxFQfY4 iVd8ySKxKVXVMzWynTRKAkYNOvxj8tpJgEwlrKG83MJ0z22s0CucolLiN2VDBc4a51UEdMFj aK6hO+w2HOxFCHxBUOUS9jrYyjP8UQHPYqNaxwsRoASCqWdjSfelM2UWWae3nr2jG8nmrwlN JGQfK6EVChFUv43nWLpGrpEi9fHIxzSI0uJHfgXKDz+j9KjiIO9E+9ZYDNikMhlhE97nOkl2 4kGbJbbo/mueOb/fjPW4eYuwaMidBAG6WTNg5UPLIare1M2cFzN/teNmdvNjaQ5xfUK/goJl 1nhMnJlJK3X3iGbeFTbNy09M9sCn/9X9BoGAMDlBn7ws1BLXGplxP13m0cfFVX/yNFe8A== IronPort-HdrOrdr: A9a23:oTZoiq3aFgb5AX9qgrmu5gqjBHYkLtp133Aq2lEZdPU0SKGlfq GV7ZEmPHrP4gr5N0tOpTntAse9qBDnhPxICOsqXYtKNTOO0AeVxelZhrcKqAeQeBEWmNQ96U 9hGZIOcuEZDzJB/LvHCN/TKadd/DGFmprY+ts31x1WPGVXgzkL1XYANu6ceHcGIzVuNN4CO7 e3wNFInDakcWR/VLXBOpFUN9KzweEijfjdEGc7OyI= X-IronPort-AV: E=Sophos;i="5.96,315,1665460800"; d="scan'208";a="91449590" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Kevin Tian Subject: [PATCH v2 6/8] x86/hvm: Enable guest access to MSR_PKRS Date: Tue, 10 Jan 2023 17:18:43 +0000 Message-ID: <20230110171845.20542-7-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20230110171845.20542-1-andrew.cooper3@citrix.com> References: <20230110171845.20542-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Have guest_{rd,wr}msr(), via hvm_{get,set}_reg(), access either the live register, or stashed state, depending on context. Include MSR_PKRS for migration, and let the guest have full access. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu CC: Kevin Tian v2: * Rebase over the get/set_reg() infrastructure. --- xen/arch/x86/hvm/hvm.c | 1 + xen/arch/x86/hvm/vmx/vmx.c | 17 +++++++++++++++++ xen/arch/x86/msr.c | 10 ++++++++++ 3 files changed, 28 insertions(+) diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c index 927a221660e8..c6c1eea18003 100644 --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -1333,6 +1333,7 @@ static int cf_check hvm_load_cpu_xsave_states( static const uint32_t msrs_to_send[] = { MSR_SPEC_CTRL, MSR_INTEL_MISC_FEATURES_ENABLES, + MSR_PKRS, MSR_IA32_BNDCFGS, MSR_IA32_XSS, MSR_VIRT_SPEC_CTRL, diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index b1f493f009fd..57827779c305 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -657,6 +657,11 @@ static void cf_check vmx_cpuid_policy_changed(struct vcpu *v) else vmx_set_msr_intercept(v, MSR_FLUSH_CMD, VMX_MSR_RW); + if ( cp->feat.pks ) + vmx_clear_msr_intercept(v, MSR_PKRS, VMX_MSR_RW); + else + vmx_set_msr_intercept(v, MSR_PKRS, VMX_MSR_RW); + out: vmx_vmcs_exit(v); @@ -2455,6 +2460,7 @@ static uint64_t cf_check vmx_get_reg(struct vcpu *v, unsigned int reg) { const struct vcpu *curr = current; struct domain *d = v->domain; + const struct vcpu_msrs *msrs = v->arch.msrs; uint64_t val = 0; int rc; @@ -2471,6 +2477,9 @@ static uint64_t cf_check vmx_get_reg(struct vcpu *v, unsigned int reg) } return val; + case MSR_PKRS: + return (v == curr) ? rdpkrs() : msrs->pkrs; + case MSR_SHADOW_GS_BASE: if ( v != curr ) return v->arch.hvm.vmx.shadow_gs; @@ -2499,6 +2508,8 @@ static uint64_t cf_check vmx_get_reg(struct vcpu *v, unsigned int reg) static void cf_check vmx_set_reg(struct vcpu *v, unsigned int reg, uint64_t val) { + const struct vcpu *curr = current; + struct vcpu_msrs *msrs = v->arch.msrs; struct domain *d = v->domain; int rc; @@ -2514,6 +2525,12 @@ static void cf_check vmx_set_reg(struct vcpu *v, unsigned int reg, uint64_t val) domain_crash(d); } return; + + case MSR_PKRS: + msrs->pkrs = val; + if ( v == curr ) + wrpkrs(val); + return; } /* Logic which maybe requires remote VMCS acquisition. */ diff --git a/xen/arch/x86/msr.c b/xen/arch/x86/msr.c index 317b154d244d..7ddf0078c3a2 100644 --- a/xen/arch/x86/msr.c +++ b/xen/arch/x86/msr.c @@ -325,6 +325,11 @@ int guest_rdmsr(struct vcpu *v, uint32_t msr, uint64_t *val) *val = 0; break; + case MSR_PKRS: + if ( !cp->feat.pks ) + goto gp_fault; + goto get_reg; + case MSR_X2APIC_FIRST ... MSR_X2APIC_LAST: if ( !is_hvm_domain(d) || v != curr ) goto gp_fault; @@ -616,6 +621,11 @@ int guest_wrmsr(struct vcpu *v, uint32_t msr, uint64_t val) break; goto gp_fault; + case MSR_PKRS: + if ( !cp->feat.pks || val != (uint32_t)val ) + goto gp_fault; + goto set_reg; + case MSR_X2APIC_FIRST ... MSR_X2APIC_LAST: if ( !is_hvm_domain(d) || v != curr ) goto gp_fault; -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Tue Jan 10 17:19:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 17:19:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474879.736328 (Exim 4.92) (envelope-from ) id 1pFIH5-0004a2-Tm; Tue, 10 Jan 2023 17:18:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474879.736328; Tue, 10 Jan 2023 17:18:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFIH5-0004ZF-OP; Tue, 10 Jan 2023 17:18:59 +0000 Received: by outflank-mailman (input) for mailman id 474879; Tue, 10 Jan 2023 17:18:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFIH4-0003S0-QI for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 17:18:58 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id dcb2fe24-910a-11ed-91b6-6bf2151ebd3b; Tue, 10 Jan 2023 18:18:56 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dcb2fe24-910a-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1673371135; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=4kWQkYSpiZBIu90gQLV1EYaENe8mysfk1fvV+p0jEtY=; b=Yy5cNSMLA2BR3bxYAt0zSwq51NKtyLIYeE98unOEo508TO38foAnpOGp tOIk6YKcKalQe75FEFbDOhDrp+Cb3/NyztHQN0AW2xSlTGIFBBpxSr4T6 0kpwFEHhYjiCtEpvh2H1l8XKsmfQ6miYMpHX6aGZ4KCcO2D4wxnGnVRy9 Q=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 90908186 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:9XpW9q/pwj6N3yVagW41DrUDk36TJUtcMsCJ2f8bNWPcYEJGY0x3n DRLCzuFbK2IZjH9eIoiO9nk8E5TsJLTyYM1GQI6+3g8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKucYHsZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kIx1BjOkGlA5AdmPKkT5AS2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklx/ t0ZL2ASSCyIxKG0/o+cUbcvg+kKeZyD0IM34hmMzBncBPciB5vCX7/L9ZlT2zJYasJmRKiEI ZBDMHw2MUqGM0Yn1lQ/UfrSmM+BgHXlfiIeg1WSvactuEDYzRBr0airO93QEjCPbZQNzx7I/ zKYl4j/Kg4aKMSwwheMyVSPts3erR/yfoItPrLto5aGh3XMnzdOWXX6T2CTvv2RmkO4HdVFJ CQ86ico6KQ/6kGvZt38RAGj5m6JuAYGXNhdGPF87xuCooL2yQuEAmkPThZadccr8sQxQFQXO kShxo2zQ2Y16fvMFCzbpuz8QS6O1TY9EmQjZChUUi056Jqgor8OqQmRDdNOOfvg5jHqIg3Yz zePpSk4orwci88Xyqm2lWz6byKQSovhFVBsuFiONo6xxkYgPdP+OdT0gbTOxawYRLt1WGVtq 5TtdyK2yOkVRa+AmyWWKAnmNOH4vq3VWNEwbLMGInXAy9hP0yT4FWyzyGskTKuMDirjUWGBX aMrkVkNjKK/xVPzBUONX6q/Ct4x0Y/rHsn/W/bfY7JmO8YuL1XXrXkxOBPJhQgBdXTAd4llY f93lu71Ux4n5VlPlmLqF4/xL5d3rszB+Y8jbc+ilEn2uVZvTHWUVa0EIDOzghMRtcu5TPHu2 48HbaOikkwPONASlwGLqeb/23hWdylkbX03wuQLHtO+zv1OQz19Wq6AnO5/IOSIXc19z4/1w 510YWcAoHKXuJENAV7ihqxLAF83YatCkA== IronPort-HdrOrdr: A9a23:dyl0+a9aSWYSd8IC7FZuk+DWI+orL9Y04lQ7vn2ZKCY4TiX8ra uTdZsguiMc5Ax+ZJhDo7C90di7IE80nKQdieN9AV7IZniEhILHFvAG0aLShxHmBi3i5qp8+M 5bAsxD4QTLfDpHsfo= X-IronPort-AV: E=Sophos;i="5.96,315,1665460800"; d="scan'208";a="90908186" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v2 3/8] x86/prot-key: Split PKRU infrastructure out of asm/processor.h Date: Tue, 10 Jan 2023 17:18:40 +0000 Message-ID: <20230110171845.20542-4-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20230110171845.20542-1-andrew.cooper3@citrix.com> References: <20230110171845.20542-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit asm/processor.h is in desperate need of splitting up, and protection key functionality in only used in the emulator and pagewalk. Introduce a new asm/prot-key.h and move the relevant content over. Rename the PKRU_* constants to drop the user part and to use the architectural terminology. Drop the read_pkru_{ad,wd}() helpers entirely. The pkru infix is about to become wrong, and the sole user is shorter and easier to follow without the helpers. No functional change. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu v2: * Mask pk_ar --- xen/arch/x86/cpu/common.c | 1 + xen/arch/x86/include/asm/processor.h | 38 ------------------------------------ xen/arch/x86/include/asm/prot-key.h | 31 +++++++++++++++++++++++++++++ xen/arch/x86/mm/guest_walk.c | 9 ++++++--- xen/arch/x86/x86_emulate.c | 2 ++ 5 files changed, 40 insertions(+), 41 deletions(-) create mode 100644 xen/arch/x86/include/asm/prot-key.h diff --git a/xen/arch/x86/cpu/common.c b/xen/arch/x86/cpu/common.c index fe92f29c2dc6..2bcdd08b2fb5 100644 --- a/xen/arch/x86/cpu/common.c +++ b/xen/arch/x86/cpu/common.c @@ -11,6 +11,7 @@ #include #include #include +#include #include #include #include diff --git a/xen/arch/x86/include/asm/processor.h b/xen/arch/x86/include/asm/processor.h index 60b902060914..b95d2483212a 100644 --- a/xen/arch/x86/include/asm/processor.h +++ b/xen/arch/x86/include/asm/processor.h @@ -374,44 +374,6 @@ static always_inline void set_in_cr4 (unsigned long mask) write_cr4(read_cr4() | mask); } -static inline unsigned int rdpkru(void) -{ - unsigned int pkru; - - asm volatile (".byte 0x0f,0x01,0xee" - : "=a" (pkru) : "c" (0) : "dx"); - - return pkru; -} - -static inline void wrpkru(unsigned int pkru) -{ - asm volatile ( ".byte 0x0f, 0x01, 0xef" - :: "a" (pkru), "d" (0), "c" (0) ); -} - -/* Macros for PKRU domain */ -#define PKRU_READ (0) -#define PKRU_WRITE (1) -#define PKRU_ATTRS (2) - -/* - * PKRU defines 32 bits, there are 16 domains and 2 attribute bits per - * domain in pkru, pkeys is index to a defined domain, so the value of - * pte_pkeys * PKRU_ATTRS + R/W is offset of a defined domain attribute. - */ -static inline bool_t read_pkru_ad(uint32_t pkru, unsigned int pkey) -{ - ASSERT(pkey < 16); - return (pkru >> (pkey * PKRU_ATTRS + PKRU_READ)) & 1; -} - -static inline bool_t read_pkru_wd(uint32_t pkru, unsigned int pkey) -{ - ASSERT(pkey < 16); - return (pkru >> (pkey * PKRU_ATTRS + PKRU_WRITE)) & 1; -} - static always_inline void __monitor(const void *eax, unsigned long ecx, unsigned long edx) { diff --git a/xen/arch/x86/include/asm/prot-key.h b/xen/arch/x86/include/asm/prot-key.h new file mode 100644 index 000000000000..63a2e22f3fa0 --- /dev/null +++ b/xen/arch/x86/include/asm/prot-key.h @@ -0,0 +1,31 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * Copyright (c) 2021-2022 Citrix Systems Ltd. + */ +#ifndef ASM_PROT_KEY_H +#define ASM_PROT_KEY_H + +#include + +#define PKEY_AD 1 /* Access Disable */ +#define PKEY_WD 2 /* Write Disable */ + +#define PKEY_WIDTH 2 /* Two bits per protection key */ + +static inline uint32_t rdpkru(void) +{ + uint32_t pkru; + + asm volatile ( ".byte 0x0f,0x01,0xee" + : "=a" (pkru) : "c" (0) : "dx" ); + + return pkru; +} + +static inline void wrpkru(uint32_t pkru) +{ + asm volatile ( ".byte 0x0f,0x01,0xef" + :: "a" (pkru), "d" (0), "c" (0) ); +} + +#endif /* ASM_PROT_KEY_H */ diff --git a/xen/arch/x86/mm/guest_walk.c b/xen/arch/x86/mm/guest_walk.c index 70dacc477f9a..161a61b8f5ca 100644 --- a/xen/arch/x86/mm/guest_walk.c +++ b/xen/arch/x86/mm/guest_walk.c @@ -26,7 +26,9 @@ #include #include #include + #include +#include #include #include @@ -413,10 +415,11 @@ guest_walk_tables(const struct vcpu *v, struct p2m_domain *p2m, guest_pku_enabled(v) ) { unsigned int pkey = guest_l1e_get_pkey(gw->l1e); - unsigned int pkru = rdpkru(); + unsigned int pkr = rdpkru(); + unsigned int pk_ar = (pkr >> (pkey * PKEY_WIDTH)) & (PKEY_AD | PKEY_WD); - if ( read_pkru_ad(pkru, pkey) || - ((walk & PFEC_write_access) && read_pkru_wd(pkru, pkey) && + if ( (pk_ar & PKEY_AD) || + ((walk & PFEC_write_access) && (pk_ar & PKEY_WD) && ((walk & PFEC_user_mode) || guest_wp_enabled(v))) ) { gw->pfec |= PFEC_prot_key; diff --git a/xen/arch/x86/x86_emulate.c b/xen/arch/x86/x86_emulate.c index 720740f29b84..8c7d18521807 100644 --- a/xen/arch/x86/x86_emulate.c +++ b/xen/arch/x86/x86_emulate.c @@ -12,8 +12,10 @@ #include #include #include + #include #include /* current_cpu_info */ +#include #include #include /* cpu_has_amd_erratum() */ #include -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Tue Jan 10 17:18:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 17:18:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474877.736310 (Exim 4.92) (envelope-from ) id 1pFIH4-0004By-1o; Tue, 10 Jan 2023 17:18:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474877.736310; Tue, 10 Jan 2023 17:18:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFIH3-0004AN-Tt; Tue, 10 Jan 2023 17:18:57 +0000 Received: by outflank-mailman (input) for mailman id 474877; Tue, 10 Jan 2023 17:18:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFIH2-0003S0-Pd for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 17:18:56 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id dc0f24b7-910a-11ed-91b6-6bf2151ebd3b; Tue, 10 Jan 2023 18:18:54 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dc0f24b7-910a-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1673371134; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=mz05xHRr3qRTB02QoQaO+mfrlV8+T4q/+0C/A1xaNc4=; b=WCMh4zFl/PlKETTmaZaTzzCqqUISfUDIWTgdYv6Wc3UHoVjC2MZrlF2X OKwuN+6zoErEtRoWe+73iGe6L7KJzQWjLwcakiwXyTUYMni30IKi8Yrrx gi/HAdNQm1+ULJ1P6VpXvlhxxHo/Sg8CfHialbIaCedQioL1BJABR6zUT Q=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 90908185 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:28nkk6wk8XHfTO+NWwV6t+cexirEfRIJ4+MujC+fZmUNrF6WrkUAm zcZWm2AMv2IZzDxedF/bYyx/EoD7MTXztdiHgZoqCAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTbaeYUidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+U0HUMja4mtC5QRnPKgT5zcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KV5F1 P0feC8rUhvAxOCI/ZWgFKppq+12eaEHPKtH0p1h5TTQDPJgSpHfWaTao9Rf2V/chOgXQ6yYP ZBAL2MyMlKQOHWjOX9OYH46tM6uimPybHtzr1WNqLBsy2PS0BZwwP7mN9+9ltmiFJ0ExhbB9 j+uE2LRJywELsyD8zi5+VWegeTAwAnGep9PLejtnhJtqALKnTFCYPEMbnOkpdGph0j4XMhQQ 2QX9zQvq+4u9UWtZtj7QxC85nWDu3Y0S9dWVuE39gyJ4q7V+BqCQHgJSCZbb94rv9NwQiYlv nertd70AT1ksJWOVGmQsLyTqFuP1TM9dDFYI3VeFE1cvoel8NpbYg/zoshLL6WUj9qlBhfMy HPJrhYDoK5Nzssm/vDulbzYuA6Eqp/MRw8zwwzYWGO58w90DLKYi5yUBUvztqgZctvAJrWVl D1dwpXFsrhSZX2YvHbVKNjhCo1F8Bps3Nf0pVd0V6cs+D22k5JIVdABuWouTKuF3yttRNMIX KMxkVkKjHOwFCHwBUOSX25WI5pC8EQYPY65Ps04l/IXCnSLSCeJ/Tt1eWmb1H33nU4nnMkXY MnEKpz8XC5FVPk+llJaotvxN5dxnkjSIkuKG/jGI+mPi+LCNBZ5t59ZWLdxUgzJxPzd+1iEm zquH8CL1w9eQIXDjtr/qOYuwaQxBSFjX/je8pUHHtNv1yI6QAnN/deNm+J+E2Gk9owJ/tr1E oaVARMEmQuu2CCZcm1nqBlLMdvSYHq2llpjVQREALpi8yRLjVqHhEvHS6YKQA== IronPort-HdrOrdr: A9a23:Ts+48qvM/T/hIseqttiTepL+7skDeNV00zEX/kB9WHVpm62j+/ xG+c5x6faaslkssR0b9+xoWpPhfZqsz/9ICOAqVN/JMTUO01HYT72Kg7GSpgHIKmnT8fNcyL clU4UWMqyVMbGit7eZ3DWF X-IronPort-AV: E=Sophos;i="5.96,315,1665460800"; d="scan'208";a="90908185" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Kevin Tian Subject: [PATCH v2 0/8] x86: Protection Key Supervisor support Date: Tue, 10 Jan 2023 17:18:37 +0000 Message-ID: <20230110171845.20542-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Only 14 months after v1... This time with testing on real hardware (not that any bugs were found) and against an updated XTF comprehensive pagewalk test. # time ./xtf-runner hvm64 pagetable-emulation~hap --- Xen Test Framework --- Environment: HVM 64bit (Long mode 4 levels) Test pagetable-emulation Info: Intel, Fam 6, Model 143, Stepping 3, paddr 46, vaddr 48 Features: PSE PAE PGE PAT PSE36 PCID NX PAGE1G SMEP SMAP PKU PKS Paging mode heuristic: Hap Using physical addresses 0000000040000000 and 0000200000000000 Test L1e Test L2e Test L2e Superpage Test L3e Test L3e Superpage Test L4e Test L4e Superpage Completed 28835840 tests Test result: SUCCESS Combined test results: test-hvm64-pagetable-emulation~hap SUCCESS real 1m26.315s user 0m0.039s sys 0m0.086s This test is going to get even more silly when CET-SS becomes supported. Andrew Cooper (8): x86/boot: Sanitise PKRU on boot x86/prot-key: Enumeration for Protection Key Supervisor x86/prot-key: Split PKRU infrastructure out of asm/processor.h x86: Initial support for WRMSRNS x86/hvm: Context switch MSR_PKRS x86/hvm: Enable guest access to MSR_PKRS x86/pagewalk: Support PKS x86/hvm: Support PKS for HAP guests tools/libs/light/libxl_cpuid.c | 2 + tools/misc/xen-cpuid.c | 3 +- xen/arch/x86/cpu/common.c | 6 ++ xen/arch/x86/cpuid.c | 9 +++ xen/arch/x86/hvm/hvm.c | 5 +- xen/arch/x86/hvm/vmx/vmx.c | 26 +++++++++ xen/arch/x86/include/asm/cpufeature.h | 2 + xen/arch/x86/include/asm/guest_pt.h | 5 ++ xen/arch/x86/include/asm/hvm/hvm.h | 3 + xen/arch/x86/include/asm/msr-index.h | 2 + xen/arch/x86/include/asm/msr.h | 21 +++++++ xen/arch/x86/include/asm/processor.h | 38 ------------- xen/arch/x86/include/asm/prot-key.h | 85 +++++++++++++++++++++++++++++ xen/arch/x86/include/asm/x86-defns.h | 1 + xen/arch/x86/mm/guest_walk.c | 16 ++++-- xen/arch/x86/msr.c | 10 ++++ xen/arch/x86/setup.c | 6 +- xen/arch/x86/smpboot.c | 4 ++ xen/arch/x86/x86_emulate.c | 2 + xen/include/public/arch-x86/cpufeatureset.h | 2 + 20 files changed, 201 insertions(+), 47 deletions(-) create mode 100644 xen/arch/x86/include/asm/prot-key.h -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Tue Jan 10 17:19:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 17:19:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474880.736344 (Exim 4.92) (envelope-from ) id 1pFIH8-00054l-8N; Tue, 10 Jan 2023 17:19:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474880.736344; Tue, 10 Jan 2023 17:19:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFIH8-00054T-1o; Tue, 10 Jan 2023 17:19:02 +0000 Received: by outflank-mailman (input) for mailman id 474880; Tue, 10 Jan 2023 17:19:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFIH5-0003S0-QM for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 17:18:59 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id dc27791f-910a-11ed-91b6-6bf2151ebd3b; Tue, 10 Jan 2023 18:18:56 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dc27791f-910a-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1673371136; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=nq9rxCSKOSFBwm6aWpKwYZFwQDRPg+/dlW9R5ZTrDnU=; b=f3zU8CdTxfe1VDbWjgv1M/n1ISXt4fe0NTFDgM9gE5MStm3U/n75NAwu uYYujmpeJKHSQpshSWyrRt1PFYzxKFj0CRZdUlsoOzJf6dIdqm8OWsFlP ydJwQF+39MnP+dkfs3U7e+cqLulfWC5VDhEYVDmJ9QZMTzzcqMc3hUDBc A=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 90908188 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:58OJS6qHUup8gnBYIg57y4Gp9bdeBmIxZRIvgKrLsJaIsI4StFCzt garIBmHOK2LNjDxc4wkYNm2oB8Dv8CGzYIxTAc5/HsxES4Qp5uZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpAFc+E0/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06W1wUmAWP6gR5weHziFNV/rzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXADoqVkCypc3s+72Ed7FGqdocF9S0EapK7xmMzRmBZRonaZXKQqGM7t5ExjYgwMtJGJ4yZ eJAN2ApNk6ZJUQSZBFHU/rSn8/x7pX7WxRepEiYuuwc5G/LwRYq+LPsLMDUapqBQsA9ckOw9 zqXpzSgUkFy2Nq3kDmB0H+jmLD2hirZBN09C562yuJRjwjGroAUIEJPDgbqyRWjsWahX/pPJ kpS/TAhxYAx+VKqSJ/hXhS+iH+CohMYHdFXFoUS+AyLj6bZ/QudLmwFVSJaLswrstcsQj4n3 UPPmMnmbRRNmrCITXOW9p+PsCi/fyMSKAc/iTQsFFVfpYO5+cdq00yJHo0L/LOJYsPdExbIk wGog3IFiIou1eQkyZqA4A/qqmf5znTWdTId6gLSV2Ojywp2Yo+5eoClgWTmAeZ8wJWxFQfY4 iVd8ySKxKVXVMzWynTRKAkYNOvxj8tpJgEwlrKG83MJ0z22s0CucolLiN2VDBc4a51UEdMFj aK6hO+w2HOxFCHxBUOUS9jrYyjP8UQHPYqNaxwsRoASCqWdjSfelM2UWWae3nr2jG8nmrwlN JGQfK6EVChFUv43nWLpGrpEi9fHIxzSI0uJHfgXKDz+j9KjiIO9E+9ZYDNikMhlhE97nOkl2 4kGbJbbo/mueOb/fjPW4eYuwaMidBAG6WTNg5UPLIare1M2cFzN/teNmdvNjaQ5xfUK/goJl 1nhMnJlJK3X3iGbeFTbNy09M9sCn/9X9BoGAMDlBn7ws1BLXGplxPl3m0cfFVX/yNFe8A== IronPort-HdrOrdr: A9a23:ZLPzHar/LmCAuSlV/CUVsGkaV5rveYIsimQD101hICG9Evb0qy nOpoV/6faQslwssR4b9uxoVJPvfZq+z+8W3WByB9eftWDd0QPFEGgL1+DfKlbbak7DH4BmtJ uJc8JFeafN5VoRt7eG3OFveexQvOVu88qT9JjjJ28Gd3APV0n5hT0JcjpyFCdNNW57LKt8Lr WwzOxdqQGtfHwGB/7LfUXsD4D41rv2fIuNW29+OyIa X-IronPort-AV: E=Sophos;i="5.96,315,1665460800"; d="scan'208";a="90908188" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Kevin Tian Subject: [PATCH v2 5/8] x86/hvm: Context switch MSR_PKRS Date: Tue, 10 Jan 2023 17:18:42 +0000 Message-ID: <20230110171845.20542-6-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20230110171845.20542-1-andrew.cooper3@citrix.com> References: <20230110171845.20542-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Under PKS, MSR_PKRS is available and based on the CPUID policy alone, and usable independently of CR4.PKS. See the large comment in prot-key.h for details of the context switching arrangement. Use WRMSRNS right away, as we don't care about serialsing properties for context switching this MSR. Sanitise MSR_PKRS on boot. In anticipation of wanting to use PKS for Xen in the future, arrange for the sanitisation to occur prior to potentially setting CR4.PKS; if PKEY0.{AD,WD} leak in from a previous context, we will triple fault immediately on setting CR4.PKS. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu CC: Kevin Tian v2: * Use WRMSRNS * Sanitise MSR_PKS on boot. --- xen/arch/x86/cpu/common.c | 2 ++ xen/arch/x86/hvm/vmx/vmx.c | 9 +++++++ xen/arch/x86/include/asm/msr.h | 9 +++++++ xen/arch/x86/include/asm/prot-key.h | 54 +++++++++++++++++++++++++++++++++++++ xen/arch/x86/setup.c | 4 +++ xen/arch/x86/smpboot.c | 4 +++ 6 files changed, 82 insertions(+) diff --git a/xen/arch/x86/cpu/common.c b/xen/arch/x86/cpu/common.c index 2bcdd08b2fb5..f44c907e8a43 100644 --- a/xen/arch/x86/cpu/common.c +++ b/xen/arch/x86/cpu/common.c @@ -58,6 +58,8 @@ static unsigned int forced_caps[NCAPINTS]; DEFINE_PER_CPU(bool, full_gdt_loaded); +DEFINE_PER_CPU(uint32_t, pkrs); + void __init setup_clear_cpu_cap(unsigned int cap) { const uint32_t *dfs; diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index 43a4865d1c76..b1f493f009fd 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -58,6 +58,7 @@ #include #include #include +#include #include static bool_t __initdata opt_force_ept; @@ -536,6 +537,7 @@ static void vmx_restore_host_msrs(void) static void vmx_save_guest_msrs(struct vcpu *v) { + const struct cpuid_policy *cp = v->domain->arch.cpuid; struct vcpu_msrs *msrs = v->arch.msrs; /* @@ -549,10 +551,14 @@ static void vmx_save_guest_msrs(struct vcpu *v) rdmsrl(MSR_RTIT_OUTPUT_MASK, msrs->rtit.output_mask); rdmsrl(MSR_RTIT_STATUS, msrs->rtit.status); } + + if ( cp->feat.pks ) + msrs->pkrs = rdpkrs_and_cache(); } static void vmx_restore_guest_msrs(struct vcpu *v) { + const struct cpuid_policy *cp = v->domain->arch.cpuid; const struct vcpu_msrs *msrs = v->arch.msrs; write_gs_shadow(v->arch.hvm.vmx.shadow_gs); @@ -569,6 +575,9 @@ static void vmx_restore_guest_msrs(struct vcpu *v) wrmsrl(MSR_RTIT_OUTPUT_MASK, msrs->rtit.output_mask); wrmsrl(MSR_RTIT_STATUS, msrs->rtit.status); } + + if ( cp->feat.pks ) + wrpkrs(msrs->pkrs); } void vmx_update_cpu_exec_control(struct vcpu *v) diff --git a/xen/arch/x86/include/asm/msr.h b/xen/arch/x86/include/asm/msr.h index 191e54068856..7946b6b24c11 100644 --- a/xen/arch/x86/include/asm/msr.h +++ b/xen/arch/x86/include/asm/msr.h @@ -373,6 +373,15 @@ struct vcpu_msrs }; } rtit; + /* + * 0x000006e1 - MSR_PKRS - Protection Key Supervisor. + * + * Exposed R/W to guests. Xen doesn't use PKS yet, so only context + * switched per vcpu. When in current context, live value is in hardware, + * and this value is stale. + */ + uint32_t pkrs; + /* 0x00000da0 - MSR_IA32_XSS */ struct { uint64_t raw; diff --git a/xen/arch/x86/include/asm/prot-key.h b/xen/arch/x86/include/asm/prot-key.h index 63a2e22f3fa0..0dcd31b7ea68 100644 --- a/xen/arch/x86/include/asm/prot-key.h +++ b/xen/arch/x86/include/asm/prot-key.h @@ -5,8 +5,11 @@ #ifndef ASM_PROT_KEY_H #define ASM_PROT_KEY_H +#include #include +#include + #define PKEY_AD 1 /* Access Disable */ #define PKEY_WD 2 /* Write Disable */ @@ -28,4 +31,55 @@ static inline void wrpkru(uint32_t pkru) :: "a" (pkru), "d" (0), "c" (0) ); } +/* + * Xen does not use PKS. + * + * Guest kernel use is expected to be one default key, except for tiny windows + * with a double write to switch to a non-default key in a permitted critical + * section. + * + * As such, we want MSR_PKRS un-intercepted. Furthermore, as we only need it + * in Xen for emulation or migration purposes (i.e. possibly never in a + * domain's lifetime), we don't want to re-sync the hardware value on every + * vmexit. + * + * Therefore, we read and cache the guest value in ctxt_switch_from(), in the + * expectation that we can short-circuit the write in ctxt_switch_to(). + * During regular operations in current context, the guest value is in + * hardware and the per-cpu cache is stale. + */ +DECLARE_PER_CPU(uint32_t, pkrs); + +static inline uint32_t rdpkrs(void) +{ + uint32_t pkrs, tmp; + + rdmsr(MSR_PKRS, pkrs, tmp); + + return pkrs; +} + +static inline uint32_t rdpkrs_and_cache(void) +{ + return this_cpu(pkrs) = rdpkrs(); +} + +static inline void wrpkrs(uint32_t pkrs) +{ + uint32_t *this_pkrs = &this_cpu(pkrs); + + if ( *this_pkrs != pkrs ) + { + *this_pkrs = pkrs; + + wrmsr_ns(MSR_PKRS, pkrs, 0); + } +} + +static inline void wrpkrs_and_cache(uint32_t pkrs) +{ + this_cpu(pkrs) = pkrs; + wrmsr_ns(MSR_PKRS, pkrs, 0); +} + #endif /* ASM_PROT_KEY_H */ diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index 6deadcf74763..567a0a42ac50 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -54,6 +54,7 @@ #include #include #include +#include #include /* opt_nosmp: If true, secondary processors are ignored. */ @@ -1804,6 +1805,9 @@ void __init noreturn __start_xen(unsigned long mbi_p) if ( opt_invpcid && cpu_has_invpcid ) use_invpcid = true; + if ( cpu_has_pks ) + wrpkrs_and_cache(0); /* Must be before setting CR4.PKS */ + init_speculation_mitigations(); init_idle_domain(); diff --git a/xen/arch/x86/smpboot.c b/xen/arch/x86/smpboot.c index 52beed9d8d6d..b26758c2c89f 100644 --- a/xen/arch/x86/smpboot.c +++ b/xen/arch/x86/smpboot.c @@ -42,6 +42,7 @@ #include #include #include +#include #include #include #include @@ -364,6 +365,9 @@ void start_secondary(void *unused) /* Full exception support from here on in. */ + if ( cpu_has_pks ) + wrpkrs_and_cache(0); /* Must be before setting CR4.PKS */ + /* Safe to enable feature such as CR4.MCE with the IDT set up now. */ write_cr4(mmu_cr4_features); -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Tue Jan 10 17:19:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 17:19:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474881.736350 (Exim 4.92) (envelope-from ) id 1pFIH8-000580-SC; Tue, 10 Jan 2023 17:19:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474881.736350; Tue, 10 Jan 2023 17:19:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFIH8-00057K-EC; Tue, 10 Jan 2023 17:19:02 +0000 Received: by outflank-mailman (input) for mailman id 474881; Tue, 10 Jan 2023 17:19:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFIH6-0003S0-Qe for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 17:19:00 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id dd6eb98c-910a-11ed-91b6-6bf2151ebd3b; Tue, 10 Jan 2023 18:18:57 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dd6eb98c-910a-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1673371137; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=JEFM5DgSMIlHdoI6Ogj3/3vP8p3vve1BuSmFbdoNBC0=; b=CkJfXtGAuvEjg0fSpmAQpDOtb+a/xGUkfpEjtXNssU8v2WwoUpN+LrCE BNOR5fBNcTNCMEstQpPOj5d3C70hhJSospZ6FMmPZN1MGoOCOjdcAwMs0 VZh3zUeU+0rARogkOGXgh5OrojteeuIrFnL764w/j/A4VGfx9gRiSjdmy k=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 90908190 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:DbCNyqvq0Vx5DDVZ2p/52hYuvufnVEVeMUV32f8akzHdYApBsoF/q tZmKTuAP66DZWHwLt5yYYq+p0gAvZXSy4VnQQQ4+Ho2Ri4T+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg0HVU/IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj5lv0gnRkPaoQ5AaHzyFOZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwIhc1PiGhqLiNz42GEsNDmPsYMZbGFdZK0p1g5Wmx4fcORJnCR+PB5MNC3Sd2jcdLdRrcT 5NHM3w1Nk2GOkARfAdMYH49tL7Aan3XWjtUsl+K44Ew5HDe1ldZ27nxKtvFPNeNQK25m27J/ jOerz2oWnn2MvSE1ziV0WuHhdbzoiH3V78oL7aa5NBD1Qj7Kms7V0RNCArTTeOColG6c8JSL QoT4CVGhbg/8gmnQ8fwWzW8oWWYpVgMVtxICeo45QqRjK3O7G6xJEIJUzpAY9wOr9ItSHoh0 Vrhoj/yLWUx6vvPEyvbr+rK62PpUcQIEYMcTSUjdVs0wfa5m44Ms0rlYchcK7Pqo/SgTFkc3 Au2hCQ5grwSi+sC2KO64U3LjlqQm3TZcuImzl6JBzz4t2uVcKbgPtX1sgaDsZ6sOa7DFjG8U G44d99yBQzkJbWEj2SzTeoEB9lFDN7VYWSH0TaD83TMnglBGkJPn6gKu1mSx28zaK7onAMFh 2eN0T69HLcJYBOXgVZfOupd8fgCw6n6DsjCXfvJdNdIaZUZXFbZo3o0NR/IgD2wyRJEfUQD1 XGzK57E4ZEyUPoP8dZLb71Fje9DKt4WmQs/uqwXPzz4iOHDNRZ5uJ8OMUeUb/BR0U93iFy9z jqrDOPTk083eLSnMkHqHXs7cQhiwY4TWcqn9KS6t4erfmJbJY3WI6SNneJwKtE4wf89eyWh1 ijVZ3K0AWHX3RXvQThmoFg9AF8zdf6TdU4GABE= IronPort-HdrOrdr: A9a23:oRLJXKi0dBOuc7/fiMW0v9kprnBQXh4ji2hC6mlwRA09TyX5ra 2TdZUgpHrJYVMqMk3I9uruBEDtex3hHP1OkOss1NWZPDUO0VHARO1fBOPZqAEIcBeOldK1u5 0AT0B/YueAd2STj6zBkXSF+wBL+qj6zEiq792usEuEVWtRGsVdB58SMHfiLqVxLjM2YqYRJd 6nyedsgSGvQngTZtTTPAh/YwCSz+e78q4PeHQ9dmca1DU= X-IronPort-AV: E=Sophos;i="5.96,315,1665460800"; d="scan'208";a="90908190" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v2 7/8] x86/pagewalk: Support PKS Date: Tue, 10 Jan 2023 17:18:44 +0000 Message-ID: <20230110171845.20542-8-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20230110171845.20542-1-andrew.cooper3@citrix.com> References: <20230110171845.20542-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit PKS is very similar to the existing PKU behaviour, operating on pagewalks for any supervisor mapping. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu --- xen/arch/x86/include/asm/guest_pt.h | 5 +++++ xen/arch/x86/include/asm/hvm/hvm.h | 3 +++ xen/arch/x86/mm/guest_walk.c | 9 +++++---- 3 files changed, 13 insertions(+), 4 deletions(-) diff --git a/xen/arch/x86/include/asm/guest_pt.h b/xen/arch/x86/include/asm/guest_pt.h index 6647ccfb8520..6802db2a415a 100644 --- a/xen/arch/x86/include/asm/guest_pt.h +++ b/xen/arch/x86/include/asm/guest_pt.h @@ -282,6 +282,11 @@ static always_inline bool guest_pku_enabled(const struct vcpu *v) return !is_pv_vcpu(v) && hvm_pku_enabled(v); } +static always_inline bool guest_pks_enabled(const struct vcpu *v) +{ + return !is_pv_vcpu(v) && hvm_pks_enabled(v); +} + /* Helpers for identifying whether guest entries have reserved bits set. */ /* Bits reserved because of maxphysaddr, and (lack of) EFER.NX */ diff --git a/xen/arch/x86/include/asm/hvm/hvm.h b/xen/arch/x86/include/asm/hvm/hvm.h index 93254651f2f5..65768c797ea7 100644 --- a/xen/arch/x86/include/asm/hvm/hvm.h +++ b/xen/arch/x86/include/asm/hvm/hvm.h @@ -407,6 +407,8 @@ int hvm_get_param(struct domain *d, uint32_t index, uint64_t *value); ((v)->arch.hvm.guest_efer & EFER_NXE) #define hvm_pku_enabled(v) \ (hvm_paging_enabled(v) && ((v)->arch.hvm.guest_cr[4] & X86_CR4_PKE)) +#define hvm_pks_enabled(v) \ + (hvm_paging_enabled(v) && ((v)->arch.hvm.guest_cr[4] & X86_CR4_PKS)) /* Can we use superpages in the HAP p2m table? */ #define hap_has_1gb (!!(hvm_funcs.hap_capabilities & HVM_HAP_SUPERPAGE_1GB)) @@ -911,6 +913,7 @@ static inline void hvm_set_reg(struct vcpu *v, unsigned int reg, uint64_t val) #define hvm_smap_enabled(v) ((void)(v), false) #define hvm_nx_enabled(v) ((void)(v), false) #define hvm_pku_enabled(v) ((void)(v), false) +#define hvm_pks_enabled(v) ((void)(v), false) #define arch_vcpu_block(v) ((void)(v)) diff --git a/xen/arch/x86/mm/guest_walk.c b/xen/arch/x86/mm/guest_walk.c index 161a61b8f5ca..76b4e0425887 100644 --- a/xen/arch/x86/mm/guest_walk.c +++ b/xen/arch/x86/mm/guest_walk.c @@ -406,16 +406,17 @@ guest_walk_tables(const struct vcpu *v, struct p2m_domain *p2m, #if GUEST_PAGING_LEVELS >= 4 /* 64-bit only... */ /* * If all access checks are thus far ok, check Protection Key for 64bit - * data accesses to user mappings. + * data accesses. * * N.B. In the case that the walk ended with a superpage, the fabricated * gw->l1e contains the appropriate leaf pkey. */ - if ( (ar & _PAGE_USER) && !(walk & PFEC_insn_fetch) && - guest_pku_enabled(v) ) + if ( !(walk & PFEC_insn_fetch) && + ((ar & _PAGE_USER) ? guest_pku_enabled(v) + : guest_pks_enabled(v)) ) { unsigned int pkey = guest_l1e_get_pkey(gw->l1e); - unsigned int pkr = rdpkru(); + unsigned int pkr = (ar & _PAGE_USER) ? rdpkru() : rdpkrs(); unsigned int pk_ar = (pkr >> (pkey * PKEY_WIDTH)) & (PKEY_AD | PKEY_WD); if ( (pk_ar & PKEY_AD) || -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Tue Jan 10 17:19:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 17:19:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474882.736363 (Exim 4.92) (envelope-from ) id 1pFIHA-0005XK-6d; Tue, 10 Jan 2023 17:19:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474882.736363; Tue, 10 Jan 2023 17:19:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFIH9-0005VV-UW; Tue, 10 Jan 2023 17:19:03 +0000 Received: by outflank-mailman (input) for mailman id 474882; Tue, 10 Jan 2023 17:19:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFIH7-0003S0-Qg for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 17:19:01 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id dc65418a-910a-11ed-91b6-6bf2151ebd3b; Tue, 10 Jan 2023 18:18:57 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dc65418a-910a-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1673371137; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=C9gSfgX+9i+r0YwgaULSxlIhX07TJ2xDDOE7SZdYeBY=; b=NcvoAQWciyRAbIkLgnVc9iNEg66rZ8SSLjF+pZfL9Jrh7hkPNp6lxqUY bYP+y1xr8nUp/gEAkT41lPMFLhjhROGEj1HDBlIs6O1msHSW/mE//WDif MLY3PPmyM3n7ftk0GMRlrPawHgfYBEMU2+Wc/Ao0xPPGmMUFbfiFRf1n9 o=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 91967753 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:YwnKM6zuo4bG75SfPt16t+ckxirEfRIJ4+MujC+fZmUNrF6WrkUPz mRKUWzXPK2MajSnet0lYY7k8ktS6MDUxoNjG1ZvqCAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTbaeYUidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+U0HUMja4mtC5QRnPKgT5zcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KW1y8 985EjkAUhfdhPm38ZGfYM9Fpct2eaEHPKtH0p1h5TTQDPJgSpHfWaTao9Rf2V/chOgXQ6yYP ZBAL2MyMlKQOHWjOX9OYH46tM6uimPybHtzr1WNqLBsy2PS0BZwwP7mN9+9ltmiFJwEwBnH+ zmuE2LRWw9HLfnHxCK8o1mR3/bFsgy8A49CG+jtnhJtqALKnTFCYPEMbnOkpdGph0j4XMhQQ 2QE9yxroaUs+UiDStjmQwb+sHOCpgQbWddbD6s98g7l4oj+7hudB2MEZiVcc9Fgv8gzLQHGz XfQwYmvX2Y29uTIFzTNrd94sA9eJwAZEWkhRBUNQDcCvdr4obAQqjjpZ/VsRfvdYsLOJRn8x DWDrS4bjroVjNIW26jTwW0rkw5AtbCSEFdru1y/snaNq1ogOdX7P9DABU3zt64oEWqPcrWWU JHoceC65ftGM5yCnTflrA4lTODwvKbt3NExbDdS83gdG9aFoSXLkWN4umsWyKJV3iEsJ1fUj Lf741852XOqFCLCgVVLS4ywEd826qPrCM7oUPvZBvIXPMcqLl/WpH4zOBfKt4wIrKTKuftnU Xt8WZ/yZUv29Iw9lGbmLwvj+eNDKt8CKZP7GsmgkkXPPUu2b3+JU7YVWGZinchghJ5oVD79q o4FX+PTkkU3bQELSnWPmWLlBQxQfCdT6FGfg5A/S9Nv1SI9RD1wWq6MnO16E2Gn9owM/tr1E riGchcw4DLCabfvcG1mtlgLhGvTYKtC IronPort-HdrOrdr: A9a23:H2/ClqFyTJLFRUOopLqELMeALOsnbusQ8zAXPiBKJCC9E/bo8v xG+c5w6faaslkssR0b9+xoW5PwI080l6QU3WB5B97LMDUO0FHCEGgI1/qA/9SPIUzDHu4279 YbT0B9YueAcGSTW6zBkXWF+9VL+qj5zEix792uq0uE1WtRGtldBwESMHf9LmRGADNoKLAeD5 Sm6s9Ot1ObCA8qhpTSPAhiYwDbzee77a7bXQ== X-IronPort-AV: E=Sophos;i="5.96,315,1665460800"; d="scan'208";a="91967753" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v2 8/8] x86/hvm: Support PKS for HAP guests Date: Tue, 10 Jan 2023 17:18:45 +0000 Message-ID: <20230110171845.20542-9-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20230110171845.20542-1-andrew.cooper3@citrix.com> References: <20230110171845.20542-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit With all infrastructure in place, advertise the PKS CPUID bit to HAP guests, and let them set CR4.PKS. Experiment with a tweak to the layout of hvm_cr4_guest_valid_bits() so future additions will be just a single added line. The current context switching behaviour is tied to how VT-x works, so leave a safety check in the short term. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu --- xen/arch/x86/cpuid.c | 9 +++++++++ xen/arch/x86/hvm/hvm.c | 4 +++- xen/include/public/arch-x86/cpufeatureset.h | 2 +- 3 files changed, 13 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/cpuid.c b/xen/arch/x86/cpuid.c index acc2f606cea8..b22725c492e7 100644 --- a/xen/arch/x86/cpuid.c +++ b/xen/arch/x86/cpuid.c @@ -579,6 +579,15 @@ static void __init calculate_hvm_max_policy(void) __clear_bit(X86_FEATURE_XSAVES, hvm_featureset); } + /* + * Xen doesn't use PKS, so the guest support for it has opted to not use + * the VMCS load/save controls for efficiency reasons. This depends on + * the exact vmentry/exit behaviour, so don't expose PKS in other + * situations until someone has cross-checked the behaviour for safety. + */ + if ( !cpu_has_vmx ) + __clear_bit(X86_FEATURE_PKS, hvm_featureset); + guest_common_feature_adjustments(hvm_featureset); sanitise_featureset(hvm_featureset); diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c index c6c1eea18003..606f0e864981 100644 --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -969,7 +969,9 @@ unsigned long hvm_cr4_guest_valid_bits(const struct domain *d) (p->feat.smep ? X86_CR4_SMEP : 0) | (p->feat.smap ? X86_CR4_SMAP : 0) | (p->feat.pku ? X86_CR4_PKE : 0) | - (cet ? X86_CR4_CET : 0)); + (cet ? X86_CR4_CET : 0) | + (p->feat.pks ? X86_CR4_PKS : 0) | + 0); } static int cf_check hvm_load_cpu_ctxt(struct domain *d, hvm_domain_context_t *h) diff --git a/xen/include/public/arch-x86/cpufeatureset.h b/xen/include/public/arch-x86/cpufeatureset.h index 5444bc5d8374..3b85bcca1537 100644 --- a/xen/include/public/arch-x86/cpufeatureset.h +++ b/xen/include/public/arch-x86/cpufeatureset.h @@ -227,7 +227,7 @@ XEN_CPUFEATURE(CLDEMOTE, 6*32+25) /*A CLDEMOTE instruction */ XEN_CPUFEATURE(MOVDIRI, 6*32+27) /*a MOVDIRI instruction */ XEN_CPUFEATURE(MOVDIR64B, 6*32+28) /*a MOVDIR64B instruction */ XEN_CPUFEATURE(ENQCMD, 6*32+29) /* ENQCMD{,S} instructions */ -XEN_CPUFEATURE(PKS, 6*32+31) /* Protection Key for Supervisor */ +XEN_CPUFEATURE(PKS, 6*32+31) /*H Protection Key for Supervisor */ /* AMD-defined CPU features, CPUID level 0x80000007.edx, word 7 */ XEN_CPUFEATURE(HW_PSTATE, 7*32+ 7) /* Hardware Pstates */ -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Tue Jan 10 18:08:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 18:08:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474932.736383 (Exim 4.92) (envelope-from ) id 1pFJ2P-0004uY-47; Tue, 10 Jan 2023 18:07:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474932.736383; Tue, 10 Jan 2023 18:07:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFJ2P-0004uR-18; Tue, 10 Jan 2023 18:07:53 +0000 Received: by outflank-mailman (input) for mailman id 474932; Tue, 10 Jan 2023 18:07:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFJ2N-0004uL-M8 for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 18:07:52 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b0133454-9111-11ed-91b6-6bf2151ebd3b; Tue, 10 Jan 2023 19:07:49 +0100 (CET) Received: from mail-bn1nam02lp2049.outbound.protection.outlook.com (HELO NAM02-BN1-obe.outbound.protection.outlook.com) ([104.47.51.49]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 10 Jan 2023 13:07:42 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DM6PR03MB5132.namprd03.prod.outlook.com (2603:10b6:5:1e4::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 18:07:40 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5986.018; Tue, 10 Jan 2023 18:07:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b0133454-9111-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1673374069; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=MdqVEpphdJImzJSpUifrpqkuvfmbJ6VAe+5o7miVXh4=; b=V0itUQyhzoOSmOkLCuNHT80dFQr0VjOcEk/q83Ysrn9B2XyA14M9wdGq eGinUEj9EcGt2FNdPBCg6YupcrNm3+xoAmXVjdQxGy16CScnhs82MsC36 P6VwcmH+1RXF37AyInc4fvV5La7ShRcvZxzndZF2XDtPgibJ3H+eFrcSf s=; X-IronPort-RemoteIP: 104.47.51.49 X-IronPort-MID: 94445988 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:6Aifuq668Slxi4rXLDSqowxRtAHGchMFZxGqfqrLsTDasY5as4F+v mYfWDyCbP2JZWOgeN10bN+0pxtT65/VmII1TQY5/300Hi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraBYnoqLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+4pwehBtC5gZlPakS5AeF/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m7 /wFAjctYim/qM2v2pGKG+BHos0vFZy+VG8fkikIITDxK98DGcqGaYOToNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6OlUotgdABM/KMEjCObexTklyVu STt+GPhDwtBHNee1SCE4jSngeqncSbTCd5OSODppq4CbFu712kBKiwIWGmH+9aemEOcBe5He xMG0397xUQ13AnxJjXnZDWorXjBshMCVt54F+wh9BrL2qfS+xyeBGUPUnhGctNOnO0cSCEu1 1SJt8j0HjEpu7qQIVqC8p+EoDX0PjIaRUcBaDEFS00Z4tDliIA1kh/LCN1kFcaIYsbdHDjxx 3WAqnE4jrBL18oTjf3nrBbAni6moYXPQkgt/ALLU2m57wR/Iom4e4iv7lud5vFFRGqEcmS8U LE/s5D2xIgz4VulzURhnM1l8GmV2su4 IronPort-HdrOrdr: A9a23:aRqv2q+kGb5QVFJ/S51uk+H2dr1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYW4qKQodcdDpAtjifZtFnaQFrbX5To3SJjUO31HYY72KjLGSjgEIfheTygcz79 YGT0ETMrzN5B1B/L7HCWqDYpgdKbu8gcaVbI7lph8DIz2CKZsQljuRYTzrcHGeMTM2YabRY6 Dsg/avyQDBRV0nKuCAQlUVVenKoNPG0LrgfB49HhYirCWekD+y77b+Mh6AmjMTSSlGz7sO+X XM11WR3NTij9iLjjvnk0PD5ZVfn9XsjvNFGcy3k8AQbhn8lwqyY4xlerua+BQ4uvum5loGmM TF5z0gI8NwwXXMeXzdm2qt5yDQlBIVr1Pyw16RhnXu5ebjQighNsZHjYVFNjPE9ksJprhHoe B29lPck6ASIQLLnSz76dSNfQptjFCIrX0rlvNWp2BDULEZdKRaoeUkjQZo+dY7bWbHAbIcYa 9T5fLnla9rmJShHijkV1xUsZuRt7IIb0y7qwY5y5aoOnNt7Q1EJgMjtbAidzE7hdEAotB/lp r52u4DrsAwcuYGKa16H+sPWs2xFyjERg/NKnubJRD9GLgAIG+lke++3Fyb3pDZRHUk9upFpH 36aiIQiUciP0b1TcGe1pxC9R7ABG27QDT208lbo5x0oKf1SrbnOTCKDAlGqbrrn9wPRsnAH/ qjMpNfBPHuaWPoBIZSxgX7H51fM2MXXsEZsssyH1iOvsXIIIv3sfGzSoeZGJP9VTI/Hm/vCH oKWzb+YM1G80CwQ3f9xAPcXnv8E3aPiq6Y0JKqi9T75LJ9RbGk6DJl+GhRzvv7WQFqo+gxYF Z0Jq/hn+eyuXS2lFy4mllUBg== X-IronPort-AV: E=Sophos;i="5.96,315,1665460800"; d="scan'208";a="94445988" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KXBj/6Jbjdkl1GrEhBfUc7QJYFH6Gft0Mp72o2p1JIzWTIKZZ3SGZzOF4HrhCriTkdt8pU9kYC8637Q+whhWLXuUe2iGUmDV7abMLiVR80cKQSMaV/ERcAv4Pq0kOGK6Zilgx7LE4DX0thrwywVaKaVCdynEvMcaTbwTcUCEskjbj9tM/AcpvFXbQP/KC3dm2+pVXu57OqKV5MtETWoZUz3n4iYjmd340CgFz/RU3VqR+l3rwtqNEuiJm6U4YgzeS78TGgZ4uG9Izd5du7wyqTOHLkud0P3L4QlVfsQmkc/PNAqrMi7EJ76P+2O1FAj3oSWg2e0dmF9bSqldxqXjPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MdqVEpphdJImzJSpUifrpqkuvfmbJ6VAe+5o7miVXh4=; b=YgIY07I2xALE9rqhYEBzb7o9jSmlISrIIKRMunRvUlxMzOpx+gNSW/DqLwldt8ZqQTvgavM4c0pXyDAzcHUv2+xJtyL6EHDoIVH5JK6OupPvow4C5iLvxoiUJbuSIu21KQn7urOoR97pEXH/wr+ZiGAZ+oGnjpuh2h8dVMMvfKmvFxHkR30ANkkNWmFe1RE4gWeIfiqUNGbuAbyOQrhLn0k6EQqq+zPKcLpeYcOAXf7eaaY/E+iAOwBQLH77EbNQeVjhQGz0FsQvFkiHLOd8fMbDS6YwfW+Hxk3yGWDFU6NHOrppf7EdCrWgVrrRxpCLdVrnN6Oaad3UbL5spRC63g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MdqVEpphdJImzJSpUifrpqkuvfmbJ6VAe+5o7miVXh4=; b=gkmNLeC1xBU48YLCErIwZT0o/AkVXDKRJ+XFA8fJYOoC/e6DsgVE5aUeOrJGgH/+59ovhrVcu5qie1An8tIdS5KZgqo5pXA+wRxiaaMZhQ3EcD8/x4S9EpMYq7zGLhoQTE+cwUPXA96hEL8LFqNm8vAKvQ1sdJ8LM+Y360SCPSA= From: Andrew Cooper To: Andrew Cooper , Xen-devel CC: Jan Beulich , Roger Pau Monne , Wei Liu , Kevin Tian Subject: Re: [PATCH v2 6/8] x86/hvm: Enable guest access to MSR_PKRS Thread-Topic: [PATCH v2 6/8] x86/hvm: Enable guest access to MSR_PKRS Thread-Index: AQHZJReeV/6Z/BfYW0W8YgpP3+cAB66X8qqA Date: Tue, 10 Jan 2023 18:07:39 +0000 Message-ID: <798bf587-06c2-bdf3-646d-bc3da2a9a566@citrix.com> References: <20230110171845.20542-1-andrew.cooper3@citrix.com> <20230110171845.20542-7-andrew.cooper3@citrix.com> In-Reply-To: <20230110171845.20542-7-andrew.cooper3@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|DM6PR03MB5132:EE_ x-ms-office365-filtering-correlation-id: a2ce736f-a0a7-436c-859d-08daf3358fc8 x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: J+duAl60zo5hWAQafLCYvrIiVv/ysllt1P+QNsxZlH8FGyiI8TcCYIMsu+MPSzvjR39wPNVCr1LNAGYDerHsMs6Q5tlnFDpCIqMVXJ1RtL0zPJfTwQxPfqK7WQXx4+ImuDqqeRHO0Z1Ss6ob6aZVS4qSCHyixEpMjyySuJdRwGzUCgOKxyNkLqmLWdCqM2YvctsHQoRh/4ISRkk0xuWHXN/4PWYa7akDR9oESlDZ1PLDJnCNemMqmmRxKr+rwLo0OKmZSNSyNMB5h5D7KGl4JVSdXcX2U4i1J5IHLWcXDyJsJ0rXEVY/ylV19axrRmTjCw3qLLgMY7IB14cn94kU1rkYbdL7vnZxGxV7vMq3iVTHxZ2WHsG5cgg3zrApnLTuF6IqZYDkAXxWwQC40cgH8MeL5+dHD9hwGMk35qeuwekpkRB+n98LkHkZ+h9eBAHO3T3ulW6zaCiP9MSHVzVnHNJ1wjB5n/QlQjRh2gJOc/YOg1WUX9ojja8EM2tquYulWdYzcgOWuqzh++dw24mfNqPPiPPENE0535TjqkFq+1mo+S+drbkywHaYz6lpTvd4x8DjAOatwjsUyz8UY0ylnTuYqh5JR0uwnj5WJxYQhM+/+7VjuJYJcZvma0YgLkhzwzYg4cWnB4pue9tkTs8m4l/oFqAFlAytDvbVIBI+vOQO3EBkVSSll9oDkLppGhvVsYm8zayLuXWHjiOEPieznki6bi65pdQc5yxRHYh/USipUOQD2B070sdbN8ETe9AFh+/yPKKdUBQBFcFdXuGN/w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(366004)(39860400002)(346002)(396003)(376002)(451199015)(36756003)(186003)(26005)(53546011)(122000001)(8936002)(31686004)(6512007)(6506007)(2616005)(66946007)(5660300002)(66446008)(66556008)(66476007)(64756008)(316002)(91956017)(4326008)(38070700005)(86362001)(71200400001)(31696002)(76116006)(38100700002)(82960400001)(478600001)(6486002)(54906003)(41300700001)(8676002)(110136005)(83380400001)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ajZVZk5JMmExWklCelpOSjdqZjNYUThFV2hwdXVHU2s0czl4OFR4NHZpRmJM?= =?utf-8?B?RUJ3QjRPMFlHaXQ2SzZQOVNyeWdEVGVDeGxmc0U1RnVtb2tpSnUxcUFsZUtM?= =?utf-8?B?K1RHWGFSNVpKM2wxeXVuREdpaUJKU1hoaWtTVWFWSFhJZHdwS1lUL2QzRGpr?= =?utf-8?B?d25LZHFGWEVZNUtUNFNVZTNxZEJDRUJlZ3ZNVlRiYVd4L2ZJaXhVYjVjQlNT?= =?utf-8?B?MTRFMEpQc1lhUDBwcTBqeFdSRU13M0tuQmtjV25QREcyM1lkaGRmbkllcFR6?= =?utf-8?B?dUdlWStwVVpKc2h0ejBoT1NVZUI1OGRadE5QN0JNL3Y2UUpPVnBsMkFNYUZP?= =?utf-8?B?dnFzOFBVTzMrdWNneENMWnpIQ2FRQmRXNDRqUUtxRzdvTW1WR0dFQ1c2WG45?= =?utf-8?B?N0Z5Zm05Y01xNzVUeVRYUmZuN1NQWEptS3FIc2dVU2dON0ZaTXNlUnk2OTU0?= =?utf-8?B?ejFEd08yLzZBK2NVbnhDMm05VkhBd1R2SjJFMDZzYzRrMnBWOE5XRGlNUUlO?= =?utf-8?B?RzZmV2FzOWdNVmp5a2NZV05pOVd6R3NwRnE2bFNMR0t3S28xV2pmbS9DdEt2?= =?utf-8?B?Qkxra1laSCtjNjBtTHp2SGlBTll2OTZiUk9sMTBlcktKNmJ0T1R5TE5wSU8x?= =?utf-8?B?Y2xxMWVxelh4dWZKemNESElUWGE3OVFTSkozNVlaRHZIamxtTGwyM2pWQU9C?= =?utf-8?B?R0hscXBuUE40eTg3ZkYzRjkwN0FsRXh1UUlqRlR5ZXZ3OWM4R09STFEvM0pE?= =?utf-8?B?c1ZJZDdUU0cyNUtHMkR3QzlBbXViU29SOGluelI5M0RVeE04NFFrODRIeGZt?= =?utf-8?B?NmRFS2p4WVNWN2R3MEpoTnhsSFNmcTl1MC9TZlh0L3lyRC9URGpJcVlyUEtp?= =?utf-8?B?MlI4bEZ2eWFkL2t4SWNQY2hHa0pSK3J5RVNycXFZWjd3RXNSZDRDY1JTQ3Bt?= =?utf-8?B?dmxaeGZoWThhMi9pNFYzRlJobkVHTGFQV1ZYZ3g5VFNmdVgyQzFvVCtSYjZo?= =?utf-8?B?R1pyMitDaTVHZk01VE1SblRWUVpHS3dLUXBwOTN1aDNXaitGSkJoZ2FTcFhq?= =?utf-8?B?SFZrZndOU05RNVhiYUFPRHdiekdjOTQvN2V5VGd3VkF1emp0V0tiajFsNzN5?= =?utf-8?B?cmhlRGhrTUo1RStZeFBvS3BTRFJoSEttQlVPcDJSYnkrd2F5ZDBZU3hhbFBx?= =?utf-8?B?T245dEMrcDEyVUUyV3J1NWE2djJZQXpYR1hEcWtxQ1Awc1EwSkx3Mmlvci9F?= =?utf-8?B?NVFvRjVwaDY3UFh0SkZHdVBaUEU0cE5pTkVZaEZZd2JQSTZMZGpSSTdaT3Z3?= =?utf-8?B?M08xeFJiei84WFJMWS9PN0huZ3ZhQU1oY3VHWFRBZ0hTdnh5Y0E1cEc4UlFH?= =?utf-8?B?c0JQN25xNXhLSTFzbVl1V1ZlNll5Qk9FSkREWXR2UCtna2JoRzBnajNDbFJy?= =?utf-8?B?VEdCblFYeGFwRFFxZG9oaWtLQzZETXVseUxsTVd6WHNMQ0xUVGtMbk5PM00x?= =?utf-8?B?WlhLUXVZaGtCZVI0QnVOUFNBVDUwL2VISmhZTHMwbDFWS2RmczI2a05ReEpX?= =?utf-8?B?bTFKSFNKYklRWDdQVE90REVJUUp4MFRncmtZY3RGL1JQREYxRk55c1FUQ09Z?= =?utf-8?B?OUxVY29NUDRKdStXY2RLc0FmRTZxVy9IKzV5a2dPdy9OODZicWRVbU0xY1dq?= =?utf-8?B?MHlKSzVZcVI1VWtjWlcrd001QkVrUG5ZVUowbTZFRW9WSVduSjBMaFFOdXV4?= =?utf-8?B?bGk5OGJnZGVxOERJQlhkcEVJVFI3TFFFVGV6eG41T0ZvaFptQWJSa3llQ2hO?= =?utf-8?B?UHl0RmJLckdtekpWaXRnd1A4SkwrMkJqaUxQbnQ4STkwR3ZvazlORGhUckJE?= =?utf-8?B?Ly8xVHBwMkp0OG5sTSt3RU1UQzJ6ZjlISWU4Z202TXJGMEgvTFRKR3hxcnBC?= =?utf-8?B?ZmhiU3I1blBPOVlmOGEvUGlHM3hZMVFCM1p1SnNhL1lQSDlIYXU0ak4rb3Iv?= =?utf-8?B?blN4SzlMdXpGT2d0Q3dDWmwrdDNBeG92RjcwTjZLZHJoTHVNQ01Ed21MKzBy?= =?utf-8?B?cGpjQXYzVTJMYkZNWC9uVFZFOTRCVlIra2tUVXZlVkxtbHluY25zaDhSZkl0?= =?utf-8?Q?8YPR/XB8gEv4YVuCPDgmi1Lg+?= Content-Type: text/plain; charset="utf-8" Content-ID: <0A177FF677FDDD42BEBD0973D4FB9674@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: PGKj8lhuTeQzvwXVYTXfEK2lvu8WuqP8CVCdrdLcnfhwTxwI8HqdJCTZFMAlAdZjNr/St92xS9NWZCaBxYnpAfKhlFrxnsiPLX0CgnmSYS2zSIaomTqG3WeuZBGcdm1p0ySnud71BA4FtqdE0GLbmj++zgmyswnxxsUhFW6YCQbonch8kdxvExXieu/JqOj8beNg/R6jm9t+rZLG0CvLf1UhGfft2TUgN5Hu7wd0JPgfrXSi76S/zW0DAanvLJwnDxXDzsiGdx27lCiWgYBIHPCvkecPZT/Kl8Hw/nv6siDfDBqpt2ffhAwAznEIfbDtOKeLdGpT8d+HNWVXPzBu3AVP1TZcexmPN/l3TCRzkI7VcQWKsHCVkiV4+lQXLJkPHVYYxRJ/xMKmAz9HFFZExFpGxWRyFM5iaAGD7HuObArJFCrtFqDLlBymgtvX6K9WG0DAYXqJF8x7TtZg7I/Gbfps8KG7ADW5R7rQWY2/GlMnzIIMYouZGJeafNO+zveTUsmgqoGZMrcuGmHFc3zMfN1pOay4eFuwDSDYGXanMg4nCkwyY9oJMtzgQYtVx1mJZGGNT8/o5i2ttEgQuskHjJP2O9ush8aaEArnVIp6qz9qtEV1RGMCNCN6+q4YG4cTdfSxTrIIKW7EQ06En3cNtrrcR0IyDkAuZdbegS6SUyPzADE2wkjvjPMQO3gsWL2FFBoKEZfz2UBrJGacHFbPkmgv3KSCJrTP1GAdGk8ucyK2X/1iMU6kxjIezD2FePi0FLCo7MghMi9t4zwkPZpVKCsjD2E2IbCeVMpsT4cDgOz+nZsRXJ8wC5LYs+pE6o6npnf+prsmJP9aGkFUAZ0hhesd8KSvlKCJNiozGmpk9HI= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a2ce736f-a0a7-436c-859d-08daf3358fc8 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jan 2023 18:07:39.6821 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /QhVEsWY6oawseMrLl4RRFT/MgzKboZT8AwlAa4mDBh7noxRSwz5WiIWEK9V0ViMRP/1iH3zBd9u/hNL0XlQT4vGeDX0C+h4HuiVpbE6u+o= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5132 T24gMTAvMDEvMjAyMyA1OjE4IHBtLCBBbmRyZXcgQ29vcGVyIHdyb3RlOg0KPiBIYXZlIGd1ZXN0 X3tyZCx3cn1tc3IoKSwgdmlhIGh2bV97Z2V0LHNldH1fcmVnKCksIGFjY2VzcyBlaXRoZXIgdGhl IGxpdmUNCj4gcmVnaXN0ZXIsIG9yIHN0YXNoZWQgc3RhdGUsIGRlcGVuZGluZyBvbiBjb250ZXh0 LiAgSW5jbHVkZSBNU1JfUEtSUyBmb3INCj4gbWlncmF0aW9uLCBhbmQgbGV0IHRoZSBndWVzdCBo YXZlIGZ1bGwgYWNjZXNzLg0KPg0KPiBTaWduZWQtb2ZmLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRy ZXcuY29vcGVyM0BjaXRyaXguY29tPg0KPiBSZXZpZXdlZC1ieTogSmFuIEJldWxpY2ggPGpiZXVs aWNoQHN1c2UuY29tPg0KPiAtLS0NCj4gQ0M6IEphbiBCZXVsaWNoIDxKQmV1bGljaEBzdXNlLmNv bT4NCj4gQ0M6IFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPg0KPiBDQzog V2VpIExpdSA8d2xAeGVuLm9yZz4NCj4gQ0M6IEtldmluIFRpYW4gPGtldmluLnRpYW5AaW50ZWwu Y29tPg0KPg0KPiB2MjoNCj4gICogUmViYXNlIG92ZXIgdGhlIGdldC9zZXRfcmVnKCkgaW5mcmFz dHJ1Y3R1cmUuDQo+IC0tLQ0KPiAgeGVuL2FyY2gveDg2L2h2bS9odm0uYyAgICAgfCAgMSArDQo+ ICB4ZW4vYXJjaC94ODYvaHZtL3ZteC92bXguYyB8IDE3ICsrKysrKysrKysrKysrKysrDQo+ICB4 ZW4vYXJjaC94ODYvbXNyLmMgICAgICAgICB8IDEwICsrKysrKysrKysNCj4gIDMgZmlsZXMgY2hh bmdlZCwgMjggaW5zZXJ0aW9ucygrKQ0KPg0KPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L2h2 bS9odm0uYyBiL3hlbi9hcmNoL3g4Ni9odm0vaHZtLmMNCj4gaW5kZXggOTI3YTIyMTY2MGU4Li5j NmMxZWVhMTgwMDMgMTAwNjQ0DQo+IC0tLSBhL3hlbi9hcmNoL3g4Ni9odm0vaHZtLmMNCj4gKysr IGIveGVuL2FyY2gveDg2L2h2bS9odm0uYw0KPiBAQCAtMTMzMyw2ICsxMzMzLDcgQEAgc3RhdGlj IGludCBjZl9jaGVjayBodm1fbG9hZF9jcHVfeHNhdmVfc3RhdGVzKA0KPiAgc3RhdGljIGNvbnN0 IHVpbnQzMl90IG1zcnNfdG9fc2VuZFtdID0gew0KPiAgICAgIE1TUl9TUEVDX0NUUkwsDQo+ICAg ICAgTVNSX0lOVEVMX01JU0NfRkVBVFVSRVNfRU5BQkxFUywNCj4gKyAgICBNU1JfUEtSUywNCj4g ICAgICBNU1JfSUEzMl9CTkRDRkdTLA0KPiAgICAgIE1TUl9JQTMyX1hTUywNCj4gICAgICBNU1Jf VklSVF9TUEVDX0NUUkwsDQoNCk5lZWRzIHRoZSBmb2xsb3dpbmcgaHVuayB0b286DQoNCmRpZmYg LS1naXQgYS94ZW4vYXJjaC94ODYvaHZtL2h2bS5jIGIveGVuL2FyY2gveDg2L2h2bS9odm0uYw0K aW5kZXggYzZjMWVlYTE4MDAzLi44NmNhYjdhYTI2MjcgMTAwNjQ0DQotLS0gYS94ZW4vYXJjaC94 ODYvaHZtL2h2bS5jDQorKysgYi94ZW4vYXJjaC94ODYvaHZtL2h2bS5jDQpAQCAtMTQ4Nyw2ICsx NDg3LDcgQEAgc3RhdGljIGludCBjZl9jaGVjayBodm1fbG9hZF9jcHVfbXNycyhzdHJ1Y3QNCmRv bWFpbiAqZCwgaHZtX2RvbWFpbl9jb250ZXh0X3QgKmgpDQrCoA0KwqDCoMKgwqDCoMKgwqDCoCBj YXNlIE1TUl9TUEVDX0NUUkw6DQrCoMKgwqDCoMKgwqDCoMKgIGNhc2UgTVNSX0lOVEVMX01JU0Nf RkVBVFVSRVNfRU5BQkxFUzoNCivCoMKgwqDCoMKgwqDCoCBjYXNlIE1TUl9QS1JTOg0KwqDCoMKg wqDCoMKgwqDCoCBjYXNlIE1TUl9JQTMyX0JORENGR1M6DQrCoMKgwqDCoMKgwqDCoMKgIGNhc2Ug TVNSX0lBMzJfWFNTOg0KwqDCoMKgwqDCoMKgwqDCoCBjYXNlIE1TUl9WSVJUX1NQRUNfQ1RSTDoN Cg0KZm9yIHRoZSByZWNlaXZlIHNpZGUgb2YgbWlncmF0aW9uIHRvIHdvcmsuDQoNCn5BbmRyZXcN Cg== From xen-devel-bounces@lists.xenproject.org Tue Jan 10 19:16:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 19:16:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474938.736394 (Exim 4.92) (envelope-from ) id 1pFK6V-00040S-40; Tue, 10 Jan 2023 19:16:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474938.736394; Tue, 10 Jan 2023 19:16:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFK6U-00040L-WF; Tue, 10 Jan 2023 19:16:11 +0000 Received: by outflank-mailman (input) for mailman id 474938; Tue, 10 Jan 2023 19:16:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFK6U-00040F-70 for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 19:16:10 +0000 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [2a00:1450:4864:20::52b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3cc27a69-911b-11ed-91b6-6bf2151ebd3b; Tue, 10 Jan 2023 20:16:08 +0100 (CET) Received: by mail-ed1-x52b.google.com with SMTP id i9so19100517edj.4 for ; Tue, 10 Jan 2023 11:16:08 -0800 (PST) Received: from 2a02.2378.10b2.ddc1.ip.kyivstar.net ([2a02:2378:10b2:ddc1:8e79:90f9:af64:1818]) by smtp.gmail.com with ESMTPSA id p1-20020aa7cc81000000b00499cc326a4fsm913311edt.9.2023.01.10.11.16.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jan 2023 11:16:07 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3cc27a69-911b-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=o828iz6JTK7okONjfswkpoOBjebJS1MqqtT+ftr793o=; b=QE2F3WSP/YvMYIQ1z1dwdkfsDuVoyIZvAQiSfLeGX5hkDoY7H+ZU2iSARZsURKcO0v uWZ1lxiMXl/8uvtBSpSsuL9KmEv1lZKUGSLAY5+XJWmA5D1mY/7ILKFJODGBK/qLoUYD zyX0oRRGcEceJ4vFbUTlTbzBHSbWYZc/Xt+g+xij484C6veurxRUlv7prUwPCX+YUeF4 YNBJX3aJfQDqOjfMaxf1tDjtiIDVQ1UnkBhcFdLjcBI1A5CzUCVbBRaRMubxouBPO7Qy 5wmhWjSxbpt5Ch0m9S8YAFxfVreAjkyJlwciL3T0MEFzucUs8UFk9b/uC/ptod9diowH E90g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=o828iz6JTK7okONjfswkpoOBjebJS1MqqtT+ftr793o=; b=CpETLYbTmuWlAV/rGTO6ZP/QkRSilxp+xgj0OARQEzQ8Ec/b5A/42cdMGAL08Dvi9x FSqz5tiz3rN2BeG+y6tJIOshGRdUVl2ujOva3kwQvwCCqepj01+KqmJya7l7LC2sgIpW c0WhbhWkuUvaX35Fc/LOH/PngWiguiaw4UjB4MCfVl3zT8bucSvkxRVDch7Dk9RHfFyw Snyx2onMhLBxnRUSz+8F6Z6igj4HK3xmmGECDMIvax2n9QH5jAvrRsGg+vUUHg9lml4N ssTgvF9IkCOw0AsG9RKsGuWbWzo9DaUg6t6PLhIRmqnE8MD3CPz3x2TB6U2lgU5A5hMB 3gYg== X-Gm-Message-State: AFqh2kqLvZRRJrdhjN6jq6xxVt/MJprjtPkz/YyH9yH4GmEySawOFMCK jpKIp6fUuSp6CiRGLWI42RU= X-Google-Smtp-Source: AMrXdXuHJIh9tZBmajvoQ7sCEV6H+1VltAy2kFAubizjyqbH5gL5D1lgW/EEXM/x741+O9swxLfkYQ== X-Received: by 2002:a05:6402:501c:b0:48f:a9a2:29fa with SMTP id p28-20020a056402501c00b0048fa9a229famr23532127eda.2.1673378168420; Tue, 10 Jan 2023 11:16:08 -0800 (PST) Message-ID: Subject: Re: [PATCH v3 1/6] xen/riscv: introduce dummy asm/init.h From: Oleksii To: Jan Beulich , Julien Grall , Stefano Stabellini , Bertrand Marquis Cc: Andrew Cooper , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org Date: Tue, 10 Jan 2023 21:16:06 +0200 In-Reply-To: <891d0830-7fdc-202a-5f12-2364cae5bce5@suse.com> References: <891d0830-7fdc-202a-5f12-2364cae5bce5@suse.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 Hello Jan, Sorry for breaking into the conversation. On Tue, 2023-01-10 at 18:02 +0100, Jan Beulich wrote: > Arm maintainers, >=20 > On 10.01.2023 16:17, Oleksii Kurochko wrote: > > --- /dev/null > > +++ b/xen/arch/riscv/include/asm/init.h > > @@ -0,0 +1,12 @@ > > +#ifndef _XEN_ASM_INIT_H > > +#define _XEN_ASM_INIT_H > > + > > +#endif /* _XEN_ASM_INIT_H */ >=20 > instead of having RISC-V introduce an empty stub matching what x86 > has, Have you had a chance to look at the answer (Re: [PATCH v1 0/8] Basic early_printk and smoke test implementation) of Andrew: https://lore.kernel.org/xen-devel/299d913c-8095-ad90-ea3b-d46ef74d4fdc@citr= ix.com/#t I agree with his point regarding the usage of __has_include() to not produce empty headers stubs for RISCV and for future architectures too. > If maintainers are OK I can start to use __has_include() in the > correspondent files.what would it take to empty Arm's as > well, allowing both present ones to > go away and no new one to be introduced? The only thing you have in > there > is struct init_info, which doesn't feel like it's properly placed in > this > header (x86 has such stuff in setup.h) ... >=20 > Jan ~Oleksii From xen-devel-bounces@lists.xenproject.org Tue Jan 10 20:33:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 20:33:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474952.736411 (Exim 4.92) (envelope-from ) id 1pFLIr-0003fP-RR; Tue, 10 Jan 2023 20:33:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474952.736411; Tue, 10 Jan 2023 20:33:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFLIr-0003fI-Nu; Tue, 10 Jan 2023 20:33:01 +0000 Received: by outflank-mailman (input) for mailman id 474952; Tue, 10 Jan 2023 20:33:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFLIq-0003f8-57; Tue, 10 Jan 2023 20:33:00 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFLIq-0000oz-2T; Tue, 10 Jan 2023 20:33:00 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFLIp-0006GR-KT; Tue, 10 Jan 2023 20:32:59 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pFLIp-0003vE-K0; Tue, 10 Jan 2023 20:32:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=WxNBTje/r+ocUZcBF/5/vf8Es6YebQKTgco6/Jra55s=; b=xOqF/RqylTnRjCwYdXjjYlcPVJ Q82aJ0G6cqNgjIyuTKEc7/in1kS+z3jCOkvQgGIuPd7clQjLc0ERE7yO0QbG2sG2KuD8xgRXmYNKn EsRQDOBrLZJEuxpHk9tlHwa+PMDpZjtPMWgQKB3vaIp/cQSUCyvkHeFLSyplvK5LtD7Y=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 175707: all pass - PUSHED X-Osstest-Versions-This: ovmf=ec54ce1f1ab41b92782b37ae59e752fff0ef9c41 X-Osstest-Versions-That: ovmf=717f35a9f2d883a74998f7deb3d2cdf95bddf039 From: osstest service owner Date: Tue, 10 Jan 2023 20:32:59 +0000 flight 175707 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/175707/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf ec54ce1f1ab41b92782b37ae59e752fff0ef9c41 baseline version: ovmf 717f35a9f2d883a74998f7deb3d2cdf95bddf039 Last test of basis 175702 2023-01-10 14:40:41 Z 0 days Testing same since 175707 2023-01-10 17:40:54 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ard Biesheuvel dann frazier Laszlo Ersek jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 717f35a9f2..ec54ce1f1a ec54ce1f1ab41b92782b37ae59e752fff0ef9c41 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue Jan 10 20:49:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 20:49:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474960.736422 (Exim 4.92) (envelope-from ) id 1pFLZ8-0005Es-8H; Tue, 10 Jan 2023 20:49:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474960.736422; Tue, 10 Jan 2023 20:49:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFLZ8-0005El-5P; Tue, 10 Jan 2023 20:49:50 +0000 Received: by outflank-mailman (input) for mailman id 474960; Tue, 10 Jan 2023 20:49:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFLZ6-0005Eb-E4; Tue, 10 Jan 2023 20:49:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFLZ6-0001GZ-Av; Tue, 10 Jan 2023 20:49:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFLZ5-0006fv-Sl; Tue, 10 Jan 2023 20:49:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pFLZ5-0007oN-SC; Tue, 10 Jan 2023 20:49:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=6aTQMh1gv7M3ZDeD+FNJa8KPUqql1IvnsLVX6lrPJTE=; b=C67I8/IXj3LjiVnJc87aAbsKlc M3F/1Ham3q9VZwB/jIJRBKxhDWD8cbB+Kn4z0k89gkRaTsbzw29xoohy9KzXgaPQHrAssCpKNDazO GSU9m8kirsfZBccF+ijS3WckxgbwIzV9BpnY8Ol31ynFvECIk7ogGc+7/fx3ig/EgjxI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 175703: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-amd64-xsm:xen-build:fail:regression qemu-mainline:build-amd64:xen-build:fail:regression qemu-mainline:build-i386:xen-build:fail:regression qemu-mainline:build-arm64-xsm:xen-build:fail:regression qemu-mainline:build-i386-xsm:xen-build:fail:regression qemu-mainline:build-arm64:xen-build:fail:regression qemu-mainline:build-armhf:xen-build:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-coresched-amd64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:build-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-rtds:build-check(1):blocked:nonblocking qemu-mainline:build-arm64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking qemu-mainline:build-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking qemu-mainline:build-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-dom0pvh-xl-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-dom0pvh-xl-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvshim:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-pygrub:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvhv2-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-freebsd11-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-freebsd12-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvhv2-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-multivcpu:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: qemuu=aa96ab7c9df59c615ca82b49c9062819e0a1c287 X-Osstest-Versions-That: qemuu=0ab12aa32462817f0a53fa6f6ce4baf664ef1713 From: osstest service owner Date: Tue, 10 Jan 2023 20:49:47 +0000 flight 175703 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/175703/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 175623 build-amd64 6 xen-build fail REGR. vs. 175623 build-i386 6 xen-build fail REGR. vs. 175623 build-arm64-xsm 6 xen-build fail REGR. vs. 175623 build-i386-xsm 6 xen-build fail REGR. vs. 175623 build-arm64 6 xen-build fail REGR. vs. 175623 build-armhf 6 xen-build fail REGR. vs. 175623 Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-win7-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ws16-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-shadow 1 build-check(1) blocked n/a test-amd64-i386-xl-vhd 1 build-check(1) blocked n/a test-amd64-i386-xl-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) blocked n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) blocked n/a test-armhf-armhf-xl-rtds 1 build-check(1) blocked n/a test-armhf-armhf-xl-vhd 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-amd 1 build-check(1) blocked n/a test-amd64-i386-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-i386 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-amd64 1 build-check(1) blocked n/a test-amd64-coresched-i386-xl 1 build-check(1) blocked n/a test-amd64-coresched-amd64-xl 1 build-check(1) blocked n/a test-amd64-amd64-xl-xsm 1 build-check(1) blocked n/a build-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-shadow 1 build-check(1) blocked n/a test-amd64-amd64-xl-rtds 1 build-check(1) blocked n/a build-arm64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ws16-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a build-armhf-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-amd64-dom0pvh-xl-amd 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 1 build-check(1) blocked n/a test-amd64-amd64-dom0pvh-xl-intel 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvshim 1 build-check(1) blocked n/a test-amd64-amd64-pair 1 build-check(1) blocked n/a test-amd64-amd64-pygrub 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvhv2-intel 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-freebsd11-amd64 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-freebsd12-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvhv2-amd 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-nested-amd 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-nested-intel 1 build-check(1) blocked n/a test-amd64-amd64-xl-multivcpu 1 build-check(1) blocked n/a test-amd64-amd64-xl 1 build-check(1) blocked n/a test-amd64-amd64-xl-credit1 1 build-check(1) blocked n/a test-amd64-amd64-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-arndale 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-intel 1 build-check(1) blocked n/a test-amd64-i386-xl 1 build-check(1) blocked n/a test-amd64-i386-xl-pvshim 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a version targeted for testing: qemuu aa96ab7c9df59c615ca82b49c9062819e0a1c287 baseline version: qemuu 0ab12aa32462817f0a53fa6f6ce4baf664ef1713 Last test of basis 175623 2023-01-07 23:09:00 Z 2 days Failing since 175627 2023-01-08 14:40:14 Z 2 days 11 attempts Testing same since 175654 2023-01-09 18:08:58 Z 1 days 6 attempts ------------------------------------------------------------ People who touched revisions under test: Ard Biesheuvel Bernhard Beschow Christian Borntraeger Cindy Lu Dongli Zhang Eugenio Pérez Greg Kurz Guoyi Tu Hyman Huang(黄勇) Igor Mammedov Jason Wang Jonathan Cameron Kai Huang Laszlo Ersek Lei Xiang leixiang Liuxiangdong Longpeng Lubomir Rintel Marc-André Lureau Markus Armbruster Michael S. Tsirkin Nikita Ivanov Paolo Bonzini Peter Maydell Philippe Mathieu-Daudé Richard Henderson Thomas Huth Yanan Wang Yicong Yang Zeng Chi jobs: build-amd64-xsm fail build-arm64-xsm fail build-i386-xsm fail build-amd64 fail build-arm64 fail build-armhf fail build-i386 fail build-amd64-libvirt blocked build-arm64-libvirt blocked build-armhf-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl blocked test-amd64-coresched-amd64-xl blocked test-arm64-arm64-xl blocked test-armhf-armhf-xl blocked test-amd64-i386-xl blocked test-amd64-coresched-i386-xl blocked test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm blocked test-amd64-i386-xl-qemuu-debianhvm-i386-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm blocked test-arm64-arm64-xl-xsm blocked test-amd64-i386-xl-xsm blocked test-amd64-amd64-qemuu-nested-amd blocked test-amd64-amd64-xl-pvhv2-amd blocked test-amd64-i386-qemuu-rhel6hvm-amd blocked test-amd64-amd64-dom0pvh-xl-amd blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64 blocked test-amd64-i386-xl-qemuu-debianhvm-amd64 blocked test-amd64-i386-freebsd10-amd64 blocked test-amd64-amd64-qemuu-freebsd11-amd64 blocked test-amd64-amd64-qemuu-freebsd12-amd64 blocked test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked test-amd64-amd64-xl-qemuu-win7-amd64 blocked test-amd64-i386-xl-qemuu-win7-amd64 blocked test-amd64-amd64-xl-qemuu-ws16-amd64 blocked test-amd64-i386-xl-qemuu-ws16-amd64 blocked test-armhf-armhf-xl-arndale blocked test-amd64-amd64-xl-credit1 blocked test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 blocked test-amd64-amd64-xl-credit2 blocked test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 blocked test-armhf-armhf-xl-cubietruck blocked test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict blocked test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict blocked test-amd64-i386-freebsd10-i386 blocked test-amd64-amd64-qemuu-nested-intel blocked test-amd64-amd64-xl-pvhv2-intel blocked test-amd64-i386-qemuu-rhel6hvm-intel blocked test-amd64-amd64-dom0pvh-xl-intel blocked test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu blocked test-armhf-armhf-xl-multivcpu blocked test-amd64-amd64-pair blocked test-amd64-i386-pair blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim blocked test-amd64-i386-xl-pvshim blocked test-amd64-amd64-pygrub blocked test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds blocked test-armhf-armhf-xl-rtds blocked test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow blocked test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow blocked test-amd64-amd64-xl-shadow blocked test-amd64-i386-xl-shadow blocked test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd blocked test-amd64-i386-xl-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2556 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Jan 10 21:01:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 21:01:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474969.736433 (Exim 4.92) (envelope-from ) id 1pFLk5-0007co-EA; Tue, 10 Jan 2023 21:01:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474969.736433; Tue, 10 Jan 2023 21:01:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFLk5-0007ch-AR; Tue, 10 Jan 2023 21:01:09 +0000 Received: by outflank-mailman (input) for mailman id 474969; Tue, 10 Jan 2023 21:01:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFLk3-0007cX-U4; Tue, 10 Jan 2023 21:01:07 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFLk3-0001Vk-QD; Tue, 10 Jan 2023 21:01:07 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFLk3-0006ur-77; Tue, 10 Jan 2023 21:01:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pFLk3-00044X-6W; Tue, 10 Jan 2023 21:01:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=R2D59ZFz1TIF0XrxWAVn2pBSUPs6xQBQ7HgIlQoPp9w=; b=P1xQ8rbSgtiAMCV/9BYHuFD3GV mV+1VKvuIdKrfbYGgJqhnL/XPMrDWKoAezjuZbULg9Hvgly6DyIs7btynyVCOVA9xctH6cuRxSTJ8 C4dL6pcBVCZchPg2E+Z/GciV86XyY04/hysNHbKaQkprqBbTwA/qkEdl6eTgTAr//kOI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 175694: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-i386-migrupgrade:xen-install/src_host:fail:heisenbug xen-unstable:test-amd64-i386-migrupgrade:xen-install/dst_host:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=692d04a9ca429ca574d859fa8f43578e03b9f8b3 X-Osstest-Versions-That: xen=692d04a9ca429ca574d859fa8f43578e03b9f8b3 From: osstest service owner Date: Tue, 10 Jan 2023 21:01:07 +0000 flight 175694 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/175694/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail in 175671 pass in 175694 test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail in 175671 pass in 175694 test-amd64-i386-migrupgrade 10 xen-install/src_host fail pass in 175671 test-amd64-i386-migrupgrade 11 xen-install/dst_host fail pass in 175671 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 175671 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 175671 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175671 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175671 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 175671 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175671 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 175671 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 175671 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 175671 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 175671 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175671 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 175671 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen 692d04a9ca429ca574d859fa8f43578e03b9f8b3 baseline version: xen 692d04a9ca429ca574d859fa8f43578e03b9f8b3 Last test of basis 175694 2023-01-10 09:33:52 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Tue Jan 10 21:30:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 21:30:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474979.736450 (Exim 4.92) (envelope-from ) id 1pFMBw-0001lL-O1; Tue, 10 Jan 2023 21:29:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474979.736450; Tue, 10 Jan 2023 21:29:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFMBw-0001lE-Kc; Tue, 10 Jan 2023 21:29:56 +0000 Received: by outflank-mailman (input) for mailman id 474979; Tue, 10 Jan 2023 21:29:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFMBu-0001l8-Vl for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 21:29:55 +0000 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [2a00:1450:4864:20::433]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ea9e8b68-912d-11ed-91b6-6bf2151ebd3b; Tue, 10 Jan 2023 22:29:51 +0100 (CET) Received: by mail-wr1-x433.google.com with SMTP id z5so12097913wrt.6 for ; Tue, 10 Jan 2023 13:29:51 -0800 (PST) Received: from localhost.localdomain ([185.126.107.38]) by smtp.gmail.com with ESMTPSA id m7-20020adffe47000000b002b880b6ef19sm12096616wrs.66.2023.01.10.13.29.48 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 10 Jan 2023 13:29:50 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ea9e8b68-912d-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=W6wbWAaLwPWIlIyedxb4xDOOJaJOFE6u3k4WgWE5z1Q=; b=NJZgrJVezNBUk1duCF+KjTkxDbZ0B2oYgQK83ujjYQRz+WNzlUbXFUmU9NDDTsM19M goUMPU68xScavEmrKhM2zb28Z0Uwxk8Ks3kUNckShLpzHgDUlR5ymQe1OZjxxTFSGJfy 0mIRfytO1Hzan3AA8Tb7BY3X2jb4Bn5qRPiuxYu8Q2WvtI4lbPS4ceMTfBPmj03uewwZ DDGHmMz6s2PJdA2G8U1VcDFgyfp5CE0R5WzFgg1GOpY1yXdYtJPJVAryA7QY3qB9bevb mGS1tIJTmqUB7pSkXaebkhgeUEgr/3nV7vBsCwGWP/6JsZVQNg8uLSUdjUPpO9cHHeoC RSng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=W6wbWAaLwPWIlIyedxb4xDOOJaJOFE6u3k4WgWE5z1Q=; b=HFwMHq2BXnA3kA/2yCxRKKhIPUVpgTAceYy+CzruVZcZ/2FC0udJmqkW9kb2w6i+Tb 807kf4nhz7XLIvcsQaoCFx2iBozeEqIWaEF4F1E37XZUvWovBarwZyC69+uescIo8YeJ UXq/uvPsIxiSt319Y/DdXKHhD5N/0BFtumqHXIChm2K4cYbYVA1fx6xuuypO6wgm5CNU gSR3k3F3nztJQn7GlN6UT+K8hBAdV4lX5cS5VfLHegZ1lVhNDEj4YRcGrAr0tHCxdYrF ph14mL2/nCbuCrPhiRZe3AArTofyrHF0tinFN8sdvQXK9UwAdJwTFdhQxk+tOzagJ2qZ LZGQ== X-Gm-Message-State: AFqh2koAvaUySPI0q5uuJlVEVastbdMgvY6JY0RaI75vchY7PGd8I+TI hYZcbu/1Ad0fHD2XAFBgXgadhA== X-Google-Smtp-Source: AMrXdXsUkev5VAsuQo1OfOr+0irzTxLF6bwT0XZWW8EQ21bjlIyp+8HkVhItOJf6wPYBdCkZvWs46A== X-Received: by 2002:a5d:664e:0:b0:2bc:7ec3:8a8 with SMTP id f14-20020a5d664e000000b002bc7ec308a8mr5077500wrw.44.1673386190595; Tue, 10 Jan 2023 13:29:50 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Peter Maydell , qemu-block@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org, Richard Henderson , =?UTF-8?q?Alex=20Benn=C3=A9e?= , ale@rev.ng, qemu-riscv@nongnu.org, xen-devel@lists.xenproject.org, Thomas Huth , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH] bulk: Rename TARGET_FMT_plx -> HWADDR_FMT_plx Date: Tue, 10 Jan 2023 22:29:47 +0100 Message-Id: <20230110212947.34557-1-philmd@linaro.org> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The 'hwaddr' type is defined in "exec/hwaddr.h" as: hwaddr is the type of a physical address (its size can be different from 'target_ulong'). All definitions use the 'HWADDR_' prefix, except TARGET_FMT_plx: $ fgrep define include/exec/hwaddr.h #define HWADDR_H #define HWADDR_BITS 64 #define HWADDR_MAX UINT64_MAX #define TARGET_FMT_plx "%016" PRIx64 ^^^^^^ #define HWADDR_PRId PRId64 #define HWADDR_PRIi PRIi64 #define HWADDR_PRIo PRIo64 #define HWADDR_PRIu PRIu64 #define HWADDR_PRIx PRIx64 #define HWADDR_PRIX PRIX64 Since hwaddr's size can be *different* from target_ulong, it is very confusing to read one of its format using the 'TARGET_FMT_' prefix, normally used for the target_long / target_ulong types: $ fgrep TARGET_FMT_ include/exec/cpu-defs.h #define TARGET_FMT_lx "%08x" #define TARGET_FMT_ld "%d" #define TARGET_FMT_lu "%u" #define TARGET_FMT_lx "%016" PRIx64 #define TARGET_FMT_ld "%" PRId64 #define TARGET_FMT_lu "%" PRIu64 Apparently this format was missed during commit a8170e5e97 ("Rename target_phys_addr_t to hwaddr"), so complete it by doing a bulk-rename with: $ sed -i -e s/TARGET_FMT_plx/HWADDR_FMT_plx/g $(git grep -l TARGET_FMT_plx) Signed-off-by: Philippe Mathieu-Daudé --- accel/tcg/cputlb.c | 2 +- hw/arm/strongarm.c | 24 ++++++++++++------------ hw/block/pflash_cfi01.c | 2 +- hw/char/digic-uart.c | 4 ++-- hw/char/etraxfs_ser.c | 4 ++-- hw/core/loader.c | 8 ++++---- hw/core/sysbus.c | 4 ++-- hw/display/cirrus_vga.c | 4 ++-- hw/display/g364fb.c | 4 ++-- hw/display/vga.c | 8 ++++---- hw/dma/etraxfs_dma.c | 14 +++++++------- hw/dma/pl330.c | 14 +++++++------- hw/dma/xilinx_axidma.c | 4 ++-- hw/dma/xlnx_csu_dma.c | 4 ++-- hw/i2c/mpc_i2c.c | 4 ++-- hw/i386/multiboot.c | 8 ++++---- hw/i386/xen/xen-hvm.c | 8 ++++---- hw/i386/xen/xen-mapcache.c | 16 ++++++++-------- hw/i386/xen/xen_platform.c | 4 ++-- hw/intc/arm_gicv3_dist.c | 8 ++++---- hw/intc/arm_gicv3_its.c | 14 +++++++------- hw/intc/arm_gicv3_redist.c | 8 ++++---- hw/intc/exynos4210_combiner.c | 10 +++++----- hw/misc/auxbus.c | 2 +- hw/misc/ivshmem.c | 6 +++--- hw/misc/macio/mac_dbdma.c | 4 ++-- hw/misc/mst_fpga.c | 4 ++-- hw/net/allwinner-sun8i-emac.c | 4 ++-- hw/net/allwinner_emac.c | 4 ++-- hw/net/fsl_etsec/etsec.c | 4 ++-- hw/net/fsl_etsec/rings.c | 4 ++-- hw/net/pcnet.c | 4 ++-- hw/net/rocker/rocker.c | 26 +++++++++++++------------- hw/net/rocker/rocker_desc.c | 2 +- hw/net/xilinx_axienet.c | 4 ++-- hw/net/xilinx_ethlite.c | 6 +++--- hw/pci-bridge/pci_expander_bridge.c | 2 +- hw/pci-host/bonito.c | 14 +++++++------- hw/pci-host/ppce500.c | 4 ++-- hw/pci/pci_host.c | 4 ++-- hw/ppc/ppc4xx_sdram.c | 2 +- hw/rtc/exynos4210_rtc.c | 4 ++-- hw/sh4/sh7750.c | 4 ++-- hw/ssi/xilinx_spi.c | 4 ++-- hw/ssi/xilinx_spips.c | 8 ++++---- hw/timer/digic-timer.c | 4 ++-- hw/timer/etraxfs_timer.c | 2 +- hw/timer/exynos4210_mct.c | 2 +- hw/timer/exynos4210_pwm.c | 4 ++-- hw/virtio/virtio-mmio.c | 4 ++-- hw/xen/xen_pt.c | 4 ++-- include/exec/hwaddr.h | 2 +- monitor/misc.c | 2 +- softmmu/memory.c | 18 +++++++++--------- softmmu/memory_mapping.c | 4 ++-- softmmu/physmem.c | 10 +++++----- target/i386/monitor.c | 6 +++--- target/loongarch/tlb_helper.c | 2 +- target/microblaze/op_helper.c | 2 +- target/mips/tcg/sysemu/tlb_helper.c | 2 +- target/ppc/mmu-hash32.c | 14 +++++++------- target/ppc/mmu-hash64.c | 12 ++++++------ target/ppc/mmu_common.c | 26 +++++++++++++------------- target/ppc/mmu_helper.c | 4 ++-- target/riscv/cpu_helper.c | 10 +++++----- target/riscv/monitor.c | 2 +- target/sparc/ldst_helper.c | 6 +++--- target/sparc/mmu_helper.c | 10 +++++----- target/tricore/helper.c | 2 +- 69 files changed, 227 insertions(+), 227 deletions(-) diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c index 4948729917..4e040a1cb9 100644 --- a/accel/tcg/cputlb.c +++ b/accel/tcg/cputlb.c @@ -1142,7 +1142,7 @@ void tlb_set_page_full(CPUState *cpu, int mmu_idx, &xlat, &sz, full->attrs, &prot); assert(sz >= TARGET_PAGE_SIZE); - tlb_debug("vaddr=" TARGET_FMT_lx " paddr=0x" TARGET_FMT_plx + tlb_debug("vaddr=" TARGET_FMT_lx " paddr=0x" HWADDR_FMT_plx " prot=%x idx=%d\n", vaddr, full->phys_addr, prot, mmu_idx); diff --git a/hw/arm/strongarm.c b/hw/arm/strongarm.c index 39b8f01ac4..cc73145053 100644 --- a/hw/arm/strongarm.c +++ b/hw/arm/strongarm.c @@ -151,7 +151,7 @@ static uint64_t strongarm_pic_mem_read(void *opaque, hwaddr offset, case ICPR: return s->pending; default: - printf("%s: Bad register offset 0x" TARGET_FMT_plx "\n", + printf("%s: Bad register offset 0x" HWADDR_FMT_plx "\n", __func__, offset); return 0; } @@ -173,7 +173,7 @@ static void strongarm_pic_mem_write(void *opaque, hwaddr offset, s->int_idle = (value & 1) ? 0 : ~0; break; default: - printf("%s: Bad register offset 0x" TARGET_FMT_plx "\n", + printf("%s: Bad register offset 0x" HWADDR_FMT_plx "\n", __func__, offset); break; } @@ -333,7 +333,7 @@ static uint64_t strongarm_rtc_read(void *opaque, hwaddr addr, ((qemu_clock_get_ms(rtc_clock) - s->last_hz) << 15) / (1000 * ((s->rttr & 0xffff) + 1)); default: - printf("%s: Bad register 0x" TARGET_FMT_plx "\n", __func__, addr); + printf("%s: Bad register 0x" HWADDR_FMT_plx "\n", __func__, addr); return 0; } } @@ -375,7 +375,7 @@ static void strongarm_rtc_write(void *opaque, hwaddr addr, break; default: - printf("%s: Bad register 0x" TARGET_FMT_plx "\n", __func__, addr); + printf("%s: Bad register 0x" HWADDR_FMT_plx "\n", __func__, addr); } } @@ -581,7 +581,7 @@ static uint64_t strongarm_gpio_read(void *opaque, hwaddr offset, return s->status; default: - printf("%s: Bad offset 0x" TARGET_FMT_plx "\n", __func__, offset); + printf("%s: Bad offset 0x" HWADDR_FMT_plx "\n", __func__, offset); } return 0; @@ -626,7 +626,7 @@ static void strongarm_gpio_write(void *opaque, hwaddr offset, break; default: - printf("%s: Bad offset 0x" TARGET_FMT_plx "\n", __func__, offset); + printf("%s: Bad offset 0x" HWADDR_FMT_plx "\n", __func__, offset); } } @@ -782,7 +782,7 @@ static uint64_t strongarm_ppc_read(void *opaque, hwaddr offset, return s->ppfr | ~0x7f001; default: - printf("%s: Bad offset 0x" TARGET_FMT_plx "\n", __func__, offset); + printf("%s: Bad offset 0x" HWADDR_FMT_plx "\n", __func__, offset); } return 0; @@ -817,7 +817,7 @@ static void strongarm_ppc_write(void *opaque, hwaddr offset, break; default: - printf("%s: Bad offset 0x" TARGET_FMT_plx "\n", __func__, offset); + printf("%s: Bad offset 0x" HWADDR_FMT_plx "\n", __func__, offset); } } @@ -1164,7 +1164,7 @@ static uint64_t strongarm_uart_read(void *opaque, hwaddr addr, return s->utsr1; default: - printf("%s: Bad register 0x" TARGET_FMT_plx "\n", __func__, addr); + printf("%s: Bad register 0x" HWADDR_FMT_plx "\n", __func__, addr); return 0; } } @@ -1221,7 +1221,7 @@ static void strongarm_uart_write(void *opaque, hwaddr addr, break; default: - printf("%s: Bad register 0x" TARGET_FMT_plx "\n", __func__, addr); + printf("%s: Bad register 0x" HWADDR_FMT_plx "\n", __func__, addr); } } @@ -1443,7 +1443,7 @@ static uint64_t strongarm_ssp_read(void *opaque, hwaddr addr, strongarm_ssp_fifo_update(s); return retval; default: - printf("%s: Bad register 0x" TARGET_FMT_plx "\n", __func__, addr); + printf("%s: Bad register 0x" HWADDR_FMT_plx "\n", __func__, addr); break; } return 0; @@ -1509,7 +1509,7 @@ static void strongarm_ssp_write(void *opaque, hwaddr addr, break; default: - printf("%s: Bad register 0x" TARGET_FMT_plx "\n", __func__, addr); + printf("%s: Bad register 0x" HWADDR_FMT_plx "\n", __func__, addr); break; } } diff --git a/hw/block/pflash_cfi01.c b/hw/block/pflash_cfi01.c index 0cbc2fb4cb..36d68c70f6 100644 --- a/hw/block/pflash_cfi01.c +++ b/hw/block/pflash_cfi01.c @@ -645,7 +645,7 @@ static void pflash_write(PFlashCFI01 *pfl, hwaddr offset, error_flash: qemu_log_mask(LOG_UNIMP, "%s: Unimplemented flash cmd sequence " - "(offset " TARGET_FMT_plx ", wcycle 0x%x cmd 0x%x value 0x%x)" + "(offset " HWADDR_FMT_plx ", wcycle 0x%x cmd 0x%x value 0x%x)" "\n", __func__, offset, pfl->wcycle, pfl->cmd, value); mode_read_array: diff --git a/hw/char/digic-uart.c b/hw/char/digic-uart.c index 00e5df5517..51d4e7db52 100644 --- a/hw/char/digic-uart.c +++ b/hw/char/digic-uart.c @@ -63,7 +63,7 @@ static uint64_t digic_uart_read(void *opaque, hwaddr addr, default: qemu_log_mask(LOG_UNIMP, "digic-uart: read access to unknown register 0x" - TARGET_FMT_plx "\n", addr << 2); + HWADDR_FMT_plx "\n", addr << 2); } return ret; @@ -101,7 +101,7 @@ static void digic_uart_write(void *opaque, hwaddr addr, uint64_t value, default: qemu_log_mask(LOG_UNIMP, "digic-uart: write access to unknown register 0x" - TARGET_FMT_plx "\n", addr << 2); + HWADDR_FMT_plx "\n", addr << 2); } } diff --git a/hw/char/etraxfs_ser.c b/hw/char/etraxfs_ser.c index e8c3017724..8d6422dae4 100644 --- a/hw/char/etraxfs_ser.c +++ b/hw/char/etraxfs_ser.c @@ -113,7 +113,7 @@ ser_read(void *opaque, hwaddr addr, unsigned int size) break; default: r = s->regs[addr]; - D(qemu_log("%s " TARGET_FMT_plx "=%x\n", __func__, addr, r)); + D(qemu_log("%s " HWADDR_FMT_plx "=%x\n", __func__, addr, r)); break; } return r; @@ -127,7 +127,7 @@ ser_write(void *opaque, hwaddr addr, uint32_t value = val64; unsigned char ch = val64; - D(qemu_log("%s " TARGET_FMT_plx "=%x\n", __func__, addr, value)); + D(qemu_log("%s " HWADDR_FMT_plx "=%x\n", __func__, addr, value)); addr >>= 2; switch (addr) { diff --git a/hw/core/loader.c b/hw/core/loader.c index 0548830733..a18fb26469 100644 --- a/hw/core/loader.c +++ b/hw/core/loader.c @@ -1054,7 +1054,7 @@ ssize_t rom_add_file(const char *file, const char *fw_dir, rom->mr = mr; snprintf(devpath, sizeof(devpath), "/rom@%s", file); } else { - snprintf(devpath, sizeof(devpath), "/rom@" TARGET_FMT_plx, addr); + snprintf(devpath, sizeof(devpath), "/rom@" HWADDR_FMT_plx, addr); } } @@ -1238,10 +1238,10 @@ static void rom_print_one_overlap_error(Rom *last_rom, Rom *rom) "\nThe following two regions overlap (in the %s address space):\n", rom_as_name(rom)); error_printf( - " %s (addresses 0x" TARGET_FMT_plx " - 0x" TARGET_FMT_plx ")\n", + " %s (addresses 0x" HWADDR_FMT_plx " - 0x" HWADDR_FMT_plx ")\n", last_rom->name, last_rom->addr, last_rom->addr + last_rom->romsize); error_printf( - " %s (addresses 0x" TARGET_FMT_plx " - 0x" TARGET_FMT_plx ")\n", + " %s (addresses 0x" HWADDR_FMT_plx " - 0x" HWADDR_FMT_plx ")\n", rom->name, rom->addr, rom->addr + rom->romsize); } @@ -1595,7 +1595,7 @@ HumanReadableText *qmp_x_query_roms(Error **errp) rom->romsize, rom->name); } else if (!rom->fw_file) { - g_string_append_printf(buf, "addr=" TARGET_FMT_plx + g_string_append_printf(buf, "addr=" HWADDR_FMT_plx " size=0x%06zx mem=%s name=\"%s\"\n", rom->addr, rom->romsize, rom->isrom ? "rom" : "ram", diff --git a/hw/core/sysbus.c b/hw/core/sysbus.c index 05c1da3d31..35f902b582 100644 --- a/hw/core/sysbus.c +++ b/hw/core/sysbus.c @@ -269,7 +269,7 @@ static void sysbus_dev_print(Monitor *mon, DeviceState *dev, int indent) for (i = 0; i < s->num_mmio; i++) { size = memory_region_size(s->mmio[i].memory); - monitor_printf(mon, "%*smmio " TARGET_FMT_plx "/" TARGET_FMT_plx "\n", + monitor_printf(mon, "%*smmio " HWADDR_FMT_plx "/" HWADDR_FMT_plx "\n", indent, "", s->mmio[i].addr, size); } } @@ -289,7 +289,7 @@ static char *sysbus_get_fw_dev_path(DeviceState *dev) } } if (s->num_mmio) { - return g_strdup_printf("%s@" TARGET_FMT_plx, qdev_fw_name(dev), + return g_strdup_printf("%s@" HWADDR_FMT_plx, qdev_fw_name(dev), s->mmio[0].addr); } if (s->num_pio) { diff --git a/hw/display/cirrus_vga.c b/hw/display/cirrus_vga.c index 55c32e3e40..b80f98b6c4 100644 --- a/hw/display/cirrus_vga.c +++ b/hw/display/cirrus_vga.c @@ -2041,7 +2041,7 @@ static uint64_t cirrus_vga_mem_read(void *opaque, } else { val = 0xff; qemu_log_mask(LOG_GUEST_ERROR, - "cirrus: mem_readb 0x" TARGET_FMT_plx "\n", addr); + "cirrus: mem_readb 0x" HWADDR_FMT_plx "\n", addr); } return val; } @@ -2105,7 +2105,7 @@ static void cirrus_vga_mem_write(void *opaque, } } else { qemu_log_mask(LOG_GUEST_ERROR, - "cirrus: mem_writeb 0x" TARGET_FMT_plx " " + "cirrus: mem_writeb 0x" HWADDR_FMT_plx " " "value 0x%02" PRIx64 "\n", addr, mem_value); } } diff --git a/hw/display/g364fb.c b/hw/display/g364fb.c index caca86d773..2903cab82d 100644 --- a/hw/display/g364fb.c +++ b/hw/display/g364fb.c @@ -320,7 +320,7 @@ static uint64_t g364fb_ctrl_read(void *opaque, break; default: { - error_report("g364: invalid read at [" TARGET_FMT_plx "]", + error_report("g364: invalid read at [" HWADDR_FMT_plx "]", addr); val = 0; break; @@ -424,7 +424,7 @@ static void g364fb_ctrl_write(void *opaque, break; default: error_report("g364: invalid write of 0x%" PRIx64 - " at [" TARGET_FMT_plx "]", val, addr); + " at [" HWADDR_FMT_plx "]", val, addr); break; } } diff --git a/hw/display/vga.c b/hw/display/vga.c index 0cb26a791b..7a5fdff649 100644 --- a/hw/display/vga.c +++ b/hw/display/vga.c @@ -875,7 +875,7 @@ void vga_mem_writeb(VGACommonState *s, hwaddr addr, uint32_t val) uint32_t write_mask, bit_mask, set_mask; #ifdef DEBUG_VGA_MEM - printf("vga: [0x" TARGET_FMT_plx "] = 0x%02x\n", addr, val); + printf("vga: [0x" HWADDR_FMT_plx "] = 0x%02x\n", addr, val); #endif /* convert to VGA memory offset */ memory_map_mode = (s->gr[VGA_GFX_MISC] >> 2) & 3; @@ -909,7 +909,7 @@ void vga_mem_writeb(VGACommonState *s, hwaddr addr, uint32_t val) assert(addr < s->vram_size); s->vram_ptr[addr] = val; #ifdef DEBUG_VGA_MEM - printf("vga: chain4: [0x" TARGET_FMT_plx "]\n", addr); + printf("vga: chain4: [0x" HWADDR_FMT_plx "]\n", addr); #endif s->plane_updated |= mask; /* only used to detect font change */ memory_region_set_dirty(&s->vram, addr, 1); @@ -925,7 +925,7 @@ void vga_mem_writeb(VGACommonState *s, hwaddr addr, uint32_t val) } s->vram_ptr[addr] = val; #ifdef DEBUG_VGA_MEM - printf("vga: odd/even: [0x" TARGET_FMT_plx "]\n", addr); + printf("vga: odd/even: [0x" HWADDR_FMT_plx "]\n", addr); #endif s->plane_updated |= mask; /* only used to detect font change */ memory_region_set_dirty(&s->vram, addr, 1); @@ -1003,7 +1003,7 @@ void vga_mem_writeb(VGACommonState *s, hwaddr addr, uint32_t val) (((uint32_t *)s->vram_ptr)[addr] & ~write_mask) | (val & write_mask); #ifdef DEBUG_VGA_MEM - printf("vga: latch: [0x" TARGET_FMT_plx "] mask=0x%08x val=0x%08x\n", + printf("vga: latch: [0x" HWADDR_FMT_plx "] mask=0x%08x val=0x%08x\n", addr * 4, write_mask, val); #endif memory_region_set_dirty(&s->vram, addr << 2, sizeof(uint32_t)); diff --git a/hw/dma/etraxfs_dma.c b/hw/dma/etraxfs_dma.c index c4334e87bf..8951864ed7 100644 --- a/hw/dma/etraxfs_dma.c +++ b/hw/dma/etraxfs_dma.c @@ -272,7 +272,7 @@ static void channel_load_d(struct fs_dma_ctrl *ctrl, int c) hwaddr addr = channel_reg(ctrl, c, RW_SAVED_DATA); /* Load and decode. FIXME: handle endianness. */ - D(printf("%s ch=%d addr=" TARGET_FMT_plx "\n", __func__, c, addr)); + D(printf("%s ch=%d addr=" HWADDR_FMT_plx "\n", __func__, c, addr)); cpu_physical_memory_read(addr, &ctrl->channels[c].current_d, sizeof(ctrl->channels[c].current_d)); @@ -285,7 +285,7 @@ static void channel_store_c(struct fs_dma_ctrl *ctrl, int c) hwaddr addr = channel_reg(ctrl, c, RW_GROUP_DOWN); /* Encode and store. FIXME: handle endianness. */ - D(printf("%s ch=%d addr=" TARGET_FMT_plx "\n", __func__, c, addr)); + D(printf("%s ch=%d addr=" HWADDR_FMT_plx "\n", __func__, c, addr)); D(dump_d(c, &ctrl->channels[c].current_d)); cpu_physical_memory_write(addr, &ctrl->channels[c].current_c, sizeof(ctrl->channels[c].current_c)); @@ -296,7 +296,7 @@ static void channel_store_d(struct fs_dma_ctrl *ctrl, int c) hwaddr addr = channel_reg(ctrl, c, RW_SAVED_DATA); /* Encode and store. FIXME: handle endianness. */ - D(printf("%s ch=%d addr=" TARGET_FMT_plx "\n", __func__, c, addr)); + D(printf("%s ch=%d addr=" HWADDR_FMT_plx "\n", __func__, c, addr)); cpu_physical_memory_write(addr, &ctrl->channels[c].current_d, sizeof(ctrl->channels[c].current_d)); } @@ -574,7 +574,7 @@ static inline int channel_in_run(struct fs_dma_ctrl *ctrl, int c) static uint32_t dma_rinvalid (void *opaque, hwaddr addr) { - hw_error("Unsupported short raccess. reg=" TARGET_FMT_plx "\n", addr); + hw_error("Unsupported short raccess. reg=" HWADDR_FMT_plx "\n", addr); return 0; } @@ -603,7 +603,7 @@ dma_read(void *opaque, hwaddr addr, unsigned int size) default: r = ctrl->channels[c].regs[addr]; - D(printf ("%s c=%d addr=" TARGET_FMT_plx "\n", + D(printf ("%s c=%d addr=" HWADDR_FMT_plx "\n", __func__, c, addr)); break; } @@ -613,7 +613,7 @@ dma_read(void *opaque, hwaddr addr, unsigned int size) static void dma_winvalid (void *opaque, hwaddr addr, uint32_t value) { - hw_error("Unsupported short waccess. reg=" TARGET_FMT_plx "\n", addr); + hw_error("Unsupported short waccess. reg=" HWADDR_FMT_plx "\n", addr); } static void @@ -686,7 +686,7 @@ dma_write(void *opaque, hwaddr addr, break; default: - D(printf ("%s c=%d " TARGET_FMT_plx "\n", + D(printf ("%s c=%d " HWADDR_FMT_plx "\n", __func__, c, addr)); break; } diff --git a/hw/dma/pl330.c b/hw/dma/pl330.c index e5d521c329..e7e67dd8b6 100644 --- a/hw/dma/pl330.c +++ b/hw/dma/pl330.c @@ -1373,7 +1373,7 @@ static void pl330_iomem_write(void *opaque, hwaddr offset, pl330_exec(s); } else { qemu_log_mask(LOG_GUEST_ERROR, "pl330: write of illegal value %u " - "for offset " TARGET_FMT_plx "\n", (unsigned)value, + "for offset " HWADDR_FMT_plx "\n", (unsigned)value, offset); } break; @@ -1384,7 +1384,7 @@ static void pl330_iomem_write(void *opaque, hwaddr offset, s->dbg[1] = value; break; default: - qemu_log_mask(LOG_GUEST_ERROR, "pl330: bad write offset " TARGET_FMT_plx + qemu_log_mask(LOG_GUEST_ERROR, "pl330: bad write offset " HWADDR_FMT_plx "\n", offset); break; } @@ -1409,7 +1409,7 @@ static inline uint32_t pl330_iomem_read_imp(void *opaque, chan_id = offset >> 5; if (chan_id >= s->num_chnls) { qemu_log_mask(LOG_GUEST_ERROR, "pl330: bad read offset " - TARGET_FMT_plx "\n", offset); + HWADDR_FMT_plx "\n", offset); return 0; } switch (offset & 0x1f) { @@ -1425,7 +1425,7 @@ static inline uint32_t pl330_iomem_read_imp(void *opaque, return s->chan[chan_id].lc[1]; default: qemu_log_mask(LOG_GUEST_ERROR, "pl330: bad read offset " - TARGET_FMT_plx "\n", offset); + HWADDR_FMT_plx "\n", offset); return 0; } } @@ -1434,7 +1434,7 @@ static inline uint32_t pl330_iomem_read_imp(void *opaque, chan_id = offset >> 3; if (chan_id >= s->num_chnls) { qemu_log_mask(LOG_GUEST_ERROR, "pl330: bad read offset " - TARGET_FMT_plx "\n", offset); + HWADDR_FMT_plx "\n", offset); return 0; } switch ((offset >> 2) & 1) { @@ -1456,7 +1456,7 @@ static inline uint32_t pl330_iomem_read_imp(void *opaque, chan_id = offset >> 2; if (chan_id >= s->num_chnls) { qemu_log_mask(LOG_GUEST_ERROR, "pl330: bad read offset " - TARGET_FMT_plx "\n", offset); + HWADDR_FMT_plx "\n", offset); return 0; } return s->chan[chan_id].fault_type; @@ -1495,7 +1495,7 @@ static inline uint32_t pl330_iomem_read_imp(void *opaque, return s->debug_status; default: qemu_log_mask(LOG_GUEST_ERROR, "pl330: bad read offset " - TARGET_FMT_plx "\n", offset); + HWADDR_FMT_plx "\n", offset); } return 0; } diff --git a/hw/dma/xilinx_axidma.c b/hw/dma/xilinx_axidma.c index cbb8f0f169..6030c76435 100644 --- a/hw/dma/xilinx_axidma.c +++ b/hw/dma/xilinx_axidma.c @@ -456,7 +456,7 @@ static uint64_t axidma_read(void *opaque, hwaddr addr, break; default: r = s->regs[addr]; - D(qemu_log("%s ch=%d addr=" TARGET_FMT_plx " v=%x\n", + D(qemu_log("%s ch=%d addr=" HWADDR_FMT_plx " v=%x\n", __func__, sid, addr * 4, r)); break; } @@ -509,7 +509,7 @@ static void axidma_write(void *opaque, hwaddr addr, } break; default: - D(qemu_log("%s: ch=%d addr=" TARGET_FMT_plx " v=%x\n", + D(qemu_log("%s: ch=%d addr=" HWADDR_FMT_plx " v=%x\n", __func__, sid, addr * 4, (unsigned)value)); s->regs[addr] = value; break; diff --git a/hw/dma/xlnx_csu_dma.c b/hw/dma/xlnx_csu_dma.c index 1ce52ea5a2..88002698a1 100644 --- a/hw/dma/xlnx_csu_dma.c +++ b/hw/dma/xlnx_csu_dma.c @@ -211,7 +211,7 @@ static uint32_t xlnx_csu_dma_read(XlnxCSUDMA *s, uint8_t *buf, uint32_t len) if (result == MEMTX_OK) { xlnx_csu_dma_data_process(s, buf, len); } else { - qemu_log_mask(LOG_GUEST_ERROR, "%s: Bad address " TARGET_FMT_plx + qemu_log_mask(LOG_GUEST_ERROR, "%s: Bad address " HWADDR_FMT_plx " for mem read", __func__, addr); s->regs[R_INT_STATUS] |= R_INT_STATUS_AXI_BRESP_ERR_MASK; xlnx_csu_dma_update_irq(s); @@ -241,7 +241,7 @@ static uint32_t xlnx_csu_dma_write(XlnxCSUDMA *s, uint8_t *buf, uint32_t len) } if (result != MEMTX_OK) { - qemu_log_mask(LOG_GUEST_ERROR, "%s: Bad address " TARGET_FMT_plx + qemu_log_mask(LOG_GUEST_ERROR, "%s: Bad address " HWADDR_FMT_plx " for mem write", __func__, addr); s->regs[R_INT_STATUS] |= R_INT_STATUS_AXI_BRESP_ERR_MASK; xlnx_csu_dma_update_irq(s); diff --git a/hw/i2c/mpc_i2c.c b/hw/i2c/mpc_i2c.c index 845392505f..219c548402 100644 --- a/hw/i2c/mpc_i2c.c +++ b/hw/i2c/mpc_i2c.c @@ -224,7 +224,7 @@ static uint64_t mpc_i2c_read(void *opaque, hwaddr addr, unsigned size) break; } - DPRINTF("%s: addr " TARGET_FMT_plx " %02" PRIx32 "\n", __func__, + DPRINTF("%s: addr " HWADDR_FMT_plx " %02" PRIx32 "\n", __func__, addr, value); return (uint64_t)value; } @@ -234,7 +234,7 @@ static void mpc_i2c_write(void *opaque, hwaddr addr, { MPCI2CState *s = opaque; - DPRINTF("%s: addr " TARGET_FMT_plx " val %08" PRIx64 "\n", __func__, + DPRINTF("%s: addr " HWADDR_FMT_plx " val %08" PRIx64 "\n", __func__, addr, value); switch (addr) { case MPC_I2C_ADR: diff --git a/hw/i386/multiboot.c b/hw/i386/multiboot.c index 963e29362e..3332712ab3 100644 --- a/hw/i386/multiboot.c +++ b/hw/i386/multiboot.c @@ -137,7 +137,7 @@ static void mb_add_mod(MultibootState *s, stl_p(p + MB_MOD_END, end); stl_p(p + MB_MOD_CMDLINE, cmdline_phys); - mb_debug("mod%02d: "TARGET_FMT_plx" - "TARGET_FMT_plx, + mb_debug("mod%02d: "HWADDR_FMT_plx" - "HWADDR_FMT_plx, s->mb_mods_count, start, end); s->mb_mods_count++; @@ -353,7 +353,7 @@ int load_multiboot(X86MachineState *x86ms, mb_add_mod(&mbs, mbs.mb_buf_phys + offs, mbs.mb_buf_phys + offs + mb_mod_length, c); - mb_debug("mod_start: %p\nmod_end: %p\n cmdline: "TARGET_FMT_plx, + mb_debug("mod_start: %p\nmod_end: %p\n cmdline: "HWADDR_FMT_plx, (char *)mbs.mb_buf + offs, (char *)mbs.mb_buf + offs + mb_mod_length, c); g_free(one_file); @@ -382,8 +382,8 @@ int load_multiboot(X86MachineState *x86ms, stl_p(bootinfo + MBI_MMAP_ADDR, ADDR_E820_MAP); mb_debug("multiboot: entry_addr = %#x", mh_entry_addr); - mb_debug(" mb_buf_phys = "TARGET_FMT_plx, mbs.mb_buf_phys); - mb_debug(" mod_start = "TARGET_FMT_plx, + mb_debug(" mb_buf_phys = "HWADDR_FMT_plx, mbs.mb_buf_phys); + mb_debug(" mod_start = "HWADDR_FMT_plx, mbs.mb_buf_phys + mbs.offset_mods); mb_debug(" mb_mods_count = %d", mbs.mb_mods_count); diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c index e4293d6d66..b9a6f7f538 100644 --- a/hw/i386/xen/xen-hvm.c +++ b/hw/i386/xen/xen-hvm.c @@ -516,13 +516,13 @@ static void xen_set_memory(struct MemoryListener *listener, if (xen_set_mem_type(xen_domid, mem_type, start_addr >> TARGET_PAGE_BITS, size >> TARGET_PAGE_BITS)) { - DPRINTF("xen_set_mem_type error, addr: "TARGET_FMT_plx"\n", + DPRINTF("xen_set_mem_type error, addr: "HWADDR_FMT_plx"\n", start_addr); } } } else { if (xen_remove_from_physmap(state, start_addr, size) < 0) { - DPRINTF("physmapping does not exist at "TARGET_FMT_plx"\n", start_addr); + DPRINTF("physmapping does not exist at "HWADDR_FMT_plx"\n", start_addr); } } } @@ -642,8 +642,8 @@ static void xen_sync_dirty_bitmap(XenIOState *state, #endif if (errno == ENODATA) { memory_region_set_dirty(framebuffer, 0, size); - DPRINTF("xen: track_dirty_vram failed (0x" TARGET_FMT_plx - ", 0x" TARGET_FMT_plx "): %s\n", + DPRINTF("xen: track_dirty_vram failed (0x" HWADDR_FMT_plx + ", 0x" HWADDR_FMT_plx "): %s\n", start_addr, start_addr + size, strerror(errno)); } return; diff --git a/hw/i386/xen/xen-mapcache.c b/hw/i386/xen/xen-mapcache.c index a2f93096e7..1d0879d234 100644 --- a/hw/i386/xen/xen-mapcache.c +++ b/hw/i386/xen/xen-mapcache.c @@ -357,7 +357,7 @@ tryagain: entry->lock++; if (entry->lock == 0) { fprintf(stderr, - "mapcache entry lock overflow: "TARGET_FMT_plx" -> %p\n", + "mapcache entry lock overflow: "HWADDR_FMT_plx" -> %p\n", entry->paddr_index, entry->vaddr_base); abort(); } @@ -404,7 +404,7 @@ ram_addr_t xen_ram_addr_from_mapcache(void *ptr) if (!found) { fprintf(stderr, "%s, could not find %p\n", __func__, ptr); QTAILQ_FOREACH(reventry, &mapcache->locked_entries, next) { - DPRINTF(" "TARGET_FMT_plx" -> %p is present\n", reventry->paddr_index, + DPRINTF(" "HWADDR_FMT_plx" -> %p is present\n", reventry->paddr_index, reventry->vaddr_req); } abort(); @@ -445,7 +445,7 @@ static void xen_invalidate_map_cache_entry_unlocked(uint8_t *buffer) if (!found) { DPRINTF("%s, could not find %p\n", __func__, buffer); QTAILQ_FOREACH(reventry, &mapcache->locked_entries, next) { - DPRINTF(" "TARGET_FMT_plx" -> %p is present\n", reventry->paddr_index, reventry->vaddr_req); + DPRINTF(" "HWADDR_FMT_plx" -> %p is present\n", reventry->paddr_index, reventry->vaddr_req); } return; } @@ -503,7 +503,7 @@ void xen_invalidate_map_cache(void) continue; } fprintf(stderr, "Locked DMA mapping while invalidating mapcache!" - " "TARGET_FMT_plx" -> %p is present\n", + " "HWADDR_FMT_plx" -> %p is present\n", reventry->paddr_index, reventry->vaddr_req); } @@ -562,7 +562,7 @@ static uint8_t *xen_replace_cache_entry_unlocked(hwaddr old_phys_addr, entry = entry->next; } if (!entry) { - DPRINTF("Trying to update an entry for "TARGET_FMT_plx \ + DPRINTF("Trying to update an entry for "HWADDR_FMT_plx \ "that is not in the mapcache!\n", old_phys_addr); return NULL; } @@ -570,15 +570,15 @@ static uint8_t *xen_replace_cache_entry_unlocked(hwaddr old_phys_addr, address_index = new_phys_addr >> MCACHE_BUCKET_SHIFT; address_offset = new_phys_addr & (MCACHE_BUCKET_SIZE - 1); - fprintf(stderr, "Replacing a dummy mapcache entry for "TARGET_FMT_plx \ - " with "TARGET_FMT_plx"\n", old_phys_addr, new_phys_addr); + fprintf(stderr, "Replacing a dummy mapcache entry for "HWADDR_FMT_plx \ + " with "HWADDR_FMT_plx"\n", old_phys_addr, new_phys_addr); xen_remap_bucket(entry, entry->vaddr_base, cache_size, address_index, false); if (!test_bits(address_offset >> XC_PAGE_SHIFT, test_bit_size >> XC_PAGE_SHIFT, entry->valid_mapping)) { - DPRINTF("Unable to update a mapcache entry for "TARGET_FMT_plx"!\n", + DPRINTF("Unable to update a mapcache entry for "HWADDR_FMT_plx"!\n", old_phys_addr); return NULL; } diff --git a/hw/i386/xen/xen_platform.c b/hw/i386/xen/xen_platform.c index 7db0d94ec2..66e6de31a6 100644 --- a/hw/i386/xen/xen_platform.c +++ b/hw/i386/xen/xen_platform.c @@ -445,7 +445,7 @@ static uint64_t platform_mmio_read(void *opaque, hwaddr addr, unsigned size) { DPRINTF("Warning: attempted read from physical address " - "0x" TARGET_FMT_plx " in xen platform mmio space\n", addr); + "0x" HWADDR_FMT_plx " in xen platform mmio space\n", addr); return 0; } @@ -454,7 +454,7 @@ static void platform_mmio_write(void *opaque, hwaddr addr, uint64_t val, unsigned size) { DPRINTF("Warning: attempted write of 0x%"PRIx64" to physical " - "address 0x" TARGET_FMT_plx " in xen platform mmio space\n", + "address 0x" HWADDR_FMT_plx " in xen platform mmio space\n", val, addr); } diff --git a/hw/intc/arm_gicv3_dist.c b/hw/intc/arm_gicv3_dist.c index d599fefcbc..35e850685c 100644 --- a/hw/intc/arm_gicv3_dist.c +++ b/hw/intc/arm_gicv3_dist.c @@ -564,7 +564,7 @@ static bool gicd_readl(GICv3State *s, hwaddr offset, /* WO registers, return unknown value */ qemu_log_mask(LOG_GUEST_ERROR, "%s: invalid guest read from WO register at offset " - TARGET_FMT_plx "\n", __func__, offset); + HWADDR_FMT_plx "\n", __func__, offset); *data = 0; return true; default: @@ -773,7 +773,7 @@ static bool gicd_writel(GICv3State *s, hwaddr offset, /* RO registers, ignore the write */ qemu_log_mask(LOG_GUEST_ERROR, "%s: invalid guest write to RO register at offset " - TARGET_FMT_plx "\n", __func__, offset); + HWADDR_FMT_plx "\n", __func__, offset); return true; default: return false; @@ -838,7 +838,7 @@ MemTxResult gicv3_dist_read(void *opaque, hwaddr offset, uint64_t *data, if (!r) { qemu_log_mask(LOG_GUEST_ERROR, - "%s: invalid guest read at offset " TARGET_FMT_plx + "%s: invalid guest read at offset " HWADDR_FMT_plx " size %u\n", __func__, offset, size); trace_gicv3_dist_badread(offset, size, attrs.secure); /* The spec requires that reserved registers are RAZ/WI; @@ -879,7 +879,7 @@ MemTxResult gicv3_dist_write(void *opaque, hwaddr offset, uint64_t data, if (!r) { qemu_log_mask(LOG_GUEST_ERROR, - "%s: invalid guest write at offset " TARGET_FMT_plx + "%s: invalid guest write at offset " HWADDR_FMT_plx " size %u\n", __func__, offset, size); trace_gicv3_dist_badwrite(offset, data, size, attrs.secure); /* The spec requires that reserved registers are RAZ/WI; diff --git a/hw/intc/arm_gicv3_its.c b/hw/intc/arm_gicv3_its.c index 57c79da5c5..43dfd7a35c 100644 --- a/hw/intc/arm_gicv3_its.c +++ b/hw/intc/arm_gicv3_its.c @@ -1633,7 +1633,7 @@ static bool its_writel(GICv3ITSState *s, hwaddr offset, /* RO register, ignore the write */ qemu_log_mask(LOG_GUEST_ERROR, "%s: invalid guest write to RO register at offset " - TARGET_FMT_plx "\n", __func__, offset); + HWADDR_FMT_plx "\n", __func__, offset); } break; case GITS_CREADR + 4: @@ -1643,7 +1643,7 @@ static bool its_writel(GICv3ITSState *s, hwaddr offset, /* RO register, ignore the write */ qemu_log_mask(LOG_GUEST_ERROR, "%s: invalid guest write to RO register at offset " - TARGET_FMT_plx "\n", __func__, offset); + HWADDR_FMT_plx "\n", __func__, offset); } break; case GITS_BASER ... GITS_BASER + 0x3f: @@ -1675,7 +1675,7 @@ static bool its_writel(GICv3ITSState *s, hwaddr offset, /* RO registers, ignore the write */ qemu_log_mask(LOG_GUEST_ERROR, "%s: invalid guest write to RO register at offset " - TARGET_FMT_plx "\n", __func__, offset); + HWADDR_FMT_plx "\n", __func__, offset); break; default: result = false; @@ -1785,14 +1785,14 @@ static bool its_writell(GICv3ITSState *s, hwaddr offset, /* RO register, ignore the write */ qemu_log_mask(LOG_GUEST_ERROR, "%s: invalid guest write to RO register at offset " - TARGET_FMT_plx "\n", __func__, offset); + HWADDR_FMT_plx "\n", __func__, offset); } break; case GITS_TYPER: /* RO registers, ignore the write */ qemu_log_mask(LOG_GUEST_ERROR, "%s: invalid guest write to RO register at offset " - TARGET_FMT_plx "\n", __func__, offset); + HWADDR_FMT_plx "\n", __func__, offset); break; default: result = false; @@ -1851,7 +1851,7 @@ static MemTxResult gicv3_its_read(void *opaque, hwaddr offset, uint64_t *data, if (!result) { qemu_log_mask(LOG_GUEST_ERROR, - "%s: invalid guest read at offset " TARGET_FMT_plx + "%s: invalid guest read at offset " HWADDR_FMT_plx " size %u\n", __func__, offset, size); trace_gicv3_its_badread(offset, size); /* @@ -1887,7 +1887,7 @@ static MemTxResult gicv3_its_write(void *opaque, hwaddr offset, uint64_t data, if (!result) { qemu_log_mask(LOG_GUEST_ERROR, - "%s: invalid guest write at offset " TARGET_FMT_plx + "%s: invalid guest write at offset " HWADDR_FMT_plx " size %u\n", __func__, offset, size); trace_gicv3_its_badwrite(offset, data, size); /* diff --git a/hw/intc/arm_gicv3_redist.c b/hw/intc/arm_gicv3_redist.c index c92ceecc16..297f7f0263 100644 --- a/hw/intc/arm_gicv3_redist.c +++ b/hw/intc/arm_gicv3_redist.c @@ -601,7 +601,7 @@ static MemTxResult gicr_writel(GICv3CPUState *cs, hwaddr offset, /* RO registers, ignore the write */ qemu_log_mask(LOG_GUEST_ERROR, "%s: invalid guest write to RO register at offset " - TARGET_FMT_plx "\n", __func__, offset); + HWADDR_FMT_plx "\n", __func__, offset); return MEMTX_OK; /* * VLPI frame registers. We don't need a version check for @@ -668,7 +668,7 @@ static MemTxResult gicr_writell(GICv3CPUState *cs, hwaddr offset, /* RO register, ignore the write */ qemu_log_mask(LOG_GUEST_ERROR, "%s: invalid guest write to RO register at offset " - TARGET_FMT_plx "\n", __func__, offset); + HWADDR_FMT_plx "\n", __func__, offset); return MEMTX_OK; /* * VLPI frame registers. We don't need a version check for @@ -727,7 +727,7 @@ MemTxResult gicv3_redist_read(void *opaque, hwaddr offset, uint64_t *data, if (r != MEMTX_OK) { qemu_log_mask(LOG_GUEST_ERROR, - "%s: invalid guest read at offset " TARGET_FMT_plx + "%s: invalid guest read at offset " HWADDR_FMT_plx " size %u\n", __func__, offset, size); trace_gicv3_redist_badread(gicv3_redist_affid(cs), offset, size, attrs.secure); @@ -786,7 +786,7 @@ MemTxResult gicv3_redist_write(void *opaque, hwaddr offset, uint64_t data, if (r != MEMTX_OK) { qemu_log_mask(LOG_GUEST_ERROR, - "%s: invalid guest write at offset " TARGET_FMT_plx + "%s: invalid guest write at offset " HWADDR_FMT_plx " size %u\n", __func__, offset, size); trace_gicv3_redist_badwrite(gicv3_redist_affid(cs), offset, data, size, attrs.secure); diff --git a/hw/intc/exynos4210_combiner.c b/hw/intc/exynos4210_combiner.c index a289510bdb..4ba448fdb1 100644 --- a/hw/intc/exynos4210_combiner.c +++ b/hw/intc/exynos4210_combiner.c @@ -120,7 +120,7 @@ exynos4210_combiner_read(void *opaque, hwaddr offset, unsigned size) default: if (offset >> 2 >= IIC_REGSET_SIZE) { hw_error("exynos4210.combiner: overflow of reg_set by 0x" - TARGET_FMT_plx "offset\n", offset); + HWADDR_FMT_plx "offset\n", offset); } val = s->reg_set[offset >> 2]; } @@ -184,19 +184,19 @@ static void exynos4210_combiner_write(void *opaque, hwaddr offset, if (req_quad_base_n >= IIC_NGRP) { hw_error("exynos4210.combiner: unallowed write access at offset 0x" - TARGET_FMT_plx "\n", offset); + HWADDR_FMT_plx "\n", offset); return; } if (reg_n > 1) { hw_error("exynos4210.combiner: unallowed write access at offset 0x" - TARGET_FMT_plx "\n", offset); + HWADDR_FMT_plx "\n", offset); return; } if (offset >> 2 >= IIC_REGSET_SIZE) { hw_error("exynos4210.combiner: overflow of reg_set by 0x" - TARGET_FMT_plx "offset\n", offset); + HWADDR_FMT_plx "offset\n", offset); } s->reg_set[offset >> 2] = val; @@ -246,7 +246,7 @@ static void exynos4210_combiner_write(void *opaque, hwaddr offset, break; default: hw_error("exynos4210.combiner: unallowed write access at offset 0x" - TARGET_FMT_plx "\n", offset); + HWADDR_FMT_plx "\n", offset); break; } } diff --git a/hw/misc/auxbus.c b/hw/misc/auxbus.c index 8a8012f5f0..28d50d9d09 100644 --- a/hw/misc/auxbus.c +++ b/hw/misc/auxbus.c @@ -299,7 +299,7 @@ static void aux_slave_dev_print(Monitor *mon, DeviceState *dev, int indent) s = AUX_SLAVE(dev); - monitor_printf(mon, "%*smemory " TARGET_FMT_plx "/" TARGET_FMT_plx "\n", + monitor_printf(mon, "%*smemory " HWADDR_FMT_plx "/" HWADDR_FMT_plx "\n", indent, "", object_property_get_uint(OBJECT(s->mmio), "addr", NULL), memory_region_size(s->mmio)); diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index 8270db53cd..d66d912172 100644 --- a/hw/misc/ivshmem.c +++ b/hw/misc/ivshmem.c @@ -179,7 +179,7 @@ static void ivshmem_io_write(void *opaque, hwaddr addr, addr &= 0xfc; - IVSHMEM_DPRINTF("writing to addr " TARGET_FMT_plx "\n", addr); + IVSHMEM_DPRINTF("writing to addr " HWADDR_FMT_plx "\n", addr); switch (addr) { case INTRMASK: @@ -207,7 +207,7 @@ static void ivshmem_io_write(void *opaque, hwaddr addr, } break; default: - IVSHMEM_DPRINTF("Unhandled write " TARGET_FMT_plx "\n", addr); + IVSHMEM_DPRINTF("Unhandled write " HWADDR_FMT_plx "\n", addr); } } @@ -233,7 +233,7 @@ static uint64_t ivshmem_io_read(void *opaque, hwaddr addr, break; default: - IVSHMEM_DPRINTF("why are we reading " TARGET_FMT_plx "\n", addr); + IVSHMEM_DPRINTF("why are we reading " HWADDR_FMT_plx "\n", addr); ret = 0; } diff --git a/hw/misc/macio/mac_dbdma.c b/hw/misc/macio/mac_dbdma.c index efcc02609f..43bb1f56ba 100644 --- a/hw/misc/macio/mac_dbdma.c +++ b/hw/misc/macio/mac_dbdma.c @@ -704,7 +704,7 @@ static void dbdma_write(void *opaque, hwaddr addr, DBDMA_channel *ch = &s->channels[channel]; int reg = (addr - (channel << DBDMA_CHANNEL_SHIFT)) >> 2; - DBDMA_DPRINTFCH(ch, "writel 0x" TARGET_FMT_plx " <= 0x%08"PRIx64"\n", + DBDMA_DPRINTFCH(ch, "writel 0x" HWADDR_FMT_plx " <= 0x%08"PRIx64"\n", addr, value); DBDMA_DPRINTFCH(ch, "channel 0x%x reg 0x%x\n", (uint32_t)addr >> DBDMA_CHANNEL_SHIFT, reg); @@ -786,7 +786,7 @@ static uint64_t dbdma_read(void *opaque, hwaddr addr, break; } - DBDMA_DPRINTFCH(ch, "readl 0x" TARGET_FMT_plx " => 0x%08x\n", addr, value); + DBDMA_DPRINTFCH(ch, "readl 0x" HWADDR_FMT_plx " => 0x%08x\n", addr, value); DBDMA_DPRINTFCH(ch, "channel 0x%x reg 0x%x\n", (uint32_t)addr >> DBDMA_CHANNEL_SHIFT, reg); diff --git a/hw/misc/mst_fpga.c b/hw/misc/mst_fpga.c index 2aaadfa966..7692825867 100644 --- a/hw/misc/mst_fpga.c +++ b/hw/misc/mst_fpga.c @@ -131,7 +131,7 @@ mst_fpga_readb(void *opaque, hwaddr addr, unsigned size) return s->pcmcia1; default: printf("Mainstone - mst_fpga_readb: Bad register offset " - "0x" TARGET_FMT_plx "\n", addr); + "0x" HWADDR_FMT_plx "\n", addr); } return 0; } @@ -185,7 +185,7 @@ mst_fpga_writeb(void *opaque, hwaddr addr, uint64_t value, break; default: printf("Mainstone - mst_fpga_writeb: Bad register offset " - "0x" TARGET_FMT_plx "\n", addr); + "0x" HWADDR_FMT_plx "\n", addr); } } diff --git a/hw/net/allwinner-sun8i-emac.c b/hw/net/allwinner-sun8i-emac.c index ecc0245fe8..b861d8ff35 100644 --- a/hw/net/allwinner-sun8i-emac.c +++ b/hw/net/allwinner-sun8i-emac.c @@ -663,7 +663,7 @@ static uint64_t allwinner_sun8i_emac_read(void *opaque, hwaddr offset, break; default: qemu_log_mask(LOG_UNIMP, "allwinner-h3-emac: read access to unknown " - "EMAC register 0x" TARGET_FMT_plx "\n", + "EMAC register 0x" HWADDR_FMT_plx "\n", offset); } @@ -760,7 +760,7 @@ static void allwinner_sun8i_emac_write(void *opaque, hwaddr offset, break; default: qemu_log_mask(LOG_UNIMP, "allwinner-h3-emac: write access to unknown " - "EMAC register 0x" TARGET_FMT_plx "\n", + "EMAC register 0x" HWADDR_FMT_plx "\n", offset); } } diff --git a/hw/net/allwinner_emac.c b/hw/net/allwinner_emac.c index ddddf35c45..372e5b66da 100644 --- a/hw/net/allwinner_emac.c +++ b/hw/net/allwinner_emac.c @@ -304,7 +304,7 @@ static uint64_t aw_emac_read(void *opaque, hwaddr offset, unsigned size) default: qemu_log_mask(LOG_UNIMP, "allwinner_emac: read access to unknown register 0x" - TARGET_FMT_plx "\n", offset); + HWADDR_FMT_plx "\n", offset); ret = 0; } @@ -407,7 +407,7 @@ static void aw_emac_write(void *opaque, hwaddr offset, uint64_t value, default: qemu_log_mask(LOG_UNIMP, "allwinner_emac: write access to unknown register 0x" - TARGET_FMT_plx "\n", offset); + HWADDR_FMT_plx "\n", offset); } } diff --git a/hw/net/fsl_etsec/etsec.c b/hw/net/fsl_etsec/etsec.c index b75d8e3dce..c753bfb3a8 100644 --- a/hw/net/fsl_etsec/etsec.c +++ b/hw/net/fsl_etsec/etsec.c @@ -99,7 +99,7 @@ static uint64_t etsec_read(void *opaque, hwaddr addr, unsigned size) break; } - DPRINTF("Read 0x%08x @ 0x" TARGET_FMT_plx + DPRINTF("Read 0x%08x @ 0x" HWADDR_FMT_plx " : %s (%s)\n", ret, addr, reg->name, reg->desc); @@ -276,7 +276,7 @@ static void etsec_write(void *opaque, } } - DPRINTF("Write 0x%08x @ 0x" TARGET_FMT_plx + DPRINTF("Write 0x%08x @ 0x" HWADDR_FMT_plx " val:0x%08x->0x%08x : %s (%s)\n", (unsigned int)value, addr, before, reg->value, reg->name, reg->desc); diff --git a/hw/net/fsl_etsec/rings.c b/hw/net/fsl_etsec/rings.c index a32589e33b..788463f1b6 100644 --- a/hw/net/fsl_etsec/rings.c +++ b/hw/net/fsl_etsec/rings.c @@ -109,7 +109,7 @@ static void read_buffer_descriptor(eTSEC *etsec, { assert(bd != NULL); - RING_DEBUG("READ Buffer Descriptor @ 0x" TARGET_FMT_plx"\n", addr); + RING_DEBUG("READ Buffer Descriptor @ 0x" HWADDR_FMT_plx"\n", addr); cpu_physical_memory_read(addr, bd, sizeof(eTSEC_rxtx_bd)); @@ -141,7 +141,7 @@ static void write_buffer_descriptor(eTSEC *etsec, stl_be_p(&bd->bufptr, bd->bufptr); } - RING_DEBUG("Write Buffer Descriptor @ 0x" TARGET_FMT_plx"\n", addr); + RING_DEBUG("Write Buffer Descriptor @ 0x" HWADDR_FMT_plx"\n", addr); cpu_physical_memory_write(addr, bd, sizeof(eTSEC_rxtx_bd)); diff --git a/hw/net/pcnet.c b/hw/net/pcnet.c index e63e524913..d456094575 100644 --- a/hw/net/pcnet.c +++ b/hw/net/pcnet.c @@ -908,11 +908,11 @@ static void pcnet_rdte_poll(PCNetState *s) s->csr[37] = nnrd >> 16; #ifdef PCNET_DEBUG if (bad) { - printf("pcnet: BAD RMD RECORDS AFTER 0x" TARGET_FMT_plx "\n", + printf("pcnet: BAD RMD RECORDS AFTER 0x" HWADDR_FMT_plx "\n", crda); } } else { - printf("pcnet: BAD RMD RDA=0x" TARGET_FMT_plx "\n", crda); + printf("pcnet: BAD RMD RDA=0x" HWADDR_FMT_plx "\n", crda); #endif } } diff --git a/hw/net/rocker/rocker.c b/hw/net/rocker/rocker.c index cf54ddf49d..7ea8eb6ba5 100644 --- a/hw/net/rocker/rocker.c +++ b/hw/net/rocker/rocker.c @@ -815,7 +815,7 @@ static void rocker_io_writel(void *opaque, hwaddr addr, uint32_t val) } break; default: - DPRINTF("not implemented dma reg write(l) addr=0x" TARGET_FMT_plx + DPRINTF("not implemented dma reg write(l) addr=0x" HWADDR_FMT_plx " val=0x%08x (ring %d, addr=0x%02x)\n", addr, val, index, offset); break; @@ -857,7 +857,7 @@ static void rocker_io_writel(void *opaque, hwaddr addr, uint32_t val) r->lower32 = 0; break; default: - DPRINTF("not implemented write(l) addr=0x" TARGET_FMT_plx + DPRINTF("not implemented write(l) addr=0x" HWADDR_FMT_plx " val=0x%08x\n", addr, val); break; } @@ -876,8 +876,8 @@ static void rocker_io_writeq(void *opaque, hwaddr addr, uint64_t val) desc_ring_set_base_addr(r->rings[index], val); break; default: - DPRINTF("not implemented dma reg write(q) addr=0x" TARGET_FMT_plx - " val=0x" TARGET_FMT_plx " (ring %d, offset=0x%02x)\n", + DPRINTF("not implemented dma reg write(q) addr=0x" HWADDR_FMT_plx + " val=0x" HWADDR_FMT_plx " (ring %d, offset=0x%02x)\n", addr, val, index, offset); break; } @@ -895,8 +895,8 @@ static void rocker_io_writeq(void *opaque, hwaddr addr, uint64_t val) rocker_port_phys_enable_write(r, val); break; default: - DPRINTF("not implemented write(q) addr=0x" TARGET_FMT_plx - " val=0x" TARGET_FMT_plx "\n", addr, val); + DPRINTF("not implemented write(q) addr=0x" HWADDR_FMT_plx + " val=0x" HWADDR_FMT_plx "\n", addr, val); break; } } @@ -987,8 +987,8 @@ static const char *rocker_reg_name(void *opaque, hwaddr addr) static void rocker_mmio_write(void *opaque, hwaddr addr, uint64_t val, unsigned size) { - DPRINTF("Write %s addr " TARGET_FMT_plx - ", size %u, val " TARGET_FMT_plx "\n", + DPRINTF("Write %s addr " HWADDR_FMT_plx + ", size %u, val " HWADDR_FMT_plx "\n", rocker_reg_name(opaque, addr), addr, size, val); switch (size) { @@ -1060,7 +1060,7 @@ static uint32_t rocker_io_readl(void *opaque, hwaddr addr) ret = desc_ring_get_credits(r->rings[index]); break; default: - DPRINTF("not implemented dma reg read(l) addr=0x" TARGET_FMT_plx + DPRINTF("not implemented dma reg read(l) addr=0x" HWADDR_FMT_plx " (ring %d, addr=0x%02x)\n", addr, index, offset); ret = 0; break; @@ -1115,7 +1115,7 @@ static uint32_t rocker_io_readl(void *opaque, hwaddr addr) ret = (uint32_t)(r->switch_id >> 32); break; default: - DPRINTF("not implemented read(l) addr=0x" TARGET_FMT_plx "\n", addr); + DPRINTF("not implemented read(l) addr=0x" HWADDR_FMT_plx "\n", addr); ret = 0; break; } @@ -1136,7 +1136,7 @@ static uint64_t rocker_io_readq(void *opaque, hwaddr addr) ret = desc_ring_get_base_addr(r->rings[index]); break; default: - DPRINTF("not implemented dma reg read(q) addr=0x" TARGET_FMT_plx + DPRINTF("not implemented dma reg read(q) addr=0x" HWADDR_FMT_plx " (ring %d, addr=0x%02x)\n", addr, index, offset); ret = 0; break; @@ -1165,7 +1165,7 @@ static uint64_t rocker_io_readq(void *opaque, hwaddr addr) ret = r->switch_id; break; default: - DPRINTF("not implemented read(q) addr=0x" TARGET_FMT_plx "\n", addr); + DPRINTF("not implemented read(q) addr=0x" HWADDR_FMT_plx "\n", addr); ret = 0; break; } @@ -1174,7 +1174,7 @@ static uint64_t rocker_io_readq(void *opaque, hwaddr addr) static uint64_t rocker_mmio_read(void *opaque, hwaddr addr, unsigned size) { - DPRINTF("Read %s addr " TARGET_FMT_plx ", size %u\n", + DPRINTF("Read %s addr " HWADDR_FMT_plx ", size %u\n", rocker_reg_name(opaque, addr), addr, size); switch (size) { diff --git a/hw/net/rocker/rocker_desc.c b/hw/net/rocker/rocker_desc.c index f3068c9250..675383db36 100644 --- a/hw/net/rocker/rocker_desc.c +++ b/hw/net/rocker/rocker_desc.c @@ -104,7 +104,7 @@ static bool desc_ring_empty(DescRing *ring) bool desc_ring_set_base_addr(DescRing *ring, uint64_t base_addr) { if (base_addr & 0x7) { - DPRINTF("ERROR: ring[%d] desc base addr (0x" TARGET_FMT_plx + DPRINTF("ERROR: ring[%d] desc base addr (0x" HWADDR_FMT_plx ") not 8-byte aligned\n", ring->index, base_addr); return false; } diff --git a/hw/net/xilinx_axienet.c b/hw/net/xilinx_axienet.c index 990ff3a1c2..7e00965323 100644 --- a/hw/net/xilinx_axienet.c +++ b/hw/net/xilinx_axienet.c @@ -524,7 +524,7 @@ static uint64_t enet_read(void *opaque, hwaddr addr, unsigned size) if (addr < ARRAY_SIZE(s->regs)) { r = s->regs[addr]; } - DENET(qemu_log("%s addr=" TARGET_FMT_plx " v=%x\n", + DENET(qemu_log("%s addr=" HWADDR_FMT_plx " v=%x\n", __func__, addr * 4, r)); break; } @@ -630,7 +630,7 @@ static void enet_write(void *opaque, hwaddr addr, break; default: - DENET(qemu_log("%s addr=" TARGET_FMT_plx " v=%x\n", + DENET(qemu_log("%s addr=" HWADDR_FMT_plx " v=%x\n", __func__, addr * 4, (unsigned)value)); if (addr < ARRAY_SIZE(s->regs)) { s->regs[addr] = value; diff --git a/hw/net/xilinx_ethlite.c b/hw/net/xilinx_ethlite.c index 6e09f7e422..99c22819ea 100644 --- a/hw/net/xilinx_ethlite.c +++ b/hw/net/xilinx_ethlite.c @@ -99,7 +99,7 @@ eth_read(void *opaque, hwaddr addr, unsigned int size) case R_RX_CTRL1: case R_RX_CTRL0: r = s->regs[addr]; - D(qemu_log("%s " TARGET_FMT_plx "=%x\n", __func__, addr * 4, r)); + D(qemu_log("%s " HWADDR_FMT_plx "=%x\n", __func__, addr * 4, r)); break; default: @@ -125,7 +125,7 @@ eth_write(void *opaque, hwaddr addr, if (addr == R_TX_CTRL1) base = 0x800 / 4; - D(qemu_log("%s addr=" TARGET_FMT_plx " val=%x\n", + D(qemu_log("%s addr=" HWADDR_FMT_plx " val=%x\n", __func__, addr * 4, value)); if ((value & (CTRL_P | CTRL_S)) == CTRL_S) { qemu_send_packet(qemu_get_queue(s->nic), @@ -155,7 +155,7 @@ eth_write(void *opaque, hwaddr addr, case R_TX_LEN0: case R_TX_LEN1: case R_TX_GIE0: - D(qemu_log("%s addr=" TARGET_FMT_plx " val=%x\n", + D(qemu_log("%s addr=" HWADDR_FMT_plx " val=%x\n", __func__, addr * 4, value)); s->regs[addr] = value; break; diff --git a/hw/pci-bridge/pci_expander_bridge.c b/hw/pci-bridge/pci_expander_bridge.c index 870d9bab11..e752a21292 100644 --- a/hw/pci-bridge/pci_expander_bridge.c +++ b/hw/pci-bridge/pci_expander_bridge.c @@ -155,7 +155,7 @@ static char *pxb_host_ofw_unit_address(const SysBusDevice *dev) main_host_sbd = SYS_BUS_DEVICE(main_host); if (main_host_sbd->num_mmio > 0) { - return g_strdup_printf(TARGET_FMT_plx ",%x", + return g_strdup_printf(HWADDR_FMT_plx ",%x", main_host_sbd->mmio[0].addr, position + 1); } if (main_host_sbd->num_pio > 0) { diff --git a/hw/pci-host/bonito.c b/hw/pci-host/bonito.c index f04f3ad668..e55e4d2950 100644 --- a/hw/pci-host/bonito.c +++ b/hw/pci-host/bonito.c @@ -254,7 +254,7 @@ static void bonito_writel(void *opaque, hwaddr addr, saddr = addr >> 2; - DPRINTF("bonito_writel "TARGET_FMT_plx" val %lx saddr %x\n", + DPRINTF("bonito_writel "HWADDR_FMT_plx" val %lx saddr %x\n", addr, val, saddr); switch (saddr) { case BONITO_BONPONCFG: @@ -317,7 +317,7 @@ static uint64_t bonito_readl(void *opaque, hwaddr addr, saddr = addr >> 2; - DPRINTF("bonito_readl "TARGET_FMT_plx"\n", addr); + DPRINTF("bonito_readl "HWADDR_FMT_plx"\n", addr); switch (saddr) { case BONITO_INTISR: return s->regs[saddr]; @@ -342,7 +342,7 @@ static void bonito_pciconf_writel(void *opaque, hwaddr addr, PCIBonitoState *s = opaque; PCIDevice *d = PCI_DEVICE(s); - DPRINTF("bonito_pciconf_writel "TARGET_FMT_plx" val %lx\n", addr, val); + DPRINTF("bonito_pciconf_writel "HWADDR_FMT_plx" val %lx\n", addr, val); d->config_write(d, addr, val, 4); } @@ -353,7 +353,7 @@ static uint64_t bonito_pciconf_readl(void *opaque, hwaddr addr, PCIBonitoState *s = opaque; PCIDevice *d = PCI_DEVICE(s); - DPRINTF("bonito_pciconf_readl "TARGET_FMT_plx"\n", addr); + DPRINTF("bonito_pciconf_readl "HWADDR_FMT_plx"\n", addr); return d->config_read(d, addr, 4); } @@ -469,7 +469,7 @@ static uint32_t bonito_sbridge_pciaddr(void *opaque, hwaddr addr) regno = (cfgaddr & BONITO_PCICONF_REG_MASK_HW) >> BONITO_PCICONF_REG_OFFSET; if (idsel == 0) { - error_report("error in bonito pci config address 0x" TARGET_FMT_plx + error_report("error in bonito pci config address 0x" HWADDR_FMT_plx ",pcimap_cfg=0x%x", addr, s->regs[BONITO_PCIMAP_CFG]); exit(1); } @@ -489,7 +489,7 @@ static void bonito_spciconf_write(void *opaque, hwaddr addr, uint64_t val, uint32_t pciaddr; uint16_t status; - DPRINTF("bonito_spciconf_write "TARGET_FMT_plx" size %d val %lx\n", + DPRINTF("bonito_spciconf_write "HWADDR_FMT_plx" size %d val %lx\n", addr, size, val); pciaddr = bonito_sbridge_pciaddr(s, addr); @@ -519,7 +519,7 @@ static uint64_t bonito_spciconf_read(void *opaque, hwaddr addr, unsigned size) uint32_t pciaddr; uint16_t status; - DPRINTF("bonito_spciconf_read "TARGET_FMT_plx" size %d\n", addr, size); + DPRINTF("bonito_spciconf_read "HWADDR_FMT_plx" size %d\n", addr, size); pciaddr = bonito_sbridge_pciaddr(s, addr); diff --git a/hw/pci-host/ppce500.c b/hw/pci-host/ppce500.c index 568849e930..38814247f2 100644 --- a/hw/pci-host/ppce500.c +++ b/hw/pci-host/ppce500.c @@ -189,7 +189,7 @@ static uint64_t pci_reg_read4(void *opaque, hwaddr addr, break; } - pci_debug("%s: win:%lx(addr:" TARGET_FMT_plx ") -> value:%x\n", __func__, + pci_debug("%s: win:%lx(addr:" HWADDR_FMT_plx ") -> value:%x\n", __func__, win, addr, value); return value; } @@ -268,7 +268,7 @@ static void pci_reg_write4(void *opaque, hwaddr addr, win = addr & 0xfe0; - pci_debug("%s: value:%x -> win:%lx(addr:" TARGET_FMT_plx ")\n", + pci_debug("%s: value:%x -> win:%lx(addr:" HWADDR_FMT_plx ")\n", __func__, (unsigned)value, win, addr); switch (win) { diff --git a/hw/pci/pci_host.c b/hw/pci/pci_host.c index eaf217ff55..7f9f75239c 100644 --- a/hw/pci/pci_host.c +++ b/hw/pci/pci_host.c @@ -143,7 +143,7 @@ static void pci_host_config_write(void *opaque, hwaddr addr, { PCIHostState *s = opaque; - PCI_DPRINTF("%s addr " TARGET_FMT_plx " len %d val %"PRIx64"\n", + PCI_DPRINTF("%s addr " HWADDR_FMT_plx " len %d val %"PRIx64"\n", __func__, addr, len, val); if (addr != 0 || len != 4) { return; @@ -157,7 +157,7 @@ static uint64_t pci_host_config_read(void *opaque, hwaddr addr, PCIHostState *s = opaque; uint32_t val = s->config_reg; - PCI_DPRINTF("%s addr " TARGET_FMT_plx " len %d val %"PRIx32"\n", + PCI_DPRINTF("%s addr " HWADDR_FMT_plx " len %d val %"PRIx32"\n", __func__, addr, len, val); return val; } diff --git a/hw/ppc/ppc4xx_sdram.c b/hw/ppc/ppc4xx_sdram.c index a24c80b1d2..4501fb28a5 100644 --- a/hw/ppc/ppc4xx_sdram.c +++ b/hw/ppc/ppc4xx_sdram.c @@ -500,7 +500,7 @@ static uint32_t sdram_ddr2_bcr(hwaddr ram_base, hwaddr ram_size) bcr = 0x8000; break; default: - error_report("invalid RAM size " TARGET_FMT_plx, ram_size); + error_report("invalid RAM size " HWADDR_FMT_plx, ram_size); return 0; } bcr |= ram_base >> 2 & 0xffe00000; diff --git a/hw/rtc/exynos4210_rtc.c b/hw/rtc/exynos4210_rtc.c index d1620c7a2a..2b8a38a296 100644 --- a/hw/rtc/exynos4210_rtc.c +++ b/hw/rtc/exynos4210_rtc.c @@ -374,7 +374,7 @@ static uint64_t exynos4210_rtc_read(void *opaque, hwaddr offset, default: qemu_log_mask(LOG_GUEST_ERROR, - "exynos4210.rtc: bad read offset " TARGET_FMT_plx, + "exynos4210.rtc: bad read offset " HWADDR_FMT_plx, offset); break; } @@ -508,7 +508,7 @@ static void exynos4210_rtc_write(void *opaque, hwaddr offset, default: qemu_log_mask(LOG_GUEST_ERROR, - "exynos4210.rtc: bad write offset " TARGET_FMT_plx, + "exynos4210.rtc: bad write offset " HWADDR_FMT_plx, offset); break; diff --git a/hw/sh4/sh7750.c b/hw/sh4/sh7750.c index c77792d150..ebe0fd96d9 100644 --- a/hw/sh4/sh7750.c +++ b/hw/sh4/sh7750.c @@ -207,13 +207,13 @@ static void portb_changed(SH7750State *s, uint16_t prev) static void error_access(const char *kind, hwaddr addr) { - fprintf(stderr, "%s to %s (0x" TARGET_FMT_plx ") not supported\n", + fprintf(stderr, "%s to %s (0x" HWADDR_FMT_plx ") not supported\n", kind, regname(addr), addr); } static void ignore_access(const char *kind, hwaddr addr) { - fprintf(stderr, "%s to %s (0x" TARGET_FMT_plx ") ignored\n", + fprintf(stderr, "%s to %s (0x" HWADDR_FMT_plx ") ignored\n", kind, regname(addr), addr); } diff --git a/hw/ssi/xilinx_spi.c b/hw/ssi/xilinx_spi.c index b2819a7ff0..552927622f 100644 --- a/hw/ssi/xilinx_spi.c +++ b/hw/ssi/xilinx_spi.c @@ -232,7 +232,7 @@ spi_read(void *opaque, hwaddr addr, unsigned int size) break; } - DB_PRINT("addr=" TARGET_FMT_plx " = %x\n", addr * 4, r); + DB_PRINT("addr=" HWADDR_FMT_plx " = %x\n", addr * 4, r); xlx_spi_update_irq(s); return r; } @@ -244,7 +244,7 @@ spi_write(void *opaque, hwaddr addr, XilinxSPI *s = opaque; uint32_t value = val64; - DB_PRINT("addr=" TARGET_FMT_plx " = %x\n", addr, value); + DB_PRINT("addr=" HWADDR_FMT_plx " = %x\n", addr, value); addr >>= 2; switch (addr) { case R_SRR: diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c index 1e9dba2039..97009d3a5d 100644 --- a/hw/ssi/xilinx_spips.c +++ b/hw/ssi/xilinx_spips.c @@ -887,7 +887,7 @@ static uint64_t xilinx_spips_read(void *opaque, hwaddr addr, case R_INTR_STATUS: ret = s->regs[addr] & IXR_ALL; s->regs[addr] = 0; - DB_PRINT_L(0, "addr=" TARGET_FMT_plx " = %x\n", addr * 4, ret); + DB_PRINT_L(0, "addr=" HWADDR_FMT_plx " = %x\n", addr * 4, ret); xilinx_spips_update_ixr(s); return ret; case R_INTR_MASK: @@ -916,12 +916,12 @@ static uint64_t xilinx_spips_read(void *opaque, hwaddr addr, if (!(s->regs[R_CONFIG] & R_CONFIG_ENDIAN)) { ret <<= 8 * shortfall; } - DB_PRINT_L(0, "addr=" TARGET_FMT_plx " = %x\n", addr * 4, ret); + DB_PRINT_L(0, "addr=" HWADDR_FMT_plx " = %x\n", addr * 4, ret); xilinx_spips_check_flush(s); xilinx_spips_update_ixr(s); return ret; } - DB_PRINT_L(0, "addr=" TARGET_FMT_plx " = %x\n", addr * 4, + DB_PRINT_L(0, "addr=" HWADDR_FMT_plx " = %x\n", addr * 4, s->regs[addr] & mask); return s->regs[addr] & mask; @@ -971,7 +971,7 @@ static void xilinx_spips_write(void *opaque, hwaddr addr, XilinxSPIPS *s = opaque; bool try_flush = true; - DB_PRINT_L(0, "addr=" TARGET_FMT_plx " = %x\n", addr, (unsigned)value); + DB_PRINT_L(0, "addr=" HWADDR_FMT_plx " = %x\n", addr, (unsigned)value); addr >>= 2; switch (addr) { case R_CONFIG: diff --git a/hw/timer/digic-timer.c b/hw/timer/digic-timer.c index d5186f4454..973eab4386 100644 --- a/hw/timer/digic-timer.c +++ b/hw/timer/digic-timer.c @@ -76,7 +76,7 @@ static uint64_t digic_timer_read(void *opaque, hwaddr offset, unsigned size) default: qemu_log_mask(LOG_UNIMP, "digic-timer: read access to unknown register 0x" - TARGET_FMT_plx "\n", offset); + HWADDR_FMT_plx "\n", offset); } return ret; @@ -116,7 +116,7 @@ static void digic_timer_write(void *opaque, hwaddr offset, default: qemu_log_mask(LOG_UNIMP, "digic-timer: read access to unknown register 0x" - TARGET_FMT_plx "\n", offset); + HWADDR_FMT_plx "\n", offset); } } diff --git a/hw/timer/etraxfs_timer.c b/hw/timer/etraxfs_timer.c index ecc2831baf..0205b49912 100644 --- a/hw/timer/etraxfs_timer.c +++ b/hw/timer/etraxfs_timer.c @@ -324,7 +324,7 @@ timer_write(void *opaque, hwaddr addr, t->rw_ack_intr = 0; break; default: - printf ("%s " TARGET_FMT_plx " %x\n", + printf ("%s " HWADDR_FMT_plx " %x\n", __func__, addr, value); break; } diff --git a/hw/timer/exynos4210_mct.c b/hw/timer/exynos4210_mct.c index e175a9f5b9..c17b247da3 100644 --- a/hw/timer/exynos4210_mct.c +++ b/hw/timer/exynos4210_mct.c @@ -1445,7 +1445,7 @@ static void exynos4210_mct_write(void *opaque, hwaddr offset, case L0_ICNTO: case L1_ICNTO: case L0_FRCNTO: case L1_FRCNTO: qemu_log_mask(LOG_GUEST_ERROR, - "exynos4210.mct: write to RO register " TARGET_FMT_plx, + "exynos4210.mct: write to RO register " HWADDR_FMT_plx, offset); break; diff --git a/hw/timer/exynos4210_pwm.c b/hw/timer/exynos4210_pwm.c index 02924a9e5b..3528d0f33a 100644 --- a/hw/timer/exynos4210_pwm.c +++ b/hw/timer/exynos4210_pwm.c @@ -257,7 +257,7 @@ static uint64_t exynos4210_pwm_read(void *opaque, hwaddr offset, default: qemu_log_mask(LOG_GUEST_ERROR, - "exynos4210.pwm: bad read offset " TARGET_FMT_plx, + "exynos4210.pwm: bad read offset " HWADDR_FMT_plx, offset); break; } @@ -352,7 +352,7 @@ static void exynos4210_pwm_write(void *opaque, hwaddr offset, default: qemu_log_mask(LOG_GUEST_ERROR, - "exynos4210.pwm: bad write offset " TARGET_FMT_plx, + "exynos4210.pwm: bad write offset " HWADDR_FMT_plx, offset); break; diff --git a/hw/virtio/virtio-mmio.c b/hw/virtio/virtio-mmio.c index 103260ec15..23ba625eb6 100644 --- a/hw/virtio/virtio-mmio.c +++ b/hw/virtio/virtio-mmio.c @@ -829,10 +829,10 @@ static char *virtio_mmio_bus_get_dev_path(DeviceState *dev) assert(section.mr); if (proxy_path) { - path = g_strdup_printf("%s/virtio-mmio@" TARGET_FMT_plx, proxy_path, + path = g_strdup_printf("%s/virtio-mmio@" HWADDR_FMT_plx, proxy_path, section.offset_within_address_space); } else { - path = g_strdup_printf("virtio-mmio@" TARGET_FMT_plx, + path = g_strdup_printf("virtio-mmio@" HWADDR_FMT_plx, section.offset_within_address_space); } memory_region_unref(section.mr); diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c index 0ec7e52183..8db0532632 100644 --- a/hw/xen/xen_pt.c +++ b/hw/xen/xen_pt.c @@ -434,7 +434,7 @@ static uint64_t xen_pt_bar_read(void *o, hwaddr addr, PCIDevice *d = o; /* if this function is called, that probably means that there is a * misconfiguration of the IOMMU. */ - XEN_PT_ERR(d, "Should not read BAR through QEMU. @0x"TARGET_FMT_plx"\n", + XEN_PT_ERR(d, "Should not read BAR through QEMU. @0x"HWADDR_FMT_plx"\n", addr); return 0; } @@ -443,7 +443,7 @@ static void xen_pt_bar_write(void *o, hwaddr addr, uint64_t val, { PCIDevice *d = o; /* Same comment as xen_pt_bar_read function */ - XEN_PT_ERR(d, "Should not write BAR through QEMU. @0x"TARGET_FMT_plx"\n", + XEN_PT_ERR(d, "Should not write BAR through QEMU. @0x"HWADDR_FMT_plx"\n", addr); } diff --git a/include/exec/hwaddr.h b/include/exec/hwaddr.h index 8f16d179a8..50fbb2d96c 100644 --- a/include/exec/hwaddr.h +++ b/include/exec/hwaddr.h @@ -10,7 +10,7 @@ typedef uint64_t hwaddr; #define HWADDR_MAX UINT64_MAX -#define TARGET_FMT_plx "%016" PRIx64 +#define HWADDR_FMT_plx "%016" PRIx64 #define HWADDR_PRId PRId64 #define HWADDR_PRIi PRIi64 #define HWADDR_PRIo PRIo64 diff --git a/monitor/misc.c b/monitor/misc.c index bf3f1c67ca..fa0a42c261 100644 --- a/monitor/misc.c +++ b/monitor/misc.c @@ -566,7 +566,7 @@ static void memory_dump(Monitor *mon, int count, int format, int wsize, while (len > 0) { if (is_physical) { - monitor_printf(mon, TARGET_FMT_plx ":", addr); + monitor_printf(mon, HWADDR_FMT_plx ":", addr); } else { monitor_printf(mon, TARGET_FMT_lx ":", (target_ulong)addr); } diff --git a/softmmu/memory.c b/softmmu/memory.c index e05332d07f..9d64efca26 100644 --- a/softmmu/memory.c +++ b/softmmu/memory.c @@ -1281,7 +1281,7 @@ static uint64_t unassigned_mem_read(void *opaque, hwaddr addr, unsigned size) { #ifdef DEBUG_UNASSIGNED - printf("Unassigned mem read " TARGET_FMT_plx "\n", addr); + printf("Unassigned mem read " HWADDR_FMT_plx "\n", addr); #endif return 0; } @@ -1290,7 +1290,7 @@ static void unassigned_mem_write(void *opaque, hwaddr addr, uint64_t val, unsigned size) { #ifdef DEBUG_UNASSIGNED - printf("Unassigned mem write " TARGET_FMT_plx " = 0x%"PRIx64"\n", addr, val); + printf("Unassigned mem write " HWADDR_FMT_plx " = 0x%"PRIx64"\n", addr, val); #endif } @@ -3220,9 +3220,9 @@ static void mtree_print_mr(const MemoryRegion *mr, unsigned int level, for (i = 0; i < level; i++) { qemu_printf(MTREE_INDENT); } - qemu_printf(TARGET_FMT_plx "-" TARGET_FMT_plx - " (prio %d, %s%s): alias %s @%s " TARGET_FMT_plx - "-" TARGET_FMT_plx "%s", + qemu_printf(HWADDR_FMT_plx "-" HWADDR_FMT_plx + " (prio %d, %s%s): alias %s @%s " HWADDR_FMT_plx + "-" HWADDR_FMT_plx "%s", cur_start, cur_end, mr->priority, mr->nonvolatile ? "nv-" : "", @@ -3242,7 +3242,7 @@ static void mtree_print_mr(const MemoryRegion *mr, unsigned int level, for (i = 0; i < level; i++) { qemu_printf(MTREE_INDENT); } - qemu_printf(TARGET_FMT_plx "-" TARGET_FMT_plx + qemu_printf(HWADDR_FMT_plx "-" HWADDR_FMT_plx " (prio %d, %s%s): %s%s", cur_start, cur_end, mr->priority, @@ -3329,8 +3329,8 @@ static void mtree_print_flatview(gpointer key, gpointer value, while (n--) { mr = range->mr; if (range->offset_in_region) { - qemu_printf(MTREE_INDENT TARGET_FMT_plx "-" TARGET_FMT_plx - " (prio %d, %s%s): %s @" TARGET_FMT_plx, + qemu_printf(MTREE_INDENT HWADDR_FMT_plx "-" HWADDR_FMT_plx + " (prio %d, %s%s): %s @" HWADDR_FMT_plx, int128_get64(range->addr.start), int128_get64(range->addr.start) + MR_SIZE(range->addr.size), @@ -3340,7 +3340,7 @@ static void mtree_print_flatview(gpointer key, gpointer value, memory_region_name(mr), range->offset_in_region); } else { - qemu_printf(MTREE_INDENT TARGET_FMT_plx "-" TARGET_FMT_plx + qemu_printf(MTREE_INDENT HWADDR_FMT_plx "-" HWADDR_FMT_plx " (prio %d, %s%s): %s", int128_get64(range->addr.start), int128_get64(range->addr.start) diff --git a/softmmu/memory_mapping.c b/softmmu/memory_mapping.c index f6f0a829fd..d7f1d096e0 100644 --- a/softmmu/memory_mapping.c +++ b/softmmu/memory_mapping.c @@ -241,8 +241,8 @@ static void guest_phys_block_add_section(GuestPhysListener *g, } #ifdef DEBUG_GUEST_PHYS_REGION_ADD - fprintf(stderr, "%s: target_start=" TARGET_FMT_plx " target_end=" - TARGET_FMT_plx ": %s (count: %u)\n", __func__, target_start, + fprintf(stderr, "%s: target_start=" HWADDR_FMT_plx " target_end=" + HWADDR_FMT_plx ": %s (count: %u)\n", __func__, target_start, target_end, predecessor ? "joined" : "added", g->list->num); #endif } diff --git a/softmmu/physmem.c b/softmmu/physmem.c index edec095c7a..bf585e45a8 100644 --- a/softmmu/physmem.c +++ b/softmmu/physmem.c @@ -2475,7 +2475,7 @@ static MemTxResult subpage_read(void *opaque, hwaddr addr, uint64_t *data, MemTxResult res; #if defined(DEBUG_SUBPAGE) - printf("%s: subpage %p len %u addr " TARGET_FMT_plx "\n", __func__, + printf("%s: subpage %p len %u addr " HWADDR_FMT_plx "\n", __func__, subpage, len, addr); #endif res = flatview_read(subpage->fv, addr + subpage->base, attrs, buf, len); @@ -2493,7 +2493,7 @@ static MemTxResult subpage_write(void *opaque, hwaddr addr, uint8_t buf[8]; #if defined(DEBUG_SUBPAGE) - printf("%s: subpage %p len %u addr " TARGET_FMT_plx + printf("%s: subpage %p len %u addr " HWADDR_FMT_plx " value %"PRIx64"\n", __func__, subpage, len, addr, value); #endif @@ -2507,7 +2507,7 @@ static bool subpage_accepts(void *opaque, hwaddr addr, { subpage_t *subpage = opaque; #if defined(DEBUG_SUBPAGE) - printf("%s: subpage %p %c len %u addr " TARGET_FMT_plx "\n", + printf("%s: subpage %p %c len %u addr " HWADDR_FMT_plx "\n", __func__, subpage, is_write ? 'w' : 'r', len, addr); #endif @@ -2558,7 +2558,7 @@ static subpage_t *subpage_init(FlatView *fv, hwaddr base) NULL, TARGET_PAGE_SIZE); mmio->iomem.subpage = true; #if defined(DEBUG_SUBPAGE) - printf("%s: %p base " TARGET_FMT_plx " len %08x\n", __func__, + printf("%s: %p base " HWADDR_FMT_plx " len %08x\n", __func__, mmio, base, TARGET_PAGE_SIZE); #endif @@ -3703,7 +3703,7 @@ void mtree_print_dispatch(AddressSpaceDispatch *d, MemoryRegion *root) const char *names[] = { " [unassigned]", " [not dirty]", " [ROM]", " [watch]" }; - qemu_printf(" #%d @" TARGET_FMT_plx ".." TARGET_FMT_plx + qemu_printf(" #%d @" HWADDR_FMT_plx ".." HWADDR_FMT_plx " %s%s%s%s%s", i, s->offset_within_address_space, diff --git a/target/i386/monitor.c b/target/i386/monitor.c index 8e4b4d600c..ad5b7b8bb5 100644 --- a/target/i386/monitor.c +++ b/target/i386/monitor.c @@ -57,7 +57,7 @@ static void print_pte(Monitor *mon, CPUArchState *env, hwaddr addr, { addr = addr_canonical(env, addr); - monitor_printf(mon, TARGET_FMT_plx ": " TARGET_FMT_plx + monitor_printf(mon, HWADDR_FMT_plx ": " HWADDR_FMT_plx " %c%c%c%c%c%c%c%c%c\n", addr, pte & mask, @@ -258,8 +258,8 @@ static void mem_print(Monitor *mon, CPUArchState *env, prot1 = *plast_prot; if (prot != prot1) { if (*pstart != -1) { - monitor_printf(mon, TARGET_FMT_plx "-" TARGET_FMT_plx " " - TARGET_FMT_plx " %c%c%c\n", + monitor_printf(mon, HWADDR_FMT_plx "-" HWADDR_FMT_plx " " + HWADDR_FMT_plx " %c%c%c\n", addr_canonical(env, *pstart), addr_canonical(env, end), addr_canonical(env, end - *pstart), diff --git a/target/loongarch/tlb_helper.c b/target/loongarch/tlb_helper.c index c6d1de50fe..cce1db1e0a 100644 --- a/target/loongarch/tlb_helper.c +++ b/target/loongarch/tlb_helper.c @@ -655,7 +655,7 @@ bool loongarch_cpu_tlb_fill(CPUState *cs, vaddr address, int size, physical & TARGET_PAGE_MASK, prot, mmu_idx, TARGET_PAGE_SIZE); qemu_log_mask(CPU_LOG_MMU, - "%s address=%" VADDR_PRIx " physical " TARGET_FMT_plx + "%s address=%" VADDR_PRIx " physical " HWADDR_FMT_plx " prot %d\n", __func__, address, physical, prot); return true; } else { diff --git a/target/microblaze/op_helper.c b/target/microblaze/op_helper.c index 5b745d0928..f6378030b7 100644 --- a/target/microblaze/op_helper.c +++ b/target/microblaze/op_helper.c @@ -403,7 +403,7 @@ void mb_cpu_transaction_failed(CPUState *cs, hwaddr physaddr, vaddr addr, CPUMBState *env = &cpu->env; qemu_log_mask(CPU_LOG_INT, "Transaction failed: vaddr 0x%" VADDR_PRIx - " physaddr 0x" TARGET_FMT_plx " size %d access type %s\n", + " physaddr 0x" HWADDR_FMT_plx " size %d access type %s\n", addr, physaddr, size, access_type == MMU_INST_FETCH ? "INST_FETCH" : (access_type == MMU_DATA_LOAD ? "DATA_LOAD" : "DATA_STORE")); diff --git a/target/mips/tcg/sysemu/tlb_helper.c b/target/mips/tcg/sysemu/tlb_helper.c index 9d16859c0a..e5e1e9dd3f 100644 --- a/target/mips/tcg/sysemu/tlb_helper.c +++ b/target/mips/tcg/sysemu/tlb_helper.c @@ -924,7 +924,7 @@ bool mips_cpu_tlb_fill(CPUState *cs, vaddr address, int size, switch (ret) { case TLBRET_MATCH: qemu_log_mask(CPU_LOG_MMU, - "%s address=%" VADDR_PRIx " physical " TARGET_FMT_plx + "%s address=%" VADDR_PRIx " physical " HWADDR_FMT_plx " prot %d\n", __func__, address, physical, prot); break; default: diff --git a/target/ppc/mmu-hash32.c b/target/ppc/mmu-hash32.c index cc091c3e62..3976416840 100644 --- a/target/ppc/mmu-hash32.c +++ b/target/ppc/mmu-hash32.c @@ -346,24 +346,24 @@ static hwaddr ppc_hash32_htab_lookup(PowerPCCPU *cpu, ptem = (vsid << 7) | (pgidx >> 10); /* Page address translation */ - qemu_log_mask(CPU_LOG_MMU, "htab_base " TARGET_FMT_plx - " htab_mask " TARGET_FMT_plx - " hash " TARGET_FMT_plx "\n", + qemu_log_mask(CPU_LOG_MMU, "htab_base " HWADDR_FMT_plx + " htab_mask " HWADDR_FMT_plx + " hash " HWADDR_FMT_plx "\n", ppc_hash32_hpt_base(cpu), ppc_hash32_hpt_mask(cpu), hash); /* Primary PTEG lookup */ - qemu_log_mask(CPU_LOG_MMU, "0 htab=" TARGET_FMT_plx "/" TARGET_FMT_plx + qemu_log_mask(CPU_LOG_MMU, "0 htab=" HWADDR_FMT_plx "/" HWADDR_FMT_plx " vsid=%" PRIx32 " ptem=%" PRIx32 - " hash=" TARGET_FMT_plx "\n", + " hash=" HWADDR_FMT_plx "\n", ppc_hash32_hpt_base(cpu), ppc_hash32_hpt_mask(cpu), vsid, ptem, hash); pteg_off = get_pteg_offset32(cpu, hash); pte_offset = ppc_hash32_pteg_search(cpu, pteg_off, 0, ptem, pte); if (pte_offset == -1) { /* Secondary PTEG lookup */ - qemu_log_mask(CPU_LOG_MMU, "1 htab=" TARGET_FMT_plx "/" TARGET_FMT_plx + qemu_log_mask(CPU_LOG_MMU, "1 htab=" HWADDR_FMT_plx "/" HWADDR_FMT_plx " vsid=%" PRIx32 " api=%" PRIx32 - " hash=" TARGET_FMT_plx "\n", ppc_hash32_hpt_base(cpu), + " hash=" HWADDR_FMT_plx "\n", ppc_hash32_hpt_base(cpu), ppc_hash32_hpt_mask(cpu), vsid, ptem, ~hash); pteg_off = get_pteg_offset32(cpu, ~hash); pte_offset = ppc_hash32_pteg_search(cpu, pteg_off, 1, ptem, pte); diff --git a/target/ppc/mmu-hash64.c b/target/ppc/mmu-hash64.c index b9b31fd276..900f906990 100644 --- a/target/ppc/mmu-hash64.c +++ b/target/ppc/mmu-hash64.c @@ -697,15 +697,15 @@ static hwaddr ppc_hash64_htab_lookup(PowerPCCPU *cpu, /* Page address translation */ qemu_log_mask(CPU_LOG_MMU, - "htab_base " TARGET_FMT_plx " htab_mask " TARGET_FMT_plx - " hash " TARGET_FMT_plx "\n", + "htab_base " HWADDR_FMT_plx " htab_mask " HWADDR_FMT_plx + " hash " HWADDR_FMT_plx "\n", ppc_hash64_hpt_base(cpu), ppc_hash64_hpt_mask(cpu), hash); /* Primary PTEG lookup */ qemu_log_mask(CPU_LOG_MMU, - "0 htab=" TARGET_FMT_plx "/" TARGET_FMT_plx + "0 htab=" HWADDR_FMT_plx "/" HWADDR_FMT_plx " vsid=" TARGET_FMT_lx " ptem=" TARGET_FMT_lx - " hash=" TARGET_FMT_plx "\n", + " hash=" HWADDR_FMT_plx "\n", ppc_hash64_hpt_base(cpu), ppc_hash64_hpt_mask(cpu), vsid, ptem, hash); ptex = ppc_hash64_pteg_search(cpu, hash, sps, ptem, pte, pshift); @@ -714,9 +714,9 @@ static hwaddr ppc_hash64_htab_lookup(PowerPCCPU *cpu, /* Secondary PTEG lookup */ ptem |= HPTE64_V_SECONDARY; qemu_log_mask(CPU_LOG_MMU, - "1 htab=" TARGET_FMT_plx "/" TARGET_FMT_plx + "1 htab=" HWADDR_FMT_plx "/" HWADDR_FMT_plx " vsid=" TARGET_FMT_lx " api=" TARGET_FMT_lx - " hash=" TARGET_FMT_plx "\n", ppc_hash64_hpt_base(cpu), + " hash=" HWADDR_FMT_plx "\n", ppc_hash64_hpt_base(cpu), ppc_hash64_hpt_mask(cpu), vsid, ptem, ~hash); ptex = ppc_hash64_pteg_search(cpu, ~hash, sps, ptem, pte, pshift); diff --git a/target/ppc/mmu_common.c b/target/ppc/mmu_common.c index 8901f4d134..7235a4befe 100644 --- a/target/ppc/mmu_common.c +++ b/target/ppc/mmu_common.c @@ -252,7 +252,7 @@ static int ppc6xx_tlb_check(CPUPPCState *env, mmu_ctx_t *ctx, } if (best != -1) { done: - qemu_log_mask(CPU_LOG_MMU, "found TLB at addr " TARGET_FMT_plx + qemu_log_mask(CPU_LOG_MMU, "found TLB at addr " HWADDR_FMT_plx " prot=%01x ret=%d\n", ctx->raddr & TARGET_PAGE_MASK, ctx->prot, ret); /* Update page flags */ @@ -328,7 +328,7 @@ static int get_bat_6xx_tlb(CPUPPCState *env, mmu_ctx_t *ctx, ctx->prot = prot; ret = check_prot(ctx->prot, access_type); if (ret == 0) { - qemu_log_mask(CPU_LOG_MMU, "BAT %d match: r " TARGET_FMT_plx + qemu_log_mask(CPU_LOG_MMU, "BAT %d match: r " HWADDR_FMT_plx " prot=%c%c\n", i, ctx->raddr, ctx->prot & PAGE_READ ? 'R' : '-', ctx->prot & PAGE_WRITE ? 'W' : '-'); @@ -403,9 +403,9 @@ static int get_segment_6xx_tlb(CPUPPCState *env, mmu_ctx_t *ctx, /* Check if instruction fetch is allowed, if needed */ if (type != ACCESS_CODE || ctx->nx == 0) { /* Page address translation */ - qemu_log_mask(CPU_LOG_MMU, "htab_base " TARGET_FMT_plx - " htab_mask " TARGET_FMT_plx - " hash " TARGET_FMT_plx "\n", + qemu_log_mask(CPU_LOG_MMU, "htab_base " HWADDR_FMT_plx + " htab_mask " HWADDR_FMT_plx + " hash " HWADDR_FMT_plx "\n", ppc_hash32_hpt_base(cpu), ppc_hash32_hpt_mask(cpu), hash); ctx->hash[0] = hash; ctx->hash[1] = ~hash; @@ -420,7 +420,7 @@ static int get_segment_6xx_tlb(CPUPPCState *env, mmu_ctx_t *ctx, hwaddr curaddr; uint32_t a0, a1, a2, a3; - qemu_log("Page table: " TARGET_FMT_plx " len " TARGET_FMT_plx + qemu_log("Page table: " HWADDR_FMT_plx " len " HWADDR_FMT_plx "\n", ppc_hash32_hpt_base(cpu), ppc_hash32_hpt_mask(cpu) + 0x80); for (curaddr = ppc_hash32_hpt_base(cpu); @@ -432,7 +432,7 @@ static int get_segment_6xx_tlb(CPUPPCState *env, mmu_ctx_t *ctx, a2 = ldl_phys(cs->as, curaddr + 8); a3 = ldl_phys(cs->as, curaddr + 12); if (a0 != 0 || a1 != 0 || a2 != 0 || a3 != 0) { - qemu_log(TARGET_FMT_plx ": %08x %08x %08x %08x\n", + qemu_log(HWADDR_FMT_plx ": %08x %08x %08x %08x\n", curaddr, a0, a1, a2, a3); } } @@ -578,14 +578,14 @@ static int mmu40x_get_physical_address(CPUPPCState *env, mmu_ctx_t *ctx, if (ret >= 0) { ctx->raddr = raddr; qemu_log_mask(CPU_LOG_MMU, "%s: access granted " TARGET_FMT_lx - " => " TARGET_FMT_plx + " => " HWADDR_FMT_plx " %d %d\n", __func__, address, ctx->raddr, ctx->prot, ret); return 0; } } qemu_log_mask(CPU_LOG_MMU, "%s: access refused " TARGET_FMT_lx - " => " TARGET_FMT_plx + " => " HWADDR_FMT_plx " %d %d\n", __func__, address, raddr, ctx->prot, ret); return ret; @@ -666,11 +666,11 @@ static int mmubooke_get_physical_address(CPUPPCState *env, mmu_ctx_t *ctx, if (ret >= 0) { ctx->raddr = raddr; qemu_log_mask(CPU_LOG_MMU, "%s: access granted " TARGET_FMT_lx - " => " TARGET_FMT_plx " %d %d\n", __func__, + " => " HWADDR_FMT_plx " %d %d\n", __func__, address, ctx->raddr, ctx->prot, ret); } else { qemu_log_mask(CPU_LOG_MMU, "%s: access refused " TARGET_FMT_lx - " => " TARGET_FMT_plx " %d %d\n", __func__, + " => " HWADDR_FMT_plx " %d %d\n", __func__, address, raddr, ctx->prot, ret); } @@ -894,11 +894,11 @@ found_tlb: if (ret >= 0) { ctx->raddr = raddr; qemu_log_mask(CPU_LOG_MMU, "%s: access granted " TARGET_FMT_lx - " => " TARGET_FMT_plx " %d %d\n", __func__, address, + " => " HWADDR_FMT_plx " %d %d\n", __func__, address, ctx->raddr, ctx->prot, ret); } else { qemu_log_mask(CPU_LOG_MMU, "%s: access refused " TARGET_FMT_lx - " => " TARGET_FMT_plx " %d %d\n", __func__, address, + " => " HWADDR_FMT_plx " %d %d\n", __func__, address, raddr, ctx->prot, ret); } diff --git a/target/ppc/mmu_helper.c b/target/ppc/mmu_helper.c index 2a91f3f46a..64e30435f5 100644 --- a/target/ppc/mmu_helper.c +++ b/target/ppc/mmu_helper.c @@ -826,7 +826,7 @@ void helper_4xx_tlbwe_hi(CPUPPCState *env, target_ulong entry, tlb->prot &= ~PAGE_VALID; } tlb->PID = env->spr[SPR_40x_PID]; /* PID */ - qemu_log_mask(CPU_LOG_MMU, "%s: set up TLB %d RPN " TARGET_FMT_plx + qemu_log_mask(CPU_LOG_MMU, "%s: set up TLB %d RPN " HWADDR_FMT_plx " EPN " TARGET_FMT_lx " size " TARGET_FMT_lx " prot %c%c%c%c PID %d\n", __func__, (int)entry, tlb->RPN, tlb->EPN, tlb->size, @@ -864,7 +864,7 @@ void helper_4xx_tlbwe_lo(CPUPPCState *env, target_ulong entry, if (val & PPC4XX_TLBLO_WR) { tlb->prot |= PAGE_WRITE; } - qemu_log_mask(CPU_LOG_MMU, "%s: set up TLB %d RPN " TARGET_FMT_plx + qemu_log_mask(CPU_LOG_MMU, "%s: set up TLB %d RPN " HWADDR_FMT_plx " EPN " TARGET_FMT_lx " size " TARGET_FMT_lx " prot %c%c%c%c PID %d\n", __func__, (int)entry, tlb->RPN, tlb->EPN, tlb->size, diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c index 8ea3442b4a..9a28816521 100644 --- a/target/riscv/cpu_helper.c +++ b/target/riscv/cpu_helper.c @@ -1272,7 +1272,7 @@ bool riscv_cpu_tlb_fill(CPUState *cs, vaddr address, int size, qemu_log_mask(CPU_LOG_MMU, "%s 1st-stage address=%" VADDR_PRIx " ret %d physical " - TARGET_FMT_plx " prot %d\n", + HWADDR_FMT_plx " prot %d\n", __func__, address, ret, pa, prot); if (ret == TRANSLATE_SUCCESS) { @@ -1285,7 +1285,7 @@ bool riscv_cpu_tlb_fill(CPUState *cs, vaddr address, int size, qemu_log_mask(CPU_LOG_MMU, "%s 2nd-stage address=%" VADDR_PRIx " ret %d physical " - TARGET_FMT_plx " prot %d\n", + HWADDR_FMT_plx " prot %d\n", __func__, im_address, ret, pa, prot2); prot &= prot2; @@ -1295,7 +1295,7 @@ bool riscv_cpu_tlb_fill(CPUState *cs, vaddr address, int size, size, access_type, mode); qemu_log_mask(CPU_LOG_MMU, - "%s PMP address=" TARGET_FMT_plx " ret %d prot" + "%s PMP address=" HWADDR_FMT_plx " ret %d prot" " %d tlb_size " TARGET_FMT_lu "\n", __func__, pa, ret, prot_pmp, tlb_size); @@ -1320,7 +1320,7 @@ bool riscv_cpu_tlb_fill(CPUState *cs, vaddr address, int size, qemu_log_mask(CPU_LOG_MMU, "%s address=%" VADDR_PRIx " ret %d physical " - TARGET_FMT_plx " prot %d\n", + HWADDR_FMT_plx " prot %d\n", __func__, address, ret, pa, prot); if (ret == TRANSLATE_SUCCESS) { @@ -1328,7 +1328,7 @@ bool riscv_cpu_tlb_fill(CPUState *cs, vaddr address, int size, size, access_type, mode); qemu_log_mask(CPU_LOG_MMU, - "%s PMP address=" TARGET_FMT_plx " ret %d prot" + "%s PMP address=" HWADDR_FMT_plx " ret %d prot" " %d tlb_size " TARGET_FMT_lu "\n", __func__, pa, ret, prot_pmp, tlb_size); diff --git a/target/riscv/monitor.c b/target/riscv/monitor.c index 17e63fab00..236f93b9f5 100644 --- a/target/riscv/monitor.c +++ b/target/riscv/monitor.c @@ -64,7 +64,7 @@ static void print_pte(Monitor *mon, int va_bits, target_ulong vaddr, return; } - monitor_printf(mon, TARGET_FMT_lx " " TARGET_FMT_plx " " TARGET_FMT_lx + monitor_printf(mon, TARGET_FMT_lx " " HWADDR_FMT_plx " " TARGET_FMT_lx " %c%c%c%c%c%c%c\n", addr_canonical(va_bits, vaddr), paddr, size, diff --git a/target/sparc/ldst_helper.c b/target/sparc/ldst_helper.c index ec4fae78c3..a53580d9e4 100644 --- a/target/sparc/ldst_helper.c +++ b/target/sparc/ldst_helper.c @@ -430,12 +430,12 @@ static void sparc_raise_mmu_fault(CPUState *cs, hwaddr addr, #ifdef DEBUG_UNASSIGNED if (is_asi) { - printf("Unassigned mem %s access of %d byte%s to " TARGET_FMT_plx + printf("Unassigned mem %s access of %d byte%s to " HWADDR_FMT_plx " asi 0x%02x from " TARGET_FMT_lx "\n", is_exec ? "exec" : is_write ? "write" : "read", size, size == 1 ? "" : "s", addr, is_asi, env->pc); } else { - printf("Unassigned mem %s access of %d byte%s to " TARGET_FMT_plx + printf("Unassigned mem %s access of %d byte%s to " HWADDR_FMT_plx " from " TARGET_FMT_lx "\n", is_exec ? "exec" : is_write ? "write" : "read", size, size == 1 ? "" : "s", addr, env->pc); @@ -490,7 +490,7 @@ static void sparc_raise_mmu_fault(CPUState *cs, hwaddr addr, CPUSPARCState *env = &cpu->env; #ifdef DEBUG_UNASSIGNED - printf("Unassigned mem access to " TARGET_FMT_plx " from " TARGET_FMT_lx + printf("Unassigned mem access to " HWADDR_FMT_plx " from " TARGET_FMT_lx "\n", addr, env->pc); #endif diff --git a/target/sparc/mmu_helper.c b/target/sparc/mmu_helper.c index 919448a494..158ec2ae8f 100644 --- a/target/sparc/mmu_helper.c +++ b/target/sparc/mmu_helper.c @@ -230,7 +230,7 @@ bool sparc_cpu_tlb_fill(CPUState *cs, vaddr address, int size, if (likely(error_code == 0)) { qemu_log_mask(CPU_LOG_MMU, "Translate at %" VADDR_PRIx " -> " - TARGET_FMT_plx ", vaddr " TARGET_FMT_lx "\n", + HWADDR_FMT_plx ", vaddr " TARGET_FMT_lx "\n", address, paddr, vaddr); tlb_set_page(cs, vaddr, paddr, prot, mmu_idx, page_size); return true; @@ -356,27 +356,27 @@ void dump_mmu(CPUSPARCState *env) hwaddr pa; uint32_t pde; - qemu_printf("Root ptr: " TARGET_FMT_plx ", ctx: %d\n", + qemu_printf("Root ptr: " HWADDR_FMT_plx ", ctx: %d\n", (hwaddr)env->mmuregs[1] << 4, env->mmuregs[2]); for (n = 0, va = 0; n < 256; n++, va += 16 * 1024 * 1024) { pde = mmu_probe(env, va, 2); if (pde) { pa = cpu_get_phys_page_debug(cs, va); - qemu_printf("VA: " TARGET_FMT_lx ", PA: " TARGET_FMT_plx + qemu_printf("VA: " TARGET_FMT_lx ", PA: " HWADDR_FMT_plx " PDE: " TARGET_FMT_lx "\n", va, pa, pde); for (m = 0, va1 = va; m < 64; m++, va1 += 256 * 1024) { pde = mmu_probe(env, va1, 1); if (pde) { pa = cpu_get_phys_page_debug(cs, va1); qemu_printf(" VA: " TARGET_FMT_lx ", PA: " - TARGET_FMT_plx " PDE: " TARGET_FMT_lx "\n", + HWADDR_FMT_plx " PDE: " TARGET_FMT_lx "\n", va1, pa, pde); for (o = 0, va2 = va1; o < 64; o++, va2 += 4 * 1024) { pde = mmu_probe(env, va2, 0); if (pde) { pa = cpu_get_phys_page_debug(cs, va2); qemu_printf(" VA: " TARGET_FMT_lx ", PA: " - TARGET_FMT_plx " PTE: " + HWADDR_FMT_plx " PTE: " TARGET_FMT_lx "\n", va2, pa, pde); } diff --git a/target/tricore/helper.c b/target/tricore/helper.c index 1db32808e8..114685cce4 100644 --- a/target/tricore/helper.c +++ b/target/tricore/helper.c @@ -79,7 +79,7 @@ bool tricore_cpu_tlb_fill(CPUState *cs, vaddr address, int size, address, rw, mmu_idx); qemu_log_mask(CPU_LOG_MMU, "%s address=" TARGET_FMT_lx " ret %d physical " - TARGET_FMT_plx " prot %d\n", + HWADDR_FMT_plx " prot %d\n", __func__, (target_ulong)address, ret, physical, prot); if (ret == TLBRET_MATCH) { -- 2.38.1 From xen-devel-bounces@lists.xenproject.org Tue Jan 10 22:04:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 22:04:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474988.736461 (Exim 4.92) (envelope-from ) id 1pFMjA-00068h-Hx; Tue, 10 Jan 2023 22:04:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474988.736461; Tue, 10 Jan 2023 22:04:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFMjA-00068a-FI; Tue, 10 Jan 2023 22:04:16 +0000 Received: by outflank-mailman (input) for mailman id 474988; Tue, 10 Jan 2023 22:04:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFMj9-00068U-Ll for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 22:04:15 +0000 Received: from zero.eik.bme.hu (zero.eik.bme.hu [152.66.115.2]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b6e89f3c-9132-11ed-b8d0-410ff93cb8f0; Tue, 10 Jan 2023 23:04:12 +0100 (CET) Received: from zero.eik.bme.hu (blah.eik.bme.hu [152.66.115.182]) by localhost (Postfix) with SMTP id 3ACFA745712; Tue, 10 Jan 2023 23:01:53 +0100 (CET) Received: by zero.eik.bme.hu (Postfix, from userid 432) id F3B30745706; Tue, 10 Jan 2023 23:01:52 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by zero.eik.bme.hu (Postfix) with ESMTP id F05E37456E3; Tue, 10 Jan 2023 23:01:52 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b6e89f3c-9132-11ed-b8d0-410ff93cb8f0 Date: Tue, 10 Jan 2023 23:01:52 +0100 (CET) From: BALATON Zoltan To: =?ISO-8859-15?Q?Philippe_Mathieu-Daud=E9?= cc: qemu-devel@nongnu.org, Peter Maydell , qemu-block@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org, Richard Henderson , =?ISO-8859-15?Q?Alex_Benn=E9e?= , ale@rev.ng, qemu-riscv@nongnu.org, xen-devel@lists.xenproject.org, Thomas Huth Subject: Re: [PATCH] bulk: Rename TARGET_FMT_plx -> HWADDR_FMT_plx In-Reply-To: <20230110212947.34557-1-philmd@linaro.org> Message-ID: References: <20230110212947.34557-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="3866299591-1251169997-1673388112=:35553" X-Spam-Checker-Version: Sophos PMX: 6.4.8.2820816, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2023.1.10.215119, AntiVirus-Engine: 5.96.0, AntiVirus-Data: 2023.1.10.5960001 X-Spam-Flag: NO X-Spam-Probability: 9% X-Spam-Level: X-Spam-Status: No, score=9% required=50% This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --3866299591-1251169997-1673388112=:35553 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8BIT On Tue, 10 Jan 2023, Philippe Mathieu-Daudé wrote: > The 'hwaddr' type is defined in "exec/hwaddr.h" as: > > hwaddr is the type of a physical address > (its size can be different from 'target_ulong'). > > All definitions use the 'HWADDR_' prefix, except TARGET_FMT_plx: > > $ fgrep define include/exec/hwaddr.h > #define HWADDR_H > #define HWADDR_BITS 64 > #define HWADDR_MAX UINT64_MAX > #define TARGET_FMT_plx "%016" PRIx64 > ^^^^^^ > #define HWADDR_PRId PRId64 > #define HWADDR_PRIi PRIi64 > #define HWADDR_PRIo PRIo64 > #define HWADDR_PRIu PRIu64 > #define HWADDR_PRIx PRIx64 Why are there both TARGET_FMT_plx and HWADDR_PRIx? Why not just use HWADDR_PRIx instead? Regards, BALATON Zoltan --3866299591-1251169997-1673388112=:35553-- From xen-devel-bounces@lists.xenproject.org Tue Jan 10 22:26:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 22:26:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.474995.736472 (Exim 4.92) (envelope-from ) id 1pFN4c-00008r-AZ; Tue, 10 Jan 2023 22:26:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 474995.736472; Tue, 10 Jan 2023 22:26:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFN4c-00008k-7B; Tue, 10 Jan 2023 22:26:26 +0000 Received: by outflank-mailman (input) for mailman id 474995; Tue, 10 Jan 2023 22:26:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFN4b-00008e-5E for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 22:26:25 +0000 Received: from mail-vs1-xe31.google.com (mail-vs1-xe31.google.com [2607:f8b0:4864:20::e31]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cf660be4-9135-11ed-b8d0-410ff93cb8f0; Tue, 10 Jan 2023 23:26:22 +0100 (CET) Received: by mail-vs1-xe31.google.com with SMTP id t10so3275214vsr.3 for ; Tue, 10 Jan 2023 14:26:22 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cf660be4-9135-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=IZhsa1BRRn0LWm2+qyDZA4kp5ryKIQ0bdpgv4P9ZnTE=; b=EbqBD4NEjXR7PbLaQ/7HfFBIicc1rO3MgjB5n1JfOsHIpY4+gURtFwcS/efzu6VnK8 iWpEGAjKqM5TgHLahDGE8XAMe/E/WUbLyYPvzw9mq8XLHAwGbZo/rxWnSpEnC+bz3yxZ WQP4btPlXNpgQYLp1TD+syyCVtEgb66e71mdV4gn5e0GFqrU9aSDYFReL1DbCyIy65Ey tOe9Gk10VcffKCB/NaMwK+QdN0V7dCw9c4AOU2cItfhhI4E0PD/OIHx1Z8nOtp4rD3Ax Nqdlx10zGcKrJHtSzDMsQlwKgVotoB57ycFGCb5lQPsZ2g8vOiZ8KdKTDLM/XXTG/Yw1 K8rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IZhsa1BRRn0LWm2+qyDZA4kp5ryKIQ0bdpgv4P9ZnTE=; b=PritcKdxWGpjaNjzIqAALEvVW+cFsnaoASfolJ83ahOe9W0swtZC977L/mhK9tWwTj jtw61OKxA9MCbWp9H0AX3oSym3idDkuSOquzqJKNJY1nlysIxHb022xp7aWWJxeG2akt fok0nBLOKEZ6G/80mPOzFxLkiC2Cmw2YOT7pZ6hvzpBhH19dX5RoAAyT87n/moZf7A/9 F9W1Sz+QFg0bTOmfiSUAZNCLo0S+tT9lVCVPHfoFAYU2/vGYF3yajjazgqbiEiqf7Dt0 v764Iml8J+pqeAU9FzgXxWg63AnPb8VSjUmqIwHl3PjZwFMScerLHXT1CpdZsZeVzrLB Hnnw== X-Gm-Message-State: AFqh2kpxBEBnWto3hRMCF+5dIPWi8grh04ZxOAbjE1onNXAGpYx2MTpr aJ9EjgYG4hBsjHBV/nol+GeBoIQHzgFX21dAwaw= X-Google-Smtp-Source: AMrXdXuWycCwf1rXJCknXxR3cUfEDUJV/lBBOmFmcQSlQ7u1K27uah59lY7T3vkBmtS4/+SMfJNopgy5YwuwOMBL0uc= X-Received: by 2002:a67:6582:0:b0:3d0:d7ce:b383 with SMTP id z124-20020a676582000000b003d0d7ceb383mr119944vsb.72.1673389581218; Tue, 10 Jan 2023 14:26:21 -0800 (PST) MIME-Version: 1.0 References: <7d89e3811e6ea4f307862d6552ad7c7e58176518.1673362493.git.oleksii.kurochko@gmail.com> In-Reply-To: <7d89e3811e6ea4f307862d6552ad7c7e58176518.1673362493.git.oleksii.kurochko@gmail.com> From: Alistair Francis Date: Wed, 11 Jan 2023 08:25:55 +1000 Message-ID: Subject: Re: [PATCH v3 3/6] xen/riscv: introduce stack stuff To: Oleksii Kurochko Cc: xen-devel@lists.xenproject.org, Jan Beulich , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis Content-Type: text/plain; charset="UTF-8" On Wed, Jan 11, 2023 at 1:18 AM Oleksii Kurochko wrote: > > The patch introduces and sets up a stack in order to go to C environment > > Signed-off-by: Oleksii Kurochko Reviewed-by: Alistair Francis Alistair > --- > Changes in V3: > - reorder headers in alphabetical order > - merge changes related to start_xen() function from "[PATCH v2 7/8] > xen/riscv: print hello message from C env" to this patch > - remove unneeded parentheses in definition of STACK_SIZE > --- > Changes in V2: > - introduce STACK_SIZE define. > - use consistent padding between instruction mnemonic and operand(s) > --- > xen/arch/riscv/Makefile | 1 + > xen/arch/riscv/include/asm/config.h | 2 ++ > xen/arch/riscv/riscv64/head.S | 6 +++++- > xen/arch/riscv/setup.c | 14 ++++++++++++++ > 4 files changed, 22 insertions(+), 1 deletion(-) > create mode 100644 xen/arch/riscv/setup.c > > diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile > index 248f2cbb3e..5a67a3f493 100644 > --- a/xen/arch/riscv/Makefile > +++ b/xen/arch/riscv/Makefile > @@ -1,4 +1,5 @@ > obj-$(CONFIG_RISCV_64) += riscv64/ > +obj-y += setup.o > > $(TARGET): $(TARGET)-syms > $(OBJCOPY) -O binary -S $< $@ > diff --git a/xen/arch/riscv/include/asm/config.h b/xen/arch/riscv/include/asm/config.h > index 0370f865f3..763a922a04 100644 > --- a/xen/arch/riscv/include/asm/config.h > +++ b/xen/arch/riscv/include/asm/config.h > @@ -43,6 +43,8 @@ > > #define SMP_CACHE_BYTES (1 << 6) > > +#define STACK_SIZE PAGE_SIZE > + > #endif /* __RISCV_CONFIG_H__ */ > /* > * Local variables: > diff --git a/xen/arch/riscv/riscv64/head.S b/xen/arch/riscv/riscv64/head.S > index 990edb70a0..d444dd8aad 100644 > --- a/xen/arch/riscv/riscv64/head.S > +++ b/xen/arch/riscv/riscv64/head.S > @@ -1,4 +1,8 @@ > .section .text.header, "ax", %progbits > > ENTRY(start) > - j start > + la sp, cpu0_boot_stack > + li t0, STACK_SIZE > + add sp, sp, t0 > + > + tail start_xen > diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c > new file mode 100644 > index 0000000000..13e24e2fe1 > --- /dev/null > +++ b/xen/arch/riscv/setup.c > @@ -0,0 +1,14 @@ > +#include > +#include > + > +/* Xen stack for bringing up the first CPU. */ > +unsigned char __initdata cpu0_boot_stack[STACK_SIZE] > + __aligned(STACK_SIZE); > + > +void __init noreturn start_xen(void) > +{ > + for ( ;; ) > + asm volatile ("wfi"); > + > + unreachable(); > +} > -- > 2.38.1 > > From xen-devel-bounces@lists.xenproject.org Tue Jan 10 22:31:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 Jan 2023 22:31:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475001.736483 (Exim 4.92) (envelope-from ) id 1pFN9E-0001Yu-Ro; Tue, 10 Jan 2023 22:31:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475001.736483; Tue, 10 Jan 2023 22:31:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFN9E-0001Yn-OT; Tue, 10 Jan 2023 22:31:12 +0000 Received: by outflank-mailman (input) for mailman id 475001; Tue, 10 Jan 2023 22:31:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFN9D-0001Yh-Mz for xen-devel@lists.xenproject.org; Tue, 10 Jan 2023 22:31:11 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFN96-0003Zs-Mt; Tue, 10 Jan 2023 22:31:04 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.2.225]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pFN96-0004o6-Ft; Tue, 10 Jan 2023 22:31:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=nL0hgIXtLIRLqID3kiLWMDGxgcSsGiMcy7f4z5lq1Jg=; b=XG6kO7rHNnckMSBBPOWKDM3577 TfGLpg+bfRuQBpU3vI3Y7JisSBzaUyg2I7O8SuvgF33UGVONjNJowJJhEl6jHnurU0E4r8AHn3UVD p5WQ2WZz8TubQbpW9pCsXA+P3TRnW/eIfU4VgGbrOKTL+fbw9EQ0sY+1s8Rjwi6zqJEI=; Message-ID: Date: Tue, 10 Jan 2023 22:31:01 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v3 1/6] xen/riscv: introduce dummy asm/init.h Content-Language: en-US To: Jan Beulich , Stefano Stabellini , Bertrand Marquis Cc: Andrew Cooper , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org, Oleksii Kurochko References: <891d0830-7fdc-202a-5f12-2364cae5bce5@suse.com> From: Julien Grall In-Reply-To: <891d0830-7fdc-202a-5f12-2364cae5bce5@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/01/2023 17:02, Jan Beulich wrote: > Arm maintainers, Hi Jan, > On 10.01.2023 16:17, Oleksii Kurochko wrote: >> --- /dev/null >> +++ b/xen/arch/riscv/include/asm/init.h >> @@ -0,0 +1,12 @@ >> +#ifndef _XEN_ASM_INIT_H >> +#define _XEN_ASM_INIT_H >> + >> +#endif /* _XEN_ASM_INIT_H */ > > instead of having RISC-V introduce an empty stub matching what x86 has, > what would it take to empty Arm's as well, allowing both present ones to > go away and no new one to be introduced? The only thing you have in there > is struct init_info, which doesn't feel like it's properly placed in this > header (x86 has such stuff in setup.h) ... Yes. setup.h should be a good place even though the header is getting quite crowded. I am happy to send a patch for it. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Jan 11 00:38:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 00:38:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475008.736493 (Exim 4.92) (envelope-from ) id 1pFP85-0005WJ-1W; Wed, 11 Jan 2023 00:38:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475008.736493; Wed, 11 Jan 2023 00:38:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFP84-0005WC-V6; Wed, 11 Jan 2023 00:38:08 +0000 Received: by outflank-mailman (input) for mailman id 475008; Wed, 11 Jan 2023 00:38:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFP83-0005W2-3s; Wed, 11 Jan 2023 00:38:07 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFP82-0006rr-S9; Wed, 11 Jan 2023 00:38:06 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFP82-0003TC-BA; Wed, 11 Jan 2023 00:38:06 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pFP82-0003vP-Ah; Wed, 11 Jan 2023 00:38:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To; bh=TWZ+qVXHQP3krp9rAGWxkij9uLoIozYj3G3z4UDpz1A=; b=AnXClTdQK836sQW5umF0qeJ6Vw SZUnYoA541gVyop/idHTXMrrvKYaM24Tdf8NvIYObl7BN0CwAHFTl7SN9iF2U7RYwFrjem8+oQ/AG uyjRm+Ss1GVEEaVUWvkAnFHXe1XYtx0GYUb+dAmZjwrlB47mdBHnt9jvFGdvnEZ+5VKw=; To: xen-devel@lists.xenproject.org Subject: [qemu-mainline bisection] complete build-armhf Message-Id: From: osstest service owner Date: Wed, 11 Jan 2023 00:38:06 +0000 branch xen-unstable xenbranch xen-unstable job build-armhf testid xen-build Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemuu git://git.qemu.org/qemu.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git *** Found and reproduced problem changeset *** Bug is in tree: qemuu git://git.qemu.org/qemu.git Bug introduced: 3d83b78285d6e96636130f7d449fd02e2d4deee0 Bug not present: 528d9f33cad5245c1099d77084c78bb2244d5143 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/175708/ commit 3d83b78285d6e96636130f7d449fd02e2d4deee0 Merge: 528d9f33ca fb418b51b7 Author: Peter Maydell Date: Sun Jan 8 14:27:40 2023 +0000 Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging * Atomic memslot updates for KVM (Emanuele, David) * Always send errors to logfile when daemonized (Greg) * Add support for IDE CompactFlash card (Lubomir) * First round of build system cleanups (myself) * First round of feature removals (myself) * Reduce "qemu/accel.h" inclusion (Philippe) # gpg: Signature made Thu 05 Jan 2023 23:51:09 GMT # gpg: using RSA key F13338574B662389866C7682BFFBD25F78C7AE83 # gpg: issuer "pbonzini@redhat.com" # gpg: Good signature from "Paolo Bonzini " [full] # gpg: aka "Paolo Bonzini " [full] # Primary key fingerprint: 46F5 9FBD 57D6 12E7 BFD4 E2F7 7E15 100C CD36 69B1 # Subkey fingerprint: F133 3857 4B66 2389 866C 7682 BFFB D25F 78C7 AE83 * tag 'for-upstream' of https://gitlab.com/bonzini/qemu: (24 commits) i386: SGX: remove deprecated member of SGXInfo target/i386: Add SGX aex-notify and EDECCSSA support util: remove support -chardev tty and -chardev parport util: remove support for hex numbers with a scaling suffix KVM: remove support for kernel-irqchip=off docs: do not talk about past removal as happening in the future meson: accept relative symlinks in "meson introspect --installed" data meson: cleanup compiler detection meson: support meson 0.64 -Doptimization=plain configure: test all warnings tests/qapi-schema: remove Meson workaround meson: cleanup dummy-cpus.c rules meson: tweak hardening options for Windows configure: remove backwards-compatibility and obsolete options configure: preserve qemu-ga variables configure: cleanup $cpu tests configure: remove dead function configure: remove useless write_c_skeleton ide: Add "ide-cf" driver, a CompactFlash card ide: Add 8-bit data mode ... Signed-off-by: Peter Maydell commit fb418b51b7b43c34873f4b9af3da7031b7452115 Author: Paolo Bonzini Date: Fri Dec 16 11:02:48 2022 +0100 i386: SGX: remove deprecated member of SGXInfo Signed-off-by: Paolo Bonzini commit d45f24fe7525d8a8aaa4ca6d9d214dc41819caa5 Author: Kai Huang Date: Wed Nov 9 15:48:34 2022 +1300 target/i386: Add SGX aex-notify and EDECCSSA support The new SGX Asynchronous Exit (AEX) notification mechanism (AEX-notify) allows one enclave to receive a notification in the ERESUME after the enclave exit due to an AEX. EDECCSSA is a new SGX user leaf function (ENCLU[EDECCSSA]) to facilitate the AEX notification handling. Whether the hardware supports to create enclave with AEX-notify support is enumerated via CPUID.(EAX=0x12,ECX=0x1):EAX[10]. The new EDECCSSA user leaf function is enumerated via CPUID.(EAX=0x12,ECX=0x0):EAX[11]. Add support to allow to expose the new SGX AEX-notify feature and the new EDECCSSA user leaf function to KVM guest. Link: https://lore.kernel.org/lkml/166760360549.4906.809756297092548496.tip-bot2@tip-bot2/ Link: https://lore.kernel.org/lkml/166760360934.4906.2427175408052308969.tip-bot2@tip-bot2/ Reviewed-by: Yang Zhong Signed-off-by: Kai Huang Message-Id: <20221109024834.172705-1-kai.huang@intel.com> Signed-off-by: Paolo Bonzini commit 6f9f630836df355b9ca3f4641e6b7be71f6af076 Author: Paolo Bonzini Date: Fri Dec 16 10:56:53 2022 +0100 util: remove support -chardev tty and -chardev parport These were deprecated in 6.0 and can now be removed. Signed-off-by: Paolo Bonzini commit 8b902e3d2309595567e4957b96e971c4f3ca455e Author: Paolo Bonzini Date: Fri Dec 16 10:50:05 2022 +0100 util: remove support for hex numbers with a scaling suffix This was deprecated in 6.0 and can now be removed. Signed-off-by: Paolo Bonzini commit eaaaf8abdc9a9f3493f2cb6a751660dff3f9db57 Author: Paolo Bonzini Date: Fri Dec 16 10:39:32 2022 +0100 KVM: remove support for kernel-irqchip=off -machine kernel-irqchip=off is broken for many guest OSes; kernel-irqchip=split is the replacement that works, so remove the deprecated support for the former. Signed-off-by: Paolo Bonzini commit 9d3f8b3247795ae8f482700bbbace04b04421d5b Author: Paolo Bonzini Date: Fri Dec 16 11:05:20 2022 +0100 docs: do not talk about past removal as happening in the future KVM guest support on 32-bit Arm hosts *has* been removed, so rephrase the sentence describing it. Signed-off-by: Paolo Bonzini commit f32eb0021a85efaca97f69b0e9201737562a8e4f Author: Paolo Bonzini Date: Wed Dec 14 13:25:00 2022 +0100 meson: accept relative symlinks in "meson introspect --installed" data When installing shared libraries, as is the case for libvfio-user.so, Meson will include relative symbolic links in the output of "meson introspect --installed": { "libvfio-user.so": "/usr/local/lib64/libvfio-user.so", ... } In the case of scripts/symlink-install-tree.py, this will be a symbolic link to a symbolic link but, in any case, there is no issue in creating it. Cc: qemu-stable@nongnu.org Signed-off-by: Paolo Bonzini commit e51340243687a2cd7ffcf0d6e2de030bed4b8720 Author: Paolo Bonzini Date: Wed Oct 12 14:15:06 2022 +0200 meson: cleanup compiler detection Detect all compilers at the beginning of meson.build, and store the available languages in an array. Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit 6a97f3939240977e66e90862419911666956a76a Author: Paolo Bonzini Date: Wed Nov 2 13:07:23 2022 +0100 meson: support meson 0.64 -Doptimization=plain In Meson 0.64, the optimization built-in option now accepts the "plain" value, which will not set any optimization flags. While QEMU does not check the contents of the option and therefore does not suffer any ill effect from the new value, it uses get_option to print the optimization flags in the summary. Clean the code up to remove duplication, and check for -Doptimization=plain at the same time. Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit ca9b5c2ebf1aca87677a24c208bf3d0345c0b1aa Author: Paolo Bonzini Date: Wed Oct 12 14:21:22 2022 +0200 configure: test all warnings Some warnings are hardcoded in QEMU_CFLAGS and not tested. There is no particular reason to single out these five, as many more -W flags are present on all the supported compilers. For homogeneity when moving the detection to meson, make them use the same warn_flags infrastructure. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Paolo Bonzini commit 7bef93ff064f540e24a36a31263ae3db2d06b3d2 Author: Paolo Bonzini Date: Wed Dec 14 12:29:11 2022 +0100 tests/qapi-schema: remove Meson workaround The referenced issue has been fixed since version 0.61, so remove the workaround. Signed-off-by: Paolo Bonzini commit 9c9b85d705abdcce0b63f9182d8140dd67bd13fb Author: Paolo Bonzini Date: Thu Jul 22 10:43:00 2021 +0200 meson: cleanup dummy-cpus.c rules Now that qtest is available on all targets including Windows, dummy-cpus.c is included unconditionally in the build. It also does not need to be compiled per-target. Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit 2d73fa74728dccde5cc29c4e56b4d781e4ead7c4 Author: Paolo Bonzini Date: Wed Nov 2 13:03:51 2022 +0100 meson: tweak hardening options for Windows meson.build has been enabling ASLR _only_ for debug builds since commit d2147e04f95f ("configure: move Windows flags detection to meson", 2022-05-07); instead it was supposed to disable it for debug builds. However, the flag has been enabled for DLLs upstream for roughly 2 years (https://sourceware.org/bugzilla/show_bug.cgi?id=19011), and also by some distros including Debian for 6 years even (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=836365). Enable it unconditionally; we can fix the reversed logic of commit d2147e04f95f later if there are any reports, but for now just enable the hardening. Also add -Wl,--high-entropy-va, which also controls ASLR. Signed-off-by: Paolo Bonzini commit 10229ec3b0ff77c4894cefa312c21e65a761dcde Author: Paolo Bonzini Date: Tue Oct 18 10:17:46 2022 +0200 configure: remove backwards-compatibility and obsolete options Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit 954ed68f9934a3e08f904acb93ce168505995e95 Author: Paolo Bonzini Date: Wed Oct 12 11:35:17 2022 +0200 configure: preserve qemu-ga variables Ensure that qemu-ga variables set at configure time are kept later when the script is rerun. For preserve_env to work, the variables need to be empty so move the default values to config-host.mak generation. Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit f9c77801f4992fae99392ccbb60596dfa1fcf04a Author: Paolo Bonzini Date: Wed Oct 12 15:27:03 2022 +0200 configure: cleanup $cpu tests $cpu is derived from preprocessor defines rather than uname these days, so do not bother using isainfo on Solaris. Likewise do not recognize BeOS's uname -m output. Keep the other, less OS-specific canonicalizations for the benefit of people using --cpu. Reviewed-by: Peter Maydell Signed-off-by: Paolo Bonzini commit 91cd485a6dcbc8210666d19146fe73b8664f0418 Author: Paolo Bonzini Date: Tue Oct 18 10:17:25 2022 +0200 configure: remove dead function Reviewed-by: Peter Maydell Signed-off-by: Paolo Bonzini commit c5634e822416e71e00f08f55a521362d8d21264d Author: Paolo Bonzini Date: Thu Oct 20 14:20:06 2022 +0200 configure: remove useless write_c_skeleton This is not needed ever since QEMU stopped detecting -liberty; this happened with the Meson switch but it is quite likely that the library was not really necessary years before. Reviewed-by: Peter Maydell Signed-off-by: Paolo Bonzini commit cec79db38df72ce74d0296b831e90547111bc13c Author: Lubomir Rintel Date: Wed Nov 30 13:03:19 2022 +0100 ide: Add "ide-cf" driver, a CompactFlash card This allows attaching IDE_CFATA device to an IDE bus. Behaves like a CompactFlash card in True IDE mode. Tested with: qemu-system-i386 \$ -device driver=ide-cf,drive=cf,bus=ide.0 \$ -drive id=cf,index=0,format=raw,if=none,file=cf.img Signed-off-by: Lubomir Rintel Message-Id: <20221130120319.706885-1-lkundrak@v3.sk> Signed-off-by: Paolo Bonzini commit 1ea17d228e582b1cfbf6f61e9da5fafef4063be8 Author: Lubomir Rintel Date: Wed Nov 30 13:02:38 2022 +0100 ide: Add 8-bit data mode CompactFlash uses features 0x01 and 0x81 to enable/disable 8-bit data path. Implement them. Signed-off-by: Lubomir Rintel Message-Id: <20221130120238.706717-1-lkundrak@v3.sk> Signed-off-by: Paolo Bonzini commit 9b063b7ea697d796914b3651d15c3457b7b1135c Author: Greg Kurz Date: Tue Nov 8 15:00:32 2022 +0100 util/log: Always send errors to logfile when daemonized When QEMU is started with `-daemonize`, all stdio descriptors get redirected to `/dev/null`. This basically means that anything printed with error_report() and friends is lost. Current logging code allows to redirect to a file with `-D` but this requires to enable some logging item with `-d` as well to be functional. Relax the check on the log flags when QEMU is daemonized, so that other users of stderr can benefit from the redirection, without the need to enable unwanted debug logs. Previous behaviour is retained for the non-daemonized case. The logic is unrolled as an `if` for better readability. The qemu_log_level and log_per_thread globals reflect the state we want to transition to at this point : use them instead of the intermediary locals for correctness. qemu_set_log_internal() is adapted to open a per-thread log file when '-d tid' is passed. This is done by hijacking qemu_try_lock() which seems simpler that refactoring the code. Signed-off-by: Greg Kurz Message-Id: <20221108140032.1460307-3-groug@kaod.org> Signed-off-by: Paolo Bonzini commit 59bde2137445b63c822720d069d91d38190c6540 Author: Paolo Bonzini Date: Tue Nov 8 15:00:31 2022 +0100 util/log: do not close and reopen log files when flags are turned off log_append makes sure that if you turn off the logging (which clears log_flags and makes need_to_open_file false) the old log is not overwritten. The usecase is that if you remove or move the file QEMU will not keep writing to the old file. However, this is not always the desited behavior, in particular having log_append==1 after changing the file name makes little sense. When qemu_set_log_internal is called from the logfile monitor command, filename must be non-NULL and therefore changed_name must be true. Therefore, the only case where the file is closed and need_to_open_file == false is indeed when log_flags becomes zero. In this case, just flush the file and do not bother closing it, thus faking the same append behavior as previously. The behavioral change is that changing the logfile twice, for example log1 -> log2 -> log1, will cause log1 to be overwritten. This can simply be documented, since it is not a particularly surprising behavior. Suggested-by: Alex Bennée Signed-off-by: Paolo Bonzini Reviewed-by: Richard Henderson Reviewed-by: Greg Kurz Message-Id: <20221025092119.236224-1-pbonzini@redhat.com> [groug: nullify global_file before actually closing the file] Signed-off-by: Greg Kurz Message-Id: <20221108140032.1460307-2-groug@kaod.org> Signed-off-by: Paolo Bonzini commit cc6ff741123216550997b12cdd991beeed47bd0d Author: Philippe Mathieu-Daudé Date: Wed Nov 30 14:56:41 2022 +0100 hw: Reduce "qemu/accel.h" inclusion Move "qemu/accel.h" include from the heavily included "hw/boards.h" to hw/core/machine.c, the single file using the AccelState definition. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Fabiano Rosas Message-Id: <20221130135641.85328-3-philmd@linaro.org> Signed-off-by: Paolo Bonzini commit 3d277871f39d4de42f56b7b0cef5721e525b2d31 Author: Philippe Mathieu-Daudé Date: Wed Nov 30 14:56:40 2022 +0100 typedefs: Forward-declare AccelState Forward-declare AccelState in "qemu/typedefs.h" so structures using a reference of it (like MachineState in "hw/boards.h") don't have to include "qemu/accel.h". Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Fabiano Rosas Message-Id: <20221130135641.85328-2-philmd@linaro.org> Signed-off-by: Paolo Bonzini For bisection revision-tuple graph see: http://logs.test-lab.xenproject.org/osstest/results/bisect/qemu-mainline/build-armhf.xen-build.html Revision IDs in each graph node refer, respectively, to the Trees above. ---------------------------------------- Running cs-bisection-step --graph-out=/home/logs/results/bisect/qemu-mainline/build-armhf.xen-build --summary-out=tmp/175710.bisection-summary --basis-template=175623 --blessings=real,real-bisect,real-retry qemu-mainline build-armhf xen-build Searching for failure / basis pass: 175703 fail [host=cubietruck-gleizes] / 175637 ok. Failure / basis pass flights: 175703 / 175637 Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemuu git://git.qemu.org/qemu.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git Latest 82dd766f25225b0812bbac628c60d2b48f2346e4 aa96ab7c9df59c615ca82b49c9062819e0a1c287 645a64b4911d7cadf5749d7375544fc2384e70ba 692d04a9ca429ca574d859fa8f43578e03b9f8b3 Basis pass d8d829b89dababf763ab33b8cdd852b2830db3cf 528d9f33cad5245c1099d77084c78bb2244d5143 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 Generating revisions with ./adhoc-revtuple-generator git://xenbits.xen.org/osstest/ovmf.git#d8d829b89dababf763ab33b8cdd852b2830db3cf-82dd766f25225b0812bbac628c60d2b48f2346e4 git://git.qemu.org/qemu.git#528d9f33cad5245c1099d77084c78bb2244d5143-aa96ab7c9df59c615ca82b49c9062819e0a1c287 git://xenbits.xen.org/osstest/seabios.git#645a64b4911d7cadf5749d7375544fc2384e70ba-645a64b4911d7cadf5749d7375544fc2384e70ba git://xenbits.xen.org/xen.git#2b21cbbb339fb14414f357a6683b1df74c36fda2-692d04a9ca429ca574d8\ 59fa8f43578e03b9f8b3 Loaded 24993 nodes in revision graph Searching for test results: 175627 [host=cubietruck-braque] 175637 pass d8d829b89dababf763ab33b8cdd852b2830db3cf 528d9f33cad5245c1099d77084c78bb2244d5143 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 175643 fail d8d829b89dababf763ab33b8cdd852b2830db3cf 3d83b78285d6e96636130f7d449fd02e2d4deee0 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 175647 fail d8d829b89dababf763ab33b8cdd852b2830db3cf d6271b657286de80260413684a1f2a63f44ea17b 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 175654 fail irrelevant 175664 fail irrelevant 175672 [host=cubietruck-picasso] 175681 fail irrelevant 175699 pass d8d829b89dababf763ab33b8cdd852b2830db3cf 528d9f33cad5245c1099d77084c78bb2244d5143 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 175700 fail irrelevant 175691 fail irrelevant 175701 fail d8d829b89dababf763ab33b8cdd852b2830db3cf 3d83b78285d6e96636130f7d449fd02e2d4deee0 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 175703 fail 82dd766f25225b0812bbac628c60d2b48f2346e4 aa96ab7c9df59c615ca82b49c9062819e0a1c287 645a64b4911d7cadf5749d7375544fc2384e70ba 692d04a9ca429ca574d859fa8f43578e03b9f8b3 175704 fail irrelevant 175705 pass d8d829b89dababf763ab33b8cdd852b2830db3cf 528d9f33cad5245c1099d77084c78bb2244d5143 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 175708 fail d8d829b89dababf763ab33b8cdd852b2830db3cf 3d83b78285d6e96636130f7d449fd02e2d4deee0 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 175710 fail 82dd766f25225b0812bbac628c60d2b48f2346e4 aa96ab7c9df59c615ca82b49c9062819e0a1c287 645a64b4911d7cadf5749d7375544fc2384e70ba 692d04a9ca429ca574d859fa8f43578e03b9f8b3 Searching for interesting versions Result found: flight 175637 (pass), for basis pass Result found: flight 175703 (fail), for basis failure (at ancestor ~9) Repro found: flight 175705 (pass), for basis pass Repro found: flight 175710 (fail), for basis failure 0 revisions at d8d829b89dababf763ab33b8cdd852b2830db3cf 528d9f33cad5245c1099d77084c78bb2244d5143 645a64b4911d7cadf5749d7375544fc2384e70ba 2b21cbbb339fb14414f357a6683b1df74c36fda2 No revisions left to test, checking graph state. Result found: flight 175637 (pass), for last pass Result found: flight 175643 (fail), for first failure Repro found: flight 175699 (pass), for last pass Repro found: flight 175701 (fail), for first failure Repro found: flight 175705 (pass), for last pass Repro found: flight 175708 (fail), for first failure *** Found and reproduced problem changeset *** Bug is in tree: qemuu git://git.qemu.org/qemu.git Bug introduced: 3d83b78285d6e96636130f7d449fd02e2d4deee0 Bug not present: 528d9f33cad5245c1099d77084c78bb2244d5143 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/175708/ commit 3d83b78285d6e96636130f7d449fd02e2d4deee0 Merge: 528d9f33ca fb418b51b7 Author: Peter Maydell Date: Sun Jan 8 14:27:40 2023 +0000 Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging * Atomic memslot updates for KVM (Emanuele, David) * Always send errors to logfile when daemonized (Greg) * Add support for IDE CompactFlash card (Lubomir) * First round of build system cleanups (myself) * First round of feature removals (myself) * Reduce "qemu/accel.h" inclusion (Philippe) # gpg: Signature made Thu 05 Jan 2023 23:51:09 GMT # gpg: using RSA key F13338574B662389866C7682BFFBD25F78C7AE83 # gpg: issuer "pbonzini@redhat.com" # gpg: Good signature from "Paolo Bonzini " [full] # gpg: aka "Paolo Bonzini " [full] # Primary key fingerprint: 46F5 9FBD 57D6 12E7 BFD4 E2F7 7E15 100C CD36 69B1 # Subkey fingerprint: F133 3857 4B66 2389 866C 7682 BFFB D25F 78C7 AE83 * tag 'for-upstream' of https://gitlab.com/bonzini/qemu: (24 commits) i386: SGX: remove deprecated member of SGXInfo target/i386: Add SGX aex-notify and EDECCSSA support util: remove support -chardev tty and -chardev parport util: remove support for hex numbers with a scaling suffix KVM: remove support for kernel-irqchip=off docs: do not talk about past removal as happening in the future meson: accept relative symlinks in "meson introspect --installed" data meson: cleanup compiler detection meson: support meson 0.64 -Doptimization=plain configure: test all warnings tests/qapi-schema: remove Meson workaround meson: cleanup dummy-cpus.c rules meson: tweak hardening options for Windows configure: remove backwards-compatibility and obsolete options configure: preserve qemu-ga variables configure: cleanup $cpu tests configure: remove dead function configure: remove useless write_c_skeleton ide: Add "ide-cf" driver, a CompactFlash card ide: Add 8-bit data mode ... Signed-off-by: Peter Maydell commit fb418b51b7b43c34873f4b9af3da7031b7452115 Author: Paolo Bonzini Date: Fri Dec 16 11:02:48 2022 +0100 i386: SGX: remove deprecated member of SGXInfo Signed-off-by: Paolo Bonzini commit d45f24fe7525d8a8aaa4ca6d9d214dc41819caa5 Author: Kai Huang Date: Wed Nov 9 15:48:34 2022 +1300 target/i386: Add SGX aex-notify and EDECCSSA support The new SGX Asynchronous Exit (AEX) notification mechanism (AEX-notify) allows one enclave to receive a notification in the ERESUME after the enclave exit due to an AEX. EDECCSSA is a new SGX user leaf function (ENCLU[EDECCSSA]) to facilitate the AEX notification handling. Whether the hardware supports to create enclave with AEX-notify support is enumerated via CPUID.(EAX=0x12,ECX=0x1):EAX[10]. The new EDECCSSA user leaf function is enumerated via CPUID.(EAX=0x12,ECX=0x0):EAX[11]. Add support to allow to expose the new SGX AEX-notify feature and the new EDECCSSA user leaf function to KVM guest. Link: https://lore.kernel.org/lkml/166760360549.4906.809756297092548496.tip-bot2@tip-bot2/ Link: https://lore.kernel.org/lkml/166760360934.4906.2427175408052308969.tip-bot2@tip-bot2/ Reviewed-by: Yang Zhong Signed-off-by: Kai Huang Message-Id: <20221109024834.172705-1-kai.huang@intel.com> Signed-off-by: Paolo Bonzini commit 6f9f630836df355b9ca3f4641e6b7be71f6af076 Author: Paolo Bonzini Date: Fri Dec 16 10:56:53 2022 +0100 util: remove support -chardev tty and -chardev parport These were deprecated in 6.0 and can now be removed. Signed-off-by: Paolo Bonzini commit 8b902e3d2309595567e4957b96e971c4f3ca455e Author: Paolo Bonzini Date: Fri Dec 16 10:50:05 2022 +0100 util: remove support for hex numbers with a scaling suffix This was deprecated in 6.0 and can now be removed. Signed-off-by: Paolo Bonzini commit eaaaf8abdc9a9f3493f2cb6a751660dff3f9db57 Author: Paolo Bonzini Date: Fri Dec 16 10:39:32 2022 +0100 KVM: remove support for kernel-irqchip=off -machine kernel-irqchip=off is broken for many guest OSes; kernel-irqchip=split is the replacement that works, so remove the deprecated support for the former. Signed-off-by: Paolo Bonzini commit 9d3f8b3247795ae8f482700bbbace04b04421d5b Author: Paolo Bonzini Date: Fri Dec 16 11:05:20 2022 +0100 docs: do not talk about past removal as happening in the future KVM guest support on 32-bit Arm hosts *has* been removed, so rephrase the sentence describing it. Signed-off-by: Paolo Bonzini commit f32eb0021a85efaca97f69b0e9201737562a8e4f Author: Paolo Bonzini Date: Wed Dec 14 13:25:00 2022 +0100 meson: accept relative symlinks in "meson introspect --installed" data When installing shared libraries, as is the case for libvfio-user.so, Meson will include relative symbolic links in the output of "meson introspect --installed": { "libvfio-user.so": "/usr/local/lib64/libvfio-user.so", ... } In the case of scripts/symlink-install-tree.py, this will be a symbolic link to a symbolic link but, in any case, there is no issue in creating it. Cc: qemu-stable@nongnu.org Signed-off-by: Paolo Bonzini commit e51340243687a2cd7ffcf0d6e2de030bed4b8720 Author: Paolo Bonzini Date: Wed Oct 12 14:15:06 2022 +0200 meson: cleanup compiler detection Detect all compilers at the beginning of meson.build, and store the available languages in an array. Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit 6a97f3939240977e66e90862419911666956a76a Author: Paolo Bonzini Date: Wed Nov 2 13:07:23 2022 +0100 meson: support meson 0.64 -Doptimization=plain In Meson 0.64, the optimization built-in option now accepts the "plain" value, which will not set any optimization flags. While QEMU does not check the contents of the option and therefore does not suffer any ill effect from the new value, it uses get_option to print the optimization flags in the summary. Clean the code up to remove duplication, and check for -Doptimization=plain at the same time. Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit ca9b5c2ebf1aca87677a24c208bf3d0345c0b1aa Author: Paolo Bonzini Date: Wed Oct 12 14:21:22 2022 +0200 configure: test all warnings Some warnings are hardcoded in QEMU_CFLAGS and not tested. There is no particular reason to single out these five, as many more -W flags are present on all the supported compilers. For homogeneity when moving the detection to meson, make them use the same warn_flags infrastructure. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Paolo Bonzini commit 7bef93ff064f540e24a36a31263ae3db2d06b3d2 Author: Paolo Bonzini Date: Wed Dec 14 12:29:11 2022 +0100 tests/qapi-schema: remove Meson workaround The referenced issue has been fixed since version 0.61, so remove the workaround. Signed-off-by: Paolo Bonzini commit 9c9b85d705abdcce0b63f9182d8140dd67bd13fb Author: Paolo Bonzini Date: Thu Jul 22 10:43:00 2021 +0200 meson: cleanup dummy-cpus.c rules Now that qtest is available on all targets including Windows, dummy-cpus.c is included unconditionally in the build. It also does not need to be compiled per-target. Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit 2d73fa74728dccde5cc29c4e56b4d781e4ead7c4 Author: Paolo Bonzini Date: Wed Nov 2 13:03:51 2022 +0100 meson: tweak hardening options for Windows meson.build has been enabling ASLR _only_ for debug builds since commit d2147e04f95f ("configure: move Windows flags detection to meson", 2022-05-07); instead it was supposed to disable it for debug builds. However, the flag has been enabled for DLLs upstream for roughly 2 years (https://sourceware.org/bugzilla/show_bug.cgi?id=19011), and also by some distros including Debian for 6 years even (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=836365). Enable it unconditionally; we can fix the reversed logic of commit d2147e04f95f later if there are any reports, but for now just enable the hardening. Also add -Wl,--high-entropy-va, which also controls ASLR. Signed-off-by: Paolo Bonzini commit 10229ec3b0ff77c4894cefa312c21e65a761dcde Author: Paolo Bonzini Date: Tue Oct 18 10:17:46 2022 +0200 configure: remove backwards-compatibility and obsolete options Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit 954ed68f9934a3e08f904acb93ce168505995e95 Author: Paolo Bonzini Date: Wed Oct 12 11:35:17 2022 +0200 configure: preserve qemu-ga variables Ensure that qemu-ga variables set at configure time are kept later when the script is rerun. For preserve_env to work, the variables need to be empty so move the default values to config-host.mak generation. Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini commit f9c77801f4992fae99392ccbb60596dfa1fcf04a Author: Paolo Bonzini Date: Wed Oct 12 15:27:03 2022 +0200 configure: cleanup $cpu tests $cpu is derived from preprocessor defines rather than uname these days, so do not bother using isainfo on Solaris. Likewise do not recognize BeOS's uname -m output. Keep the other, less OS-specific canonicalizations for the benefit of people using --cpu. Reviewed-by: Peter Maydell Signed-off-by: Paolo Bonzini commit 91cd485a6dcbc8210666d19146fe73b8664f0418 Author: Paolo Bonzini Date: Tue Oct 18 10:17:25 2022 +0200 configure: remove dead function Reviewed-by: Peter Maydell Signed-off-by: Paolo Bonzini commit c5634e822416e71e00f08f55a521362d8d21264d Author: Paolo Bonzini Date: Thu Oct 20 14:20:06 2022 +0200 configure: remove useless write_c_skeleton This is not needed ever since QEMU stopped detecting -liberty; this happened with the Meson switch but it is quite likely that the library was not really necessary years before. Reviewed-by: Peter Maydell Signed-off-by: Paolo Bonzini commit cec79db38df72ce74d0296b831e90547111bc13c Author: Lubomir Rintel Date: Wed Nov 30 13:03:19 2022 +0100 ide: Add "ide-cf" driver, a CompactFlash card This allows attaching IDE_CFATA device to an IDE bus. Behaves like a CompactFlash card in True IDE mode. Tested with: qemu-system-i386 \$ -device driver=ide-cf,drive=cf,bus=ide.0 \$ -drive id=cf,index=0,format=raw,if=none,file=cf.img Signed-off-by: Lubomir Rintel Message-Id: <20221130120319.706885-1-lkundrak@v3.sk> Signed-off-by: Paolo Bonzini commit 1ea17d228e582b1cfbf6f61e9da5fafef4063be8 Author: Lubomir Rintel Date: Wed Nov 30 13:02:38 2022 +0100 ide: Add 8-bit data mode CompactFlash uses features 0x01 and 0x81 to enable/disable 8-bit data path. Implement them. Signed-off-by: Lubomir Rintel Message-Id: <20221130120238.706717-1-lkundrak@v3.sk> Signed-off-by: Paolo Bonzini commit 9b063b7ea697d796914b3651d15c3457b7b1135c Author: Greg Kurz Date: Tue Nov 8 15:00:32 2022 +0100 util/log: Always send errors to logfile when daemonized When QEMU is started with `-daemonize`, all stdio descriptors get redirected to `/dev/null`. This basically means that anything printed with error_report() and friends is lost. Current logging code allows to redirect to a file with `-D` but this requires to enable some logging item with `-d` as well to be functional. Relax the check on the log flags when QEMU is daemonized, so that other users of stderr can benefit from the redirection, without the need to enable unwanted debug logs. Previous behaviour is retained for the non-daemonized case. The logic is unrolled as an `if` for better readability. The qemu_log_level and log_per_thread globals reflect the state we want to transition to at this point : use them instead of the intermediary locals for correctness. qemu_set_log_internal() is adapted to open a per-thread log file when '-d tid' is passed. This is done by hijacking qemu_try_lock() which seems simpler that refactoring the code. Signed-off-by: Greg Kurz Message-Id: <20221108140032.1460307-3-groug@kaod.org> Signed-off-by: Paolo Bonzini commit 59bde2137445b63c822720d069d91d38190c6540 Author: Paolo Bonzini Date: Tue Nov 8 15:00:31 2022 +0100 util/log: do not close and reopen log files when flags are turned off log_append makes sure that if you turn off the logging (which clears log_flags and makes need_to_open_file false) the old log is not overwritten. The usecase is that if you remove or move the file QEMU will not keep writing to the old file. However, this is not always the desited behavior, in particular having log_append==1 after changing the file name makes little sense. When qemu_set_log_internal is called from the logfile monitor command, filename must be non-NULL and therefore changed_name must be true. Therefore, the only case where the file is closed and need_to_open_file == false is indeed when log_flags becomes zero. In this case, just flush the file and do not bother closing it, thus faking the same append behavior as previously. The behavioral change is that changing the logfile twice, for example log1 -> log2 -> log1, will cause log1 to be overwritten. This can simply be documented, since it is not a particularly surprising behavior. Suggested-by: Alex Bennée Signed-off-by: Paolo Bonzini Reviewed-by: Richard Henderson Reviewed-by: Greg Kurz Message-Id: <20221025092119.236224-1-pbonzini@redhat.com> [groug: nullify global_file before actually closing the file] Signed-off-by: Greg Kurz Message-Id: <20221108140032.1460307-2-groug@kaod.org> Signed-off-by: Paolo Bonzini commit cc6ff741123216550997b12cdd991beeed47bd0d Author: Philippe Mathieu-Daudé Date: Wed Nov 30 14:56:41 2022 +0100 hw: Reduce "qemu/accel.h" inclusion Move "qemu/accel.h" include from the heavily included "hw/boards.h" to hw/core/machine.c, the single file using the AccelState definition. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Fabiano Rosas Message-Id: <20221130135641.85328-3-philmd@linaro.org> Signed-off-by: Paolo Bonzini commit 3d277871f39d4de42f56b7b0cef5721e525b2d31 Author: Philippe Mathieu-Daudé Date: Wed Nov 30 14:56:40 2022 +0100 typedefs: Forward-declare AccelState Forward-declare AccelState in "qemu/typedefs.h" so structures using a reference of it (like MachineState in "hw/boards.h") don't have to include "qemu/accel.h". Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Fabiano Rosas Message-Id: <20221130135641.85328-2-philmd@linaro.org> Signed-off-by: Paolo Bonzini Revision graph left in /home/logs/results/bisect/qemu-mainline/build-armhf.xen-build.{dot,ps,png,html,svg}. ---------------------------------------- 175710: tolerable ALL FAIL flight 175710 qemu-mainline real-bisect [real] http://logs.test-lab.xenproject.org/osstest/logs/175710/ Failures :-/ but no regressions. Tests which did not succeed, including tests which could not be run: build-armhf 6 xen-build fail baseline untested jobs: build-armhf fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary From xen-devel-bounces@lists.xenproject.org Wed Jan 11 00:39:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 00:39:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475017.736505 (Exim 4.92) (envelope-from ) id 1pFP97-00067L-IB; Wed, 11 Jan 2023 00:39:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475017.736505; Wed, 11 Jan 2023 00:39:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFP97-00067E-Dg; Wed, 11 Jan 2023 00:39:13 +0000 Received: by outflank-mailman (input) for mailman id 475017; Wed, 11 Jan 2023 00:39:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFP96-000672-FZ; Wed, 11 Jan 2023 00:39:12 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFP96-0006sf-El; Wed, 11 Jan 2023 00:39:12 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFP96-0003Vw-4l; Wed, 11 Jan 2023 00:39:12 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pFP96-0004PW-4J; Wed, 11 Jan 2023 00:39:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=XACOe9Jsv3kvkMOy/6uZk5JMJ1rX1a1UMfnkoSfWIIE=; b=2CKg48WWqAJj2S9YWDd83uN4jW vcPXSu/yPLzdK41Mz1tn269mg8gmolyFKFRsXEAFxcQJqPR+yIfTRQNLgkSBUq7iSYPv5TUw2j2R3 OCNgGsKGVbtgPzHrHRimJyFjHYO+N00bEIRBy4kUO0Osd31oFmqYhkhGpZ3tWFfrL8EI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 175711: tolerable FAIL - PUSHED X-Osstest-Failures: ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:heisenbug X-Osstest-Versions-This: ovmf=fe405f08a09e9f2306c72aa23d8edfbcfaa23bff X-Osstest-Versions-That: ovmf=ec54ce1f1ab41b92782b37ae59e752fff0ef9c41 From: osstest service owner Date: Wed, 11 Jan 2023 00:39:12 +0000 flight 175711 ovmf real [real] flight 175713 ovmf real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/175711/ http://logs.test-lab.xenproject.org/osstest/logs/175713/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail pass in 175713-retest version targeted for testing: ovmf fe405f08a09e9f2306c72aa23d8edfbcfaa23bff baseline version: ovmf ec54ce1f1ab41b92782b37ae59e752fff0ef9c41 Last test of basis 175707 2023-01-10 17:40:54 Z 0 days Testing same since 175711 2023-01-10 21:40:39 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Michael D Kinney Zachary Clark-Williams Zachary Clark-Williams jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git ec54ce1f1a..fe405f08a0 fe405f08a09e9f2306c72aa23d8edfbcfaa23bff -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Jan 11 01:17:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 01:17:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475027.736516 (Exim 4.92) (envelope-from ) id 1pFPkS-0000Fa-Eb; Wed, 11 Jan 2023 01:17:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475027.736516; Wed, 11 Jan 2023 01:17:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFPkS-0000FS-9K; Wed, 11 Jan 2023 01:17:48 +0000 Received: by outflank-mailman (input) for mailman id 475027; Wed, 11 Jan 2023 01:17:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFPkR-0000FH-5q; Wed, 11 Jan 2023 01:17:47 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFPkR-0006Qr-3a; Wed, 11 Jan 2023 01:17:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFPkQ-0004N4-Nj; Wed, 11 Jan 2023 01:17:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pFPkQ-00009z-NM; Wed, 11 Jan 2023 01:17:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=CdFPKlnrt47iZJh97eTAgD9msfM9iPH4ZbeGmGwRTwo=; b=Nu5Rm5Xcfj59PXa7HMgOXuBHuL gNFWMoKktOvdYXrGmizb76O6wJCypJUheKvFNevh3VNb8+3J9yjXpYOVaJiKWq7sfwNDu6vb/YN1s q6PN5Vsu+idrF/mGecSA0P+InBgWIxCevmZ8n0/prvGLiKYPbiFN2ug7Ontimq/fcdrU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 175712: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=4d975798e11579fdf405b348543061129e01b0fb X-Osstest-Versions-That: xen=692d04a9ca429ca574d859fa8f43578e03b9f8b3 From: osstest service owner Date: Wed, 11 Jan 2023 01:17:46 +0000 flight 175712 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/175712/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 4d975798e11579fdf405b348543061129e01b0fb baseline version: xen 692d04a9ca429ca574d859fa8f43578e03b9f8b3 Last test of basis 175653 2023-01-09 18:05:52 Z 1 days Testing same since 175712 2023-01-10 22:00:26 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Julien Grall jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 692d04a9ca..4d975798e1 4d975798e11579fdf405b348543061129e01b0fb -> smoke From xen-devel-bounces@lists.xenproject.org Wed Jan 11 01:48:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 01:48:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475035.736527 (Exim 4.92) (envelope-from ) id 1pFQDj-0003ce-OL; Wed, 11 Jan 2023 01:48:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475035.736527; Wed, 11 Jan 2023 01:48:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFQDj-0003cF-I5; Wed, 11 Jan 2023 01:48:03 +0000 Received: by outflank-mailman (input) for mailman id 475035; Wed, 11 Jan 2023 01:48:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFQDh-0003c3-Qv; Wed, 11 Jan 2023 01:48:01 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFQDh-00073r-Oe; Wed, 11 Jan 2023 01:48:01 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFQDh-00051m-4w; Wed, 11 Jan 2023 01:48:01 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pFQDh-0000Yu-3W; Wed, 11 Jan 2023 01:48:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=aP9M++HVXyuaYkEn0cw3AFsXunwLV5x9EYYiljqFap0=; b=5La9mAivIRVDUR4g8n78S/DdEq CwySFykiUxBPz2z3bFmzl46tX/vcX+wONPZI9ls8GWt8s943V7rRJmFSS94hgLGVTK/gDwsfcR7UI R3OlYKZ6qe1rn13maRv6vNeToO3zm9Rwv/xVh0o+3QW3BgojqvG3xjXRWwiYtjDlnpnQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 175709: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-amd64-xsm:xen-build:fail:regression qemu-mainline:build-amd64:xen-build:fail:regression qemu-mainline:build-i386:xen-build:fail:regression qemu-mainline:build-arm64-xsm:xen-build:fail:regression qemu-mainline:build-i386-xsm:xen-build:fail:regression qemu-mainline:build-arm64:xen-build:fail:regression qemu-mainline:build-armhf:xen-build:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-coresched-amd64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:build-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-rtds:build-check(1):blocked:nonblocking qemu-mainline:build-arm64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking qemu-mainline:build-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking qemu-mainline:build-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-dom0pvh-xl-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-dom0pvh-xl-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvshim:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-pygrub:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvhv2-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-freebsd11-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-freebsd12-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvhv2-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-multivcpu:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: qemuu=aa96ab7c9df59c615ca82b49c9062819e0a1c287 X-Osstest-Versions-That: qemuu=0ab12aa32462817f0a53fa6f6ce4baf664ef1713 From: osstest service owner Date: Wed, 11 Jan 2023 01:48:01 +0000 flight 175709 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/175709/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 175623 build-amd64 6 xen-build fail REGR. vs. 175623 build-i386 6 xen-build fail REGR. vs. 175623 build-arm64-xsm 6 xen-build fail REGR. vs. 175623 build-i386-xsm 6 xen-build fail REGR. vs. 175623 build-arm64 6 xen-build fail REGR. vs. 175623 build-armhf 6 xen-build fail REGR. vs. 175623 Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-win7-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ws16-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-shadow 1 build-check(1) blocked n/a test-amd64-i386-xl-vhd 1 build-check(1) blocked n/a test-amd64-i386-xl-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) blocked n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) blocked n/a test-armhf-armhf-xl-rtds 1 build-check(1) blocked n/a test-armhf-armhf-xl-vhd 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-amd 1 build-check(1) blocked n/a test-amd64-i386-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-i386 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-amd64 1 build-check(1) blocked n/a test-amd64-coresched-i386-xl 1 build-check(1) blocked n/a test-amd64-coresched-amd64-xl 1 build-check(1) blocked n/a test-amd64-amd64-xl-xsm 1 build-check(1) blocked n/a build-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-shadow 1 build-check(1) blocked n/a test-amd64-amd64-xl-rtds 1 build-check(1) blocked n/a build-arm64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ws16-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a build-armhf-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-amd64-dom0pvh-xl-amd 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 1 build-check(1) blocked n/a test-amd64-amd64-dom0pvh-xl-intel 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvshim 1 build-check(1) blocked n/a test-amd64-amd64-pair 1 build-check(1) blocked n/a test-amd64-amd64-pygrub 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvhv2-intel 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-freebsd11-amd64 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-freebsd12-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvhv2-amd 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-nested-amd 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-nested-intel 1 build-check(1) blocked n/a test-amd64-amd64-xl-multivcpu 1 build-check(1) blocked n/a test-amd64-amd64-xl 1 build-check(1) blocked n/a test-amd64-amd64-xl-credit1 1 build-check(1) blocked n/a test-amd64-amd64-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-arndale 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-intel 1 build-check(1) blocked n/a test-amd64-i386-xl 1 build-check(1) blocked n/a test-amd64-i386-xl-pvshim 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a version targeted for testing: qemuu aa96ab7c9df59c615ca82b49c9062819e0a1c287 baseline version: qemuu 0ab12aa32462817f0a53fa6f6ce4baf664ef1713 Last test of basis 175623 2023-01-07 23:09:00 Z 3 days Failing since 175627 2023-01-08 14:40:14 Z 2 days 12 attempts Testing same since 175654 2023-01-09 18:08:58 Z 1 days 7 attempts ------------------------------------------------------------ People who touched revisions under test: Ard Biesheuvel Bernhard Beschow Christian Borntraeger Cindy Lu Dongli Zhang Eugenio Pérez Greg Kurz Guoyi Tu Hyman Huang(黄勇) Igor Mammedov Jason Wang Jonathan Cameron Kai Huang Laszlo Ersek Lei Xiang leixiang Liuxiangdong Longpeng Lubomir Rintel Marc-André Lureau Markus Armbruster Michael S. Tsirkin Nikita Ivanov Paolo Bonzini Peter Maydell Philippe Mathieu-Daudé Richard Henderson Thomas Huth Yanan Wang Yicong Yang Zeng Chi jobs: build-amd64-xsm fail build-arm64-xsm fail build-i386-xsm fail build-amd64 fail build-arm64 fail build-armhf fail build-i386 fail build-amd64-libvirt blocked build-arm64-libvirt blocked build-armhf-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl blocked test-amd64-coresched-amd64-xl blocked test-arm64-arm64-xl blocked test-armhf-armhf-xl blocked test-amd64-i386-xl blocked test-amd64-coresched-i386-xl blocked test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm blocked test-amd64-i386-xl-qemuu-debianhvm-i386-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm blocked test-arm64-arm64-xl-xsm blocked test-amd64-i386-xl-xsm blocked test-amd64-amd64-qemuu-nested-amd blocked test-amd64-amd64-xl-pvhv2-amd blocked test-amd64-i386-qemuu-rhel6hvm-amd blocked test-amd64-amd64-dom0pvh-xl-amd blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64 blocked test-amd64-i386-xl-qemuu-debianhvm-amd64 blocked test-amd64-i386-freebsd10-amd64 blocked test-amd64-amd64-qemuu-freebsd11-amd64 blocked test-amd64-amd64-qemuu-freebsd12-amd64 blocked test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked test-amd64-amd64-xl-qemuu-win7-amd64 blocked test-amd64-i386-xl-qemuu-win7-amd64 blocked test-amd64-amd64-xl-qemuu-ws16-amd64 blocked test-amd64-i386-xl-qemuu-ws16-amd64 blocked test-armhf-armhf-xl-arndale blocked test-amd64-amd64-xl-credit1 blocked test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 blocked test-amd64-amd64-xl-credit2 blocked test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 blocked test-armhf-armhf-xl-cubietruck blocked test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict blocked test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict blocked test-amd64-i386-freebsd10-i386 blocked test-amd64-amd64-qemuu-nested-intel blocked test-amd64-amd64-xl-pvhv2-intel blocked test-amd64-i386-qemuu-rhel6hvm-intel blocked test-amd64-amd64-dom0pvh-xl-intel blocked test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu blocked test-armhf-armhf-xl-multivcpu blocked test-amd64-amd64-pair blocked test-amd64-i386-pair blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim blocked test-amd64-i386-xl-pvshim blocked test-amd64-amd64-pygrub blocked test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds blocked test-armhf-armhf-xl-rtds blocked test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow blocked test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow blocked test-amd64-amd64-xl-shadow blocked test-amd64-i386-xl-shadow blocked test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd blocked test-amd64-i386-xl-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2556 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Jan 11 03:04:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 03:04:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475044.736538 (Exim 4.92) (envelope-from ) id 1pFRPV-0003cG-8h; Wed, 11 Jan 2023 03:04:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475044.736538; Wed, 11 Jan 2023 03:04:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFRPV-0003c9-5K; Wed, 11 Jan 2023 03:04:17 +0000 Received: by outflank-mailman (input) for mailman id 475044; Wed, 11 Jan 2023 03:04:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFRPT-0003bz-OG; Wed, 11 Jan 2023 03:04:15 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFRPT-0000ig-KF; Wed, 11 Jan 2023 03:04:15 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFRPT-0006kp-8a; Wed, 11 Jan 2023 03:04:15 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pFRPT-0002eW-7y; Wed, 11 Jan 2023 03:04:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=+NxwE6NEMB60Od4y5e6p524A5gFTPx6MBJzagkp8g7g=; b=DYBTzz5WrmYgxpBF6g2kRVW+u4 xnOpTEHuP2LCmCg6k/3Te/uhC10OkBOSq2C/UmawMDCLvyi2k/6aOK4r6eZwa8xE8adrMG5NNYWT5 +owKGf7SKGtHb3CKm9M2xmdVqMOXlx36qXOJRadlwDKOdb5wbVDjcaOu1sIm1NSjOFbM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 175706: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=40c18f363a0806d4f566e8a9a9bd2d7766a72cf5 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Wed, 11 Jan 2023 03:04:15 +0000 flight 175706 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/175706/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine 8 reboot fail REGR. vs. 173462 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux 40c18f363a0806d4f566e8a9a9bd2d7766a72cf5 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 95 days Failing since 173470 2022-10-08 06:21:34 Z 94 days 199 attempts Testing same since 175706 2023-01-10 17:40:05 Z 0 days 1 attempts ------------------------------------------------------------ 3319 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 505758 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Jan 11 03:24:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 03:24:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475052.736549 (Exim 4.92) (envelope-from ) id 1pFRj1-000608-TP; Wed, 11 Jan 2023 03:24:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475052.736549; Wed, 11 Jan 2023 03:24:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFRj1-000601-Q2; Wed, 11 Jan 2023 03:24:27 +0000 Received: by outflank-mailman (input) for mailman id 475052; Wed, 11 Jan 2023 03:24:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFRj0-0005zr-DL; Wed, 11 Jan 2023 03:24:26 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFRj0-0001CT-BW; Wed, 11 Jan 2023 03:24:26 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFRiz-0007Mv-TO; Wed, 11 Jan 2023 03:24:25 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pFRiz-0001SR-Sk; Wed, 11 Jan 2023 03:24:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=nH8HPizo21iSp5t+H++796J1pK2fD+QJmm4NQGEJzlo=; b=thXKFGGDI2DL5cOMUZM/H1669o qq4koSsQ53cCLI9+1u6rrrYJUDLzi2kvgGBni2oWXnHo1wm97GlbEOL7acebANKptMIvZiqZysKlH EPLfC4K3KY/uruGbdAFyNTL0I8HkitMrhHfzTYwizMQMntZTyYlw92HdTJM0knTdNsTw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xtf test] 175715: all pass - PUSHED X-Osstest-Versions-This: xtf=c0f454c68329301447fd258e47824f7d402f19e9 X-Osstest-Versions-That: xtf=d1b8b7c312d2cf0e501ed43e88e45bba2c6986b5 From: osstest service owner Date: Wed, 11 Jan 2023 03:24:25 +0000 flight 175715 xtf real [real] http://logs.test-lab.xenproject.org/osstest/logs/175715/ Perfect :-) All tests in this flight passed as required version targeted for testing: xtf c0f454c68329301447fd258e47824f7d402f19e9 baseline version: xtf d1b8b7c312d2cf0e501ed43e88e45bba2c6986b5 Last test of basis 175508 2022-12-27 20:12:16 Z 14 days Testing same since 175715 2023-01-11 01:41:46 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper jobs: build-amd64-xtf pass build-amd64 pass build-amd64-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xtf.git d1b8b7c..c0f454c c0f454c68329301447fd258e47824f7d402f19e9 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Jan 11 04:29:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 04:29:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475060.736560 (Exim 4.92) (envelope-from ) id 1pFSk6-0003nD-Ha; Wed, 11 Jan 2023 04:29:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475060.736560; Wed, 11 Jan 2023 04:29:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFSk6-0003n6-EH; Wed, 11 Jan 2023 04:29:38 +0000 Received: by outflank-mailman (input) for mailman id 475060; Wed, 11 Jan 2023 04:29:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFSk5-0003mw-Se; Wed, 11 Jan 2023 04:29:37 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFSk5-0002ig-On; Wed, 11 Jan 2023 04:29:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFSk5-0002Lg-CU; Wed, 11 Jan 2023 04:29:37 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pFSk5-0001TY-Bo; Wed, 11 Jan 2023 04:29:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=3uOPmtWBUBTw35P2hc/+UUHYSMfCoiT/VICta7/Rfq0=; b=p1p5JkDAGtectHCy9g7WU0GmWK 7MKcgKZHFtK7S1e6t3WyPx6rumAuh9LFXok16gZPyVtGWRCSvVTTRIxhidl9E5N8gEZbBDEXzCmCg pFrdW2/xNYx799u/SDTxeg6LAbE8Tg+EiTqYzg/ezvQVKG02cDvplztI1WjL3SvLhX4w=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 175716: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-amd64-xsm:xen-build:fail:regression qemu-mainline:build-amd64:xen-build:fail:regression qemu-mainline:build-i386:xen-build:fail:regression qemu-mainline:build-arm64-xsm:xen-build:fail:regression qemu-mainline:build-i386-xsm:xen-build:fail:regression qemu-mainline:build-arm64:xen-build:fail:regression qemu-mainline:build-armhf:xen-build:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-coresched-amd64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:build-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-rtds:build-check(1):blocked:nonblocking qemu-mainline:build-arm64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking qemu-mainline:build-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking qemu-mainline:build-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-dom0pvh-xl-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-dom0pvh-xl-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvshim:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-pygrub:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvhv2-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-freebsd11-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-freebsd12-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvhv2-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-multivcpu:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: qemuu=aa96ab7c9df59c615ca82b49c9062819e0a1c287 X-Osstest-Versions-That: qemuu=0ab12aa32462817f0a53fa6f6ce4baf664ef1713 From: osstest service owner Date: Wed, 11 Jan 2023 04:29:37 +0000 flight 175716 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/175716/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 175623 build-amd64 6 xen-build fail REGR. vs. 175623 build-i386 6 xen-build fail REGR. vs. 175623 build-arm64-xsm 6 xen-build fail REGR. vs. 175623 build-i386-xsm 6 xen-build fail REGR. vs. 175623 build-arm64 6 xen-build fail REGR. vs. 175623 build-armhf 6 xen-build fail REGR. vs. 175623 Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-win7-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ws16-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-shadow 1 build-check(1) blocked n/a test-amd64-i386-xl-vhd 1 build-check(1) blocked n/a test-amd64-i386-xl-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) blocked n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) blocked n/a test-armhf-armhf-xl-rtds 1 build-check(1) blocked n/a test-armhf-armhf-xl-vhd 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-amd 1 build-check(1) blocked n/a test-amd64-i386-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-i386 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-amd64 1 build-check(1) blocked n/a test-amd64-coresched-i386-xl 1 build-check(1) blocked n/a test-amd64-coresched-amd64-xl 1 build-check(1) blocked n/a test-amd64-amd64-xl-xsm 1 build-check(1) blocked n/a build-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-shadow 1 build-check(1) blocked n/a test-amd64-amd64-xl-rtds 1 build-check(1) blocked n/a build-arm64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ws16-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a build-armhf-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-amd64-dom0pvh-xl-amd 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 1 build-check(1) blocked n/a test-amd64-amd64-dom0pvh-xl-intel 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvshim 1 build-check(1) blocked n/a test-amd64-amd64-pair 1 build-check(1) blocked n/a test-amd64-amd64-pygrub 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvhv2-intel 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-freebsd11-amd64 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-freebsd12-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvhv2-amd 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-nested-amd 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-nested-intel 1 build-check(1) blocked n/a test-amd64-amd64-xl-multivcpu 1 build-check(1) blocked n/a test-amd64-amd64-xl 1 build-check(1) blocked n/a test-amd64-amd64-xl-credit1 1 build-check(1) blocked n/a test-amd64-amd64-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-arndale 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-intel 1 build-check(1) blocked n/a test-amd64-i386-xl 1 build-check(1) blocked n/a test-amd64-i386-xl-pvshim 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a version targeted for testing: qemuu aa96ab7c9df59c615ca82b49c9062819e0a1c287 baseline version: qemuu 0ab12aa32462817f0a53fa6f6ce4baf664ef1713 Last test of basis 175623 2023-01-07 23:09:00 Z 3 days Failing since 175627 2023-01-08 14:40:14 Z 2 days 13 attempts Testing same since 175654 2023-01-09 18:08:58 Z 1 days 8 attempts ------------------------------------------------------------ People who touched revisions under test: Ard Biesheuvel Bernhard Beschow Christian Borntraeger Cindy Lu Dongli Zhang Eugenio Pérez Greg Kurz Guoyi Tu Hyman Huang(黄勇) Igor Mammedov Jason Wang Jonathan Cameron Kai Huang Laszlo Ersek Lei Xiang leixiang Liuxiangdong Longpeng Lubomir Rintel Marc-André Lureau Markus Armbruster Michael S. Tsirkin Nikita Ivanov Paolo Bonzini Peter Maydell Philippe Mathieu-Daudé Richard Henderson Thomas Huth Yanan Wang Yicong Yang Zeng Chi jobs: build-amd64-xsm fail build-arm64-xsm fail build-i386-xsm fail build-amd64 fail build-arm64 fail build-armhf fail build-i386 fail build-amd64-libvirt blocked build-arm64-libvirt blocked build-armhf-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl blocked test-amd64-coresched-amd64-xl blocked test-arm64-arm64-xl blocked test-armhf-armhf-xl blocked test-amd64-i386-xl blocked test-amd64-coresched-i386-xl blocked test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm blocked test-amd64-i386-xl-qemuu-debianhvm-i386-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm blocked test-arm64-arm64-xl-xsm blocked test-amd64-i386-xl-xsm blocked test-amd64-amd64-qemuu-nested-amd blocked test-amd64-amd64-xl-pvhv2-amd blocked test-amd64-i386-qemuu-rhel6hvm-amd blocked test-amd64-amd64-dom0pvh-xl-amd blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64 blocked test-amd64-i386-xl-qemuu-debianhvm-amd64 blocked test-amd64-i386-freebsd10-amd64 blocked test-amd64-amd64-qemuu-freebsd11-amd64 blocked test-amd64-amd64-qemuu-freebsd12-amd64 blocked test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked test-amd64-amd64-xl-qemuu-win7-amd64 blocked test-amd64-i386-xl-qemuu-win7-amd64 blocked test-amd64-amd64-xl-qemuu-ws16-amd64 blocked test-amd64-i386-xl-qemuu-ws16-amd64 blocked test-armhf-armhf-xl-arndale blocked test-amd64-amd64-xl-credit1 blocked test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 blocked test-amd64-amd64-xl-credit2 blocked test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 blocked test-armhf-armhf-xl-cubietruck blocked test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict blocked test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict blocked test-amd64-i386-freebsd10-i386 blocked test-amd64-amd64-qemuu-nested-intel blocked test-amd64-amd64-xl-pvhv2-intel blocked test-amd64-i386-qemuu-rhel6hvm-intel blocked test-amd64-amd64-dom0pvh-xl-intel blocked test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu blocked test-armhf-armhf-xl-multivcpu blocked test-amd64-amd64-pair blocked test-amd64-i386-pair blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim blocked test-amd64-i386-xl-pvshim blocked test-amd64-amd64-pygrub blocked test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds blocked test-armhf-armhf-xl-rtds blocked test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow blocked test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow blocked test-amd64-amd64-xl-shadow blocked test-amd64-i386-xl-shadow blocked test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd blocked test-amd64-i386-xl-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2556 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Jan 11 06:37:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 06:37:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475069.736571 (Exim 4.92) (envelope-from ) id 1pFUjE-0000GG-VF; Wed, 11 Jan 2023 06:36:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475069.736571; Wed, 11 Jan 2023 06:36:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFUjE-0000G4-R8; Wed, 11 Jan 2023 06:36:52 +0000 Received: by outflank-mailman (input) for mailman id 475069; Wed, 11 Jan 2023 06:36:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFUjD-0000Fy-Lx for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 06:36:51 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5375e9bb-917a-11ed-b8d0-410ff93cb8f0; Wed, 11 Jan 2023 07:36:49 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 38539767AF; Wed, 11 Jan 2023 06:36:48 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1446313591; Wed, 11 Jan 2023 06:36:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id uQRkAwBZvmPpDwAAMHmgww (envelope-from ); Wed, 11 Jan 2023 06:36:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5375e9bb-917a-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1673419008; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JaBNeXv3JHHEZzeIDo3MVWFDAOvKZX193fiyQ4pPOJ4=; b=M4sHfpFQ+vLCruT3vRJ0x+AvFGg9BMQ713MwvhZ0a5lnXP0fEpLpQ6hRd90RzayXroq6MM ArkdSY5iCLNgTJKrmIM3DB+NBebmICWExJTTKs5ToLmL5kRyHwmLrHYXJEEURPj4fZZsd1 X8A9Z8yoDxVET4JaYNd2/HfLt+rwRVI= Message-ID: <27c0f7bd-b548-17f4-d675-7143e218fd65@suse.com> Date: Wed, 11 Jan 2023 07:36:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 04/19] tools/xenstore: remove all watches when a domain has stopped Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20221213160045.28170-1-jgross@suse.com> <20221213160045.28170-5-jgross@suse.com> <831c0e75-1a23-6210-9f5b-7212a6763dc3@xen.org> From: Juergen Gross In-Reply-To: <831c0e75-1a23-6210-9f5b-7212a6763dc3@xen.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------543lBimyMSr6wfImjmhUjh0V" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------543lBimyMSr6wfImjmhUjh0V Content-Type: multipart/mixed; boundary="------------QnXaG4DvJ01tw3PmipuYzTR0"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD Message-ID: <27c0f7bd-b548-17f4-d675-7143e218fd65@suse.com> Subject: Re: [PATCH v2 04/19] tools/xenstore: remove all watches when a domain has stopped References: <20221213160045.28170-1-jgross@suse.com> <20221213160045.28170-5-jgross@suse.com> <831c0e75-1a23-6210-9f5b-7212a6763dc3@xen.org> In-Reply-To: <831c0e75-1a23-6210-9f5b-7212a6763dc3@xen.org> --------------QnXaG4DvJ01tw3PmipuYzTR0 Content-Type: multipart/mixed; boundary="------------XdaIJZ0eb0W0NGn75bMqIkpx" --------------XdaIJZ0eb0W0NGn75bMqIkpx Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjAuMTIuMjIgMjA6MDEsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGkgSnVlcmdlbiwN Cj4gDQo+IE9uIDEzLzEyLzIwMjIgMTY6MDAsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBX aGVuIGEgZG9tYWluIGhhcyBiZWVuIHJlbGVhc2VkIGJ5IFhlbiB0b29scywgcmVtb3ZlIGFs bCBpdHMNCj4+IHJlZ2lzdGVyZWQgd2F0Y2hlcy4gVGhpcyBhdm9pZHMgc2VuZGluZyB3YXRj aCBldmVudHMgdG8gdGhlIGRlYWQgZG9tYWluDQo+PiB3aGVuIGFsbCB0aGUgbm9kZXMgcmVs YXRlZCB0byBpdCBhcmUgYmVpbmcgcmVtb3ZlZCBieSB0aGUgWGVuIHRvb2xzLg0KPiANCj4g QUZBSUNULCB0aGUgb25seSB1c2VyIG9mIHRoZSBjb21tYW5kIGluIHRoZSB0cmVlIGlzIHNv ZnRyZXNldC4gV291bGQgeW91IGJlIGFibGUgDQo+IHRvIGNoZWNrIHRoaXMgaXMgc3RpbGwg d29ya2luZyBhcyBleHBlY3RlZD8NCg0KU2VlbXMgdG8gd29yayBmaW5lLg0KDQoNCkp1ZXJn ZW4NCg== --------------XdaIJZ0eb0W0NGn75bMqIkpx Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------XdaIJZ0eb0W0NGn75bMqIkpx-- --------------QnXaG4DvJ01tw3PmipuYzTR0-- --------------543lBimyMSr6wfImjmhUjh0V Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmO+WP8FAwAAAAAACgkQsN6d1ii/Ey+o PQf+NNNGZzTLYRWZ6eDnIi+WZa7cfKJlPaRIpUXp69u6zH8fvwAKy4rVKyRRDaBXqK8+UWFQbBXe pdJNXUGFtBrLumABe7IBdW5bx6qH0qT8azuL5TAXxEYNnVwaEvI8KZNaxgq5Y81p2LmVsNfXyBHT hFqRDJt/pYj2eiBuJc6dRx6JFKyDBE9SPm2VvKG9KSS8d9qnfMEQ7/S/Tpe7g7597VlEv5bKjaPk sg8g/G0X9RSoxsr6/RKW6IqrgTDHaToFd1mZa+8R+nBVo4elAIUgMagHdKu/NhjS60MrZBivOg5T uNANbh1PYyUzdXJr8CAdcUUvb4zuN0uN6oeB+IuhjA== =lgfh -----END PGP SIGNATURE----- --------------543lBimyMSr6wfImjmhUjh0V-- From xen-devel-bounces@lists.xenproject.org Wed Jan 11 06:41:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 06:41:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475077.736582 (Exim 4.92) (envelope-from ) id 1pFUnd-0001h8-Jx; Wed, 11 Jan 2023 06:41:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475077.736582; Wed, 11 Jan 2023 06:41:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFUnd-0001h1-Gj; Wed, 11 Jan 2023 06:41:25 +0000 Received: by outflank-mailman (input) for mailman id 475077; Wed, 11 Jan 2023 06:41:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFUnb-0001gv-SU for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 06:41:23 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f621b1ea-917a-11ed-91b6-6bf2151ebd3b; Wed, 11 Jan 2023 07:41:22 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 5D52F767FD; Wed, 11 Jan 2023 06:41:21 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3CF0413591; Wed, 11 Jan 2023 06:41:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 9TdUDRFavmOtEQAAMHmgww (envelope-from ); Wed, 11 Jan 2023 06:41:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f621b1ea-917a-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1673419281; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+vW4S4y4+XfNKdBHLKvlFz/sa6uAIQgJqHzcbiqqzL0=; b=iB2JM4997ocQyGAojts/fvPXeOPTAFwDW43/uqWUvk4DGPQLIoVHXMyOMLoqRFjIBp66h/ 93M5g9g8ijuYGoPoALWGDXG/LhyNcuswtPNsSegxfLMmeF9/auv4SuPCz+2I2eAclZWSz1 kcOGsO1Oh701vpx8iHqQVbvjWeU98eU= Message-ID: Date: Wed, 11 Jan 2023 07:41:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 07/19] tools/xenstore: introduce dummy nodes for special watch paths Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20221213160045.28170-1-jgross@suse.com> <20221213160045.28170-8-jgross@suse.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------PKamcPk8MnVCPoaJSA6OwDn2" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------PKamcPk8MnVCPoaJSA6OwDn2 Content-Type: multipart/mixed; boundary="------------7q8kZOtFBX4uJ9pMUoKvfi7t"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD Message-ID: Subject: Re: [PATCH v2 07/19] tools/xenstore: introduce dummy nodes for special watch paths References: <20221213160045.28170-1-jgross@suse.com> <20221213160045.28170-8-jgross@suse.com> In-Reply-To: --------------7q8kZOtFBX4uJ9pMUoKvfi7t Content-Type: multipart/mixed; boundary="------------ITGsB4urG0ZsP17XW4b2tN4Y" --------------ITGsB4urG0ZsP17XW4b2tN4Y Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjAuMTIuMjIgMjA6MzksIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGkgSnVlcmdlbiwN Cj4gDQo+IE9uIDEzLzEyLzIwMjIgMTY6MDAsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBJ bnN0ZWFkIG9mIHNwZWNpYWwgY2FzaW5nIHRoZSBwZXJtaXNzaW9uIGhhbmRsaW5nIGFuZCB3 YXRjaCBldmVudA0KPj4gZmlyaW5nIGZvciB0aGUgc3BlY2lhbCB3YXRjaCBwYXRocyAiQGlu dHJvZHVjZURvbWFpbiIgYW5kDQo+PiAiQHJlbGVhc2VEb21haW4iLCB1c2Ugc3RhdGljIGR1 bW15IG5vZGVzIGFkZGVkIHRvIHRoZSBkYXRhIGJhc2Ugd2hlbg0KPj4gc3RhcnRpbmcgWGVu c3RvcmUuDQo+Pg0KPj4gVGhlIG5vZGUgYWNjb3VudGluZyBuZWVkcyB0byByZWZsZWN0IHRo YXQgY2hhbmdlIGJ5IGFkZGluZyB0aGUgc3BlY2lhbA0KPj4gbm9kZXMgaW4gdGhlIGRvbWFp bl9lbnRyeV9maXgoKSBjYWxsIGluIHNldHVwX3N0cnVjdHVyZSgpLg0KPj4NCj4+IE5vdGUg dGhhdCB0aGlzIHJlcXVpcmVzIHRvIHJld29yayB0aGUgY2FsbHMgb2YgZmlyZV93YXRjaGVz KCkgZm9yIHRoZQ0KPj4gc3BlY2lhbCBldmVudHMgaW4gb3JkZXIgdG8gYXZvaWQgbGVha2lu ZyBtZW1vcnkuDQo+Pg0KPj4gTW92ZSB0aGUgY2hlY2sgZm9yIGEgdmFsaWQgbm9kZSBuYW1l IGZyb20gZ2V0X25vZGUoKSB0bw0KPj4gZ2V0X25vZGVfY2Fub25pY2FsaXplZCgpLCBhcyBp dCBhbGxvd3MgdG8gdXNlIGdldF9ub2RlKCkgZm9yIHRoZQ0KPj4gc3BlY2lhbCBub2Rlcywg dG9vLg0KPj4NCj4+IEluIG9yZGVyIHRvIGF2b2lkIHJlYWQgYW5kIHdyaXRlIGFjY2Vzc2Vz IHRvIHRoZSBzcGVjaWFsIG5vZGVzIHVzZSBhDQo+PiBzcGVjaWFsIHZhcmlhbnQgZm9yIG9i dGFpbmluZyB0aGUgY3VycmVudCBub2RlIGRhdGEgZm9yIHRoZSBwZXJtaXNzaW9uDQo+PiBo YW5kbGluZy4NCj4+DQo+PiBUaGlzIGFsbG93cyB0byBzaW1wbGlmeSBxdWl0ZSBzb21lIGNv ZGUuIEluIGZ1dHVyZSBzdWItbm9kZXMgb2YgdGhlDQo+PiBzcGVjaWFsIG5vZGVzIHdpbGwg YmUgcG9zc2libGUgZHVlIHRvIHRoaXMgY2hhbmdlLCBhbGxvd2luZyBtb3JlIGZpbmUNCj4+ IGdyYWluZWQgcGVybWlzc2lvbiBjb250cm9sIG9mIHNwZWNpYWwgZXZlbnRzIGZvciBzcGVj aWZpYyBkb21haW5zLg0KPj4NCj4+IFNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpn cm9zc0BzdXNlLmNvbT4NCj4+IC0tLQ0KPj4gVjI6DQo+PiAtIGFkZCBnZXRfc3BlY19ub2Rl KCkNCj4+IC0gZXhwYW5kIGNvbW1pdCBtZXNzYWdlIChKdWxpZW4gR3JhbGwpDQo+PiAtLS0N Cj4+IMKgIHRvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb250cm9sLmMgfMKgwqAgMyAtDQo+ PiDCoCB0b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jwqDCoMKgIHzCoCA5MiArKysr KysrKystLS0tLS0tDQo+PiDCoCB0b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmPC oCB8IDE2MiArKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQ0KPj4gwqAgdG9vbHMveGVu c3RvcmUveGVuc3RvcmVkX2RvbWFpbi5owqAgfMKgwqAgNiAtLQ0KPj4gwqAgdG9vbHMveGVu c3RvcmUveGVuc3RvcmVkX3dhdGNoLmPCoMKgIHzCoCAxNyArLS0NCj4+IMKgIDUgZmlsZXMg Y2hhbmdlZCwgODAgaW5zZXJ0aW9ucygrKSwgMjAwIGRlbGV0aW9ucygtKQ0KPj4NCj4+IGRp ZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29udHJvbC5jIA0KPj4gYi90 b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29udHJvbC5jDQo+PiBpbmRleCBkMWFhYTAwYmY0 Li40MWU2OTkyNTkxIDEwMDY0NA0KPj4gLS0tIGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVk X2NvbnRyb2wuYw0KPj4gKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvbnRyb2wu Yw0KPj4gQEAgLTY3Niw5ICs2NzYsNiBAQCBzdGF0aWMgY29uc3QgY2hhciAqbHVfZHVtcF9z dGF0ZShjb25zdCB2b2lkICpjdHgsIHN0cnVjdCANCj4+IGNvbm5lY3Rpb24gKmNvbm4pDQo+ PiDCoMKgwqDCoMKgIGlmIChyZXQpDQo+PiDCoMKgwqDCoMKgwqDCoMKgwqAgZ290byBvdXQ7 DQo+PiDCoMKgwqDCoMKgIHJldCA9IGR1bXBfc3RhdGVfY29ubmVjdGlvbnMoZnApOw0KPj4g LcKgwqDCoCBpZiAocmV0KQ0KPj4gLcKgwqDCoMKgwqDCoMKgIGdvdG8gb3V0Ow0KPj4gLcKg wqDCoCByZXQgPSBkdW1wX3N0YXRlX3NwZWNpYWxfbm9kZXMoZnApOw0KPj4gwqDCoMKgwqDC oCBpZiAocmV0KQ0KPj4gwqDCoMKgwqDCoMKgwqDCoMKgIGdvdG8gb3V0Ow0KPj4gwqDCoMKg wqDCoCByZXQgPSBkdW1wX3N0YXRlX25vZGVzKGZwLCBjdHgpOw0KPj4gZGlmZiAtLWdpdCBh L3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMgYi90b29scy94ZW5zdG9yZS94ZW5z dG9yZWRfY29yZS5jDQo+PiBpbmRleCAxNjUwODIxOTIyLi5mOTY3MTRlMWI4IDEwMDY0NA0K Pj4gLS0tIGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYw0KPj4gKysrIGIvdG9v bHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYw0KPj4gQEAgLTYxNiw3ICs2MTYsOCBAQCBz dGF0aWMgdm9pZCBnZXRfYWNjX2RhdGEoVERCX0RBVEEgKmtleSwgc3RydWN0IA0KPj4gbm9k ZV9hY2NvdW50X2RhdGEgKmFjYykNCj4+IMKgIHN0YXRpYyB1bnNpZ25lZCBpbnQgZ2V0X2Fj Y19kb21pZChzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgVERCX0RBVEEgKmtleSwNCj4+IMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHVuc2lnbmVkIGludCBkb21p ZCkNCj4+IMKgIHsNCj4+IC3CoMKgwqAgcmV0dXJuICghY29ubiB8fCBrZXktPmRwdHJbMF0g PT0gJy8nKSA/IGRvbWlkIDogY29ubi0+aWQ7DQo+PiArwqDCoMKgIHJldHVybiAoIWNvbm4g fHwga2V5LT5kcHRyWzBdID09ICcvJyB8fCBrZXktPmRwdHJbMF0gPT0gJ0AnKQ0KPiANCj4g VGhlIGNvbW1lbnQgb24gdG9wIG9mIGdldF9hY2NfZG9taWQoKSBuZWVkcyB0byBiZSB1cGRh dGVkLg0KDQpPaCwgeWVzLg0KDQo+IA0KPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgID8gZG9t aWQgOiBjb25uLT5pZDsNCj4+IMKgIH0NCj4gDQo+IFsuLi5dDQo+IA0KPj4gK3N0YXRpYyB2 b2lkIGZpcmVfc3BlY2lhbF93YXRjaGVzKGNvbnN0IGNoYXIgKm5hbWUpDQo+PiArew0KPj4g K8KgwqDCoCB2b2lkICpjdHggPSB0YWxsb2NfbmV3KE5VTEwpOw0KPj4gK8KgwqDCoCBzdHJ1 Y3Qgbm9kZSAqbm9kZTsNCj4+ICsNCj4+ICvCoMKgwqAgaWYgKCFjdHgpDQo+PiArwqDCoMKg wqDCoMKgwqAgcmV0dXJuOw0KPj4gKw0KPj4gK8KgwqDCoCBub2RlID0gcmVhZF9ub2RlKE5V TEwsIGN0eCwgbmFtZSk7DQo+PiArDQo+PiArwqDCoMKgIGlmIChub2RlKQ0KPj4gK8KgwqDC oMKgwqDCoMKgIGZpcmVfd2F0Y2hlcyhOVUxMLCBjdHgsIG5hbWUsIG5vZGUsIHRydWUsIE5V TEwpOw0KPiANCj4gTklUOiBJIHdvdWxkIGNvbnNpZGVyIHRvIGxvZyBhbiBlcnJvciAobWF5 YmUgb25seSBvbmNlKSBpZiAnbm9kZScgaXMgTlVMTC4gVGhlIA0KPiBwdXJwb3NlIGlzIHRv IGhlbHAgZGVidWdnaW5nIFhlbnN0b3JlZC4NCg0KSSB0aGluayB3ZSBjYW4gbG9nIGl0IGFs d2F5cywgYXMgdGhpcyBpcyByZWFsbHkgYSBiYWQgcHJvYmxlbS4NCg0KDQpKdWVyZ2VuDQo= --------------ITGsB4urG0ZsP17XW4b2tN4Y Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------ITGsB4urG0ZsP17XW4b2tN4Y-- --------------7q8kZOtFBX4uJ9pMUoKvfi7t-- --------------PKamcPk8MnVCPoaJSA6OwDn2 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmO+WhAFAwAAAAAACgkQsN6d1ii/Ey/H HAgAhOvLTDg5w53w2vG33Eum8ZngSadlt2L2Rjfn1Ylv7h9REeNHJQO39LYrXz6y8PcQ2pGcFVlY h8giNYfid8dn2fxCtrNFX5yRcstPKc/vIxkB/v2KPBIGecuzk6/ZJlY+k6o/coQIl8H30M3+JZV8 0/TL7lcjGHyhH7LDWdU3q5MDXMaEWNrmAmv1uXzAlgSpto24bv/C0gnmHRT3ODUjGFO5flM9v0PF eJ6R29srn8o+yZyRAmSFV373SnPNEe9iXAdbXvtG457XFDFYZRt/FaBDUrxTpJD7BATf+An0jaJt UlQvAIHDNP8YS9SuN0ZO5Sc2lBO39Q+jHDfG/7Qtrg== =idBP -----END PGP SIGNATURE----- --------------PKamcPk8MnVCPoaJSA6OwDn2-- From xen-devel-bounces@lists.xenproject.org Wed Jan 11 06:48:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 06:48:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475083.736593 (Exim 4.92) (envelope-from ) id 1pFUuY-0002NC-9f; Wed, 11 Jan 2023 06:48:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475083.736593; Wed, 11 Jan 2023 06:48:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFUuY-0002N5-71; Wed, 11 Jan 2023 06:48:34 +0000 Received: by outflank-mailman (input) for mailman id 475083; Wed, 11 Jan 2023 06:48:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFUuW-0002Mz-Pn for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 06:48:32 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f58832ca-917b-11ed-b8d0-410ff93cb8f0; Wed, 11 Jan 2023 07:48:30 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 286BD6C4B3; Wed, 11 Jan 2023 06:48:30 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 04C7C13591; Wed, 11 Jan 2023 06:48:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id h0bgOr1bvmN6FAAAMHmgww (envelope-from ); Wed, 11 Jan 2023 06:48:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f58832ca-917b-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1673419710; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=h/xsLmYu8PUeVBs7m9IadSmfo18cmPayuL3NLFVkB3A=; b=kVuiqtsle7luVDg0xLgVPsW+6c0N/l/5nO6yrFYmxt03hcO3QUfwz93XdyQ9QlIaZwS09d f9D9TRKlSkvU+i/1D94iJBulKdM9uuqGiFo9KPZIvcauM015+5IQL/YFj0z8qY2x25esVe 6a5nBGkhiQFoFw4jIRos64DYmF4vlzE= Message-ID: <163d32e1-7deb-e177-a334-c1dd27f3e2c5@suse.com> Date: Wed, 11 Jan 2023 07:48:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 08/19] tools/xenstore: replace watch->relative_path with a prefix length Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20221213160045.28170-1-jgross@suse.com> <20221213160045.28170-9-jgross@suse.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------MncdTU0DTfpFocwTVofiMOMe" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------MncdTU0DTfpFocwTVofiMOMe Content-Type: multipart/mixed; boundary="------------YWS0fT3dUpV2wVLegTZwDaFU"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD Message-ID: <163d32e1-7deb-e177-a334-c1dd27f3e2c5@suse.com> Subject: Re: [PATCH v2 08/19] tools/xenstore: replace watch->relative_path with a prefix length References: <20221213160045.28170-1-jgross@suse.com> <20221213160045.28170-9-jgross@suse.com> In-Reply-To: --------------YWS0fT3dUpV2wVLegTZwDaFU Content-Type: multipart/mixed; boundary="------------NxgSjV8HyGqqKi4Gpuo4LrEL" --------------NxgSjV8HyGqqKi4Gpuo4LrEL Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjAuMTIuMjIgMjA6NDIsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGkgSnVlcmdlbiwN Cj4gDQo+IE9uIDEzLzEyLzIwMjIgMTY6MDAsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBA QCAtMzEzLDE5ICszMDIsMTkgQEAgY29uc3QgY2hhciAqZHVtcF9zdGF0ZV93YXRjaGVzKEZJ TEUgKmZwLCBzdHJ1Y3QgDQo+PiBjb25uZWN0aW9uICpjb25uLA0KPj4gwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB1bnNpZ25lZCBpbnQgY29ubl9pZCkNCj4+ IMKgIHsNCj4+IMKgwqDCoMKgwqAgY29uc3QgY2hhciAqcmV0ID0gTlVMTDsNCj4+ICvCoMKg wqAgY29uc3QgY2hhciAqd2F0Y2hfcGF0aDsNCj4+IMKgwqDCoMKgwqAgc3RydWN0IHdhdGNo ICp3YXRjaDsNCj4+IMKgwqDCoMKgwqAgc3RydWN0IHhzX3N0YXRlX3dhdGNoIHN3Ow0KPj4g wqDCoMKgwqDCoCBzdHJ1Y3QgeHNfc3RhdGVfcmVjb3JkX2hlYWRlciBoZWFkOw0KPj4gLcKg wqDCoCBjb25zdCBjaGFyICpwYXRoOw0KPj4gwqDCoMKgwqDCoCBoZWFkLnR5cGUgPSBYU19T VEFURV9UWVBFX1dBVENIOw0KPj4gwqDCoMKgwqDCoCBsaXN0X2Zvcl9lYWNoX2VudHJ5KHdh dGNoLCAmY29ubi0+d2F0Y2hlcywgbGlzdCkgew0KPj4gwqDCoMKgwqDCoMKgwqDCoMKgIGhl YWQubGVuZ3RoID0gc2l6ZW9mKHN3KTsNCj4+ICvCoMKgwqDCoMKgwqDCoCB3YXRjaF9wYXRo ID0gZ2V0X3dhdGNoX3BhdGgod2F0Y2gsIHdhdGNoLT5ub2RlKTsNCj4gDQo+IEl0IGlzIG5v dCBjbGVhciB0byBtZSB3aHkgeW91IGNhbGwgZ2V0X3dhdGNoX3BhdGgoKSBlYXJsaWVyIGFu ZCBhbHNvIHJlbmFtZSB0aGUgDQo+IHZhcmlhYmxlLg0KPiANCj4gSSBkb24ndCBtaW5kIHRo ZSBuZXcgbmFtZSwgYnV0IGl0IGRvZXNuJ3QgZmVlbCBsaWtlIGl0IGJlbG9uZ3MgdG8gdGhp cyBwYXRjaCBhcyANCj4gdGhlIGNvZGUgaW4gZHV5bXBfc3RhdGVfd2F0Y2hlcygpIHdvdWxk IG5vdCBiZSBjaGFuZ2VkIG90aGVyd2lzZS4NCg0KQm90aCBjaGFuZ2VzIGFyZSB0aGUgcmVz dWx0IG9mIFYxIG9mIHRoZSBzZXJpZXMuIFdpbGwgdW5kbyB0aGVtLg0KDQoNCkp1ZXJnZW4N Cg== --------------NxgSjV8HyGqqKi4Gpuo4LrEL Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------NxgSjV8HyGqqKi4Gpuo4LrEL-- --------------YWS0fT3dUpV2wVLegTZwDaFU-- --------------MncdTU0DTfpFocwTVofiMOMe Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmO+W70FAwAAAAAACgkQsN6d1ii/Ey9z 2gf8Duyiba2HuQ1nQt/75qeCr90HHRt2R1NeDKWbNdHndactjt2JyEYlpAST5Er++swyzd4f8iuh 7ED/uOjRRdPXCuyUtqBdSdU15+xVlfUemXypyvkeVC6JcUvHmlXUS1h1zrquuQKoci14OE/C0EiN VddJvJi1k6UfJzpTkZ4WYxQWlDv0M0G7Iw6PC3S7Ih7H3jRM08ZYb0nZYhm5pvGgdSFsXZt3HrWn uvPyunUR9jMQ8q/UYQJ65F6pjtE8JeVo12kExBXb0WZ1rqDOsGeQEq3akSV25EEo8qAX0eEYKuov De59w9lMRC4Ga8XyB+u+MTZOqGYGBmZQ4m3b9ilY6g== =EvL5 -----END PGP SIGNATURE----- --------------MncdTU0DTfpFocwTVofiMOMe-- From xen-devel-bounces@lists.xenproject.org Wed Jan 11 07:10:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 07:10:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475090.736604 (Exim 4.92) (envelope-from ) id 1pFVFd-0005jj-53; Wed, 11 Jan 2023 07:10:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475090.736604; Wed, 11 Jan 2023 07:10:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFVFd-0005jc-2L; Wed, 11 Jan 2023 07:10:21 +0000 Received: by outflank-mailman (input) for mailman id 475090; Wed, 11 Jan 2023 07:10:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFVFb-0005jW-ME for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 07:10:19 +0000 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [2a00:1450:4864:20::431]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 004f5cb0-917f-11ed-b8d0-410ff93cb8f0; Wed, 11 Jan 2023 08:10:17 +0100 (CET) Received: by mail-wr1-x431.google.com with SMTP id d17so14095027wrs.2 for ; Tue, 10 Jan 2023 23:10:17 -0800 (PST) Received: from [192.168.30.216] ([81.0.6.76]) by smtp.gmail.com with ESMTPSA id c10-20020a056000104a00b002238ea5750csm15291197wrx.72.2023.01.10.23.10.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Jan 2023 23:10:16 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 004f5cb0-917f-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=JLMrfUKmlGGDmWYHnk7ZCXAGeJsLRVrjdj3i8XFCUkM=; b=QsnvU3QjCsGrUrsWmZMal1dSye7ALlPTlWdR8roEyrDSpSTxK4uCYZRp8s0YPW7Pi+ iNCH8BzYk3d67MKeCG1vRxV7zdeIFTl3dhKrDxswgfX1ppqfAPl/q5ksc0vXLhXpgmZ5 gyZ14dlu5esz4Yna9dWY4Bupdu0Ra7GI6TtXdqPYjQetM3qHuHJPdCy9pMjWSYJ1aXu3 RJEHUS+8Y+cJu+27SNrPJ853dDlN/4lYwMCZsHFppzlmfeFZ42cCme2GHrtMhJ1J6ZKL GrjNaiXAgexd1SaOpVMGq7zBPoqHafa7W63RaApTWq0/QMvDX4+KE5cgoHgXVFcvY9ko arRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JLMrfUKmlGGDmWYHnk7ZCXAGeJsLRVrjdj3i8XFCUkM=; b=LU15ll/uVm9UhFnvkeWLXrr9ae+ifQ5mSXPn49PxmhkIoGzG79a1TTjMWORVGliLE+ VJ/qkKn5nhjLq5VVo1AGr/uPMFMtANBlDD27MLvcrY9kHFgabHpdo4IPJwl7rLVeEFLr lcDBtcVaxP59ACE2Rbhw+KpC0YHhW3qoLZ28Ke2aSipvfRkBLZNIvmcinjw/ahjC3u0N lrcIJw1/5SgdlsClddpW0W/xf0k3d8tgv5eWHL5klj+RUo38mL8dJcTPaVOHzf7nDDae RBCNFdcXNzJUxLx8SNbNCqCvn0aBAv4RJmdzxSHbV5krbv9WJ0XK+pMq3zqN6mphtwmt +MDQ== X-Gm-Message-State: AFqh2ko1j8Fr0STTI8CibvwQ3JNt+GjkyEoJ+Swp5K1ZHebTlDFlNfHB Nr9ORnPntetcTZnV9oY8HSWoIQ== X-Google-Smtp-Source: AMrXdXsGPsc4OJU/t1NQdJK4GmcIPv1Y7o5mpehNbv/fNNrQ3c/gKOMp6+JozXH+1a+SCVhmx/wolA== X-Received: by 2002:adf:f107:0:b0:284:5050:5e59 with SMTP id r7-20020adff107000000b0028450505e59mr33484997wro.29.1673421016818; Tue, 10 Jan 2023 23:10:16 -0800 (PST) Message-ID: <92cd2724-6a14-deb1-923c-dad28de5e8c6@linaro.org> Date: Wed, 11 Jan 2023 08:10:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] bulk: Rename TARGET_FMT_plx -> HWADDR_FMT_plx Content-Language: en-US To: BALATON Zoltan Cc: qemu-devel@nongnu.org, Peter Maydell , qemu-block@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org, Richard Henderson , =?UTF-8?Q?Alex_Benn=c3=a9e?= , ale@rev.ng, qemu-riscv@nongnu.org, xen-devel@lists.xenproject.org, Thomas Huth References: <20230110212947.34557-1-philmd@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 10/1/23 23:01, BALATON Zoltan wrote: > On Tue, 10 Jan 2023, Philippe Mathieu-Daudé wrote: >> The 'hwaddr' type is defined in "exec/hwaddr.h" as: >> >>    hwaddr is the type of a physical address >>   (its size can be different from 'target_ulong'). >> >> All definitions use the 'HWADDR_' prefix, except TARGET_FMT_plx: >> >> $ fgrep define include/exec/hwaddr.h >> #define HWADDR_H >> #define HWADDR_BITS 64 >> #define HWADDR_MAX UINT64_MAX >> #define TARGET_FMT_plx "%016" PRIx64 >>         ^^^^^^ >> #define HWADDR_PRId PRId64 >> #define HWADDR_PRIi PRIi64 >> #define HWADDR_PRIo PRIo64 >> #define HWADDR_PRIu PRIu64 >> #define HWADDR_PRIx PRIx64 > > Why are there both TARGET_FMT_plx and HWADDR_PRIx? Why not just use > HWADDR_PRIx instead? Too lazy to specify the 0-digit alignment format I presume? From xen-devel-bounces@lists.xenproject.org Wed Jan 11 07:38:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 07:38:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475096.736614 (Exim 4.92) (envelope-from ) id 1pFVgE-0008Ew-9n; Wed, 11 Jan 2023 07:37:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475096.736614; Wed, 11 Jan 2023 07:37:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFVgE-0008Ep-6f; Wed, 11 Jan 2023 07:37:50 +0000 Received: by outflank-mailman (input) for mailman id 475096; Wed, 11 Jan 2023 07:37:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFVgC-0008Ej-KO for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 07:37:48 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2087.outbound.protection.outlook.com [40.107.6.87]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d763f9af-9182-11ed-91b6-6bf2151ebd3b; Wed, 11 Jan 2023 08:37:46 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU0PR04MB9300.eurprd04.prod.outlook.com (2603:10a6:10:357::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Wed, 11 Jan 2023 07:37:45 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Wed, 11 Jan 2023 07:37:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d763f9af-9182-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ylhaq2dbWYtp2PCsAqbi6EZUATIrgXI3NU9ug2iNoHC01ScMdqf+JG+GmH9b2FXwFSYuWLoNHbTodEFHoy2pZNG63ubP8pfC2nGi9g2U7rGAflQ3WCpfMSRWVxxfDANmEI4eFtnyzYOo1YNlZzpCZWiHPlI9Qt2XGaLfPBtQCGu7iGF9frXU0PHjddpF7A0nrsWo9/A8Z8QHMg3D8XVmUlVf/nLP9nGTTth/WMofU4yZgwYF8Ubs6hSPNaHZO93xR/fpsPUWWizTaohzW4/4Uf/jpjpkTfeI4rO4EFQWh7ynr9GW0NNV2uE/Ic+BfPao00OQ6On9ZNJ9FTPvcwUE0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vhz+97kEQewXrQMY8ev7cqCU+oOfgrtlWTWgYUbkSVk=; b=NYMN3PBk+1+retThxrA3rEPbAmqABTWtctjgGAYXMBKHBiICdnAOf9+5iC35svKuAX8bkpTLRt8lOnXibbGqxqIvIlpVQNrW6Gl32IVpGYi7UnCvH5BhKlLaz1lyzqDefHZYHEeIqlwOiYx9lGh1QlXg2eSfvkIdFrc/9LqbJ4MPupRrmITV1vmsY0cel0lXHFVTQhJF7CLqkGHVZk24p4L84V6F52bh3zhgPcNChxqs/4OCdifUnr9C2hoE0YSjRjwOhGhwZu3478ZU/UPNWcU+32iOo7AhBlDq6ADlPvfZ1BuHfAUPKZGsEs5F+a8PohP1ZpNYx7lyYE0+Et27QA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vhz+97kEQewXrQMY8ev7cqCU+oOfgrtlWTWgYUbkSVk=; b=rLfq79Wmkm5JJWSU/5KAXxtaOuzo6G8J5qbv8K6JYzCKAc0JfsDiTEGk9xID6UoTUQTzQPe0eTnunEcleE6Rr5ovF0Qtbt2vqyc+zFUOuDWM3C9qErj6zebG2gR7Ja3HRitbRFGigB3GAmybA/OlpojMIvxvk6k+e6qsOXdO793Dxpfpw+qPeQLRul72Y9F8nUWilBnJNkNKGgcyXV2ubX415/4VdL+LZ/3gDOhvxjy5IRtfSArSDtUfT/BcrrwtqzrakxQUqB+wzwjJYkbwhLfkYIt7DQtFIQ6sOtm7DgkFEBuzIpV50AGRwkXdje39lNriCfGSjGwnkRqloOwxcQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 11 Jan 2023 08:37:42 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v3 1/6] xen/riscv: introduce dummy asm/init.h Content-Language: en-US To: Oleksii Cc: Andrew Cooper , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org, Julien Grall , Stefano Stabellini , Bertrand Marquis References: <891d0830-7fdc-202a-5f12-2364cae5bce5@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0111.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU0PR04MB9300:EE_ X-MS-Office365-Filtering-Correlation-Id: fd8ea0a5-f7d9-4e9d-15df-08daf3a6ba7f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UkNZtxUzAMOYfa7Q9hxaQ033OhtDFbzkinkzniv1vh3aleUg+v/5h0FcQTPoc1bxQkm7dZgA5fy/gfJpxMwGPcd6qQ2AD9oZGhKYv1nU+ddBH74vp1Wpj8B2YGegecTpaj8iad+SozoW5lguugJcwV5/EzICQTxdL4750fCkHdzp4Q3Dapwkx07V8X3FfEOM85pxezjE0ig1lkDjeimVdQx77fFZxj2afBRpruZ7nz9J9BUo1/OyfzWmK5JtoeD/74I8lSeIxif4GW4TJ8aWBTD87F9RJnPrEu5s4OsuGY94rGWgLZ052ctC8xYlvxlaDjX5HFXt+lYyFBjYWNCEnNYDGeX9AV60c7JiZjXmpse8QTWLW5ztbMtEJh/deIxlrVpRZ0mVguoLlkKlj6vq0tyglChClH7C5dA0IYEsClt563Wam1QHhPFAZ5e6UsSeWZnxCdHFAKRh1uwF5eZbUCSRudIISKz3qfguzW76zPAsbXJ5q6vXLUSHppNXhF8RWT3KQEvFM7L5eC/1Xuggb+fkDCo5N244r/7ZDQZiVGU0iJdamkkm2R7diIjq5K10n2QfmB5rQ0Jt/zDTGWgDVyTgG1Z7pJYVcpfiAWrpnanYb6qKwJTayZhU7KzZU85TVzpAyGZ7u0Xw1GaJU7UMD9YxnJbDAm8wG2XSl8ccwV3XQp3j7Zs6wKVZWqdQi+PhReM0Fl56AsoRE4UitKrUxiG8FqkhRXblWEY6D9JnwVjy1QP3rx9sXlemQeWC1Gzh X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(396003)(366004)(39860400002)(346002)(376002)(451199015)(7416002)(316002)(5660300002)(186003)(6512007)(26005)(6486002)(966005)(478600001)(2616005)(31696002)(41300700001)(6916009)(66556008)(54906003)(66946007)(66476007)(4326008)(8676002)(8936002)(86362001)(36756003)(53546011)(31686004)(6506007)(38100700002)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ck9zSmpmT2VaM1hFRGhlNGRqL1VqZ1RQVUdPalVFS3lJV3QvV2ZLZjFMNWtF?= =?utf-8?B?UHhaOENYY0hNQ0psNXFtN2IyVDdGbm1wNk82d1BkY3F4dWN4K1VlYVpOaFJ5?= =?utf-8?B?SkF5czJwbnEyYk9ta2dTZi9pbFhFdk8rMmwrNFd1aFNHRkFJeGUzUnp3M05l?= =?utf-8?B?T1JUMkk4eXAwVzFkMTBUSGN6Z0lja205VUYwU2EwNlFxYVJuc0s3QURmS2hw?= =?utf-8?B?NmFWWHJ1RlRDNy90cjF1eWQ2RVlDNS9RVE1EeFBTSnJaSk9tWStad3hISXRi?= =?utf-8?B?d0xTRjRNTVhaRW43NEptRW1tU3g2Q24xVVJKOE9GZlZTUXBEK24rZ0M0TElL?= =?utf-8?B?ZTF6UWVaL0ovVVNQZTg0QitFS0t6alQyWHEyN3ByMDBleVNWS1JsRzhaQ1F1?= =?utf-8?B?eGN4RzNBZTJCN1hlY1BIcFdxcVc3QjNhTldvamNoT1hJV21VNEZZdnhQUmt4?= =?utf-8?B?UVhETmhqTTRoT0pXRUlIWWpZc1NvQ2hCYWNuMTYxV0wxUk1KY3BiL2dUWnpB?= =?utf-8?B?Tzh5YVp2RlZJQUYzazRWNlJwNTh5THFCeTArR3FtYzlubkxvdGp6V2VRVTlK?= =?utf-8?B?Tzh5cStMcElwaEFNb0NIckFPT1NuV084bmo5Qm16SUNnckVJRTJMZ3IwMUhw?= =?utf-8?B?cHZGKzRxWG9DdjRRa3NMNTNZRXdPeHFXcWlxQmk0OGc5RnhRVjFoQ3U4UVgv?= =?utf-8?B?akVSMjJnTkMvMlJTVXVWZlczOUFHWUM4eWZ0MjBYbzR2L0tsNHJPTm82NkF5?= =?utf-8?B?WlFsckkvc1VCUmtMYmVDa2czTmtvSzhZM0ZPZGl4dldPeUlpNzVOaU5wWkJC?= =?utf-8?B?eUNRK21ldXRXa0trbmdOV2tQSlAzZFM3NlNSQ3NmOGRCaWdVSnZzVnVJVVNa?= =?utf-8?B?WTZ2OG5zU0MrRGJZZmNURCtZZ21DY21hajVFdXFKTjJ0aFNQWkxWTGZndEtP?= =?utf-8?B?bGZUcW9CS3AvbkRjNFc2ZnNmREVycTFrL1dYdlN3RFpzK1Q3RHI1NGY0U2hN?= =?utf-8?B?STZIOHRobzVVbDUzd0JxdkJUbllhRVk5VW83NzcxQUU3MUwxazRXOW1NcUN4?= =?utf-8?B?V2xjUGJVMys4d2pIYk1BSnlaSHFOSkNvNWNWUVpYWm5TZklVUlhRK2o4WVlR?= =?utf-8?B?ZXRsdVFIOE9Ua2l1VVp5OUxIZ0c5NFY4Tjhzbi9ZUGFZb1lheVpicWs3L3VF?= =?utf-8?B?NXlHRUphVFRybVYweHRYdG1paC9KN0VKOG5icjA1d21VcW1iWmFRYWE5Zklo?= =?utf-8?B?Um9NNEgxaHRDRFpqL1E2L3lrampNckJYU3BLblB5bnhEaW43M1c4azR3NWN3?= =?utf-8?B?Q1kvK3k0VGwyVnBCb0xDVUk4Ymg2VzlkVzF4aU92VERwKzBPcURtZHJRTzRF?= =?utf-8?B?UXNBRVRoa1BQWG9xNm9QbllPVWEzcDhaSXowUjJBa3JtaXU2VEdBQkgwL1RI?= =?utf-8?B?dko0VXJ0ai9rMU9lOEJZa25uNHlvTFRTVTZpcXhBNlZOR053eWoxVE9rbUZq?= =?utf-8?B?anRsVnlhakNBdjlPYzdHdis1NkhiblhTbFVRWmxBMHlJS1QxQmpxclJQTmRu?= =?utf-8?B?UVAzbTBEeTFiYmJsR2RKNGcrU3JZSW83K050RFJ2Umh0MWh2WnFhWWhlWUM0?= =?utf-8?B?d28vRUw0NFZUemdTTjlJc1JjcWlVYy9saGg0ZGRqbEFVSFhxNURvd2FpY1d3?= =?utf-8?B?cmc5VG9xUnRRbXVuNXhuWEUrNUN5SExTMEtMam8yUjNXQ0x5Yy93OTh5TGhu?= =?utf-8?B?cllPU1V3OExqR1NwOHRzeFdBaFNYYWFnbkh4QVVxSmRhclpSeU92bW1EaUZN?= =?utf-8?B?dUZMN2Q5dXp3a3lnQXhYL0lzOWJOTThoS2pLWUdxdHFZZEc2b1V0U05Bb1dp?= =?utf-8?B?WHlKUzhnaEpFVlJVY01KdmdNanpleG5qR1BqdWdZZTd1UnF5aGJwaTFLbFJp?= =?utf-8?B?ajdsNGZBWGtoYXgydWRDUVRMTVVtaEZ1cm5nVlVDa0kwZ2hVbkVjanVXVHdC?= =?utf-8?B?eUZ2V3FNaUpTRHZvWUo4NDhQUUtESnhBYjN0Y1oxWTd6TW1oeU1EWVJGRy9v?= =?utf-8?B?NVBySHFMSFFUemRHQjF2VEZwWjVrQ0F4Q3ZicjZDVFBpazFXKzNXZmFsUGlH?= =?utf-8?Q?eodkwE7lYXeUNTjStxNttCP+W?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: fd8ea0a5-f7d9-4e9d-15df-08daf3a6ba7f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2023 07:37:44.7076 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Wp03pECD6X9qBJpSdaiKGIBMHiYyCaAgqy6McWAlDLYiIhUHSUqmHTl3ATJ3y4UR58tiBSMMTwR1X/rGRUODRg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9300 On 10.01.2023 20:16, Oleksii wrote: > Sorry for breaking into the conversation. That's perfectly fine; no need to be sorry. > On Tue, 2023-01-10 at 18:02 +0100, Jan Beulich wrote: >> Arm maintainers, >> >> On 10.01.2023 16:17, Oleksii Kurochko wrote: >>> --- /dev/null >>> +++ b/xen/arch/riscv/include/asm/init.h >>> @@ -0,0 +1,12 @@ >>> +#ifndef _XEN_ASM_INIT_H >>> +#define _XEN_ASM_INIT_H >>> + >>> +#endif /* _XEN_ASM_INIT_H */ >> >> instead of having RISC-V introduce an empty stub matching what x86 >> has, > Have you had a chance to look at the answer (Re: [PATCH v1 0/8] Basic > early_printk and smoke test implementation) of Andrew: > https://lore.kernel.org/xen-devel/299d913c-8095-ad90-ea3b-d46ef74d4fdc@citrix.com/#t > > I agree with his point regarding the usage of __has_include() to not > produce empty headers stubs for RISCV and for future architectures too. Sure, but as he said, that requires settling on a new toolchain baseline, which is something that we've failed to come to any results for, for a considerable number of years. Plus if we could get rid of this (then optional) arch header altogether, it would imo be even better. Jan From xen-devel-bounces@lists.xenproject.org Wed Jan 11 08:06:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 08:06:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475105.736626 (Exim 4.92) (envelope-from ) id 1pFW7T-0003fy-Oj; Wed, 11 Jan 2023 08:05:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475105.736626; Wed, 11 Jan 2023 08:05:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFW7T-0003fr-M7; Wed, 11 Jan 2023 08:05:59 +0000 Received: by outflank-mailman (input) for mailman id 475105; Wed, 11 Jan 2023 08:05:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFW7T-0003fh-59; Wed, 11 Jan 2023 08:05:59 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFW7T-0000RC-21; Wed, 11 Jan 2023 08:05:59 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFW7S-0004xq-GP; Wed, 11 Jan 2023 08:05:58 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pFW7S-00046v-Fw; Wed, 11 Jan 2023 08:05:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=X1eacXw8d1UxZUYYq/r1IiTafNFNYZ1mN17LVZQv+t0=; b=K78Jit/nn1yO6ck2WvRNvlHgFU h0Faa67/aP5onlSvzPSI6087/OE6R82z2uEIF7JFeTqu3WVLYT3O4j+iUXhhTrxt9d9v/nNx9poCP Ko0NGAH31LfMNFkAXxJ9619ZW3PHAYrElBhi18gGfQvAtBOKbaGDQ0kGx3qJhOuQTQa4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 175714: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=4d975798e11579fdf405b348543061129e01b0fb X-Osstest-Versions-That: xen=692d04a9ca429ca574d859fa8f43578e03b9f8b3 From: osstest service owner Date: Wed, 11 Jan 2023 08:05:58 +0000 flight 175714 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/175714/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 175694 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 175694 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175694 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175694 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 175694 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175694 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 175694 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 175694 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 175694 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 175694 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175694 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 175694 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen 4d975798e11579fdf405b348543061129e01b0fb baseline version: xen 692d04a9ca429ca574d859fa8f43578e03b9f8b3 Last test of basis 175694 2023-01-10 09:33:52 Z 0 days Testing same since 175714 2023-01-11 01:39:16 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Julien Grall jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 692d04a9ca..4d975798e1 4d975798e11579fdf405b348543061129e01b0fb -> master From xen-devel-bounces@lists.xenproject.org Wed Jan 11 08:44:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 08:44:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475116.736644 (Exim 4.92) (envelope-from ) id 1pFWiB-000801-SV; Wed, 11 Jan 2023 08:43:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475116.736644; Wed, 11 Jan 2023 08:43:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFWiB-0007zu-Pn; Wed, 11 Jan 2023 08:43:55 +0000 Received: by outflank-mailman (input) for mailman id 475116; Wed, 11 Jan 2023 08:43:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFWiB-0007zo-5E for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 08:43:55 +0000 Received: from sonic309-13.consmr.mail.bf2.yahoo.com (sonic309-13.consmr.mail.bf2.yahoo.com [74.6.129.123]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 10683819-918c-11ed-b8d0-410ff93cb8f0; Wed, 11 Jan 2023 09:43:50 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic309.consmr.mail.bf2.yahoo.com with HTTP; Wed, 11 Jan 2023 08:43:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 10683819-918c-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1673426629; bh=VoekXF/Cd5va2LLTczOOjyYZgThCQF3kMuFP7XQ81TQ=; h=Date:From:To:In-Reply-To:References:Subject:From:Subject:Reply-To; b=G9z4wLQrRMYIWI5UaKX9/g/77+ubmKhYHJD4NlHQFz1SX2B3MeM7wndtbkwlp+7WH62K0Y9zfGICOYexCe/V9e6DNFiijTuzrCOI3b8nvLLjfYqId9d71kuj1SbU85KNWHXiGy9obj5KL5LGrEoTsiApHpZ94vgeQ3EyVlAc8zVmVyfRChqmHpgCtblCDRByecUql4zhnOLgmXdDxDelRFBHKlAk6TKPxUXl9mqLGpOY4x6e8T00zbp8VUcBGygT3mK5+vzeV6Dj2iu403m3zAArbi5qhVjfYJp5UGtatFLFc/3WQPgm3wHv7kYQftAxocbdfgy35ZGUCRH8U5I8sg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1673426629; bh=CJ4lJtf1Bl/l8OtddRDgBx6qzxht4WP6MLLJKMmo+1Q=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=Lt5Vf4ZqlEonPCn4KKe2lr4Lv7UTL8VIfJ9Y3VaAc0qDtNO8OR8NJfrHwih0H17W4l/I6+anIRh9FdPtG/zsWZNY2bx5CokF8R4IaDHJ8t9YSOgLrI0m6iA5gh3jTx5/FjPZxLR/3Com0Mb9KLANH1cLptROKplQv4WGrWDcC6IWYVnsiv+r70wEsTmL8c60kd7+GZW4Kd7LLFNNBoxB3kLPdYN5MPMG4nwn8O33qGNNKhketlh9YVyvVRPe9zKDvWNj2dh6i47EDIbPsboD3y/UyCV4rHZdh8eBa08x/A5MGJ1cOWNPS+SZ+ex06GYWr4rFxu8q1PVtX1TMKdM86Q== X-YMail-OSG: MJRqsm4VM1luKBx.fvru._khTqXq9mlDA4F16VP_rcGUUzLETySH9suTbj5v7vt 1d4Et18vYapNYZ9JhTQzNTwYanJ2bP3oZigByZc8LNnqF87rsYiHxYPR2HKymGfMKfTlJcK2xuOP jtNfd7ERajSgQIxEIha4SbU4eETTp59PBcBs3c1x_oVMRS5k.qcpREUf7IQ8K0c0Cbwz8jyAGhZl AyfC1gk5k6wY4Qjsr6S69Bj86kr4.IDBN0U_WkSazTnTX_d2WvsNhsylZmiJ_XNRLi4cO3uwF5BR cznuuRB3G0pFWEG7R0IxkVjJQT4QSrd6UIR9.0KzJmkKzx5fr7z51j7lTeuoyQdaqY1IdoewU01X D16WE8Tlz.gbDLk2NNAAHyhUA60c41qqEDyHNjTa6yi4NqeU9eCPT_Sr2tdy2CApHhX3ISs9Esq2 j_xWdI5pOBGc_R3m870wIVpKgMB7m0YZs9XWJDS6N._sHjwFX_5pp72nKf82p1Wo6l0YOSrNR4Jg Mgtqsd0mVWfBNvORy0vJFIC68dW22KpqvNAFYQUdo0eVyq8COzeOT3sf44y.qexKYgSdi0kQXDgt 1wciSueAmGUg8KG8Uko9gVsf_bRtayO3ic6EQ_xv1T1qiOIh71lLfN7fQHBleOo1HOQYfAc2JyH2 qvDGsw9GT_Hi9dnv6gO6MJV_80qwM0dXaQrPlbxWj1MmLVfYRrSMhBXhp3t.YOeq3X0_dcW0k0kF cLlPmSHLAEPnu4i.ZeEw7UnINGPqeIwG02s7O9Qr2FT42DyfmC2j2zKR1FHePmFmcB7rOixCnf2X ETeuhvcXzDJ9RGCiZSiMnqbiy_OzXRluLfBbT4PfCT3Z3EujbLx.4rp.iRk_5UhmzCkJbnq44dLr ET2hY7SVv5PoSENyw5O.tgznUu_WXM7F2ShLxi.kurNHomWy2W7k0LIaHXu8uW_Tx1zwhaGAh370 OJHNNAGLrJRoouZ7vMM4NGU14JBTju.jspj4BKeE0WJ.qGXjyB49mp2i_TG8HBA_6qVDwletph6j LBqEFRoHKo7fdQdYPgyC0vX.1o44od1h_N.SdO5vXcF7dd3w1B6uEfuX1XwyMMFkLZTvUbgdw76q .ZbrLjOsr.f8kPiCTNyoAm7o7ZKWjaXTKH7MBfeGSiLiSmXC51Ygu90a2Ah1oea4suaWF6o4.PA6 EnHCZ2iCfzGls9vLf7u7zGZnzB6u2f5NzDYaiclVK6OmG_JmtxYhmub1Em1zbZw1E_9J7ekEG0K. jHJkRC_QoO9XRemsCAFdtpe5VQWNBCKSXBNq08B2gi.kaMBIElJm8NocBXC_0aLd42tOUSWhVyRP UUBuyO7ADNgtMzapYYd1FZJgMqALNidRhRMPWfBY5KVyIbTppfMh3cIFxrqpPgs4d230KsmxYI47 vZXKEo0f.HzUKdM0oX68aavIg01Y5RfePwzTL0dSvvKpaMGvKUltVd3kJnPBB82..puDS22NjfQh MshCmUWIuGcyk.8SybsP37nViBjrzTMuTH6.VOaHBTiFTJguh8FIcKmvlXSF1rP8O42vYOIbPxMJ oBSwnV1vVUQAozHhQZWrd5JRopou9g4fHi8wF9384BNEHX.OE5kQ.Ey2yBO8gEz6YGltLIda5ewp wpmV5ghTdt7iTVuDyM67V34d16s31wC0cpy6AJMr4._UsRO9N11DutXm1iIKm01CXqNZ4l4eV7YT wqcjDXXafDogA3iwaVX2_aMq29z1ZY5rVH3J7yOLplfQa_vjK3zvADeRcnIBpu.uRzJ2lPMH0lYT .Q08hRTn4OHYOdC_DVDVqIcHYoYL4fpcz9Ze67nxYxeb0GKho9wtJ7YxkVKoWZ6Lcn9Tpr1Alne6 ekm5K6cQfZTsJ9pb_6zdwDikhVO6YIaIJL8FR8chw1Y4yaJxcqiJHHk6xCVViGDUPyDPfsgmqqlv Ot_AFzN83EyGo9MU9WJktgBWxB1YJSt3TmlyGO7UHthErFMVFCYRgrtrOJ.ud.7mS1wdF.8XoLIg nz2z8t3dbwZlJt0O_Gb2CbwsS5pZcKmwXZPhox1mZG_qdf2bcihxhK6944omvzbvp08QaVXW38b9 .NPX67fgjYei_Id93etsKXWhdJs0jDD0MPcwbljBp6MmJSE.RSHTD872babfDUQwdcseCx5IRo4w YFsQr.miaW9Hz2dCaQMb2Ibc0vX9XwdNFe0lGMZmjdCD7OFceknlI62Frv6kp7Q_k.lRi2tjp370 VEfJwHww0b2bJHHQ_ZMPFC6y8CJA- X-Sonic-MF: Date: Wed, 11 Jan 2023 08:43:48 +0000 (UTC) From: Jason Long To: Xen-devel Message-ID: <437182837.4659385.1673426628212@mail.yahoo.com> In-Reply-To: <741943497.1243882.1671532529734@mail.yahoo.com> References: <741943497.1243882.1671532529734.ref@mail.yahoo.com> <741943497.1243882.1671532529734@mail.yahoo.com> Subject: Re: No package 'pixman-1' found MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.20982 YMailNorrin Content-Length: 4205 Hello, I installed the=C2=A0pixman package, but Xen can't find it. On Tuesday, December 20, 2022 at 02:05:48 PM GMT+3:30, Jason Long wrote:=20 Hello, How to solve the pixman error: $ sudo ./configure checking build system type... x86_64-pc-solaris2.11 checking host system type... x86_64-pc-solaris2.11 Will build the following subsystems: =C2=A0=C2=A0xen =C2=A0=C2=A0tools =C2=A0=C2=A0stubdom =C2=A0=C2=A0docs configure: creating ./config.status config.status: creating config/Toplevel.mk config.status: creating config/Paths.mk =3D=3D=3D configuring in tools (/home/Hypervisor/xen-4.16.2/tools) configure: running /bin/sh ./configure --disable-option-checking '--prefix= =3D/usr/local'=C2=A0=C2=A0--cache-file=3D/dev/null --srcdir=3D. checking build system type... x86_64-pc-solaris2.11 checking host system type... x86_64-pc-solaris2.11 checking for gcc... gcc checking whether the C compiler works... yes checking for C compiler default output file name... a.out checking for suffix of executables... checking whether we are cross compiling... no checking for suffix of object files... o checking whether we are using the GNU C compiler... yes checking whether gcc accepts -g... yes checking for gcc option to accept ISO C89... none needed checking for special C compiler options needed for large files... no checking for _FILE_OFFSET_BITS value needed for large files... no checking for gcc... (cached) gcc checking whether we are using the GNU C compiler... (cached) yes checking whether gcc accepts -g... (cached) yes checking for gcc option to accept ISO C89... (cached) none needed checking whether make sets $(MAKE)... yes checking for a BSD-compatible install... /usr/bin/install -c checking for flex... /usr/bin/flex checking for abi-dumper... no checking for perl... /usr/bin/perl checking for awk... /usr/bin/awk checking for ocamlc... no checking for ocaml... no checking for ocamldep... no checking for ocamlmktop... no checking for ocamlmklib... no checking for ocamldoc... no checking for ocamlbuild... no checking for ocamlfind... no checking for gawk... /usr/bin/awk checking for go... no checking for checkpolicy... no checking for bash... /usr/bin/bash checking for python3... python3 checking for python3... /usr/bin/python3 checking for python3... /usr/bin/python3 checking for python version >=3D 2.6 ... yes checking how to run the C preprocessor... gcc -E checking for grep that handles long lines and -e... /usr/bin/ggrep checking for egrep... /usr/bin/ggrep -E checking for ANSI C header files... yes checking for sys/types.h... yes checking for sys/stat.h... yes checking for stdlib.h... yes checking for string.h... yes checking for memory.h... yes checking for strings.h... yes checking for inttypes.h... yes checking for stdint.h... yes checking for unistd.h... yes checking for python3-config... /usr/bin/python3-config checking Python.h usability... yes checking Python.h presence... yes checking for Python.h... yes checking for PyArg_ParseTuple... yes checking whether Python setup.py brokenly enables -D_FORTIFY_SOURCE... no checking for iasl... /usr/sbin/iasl checking uuid/uuid.h usability... yes checking uuid/uuid.h presence... yes checking for uuid/uuid.h... yes checking for uuid_clear in -luuid... yes checking uuid.h usability... no checking uuid.h presence... no checking for uuid.h... no checking curses.h usability... yes checking curses.h presence... yes checking for curses.h... yes checking for clear in -lcurses... yes checking ncurses.h usability... no checking ncurses.h presence... no checking for ncurses.h... no checking for pkg-config... /usr/bin/pkg-config checking pkg-config is at least version 0.9.0... yes checking for glib... yes checking for pixman... no configure: error: Package requirements (pixman-1 >=3D 0.21.8) were not met: No package 'pixman-1' found Consider adjusting the PKG_CONFIG_PATH environment variable if you installed software in a non-standard prefix. Alternatively, you may set the environment variables pixman_CFLAGS and pixman_LIBS to avoid the need to call pkg-config. See the pkg-config man page for more details. configure: error: ./configure failed for tools Thank you. From xen-devel-bounces@lists.xenproject.org Wed Jan 11 08:48:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 08:48:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475122.736656 (Exim 4.92) (envelope-from ) id 1pFWmE-000090-CZ; Wed, 11 Jan 2023 08:48:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475122.736656; Wed, 11 Jan 2023 08:48:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFWmE-00008t-9M; Wed, 11 Jan 2023 08:48:06 +0000 Received: by outflank-mailman (input) for mailman id 475122; Wed, 11 Jan 2023 08:48:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFWmC-00008n-MY for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 08:48:04 +0000 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [2a00:1450:4864:20::130]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a6c86103-918c-11ed-b8d0-410ff93cb8f0; Wed, 11 Jan 2023 09:47:59 +0100 (CET) Received: by mail-lf1-x130.google.com with SMTP id bf43so22462350lfb.6 for ; Wed, 11 Jan 2023 00:48:02 -0800 (PST) Received: from [192.168.0.145] ([195.234.76.149]) by smtp.gmail.com with ESMTPSA id v15-20020a056512348f00b004abc977ad7fsm2618553lfr.294.2023.01.11.00.48.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jan 2023 00:48:01 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a6c86103-918c-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=8y917LEB/E4gPgzcqGY64IPhYuqoMULpvWHngFQzRlY=; b=BhVKKn+O+uKX22E5J26BMzjcOBHqhEzPlMpmecjC6R0s2MyXuFVUXHvXgqg9qjTa0L pHoQOWNlpRX8g4iS3gcTPTdzgh7/HysbqbRnAaKWGriyHjHfV63QIODM6PW/X+/fhAZs OFHzAfsGzgLvIsdoYXnC4O/jR1a1HpiL3ojVK1eQvbMmVFEW1goJydpNgpinqdMYsURM SbjefM9UKh5KTLP9k7oF7h/Ckrn4YZD9c3uBrKNPv8eDsNyuEEa86aAi6mqGBOLQrD36 7WgLwZNRCm/FMsuNpXDMtcEiDuQsgR3FOxtJIwHX5BMhPz/LYPeHHulFbG0cOq3TpYUa cz4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=8y917LEB/E4gPgzcqGY64IPhYuqoMULpvWHngFQzRlY=; b=STTzyJSbXJk+ydwNWfulpZ7GiUc07NiX2HPnnw+2ixmOcThQqHsw80SnHfd6KulDg2 8gMg+DFBsQc3QQCt2ZA4vCXkMhhDSHj+b8MqfUjKF7UZLLVDkmH/Bcy8G4Aek3IoohZv hmKTci+Oc4NOZOyPIQaYlNH5SCCrZ73P6nG4C9wLU03QPzx+FVwO4KghSHqDRO2H3FE5 EFt6tDivgLspmPnBLEyE8E2gN/75zLVoipsUqkEEwEgFt9MSJom+pcjwg3hcAaDDWCpE t1nxEqHZTZfBr1yfGxEuDtOjSvmT28zNCBMAr6Vba6xDLc81SuSmNxwvJsBi75oO/VuG YoNw== X-Gm-Message-State: AFqh2kqJGP7rwzKIAAwATaxaU5Um33gNAuwvzPcNiraOoq1lIlOd0J0x KUEXJa8ZOcFMbUu5TnyPQwo= X-Google-Smtp-Source: AMrXdXsv7jz+fVYF8AXY6KBGKv2KGgu/sAbV+BAjZP+C9tp0SHMCoFBt97GyczbGnJPSQkLCzlTyaA== X-Received: by 2002:ac2:5604:0:b0:4a4:68b8:c2b6 with SMTP id v4-20020ac25604000000b004a468b8c2b6mr17246519lfd.13.1673426881740; Wed, 11 Jan 2023 00:48:01 -0800 (PST) Message-ID: <06185fcfb8cbd849df4b033efa923b55c054738d.camel@gmail.com> Subject: Re: [PATCH v3 2/6] xen/riscv: introduce asm/types.h header file From: Oleksii To: Jan Beulich Cc: Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org Date: Wed, 11 Jan 2023 10:47:59 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 On Tue, 2023-01-10 at 17:58 +0100, Jan Beulich wrote: > On 10.01.2023 16:17, Oleksii Kurochko wrote: > > Signed-off-by: Oleksii Kurochko > > --- > > Changes in V3: > > =C2=A0=C2=A0=C2=A0 - Nothing changed > > --- > > Changes in V2: > > =C2=A0=C2=A0=C2=A0 - Remove unneeded now types from >=20 > I guess you went a little too far: Types used in common code, even if > you It looks then I didn't understand which one of types are needed. In "[PATCH v1 2/8] xen/riscv: introduce asm/types.h header file" all types were introduced as most of them are used in : __{u|s}{8|16|32|64}. Thereby it looks like the following types in should be present from the start: typedef __signed__ char __s8; typedef unsigned char __u8; typedef __signed__ short __s16; typedef unsigned short __u16; typedef __signed__ int __s32; typedef unsigned int __u32; #if defined(__GNUC__) && !defined(__STRICT_ANSI__) #if defined(CONFIG_RISCV_32) typedef __signed__ long long __s64; typedef unsigned long long __u64; #elif defined (CONFIG_RISCV_64) typedef __signed__ long __s64; typedef unsigned long __u64; #endif #endif Then it turns out that there is no any sense in: typedef signed char s8; typedef unsigned char u8; typedef signed short s16; typedef unsigned short u16; typedef signed int s32; typedef unsigned int u32; typedef signed long long s64; typedef unsigned long long u64; OR typedef signed long s64; typedef unsigned long u64; As I understand instead of them should be used: {u|s}int_t. All other types such as {v,p}addr_t, register_t and definitions PRIvaddr, INVALID_PADDR, PRIpaadr, PRIregister should be present in from the start. Am I right? > do not build that yet, will want declaring right away imo. Of course > I > should finally try and get rid of at least some of the being-phased- > out > ones (s8 and s16 look to be relatively low hanging fruit, for > example, > and of these only s16 looks to be used in common code) ... >=20 > Jan ~Oleksii From xen-devel-bounces@lists.xenproject.org Wed Jan 11 08:59:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 08:59:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475130.736667 (Exim 4.92) (envelope-from ) id 1pFWxS-0001g2-GQ; Wed, 11 Jan 2023 08:59:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475130.736667; Wed, 11 Jan 2023 08:59:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFWxS-0001fv-Dh; Wed, 11 Jan 2023 08:59:42 +0000 Received: by outflank-mailman (input) for mailman id 475130; Wed, 11 Jan 2023 08:59:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFWxQ-0001fp-LZ for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 08:59:40 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4761c808-918e-11ed-91b6-6bf2151ebd3b; Wed, 11 Jan 2023 09:59:38 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id EBDD017046; Wed, 11 Jan 2023 08:59:37 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C781613591; Wed, 11 Jan 2023 08:59:37 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id kJA7L3l6vmN3VQAAMHmgww (envelope-from ); Wed, 11 Jan 2023 08:59:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4761c808-918e-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1673427577; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=f7vdUTLFJK7nC/ySdUbLnopzsNLUzSvsor32P4sJj0A=; b=ADksBRVKrLmEF7t/c/AorY7+23HbU4QgiYWVwL2zFhRvV0OHGZ0y60CcmwVGWyBN0E0Kej q7Zeknw4Itd+8bmZCQ5W5lTlJCNV1t1d0gx52FrDm7/KgYN3FNG3//L6ubsTWvX1s2ewem nmgurm/w18MoFkOi/sUkW73LwfA3ykg= Message-ID: <05871696-1638-82d0-8d55-9088b4bb9a18@suse.com> Date: Wed, 11 Jan 2023 09:59:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20221213160045.28170-1-jgross@suse.com> <20221213160045.28170-11-jgross@suse.com> From: Juergen Gross Subject: Re: [PATCH v2 10/19] tools/xenstore: change per-domain node accounting interface In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------KS7AxDwQIZ4uNKtSJykthUro" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------KS7AxDwQIZ4uNKtSJykthUro Content-Type: multipart/mixed; boundary="------------ijqjNbtAm927E2rgdiy43jO6"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD Message-ID: <05871696-1638-82d0-8d55-9088b4bb9a18@suse.com> Subject: Re: [PATCH v2 10/19] tools/xenstore: change per-domain node accounting interface References: <20221213160045.28170-1-jgross@suse.com> <20221213160045.28170-11-jgross@suse.com> In-Reply-To: --------------ijqjNbtAm927E2rgdiy43jO6 Content-Type: multipart/mixed; boundary="------------dZLLH6SYO5JkkPHB2rrxCE6s" --------------dZLLH6SYO5JkkPHB2rrxCE6s Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjAuMTIuMjIgMjE6MTUsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGksDQo+IA0KPiBP biAxMy8xMi8yMDIyIDE2OjAwLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gUmV3b3JrIHRo ZSBpbnRlcmZhY2UgYW5kIHRoZSBpbnRlcm5hbHMgb2YgdGhlIHBlci1kb21haW4gbm9kZQ0K Pj4gYWNjb3VudGluZzoNCj4+DQo+PiAtIHJlbmFtZSB0aGUgZnVuY3Rpb25zIHRvIGRvbWFp bl9uYmVudHJ5XyooKSBpbiBvcmRlciB0byBiZXR0ZXIgbWF0Y2gNCj4+IMKgwqAgdGhlIHJl bGF0ZWQgY291bnRlciBuYW1lDQo+Pg0KPj4gLSBzd2l0Y2ggZnJvbSBub2RlIHBvaW50ZXIg dG8gZG9taWQgYXMgaW50ZXJmYWNlLCBhcyBhbGwgbm9kZXMgaGF2ZSB0aGUNCj4+IMKgwqAg b3duZXIgZmlsbGVkIGluDQo+IA0KPiBUaGUgZG93bnNpZGUgaXMgbm93IHlvdSBoYXZlIG1h eSBwbGFjZSBvcGVuLWNvZGluZyAiLi4uLT5wZXJtcy0+cFswXS5pZCIuIElITU8gDQo+IHRo aXMgaXMgbWFraW5nIHRoZSBjb2RlIG1vcmUgY29tcGxpY2F0ZWQuIFNvIGNhbiB5b3UgaW50 cm9kdWNlIGEgZmV3IHdyYXBwZXJzIA0KPiB0aGF0IHdvdWxkIHRha2UgYSBub2RlIGFuZCB0 aGVuIGNvbnZlcnQgdG8gdGhlIG93bmVyPw0KDQpPa2F5Lg0KDQo+IA0KPj4NCj4+IC0gdXNl IGEgY29tbW9uIGludGVybmFsIGZ1bmN0aW9uIGZvciBhZGRpbmcgYSB2YWx1ZSB0byB0aGUg Y291bnRlcg0KPj4NCj4+IEZvciB0aGUgdHJhbnNhY3Rpb24gY2FzZSBhZGQgYSBoZWxwZXIg ZnVuY3Rpb24gdG8gZ2V0IHRoZSBsaXN0IGhlYWQNCj4+IG9mIHRoZSBwZXItdHJhbnNhY3Rp b24gY2hhbmdlZCBkb21haW5zLCBlbmFibGluZyB0byBlbGltaW5hdGUgdGhlDQo+PiB0cmFu c2FjdGlvbl9lbnRyeV8qKCkgZnVuY3Rpb25zLg0KPj4NCj4+IFNpZ25lZC1vZmYtYnk6IEp1 ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4NCj4+IC0tLQ0KPj4gwqAgdG9vbHMveGVu c3RvcmUveGVuc3RvcmVkX2NvcmUuY8KgwqDCoMKgwqDCoMKgIHzCoCAyMiArKy0tLQ0KPj4g wqAgdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5jwqDCoMKgwqDCoCB8IDEyMiAr KysrKysrKysrKy0tLS0tLS0tLS0tLS0tDQo+PiDCoCB0b29scy94ZW5zdG9yZS94ZW5zdG9y ZWRfZG9tYWluLmjCoMKgwqDCoMKgIHzCoCAxMCArLQ0KPj4gwqAgdG9vbHMveGVuc3RvcmUv eGVuc3RvcmVkX3RyYW5zYWN0aW9uLmMgfMKgIDE1ICstLQ0KPj4gwqAgdG9vbHMveGVuc3Rv cmUveGVuc3RvcmVkX3RyYW5zYWN0aW9uLmggfMKgwqAgNyArLQ0KPj4gwqAgNSBmaWxlcyBj aGFuZ2VkLCA3MiBpbnNlcnRpb25zKCspLCAxMDQgZGVsZXRpb25zKC0pDQo+Pg0KPj4gZGlm ZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMgYi90b29scy94ZW5z dG9yZS94ZW5zdG9yZWRfY29yZS5jDQo+PiBpbmRleCBmOTY3MTRlMWI4Li42MTU2OWNlY2Ji IDEwMDY0NA0KPj4gLS0tIGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYw0KPj4g KysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYw0KPj4gQEAgLTE0NTksNyAr MTQ1OSw3IEBAIHN0YXRpYyB2b2lkIGRlc3Ryb3lfbm9kZV9ybShzdHJ1Y3QgY29ubmVjdGlv biAqY29ubiwgDQo+PiBzdHJ1Y3Qgbm9kZSAqbm9kZSkNCj4+IMKgIHN0YXRpYyBpbnQgZGVz dHJveV9ub2RlKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBzdHJ1Y3Qgbm9kZSAqbm9kZSkN Cj4+IMKgIHsNCj4+IMKgwqDCoMKgwqAgZGVzdHJveV9ub2RlX3JtKGNvbm4sIG5vZGUpOw0K Pj4gLcKgwqDCoCBkb21haW5fZW50cnlfZGVjKGNvbm4sIG5vZGUpOw0KPj4gK8KgwqDCoCBk b21haW5fbmJlbnRyeV9kZWMoY29ubiwgbm9kZS0+cGVybXMucFswXS5pZCk7DQo+PiDCoMKg wqDCoMKgIC8qDQo+PiDCoMKgwqDCoMKgwqAgKiBJdCBpcyBub3QgcG9zc2libGUgdG8gZWFz aWx5IHJldmVydCB0aGUgY2hhbmdlcyBpbiBhIHRyYW5zYWN0aW9uLg0KPj4gQEAgLTE0OTgs NyArMTQ5OCw3IEBAIHN0YXRpYyBzdHJ1Y3Qgbm9kZSAqY3JlYXRlX25vZGUoc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4sIA0KPj4gY29uc3Qgdm9pZCAqY3R4LA0KPj4gwqDCoMKgwqDCoCBm b3IgKGkgPSBub2RlOyBpOyBpID0gaS0+cGFyZW50KSB7DQo+PiDCoMKgwqDCoMKgwqDCoMKg wqAgLyogaS0+cGFyZW50IGlzIHNldCBmb3IgZWFjaCBuZXcgbm9kZSwgc28gY2hlY2sgcXVv dGEuICovDQo+PiDCoMKgwqDCoMKgwqDCoMKgwqAgaWYgKGktPnBhcmVudCAmJg0KPj4gLcKg wqDCoMKgwqDCoMKgwqDCoMKgwqAgZG9tYWluX2VudHJ5KGNvbm4pID49IHF1b3RhX25iX2Vu dHJ5X3Blcl9kb21haW4pIHsNCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGRvbWFpbl9u YmVudHJ5KGNvbm4pID49IHF1b3RhX25iX2VudHJ5X3Blcl9kb21haW4pIHsNCj4+IMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJldCA9IEVOT1NQQzsNCj4+IMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgIGdvdG8gZXJyOw0KPj4gwqDCoMKgwqDCoMKgwqDCoMKgIH0NCj4+IEBA IC0xNTA5LDcgKzE1MDksNyBAQCBzdGF0aWMgc3RydWN0IG5vZGUgKmNyZWF0ZV9ub2RlKHN0 cnVjdCBjb25uZWN0aW9uICpjb25uLCANCj4+IGNvbnN0IHZvaWQgKmN0eCwNCj4+IMKgwqDC oMKgwqDCoMKgwqDCoCAvKiBBY2NvdW50IGZvciBuZXcgbm9kZSAqLw0KPj4gwqDCoMKgwqDC oMKgwqDCoMKgIGlmIChpLT5wYXJlbnQpIHsNCj4+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKg IGlmIChkb21haW5fZW50cnlfaW5jKGNvbm4sIGkpKSB7DQo+PiArwqDCoMKgwqDCoMKgwqDC oMKgwqDCoCBpZiAoZG9tYWluX25iZW50cnlfaW5jKGNvbm4sIGktPnBlcm1zLnBbMF0uaWQp KSB7DQo+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGRlc3Ryb3lfbm9k ZV9ybShjb25uLCBpKTsNCj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg cmV0dXJuIE5VTEw7DQo+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB9DQo+PiBAQCAt MTY2Miw3ICsxNjYyLDcgQEAgc3RhdGljIGludCBkZWxub2RlX3N1Yihjb25zdCB2b2lkICpj dHgsIHN0cnVjdCANCj4+IGNvbm5lY3Rpb24gKmNvbm4sDQo+PiDCoMKgwqDCoMKgIHdhdGNo X2V4YWN0ID0gc3RyY21wKHJvb3QsIG5vZGUtPm5hbWUpOw0KPj4gwqDCoMKgwqDCoCBmaXJl X3dhdGNoZXMoY29ubiwgY3R4LCBub2RlLT5uYW1lLCBub2RlLCB3YXRjaF9leGFjdCwgTlVM TCk7DQo+PiAtwqDCoMKgIGRvbWFpbl9lbnRyeV9kZWMoY29ubiwgbm9kZSk7DQo+PiArwqDC oMKgIGRvbWFpbl9uYmVudHJ5X2RlYyhjb25uLCBub2RlLT5wZXJtcy5wWzBdLmlkKTsNCj4+ IMKgwqDCoMKgwqAgcmV0dXJuIFdBTEtfVFJFRV9STV9DSElMREVOVFJZOw0KPj4gwqAgfQ0K Pj4gQEAgLTE4MDIsMjUgKzE4MDIsMjUgQEAgc3RhdGljIGludCBkb19zZXRfcGVybXMoY29u c3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgDQo+PiBjb25uZWN0aW9uICpjb25uLA0KPj4gwqDCoMKg wqDCoMKgwqDCoMKgIHJldHVybiBFUEVSTTsNCj4+IMKgwqDCoMKgwqAgb2xkX3Blcm1zID0g bm9kZS0+cGVybXM7DQo+PiAtwqDCoMKgIGRvbWFpbl9lbnRyeV9kZWMoY29ubiwgbm9kZSk7 DQo+PiArwqDCoMKgIGRvbWFpbl9uYmVudHJ5X2RlYyhjb25uLCBub2RlLT5wZXJtcy5wWzBd LmlkKTsNCj4+IMKgwqDCoMKgwqAgbm9kZS0+cGVybXMgPSBwZXJtczsNCj4+IC3CoMKgwqAg aWYgKGRvbWFpbl9lbnRyeV9pbmMoY29ubiwgbm9kZSkpIHsNCj4+ICvCoMKgwqAgaWYgKGRv bWFpbl9uYmVudHJ5X2luYyhjb25uLCBub2RlLT5wZXJtcy5wWzBdLmlkKSkgew0KPj4gwqDC oMKgwqDCoMKgwqDCoMKgIG5vZGUtPnBlcm1zID0gb2xkX3Blcm1zOw0KPj4gwqDCoMKgwqDC oMKgwqDCoMKgIC8qDQo+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoCAqIFRoaXMgc2hvdWxkIG5l dmVyIGZhaWwgYmVjYXVzZSB3ZSBoYWQgYSByZWZlcmVuY2Ugb24gdGhlDQo+PiDCoMKgwqDC oMKgwqDCoMKgwqDCoCAqIGRvbWFpbiBiZWZvcmUgYW5kIFhlbnN0b3JlZCBpcyBzaW5nbGUt dGhyZWFkZWQuDQo+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoCAqLw0KPj4gLcKgwqDCoMKgwqDC oMKgIGRvbWFpbl9lbnRyeV9pbmMoY29ubiwgbm9kZSk7DQo+PiArwqDCoMKgwqDCoMKgwqAg ZG9tYWluX25iZW50cnlfaW5jKGNvbm4sIG5vZGUtPnBlcm1zLnBbMF0uaWQpOw0KPj4gwqDC oMKgwqDCoMKgwqDCoMKgIHJldHVybiBFTk9NRU07DQo+PiDCoMKgwqDCoMKgIH0NCj4+IMKg wqDCoMKgwqAgaWYgKHdyaXRlX25vZGUoY29ubiwgbm9kZSwgZmFsc2UpKSB7DQo+PiDCoMKg wqDCoMKgwqDCoMKgwqAgaW50IHNhdmVkX2Vycm5vID0gZXJybm87DQo+PiAtwqDCoMKgwqDC oMKgwqAgZG9tYWluX2VudHJ5X2RlYyhjb25uLCBub2RlKTsNCj4+ICvCoMKgwqDCoMKgwqDC oCBkb21haW5fbmJlbnRyeV9kZWMoY29ubiwgbm9kZS0+cGVybXMucFswXS5pZCk7DQo+PiDC oMKgwqDCoMKgwqDCoMKgwqAgbm9kZS0+cGVybXMgPSBvbGRfcGVybXM7DQo+PiDCoMKgwqDC oMKgwqDCoMKgwqAgLyogTm8gZmFpbHVyZSBwb3NzaWJsZSBhcyBhYm92ZS4gKi8NCj4+IC3C oMKgwqDCoMKgwqDCoCBkb21haW5fZW50cnlfaW5jKGNvbm4sIG5vZGUpOw0KPj4gK8KgwqDC oMKgwqDCoMKgIGRvbWFpbl9uYmVudHJ5X2luYyhjb25uLCBub2RlLT5wZXJtcy5wWzBdLmlk KTsNCj4+IMKgwqDCoMKgwqDCoMKgwqDCoCBlcnJubyA9IHNhdmVkX2Vycm5vOw0KPj4gwqDC oMKgwqDCoMKgwqDCoMKgIHJldHVybiBlcnJubzsNCj4+IEBAIC0yMzkyLDcgKzIzOTIsNyBA QCB2b2lkIHNldHVwX3N0cnVjdHVyZShib29sIGxpdmVfdXBkYXRlKQ0KPj4gwqDCoMKgwqDC oMKgwqDCoMKgIG1hbnVhbF9ub2RlKCIvdG9vbC94ZW5zdG9yZWQiLCBOVUxMKTsNCj4+IMKg wqDCoMKgwqDCoMKgwqDCoCBtYW51YWxfbm9kZSgiQHJlbGVhc2VEb21haW4iLCBOVUxMKTsN Cj4+IMKgwqDCoMKgwqDCoMKgwqDCoCBtYW51YWxfbm9kZSgiQGludHJvZHVjZURvbWFpbiIs IE5VTEwpOw0KPj4gLcKgwqDCoMKgwqDCoMKgIGRvbWFpbl9lbnRyeV9maXgoZG9tMF9kb21p ZCwgNSwgdHJ1ZSk7DQo+PiArwqDCoMKgwqDCoMKgwqAgZG9tYWluX25iZW50cnlfZml4KGRv bTBfZG9taWQsIDUsIHRydWUpOw0KPj4gwqDCoMKgwqDCoCB9DQo+PiDCoMKgwqDCoMKgIGNo ZWNrX3N0b3JlKCk7DQo+PiBAQCAtMzQwMCw3ICszNDAwLDcgQEAgdm9pZCByZWFkX3N0YXRl X25vZGUoY29uc3Qgdm9pZCAqY3R4LCBjb25zdCB2b2lkICpzdGF0ZSkNCj4+IMKgwqDCoMKg wqAgaWYgKHdyaXRlX25vZGVfcmF3KE5VTEwsICZrZXksIG5vZGUsIHRydWUpKQ0KPj4gwqDC oMKgwqDCoMKgwqDCoMKgIGJhcmYoIndyaXRlIG5vZGUgZXJyb3IgcmVzdG9yaW5nIG5vZGUi KTsNCj4+IC3CoMKgwqAgaWYgKGRvbWFpbl9lbnRyeV9pbmMoJmNvbm4sIG5vZGUpKQ0KPj4g K8KgwqDCoCBpZiAoZG9tYWluX25iZW50cnlfaW5jKCZjb25uLCBub2RlLT5wZXJtcy5wWzBd LmlkKSkNCj4+IMKgwqDCoMKgwqDCoMKgwqDCoCBiYXJmKCJub2RlIGFjY291bnRpbmcgZXJy b3IgcmVzdG9yaW5nIG5vZGUiKTsNCj4+IMKgwqDCoMKgwqAgdGFsbG9jX2ZyZWUobm9kZSk7 DQo+PiBkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5jIA0K Pj4gYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmMNCj4+IGluZGV4IDMyMTYx MTllODMuLjQwYjI0MDU2YzUgMTAwNjQ0DQo+PiAtLS0gYS90b29scy94ZW5zdG9yZS94ZW5z dG9yZWRfZG9tYWluLmMNCj4+ICsrKyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21h aW4uYw0KPj4gQEAgLTI0OSw3ICsyNDksNyBAQCBzdGF0aWMgaW50IGRvbWFpbl90cmVlX3Jl bW92ZV9zdWIoY29uc3Qgdm9pZCAqY3R4LCBzdHJ1Y3QgDQo+PiBjb25uZWN0aW9uICpjb25u LA0KPj4gwqDCoMKgwqDCoMKgwqDCoMKgIGRvbWFpbi0+bmJlbnRyeS0tOw0KPj4gwqDCoMKg wqDCoMKgwqDCoMKgIG5vZGUtPnBlcm1zLnBbMF0uaWQgPSBwcml2X2RvbWlkOw0KPj4gwqDC oMKgwqDCoMKgwqDCoMKgIG5vZGUtPmFjYy5tZW1vcnkgPSAwOw0KPj4gLcKgwqDCoMKgwqDC oMKgIGRvbWFpbl9lbnRyeV9pbmMoTlVMTCwgbm9kZSk7DQo+PiArwqDCoMKgwqDCoMKgwqAg ZG9tYWluX25iZW50cnlfaW5jKE5VTEwsIHByaXZfZG9taWQpOw0KPj4gwqDCoMKgwqDCoMKg wqDCoMKgIGlmICh3cml0ZV9ub2RlX3JhdyhOVUxMLCAma2V5LCBub2RlLCB0cnVlKSkgew0K Pj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgLyogVGhhdCdzIHVuZm9ydHVuYXRlLiBX ZSBvbmx5IGNhbiB0cnkgdG8gY29udGludWUuICovDQo+PiDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoCBzeXNsb2coTE9HX0VSUiwNCj4+IEBAIC01NTksNyArNTU5LDcgQEAgaW50IGFj Y19maXhfZG9tYWlucyhzdHJ1Y3QgbGlzdF9oZWFkICpoZWFkLCBib29sIHVwZGF0ZSkNCj4+ IMKgwqDCoMKgwqAgaW50IGNudDsNCj4+IMKgwqDCoMKgwqAgbGlzdF9mb3JfZWFjaF9lbnRy eShjZCwgaGVhZCwgbGlzdCkgew0KPj4gLcKgwqDCoMKgwqDCoMKgIGNudCA9IGRvbWFpbl9l bnRyeV9maXgoY2QtPmRvbWlkLCBjZC0+bmJlbnRyeSwgdXBkYXRlKTsNCj4+ICvCoMKgwqDC oMKgwqDCoCBjbnQgPSBkb21haW5fbmJlbnRyeV9maXgoY2QtPmRvbWlkLCBjZC0+bmJlbnRy eSwgdXBkYXRlKTsNCj4+IMKgwqDCoMKgwqDCoMKgwqDCoCBpZiAoIXVwZGF0ZSkgew0KPj4g wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgaWYgKGNudCA+PSBxdW90YV9uYl9lbnRyeV9w ZXJfZG9tYWluKQ0KPj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCByZXR1 cm4gRU5PU1BDOw0KPj4gQEAgLTYwNCwxOCArNjA0LDE5IEBAIHN0YXRpYyBzdHJ1Y3QgY2hh bmdlZF9kb21haW4gDQo+PiAqYWNjX2dldF9jaGFuZ2VkX2RvbWFpbihjb25zdCB2b2lkICpj dHgsDQo+PiDCoMKgwqDCoMKgIHJldHVybiBjZDsNCj4+IMKgIH0NCj4+IC1pbnQgYWNjX2Fk ZF9kb21fbmJlbnRyeShjb25zdCB2b2lkICpjdHgsIHN0cnVjdCBsaXN0X2hlYWQgKmhlYWQs IGludCB2YWwsDQo+PiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB1bnNpZ25lZCBpbnQgZG9t aWQpDQo+PiArc3RhdGljIGludCBhY2NfYWRkX2RvbV9uYmVudHJ5KGNvbnN0IHZvaWQgKmN0 eCwgc3RydWN0IGxpc3RfaGVhZCAqaGVhZCwgaW50IHZhbCwNCj4+ICvCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgdW5zaWduZWQgaW50IGRvbWlkKQ0KPj4gwqAgew0K Pj4gwqDCoMKgwqDCoCBzdHJ1Y3QgY2hhbmdlZF9kb21haW4gKmNkOw0KPj4gwqDCoMKgwqDC oCBjZCA9IGFjY19nZXRfY2hhbmdlZF9kb21haW4oY3R4LCBoZWFkLCBkb21pZCk7DQo+PiDC oMKgwqDCoMKgIGlmICghY2QpDQo+PiAtwqDCoMKgwqDCoMKgwqAgcmV0dXJuIGVycm5vOw0K Pj4gK8KgwqDCoMKgwqDCoMKgIHJldHVybiAwOw0KPj4gK8KgwqDCoCBlcnJubyA9IDA7DQo+ PiDCoMKgwqDCoMKgIGNkLT5uYmVudHJ5ICs9IHZhbDsNCj4+IC3CoMKgwqAgcmV0dXJuIDA7 DQo+PiArwqDCoMKgIHJldHVybiBjZC0+bmJlbnRyeTsNCj4gDQo+IFlvdSBqdXN0IGludHJv ZHVjZWQgdGhpcyBoZWxwZXIgaW4gdGhlIHByZXZpb3VzIHBhdGNoIChpLmUuICM5KS4gU28g Y2FuIHlvdSBnZXQgDQo+IHRoZSBpbnRlcmZhY2UgY29ycmVjdCBmcm9tIHRoZSBzdGFydD8g VGhpcyB3aWxsIG1ha2UgZWFzaWVyIHRvIHJldmlldyB0aGUgc2VyaWVzLg0KPiANCj4gSSBk b24ndCBtaW5kIHRvbyBtdWNoIGlmIHlvdSBhZGQgdGhlIHN0YXRpYyBoZXJlLiBBbHRob3Vn aCwgaXQgd291bGQgaGF2ZSBiZWVuIA0KPiBuaWNlIGlmIHdlIGF2b2lkIGNoYW5naW5nIGNv ZGUganVzdCBpbnRyb2R1Y2VkLg0KDQpGaW5lIHdpdGggbWUuDQoNCj4gDQo+PiDCoCB9DQo+ PiDCoCBzdGF0aWMgdm9pZCBkb21haW5fY29ubl9yZXNldChzdHJ1Y3QgZG9tYWluICpkb21h aW4pDQo+PiBAQCAtOTg4LDMwICs5ODksNiBAQCB2b2lkIGRvbWFpbl9kZWluaXQodm9pZCkN Cj4+IMKgwqDCoMKgwqDCoMKgwqDCoCB4ZW5ldnRjaG5fdW5iaW5kKHhjZV9oYW5kbGUsIHZp cnFfcG9ydCk7DQo+PiDCoCB9DQo+PiAtaW50IGRvbWFpbl9lbnRyeV9pbmMoc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBub2RlICpub2RlKQ0KPj4gLXsNCj4+IC3CoMKgwqAg c3RydWN0IGRvbWFpbiAqZDsNCj4+IC3CoMKgwqAgdW5zaWduZWQgaW50IGRvbWlkOw0KPj4g LQ0KPj4gLcKgwqDCoCBpZiAoIW5vZGUtPnBlcm1zLnApDQo+PiAtwqDCoMKgwqDCoMKgwqAg cmV0dXJuIDA7DQo+PiAtDQo+PiAtwqDCoMKgIGRvbWlkID0gbm9kZS0+cGVybXMucFswXS5p ZDsNCj4+IC0NCj4+IC3CoMKgwqAgaWYgKGNvbm4gJiYgY29ubi0+dHJhbnNhY3Rpb24pIHsN Cj4+IC3CoMKgwqDCoMKgwqDCoCB0cmFuc2FjdGlvbl9lbnRyeV9pbmMoY29ubi0+dHJhbnNh Y3Rpb24sIGRvbWlkKTsNCj4+IC3CoMKgwqAgfSBlbHNlIHsNCj4+IC3CoMKgwqDCoMKgwqDC oCBkID0gKGNvbm4gJiYgZG9taWQgPT0gY29ubi0+aWQgJiYgY29ubi0+ZG9tYWluKSA/IGNv bm4tPmRvbWFpbg0KPj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgOiBmaW5kX29yX2FsbG9j X2V4aXN0aW5nX2RvbWFpbihkb21pZCk7DQo+PiAtwqDCoMKgwqDCoMKgwqAgaWYgKGQpDQo+ PiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBkLT5uYmVudHJ5Kys7DQo+PiAtwqDCoMKgwqDC oMKgwqAgZWxzZQ0KPj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJuIEVOT01FTTsN Cj4+IC3CoMKgwqAgfQ0KPj4gLQ0KPj4gLcKgwqDCoCByZXR1cm4gMDsNCj4+IC19DQo+PiAt DQo+PiDCoCAvKg0KPj4gwqDCoCAqIENoZWNrIHdoZXRoZXIgYSBkb21haW4gd2FzIGNyZWF0 ZWQgYmVmb3JlIG9yIGFmdGVyIGEgc3BlY2lmaWMgZ2VuZXJhdGlvbg0KPj4gwqDCoCAqIGNv dW50ICh1c2VkIGZvciB0ZXN0aW5nIHdoZXRoZXIgYSBub2RlIHBlcm1pc3Npb24gaXMgb2xk ZXIgdGhhbiBhIGRvbWFpbikuDQo+PiBAQCAtMTA3OSw2MiArMTA1Niw2NyBAQCBpbnQgZG9t YWluX2FkanVzdF9ub2RlX3Blcm1zKHN0cnVjdCBub2RlICpub2RlKQ0KPj4gwqDCoMKgwqDC oCByZXR1cm4gMDsNCj4+IMKgIH0NCj4+IC12b2lkIGRvbWFpbl9lbnRyeV9kZWMoc3RydWN0 IGNvbm5lY3Rpb24gKmNvbm4sIHN0cnVjdCBub2RlICpub2RlKQ0KPj4gK3N0YXRpYyBpbnQg ZG9tYWluX25iZW50cnlfYWRkKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCB1bnNpZ25lZCBp bnQgZG9taWQsDQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBpbnQg YWRkLCBib29sIGRvbV9leGlzdHMpDQo+IA0KPiBUaGUgbmFtZSBvZiB0aGUgdmFyaWFibGUg c3VnZ2VzdHMgdGhhdCB0aGF0IGlmIGl0IGlzIGZhbHNlIHRoZW4gaXQgZG9lc24ndCANCj4g ZXhpc3RzLiBIb3dldmVyLCBsb29raW5nIGF0IGhvdyB5b3UgdXNlIGl0LCBpdCBpcyBtb3Jl IGEgIkNhbiBzdHJ1Y3QgZG9tYWluIGJlIA0KPiBhbGxvY2F0ZWQ/Ii4gU28gSSB3b3VsZCBy ZW5hbWUgaXQgdG8gImRvbV9hbGxvY19hbGxvd2VkIiBvciBzaW1pbGFyLg0KDQpJJ2xsIG5h bWUgaXQgIm5vX2RvbV9hbGxvYyIuDQoNCj4gDQo+PiDCoCB7DQo+PiDCoMKgwqDCoMKgIHN0 cnVjdCBkb21haW4gKmQ7DQo+PiAtwqDCoMKgIHVuc2lnbmVkIGludCBkb21pZDsNCj4+IC0N Cj4+IC3CoMKgwqAgaWYgKCFub2RlLT5wZXJtcy5wKQ0KPj4gLcKgwqDCoMKgwqDCoMKgIHJl dHVybjsNCj4+ICvCoMKgwqAgc3RydWN0IGxpc3RfaGVhZCAqaGVhZDsNCj4+ICvCoMKgwqAg aW50IHJldDsNCj4+IC3CoMKgwqAgZG9taWQgPSBub2RlLT5wZXJtcy5wID8gbm9kZS0+cGVy bXMucFswXS5pZCA6IGNvbm4tPmlkOw0KPj4gK8KgwqDCoCBpZiAoY29ubiAmJiBkb21pZCA9 PSBjb25uLT5pZCAmJiBjb25uLT5kb21haW4pDQo+PiArwqDCoMKgwqDCoMKgwqAgZCA9IGNv bm4tPmRvbWFpbjsNCj4+ICvCoMKgwqAgZWxzZSBpZiAoZG9tX2V4aXN0cykgew0KPj4gK8Kg wqDCoMKgwqDCoMKgIGQgPSBmaW5kX2RvbWFpbl9zdHJ1Y3QoZG9taWQpOw0KPj4gK8KgwqDC oMKgwqDCoMKgIGlmICghZCkgew0KPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZXJybm8g PSBFTk9FTlQ7DQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBjb3JydXB0KGNvbm4sICJN aXNzaW5nIGRvbWFpbiAldVxuIiwgZG9taWQpOw0KPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKg wqAgcmV0dXJuIC0xOw0KPj4gK8KgwqDCoMKgwqDCoMKgIH0NCj4+ICvCoMKgwqAgfSBlbHNl IHsNCj4+ICvCoMKgwqDCoMKgwqDCoCBkID0gZmluZF9vcl9hbGxvY19leGlzdGluZ19kb21h aW4oZG9taWQpOw0KPj4gK8KgwqDCoMKgwqDCoMKgIGlmICghZCkgew0KPj4gK8KgwqDCoMKg wqDCoMKgwqDCoMKgwqAgZXJybm8gPSBFTk9NRU07DQo+PiArwqDCoMKgwqDCoMKgwqDCoMKg wqDCoCByZXR1cm4gLTE7DQo+PiArwqDCoMKgwqDCoMKgwqAgfQ0KPj4gK8KgwqDCoCB9DQo+ PiDCoMKgwqDCoMKgIGlmIChjb25uICYmIGNvbm4tPnRyYW5zYWN0aW9uKSB7DQo+PiAtwqDC oMKgwqDCoMKgwqAgdHJhbnNhY3Rpb25fZW50cnlfZGVjKGNvbm4tPnRyYW5zYWN0aW9uLCBk b21pZCk7DQo+PiAtwqDCoMKgIH0gZWxzZSB7DQo+PiAtwqDCoMKgwqDCoMKgwqAgZCA9IChj b25uICYmIGRvbWlkID09IGNvbm4tPmlkICYmIGNvbm4tPmRvbWFpbikgPyBjb25uLT5kb21h aW4NCj4+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgIDogZmluZF9kb21haW5fc3RydWN0KGRv bWlkKTsNCj4+IC3CoMKgwqDCoMKgwqDCoCBpZiAoZCkgew0KPj4gLcKgwqDCoMKgwqDCoMKg wqDCoMKgwqAgZC0+bmJlbnRyeS0tOw0KPj4gLcKgwqDCoMKgwqDCoMKgIH0gZWxzZSB7DQo+ PiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBlcnJubyA9IEVOT0VOVDsNCj4+IC3CoMKgwqDC oMKgwqDCoMKgwqDCoMKgIGNvcnJ1cHQoY29ubiwNCj4+IC3CoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqAgIk5vZGUgXCIlc1wiIG93bmVkIGJ5IG5vbi1leGlzdGluZyBkb21haW4g JXVcbiIsDQo+PiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIG5vZGUtPm5hbWUs IGRvbWlkKTsNCj4+ICvCoMKgwqDCoMKgwqDCoCBoZWFkID0gdHJhbnNhY3Rpb25fZ2V0X2No YW5nZWRfZG9tYWlucyhjb25uLT50cmFuc2FjdGlvbik7DQo+PiArwqDCoMKgwqDCoMKgwqAg cmV0ID0gYWNjX2FkZF9kb21fbmJlbnRyeShjb25uLT50cmFuc2FjdGlvbiwgaGVhZCwgYWRk LCBkb21pZCk7DQo+PiArwqDCoMKgwqDCoMKgwqAgaWYgKGVycm5vKSB7DQo+PiArwqDCoMKg wqDCoMKgwqDCoMKgwqDCoCBmYWlsX3RyYW5zYWN0aW9uKGNvbm4tPnRyYW5zYWN0aW9uKTsN Cj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiAtMTsNCj4+IMKgwqDCoMKgwqDC oMKgwqDCoCB9DQo+PiArwqDCoMKgwqDCoMKgwqAgcmV0dXJuIGQtPm5iZW50cnkgKyByZXQ7 DQo+IA0KPiBJdCBpcyBub3QgZW50aXJlbHkgY2xlYXIgd2h5IHlvdSBhcmUgcmV0dXJuICJk LT5uYmVudHJ5ICsgcmV0IiBoZXJlLiBJZiBpdCBpcyAuLi4NCj4gDQo+PiDCoMKgwqDCoMKg IH0NCj4+ICsNCj4+ICvCoMKgwqAgZC0+bmJlbnRyeSArPSBhZGQ7DQo+PiArDQo+PiArwqDC oMKgIHJldHVybiBkLT5uYmVudHJ5Ow0KPj4gwqAgfQ0KPj4gLWludCBkb21haW5fZW50cnlf Zml4KHVuc2lnbmVkIGludCBkb21pZCwgaW50IG51bSwgYm9vbCB1cGRhdGUpDQo+PiAraW50 IGRvbWFpbl9uYmVudHJ5X2luYyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgdW5zaWduZWQg aW50IGRvbWlkKQ0KPj4gwqAgew0KPj4gLcKgwqDCoCBzdHJ1Y3QgZG9tYWluICpkOw0KPj4g LcKgwqDCoCBpbnQgY250Ow0KPj4gK8KgwqDCoCByZXR1cm4gKGRvbWFpbl9uYmVudHJ5X2Fk ZChjb25uLCBkb21pZCwgMSwgZmFsc2UpIDwgMCkgPyBlcnJubyA6IDA7DQo+PiArfQ0KPj4g LcKgwqDCoCBpZiAodXBkYXRlKSB7DQo+PiAtwqDCoMKgwqDCoMKgwqAgZCA9IGZpbmRfZG9t YWluX3N0cnVjdChkb21pZCk7DQo+PiAtwqDCoMKgwqDCoMKgwqAgYXNzZXJ0KGQpOw0KPj4g LcKgwqDCoCB9IGVsc2Ugew0KPj4gLcKgwqDCoMKgwqDCoMKgIC8qDQo+PiAtwqDCoMKgwqDC oMKgwqDCoCAqIFdlIGFyZSBjYWxsZWQgZmlyc3Qgd2l0aCB1cGRhdGUgPT0gZmFsc2UgaW4g b3JkZXIgdG8gY2F0Y2gNCj4+IC3CoMKgwqDCoMKgwqDCoMKgICogYW55IGVycm9yLiBTbyBk byBhIHBvc3NpYmxlIGFsbG9jYXRpb24gYW5kIGNoZWNrIGZvciBlcnJvcg0KPj4gLcKgwqDC oMKgwqDCoMKgwqAgKiBvbmx5IGluIHRoaXMgY2FzZSwgYXMgaW4gdGhlIGNhc2Ugb2YgdXBk YXRlID09IHRydWUgbm90aGluZw0KPj4gLcKgwqDCoMKgwqDCoMKgwqAgKiBjYW4gZ28gd3Jv bmcgYW55bW9yZSBhcyB0aGUgYWxsb2NhdGlvbiBhbHJlYWR5IGhhcHBlbmVkLg0KPj4gLcKg wqDCoMKgwqDCoMKgwqAgKi8NCj4+IC3CoMKgwqDCoMKgwqDCoCBkID0gZmluZF9vcl9hbGxv Y19leGlzdGluZ19kb21haW4oZG9taWQpOw0KPj4gLcKgwqDCoMKgwqDCoMKgIGlmICghZCkN Cj4+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiAtMTsNCj4+IC3CoMKgwqAgfQ0K Pj4gK2ludCBkb21haW5fbmJlbnRyeV9kZWMoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHVu c2lnbmVkIGludCBkb21pZCkNCj4+ICt7DQo+PiArwqDCoMKgIHJldHVybiAoZG9tYWluX25i ZW50cnlfYWRkKGNvbm4sIGRvbWlkLCAtMSwgdHJ1ZSkgPCAwKSA/IGVycm5vIDogMDsNCj4g DQo+IC4uLiB0byBtYWtlIHN1cmUgZG9tYWluX25iZW50cnlfYWRkKCkgaXMgbm90IHJldHVy bmluZyBhIG5lZ2F0aXZlIHZhbHVlLiBUaGVuIGl0IA0KPiB3b3VsZCBub3Qgd29yay4NCj4g DQo+IEEgZ29vZCBleGFtcGxlIGltYWdpbmUgeW91IGhhdmUgYSB0cmFuc2FjdGlvbiByZW1v dmluZyBub2RlcyBmcm9tIHRyZWUgYnV0IG5vdCANCj4gYWRkaW5nIGFueS4gVGhlbiB0aGUg InJldCIgd291bGQgYmUgbmVnYXRpdmUuDQo+IA0KPiBNZWFud2hpbGUgdGhlIG5vZGVzIGFy ZSBhbHNvIHJlbW92ZWQgb3V0c2lkZSBvZiB0aGUgdHJhbnNhY3Rpb24uIFNvIHRoZSBzdW0g b2YgDQo+ICJkLT5uYmVudHJ5ICsgcmV0IiB3b3VsZCBiZSBuZWdhdGl2ZSByZXN1bHRpbmcg dG8gYSBmYWlsdXJlIGhlcmUuDQoNClRoYW5rcyBmb3IgY2F0Y2hpbmcgdGhpcy4NCg0KSSB0 aGluayB0aGUgY29ycmVjdCB3YXkgdG8gaGFuZGxlIHRoaXMgaXMgdG8gcmV0dXJuIG1heChk LT5uYmVudHJ5ICsgcmV0LCAwKSBpbg0KZG9tYWluX25iZW50cnlfYWRkKCkuIFRoZSB2YWx1 ZSBtaWdodCBiZSBpbXByZWNpc2UsIGJ1dCBhbHdheXMgPj0gMCBhbmQgbmV2ZXINCndyb25n IG91dHNpZGUgb2YgYSB0cmFuc2FjdGlvbiBjb2xsaXNpb24uDQoNCj4gDQo+IFN1Y2ggY2hh bmdlIG9mIGJlaGF2aW9yIHNob3VsZCBwb2ludGVkIGluIHRoZSBjb21taXQgbWVzc2FnZS4g QnV0IHRoZW4gSSBhbSBub3QgDQo+IGNvbnZpbmNlZCB0aGlzIHNob3VsZCBiZSBwYXJ0IG9m IHRoaXMgY29tbWl0IHdoaWNoIGlzIG1haW5seSByZXdvcmtpbmcgYW4gDQo+IGludGVyZmFj ZSAoZS5nLiBubyBmdW5jdGlvbmFsIGNoYW5nZSBpcyBleHBlY3RlZCkuDQoNCg0KSnVlcmdl bg0KDQo= --------------dZLLH6SYO5JkkPHB2rrxCE6s Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------dZLLH6SYO5JkkPHB2rrxCE6s-- --------------ijqjNbtAm927E2rgdiy43jO6-- --------------KS7AxDwQIZ4uNKtSJykthUro Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmO+enkFAwAAAAAACgkQsN6d1ii/Ey/s wQf+PJOnejDtgeKL+GLHhCHx4937CxbZtbLEsK4OIDYN7VMAjOWlZ5q/Ws1PtdsOwFaC99aoF2Q6 TXl47ODFdDCUXE54u9aHkYBbTqV3VSfJZw2Lo1nzQjKN0W/mGcVLLTWeLY9y07LTW+/ejyu9kEla 9uDvvi72dm/HI27BY9aZsRw8g43erfVEQcjd/Ff/Zvs83iTj6n6OC4U5pNzxI/W8bwXTxv4Zrp9N bZndpWR002znMNRoOKObXMJDdQxeaMCxRy9kusUPmY3NhLbTt8RFQtL2CtjeioPts8yvZgtRMKDZ b8gHBXjuFPvFhHpY3004uX2tv9MjSxdwHY+wC7NDsw== =z9Mn -----END PGP SIGNATURE----- --------------KS7AxDwQIZ4uNKtSJykthUro-- From xen-devel-bounces@lists.xenproject.org Wed Jan 11 09:07:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 09:07:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475137.736677 (Exim 4.92) (envelope-from ) id 1pFX4f-0003E3-Be; Wed, 11 Jan 2023 09:07:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475137.736677; Wed, 11 Jan 2023 09:07:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFX4f-0003Dw-8z; Wed, 11 Jan 2023 09:07:09 +0000 Received: by outflank-mailman (input) for mailman id 475137; Wed, 11 Jan 2023 09:07:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFX4e-0003Dq-B8 for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 09:07:08 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 52a5e5d5-918f-11ed-91b6-6bf2151ebd3b; Wed, 11 Jan 2023 10:07:07 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 93BED170A7; Wed, 11 Jan 2023 09:07:06 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6C5FE13591; Wed, 11 Jan 2023 09:07:06 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id iiIDGTp8vmOAWQAAMHmgww (envelope-from ); Wed, 11 Jan 2023 09:07:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 52a5e5d5-918f-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1673428026; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hINL1kw5QQtqka4RW0Ff+qlJJ1FTTaLsBoXy+6fy0SY=; b=u8cqqGl5iJLQW4NvZB0OfdcA0OX/HsXxnqegqv2rKBxRg+7JvkgWzpjKxjSDeqpd7/X7ex oMOP7iWvchwSpghbnB5xtAO4vdLw4kuGFmF9Y6wlEI9CMMGtC6R7w4edrIJTWZauKnKr8H Nqq1xNhhVrvFbfu5lFzzCN1kUS7TQ0Y= Message-ID: <2c0b38d3-b254-6968-1492-35d7b8b475ad@suse.com> Date: Wed, 11 Jan 2023 10:07:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 11/19] tools/xenstore: don't allow creating too many nodes in a transaction Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20221213160045.28170-1-jgross@suse.com> <20221213160045.28170-12-jgross@suse.com> <04658e96-ec81-1dba-6829-3a52c69a27bb@xen.org> From: Juergen Gross In-Reply-To: <04658e96-ec81-1dba-6829-3a52c69a27bb@xen.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------6zV1cawd1gKaGdLLS6m0S5vW" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------6zV1cawd1gKaGdLLS6m0S5vW Content-Type: multipart/mixed; boundary="------------4fNEaKrbQaeyNiC3QP8pEqpn"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD Message-ID: <2c0b38d3-b254-6968-1492-35d7b8b475ad@suse.com> Subject: Re: [PATCH v2 11/19] tools/xenstore: don't allow creating too many nodes in a transaction References: <20221213160045.28170-1-jgross@suse.com> <20221213160045.28170-12-jgross@suse.com> <04658e96-ec81-1dba-6829-3a52c69a27bb@xen.org> In-Reply-To: <04658e96-ec81-1dba-6829-3a52c69a27bb@xen.org> --------------4fNEaKrbQaeyNiC3QP8pEqpn Content-Type: multipart/mixed; boundary="------------95dPM5R07imH7r3tCk1Hjnk9" --------------95dPM5R07imH7r3tCk1Hjnk9 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjAuMTIuMjIgMjE6MTgsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGksDQo+IA0KPiBP biAxMy8xMi8yMDIyIDE2OjAwLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gVGhlIGFjY291 bnRpbmcgZm9yIHRoZSBudW1iZXIgb2Ygbm9kZXMgb2YgYSBkb21haW4gaW4gYW4gYWN0aXZl DQo+PiB0cmFuc2FjdGlvbiBpcyBub3Qgd29ya2luZyBjb3JyZWN0bHksIGFzIGl0IGFsbG93 cyB0byBjcmVhdGUgYXJiaXRyYXJ5DQo+PiBudW1iZXIgb2Ygbm9kZXMuIFRoZSB0cmFuc2Fj dGlvbiB3aWxsIGZpbmFsbHkgZmFpbCBkdWUgdG8gZXhjZWVkaW5nDQo+PiB0aGUgbnVtYmVy IG9mIG5vZGVzIHF1b3RhLCBidXQgYmVmb3JlIGNsb3NpbmcgdGhlIHRyYW5zYWN0aW9uIGFu DQo+PiB1bnByaXZpbGVnZWQgZ3Vlc3QgY291bGQgY2F1c2UgWGVuc3RvcmUgdG8gdXNlIGEg bG90IG9mIG1lbW9yeS4NCj4gDQo+IEFzIHBlciB0aGUgZGlzY3Vzc2lvbiBpbiB2MSwgdGhl IGNvbW1pdCBtZXNzYWdlIG5lZWRzIHRvIGJlIHJld29yZGVkLg0KPiANCj4gSSB3aWxsIGxv b2sgYXQgdGhpcyBwYXRjaCBpbiBtb3JlIGRldGFpbHMgb25jZSBJIGhhdmUgcmVhY2hlZCB0 aGUgMm5kIHNlcmllcy4NCg0KSSdsbCB3YWl0IHdpdGggdGhlIHJld29yZGluZyB1bnRpbCB0 aGVuLg0KDQoNCkp1ZXJnZW4NCg== --------------95dPM5R07imH7r3tCk1Hjnk9 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------95dPM5R07imH7r3tCk1Hjnk9-- --------------4fNEaKrbQaeyNiC3QP8pEqpn-- --------------6zV1cawd1gKaGdLLS6m0S5vW Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmO+fDoFAwAAAAAACgkQsN6d1ii/Ey85 WQf7BFomOGWEfBpKGyU353SMG/DW8NJcbDP8CgVk3bkGErZApUc6V76Tl0mw1Azl3pi67kWNOno/ gWlCVvok1XNvRkGkKvji4A53P2nZqR8LLK2zUAJgnBITjx36afBr06fpvrCFSMV90JQB3dIkkstj 7QoQhGD5sC2vh3+H/5kc3lEyNwpwU7yBNkLau3WL4kcYJ9wQ3KAsCbWNjeQ1pvTfpKwfrF9sJIMu TIt5zgo0cqidEMoFR0tU+g0rY84QxcJseQjmhJHu32Xf0CpGSGBIFFgiDVW5vP9GKTsQyEkGKYVz tbgxUU5nHojxlMGZPqe/ANc6KpnL1aSQ+5ZC8RCNRw== =HGFe -----END PGP SIGNATURE----- --------------6zV1cawd1gKaGdLLS6m0S5vW-- From xen-devel-bounces@lists.xenproject.org Wed Jan 11 09:08:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 09:08:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475143.736688 (Exim 4.92) (envelope-from ) id 1pFX5w-0003mu-Lu; Wed, 11 Jan 2023 09:08:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475143.736688; Wed, 11 Jan 2023 09:08:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFX5w-0003mn-Iw; Wed, 11 Jan 2023 09:08:28 +0000 Received: by outflank-mailman (input) for mailman id 475143; Wed, 11 Jan 2023 09:08:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFX5v-0003mh-PX for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 09:08:27 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2040.outbound.protection.outlook.com [40.107.22.40]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7fbf4159-918f-11ed-b8d0-410ff93cb8f0; Wed, 11 Jan 2023 10:08:23 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB6803.eurprd04.prod.outlook.com (2603:10a6:208:187::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Wed, 11 Jan 2023 09:08:22 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Wed, 11 Jan 2023 09:08:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7fbf4159-918f-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g6V8MEZokr3DYQGSn6eWcqLsvGmdovnzWUNfFJGF9cSjBU11wg+dz4WLtB2W18vKzXzSiEB7LPCm/dUgbToU0Rmpd9/oGwIWElX1XxmGLKHh5Td0ZrlI3fLr03uBy1W/G5Q6gUA/O1vWG5huKlccFZxrn64E+oRu/KwAe/K0sprpaHY2juE60uew/8jMNyfWaIFsLaD6vlqj+VhDJI84NrM/3M8djRRXM9Qp343kc7DzeJNJVooDRnjkmHkOI3PWmuqJ6/OilPM22hkM6bdZTnr2sZ8vPfFhajnb4ukGul/xA61CKj/RZ5WTzSGLOlE5NLThRWzA7uRSHOM43zz9oA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fcayiEJHhuTrBBbs3n/Zkwp+wXDoF5yREjQiuKs5PQE=; b=WMMU2A8HTc0kZN1fIGv/TmRHuE5RtX6D9ZsqR1P4WjiYrW0ufhbmQeAjJsuG7gxi4nUtknSbRZMBj6jjfZwUTPnq0z2LN7g4RjrUxCXWrg1EVSLVaeWsdMzVbkLd1JwrXVMsbANra94E3BggWlyVUt8ys5GN7+bA3F1p6omh6ETGMYPNBXDT1fjRS29IowCiWGhfmw2ufAX7QxNBVWjIsS2JiOFyU7JoJPBWAuLhXdr2aOLSrZlGzjNpMIDxtGCqT6AHTrzIHrmWSSp80Fhueff2g6g46OdR9/TSr2YviafUvssu0+mgUZwAmWXoM5tEMVllxOnY/Qtt1Few31P3Uw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fcayiEJHhuTrBBbs3n/Zkwp+wXDoF5yREjQiuKs5PQE=; b=A019GrJZk7g5WZg4oKewTOq5gdvQmTl+YjoyVlTagVwBoC7vTsGRFV1SQhocqRMDruwbhghWHj5L6oMBw69m463FJIX/z7qIS5nfFS+rIUvC4hNlxIR1dY2JdxkG4MqTfc3AedXji1KVBbs4FQK0VpkHhgXNEhOl7dRlO3g4zCaYiSvCOBGfrKeFMVHcnN5w5j2S4tgrQkqantplbljALkgI8kFtz+el3QmKTEd9SU6pE6iT/AIo67/KwhubuEdBLz5zVgEXs5RlHSKHNMrxUjsge+js3mYvoJ4nQRAUuNATBPeF9t2liLq75Cf6vohF1bI+ZsiArahIudO4ZiXOjQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <1b6ee20d-2f32-ab38-83ec-69c33baf42fd@suse.com> Date: Wed, 11 Jan 2023 10:08:20 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v3 2/6] xen/riscv: introduce asm/types.h header file Content-Language: en-US To: Oleksii Cc: Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org References: <06185fcfb8cbd849df4b033efa923b55c054738d.camel@gmail.com> From: Jan Beulich In-Reply-To: <06185fcfb8cbd849df4b033efa923b55c054738d.camel@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0101.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a1::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM0PR04MB6803:EE_ X-MS-Office365-Filtering-Correlation-Id: 9afdd411-15cc-4544-4512-08daf3b363e6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MrMC31EWQie1C5it+fnueu96JOht7t0lOGc799NtF69t70QT7sT0UZ8sNSIxqnNNFzCJCfgZ2K4M86mIDPIezQQ4gUakc5Tx+b9aO4EAw5jUBf5EsTvnPIB0p3rO6kWC3YRfYtkSm2dy/IayqPM/6mEP8KK04efSGhd5ld7iZpcvAoFJR5GaFV6z6cmIgyTiMVAGRB8NjpjYJWpGyLvVbp+UwI5CpWfYwo5unPqguzJ8+54FA2mFuo4wkbqYNM2x41HpF8uSYsgqwRUBkBfZvxRBGi7H/Ix/zPPgckf0Pzt946rYebljzwcUsZW5b+HhBn7wuJSKThSesQ/iuVrvBNNnermfgyq4XPvm0hve4cpWUr73KZ1Ijrz2JWChEuxqx/tk3XdGSf0x7S1ME0mu0aU+5hGG5ldL/Iwu28A7trlo2MsMWwMXpfcYSWDr/4I6MEWLZHaHLAkz/WbXD3GlnuTyPUaPWQXEuWhO33Ss17z/gKOMNJLF4mWoDVoBtK9vkYKX55M9nIF1ysNVkQi9EhhT3R7nC0gqU92XAn2Kznwpb3nAxUPTXwKb+Nxde2Sbr+1ghNTS7MrvcsvVuLXRwVjygWOoE+6LznoU0NP9mcxv/gpLBNMZMDs//YzhWinqmBFWkbB4sFKpv04QnoiQQoYLFtMozQKmgUS2ThwRawsOgwb/EMIouupRyiCuCMP5fR3vbiDHJSFvOUJ6UwuEAgc7EjFSVgL7oQWdxy7f1bk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(366004)(136003)(376002)(346002)(39860400002)(451199015)(6506007)(478600001)(53546011)(26005)(36756003)(2616005)(38100700002)(86362001)(6486002)(31696002)(6512007)(186003)(5660300002)(31686004)(66556008)(8936002)(66946007)(66476007)(8676002)(54906003)(4326008)(41300700001)(6916009)(316002)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bjJQRW9CaXFncmJ4VkpGNHJuWjVGTmpRWjg1elpqN2ZOdUUrZGRwbTZjQVhO?= =?utf-8?B?SUFnSXdxT2hPSWhCK0tKRDI5OFdMd0NFRythakFrTlhkaWlyR2pYaDFJUTg0?= =?utf-8?B?dXkwVUxZT3Q1bjI2czZhcTR0YklqUEpyRFY0d1hDTEVISTBOWmJPaDNpdk81?= =?utf-8?B?YVlvdUZ1M1lOd3o4TmZBRnBsdktEa29XNm9qckpYZ1F2T1R1SFVWU0kxZGxu?= =?utf-8?B?VXdIbUFPWThzWDNYYzFDK3M5NHVTaXgwSHkrVkdVeS93Mm1SYVVQWFVHRUtP?= =?utf-8?B?cldwZ2JoYVVYaUYwaEc5eko4eCt4SWVGUGRyVVoyU3pZelRRQVFGeUtvbTho?= =?utf-8?B?VmFkeDNIcUF6VkVtMkdxaDI2cUpCSXR6TWZBbm5GWStqVUhPcXNGK3pjR00x?= =?utf-8?B?Ukw2ME90OUxvdC9BMm1WM1B5SzBlLzBjVjR1WkdwSHUwQWxvM01JYnhMS05P?= =?utf-8?B?RXZkUlJTTDZoZjhOeklGWUZPSVB5UkFJOFBJZkFiR0hXOTk1R2l3dzhkUXFv?= =?utf-8?B?VWdPN3RXUE9DZjBTZXVYYThsNERrTFpiVHpzaUJXVDFCS3BWbDNHSGNNY0h5?= =?utf-8?B?UW5QczVNVDR2M2dwZTM2MFRhWFhJQ1dobzJiT3JRZmtFcnVDM0w5LzExUWw5?= =?utf-8?B?SVZ3RXpGVS94NTYwZW9xSExuTlZSRkRXeWNUZlZTd0c5Z3Z2UG51aDY1UUdv?= =?utf-8?B?RjRPNldSNUF1UEVRYUcyVmJYY21RN2t1M25VdDVnMnBVcERJREExRjg3dWda?= =?utf-8?B?ajBScXdtaEFkVzc1UEE3aU41WHdLVWl0a09nWWhJZ0pBczZBTmhnTmpqQk5U?= =?utf-8?B?MUV4Y2tXbk9WZTIyREN1UDNZcHNjK0cvZTdLWnh2bUkxZjVQaVhTb0ZCbkdz?= =?utf-8?B?Wk5mY1E2dXRBbWNSbkRMOGlyM2ZzQ1NZRE95TlpwbFcvUTJTSXptbDBzNWhY?= =?utf-8?B?UUx2d3N6bnAvZk9yYVJDZTBKTGV1VkVSNU1FMi9hUUErNDR0RElhWjNzb282?= =?utf-8?B?SDRvL1IzMkZwSTQyWTVMa3NyeUZuSFNldkZNU1gwUDdSaFlhQlFWZWkxMUZR?= =?utf-8?B?WkpaeDBiUDBJRDBlclB4ZkhLck1UM2k1b2U3UzJPd1huRWJkZVFyc3pVanp5?= =?utf-8?B?UGFLSmxZcjQ3S1JHVGZFZ0d0RjZ2MHhzOVlzRDArbzJ4blhialErbDcwaUdl?= =?utf-8?B?cE4raXBuU0dWSERLTGtnaDFvb1ljdWlxWktLSVNYZjB0OFFyN2UzOUdrZDRs?= =?utf-8?B?R0JzRlZleHJnSzQ1ZkhOZWpDd3ptcHBwNnRTOGhCME5LZ2pCcitEVlNxZ3Zs?= =?utf-8?B?Ly9TRldrRFdIbWRHVDczMnB0R05hNXV1eVdubXRoTnUxU1BXVnNURnJVK1Rs?= =?utf-8?B?Y2llcTh2WDVwNjA1a0laOWd4aEtIc2dqQkI0aWR2Z3pWTy8rQ3pyNjc3QnhP?= =?utf-8?B?Y3NlQ1pXN1ZaSmFkL29FRlpyVGpBVzgxMGt0TTFkRDk5OC9SYWJKVERyS3Fi?= =?utf-8?B?VXp6eUxwVlhuZGpPc2NlNnh5Y2Z2dVNnUmhzcXZ2RGRRdTlZZUN4VGcvSW8r?= =?utf-8?B?YXF1RmVUZTRkRlJ0SS91Y01KUEJzQ3ZXd0lrd2ttWG5rRjJ4MlFPVnRBenBD?= =?utf-8?B?SzBHb3pRbWRaaTVvU0ZHQXJRcHNKRzV6LzZ2ZkR4dlFuQTRobXE0Zjk5VGNo?= =?utf-8?B?UEJHR2g2K3A5cEdyS3NLSUhmVFl6OEZ6VzAydXJodElhVy9KV2NLSENlNkR0?= =?utf-8?B?c1c1c0plaG9qSWdzdy9Ec1JUdUNxNEh6dTFscmtIZkpyQ2lZck1vcVE1MWtG?= =?utf-8?B?MDd6cGRUMXRyZi9uWlRRdFJZM0FZSkNJNUgvMHJUY0pzcFZPRCtETC9oNFlO?= =?utf-8?B?YmkrNnp2cHAwTXlDQUdSMk52NjBlaWNabXNOUGx1QUVLVVpVcWhHUUV6Nk41?= =?utf-8?B?dDJUdDB1VmZCbFZWc1FzdWRaNTMzTjlkdUlRWDBqeWlPT2ZWb2VFRWVScGZw?= =?utf-8?B?eVRRbUhyc0lBVTBWb2tGRmkycVgyRE9YUTdQUjNLUjBhM3RHb2V6WkJ1cDJP?= =?utf-8?B?aGN2V1F0Vk5DMVkyMmVBeEZrQWFqVE9Zc3JGZDE1V3dLMWw4R0JqWjdLcmdq?= =?utf-8?Q?Gwnri104DfMXCIKvykDxVQ81n?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9afdd411-15cc-4544-4512-08daf3b363e6 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2023 09:08:22.8171 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: F+NxpV/yrE1ZWgUV/PqKE9nzxnq1AuySih9/tOnpcUdlxJa4UccVwEVe8g+RFHMSE/Sdy5VD/KYDt41wJWO7QA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6803 On 11.01.2023 09:47, Oleksii wrote: > On Tue, 2023-01-10 at 17:58 +0100, Jan Beulich wrote: >> On 10.01.2023 16:17, Oleksii Kurochko wrote: >>> Signed-off-by: Oleksii Kurochko >>> --- >>> Changes in V3: >>>     - Nothing changed >>> --- >>> Changes in V2: >>>     - Remove unneeded now types from >> >> I guess you went a little too far: Types used in common code, even if >> you > It looks then I didn't understand which one of types are needed. > > In "[PATCH v1 2/8] xen/riscv: introduce asm/types.h header file" all > types were introduced as most of them are used in : > __{u|s}{8|16|32|64}. Thereby it looks like the following types in > should be present from the start: > typedef __signed__ char __s8; > typedef unsigned char __u8; > > typedef __signed__ short __s16; > typedef unsigned short __u16; > > typedef __signed__ int __s32; > typedef unsigned int __u32; > > #if defined(__GNUC__) && !defined(__STRICT_ANSI__) > #if defined(CONFIG_RISCV_32) > typedef __signed__ long long __s64; > typedef unsigned long long __u64; > #elif defined (CONFIG_RISCV_64) > typedef __signed__ long __s64; > typedef unsigned long __u64; > #endif > #endif > > Then it turns out that there is no any sense in: > typedef signed char s8; > typedef unsigned char u8; > > typedef signed short s16; > typedef unsigned short u16; > > typedef signed int s32; > typedef unsigned int u32; > > typedef signed long long s64; > typedef unsigned long long u64; > OR > typedef signed long s64; > typedef unsigned long u64; > As I understand instead of them should be used: {u|s}int_t. Hmm, the situation is worse than I thought (recalled) it was: You're right, xen/types.h actually uses __{u,s}. So I'm sorry for mis- guiding you; we'll need to do more cleanup first for asm/types.h to become smaller. Jan From xen-devel-bounces@lists.xenproject.org Wed Jan 11 09:27:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 09:27:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475149.736699 (Exim 4.92) (envelope-from ) id 1pFXNz-0006AZ-5f; Wed, 11 Jan 2023 09:27:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475149.736699; Wed, 11 Jan 2023 09:27:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFXNz-0006AS-37; Wed, 11 Jan 2023 09:27:07 +0000 Received: by outflank-mailman (input) for mailman id 475149; Wed, 11 Jan 2023 09:27:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFXNx-0006AM-F3 for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 09:27:05 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 19ba45e0-9192-11ed-b8d0-410ff93cb8f0; Wed, 11 Jan 2023 10:27:00 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1B9F51715E; Wed, 11 Jan 2023 09:27:02 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E60EC1358A; Wed, 11 Jan 2023 09:27:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id mUbnNuWAvmOTZAAAMHmgww (envelope-from ); Wed, 11 Jan 2023 09:27:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 19ba45e0-9192-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1673429222; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sC0uF9eGD69o848eLYrtexwMqzyMTiSrfsq2L3LBc6o=; b=OyjvChkMMyD2LS6IjAWh2I3qNttukzBbDcDJAtctZ3PdlMQH/UfvDd/tNRFJGfbYr58Q6j Arl3lpWMdFWeXE2pgv8Yc/juJmPMoUsrztRlCwzApQV+ZGeZ1zuN8kdrTRICA5VqD1gNQV A3j6wCCa2jPbMIJ0T2lf9qQr/RpCCgk= Message-ID: <00c146ee-b0d4-55bd-3276-4894b26cd83c@suse.com> Date: Wed, 11 Jan 2023 10:27:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20221213160045.28170-1-jgross@suse.com> <20221213160045.28170-16-jgross@suse.com> From: Juergen Gross Subject: Re: [PATCH v2 15/19] tools/xenstore: switch hashtable to use the talloc framework In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------iFVyoi4bR64KLaI8CtSoZUfV" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------iFVyoi4bR64KLaI8CtSoZUfV Content-Type: multipart/mixed; boundary="------------KWXXITPtJ1KDuGIb5mxLsr06"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD Message-ID: <00c146ee-b0d4-55bd-3276-4894b26cd83c@suse.com> Subject: Re: [PATCH v2 15/19] tools/xenstore: switch hashtable to use the talloc framework References: <20221213160045.28170-1-jgross@suse.com> <20221213160045.28170-16-jgross@suse.com> In-Reply-To: --------------KWXXITPtJ1KDuGIb5mxLsr06 Content-Type: multipart/mixed; boundary="------------TrpUY8kPg6koMLqXntZ3bvG1" --------------TrpUY8kPg6koMLqXntZ3bvG1 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjAuMTIuMjIgMjI6NTAsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGkgSnVlcmdlbiwN Cj4gDQo+IE9uIDEzLzEyLzIwMjIgMTY6MDAsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBA QCAtMTE1LDQ3ICsxMTcsMzIgQEAgaGFzaHRhYmxlX2V4cGFuZChzdHJ1Y3QgaGFzaHRhYmxl ICpoKQ0KPj4gwqDCoMKgwqDCoCBpZiAoaC0+cHJpbWVpbmRleCA9PSAocHJpbWVfdGFibGVf bGVuZ3RoIC0gMSkpIHJldHVybiAwOw0KPj4gwqDCoMKgwqDCoCBuZXdzaXplID0gcHJpbWVz WysrKGgtPnByaW1laW5kZXgpXTsNCj4+IC3CoMKgwqAgbmV3dGFibGUgPSAoc3RydWN0IGVu dHJ5ICoqKWNhbGxvYyhuZXdzaXplLCBzaXplb2Yoc3RydWN0IGVudHJ5KikpOw0KPj4gLcKg wqDCoCBpZiAoTlVMTCAhPSBuZXd0YWJsZSkNCj4+ICvCoMKgwqAgbmV3dGFibGUgPSB0YWxs b2NfcmVhbGxvYyhoLCBoLT50YWJsZSwgc3RydWN0IGVudHJ5ICosIG5ld3NpemUpOw0KPj4g K8KgwqDCoCBpZiAoIW5ld3RhYmxlKQ0KPj4gwqDCoMKgwqDCoCB7DQo+PiAtwqDCoMKgwqDC oMKgwqAgLyogVGhpcyBhbGdvcml0aG0gaXMgbm90ICdzdGFibGUnLiBpZS4gaXQgcmV2ZXJz ZXMgdGhlIGxpc3QNCj4+IC3CoMKgwqDCoMKgwqDCoMKgICogd2hlbiBpdCB0cmFuc2ZlcnMg ZW50cmllcyBiZXR3ZWVuIHRoZSB0YWJsZXMgKi8NCj4+IC3CoMKgwqDCoMKgwqDCoCBmb3Ig KGkgPSAwOyBpIDwgaC0+dGFibGVsZW5ndGg7IGkrKykgew0KPj4gLcKgwqDCoMKgwqDCoMKg wqDCoMKgwqAgd2hpbGUgKE5VTEwgIT0gKGUgPSBoLT50YWJsZVtpXSkpIHsNCj4+IC3CoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgaC0+dGFibGVbaV0gPSBlLT5uZXh0Ow0KPj4g LcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBpbmRleCA9IGluZGV4Rm9yKG5ld3Np emUsZS0+aCk7DQo+PiArwqDCoMKgwqDCoMKgwqAgaC0+cHJpbWVpbmRleC0tOw0KPj4gK8Kg wqDCoMKgwqDCoMKgIHJldHVybiAwOw0KPj4gK8KgwqDCoCB9DQo+PiArDQo+PiArwqDCoMKg IGgtPnRhYmxlID0gbmV3dGFibGU7DQo+PiArwqDCoMKgIG1lbXNldChuZXd0YWJsZSArIGgt PnRhYmxlbGVuZ3RoLCAwLA0KPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgIChuZXdzaXplIC0g aC0+dGFibGVsZW5ndGgpICogc2l6ZW9mKCpuZXd0YWJsZSkpOw0KPj4gK8KgwqDCoCBmb3Ig KGkgPSAwOyBpIDwgaC0+dGFibGVsZW5ndGg7IGkrKykgew0KPiANCj4gSSB1bmRlcnN0YW5k IHRoaXMgY29kZSBpcyB0YWtlbiBmcm9tIHRoZSByZWFsbG9jIHBhdGguIEhvd2V2ZXIsIGlz bid0IHRoaXMgDQo+IGFsZ29yaXRobSBhbHNvIG5vdCBzdGFibGU/IElmIHNvLCB0aGVuIEkg dGhpbmsgd2UgbW92ZSB0aGUgY29tbWVudCBoZXJlLg0KDQpJJ20gZmluZSB3aXRoIHRoYXQs IGV2ZW4gaWYgSSBkb24ndCBzZWUgaG93IGl0IHdvdWxkIG1hdHRlci4gVGhlcmUgaXMgbm8N Cmd1YXJhbnRlZSByZWdhcmRpbmcgdGhlIG9yZGVyIG9mIGVudHJpZXMgZm9yIGEgZ2l2ZW4g aW5kZXguDQoNCj4gDQo+PiArwqDCoMKgwqDCoMKgwqAgZm9yIChwRSA9ICYobmV3dGFibGVb aV0pLCBlID0gKnBFOyBlICE9IE5VTEw7IGUgPSAqcEUpIHsNCj4+ICvCoMKgwqDCoMKgwqDC oMKgwqDCoMKgIGluZGV4ID0gaW5kZXhGb3IobmV3c2l6ZSxlLT5oKTsNCj4gDQo+IE1pc3Np bmcgc3BhY2UgYWZ0ZXIgIiwiLg0KDQpXaWxsIGZpeC4NCg0KPiANCj4+ICvCoMKgwqDCoMKg wqDCoMKgwqDCoMKgIGlmIChpbmRleCA9PSBpKQ0KPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKg wqAgew0KPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBwRSA9ICYoZS0+bmV4 dCk7DQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB9DQo+PiArwqDCoMKgwqDCoMKgwqDC oMKgwqDCoCBlbHNlDQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB7DQo+PiArwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgICpwRSA9IGUtPm5leHQ7DQo+PiDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGUtPm5leHQgPSBuZXd0YWJsZVtpbmRleF07DQo+ PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIG5ld3RhYmxlW2luZGV4XSA9 IGU7DQo+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB9DQo+PiDCoMKgwqDCoMKgwqDC oMKgwqAgfQ0KPj4gLcKgwqDCoMKgwqDCoMKgIGZyZWUoaC0+dGFibGUpOw0KPj4gLcKgwqDC oMKgwqDCoMKgIGgtPnRhYmxlID0gbmV3dGFibGU7DQo+PiAtwqDCoMKgIH0NCj4+IC3CoMKg wqAgLyogUGxhbiBCOiByZWFsbG9jIGluc3RlYWQgKi8NCj4+IC3CoMKgwqAgZWxzZQ0KPj4g LcKgwqDCoCB7DQo+PiAtwqDCoMKgwqDCoMKgwqAgbmV3dGFibGUgPSAoc3RydWN0IGVudHJ5 ICoqKQ0KPj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCByZWFsbG9j KGgtPnRhYmxlLCBuZXdzaXplICogc2l6ZW9mKHN0cnVjdCBlbnRyeSAqKSk7DQo+PiAtwqDC oMKgwqDCoMKgwqAgaWYgKE5VTEwgPT0gbmV3dGFibGUpIHsgKGgtPnByaW1laW5kZXgpLS07 IHJldHVybiAwOyB9DQo+PiAtwqDCoMKgwqDCoMKgwqAgaC0+dGFibGUgPSBuZXd0YWJsZTsN Cj4+IC3CoMKgwqDCoMKgwqDCoCBtZW1zZXQobmV3dGFibGUgKyBoLT50YWJsZWxlbmd0aCwg MCwNCj4+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIChuZXdzaXplIC0gaC0+dGFi bGVsZW5ndGgpICogc2l6ZW9mKCpuZXd0YWJsZSkpOw0KPj4gLcKgwqDCoMKgwqDCoMKgIGZv ciAoaSA9IDA7IGkgPCBoLT50YWJsZWxlbmd0aDsgaSsrKSB7DQo+PiAtwqDCoMKgwqDCoMKg wqDCoMKgwqDCoCBmb3IgKHBFID0gJihuZXd0YWJsZVtpXSksIGUgPSAqcEU7IGUgIT0gTlVM TDsgZSA9ICpwRSkgew0KPj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBpbmRl eCA9IGluZGV4Rm9yKG5ld3NpemUsZS0+aCk7DQo+PiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgIGlmIChpbmRleCA9PSBpKQ0KPj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoCB7DQo+PiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg cEUgPSAmKGUtPm5leHQpOw0KPj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB9 DQo+PiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGVsc2UNCj4+IC3CoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgew0KPj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgICpwRSA9IGUtPm5leHQ7DQo+PiAtwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqAgZS0+bmV4dCA9IG5ld3RhYmxlW2luZGV4XTsNCj4+IC3C oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBuZXd0YWJsZVtpbmRleF0g PSBlOw0KPj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB9DQo+PiAtwqDCoMKg wqDCoMKgwqDCoMKgwqDCoCB9DQo+PiAtwqDCoMKgwqDCoMKgwqAgfQ0KPj4gwqDCoMKgwqDC oCB9DQo+PiArDQo+PiDCoMKgwqDCoMKgIGgtPnRhYmxlbGVuZ3RoID0gbmV3c2l6ZTsNCj4+ IMKgwqDCoMKgwqAgaC0+bG9hZGxpbWl0wqDCoCA9ICh1bnNpZ25lZCBpbnQpDQo+PiDCoMKg wqDCoMKgwqDCoMKgwqAgKCgodWludDY0X3QpbmV3c2l6ZSAqIG1heF9sb2FkX2ZhY3Rvcikg LyAxMDApOw0KPj4gQEAgLTE4NCw3ICsxNzEsNyBAQCBoYXNodGFibGVfaW5zZXJ0KHN0cnVj dCBoYXNodGFibGUgKmgsIHZvaWQgKmssIHZvaWQgKnYpDQo+PiDCoMKgwqDCoMKgwqDCoMKg wqDCoCAqIGVsZW1lbnQgbWF5IGJlIG9rLiBOZXh0IHRpbWUgd2UgaW5zZXJ0LCB3ZSdsbCB0 cnkgZXhwYW5kaW5nIGFnYWluLiovDQo+PiDCoMKgwqDCoMKgwqDCoMKgwqAgaGFzaHRhYmxl X2V4cGFuZChoKTsNCj4+IMKgwqDCoMKgwqAgfQ0KPj4gLcKgwqDCoCBlID0gKHN0cnVjdCBl bnRyeSAqKWNhbGxvYygxLCBzaXplb2Yoc3RydWN0IGVudHJ5KSk7DQo+PiArwqDCoMKgIGUg PSB0YWxsb2NfemVybyhoLCBzdHJ1Y3QgZW50cnkpOw0KPj4gwqDCoMKgwqDCoCBpZiAoTlVM TCA9PSBlKSB7IC0tKGgtPmVudHJ5Y291bnQpOyByZXR1cm4gMDsgfSAvKm9vbSovDQo+PiDC oMKgwqDCoMKgIGUtPmggPSBoYXNoKGgsayk7DQo+PiDCoMKgwqDCoMKgIGluZGV4ID0gaW5k ZXhGb3IoaC0+dGFibGVsZW5ndGgsZS0+aCk7DQo+PiBAQCAtMjM4LDggKzIyNSw4IEBAIGhh c2h0YWJsZV9yZW1vdmUoc3RydWN0IGhhc2h0YWJsZSAqaCwgdm9pZCAqaykNCj4+IMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgIGgtPmVudHJ5Y291bnQtLTsNCj4+IMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgIHYgPSBlLT52Ow0KPj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqAgaWYgKGgtPmZsYWdzICYgSEFTSFRBQkxFX0ZSRUVfS0VZKQ0KPj4gLcKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoCBmcmVlKGUtPmspOw0KPj4gLcKgwqDCoMKgwqDCoMKgwqDC oMKgwqAgZnJlZShlKTsNCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgdGFs bG9jX2ZyZWUoZS0+ayk7DQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB0YWxsb2NfZnJl ZShlKTsNCj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiB2Ow0KPj4gwqDC oMKgwqDCoMKgwqDCoMKgIH0NCj4+IMKgwqDCoMKgwqDCoMKgwqDCoCBwRSA9ICYoZS0+bmV4 dCk7DQo+PiBAQCAtMjgwLDI1ICsyNjcsMjAgQEAgdm9pZA0KPj4gwqAgaGFzaHRhYmxlX2Rl c3Ryb3koc3RydWN0IGhhc2h0YWJsZSAqaCkNCj4+IMKgIHsNCj4+IMKgwqDCoMKgwqAgdW5z aWduZWQgaW50IGk7DQo+PiAtwqDCoMKgIHN0cnVjdCBlbnRyeSAqZSwgKmY7DQo+PiArwqDC oMKgIHN0cnVjdCBlbnRyeSAqZTsNCj4+IMKgwqDCoMKgwqAgc3RydWN0IGVudHJ5ICoqdGFi bGUgPSBoLT50YWJsZTsNCj4+IMKgwqDCoMKgwqAgZm9yIChpID0gMDsgaSA8IGgtPnRhYmxl bGVuZ3RoOyBpKyspDQo+PiDCoMKgwqDCoMKgIHsNCj4+IC3CoMKgwqDCoMKgwqDCoCBlID0g dGFibGVbaV07DQo+PiAtwqDCoMKgwqDCoMKgwqAgd2hpbGUgKE5VTEwgIT0gZSkNCj4+ICvC oMKgwqDCoMKgwqDCoCBmb3IgKGUgPSB0YWJsZVtpXTsgZTsgZSA9IGUtPm5leHQpDQo+PiDC oMKgwqDCoMKgwqDCoMKgwqAgew0KPj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZiA9IGU7 DQo+PiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBlID0gZS0+bmV4dDsNCj4+IMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgIGlmIChoLT5mbGFncyAmIEhBU0hUQUJMRV9GUkVFX0tFWSkN Cj4+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZnJlZShmLT5rKTsNCj4+ICvC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgdGFsbG9jX2ZyZWUoZS0+ayk7DQo+PiDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBpZiAoaC0+ZmxhZ3MgJiBIQVNIVEFCTEVfRlJF RV9WQUxVRSkNCj4+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZnJlZShmLT52 KTsNCj4+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGZyZWUoZik7DQo+IA0KPiBBRkFJVSwg dGhlIGxvb3AgaXMgcmV3b3JrZWQgc28geW91IGxldCB0YWxsb2MgdG8gZnJlZSBlYWNoIGVs ZW1lbnQgd2l0aCB0aGUgDQo+IHBhcmVudC4gVXNpbmcgYSB3aGlsZSBsb29wIGlzIGRlZmlu aXRlbHkgY2xlYW5lciwgYnV0IG5vdyB5b3Ugd2lsbCBlbmQgdXAgdG8gDQo+IGhhdmUgdHdv IHNlcGFyYXRlIGxvb3AgZm9yIHRoZSBlbGVtZW50cy4NCj4gDQo+IFRoZXJlIGlzIGEgcmlz ayB0aGF0IHRoZSBvdmVyYWxsIHBlcmZvcm1hbmNlIG9mIGhhc2h0YWJsZV9kZXN0cm95KCkg d2lsbCBiZSANCj4gd29yc2UgYXMgdGhlIGRhdGEgYWNjZXNzZWQgaW4gb25lIGxvb3AgbWF5 IG5vdCBmaXQgaW4gdGhlIGNhY2hlLiBTbyB5b3Ugd2lsbCANCj4gaGF2ZSB0byByZWxvYWQg aXQgb24gdGhlIHNlY29uZCBsb29wLg0KPiANCj4gVGhlcmVmb3JlLCBJIHRoaW5rIGl0IHdv dWxkIGJlIGJldHRlciB0byBrZWVwIHRoZSBsb29wIGFzLWlzLg0KDQpXaGF0IGFib3V0IGEg Y29tcGxldGVseSBkaWZmZXJlbnQgYXBwcm9hY2g/IEkgY291bGQgbWFrZSB0aGUga2V5IGFu ZCB2YWx1ZQ0KdGFsbG9jIGNoaWxkcmVuIG9mIGUgd2hlbiBfaW5zZXJ0aW5nXyB0aGUgZWxl bWVudCBhbmQgdGhlIHJlbGF0ZWQgZmxhZyBpcw0Kc2V0LiBUaGlzIHdvdWxkIHJlZHVjZSBo YXNodGFibGVfZGVzdHJveSB0byBhIHNpbmdsZSB0YWxsb2NfZnJlZSgpLg0KDQoNCkp1ZXJn ZW4NCg== --------------TrpUY8kPg6koMLqXntZ3bvG1 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------TrpUY8kPg6koMLqXntZ3bvG1-- --------------KWXXITPtJ1KDuGIb5mxLsr06-- --------------iFVyoi4bR64KLaI8CtSoZUfV Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmO+gOUFAwAAAAAACgkQsN6d1ii/Ey+v uQf+P5XFFJu4NP1Mq53Wvtwy8CyWDF2MCfNCX9ie51bqX/q8N/+KFNfHYdU1r0qybpGvcntcFhhM tN571xBmd9SDFAmGUJ3m9G8ldVzY39zmXk2MXuDJ4YBw6g4BzmVPuTtUyv5yByVR9I5mo1CYpeN1 O/aCwC2OGZ/K3ThxQVBMchSAnELZgbSBFWnT7sSWEgduoEBIfI68RyqT3QoXYwD/2/9ixdo5JrYM Pn+rYDjb0rdra8I0osBUSG+s6B9+GNxtrupkXfqfybhXf315jMlpTXVyEkbeGVaziTOQJGvc96r+ Z2ymWKtiapHPL372dgjUxKe4YGQxKskYSNJgXfZ3Bg== =0rXS -----END PGP SIGNATURE----- --------------iFVyoi4bR64KLaI8CtSoZUfV-- From xen-devel-bounces@lists.xenproject.org Wed Jan 11 09:49:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 09:49:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475156.736710 (Exim 4.92) (envelope-from ) id 1pFXj4-0000DM-2X; Wed, 11 Jan 2023 09:48:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475156.736710; Wed, 11 Jan 2023 09:48:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFXj3-0000DF-W6; Wed, 11 Jan 2023 09:48:53 +0000 Received: by outflank-mailman (input) for mailman id 475156; Wed, 11 Jan 2023 09:48:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFXj1-0000D9-Th for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 09:48:52 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2080.outbound.protection.outlook.com [40.107.241.80]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 242e3b18-9195-11ed-b8d0-410ff93cb8f0; Wed, 11 Jan 2023 10:48:46 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM8PR04MB7412.eurprd04.prod.outlook.com (2603:10a6:20b:1df::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.12; Wed, 11 Jan 2023 09:48:46 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Wed, 11 Jan 2023 09:48:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 242e3b18-9195-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SF6NnTtLrsJr2SzrT7J8Ho/n+m94qAWfm430rj6MFMIQUc7tSb4DwdqnJ1R1NB+M4CuqIcznr9r9lZvWwsUK3H9ZKC+B/GX1dKg6o0KGMVKUGxMzeVneBe9TKA4567kypnxcAg0edQDfxeas6kiXvHmrvznX9XmkYb/aU9PdEWDX2kjbhSvKjUaK2SP5dABdy/SMKURs0UbhQ5s53K/YZViTZ7yK0xWQk0Dc2ZXQYva3ML1xEjDSyIuT5YY3EibWwcOEvNTY7Wm5qFiQRq91ipnlpb9IgE4x0Dfc9UI5KLo878KqSrJjm698vkYohttzjAEIrCKbepE4aEw6U0Np+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eoZCTYBDdYYKGrLaMH8wVWpss546JEA1sd9sUuWz8iw=; b=KiDqhxp581K872JKra2y430/iY5zm86ZMRDQE2WDQlk5LMf6dUWdvzTfNT1Mq5OvY2epGQA6Qu2Tv3FVgPgl01RXbziMaOBjvnppuN+Nnc5lOVaVH3t00hS+sgERaZ5DPdPj3cYPSWbF0RM3xHhgE1aIA3Lf56IJN8Xh3bh7zl5c1KDTPQyrxGvBIh0uHzGlVs/sG+Ye42CmMu6qrFEJwGeCxknI+EaDX6W8uOOjUHN0Fr5WgvAxGwVljU8F7xUUXdioXNTq3DWQOJ1yGR80JOxZ6BUxJggtzEjaIZKMjIKjhw9H/gDB3H31XhxqD+07/w0rgAzBZ7BXLj/umPVlqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eoZCTYBDdYYKGrLaMH8wVWpss546JEA1sd9sUuWz8iw=; b=nefqHG47PLsLd6GumTbaxX61c/yS4XwF6iPxBs2RXkRMykjGlkymE5HJYAkv66wKA6iWmSkKL4e015CHlvIH1ueDzYXEPeTJbwLvS+DIniFKfrUFv1Ajflvin0LGerI+yuUSLrggr0jhGwiSBbcrZV7e/HZhMy5FQF5lbdeTeFVlnD4HdqUWX9C6YSEhE7oYKPtUhf0xlRE/L6KiYgOFffN8NkwkGXO3qefrkwAT9JQqkkIMF9Tcjuj/mxooFtg3exIcxiRLr28K+RP/B9j+i2sqXclqcjI1gpN5Qe8n7xbJYsPbvYe0LHl7AL0D+hHDkgcHnjf/7Pzbcje9nG+H9g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <999009a1-bfef-3e02-09cd-865ff462c3d8@suse.com> Date: Wed, 11 Jan 2023 10:48:44 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [XEN PATCH] tools: Fix build with recent QEMU, use "--enable-trace-backends" Content-Language: en-US To: Anthony PERARD Cc: Wei Liu , xen-devel@lists.xenproject.org References: <20230110151854.50746-1-anthony.perard@citrix.com> From: Jan Beulich In-Reply-To: <20230110151854.50746-1-anthony.perard@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0162.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM8PR04MB7412:EE_ X-MS-Office365-Filtering-Correlation-Id: f4672d97-838b-47fa-f263-08daf3b9082f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: B1b7uXsO2cXfZug3glU2a8yU4l7Hqbi1sVRxDBYbqp7mVWal+EiP+DAav4U9B1dTN2U7/i+GDoDP8qziT/efO+Pd5kaxdAy8JiehCrdQ/TQo+8y+NXNbYkNl5Zvj+RelAivucYdt16yztEXatFek+W+k42Z8Y6DT5CI/mfWXzNwOqgf0TpE39m+z5djUSy5i9grwGjNcUsa6QQTv/a5PVGn/qy11+WDTIhIz/5/2+UcaFp8ZblhTG6MqxZfvQTwPB1oToMBm3tuSaKJnXQ9DNE/kF5XLlszQc/dSLiuMbkl+8B9GcGqX2lUB3R6ebL3RAm7/yfJwdFXz2dtgtRjbKQGxNtlD3V7J2wXSqLI0Nay4nJrz5YRqobMdev05pW+AYhs09OWlST9A2FNg2sTaOuM+tz6am3BNNxiY/x0HMlP8C+3Y0JsGanf2XgvMTn5YA/XVp2cG+rAn9X0fXIea2wCKaihl/5ELbsgnN1baHYPr6oA9OK0nq3wr9RVLwFU0WfIbGyGgdG5AXwcG6FcgRbemNkoe05Exoep6yLRV0zVoGASpCJzXt6rDWlrtsSQCRgT1C7yby/MLqrDDL/f8i/eWhrv99Fss5DjaTe45uMBblwDMlrTGfuSG9b8vIktkicd1HDd2c502GD2M3hrttGaz1gWkJC9hq8MMin7faxMJ9bZApex/nteYr/Noe0hFy4wbsHtTRVnKj9vEVwmRIIpVWDKxRu6cVtod6y9yHsE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(376002)(346002)(136003)(366004)(39860400002)(451199015)(38100700002)(31696002)(86362001)(36756003)(53546011)(2616005)(6512007)(186003)(316002)(478600001)(6486002)(31686004)(26005)(2906002)(83380400001)(5660300002)(8936002)(4326008)(41300700001)(6506007)(66476007)(66556008)(8676002)(6916009)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a1BFaGpZbXZyYjFUUEJJaHdYendTRnJaQ1JmK3VMejlFL1psZHYvU0JkclVW?= =?utf-8?B?Mno3MC9YZWFORGlZbmpkK25semVvekM0MWFDZW5BVVdFekEwZ3Q5RnVITTl0?= =?utf-8?B?SC9tMlI3ajYrODdJK3pVa1cwL0FVSHY5QUdXb0dmbkVReGMwSHdac0RxVmlK?= =?utf-8?B?SUd4b3FVa3FTcXN4clFVUlQ3ckx0Sjg3MGp4TkxWSDV3ZzFnZ0NxSVVrem81?= =?utf-8?B?SGIzSFkvbmMrM2VXV3BLbmtOS1VCZFRVdERRdmVYSlBvWTg3Z1V0QVRsN2JC?= =?utf-8?B?cHUyMVY4V3BGQXlJUmlUZDk0ZUpTN2VTTkZXd0d0NTJzY1NvNGdDYTJKbzR1?= =?utf-8?B?NGJ3T2dQWTFTZmlNeGl6cndCTmQrbXh2SU9VWmlxQS8vUkRLMWxsNFFyNE9v?= =?utf-8?B?UitiSUNMMGY5TDRtRnlmeEhpcU9Venh2T1FVN0tOS3hrZ2d3ZFdqdmVDWGUx?= =?utf-8?B?alJBUHJ3eHJYRm9MTUZ0M0kwdDhFSjdtQTFmRWhnUUlCalB3WHFHT2FhWFhY?= =?utf-8?B?RjRDd3JWcFJ6R3FEZVJiM09kMXRrVVdMZDlweWxhSjN3KzMvOGdpYy84TDlp?= =?utf-8?B?VlE1bnI0QmJSWURuU1h1a3NobzlDaW1JNXB2SEZoNENuV3hGNEpOZ2VVOW1J?= =?utf-8?B?OGlLSXB6SGdBaXpIM2ZLd21Jdnd4YVBpRlYwckU1ZGpUbXBCV0xaQXpYTlVt?= =?utf-8?B?RVB0RXVzbzRvOWNvNGpwL3lqSjlNVGFhNVdvRHpSQW1vcmRCblRoaW1DT1Bt?= =?utf-8?B?WC8zWWk3MVRTQ0huMzZuL0RRQ01VQlFRbkdxMXE5ck5kc2pzd285VGdYWkgw?= =?utf-8?B?U2NtS25sUVNlbnZldWZuS0tiWjVDTzRFMTJyaVEzK1RaYXl6MEQxVFgxZ1U5?= =?utf-8?B?V0FFbkxiT0Nvbzh6UFoyd01jQU9HTkV4azhHdmpQT3VZaHdNVmtOTFh3SU5s?= =?utf-8?B?T3JCQUpRRWd5ak9rVm8rbm9hT1lPMjVNMjBOUmFCNTQzNEJPN1F5YThURUdK?= =?utf-8?B?MFpMVjRjb2s0b0RBYS8rU0kwc0thVlE3RWpQTGJvRHhRaGZpcW5UMlA0cXA0?= =?utf-8?B?TkV6RW9BQlNudkIwNUR3OVVGdDY0dUxBMFpBRExnMUNYWm1naEozaTJpNlNX?= =?utf-8?B?bGh3MTlkdGx1d1N2Um9wWVVTdVJVSkxZYmk2Mk5qRUE5MnZ1dTZvMEM0cVJn?= =?utf-8?B?VkFVdlN0dVlob0VabFYxOGU3WmpudnFHdndScldtN2svb3g3QmRQODZEdXVJ?= =?utf-8?B?aU9iczIrNGo0eFJ3Rk9FRHpCU1V3NWtYM0wvYTdrUDlJN1RaVnN3RUZHOXFp?= =?utf-8?B?dUpsSWhVTy9mM1ZLb1VGdzFEaHBOK1NoUldDK1VYejJ3Uyt0M0lPbjRiTEtl?= =?utf-8?B?aTFJaVF0N1h4Umh5cXc0dWtUdmgzWEw4d29VZzZLT1VKVElFMVNUWU42ajZQ?= =?utf-8?B?THFpVWpjSUdQS1BkTkVEMlhoc0tYM2Q4WFVYTHpPSFhTZll3c2lQZ0RrbHdj?= =?utf-8?B?U3lBWUczWEo1azZFRVJjWkRnWjNvWDFVQnk0TTNJTktkVElkZzZFUng3SEhy?= =?utf-8?B?MW5HdW5CMHNZNXo0YmZ3eGFnTHEvT0VpUmRNSzNlK09pc2d4akxRRk1hWGFG?= =?utf-8?B?cEtFck5JdU9WV3R1UUNnV1ZXbFdwUlFwTnRoRGlMcnBSMWVTZlpPU0ZjdjZO?= =?utf-8?B?SDlWQzVYakMwNVJ5K1FBKzJ0R2tlWklwT2hucE1DOFd0UTNJSEtGdEhXNzBU?= =?utf-8?B?VUo3TTZocjNiZ09lZEYvQUFxU2ZlQW9Tc256RTVtTlpRWmZERnA4U0JxdWZZ?= =?utf-8?B?VWFqdkFtdlpRQ3BhL1JlM0NMRk1QQlZRUUtrVWl6dmFCT1J6NUhwRWQydWkw?= =?utf-8?B?ZVlMbXRCNThPaSt3Y0VYc3MwM1ZzVXY4SEVwb0VHREg5aEFvMDFDVDBxUGhx?= =?utf-8?B?clRjeHVqMFVFOTRjek5DVmE3cTRvWkVlVzlHZGZ1cDJiR282YXNwTGZkU21q?= =?utf-8?B?Wi9rYjh1dVE4SndKNys4VHJwZld2Y2RpVFhBd1JSLzJOUXR6bENMaUdWb1Vh?= =?utf-8?B?akRteWZNUzlWRnU4YjRkbmF5R2twc3laZTlFTzZhb1VTSWQydDRiR05hY21u?= =?utf-8?Q?HXgQQ09s+vGWIOhzEAbYe3eba?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f4672d97-838b-47fa-f263-08daf3b9082f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2023 09:48:46.1174 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: J2EGgGcWWTDAM6KtGLMAXyZD5kBTFWXkbCUWPp34YYWygI6zdDUjafXfTogu6AdbTI66xIIeXkRulq5gPfd4xQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7412 On 10.01.2023 16:18, Anthony PERARD wrote: > The configure option "--enable-trace-backend" isn't accepted anymore > and we should use "--enable-trace-backends" instead which was > introduce in 2014 and allow multiple backends. > > "--enable-trace-backends" was introduced by: > 5b808275f3bb ("trace: Multi-backend tracing") > The backward compatible option "--enable-trace-backend" is removed by > 10229ec3b0ff ("configure: remove backwards-compatibility and obsolete options") > > As we already use ./configure options that wouldn't be accepted by > older version of QEMU's configure, we will simply use the new spelling > for the option and avoid trying to detect which spelling to use. > > We already make use if "--firmwarepath=" which was introduced by > 3d5eecab4a5a ("Add --firmwarepath to configure") > which already include the new spelling for "--enable-trace-backends". > > Signed-off-by: Anthony PERARD I've committed this, and I'll queue this for backporting unless you (or anyone else) tell(s) me otherwise. Jan From xen-devel-bounces@lists.xenproject.org Wed Jan 11 09:52:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 09:52:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475162.736721 (Exim 4.92) (envelope-from ) id 1pFXmb-0001b7-IE; Wed, 11 Jan 2023 09:52:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475162.736721; Wed, 11 Jan 2023 09:52:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFXmb-0001b0-Fa; Wed, 11 Jan 2023 09:52:33 +0000 Received: by outflank-mailman (input) for mailman id 475162; Wed, 11 Jan 2023 09:52:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFXmZ-0001ao-Ch; Wed, 11 Jan 2023 09:52:31 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFXmZ-0002tw-8k; Wed, 11 Jan 2023 09:52:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFXmY-0000kT-Sp; Wed, 11 Jan 2023 09:52:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pFXmY-0004Iv-SD; Wed, 11 Jan 2023 09:52:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=8DHp1X0Zv2wIFfRo6BA3+CmJ9GiFHdoswGNA2MKM0EY=; b=y71UQilISbE6BLhJyxm7IQRJJg j83CEZf9ENpH88a9ZV3SM2TcG7zVsHlHc8O4kdK/wQrVMpwEGAl6gePxwdoKEtssFkCPtqm9Oa4r3 4LjlpEfSzrFxT4ZesBn7hwdH4FVpphFTSn8x2Ub0UuOohlRzTvalKNAkIhqIkMkZVpMw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 175719: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-amd64-xsm:xen-build:fail:regression qemu-mainline:build-amd64:xen-build:fail:regression qemu-mainline:build-i386:xen-build:fail:regression qemu-mainline:build-arm64-xsm:xen-build:fail:regression qemu-mainline:build-i386-xsm:xen-build:fail:regression qemu-mainline:build-arm64:xen-build:fail:regression qemu-mainline:build-armhf:xen-build:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-coresched-amd64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:build-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-rtds:build-check(1):blocked:nonblocking qemu-mainline:build-arm64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking qemu-mainline:build-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking qemu-mainline:build-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-dom0pvh-xl-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-dom0pvh-xl-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvshim:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-pygrub:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvhv2-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-freebsd11-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-freebsd12-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvhv2-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-multivcpu:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: qemuu=aa96ab7c9df59c615ca82b49c9062819e0a1c287 X-Osstest-Versions-That: qemuu=0ab12aa32462817f0a53fa6f6ce4baf664ef1713 From: osstest service owner Date: Wed, 11 Jan 2023 09:52:30 +0000 flight 175719 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/175719/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 175623 build-amd64 6 xen-build fail REGR. vs. 175623 build-i386 6 xen-build fail REGR. vs. 175623 build-arm64-xsm 6 xen-build fail REGR. vs. 175623 build-i386-xsm 6 xen-build fail REGR. vs. 175623 build-arm64 6 xen-build fail REGR. vs. 175623 build-armhf 6 xen-build fail REGR. vs. 175623 Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-win7-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ws16-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-shadow 1 build-check(1) blocked n/a test-amd64-i386-xl-vhd 1 build-check(1) blocked n/a test-amd64-i386-xl-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) blocked n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) blocked n/a test-armhf-armhf-xl-rtds 1 build-check(1) blocked n/a test-armhf-armhf-xl-vhd 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-amd 1 build-check(1) blocked n/a test-amd64-i386-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-i386 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-amd64 1 build-check(1) blocked n/a test-amd64-coresched-i386-xl 1 build-check(1) blocked n/a test-amd64-coresched-amd64-xl 1 build-check(1) blocked n/a test-amd64-amd64-xl-xsm 1 build-check(1) blocked n/a build-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-shadow 1 build-check(1) blocked n/a test-amd64-amd64-xl-rtds 1 build-check(1) blocked n/a build-arm64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ws16-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a build-armhf-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-amd64-dom0pvh-xl-amd 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 1 build-check(1) blocked n/a test-amd64-amd64-dom0pvh-xl-intel 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvshim 1 build-check(1) blocked n/a test-amd64-amd64-pair 1 build-check(1) blocked n/a test-amd64-amd64-pygrub 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvhv2-intel 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-freebsd11-amd64 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-freebsd12-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvhv2-amd 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-nested-amd 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-nested-intel 1 build-check(1) blocked n/a test-amd64-amd64-xl-multivcpu 1 build-check(1) blocked n/a test-amd64-amd64-xl 1 build-check(1) blocked n/a test-amd64-amd64-xl-credit1 1 build-check(1) blocked n/a test-amd64-amd64-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 1 build-check(1) blocked n/a test-armhf-armhf-xl-arndale 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-intel 1 build-check(1) blocked n/a test-amd64-i386-xl 1 build-check(1) blocked n/a test-amd64-i386-xl-pvshim 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a version targeted for testing: qemuu aa96ab7c9df59c615ca82b49c9062819e0a1c287 baseline version: qemuu 0ab12aa32462817f0a53fa6f6ce4baf664ef1713 Last test of basis 175623 2023-01-07 23:09:00 Z 3 days Failing since 175627 2023-01-08 14:40:14 Z 2 days 14 attempts Testing same since 175654 2023-01-09 18:08:58 Z 1 days 9 attempts ------------------------------------------------------------ People who touched revisions under test: Ard Biesheuvel Bernhard Beschow Christian Borntraeger Cindy Lu Dongli Zhang Eugenio Pérez Greg Kurz Guoyi Tu Hyman Huang(黄勇) Igor Mammedov Jason Wang Jonathan Cameron Kai Huang Laszlo Ersek Lei Xiang leixiang Liuxiangdong Longpeng Lubomir Rintel Marc-André Lureau Markus Armbruster Michael S. Tsirkin Nikita Ivanov Paolo Bonzini Peter Maydell Philippe Mathieu-Daudé Richard Henderson Thomas Huth Yanan Wang Yicong Yang Zeng Chi jobs: build-amd64-xsm fail build-arm64-xsm fail build-i386-xsm fail build-amd64 fail build-arm64 fail build-armhf fail build-i386 fail build-amd64-libvirt blocked build-arm64-libvirt blocked build-armhf-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl blocked test-amd64-coresched-amd64-xl blocked test-arm64-arm64-xl blocked test-armhf-armhf-xl blocked test-amd64-i386-xl blocked test-amd64-coresched-i386-xl blocked test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm blocked test-amd64-i386-xl-qemuu-debianhvm-i386-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm blocked test-arm64-arm64-xl-xsm blocked test-amd64-i386-xl-xsm blocked test-amd64-amd64-qemuu-nested-amd blocked test-amd64-amd64-xl-pvhv2-amd blocked test-amd64-i386-qemuu-rhel6hvm-amd blocked test-amd64-amd64-dom0pvh-xl-amd blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64 blocked test-amd64-i386-xl-qemuu-debianhvm-amd64 blocked test-amd64-i386-freebsd10-amd64 blocked test-amd64-amd64-qemuu-freebsd11-amd64 blocked test-amd64-amd64-qemuu-freebsd12-amd64 blocked test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked test-amd64-amd64-xl-qemuu-win7-amd64 blocked test-amd64-i386-xl-qemuu-win7-amd64 blocked test-amd64-amd64-xl-qemuu-ws16-amd64 blocked test-amd64-i386-xl-qemuu-ws16-amd64 blocked test-armhf-armhf-xl-arndale blocked test-amd64-amd64-xl-credit1 blocked test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 blocked test-amd64-amd64-xl-credit2 blocked test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 blocked test-armhf-armhf-xl-cubietruck blocked test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict blocked test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict blocked test-amd64-i386-freebsd10-i386 blocked test-amd64-amd64-qemuu-nested-intel blocked test-amd64-amd64-xl-pvhv2-intel blocked test-amd64-i386-qemuu-rhel6hvm-intel blocked test-amd64-amd64-dom0pvh-xl-intel blocked test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu blocked test-armhf-armhf-xl-multivcpu blocked test-amd64-amd64-pair blocked test-amd64-i386-pair blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim blocked test-amd64-i386-xl-pvshim blocked test-amd64-amd64-pygrub blocked test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds blocked test-armhf-armhf-xl-rtds blocked test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow blocked test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow blocked test-amd64-amd64-xl-shadow blocked test-amd64-i386-xl-shadow blocked test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd blocked test-amd64-i386-xl-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2556 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Jan 11 10:00:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 10:00:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475171.736732 (Exim 4.92) (envelope-from ) id 1pFXuW-0003DF-G8; Wed, 11 Jan 2023 10:00:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475171.736732; Wed, 11 Jan 2023 10:00:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFXuW-0003D8-DT; Wed, 11 Jan 2023 10:00:44 +0000 Received: by outflank-mailman (input) for mailman id 475171; Wed, 11 Jan 2023 10:00:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFXuV-0003D1-Bx for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 10:00:43 +0000 Received: from casper.infradead.org (casper.infradead.org [2001:8b0:10b:1236::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ccd4d554-9196-11ed-b8d0-410ff93cb8f0; Wed, 11 Jan 2023 11:00:38 +0100 (CET) Received: from [2001:8b0:10b:5::bb3] (helo=u3832b3a9db3152.ant.amazon.com) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFXuT-00417y-Mq; Wed, 11 Jan 2023 10:00:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ccd4d554-9196-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=MIME-Version:Content-Type:References: In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=gtUnWvOq0Tv3Rog3AzXlM5oDAQWs+ZNGSYH5rPHcNOw=; b=W/bVxTZCRA/CwxLvzV2a6CwDA2 VozrtnsiBnXzk6jMDQuM5KtWTO6kWiv4R77u/QA95YIudRUknFdt+TVcA50WJonqoz1FOH76o13L3 dUfSGsPD+2HCf+p685OHQBq4mpIabi7a5e3KprmmzVu6Y+HFahCvcPsB5EBqghbnDE5TaUPhUcGTJ WmFMM5JVaM/5ur5QBTofs19XG8Byz1B73Mvt0dO3qX9C8bbOJTqK80vddwt4Hf6TWMwaWEXzkz5Xc 7KdSo2f6vxFSLZJ5etFSRnSn28Y3vaXvKD54nixu1SDAuFmDcK3yxUDQwbkjgjJ3UnJd+GHnoktVu q/GWZ4dA==; Message-ID: <7cd31f8e7d5ec4658ab8e945c2b771fd55a0b101.camel@infradead.org> Subject: Re: [PATCH v7 1/2] KVM: x86/cpuid: generalize kvm_update_kvm_cpuid_base() and also capture limit From: David Woodhouse To: Paul Durrant , x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Sean Christopherson , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen Date: Wed, 11 Jan 2023 10:00:27 +0000 In-Reply-To: <20230106103600.528-2-pdurrant@amazon.com> References: <20230106103600.528-1-pdurrant@amazon.com> <20230106103600.528-2-pdurrant@amazon.com> Content-Type: multipart/signed; micalg="sha-256"; protocol="application/pkcs7-signature"; boundary="=-f3qb3SVQBInmnod430iv" User-Agent: Evolution 3.44.4-0ubuntu1 MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html --=-f3qb3SVQBInmnod430iv Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2023-01-06 at 10:35 +0000, Paul Durrant wrote: > A subsequent patch will need to acquire the CPUID leaf range for emulated > Xen so explicitly pass the signature of the hypervisor we're interested i= n > to the new function. Also introduce a new kvm_hypervisor_cpuid structure > so we can neatly store both the base and limit leaf indices. >=20 > Signed-off-by: Paul Durrant > --- Reviewed-by: David Woodhouse --=-f3qb3SVQBInmnod430iv Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Disposition: attachment; filename="smime.p7s" Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCCEkQw ggYQMIID+KADAgECAhBNlCwQ1DvglAnFgS06KwZPMA0GCSqGSIb3DQEBDAUAMIGIMQswCQYDVQQG EwJVUzETMBEGA1UECBMKTmV3IEplcnNleTEUMBIGA1UEBxMLSmVyc2V5IENpdHkxHjAcBgNVBAoT FVRoZSBVU0VSVFJVU1QgTmV0d29yazEuMCwGA1UEAxMlVVNFUlRydXN0IFJTQSBDZXJ0aWZpY2F0 aW9uIEF1dGhvcml0eTAeFw0xODExMDIwMDAwMDBaFw0zMDEyMzEyMzU5NTlaMIGWMQswCQYDVQQG EwJHQjEbMBkGA1UECBMSR3JlYXRlciBNYW5jaGVzdGVyMRAwDgYDVQQHEwdTYWxmb3JkMRgwFgYD VQQKEw9TZWN0aWdvIExpbWl0ZWQxPjA8BgNVBAMTNVNlY3RpZ28gUlNBIENsaWVudCBBdXRoZW50 aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKC AQEAyjztlApB/975Rrno1jvm2pK/KxBOqhq8gr2+JhwpKirSzZxQgT9tlC7zl6hn1fXjSo5MqXUf ItMltrMaXqcESJuK8dtK56NCSrq4iDKaKq9NxOXFmqXX2zN8HHGjQ2b2Xv0v1L5Nk1MQPKA19xeW QcpGEGFUUd0kN+oHox+L9aV1rjfNiCj3bJk6kJaOPabPi2503nn/ITX5e8WfPnGw4VuZ79Khj1YB rf24k5Ee1sLTHsLtpiK9OjG4iQRBdq6Z/TlVx/hGAez5h36bBJMxqdHLpdwIUkTqT8se3ed0PewD ch/8kHPo5fZl5u1B0ecpq/sDN/5sCG52Ds+QU5O5EwIDAQABo4IBZDCCAWAwHwYDVR0jBBgwFoAU U3m/WqorSs9UgOHYm8Cd8rIDZsswHQYDVR0OBBYEFAnA8vwL2pTbX/4r36iZQs/J4K0AMA4GA1Ud DwEB/wQEAwIBhjASBgNVHRMBAf8ECDAGAQH/AgEAMB0GA1UdJQQWMBQGCCsGAQUFBwMCBggrBgEF BQcDBDARBgNVHSAECjAIMAYGBFUdIAAwUAYDVR0fBEkwRzBFoEOgQYY/aHR0cDovL2NybC51c2Vy dHJ1c3QuY29tL1VTRVJUcnVzdFJTQUNlcnRpZmljYXRpb25BdXRob3JpdHkuY3JsMHYGCCsGAQUF BwEBBGowaDA/BggrBgEFBQcwAoYzaHR0cDovL2NydC51c2VydHJ1c3QuY29tL1VTRVJUcnVzdFJT QUFkZFRydXN0Q0EuY3J0MCUGCCsGAQUFBzABhhlodHRwOi8vb2NzcC51c2VydHJ1c3QuY29tMA0G CSqGSIb3DQEBDAUAA4ICAQBBRHUAqznCFfXejpVtMnFojADdF9d6HBA4kMjjsb0XMZHztuOCtKF+ xswhh2GqkW5JQrM8zVlU+A2VP72Ky2nlRA1GwmIPgou74TZ/XTarHG8zdMSgaDrkVYzz1g3nIVO9 IHk96VwsacIvBF8JfqIs+8aWH2PfSUrNxP6Ys7U0sZYx4rXD6+cqFq/ZW5BUfClN/rhk2ddQXyn7 kkmka2RQb9d90nmNHdgKrwfQ49mQ2hWQNDkJJIXwKjYA6VUR/fZUFeCUisdDe/0ABLTI+jheXUV1 eoYV7lNwNBKpeHdNuO6Aacb533JlfeUHxvBz9OfYWUiXu09sMAviM11Q0DuMZ5760CdO2VnpsXP4 KxaYIhvqPqUMWqRdWyn7crItNkZeroXaecG03i3mM7dkiPaCkgocBg0EBYsbZDZ8bsG3a08LwEsL 1Ygz3SBsyECa0waq4hOf/Z85F2w2ZpXfP+w8q4ifwO90SGZZV+HR/Jh6rEaVPDRF/CEGVqR1hiuQ OZ1YL5ezMTX0ZSLwrymUE0pwi/KDaiYB15uswgeIAcA6JzPFf9pLkAFFWs1QNyN++niFhsM47qod x/PL+5jR87myx5uYdBEQkkDc+lKB1Wct6ucXqm2EmsaQ0M95QjTmy+rDWjkDYdw3Ms6mSWE3Bn7i 5ZgtwCLXgAIe5W8mybM2JzCCBhQwggT8oAMCAQICEQDGvhmWZ0DEAx0oURL6O6l+MA0GCSqGSIb3 DQEBCwUAMIGWMQswCQYDVQQGEwJHQjEbMBkGA1UECBMSR3JlYXRlciBNYW5jaGVzdGVyMRAwDgYD VQQHEwdTYWxmb3JkMRgwFgYDVQQKEw9TZWN0aWdvIExpbWl0ZWQxPjA8BgNVBAMTNVNlY3RpZ28g UlNBIENsaWVudCBBdXRoZW50aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBMB4XDTIyMDEwNzAw MDAwMFoXDTI1MDEwNjIzNTk1OVowJDEiMCAGCSqGSIb3DQEJARYTZHdtdzJAaW5mcmFkZWFkLm9y ZzCCAiIwDQYJKoZIhvcNAQEBBQADggIPADCCAgoCggIBALQ3GpC2bomUqk+91wLYBzDMcCj5C9m6 oZaHwvmIdXftOgTbCJXADo6G9T7BBAebw2JV38EINgKpy/ZHh7htyAkWYVoFsFPrwHounto8xTsy SSePMiPlmIdQ10BcVSXMUJ3Juu16GlWOnAMJY2oYfEzmE7uT9YgcBqKCo65pTFmOnR/VVbjJk4K2 xE34GC2nAdUQkPFuyaFisicc6HRMOYXPuF0DuwITEKnjxgNjP+qDrh0db7PAjO1D4d5ftfrsf+kd RR4gKVGSk8Tz2WwvtLAroJM4nXjNPIBJNT4w/FWWc/5qPHJy2U+eITZ5LLE5s45mX2oPFknWqxBo bQZ8a9dsZ3dSPZBvE9ZrmtFLrVrN4eo1jsXgAp1+p7bkfqd3BgBEmfsYWlBXO8rVXfvPgLs32VdV NZxb/CDWPqBsiYv0Hv3HPsz07j5b+/cVoWqyHDKzkaVbxfq/7auNVRmPB3v5SWEsH8xi4Bez2V9U KxfYCnqsjp8RaC2/khxKt0A552Eaxnz/4ly/2C7wkwTQnBmdlFYhAflWKQ03Ufiu8t3iBE3VJbc2 5oMrglj7TRZrmKq3CkbFnX0fyulB+kHimrt6PIWn7kgyl9aelIl6vtbhMA+l0nfrsORMa4kobqQ5 C5rveVgmcIad67EDa+UqEKy/GltUwlSh6xy+TrK1tzDvAgMBAAGjggHMMIIByDAfBgNVHSMEGDAW gBQJwPL8C9qU21/+K9+omULPyeCtADAdBgNVHQ4EFgQUzMeDMcimo0oz8o1R1Nver3ZVpSkwDgYD VR0PAQH/BAQDAgWgMAwGA1UdEwEB/wQCMAAwHQYDVR0lBBYwFAYIKwYBBQUHAwQGCCsGAQUFBwMC MEAGA1UdIAQ5MDcwNQYMKwYBBAGyMQECAQEBMCUwIwYIKwYBBQUHAgEWF2h0dHBzOi8vc2VjdGln by5jb20vQ1BTMFoGA1UdHwRTMFEwT6BNoEuGSWh0dHA6Ly9jcmwuc2VjdGlnby5jb20vU2VjdGln b1JTQUNsaWVudEF1dGhlbnRpY2F0aW9uYW5kU2VjdXJlRW1haWxDQS5jcmwwgYoGCCsGAQUFBwEB BH4wfDBVBggrBgEFBQcwAoZJaHR0cDovL2NydC5zZWN0aWdvLmNvbS9TZWN0aWdvUlNBQ2xpZW50 QXV0aGVudGljYXRpb25hbmRTZWN1cmVFbWFpbENBLmNydDAjBggrBgEFBQcwAYYXaHR0cDovL29j c3Auc2VjdGlnby5jb20wHgYDVR0RBBcwFYETZHdtdzJAaW5mcmFkZWFkLm9yZzANBgkqhkiG9w0B AQsFAAOCAQEAyW6MUir5dm495teKqAQjDJwuFCi35h4xgnQvQ/fzPXmtR9t54rpmI2TfyvcKgOXp qa7BGXNFfh1JsqexVkIqZP9uWB2J+uVMD+XZEs/KYNNX2PvIlSPrzIB4Z2wyIGQpaPLlYflrrVFK v9CjT2zdqvy2maK7HKOQRt3BiJbVG5lRiwbbygldcALEV9ChWFfgSXvrWDZspnU3Gjw/rMHrGnql Htlyebp3pf3fSS9kzQ1FVtVIDrL6eqhTwJxe+pXSMMqFiN0whpBtXdyDjzBtQTaZJ7zTT/vlehc/ tDuqZwGHm/YJy883Ll+GP3NvOkgaRGWEuYWJJ6hFCkXYjyR9IzCCBhQwggT8oAMCAQICEQDGvhmW Z0DEAx0oURL6O6l+MA0GCSqGSIb3DQEBCwUAMIGWMQswCQYDVQQGEwJHQjEbMBkGA1UECBMSR3Jl YXRlciBNYW5jaGVzdGVyMRAwDgYDVQQHEwdTYWxmb3JkMRgwFgYDVQQKEw9TZWN0aWdvIExpbWl0 ZWQxPjA8BgNVBAMTNVNlY3RpZ28gUlNBIENsaWVudCBBdXRoZW50aWNhdGlvbiBhbmQgU2VjdXJl IEVtYWlsIENBMB4XDTIyMDEwNzAwMDAwMFoXDTI1MDEwNjIzNTk1OVowJDEiMCAGCSqGSIb3DQEJ ARYTZHdtdzJAaW5mcmFkZWFkLm9yZzCCAiIwDQYJKoZIhvcNAQEBBQADggIPADCCAgoCggIBALQ3 GpC2bomUqk+91wLYBzDMcCj5C9m6oZaHwvmIdXftOgTbCJXADo6G9T7BBAebw2JV38EINgKpy/ZH h7htyAkWYVoFsFPrwHounto8xTsySSePMiPlmIdQ10BcVSXMUJ3Juu16GlWOnAMJY2oYfEzmE7uT 9YgcBqKCo65pTFmOnR/VVbjJk4K2xE34GC2nAdUQkPFuyaFisicc6HRMOYXPuF0DuwITEKnjxgNj P+qDrh0db7PAjO1D4d5ftfrsf+kdRR4gKVGSk8Tz2WwvtLAroJM4nXjNPIBJNT4w/FWWc/5qPHJy 2U+eITZ5LLE5s45mX2oPFknWqxBobQZ8a9dsZ3dSPZBvE9ZrmtFLrVrN4eo1jsXgAp1+p7bkfqd3 BgBEmfsYWlBXO8rVXfvPgLs32VdVNZxb/CDWPqBsiYv0Hv3HPsz07j5b+/cVoWqyHDKzkaVbxfq/ 7auNVRmPB3v5SWEsH8xi4Bez2V9UKxfYCnqsjp8RaC2/khxKt0A552Eaxnz/4ly/2C7wkwTQnBmd lFYhAflWKQ03Ufiu8t3iBE3VJbc25oMrglj7TRZrmKq3CkbFnX0fyulB+kHimrt6PIWn7kgyl9ae lIl6vtbhMA+l0nfrsORMa4kobqQ5C5rveVgmcIad67EDa+UqEKy/GltUwlSh6xy+TrK1tzDvAgMB AAGjggHMMIIByDAfBgNVHSMEGDAWgBQJwPL8C9qU21/+K9+omULPyeCtADAdBgNVHQ4EFgQUzMeD Mcimo0oz8o1R1Nver3ZVpSkwDgYDVR0PAQH/BAQDAgWgMAwGA1UdEwEB/wQCMAAwHQYDVR0lBBYw FAYIKwYBBQUHAwQGCCsGAQUFBwMCMEAGA1UdIAQ5MDcwNQYMKwYBBAGyMQECAQEBMCUwIwYIKwYB BQUHAgEWF2h0dHBzOi8vc2VjdGlnby5jb20vQ1BTMFoGA1UdHwRTMFEwT6BNoEuGSWh0dHA6Ly9j cmwuc2VjdGlnby5jb20vU2VjdGlnb1JTQUNsaWVudEF1dGhlbnRpY2F0aW9uYW5kU2VjdXJlRW1h aWxDQS5jcmwwgYoGCCsGAQUFBwEBBH4wfDBVBggrBgEFBQcwAoZJaHR0cDovL2NydC5zZWN0aWdv LmNvbS9TZWN0aWdvUlNBQ2xpZW50QXV0aGVudGljYXRpb25hbmRTZWN1cmVFbWFpbENBLmNydDAj BggrBgEFBQcwAYYXaHR0cDovL29jc3Auc2VjdGlnby5jb20wHgYDVR0RBBcwFYETZHdtdzJAaW5m cmFkZWFkLm9yZzANBgkqhkiG9w0BAQsFAAOCAQEAyW6MUir5dm495teKqAQjDJwuFCi35h4xgnQv Q/fzPXmtR9t54rpmI2TfyvcKgOXpqa7BGXNFfh1JsqexVkIqZP9uWB2J+uVMD+XZEs/KYNNX2PvI lSPrzIB4Z2wyIGQpaPLlYflrrVFKv9CjT2zdqvy2maK7HKOQRt3BiJbVG5lRiwbbygldcALEV9Ch WFfgSXvrWDZspnU3Gjw/rMHrGnqlHtlyebp3pf3fSS9kzQ1FVtVIDrL6eqhTwJxe+pXSMMqFiN0w hpBtXdyDjzBtQTaZJ7zTT/vlehc/tDuqZwGHm/YJy883Ll+GP3NvOkgaRGWEuYWJJ6hFCkXYjyR9 IzGCBMcwggTDAgEBMIGsMIGWMQswCQYDVQQGEwJHQjEbMBkGA1UECBMSR3JlYXRlciBNYW5jaGVz dGVyMRAwDgYDVQQHEwdTYWxmb3JkMRgwFgYDVQQKEw9TZWN0aWdvIExpbWl0ZWQxPjA8BgNVBAMT NVNlY3RpZ28gUlNBIENsaWVudCBBdXRoZW50aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBAhEA xr4ZlmdAxAMdKFES+jupfjANBglghkgBZQMEAgEFAKCCAeswGAYJKoZIhvcNAQkDMQsGCSqGSIb3 DQEHATAcBgkqhkiG9w0BCQUxDxcNMjMwMTExMTAwMDI3WjAvBgkqhkiG9w0BCQQxIgQgLVDKcKpc s/0Xl+zEpzb59ornBDJqO0R8sz9mYsHaa+owgb0GCSsGAQQBgjcQBDGBrzCBrDCBljELMAkGA1UE BhMCR0IxGzAZBgNVBAgTEkdyZWF0ZXIgTWFuY2hlc3RlcjEQMA4GA1UEBxMHU2FsZm9yZDEYMBYG A1UEChMPU2VjdGlnbyBMaW1pdGVkMT4wPAYDVQQDEzVTZWN0aWdvIFJTQSBDbGllbnQgQXV0aGVu dGljYXRpb24gYW5kIFNlY3VyZSBFbWFpbCBDQQIRAMa+GZZnQMQDHShREvo7qX4wgb8GCyqGSIb3 DQEJEAILMYGvoIGsMIGWMQswCQYDVQQGEwJHQjEbMBkGA1UECBMSR3JlYXRlciBNYW5jaGVzdGVy MRAwDgYDVQQHEwdTYWxmb3JkMRgwFgYDVQQKEw9TZWN0aWdvIExpbWl0ZWQxPjA8BgNVBAMTNVNl Y3RpZ28gUlNBIENsaWVudCBBdXRoZW50aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBAhEAxr4Z lmdAxAMdKFES+jupfjANBgkqhkiG9w0BAQEFAASCAgCnMR6Zpf9PuUzry9agQlFeDFJ9824fgOPU QjTNjVgEmb6oHW06B53qOlhnU/Jf1t9+JTpID4GfOwO67Xc1Hj2Za0sOouHWWSpSVKt6ynO2G7I4 xj0Bsdr9iQTm/PBYo1t42lrMikj55LK60XteEjAvt0w7tKSerdQKUAcG8PYjBY1VQfD9FLHzoIbs o+qJfneWp8QLFyx8M6fJsKMyJ20+rYUAGRxdfTkk4fkjW/RYW1D2d9j15y5DwI0WAFztZZugA35T peQZYKpDzQGT1OJ9wY5mnS7CRqmXGabk0R0xegjtgv3SbkjreO834yhl9yPvlwJUJ4L+wyZqAMXs 4vKZqQonc5nmyTdcXJt5qskpMKBMVcN50/Xc8VC1yXeRqWP3ZCiuyDCydQvUnl5utqIQArxI0zhf 6WrnFOI9cl/1BGeTDAk3YKxnzjB696iBADIlqfpBKERS6ZT3maAvuFgsKpDcHXCs3B5qkEW1qizT uu/nz1vSdG/8ShRhkBJ9eYvsyv1OUBJvtDA+WCaZL/E9jV612X1tSZGlMNYbz3nH0Y+r/fce6zu2 hX20NrFIbY80NyjHgVBFFtKHwA67Y4EFkmccFdBkx3LRqtagyrfMTfHBTpQSEHPpGCfRLy62fuQy U2Jr1x4txafZ38DYH2cSdWYR9ORtZa2O/ahNku+6vQAAAAAAAA== --=-f3qb3SVQBInmnod430iv-- From xen-devel-bounces@lists.xenproject.org Wed Jan 11 10:01:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 10:01:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475172.736744 (Exim 4.92) (envelope-from ) id 1pFXuo-0003Xp-P5; Wed, 11 Jan 2023 10:01:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475172.736744; Wed, 11 Jan 2023 10:01:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFXuo-0003Xg-MN; Wed, 11 Jan 2023 10:01:02 +0000 Received: by outflank-mailman (input) for mailman id 475172; Wed, 11 Jan 2023 10:01:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFXun-0003Vu-8y for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 10:01:01 +0000 Received: from casper.infradead.org (casper.infradead.org [2001:8b0:10b:1236::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d9798001-9196-11ed-91b6-6bf2151ebd3b; Wed, 11 Jan 2023 11:01:00 +0100 (CET) Received: from [2001:8b0:10b:5::bb3] (helo=u3832b3a9db3152.infradead.org) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFXuq-00419Q-AI; Wed, 11 Jan 2023 10:01:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d9798001-9196-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=MIME-Version:Content-Type:References: In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=QTPVTKNqATKtQW82I4C8pCyzH/+bIzUEXeJ6Ghw5pok=; b=P3kcRxE7uzo+Y8dmUu/iJrK7hl F8osY8n0VaDEt2J7x4qBbijTBIWKJO2362zN+eZ1WVjg+nc0z3pim5m5VGIYfiuLovCRyHZ1bZeed b2y4kSw1J/x2MCWfWs03QJPo7bwKwvy2X56W4EDJvNEvfLNperiG6Y3y0vOjSaqxD3qQnXn2FlSmA Ej8vbmSY7sDXWvxuD8feT8IYJ4HphQ0M5jfFCUHj5sgXWJp7F1F5NajARqcFpJRlDogNXzJ8GgVaS Al2e6qISqxRSGJoECde9WfgDX1Z3ueZRCkIqVaTgF+i/wHGWKihxhXgYzXlB3XxOGZtKfAMr3Mph3 zGoFDBbg==; Message-ID: <477edcdff6507e35793c1cb9a97101d01425cff9.camel@infradead.org> Subject: Re: [PATCH v7 2/2] KVM: x86/xen: update Xen CPUID Leaf 4 (tsc info) sub-leaves, if present From: David Woodhouse To: Paul Durrant , x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Sean Christopherson , Paolo Bonzini , Juergen Gross , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" Date: Wed, 11 Jan 2023 10:00:50 +0000 In-Reply-To: <20230106103600.528-3-pdurrant@amazon.com> References: <20230106103600.528-1-pdurrant@amazon.com> <20230106103600.528-3-pdurrant@amazon.com> Content-Type: multipart/signed; micalg="sha-256"; protocol="application/pkcs7-signature"; boundary="=-sPgM3fl2soxIlK/U1gLd" User-Agent: Evolution 3.44.4-0ubuntu1 MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html --=-sPgM3fl2soxIlK/U1gLd Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2023-01-06 at 10:36 +0000, Paul Durrant wrote: > The scaling information in subleaf 1 should match the values set by KVM i= n > the 'vcpu_info' sub-structure 'time_info' (a.k.a. pvclock_vcpu_time_info) > which is shared with the guest, but is not directly available to the VMM. > The offset values are not set since a TSC offset is already applied. > The TSC frequency should also be set in sub-leaf 2. >=20 > Signed-off-by: Paul Durrant > --- Reviewed-by: David Woodhouse --=-sPgM3fl2soxIlK/U1gLd Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Disposition: attachment; filename="smime.p7s" Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCCEkQw ggYQMIID+KADAgECAhBNlCwQ1DvglAnFgS06KwZPMA0GCSqGSIb3DQEBDAUAMIGIMQswCQYDVQQG EwJVUzETMBEGA1UECBMKTmV3IEplcnNleTEUMBIGA1UEBxMLSmVyc2V5IENpdHkxHjAcBgNVBAoT FVRoZSBVU0VSVFJVU1QgTmV0d29yazEuMCwGA1UEAxMlVVNFUlRydXN0IFJTQSBDZXJ0aWZpY2F0 aW9uIEF1dGhvcml0eTAeFw0xODExMDIwMDAwMDBaFw0zMDEyMzEyMzU5NTlaMIGWMQswCQYDVQQG EwJHQjEbMBkGA1UECBMSR3JlYXRlciBNYW5jaGVzdGVyMRAwDgYDVQQHEwdTYWxmb3JkMRgwFgYD VQQKEw9TZWN0aWdvIExpbWl0ZWQxPjA8BgNVBAMTNVNlY3RpZ28gUlNBIENsaWVudCBBdXRoZW50 aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKC AQEAyjztlApB/975Rrno1jvm2pK/KxBOqhq8gr2+JhwpKirSzZxQgT9tlC7zl6hn1fXjSo5MqXUf ItMltrMaXqcESJuK8dtK56NCSrq4iDKaKq9NxOXFmqXX2zN8HHGjQ2b2Xv0v1L5Nk1MQPKA19xeW QcpGEGFUUd0kN+oHox+L9aV1rjfNiCj3bJk6kJaOPabPi2503nn/ITX5e8WfPnGw4VuZ79Khj1YB rf24k5Ee1sLTHsLtpiK9OjG4iQRBdq6Z/TlVx/hGAez5h36bBJMxqdHLpdwIUkTqT8se3ed0PewD ch/8kHPo5fZl5u1B0ecpq/sDN/5sCG52Ds+QU5O5EwIDAQABo4IBZDCCAWAwHwYDVR0jBBgwFoAU U3m/WqorSs9UgOHYm8Cd8rIDZsswHQYDVR0OBBYEFAnA8vwL2pTbX/4r36iZQs/J4K0AMA4GA1Ud DwEB/wQEAwIBhjASBgNVHRMBAf8ECDAGAQH/AgEAMB0GA1UdJQQWMBQGCCsGAQUFBwMCBggrBgEF BQcDBDARBgNVHSAECjAIMAYGBFUdIAAwUAYDVR0fBEkwRzBFoEOgQYY/aHR0cDovL2NybC51c2Vy dHJ1c3QuY29tL1VTRVJUcnVzdFJTQUNlcnRpZmljYXRpb25BdXRob3JpdHkuY3JsMHYGCCsGAQUF BwEBBGowaDA/BggrBgEFBQcwAoYzaHR0cDovL2NydC51c2VydHJ1c3QuY29tL1VTRVJUcnVzdFJT QUFkZFRydXN0Q0EuY3J0MCUGCCsGAQUFBzABhhlodHRwOi8vb2NzcC51c2VydHJ1c3QuY29tMA0G CSqGSIb3DQEBDAUAA4ICAQBBRHUAqznCFfXejpVtMnFojADdF9d6HBA4kMjjsb0XMZHztuOCtKF+ xswhh2GqkW5JQrM8zVlU+A2VP72Ky2nlRA1GwmIPgou74TZ/XTarHG8zdMSgaDrkVYzz1g3nIVO9 IHk96VwsacIvBF8JfqIs+8aWH2PfSUrNxP6Ys7U0sZYx4rXD6+cqFq/ZW5BUfClN/rhk2ddQXyn7 kkmka2RQb9d90nmNHdgKrwfQ49mQ2hWQNDkJJIXwKjYA6VUR/fZUFeCUisdDe/0ABLTI+jheXUV1 eoYV7lNwNBKpeHdNuO6Aacb533JlfeUHxvBz9OfYWUiXu09sMAviM11Q0DuMZ5760CdO2VnpsXP4 KxaYIhvqPqUMWqRdWyn7crItNkZeroXaecG03i3mM7dkiPaCkgocBg0EBYsbZDZ8bsG3a08LwEsL 1Ygz3SBsyECa0waq4hOf/Z85F2w2ZpXfP+w8q4ifwO90SGZZV+HR/Jh6rEaVPDRF/CEGVqR1hiuQ OZ1YL5ezMTX0ZSLwrymUE0pwi/KDaiYB15uswgeIAcA6JzPFf9pLkAFFWs1QNyN++niFhsM47qod x/PL+5jR87myx5uYdBEQkkDc+lKB1Wct6ucXqm2EmsaQ0M95QjTmy+rDWjkDYdw3Ms6mSWE3Bn7i 5ZgtwCLXgAIe5W8mybM2JzCCBhQwggT8oAMCAQICEQDGvhmWZ0DEAx0oURL6O6l+MA0GCSqGSIb3 DQEBCwUAMIGWMQswCQYDVQQGEwJHQjEbMBkGA1UECBMSR3JlYXRlciBNYW5jaGVzdGVyMRAwDgYD VQQHEwdTYWxmb3JkMRgwFgYDVQQKEw9TZWN0aWdvIExpbWl0ZWQxPjA8BgNVBAMTNVNlY3RpZ28g UlNBIENsaWVudCBBdXRoZW50aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBMB4XDTIyMDEwNzAw MDAwMFoXDTI1MDEwNjIzNTk1OVowJDEiMCAGCSqGSIb3DQEJARYTZHdtdzJAaW5mcmFkZWFkLm9y ZzCCAiIwDQYJKoZIhvcNAQEBBQADggIPADCCAgoCggIBALQ3GpC2bomUqk+91wLYBzDMcCj5C9m6 oZaHwvmIdXftOgTbCJXADo6G9T7BBAebw2JV38EINgKpy/ZHh7htyAkWYVoFsFPrwHounto8xTsy SSePMiPlmIdQ10BcVSXMUJ3Juu16GlWOnAMJY2oYfEzmE7uT9YgcBqKCo65pTFmOnR/VVbjJk4K2 xE34GC2nAdUQkPFuyaFisicc6HRMOYXPuF0DuwITEKnjxgNjP+qDrh0db7PAjO1D4d5ftfrsf+kd RR4gKVGSk8Tz2WwvtLAroJM4nXjNPIBJNT4w/FWWc/5qPHJy2U+eITZ5LLE5s45mX2oPFknWqxBo bQZ8a9dsZ3dSPZBvE9ZrmtFLrVrN4eo1jsXgAp1+p7bkfqd3BgBEmfsYWlBXO8rVXfvPgLs32VdV NZxb/CDWPqBsiYv0Hv3HPsz07j5b+/cVoWqyHDKzkaVbxfq/7auNVRmPB3v5SWEsH8xi4Bez2V9U KxfYCnqsjp8RaC2/khxKt0A552Eaxnz/4ly/2C7wkwTQnBmdlFYhAflWKQ03Ufiu8t3iBE3VJbc2 5oMrglj7TRZrmKq3CkbFnX0fyulB+kHimrt6PIWn7kgyl9aelIl6vtbhMA+l0nfrsORMa4kobqQ5 C5rveVgmcIad67EDa+UqEKy/GltUwlSh6xy+TrK1tzDvAgMBAAGjggHMMIIByDAfBgNVHSMEGDAW gBQJwPL8C9qU21/+K9+omULPyeCtADAdBgNVHQ4EFgQUzMeDMcimo0oz8o1R1Nver3ZVpSkwDgYD VR0PAQH/BAQDAgWgMAwGA1UdEwEB/wQCMAAwHQYDVR0lBBYwFAYIKwYBBQUHAwQGCCsGAQUFBwMC MEAGA1UdIAQ5MDcwNQYMKwYBBAGyMQECAQEBMCUwIwYIKwYBBQUHAgEWF2h0dHBzOi8vc2VjdGln by5jb20vQ1BTMFoGA1UdHwRTMFEwT6BNoEuGSWh0dHA6Ly9jcmwuc2VjdGlnby5jb20vU2VjdGln b1JTQUNsaWVudEF1dGhlbnRpY2F0aW9uYW5kU2VjdXJlRW1haWxDQS5jcmwwgYoGCCsGAQUFBwEB BH4wfDBVBggrBgEFBQcwAoZJaHR0cDovL2NydC5zZWN0aWdvLmNvbS9TZWN0aWdvUlNBQ2xpZW50 QXV0aGVudGljYXRpb25hbmRTZWN1cmVFbWFpbENBLmNydDAjBggrBgEFBQcwAYYXaHR0cDovL29j c3Auc2VjdGlnby5jb20wHgYDVR0RBBcwFYETZHdtdzJAaW5mcmFkZWFkLm9yZzANBgkqhkiG9w0B AQsFAAOCAQEAyW6MUir5dm495teKqAQjDJwuFCi35h4xgnQvQ/fzPXmtR9t54rpmI2TfyvcKgOXp qa7BGXNFfh1JsqexVkIqZP9uWB2J+uVMD+XZEs/KYNNX2PvIlSPrzIB4Z2wyIGQpaPLlYflrrVFK v9CjT2zdqvy2maK7HKOQRt3BiJbVG5lRiwbbygldcALEV9ChWFfgSXvrWDZspnU3Gjw/rMHrGnql Htlyebp3pf3fSS9kzQ1FVtVIDrL6eqhTwJxe+pXSMMqFiN0whpBtXdyDjzBtQTaZJ7zTT/vlehc/ tDuqZwGHm/YJy883Ll+GP3NvOkgaRGWEuYWJJ6hFCkXYjyR9IzCCBhQwggT8oAMCAQICEQDGvhmW Z0DEAx0oURL6O6l+MA0GCSqGSIb3DQEBCwUAMIGWMQswCQYDVQQGEwJHQjEbMBkGA1UECBMSR3Jl YXRlciBNYW5jaGVzdGVyMRAwDgYDVQQHEwdTYWxmb3JkMRgwFgYDVQQKEw9TZWN0aWdvIExpbWl0 ZWQxPjA8BgNVBAMTNVNlY3RpZ28gUlNBIENsaWVudCBBdXRoZW50aWNhdGlvbiBhbmQgU2VjdXJl IEVtYWlsIENBMB4XDTIyMDEwNzAwMDAwMFoXDTI1MDEwNjIzNTk1OVowJDEiMCAGCSqGSIb3DQEJ ARYTZHdtdzJAaW5mcmFkZWFkLm9yZzCCAiIwDQYJKoZIhvcNAQEBBQADggIPADCCAgoCggIBALQ3 GpC2bomUqk+91wLYBzDMcCj5C9m6oZaHwvmIdXftOgTbCJXADo6G9T7BBAebw2JV38EINgKpy/ZH h7htyAkWYVoFsFPrwHounto8xTsySSePMiPlmIdQ10BcVSXMUJ3Juu16GlWOnAMJY2oYfEzmE7uT 9YgcBqKCo65pTFmOnR/VVbjJk4K2xE34GC2nAdUQkPFuyaFisicc6HRMOYXPuF0DuwITEKnjxgNj P+qDrh0db7PAjO1D4d5ftfrsf+kdRR4gKVGSk8Tz2WwvtLAroJM4nXjNPIBJNT4w/FWWc/5qPHJy 2U+eITZ5LLE5s45mX2oPFknWqxBobQZ8a9dsZ3dSPZBvE9ZrmtFLrVrN4eo1jsXgAp1+p7bkfqd3 BgBEmfsYWlBXO8rVXfvPgLs32VdVNZxb/CDWPqBsiYv0Hv3HPsz07j5b+/cVoWqyHDKzkaVbxfq/ 7auNVRmPB3v5SWEsH8xi4Bez2V9UKxfYCnqsjp8RaC2/khxKt0A552Eaxnz/4ly/2C7wkwTQnBmd lFYhAflWKQ03Ufiu8t3iBE3VJbc25oMrglj7TRZrmKq3CkbFnX0fyulB+kHimrt6PIWn7kgyl9ae lIl6vtbhMA+l0nfrsORMa4kobqQ5C5rveVgmcIad67EDa+UqEKy/GltUwlSh6xy+TrK1tzDvAgMB AAGjggHMMIIByDAfBgNVHSMEGDAWgBQJwPL8C9qU21/+K9+omULPyeCtADAdBgNVHQ4EFgQUzMeD Mcimo0oz8o1R1Nver3ZVpSkwDgYDVR0PAQH/BAQDAgWgMAwGA1UdEwEB/wQCMAAwHQYDVR0lBBYw FAYIKwYBBQUHAwQGCCsGAQUFBwMCMEAGA1UdIAQ5MDcwNQYMKwYBBAGyMQECAQEBMCUwIwYIKwYB BQUHAgEWF2h0dHBzOi8vc2VjdGlnby5jb20vQ1BTMFoGA1UdHwRTMFEwT6BNoEuGSWh0dHA6Ly9j cmwuc2VjdGlnby5jb20vU2VjdGlnb1JTQUNsaWVudEF1dGhlbnRpY2F0aW9uYW5kU2VjdXJlRW1h aWxDQS5jcmwwgYoGCCsGAQUFBwEBBH4wfDBVBggrBgEFBQcwAoZJaHR0cDovL2NydC5zZWN0aWdv LmNvbS9TZWN0aWdvUlNBQ2xpZW50QXV0aGVudGljYXRpb25hbmRTZWN1cmVFbWFpbENBLmNydDAj BggrBgEFBQcwAYYXaHR0cDovL29jc3Auc2VjdGlnby5jb20wHgYDVR0RBBcwFYETZHdtdzJAaW5m cmFkZWFkLm9yZzANBgkqhkiG9w0BAQsFAAOCAQEAyW6MUir5dm495teKqAQjDJwuFCi35h4xgnQv Q/fzPXmtR9t54rpmI2TfyvcKgOXpqa7BGXNFfh1JsqexVkIqZP9uWB2J+uVMD+XZEs/KYNNX2PvI lSPrzIB4Z2wyIGQpaPLlYflrrVFKv9CjT2zdqvy2maK7HKOQRt3BiJbVG5lRiwbbygldcALEV9Ch WFfgSXvrWDZspnU3Gjw/rMHrGnqlHtlyebp3pf3fSS9kzQ1FVtVIDrL6eqhTwJxe+pXSMMqFiN0w hpBtXdyDjzBtQTaZJ7zTT/vlehc/tDuqZwGHm/YJy883Ll+GP3NvOkgaRGWEuYWJJ6hFCkXYjyR9 IzGCBMcwggTDAgEBMIGsMIGWMQswCQYDVQQGEwJHQjEbMBkGA1UECBMSR3JlYXRlciBNYW5jaGVz dGVyMRAwDgYDVQQHEwdTYWxmb3JkMRgwFgYDVQQKEw9TZWN0aWdvIExpbWl0ZWQxPjA8BgNVBAMT NVNlY3RpZ28gUlNBIENsaWVudCBBdXRoZW50aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBAhEA xr4ZlmdAxAMdKFES+jupfjANBglghkgBZQMEAgEFAKCCAeswGAYJKoZIhvcNAQkDMQsGCSqGSIb3 DQEHATAcBgkqhkiG9w0BCQUxDxcNMjMwMTExMTAwMDUwWjAvBgkqhkiG9w0BCQQxIgQgNgV5GBjJ lHIlCxWgQgdiehi/uQV1nV77Zej1Pn52QJAwgb0GCSsGAQQBgjcQBDGBrzCBrDCBljELMAkGA1UE BhMCR0IxGzAZBgNVBAgTEkdyZWF0ZXIgTWFuY2hlc3RlcjEQMA4GA1UEBxMHU2FsZm9yZDEYMBYG A1UEChMPU2VjdGlnbyBMaW1pdGVkMT4wPAYDVQQDEzVTZWN0aWdvIFJTQSBDbGllbnQgQXV0aGVu dGljYXRpb24gYW5kIFNlY3VyZSBFbWFpbCBDQQIRAMa+GZZnQMQDHShREvo7qX4wgb8GCyqGSIb3 DQEJEAILMYGvoIGsMIGWMQswCQYDVQQGEwJHQjEbMBkGA1UECBMSR3JlYXRlciBNYW5jaGVzdGVy MRAwDgYDVQQHEwdTYWxmb3JkMRgwFgYDVQQKEw9TZWN0aWdvIExpbWl0ZWQxPjA8BgNVBAMTNVNl Y3RpZ28gUlNBIENsaWVudCBBdXRoZW50aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBAhEAxr4Z lmdAxAMdKFES+jupfjANBgkqhkiG9w0BAQEFAASCAgBwxZg89Rk6L/cCUA5Nx4P1NkkYNFssNrSZ GUADoVY7R9peuMmOR0FteSbXSZqbiqnM11MxDDte2HhwCIJlNBGJtTj/doHrdBMCocWKJ99uBPgJ 4su7WohSzAWhr5oVJHOKIfo11jjX/t7tWJly7PFqcZSa3Jr0/d7RV5qPsueTYmcRBEgcjxO1akNE ea8JSAISLKoxTUGgKx4KKrdik/1RV/rAi9nt40d4c2ltbVJV3M+ACo4msttBt6G4hF2cDpzjJz6E of6y2C34eiM+9gJYkWokcrsKaLAW5TZpQjEwY9H2RZWZySZ8CeTWKxaX6vxdZgwLb7FUrTsaOMns schYhvs9bVnZbv5Kqof9ZsMFTyJOuREWudGeymrQ8eAUGPx9tqiRZaYVq226xVQ1Wg9viCzbVxPF UIAdkH+Q70e3yDILny9c2lkFMlO6xcCMzZv8DMEMPAuaEV8skUbZ9/53hx4J27ROWbqwJKKFORkf c2adKpl0R7sZb69h28oyy3ibdUyF+vRTW6xGIiVvab9eV5xxvKGUaDqRrwtDGTyXtj8QgTON0/6j s9EM9ZsJIfXv/Jm68aCLRSlZnVZZ6MGN7QHVQnHdcqNnzUf1rQybxT26Oe8w83azF1g3ggSHQoUO q8Zm4PR/bksmIE31o22eRAT8T5EGh2YXTTNaByHpiQAAAAAAAA== --=-sPgM3fl2soxIlK/U1gLd-- From xen-devel-bounces@lists.xenproject.org Wed Jan 11 10:04:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 10:04:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475185.736754 (Exim 4.92) (envelope-from ) id 1pFXxj-0004Ns-6K; Wed, 11 Jan 2023 10:04:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475185.736754; Wed, 11 Jan 2023 10:04:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFXxj-0004Nl-3V; Wed, 11 Jan 2023 10:04:03 +0000 Received: by outflank-mailman (input) for mailman id 475185; Wed, 11 Jan 2023 10:04:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFXxh-0004Na-LC for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 10:04:01 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2048.outbound.protection.outlook.com [40.107.21.48]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 42f6c161-9197-11ed-b8d0-410ff93cb8f0; Wed, 11 Jan 2023 11:03:57 +0100 (CET) Received: from AM7PR04CA0020.eurprd04.prod.outlook.com (2603:10a6:20b:110::30) by AM0PR08MB5524.eurprd08.prod.outlook.com (2603:10a6:208:181::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.9; Wed, 11 Jan 2023 10:03:51 +0000 Received: from AM7EUR03FT040.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:110:cafe::bf) by AM7PR04CA0020.outlook.office365.com (2603:10a6:20b:110::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.13 via Frontend Transport; Wed, 11 Jan 2023 10:03:50 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT040.mail.protection.outlook.com (100.127.140.128) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Wed, 11 Jan 2023 10:03:49 +0000 Received: ("Tessian outbound 3ad958cd7492:v132"); Wed, 11 Jan 2023 10:03:49 +0000 Received: from 6cc083741620.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 3732E506-27AA-445C-AA94-DE92036D4E13.1; Wed, 11 Jan 2023 10:03:41 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 6cc083741620.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 11 Jan 2023 10:03:41 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by GV2PR08MB8653.eurprd08.prod.outlook.com (2603:10a6:150:b9::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Wed, 11 Jan 2023 10:03:35 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::72d6:6a74:b637:cc5b]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::72d6:6a74:b637:cc5b%3]) with mapi id 15.20.5986.018; Wed, 11 Jan 2023 10:03:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 42f6c161-9197-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1FdgGnzcTccqMF0pRyxh6JcyPPsUhfbZpJF0BWhSYwI=; b=TIxDaFxn7VrWvIsPdtNXfLZap/p1LryxhoEtS0b0pYQ2sGYoYSGQH7ALEJYdCsx8U0R+m08xGr0LZkkxx7LThfIdn7OVtbDHIrFDsKRCmRM1MKbfbUT1VgDB/aVTRoeIrjaY1VbKgUNF5wxUTSIscGAikQu0a0NmCYd4UgnbkjA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fj43aJZRLaybNAfMNbF/jQaIPxYGVlGrNgqjDJsyQ3Du3tAj+p29X8MH+HqvgxPrR1nKOkBedVNCszrWbcI1V6+LfEpEoxds+l2KuEmR8dBfIEs+pRzr+wRJcX6vc7W303i81weqkPFsrF9zubYR+IwWRfiRb6ofgfO+s9k7JoF7V6a8BFYcutCbvZXQ5tJdPzlkRQrMP5baK3XmGObrYT4NnTSVgrkKYIwmcEV5aRf5opkOXJYAtM2aIOyOCnfSXkxy1Jax+OoNmlT4njWubbuivBf0HU7UvJOBzGfGhKc7O2txv3WRl/Yoza5hIYJktDcv2DEw6eF1hMieO8pwYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1FdgGnzcTccqMF0pRyxh6JcyPPsUhfbZpJF0BWhSYwI=; b=gfmHqUAa46aNnLC+saUoy8i6SQWYTCafw2wqNSia3zdrbDetvj8QmtZniLlBECFJtSAh5qX0JuF3mUyEP3fxQV202wg/+4LAmp5DtNmBD5ZM1xtjMJcg+PjCdOp0QselRYoUF0jnntZmJDrLaAwZOJTkdrcnoTxWIrWOmxyxbcYEKUFXC1sPw6VvFp2v41dZG8qoh+u+gcHdGX8vYGwj2kMK4qIHs50ctIjgSzeqepb+XC7t2riggDkBEYh5XBfJQx4VJY5lamoYZKA8JZcLyVpse0tw6Xq+d/j+xq6BdZWsf38i6DlB8YproVABf91eGJbTUI0x19x2VUtsQB4Rqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1FdgGnzcTccqMF0pRyxh6JcyPPsUhfbZpJF0BWhSYwI=; b=TIxDaFxn7VrWvIsPdtNXfLZap/p1LryxhoEtS0b0pYQ2sGYoYSGQH7ALEJYdCsx8U0R+m08xGr0LZkkxx7LThfIdn7OVtbDHIrFDsKRCmRM1MKbfbUT1VgDB/aVTRoeIrjaY1VbKgUNF5wxUTSIscGAikQu0a0NmCYd4UgnbkjA= From: Wei Chen To: Jan Beulich CC: nd , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v2 01/17] xen/arm: use NR_MEM_BANKS to override default NR_NODE_MEMBLKS Thread-Topic: [PATCH v2 01/17] xen/arm: use NR_MEM_BANKS to override default NR_NODE_MEMBLKS Thread-Index: AQHZJNEWABvs02i6OUO2BkMLi8xulK6XauOAgAGQmoA= Date: Wed, 11 Jan 2023 10:03:35 +0000 Message-ID: References: <20230110084930.1095203-1-wei.chen@arm.com> <20230110084930.1095203-2-wei.chen@arm.com> <3c664437-7184-d4be-63e2-335942bb6a46@suse.com> In-Reply-To: <3c664437-7184-d4be-63e2-335942bb6a46@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 07CD7E887D4AC040B11786254DD652AB.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAXPR08MB7420:EE_|GV2PR08MB8653:EE_|AM7EUR03FT040:EE_|AM0PR08MB5524:EE_ X-MS-Office365-Filtering-Correlation-Id: fcf160cd-4391-4129-9bb5-08daf3bb22ed x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: lecE4T+77r6OoSinuaugkRy0Rv/nC0FnrUfQh4kyCqKd+qFXXuTWT9RbSugQsmnQMLesMekJqyHHsRAp+ttksMhsRWEAPzA0RyIiff9mrAMlRTC6Cjxp8nNtV1xVeyppWEFBr6rvabnbkmlGFd2tKBntBgIA5BKJbijoKBe6ibTE+c72XLYEtHsXw8YKGHLc3gMSMJW9t7coUQqGnC9VJaw2tAwaUW746lBnxwgw18002HFX6OjOSPERyZK/BG/OXXA9xUVg7oUKYWFSSZ4/ET6fsbuMkxMI4QCyvmi5tcrHPUElYriuqvqSIMpK6D0swEk5kt4F55hRglx9/dxYcvhdSwCT+KEXCPMfXJVg0xOhMEqV7Z0RIJE5UmfnYjbqBujZpxlhsXI505q2KHdo2DdTBREByJswFzWLDFPQ16WaQylOc+VqEcMawfXuOCV+xLulVZ1WKRKxcXmuVKv8QwFggua/swvRDITBS6EBwXcbIoF/hmnJpCRaZ8ImXpgbC4zh+G2BkYhV4FkxjnheVCeY7BzWaLTWHqVkTcQXXVqOiVM/zeIiXJtSCYvAEQndev4u+0lNFFKUpj9rsYkZuIaSZ8tkBbHd8K93GPurWH2iSeVWiRKrX5gBNsuYKXyW9hhE08TuBUnRSPi7K5GxZEr28eDo5MeNfIEh2W3XVS/qu0EEsmluri3/6HgCXxm49M8jtSGmtLL84OlvQyeA7tTaYZGdkEAiLa/oO7npCGA= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(396003)(346002)(366004)(376002)(451199015)(122000001)(83380400001)(86362001)(38100700002)(2906002)(52536014)(5660300002)(41300700001)(8936002)(53546011)(55016003)(8676002)(186003)(9686003)(478600001)(26005)(6506007)(66476007)(66556008)(66946007)(4326008)(76116006)(64756008)(66446008)(316002)(54906003)(966005)(6916009)(71200400001)(7696005)(38070700005)(66899015)(33656002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8653 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 2fd47b3b-e22c-453f-8527-08daf3bb1a62 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5VSa6Voml4XuKjfhIJwQY6ynh+GtVYmcIGkZ8mhOdhhtSm1qLPBgiv4mDRCrH/LGqkzFKgilEYjuLEP745NTiNhCpFSwIZ7wkFRv8eZm/Rm83RuTJdnW61n/E845WD8H8iJie01glOqhOnqsAX6K+EQTPKntTODS8MQqzOIkVXIlGQuY4qUi1adoOfXaNI6Hvg9fStWT/NHXIfMdRf8tcN8CMC+HW0N1tFOLG+6G53vg+x2cEUGMV61uKypjdpzbXFI9OK3bSdGvhwMpsoQ4hrXhv1rQGr12t+n5LdSlbdeEMAIXD/6I3z7cIeJOwgGWKLJDqHz7upzyPsMxSf/PmI3GR4RNhvN/0PaSjVVEWgEpLLxOvciJzHfzGFQ63Ydjj15Zx0uLqR54x9t9GALmy45SPm0D6JkPv/AxDAtO13uIvDNXKH5kLKpHFF/QZRvx8/jsH0Dw1chYL2OWmAo15E4kYFAKsF+E3b14Be/BU0aKorqXsUTJPDgj7O5el4V0N7Gg2FBJiy8uwIwSdoBDTldh0CtxnMSJhfXxwjjj64uh03LhW+Njcq+aob9mVDCvTZ8wqCxejD//3GN7UWaxm0frNHdMMWBnYtFVjKGUiZZFWRNRIZWpmtYSESL2egzKxxEuXMFIIYosKcDPqpAubBrRjOhkIXUklATNs+jBY+REkuSwSuzSpJlzQSsh4fnI7f67Lr/fvR+v0NEtVXfi9FCsFjhGbuRNdu+oPVy+scM= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(346002)(376002)(39860400002)(451199015)(36840700001)(40470700004)(46966006)(36860700001)(52536014)(186003)(8936002)(6862004)(82740400003)(26005)(9686003)(478600001)(82310400005)(966005)(2906002)(40460700003)(316002)(54906003)(70586007)(55016003)(40480700001)(5660300002)(336012)(7696005)(70206006)(8676002)(81166007)(33656002)(4326008)(356005)(6506007)(66899015)(41300700001)(53546011)(47076005)(86362001)(83380400001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2023 10:03:49.6152 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fcf160cd-4391-4129-9bb5-08daf3bb22ed X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5524 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU2VudDogMjAyM+W5tDHmnIgxMOaXpSAxODowMA0K PiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+DQo+IENjOiBuZCA8bmRAYXJtLmNvbT47 IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz47IEp1bGllbg0KPiBH cmFsbCA8anVsaWVuQHhlbi5vcmc+OyBCZXJ0cmFuZCBNYXJxdWlzIDxCZXJ0cmFuZC5NYXJxdWlz QGFybS5jb20+Ow0KPiBWb2xvZHlteXIgQmFiY2h1ayA8Vm9sb2R5bXlyX0JhYmNodWtAZXBhbS5j b20+OyBBbmRyZXcgQ29vcGVyDQo+IDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPjsgR2Vvcmdl IER1bmxhcCA8Z2VvcmdlLmR1bmxhcEBjaXRyaXguY29tPjsgV2VpDQo+IExpdSA8d2xAeGVuLm9y Zz47IHhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZw0KPiBTdWJqZWN0OiBSZTogW1BBVENI IHYyIDAxLzE3XSB4ZW4vYXJtOiB1c2UgTlJfTUVNX0JBTktTIHRvIG92ZXJyaWRlDQo+IGRlZmF1 bHQgTlJfTk9ERV9NRU1CTEtTDQo+IA0KPiBPbiAxMC4wMS4yMDIzIDA5OjQ5LCBXZWkgQ2hlbiB3 cm90ZToNCj4gPiAtLS0gYS94ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vbnVtYS5oDQo+ID4gKysr IGIveGVuL2FyY2gvYXJtL2luY2x1ZGUvYXNtL251bWEuaA0KPiA+IEBAIC0zLDkgKzMsMjYgQEAN Cj4gPg0KPiA+ICAjaW5jbHVkZSA8eGVuL21tLmg+DQo+ID4NCj4gPiArI2luY2x1ZGUgPGFzbS9z ZXR1cC5oPg0KPiA+ICsNCj4gPiAgdHlwZWRlZiB1OCBub2RlaWRfdDsNCj4gPg0KPiA+IC0jaWZu ZGVmIENPTkZJR19OVU1BDQo+ID4gKyNpZmRlZiBDT05GSUdfTlVNQQ0KPiA+ICsNCj4gPiArLyoN Cj4gPiArICogSXQgaXMgdmVyeSBsaWtlbHkgdGhhdCBpZiB5b3UgaGF2ZSBtb3JlIHRoYW4gNjQg bm9kZXMsIHlvdSBtYXkNCj4gPiArICogbmVlZCBhIGxvdCBtb3JlIHRoYW4gMiByZWdpb25zIHBl ciBub2RlLiBTbywgZm9yIEFybSwgd2Ugd291bGQNCj4gPiArICoganVzdCBkZWZpbmUgTlJfTk9E RV9NRU1CTEtTIGFzIGFuIGFsaWFzIHRvIE5SX01FTV9CQU5LUy4NCj4gPiArICogQW5kIGluIHRo ZSBmdXR1cmUgTlJfTUVNX0JBTktTIHdpbGwgYmUgYnVtcGVkIGZvciBuZXcgcGxhdGZvcm1zLA0K PiA+ICsgKiBidXQgZm9yIG5vdyBsZWF2ZSBOUl9NRU1fQkFOS1MgYXMgaXQgaXMgb24gQXJtLiBU aGlzIGF2b2lkIHRvDQo+ID4gKyAqIGhhdmUgZGlmZmVyZW50IHdheSB0byBkZWZpbmUgdGhlIHZh bHVlIGJhc2VkIE5VTUEgdnMgbm9uLU5VTUEuDQo+ID4gKyAqDQo+ID4gKyAqIEZ1cnRoZXIgZGlz Y3Vzc2lvbnMgY2FuIGJlIGZvdW5kIGhlcmU6DQo+ID4gKyAqIGh0dHBzOi8vbGlzdHMueGVucHJv amVjdC5vcmcvYXJjaGl2ZXMvaHRtbC94ZW4tZGV2ZWwvMjAyMS0NCj4gMDkvbXNnMDIzMjIuaHRt bA0KPiA+ICsgKi8NCj4gPiArI2RlZmluZSBOUl9OT0RFX01FTUJMS1MgTlJfTUVNX0JBTktTDQo+ IA0KPiBCdXQgaXNuJ3QgTlJfTUVNX0JBTktTIGEgc3lzdGVtLXdpZGUgc2V0dGluZywgd2hpY2gg ZG9lc24ndCByZWFsbHkNCj4gbWFrZSBzZW5zZSB0byB1c2UgYXMgYSBwZXItbm9kZSBvbmU/IElP VyBhcmVuJ3QgeW91IG5vdyBhbGxvd2luZw0KPiBOUl9NRU1fQkFOS1MgcmVnaW9ucyBvbiBlYWNo IG5vZGUsIHdoaWNoIHRha2VuIHRvZ2V0aGVyIHdpbGwgYmUNCj4gbXVjaCBtb3JlIHRoYW4gTlJf TUVNX0JBTktTIHRoYXQgeW91IGNhbiBkZWFsIHdpdGggb24gdGhlIHdob2xlDQo+IHN5c3RlbT8N Cj4gDQoNClRoYW5rcyBvZiBwb2ludGluZyBvdXQgdGhpcy4gWWVzIE5SX01FTV9CQU5LUyBhIHN5 c3RlbS13aWRlIHNldHRpbmcsDQpidXQgd2UganVzdCB1c2UgaXQgdG8gZGVmaW5lIHRoZSBNQVgg bWVtb3J5IGJhbmtzIGZvciBzaW5nbGUgbm9kZSwNCnRoaXMgZG9lcyBub3QgbWVhbiB0aGF0IHRo ZXJlIGFyZSByZWFsbHkgc28gbWFueSBiYW5rcyBvbiB0aGVzZSBub2Rlcy4NCldoZW4gYSBzeXN0 ZW0gb25seSBjb250YWlucyBvbmUgbm9kZSBOUl9NRU1fQkFOS1MgZXF1YWxzIHRvDQpOUl9OT0RF X01FTUJMS1MuIE91ciBpZGVhIGlzIHRoYXQsIGlmIHRoZSB0b3RhbCBtZW1vcnkgYmFua3Mgb2YN CmFsbCBub2RlcyBleGNlZWQgdGhlIE5SX01FTV9CQU5LUywgd2Ugd2lsbCBidW1wIE5SX01FTV9C QU5LUy4NCg0KQnV0IEkgYW0gb3BlbiB0byB0aGlzIHF1ZXN0aW9uLCBpZiB0aGVyZSBhcmUgbW9y ZSBzdWdnZXN0aW9ucyBmcm9tDQptYWludGFpbmVycy4NCg0KQ2hlZXJzLA0KV2VpIENoZW4NCg0K DQo+IEphbg0K From xen-devel-bounces@lists.xenproject.org Wed Jan 11 10:22:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 10:22:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475192.736766 (Exim 4.92) (envelope-from ) id 1pFYFQ-0006nP-SK; Wed, 11 Jan 2023 10:22:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475192.736766; Wed, 11 Jan 2023 10:22:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFYFQ-0006nI-PV; Wed, 11 Jan 2023 10:22:20 +0000 Received: by outflank-mailman (input) for mailman id 475192; Wed, 11 Jan 2023 10:22:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFYFO-0006nC-Tg for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 10:22:19 +0000 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [2a00:1450:4864:20::62c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d1120586-9199-11ed-b8d0-410ff93cb8f0; Wed, 11 Jan 2023 11:22:14 +0100 (CET) Received: by mail-ej1-x62c.google.com with SMTP id az20so16561123ejc.1 for ; Wed, 11 Jan 2023 02:22:16 -0800 (PST) Received: from [192.168.1.93] (adsl-211.37.6.0.tellas.gr. [37.6.0.211]) by smtp.gmail.com with ESMTPSA id kx1-20020a170907774100b0084d368b1628sm4908156ejc.40.2023.01.11.02.22.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Jan 2023 02:22:15 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d1120586-9199-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6tJ7kpzrhyHUzMy1RjtfFRjdNaVMpk5nM2TuZL5gE8g=; b=KufNy0VSaoPfgDDeR+SD9quaYDs9EZYi/89cMJk+QbGxz9EaN2xbZemRNgLQalRfp0 CtE5ZhcTlstIlwml8qq22uNe6E5F3cm8RD0mEeb97pszLenvnsFTLSlsJjIHgzSeAPW/ fEoRIv7jd3dZxEPJFSYvrIIFG1R8spkfCAPc+btJST1OBTZbFeqgeNLgV/ECTXZCbLgd ePvtC1Wov2zAQXZrMTzA7jrr5nQOsgC5N50rMqNFXSiJD0/h69RsLJO9dk5WDV9vGdA3 cnCyXVIZqTGRMrPQ7w2t8gbSnYMqRYLrxstjbNiMB6tN7O89dm/WxBOlmKITDshTvs0C 0Kmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6tJ7kpzrhyHUzMy1RjtfFRjdNaVMpk5nM2TuZL5gE8g=; b=xrG8KXF964YsoO/b6OJRA4CVjnYxHO6endV0GnLnTjiip/1RRUhzzFK3e6aJvbbV9H k4cVfD9H46DQYWzr7OzxUTL1rMFC+h7f3d1H89hVfZ8JyLMx0nA7PuyHcsS92VdI3mnf FMhupGtesUEGfFvb0s4YJpeL7SD4E5tQWZuIgG5Fgw6zt9D8OXdWXEVgH5uR9yMNmuVn QwF87cxlbtN3WLAoThwOlZqfQSc9vuzNKruh7bDwa0TDqoiHjjAVvfjkrDRbe3TU2Opo y+bbGWsTZrW12qVAcnqXzlSerWkPix7vmJTV447AnKZlKQvV9z5IqjRLg+5GsGFgnewy YiKw== X-Gm-Message-State: AFqh2krCWLWDSZwy6bDiVZpFDJszp0Y4pKz/B+gMP+OhEKVNFL50j4wo x5gbHv3/KMpjZGN7QQpSa5A= X-Google-Smtp-Source: AMrXdXsRxv3g1e/h/BybE80Hrt7Q0YSmsDLpGYzAvSabVG+lJTSGohlyCqExnCpAITtHrgwgpusLZg== X-Received: by 2002:a17:906:380e:b0:7c0:be5d:59a9 with SMTP id v14-20020a170906380e00b007c0be5d59a9mr64490219ejc.20.1673432536107; Wed, 11 Jan 2023 02:22:16 -0800 (PST) Message-ID: <0398c48c-cc5d-a4fb-354f-54e3c5900d18@gmail.com> Date: Wed, 11 Jan 2023 12:22:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v3 2/6] xen/riscv: introduce asm/types.h header file To: Jan Beulich , Oleksii Cc: Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org References: <06185fcfb8cbd849df4b033efa923b55c054738d.camel@gmail.com> <1b6ee20d-2f32-ab38-83ec-69c33baf42fd@suse.com> Content-Language: en-US From: Xenia Ragiadakou In-Reply-To: <1b6ee20d-2f32-ab38-83ec-69c33baf42fd@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 1/11/23 11:08, Jan Beulich wrote: > On 11.01.2023 09:47, Oleksii wrote: >> On Tue, 2023-01-10 at 17:58 +0100, Jan Beulich wrote: >>> On 10.01.2023 16:17, Oleksii Kurochko wrote: >>>> Signed-off-by: Oleksii Kurochko >>>> --- >>>> Changes in V3: >>>>     - Nothing changed >>>> --- >>>> Changes in V2: >>>>     - Remove unneeded now types from >>> >>> I guess you went a little too far: Types used in common code, even if >>> you >> It looks then I didn't understand which one of types are needed. >> >> In "[PATCH v1 2/8] xen/riscv: introduce asm/types.h header file" all >> types were introduced as most of them are used in : >> __{u|s}{8|16|32|64}. Thereby it looks like the following types in >> should be present from the start: >> typedef __signed__ char __s8; >> typedef unsigned char __u8; >> >> typedef __signed__ short __s16; >> typedef unsigned short __u16; >> >> typedef __signed__ int __s32; >> typedef unsigned int __u32; >> >> #if defined(__GNUC__) && !defined(__STRICT_ANSI__) >> #if defined(CONFIG_RISCV_32) >> typedef __signed__ long long __s64; >> typedef unsigned long long __u64; >> #elif defined (CONFIG_RISCV_64) >> typedef __signed__ long __s64; >> typedef unsigned long __u64; >> #endif >> #endif >> >> Then it turns out that there is no any sense in: >> typedef signed char s8; >> typedef unsigned char u8; >> >> typedef signed short s16; >> typedef unsigned short u16; >> >> typedef signed int s32; >> typedef unsigned int u32; >> >> typedef signed long long s64; >> typedef unsigned long long u64; >> OR >> typedef signed long s64; >> typedef unsigned long u64; >> As I understand instead of them should be used: {u|s}int_t. > > Hmm, the situation is worse than I thought (recalled) it was: You're > right, xen/types.h actually uses __{u,s}. So I'm sorry for mis- > guiding you; we'll need to do more cleanup first for asm/types.h to > become smaller. What is the reason for not declaring __{u,s} directly in xen/types.h as type alias to {u,s}? IIUC __{u,s} and {u,s} are needed by code ported from Linux while Xen code should use {u|s}int_t instead, right? -- Xenia From xen-devel-bounces@lists.xenproject.org Wed Jan 11 10:44:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 10:44:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475198.736777 (Exim 4.92) (envelope-from ) id 1pFYb5-0000oO-OA; Wed, 11 Jan 2023 10:44:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475198.736777; Wed, 11 Jan 2023 10:44:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFYb5-0000oH-KZ; Wed, 11 Jan 2023 10:44:43 +0000 Received: by outflank-mailman (input) for mailman id 475198; Wed, 11 Jan 2023 10:44:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFYb4-0000oB-84 for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 10:44:42 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f20eab4e-919c-11ed-91b6-6bf2151ebd3b; Wed, 11 Jan 2023 11:44:39 +0100 (CET) Received: from mail-bn8nam11lp2169.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 11 Jan 2023 05:44:32 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SA2PR03MB5705.namprd03.prod.outlook.com (2603:10b6:806:11a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Wed, 11 Jan 2023 10:44:31 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5986.018; Wed, 11 Jan 2023 10:44:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f20eab4e-919c-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1673433879; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=cUc1rSn5E96ZQjUiXm6XDYkzlgy88aybRcj54b94sWo=; b=TE/SEc0LL2OlItUbGekHcBrbPG/d7vmsn+fx4kGfvUOv0aPHb0zk6bwl YMLIiCEi0a/AbEgZswD9F5F0jMamtw4Sp6iZO66xv3ZV9EoMP1xJ0pmlz /6fR7k3QNkF0J7ch0Wq6l26uXjW3NvmNPV+T++YD8N++CXpLR6ThZl6Yp 8=; X-IronPort-RemoteIP: 104.47.58.169 X-IronPort-MID: 91036434 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:ljqed6x6Wp1lm61TJ9V6t+fUxyrEfRIJ4+MujC+fZmUNrF6WrkUFz DcYCD+FaKyNZ2Chfd8jaYu2oBgFsJ7dz9NkS1ZsqSAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTbaeYUidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+U0HUMja4mtC5QRnPKkT5TcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KTFw9 6c+DDU8VRC8usCw+PGXEeIyrNt2eaEHPKtH0p1h5RfwKK9/BLrlE+DN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvjiVlVIguFTuGIO9ltiibMNZhEuH4 EnB+Hz0GEoyP92D0zuVtHmrg4cjmAuqAdpJSuHjqpaGhnWYwDciFQNJZWeX+6GU1GOwCs5zD Esbr39GQa8asRbDosPGdxq8rX2fvx9aWMdKFOY66walxa/d4gLfDW8BJhZRZdpjuMIoSDgC0 l6Sg8ivFTFpqKeSS3+W6vGTtzzaETMOMWYIaCsATA0Ey9ruuoc+ilTIVNkLOKG0h9vxBDr56 yqLsi8lhrMYy8UM0s2T9lndjzWhjpPAVAIy60PcWWfN0+9iTIusZojt416L6/9Fdd+dVgPY4 ilCnNWC5ucTC53LjDaKXOgGALCu4bCCLSHYhllsWZIm8lxB5kKeQGyZ2xkmTG8BDyrOUWaBj JP70e+J2KJuAQ== IronPort-HdrOrdr: A9a23:LnaWaato7eFw7yIeZB3cLit47skDstV00zEX/kB9WHVpm6yj+v xG/c5rsCMc7Qx6ZJhOo7+90cW7L080lqQFg7X5X43DYOCOggLBQL2KhbGI/9SKIVycygcy78 Zdm6gVMqyLMbB55/yKnTVRxbwbsaW6GKPDv5ag8590JzsaD52Jd21Ce36m+ksdfnggObMJUK Cyy+BgvDSadXEefq2AdwI4t7iqnaysqHr+CyR2fiIa1A== X-IronPort-AV: E=Sophos;i="5.96,315,1665460800"; d="scan'208";a="91036434" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ly0DOinDCJRhiUEwZsIN+5hzjrn0ZM50W3A545q90BSo+xuu6nf2gxzRgeeJUK4E9GaiBa2706rVI3KKhaq/BGq5oE/54mUEDKklfS3ii5vWDnBykpybfCo0K6z641xyL+eZLvEDhmoepSdMKFSnkGgdLCropp/Al0q7s1YQiLwKFTf66G8/eL1Wc25fPcz2Lsu6fGrurAku7x/ntOXRql9YaNPFMZoJplX76kK94jCuNAFdLTIhT6oyNNgOhodx6v+Wjb5YdwSCJYrrXgSiw8D2RVAoP9lQaN2PK0JtUwBK120/p3noTkL9b8lqotqMXVWXPwG20FXyUQC3AnN7QQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cUc1rSn5E96ZQjUiXm6XDYkzlgy88aybRcj54b94sWo=; b=Ic2FEesQC5tn7tPuSyrqexrYcYTYfZiu2JHWBr5rhIxWTZDuFIZoqg51ava0zN5DlxsazR09+3WmxvU0RiqTFb3/WX0KDjbOpYtZSfYjxazIK1JSIURiB7hXRD/n7h4fSQeIsAx0pK6q3C2G7hqDmQyDMV4THLozv+dSXbpolSZ/GMb77ku4ADGlHWJoEwb0PK3neJYchmYlxWvVFC5yasi0rR/06glMd3eXlyWtWFyP1vYp04FKfVkp2J6xHkLwjOC5Xz7c/AuMAMpolc3BZYiNr2aivVRp92hQEb12sdJdWxJOh/PDuAH/lKmDS0BlIa2l6xt4KFSfEjxdYHpApw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cUc1rSn5E96ZQjUiXm6XDYkzlgy88aybRcj54b94sWo=; b=hXD2XI6/mSCGheEwrKJ7KP02xL7tHTTEf1WtDi84NcN5KBqKUZxtHCgTBKPHzzM+3YMqsCxyYKtK9wy/oLx4cwy0NZ0AHTtF9taKVpWWwnFcS+RoHV0nG1EiwAA6xG51oP3rITFzbW6BE3qW7ymOCkJFKJfpoiSliefU3Bf/jSU= From: Andrew Cooper To: Oleksii Kurochko , "xen-devel@lists.xenproject.org" CC: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Doug Goldstein Subject: Re: [PATCH] automation: rename RISCV_64 container and jobs Thread-Topic: [PATCH] automation: rename RISCV_64 container and jobs Thread-Index: AQHZJRAt1qKQYAWJX02qzojGezRz/a6ZCT0A Date: Wed, 11 Jan 2023 10:44:30 +0000 Message-ID: <4f15fe80-9a60-76ce-9cf8-2143ea2d86eb@citrix.com> References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|SA2PR03MB5705:EE_ x-ms-office365-filtering-correlation-id: 9e8c6818-9c28-4420-43f5-08daf3c0d1e0 x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8aqcETFqg2puyXjMekJLe+wDZgnxwK0lfUIcrnQaojG0jS8gWTp+5cuvfThQyT0tXQmGxlZiGpRxisrBnJe7uVeI3jViBOuSSia92xDm2UrYmPcnywj2HSm0k4SgHxX6BAku59uLo+WSOVNMYVmKK+7xpMVbKQCdvjdyVNPc6L0OTOq1Eido/eaGbADcfO38bK4uQyO8Fq1Ic7yAyQt7FoEFqo/450VOvgCUYn9egLcpDugUAX+LTD7EjSb8qPeI2c0/Wjq0CHh2YbzZ4HHUVPhTV7zrfwRiLALlsQrpA9S6YeTXw06u8WNr0vlpHpqYil3YZfzp69s3ABEeNEZSknGtJnQG0YETrhAaRrZQn/oGJXcwz5l92hgAt8XSToc/iaRh7eL4z4hkZYpepGCWrRTjrenIHh46ImmwJXZa3fXjE/U5y9iYaZqFkFyZkL8q479DS1mYjiw1eOHdomj1/D7Z55xL9Oehnzo5xtBlUHGLEJOlQTxfFWEwPSVjukQ2WFH+DxpGWZNfVls0XAxTzJ3eI6eEFnCeRxVHY+dT7AnplsAxzMokWfsIRtEG+mBlGxy/xo0igsfibt2aog9PDotwchBzgvRDl0whitZjHNKTo4p4fhDn6zQVQ5+BnacYytootpb1rvO/g445sX/qP2e4E9G4dolspwIHrQvLji8WBYpgFgKyAm29rWawHrNsVP3KXwwpRRNaljqXzaSmnfy06q/DGxKvsCtD6s5Ivl5Q1PSLS8CImn7arEldUBGtaghFMrRREyo6kuSa7eWrAg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(396003)(376002)(136003)(366004)(451199015)(6506007)(82960400001)(38100700002)(122000001)(31686004)(53546011)(2906002)(478600001)(6486002)(86362001)(2616005)(4744005)(8676002)(186003)(6512007)(316002)(26005)(5660300002)(71200400001)(8936002)(36756003)(38070700005)(31696002)(41300700001)(66446008)(66946007)(91956017)(110136005)(54906003)(76116006)(64756008)(4326008)(66556008)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NklaeEF0NEI5K3lGTStmYkJCTS9FdXpvNE10b3FhNFY1MHduZnFUd2cyY29O?= =?utf-8?B?TVBTNGJhY3oyMExoQ3BnelpVbmRqU2I2cWVHcU1VOUZsWUVlSWVjWHo4dmZD?= =?utf-8?B?dXN2emU0cHpFL3g1c0tCeklmQmx3N2tnclk3Z0ovblRjL1VyR0RNWkVuRUdu?= =?utf-8?B?Ym9XY0FrRzk5cUlQUm9XdnF3TGxxOThOT0tZZW5QU1l1eEJsS0RVV2xkUnJX?= =?utf-8?B?V1gyZHoxYzB2VEYzS3VMK1g4UTBTRFRPbitnMC9JR1JvQ1YxZ2IxZHVUUm9l?= =?utf-8?B?MXBId2xmODh3QkRld2lwbDlhalNlT1FmV0RMemlnUEJuNmNxdDdjRzkzZE4v?= =?utf-8?B?UFVqcE01U2FkeDdicHcxUkdHOG5GRjZRbGFxY0duKytpdEdFRHNLQWhILyts?= =?utf-8?B?MTk4clJFQWxUKzZhdzkvKzJGdkViVWswVWhXbWV4LzRlYU1PTTAxenhkNG9u?= =?utf-8?B?REtIVlBIbzc5cWdIVU5TamNZanRCcDQybmZlUnFDRThsRGhmdmErVklHTno5?= =?utf-8?B?NEZmRWtSOVlOamdTcllzR3NXVHdOZzU3YjdCaVN3dzJQc1Axd1U3ZWc5L090?= =?utf-8?B?VVhzaEl0ZHdWamJYSSs2eURIUVBXbzNSZWhQcnYyb05SKys2SitNbDl1NUF2?= =?utf-8?B?SDFKazNOdVhWVmcrRFNISHdDZkRIbDlGemVzT2x2UTJ0VzZNSzZ6Wi9Vby9z?= =?utf-8?B?OTFxOFFFSnBFZXBqby95ZWRhdnc4ZW1FamFlU3RwcE95RWt2Q0hvWGYra2hE?= =?utf-8?B?dk5NeEZWcjZrdGQ2dHhEdHVTK1F0azQ2TnlwR2wxRU1VeVR5MTgyK2F6VUpV?= =?utf-8?B?b1pPSDZaVmJVdUxnc2hGNUtMMVlQeG1hejI2djU3ZUlhSklUNmtWWmwycko5?= =?utf-8?B?ZzB6cU5jOTQvYVFHaGdTOHdHZ0tlekNBd1k2dmFXOTJyN0hQU0lDQ1lBaFdi?= =?utf-8?B?dHNsb1NlZ3RxTlZTUFlrTGY5OThMUkx0VE9xd1NkRmUzUmhtdWtocHk5bmsy?= =?utf-8?B?RzVqYXJVL29TZlVZKzFlWDRHeDhZWnhNQ1VCTE5XK1dhdFl0Z3N3bGlzNURw?= =?utf-8?B?cjd1WGZOVUF4UlFzZyswV1M0aWdLb29nelIwM05uM0pTNU1QVFRibHNZclJp?= =?utf-8?B?SGIyNkZUSEk0VGRiQ1ZWSkQyaWpJck9jdGs5M3JseEk4Y052SE50VUFOMjlh?= =?utf-8?B?QjZOdDJGeG4wcUc1blp4NUs2TVlNbmVlVW5PRmFpaTVWYTdXWTNQMGM4RXls?= =?utf-8?B?Nk5zcHM3cG12bGdrcUh4UkV1UXNxb0lQaXpLL0tjMEtWZGtUWGhlVktsbmw5?= =?utf-8?B?TElRRU5YcGF5V0JjZnNIQTk4NnZLQW1BQzlBS2g2SXI2ZFdLNmF1T1VwelB2?= =?utf-8?B?YUhaTUNwcld0RkUraWQ3dGhYMHY5ZkNCd05DUGZOam83cXZoajdOZUplWTdP?= =?utf-8?B?U1NDVjY1aXZTb1c3ZUY3WmRxK0hocElOdlRhUWxacitGN25qNDJtcW45NkJP?= =?utf-8?B?MlBaZ1IybDJEOUljVEgvUDZ1bVd2VFpvNTFUUlFkaFpoTlNpWFVqZElicHp6?= =?utf-8?B?OUgwa1VnMit3cmMzUk42UGFYZkRTOWJOWXBQY0MxcGFQaTByNVhLWm9HQm1T?= =?utf-8?B?S01CU0FSazZCTGQ3YU9OVWdqOHpZcXpKOEM5bGJ4eWYvZ21jaDlkRmlYalRV?= =?utf-8?B?TjI5SmdVL2l4UjZJOW1oS25YdHFYQ21nM2tTVkVQTXExUVY3RWRFWGFRd0xn?= =?utf-8?B?S0RIRVVtNU9td3ptdkFha1VZYWlZRXZad25mNjNjeGVmNXY1Wm5XUFNTOXVD?= =?utf-8?B?SmpCNW1FRFhwSG9wUVo4dU84RXdCMGZkWTg5dldobGZHaDVOUmplWXpKZTJV?= =?utf-8?B?SzEyUUdCck9NWmx3WU9aNk52QXVYeW1mcmVSc2psVVJIK0lBV2RJaXU0aEpR?= =?utf-8?B?aVl6aW1XZ0ZoTHdJQStidi9zZnpwWHZSa3dSK3BWUnFnbHU4Yjltd3RuWXNB?= =?utf-8?B?eEtpWUJibEpSMmh3cnNCTDFOdTZTUCtaWkRSMjg3NVoyN3d3RmxVeC83c1kr?= =?utf-8?B?Vi8rRFBVT1lRNjRMREsyVUwraUEydnowZGhsVkpjRjQ5Y1VpbzNaV1B4cm9V?= =?utf-8?Q?VEvbLrJUJ4ZQfVXZARY9zsDrk?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Sx7J0+f4Oc/Ow5QLPWYyKHciRRIdyxTKwZM1lay79O9vnwknoE8VBkaSPiduaPx+eFuTad3pCkfNkf6y6TOiCy372Xu0rjFVDGaVlfG6o6T/U/piC7nSgsEt6pVcTos/ZKcxmX4EcAJErKrrCQ3oa9LqqzFl/Q3QFiqCfs1r3cQOyN4VERLEbrq2iC33YN9csO2YvGXMDcjjORqUcN4W0Rs2ZZN+ugIdsqujj29dUJnPqaXS8M0Er3J4PYSbK9iApBD7r2Q2zxVqEV8+syOTQ6E4I8M6D8lA++6rW8BUDu3EK7eSQhnb649IY7te6AccVdbGwgfJWT1qi2bRwVMDWvgZVenSgrjFbo4Ll85stbNg/WqOX8zxTt2ChpXyVou1xTAeb858c0ZgC4dyLoMRSroRfG3DtwCHfdtqW0APQY3iXLDURhW+Sc/3kxBl7y2+UbWBnO9tZh6nAmqomVEdWhCk6nStkg2fD/IQAZXYBKaWQ2S/Y+rfuRLP5rnxHDgBxnoLS6sxnkM6z5TTUH6ALvl/WJNmgqkXxYHuc1gQnjVAMWn+olSFgZBtMnU0VosNjmQkxZz/C1Sk1gJQ9lU+y9bhJ38By+KCs8omdKbwruGMSnWmYPfpWlEc5fnkkPzOZ8nz3HWb0LFye0MUXZqlVZcSTPDgcPgK9ni3dXWiDCwGJ7NGr88X3U/l3YnzWEFim6ozNSDPUBWvA2MWvJ1PSSUwTNTS1d55rxQIvNWDCFYGUiA+dXgzjW5CHQurkugwZ3VyewEeMAEcH+9uss3F+WvG8n2feKs9sIZBzeH+kCXzEHFKJfa0SFy+hgH08kTT+Yhu3tHhcJ5n8ppo98tWT4YEDC8Gne2OuoDRNYOmnW1hMLZO1qkc5hZmTk9vBDAkGgSapc+P6ZnXQ38pY5rZpA== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9e8c6818-9c28-4420-43f5-08daf3c0d1e0 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jan 2023 10:44:30.6596 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: elDQ/uevrmYXhPYqA2rsgJw/8LY2jZWjXiv1E00HiIdZhuzVhZ55nEzJHVk4vtjaepkNpVFwRWGQoI+EQdyHTFoE9ZRAS3nriC0fnV8A5Dk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5705 T24gMTAvMDEvMjAyMyA0OjI1IHBtLCBPbGVrc2lpIEt1cm9jaGtvIHdyb3RlOg0KPiBBbGwgUklT Q1ZfNjQtcmVsYXRlZCBzdHVmZiB3YXMgcmVuYW1lZCB0byBiZSBjb25zaXN0ZW50IHdpdGgNCj4g QVJNIChhcm0zMiBpcyBjcm9zcyBidWlsZCBhcyBSSVNDVl82NCkuDQo+DQo+IFRoZSBwYXRjaCBp cyBiYXNlZCBvbiB0aGUgZm9sbG93aW5nIHBhdGNoIHNlcmllczoNCj4gW1BBVENIICpdIEJhc2lj IGVhcmx5X3ByaW50ayBhbmQgc21va2UgdGVzdCBpbXBsZW1lbnRhdGlvbg0KPg0KPiBTaWduZWQt b2ZmLWJ5OiBPbGVrc2lpIEt1cm9jaGtvIDxvbGVrc2lpLmt1cm9jaGtvQGdtYWlsLmNvbT4NCj4g LS0tDQo+ICAuLi52NjQuZG9ja2VyZmlsZSA9PiBjdXJyZW50LXJpc2N2NjQuZG9ja2VyZmlsZX0g fCAgMA0KDQpUaGlzIHJlbmFtZSB3aWxsIGJyZWFrIFhlbiA0LjE3DQoNCk5vdywgYXMgNC4xNydz IFJJU0MtViBzdXBwb3J0IHdhcyBzbyB0b2tlbiB0aGF0IGl0IHdhc24ndCBldmVuIHByb3Blcmx5 DQp3aXJlZCBpbnRvIENJLCB0aGVuIHRoaXMgaXMgcHJvYmFibHkgZmluZS4NCg0KQnV0IHdlIGFi c29sdXRlbHkgZG8gbmVlZCB0byBiZSBhd2FyZSBvZiB0aGUgY29uc2VxdWVuY2UgYmVmb3JlIHRh a2luZw0KdGhlIHBhdGNoLg0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Wed Jan 11 11:05:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 11:05:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475205.736788 (Exim 4.92) (envelope-from ) id 1pFYv9-0003HA-D9; Wed, 11 Jan 2023 11:05:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475205.736788; Wed, 11 Jan 2023 11:05:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFYv9-0003H3-9t; Wed, 11 Jan 2023 11:05:27 +0000 Received: by outflank-mailman (input) for mailman id 475205; Wed, 11 Jan 2023 11:05:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFYv7-0003Gx-TP for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 11:05:26 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2084.outbound.protection.outlook.com [40.107.244.84]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d8cb6fae-919f-11ed-91b6-6bf2151ebd3b; Wed, 11 Jan 2023 12:05:24 +0100 (CET) Received: from DM5PR08CA0030.namprd08.prod.outlook.com (2603:10b6:4:60::19) by CY8PR12MB7435.namprd12.prod.outlook.com (2603:10b6:930:51::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.13; Wed, 11 Jan 2023 11:05:21 +0000 Received: from DM6NAM11FT106.eop-nam11.prod.protection.outlook.com (2603:10b6:4:60:cafe::fc) by DM5PR08CA0030.outlook.office365.com (2603:10b6:4:60::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.13 via Frontend Transport; Wed, 11 Jan 2023 11:05:21 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by DM6NAM11FT106.mail.protection.outlook.com (10.13.172.229) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6002.12 via Frontend Transport; Wed, 11 Jan 2023 11:05:20 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 11 Jan 2023 05:05:20 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 11 Jan 2023 05:05:20 -0600 Received: from [10.71.193.39] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Wed, 11 Jan 2023 05:05:18 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d8cb6fae-919f-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KvoI+LKKpNIpbWF+69cGnGcwmVfLUXrk0G205/FYvXrRes1PQ7leFUMGeLiPnKYaFGEXd00LbUdefYCyS+OzudHrA0oLC9GwGC64lpnOhlHInXgJZoUtn6/iJJan+2q4h+Tduoit2bBcF/BVZsMjG1kgAPGn2kirisWOk8kgNsQ6rvAdwetKDrUwuxUH556VeS/UOX6gvq01PTlekIFO2fKKFzvZ6DdPb7rZRKb8z9lhM/eGfsgzolPmmp0Ks4QzVqVu+V2EcstzeJ4T5D+r93SXpvAsvRejWTzL+VrTyMdPJE2rqwBQ9CdB/RM04iAvwqQJvYVJUladcOjurZbWmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wErCXnpAFasgVfkVOpDBs0NnPqWQPgKvRmIRDzVqRqE=; b=h1igtfL+nl1DcXM+8pgscvxxwrHFtl425vJFRyGWF+TV1tQ5xisNaaRl3Hbr8jkLpBLhsZk7y5auUKVjHXRPzJMzRccQ/cFzj1zyzonQp8Iu2/y56yWNpspdh+rfilgfoZ2Gg3bntUOe7/y23rZY8e396N3t7xTaI5myD+ZXgAQt+URc6uYpZT0SAytwFZLEQycFOQrO1wavbp7I2G1ZkOWyaRuWEmPaHsgb8Fi3sqDHk1BzSnlZLAEuDJ6M8LKAtTd2vzyA80AghssxyFjF/17Wt2vYm+g5h3+2JQoDr9IHTc/jU3PtjWEr0OgREtZ8U6BIS413tZ+glzC7kL6QJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=citrix.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wErCXnpAFasgVfkVOpDBs0NnPqWQPgKvRmIRDzVqRqE=; b=sjtRFrdwYTOg2oM8OV2YKX8zd/mUSBvUvD3ANjNlnPV77OpXhXj8uFmkWzH4oMRKQLDWkP83pke9OO+OTg7anBfof1leTh+ZhXGackzTazVQrCqk87I4oQCDUhl5VIBTEADLOpa5tjRRhy2+fO8Qrte9UkHP2er2QTrXfKjh14o= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: <4bdb36a2-fda6-1949-d7db-7344a801fa50@amd.com> Date: Wed, 11 Jan 2023 12:05:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] automation: rename RISCV_64 container and jobs To: Andrew Cooper , Oleksii Kurochko , "xen-devel@lists.xenproject.org" CC: Stefano Stabellini , Gianluca Guida , Doug Goldstein References: <4f15fe80-9a60-76ce-9cf8-2143ea2d86eb@citrix.com> Content-Language: en-US From: Michal Orzel In-Reply-To: <4f15fe80-9a60-76ce-9cf8-2143ea2d86eb@citrix.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT106:EE_|CY8PR12MB7435:EE_ X-MS-Office365-Filtering-Correlation-Id: 1b5f3afc-9796-4fb7-7bd9-08daf3c3bb23 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +KW+gWucd6aWaiHm9bR2pH024yR1CE5NEnhDcvwQHVR/A8RoHE+2gHYW3WzvszmTiq+Zmy+49sSZWWh4RR4ZM0JFA9D4meSEb74vaAx0u/dBrzuTgRIcVDtZ6BQhNjQ6Sr0dvQb/zpZT8hkBvgrpsoBOsAj1zziL3nStNstYBzOdAq6fqLXTGqNJBgbU4Lgtopas3IqSE7lZfmiLXaOEYa0paLYDakRe/ygqW10Wzo+TGhxoqWS5dVniO+jiB1YiC6ACvRNQRZxXxLYZAuafdbIF80cg3ka5zHKg8K7hEvG2jntYTV4tb0K5XJumUIjVjSUQ2+4Myv3n02ToJOCTtTTqFgeFJ19buv4jaJOnGeXLdfR6ga7H9Ci3Wuz4tCEKDAmLbReBTKwLa3iuAIpdwiYQZiX4QWmsWoX/vZR1L/Xtv2OkOEmBoQvMC2xdvZ/Lwonh3kbjg5e0EVaDZsAnJSUGATFZ9O0cvMe313orfopxlYRlSgwnp8xWxEwZOKQIVfkvhdmIAV1kho0ha2Z7pPNlFHCe8tCzLfD43I1MDIrn1ba7K4q/hCdgsZDk7q/RrPofTh1M3rHbhwKYXhXOgST21y1CDEdDwFHEzpv3d3yNgn8vl9bnfIZAKnwTMEThOdkcCFhiUrASSyxXcnEjeXLQvIaN3rOYrVqG3imLTMI7Sr8Ml4qWGx4yRMkUxhxDsQ5xNoLyH61Vy3SVAf3LHeWAlXivgY/Ta5IQxy03159ocOlQ6XXTQLTJcWWbwzhX/8PPCAiKilldIyQGb57Kng== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(136003)(396003)(39860400002)(451199015)(36840700001)(46966006)(40470700004)(478600001)(82740400003)(47076005)(41300700001)(356005)(426003)(81166007)(40460700003)(86362001)(110136005)(316002)(54906003)(16576012)(31696002)(2616005)(186003)(40480700001)(70586007)(26005)(336012)(82310400005)(70206006)(8676002)(36756003)(5660300002)(53546011)(36860700001)(2906002)(4326008)(31686004)(4744005)(44832011)(8936002)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2023 11:05:20.9402 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1b5f3afc-9796-4fb7-7bd9-08daf3c3bb23 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT106.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7435 On 11/01/2023 11:44, Andrew Cooper wrote: > > > On 10/01/2023 4:25 pm, Oleksii Kurochko wrote: >> All RISCV_64-related stuff was renamed to be consistent with >> ARM (arm32 is cross build as RISCV_64). >> >> The patch is based on the following patch series: >> [PATCH *] Basic early_printk and smoke test implementation >> >> Signed-off-by: Oleksii Kurochko >> --- >> ...v64.dockerfile => current-riscv64.dockerfile} | 0 > > This rename will break Xen 4.17 I guess only if we decide to remove the old container from registry, which we do not need to do. We already have a few containers in the registry whose dockerfiles no longer appear in xen.git but are kept in gitlab for backwards compatibility. > > Now, as 4.17's RISC-V support was so token that it wasn't even properly > wired into CI, then this is probably fine. > > But we absolutely do need to be aware of the consequence before taking > the patch. > > ~Andrew ~Michal From xen-devel-bounces@lists.xenproject.org Wed Jan 11 11:31:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 11:31:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475211.736799 (Exim 4.92) (envelope-from ) id 1pFZJo-0006Vr-D9; Wed, 11 Jan 2023 11:30:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475211.736799; Wed, 11 Jan 2023 11:30:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFZJo-0006Vk-AU; Wed, 11 Jan 2023 11:30:56 +0000 Received: by outflank-mailman (input) for mailman id 475211; Wed, 11 Jan 2023 11:30:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFZJm-0006Ve-JF for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 11:30:54 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 680acd88-91a3-11ed-91b6-6bf2151ebd3b; Wed, 11 Jan 2023 12:30:53 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 81C1EB81B8D; Wed, 11 Jan 2023 11:30:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3D688C433EF; Wed, 11 Jan 2023 11:30:50 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 680acd88-91a3-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1673436651; bh=WJ96hH6M2QWhqMqos8NlJvpLqVVBxtYsuEjUoVykxZs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=X7a5KWZHBLMUkKm8d7N1mA+UILCUqbJnKRAWqBLYnqLFbEiClsPP+hZZV1xghrAa6 /mZHoqJZQ3wMqDA66QoIsvm5lc2i9xyw4j4Qa9qsBNa5/OJ4Pcg7bemhED9vtRGmtJ c/TGi6+t/6rL26PggxIY0N2xBa4fplpGKMUGxUKo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org Subject: [PATCH v2 14/16] xen/xenbus: move to_xenbus_device() to use container_of_const() Date: Wed, 11 Jan 2023 12:30:16 +0100 Message-Id: <20230111113018.459199-15-gregkh@linuxfoundation.org> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230111113018.459199-1-gregkh@linuxfoundation.org> References: <20230111113018.459199-1-gregkh@linuxfoundation.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1111; i=gregkh@linuxfoundation.org; h=from:subject; bh=WJ96hH6M2QWhqMqos8NlJvpLqVVBxtYsuEjUoVykxZs=; b=owGbwMvMwCRo6H6F97bub03G02pJDMn75p5iDqjYGXvtfmJbfiGLYEh0rmbzkQfMxlmZT6a8f3xz mmVIRywLgyATg6yYIsuXbTxH91ccUvQytD0NM4eVCWQIAxenAExEzINhnumZBRPTnvPn53v37j2tLX W4Ri/vPsM8/VuB8089evrezHar0ST1/HL+f+5XAA== X-Developer-Key: i=gregkh@linuxfoundation.org; a=openpgp; fpr=F4B60CC5BF78C2214A313DCB3147D40DDB2DFB29 Content-Transfer-Encoding: 8bit The driver core is changing to pass some pointers as const, so move to_xenbus_device() to use container_of_const() to handle this change. to_xenbus_device() now properly keeps the const-ness of the pointer passed into it, while as before it could be lost. Cc: Juergen Gross Cc: Stefano Stabellini Cc: Oleksandr Tyshchenko Cc: xen-devel@lists.xenproject.org Signed-off-by: Greg Kroah-Hartman --- include/xen/xenbus.h | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/include/xen/xenbus.h b/include/xen/xenbus.h index eaa932b99d8a..b31f77f9c50c 100644 --- a/include/xen/xenbus.h +++ b/include/xen/xenbus.h @@ -96,10 +96,7 @@ struct xenbus_device { unsigned int spurious_threshold; }; -static inline struct xenbus_device *to_xenbus_device(struct device *dev) -{ - return container_of(dev, struct xenbus_device, dev); -} +#define to_xenbus_device(__dev) container_of_const(__dev, struct xenbus_device, dev) struct xenbus_device_id { -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Wed Jan 11 11:38:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 11:38:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475218.736810 (Exim 4.92) (envelope-from ) id 1pFZRE-0007Ei-9D; Wed, 11 Jan 2023 11:38:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475218.736810; Wed, 11 Jan 2023 11:38:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFZRE-0007Eb-5m; Wed, 11 Jan 2023 11:38:36 +0000 Received: by outflank-mailman (input) for mailman id 475218; Wed, 11 Jan 2023 11:38:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFZRD-0007EV-J5 for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 11:38:35 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2057.outbound.protection.outlook.com [40.107.6.57]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7a1ddd81-91a4-11ed-b8d0-410ff93cb8f0; Wed, 11 Jan 2023 12:38:33 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB9521.eurprd04.prod.outlook.com (2603:10a6:10:2f3::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Wed, 11 Jan 2023 11:38:31 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Wed, 11 Jan 2023 11:38:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7a1ddd81-91a4-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MmorWcLXUTBm0fwhXjDg8q/RuRnCA2qvyAe32Oef1q19kzVOsqnYJNJG/1qL9z9rxMB1slBrEntBb1uSXAHCbIgFZBe6MvnLxeZAP+Aogv3MJbvVLn4epnprz+VlL9F70ujhKhdLcbnbylIdDZpmJmcNfSJKx37H5MTvrEIXD3r+dMx9UmBsBrezccB9fzk/e1p/m1/qUWE2u3oC3VD9Ha3QzC8hcNBkq07O+yMLOJLLRCQCFRYw0Nh08lNxlfaw87+G7QDeav3n7Z6Fp6pZ+kWWyNq0D+5L+m+IXFV09vacxFIHmMlIOQWtCS3wSehdmfVnCxBBr2OXwJBfQ/+cwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HsNHV6GLY/1LSfhSE0JxMz7TRDlapBwsAEehfvWhyro=; b=ExXA5dN0DkXUdHMV1RpmuhyPLWF+1bFrHr/sk/WE+z/3eL4YDSLmt8Y3pUtQooMTT6tQoNxuG41RfhuwhBOSB5jSSpLTr9DR5b2gKWilMTjFxBMm6+j0PvaZlc2R5Hdn3B5eLuCS2KRI+O2qXtrWRLTjrA6vz4LvhpWz9uaqbDD1LqSgeBeoIAUWnBDvcSGOhfQnmrBpcGkfdVtrhwYJ02eMUAF2799YEJzscrPC4S0lDedVxZ+LxfvxqUJHNSZpH+uOx6W89dFaEhlmarzqOeoIQqWwobawkocui91kLLvCZNRokq/R2/21YU2+75YvUgNDa2chsHni3lH6APoqew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HsNHV6GLY/1LSfhSE0JxMz7TRDlapBwsAEehfvWhyro=; b=U3/tihuM+zAng1mquLq8qNdycLwq5G8s8HS2UWSCRBPI6B3LheMDcSxr/Fym1YY7BLc/d3pWGSct3FxZoDJfpfk0plgY7wG8oJp27emlpGD9RFoIg1cspt/6d40hr+0/4EzBjoSxcngPM5n3Q2WL5jQVLcMDtWXNsgPZLqEKJc6vbfUXUeaeS2XSW2xXOaOdskakX+hlK1N2JZhMz2OJ5e2e4Wm7qZi43zJAfi0En1mW3jr2oLs0xAr04wOpR0HZqEp+wfNoPs+U4zgaQCKRLXVktNRLB3+9RCGzTWrpeez84KazHUvs81EVlnM6YtuQc+nfNEkID2CVpN4e6j0HOg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <644334f1-8e1d-3203-e942-0eb3ef5584a9@suse.com> Date: Wed, 11 Jan 2023 12:38:29 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v3 2/6] xen/riscv: introduce asm/types.h header file Content-Language: en-US To: Xenia Ragiadakou Cc: Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org, Oleksii References: <06185fcfb8cbd849df4b033efa923b55c054738d.camel@gmail.com> <1b6ee20d-2f32-ab38-83ec-69c33baf42fd@suse.com> <0398c48c-cc5d-a4fb-354f-54e3c5900d18@gmail.com> From: Jan Beulich In-Reply-To: <0398c48c-cc5d-a4fb-354f-54e3c5900d18@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0056.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB9521:EE_ X-MS-Office365-Filtering-Correlation-Id: cdd39ce0-1def-44be-07c7-08daf3c85d15 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1QxpyuAnAkK+5rK6x/5wnfb7bHbfTmtAI6hQZMEwDX2aJwA252KeYg1hiorvNlY7NrdIdoE/wBCumRe40fkM4PRSxjr40R8En4PK9U3ZXAFNsg/yKlG4EoKZnngq2VQ+yJeAG8euO7MdIuxG3RH8ogKfNlAB3RBqh1Afk2CnlbY2Ky00TyJrcrbZTJrC2slVRJ3Kzs+DFXH+4ODxd6ED3hcPcAsdORG/UClpPeQhjQN+6DGhnXSn68bbAgnSxznknS63OB33DND5v8YoAizj8WAwk5P2t/xw1ejNwL1rms9wPzFNBEaUHxwrTh2m5odC2F/A2RlXjQ9wQDiRSJxmt/vU7TVC1XVqfQKI5rvoqJ9uKrbtsk44ITso99nzH45lTh/8SRGIAXPeEETbJQanDQ9vZHpxloWbO2Kb91Ed/00BDtVqNi3d3vcHv1pDeQ1VAaHxX9evQl9DCZHzFdcGzl1k1pWr+VR8yBwGRuSrYpqTjVtp+x/t06ZSgoGocqAY4+8VQ27SoBITPEg18Nb/b/mo15oPwuFnQmPvQRyyGKinI+xyOMV/jWdQDb57PY7O0H8V2e5yIAyFVhH1s+6G5fkxiy7mxaBgIRDlM2jLm4gEq2UJMhpu7fML42YRH/d2yhCeaYyb3YAMhmweZpZWqFcl/2GAaTzWNwSAmzoLTYFtn+B1ucpcxwGdord0EEiAPstGyJ0trGlasLgAGiehxBAYX79SjZMBHpKXYgKQwP0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(366004)(396003)(346002)(136003)(376002)(451199015)(36756003)(26005)(186003)(8936002)(53546011)(6486002)(6512007)(31686004)(6506007)(2616005)(66946007)(5660300002)(66476007)(7416002)(66556008)(6916009)(316002)(4326008)(86362001)(31696002)(38100700002)(478600001)(54906003)(8676002)(41300700001)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TTlzSWszVDdDeVJNcDlvYi90d0xpR3ZiNExRYjdlRTlqVlJQcGlRdFdIWnVP?= =?utf-8?B?YmphVTFPUVhlelFveHBVd3RoVjkxTEhMNWFCZEpOeStTTTBhSGE2Y0NmamRR?= =?utf-8?B?dVNvZ09xc1hyUFpjSTVXR2hhbnJud2t6cVFEUGxGQmdRWjFTay9Ya0tGOEg2?= =?utf-8?B?K2xmUXp3SlVpbXJvMmpYZTZIeW1hQXRwVTZqd3BTOGRxc0lvd3N4ZDN2Y2VT?= =?utf-8?B?d2htdUEwSVczaGU5ZGxxcXJwZHpuSlQvaHZnSDl5WHpieWFEc2lDdXQyeFBP?= =?utf-8?B?LzF5azFkODFLbTRNZisxK0JkVkhuK3JwYWdLYm1qQmhsMVRaVEE5NTQweUVx?= =?utf-8?B?MWFUSmtkWVoyRWJnbms3Vlh1elRrOXdFNGZuejErc2Urc21kOHk1UW9Pc05q?= =?utf-8?B?RGZjbWFBTE91Nk5lWEFsK1hKZldEVFNtdVU3YnZpUVVGQ0VmTEJxSVVwVzgx?= =?utf-8?B?NHVBY1dpQkVPQXoxZWNoeVc5UWNnTGdaWnA2T1BIaHU1dkwrcjR1YndhZHRk?= =?utf-8?B?QlpDV0U0U1JFWmJhZW1NMmV4ZlZEajdQOWh0d2lCWTQ3Rm1JNmZiUzFIQmd0?= =?utf-8?B?MWFiSHlDQm5hTDFxM0x4cUkvS1lYM3NMT05jalRZVEJITmVIbTNjS3pGaG5a?= =?utf-8?B?UXRDU1hTWUdrUngyNytPbUtnTVVXOTFWNkp5dHNzRTNCYmdtTDdZWEdpQXNu?= =?utf-8?B?d25wZmhmSXErOFBBdnIya1c4V05NMlNQeWF0Wkt3eHh6dWdsMzZnVkxjYjhZ?= =?utf-8?B?SHdCMUhRM0NaSVoxYmdjYk9TK1dsejBoSmFBNG1wRXZzUEtWNUU4WjNUZGZm?= =?utf-8?B?dkdvUHo4WDJFOVpocXF1ajRoNkJ2R1VLeVZzVXdCb1NmMWNjYVdzdEppTFFD?= =?utf-8?B?Mk1RekNQTE1kMXFGajNuZHNBalorcStSaHpSQ2lKNWk0b054azdlU3RoOGtu?= =?utf-8?B?TWNHdmNBMVUzeVdkMjlCVG1SbksyYXA5bFdzZDBTVmJuczRKekFTZlhvTnBq?= =?utf-8?B?VE1UT3kwQTJUd0NPZC9McFBueExTcGhpMEcwOHRVd3Y4dzB2bWxENjBsbXMw?= =?utf-8?B?MGJielNVdm5WNytBNjM0ZXZuVkhaWS9EdVA1dTJmTjhXbkU0WWFhOXEzZVRj?= =?utf-8?B?aUNMWDZIcXNjOXlCaG9uMllTbEkzNFp4NVA0NXoxOXBHWjhHVVBIcVVMZFQ3?= =?utf-8?B?aVZxekxPWGVDQ3pWdnYzTDVkWHVrdjVZUnJ4YklXUlU4cjBIdkN5MVd2bE9C?= =?utf-8?B?cTdxelkrOURJN05vdzMzRW93WVNNOXp1TStpQmtVbk1ydXVPVGp0ZXN0eEdB?= =?utf-8?B?RDAzZjBUd0FxdmJTRDNTeUwxcmFqS255OHQvaEkvR2k3SXVmT2l2TFdTSnlu?= =?utf-8?B?OWN5TUhBdFBPVVlNZG13b2tOYXdlcVJYUUV1YWxIbjFwRjFuQnFMNlZzMWpI?= =?utf-8?B?dXdFSGtmOWtjeCs0VVFkTGRuUUZ1TWUrY1FhUDdmN29YYTNLRGhDK0RsQWFr?= =?utf-8?B?bGpHcngxdmQvOTRIL2hIaHJHenpOajhJWlAvd2RCYWg1Yk1iak91b2YvSHJX?= =?utf-8?B?ZUQ0bm95eVBGOXhBTEJ5TmZ3WU5nZGFRRUl3Yi85L0ZXUWZ6czMrV2xsNnEv?= =?utf-8?B?VnNJVnBkalVNWnVFR1J6RklYT3BHNXNaQjZlbEhDV1ArcEhYa1JOVksxeEVC?= =?utf-8?B?eG9ydTYyS0JZVXJEWHFTTGhJK2Z6dzRic0h4bkxjMHVTalNHMWg1OU95cXZT?= =?utf-8?B?c3F4SlZJNjhxN0REZXhHVVJOYWdOMmFuZ2ZBais1MWxwZUJmMnhaRzJrZ1lv?= =?utf-8?B?ZVhrN2dSUzZYT2RkUUVrMUU1aDlQbDJHYVZNK21EbEk4cmR3b2V0QkZQZHV3?= =?utf-8?B?eHFlVWlOdUpSOFdBV0ZiV3lVNDhQcVY3aXRXTk8vcWh6MTMySHNwai9PRGE4?= =?utf-8?B?ZVQ1QmZsbVlHT1JxamlJQXJOMWpKWGlGdmNVZUxsUlJRSThjakRGalU0aGhw?= =?utf-8?B?ZWNlS0V1djMyNTN1OWFGU0p4Y3NUOU04TlM2eTVPWXR0dlMwOGZCREUvYno1?= =?utf-8?B?ZFcxRmFWNGFBa3ViaWJaOE1QUFpZVTdTODd6a2gvK1pyTWlMM1pYeTUxdTdY?= =?utf-8?Q?OqnWzY6W4fJhYWM6750JaCLMU?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: cdd39ce0-1def-44be-07c7-08daf3c85d15 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2023 11:38:31.3889 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CS5BT7ae0nD7cdP76EmTm+mRW7ypC0UVQ5EnOZOyzNUR4cxxIsdk8i8grUqMjOwN8JewRDDuIYxIH/WWVJ4TNQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB9521 On 11.01.2023 11:22, Xenia Ragiadakou wrote: > > On 1/11/23 11:08, Jan Beulich wrote: >> On 11.01.2023 09:47, Oleksii wrote: >>> On Tue, 2023-01-10 at 17:58 +0100, Jan Beulich wrote: >>>> On 10.01.2023 16:17, Oleksii Kurochko wrote: >>>>> Signed-off-by: Oleksii Kurochko >>>>> --- >>>>> Changes in V3: >>>>>     - Nothing changed >>>>> --- >>>>> Changes in V2: >>>>>     - Remove unneeded now types from >>>> >>>> I guess you went a little too far: Types used in common code, even if >>>> you >>> It looks then I didn't understand which one of types are needed. >>> >>> In "[PATCH v1 2/8] xen/riscv: introduce asm/types.h header file" all >>> types were introduced as most of them are used in : >>> __{u|s}{8|16|32|64}. Thereby it looks like the following types in >>> should be present from the start: >>> typedef __signed__ char __s8; >>> typedef unsigned char __u8; >>> >>> typedef __signed__ short __s16; >>> typedef unsigned short __u16; >>> >>> typedef __signed__ int __s32; >>> typedef unsigned int __u32; >>> >>> #if defined(__GNUC__) && !defined(__STRICT_ANSI__) >>> #if defined(CONFIG_RISCV_32) >>> typedef __signed__ long long __s64; >>> typedef unsigned long long __u64; >>> #elif defined (CONFIG_RISCV_64) >>> typedef __signed__ long __s64; >>> typedef unsigned long __u64; >>> #endif >>> #endif >>> >>> Then it turns out that there is no any sense in: >>> typedef signed char s8; >>> typedef unsigned char u8; >>> >>> typedef signed short s16; >>> typedef unsigned short u16; >>> >>> typedef signed int s32; >>> typedef unsigned int u32; >>> >>> typedef signed long long s64; >>> typedef unsigned long long u64; >>> OR >>> typedef signed long s64; >>> typedef unsigned long u64; >>> As I understand instead of them should be used: {u|s}int_t. >> >> Hmm, the situation is worse than I thought (recalled) it was: You're >> right, xen/types.h actually uses __{u,s}. So I'm sorry for mis- >> guiding you; we'll need to do more cleanup first for asm/types.h to >> become smaller. > > What is the reason for not declaring __{u,s} directly in xen/types.h > as type alias to {u,s}? > > IIUC __{u,s} and {u,s} are needed by code ported from Linux while > Xen code should use {u|s}int_t instead, right? Yes. Hence in the long run only Linux files should get to see __{u,s} and {u,s}, perhaps from a new linux-types.h. Jan From xen-devel-bounces@lists.xenproject.org Wed Jan 11 11:40:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 11:40:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475224.736821 (Exim 4.92) (envelope-from ) id 1pFZSo-00008T-K3; Wed, 11 Jan 2023 11:40:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475224.736821; Wed, 11 Jan 2023 11:40:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFZSo-00008M-Gg; Wed, 11 Jan 2023 11:40:14 +0000 Received: by outflank-mailman (input) for mailman id 475224; Wed, 11 Jan 2023 11:40:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFZSn-00008F-4r for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 11:40:13 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b3a1b7d0-91a4-11ed-91b6-6bf2151ebd3b; Wed, 11 Jan 2023 12:40:11 +0100 (CET) Received: from mail-bn8nam12lp2173.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.173]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 11 Jan 2023 06:40:01 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SA0PR03MB5402.namprd03.prod.outlook.com (2603:10b6:806:b7::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Wed, 11 Jan 2023 11:39:58 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5986.018; Wed, 11 Jan 2023 11:39:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b3a1b7d0-91a4-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1673437210; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=Npg4FEh7fyagYb+edMrpBphe4PX+wjiTOlTdbORlpiw=; b=DGowymT0p4m1+xJ/CJ+XAz8x60/dHxo9KQ2G3z/azao0vP5Pybcxmp1j cXv9HxMNM0iCyy3TK/BglkgaYDPMp8dLlYXHgKlK4kDqWDA7JqaCcPRxp i+JuVIB2XLAEqtpFjCrS/2wx1BkN9yuHcDAzEWut6fPLFNT3vJ8PectXQ 8=; X-IronPort-RemoteIP: 104.47.55.173 X-IronPort-MID: 91581756 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:IpC0JqMbyQodUq3vrR0QlsFynXyQoLVcMsEvi/4bfWQNrUoi3mcCm DZLC2vQPffbZzfwfI92Ydu+8RkP7MDWyNdmHgto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQA+KmU4YoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvzrRC9H5qyo42tB5wVmPJingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0qFLAUp02 d1AFGAcfjWInNKMxKyHVOY506zPLOGzVG8ekldJ6GiDSNwAEdXESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+PdxujeIpOBy+OGF3N79U9qGX8hK2G2fo XrL5T/RCRAGLt2PjzGC9xpAg8eexH6rAd1PStVU8NZqsAKU+mZQFiEVUHm3mt6yrXPhQo1mf hl8Fi0G6PJaGFaQZsHwQxCislaFuBAGUtZdGuF87xuCooLW5A+fDHIZQSNMctUjnMAzTD0uk FSOmrvBAT1pra3QSn+H8LqQhS29NDJTLmIYYyIACwwf7LHLsNFtphHCVNBuFOiylNKdMS3/x yCiqCk4mqkJisgKx+O38DjvgT22oYPSZhUo/QiRVWWghitjbYCsaoiA6lXB6/tEaoGDQTGpr HUC3sST8u0KJZWMjzCWBvUAGqmz4PSIOyGahkRgd7Ej/Tmw/3+ofahL/SpzYkxuN645lSTBZ UbSvUZb4s9VNX7zN6tvOdvuUIIt0LTqEsnjWrbMdN1Sb5NtdQiBuiZzeUqX2GOrm08p+U0iB aqmnQ+XJS5yIcxaIPCeHo/xDZdDKvgC+F7u IronPort-HdrOrdr: A9a23:aMabnKi4ttMCk/3wriADwlyW4XBQXh0ji2hC6mlwRA09TySZ// re+sjztCWVtN91YhodcL+7WZVoLUmskKKdgrNhRItKPjOWwFdARbsKheSN/9SJIVyEygc379 YFT0ERMqyWMXFKyevBzU2fNf1I+rW6GaaT79v2/jNWYTsvQYdGwCdWNj2yL21RY019KadRLu v+2uN34zWhfHgMbte2HBA+MtTrrcHQiZTjbQUnKnccmWuzsQ8= X-IronPort-AV: E=Sophos;i="5.96,315,1665460800"; d="scan'208";a="91581756" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n9z0banVAMugsDsjsV0tOampXUeLXbTxzTf1kK7yOrDGo4UTiVNUXQSLuT+uqjTEmU3Hb1XLRVOfb8A9/LJqSBXJ0BJu32KIHrW8WO4B7UY2OfrdngNxNwNIuiM5viXA/FaMRWEpUGv7Ks1UU3q3AeE+JBH+QZ+weidcSBRn7btv3PettSk+wjkILIib8xNSao4l7spHfKbaaqMzvv2WSXnoQgxIvM0aNItLIg3VbRNs+UlDFUoCdpi2eloKZz6fmrlYy60SuzvWCtGLw5COWuzzp7Z61HOrqDggcl+h/5X8vBUo5YgNqPCEdfk9ukzadDuW3uufftELXDnF0gqXNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Npg4FEh7fyagYb+edMrpBphe4PX+wjiTOlTdbORlpiw=; b=NcxYxjRIVWzXsBw0/rCBpVQB7SQ9K8QFdojr88LyElAi2sH6mN8POPc8zICX+CGUy5LYPES6ia2L1P4KYOgIcj9cVqw1Tz39C8fEb1VbQA8gT9VISI/Y1PTBRJR0NNoo980uqW3CRuczC3HQcMe3TZVXE6z0rY1IUuOfvzu39Fz2Rqnm7ODfT6iOjCg2aAgXJfx2rEA/wyknqtMciDbWH9VMC1bUUsbxP63S85Wjd9C+hzLTwTnxZhU7w8Ahc6J7VI1h/cnGeemYlb4iJdaSK7iHPHYa5v/NwOAHKdU+eGkzIKHIE4FdqX7/Az9A+Fbfh0nmIoYBX1ndohQw7XTBwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Npg4FEh7fyagYb+edMrpBphe4PX+wjiTOlTdbORlpiw=; b=U2imVUrVMzCxLd6YBSraBivx2FPpHGJ52JzzUkTpluQYmihxnwtTGXQGnbfQsU5lD9r9YZNdl3wXgXQv7GJeKSJFpmgZrnW8PshUUbtYOzof7gDAVIO531UUrqKPc0+1zKEZ/7GKDxMrZ0QHaKGkDRI145IihAAbPI84RVqXF9Q= From: Andrew Cooper To: Peter Zijlstra , Joan Bruguera CC: "linux-kernel@vger.kernel.org" , "x86@kernel.org" , Thomas Gleixner , Juergen Gross , "Rafael J. Wysocki" , xen-devel , Jan Beulich , Roger Pau Monne Subject: Re: Wake-up from suspend to RAM broken under `retbleed=stuff` Thread-Topic: Wake-up from suspend to RAM broken under `retbleed=stuff` Thread-Index: AQHZJa6+C7zgK+BmnkyxcC0/cTTk966ZF36A Date: Wed, 11 Jan 2023 11:39:57 +0000 Message-ID: References: <20230108030748.158120-1-joanbrugueram@gmail.com> <20230109040531.7888-1-joanbrugueram@gmail.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|SA0PR03MB5402:EE_ x-ms-office365-filtering-correlation-id: fa5edb11-4719-4c3d-2944-08daf3c89113 x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TlpLLYxC/5fSK0lPqZH8Ueh9UtfVynvOyoZdJlLi8fHDuvQA3Gm7OSgiR44CV3cLUM6kRyykRnp2PMfXnlkGvTZRwQ/3+nelIdo1/MLuoGDbu7bICdfVn/GYEkK1w/nxJqT5FmK448DypO+Wid9QJPsJhYCpv8CdU4NOyfd5MQ9GZ5acajOPZCGJGwpei24x0tJVI7zO2sbQvo7PvoBm8fAyswvVPNKyyt97sPFiR2GUtndefFSHYvu+KRuJ2zgzbjSHYIP6JfWag8jEQfIcjOpvXpKrVV5ULrQzMpfHwpzEDLDxNdhi8EdQrUR7pLOAwJcsiaD37JaMl1P2X+uyYfUBEIQQyXeixY90s3CqXylQERED90afvimrwl+HPDegLeA1t9+HmUAp3/JzOTJzJKpXgY3SLDrFvp2HKBNfyToHlB8FjXy1iw9w4I+FWbk+RAv3+NCx+K5bUPQo/cVkfpi8RWLa5ifyB7XeZyRIdDuTSHWaGNFEdH4q0G1lsABmnedxHQFCTKTnLfOv30MIzfE5Mabe4ZcG3O5LmbBAeIMGkjKbAmWSEsIYZoVGqdR2AYwkfIfKQXylF0dWQl/QWZ7UOyf9D/RSpl5O/gd2s/pguGn7+C4fKP54JyU0WaU3b8bPxHiuhKdHKvQnGhTm3qzrOMAeSKM+aA55RIiLkj4QCm/5+LSHBcHx4HX5kYHWkKD3kwqLRKcYhVG9LV+rDrAOMPAFVbS8On8hm47QduTLTchYyEfNG8NxHi64PJ+5vRyqECTQCjFPIgRI+mLzHM8dqylwwI/9ny1+LSjtpXs= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(136003)(396003)(346002)(376002)(39860400002)(451199015)(7416002)(316002)(5660300002)(71200400001)(508600001)(6512007)(26005)(186003)(6486002)(2616005)(31696002)(41300700001)(66556008)(91956017)(54906003)(66946007)(66476007)(66446008)(4326008)(8676002)(64756008)(110136005)(76116006)(38070700005)(8936002)(83380400001)(86362001)(36756003)(15650500001)(107886003)(53546011)(31686004)(6506007)(122000001)(82960400001)(38100700002)(2906002)(81973001)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?RUdpeFd1eGpnYVg5eWRIbEVLRkNqdmJlMG1CTEU1MXlXdFBoREhBY1FmcFhB?= =?utf-8?B?UkRpalErUU9aMkxXT1Nsd2tXaUl2MjFZaEtyaXdreWc4UVBMUEJwNUd6Wkh5?= =?utf-8?B?OFRZQXdadzU2RjJ2c3doN1BvQVhMT2hxYjhLTEJaSmxMZWNnVVJDalY2ZmN0?= =?utf-8?B?U2l4TjNndjFLSzJzUHA1VE5paVFFQTNhU0JCQ0pjQ0ppcFlaNHJTNHJiM3lL?= =?utf-8?B?bnllVVNZNjNKYXFhaWNYd1dkMEJXLzg1eXI4c25KaXpzbDVzUVIrRnl5clN0?= =?utf-8?B?ZFdmd1ZKMHZkcXBpRFBuS3pDQklOQklLVGdCWkxnME1YcGx2YzRjMlhJeVpW?= =?utf-8?B?QTF1T3Z6alpSblVHZ3RwdFdEL2d0cjlVTW1ycmdaYlQrRlg4NW9KWlVNdHFr?= =?utf-8?B?S3UzU0tzUmZ4V1VGem9rT0lMeENkOXJscnlWTmt3aUtWalF2L3hIWGJIOWxi?= =?utf-8?B?L3FrcmRMNnVOQnEzMVM4bk9aMjVqZUxNeTZETnhUVUFYMmdxQUo5cFI2N0Iv?= =?utf-8?B?QU9HYUlBeVJNT05MdGw1K0NoTXNqeFZKaHhTdVVFd3pXeWU5em8wellWY2Fh?= =?utf-8?B?RGFkQkR4blJXMUkrVXQ4aExvMm0xc0h3eHNTbGFSOVN5czdlMHUxWGtDcjBm?= =?utf-8?B?QlN4ek1xaEtsSlF1VjVzdjVTb1RpcXZYWlpDSVJqbGdDa2F1Rm9SaS81QWI2?= =?utf-8?B?dnluMHpDQmZDWVk4YTF0NmNVYnlwTDl2R0pJL1EwRDlrbUZPQXpkY2RTQlpZ?= =?utf-8?B?UjNnSWl4RTBNTktFdUswOUxCYmZhLzBFZ3g4aEk4UUl2TjQ3S29ST3lhOUtl?= =?utf-8?B?djBQRjIrcVVxek5jRkZERFZqRjc0MURHb0dvYndQZitTR3ZKNjM1ZXhKTzlv?= =?utf-8?B?UldZNklNNFJIOEIxb3p6VmVKZEJOZTRBYUp4NmZtU0lsM3pDZHgvTG0rcjR6?= =?utf-8?B?WnRYWG02UlFjZ3Z6QnFVSDNUZDZzQzhWVFhRRGRxaHIvbGpvWHdHV2lDbFJV?= =?utf-8?B?djRjMmZFQzBDVmxhSCtta0VtZlpOQ0pLWUgxOGNueE1vUnBhZHJNWkVFTDhU?= =?utf-8?B?SFNqZWVZOHI3cDE5QS9jcnV3Zy83cWNxZkhpekRUZDMyaFh2WEVldXpoc2di?= =?utf-8?B?akxxSmhVVXB2bUJGZmZZQWxjTkErc0dkdnk3VzIxazFubCtWNklHYmpLWFEz?= =?utf-8?B?M1YxNFBMMHhxNDJTVS82SHNxc3QyeDBDcjRzT1JwUG9PQncrRUVaL0VkU1Z0?= =?utf-8?B?eFpZcWZSaEZwMVVJVzIzM1VYWndpOXR1VlAxK3c1eE5mOERhYjI1bmJPWHVy?= =?utf-8?B?NXJhZmhPS1RUdWlXWGhpa0laZG5tUHBRMnJ1Sk1ETm0xWjE3UXdXK21zQWRz?= =?utf-8?B?U1lnNXBZWjQzL29Da2RXTFB1cHNOZkNqRmhuRnV1eWZHdHU1Ym9kZmd6Ujl6?= =?utf-8?B?TkwxanhwZkhYeW9Fb0QyQjJzalRiMDRTU0dlbDkvcDBkbDNzZUVmU0JraitO?= =?utf-8?B?bU80UmFLZWRwMFdabHpqS2krRUNXOXFFRWVrazRyclNqUmV2Z2NhUzFKUit2?= =?utf-8?B?WjVNK2xKempjLzNiMTNXRm9EeWVLNGk3LzZhYjBtbHAyYk1KNTZMRU45ZFdN?= =?utf-8?B?RTlHd1lXeS9YQy9aL2VIbHgzTENsbTBPOXJGY1FlR2ZvUXhGaVZiZjdhRVpB?= =?utf-8?B?T01CNnhPR3YrbWM3eUVmOE5iazJuazlzUjFJdjFLSXp0dFZleFMxV3Fsa2pJ?= =?utf-8?B?T0VLcnQ0VlVUNXliOUlINy9NcVlZcUtNSjRmVEdWN1p6VnBOeHQrZ1NhVUhu?= =?utf-8?B?eDQ5OUdkMDhtU0hYamVSM0NleVd0cTVPakVETWZHVWJRdnRxSkJjaGo1R3U5?= =?utf-8?B?eHJjT29QUEdSclFFeVp0VE9JRDRaamJKYmUzMTh0RmI4UUlnSTFLVjlsUzQy?= =?utf-8?B?MXFIeng0dEFLRGJvblZTOTNQVDlUSjlIM0pjRVptVzBQeDhwNlhBdnpGQjJz?= =?utf-8?B?S0ZDbkRtZ0kyZG9zODd0QWpIenQwc3JnTzNVTHpITXcvQzEzVGRVbFRtSXZZ?= =?utf-8?B?MGI4QVVDVzJiSGRrU3haUHl0QWt2SnV0TmRNRkVsQi9CVWd4QTlzNXR5d1Rv?= =?utf-8?Q?ENucGTdwCeR05/i77KMV+t1pq?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?YTBSc2tkS3RTMThhMkRzODdkb3RKWk9VY1dRZm5oTk5WcEpETmpyL01Xd1Ji?= =?utf-8?B?MGh4WDQ2cWZnYUtsaTM0U3ZhRFY5c25qT1pPTSs0WkQrWVZoKy9hK2Jhb2d5?= =?utf-8?B?K21ySmhRWjl0bXAxaStDN1dyL3hVcFNXWUI5M1pFRXM2dDROU2t4R0VoTDk4?= =?utf-8?B?ZHhjWitkYURiVStteEdjczY2V05UaGh1bWxaaHg3MlFaUVJwYzkzbFArN0R2?= =?utf-8?B?WXUzelpYbnVrSk9uSGhXTjlwTjllRmZnSjROZXp6NjMweW9MamlvUmNzVDJ4?= =?utf-8?B?eFNFSHlFRDRqNkUvU2c4bWd2YjJhZnA4dEo0aE5xOWp6RzNWUkZqaGtwT2JB?= =?utf-8?B?ek5yc2VxVTg1cmZqcFprdVhPbzUzbzV6VmV6VXlrOWNGakx6eGRsR3RIeHNW?= =?utf-8?B?Y0h5QkJpOVlJSTl6R25uMExiNUJ5TGUrWDN6Wlo5TVJQYkJ5cmd1STV4dWhE?= =?utf-8?B?M0RzZHY4bzcrMGlpa01lR3ZpNnZrOEoxNFViLzFlWnVrRHoyVm1oNnFVSEN0?= =?utf-8?B?UkJlVzd6U2dNYi9hWWZxSElMU3B0ZjNYYld0SDljNzZpQjAxWmFBT3BQQkg5?= =?utf-8?B?bEJOLy9lY05rZEhsQ3pLQ045WGI3MDVXZEhxaFFBeWgzcVQ0Nm56Zlp1eGtS?= =?utf-8?B?R0pTOUw0VjZ0WXVuUWpPVkVwRUxPSjI3cDFraGp3Q2lmVHdpUWx1ZG1jSVEw?= =?utf-8?B?Y2JUUjNOb3luVWtaRURVNFV4SHFjSThuaXhlVWlyNkNjbDBDa0h6NGNLTnNp?= =?utf-8?B?dWQ4SHBMV3RXaFoyNnQ2UFBvRUVFRDFTaThUa0tlT3ZPTXZwYmh0aFAwUDFu?= =?utf-8?B?MzNLdmFNZ3BYNHQreWJKQTJFV1lWKzA1Q05FelNPTVdUeWlSQ3hBN1ozL04w?= =?utf-8?B?bk5FMlljRWpqTERjTGtDVGVMUUZFS2xjVjFSWXdmbUU1b2ptMmYzVGNwTkRl?= =?utf-8?B?ekd4U2VGTFlmZStFeXlkZUp0K1FlMkxDU3FpdzRLRlRaTURUZzJOS2tETHAx?= =?utf-8?B?Wk45QWhaUHROVTJyRm9BRVRTUmpNdUJYcWFWaXRHLzBTbDc0aGRCeVhGaS9S?= =?utf-8?B?Y01wa3RSRFZIaDBQdFVWcURsZjAxZjEzb09RU0F2UGtCRkZuVWRaMVNLZzJz?= =?utf-8?B?c1RtcmJ4Q1JIK0w3blI4Y0IwZWZkOXRQVUpDdnVEYWJ5bmlsUVVsWEZkYktE?= =?utf-8?B?eHgzc3V5Tm1ZM3pXM3dNZFNkaUVTa243dlpkQ05iZkdkelRmTGRBMSt6NDRa?= =?utf-8?B?NVZaNXhPeVJKazhTSU5VTms2MHl1czVKNjdqMFFOTVduVU00eC94aTNhc3lI?= =?utf-8?Q?8QXXdN+5Kf5zA=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fa5edb11-4719-4c3d-2944-08daf3c89113 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jan 2023 11:39:57.8838 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WBAE67blKJopvNNxCVLXsIDkZ5dQBDoa6whsJj3QEgw0yWavIv4M9cThC5Gc6mL6GNrwtLkoCJLWFXxnb/JpmkFmvGzkLOl75T2HQJfBwTs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR03MB5402 T24gMTEvMDEvMjAyMyAxMToyMCBhbSwgUGV0ZXIgWmlqbHN0cmEgd3JvdGU6DQo+IE9uIE1vbiwg SmFuIDA5LCAyMDIzIGF0IDA0OjA1OjMxQU0gKzAwMDAsIEpvYW4gQnJ1Z3VlcmEgd3JvdGU6DQo+ PiBUaGlzIGZpeGVzIHdha2V1cCBmb3IgbWUgb24gYm90aCBRRU1VIGFuZCByZWFsIEhXDQo+PiAo anVzdCBhIHByb29mIG9mIGNvbmNlcHQsIGRvbid0IG1lcmdlKQ0KPj4NCj4+IGRpZmYgLS1naXQg YS9hcmNoL3g4Ni9rZXJuZWwvY2FsbHRodW5rcy5jIGIvYXJjaC94ODYva2VybmVsL2NhbGx0aHVu a3MuYw0KPj4gaW5kZXggZmZlYTk4ZjkwNjRiLi44NzA0YmNjMGNlMzIgMTAwNjQ0DQo+PiAtLS0g YS9hcmNoL3g4Ni9rZXJuZWwvY2FsbHRodW5rcy5jDQo+PiArKysgYi9hcmNoL3g4Ni9rZXJuZWwv Y2FsbHRodW5rcy5jDQo+PiBAQCAtNyw2ICs3LDcgQEANCj4+ICAjaW5jbHVkZSA8bGludXgvbWVt b3J5Lmg+DQo+PiAgI2luY2x1ZGUgPGxpbnV4L21vZHVsZWxvYWRlci5oPg0KPj4gICNpbmNsdWRl IDxsaW51eC9zdGF0aWNfY2FsbC5oPg0KPj4gKyNpbmNsdWRlIDxsaW51eC9zdXNwZW5kLmg+DQo+ PiAgDQo+PiAgI2luY2x1ZGUgPGFzbS9hbHRlcm5hdGl2ZS5oPg0KPj4gICNpbmNsdWRlIDxhc20v YXNtLW9mZnNldHMuaD4NCj4+IEBAIC0xNTAsNiArMTUxLDEwIEBAIHN0YXRpYyBib29sIHNraXBf YWRkcih2b2lkICpkZXN0KQ0KPj4gIAlpZiAoZGVzdCA+PSAodm9pZCAqKWh5cGVyY2FsbF9wYWdl ICYmDQo+PiAgCSAgICBkZXN0IDwgKHZvaWQqKWh5cGVyY2FsbF9wYWdlICsgUEFHRV9TSVpFKQ0K Pj4gIAkJcmV0dXJuIHRydWU7DQo+PiArI2VuZGlmDQo+PiArI2lmZGVmIENPTkZJR19QTV9TTEVF UA0KPj4gKwlpZiAoZGVzdCA9PSByZXN0b3JlX3Byb2Nlc3Nvcl9zdGF0ZSkNCj4+ICsJCXJldHVy biB0cnVlOw0KPj4gICNlbmRpZg0KPj4gIAlyZXR1cm4gZmFsc2U7DQo+PiAgfQ0KPj4gZGlmZiAt LWdpdCBhL2FyY2gveDg2L3Bvd2VyL2NwdS5jIGIvYXJjaC94ODYvcG93ZXIvY3B1LmMNCj4+IGlu ZGV4IDIzNjQ0N2VlOWJlYi4uZTY2Nzg5NDkzNmY3IDEwMDY0NA0KPj4gLS0tIGEvYXJjaC94ODYv cG93ZXIvY3B1LmMNCj4+ICsrKyBiL2FyY2gveDg2L3Bvd2VyL2NwdS5jDQo+PiBAQCAtMjgxLDYg KzI4MSw5IEBAIHN0YXRpYyB2b2lkIG5vdHJhY2UgX19yZXN0b3JlX3Byb2Nlc3Nvcl9zdGF0ZShz dHJ1Y3Qgc2F2ZWRfY29udGV4dCAqY3R4dCkNCj4+ICAvKiBOZWVkZWQgYnkgYXBtLmMgKi8NCj4+ ICB2b2lkIG5vdHJhY2UgcmVzdG9yZV9wcm9jZXNzb3Jfc3RhdGUodm9pZCkNCj4+ICB7DQo+PiAr CS8qIFJlc3RvcmUgR1MgYmVmb3JlIGNhbGxpbmcgYW55dGhpbmcgdG8gYXZvaWQgY3Jhc2ggb24g Y2FsbCBkZXB0aCBhY2NvdW50aW5nICovDQo+PiArCW5hdGl2ZV93cm1zcmwoTVNSX0dTX0JBU0Us IHNhdmVkX2NvbnRleHQua2VybmVsbW9kZV9nc19iYXNlKTsNCj4+ICsNCj4+ICAJX19yZXN0b3Jl X3Byb2Nlc3Nvcl9zdGF0ZSgmc2F2ZWRfY29udGV4dCk7DQo+PiAgfQ0KPiBZZWFoLCBJIGNhbiBz ZWUgd2h5LCBidXQgSSdtIG5vdCByZWFsbHkgY29tZm9ydGFibGUgd2l0aCB0aGlzLiBUQkgsIEkN Cj4gZG9uJ3Qgc2VlIGhvdyB0aGUgd2hvbGUgcmVzdW1lIGNvZGUgaXMgY29ycmVjdCB0byBiZWdp biB3aXRoLiBBdCB0aGUNCj4gdmVyeSBsZWFzdCBpdCBuZWVkcyBhIGhlYXZ5IGRvc2Ugb2Ygbm9p bnN0ci4NCj4NCj4gUmFmYWVsLCB3aGF0IGNyMyBpcyBhY3RpdmUgd2hlbiB3ZSBjYWxsIHJlc3Rv cmVfcHJvY2Vzc29yX3N0YXRlKCk/DQo+DQo+IFNwZWNpZmljYWxseSwgdGhlIHByb2JsZW0gaXMg dGhhdCBJIGRvbid0IGZlZWwgY29tZm9ydGFibGUgZG9pbmcgYW55DQo+IHNvcnQgb2Ygd2VpcmQg Y29kZSB1bnRpbCBhbGwgdGhlIENSIGFuZCBzZWdtZW50IHJlZ2lzdGVycyBoYXZlIGJlZW4NCj4g cmVzdG9yZWQsIGhvd2V2ZXIsIHdyaXRlX2NyKigpIGFyZSBwYXJhdmlydCBmdW5jdGlvbnMgdGhh dCByZXN1bHQgaW4NCj4gQ0FMTCwgd2hpY2ggdGhlbiBnaXZlcyB1cyBhIGJpdCBvZiBhIGNoZWNr ZW4gYW5kIGVnZyBwcm9ibGVtLg0KPg0KPiBJJ20gYWxzbyB3b25kZXJpbmcgaG93IHdlbGwgcmV0 YmxlZWQ9c3R1ZmYgd29ya3Mgb24gWGVuLCBpZiBhdCBhbGwuIElmDQo+IHdlIGNhbiBpZ25vcmUg WGVuLCB0aGluZ3MgYXJlIGEgbGl0dGxlIGVhcmllciBwZXJoYXBzLg0KDQpJIHJlYWxseSB3b3Vs ZCBsaWtlIHJldGJsZWVkPXN0dWZmIHRvIHdvcmsgdW5kZXIgWGVuIFBWLCBiZWNhdXNlIHRoZW4g d2UNCmNhbiBhcnJhbmdlIHRvIHN0YXJ0IHR1cm5pbmcgb2ZmIHNvbWUgZXZlbiBtb3JlIGV4cGVu c2l2ZSBtaXRpZ2F0aW9ucw0KdGhhdCBYZW4gZG9lcyBvbiBiZWhhbGYgb2YgZ3Vlc3RzLg0KDQpJ IGhhdmUgYSBzdXNwaWNpb24gdGhhdCB0aGVzZSBwYXRocyB3aWxsIGJlIHVzZWQgdW5kZXIgWGVu IFBWLCBldmVuIGlmDQpvbmx5IGZvciBkb20wLsKgIFRoZSBhYnN0cmFjdGlvbiBmb3IgaG9zdCBT My80LzUgYXJlIG5vdCBncmVhdC7CoCBUaGF0DQpzYWlkLCBhdCBhbGwgcG9pbnRzIHRoYXQgZ3Vl c3QgY29kZSBpcyBleGVjdXRpbmcsIGV2ZW4gYWZ0ZXIgYSBsb2dpY2FsDQpTMyByZXN1bWUsIGl0 IHdpbGwgaGF2ZSBhIGdvb2QgR1NfQkFTRcKgIChBc3N1bWluZyB0aGUgdGVhcmRvd24gbG9naWMN CmRvZXNuJ3Qgc2VsZi1jbG9iYmVyLikNCg0KVGhlIGJpZ2dlciBpc3N1ZSB3aXRoIHN0dWZmIGFj Y291bnRpbmcgaXMgdGhhdCBub3RoaW5nIEFGQUlDVCBhY2NvdW50cw0KZm9yIHRoZSBmYWN0IHRo YXQgYW55IGh5cGVyY2FsbCBwb3RlbnRpYWxseSBlbXB0aWVzIHRoZSBSU0IgaW4gb3RoZXJ3aXNl DQpzeW5jaHJvbm91cyBwcm9ncmFtIGZsb3cuDQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Wed Jan 11 11:44:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 11:44:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475231.736832 (Exim 4.92) (envelope-from ) id 1pFZWm-0000qm-7N; Wed, 11 Jan 2023 11:44:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475231.736832; Wed, 11 Jan 2023 11:44:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFZWm-0000qf-4K; Wed, 11 Jan 2023 11:44:20 +0000 Received: by outflank-mailman (input) for mailman id 475231; Wed, 11 Jan 2023 11:44:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFZWk-0000qZ-MG for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 11:44:18 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFZWj-0005Uq-UA; Wed, 11 Jan 2023 11:44:17 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pFZWj-0004U7-LW; Wed, 11 Jan 2023 11:44:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date: Subject:Cc:To:From; bh=IqfAabigwW7CFHzU0bZ0FY9KOz/BysPhEjw0xmgSgig=; b=Gy3Snw FPKTAkG1qUEP9B/Bco0jMaZx0BKx8PW1ffs1HugeclmkrTKpKNVlnrKChowYRzR8eXFv63DX5ljo1 OBnOt9MsCW4mGAC1hU0Go3L28u6iv2S9k1EWjK/HuzVG/Fo1cUz7HGUK89Yp2o2TIj5XPYtUFQt8T RzG+oNgFc6Y=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Oleksii Kurochko Subject: [PATCH] xen: Remove the arch specific header init.h Date: Wed, 11 Jan 2023 11:44:09 +0000 Message-Id: <20230111114409.7495-1-julien@xen.org> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Julien Grall Both x86 and (soon) RISC-V version of init.h are empty. On Arm, it contains a structure that should not be used by any common code. The structure init_info is used to store information to setup the CPU currently being brought-up. setup.h seems to be more suitable even though the header is getting quite crowded. Looking through the history, was introduced at the same time as the ia64 port because for some reasons most of the macros where duplicated. This was changed in 72c07f413879 and I don't foresee any reason to require arch specific definition for init.h in the near future. Therefore remove asm/init.h for both x86 and arm (the only definition is moved in setup.h). With that RISC-V will not need to introduce an empty header. Suggested-by: Jan Beulich Signed-off-by: Julien Grall --- cc: Oleksii Kurochko --- xen/arch/arm/arm32/asm-offsets.c | 1 + xen/arch/arm/arm64/asm-offsets.c | 1 + xen/arch/arm/include/asm/init.h | 20 -------------------- xen/arch/arm/include/asm/setup.h | 8 ++++++++ xen/arch/x86/acpi/power.c | 1 - xen/arch/x86/include/asm/init.h | 4 ---- xen/include/xen/init.h | 2 -- 7 files changed, 10 insertions(+), 27 deletions(-) delete mode 100644 xen/arch/arm/include/asm/init.h delete mode 100644 xen/arch/x86/include/asm/init.h diff --git a/xen/arch/arm/arm32/asm-offsets.c b/xen/arch/arm/arm32/asm-offsets.c index 2116ba5b95bf..05c692bb2822 100644 --- a/xen/arch/arm/arm32/asm-offsets.c +++ b/xen/arch/arm/arm32/asm-offsets.c @@ -11,6 +11,7 @@ #include #include #include +#include #define DEFINE(_sym, _val) \ asm volatile ("\n.ascii\"==>#define " #_sym " %0 /* " #_val " */<==\"" \ diff --git a/xen/arch/arm/arm64/asm-offsets.c b/xen/arch/arm/arm64/asm-offsets.c index 280ddb55bfd4..7226cd9b2eb0 100644 --- a/xen/arch/arm/arm64/asm-offsets.c +++ b/xen/arch/arm/arm64/asm-offsets.c @@ -10,6 +10,7 @@ #include #include #include +#include #include #define DEFINE(_sym, _val) \ diff --git a/xen/arch/arm/include/asm/init.h b/xen/arch/arm/include/asm/init.h deleted file mode 100644 index 5ac8cf8797d6..000000000000 --- a/xen/arch/arm/include/asm/init.h +++ /dev/null @@ -1,20 +0,0 @@ -#ifndef _XEN_ASM_INIT_H -#define _XEN_ASM_INIT_H - -struct init_info -{ - /* Pointer to the stack, used by head.S when entering in C */ - unsigned char *stack; - /* Logical CPU ID, used by start_secondary */ - unsigned int cpuid; -}; - -#endif /* _XEN_ASM_INIT_H */ -/* - * Local variables: - * mode: C - * c-file-style: "BSD" - * c-basic-offset: 4 - * indent-tabs-mode: nil - * End: - */ diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index fdbf68aadcaa..a926f30a2be4 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -168,6 +168,14 @@ int map_range_to_domain(const struct dt_device_node *dev, extern const char __ro_after_init_start[], __ro_after_init_end[]; +struct init_info +{ + /* Pointer to the stack, used by head.S when entering in C */ + unsigned char *stack; + /* Logical CPU ID, used by start_secondary */ + unsigned int cpuid; +}; + #endif /* * Local variables: diff --git a/xen/arch/x86/acpi/power.c b/xen/arch/x86/acpi/power.c index b76f673acb1a..d23335391c67 100644 --- a/xen/arch/x86/acpi/power.c +++ b/xen/arch/x86/acpi/power.c @@ -17,7 +17,6 @@ #include #include #include -#include #include #include #include diff --git a/xen/arch/x86/include/asm/init.h b/xen/arch/x86/include/asm/init.h deleted file mode 100644 index 5295b35e6337..000000000000 --- a/xen/arch/x86/include/asm/init.h +++ /dev/null @@ -1,4 +0,0 @@ -#ifndef _XEN_ASM_INIT_H -#define _XEN_ASM_INIT_H - -#endif /* _XEN_ASM_INIT_H */ diff --git a/xen/include/xen/init.h b/xen/include/xen/init.h index 0af0e234ec80..1d7c0216bc80 100644 --- a/xen/include/xen/init.h +++ b/xen/include/xen/init.h @@ -1,8 +1,6 @@ #ifndef _LINUX_INIT_H #define _LINUX_INIT_H -#include - /* * Mark functions and data as being only used at initialization * or exit time. -- 2.38.1 From xen-devel-bounces@lists.xenproject.org Wed Jan 11 11:45:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 11:45:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475237.736843 (Exim 4.92) (envelope-from ) id 1pFZYC-0001PG-Hd; Wed, 11 Jan 2023 11:45:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475237.736843; Wed, 11 Jan 2023 11:45:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFZYC-0001P9-Eb; Wed, 11 Jan 2023 11:45:48 +0000 Received: by outflank-mailman (input) for mailman id 475237; Wed, 11 Jan 2023 11:45:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFZYA-0001P0-TB for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 11:45:46 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on2048.outbound.protection.outlook.com [40.107.8.48]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7b820bfd-91a5-11ed-b8d0-410ff93cb8f0; Wed, 11 Jan 2023 12:45:44 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9489.eurprd04.prod.outlook.com (2603:10a6:102:2c1::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Wed, 11 Jan 2023 11:45:42 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Wed, 11 Jan 2023 11:45:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7b820bfd-91a5-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IuSovQhox+7pvm2LM8mMy3OCazP++cMoCFH5nB2NFR/zh0XCCcBiCqeWgs8l0N36/BPhH6LRRm8k2pgmP6ZM8H/LYd9lxQeZDFhqs1Fqt0f/lclHeWXjflCxkm9/pEuL9Xw05TquB6/53XmHW4j7hC7nNzOVneYQObzYJmlp7dfG7i9/KJb1JGzjdhpj6cCBSRWu+LufKzxmNrgbEanJCTqpo4E0dFvqvO9v312Vw/OvUs/2KYfmi4+8kFj1R+uVLw8r62MAPe5VSCSBZz/NV0l89o9fICgDDg4NDSJVVyTjRf5XF6vGC9dYIeuCaNtW++cqCUnZ5sbrrZcUNAUOdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vJyBKwRcILZLfFiT4JKRJBdJChq++tQiSdJTUxAwsZY=; b=fAlE4NRljiXH9tSwhmUC6x1k2x0msNp8wokCaWCFHoQzerrlVxvA+Fb5fjy/BDD3woHZD9q/FYBhntTcbIX7X2Paw8qN7m9isccG6PivvOnN3ocXdxMpSK3mHsiYwwrL+RA2P2HlPL/rIdEsHJC4wuD0Yl5ClaEUDeDFYfHu7YBa7vI+foi+IGIXWXT/2Nwd0Z4pn1cxtRJxUQ4ZCFDN3GR1UYu3Bom1haH62TiPGwn3tkij/7aKUSVmdP47SKtUdrK8WdM+qB49vs/qbEKA38OFBkbjDC+OiX8JvBiW99dgbnYLcDbmKydRo3/hIvJ1gENf5iWSP4h44lzgFua+Eg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vJyBKwRcILZLfFiT4JKRJBdJChq++tQiSdJTUxAwsZY=; b=YIMH09P5xf84nJhadwq6Ng0PRQbK1DZD2febd4fZCf+ROeN1Ec2Z803GrqUTifeoXWkpREY/h4IcJiTxhKg5Ke9lkWE+05nUOwhBgpnsJtVmIFcdEkFYpgo5MPGAv374hXwVuavEvTvSDWiQ+qWq91OtBK3ULEHzmw+JF+4Fu4wb7Eo547ly/M8wiGFxHVA+bAp2xjIgQ/mvNg2cmqttF/1QuL40reEw6bP+myb+LahgB4NyeKA8jpOaGnHmEM1ofNIfCpeMSSlI5QGcsJ/n0eOkxssm0VhF25udU9jMs0YkWcLzblOXBg6uaxUx7OxtteEWUoNh1COlNAeEtVkxRQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 11 Jan 2023 12:45:39 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: Wake-up from suspend to RAM broken under `retbleed=stuff` Content-Language: en-US To: Andrew Cooper Cc: "linux-kernel@vger.kernel.org" , "x86@kernel.org" , Thomas Gleixner , Juergen Gross , "Rafael J. Wysocki" , xen-devel , Roger Pau Monne , Peter Zijlstra , Joan Bruguera References: <20230108030748.158120-1-joanbrugueram@gmail.com> <20230109040531.7888-1-joanbrugueram@gmail.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0119.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9489:EE_ X-MS-Office365-Filtering-Correlation-Id: 43b48721-5c99-4d23-7067-08daf3c95e1c X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: owCNN63GRNTThhPWm/9y/E20yMqdne0m1WZtQCfsCZU/7nH5q44OzXKTMHE4pAAtFttrLQU3J1MGfefSLaW8wwT/9A/FYnM7wIuf7CrrZhiYIaCDM5ggZpmG5KwcAPXpW+05wWCWjlHI8PMUb67SnDCd62hPpSL3n81mYWvo87QRRHVKa1O3JIFMuarWg7w33O4F6yVQCykcLv2bEg/vbgztp1n+/ZOEfai2WyZOstZUwmRc95TBrqc4kNZHV4didJQslLSi4JzGXNFAAewW/4TC77YlRmkCBhTz5Rj+P9tXzkQRIOV/9TxXS18vU6ZNBPUiRXjuoiOO9qVkbw8YE3SmMxLG0SnUzXBjdAUoeDADmCxG6ouMcHpC69lZDZfx5cVjnlARxmTa0q9eAh7K9l1gddmJ5spPdXCC98CNdoiQBYnPwO5aAeBtSJy8KJTgbvm9XfULU+gzUg3qf9CctaWND9TGr8YO5flHtDnVrcDz/q2YvxHGoX2LX/lIf40Tfw2vcSeuYOfGfLPGtD6oEvvr7n/WJInq8se2jTgptRKfI7ZThmADxKbLc4yjX6OLS+Cg7pEISTpeL+9H8P68hJEQM9DhrftiBDd0wdIwqwvnL8D4D3P3R+llZJLQGyvo3vShuvPpLaMe72BBKN/GaItFTA0D/5wnrhZj7wpPy6PCFoxqHLiorGkdkJKKq1WWmEzFIzp55p2so+CCJrVtcscTQpsRj311cH5dxYlO35bb3+6IyoH/RzcKhoNVbidr X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(376002)(366004)(39860400002)(136003)(346002)(451199015)(53546011)(15650500001)(31686004)(2906002)(6506007)(6486002)(26005)(478600001)(6512007)(6666004)(186003)(8676002)(83380400001)(2616005)(36756003)(316002)(66946007)(66476007)(54906003)(66556008)(6916009)(4326008)(41300700001)(5660300002)(4744005)(38100700002)(31696002)(86362001)(8936002)(81973001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T1p3RUd5VCtpSCtySlRHTmx4Yi9YYThyY0JYREFhYVhmcDk5SG5WODBQMU5z?= =?utf-8?B?K0poRmdqTlpWMHd2NUh6eFBPb3ZMOFk4Skl5clVsVUQ2bTBHRGliZ09CWUFo?= =?utf-8?B?MEpIV04vQ3dPMC83VWlOaVVLQzlVdmYycFpneWphd2NKN2tURnlXb3pyaW9p?= =?utf-8?B?M0hiQnlZVTZrYnJuanp3SWdqSGFuZXk1cjQ1UllVayttTzVFRVg2V0pNQzBk?= =?utf-8?B?NjhiZ2hpdjVPTkpIZHpTcWhZSytqSjJhT0JpVEZkbGRzVVlBZ3lsdzdqMkdJ?= =?utf-8?B?SGhwRU5wOUdVY2VUYndZTzdEQWZJM0R4TUQ5cVZ3MkJJT0EydEpwS0hKRm5Q?= =?utf-8?B?ejJmZFd3R0VGTWJZb3J5aXBoVGNPWGtkbkNoY25DOS9uakw2eGxoL2Zqd2wy?= =?utf-8?B?TU1vRElaY1F2dG9Ka2l0TklNWGJ0T1JMZktWSDhjWkgwTGFnRjlKcERpZ2Z2?= =?utf-8?B?RXl0M3dWRFJQTTdNeUZXcWZTOWd0ZnpYUU9mem9NU21xRjZqejRVcmJOY1dh?= =?utf-8?B?NUhiMW00ZXJGWnlWRGpkRGZYUjlSUnF2MXFKTnNQR2Izd1phYlFudWM5dEdJ?= =?utf-8?B?djdWZGY0NkZTYjlJdmdYc3hJWVJWaUR1TmtlV1Z6SDZGOHR5MlZMc1RhbTE4?= =?utf-8?B?NUdMTnVlSCtXaC82QXAzUDhBM0RYQkNxa05IWDczVzFxSmEvc0Y2NUxQNEJz?= =?utf-8?B?Rm1QUE5JdVFneFRyUEF1elExWWtXVmlXa1YzalBOOXJ0SThrZFB5WnUzczlB?= =?utf-8?B?NDJzSFg3b3F5d3htYmJ3d0RrdWppTU05RE9uMU8xM2JwMjQ4eEMwQlZpOFd0?= =?utf-8?B?Ynp2YmRNc1ZicDhNQnB0QUpuWjgxYzFiZTF3aG5vYkRRNXhkQVBsbEJ2VEcy?= =?utf-8?B?OFdncGRnR1prNEZuZkRyZjdPVlFrVDBLZG5hK2tnOUJ2RGJTTSs1OEVoMVZN?= =?utf-8?B?Yml5YzVqN1F6dmlZblY4a3l0UFBxWkduakNlWmxCRzJDZHNSd0FtT3BjMWlx?= =?utf-8?B?V1dBN0locEF4Szloblc4N0lkMFZEN05mNXhhNExOVGFyQ1pDTnhEVVZHS3ZV?= =?utf-8?B?N2c0UzZUNVA5VFlnSXhFZzRrT1YxUWplYlRjR2ZqVUtiUCs1ajFEenRCMzVQ?= =?utf-8?B?Q3d3ejRORUljUUluS2MrMjhWVFhlem9iaW9ucHkvN2pxcDFtdjU5eGlEbWEy?= =?utf-8?B?SFFHajdjWFNjb1czRTN0L3NuOHNua1lkdXU5MmRXcHU5OGdOS2NLN0JTTXJ3?= =?utf-8?B?MTB2RzlCNGw3cHdoQVlUN3pZOTV6VDNybE9uSmkwYmVYUkNVZjljNHNZRHJT?= =?utf-8?B?Y09YUnlZUHFQRjBJZllqU1d1TDREOVdTQ2k1QUhyT0djUTBVN1YyUk5Sb0I0?= =?utf-8?B?VU9PL0FGVDNpd0hhdElwTDZzdHZnSE1DK1Ewbm55dy85TGZWbDQ5alFmbE1y?= =?utf-8?B?ZHJCbkZERzIzelB3YjBZOU9qYUZEckRDVjFmWkg4cmpodXIxV2tSYXQ5Qi85?= =?utf-8?B?VVovc3V2WDNGaUNXNnZPN0ozN0dGUjhweHZLVGJEZVN4MjY5Ulg1dHN3anJp?= =?utf-8?B?eFhWUENha0JkQk5mem9lNG0zYkRwZnFlN0FsVkF1WWtZSE9GZ1MxWHhPRjdk?= =?utf-8?B?Mk9mVk9OekFXQzk3RXFJTVVEV3RCdEpqMzM2b3YwVHUySnJMMFZCMDVYaGkw?= =?utf-8?B?MENGZWRiemxRZlltUit0RzZBZjJXSkdXWUxQYm9BTExSYU1SMUluWnB4QVZj?= =?utf-8?B?QzEvOXdabzFRVzVOTk9EczNUZzlFMTVaTWFhZU5jeXpKZ1NTMUxqKzhmczha?= =?utf-8?B?ZGFaaG9aZjRWNkQwa2ZGRUpXVGh6a0tHdlpJRnAzd1M0RUlZVDhnN1dUZVNJ?= =?utf-8?B?Rm80Vk1ZYTQvS0RKRGFRLzNPTmN0cE5ObGNybEQ2YlB5dzlnRzE2cWRsT29X?= =?utf-8?B?dDFOaTAzb2ZScFVZaFl1anNnR0VORjNUN1B5cG1CM3ozZjRrWnp5VkVHTzBx?= =?utf-8?B?SUlHb2NPNFhXTnlHZEJPQURZcGlWTGJlL0ttcFR2dnBzcExtby9EbWU5aDEr?= =?utf-8?B?KzRiY1U3RTZzajA2K2RYZVZmUVRKNE9nSHJIWU1qWWY5SldBTDVicWJkK0Zy?= =?utf-8?Q?Sv5fZmG1pacWQlwpi6XbUdfRV?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 43b48721-5c99-4d23-7067-08daf3c95e1c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2023 11:45:42.1119 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PKsUwEW9ReEg0+L9PyfNKN04LQMbr2R5om7+UCDS4ee0xhEr2fp5eyQWIoTHOan9I2uk5cxsBqRDy4Zpu+YwEQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9489 On 11.01.2023 12:39, Andrew Cooper wrote: > The bigger issue with stuff accounting is that nothing AFAICT accounts > for the fact that any hypercall potentially empties the RSB in otherwise > synchronous program flow. But that's not just at hypercall boundaries, but effectively anywhere (i.e. whenever the hypervisor decides to de-schedule the vCPU)? Jan From xen-devel-bounces@lists.xenproject.org Wed Jan 11 11:47:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 11:47:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475243.736853 (Exim 4.92) (envelope-from ) id 1pFZZp-0001yc-T7; Wed, 11 Jan 2023 11:47:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475243.736853; Wed, 11 Jan 2023 11:47:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFZZp-0001yV-QN; Wed, 11 Jan 2023 11:47:29 +0000 Received: by outflank-mailman (input) for mailman id 475243; Wed, 11 Jan 2023 11:47:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFZZo-0001yH-C5 for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 11:47:28 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b67f4aaa-91a5-11ed-b8d0-410ff93cb8f0; Wed, 11 Jan 2023 12:47:25 +0100 (CET) Received: from mail-mw2nam10lp2104.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.104]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 11 Jan 2023 06:47:21 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SA0PR03MB5402.namprd03.prod.outlook.com (2603:10b6:806:b7::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Wed, 11 Jan 2023 11:47:20 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5986.018; Wed, 11 Jan 2023 11:47:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b67f4aaa-91a5-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1673437645; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=N19BN8vT5mhkquQUDl8iaAN7tGdPH7TWLraXfCAokq4=; b=MUyENqgDZvQYfNHba/gnmG4+fo7Cdv1vTT9DaYAxhRsk64yIzpYCW8+t H43Q43oKx9Ougw7hMOUvi/aagLs3eiYveE3GYOKB/aLD6PDSAK6ur0PHa cNkRKXDfLpslBlzqzd+5jOZA82Ktk+hk76NwnyORn6Yg2CKNB2x8a3k1O I=; X-IronPort-RemoteIP: 104.47.55.104 X-IronPort-MID: 92103583 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:s+aHKqj/wxN/9bmNr0oe30diX1610REKZh0ujC45NGQN5FlHY01je htvWW2GOf/ZYWOmeN1/bIvlp04P7JeHnYRiSAc5qH8xFSsb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmUpH1QMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWs0N8klgZmP6sT5QaHzyB94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQSBTIvVhS619iH64KVVepCgpQuN/nkadZ3VnFIlVk1DN4AaLWaG+Dv2oUd2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilEsluG1bLI5efTTLSlRtm+eq njL4CLSBRYCOcbE4TGE7mitlqnEmiaTtIc6RefhrqU30Ab7Kmo7CQwPVGK4mNaAkhClXOtlG lAN+HUTlP1nnKCsZpynN/Gim1aGoxodVtx4A+A8rgaXxcL88wufQ2QJUDNFQNgnr9MtAywn0 EeTmNHkDiApt6eaIVqf+a2dqTeaMC0cP2gEIyQDSGMt+ML/qYs+ihbOSNdLE6OviNDxXzbqz FiipiUkm68ai8JN0qyh5E3GmBqlvJ2PRQkwji3pWWai4hJ8dZSSTYWi4ljG7t5NNI+cCFKGu RAsmcKT8eQPBpGljzGWTaMGG7TBz+mBGC3RhxhoBZZJ3zOp9n24fIEW4yxkI0xpMcEsdjrgY UuVsgRUjKK/J1OvZK5zJoeuUcIjyPG4Ecy/D6iIKN1TfpJ2aQmLujl0YlKd1Hzsl05qlrwjP ZCccoCnCnNy5blb8Qdajtw1idcDrh3SD0uKLXwn53xLCYajWUM= IronPort-HdrOrdr: A9a23:c0zT0KrB3sSvbAv7l8QATv4aV5rveYIsimQD101hICG9Evb0qy nOpoV/6faQslwssR4b9uxoVJPvfZq+z+8W3WByB9eftWDd0QPFEGgL1+DfKlbbak7DH4BmtJ uJc8JFeafN5VoRt7eG3OFveexQvOVu88qT9JjjJ28Gd3APV0n5hT0JcjpyFCdNNW57LKt8Lr WwzOxdqQGtfHwGB/7LfUXsD4D41rv2fIuNW29+OyIa X-IronPort-AV: E=Sophos;i="5.96,315,1665460800"; d="scan'208";a="92103583" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BfiyQEyH8cTyHJqKB7gCBeNqFp9O/35mjR7LDhgZKZ9XJA6eaizLuMtNvL5kSrnkfhdEEuYD/BVd+x4xBn516738vGNbCNsI4SDrcRgchH7u7iTtdN3rUbmI4dPAoL6eF/Go0sIVK1ZKbfElynSnVIZYjhurTdlOer3548emvKdaNmm//ZN6jZFOo7YpF5CvGYYsSgUEh8BIprdb3n8KhVRLJi5d7s3SDegw2Bh2izQPrO0wVwVOOfDp1aBSIKzBmXWqak3YEmZ49w5BUCXLDfneo4ak4i5Ol3vWiEocu/OmcsRUqiyWG+IxiVITs0EemsrG/L6PZqnJOFiUmKxorw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N19BN8vT5mhkquQUDl8iaAN7tGdPH7TWLraXfCAokq4=; b=e6E9fzNRFrXmDA5YQJ0Ih2qkYU0jSd4olQhPb9cSCNiw8Maxf95QVstSobM+v6L97E7kyYWgdl9iurbr1EeOEQWBEbfwM8dAyUksLCSAqjbNqpJMn3m+7+nrD1d1gtWdXBaidNhocifEU7V3PGD3okRKcToHIXFJNG9RDMMlSOvmxy7QhYvlZo1nPqcVXd3LBPnHdFZ37gMdytadjR/W44kZttc3bLR0LDXEmwGY2uV6wW+b9dUlJA1NcQ9J+LAXIWgBvPaGQLBVS49dYQn6r4kvZ7j/kDq2TfgjTlFrO3QFMXS2R7aZaiM8HAi6La+WwGs1LvwSWY5l+EgcUyTeQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N19BN8vT5mhkquQUDl8iaAN7tGdPH7TWLraXfCAokq4=; b=CFAljS5NFqm5wj/FKz/jhURHuaSzeS5oC6CYyNgniluVXO/+gx0U/WG5OROHRXejpoHJ4Z9Rhqb0IGpP3kzpWafOh3Gooj2lMLHiTLfpnSLN0Kaxfr0LDojeRmmHu4dCChscv/fj2qDQ9CNtbHTshpyzMQMNhSAgwm4wb2TBy6E= From: Andrew Cooper To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , George Dunlap , Jan Beulich , Wei Liu , Roger Pau Monne , Oleksii Kurochko Subject: Re: [PATCH] xen: Remove the arch specific header init.h Thread-Topic: [PATCH] xen: Remove the arch specific header init.h Thread-Index: AQHZJbIRC1R7bPh5UkiB/FwWKG3LDa6ZGYaA Date: Wed, 11 Jan 2023 11:47:20 +0000 Message-ID: <7590f300-49ef-8180-543d-96b5af06fbd5@citrix.com> References: <20230111114409.7495-1-julien@xen.org> In-Reply-To: <20230111114409.7495-1-julien@xen.org> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|SA0PR03MB5402:EE_ x-ms-office365-filtering-correlation-id: ac591cdc-7851-48bd-baf8-08daf3c998bb x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ogirymhQkRqselGT+JYNBxijFb871U8NEn20x3v0GkmkM9VR7UInm0dK4khP8xvBHSsyxVm2YOgGJiaeqe+bvHecwu3n4eZRkMISxa8ITFp0tF97LgT8HcfnN4pYL/qsUSBLjKh8dWFcCUIbt28Sdq6p1j1+OHfqlqzKTF181Lk/bgxeaD5b8UN0sJh0/hwbtum14bk/EZrYOyanzjI3uH8nEt+5c++DKEdDNsFQmfGzr3s5029PyPukDxWcyH8en655V5yhCaLfFMaVs5nN7K9Hw3cGIKBhGx82fD8J3RgH7r7FwEm3PwDX8Nrf8fRRfnp3JbyNBiBgVJMPu45SbSK/Glp4RobvHNXIQBydUlGgqWiLnUKPCoR739YGwegQBKcVkKU/cWKkBGxmaJCjEKp6t4ErRJH2efhonKn9CKogUOjHBMiFK4mjenRaKjsm/K0VIpWJC1vqPZJ1764p5HH8FkOaoszXzXs6jOluY5+Kfdire73fLwWDiYE+XdRpVIVgte7IvDFGGhPdmdlxb+8d/R+CPUCHuT9E6XqYYntMR84mHi5AK+skLAaFW//xSzlFwulch2z2RpHUqRHmOK7kApkDcAIu+v2muuZ6xL+WnYuH2QAPvaPO6Qwk6iN2TNntXR210FkUPc1E9kh5ElRuqjEON4Opw1FyPBfulQYnkEHRdUyt/OihYpt1w9D7HH2jVZhhGbwsBXtnCGTSMGX987IhXCgLwk6T6jgrzblxbi8kndEJyuKphN14Y7HzvdXN8S0vdCg48oIAI6Pq2g== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(136003)(396003)(346002)(376002)(39860400002)(451199015)(7416002)(4744005)(316002)(5660300002)(71200400001)(508600001)(6512007)(26005)(186003)(6486002)(2616005)(31696002)(41300700001)(66556008)(91956017)(54906003)(66946007)(66476007)(66446008)(4326008)(8676002)(64756008)(110136005)(76116006)(38070700005)(8936002)(86362001)(36756003)(53546011)(31686004)(6506007)(122000001)(82960400001)(38100700002)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SGppaVdIWUw1NzJwd3dMdVBIOU1HeDhpbmpZZE1RZ01XLzZRNFVBUkgwMUVG?= =?utf-8?B?YWNycDA4ZkttM3lJa2tjdXdvSVB5YTVSdlNQZjRCYjNJK1RZZXVzaUVhamp0?= =?utf-8?B?U29oZE5pRG53MHg5Zng3M2lydGZib0V6UUI4ZjRoZ3lvMFVsOUNLNTNaem5X?= =?utf-8?B?cEpLNTRPaEdaVSttTEVtc2crd1FLR1NjR29jTnJTU21PRktXREdiTE9xVGl6?= =?utf-8?B?QWNTcXVYNjVSMkNCYWFrQStuYXRneWViTXIyc3J0OGdjc2pDMWpQOTlNUGFo?= =?utf-8?B?NVBidTZuTnVKR2V3eCttYVVKeXhXRC9FbFAxd1lWbWZVNmFEWWpjMUNrWk93?= =?utf-8?B?ek12VjJuVkQzWW51M3lMM0VhVmhUMGw3M3AyODF3dVlmR1RCYTdGVEV6akI1?= =?utf-8?B?UllKNy9BNlpoeGg2Z2s2TFBLQ1haaVhSZUVUNTJJV1A0ZThGbkxseDRvUkN6?= =?utf-8?B?bU9oMVhlT2pZVGd0VG9qSkRrTXRoUExVWkhzMWRva3ZXL0pBSjRCd01URTJh?= =?utf-8?B?VXIrd3FQWkx0N25SR0MwbEI2WWo0QnBrS0RZSXB0U0FiMGFkMHBpTWttVDVM?= =?utf-8?B?Wk1wYUxKYUNoMVdYVWxVYmJSamRUcjQrVG5lOCs3RTdRL25TVkl5ZXROazEr?= =?utf-8?B?VE0xMGlNQkUySTl4V25lOS8ybUM2L09rU2hOYzYvRlQxcHFyT1ZxdzUvU0R2?= =?utf-8?B?NFE3OGdDSEpZWW1pT0daYytsZkNSby9TRFlpblllRzVETjdEaittNm9zOGJ4?= =?utf-8?B?RkNlQVZPeHdnb2hvKys3OFhHVWZwZ04vZ3UzMStiZERjY2NFT3FkZW5ORUh5?= =?utf-8?B?RmIvVmRUY2psaG5pWTN1WjNVVS91dmV0eTRjV052SFFHRUtWTldLSzh1UUVr?= =?utf-8?B?V0FhTnBrVi9Xc0lNVytMS2hDWEtmS3pEL2xXVFhOMDAvLy9ndGZVYmx2WTh2?= =?utf-8?B?MUZhUlh1NDhzbGlVbHZoSytLdjNPU3hpL1hXQitmQ1pVcm1iZ3VVSFYvejYz?= =?utf-8?B?aytqVnMyR0VTcTEvWnpZZzJFbVgveDlFOHNTOHBuU0VvY2hXV21mOWxWMXgz?= =?utf-8?B?MmZnbzZKd1JmSHBDcVhGdW1FUTlJczRLbHBkMFhsN0FOT1dQSGNyT1pXaFlW?= =?utf-8?B?bnAxZEVmeDNIdU00TExTQXQ1Q2RWY0xkdDVUMnM0TlZQZWlPVTVHOXc2ajQw?= =?utf-8?B?QVZWZnA2cWp2TTBBSDYvWTBlakYxUFNLNG1TSU5kYmRNYWFTQjl1VU9JN1Vz?= =?utf-8?B?SGl4RWpLcmx3WFlKandEejVOdUFaQWJRcDVDdlRrWnJvZ2oyZkFKV0hIVHF3?= =?utf-8?B?Ykh1ejhWZkJpb1hpVU1kL2ZWQVJ0OUYvS0trWlhmZUhKSXFVU2pVdVFuRndr?= =?utf-8?B?eWs5LzArZHdQckNSaTI2RVhOZVhSdVowZHV2QUZHLzVmY1UrKzQyeWowd05X?= =?utf-8?B?Qk9LTVh2czg4cjIvU2VLV1NTVFN5Q0hCYVFxSmRXKzNPRlBBTVJWM2RobnpC?= =?utf-8?B?TkgrbG85S3pSY2t0ZHI5eDZ4WWR0Z0g5b0lzUDFuS1FhY2w0VTZqUmlkR3VR?= =?utf-8?B?cGw4TmpUdkVCSmVRU2JSR2s5SVhGdGJJU1RpUlM4Rlo0K0xtdEVVVS9RWW81?= =?utf-8?B?RUlJZUtRcnF0aFRJTGFMWWlsa0t6blhoWlAwWURwQXlMMXVRYzJIeDJtMWFy?= =?utf-8?B?SzFoM1U0Q092MFkxQXFCRExaay9neVloS21VdFc5NFdBa2JmUTdod2wxMUR1?= =?utf-8?B?UlpPRk44T3dGUWJ3aE9SU2kvUzQvRk1CR0NXU3RNNU1ReDlEUWNvRUlYNGVB?= =?utf-8?B?OXkvR0FOSWM2QS9TQnpXVXJwUy9Pcktsb21ZakhXK2xnNUJwUWRISVRva0NO?= =?utf-8?B?amJGbnhMeWFDTi9reXMzbUl1bFJBMHhzZTVQL2pMamlOdFpybW94OE9HVDBX?= =?utf-8?B?TXNRWWlMODZFZ1gxcU1rWlZxSkNRODBkaUlqNTQxVUdZekpubUtHVkloTjEy?= =?utf-8?B?bUxJNGZSWTdPRVRocmRZUXdVODZOWWQwOEJWdXMxa1F5bElTV3Q4SnR4TGFD?= =?utf-8?B?WEJidkNEazM0SmRUc1AwTEMvaGRuQ05CcmEvSU1OYkdZd2RkSTRsb20wbHRa?= =?utf-8?Q?Pn1l0+iH9/6KdrIaytgdmLZnr?= Content-Type: text/plain; charset="utf-8" Content-ID: <49306D701B4E8B4BA6AB7710D450EFE6@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?YnlwSXRnbFA0eXhsU2xoRm5kd0tGRWZPUkVGNWhFQmZDTVRNSjZqbFJPd0Mr?= =?utf-8?B?R2tDNkpuK0NHSkxYcndyZ05xZnh3dGVSbi85dXlIdXRrcUZ6VWxqekVwYk1C?= =?utf-8?B?MXFlUlYyWDk1Wmc2d3IxNUJJQ0Z5Zm5QZDFjSDNBVk1vbWRRaFJJSHptazVy?= =?utf-8?B?VStmUmtJdUdxaGtYazNZaDgrRTRCSURsc2FKZDN3cHBSclNSMmt0SmF3TDUr?= =?utf-8?B?YVhhMU8vdHR1anA2eTRjZGpEQzArdUZXVllKTlJwWlZNTklvb05helZDRy8w?= =?utf-8?B?R01WZDhpQnFNS2EzS2F0ZmRjclpHNUhwaiszV1ZoSEhudGo3QmZvSGkvclVi?= =?utf-8?B?clZXQlVJdVdYUjYxc0Q2cVg2cUtTVExabzdjeWNWUkNreElHQjVIdUJEMmh4?= =?utf-8?B?bjVNZEpvUUFJTzhoUkl4ejBGM29Md0ZTbGxlNnZLSUhEWWY5NXRDZEpudmtv?= =?utf-8?B?ZCtTL2ZhWGxJb3U1WDlDTjhOdFNnM2dTeStINStKY2xwR1hKN2k2QTYwdXNJ?= =?utf-8?B?NzlkTUhYR0FXRUEwekR2NjhrZWE5Y1Y4eHNCakF5RzNuZ3lUL0crRFR3dzZD?= =?utf-8?B?NUo4R3RmTk9xY2RteGVHdmZtQXltbHJ6UHpqYlFqdVcrL0RmcGpEeVhZcFJR?= =?utf-8?B?enJzSTNlMFFJWXBDeUdKdmF1VDhhWGFZUjFIdFBRaFh4UHcyUUJzd2dudFFT?= =?utf-8?B?QTdPSEk4YUVBbit3SVBBTkl4azJWR2FQSDM1U05PQ0lKanl0SHJHUWhjWjgz?= =?utf-8?B?UXFMdm9TK0ZpVzcyenhoZHI5K2F4bEhrTFJCaXBUK1dPL2UyUk1nTDZwUk00?= =?utf-8?B?NWZCSHRjek9tclYrZXg3dzZrcFY3YlM4S2NLZ1liN3c4NXp3azRTb1NnZXBk?= =?utf-8?B?MFRvOTVYaHRlOTBhWC9QWGxhenZjU0MvaWR4M2R0cDJpM00zZ1kwaXF4YkRX?= =?utf-8?B?T1EraGNaYktTNk04U0Jka2gxenRKWG9HQTE3cWs3L3ZoeXJvczNERzBVU25D?= =?utf-8?B?OFcyMWJhUklUdGxEY2xtakhtL201MWsrVDE2aFA2ekJnZmxLOTI2RVFwbTdE?= =?utf-8?B?aGtxRVdYN080YTM3czU2VmViMjVVN2llejlYTzY2NHB6Q1NjVU9oYzFoelQx?= =?utf-8?B?VHhSczRVMDEyaUtUVm45UC96dkNXOVIySjRDZytTdHlYbFJ5N1ZLUyt2eUMw?= =?utf-8?B?L1ZMVkRUQ1lSZnkvcFVaS2hQQ0JVeVZqNVVVM1ZHVUJxUC9vQ1liZ2VGVTFn?= =?utf-8?B?TVZJR0R3aW0ybk1HcjQzU2lmaThzT3BxUmEwMnFRbjNTUnNxQT09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ac591cdc-7851-48bd-baf8-08daf3c998bb X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jan 2023 11:47:20.2606 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: e0cP1qCANL8V7PRb9IOHNIH4+78gP9T+N/Ou7e63Of1B16dAJriTVcZszHUqpOsbjKBVpOL//oNA3noae29rPms+GHsTMuj3sk8YOLKVDKQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR03MB5402 T24gMTEvMDEvMjAyMyAxMTo0NCBhbSwgSnVsaWVuIEdyYWxsIHdyb3RlOg0KPiBGcm9tOiBKdWxp ZW4gR3JhbGwgPGpncmFsbEBhbWF6b24uY29tPg0KPg0KPiBCb3RoIHg4NiBhbmQgKHNvb24pIFJJ U0MtViB2ZXJzaW9uIG9mIGluaXQuaCBhcmUgZW1wdHkuIE9uIEFybSwgaXQgY29udGFpbnMNCj4g YSBzdHJ1Y3R1cmUgdGhhdCBzaG91bGQgbm90IGJlIHVzZWQgYnkgYW55IGNvbW1vbiBjb2RlLg0K Pg0KPiBUaGUgc3RydWN0dXJlIGluaXRfaW5mbyBpcyB1c2VkIHRvIHN0b3JlIGluZm9ybWF0aW9u IHRvIHNldHVwIHRoZSBDUFUNCj4gY3VycmVudGx5IGJlaW5nIGJyb3VnaHQtdXAuIHNldHVwLmgg c2VlbXMgdG8gYmUgbW9yZSBzdWl0YWJsZSBldmVuIHRob3VnaA0KPiB0aGUgaGVhZGVyIGlzIGdl dHRpbmcgcXVpdGUgY3Jvd2RlZC4NCj4NCj4gTG9va2luZyB0aHJvdWdoIHRoZSBoaXN0b3J5LCA8 YXNtL2luaXQuaD4gd2FzIGludHJvZHVjZWQgYXQgdGhlIHNhbWUNCj4gdGltZSBhcyB0aGUgaWE2 NCBwb3J0IGJlY2F1c2UgZm9yIHNvbWUgcmVhc29ucyBtb3N0IG9mIHRoZSBtYWNyb3MNCj4gd2hl cmUgZHVwbGljYXRlZC4gVGhpcyB3YXMgY2hhbmdlZCBpbiA3MmMwN2Y0MTM4NzkgYW5kIEkgZG9u J3QNCj4gZm9yZXNlZSBhbnkgcmVhc29uIHRvIHJlcXVpcmUgYXJjaCBzcGVjaWZpYyBkZWZpbml0 aW9uIGZvciBpbml0LmgNCj4gaW4gdGhlIG5lYXIgZnV0dXJlLg0KPg0KPiBUaGVyZWZvcmUgcmVt b3ZlIGFzbS9pbml0LmggZm9yIGJvdGggeDg2IGFuZCBhcm0gKHRoZSBvbmx5IGRlZmluaXRpb24N Cj4gaXMgbW92ZWQgaW4gc2V0dXAuaCkuIFdpdGggdGhhdCBSSVNDLVYgd2lsbCBub3QgbmVlZCB0 byBpbnRyb2R1Y2UNCj4gYW4gZW1wdHkgaGVhZGVyLg0KPg0KPiBTdWdnZXN0ZWQtYnk6IEphbiBC ZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU2lnbmVkLW9mZi1ieTogSnVsaWVuIEdyYWxs IDxqZ3JhbGxAYW1hem9uLmNvbT4NCg0KQWNrZWQtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5j b29wZXIzQGNpdHJpeC5jb20+DQo= From xen-devel-bounces@lists.xenproject.org Wed Jan 11 12:06:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 12:06:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475258.736865 (Exim 4.92) (envelope-from ) id 1pFZsA-0004eB-RS; Wed, 11 Jan 2023 12:06:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475258.736865; Wed, 11 Jan 2023 12:06:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFZsA-0004e4-Oi; Wed, 11 Jan 2023 12:06:26 +0000 Received: by outflank-mailman (input) for mailman id 475258; Wed, 11 Jan 2023 12:06:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFZs9-0004dy-0D for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 12:06:25 +0000 Received: from mail-vs1-xe2d.google.com (mail-vs1-xe2d.google.com [2607:f8b0:4864:20::e2d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5ddb441d-91a8-11ed-91b6-6bf2151ebd3b; Wed, 11 Jan 2023 13:06:24 +0100 (CET) Received: by mail-vs1-xe2d.google.com with SMTP id n190so11571631vsc.11 for ; Wed, 11 Jan 2023 04:06:23 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5ddb441d-91a8-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=8jzO6WX6QmQF0cHfaz5VH2e/upxcA5uDmPtPD+mE8yM=; b=JrcRNYFE0uDC2Xu5K9OIsHIAZ14u1jygNIehEYnKypuMbMX7eOtVym54dbN95+iPkw cSUTQ71OzNX+sDMOJ2fN6FY2dMBawehNB/67DwZ9gqdEGki2V8BrvIomo97X+8ilBF+C pcluFd0Q6SuhvJl+MFXaT7YIoN4dSTKW5IwVhpTnfvdBqq8XwyjX1fKWHA45zt8Jhu3B zKIs0tx5TuAJzAwMpj9d1LVDavSXIgcxxJ4nivMJPYOK7D24Thl6Sumb/IOKa84YcXwy meTIVk02XxVomJSqLL4R04vOk8YQE37KdrNqrjgLF0nVYruCEv7ZYpVbqNgWv+owR5yr hfdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8jzO6WX6QmQF0cHfaz5VH2e/upxcA5uDmPtPD+mE8yM=; b=0SE1POvDeQxHKiNVDt9hNlKPa8WwWLjxZFv5wKpI1fm0TeZgfg9Rs5ELQe8U1D8w9L Iaqm0+Zcv9UzTbwu2qlcRNMR+l+ied0HUo5/9XUQKN8oNB8QcLJo4uIvwdvFUR/mkV/j 37Tx4fXGpU3BpfgmpfID812OZS4GKZeocCxuIOIooSmiDPDWYvabLkSPYTNQQddeuQPq HNbJ/mFM2EmddXl/5bd6UnpNuX1oiOkrdTm+pnD3dYdgekGXrHfgt0GwQgGDAqIJ3U3K 4PULFbixj1hbcQbYSjFZl6hGynB/VVbnzw1mzbSSCd0dFRzbDLgm0Z0NCc66SHoBKvpc n8OQ== X-Gm-Message-State: AFqh2kp43x1uxAlhKqL611+NNJ3qo7Wl/ne0CtthCtGGCNDjDDS8WZPk s/pAI7QR9Yhz5W2ctZiQ2/UmOz01SK/2f6GeZsg= X-Google-Smtp-Source: AMrXdXuW5oH7qCrf783SkWF+5Un00TFGbLY1x6jvHqrYZaHBs81C3ZwH8qykQGGpb/VF4zT3NPTLuYN3PX0w5aGyxwI= X-Received: by 2002:a67:6582:0:b0:3d0:d7ce:b383 with SMTP id z124-20020a676582000000b003d0d7ceb383mr376193vsb.72.1673438782800; Wed, 11 Jan 2023 04:06:22 -0800 (PST) MIME-Version: 1.0 References: <20230111114409.7495-1-julien@xen.org> In-Reply-To: <20230111114409.7495-1-julien@xen.org> From: Alistair Francis Date: Wed, 11 Jan 2023 22:05:56 +1000 Message-ID: Subject: Re: [PATCH] xen: Remove the arch specific header init.h To: Julien Grall Cc: xen-devel@lists.xenproject.org, Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Oleksii Kurochko Content-Type: text/plain; charset="UTF-8" On Wed, Jan 11, 2023 at 9:44 PM Julien Grall wrote: > > From: Julien Grall > > Both x86 and (soon) RISC-V version of init.h are empty. On Arm, it contains > a structure that should not be used by any common code. > > The structure init_info is used to store information to setup the CPU > currently being brought-up. setup.h seems to be more suitable even though > the header is getting quite crowded. > > Looking through the history, was introduced at the same > time as the ia64 port because for some reasons most of the macros > where duplicated. This was changed in 72c07f413879 and I don't > foresee any reason to require arch specific definition for init.h > in the near future. > > Therefore remove asm/init.h for both x86 and arm (the only definition > is moved in setup.h). With that RISC-V will not need to introduce > an empty header. > > Suggested-by: Jan Beulich > Signed-off-by: Julien Grall Acked-by: Alistair Francis Alistair > > --- > cc: Oleksii Kurochko > --- > xen/arch/arm/arm32/asm-offsets.c | 1 + > xen/arch/arm/arm64/asm-offsets.c | 1 + > xen/arch/arm/include/asm/init.h | 20 -------------------- > xen/arch/arm/include/asm/setup.h | 8 ++++++++ > xen/arch/x86/acpi/power.c | 1 - > xen/arch/x86/include/asm/init.h | 4 ---- > xen/include/xen/init.h | 2 -- > 7 files changed, 10 insertions(+), 27 deletions(-) > delete mode 100644 xen/arch/arm/include/asm/init.h > delete mode 100644 xen/arch/x86/include/asm/init.h > > diff --git a/xen/arch/arm/arm32/asm-offsets.c b/xen/arch/arm/arm32/asm-offsets.c > index 2116ba5b95bf..05c692bb2822 100644 > --- a/xen/arch/arm/arm32/asm-offsets.c > +++ b/xen/arch/arm/arm32/asm-offsets.c > @@ -11,6 +11,7 @@ > #include > #include > #include > +#include > > #define DEFINE(_sym, _val) \ > asm volatile ("\n.ascii\"==>#define " #_sym " %0 /* " #_val " */<==\"" \ > diff --git a/xen/arch/arm/arm64/asm-offsets.c b/xen/arch/arm/arm64/asm-offsets.c > index 280ddb55bfd4..7226cd9b2eb0 100644 > --- a/xen/arch/arm/arm64/asm-offsets.c > +++ b/xen/arch/arm/arm64/asm-offsets.c > @@ -10,6 +10,7 @@ > #include > #include > #include > +#include > #include > > #define DEFINE(_sym, _val) \ > diff --git a/xen/arch/arm/include/asm/init.h b/xen/arch/arm/include/asm/init.h > deleted file mode 100644 > index 5ac8cf8797d6..000000000000 > --- a/xen/arch/arm/include/asm/init.h > +++ /dev/null > @@ -1,20 +0,0 @@ > -#ifndef _XEN_ASM_INIT_H > -#define _XEN_ASM_INIT_H > - > -struct init_info > -{ > - /* Pointer to the stack, used by head.S when entering in C */ > - unsigned char *stack; > - /* Logical CPU ID, used by start_secondary */ > - unsigned int cpuid; > -}; > - > -#endif /* _XEN_ASM_INIT_H */ > -/* > - * Local variables: > - * mode: C > - * c-file-style: "BSD" > - * c-basic-offset: 4 > - * indent-tabs-mode: nil > - * End: > - */ > diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h > index fdbf68aadcaa..a926f30a2be4 100644 > --- a/xen/arch/arm/include/asm/setup.h > +++ b/xen/arch/arm/include/asm/setup.h > @@ -168,6 +168,14 @@ int map_range_to_domain(const struct dt_device_node *dev, > > extern const char __ro_after_init_start[], __ro_after_init_end[]; > > +struct init_info > +{ > + /* Pointer to the stack, used by head.S when entering in C */ > + unsigned char *stack; > + /* Logical CPU ID, used by start_secondary */ > + unsigned int cpuid; > +}; > + > #endif > /* > * Local variables: > diff --git a/xen/arch/x86/acpi/power.c b/xen/arch/x86/acpi/power.c > index b76f673acb1a..d23335391c67 100644 > --- a/xen/arch/x86/acpi/power.c > +++ b/xen/arch/x86/acpi/power.c > @@ -17,7 +17,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/xen/arch/x86/include/asm/init.h b/xen/arch/x86/include/asm/init.h > deleted file mode 100644 > index 5295b35e6337..000000000000 > --- a/xen/arch/x86/include/asm/init.h > +++ /dev/null > @@ -1,4 +0,0 @@ > -#ifndef _XEN_ASM_INIT_H > -#define _XEN_ASM_INIT_H > - > -#endif /* _XEN_ASM_INIT_H */ > diff --git a/xen/include/xen/init.h b/xen/include/xen/init.h > index 0af0e234ec80..1d7c0216bc80 100644 > --- a/xen/include/xen/init.h > +++ b/xen/include/xen/init.h > @@ -1,8 +1,6 @@ > #ifndef _LINUX_INIT_H > #define _LINUX_INIT_H > > -#include > - > /* > * Mark functions and data as being only used at initialization > * or exit time. > -- > 2.38.1 > > From xen-devel-bounces@lists.xenproject.org Wed Jan 11 12:12:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 12:12:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475264.736876 (Exim 4.92) (envelope-from ) id 1pFZxc-00064u-EY; Wed, 11 Jan 2023 12:12:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475264.736876; Wed, 11 Jan 2023 12:12:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFZxc-00064n-BX; Wed, 11 Jan 2023 12:12:04 +0000 Received: by outflank-mailman (input) for mailman id 475264; Wed, 11 Jan 2023 12:12:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFZxa-00064h-NT for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 12:12:02 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 26b2dfea-91a9-11ed-b8d0-410ff93cb8f0; Wed, 11 Jan 2023 13:12:00 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D516B17771; Wed, 11 Jan 2023 12:11:58 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A009E13591; Wed, 11 Jan 2023 12:11:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id te2/JY6nvmPRQAAAMHmgww (envelope-from ); Wed, 11 Jan 2023 12:11:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 26b2dfea-91a9-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1673439118; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=B3qrf9YikvjYRWNKLSEsWiB+pp5U14J3LBizIBHQ/WI=; b=qamluBfRpiT5Np1/rixUryWJe96HqV9zqy4Ro3rxPqrVYaY0ZMMrR7IXIfYlhJhS9nMu9X P6iNwNfFfU4J7lWSa2YBRLKkrxCEd/kPAFvlPGDKOEl2BUezB/j+vHerKMbgMOEa+Ed8LZ SAY5C1Ga6iZ4ySRlt2CtUsvl9X5cHJE= Message-ID: <2cc22d0a-105e-7569-9148-1267bee17181@suse.com> Date: Wed, 11 Jan 2023 13:11:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 14/16] xen/xenbus: move to_xenbus_device() to use container_of_const() Content-Language: en-US To: Greg Kroah-Hartman , linux-kernel@vger.kernel.org Cc: Stefano Stabellini , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org References: <20230111113018.459199-1-gregkh@linuxfoundation.org> <20230111113018.459199-15-gregkh@linuxfoundation.org> From: Juergen Gross In-Reply-To: <20230111113018.459199-15-gregkh@linuxfoundation.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------LCWxg77wBtn0gC0pubqm0PjV" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------LCWxg77wBtn0gC0pubqm0PjV Content-Type: multipart/mixed; boundary="------------gURSyyQPE0TXCrnge7VP9xW8"; protected-headers="v1" From: Juergen Gross To: Greg Kroah-Hartman , linux-kernel@vger.kernel.org Cc: Stefano Stabellini , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org Message-ID: <2cc22d0a-105e-7569-9148-1267bee17181@suse.com> Subject: Re: [PATCH v2 14/16] xen/xenbus: move to_xenbus_device() to use container_of_const() References: <20230111113018.459199-1-gregkh@linuxfoundation.org> <20230111113018.459199-15-gregkh@linuxfoundation.org> In-Reply-To: <20230111113018.459199-15-gregkh@linuxfoundation.org> --------------gURSyyQPE0TXCrnge7VP9xW8 Content-Type: multipart/mixed; boundary="------------AjYhaO0p3szD2QFXvSvYRgYI" --------------AjYhaO0p3szD2QFXvSvYRgYI Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTEuMDEuMjMgMTI6MzAsIEdyZWcgS3JvYWgtSGFydG1hbiB3cm90ZToNCj4gVGhlIGRy aXZlciBjb3JlIGlzIGNoYW5naW5nIHRvIHBhc3Mgc29tZSBwb2ludGVycyBhcyBjb25zdCwg c28gbW92ZQ0KPiB0b194ZW5idXNfZGV2aWNlKCkgdG8gdXNlIGNvbnRhaW5lcl9vZl9jb25z dCgpIHRvIGhhbmRsZSB0aGlzIGNoYW5nZS4NCj4gDQo+IHRvX3hlbmJ1c19kZXZpY2UoKSBu b3cgcHJvcGVybHkga2VlcHMgdGhlIGNvbnN0LW5lc3Mgb2YgdGhlIHBvaW50ZXIgcGFzc2Vk DQo+IGludG8gaXQsIHdoaWxlIGFzIGJlZm9yZSBpdCBjb3VsZCBiZSBsb3N0Lg0KPiANCj4g Q2M6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4NCj4gQ2M6IFN0ZWZhbm8gU3Rh YmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz4NCj4gQ2M6IE9sZWtzYW5kciBUeXNo Y2hlbmtvIDxvbGVrc2FuZHJfdHlzaGNoZW5rb0BlcGFtLmNvbT4NCj4gQ2M6IHhlbi1kZXZl bEBsaXN0cy54ZW5wcm9qZWN0Lm9yZw0KPiBTaWduZWQtb2ZmLWJ5OiBHcmVnIEtyb2FoLUhh cnRtYW4gPGdyZWdraEBsaW51eGZvdW5kYXRpb24ub3JnPg0KDQpBY2tlZC1ieTogSnVlcmdl biBHcm9zcyA8amdyb3NzQHN1c2UuY29tPg0KDQoNCkp1ZXJnZW4NCg0K --------------AjYhaO0p3szD2QFXvSvYRgYI Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------AjYhaO0p3szD2QFXvSvYRgYI-- --------------gURSyyQPE0TXCrnge7VP9xW8-- --------------LCWxg77wBtn0gC0pubqm0PjV Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmO+p44FAwAAAAAACgkQsN6d1ii/Ey/e bQgAjbPhju5lkpQbgda1vZ8/DpvZTWODueSnVZMfvIG/CesFP2mSzpp9g3IO1DoBcvKCWikBTQXw gDEoDqaVvS72H5uybTNOAZTktXiXt9TLSt6Bkg1TKrW2G9jiTfmhGdNQgt2j5r9sbEvhSz1tFcso Vq6KE7OXQiV5l5+hNDYt/kbpdtgFZpwJYqWJzBEhWcCtcz+ciIewf4wqKsWq/nStN150XFdCW4DJ kj9IgVtW4054+V2+ROzcSNSRLpZ7pUtzlRQq8NjCGCy9WsNQy94u+sqYZx1C8JDjVkOerj9twghz uSXwneu8DEwVojGB4sFYe0VvFvQABU6Q7CSqUMMPwA== =4j1i -----END PGP SIGNATURE----- --------------LCWxg77wBtn0gC0pubqm0PjV-- From xen-devel-bounces@lists.xenproject.org Wed Jan 11 12:14:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 12:14:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475270.736887 (Exim 4.92) (envelope-from ) id 1pFa0N-0006g1-UH; Wed, 11 Jan 2023 12:14:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475270.736887; Wed, 11 Jan 2023 12:14:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFa0N-0006fu-QO; Wed, 11 Jan 2023 12:14:55 +0000 Received: by outflank-mailman (input) for mailman id 475270; Wed, 11 Jan 2023 12:14:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFa0M-0006fk-O8 for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 12:14:54 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2087.outbound.protection.outlook.com [40.107.247.87]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8d5d4fdd-91a9-11ed-91b6-6bf2151ebd3b; Wed, 11 Jan 2023 13:14:52 +0100 (CET) Received: from AS9PR06CA0457.eurprd06.prod.outlook.com (2603:10a6:20b:49a::18) by DB4PR08MB7959.eurprd08.prod.outlook.com (2603:10a6:10:38e::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.12; Wed, 11 Jan 2023 12:14:41 +0000 Received: from AM7EUR03FT005.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:49a:cafe::35) by AS9PR06CA0457.outlook.office365.com (2603:10a6:20b:49a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.13 via Frontend Transport; Wed, 11 Jan 2023 12:14:41 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT005.mail.protection.outlook.com (100.127.140.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Wed, 11 Jan 2023 12:14:40 +0000 Received: ("Tessian outbound 43b0faad5a68:v132"); Wed, 11 Jan 2023 12:14:40 +0000 Received: from 83a73c8f75ae.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 6480313E-C6CF-4E30-8788-17E969093945.1; Wed, 11 Jan 2023 12:14:29 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 83a73c8f75ae.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 11 Jan 2023 12:14:29 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by PAVPR08MB9354.eurprd08.prod.outlook.com (2603:10a6:102:301::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Wed, 11 Jan 2023 12:14:26 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::b14f:1c13:afa:4eda]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::b14f:1c13:afa:4eda%3]) with mapi id 15.20.5986.018; Wed, 11 Jan 2023 12:14:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8d5d4fdd-91a9-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0MvJYukd5RpqeKbJG/1RE6/DG6w+HNio7w46iNbYORc=; b=kjzIzJc4W1eYrJohHo2l5chO19gp0UVZwTXX0GIiwG6FbzMrcXASEbEiZ/+0qXPR/p4M3W2PhgH4M2uPh+5QqFUTd34rvJSTO+DbbBb/vMBi02e2O7s0RKaqGV14HDVnAKdO/j7Yc3lLoBDeTz+gRrzbw5qlBMz14o7XeqTbMYg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: e2bd239f0e166dd1 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wb4an7EHPilKYVUEzdozvgngNC7ureDTzteTt0XtSdgFemxw54FUlZYs1MjUuT3rDBMAaZSlONQirGu2geeB79NPH6W0xChxTTHLm+pXEC4S7Oizo1aLh5iRwrxC7EP9KZgLwUtspkZ2pFPIFx2/+ABO4Gx5qK3zqrBlTvSH0UaPbt4XVn8ivmtINEhQNz+8YIKJvvPWp/ldhT+LRbIbWCfjsGla2bZVU7Q9dVjZaupkUkcG+zsSLmQcOMKZPQCCwMsAfviAFTYYDyI3kl59JF8D0k8nZ7slcxSGYXEhiEoObMNoo0b+Do65pJaNKPoDb7O92NEyXAv8a5j8yV2Zww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0MvJYukd5RpqeKbJG/1RE6/DG6w+HNio7w46iNbYORc=; b=WTi5ZtlDZzjX1/HTXU/yDLDyCC6Jez9xh0+7KJ4VoCIjT9AkzzKXg9IguJbTF6Vij+K4a31j1YDTXjV4tKbwTzPhXm+0YesaQL2G2EodQloTf+bvkAxLHD3VN94EidaH/yXMTNRJVJALETgxPosbmaxikD0ZkCXbnhaaK/eTdRBb2Q/124tb+u5HG7dgXJ2Ep2F7hF+/9QPNGUSMFF8noSrCNmHAaRkNEIQZSE14/+81Sl4nWSolAEhGQp7isOK9WaAG5Lzfhn9VStV8HjtRKdHRvczEnx0rfHSJeMo+QlM1ES5clVdrBdjMgl7JxPFeYRlCe5XlR+O5YcceDfNWpQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0MvJYukd5RpqeKbJG/1RE6/DG6w+HNio7w46iNbYORc=; b=kjzIzJc4W1eYrJohHo2l5chO19gp0UVZwTXX0GIiwG6FbzMrcXASEbEiZ/+0qXPR/p4M3W2PhgH4M2uPh+5QqFUTd34rvJSTO+DbbBb/vMBi02e2O7s0RKaqGV14HDVnAKdO/j7Yc3lLoBDeTz+gRrzbw5qlBMz14o7XeqTbMYg= From: Luca Fancellu To: Julien Grall CC: Xen-devel , Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Oleksii Kurochko Subject: Re: [PATCH] xen: Remove the arch specific header init.h Thread-Topic: [PATCH] xen: Remove the arch specific header init.h Thread-Index: AQHZJbIaKE9+sa25KkC1qw/e7vlCUK6ZIQwA Date: Wed, 11 Jan 2023 12:14:25 +0000 Message-ID: <69428FD5-7BFB-43BC-B2D7-F1C352365EB8@arm.com> References: <20230111114409.7495-1-julien@xen.org> In-Reply-To: <20230111114409.7495-1-julien@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.300.101.1.3) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|PAVPR08MB9354:EE_|AM7EUR03FT005:EE_|DB4PR08MB7959:EE_ X-MS-Office365-Filtering-Correlation-Id: 4b9e937a-e57b-45e0-a153-08daf3cd6a9b x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 9LOBkl0nCdjl4SDOPcoQgwqfEzzAU2tbLDrT5yJwistFtBAq5Wtylo49VybF4soTSZBrE5xjtpCBPvpTQ2ZpHYl4bz+TAPaAlwf0ZD7elg3398GkXhbm6VLjYalsre4K6m53P01Gxw5+yl8xBeMOxhetZZpEnNFgpWCUJzdN/xmVQ81pxOq84IR312li2Hz63xsnPqEeLG3b1WCqWmBlMi0jiseziUtOsjE/EJ+i7Bu3xofjVeCdvQHjGUpaueWvqHED0KfcJMSRcBhpWPJBb0VtIHyGsfLb39a2xPoEsVt89llPp3TgS1HGmtLDxaQdRt9U1QLYDagCeWudgOIem0dyNzEbTCEBl50r4cG4dFSWcUKHD0RLdzc5u6FQQhw5ITgAwedKjTEbtCqNeF4L5Ux9msm+ZPqwr4iPTJlw3rjCRMbZt9zkeRGb7HENeRCoizyD80ElJuOV3IwBRQkW00m9DKaihCtPmisKrrw4/l2kVNyW2DgNZH7zxZqjBEobPDRWyKoRFUoqRf1Pcu9hIlcXgtsOeXyZUhupwHEBTGLAifcfNh2EgvGJu5atkwVUI7kXjsHFQcA+qX7IlpZazPcqLoRq015J5Z3svUWUBrodquPOOUql2UKoOJDf7bwoQsK+ds+8Vxwie9Km1PWMAuqtGe3knXJ5bbz2AQaD0E8Bhw4Aju2TQtYBhL+Ecu3X+q0bw2oY30yr/1yhlCOpaC93ka3fSoRYVN/21sQoVtI= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(366004)(346002)(39860400002)(136003)(451199015)(7416002)(5660300002)(2906002)(8936002)(41300700001)(2616005)(8676002)(64756008)(4326008)(316002)(66476007)(66556008)(91956017)(86362001)(66946007)(6916009)(76116006)(54906003)(66446008)(71200400001)(36756003)(478600001)(6486002)(33656002)(6512007)(53546011)(26005)(6506007)(186003)(122000001)(38070700005)(38100700002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <14F03F888A259C4388E86CA88E34151A@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9354 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 398c2b35-f106-4ce2-d2dc-08daf3cd61b9 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Iks4Gadg3jehNMnx6XqQitH+GXnBfzYzoYNXNM6DqMVP0VIDRRTccpuegQZbgs9mN7yCIn4lge8QZ7iSzSM4t48RWSKKTICfsFjeihq1s90cg+t/yb3uWNV92+q7x6r+ZMXpQd18KAPNol09m4zY9IXPB1UJxZoqo8TK2408lSeflRFx0NAe0Aq+LEr1m6auMPTFN9ZYruAx9ZDQmVB6yobFvvJOYxpLIQ99RskEyO7WODVeQigARfM7WOt8WSB7DH+9dpv3sFvgulsUMFQ76zCrCho/ad7tKKuqTNMyeXocQlZl8qZ58O+Al5xCHKwlm3eY/EBshouOfj7LBBtNjBjp5PGsk3utzHEKOudLiYjJ/82O/BTtg9d1jPRX8JeuHCL3wyOjQXvOhkrXtRVsTHc+/vcO4HoFst+OO6CbXBtUWci8/xsOtr5Nk6Q4B6mqaLLq6hca5hcjNKhDpvyxuieaUx6FW0CfHEOBpGw3z/8cJrfjzlm41LgEKdqHbr9EnX+8lkVm/L/dAaCkXpE4hnbRGPXLvoCsl/hVjCxbMt+SoUuE4nwkSi1HrHhCXSKeoX45eL1jKc76IJ8GmrajzQmohFvrMaSqaQOWDGDEqgnUu2rW3FQhgLL9ej5QUGZYXHdY58JlsgxLcLFQKpnfg7FTUlvKSM+ECSaSh2V+T7GcmsM5uJ88GPTBGhoaC2lIFUB//mYZo0u2QGddlXOLFQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(396003)(346002)(136003)(451199015)(36840700001)(40470700004)(46966006)(36860700001)(478600001)(6486002)(6512007)(26005)(40460700003)(36756003)(186003)(356005)(47076005)(81166007)(86362001)(41300700001)(8936002)(6862004)(82310400005)(2906002)(5660300002)(82740400003)(54906003)(316002)(40480700001)(2616005)(70206006)(70586007)(8676002)(33656002)(336012)(6506007)(4326008)(107886003)(53546011);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2023 12:14:40.8151 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4b9e937a-e57b-45e0-a153-08daf3cd6a9b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR08MB7959 DQoNCj4gT24gMTEgSmFuIDIwMjMsIGF0IDExOjQ0LCBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4u b3JnPiB3cm90ZToNCj4gDQo+IEZyb206IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+ DQo+IA0KPiBCb3RoIHg4NiBhbmQgKHNvb24pIFJJU0MtViB2ZXJzaW9uIG9mIGluaXQuaCBhcmUg ZW1wdHkuIE9uIEFybSwgaXQgY29udGFpbnMNCj4gYSBzdHJ1Y3R1cmUgdGhhdCBzaG91bGQgbm90 IGJlIHVzZWQgYnkgYW55IGNvbW1vbiBjb2RlLg0KPiANCj4gVGhlIHN0cnVjdHVyZSBpbml0X2lu Zm8gaXMgdXNlZCB0byBzdG9yZSBpbmZvcm1hdGlvbiB0byBzZXR1cCB0aGUgQ1BVDQo+IGN1cnJl bnRseSBiZWluZyBicm91Z2h0LXVwLiBzZXR1cC5oIHNlZW1zIHRvIGJlIG1vcmUgc3VpdGFibGUg ZXZlbiB0aG91Z2gNCj4gdGhlIGhlYWRlciBpcyBnZXR0aW5nIHF1aXRlIGNyb3dkZWQuDQo+IA0K PiBMb29raW5nIHRocm91Z2ggdGhlIGhpc3RvcnksIDxhc20vaW5pdC5oPiB3YXMgaW50cm9kdWNl ZCBhdCB0aGUgc2FtZQ0KPiB0aW1lIGFzIHRoZSBpYTY0IHBvcnQgYmVjYXVzZSBmb3Igc29tZSBy ZWFzb25zIG1vc3Qgb2YgdGhlIG1hY3Jvcw0KPiB3aGVyZSBkdXBsaWNhdGVkLiBUaGlzIHdhcyBj aGFuZ2VkIGluIDcyYzA3ZjQxMzg3OSBhbmQgSSBkb24ndA0KPiBmb3Jlc2VlIGFueSByZWFzb24g dG8gcmVxdWlyZSBhcmNoIHNwZWNpZmljIGRlZmluaXRpb24gZm9yIGluaXQuaA0KPiBpbiB0aGUg bmVhciBmdXR1cmUuDQo+IA0KPiBUaGVyZWZvcmUgcmVtb3ZlIGFzbS9pbml0LmggZm9yIGJvdGgg eDg2IGFuZCBhcm0gKHRoZSBvbmx5IGRlZmluaXRpb24NCj4gaXMgbW92ZWQgaW4gc2V0dXAuaCku IFdpdGggdGhhdCBSSVNDLVYgd2lsbCBub3QgbmVlZCB0byBpbnRyb2R1Y2UNCj4gYW4gZW1wdHkg aGVhZGVyLg0KPiANCj4gU3VnZ2VzdGVkLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5j b20+DQo+IFNpZ25lZC1vZmYtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+DQo+ IA0KDQpIaSBKdWxpZW4sDQoNClRoZSBhcm0gcGFydCBsb29rcyBnb29kIHRvIG1lLCBJ4oCZdmUg YWxzbyBidWlsdCB4ODYsIGFybTMyIGFuZCBhcm02NCBhbmQNCm5vIHByb2JsZW1zIGZvdW5kLg0K DQpSZXZpZXdlZC1ieTogTHVjYSBGYW5jZWxsdSA8bHVjYS5mYW5jZWxsdUBhcm0uY29tPg0KDQoN Cg0K From xen-devel-bounces@lists.xenproject.org Wed Jan 11 12:25:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 12:25:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475277.736898 (Exim 4.92) (envelope-from ) id 1pFaAD-0008E8-01; Wed, 11 Jan 2023 12:25:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475277.736898; Wed, 11 Jan 2023 12:25:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFaAC-0008E1-Ry; Wed, 11 Jan 2023 12:25:04 +0000 Received: by outflank-mailman (input) for mailman id 475277; Wed, 11 Jan 2023 12:25:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFaAC-0008Dv-4c for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 12:25:04 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f8e66b5f-91aa-11ed-91b6-6bf2151ebd3b; Wed, 11 Jan 2023 13:25:02 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 0523A177FF; Wed, 11 Jan 2023 12:25:02 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D519413591; Wed, 11 Jan 2023 12:25:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id xE+2Mp2qvmMUSAAAMHmgww (envelope-from ); Wed, 11 Jan 2023 12:25:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f8e66b5f-91aa-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1673439902; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=vZMspio6CqflV2FoZGlGgB3ql5H0jWaCysfX0yUnYDQ=; b=i1j/ru4dgYR90bYOPjq+JSLrzSFu3i9s/RaWWGUijp2M6fS3/bNXgZgzTq+7/Wkoxb+Vco YrOwY5iy3Qm217kyCcQYgZQdqOPNNKWA09rKXzprgg7CG/OpT7LMAK+Y7t62I9v+Y5dJbC qnsseM3aCsLj/JhMkaXRg2Vdz86A4+o= From: Juergen Gross To: torvalds@linux-foundation.org Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, sstabellini@kernel.org Subject: [GIT PULL] xen: branch for v6.2-rc4 Date: Wed, 11 Jan 2023 13:25:01 +0100 Message-Id: <20230111122501.21815-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-6.2-rc4-tag xen: branch for v6.2-rc4 It contains: - 2 cleanup patches - a fix of a memory leak in the Xen pvfront driver - a fix of a locking issue in the Xen hypervisor console driver Thanks. Juergen arch/x86/xen/p2m.c | 5 ---- drivers/block/xen-blkback/xenbus.c | 4 +-- drivers/block/xen-blkfront.c | 3 +-- drivers/char/tpm/xen-tpmfront.c | 3 +-- drivers/gpu/drm/xen/xen_drm_front.c | 3 +-- drivers/input/misc/xen-kbdfront.c | 5 ++-- drivers/net/xen-netback/xenbus.c | 3 +-- drivers/net/xen-netfront.c | 4 +-- drivers/pci/xen-pcifront.c | 4 +-- drivers/scsi/xen-scsifront.c | 4 +-- drivers/tty/hvc/hvc_xen.c | 50 +++++++++++++++++++++++-------------- drivers/usb/host/xen-hcd.c | 4 +-- drivers/video/fbdev/xen-fbfront.c | 6 ++--- drivers/xen/pvcalls-back.c | 3 +-- drivers/xen/pvcalls-front.c | 7 +++--- drivers/xen/xen-pciback/xenbus.c | 4 +-- drivers/xen/xen-scsiback.c | 4 +-- include/xen/xenbus.h | 2 +- net/9p/trans_xen.c | 3 +-- sound/xen/xen_snd_front.c | 3 +-- 20 files changed, 54 insertions(+), 70 deletions(-) Dawei Li (1): xen: make remove callback of xen driver void returned Jiapeng Chong (1): x86/xen: Remove the unused function p2m_index() Oleksii Moisieiev (1): xen/pvcalls: free active map buffer on pvcalls_front_free_map Roger Pau Monne (1): hvc/xen: lock console list traversal From xen-devel-bounces@lists.xenproject.org Wed Jan 11 12:31:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 12:31:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475283.736908 (Exim 4.92) (envelope-from ) id 1pFaFt-0001Eg-KD; Wed, 11 Jan 2023 12:30:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475283.736908; Wed, 11 Jan 2023 12:30:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFaFt-0001EZ-HN; Wed, 11 Jan 2023 12:30:57 +0000 Received: by outflank-mailman (input) for mailman id 475283; Wed, 11 Jan 2023 12:30:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFaFr-0001ER-ME for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 12:30:55 +0000 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [2a00:1450:4864:20::636]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cac2bd1c-91ab-11ed-91b6-6bf2151ebd3b; Wed, 11 Jan 2023 13:30:54 +0100 (CET) Received: by mail-ej1-x636.google.com with SMTP id az20so17363314ejc.1 for ; Wed, 11 Jan 2023 04:30:54 -0800 (PST) Received: from [192.168.1.93] (adsl-211.37.6.0.tellas.gr. [37.6.0.211]) by smtp.gmail.com with ESMTPSA id r18-20020a1709061bb200b0082000f8d871sm6178680ejg.152.2023.01.11.04.30.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Jan 2023 04:30:53 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cac2bd1c-91ab-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Yjk1YZNghOMLZI3FrMEWJU4Cn7nFZUvUvjgjLRR3p2k=; b=AOjelN5z2UIcIODUnVgWrlBIX9DOy+sD3o6f/jPR74RP7uzVY3+4DfdoB61jI7tYzO Yh9qkGKx+gMTTmociq21tB0DYouTv4A3gmAQzXrS7xELrHHOyGcMIgl6HWqAPQSETSDL PkiF1MlDjNt2A4rKQvARidkk8pdSLm+/VhEfTEBwlF8uGfmUTHJqURnBwQzRDHHFXnLw K+uHPZWH4726AL1M+vylSEVP1x/bIZ3zxXydGTzagT95fZHACiApMt623VOnGSNnspFK RFaY56bPgFPeiOAulfAkikKH3BdqEdcAGD5yQ0OwfUrAJB908y3AruuYVMP/PAzZWE3o USPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Yjk1YZNghOMLZI3FrMEWJU4Cn7nFZUvUvjgjLRR3p2k=; b=3vfa4hgEx7RyGeu5KhqSO7K++HP+BpeY/qrS+AEJ8VSdGf+EKUqanMZDSLfztD8daK cvnwqKDfcwHzxKIwwTx96lr6dCeozYbIKEEqemXIjdmljGtncSlk8mx+nQ86zpp/0GTg ScZ/E+zmbOUd4kvukUOzSLFpRRaBRO8wUlWJZeqZlqz9l3HXMKU5YjHWwmrdhqpLp0vX 8//ZMGjOmdXvnU8AN8PagTSs/ExugjJHgfDTDI0Rn6JXDEcx+I8x2EEqm55h01vYPnBb zwtly+cGTqUb+7egxOugPDQhref9YWmQrge5Rb6npepsixaU0bhwfwCwHnXSVy/AUwqN AdCQ== X-Gm-Message-State: AFqh2krGc/JL7e/QJOWjuncIuB/KwWCiBfVdo7Jt9bVBSZBfssl3Hdju AVDwEuzSRlrCcu8DihSsVFA= X-Google-Smtp-Source: AMrXdXvNAsGU5q66/AH9qF3roK03cLm2BWTh8G7reASo6tOvzixzJEnl0XWV5s9mWLkvF68lyIWEPg== X-Received: by 2002:a17:907:8d16:b0:7c4:fa17:71fe with SMTP id tc22-20020a1709078d1600b007c4fa1771femr9867416ejc.45.1673440254190; Wed, 11 Jan 2023 04:30:54 -0800 (PST) Message-ID: <2acf07aa-ec56-99fc-765e-70fb7e753547@gmail.com> Date: Wed, 11 Jan 2023 14:30:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v3 2/6] xen/riscv: introduce asm/types.h header file Content-Language: en-US To: Jan Beulich Cc: Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org, Oleksii References: <06185fcfb8cbd849df4b033efa923b55c054738d.camel@gmail.com> <1b6ee20d-2f32-ab38-83ec-69c33baf42fd@suse.com> <0398c48c-cc5d-a4fb-354f-54e3c5900d18@gmail.com> <644334f1-8e1d-3203-e942-0eb3ef5584a9@suse.com> From: Xenia Ragiadakou In-Reply-To: <644334f1-8e1d-3203-e942-0eb3ef5584a9@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 1/11/23 13:38, Jan Beulich wrote: > On 11.01.2023 11:22, Xenia Ragiadakou wrote: >> >> On 1/11/23 11:08, Jan Beulich wrote: >>> On 11.01.2023 09:47, Oleksii wrote: >>>> On Tue, 2023-01-10 at 17:58 +0100, Jan Beulich wrote: >>>>> On 10.01.2023 16:17, Oleksii Kurochko wrote: >>>>>> Signed-off-by: Oleksii Kurochko >>>>>> --- >>>>>> Changes in V3: >>>>>>     - Nothing changed >>>>>> --- >>>>>> Changes in V2: >>>>>>     - Remove unneeded now types from >>>>> >>>>> I guess you went a little too far: Types used in common code, even if >>>>> you >>>> It looks then I didn't understand which one of types are needed. >>>> >>>> In "[PATCH v1 2/8] xen/riscv: introduce asm/types.h header file" all >>>> types were introduced as most of them are used in : >>>> __{u|s}{8|16|32|64}. Thereby it looks like the following types in >>>> should be present from the start: >>>> typedef __signed__ char __s8; >>>> typedef unsigned char __u8; >>>> >>>> typedef __signed__ short __s16; >>>> typedef unsigned short __u16; >>>> >>>> typedef __signed__ int __s32; >>>> typedef unsigned int __u32; >>>> >>>> #if defined(__GNUC__) && !defined(__STRICT_ANSI__) >>>> #if defined(CONFIG_RISCV_32) >>>> typedef __signed__ long long __s64; >>>> typedef unsigned long long __u64; >>>> #elif defined (CONFIG_RISCV_64) >>>> typedef __signed__ long __s64; >>>> typedef unsigned long __u64; >>>> #endif >>>> #endif >>>> >>>> Then it turns out that there is no any sense in: >>>> typedef signed char s8; >>>> typedef unsigned char u8; >>>> >>>> typedef signed short s16; >>>> typedef unsigned short u16; >>>> >>>> typedef signed int s32; >>>> typedef unsigned int u32; >>>> >>>> typedef signed long long s64; >>>> typedef unsigned long long u64; >>>> OR >>>> typedef signed long s64; >>>> typedef unsigned long u64; >>>> As I understand instead of them should be used: {u|s}int_t. >>> >>> Hmm, the situation is worse than I thought (recalled) it was: You're >>> right, xen/types.h actually uses __{u,s}. So I'm sorry for mis- >>> guiding you; we'll need to do more cleanup first for asm/types.h to >>> become smaller. >> >> What is the reason for not declaring __{u,s} directly in xen/types.h >> as type alias to {u,s}? >> >> IIUC __{u,s} and {u,s} are needed by code ported from Linux while >> Xen code should use {u|s}int_t instead, right? > > Yes. Hence in the long run only Linux files should get to see __{u,s} > and {u,s}, perhaps from a new linux-types.h. Thanks for the clarification. Could you please help me understand also why __signed__ keyword is required when declaring __{u,s}? I mean why __{u,s} cannot be declared using the signed type specifier, just like {u,s}? -- Xenia From xen-devel-bounces@lists.xenproject.org Wed Jan 11 13:17:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 13:17:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475289.736920 (Exim 4.92) (envelope-from ) id 1pFayf-0005Yd-5G; Wed, 11 Jan 2023 13:17:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475289.736920; Wed, 11 Jan 2023 13:17:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFayf-0005YW-1O; Wed, 11 Jan 2023 13:17:13 +0000 Received: by outflank-mailman (input) for mailman id 475289; Wed, 11 Jan 2023 13:17:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFayc-0005YQ-KP for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 13:17:10 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2079.outbound.protection.outlook.com [40.107.20.79]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3de542c8-91b2-11ed-b8d0-410ff93cb8f0; Wed, 11 Jan 2023 14:17:05 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8558.eurprd04.prod.outlook.com (2603:10a6:102:215::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.13; Wed, 11 Jan 2023 13:17:03 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Wed, 11 Jan 2023 13:17:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3de542c8-91b2-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iqydBGDl+UjeI6g9kwruVpimJmwH6MWBS2j22656D2/KZucAvPQwjiFjQKZQHa2llmJekV1OdrbyzFBdLyI+x3ddxCoTqH5P6CrUTPhcG9IHCDYSXJfsnHVXGXU+1/VSCQC90FLwtOpUr0ZXgjUNZP2PnJOvtXX8+ReM8Yk8Ac1r+AiJmgpo+cPAj+3ATQrrys5CXP5qpQzudmV5qDYyX0/jwh3Q7fTDtWcWPo5Y0HhAHXmyq1IIsWJUkrNCYWtknAkVmAQq4pryIurkdV8twRVCYtTPLuZ4FjLpw53G5paAxffD8t6Ray3pabYLvDrvzpx5THRbezC8ZLMRvuw5rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nzrFD3tt/PvzTVbC4ffQHf9Qv8d3GT/J1THhPr70VZI=; b=ZymPjonLrqRvxOx50s1IAaz35c+dj9erKUpeBfurteWSto2X3YST9IyFXlGKuEGXF2m5qxIIpTImtHKU9vRZRhDm7Rp8rjB8Jn+9xSgmdNoR6Apw+hM+n7whimlIqKnurVxZySvVpcHmYcMkr+1qZVJELwXKTayR7H4atQU/IEIyeu7hyNW7nzufO2Q4O6xo5EUr7tYm+Nw3vHx2pQqfit/ED66Dr4uqNfZAdB6sXmuZX6RzOm9H4gYqlfmwdFJTZiZ//Yk78rTSIcLTYmq43fZPYD5aaGvnoNRhmfW9XJSEgwHkSeBMvAhNEaKvENXjIrhrhkhr5Aoebr7tWej4yA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nzrFD3tt/PvzTVbC4ffQHf9Qv8d3GT/J1THhPr70VZI=; b=i50kvVXFd+R2D4mVRVZy1Xp7LMahj/9XjDt511rYsNJtkFr6g44sQQGiVzkCZwtSBDX2P2Lrlkt8FcGy6SrPpy4P6W+zKOFCD6W+WJM4YEfh6aUE+Iz2gvsoNpLQ2gpYZbHJRUjgr6K2JZAXZsfQJG4rXIM/j/8HvYXqaBht2/Jkrfam15bVQ/Xam1NYfP0FVOItmg/F8zug+mxS7hHJonAQLwZs9DEsm9J3KCH9qcvj6MTg9Lv1GO7P/mxBt3AnKhZz3Z6O049NFbYZgBRjSmYYZJg9zGAgJAO2yXm0npimrvVEciBv5aFNJvdnqRh6wom/1j1pG8evBrJPyRBWZw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <72930382-b216-4ec3-6d29-889a3bf0bc6e@suse.com> Date: Wed, 11 Jan 2023 14:17:01 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v3 2/6] xen/riscv: introduce asm/types.h header file Content-Language: en-US To: Xenia Ragiadakou Cc: Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org, Oleksii References: <06185fcfb8cbd849df4b033efa923b55c054738d.camel@gmail.com> <1b6ee20d-2f32-ab38-83ec-69c33baf42fd@suse.com> <0398c48c-cc5d-a4fb-354f-54e3c5900d18@gmail.com> <644334f1-8e1d-3203-e942-0eb3ef5584a9@suse.com> <2acf07aa-ec56-99fc-765e-70fb7e753547@gmail.com> From: Jan Beulich In-Reply-To: <2acf07aa-ec56-99fc-765e-70fb7e753547@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0143.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8558:EE_ X-MS-Office365-Filtering-Correlation-Id: 49d1b50e-24e9-4f93-fca3-08daf3d62134 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dMCgeY6HsXb90QxYyMf6SDZpNcE5AeHrY8H2Maa7+QveUKAEyCCP7vW3l86bnpYFUM2NJ9rN1/HB1QC7i2XWgqxU+x1zlli/g5oZxaDg7vmFj3KKcjodkKuz81ylaVIHSYg0sEj03rnIeXvgg1PggGW+XrRvO9JR8ZyXi+f2axio1mHL3QHiYD10jcZ7HXyoVtZUTDXLdamyBz7hncbndSr7xTLiIiimqBpUWrUByiPeXx4j3fPH1iRZPGqCUqjorYDCaN7rcNl/bVJVOzIH/vV63BaleUL8LXFBrN9/gYFkau47c6qvZTwYf008LimkN9roxUULA3ApOJbOs5p600XYTr6e3vJkIMUR/GQzXfpvh4v87DIEMD0uJaJDC9lPZnIjqt26MeZsgp/xlGWtj4qSwISjL9s26v9SdtKyPsdcslYo1NS4+8yj77hglmJZV6V2Cze6XCa4968WxtGj8DIGWFylVydiPviAbsWjLjUJfbMNz8TSpyM1pDCF8AntncmRO3WrDGQ5ek37xsoja1rxDes2DOpO9VS7QoGhOPcXo2/ijambFUgayKcX634jGDthyfyyog0n1bJ3wH1W5cjlFQ/Ortnqo02vnmZFkDpb2xF2CopxQil4Hdd5Ztsz9R6c03Pqe2oxkdaaSNUaaZvlMKHAsXhvCTEdZv6RDUCl9g+hpPv9MnJnameB9sT/JdABxpF6Kcq2TJeDHeqk03bKG1b1rpg1bmWCIhVUHuk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(39860400002)(396003)(136003)(376002)(366004)(451199015)(7416002)(6506007)(2906002)(36756003)(8676002)(4326008)(6916009)(53546011)(5660300002)(8936002)(4744005)(31686004)(38100700002)(6512007)(41300700001)(6486002)(478600001)(26005)(66476007)(66946007)(66556008)(186003)(86362001)(31696002)(2616005)(54906003)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TWNld0pOYTJ3aERyanZpdWVxdG5KcEQ5Zy9GT3U3UzdTb3VWakExd1IwWTA4?= =?utf-8?B?NVY3cS9ySDFFdm9kNWFDbVVoM21yM2U3dmtoeE1NUEpYdFEvS1lmYVZ4RmdP?= =?utf-8?B?Tlg2aExoOTdlcXp2d2liM2g3SlpKL1hPU3NwckNRMEp3OUdzWHZhZTQzQ3pV?= =?utf-8?B?WDJqU2x1SDhaUFhyZ3cvNXcwdG9Cakw3aElpZUZrRFRiWlFmMTlYSXBsQ2Zi?= =?utf-8?B?STZKWi83US80Zng5ckNxVVhQaDlpSG05Q2k1MzBIWDZVT2VTUzhpald2QjBh?= =?utf-8?B?MHJnSERORzdTVmFxVXduLy9rNCtTZVdkUjdDR0NwVmY0UkxrTmVBQTJhQzZw?= =?utf-8?B?NnQ1THFYbGRMYnRhT1o5c0p6cTZXSEpmUkN5NlRldW1yWmUwZVJoamFPNmdM?= =?utf-8?B?TExsV0dnL1Q3Nkh3MkhGSjAyYVdUNnp6M015bCtFZ0oxVHk5VEJkOUxpcVJj?= =?utf-8?B?eGVlSTgzNmVqdHdQUytBL3NmZ1owZ001S2dqckgzN3VLVzVuLzEzYnlFUk1i?= =?utf-8?B?em5JNGVCcENSTmJqWHM3QUdhV3ZnanhwQ0U0NWhuMk5zLzk0V043U3hqY1JQ?= =?utf-8?B?VUJJTUFlSVlhaHZFSHMzVGd0aTF5V0hzRGhFVkdha0NISzk2MUg2ZXNmajIz?= =?utf-8?B?VzM5bUVjL2lxdm1iQ3g4cm5ZeUNsdDNnOGNyWXRYQ1c1NFVqRjNvTEtYaG54?= =?utf-8?B?bkUrVUF1N1U4SlExVE1CNUNwLzd0V2RDK3dicXRxWTlmbEVjOCtBcVJmT05M?= =?utf-8?B?Z1RhRERCcG8wL3lvSGd2Z09KckxkU05sWndlcC85dXZQZEgxMHMvTTJWcFVW?= =?utf-8?B?aHYrb1pFM0Njbm9mMDN2c04zM1RhbnR4a3NOTEhIeUJjd3J1VGswTkxla2hh?= =?utf-8?B?VzdjTFgxQkxINVRXMEpwemtleHVxa2tIQzNISHEzMjJGQTNQZlVaZUlBRkc2?= =?utf-8?B?ZnJISnlOOWNWUDRTOHpCRWRxeUdyZ01VcDVQSVAwVXRkcUJ0cDFCU3BPbXlh?= =?utf-8?B?cGpQQUcxeHlUTkkwR0NQdjB5a2RiVzdzeU5GNnQrSjZJYkpIVUZWMVpsTTBt?= =?utf-8?B?ZWNDLyswRFZFQzJZR2NWM0Z2Q1RUc25zaCsrT00xTkJDTEpMRUNSS1Flc0o1?= =?utf-8?B?MnQzcGFMSnY1cEtnYlZyZDdpejJJYkd3MXhPRG9CMVl4dHBzVkpFSmd5RTg3?= =?utf-8?B?QVVYTmJuQ0R2bU5HdTRZTkpyQi83MUdPbHFyZTRGems5REEyY200WkpRdXJ5?= =?utf-8?B?L2tiYzcvb3ZzK2JRV0pFYXdSdExCbElXa1VxYitrV2FueFNtdThjSDdibnNJ?= =?utf-8?B?NFRhbUF4ZEFGdVZvb05yd2lqWUNER1VXTUI1d0hZK0FGc08zTlllb0pOWDFY?= =?utf-8?B?Sk5pUjlYNWNsMVZ3ZVFEbnNzNHBkWUZnQ1pRS0NMam9JTXRyWkI3amEyNUg0?= =?utf-8?B?OHRXVmxSS3NTdHdSUWJoTUhCd1V0NVNxb0l5QVRnQ3l4OUVyelppYnZQUlNE?= =?utf-8?B?c3hiMFVtNGpSS3pJNEtQUWZUNXoxREpkZWdwUTRvbk93NVg5eXVNUXYvRWhP?= =?utf-8?B?M3hPZEFIeSsrT01YcEZaOEx6b3FVOVl3dy9TY1A1NEJ2bmVWVmt2d1JrZmRP?= =?utf-8?B?L1VkOS9IWTM5akJmbUlyYTFPUWNHbHpqOFdhQUR0bmNSRkUxYzEvNlFZQlZt?= =?utf-8?B?TktCQzRqbDRZbjVOSi85T1owM0hSRkxjZ2JJT1lza0JOakIxWWZEMWhtRjE2?= =?utf-8?B?RitRc3p0TWlJLy83Y21lMzFJOE84ZmNIUzNzL0h4MGxLUzIxZlR3L1ZXN1BL?= =?utf-8?B?L0FhU3p0WDFRTUNIZllRTWpSQk91UWJ2MkxGNWZmZEovOTZDUHVieFEvSE5E?= =?utf-8?B?dWFtNEk3bVhySEZxMnpCWGp5aXVhdEVsLzVFWGI1QmozdkowOWsvdlZXbnRr?= =?utf-8?B?RE4zSDI1bkdzMFJUTVRGNDRMRFNWdGlmdGpWaDFKQi9wTzFUOWNnU1hvQms1?= =?utf-8?B?bmpFNjBlaEpKTERvWFRaRDVGTUd2aXp4c1NOaTEyQ3pvSG1SaWhEcHg3bEdm?= =?utf-8?B?cGQ0WXRnVVA0RDVBWmlPQStGWlRTM3JSdjdoN29yQ0NiOXBvenFjdCtnUTZE?= =?utf-8?Q?BoP82NGQX0BZfo7tOhIxbWqb+?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 49d1b50e-24e9-4f93-fca3-08daf3d62134 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2023 13:17:03.3892 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IZ2wtJMfXsN17lPxBHcqi3wKsJ69OXJ/+HLe4Q3yAYHK4jSgT2LIwnzYBuTwG+hYAWQgzfpajQH2E4oS//F6Jg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8558 On 11.01.2023 13:30, Xenia Ragiadakou wrote: > Could you please help me understand also > why __signed__ keyword is required when declaring __{u,s}? > I mean why __{u,s} cannot be declared using the signed type > specifier, just like {u,s}? I'm afraid I can't, as this looks to have been (blindly?) imported from Linux very, very long ago. Having put time in going through our own history, I'm afraid I don't want to go further and see whether I could spot the reason for you by going through Linux'es. Jan From xen-devel-bounces@lists.xenproject.org Wed Jan 11 13:30:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 13:30:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475295.736931 (Exim 4.92) (envelope-from ) id 1pFbBC-0007rS-8g; Wed, 11 Jan 2023 13:30:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475295.736931; Wed, 11 Jan 2023 13:30:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFbBC-0007rL-52; Wed, 11 Jan 2023 13:30:10 +0000 Received: by outflank-mailman (input) for mailman id 475295; Wed, 11 Jan 2023 13:30:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFbBB-0007rB-KZ for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 13:30:09 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2045.outbound.protection.outlook.com [40.107.21.45]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 103d15a8-91b4-11ed-b8d0-410ff93cb8f0; Wed, 11 Jan 2023 14:30:07 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8209.eurprd04.prod.outlook.com (2603:10a6:20b:3e4::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Wed, 11 Jan 2023 13:30:05 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Wed, 11 Jan 2023 13:30:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 103d15a8-91b4-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mFIy+QvfbTeOv3/reyp9xdENLhPruCS2CAq4iDulJs/Py44UBJ8IfJN6jXIDw4iaQzn5JOX2y7FUeigS1yVeSY2+6jVprV4DLEqj+cMnDEYGJsUFo4yOy+0zHndShbG6FKos6VGil2JOnVeh/2U/dkET0feYV+UxGAB9yheRB3QA9ncUfpifeVADu9DcQaFTanigGtyir11GNTW8IXXc5eZCEZS48UGQZHglIO7HHtLhtQ0WahqhGNUSyezkkku2hX66c92JmjE/d/A5pxWpPQ/rFUenUvb+sx6UVEpdiWcM40KtlHdXZMjkGHYThHvLIYjawUdHpxPFwvi4dUPUjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0TX1CqU2wGeQ3+EII8UKIjdIZad4JftlhHN3FtONqdI=; b=M03ZLfKZZGG6vFBANJwOjMoK3aY9aX/EDpw6rikctdsPd5+rXLPZtuxT2npVkVLJcCspCBwV/MjFelW5X8u6pC/6A9KrpXZzoCp40kz0zqATN3M85aEkUkR6kvRAiWd8cP01VSGyovJxK5JbMdr43FkKmyBOwK1kUo4t1Mw4Ke886NOdEuMHIgPxn8h8pTg1X1v5MlZFiwHjsaqTYGh25cHED0iWJaJYXQPYvQfbHzID55l3VVi8GCcmShpKBBIgUxSRD+aAsA8lQUYpeBuK3+MLjNKAToIACzLsR6vC0LFgicesiyXaVsNdaSfoEzgt6cxxIf7hpSpQLLBtK6QrTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0TX1CqU2wGeQ3+EII8UKIjdIZad4JftlhHN3FtONqdI=; b=jU1cqnh5cEsEYvAv+3zrIGHI1UlKcTDAcNBNmDy24aZKjtWGf5ssUoHn/wuZErLhwgrqOOantorv+Jf9cnxdPrcQqKZ6aewG2AZZNP+RScqrc8tvRpGbFJlYMOa3aV6Lcl++7n4EfemNKljNGBlXaq09tdZYAA2/CiaKEQPI/hMBP8ncmna/Y5UAt7tCetBpkw4VnHwCSSbz4gFvE0yexmwWfEac5hfAnZQdK1m2mCGwFjTYDUL7Xf6ilZhb7dEOrTboQo6YNg0H9D/d+5j14NGjSphIg29hZs/DlKGNo17d3gii7D+yFW36nHQ7WX5biWzqBf/0SxhkIjJP6b830w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <306563b1-c040-6e28-c50e-0d742c59cb7c@suse.com> Date: Wed, 11 Jan 2023 14:30:03 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] xen: Remove the arch specific header init.h Content-Language: en-US To: Julien Grall Cc: Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Oleksii Kurochko , xen-devel@lists.xenproject.org References: <20230111114409.7495-1-julien@xen.org> From: Jan Beulich In-Reply-To: <20230111114409.7495-1-julien@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0002.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8209:EE_ X-MS-Office365-Filtering-Correlation-Id: f59bd13b-b996-4e8e-7f70-08daf3d7f319 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uvttihokEJKvUeQebd7F0I7hmHf1wK2+LYMdN+RAVqQ/Qicy/JggHbJCPKeQjB7pfb4D4qyB8cXriNJ3RVZoEsIg92U2OH8GGKSFWf5i1S6kSUnXPC2ojw5Vfv/Rs1oIlgofgAA8HlgEXh26vdO5UJJFiiCfMLfjadE5wybfV7lJa/34Nao1cvI4zjsIU0KAYEL0rvDSKxr1jTN171EVkgFFZasMA3E+rvg0B6xx7GbRb8LHsoOknkYcKRBxCPQYvTIzFy55VXv4wUJoqpswPMKH37twfO4T70F2ylCXAE/S87fkLteH/eXPlqzoJTOwJIa/qJcf87IWXBC0U8CwcdVQKCLezUOs0NwHMo2D+CkP0cRmefk6xt1aZki0cxirgng3c+JigJUp1C6+2IDCab/x8YgGzh2fwDNRPnjkNhk9RX5ICRdi6W7z1XIlHzJ9nrg0gKwo1Y/eDPomUYGkshMLlTGveYFqY87ahqndSglK1Lkluv6WUeK8T9EVvr5cFS04RtvJfTfDEO3QZAYNSBd9pvNgt2K8izD3Eb0KsfTHvwDUWJv4niDTvgBbtNh6bMUr3YWcIjwyG8duCitxPzbwRlaJK/sqOPg7yMqRp6bHO7YifTDj5K9OD/8v8UlkDtXh0N355jDxK/4OnKYZq5NjgRZVCv0jJzNvwxs0N1eZdTgLJgYU1/Vdhrmoy8J8haxR0cpX9EvZsvdYI83mBUX/v30bBf3cvVNAwUMr14g= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(39860400002)(366004)(376002)(136003)(396003)(451199015)(8936002)(2906002)(5660300002)(41300700001)(7416002)(316002)(4326008)(66556008)(8676002)(6916009)(66476007)(66946007)(54906003)(26005)(6512007)(38100700002)(2616005)(31686004)(86362001)(186003)(31696002)(53546011)(36756003)(6506007)(478600001)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bFRnVFhzQ0ZSdGh4NjJCSXExTjF1VmJVVE1BYWxMeVRFMUJrZ2o4UXdMK3By?= =?utf-8?B?V09qSUJHSlJGOTNBYnovYXJJRVZ3dlJiUEVES1pGdjYwZzZIMnRubDN3OVg3?= =?utf-8?B?eHV3WjVramV1RFByZVdUTnplSHZzd2tDS3ZJcFFEL004SWdRK2xURkZVdXRW?= =?utf-8?B?YjhHZWprWXpGdU81bTRkODYraW05MzR6YXNmVDJhYVJhZDZuQ3c3RWhXaGFC?= =?utf-8?B?aWZiTzkyWmVOUjV5QVZsM1FwZHl6bjZFaXgzeVlBeFFoVVJiRVZLR2E4aUlP?= =?utf-8?B?SHdYQVRiVHVvLyttMUJjM0pTblJ0Qkt3R3pXczZKRzVUbWdtM2lyUjlPYzMx?= =?utf-8?B?WU15WnQ5dU1EU3R6YXpaVldNZlE4ZlU0dGJuSmZDa0RPWTZsMmtkMjJTZzcz?= =?utf-8?B?NUFOM3dJNy93UkovWGlrSE9VRVFuRWcwcHpnSmltNWRMeStya2tRNFVWcVRL?= =?utf-8?B?OFdrbFhaNHhFQVQydUk3Z3l6UFkzdzFwZVVrQTJqS2NHaU4wVlFaNVA5TE5U?= =?utf-8?B?MWF5clhwcHBwb0NQdENXOUdHQ245WkJBa3lFSzd3ZHR1cWpvWk4yVUtDaXY1?= =?utf-8?B?SUpMZ1V1TE5KcTQvd2V6ZlZmU1J5dmU4RnB5MjNXWXJDLzg0N2NZWGtnS21z?= =?utf-8?B?cFZMZEJIRWhLbUU4UGVmd0lpYjJmUmhsNHRGejlGZDR6OWY3SzhNaXNoUjNI?= =?utf-8?B?VFRsVlZUY3pybFNRTUx1OEZqQUs3QUw3SlJQYWMvVThKMzB3Vld5VUpERnFO?= =?utf-8?B?NFYyUkZrdDJVa2JIOUFzVHgwbUQzNWhVUHFWcGNCT2Y4RDdUUUZGM1U5ZXd3?= =?utf-8?B?N1dFbER3RUFnbmFvM3BHaHJCV1BEaEo3djNUUEZib3NwcGt3TmxLeGN4S21n?= =?utf-8?B?cTRTZ1RodTk3OXM2VndHYldtdFA0UkRNMFhMeU81MHYydXNYUXExWUxTRGkw?= =?utf-8?B?RHYzVFFnZk52dzU0OEtZM05WV2ZQWWNCQmpYTGVRZTJVenEvSXVTOEd0QVpE?= =?utf-8?B?eVhudEduNDJtbUxkdERabU5vV2llaHltU1pMb3BPc1MveE5iRVlpa2Ezem5E?= =?utf-8?B?b3lSTktVWjBhNXlrUVBBUjZPbzVwVGdBTCtod3ZkOGlQaUk3RVRGRmw3dHly?= =?utf-8?B?VTAvbDNQRHRRZHJPTFZzaUVQU0tVOEw2Q1VsRm9LYzZib0tjWTNrRlNSZTFN?= =?utf-8?B?emFBNzltUVpxWGoydG44bVdpKyt1eC9wRll1c1dNbGYvbVRqb1dDMW5tMGN6?= =?utf-8?B?amRWa1RPdlVZTUhWUElCNlNNY2lvRS9zSmgveG9nYWZVTU5SaWxnenRBZmNu?= =?utf-8?B?Mi83UGF6ZTM4SlkzS0JHMS9iY01ZbmNQUkhZRGM3UDRxRnNwM3RzZHFNdFd1?= =?utf-8?B?NGF4Mi95citFa1JscEpvYjc1ZXhQbFI5Q3BqVTdmRGNXRXJKM25HU3FrOFJI?= =?utf-8?B?WkptanBMcUt4SVI3MlUyOUZLU0lHTGJaR2lpU1hhMFQ3MDdJTktxcnVKYmph?= =?utf-8?B?TTl6Vm40enU5amJ0c1lDMlBLaUNxa0tBWktzb2YzM1Z4WUpLWnE5blBMY3Jj?= =?utf-8?B?c1lpMzBXWGFqTEx5aHZvRXJMWURIMWVOU0NBS05xazQ1SnVQbGVpSzA0NTQw?= =?utf-8?B?ZWZTRFI3YjdsUHFkaTRrUmVuYjIrQk1HUkdKRU4rcEpaaW0zWUx5Rm91MEsz?= =?utf-8?B?MHhRcFJ4UjVyMU1DREp0QklZa2ZNWE9WQ25ZODA1bTNydGZVOHc5a2tjZmNr?= =?utf-8?B?OFhpT3V3MDdMWGQrWmVYUWRnSVljMUlpSjBhamhGR0pnaStkWEM2VEJlNUp4?= =?utf-8?B?THhGVWFDWENFdWFZUUJlYnVSNDViZ1phOVFhdDhRNDhoWTU4U21McDdRVUVT?= =?utf-8?B?dVBZUmFrcXMrM1YzWndrcVBPeHgrS3ZTcXVma21XTDcvT1ZCdnMzV2Jqa1hP?= =?utf-8?B?S2NXZFJxOEVraEJBL3JqSmlnUDF2WlRrV3pqMlZsaE5CeGpOTkNpclFMOTcz?= =?utf-8?B?WUR5UGFWc0JBTnFLNXFMK2NESFNCUldpT2d1bmpzT1RFK0wwMGtWZDlRZHpE?= =?utf-8?B?MTdXQThXejIzMU1idkRjU1Z6ZFRzVDJLbEhreHJnam1sZm5JOUlFTksyL0o2?= =?utf-8?Q?ym3fMi3k5IyGKagTVdLYCgT08?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f59bd13b-b996-4e8e-7f70-08daf3d7f319 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2023 13:30:04.9649 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OcbW7KA4WD4T3pi9QjJrf6WslnpNqJtvNqSoVJCRKwDK4vlYknMLPhYJnUZNY/YpvJpl3hHSBU3CivH7lePUcw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8209 On 11.01.2023 12:44, Julien Grall wrote: > From: Julien Grall > > Both x86 and (soon) RISC-V version of init.h are empty. On Arm, it contains > a structure that should not be used by any common code. > > The structure init_info is used to store information to setup the CPU > currently being brought-up. setup.h seems to be more suitable even though > the header is getting quite crowded. > > Looking through the history, was introduced at the same > time as the ia64 port because for some reasons most of the macros > where duplicated. This was changed in 72c07f413879 and I don't > foresee any reason to require arch specific definition for init.h > in the near future. > > Therefore remove asm/init.h for both x86 and arm (the only definition > is moved in setup.h). With that RISC-V will not need to introduce > an empty header. > > Suggested-by: Jan Beulich > Signed-off-by: Julien Grall Reviewed-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Wed Jan 11 13:35:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 13:35:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475302.736941 (Exim 4.92) (envelope-from ) id 1pFbGg-00006m-1n; Wed, 11 Jan 2023 13:35:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475302.736941; Wed, 11 Jan 2023 13:35:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFbGf-00006f-VE; Wed, 11 Jan 2023 13:35:49 +0000 Received: by outflank-mailman (input) for mailman id 475302; Wed, 11 Jan 2023 13:35:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFbGe-00006V-KK; Wed, 11 Jan 2023 13:35:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFbGe-00085c-Gw; Wed, 11 Jan 2023 13:35:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFbGe-0002vq-0i; Wed, 11 Jan 2023 13:35:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pFbGe-0001jJ-0J; Wed, 11 Jan 2023 13:35:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=a4tPSNcJ1Q+cgVxfRTd+oLsh4xRBRuM072Zyzw6m+zg=; b=NKLu0nj4CmfGd3kT5MbFJyBY2a AFlXGD5uFiAh/0BH/FP7syUm+WwhqNoRN/RW25JTG51bBIHbf0f7C65gI5XEUll8XQRWXEDmOpTt5 46liEoccksVlCVEI/37DsJ1TISZOTnp26g1f0rEPn1Tc8fCnXvPUiiIjjiKknyJdStvY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 175717: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=7dd4b804e08041ff56c88bdd8da742d14b17ed25 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Wed, 11 Jan 2023 13:35:48 +0000 flight 175717 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/175717/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine 8 reboot fail REGR. vs. 173462 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux 7dd4b804e08041ff56c88bdd8da742d14b17ed25 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 95 days Failing since 173470 2022-10-08 06:21:34 Z 95 days 200 attempts Testing same since 175717 2023-01-11 03:09:17 Z 0 days 1 attempts ------------------------------------------------------------ 3319 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 505897 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Jan 11 13:36:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 13:36:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475308.736953 (Exim 4.92) (envelope-from ) id 1pFbHE-0000cH-BV; Wed, 11 Jan 2023 13:36:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475308.736953; Wed, 11 Jan 2023 13:36:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFbHE-0000cA-8X; Wed, 11 Jan 2023 13:36:24 +0000 Received: by outflank-mailman (input) for mailman id 475308; Wed, 11 Jan 2023 13:36:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFbHC-0000bs-Ju; Wed, 11 Jan 2023 13:36:22 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFbHC-00085z-IB; Wed, 11 Jan 2023 13:36:22 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFbHC-0002xa-6v; Wed, 11 Jan 2023 13:36:22 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pFbHC-0002RX-6V; Wed, 11 Jan 2023 13:36:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=N8yjvevQDF8meG17XgBT9ibHclfwJsOAcZlZRFo/MRc=; b=gaEw19yT7PrAz0gUMCYOFbbrLq ZgfnQY7HtBGWT0JO+7w0xPzI6mPqfF3qz9dsxQyz7hxraNucG2IPCHWQz3kpRFgv/g8l4f19eMz9V pGB3YdwWLovTQyXD89Qv+kHKKLdGtW4MMiDmaQmIwp+yJAuF29XwIKEMmbnpBO/w9MvU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 175721: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=e66d450b6e0ffec635639df993ab43ce28b3383f X-Osstest-Versions-That: xen=4d975798e11579fdf405b348543061129e01b0fb From: osstest service owner Date: Wed, 11 Jan 2023 13:36:22 +0000 flight 175721 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/175721/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen e66d450b6e0ffec635639df993ab43ce28b3383f baseline version: xen 4d975798e11579fdf405b348543061129e01b0fb Last test of basis 175712 2023-01-10 22:00:26 Z 0 days Testing same since 175721 2023-01-11 10:03:26 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 4d975798e1..e66d450b6e e66d450b6e0ffec635639df993ab43ce28b3383f -> smoke From xen-devel-bounces@lists.xenproject.org Wed Jan 11 13:51:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 13:51:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475318.736964 (Exim 4.92) (envelope-from ) id 1pFbVf-000339-LS; Wed, 11 Jan 2023 13:51:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475318.736964; Wed, 11 Jan 2023 13:51:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFbVf-000332-Ij; Wed, 11 Jan 2023 13:51:19 +0000 Received: by outflank-mailman (input) for mailman id 475318; Wed, 11 Jan 2023 13:51:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFbVe-00032w-SC for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 13:51:18 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2077.outbound.protection.outlook.com [40.107.241.77]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0498bb00-91b7-11ed-91b6-6bf2151ebd3b; Wed, 11 Jan 2023 14:51:16 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBAPR04MB7352.eurprd04.prod.outlook.com (2603:10a6:10:1a8::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Wed, 11 Jan 2023 13:51:13 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Wed, 11 Jan 2023 13:51:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0498bb00-91b7-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ehFA9beu3wI7dZRUgk2FXcAMUMID6fFgaInH/T0KRL9m9q194mJvYEXO53QposM+tS2dV+ovYWCpeQH3kp6ID6uLnLyQ5HbhswhyG7b1D07iRWFk6lHT4f7Aqq67b67wdRivwyilE88AQ/9gcY04ezMhDKfgtOakvcqm7Q7259Zqe/2fkNiWJ2MBbRMuuMFxugcZgmKZSwdlnOojZzBZxDKbo72gwGJItg5IgaF/7djSyG/2BPtirIFvYyUWMiwKOrSP3y9J26WNIQ1HFBkCSQ9HWrPf2PBSStJeR2xt1ijkzZYMLmnpxGjrbNvXuOg5yFDhU0fJcXYGHuYcwm4S4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ILA0dFecrQ4kY+XxLhjKokOnovJsHmRJvxl1dDrFEto=; b=YKD78oWLtyUPLaEDNPVHMmYse60pk3FR2fwDmVTrNkf5TlZ+t7JNPFKy9ki0/DC73yavQoZqx6RrM04IumXrcWFUcxcJ7ZY+PKYsSl0bi16YIe5A/99zh4yyMHkQ0To1WX/uJgEmvDMayTH3o8Q5Qoz5SewRvF7HBbE0B/fFlc/ddiksuF97eXTMn3x0FVaso6pddm7gAvIIcIv72sx/XC0tmkH293tmLgBHWPJHA7nbgZTyKegqfxIdzzaiGVDRvSzbrNUKkENhAhcThRE+3PdpQmGmaqHpgupMjMKeTusTHXv2T8zaOQc2Qdk1yUVrw3sIISzMqmi6jtYoFesZjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ILA0dFecrQ4kY+XxLhjKokOnovJsHmRJvxl1dDrFEto=; b=tTvqcj6J30POYLQoKIElakEDxoCJ8yc1QYJ2z2ckqqwvIVi3c0Y/pxGlcjxp3oRPl5GVwwC9N19q2q937mJGK6npiWxRsG20+GkGtZ81Y3ovuNucBOYyi+6uf/B7ZEM47+Du/WKgT6qzt4fkFXtNJ4Leta4KblL1cHu1S+omSrC+sxbfeHSmgivYtYkBdsCGLM041aQF9tQQJiz2e5FGXapYlz7XbT1YdzMEJepimZXLtePskwDwtWZZGKJL21PjqSTuI1K3+Xll/KKMNYDgFd/yv0Wo6k+nwtT5BNS2GpTisuNYWLKQYB/KiF9bWf63RvAmZlP0jYEjQeeFBJ+wKg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 11 Jan 2023 14:51:11 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 From: Jan Beulich Subject: [PATCH v2 0/9] x86/shadow: misc tidying To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Tim Deegan , George Dunlap Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0050.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:92::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBAPR04MB7352:EE_ X-MS-Office365-Filtering-Correlation-Id: 860045e7-638c-45f0-b423-08daf3dae759 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Kt2YvQvDn+8szyiGFtv0hDU16mJfdkPI/ohTB/p2Qi+svxCrcCiqidUznA1JK7wUQgrqfpJS6JUAejatqBn9v0kA6RiFSMZZdGH28EyCMF72k7pG6Y4yen1o6psFZWPASVL9geyteQ8UE0sDcFjK80wkm2YBbhR6bC1G1LUbn4XmxSMgPvKByUVQ2gnn9SntakTExHVSH5XUcpD52MoV7lWEfrpO0qw+fMf76Ag9/KjpZWhl1qOwWhprg1Bi61rnKzzMvnfMtJhn7whZ4PD4UmUn6gQUbvaHvfbNXkGxKIfenrjsL6k4eP3Wm5sSSfAg21wxEu3dwezmVxbD8VijKOEKfyiFdDKDWMjwUU8qXAnNWQTq6tEQnIZMJ9orUIoH8etQ9Ftb/ASCpvvxpiF7jcx7TmWSRXhuvc4YBGidcbwuibl8J23FXQ5nCM1jvmCAvQJArzK1lyanPhkN1D/NyhmymVD+Zb/fUKA0OMIimaqRutr6E79bN42hjQaI0/BHodepp5yzUhXOwMDkp9Q3ECn+SlvyVjETps8oIFOWvw8TjO/LHCpP9/E0KNeNf6938kida6nqfQejWBMPmp4LKTf6fi+JhxK4WM4bVwomlqxMJBJJGfgcKzMyfp+fuiE0BD2KDs0qucXhn1aLyl1GP/QDfIWzOq0WOL+v60DWr7adboffpo3EFCh3Dt3dF2pK3zomZlxPhYRp4/Rg310ALtoSvRutDnO5Qf9T66gE/TA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(346002)(136003)(366004)(396003)(376002)(451199015)(8676002)(83380400001)(31696002)(38100700002)(2906002)(4326008)(5660300002)(4744005)(8936002)(6916009)(66946007)(66476007)(186003)(6486002)(41300700001)(6512007)(26005)(6506007)(2616005)(54906003)(478600001)(316002)(66556008)(86362001)(31686004)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dWNPUFpoM2hwbEtyNlJlekNUVWttd2p6cXdxMTFNNzBsYUthdW04ZW9BUjFp?= =?utf-8?B?a09vQjhxOTNGcGcvRS9UNlEwR0ZFU1RVYjZoTFZYYkNsRmszdlJJall5K0R1?= =?utf-8?B?RkwvdFloMFI0Z1E2akNwZlFUM1V3Uyt3a2hvMS91dFNSVnQ2VGdlaFE1Rk9J?= =?utf-8?B?VWhtOCt4SEFYelFLZ3E2aTNxODE3aCtsaHVPN0tNVjdpSHdGcjI4MHpsUXRy?= =?utf-8?B?RHRlclBrVnRBS1dNQzBrN0t3WmpDNHJQL2podHJVb1dGcnd5QUw2ZEVDSFMw?= =?utf-8?B?Q1BiVWdrTnJGdU5McXB1WmVHNmhxeHpXMnBzeWJUNU1tUUpmWTdmL2YxSVRs?= =?utf-8?B?Tjc0VW54d3VIS1ZlMVhGREFyMkU2TnhTZ3VSUHM4ZEJncVJ2MlFuM0JSK0Uv?= =?utf-8?B?M1NNQXphNVYzZE5wWUp4My9CaENFTlpsNFlTZTROQm53T25iWXJaRzBZZG91?= =?utf-8?B?OXBmcHdITk9Kb1Y2T3UrUHEydUl4NzJVYmhLTXFFVHo0UGsvV2hjOEpUZzJN?= =?utf-8?B?R3ZrenpmUWQxZDl0eXpNUzhJWDc4UUE0NXNmYUNpODFVU1RoSXVSSFA5UWV4?= =?utf-8?B?QnBXdE9aREpmNjFXTXhNdG9QU1FwS3pBblQ1K3lNVEQyTUM1TFFJTjlML08w?= =?utf-8?B?ZWszRGs5Z0J2cGc0bmI1SC9vNnRDMDJPUCtzbitqNkxxSFh5ekZESXRld2Fz?= =?utf-8?B?QWpwTnVqdmxzam9WODRiS1BKbS9kdjRtTmdWMkhxVG55M2FnZnpoWEcrdE1O?= =?utf-8?B?Z3d1Z0JDeUFnTktUOUlMU3RZelpEbWpHeHJPZms0cFBhYXFYd0lKZ3ZPNnlG?= =?utf-8?B?eWNUeXRlcTNpK0xBNVVTaWNRV1pXNXBKMFNKa0N4bTFZSllyUEdidG03YWxH?= =?utf-8?B?ejdtODNMN3MyTExROWtKUlhSZ2h2V3FSZUNSb3pwbFVxNXNMMFZacER3ZlNy?= =?utf-8?B?WUMvbkNBZVhXQ0o3SldaNm03SDNXNlEydk9YNTViYm5LdC9NdC9ZbmJuMUVP?= =?utf-8?B?VnZ1RlZhRFRYb0wvSWcvL3pSNkV3ZU1hMlJPOTZyMmpXbW5DVTlvVU56ZGl5?= =?utf-8?B?UTdYTUxWNnh2Q3Y4UGNEVWY4b0o0amFBSmdNOVlrSmxiMWh3N2QzeGt2em5J?= =?utf-8?B?Q2ZuVmdZT3o0WlBpUHdpaE5BOU5NM1lMMlo0eDBWVGcyY2dYbzNyZ1ZxRnJU?= =?utf-8?B?ZzZ2M1NWanpJOTlmWXNGenFXc0hqT3BLcnFJS003NmhqbS9ObUFNai9PTFVM?= =?utf-8?B?YVlhV3BQSXlYc1l3T0p4NDVtbkNrTkk0OFFjVnNBdFpVUjl0dE56VGFFVXVL?= =?utf-8?B?cUNqMXJucjE4VlFPSVQzRzZwOGliWmg1bmxJUnRTVjFqSHVCQThiWUNsNndz?= =?utf-8?B?a0o1dWltTkIxZkhqWkNzNE1WdzFycUFIWlQxbDMzV1JGcjFXLzg4bFhNT0pQ?= =?utf-8?B?bGZXMVFkUlV1UG4rODE0TnNCak1XQkxwT1J1eXczbmZEeUlnZk1XSmtNenZT?= =?utf-8?B?MXNzWXRmSmZweU9sd2diYmNYN0JlSlVmSEJrK2ZBdTVFb3VDa3ZQUE1nY2R2?= =?utf-8?B?MytFQnBFSGxjUlAzK0padnE3Q0h5UkYyQUN3cjVuZ0RZbjhycWd6R0Zucm56?= =?utf-8?B?S3hQMkxnT1JVenRFYzNib25hc0R1aklmWlk2aS9BRm5sVEV4QkpnMER1L0gx?= =?utf-8?B?bkQyaGpWbWtOcG9aWCtYeURIY2JrT2puOVN2M0JKMGNCRkZiSm1QMmlFZ2RE?= =?utf-8?B?aFdzNkJGRklURW1zUlBQWm9RTWM3c0M5L2J3dEUxOCtGM3ZlZlVnSGNvOWJT?= =?utf-8?B?OWErY2NlM0Fuc2c4eWNPRjczUHVVNjkvRU5Rbm9qTksrTW4wUXdiUUxZa1J1?= =?utf-8?B?bmhNUUlrdU1ZaGs1UE42aVB2TDRHcUZWM09JbkV5czloRnYxN1FudlI1d3RN?= =?utf-8?B?Q2p3cWU0VDhXOGdWdXpJT1YwT2tnak42RjE1MFZHYkxLYlVmQjZJaG4vbi9v?= =?utf-8?B?ZEpRYUtEeldKNlhjZ1Y3Q3RBSzVUUUVhWDY5VU9RVGFOelhjV2taSE1YeFQr?= =?utf-8?B?cHYzQWZLZ3Q3eXdFSmI0WWgvZU9GZXZBWUExNDhCM1lSUWxJRy9zQnR0WklN?= =?utf-8?Q?L3YaIxosS2geUayKPQlo7mAiY?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 860045e7-638c-45f0-b423-08daf3dae759 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2023 13:51:13.7275 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6Ew2zOJpg+hVd2QZJ1gxeJehLbYzl5A1S7TWQyhu/+5Pz/4lWIZ4eNqrs+4r1K/OWEC1dnglGVKzv/n/P7h51A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7352 ... or so I hope. The main observation was that we still have both hash_vcpu_for_each() and hash_domain_for_each(), where the latter was introduced in 2014/15 to replace the former. Only some eight years later we can now complete this conversion. Everything else addresses other things noticed along the road. Note that patch 8 conflicts contextually but not functionally with patches 3 and 4 from "x86/mm: address aspects noticed during XSA-410 work". 1: replace sh_reset_l3_up_pointers() 2: drop hash_vcpu_foreach() 3: rename hash_domain_foreach() 4: drop a few uses of mfn_valid() 5: L2H shadow type is PV32-only 6: x86/shadow: re-work 4-level SHADOW_FOREACH_L2E() 7: reduce effort of hash calculation 8: call sh_detach_old_tables() directly 9: harden shadow_size() Jan From xen-devel-bounces@lists.xenproject.org Wed Jan 11 13:52:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 13:52:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475325.736975 (Exim 4.92) (envelope-from ) id 1pFbWn-0003dJ-3s; Wed, 11 Jan 2023 13:52:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475325.736975; Wed, 11 Jan 2023 13:52:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFbWn-0003dC-12; Wed, 11 Jan 2023 13:52:29 +0000 Received: by outflank-mailman (input) for mailman id 475325; Wed, 11 Jan 2023 13:52:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFbWl-0003d2-Vu for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 13:52:27 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2081.outbound.protection.outlook.com [40.107.13.81]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2db852a9-91b7-11ed-b8d0-410ff93cb8f0; Wed, 11 Jan 2023 14:52:25 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8551.eurprd04.prod.outlook.com (2603:10a6:10:2d6::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Wed, 11 Jan 2023 13:52:24 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Wed, 11 Jan 2023 13:52:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2db852a9-91b7-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PnJXs/RCFzWvUfIZrzXsIUTiCGrHr6jla1sdXi42MvSxY3MQAvpBGTIER/bnW4Hi5ytmrbHEpHM50/qAl7LaQzNhto4LVcKMd41+EiCKXZ0I4rQfOHZhgYeccEboBEY459Cj7O1DKpKIyYP4VcyQ9cYzaChZ4sLmwWbtl8dbvru+GrOlGNpvpX4QzQiJJjiw9uD7m1+mbr/1tVcpb7hj0k2L14e9KaQRpuIvDFS/CqYH5VuZ38QnhyHRQQOvk3JRHS1kg5RQJRKzWw8nf6wG7WI+e1mKEAHoq/egIo5JhAXz+UmIN+RmtLitzn8ysfMkP0g313xyZ9eWHSiS1L59xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KK/uRlwbYcJhgv6CUBJFcIfHjTvH5M/RQaJchWkIy70=; b=MBCyyS5Ey085RxPJypzjAQCj2Yb0n/K4ZU6ceMTQFiXncVyeZhSiJdrioXyqjpzimOtdRLoWje5xaxE/cEiRwg3vPJTVlBSmN7xlZ/4fjFcDGeMJ701mEduSMVEHN6afcv67s6e2/rVHByDrK2MCXKwXkXv+HJgSR2vKbeJGKbobLIeoNXCsUoiVh5XiXr//78XWscH9VXMkiPBAwWf+H74k/egUrtU7R52DtOz67SGxR4CWHd9aeskIm7gGZaRQnbREj6/IRxD0BwFiVLuQYexTed5VIu2636UX04qRktdpPHbWsJ4QdCSGdNfDHybxYHdKrxLz6XJJeibbvOh+1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KK/uRlwbYcJhgv6CUBJFcIfHjTvH5M/RQaJchWkIy70=; b=zTZ3dJEnc4LIasDhgH0+ZFcgb088WgxZGxR1ih5Ddihv/4ynuTkzfMQOdNgtwMbwx+JPt1OWrPZS+B/3ES0zCAiZtSwLGtliXWkj47uK+tS0PyiiaSFqgGaiH0WUlzKijD8R+fDYHz7PjmkO5QbpOZmUStqPKGypaBrLJUzmr+VIDvo5ETjXJkPPxOxvs/r0+vqANr2/frYRF3m1S8P2rPH9zYsJaRs7xr3TzDxzxeQzqei7kVTt8qffp1ZUh3DOWzTxxan3sVmJ38v4BLvUWoscdzVGrgppVC4Kp1iZnC49dMUEdklIXQ/ZMGfPhurLjMvMB6icqWnO6oQh0cQgRA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 11 Jan 2023 14:52:22 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: [PATCH v2 1/9] x86/shadow: replace sh_reset_l3_up_pointers() Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Tim Deegan , George Dunlap References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0063.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8551:EE_ X-MS-Office365-Filtering-Correlation-Id: dfc66c8c-e5ab-4393-7521-08daf3db113f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FAg/V3ol1FxL1GfqhAbdhCjB4B35KZL+j52JNj0TaLBgflCBP1Ix6ERrGgelSlRmnY8H5o/yYVhoKj4FW5QojGsNNNvTgzGZaBscoGuXgSCxZP+qwKL435daBOGcGHMb+fDX1OUg6P/82nvpqBKorVY3LZ1hyvSSTjW6pyeHrzhSr4YYeZtvZzkjZU3dVKlulV2tmzaovBPOjJRbtuD3CnqCVpuMe8up2X5ysjx9Ma36M26CSp5IMShlPVl2QZ8UHjxDPnT5Yu/Ua1jZwLUTL0utjr3poNDaF6gMh3PBpZb/mhbz1SQrCoUoQu3ZQ4yQabXqT9+1Ex4gwnMFSyndmXAbba53thJVAzeD7vLX39toVUH8pW0qbLcpLUEiGUswEP9R+xqAOa0lZPSG9BU74jvemnnJqARFTSylDbDU0a5Ww0gA2ndUOnmm8e/Z1Zboam5xBn2OT+r9rFdIKLkHV758IlvaHTW6IOEqO9R4RkjLwEhZm+6XGV2hm56eSNtl+8+xhBAXGE4+kDVNBqz87unFy+y4EvUaL32JhWExqKy/4n0qqO2lNOZyMTA51x6jboqhwS2qynHgzPoBOj/XkjliuzxGjrZBTm3dwLbTGHKa+ZyH/mjcqmhQDA94vGFRkQnN4F4OLmksR7X3ygeZi9miopC3g/3a2HHCrnjCX5iWrzBgndXcl0UPQLqMBr8BZLJGGYpMsxdxhxwz/gHy5T+g+l0aFF5rLBA3ehcW/vA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(39860400002)(366004)(376002)(136003)(396003)(451199015)(8936002)(2906002)(5660300002)(41300700001)(316002)(4326008)(66556008)(8676002)(6916009)(66476007)(66946007)(54906003)(26005)(6512007)(38100700002)(2616005)(31686004)(86362001)(186003)(31696002)(83380400001)(36756003)(6506007)(478600001)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZG1mZ2ZNQVpSbTZxbUhqalNhK1hrTi9wZHlPSG5xZjlUV0xBeFhMb3JtdG5I?= =?utf-8?B?cTZta0gzUkhCb3JMeTViL1BueFc3bjQrdzZRU1dkanBTQkxpY0FvbDMvT2hn?= =?utf-8?B?QkxSTllCWkc0MU83YjY5RVRFSWdPeitZZGp3c1VEVm5tbkoveVpZNUpkVElX?= =?utf-8?B?OGVOOFhJQnAzMStMN1hwc1JYeVhnaFpjUGh3cVJxQ1VJbzd0Y2lHVTZTSkdC?= =?utf-8?B?L3BPUWVHMVhFdHE4MzUrcWFCcUM2aUFtMUdFeVhqSmE5NGFxK29WR0IreXM0?= =?utf-8?B?MDJ2RU93TUsreHp4Q1ZncGc4K01EWWdUQ0NUdFlaRW4zMVBHUVRwTndHZldR?= =?utf-8?B?YjVveDZyQWdJUWFwWThWM20vU2NKV3prUlhHRmxUWXpCZXZDUVRPdDZocTY4?= =?utf-8?B?cTFFdUg4aVg0MGhRNU1QSkhzR00xREdPUjZpR1JjenFjREFzKzA5V2Z6bVd1?= =?utf-8?B?VnFWb0dNUjVKMXVVbTlLdVJvUXVRWXo5dVdvN00rRGRrell0eDVNMU9YUVoz?= =?utf-8?B?N2lXZlArRktJUXMrU204R0RNbWRoRmxieG0wK2VWekZKSHkrYmptL1pwM0ZM?= =?utf-8?B?YUhkaE9zbEpGajlCSTVkbnFSSUoweGpaTFUvTldSUGFHUWJadzFweUREemRw?= =?utf-8?B?SlA4YXpSQVJtcGtZNk5wOHF2RmR4enVEZ05HdGxVM1pnaFlPUXZ1Q3dqQ3Va?= =?utf-8?B?d0Rod2VWc1AzQUZ1QU0wQWl3eURZbU1YMUlQb3NtMStNSmlocThEZGRaTzlV?= =?utf-8?B?SW5qTzQ4dGl0NktyZDZlWnBwVUR6eHJab2gxSXV2WlYyN2FHQlRscDFoZUNF?= =?utf-8?B?K0VZQmcvQmZycjJRQkM0R2pUOVJicEloS001SStyU21uMTlydVJFOWEvK3NF?= =?utf-8?B?UTNwbTRPd3hRaWdWa2xvemJaeUJHdVN1Mm52V0ZaS3ZHa3JyQ0JqUkNzL3gv?= =?utf-8?B?aHo1OE9sOEVHb2MyNUxQb1I4cUxlZ2cxRkR0UWxwUXpZSXVFZDhqd1FkOUhY?= =?utf-8?B?bitwaWVJbFRRWEI0WlJYVXVRTVcvbFExQkk0ZVpRWHFTZ1UyMU1UeENCK1h3?= =?utf-8?B?UG0yQ0dvSm92MFpsc0g1cFpkMG8rdWVYcllJSFVwKzJpVFN6QkxOSHF0OEJM?= =?utf-8?B?UzlKdU1WRjFFWmUvVVJncG9oYmVPZUx0Uk1qbFdtWjRXRUJyTlQrWEFuc3lh?= =?utf-8?B?bjdQZ2U4RzNwVXdIa2IxVUQxOTZOL01aMTZoOHRhTnJsVDlnOUVFdXJpR0hM?= =?utf-8?B?MG8zYWd2bkFCNnZMNktadlFNNnR4UDVKbXdGemJWcmdPNkFva01xQTBpTm9M?= =?utf-8?B?TFZpUTl4SDRtU05RTU12b3Y3bWk5WGtSa1VzZG9SeDhVMituRFFMeGFZWW5O?= =?utf-8?B?SGF2ZmJGYkxPeU1WUW9yY1lQUEFUVzhTampsL3FwZ3o5cDhhaG5JWlBITDBX?= =?utf-8?B?TEl2TVFOUWNiOFc2N09DdGxNVjFzemg3bFl1OUhjZmNtbXN3RzJsUVhYeXRn?= =?utf-8?B?QWNZcHY3ZXpUVCtDREs4QVQzNHhkd3lyRFB1VGROemtWU2VsWHRJSlE4b2xs?= =?utf-8?B?aGUvbEVBOGdnbllZY1ptVzVlSk1GUTM0NXNVQVRHZENFVUF4cERYRXVINXN4?= =?utf-8?B?OFo2Tm5YWmVld2JUcUFnVm5PUE1rNjZscitDNkNpT3RmVzgyQUdUdTh6QTA5?= =?utf-8?B?Tjh5SDVKZG90Y3NkOUJWR0k5YytaRlRTdnlEa3JIRm9hbHN3VHpEUTM3c04w?= =?utf-8?B?b1FnckkzazdzWEd6a21IdXM4Nms5RHFBeWl6cHNWM2V0enY3OGtxUlo0YnRO?= =?utf-8?B?VnIzUmM2b0N6a0ora0xBSXpta2hDNGFqTnBOaTNYakdkdGJ5R3MyMWFlZVBW?= =?utf-8?B?UFlURVZuak4xRkF2bXpLdVFUemdSTUs2SjcrNG0wTkp4RzdUeWNmaXM1MDRH?= =?utf-8?B?QStjYUpHakVleW1NTWxxamt4eGE5RERDZTB1clgzVkFiVlJuZnB6UU1XRkpj?= =?utf-8?B?OVl4OEViMDdqblc0aFZOZWNDTFZwcEE4WW14UWlDblhwR0k1TDhWSDJYQm1p?= =?utf-8?B?Z3JRdndaV1p1bHZta2FmNW5DcUx5MkJRbStoQ0pHb3NDU2lIRjZsZXA1UzBP?= =?utf-8?Q?r7K6LbkkbedpDlsGwErrqgxUj?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: dfc66c8c-e5ab-4393-7521-08daf3db113f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2023 13:52:24.0355 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /U09tZ0oVetiutgyIdihm2DyfKHPO/w6U5ml9c+X/+ZicL/95qDaPBMkt1HZ0THp0BBZ33yXwVlA5/KkecZJYQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8551 Rather than doing a separate hash walk (and then even using the vCPU variant, which is to go away), do the up-pointer-clearing right in sh_unpin(), as an alternative to the (now further limited) enlisting on a "free floating" list fragment. This utilizes the fact that such list fragments are traversed only for multi-page shadows (in shadow_free()). Furthermore sh_terminate_list() is a safe guard only anyway, which isn't in use in the common case (it actually does anything only for BIGMEM configurations). Signed-off-by: Jan Beulich Acked-by: Andrew Cooper --- a/xen/arch/x86/include/asm/domain.h +++ b/xen/arch/x86/include/asm/domain.h @@ -116,6 +116,9 @@ struct shadow_domain { /* OOS */ bool_t oos_active; + /* Domain is in the process of leaving SHOPT_LINUX_L3_TOPLEVEL mode. */ + bool unpinning_l3; + #ifdef CONFIG_HVM /* Has this domain ever used HVMOP_pagetable_dying? */ bool_t pagetable_dying_op; --- a/xen/arch/x86/mm/shadow/common.c +++ b/xen/arch/x86/mm/shadow/common.c @@ -2302,29 +2302,6 @@ void shadow_prepare_page_type_change(str /**************************************************************************/ -/* Reset the up-pointers of every L3 shadow to 0. - * This is called when l3 shadows stop being pinnable, to clear out all - * the list-head bits so the up-pointer field is properly inititalised. */ -static int cf_check sh_clear_up_pointer( - struct vcpu *v, mfn_t smfn, mfn_t unused) -{ - mfn_to_page(smfn)->up = 0; - return 0; -} - -void sh_reset_l3_up_pointers(struct vcpu *v) -{ - static const hash_vcpu_callback_t callbacks[SH_type_unused] = { - [SH_type_l3_64_shadow] = sh_clear_up_pointer, - }; - - HASH_CALLBACKS_CHECK(SHF_L3_64); - hash_vcpu_foreach(v, SHF_L3_64, callbacks, INVALID_MFN); -} - - -/**************************************************************************/ - static void sh_update_paging_modes(struct vcpu *v) { struct domain *d = v->domain; --- a/xen/arch/x86/mm/shadow/multi.c +++ b/xen/arch/x86/mm/shadow/multi.c @@ -960,6 +960,8 @@ sh_make_shadow(struct vcpu *v, mfn_t gmf } if ( l4count > 2 * d->max_vcpus ) { + d->arch.paging.shadow.unpinning_l3 = true; + /* Unpin all the pinned l3 tables, and don't pin any more. */ page_list_for_each_safe(sp, t, &d->arch.paging.shadow.pinned_shadows) { @@ -967,7 +969,8 @@ sh_make_shadow(struct vcpu *v, mfn_t gmf sh_unpin(d, page_to_mfn(sp)); } d->arch.paging.shadow.opt_flags &= ~SHOPT_LINUX_L3_TOPLEVEL; - sh_reset_l3_up_pointers(v); + + d->arch.paging.shadow.unpinning_l3 = false; } } #endif --- a/xen/arch/x86/mm/shadow/private.h +++ b/xen/arch/x86/mm/shadow/private.h @@ -497,11 +497,6 @@ void shadow_blow_tables(struct domain *d */ int sh_remove_all_mappings(struct domain *d, mfn_t gmfn, gfn_t gfn); -/* Reset the up-pointers of every L3 shadow to 0. - * This is called when l3 shadows stop being pinnable, to clear out all - * the list-head bits so the up-pointer field is properly inititalised. */ -void sh_reset_l3_up_pointers(struct vcpu *v); - /****************************************************************************** * Flags used in the return value of the shadow_set_lXe() functions... */ @@ -721,7 +716,7 @@ static inline void sh_unpin(struct domai { struct page_list_head tmp_list, *pin_list; struct page_info *sp, *next; - unsigned int i, head_type; + unsigned int i, head_type, sz; ASSERT(mfn_valid(smfn)); sp = mfn_to_page(smfn); @@ -733,20 +728,30 @@ static inline void sh_unpin(struct domai return; sp->u.sh.pinned = 0; - /* Cut the sub-list out of the list of pinned shadows, - * stitching it back into a list fragment of its own. */ + sz = shadow_size(head_type); + + /* + * Cut the sub-list out of the list of pinned shadows, stitching + * multi-page shadows back into a list fragment of their own. + */ pin_list = &d->arch.paging.shadow.pinned_shadows; INIT_PAGE_LIST_HEAD(&tmp_list); - for ( i = 0; i < shadow_size(head_type); i++ ) + for ( i = 0; i < sz; i++ ) { ASSERT(sp->u.sh.type == head_type); ASSERT(!i || !sp->u.sh.head); next = page_list_next(sp, pin_list); page_list_del(sp, pin_list); - page_list_add_tail(sp, &tmp_list); + if ( sz > 1 ) + page_list_add_tail(sp, &tmp_list); + else if ( head_type == SH_type_l3_64_shadow && + d->arch.paging.shadow.unpinning_l3 ) + sp->up = 0; sp = next; } - sh_terminate_list(&tmp_list); + + if ( sz > 1 ) + sh_terminate_list(&tmp_list); sh_put_ref(d, smfn, 0); } From xen-devel-bounces@lists.xenproject.org Wed Jan 11 13:52:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 13:52:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475329.736986 (Exim 4.92) (envelope-from ) id 1pFbXE-00049g-F3; Wed, 11 Jan 2023 13:52:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475329.736986; Wed, 11 Jan 2023 13:52:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFbXE-00049Z-9u; Wed, 11 Jan 2023 13:52:56 +0000 Received: by outflank-mailman (input) for mailman id 475329; Wed, 11 Jan 2023 13:52:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFbXD-000486-17; Wed, 11 Jan 2023 13:52:55 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFbXC-00007H-S9; Wed, 11 Jan 2023 13:52:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFbXC-0003jc-Ez; Wed, 11 Jan 2023 13:52:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pFbXC-0005rG-EV; Wed, 11 Jan 2023 13:52:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=WmcN1gR5iWVs5Cq2Jm0coIAsjVLXJHEr0jlramojE7k=; b=05Ha6d8vu7JIieARrR512kArVI GDEAJCTk/NQb35TbztCO4Ld/ro9jKEnZ5UYGvIXEn5RH9bT24xCb5C+4c/6aj2yZGWpfGz9tb/JPR +CCImAg8TY4oDci0idBOkkM3poQGspZbp/bGnKY/9jJlk67BHo7CYYS5ULFUmI5e4amE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 175722: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-amd64-xsm:xen-build:fail:regression qemu-mainline:build-amd64:xen-build:fail:regression qemu-mainline:build-i386:xen-build:fail:regression qemu-mainline:build-arm64-xsm:xen-build:fail:regression qemu-mainline:build-i386-xsm:xen-build:fail:regression qemu-mainline:build-arm64:xen-build:fail:regression qemu-mainline:build-arm64-pvops:kernel-build:fail:regression qemu-mainline:build-armhf:xen-build:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-coresched-amd64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:build-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-rtds:build-check(1):blocked:nonblocking qemu-mainline:build-arm64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking qemu-mainline:build-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking qemu-mainline:build-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-dom0pvh-xl-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-dom0pvh-xl-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvshim:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-pygrub:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvhv2-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-freebsd11-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-freebsd12-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvhv2-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-multivcpu:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: qemuu=aa96ab7c9df59c615ca82b49c9062819e0a1c287 X-Osstest-Versions-That: qemuu=0ab12aa32462817f0a53fa6f6ce4baf664ef1713 From: osstest service owner Date: Wed, 11 Jan 2023 13:52:54 +0000 flight 175722 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/175722/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 175623 build-amd64 6 xen-build fail REGR. vs. 175623 build-i386 6 xen-build fail REGR. vs. 175623 build-arm64-xsm 6 xen-build fail REGR. vs. 175623 build-i386-xsm 6 xen-build fail REGR. vs. 175623 build-arm64 6 xen-build fail REGR. vs. 175623 build-arm64-pvops 6 kernel-build fail REGR. vs. 175623 build-armhf 6 xen-build fail REGR. vs. 175623 Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-win7-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ws16-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-shadow 1 build-check(1) blocked n/a test-amd64-i386-xl-vhd 1 build-check(1) blocked n/a test-amd64-i386-xl-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) blocked n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) blocked n/a test-armhf-armhf-xl-rtds 1 build-check(1) blocked n/a test-armhf-armhf-xl-vhd 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-amd 1 build-check(1) blocked n/a test-amd64-i386-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-i386 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-amd64 1 build-check(1) blocked n/a test-amd64-coresched-i386-xl 1 build-check(1) blocked n/a test-amd64-coresched-amd64-xl 1 build-check(1) blocked n/a test-amd64-amd64-xl-xsm 1 build-check(1) blocked n/a build-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-shadow 1 build-check(1) blocked n/a test-amd64-amd64-xl-rtds 1 build-check(1) blocked n/a build-arm64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ws16-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a build-armhf-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-amd64-dom0pvh-xl-amd 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 1 build-check(1) blocked n/a test-amd64-amd64-dom0pvh-xl-intel 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvshim 1 build-check(1) blocked n/a test-amd64-amd64-pair 1 build-check(1) blocked n/a test-amd64-amd64-pygrub 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvhv2-intel 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-freebsd11-amd64 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-freebsd12-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvhv2-amd 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-nested-amd 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-nested-intel 1 build-check(1) blocked n/a test-amd64-amd64-xl-multivcpu 1 build-check(1) blocked n/a test-amd64-amd64-xl 1 build-check(1) blocked n/a test-amd64-amd64-xl-credit1 1 build-check(1) blocked n/a test-amd64-amd64-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-arndale 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-intel 1 build-check(1) blocked n/a test-amd64-i386-xl 1 build-check(1) blocked n/a test-amd64-i386-xl-pvshim 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a version targeted for testing: qemuu aa96ab7c9df59c615ca82b49c9062819e0a1c287 baseline version: qemuu 0ab12aa32462817f0a53fa6f6ce4baf664ef1713 Last test of basis 175623 2023-01-07 23:09:00 Z 3 days Failing since 175627 2023-01-08 14:40:14 Z 2 days 15 attempts Testing same since 175654 2023-01-09 18:08:58 Z 1 days 10 attempts ------------------------------------------------------------ People who touched revisions under test: Ard Biesheuvel Bernhard Beschow Christian Borntraeger Cindy Lu Dongli Zhang Eugenio Pérez Greg Kurz Guoyi Tu Hyman Huang(黄勇) Igor Mammedov Jason Wang Jonathan Cameron Kai Huang Laszlo Ersek Lei Xiang leixiang Liuxiangdong Longpeng Lubomir Rintel Marc-André Lureau Markus Armbruster Michael S. Tsirkin Nikita Ivanov Paolo Bonzini Peter Maydell Philippe Mathieu-Daudé Richard Henderson Thomas Huth Yanan Wang Yicong Yang Zeng Chi jobs: build-amd64-xsm fail build-arm64-xsm fail build-i386-xsm fail build-amd64 fail build-arm64 fail build-armhf fail build-i386 fail build-amd64-libvirt blocked build-arm64-libvirt blocked build-armhf-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-arm64-pvops fail build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl blocked test-amd64-coresched-amd64-xl blocked test-arm64-arm64-xl blocked test-armhf-armhf-xl blocked test-amd64-i386-xl blocked test-amd64-coresched-i386-xl blocked test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm blocked test-amd64-i386-xl-qemuu-debianhvm-i386-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm blocked test-arm64-arm64-xl-xsm blocked test-amd64-i386-xl-xsm blocked test-amd64-amd64-qemuu-nested-amd blocked test-amd64-amd64-xl-pvhv2-amd blocked test-amd64-i386-qemuu-rhel6hvm-amd blocked test-amd64-amd64-dom0pvh-xl-amd blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64 blocked test-amd64-i386-xl-qemuu-debianhvm-amd64 blocked test-amd64-i386-freebsd10-amd64 blocked test-amd64-amd64-qemuu-freebsd11-amd64 blocked test-amd64-amd64-qemuu-freebsd12-amd64 blocked test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked test-amd64-amd64-xl-qemuu-win7-amd64 blocked test-amd64-i386-xl-qemuu-win7-amd64 blocked test-amd64-amd64-xl-qemuu-ws16-amd64 blocked test-amd64-i386-xl-qemuu-ws16-amd64 blocked test-armhf-armhf-xl-arndale blocked test-amd64-amd64-xl-credit1 blocked test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 blocked test-amd64-amd64-xl-credit2 blocked test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 blocked test-armhf-armhf-xl-cubietruck blocked test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict blocked test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict blocked test-amd64-i386-freebsd10-i386 blocked test-amd64-amd64-qemuu-nested-intel blocked test-amd64-amd64-xl-pvhv2-intel blocked test-amd64-i386-qemuu-rhel6hvm-intel blocked test-amd64-amd64-dom0pvh-xl-intel blocked test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu blocked test-armhf-armhf-xl-multivcpu blocked test-amd64-amd64-pair blocked test-amd64-i386-pair blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim blocked test-amd64-i386-xl-pvshim blocked test-amd64-amd64-pygrub blocked test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds blocked test-armhf-armhf-xl-rtds blocked test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow blocked test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow blocked test-amd64-amd64-xl-shadow blocked test-amd64-i386-xl-shadow blocked test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd blocked test-amd64-i386-xl-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2556 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Jan 11 13:52:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 13:52:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475332.736997 (Exim 4.92) (envelope-from ) id 1pFbXH-0004RR-RI; Wed, 11 Jan 2023 13:52:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475332.736997; Wed, 11 Jan 2023 13:52:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFbXH-0004RJ-Nm; Wed, 11 Jan 2023 13:52:59 +0000 Received: by outflank-mailman (input) for mailman id 475332; Wed, 11 Jan 2023 13:52:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFbXG-0004QI-Lp for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 13:52:58 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2084.outbound.protection.outlook.com [40.107.13.84]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3fde7629-91b7-11ed-b8d0-410ff93cb8f0; Wed, 11 Jan 2023 14:52:55 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8551.eurprd04.prod.outlook.com (2603:10a6:10:2d6::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Wed, 11 Jan 2023 13:52:54 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Wed, 11 Jan 2023 13:52:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3fde7629-91b7-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Xs5ktteQeAbjbF3OaY6w1lsapMxtJ+FEdx2EF+KXaa6Hg8XKaz4GOvsnsyPutwzKL8aBDDw44EXosht5S/FQ+QhYD4utSdOypESW8XhogJpvymhla8IqWakzLsoJJk9aGJ04BPGwkBtdgoncLruUdf2KbkfESdvI6xGg1PmAQSAlWPCqrYORBbG9DVtqovdIRMk1/RdlQcvkBmXTEp1E0/QAwqU7lxGhKXUmRl+qgWVd91lnWc/a6+FjNTo/de8A1txd5uPhv3cJuBESO0nxsxQ2s5Rtzv7jVAiZpHUrLT5bNZ2+zxkzYRnpl88U/YrSV9HLXGXgEDAouBWYyOG3Bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rQVzcV/aXrmtFWKLwSeA0Wp+ghnodUCv9vHrPOZHrwE=; b=HczbtIbvSt7k/ToZ2QyGMzLYTX9L5rNUgcvNfo5aRLIBiXrVya3bu6RTir5TLbcl9FSmIhfursO2Flk5MJLqd3U2cb2NwEER4+rM9t+PvMgv/zzTLkJc8vZ0P2sJ1usGsVjGOde5El+njYW4JvXkEsFL0E0U908xNJXZigyYFi9Fb5va4jhC+n2LyDD2RNHnFDGQKn3EYwDjfvDJkSVumavXa+exn3r9DBkbcGCYggSxRjooUjUdiOvkD/EzF/kIESR6eb5UnccqyPMjRisjLXCyZIHXbJ1GqgIPQriTKbEMpUgiEVVR/e1NE6/mPqeLiKl4OAXzXNGnT0OILwL7Zw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rQVzcV/aXrmtFWKLwSeA0Wp+ghnodUCv9vHrPOZHrwE=; b=uuLYYp2LtOXjuTjT8YtjEvA90DwT0rzNHs1DifEbBz+1TlOpIeHmxxoelpKhRWFbZUbdEUbCDrU5+CwkPh8Rm6FFcBtp1UsGk/IIv3/khk6nC7kz7oFlB+LUoqmcOlYnS6mFfWRm1sC+9pB81XW3dM82Kw9Hi5LUOSE0pABS8MNgcpyxsigTlOqyNBRkdGpN8M05Uj8nLw2v29JWFz9pwMMqCn2x2DUfAnlXB8TLA1s2w5pzo+cbKc4GNk0dT8E4mWDOwe6SwjP/PDipBbDLEKPIdMBT4uZbmrUAbBuM4f+oPz8zZZ7ohuW78AZU5khiQnxWW5B3JI+cJziZ7/6Gqg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <17d7ca95-4c94-93e3-9a42-cc95512a66cc@suse.com> Date: Wed, 11 Jan 2023 14:52:53 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: [PATCH v2 2/9] x86/shadow: drop hash_vcpu_foreach() Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Tim Deegan , George Dunlap References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0064.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8551:EE_ X-MS-Office365-Filtering-Correlation-Id: d6b15711-5617-4149-eee7-08daf3db2365 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: //0zVOYkBlk+vQJ/HfhyC1nKEJ73BQcACHluRZQHwt1COJ1q0xHggOfsLK1du3af0W586iGfWutDDVxt/dJhPlg3nZPHpys3cR7DpoD4wjwQQBqN6fCreliMMlY3OmagV0nibsPrGP8EYEibCDNHG1+3BcRxvgLiYHACzXYWbsG/qNEDefVQxeu0FzX/98T3OkaJ6xwxtXC5zx9M8P/TkYv2Vpr42fVhziSHviHt3N3kvUK0q5Nu0XNJP3lOTkdQZswYf1Gqunj+xIbkR0iqTIlPKeTPC8h25xA0SJEltAEdHzu4jcXmB6s6h8ez2RG3lDnbrQTFe3rqMuoUKJFwlSqzoZB4h99FNIzvU7PvG3Wm4Puiu3svE7nUTNhxEsGEajhevxaGZM9cL7d9YWCl1bSvYROkrZk+0Xe+PpW+ApDQ4QcKUeTX8ddvvESG+sBp3OzI9sMW8aKPRhv+oEbEFaDlzyCwKX0mdfi4/MytrB3KKEq+VfsLWhly6PqabYM4uXcY33rsoNN+vtpbd5YQ2KaaZUpciHt4Q91431y9QbkyYWQhdgl3+b4IrsN7UrR5uI6pmcbSiTe4Yj9POB6YL0cu7vKRvgD5VFYwPQZ2S3mv/vTRahc1NRsGiYtekAm22W2XTlrx0XsU/FTcIFd+/uOIv1iux/VXBA1//PUlijP5DLi7hHORhDG2MlofUwpgxAlBa03qfbW2Qje/KZ4p9RRtTirloIYOol5/1YL68DsWV5M7HNzEtSN+4E7xL3STdMSkfzd5ekK1uXaI+XCLAavq0+aSE4OVUYNE9Q6FiPBwoIfwzLDwmidvv/MMOmhS X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(39860400002)(366004)(376002)(136003)(396003)(451199015)(8936002)(2906002)(5660300002)(41300700001)(316002)(4326008)(66556008)(8676002)(6916009)(66476007)(66946007)(54906003)(26005)(6512007)(38100700002)(2616005)(31686004)(86362001)(186003)(31696002)(83380400001)(36756003)(6506007)(478600001)(6486002)(43740500002)(45980500001)(414714003)(473944003)(357404004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b3YrVXZZNzRXbnV2eDRYY1FmTy9CSjh4UDVPK0lvbzRKWHlLSXozZ0RhMjBp?= =?utf-8?B?ejE3UWJhQXp1VEVmOXU2dmFhQmZSSnZMdFlrclYrK1JyVzhBckd2UVAvc2FS?= =?utf-8?B?cG9Mc1ExNlNJZm4zWjBtdmtuTzFPZXI2MzdmdEpZUjN1dGJpVHQxZXZOTHow?= =?utf-8?B?QXdnTlcyZlAwZS9FQXZYS0U3SHdpem9wRFlkd2RkUzJ4OGFydWtUSmR4UEM3?= =?utf-8?B?SXRVZkZEaXl0NlUxczhoTUVNWGtiWlpHVzN2S25VWkROcmZWZUJiQW9FYnBV?= =?utf-8?B?bXRzRmxpMEU4OWxVUHg2M2JaakpGSFkvMmNCSnprUEVnVWc2bjNGV3ZVOFNN?= =?utf-8?B?TUZTOFJDeG8rdzdteEQyeXQ4SE45QmNuRkViRUQ1SytoOEV3M283SFpUemFV?= =?utf-8?B?TlRPQnJMYlNKd3NUcStSbEJHYVkvK3dwaGpEa21nUjA5ZzM5M0pvSU5QZGpY?= =?utf-8?B?OVBhRGJYMUUyVHpVWEJUbmROdEtQWlorRjBLZ2FjN2Q1Ykhxc0VLVVoxU1o4?= =?utf-8?B?ZlcyNFNqazJhWFdjSFRwWU5wb1VxM0ZteHJtRnQ3bkVVb3BJTjZTU2pXcE1Q?= =?utf-8?B?RTdhazVvVlU4bWt0TFZmR25ZaHBOZWtRbFlSVHlmNEN0SDZ4L05DWGdmNTAw?= =?utf-8?B?anpTR1ZOaW1rdFpqbk9LQW93WFBxb0tDSEZobThkNGpRLzIveFY1VEZ2aGNP?= =?utf-8?B?MGtENkxDRFRtZnNUKzZGU0Y4TWtkTWhpOXdOVXRuNjdoNHdZcHpGNUtvSzhG?= =?utf-8?B?NkFmSEIzVHYwaTlISyt4YXJrTEttOHdCRTZPOG9kRDd1dzdpTjJmUVljNmlt?= =?utf-8?B?SXJ5ajFxQkhXOGhvbElMQmdPYTBQK1ZnUnp1N1FjL25WY1dtOEorbmh2ZDNJ?= =?utf-8?B?V2QvRnpVRUI2N3R5UmVtNnhUY20zbFBmZHB4SmltVnRSZm8zSy9aWGVXYW8v?= =?utf-8?B?dnlzcXM3QnVFeGE5bjh1TjdkZlRVL0lFWUVTRkpaVkZ1eVZQNW5ja0tSOGdo?= =?utf-8?B?aHRsQnJHMStSSThEMG9aUHVoTWIyVzdmYWRGYUFpV2lJNlc5Z3h0SDZ5RWl6?= =?utf-8?B?Y09VRDJqVUdpdkFmcE5COS9PY3o4cmtWU3ByalI0WmFIZEcrMUtkNDZFczgy?= =?utf-8?B?QW5ZMXovdHRXSDBPY2tXNnVkNEVCK2VWSG94cC9iYlVhd1QxdTZsZmJXcVpz?= =?utf-8?B?a1k4V29zaG1DUDVYRWhKbDJxYmN4R1pSbThnWjYrcWhqeXNTTytRTVFmOWVC?= =?utf-8?B?elFkV2c4RkU1YzlLUFZJRzFpRmhNNTRBYjhya1NCV051R3Y0VEtwQnQwSFUv?= =?utf-8?B?ekFyWWRtSWFyeEc0Qm8yZGtFeDRiMnRNOWxrZXduNjdFN2ZabGZoaHJNTWFl?= =?utf-8?B?SHFYQW1oNjQyNXFzdzVuTGl2aTdsOHc5NU1sTTBsSy82eFYveHFaaVZramhC?= =?utf-8?B?VW5aYmlqZVRsUzV3UE9XYkVOb05BMm1zVlc1T1YvenF5S2dvWldJNGdwTXJl?= =?utf-8?B?OTBDZGRrSTUveDhEZm1BaWtRcktyaTM5ZFBkZVBNVm5JN21RdHBxQlZEQ1B2?= =?utf-8?B?RlowRlF6YUdkZFNhZWJ6c3BWUkdIeUQvN2V0eG5USVAyZjVlN0VvcmRJL0VL?= =?utf-8?B?dVRrWlZYcGtFVElwZnVoV3RhU2dkM1lFUndYTVhKRHVTZXNObjFycVhFVERM?= =?utf-8?B?TlRBTUkvK2F2YlNxcHRvZEd4QTdhUERjQVMzOFROVU4yZG5TV29ZSHBBY1hm?= =?utf-8?B?NTdIeHpJUmVSaUI4dFhiRzRrR3pKSzBWZEkwUEZXdDBmTEtLTWVicmwxRzI2?= =?utf-8?B?RUN5cUNZcEpqTGp2UDQ0Z2lNcS9pUTFaK3BxaDhkaFFsSklsUW1BUExLU3Bq?= =?utf-8?B?eHhPYVpwVld3YUhrdnRaTmU0V0JiZDRVQm8vRjduSjRjQWFleUNGNDQyVllz?= =?utf-8?B?RW1NanIwOFQxSUlOWmI4SENLMWU0R0FaQjZlVlpnZGI2ZG5Pcm5zekUwZExa?= =?utf-8?B?Yk83Y20zV1BHb1NwQ25Ha1ROdEVGcERnODFnZWZBcld3dlpSS04ycDFxRWlM?= =?utf-8?B?WmdPUjJYZ1paWnh1bTJhZFN1dlExV1BPNnB2Q1BFVExJZ0JMeDBud2lLb1or?= =?utf-8?Q?MfeOd0ctzwRdkbVgvuafHukvB?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d6b15711-5617-4149-eee7-08daf3db2365 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2023 13:52:54.5335 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MS4y41vVZFF7t+NIy7x67Bf84MUqL61ubBx1bn82Z+aeb1Av2lyXupvPjeLD7C/kV6tyqgUnrbHL7/F55l8tPQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8551 The domain based variant is easily usable by shadow_audit_tables(); all that's needed is conversion of the callback functions. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper --- a/xen/arch/x86/mm/shadow/common.c +++ b/xen/arch/x86/mm/shadow/common.c @@ -1640,59 +1640,11 @@ bool shadow_hash_delete(struct domain *d return true; } -typedef int (*hash_vcpu_callback_t)(struct vcpu *v, mfn_t smfn, mfn_t other_mfn); typedef int (*hash_domain_callback_t)(struct domain *d, mfn_t smfn, mfn_t other_mfn); #define HASH_CALLBACKS_CHECK(mask) \ BUILD_BUG_ON((mask) > (1U << ARRAY_SIZE(callbacks)) - 1) -static void hash_vcpu_foreach(struct vcpu *v, unsigned int callback_mask, - const hash_vcpu_callback_t callbacks[], - mfn_t callback_mfn) -/* Walk the hash table looking at the types of the entries and - * calling the appropriate callback function for each entry. - * The mask determines which shadow types we call back for, and the array - * of callbacks tells us which function to call. - * Any callback may return non-zero to let us skip the rest of the scan. - * - * WARNING: Callbacks MUST NOT add or remove hash entries unless they - * then return non-zero to terminate the scan. */ -{ - int i, done = 0; - struct domain *d = v->domain; - struct page_info *x; - - ASSERT(paging_locked_by_me(d)); - - /* Can be called via p2m code &c after shadow teardown. */ - if ( unlikely(!d->arch.paging.shadow.hash_table) ) - return; - - /* Say we're here, to stop hash-lookups reordering the chains */ - ASSERT(d->arch.paging.shadow.hash_walking == 0); - d->arch.paging.shadow.hash_walking = 1; - - for ( i = 0; i < SHADOW_HASH_BUCKETS; i++ ) - { - /* WARNING: This is not safe against changes to the hash table. - * The callback *must* return non-zero if it has inserted or - * deleted anything from the hash (lookups are OK, though). */ - for ( x = d->arch.paging.shadow.hash_table[i]; x; x = next_shadow(x) ) - { - if ( callback_mask & (1 << x->u.sh.type) ) - { - ASSERT(x->u.sh.type <= SH_type_max_shadow); - ASSERT(callbacks[x->u.sh.type] != NULL); - done = callbacks[x->u.sh.type](v, page_to_mfn(x), - callback_mfn); - if ( done ) break; - } - } - if ( done ) break; - } - d->arch.paging.shadow.hash_walking = 0; -} - static void hash_domain_foreach(struct domain *d, unsigned int callback_mask, const hash_domain_callback_t callbacks[], @@ -3211,7 +3163,7 @@ int shadow_domctl(struct domain *d, void shadow_audit_tables(struct vcpu *v) { /* Dispatch table for getting per-type functions */ - static const hash_vcpu_callback_t callbacks[SH_type_unused] = { + static const hash_domain_callback_t callbacks[SH_type_unused] = { #if SHADOW_AUDIT & (SHADOW_AUDIT_ENTRIES | SHADOW_AUDIT_ENTRIES_FULL) # ifdef CONFIG_HVM [SH_type_l1_32_shadow] = SHADOW_INTERNAL_NAME(sh_audit_l1_table, 2), @@ -3258,7 +3210,7 @@ void shadow_audit_tables(struct vcpu *v) HASH_CALLBACKS_CHECK(SHADOW_AUDIT & (SHADOW_AUDIT_ENTRIES | SHADOW_AUDIT_ENTRIES_FULL) ? SHF_page_type_mask : 0); - hash_vcpu_foreach(v, mask, callbacks, INVALID_MFN); + hash_domain_foreach(v->domain, mask, callbacks, INVALID_MFN); } #ifdef CONFIG_PV --- a/xen/arch/x86/mm/shadow/multi.c +++ b/xen/arch/x86/mm/shadow/multi.c @@ -326,32 +326,32 @@ static void sh_audit_gw(struct vcpu *v, if ( mfn_valid(gw->l4mfn) && mfn_valid((smfn = get_shadow_status(d, gw->l4mfn, SH_type_l4_shadow))) ) - (void) sh_audit_l4_table(v, smfn, INVALID_MFN); + sh_audit_l4_table(d, smfn, INVALID_MFN); if ( mfn_valid(gw->l3mfn) && mfn_valid((smfn = get_shadow_status(d, gw->l3mfn, SH_type_l3_shadow))) ) - (void) sh_audit_l3_table(v, smfn, INVALID_MFN); + sh_audit_l3_table(d, smfn, INVALID_MFN); #endif /* PAE or 64... */ if ( mfn_valid(gw->l2mfn) ) { if ( mfn_valid((smfn = get_shadow_status(d, gw->l2mfn, SH_type_l2_shadow))) ) - (void) sh_audit_l2_table(v, smfn, INVALID_MFN); + sh_audit_l2_table(d, smfn, INVALID_MFN); #if GUEST_PAGING_LEVELS >= 4 /* 32-bit PV only */ if ( mfn_valid((smfn = get_shadow_status(d, gw->l2mfn, SH_type_l2h_shadow))) ) - (void) sh_audit_l2_table(v, smfn, INVALID_MFN); + sh_audit_l2_table(d, smfn, INVALID_MFN); #endif } if ( mfn_valid(gw->l1mfn) && mfn_valid((smfn = get_shadow_status(d, gw->l1mfn, SH_type_l1_shadow))) ) - (void) sh_audit_l1_table(v, smfn, INVALID_MFN); + sh_audit_l1_table(d, smfn, INVALID_MFN); else if ( (guest_l2e_get_flags(gw->l2e) & _PAGE_PRESENT) && (guest_l2e_get_flags(gw->l2e) & _PAGE_PSE) && mfn_valid( (smfn = get_fl1_shadow_status(d, guest_l2e_get_gfn(gw->l2e)))) ) - (void) sh_audit_fl1_table(v, smfn, INVALID_MFN); + sh_audit_fl1_table(d, smfn, INVALID_MFN); #endif /* SHADOW_AUDIT & SHADOW_AUDIT_ENTRIES */ } @@ -3950,9 +3950,8 @@ static const char *sh_audit_flags(const return NULL; } -int cf_check sh_audit_l1_table(struct vcpu *v, mfn_t sl1mfn, mfn_t x) +int cf_check sh_audit_l1_table(struct domain *d, mfn_t sl1mfn, mfn_t x) { - struct domain *d = v->domain; guest_l1e_t *gl1e, *gp; shadow_l1e_t *sl1e; mfn_t mfn, gmfn, gl1mfn; @@ -4019,7 +4018,7 @@ int cf_check sh_audit_l1_table(struct vc return done; } -int cf_check sh_audit_fl1_table(struct vcpu *v, mfn_t sl1mfn, mfn_t x) +int cf_check sh_audit_fl1_table(struct domain *d, mfn_t sl1mfn, mfn_t x) { guest_l1e_t *gl1e, e; shadow_l1e_t *sl1e; @@ -4045,9 +4044,8 @@ int cf_check sh_audit_fl1_table(struct v return 0; } -int cf_check sh_audit_l2_table(struct vcpu *v, mfn_t sl2mfn, mfn_t x) +int cf_check sh_audit_l2_table(struct domain *d, mfn_t sl2mfn, mfn_t x) { - struct domain *d = v->domain; guest_l2e_t *gl2e, *gp; shadow_l2e_t *sl2e; mfn_t mfn, gmfn, gl2mfn; @@ -4097,9 +4095,8 @@ int cf_check sh_audit_l2_table(struct vc } #if GUEST_PAGING_LEVELS >= 4 -int cf_check sh_audit_l3_table(struct vcpu *v, mfn_t sl3mfn, mfn_t x) +int cf_check sh_audit_l3_table(struct domain *d, mfn_t sl3mfn, mfn_t x) { - struct domain *d = v->domain; guest_l3e_t *gl3e, *gp; shadow_l3e_t *sl3e; mfn_t mfn, gmfn, gl3mfn; @@ -4145,9 +4142,8 @@ int cf_check sh_audit_l3_table(struct vc return 0; } -int cf_check sh_audit_l4_table(struct vcpu *v, mfn_t sl4mfn, mfn_t x) +int cf_check sh_audit_l4_table(struct domain *d, mfn_t sl4mfn, mfn_t x) { - struct domain *d = v->domain; guest_l4e_t *gl4e, *gp; shadow_l4e_t *sl4e; mfn_t mfn, gmfn, gl4mfn; --- a/xen/arch/x86/mm/shadow/multi.h +++ b/xen/arch/x86/mm/shadow/multi.h @@ -83,19 +83,19 @@ SHADOW_INTERNAL_NAME(sh_remove_l3_shadow #if SHADOW_AUDIT & SHADOW_AUDIT_ENTRIES int cf_check SHADOW_INTERNAL_NAME(sh_audit_l1_table, GUEST_LEVELS) - (struct vcpu *v, mfn_t sl1mfn, mfn_t x); + (struct domain *d, mfn_t sl1mfn, mfn_t x); int cf_check SHADOW_INTERNAL_NAME(sh_audit_fl1_table, GUEST_LEVELS) - (struct vcpu *v, mfn_t sl1mfn, mfn_t x); + (struct domain *d, mfn_t sl1mfn, mfn_t x); int cf_check SHADOW_INTERNAL_NAME(sh_audit_l2_table, GUEST_LEVELS) - (struct vcpu *v, mfn_t sl2mfn, mfn_t x); + (struct domain *d, mfn_t sl2mfn, mfn_t x); int cf_check SHADOW_INTERNAL_NAME(sh_audit_l3_table, GUEST_LEVELS) - (struct vcpu *v, mfn_t sl3mfn, mfn_t x); + (struct domain *d, mfn_t sl3mfn, mfn_t x); int cf_check SHADOW_INTERNAL_NAME(sh_audit_l4_table, GUEST_LEVELS) - (struct vcpu *v, mfn_t sl4mfn, mfn_t x); + (struct domain *d, mfn_t sl4mfn, mfn_t x); #endif extern const struct paging_mode From xen-devel-bounces@lists.xenproject.org Wed Jan 11 13:53:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 13:53:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475344.737008 (Exim 4.92) (envelope-from ) id 1pFbXr-0005IV-6M; Wed, 11 Jan 2023 13:53:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475344.737008; Wed, 11 Jan 2023 13:53:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFbXr-0005II-2H; Wed, 11 Jan 2023 13:53:35 +0000 Received: by outflank-mailman (input) for mailman id 475344; Wed, 11 Jan 2023 13:53:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFbXp-00047w-ET for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 13:53:33 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2048.outbound.protection.outlook.com [40.107.13.48]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 55891915-91b7-11ed-91b6-6bf2151ebd3b; Wed, 11 Jan 2023 14:53:32 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8551.eurprd04.prod.outlook.com (2603:10a6:10:2d6::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Wed, 11 Jan 2023 13:53:30 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Wed, 11 Jan 2023 13:53:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 55891915-91b7-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=URIUJvBUnhD4gku6qib2sVtrZYoKIBmoNUghFiwwgyeCoScB/mUwsrbzK8K5W4tyzqxwCr7zhRYfIpyZ8wMjLAjydK0/g42FepxwPItjpLnwUxtlHE5B8zWKCQSe1rl+StcCTQ2ryrmWj4K1nibMoXRGtdXpcRhlFYWvjSntKPo0gr/iFVEjLXj6o0XCP2NYW7o1YF+LhZ3DIc7wdbvBHCtMygtMAUo0bLZB9kmYbhCrLqpW65Tjigt6uQny5XOLok3DNLR3aCscbI8T/ylM5XWRxjMwbuotsWwjcR9Mqs41iCKajdhRCaelFc96sKMnDHZjTqa89u+iEyh6y332zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zfV7FH4PlbLPIPiG+PzMORtLnBIDSYzDeJCNwEUQtis=; b=Ow+4oszuWC7+szzZOqmusakF1TkHARoostoEZWy7tldhwsEl6s3oM/wYm8fxzaUljzfMcDTC3MsJuoFlmbvzWUeRpmfdB/k+w51kAf4CsAWCi7WkjYzpMPAImpqx8hNwm9Qr5odM7Y5vv7TGUVqeeY/ULR/wKW5aN8god6ck7GQv46oeqzlVP+QUbooE1XVIhAbkm4GsJMbcnoUABlJtUGzxP+oXcBS6La2nlT3DMbrX6oFQuM4OynXvqO5t9az6MlVcL6yX0NXI1CVBNn0+5VGB7C41FNcBaUvP40rMlz+C2YSQebaW3saoDDuVZ2FQ/xJzDUokzqlqNIW551Dgag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zfV7FH4PlbLPIPiG+PzMORtLnBIDSYzDeJCNwEUQtis=; b=bIS/MneUtTtRjQmNLzGJJdMBFWtz09BScvbX22KDROsyUmACdCZLYqsDabtUbLqaXt1rZlVpwtbXq0OK5TOzEyHLI0dfwpngM6eMsWqQQeAyk0YgGIniXBikGDzPDr7UfTFPdLml9TovrdhahCyBhx3IC+NZMhBNErmIg/GXxux1axKJJYJFd1EP3IreZc+CWZ1SauoCHQ/RiWl7VORU/JyQAzH0cEQVdoFV6ZvXhNO6lrJP5vEp3JX71aRPxiHcP5Q+zHpjs005pyMK3uOLfYnkOgiPcLpmDExMsIBZ/VL3L/zffCyt+fURzlqkIfsxoW2Ripa7FmJqw3p4BvKC4g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 11 Jan 2023 14:53:29 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: [PATCH v2 3/9] x86/shadow: rename hash_domain_foreach() Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Tim Deegan , George Dunlap References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0181.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9f::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8551:EE_ X-MS-Office365-Filtering-Correlation-Id: c4b00fea-09ab-4c99-1dbb-08daf3db38fc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yBVUELvVhxkKF3Wuker5LK7J1dyVEsyW9Q4c9eq63mJ2ZH1TnGw4BFsN1AVle+6wVMvk7SGA19QkRtSD2Sv0//rRMDp7P5BAirODYFkmyebvRJ/kbuRTkU9OXNhog7Bbmm3EC3oMjPRvL8I0J/shA2AcOoSt5HLdqY55x2IZTMlX/Bll6TBCEg+6WyWx7VHs5dR9HBDWLRQtviiUYoXYmXqxGVLhZrYC6Ex7x8gTYEXcWUh/7iI+s+LIkARol2eDFvrMZr0dkSEMUtLqMFoSiq4W4rKwm3tQaTxyi649bQOQO1WiAkKhPisQxCsTLCcfgWb8hiwC0H1s/MaRZkMWvAhOPuU7Xg0wCbs8wi7HiIpbWSEy9TAteJzhDcRz3G1cgjMounCr5GEW5Z3RajbpA8bIHRSJvPmI13QorIopYNiOii0oDSkInNAZ1B3OAnPpyGbTW0BBTcweogFkkhQv8x16Gu2sHVXWkCju70XkvdRKcxVEoiP6XOok876JTkwiPt7OESPuQUCb3LJ0ewXDvrBU8a+EFQveFIfwbIB3Fo9coxUeupWWYdhv3qWYOuax6xmrzk8TLPWymSZex0S/APoN9nGBrTPz54J8wjtPu+zeT6nwKrVrk7KODxnwk0zPeVW8aXEr7VNWL3FDiQedMJdmpU2zcvSMVHsLhvlqpNWxBF9rGJf/onHqtLlpFG5FW6W9m7kax+tyKjMuF2O6DB5ythyxloNmrkn1Esr9cbs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(39860400002)(366004)(376002)(136003)(396003)(451199015)(8936002)(2906002)(5660300002)(41300700001)(316002)(4326008)(66556008)(8676002)(6916009)(66476007)(66946007)(54906003)(26005)(6512007)(38100700002)(2616005)(31686004)(86362001)(186003)(31696002)(83380400001)(36756003)(6506007)(478600001)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R3VoZzNrWG5tdjA1Y0t5eFhVeXJ0bU1qeVJuZll5L1VJV083QTFsN3RMcVFv?= =?utf-8?B?OUY3TVdtQnhESE9teGpJSVBNczJSRnB1RXFQUTdKa1dPemxqY3FoRlRkUkh4?= =?utf-8?B?VDBUWC9QV3N0WGNFT1FNMXQzRlgxZXI2UG5TVS9LbG9VS3lJS2lJQmRxOE4v?= =?utf-8?B?RFdSTXpEa3FGMGhJTm5ycVZUcGdDZnZDak9zK2NmM3g5NUY5KzRsUVREbjF0?= =?utf-8?B?Q2R6Z0krZ0s5RUY0WjZtQXdScnFKSHRyK3pMTWc3eFozRnFVYWtKNTIzR09h?= =?utf-8?B?T1hJRjE5Z0p4bmp1WWxwWWxVaGtrODJhTG9BajNReitmNlVZQlRLblNlNkdG?= =?utf-8?B?NGM2eFZqNHVmQldUTnExMWVxbTUyK0d6Q3JSRzBYS2tOaXAvR1ZMQkdYUUtj?= =?utf-8?B?Uld6QTJNYjUyUnVvdWtOekF1NGFGaTY4MGpmMVVETzVlaS9ZRGNBTmlZN3Fh?= =?utf-8?B?bFpTTHBGaktYT09FWURCandRblBkdWJrOVpyNzdrR2ZLa1Z3em5naXlXNHli?= =?utf-8?B?SHhBOWhjcDViN29SNDEvc2FhdHJjWTlNRFRaa0dFMm1aUFdZZzY4ci9zb0t5?= =?utf-8?B?MHNicnVkenE5em53N0xrZFZaWUJaY3MxSytDOWlxT1lkcE55cmpQa20yVEFx?= =?utf-8?B?SjY0dGJxaG9iZUZlcW9ZODZ6NDVGTmh5cktxdkpzOFV3bjJEdTVKcXFxdmxN?= =?utf-8?B?WkpoSnhWVVAvZDlDdW1VWk01WGJLNzNKN2N1OFlMREprR1BsdGZKZlprNDQ5?= =?utf-8?B?SEVoeUtOelVHN3pXSFJvdUdtOEFFMm8wdUpRbDE3QU9NajdsRkFBSStEMVhJ?= =?utf-8?B?Vk0zUnhTYzErZGpWc2t0NXlRaEdkdkZXNGFlSU0zaUkwZENkQ0Znd0FNWDk4?= =?utf-8?B?OWlucC95bFIvdDVPOVFqcjNsb2ZzU0NyUTFCMGtNSUdZZnN1VENIYjFiV2hY?= =?utf-8?B?TVhpc1BQMnM4ZEJpSzQxdzY5RldRT01xZ2Y0cWg1R3Zsdi9RalBOREswR3RU?= =?utf-8?B?NE9FcWtRT2dYTVRCNDUvb3BEZDd4aW1kQ0tIZFBuN1Q2a09VejJxTmFEUEFj?= =?utf-8?B?a29obFp0NXJDZkhHV2Y5RFBoc01qNDNtc0tMcWw5Mlg5b2Q0WDNmOGVHdjNz?= =?utf-8?B?MHR1eVBhN0tRUDBOS3EzTkxidnN5cHpUQTJXelg4M0wwMUZLVzViZWZaVWl6?= =?utf-8?B?d3JCRnRBNFBWZVN6TkFESUNQVzNGMlFIV1FPQ0JFOS82dVBialVpMHBVYVJY?= =?utf-8?B?bExBUUpoNkYrc1kyZE5YdWFEc0Z1R3Rzb29RdExvdDBnLzZCMXBtaXBWWGpQ?= =?utf-8?B?Ui9PSjgwQXZtdHRHdG1jM1ZqYmZobDQzM1hBcGFFbjZSNGdkQ25BSDhxU0t5?= =?utf-8?B?VWtDRXdnSDZBcmttclBQQmJ2K0tvY28yOUxtcVB4M2w0N283eVlxTDNFQ29F?= =?utf-8?B?dDM2bmNpOHNQb3NjNzZGRUZZSTVXMlVzZTBNdW9YN3ZRSnMyVlZ5NUxsbG1X?= =?utf-8?B?OTVFOWVTbXNYZ2hWZG1ZYWMxaEN1ZVVsRnNCZlhZeUdYYVYvNXFBRkoxd3p3?= =?utf-8?B?UXZUYmJ2Sjg4K1hTTHpKcEkwYUFBc3Vwc2xVczEzWXVVSEhOKy9qbFBNVEN5?= =?utf-8?B?bDVoVVlCNVhLS2ZsVnE3cC9IdWhpbzJieWlBc0VCSlJRZFhocU5UOGVybHFX?= =?utf-8?B?Rk90cGFtc21VZHAwSGNxSGpSNG5YNHVQaUF0Z3FieHdTWkVMRmEvdldQc0hs?= =?utf-8?B?UnRvOE9nY0dCdlNNb1Jwa0J3a1hnVktQRDJoWHR1anBXcDFCZllEYVExV0wy?= =?utf-8?B?YWhzcGZ1SkZld2thWEFSQ3p0MGJnWUt3Q3NMTG1vOWxCbHRlYWxFejVjbzJT?= =?utf-8?B?UUpGRlJDTm1KVllZaUV4UHlUdlVsSGlkVm5uUWp3eUFnNTZjbG1hbnhtZjhp?= =?utf-8?B?Y3g5ek5HWkN4WDNtcmNlb0RxaDNuQXl2QktUZW1xY3M2cDYza0ZvcmZPSUZI?= =?utf-8?B?S2pod09MeWVHMWNjeWlZNXpHTWZIdnlxZjdsUE0yaVVxdHY4RmgwUGFVZFZ6?= =?utf-8?B?djEwU3M3SWVKYkRPdkZnNmpWMlRsOGlYR2IwVGMxSG9ZUENXd0NnY0svck9u?= =?utf-8?Q?0jl1o2m0kv+2TpFP5dz5Yx7CQ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c4b00fea-09ab-4c99-1dbb-08daf3db38fc X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2023 13:53:30.6874 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2tjwHUZPplVPns/+4HE8dfFY4HNDs2WIGua3tH8rxVltNrEzsV+Q6b/lnKvCSeZ2tvlqx2kXoT2cSzZs5DH/eQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8551 The "domain" in there has become meaningless; drop it. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper --- a/xen/arch/x86/mm/shadow/common.c +++ b/xen/arch/x86/mm/shadow/common.c @@ -1640,15 +1640,15 @@ bool shadow_hash_delete(struct domain *d return true; } -typedef int (*hash_domain_callback_t)(struct domain *d, mfn_t smfn, mfn_t other_mfn); +typedef int (*hash_callback_t)(struct domain *d, mfn_t smfn, mfn_t other_mfn); #define HASH_CALLBACKS_CHECK(mask) \ BUILD_BUG_ON((mask) > (1U << ARRAY_SIZE(callbacks)) - 1) -static void hash_domain_foreach(struct domain *d, - unsigned int callback_mask, - const hash_domain_callback_t callbacks[], - mfn_t callback_mfn) +static void hash_foreach(struct domain *d, + unsigned int callback_mask, + const hash_callback_t callbacks[], + mfn_t callback_mfn) /* Walk the hash table looking at the types of the entries and * calling the appropriate callback function for each entry. * The mask determines which shadow types we call back for, and the array @@ -1784,7 +1784,7 @@ int sh_remove_write_access(struct domain unsigned long fault_addr) { /* Dispatch table for getting per-type functions */ - static const hash_domain_callback_t callbacks[SH_type_unused] = { + static const hash_callback_t callbacks[SH_type_unused] = { #ifdef CONFIG_HVM [SH_type_l1_32_shadow] = SHADOW_INTERNAL_NAME(sh_rm_write_access_from_l1, 2), [SH_type_fl1_32_shadow] = SHADOW_INTERNAL_NAME(sh_rm_write_access_from_l1, 2), @@ -1969,7 +1969,7 @@ int sh_remove_write_access(struct domain else perfc_incr(shadow_writeable_bf); HASH_CALLBACKS_CHECK(SHF_L1_ANY | SHF_FL1_ANY); - hash_domain_foreach(d, SHF_L1_ANY | SHF_FL1_ANY, callbacks, gmfn); + hash_foreach(d, SHF_L1_ANY | SHF_FL1_ANY, callbacks, gmfn); /* If that didn't catch the mapping, then there's some non-pagetable * mapping -- ioreq page, grant mapping, &c. */ @@ -1997,7 +1997,7 @@ int sh_remove_all_mappings(struct domain struct page_info *page = mfn_to_page(gmfn); /* Dispatch table for getting per-type functions */ - static const hash_domain_callback_t callbacks[SH_type_unused] = { + static const hash_callback_t callbacks[SH_type_unused] = { [SH_type_l1_32_shadow] = SHADOW_INTERNAL_NAME(sh_rm_mappings_from_l1, 2), [SH_type_fl1_32_shadow] = SHADOW_INTERNAL_NAME(sh_rm_mappings_from_l1, 2), [SH_type_l1_pae_shadow] = SHADOW_INTERNAL_NAME(sh_rm_mappings_from_l1, 3), @@ -2021,7 +2021,7 @@ int sh_remove_all_mappings(struct domain /* Brute-force search of all the shadows, by walking the hash */ perfc_incr(shadow_mappings_bf); HASH_CALLBACKS_CHECK(SHF_L1_ANY | SHF_FL1_ANY); - hash_domain_foreach(d, SHF_L1_ANY | SHF_FL1_ANY, callbacks, gmfn); + hash_foreach(d, SHF_L1_ANY | SHF_FL1_ANY, callbacks, gmfn); /* If that didn't catch the mapping, something is very wrong */ if ( !sh_check_page_has_no_refs(page) ) @@ -2128,7 +2128,7 @@ void sh_remove_shadows(struct domain *d, /* Dispatch table for getting per-type functions: each level must * be called with the function to remove a lower-level shadow. */ - static const hash_domain_callback_t callbacks[SH_type_unused] = { + static const hash_callback_t callbacks[SH_type_unused] = { #ifdef CONFIG_HVM [SH_type_l2_32_shadow] = SHADOW_INTERNAL_NAME(sh_remove_l1_shadow, 2), [SH_type_l2_pae_shadow] = SHADOW_INTERNAL_NAME(sh_remove_l1_shadow, 3), @@ -2173,9 +2173,9 @@ void sh_remove_shadows(struct domain *d, /* * Lower-level shadows need to be excised from upper-level shadows. This - * call to hash_domain_foreach() looks dangerous but is in fact OK: each - * call will remove at most one shadow, and terminate immediately when - * it does remove it, so we never walk the hash after doing a deletion. + * call to hash_foreach() looks dangerous but is in fact OK: each call + * will remove at most one shadow, and terminate immediately when it does + * remove it, so we never walk the hash after doing a deletion. */ #define DO_UNSHADOW(_type) do { \ t = (_type); \ @@ -2199,7 +2199,7 @@ void sh_remove_shadows(struct domain *d, (pg->shadow_flags & (1 << t)) ) \ { \ HASH_CALLBACKS_CHECK(SHF_page_type_mask); \ - hash_domain_foreach(d, masks[t], callbacks, smfn); \ + hash_foreach(d, masks[t], callbacks, smfn); \ } \ } while (0) @@ -3163,7 +3163,7 @@ int shadow_domctl(struct domain *d, void shadow_audit_tables(struct vcpu *v) { /* Dispatch table for getting per-type functions */ - static const hash_domain_callback_t callbacks[SH_type_unused] = { + static const hash_callback_t callbacks[SH_type_unused] = { #if SHADOW_AUDIT & (SHADOW_AUDIT_ENTRIES | SHADOW_AUDIT_ENTRIES_FULL) # ifdef CONFIG_HVM [SH_type_l1_32_shadow] = SHADOW_INTERNAL_NAME(sh_audit_l1_table, 2), @@ -3210,7 +3210,7 @@ void shadow_audit_tables(struct vcpu *v) HASH_CALLBACKS_CHECK(SHADOW_AUDIT & (SHADOW_AUDIT_ENTRIES | SHADOW_AUDIT_ENTRIES_FULL) ? SHF_page_type_mask : 0); - hash_domain_foreach(v->domain, mask, callbacks, INVALID_MFN); + hash_foreach(v->domain, mask, callbacks, INVALID_MFN); } #ifdef CONFIG_PV From xen-devel-bounces@lists.xenproject.org Wed Jan 11 13:54:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 13:54:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475351.737019 (Exim 4.92) (envelope-from ) id 1pFbYI-0005tG-H2; Wed, 11 Jan 2023 13:54:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475351.737019; Wed, 11 Jan 2023 13:54:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFbYI-0005t9-E7; Wed, 11 Jan 2023 13:54:02 +0000 Received: by outflank-mailman (input) for mailman id 475351; Wed, 11 Jan 2023 13:54:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFbYG-0004QI-RZ for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 13:54:01 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2051.outbound.protection.outlook.com [40.107.13.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 653476f0-91b7-11ed-b8d0-410ff93cb8f0; Wed, 11 Jan 2023 14:53:58 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8551.eurprd04.prod.outlook.com (2603:10a6:10:2d6::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Wed, 11 Jan 2023 13:53:57 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Wed, 11 Jan 2023 13:53:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 653476f0-91b7-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T0w5MUipcezPpMUOlCjSz2ReCrpCgkG9lPNmv3iD7VmzNEWNdmJLYZtq+XQLEOkOlFXpEI9Hei1gleUCfdjCcgeV+2QtyWyFhdhGlxSOmsE7DIQ/3TTW5rnEadV+sG8sp+ahqRpvmiOoVndK3M6eD4o+YEVMTCFhMLgqbf0OxmRB/q0tZxSJdF9Uo3nDr0wOX7kyGxhmORKbrxYUAYBXrd2m4N8fNgR1MjwAiMn7vSvi1ktJwPldr/z9mDoP8qo29HW7YYADRyPm79vtciKYE2EWuzzFoscOKVXHYsf/7LjoAY60TuENiJdHygt3Dzpc58O2PAmwPnlp0gixrgcJuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I0kOuEOlEby+rFnQkiCiFwCOaJzxSnerJCBJ3RDmWQU=; b=Z6ElVhyAMUi/UwJCJs0O1u01DefWMHCUB6Orz4joRz3nsuR+7CSxK48xhD1mD28p+VrJ+yeTxgQyDIyxoWJhXBAgRT8WXr/MGmqcjMsbFCcebXkS03u8RXwtxpz82tQz46+96qqZNlKeBI5KEILWpcNCymTESy7jLHDAQBcHKQa2+hK2qoL3LRJuiQTVHD161KIm8RcKA7cKo+XuzcGeabWUIXaePO8kwDzhCvBps/d7Qa3aXgReAO79veKISZbe6wFWU85y8B8S6yyDoFeZ7KXDsJH0S87eK5nsbEqcsjc77YYSa+jPdF9R9gF6TlQ5tX0brDIpOxHQ2nRV4+RvEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I0kOuEOlEby+rFnQkiCiFwCOaJzxSnerJCBJ3RDmWQU=; b=D+iPzFj9uOvdTyzl/BAlIXp31Pl3eVfEUU3POWmMLcWWE0UDYEutYc2eyAsDd/peGUk91ys93mLbgvkQsoyJrrP9idcDJT09Tq9f7d0z/mFQA9kBn5R7gM0p8BeWrQ8iJ3KII1rdM3kuyq/S1VNsLQqdK6/OovgD+0EgD883JmubfcbeeZ4+BI3ddE7zWhuRP5xE+BnfnqF65O8cnjnpT3uHscJj3OEz6MXv3+gJR76/CBNiLxapS3mjNQ/dGdUG0kJcH+pDgFNquheRhx44ZLnruPY55/seIrfrf9vIncUTeXycddt2kPj+FVNZkhU8SSpZbHbI7SPO2zzAQCLQCA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 11 Jan 2023 14:53:55 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: [PATCH v2 4/9] x86/shadow: drop a few uses of mfn_valid() Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Tim Deegan , George Dunlap References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0119.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8551:EE_ X-MS-Office365-Filtering-Correlation-Id: ceb18629-2864-4b6a-72c9-08daf3db48e6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HeLBCjs5tZLaz/qQDn4lvkeEN/9Cdqa8kSMhZ4egsF5HzfvJUHan2fT2Qr2uW4F6Dg06aUVRBT0md5Ubu2dE2dbt7XY2M+fgJBuPHjg7S6Zt84zfkma2wQX7kf5dkk9zmjryw2srlxX6OUUvOi3/C4tHIubAfX9Nc7gYEYMrMOIGUroUcHHkzd9Ipqd92wM3PDgQ61tNY981XLpk5nqgJiXJAQQdWCuVs4LdWCZsP9Z+CK1aEmmmFyLUplg7YTkyORoZsgvYBoFiMrD9mS/UVe3zRjsRq76eIbPKKwwgfC0mkGkcsS/eGA3/QugG5SHukS88rL0zU7ZLoQaFnr7Sv4KiWbSpQNnNc3+KvHMcAqaSJ+N4rGxZRpqmWH6ifWlKN2Jr7ZtKa3cIVZmer+p3AlktquNgHDle7PoLt2T4rCuMBhGnFjyMO6YW6aksn55wT6npZ4g+6FbI/5RIwHU7Kw4c7zq0SzPROkvYn5/2rn+wUo7YLzRZMmQ2DAmcgkNVnKjBd2gU96wxDUngSy05ydKGwS0RoqLBomr24MudNBgBLl/FCFrqCQ8V10iaey80GgpULBzDokB1iZ4YBotoH3w/uPv/IVV17aby4cTf4c/8eY2sBcL9+GPS4Y/HSo5bR9wiRvKSIbjH6ueTw9CnyVaJEHIITnpTUPfkd7IiAzufF4VX362Moy1aWdaacuHQFmLFkC+f8EUbW7DnonXvHCL+Prq/Be8TkMdc0RoSQJk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(39860400002)(366004)(376002)(136003)(396003)(451199015)(8936002)(2906002)(5660300002)(41300700001)(316002)(4326008)(66556008)(8676002)(6916009)(66476007)(66946007)(54906003)(26005)(6512007)(38100700002)(2616005)(31686004)(86362001)(186003)(31696002)(36756003)(6506007)(478600001)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dnl2Ykd5ZUliTlh3cU1GbkFuQ2hlcTJDL1JnMUdGVHNtVCs5SG5MS2hrY0gx?= =?utf-8?B?TkR3WWR3SGhNWVFwWDJ4dDBuVVhaOHAvYXR2dTBZQkNCRmQ5cWdmcmlFaFBQ?= =?utf-8?B?bW1uUTROaEhCT3pycGRVWExGN0RTL2NxU2dDaFhlQUZuZ3RUUFE2TVhFNUcz?= =?utf-8?B?OTdRSi8reGIvU09sS2tIcUQxV1R5UTV1aWlkVVNYWXFFODA3em91WTNsckJr?= =?utf-8?B?QWt1UUdXVGppa3kzZ1VzWFM5L0RHcHY2MUlKYURtSlg5aUxzc2dvTEZoa3RJ?= =?utf-8?B?c2ZiL0duZGxuUXFzZkhXd1ArU1hkZGVOL2J0a3pxRTl5V2lBdWNXZDdLZHJt?= =?utf-8?B?QWZhdmR2ZHBMWWJKNks5NEErMkJCcExVZzd3TmsyZ0pHRTBSdENpcExEUTY2?= =?utf-8?B?V1pTd2JxVWlHaWd3U2NtbnBRTkQ2eHl5M0VneHdXMTI3MzFlUFFzN0wyV2I1?= =?utf-8?B?N3N1bkJiaUNXSDkvNDdRbkhBdW1NWjd0SDRkV3ZvUnlRTWFKOXFFUzhBUDRL?= =?utf-8?B?MllOQ2ZRVURlTVpvMWw4YitJZFZLcE9mRmU3OG52VC9FNi90MTF5VzFPcEpt?= =?utf-8?B?cElCQlpOY2kxRi9LeHZXR2pRQkJTTHFKSzNkdUd1S2pZbEpCaUN3dWV5SnlW?= =?utf-8?B?ZDZPalROeGNnYzNQYnBGSFVwQU5uakFWeDl0djgyWTFmUDIvdlptVHRYbER3?= =?utf-8?B?dnI4M1Bld2pYcmx2UXJITzY2SVlIWEVPN2x1NExhVFk1Q2gyMVZHZmF1bUVQ?= =?utf-8?B?Uitwdkx0cmJKT2hzZGJGRFFxVzNQelFvdEpFdFppc3ZVNkpmLy9sdzdWU09F?= =?utf-8?B?d215MHdjRHBneEZtdUowZ2hvRkpuQWVFUFRiYUZaVE1LZHpkYlhqMXRuRVgv?= =?utf-8?B?OWdGTGVHNGRaK3BORWpPcGczbEZia21TTnhGTVhoQWNKTTFXdURWZ1FrQ0Z2?= =?utf-8?B?amxuck0vREEwLzhscEZkZytGYW1sQ1VrWjhSWnAwYUY5VkRGbllWLzFBYVBF?= =?utf-8?B?UnhmL2hWWURvdWQ2ZE5RN2tJRmkyK2VBRmxQSkxRMGhjRXdSWXZTTW5wbStK?= =?utf-8?B?MzlPNUMzYnRLOG85dkxPN1RSeEN2SG9YN1FMNXVvR0dVN0NtTUhlYVdEOHE5?= =?utf-8?B?QU5Oek9IZkZaMEM1MmFLNytaN3pBb0t3ZDVHN3g3ZFZMZisvL3docnFEajdx?= =?utf-8?B?bjVQdEZKcDZZLytPWk1QcWtSRk9wUDlDYlp1SUxVRkF2SnVTS3JYM1R4VEZW?= =?utf-8?B?dkk2NjBaWlVoNGdnaFk2MXB4TWROUVQ4VFpWSmR3N1hEQzZkbWFMKzd3cDl2?= =?utf-8?B?NGdlMzUra1lub1NGNmFTYXZ1KzBqSjFRQThRcHQyMzJWclJPc3NvYmNzeG5y?= =?utf-8?B?eGtlY05Qdk1qblBSTXg3MXBhVHNvQTRsS1dqcjJIU3dYb2tCN1QrTjJYNzN4?= =?utf-8?B?TU1wOS9EanpwNGRoQlhuSm5LQXFOREtGd3VPZHlXT3FwemRvcjJ0NWlrVXpa?= =?utf-8?B?RWY2MmgreXJxYitaV05XdHB2Tmo3YmZadXMyZlcxaXhycHlSWHYraUlNdERC?= =?utf-8?B?SGV0TFpZVXhjU2lnWSs1YldNem9NRWVtL0RiaU5ra3l1WFp5M0JwN2haUW9y?= =?utf-8?B?eUw3eWFzZlY4Q0dSQkkrV1lxMXNWbGtQVmZhMkJHTXlLSXhqRkxyZ2wwUWlQ?= =?utf-8?B?U0RTam11Q00xWHVIMHZpcWlVMktsVUZsMWxhOU9lT3Q0SERKUVhoV2RBS3c5?= =?utf-8?B?ZkFFaE5MVkRKUDRHeUN0cTFGSTFvSFUydi9RWm9DQmpXOVRXa0dOVmxxSG9y?= =?utf-8?B?dDQ5a1FzT2c0V1BUREVsWDRoUzJ4cEpzYklnbFA5QmNCckV3NW5vR0k4cldl?= =?utf-8?B?OGRiUjlHM28yQi9MaGZJaVhldlllL2JPUUYrMnMxaCtLNlExenpnU2EvZmhi?= =?utf-8?B?OUV6QkRHL1ZHS2lNWEpnV3ZSNHBjUDZDNUZtSEJ6a2R3U0YrRCtiSmdqLzJK?= =?utf-8?B?MHhycFNsNTVHWUhlWU1BZStnNjYySlhmNzNnNUpxQmNrME1XaEpXNlAyNnE1?= =?utf-8?B?ZXQ0TGJaa3VPNUMvMDRqbjdCUE1QVU4wZDY3MDZjQU5FQ01pZDlDMDJEbjBr?= =?utf-8?Q?wb8CzMJUXneG6IIDT0sm82yoL?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ceb18629-2864-4b6a-72c9-08daf3db48e6 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2023 13:53:57.3733 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EdZUxOQLlrgiCcJthcHQjk82pY9X6E/noJvMiC7aCIPAwcRaIVAlDxqWnDHzLPf60dASdU8f+U646z5H7AyNeg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8551 v->arch.paging.shadow.shadow_table[], v->arch.paging.shadow.oos[], v->arch.paging.shadow.oos_{snapshot[],fixup[].smfn[]} as well as the hash table are all only ever written with valid MFNs or INVALID_MFN. Avoid the somewhat expensive mfn_valid() when checking MFNs coming from these arrays. Signed-off-by: Jan Beulich --- There are many more uses which can likely be replaced, but I think we're better off doing this in piecemeal fashion. --- a/xen/arch/x86/mm/shadow/common.c +++ b/xen/arch/x86/mm/shadow/common.c @@ -171,7 +171,7 @@ static void sh_oos_audit(struct domain * for ( idx = 0; idx < SHADOW_OOS_PAGES; idx++ ) { mfn_t *oos = v->arch.paging.shadow.oos; - if ( !mfn_valid(oos[idx]) ) + if ( mfn_eq(oos[idx], INVALID_MFN) ) continue; expected_idx = mfn_x(oos[idx]) % SHADOW_OOS_PAGES; @@ -327,8 +327,7 @@ void oos_fixup_add(struct domain *d, mfn int i; for ( i = 0; i < SHADOW_OOS_FIXUPS; i++ ) { - if ( mfn_valid(oos_fixup[idx].smfn[i]) - && mfn_eq(oos_fixup[idx].smfn[i], smfn) + if ( mfn_eq(oos_fixup[idx].smfn[i], smfn) && (oos_fixup[idx].off[i] == off) ) return; } @@ -461,7 +460,7 @@ static void oos_hash_add(struct vcpu *v, idx = mfn_x(gmfn) % SHADOW_OOS_PAGES; oidx = idx; - if ( mfn_valid(oos[idx]) + if ( !mfn_eq(oos[idx], INVALID_MFN) && (mfn_x(oos[idx]) % SHADOW_OOS_PAGES) == idx ) { /* Punt the current occupant into the next slot */ @@ -470,8 +469,8 @@ static void oos_hash_add(struct vcpu *v, swap = 1; idx = (idx + 1) % SHADOW_OOS_PAGES; } - if ( mfn_valid(oos[idx]) ) - { + if ( !mfn_eq(oos[idx], INVALID_MFN) ) + { /* Crush the current occupant. */ _sh_resync(v, oos[idx], &oos_fixup[idx], oos_snapshot[idx]); perfc_incr(shadow_unsync_evict); @@ -607,7 +606,7 @@ void sh_resync_all(struct vcpu *v, int s /* First: resync all of this vcpu's oos pages */ for ( idx = 0; idx < SHADOW_OOS_PAGES; idx++ ) - if ( mfn_valid(oos[idx]) ) + if ( !mfn_eq(oos[idx], INVALID_MFN) ) { /* Write-protect and sync contents */ _sh_resync(v, oos[idx], &oos_fixup[idx], oos_snapshot[idx]); @@ -630,7 +629,7 @@ void sh_resync_all(struct vcpu *v, int s for ( idx = 0; idx < SHADOW_OOS_PAGES; idx++ ) { - if ( !mfn_valid(oos[idx]) ) + if ( mfn_eq(oos[idx], INVALID_MFN) ) continue; if ( skip ) @@ -2183,7 +2182,7 @@ void sh_remove_shadows(struct domain *d, !(pg->shadow_flags & (1 << t)) ) \ break; \ smfn = shadow_hash_lookup(d, mfn_x(gmfn), t); \ - if ( unlikely(!mfn_valid(smfn)) ) \ + if ( unlikely(mfn_eq(smfn, INVALID_MFN)) ) \ { \ printk(XENLOG_G_ERR "gmfn %"PRI_mfn" has flags %#x" \ " but no type-%#x shadow\n", \ @@ -2751,7 +2750,7 @@ void shadow_teardown(struct domain *d, b int i; mfn_t *oos_snapshot = v->arch.paging.shadow.oos_snapshot; for ( i = 0; i < SHADOW_OOS_PAGES; i++ ) - if ( mfn_valid(oos_snapshot[i]) ) + if ( !mfn_eq(oos_snapshot[i], INVALID_MFN) ) { shadow_free(d, oos_snapshot[i]); oos_snapshot[i] = INVALID_MFN; @@ -2934,7 +2933,7 @@ static int shadow_one_bit_disable(struct int i; mfn_t *oos_snapshot = v->arch.paging.shadow.oos_snapshot; for ( i = 0; i < SHADOW_OOS_PAGES; i++ ) - if ( mfn_valid(oos_snapshot[i]) ) + if ( !mfn_eq(oos_snapshot[i], INVALID_MFN) ) { shadow_free(d, oos_snapshot[i]); oos_snapshot[i] = INVALID_MFN; --- a/xen/arch/x86/mm/shadow/multi.c +++ b/xen/arch/x86/mm/shadow/multi.c @@ -110,7 +110,7 @@ get_fl1_shadow_status(struct domain *d, /* Look for FL1 shadows in the hash table */ { mfn_t smfn = shadow_hash_lookup(d, gfn_x(gfn), SH_type_fl1_shadow); - ASSERT(!mfn_valid(smfn) || mfn_to_page(smfn)->u.sh.head); + ASSERT(mfn_eq(smfn, INVALID_MFN) || mfn_to_page(smfn)->u.sh.head); return smfn; } @@ -2680,7 +2680,7 @@ static int cf_check sh_page_fault( mfn_t smfn = pagetable_get_mfn( v->arch.paging.shadow.shadow_table[i]); - if ( mfn_valid(smfn) && (mfn_x(smfn) != 0) ) + if ( mfn_x(smfn) ) { used |= (mfn_to_page(smfn)->v.sh.back == mfn_x(gmfn)); @@ -3824,7 +3824,7 @@ static void cf_check sh_pagetable_dying( : shadow_hash_lookup(d, mfn_x(gmfn), SH_type_l2_pae_shadow); } - if ( mfn_valid(smfn) ) + if ( !mfn_eq(smfn, INVALID_MFN) ) { gmfn = _mfn(mfn_to_page(smfn)->v.sh.back); mfn_to_page(gmfn)->pagetable_dying = true; @@ -3867,7 +3867,7 @@ static void cf_check sh_pagetable_dying( smfn = shadow_hash_lookup(d, mfn_x(gmfn), SH_type_l4_64_shadow); #endif - if ( mfn_valid(smfn) ) + if ( !mfn_eq(smfn, INVALID_MFN) ) { mfn_to_page(gmfn)->pagetable_dying = true; shadow_unhook_mappings(d, smfn, 1/* user pages only */); --- a/xen/arch/x86/mm/shadow/private.h +++ b/xen/arch/x86/mm/shadow/private.h @@ -769,8 +769,10 @@ get_shadow_status(struct domain *d, mfn_ /* Look for shadows in the hash table */ { mfn_t smfn = shadow_hash_lookup(d, mfn_x(gmfn), shadow_type); - ASSERT(!mfn_valid(smfn) || mfn_to_page(smfn)->u.sh.head); + + ASSERT(mfn_eq(smfn, INVALID_MFN) || mfn_to_page(smfn)->u.sh.head); perfc_incr(shadow_get_shadow_status); + return smfn; } From xen-devel-bounces@lists.xenproject.org Wed Jan 11 13:54:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 13:54:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475355.737030 (Exim 4.92) (envelope-from ) id 1pFbYc-0006Of-SR; Wed, 11 Jan 2023 13:54:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475355.737030; Wed, 11 Jan 2023 13:54:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFbYc-0006OY-Nz; Wed, 11 Jan 2023 13:54:22 +0000 Received: by outflank-mailman (input) for mailman id 475355; Wed, 11 Jan 2023 13:54:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFbYb-0004QI-0J for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 13:54:21 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2085.outbound.protection.outlook.com [40.107.13.85]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 711636b6-91b7-11ed-b8d0-410ff93cb8f0; Wed, 11 Jan 2023 14:54:18 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8551.eurprd04.prod.outlook.com (2603:10a6:10:2d6::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Wed, 11 Jan 2023 13:54:17 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Wed, 11 Jan 2023 13:54:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 711636b6-91b7-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z/X6hsId14TLdqMovZn6xfbBMq9Vy09EQsW1KtOfE2uZQDRAyfmaFzLkyz3ViIM9A4QhMuDNDyTatk7lgQVqwG/pVCRsBf98lIbuOkmrlLCxHZU4w8rZqVKWu64hR4X/Qpua7y5EGND5muVzYm4UmopsNZl7V0t3Ae2dSxmYKPdc9o2oG0GO7L3h6yYw71BWgxaSn15KxyGmIuwC8ZYOhLV5crDK1M9ctSP3kPMSIaFzrEaVKsrUSXuZml4Vkn5wT0yGQYG73ExU+nui66hoEE4LPM/OAUvjp8yasAlSzqeQyxXqt672K0XwcFejgfZPwt7z4numTwZvT+czRSkxeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rzqulTEtucE5QZgMYqiUHlGTP59ie28OePbEzibohCE=; b=bfrmh5bfC8MStwAB4C97185IwRk+kJrSjopibru4g4Q0kOZwASoaireZ6dJmnbMNyOgEQJJYQALADPzukl38VdYun6Lorpq8LdlpygLEejqMNh03ewDRt12YU2oq9JRos+qqck1MMuawxxU8v4Ufw9JADOJ8UroPdVuZzdDsvq85SEW42CK0vtdKxTz4QYvmNvHM4FGLlsNaIur81DkvDc9kgx4LUt5b9YsrGKM4ta3v89T2po8mDaCT/8YsX+0hjy5reZ2aCiVGJDC/75YsETO/mCQcvYF/xwTHj041VkFQZ9XvniJv0BnmyZTSwS2w04PNKCDiB5QNYkIHOu6IbA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rzqulTEtucE5QZgMYqiUHlGTP59ie28OePbEzibohCE=; b=wCS9rReg0rpAQ9wiZ7XZRXdBoF/mZkkw+nJC/tq9uC7yQwZq6rUez8dJsa1odzHCxvhrx4YbJwMhOmcFTIEU2f40HUIGkq1Cyl6eXiT9QzAnL5b07Qy1jTBMqVJDIwA8MitB3yjnX4Idd7uo9SpwiK4d1eryLFR0lKRp8I2X0wHb8ynN4ox79woRaghbMNznGo9ZB+6wlPrVwekVy7K1NBaAhMopvP0cpLOzvNQrFLyDcisHAi8q9UCOtm/OY7RdzkY6HMjEzd7RMzR2jUBySg811E+A0nXMS+hrEF8Lhxg/8CBMnR1H7s/e3VWVEd+f6uYjRzFaFQLmb61qHozDiw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 11 Jan 2023 14:54:15 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: [PATCH v2 5/9] x86/shadow: L2H shadow type is PV32-only Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Tim Deegan , George Dunlap References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0017.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a::27) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8551:EE_ X-MS-Office365-Filtering-Correlation-Id: b48130e9-32de-49a3-54e3-08daf3db54e0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QhQC/dFlDo4JO9JDWJrG26/1RoDmxezYZQwk3Tp7EvGVrpjotE8XQ1cvkWp36KUSxrgiT2t1paRU1980GqV2OzyoSIPpdViL1aoyXSRFZOCOPbUqFm925eV1CQ0i4l3U5G0o0EM3Ywk+VyEw4RjL1bNyzYDvXdrv+AVqEqVvUg/HO5DcN3Km9STK51lh/6YrI2dSvpmMn/+A/RSVmklO6VvQhcV2zYsF/JRsrogDporW4N8WhaGTKgsiwTLstrg29tGggBUb/BJBVrDOlOvsyANhs3HlOPehYlG0wJ5HH2TAW1opRzBdGvmvuprBXmGhmIORhqQZyUY50szDysVrpGYzQ0CyF04fksBvkct9XcN79Zw9hS4Myk//NC8W5mGGti+LSdqt6+IR+7gz2jFubQEfXLPI7+FkkHT0Tgn9lTkWoTgUluzZntIKapiJJ/I4Toz8WEIj80P+gJGW/aGpmAivVctgodpdqfWPMKKDo2aZKwXdei1hk/NO/7Fl69Eh+JvK4jq5OCtTmz1YfJJc1QC+Gd3kVfuHWTx7Kk/2QG4VkpN9mlFZrRSGjnrcujcY5eqUviySqewL/3hAx7qxRs4VNlY/1C/yD8lYYhZR66rDKz2B0L1NKoMRiHsjQWSx94fBUNdOFVJu44UX0AXRiEWunTH7ZVJYcXXr5sclcDGuzcQa3Bq4KXh6elBVpSVEe2ERodGjxzbXw3wvBAk0C17UP3sP/a6Q+CLdTzj/QVY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(39860400002)(366004)(376002)(136003)(396003)(451199015)(8936002)(2906002)(5660300002)(41300700001)(316002)(4326008)(66556008)(8676002)(6916009)(66476007)(66946007)(54906003)(26005)(6512007)(38100700002)(2616005)(31686004)(86362001)(186003)(31696002)(83380400001)(36756003)(6506007)(478600001)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZnhUVXBUVjN1SHJ1SjQ4VjdTZGNlaHBTc3IzSUpYUURTb3hqUzhZdUZacWhv?= =?utf-8?B?blhrRFJIU0QvbVR5Z3hZOUNNTkR2bDZBbzNjelJkVjlzK3d6cXZ6RDhQdElx?= =?utf-8?B?MHV5d1RtdjNtZncycHNkL2ZJY1MxLzFQbGZTbzZjMVhKbk8xMEFLQTFlRVVz?= =?utf-8?B?dXdqTVppYk1NTFBmQmlsZDRIMEpJcCtQbkxPN05xSWFrWTVKYWZEMXFHemMv?= =?utf-8?B?Ukp3aW1lTzcwdEhrQ0dCbm45eER3Mk1jR2lmUGY4bTRMR0I4L3lwckFWaGYw?= =?utf-8?B?S1I1b01uTTFtbzU3UDNiK1NRQ3FLUllNQW5wS2I0OEt3SXpQcXBON2NSU1F2?= =?utf-8?B?Q2tQTXoybG9rQnJDRXRUaG83NXpvRzUvUlgxcTlWMWJIUDUrMHByMzN4V1hE?= =?utf-8?B?Rm1uTkM0QVYyWkJwN2pUNnU1VllSVzVCTHRyYkE4SFZ4cld1bnVkZTNyY01x?= =?utf-8?B?a2FDVk9UbXVDNEVMKytrb2hpSVJoaWRPTVZJZGZhU3NFZmhpbE4wcTdVc3FF?= =?utf-8?B?UjNSYnMzQlV1UkJYQVJabWthRC9qNzArYXlDVEg0NVNBL0RaN2tGak83QmdZ?= =?utf-8?B?VG1CN0t4L1VKTlNwcFROeXA1KzBPY29ieXRndDRWMWtiSDFvcWNQUTRjYTd3?= =?utf-8?B?UVY1c3VMQzU5R0xwR0tIYWpmUFVxQUFRY01USlZzendEdkFRWEF3YVo5OGdI?= =?utf-8?B?cUViNlNBYVJoM1NDci8wbEJJUmpQMm9NcDhTMm1CaEU1OU9Ld1ptMkROWDdZ?= =?utf-8?B?WjFBU2laOHkza1p6Lzhlb2tCYUNzcHlid2pTY3J2ZVp0aDZZckg2a2dRYjVV?= =?utf-8?B?VFN1MHdoS1NnMFhPYlBEMHRJNVIzaERwcDV5M0I3dEE5RHhMZG5tUjUxQ3ZL?= =?utf-8?B?UnVVRTlPNW1UblpCZmJJSVpzQ1IyZHBaVzVickZDQ0JORkY0eWgyMHZ0bkkv?= =?utf-8?B?UmtZcmJWcW5hMEMvRkhRTURCVENhK1hEWkN2S29YS2VZME9RNjA0TmhRM1VV?= =?utf-8?B?dEs4OXlTVjN5cHhXOTF5WGxjZmRWSGt5VnV4SFQvSTNNRlduRVkvMktnaVBv?= =?utf-8?B?dS9mSGVjc3E2MWV0VkVEazIrNlBCUkl5WGF2SVFRdnFNUWJ0MG9TM2cvdGtL?= =?utf-8?B?MzdBeHo0UHpZQmp1S0ZXWnpCZnVPeVZVZ2JkOUpJaXpTSVpkZ04yRUlNSFYv?= =?utf-8?B?STRqSFVQaFFWRElQb3JGL1ZGYzM3Y3JxWHJBRStXUWRzYWVEamp0QTBrK0R4?= =?utf-8?B?RVpHNkdYZEN1SE1jb0xheCtMRTFNRVpnVDBaeTJRYlQrdVNmaUg2dkc2QjA0?= =?utf-8?B?Si9uUHM4SkR5WG1sTVgwRXlaV2lGTlNzcG8vSDZIYmlDcjQxQUlMRWEzZHND?= =?utf-8?B?RkhEOTlObWlSZFpVYVI0UXArS2xtdmZUVnlkenNBZ1FMTDRsemVBS0pXdXRt?= =?utf-8?B?VEhWWEY2UW83Q0RjZTd0UTBmRTJabjA0ZXZSRXB1VWFKZ2J4Q2llcytQZmY1?= =?utf-8?B?ZmlNNVRGMzdOQVVEckVicVhYemhFOG1mZGVPbjVta0QwQTJhYUsySG1TbzBS?= =?utf-8?B?eGNtd1JrUGRrRjdGSEZYeWliZzV2MnltK2lVSS9NZHlYQVJicHQrNkNQUitB?= =?utf-8?B?QWk4T0wzUTExZDhXc1I2d0lyOHVkTFJNd1RTZjB1bVVMY0xFdlcrRllaMVRK?= =?utf-8?B?SGZ5TVllVXY4TUk4L0ZsQUV1enYyLzRBZmRhaEtIVmJRbG0xek0welp3K0FO?= =?utf-8?B?dU5SZnpmVVd4aTYwRFBENVBIejA4c3R4Vml1bzhGcDY4ckJYaTdwM2RJVG0y?= =?utf-8?B?SWtCWXVlb1JteXpXd0dLMnp4VUVXRXJGWE1obHhOR0MrQ2JPaDJjNkxHcENP?= =?utf-8?B?SHJEc2I0eGtqZkE4Vi9vWXp4cHdpY3QvbGNXTDFPTE9lYXdWd083Rmt2SWM3?= =?utf-8?B?UFUrRkJQY05CQ3EzZ0xnM3J0UlgrMTVzaXBBMmxhZnU3NW9mcUtBUXJQbWVV?= =?utf-8?B?cTFlT1lXUUZJKzQyWTJqTWRHSnRESTFZaFVIUzFtR2ZsbUtUZE5LQ2NXcjJr?= =?utf-8?B?MDZDekQ5OFhSVGFGeWJlaXlFNmlmcE92eXIzdmpraDBKVVFIMXBtYjBPVWF2?= =?utf-8?Q?U19HL2/vndxWdWVUXBwToLwbs?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b48130e9-32de-49a3-54e3-08daf3db54e0 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2023 13:54:17.4815 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BuP8aE6jpW9NB/8eKpEaOGtNz9K0RdyoeXP/NdoOeawDu7gh95jKzC66swtjXMssOA0sexxtBgIh0rUQ7t8Ahw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8551 Like for the various HVM-only types, save a little bit of code by suitably "masking" this type out when !PV32. Signed-off-by: Jan Beulich --- I wasn't really sure whether it would be worthwhile to also update the "#else" part of shadow_size(). Doing so would be a little tricky, as the type to return 0 for has no name right now; I'd need to move down the #undef to allow for that. Thoughts? --- v2: Merely comment out the sh_type_to_size[] entry. --- a/xen/arch/x86/mm/shadow/common.c +++ b/xen/arch/x86/mm/shadow/common.c @@ -1740,9 +1740,11 @@ void sh_destroy_shadow(struct domain *d, case SH_type_fl1_64_shadow: SHADOW_INTERNAL_NAME(sh_destroy_l1_shadow, 4)(d, smfn); break; +#ifdef CONFIG_PV32 case SH_type_l2h_64_shadow: ASSERT(is_pv_32bit_domain(d)); /* Fall through... */ +#endif case SH_type_l2_64_shadow: SHADOW_INTERNAL_NAME(sh_destroy_l2_shadow, 4)(d, smfn); break; @@ -2095,7 +2097,9 @@ static int sh_remove_shadow_via_pointer( #endif case SH_type_l1_64_shadow: case SH_type_l2_64_shadow: +#ifdef CONFIG_PV32 case SH_type_l2h_64_shadow: +#endif case SH_type_l3_64_shadow: case SH_type_l4_64_shadow: SHADOW_INTERNAL_NAME(sh_clear_shadow_entry, 4)(d, vaddr, pmfn); @@ -2133,7 +2137,9 @@ void sh_remove_shadows(struct domain *d, [SH_type_l2_pae_shadow] = SHADOW_INTERNAL_NAME(sh_remove_l1_shadow, 3), #endif [SH_type_l2_64_shadow] = SHADOW_INTERNAL_NAME(sh_remove_l1_shadow, 4), +#ifdef CONFIG_PV32 [SH_type_l2h_64_shadow] = SHADOW_INTERNAL_NAME(sh_remove_l1_shadow, 4), +#endif [SH_type_l3_64_shadow] = SHADOW_INTERNAL_NAME(sh_remove_l2_shadow, 4), [SH_type_l4_64_shadow] = SHADOW_INTERNAL_NAME(sh_remove_l3_shadow, 4), }; @@ -2146,7 +2152,9 @@ void sh_remove_shadows(struct domain *d, #endif [SH_type_l1_64_shadow] = SHF_L2H_64 | SHF_L2_64, [SH_type_l2_64_shadow] = SHF_L3_64, +#ifdef CONFIG_PV32 [SH_type_l2h_64_shadow] = SHF_L3_64, +#endif [SH_type_l3_64_shadow] = SHF_L4_64, }; @@ -2210,7 +2218,9 @@ void sh_remove_shadows(struct domain *d, #endif DO_UNSHADOW(SH_type_l4_64_shadow); DO_UNSHADOW(SH_type_l3_64_shadow); +#ifdef CONFIG_PV32 DO_UNSHADOW(SH_type_l2h_64_shadow); +#endif DO_UNSHADOW(SH_type_l2_64_shadow); DO_UNSHADOW(SH_type_l1_64_shadow); @@ -3175,7 +3185,9 @@ void shadow_audit_tables(struct vcpu *v) [SH_type_l1_64_shadow] = SHADOW_INTERNAL_NAME(sh_audit_l1_table, 4), [SH_type_fl1_64_shadow] = SHADOW_INTERNAL_NAME(sh_audit_fl1_table, 4), [SH_type_l2_64_shadow] = SHADOW_INTERNAL_NAME(sh_audit_l2_table, 4), +# ifdef CONFIG_PV32 [SH_type_l2h_64_shadow] = SHADOW_INTERNAL_NAME(sh_audit_l2_table, 4), +# endif [SH_type_l3_64_shadow] = SHADOW_INTERNAL_NAME(sh_audit_l3_table, 4), [SH_type_l4_64_shadow] = SHADOW_INTERNAL_NAME(sh_audit_l4_table, 4), #endif --- a/xen/arch/x86/mm/shadow/hvm.c +++ b/xen/arch/x86/mm/shadow/hvm.c @@ -56,7 +56,7 @@ const uint8_t sh_type_to_size[] = { [SH_type_l1_64_shadow] = 1, [SH_type_fl1_64_shadow] = 1, [SH_type_l2_64_shadow] = 1, - [SH_type_l2h_64_shadow] = 1, +/* [SH_type_l2h_64_shadow] = 1, PV32-only */ [SH_type_l3_64_shadow] = 1, [SH_type_l4_64_shadow] = 1, [SH_type_p2m_table] = 1, --- a/xen/arch/x86/mm/shadow/multi.c +++ b/xen/arch/x86/mm/shadow/multi.c @@ -97,6 +97,13 @@ static void sh_flush_local(const struct flush_local(guest_flush_tlb_flags(d)); } +#if GUEST_PAGING_LEVELS >= 4 && defined(CONFIG_PV32) +#define ASSERT_VALID_L2(t) \ + ASSERT((t) == SH_type_l2_shadow || (t) == SH_type_l2h_shadow) +#else +#define ASSERT_VALID_L2(t) ASSERT((t) == SH_type_l2_shadow) +#endif + /**************************************************************************/ /* Hash table mapping from guest pagetables to shadows * @@ -337,7 +344,7 @@ static void sh_audit_gw(struct vcpu *v, if ( mfn_valid((smfn = get_shadow_status(d, gw->l2mfn, SH_type_l2_shadow))) ) sh_audit_l2_table(d, smfn, INVALID_MFN); -#if GUEST_PAGING_LEVELS >= 4 /* 32-bit PV only */ +#if GUEST_PAGING_LEVELS >= 4 && defined(CONFIG_PV32) if ( mfn_valid((smfn = get_shadow_status(d, gw->l2mfn, SH_type_l2h_shadow))) ) sh_audit_l2_table(d, smfn, INVALID_MFN); @@ -859,13 +866,12 @@ do { int _i; \ int _xen = !shadow_mode_external(_dom); \ shadow_l2e_t *_sp = map_domain_page((_sl2mfn)); \ - ASSERT(mfn_to_page(_sl2mfn)->u.sh.type == SH_type_l2_64_shadow ||\ - mfn_to_page(_sl2mfn)->u.sh.type == SH_type_l2h_64_shadow);\ + ASSERT_VALID_L2(mfn_to_page(_sl2mfn)->u.sh.type); \ for ( _i = 0; _i < SHADOW_L2_PAGETABLE_ENTRIES; _i++ ) \ { \ if ( (!(_xen)) \ || !is_pv_32bit_domain(_dom) \ - || mfn_to_page(_sl2mfn)->u.sh.type != SH_type_l2h_64_shadow \ + || mfn_to_page(_sl2mfn)->u.sh.type == SH_type_l2_64_shadow \ || (_i < COMPAT_L2_PAGETABLE_FIRST_XEN_SLOT(_dom)) ) \ { \ (_sl2e) = _sp + _i; \ @@ -992,6 +998,7 @@ sh_make_shadow(struct vcpu *v, mfn_t gmf } break; +#ifdef CONFIG_PV32 case SH_type_l2h_shadow: BUILD_BUG_ON(sizeof(l2_pgentry_t) != sizeof(shadow_l2e_t)); if ( is_pv_32bit_domain(d) ) @@ -1002,6 +1009,8 @@ sh_make_shadow(struct vcpu *v, mfn_t gmf unmap_domain_page(l2t); } break; +#endif + default: /* Do nothing */ break; } } @@ -1123,11 +1132,13 @@ static shadow_l2e_t * shadow_get_and_cre shadow_l3e_t new_sl3e; unsigned int t = SH_type_l2_shadow; +#ifdef CONFIG_PV32 /* Tag compat L2 containing hypervisor (m2p) mappings */ if ( is_pv_32bit_domain(d) && guest_l4_table_offset(gw->va) == 0 && guest_l3_table_offset(gw->va) == 3 ) t = SH_type_l2h_shadow; +#endif /* No l2 shadow installed: find and install it. */ *sl2mfn = get_shadow_status(d, gw->l2mfn, t); @@ -1337,11 +1348,7 @@ void sh_destroy_l2_shadow(struct domain SHADOW_DEBUG(DESTROY_SHADOW, "%"PRI_mfn"\n", mfn_x(smfn)); -#if GUEST_PAGING_LEVELS >= 4 - ASSERT(t == SH_type_l2_shadow || t == SH_type_l2h_shadow); -#else - ASSERT(t == SH_type_l2_shadow); -#endif + ASSERT_VALID_L2(t); ASSERT(sp->u.sh.head); /* Record that the guest page isn't shadowed any more (in this type) */ @@ -1865,7 +1872,7 @@ int sh_map_and_validate_gl2he(struct vcpu *v, mfn_t gl2mfn, void *new_gl2p, u32 size) { -#if GUEST_PAGING_LEVELS >= 4 +#if GUEST_PAGING_LEVELS >= 4 && defined(CONFIG_PV32) return sh_map_and_validate(v, gl2mfn, new_gl2p, size, SH_type_l2h_shadow, shadow_l2_index, @@ -3674,7 +3681,7 @@ void sh_clear_shadow_entry(struct domain shadow_set_l1e(d, ep, shadow_l1e_empty(), p2m_invalid, smfn); break; case SH_type_l2_shadow: -#if GUEST_PAGING_LEVELS >= 4 +#if GUEST_PAGING_LEVELS >= 4 && defined(CONFIG_PV32) case SH_type_l2h_shadow: #endif shadow_set_l2e(d, ep, shadow_l2e_empty(), smfn); @@ -4124,14 +4131,16 @@ int cf_check sh_audit_l3_table(struct do if ( SHADOW_AUDIT & SHADOW_AUDIT_ENTRIES_MFNS ) { + unsigned int t = SH_type_l2_shadow; + gfn = guest_l3e_get_gfn(*gl3e); mfn = shadow_l3e_get_mfn(*sl3e); - gmfn = get_shadow_status(d, get_gfn_query_unlocked( - d, gfn_x(gfn), &p2mt), - (is_pv_32bit_domain(d) && - guest_index(gl3e) == 3) - ? SH_type_l2h_shadow - : SH_type_l2_shadow); +#ifdef CONFIG_PV32 + if ( guest_index(gl3e) == 3 && is_pv_32bit_domain(d) ) + t = SH_type_l2h_shadow; +#endif + gmfn = get_shadow_status( + d, get_gfn_query_unlocked(d, gfn_x(gfn), &p2mt), t); if ( !mfn_eq(gmfn, mfn) ) AUDIT_FAIL(3, "bad translation: gfn %" SH_PRI_gfn " --> %" PRI_mfn " != mfn %" PRI_mfn, --- a/xen/arch/x86/mm/shadow/private.h +++ b/xen/arch/x86/mm/shadow/private.h @@ -209,6 +209,10 @@ extern void shadow_audit_tables(struct v #define SH_type_unused 10U #endif +#ifndef CONFIG_PV32 /* Unused (but uglier to #ifdef above): */ +#undef SH_type_l2h_64_shadow +#endif + /* * What counts as a pinnable shadow? */ @@ -286,7 +290,11 @@ static inline void sh_terminate_list(str #define SHF_L1_64 (1u << SH_type_l1_64_shadow) #define SHF_FL1_64 (1u << SH_type_fl1_64_shadow) #define SHF_L2_64 (1u << SH_type_l2_64_shadow) +#ifdef CONFIG_PV32 #define SHF_L2H_64 (1u << SH_type_l2h_64_shadow) +#else +#define SHF_L2H_64 0 +#endif #define SHF_L3_64 (1u << SH_type_l3_64_shadow) #define SHF_L4_64 (1u << SH_type_l4_64_shadow) From xen-devel-bounces@lists.xenproject.org Wed Jan 11 13:55:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 13:55:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475361.737043 (Exim 4.92) (envelope-from ) id 1pFbZP-00079L-B0; Wed, 11 Jan 2023 13:55:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475361.737043; Wed, 11 Jan 2023 13:55:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFbZP-00079E-7w; Wed, 11 Jan 2023 13:55:11 +0000 Received: by outflank-mailman (input) for mailman id 475361; Wed, 11 Jan 2023 13:55:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFbYy-0004QI-Bw for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 13:54:44 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2059.outbound.protection.outlook.com [40.107.13.59]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7f31bd34-91b7-11ed-b8d0-410ff93cb8f0; Wed, 11 Jan 2023 14:54:42 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8551.eurprd04.prod.outlook.com (2603:10a6:10:2d6::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Wed, 11 Jan 2023 13:54:40 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Wed, 11 Jan 2023 13:54:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7f31bd34-91b7-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ef4eBs+AKiiy090udEb1VC+i9u//RYUJ5ou3mdLgQ9b6v0NqFQZm3eOYB/2LvKMsMQza4tj4RkVFhV1PXHJI6VJyJbiFPAKMAcfnEFsuSCbco8F3PbSaUozDvVb5GKQdJvFGCu1Z2pwb3GNsS7dIy3CT85Fh4sw2nG95zVepUBfHQaVQORMxlIlmAvrRf5Zcm7DQdiwoVMzH58trVcID0Hw8LTQgpDs8SNBs9tpusHwuXTL8ZCnUGq4SUHdHDWUkJ3ZG9avyKxF4OUWIxAEZQUX5TS+/pQ2oIDcsrrRXfxrr8+LwuC+hr2fo4NY+jAiENdlTLFlnfI/TDt2mfR4Tlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+A1uJIX8hCVYxMZpSUyJ3UOaNSMYMDBoFU6vGM6iCfg=; b=ZFVuMt3mAXTXntaYkgz/BRN3GtdwR7DDbyo2AL6oRH8Nz3lP/fUHEYmmmsqY0TPv5Qgz4oyTfc+ruFgX6WTZe66E85NXPcWKELzZ0oYWL7xhC0RnF1VUPQG2dYiG9u9Q+dCd5sYctXVmvKOkDo/pdwhYRsAylsYc3uFTxkOldJsVX8B283OMV9bt1aiQDQE6FzRc2mMnfF2Ocnp/0IRt9ucbYoUVVZfAWvuu89fLs8V7dev7MywsglWEgu2aQU9VHvt1ov/SWqkXRysPZCg/Kf9w6+YhtWkUpHVll9euzK4k76P70I9e7eY7kcO2mnwdt4jFaRsraGXrGedM2DWBhg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+A1uJIX8hCVYxMZpSUyJ3UOaNSMYMDBoFU6vGM6iCfg=; b=nzbKpI3XMAKMvios3Vn76ZE44+K5Hsg4OavvTdiW5CyfvFWOqTD41O8F6Ty6dj1xx9bJdhHbg3SaKGZugR4SaR3w9et0Y3glkIcZYXjHK4px8ctLZs1IfBNaO5RkR8HVOLAt7tnVny9YXj3m/R8dQ79PAcMQF/OJWF2X/T0YTl7QQMWVUIFy0Q8sHJB2C1FLf17L9yu4Xj7/LShwjNeLWartGKQKXozKXLBtPVEXJtSo/Bvkqq2IT3xD9Cf96KW5TwCjI4Fi7dIlOTfdj5q4FX8sgTltaiTMskUg4D63GiGiFUMqji4n7BjlpZ9kt/hNSsN41d25q0A8EiMFUTr4LA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <27a7245c-f933-5b2b-5685-d9ba2dbd4a8c@suse.com> Date: Wed, 11 Jan 2023 14:54:38 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: [PATCH v2 6/9] x86/shadow: re-work 4-level SHADOW_FOREACH_L2E() Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Tim Deegan , George Dunlap References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0032.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8551:EE_ X-MS-Office365-Filtering-Correlation-Id: 77f40980-f1c7-40ad-5378-08daf3db62c5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: x4WqpYgLr3iqSQJb/MamaeokYvbenoEW649EYtu+cuhH/ix4DTkhY1/cFxm4HRpMoKnPwrg+C6hIZnq4G9IOr/UChdZwWP01Tp4cTifMGmiJMzGy/s/TO1o1HXFQrdXwqWX9l/XGRLRn16DufIJtg+ugZYq3OM85llPVxZlCIQbnHtHp6ehipwDi01Qv7MG/PcorOqHey/gJPI8U/vTdjoT+hb7ig2NDjs1jikpb+AkEPvGaofjoQMO1jURtIaCrbBsJsuqsaI3TJjYHVOwd3xDvWPa0eZtpMAlcgXBUsk7JVraBvi4G1PS1y3jYMjc9BkGTK0QfceRDovUheuY3v6V0c/332dtcsxgfcOw0W3jIxcQqqET5zJl+gaDzP5AYw7wI6xbBWlbeKdVYlSLpKJnB5hyAtao+N4g6gMmfKTpyvhRMA4q4t3t+HAeb2Yryh6w0aisnvTIFjhC7AoBpMlDvq+OkfmpcCbFSSTfrOXwweEATVTVdmEURl0BRI2RB3v+4zQ7oy0Bv5KUvkih3hpWgcR2LLxgSx+2LhsXlMfdH0Oiw9WKoyX2dhuwgZV0dl1b440+hre6yNtz7Rrf5/UVV/KJXZewMbISD7h9bH8TM52J8vZyMLO/7Yce38egF8yi14dUhr4uXq66/UovksTI/oZ0aGwVO2sA3m41Ic6vMf47yCkIlVNTY4cZ5Ng2L8a5JHGmfvRL0Lp+GdsGBg99RlRrSAOxQlWDMQWlZ1Hk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(39860400002)(366004)(376002)(136003)(396003)(451199015)(8936002)(2906002)(5660300002)(41300700001)(316002)(4326008)(66556008)(8676002)(6916009)(66476007)(66946007)(54906003)(26005)(6512007)(38100700002)(2616005)(31686004)(86362001)(186003)(31696002)(36756003)(6506007)(478600001)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SHlTSy9mMzk3OWVldEV0Qld4T1lpQWUzR2hKMU1sZW85aVVjajVmckxvNXFx?= =?utf-8?B?SWowU09ySExoYnpjWExlcDlNa25nRmV6QW9NVVRMT0ZNbS9XWkpvZlB1S0VC?= =?utf-8?B?SVFYaGQvalQyeXhYc3VmQ21FaVZXeTNDZkdLQnk2R0ZsQXdMOEgycjhMNkZQ?= =?utf-8?B?eGtNUG9jRlN5cXVrUG5aS1pjNjZmbWxlWVo1Q01jM3duUG9tYWJBalZDYVBY?= =?utf-8?B?UGlEK1dNQmlNbjRwRTNjdVBpc3lxUlBnMUNaakNrOTc4UEZYNFNqbWowTHNp?= =?utf-8?B?a0daV2FaMTFUc3JkbEtlckcwOTJHRWFoODlVR3BEVFk0dDBjU2JYdWd1WHZE?= =?utf-8?B?Y1Z4aUNiWTZhYkFXeURSRnFnMjU2bmkxbmIvM2ZqNC94QkN2TFFKZzc2c2dG?= =?utf-8?B?N1Q2ZzROeTlFRGZvdXJ5VEVWbzZOaDlUZlFHK2JNWk9yb3VXWmVxZFFpbThC?= =?utf-8?B?VUU4YzZWUk5vQjBpeFl2R09RYTBrYmNmbzdDZGdCRjBPOEVFTTg3cEFweXVD?= =?utf-8?B?OTBUMnVoNnc1bithOG9sN2VlYmhYdWZVVkF3R1Rwd0RKdktWRHMwOFB3amJF?= =?utf-8?B?QTFFK2t3OEtvNGw3ODg1anJ0M2pZVHJ1dHhsR0RmTWN6NzBIR1JLT3psT2hy?= =?utf-8?B?alc2N1d4a05UWUhZcWh1VHRLUjJKWVVrcnpnMmJoTXY2NXhsWkR2OXFOSElz?= =?utf-8?B?S1ZuMUdDckxPeStGdVE1dmZXZlZRR2NhaDdZUEU3UGJQQ0locWk5bCtjeExw?= =?utf-8?B?bXlUUFdZUklhejdPQ2JycFhPYXJkeHFjUm54VklLYnNRcHV6S2hSeWwxemM2?= =?utf-8?B?VWtTYTJIRnNzV0ZKTjBiT0U5Z1RnZjVEa0padTlCbWVTMWlRQU1TSnVINnpl?= =?utf-8?B?SkU2TVVRcmRYbnJRN2pMOHBDTVdZVkVycFhxZ2VDVHZaNVg5TVBkQTE3NENW?= =?utf-8?B?WEo1ek1ybDhURzErM3B2VHFWOFNTS3JOS0NKamZQZXJWa2ZMcHhhL1JEcUI1?= =?utf-8?B?YU9KZnlPS1NIc3NDZ0hXcDlaMnJXNW5WOEhNVUMyZkFldFhxYUVLUHc1cWJV?= =?utf-8?B?d0R3Ri96K2lGUTV1czQzWHl3dzdJUHczdFBkT2NpZnYvTHZhUXMxV0p5WUpP?= =?utf-8?B?QTZyczI4VU13Zk15RytNK3lpbkNzb0pEVWNRdmZMcnl1dWZva2cwem5KZDJ4?= =?utf-8?B?QisvM3ZpK0pRM2FjVk93T1dRbHVxbGZ3NCtMNG5DWnNXc3VCa0MvZStkT0p2?= =?utf-8?B?WEJBV0J3QmlOYndoY3FGVklNYWN5MU4xL05lb0FndUJieGhwRC8xNjA0Z1lQ?= =?utf-8?B?aFplUjcrZmgwbmZab2VmcDlrQXhyQmJ3Q2RLVTZvdlJ5ZUlWT1NMeTB0NjFv?= =?utf-8?B?SU4zRUdvNlVoNThZMHpqNHNNLytsNTZ1QlJsQVJUYUlkdVRaV2ZsU2Q5dzIx?= =?utf-8?B?VDVYOEJ1M3ptZ0YrdGtYUnlPT091NFhMejVndlZGQlIxYjlGaGtId29IdTdH?= =?utf-8?B?ZHFIYnYwNTZiN09IbW4xK1VxYmxyN0poaDZ6YUtERXFiYzNBRmhjZkNtY0d0?= =?utf-8?B?R0ZRMEYzdUJQdUhmY25RM1NSZWxFNkhUU1VvS2djU2E5RjYxMVZTeWNjYW1W?= =?utf-8?B?TTQ0TTdRbklNSnQzN3RyRTZoNnRjNlltQTlIQWZ3RjNtS3hUSDF5MGxwbmdr?= =?utf-8?B?aGFtRWFDRW5ocUVIdE1jL0pCdHRvR2c2RndqTk5pOGk1ZUFQcjgrMWZFMkdQ?= =?utf-8?B?NWRjTzA5WG5JTDdkdXBDdmhWaEN3MWNabnNuZWRFRFl3UkoralVEYjRrc2pW?= =?utf-8?B?bmdFZjFibFA2OUMzb3o1NkdTdm9vTi91WEdTUHkvQVBvbGREemZDd2dnSVRp?= =?utf-8?B?YmowYytIMEJ3ZnlRSHorbU9uUVZ6OW1JakkwU1NNcTlxaFpDUFlocUdMTkNh?= =?utf-8?B?YmhyZUZ2RzFjR2xxYVVOVnpJcVk4R1ZhbzFaS3cxQVNFQW9Pc1AwQWZNQ1V3?= =?utf-8?B?WHpMVUNVeDc5bmFBVDVpb0FTNDFBL0JidHY3MFdUdTE0WXBBckZQVWxLdC9p?= =?utf-8?B?OTYzNE15ZVRFcWRwZHZtNmNKMUJXSFNxUjQ5a3JyWk83cnVxTUQzcEJPQzhR?= =?utf-8?Q?0uW1LtPf4c5X2e8Z9EKRI8Tce?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 77f40980-f1c7-40ad-5378-08daf3db62c5 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2023 13:54:40.7770 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PcxIjW7TFPzjrc9g8815cBO2A4qjBvxhFlPsiatNZj4DNwJVkZuZ0bA+2/8dbTMDDQC6owX1dFRB+ogtiIVF4A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8551 First of all move the almost loop-invariant condition out of the loop; transform it into an altered loop boundary. Since the new local variable wants to be "unsigned int" and named without violating name space rules, convert the loop induction variable accordingly. Signed-off-by: Jan Beulich --- v2: New. --- a/xen/arch/x86/mm/shadow/multi.c +++ b/xen/arch/x86/mm/shadow/multi.c @@ -863,23 +863,20 @@ do { /* 64-bit l2: touch all entries except for PAE compat guests. */ #define SHADOW_FOREACH_L2E(_sl2mfn, _sl2e, _gl2p, _done, _dom, _code) \ do { \ - int _i; \ - int _xen = !shadow_mode_external(_dom); \ + unsigned int i_, end_ = SHADOW_L2_PAGETABLE_ENTRIES; \ shadow_l2e_t *_sp = map_domain_page((_sl2mfn)); \ ASSERT_VALID_L2(mfn_to_page(_sl2mfn)->u.sh.type); \ - for ( _i = 0; _i < SHADOW_L2_PAGETABLE_ENTRIES; _i++ ) \ + if ( !shadow_mode_external(_dom) && \ + is_pv_32bit_domain(_dom) && \ + mfn_to_page(_sl2mfn)->u.sh.type != SH_type_l2_64_shadow ) \ + end_ = COMPAT_L2_PAGETABLE_FIRST_XEN_SLOT(_dom); \ + for ( i_ = 0; i_ < end_; ++i_ ) \ { \ - if ( (!(_xen)) \ - || !is_pv_32bit_domain(_dom) \ - || mfn_to_page(_sl2mfn)->u.sh.type == SH_type_l2_64_shadow \ - || (_i < COMPAT_L2_PAGETABLE_FIRST_XEN_SLOT(_dom)) ) \ - { \ - (_sl2e) = _sp + _i; \ - if ( shadow_l2e_get_flags(*(_sl2e)) & _PAGE_PRESENT ) \ - {_code} \ - if ( _done ) break; \ - increment_ptr_to_guest_entry(_gl2p); \ - } \ + (_sl2e) = _sp + i_; \ + if ( shadow_l2e_get_flags(*(_sl2e)) & _PAGE_PRESENT ) \ + { _code } \ + if ( _done ) break; \ + increment_ptr_to_guest_entry(_gl2p); \ } \ unmap_domain_page(_sp); \ } while (0) From xen-devel-bounces@lists.xenproject.org Wed Jan 11 13:56:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 13:56:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475373.737055 (Exim 4.92) (envelope-from ) id 1pFban-0007nf-LO; Wed, 11 Jan 2023 13:56:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475373.737055; Wed, 11 Jan 2023 13:56:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFban-0007nY-IS; Wed, 11 Jan 2023 13:56:37 +0000 Received: by outflank-mailman (input) for mailman id 475373; Wed, 11 Jan 2023 13:56:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFbam-0007nL-CY for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 13:56:36 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2079.outbound.protection.outlook.com [40.107.6.79]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c1f28ee2-91b7-11ed-b8d0-410ff93cb8f0; Wed, 11 Jan 2023 14:56:34 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB9116.eurprd04.prod.outlook.com (2603:10a6:10:2f7::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Wed, 11 Jan 2023 13:56:33 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Wed, 11 Jan 2023 13:56:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c1f28ee2-91b7-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z953bz3nFFFaQ8kRRDXismk0G7je/7A7feBoknxMk94W9dqBDDOXX4mEzejOYUSw3B7Gm2NMmgpZukW2t5lpVPYGUkCSlCelD7rN6bMJjHwC0llDL8OBOh1OQnYWbEJYX3kTM82iRHqLLv27sjzLtwosLtL7qO688g9QjzxwGDIgHN+uqUP6cJqF8Dr9iDGYliahGOBv/59fat9luHaLFVVhkqBiClnw5Nk+OmtbAfPTLo32/WmnTN02h8x/k6NUmfa1zGvMXUY3G2Q/hwdd8zYVJQS6pWwR5dq9jDVtYOJRPC98z9xfdZWiXLrAP4BJZLkQ8h8PAmtbxeylI0Gqaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dOlBxwttZ7/+xseKnKOuiqz4kR/3+d88oza4XKWQx5c=; b=Q1F0GUfzbx8Z7UvU8AP+nNyj1rjYDxJ1ByQvE6awNcYfvdXADwXV1/RYwBNikqX8XWKMepjsSwsLiFqbPKOa+ulf5x5FLjtUjYC3gDHMSzCcmmAOSE1RwugoCnXY+pzcc1ekm1JZFeDYQMqHLCEgGaP2XheeW0HbSL0GfS4P7XmOzUVv6viabhuHXXtXQR+gW+8YmCLLB4lmW6lwGdLqxBrdopLfKRTW4DEonhELpNlONWyca/sU8ZJvHVkzUWjpWEK8GWQ8VCSNrg817ewABmRVY4ivcr6e2fI6JSgyqF+jT715XW8F/2sHT5eChtkneZu7tJXAUPi/qxbzW1D19g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dOlBxwttZ7/+xseKnKOuiqz4kR/3+d88oza4XKWQx5c=; b=zoh4veZ5PfqSLe389B4cbTUw2GjeL30lAIp39GgmDuMjqPaDGQwXQ3n6Mya3x+aZe8aKg2gEIrmsKi+DI0EFlcUwDuEotmelba3NFWnbj/DyGovZyCBm3aw4Bip+8VOsGS5vyaUNZxKyplNQmNKsUOnL16yVwDIhGcTY0+r+tFoRcHygdPQ3+qQ67U3XCKuPLElbHZODMf6PuVaZWVx0FuzLmLwP1fHQZXqg0sqHt4my+ptl4fs1vOzAzJpD937p/TexMbUCXPb7NQY76kZNRK/5l769OhKspd8VFjEoeUZkYmDd3RTaBuWLeBVPnFWlCLSdOomfw/VLhOmTbuxeIw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <4785b34b-2672-e3a8-8096-df1365b6b7b8@suse.com> Date: Wed, 11 Jan 2023 14:56:30 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: [PATCH v2 7/9] x86/shadow: reduce effort of hash calculation Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Tim Deegan , George Dunlap References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0018.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a::28) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB9116:EE_ X-MS-Office365-Filtering-Correlation-Id: 91fef956-0412-4031-5c15-08daf3dba5a0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5D8H1G5oecUJkQHviGT+zZZ6KmsDOeRgaOgDikazts7wgSrYXYRltyRh9cP9HxiWIYeayePzRP0CpZgDpExaPme0fTXXW1HpPT6LUJEiIuh7MlrmbRh64+QUeaDKZdeFUDAgBcRWVLK0IOmOajbGy0nbxleD84HcoVq24l0R8s8WhbrnU+QCNAJvYh6bUDWt9PH3wfXJBHklpmNTqSA9/ZRnnYAgaZgo3cWlQ92MzUuVoxqQ3gwsIan2omIxKU+8SycGAAtT/zJ1o4I8NqMZyfRgFcW6qN+3vMuLSvTh8c0Nl6Oj8UipEL4Yu8IR24id1bWMECkSdRBIZMg4JA+x8eOvIUWNDFwl36paZftkxmQryqtCVcRNHMmWLMz6ZNaBh/M2Pvcbw5iq7GBKidkhh/PZcR28PJXqwk5O42yeCdE2O7AG3N5qmdhbkBYMWLN8N/PewCioNlfPTIAlOoTBgwH/z/Ure7Plg8FcWj7uTx0M6RYuV8Tp3OvJ9JzR3QMX45SEfgVTN/k660eAvAjO1WlNrS20lJ6100fED/3se3k8ShIcbmA57eOdkoQpHX3h9oIUE7jJj/cMML4kGQmvLS7B3ULSQBkRpHSviY5EWPKXapIvvJf3vMP9Yn2FVK83mCUfhQJ7f1qFJK3RycR+Hz/0z3B6CGKFPhhIPpMfgG7+j+6kwMBo71I8afZOm5sVmo9DXmzDZlQq8PYg3Wtu57JY1P0Rn6t3ugCWc00aM0g= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(346002)(39860400002)(366004)(376002)(396003)(451199015)(8676002)(66946007)(31686004)(41300700001)(2906002)(8936002)(5660300002)(36756003)(6916009)(66476007)(316002)(6512007)(66556008)(54906003)(478600001)(6486002)(6506007)(4326008)(26005)(186003)(2616005)(31696002)(86362001)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TFdmek02TExYa2h4N2pEUXFNa25uTWJBV2xleFBQRHRjRWJNcjl1SmNrMkEr?= =?utf-8?B?T2NOanRSbWx3Q3BtL0hNK1VkVldnemJTYUphSzY3em1wOFl6Sit4MGxmWGN5?= =?utf-8?B?c2dRSnE1V0FZaVhNcUdhT2V1NVMvcWFKOThBdWFsTTZMRnh4QlZGTVVJQWRB?= =?utf-8?B?dGdPZVlNbFVGUWw3eGNoWTA0M2JuRy9PaDJGUWVUOXZnSWZMMThZbGc1MmVh?= =?utf-8?B?amh1WGZXVUc0TVcydzliZEhDUGFKVHR4SU4zK2pNTDRRTU51U1VkclNNVEha?= =?utf-8?B?QTFyYmNuMDUxUzA2b3FCNnV5OW9VaWpjOUVuWTJxcXZkOXliZ2JMQUJVSGhR?= =?utf-8?B?VnhnSGVwbUlUUWJMK28wcUhyczV0a2xRSTRwczFBTUVqelF4YnNEcUtadmFa?= =?utf-8?B?YTdIVXloK2dVOFMzbFdBSk5Xam04M3FSZGJJN1dKNDhuSmcwWDNHU1EzVmtl?= =?utf-8?B?d1BKbk5lMzRyb1pOSGFvam85Zjh0d3NuS1hGWkhEcnFVRjFmanlDRlNmbDVs?= =?utf-8?B?VmFScFcyWWJCTWRkVGVsUVp4SHQrcXg3cWFEaDhPblRCaFd2MStBdUNFZDJK?= =?utf-8?B?dzh0N1BLSm9sUHFYenUrdzBvQjIwbG5COHhFNUFPRDFrWm56WUszZjhZYVdN?= =?utf-8?B?cW5oakxRRnNvbXQyUHMvNTJheXNPaVgxQ0dlbmszelo5TUJHb0FnZ2g5MGlQ?= =?utf-8?B?WXZNTFpqaFNlMDhmV21iT0Q1V3hpeEN4ejJiUGpjQmYrMjZqYTRoTGRHUzNW?= =?utf-8?B?ZFNBYkg4Z055VFZVcGJSODJsNzZONVRDNGVrOHlwZmpKV1ZsR3BjU0tQcTZC?= =?utf-8?B?aGpHdTRRbkpWd1o1OG5BSFpuOVl4U25WRkM3enJjWUhpUTdJWjlyM1ZNVFll?= =?utf-8?B?d01HRy9iRG1UK1d5ZmVDZDFJTVBiQ1R0bCtDUDhVc1hEYTZmNWxqenpiUk4x?= =?utf-8?B?V0lRNE05N0s3aCtOMFdpM2IvcWloZHFObHFSa2xSMy9LWEpXRDhSa2JsbExl?= =?utf-8?B?SkxFM0ZUOU5RQVprL3RYNjhUNmYzY0IxSzMrWER6YitmYVl1alZ4SFIrRkNj?= =?utf-8?B?U1F3TEk5cG8vRUJPSDQvYUdOWi90Y3dzWE9WMWhXQ29jaDQ1ZnpUWFVhREJ1?= =?utf-8?B?dGdoaFV5aFJzVm9oUkFWcnhPSVhvenZWYWVoK2x6TGJYU1I1WW1FeFA4dVRP?= =?utf-8?B?Uk0vTG10NHdyblprTStCWk9ka1ZJVTF1WTFKVExsMTl6RzVkN3E5SnNJdStE?= =?utf-8?B?SXMxSkVwVVAwbUNrS2p5YlBWVXk1OHE0c29vTVUrYkQ2bTV6TmNSV2dndTNx?= =?utf-8?B?bEcyK3hRTjZYVDhRMU9GYzIwRVNUMGhVMkJXVzJRVzI5SW0vZ2JEVlFrRWJF?= =?utf-8?B?UlhzSkR1TUZNUnNvZGRSQUNDMWtOZGIyOEVocUJQcGdEV2JvWlhweHJsaUpB?= =?utf-8?B?YWhObVUvRjFaeTNuQkcxSjlCOWY5T0xRbi9hSGs5cC9zVWlpakVoYk82eFFO?= =?utf-8?B?eVpmTXNCdXE1OTROeW9QQVZEUmtqOVROdTIxeVEyckJXeFl0aE5MdksybGFU?= =?utf-8?B?MVRReGdXZlBYdVpRaFlMNTl4YkpXeTZ4U1RWdFc2OVo2R1luWDJyMGsxdXVh?= =?utf-8?B?dU51emdGMU1keUM1dHl0VksveitVNDRXcHlzUC9pNW5xNFhlRDhtNWNRZ0Nm?= =?utf-8?B?bHo3aElpZ29GVXJ0LzRwT1hXVFl6MktJY2NyQVlKbnVMZTlrNlFRWUtKaTdp?= =?utf-8?B?STNNeTNUditicGFkUkM4L2JDeDBKT0VKblduNUVGQWtURml6T1l3QzdSNkQr?= =?utf-8?B?ejU4bGNQU1BCRGNyRHQxTzRPdnJqTjdzYXhESmo5SHRyb1NmL251Sk95SU13?= =?utf-8?B?U3ZhbENpbFRXRlJUd1M5WGpaOG9sT3YzRWFzNitocjVqOWVzVERkcWs0NmpY?= =?utf-8?B?RkZxempXVlRzM0lNYlFSYTVSN0hGOW9rZVdodmVuK0pmN0hQMjhGY3JFc2Mv?= =?utf-8?B?ZlpNVTZxSTFuTUtTeHdEZU5NbWNYR0EwUTBUeXIzYWZlTjFmTXdIRFkrKzZj?= =?utf-8?B?cVFEamRab1VpOGN2K0NPdkZDZzZrSGlPU092NnRGc2EzdHNCTjFtR2dnS0J2?= =?utf-8?Q?pAkakPTD2PBzyj1aXfaRBETlv?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 91fef956-0412-4031-5c15-08daf3dba5a0 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2023 13:56:32.9577 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tHszxTT8ffrBZ8Z8eMdO5NeCQq5truvEfqlaFWhfwO2foFKWTbPB/zn+tpAyS9Sk9fDjwYbs/fR/TedndyqQ/w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB9116 The "n" input is a GFN/MFN value and hence bounded by the physical address bits in use on a system. The hash quality won't improve by also including the upper always-zero bits in the calculation. To keep things as compile-time-constant as they were before, use PADDR_BITS (not paddr_bits) for loop bounding. This reduces loop iterations from 8 to 5. While there also drop the unnecessary conversion to an array of unsigned char, moving the value off the stack altogether (at least with optimization enabled). Signed-off-by: Jan Beulich --- I was tempted to also change the type "i" (unsigned) right here, but then thought this might be going too far ... --- v2: Also eliminate the unsigned char * alias of "n". --- a/xen/arch/x86/mm/shadow/common.c +++ b/xen/arch/x86/mm/shadow/common.c @@ -1397,10 +1397,13 @@ static unsigned int shadow_get_allocatio typedef u32 key_t; static inline key_t sh_hash(unsigned long n, unsigned int t) { - unsigned char *p = (unsigned char *)&n; key_t k = t; int i; - for ( i = 0; i < sizeof(n) ; i++ ) k = (u32)p[i] + (k<<6) + (k<<16) - k; + + BUILD_BUG_ON(PADDR_BITS > BITS_PER_LONG + PAGE_SHIFT); + for ( i = 0; i < (PADDR_BITS - PAGE_SHIFT + 7) / 8; i++, n >>= 8 ) + k = (uint8_t)n + (k << 6) + (k << 16) - k; + return k % SHADOW_HASH_BUCKETS; } From xen-devel-bounces@lists.xenproject.org Wed Jan 11 13:57:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 13:57:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475378.737066 (Exim 4.92) (envelope-from ) id 1pFbbQ-0008LM-V4; Wed, 11 Jan 2023 13:57:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475378.737066; Wed, 11 Jan 2023 13:57:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFbbQ-0008LF-Re; Wed, 11 Jan 2023 13:57:16 +0000 Received: by outflank-mailman (input) for mailman id 475378; Wed, 11 Jan 2023 13:57:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFbbP-0008Kv-Ik for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 13:57:15 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2046.outbound.protection.outlook.com [40.107.6.46]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d904d9cd-91b7-11ed-b8d0-410ff93cb8f0; Wed, 11 Jan 2023 14:57:13 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8073.eurprd04.prod.outlook.com (2603:10a6:10:24d::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Wed, 11 Jan 2023 13:57:10 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Wed, 11 Jan 2023 13:57:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d904d9cd-91b7-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WkxdgB88KE20zyOORVTy4RosbNtgrxGjpkEM4pysQbT6Xyuok9jeYshiM5nlk1quYhhnR/AfPYh+iLgpZESwSSe0eTOtGfz+cEimMVJEnSRjIy8t4wAMp+z0OgQDDLOAk2vDr7NRSa/MfljoqUB/7I8Wj8LPHO9PPvFd3N35vkppXmRQPNURGKz7m4SbjKz4CTvW0RlHD58+Ye1QaR2uSdszSG3RpNUpWF6P8/BKJanme3WMkc171FwXK90CDfktz08xJj30uslkkx1cedVju1E082c5NVM8hPnvwj5Ea5y1OXOQbhfeEVP3gIryZ1YINutue9mRIb54p6mkPL5Oaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4uJicMk7KMO3J5OufWXUur+3R2HmbLQ7mvJAVkX8lh8=; b=oMaoI6rCBCF4h4BIMNx5AZVZaysitmIpl4TslSq3cA9CRJuaJGk2K1hpEbet1TY6Ww2SYu4QXKUkA8994sbkVYCBbCQFi0rK1ye6W9Mzk77h9zpO3zWFx97KSDdl1Pl5KDOz4JTuc0REUnlkhA9ir0NGxThmGwGYIGPW2Mdjz8qA6bhXKvM3OPj9IojyY2iCHBbrSj9LxCxVPeHBCfPeJjczUozxgUjNHSPAzEESz61nk7sKAXviTYM9xjOv0HabjZV5+okcXg7pouU6IBDkY+SD9tkhq5jtvCs/KeRhxqyeQy1PHp27dsfzb2j8EE457wduSTwBHauezRNEYUPGgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4uJicMk7KMO3J5OufWXUur+3R2HmbLQ7mvJAVkX8lh8=; b=nqmqe3S8mTfCKPnKooPJn3xO7qpQ2zgZehLK8bKuRblnamQ4eY2+ube8v+U3MCnVCpySm83FwL4HNEW/bJ4adUvaIhvHGOBeCTp44bBSsjd/zslBzK2UfljntcWeVIgjz3n08Xaqmd2T3Kei62q1umZ0ypAILWfY0E9+KlIhRviEbqBmewGlaLmPPd4CkLEIwlk84SbPtN15FQkxjjoqP7CGvu0uG13ZDvi2zr/lgOfpkW+SZc4Y1BxOLd46s6lpYBAOTcEUhettJzN6waR0HjTlSXy9HD8IQdQX985Qz1E0AV9RiFFuB0yrAvBs/XBdzAMyL+/NQW7V22i1bwb/RQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <8ed7a628-f64e-5512-efdb-4116a7b88a1d@suse.com> Date: Wed, 11 Jan 2023 14:57:08 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: [PATCH v2 8/9] x86/shadow: call sh_detach_old_tables() directly Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Tim Deegan , George Dunlap References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0013.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a::23) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8073:EE_ X-MS-Office365-Filtering-Correlation-Id: 20e7719b-0f12-4f63-25a1-08daf3dbbbb0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZgIDrbmRswtSGvu6MoAAcu7vvOSz/wPQRTry08dJSX3634u1ry+j3My45I9rbrN8h+cYbw+JkOoE7FEvS5jcIwWc9vdviTyT+9+oBWj6XV3Ngbc5fq7EqluLonco25s3apsYZ4jO1BvXC/DjH62lpQ7QSJfA02D1axIsluS17jXRnPwsA/XDrrQSCANTsKcMCavjfaJwcZBoQGHtNtXB/DOw42bwMAi3/7GZ8q5zIalYF9ENQUwJqyiIp/Ed+HmrbFc9B9hbjQIyHSaXlcfOV+vGc20a1uOzJKJCRknaQvFLWKj4NYXL2jIKuAZaeg5eW4mQ2J+huNtXdS/saTeGUQr99gTSwNRBZ3pFz3LMi1/R3vbO6g1Bs/pI+3o99sHJsL6qqojXUTribFiZh+R7XMmOpZ5LiukOcmnmeqIKKSe34M/owp1EizLyrc6kAnQVLl8NcjCcOQaBDwxUfMpazEHJytXzaWjuTgXFQFZVa/21R1zDEqZA9Bfd0ykzgUwfxGNVqItNQPWb/GKX0e8D4zZhESYo7ipJ5wheM3OlybAwo2+kv0tu4De48TsehZBRWg9SCoOywZUbRSeCuTx2OI3l3kFVfimbs5DRvd7rTyelb+6aM3GHUYricboHX+yXgQuE2OnYvD9K99xCejeVOP0E3LEfUJ8/NcIgnzcVkVgzi2yHUFyH+eL+yqmyPzr3eNTPNA/yU3xdS8SlEo4yoZuEu3k9tIhnQlmWlCvj8tY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(346002)(39860400002)(366004)(376002)(396003)(451199015)(8676002)(66946007)(66899015)(31686004)(41300700001)(2906002)(8936002)(5660300002)(36756003)(6916009)(66476007)(316002)(6512007)(66556008)(54906003)(478600001)(6486002)(6506007)(4326008)(26005)(186003)(2616005)(31696002)(83380400001)(86362001)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZktyME1BTHMycXhOSTJtSTJvNXdzYnhmSWc5WlhxTlBZQzFrTE8wMzVwRWFl?= =?utf-8?B?d0NtaU9JOGRmV05DZTh6OEdSdmVIQmwyeFUvVnkxY0piSmZPQStXcnlFUnkr?= =?utf-8?B?cFNTcGVCY2drUVNnN2pEWUlWRU1wYmxCNnM5NndMUFcrTE9Va2VzTnNVa3lE?= =?utf-8?B?aVIwUUkxQ1RMdkhtOGhzUXZ1OFhzZ3NkaHJ2Y0MxM2kyZTA2QWprVG9VZS9v?= =?utf-8?B?NGh5YnJmcy9hREdGNG5SOWl5M214UDNNL2ZjazhXZEZKR3pMV0JJNklCNjU3?= =?utf-8?B?cDBIYUZpWmU2Skw3Q1NnYmFnOU5HOTRKM01mSDMxbzQ0eXNuY3A4VUZ4cFBz?= =?utf-8?B?Umc1NWdsU21PU09ONWE1dGdpVm1MOXpXSHEwMUx0QjVyMEtVSlFHT1JOQ1Fj?= =?utf-8?B?LzlIK0hZb2FYRWVXVTRkSlJqTWdPSnpFcUZteEp1dGNyZXVUajl3SlhCWHlh?= =?utf-8?B?S0JvOGZLM0Z4bllURUUrUTRGbmxUMC9YalhTWktjVUlMRldpMUVET3VTR3NE?= =?utf-8?B?dmdkZXFwMlI1a2d1UTF5RngwNklmUlV3eUhEWVN0UTlMTEtEdFc3TStURHRQ?= =?utf-8?B?dWdReWdWeXVaQlZxY21GM1ZMd2JrNFlpU0pkSTdRcC9aM0lsNnNINysvVUJo?= =?utf-8?B?WEI0ZFpnbHVJT204d29LekpGZVdCaHp3WmdNRUdEMXdrSDZoYWZCNnVPV3Ev?= =?utf-8?B?Z09DejlGWHRZOVl2ZlFkbXViMHh3N0cxaDlSQlV1ZElTSis4ZTdZRHJ3TGl3?= =?utf-8?B?amU3bUNYZHJIMzFIN1NpRE13Z29NbHNLTzVlbkg5Z3o0NTNXN2R4NVViekxh?= =?utf-8?B?MzhCM0VKM1hOWVQ3WkVrSzlseGtrQzJOc1g4dWxYbzI2aXJxVVVudjU5QzZB?= =?utf-8?B?a3JaSkM4RURYcm9mR3o1UFpaNFVQZ2Q4QnRqbGZwQko0Z0RGSEZOZ0VDUlVq?= =?utf-8?B?N05jSG1DWUZ1djg0dDNiNlpmSEVvK3h0dVdzTGUzK1ZmTG0zYTl2eXJwc3pV?= =?utf-8?B?OEdsSVVmcy9kVTFiTGh3L3Q5UW9OcW5ReGY3UWd1Szl0QWdHaDJUSkNDa0Z5?= =?utf-8?B?bVBHd0NzWVJ4NXZ2L0phWXNTdExBMW9aOE13Nkplc2lrMVROOGRKajNCUTZB?= =?utf-8?B?R3BEZjdpZFJhcklDM0hzdUpCRkhZSytLSzZ2NWFnNWdyYWx6b0VHQUIvOW1R?= =?utf-8?B?VHR5OVhVZ0JMdGRKTGQ5cTJFVEJYWjFvTVE2Qk5EWTNnR0svUjdTRzVER1Yr?= =?utf-8?B?TCtQWms0Q3FVUVY0VitJUXAwNlVvUFQrL1JuWktNaG9SbHRPbkoyL2wrQW54?= =?utf-8?B?Qm9DQkFvWEtzOWNaYVV2Z25DYVZhVm8xcXFlaW95TGtyQXdtYzFOUnd0cHQy?= =?utf-8?B?TSt5bjNVMk1KN2hUaithMGE2WU9vRVpucElHb21JbGxHT1FUSXRSVzZlMXIr?= =?utf-8?B?b3JZM1pIdk9MNytyQzNhWDNwZnFzOUZCa09FcUxaODFnQTVoN29JNmlKUGJl?= =?utf-8?B?UDJJUUtCN2RycWNSRndKSmJaWmYyNkt3VFBta3hOQlF5V0FLZW9ST2JGbDMx?= =?utf-8?B?V3ZGRUQ0WHBlaXQ0ZFBkeDRQL2Q4OHlOeUlSemxlM1kxRzMvSUZRYXUrRkdi?= =?utf-8?B?ZFRLYlRBZUNsZVRkU2ZzQVkrYTVZNWhIVVR2bTNNNDBzSzVxVXJRcTltOE94?= =?utf-8?B?RjNCY3ZuOERUVnptR2VLYW1qdmUwVU1zUVQzN1VHK0JyRTlmOTVlZlZyd3Na?= =?utf-8?B?RzVTZFRXMnp5M0VRb0pTZGdENG5saEs3MFFDa1UrYitWWStoU2g5bU9sRDV3?= =?utf-8?B?VEx3cUhnbXZ3bnNkclJlZG1xbVdWU1hETlU3S3ptOENDVEhFSWVEeG1xbUFp?= =?utf-8?B?OTFPaDhUTlUyei8yWjdXdnZOWHdBemVEeG90N3M2cmVZZ0FVZkNlL05Ic2VG?= =?utf-8?B?bm1aVTEwRXBEbTBkeEhBTnI4RW1pbHpYVFo5RkxpaVorZ3Z3RHRsaWFJSFNx?= =?utf-8?B?Qzk1ZGUyWmdFNkZEaXJEREFpazRyZjJiNEZiRmpuUDZpczg4K3JBWUxWbWt4?= =?utf-8?B?dGE3UVVuTjV2SXgvUjhkT1pCZW1aSWFMd2ZSOGROUVhyVlhacWQ2VHFxbFdv?= =?utf-8?Q?rlnuLGjl/kkkMqVKnBFdTycSf?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 20e7719b-0f12-4f63-25a1-08daf3dbbbb0 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2023 13:57:09.9710 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +Vq5kjVN7hzmzI0kfPp2Xo60nZXLZRWRwkdQFhwAZ+gM4VOpt2VsS7kUEHIVAUs+Jf4so/fkWL3tyupUAX3Z7g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8073 There's nothing really mode specific in this function anymore (the varying number of valid entries in v->arch.paging.shadow.shadow_table[] is dealt with fine by the zero check, and we have other similar cases of iterating through the full array in common.c), and hence there's neither a need to have multiple instances of it, nor does it need calling through a function pointer. Signed-off-by: Jan Beulich --- I've retained the C++-style comment in the function as this style is used elsewhere as well in shadow code. I wouldn't mind changing the comment to conform to ./CODING_STYLE. --- v2: New. --- a/xen/arch/x86/include/asm/paging.h +++ b/xen/arch/x86/include/asm/paging.h @@ -98,7 +98,6 @@ struct shadow_paging_mode { #ifdef CONFIG_SHADOW_PAGING - void (*detach_old_tables )(struct vcpu *v); #ifdef CONFIG_PV void (*write_guest_entry )(struct vcpu *v, intpte_t *p, intpte_t new, mfn_t gmfn); --- a/xen/arch/x86/mm/shadow/common.c +++ b/xen/arch/x86/mm/shadow/common.c @@ -2264,6 +2264,29 @@ void shadow_prepare_page_type_change(str shadow_remove_all_shadows(d, page_to_mfn(page)); } +/* + * Removes v->arch.paging.shadow.shadow_table[]. + * Does all appropriate management/bookkeeping/refcounting/etc... + */ +static void sh_detach_old_tables(struct vcpu *v) +{ + struct domain *d = v->domain; + unsigned int i; + + //// + //// vcpu->arch.paging.shadow.shadow_table[] + //// + + for ( i = 0; i < ARRAY_SIZE(v->arch.paging.shadow.shadow_table); ++i ) + { + mfn_t smfn = pagetable_get_mfn(v->arch.paging.shadow.shadow_table[i]); + + if ( mfn_x(smfn) ) + sh_put_ref(d, smfn, 0); + v->arch.paging.shadow.shadow_table[i] = pagetable_null(); + } +} + /**************************************************************************/ static void sh_update_paging_modes(struct vcpu *v) @@ -2312,7 +2335,7 @@ static void sh_update_paging_modes(struc // First, tear down any old shadow tables held by this vcpu. // if ( v->arch.paging.mode ) - v->arch.paging.mode->shadow.detach_old_tables(v); + sh_detach_old_tables(v); #ifdef CONFIG_HVM if ( is_hvm_domain(d) ) @@ -2700,7 +2723,7 @@ void shadow_vcpu_teardown(struct vcpu *v if ( !paging_mode_shadow(d) || !v->arch.paging.mode ) goto out; - v->arch.paging.mode->shadow.detach_old_tables(v); + sh_detach_old_tables(v); #ifdef CONFIG_HVM if ( shadow_mode_external(d) ) { @@ -2935,7 +2958,7 @@ static int shadow_one_bit_disable(struct for_each_vcpu(d, v) { if ( v->arch.paging.mode ) - v->arch.paging.mode->shadow.detach_old_tables(v); + sh_detach_old_tables(v); if ( !(v->arch.flags & TF_kernel_mode) ) make_cr3(v, pagetable_get_mfn(v->arch.guest_table_user)); else --- a/xen/arch/x86/mm/shadow/multi.c +++ b/xen/arch/x86/mm/shadow/multi.c @@ -3207,30 +3207,6 @@ sh_update_linear_entries(struct vcpu *v) sh_flush_local(d); } - -/* - * Removes v->arch.paging.shadow.shadow_table[]. - * Does all appropriate management/bookkeeping/refcounting/etc... - */ -static void cf_check sh_detach_old_tables(struct vcpu *v) -{ - struct domain *d = v->domain; - mfn_t smfn; - unsigned int i; - - //// - //// vcpu->arch.paging.shadow.shadow_table[] - //// - - for_each_shadow_table(v, i) - { - smfn = pagetable_get_mfn(v->arch.paging.shadow.shadow_table[i]); - if ( mfn_x(smfn) ) - sh_put_ref(d, smfn, 0); - v->arch.paging.shadow.shadow_table[i] = pagetable_null(); - } -} - static void cf_check sh_update_cr3(struct vcpu *v, int do_locking, bool noflush) /* Updates vcpu->arch.cr3 after the guest has changed CR3. * Paravirtual guests should set v->arch.guest_table (and guest_table_user, @@ -4211,7 +4187,6 @@ const struct paging_mode sh_paging_mode .update_paging_modes = shadow_update_paging_modes, .flush_tlb = shadow_flush_tlb, .guest_levels = GUEST_PAGING_LEVELS, - .shadow.detach_old_tables = sh_detach_old_tables, #ifdef CONFIG_PV .shadow.write_guest_entry = sh_write_guest_entry, .shadow.cmpxchg_guest_entry = sh_cmpxchg_guest_entry, --- a/xen/arch/x86/mm/shadow/types.h +++ b/xen/arch/x86/mm/shadow/types.h @@ -236,7 +236,6 @@ static inline shadow_l4e_t shadow_l4e_fr #define sh_unhook_pae_mappings INTERNAL_NAME(sh_unhook_pae_mappings) #define sh_unhook_64b_mappings INTERNAL_NAME(sh_unhook_64b_mappings) #define sh_paging_mode INTERNAL_NAME(sh_paging_mode) -#define sh_detach_old_tables INTERNAL_NAME(sh_detach_old_tables) #define sh_audit_l1_table INTERNAL_NAME(sh_audit_l1_table) #define sh_audit_fl1_table INTERNAL_NAME(sh_audit_fl1_table) #define sh_audit_l2_table INTERNAL_NAME(sh_audit_l2_table) From xen-devel-bounces@lists.xenproject.org Wed Jan 11 13:58:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 13:58:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475386.737077 (Exim 4.92) (envelope-from ) id 1pFbc8-0000YC-9I; Wed, 11 Jan 2023 13:58:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475386.737077; Wed, 11 Jan 2023 13:58:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFbc8-0000Y5-6b; Wed, 11 Jan 2023 13:58:00 +0000 Received: by outflank-mailman (input) for mailman id 475386; Wed, 11 Jan 2023 13:57:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFbc6-0008Co-5B for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 13:57:58 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2068.outbound.protection.outlook.com [40.107.6.68]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f3a98656-91b7-11ed-91b6-6bf2151ebd3b; Wed, 11 Jan 2023 14:57:57 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8073.eurprd04.prod.outlook.com (2603:10a6:10:24d::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Wed, 11 Jan 2023 13:57:56 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Wed, 11 Jan 2023 13:57:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f3a98656-91b7-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TSRKM4oRF64gC77pPF7nUVgW9tf0uMUPNbvDdzwKSND6YmoJUfF0iuVSTtzSaYmNkSCX8TEHXa68Pm+0oRj5ciyS3hRsvNMdR30ao483g5gPf0bv8VwRtd1qWPszc7w9Sx47PS8kzY37oluYMRNkVQR243c0L7F+z+063GgedLF5tncE9JUitRgzKj0gAftE5TG1HmoDiJcdPEsrmUDYHyVTRlIc5bKCiojTWN8S//Pi4enidjmE5yxRv5TCt3lbi19HZnTkGrgaVZp8xvbGrmsl5vtYE6vvs/fTuqN4vHT9bRAKZsZ0F9DvEnXZ4FP75tVihJVYkZgsAudVgKZM4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bY7YXGCVxaLa3//TMr+/cVinLxzirB14/tYwJGkYJjk=; b=hNLalCz4m6o2ykOlQQqlaXVOBukHG/SzuXvBpL6I5w0hkkZ8sND+rODYbJhiH9fxxfgQ/JDfZdI1Jb/uXidSrHCMLL/J68l3rxrOaYX+e04eKqR1WRMiU52Bw3/ezmfgpcKdbBBzD9M0+TYeYyknAx/uHbPpLAVxjHhNSwvgPPT2PfDvp0Y/A0mO13PFupLAeVeMNEOA2cI0n1fEsjr8BluLqHsOXlQm/SPKilIAdpbNIMJ542CfeV0x6x0DvQ9Wz1Io2X8U7TamTKAf+w1bxySpLgQ/rDQo0iHKZZ9OlmCZkpObocl2jBmameezeLH9uSUbAQiLlzaq1AWGH5QUFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bY7YXGCVxaLa3//TMr+/cVinLxzirB14/tYwJGkYJjk=; b=N15A5ATS7ywjuhcOKx2GNBO/I77JMKDUY5NiRnwW0ihxCok6GzCNdKVxNM+UKRew7PFspHLI6Ke7RKwxnEAXRxrcDhh90l2HIk1ez3oVS4BmNYys3Quna7BcUZGlW/rPUbh9xX/1nz7jkEVw/KwMrpuKLJQymjoAmxq+qtdyaVnP0aD6h2bTGiFbEATGwNDQMaVVIis+CA0L5gFTygdC5MJQc/9Pyi+M62Pm3GnEwaqKpPoXWKIscq4OymCv+OVllyrvZos45eYzSOt6NDQenUy2e56RQWu+mVAmyh5YBZ5HmBrUcTmnwzVIUKwHX031ShxldS7rDUbcfOEoGgLfrA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9bea51eb-4fbd-b061-52d7-c6c234d060a1@suse.com> Date: Wed, 11 Jan 2023 14:57:54 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: [PATCH v2 9/9] x86/shadow: harden shadow_size() Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Tim Deegan , George Dunlap References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0175.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8073:EE_ X-MS-Office365-Filtering-Correlation-Id: 7e217842-588d-493e-9601-08daf3dbd751 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VZsiGfwYLcPJVSOfMGpKtPDMqAtgpCG3tRjXgraxkoxOwP/vfVnUVrOWXD7eA7crR7rcnHAJsbW6QxV49Y29YxfC51Eez7ATGuh8k7UclifmXlunV8HIHe9tdMWqEjQ/FkPVz3zGBI64PRG/uS6ae6U4/aT80Ck+D9fsnoaolM1HxUk7hNZYZQbXyTtK+zIocV5MIjvcvsbvCyKB8vLZQXVrmh6WFMFiunp16NHmlTnTzM42pRoZlOVNBFmzm38ajohznsS10rEomS6bL4nZWbUC6JcbYtHhef/TBapRrYGubtJCkJYryaGBiBh12QmB/QzeWMReX+16YhQgzXknWnskOsJBN75ogglRB7TSwi+7jjBGT4cVmcFUMuQe3PeM4Wr+OWmeN/ywSxdgLsc0d51P87UwAIPoISZ/OA1bEGJJu4NH8qP3AwBVmSt17+wI7Y9WvUsQKgfx2/rK8+TA+NEpvnUt9FRdEjV7hD32TNTUMUKxF0sTJknXaVsW/AH4I6CfHOnNFs1STYQybiVRhYmq81dNEl8832LKn0Nh1SVsotRpyuboolVqf2+I4pQxJgHCH5Po752CQ0f7V50ZRRaMXveI+ejZ77OUDAdCIqEttnFcx3eqgtjG1OTj6QEP2SyMqPDWcJK9WPhcZIudEq7mch0/xLfRKcngvOGoX870MgMCZ4HERAZVI0+hw5U3/p4bc7D5O8kmLi93aVMNbZNeV7PaqWLI7asoaooh1Nk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(346002)(39860400002)(366004)(376002)(396003)(451199015)(8676002)(66946007)(31686004)(41300700001)(2906002)(8936002)(5660300002)(36756003)(4744005)(6916009)(66476007)(316002)(6512007)(66556008)(54906003)(478600001)(6486002)(6506007)(4326008)(26005)(186003)(2616005)(31696002)(83380400001)(86362001)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SklXSXNLMGNmSFRWYUdoNmt4NFJRb01aYVNVVjlTaXdRMmliYUY4VHdNZElj?= =?utf-8?B?dFBnY042d05EQ0xNUzRxcSt4Mml3aVY1Q0xaeVJFWERoUHpqQjViVFZBN2ts?= =?utf-8?B?VUZrcjNIOG1LZzlleFEyZm9RMG9DL0ROckRTaXpOQm5DbmhieEEwVEFxVjhj?= =?utf-8?B?WENpSHVKRmpaZE5CeUd0RWNxdmR3WEFDZG1IUDVVK3AvT3djbGcxMVJFcWI2?= =?utf-8?B?TC9WbnhRWjJrNEwyZTdOWU9pNjZFRlJGVmJxbS9TUHlCUndBK1RBdGRnTUFG?= =?utf-8?B?Smd1T0paR2xXNkdLWmpqTWQ0cUcrR3lMaXoyR2Y4aGdkT2Vrd3FWeXNRRzN4?= =?utf-8?B?aXhMcjEraGE4QTRmaDNpdFdjVWJmbHN5bTNEdTZPSWpxR3Y0QVQ1Y2NlZWxs?= =?utf-8?B?ekNmcHNVaHMvSVVmRFBENXI1Y05wd1ZFQWxWVWZCaEp1MUxDN0xodkZiV0xW?= =?utf-8?B?RHowRU4zM1ZsT1FRbkZGZ1drVHlrenhKbVVuaEg0SE1jc21ZNFVMd1BYK002?= =?utf-8?B?Mkc3N1Y0MjQzVXhEd3haSlptS0JxV2hBaHp5NnJuR2Eva2FXc1hRbXNSS3dW?= =?utf-8?B?d0JVdmVWSXZMaldBQ3lvSW9MVW1LSjh4M3RFNXV1OHZZN0p5VzdCdG1ySXhG?= =?utf-8?B?eEhxYkd0NmNzVlUvV3FSS0dNRmw3N0xQQ3h5ZmZGazNIMVJQTk93TDFnYXdo?= =?utf-8?B?NFRFdmFkeUhyTit2ZXZPbUM3Szh3aDZ1VkthT3VRcGlleWlsZlFzdjY2MW1j?= =?utf-8?B?SzRYd2xGdHJtTW83alFHZWVRdEJha0hvQ2NxMjgxaFdIVVhuQ215SDVtcFoy?= =?utf-8?B?ZUVwMnh1RGZFaVpTZUEyRlBhUXVXaGRialo2Yk1SSnhaendSTlBJS1Z0K29w?= =?utf-8?B?Y3BDL0htTkJPWFZ3bURxdlRzYzlyTlFjaUlZM0R6MC90clAxSXRxTVJmNzJ6?= =?utf-8?B?cnVNZFJ1azhHK2tSOGdrWExYSm5uQm1UcGhnc1JWZWxOR2sveXJqRnQ5QVQ5?= =?utf-8?B?dFZFZVg1VEtXSlFIYW9zTFMxb2J2WTdTRS9rS3lVMmdaSXBGQU9UVmMwN09H?= =?utf-8?B?c0c5cDV3ampSMWZ4eHgrRFNpeEFlSDJWM1N4aW9PL1RFWjEyMGE2SDdQbDQy?= =?utf-8?B?dWhkWXFWL0M1MDFrRzRXKzgvTHo2WHVUWGpFNnhMYzBpU0t2RTdVMFBUSWYr?= =?utf-8?B?UFpoTFFtbXVDcnB3U3Y1RlJxWEd3eE9NUUxVWHg3RjJBS2FiUWx2ZFFxZFlw?= =?utf-8?B?Q0hnbXhqb3Vad3A2c0EvVFUyNm5pWlRoYWFIRG9xL3BvNTYzTzdSOEdqY2x4?= =?utf-8?B?bm9NWWRKY2FSN1c2bkV2c0RrZ0hmNDk0NmtRQ1VQaVIvYWFIS3l0UGVmQnY5?= =?utf-8?B?d2VjOTIyaXBQdWczSWt6Z1lGZG9wbXJ2a0IvWjJPMXNxTDBmT0xidFlXR0l0?= =?utf-8?B?bkdUTm85ZGZOd0cyUXBuYXhEalFJZ2FzRkRiSWNlRDhyL3RVeGphM2d6NS8z?= =?utf-8?B?bk5yc1ZjZnFTL0Z4WXg5WHV5QldHM05ZK0ZpRXhwSzk1SHVrSjBKWUdreGUz?= =?utf-8?B?bkhiTmhhMElzUWs5T1VPUGczZEVKM1prclZaWlBzWGRuS3JWYXVKSmc1bG9q?= =?utf-8?B?VXlmSFJIRlR1TXk1NU13blNRWXRhaWFKekZRRWhFWVFXaUgzdU9LTE9KeENq?= =?utf-8?B?cXB3djBHbCtvZ2swajhuV0V1YXdtTDZHZHhZZ0hzckpnUTRDeDFVTXdoT2JP?= =?utf-8?B?VlRJaDRFMEUvQVdTVDd5dEE4YnFIcmQ4QXAweU4wNnp5a1dnVWZPbmpydXhN?= =?utf-8?B?a1daN1FLZmtOeEFCOWdjRzZzWVdhVHJHdTlXRTdMOFpCanRUekJ0OERlLzF2?= =?utf-8?B?Zm96a2I5aHhURWJyRjJ2YWkyaG9ldVQ1czVhZFc0Y1gwS1p0dzI0cjlrQng4?= =?utf-8?B?dEFlZGlFOVVXaVc2c1Jpd2ZraGZhaWluY3ZKWUhiV2pYQWpoSkdOOTRNZHlk?= =?utf-8?B?THV3bGZqZzNwT0NJNWZRWkNoUXAxblYwbFQ2MWRGbWJnbGt3dGVmSEhaUjND?= =?utf-8?B?cUhFcUhTalZOM3NQTzVzSjZGMDJvNGdkVUxiQlEwLzl1SXc0eEtrbGRVL1R6?= =?utf-8?Q?YLX1ZvyxHW57hGX7+O2wCHpOf?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7e217842-588d-493e-9601-08daf3dbd751 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2023 13:57:56.3119 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pNl8/x3onggPgJYTTXZSXr9YCczCD1KgrwhkC/lBGac3cJeF+R61O/ju2UbgrjpkCx/Jb9QOq1oFBgqWWxTkVw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8073 Make HVM=y release build behavior prone against array overrun, by (ab)using array_access_nospec(). This is in particular to guard against e.g. SH_type_unused making it here unintentionally. Signed-off-by: Jan Beulich --- v2: New. --- a/xen/arch/x86/mm/shadow/private.h +++ b/xen/arch/x86/mm/shadow/private.h @@ -27,6 +27,7 @@ // been included... #include #include +#include #include #include #include @@ -368,7 +369,7 @@ shadow_size(unsigned int shadow_type) { #ifdef CONFIG_HVM ASSERT(shadow_type < ARRAY_SIZE(sh_type_to_size)); - return sh_type_to_size[shadow_type]; + return array_access_nospec(sh_type_to_size, shadow_type); #else ASSERT(shadow_type < SH_type_unused); return shadow_type != SH_type_none; From xen-devel-bounces@lists.xenproject.org Wed Jan 11 14:11:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 14:11:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475392.737087 (Exim 4.92) (envelope-from ) id 1pFbp1-00031X-En; Wed, 11 Jan 2023 14:11:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475392.737087; Wed, 11 Jan 2023 14:11:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFbp1-00031Q-Br; Wed, 11 Jan 2023 14:11:19 +0000 Received: by outflank-mailman (input) for mailman id 475392; Wed, 11 Jan 2023 14:11:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFbp0-00031K-1T for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 14:11:18 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on2053.outbound.protection.outlook.com [40.107.8.53]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d02b5c98-91b9-11ed-91b6-6bf2151ebd3b; Wed, 11 Jan 2023 15:11:17 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBAPR04MB7350.eurprd04.prod.outlook.com (2603:10a6:10:1a9::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Wed, 11 Jan 2023 14:11:14 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Wed, 11 Jan 2023 14:11:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d02b5c98-91b9-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dpR0656fUdv6dGf4ZoB6GU9xbwXNK2jko6PvMOU43awudUlJYNAbAUhwBQp6JVcumw3vUrl/P3aOib8aMaXcKcT1sH+xcSQZiO+aggu+8dZtchBZ8FxUXoRcudvWC1YwYKaDqNKTRFI6pZA/hirXt0futXBfmuBsyLqvXwFQagiuhQ4cW17YDD237ZhyBIWfEzLPlyZGf9X93PvSAE8YUACm/ACcA36RMCSoyR2sAEmpCaA7ALIMmfW71FpEsx59aqz1xmvor1Cdy0V4amF8uXHEWXbZ0CUi968OIDnL8Tw6a4ssXP+9pEWM7IOFQTFbm3LHxLn8VD6hLor6lsXKpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=samdL1jok7HXUArxo1y7qppuzAQBeGFzLeWWO6WNryw=; b=YeRUFxWIM8T3f8f898L0IfCTpTz0xbl1CKjrS8RJ0vWunLnsXXmFud4QM3dWMYRtSAkDAR1BSshenZI6fqxthVtDqkWLB25EwVAmlxnsAox6bR6uuzBNUZ3Af1Qjk+HAF861VNvybk80m9Sd1rxXdQqjXKcEyHKfOe1iIDtRuz6vFCph6gbWxaBklrM0nQojPS9oG3M5LcXvW75gt0sT9DqK0raYlLCiATcApufCFodgSUMWePax8IQwbfHcQr1/+OwhHeAYzMC2Ae5ouFQBufhhnrZOH3cN4nRR/16SS8S2e12hDHNJuRrzu1pbw079fp1ZddaNoYLUDJRyilydCA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=samdL1jok7HXUArxo1y7qppuzAQBeGFzLeWWO6WNryw=; b=qy3pTWyXdi8str371y7RgG/kAz7QYHMSATdajMZ1LN5OVZo5xxgYfrnW1UVuyJhpReB6t+xP3fv/qnzkc5h7nuRWZQ4EEgDe9ZL3GxHoaVsc68hYJKK6KZCR0S35rNZBg/ffN4vfeXul0+bFXA+8j2qI6Gn6p/p2vbid2EiEm5AF1ghuqauk4T9a7h1BpS62v4aVruVZJSzC8AKxUXmQReOvp/NPRXLsLh4Xm+Qy+U5jW6JiATq7P2Pm5I3Gh4ObVXGEiWOZ3D6pzgVEHmt1dCPMSeX4TB/sW/FRVGbFxsz958q4EfB1dTcqcLY876bYdkBL5bZai2fIA/PIOvzRqg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <52429554-1559-6bae-f3d9-d32152e763b4@suse.com> Date: Wed, 11 Jan 2023 15:11:11 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 14/22] x86/domain_page: remove the fast paths when mfn is not in the directmap Content-Language: en-US To: Julien Grall Cc: Hongyan Xia , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Julien Grall , xen-devel@lists.xenproject.org References: <20221216114853.8227-1-julien@xen.org> <20221216114853.8227-15-julien@xen.org> From: Jan Beulich In-Reply-To: <20221216114853.8227-15-julien@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0129.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBAPR04MB7350:EE_ X-MS-Office365-Filtering-Correlation-Id: ffee38c1-f8e3-41fa-d850-08daf3ddb2bc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oWJG2y0e1e5wnw9wzE9jhnk8PGd/pYfq+rowrPesldxeli8SoPRf5/Aesssr5khIUTjreYkLkBoHmI9YxJ2YV4PFEDrC40uPtwX4fHuccZLl19p/9TNO1GRH1VjSMyLkTmjGFbYwh5mHgPmXnk+KM9cH4IfnlvCw7oS7BDhxxHUVwomtb7QK9LRjogCohA3ldsutgNSZsbLOlCJkAsiv16bUUDB1VisD6n8LinRhzP6vvCCj1KKB1TPBq7VKVVZUakTmyI/tpVWg2TY4ROlABWockz63HqULBKYYqNOCqKsINxuwgo9IJn5Gia55L4FOkZ+EP5umpHD6UU6OHmLywWp0gNOpX5B6GgI+XdO9e/nvY7ShcJAKgzCCSIWlz6QjQNWFpWJcAMcRUU2UYUeNkhMjANW0lyn2Ew18vM12MHAMVpSbbHPM+PH9AHnvJAPil/Jr3/Z+LZbahxXcviztnVkC0W/7jbLOVvtUPWPVamm1kqOwOaEexVBz0Dyj6GP51wNmZ2aUAhs0FT3FCt/sDxUL9NfD3l5eMEw4jVzyz3ZESpkOIeNJ5txlGwERILAr5n82J4Yq/M65vobIlFkhJfFx082Q9IjQHyGqs3HXICmYWlDbmYu0kI8NtIXzMFzISpErmvm/Ztfuis2GEBFl1f9jKVUj6t5WaHsA0ChBlet2oElz5PX7GNyLG+gwT2pvXz9O/wbQc+Ul0qgHQud76TiSNLaiyWhYqdiGVtcjJ2w= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(376002)(346002)(396003)(366004)(136003)(451199015)(478600001)(53546011)(6506007)(6486002)(31686004)(186003)(6512007)(66476007)(66556008)(86362001)(31696002)(66946007)(316002)(54906003)(2616005)(6916009)(4326008)(8676002)(2906002)(41300700001)(38100700002)(8936002)(5660300002)(26005)(36756003)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M2Q1Zmd3VUdIR3JPY2t0Vm8xUFBtOFArL0RvQnY3U2hua3VnMXBMY0o1OVho?= =?utf-8?B?OXhyUHNEWGlwMkoxdE91SklwN1NWMmJ4RlUrNmJKT05Sc29ndzZUdU9iSVlH?= =?utf-8?B?V2dTd1dyUG4xb2toeWduaTBOSkthVU5tazU5WVFmcDNKbXNSdktSNHZycEZi?= =?utf-8?B?Z2NaUUNsSlVBcXRtZm1jS2wxbzZseU5mRXBDUlI1M1pmNXZNb1UwRFU2Mi83?= =?utf-8?B?YStmWnNxOFc3Nkw4NitpbTBGemt0M21WdjgzaWYycXByMERMU0tNZkhBMGdy?= =?utf-8?B?ZmRiMHduSkJyUUdFQ28xMUtTMFp6TG05OVFlTTJPNnora0lNaytFVjkvVng4?= =?utf-8?B?YW5DN0E3U3E1SmlycURJSXZ0NEpxQm1nZEpoMnhmeTAyVEtxait4aURrVjRW?= =?utf-8?B?TTBsN0V5N1dCMnJuZ3Q1N1prb1g1K2FhTTFYRU10KysvR2FXRmJ2cDhmekU5?= =?utf-8?B?WEJDeVBQNTNwdlJsQjVqdjJ6ejdGd2VyZXNjd0p6anlBbXhvNmNqc09yU0hT?= =?utf-8?B?Mm0vMXBxaXdzeDZLenlTSEszOFBGRWlaelVDL24rZnR0T0ZsdU1iWVJERXlx?= =?utf-8?B?U09FVjlHMEd4dloyNGx6YmFpN1BHR1UzN0gvNjBYZGQ2WmM3d21wZDJIb1BJ?= =?utf-8?B?QmQ3ODR0RG1NempVa2JBNFNHSlovb1VOVTRpcFdwcTlLY09ZUkc1dzYwdUxV?= =?utf-8?B?MzRqTDRhN2VlSTRPR0JKSWhnY2RoUDRjNnlENnc4d2FrREJXQXZjeWxhQXhF?= =?utf-8?B?aGFac2VGelE5ZndjOVpkVVM3VjZFOUhMVlFRRjI1ZjBORnJBdmtSM3FzUDdX?= =?utf-8?B?MlhEN1lrUFlTa1kxczQ1M3lwWThDRWFGTHpRdThaQndVYTBCMTBCVXdCOUJE?= =?utf-8?B?aEh1NjlOWURoOGZ6Rzc5YmZKN090Y3pLVkw3L3h2R0ZSUUJhWC95R2tlbUh4?= =?utf-8?B?UzQ3RU1oRXhTNVlkL2oyYzhxcnE4NkJOa1FndWdKMVB6aVVua2pQTkdGS25V?= =?utf-8?B?ZStVcG5kT1ZUdHFuTzVFTVFZV3FVKzhwaFM0TGhTZzhVa2ovQ2g2THhWdFVV?= =?utf-8?B?QlV6RzV4WitPbVdjVGt3WUN4NUh0MURibG9ZZ1V6MXZwL3pSZUwzZ0JiTDV3?= =?utf-8?B?TXNySGNpQVhaUHJoUnhWNmxXbjdjUTRtTWJTQmxDOHFLM0pSSVNzTmFvWjRj?= =?utf-8?B?czQweFVyb2paSXFrMU1ZUUJxVGV3REhxUndQc0xCVXRMemhEYXJlaWxhWWNw?= =?utf-8?B?NVZaMVl2bFRFYyt5Qng2UmhEaDdlcklHanI3QnZLR1FXTDcvQ2ROTEdSU09K?= =?utf-8?B?VGNRc1I4SmF6SC8wWitUQzh6MWRvL1ZoUVNwcURDZXFPMWxkYUhXQ3RIUW5O?= =?utf-8?B?U2N4eitJajV0Y3J0VlgxZzE3MGxVVElIL1BaaGRQb0ZSODNoYUtvMUJmdDhl?= =?utf-8?B?dFgwMlRramxrcmtlM0pUcDBEZkJSaVlsZGdOL3Z2U0F1d3M4a2dKZnlFdlNY?= =?utf-8?B?U292dE1iUm1lazREVEhWZ1k3L1l6Y0xxOGMzVWhxZUF4ZzdETDR3QXlSKzU0?= =?utf-8?B?cjhBU3I2eFFTRVRDTFdoSlB4ajNKdzllU0x5Q2tYQ2NvN3RpWDlRVXBDOW9Y?= =?utf-8?B?OFhTVDQ5YXR3dWlDOTJFUFVPbTJmdjVucHZrR01XakxlRERmMWNmQjZEOE9o?= =?utf-8?B?dVVDc1J0dFF3UCtFMWdlS3lDTWRCZ1kveVhVVEgzWVRDRk8yd2N0L2N2QWxa?= =?utf-8?B?OEpHMlRLU2c1OE5ZU1VwQ2JUTkpoVnJDZ2F5UGgxSUpmTnlYckZ2dEpFbC9p?= =?utf-8?B?OTk5VU05SzAvQ05YUVU0ajd5V0pIWUErZ05KNWNLbVNjUlJkRG9CQWw1MTBj?= =?utf-8?B?b0M4Vm4wdzNaQ216d2REUHRzMHIydzVUVlFrZ2F6bms3NWVodmV5U1c1azZO?= =?utf-8?B?VHRYSnVrQkRMNFQwRFl5M3lGK0dNVnpoM1BKeGtCdGxpaVpPZlEvV29YWFEw?= =?utf-8?B?b2lsRmJzQWJqUldUWGZYc1NhQTVKL3lmUDJGM2o4ZzRTQmRtV2o4MmR3QW40?= =?utf-8?B?cFpQSTNQTzYzOFFQSFJvdEw0M2t3Q3JPUm9rVHNlVUducDdpNmN4Q0Y1NzBq?= =?utf-8?Q?mJwuaRm2MDaDT4jdHX3uFjN9A?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ffee38c1-f8e3-41fa-d850-08daf3ddb2bc X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2023 14:11:13.9482 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Vv4Jj+eVfRj1i4ZlZjKNS2weRiCxFH8dKmOS9FC/VfsVLEXB0ZTN0icO99iJyRyCmqcQHtE/8WkjPlYvpPM64Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7350 On 16.12.2022 12:48, Julien Grall wrote: > From: Hongyan Xia > > When mfn is not in direct map, never use mfn_to_virt for any mappings. > > We replace mfn_x(mfn) <= PFN_DOWN(__pa(HYPERVISOR_VIRT_END - 1)) with > arch_mfns_in_direct_map(mfn, 1) because these two are equivalent. The > extra comparison in arch_mfns_in_direct_map() looks different but because > DIRECTMAP_VIRT_END is always higher, it does not make any difference. > > Lastly, domain_page_map_to_mfn() needs to gain to a special case for > the PMAP. > > Signed-off-by: Hongyan Xia > Signed-off-by: Julien Grall This looks plausible, but cannot really be fully judged upon before the mapcache_current_vcpu() aspects pointed out earlier have been sorted. As to using pmap - assuming you've done an audit and the number of simultaneous mappings that can be in use can be proven to not exceed the number of slots available, can you please say so in the description? I have to admit though that I'm wary - this isn't a per-CPU number of slots aiui, but a global one. But then you also have a BUG_ON() there restricting the use to early boot. The reasoning for this is also missing (and might address my concern). Jan From xen-devel-bounces@lists.xenproject.org Wed Jan 11 14:23:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 14:23:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475398.737098 (Exim 4.92) (envelope-from ) id 1pFc15-0004XF-I5; Wed, 11 Jan 2023 14:23:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475398.737098; Wed, 11 Jan 2023 14:23:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFc15-0004X8-FN; Wed, 11 Jan 2023 14:23:47 +0000 Received: by outflank-mailman (input) for mailman id 475398; Wed, 11 Jan 2023 14:23:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFc14-0004X2-Cj for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 14:23:46 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2079.outbound.protection.outlook.com [40.107.22.79]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8cc1aadd-91bb-11ed-b8d0-410ff93cb8f0; Wed, 11 Jan 2023 15:23:42 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBAPR04MB7206.eurprd04.prod.outlook.com (2603:10a6:10:1a4::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Wed, 11 Jan 2023 14:23:40 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Wed, 11 Jan 2023 14:23:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8cc1aadd-91bb-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ab+R12EWg1Mx0zro3Bc7XelMyMCLFWgn0NW+YWWn89VFL1uPSXU9yrIgsD38APfktCBcml7/8rpnjtJOPSp9Ta40ZSUJKebL0m3NgplS7NlCZ2vsSCmxnR3EUf5MX9vHgY3p2MdhC4NCsmcqMuTTfqYH8tQDeAzcxJDec0F9EAkCHPl138ytOXskmQ01VfuH0TOcU0qd4oeqaj4bSH9RI5TYYkxh+xl2crBaGrTCIbGe1GW6gj2XKaZinv7U3vmdiOtvOKJ9VBQn4iI4VzjQS/HBcsgwFlrxnjpHEAjQTPmRMkjphP3wTitrw4sBBR7TZKpCCOY9K4rGw+froheLxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DMBTdI2Yk2d2vY0X7k+8AX2NLn5sYOGt2PdfXWSDWsc=; b=Xm2+EdB1vIx1YFmR12A7vt+7xaRi2oAAKSdWGofupK066Eom+bVC3ZnHCAwEqAYLsxItB0faig7u6mtFZZ5Bn+/nObKZbN2bYoBBm1QMoCGgUShBPmKm+43XqbIx9J679NWfuDgU2yz63WM39xlhwLVxta1SAl2UG2XFihtFCsmHv6NCKKDUDdfMoAYKfOYeCgkoqy5yjOceB2mb23wfi6cqKI5eZKhYnFNLKJbRqCk/OljB8jZxid8nc8gBvmBgj1EMKJCWFHe+DwJbWPZRPlvbN/ZAnX7S9b8TLcP7FsLN1z4dxhFGpe5ChQAqPCNRGpLhJsRF+SZQSAWQeceNYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DMBTdI2Yk2d2vY0X7k+8AX2NLn5sYOGt2PdfXWSDWsc=; b=WfwpB8t82bcuBjjGob6bqhj/rn7GVmqOjsrcqqYUWL0Wcg23TyexWaP3hyow4rGAZJSbk0mE9ZyjdZzpyg70DHQTBIlKWXdaXh3GXF38i5Zc28GTRWvmczZ7GeqtMzzHcUJoDRtlH91Y7hYbCphyyHz3nasoj4wIJZbtWDDtoJuyUIkmt0tMgR+Osb2tSYggGrMQKturG4sstC05G6q5xJ5Euww6nmXdAl4JRw8/ZEj/U80AlS45hH696oCutqqpWiDfFU/ZPOMRh4P2Uuv7jbMPdslhx3ht146Vow5V3moIKfHhXgarWCaIborx/q8intLRIqVyjkZiQ5NAN1/0zg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3ad82ad8-7762-8014-a55b-a6f8316f398e@suse.com> Date: Wed, 11 Jan 2023 15:23:38 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 15/22] xen/page_alloc: add a path for xenheap when there is no direct map Content-Language: en-US To: Julien Grall Cc: Hongyan Xia , Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , Julien Grall , xen-devel@lists.xenproject.org References: <20221216114853.8227-1-julien@xen.org> <20221216114853.8227-16-julien@xen.org> From: Jan Beulich In-Reply-To: <20221216114853.8227-16-julien@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0150.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBAPR04MB7206:EE_ X-MS-Office365-Filtering-Correlation-Id: 50cc3b31-62f9-43ea-fbf7-08daf3df6fd0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Z4tii7jzPiWW1LW46ete0wtS3FFa08xCKJ6G0P1nLkmJyUcUg7r019nRukBnBv8VQJJSO1tMFRdEaDoXOilk7eNa4jON50uN5+a/l3COc0537qgmEh1K/J8BXd4w3TXHOhozv79XKgzUjXNtjAAfBRts46AJE4CDqUMvwcI9PfNG8pdPreuVlZyWFfIObkTMN/0wM9l0ZqsFSoYCXLBSBK2uiJm5vm6h0camt0Wmi7KpOt8POjrnLUbmsGShJxV/8+arWL1+NfAUyccPOktMwtnS5ZKeLVB9UxUDX8DrMRhOFBv5DJMvKjzJ1Y9l1WyZ9frSbdwYuai2UWov6KFrZ3oekUVRDkVXvd/zksc/UNrQhtL5FWKT/C11v8ju5XPFJm2ys9SP2JbEAra80+DRho9qLZ07iBiEGMsst6ja996DP1TYEiu/GKEm28Yp3bjI2QcSXUQ+xQbO2pUX1fQFtya9OQ866GKc4Tf+w7vGZXtRZLsAAFzJVG4sCXVfm97ih91S43GVoiZA1kcmuOSVJSRkeMTSjhF6FPfdmBvsmDETZWH5T/cvb0NDbDlR2hGkN3MPBcyFI58OYzDri47cNlabTW9UzWlnr8JmZRNNNs/+I/xLL41tLh71SdW+HR+Z8u6zQQef44Tmee+WLlFydT8rCMjxQqnVrBG8Zk1QH4scDkMRCmcIJBwq4qbU19oz6+YuNeWAtM67yAKCAyLO3oTpJIh6OT25U9IC0xvpUqA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(346002)(396003)(366004)(39860400002)(136003)(451199015)(2906002)(83380400001)(2616005)(66556008)(66476007)(6916009)(66946007)(5660300002)(8936002)(53546011)(36756003)(186003)(26005)(6506007)(6512007)(31686004)(6486002)(478600001)(38100700002)(41300700001)(8676002)(54906003)(86362001)(316002)(4326008)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cjFsMldPUTdkMjFsTWcwbStyOUxkQ3RDTmxnSE4rM25GTTNWUWlZQlk5NmVH?= =?utf-8?B?SUI2dm13M0ZrWEN6RVdDemt0c0o1K1R2SUZ5eGlxTnVJMjNCZEIzRmJQcmhG?= =?utf-8?B?NjVJTU84cm9EL3VtVDZPd3laWlVkUDNsSjJ1bE40RktabFNWTTJoQ3NOWnZn?= =?utf-8?B?ZU9PUkNreWhEQ0lQbSt5b1piUnQ1VSt3TEpaZ0UwblZvRTJweUdLOW9zZnB6?= =?utf-8?B?ckpBWnVKZ1RuWGZHN08xRVNXMGhYekpXdzJ1cGNBQWRDQWtYdU9mK05va1VP?= =?utf-8?B?QmRzMXo1c1Q1eGo3cXptc3B4U0tiRElhWitwTTlZK2h6Y0FkUm9rdDBycW1a?= =?utf-8?B?cXRwdktjOXR2ZzhFQkV0QkFWQ2tlMi9jTWFRcGxYeXZiUUQyUU1iTmlWUWo4?= =?utf-8?B?RVp5b1Z3K2tqdVcvMXJvYXZIN3FYNi9JMmhQYjl3VmsrTFRJQ1dGVVZJL2Rs?= =?utf-8?B?VEZnT3NmdnI5N0VjUXpjZlEzN0loc2pjUlZ0dVVMSFgyelpEcWpsaFVkWDNZ?= =?utf-8?B?Rk5kWXJOeDBVU3ZXeWRMemx1ekxKd3NvbkszVEowSUhXS1V3aTRTN3lWbUhW?= =?utf-8?B?NmNkQ0JGeWJ0dEh4b284d0lLNlJYdWNDb1lKT2xxVWFBZHdnNTEvcWF6SGxm?= =?utf-8?B?WWdvU3A3aFp0R3BaaUtzS1FkSWZHSzlXKzVNRHdHc2E2bzRKeXhmZkVjaXJq?= =?utf-8?B?NXpoRHplZXY4THZuUEhraml5MklnWWtrdlpPZ0FUakhOTVhQWHRIbnA4dnVu?= =?utf-8?B?YlJRMVp5MVNlRHpTSmxqTGVxNGk4Y0dGOWxyamZBZzVMeHpUbnhJamVlbE1E?= =?utf-8?B?SkZvM25EUUt2OGNHbkpxQUhuN3NoNlFDMStkbHRSN3dZeTdIczBIc0JNNmo4?= =?utf-8?B?ZjJ1azJEMEFERTFFWDVGdFduVVMrdHQ5U3BFTmV0SlJoeDVlZndYeGdnRmF4?= =?utf-8?B?Zjg5b1hmUHRnWlBROVBxWEFNTzlMQUJHMGtlR0dqR0FPMmQrejBjVDVTYTJR?= =?utf-8?B?T3ljUW0vVEVRQ2w2L0twUEFVZ0cyMkdTS2RGd0d6TzBYcTQ1UVh4K2RWaEI3?= =?utf-8?B?Sm1zRVVSekN3ZzNhcUUrblpWRjMwb0lqMXlXSHMwYkhsM0JqWktxWkhEY3Vw?= =?utf-8?B?QlRyNWxqRHlnejlSc2pkMlJ6a20vVVdFWjIyTEl2d3cvclJWcmZaVHA4NEVl?= =?utf-8?B?WmY4UEo0Ryt5amhqMk5Idzg3OEZNN21yMmdiM3ZYVC9VL04xSzYyUmh4bTk0?= =?utf-8?B?V3VXMjQ3MFRCVlRqVm1SQVNlYlUxVjBZTGR4Zng0dnd6a05XN1poemR5NnVI?= =?utf-8?B?eVZMM0R1WVR2RXBCbXVjdE5HdUxBZzFHSEh1UmErMEN5dEE5ME9JNnA0MmtE?= =?utf-8?B?WFoxUWdrR2VEWEhTMFlJYTAwcUY2WFQzWW9zeS9xK29JdngrNnVsOGZ5ekFn?= =?utf-8?B?U2pFUjJmVVNxT0VqT1lpRWVKOUxHdG8rcE1BOXlQY25sTldiN1B4aFBmKzFw?= =?utf-8?B?WFlLOUpLYWxKcE1GY25Wa3JsMUlrWElTT1RmZTdTOEIwRnhZQ0JoK1VNUFc5?= =?utf-8?B?OERaT2c2bGlIYi94ZDhmUWVhYXZZVUZWeUdsaTE5TVdNM1oxZjBWUFZmRDNL?= =?utf-8?B?NHVrdWk2Q0dybHY2TjFoanFxYjBMeXpmTnN3TkR1Mm1pdTNuUnNiWEVoQ1Z0?= =?utf-8?B?dE1EM1JEeWZZMHg3THBvaUdEdFBkMkFRSGJQLzZWUnZ2SVJSREozZDgzNTlv?= =?utf-8?B?SVgwZzM5M0FueDRFeFdOdVYyOC9XVWptNk8wWkF5azdmVTlzY2Rwbzc2OStL?= =?utf-8?B?c1ZhbC85bHkwVUs5eEVzZHRrWUI1SkljNk13ZVU0cXVYRGdZZ0l4YTlSa1Fw?= =?utf-8?B?RlRlYlROakRpYUFEMkJFOTBraWVDbzRxNFRmWmNsL3hLTWEydnBOSkVyY3Fu?= =?utf-8?B?S09ITS9ZN0UwaTgrOE5nRzBQL3Jid0ROeGtvSjArbFN3eGVQTVRRSGRMQ0Ey?= =?utf-8?B?YmQzdldzUk4wS3VhTXdYaTdyMzZ1di95enhjL1RMYjdabjQvZVVXbVVuRFBK?= =?utf-8?B?U3c4Yk9Hd3JoU05CZVdWOTUvc0Q0L2VFdHBrTEhmSTBwRFBxSXBta004REE3?= =?utf-8?Q?nX+Se7rwnUb4xEmDyo7w1yGNw?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 50cc3b31-62f9-43ea-fbf7-08daf3df6fd0 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2023 14:23:40.6351 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5lqnJrlm5LhEpBeEjbR8kWb+wu4A+6UwHibyjTtL25EGkoJxA4CdGiF+Y31Hoe0fu/hueRAycvKKFB00sDu9IA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7206 On 16.12.2022 12:48, Julien Grall wrote: > From: Hongyan Xia > > When there is not an always-mapped direct map, xenheap allocations need > to be mapped and unmapped on-demand. Hmm, that's still putting mappings in the directmap, which I thought we mean to be doing away with. If that's just a temporary step, then please say so here. > I have left the call to map_pages_to_xen() and destroy_xen_mappings() > in the split heap for now. I am not entirely convinced this is necessary > because in that setup only the xenheap would be always mapped and > this doesn't contain any guest memory (aside the grant-table). > So map/unmapping for every allocation seems unnecessary. But if you're unmapping, that heap won't be "always mapped" anymore. So why would it need mapping initially? > Changes since Hongyan's version: > * Rebase > * Fix indentation in alloc_xenheap_pages() Looks like you did in one of the two instances only, as ... > @@ -2230,17 +2231,36 @@ void *alloc_xenheap_pages(unsigned int order, unsigned int memflags) > if ( unlikely(pg == NULL) ) > return NULL; > > + ret = page_to_virt(pg); > + > + if ( !arch_has_directmap() && > + map_pages_to_xen((unsigned long)ret, page_to_mfn(pg), 1UL << order, > + PAGE_HYPERVISOR) ) > + { > + /* Failed to map xenheap pages. */ > + free_heap_pages(pg, order, false); > + return NULL; > + } ... this looks wrong. An important aspect here is that to be sure of no recursion, map_pages_to_xen() and destroy_xen_mappings() may no longer use Xen heap pages. May be worth saying explicitly in the description (I can't think of a good place in code where such a comment could be put _and_ be likely to be noticed at the right point in time). > void free_xenheap_pages(void *v, unsigned int order) > { > + unsigned long va = (unsigned long)v & PAGE_MASK; > + > ASSERT_ALLOC_CONTEXT(); > > if ( v == NULL ) > return; > > + if ( !arch_has_directmap() && > + destroy_xen_mappings(va, va + (1UL << (order + PAGE_SHIFT))) ) > + dprintk(XENLOG_WARNING, > + "Error while destroying xenheap mappings at %p, order %u\n", > + v, order); Doesn't failure here mean (intended) security henceforth isn't guaranteed anymore? If so, a mere dprintk() can't really be sufficient to "handle" the error. Jan From xen-devel-bounces@lists.xenproject.org Wed Jan 11 14:24:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 14:24:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475402.737110 (Exim 4.92) (envelope-from ) id 1pFc1U-0004xC-U1; Wed, 11 Jan 2023 14:24:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475402.737110; Wed, 11 Jan 2023 14:24:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFc1U-0004x5-R2; Wed, 11 Jan 2023 14:24:12 +0000 Received: by outflank-mailman (input) for mailman id 475402; Wed, 11 Jan 2023 14:24:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFc1T-0004X2-MV for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 14:24:11 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9abdd617-91bb-11ed-b8d0-410ff93cb8f0; Wed, 11 Jan 2023 15:24:08 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9abdd617-91bb-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1673447048; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=w8iJbWumWsWSLAQupGB9uR+XhDb3DO8D3MIfiJPhdz8=; b=fvF4BX+LPrQIrY2PpHtLmmLlik6LfxTjvMHH0utzI0BqD0bxqb/oUMd5 N3ynSJFBX6ODR5lUKO0xlFzG1LltL/LlsRiGuVjiAB81lItJuZvtYlSwB A1eMWha8DWiO/+SqxstiXRfd8Z2ybKbHaE2mP176YByTOrzifXjKxz0u7 U=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 92126493 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:MaYA86LOzuKiLSf/FE+R25UlxSXFcZb7ZxGr2PjKsXjdYENS12dVz 2sbDG/VO6yNZGCnctAibd/g/E1XsMeBz4AwQFFlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHv+kUrWs1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPdwP9TlK6q4mhA5wVnPaojUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5WKEVx3 84CcQsyZ066nOKv0qmWE+NF05FLwMnDZOvzu1llxDDdS/0nXYrCU+PB4towMDUY354UW6yEP oxANGQpPE+ojx5nYz/7DLolkf2ni2i5fyxRs1aUjaE2/3LS3Ep6172F3N/9K4bTH5sJzx3wS mTuvEPDXA9HF9WjwyOV81Sq3NfrxS3pYddHfFG/3qEz2wDCroAJMzUJUXOrrP//jVSxM/pPJ kpR9icwoKwa8E2wUsK7TxC+uGSDvBMXR5xXCeJSwAOHx7fQ4g2ZLnMZVTMHY9sj3PLaXhRzi AXPxYmwQ2Uy7vvFEhpx64t4sxuTEAwqB10YPBQ7RFU8+Nn6spoe1xjmG4ML/LGOsvX5HjT5w javpSc4hqkOgcNj65hX7WwrkBr3+MGXE1ddChH/Gzv8s1gnPNLNi5mAswCz0BpWEGqOorBtV lAgktPW0u0BBIrleMelELRUR+HBCxpo3VThbb9T83sJrW/FF52LJ9o4DNRCyKBBbK45lcfBO hO7hO+ozMY70IGWRaF2eZmtLM8h0LLtE9/oPtiNMIUVOccsKl/ao38+DaJ144wKuBFy+ZzTx L/BKZr8ZZrkIfkPIMWKqxc1juZwm3FWKZL7TpHn1RW3uYdyl1bMIYrpxGCmN7hjhIvd+VW9z jqqH5fSo/mpeLGkM3a/HE96BQxiEEXX8rit9ZcMK7LTc1c4cIzjYteIqY4cl0Vet/w9vo/1E ruVACe0FHKXaaX7FDi3 IronPort-HdrOrdr: A9a23:McqUha8+FRcEno35IkFuk+D2I+orL9Y04lQ7vn2ZESYlFfBxl6 iV88jzpiWE7gr5OUtQ4+xoV5PwIk80maQZ3WBVB8bHYOCEghrUEGgB1/qB/9SIIUSXnYRgPO VbAs1D4bbLY2SS+Pyb3ODOKbcdKbe8nJxAzt2utkuFBTsaE52IwT0JcTqmLg== X-IronPort-AV: E=Sophos;i="5.96,317,1665460800"; d="scan'208";a="92126493" From: Sergey Dyasli To: CC: Sergey Dyasli , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v2] x86/ucode/AMD: apply the patch early on every logical thread Date: Wed, 11 Jan 2023 14:23:29 +0000 Message-ID: <20230111142329.4379-1-sergey.dyasli@citrix.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit The original issue has been reported on AMD Bulldozer-based CPUs where ucode loading loses the LWP feature bit in order to gain the IBPB bit. LWP disabling is per-SMT/CMT core modification and needs to happen on each sibling thread despite the shared microcode engine. Otherwise, logical CPUs will end up with different cpuid capabilities. Link: https://bugzilla.kernel.org/show_bug.cgi?id=216211 Guests running under Xen happen to be not affected because of levelling logic for the feature masking/override MSRs which causes the LWP bit to fall out and hides the issue. The latest recommendation from AMD, after discussing this bug, is to load ucode on every logical CPU. In Linux kernel this issue has been addressed by e7ad18d1169c ("x86/microcode/AMD: Apply the patch early on every logical thread"). Follow the same approach in Xen. Introduce SAME_UCODE match result and use it for early AMD ucode loading. Late loading is still performed only on the first of SMT/CMT siblings and only if a newer ucode revision has been provided (unless allow_same option is specified). Intel's side of things is modified for consistency but provides no functional change. Signed-off-by: Sergey Dyasli --- v1 --> v2: - Expanded the commit message with the levelling section - Adjusted comment for OLD_UCODE CC: Jan Beulich CC: Andrew Cooper CC: "Roger Pau Monné" CC: Wei Liu --- xen/arch/x86/cpu/microcode/amd.c | 16 +++++++++++++--- xen/arch/x86/cpu/microcode/intel.c | 9 +++++++-- xen/arch/x86/cpu/microcode/private.h | 3 ++- 3 files changed, 22 insertions(+), 6 deletions(-) diff --git a/xen/arch/x86/cpu/microcode/amd.c b/xen/arch/x86/cpu/microcode/amd.c index 4b097187a0..96db10a2e0 100644 --- a/xen/arch/x86/cpu/microcode/amd.c +++ b/xen/arch/x86/cpu/microcode/amd.c @@ -176,8 +176,13 @@ static enum microcode_match_result compare_revisions( if ( new_rev > old_rev ) return NEW_UCODE; - if ( opt_ucode_allow_same && new_rev == old_rev ) - return NEW_UCODE; + if ( new_rev == old_rev ) + { + if ( opt_ucode_allow_same ) + return NEW_UCODE; + else + return SAME_UCODE; + } return OLD_UCODE; } @@ -220,8 +225,13 @@ static int cf_check apply_microcode(const struct microcode_patch *patch) unsigned int cpu = smp_processor_id(); struct cpu_signature *sig = &per_cpu(cpu_sig, cpu); uint32_t rev, old_rev = sig->rev; + enum microcode_match_result result = microcode_fits(patch); - if ( microcode_fits(patch) != NEW_UCODE ) + /* + * Allow application of the same revision to pick up SMT-specific changes + * even if the revision of the other SMT thread is already up-to-date. + */ + if ( result != NEW_UCODE && result != SAME_UCODE ) return -EINVAL; if ( check_final_patch_levels(sig) ) diff --git a/xen/arch/x86/cpu/microcode/intel.c b/xen/arch/x86/cpu/microcode/intel.c index f7fec4b4ed..59a99eee4e 100644 --- a/xen/arch/x86/cpu/microcode/intel.c +++ b/xen/arch/x86/cpu/microcode/intel.c @@ -232,8 +232,13 @@ static enum microcode_match_result compare_revisions( if ( new_rev > old_rev ) return NEW_UCODE; - if ( opt_ucode_allow_same && new_rev == old_rev ) - return NEW_UCODE; + if ( new_rev == old_rev ) + { + if ( opt_ucode_allow_same ) + return NEW_UCODE; + else + return SAME_UCODE; + } /* * Treat pre-production as always applicable - anyone using pre-production diff --git a/xen/arch/x86/cpu/microcode/private.h b/xen/arch/x86/cpu/microcode/private.h index 73b095d5bf..626aeb4d08 100644 --- a/xen/arch/x86/cpu/microcode/private.h +++ b/xen/arch/x86/cpu/microcode/private.h @@ -6,7 +6,8 @@ extern bool opt_ucode_allow_same; enum microcode_match_result { - OLD_UCODE, /* signature matched, but revision id is older or equal */ + OLD_UCODE, /* signature matched, but revision id is older */ + SAME_UCODE, /* signature matched, but revision id is the same */ NEW_UCODE, /* signature matched, but revision id is newer */ MIS_UCODE, /* signature mismatched */ }; -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Wed Jan 11 14:29:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 14:29:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475411.737121 (Exim 4.92) (envelope-from ) id 1pFc6R-0005mU-IV; Wed, 11 Jan 2023 14:29:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475411.737121; Wed, 11 Jan 2023 14:29:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFc6R-0005mN-F3; Wed, 11 Jan 2023 14:29:19 +0000 Received: by outflank-mailman (input) for mailman id 475411; Wed, 11 Jan 2023 14:29:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFc6Q-0005mD-7z; Wed, 11 Jan 2023 14:29:18 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFc6Q-0001A4-5Q; Wed, 11 Jan 2023 14:29:18 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFc6P-0004qZ-Pz; Wed, 11 Jan 2023 14:29:17 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pFc6P-0008Lr-PT; Wed, 11 Jan 2023 14:29:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=+Vo5v3yU7TBDaCEYl+KLk7kGe7EGqUw64Budd18tvRs=; b=GKZBhFX48Z1x0nehXuSP8J2VBB xaZ/70mrePvHmfBx7YjWKOlpbJlwMtelUS01p8YIrYBvlWTwoYojQwN7Me699ZDxICAbnPmvJWADp qY85RWrjVMDS+tw4wK30V+3yCsTPRLqICZScy6ii7Sq2jGPYDRMYEwlq5zfHrmMR8xXk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 175718: tolerable FAIL - PUSHED X-Osstest-Failures: libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: libvirt=a5738ab74c2ab449522ddf661808262fc92e28d7 X-Osstest-Versions-That: libvirt=49ff47269b71a762ca5de4595f6ec915043e05ce From: osstest service owner Date: Wed, 11 Jan 2023 14:29:17 +0000 flight 175718 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/175718/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 175684 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail like 175684 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 175684 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 175684 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: libvirt a5738ab74c2ab449522ddf661808262fc92e28d7 baseline version: libvirt 49ff47269b71a762ca5de4595f6ec915043e05ce Last test of basis 175684 2023-01-10 04:18:53 Z 1 days Testing same since 175718 2023-01-11 04:20:41 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Daniel P. Berrangé Jiri Denemark Laine Stump Martin Kletzander Peter Krempa jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git 49ff47269b..a5738ab74c a5738ab74c2ab449522ddf661808262fc92e28d7 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Jan 11 14:35:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 14:35:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475419.737131 (Exim 4.92) (envelope-from ) id 1pFcBv-0007CV-6u; Wed, 11 Jan 2023 14:34:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475419.737131; Wed, 11 Jan 2023 14:34:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFcBv-0007CO-4I; Wed, 11 Jan 2023 14:34:59 +0000 Received: by outflank-mailman (input) for mailman id 475419; Wed, 11 Jan 2023 14:34:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFcBt-0007CI-1I for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 14:34:57 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2044.outbound.protection.outlook.com [40.107.247.44]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1d53642d-91bd-11ed-b8d0-410ff93cb8f0; Wed, 11 Jan 2023 15:34:54 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8551.eurprd04.prod.outlook.com (2603:10a6:10:2d6::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Wed, 11 Jan 2023 14:34:53 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Wed, 11 Jan 2023 14:34:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1d53642d-91bd-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KDxzQTkjy38BmcIoA4oe5Udj98+Z3b33bjT+lxvxs88ws5BhmE72rTD5RMvrnHbmRLEBLWQXHvdyMqeQ5LaSNdtJNC9Hql3xUAuZdk+MJudBz6TDetN/zx1fgSG4AexF86oka3If8UlHncsgwBII1u+/rZqEEPg/nROW0ZzuOyqAvVgRTcmEHXB54oUpKdQWf14vIuxvNW3dZY5eV9MaAwgMszecy5BkCypg68BrqRr5uubAZqc1auecC8VP7IQkelsvGuM2tYPV0ph58DCNn1h2+yItahtqa6+fH6BoUPn1NCXP/PqflofKbRAuyFqBDqBWAH8xrD99unKEI9ZoIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8mwZanp8D+FPIIeYcPrZURlT8a36AzCP0jEaVSmpmQc=; b=YLqsLxRhOPEq0HvQHskybO9Q6CNnON+udnmV/iR4gJtRy657XiF7iYLUFK4lJGP0fEsXnjbyFxjfJJ+bz2osEVBGJXAwDbFqJT9ZVtUOD9tt8vuHdjcXmPBie9qzIic8Y3uZCr6lHWPNsnSLvBv6NJJ2ZMD3XgZnsp+Mt0jHAkkTJcWfU9/bNGHecvSEHNi/hg2AKwTNchWWC+SqcEejY7XMc5E/6baZvcTf6UeXg3hcwuzEUd+S0V3WS2DdtXuiIp1j13PImLtzL5e9d87CeS+QJ9L++lxWIhcs22/R1234M3PBXeydaa3IUy02Iu7u5F5yQwjjAiOHsNYBblLFdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8mwZanp8D+FPIIeYcPrZURlT8a36AzCP0jEaVSmpmQc=; b=0gD+XDQwekBSXjPtDpALB5pryxSDApFdH7Plm6Hz7skleE8EHMnNF4jNQKXdLm8dhe1oq1xkuQ1ptrU9i1y8yiMKvu7qUy8D8UnjLJ08gFRBsZtk9rKVdAIcvAumSenZtz8w15kmxkZ9Z4Fm9tM+fZxRljSB1giKcyItEpbfv22DaCO6tdR7pdQpeoFd60Km1UqC50pUoUncUeWSjBLQoGUr/0LBeU2VknQfQ7QSMXDI0Oew6/zp1Za/sti6uSB3Jncrz7f3PdJST8bKpWZaJYO/RTZieTQzXfC57WAfsWJSymCylWHBYth8He7SbuTsBGuS10PifHKjGpu0SRDx/A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <75a3787f-7fc0-8586-8a96-1eb2e94cf523@suse.com> Date: Wed, 11 Jan 2023 15:34:51 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 16/22] x86/setup: leave early boot slightly earlier Content-Language: en-US To: Julien Grall Cc: Hongyan Xia , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Julien Grall , xen-devel@lists.xenproject.org References: <20221216114853.8227-1-julien@xen.org> <20221216114853.8227-17-julien@xen.org> From: Jan Beulich In-Reply-To: <20221216114853.8227-17-julien@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0172.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9f::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8551:EE_ X-MS-Office365-Filtering-Correlation-Id: 95409bce-a927-4bda-1185-08daf3e100bc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zryfzpD2urRK8pZM8bXKqmYVkTh6z2mU3fpocJz7wR4HsHtsRevduBoGowtCuDJi98/JmaU36YApUXO+haKaP7+55Mb7dqGUo/0nmYQrxTRgF93up76xs3D95djZMLEdPJWk4e47jLOUKjs9RCqGucMuOGGsPd6pwk0rejhSbn/8czNlEChpr06MWeVLLYuVqiJxmP3yoDCC34heQ9d0Y5LlNJtmV8Q8USr8/lUzK0rRXcgBxXpiyMhbFmGQybMvXwPigf3JlopW6Sm55Tl1IDIEbvhsQyRkrJPsVXPfgMgaRDiCRhMUh+ApnzzZp3SkGM4YutXncrED9gaidEkpTIyKmPwAOFXNSJ2YWBCZBp57zHgGkaIiDyj+n18uYYUsqASEolnjleoXFSv5NJKb1FJjp9/Q18ZKicEnUQ4C+VLfx5qt58XK90gfvRs/PCyr8BRKXLicoXtOnNw7zr65kqU7IB7occrXCCmFhehQjI+/Z9iGJhDDHjRGPPtoul1qDbL3/KUt0mz+P264RupRFJ+9ujvlcOCWvLMz4RL8/9jYRYE2DAW+j8jpQgnXNZ8BpWKx5P4dVLGwHsfPOgO5QngWF1JpD5pzyfahhi7K8XM56CHtfanTfGeH3q+hBcB8rSL+MLuh4wscETTNoUcfAhAIaGho1yrQlIvzXMnc36XPgjXfe6oF9d5meoiAdDfSZGAOl63b1aNMpoXViQzGNIM/EERkQQuUVO66ABdbLQI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(39860400002)(366004)(376002)(136003)(396003)(451199015)(8936002)(2906002)(5660300002)(41300700001)(316002)(4326008)(66556008)(8676002)(6916009)(66476007)(66946007)(54906003)(26005)(6512007)(38100700002)(2616005)(31686004)(86362001)(186003)(31696002)(83380400001)(53546011)(36756003)(6506007)(478600001)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b3k3Y3JiZWtXMnJFYXNhTWd2Y3VCVE5Ud20zWUV3OVZnZnB0bmhWeUtESERu?= =?utf-8?B?OWR5bEg2L3ZyUTMwQzVWeE5JZDdCdXFtbnI2b3BxTUtGbnFHRjJtVmdBMkZL?= =?utf-8?B?aEcveU1neXFrKzJJQ3RJYUk2ZXc3c0o4OFdkYjQ3ZlEzbU9aOXAwK1dpUDZa?= =?utf-8?B?Ymo0QWJWQ0IxbU5xZnBXNFk0V3FubWlEZHVwa0ZhSjVlUmhvM2FGbXBuUzU1?= =?utf-8?B?MUVYN2EvOVJ6WFdRZTRsek52OVpjVFhPN2J3TjlNT0pHblcrM2ZMNVcyaVE4?= =?utf-8?B?ZG5YRXNMUkdiVzFkKzRNRFJJYy8rbVVrN3JBL3ZPY3ZPQi9GWVExcjRZczdv?= =?utf-8?B?WWpZdlMzRzdpU0FEcFBCSzZuNEQ5MXRrbllsbHAwaFhOYmNKaDRaa01XV1JV?= =?utf-8?B?WmZKMHduVTIxamdvcEJSbCtLdEQxMlhNcVh3L0piM2xsS3BHRXA4LzVmOXRn?= =?utf-8?B?Tk4xaUtqL1lXK3lINXUwbzRid0p0ZnFUNlkxYXdwQ09EZGV1bTRLblBNNzBK?= =?utf-8?B?TGxOSlhPdzRrYmRFb2R6Ulp6TjU1UGx5eUhHR08yZXR5THBGemJ1T2RnbC9Q?= =?utf-8?B?bXE0alJwcnNic2JxZ09sQ3l6aXVVYVV4MEpncitKQkd2eXVQK0RsaHBoY3JV?= =?utf-8?B?dG1ieFZLZGpsZU9vWk5lSG12NTBjTTV4ZDczMGJheS90V0ZCNkRjOGh5dDlS?= =?utf-8?B?d0MwRG93UTVLeXpUUG1UNnFuNlMxWWVPRUVtbkRIaWNlTk1ia2wrSXJ6Tmtz?= =?utf-8?B?aVY1M3g4a0ZISm9kNmc0TGNIMnRDVzF5UExwYUJ1QW1aZnNuVnVGL01vNktM?= =?utf-8?B?MmdxbHl6cGY3bnJHVzliVGZtRlRPbXdSS3RqUUs0OTBvdURMd3QxdU1sMzlJ?= =?utf-8?B?bURyajBEdm1lZWNiZFgrdmxBSkpGTGl1VFdnbVhadFNjUy8xenJxZjNxREYr?= =?utf-8?B?bytwNldpd2N0aGo1QkVIUnViUXVETC9nSzdxc3JuRGhXaXRwUWdYS0k1ZDhI?= =?utf-8?B?NzVHLzVhbWV2NEg5Z2Vwcmpud1BWMjBsaitBbHgvR0M4d0FXVDlPOHAwNTBl?= =?utf-8?B?RXhwd0hmSlZaSklweDZnV0VYM3hMRU1PZFJYN2oxTVFiUjl4Y21WWFRSV1Yx?= =?utf-8?B?OHRaOVFVUVpyZDFXb2hHVTc5di9VTzZ2a2VSOFBLa2RmK0xKMFFEdCtYQmxX?= =?utf-8?B?R2dTR1ZxWDZyTi9FVDV5a1NKNk9yYTRhcUgwOG4xbkgzWSszN3RLU0t1aksr?= =?utf-8?B?SDYrMXdadDhxVHRPTzI2QVJUaElMQVFweHhXQlViZHkvbm1MaDVQc09XMWg3?= =?utf-8?B?TUtaeDlQNFVtRTRIeGE5VFdVamg3TEpyS2E3S2s0cGkwTWhWb2k2bDV3OGlv?= =?utf-8?B?d0ZmdGhiSkUxMG9uWDhPS0k4alBTWWZxbEdURE5HOXdNYUJ6eHlqc0RJaXJw?= =?utf-8?B?MHd0d241VERpRDlCZE9uaUJDcmNEQmZiRWF0ckdBMThWU1ZoVmY3Szd1ZUlD?= =?utf-8?B?RkVKSUlzeVNhNW5VUi9ZMjU5amhPd2hnazE1dUVNVU15bnd5c0dTUVo0SGlj?= =?utf-8?B?STcremNNRS9xU1c0bXdBQ2dyM2taNmhJTW85WTNmTzlPdzJJbWVUV3JsUVJK?= =?utf-8?B?V3hWcTB6OXNIYU1vdnhMRzM5ZDBRSXNqeFAxY0hCU3hyRllQRThEYzYvU3cx?= =?utf-8?B?TUtlR0lhdG5TVXpJTkhKRm9yT0pUd0J2SUo1OUZwOWNpcGJhdm5lckx4TnRV?= =?utf-8?B?amg1U2dLdy96UDNsdTNNK0VrbkRJYUIyYnFvWlR6T1h1U0dkSzFIcmpJS0dk?= =?utf-8?B?ZFdIZzJGVUFGbG9WNkh2aXlvQlQ1ZXFvZDlyTFpiOGZpU2h1YzBucUoxdjg3?= =?utf-8?B?WXpQQ3BrMWlQM0ltcEtnYWdHQVNCemFpWERHRWVGeDZHZkZPUnpwTDg0QTlm?= =?utf-8?B?VUgvdEQrcXg5dFllNUp5UnVoZzZRL1dKYUtiY3VyM204MUV4MDhUTlQ4U0FS?= =?utf-8?B?WHpzc082bzF3L3NoK01wbmFSOXJ2bEtjRlo3UWVldkwyRXFPdnJUTHg3dSt4?= =?utf-8?B?bElSc1V5UzFYZWplSFZobzE0TFpzL2tKV3JnSjJJTEZJdVh4ZEZ2LzRCL3dm?= =?utf-8?Q?THafqjgIf5VdLxMHoCUWmnfnY?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 95409bce-a927-4bda-1185-08daf3e100bc X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2023 14:34:53.2956 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bz/zDgtsONFgN/kYUWxLokQhF/JN4Q9gOQhohN9qOxXxdFwQGd8jGduQmHACp0RFC4r04V1PSTB2LZAvZHsEgg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8551 On 16.12.2022 12:48, Julien Grall wrote: > --- a/xen/arch/x86/setup.c > +++ b/xen/arch/x86/setup.c > @@ -1648,6 +1648,22 @@ void __init noreturn __start_xen(unsigned long mbi_p) > > numa_initmem_init(0, raw_max_page); > > + /* > + * When we do not have a direct map, memory for metadata of heap nodes in > + * init_node_heap() is allocated from xenheap, which needs to be mapped and > + * unmapped on demand. However, we cannot just take memory from the boot > + * allocator to create the PTEs while we are passing memory to the heap > + * allocator during end_boot_allocator(). > + * > + * To solve this race, we need to leave early boot before > + * end_boot_allocator() so that Xen PTE pages are allocated from the heap > + * instead of the boot allocator. We can do this because the metadata for > + * the 1st node is statically allocated, and by the time we need memory to > + * create mappings for the 2nd node, we already have enough memory in the > + * heap allocator in the 1st node. > + */ Is this "enough" guaranteed, or merely a hope (and true in the common case, but maybe not when the 1st node ends up having very little memory)? > + system_state = SYS_STATE_boot; > + > if ( max_page - 1 > virt_to_mfn(HYPERVISOR_VIRT_END - 1) ) > { > unsigned long limit = virt_to_mfn(HYPERVISOR_VIRT_END - 1); > @@ -1677,8 +1693,6 @@ void __init noreturn __start_xen(unsigned long mbi_p) > else > end_boot_allocator(); > > - system_state = SYS_STATE_boot; I'm afraid I don't view this as viable - there are assumptions not just in the page table allocation functions that SYS_STATE_boot (or higher) means that end_boot_allocator() has run (e.g. acpi_os_map_memory()). You also do this for x86 only. I think system_state wants leaving alone here, and an arch specific approach wants creating for the page table allocation you talk of. Jan From xen-devel-bounces@lists.xenproject.org Wed Jan 11 14:38:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 14:38:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475454.737177 (Exim 4.92) (envelope-from ) id 1pFcFX-0001PT-Co; Wed, 11 Jan 2023 14:38:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475454.737177; Wed, 11 Jan 2023 14:38:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFcFX-0001PM-A9; Wed, 11 Jan 2023 14:38:43 +0000 Received: by outflank-mailman (input) for mailman id 475454; Wed, 11 Jan 2023 14:38:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFcFV-0001NK-Nf for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 14:38:41 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id a2e338e5-91bd-11ed-b8d0-410ff93cb8f0; Wed, 11 Jan 2023 15:38:39 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 33D9DFEC; Wed, 11 Jan 2023 06:39:20 -0800 (PST) Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com [10.1.195.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 766E63F71A; Wed, 11 Jan 2023 06:38:36 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a2e338e5-91bd-11ed-b8d0-410ff93cb8f0 From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Anthony PERARD , Nick Rosbrook , Juergen Gross Subject: [RFC PATCH 0/8] SVE feature for arm guests Date: Wed, 11 Jan 2023 14:38:18 +0000 Message-Id: <20230111143826.3224-1-luca.fancellu@arm.com> X-Mailer: git-send-email 2.17.1 This serie is introducing the possibility for Dom0 and DomU guests to use sve/sve2 instructions. SVE feature introduces new instruction and registers to improve performances on floating point operations. The SVE feature is advertised using the ID_AA64PFR0_EL1 register, SVE field, and when available the ID_AA64ZFR0_EL1 register provides additional information about the implemented version and other SVE feature. New registers added by the SVE feature are Z0-Z31, P0-P15, FFR, ZCR_ELx. Z0-Z31 are scalable vector register whose size is implementation defined and goes from 128 bits to maximum 2048, the term vector length will be used to refer to this quantity. P0-P15 are predicate registers and the size is the vector length divided by 8, same size is the FFR (First Fault Register). ZCR_ELx is a register that can control and restrict the maximum vector length used by the exception level and all the lower exception levels, so for example EL3 can restrict the vector length usable by EL3,2,1,0. The platform has a maximum implemented vector length, so for every value written in ZCR register, if this value is above the implemented length, then the lower value will be used. The RDVL instruction can be used to check what vector length is the HW using after setting ZCR. For an SVE guest, the V0-V31 registers are part of the Z0-Z31, so there is no need to save them separately, saving Z0-Z31 will save implicitly also V0-V31. SVE usage can be trapped using a flag in CPTR_EL2, hence in this serie the register is added to the domain state, to be able to trap only the guests that are not allowed to use SVE. This serie is introducing a command line parameter to enable Dom0 to use SVE and to set its maximum vector length that by default is 0 which means the guest is not allowed to use SVE. Values from 128 to 2048 mean the guest can use SVE with the selected value used as maximum allowed vector length (which could be lower if the implemented one is lower). For DomUs, an XL parameter with the same way of use is introduced and a dom0less DTB binding is created. The context switch is the most critical part because there can be big registers to be saved, in this serie an easy approach is used and the context is saved/restored every time for the guests that are allowed to use SVE. Luca Fancellu (8): xen/arm: enable SVE extension for Xen xen/arm: add sve_vl_bits field to domain xen/arm: Expose SVE feature to the guest xen/arm: add SVE exception class handling arm/sve: save/restore SVE context switch xen/arm: enable Dom0 to use SVE feature xen/tools: add sve parameter in XL configuration xen/arm: add sve property for dom0less domUs docs/man/xl.cfg.5.pod.in | 11 ++ docs/misc/arm/device-tree/booting.txt | 7 + docs/misc/xen-command-line.pandoc | 12 ++ tools/golang/xenlight/helpers.gen.go | 2 + tools/golang/xenlight/types.gen.go | 1 + tools/include/libxl.h | 5 + tools/libs/light/libxl_arm.c | 2 + tools/libs/light/libxl_types.idl | 1 + tools/xl/xl_parse.c | 10 ++ xen/arch/arm/Kconfig | 3 +- xen/arch/arm/arm64/Makefile | 1 + xen/arch/arm/arm64/cpufeature.c | 7 +- xen/arch/arm/arm64/sve.c | 104 +++++++++++++ xen/arch/arm/arm64/sve_asm.S | 189 +++++++++++++++++++++++ xen/arch/arm/arm64/vfp.c | 79 ++++++---- xen/arch/arm/arm64/vsysreg.c | 39 ++++- xen/arch/arm/cpufeature.c | 6 +- xen/arch/arm/domain.c | 61 ++++++++ xen/arch/arm/domain_build.c | 11 ++ xen/arch/arm/include/asm/arm64/sve.h | 72 +++++++++ xen/arch/arm/include/asm/arm64/sysregs.h | 4 + xen/arch/arm/include/asm/arm64/vfp.h | 10 ++ xen/arch/arm/include/asm/cpufeature.h | 14 ++ xen/arch/arm/include/asm/domain.h | 8 + xen/arch/arm/include/asm/processor.h | 3 + xen/arch/arm/setup.c | 5 +- xen/arch/arm/traps.c | 46 ++++-- xen/include/public/arch-arm.h | 2 + xen/include/public/domctl.h | 2 +- 29 files changed, 661 insertions(+), 56 deletions(-) create mode 100644 xen/arch/arm/arm64/sve.c create mode 100644 xen/arch/arm/arm64/sve_asm.S create mode 100644 xen/arch/arm/include/asm/arm64/sve.h -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Wed Jan 11 14:38:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 14:38:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475455.737184 (Exim 4.92) (envelope-from ) id 1pFcFX-0001WW-Tg; Wed, 11 Jan 2023 14:38:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475455.737184; Wed, 11 Jan 2023 14:38:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFcFX-0001UQ-N2; Wed, 11 Jan 2023 14:38:43 +0000 Received: by outflank-mailman (input) for mailman id 475455; Wed, 11 Jan 2023 14:38:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFcFW-0001NK-Dl for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 14:38:42 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id a38f1210-91bd-11ed-b8d0-410ff93cb8f0; Wed, 11 Jan 2023 15:38:40 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 618DA13D5; Wed, 11 Jan 2023 06:39:21 -0800 (PST) Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com [10.1.195.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5539A3F71A; Wed, 11 Jan 2023 06:38:38 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a38f1210-91bd-11ed-b8d0-410ff93cb8f0 From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [RFC PATCH 1/8] xen/arm: enable SVE extension for Xen Date: Wed, 11 Jan 2023 14:38:19 +0000 Message-Id: <20230111143826.3224-2-luca.fancellu@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230111143826.3224-1-luca.fancellu@arm.com> References: <20230111143826.3224-1-luca.fancellu@arm.com> Enable Xen to handle the SVE extension, add code in cpufeature module to handle ZCR SVE register, disable trapping SVE feature on system boot, it will be restored later on vcpu creation and running. While there, correct coding style for the comment on coprocessor trapping. Change the KConfig entry to make ARM64_SVE symbol selectable, by default it will be not selected. Create sve module and sve_asm.S that contains assembly routines for the SVE feature, this code is inspired from linux and it uses instruction encoding to be compatible with compilers that does not support SVE. Signed-off-by: Luca Fancellu --- xen/arch/arm/Kconfig | 3 +- xen/arch/arm/arm64/Makefile | 1 + xen/arch/arm/arm64/cpufeature.c | 7 ++-- xen/arch/arm/arm64/sve.c | 38 +++++++++++++++++++ xen/arch/arm/arm64/sve_asm.S | 48 ++++++++++++++++++++++++ xen/arch/arm/cpufeature.c | 6 ++- xen/arch/arm/domain.c | 4 ++ xen/arch/arm/include/asm/arm64/sve.h | 43 +++++++++++++++++++++ xen/arch/arm/include/asm/arm64/sysregs.h | 1 + xen/arch/arm/include/asm/cpufeature.h | 14 +++++++ xen/arch/arm/include/asm/domain.h | 1 + xen/arch/arm/include/asm/processor.h | 2 + xen/arch/arm/setup.c | 5 ++- xen/arch/arm/traps.c | 34 ++++++++++++----- 14 files changed, 188 insertions(+), 19 deletions(-) create mode 100644 xen/arch/arm/arm64/sve.c create mode 100644 xen/arch/arm/arm64/sve_asm.S create mode 100644 xen/arch/arm/include/asm/arm64/sve.h diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index 239d3aed3c7f..2a5151f3c718 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -112,11 +112,10 @@ config ARM64_PTR_AUTH This feature is not supported in Xen. config ARM64_SVE - def_bool n + bool "Enable Scalar Vector Extension support" if EXPERT depends on ARM_64 help Scalar Vector Extension support. - This feature is not supported in Xen. config ARM64_MTE def_bool n diff --git a/xen/arch/arm/arm64/Makefile b/xen/arch/arm/arm64/Makefile index 6d507da0d44d..1d59c3b0ec89 100644 --- a/xen/arch/arm/arm64/Makefile +++ b/xen/arch/arm/arm64/Makefile @@ -12,6 +12,7 @@ obj-y += insn.o obj-$(CONFIG_LIVEPATCH) += livepatch.o obj-y += smc.o obj-y += smpboot.o +obj-$(CONFIG_ARM64_SVE) += sve.o sve_asm.o obj-y += traps.o obj-y += vfp.o obj-y += vsysreg.o diff --git a/xen/arch/arm/arm64/cpufeature.c b/xen/arch/arm/arm64/cpufeature.c index d9039d37b2d1..b4656ff4d80f 100644 --- a/xen/arch/arm/arm64/cpufeature.c +++ b/xen/arch/arm/arm64/cpufeature.c @@ -455,15 +455,11 @@ static const struct arm64_ftr_bits ftr_id_dfr1[] = { ARM64_FTR_END, }; -#if 0 -/* TODO: use this to sanitize SVE once we support it */ - static const struct arm64_ftr_bits ftr_zcr[] = { ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, ZCR_ELx_LEN_SHIFT, ZCR_ELx_LEN_SIZE, 0), /* LEN */ ARM64_FTR_END, }; -#endif /* * Common ftr bits for a 32bit register with all hidden, strict @@ -603,6 +599,9 @@ void update_system_features(const struct cpuinfo_arm *new) SANITIZE_ID_REG(zfr64, 0, aa64zfr0); + if ( cpu_has_sve ) + SANITIZE_REG(zcr64, 0, zcr); + /* * Comment from Linux: * Userspace may perform DC ZVA instructions. Mismatched block sizes diff --git a/xen/arch/arm/arm64/sve.c b/xen/arch/arm/arm64/sve.c new file mode 100644 index 000000000000..326389278292 --- /dev/null +++ b/xen/arch/arm/arm64/sve.c @@ -0,0 +1,38 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * Arm SVE feature code + * + * Copyright (C) 2022 ARM Ltd. + */ + +#include +#include +#include + +extern unsigned int sve_get_hw_vl(void); + +register_t compute_max_zcr(void) +{ + register_t zcr = vl_to_zcr(SVE_VL_MAX_BITS); + unsigned int hw_vl; + + /* + * Set the maximum SVE vector length, doing that we will know the VL + * supported by the platform, calling sve_get_hw_vl() + */ + WRITE_SYSREG(zcr, ZCR_EL2); + + /* + * Read the maximum VL, which could be lower than what we imposed before, + * hw_vl contains VL in bytes, multiply it by 8 to use vl_to_zcr() later + */ + hw_vl = sve_get_hw_vl() * 8U; + + return vl_to_zcr(hw_vl); +} + +/* Takes a vector length in bits and returns the ZCR_ELx encoding */ +register_t vl_to_zcr(uint16_t vl) +{ + return ((vl / SVE_VL_MULTIPLE_VAL) - 1U) & ZCR_ELx_LEN_MASK; +} diff --git a/xen/arch/arm/arm64/sve_asm.S b/xen/arch/arm/arm64/sve_asm.S new file mode 100644 index 000000000000..4d1549344733 --- /dev/null +++ b/xen/arch/arm/arm64/sve_asm.S @@ -0,0 +1,48 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * Arm SVE assembly routines + * + * Copyright (C) 2022 ARM Ltd. + * + * Some macros and instruction encoding in this file are taken from linux 6.1.1, + * file arch/arm64/include/asm/fpsimdmacros.h, some of them are a modified + * version. + */ + +/* Sanity-check macros to help avoid encoding garbage instructions */ + +.macro _check_general_reg nr + .if (\nr) < 0 || (\nr) > 30 + .error "Bad register number \nr." + .endif +.endm + +.macro _check_num n, min, max + .if (\n) < (\min) || (\n) > (\max) + .error "Number \n out of range [\min,\max]" + .endif +.endm + +/* SVE instruction encodings for non-SVE-capable assemblers */ +/* (pre binutils 2.28, all kernel capable clang versions support SVE) */ + +/* RDVL X\nx, #\imm */ +.macro _sve_rdvl nx, imm + _check_general_reg \nx + _check_num (\imm), -0x20, 0x1f + .inst 0x04bf5000 \ + | (\nx) \ + | (((\imm) & 0x3f) << 5) +.endm + +/* Gets the current vector register size in bytes */ +GLOBAL(sve_get_hw_vl) + _sve_rdvl 0, 1 + ret + +/* + * Local variables: + * mode: ASM + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/arm/cpufeature.c b/xen/arch/arm/cpufeature.c index c4ec38bb2554..83b84368f6d5 100644 --- a/xen/arch/arm/cpufeature.c +++ b/xen/arch/arm/cpufeature.c @@ -9,6 +9,7 @@ #include #include #include +#include #include DECLARE_BITMAP(cpu_hwcaps, ARM_NCAPS); @@ -143,6 +144,9 @@ void identify_cpu(struct cpuinfo_arm *c) c->zfr64.bits[0] = READ_SYSREG(ID_AA64ZFR0_EL1); + if ( cpu_has_sve ) + c->zcr64.bits[0] = compute_max_zcr(); + c->dczid.bits[0] = READ_SYSREG(DCZID_EL0); c->ctr.bits[0] = READ_SYSREG(CTR_EL0); @@ -199,7 +203,7 @@ static int __init create_guest_cpuinfo(void) guest_cpuinfo.pfr64.mpam = 0; guest_cpuinfo.pfr64.mpam_frac = 0; - /* Hide SVE as Xen does not support it */ + /* Hide SVE by default to the guests */ guest_cpuinfo.pfr64.sve = 0; guest_cpuinfo.zfr64.bits[0] = 0; diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c index 99577adb6c69..8ea3843ea8e8 100644 --- a/xen/arch/arm/domain.c +++ b/xen/arch/arm/domain.c @@ -181,6 +181,8 @@ static void ctxt_switch_to(struct vcpu *n) /* VGIC */ gic_restore_state(n); + WRITE_SYSREG(n->arch.cptr_el2, CPTR_EL2); + /* VFP */ vfp_restore_state(n); @@ -548,6 +550,8 @@ int arch_vcpu_create(struct vcpu *v) v->arch.vmpidr = MPIDR_SMP | vcpuid_to_vaffinity(v->vcpu_id); + v->arch.cptr_el2 = get_default_cptr_flags(); + v->arch.hcr_el2 = get_default_hcr_flags(); v->arch.mdcr_el2 = HDCR_TDRA | HDCR_TDOSA | HDCR_TDA; diff --git a/xen/arch/arm/include/asm/arm64/sve.h b/xen/arch/arm/include/asm/arm64/sve.h new file mode 100644 index 000000000000..bd56e2f24230 --- /dev/null +++ b/xen/arch/arm/include/asm/arm64/sve.h @@ -0,0 +1,43 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * Arm SVE feature code + * + * Copyright (C) 2022 ARM Ltd. + */ + +#ifndef _ARM_ARM64_SVE_H +#define _ARM_ARM64_SVE_H + +#define SVE_VL_MAX_BITS (2048U) + +/* Vector length must be multiple of 128 */ +#define SVE_VL_MULTIPLE_VAL (128U) + +#ifdef CONFIG_ARM64_SVE + +register_t compute_max_zcr(void); +register_t vl_to_zcr(uint16_t vl); + +#else /* !CONFIG_ARM64_SVE */ + +static inline register_t compute_max_zcr(void) +{ + return 0; +} + +static inline register_t vl_to_zcr(uint16_t vl) +{ + return 0; +} + +#endif + +#endif /* _ARM_ARM64_SVE_H */ +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/arm/include/asm/arm64/sysregs.h b/xen/arch/arm/include/asm/arm64/sysregs.h index 463899951414..4cabb9eb4d5e 100644 --- a/xen/arch/arm/include/asm/arm64/sysregs.h +++ b/xen/arch/arm/include/asm/arm64/sysregs.h @@ -24,6 +24,7 @@ #define ICH_EISR_EL2 S3_4_C12_C11_3 #define ICH_ELSR_EL2 S3_4_C12_C11_5 #define ICH_VMCR_EL2 S3_4_C12_C11_7 +#define ZCR_EL2 S3_4_C1_C2_0 #define __LR0_EL2(x) S3_4_C12_C12_ ## x #define __LR8_EL2(x) S3_4_C12_C13_ ## x diff --git a/xen/arch/arm/include/asm/cpufeature.h b/xen/arch/arm/include/asm/cpufeature.h index c62cf6293fd6..6d703e051906 100644 --- a/xen/arch/arm/include/asm/cpufeature.h +++ b/xen/arch/arm/include/asm/cpufeature.h @@ -32,6 +32,12 @@ #define cpu_has_thumbee (boot_cpu_feature32(thumbee) == 1) #define cpu_has_aarch32 (cpu_has_arm || cpu_has_thumb) +#ifdef CONFIG_ARM64_SVE +#define cpu_has_sve (boot_cpu_feature64(sve) == 1) +#else +#define cpu_has_sve (0) +#endif + #ifdef CONFIG_ARM_32 #define cpu_has_gicv3 (boot_cpu_feature32(gic) >= 1) #define cpu_has_gentimer (boot_cpu_feature32(gentimer) == 1) @@ -323,6 +329,14 @@ struct cpuinfo_arm { }; } isa64; + union { + register_t bits[1]; + struct { + unsigned long len:4; + unsigned long __res0:60; + }; + } zcr64; + struct { register_t bits[1]; } zfr64; diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm/domain.h index 0e310601e846..42eb5df320a7 100644 --- a/xen/arch/arm/include/asm/domain.h +++ b/xen/arch/arm/include/asm/domain.h @@ -190,6 +190,7 @@ struct arch_vcpu register_t tpidrro_el0; /* HYP configuration */ + register_t cptr_el2; register_t hcr_el2; register_t mdcr_el2; diff --git a/xen/arch/arm/include/asm/processor.h b/xen/arch/arm/include/asm/processor.h index 1dd81d7d528f..0e38926b94db 100644 --- a/xen/arch/arm/include/asm/processor.h +++ b/xen/arch/arm/include/asm/processor.h @@ -583,6 +583,8 @@ void do_trap_guest_serror(struct cpu_user_regs *regs); register_t get_default_hcr_flags(void); +register_t get_default_cptr_flags(void); + /* * Synchronize SError unless the feature is selected. * This is relying on the SErrors are currently unmasked. diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 1f26f67b90e3..5459cc4f5e62 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -135,10 +135,11 @@ static void __init processor_id(void) cpu_has_el2_32 ? "64+32" : cpu_has_el2_64 ? "64" : "No", cpu_has_el1_32 ? "64+32" : cpu_has_el1_64 ? "64" : "No", cpu_has_el0_32 ? "64+32" : cpu_has_el0_64 ? "64" : "No"); - printk(" Extensions:%s%s%s\n", + printk(" Extensions:%s%s%s%s\n", cpu_has_fp ? " FloatingPoint" : "", cpu_has_simd ? " AdvancedSIMD" : "", - cpu_has_gicv3 ? " GICv3-SysReg" : ""); + cpu_has_gicv3 ? " GICv3-SysReg" : "", + cpu_has_sve ? " SVE" : ""); /* Warn user if we find unknown floating-point features */ if ( cpu_has_fp && (boot_cpu_feature64(fp) >= 2) ) diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c index 061c92acbd68..45163fd3afb0 100644 --- a/xen/arch/arm/traps.c +++ b/xen/arch/arm/traps.c @@ -93,6 +93,21 @@ register_t get_default_hcr_flags(void) HCR_TID3|HCR_TSC|HCR_TAC|HCR_SWIO|HCR_TIDCP|HCR_FB|HCR_TSW); } +register_t get_default_cptr_flags(void) +{ + /* + * Trap all coprocessor registers (0-13) except cp10 and + * cp11 for VFP. + * + * /!\ All coprocessors except cp10 and cp11 cannot be used in Xen. + * + * On ARM64 the TCPx bits which we set here (0..9,12,13) are all + * RES1, i.e. they would trap whether we did this write or not. + */ + return ((HCPTR_CP_MASK & ~(HCPTR_CP(10) | HCPTR_CP(11))) | + HCPTR_TTA | HCPTR_TAM); +} + static enum { SERRORS_DIVERSE, SERRORS_PANIC, @@ -122,6 +137,7 @@ __initcall(update_serrors_cpu_caps); void init_traps(void) { + register_t cptr_bits = get_default_cptr_flags(); /* * Setup Hyp vector base. Note they might get updated with the * branch predictor hardening. @@ -135,17 +151,15 @@ void init_traps(void) /* Trap CP15 c15 used for implementation defined registers */ WRITE_SYSREG(HSTR_T(15), HSTR_EL2); - /* Trap all coprocessor registers (0-13) except cp10 and - * cp11 for VFP. - * - * /!\ All coprocessors except cp10 and cp11 cannot be used in Xen. - * - * On ARM64 the TCPx bits which we set here (0..9,12,13) are all - * RES1, i.e. they would trap whether we did this write or not. +#ifdef CONFIG_ARM64_SVE + /* + * Don't trap SVE now, Xen might need to access ZCR reg in cpufeature code, + * trapping again or not will be handled on vcpu creation/scheduling later */ - WRITE_SYSREG((HCPTR_CP_MASK & ~(HCPTR_CP(10) | HCPTR_CP(11))) | - HCPTR_TTA | HCPTR_TAM, - CPTR_EL2); + cptr_bits &= ~HCPTR_CP(8); +#endif + + WRITE_SYSREG(cptr_bits, CPTR_EL2); /* * Configure HCR_EL2 with the bare minimum to run Xen until a guest -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Wed Jan 11 14:38:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 14:38:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475456.737199 (Exim 4.92) (envelope-from ) id 1pFcFZ-0001v4-59; Wed, 11 Jan 2023 14:38:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475456.737199; Wed, 11 Jan 2023 14:38:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFcFZ-0001u5-0e; Wed, 11 Jan 2023 14:38:45 +0000 Received: by outflank-mailman (input) for mailman id 475456; Wed, 11 Jan 2023 14:38:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFcFX-0001NK-JO for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 14:38:43 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id a472b751-91bd-11ed-b8d0-410ff93cb8f0; Wed, 11 Jan 2023 15:38:41 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E4BDE15DB; Wed, 11 Jan 2023 06:39:22 -0800 (PST) Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com [10.1.195.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 885FB3F71A; Wed, 11 Jan 2023 06:38:39 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a472b751-91bd-11ed-b8d0-410ff93cb8f0 From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: [RFC PATCH 2/8] xen/arm: add sve_vl_bits field to domain Date: Wed, 11 Jan 2023 14:38:20 +0000 Message-Id: <20230111143826.3224-3-luca.fancellu@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230111143826.3224-1-luca.fancellu@arm.com> References: <20230111143826.3224-1-luca.fancellu@arm.com> Add sve_vl_bits field to arch_domain and xen_arch_domainconfig structure, to allow the domain to have an information about the SVE feature and the number of SVE register bits that are allowed for this domain. The field is used also to allow or forbid a domain to use SVE, because a value equal to zero means the guest is not allowed to use the feature. When the guest is allowed to use SVE, the zcr_el2 register is updated on context switch to restict the domain on the allowed number of bits chosen, this value is the minimum among the chosen value and the platform supported value. Signed-off-by: Luca Fancellu --- xen/arch/arm/arm64/sve.c | 9 ++++++ xen/arch/arm/domain.c | 45 ++++++++++++++++++++++++++++ xen/arch/arm/include/asm/arm64/sve.h | 12 ++++++++ xen/arch/arm/include/asm/domain.h | 6 ++++ xen/include/public/arch-arm.h | 2 ++ xen/include/public/domctl.h | 2 +- 6 files changed, 75 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/arm64/sve.c b/xen/arch/arm/arm64/sve.c index 326389278292..b7695834f4ba 100644 --- a/xen/arch/arm/arm64/sve.c +++ b/xen/arch/arm/arm64/sve.c @@ -6,6 +6,7 @@ */ #include +#include #include #include @@ -36,3 +37,11 @@ register_t vl_to_zcr(uint16_t vl) { return ((vl / SVE_VL_MULTIPLE_VAL) - 1U) & ZCR_ELx_LEN_MASK; } + +/* Get the system sanitized value for VL in bits */ +uint16_t get_sys_vl_len(void) +{ + /* ZCR_ELx len field is ((len+1) * 128) = vector bits length */ + return ((system_cpuinfo.zcr64.bits[0] & ZCR_ELx_LEN_MASK) + 1U) * + SVE_VL_MULTIPLE_VAL; +} diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c index 8ea3843ea8e8..27f38729302b 100644 --- a/xen/arch/arm/domain.c +++ b/xen/arch/arm/domain.c @@ -13,6 +13,7 @@ #include #include +#include #include #include #include @@ -183,6 +184,11 @@ static void ctxt_switch_to(struct vcpu *n) WRITE_SYSREG(n->arch.cptr_el2, CPTR_EL2); +#ifdef CONFIG_ARM64_SVE + if ( is_sve_domain(n->domain) ) + WRITE_SYSREG(n->arch.zcr_el2, ZCR_EL2); +#endif + /* VFP */ vfp_restore_state(n); @@ -551,6 +557,11 @@ int arch_vcpu_create(struct vcpu *v) v->arch.vmpidr = MPIDR_SMP | vcpuid_to_vaffinity(v->vcpu_id); v->arch.cptr_el2 = get_default_cptr_flags(); + if ( is_sve_domain(v->domain) ) + { + v->arch.cptr_el2 &= ~HCPTR_CP(8); + v->arch.zcr_el2 = vl_to_zcr(v->domain->arch.sve_vl_bits); + } v->arch.hcr_el2 = get_default_hcr_flags(); @@ -595,6 +606,7 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config) unsigned int max_vcpus; unsigned int flags_required = (XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap); unsigned int flags_optional = (XEN_DOMCTL_CDF_iommu | XEN_DOMCTL_CDF_vpmu); + unsigned int sve_vl_bits = config->arch.sve_vl_bits; if ( (config->flags & ~flags_optional) != flags_required ) { @@ -603,6 +615,36 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config) return -EINVAL; } + /* Check feature flags */ + if ( sve_vl_bits > 0 ) { + unsigned int zcr_max_bits; + + if ( !cpu_has_sve ) + { + dprintk(XENLOG_INFO, "SVE is unsupported on this machine.\n"); + return -EINVAL; + } + else if ( !is_vl_valid(sve_vl_bits) ) + { + dprintk(XENLOG_INFO, "Unsupported SVE vector length (%u)\n", + sve_vl_bits); + return -EINVAL; + } + /* + * get_sys_vl_len() is the common safe value among all cpus, so if the + * value specified by the user is above that value, use the safe value + * instead. + */ + zcr_max_bits = get_sys_vl_len(); + if ( sve_vl_bits > zcr_max_bits ) + { + config->arch.sve_vl_bits = zcr_max_bits; + dprintk(XENLOG_INFO, + "SVE vector length lowered to %u, safe value among CPUs\n", + zcr_max_bits); + } + } + /* The P2M table must always be shared between the CPU and the IOMMU */ if ( config->iommu_opts & XEN_DOMCTL_IOMMU_no_sharept ) { @@ -745,6 +787,9 @@ int arch_domain_create(struct domain *d, if ( (rc = domain_vpci_init(d)) != 0 ) goto fail; + /* Copy sve_vl_bits to the domain configuration */ + d->arch.sve_vl_bits = config->arch.sve_vl_bits; + return 0; fail: diff --git a/xen/arch/arm/include/asm/arm64/sve.h b/xen/arch/arm/include/asm/arm64/sve.h index bd56e2f24230..f4a660e402ca 100644 --- a/xen/arch/arm/include/asm/arm64/sve.h +++ b/xen/arch/arm/include/asm/arm64/sve.h @@ -13,10 +13,17 @@ /* Vector length must be multiple of 128 */ #define SVE_VL_MULTIPLE_VAL (128U) +static inline bool is_vl_valid(uint16_t vl) +{ + /* SVE vector length is multiple of 128 and maximum 2048 */ + return ((vl % SVE_VL_MULTIPLE_VAL) == 0) && (vl <= SVE_VL_MAX_BITS); +} + #ifdef CONFIG_ARM64_SVE register_t compute_max_zcr(void); register_t vl_to_zcr(uint16_t vl); +uint16_t get_sys_vl_len(void); #else /* !CONFIG_ARM64_SVE */ @@ -30,6 +37,11 @@ static inline register_t vl_to_zcr(uint16_t vl) return 0; } +static inline uint16_t get_sys_vl_len(void) +{ + return 0; +} + #endif #endif /* _ARM_ARM64_SVE_H */ diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm/domain.h index 42eb5df320a7..e4794a9fd2ab 100644 --- a/xen/arch/arm/include/asm/domain.h +++ b/xen/arch/arm/include/asm/domain.h @@ -31,6 +31,8 @@ enum domain_type { #define is_domain_direct_mapped(d) ((d)->cdf & CDF_directmap) +#define is_sve_domain(d) ((d)->arch.sve_vl_bits > 0) + /* * Is the domain using the host memory layout? * @@ -114,6 +116,9 @@ struct arch_domain void *tee; #endif + /* max SVE vector length in bits */ + uint16_t sve_vl_bits; + } __cacheline_aligned; struct arch_vcpu @@ -190,6 +195,7 @@ struct arch_vcpu register_t tpidrro_el0; /* HYP configuration */ + register_t zcr_el2; register_t cptr_el2; register_t hcr_el2; register_t mdcr_el2; diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h index 1528ced5097a..e18a075105f0 100644 --- a/xen/include/public/arch-arm.h +++ b/xen/include/public/arch-arm.h @@ -304,6 +304,8 @@ struct xen_arch_domainconfig { uint16_t tee_type; /* IN */ uint32_t nr_spis; + /* IN */ + uint16_t sve_vl_bits; /* * OUT * Based on the property clock-frequency in the DT timer node. diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h index 51be28c3de7c..616d7a1c070d 100644 --- a/xen/include/public/domctl.h +++ b/xen/include/public/domctl.h @@ -21,7 +21,7 @@ #include "hvm/save.h" #include "memory.h" -#define XEN_DOMCTL_INTERFACE_VERSION 0x00000015 +#define XEN_DOMCTL_INTERFACE_VERSION 0x00000016 /* * NB. xen_domctl.domain is an IN/OUT parameter for this operation. -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Wed Jan 11 14:38:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 14:38:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475458.737210 (Exim 4.92) (envelope-from ) id 1pFcFd-0002Ge-FU; Wed, 11 Jan 2023 14:38:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475458.737210; Wed, 11 Jan 2023 14:38:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFcFd-0002GV-An; Wed, 11 Jan 2023 14:38:49 +0000 Received: by outflank-mailman (input) for mailman id 475458; Wed, 11 Jan 2023 14:38:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFcFb-0001NK-Ku for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 14:38:47 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id a681ec48-91bd-11ed-b8d0-410ff93cb8f0; Wed, 11 Jan 2023 15:38:44 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 51FE913D5; Wed, 11 Jan 2023 06:39:26 -0800 (PST) Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com [10.1.195.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 45D913F71A; Wed, 11 Jan 2023 06:38:43 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a681ec48-91bd-11ed-b8d0-410ff93cb8f0 From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [RFC PATCH 5/8] arm/sve: save/restore SVE context switch Date: Wed, 11 Jan 2023 14:38:23 +0000 Message-Id: <20230111143826.3224-6-luca.fancellu@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230111143826.3224-1-luca.fancellu@arm.com> References: <20230111143826.3224-1-luca.fancellu@arm.com> Save/restore context switch for SVE, allocate memory to contain the Z0-31 registers whose length is maximum 2048 bits each and FFR who can be maximum 256 bits, the allocated memory depends on how many bits is the vector length for the domain and how many bits are supported by the platform. Save P0-15 whose length is maximum 256 bits each, in this case the memory used is from the fpregs field in struct vfp_state, because V0-31 are part of Z0-31 and this space would have been unused for SVE domain otherwise. Create zcr_el1 field in arch_vcpu and save/restore ZCR_EL1 value on context switch. Remove headers from sve.c that are already included using xen/sched.h. Signed-off-by: Luca Fancellu --- xen/arch/arm/arm64/sve.c | 58 +++++++++- xen/arch/arm/arm64/sve_asm.S | 141 +++++++++++++++++++++++ xen/arch/arm/arm64/vfp.c | 79 +++++++------ xen/arch/arm/domain.c | 12 ++ xen/arch/arm/include/asm/arm64/sve.h | 13 +++ xen/arch/arm/include/asm/arm64/sysregs.h | 3 + xen/arch/arm/include/asm/arm64/vfp.h | 10 ++ xen/arch/arm/include/asm/domain.h | 1 + 8 files changed, 280 insertions(+), 37 deletions(-) diff --git a/xen/arch/arm/arm64/sve.c b/xen/arch/arm/arm64/sve.c index b7695834f4ba..c7b325700fe4 100644 --- a/xen/arch/arm/arm64/sve.c +++ b/xen/arch/arm/arm64/sve.c @@ -5,12 +5,29 @@ * Copyright (C) 2022 ARM Ltd. */ -#include -#include +#include +#include #include -#include extern unsigned int sve_get_hw_vl(void); +extern void sve_save_ctx(uint64_t *sve_ctx, uint64_t *pregs, int save_ffr); +extern void sve_load_ctx(uint64_t const *sve_ctx, uint64_t const *pregs, + int restore_ffr); + +static inline uint16_t sve_zreg_ctx_size(uint16_t vl) +{ + /* + * Z0-31 registers size in bytes is computed from VL that is in bits, so VL + * in bytes is VL/8. + */ + return (vl / 8U) * 32U; +} + +static inline uint16_t sve_ffrreg_ctx_size(uint16_t vl) +{ + /* FFR register size is VL/8, which is in bytes (VL/8)/8 */ + return (vl / 64U); +} register_t compute_max_zcr(void) { @@ -45,3 +62,38 @@ uint16_t get_sys_vl_len(void) return ((system_cpuinfo.zcr64.bits[0] & ZCR_ELx_LEN_MASK) + 1U) * SVE_VL_MULTIPLE_VAL; } + +int sve_context_init(struct vcpu *v) +{ + uint64_t *ctx = _xzalloc(sve_zreg_ctx_size(v->domain->arch.sve_vl_bits) + + sve_ffrreg_ctx_size(v->domain->arch.sve_vl_bits), + L1_CACHE_BYTES); + + if ( !ctx ) + return -ENOMEM; + + v->arch.vfp.sve_context = ctx; + + return 0; +} + +void sve_context_free(struct vcpu *v) +{ + xfree(v->arch.vfp.sve_context); +} + +void sve_save_state(struct vcpu *v) +{ + uint64_t *sve_ctx_zreg_end = v->arch.vfp.sve_context + + (sve_zreg_ctx_size(v->domain->arch.sve_vl_bits) / sizeof(uint64_t)); + + sve_save_ctx(sve_ctx_zreg_end, v->arch.vfp.fpregs, 1); +} + +void sve_restore_state(struct vcpu *v) +{ + uint64_t *sve_ctx_zreg_end = v->arch.vfp.sve_context + + (sve_zreg_ctx_size(v->domain->arch.sve_vl_bits) / sizeof(uint64_t)); + + sve_load_ctx(sve_ctx_zreg_end, v->arch.vfp.fpregs, 1); +} diff --git a/xen/arch/arm/arm64/sve_asm.S b/xen/arch/arm/arm64/sve_asm.S index 4d1549344733..8c37d7bc95d5 100644 --- a/xen/arch/arm/arm64/sve_asm.S +++ b/xen/arch/arm/arm64/sve_asm.S @@ -17,6 +17,18 @@ .endif .endm +.macro _sve_check_zreg znr + .if (\znr) < 0 || (\znr) > 31 + .error "Bad Scalable Vector Extension vector register number \znr." + .endif +.endm + +.macro _sve_check_preg pnr + .if (\pnr) < 0 || (\pnr) > 15 + .error "Bad Scalable Vector Extension predicate register number \pnr." + .endif +.endm + .macro _check_num n, min, max .if (\n) < (\min) || (\n) > (\max) .error "Number \n out of range [\min,\max]" @@ -26,6 +38,54 @@ /* SVE instruction encodings for non-SVE-capable assemblers */ /* (pre binutils 2.28, all kernel capable clang versions support SVE) */ +/* STR (vector): STR Z\nz, [X\nxbase, #\offset, MUL VL] */ +.macro _sve_str_v nz, nxbase, offset=0 + _sve_check_zreg \nz + _check_general_reg \nxbase + _check_num (\offset), -0x100, 0xff + .inst 0xe5804000 \ + | (\nz) \ + | ((\nxbase) << 5) \ + | (((\offset) & 7) << 10) \ + | (((\offset) & 0x1f8) << 13) +.endm + +/* LDR (vector): LDR Z\nz, [X\nxbase, #\offset, MUL VL] */ +.macro _sve_ldr_v nz, nxbase, offset=0 + _sve_check_zreg \nz + _check_general_reg \nxbase + _check_num (\offset), -0x100, 0xff + .inst 0x85804000 \ + | (\nz) \ + | ((\nxbase) << 5) \ + | (((\offset) & 7) << 10) \ + | (((\offset) & 0x1f8) << 13) +.endm + +/* STR (predicate): STR P\np, [X\nxbase, #\offset, MUL VL] */ +.macro _sve_str_p np, nxbase, offset=0 + _sve_check_preg \np + _check_general_reg \nxbase + _check_num (\offset), -0x100, 0xff + .inst 0xe5800000 \ + | (\np) \ + | ((\nxbase) << 5) \ + | (((\offset) & 7) << 10) \ + | (((\offset) & 0x1f8) << 13) +.endm + +/* LDR (predicate): LDR P\np, [X\nxbase, #\offset, MUL VL] */ +.macro _sve_ldr_p np, nxbase, offset=0 + _sve_check_preg \np + _check_general_reg \nxbase + _check_num (\offset), -0x100, 0xff + .inst 0x85800000 \ + | (\np) \ + | ((\nxbase) << 5) \ + | (((\offset) & 7) << 10) \ + | (((\offset) & 0x1f8) << 13) +.endm + /* RDVL X\nx, #\imm */ .macro _sve_rdvl nx, imm _check_general_reg \nx @@ -35,11 +95,92 @@ | (((\imm) & 0x3f) << 5) .endm +/* RDFFR (unpredicated): RDFFR P\np.B */ +.macro _sve_rdffr np + _sve_check_preg \np + .inst 0x2519f000 \ + | (\np) +.endm + +/* WRFFR P\np.B */ +.macro _sve_wrffr np + _sve_check_preg \np + .inst 0x25289000 \ + | ((\np) << 5) +.endm + +.macro __for from:req, to:req + .if (\from) == (\to) + _for__body %\from + .else + __for %\from, %((\from) + ((\to) - (\from)) / 2) + __for %((\from) + ((\to) - (\from)) / 2 + 1), %\to + .endif +.endm + +.macro _for var:req, from:req, to:req, insn:vararg + .macro _for__body \var:req + .noaltmacro + \insn + .altmacro + .endm + + .altmacro + __for \from, \to + .noaltmacro + + .purgem _for__body +.endm + +.macro sve_save nxzffrctx, nxpctx, save_ffr + _for n, 0, 31, _sve_str_v \n, \nxzffrctx, \n - 32 + _for n, 0, 15, _sve_str_p \n, \nxpctx, \n + cbz \save_ffr, 1f + _sve_rdffr 0 + _sve_str_p 0, \nxzffrctx + _sve_ldr_p 0, \nxpctx + b 2f +1: + str xzr, [x\nxzffrctx] // Zero out FFR +2: +.endm + +.macro sve_load nxzffrctx, nxpctx, restore_ffr + _for n, 0, 31, _sve_ldr_v \n, \nxzffrctx, \n - 32 + cbz \restore_ffr, 1f + _sve_ldr_p 0, \nxzffrctx + _sve_wrffr 0 +1: + _for n, 0, 15, _sve_ldr_p \n, \nxpctx, \n +.endm + /* Gets the current vector register size in bytes */ GLOBAL(sve_get_hw_vl) _sve_rdvl 0, 1 ret +/* + * Save the SVE context + * + * x0 - pointer to buffer for Z0-31 + FFR + * x1 - pointer to buffer for P0-15 + * x2 - Save FFR if non-zero + */ +GLOBAL(sve_save_ctx) + sve_save 0, 1, x2 + ret + +/* + * Load the SVE context + * + * x0 - pointer to buffer for Z0-31 + FFR + * x1 - pointer to buffer for P0-15 + * x2 - Restore FFR if non-zero + */ +GLOBAL(sve_load_ctx) + sve_load 0, 1, x2 + ret + /* * Local variables: * mode: ASM diff --git a/xen/arch/arm/arm64/vfp.c b/xen/arch/arm/arm64/vfp.c index 47885e76baae..2d0d7c2e6ddb 100644 --- a/xen/arch/arm/arm64/vfp.c +++ b/xen/arch/arm/arm64/vfp.c @@ -2,29 +2,35 @@ #include #include #include +#include void vfp_save_state(struct vcpu *v) { if ( !cpu_has_fp ) return; - asm volatile("stp q0, q1, [%1, #16 * 0]\n\t" - "stp q2, q3, [%1, #16 * 2]\n\t" - "stp q4, q5, [%1, #16 * 4]\n\t" - "stp q6, q7, [%1, #16 * 6]\n\t" - "stp q8, q9, [%1, #16 * 8]\n\t" - "stp q10, q11, [%1, #16 * 10]\n\t" - "stp q12, q13, [%1, #16 * 12]\n\t" - "stp q14, q15, [%1, #16 * 14]\n\t" - "stp q16, q17, [%1, #16 * 16]\n\t" - "stp q18, q19, [%1, #16 * 18]\n\t" - "stp q20, q21, [%1, #16 * 20]\n\t" - "stp q22, q23, [%1, #16 * 22]\n\t" - "stp q24, q25, [%1, #16 * 24]\n\t" - "stp q26, q27, [%1, #16 * 26]\n\t" - "stp q28, q29, [%1, #16 * 28]\n\t" - "stp q30, q31, [%1, #16 * 30]\n\t" - : "=Q" (*v->arch.vfp.fpregs) : "r" (v->arch.vfp.fpregs)); + if ( is_sve_domain(v->domain) ) + sve_save_state(v); + else + { + asm volatile("stp q0, q1, [%1, #16 * 0]\n\t" + "stp q2, q3, [%1, #16 * 2]\n\t" + "stp q4, q5, [%1, #16 * 4]\n\t" + "stp q6, q7, [%1, #16 * 6]\n\t" + "stp q8, q9, [%1, #16 * 8]\n\t" + "stp q10, q11, [%1, #16 * 10]\n\t" + "stp q12, q13, [%1, #16 * 12]\n\t" + "stp q14, q15, [%1, #16 * 14]\n\t" + "stp q16, q17, [%1, #16 * 16]\n\t" + "stp q18, q19, [%1, #16 * 18]\n\t" + "stp q20, q21, [%1, #16 * 20]\n\t" + "stp q22, q23, [%1, #16 * 22]\n\t" + "stp q24, q25, [%1, #16 * 24]\n\t" + "stp q26, q27, [%1, #16 * 26]\n\t" + "stp q28, q29, [%1, #16 * 28]\n\t" + "stp q30, q31, [%1, #16 * 30]\n\t" + : "=Q" (*v->arch.vfp.fpregs) : "r" (v->arch.vfp.fpregs)); + } v->arch.vfp.fpsr = READ_SYSREG(FPSR); v->arch.vfp.fpcr = READ_SYSREG(FPCR); @@ -37,23 +43,28 @@ void vfp_restore_state(struct vcpu *v) if ( !cpu_has_fp ) return; - asm volatile("ldp q0, q1, [%1, #16 * 0]\n\t" - "ldp q2, q3, [%1, #16 * 2]\n\t" - "ldp q4, q5, [%1, #16 * 4]\n\t" - "ldp q6, q7, [%1, #16 * 6]\n\t" - "ldp q8, q9, [%1, #16 * 8]\n\t" - "ldp q10, q11, [%1, #16 * 10]\n\t" - "ldp q12, q13, [%1, #16 * 12]\n\t" - "ldp q14, q15, [%1, #16 * 14]\n\t" - "ldp q16, q17, [%1, #16 * 16]\n\t" - "ldp q18, q19, [%1, #16 * 18]\n\t" - "ldp q20, q21, [%1, #16 * 20]\n\t" - "ldp q22, q23, [%1, #16 * 22]\n\t" - "ldp q24, q25, [%1, #16 * 24]\n\t" - "ldp q26, q27, [%1, #16 * 26]\n\t" - "ldp q28, q29, [%1, #16 * 28]\n\t" - "ldp q30, q31, [%1, #16 * 30]\n\t" - : : "Q" (*v->arch.vfp.fpregs), "r" (v->arch.vfp.fpregs)); + if ( is_sve_domain(v->domain) ) + sve_restore_state(v); + else + { + asm volatile("ldp q0, q1, [%1, #16 * 0]\n\t" + "ldp q2, q3, [%1, #16 * 2]\n\t" + "ldp q4, q5, [%1, #16 * 4]\n\t" + "ldp q6, q7, [%1, #16 * 6]\n\t" + "ldp q8, q9, [%1, #16 * 8]\n\t" + "ldp q10, q11, [%1, #16 * 10]\n\t" + "ldp q12, q13, [%1, #16 * 12]\n\t" + "ldp q14, q15, [%1, #16 * 14]\n\t" + "ldp q16, q17, [%1, #16 * 16]\n\t" + "ldp q18, q19, [%1, #16 * 18]\n\t" + "ldp q20, q21, [%1, #16 * 20]\n\t" + "ldp q22, q23, [%1, #16 * 22]\n\t" + "ldp q24, q25, [%1, #16 * 24]\n\t" + "ldp q26, q27, [%1, #16 * 26]\n\t" + "ldp q28, q29, [%1, #16 * 28]\n\t" + "ldp q30, q31, [%1, #16 * 30]\n\t" + : : "Q" (*v->arch.vfp.fpregs), "r" (v->arch.vfp.fpregs)); + } WRITE_SYSREG(v->arch.vfp.fpsr, FPSR); WRITE_SYSREG(v->arch.vfp.fpcr, FPCR); diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c index 27f38729302b..228cd2f7627e 100644 --- a/xen/arch/arm/domain.c +++ b/xen/arch/arm/domain.c @@ -159,6 +159,11 @@ static void ctxt_switch_from(struct vcpu *p) /* VFP */ vfp_save_state(p); +#ifdef CONFIG_ARM64_SVE + if ( is_sve_domain(p->domain) ) + p->arch.zcr_el1 = READ_SYSREG(ZCR_EL1); +#endif + /* VGIC */ gic_save_state(p); @@ -186,7 +191,10 @@ static void ctxt_switch_to(struct vcpu *n) #ifdef CONFIG_ARM64_SVE if ( is_sve_domain(n->domain) ) + { + WRITE_SYSREG(n->arch.zcr_el1, ZCR_EL1); WRITE_SYSREG(n->arch.zcr_el2, ZCR_EL2); + } #endif /* VFP */ @@ -559,6 +567,8 @@ int arch_vcpu_create(struct vcpu *v) v->arch.cptr_el2 = get_default_cptr_flags(); if ( is_sve_domain(v->domain) ) { + if ( (rc = sve_context_init(v)) != 0 ) + goto fail; v->arch.cptr_el2 &= ~HCPTR_CP(8); v->arch.zcr_el2 = vl_to_zcr(v->domain->arch.sve_vl_bits); } @@ -591,6 +601,8 @@ fail: void arch_vcpu_destroy(struct vcpu *v) { + if ( is_sve_domain(v->domain) ) + sve_context_free(v); vcpu_timer_destroy(v); vcpu_vgic_free(v); free_xenheap_pages(v->arch.stack, STACK_ORDER); diff --git a/xen/arch/arm/include/asm/arm64/sve.h b/xen/arch/arm/include/asm/arm64/sve.h index f4a660e402ca..28c31b329233 100644 --- a/xen/arch/arm/include/asm/arm64/sve.h +++ b/xen/arch/arm/include/asm/arm64/sve.h @@ -24,6 +24,10 @@ static inline bool is_vl_valid(uint16_t vl) register_t compute_max_zcr(void); register_t vl_to_zcr(uint16_t vl); uint16_t get_sys_vl_len(void); +int sve_context_init(struct vcpu *v); +void sve_context_free(struct vcpu *v); +void sve_save_state(struct vcpu *v); +void sve_restore_state(struct vcpu *v); #else /* !CONFIG_ARM64_SVE */ @@ -42,6 +46,15 @@ static inline uint16_t get_sys_vl_len(void) return 0; } +static inline int sve_context_init(struct vcpu *v) +{ + return 0; +} + +static inline void sve_context_free(struct vcpu *v) {} +static inline void sve_save_state(struct vcpu *v) {} +static inline void sve_restore_state(struct vcpu *v) {} + #endif #endif /* _ARM_ARM64_SVE_H */ diff --git a/xen/arch/arm/include/asm/arm64/sysregs.h b/xen/arch/arm/include/asm/arm64/sysregs.h index 4cabb9eb4d5e..3fdeb9d8cdef 100644 --- a/xen/arch/arm/include/asm/arm64/sysregs.h +++ b/xen/arch/arm/include/asm/arm64/sysregs.h @@ -88,6 +88,9 @@ #ifndef ID_AA64ISAR2_EL1 #define ID_AA64ISAR2_EL1 S3_0_C0_C6_2 #endif +#ifndef ZCR_EL1 +#define ZCR_EL1 S3_0_C1_C2_0 +#endif /* ID registers (imported from arm64/include/asm/sysreg.h in Linux) */ diff --git a/xen/arch/arm/include/asm/arm64/vfp.h b/xen/arch/arm/include/asm/arm64/vfp.h index e6e8c363bc16..8af714cb8ecc 100644 --- a/xen/arch/arm/include/asm/arm64/vfp.h +++ b/xen/arch/arm/include/asm/arm64/vfp.h @@ -6,7 +6,17 @@ struct vfp_state { + /* + * When SVE is enabled for the guest, fpregs memory will be used to + * save/restore P0-P15 registers, otherwise it will be used for the V0-V31 + * registers. + */ uint64_t fpregs[64] __vfp_aligned; + /* + * When SVE is enabled for the guest, sve_context contains memory to + * save/restore Z0-Z31 registers and FFR. + */ + uint64_t *sve_context; register_t fpcr; register_t fpexc32_el2; register_t fpsr; diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm/domain.h index e4794a9fd2ab..4d1066750a9b 100644 --- a/xen/arch/arm/include/asm/domain.h +++ b/xen/arch/arm/include/asm/domain.h @@ -195,6 +195,7 @@ struct arch_vcpu register_t tpidrro_el0; /* HYP configuration */ + register_t zcr_el1; register_t zcr_el2; register_t cptr_el2; register_t hcr_el2; -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Wed Jan 11 14:45:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 14:45:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475482.737221 (Exim 4.92) (envelope-from ) id 1pFcLq-0004sl-BA; Wed, 11 Jan 2023 14:45:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475482.737221; Wed, 11 Jan 2023 14:45:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFcLq-0004se-8W; Wed, 11 Jan 2023 14:45:14 +0000 Received: by outflank-mailman (input) for mailman id 475482; Wed, 11 Jan 2023 14:45:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFcGC-0001NK-ST for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 14:39:25 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2082.outbound.protection.outlook.com [40.107.22.82]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bd320209-91bd-11ed-b8d0-410ff93cb8f0; Wed, 11 Jan 2023 15:39:23 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB9449.eurprd04.prod.outlook.com (2603:10a6:10:36a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.13; Wed, 11 Jan 2023 14:39:20 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Wed, 11 Jan 2023 14:39:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bd320209-91bd-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bCsAl/kMOXrBQ+C84FPAsm2zEivtdtQMLY9fJE+RdP020q3F3RNI1mpJMumi1UhYOarGF+BskxCJ0WwI3d8ViT0R2/hr6x6zI7+SIr8/ytWWRquozs8Y8f90PJmuTp2QBEqVYSrn/OSuO9kKCsBDTK2cgs1yO+RwqzC7//9I3cHUOcxLQyl8d0vdAgOhe8Qm6lFdaZJ16E2ixK6YfeccAwszvzzm5kQcPMg2sjyiKcxfhR3BSKEykUYOz1EpICxGYb7xyK35/Kn7gYQOxQ7FFDKk0T+kC/+ezbBooXyAS6BJTPCtLx+F73TKcES+PDwev3udnU/JM9toIBvOQ6lURw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wLFn4NbS1Lo3PpETX2gDmRJejP1llNLWgrYgaeEIQ5M=; b=WUTbBFt8P5H/Uk2jllIuUm7SKercGaVFmCX42k9Qaf7ZjPqAog13T8ffd8BGT7F9O/g/4DT7aGIP5xODxNb0umX4Vkinl2p+TddTmiQJVWSztb++RVitPmzqOmiwXDAYdp199PUrLOYYixLD3reuzLAnce5/Y6pnQUMvKlHwLdy/jEuuN2hr3vHbvKwIIxEtVFawPxvZSTLanVbQIfwicZf9I2WN1lmVYco7KO460rOLXh7sqPwnCGKHFz39HsIkLIj7jksjxEc3CQVybDV3d6ULruAmLW7R1AJk9wI4+kJTNO+jaiPGwazib5MPTPPTbNuruHeL9BkBbhgTDlLAvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wLFn4NbS1Lo3PpETX2gDmRJejP1llNLWgrYgaeEIQ5M=; b=dv3QEB3m+WD2w+2OpuLm1cAHtvL3P2NDDjvo/VAmrGMHN+5UIZGiaDX4KTIHAnxZuXukDG4VdwPbvwoxywVU00Qs4tkySsfGVE7GVJXetSzKDLN5dHC/V6KcQrU+zCysCBjHsXnZgggcNn1hYnTEJyGzSoGbFr8IRG+b2ymLVgOwSay1m5fkjvkwt64yfepx8GgYidX/e6jyaQaxgXJ4hfIOBqwPwiG7xHFjHnCxZud8SFfKtpZ9cNFlZbRdH4PRT0HBsb/RFpHh+Mf3zx6+ELUzZWsszZxBmJHLDYZQ44RC85y5qbi2Gn0HDuIPAeGXjKoSB2FFy9uTkdFlNxDzfQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <71e7227c-347e-6439-f3ab-827f2e646c24@suse.com> Date: Wed, 11 Jan 2023 15:39:18 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 17/22] x86/setup: vmap heap nodes when they are outside the direct map Content-Language: en-US To: Julien Grall Cc: Hongyan Xia , Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , Julien Grall , xen-devel@lists.xenproject.org References: <20221216114853.8227-1-julien@xen.org> <20221216114853.8227-18-julien@xen.org> From: Jan Beulich In-Reply-To: <20221216114853.8227-18-julien@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0147.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB9449:EE_ X-MS-Office365-Filtering-Correlation-Id: 112d85e4-31b6-4433-edc0-08daf3e1a025 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ti0cH0TOFMH7ABtn8KXml3Oh/XMP5JhK2g0NNXptnYjlkBBnvunSdHkB1HPy3eaPh8hmvxek3hZuCGrx1NAZnt2WR9OiQ3D0Gc6cZWi2ZZEs+XXj7HeNfSTHomFqENw+/dBPuPjh3E67YT/PFFe6bMFaVfKYzqaStzVi7AOSrXGXQN7F/RvDXteVl+8DAXgpeyGDWEFflq8UX2pAe8EfHRuQm5SHrBFsD5vEcmD1s5KKu8z8VaOptE9ezKMs4d14pKisX+hdxifeFf8yzs2nIlLZ/3WMmG7pUTnyEKTWlCZirihVqqOtuZjSwacrw2DMF6KV2vyHBppbRmNEl/pEfbWOs4suc3PNCtUcxKaNSdwg68DVEUEcjwcoASNd5KjpIoQcsZzY8Id3tJHKUwSkSRanKvrcV7tulAnJZV70vD2EI9xEcO1SVlRn2YO6gEetjSJOADwtBj/+vm3BtaksF9LcHaMBR1IcWj4hlAq+TbLmgLqNDmobhLb5FJm9KIodFK/wb5ipFkGTe1QCtP8Se3m5V9Q6e62AaeE32/hNsxisvo7fKMVQsJGtkwWeolgv8BzYBshLB/motfo+2IMKdgbYJ/2ojkz6OwSqgU5V55xniXeILBYMBFAFdDZzuar3RDL1GS3xWwflcHe0k9f7EUvl9h/B5ipcDl+xrzgUx3IjbYKTIOqfBE0C15PHRi9upvG426DEIGRbFGvf4eX/vX2ZGrPOkS+10vdIIxxZlyM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(39860400002)(396003)(136003)(376002)(366004)(451199015)(6506007)(2906002)(36756003)(8676002)(4326008)(6916009)(5660300002)(53546011)(8936002)(31686004)(38100700002)(6512007)(41300700001)(478600001)(6486002)(26005)(66476007)(66946007)(66556008)(186003)(86362001)(31696002)(2616005)(54906003)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RlV6VGcwL0t2dVVpN2JCY01iZFZpTk8xZmprN3ZTQ1c3M1oyMjhZS2wyWGdB?= =?utf-8?B?YnVjYmR0Q0E4UjcwNnp6RG5SQ0pFeGJBUXNpYzNOQzhEVHdLUEhRcW1aUGti?= =?utf-8?B?V1NKNVJOalBVbVZ0UFdQZytWNmR1eGdCLzNma3BZamYyNHNISTV2WUkvTjNh?= =?utf-8?B?TE1xbmxRWTRONXB6NHBrTzJvOVIwMmRNc3lKd2xpN3pUSUVTcExqMEZqR1o3?= =?utf-8?B?S2xWRHh6ejZGSGhWRzhVMnppdmRrRnNQNkNvRFp1K2h2K21wQXVnUnBUMEFi?= =?utf-8?B?bnpJUW1DMExVYm1nWWFYUUFYMTRBYjNqMWQrM2J2QmRaME8wLzBjRnhwWXJ6?= =?utf-8?B?MXplQ2o0dXQ2b3JrUW94WWtUSkNlZ0pSMUVnak1qTGc1QUdlWnJ0cTk0THBZ?= =?utf-8?B?TzBzK3AvMGp6aUtNcDRNOENrSmRBM1l5djZzUXB3ZjUzZWlXNUNJN2dTQ3pN?= =?utf-8?B?cXJJYnZvbE9ONEphVktNa3E5RVVEZnJpeUN1QnR6aXVGQ3ZzZDYrV3lrRTJU?= =?utf-8?B?cHpodUd6VCtHV0xHM242Vzd5WHA0K1JVQW5YWmxtbXJ3MHpIdzdUUC9TaWFC?= =?utf-8?B?TWZncENuMVo2WTNvbWlYYUw3b2gralh3TEVjS1l3dEI5R2JiWE8yODNZdS9V?= =?utf-8?B?RnN4bFNUQnJuTVAzQUtIdU9mZUhCR3BGd1doaDhjc21rTUR1a2h5S3VOakJD?= =?utf-8?B?c0NaaWNMOXFuakNsZnIvWjJhYWk1S3NrcU92bWYyUjVhWlBzMEt1NGNWcFFn?= =?utf-8?B?a2poUFZIWkJoZGZPVVJ6MTl5b0U0ZUgvMzZJNGlzNGIwWkZOZHpNM3BwTVRB?= =?utf-8?B?Tzd1SWxiR2lYeFMxN3ptRDB2YUwwT3lPMGlPcXdWS2Z0WGZ0ZzRSamJrUXlw?= =?utf-8?B?aGJ4NUJETGpVZjdLa2RpWUZnaGx2cExFZE1DMlk5WW1Ea0ZsSnhHS1VQenF3?= =?utf-8?B?a0pybU0yVEpRTENPSjAyb05VUHVZYkF2L1lnbGUyY0kwdlBGTWZ2Q21WRmtX?= =?utf-8?B?T3pha2Jmay9UNkFFV2RYUmpPSWZQTTF4eS9LdE9FQ2RmM3dZbXkwT3BidUp2?= =?utf-8?B?WjYyT1MrdXpFQUlncC9nVWRpNkwrb3FkZTlUVGduaWZseVp0TW8yUHdudkEr?= =?utf-8?B?a05qZlY5UlVmdnBISWE2WVVkL1U0TURJNlRLWWZLa0llbjhSVG9rNGRSY3JB?= =?utf-8?B?aUI3b1MveG1xeUlkUnpFVEh3T0ZEZVJCa2ZDSHZKUmpRQ3ZVTmVWYk9obm1H?= =?utf-8?B?OCtSNUxmZ0xuTDZHZ0lKSU9xWWZNNHdjL1pVTTlrdTZhY1RhVHFJZDEyaEJn?= =?utf-8?B?bUxOZ3FNNmpyZ0QzL01GOC9ZTlE1YWJZd2NFVFZDVnZqZkZTSTZRVVNnN0Z5?= =?utf-8?B?MTBJL2QzRmM5dlZZemc5SkNPR2VRbUlWOUo1M3ZxcG9vODVIL04vSVY1bjVH?= =?utf-8?B?bTRaSEFueEZIMEgvd0podWlIL2lOU014alJyRGxzZXpZRUt0ejlheUd2S1U0?= =?utf-8?B?WlNSMENyakRDMy9KdlVRTjhzNkR1RHZSWFJMcVNramEreEkvd3hwWFNvVGpW?= =?utf-8?B?Z0lQM3IyVXhWT3p4ZExZRHFuTXZ2QXpXL0VYWkRScWVXVjZ3a2Rqam1GSHlt?= =?utf-8?B?a2xvZEVQa0hNSjhsVUk2VXJkeDVBeE5DNytsQ1ZpaXkxb2ovemZBOG8vUmlr?= =?utf-8?B?NE9uMzRKNWJHMTBQY25NTTVWdzVGcEZFYU9tbWJYVWd1cWl6b2xMVFZKeWN2?= =?utf-8?B?S25pZnp3c3J3SWlkczB3dUc2TVR5QUdnK3NBeEVOYTZjZkNUNmhRdHYxWkdh?= =?utf-8?B?NTJxY0dSMnhYdkpQNnpUbUcwRUNUTVlvSjFma1B3TlNQcjcza2o0eU90aHcv?= =?utf-8?B?YTBTOU84M2dlc2pTUE93NHM4ZDliTXZYQXg2YXRXcDlLWUUxN1hiVVJXcGly?= =?utf-8?B?djZ5V0tINkNmRFpCRC9ZOFlEb2hEVmptaXo1aWduaktOdUR4YkkreEhWYjBU?= =?utf-8?B?enRCeHZueUFlL2NvenpZaDZpc1Y3alRWQ1VDMmRpTEVMN290Y2NrSjFmT05G?= =?utf-8?B?cG14SFlQU3AyR2FFYjVBTUlYZWcrZzIzME1neTBleWl0dU14VXI5N2tOUHNo?= =?utf-8?Q?VWRhZb9jCfnEPGhcpGANQjYmJ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 112d85e4-31b6-4433-edc0-08daf3e1a025 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2023 14:39:20.7784 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: d3HvLfoDTDVvw1B32Mq/g9KLiQwFyAjBihDDFMNg0KJ8HDYs2ynghS0fxJbsM6sv70y7KAkYOEBEzYyhLCqlUQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9449 On 16.12.2022 12:48, Julien Grall wrote: > @@ -597,22 +598,43 @@ static unsigned long init_node_heap(int node, unsigned long mfn, > needed = 0; > } > else if ( *use_tail && nr >= needed && > - arch_mfns_in_directmap(mfn + nr - needed, needed) && > (!xenheap_bits || > !((mfn + nr - 1) >> (xenheap_bits - PAGE_SHIFT))) ) > { > - _heap[node] = mfn_to_virt(mfn + nr - needed); > - avail[node] = mfn_to_virt(mfn + nr - 1) + > - PAGE_SIZE - sizeof(**avail) * NR_ZONES; > - } > - else if ( nr >= needed && By replacing these two well-formed lines with ... > - arch_mfns_in_directmap(mfn, needed) && > + if ( arch_mfns_in_directmap(mfn + nr - needed, needed) ) > + { > + _heap[node] = mfn_to_virt(mfn + nr - needed); > + avail[node] = mfn_to_virt(mfn + nr - 1) + > + PAGE_SIZE - sizeof(**avail) * NR_ZONES; > + } > + else > + { > + mfn_t needed_start = _mfn(mfn + nr - needed); > + > + _heap[node] = vmap_contig_pages(needed_start, needed); > + BUG_ON(!_heap[node]); > + avail[node] = (void *)(_heap[node]) + (needed << PAGE_SHIFT) - > + sizeof(**avail) * NR_ZONES; > + } > + } else if ( nr >= needed && ... this, you're not only violating style here, but you also ... > (!xenheap_bits || > !((mfn + needed - 1) >> (xenheap_bits - PAGE_SHIFT))) ) ... break indentation for these two lines. Jan From xen-devel-bounces@lists.xenproject.org Wed Jan 11 14:45:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 14:45:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475493.737231 (Exim 4.92) (envelope-from ) id 1pFcLs-000597-Ie; Wed, 11 Jan 2023 14:45:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475493.737231; Wed, 11 Jan 2023 14:45:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFcLs-000590-Ft; Wed, 11 Jan 2023 14:45:16 +0000 Received: by outflank-mailman (input) for mailman id 475493; Wed, 11 Jan 2023 14:45:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFcFc-0000FC-GM for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 14:38:48 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id a8093cec-91bd-11ed-91b6-6bf2151ebd3b; Wed, 11 Jan 2023 15:38:47 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1281615DB; Wed, 11 Jan 2023 06:39:29 -0800 (PST) Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com [10.1.195.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 064353F71A; Wed, 11 Jan 2023 06:38:45 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a8093cec-91bd-11ed-91b6-6bf2151ebd3b From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Wei Liu , Anthony PERARD , George Dunlap , Nick Rosbrook , Juergen Gross Subject: [RFC PATCH 7/8] xen/tools: add sve parameter in XL configuration Date: Wed, 11 Jan 2023 14:38:25 +0000 Message-Id: <20230111143826.3224-8-luca.fancellu@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230111143826.3224-1-luca.fancellu@arm.com> References: <20230111143826.3224-1-luca.fancellu@arm.com> Add sve parameter in XL configuration to allow guests to use SVE feature. Signed-off-by: Luca Fancellu --- docs/man/xl.cfg.5.pod.in | 11 +++++++++++ tools/golang/xenlight/helpers.gen.go | 2 ++ tools/golang/xenlight/types.gen.go | 1 + tools/include/libxl.h | 5 +++++ tools/libs/light/libxl_arm.c | 2 ++ tools/libs/light/libxl_types.idl | 1 + tools/xl/xl_parse.c | 10 ++++++++++ 7 files changed, 32 insertions(+) diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in index 024bceeb61b2..60412f7e32a0 100644 --- a/docs/man/xl.cfg.5.pod.in +++ b/docs/man/xl.cfg.5.pod.in @@ -2903,6 +2903,17 @@ Currently, only the "sbsa_uart" model is supported for ARM. =back +=item B + +To enable SVE, user must specify a number different from zero, maximum 2048 and +multiple of 128. That value will be the maximum number of SVE registers bits +that the hypervisor will impose to this guest. If the platform has a lower bits +value, then the lower value will be chosen. +A value equal to zero is the default and it means this guest is not allowed to +use SVE. + +=back + =head3 x86 =over 4 diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go index 3ac4938858f2..7f3b1e758b00 100644 --- a/tools/golang/xenlight/helpers.gen.go +++ b/tools/golang/xenlight/helpers.gen.go @@ -1117,6 +1117,7 @@ default: return fmt.Errorf("invalid union key '%v'", x.Type)} x.ArchArm.GicVersion = GicVersion(xc.arch_arm.gic_version) x.ArchArm.Vuart = VuartType(xc.arch_arm.vuart) +x.ArchArm.Sve = int(xc.arch_arm.sve) if err := x.ArchX86.MsrRelaxed.fromC(&xc.arch_x86.msr_relaxed);err != nil { return fmt.Errorf("converting field ArchX86.MsrRelaxed: %v", err) } @@ -1602,6 +1603,7 @@ default: return fmt.Errorf("invalid union key '%v'", x.Type)} xc.arch_arm.gic_version = C.libxl_gic_version(x.ArchArm.GicVersion) xc.arch_arm.vuart = C.libxl_vuart_type(x.ArchArm.Vuart) +xc.arch_arm.sve = C.int(x.Sve) if err := x.ArchX86.MsrRelaxed.toC(&xc.arch_x86.msr_relaxed); err != nil { return fmt.Errorf("converting field ArchX86.MsrRelaxed: %v", err) } diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go index 16ce879e3fb7..ed144325682e 100644 --- a/tools/golang/xenlight/types.gen.go +++ b/tools/golang/xenlight/types.gen.go @@ -537,6 +537,7 @@ TypeUnion DomainBuildInfoTypeUnion ArchArm struct { GicVersion GicVersion Vuart VuartType +Sve uint32 } ArchX86 struct { MsrRelaxed Defbool diff --git a/tools/include/libxl.h b/tools/include/libxl.h index d652895075a0..1057962e2e3f 100644 --- a/tools/include/libxl.h +++ b/tools/include/libxl.h @@ -278,6 +278,11 @@ */ #define LIBXL_HAVE_BUILDINFO_ARCH_ARM_TEE 1 +/* + * libxl_domain_build_info has the arch_arm.sve field. + */ +#define LIBXL_HAVE_BUILDINFO_ARCH_ARM_SVE 1 + /* * LIBXL_HAVE_SOFT_RESET indicates that libxl supports performing * 'soft reset' for domains and there is 'soft_reset' shutdown reason diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c index ddc7b2a15975..31f30e054bf4 100644 --- a/tools/libs/light/libxl_arm.c +++ b/tools/libs/light/libxl_arm.c @@ -211,6 +211,8 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, return ERROR_FAIL; } + config->arch.sve_vl_bits = d_config->b_info.arch_arm.sve; + return 0; } diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl index 0cfad8508dbd..27e22523c7c2 100644 --- a/tools/libs/light/libxl_types.idl +++ b/tools/libs/light/libxl_types.idl @@ -663,6 +663,7 @@ libxl_domain_build_info = Struct("domain_build_info",[ ("arch_arm", Struct(None, [("gic_version", libxl_gic_version), ("vuart", libxl_vuart_type), + ("sve", uint32), ])), ("arch_x86", Struct(None, [("msr_relaxed", libxl_defbool), ])), diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c index 853e9f357a1a..49b2f28807e5 100644 --- a/tools/xl/xl_parse.c +++ b/tools/xl/xl_parse.c @@ -2828,6 +2828,16 @@ skip_usbdev: } } + if (!xlu_cfg_get_long (config, "sve", &l, 0)) { + if (((l % 128) != 0) || (l > 2048)) { + fprintf(stderr, + "Invalid sve value: %ld. Needs to be <= 2048 and multiple" + " of 128\n", l); + exit(-ERROR_FAIL); + } + b_info->arch_arm.sve = l; + } + parse_vkb_list(config, d_config); d_config->virtios = NULL; -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Wed Jan 11 14:45:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 14:45:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475503.737243 (Exim 4.92) (envelope-from ) id 1pFcLv-0005Rh-R6; Wed, 11 Jan 2023 14:45:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475503.737243; Wed, 11 Jan 2023 14:45:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFcLv-0005Ra-Nt; Wed, 11 Jan 2023 14:45:19 +0000 Received: by outflank-mailman (input) for mailman id 475503; Wed, 11 Jan 2023 14:45:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFcFd-0000FC-FX for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 14:38:49 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id a8afd8c2-91bd-11ed-91b6-6bf2151ebd3b; Wed, 11 Jan 2023 15:38:48 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 299D6FEC; Wed, 11 Jan 2023 06:39:30 -0800 (PST) Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com [10.1.195.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3849D3F71A; Wed, 11 Jan 2023 06:38:47 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a8afd8c2-91bd-11ed-91b6-6bf2151ebd3b From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [RFC PATCH 8/8] xen/arm: add sve property for dom0less domUs Date: Wed, 11 Jan 2023 14:38:26 +0000 Message-Id: <20230111143826.3224-9-luca.fancellu@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230111143826.3224-1-luca.fancellu@arm.com> References: <20230111143826.3224-1-luca.fancellu@arm.com> Add a device tree property in the dom0less domU configuration to enable the guest to use SVE. Update documentation. Signed-off-by: Luca Fancellu --- docs/misc/arm/device-tree/booting.txt | 7 +++++++ xen/arch/arm/domain_build.c | 7 +++++++ 2 files changed, 14 insertions(+) diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt index 3879340b5e0a..3d1ce652317e 100644 --- a/docs/misc/arm/device-tree/booting.txt +++ b/docs/misc/arm/device-tree/booting.txt @@ -193,6 +193,13 @@ with the following properties: Optional. Handle to a xen,cpupool device tree node that identifies the cpupool where the guest will be started at boot. +- sve + + Optional. A number that, when above 0, enables SVE for this guest and sets + its maximum SVE vector length. The default value is 0, that means this + guest is not allowed to use SVE, the maximum value allowed is 2048, any + other value must be multiple of 128. + - xen,enhanced A string property. Possible property values are: diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 48c3fdc28063..05b2bfc9195f 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -3959,6 +3959,13 @@ void __init create_domUs(void) d_cfg.max_maptrack_frames = val; } + if ( dt_property_read_u32(node, "sve", &val) ) + { + if ( val > UINT16_MAX ) + panic("sve property value (%"PRIu32") overflow\n", val); + d_cfg.arch.sve_vl_bits = val; + } + /* * The variable max_init_domid is initialized with zero, so here it's * very important to use the pre-increment operator to call -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Wed Jan 11 14:45:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 14:45:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475504.737254 (Exim 4.92) (envelope-from ) id 1pFcLx-0005iQ-3v; Wed, 11 Jan 2023 14:45:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475504.737254; Wed, 11 Jan 2023 14:45:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFcLx-0005iF-0s; Wed, 11 Jan 2023 14:45:21 +0000 Received: by outflank-mailman (input) for mailman id 475504; Wed, 11 Jan 2023 14:45:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFcFY-0000FC-D1 for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 14:38:44 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id a5a241cf-91bd-11ed-91b6-6bf2151ebd3b; Wed, 11 Jan 2023 15:38:43 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1FD5FFEC; Wed, 11 Jan 2023 06:39:25 -0800 (PST) Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com [10.1.195.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2E32A3F71A; Wed, 11 Jan 2023 06:38:42 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a5a241cf-91bd-11ed-91b6-6bf2151ebd3b From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [RFC PATCH 4/8] xen/arm: add SVE exception class handling Date: Wed, 11 Jan 2023 14:38:22 +0000 Message-Id: <20230111143826.3224-5-luca.fancellu@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230111143826.3224-1-luca.fancellu@arm.com> References: <20230111143826.3224-1-luca.fancellu@arm.com> SVE has a new exception class with code 0x19, introduce the new code and handle the exception. Signed-off-by: Luca Fancellu --- xen/arch/arm/include/asm/processor.h | 1 + xen/arch/arm/traps.c | 12 ++++++++++++ 2 files changed, 13 insertions(+) diff --git a/xen/arch/arm/include/asm/processor.h b/xen/arch/arm/include/asm/processor.h index 0e38926b94db..625c2bd0cd6c 100644 --- a/xen/arch/arm/include/asm/processor.h +++ b/xen/arch/arm/include/asm/processor.h @@ -426,6 +426,7 @@ #define HSR_EC_HVC64 0x16 #define HSR_EC_SMC64 0x17 #define HSR_EC_SYSREG 0x18 +#define HSR_EC_SVE 0x19 #endif #define HSR_EC_INSTR_ABORT_LOWER_EL 0x20 #define HSR_EC_INSTR_ABORT_CURR_EL 0x21 diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c index 45163fd3afb0..66e07197aea5 100644 --- a/xen/arch/arm/traps.c +++ b/xen/arch/arm/traps.c @@ -2168,6 +2168,13 @@ void do_trap_guest_sync(struct cpu_user_regs *regs) perfc_incr(trap_sysreg); do_sysreg(regs, hsr); break; + case HSR_EC_SVE: + GUEST_BUG_ON(regs_mode_is_32bit(regs)); + gprintk(XENLOG_WARNING, + "Domain id %d tried to use SVE while not allowed\n", + current->domain->domain_id); + inject_undef_exception(regs, hsr); + break; #endif case HSR_EC_INSTR_ABORT_LOWER_EL: @@ -2197,6 +2204,11 @@ void do_trap_hyp_sync(struct cpu_user_regs *regs) case HSR_EC_BRK: do_trap_brk(regs, hsr); break; + case HSR_EC_SVE: + /* An SVE exception is a bug somewhere in hypervisor code */ + printk("SVE trap at EL2.\n"); + do_unexpected_trap("Hypervisor", regs); + break; #endif case HSR_EC_DATA_ABORT_CURR_EL: case HSR_EC_INSTR_ABORT_CURR_EL: -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Wed Jan 11 14:45:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 14:45:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475507.737265 (Exim 4.92) (envelope-from ) id 1pFcLz-00061K-Cx; Wed, 11 Jan 2023 14:45:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475507.737265; Wed, 11 Jan 2023 14:45:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFcLz-000617-9H; Wed, 11 Jan 2023 14:45:23 +0000 Received: by outflank-mailman (input) for mailman id 475507; Wed, 11 Jan 2023 14:45:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFcFX-0000FC-Cn for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 14:38:43 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id a51c0bc6-91bd-11ed-91b6-6bf2151ebd3b; Wed, 11 Jan 2023 15:38:42 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 09004169E; Wed, 11 Jan 2023 06:39:24 -0800 (PST) Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com [10.1.195.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 16C5F3F71A; Wed, 11 Jan 2023 06:38:40 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a51c0bc6-91bd-11ed-91b6-6bf2151ebd3b From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [RFC PATCH 3/8] xen/arm: Expose SVE feature to the guest Date: Wed, 11 Jan 2023 14:38:21 +0000 Message-Id: <20230111143826.3224-4-luca.fancellu@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230111143826.3224-1-luca.fancellu@arm.com> References: <20230111143826.3224-1-luca.fancellu@arm.com> When a guest is allowed to use SVE, expose the SVE features through the identification registers. Signed-off-by: Luca Fancellu --- xen/arch/arm/arm64/vsysreg.c | 39 ++++++++++++++++++++++++++++++++++-- 1 file changed, 37 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm/arm64/vsysreg.c b/xen/arch/arm/arm64/vsysreg.c index 758750983c11..10048bb4d221 100644 --- a/xen/arch/arm/arm64/vsysreg.c +++ b/xen/arch/arm/arm64/vsysreg.c @@ -18,6 +18,7 @@ #include +#include #include #include #include @@ -295,7 +296,28 @@ void do_sysreg(struct cpu_user_regs *regs, GENERATE_TID3_INFO(MVFR0_EL1, mvfr, 0) GENERATE_TID3_INFO(MVFR1_EL1, mvfr, 1) GENERATE_TID3_INFO(MVFR2_EL1, mvfr, 2) - GENERATE_TID3_INFO(ID_AA64PFR0_EL1, pfr64, 0) + + case HSR_SYSREG_ID_AA64PFR0_EL1: + { + register_t guest_reg_value = guest_cpuinfo.pfr64.bits[0]; + + if ( is_sve_domain(v->domain) ) + { + /* 4 is the SVE field width in id_aa64pfr0_el1 */ + uint64_t mask = GENMASK(ID_AA64PFR0_SVE_SHIFT + 4 - 1, + ID_AA64PFR0_SVE_SHIFT); + /* sysval is the sve field on the system */ + uint64_t sysval = cpuid_feature_extract_unsigned_field_width( + system_cpuinfo.pfr64.bits[0], + ID_AA64PFR0_SVE_SHIFT, 4); + guest_reg_value &= ~mask; + guest_reg_value |= (sysval << ID_AA64PFR0_SVE_SHIFT) & mask; + } + + return handle_ro_read_val(regs, regidx, hsr.sysreg.read, hsr, 1, + guest_reg_value); + } + GENERATE_TID3_INFO(ID_AA64PFR1_EL1, pfr64, 1) GENERATE_TID3_INFO(ID_AA64DFR0_EL1, dbg64, 0) GENERATE_TID3_INFO(ID_AA64DFR1_EL1, dbg64, 1) @@ -306,7 +328,20 @@ void do_sysreg(struct cpu_user_regs *regs, GENERATE_TID3_INFO(ID_AA64MMFR2_EL1, mm64, 2) GENERATE_TID3_INFO(ID_AA64AFR0_EL1, aux64, 0) GENERATE_TID3_INFO(ID_AA64AFR1_EL1, aux64, 1) - GENERATE_TID3_INFO(ID_AA64ZFR0_EL1, zfr64, 0) + + case HSR_SYSREG_ID_AA64ZFR0_EL1: + { + /* + * When the guest has the SVE feature enabled, the whole id_aa64zfr0_el1 + * needs to be exposed. + */ + register_t guest_reg_value = guest_cpuinfo.zfr64.bits[0]; + if ( is_sve_domain(v->domain) ) + guest_reg_value = system_cpuinfo.zfr64.bits[0]; + + return handle_ro_read_val(regs, regidx, hsr.sysreg.read, hsr, 1, + guest_reg_value); + } /* * Those cases are catching all Reserved registers trapped by TID3 which -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Wed Jan 11 14:45:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 14:45:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475509.737271 (Exim 4.92) (envelope-from ) id 1pFcLz-00064Q-RZ; Wed, 11 Jan 2023 14:45:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475509.737271; Wed, 11 Jan 2023 14:45:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFcLz-00063i-Ir; Wed, 11 Jan 2023 14:45:23 +0000 Received: by outflank-mailman (input) for mailman id 475509; Wed, 11 Jan 2023 14:45:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFcFb-0000FC-Er for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 14:38:47 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id a760cc4e-91bd-11ed-91b6-6bf2151ebd3b; Wed, 11 Jan 2023 15:38:46 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D45BEFEC; Wed, 11 Jan 2023 06:39:27 -0800 (PST) Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com [10.1.195.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 78DB13F71A; Wed, 11 Jan 2023 06:38:44 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a760cc4e-91bd-11ed-91b6-6bf2151ebd3b From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Volodymyr Babchuk Subject: [RFC PATCH 6/8] xen/arm: enable Dom0 to use SVE feature Date: Wed, 11 Jan 2023 14:38:24 +0000 Message-Id: <20230111143826.3224-7-luca.fancellu@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230111143826.3224-1-luca.fancellu@arm.com> References: <20230111143826.3224-1-luca.fancellu@arm.com> Add a command line parameter to allow Dom0 the use of SVE resources, the command line parameter dom0_sve controls the feature on this domain and sets the maximum SVE vector length for Dom0. Signed-off-by: Luca Fancellu --- docs/misc/xen-command-line.pandoc | 12 ++++++++++++ xen/arch/arm/arm64/sve.c | 5 +++++ xen/arch/arm/domain_build.c | 4 ++++ xen/arch/arm/include/asm/arm64/sve.h | 4 ++++ 4 files changed, 25 insertions(+) diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc index 923910f553c5..940a96f4207c 100644 --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -995,6 +995,18 @@ restrictions set up here. Note that the values to be specified here are ACPI PXM ones, not Xen internal node numbers. `relaxed` sets up vCPU affinities to prefer but be not limited to the specified node(s). +### dom0_sve (arm) +> `= ` + +> Default: `0` + +Enable arm SVE usage for Dom0 domain and sets the maximum SVE vector length. +Values above 0 means feature is enabled for Dom0, otherwise feature is disabled. +Possible values are from 0 to maximum 2048, being multiple of 128, that will be +the maximum vector length. +Please note that the specified value is a maximum allowed vector length, so if +the platform supports only a lower value, the lower one will be chosen. + ### dom0_vcpus_pin > `= ` diff --git a/xen/arch/arm/arm64/sve.c b/xen/arch/arm/arm64/sve.c index c7b325700fe4..9f8c5d21a59f 100644 --- a/xen/arch/arm/arm64/sve.c +++ b/xen/arch/arm/arm64/sve.c @@ -5,10 +5,15 @@ * Copyright (C) 2022 ARM Ltd. */ +#include #include #include #include +/* opt_dom0_sve: allow Dom0 to use SVE and set maximum vector length. */ +unsigned int __initdata opt_dom0_sve; +integer_param("dom0_sve", opt_dom0_sve); + extern unsigned int sve_get_hw_vl(void); extern void sve_save_ctx(uint64_t *sve_ctx, uint64_t *pregs, int save_ffr); extern void sve_load_ctx(uint64_t const *sve_ctx, uint64_t const *pregs, diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 829cea8de84f..48c3fdc28063 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -26,6 +26,7 @@ #include #include #include +#include #include #include #include @@ -4075,6 +4076,9 @@ void __init create_dom0(void) if ( iommu_enabled ) dom0_cfg.flags |= XEN_DOMCTL_CDF_iommu; + if ( opt_dom0_sve > 0 ) + dom0_cfg.arch.sve_vl_bits = opt_dom0_sve; + dom0 = domain_create(0, &dom0_cfg, CDF_privileged | CDF_directmap); if ( IS_ERR(dom0) || (alloc_dom0_vcpu0(dom0) == NULL) ) panic("Error creating domain 0\n"); diff --git a/xen/arch/arm/include/asm/arm64/sve.h b/xen/arch/arm/include/asm/arm64/sve.h index 28c31b329233..dc6e747cec9e 100644 --- a/xen/arch/arm/include/asm/arm64/sve.h +++ b/xen/arch/arm/include/asm/arm64/sve.h @@ -21,6 +21,8 @@ static inline bool is_vl_valid(uint16_t vl) #ifdef CONFIG_ARM64_SVE +extern unsigned int opt_dom0_sve; + register_t compute_max_zcr(void); register_t vl_to_zcr(uint16_t vl); uint16_t get_sys_vl_len(void); @@ -31,6 +33,8 @@ void sve_restore_state(struct vcpu *v); #else /* !CONFIG_ARM64_SVE */ +#define opt_dom0_sve (0) + static inline register_t compute_max_zcr(void) { return 0; -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Wed Jan 11 14:48:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 14:48:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475561.737286 (Exim 4.92) (envelope-from ) id 1pFcOW-0008KZ-AO; Wed, 11 Jan 2023 14:48:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475561.737286; Wed, 11 Jan 2023 14:48:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFcOW-0008KS-7h; Wed, 11 Jan 2023 14:48:00 +0000 Received: by outflank-mailman (input) for mailman id 475561; Wed, 11 Jan 2023 14:47:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFcOU-0008KI-Gc for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 14:47:58 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2077.outbound.protection.outlook.com [40.107.20.77]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id efd3e813-91be-11ed-91b6-6bf2151ebd3b; Wed, 11 Jan 2023 15:47:57 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9399.eurprd04.prod.outlook.com (2603:10a6:102:2b3::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Wed, 11 Jan 2023 14:47:55 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Wed, 11 Jan 2023 14:47:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: efd3e813-91be-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IIhyscHN3roRN3iTTia8efG8JLElZA92SbjJuRZgFV4tuRwH5OkNHQaBf4bFpanZB371WIWR7Dggw9inyW3j7WZyNes+d4Y3ep/glcygXsj+qBBGh0mgmtrV4IKHnyumZ+SPAMKA6ea7ep3sWGH4O+kbYfDlFlZH/tsBk5clFNCXxNx9FAIfTvrTgXcgbI9W180ckNPF1iji/MwHztcR5jz5csvL8W0TfMMR4wFG6JOftn59+jWuDCS0ikMmfBtHO1loMs5p24XB8Wua/qE7HtrmV6FkE4lY/cCRzxc7qwc/XfUZKRlVOT5T/MPtjS6lRQxX+t5EY+haCLyD41+2Jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VdoXEti/lpxrYlLx7N4cmaE1xWLxL+GISh9xXSn2meI=; b=I73yptCvK91JzqS8aiatNhqoyxnSteJ5E5CENoZC8rKHK7O2LrRBNzyZU8YDLTVGZxQ0q6vvwE0CaglScjib1zEHrdRmB4G/xR7O9n3YFH2gy5qFac9buQVNDPI+BHnWDgj2lpdos6/xw4OjANBC+4n0V1/FSC2l3jQ7dFOEClhDe3rWCRDvXXeTOG2NM/JR/60xNYAuLl9JyxgPJB3htpa7rCN3UiEsjg7WwArlNTXfhmvOu8NP+uNSNc+huiI029tVOHUDvO+lyDV7WBLBZuNZmbrpTbIJNtmxytFj8lo8/K4fB+qnIxOG5wcgfl+/1f4InvJNsOSnjXxC15KQmA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VdoXEti/lpxrYlLx7N4cmaE1xWLxL+GISh9xXSn2meI=; b=utDeqBw+nqCTNv7yrO4jUPIZ0aw34fBntngBFDEff7AkK3ou4ZwCpH2Wl4VpHLyXjc3zUJM8z7RXeMnsYeuSWtAjWQ9AQ/NIHZYTdTuhDtzwkoVFpRn5+JV+dW3qGsKbFTQUTXh5McP55ITldIv0oIcBYlIEabKhUkK2SRmyki4yEJN0nFJoMjU6zW31VFbzW5q8fa4tDOGBCMidng5SD3HD4Jai5kvfpJLqK7CGeT8OqvlS514z4V7D8OBsMTXoRLb1E0OBZKPKNJbmi/y1+0tyEBPjlq+oIbmv3efHMfVEF5j2iii8NYbuMV/gbrclmtoD0T7kJB0Qk4uuGugEzA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <41ae2fa8-27a3-72d4-ab20-100085c55ba2@suse.com> Date: Wed, 11 Jan 2023 15:47:53 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 18/22] x86/setup: do not create valid mappings when directmap=no Content-Language: en-US To: Julien Grall Cc: Hongyan Xia , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Julien Grall , xen-devel@lists.xenproject.org References: <20221216114853.8227-1-julien@xen.org> <20221216114853.8227-19-julien@xen.org> From: Jan Beulich In-Reply-To: <20221216114853.8227-19-julien@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0166.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9399:EE_ X-MS-Office365-Filtering-Correlation-Id: cacf34b4-e117-4e45-05c6-08daf3e2d2e8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: H0jN9fFSrJK66BlrtmJ8U939nj/69O0X9G3tJYbRplwhKQGRE27eD5eR3eL7oa1NFNFM7j0vLT/2ymUFQNU4IOY7mCXjdOn4sKzKka5bpXwSwWfh0tXAGAaNEnkY7WbeHkXsF0z0N2oLsXZwQSLIDiYm28Uw1nW6h/JQpKw8nj71Dp7fM8y9mNoaUoKQluSeb+KLzCCvoF0enhAnkMyoYYTLkUkEGIdI7E9PyJjDWexOp2Md65F/1Lo3NazwV8ajlKB9SiiR0pDyRSKm/5G7I/06/kRNeDgnvFtFMfNlEteeALAA5Msc939BzifsFpqur1FaOR5aJNdiDqLJ/M2ly6kNa09ZVEo4GMLm0dyLt7kuNg1yZTYB+FBAqbmfBmM54uu+v5uuoU+Aw/PmLQFAafAN+KvOl1k4MsWJ5GsNAPwD1fisb0zSErIPnoEPGZBpgt2mmmj9AQEqzrHhku109DEXK5Aj6bFQPyyhBvIUojs9Fcdc/CdYn/C7GCbT63OFZW4dZziPSNSudkqBWM+IU1rySJD1iYbkN7VwRmkwjrifanThSg/NkCJ+0UM+dcF3jK0NwH5sD1PS9dQSd9rPVYaTxzDLwkLvN69BzW/565cQ9dZGprck4VJQyXqZG840PQkYB7f0RhFUGNXZAF7ufqXjNfeTlzTYsrGYQ/HMeVbCF38Kt+IYp2O0XngC3XF+9MRd4Mfpv6VXfmvZRdPmOjwStxtcqMZfztVvd5Zh26g= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(396003)(136003)(376002)(39860400002)(366004)(451199015)(5660300002)(4744005)(8936002)(41300700001)(31686004)(2906002)(36756003)(66946007)(54906003)(8676002)(6916009)(66476007)(4326008)(316002)(66556008)(6512007)(186003)(6506007)(86362001)(478600001)(6486002)(53546011)(26005)(31696002)(2616005)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bG51Q1BmbFpGZm9qcWNIbUloQXY2U2tEa0V4ZWRQRExvY05IWjRMeGZQc1ZM?= =?utf-8?B?MFVzTHBVL3VCSmxXNUZ3ZFVUc0ZqN25Xb01rTG9rdXIwL0xSZWdpaW1tYmpR?= =?utf-8?B?elpkVFN3SlpLc1ZyMkRtOE5tWWFQejc1WHd6YlB1VStKbTR6Z1o5cC83R3B5?= =?utf-8?B?REc1cktVV3hXbllLRFI5VHNVSWc3NitGUzU1eUo0YXRCcGV0cXVxSWNwTmxo?= =?utf-8?B?WVJqZE9ETHNTMHhHMnFZOUhodlZPK3h0RVlLOWZZZGVWWERtQVMzSEFjK0xr?= =?utf-8?B?ZE9uVThQK1EyWXhId3pnbFJoRHAvSFVzcyttSTU3V2EyR2c5SDRNZWxwRy9p?= =?utf-8?B?T216UXFGQlpzaG16MEJhQ2luY3NZeUxYWTN2N3lDY2hEODk2cDdxMlpTZVR6?= =?utf-8?B?R0F3aitFZXp2TWVtVVdhUkJ2d3BzWXk4bnB4K3U3V1B2NmJOQlhJekVncXh2?= =?utf-8?B?SWhpREdZS1JGVlZ6M3k0c0hIdHhjakFGWGE4a1MvWjRscmlpODZvR3p2bzJp?= =?utf-8?B?REpFaGxTUzNyc3pESlN0TnZVQ3BIQTUrR2RwdHp5djZSZTdKdE1wd1UxZHVH?= =?utf-8?B?ZHNEZmhXdVNQOHdsd3VTVHBjNFUrVng4c0FSWXhNc1NCSVVvRysrVTV0WXV5?= =?utf-8?B?Ungwb3FUYU5kOEc5Ylc1ajhEM0tFUFNIdVRNazB3RXVmajdPdmZmZ3JUSUd6?= =?utf-8?B?RFZVbEs5ZW50SFZsVFVyZG9EL2w3UEQxalNoSXIwYVRZeGlEeUZBUW5HN1lv?= =?utf-8?B?U05SU29WNGRVSklyalR6UVdESzUzNVFZUzMzK3NxMUo4VENoTnJLUHJHUG16?= =?utf-8?B?MHpaRDlEdUpoZDhieE5tYnpubkJQQ1VQblF4WE14dW1FUVROSlBxK1ZTUVkx?= =?utf-8?B?d0FNQ3VPcTdqczVJVlZBQlk3NjNMYjBETmdqK2JJZGdVRnpBbFZjQldtcER6?= =?utf-8?B?YnNOMWRNWENDTTF0WWk3aVJ1SEFLdmhGTVRuZUE4blpXcnFvTnc4eEdwa2Qw?= =?utf-8?B?MGU2QVpLNE4vVXdENnpLVnBqaVdhenBhMkp6R3pNTFlQaUxWdVF4VVdDdXBV?= =?utf-8?B?S25oWk56aEZLSHg2QnNsVzBxMkVmK0VDUGhna2kvczh4TXZCTFBkU01lekhw?= =?utf-8?B?L2hqdzlmc095eE9qL0luZFRxZTBGQmJnMjdnRXl6TG5kRWc3TGpocGFEN0dv?= =?utf-8?B?Mms5TGZhRFJralI4NHlOZE4vRDNPLzFvb3dRMmtCWVVxK2hUR1JISVVzd3ND?= =?utf-8?B?bnJBaTRrNmVaVUplUmEwVDBtOG43ZjNCb0Z4eEhmVUZ2MWtlcm5vdEVWVnlF?= =?utf-8?B?ZzhXYW1CbDV6d2lSME52aElQSThJcVlVQkcxZ2Y3MUVYcS9GdzB4ekJaNVJh?= =?utf-8?B?c1hXTStjSlJqUWQzeVNuYTQ1MExGekVUSDNZSXlKZnQzclJ1QTQvWkVQUFAz?= =?utf-8?B?SHVUYWxCOStVTGp0VFN2N1Jsa3BBaVQ1aTYyL2o2R2dLMzM5MDFJU2kzazhV?= =?utf-8?B?UVFTa1JHQUkxV3g4K1dibUcrb2xzbDUzcWtDbmJ4N05DZEcwUElCSWxXZ05K?= =?utf-8?B?QS8wOWtvcnF0WmxyWkI2eG5SVjZCUE0vWVk4UmZDUU9WVHRwVGlNSG5KbEc4?= =?utf-8?B?TVh1SjJBRDJzenlvY1gwckJwQSttYWVGMDRiSlFKZi9kL1BzU2FKcnBWTTlD?= =?utf-8?B?S2dGWW1OVk9vWXFoanRZL2NsK0R2QUd5SWlHZlhyME9MKzRBdStEaVJ4NGxI?= =?utf-8?B?ckpuczZ0T0RHU2pRYWlUay9uV0Q2RjdVTklTR0NsS0tTRjh5OHhmV1RLekpL?= =?utf-8?B?cUI5MWpoL1R0bGZpZEZjRTZyM2paY1ArWVN4bFJtcUFIWkdqZld0SllHUWhY?= =?utf-8?B?MytYUjBTdm9FeDhlQjVhVzZBMjB6eEhNYkFjMUtpbExVTmNVSTFrTUNheURv?= =?utf-8?B?cGRYajZGZnJPTGQ2U1ZFLzNuaUFCT21kRzllMlk2VUpIY1NDL0lEWlBGZzdj?= =?utf-8?B?Q2QxemxxZ0Rha2h3aVpQSUZ1YzJ0NVgxVGplOVBTNlZKSE1VM1VsN0h0REsz?= =?utf-8?B?UmFSY1ZsV2dyYk9Qd0UyelEvejNuZDhvdTBmU2NNMzJjQWY5RWtVdlc4RDZD?= =?utf-8?Q?/0X7UTkIDzdV+NP9N5DFKg+j5?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: cacf34b4-e117-4e45-05c6-08daf3e2d2e8 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2023 14:47:55.4957 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: t+fKBe4ntvDO5V5ktY10qiZMy+PwQZmS6lpgIUmv7uudTm9J0fO2S/bSOJJ607m9v34U8ijRTD7Mj8Pz8SanYA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9399 On 16.12.2022 12:48, Julien Grall wrote: > From: Hongyan Xia > > Create empty mappings in the second e820 pass. Also, destroy existing > direct map mappings created in the first pass. Could you remind me (perhaps say a word here) why these need creating then in the first place? Jan From xen-devel-bounces@lists.xenproject.org Wed Jan 11 14:50:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 14:50:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475567.737298 (Exim 4.92) (envelope-from ) id 1pFcQk-0001KY-Oc; Wed, 11 Jan 2023 14:50:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475567.737298; Wed, 11 Jan 2023 14:50:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFcQk-0001KR-KX; Wed, 11 Jan 2023 14:50:18 +0000 Received: by outflank-mailman (input) for mailman id 475567; Wed, 11 Jan 2023 14:50:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFcQi-0001KL-VA for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 14:50:17 +0000 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [2a00:1450:4864:20::633]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4286b155-91bf-11ed-91b6-6bf2151ebd3b; Wed, 11 Jan 2023 15:50:16 +0100 (CET) Received: by mail-ej1-x633.google.com with SMTP id fy8so37314109ejc.13 for ; Wed, 11 Jan 2023 06:50:16 -0800 (PST) Received: from [192.168.1.93] (adsl-139.109.242.137.tellas.gr. [109.242.137.139]) by smtp.gmail.com with ESMTPSA id kv18-20020a17090778d200b007c4f8bc322asm6254322ejc.196.2023.01.11.06.50.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Jan 2023 06:50:15 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4286b155-91bf-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=voa25sTfLc4t7NqxP8u43Bb1H3o1VCobc5wW+DSwPKg=; b=QHUaVQGEpZ20r2htUX1Vhc3KYWX3qiUGOoeOjVkPz0yHXRDCz6kq4P2kR4GzXRO99l QdMpumEQWn7KbnSX52Ynch4DnbXM4SdVJu3hgRtm9C038BC/9m/p+mJuWpOlkv5T0Lq9 ZJPOG0kz8dkv+6Pva8A6hqfRPqYQigZDjEZ3Jepwwu2OLVLlRbPPC6doIBxvTX91ZzDO Vc0Fs7vVqrofhRyDGZyF3kIese++TA9EQEh+d/lv/7XJNMWvuVshqiMHgfa4nMm/49Q7 i6vq8Di/JZx+Atb70B1H1EyG1ndINNh88uVUC5S+ijECILYA1HM2aoMhvCyaQBI1jJOG kwMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=voa25sTfLc4t7NqxP8u43Bb1H3o1VCobc5wW+DSwPKg=; b=5NYVk0IdjBdR3FdlhRkGyezV/jz5/MKRyjoO3h0aBFKK/mLpKrPDYMuA9mPqFyPhIw FT/aKHj+our0Nh9C8O5On3fISu+ZCF32Zjf723/D1SEFGSA5XN5Hya1mTCFxVJCPorWC +ZpFICVpZoq2lqKrSpOA8RnsyZy85e36eR4oH8K1g+Kv4HYbd7+QCFTNQWo2iAnOjwYt 8G6iXVhwzAdi7HoQFnuJ6cbcM5aoiBT/c7m+RNJtsl8MYHI4MBR7IvZmH5R6sN11CMXF mxuFq5M3Zs4n6HgwUsRb8+phlycSlE+r9v/s2CPVCNK5eSfnGD5BicSmkRe8eSz+jDfT Sx2g== X-Gm-Message-State: AFqh2kr6wG+yzUzQyrcY5Le+cJrqUULsTNbu+SowO9c3u1vr4Z1Nt74h LLwac6yUuY2XKq2tq7H4e0w= X-Google-Smtp-Source: AMrXdXuaexZXnckrt7QwAjlOlFbXAEYnc/a0t4Ny0Or7nmcdQ64+510P8/9hwmgBzgEOjTf/1Dlyjg== X-Received: by 2002:a17:907:8dcc:b0:84d:21b2:735a with SMTP id tg12-20020a1709078dcc00b0084d21b2735amr17286857ejc.54.1673448615496; Wed, 11 Jan 2023 06:50:15 -0800 (PST) Message-ID: <0b7489e6-3d7b-ddc3-fe8f-8dbea629bedd@gmail.com> Date: Wed, 11 Jan 2023 16:50:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v3 2/6] xen/riscv: introduce asm/types.h header file Content-Language: en-US To: Jan Beulich Cc: Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org, Oleksii References: <06185fcfb8cbd849df4b033efa923b55c054738d.camel@gmail.com> <1b6ee20d-2f32-ab38-83ec-69c33baf42fd@suse.com> <0398c48c-cc5d-a4fb-354f-54e3c5900d18@gmail.com> <644334f1-8e1d-3203-e942-0eb3ef5584a9@suse.com> <2acf07aa-ec56-99fc-765e-70fb7e753547@gmail.com> <72930382-b216-4ec3-6d29-889a3bf0bc6e@suse.com> From: Xenia Ragiadakou In-Reply-To: <72930382-b216-4ec3-6d29-889a3bf0bc6e@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/11/23 15:17, Jan Beulich wrote: > On 11.01.2023 13:30, Xenia Ragiadakou wrote: >> Could you please help me understand also >> why __signed__ keyword is required when declaring __{u,s}? >> I mean why __{u,s} cannot be declared using the signed type >> specifier, just like {u,s}? > > I'm afraid I can't, as this looks to have been (blindly?) imported > from Linux very, very long ago. Having put time in going through > our own history, I'm afraid I don't want to go further and see > whether I could spot the reason for you by going through Linux'es. Sorry, I was not aiming to drag you (or anyone) into spotting why Linux uses __signed__ when declaring __s. AfAIU these types are exported and used in userspace and maybe the reason is to support building with pre-standard C compilers. I am just wondering why Xen, that is compiled with std=c99, uses __signed__. If there is no reason, I think this difference between the declarations of __{u,s} and {u,s} is misleading and confusing (to me at least). -- Xenia From xen-devel-bounces@lists.xenproject.org Wed Jan 11 14:57:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 14:57:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475579.737309 (Exim 4.92) (envelope-from ) id 1pFcXA-00020L-EN; Wed, 11 Jan 2023 14:56:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475579.737309; Wed, 11 Jan 2023 14:56:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFcXA-00020E-AG; Wed, 11 Jan 2023 14:56:56 +0000 Received: by outflank-mailman (input) for mailman id 475579; Wed, 11 Jan 2023 14:56:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFcX8-000208-He for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 14:56:54 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2059.outbound.protection.outlook.com [40.107.21.59]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2e9f0f66-91c0-11ed-b8d0-410ff93cb8f0; Wed, 11 Jan 2023 15:56:52 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBAPR04MB7287.eurprd04.prod.outlook.com (2603:10a6:10:1a4::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.13; Wed, 11 Jan 2023 14:56:51 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Wed, 11 Jan 2023 14:56:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2e9f0f66-91c0-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SwImrKxBV4L4GUQEHnRMZF9ZiCosZxqBh6Nna+h/Vk4Q3k4JkK1ZVx163IP3U8KyL8NW13+VrR0Ja5sWo5KMM6USFDTvMvY+tao2YHlf6cPUAt5v2u0GOKHjRt5kHnNLPCix7d6LICA2lRT2AI3QavD6e8/BgzZwD1fvQ5ZaYfJQ0YX1qAJejlzw+YR4fwucwjIRlJmUl21ksL8r8UFrO/GVp50mUOSJ/T3GfdG2NuMKYbvL1hl+VMiZ3Me0b8Xa6s3R6DS/xSoHphg8/GxwMNgnK0hQBGqiHvuGjT3xrrYX9lDjiHHi8YwXZ8kQuRd+XYQ11VCAL3c3nMGnP0bb+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b1Veq8igell7UWHBBB9V20mEnZ/tb+NsSpwXNKHkiXY=; b=k7yrtwndHUoR4FLy6bwnSuLtFH6SI/lY3xY+Xkym0+UZ6aZyazL00i57ESrU0QfoOJME9YvJqyqeoYU2Ax6+fwF5fnmxaej+Wb4ECHP0qhYpJP/LobHklwZR6eYd2htLUV1j9YYw40GIzxiGAUCu/3tjC0cclvMgnSdo6JKuLGzlzsneP851JulRRHAYQExA22EOQfK6BPE36wH7sWxO6MjkUvwQYqZBaB9rpolzyXAj70TtJIip84xpbMJiHT1sqD1T1y098HHxetZRT6peAyWMn5H2vY1xUEufOqtjuv56LjkVRvwd4EvKIWzPksX5VbJtOdDB+6GBX+R3/GTXpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b1Veq8igell7UWHBBB9V20mEnZ/tb+NsSpwXNKHkiXY=; b=g+z/g7T8aQV8Q8dXwlhOzeikYXtNAH0a7EgtcQ8vUNxkDTspmRaaszNw6Pc1RCQk7uiQxuYzsqiakEERKag5Pac6uImrUExBZq6rzp5ny1caN7YORCijw3sly5qnPwSPLdAdjIWDxiicTIiqqznCEs1CG9/6QB/WZld/7wD/t245KRHNZhPvPuNv0SgbL0wv0mxmUnJLFkKz6P1cNmSFBPmw2Bunf7HZM8MAygGIVyf0M3WCACyqJtziO2JMRoi4SiC9f9U9NhrcJWbIb/R6LT6e/R5Dtu78kE4TTzZk0iBfy/RxB5sLrlw9iOwk2MLEaA6q5n1A9v4+KhbMjyH+qA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <24b26a73-1e45-d556-c286-1e9d56bd4c29@suse.com> Date: Wed, 11 Jan 2023 15:56:49 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 1/8] x86/iommu: introduce AMD-Vi and Intel VT-d Kconfig options Content-Language: en-US To: Xenia Ragiadakou Cc: Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20230104084502.61734-1-burzalodowa@gmail.com> <20230104084502.61734-2-burzalodowa@gmail.com> From: Jan Beulich In-Reply-To: <20230104084502.61734-2-burzalodowa@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0172.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9f::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBAPR04MB7287:EE_ X-MS-Office365-Filtering-Correlation-Id: dc913a10-735f-404f-ff42-08daf3e41213 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mWzt0hUqnnnG+vQi21fVAV8WOY1LJte2JounzOTuZTQR2CRoyYCWZM7pRgGAuepgzW6bm0JynyWp1N+U1A+vmuyr0tjTh7j0RIix+A6aL/cdWrosJB8Urqj4VfCM/5gvGdDf3ID7AqPvq0Fg1R7mbzh0NbL2uF7LmO7sERh6AMP6LWInEmLOIvQnqCGGF/zW8ljLejiPQFiOGZ1J5kguJYf6I6tjRezPM3sfNrMha9eEHagZ/yh6hzcewLL6SN6dR4voGxJUt+6rUBbyiXDhNEv1tXf4UQAIIZIcCIEX5WoE+lBoCMGCEFM67kfrRTXhrnVRKqMli4HU1BJ3FV9eXObdZyOXPeKJoDXQLp96A4qZU5lTh9cO9gZSFkZgb52N0thI7qBHB1YRrv6+4l3ZEfBy8GowRv+raOvXVAQ3iuBeFtA985D1SQwUXwABNANFlEifx2C8Hsu+MPhzlCVnUWnzO2cuoG+i53aRjANA/7dWTBHBhhw94h9kEpYdNeF2BKF2Pg941Dye7CrUz0y75IptnbHAxI223XOZfqQhJyiFwPgukOP4MUiurP9dmGceK1zwqPzlmKkM3HOIm/PhC6D4TCr2IOlLycBu3l57RK0g9py0H58JE7EbXZFeQiPwIq0ZPDJp11SArOLh9oCrXqXe0cvtHRdufolqNfEIsNenG5WlP2AknU0zRnT8qbbpN+Z1M47QyImAI/nQA6qTs4Bzh3raMo9UnluRCTcGFPM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(39860400002)(396003)(136003)(366004)(346002)(451199015)(66556008)(8676002)(66476007)(38100700002)(66946007)(6916009)(4326008)(86362001)(6512007)(31696002)(26005)(186003)(2616005)(316002)(478600001)(6486002)(54906003)(36756003)(31686004)(5660300002)(2906002)(41300700001)(8936002)(6506007)(4744005)(53546011)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MCtyRWdPMXBxQTlUN0VzMUdaeVZ4SnpJRFpFYjNOdFBoeEZXTGNKQlk0WDMw?= =?utf-8?B?c1paUWE0TFNxM0lYTERYUm0vSW1tL25xRUpNUnIydU1qUzR0ZGtWaitKZmdB?= =?utf-8?B?VmllbkxpaXJrTHRDS2RBazFKUWtER2lJMU1KOTBUWDNkM01KcGZESmRKTWhR?= =?utf-8?B?TXFJcW56cTZmRkpJV3pETEtuZlFpRUg1d1FWNklYUGlHSTBqVGgyYVlYR2xS?= =?utf-8?B?dm1CVnloYk9BZStpWGx1K01yR3ZvRDBjWUFkNUxncC9jZ0F3djdOT0pYTHF4?= =?utf-8?B?SFhGZnFBNVM1c3k5L3R2czM2aktENk1FMU5hRUpvYmlNdDhaWHhyOC9ZOVBi?= =?utf-8?B?RWpCYTZBVE9tOFJqS0N5OFlOK3NhMHdvQzlRNFc0SWhYV0dpVUNUWm5DT3ZQ?= =?utf-8?B?akpJeUdSN2hPUysyVHpNNUF6bVFCVWtrSU5GL2tTZ2EyVXlwNTI4eGt6b2Rh?= =?utf-8?B?anMvVXI0ZWkxZ29taTJJK2g3dmZwNUthVVRlckZYU3JxK2I1akZVZExycW50?= =?utf-8?B?eWVCNUxzUm9XTlhnd1NhWmx3NXlDdktZR255dURJZGFBL3Z4RDh4SVRkN2Jv?= =?utf-8?B?SzVESGVJOTF1S1ZobzRacFh4NDkvSUNIN29VekNENk5xV0ovTURLRjQvckp4?= =?utf-8?B?eHkxNGNEbno5TTNGclhNRTdNc2pIcE9hcWVUUDYrSTZMMmw4akxodkxUY2hG?= =?utf-8?B?OW9Zc3Nna3VIR2o2Tkt3K0FLbnkwM1pjR1pNTlhNTDJuZ0NWWWNsMk40NjhO?= =?utf-8?B?NnVwWTY3UlAyNTl4eC96a0pxcmpELytWeXdUbHZwMkNUeFVIMHkybmdkem9K?= =?utf-8?B?WDlnU1VyNmZDQ2NkUzlqMGppcDJOOHZBMUtnN3dmSXBiZXJvMmlBMmN1VEZa?= =?utf-8?B?UmhmS2UrMGlDb1VBRlQ4RzNlbDJVbytEb0o4VWFaUHk1dTlVcGJOd214WUtL?= =?utf-8?B?cWIvSjg4NURGaGRadEZSd2dVNlBTYm41a1hQWmZrVTRkUGgxdkgzOExyMUNS?= =?utf-8?B?TWxOYlhoSmlaZFc0UVJySWVMMzlzbjVRZ285RElIbUVWdHVDR2tzaDZHSzBE?= =?utf-8?B?YXIybGlTUkRVSmZiNDhPOGRqWVZEZ25QVVFpbnlXTkJ3VVZPcVJxMjYvbFB6?= =?utf-8?B?MXJuSVMrdzVnUEdwOHBZQWdxTFF0YlBEVmQreVh1d3NRZVlUUm5tNTIzODFw?= =?utf-8?B?d1cyNFFvYWpURUl1Tkw5VUJWell1SUpGU2JXeDVHVldWRmdyZ2llbzg5eGwr?= =?utf-8?B?NDh0bUVoblZKNmNyWkdyQ011RXZNM2U3eHpBc2RRclJsZHB5alk5UVI1bUh0?= =?utf-8?B?V05YZnp2aE5qM0pjejlKVnhtU01tM1QvUUtkbkNZUER2MytrNWNWNWgxZlJE?= =?utf-8?B?L3pyMGIyeDBrOXR4U1k1OXlwcm4wWU5NSlNwTnRVQTNsRXh3Z1dKbVBjQWdI?= =?utf-8?B?VHVaZ09Ic2poMVJjYTd5dnozeGlSVTVZZkJzQSt5cUgyZUl3cWlMbWhXSHA4?= =?utf-8?B?VWlhOEpRM293bXo0OGIzR2tBZUlLcTRHRTlVWmVUanRGaERhVzFzclNOMTZk?= =?utf-8?B?N0VuU3hFV1BUR3BXY0FYaCtWaDdiTk03cXNPL0lYMnZhZjlNQzFoak1QTUQ2?= =?utf-8?B?VGEvK1hibUVmMkdTK2FFdEhIUUlWVlRTeHphcmg3Y3A3YTA2ZjFURjFzNzFR?= =?utf-8?B?aVJyaWxuaERhLzRycjlCL25wOGhEaytuQTNnaVhvL0FTWThVY1lTRms0c3hL?= =?utf-8?B?UXRUejFNcVFYTHBGemY1MTBRWUJieXFXTVBRWTRXRVBIb2MveVdUNkEydGk2?= =?utf-8?B?dUNLOVRSMUtsVGtiSTJIaHRsa2doRVRZODVZOHJ1a0VJbkRaTW9UZUNDdkNo?= =?utf-8?B?OE9paUZNc0xFQzd6MDBaR0d2L0pHZXlDMVZ3cm5mL2NmaHRkK3FFaEgwUjdW?= =?utf-8?B?YUlVb3A0OGR0QjFUaFcwYjRzV2FYNkFmSXNZSGpVYlhjT29UUnhRVkpzU3Bp?= =?utf-8?B?WnJpR3RhU09SaU1LUVlYZW1VTnV1N1dSTjZ2K1lPUlNmTVNlNFR1Z01iWEp4?= =?utf-8?B?QXZNUzVuTkZ5cXlXM2REcGhvRDJNNUxhMWZDRktWM1VpS1ZpaTdFVHZhU21j?= =?utf-8?Q?pKPzbrXHBQ0XefeA3gGItJQqK?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: dc913a10-735f-404f-ff42-08daf3e41213 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2023 14:56:50.9302 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: d4ay7bEiKAmBp4Wu0x0Z0G+swd4Rf4UU0DIiZrKV/YE4RjevnDkYCQSx9IZD5gn0517lTaTHEW94m9teK8CXYg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7287 On 04.01.2023 09:44, Xenia Ragiadakou wrote: > Introduce two new Kconfig options, AMD_IOMMU and INTEL_IOMMU, to allow code > specific to each IOMMU technology to be separated and, when not required, > stripped. AMD_IOMMU will be used to enable IOMMU support for platforms that > implement the AMD I/O Virtualization Technology. INTEL_IOMMU will be used to > enable IOMMU support for platforms that implement the Intel Virtualization > Technology for Directed I/O. > > Since, at this point, disabling any of them would cause Xen to not compile, > the options are not visible to the user and are enabled by default if X86. > > Signed-off-by: Xenia Ragiadakou Reviewed-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Wed Jan 11 15:03:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 15:03:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475586.737320 (Exim 4.92) (envelope-from ) id 1pFcde-0003XP-70; Wed, 11 Jan 2023 15:03:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475586.737320; Wed, 11 Jan 2023 15:03:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFcde-0003XI-4A; Wed, 11 Jan 2023 15:03:38 +0000 Received: by outflank-mailman (input) for mailman id 475586; Wed, 11 Jan 2023 15:03:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFcdc-0003X9-Pb for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 15:03:36 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2073.outbound.protection.outlook.com [40.107.241.73]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1e721a8e-91c1-11ed-b8d0-410ff93cb8f0; Wed, 11 Jan 2023 16:03:34 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB9295.eurprd04.prod.outlook.com (2603:10a6:102:2a6::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Wed, 11 Jan 2023 15:03:33 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Wed, 11 Jan 2023 15:03:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1e721a8e-91c1-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kH9vcWJ9kkOGpKMUpOq6ex7oKL1dSmJZ1RnC+nAoXuildWt1487dzMy+sqfFyD4nny+jKv1zNhB0iMpSgUVfsq2/sx/G/9WeQMKKORUx336pZMkt38mUuJnQZ9IUV0eFeG6UjIK2/PV3AgQn24yw25RryagKppoHs6sW5EyY23l71d9TR8FbAPP8ii7ftBquSPZBxs+6gM+yPa1SZY5czD7AO+svguPuTJrkQfKbyF0zCF2Oe9rj46JrqOeo+xcbuUOjemDAyO2MQ0KBoraW6TYB3g+5Znctz0K9+tWn43sN+CxOoUSgcbua4Ad5BnWc7ZnT/B8BV+w6fjAQqlvNRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UeZYyUPop4VvJLAt7/aINgFGYQAOIKFvFeiRXTQo8g4=; b=mVZmY8xqziqujV6fPO7T5BbDrC6WcQ+m/P5qkM7gFvhZBsLbGSNiT+dzYkNPJRNkUpja7G2oxlXQEcYO1lY19BYdFF8KYOrAR81QaNO+Lkm3+cSHkGGWKS3GkEiYPf1NOmYvDK1QgsLtLRUNDegB33ClpDEW36E236AYcefkGJd7D0cCVjVd7IC1aLF3pMXe6JYXV37KX48IQ4LSZVa+DaxyWyoNNQ0YdWddIFWRnXpDLiBbMXfVOXvpyhLEOz9CoQRlsDllMT5lbIXsvfb/zHSefNuXbfKSS1ERMEE84bvvWhRuZS08s4d1cve+fodlcnRxz9DTIdEon7AZ0jiK7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UeZYyUPop4VvJLAt7/aINgFGYQAOIKFvFeiRXTQo8g4=; b=uVMM8t2IZQ5pXBlNHoLZ4sQzx1++LxLey1bee7xzRycW/xA/pOQlz+S4ocXjvo2ZT2XbVW+JadfVMiwX+xfKpUHlO8c0trWX/wGNnUE28QfLoaXSdFfPI6voYHPV2gyYXvtAhx5xz6xOwEItj1C8UHMm57bPueUeniBBkPGZZ8tGecO57DZKW4V7W8l93QI0jQBN4aoOoRKOqPf5g6u9elq+Z4OJKLwSUyLC56Wh4U/U0brvWaxLEc76VoKQ4gcrAWZq714vhdilu4BgQfLrJs+ahV13FqeBM+x+/pQUa6iuSGJcwD0QZiGl69x8pIEab3+rvavOBfttaS41M3sJ9A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 11 Jan 2023 16:03:30 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 2/8] x86/iommu: amd_iommu_perdev_intremap is AMD-Vi specific Content-Language: en-US To: Xenia Ragiadakou Cc: Andrew Cooper , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20230104084502.61734-1-burzalodowa@gmail.com> <20230104084502.61734-3-burzalodowa@gmail.com> From: Jan Beulich In-Reply-To: <20230104084502.61734-3-burzalodowa@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0129.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB9295:EE_ X-MS-Office365-Filtering-Correlation-Id: ed9ca9cf-77bc-4793-e58d-08daf3e501a2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ur4+6uijsqCtYZikcIsczVycL0g9jZyhA4AIYOKlxFbNWQNPIYHTQnYUMFY3sTcQWPkYNJsSUnH62hd5GGvWAJFcDwbzoRyWoSya4MINhmLIt9FBIWLB7UCKyTQQ80aiC7bWaGmukyIT4puBpw0jPEspt7ke4sV/TZKgcsZTwveb6vh6tSLGkzvOCjaNg5Gbdzu/UkbGYc1HpqsNEU80f/Dw36kYPOGVwtBHtxhIqUhBP410N0Yu6lkzrZH2AdvsH7FtD7dxFUBZSPB4jbrCJhMivV8hoc5BIaE5M48iZXwBWVvXsPQScJJEhpomu/Q3Ti9LwvbfRsNO/TUW0MfsX/QUidoc1LDCZWPRQ+JC+T1tkLdu5e5gudqIwq7iaRTXLwAnAt0YVBM7eyfiyA8JJZ674W11fxu59d+bit4/8l5FtB/OlNiN4xwMXJkGROJw8wqIhYgW68jMZyY3IVbHo3eWob4GLUz4+yY661oxhKDPbcIGYg9CubMYQxb2vUbRxw5Bjx/BEurUdQXaIoai7BpzwOgcK/IY40y5jFh+Da/IEe67bI2S9PmJ487F7Uzkz7mBXE+n4WyDplnYa23DOr1SZczHlOevVV0myXcWCRoQj/dKaEU8NpoT3f+x5S4mqjHnr08Sqo2RrJBV9ELUpCAg90U8ks37MqizhSHYLX1CcLDj82/L+Dw6MrV8HPY2Bic3Htaam1yDOF3MDzRacbAFHEqjjZV2MfX/MIyuClU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(346002)(39860400002)(396003)(366004)(136003)(451199015)(36756003)(31686004)(86362001)(4326008)(66556008)(41300700001)(31696002)(54906003)(8676002)(66946007)(66476007)(38100700002)(6916009)(53546011)(6486002)(186003)(26005)(6506007)(2906002)(8936002)(5660300002)(4744005)(316002)(478600001)(2616005)(6512007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WWJZdmhQQnZIeHNhMXJIMWtBMFZvOTZjM254SmdEb0dUenhRUHJoSGxpRTZj?= =?utf-8?B?R3VDeWF0N2RRNDdWN1pOWkJ3VFUxYmMzbDBseWdtMnAwSVRValVkcDNRZjRS?= =?utf-8?B?SVpmU1c5T1NCbUZjWjUvRjlDSDFhbCtzMGsvb1JPeU8zMXpTYjVFaW44cC9y?= =?utf-8?B?VHRFa1pjdkE5NkM3RTJNbEp5bXdIblJTRWV2ckdvb2w5a091eFpNd2JJUGRx?= =?utf-8?B?bThMU0dQL09WNHZqbktUbzJJVDd2eWdRVmc0Tk1yT0VDS2U1ZE5scnNpcVR5?= =?utf-8?B?Tk9MdUpMbUc4SytOdHRvUDdVVXR2eTljcWc4YlpLU2I5RnhXWDh1eFpyRUZx?= =?utf-8?B?alN2UXk1Wmc4bjZkTEthY0o1NXY4THdiTUo1ZW5tWjlxK3B0alJ2bnEwMXdT?= =?utf-8?B?SUxjSlFGRFhhejlkbXhubWIrWk0remwxREFabVhRdTEyTCtmamhMaW5aZlNZ?= =?utf-8?B?UUs0a2pVck9MV0xQWCtLaE0yT1ZJK3pkTkF5Z3Uxa0Rzczh3MWtQbFdKVWdp?= =?utf-8?B?QWZWOGFhY1B2T1IvRW1tV1JMQmRpZWFoNGU0Q0d4SW5KdXFtelhsSnpXU2lu?= =?utf-8?B?Y3pjMWQ4WFZVZmMxVUpUTzNVdUdST2ROc2pjQTlkaVpNaFI5cEdXR2lObWRO?= =?utf-8?B?VkFOczF3NWxRb3RPZ1R5Y2N4TXdiRFVmNUc2TERWYW9wUHM3TjVuQ2toRjVQ?= =?utf-8?B?K0EzSnpxTUhJMUhLR2RwSE5XMnIzdHU0OHV3dFNwa2Z2SUttUVlUd2NUb2Qy?= =?utf-8?B?bVFVa3B1amw3ZVE0SlhMdC9idExSdGIweXJRbFN0YW5aeHBVQmRjckNpSGxK?= =?utf-8?B?cWo3c0gvcHlTT01BTTIxWDQ3WXJYYU5USjlZVjZGSjYzN3NMUFc3aEJFNFNh?= =?utf-8?B?TnZSOTBiaW94eWgzOW5LSFJRU3k0T3hXN25ka0JtYkNpaVdhL3lIamtJZUFZ?= =?utf-8?B?MC9PeHVCK1ZjcjNUQWtnNHlRTnhqM1puZ3l6c09EbzhrTjBSTXBqa3pQUWNr?= =?utf-8?B?bFpIL3BBZmxvanJpaS9Qcm16c0xieHZRRUpITE5PdFNwc3dIcTZyS3ZGaDJN?= =?utf-8?B?SXY2OTRWVDcrTTlyUkg3WmtGc0R4OGorMWNvZWhtL3Y1cWQ2VEhVQVF2bHN1?= =?utf-8?B?RTVScSs0VjRMZ2ZCODZ5OExYK0dXZDJjZlRuTXp4YVRyRm5JNDc3c3FYcGw1?= =?utf-8?B?QUUzYS9hSUtxSnNpK051YmxHVE84TG5IREZBRm5Mc2hBZEN3ZXRFa1hKdVJJ?= =?utf-8?B?dysxSktNOEFvNEJQVWR5bkM3alFFOXVwVjJZT0ROTGpUMWNuQUFHZGZjS3dH?= =?utf-8?B?bGFLZFZiWkJCNHZqdlVCL1dJSkY5ci80L3RTZ3dwZEYrZS9XUkQ0OFR3Yzlv?= =?utf-8?B?RHorOFZUbUFKOTBnTElsNFdVYVpab2k2UklOQVZKbVdkN3E2VGM5OFgvb21m?= =?utf-8?B?dHMza3JMOHE0dTdkbUQ4ajNFWm1ZZzFRWmJoUUtieW8rME4vMjJIeDEraEha?= =?utf-8?B?RGk0UkhnNXhEbSt6N3pnZ3hPdWJDS0lONTFkZ1NTRmk2d3BFc1JGeVhpYUF3?= =?utf-8?B?aGlMbFhic2Q5WjBvZkxWWUIrY3JqNXh1MjN1RExIM3RJVEpqdGNackhIYWdr?= =?utf-8?B?OEJERnZ1aGVZelVoK2k4SUlPYnNUUGg5TEVtbGdHbDRMRkY0bCt6ZzE5ajkz?= =?utf-8?B?QnJGTEowRFVHejE4clpsTWFERk9LWEQzangvcjNHcDVqN3dyM1JaNkRGYktM?= =?utf-8?B?WUNtajVBQU1tMHU3QVdyN2Q0K3B0eS9WVVFFck5xUE5qVGdsdkk5aHdOa0o3?= =?utf-8?B?WnBXNmZ2czZEVTRkUmZJS0drcGU1d0ZFWHBRTDlUTnZoOStzanN6TVc5Vm1s?= =?utf-8?B?ME00ZU1TWVhDOFpjdjNObTg5cHV2TUZWampvdjVuYTF3eGw0NEltQjBtYlVi?= =?utf-8?B?Q05xTXZTdWdweC8rY0VQSStFNWVaUEw4a2hWSzBMdVBlbjR6OEQybWxNNW5H?= =?utf-8?B?NmJTZVpIYWM2TEQyanMwTi8yem92RGx1dW92VDdxL0c4cHBrdXhUbWJTVTUr?= =?utf-8?B?TlhrZXBNbERlcFdsZjg5VDFpMVk0dXY1ekZkeXI3aHBLK3h2MDFuajFBaFFl?= =?utf-8?Q?O+FcR0bAB2EPJRZjlr+K/sMyr?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ed9ca9cf-77bc-4793-e58d-08daf3e501a2 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2023 15:03:32.9515 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: P5S87Vr6Lt4YjW2nUeTV8KtVvAi+Iu6HdeKUQgWunvxM9Znjt8XBDODKXXEnDNFSraaVD7kFFBUXBy5TmhA+GQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9295 On 04.01.2023 09:44, Xenia Ragiadakou wrote: > @@ -116,7 +115,11 @@ static int __init cf_check parse_iommu_param(const char *s) > iommu_verbose = 1; > } > else if ( (val = parse_boolean("amd-iommu-perdev-intremap", s, ss)) >= 0 ) > +#ifdef CONFIG_AMD_IOMMU > amd_iommu_perdev_intremap = val; > +#else > + no_config_param("AMD_IOMMU", "amd-iommu-perdev-intremap", s, ss); The string literal wants to be "iommu", I think. Please see other uses of no_config_param(). Jan From xen-devel-bounces@lists.xenproject.org Wed Jan 11 15:20:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 15:20:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475592.737330 (Exim 4.92) (envelope-from ) id 1pFctY-0005ey-JC; Wed, 11 Jan 2023 15:20:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475592.737330; Wed, 11 Jan 2023 15:20:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFctY-0005eL-Fk; Wed, 11 Jan 2023 15:20:04 +0000 Received: by outflank-mailman (input) for mailman id 475592; Wed, 11 Jan 2023 15:20:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFctX-0005Pg-OV for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 15:20:03 +0000 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [2a00:1450:4864:20::636]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6ac0335c-91c3-11ed-b8d0-410ff93cb8f0; Wed, 11 Jan 2023 16:20:01 +0100 (CET) Received: by mail-ej1-x636.google.com with SMTP id u9so37726917ejo.0 for ; Wed, 11 Jan 2023 07:20:01 -0800 (PST) Received: from [192.168.1.93] (adsl-139.109.242.137.tellas.gr. [109.242.137.139]) by smtp.gmail.com with ESMTPSA id 4-20020a170906300400b007b4bc423b41sm6310902ejz.190.2023.01.11.07.19.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Jan 2023 07:20:00 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6ac0335c-91c3-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6d3Rm4gSZWrkj+xvHGYHayuc1OKGY/sZHKxHJwdXIIk=; b=SgZSElsCSwvUXv5klue32nTPdvZ5NGHMGHqqi0k8IGfxXoJN7ehr6vZSWT4peBt2Lx n0SGoTiviqGvu9f9qsL0ePa+sa3r/KDXNw9w9fSXRKvuEwCWMWUMFA/Q7gJdto0KJhem Pfm/RvBlI4YWcFCYM2J9Ci68rNDSZISrUCK2MoS3/aF8ZLL430iDnpf67re5HebEztDY voTiUPCage/hCR0uJoQXW7iMu9U3MMH8fvDct7d1f4XMcypAmDebNrJXdCj/hXZh3Xw1 fC/9tCNFEtaUb5rBtcUPwjiEo2OqbiDA+4dAZr1i3l0kGkwHvpSuAc2cLua1mlu/lehV EkJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6d3Rm4gSZWrkj+xvHGYHayuc1OKGY/sZHKxHJwdXIIk=; b=3gptv2IyGKMM4/VRX01JjzBnj3demfBmf8UDmVK+mEaSuJrdXbGhUSS510bZqTLv4D LLXvz8wa3yd8co5Kvoqi5pCAeqXsJrI3Ql71mmzcBpcvl9lMRhO7I94KD7Ej+VPIyjiy XBLBxH3IiWrFHNWnZyuYSs10BjHCIr/mqPtAFHwahtsmzglWcUuYpEYq1Kgpu8FQVd57 8egc5DbDfeTrdhMqN9qkBP2i+GGROTQMJ2zGdZ2+4/jYSdKGHJJis+tQ2Z6bmEM8V/SP AlcxHlocOOjcCyRm3Z71XY9aqacCgGn1vxL3SySs4Dlgg2rTLlKqEueCNUelqYHy8yUl FDFA== X-Gm-Message-State: AFqh2kqarTFbTqnBTWOdmEOtz585THYpxudq3dtBFDleYz2Ie1GcC2hn TuDSLXHN8Z57DJekK+iYjPTXrTFFA1U= X-Google-Smtp-Source: AMrXdXu5pqUwZLrcRUNsu3uAbY+6t77DOkzBSBRMNM2P/IRed6PF/rekItGgxt8NXX/JvpvVqPLJew== X-Received: by 2002:a17:906:279a:b0:7c1:10b4:4742 with SMTP id j26-20020a170906279a00b007c110b44742mr58538232ejc.55.1673450401063; Wed, 11 Jan 2023 07:20:01 -0800 (PST) Message-ID: <57631dd0-0811-75af-12cc-9091228d2a6c@gmail.com> Date: Wed, 11 Jan 2023 17:19:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v2 2/8] x86/iommu: amd_iommu_perdev_intremap is AMD-Vi specific Content-Language: en-US To: Jan Beulich Cc: Andrew Cooper , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20230104084502.61734-1-burzalodowa@gmail.com> <20230104084502.61734-3-burzalodowa@gmail.com> From: Xenia Ragiadakou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/11/23 17:03, Jan Beulich wrote: > On 04.01.2023 09:44, Xenia Ragiadakou wrote: >> @@ -116,7 +115,11 @@ static int __init cf_check parse_iommu_param(const char *s) >> iommu_verbose = 1; >> } >> else if ( (val = parse_boolean("amd-iommu-perdev-intremap", s, ss)) >= 0 ) >> +#ifdef CONFIG_AMD_IOMMU >> amd_iommu_perdev_intremap = val; >> +#else >> + no_config_param("AMD_IOMMU", "amd-iommu-perdev-intremap", s, ss); > > The string literal wants to be "iommu", I think. Please see other uses of > no_config_param(). Thanks for reviewing this. You are right. I will fix it. -- Xenia From xen-devel-bounces@lists.xenproject.org Wed Jan 11 15:40:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 15:40:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475621.737359 (Exim 4.92) (envelope-from ) id 1pFdDS-0000qN-K0; Wed, 11 Jan 2023 15:40:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475621.737359; Wed, 11 Jan 2023 15:40:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFdDS-0000qG-HF; Wed, 11 Jan 2023 15:40:38 +0000 Received: by outflank-mailman (input) for mailman id 475621; Wed, 11 Jan 2023 15:40:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFdDQ-0000qA-Su for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 15:40:37 +0000 Received: from sonic307-55.consmr.mail.gq1.yahoo.com (sonic307-55.consmr.mail.gq1.yahoo.com [98.137.64.31]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 47c15eb5-91c6-11ed-b8d0-410ff93cb8f0; Wed, 11 Jan 2023 16:40:32 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.gq1.yahoo.com with HTTP; Wed, 11 Jan 2023 15:40:30 +0000 Received: by hermes--production-ne1-5648bd7666-fj7tv (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID ce1cce5b596248fed3d2923baf1d0f09; Wed, 11 Jan 2023 15:40:26 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 47c15eb5-91c6-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1673451630; bh=s6r8sDYEdbTeLYOFsl5nU8ZnCWpMdTQmdI104oVZvNw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=jRmQMdEuRFDFQ39ny7YSHp2wuML8TmnCuVUXgYcTsT/EQyrYROgQ+u/2DwiUOj4UL+7aGCEvHVqbv79ce6avA1dYwpaXzbbh2eu/8USXYKd27/wdoqacAxCfV69Fukt0SyW0v0VTrKzTfldVRsxKAsaoAJy65XG0VpuXckDppB7EJny2k5acsVfVkdK1VuRQ9zyyMNeS1CAE0tXnjMLZj+ApFmrgJIy51jBMIy6yQlGuZwzvWNYnIv+g3+e22JGZFm760CdMrIb6T8wHAY53eoE40jmKsiCPwZcUpzN8iLRkSbyv+2o46/qt/M/9IWkpLsfsoCaBUqZc5rOLnhqTiA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1673451630; bh=aOL7gpP8uLaEW3P9FsLedafrNgS/BxTOzvqfUf6PCYb=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=JzRwa4+M6y4har9euI9Ci2QQVCz1fZGRVkbf1940ww/tL1YsXY9hPqEjLIc+8yIPYZpnI9dsMst+GP/YKHvvHVaY7xXwS+KoXHAQVjObZSX0kQEEYInwkIgGIgwT3q1BWrfgvRlUpHHNp2cRiHY/BFcJJSTsmPcu7FFi4iCbLHZIYS25ukkQWGQz3yXF9y5MgCgxDjnuRAcEKRfvklT2ZOEgSvfF6pOk0Hq2p7ZQh0CceIDubJSA3RL3bPZ25MNP/OoAg17FM7O3rfcPe6mro4KFkQqoGPrfG5JhKGmDfBXMfskNCsRajOpIGSmgrdb3mSkrk3d97rtbS6JylpnQyQ== X-YMail-OSG: lYsCu0wVM1k3WaIGZI2L.iu2qG7YRcGMILSxRU5JPKmIxzl6i4pWw0n6uaaqZ5e LwF2H5FVE36O17cLqgvLhpPY2KSZlOD0jOBXQWuzE2aORxNhz3n9slMbtEtYFDmGRZaIrzSFiRQh N9Y5vP6plZnE6ppOw8m04V8YNTU.ldqdhM7PRwrSYiTYgGOWE41opg9ayUhhyNZ_R8HxYUxm69SG ESZuSYGPOJCUtO1ctqwGw6YOQHbdjUxNFd5zch1VV4HWgWQWkIt1jngEcjjPHDr7OK8MaP.ikv_u CoiVMeyvFBqmNaMSDyn5UV429_RtCFD_THF1g.6LoohrKy2iPYJAZCmSb2m93rm5ETITf_X5GQve d67nMqNKluS_gxdIErIs_W_S2aGfSTtcxkiU7OZ.Urg0pw2izynz_uVOvZel0Q2PZZ6ngYJTMWVX PEAqVZ2xmk5c0Th9OLuJYJA7ntTilJ3DW4IBtCCB4YU3OIPFPRl7LzPp56fZXhgs_W7ZyG2YnCbD M12j8qbqaErBtF4EL4BA0gxF.AczUTk.ZRlRnyQmUoyPzpgXJZHCA1jfwSxEGdD5SewAwhU4uoNU 3TEDkliOQ3P9nVqWpvX6OkJE_1ZqvmKU42iGPSl8DbT8rXgYgT82QTX3Fs6OLFWgQjCuqnvZMMzl 5w0PjjUqAP3LncL1ONGu3qp9YrQGFEuMEVGFK2eMEtlj.DIHP7ZMpfghNRuHpPXzrp3hi8np4B3E mn1mInSBQoR.J9WaOjd8sjUz5OR2EWMopLiy8ZGx_MOzCZv64.WbATk6FYX.oHG04xedmp6Th_J3 SHIUGiOsMT2ABNiXw5GpzWNjF7Uwt6e5ask9aN9vviojGi8QvGEUppU4YJmHxSc0QrFP3bM_1iJS lbBbKgvoXt62B9bWyKkhfD0MxdgL.bl2mOVuJoD_3LkDrNsYkM1IjtiUa03T58lt48_WbZcP5lsR 3_x2XwQMDTeWxRuzjUYgSEkb5zTmBdv0yU_lu6mdlt9EW4VcOKHwzyw3UH4Tp2Butko8p1Y9_cgR 1XLvcgymX6EhWZhuzR_joqwC_zv0q_MiwmZbrcPAJKM5Jl0lfIGiX_chUQT2udzUce.QadvT1faP ZdDyKXj9THauuKmHEmo7yvI9t_AMYBqT9BDZJzTOhkVeH2UTw6_.Qi3pcNhS0JMzAZciULhfJLqD A9oMRmW9L_l4BI3BPvWwfOTiZluoRz3hUVxWK3E6QdSiuLzNi4GFWTSckB0_lx.me9L3sYmeKNHq jcbOi3pvY8DTQqdfkZDQYXxLH4HCKv5mCyZzOhV0sr9noHkJzkGP62d9KKRSxkBh2Vfg0Dod2nIw 6bFu_tTxEU2oywhRSzCQe7QhpZmM_w2AG6.bA.MSOKxw_REoxO4m4wF_Kz.T5IELHTAjtw.Eb3KV 8GO8X2r1N_2TxoxzN0K8XxFK4YYOlRIYRxqm8qD4ZF5ThXOquujUCcoe7pi5HX5UyT9IcZjcft3T jBRrIYWf4wQ74ItrBCPX_GnTfL6m0sAVZG1bmn6gUVnGzQVQgqkcSumyzW50S.2hw6W28divjlX7 GIygfmdgVUti7VWgwTiHTvRw982a.buCK137Dbj1CjYAAWLR9QVjT14hUvjSFnu92W7ATWrzmKTJ PDbcP_xloobsPq_LbSbZ0vosDCvjCemWok7muaA8b5eFs9AjLiik3CFY1SDc0G0hi0s8Hri6HDNC clBhw_jkaIeBXOaN50LUBZBVILp7lW9ffd5q6zfnvfWmrPqAv56KrfQ53Wtpo8knUlvZuT61f0EX y958r_4fyAeukDMHaU8yIGt8PPqqph8B.PqRSdJNSyb8_K704kFVNkLQTSnotN9akVDFWKvCyBhD .BRlICshs4UapnpSBSldSLBlrUPNByk4JYsffdWM8Cy1AQUV2CQBfFNjDL3k7ixUJYz6s.8ll4k1 4eaI9ORQuZbgUpOzTBl5BzlMa6Bi0X._KreaoCmOF6d43qN7ASoUvEYbNOIkUI6dU8Nu5ZTee42r 4L19QDY_bh9J3R4HX8GV5Vfifc7Si8mXZmcacSvut8bQAWPDVbK3g4DJ0xvU9kE30Az9M1nitlO. 6b_Iky8YUyRzC.dCgOHKS1D7015zRrYGH7n1XNwkGnJVh7cbgoODU168JwaSR8max3RchS13W4Ss Uo_7tMdl2gQ34eZbBdZm1MK1okxDComQ9AHUSL38J5XljbGZKQ61n_4NxxfPmH69j1L6fKvN5WSS lJ.NMbXBt0K1peo1teE0RRTN.wg-- X-Sonic-MF: Message-ID: Date: Wed, 11 Jan 2023 10:40:24 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v8] xen/pt: reserve PCI slot 2 for Intel igd-passthru To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org, Stefano Stabellini , Anthony Perard , Paul Durrant , Paolo Bonzini , Richard Henderson , Eduardo Habkost , Marcel Apfelbaum , xen-devel@lists.xenproject.org, =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Bernhard Beschow References: <20230110030331-mutt-send-email-mst@kernel.org> Content-Language: en-US From: Chuck Zmudzinski In-Reply-To: <20230110030331-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.20982 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 14386 On 1/10/23 3:16 AM, Michael S. Tsirkin wrote: > On Tue, Jan 10, 2023 at 02:08:34AM -0500, Chuck Zmudzinski wrote: >> Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, >> as noted in docs/igd-assign.txt in the Qemu source code. >> >> Currently, when the xl toolstack is used to configure a Xen HVM guest with >> Intel IGD passthrough to the guest with the Qemu upstream device model, >> a Qemu emulated PCI device will occupy slot 2 and the Intel IGD will occupy >> a different slot. This problem often prevents the guest from booting. >> >> The only available workaround is not good: Configure Xen HVM guests to use >> the old and no longer maintained Qemu traditional device model available >> from xenbits.xen.org which does reserve slot 2 for the Intel IGD. >> >> To implement this feature in the Qemu upstream device model for Xen HVM >> guests, introduce the following new functions, types, and macros: >> >> * XEN_PT_DEVICE_CLASS declaration, based on the existing TYPE_XEN_PT_DEVICE >> * XEN_PT_DEVICE_GET_CLASS macro helper function for XEN_PT_DEVICE_CLASS >> * typedef XenPTQdevRealize function pointer >> * XEN_PCI_IGD_SLOT_MASK, the value of slot_reserved_mask to reserve slot 2 >> * xen_igd_reserve_slot and xen_igd_clear_slot functions >> >> The new xen_igd_reserve_slot function uses the existing slot_reserved_mask >> member of PCIBus to reserve PCI slot 2 for Xen HVM guests configured using >> the xl toolstack with the gfx_passthru option enabled, which sets the >> igd-passthru=on option to Qemu for the Xen HVM machine type. >> >> The new xen_igd_reserve_slot function also needs to be implemented in >> hw/xen/xen_pt_stub.c to prevent FTBFS during the link stage for the case >> when Qemu is configured with --enable-xen and --disable-xen-pci-passthrough, >> in which case it does nothing. >> >> The new xen_igd_clear_slot function overrides qdev->realize of the parent >> PCI device class to enable the Intel IGD to occupy slot 2 on the PCI bus >> since slot 2 was reserved by xen_igd_reserve_slot when the PCI bus was >> created in hw/i386/pc_piix.c for the case when igd-passthru=on. >> >> Move the call to xen_host_pci_device_get, and the associated error >> handling, from xen_pt_realize to the new xen_igd_clear_slot function to >> initialize the device class and vendor values which enables the checks for >> the Intel IGD to succeed. The verification that the host device is an >> Intel IGD to be passed through is done by checking the domain, bus, slot, >> and function values as well as by checking that gfx_passthru is enabled, >> the device class is VGA, and the device vendor in Intel. >> >> Signed-off-by: Chuck Zmudzinski >> --- >> Notes that might be helpful to reviewers of patched code in hw/xen: >> >> The new functions and types are based on recommendations from Qemu docs: >> https://qemu.readthedocs.io/en/latest/devel/qom.html >> >> Notes that might be helpful to reviewers of patched code in hw/i386: >> >> The small patch to hw/i386/pc_piix.c is protected by CONFIG_XEN so it does >> not affect builds that do not have CONFIG_XEN defined. >> >> xen_igd_gfx_pt_enabled() in the patched hw/i386/pc_piix.c file is an >> existing function that is only true when Qemu is built with >> xen-pci-passthrough enabled and the administrator has configured the Xen >> HVM guest with Qemu's igd-passthru=on option. >> >> v2: Remove From: tag at top of commit message >> >> v3: Changed the test for the Intel IGD in xen_igd_clear_slot: >> >> if (is_igd_vga_passthrough(&s->real_device) && >> (s->real_device.vendor_id == PCI_VENDOR_ID_INTEL)) { >> >> is changed to >> >> if (xen_igd_gfx_pt_enabled() && (s->hostaddr.slot == 2) >> && (s->hostaddr.function == 0)) { >> >> I hoped that I could use the test in v2, since it matches the >> other tests for the Intel IGD in Qemu and Xen, but those tests >> do not work because the necessary data structures are not set with >> their values yet. So instead use the test that the administrator >> has enabled gfx_passthru and the device address on the host is >> 02.0. This test does detect the Intel IGD correctly. >> >> v4: Use brchuckz@aol.com instead of brchuckz@netscape.net for the author's >> email address to match the address used by the same author in commits >> be9c61da and c0e86b76 >> >> Change variable for XEN_PT_DEVICE_CLASS: xptc changed to xpdc >> >> v5: The patch of xen_pt.c was re-worked to allow a more consistent test >> for the Intel IGD that uses the same criteria as in other places. >> This involved moving the call to xen_host_pci_device_get from >> xen_pt_realize to xen_igd_clear_slot and updating the checks for the >> Intel IGD in xen_igd_clear_slot: >> >> if (xen_igd_gfx_pt_enabled() && (s->hostaddr.slot == 2) >> && (s->hostaddr.function == 0)) { >> >> is changed to >> >> if (is_igd_vga_passthrough(&s->real_device) && >> s->real_device.domain == 0 && s->real_device.bus == 0 && >> s->real_device.dev == 2 && s->real_device.func == 0 && >> s->real_device.vendor_id == PCI_VENDOR_ID_INTEL) { >> >> Added an explanation for the move of xen_host_pci_device_get from >> xen_pt_realize to xen_igd_clear_slot to the commit message. >> >> Rebase. >> >> v6: Fix logging by removing these lines from the move from xen_pt_realize >> to xen_igd_clear_slot that was done in v5: >> >> XEN_PT_LOG(d, "Assigning real physical device %02x:%02x.%d" >> " to devfn 0x%x\n", >> s->hostaddr.bus, s->hostaddr.slot, s->hostaddr.function, >> s->dev.devfn); >> >> This log needs to be in xen_pt_realize because s->dev.devfn is not >> set yet in xen_igd_clear_slot. >> >> v7: The v7 that was posted to the mailing list was incorrect. v8 is what >> v7 was intended to be. >> >> v8: Inhibit out of context log message and needless processing by >> adding 2 lines at the top of the new xen_igd_clear_slot function: >> >> if (!(pci_bus->slot_reserved_mask & XEN_PCI_IGD_SLOT_MASK)) >> return; >> >> Rebase. This removed an unnecessary header file from xen_pt.h >> >> hw/i386/pc_piix.c | 3 +++ >> hw/xen/xen_pt.c | 49 ++++++++++++++++++++++++++++++++++++-------- >> hw/xen/xen_pt.h | 16 +++++++++++++++ >> hw/xen/xen_pt_stub.c | 4 ++++ >> 4 files changed, 63 insertions(+), 9 deletions(-) >> >> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c >> index b48047f50c..bc5efa4f59 100644 >> --- a/hw/i386/pc_piix.c >> +++ b/hw/i386/pc_piix.c >> @@ -405,6 +405,9 @@ static void pc_xen_hvm_init(MachineState *machine) >> } >> >> pc_xen_hvm_init_pci(machine); >> + if (xen_igd_gfx_pt_enabled()) { >> + xen_igd_reserve_slot(pcms->bus); >> + } >> pci_create_simple(pcms->bus, -1, "xen-platform"); >> } >> #endif > > I would even maybe go further and move the whole logic into > xen_igd_reserve_slot. And I would even just name it > xen_hvm_init_reserved_slots without worrying about the what > or why at the pc level. At this point it will be up to Xen maintainers. I see to do that would be to resolve the two pc_xen_hvm* functions in pc_piix.c that are guarded by CONFIG_XEN and move them to an appropriate place such as xen-hvm.c. That is along the lines of the work that Bernhard and Philippe are doing, so I am Cc'ing them. My first inclination is just to defer to them: I think eventually the little patch I propose here to pc_piix.c is eventually going to be moved out of pc_piix.c by Bernhard in a future patch. What they have been doing is very conservative, and I expect if and when Bernhard gets here to resolve those functions, they will do it in a way that keeps the dependency of the xenfv machine type on the pc machine type and the pc_init1 function. What I would propose would be to break the dependency of xenfv on the pc_init1 function. That is, I would propose having a xenfv_init function in xen-hvm.c, and the first version would be the current version of pc_init1, so xenfv would still depend on many i440fx type things, but with the change xen developers would be free to tweak xenfv_init without affecting the users of the pc machine type. Would that be a good idea? If I get posiive feedback for this idea, I will put it on the table, probably initially as an RFC patch. Also, thanks, Michael, for your other suggestions for this patch about using macros for the devfn constants. Chuck > >> diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c >> index 0ec7e52183..eff38155ef 100644 >> --- a/hw/xen/xen_pt.c >> +++ b/hw/xen/xen_pt.c >> @@ -780,15 +780,6 @@ static void xen_pt_realize(PCIDevice *d, Error **errp) >> s->hostaddr.bus, s->hostaddr.slot, s->hostaddr.function, >> s->dev.devfn); >> >> - xen_host_pci_device_get(&s->real_device, >> - s->hostaddr.domain, s->hostaddr.bus, >> - s->hostaddr.slot, s->hostaddr.function, >> - errp); >> - if (*errp) { >> - error_append_hint(errp, "Failed to \"open\" the real pci device"); >> - return; >> - } >> - >> s->is_virtfn = s->real_device.is_virtfn; >> if (s->is_virtfn) { >> XEN_PT_LOG(d, "%04x:%02x:%02x.%d is a SR-IOV Virtual Function\n", >> @@ -950,11 +941,50 @@ static void xen_pci_passthrough_instance_init(Object *obj) >> PCI_DEVICE(obj)->cap_present |= QEMU_PCI_CAP_EXPRESS; >> } >> >> +void xen_igd_reserve_slot(PCIBus *pci_bus) >> +{ >> + XEN_PT_LOG(0, "Reserving PCI slot 2 for IGD\n"); >> + pci_bus->slot_reserved_mask |= XEN_PCI_IGD_SLOT_MASK; >> +} >> + >> +static void xen_igd_clear_slot(DeviceState *qdev, Error **errp) >> +{ >> + ERRP_GUARD(); >> + PCIDevice *pci_dev = (PCIDevice *)qdev; >> + XenPCIPassthroughState *s = XEN_PT_DEVICE(pci_dev); >> + XenPTDeviceClass *xpdc = XEN_PT_DEVICE_GET_CLASS(s); >> + PCIBus *pci_bus = pci_get_bus(pci_dev); >> + >> + if (!(pci_bus->slot_reserved_mask & XEN_PCI_IGD_SLOT_MASK)) >> + return; >> + >> + xen_host_pci_device_get(&s->real_device, >> + s->hostaddr.domain, s->hostaddr.bus, >> + s->hostaddr.slot, s->hostaddr.function, >> + errp); >> + if (*errp) { >> + error_append_hint(errp, "Failed to \"open\" the real pci device"); >> + return; >> + } >> + >> + if (is_igd_vga_passthrough(&s->real_device) && >> + s->real_device.domain == 0 && s->real_device.bus == 0 && >> + s->real_device.dev == 2 && s->real_device.func == 0 && >> + s->real_device.vendor_id == PCI_VENDOR_ID_INTEL) { > > how about macros for these? > > #define XEN_PCI_IGD_DOMAIN 0 > #define XEN_PCI_IGD_BUS 0 > #define XEN_PCI_IGD_DEV 2 > #define XEN_PCI_IGD_FN 0 > >> + pci_bus->slot_reserved_mask &= ~XEN_PCI_IGD_SLOT_MASK; > > If you are going to do this, you should set it back > either after pci_qdev_realize or in unrealize, > for symmetry. > >> + XEN_PT_LOG(pci_dev, "Intel IGD found, using slot 2\n"); >> + } > > >> + xpdc->pci_qdev_realize(qdev, errp); >> +} >> + > > > >> static void xen_pci_passthrough_class_init(ObjectClass *klass, void *data) >> { >> DeviceClass *dc = DEVICE_CLASS(klass); >> PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); >> >> + XenPTDeviceClass *xpdc = XEN_PT_DEVICE_CLASS(klass); >> + xpdc->pci_qdev_realize = dc->realize; >> + dc->realize = xen_igd_clear_slot; >> k->realize = xen_pt_realize; >> k->exit = xen_pt_unregister_device; >> k->config_read = xen_pt_pci_read_config; >> @@ -977,6 +1007,7 @@ static const TypeInfo xen_pci_passthrough_info = { >> .instance_size = sizeof(XenPCIPassthroughState), >> .instance_finalize = xen_pci_passthrough_finalize, >> .class_init = xen_pci_passthrough_class_init, >> + .class_size = sizeof(XenPTDeviceClass), >> .instance_init = xen_pci_passthrough_instance_init, >> .interfaces = (InterfaceInfo[]) { >> { INTERFACE_CONVENTIONAL_PCI_DEVICE }, >> diff --git a/hw/xen/xen_pt.h b/hw/xen/xen_pt.h >> index cf10fc7bbf..8c25932b4b 100644 >> --- a/hw/xen/xen_pt.h >> +++ b/hw/xen/xen_pt.h >> @@ -2,6 +2,7 @@ >> #define XEN_PT_H >> >> #include "hw/xen/xen_common.h" >> +#include "hw/pci/pci_bus.h" >> #include "xen-host-pci-device.h" >> #include "qom/object.h" >> >> @@ -40,7 +41,20 @@ typedef struct XenPTReg XenPTReg; >> #define TYPE_XEN_PT_DEVICE "xen-pci-passthrough" >> OBJECT_DECLARE_SIMPLE_TYPE(XenPCIPassthroughState, XEN_PT_DEVICE) >> >> +#define XEN_PT_DEVICE_CLASS(klass) \ >> + OBJECT_CLASS_CHECK(XenPTDeviceClass, klass, TYPE_XEN_PT_DEVICE) >> +#define XEN_PT_DEVICE_GET_CLASS(obj) \ >> + OBJECT_GET_CLASS(XenPTDeviceClass, obj, TYPE_XEN_PT_DEVICE) >> + >> +typedef void (*XenPTQdevRealize)(DeviceState *qdev, Error **errp); >> + >> +typedef struct XenPTDeviceClass { >> + PCIDeviceClass parent_class; >> + XenPTQdevRealize pci_qdev_realize; >> +} XenPTDeviceClass; >> + >> uint32_t igd_read_opregion(XenPCIPassthroughState *s); >> +void xen_igd_reserve_slot(PCIBus *pci_bus); >> void igd_write_opregion(XenPCIPassthroughState *s, uint32_t val); >> void xen_igd_passthrough_isa_bridge_create(XenPCIPassthroughState *s, >> XenHostPCIDevice *dev); >> @@ -75,6 +89,8 @@ typedef int (*xen_pt_conf_byte_read) >> >> #define XEN_PCI_INTEL_OPREGION 0xfc >> >> +#define XEN_PCI_IGD_SLOT_MASK 0x4UL /* Intel IGD slot_reserved_mask */ >> + > > I think you want to calculate this based on dev fn: > > #define XEN_PCI_IGD_SLOT_MASK \ > (0x1 << PCI_SLOT(PCI_DEVFN(XEN_PCI_IGD_DEV, XEN_PCI_IGD_FN))) > > >> typedef enum { >> XEN_PT_GRP_TYPE_HARDWIRED = 0, /* 0 Hardwired reg group */ >> XEN_PT_GRP_TYPE_EMU, /* emul reg group */ >> diff --git a/hw/xen/xen_pt_stub.c b/hw/xen/xen_pt_stub.c >> index 2d8cac8d54..5c108446a8 100644 >> --- a/hw/xen/xen_pt_stub.c >> +++ b/hw/xen/xen_pt_stub.c >> @@ -20,3 +20,7 @@ void xen_igd_gfx_pt_set(bool value, Error **errp) >> error_setg(errp, "Xen PCI passthrough support not built in"); >> } >> } >> + >> +void xen_igd_reserve_slot(PCIBus *pci_bus) >> +{ >> +} >> -- >> 2.39.0 > From xen-devel-bounces@lists.xenproject.org Wed Jan 11 15:49:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 15:49:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475628.737369 (Exim 4.92) (envelope-from ) id 1pFdM0-0001aM-J9; Wed, 11 Jan 2023 15:49:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475628.737369; Wed, 11 Jan 2023 15:49:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFdM0-0001aF-GL; Wed, 11 Jan 2023 15:49:28 +0000 Received: by outflank-mailman (input) for mailman id 475628; Wed, 11 Jan 2023 15:49:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFdLz-0001a5-Ds; Wed, 11 Jan 2023 15:49:27 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFdLz-0003GB-A5; Wed, 11 Jan 2023 15:49:27 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFdLz-0006im-37; Wed, 11 Jan 2023 15:49:27 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pFdLz-0004bX-2e; Wed, 11 Jan 2023 15:49:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=3+zwuy+EA5WrvQE6y1eJ9ZPpehJnYnLBd21Jz9Lu3K8=; b=38JxeEyTIXxLd/jcJeDSQKd1N0 c93kXt/HHTKevL6jUrUONCYc2ybgrGidaNT1zPx0c4vKKOEwAAAIU4zfZeweTGlFIHST/nU75G3ke 18bzNi6N53V7JUSsK+hrMI44P3pCMIuQ3CTRuabJ6SLDeScn9zfV5hnJ2iFEumrJsCEo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 175720: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-freebsd10-i386:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-pair:xen-install/src_host:fail:heisenbug xen-unstable:test-amd64-i386-xl-vhd:guest-start.2:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=4d975798e11579fdf405b348543061129e01b0fb X-Osstest-Versions-That: xen=4d975798e11579fdf405b348543061129e01b0fb From: osstest service owner Date: Wed, 11 Jan 2023 15:49:27 +0000 flight 175720 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/175720/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-freebsd10-i386 7 xen-install fail pass in 175714 test-amd64-i386-pair 10 xen-install/src_host fail pass in 175714 test-amd64-i386-xl-vhd 22 guest-start.2 fail pass in 175714 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 175714 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 175714 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175714 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175714 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 175714 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175714 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 175714 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 175714 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 175714 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 175714 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175714 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 175714 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen 4d975798e11579fdf405b348543061129e01b0fb baseline version: xen 4d975798e11579fdf405b348543061129e01b0fb Last test of basis 175720 2023-01-11 08:10:04 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Wed Jan 11 16:59:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 16:59:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475636.737380 (Exim 4.92) (envelope-from ) id 1pFeRm-0000fb-Qy; Wed, 11 Jan 2023 16:59:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475636.737380; Wed, 11 Jan 2023 16:59:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFeRm-0000fU-OO; Wed, 11 Jan 2023 16:59:30 +0000 Received: by outflank-mailman (input) for mailman id 475636; Wed, 11 Jan 2023 16:59:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFeRl-0000fO-DN for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 16:59:29 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFeRk-0005Kj-Kz; Wed, 11 Jan 2023 16:59:28 +0000 Received: from 54-240-197-234.amazon.com ([54.240.197.234] helo=[192.168.5.208]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pFeRk-0006fG-Et; Wed, 11 Jan 2023 16:59:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=8JyxsweNSjFnsgr9I+UrD3dI3IlDhE6PVGuCmTDcsBg=; b=TqLmaPnp7KDDR415D3LtoZxJJw 0FOqiwID9R7GQsFIX4jYfdvPb203GecYn9CX+uZSmnCXXvHb4W8CUQH8cwkwU2EfgOL12zMBu4ON2 3EqlxTlE3StQipJaJdz2z34+Rk9yOF8Acg6W6d5YRPLwKvaD2Qy5OfNg5snJ3rAf2bWE=; Message-ID: <3e4ce6c0-9949-1312-f492-913b7dd2cf18@xen.org> Date: Wed, 11 Jan 2023 16:59:25 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [RFC PATCH 0/8] SVE feature for arm guests Content-Language: en-US To: Luca Fancellu , xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Anthony PERARD , Nick Rosbrook , Juergen Gross References: <20230111143826.3224-1-luca.fancellu@arm.com> From: Julien Grall In-Reply-To: <20230111143826.3224-1-luca.fancellu@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Luca, On 11/01/2023 14:38, Luca Fancellu wrote: > This serie is introducing the possibility for Dom0 and DomU guests to use > sve/sve2 instructions. > > SVE feature introduces new instruction and registers to improve performances on > floating point operations. > > The SVE feature is advertised using the ID_AA64PFR0_EL1 register, SVE field, and > when available the ID_AA64ZFR0_EL1 register provides additional information > about the implemented version and other SVE feature. > > New registers added by the SVE feature are Z0-Z31, P0-P15, FFR, ZCR_ELx. > > Z0-Z31 are scalable vector register whose size is implementation defined and > goes from 128 bits to maximum 2048, the term vector length will be used to refer > to this quantity. > P0-P15 are predicate registers and the size is the vector length divided by 8, > same size is the FFR (First Fault Register). > ZCR_ELx is a register that can control and restrict the maximum vector length > used by the exception level and all the lower exception levels, so for > example EL3 can restrict the vector length usable by EL3,2,1,0. > > The platform has a maximum implemented vector length, so for every value > written in ZCR register, if this value is above the implemented length, then the > lower value will be used. The RDVL instruction can be used to check what vector > length is the HW using after setting ZCR. > > For an SVE guest, the V0-V31 registers are part of the Z0-Z31, so there is no > need to save them separately, saving Z0-Z31 will save implicitly also V0-V31. > > SVE usage can be trapped using a flag in CPTR_EL2, hence in this serie the > register is added to the domain state, to be able to trap only the guests that > are not allowed to use SVE. > > This serie is introducing a command line parameter to enable Dom0 to use SVE and > to set its maximum vector length that by default is 0 which means the guest is > not allowed to use SVE. Values from 128 to 2048 mean the guest can use SVE with > the selected value used as maximum allowed vector length (which could be lower > if the implemented one is lower). > For DomUs, an XL parameter with the same way of use is introduced and a dom0less > DTB binding is created. > > The context switch is the most critical part because there can be big registers > to be saved, in this serie an easy approach is used and the context is > saved/restored every time for the guests that are allowed to use SVE. This would be OK for an initial approach. But I would be worry to officially support SVE because of the potential large impact on other users. What's the long term plan? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Jan 11 17:14:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 17:14:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475642.737392 (Exim 4.92) (envelope-from ) id 1pFegM-00032F-5J; Wed, 11 Jan 2023 17:14:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475642.737392; Wed, 11 Jan 2023 17:14:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFegM-000328-1W; Wed, 11 Jan 2023 17:14:34 +0000 Received: by outflank-mailman (input) for mailman id 475642; Wed, 11 Jan 2023 17:14:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFegK-00031y-0j; Wed, 11 Jan 2023 17:14:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFegJ-0005g2-Nq; Wed, 11 Jan 2023 17:14:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFegJ-00010p-Eb; Wed, 11 Jan 2023 17:14:31 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pFegJ-0005S0-E7; Wed, 11 Jan 2023 17:14:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=xVuqWYu0r/UOSN8D56WeD5YbVyHqDEwYeGxvcqgHbz8=; b=TdXs0+t9gba1Gsqq8UyhQHqzu9 Xl7J9ZdXOTmKYcaf2BRiOotkA01n+kQ7mVd30y8CPYmK36MYdtTnSP3Fv6PyVawoheW29fL2diN5t 7MelQxAYtkpmJNHFT8ktRT4GHFKrguFSIEpgyhiPvQoYAoM7+zlylWxucOLwjBTisDkk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 175725: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-amd64-xsm:xen-build:fail:regression qemu-mainline:build-amd64:xen-build:fail:regression qemu-mainline:build-i386:xen-build:fail:regression qemu-mainline:build-arm64-xsm:xen-build:fail:regression qemu-mainline:build-i386-xsm:xen-build:fail:regression qemu-mainline:build-arm64:xen-build:fail:regression qemu-mainline:build-armhf:xen-build:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-coresched-amd64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:build-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-rtds:build-check(1):blocked:nonblocking qemu-mainline:build-arm64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking qemu-mainline:build-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking qemu-mainline:build-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-dom0pvh-xl-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-dom0pvh-xl-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvshim:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-pygrub:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvhv2-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-freebsd11-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-freebsd12-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvhv2-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-multivcpu:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: qemuu=aa96ab7c9df59c615ca82b49c9062819e0a1c287 X-Osstest-Versions-That: qemuu=0ab12aa32462817f0a53fa6f6ce4baf664ef1713 From: osstest service owner Date: Wed, 11 Jan 2023 17:14:31 +0000 flight 175725 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/175725/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 175623 build-amd64 6 xen-build fail REGR. vs. 175623 build-i386 6 xen-build fail REGR. vs. 175623 build-arm64-xsm 6 xen-build fail REGR. vs. 175623 build-i386-xsm 6 xen-build fail REGR. vs. 175623 build-arm64 6 xen-build fail REGR. vs. 175623 build-armhf 6 xen-build fail REGR. vs. 175623 Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-win7-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ws16-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-shadow 1 build-check(1) blocked n/a test-amd64-i386-xl-vhd 1 build-check(1) blocked n/a test-amd64-i386-xl-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) blocked n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) blocked n/a test-armhf-armhf-xl-rtds 1 build-check(1) blocked n/a test-armhf-armhf-xl-vhd 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-amd 1 build-check(1) blocked n/a test-amd64-i386-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-i386 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-amd64 1 build-check(1) blocked n/a test-amd64-coresched-i386-xl 1 build-check(1) blocked n/a test-amd64-coresched-amd64-xl 1 build-check(1) blocked n/a test-amd64-amd64-xl-xsm 1 build-check(1) blocked n/a build-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-shadow 1 build-check(1) blocked n/a test-amd64-amd64-xl-rtds 1 build-check(1) blocked n/a build-arm64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ws16-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a build-armhf-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-amd64-dom0pvh-xl-amd 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 1 build-check(1) blocked n/a test-amd64-amd64-dom0pvh-xl-intel 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvshim 1 build-check(1) blocked n/a test-amd64-amd64-pair 1 build-check(1) blocked n/a test-amd64-amd64-pygrub 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvhv2-intel 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-freebsd11-amd64 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-freebsd12-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvhv2-amd 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-nested-amd 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-nested-intel 1 build-check(1) blocked n/a test-amd64-amd64-xl-multivcpu 1 build-check(1) blocked n/a test-amd64-amd64-xl 1 build-check(1) blocked n/a test-amd64-amd64-xl-credit1 1 build-check(1) blocked n/a test-amd64-amd64-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 1 build-check(1) blocked n/a test-armhf-armhf-xl-arndale 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-intel 1 build-check(1) blocked n/a test-amd64-i386-xl 1 build-check(1) blocked n/a test-amd64-i386-xl-pvshim 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a version targeted for testing: qemuu aa96ab7c9df59c615ca82b49c9062819e0a1c287 baseline version: qemuu 0ab12aa32462817f0a53fa6f6ce4baf664ef1713 Last test of basis 175623 2023-01-07 23:09:00 Z 3 days Failing since 175627 2023-01-08 14:40:14 Z 3 days 16 attempts Testing same since 175654 2023-01-09 18:08:58 Z 1 days 11 attempts ------------------------------------------------------------ People who touched revisions under test: Ard Biesheuvel Bernhard Beschow Christian Borntraeger Cindy Lu Dongli Zhang Eugenio Pérez Greg Kurz Guoyi Tu Hyman Huang(黄勇) Igor Mammedov Jason Wang Jonathan Cameron Kai Huang Laszlo Ersek Lei Xiang leixiang Liuxiangdong Longpeng Lubomir Rintel Marc-André Lureau Markus Armbruster Michael S. Tsirkin Nikita Ivanov Paolo Bonzini Peter Maydell Philippe Mathieu-Daudé Richard Henderson Thomas Huth Yanan Wang Yicong Yang Zeng Chi jobs: build-amd64-xsm fail build-arm64-xsm fail build-i386-xsm fail build-amd64 fail build-arm64 fail build-armhf fail build-i386 fail build-amd64-libvirt blocked build-arm64-libvirt blocked build-armhf-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl blocked test-amd64-coresched-amd64-xl blocked test-arm64-arm64-xl blocked test-armhf-armhf-xl blocked test-amd64-i386-xl blocked test-amd64-coresched-i386-xl blocked test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm blocked test-amd64-i386-xl-qemuu-debianhvm-i386-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm blocked test-arm64-arm64-xl-xsm blocked test-amd64-i386-xl-xsm blocked test-amd64-amd64-qemuu-nested-amd blocked test-amd64-amd64-xl-pvhv2-amd blocked test-amd64-i386-qemuu-rhel6hvm-amd blocked test-amd64-amd64-dom0pvh-xl-amd blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64 blocked test-amd64-i386-xl-qemuu-debianhvm-amd64 blocked test-amd64-i386-freebsd10-amd64 blocked test-amd64-amd64-qemuu-freebsd11-amd64 blocked test-amd64-amd64-qemuu-freebsd12-amd64 blocked test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked test-amd64-amd64-xl-qemuu-win7-amd64 blocked test-amd64-i386-xl-qemuu-win7-amd64 blocked test-amd64-amd64-xl-qemuu-ws16-amd64 blocked test-amd64-i386-xl-qemuu-ws16-amd64 blocked test-armhf-armhf-xl-arndale blocked test-amd64-amd64-xl-credit1 blocked test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 blocked test-amd64-amd64-xl-credit2 blocked test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 blocked test-armhf-armhf-xl-cubietruck blocked test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict blocked test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict blocked test-amd64-i386-freebsd10-i386 blocked test-amd64-amd64-qemuu-nested-intel blocked test-amd64-amd64-xl-pvhv2-intel blocked test-amd64-i386-qemuu-rhel6hvm-intel blocked test-amd64-amd64-dom0pvh-xl-intel blocked test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu blocked test-armhf-armhf-xl-multivcpu blocked test-amd64-amd64-pair blocked test-amd64-i386-pair blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim blocked test-amd64-i386-xl-pvshim blocked test-amd64-amd64-pygrub blocked test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds blocked test-armhf-armhf-xl-rtds blocked test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow blocked test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow blocked test-amd64-amd64-xl-shadow blocked test-amd64-i386-xl-shadow blocked test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd blocked test-amd64-i386-xl-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2556 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Jan 11 17:16:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 17:16:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475651.737403 (Exim 4.92) (envelope-from ) id 1pFeib-0003fD-NE; Wed, 11 Jan 2023 17:16:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475651.737403; Wed, 11 Jan 2023 17:16:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFeib-0003f6-JO; Wed, 11 Jan 2023 17:16:53 +0000 Received: by outflank-mailman (input) for mailman id 475651; Wed, 11 Jan 2023 17:16:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFeiZ-0003f0-Sl for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 17:16:51 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFeiZ-0005tZ-IU; Wed, 11 Jan 2023 17:16:51 +0000 Received: from 54-240-197-234.amazon.com ([54.240.197.234] helo=[192.168.5.208]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pFeiZ-0007er-Ce; Wed, 11 Jan 2023 17:16:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=2bzw1WLg844SYQ5XotTV+5/B3cmddNxNxoBmTA6gcb8=; b=1nF2crPSUbKxCLzolKIeIHrBeT cQn+vtmsWm2WbeErVdql+YJ4BsQqgbJCO3+bajdXDDUZIAZnxAMJGf4XVkiSzVuJREn8AkyPDXCWJ zVaA3M96h7m5xeQATefgrqOaU6cLpdGMlrqObZxFz+syQ/z6OkvFdnQ7rTBbuMQeXT3c=; Message-ID: Date: Wed, 11 Jan 2023 17:16:49 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [RFC PATCH 1/8] xen/arm: enable SVE extension for Xen Content-Language: en-US To: Luca Fancellu , xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20230111143826.3224-1-luca.fancellu@arm.com> <20230111143826.3224-2-luca.fancellu@arm.com> From: Julien Grall In-Reply-To: <20230111143826.3224-2-luca.fancellu@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Luca, As this is an RFC, I will be mostly making general comments. On 11/01/2023 14:38, Luca Fancellu wrote: > diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c > index 99577adb6c69..8ea3843ea8e8 100644 > --- a/xen/arch/arm/domain.c > +++ b/xen/arch/arm/domain.c > @@ -181,6 +181,8 @@ static void ctxt_switch_to(struct vcpu *n) > /* VGIC */ > gic_restore_state(n); > > + WRITE_SYSREG(n->arch.cptr_el2, CPTR_EL2); Shouldn't this need an isb() afterwards do ensure that any previously trapped will be accessible? [...] > @@ -122,6 +137,7 @@ __initcall(update_serrors_cpu_caps); > > void init_traps(void) > { > + register_t cptr_bits = get_default_cptr_flags(); > /* > * Setup Hyp vector base. Note they might get updated with the > * branch predictor hardening. > @@ -135,17 +151,15 @@ void init_traps(void) > /* Trap CP15 c15 used for implementation defined registers */ > WRITE_SYSREG(HSTR_T(15), HSTR_EL2); > > - /* Trap all coprocessor registers (0-13) except cp10 and > - * cp11 for VFP. > - * > - * /!\ All coprocessors except cp10 and cp11 cannot be used in Xen. > - * > - * On ARM64 the TCPx bits which we set here (0..9,12,13) are all > - * RES1, i.e. they would trap whether we did this write or not. > +#ifdef CONFIG_ARM64_SVE > + /* > + * Don't trap SVE now, Xen might need to access ZCR reg in cpufeature code, > + * trapping again or not will be handled on vcpu creation/scheduling later > */ Instead of enable by default at boot, can we try to enable/disable only when this is strictly needed? > - WRITE_SYSREG((HCPTR_CP_MASK & ~(HCPTR_CP(10) | HCPTR_CP(11))) | > - HCPTR_TTA | HCPTR_TAM, > - CPTR_EL2); > + cptr_bits &= ~HCPTR_CP(8); > +#endif > + > + WRITE_SYSREG(cptr_bits, CPTR_EL2); > > /* > * Configure HCR_EL2 with the bare minimum to run Xen until a guest Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Jan 11 17:28:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 17:28:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475658.737414 (Exim 4.92) (envelope-from ) id 1pFetL-0005Ag-M0; Wed, 11 Jan 2023 17:27:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475658.737414; Wed, 11 Jan 2023 17:27:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFetL-0005AZ-JE; Wed, 11 Jan 2023 17:27:59 +0000 Received: by outflank-mailman (input) for mailman id 475658; Wed, 11 Jan 2023 17:27:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFetK-0005AT-Pj for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 17:27:58 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFetK-000664-DN; Wed, 11 Jan 2023 17:27:58 +0000 Received: from 54-240-197-234.amazon.com ([54.240.197.234] helo=[192.168.5.208]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pFetK-00081C-5p; Wed, 11 Jan 2023 17:27:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=vx4ET+fi0wgacgZzFl1B6OvOIT/Q1T/uIXWJTLhiJ8Q=; b=5J+JVCemmfBxg9Q1/lVjUbiCzh WsVQFLjqhgkuxqdU8/t02lCHRd7GRsg/OsLkrPjMNiEXub9hHbnJ56l8dV454aAs7sizhMCEN9oXD PWlvaA3z2bbnPcACg/oX4XsdpQBhnMzAUxzS6IlZP5nKYow7YR/yWlTTrHP7L3MARm5c=; Message-ID: <91b5c7db-ec9b-efa6-f5cf-dc5e8b176db6@xen.org> Date: Wed, 11 Jan 2023 17:27:55 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [RFC PATCH 2/8] xen/arm: add sve_vl_bits field to domain Content-Language: en-US To: Luca Fancellu , xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu References: <20230111143826.3224-1-luca.fancellu@arm.com> <20230111143826.3224-3-luca.fancellu@arm.com> From: Julien Grall In-Reply-To: <20230111143826.3224-3-luca.fancellu@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Luca, On 11/01/2023 14:38, Luca Fancellu wrote: > Add sve_vl_bits field to arch_domain and xen_arch_domainconfig > structure, to allow the domain to have an information about the > SVE feature and the number of SVE register bits that are allowed > for this domain. > > The field is used also to allow or forbid a domain to use SVE, > because a value equal to zero means the guest is not allowed to > use the feature. > > When the guest is allowed to use SVE, the zcr_el2 register is > updated on context switch to restict the domain on the allowed > number of bits chosen, this value is the minimum among the chosen > value and the platform supported value. > > Signed-off-by: Luca Fancellu > --- > xen/arch/arm/arm64/sve.c | 9 ++++++ > xen/arch/arm/domain.c | 45 ++++++++++++++++++++++++++++ > xen/arch/arm/include/asm/arm64/sve.h | 12 ++++++++ > xen/arch/arm/include/asm/domain.h | 6 ++++ > xen/include/public/arch-arm.h | 2 ++ > xen/include/public/domctl.h | 2 +- > 6 files changed, 75 insertions(+), 1 deletion(-) > > diff --git a/xen/arch/arm/arm64/sve.c b/xen/arch/arm/arm64/sve.c > index 326389278292..b7695834f4ba 100644 > --- a/xen/arch/arm/arm64/sve.c > +++ b/xen/arch/arm/arm64/sve.c > @@ -6,6 +6,7 @@ > */ > > #include > +#include > #include > #include > > @@ -36,3 +37,11 @@ register_t vl_to_zcr(uint16_t vl) > { > return ((vl / SVE_VL_MULTIPLE_VAL) - 1U) & ZCR_ELx_LEN_MASK; > } > + > +/* Get the system sanitized value for VL in bits */ > +uint16_t get_sys_vl_len(void) > +{ > + /* ZCR_ELx len field is ((len+1) * 128) = vector bits length */ > + return ((system_cpuinfo.zcr64.bits[0] & ZCR_ELx_LEN_MASK) + 1U) * > + SVE_VL_MULTIPLE_VAL; > +} > diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c > index 8ea3843ea8e8..27f38729302b 100644 > --- a/xen/arch/arm/domain.c > +++ b/xen/arch/arm/domain.c > @@ -13,6 +13,7 @@ > #include > > #include > +#include > #include > #include > #include > @@ -183,6 +184,11 @@ static void ctxt_switch_to(struct vcpu *n) > > WRITE_SYSREG(n->arch.cptr_el2, CPTR_EL2); > > +#ifdef CONFIG_ARM64_SVE > + if ( is_sve_domain(n->domain) ) > + WRITE_SYSREG(n->arch.zcr_el2, ZCR_EL2); > +#endif I would actually expect that is_sve_domain() returns false when the SVE is not enabled. So can we simply remove the #ifdef? > + > /* VFP */ > vfp_restore_state(n); > > @@ -551,6 +557,11 @@ int arch_vcpu_create(struct vcpu *v) > v->arch.vmpidr = MPIDR_SMP | vcpuid_to_vaffinity(v->vcpu_id); > > v->arch.cptr_el2 = get_default_cptr_flags(); > + if ( is_sve_domain(v->domain) ) > + { > + v->arch.cptr_el2 &= ~HCPTR_CP(8); > + v->arch.zcr_el2 = vl_to_zcr(v->domain->arch.sve_vl_bits); > + } > > v->arch.hcr_el2 = get_default_hcr_flags(); > > @@ -595,6 +606,7 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config) > unsigned int max_vcpus; > unsigned int flags_required = (XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap); > unsigned int flags_optional = (XEN_DOMCTL_CDF_iommu | XEN_DOMCTL_CDF_vpmu); > + unsigned int sve_vl_bits = config->arch.sve_vl_bits; > > if ( (config->flags & ~flags_optional) != flags_required ) > { > @@ -603,6 +615,36 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config) > return -EINVAL; > } > > + /* Check feature flags */ > + if ( sve_vl_bits > 0 ) { > + unsigned int zcr_max_bits; > + > + if ( !cpu_has_sve ) > + { > + dprintk(XENLOG_INFO, "SVE is unsupported on this machine.\n"); > + return -EINVAL; > + } > + else if ( !is_vl_valid(sve_vl_bits) ) > + { > + dprintk(XENLOG_INFO, "Unsupported SVE vector length (%u)\n", > + sve_vl_bits); > + return -EINVAL; > + } > + /* > + * get_sys_vl_len() is the common safe value among all cpus, so if the > + * value specified by the user is above that value, use the safe value > + * instead. > + */ > + zcr_max_bits = get_sys_vl_len(); > + if ( sve_vl_bits > zcr_max_bits ) > + { > + config->arch.sve_vl_bits = zcr_max_bits; > + dprintk(XENLOG_INFO, > + "SVE vector length lowered to %u, safe value among CPUs\n", > + zcr_max_bits); > + } I don't think Xen should "downgrade" the value. Instead, this should be the decision from the tools. So we want to find a different way to reproduce the value (Andrew may have some ideas here as he was looking at it). > + } > + > /* The P2M table must always be shared between the CPU and the IOMMU */ > if ( config->iommu_opts & XEN_DOMCTL_IOMMU_no_sharept ) > { > @@ -745,6 +787,9 @@ int arch_domain_create(struct domain *d, > if ( (rc = domain_vpci_init(d)) != 0 ) > goto fail; > > + /* Copy sve_vl_bits to the domain configuration */ > + d->arch.sve_vl_bits = config->arch.sve_vl_bits; > + > return 0; > > fail: > diff --git a/xen/arch/arm/include/asm/arm64/sve.h b/xen/arch/arm/include/asm/arm64/sve.h > index bd56e2f24230..f4a660e402ca 100644 > --- a/xen/arch/arm/include/asm/arm64/sve.h > +++ b/xen/arch/arm/include/asm/arm64/sve.h > @@ -13,10 +13,17 @@ > /* Vector length must be multiple of 128 */ > #define SVE_VL_MULTIPLE_VAL (128U) > > +static inline bool is_vl_valid(uint16_t vl) > +{ > + /* SVE vector length is multiple of 128 and maximum 2048 */ > + return ((vl % SVE_VL_MULTIPLE_VAL) == 0) && (vl <= SVE_VL_MAX_BITS); > +} > + > #ifdef CONFIG_ARM64_SVE > > register_t compute_max_zcr(void); > register_t vl_to_zcr(uint16_t vl); > +uint16_t get_sys_vl_len(void); > > #else /* !CONFIG_ARM64_SVE */ > > @@ -30,6 +37,11 @@ static inline register_t vl_to_zcr(uint16_t vl) > return 0; > } > > +static inline uint16_t get_sys_vl_len(void) > +{ > + return 0; > +} > + > #endif > > #endif /* _ARM_ARM64_SVE_H */ > diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm/domain.h > index 42eb5df320a7..e4794a9fd2ab 100644 > --- a/xen/arch/arm/include/asm/domain.h > +++ b/xen/arch/arm/include/asm/domain.h > @@ -31,6 +31,8 @@ enum domain_type { > > #define is_domain_direct_mapped(d) ((d)->cdf & CDF_directmap) > > +#define is_sve_domain(d) ((d)->arch.sve_vl_bits > 0) > + > /* > * Is the domain using the host memory layout? > * > @@ -114,6 +116,9 @@ struct arch_domain > void *tee; > #endif > > + /* max SVE vector length in bits */ > + uint16_t sve_vl_bits; > + > } __cacheline_aligned; > > struct arch_vcpu > @@ -190,6 +195,7 @@ struct arch_vcpu > register_t tpidrro_el0; > > /* HYP configuration */ > + register_t zcr_el2; > register_t cptr_el2; > register_t hcr_el2; > register_t mdcr_el2; > diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h > index 1528ced5097a..e18a075105f0 100644 > --- a/xen/include/public/arch-arm.h > +++ b/xen/include/public/arch-arm.h > @@ -304,6 +304,8 @@ struct xen_arch_domainconfig { > uint16_t tee_type; > /* IN */ > uint32_t nr_spis; > + /* IN */ > + uint16_t sve_vl_bits; Please spell out the padding clearly (even though I know there is one in this structure that is not mentioned). > /* > * OUT > * Based on the property clock-frequency in the DT timer node. > diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h > index 51be28c3de7c..616d7a1c070d 100644 > --- a/xen/include/public/domctl.h > +++ b/xen/include/public/domctl.h > @@ -21,7 +21,7 @@ > #include "hvm/save.h" > #include "memory.h" > > -#define XEN_DOMCTL_INTERFACE_VERSION 0x00000015 > +#define XEN_DOMCTL_INTERFACE_VERSION 0x00000016 > > /* > * NB. xen_domctl.domain is an IN/OUT parameter for this operation. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Jan 11 17:41:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 17:41:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475664.737425 (Exim 4.92) (envelope-from ) id 1pFf66-0007U2-Pi; Wed, 11 Jan 2023 17:41:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475664.737425; Wed, 11 Jan 2023 17:41:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFf66-0007Tv-Mv; Wed, 11 Jan 2023 17:41:10 +0000 Received: by outflank-mailman (input) for mailman id 475664; Wed, 11 Jan 2023 17:41:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFf65-0007Tp-Sz for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 17:41:09 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFf65-0006Vr-ML; Wed, 11 Jan 2023 17:41:09 +0000 Received: from 54-240-197-234.amazon.com ([54.240.197.234] helo=[192.168.5.208]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pFf65-0000Am-GH; Wed, 11 Jan 2023 17:41:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:Cc: References:To:Subject:MIME-Version:Date:Message-ID; bh=fv3MXOu6EuolHTnQDcmuRLHyg/qPSeb3PzTxILBhHN8=; b=dv7SVcKhR+mtH7H4vfq+alyXYz 01aYzpxEVaPQfeNfZcLvYAxF9K4MBEEIOGPyBXKjvNkmfFD/GdQHSQKRC9vlV5SG69HKWN5IxtZRJ NDhIpDFi62cv+0jd0oz4E8dKaMhRw9DbT9QfXo6YqPOuOyPBiFx8m8j2ldmddbTF3CiU=; Message-ID: <3e7059c2-0d23-03f2-9a93-f88de09171f4@xen.org> Date: Wed, 11 Jan 2023 17:41:08 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: Xenalyze on ARM ( NXP S32G3 with Cortex-A53) Content-Language: en-US To: El Mesdadi Youssef ESK UILD7 , "xen-devel@lists.xenproject.org" References: Cc: Stefano Stabellini From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit (+Stefano) On 10/01/2023 14:20, El Mesdadi Youssef ESK UILD7 wrote: >>> Hello, > >>> > I'm trying to measure the performance of Xen on the S32G3 microprocessor, unfortunately, after following the BSP-Linux to install Xen, I found that Xentrace is not available or not compatible with ARM architecture. I have seen some studies on Xilinx, and how they made Xentrace compatible with ARM, but I have no resources or access to get that and make it work on my Board. If there is any help I would appreciate it and thanks in advance. xentrace should work on upstream Xen. What did you version did you try? Can you also clarify the error you are seen? > >>> I have some extra questions, and it will be helpful to share your ideas with me, > > > * Is it possible to run a native application ( C-code) on the virtual machine, turn on a LED, have access to the GPIO, or send some messages using Can-Interface? Yes if you assign (or provide para-virtualized driver) the GPIO/LED/Can-Interface to the guest. > * My Board has no Ethernet, and no Extern SD Card, is there any method I can use to build a kernel for an operating system with my laptop, and transfer it to the board? I am confused, if you don't have network and an external sdcard, then you did you first put Xen on your system? In theory you could transfer the binary (using base64) via the serial console. But that's hackish. Instead, I would recommend to speak with the board vendor and ask them how you can upload your own software. > * Any suggestions in detail to measure the interrupt latency, Xen Overhead, and switch context (time to switch from one VM to another, that's what I wanted to measure with Xenalyze) xentrace will be your best bet. Otherwise, you will need to implement custom tracing. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Jan 11 17:45:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 17:45:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475671.737435 (Exim 4.92) (envelope-from ) id 1pFfAH-00086X-9f; Wed, 11 Jan 2023 17:45:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475671.737435; Wed, 11 Jan 2023 17:45:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFfAH-00086Q-6x; Wed, 11 Jan 2023 17:45:29 +0000 Received: by outflank-mailman (input) for mailman id 475671; Wed, 11 Jan 2023 17:45:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFfAF-00086I-MW for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 17:45:27 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFfAE-0006eP-VP; Wed, 11 Jan 2023 17:45:26 +0000 Received: from 54-240-197-234.amazon.com ([54.240.197.234] helo=[192.168.5.208]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pFfAE-0000Pa-Pp; Wed, 11 Jan 2023 17:45:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=a7QlcAv1z/+JZ8qrnZpz/POOL4amY4nEQ0WiQriXJG0=; b=YzmBMgq9bQ0gAKVpfTR/6CRZZQ Q6DrYuFUms0C/GOU31dBdYFRj9UmemBjdBTHKIjPjG3maRNDRoiTylzrj2oqKYZIzu//A5Cjx39cq 0d5VH6vtFuLHR1Y91aMdv6eBUI34kUuncpKr8Gw8o6Kcxw+EsE+5Ek9V+dwFf7hetYkw=; Message-ID: <4715f53c-ace8-5f45-edea-4391cc308524@xen.org> Date: Wed, 11 Jan 2023 17:45:25 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 04/19] tools/xenstore: remove all watches when a domain has stopped Content-Language: en-US To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20221213160045.28170-1-jgross@suse.com> <20221213160045.28170-5-jgross@suse.com> <831c0e75-1a23-6210-9f5b-7212a6763dc3@xen.org> <27c0f7bd-b548-17f4-d675-7143e218fd65@suse.com> From: Julien Grall In-Reply-To: <27c0f7bd-b548-17f4-d675-7143e218fd65@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Juergen, On 11/01/2023 06:36, Juergen Gross wrote: > On 20.12.22 20:01, Julien Grall wrote: >> On 13/12/2022 16:00, Juergen Gross wrote: >>> When a domain has been released by Xen tools, remove all its >>> registered watches. This avoids sending watch events to the dead domain >>> when all the nodes related to it are being removed by the Xen tools. >> >> AFAICT, the only user of the command in the tree is softreset. Would >> you be able to check this is still working as expected? > > Seems to work fine. Thanks for the confirmation! You can add my reviewed-by: Reviewed-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Jan 11 17:46:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 17:46:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475677.737447 (Exim 4.92) (envelope-from ) id 1pFfBO-0000Cy-LB; Wed, 11 Jan 2023 17:46:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475677.737447; Wed, 11 Jan 2023 17:46:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFfBO-0000Cr-Gr; Wed, 11 Jan 2023 17:46:38 +0000 Received: by outflank-mailman (input) for mailman id 475677; Wed, 11 Jan 2023 17:46:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFfBN-0000Cl-AD for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 17:46:37 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFfBM-0006pK-KA; Wed, 11 Jan 2023 17:46:36 +0000 Received: from 54-240-197-234.amazon.com ([54.240.197.234] helo=[192.168.5.208]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pFfBM-0000QX-EY; Wed, 11 Jan 2023 17:46:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=Jvy5eD9ZeUAtNcJWnt2kJUd5icqyY9UC1xK7nopURIA=; b=PO7N406FBi0TsjelWwOzO7r9YR Roq7YBxAWuL9bEYoFhZovjoKzOAfU0TdpgFOisQCpfwN2Jk7A5jyjebSQRPIWpGW7Gz75uZgzKEj8 HSyopx0/r8TqNllC33M+wOxIUuRsJC+cziVxkVk/roePs42Bg0oWVYNB/MIETLsbKA2I=; Message-ID: <0d56e193-c70d-e65a-f4a5-02babc608045@xen.org> Date: Wed, 11 Jan 2023 17:46:35 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 07/19] tools/xenstore: introduce dummy nodes for special watch paths Content-Language: en-US To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20221213160045.28170-1-jgross@suse.com> <20221213160045.28170-8-jgross@suse.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Juergen, On 11/01/2023 06:41, Juergen Gross wrote: > On 20.12.22 20:39, Julien Grall wrote: >>> +static void fire_special_watches(const char *name) >>> +{ >>> +    void *ctx = talloc_new(NULL); >>> +    struct node *node; >>> + >>> +    if (!ctx) >>> +        return; >>> + >>> +    node = read_node(NULL, ctx, name); >>> + >>> +    if (node) >>> +        fire_watches(NULL, ctx, name, node, true, NULL); >> >> NIT: I would consider to log an error (maybe only once) if 'node' is >> NULL. The purpose is to help debugging Xenstored. > > I think we can log it always, as this is really a bad problem. That works for me. If it is always logged, then I guess this would need to be a syslog message as well. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Jan 11 17:48:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 17:48:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475683.737458 (Exim 4.92) (envelope-from ) id 1pFfDb-0000ph-0o; Wed, 11 Jan 2023 17:48:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475683.737458; Wed, 11 Jan 2023 17:48:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFfDa-0000pa-Tw; Wed, 11 Jan 2023 17:48:54 +0000 Received: by outflank-mailman (input) for mailman id 475683; Wed, 11 Jan 2023 17:48:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFfDY-0000pQ-TV for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 17:48:52 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFfDY-0006r9-5g; Wed, 11 Jan 2023 17:48:52 +0000 Received: from 54-240-197-234.amazon.com ([54.240.197.234] helo=[192.168.5.208]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pFfDX-0000TV-ND; Wed, 11 Jan 2023 17:48:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=hFdyGGRIGPGTdIo6+1cWsTsw+9Ohkpo48FAwiLTbEiM=; b=YX5IoEuFCotJcph4MvfYhCiTx6 snYuEVlzWX1/2NaXSMJYGmgjfwjYWSetKGF49I+twJ7w1voQtD2QTmtlRXB88MoLzPAES5hIqhdqm aIvJLv467iv4y/HT/Ee323Ea4x/jXHdIfJ5owFPwbO5mpbRFb/hhkarr4xr6YL3sJagQ=; Message-ID: Date: Wed, 11 Jan 2023 17:48:50 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 10/19] tools/xenstore: change per-domain node accounting interface Content-Language: en-US To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20221213160045.28170-1-jgross@suse.com> <20221213160045.28170-11-jgross@suse.com> <05871696-1638-82d0-8d55-9088b4bb9a18@suse.com> From: Julien Grall In-Reply-To: <05871696-1638-82d0-8d55-9088b4bb9a18@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Juergen, On 11/01/2023 08:59, Juergen Gross wrote: >> ... to make sure domain_nbentry_add() is not returning a negative >> value. Then it would not work. >> >> A good example imagine you have a transaction removing nodes from tree >> but not adding any. Then the "ret" would be negative. >> >> Meanwhile the nodes are also removed outside of the transaction. So >> the sum of "d->nbentry + ret" would be negative resulting to a failure >> here. > > Thanks for catching this. > > I think the correct way to handle this is to return max(d->nbentry + > ret, 0) in > domain_nbentry_add(). The value might be imprecise, but always >= 0 and > never > wrong outside of a transaction collision. I am bit confused with your proposal. If the return value is imprecise, then what's the point of returning max(...) instead of simply 0? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Jan 11 17:50:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 17:50:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475689.737469 (Exim 4.92) (envelope-from ) id 1pFfF9-0002Dh-BT; Wed, 11 Jan 2023 17:50:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475689.737469; Wed, 11 Jan 2023 17:50:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFfF9-0002Da-8a; Wed, 11 Jan 2023 17:50:31 +0000 Received: by outflank-mailman (input) for mailman id 475689; Wed, 11 Jan 2023 17:50:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFfF8-0002DU-LZ for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 17:50:30 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFfF8-0006u0-2H; Wed, 11 Jan 2023 17:50:30 +0000 Received: from 54-240-197-234.amazon.com ([54.240.197.234] helo=[192.168.5.208]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pFfF7-0000UZ-Sw; Wed, 11 Jan 2023 17:50:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=sAeILFWTwtmh4b34OUGqh46wnnEdsZZkpDl1zLNmOog=; b=ox4ZhNHBLi2qpcwF7osKlnq+Dd 2NtMsnlmRtSlvJvkz13HKdXVEn6P4n9DsuY7kEHO9dAY8EhgAu6pzlxz7GLz3aLPVTuQhJsgeMs6Q 0kEmYUU+g6ugqizjq7MWPNvBu2ZVWgO438p2XXt60ewxb+GTtJpyKREyhqT9HDXe0ug8=; Message-ID: <79a999c7-af1f-1cf2-6d01-ac70bdd1972d@xen.org> Date: Wed, 11 Jan 2023 17:50:28 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 15/19] tools/xenstore: switch hashtable to use the talloc framework Content-Language: en-US To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20221213160045.28170-1-jgross@suse.com> <20221213160045.28170-16-jgross@suse.com> <00c146ee-b0d4-55bd-3276-4894b26cd83c@suse.com> From: Julien Grall In-Reply-To: <00c146ee-b0d4-55bd-3276-4894b26cd83c@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, On 11/01/2023 09:27, Juergen Gross wrote: > On 20.12.22 22:50, Julien Grall wrote: >> Hi Juergen, >> >> On 13/12/2022 16:00, Juergen Gross wrote: >>> @@ -115,47 +117,32 @@ hashtable_expand(struct hashtable *h) >>>       if (h->primeindex == (prime_table_length - 1)) return 0; >>>       newsize = primes[++(h->primeindex)]; >>> -    newtable = (struct entry **)calloc(newsize, sizeof(struct entry*)); >>> -    if (NULL != newtable) >>> +    newtable = talloc_realloc(h, h->table, struct entry *, newsize); >>> +    if (!newtable) >>>       { >>> -        /* This algorithm is not 'stable'. ie. it reverses the list >>> -         * when it transfers entries between the tables */ >>> -        for (i = 0; i < h->tablelength; i++) { >>> -            while (NULL != (e = h->table[i])) { >>> -                h->table[i] = e->next; >>> -                index = indexFor(newsize,e->h); >>> +        h->primeindex--; >>> +        return 0; >>> +    } >>> + >>> +    h->table = newtable; >>> +    memset(newtable + h->tablelength, 0, >>> +           (newsize - h->tablelength) * sizeof(*newtable)); >>> +    for (i = 0; i < h->tablelength; i++) { >> >> I understand this code is taken from the realloc path. However, isn't >> this algorithm also not stable? If so, then I think we move the >> comment here. > > I'm fine with that, even if I don't see how it would matter. There is no > guarantee regarding the order of entries for a given index. That's a fair point. Feel free to ignore my comment then :). >>> +            if (index == i) >>> +            { >>> +                pE = &(e->next); >>> +            } >>> +            else >>> +            { >>> +                *pE = e->next; >>>                   e->next = newtable[index]; >>>                   newtable[index] = e; >>>               } >>>           } >>> -        free(h->table); >>> -        h->table = newtable; >>> -    } >>> -    /* Plan B: realloc instead */ >>> -    else >>> -    { >>> -        newtable = (struct entry **) >>> -                   realloc(h->table, newsize * sizeof(struct entry *)); >>> -        if (NULL == newtable) { (h->primeindex)--; return 0; } >>> -        h->table = newtable; >>> -        memset(newtable + h->tablelength, 0, >>> -               (newsize - h->tablelength) * sizeof(*newtable)); >>> -        for (i = 0; i < h->tablelength; i++) { >>> -            for (pE = &(newtable[i]), e = *pE; e != NULL; e = *pE) { >>> -                index = indexFor(newsize,e->h); >>> -                if (index == i) >>> -                { >>> -                    pE = &(e->next); >>> -                } >>> -                else >>> -                { >>> -                    *pE = e->next; >>> -                    e->next = newtable[index]; >>> -                    newtable[index] = e; >>> -                } >>> -            } >>> -        } >>>       } >>> + >>>       h->tablelength = newsize; >>>       h->loadlimit   = (unsigned int) >>>           (((uint64_t)newsize * max_load_factor) / 100); >>> @@ -184,7 +171,7 @@ hashtable_insert(struct hashtable *h, void *k, >>> void *v) >>>            * element may be ok. Next time we insert, we'll try >>> expanding again.*/ >>>           hashtable_expand(h); >>>       } >>> -    e = (struct entry *)calloc(1, sizeof(struct entry)); >>> +    e = talloc_zero(h, struct entry); >>>       if (NULL == e) { --(h->entrycount); return 0; } /*oom*/ >>>       e->h = hash(h,k); >>>       index = indexFor(h->tablelength,e->h); >>> @@ -238,8 +225,8 @@ hashtable_remove(struct hashtable *h, void *k) >>>               h->entrycount--; >>>               v = e->v; >>>               if (h->flags & HASHTABLE_FREE_KEY) >>> -                free(e->k); >>> -            free(e); >>> +                talloc_free(e->k); >>> +            talloc_free(e); >>>               return v; >>>           } >>>           pE = &(e->next); >>> @@ -280,25 +267,20 @@ void >>>   hashtable_destroy(struct hashtable *h) >>>   { >>>       unsigned int i; >>> -    struct entry *e, *f; >>> +    struct entry *e; >>>       struct entry **table = h->table; >>>       for (i = 0; i < h->tablelength; i++) >>>       { >>> -        e = table[i]; >>> -        while (NULL != e) >>> +        for (e = table[i]; e; e = e->next) >>>           { >>> -            f = e; >>> -            e = e->next; >>>               if (h->flags & HASHTABLE_FREE_KEY) >>> -                free(f->k); >>> +                talloc_free(e->k); >>>               if (h->flags & HASHTABLE_FREE_VALUE) >>> -                free(f->v); >>> -            free(f); >> >> AFAIU, the loop is reworked so you let talloc to free each element >> with the parent. Using a while loop is definitely cleaner, but now you >> will end up to have two separate loop for the elements. >> >> There is a risk that the overall performance of hashtable_destroy() >> will be worse as the data accessed in one loop may not fit in the >> cache. So you will have to reload it on the second loop. >> >> Therefore, I think it would be better to keep the loop as-is. > > What about a completely different approach? I could make the key and value > talloc children of e when _inserting_ the element and the related flag is > set. This would reduce hashtable_destroy to a single talloc_free(). I am fine with that. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Jan 11 18:18:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 18:18:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475696.737479 (Exim 4.92) (envelope-from ) id 1pFfgF-0004tE-KW; Wed, 11 Jan 2023 18:18:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475696.737479; Wed, 11 Jan 2023 18:18:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFfgF-0004t7-He; Wed, 11 Jan 2023 18:18:31 +0000 Received: by outflank-mailman (input) for mailman id 475696; Wed, 11 Jan 2023 18:18:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFfgD-0004t1-Og for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 18:18:29 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 56dafc82-91dc-11ed-91b6-6bf2151ebd3b; Wed, 11 Jan 2023 19:18:27 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 56dafc82-91dc-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1673461107; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=8eWpl94CgVNDdkjjqPyLI3KBUVFTsyRmT98TKI665ck=; b=dsVsbTdsBg8z+f+jFXNZP3vNjqLkMPhb44ZHkLvG7RY29bzET60YdtSP iBQNCEVnD/coboH4592N9XjavAHrXLhNQvXGVd/+2s0S/lyVi5rY0c/pC 50P5tZBpceim0o9ErPBKj5NRp8VaHPvQg+RUEt66/fW3+KB65l1xWyd0X E=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 92218242 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:5lxhZarKMUvrhYru9AfC5ob7/8heBmIZZRIvgKrLsJaIsI4StFCzt garIBnSOPbfZWKnLox3ao3g8EtV65TVnNU3HVE5+y40EHgb8puZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpAFc+E0/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06W1wUmAWP6gR5weHziBNVvrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXACoDVRSu2tK9+bLla81lo8JzNvW2FoxK7xmMzRmBZRonaZXKQqGM7t5ExjYgwMtJGJ4yZ eJAN2ApNk6ZJUQSZBFHU/rSn8/x7pX7WzRetFKSo7tx+2XJxRZ9+LPsLMDUapqBQsA9ckOw9 zicpjSjXkty2Nq34gKf6lm+nPH0nwCgYa8SMqK98v9PqQjGroAUIEJPDgbqyRWjsWauVtQaJ 0EK9y4Gqakp6FftXtT7Rwe/onOPolgbQdU4O+8w5RyJy6HUyx2EHWVCRTlEAOHKr+dvG2Zsj AXQ2Yq0W3o/69V5VE5x6J+Oowi2FHUlJlYCOw4gRC4Ds8Pf/as820enoslYLIa5idj8GDfVy j+MrTQji7h7sfPnx5lX7nic3Wvy+8Ghohodo1yOAzn7tl8RiJuNPdTA1LTN0RpXwG91pHGlt WNMpcWR5ftm4XqlxH3UG7Vl8F1ECp+43NzgbbxHRcJJG9eFoSTLkWVsDNZWei9U3j4sI2OBX aMqkVo5CGVvFHWrd7RrRIm6Ft4ny6Ptffy8CK+PNYUTPMgsK1HXlM2LWaJ39zmz+HXAbIllY cvLGSpSJSty5VtbIMqeGL5GjO5DKtEWzmLPX5HrpylLIpLHDEN5vYwtaQPUBshgtfPsnekg2 4oHXyd840kFAbKWj+i+2dJ7EG3m2lBiW8mo8JIJJ7LdSuekcUl4Y8LsLXoaU9QNt8xoei3gp xlRhmcwJILDuED6 IronPort-HdrOrdr: A9a23:ZAoJ4KxiJ4IRZuDHZ9xgKrPxv+skLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9IYgBZpTnyAtj6fZq8z+893WB1B9uftWbdyQ+Vxe1ZjLcKhgeQYhEWldQtnZ uIEZIOb+EYZGIS5amV3OD7KadH/DDtytHKuQ6q9QYJcegcUdAD0+4WMGamO3wzYDMDKYsyFZ Ka6MYCjSGnY24rYsOyAWRAd/TfpvXQ/aiWKyIuNloC0k2jnDmo4Ln1H1yzxREFSQ5Cxr8k7C zsjxH53KO+qPu2oyWsmlM7rq4m1OcJ+OEzSvBkufJlawkETTzYJLiJbofy8wzdZtvfq2rC3u O84SvIdP4DkU85NlvF3CcFnTOQmwrGokWStWOwkD/tp9f0Syk9DNcEjYVFcgHB405lp91k1r lXtljpw6a/ICmw7hgV3eK4Ii1Chw6xuz4vgOQTh3tQXc8Xb6JQt5UW+AdQHI0bFCz35Yg7GK 02Zfusksp+YBefdTTUr2NvyNujUjA6GQqHWFELvoiQ3yJNlH50wkMEzIgUn2sG9pg6V55Yjt 60RZhAhfVLVIsbfKh9DOAOTY++DXHMWwvFNCaILVHuBMg8SgHwQl7MkcUIDc2RCe01JcEJ6e v8uXtjxBAPR34= X-IronPort-AV: E=Sophos;i="5.96,317,1665460800"; d="scan'208";a="92218242" From: Anthony PERARD To: CC: Jan Beulich , Andrew Cooper , Anthony PERARD Subject: [RFC PATCH] build: include/compat: figure out which other compat headers are needed Date: Wed, 11 Jan 2023 18:17:03 +0000 Message-ID: <20230111181703.30991-1-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Some compat headers depends on other compat headers that may not have been generated due to config option. This would be a generic way to deal with deps, instead of headers-$(call or $(CONFIG_TRACEBUFFER),$(CONFIG_HVM)) += compat/trace.h This is just an RFC, as it only deals with "hvm_op.h" and nothing is done to have make regenerate the new file when needed. Signed-off-by: Anthony PERARD --- xen/include/Makefile | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/xen/include/Makefile b/xen/include/Makefile index 65be310eca..5e6de97841 100644 --- a/xen/include/Makefile +++ b/xen/include/Makefile @@ -34,6 +34,29 @@ headers-$(CONFIG_TRACEBUFFER) += compat/trace.h headers-$(CONFIG_XENOPROF) += compat/xenoprof.h headers-$(CONFIG_XSM_FLASK) += compat/xsm/flask_op.h +# Find dependencies of compat headers. +# e.g. hvm/hvm_op.h needs trace.h; but if CONFIG_TRACEBUFFER=n, then trace.h would be missing. +# +# Using sed to remove ".." from path because unsure if something else is available +# There's `realpath`, but maynot be available +# realpath --relative-to=. -mL compat/hvm/../trace.h -> compat/trace.h +# `make` also have macro for that $(abspath), only recent version. +# +# The $(CC) line to gen deps is derived from $(cmd_compat_i) +include $(obj)/.compat-header-deps.d +$(obj)/.compat-header-deps.d: include/public/hvm/hvm_op.h + $(CC) -MM -MF $@.tmp $(filter-out -Wa$(comma)% -include %/include/xen/config.h,$(XEN_CFLAGS)) $< + for f in $$(cat $@.tmp | sed -r '1s/^[^:]*: //; s/ \\$$//'); do \ + echo $$f; \ + done | sed -r \ + -e 's#.*/public#compat#; : p; s#/[^/]+/../#/#; t p; s#$$# \\#' \ + -e '1i headers-y-deps := \\' -e '$$a \ ' \ + > $@ + +headers-y-deps := $(filter-out compat/xen-compat.h,$(headers-y-deps)) +# Add compat header dependencies and eliminates duplicates +headers-y := $(sort $(headers-y) $(headers-y-deps)) + cppflags-y := -include public/xen-compat.h -DXEN_GENERATING_COMPAT_HEADERS cppflags-$(CONFIG_X86) += -m32 -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Wed Jan 11 20:55:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 20:55:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475702.737490 (Exim 4.92) (envelope-from ) id 1pFi85-0003OJ-My; Wed, 11 Jan 2023 20:55:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475702.737490; Wed, 11 Jan 2023 20:55:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFi85-0003OC-KQ; Wed, 11 Jan 2023 20:55:25 +0000 Received: by outflank-mailman (input) for mailman id 475702; Wed, 11 Jan 2023 20:55:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFi84-0003O2-QR; Wed, 11 Jan 2023 20:55:24 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFi84-0002ji-Oh; Wed, 11 Jan 2023 20:55:24 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFi84-0003ar-6B; Wed, 11 Jan 2023 20:55:24 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pFi84-0006ZD-5h; Wed, 11 Jan 2023 20:55:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=nJXva4DLyo0mJGHODWvDTKdBwuYfbzqXPKZjNPCzliw=; b=beLKrZLYHFNosBR0fiaM+d82EG CceGwcf8HH8dTY9cVqRKytm2UhcqTvKmHtjPwtQVxpiTO6d2KebOij+awGywOP1dNqhzaTPxCV50L tP5YQJ902h2jAbXoYnLgag628tXNtWaWsP0Oa6X5I3OoSEjCZo2F0eQJJ9HIQLs9qqoI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 175728: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=fd42170b152b19ff12121f3b63674e882c087849 X-Osstest-Versions-That: xen=e66d450b6e0ffec635639df993ab43ce28b3383f From: osstest service owner Date: Wed, 11 Jan 2023 20:55:24 +0000 flight 175728 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/175728/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen fd42170b152b19ff12121f3b63674e882c087849 baseline version: xen e66d450b6e0ffec635639df993ab43ce28b3383f Last test of basis 175721 2023-01-11 10:03:26 Z 0 days Testing same since 175728 2023-01-11 18:00:27 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alistair Francis Andrew Cooper Julien Grall jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git e66d450b6e..fd42170b15 fd42170b152b19ff12121f3b63674e882c087849 -> smoke From xen-devel-bounces@lists.xenproject.org Wed Jan 11 21:05:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 21:05:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475710.737502 (Exim 4.92) (envelope-from ) id 1pFiI2-0004tf-MT; Wed, 11 Jan 2023 21:05:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475710.737502; Wed, 11 Jan 2023 21:05:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFiI2-0004tY-JP; Wed, 11 Jan 2023 21:05:42 +0000 Received: by outflank-mailman (input) for mailman id 475710; Wed, 11 Jan 2023 21:05:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFiI0-0004tR-Q2 for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 21:05:41 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b16e78ef-91f3-11ed-b8d0-410ff93cb8f0; Wed, 11 Jan 2023 22:05:37 +0100 (CET) Received: from mail-dm6nam04lp2046.outbound.protection.outlook.com (HELO NAM04-DM6-obe.outbound.protection.outlook.com) ([104.47.73.46]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 11 Jan 2023 16:05:15 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DS7PR03MB5477.namprd03.prod.outlook.com (2603:10b6:5:2c4::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Wed, 11 Jan 2023 21:05:13 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5986.018; Wed, 11 Jan 2023 21:05:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b16e78ef-91f3-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1673471137; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=HAvb2Mg1S0uuzH1onFjGMe88MbP+3GiSjiHHn55VMlw=; b=eN4l+iinxuUzBuamNQVbVsDEiqPnWpDUzFnRss4JR6OH4X5upnUBGprE 66R9TYcPATRdSF+QBgJZvnbsenm7qaJFjkDARP6g4DwAg2syPQ0lPRbRi CJX3XZea3lWQeEHCDmrgRe650WiJ4wuagqaHjsDF4nekJMXGEjJUjbk73 E=; X-IronPort-RemoteIP: 104.47.73.46 X-IronPort-MID: 92616230 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:pRP0A6LKfUcMfgJeFE+RKJQlxSXFcZb7ZxGr2PjKsXjdYENSgTIFy TEfUT+OPP7eZzDxft9/bdzg8R8FvcfUydMwSgFlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHv+kUrWs1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPdwP9TlK6q4mhA5wVnPaojUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5mD1ENy qEGMwlQMEvAvqWmw6+LZrlV05FLwMnDZOvzu1lG5BSBUbMKZM6GRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/VspTSNpOBy+OGF3N79U9qGX8hK2G2fo XrL5T/RCRAGLt2PjzGC9xpAg8eex32iBthJTNVU8NZb2QyexzceDCYVD1uRiOuGtRWQWO5Af hl8Fi0G6PJaGFaQZsnwWVi0rWCJujYYWsFMCKsq5QeV0K3W7g2FQG8eQVZpatYrqcs3TjwCz UKSkpXiAjkHmL+ITXOQ8J+EoDX0PjIaRUcZfjMNRwYB59jloakwgwjJQ9IlF7S65vXqHRngz jbMqzIx750RkMhN0ay49FLGhjuEp57VQwpz7QLSNkqm4x14Ysi5ZoWuwVnd8ftEao2eSzG8U GMsnsGf6KUCCM+LnSnVHOEVRun1ubCCLSHWhkNpE9857TOx9nW/fIdWpjZjOENuNcVCcjjsC KPOhT5sCFZoFCPCRcdKj0iZVKzGEYCI+QzZa83p IronPort-HdrOrdr: A9a23:8EEw46yxh1stJ6KsbVSJKrPxAugkLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9IYgBapTiBUJPwIk81bfZOkMUs1MSZLXPbUQyTXc5fBOrZsnDd8kjFmtK1up 0QFJSWZOeQMbE+t7eD3ODaKadv/DDkytHPuQ629R4EIm9XguNbnn5E422gYy9LrXx9dP4E/e 2nl696TlSbGUg/X4CePD0oTuLDr9rEmNbPZgMHPQcu7E2jnC6l87nzFjmfx1M7XylUybkv3G DZm0ihj5/T882T+1v57Sv+/p5WkNzuxp9qA9GNsNEcLnHBmxulf4NoXpyFpXQQrPu04Fgnvd HQq1MLPth16VnWYmapyCGdmjXI4XIL0TvP2FWYiXzsrYjSXzQhEfdMgopfb1/w91cglMsU6t MI40up875sST/QliX04NbFEztwkFCvnHYkmekPy1RCTIolbqNLp4B3xjIRLH5AJlO/1GkUKp gpMCju3ocOTbpcVQGAgoBb+q3qYp30JGbcfqFNgL3O79EcpgEF86JR/r1iop5HzuN/d3AM3Z W7Dkwj/os+MfM+fOZzAvwMTtCwDXGISRXQMHiKKVCiD60fPWnRwqSHqIndS9vaCqDg4aFC7q gpamko/FIaagbrE4mDzZdL+hfCTCG0Wins0NhX49x8tqfnTLTmPCWfQBR2+vHQ6ck3E4neQb K+KZhWC/jsIS/nHptIxRT3X91XJWMFWMMYt94nUxaFo97NKIftquvHGcyjb4bFAHIhQCfyE3 EDVD/8KIFJ6V2qQGbxhFzLV3bkaiXEjOVN+WjhjpwuIaQ2R/5xW1Iu+CWED+mwWE1/m71zel diK7X6la7+rXWq/A/znhBUBiY= X-IronPort-AV: E=Sophos;i="5.96,317,1665460800"; d="scan'208";a="92616230" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FKTT/sluGpc0hw0VdTyxzbS8NC0aVlYy8NO1NnfTAUn8UMQHh59MiSGRsHGqTesHZa5uJN93HFURMLiZrlAcPHoIiN0ngTN/obGMISM+eyNnLEMgkeSewFwMKLfPCtRwGTei3b+htU0cuS5ZAPrTjB2+lbF0aeWdxOXAAEPU9CVYzENLflersyIpwvJMoRkCKByQId8I6xmNtC/p/mdyZ6fvQtAlo5yTjkeYLOKR7ak6VaMjuIfHTYRU8p/0CL140WFxU0SVGtXi/puyOOgmvVG7PnLBSzqjhvLQOhlAvYcUSlNGm9en1XbBAJOCgq8359TyXPiur9SCy8ZWL2c5Ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HAvb2Mg1S0uuzH1onFjGMe88MbP+3GiSjiHHn55VMlw=; b=C3QcbFnDP7NRP1TmWbFtPUcieeXF+o59O/KxfJhHF1nrlNhmaj7eQwln8AURsJ5y8af399MK2Y0ALLg9fJ/fhn62zNPBgp5VoqO18UZRag8uuR86XBGjvLg0qy/4XNyvqC9//XeyGihzlHVGpNYYVWqXR9m1ZH9SDpOwSgf/QlJWyqCXJ3+qSOI+thx02QrqVbi0J73R9n0qoUrroxhmGdqdnGAdveOVswba4jNeVN+ItcylDylKUPb0qOuJ2dHi6fzyzuB7zTDWketAO9Y6s0GtDcviPm/vD6CGTx1LvxX+amhXXq7aS3zjahCPm5W6VQZn4zNcw0dKydXgbPqS3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HAvb2Mg1S0uuzH1onFjGMe88MbP+3GiSjiHHn55VMlw=; b=hQIoaWbSIwzd+cnLZ6CgNa2Hh3Gy6n81GaFu7s2OnkNRs+P0uysFZTPzwCG2ocz+Aqs4GegBS4+ugsOihY2/bwNgKmUTkldfjZfJmISeWFj2grS+1uwea5U+eHyExWufqDfiyFmcpL65P244oPYVd1brcP+MYkyIg7bz27U7Ny0= From: Andrew Cooper To: Roger Pau Monne , "xen-devel@lists.xenproject.org" CC: George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Jun Nakajima , Kevin Tian Subject: Re: [PATCH v4 3/3] x86/vmx: implement Notify VM Exit Thread-Topic: [PATCH v4 3/3] x86/vmx: implement Notify VM Exit Thread-Index: AQHZDxB+OJsGEBOWPkStgY7+/Eiq966Z4qgA Date: Wed, 11 Jan 2023 21:05:12 +0000 Message-ID: <553cbd97-f667-1549-4374-9385d3d53710@citrix.com> References: <20221213163104.19066-1-roger.pau@citrix.com> <20221213163104.19066-4-roger.pau@citrix.com> In-Reply-To: <20221213163104.19066-4-roger.pau@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|DS7PR03MB5477:EE_ x-ms-office365-filtering-correlation-id: b032f9af-70fd-4ea8-e5cd-08daf41787f1 x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: aVLU/RA1iQaUX2Nu4UcxgwLOA2teLb6SwagstNjBlVNXQTDRpyAtgAIPkX2FCR1YeSyLBuniUd4a7s/SH+l6hDJz1abEDb8Zq/irA++A+xsUopEFiSxfuv8vQ1pOyMdN5MFhBcvz6JS03wuo8WVr34CtOChr0bWI8wdemHHhoUPJdUZqtFho9UUF2twGcj+BSrtsGTi3uMLW2SdEIuVQ7Lk+QPC8DoDfjIZjYlGLQZWDQTh48VBY2s9lYhXxY04XvNjZ3Ubh9Pq/pXM+F6+AnPY73zBbPGOTRyzkhQGrGuotaRW84zjfgTpPHd/tv/u5W5Fr4LKafj6cSmEKVhZ1u5jHXBIih8one71rlelD2qDUCHRfHQwICU89KGOpBbLVU6xK57B1jW/tp/l+Aaj7sgSLj/Cg/s1lfkdbYk84WWGL1ZSo+Uxd21ceQwOI4idtu5WnJ9W6FoyeaONdsew+HSMLVJftdt45jDbBQiQJGReq9YSvWYYRWNg+b+tvY5yLd08jlp05Xvw3AzRNvz/iJ6kAEu7+9BMNKZhTb/wVef5dFLD2sw3DVi6Iwk+Ydl2xdp1Qly1AichUiZ7nidGFR5RLCrUU5dH/6SDZAj7qraNPaCUCJ2xJPy+FfvR+vBT4i+T252x7ypsKhwqL1XMZgzAV84Sl2eyppYCvXuMdEqQ0SaZ9smBCgU6hogwm3+b6n/l/FDuQTd/NWKvSoHlCbl5w5Wejuj9HuYbIBluG6fZ58+qb0s7n44gL1mzlGc5iN5VgWhDlu2Sfp+Tz3ILn2g== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(366004)(136003)(39860400002)(376002)(451199015)(8936002)(26005)(2906002)(5660300002)(71200400001)(41300700001)(66446008)(66556008)(4326008)(91956017)(316002)(8676002)(76116006)(64756008)(66476007)(66946007)(110136005)(54906003)(38070700005)(6512007)(122000001)(2616005)(38100700002)(86362001)(31686004)(186003)(31696002)(53546011)(83380400001)(36756003)(508600001)(82960400001)(6506007)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?OXBrSnNvLzFDenFTTEVhbGxFd0M5ZEJ4OCthbjFsTVdrYnpaM2h3R3NaN1ky?= =?utf-8?B?K2VUcThiRmN0NVhsYytOSW9jYWZYQ1R1Vkp6RVJ0RG5Sbm83YUNQb3NIN0NW?= =?utf-8?B?MzZsdzVNdmx1dncwREQ4bjdURGhSWm1yakJOSFExd3lwT0tsL3ozOWdVazNu?= =?utf-8?B?OTdNblRCd1RhSXRXdVpsNC9SWTROK3BiMW5YS3dKZ051bStvL2FvNjQ1ZVJ0?= =?utf-8?B?TmF1T0dvMFc0VGV4eWNVSlVwb28zcmpwM0s0VjIyWjltaW9JUENML3BkZlg3?= =?utf-8?B?TjJRNEwxMXQ2QlI5cmtReFRpTGZKY1NaOFlnNXlONGRGVGY4d3kxd1ZDWGJT?= =?utf-8?B?dlB1YW5xdVp5YWRCaEdUZVpEK1E5WW9QMWt4aHRhb01LREhrdVBETHhWbTZC?= =?utf-8?B?MjNUTDNiYW5yMDZHUXZlZ0RETmkvMkpRLy9CQWdTNnNkV2cvSjE1bGtVSTFL?= =?utf-8?B?MmJpMHE3NXRvajIrWmV5MEVWdzFWaTB5MmQwNjRNRWViV3hlUWE3d3NvdHND?= =?utf-8?B?Mms0cGMrYjRMaDQvVXVPVTMreDZOcHlPZ3BiczRJdEdlN3RiUnJJNEFVQ0pk?= =?utf-8?B?aFozd2NscHNhSFlQSlQwVyt6T3oyZWMrOVlZbGwrdTgwSDBEMGNkdW1TWGhF?= =?utf-8?B?SWNxSlNJQktYV2VNTkhYVlQxQVVGN3BteWFrLzIvWVYxNU1xck5qNmdIYm9Y?= =?utf-8?B?TjNmYzF6TDBVNXpMTko3MmdJQ1FJTGxJTmJzRXVwckIzSWdHMmlNQ01NY2dv?= =?utf-8?B?Nmd2b1QwWWdHaTAvWmdiakRXaTFNRU5YdVNJUzdHbXc0MFk0enRBTkFnL3Vx?= =?utf-8?B?TXNhNEYyQU5raDgrM2NDMmJtaFhvVE92ZXFxYVZwSFZpeC96djdhVDFSQlRl?= =?utf-8?B?VUUzMFZSZXI4WTZWZEVSalByWXNYcGVnZ2dnMHhYR3dQU1hEcjNJREtmV0Vl?= =?utf-8?B?QkFVdFcyQ2MveEVhYlBzVUZkQ3hjWVAxTzRLc2ZyNzlMNllQSGpDd055b2pE?= =?utf-8?B?Q1Z6ZEF1YmpSNTU2ZUpMWVVEbDIwaUthUk1QNzdYKzgzb2ZpS2lsbExFbkUx?= =?utf-8?B?VkMxOENYeUFpWUxiMXN5ZjFIdzIyUFlvUGI2djVMTmltallSK2Q0cnJCSm1G?= =?utf-8?B?aHVXVVlPei94NmdXYnlMUmp2WlNHYXJ5bFFjcWw5ekZEU0ZPVTlpeFJxM3pV?= =?utf-8?B?aEtaSGpkdHRJQW1KWnJDK3VOMmFHTG9FcGF6RC9sTDVBYzlKR2ZhVmE4UE9u?= =?utf-8?B?eTZEOXJEUVFkdjhrd2pESWFFM2NyY3l5T1JmY3Y2OEhwR00wdFpUUGpycXFG?= =?utf-8?B?YTdWTlZTSzNTejhORGZKYTVxNzJ1c1J3STdTaCtmeG9FUzBOZnpMdkVSem9t?= =?utf-8?B?TFV2d1FVSDhTMXNGSC9QVTlsWGpSV2R5cXZqSFFDSEIyZ2h0SklpR3djSGUw?= =?utf-8?B?T0lYVG9YV3lLYXhGMVlYQ1B4OGw2M2xuQUw0V0xpRnRDNUtZLzFSY2l6dUVp?= =?utf-8?B?ei9JbXlUTE5KVU1MQmNKcmxSd05kek1ZTGxmcS9pZU5ad1VoZ3ExUFBEbzNO?= =?utf-8?B?SXhyM1FwbDF2Q0VnZHJOSWI2S3pMQ21WaFNNUzlkQ3VyVTAxaGFKdk9JNEhC?= =?utf-8?B?SlpRT3J2dVFvSkVwRGxTS25neWlJQU8zT1NZUElRekcyNkZoRlhKQ0FtY0Np?= =?utf-8?B?TGtCaTFYKzBXTlh6ejlLNU9hNTFSZEE2My9yZFpWeU82b3NjY2l1UDBTTVdt?= =?utf-8?B?c21EWklTc2tVVmdiTlIxWSt3MkVPK1NXL0t0d3U3RnhIejgrYW1NNmEwcXBX?= =?utf-8?B?WTJGT3k5a3kzNVExZ2dXOHhQRndaTTNaMmoxUnFXajMvNHR2QXlZLzZtT2Js?= =?utf-8?B?RUdxaXhudURMaWtwK3gxTVU1Zkw5OHZndEY3dmZaamxhdTZLaGZ5bVpOWWIz?= =?utf-8?B?eFAwcTJzRFVscDAwdUZ2U3ZjM1V1NEY0NlgwVXhFbmJ4UFNIYkp6aEN0ZTZQ?= =?utf-8?B?dExTaE5Fb3JWOC93WDFjVjEvK0IrdVhPd2pwSDgvS21SMkJPTEJMaDl1aG1h?= =?utf-8?B?NThMNmFZSmk2OXlIT0Yvd2VnVkcvVUsvRnYwampqZThYT1pIYmRSVmZxOUdN?= =?utf-8?Q?/xlTf7AXiHPfFZ5HCizSzFiPK?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: p+BhTnAM7Xns3USDFDjN8DVK1xT1QFgajx3fY6eyVy/5A7Mdzt2Z+euG1leTkfJyk7A2KcXxVj0KIyD4Qe0IvG+RcQJR5OmLuyJpDRS7mYC4Wqf9qiVNgNXSFNLBJ4vP1nOi4kmubJ9dKx2s/dpeUJyx6UCyzz2O3o32df48wiaqs+FmO8lBYkQIxo9Zdi4Au+ipmj+4UMIq8g41mpOlyI6aepo83P3i5N8HXqpVC7OXxASP6PtqCiX9WQl4fMMZPYv/m9lGPs08iBXDZaJ/8Bpc3LgAcH/Xgfaf9ynVRuvdPjrJveUqOFeGtYGr6kTz6MsiMf7ltv+8QIk9sV/wuxL+y9fcRJOnUXDQMqud2tBSFgeI7MiP+nkA1cvPzGMtfLHvl3tYFAcsdJnEUAP1syd6FC05fQS4G+rdyBeTnHZNFZrzKowVpoWff4MMxlNcDCD3T+PyOaWwfiTmi+nOixLdZ2JFwG89db7N5xpoGSjPJmt6Vom40itWV7EGNLeqs9f6EizO51wTcRdFJowXZYZrEoGVuQgZuAo7pYDSYlXDTUkyCDK8DFqKsJMoXVpYCxOTSb8X7mjghiBMRRIDTwt8894DJaEDyekQLWVgcp4BXigD3xu2yhI3swaMFWGM7Jd79pFjarPNF+tDqACT+JHz2YRCkiv51ylYJsafSYi8wdNhtGOWfDOUwrILp3S/VucfJszf+1V7owZVVgXOmhUmTORSV+ZK0oIZSfXc3NHxqqBNnKplGbbqMorsGz0Kupcbd81nI1gRSbqacVeOPfnAZoROx4jijU/ANeq9gNVlurN6WcNSDA5NYxCfRLYpnLiq7+EUmNZbqtc8/AyEuqM0Mdtgl5MdBoL55nDhmELhlreknlxL8Po8J1AUGqlV X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b032f9af-70fd-4ea8-e5cd-08daf41787f1 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jan 2023 21:05:12.8236 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SWnl7+gqiOcOo1DiD/1APtZak1TLCD3UwsIb3jlZ8HJzFJskw89zynpz1ECeK2BRHLiCZ5LKLyZkOWFGwG/Sn8JIWFxRcABCgTOu1OBhZ+s= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5477 T24gMTMvMTIvMjAyMiA0OjMxIHBtLCBSb2dlciBQYXUgTW9ubmUgd3JvdGU6DQo+IGRpZmYgLS1n aXQgYS94ZW4vYXJjaC94ODYvaHZtL3ZteC92bWNzLmMgYi94ZW4vYXJjaC94ODYvaHZtL3ZteC92 bWNzLmMNCj4gaW5kZXggYTBkNWU4ZDZhYi4uM2Q3YzQ3MWEzZiAxMDA2NDQNCj4gLS0tIGEveGVu L2FyY2gveDg2L2h2bS92bXgvdm1jcy5jDQo+ICsrKyBiL3hlbi9hcmNoL3g4Ni9odm0vdm14L3Zt Y3MuYw0KPiBAQCAtMTI5MCw2ICsxMjk2LDE3IEBAIHN0YXRpYyBpbnQgY29uc3RydWN0X3ZtY3Mo c3RydWN0IHZjcHUgKnYpDQo+ICAgICAgdi0+YXJjaC5odm0udm14LmV4Y2VwdGlvbl9iaXRtYXAg PSBIVk1fVFJBUF9NQVNLDQo+ICAgICAgICAgICAgICAgIHwgKHBhZ2luZ19tb2RlX2hhcChkKSA/ IDAgOiAoMVUgPDwgVFJBUF9wYWdlX2ZhdWx0KSkNCj4gICAgICAgICAgICAgICAgfCAodi0+YXJj aC5mdWxseV9lYWdlcl9mcHUgPyAwIDogKDFVIDw8IFRSQVBfbm9fZGV2aWNlKSk7DQo+ICsgICAg aWYgKCBjcHVfaGFzX3ZteF9ub3RpZnlfdm1fZXhpdGluZyApDQo+ICsgICAgew0KPiArICAgICAg ICBfX3Ztd3JpdGUoTk9USUZZX1dJTkRPVywgdm1fbm90aWZ5X3dpbmRvdyk7DQo+ICsgICAgICAg IC8qDQo+ICsgICAgICAgICAqIERpc2FibGUgI0FDIGFuZCAjREIgaW50ZXJjZXB0aW9uOiBieSB1 c2luZyBWTSBOb3RpZnkgWGVuIGlzDQo+ICsgICAgICAgICAqIGd1YXJhbnRlZWQgdG8gZ2V0IGEg Vk0gZXhpdCBldmVuIGlmIHRoZSBndWVzdCBtYW5hZ2VzIHRvIGxvY2sgdGhlDQo+ICsgICAgICAg ICAqIENQVS4NCj4gKyAgICAgICAgICovDQo+ICsgICAgICAgIHYtPmFyY2guaHZtLnZteC5leGNl cHRpb25fYml0bWFwICY9IH4oKDFVIDw8IFRSQVBfZGVidWcpIHwNCj4gKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoMVUgPDwgVFJBUF9hbGlnbm1lbnRfY2hl Y2spKTsNCj4gKyAgICB9DQo+ICAgICAgdm14X3VwZGF0ZV9leGNlcHRpb25fYml0bWFwKHYpOw0K PiAgDQo+ICAgICAgdi0+YXJjaC5odm0uZ3Vlc3RfY3JbMF0gPSBYODZfQ1IwX1BFIHwgWDg2X0NS MF9FVDsNCj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9odm0vdm14L3ZteC5jIGIveGVuL2Fy Y2gveDg2L2h2bS92bXgvdm14LmMNCj4gaW5kZXggZGFiZjRhMzU1Mi4uYjExNTc4Nzc3YSAxMDA2 NDQNCj4gLS0tIGEveGVuL2FyY2gveDg2L2h2bS92bXgvdm14LmMNCj4gKysrIGIveGVuL2FyY2gv eDg2L2h2bS92bXgvdm14LmMNCj4gQEAgLTE0MjgsMTAgKzE0MjgsMTkgQEAgc3RhdGljIHZvaWQg Y2ZfY2hlY2sgdm14X3VwZGF0ZV9ob3N0X2NyMyhzdHJ1Y3QgdmNwdSAqdikNCj4gIA0KPiAgdm9p ZCB2bXhfdXBkYXRlX2RlYnVnX3N0YXRlKHN0cnVjdCB2Y3B1ICp2KQ0KPiAgew0KPiArICAgIHVu c2lnbmVkIGludCBtYXNrID0gMXUgPDwgVFJBUF9pbnQzOw0KPiArDQo+ICsgICAgaWYgKCAhY3B1 X2hhc19tb25pdG9yX3RyYXBfZmxhZyAmJiBjcHVfaGFzX3ZteF9ub3RpZnlfdm1fZXhpdGluZyAp DQo+ICsgICAgICAgIC8qDQo+ICsgICAgICAgICAqIE9ubHkgYWxsb3cgdG9nZ2xpbmcgVFJBUF9k ZWJ1ZyBpZiBub3RpZnkgVk0gZXhpdCBpcyBlbmFibGVkLCBhcw0KPiArICAgICAgICAgKiB1bmNv bmRpdGlvbmFsbHkgc2V0dGluZyBUUkFQX2RlYnVnIGlzIHBhcnQgb2YgdGhlIFhTQS0xNTYgZml4 Lg0KPiArICAgICAgICAgKi8NCj4gKyAgICAgICAgbWFzayB8PSAxdSA8PCBUUkFQX2RlYnVnOw0K PiArDQo+ICAgICAgaWYgKCB2LT5hcmNoLmh2bS5kZWJ1Z19zdGF0ZV9sYXRjaCApDQo+IC0gICAg ICAgIHYtPmFyY2guaHZtLnZteC5leGNlcHRpb25fYml0bWFwIHw9IDFVIDw8IFRSQVBfaW50MzsN Cj4gKyAgICAgICAgdi0+YXJjaC5odm0udm14LmV4Y2VwdGlvbl9iaXRtYXAgfD0gbWFzazsNCj4g ICAgICBlbHNlDQo+IC0gICAgICAgIHYtPmFyY2guaHZtLnZteC5leGNlcHRpb25fYml0bWFwICY9 IH4oMVUgPDwgVFJBUF9pbnQzKTsNCj4gKyAgICAgICAgdi0+YXJjaC5odm0udm14LmV4Y2VwdGlv bl9iaXRtYXAgJj0gfm1hc2s7DQo+ICANCj4gICAgICB2bXhfdm1jc19lbnRlcih2KTsNCj4gICAg ICB2bXhfdXBkYXRlX2V4Y2VwdGlvbl9iaXRtYXAodik7DQo+IEBAIC00MTgwLDYgKzQxODksOSBA QCB2b2lkIHZteF92bWV4aXRfaGFuZGxlcihzdHJ1Y3QgY3B1X3VzZXJfcmVncyAqcmVncykNCj4g ICAgICAgICAgc3dpdGNoICggdmVjdG9yICkNCj4gICAgICAgICAgew0KPiAgICAgICAgICBjYXNl IFRSQVBfZGVidWc6DQo+ICsgICAgICAgICAgICBpZiAoIGNwdV9oYXNfbW9uaXRvcl90cmFwX2Zs YWcgJiYgY3B1X2hhc192bXhfbm90aWZ5X3ZtX2V4aXRpbmcgKQ0KPiArICAgICAgICAgICAgICAg IGdvdG8gZXhpdF9hbmRfY3Jhc2g7DQoNClRoaXMgYnJlYWtzIEdEQlNYIGFuZCBpbnRyb3NwZWN0 aW9uLg0KDQpGb3IgWFNBLTE1Niwgd2Ugd2VyZSBmb3JjZWQgdG8gaW50ZXJjZXB0ICNEQiB1bmls YXRlcmFsbHkgZm9yIHNhZmV0eSwNCmJ1dCBib3RoIEdEQlNYIGFuZCBJbnRyb3NwZWN0aW9uIGNh biBvcHRpb25hbGx5IGludGVyY2VwdGluZyAjREIgZm9yDQpsb2dpY2FsIHJlYXNvbnMgdG9vLg0K DQppLmUuIHdlIGNhbiBsZWdpdGltYXRlbHkgZW5kIHVwIGhlcmUgZXZlbiBvbiBhbiBzeXN0ZW0g d2l0aCBWTSBOb3RpZnkuDQoNCg0KV2hhdCBJIGNhbid0IGZpZ3VyZSBvdXQgaXMgd2h5IG1hZGUg YW55IHJlZmVyZW5jZSB0byBNVEYuwqAgTVRGIGhhcw0KYWJzb2x1dGVseSBub3RoaW5nIHRvIGRv IHdpdGggVFJBUF9kZWJ1Zy4NCg0KRnVydGhlcm1vcmUsIHRoZXJlJ3Mgbm8gQ1BVIGluIHByYWN0 aWNlIHRoYXQgaGFzIFZNIE5vdGlmeSBidXQgbGFja3MNCk1URiwgc28gdGhlIGhlYWQgb2Ygdm14 X3VwZGF0ZV9kZWJ1Z19zdGF0ZSgpIGxvb2tzIGxpa2UgZGVhZCBjb2RlLi4uDQoNCn5BbmRyZXcN Cg== From xen-devel-bounces@lists.xenproject.org Wed Jan 11 21:14:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 21:14:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475716.737513 (Exim 4.92) (envelope-from ) id 1pFiQf-0006MI-JP; Wed, 11 Jan 2023 21:14:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475716.737513; Wed, 11 Jan 2023 21:14:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFiQf-0006MB-F6; Wed, 11 Jan 2023 21:14:37 +0000 Received: by outflank-mailman (input) for mailman id 475716; Wed, 11 Jan 2023 21:14:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFiQe-0006M1-7j; Wed, 11 Jan 2023 21:14:36 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFiQe-00033c-5H; Wed, 11 Jan 2023 21:14:36 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFiQd-0004Yo-LA; Wed, 11 Jan 2023 21:14:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pFiQd-00045U-Kf; Wed, 11 Jan 2023 21:14:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Z2VlB9Fz/SR1Do5HCRA5Rs/CD9PPYRNDZjFCwBBELok=; b=Fo7rmtG0ginM7yQQYlAPdxhea3 tvfwLn+FW1M0QdAYQauQm+DOOfcUc8gyyMq3JmHBIUVgoIk90VYQaeWzqVzBoeK0TANJiWN0h9TBW sOVi5NoHe06KLsMdukaizqcclg0aI5C2ecsm+m5e3hUh+q7wLlLQsWkSoK/YLgExAV0c=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 175727: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-amd64-xsm:xen-build:fail:regression qemu-mainline:build-amd64:xen-build:fail:regression qemu-mainline:build-i386:xen-build:fail:regression qemu-mainline:build-arm64-xsm:xen-build:fail:regression qemu-mainline:build-i386-xsm:xen-build:fail:regression qemu-mainline:build-arm64:xen-build:fail:regression qemu-mainline:build-armhf:xen-build:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-coresched-amd64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:build-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-rtds:build-check(1):blocked:nonblocking qemu-mainline:build-arm64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking qemu-mainline:build-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking qemu-mainline:build-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-dom0pvh-xl-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-dom0pvh-xl-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvshim:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-pygrub:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvhv2-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-freebsd11-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-freebsd12-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvhv2-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-multivcpu:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: qemuu=aa96ab7c9df59c615ca82b49c9062819e0a1c287 X-Osstest-Versions-That: qemuu=0ab12aa32462817f0a53fa6f6ce4baf664ef1713 From: osstest service owner Date: Wed, 11 Jan 2023 21:14:35 +0000 flight 175727 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/175727/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 175623 build-amd64 6 xen-build fail REGR. vs. 175623 build-i386 6 xen-build fail REGR. vs. 175623 build-arm64-xsm 6 xen-build fail REGR. vs. 175623 build-i386-xsm 6 xen-build fail REGR. vs. 175623 build-arm64 6 xen-build fail REGR. vs. 175623 build-armhf 6 xen-build fail REGR. vs. 175623 Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-win7-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ws16-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-shadow 1 build-check(1) blocked n/a test-amd64-i386-xl-vhd 1 build-check(1) blocked n/a test-amd64-i386-xl-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) blocked n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) blocked n/a test-armhf-armhf-xl-rtds 1 build-check(1) blocked n/a test-armhf-armhf-xl-vhd 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-amd 1 build-check(1) blocked n/a test-amd64-i386-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-i386 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-amd64 1 build-check(1) blocked n/a test-amd64-coresched-i386-xl 1 build-check(1) blocked n/a test-amd64-coresched-amd64-xl 1 build-check(1) blocked n/a test-amd64-amd64-xl-xsm 1 build-check(1) blocked n/a build-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-shadow 1 build-check(1) blocked n/a test-amd64-amd64-xl-rtds 1 build-check(1) blocked n/a build-arm64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ws16-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a build-armhf-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-amd64-dom0pvh-xl-amd 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 1 build-check(1) blocked n/a test-amd64-amd64-dom0pvh-xl-intel 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvshim 1 build-check(1) blocked n/a test-amd64-amd64-pair 1 build-check(1) blocked n/a test-amd64-amd64-pygrub 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvhv2-intel 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-freebsd11-amd64 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-freebsd12-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvhv2-amd 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-nested-amd 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-nested-intel 1 build-check(1) blocked n/a test-amd64-amd64-xl-multivcpu 1 build-check(1) blocked n/a test-amd64-amd64-xl 1 build-check(1) blocked n/a test-amd64-amd64-xl-credit1 1 build-check(1) blocked n/a test-amd64-amd64-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 1 build-check(1) blocked n/a test-armhf-armhf-xl-arndale 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-intel 1 build-check(1) blocked n/a test-amd64-i386-xl 1 build-check(1) blocked n/a test-amd64-i386-xl-pvshim 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a version targeted for testing: qemuu aa96ab7c9df59c615ca82b49c9062819e0a1c287 baseline version: qemuu 0ab12aa32462817f0a53fa6f6ce4baf664ef1713 Last test of basis 175623 2023-01-07 23:09:00 Z 3 days Failing since 175627 2023-01-08 14:40:14 Z 3 days 17 attempts Testing same since 175654 2023-01-09 18:08:58 Z 2 days 12 attempts ------------------------------------------------------------ People who touched revisions under test: Ard Biesheuvel Bernhard Beschow Christian Borntraeger Cindy Lu Dongli Zhang Eugenio Pérez Greg Kurz Guoyi Tu Hyman Huang(黄勇) Igor Mammedov Jason Wang Jonathan Cameron Kai Huang Laszlo Ersek Lei Xiang leixiang Liuxiangdong Longpeng Lubomir Rintel Marc-André Lureau Markus Armbruster Michael S. Tsirkin Nikita Ivanov Paolo Bonzini Peter Maydell Philippe Mathieu-Daudé Richard Henderson Thomas Huth Yanan Wang Yicong Yang Zeng Chi jobs: build-amd64-xsm fail build-arm64-xsm fail build-i386-xsm fail build-amd64 fail build-arm64 fail build-armhf fail build-i386 fail build-amd64-libvirt blocked build-arm64-libvirt blocked build-armhf-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl blocked test-amd64-coresched-amd64-xl blocked test-arm64-arm64-xl blocked test-armhf-armhf-xl blocked test-amd64-i386-xl blocked test-amd64-coresched-i386-xl blocked test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm blocked test-amd64-i386-xl-qemuu-debianhvm-i386-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm blocked test-arm64-arm64-xl-xsm blocked test-amd64-i386-xl-xsm blocked test-amd64-amd64-qemuu-nested-amd blocked test-amd64-amd64-xl-pvhv2-amd blocked test-amd64-i386-qemuu-rhel6hvm-amd blocked test-amd64-amd64-dom0pvh-xl-amd blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64 blocked test-amd64-i386-xl-qemuu-debianhvm-amd64 blocked test-amd64-i386-freebsd10-amd64 blocked test-amd64-amd64-qemuu-freebsd11-amd64 blocked test-amd64-amd64-qemuu-freebsd12-amd64 blocked test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked test-amd64-amd64-xl-qemuu-win7-amd64 blocked test-amd64-i386-xl-qemuu-win7-amd64 blocked test-amd64-amd64-xl-qemuu-ws16-amd64 blocked test-amd64-i386-xl-qemuu-ws16-amd64 blocked test-armhf-armhf-xl-arndale blocked test-amd64-amd64-xl-credit1 blocked test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 blocked test-amd64-amd64-xl-credit2 blocked test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 blocked test-armhf-armhf-xl-cubietruck blocked test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict blocked test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict blocked test-amd64-i386-freebsd10-i386 blocked test-amd64-amd64-qemuu-nested-intel blocked test-amd64-amd64-xl-pvhv2-intel blocked test-amd64-i386-qemuu-rhel6hvm-intel blocked test-amd64-amd64-dom0pvh-xl-intel blocked test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu blocked test-armhf-armhf-xl-multivcpu blocked test-amd64-amd64-pair blocked test-amd64-i386-pair blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim blocked test-amd64-i386-xl-pvshim blocked test-amd64-amd64-pygrub blocked test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds blocked test-armhf-armhf-xl-rtds blocked test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow blocked test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow blocked test-amd64-amd64-xl-shadow blocked test-amd64-i386-xl-shadow blocked test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd blocked test-amd64-i386-xl-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2556 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Jan 11 22:07:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 22:07:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475725.737524 (Exim 4.92) (envelope-from ) id 1pFjFS-0003EF-Hp; Wed, 11 Jan 2023 22:07:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475725.737524; Wed, 11 Jan 2023 22:07:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFjFS-0003E8-Eo; Wed, 11 Jan 2023 22:07:06 +0000 Received: by outflank-mailman (input) for mailman id 475725; Wed, 11 Jan 2023 22:07:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFjFQ-0003E2-Vj for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 22:07:05 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 45d25bd3-91fc-11ed-91b6-6bf2151ebd3b; Wed, 11 Jan 2023 23:07:02 +0100 (CET) Received: from mail-dm6nam12lp2177.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.177]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 11 Jan 2023 17:06:59 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by MW4PR03MB6555.namprd03.prod.outlook.com (2603:10b6:303:126::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.13; Wed, 11 Jan 2023 22:06:57 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5986.018; Wed, 11 Jan 2023 22:06:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 45d25bd3-91fc-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1673474822; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=3WC4I1sq6pRJvzk9BQhg0ICzYteAkwLRJ6tfwfxFB0A=; b=du3Xq4yTFreumlYt7IAR8V1bBoKwdmesB1SJDyqy4Ne+d/QHPdp2/2zF 6w5VtBcdz34TP0KclhoG4KyQtUkw5DQQ6NNJP8cJNa/2TuWeb3Q2ABEfV 3/rAYzflxY1f6gH7pegeA/mx5RqR5Qou/UGRpKqiHBGtddeaMCLXMxrFj A=; X-IronPort-RemoteIP: 104.47.59.177 X-IronPort-MID: 92247221 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:XRDpJKhxB9pCb10JH+qNxXm2X1611REKZh0ujC45NGQN5FlHY01je htvXmqEa6yJZWOjLdh0PYuwpkoAvsSEm9UyTlA6/Hg9ESob9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmUpH1QMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWs0N8klgZmP6sT5QaHzyJ94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQGLgIvbzyN2tuqg5CxG8ZrtJ4DMu/CadZ3VnFIlVk1DN4AaLWaGeDmwIEd2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilEgluGyb7I5efTTLSlRtm+eq njL4CLSBRYCOcbE4TGE7mitlqnEmiaTtIc6RefiqqEw2gT7Kmo7UzwyZVym/OGFjE+/e41ed 2ob6zUtov1nnKCsZpynN/Gim1aGtBMBX9tbE8Uh9RqAjKHT5m6xAmkCUy4Ea9E8ssIybSIl2 0XPnN7zAzFr9rqPRhq15ufKhTC/Iy4YKSkFfyBsZRcK58nLpIA1kw7VSdBiAOi5g7XdGz7qx CuRhDMjnLhVhskOv42h9F7OjjaEpZXTSAMxoALNUQqN/g5/IYKoeYGswVza9upbapaUSEGbu 3oJkNTY6/oBZbmVmTCAWvclHben/f+JPTTQx1l1EPEJ9TOk/XS5YI9N7St3IW9mN88FfXniZ 0q7hO9KzJpaPX/vYaopZYu0Up4u1fK5SoujUe3IZN1TZJQ3bBWA4CxleU+X2SbqjVQolqY8f 5ycdK5AEEonNEiu9xLuL8917FPh7nlWKb/7LXwj8yma7A== IronPort-HdrOrdr: A9a23:S9kQEqvz0wktzuBfuHU4OIwz7skDeNV00zEX/kB9WHVpm62j+/ xG+c5x6faaslkssR0b9+xoWpPhfZqsz/9ICOAqVN/JMTUO01HYT72Kg7GSpgHIKmnT8fNcyL clU4UWMqyVMbGit7eZ3DWF X-IronPort-AV: E=Sophos;i="5.96,318,1665460800"; d="scan'208";a="92247221" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LByou3vqt3nfqWjejpteOkuKVGQOb7bcu6qohg2xuy/kmckJcEDU+UPzsSenHyH01lUYkv5zcJEOVZovtsx4A2DZZEt6cTUgZd4qg9ieOmlIW+FUJd8dq8fpdT2MT6y4HR57EDF14KZUkvUsjrtLYi/VcpJMVNCY/+v+OH+CgoauD7zoKQDaKGh3gcbaM4Nkdk5ozE0z0puU4nyxenE9lVkF0LLQINY5tmoamMNHr0WepHM3Ja601nnTpdlbLRA+ksw2CVr9Cg/0fFe6oNHFtuVOFuL8+yZVyZbMt4TypkkrwfG3GMqCkHec9VGKniSZkrIVR2wwkbDQMELNTNFFow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3WC4I1sq6pRJvzk9BQhg0ICzYteAkwLRJ6tfwfxFB0A=; b=NDWpxgGd9ja2Tc3bkeki8cQ4TQ3ncGqxnoIRUF8dID4KNrnHFhkzBMo0iSdSd/Bqy7uorNTb/xZ7FNAU0VF2HOBJoxNmHkC2YRXWt5jQXR26TUb9RSULPfq3htgnfQE6vt5LA95PiUMpfHU+ofqb68/Lpws5EM1lWmlFgbXzdPSH54iZ/70c/V1Hvd21JqIkWoBeVdlC742IlF24cDF1GJDgBkHXcakicALCl30p2+hhrJ3IVKuF0se/qt1Tj//ZPnSlwm6ViTxWiXIt0KZ2mBWhlVw1ETLyjEGaeZK64DFdDzjrCAbhtJqlGeerEbv+rrgD+oH3GHOS7kbxLw1WFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3WC4I1sq6pRJvzk9BQhg0ICzYteAkwLRJ6tfwfxFB0A=; b=JE5gCUzYce+uFFP0xwEFi7rvp/F9RGhPjdj+Ug81GffsRQ2TSsO/BYNhWcRIUxu/HX2apnGzK4lzhv+JIu1Z6ZYXaxRbL2i4eEqAwMr4mvU+z3q5jYqHC5GQWXLsFNQZxq60b70q7/yMUm7z+4KXQcnPsBpFaVWxlNQkH38OVL0= From: Andrew Cooper To: Jan Beulich CC: "linux-kernel@vger.kernel.org" , "x86@kernel.org" , Thomas Gleixner , Juergen Gross , "Rafael J. Wysocki" , xen-devel , Roger Pau Monne , Peter Zijlstra , Joan Bruguera Subject: Re: Wake-up from suspend to RAM broken under `retbleed=stuff` Thread-Topic: Wake-up from suspend to RAM broken under `retbleed=stuff` Thread-Index: AQHZJa6+C7zgK+BmnkyxcC0/cTTk966ZF36AgAABmICAAK2VAA== Date: Wed, 11 Jan 2023 22:06:56 +0000 Message-ID: References: <20230108030748.158120-1-joanbrugueram@gmail.com> <20230109040531.7888-1-joanbrugueram@gmail.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|MW4PR03MB6555:EE_ x-ms-office365-filtering-correlation-id: 2a83e043-1f44-4f5d-1227-08daf42027c6 x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: EEnmCcgekWAKjbIUQU1PSMdoNxaVfi5td86HLQzVmWXn/rCsfU+3093Di6zA6lh+Bd8Lbudy3k7I2oyMqr2GlI4O7C/e/cVXrJ8pvu4ZXj8yYNYwLDJLJjED6xWox97Wmh+kq35015Z2lnVNrlU7sbBUFdUNHFyWEer8DDvjPU2e790bAiHAtBeDjX9fE5Wa9b0vvX4CyW65AvWkeK88RJVAfWN6+PpUPpj2/mIp2M/UVwdhs4WMP4AT4uMch9FnpXBWsF3NnjSkHSJGYY7bBljeAYTNSB9xp+Drj57Rk/iQ183/qgxm7dg35jshcKIwiRbAm2fT3B16ZOodNIoN4NkawZ+uZSKdpsOQtF+/iOyhNYV/lUf5a49p0OQXEuZ8v70wgsxt/G2qiq2DlpKForAVuX/dLh/4BNneqOuV7SqXtvrku7flphGjEJn31XpYasDnaMU6GYvDJpG+j3IIACKAJ8JafAOq9rpYTEt6P2W3qCqQxBVc1ogkZfg5wJU2dLBlFqcl8voYlZxECOYfrp8rvG1c0x/ESwxE4k6tTxe5WQgXYZm92TmYl7ye2VoL29ECvjF6Ldaby+C88MB59/RxsW5nUUVtNtOFzMCIw6MucTuNncvOLUKLaa7r6RdtYK6fMJEjM1TWyxEd2j2s+yoJ7w933LQjuG+FKLBpOpmsXhdqT1t1Xbm4vcaqs8JdoLfQLNz8NnrHwaxxLpp8DpeezJsjj3phesF+R+2Jhd04VkukGkVU/BNBwcpnym6pCdMCvn3bAECJe+T1+Q+AgZz8pAGs3mIfbQu+A3gudHE= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(366004)(39860400002)(136003)(396003)(346002)(451199015)(82960400001)(508600001)(38070700005)(6486002)(41300700001)(38100700002)(6512007)(31696002)(86362001)(71200400001)(316002)(54906003)(2616005)(91956017)(66556008)(66946007)(26005)(186003)(66476007)(76116006)(4326008)(66446008)(6916009)(64756008)(36756003)(5660300002)(53546011)(15650500001)(7416002)(6506007)(2906002)(31686004)(4744005)(8676002)(8936002)(83380400001)(122000001)(81973001)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?bXRhVlgzZVpYaGljRkxMK0U3SzA5Q0h2ZEdmUjZsT2l5eDMrOGpSbGtXTDd5?= =?utf-8?B?QXQ3MzR5TUJRaE8zZ3FuMnRFLzV6cVN0L3dud29rQ2g2dlRRK0wvd21vT0E3?= =?utf-8?B?ZHVoMWFhSWtpeDNZaVlpSlBOQlovcmpaQjlsQ3J4Sk1RckFoN1htZVU0Tktq?= =?utf-8?B?TjEvNitXOW9DeTNYSThQMzg3ZUppMXhMU3JMVG8xcldtc3dmR1YwVUZyMkdW?= =?utf-8?B?NE1oYWRsa0Rpa21QRVM0SkswZUdwa2tmYXM1NXI5L3BuWFlORzJCV2NmVkNr?= =?utf-8?B?b2Zqd2hEVGtkSVJRVmJzS2dzbHE2UTBuSURHV2NqMXVBNHQ4YzAzVXhRbXN2?= =?utf-8?B?clJIK1REL2NTMDlwS1BnL0R1TzVGclJFZXlGTHptakZiVFVpVUh1Qk9nZUtT?= =?utf-8?B?UkorT2t6UDZ6NGo3bE5va3IrelFLOGVIK2J4bjM3dVh3cW8rN00xSlBmdE83?= =?utf-8?B?TitOYW9BdytHbXk5VjFoWWZ2MjhpN2hnN1YrTWRkRDgxTmNOb016N2JlUXJV?= =?utf-8?B?dlh4UDVCaUpQeisrd3J6WUtpckhRb1pIdE5WMktVL25ESlRGaC9lYWU1U3Ux?= =?utf-8?B?V1dSMnBRYXphN1dTNmYxRlRQRjlwWmhNeEc5YmJhUzNXa3llN2NXMGlVZUJR?= =?utf-8?B?Wm4xK0FSU3FTWEsyY3lmS0o3UEpIUkFRVVFwMDNIMk5nY2Nxb2tBOUtJYU92?= =?utf-8?B?LzlzekVyM2pqWUdxbndwSjAwTGR2SitPSG41QmVtZGcxbFo3VTl3RmNMRmFy?= =?utf-8?B?Z3plQnZUaGwxazczVHFFSko2azdhRS9OT0MvUS9TVkx2UlVSa1ArVU1OVzNB?= =?utf-8?B?eWdUamJ5eTJqbDhBUXRVQ2pCVHgxL3lMQkV6d3hlRzFQOVJxbWZVNWRiaWNF?= =?utf-8?B?dTZnZU9OZUN0NTVCU084OUNyZGRwV3ZhRXphMkdvbzhQZ0QraTVEM0hKS1pa?= =?utf-8?B?RkkrTjgyaW5mWmxzSEgvdVREKzRlUkdGMnB0SzFFQk9oeWJNVWJOWForSnBD?= =?utf-8?B?clZBcnh4M0lDdXhZSGVDampGWUM1YytOc0VoZnppeFhKbkJ5TUI2ZnZlNFJT?= =?utf-8?B?QXZ3b1VYUVFZVHE0aDRTN0pTcFMrVEJmc3Y2NUlFRis0SzRENnhhc1NHYVRa?= =?utf-8?B?Nlg5eVZERW5hTkE0QjBsVU1nVmMxTFZjYXUzWTB1RGhNMVVESXlrQ2RwUzlG?= =?utf-8?B?bk5randvVWtvZGNIQnA1TDdyU0kxR1FhYVZPNmQ2TlkrUVlZaW9FT3Y3SXJw?= =?utf-8?B?S1lxQnRPdi9zUjV4eHJ1cDVxSHNsZUpod1J6Q2RzSE81bUtoVXNBTzF4Q3ZW?= =?utf-8?B?MTRDOWNCQTVFek5iQ04zSWdQaElINWF1c1hONTkxald3QjBrUkdCRnhHbDdK?= =?utf-8?B?MFNlcmRGWTNaLzY0Si9DR1A2SWxwaDVEczhEZUxaUjE3WEdBeFd1cjdDQzBD?= =?utf-8?B?OWNGNTlBK0ZqVEtuamhTVXpwK0VyaGRRQzZ3cHUwSDVkY0JRa1k1Y24zd2Nk?= =?utf-8?B?TnNnay94R3lsUEl0U2VWRW5ONmdEWVI5aTNiZGdtL2JqcS9aVWRpTXlsZndr?= =?utf-8?B?NHFKQldEQWxESm1rN0IvZjcvUWRCcnRpZ2dYMjR6a3QzS0k4bkhMcHYvUFNN?= =?utf-8?B?VzJEd1VhVHFHM1JDYnV4RTM3R0JyY2NjVVFkVForcHBCazZjdnF4VDI2Rnhr?= =?utf-8?B?ZXBDWUltbU9wSnlnMVVmNWgweGF2cGNpd285WVZjNHppVndSUnlYMnVFa0or?= =?utf-8?B?UEs4ZUxhMzBsR2lMejBBOGt2T2FvenM2NnZ1ZThGV0ZwdUQ5RFhyKzhQVHV2?= =?utf-8?B?SU5Zd2puQ1lTa3RtTnBqUjNVZE5SVnZScTBGNjBKS2xLY3oxWVo1eTZzYmFX?= =?utf-8?B?KzFjekRjb1V4Zko2M0JqcndZUUJUQjhndzVGenpDT0VKWU4zd0NtV2ErRlgw?= =?utf-8?B?VUFuUXZKZkVqejJtV0FObUMrU3VLWjRuU1FEaWwxYmUwUmUvV1NlQ3ExMWtQ?= =?utf-8?B?VTJrMENrRTdRSUdvTjk3Q1prbUl5MUU0anNuMWdpaDZIQ3pranlFRndQVXJM?= =?utf-8?B?bDBvU1FnRkR5THNObm9zRStWOXoxZkppOUU4THVRUW5PMjNrbHNYU3FJMDNk?= =?utf-8?Q?xvhhYi9YTJuY6pq30mC9iuD1U?= Content-Type: text/plain; charset="utf-8" Content-ID: <4A8DB20C8A814C47B6867826EF244D2A@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?OG5NUUxGY0JTVlhLU0ZtVzl6REwxVWVNL25DZ2FEMWdzL0tOd1hsc0tYZmlh?= =?utf-8?B?YThzN3E5TFhDQXdtanlFVExFS2NHbmUyTTJFYUY4RXA0NkJhRm1KVnBQMS9i?= =?utf-8?B?SFd2NW81SVI0L1orKzNKcjRMaytBQjNVN1V5WTlJY3ljY1pwN0tIaVMyUDJ3?= =?utf-8?B?MHZCRUgrWkhtZkdIRmNEQnp4VHJqTkw0bXVVSExLVUprWHEvSjJnUmZOZ0xT?= =?utf-8?B?M3ZUNktOTXlVZHRzOVQ5T0hBN21ZYU9iUzZjeVd4VmEySnRWR2xMVEMvRkI0?= =?utf-8?B?TDZWWlNqb3RPWnlLVTd3VDRHelROUnRzZms0YlpUZ0ljR1Q0Ym5DbUxDczNS?= =?utf-8?B?TnE2UEFBa1hxWkhxanc0RmtjSERnWjRhQ3hibzE3MWg3dWVuQ3VqWjhHMkFz?= =?utf-8?B?NHNFbVpkWU1yUE5Ba3JlbEtSa01Fc2hJc0JtRW52cFk0eUkwNWhhUkUrMGFW?= =?utf-8?B?RkFreDlRT2RkTnJZS3R3R0NQNS9qL0xNMUw0SFUyYVhnNjlTMUFYWHdNdlIv?= =?utf-8?B?OFpQS3RvekFBVWRWRzAvcGwyN0I1ZTVkOTk0RXBJYTFpRGY5MGdBbklDNzUx?= =?utf-8?B?MldlMUE5WVE3L1Z5NGtOU2RLZmUzU1BHVjZvb1hseUdobUFzU3VBZHVmR2pC?= =?utf-8?B?bnI0dlhac2VCYTlkQ0RWbTV0L2hNRzFyUWRBZVNTbU5JdThzcWZmdnRudG9J?= =?utf-8?B?U3FDZHlWNFZqWlVRL1oyeS9mZS9PYUhLczN2UHczbW9LU0IyU1pPazZNZ0s2?= =?utf-8?B?VXRqcG9wenA1N3o2K2xZTTlubjZtcWZtbkl1UnlUQjF1cW1XRzhmNnZ3Mm5j?= =?utf-8?B?ekdCei9UcEllZjJDNUY0ZEhyYnJSTGc1VzFabG5wR3cyNFg4eWNCV2N0QlF1?= =?utf-8?B?ckdUYXkzLy9oWW5ndEFxWmI4U2VXRkF5RkowSHlkMWpqNzZERlRtQjNMalRm?= =?utf-8?B?UlhScENENlR6UktDc0huL3RhbmE1K3lWWm5TMkFOd3g5QnNkSElwKzVGLzcz?= =?utf-8?B?YnlpdExsWVJLUklyQ1dEMGlrcllvZzFvOVZnVEtoN0UwM0lmL1JDanNJR1VO?= =?utf-8?B?ME5kcGcxbUhka3JyZGY0VVVNbEZocmduYnJHQnJJNnFMSGlpTVE4UlhndFpk?= =?utf-8?B?ZCtPWFRqb1VTdTlTd0FRUWFBU21XSE5zenU5bUU0ajM5M3VwOHkxRzAvbUNs?= =?utf-8?B?RlRZZlJRdklwMysvaU03SFBwdmdWOHVwLy9BS1VxYmF3WDIvWGNWYUdtMU1a?= =?utf-8?B?Znh3cjBSZklGMG1jRDZxWFhaeHAxVWRucllEY2RiV29ZRmFacnlDOEtkVzRL?= =?utf-8?Q?suAZcQ/vXM+R4=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2a83e043-1f44-4f5d-1227-08daf42027c6 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jan 2023 22:06:56.9613 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YnDzG0Exna6WsGLecBjljQYrZJ0ZJVJ2dlSHkohMWfm+t4EhZpxHUz6DMdiUFJnzhyADGq0Qdh/c/GnsB2G+JfllvaRJ1hc5jlHxba7hOoM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6555 T24gMTEvMDEvMjAyMyAxMTo0NSBhbSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDExLjAxLjIw MjMgMTI6MzksIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBUaGUgYmlnZ2VyIGlzc3VlIHdpdGgg c3R1ZmYgYWNjb3VudGluZyBpcyB0aGF0IG5vdGhpbmcgQUZBSUNUIGFjY291bnRzDQo+PiBmb3Ig dGhlIGZhY3QgdGhhdCBhbnkgaHlwZXJjYWxsIHBvdGVudGlhbGx5IGVtcHRpZXMgdGhlIFJTQiBp biBvdGhlcndpc2UNCj4+IHN5bmNocm9ub3VzIHByb2dyYW0gZmxvdy4NCj4gQnV0IHRoYXQncyBu b3QganVzdCBhdCBoeXBlcmNhbGwgYm91bmRhcmllcywgYnV0IGVmZmVjdGl2ZWx5IGFueXdoZXJl DQo+IChpLmUuIHdoZW5ldmVyIHRoZSBoeXBlcnZpc29yIGRlY2lkZXMgdG8gZGUtc2NoZWR1bGUg dGhlIHZDUFUpPw0KDQpDb3JyZWN0LCBidXQgaXQncyBvbmx5IHRoZSBSRVQgaW5zdHJ1Y3Rpb25z IHRoYXQgcmVsaWFibHkgdW5kZXJmbG93IHRoZQ0KUlNCIHdoaWNoIGNhbiBiZSB1c2VmdWxseSBh dHRhY2tlZC4NCg0KVGhlICVyaXAgYXQgd2hpY2ggWGVuIGRlY2lkZXMgdG8gZGUtc2NoZWR1bGUg YSB2Q1BVIGFyZSByYW5kb20gZnJvbSB0aGUNCnBvaW50IG9mIHZpZXcgb2YgYW4gYXR0YWNrZXIu DQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Wed Jan 11 22:22:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 22:22:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475731.737535 (Exim 4.92) (envelope-from ) id 1pFjUD-0005ZE-Tf; Wed, 11 Jan 2023 22:22:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475731.737535; Wed, 11 Jan 2023 22:22:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFjUD-0005Z7-P6; Wed, 11 Jan 2023 22:22:21 +0000 Received: by outflank-mailman (input) for mailman id 475731; Wed, 11 Jan 2023 22:22:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFjUD-0005Yw-CP; Wed, 11 Jan 2023 22:22:21 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFjUD-0004jd-9o; Wed, 11 Jan 2023 22:22:21 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFjUC-0006QM-Pi; Wed, 11 Jan 2023 22:22:20 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pFjUC-0000fA-PE; Wed, 11 Jan 2023 22:22:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=WjG9wrRVnF1A3hL0o0y3bWu6/UW/fOsxxQM0SxxQq4o=; b=6bPsZVzZL5mQ3rwBNmn0TED+bk UXNVQy9+t2M1QKx35FYDybwMChHsjzBKWv3uWe5EemWGaapi3DuK0deIrh6kSdNgEOhSMoicP0s0r xzQDfkOgAzbGyTcjM8mxzGoq2pteVmwNsIBEBwOj51ENuMlmAVx8NIEmm6KgXE1yLuKY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 175723: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=7dd4b804e08041ff56c88bdd8da742d14b17ed25 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Wed, 11 Jan 2023 22:22:20 +0000 flight 175723 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/175723/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine 8 reboot fail REGR. vs. 173462 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux 7dd4b804e08041ff56c88bdd8da742d14b17ed25 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 96 days Failing since 173470 2022-10-08 06:21:34 Z 95 days 201 attempts Testing same since 175717 2023-01-11 03:09:17 Z 0 days 2 attempts ------------------------------------------------------------ 3319 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 505897 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Jan 11 22:30:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 22:30:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475740.737546 (Exim 4.92) (envelope-from ) id 1pFjbl-00076M-Rb; Wed, 11 Jan 2023 22:30:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475740.737546; Wed, 11 Jan 2023 22:30:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFjbl-00076F-MY; Wed, 11 Jan 2023 22:30:09 +0000 Received: by outflank-mailman (input) for mailman id 475740; Wed, 11 Jan 2023 22:30:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFjbl-000765-7X for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 22:30:09 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7f0a6dd6-91ff-11ed-b8d0-410ff93cb8f0; Wed, 11 Jan 2023 23:30:06 +0100 (CET) Received: from mail-dm6nam11lp2176.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.176]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 11 Jan 2023 17:29:56 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SJ0PR03MB6421.namprd03.prod.outlook.com (2603:10b6:a03:398::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Wed, 11 Jan 2023 22:29:53 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5986.018; Wed, 11 Jan 2023 22:29:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7f0a6dd6-91ff-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1673476206; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=Tfci1Yft9hO6QbrKbFegdwobYO10oeVT7nn7iT/MQl4=; b=TPYap8oc8EmPdWt0QDtyvxKuRwsLN2OV9NHIRh0SWZrA1dTEGju+NJ0T LWsEhbx1K4Jqd7l/imqi+1fnU4A0sctycOnsg1nsUc8mi6BXjsdW8G89/ 40BPB635pUZpVd5XuhjOXDL5Lefsoq9hXyPZvGGC3z3gGvfLWNJ3Lxem7 U=; X-IronPort-RemoteIP: 104.47.57.176 X-IronPort-MID: 91140376 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:etQh+KIKNIBJC4T8FE+RG5QlxSXFcZb7ZxGr2PjKsXjdYENS0DIAy 2AcXWCHP/aDZWbyfN8nb97i9E1VuMWEx4QxHVFlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHv+kUrWs1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPdwP9TlK6q4mhA5wVnPasjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5GAjl20 P1GMwsgbzbboMyqnJejddJz05FLwMnDZOvzu1lG5BSAVLMKZM6GRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dopTGMkmSd05C0WDbRUvWMSd9YgQCzo WXe8n6iKhobKMae2XyO9XfEaurnzHqiBNpJS+PQGvhC2HrUwnAjLh4sCXCLpdu2iHWPZPdYE hlBksYphe1onKCxdfHtUhv9rHOasxo0X9tLD/Z8+AyL0rDT4QuSGi4DVDEpQN4sudIyRDcq/ kSUhN6vDjtq2JWXVHac+7G8vT60fy8PIgcqfjQYRAEI593ipoAbjR/VSNtnVqmvgbXdBjXY0 z2M6i8kiN0uYdUj0qy6+RXLhmyqr52QFwotvFyIACSi8x9zY5Oja8qw81/H4P1cLYGfCF6co HwDnMvY5+cLZX2QqBGwrCw2NOnBz5643Pf02DaDw7FJG+yRxkOe IronPort-HdrOrdr: A9a23:Jk9w9arwl7G7Ed4GeEkhl3caV5oleYIsimQD101hICG9E/b1qy nKpp8mPHDP5wr5NEtPpTnjAsm9qALnlKKdiLN5Vd3OYOCMghrKEGgN1/qG/xTQXwH46+5Bxe NBXsFFebnN5IFB/KTH3DU= X-IronPort-AV: E=Sophos;i="5.96,318,1665460800"; d="scan'208";a="91140376" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HO8e/QD+7uaOC5vz8NVQJXiyssWsxNTtXGAcxaSkv+MO/e1NDBa/57NE0IzRdiVt8OttfiNyCFB+44J8FGgtIm0Yp4gp0j0JSdCvtVgU5/T9ry4rAoAFf2w5E96NHsCot2pw56aSzVv+xr36+rBoa57ftSC5n2ZS+5Ii8nuY9islLbiYKiU/u7yEvmJ6MFEcChrSuvnarvpL3e5gkCRPcleL6+Ibsu0YCU1+nIuYrukfRLfMg81ED+sx/yyrVRBSl/BOBpn+jJq4CsoOnI5utPB5uaPlCTfUrYbyD+z+JJIEZdOOvOeO0xbomOaJXQU6zjx6EjgV/FNX+zMw8qW0cQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Tfci1Yft9hO6QbrKbFegdwobYO10oeVT7nn7iT/MQl4=; b=H20khbe0Ggu6T/0hGnNBKXWwMb8E55/cXcFpvepSHL5M6DSV32X5Y8aXEmUbxr0GVfUIdZDuhqqTAfkyg4C3aSfV2zjrt/VfWlkN29fwkstKyopD9srrja/Xll4ex3rIQo+ZCigqIQQb7CmWfE7bc6QTp8qMprVkZgZc9bwqo/N662KuUFuh06eRSJigy9Ipy1hdtSI6J9IpKsocR8vWCJRxRLfedBc1/vtsjd+0tW9njzVrru7w1IFDomHap609b6sviWoAw51D5vrSTcqPlOpsAkYYBFMS6aKokteP+1FHokIKbv6W6tThIuNhJpsRnA86qH9xv5qNUgmRA2ASIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Tfci1Yft9hO6QbrKbFegdwobYO10oeVT7nn7iT/MQl4=; b=KmRKLqSQNKOEGc7dNt1ettwHatY0keKRuupZfWWsf8D5bSJYR/1ejetVwduA16EkVnqw3r8XqrS8ACun9ewFrmvkVRtl5LtsV7UI8sza80klgfh7uNM5aGlVx1Et+nFf1ors6JywySe8tv2b/EwjAfIIwIfoAjMOPriOKLG4FOk= From: Andrew Cooper To: Anthony Perard , "xen-devel@lists.xenproject.org" CC: Jan Beulich , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re:[Multiple reverts] [RFC PATCH] build: include/compat: figure out which other compat headers are needed Thread-Topic: Re:[Multiple reverts] [RFC PATCH] build: include/compat: figure out which other compat headers are needed Thread-Index: AQHZJekaQF9ZU0LVM0eT+jo0D4jURa6ZzKCA Date: Wed, 11 Jan 2023 22:29:53 +0000 Message-ID: <5c7ffbe4-3c19-d748-9489-9a256faebb7a@citrix.com> References: <20230111181703.30991-1-anthony.perard@citrix.com> In-Reply-To: <20230111181703.30991-1-anthony.perard@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|SJ0PR03MB6421:EE_ x-ms-office365-filtering-correlation-id: 9dcd06f4-ea76-4dde-08fd-08daf4235c6a x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: q6JYKNIOkAugNmAjkql06KTLpHptgJiMSS3lt8jrDM6goAK+sSWDENno2yVKPp1lKXBRK5LLCHbKeqaZWmaneazMdyRLMZwAfxWT14lwh3W6+9YuMzUHZ2Lmmp1MKJkxzSIYqScjkDmGEr5q4xBKQQLiL0QbiyLWFepaHqPSdGWU7wFyUgWnURs8eZedBmhRfv5b98FOs8R6OdZDKu1C1rJPfG+aQWDckqsIrErXTr35xE/ZOg+gh6B5vNAxa4u6CYh+FOqLFYZHqdFVVHFGNXUYJOr87On/w61Hy2+8XyMq6j8TBkSHkO8JHF4mBMGM8fiC74CNP9d6p/EtcLccQmY3h+Tn3/6hViIIPqdoIeudo8mEgKyiaRVa0wh1+hP/gJWrK8OnY9E3IFnwxQFr3Ds/BZymcMfcnu194lQPP6nJOVEVQGCK6TyAuN+F3h2OYBS96c9NqDI33tgUhYkoYFWe802Qq1LTm4aAxH0k9jmLcvch4KAEbHONvWIV1JKecWe3/FxVvu4sPgGwcsgUgopfZYSuE1muGPdOBKJUQc5L4ch/EJNBWOnyisz0qPwPIJT/95w7SFh+jGhPP3nvDuAaVUyjzCKyTDv0Wa80Wx4kG7/zGXvB2RXko9EVCsE5kV8PvXO0o5eL8sYOyFcSBUi3Yz4256/Mh+zz6X1fqtzEdIK6hm8qaKLC5TaTaUNlqKjGdUECq3sUqKZ61/k/Wzf9vZAtM1jsVxYXlte1kGxMn2KTMYdMxNuhpY9aLcwaX8XJPTiv3MnX2+OSp6CT2HcDL2uvtGk2zMJMIDjqUnggQ6ywoOAA50BZGK+ouRj1MQehMU1q9OEEUoTR3/3b4iWcNAERvtxLXCx5c+nV+H8= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(366004)(39860400002)(346002)(376002)(451199015)(82960400001)(38100700002)(38070700005)(122000001)(86362001)(31696002)(91956017)(66446008)(66476007)(64756008)(4326008)(76116006)(66556008)(54906003)(66946007)(8676002)(41300700001)(110136005)(8936002)(2906002)(5660300002)(6512007)(2616005)(83380400001)(6486002)(53546011)(71200400001)(966005)(186003)(316002)(508600001)(26005)(6506007)(66899015)(31686004)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?WnZFRVdLRVN3TDJ5TS82U1ZwWHd3bTFVaGtQaHNSaFQyb2RLWFJOSWdKU2pP?= =?utf-8?B?L1UyeWN2UWhDdmVFeFZqb0o4bElwN3RmYWtFaENDRUFRUWorV2xjUWxKb2R3?= =?utf-8?B?NFR3UTBTc2NIdjVqb1pVMmhqNmV3dnlrSHdINytzQnh6aEVtNFJnRU1Gc2pn?= =?utf-8?B?NVM0anNabnUwSXpEUXgyRHkyS2x0SW9zWjd0N3VzRUpWYjRzTXkyS3pIZEpD?= =?utf-8?B?WjlsbXRlaitkUWtmSjI4TVJ0d29RN3ZMZWdvV1Vpa0IwZ1MxR3QvdngzNXpC?= =?utf-8?B?cmk3WUlVOTNnVDV3QitFZjI0TnQyNHgvTitzYStmWnRjbDZDOGNoZzdPWEVF?= =?utf-8?B?cUVodUx2Qk0yRHp3cjU0UVZhZHd1YXlZSVk1VkNHM2toMHljSG43NFE4eUJk?= =?utf-8?B?dXF1Yk1IT1U4QndHa1h2WnZrbmdFODJUcUZWNHRFRkJibFJkY2QreWlCZExI?= =?utf-8?B?TE13eTRKQjV4UkkzMTVINHIwNXZzRjJWNVVoZHNGWU05dEkrMXlkZ1l3RE1V?= =?utf-8?B?bHRqdnpIZStXNkc2RW9WS2RlSE5tRklCZkZkRElybGxnVzd0MDZDSmJGU0Vx?= =?utf-8?B?Rm0rdlhLNERPZ3llb2J5YXhsUGpONUVMV29GaHRsaFIrdjMxdUdQUmY3VlEz?= =?utf-8?B?MjhXM0tpcTI0TDYyTHdncktJK2tCY1Q0cGZsMnlTaDhheGJLcmR2dG8rYWo0?= =?utf-8?B?MlNmeFZJUGh0Z0JDOEQvbDlQT3UwZ1BqNUdCMG44Qi9zR2pNeERKaUdRTlR6?= =?utf-8?B?bWNUcDlIelkrR0JjZVlneisxSWhiVldlS0ZnUXo0TVQ2enE4U0VUdFcxYUhN?= =?utf-8?B?RHlYU0RXNnNwUDMrblBDT2ROZjduVWhKMmxOQ2Vxa3hDTnl4K2xFQ280dm5y?= =?utf-8?B?aWpZMEMxWGpJVnIyVmFkaVliOTFjNkNITWlwWE9hSHhYNnNKT0RtRVYySk1K?= =?utf-8?B?NEN1ZTl2Q1RjUnIxalB3bmN6eTdGRjhwR0dVcVFWbXFIdHVmNC9lSEk2QUE0?= =?utf-8?B?Y0o3N2hDbTBQcjFZRk9vV1RBVmV4ckpQeW1XRTc3RlhrVVo2ZmZBdlF4Wmkx?= =?utf-8?B?RmdzeTJ6cHRHNE41YkRaZjh1OWRnZ1pNMm1JT25vcVJvK09jdFNJdlByS3ly?= =?utf-8?B?OTdqWW1FUXlXSEM5TjBCbFp5UlM5VTFVMHRGdTdHRGhKL1dwRGJEUEszZnRp?= =?utf-8?B?RFlTamJleENwS0hPQjZySUNzMjgxckduTTJwcklzbXRDVzVlb2UwZStaakdq?= =?utf-8?B?emtVQkIvNlZOZkVMamc3MjM3YUxBTGRDbVgyWFNXcXdyaGV4OERQTzFnRGRO?= =?utf-8?B?ODBoWHBnTGNqK1hiek9NNkdMMXpoclVoWE55WFJoSU9JNzdybXExd2t2ZGNM?= =?utf-8?B?MTBUUEtITUZRMytrUFdPa0tmSUdCRnRnb2JGcHBHMUFnQ1hBZitzb0hhUWNN?= =?utf-8?B?aG1XQ3RGTk5EbnYxaDVtYW40Ni9ULzJrKzNkcHhxMnZEL2pJS0tKTy8wbVRU?= =?utf-8?B?TXdtMTljVkNrQktDZzI5UmRDQ2hobkZWcG80cmpZOWh5QUJjT3dnOWdQKy9C?= =?utf-8?B?SEdRdHFrSnd6RDRqakQrVXNMYm1ZWTVGQlB5elBaRXRWRU5pK05vV281R01o?= =?utf-8?B?WHlYQ29DMDZTRUFjaC9MMzc1THlGa3F4bkpha1RnNTl1RmRESW9zME9JNDhC?= =?utf-8?B?WG1QanY5N2FYMFYzaWoxSXJoWm9YdXVkMmtNYVFuZGZTQnpOSmtoZWpMamtR?= =?utf-8?B?RlVWU1R2UVo4cVFocS9JNDNPSFZoV0tEQnpQZ04rY0VlSTZWMDJyYm5WYTZ3?= =?utf-8?B?aVpqMjRTc2lZbFpnaXJjQlc2VHRIcnJRZFJUajJKQ1N0S2Vmczdld3gzSXUz?= =?utf-8?B?ODVKRjdyck9uQkEvN2ExRklTeDNuem5veUZBZ1Z0dnN3RWlEZ2RaWkZVTTU2?= =?utf-8?B?cGg4dVg5M3pVazlyaVhDRE9tZUwyLzJPa3FzVzl4Y28yYTFSS2ErMEhiSm11?= =?utf-8?B?cE1XZ0x3UmRDWDlpcnBxanpWbDN1QU16TlFDeWhSRnhld0V1eEg3SmU2bDdX?= =?utf-8?B?QlZwTVZwWkVtN1phKzlCTVp6bDBQZU1yWXVRQkxwN1RsSHo3TnBlVGRpMzdM?= =?utf-8?Q?awuamTOUJC2BR+j0CBhcDniND?= Content-Type: text/plain; charset="utf-8" Content-ID: <9A018F9DF57C8A4F87AE15F76341704B@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: bqcKTcAvIujz7kVq8lq2wXP56A6k8wx/SA2+NpHyTFHO8VyRxSx5ugmScsc3NxqDyOyzylofRv7/iPSolybaZQwgb+l43dR0crQL5iEiF4URTzbdFinIlHIouHqd0K0hm5LNHr4iEGEj9qXftS8LmwO/wFr4JYlaawU9FC7y6B2z5qIxtYG1XVgcp+KwqXD+0UYvV1rYzHVuYdSmIyy2HwXi3pvHmwqFI1Mi7egvRI1xMIUue7l/VfA9IHKJ2Pf46whOnIF3hsCeALyMH9R7VTrCUVAZLt7Eq8nJNxmnhZcD0w21BIYKpVIYU67Zzy2MiV8HjtiEJIAiNy/VswscKi3DWsXusBl7947rybV6oNzY9nPHRTKDsWy+CScj+f65xwV63cVIgtAUUkQHz8p13nfrXHSUzRD9a8jBMlE/1DXZ0c+xeRzXf86KNdv/hfY1+6FoJUnBlLD6bzShp/2nQTfZfxroBh4TCl2v0PEcO0H/L61zWJC70M20e2PQ6YwJKzH+W9PJZb3ocVBlpaoLjGlKNN4ZCBF9dKKICKOpF6RhnfMdFl4KoRigSPRybkqsC2Nm60Hhyu9GI9YEZnmTQGdXXjFM00tNdQnzoBB97m34Syt5uWzqwT8xQgT8aRlnaJTcNGAJCoYUxdiz3cSqVjL9r88CDMDFFTi37c6oQg0nh51MykwZ7SdHTutogCYXxIvmzbeRaqF4SQ48KgZsyJpf62JFt9NYaXciCxuEnVRUlqMoCHigLflYsMlOdRbCU6HYh9tnO2UdN3JN3K11YXU6L4GhhBxeVtyKX3uufvsROgv1h13/svSE8JfcQs08RbCFA7flPtE70ethA4b9b6gasFMIwwSPwbpIKmu0YdI= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9dcd06f4-ea76-4dde-08fd-08daf4235c6a X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jan 2023 22:29:53.7363 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cQcCq1t3mbjfKRe9li1q4uZ4qUWeg4JONgWI7ZLPzNl00hxEpLalzk6NyJrcbrNrITy+FCMW3puL9HEaUpDoHyCdgYCfEAP4RHQ9p05GMtc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6421 T24gMTEvMDEvMjAyMyA2OjE3IHBtLCBBbnRob255IFBFUkFSRCB3cm90ZToNCj4gU29tZSBjb21w YXQgaGVhZGVycyBkZXBlbmRzIG9uIG90aGVyIGNvbXBhdCBoZWFkZXJzIHRoYXQgbWF5IG5vdCBo YXZlDQo+IGJlZW4gZ2VuZXJhdGVkIGR1ZSB0byBjb25maWcgb3B0aW9uLg0KPg0KPiBUaGlzIHdv dWxkIGJlIGEgZ2VuZXJpYyB3YXkgdG8gZGVhbCB3aXRoIGRlcHMsIGluc3RlYWQgb2YNCj4gICAg IGhlYWRlcnMtJChjYWxsIG9yICQoQ09ORklHX1RSQUNFQlVGRkVSKSwkKENPTkZJR19IVk0pKSAr PSBjb21wYXQvdHJhY2UuaA0KPg0KPiBUaGlzIGlzIGp1c3QgYW4gUkZDLCBhcyBpdCBvbmx5IGRl YWxzIHdpdGggImh2bV9vcC5oIiBhbmQgbm90aGluZyBpcw0KPiBkb25lIHRvIGhhdmUgbWFrZSBy ZWdlbmVyYXRlIHRoZSBuZXcgZmlsZSB3aGVuIG5lZWRlZC4NCj4NCj4gU2lnbmVkLW9mZi1ieTog QW50aG9ueSBQRVJBUkQgPGFudGhvbnkucGVyYXJkQGNpdHJpeC5jb20+DQo+IC0tLQ0KPiAgeGVu L2luY2x1ZGUvTWFrZWZpbGUgfCAyMyArKysrKysrKysrKysrKysrKysrKysrKw0KPiAgMSBmaWxl IGNoYW5nZWQsIDIzIGluc2VydGlvbnMoKykNCj4NCj4gZGlmZiAtLWdpdCBhL3hlbi9pbmNsdWRl L01ha2VmaWxlIGIveGVuL2luY2x1ZGUvTWFrZWZpbGUNCj4gaW5kZXggNjViZTMxMGVjYS4uNWU2 ZGU5Nzg0MSAxMDA2NDQNCj4gLS0tIGEveGVuL2luY2x1ZGUvTWFrZWZpbGUNCj4gKysrIGIveGVu L2luY2x1ZGUvTWFrZWZpbGUNCj4gQEAgLTM0LDYgKzM0LDI5IEBAIGhlYWRlcnMtJChDT05GSUdf VFJBQ0VCVUZGRVIpICs9IGNvbXBhdC90cmFjZS5oDQo+ICBoZWFkZXJzLSQoQ09ORklHX1hFTk9Q Uk9GKSArPSBjb21wYXQveGVub3Byb2YuaA0KPiAgaGVhZGVycy0kKENPTkZJR19YU01fRkxBU0sp ICs9IGNvbXBhdC94c20vZmxhc2tfb3AuaA0KPiAgDQo+ICsjIEZpbmQgZGVwZW5kZW5jaWVzIG9m IGNvbXBhdCBoZWFkZXJzLg0KPiArIyBlLmcuIGh2bS9odm1fb3AuaCBuZWVkcyB0cmFjZS5oOyBi dXQgaWYgQ09ORklHX1RSQUNFQlVGRkVSPW4sIHRoZW4gdHJhY2UuaCB3b3VsZCBiZSBtaXNzaW5n Lg0KPiArIw0KPiArIyBVc2luZyBzZWQgdG8gcmVtb3ZlICIuLiIgZnJvbSBwYXRoIGJlY2F1c2Ug dW5zdXJlIGlmIHNvbWV0aGluZyBlbHNlIGlzIGF2YWlsYWJsZQ0KPiArIyBUaGVyZSdzIGByZWFs cGF0aGAsIGJ1dCBtYXlub3QgYmUgYXZhaWxhYmxlDQo+ICsjCXJlYWxwYXRoIC0tcmVsYXRpdmUt dG89LiAtbUwgY29tcGF0L2h2bS8uLi90cmFjZS5oIC0+IGNvbXBhdC90cmFjZS5oDQo+ICsjIGBt YWtlYCBhbHNvIGhhdmUgbWFjcm8gZm9yIHRoYXQgJChhYnNwYXRoKSwgb25seSByZWNlbnQgdmVy c2lvbi4NCj4gKyMNCj4gKyMgVGhlICQoQ0MpIGxpbmUgdG8gZ2VuIGRlcHMgaXMgZGVyaXZlZCBm cm9tICQoY21kX2NvbXBhdF9pKQ0KPiAraW5jbHVkZSAkKG9iaikvLmNvbXBhdC1oZWFkZXItZGVw cy5kDQo+ICskKG9iaikvLmNvbXBhdC1oZWFkZXItZGVwcy5kOiBpbmNsdWRlL3B1YmxpYy9odm0v aHZtX29wLmgNCj4gKwkkKENDKSAtTU0gLU1GICRALnRtcCAkKGZpbHRlci1vdXQgLVdhJChjb21t YSklIC1pbmNsdWRlICUvaW5jbHVkZS94ZW4vY29uZmlnLmgsJChYRU5fQ0ZMQUdTKSkgJDwNCj4g Kwlmb3IgZiBpbiAkJChjYXQgJEAudG1wIHwgc2VkIC1yICcxcy9eW146XSo6IC8vOyBzLyBcXCQk Ly8nKTsgZG8gXA0KPiArCSAgICBlY2hvICQkZjsgXA0KPiArCWRvbmUgfCBzZWQgLXIgXA0KPiAr CSAgICAtZSAncyMuKi9wdWJsaWMjY29tcGF0IzsgOiBwOyBzIy9bXi9dKy8uLi8jLyM7IHQgcDsg cyMkJCMgXFwjJyBcDQo+ICsJICAgIC1lICcxaSBoZWFkZXJzLXktZGVwcyA6PSBcXCcgLWUgJyQk YSBcICcgXA0KPiArCSAgICA+ICRADQo+ICsNCj4gK2hlYWRlcnMteS1kZXBzIDo9ICQoZmlsdGVy LW91dCBjb21wYXQveGVuLWNvbXBhdC5oLCQoaGVhZGVycy15LWRlcHMpKQ0KPiArIyBBZGQgY29t cGF0IGhlYWRlciBkZXBlbmRlbmNpZXMgYW5kIGVsaW1pbmF0ZXMgZHVwbGljYXRlcw0KPiAraGVh ZGVycy15IDo9ICQoc29ydCAkKGhlYWRlcnMteSkgJChoZWFkZXJzLXktZGVwcykpDQo+ICsNCj4g IGNwcGZsYWdzLXkgICAgICAgICAgICAgICAgOj0gLWluY2x1ZGUgcHVibGljL3hlbi1jb21wYXQu aCAtRFhFTl9HRU5FUkFUSU5HX0NPTVBBVF9IRUFERVJTDQo+ICBjcHBmbGFncy0kKENPTkZJR19Y ODYpICAgICs9IC1tMzINCj4gIA0KDQpGb3IgcG9zdGVyaXR5LA0KaHR0cHM6Ly9naXRsYWIuY29t L3hlbi1wcm9qZWN0L3Blb3BsZS9hbmR5aGhwL3hlbi8tL2pvYnMvMzU4NTM3OTU1MyBpcw0KdGhl IGlzc3VlIGluIHF1ZXN0aW9uLg0KDQpJbiBmaWxlIGluY2x1ZGVkIGZyb20gYXJjaC94ODYvaHZt L2h2bS5jOjgyOg0KLi9pbmNsdWRlL2NvbXBhdC9odm0vaHZtX29wLmg6NjoxMDogZmF0YWwgZXJy b3I6IC4uL3RyYWNlLmg6IE5vIHN1Y2gNCmZpbGUgb3IgZGlyZWN0b3J5DQrCoMKgwqAgNiB8ICNp bmNsdWRlICIuLi90cmFjZS5oIg0KwqDCoMKgwqDCoCB8wqDCoMKgwqDCoMKgwqDCoMKgIF5+fn5+ fn5+fn5+fg0KY29tcGlsYXRpb24gdGVybWluYXRlZC4NCm1ha2VbNF06ICoqKiBbUnVsZXMubWs6 MjQ2OiBhcmNoL3g4Ni9odm0vaHZtLm9dIEVycm9yIDENCm1ha2VbM106ICoqKiBbUnVsZXMubWs6 MzIwOiBhcmNoL3g4Ni9odm1dIEVycm9yIDINCm1ha2VbM106ICoqKiBXYWl0aW5nIGZvciB1bmZp bmlzaGVkIGpvYnMuLi4uDQoNCg0KQWxsIHB1YmxpYyBoZWFkZXJzIHVzZSAiLi4vIiByZWxhdGl2 ZSBpbmNsdWRlcyBmb3IgdHJhdmVyc2luZyB0aGUNCnB1YmxpYy8gaGllcmFyY2h5LsKgIFRoaXMg Y2Fubm90IGZlYXNpYmx5IGNoYW5nZSBnaXZlbiBvdXIgImNvcHkgdGhpcw0KaW50byB5b3VyIHBy b2plY3QiIHN0YW5jZSwgYnV0IGl0IG1lYW5zIHRoZSBjb21wYXQgaGVhZGVycyBoYXZlIHRoZSBz YW1lDQpzdHJ1Y3R1cmUgdW5kZXIgY29tcGF0Ly4NCg0KVGhpcyBpbmNsdWRlIGlzIHN1cHBvc2Vk IHRvIGJlIGluY2x1ZGluZyBjb21wYXQvdHJhY2UuaCBidXQgaXQgd2FzDQphY3R1YWxseSBwaWNr aW5nIHVwIHg4NidzIGFzbS90cmFjZS5oLCBoZW5jZSB0aGUgYnVpbGQgZmFpbHVyZSBub3cgdGhh dA0KSSd2ZSBkZWxldGVkIHRoZSBmaWxlLg0KDQpUaGlzIGRlbW9uc3RyYXRlcyB0aGF0IHRyeWlu ZyB0byBiZSBjbGV2ZXIgd2l0aCAtaXF1b3RlIGlzIGEgbWlzdGFrZS7CoA0KTm90aGluZyBnb29k IGNhbiBwb3NzaWJseSBjb21lIG9mIGhhdmluZyB0aGUgPD4gYW5kICIiIGluY2x1ZGUgcGF0aHMN CmJlaW5nIGRpZmZlcmVudC7CoCBUaGVyZWZvcmUgd2UgbXVzdCByZXZlcnQgYWxsIHVzZXMgb2Yg LWlxdW90ZS4NCg0KDQpCdXQsIHRoYXQgaXNuJ3QgdGhlIG9ubHkgYnVnLg0KDQpUaGUgcmVhbCBo dm1fb3AuaCBsZWdpdGltYXRlbHkgaW5jbHVkZXMgdGhlIHJlYWwgdHJhY2UuaCwgdGhlcmVmb3Jl IHRoZQ0KY29tcGF0IGh2bV9vcC5oIGxlZ2l0aW1hdGVseSBpbmNsdWRlcyB0aGUgY29tcGF0IHRy YWNlLmggdG9vLsKgIEJ1dA0KZ2VuZXJhdGlvbiBvZiBjb21wYXQgdHJhY2UuaCB3YXMgbWFkZSBh c3ltbWV0cmljIGJlY2F1c2Ugb2YgMmM4ZmFiYjIyMy4NCg0KSW4gaGluZHNpZ2h0LCB0aGF0J3Mg YSBwdWJsaWMgQUJJIGJyZWFrYWdlLsKgIFRoZSBjdXJyZW50IGNvbmZpZ3VyYXRpb24NCm9mIHRo aXMgYnVpbGQgb2YgdGhlIGh5cGVydmlzb3IgaGFzIG5vIGxlZ2l0aW1hdGUgYmVhcmluZyBvbiB0 aGUgaGVhZGVycw0KbmVlZGluZyB0byBiZSBpbnN0YWxsZWQgdG8gL3Vzci9pbmNsdWRlL3hlbi4N Cg0KT3IgcHV0IGFub3RoZXIgd2F5LCBpdCBpcyBhIGJyZWFrYWdlIHRvIHJlcXVpcmUgWGVuIHRv IGhhdmUNCkNPTkZJR19DT01QQVQrQ09ORklHX1RSQUNFQlVGRkVSIGVuYWJsZWQgaW4gdGhlIGJ1 aWxkIHNpbXBseSB0byBnZXQgdGhlDQpwdWJsaWMgQVBJIGhlYWRlcnMgZ2VuZXJhdGVkIHByb3Bl cmx5Lg0KDQpTbyAyYzhmYWJiMjIzIG5lZWRzIHJldmVydGluZyB0b28uDQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Wed Jan 11 23:16:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 23:16:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475746.737557 (Exim 4.92) (envelope-from ) id 1pFkKM-00033a-5K; Wed, 11 Jan 2023 23:16:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475746.737557; Wed, 11 Jan 2023 23:16:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFkKM-00033T-1z; Wed, 11 Jan 2023 23:16:14 +0000 Received: by outflank-mailman (input) for mailman id 475746; Wed, 11 Jan 2023 23:16:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFkKK-00033N-Jh for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 23:16:12 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id eb007b52-9205-11ed-b8d0-410ff93cb8f0; Thu, 12 Jan 2023 00:16:04 +0100 (CET) Received: from mail-co1nam11lp2171.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.171]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 11 Jan 2023 18:15:58 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by PH0PR03MB5878.namprd03.prod.outlook.com (2603:10b6:510:34::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Wed, 11 Jan 2023 23:15:54 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5986.018; Wed, 11 Jan 2023 23:15:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eb007b52-9205-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1673478964; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=slJOBE0mbK8K/SCPeC6NuKHHLlciEoPKDGwPLBhaokI=; b=dPNydfVYHAhaWXCCifDhULmF9pfCS5A8owaWJe0s2D91YPItHxtQeyvV vrJxLvAawTWVAs8tsgOPbsFYtOp3NlU76TAcmU/Yh6Sx8hoPjYPKHjvd7 kJwBh5dqVkekZjH8H4pWZ1qor2/6plNqtDHz9p/l0Tr/eAEV0xv+sCA4m o=; X-IronPort-RemoteIP: 104.47.56.171 X-IronPort-MID: 94677062 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:Qmwatazk4O2zKbZ+teR6t+cGxyrEfRIJ4+MujC+fZmUNrF6WrkVRz mQWXzzSM/yNZmbwc4x2PISypE8Pv5KGyYRrGwZq+SAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTbaeYUidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+U0HUMja4mtC5QRnPKkT5zcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KTl8+ /MYCCoXVRasjb2V+JeRTvNO1v12eaEHPKtH0p1h5RfwKK9/BLvkGuDN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvjaVlVMouFTuGIO9ltiibMNZhEuH4 EnB+Hz0GEoyP92D0zuVtHmrg4cjmAuqBNxNS+XmrJaGhnWL31cCNjRKbmKy4tO7ulC6XYMEI BALr39GQa8asRbDosPGdx+yrWOAvxUcc8FNCOB84waIooLE7gDcCmUaQzppbN09qNRwVTEsz kWOnd7iGXpoqrL9YW2Z3qeZq3W1Iyd9BXMDYAcUQA1D5MPsyLzflTrKR9dnVaWy19v8HGipx yjQ9XdnwbIOkcQMyqO3u0jdhC6hrYTISQhz4RjLWmWi7UVyY4vNi5GU1GU3JM1odO6xJmRtd lBd8yRCxIji1a2wqRE= IronPort-HdrOrdr: A9a23:OEBT06664SBrvsnFyAPXwOPXdLJyesId70hD6qkRc20xTiX8ra rCoB1173PJYVoqN03I4OrwQZVoIkmsl6Kdg7NwAV7KZmCPhILPFu9fBODZsl7d8kPFl9K14p 0QF5SWWOeaMbGjt7eA3OBjKadH/DBbytHOuQ4D9QYUcei1UdAb0ztE X-IronPort-AV: E=Sophos;i="5.96,318,1665460800"; d="scan'208";a="94677062" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Nds3jGcURGqMSuukeSyz5UDTRKTp0KFhT8LggkajqVuGM0VfHlqF6NQnOzxWAHjYV3yZecoOWWkS04+DI74M5RcAg8MQ8VuUxelyfQHSC5Og4uRDu59W4y22OjiZg4T57R/RUJIvtQS1+ZkgNsCUbuNDcZddglslXpY1/TSQiMo8poySYazlEO1xQDz1fBBU6I+iSLAS1+vqJF7YXnD8yyfcgoRvnkM1YVDgAJJStsaacQNihLaf7hgz8hJPdV4paqR5WfHmF71miA0ILePb+MaxXnFL2ay+tW/H1IvYTCjBuT9Lzmi7pidDcpvBvKQ2wwI82ir3Shf8fBjuY+eZLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=slJOBE0mbK8K/SCPeC6NuKHHLlciEoPKDGwPLBhaokI=; b=ChrJ9VNzWyny/uenxMrvdJwkgbXsHOUb2ago5wakIF+kbQW4Qz0pjGh8lEgaRAAupxwyjKd7jP25oYs/g+xJBD4Oq8sHiq9FagexIZiV6oWB1bf/Cga6g3pw/PpeVXTwtPZgKiScq1RiLUtrSr0IVrAVLQYbaDJrxOY82I+xRVagV0XkeyUqZH9jOfA+nIlTdxetj4rgoQ0RUILv1RdGrUapcx77EnrYj6Tio5DkrBcqYZngJtt2ZsENr1+xdy1LzYzT28Kr64a0f4eFFNb6MajoYaQju+uJ9Z9tZKdyo+Os1gprlvvfesy2/9VxCm/ypBUrjpUG4XrHk7s9FDBwLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=slJOBE0mbK8K/SCPeC6NuKHHLlciEoPKDGwPLBhaokI=; b=mvZd9QZ0ONLdSRWieu/HDYKulwN6TQZ1ofYY4uUDzZ88nrl0kSWii1+xwgu67UPc7OzCKLVhxnvmViduiFQospt4D/zF00BsQ7R1UR7EfsMmTLkGvPEKszWojlYJggPMlcj6OHWNVJh+doyAuOSAiedfmrwTH/UBeaQq2GNrKDE= From: Andrew Cooper To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Wei Liu , Roger Pau Monne , "Tim (Xen.org)" , George Dunlap Subject: Re: [PATCH v2 9/9] x86/shadow: harden shadow_size() Thread-Topic: [PATCH v2 9/9] x86/shadow: harden shadow_size() Thread-Index: AQHZJcS6xQlTtpJxX0O79yAhgOZJ+66Z2cOA Date: Wed, 11 Jan 2023 23:15:54 +0000 Message-ID: References: <9bea51eb-4fbd-b061-52d7-c6c234d060a1@suse.com> In-Reply-To: <9bea51eb-4fbd-b061-52d7-c6c234d060a1@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|PH0PR03MB5878:EE_ x-ms-office365-filtering-correlation-id: f701c556-07ac-428d-1861-08daf429c9bf x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: WePJjXtuoCD6sIsVm+E5aPCU4umzbvrkJreTKNkVPb3OlmQSIevaohe7ixdpzS8IPgr0fsrAP8Sf7Jz+x+qt3QdYQ+b/yeuayrXfVZg+iXK5WhVOFWooFnQzFnyA7FErNY52E8fQ48vsVjwweXr5zLt8N/GYPcC4kY7gzNVMYzMHFTdM92V0bwRNPsZkKh3q5ThLy6dLmka17gw6ckmyntZWi7f4HKZ4ydiqsDRd7dVidDomFhJq64NFwzfTeyYtMSL5m+PmKeO4SXZw1Srs/xArOt77doq2ZCNkk4Uk7YKZe6pvEtBdZ3Xws9PYaczgHmRXlDCMdgnJ66gI8icHWD7hA1EYtz8izkO1GIQ9ypH1zuz/ANleDXPjzEjMAUVNs3DRcCJFEkFTo1ab+7rVPblio1IgKbx0GfZhB4G8w2vUcWvzCOEgu9WP4MNagFo0RsdbusrsU0apNom5VM2UnD2OBBIgsph3+BX94V5rH2Q5tyLSZbmEL/XFe7WTTpF89G3mO2RRH3D21s5OkWOaE9mWOXTFVC2c2Rtl5bvZBmMF0SsMB/vPtFr7vph8RIzYM14G4GzMS2HOVRrO9LOmk9y4gl+uVOAdz9ZF3uI0Lif4vze+os3iurHhcvUG3IxhVSoGkFVxbGvZ0HvijAx5N0jcDBUCv3GsQlEtJq5Aw1zemO55Pyoy33KLtdmjMS2CwJ9dcKd/jvUyDKYSxSOfw0CYUVy1p68c0BMZRnrVqfb0zxqO/jls1xOCslnFDX7FcRCdfNxsgoiTmwnpwh9rTg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(136003)(396003)(376002)(346002)(39860400002)(451199015)(8676002)(186003)(26005)(316002)(71200400001)(5660300002)(6512007)(6486002)(478600001)(86362001)(2616005)(31696002)(41300700001)(54906003)(76116006)(66556008)(110136005)(91956017)(4326008)(66476007)(66946007)(64756008)(66446008)(8936002)(36756003)(83380400001)(38070700005)(31686004)(107886003)(6506007)(82960400001)(38100700002)(122000001)(2906002)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ZVlVQVZCZm9rdnYreDZLQkwxdjVWRjJNSDBGWmZGMDRJZjZXZGxycWZ3RGpq?= =?utf-8?B?SENmdC9tK1dVL3NsUjBua2R3ZDBzTUFCQkNTT3JHUENKY1plckxQeWZrdE5j?= =?utf-8?B?ZEZydDV3M1R5LzRGOEdzQ1ordFJMNFhHM2hZRnYxQzhieCtvek9iR2ZrdWxt?= =?utf-8?B?dGZSQmlWcDdheU9OQTRpVjFmZVhHSmwyZnZzdVZwaENFVTEyVlhvME5kSGRW?= =?utf-8?B?LzlrWmIxcG0rWjJXRjZ6M2Jrd2hYcWJjVS9nRnVkY3lyQ1FldzRJZFBhaW01?= =?utf-8?B?NTNNMEhHU2ROenVaT0NuNklZaUZaMzh1V0o0dzAzbXZUMW5PclJCVWF4UU45?= =?utf-8?B?b2hlSmo5RnNBWVVNVEZrSXp6dXhDcXFtRkpjVWJVMmhzeTBEMzg5aXBOOTE4?= =?utf-8?B?amhTTlJnaEFIRDZ1L3BwN015MmdTTzFDVHRveW83dWVzOXR6VmVPRmNnSXkz?= =?utf-8?B?NkRzV0dYOHQ3YWIwTDIvdmNzTkJYMFJMc0ZwWVY3M1ZGRG50YWR1NHRDTEpE?= =?utf-8?B?bGxTcG9SazlKYkljRkE1VkloYVg5bUpCVEpMZThSelAwZUNCbk9hOEt0ME1C?= =?utf-8?B?S2FiVU0rUlV1c0JwdVpwRjZ2MlhQMzJlczVpenBKaHoyc0V0MzFNYUVzbkdR?= =?utf-8?B?SmtjbFR1UStDMnlDaklqMXdBY0xRMVM1cmw0L2lxNWtxM0R6TjVZNHFoRDdi?= =?utf-8?B?eXloYlFxRDRKKzBZN3cyTEpra1lsMGZWOW5HNm54NG1tYk1mZkg2b0grdW5F?= =?utf-8?B?MDhMSXRncmhaOGFXYjN2cXU0c1I2aHkyYjM2ZG1RTnc3TXhFNjJ3TzJUc1lN?= =?utf-8?B?NDd0UWtLN1VsTlJRVE5EN2N0RE5YRitOTWI0OHBUMC9ZbWgrMUdqR1RMZUVP?= =?utf-8?B?aFdaUTZSSnF4c01oTE54eWxQaXVzWkI5Z3FSSU4rK2ZYSjVVTkJvNHZFYlo1?= =?utf-8?B?TVZtcGwvdVQzUlVGUnBTN0lXcnltZlpEU3BBb1IzVHA5WEVJWGk5TVBtbytr?= =?utf-8?B?dGxqaVcvcHFhNlRaOU5hZmRBVk5rVG0xSzRqMUE4b2phcFNwSGJmeGF5TXIw?= =?utf-8?B?c0R5VmxxOXRyUFpRMFhYaTZNQVhIcjNsSGZSYWxrL3UzUVo4Vk85VHcycGZU?= =?utf-8?B?aGI3RUl5TjVpT3NBTndwbnl6b1hXS0VPVm54RllUVGZtTjhqUGZGeldBZGlY?= =?utf-8?B?UUF0R3JoQVQ4eFdPSVZLSmt6UjIrUjBTMDRIcUhkaVpuc3RidW9FemdIZDJO?= =?utf-8?B?VnE5STJRR0hOeEdZblAreG9DR2tMSU9ocEM0MFBLaXJKbXVPSzVHT3ZjU2NN?= =?utf-8?B?cFRlVWVoY1ljRnNDN3I1WWFTU3IrbDhlUU9pcVNUTHl4bTRzdm1jZU02QlFT?= =?utf-8?B?YXdGZEpZK0EyOGJrV3ZsRWFBM3BkNFRud0dSZ3c1Y0liRUZNNDIrd2tTOUt3?= =?utf-8?B?WFM5N3pvYUJvcEVyTWEwRUZWTm5ZYlFrYXVpckE3NDk4ZENVcDBzQnZRaDhx?= =?utf-8?B?eUU0dkxZSVZSZks0STJreVlsYXl3YTl4R3h4dEFXYmtUQnJqelVXRVU3aXFE?= =?utf-8?B?QW5oOFk2NmZaajNYU2FPZVpHZkJpU0h3NXNuTHAzamQvRG1GYVhrbzU4Q2x0?= =?utf-8?B?bVhxVVdRdzI3b2VGWEVpKzdiekFReHFOaElUaTZiK25ZTlpldU1BZ0N0TVFI?= =?utf-8?B?U3lDdkc2MnZqaTZjZThnN25xNk9nNUZBVmE2ZzBxd21Cc1U2dDFPbXRTSWV5?= =?utf-8?B?ekN1a1NjRGZUSGZmaHZqMlRFOWZQQWpuMjFSM0dHT0w3RUkrZVRCZ0w1THdj?= =?utf-8?B?K3FoK21sRHFMTXNTNHVRL0NjWUVFNnd5TVNIdzBWQ2NqdlNMVzh5ZS8wNUlv?= =?utf-8?B?MXJEWjJUR0JxRU9uZ1plM1psTjlSSzlLMlk5cGlHdElTWmZxajF3Uzg3dW9x?= =?utf-8?B?ZnFzSUFJODJrSnNBdU95MzZMSVN3S243UktoWG52NzNMazdVbkJESTVhcmY3?= =?utf-8?B?RXZBQ1c0YmZkTkdDTjd5NWRhbXd2ZS9LbUtBYlRDSy9FbTY4aEtWcERMQUZN?= =?utf-8?B?UFI4NElPREFvK1RsVWhPQnJlWXlNWStYY05WdS9CakVYS000dnM5aXUzY0VX?= =?utf-8?Q?H9oFluWCo0Tw1Tlb1x1QG7TNd?= Content-Type: text/plain; charset="utf-8" Content-ID: <78DC18C3BC14B84C9444B4499CB72BBA@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: ooad0/v2jJu9uW40vAsT8k7+/QGv7NWCMu/cy6vYerVsvbhLKfE8OGB6iP02NMm1cHUfgN9qtpb/7IRg+g2+p4sCACKIyNY8tG2NT7fB2OL70+hN+hZhe9JwkwteAjRa/hQ5NCQVOI2vZ/JP4oX3gsKbvJCIgiiuYpas2YsY3aBYWhOVc2X/AYOyYN3YPyeVH6QufnQKi+20tZHGW7/a/tFlHt3m18a3PIYYLL6GBoz6YI0bq6N43Md3+UNa45xMNCjPqCAiN4KxlyGAEKLsqdPPi1YkJ2ySRYN7FI8vgLGSYtQnWlaMV9vKq/mgZOg4ZiQJY8Jq3tZB9kwPBeIhphXHutVMx9olYH1/X+47GtO2VBxU3YKZU1ftiXf7TLlhZYHJ7EBcnwbAkK8kjybSE4ckQRQD6CHBgEfm9k/9AAnL+r80VCan2TqZ/qvPrVOwlKeWsw7YD78NpuRGE8bm2/B5ZxNvNO8ZIv0WH9dmw2mP50AkkD0lmUpXMfijd5mte5M+k/lnPu/MYkniM7fHbmLCa5d08FrwMtJXRLIQ8xbVcdCfadjc4h7oBRlrvb+RKbQPzzFKNpKPCi8i4FsRi9A7jsTLPB0pE9IHxoGE78auw7V7S4nvdNUGCyVMllBB5A7em/UelV3A98mWyUa+Mm62uRa8AggeDHNe1si+cADQXutP5xqS0PqA2mZ763/b379SPQj2dr7Va849n6pfJUVvVBrewx8UXvADZ3g4yn9m7ZrixEQT6uDbAdh5bBy0YwDTaNBjpT8b2dCliqcoIJaLOZiM3G3s4kMOnFSP/1M0e9NATUhsWUwmOJFmHFadPi5fPw25hFbBj3vKqg09Lw== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f701c556-07ac-428d-1861-08daf429c9bf X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jan 2023 23:15:54.1302 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: b7VQWYOn5+3L9DU7sd1Aowg88BivuWmATZiCBiC+n5uayybwdIwu95/ql57+lG9w4npIlXSTFWiocB00xxfENYP2I8xRMgCobDLMbR1vwgc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5878 T24gMTEvMDEvMjAyMyAxOjU3IHBtLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gTWFrZSBIVk09eSBy ZWxlYXNlIGJ1aWxkIGJlaGF2aW9yIHByb25lIGFnYWluc3QgYXJyYXkgb3ZlcnJ1biwgYnkNCj4g KGFiKXVzaW5nIGFycmF5X2FjY2Vzc19ub3NwZWMoKS4gVGhpcyBpcyBpbiBwYXJ0aWN1bGFyIHRv IGd1YXJkIGFnYWluc3QNCj4gZS5nLiBTSF90eXBlX3VudXNlZCBtYWtpbmcgaXQgaGVyZSB1bmlu dGVudGlvbmFsbHkuDQo+DQo+IFNpZ25lZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBz dXNlLmNvbT4NCj4gLS0tDQo+IHYyOiBOZXcuDQo+DQo+IC0tLSBhL3hlbi9hcmNoL3g4Ni9tbS9z aGFkb3cvcHJpdmF0ZS5oDQo+ICsrKyBiL3hlbi9hcmNoL3g4Ni9tbS9zaGFkb3cvcHJpdmF0ZS5o DQo+IEBAIC0yNyw2ICsyNyw3IEBADQo+ICAvLyBiZWVuIGluY2x1ZGVkLi4uDQo+ICAjaW5jbHVk ZSA8YXNtL3BhZ2UuaD4NCj4gICNpbmNsdWRlIDx4ZW4vZG9tYWluX3BhZ2UuaD4NCj4gKyNpbmNs dWRlIDx4ZW4vbm9zcGVjLmg+DQo+ICAjaW5jbHVkZSA8YXNtL3g4Nl9lbXVsYXRlLmg+DQo+ICAj aW5jbHVkZSA8YXNtL2h2bS9zdXBwb3J0Lmg+DQo+ICAjaW5jbHVkZSA8YXNtL2F0b21pYy5oPg0K PiBAQCAtMzY4LDcgKzM2OSw3IEBAIHNoYWRvd19zaXplKHVuc2lnbmVkIGludCBzaGFkb3dfdHlw ZSkNCj4gIHsNCj4gICNpZmRlZiBDT05GSUdfSFZNDQo+ICAgICAgQVNTRVJUKHNoYWRvd190eXBl IDwgQVJSQVlfU0laRShzaF90eXBlX3RvX3NpemUpKTsNCj4gLSAgICByZXR1cm4gc2hfdHlwZV90 b19zaXplW3NoYWRvd190eXBlXTsNCj4gKyAgICByZXR1cm4gYXJyYXlfYWNjZXNzX25vc3BlYyhz aF90eXBlX3RvX3NpemUsIHNoYWRvd190eXBlKTsNCg0KSSBkb24ndCB0aGluayB0aGlzIGlzIHdh cnJhbnRlZC4NCg0KRmlyc3QsIGlmIHRoZSBjb21taXQgbWVzc2FnZSB3ZXJlIGFjY3VyYXRlLCB0 aGVuIGl0J3MgYSBwcm9ibGVtIGZvciBhbGwNCmFycmF5cyBvZiBzaXplIFNIX3R5cGVfdW51c2Vk LCB5ZXQgeW91J3ZlIG9ubHkgYWRqdXN0ZWQgYSBzaW5nbGUgaW5zdGFuY2UuDQoNClNlY29uZGx5 LCBpZiBpdCB3ZXJlIHJlbGlhYmx5IDE2IHRoZW4gd2UgY291bGQgZG8gdGhlIGJhc2ljYWxseS1m cmVlDQoidHlwZSAmPSAxNTsiIG1vZGlmaWNhdGlvbi7CoCAoSXQgYXBwZWFycyBteSBjaGFuZ2Ug dG8gZG8gdGhpcw0KYXV0b21hdGljYWxseSBoYXNuJ3QgYmVlbiB0YWtlbiB5ZXQuKSwgYnV0IHdl J2xsIGVuZCB1cCB3aXRoIGxmZW5jZQ0KdmFyaWF0aW9uIGhlcmUuDQoNCg0KQnV0IHRoZSB2YWx1 ZSBpc24ndCBhdHRhY2tlciBjb250cm9sbGVkLsKgIHNoYWRvd190eXBlIGFsd2F5cyBjb21lcyBm cm9tDQpYZW4ncyBtZXRhZGF0YSBhYm91dCB0aGUgZ3Vlc3QsIG5vdCB0aGUgZ3Vlc3QgaXRzZWxm LsKgIFNvIEkgZG9uJ3Qgc2VlDQpob3cgdGhpcyBjYW4gY29uY2VpdmFibHkgYmUgYSBzcGVjdWxh dGl2ZSBpc3N1ZSBldmVuIGluIHByaW5jaXBsZS4NCg0KfkFuZHJldw0K From xen-devel-bounces@lists.xenproject.org Wed Jan 11 23:56:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 Jan 2023 23:56:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475753.737568 (Exim 4.92) (envelope-from ) id 1pFkxY-0007Ls-Cu; Wed, 11 Jan 2023 23:56:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475753.737568; Wed, 11 Jan 2023 23:56:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFkxY-0007Ll-AA; Wed, 11 Jan 2023 23:56:44 +0000 Received: by outflank-mailman (input) for mailman id 475753; Wed, 11 Jan 2023 23:56:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFkxW-0007Lf-Tm for xen-devel@lists.xenproject.org; Wed, 11 Jan 2023 23:56:42 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9685ab62-920b-11ed-91b6-6bf2151ebd3b; Thu, 12 Jan 2023 00:56:40 +0100 (CET) Received: from mail-bn7nam10lp2107.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.107]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 11 Jan 2023 18:56:34 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by PH0PR03MB6787.namprd03.prod.outlook.com (2603:10b6:510:123::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Wed, 11 Jan 2023 23:56:31 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5986.018; Wed, 11 Jan 2023 23:56:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9685ab62-920b-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1673481400; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=+wJnjP+gFDwTbENByDjE9DAEGhVAVwRyGY6u9OSpZ5g=; b=UKJHHSqVT3uhp1OIeSRXxkILm1WJv/zxAOZ5utZDsLiCDfyhJ2Ph+v5n k7a25Bjaeki9RMZ4+AtIWioErv4hUS6470OaTFvOisXNikb28YOwnm8RU QhQF5WzbRe4XPi+XH5/MJXSeX3En1BAyP655Ulyn9ih6h5wEjb30k5lfx I=; X-IronPort-RemoteIP: 104.47.70.107 X-IronPort-MID: 91686049 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:JtIO1KO0ShuUm83vrR2UlsFynXyQoLVcMsEvi/4bfWQNrUp21D1Vn GBLCDyBaareZGvzeop0boq19kMB6p/QnYAyHQto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQA+KmU4YoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvzrRC9H5qyo42tB5wVmPpingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0vdqCEN83 +ZAE25TVT7YvLuR64Khc9A506zPLOGzVG8ekldJ6GiBSNwAHtXESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+vJxujCMpOBy+OGF3N79U9qGX8hK2G2fo XrL5T/RCRAGLt2PjzGC9xpAg8eexH2rBtpORdVU8NZLvkyQ7EtKKSEHRGSbsfOdjGmuC/h2f hl8Fi0G6PJaGFaQZtv3UgC8oXWElgUBQNcWGOo/gCmdx6yR7wuHC2wsSj9adMdgpMIwXSYt1 FKCg5XuHzMHmKKRYWKQ8PGTtzzaETQUKEcSaClCShEKi+QPu6k2hxPLC9xlT6i8i4StHSmqm mjV6i8jm78UkMgHkb2h+kzKiC6toZ6PSRMp4gLQXSSu6QYRiJOZWrFEIGPztZ5oRLt1hHHY1 JTYs6ByNNwzMKw= IronPort-HdrOrdr: A9a23:2BHan6yAukz+po36jnSbKrPxaeskLtp133Aq2lEZdPU1SL3sqy nKpp906faaslYssQ4b6Ky90cW7IE80lqQFkrX5Q43SPjUO0VHAROtfBODZsl7d8kPFh4tgPa wJSdkANDWZZ2IXsS6QijPWLz7uquPrzImYwd77i1NRZUVSbadkhj0JeDpy0CdNNXd77V5SLu vt2iKDzQDQCEj/Ff7LYkUtbqz4vtjWk5CjSQcebiRXkTWmvHeT8bvnFBrd9QsfVj4n+8ZezU H11zbh47mlsbWdwhvRvlWjiKh+qZ/a095eA87JrNYTJi6EsHfPWK1RH4eauSwzoqWUyHtCqq i1nz4Qe/5r7m/XfCWOrQDz1xLG2DIjgkWSsmOwsD/YuMnkQzB/NMZbn4JedXLimjAdgO0= X-IronPort-AV: E=Sophos;i="5.96,318,1665460800"; d="scan'208";a="91686049" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OgP+NOhqtpBrg6HrrVxrdpTCBZRm6cLfGbDKnv84X+QZh8t74ztiC3nghUQDT3CymIg9HuP2x6ufEhw0R4KT5tT3PpZro2VgQkSHVGf8CoKyIRfj2dsPOjJNQiURk03Z2Z33yJAk1mxukjK0fu2icF1poD8PxkGc5X5o5c6MHKAbI/8IHJ+b3Ug/1jXPh6cTI7OC2pTEYE1w7L4qrrRbXnH5NCIt0dRGzH8+tjOSayBiqHgqwsiFXCD97zRVEjJWiU6mAiTrdFQK5ZMKSR+bhvGxIws1DCc2XvxIsCnAfsog81CQ1Nw03YCC7WZFYYFqAbqs4Vt9Wt4VpKEl4AK+qQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+wJnjP+gFDwTbENByDjE9DAEGhVAVwRyGY6u9OSpZ5g=; b=nCDVBh7j/hSdw0qXjE0if9FxhUOYgPYKX+JoZ0eJ71bUZpv0dhpLesG4Crj9rQ7mT1FVGcUNAQxH2rCsb2epZQc0/5onHoLyfFxKDdX7nGofzuEP2GbG+4Xn3yBcC4FIgQyrYEOXLEj97NhXf3w9ytGHHc9dleWEJ+1XP8fvPPQYAquGrK+ITuibmcLSgd/gung6c/QfBiSySSVknplVdd4WTRnqxgRbJoFGTe9QfwRQ9nJa5vyt+Tqf6BPIZD0TCqHUtC5zlk4gkr08lvmSck0iPvhnY07xSB7smFlfXWSfHpMx0t3+CizoGgdUdjNbTNYMnimDz6d27nfkel3aNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+wJnjP+gFDwTbENByDjE9DAEGhVAVwRyGY6u9OSpZ5g=; b=CVOmKgUbQ6coNqZ/g1IqCams8yCeHNv3Ol1KbP6niNAaJcdFGWbx+py/BTS6oFIhZLP4AM4Arbdey6cRVBjRwzav5rT/kht5rQJo51j3DqtVQNtkJR0/6VNogGq2y7LrZJ1MbgWyFwvpoAcXH2dyzGFkqZppCEXqyoG78lp64ns= From: Andrew Cooper To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Wei Liu , Roger Pau Monne , "Tim (Xen.org)" , George Dunlap Subject: Re: [PATCH v2 8/9] x86/shadow: call sh_detach_old_tables() directly Thread-Topic: [PATCH v2 8/9] x86/shadow: call sh_detach_old_tables() directly Thread-Index: AQHZJcSfDC5mFmcp2UCTS4rgBv7O2q6Z5R0A Date: Wed, 11 Jan 2023 23:56:30 +0000 Message-ID: <722642fa-4eb0-930a-9755-f7780da65eec@citrix.com> References: <8ed7a628-f64e-5512-efdb-4116a7b88a1d@suse.com> In-Reply-To: <8ed7a628-f64e-5512-efdb-4116a7b88a1d@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|PH0PR03MB6787:EE_ x-ms-office365-filtering-correlation-id: ca53f7d5-9d4f-42ba-de2a-08daf42f7634 x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nLeyYGoCqW9YYyZNVRHYQqv5g9xdq4sMOibRHYrm1WTaUuLmtSiC/zXhBwUpD/SduDJjg9A3Pqmm3Pwg78pe4m0KLvryONLinugKZhBLq+BCPLjyQUQlWFW3ADmXIxoHbYGLlTXbI/TMnM5jcUjkuFIB7ZvdH/LCjvGbno2NnEI8S3eFnAF6dHgM4Mok/BaHMopEQt5/XX80zWNxcjO0LL9rE2jFJtIaoPVXvd2Mp2DJ+EhKCqP5BNi+CfzROdlRSRyB7g7vwXg4yxAjcd6iptFXfDyKYCurPul2ZgQiaiPF+XVZR2yk3OU9UoSnCJdAYouYCXKvAzEE6YkyrlWK5j/ynOs1wRfhmSqAeDFE43uMmlQVVSMwqd+37TYPECUHj6PyrGQRFKGlmRtofMFhFm9vnZoc4f40jSUyCsIx4/ch7R4haegfS0liqcvDrd8gSejEkHMgRlFJh7akExwC5qr+OqOKU+bjztZwzw2OEW/OOYxvAlSKbuHtrtV54mYNo81pyAVa3qGV3QTtBtIIm1mE1SHNJctFhpQ+u4KqJKtqx+bFNEZihdMVs9fi3DeTNTppuIMuFt3SUdI0vpWFEMK8a+OtgVV0mIxnjx4bqaLG2TIgfUU6Hf4r7I9ml0bMWkRlLlFJlm447+TF0tR+VaZeYW3mdhwWgLCGwaC2/E9yf4HUR+QZqjdPsd1sh++Ts6ZNX/4iOq99PsEzQS0bhd5r6Lv+sH7gVvYwHWYcIa/fmG8t5VLQ1jMotMxVL1Nez2BPhP04RC/WevBig5EZJQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(366004)(39860400002)(396003)(376002)(136003)(451199015)(36756003)(38100700002)(186003)(8936002)(2906002)(91956017)(41300700001)(5660300002)(76116006)(66446008)(71200400001)(66476007)(64756008)(8676002)(66556008)(66946007)(316002)(4326008)(4744005)(38070700005)(110136005)(54906003)(122000001)(6512007)(26005)(2616005)(31686004)(31696002)(86362001)(478600001)(107886003)(82960400001)(53546011)(6506007)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?dXcrbXI2YTZtRlBycW1iR250UkRTMVNBaVcxZm03THgwUE9qcHJvaS9QRUNC?= =?utf-8?B?aU5lSXRGL210TjM0U0kwMUcwQ29Kd25kRzR0ejQ0WTBnNElqaGpPTlhDZm41?= =?utf-8?B?cDc0WEFnTVpDOXR2MHhXU0JpbTY5bDBKUXh6a3RSNnYxMWFRL2Mrd0xqYXI1?= =?utf-8?B?Z09MR29icHdqR0NNbVhCL2R5TWdXVGorQk9JLzBZc3V1SkZUYm1RT2VPWmdC?= =?utf-8?B?Wm5adDd1ZFNSdy82d1lMdk9RUlBBYmFxeW1tQlQxdFRHL3B1RlJsL2ViaW1n?= =?utf-8?B?cGx2V2xscnpqclIxU1poaHUzOFRNWXgzbHpLbVdVcVZCdE9DcTl5b0dZeTJ3?= =?utf-8?B?c3VWOTBGVW9nOFF1dDdwcjBQMWZUZU1XUXNlV0k5VGFhK3c0dndaN1JTZFZy?= =?utf-8?B?c2FEMURWQXNKMCthV05aUVN6OVBXTmx3Q1hLV3VuU2E3bFVjZHg2NE40NkJl?= =?utf-8?B?ZWRVMi92eURyQmxnVWo4Q3lhaVEvZE1mWEV0bGVaaHpyM2pNZlZYY292aE9j?= =?utf-8?B?RVFLemt1WlF1bS9STndnZ0ZkZEVCQ0xFZFdoM3ZpNmZ0T2FvYzRUKzRIRDd3?= =?utf-8?B?THVCZ1ZicXlnTVlEMU5lcmNPb2g5QUc5ZHJlVG5GU2RsZEdUSFVsc3JGaGcw?= =?utf-8?B?TGo2V2R3Q0kvMHdNckVhcERVeElENzVpR1JjY25jdjZxSzMzSkh3cTBaS1lK?= =?utf-8?B?T01xbzBrVlZhNFRDRXZvMXhLMjlzQ1dCYmEwbnZqa0dNeUIrK2kzSGhIT3d5?= =?utf-8?B?UVNPOGRxMExkR1MwdlNGNzFWRFdYMThEOTlwQkdISGRhYm5sZUNUZmh6QVhy?= =?utf-8?B?Ty9mWjV6Rm1sRGpxVFArcWttNTVwKzRNTWRmYXB5UGhwQk5yeGg1d2NlZk1R?= =?utf-8?B?NkcrdTBQZ2lLWm5ZZytEOVZVK2RhbkNxazVLY0dINHB2OERaTXE2TzczZ0lR?= =?utf-8?B?VUJXeEs1Umdpb3hnQUU0dmpJU01vSjJmTU1MRmRoUjJJYWFINkZWNXdxTUdR?= =?utf-8?B?VFViMHZ6V082RjI2Z3RBaUpva2tsYTM3UVJUVk1uRG5ZUVNsYjJzVEVWeW1M?= =?utf-8?B?bzZWY29FZGtGdHJIaStXU2luaVE3ZThleHR0RGJ3YVVXcVh2U3hZTnBPb3Vh?= =?utf-8?B?dVZUQUhURDZEQ29iaFVhSEhQTlIxc1JHYXp5UmxHSkhGdVMyOFNBTmlJMEh6?= =?utf-8?B?ZkVPSFdiMHdRRkZUUkR3QUJWVCtMbEIwckR3N3RDZ3ZiVTZjMHhyU3VVTHdi?= =?utf-8?B?NitQTDZSNnMzcmN3VFFYRDc5Sk1VdGU1dmswK3lBcVRhTmE4SFBrbEozUUZZ?= =?utf-8?B?eUp3VVE4MWZ4TXRJTjlEYVEvZHl4TDdXSllYMk4rc3Z4MkZCbzh3aGlKQ2tV?= =?utf-8?B?SFV0b2p5Q2xiSHVabGFtR1IrbytmWUhKMWtLN0hscFZTRE9VTzVhRWdkanl4?= =?utf-8?B?Q0s3UmNWU3NMZjR2OW0zcE0rbHhtekJ1cXVpSlRrb0loYmE3SHVkam1MU3Zr?= =?utf-8?B?eStFOEhUbkIxb1dHN09QTUVVVGxKSjBZQUV4TEh1WmRRc2F4eldWNHBPRVYz?= =?utf-8?B?YjJNV1lweWtrc0pVbjQ3WkE1RytwMStna3pKWDZTbldMMlJmNVpPUDltbWJO?= =?utf-8?B?UWhuenV0QXVYRFlQY29lR1hidkswTHpBM0JSd0pSakVGM3RQdFdCcS9aK3R5?= =?utf-8?B?TXR3amRZVGFuQ28vQ1ZpdTNOR1dzR1FzbHVENFFwbXoyRDBBWGR5azBXeUdH?= =?utf-8?B?QnVSVThpQXE0SEt2cGhBSzd5RXBaZExCeW5TTFVFK0oyLzJxRC9vQ0oraVRT?= =?utf-8?B?MnZ4MXNTRFRnaG1Ta2RkTFI4UWtxRVlQQk5JN0hNTVY1alYvclBPOG9xdlpn?= =?utf-8?B?MnlQU0ZJb0ZIVUszc1ZycXc3dmVIMkdTbEcwM250Wldjd21CSm5IVTgyTThG?= =?utf-8?B?NC9JWHhTYWxKMXVBTkltS2RhZTZJQk9sc0VEUWd6aVhoWUlRTE9MbnBjR252?= =?utf-8?B?aEJNdDRvSlNoejg3NjN4QnZrdzJsenYwNVVWcDI0RXV3cGRQV05PVjNLVmNq?= =?utf-8?B?Wm5hZWFrQWh2VUtvZlA3eEVFZTM1THUycUV3Z2Vua0V4T3JiOENsRFpkeHBB?= =?utf-8?Q?SOIVn433i6r5hK/+lr5nTe9hK?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: me3Q3rIj/HukUybZXzlIpKKu3YsSTdJIGeQZUfD25iXc2AIscICKM5hyGNwq9VCuJRpcXpJ6b69ff9NH8joOWOwfkXRUbas1G/A6DDp5Z77kbGHptvUjdkw+hBn+ddx/A+G+h4eKnBXg20si6nMr3ybGtAYdKk1M6f/EyQeno+SJx4aAlaQr7XC+IPBZLUT9M9Zhh4UlkxHJlxkwQuAsOGrZ4zmsMTQBz3li0hlOfw2zMj0CdWBWvDOJI8OQDbnqSeiP20mcfAgkgv5sdCgZ8DPmXW4PxuTouwY2zWiIGN/Q/1ksif8x9M+gpXrWwjeMt6Y8DWldru/kazVW4a1TNhtNARFWyH5haCRXwQXVHdFkd+OshISuox+k5d9Yjq7oRIhVIwvi2LIXG33roxjM9dQx9oW7frN3PeSUZpLpBj+orUkp/qe1F9cCLKaRKqkIELl7ztmwu+RwrgL2hCfPab851XgsBx8rgW9Jp1/Wva2vpHxjQZaZP1FufyPk5V95KO6W76je30zdJoaJqrxzF7bdL24yZiipjwLpJlvtLq+ZK0W20CF/0nC+CTH5Ji6PecuRvNeBeYvAXfPiMlySpfysTVjQm4pCpCBm1g8/A+MWwI+m9IrxyD6Fae60NpKQDMM0bx+QCQQkP2EgcBYdtMi0Q/pqXTL2Cjw2O0NGZpttSrmn3ZGojKFLqdZfCKr3LbUO6nZMRZeJLr6V4a2H0HK7N8qD5Yq3RFX9UMDHMK5EaejSg4K7KnVnCjL4jtCewsLaODlOpqZ+LD6IiiEHzp19hy6f8WvxIN/hNU9Qv2hzN4lIEItbd1l9Xsb0Twppbrkz2+/mzGql54CeOzPp+A== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ca53f7d5-9d4f-42ba-de2a-08daf42f7634 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jan 2023 23:56:30.9538 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5BlEYfbHA88gYfQJLSSlsDXfD+ScFyjYq0/eE4VuHoP5RfIJyqL4xwZXn4zR2C0Z9GelYm/Y5s9mUBpotMvS3NqG7BEkY1opndtlm/0M4ZM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6787 T24gMTEvMDEvMjAyMyAxOjU3IHBtLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gLS0tIGEveGVuL2Fy Y2gveDg2L21tL3NoYWRvdy9jb21tb24uYw0KPiArKysgYi94ZW4vYXJjaC94ODYvbW0vc2hhZG93 L2NvbW1vbi5jDQo+IEBAIC0yMjY0LDYgKzIyNjQsMjkgQEAgdm9pZCBzaGFkb3dfcHJlcGFyZV9w YWdlX3R5cGVfY2hhbmdlKHN0cg0KPiAgICAgIHNoYWRvd19yZW1vdmVfYWxsX3NoYWRvd3MoZCwg cGFnZV90b19tZm4ocGFnZSkpOw0KPiAgfQ0KPiAgDQo+ICsvKg0KPiArICogUmVtb3ZlcyB2LT5h cmNoLnBhZ2luZy5zaGFkb3cuc2hhZG93X3RhYmxlW10uDQo+ICsgKiBEb2VzIGFsbCBhcHByb3By aWF0ZSBtYW5hZ2VtZW50L2Jvb2trZWVwaW5nL3JlZmNvdW50aW5nL2V0Yy4uLg0KPiArICovDQo+ ICtzdGF0aWMgdm9pZCBzaF9kZXRhY2hfb2xkX3RhYmxlcyhzdHJ1Y3QgdmNwdSAqdikNCj4gK3sN Cj4gKyAgICBzdHJ1Y3QgZG9tYWluICpkID0gdi0+ZG9tYWluOw0KPiArICAgIHVuc2lnbmVkIGlu dCBpOw0KPiArDQo+ICsgICAgLy8vLw0KPiArICAgIC8vLy8gdmNwdS0+YXJjaC5wYWdpbmcuc2hh ZG93LnNoYWRvd190YWJsZVtdDQo+ICsgICAgLy8vLw0KDQpIb25lc3RseSwgSSBkb24ndCBzZWUg d2hhdCB0aGUgcG9pbnQgb2YgdGhpcyBjb21tZW50IGlzIGF0IGFsbC7CoCBJJ2QNCnN1Z2dlc3Qg anVzdCBkcm9wcGluZyBpdCBhcyB5b3UgbW92ZSB0aGUgZnVuY3Rpb24sIHdoaWNoIGF2b2lkcyB0 aGUgbmVlZA0KdG8gZGViYXRlIG92ZXIgQysrIGNvbW1lbnRzLg0KDQpQcmVmZXJhYmx5IHdpdGgg dGhpcyBkb25lLCBBY2tlZC1ieTogQW5kcmV3IENvb3Blcg0KPGFuZHJldy5jb29wZXIzQGNpdHJp eC5jb20+DQo= From xen-devel-bounces@lists.xenproject.org Thu Jan 12 00:00:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 00:00:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475759.737579 (Exim 4.92) (envelope-from ) id 1pFl0r-0000jr-53; Thu, 12 Jan 2023 00:00:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475759.737579; Thu, 12 Jan 2023 00:00:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFl0r-0000jk-1Z; Thu, 12 Jan 2023 00:00:09 +0000 Received: by outflank-mailman (input) for mailman id 475759; Thu, 12 Jan 2023 00:00:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFl0p-0000ja-OP; Thu, 12 Jan 2023 00:00:07 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFl0p-0007P2-Lu; Thu, 12 Jan 2023 00:00:07 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFl0p-0000DM-FB; Thu, 12 Jan 2023 00:00:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pFl0p-0005w0-El; Thu, 12 Jan 2023 00:00:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=7T4Q/NA4yHfN+17zHXeamo+yuPewB09SghTmA12euNo=; b=Q6IJpFKYQdPY9h3jfrklyTLNX9 KhJjBC+8Rbi4ph2/ihQocRUk1fpQASF1RDrv1LDYPF4DyRl68+xFdo2gifbsx/SuBtFhE2H8E7//T 5an9y+MuQP1R16rJnS1TgvOcLzyjyupzYWhiP1sG7jxTmyKK0j3bmHvHxQtbzyQ8h/Q4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 175729: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-amd64-xsm:xen-build:fail:regression qemu-mainline:build-amd64:xen-build:fail:regression qemu-mainline:build-i386:xen-build:fail:regression qemu-mainline:build-arm64-xsm:xen-build:fail:regression qemu-mainline:build-i386-xsm:xen-build:fail:regression qemu-mainline:build-arm64:xen-build:fail:regression qemu-mainline:build-armhf:xen-build:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-coresched-amd64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:build-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-rtds:build-check(1):blocked:nonblocking qemu-mainline:build-arm64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking qemu-mainline:build-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking qemu-mainline:build-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-dom0pvh-xl-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-dom0pvh-xl-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvshim:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-pygrub:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvhv2-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-freebsd11-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-freebsd12-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvhv2-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-multivcpu:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: qemuu=aa96ab7c9df59c615ca82b49c9062819e0a1c287 X-Osstest-Versions-That: qemuu=0ab12aa32462817f0a53fa6f6ce4baf664ef1713 From: osstest service owner Date: Thu, 12 Jan 2023 00:00:07 +0000 flight 175729 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/175729/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 175623 build-amd64 6 xen-build fail REGR. vs. 175623 build-i386 6 xen-build fail REGR. vs. 175623 build-arm64-xsm 6 xen-build fail REGR. vs. 175623 build-i386-xsm 6 xen-build fail REGR. vs. 175623 build-arm64 6 xen-build fail REGR. vs. 175623 build-armhf 6 xen-build fail REGR. vs. 175623 Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-win7-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ws16-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-shadow 1 build-check(1) blocked n/a test-amd64-i386-xl-vhd 1 build-check(1) blocked n/a test-amd64-i386-xl-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) blocked n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) blocked n/a test-armhf-armhf-xl-rtds 1 build-check(1) blocked n/a test-armhf-armhf-xl-vhd 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-amd 1 build-check(1) blocked n/a test-amd64-i386-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-i386 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-amd64 1 build-check(1) blocked n/a test-amd64-coresched-i386-xl 1 build-check(1) blocked n/a test-amd64-coresched-amd64-xl 1 build-check(1) blocked n/a test-amd64-amd64-xl-xsm 1 build-check(1) blocked n/a build-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-shadow 1 build-check(1) blocked n/a test-amd64-amd64-xl-rtds 1 build-check(1) blocked n/a build-arm64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ws16-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a build-armhf-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-amd64-dom0pvh-xl-amd 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 1 build-check(1) blocked n/a test-amd64-amd64-dom0pvh-xl-intel 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvshim 1 build-check(1) blocked n/a test-amd64-amd64-pair 1 build-check(1) blocked n/a test-amd64-amd64-pygrub 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvhv2-intel 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-freebsd11-amd64 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-freebsd12-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvhv2-amd 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-nested-amd 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-nested-intel 1 build-check(1) blocked n/a test-amd64-amd64-xl-multivcpu 1 build-check(1) blocked n/a test-amd64-amd64-xl 1 build-check(1) blocked n/a test-amd64-amd64-xl-credit1 1 build-check(1) blocked n/a test-amd64-amd64-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 1 build-check(1) blocked n/a test-armhf-armhf-xl-arndale 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-intel 1 build-check(1) blocked n/a test-amd64-i386-xl 1 build-check(1) blocked n/a test-amd64-i386-xl-pvshim 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a version targeted for testing: qemuu aa96ab7c9df59c615ca82b49c9062819e0a1c287 baseline version: qemuu 0ab12aa32462817f0a53fa6f6ce4baf664ef1713 Last test of basis 175623 2023-01-07 23:09:00 Z 4 days Failing since 175627 2023-01-08 14:40:14 Z 3 days 18 attempts Testing same since 175654 2023-01-09 18:08:58 Z 2 days 13 attempts ------------------------------------------------------------ People who touched revisions under test: Ard Biesheuvel Bernhard Beschow Christian Borntraeger Cindy Lu Dongli Zhang Eugenio Pérez Greg Kurz Guoyi Tu Hyman Huang(黄勇) Igor Mammedov Jason Wang Jonathan Cameron Kai Huang Laszlo Ersek Lei Xiang leixiang Liuxiangdong Longpeng Lubomir Rintel Marc-André Lureau Markus Armbruster Michael S. Tsirkin Nikita Ivanov Paolo Bonzini Peter Maydell Philippe Mathieu-Daudé Richard Henderson Thomas Huth Yanan Wang Yicong Yang Zeng Chi jobs: build-amd64-xsm fail build-arm64-xsm fail build-i386-xsm fail build-amd64 fail build-arm64 fail build-armhf fail build-i386 fail build-amd64-libvirt blocked build-arm64-libvirt blocked build-armhf-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl blocked test-amd64-coresched-amd64-xl blocked test-arm64-arm64-xl blocked test-armhf-armhf-xl blocked test-amd64-i386-xl blocked test-amd64-coresched-i386-xl blocked test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm blocked test-amd64-i386-xl-qemuu-debianhvm-i386-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm blocked test-arm64-arm64-xl-xsm blocked test-amd64-i386-xl-xsm blocked test-amd64-amd64-qemuu-nested-amd blocked test-amd64-amd64-xl-pvhv2-amd blocked test-amd64-i386-qemuu-rhel6hvm-amd blocked test-amd64-amd64-dom0pvh-xl-amd blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64 blocked test-amd64-i386-xl-qemuu-debianhvm-amd64 blocked test-amd64-i386-freebsd10-amd64 blocked test-amd64-amd64-qemuu-freebsd11-amd64 blocked test-amd64-amd64-qemuu-freebsd12-amd64 blocked test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked test-amd64-amd64-xl-qemuu-win7-amd64 blocked test-amd64-i386-xl-qemuu-win7-amd64 blocked test-amd64-amd64-xl-qemuu-ws16-amd64 blocked test-amd64-i386-xl-qemuu-ws16-amd64 blocked test-armhf-armhf-xl-arndale blocked test-amd64-amd64-xl-credit1 blocked test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 blocked test-amd64-amd64-xl-credit2 blocked test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 blocked test-armhf-armhf-xl-cubietruck blocked test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict blocked test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict blocked test-amd64-i386-freebsd10-i386 blocked test-amd64-amd64-qemuu-nested-intel blocked test-amd64-amd64-xl-pvhv2-intel blocked test-amd64-i386-qemuu-rhel6hvm-intel blocked test-amd64-amd64-dom0pvh-xl-intel blocked test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu blocked test-armhf-armhf-xl-multivcpu blocked test-amd64-amd64-pair blocked test-amd64-i386-pair blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim blocked test-amd64-i386-xl-pvshim blocked test-amd64-amd64-pygrub blocked test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds blocked test-armhf-armhf-xl-rtds blocked test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow blocked test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow blocked test-amd64-amd64-xl-shadow blocked test-amd64-i386-xl-shadow blocked test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd blocked test-amd64-i386-xl-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2556 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Jan 12 00:02:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 00:02:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475768.737590 (Exim 4.92) (envelope-from ) id 1pFl3A-0001Z9-NZ; Thu, 12 Jan 2023 00:02:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475768.737590; Thu, 12 Jan 2023 00:02:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFl3A-0001Z2-Kg; Thu, 12 Jan 2023 00:02:32 +0000 Received: by outflank-mailman (input) for mailman id 475768; Thu, 12 Jan 2023 00:02:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFl3A-0001Yu-3C for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 00:02:32 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 66ab9fb2-920c-11ed-b8d0-410ff93cb8f0; Thu, 12 Jan 2023 01:02:29 +0100 (CET) Received: from mail-mw2nam10lp2107.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.107]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 11 Jan 2023 19:02:26 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by PH0PR03MB5685.namprd03.prod.outlook.com (2603:10b6:510:42::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Thu, 12 Jan 2023 00:02:25 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5986.018; Thu, 12 Jan 2023 00:02:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 66ab9fb2-920c-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1673481749; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=c3iDwnezfMF+ULW9BNrpEmhodULbQKYQwOVb7MiOsC8=; b=R0VkhXTNH7xwM//h2vSO1p/HsQ2UpYsPhDs8uvnNX2XKq350Z98sZa87 XaT7HCn58ADQKCRoiJAKUZfJZWJqw5VcrEYywgdNBKlegp3YvIrreDu1s gqM84ZUcVoT5NpSevDF6RwOZlo7CULNVlWZ0/3yyiSbnB4nQT+Ebl9TOx o=; X-IronPort-RemoteIP: 104.47.55.107 X-IronPort-MID: 92208154 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:R+DA36P2BGaixafvrR2UlsFynXyQoLVcMsEvi/4bfWQNrUok1zdVz DcfDDyHafeOZjOgfo12YY3jpxgAuJOGndNnTQto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQA+KmU4YoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvzrRC9H5qyo42tB5wVmPpingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0sdPGVlu1 /EpEwIuaReZl9uw0oqWTNA506zPLOGzVG8ekldJ6GiBSNMZG9XESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+PdxujCMpOBy+OGF3N79U9qGX8hK2G2fo XrL5T/RCRAGLt2PjzGC9xpAg8eex3mjCNtPSNVU8NZm2Qy06DYzVSYncmedqsW7kFyGBtx2f hl8Fi0G6PJaGFaQZtv3UgC8oXWElgUBQNcWGOo/gCmdx6yR7wuHC2wsSj9adMdgpMIwXSYt1 FKCg5XuHzMHmKKRYWKQ8PGTtzzaETQUKEcSaClCShEKi+QPu6k2hxPLC9N8Sqi8i4StHSmqm mjV6i8jm78UkMgHkb2h+kzKiC6toZ6PSRMp4gLQXSSu6QYRiJOZWrFEIGPztZ5oRLt1hHHb1 JTYs6ByNNwzMKw= IronPort-HdrOrdr: A9a23:AxAW0Kxvakbs1UI523JmKrPw1r1zdoMgy1knxilNoHxuH/BwWf rPoB17726RtN91YhsdcL+7V5VoLUmzyXcX2/h1AV7BZniEhILAFugLgbcKqweKJ8SUzJ8+6U 4PSclD4N2bNykGsS75ijPIb+rJFrO8gd+VbeS19QYScelzAZsQiDuQkmygYzZLrA8tP+teKL OsovBpihCHYnotYsGyFhA+LpL+T42iruOeXfYebSRXkDWzsQ== X-IronPort-AV: E=Sophos;i="5.96,318,1665460800"; d="scan'208";a="92208154" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hBxTqiNseKxi3Rb3bHnLcJnmemaAW6Vy14J0lgBniSDNKEY8Eia5I9kb7Biq2iK6X5wuL4NkdlGbNeY8Li2IaE2Pa6iyxmc6fKT5itA5H8p4Z48pPiU4hxxNNQZsSu88ZpbuTpx3CCDUuaRgmNSe0H3smchguFCj63rS5DUWYGjOl3vYKbLMT6ox6Sp6au8ZnWo1F5GhKUg61pv5vqQa5OfMVoKeKydeYMBNBKctQVLcRlugFAWdDJJAna+axp8bz0F11fK9xv2FVgpdoalw//cfg/DKWzXXGCEdepxlguffLH9UEe8MjeJKbzGlItSSfUGMRsVISvZb+nmEkc25aQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c3iDwnezfMF+ULW9BNrpEmhodULbQKYQwOVb7MiOsC8=; b=GK6FcTleryCOEQZtvKX3dbEOde2B6dVCRvwSKBAVbggtWzqagsoHwvwiSUQAZs3JY8BSQjgNgUV+HMs/mfV89b6DRuoS6QZwxlIk9Xvdw5xHnb9hddT/NSqjQEVjq4Q6bxAJVDmbRzU9zO0rX+quxdznoYmltB6cO+z1aDsRIRovDfuI0di+7ny31iND9rtWYyAw/+msj0mBcLFGrfAOihW4VrVR9VnyVJkTwFBlwdz++n4RE6aIpla9AH2HZWd/ikPCQVwtaKzqUmbrKtFhXzClkDuwjtisPJFGbaYsifhD29W+CfYkNV1uLLW0k8ZCb9nW6fAUninvKXf2wZ99GQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c3iDwnezfMF+ULW9BNrpEmhodULbQKYQwOVb7MiOsC8=; b=wBVTnHekgCJkCtPAiy/4pXz/+HwevUsLSOWw5cVoJdkfirKGB/zXgGCwwr3y9v6OQdDB+wPDph6DBAQEH7CcACJjSS+6FJvYjKEnGYwEEB5nPISAFH/sy32xsDYrmvtWhyLikJ/PeBjesyuok6ppVjHZEeA6AFzm1THTR+jiAvY= From: Andrew Cooper To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Wei Liu , Roger Pau Monne , "Tim (Xen.org)" , George Dunlap Subject: Re: [PATCH v2 7/9] x86/shadow: reduce effort of hash calculation Thread-Topic: [PATCH v2 7/9] x86/shadow: reduce effort of hash calculation Thread-Index: AQHZJcSKbn2Oy+OF1EuP+6uJ3eHPoq6Z5sMA Date: Thu, 12 Jan 2023 00:02:24 +0000 Message-ID: <28488645-1cf7-cb9b-ca03-f060f7947156@citrix.com> References: <4785b34b-2672-e3a8-8096-df1365b6b7b8@suse.com> In-Reply-To: <4785b34b-2672-e3a8-8096-df1365b6b7b8@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|PH0PR03MB5685:EE_ x-ms-office365-filtering-correlation-id: 1001df52-2a13-4c49-9cfb-08daf430491b x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: oCCOWOH52K1U7Usk3e1wfph8E5ezYKfJvxrjxhS5bohK0izIQ9jy0CWqYjSHMPPNfzFW6cpX8PH9e4/JZBrZ0wSGPskIzX5ettypmnVlPHLDl0Kx4W9uDcwD2BQPjXCz2WMf4uTQauzn85zIKLxk3gPvvjFMw1cuC53d9gfo9/GarxHe4ijsS+54BGBY0fkgwW0hA7QYySebbIDQHfJ1JkADaKoh8WUTK9rcMOioTZtPbw2+uxT1AvM3+uCjvTnhEA+y/nobC0a4+vanp4gEhk8dCbQ1cj1p3x5WJtibJhmNANt5rCj/vdmVcsybDCu7gFEPYu932pOEqQ1uEPlcqe3nocEl1Kd7PAdbPqlXxp7+4aQq69X5V7hQlBtjxKxv07ibMkY9ykGRVccLCWll1LUmxBdwPAWuc87fKTHElLZxTL6HZ+LmUxDhzW67S/6RhwwfbWKvNabdczsxp4p8fZULObCeZHcYxLnffVY95AMpVnar6SgqlMcKWTfD5oG1LBMrhx+knDoVA9vLkJCJyJHFg+C2uuWl96rZ801dZzFkI68QopX9th1X10JrQEfKYaVxdJiT/rywbmbdkRY99KYjdTpphC7z+k//bSHfaXIjDSRJB3VNhf1wMtCCppzZ1Z4RhY+nRFtEhY85ErpyJm5y4Pvh6XHZGDYbYMOJ+K8Fi0yFLF/1nL/LQAw92+JIvqn9sjSyy2GrQ3FtQBwdzw6FUutnrsTOMBskBxW2i13QL7owkh1lCxuff5v19Tb+WqNCV+DXXup8QqDQ+Axx4w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(376002)(39860400002)(366004)(396003)(451199015)(66946007)(64756008)(110136005)(2616005)(36756003)(4326008)(41300700001)(316002)(8676002)(66556008)(66476007)(76116006)(66446008)(86362001)(38070700005)(31696002)(4744005)(8936002)(122000001)(38100700002)(5660300002)(54906003)(82960400001)(91956017)(6486002)(2906002)(71200400001)(6506007)(6512007)(53546011)(31686004)(478600001)(186003)(26005)(107886003)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?cnV4MmlIQnc1eG1nT2YyOXFjS3ZWQzRUbEw0YVh1R3ZIWXBjcDFqOFNGMGp6?= =?utf-8?B?aVQ3MnNtVXoyTC94K2NXNkUwMk42UG12ZStBYnJ3RDB0U1prNEdGSkZ6QVZH?= =?utf-8?B?cmY4T3ZSZEcwUUJjYkR2WnhrbUZHaHdFRWU0WFA1YVN5T0lsM3dBcTdyVDh3?= =?utf-8?B?WE5RQkwxcDMyZmdFdE5JUnJyMkF1NUVMT1IwVnZDcFA4NWpKQW1jZzdCM3Zz?= =?utf-8?B?YnZnK1FReEppVXRjTHJ5VXYxVUJvajB2ODFEMk1TOUNoenZVVEdRdGcyWFF5?= =?utf-8?B?TEFjdFhiZEZ3b2tKbDRWZ1RsaTN6Q2pISVhhS3JLcEJQVlFDdEdoTEFjTkpr?= =?utf-8?B?ZjFodVdBZHhQc05KOWpuaCt0dTFoZmtSbmkxNmlya1YzK3dEVC90aUp2V29a?= =?utf-8?B?ZTZ4Rmh3eHNWOWRtNG1vbm8zWjFRVkwwTUhMOWtqaE9iMUpybUdPNGcvS0Fi?= =?utf-8?B?V0I5TDIrSDdlZlBhVHdVV2NTazA0c1FUdXN5QlJUbzNUeWVpbFZyd2F3U0pC?= =?utf-8?B?em0zbzZmL0h4YTRUK1M5ZVBQdTFyU2ZzaGh6WDBsU09tZHhrZGtkN290KzF3?= =?utf-8?B?K2tYRmFxWllFSDNQb2t3R2l2MytTL3pnY2psekdrdm4zalBXUXdZUG1JOG1I?= =?utf-8?B?K3owbm4wUGJZNkNBZTJwZ2MyNXIyaVhBemFHYmcxWis0RFMzM1h2R1BlREN2?= =?utf-8?B?akJOVzJMcFFEVTFreDg0VHJ0bDN1QkpVUjY4aG8ySUVlTmZscDQ2QWJUdG5N?= =?utf-8?B?cUhyNjdzUE1UNkFEUnFkZWJVS1ZmRFBIOENLUkJlTk9LSFBtZWJveFF2MUtV?= =?utf-8?B?SVNWQ2dvNG9zbUNWSTBNZk5FeEE0WTlWS3VOMUMvcmsrTmpYemF2N2h3WVcv?= =?utf-8?B?SXlYcnNZYUtWRXY4bnR6UXdUMXNDV05obEQ2bzBQN0dxMjNCeGJhTWpNM2Jo?= =?utf-8?B?Qm1CMDR5OXdnMG9UU01GYWV2dXhOSlozUVJKMHFxa21COHJIWU1XSXdKaUNH?= =?utf-8?B?NkFwWTc5N2NMeDhWdzBZYXQ5WGtSYmZWSnBmV002N29QSE1yeHFPNlg4MnFB?= =?utf-8?B?OEpLL1BCVFFEb2ordzRzdmdqTE1KSHhKZ1JRQklQRUlkWVpDN1ZHQ01XWmFk?= =?utf-8?B?U010Qm5kWVpIVk5YVkoyck94WTcvWDNGR0FGa3VBcTlCUlhpZ0k3OTl2UzV3?= =?utf-8?B?amU0eVhqVUI1WFd2OUdQZ3lwQmY2Q0hZWmRyN0dBZ21WcytjZU5GTlhTSGtt?= =?utf-8?B?dWorSU9HOXhtUm1zOWJLTGlOVHlyYkZRRTd5cHJkeDR5ZWthODJPbVNKWmNQ?= =?utf-8?B?NUlJQkh0TUs5SktvMURaSkI0L0NxdFVSbTJ6NGljQVBHWDdZTDJmSWk2MXdF?= =?utf-8?B?c1ZDRWd4YTU3SVQyWC9pRUdTT2l2TjdjNjFVS2ZoOHNTMnJrUWx2V0RhR0d3?= =?utf-8?B?eGhTY3ltT3pKNm56NU91TkUwTW5UZ3I3dnNQUG05VktWUFJORTBiR0w2bUsw?= =?utf-8?B?QWxDWmJFRjJJUFdXN3VLclcxR2JlQ1U1RFV4UGFudGxJT3BITkJmNzhJTGVG?= =?utf-8?B?ZUs4RFNqamhTcDVVQ0dGUXVQNDAzbFdjWkt6L0JCTU1CNFFkVUtqaXcxVytK?= =?utf-8?B?c1NJbk9VOGlBRHBtYnM2ZlpPV3ozaEx5UHVENWpYZW4wbDRScCtHT1Fqd2Ju?= =?utf-8?B?a1VHWHhHdmU1NThaSzBYeEVoaDV4YXVtYWF6dHl2d0ZLZHYzeVdVNVczbzYx?= =?utf-8?B?WEgvRzRIbDJGS2tId2FXUHZHaHdIUUZ3UURUbGVUV1JmdEJmeVJkMy9sd013?= =?utf-8?B?V3ozUnFsYVlEK2RWR2oxSE9neTB4THJiaHNNS1NDTmZ2YlYzMFlJWEFuVzZx?= =?utf-8?B?YTVjNzRQVVBkd0h0V2VKMXFvUlZRNlZvTmRSY2dPVXBjOEVQMlByTWZHMEV3?= =?utf-8?B?VVljZUNySlJKbGkrYWVXdXdmRGpRb2JUTnJPTkg0TVkwRkwxMUtaS01pR1BH?= =?utf-8?B?UDhtN2ZJejR6cXJKNFF4QUltZ2QvT0g4aTdFcmwxbGFYNHZGTFQyNHpvQXgz?= =?utf-8?B?bHlPa2FBakp3N2tUcWNvYnV0K2FZQzJHSGkwYlBMSTd0ZXdvcDJKWDB2cWRp?= =?utf-8?Q?3c1LPIujqc/aEbEYoPzXyYCf1?= Content-Type: text/plain; charset="utf-8" Content-ID: <82E358E44FF7894CB3C2763FDBE6DCA3@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: TLbZiH43vNJBNjSgp3zTAvPCoTZ/CjbrqzKiPqhSDrJPnC9iVlQmeQ356WCLkc+oSqqxIkVnhsIwW8qbNcZsPzarGf4zdSYXIWSx/NdAinc8+vOSYB/ymSWleGtcHH79o1BafrRnJ158JVw1yLHDLi8rwWZM4rrMTP1hT9sCV3YRJkNUaHkFYQD55dsWxM08LVd1JZbfg6oNLBT+XJRAAhROfSZQgWRJvsYC8prcJEk+4x/W/CmFJUotTgFiV2O9O4hur504rCCFA15Q3DyhCdaNooWTNRH/eGBEsRFBcSvu/egIYCw9vb6o9h21GaOy6Y4gJUyBxeDoXx+VZ4mTMOcEzd2SN/G1WCxRMzXNWRZa4ayyrASO+98ucsN3wpiljySjnX4EIzP8Pi8hwEheJhyLCIqG/ZQEo/wUE7spRAI+uWSSYzZiR4oR9o/deblpUbjibm+ndBjgq2X0Ld3EBm5b9KA9KJdOnwA8QFcLP6g5oN+hh9G9BqWqR2lfmec54Q1yR3rHJXVEcGRbXrPpQRP1ffSw7eEdhBbI91jPaPAab5edQfan6pvLJecaNUH2kr1BvQ6JeTKn9UoAf0ABsW5eJ5U3fFO2Py5UpPEZQ8ck0cnHtJUNW+wGfhVRh+Gui0/tf96ynQESBf/kyJX+0O8PRrdvVRCTflHn6EOAfY4EbPzMt6TL3mTL1OUpCqJRYq/LMlQzLuFurCyfWZR9beraprGFuhY64O2QydSIvjFSqj9N0UUXD+C/aUD0roSARz6WujqLUixLmCmwhFE+vI6A9w8kZQL4JWwap++MSXus/koktWb0k+wrSNzV05kWfthiGpMzYl2nDMyjxsBVHw== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1001df52-2a13-4c49-9cfb-08daf430491b X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jan 2023 00:02:24.7875 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EY027ciF4+8mTfK/wipN2e4uLaIAs7wNwE/HETKH27VEh9RS6zm9Pf7OqpO+p2OoZ06fEUDaD2tjerjFB7p1Hk+0onY1BdvNWt92phpUplA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5685 T24gMTEvMDEvMjAyMyAxOjU2IHBtLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gVGhlICJuIiBpbnB1 dCBpcyBhIEdGTi9NRk4gdmFsdWUgYW5kIGhlbmNlIGJvdW5kZWQgYnkgdGhlIHBoeXNpY2FsDQo+ IGFkZHJlc3MgYml0cyBpbiB1c2Ugb24gYSBzeXN0ZW0uIFRoZSBoYXNoIHF1YWxpdHkgd29uJ3Qg aW1wcm92ZSBieSBhbHNvDQo+IGluY2x1ZGluZyB0aGUgdXBwZXIgYWx3YXlzLXplcm8gYml0cyBp biB0aGUgY2FsY3VsYXRpb24uIFRvIGtlZXAgdGhpbmdzDQo+IGFzIGNvbXBpbGUtdGltZS1jb25z dGFudCBhcyB0aGV5IHdlcmUgYmVmb3JlLCB1c2UgUEFERFJfQklUUyAobm90DQo+IHBhZGRyX2Jp dHMpIGZvciBsb29wIGJvdW5kaW5nLiBUaGlzIHJlZHVjZXMgbG9vcCBpdGVyYXRpb25zIGZyb20g OCB0byA1Lg0KPg0KPiBXaGlsZSB0aGVyZSBhbHNvIGRyb3AgdGhlIHVubmVjZXNzYXJ5IGNvbnZl cnNpb24gdG8gYW4gYXJyYXkgb2YgdW5zaWduZWQNCj4gY2hhciwgbW92aW5nIHRoZSB2YWx1ZSBv ZmYgdGhlIHN0YWNrIGFsdG9nZXRoZXIgKGF0IGxlYXN0IHdpdGgNCj4gb3B0aW1pemF0aW9uIGVu YWJsZWQpLg0KDQpJJ20gbm90IHN1cmUgdGhpcyBmaW5hbCBiaXQgaW4gYnJhY2tldHMgaXMgcmVs ZXZhbnQuwqAgSXQgd291bGRuJ3QgYmUgb24NCnRoZSBzdGFjayB3aXRob3V0IG9wdGltaXNhdGlv bnMgZWl0aGVyLCBiZWNhdXNlIEFCSS13aXNlLCBpdCB3aWxsIGJlIGluDQolcnNpLg0KDQpJJ2Qg anVzdCBkcm9wIGl0Lg0KDQo+DQo+IFNpZ25lZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGlj aEBzdXNlLmNvbT4NCg0KUmV2aWV3ZWQtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIz QGNpdHJpeC5jb20+DQo= From xen-devel-bounces@lists.xenproject.org Thu Jan 12 00:05:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 00:05:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475774.737601 (Exim 4.92) (envelope-from ) id 1pFl65-0002Bz-6l; Thu, 12 Jan 2023 00:05:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475774.737601; Thu, 12 Jan 2023 00:05:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFl65-0002Bs-2z; Thu, 12 Jan 2023 00:05:33 +0000 Received: by outflank-mailman (input) for mailman id 475774; Thu, 12 Jan 2023 00:05:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFl63-0002Bm-VH for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 00:05:31 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d20d7956-920c-11ed-b8d0-410ff93cb8f0; Thu, 12 Jan 2023 01:05:29 +0100 (CET) Received: from mail-bn8nam11lp2168.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 11 Jan 2023 19:05:26 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by PH7PR03MB7048.namprd03.prod.outlook.com (2603:10b6:510:2b2::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Thu, 12 Jan 2023 00:05:23 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5986.018; Thu, 12 Jan 2023 00:05:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d20d7956-920c-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1673481929; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=IWEE+Uk224L1EzdZRWsnZkazNqZOt00zjoy/L5ND+Ss=; b=CaSDizayGBXMEqU8KtvkHK+S5sDwwmxmJeG4z62vSJJAHKjPK8/4Cj3i lSQ63w4bNOLHDUp+uYEX0aydS0teQ3HmPzWaFMfLj/gahv9PgkNmqVLT8 nhayXchpVvfoy1DVP9uQi6roXBvtCggGRu+l0gAGJBlM0mf3KQapDn2rR E=; X-IronPort-RemoteIP: 104.47.58.168 X-IronPort-MID: 92208481 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:VqW9x6txAoi4ss8uU65vrW5c5OfnVGZfMUV32f8akzHdYApBsoF/q tZmKTzVaPbZamL9LdFzaY/n9R8FvMPQzoBkTgA/rnpjQnsU+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg0HVU/IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj5lv0gnRkPaoQ5AaHziFOZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwOS0rQ069vPCN8JWHT7Fv2ZQ8LM/xI9ZK0p1g5Wmx4fcOZ7nmGvyPz/kImTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osgP60boq9lt+iHK25mm6xo G7c8nu/KRYdLNGFkhKO8262h/+JliT+MG4XPOzirKY63A3KroAVIEYZCHSy8PaJtm23C+NAc EkYpW0tq7dnoSRHSfG4BXVUukWsvBQRRt5RGO0S8xyWx+zf5APxLngJSHtNZcIrsOcyRCc2z RmZktXxHzttvbaJD3WH+d+8sjeaKSUTa2gYakcsUQoAy8nupsc0lB2nczp4OKu8j9mwEzegx TmP9XE6n+9K055N0Lin91fahT7qvoLOUgM++gTQWCSi8x99Y4mmIYev7DA38Mp9EWpQdXHZ1 FBspiRUxLlXZX1RvERhmNkwIYw= IronPort-HdrOrdr: A9a23:ANkL4akOm9tAPXhKeALAYv2MOuvpDfIk3DAbv31ZSRFFG/Fw9v re/sjzsCWftN9/YgBGpTntAsm9qBDnhPtICPcqTNOftHGPghrKEGgK1+KLqFCNdBEWndQ96U 4PScZD4RnLfD5Hsfo= X-IronPort-AV: E=Sophos;i="5.96,318,1665460800"; d="scan'208";a="92208481" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VGgQcJhdVDR5De9i6kLVEzsqntOxozNEr6LuwcT7z7cWNNkRxkW9U+Ge4SRoz0bLLGcjOvFk6+RecfMuqrmuq9tUJQBdqCef9oTUeZTbxNB7zTbZhwIy2IALS/RFPHhdrJJWimq9t3ivIxJeACFD7aFESnt0ue7zeXK6QuJu00n0DfXy4zGzUD/4gQGBsMmopzcbyDotXzg1kRgLwDzbdut6MvUaFFhuSaQYn19QMF5S4gTUjvT8LuOQ9GDtDt3Fg+T1SaVqv56AmyZg2rtGzgKn8jnYnM6/1ZZ1dICZWuj85jsXv3MacmstvX9kQZBA0KJKAM8Lb0iUeI8aj94NZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IWEE+Uk224L1EzdZRWsnZkazNqZOt00zjoy/L5ND+Ss=; b=ONETdCYH/zQzQVeuYuYR0MmHq+t6FqCFmBPwiJKhxNfwelsWMz9SoQk1Gmgtyn4qJ5ky8qqBTyWeC0jj4pJqx+7icfHb6Br9myEzDsnItJ+Cba8JF2wPUk2ZfHMnjDLS2g8V+QTncEowxisZxqXJvBf2jPSVXuVE7amUJiEBtvF5ql6257wyWGSE9ZdLgm2xUVoEHCxwQd751E8Rf0h9KLbDS+8G0/DLddbMvOIM7QVkhuQ/ADeVYSRJbLXGXnnSy81KEyNA490XXCLM7T1AjrENT3WYqNwdGAbG+LSioCRx8m6X1M349YDTauYEFSp/w6KgMNPeBrc57/TJGUlTPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IWEE+Uk224L1EzdZRWsnZkazNqZOt00zjoy/L5ND+Ss=; b=DNzhJ2sunwxbMbnOk6cUrdd386YhrKp6ZGY/BbHJZLAF1V2nf4XFqeO7knzyEc8Pkew7tAC0mmpkhPoyOZMZ6KR7cjSHOZ+rsFI7o88TAn+83nqGcyFUQGu3WjdSXHRgCRNKYo6YMWUr+10Pzp9NTuM/lKYh0WhlngQrlyNhQVA= From: Andrew Cooper To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Wei Liu , Roger Pau Monne , "Tim (Xen.org)" , George Dunlap Subject: Re: [PATCH v2 4/9] x86/shadow: drop a few uses of mfn_valid() Thread-Topic: [PATCH v2 4/9] x86/shadow: drop a few uses of mfn_valid() Thread-Index: AQHZJcQqh5dhxv4yjUqRQKHvfuBGaa6Z55gA Date: Thu, 12 Jan 2023 00:05:22 +0000 Message-ID: <54297677-c176-9358-f101-3939d133c254@citrix.com> References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|PH7PR03MB7048:EE_ x-ms-office365-filtering-correlation-id: 9da74b7d-e2d3-4220-5d77-08daf430b345 x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dXLL6J3ces1ImAJjiDwL2HkrU43WUGQe1liXhcG6Kgi6ImY0Zn8QUlsUEVUVODEwoTExWmw8t+D15dBeQ1bGIMxHcJdAl1i2C1ejqcKU6qbBPC3VK7rwWApimgpOHc8NeJJ+WV6x9XWXfq2gFYJVmVzwvTzKoR7TJBkxr45onbPWNHtYn28K8gh8QQVbcMdGEy6L5OUHs0FOjXjBY26zEGIwntGiXLwL6EyFm4GEDBrrL6b3clG2uevf5lfwZ5TU9m4pR9nfy6iJpNDy8zREEjfaNfAMS1dV6YLKMhRbsv/tw3KtM51Poicj491TkwJSJX2G5mQu1QdRDGzqYWRAY64gabqhQlzsk5+KnkOOcm/6A+92UwyeyYcHyuoaF+ckbtp0nxgYMGlqMXUZifYJ/9usl4HPKaChAjcU9EYvAz6HQdVhHLY3M72o4XGX8S+YT7fwQOu5iK9ksdV6LE6fDBTsKnEbFN/jrSPXSDyCRoq42f/Wl1D91mBQBZcgDH6KTwgO7+EFC4UsASkHcOxpnarMi0dL/Jz85qj5O02eIL0QTtwoVWi6s5DJGRfSDfyPxfX8a7SKGjcyX3nwBaJFlVeA4hmx+cIqsYu+JPBK4a1iosf3XhorJgbSbuqP+VTzhsPtDUOTDcP8gHy33HZ77ZrixqFOJbnXMNR147WaVelDCmJgBpZClzL6vybPcyz7Dm1b4cX/XD4c6xHSYUTDfwAFjxGrvoSVc/HX6q9XXAyvkEo0AVBw9Ss6dt7eVcfPv14Fhr0T7bnvvC53jQ+kUQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(376002)(39860400002)(396003)(136003)(346002)(451199015)(53546011)(31686004)(2906002)(71200400001)(6506007)(6486002)(508600001)(186003)(26005)(107886003)(6512007)(8676002)(2616005)(110136005)(66446008)(66946007)(36756003)(76116006)(64756008)(54906003)(316002)(66556008)(66476007)(4326008)(41300700001)(4744005)(82960400001)(122000001)(38100700002)(38070700005)(91956017)(86362001)(31696002)(8936002)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SzFhQi9mNFMvdGdKK0drdFduWGZ5NDk5d28weEJKa2R2SUkxckF2NjdqODNS?= =?utf-8?B?djVtMjNuVktsYjBGcVdMME5iMnNNZ3pmRGplUTBEN1ptTm01Y0pDZFI5ZE51?= =?utf-8?B?anVIUThPVTIwWFFoKzVZL2dSVmcxZi9SYUd3dzVwVGsvazlrK1BqejlHNFhl?= =?utf-8?B?eFFHczNOZlhxVHFxaEl4S2hYVTg5aUlId0dDcXdualp3elg2cVg3cWJSK1pG?= =?utf-8?B?TEtqdmJPaGdpR05WQlVteThaV3c3Ri81U3JtOTBYV0lub2tKV3RXdE1HSEto?= =?utf-8?B?aTBpdDJlUFVDSm1BRlpqWkc0UXJ3K2djTUI3b2pMTUNEQ3hlSGdHd0RPdDhm?= =?utf-8?B?TDBCTFJWM0ZzMk1nSFFBUmpFUVUrQ0xlVGl4QzZ3RVUxTGJkUHdZdVZMWnFY?= =?utf-8?B?U0xkYURJeEp6aVk2NXQxc1IzSlhhTDdlOFNKSUN6TVVKMEZkbFkrTURXakdO?= =?utf-8?B?bDlQZnNxNjhTaHFrSG1ScUUxcXdFQjVXTTBPbmRMc0dDL3I3MXpVaWZGRHhu?= =?utf-8?B?ZVZpempoTys4clBmT3ZXRXlhU1FuZ0xVeFB0a0I2bTBpd3R4TUZ0cmhLUkMx?= =?utf-8?B?dld1QlVNb1VvNFE4ZnVGa2lPV05mb3c2Vlg4NEpRK3BNU1pVQ2hOenN0VDRz?= =?utf-8?B?YjFqeDFwVnJMREwxbVRzR0Rac0hwZXRHeTJjb05ZMVpwWFhkWlpHbjNVVVhE?= =?utf-8?B?a3RETk9SZWVCWVRROGpTWENUVWFHOWhUNnRrUmF1SVFTT2MwN054Y1FocWZH?= =?utf-8?B?WnJac3FkR2U5Z0ozb0F4V3hOdVNhNFF5eFk5NzVtcTZEMWZZUVFWWDN4NEZl?= =?utf-8?B?eEQxY1Bzd2VwVHpoUzl4c2hWS1orTU1DeW9JR3dndWJib28xYXRSWkhhRHNa?= =?utf-8?B?eDhtRG9wcjZNOWhENm1QS3hac3lnSFVSNENscFFNQkNQRWxIYzFrQXAyNmli?= =?utf-8?B?SkhoU3RzUkRxTHFVSUJjdThQQlE3WlJVUkg4LzJwN1BTY1ZMR1d4MnN5cEJI?= =?utf-8?B?dlEzRFg2L3lUMDlFc1FGYjUrcUdHb3hQY1VrdkpzbTkydTBDdXdGM29tT1RJ?= =?utf-8?B?a3hMREl3K25WZ2NyaGpSdkZSSHNpQ2lxT3dsTENKSXRvaUwyd3ZEdFg3N0Ru?= =?utf-8?B?elNvQzVPcHNpcnh3dGRpaUFmQmhMT0kzTGxDNG9CLzNtWmlnSzQvMkVBS3l0?= =?utf-8?B?Z3BYb3cxemx2S3pILy9ZSDhKQ1BxSzN1MDJiVXJmKy92UWNyUEhyQU1xcmVF?= =?utf-8?B?N3l3YTdOallHZkpGYUZRU0dxdmYyYUhhNUNXVURhVzJFdTZMWGJtQjhMajZI?= =?utf-8?B?cE5GMHJsTUwyNVNVV3dlcVY4Y0ZHS3J1cnpqUWJYMzc3d3BKVWIyVEx1UjU4?= =?utf-8?B?TUNSWThnMEhLSXNMaGdZd3cwVlhyTVZNbkNVOHhFdUhFd0p3Ty96TXRmVkJT?= =?utf-8?B?R29NWmgzM0hHbW9YeG9NR1ViRnVLaU44Nmg4K2VyTVpMTk02VUJ2NlNOWTFU?= =?utf-8?B?U1drY2FVWWdwRXl0Rm4xTlBjZVJVeG1sZ0YxdmxnVTdJcm9tN3VCaitkaTJi?= =?utf-8?B?TklaZ1A4R2tOY3c0NnZHNnVkSllGdGxLNDJOSC9VcUkwdnVTbEovR3BLMVIx?= =?utf-8?B?MW9ISGlXZVcva0pPd09GYUxRL1ROUnZrckRhWGlzSk1FSmdHY2RJTm5xdnJM?= =?utf-8?B?YWwzL04rc01YaVBJUHZXRjlTdUdvNS9IejBrZzhzckRNRFJqU2FOWXpXUVA4?= =?utf-8?B?ZmVna0ZrYVlMdTA2Yk5JNFV0U3p3RWpsaVVtbFJRNnBmdktUMWoxcmxWRU40?= =?utf-8?B?eHgwWnVRMUhvVG1vUEl2ZUN3T0E0VFlTTHRYQnBnZUR3Q2YzZU9LbnlVZ0pN?= =?utf-8?B?UVNHeFpiclpVZEFqM1hDY2JadjhOSTNpN2JxZWl0RmlaclRHRlJmWnVQd2tQ?= =?utf-8?B?ZURGaXRzMXl0Z05USHVrMHJxSmtRbEs3TlRMd256eThzN3pKQ1BaV0l3WFZa?= =?utf-8?B?QlY2Zko2U0NQcitmczZIMHBjNUhnTlZiN2ppalRpU0dtQ3B3T1FJcldCaXVY?= =?utf-8?B?dmRMZTdBRE44WXE0OWs1K09GQXh5MFpwQys0V0V0OVUxMzRkWDcwc25WWFdz?= =?utf-8?B?c0wrV2hRSi83cHdjd1c4cTVoVmNuWnlyWjlibnRid3lvR0NsUUZ6cU9sbTl6?= =?utf-8?B?WlE9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <99616A2CEAE0984CB0EDA9B505FFC4C6@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: HY8PUg39IC33BYbryx3f72q04sy6yzrzQYHMwOXQLjci107s8xlDj89f6GwlF9mEiEolxUuOhQCJMAoD27z27XejahpA0ihQ61y536xgceU3eZ7M2T8zWIKnbP7kqyGCLQjh8n99S0Rc/L25BmYMwy3wg6ckPvitFd+IC77XPF42UhHXh/NYbMKv6zHiZXqO9mO/TJXMna/S3wfttPf/haGA80+/cCB6l9ArxhhnShR6P580nKCBAOYtUhBgzKZRgg5jTVexs668ZTuOD4UTnWBD8MsB+AAED8JrU/lvI1mNlRcpAPOhoOu/mlLyhSoFhHAG6p039nRpmrOAdMEbOL01X4bA7jFn7ZBw6/51DnR0X9jldH7nlE7pYgJ/SAzxt9HRvjiejky0u0yurYj9syl0tF6rM/xtNq9ZcPWLxESCli0vp8EP97pRc601LXZh+Po9s9YhoQhbO0CZK9CBMww7C5tRlAfCNWhHjOVXEUVYXVFm/REmN6GvmpKZdUXy+rdgAsdxkRKfLZxbSfOVNOcUv21k0CEIg09n4kjHPgKcC3OloGTag3GreydPkCxXsa3KsUBNb4DIKI+h9I3ttk8yEOlQZ0/YpxH7GXfnmoSssI9xmLsK448llwOm5Bm9iaQ+vEDB4grF/9IAgYfacFpHcL99aghgVWx9N61HdjM+R03/3G50/s7qtCAi2+WgjqbFQ+PtihUt9rikvPg9e58jrakOADHb0jjT8CDLJJYuuCFSYNbFMRxdrLAqgMYcsXT+jtZRaz7J0czVsIim4/J2zGmOhH9qXa/0C6wsnEfzGNm4//RpYYzx0wF3CwsC/uvv5aN22MNc/poY9jplcg== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9da74b7d-e2d3-4220-5d77-08daf430b345 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jan 2023 00:05:22.9465 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: t/SlHUtCidQLA//ATRHkx5rduOojoFnAhcLR/NGMiux50K+1yj4Ou/VetzZqPUxxd6UE1X5p/ax3/ph1la11WNddUczbJkarV39oUPqi8SA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR03MB7048 T24gMTEvMDEvMjAyMyAxOjUzIHBtLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gdi0+YXJjaC5wYWdp bmcuc2hhZG93LnNoYWRvd190YWJsZVtdLCB2LT5hcmNoLnBhZ2luZy5zaGFkb3cub29zW10sDQo+ IHYtPmFyY2gucGFnaW5nLnNoYWRvdy5vb3Nfe3NuYXBzaG90W10sZml4dXBbXS5zbWZuW119IGFz IHdlbGwgYXMgdGhlDQo+IGhhc2ggdGFibGUgYXJlIGFsbCBvbmx5IGV2ZXIgd3JpdHRlbiB3aXRo IHZhbGlkIE1GTnMgb3IgSU5WQUxJRF9NRk4uDQo+IEF2b2lkIHRoZSBzb21ld2hhdCBleHBlbnNp dmUgbWZuX3ZhbGlkKCkgd2hlbiBjaGVja2luZyBNRk5zIGNvbWluZyBmcm9tDQo+IHRoZXNlIGFy cmF5cy4NCj4NCj4gU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29t Pg0KDQpUZWNobmljYWxseSBJIGFja2VkIHRoaXMgaW4gdjEgYmVjYXVzZSB0aGUgY29tbWVudCB3 YXNuJ3QgYSBjb2RlDQpjb21tZW50LCBidXQgQWNrZWQtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJl dy5jb29wZXIzQGNpdHJpeC5jb20+DQpuZXZlcnRoZWxlc3MNCg== From xen-devel-bounces@lists.xenproject.org Thu Jan 12 01:36:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 01:36:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475780.737612 (Exim 4.92) (envelope-from ) id 1pFmVb-000116-MJ; Thu, 12 Jan 2023 01:35:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475780.737612; Thu, 12 Jan 2023 01:35:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFmVb-00010y-Gc; Thu, 12 Jan 2023 01:35:59 +0000 Received: by outflank-mailman (input) for mailman id 475780; Thu, 12 Jan 2023 01:35:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFmVZ-00010s-Rk for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 01:35:58 +0000 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 731450e7-9219-11ed-91b6-6bf2151ebd3b; Thu, 12 Jan 2023 02:35:54 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2023 17:35:51 -0800 Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by FMSMGA003.fm.intel.com with ESMTP; 11 Jan 2023 17:35:51 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 11 Jan 2023 17:35:51 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 11 Jan 2023 17:35:50 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 11 Jan 2023 17:35:50 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 11 Jan 2023 17:35:50 -0800 Received: from BN9PR11MB5276.namprd11.prod.outlook.com (2603:10b6:408:135::18) by DM4PR11MB6263.namprd11.prod.outlook.com (2603:10b6:8:a6::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Thu, 12 Jan 2023 01:35:46 +0000 Received: from BN9PR11MB5276.namprd11.prod.outlook.com ([fe80::6a8d:b95:e1b5:d79d]) by BN9PR11MB5276.namprd11.prod.outlook.com ([fe80::6a8d:b95:e1b5:d79d%7]) with mapi id 15.20.5986.018; Thu, 12 Jan 2023 01:35:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 731450e7-9219-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673487354; x=1705023354; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=062Pw/QjRa03xkcJKM56gTmrb5zWdQp44PYzHol87us=; b=iIbllR/C1xRFsBzbQtQ9eVuTKga52WcdQGRE/JWYh2MUtVClJ6N62c10 50aOS3DCayIqwhmufvFB3elU7yB5xsjpTSEWgwU9W1HuOTSNsIv8sLj65 s1e/WhMsbffm+jDMZt0gpNqlTtjhQNyan7ovgiY0J3I2G29Zb89J6fGRZ kawi2e2yypWkapPz+fGKzcqDnVG9dI6phi2k+JbIXyr/FVkHCpnCFcide tqgzRLBtqWXJofO27zuSf2LqxVfKTy3+frkhJsInHnnWMB/ReXIOhWDcR n9xhx79KMYh39JtYNMbi1LWIZ2u2RB0BZTmzuJyYE64uBWNvPI72oki0h g==; X-IronPort-AV: E=McAfee;i="6500,9779,10586"; a="409821222" X-IronPort-AV: E=Sophos;i="5.96,318,1665471600"; d="scan'208";a="409821222" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10586"; a="746368034" X-IronPort-AV: E=Sophos;i="5.96,318,1665471600"; d="scan'208";a="746368034" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IJSZFLMHg12zsLcX+scT4ilOACJE82UZ4YGI1XLOHICIdjiC00ahc+K/zQE0OeqrI5M9b44QvhYd/77H4mfmeUu4ptfyiEN8bawt8Bn9xJ5iG98e3mR45hkE96T6zf6vhKQm64CPzbleptrD11F6/Qqh93Rxt4NXp4k83SgEksSp0+e0SQJvFyFrJsoYQ7LGSFbzs08XEPrJMoL3e+rcCIhSjq9GoHkPnhPPxi4/9wWlYymcWTZb2dY/Msb+cxFvAEN7dN4SPcgVQp99KWMxSzjNIeZttZ/VyOo4kitiZ+5iD+r8boN1ljLB0o/vsM91gpi4rgWdtD/2MWZQZqInhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=062Pw/QjRa03xkcJKM56gTmrb5zWdQp44PYzHol87us=; b=XsFU9vHDr9LId4ZD+9+gx64xGKZkRNQpVZ5hDRA5CyGUMx+UBmyxgLUYZTLTBFJBvJZYSI5Qe3+OThVSrNDOrmH+Y3dS8y8+3OtCZ8zI1tgwIF+T6mxSF1uraUXYjuwubZaf9X3waGjw1Gsyqs5K/OKTLOWQRPXZTDr1I8m5zhPuSC54ixCgVJpuvuDA0hrYXAOrBF9MkRk70sFRPGV3CfGNlHocFVN8kM1MbQegOoRT7N4wao3niFIbKd4HupWR8/6lKKmRNVf04SsuTFTZ8JH2lsIt0buZIWXDwFKK9T8lUGQXQONcU898jxDuay4Xho0rMpqF30gsZwTAwmWG9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none From: "Tian, Kevin" To: "andrew.cooper3@citrix.com" , Xen-devel CC: "andrew.cooper3@citrix.com" , "Beulich, Jan" , =?utf-8?B?UGF1IE1vbm7DqSwgUm9nZXI=?= , Wei Liu , "Nakajima, Jun" Subject: RE: [PATCH 1/2] x86/vmx: Calculate model-specific LBRs once at start of day Thread-Topic: [PATCH 1/2] x86/vmx: Calculate model-specific LBRs once at start of day Thread-Index: AQHZJCMqvD+lv3RMJEyTX9mVHWu5kK6aBACw Date: Thu, 12 Jan 2023 01:35:46 +0000 Message-ID: References: <20230109120828.344-1-andrew.cooper3@citrix.com> <20230109120828.344-2-andrew.cooper3@citrix.com> In-Reply-To: <20230109120828.344-2-andrew.cooper3@citrix.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5276:EE_|DM4PR11MB6263:EE_ x-ms-office365-filtering-correlation-id: 8cbf9686-e99f-4399-32c2-08daf43d53fb x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 49asUTlnk0gjTXfEgMyE4wjntyaQgEdNKd+ZWbFKM3xpVWeqF2C0tIzrLqVsO9C/18ZHbQobVC5YYxSVMkCC99twvSUwBhHPz8dgnix+tCBmhgc2I2b4aoo43LCnp+qX/1SS7QHZOs4MUQh0JQW4pttHSOVM1QCWVvvm+NZC1cvuSGY1V8GhjaLZyo9PimCDWFvMz3YXF8qgnESZrVn9zFDA+8Fmd7nZfy1FLYtpuMTyr3wlPGDtSmHOp6EBVxF8Ft8l1Jkoz4LI/dRj80+TyCvgfzU1s609JFq6cESVAvS6UByfsn4FQpF8+arKQswkcZMSXRqXHIqjRhHKDsBiru6QKm9g58xKGn941bIpahnd4Ey6cRc4Wd+HEbefc+IxWgU4Mlh9QAaF3CoaKQ3tR8uCUbJb/bLD1zD6L284vBgB2Bt51Qh+vBT1c4aczjeyfAWRmllPj7w1sUbr0FYsB+gs1jZCJwi74voktBbvhaP3mUIaV/NONa91qmlHnkl27UqrfMJbFju3jumgC3zX3R9gniqeWlKpTXfVwsodZTVtCaIgUNBw+sx8UTJilWolJFEIDsjh8dfJ2j/nQ9/BroL+kH/pnpjoih/9NUmb3PZfG/m7ZNQsA1NpmOURrV0QKoVsZPJsN07OywU4/2a3ZLpe3N3YVyA4n4Ym5/P8Qqjy+55WJC4dXtgWgR8gFfKgK7s+V+KidlA0FXhV3ptRBA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5276.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(346002)(396003)(376002)(136003)(366004)(451199015)(6506007)(38100700002)(122000001)(82960400001)(107886003)(2906002)(478600001)(33656002)(4744005)(316002)(26005)(186003)(5660300002)(7696005)(71200400001)(9686003)(86362001)(8936002)(38070700005)(52536014)(55016003)(64756008)(41300700001)(110136005)(76116006)(8676002)(66946007)(66556008)(66476007)(66446008)(54906003)(4326008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?OVNlVTNlUnBMWWRpc2pFaUFGdmhlK2JncGpSS3NSZVJxaThNSnloN3N6dmYz?= =?utf-8?B?TS91ZnhxSFJVNjI0NGEvRnh4QmNPb3BQMTVOVUQveVNTdVZJSUd1TDZXYVdG?= =?utf-8?B?Z3RRSTBwZG8wdjZMRTBNbHpVVlJrWmRRaWlPZXlUdGtJRStzanlCZ0tlMmxG?= =?utf-8?B?a3l0NFJUcDFCUHg1Vm9MMGNvb1R0dW04akppR3RuekpnLzVqVWtDSGlvdkRv?= =?utf-8?B?c1ErQ2lWb1hmdVgwK254QmNPZVN3YnZtcU1ObHdnc3MzSkRkbkpEQUtkSlcy?= =?utf-8?B?QUtpL3JEYlVTREhyRkQxRjI5Sm5SdjZYend3WDZyZEU4VE12elZPYURMUmJ4?= =?utf-8?B?RmNzU29RcjJVVU43REpCNm5sYXQyMEpZKzk2bkxSeHl2OGRkc1J5UUVkVWRl?= =?utf-8?B?UGtYSjNQNG5hZngwT0ZvOHNhM0tab1JNbGxISGZUSGVOQmcrMGFUN29CSURk?= =?utf-8?B?YXk2SmxaYUJCdGVPM3pIOTdMRmtkemdwQ1RVRFhLSEpsa3J5LzhKTFJCcDlO?= =?utf-8?B?UXE1SXpXeEw4bS9XT2lFM1VoSzA5NTFEajN0cEFPc3F3NFY2TmxlM25xNjd6?= =?utf-8?B?YVhwV2pkZHNjUUNpUzJvQkJJa3FxZEpFbC9NSGVQazdGc2xUTjJWUENWZU5q?= =?utf-8?B?S2syQ0xNeGVvcVJwM0NkTDA4VHJhODJBOHBSZVNzZ2NqMmFmVVduQmVTVndh?= =?utf-8?B?OG5XZ2YrYzZzd3hXK2wwTjNxdXdjY3ZqaVF0R0pEcUE0TDdvVk1URnFXd2F6?= =?utf-8?B?RzcwSlA5ck1qNFpsYXFmRS9tTUZldXhGTXRReTNBVlBLVmt5V3hjcFpaRWZv?= =?utf-8?B?bkgvQWhROVhqRUQ3VU5vSHBvcTg3Z1UzNjNHZk93eFBnR1ZjaFdjb3hxRjln?= =?utf-8?B?c2tXMXhLaWRxRy9YbXJ4VVBLa3BlK2xITDZLb2w5aVk1Y1pET09mU2pKZUFP?= =?utf-8?B?T2o3dXBZQzFCNE5IZXBoaWIvUFhpQkptdE1KOTBrQTJxZzRhNXVReWZQd3l5?= =?utf-8?B?akdlKzFYM0lGbjExalNkTytTNHFmRklmZGttMWVPT0tyYjNoZDJ0cFhWdUZ2?= =?utf-8?B?VXV3Yk96UkZGTnFwd1ZwSmFrU0daMzU5NU56MzlZWm1ZZWdYWFVJRzVjSWJQ?= =?utf-8?B?OGxHZmlhWGZINXEyT1BHekJ5UWIyL0NYcDkvV2lJMDB5TjZBQll1U25sdUxu?= =?utf-8?B?bXFieTJNcUZMS0NETVV6M3FVMFhVanBsNWhRVUpKcGQ3QzIxS1lIYjNvZXRz?= =?utf-8?B?S0RZdkZWTm5CRit5TUhhZnJhdGtwb3FFQ1NuRDhCdjV4dXBzY0xQV3lTY3lZ?= =?utf-8?B?M05sNFdDSkNhV0hQK001dTRra3VrajBFdXVYVjFBODBialBiaURUV2hUbmll?= =?utf-8?B?OENVdGNSOGc0VG80bVdMUFNuaENYWFZJRnIwQUdqY1ZNbUlhRVptemVDY0V3?= =?utf-8?B?MFlNM0dPbCtYenNid3g5WXAxWkx4NTBodWtQVTlpbFd5RmRiSzdidDFIQnov?= =?utf-8?B?czVuS1RoOG5QcXh0ZXJBRHhVdTlubEdQWmhUWjY2MkpWaUFRemZ2d0pWR0JY?= =?utf-8?B?N2pzQ1NoR2tNc1JVdmkvc3cwWHExdjFvZm1MODJjNlVnVVRPbzVlR0ZURUZF?= =?utf-8?B?RGNtTDllMVlLeHBXY25IKzIxNGJZWUU3WkhtWVBrbEFXS2hjZG5JN216S05D?= =?utf-8?B?TUdVbGVoend4cHZNc3lLM3U1MFF4WFpCRGY3c3RYcVM4anUzc3pMUFRvTDdj?= =?utf-8?B?MFB4NVg3QVhKZkxBSk9TSkNoWTltMEFDUk9vTkdyaEk1U3pWbmpBb3hHclEv?= =?utf-8?B?a2hUeG9qSkN0YXpyamlXRlBocDdhREUxOTdtMkRDWTQrQkgvR3FmbzlvYnpu?= =?utf-8?B?QndQRzJZaFdQbzhLcm9wTzFRQjRNMG5rQmtuQnhoVW90c3NlY2FGbUFKclFo?= =?utf-8?B?dlUrVjhKTlIrWC9WNE03cHJlMFRYakhSUDQ0R3krWVVtbGNoZGZDVFJuRUh3?= =?utf-8?B?QmdKU0FqejgrV21mdEVXQ0swd1JObEsyVFJHaFVWMXoyV0tWN0J4MVRTSnpK?= =?utf-8?B?RzVSNkw5NkV2SkhaeDRUY0NMT05KUDk0YlFpVmtsdlg5c2J1V3JMZnlFZGU2?= =?utf-8?Q?NY+mdxj/4rPUfe9um8PNGwLfR?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8cbf9686-e99f-4399-32c2-08daf43d53fb X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jan 2023 01:35:46.5187 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0idUpcN3QkMNGOrsh+nV5BhyXQy94TrYfrQkxufdiWY6Oq4nkseGKtCIhCtWapstxtl9a85BCRQUye8Wn3otZw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6263 X-OriginatorOrg: intel.com PiBGcm9tOiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPg0KPiBTZW50 OiBNb25kYXksIEphbnVhcnkgOSwgMjAyMyA4OjA4IFBNDQo+IA0KPiBUaGVyZSBpcyBubyBwb2lu dCByZXBlYXRpbmcgdGhpcyBjYWxjdWxhdGlvbiBhdCBydW50aW1lLCBlc3BlY2lhbGx5IGFzIGl0 IGlzDQo+IGluIHRoZSBmYWxsYmFjayBwYXRoIG9mIHRoZSBXUlNNUi9SRE1TUiBoYW5kbGVycy4N Cj4gDQo+IE1vdmUgdGhlIGluZnJhc3RydWN0dXJlIGhpZ2hlciBpbiB2bXguYyB0byBhdm9pZCBm b3J3YXJkIGRlY2xhcmF0aW9ucywNCj4gcmVuYW1pbmcgbGFzdF9icmFuY2hfbXNyX2dldCgpIHRv IGdldF9tb2RlbF9zcGVjaWZpY19sYnIoKSB0byBoaWdobGlnaHQgdGhhdA0KPiB0aGVzZSBhcmUg bW9kZWwtc3BlY2lmaWMgb25seS4NCj4gDQo+IE5vIHByYWN0aWNhbCBjaGFuZ2UuDQo+IA0KPiBT aWduZWQtb2ZmLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPg0K DQpSZXZpZXdlZC1ieTogS2V2aW4gVGlhbiA8a2V2aW4udGlhbkBpbnRlbC5jb20+DQo= From xen-devel-bounces@lists.xenproject.org Thu Jan 12 01:39:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 01:39:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475787.737622 (Exim 4.92) (envelope-from ) id 1pFmYl-0001eT-7Z; Thu, 12 Jan 2023 01:39:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475787.737622; Thu, 12 Jan 2023 01:39:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFmYl-0001eM-4v; Thu, 12 Jan 2023 01:39:15 +0000 Received: by outflank-mailman (input) for mailman id 475787; Thu, 12 Jan 2023 01:39:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFmYj-0001eG-Cz for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 01:39:13 +0000 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e8d48d36-9219-11ed-91b6-6bf2151ebd3b; Thu, 12 Jan 2023 02:39:11 +0100 (CET) Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2023 17:39:08 -0800 Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga006.jf.intel.com with ESMTP; 11 Jan 2023 17:39:06 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 11 Jan 2023 17:39:08 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 11 Jan 2023 17:39:07 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 11 Jan 2023 17:39:07 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.106) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 11 Jan 2023 17:39:07 -0800 Received: from BN9PR11MB5276.namprd11.prod.outlook.com (2603:10b6:408:135::18) by MW5PR11MB5930.namprd11.prod.outlook.com (2603:10b6:303:1a1::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Thu, 12 Jan 2023 01:39:05 +0000 Received: from BN9PR11MB5276.namprd11.prod.outlook.com ([fe80::6a8d:b95:e1b5:d79d]) by BN9PR11MB5276.namprd11.prod.outlook.com ([fe80::6a8d:b95:e1b5:d79d%7]) with mapi id 15.20.5986.018; Thu, 12 Jan 2023 01:39:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e8d48d36-9219-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673487551; x=1705023551; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=OaWAnVeP0JWOVMEzqs0hGmjrGi1n6DfEAZ3Zh7ndx00=; b=gV4uYvsFkyNpQ98UbMYbZpwDtWhXOsjEiFmAY2wcZ3xP++Fci3U8ryxd q3dLJ1xRnsB+kkY6SQjhR4qC+rItum2X2a0AKibEBncBwKDOpA3HTsufk 3UCqlFL3tQBuc6QKZL4Wroc1G8PANMbqI7GbfwscfSAIjQsyvxdD5tkrJ JdnXLwZ5J9SjkzCKrLx2ZYaC1fqdyK330/l1PrNifh3OHCRge1np67R6B F13sF2kxSHB9H+AnbjW+aAVoDhqD8xearbaoSEC9Ypi8li7NcoDZpsHDu +048JeD+iaf6RNSCTXsQcL5G3X1IzfmTG64rZ3mlZGVoBZkuzkpPXKPnO g==; X-IronPort-AV: E=McAfee;i="6500,9779,10586"; a="311407704" X-IronPort-AV: E=Sophos;i="5.96,318,1665471600"; d="scan'208";a="311407704" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10586"; a="635194790" X-IronPort-AV: E=Sophos;i="5.96,318,1665471600"; d="scan'208";a="635194790" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VCJxHNuT55VyAf84qkzjRi65dZeqdekhSE7xqJyAc1bbyWhImtoGe6P6sNXUB4oasYKzgDlBWO2QpgRbm4KHlZdcVI8T4qrxMui+9po2oFu/+zKgD4qqfAWxY8vGkEzzTor2+I5CCHchsFbMtrfw6Yv6c3b0PoSbXNTGEVuuvv4qK2nu70PEykodH4R3aUcUDccnVuUgvG4qYs6LKYNj9Gnf0Iw0c1om2BWc2veFPGrEbw35vKoVSf/yP0jZI5Sv2RRsmiVqGvkfbpjgxxlVdHFTyKCNK9es3cTozCES+5Dmh+eT/omkO1m9XN9BeND+Z2TuGVdGd2dGO/wL0zUNcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OaWAnVeP0JWOVMEzqs0hGmjrGi1n6DfEAZ3Zh7ndx00=; b=LBJXJTesMj5ZOrlIUj+4D0mVwckRTvh6mW22pLgGqoheo88lgFG36Scf85kRWW/1HsDrIev3a1sKukslZLSuVw0LxzEugfzkaPzvb843fFJr46Gutvwp+O4qTBNOBdPtsU/zJfoMyt+Ni5dgfLdkrN2Or0ztap7/+AEi7Odz2TPHEHJNAhhe4Nr4QKEflBJru9zxcm599udmVaQ9nr91nsoSUs89Y6iHcje9xGWZTaMgOOx8jUPjvxi9l5BFCkksesba0ooI4034ELZhdxg7zL6vqeu+0WBBnwr20JMmRVSz4CybSZw/T0FD27zecS1KiBmwHS7kNB12bKjVXbKvDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none From: "Tian, Kevin" To: "andrew.cooper3@citrix.com" , Xen-devel CC: "andrew.cooper3@citrix.com" , "Beulich, Jan" , =?utf-8?B?UGF1IE1vbm7DqSwgUm9nZXI=?= , Wei Liu , "Nakajima, Jun" Subject: RE: [PATCH 2/2] x86/vmx: Support for CPUs without model-specific LBR Thread-Topic: [PATCH 2/2] x86/vmx: Support for CPUs without model-specific LBR Thread-Index: AQHZJCMek6T83CtFrkaQg0ivmixH/a6aBOsw Date: Thu, 12 Jan 2023 01:39:05 +0000 Message-ID: References: <20230109120828.344-1-andrew.cooper3@citrix.com> <20230109120828.344-3-andrew.cooper3@citrix.com> In-Reply-To: <20230109120828.344-3-andrew.cooper3@citrix.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5276:EE_|MW5PR11MB5930:EE_ x-ms-office365-filtering-correlation-id: 1b7dbf7e-00e3-4daa-75dd-08daf43dca8e x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: UYkibS0dum70SHkVJNKaQ6Oo5MqTdfjizuC4mUOxKvuicGMXJjxa6j+xQBlklABVfTD1DTliykQXD/4DTAMOH6G9FhL6MVmS+LOQRg9iFjFhPmEQKs1ilQ7LRjhkBWd7c6chzkxzpJ7yhQnToqayInmsSmr2OJ4Ki+6yEj1UhrH5ifHX/90EKT/rxRlHLUL0TVoLf9EM4NhdBC2xurYKW3IhU1IGGEpk7EJKJtEy9AA8njSF3NqPoER9wshq/9pXIGBIWSXCDnBCOOjbs3G+BzVY8Zfi52HY5RmmNv9PeCom0SSjHRQHDzqpNHHRaPY8p+gwxPcs/Dte/8lt+l9omW0UciFk0tIIwBqJSsISoUlsrKlR/LPrqoYDhp7/LnVX64Qx3wYkvHKKkX1Z01rk/ESNyeRzC3I3Bgdjtxym4VW4Fi/NuN/ERo+DBGuKUEqdbTSl9/jI09r3EG6eEkStqzK/kvpnm883MB9Uls73L448yBJsDlOvqfzjXvVNtpKMFX7t7yZPFzIErpeX6+I4PW66DdJx6CCf06kWfPAFr7M2QWf1sEjo+KB7LCs0PBuICZTu1Pep7CvYpeY4wnL6rz3UKy4KC3d7KeBZ6mS78+MuD2PQJSIFWyiIWYHuTcZJG5DE+5uDj/vahX2fcqtWr2RdfmzQIRdxFTcx49FH4vhUeTido4f/48eTSA83+MBI+UkPVJDkXyVNNQiBoVYqig== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5276.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(136003)(396003)(39860400002)(376002)(366004)(451199015)(41300700001)(4326008)(110136005)(66446008)(8676002)(55016003)(76116006)(66946007)(66556008)(66476007)(64756008)(54906003)(316002)(86362001)(38070700005)(8936002)(5660300002)(82960400001)(38100700002)(122000001)(33656002)(4744005)(52536014)(2906002)(6506007)(71200400001)(478600001)(9686003)(186003)(26005)(107886003)(7696005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?TE11Z1hLUitMbFpBc2xMZmJHeDdibUJkd3JBdUhia1A0QnRSQlk1NTUvbkJQ?= =?utf-8?B?TndVanJST1UzYzluZE04UGFjaTVwaUZvdUkwR3lyNzBXTnFieVBlVkxMMllG?= =?utf-8?B?Z0hReTRBOC9sVXpJalB3UFJSaW5FbTdlczFLbTVBZWgxcHo3ZFFGdXRscEdS?= =?utf-8?B?UDlOd2E1bnNvLzFDZ25Mc2taTkdUNVdLZWJXNXlIRldhSXlpa0pQRVJxcU9J?= =?utf-8?B?NDdzNDdaYnRpTlVCNXVJNDJOc0JpdGZZL2NOWFZsZ0FNaEJPNExtaDF3Skp0?= =?utf-8?B?NzV5dy8wbXpRSjQwNlkrN01seGFJcWZ6Nzk4SGhIcWdyQ3lackI4TmR0d2hU?= =?utf-8?B?VXNxVnZIRUVLekZ1UFpqRUhaV0lqaS9LY2wvdk55WE03SnhJU0dYS1FxVVIw?= =?utf-8?B?ZjgwU1JRbFlndGFFUDl4eVh0VStpSVQ5dS82bE4xTDJnTUN1Vk81bW5ueFpL?= =?utf-8?B?OXdaY3d2QWpPQlo5eHBSNDZUVE45NTFFdTBBS1FkNUpxbXl5RnY1MzlYd3BZ?= =?utf-8?B?bkYrZ1g1L3BmV0UydkFXUW44NkJUZ0x0TDNsMlY3dk55UkJxRGt1VTJ6NHlh?= =?utf-8?B?RE9Eek9oTitKVmMwUmg2amFrWEJuSi9FUHZWaGhjQVBtVkM0NEhzUm1OZzEy?= =?utf-8?B?Zmc1OFlNNHk4Yk02dTkzQW5iOHdON0NxR1VnUG92eEV2MjZrOENCK0NJMGs2?= =?utf-8?B?MnB4Zm1wblhFZEo5ZEYrWGxPWkxkOWFXYjk0WkJjNkFhREJ6NDdvcWM3OEhP?= =?utf-8?B?dHE5OUNTYTJkZk5LUy9SakJTWFUrTlU2OTRsdVRSMjZ1RC8zb3ExcVhFUnJi?= =?utf-8?B?QUhQai9SOWRJSHlxbndmK25aQ0xRbkF2RjVvMzBjSnZIVGs4TkVubStlYnhs?= =?utf-8?B?QlZ1R1FveWJLdnA1S1R4UDRBblUwYW9WUXk2ZDlyS2VBOEs5MmJIRHRGNGtS?= =?utf-8?B?UXVzMUhiMjYyeGFINHAyZGxUU0dnUUxMS3B2TUNCQVNERUxrcU9oaUNKbVV3?= =?utf-8?B?S0VlVmtCZXhvU2FnVHlGSjBlb2k4U092amVtOUxMUEQ0OTJLcmtkL05RNmc1?= =?utf-8?B?QjJVOUc0YndlYURJWmtpQjBhQWQwTU0wRzA2NjcrRWZmTVFKWlNvaVhnQ1My?= =?utf-8?B?bXdzeGhYSHpOSkhLejl4eXNaN2pLTU5kMyt2eXFKVEQ5MTZyVytzSzEzQno3?= =?utf-8?B?TWZPcHh3NEx6OWFyT2hCM3lPMUgxOHRjUTZlREtxR25na3gxVkwzTmRiWVhK?= =?utf-8?B?SFRVaWJwajU0MzdyNGJYeW1RZ0dsSFRCYk9Tdjk0cmN2RnF3d3EzK0xpcFE4?= =?utf-8?B?QytIUStJdEd5T1B0SExKYXVyQVJWcU4yeHdySFNaVlBnN2txNTkvb1NYUGxI?= =?utf-8?B?ODNsZEJuMFFEUEFxRm1JZHpjS2hPM1NlbnZXSmZ6S2M3cmVXYnoxTW01ZjNF?= =?utf-8?B?RlJuclZKZDRrQzYyN0ZVcDhFWFpBVkZ4WEcrSjAvNlpRcGNYRmFNdTA3Z3BR?= =?utf-8?B?bkllRmpCcFRLRUllcjRnS3BhV3NwSkt3cVA1SUZleFhrZy95K1dNYXpSdHlu?= =?utf-8?B?cWlHUk4wRGM2NkdHekJSQXErZFp1ZkdhU0FjVGZRSXBMSE5VQ3NEbk80aEZF?= =?utf-8?B?V3QyVkVYVVNuU25YbG4wN3psckpJTHN2OUFSRWxWWGRmK203NVhtTUllejVs?= =?utf-8?B?WTIzQkJ1cjNXMWdNd2FKbGFseTVwTFo5eDNuYWJyNGdWOW1helY3ZXVhTTJV?= =?utf-8?B?TzBDelJIdnJucFh6TTNsUzJFWmR6bjlKTm0xUlhsUlUzZUFPWkY5dEsyWjZH?= =?utf-8?B?elQrTHpiclJGZHF6bkF2bmxpaWFCakRDdWdXWlgwU3JiYy9BWjdxa0tjNHk0?= =?utf-8?B?eTVDM1hlM2lNL0FUQ2VDY01XN3ZBbHpBbFhvc1AyQkJhbEhpdWVtUjlGTTYw?= =?utf-8?B?Z2NIY09pS2cybEZTU2ZkaTByR1c1eE9NeWNYZExoaWNITUZ6TzROVkJYUjcx?= =?utf-8?B?YUxJVW5kUlZTRWJhS0o4RnVJL09KeHBiZjdhQXkwRnZxcGJhblBzaVJBWFor?= =?utf-8?B?MktWdm4wSzQrUUszZU1Kd01LV3FrQ2ZoaEw1c3BWUy9GejZwb1Rvd2pDMWN2?= =?utf-8?Q?0YSCO64E+LSwi7yj6RNe4/Zc5?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1b7dbf7e-00e3-4daa-75dd-08daf43dca8e X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jan 2023 01:39:05.4394 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sW4mBx5ZfEf/jpuS48NFvgpBP4JH2K3Vo0SxZhylL9N2AI3zraZqHoXiLzra6n0l9q7ivAyrJBE04/otOcNqgA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR11MB5930 X-OriginatorOrg: intel.com PiBGcm9tOiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPg0KPiBTZW50 OiBNb25kYXksIEphbnVhcnkgOSwgMjAyMyA4OjA4IFBNDQo+IA0KPiBJY2UgTGFrZSAoc2VydmVy IGF0IGxlYXN0KSBoYXMgYm90aCBBcmNoIExCUiBhbmQgbW9kZWwtc3BlY2lmaWMgTEJSLiAgU2Fw cGhpcmUNCj4gUmFwaWRzIGRvZXMgbm90IGhhdmUgbW9kZWwtc3BlY2lmaWMgTEJSIGF0IGFsbC4g IEkuZS4gT24gU1BSIGFuZCBsYXRlciwNCj4gbW9kZWxfc3BlY2lmaWNfbGJyIHdpbGwgYWx3YXlz IGJlIE5VTEwsIHNvIHdlIG11c3QgbWFrZSBjaGFuZ2VzIHRvIGF2b2lkDQo+IHJlbGlhYmx5IGhp dHRpbmcgdGhlIGRvbWFpbl9jcmFzaCgpLg0KPiANCj4gVGhlIEFyY2ggTEJSIHNwZWMgc3RhdGVz IHRoYXQgQ1BVcyB3aXRob3V0IG1vZGVsLXNwZWNpZmljIExCUiBpbXBsZW1lbnQNCj4gTVNSX0RC R19DVEwuTEJSIGJ5IGRpc2NhcmRpbmcgd3JpdGVzIGFuZCBhbHdheXMgcmV0dXJuaW5nIDAuDQo+ IA0KPiBEbyB0aGlzIGZvciBhbnkgQ1BVIGZvciB3aGljaCB3ZSBsYWNrIG1vZGVsLXNwZWNpZmlj IExCUiBpbmZvcm1hdGlvbi4NCj4gDQo+IEFkanVzdCB0aGUgbm93LXN0YWxlIGNvbW1lbnQsIG5v dyB0aGF0IHRoZSBBcmNoIExCUiBzcGVjIGhhcyBjcmVhdGVkIGENCj4gd2F5IHRvDQo+IHNpZ25h bCAibm8gbW9kZWwgc3BlY2lmaWMgTEJSIiB0byBndWVzdHMuDQo+IA0KPiBTaWduZWQtb2ZmLWJ5 OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPg0KDQpSZXZpZXdlZC1i eTogS2V2aW4gVGlhbiA8a2V2aW4udGlhbkBpbnRlbC5jb20+DQo= From xen-devel-bounces@lists.xenproject.org Thu Jan 12 01:43:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 01:43:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475793.737634 (Exim 4.92) (envelope-from ) id 1pFmdE-00035N-SG; Thu, 12 Jan 2023 01:43:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475793.737634; Thu, 12 Jan 2023 01:43:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFmdE-00035G-N9; Thu, 12 Jan 2023 01:43:52 +0000 Received: by outflank-mailman (input) for mailman id 475793; Thu, 12 Jan 2023 01:43:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFmdD-000356-VN; Thu, 12 Jan 2023 01:43:51 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFmdD-00086m-S3; Thu, 12 Jan 2023 01:43:51 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFmdD-0002lA-38; Thu, 12 Jan 2023 01:43:51 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pFmdD-0007Cd-2k; Thu, 12 Jan 2023 01:43:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=bE95t7GDQv/FseEad72/n1KM9dMM/4VoobFzPh2blDI=; b=HWE//I5scQXz/NfSMiAy9cZ21y TWxJKkdWPcYpTvaDTuRR4993E9TFIODDEcHTE1atUT4I7DeInbLDfimqSYWPT5Q/U5cA21Lxu9714 sXFMnjXbsbTvZAZOsG9so1y6XeRpyIFabGx84ydkvKwp8kuPuyYl7mByMIjUzC1J3x88=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 175726: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:heisenbug xen-unstable:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=e66d450b6e0ffec635639df993ab43ce28b3383f X-Osstest-Versions-That: xen=4d975798e11579fdf405b348543061129e01b0fb From: osstest service owner Date: Thu, 12 Jan 2023 01:43:51 +0000 flight 175726 xen-unstable real [real] flight 175731 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/175726/ http://logs.test-lab.xenproject.org/osstest/logs/175731/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail pass in 175731-retest test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail pass in 175731-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 175720 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 175720 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175720 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175720 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 175720 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175720 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 175720 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 175720 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 175720 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 175720 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175720 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 175720 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen e66d450b6e0ffec635639df993ab43ce28b3383f baseline version: xen 4d975798e11579fdf405b348543061129e01b0fb Last test of basis 175720 2023-01-11 08:10:04 Z 0 days Testing same since 175726 2023-01-11 16:10:12 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 4d975798e1..e66d450b6e e66d450b6e0ffec635639df993ab43ce28b3383f -> master From xen-devel-bounces@lists.xenproject.org Thu Jan 12 02:41:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 02:41:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475806.737650 (Exim 4.92) (envelope-from ) id 1pFnWM-0001GP-8P; Thu, 12 Jan 2023 02:40:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475806.737650; Thu, 12 Jan 2023 02:40:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFnWM-0001GI-3N; Thu, 12 Jan 2023 02:40:50 +0000 Received: by outflank-mailman (input) for mailman id 475806; Thu, 12 Jan 2023 02:40:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFnWK-0001Fs-P0; Thu, 12 Jan 2023 02:40:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFnWK-0001fF-NS; Thu, 12 Jan 2023 02:40:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFnWK-00045o-BT; Thu, 12 Jan 2023 02:40:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pFnWK-0007Z8-At; Thu, 12 Jan 2023 02:40:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=RBpF2YQuWouyMA6ecJteT0rCEyoKEo0jW6NTfV/Mfz8=; b=fc/hvl9U5vWMXdaxiCdNE6ertd TcfCu5llo+2/Mgb/V92GM/FHZTa4f5OKGCglYdohUcVlMRlNAfqjFr9TbhZbrnGj/5iFC/KuKykNJ Gwup40ZkGk42cQchmQyh+LWJ0JukINmv4qnBfJazdsV8ng3eP91tnyGRRlt8KHYSgj04=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 175732: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=83d9679db057d5736c7b5a56db06bb6bb66c3914 X-Osstest-Versions-That: xen=fd42170b152b19ff12121f3b63674e882c087849 From: osstest service owner Date: Thu, 12 Jan 2023 02:40:48 +0000 flight 175732 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/175732/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 83d9679db057d5736c7b5a56db06bb6bb66c3914 baseline version: xen fd42170b152b19ff12121f3b63674e882c087849 Last test of basis 175728 2023-01-11 18:00:27 Z 0 days Testing same since 175732 2023-01-12 00:00:28 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Oleksii Kurochko jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git fd42170b15..83d9679db0 83d9679db057d5736c7b5a56db06bb6bb66c3914 -> smoke From xen-devel-bounces@lists.xenproject.org Thu Jan 12 03:32:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 03:32:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475814.737660 (Exim 4.92) (envelope-from ) id 1pFoKG-0006VS-4T; Thu, 12 Jan 2023 03:32:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475814.737660; Thu, 12 Jan 2023 03:32:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFoKG-0006VL-1W; Thu, 12 Jan 2023 03:32:24 +0000 Received: by outflank-mailman (input) for mailman id 475814; Thu, 12 Jan 2023 03:32:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFoKE-0006VB-Pv; Thu, 12 Jan 2023 03:32:22 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFoKE-0002t6-Ms; Thu, 12 Jan 2023 03:32:22 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFoKE-0006Nv-8l; Thu, 12 Jan 2023 03:32:22 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pFoKE-0007KX-8G; Thu, 12 Jan 2023 03:32:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=uphChg5XX2Eh7EnrKKYYKtqWo23Nnz4X21l/v6goLmI=; b=5RIPWrBqJRyKcr5D7PTs9c6180 qesmbtPVHEqyjcZMrzxXGEO7jAVx1NwyFGfgnlMHOlXddaN/rxcYGVmVv9js//YMHG1TMFF4H+SED pCJydC3FHuPjIsMEu9WBhBVMkU/zjI4jXNdxINCDWekYncCkeJm0FKjO95GTvJaq/Kyk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 175733: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-amd64-xsm:xen-build:fail:regression qemu-mainline:build-amd64:xen-build:fail:regression qemu-mainline:build-i386:xen-build:fail:regression qemu-mainline:build-arm64-xsm:xen-build:fail:regression qemu-mainline:build-i386-xsm:xen-build:fail:regression qemu-mainline:build-arm64:xen-build:fail:regression qemu-mainline:build-armhf:xen-build:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-coresched-amd64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:build-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-rtds:build-check(1):blocked:nonblocking qemu-mainline:build-arm64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking qemu-mainline:build-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking qemu-mainline:build-i386-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-dom0pvh-xl-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-dom0pvh-xl-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvshim:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-pair:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-pygrub:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvhv2-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-freebsd11-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-freebsd12-amd64:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-pvhv2-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-multivcpu:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-amd64-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: qemuu=aa96ab7c9df59c615ca82b49c9062819e0a1c287 X-Osstest-Versions-That: qemuu=0ab12aa32462817f0a53fa6f6ce4baf664ef1713 From: osstest service owner Date: Thu, 12 Jan 2023 03:32:22 +0000 flight 175733 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/175733/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 175623 build-amd64 6 xen-build fail REGR. vs. 175623 build-i386 6 xen-build fail REGR. vs. 175623 build-arm64-xsm 6 xen-build fail REGR. vs. 175623 build-i386-xsm 6 xen-build fail REGR. vs. 175623 build-arm64 6 xen-build fail REGR. vs. 175623 build-armhf 6 xen-build fail REGR. vs. 175623 Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-win7-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ws16-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-shadow 1 build-check(1) blocked n/a test-amd64-i386-xl-vhd 1 build-check(1) blocked n/a test-amd64-i386-xl-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) blocked n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) blocked n/a test-armhf-armhf-xl-rtds 1 build-check(1) blocked n/a test-armhf-armhf-xl-vhd 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-amd 1 build-check(1) blocked n/a test-amd64-i386-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-i386 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-amd64 1 build-check(1) blocked n/a test-amd64-coresched-i386-xl 1 build-check(1) blocked n/a test-amd64-coresched-amd64-xl 1 build-check(1) blocked n/a test-amd64-amd64-xl-xsm 1 build-check(1) blocked n/a build-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-shadow 1 build-check(1) blocked n/a test-amd64-amd64-xl-rtds 1 build-check(1) blocked n/a build-arm64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ws16-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a build-armhf-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-amd64-dom0pvh-xl-amd 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 1 build-check(1) blocked n/a test-amd64-amd64-dom0pvh-xl-intel 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvshim 1 build-check(1) blocked n/a test-amd64-amd64-pair 1 build-check(1) blocked n/a test-amd64-amd64-pygrub 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvhv2-intel 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-freebsd11-amd64 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-freebsd12-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvhv2-amd 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-nested-amd 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-nested-intel 1 build-check(1) blocked n/a test-amd64-amd64-xl-multivcpu 1 build-check(1) blocked n/a test-amd64-amd64-xl 1 build-check(1) blocked n/a test-amd64-amd64-xl-credit1 1 build-check(1) blocked n/a test-amd64-amd64-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-arndale 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-intel 1 build-check(1) blocked n/a test-amd64-i386-xl 1 build-check(1) blocked n/a test-amd64-i386-xl-pvshim 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a version targeted for testing: qemuu aa96ab7c9df59c615ca82b49c9062819e0a1c287 baseline version: qemuu 0ab12aa32462817f0a53fa6f6ce4baf664ef1713 Last test of basis 175623 2023-01-07 23:09:00 Z 4 days Failing since 175627 2023-01-08 14:40:14 Z 3 days 19 attempts Testing same since 175654 2023-01-09 18:08:58 Z 2 days 14 attempts ------------------------------------------------------------ People who touched revisions under test: Ard Biesheuvel Bernhard Beschow Christian Borntraeger Cindy Lu Dongli Zhang Eugenio Pérez Greg Kurz Guoyi Tu Hyman Huang(黄勇) Igor Mammedov Jason Wang Jonathan Cameron Kai Huang Laszlo Ersek Lei Xiang leixiang Liuxiangdong Longpeng Lubomir Rintel Marc-André Lureau Markus Armbruster Michael S. Tsirkin Nikita Ivanov Paolo Bonzini Peter Maydell Philippe Mathieu-Daudé Richard Henderson Thomas Huth Yanan Wang Yicong Yang Zeng Chi jobs: build-amd64-xsm fail build-arm64-xsm fail build-i386-xsm fail build-amd64 fail build-arm64 fail build-armhf fail build-i386 fail build-amd64-libvirt blocked build-arm64-libvirt blocked build-armhf-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl blocked test-amd64-coresched-amd64-xl blocked test-arm64-arm64-xl blocked test-armhf-armhf-xl blocked test-amd64-i386-xl blocked test-amd64-coresched-i386-xl blocked test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm blocked test-amd64-i386-xl-qemuu-debianhvm-i386-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm blocked test-arm64-arm64-xl-xsm blocked test-amd64-i386-xl-xsm blocked test-amd64-amd64-qemuu-nested-amd blocked test-amd64-amd64-xl-pvhv2-amd blocked test-amd64-i386-qemuu-rhel6hvm-amd blocked test-amd64-amd64-dom0pvh-xl-amd blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64 blocked test-amd64-i386-xl-qemuu-debianhvm-amd64 blocked test-amd64-i386-freebsd10-amd64 blocked test-amd64-amd64-qemuu-freebsd11-amd64 blocked test-amd64-amd64-qemuu-freebsd12-amd64 blocked test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked test-amd64-amd64-xl-qemuu-win7-amd64 blocked test-amd64-i386-xl-qemuu-win7-amd64 blocked test-amd64-amd64-xl-qemuu-ws16-amd64 blocked test-amd64-i386-xl-qemuu-ws16-amd64 blocked test-armhf-armhf-xl-arndale blocked test-amd64-amd64-xl-credit1 blocked test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 blocked test-amd64-amd64-xl-credit2 blocked test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 blocked test-armhf-armhf-xl-cubietruck blocked test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict blocked test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict blocked test-amd64-i386-freebsd10-i386 blocked test-amd64-amd64-qemuu-nested-intel blocked test-amd64-amd64-xl-pvhv2-intel blocked test-amd64-i386-qemuu-rhel6hvm-intel blocked test-amd64-amd64-dom0pvh-xl-intel blocked test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu blocked test-armhf-armhf-xl-multivcpu blocked test-amd64-amd64-pair blocked test-amd64-i386-pair blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim blocked test-amd64-i386-xl-pvshim blocked test-amd64-amd64-pygrub blocked test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds blocked test-armhf-armhf-xl-rtds blocked test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow blocked test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow blocked test-amd64-amd64-xl-shadow blocked test-amd64-i386-xl-shadow blocked test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-libvirt-vhd blocked test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd blocked test-amd64-i386-xl-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2556 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Jan 12 05:49:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 05:49:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475822.737671 (Exim 4.92) (envelope-from ) id 1pFqT2-0003Cj-UA; Thu, 12 Jan 2023 05:49:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475822.737671; Thu, 12 Jan 2023 05:49:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFqT2-0003Cc-Qu; Thu, 12 Jan 2023 05:49:36 +0000 Received: by outflank-mailman (input) for mailman id 475822; Thu, 12 Jan 2023 05:49:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFqT1-0003CU-Hf for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 05:49:35 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e360f4a3-923c-11ed-91b6-6bf2151ebd3b; Thu, 12 Jan 2023 06:49:33 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A944E3EBBA; Thu, 12 Jan 2023 05:49:32 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 822E5134AF; Thu, 12 Jan 2023 05:49:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id JmJXHmyfv2MCLAAAMHmgww (envelope-from ); Thu, 12 Jan 2023 05:49:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e360f4a3-923c-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1673502572; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jCSkJ2BEMY4Qzmv5UmWOj9GwhY8ENcdcUr+TNtTtszk=; b=KypXs4wS45T6CBlA84cK0fwR+ved3fP2bsUGeCpIr+vQXCnlWakSM4zfgsXPI1MpXPI/vb A/XgIGIUBLO5rdvtmgDZ9NiOKXE2dHPIN7lco/qTo5BSD6HEHRutra4UEOFd+xpmUgkEBt tzT7OqUT0Sqnt8RXRVrsqbSp5hHo5vw= Message-ID: <7ba1b191-ef89-1e0d-0e1b-0b24159a9eb9@suse.com> Date: Thu, 12 Jan 2023 06:49:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 10/19] tools/xenstore: change per-domain node accounting interface Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20221213160045.28170-1-jgross@suse.com> <20221213160045.28170-11-jgross@suse.com> <05871696-1638-82d0-8d55-9088b4bb9a18@suse.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------4Una2fEaNf807I0FAxj007AF" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------4Una2fEaNf807I0FAxj007AF Content-Type: multipart/mixed; boundary="------------D1bTzj0mMMmwYj7UHgbYlVoj"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD Message-ID: <7ba1b191-ef89-1e0d-0e1b-0b24159a9eb9@suse.com> Subject: Re: [PATCH v2 10/19] tools/xenstore: change per-domain node accounting interface References: <20221213160045.28170-1-jgross@suse.com> <20221213160045.28170-11-jgross@suse.com> <05871696-1638-82d0-8d55-9088b4bb9a18@suse.com> In-Reply-To: --------------D1bTzj0mMMmwYj7UHgbYlVoj Content-Type: multipart/mixed; boundary="------------scW0k8HS13oUkWvjPCSjh6EM" --------------scW0k8HS13oUkWvjPCSjh6EM Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTEuMDEuMjMgMTg6NDgsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGkgSnVlcmdlbiwN Cj4gDQo+IE9uIDExLzAxLzIwMjMgMDg6NTksIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+Pj4g Li4uIHRvIG1ha2Ugc3VyZSBkb21haW5fbmJlbnRyeV9hZGQoKSBpcyBub3QgcmV0dXJuaW5n IGEgbmVnYXRpdmUgdmFsdWUuIFRoZW4gDQo+Pj4gaXQgd291bGQgbm90IHdvcmsuDQo+Pj4N Cj4+PiBBIGdvb2QgZXhhbXBsZSBpbWFnaW5lIHlvdSBoYXZlIGEgdHJhbnNhY3Rpb24gcmVt b3Zpbmcgbm9kZXMgZnJvbSB0cmVlIGJ1dCANCj4+PiBub3QgYWRkaW5nIGFueS4gVGhlbiB0 aGUgInJldCIgd291bGQgYmUgbmVnYXRpdmUuDQo+Pj4NCj4+PiBNZWFud2hpbGUgdGhlIG5v ZGVzIGFyZSBhbHNvIHJlbW92ZWQgb3V0c2lkZSBvZiB0aGUgdHJhbnNhY3Rpb24uIFNvIHRo ZSBzdW0gDQo+Pj4gb2YgImQtPm5iZW50cnkgKyByZXQiIHdvdWxkIGJlIG5lZ2F0aXZlIHJl c3VsdGluZyB0byBhIGZhaWx1cmUgaGVyZS4NCj4+DQo+PiBUaGFua3MgZm9yIGNhdGNoaW5n IHRoaXMuDQo+Pg0KPj4gSSB0aGluayB0aGUgY29ycmVjdCB3YXkgdG8gaGFuZGxlIHRoaXMg aXMgdG8gcmV0dXJuIG1heChkLT5uYmVudHJ5ICsgcmV0LCAwKSBpbg0KPj4gZG9tYWluX25i ZW50cnlfYWRkKCkuIFRoZSB2YWx1ZSBtaWdodCBiZSBpbXByZWNpc2UsIGJ1dCBhbHdheXMg Pj0gMCBhbmQgbmV2ZXINCj4+IHdyb25nIG91dHNpZGUgb2YgYSB0cmFuc2FjdGlvbiBjb2xs aXNpb24uDQo+IA0KPiBJIGFtIGJpdCBjb25mdXNlZCB3aXRoIHlvdXIgcHJvcG9zYWwuIElm IHRoZSByZXR1cm4gdmFsdWUgaXMgaW1wcmVjaXNlLCB0aGVuIA0KPiB3aGF0J3MgdGhlIHBv aW50IG9mIHJldHVybmluZyBtYXgoLi4uKSBpbnN0ZWFkIG9mIHNpbXBseSAwPw0KDQpQbGVh c2UgaGF2ZSBhIGxvb2sgYXQgdGhlIHVzZSBjYXNlIGVzcGVjaWFsbHkgaW4gZG9tYWluX25i ZW50cnkoKS4gUmV0dXJuaW5nDQphbHdheXMgMCB3b3VsZCBjbGVhcmx5IGJyZWFrIHF1b3Rh IGNoZWNrcy4NCg0KDQpKdWVyZ2VuDQo= --------------scW0k8HS13oUkWvjPCSjh6EM Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------scW0k8HS13oUkWvjPCSjh6EM-- --------------D1bTzj0mMMmwYj7UHgbYlVoj-- --------------4Una2fEaNf807I0FAxj007AF Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmO/n2wFAwAAAAAACgkQsN6d1ii/Ey8w uwf+Im8UXjqCT06RyrHbhWgjkYeRYKz9lfPGAaD5qEMECYX7jFmE6/WKsNVlKOK5UKt37zRat2VL ppqZm414mCaR+gAIxjBdIeN+2wWn+WvHKQt5m48REqXJb1S6LmEbUpWo482NonfnMOlR6mUVi+XF OExG7VZAZ9DBFrVqkrYXonWvoh1gMzI3rMHsWxpv33piDfOp8wcHuvrES42ywYJ/72zg/d7DigI4 SWc4AihBlLV1chrdj6oBQLOvNq3Ojxhc+OhGRjiCNmvDD9PvlRE51nLK2lNYB1FFGmK9h5fksm3E Bfscl4tKYcvTPyBTxEh8smhjG5KJKNk0FNSOFAaw1w== =7sHy -----END PGP SIGNATURE----- --------------4Una2fEaNf807I0FAxj007AF-- From xen-devel-bounces@lists.xenproject.org Thu Jan 12 06:23:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 06:23:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475833.737682 (Exim 4.92) (envelope-from ) id 1pFqzf-0007Z2-Qq; Thu, 12 Jan 2023 06:23:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475833.737682; Thu, 12 Jan 2023 06:23:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFqzf-0007Yv-MN; Thu, 12 Jan 2023 06:23:19 +0000 Received: by outflank-mailman (input) for mailman id 475833; Thu, 12 Jan 2023 06:23:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFqze-0007Y4-G7 for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 06:23:18 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2064.outbound.protection.outlook.com [40.107.104.64]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 99122d91-9241-11ed-91b6-6bf2151ebd3b; Thu, 12 Jan 2023 07:23:16 +0100 (CET) Received: from FR3P281CA0150.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::19) by AS8PR08MB9600.eurprd08.prod.outlook.com (2603:10a6:20b:618::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Thu, 12 Jan 2023 06:23:06 +0000 Received: from VI1EUR03FT039.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:95:cafe::84) by FR3P281CA0150.outlook.office365.com (2603:10a6:d10:95::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6023.6 via Frontend Transport; Thu, 12 Jan 2023 06:23:06 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT039.mail.protection.outlook.com (100.127.144.77) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.13 via Frontend Transport; Thu, 12 Jan 2023 06:23:05 +0000 Received: ("Tessian outbound 333ca28169fa:v132"); Thu, 12 Jan 2023 06:23:04 +0000 Received: from a7c287fc9c2f.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 338A23BB-E575-4500-918C-2F41A2084C16.1; Thu, 12 Jan 2023 06:22:54 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a7c287fc9c2f.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 12 Jan 2023 06:22:54 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by AS4PR08MB7686.eurprd08.prod.outlook.com (2603:10a6:20b:505::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Thu, 12 Jan 2023 06:22:52 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::72d6:6a74:b637:cc5b]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::72d6:6a74:b637:cc5b%3]) with mapi id 15.20.5986.018; Thu, 12 Jan 2023 06:22:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 99122d91-9241-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QG74g9kF2EkooN9cmiYACMFGBjheAxkc/5lBhzwQxZ4=; b=zOzIkZ5VdBMjyI7FoOpYbBkodowkTJLKtcKqoTI6Ec+CmH10kFhMlwIEJU/nK00IQ0gDYFa3zAoiu9ZTIH8MFU5+QwmaQM1NofDHaBJtblL1uyEV8w0Yd8Jyy8q1xNf8Kv+MILAwWPfYcggAOQK+TH5J64VkPXFEpMZpzcIogTw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B70hFksJmg3r9RA6ZjcZtBCLMy5eSrSo7fxiwvAOOphBLBG/Fps0pXsWHDm+TNXVZOJcSdnJlDd30MbS2+KyMH2PA7Z2S32ItCTueL4XV2o/BMGbDkNXCqXuBAL6W4IhHLQ98QiCWnFy8bGaDamW5SeLoPS9oHQmAmTCm2dwrH4zeSq5cw7bMXexwnRQjzoVoaWgTyktISmJN3ZwsEj72csYyXAGPnbhBpJKkMnN6nOq/P5G332Ca+w4B053UHjpZFi/pVqMvJFdkfET0jC0d64bj3KyQ7VWO6kmsiWG8suvyGyrnHBnnQqWfeXT41zbGQkFE/pIxUW/iW4xsdRU2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QG74g9kF2EkooN9cmiYACMFGBjheAxkc/5lBhzwQxZ4=; b=Zw1B0I9lFGiw221OiPCYDt6vL/gs08AEgkH+HhtAKgsB0fD82dvE0N3NGFNn7SpW7OwsEs2zyD94E1vn9GGYkpt8kIRjJfQDBUmobVuwHC0AWKwPLb2l0Gr0o4MxKHEdiNiV74LZX7Nry0yPr9FhewiX+w39/wIaMOR6+H/SppdpFnDj5gBf4htWG2KHWCHPOBXx9Zd36woNI2WvnRx3RDA3ehdZzEJKO2SaOgFycpELESKEWHtf4Kl60wXg18z93CR6MxSr5nq4Qf/qawblQ1igoQGkzYLm5XvsTTy3mjhU3lOtmIf6UphE2y2v/enQ7HpKWmUkvVQAMT8j4f/+BA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QG74g9kF2EkooN9cmiYACMFGBjheAxkc/5lBhzwQxZ4=; b=zOzIkZ5VdBMjyI7FoOpYbBkodowkTJLKtcKqoTI6Ec+CmH10kFhMlwIEJU/nK00IQ0gDYFa3zAoiu9ZTIH8MFU5+QwmaQM1NofDHaBJtblL1uyEV8w0Yd8Jyy8q1xNf8Kv+MILAwWPfYcggAOQK+TH5J64VkPXFEpMZpzcIogTw= From: Wei Chen To: Jan Beulich CC: nd , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v2 02/17] xen/arm: implement helpers to get and update NUMA status Thread-Topic: [PATCH v2 02/17] xen/arm: implement helpers to get and update NUMA status Thread-Index: AQHZJNEXNkX9GZxGhkCgYl8odWGCka6X2i6AgAJ2fxA= Date: Thu, 12 Jan 2023 06:22:52 +0000 Message-ID: References: <20230110084930.1095203-1-wei.chen@arm.com> <20230110084930.1095203-3-wei.chen@arm.com> <9e32ffa1-1499-f9cd-7ca8-f9493b1269cb@suse.com> In-Reply-To: <9e32ffa1-1499-f9cd-7ca8-f9493b1269cb@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 72CDFF01A6516C4E84A795F1433F4290.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAXPR08MB7420:EE_|AS4PR08MB7686:EE_|VI1EUR03FT039:EE_|AS8PR08MB9600:EE_ X-MS-Office365-Filtering-Correlation-Id: b1de7add-2af5-4e17-7e90-08daf4657713 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: AWK5C6lPJb1h1bwpm71JrS87YkNU7Wc2S/y3U+swk3s2u3Kg9JNpwHZsV5Kd1JfPASwVXqDp0SdWu7avOcrvKlifJklfj80pAOeYeotmXApGg5Jj/L7dClOx+hFRMGShbFn2rBUO4EEJogdClWEYXeClgwDbQ/Svv2wBn/DJBJWJpahWbncdUY2kPcr64hA3EHqATq5FXYefCVVZ7N62Zcrfjb7wD7t4sxQ3PRtH5aeeuFrcge5Pfv3qEE3HUuuHYNBFf2f/osF5aZD9A2fScQOCrVVtftu6sovffSwfhq/lUEh20nGbqNb47/mw2B1LyoQs2IM8ZNBdv78KwnW8UJgAipDltXiM/j1+I2SjawqqJ8KPNkyY83qFVHbYYOX/k+70BCHev13R/tSnE95nYJ0EY17aX058hYSPk9P7Pp810RwRhz0xvfaEJpKlYsxFUqie5TyNqhMgXLZ/gfCc0KqlfAcqgyi984B+XrgHVmj4tyA3YbXO7Uij+8bmA1cZWJQyE6TLhTEToyYObZUMhtKCXtiwlwzMSg8BN/qVHse4x6DYPAvV/j7A6pn+fTaVj5Qu4gA8/afLznlDn5T3DeYj8810N/cvBqB3jwH7SsZX4Xw725a1VKEFACg01+gu1T5aOBTInVu+BG0aaT1usbozGRch1nu0w2AhGBwcwhNv+10PW4vzwYSCu5/kBO2CPf+dqfmYs4Sk3GISuqc5e7D38PNr0p3ovqMmOaC6jztXPKWxKnucnI9Ea73FOhDG X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(39860400002)(376002)(366004)(396003)(451199015)(33656002)(7696005)(38070700005)(86362001)(55016003)(54906003)(316002)(6506007)(71200400001)(6916009)(66446008)(2906002)(76116006)(478600001)(8676002)(64756008)(41300700001)(52536014)(66946007)(66476007)(15650500001)(4326008)(8936002)(66556008)(53546011)(5660300002)(38100700002)(122000001)(26005)(186003)(9686003)(83380400001)(2004002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB7686 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: add1b981-b78e-46ed-f646-08daf4656f4e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tWzoxOZous/iAjy1fAQMAwc8SpHWlSlL8KsenKe0ZlUDLUoIzp5Ls5cmPEn5lz8j2ZptiHQ2TlqVn6VEuWgwstcmPMlB3a+RLtHRw8Hvsbiq4aFPFvbkr8xT5/zW5E50bKgQ1cNPjqRA6WRJX0btWMQC3UMW6FPx0jzAwBwhRhYM9glMno7BYxT2/IXwCMUay23jSJlsDKsQgNrR2HMB3k6kCewS4A9nHLNuSTpvefcMfw0/uZB8o8ZYnNdtE6JyPOWdQ6jJAZtHnQ5QYI2jaGeP5nD+5xlAxRYebdM4El1mKAGYuASx4xpfxj/zd6th5+5xwiRG3x/ACku7AUnF72RInsEHKTgueNM7JIgnpaYwyLIWWxrif4P8flhVtdbZgwHxh5UM9qjiqnQzlLYQ7S6UiZP+K/n4pUb483SKieISJnuSmj6bkuCh5reCPvnGA50KChssWPU4UTJbODBf3qD1iGSQks5fWVuKy1vV66H1+naUdwjbu60w/L2xg9zOTBQtDtqDoV13AvdkAs6D/wUsn+togtWn6kRiq0VZlQGmVeW4pfY+QbzGmRVFDBhgKNksmjYJdyz5ZOEXX4vbLwGeBHBomDC2CKnupibERiowQIn0W+MN94dfmpHfPVPJ/tKR3btZu1MoirflMzWiirlavcaDfrx7kaS6bZYk89wEwjGuGDQAewZhsyvz9ARNQnNa5hOr1YEctABU/hwE31cUgA9MKPAhitQG/lEzwA9D1AcWirlrl5/1auQ3QyPk X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(136003)(396003)(376002)(451199015)(40470700004)(46966006)(36840700001)(7696005)(33656002)(54906003)(83380400001)(8676002)(55016003)(2906002)(316002)(70586007)(70206006)(4326008)(356005)(36860700001)(81166007)(82740400003)(47076005)(82310400005)(40460700003)(53546011)(9686003)(6506007)(186003)(86362001)(478600001)(40480700001)(26005)(336012)(6862004)(8936002)(5660300002)(15650500001)(52536014)(41300700001)(2004002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 06:23:05.1580 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b1de7add-2af5-4e17-7e90-08daf4657713 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9600 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU2VudDogMjAyM+W5tDHmnIgxMeaXpSAwOjM4DQo+ IFRvOiBXZWkgQ2hlbiA8V2VpLkNoZW5AYXJtLmNvbT4NCj4gQ2M6IG5kIDxuZEBhcm0uY29tPjsg U3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPjsgSnVsaWVuDQo+IEdy YWxsIDxqdWxpZW5AeGVuLm9yZz47IEJlcnRyYW5kIE1hcnF1aXMgPEJlcnRyYW5kLk1hcnF1aXNA YXJtLmNvbT47DQo+IFZvbG9keW15ciBCYWJjaHVrIDxWb2xvZHlteXJfQmFiY2h1a0BlcGFtLmNv bT47IEFuZHJldyBDb29wZXINCj4gPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+OyBHZW9yZ2Ug RHVubGFwIDxnZW9yZ2UuZHVubGFwQGNpdHJpeC5jb20+OyBXZWkNCj4gTGl1IDx3bEB4ZW4ub3Jn PjsgUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+OyB4ZW4tDQo+IGRldmVs QGxpc3RzLnhlbnByb2plY3Qub3JnDQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjIgMDIvMTddIHhl bi9hcm06IGltcGxlbWVudCBoZWxwZXJzIHRvIGdldCBhbmQgdXBkYXRlDQo+IE5VTUEgc3RhdHVz DQo+IA0KPiBPbiAxMC4wMS4yMDIzIDA5OjQ5LCBXZWkgQ2hlbiB3cm90ZToNCj4gPiAtLS0gYS94 ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vbnVtYS5oDQo+ID4gKysrIGIveGVuL2FyY2gvYXJtL2lu Y2x1ZGUvYXNtL251bWEuaA0KPiA+IEBAIC0yMiw2ICsyMiwxMiBAQCB0eXBlZGVmIHU4IG5vZGVp ZF90Ow0KPiA+ICAgKi8NCj4gPiAgI2RlZmluZSBOUl9OT0RFX01FTUJMS1MgTlJfTUVNX0JBTktT DQo+ID4NCj4gPiArZW51bSBkdF9udW1hX3N0YXR1cyB7DQo+ID4gKyAgICBEVF9OVU1BX0lOSVQs DQo+IA0KPiBJIGRvbid0IHNlZSBhbnkgdXNlIG9mIHRoaXMuIEkgYWxzbyB0aGluayB0aGUgbmFt ZSBpc24ndCBnb29kLCBhcyBJTklUDQo+IGNhbiBiZSB0YWtlbiBmb3IgImluaXRpYWxpemVyIiBh cyB3ZWxsIGFzICJpbml0aWFsaXplZCIuIFN1Z2dlc3RpbmcgYW4NCj4gYWx0ZXJuYXRpdmUgd291 bGQgcmVxdWlyZSBrbm93aW5nIHdoYXQgdGhlIGZ1dHVyZSBwbGFucyB3aXRoIHRoaXMgYXJlOw0K PiByaWdodCBub3cgLi4uDQo+IA0KDQpzdGF0aWMgZW51bSBkdF9udW1hX3N0YXR1cyBfX3JlYWRf bW9zdGx5IGRldmljZV90cmVlX251bWE7DQpXZSB1c2UgRFRfTlVNQV9JTklUIHRvIGluZGljYXRl IGRldmljZV90cmVlX251bWEgaXMgaW4gYSBkZWZhdWx0IHZhbHVlDQooU3lzdGVtJ3MgaW5pdGlh bCB2YWx1ZSwgaGFzbid0IGRvbmUgaW5pdGlhbGl6YXRpb24pLiBNYXliZSByZW5hbWUgaXQNClRv IERUX05VTUFfVU5JTklUIGJlIGJldHRlcj8NCg0KPiA+ICsgICAgRFRfTlVNQV9PTiwNCj4gPiAr ICAgIERUX05VTUFfT0ZGLA0KPiA+ICt9Ow0KPiANCj4gLi4uIHRoZSBvdGhlciB0d28gYXJlIGFs c28gdXNlZCBvbmx5IGluIGEgc2luZ2xlIGZpbGUsIGF0IHdoaWNoIHBvaW50DQo+IHRoZWlyIHBs YWNpbmcgaW4gYSBoZWFkZXIgaXMgYWxzbyBxdWVzdGlvbmFibGUuDQo+DQoNClRoaXMgaXMgYSBn b29kIHBvaW50LCBJIHdpbGwgbW92ZSB0aGVtIHRvIHRoYXQgZmlsZS4NCg0KPiA+IC0tLSAvZGV2 L251bGwNCj4gPiArKysgYi94ZW4vYXJjaC9hcm0vbnVtYS5jDQo+ID4gQEAgLTAsMCArMSw0NCBA QA0KPiA+ICsvKiBTUERYLUxpY2Vuc2UtSWRlbnRpZmllcjogR1BMLTIuMCAqLw0KPiA+ICsvKg0K PiA+ICsgKiBBcm0gQXJjaGl0ZWN0dXJlIHN1cHBvcnQgbGF5ZXIgZm9yIE5VTUEuDQo+ID4gKyAq DQo+ID4gKyAqIENvcHlyaWdodCAoQykgMjAyMSBBcm0gTHRkDQo+ID4gKyAqDQo+ID4gKyAqIFRo aXMgcHJvZ3JhbSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQv b3IgbW9kaWZ5DQo+ID4gKyAqIGl0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIEdlbmVyYWwg UHVibGljIExpY2Vuc2UgdmVyc2lvbiAyIGFzDQo+ID4gKyAqIHB1Ymxpc2hlZCBieSB0aGUgRnJl ZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLg0KPiA+ICsgKg0KPiA+ICsgKiBUaGlzIHByb2dyYW0gaXMg ZGlzdHJpYnV0ZWQgaW4gdGhlIGhvcGUgdGhhdCBpdCB3aWxsIGJlIHVzZWZ1bCwNCj4gPiArICog YnV0IFdJVEhPVVQgQU5ZIFdBUlJBTlRZOyB3aXRob3V0IGV2ZW4gdGhlIGltcGxpZWQgd2FycmFu dHkgb2YNCj4gPiArICogTUVSQ0hBTlRBQklMSVRZIG9yIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxB UiBQVVJQT1NFLiAgU2VlIHRoZQ0KPiA+ICsgKiBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBm b3IgbW9yZSBkZXRhaWxzLg0KPiA+ICsgKg0KPiA+ICsgKiBZb3Ugc2hvdWxkIGhhdmUgcmVjZWl2 ZWQgYSBjb3B5IG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZQ0KPiA+ICsgKiBhbG9u ZyB3aXRoIHRoaXMgcHJvZ3JhbS4gSWYgbm90LCBzZWUgPGh0dHA6Ly93d3cuZ251Lm9yZy9saWNl bnNlcy8+Lg0KPiA+ICsgKg0KPiA+ICsgKi8NCj4gPiArI2luY2x1ZGUgPHhlbi9pbml0Lmg+DQo+ ID4gKyNpbmNsdWRlIDx4ZW4vbnVtYS5oPg0KPiA+ICsNCj4gPiArc3RhdGljIGVudW0gZHRfbnVt YV9zdGF0dXMgX19yZWFkX21vc3RseSBkZXZpY2VfdHJlZV9udW1hOw0KPiANCj4gX19yb19hZnRl cl9pbml0Pw0KPg0KDQpPSy4NCiANCj4gPiAtLS0gYS94ZW4vYXJjaC94ODYvaW5jbHVkZS9hc20v bnVtYS5oDQo+ID4gKysrIGIveGVuL2FyY2gveDg2L2luY2x1ZGUvYXNtL251bWEuaA0KPiA+IEBA IC0xMiw3ICsxMiw2IEBAIGV4dGVybiB1bnNpZ25lZCBpbnQgbnVtYV9ub2RlX3RvX2FyY2hfbmlk KG5vZGVpZF90IG4pOw0KPiA+DQo+ID4gICNkZWZpbmUgWk9ORV9BTElHTiAoMVVMIDw8IChNQVhf T1JERVIrUEFHRV9TSElGVCkpDQo+ID4NCj4gPiAtZXh0ZXJuIGJvb2wgbnVtYV9kaXNhYmxlZCh2 b2lkKTsNCj4gPiAgZXh0ZXJuIG5vZGVpZF90IHNldHVwX25vZGUodW5zaWduZWQgaW50IHB4bSk7 DQo+ID4gIGV4dGVybiB2b2lkIHNyYXRfZGV0ZWN0X25vZGUoaW50IGNwdSk7DQo+ID4NCj4gPiAt LS0gYS94ZW4vaW5jbHVkZS94ZW4vbnVtYS5oDQo+ID4gKysrIGIveGVuL2luY2x1ZGUveGVuL251 bWEuaA0KPiA+IEBAIC01NSw2ICs1NSw3IEBAIGV4dGVybiB2b2lkIG51bWFfaW5pdF9hcnJheSh2 b2lkKTsNCj4gPiAgZXh0ZXJuIHZvaWQgbnVtYV9zZXRfbm9kZSh1bnNpZ25lZCBpbnQgY3B1LCBu b2RlaWRfdCBub2RlKTsNCj4gPiAgZXh0ZXJuIHZvaWQgbnVtYV9pbml0bWVtX2luaXQodW5zaWdu ZWQgbG9uZyBzdGFydF9wZm4sIHVuc2lnbmVkIGxvbmcNCj4gZW5kX3Bmbik7DQo+ID4gIGV4dGVy biB2b2lkIG51bWFfZndfYmFkKHZvaWQpOw0KPiA+ICtleHRlcm4gYm9vbCBudW1hX2Rpc2FibGVk KHZvaWQpOw0KPiA+DQo+ID4gIGV4dGVybiBpbnQgYXJjaF9udW1hX3NldHVwKGNvbnN0IGNoYXIg Km9wdCk7DQo+ID4gIGV4dGVybiBib29sIGFyY2hfbnVtYV91bmF2YWlsYWJsZSh2b2lkKTsNCj4g DQo+IEhvdyBpcyB0aGlzIG1vdmVtZW50IG9mIGEgZGVjbGFyYXRpb24gcmVsYXRlZCB0byB0aGUg c3ViamVjdCBvZiB0aGUgcGF0Y2g/DQo+DQoNCkNhbiBJIGFkZCBzb21lIG1lc3NhZ2VzIGluIGNv bW1pdCBsb2cgdG8gc2F5IHNvbWV0aGluZyBsaWtlICJBcyB3ZSBoYXZlDQpJbXBsZW1lbnRlZCBu dW1hX2Rpc2FibGVkIGZvciBBcm0sIHNvIHdlIG1vdmUgbnVtYV9kaXNhYmxlZCB0byBjb21tb24g aGVhZGVyIj8NCg0KQ2hlZXJzLA0KV2VpIENoZW4NCiANCj4gSmFuDQo= From xen-devel-bounces@lists.xenproject.org Thu Jan 12 06:32:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 06:32:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475839.737692 (Exim 4.92) (envelope-from ) id 1pFr8A-0000co-Mt; Thu, 12 Jan 2023 06:32:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475839.737692; Thu, 12 Jan 2023 06:32:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFr8A-0000ch-JP; Thu, 12 Jan 2023 06:32:06 +0000 Received: by outflank-mailman (input) for mailman id 475839; Thu, 12 Jan 2023 06:32:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFr89-0000cb-84 for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 06:32:05 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2073.outbound.protection.outlook.com [40.107.105.73]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d1d0274c-9242-11ed-b8d0-410ff93cb8f0; Thu, 12 Jan 2023 07:32:00 +0100 (CET) Received: from FR3P281CA0197.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a5::7) by AM7PR08MB5320.eurprd08.prod.outlook.com (2603:10a6:20b:103::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.9; Thu, 12 Jan 2023 06:31:59 +0000 Received: from VI1EUR03FT007.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:a5:cafe::ae) by FR3P281CA0197.outlook.office365.com (2603:10a6:d10:a5::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6023.6 via Frontend Transport; Thu, 12 Jan 2023 06:31:58 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT007.mail.protection.outlook.com (100.127.144.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.13 via Frontend Transport; Thu, 12 Jan 2023 06:31:58 +0000 Received: ("Tessian outbound 3ad958cd7492:v132"); Thu, 12 Jan 2023 06:31:57 +0000 Received: from c44bca52d657.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 52929A84-EA63-4D54-8244-C6087760E8A6.1; Thu, 12 Jan 2023 06:31:47 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c44bca52d657.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 12 Jan 2023 06:31:46 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by DB3PR08MB9036.eurprd08.prod.outlook.com (2603:10a6:10:430::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Thu, 12 Jan 2023 06:31:43 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::72d6:6a74:b637:cc5b]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::72d6:6a74:b637:cc5b%3]) with mapi id 15.20.5986.018; Thu, 12 Jan 2023 06:31:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d1d0274c-9242-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w5MJBmVnVO9Knbigf1UQ+k5MGPHNfykIyXH4ko+N7FY=; b=32GgXTe+Q7qy3dr1+nATE7sL+6hsLtI90xcWXKKC1V27j7qDqKDC1amEbec76Xt9CPVb+sqHaxLvzhe2UkT2W+kjp/am7UGWxr9WQm/7ta/GFmXxZphy0bAhgHUQ0TAioLFb7Ec6ye4yivv/jxns6YuY+Gag/qQjOhQxPcjge+w= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZSjZ+2Gsl7jLzWty6iNRC6V5l51MHA50gdDs2QGH4HAvHe8CN/3diACot7xNLE9b3cmE6aKS8ufyIs/xLW46LaHsqRrquh9bRN7euiYNtRXWY1z4ugke6H/86x/EDBsnLh2l5nytUIiOvgAq6k51Dbjl+wvBVSx4SxlKuR4Dn9sm5RFWom6XB14gote+GSUgP0yHE30wzcOT34o7SOucFOR8gxeDaUrxy9BPGxNWpIOwJG7kXUw5/IrXrJDOyh2SCbgAiGBNtU8XTjHtd3y397m+7sg3m3etZJ+XXQX3Sqj7IVmAFjAa7UNK/mC48vYLvAcN+fl6EdXuX8Nr7Bry4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w5MJBmVnVO9Knbigf1UQ+k5MGPHNfykIyXH4ko+N7FY=; b=agIBrEMm3g5Gyq/nB92jqxg2BBwMXx4kj/dY/w38oxpxIZq4SrHNTw9E1ZGC5lmXEx9cKwKH7aFrPl6ZpH2kexKNUcQYB3vJI/1a9H5IprFfTPbkeZKr1X2Ie4PFj8hR4lNnIYlMOK+Gto5Cup3S5fmBJS8jThz3UJZd42ZCH5WcMknDYpR5KOoOQw/sX5K8zUv8yNqxwYytNdbIiQ4GMPqtFh1Z7QCsWy68TCx3m8FXBXODn+LXLQMhPTvv4UHJFhna0UUtGfky0BKkm+YPEgyRNcVz9Ej0/SKnStPq0uESgJJYw6EKmrlraleoA7pbJe65b4ibPKDLlgguYJyJXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w5MJBmVnVO9Knbigf1UQ+k5MGPHNfykIyXH4ko+N7FY=; b=32GgXTe+Q7qy3dr1+nATE7sL+6hsLtI90xcWXKKC1V27j7qDqKDC1amEbec76Xt9CPVb+sqHaxLvzhe2UkT2W+kjp/am7UGWxr9WQm/7ta/GFmXxZphy0bAhgHUQ0TAioLFb7Ec6ye4yivv/jxns6YuY+Gag/qQjOhQxPcjge+w= From: Wei Chen To: Jan Beulich CC: nd , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v2 03/17] xen/arm: implement node distance helpers for Arm Thread-Topic: [PATCH v2 03/17] xen/arm: implement node distance helpers for Arm Thread-Index: AQHZJNEfrPi0xon1hUWBAoFjpzsCdK6X3MQAgAJ3JNA= Date: Thu, 12 Jan 2023 06:31:43 +0000 Message-ID: References: <20230110084930.1095203-1-wei.chen@arm.com> <20230110084930.1095203-4-wei.chen@arm.com> <9fd67aa2-0bd5-16a2-1e19-139504c2090f@suse.com> In-Reply-To: <9fd67aa2-0bd5-16a2-1e19-139504c2090f@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 67DA167C1D11F84C80FB928E26319960.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAXPR08MB7420:EE_|DB3PR08MB9036:EE_|VI1EUR03FT007:EE_|AM7PR08MB5320:EE_ X-MS-Office365-Filtering-Correlation-Id: 8699eb11-5d92-4dce-24bc-08daf466b4d6 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: SaV3/Zx6UyY1ayleyg+Lj3YAthMzlvsv7crxDTJs+HkVZ8eGpvt3+rksuI8G89hVan8tMoUetguUR0qPveh7pKR8/KqoowdpSjTajwk5KzviKKqu9Gx9VvK2yB/cRFGdH5JP/yD/kdXmVoBekhzgF2MR3mnxwhBWHRdm3gKDKWyQKtXRLh2cNi+ynncWngHkjW5MYen4bXJwFp5zF3JcdvCL+Kzj3soIEfA0iocxE5aQWiA4uDHF2VHNQ6y/hIxOh31cxdnsnH2M0kePqDaH0qZJuSjKZCtplhR9p6tHjx54gjWXp/fb5heKiyLKK67syDWcnBjh+yjLn+6wH/kZX23LMS1tpaxS4eVSIUM68GbllZhFitpRAe7AFAH2wlhOIxY4ihxGvhnJobaqMyUZZIPE4YPZKA1qFY/yfJJGkOmmg7PJtoHL47Z+9ZjiVh6JPL60okN2+cr4TKHQ36HvFyzRfzyH8ItTUHiCS3pfLt1gC/1rc5zBs5a+ySx/P2w9FwTa8zqUw4UvXoUJqmBPo63LPa10kblW/wwpq16rsxgs9ihigydg6GH+CWvjyNn2GsGsAB9bMvtRrXKSd8rvIUokch85xlyO49n4S+ngvDLvGtxfu9/Vm9LKYZJapWAidwUtS/+BB/W959a84vTKz0YUvDxOorfRxzEcZLdbSMue3Z0VKaM5WyrP+T7JmlDBm81yF6iG7fAikjaiMYDVr9AalvHOS1RvLYbm8Y5QZcM= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(39860400002)(376002)(136003)(346002)(396003)(451199015)(2906002)(9686003)(5660300002)(38100700002)(8936002)(33656002)(66556008)(66446008)(64756008)(4326008)(8676002)(41300700001)(76116006)(66946007)(83380400001)(66476007)(52536014)(55016003)(316002)(86362001)(6916009)(71200400001)(186003)(7696005)(122000001)(26005)(54906003)(6506007)(38070700005)(53546011)(478600001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR08MB9036 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT007.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: f52fbe73-671b-44d3-72c9-08daf466abe6 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: llFdW67WBQNIY/bMXjhHtf+A39xsijzTaYemvmFOLEPq/itJkUKWpbaaf43PiBZy1tAbiUKZj0TtRGqh2QF+ciZuOzPX2dT3RY/Gs8y6dVdr0z5zN3IiBQsnEX0Z6E3sn0lEGAn8YeO5ezw6hQcIiEvqLpOKIMtDpit0Av5dDR2G5sCcVjIs+XZOwnbB6SQbisxv+Y43pPUSzgIp7l+KGjdVnePePoI0dVBVuOjG3aFSyb04ktgVFXXDQxmqmDSLoKhXSSaiwCuYht/2g1W9psbooJOE6AxPtFSz/1lrBx3dztbAlgfbZkPUQ2IB0ZMc569Inc7iyP0mOuEuOpOxLBgsfPFqEd6boMHM02GLXSC9hL4Ml2fOn7YPkQwNo7XjMGcsF8NrYwVXNF6DyOfv5E5DcikFrXHtpFnTuE+pn368oRREj8hO42YFo0OEYXu9H3g7jUcA/9WVfXHS1+xsZ5lqjixJExt+T9UxUROX9js0T5dNfhnVUcTIQN934Ecdm+kzmp6OsFmpKADqkn1n0WzRtalALhhFT/gOiQMEVJA6kBjMNPbluVxOwwaanyLunYvrfHn4cQaJYBW/GVOJX2TV9MOwTgcAxkC1IV7tG4ISV3p2fVtZWOdcIKi2ZS5ZcA5JIGJmN/uQmFR6lteoE/Z4y10XJMUCLOjK9Ye0NYZuvPKby+vnrt3nfGGpvND6RU0ns8HZ/u+H7ceiq2pvU4vN+q1Vbc3HCsxnLkaESkE= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(376002)(39860400002)(346002)(451199015)(40470700004)(46966006)(36840700001)(336012)(82740400003)(7696005)(52536014)(86362001)(356005)(33656002)(316002)(40460700003)(9686003)(53546011)(6506007)(186003)(26005)(4326008)(8676002)(54906003)(81166007)(70206006)(70586007)(478600001)(41300700001)(40480700001)(36860700001)(55016003)(5660300002)(47076005)(6862004)(8936002)(2906002)(82310400005)(83380400001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 06:31:58.2714 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8699eb11-5d92-4dce-24bc-08daf466b4d6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT007.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5320 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU2VudDogMjAyM+W5tDHmnIgxMeaXpSAwOjQ3DQo+ IFRvOiBXZWkgQ2hlbiA8V2VpLkNoZW5AYXJtLmNvbT4NCj4gQ2M6IG5kIDxuZEBhcm0uY29tPjsg U3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPjsgSnVsaWVuDQo+IEdy YWxsIDxqdWxpZW5AeGVuLm9yZz47IEJlcnRyYW5kIE1hcnF1aXMgPEJlcnRyYW5kLk1hcnF1aXNA YXJtLmNvbT47DQo+IFZvbG9keW15ciBCYWJjaHVrIDxWb2xvZHlteXJfQmFiY2h1a0BlcGFtLmNv bT47IEFuZHJldyBDb29wZXINCj4gPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+OyBHZW9yZ2Ug RHVubGFwIDxnZW9yZ2UuZHVubGFwQGNpdHJpeC5jb20+OyBXZWkNCj4gTGl1IDx3bEB4ZW4ub3Jn PjsgUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+OyB4ZW4tDQo+IGRldmVs QGxpc3RzLnhlbnByb2plY3Qub3JnDQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjIgMDMvMTddIHhl bi9hcm06IGltcGxlbWVudCBub2RlIGRpc3RhbmNlIGhlbHBlcnMgZm9yDQo+IEFybQ0KPiANCj4g T24gMTAuMDEuMjAyMyAwOTo0OSwgV2VpIENoZW4gd3JvdGU6DQo+ID4gLS0tIGEveGVuL2FyY2gv YXJtL2luY2x1ZGUvYXNtL251bWEuaA0KPiA+ICsrKyBiL3hlbi9hcmNoL2FybS9pbmNsdWRlL2Fz bS9udW1hLmgNCj4gPiBAQCAtMjgsNiArMjgsMjAgQEAgZW51bSBkdF9udW1hX3N0YXR1cyB7DQo+ ID4gICAgICBEVF9OVU1BX09GRiwNCj4gPiAgfTsNCj4gPg0KPiA+ICsvKg0KPiA+ICsgKiBJbiBB Q1BJIHNwZWMsIDAtOSBhcmUgdGhlIHJlc2VydmVkIHZhbHVlcyBmb3Igbm9kZSBkaXN0YW5jZSwN Cj4gPiArICogMTAgaW5kaWNhdGVzIGxvY2FsIG5vZGUgZGlzdGFuY2UsIDIwIGluZGljYXRlcyBy ZW1vdGUgbm9kZQ0KPiA+ICsgKiBkaXN0YW5jZS4gU2V0IG5vZGUgZGlzdGFuY2UgbWFwIGluIGRl dmljZSB0cmVlIHdpbGwgZm9sbG93DQo+ID4gKyAqIHRoZSBBQ1BJJ3MgZGVmaW5pdGlvbi4NCj4g PiArICovDQo+ID4gKyNkZWZpbmUgTlVNQV9ESVNUQU5DRV9VREZfTUlOICAgMA0KPiA+ICsjZGVm aW5lIE5VTUFfRElTVEFOQ0VfVURGX01BWCAgIDkNCj4gPiArI2RlZmluZSBOVU1BX0xPQ0FMX0RJ U1RBTkNFICAgICAxMA0KPiA+ICsjZGVmaW5lIE5VTUFfUkVNT1RFX0RJU1RBTkNFICAgIDIwDQo+ IA0KPiBJbiB0aGUgYWJzZW5jZSBvZiBhIGNhbGxlciBvZiBudW1hX3NldF9kaXN0YW5jZSgpIGl0 IGlzIGVudGlyZWx5IHVuY2xlYXINCj4gd2hldGhlciB0aGlzIHR5aW5nIHRvIEFDUEkgdXNlZCB2 YWx1ZXMgaXMgYWN0dWFsbHkgYXBwcm9wcmlhdGUuDQo+IA0KDQpGcm9tIEtlcm5lbCdzIE5VTUEg ZGV2aWNlIHRyZWUgYmluZGluZywgaXQgc2VlbXMgRFQgTlVNQSBhcmUgcmV1c2luZw0KQUNQSSB1 c2VkIHZhbHVlcyBmb3IgZGlzdGFuY2VzIFsxXS4NCg0KPiA+IC0tLSBhL3hlbi9hcmNoL2FybS9u dW1hLmMNCj4gPiArKysgYi94ZW4vYXJjaC9hcm0vbnVtYS5jDQo+ID4gQEAgLTIsNyArMiw3IEBA DQo+ID4gIC8qDQo+ID4gICAqIEFybSBBcmNoaXRlY3R1cmUgc3VwcG9ydCBsYXllciBmb3IgTlVN QS4NCj4gPiAgICoNCj4gPiAtICogQ29weXJpZ2h0IChDKSAyMDIxIEFybSBMdGQNCj4gPiArICog Q29weXJpZ2h0IChDKSAyMDIyIEFybSBMdGQNCj4gDQo+IEkgZG9uJ3QgdGhpbmsgaXQgbWFrZXMg c2Vuc2UgdG8gY2hhbmdlIHN1Y2ggYWZ0ZXIgdGhlIGZhY3QuIEFuZCBjZXJ0YWlubHkNCj4gbm90 IGluIGFuIHVucmVsYXRlZCBwYXRjaC4NCj4gDQoNCkkgd2lsbCByZXRvcmUgaXQsIGFuZCBhZGQg YSBTUERYIGhlYWRlci4NCg0KPiA+IEBAIC0yMiw2ICsyMiwxMSBAQA0KPiA+DQo+ID4gIHN0YXRp YyBlbnVtIGR0X251bWFfc3RhdHVzIF9fcmVhZF9tb3N0bHkgZGV2aWNlX3RyZWVfbnVtYTsNCj4g Pg0KPiA+ICtzdGF0aWMgdW5zaWduZWQgY2hhciBfX3JlYWRfbW9zdGx5DQo+ID4gK25vZGVfZGlz dGFuY2VfbWFwW01BWF9OVU1OT0RFU11bTUFYX05VTU5PREVTXSA9IHsNCj4gPiArICAgIHsgMCB9 DQo+ID4gK307DQo+IA0KPiBfX3JvX2FmdGVyX2luaXQ/DQo+IA0KDQpZZXMuDQoNCj4gPiBAQCAt NDIsMyArNDcsNDggQEAgaW50IF9faW5pdCBhcmNoX251bWFfc2V0dXAoY29uc3QgY2hhciAqb3B0 KQ0KPiA+ICB7DQo+ID4gICAgICByZXR1cm4gLUVJTlZBTDsNCj4gPiAgfQ0KPiA+ICsNCj4gPiAr dm9pZCBfX2luaXQgbnVtYV9zZXRfZGlzdGFuY2Uobm9kZWlkX3QgZnJvbSwgbm9kZWlkX3QgdG8s DQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCBkaXN0YW5j ZSkNCj4gPiArew0KPiA+ICsgICAgaWYgKCBmcm9tID49IE1BWF9OVU1OT0RFUyB8fCB0byA+PSBN QVhfTlVNTk9ERVMgKQ0KPiA+ICsgICAgew0KPiA+ICsgICAgICAgIHByaW50ayhLRVJOX1dBUk5J TkcNCj4gPiArICAgICAgICAgICAgICAgIk5VTUE6IGludmFsaWQgbm9kZXM6IGZyb209JSJQUkl1 OCIgdG89JSJQUkl1OCINCj4gTUFYPSUiUFJJdTgiXG4iLA0KPiA+ICsgICAgICAgICAgICAgICBm cm9tLCB0bywgTUFYX05VTU5PREVTKTsNCj4gPiArICAgICAgICByZXR1cm47DQo+ID4gKyAgICB9 DQo+ID4gKw0KPiA+ICsgICAgLyogTlVNQSBkZWZpbmVzIDB4ZmYgYXMgYW4gdW5yZWFjaGFibGUg bm9kZSBhbmQgMC05IGFyZSB1bmRlZmluZWQNCj4gKi8NCj4gPiArICAgIGlmICggZGlzdGFuY2Ug Pj0gTlVNQV9OT19ESVNUQU5DRSB8fA0KPiA+ICsgICAgICAgIChkaXN0YW5jZSA+PSBOVU1BX0RJ U1RBTkNFX1VERl9NSU4gJiYNCj4gDQo+IE5pdDogSW5kZW50YXRpb24uDQo+IA0KDQpPay4NCg0K PiA+ICsgICAgICAgICBkaXN0YW5jZSA8PSBOVU1BX0RJU1RBTkNFX1VERl9NQVgpIHx8DQo+ID4g KyAgICAgICAgKGZyb20gPT0gdG8gJiYgZGlzdGFuY2UgIT0gTlVNQV9MT0NBTF9ESVNUQU5DRSkg KQ0KPiA+ICsgICAgew0KPiA+ICsgICAgICAgIHByaW50ayhLRVJOX1dBUk5JTkcNCj4gPiArICAg ICAgICAgICAgICAgIk5VTUE6IGludmFsaWQgZGlzdGFuY2U6IGZyb209JSJQUkl1OCIgdG89JSJQ Ukl1OCINCj4gZGlzdGFuY2U9JSJQUkl1MzIiXG4iLA0KPiA+ICsgICAgICAgICAgICAgICBmcm9t LCB0bywgZGlzdGFuY2UpOw0KPiA+ICsgICAgICAgIHJldHVybjsNCj4gPiArICAgIH0NCj4gPiAr DQo+ID4gKyAgICBub2RlX2Rpc3RhbmNlX21hcFtmcm9tXVt0b10gPSBkaXN0YW5jZTsNCj4gPiAr fQ0KPiA+ICsNCj4gPiArdW5zaWduZWQgY2hhciBfX25vZGVfZGlzdGFuY2Uobm9kZWlkX3QgZnJv bSwgbm9kZWlkX3QgdG8pDQo+ID4gK3sNCj4gPiArICAgIC8qIFdoZW4gTlVNQSBpcyBvZmYsIGFu eSBkaXN0YW5jZSB3aWxsIGJlIHRyZWF0ZWQgYXMgcmVtb3RlLiAqLw0KPiA+ICsgICAgaWYgKCBu dW1hX2Rpc2FibGVkKCkgKQ0KPiA+ICsgICAgICAgIHJldHVybiBOVU1BX1JFTU9URV9ESVNUQU5D RTsNCj4gPiArDQo+ID4gKyAgICAvKg0KPiA+ICsgICAgICogQ2hlY2sgd2hldGhlciB0aGUgbm9k ZXMgYXJlIGluIHRoZSBtYXRyaXggcmFuZ2UuDQo+ID4gKyAgICAgKiBXaGVuIGFueSBub2RlIGlz IG91dCBvZiByYW5nZSwgZXhjZXB0IGZyb20gYW5kIHRvIG5vZGVzIGFyZSB0aGUNCj4gPiArICAg ICAqIHNhbWUsIHdlIHRyZWF0IHRoZW0gYXMgdW5yZWFjaGFibGUgKHJldHVybiAweEZGKQ0KPiA+ ICsgICAgICovDQo+ID4gKyAgICBpZiAoIGZyb20gPj0gTUFYX05VTU5PREVTIHx8IHRvID49IE1B WF9OVU1OT0RFUyApDQo+IA0KPiBJIGd1ZXNzIHVzaW5nIEFSUkFZX1NJWkUoKSBoZXJlIHdvdWxk IGJlIG1vcmUgZnV0dXJlLXByb29mLg0KPiANCg0KSSB3aWxsIHVzZSBpdCBpbiBuZXh0IHZlcnNp b24uDQoNClsxXWh0dHBzOi8vd3d3Lmtlcm5lbC5vcmcvZG9jL0RvY3VtZW50YXRpb24vZGV2aWNl dHJlZS9iaW5kaW5ncy9udW1hLnR4dA0KDQpUaGFua3MsDQpXZWkgQ2hlbg0KDQo+IEphbg0K From xen-devel-bounces@lists.xenproject.org Thu Jan 12 07:04:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 07:04:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475846.737704 (Exim 4.92) (envelope-from ) id 1pFrdg-00048G-EF; Thu, 12 Jan 2023 07:04:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475846.737704; Thu, 12 Jan 2023 07:04:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFrdg-000489-A3; Thu, 12 Jan 2023 07:04:40 +0000 Received: by outflank-mailman (input) for mailman id 475846; Thu, 12 Jan 2023 07:04:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFrdf-00047z-Mr; Thu, 12 Jan 2023 07:04:39 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFrdf-00087N-KL; Thu, 12 Jan 2023 07:04:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFrdf-0002rc-3m; Thu, 12 Jan 2023 07:04:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pFrdf-0000fh-3J; Thu, 12 Jan 2023 07:04:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=7EZAOK/ePhuZPSB5cKOXYlvM8LHVvlyCtk2hpjW8SVE=; b=lK822K0y5PTiNcyLOce97hIx9N QXh8bvEp1GGRR6GGghZ4YuBzju31ATiqbjEbN3qk0p2NxOmMpRZUxtUYRq28qQnvcba8pUPMhxr9/ Y7XEaD3NLmEs7IrOBKvJD7ItpazFsfNtT6XpeQH2bIYgTxhFeHs1MaAtDWoS9N19pgVk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 175730: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=7dd4b804e08041ff56c88bdd8da742d14b17ed25 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Thu, 12 Jan 2023 07:04:39 +0000 flight 175730 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/175730/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine 8 reboot fail REGR. vs. 173462 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux 7dd4b804e08041ff56c88bdd8da742d14b17ed25 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 96 days Failing since 173470 2022-10-08 06:21:34 Z 96 days 202 attempts Testing same since 175717 2023-01-11 03:09:17 Z 1 days 3 attempts ------------------------------------------------------------ 3319 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 505897 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Jan 12 07:42:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 07:42:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475854.737714 (Exim 4.92) (envelope-from ) id 1pFsEP-0008PG-9l; Thu, 12 Jan 2023 07:42:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475854.737714; Thu, 12 Jan 2023 07:42:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFsEP-0008P9-6r; Thu, 12 Jan 2023 07:42:37 +0000 Received: by outflank-mailman (input) for mailman id 475854; Thu, 12 Jan 2023 07:42:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFsEN-0008P3-Uz for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 07:42:36 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on2084.outbound.protection.outlook.com [40.107.14.84]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ac896ff4-924c-11ed-b8d0-410ff93cb8f0; Thu, 12 Jan 2023 08:42:33 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8936.eurprd04.prod.outlook.com (2603:10a6:10:2e3::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Thu, 12 Jan 2023 07:42:31 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Thu, 12 Jan 2023 07:42:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ac896ff4-924c-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FkMgOd0XJmfbjlMJ8p7VTxFagW30Y6OKXGXHMz5HqA/SMJLGPqBjVxjgRr7GNkDxu3+ZlqfPyPPuNGjwNZvuMuLiaQVgM7AzfXnJRWKlW4xIC83dHK8bSmy9Qma6/oTvMz7bBz87ZMFYsyK50LGlA56VC+1RV50HU11DY5TTJi3e3RtKNFRq3KxSRl/UXcfc2Lrx1VaEdE1oPHuLz7ttazinwAe1dYWHzsg3lIUqgpEgHy/x4RE/GKDVHZbbwHHDXw8fOvVXXEsRPAhEwqR9WQciiMSKaI9o1YOSRk+ARBb1G5cXw5TReUnKXy1sqc3rGVTqb6Qz1gxW+29pKAH8Vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ynWFmUUDTwFMF3VF0PVzuuKnBb1tVw4O41z9x4c9Hmg=; b=ED13Bm7XDb6/7fhGMEnjUbVMim+8EyQiHY5J+s35rF9nyB3eyuR5UMHXFfi3g+3miQYvJ0S1TN8tD4yIZ32ZFpNxPFwPU9At6RYX/3VC5ENMw7rQ5N7mR2Yf1bz/EDDGFJ6KabQNK+XgEwlaUI9qLAkLtrJzmxOig6oTOZJEcmPNjwfnclHfwclM2Ij6EnDMozBZYQay2S2o1Z3IOHQwmtqpxQSUTD0QMnh76/6AN6qj2wz/GWfuefMwkwRKHWJJyqyg/pwf4rn1z+D2AU3qCY2lzPxEBL0/45a/FJFmshDocX2ya+Wlj7+F+QXVdwy0e4SqCyis0Y4kpStI6RKTSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ynWFmUUDTwFMF3VF0PVzuuKnBb1tVw4O41z9x4c9Hmg=; b=onhVBgryRSrb89w2hqXDOSU0nqEUIFxCqqNkQ6blp2CNBHdpbvtDVe0wCLjNZ1NAbV9O00Km/WqVEqgV+N/GWEyfsXq2jMW0RADrsgGMguxP/Qkr5ao+q95IsbegcGS8J8BxP390UusaSfNKsjj2jPvJ4V9Ip2qdAA7X9g3Hime1OxpQDooK1X0Xd8SIKVHOjifQF5MKyrQLc2IjsbeahgIc4HQY9/cXbRWDFSTof2jTEH6R/cPQdAdd04BL2Di8gBdOgbXE8Bb2RZpCuAqT2kbTmkFdqCcuS72FRq5B11ccNQ47vyLw1eCuV9LUal4nm+POETL2oNYNKeGNJV2g0A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <70d620c9-7fd7-e442-15f6-af75eff33669@suse.com> Date: Thu, 12 Jan 2023 08:42:29 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v4 3/3] x86/vmx: implement Notify VM Exit Content-Language: en-US To: Andrew Cooper Cc: George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Jun Nakajima , Kevin Tian , "xen-devel@lists.xenproject.org" , Roger Pau Monne References: <20221213163104.19066-1-roger.pau@citrix.com> <20221213163104.19066-4-roger.pau@citrix.com> <553cbd97-f667-1549-4374-9385d3d53710@citrix.com> From: Jan Beulich In-Reply-To: <553cbd97-f667-1549-4374-9385d3d53710@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0067.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8936:EE_ X-MS-Office365-Filtering-Correlation-Id: 1ebb17b6-404e-4087-52a3-08daf4708fb8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YUx+9Ac9957gBE0rKUEha7dn3rnhvmFURw4LODWz1G+8yjy/co7cMP746Zq0WiJEprUIbWv1yGCAtf1kFLrLokTV2Qa3WZTeqOBOA8HshTbnnJo+0HWJgBpXsduqRs4AXozBDv9vL6+UWuPyq2tofigUy7sILHHnPXvpkx4M16dbxIILHfdGA3IsOW1j3lFAD5JBcxBNLAAIwPk2keFzQtgo1ruxXx5l12/HHl95bO2A8SrD9odDc3093fzA+gCIBCfQ+j5M7D0bvq0IEwqdp47tu8dFcZoYmxsByeTVaISVU2lgIziwLxdAjcfKwQAT8lF6mEKPrk44kaMIazdp8f0/fyTzJJjtlwC9m+mLsfSMc4xMCOMPupMj/0PeCMy729La2pinpGT/vRwcxIKX4MNI/3z+TOHDTZIytND9WoMTG8FhD0w4YQbG0R/zvWxja2YjfsTsMGl0yDwi9bbQ6/mP4rW8ouxuBVVRmoaDeCDOVrDBr+SslmIuUMyQdznwVasbG48ClbKeRaa7NGxOQ/EpUK533u2/RCG2jHC2nA49pQp7Tquw1zJlA2C8ZSAIFNIu5+W/swF58AwQYFVl4wArkXIJ6Qh3Zm3/AJEcWV3Dal3oWuFS3nken1CPtNm7fXmF8NMFMnwxRNFh0NiOGM+iitNCOcQzlM2xoZCDmB88OK9slbh/C6+q6U3OURK3a9G0kTUY1PCgWaYYfj3soxwVzEQGLZJx/wHq6cpbGPI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(39860400002)(396003)(366004)(376002)(346002)(451199015)(26005)(36756003)(186003)(6916009)(8936002)(53546011)(6512007)(31686004)(6486002)(6506007)(478600001)(66946007)(66556008)(5660300002)(66476007)(2616005)(316002)(4326008)(31696002)(41300700001)(38100700002)(54906003)(86362001)(8676002)(83380400001)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Mjk1VnFQS3FBWlJwUnp3WCttckNaVFRvbGNYRlRzSXRXZmhnK3h0b3J1WGxJ?= =?utf-8?B?KytXUzVTNVF1S2h1cERxcTRzSThzU01IZE1WKzlwMDBhdmJBK3E4OUJDZzZv?= =?utf-8?B?RFErNDJYWkVkMXFEM1prb2JYQ0l2NXIwY0g2UWViUEw3L2E5NEgrNDk3REZO?= =?utf-8?B?U3ExUzdKY3VQZjBLdTI3UndXSnV4Z0ZBLzBlaGVBOEUxeDVucXF3aWJSMEhh?= =?utf-8?B?ZFpncE9CR0wzUTJzNjhaMm9JUFh4T2pPT05SSE5FNFVQRzNQNmsrL0p3Y1Ez?= =?utf-8?B?ZU1YUksxSEdFbklKeTJBaTRSSE8rRGplWnIvNnYrMzFrbmxYL0Fxblp2OEUw?= =?utf-8?B?bnVySUVPTWJzWVg4a0hmTDJLMkFTRWlMV0lkUDRhT0VUclQ0dWdScnZjYmZu?= =?utf-8?B?T1JNZGFpTnJKdXFjWERNRlBjdnlRZVlQaWtnZEhEdVZwS0wvcmNhVmhGRUo1?= =?utf-8?B?cEgwbVIvT3F3dmxCa1ZqWjB6emVqcmtZbW9oUVdnQllZL1gwQkNlemNzSm9m?= =?utf-8?B?S0RSWHBIVVZpM0lRSVlyOS8vYVBxWDlGZG5xREVFamZGVUl3ZVFQV0RFUUht?= =?utf-8?B?NHpHV1RyUEI4SDYvVnBpMVVMb1EzaStOdGR4dU9JT1ZpQkRiUVVvdE1kNkF4?= =?utf-8?B?azVPWWlrczVSV3JXTlhIaGZWSTBweit6OG1LMGV6ejdwUHZGRUFFeUgrSUFh?= =?utf-8?B?UFFPaWo5c1pXaHRoSExZQmUyYTJpRGEzZlhtS3lnWHFyUUNnWVFrbThuRUt2?= =?utf-8?B?YVJrUGpSVWJ5NHYvZ0NSdmlMQ0xwRG1sMXVzeHYxbkhlWERuRVBLSCt1aDNV?= =?utf-8?B?aGcxd2hLaDZjVDU2Smg0dlgxU1l1bGVYQlJYb2FRSVBaQWh1dStkenVDdU1i?= =?utf-8?B?bDBGaVRWN25nelo2RGVWSFBvcHJQdXNoWDV0QVZVbzVjQURndWE2RVVyRnp3?= =?utf-8?B?WEJrcDVQa1dOQVdPS0I5bXJSb3ptTkZFcGVzMXF3Wi9UWlRHRU5uNjlTV2tp?= =?utf-8?B?TVhNR2VzODJNMTc5OXlDbzIvRDMyS2gwL0FKaUZGUjRINlNUZ2JCdm9YN1My?= =?utf-8?B?WlNOeGs1bXk5VXJpYWJxdHNUbnRBWmhsT2tRNStITmsxUnZOQ01PQWxzTzVO?= =?utf-8?B?a1JLM0FRTS9MZkVFUnVNSFh3cHh4WndqU2dyYjV3OTBxTlhLR1J5dVprclQw?= =?utf-8?B?L2VCK0NyTG9WbXJJaFhiRERoaU9DT0ZVampCblVJZzFZVDBlRktvcnJjNjB2?= =?utf-8?B?NS9hQ2I4Y21aOUtWZzFRZ1RlRnZicm1yMS9nZFU5a0FtN0JycXh1d2NRRHdw?= =?utf-8?B?ZGZLSWwyUllnR0ZQWFFRRzZsUjdWcFJkVDl5SFNrSlpmSCs0eHlJNTRDbzNF?= =?utf-8?B?TkIyeVJtYXpHTW8rK0s3UDdtTnVrc2p6UUV4RERCOWxmUUJaOFZDaEo3azYr?= =?utf-8?B?UmFVS0ZjbStlSkJHckNnZWFPZmJyYXV4UFRUc0wxdEhSMUNadzZrVkZVVjNt?= =?utf-8?B?REM3R1pFbURKdXhaL2EreDk5eEw5YTRKY3E3ays1bm1talN5MmpLNnQxcXlO?= =?utf-8?B?V0lyMWthZUprNTY2YlBlYjl4L1l6bmJ5T2RRZ3N3U0N3bGFTOU5lUWthZ2Q0?= =?utf-8?B?WnlKTUlrVFVZSGJjeHY0dldwc1U1ZXJtNDBQZG01cUhMOEtDeU8vbnhIVjBO?= =?utf-8?B?eGREc01ZVTBvOURId1Z0UlJEMzRPQjJFendiNkxyNTYyTkNoZXdPdk1KNGlL?= =?utf-8?B?aExNWVZkUnQzODAzRXNzbDdtQXJyQmJPbGFQOFlSRmhEYm03Znp0RVRTZkZV?= =?utf-8?B?OFdEWDhtZFFaVk9wckozS01NSjFiUjFTdGpMbnJsQTFRdlMyTmhncFQ3Ry9M?= =?utf-8?B?K2N5NWFJVTJFaHJoR3djUU1zRk40b3NtWjBoMHJyZjh4TGg5b2JlbXI2Y3Bv?= =?utf-8?B?S2xDTlpMeXlMU1JHTkYycldVUnpYTVJvZHlEenZhRHVneW5GYmRxemJJUXI3?= =?utf-8?B?eVhFdnB3N0lVM1dLV0F3MkdOYWdJaVpqcmJwZlUydEZMa3E0bHEyeE9OdHVC?= =?utf-8?B?TEg3L0p5QXpLekpFVXVjTGt2cVBXL0puSENueTVtWmNleFVlK3lTQWx2S3Jq?= =?utf-8?Q?Bq/6jabdE06F87+7GME7g6jrE?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1ebb17b6-404e-4087-52a3-08daf4708fb8 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 07:42:31.3894 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NCXIpTFGsUBO5JkVSBpQCA3MHDmBRADZZKgC2kY5VOs8YnMwHmaD+e7bVNg+JSCsEnkV4pJ1swVAyetyMWW+Fg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8936 On 11.01.2023 22:05, Andrew Cooper wrote: > On 13/12/2022 4:31 pm, Roger Pau Monne wrote: >> --- a/xen/arch/x86/hvm/vmx/vmx.c >> +++ b/xen/arch/x86/hvm/vmx/vmx.c >> @@ -1428,10 +1428,19 @@ static void cf_check vmx_update_host_cr3(struct vcpu *v) >> >> void vmx_update_debug_state(struct vcpu *v) >> { >> + unsigned int mask = 1u << TRAP_int3; >> + >> + if ( !cpu_has_monitor_trap_flag && cpu_has_vmx_notify_vm_exiting ) >> + /* >> + * Only allow toggling TRAP_debug if notify VM exit is enabled, as >> + * unconditionally setting TRAP_debug is part of the XSA-156 fix. >> + */ >> + mask |= 1u << TRAP_debug; >> + >> if ( v->arch.hvm.debug_state_latch ) >> - v->arch.hvm.vmx.exception_bitmap |= 1U << TRAP_int3; >> + v->arch.hvm.vmx.exception_bitmap |= mask; >> else >> - v->arch.hvm.vmx.exception_bitmap &= ~(1U << TRAP_int3); >> + v->arch.hvm.vmx.exception_bitmap &= ~mask; >> >> vmx_vmcs_enter(v); >> vmx_update_exception_bitmap(v); >> @@ -4180,6 +4189,9 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) >> switch ( vector ) >> { >> case TRAP_debug: >> + if ( cpu_has_monitor_trap_flag && cpu_has_vmx_notify_vm_exiting ) >> + goto exit_and_crash; > > This breaks GDBSX and introspection. > > For XSA-156, we were forced to intercept #DB unilaterally for safety, > but both GDBSX and Introspection can optionally intercepting #DB for > logical reasons too. > > i.e. we can legitimately end up here even on an system with VM Notify. > > > What I can't figure out is why made any reference to MTF.  MTF has > absolutely nothing to do with TRAP_debug. Looking back I see that the two seemingly asymmetric conditions puzzled me during review, but for some reason I didn't question the MTF part as a whole; I think I simply wasn't sure and hence left it to the VMX maintainers. I think you're right and that part of the condition wants deleting from vmx_update_debug_state() (on top of deleting the entire if() above). > Furthermore, there's no CPU in practice that has VM Notify but lacks > MTF, so the head of vmx_update_debug_state() looks like dead code... "No CPU in practice" is not an applicable argument as long as the spec doesn't spell out a connection. When running virtualized ourselves, any valid feature combination may be found (seeing that we similarly may ourselves surface feature combinations to guests which no real hardware equivalent exists for). Jan From xen-devel-bounces@lists.xenproject.org Thu Jan 12 07:46:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 07:46:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475861.737726 (Exim 4.92) (envelope-from ) id 1pFsIA-0000gL-S2; Thu, 12 Jan 2023 07:46:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475861.737726; Thu, 12 Jan 2023 07:46:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFsIA-0000gE-P0; Thu, 12 Jan 2023 07:46:30 +0000 Received: by outflank-mailman (input) for mailman id 475861; Thu, 12 Jan 2023 07:46:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFsI9-0000g8-Ps for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 07:46:29 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2058.outbound.protection.outlook.com [40.107.13.58]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 38c74036-924d-11ed-91b6-6bf2151ebd3b; Thu, 12 Jan 2023 08:46:28 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS1PR04MB9656.eurprd04.prod.outlook.com (2603:10a6:20b:478::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Thu, 12 Jan 2023 07:46:25 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Thu, 12 Jan 2023 07:46:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 38c74036-924d-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j4H4N8WRQ2tEzPALPcFJFmT1prtTp02cRF0chXsVul01B4sOMBPy8KD6DfdiCp+UrbQw/Viw2JZ/cVZqYwGoRwu4Sxequ/uA4P4Xh/qhZy09v+sqWkFb6GFlHJWG9hfUwgRakVmZvJLCzfFglsGntvlagjUXrrbb6FIsjYgNcRfbs3EBgcoasb8xK6ihA3IL0ATscI1QKAMcINv0+ylQhWlKKk6tryD4ts56qDIgx0VSRN74atPcVcWJk2DExddH8asC1KFqkNTRrXZkX9JRv6/s5vvF/HLQlHHONWaiGbTFWmlz0X08mQ85r7ysrbjN58Zu4DxkVzAnZukI2mLwTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OxTiy6rSNDxEOG8bK3nQOB5HR719EEuYnrmIBeGlZNE=; b=OWlC+wemmu7ahqBg8/h/gF96wOk4vPuGoDfZ9zJVsBkiMfOp/dOsyrfdRxrNxZoVLipWlcCkwB31dDeHI5GIbb9MpI3wnV6zk50zZzsLD/gq/JaT4T7sX6pZ1Jo1MU2MvBPJNfDeVYsSXh3Wdy+Ib6qM2BeHK0BPjKs3l+IaUy/LdSEbHphgX2RD34Wx+elbFeBDD5c75JxiN2irlApahvwiCQ507mK3Xk8Q8lpqT/qfoUJMnAY/91kbX2Jn+g40w0a3bOHaT6oilIAIcRx+LcrNDbUhxyD4k+evjHB5vN3j3xDBNSZShse/vmOMtWABu+wU7OfueK+SSELaZQDgHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OxTiy6rSNDxEOG8bK3nQOB5HR719EEuYnrmIBeGlZNE=; b=I77rv1tIN+ezpf77q95QdkAvqTOIGsAVKspx6CB0Sljon0hDMxxwniyrQ2eNsBZlHbI7+0OVn+bHi4rwbejvQqMlfzyX+NPnP2LRDHH8FtbL/RIU7/NNgVUChQzPAxhgD6V9oTJarSgG6uF5j5VRQAT3mq0iD7gpSv9F28w+Hd/LZ24sIi+kwFjgHCDQb6/Rh/UGzaixh5VCasAlpSraeV6qQb1F5TaD0o88UFxxRDZYStB2ud3E1K2dTSLOnD2d4HF9SBVjMCtsRcy018OhN1PlId3eTUl5JHpRWgCQk7sb22cAcweEUvAqhSEtRRvLjGICebO4pbDyV0M6FlhMlA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <750ad2e8-a5be-d9c0-846e-41bb64c195fe@suse.com> Date: Thu, 12 Jan 2023 08:46:23 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [Multiple reverts] [RFC PATCH] build: include/compat: figure out which other compat headers are needed Content-Language: en-US To: Andrew Cooper Cc: George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Anthony Perard , "xen-devel@lists.xenproject.org" References: <20230111181703.30991-1-anthony.perard@citrix.com> <5c7ffbe4-3c19-d748-9489-9a256faebb7a@citrix.com> From: Jan Beulich In-Reply-To: <5c7ffbe4-3c19-d748-9489-9a256faebb7a@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0032.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS1PR04MB9656:EE_ X-MS-Office365-Filtering-Correlation-Id: 449dff49-5e5f-430c-a992-08daf4711b80 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TwUTnoQqAyFssOw5Az04d/uLf2+NTs/CqTOaxXIb2Y99R2mgVo14xpmHgLCld2C9N1TU+cwVWYlfpIGs7i+b47FQXy4e4soh0Ox83uj7JEkpzVsUAw/0iKWRVED19fQU75EBAjUT0uFG6kXPWE03H7QxkAhX9HJgHHOeJx83FP+UFH6G+QtiVAqQGayRR2m89p+zUEs2w5PdvEeLXrtIZDpJbvc8/sDYeAmJU56p2ie3wdSmVGUNnu59K5Cjx4pNUnlqbkFsnjUmldAThFieVsnPEqvnjKqD9IT/aTddcQX9Bl6orrXYGn81mE859+9uhQhfdohhShTn6Inu47ojo4q1EBSOepEn/cVEBSwcfF6OaykxHHoy5FnoMvbwaDk7bkGc4xYa/jdR/UH+0tvKmamEr70ZCF9pg9MzbiqUhVTr+2oFjkdCMB/ngpegi4b+SqdBhNUAMa0HjcjK/VBjVbd+bpE8Q6Z1ZbUUyRINr973Pvi5AMrOGjWSbKxwaR73vWTBtWV8pz6+BctqCo95/0HwXfaImCAgHrWJi6aQ0UZMLed76FyKXOQBJAGQ3NkT93+H7K+xuVDb8WDvZOuRJp9AeyTJJINeN1Zj/ZZDAuxXiGWyIvVwvMBLGerGrn/r3wvBe30GLoxpOEb696XXH+1N9UfGd3aikeR4A5GfzuSYMX2YLCoADaTD10o2WqbdqVg5g/sfaXEgBdPpUHAek8GSLUrM9GoQ/WFg2nGIbaUhOUTYP6zWxEpw3DUrHboSgsztKctgDt66KahwXYT24A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(376002)(346002)(136003)(366004)(396003)(451199015)(26005)(6506007)(6486002)(478600001)(6916009)(6512007)(186003)(966005)(66476007)(2616005)(66946007)(41300700001)(8676002)(53546011)(316002)(54906003)(4326008)(83380400001)(86362001)(38100700002)(31696002)(66556008)(31686004)(36756003)(8936002)(5660300002)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cExhWThZSkh5d0tBOGoyTWhCdVRZayt4aldGa29XWVBFbEh5REJaN1BZYmRp?= =?utf-8?B?TmZOY0d1RWJOajZxU1ZteGhhc3QzZVR1dzE2L0dRR3VncUhmTGFkamlFTVpj?= =?utf-8?B?dVk4bEllNlplQ29sRHFrU24wT2JxNi9KK0c3SnVKYVZaR1pqZ2hTM0c5NFVD?= =?utf-8?B?SDV5Y1Q0N3pSODNnU2prRnFqRlRnWG93akNSd1FTNUNoZjI0dFNZWjFpYkJU?= =?utf-8?B?RVNEd285T0c5dHFiTWQ2UTRsMEd5L0hXbE9KcHVkRXRYVUM3KzJ5MHQvWUZs?= =?utf-8?B?TUJTYmFtbG9iQXREL21MbURUTERLcDdLTWtlWXBZSG15aldZeGdCUlhZU29n?= =?utf-8?B?WG9jdCs5emhSU0Qwd1RNckdyOU82aFBaNlJlOVJtd3B4VHJNRStZZnJkbitv?= =?utf-8?B?YTV4cnFkSWZpK1dXSnFpQ1pTLzJGUldxSVFxY24vaDFrTXc4ZTgrQXlSYmhD?= =?utf-8?B?d2hPdGtiWEFNbzNYNEN4RWFQMG5VZ2VpTXAzaXFCQ2xkRGdSdjFsRFVFcFRY?= =?utf-8?B?NzhXZnVqTFFPVnRHeWZ4aEVqSGNGdGVFZVFQOHVKTTYvQTZ6a3pUemZVSitp?= =?utf-8?B?b1Nub1RmWTNqR2RPdi9NUUtHN1F4Z3RscjRIK1hNalJCbjA5anl4RW9vbzRy?= =?utf-8?B?UG8xVmRLY2tEeVBIakMvZFZTY0tHdXM3QXNsU0JnMVlzaUQrUVQzMDg1ZXZm?= =?utf-8?B?S2RTaHlkYmxQUUQvdnU1V09vd2gzSHBjcHBhd2VkNzZEemwydlA2NU1YRWdI?= =?utf-8?B?KzBhRmVhMW9ETWZmbDVJRk8vaXVGaHp1MnVuaG1seGxybFc5VmV6dy9qYTFz?= =?utf-8?B?dWliaDdJUjB4cFRXeTRYL0JJVG0xc1dXanBaWEd2czFVZldUVlM1enVPY3ll?= =?utf-8?B?c1NwWGdyVjFRcHQvMFhwWjRYaVFiSGRMV0ZlVUdxK0R5SkhZL21BaEVKWG5n?= =?utf-8?B?VzN6WndHd2ZGb0RPYm9LNUh0ZWNsS1hSS1laNWt1MFAzRjdJM29KYUZIamdi?= =?utf-8?B?SWhyVWdLaGxCdUVMVTU5TE0rOEtwUGNsYVdVR3RZUllseGM4V3M4M2tXOC82?= =?utf-8?B?ZWNCVnZIVFN5d1hGK08wdFpQTVVYc1UzcVArY3V1d1R5aUF4anY3RGNMYmNx?= =?utf-8?B?VDNqWmppdlhWUTVwZzZ6cXhhTlBLSmt2VHBneDZDejRWazAxLzBxYm96RG53?= =?utf-8?B?dUtjdVdpdXM0L0MxbjNjcnQrZ2JJRHFYMCtsTDg2Y0pEZlphTHEyZStQTTlC?= =?utf-8?B?ajVnSnY0RVViRjBtbzN4QVkvUDEyN2dRYXdjQXRRUXo1WVFPVFhiU085Y0hj?= =?utf-8?B?YkFLMDBTS3Zsc0JCSGNMK3F0SXlEZFptN0thUy8wQ2UwV21jZk1vMzZmdGFh?= =?utf-8?B?bjEwVFN6THA1R1c1T3JzemYvWDVVV3FlZDBPZ0Q1SDhzaHRlOThqN0VCbnQw?= =?utf-8?B?NDhES2owNG9yN0pSS09lbGp4UEZ4WE1mVTZ3eFhSQ0QyVmsramY5L1hyZFlN?= =?utf-8?B?N1VGbGJ5b0xxY3ZxcGc0R0NoQ0VGMVNHQTBIbmtCemtKeG1YVjRnQVQ3Mytt?= =?utf-8?B?Szh4aDc0ZUVxK2pvN1JWM1NxZVluZ2xpbmFFdW90L1pDK3B5NGIyTmszd1M2?= =?utf-8?B?cW1ESy9qMnh0YUFDbmU4SGF0OG1EMEFlWm11Tm1hTU8zVDY1Nks2WVdoby9G?= =?utf-8?B?ZnhaMThmSmwxdWZlQnNJc2szcFpsVDh2UnI0aUIrdVRmTVI1NU5aYStuSC9m?= =?utf-8?B?ZXZidFZtSWlNTHpKNXdhWkNmUS9mLzZYM2JraWw5ZlFQMGt2YlBod3RoWjRT?= =?utf-8?B?MEVhdDZIWjcvVGJaM0RLOXg5ajNmaFV5cnRYYndIdTRrdE5qWDhSQlB6aEln?= =?utf-8?B?REliR1ZOaW01Q1FGK3BEeWUybWRKc2x1aUJJT1d3dVprVnF4YlI3YmcydjhK?= =?utf-8?B?Z1RFYVltaUVMb1pFRjlqU1dxLys1SUdHMnRyZGo1R3VPdnl0WGh3TExCMm1J?= =?utf-8?B?elh3WnBtYnR3ZWZxaXVnRnlGaVhkeUlxdnFjOTRFSjV0MTBZamdYMEFhOWFp?= =?utf-8?B?WWk2SVRiQncrR0c0UGtlYjZXeHhpYVYvK1Q4RGNDRXBUcjREMjNickd6V3Vr?= =?utf-8?Q?yAGtM+gpsl3Tq9Z+zQUT2VysN?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 449dff49-5e5f-430c-a992-08daf4711b80 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 07:46:25.7963 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ISy/a1CtDoLoTgQTBmO8jwhoYpSqT6Cz3w5wqKBGNGmHeZ0cyJT1Gtm3/t5XDNykeLCKqs8PjRKa/4D1sbgbxQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9656 On 11.01.2023 23:29, Andrew Cooper wrote: > For posterity, > https://gitlab.com/xen-project/people/andyhhp/xen/-/jobs/3585379553 is > the issue in question. > > In file included from arch/x86/hvm/hvm.c:82: > ./include/compat/hvm/hvm_op.h:6:10: fatal error: ../trace.h: No such > file or directory >     6 | #include "../trace.h" >       |          ^~~~~~~~~~~~ > compilation terminated. > make[4]: *** [Rules.mk:246: arch/x86/hvm/hvm.o] Error 1 > make[3]: *** [Rules.mk:320: arch/x86/hvm] Error 2 > make[3]: *** Waiting for unfinished jobs.... > > > All public headers use "../" relative includes for traversing the > public/ hierarchy.  This cannot feasibly change given our "copy this > into your project" stance, but it means the compat headers have the same > structure under compat/. > > This include is supposed to be including compat/trace.h but it was > actually picking up x86's asm/trace.h, hence the build failure now that > I've deleted the file. > > This demonstrates that trying to be clever with -iquote is a mistake.  > Nothing good can possibly come of having the <> and "" include paths > being different.  Therefore we must revert all uses of -iquote. I'm afraid I can't see the connection between use of -iquote and the bug here. > But, that isn't the only bug. > > The real hvm_op.h legitimately includes the real trace.h, therefore the > compat hvm_op.h legitimately includes the compat trace.h too.  But > generation of compat trace.h was made asymmetric because of 2c8fabb223. > > In hindsight, that's a public ABI breakage.  The current configuration > of this build of the hypervisor has no legitimate bearing on the headers > needing to be installed to /usr/include/xen. > > Or put another way, it is a breakage to require Xen to have > CONFIG_COMPAT+CONFIG_TRACEBUFFER enabled in the build simply to get the > public API headers generated properly. There are no public API headers which are generated. The compat headers are generate solely for Xen's internal purposes (and hence there's also no public ABI breakage). Since generation is slow, avoiding to generate ones not needed during the build is helpful. Jan From xen-devel-bounces@lists.xenproject.org Thu Jan 12 08:02:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 08:02:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475870.737737 (Exim 4.92) (envelope-from ) id 1pFsXp-0003c3-Ha; Thu, 12 Jan 2023 08:02:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475870.737737; Thu, 12 Jan 2023 08:02:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFsXp-0003bv-El; Thu, 12 Jan 2023 08:02:41 +0000 Received: by outflank-mailman (input) for mailman id 475870; Thu, 12 Jan 2023 08:02:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFsXn-0003bi-VN for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 08:02:39 +0000 Received: from EUR03-VI1-obe.outbound.protection.outlook.com (mail-vi1eur03on2073.outbound.protection.outlook.com [40.107.103.73]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7a039cee-924f-11ed-b8d0-410ff93cb8f0; Thu, 12 Jan 2023 09:02:37 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9058.eurprd04.prod.outlook.com (2603:10a6:102:231::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.19; Thu, 12 Jan 2023 08:02:34 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Thu, 12 Jan 2023 08:02:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7a039cee-924f-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=njjk/Y+h9vzUI94IBkMpSJU9UTcFA6CnxwLiEjbrq5P8Ex/6qLhk+g1Q25v+gQmnMB2sHsdz29SDzMPZMsXiRzT/d+iH+GqwgWl/6Ndr/8NFKnH9BgyaHCXYRwUGd/P6oh9kaqzNRrSrvY2VrPrBcm+an0HnkkU04eMx13m4QAn0FPK2sswZfU43E7ENuV/27OtXvSe2YU2eR+atTVJ0riGbodvULCWNHdLQ6ByOyyGkR5E8IjG34s6K727ohcjDVgnRLQfshnu4YR0kdFho71DyO8XwcPefNNGI1MoOmqrbe8IMq3qr1pAyLuPKYEJhiLHcT4jRhaleXz88hmtqNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KW1je6TKGecW+nUZ6pRPQuvvrcIDDFkiUqbq4QqiJXg=; b=cFYrt1OtqzTfVigIgCRWWdRT00z3Gby0BWZdljt8jFFzTlXcFbOk64Z9Gc/5i/kQ0DhmfSkDUh5oaF/K2/tYXNKROxFc5E65NqRXyU06BqxDHeRZ0qekwA3RY/RS8PYJhyplJLTLspwlEsjxGTY/3+tO8+diRd8dLlvx/q43eOzcz+4dIQEUWg9Y5CC/KzpPAxNSCEQT0azRCH9ZqIyOTB33IysmhVUUJyGw0M8y/6nYDSYWwjlKxG+Ia+AjPpgjgfqz7mVu6ak9hYKnSmRay+nd5GNIBNIFzmG6/PRGI3OdMEd91iiu+ICbLcLtrv0QTM2Izwi7XaFRcfpgiNNN1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KW1je6TKGecW+nUZ6pRPQuvvrcIDDFkiUqbq4QqiJXg=; b=Xk7Uv767EggzijOpRjJd1HfNAhUvoTARckuo1bSib8InkmozuUFQAu4w92Ov2iSrjNWpbhAacJADMxM7IL4rzQ7QWr91lyPCWeS6cE6D/XFKkTbEE0kdpoGXPVqbEfwcijnKCKgRwQ6xYN4X46RFam0BJhvCYz6HsYsqy9+AlMerCgtVOkuPo2+iY808gK3OmByRUJ4G3sVyXnxLPTxJ0ZtFlXKVlVJzxoZ3akF4rbu4eeDheEReIOWYB+/h4IuA3NLit1qhU/i9GixrXI1mEw0p6OsD/KsoQPcVVN2hObbrRhGefuECfcM/QKlEAwr0xXSWcmcU0iLHQBUhxVt8gw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 12 Jan 2023 09:02:31 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [RFC PATCH] build: include/compat: figure out which other compat headers are needed Content-Language: en-US To: Anthony PERARD Cc: Andrew Cooper , xen-devel@lists.xenproject.org References: <20230111181703.30991-1-anthony.perard@citrix.com> From: Jan Beulich In-Reply-To: <20230111181703.30991-1-anthony.perard@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0121.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9058:EE_ X-MS-Office365-Filtering-Correlation-Id: 7bf2e183-8486-4c62-18d9-08daf4735c56 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8bkQ7v/5khKvo1q9fRECHGqC1dTRJex6UTORmXSiNuVjJbBdU60rDw7bD18LO/tZ69GYSgSn+B0R6JQnupS02yk+A2q4KMDrydC48GOO7ltA0eoTrF4i/fsEuUdRjSJC+bfkElPvTsTFs6lQ1Oh0x8X3a/ODPxJ8k3U1anzbQhF1PV03pS1LXn+bnhqKNpbs08+mcqqg55NdExxuQCPYB5xay/DFYqsBzr2czXxaeOBXIc2sSOn0ya77nxYGYgEl3UIwJ9sMoT+eeB9ihjHr9s4v7le3wbPBexhl+bXSshnm38T4+gDefW/MLG8JkR+yHsW974cfC50GKMjwWXwux6+tBQjtVO90fGMCg9oLg0gKnAgaJBraqPV7wSMCi4oFbsUxDqFNoJMGkkF9YXxjt+G1ZpEayEWw3dJ3h7n64daO31aQB6XZdOOIm4l1IcgAjGq/NPoO4r9rZscdBqM2TYESaLaX5SdPmJetsFOHZZGpBQFnErySHbXx1PYA0itnwAND75y0B4SaIUBo2ruJxG97W724i3BxFxJSxX26WKSq1aixu5qXZ2xNV84zBTdSoGaA5Q6bmgr4VNBKfllhAIpKiuF3/aRjiEN9AQz4a491tje3+gFVCR3pZ01/2EumtfOOeAgdOFDqtuOTASaid4ZDBw5vnDse83Sc+J8IcYIVTnHDvfllWFi2Gi+xwTT4Frjf9M3MB/N30LDRJ1HRNcCV6R9t2HXgC4EmHOKd028= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(346002)(136003)(39860400002)(366004)(376002)(451199015)(38100700002)(6512007)(31686004)(2906002)(66899015)(186003)(26005)(6506007)(53546011)(86362001)(41300700001)(5660300002)(8936002)(4326008)(6916009)(8676002)(31696002)(6486002)(66556008)(6666004)(66946007)(66476007)(2616005)(316002)(36756003)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZnJWNkFXeUN6M0hyQk9ZY3p5MWFLeWplWEd3U0hMT1ZId1dnc3l0RlVkVVdu?= =?utf-8?B?TnZEdmJUTlFMTVNmSXhLU0k5eTRpb04yYU9oV1R1Yld2dHZNMWJ0b1A0dGlB?= =?utf-8?B?VFUzS3FqVStobU94aFZsYnl2Nks0Q1d1eTdGQ0F6RG9WZ0xTWGh0cDROaFZl?= =?utf-8?B?SUNIbmRaUXdiU05kWDJUM0NKemxoWDhWSzlWaUtPK1R4QmVPc3dvTTBKZ3cy?= =?utf-8?B?ZkhLVlltWFh6bTJXKzRHNVlLcjRWc2F4dTJ4RkViUmtrYW93K01BcHpYeWxo?= =?utf-8?B?ZzVpTXl6dDRnb1BPKytDaVVEVEtjUTRCRkRIVDdnb2NmVHpCV2p5TTVsNmNh?= =?utf-8?B?TXpLUDhDVnQ1YVBjQUdWMWF1UDJBN1ZOT1BDSTJSVlVTS3hLaEVRc2lXMWJq?= =?utf-8?B?T2hKc0tLbEJIeHh4UnZlTnNZcHZpUDhaUG55NVh3Q2lUK3E1c0FMcWllQ0tl?= =?utf-8?B?eURaVVNxMG51UjM5V09QK1pHbnVHcmkyN3JBYXNiMHhuWHkwYUxVMkJlZmp3?= =?utf-8?B?MW9sNWlYSC9YanRPSy9acGIzV0tTUHBNZEtrc1pFMnJMbm50YkpaVG5qOU5l?= =?utf-8?B?RE9JY0ZCZ2V1dEM3RVAzTzd5QTdYakl1eXl5ZGZlV3dMTS9sdzBGeTNkczF5?= =?utf-8?B?RjRFN25JaG51QlZnczlua0QvZkdsaHpXbjNrVE9vMmtQYjlsWUJPY3ZreWlR?= =?utf-8?B?OW53UDE4ZzIwdTB2dG0zbDFKUUdnaGgvc1BLYnJZdmt3MjFHOHMvM2d2VkdW?= =?utf-8?B?M0pKN2tDUEF6UFFDZDN3dXJZbHlVS2RLTE9vVEZzY0UzWlF2Tm52ZlhuMmxq?= =?utf-8?B?dnNJN09UbWtaeWlmdjQ3L29kU3VJUlo0dWdtellXWEVoaHJmcTNzWk5YK2NG?= =?utf-8?B?U3ExMmpOOU5QelhvOVhrK3duRThNa3hDbUpDUkZZYU43bCtkYUZGNkJ4T0wr?= =?utf-8?B?VVV5M0ZXMlc3VjRNdXFGMGtidW5yNHRMUWQ4QmtXNjIzUklKaGVkL3NYZWE4?= =?utf-8?B?SFVHZXZ0L0k4T2xZR1dIRE41bGdzQmZFSDRwWGNJN2lmMGFKRW5XZ1lPOEVH?= =?utf-8?B?dzc0S1I3NG5PR0FiRjd1SU5QaUt4MkdORlZHTWludXJwY0VHbGwrSllrWEY0?= =?utf-8?B?Tm15RnFueXlOL2hEaTZ1MTFxNCtHZTUwc1hiN3p1U21SYnFmSkZVaFVwcFNw?= =?utf-8?B?VGpJSzI3MXV5cUsxVmVxWVNGbTE4VGlWR2dxbmlNY2RtMlZVN0o5ajJsWmhC?= =?utf-8?B?ZU9jUFJOcE4zVHdZR3M1dFMyNVZYWVhzVldja1FTTTdhblljK1hsTTVUQkR1?= =?utf-8?B?RkUrc2JjeEVOR1lIL0ZsR3l1ck9wMnVnSFFVc3QwdHV1dTZqa2x5Z2xPNFE1?= =?utf-8?B?ZDl2NDA4cmJsaStGVTc0NXJRMVJDMExKYk9Za21aaWZ1SVN3WEpBSFBEVWJH?= =?utf-8?B?SHJlUXFGT1hGaGovRkQvVzlPL2x0QmNwcGpoZFgvVzljK3dzbFIxRjNrR01s?= =?utf-8?B?UnEvSmNvOXhtQVM1Q1pHMXRoYnNpb1ZKY05xT3pVS0VVc1AwZUFsRytLK3du?= =?utf-8?B?NlBhdVpONSt2ZmJTT3JReithY3A3ZUxYaFM5ZE0vWEMwOVhUQzRtUXN6N0lF?= =?utf-8?B?eDhCWFpCbGNBc3Q4aldQNElQZVhrNTF5WnR2Y211SlpvbW9wcTg4N3RHK01K?= =?utf-8?B?UnNGYnVuR1FsREgyeHBuZWc3OUhZNnJTdUQ2dXhlYkxMVEZlN0FvbUwyTUYy?= =?utf-8?B?RFI2dG5CVzBBcitCZmMxMVJPQmJTTWlORE5CbDRxNWJDWVpnaXppcEg0RTdC?= =?utf-8?B?REF3bW9DSHpJaDRBVFhBVytCRmpqZVAxb0hlUmFKZlpvcWFYeGJiWW1sU3c0?= =?utf-8?B?Qi9PdFdCSGVDK0hMTnZVVUVHa2pWU2ozT1hsTXBub1hNelNOYmpWMVpGWUtj?= =?utf-8?B?bGYvMjFtMDJHU1RjR3drdXduVXcwbDIydzNZZUxJQ0hrMXFvTDVXZ0VGTXI0?= =?utf-8?B?bzl3RlNwM3JRdm5CcXJnayt0ZFdGempaVklDN2Z6T0ZKRzBrUWpOSlZueGor?= =?utf-8?B?WXRFNVVEYXpxRVZhNFdRQnpjb09UOTQ5KzlKZHh1cSs1TUU0cEVMZUxzTE5a?= =?utf-8?Q?P17xF+uBwUgyQmXwCw5VQFIvG?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7bf2e183-8486-4c62-18d9-08daf4735c56 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 08:02:33.6409 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SxlOGMxWAW7mn/WLc2ONJsO703NE0akwt5uWZwYAp6oWvupR6+run+h+qluPrjsWltUigJEmd7iBQhlStNXN0Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9058 On 11.01.2023 19:17, Anthony PERARD wrote: > Some compat headers depends on other compat headers that may not have > been generated due to config option. > > This would be a generic way to deal with deps, instead of > headers-$(call or $(CONFIG_TRACEBUFFER),$(CONFIG_HVM)) += compat/trace.h But it would generate dependency headers even if there's only a fake dependency, like is specifically the case for hvm_op.h vs trace.h (the compat header only really needs public/trace.h, which it gets from the inclusion of the original hvm_op.h). Avoiding the generation of unnecessary compat headers is solely to speed up the build. If that wasn't an issue, I'd say we simply generate all headers at al times. In particular ... > --- a/xen/include/Makefile > +++ b/xen/include/Makefile > @@ -34,6 +34,29 @@ headers-$(CONFIG_TRACEBUFFER) += compat/trace.h > headers-$(CONFIG_XENOPROF) += compat/xenoprof.h > headers-$(CONFIG_XSM_FLASK) += compat/xsm/flask_op.h > > +# Find dependencies of compat headers. > +# e.g. hvm/hvm_op.h needs trace.h; but if CONFIG_TRACEBUFFER=n, then trace.h would be missing. > +# > +# Using sed to remove ".." from path because unsure if something else is available > +# There's `realpath`, but maynot be available > +# realpath --relative-to=. -mL compat/hvm/../trace.h -> compat/trace.h > +# `make` also have macro for that $(abspath), only recent version. > +# > +# The $(CC) line to gen deps is derived from $(cmd_compat_i) > +include $(obj)/.compat-header-deps.d > +$(obj)/.compat-header-deps.d: include/public/hvm/hvm_op.h > + $(CC) -MM -MF $@.tmp $(filter-out -Wa$(comma)% -include %/include/xen/config.h,$(XEN_CFLAGS)) $< ... this removal of the config.h inclusion is to avoid introducing any dependencies on CONFIG_* in the public headers (of course we'd expect such to be caught during review). I'll try my alternative approach next, and post a patch if successful. I am, however, aware that this also won't deal with all theoretically possible cases; I think though that the remaining cases might then better be dealt with by manually recorded dependencies (kind of along the lines of your headers-$(call or $(CONFIG_TRACEBUFFER),$(CONFIG_HVM)) += compat/trace.h in the description). > + for f in $$(cat $@.tmp | sed -r '1s/^[^:]*: //; s/ \\$$//'); do \ I'm curious: Why "cat" instead of passing the file as argument to "sed"? Jan From xen-devel-bounces@lists.xenproject.org Thu Jan 12 08:08:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 08:08:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475876.737747 (Exim 4.92) (envelope-from ) id 1pFsdV-0004NU-5g; Thu, 12 Jan 2023 08:08:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475876.737747; Thu, 12 Jan 2023 08:08:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFsdV-0004NN-2y; Thu, 12 Jan 2023 08:08:33 +0000 Received: by outflank-mailman (input) for mailman id 475876; Thu, 12 Jan 2023 08:08:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFsdU-0004NH-Hd for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 08:08:32 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on2082.outbound.protection.outlook.com [40.107.8.82]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4c29d3aa-9250-11ed-b8d0-410ff93cb8f0; Thu, 12 Jan 2023 09:08:29 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9520.eurprd04.prod.outlook.com (2603:10a6:102:22f::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 12 Jan 2023 08:08:26 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Thu, 12 Jan 2023 08:08:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4c29d3aa-9250-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mo+q1YZXF8nvt9ZtuWLwUIpEN6FszF+4Y0EKi0xJ0TNg0U6g+l7q/fFH2goqv4lwmlqmENp9CBMOrintBD3sa9Oe6Q8g1S5yPa3RP+0aDIdhOGxuIs4oi7Um/8dcnUr6DHe/jWaGA89vqghm8gilju+O8qsbr3UIvXTf7gWw+XiIDlqiTMZAqdaCFpvyCxaIpmkNRBN2RRs28SycpcMtAaisvuBPF+07cqRQXLqDgw3VgSf2az033STmULBpvY7koiI/unaxXjMXhg/Y3Vl2V05D4FcAUUd5zoMXyGUUlQO/Lu8XnI//qQ7qzcNxevKZ4P7gAvbjVtcIjawi7PWIIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NXvbY2AMJ6MkxksEorH/5cWem3dkgzZzT9MoggQzB2s=; b=HfIsdUzx0ycyYQyFpcVw/f3F11BVVLAyatKF4BsgAwnT85Xf0EQdvkNTuGqhSwh7+QaeHJRR1sy4hZLLkQ/PUnPVSVE693yr96RpkD8OtAQmSTcKXet3zWN5BYlpfmN/dU+jxXacHQMykYhT573uMFQVWNs76dApfh8UgHTj2mr8N2S9xyCmi9TF4O0nxJaNeDkAKt4zizEW+9bS1TajAdMzRI8GPh5yit/j6HoU3bIRUfWi+gUs4drMNAErZ0VN1hRPjMRmQ7pYxSMFodEkcUmTmhyr+g7/cL5SLtO5HanSgNRcE0OF7VdTYwNB9xEzdjuQ6YPki91DvF+FS3fzjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NXvbY2AMJ6MkxksEorH/5cWem3dkgzZzT9MoggQzB2s=; b=KB/g10ycW4Jz6GjVemGYRMGYxchuozQ9zFjvLGC2XsjFq4JvdKMnFwNftZzmGsjJgwCbRhSwkVaBRuBCScC3xYmcsanqTbRzulASHnLI8bEmtWsHyVA6YjLJuBbeS2qswStZaWRwgx9D6/h0jvpQVlt2Yv/3sS6DCM3LK7Q/1sOcQOJglQTtP0n+rRvj65yPShMqIsnCvrxJ7e7n83NEMjeiXIggf79733d+i2AnKZBN2bvJK72UwfJyz2pZ1eSLwMFLfKt7mBQadtql/vXfDxIs3hP0kxHR8mIEPnUFpFz7+mW7Q/pJnM2KnC9l4IQYfOZ95ZM6kWSXlAIdPq89Zg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5a802657-a6e8-9cc3-fefb-09a7e68d1e5e@suse.com> Date: Thu, 12 Jan 2023 09:08:23 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 02/17] xen/arm: implement helpers to get and update NUMA status Content-Language: en-US To: Wei Chen Cc: nd , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , "xen-devel@lists.xenproject.org" References: <20230110084930.1095203-1-wei.chen@arm.com> <20230110084930.1095203-3-wei.chen@arm.com> <9e32ffa1-1499-f9cd-7ca8-f9493b1269cb@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0144.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9520:EE_ X-MS-Office365-Filtering-Correlation-Id: 903bf81c-cb6d-45c3-d582-08daf4742e5a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iy+Tck9oeVEhJm30qJppCxWV5VulCM9mjoP9Q+dSqdZkW5iKYQ6vwAq6PHxxxOEJEM5bbzLtFMmv8EGpPqI/vVDMK/Uw+xSXVgNIS+ZeBhP9quu5da9wFZYDGZi7Tk3A9S60yJLMTjzAowqzeQB+BIet/5glsUN+A8YMEd+hD8MYoGDlaVGhXyHBo4ZpVhHZbSfSl1b3sZ285J7SvuVPZoWpR22qtEQD7GKKzk57c8YmvqhCMh6nMJcpmWt6cXvNWNz6uiEM1WPPs2PCAVG1o+zpYGLE3kyniKjSTuO4S2BiVS5fAHyAUG2r8HFY8zL4uoZ+LigMxP+wfrL3cMCyaGxiyqv4eDcj9sWF2OFsZF+t+wUvZTzqUNKIQp2QjWLQIkNCDlswIc/0+mVqNUdwIduAmU0Xa4v8GD94MiKf0yC7xBGowf/ysCJ2Xm6jY6d+Dl5x2kjA44HndDSloXNOV2SGJoh9ewB5MoYdhq+iuYI17bBowyY8vi89fBJvzTDcn+ELkf6/qFZc0H7nD6+XirEodq8Tb/ek1bWyysrYBqUx4kBfSZRODe1OmLUKF+3skOcw1AMcsRuTz141RnMea0fRtGMA6s/hxFKPs3THOHUamGvBfHUZOlD/9c7urQU6XhTSAHyZ+3zNatbD7BROTt8iwPijUvKZSuU4k+GRf5DF3RUUzUgiQaqvV3N7Pzlx4POEqWgGeUhyblJm0kJ04aXiypntdXfT1zt+fR4MUNk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(346002)(136003)(366004)(376002)(39860400002)(451199015)(186003)(6512007)(26005)(6666004)(6506007)(8936002)(53546011)(7416002)(478600001)(31686004)(6486002)(316002)(6916009)(2616005)(66946007)(66556008)(66476007)(4326008)(54906003)(8676002)(41300700001)(36756003)(83380400001)(5660300002)(2906002)(15650500001)(38100700002)(86362001)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?blhRTi9PMlM5eVN2d2NhTUdxNHc3RmR1ZmNBT3VkSEhKa0hJQXZaaGloU0JJ?= =?utf-8?B?N1hIQ2pKNWdGWHNPcjRjUGM3SitCc2c1WGlqZisxYUc1ZzdkYXd3ZERVZ0Jl?= =?utf-8?B?TnR3YkdVNk5YVEpOajZ3MGRhVTFBMFQ3L25oV1EwdkV1ZkFkbW5zNzlwQzJQ?= =?utf-8?B?WndCaWZyK3ViYmZneDhaWHpqUUgyVUF0Slk5MTI1Y21BRmpDeUt3YVdTS0to?= =?utf-8?B?VWIzNVRpTzZVMEFsNVVmbFRTdjIwQnBNMVNIc1NWeEtxK0N0N281dlU1eTZY?= =?utf-8?B?WUJtOG16UzBjRGpTT3VtRlhnKzBJc01jRFBzYUVTQXM0L1VMdkRhcnJFSDZ0?= =?utf-8?B?MTV2YTJwUjlXQlBxM3VjMTAzVlo2cVp5SVJTNDVQTENaTGJhVmpxaTZka216?= =?utf-8?B?TndoSVZORkhpK2UxRE9wUEcyY2VZdTBpSEFjUWhiWnFiYkNCU05aVGpYSUF0?= =?utf-8?B?YkFQVjR0SWh6UUovd0dXVWtaRDFNS1g3dWhPajdQTXQ1Y2p1NVhTNEhNVUt5?= =?utf-8?B?emRsV3g3dHJad2RScWtKY0lwd1ZKVTV4NGFqUnNnTVpUWnFCaWRTdnRST241?= =?utf-8?B?UUFrNVNCZldXd2hhT2h3ajBmMTdNSEN2NzVvdmhwaE5BRTQyQ0FRQ1NxV2Ux?= =?utf-8?B?UVRWUTlrTm1FMER5bkhHZnRldndXYklnNnIvT0w2aFlpelpXNnBLSFBFVHdW?= =?utf-8?B?TVZOWnY5clJzZU5WYS9tbGdPaWNwdnJudHlRaC9yL0RpR0E1VHlGdTQyR0V1?= =?utf-8?B?Yk45VW5VWERKZGx6N2M3b3cxdlg5dkdpcTZEb09pT05qSGxWNlZSeVBiWkJj?= =?utf-8?B?Yk9UTXB2eEpTblA2M3NwNkVNbC96VGdCZURacm1oNWlnaGFkL1lqcnQvcmRs?= =?utf-8?B?T2Y4R3hmUjU0TTNtL0lobEE3YlI2SUlKeVR2VXkvZjRLbEZvREI5TlhMM2lG?= =?utf-8?B?akhHTWwvc0U2dXY0NVJERWNqbXQxTkVGeE1BRERMWDdwTTlnT09uN09HK3A2?= =?utf-8?B?a3poRHZWeHpEblRlcnVMa3E0ZzA3RXpSWlhKN0Q4Qy9LT2JhclBDVFZVQ2JM?= =?utf-8?B?ZldBT1JJRHp2ZzZzbkFDVGp0aVJyWmRkL2RZa1hSUXAzazJ3MW92WGFNM1p0?= =?utf-8?B?dlZtYTZhRjhNZkhJSW5WeG85emxrdGNBdncrYURJWHFPMDNlcXhuYmZPMnlN?= =?utf-8?B?UGFYZ2ZIUW9YYjRXek5XRDhnZ1FEUHBIWklKbExwMlVHRk8yZ1B0RG9Ea2ZC?= =?utf-8?B?VzJkYmFNZlczbmZybjFJeEl1QlVpb0VHc2xUb051SytlMDJSWGkvZWhYcTFV?= =?utf-8?B?ZmI3OUEvREpNQXlCUFhmMmhSb0RpWFE3SUJwZTkxeTlJNXNscVRiV2xJSmhY?= =?utf-8?B?WmwvaExCc0dEWHplMXF5NzdIb29qUHZJRERCZUpnbDBQNG03TG1PRFlvbVZN?= =?utf-8?B?QWZsemNUY0ZrNmpHVGFrWW9wQXl1bUpHWmZwZWwvQUtFSEZCS1V2azk2SURZ?= =?utf-8?B?Q0tlSUdTVjZHYXhBVHNTRE5MaVBoRW44SzM2MzVtcStmSUdselZRbXZ5eUJY?= =?utf-8?B?cm9xanAyRE40T1BRSjVpL2NoY2I1WW93RTNySHNOQUpoQ2hoM1Jpa0xiZFYr?= =?utf-8?B?cUNla2l6ZzNoVjNSNnVJUFU2MnpZOWsxRXhHQ1RTQXZCNXllODJGNWdQVUVE?= =?utf-8?B?TFhmaFFPOE4wckJrZUpXbGhHbXAwdnh3dlpTNmVlZjBqZkFKcXRhOTJ2b3o4?= =?utf-8?B?T0RHamgzTE9GVnJsVDNXYlJJRnlaQ1JBVkVST2hIMW8yUkpKWTJ5SjFub2x2?= =?utf-8?B?cEVUamQ0aG5hWDlkem41Q3R0ZjhBUnR5anBDZEsrNEVPczUyV3VlYkJTdmVY?= =?utf-8?B?TVg0TDRBbWtjMTVtM1hXMWhhMmpWUENQcy8vbjZIRjMzOTBOYTRKRTJsZjlz?= =?utf-8?B?dVNCeTlKeGRkWUJlemt6czlGVUttMTI4ZGt1VVU3dVlIYUJMNkZEUERhNHJ6?= =?utf-8?B?L3I2WDF0a1VnbWQ5bDJ2YkxrRHNZcEkyU0JudkxRMytYVENHR0ZFZGNraWds?= =?utf-8?B?Z1UyN3pnQzZSZVRObE5XWUk3WXlTTjM4TGpiWGlDVkVDaFk0N052NVVRMzVH?= =?utf-8?Q?Bnwlssyf36crG+LC4iBZaJmwK?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 903bf81c-cb6d-45c3-d582-08daf4742e5a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 08:08:26.0559 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kv/BGVqNId27U+hMv0RZUAhX8VCBp/zrwQJejDt4fcdyKpERt35QjJFZPChqWUqGluRibEa1Wgb/w4waKyuk/w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9520 On 12.01.2023 07:22, Wei Chen wrote: >> -----Original Message----- >> From: Jan Beulich >> Sent: 2023年1月11日 0:38 >> >> On 10.01.2023 09:49, Wei Chen wrote: >>> --- a/xen/arch/arm/include/asm/numa.h >>> +++ b/xen/arch/arm/include/asm/numa.h >>> @@ -22,6 +22,12 @@ typedef u8 nodeid_t; >>> */ >>> #define NR_NODE_MEMBLKS NR_MEM_BANKS >>> >>> +enum dt_numa_status { >>> + DT_NUMA_INIT, >> >> I don't see any use of this. I also think the name isn't good, as INIT >> can be taken for "initializer" as well as "initialized". Suggesting an >> alternative would require knowing what the future plans with this are; >> right now ... >> > > static enum dt_numa_status __read_mostly device_tree_numa; There's no DT_NUMA_INIT here. You _imply_ it having a value of zero. > We use DT_NUMA_INIT to indicate device_tree_numa is in a default value > (System's initial value, hasn't done initialization). Maybe rename it > To DT_NUMA_UNINIT be better? Perhaps, yes. >>> --- a/xen/arch/x86/include/asm/numa.h >>> +++ b/xen/arch/x86/include/asm/numa.h >>> @@ -12,7 +12,6 @@ extern unsigned int numa_node_to_arch_nid(nodeid_t n); >>> >>> #define ZONE_ALIGN (1UL << (MAX_ORDER+PAGE_SHIFT)) >>> >>> -extern bool numa_disabled(void); >>> extern nodeid_t setup_node(unsigned int pxm); >>> extern void srat_detect_node(int cpu); >>> >>> --- a/xen/include/xen/numa.h >>> +++ b/xen/include/xen/numa.h >>> @@ -55,6 +55,7 @@ extern void numa_init_array(void); >>> extern void numa_set_node(unsigned int cpu, nodeid_t node); >>> extern void numa_initmem_init(unsigned long start_pfn, unsigned long >> end_pfn); >>> extern void numa_fw_bad(void); >>> +extern bool numa_disabled(void); >>> >>> extern int arch_numa_setup(const char *opt); >>> extern bool arch_numa_unavailable(void); >> >> How is this movement of a declaration related to the subject of the patch? >> > > Can I add some messages in commit log to say something like "As we have > Implemented numa_disabled for Arm, so we move numa_disabled to common header"? See your own patch 3, where you have a similar statement (albeit you mean "declaration" there, not "definition"). However, right now numa_disabled() is a #define on Arm, so the declaration becoming common isn't really warranted. In fact it'll get in the way of converting function-like macros to inline functions for Misra. Jan From xen-devel-bounces@lists.xenproject.org Thu Jan 12 08:11:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 08:11:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475883.737758 (Exim 4.92) (envelope-from ) id 1pFsgI-0005oE-NA; Thu, 12 Jan 2023 08:11:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475883.737758; Thu, 12 Jan 2023 08:11:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFsgI-0005o7-KC; Thu, 12 Jan 2023 08:11:26 +0000 Received: by outflank-mailman (input) for mailman id 475883; Thu, 12 Jan 2023 08:11:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFsgI-0005nz-05 for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 08:11:26 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on2053.outbound.protection.outlook.com [40.107.8.53]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b3c50771-9250-11ed-b8d0-410ff93cb8f0; Thu, 12 Jan 2023 09:11:23 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9520.eurprd04.prod.outlook.com (2603:10a6:102:22f::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 12 Jan 2023 08:11:22 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Thu, 12 Jan 2023 08:11:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b3c50771-9250-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O8H+cCLnYeUtZ4rJi+HCktWJdNFdupoL2hPpY4d07Xa4y+CEZVplfe4+vu8guJe6T0nhI6OfBoHfVQ0E89SXZe1EZk/2ROqi4euoCoFWI2J1PoAiPOnFwlvnHFNRSaXC5+1wpkDMvJKNyzIw06Od0MxiGcLUZR8ZOdL8NxL4N+DS60tCBimPUenl5+aNeh/o36RBq/pXgl6l5ylJK3EmqR+YMkQ1bAPIqfmXQ7tTZ9U5pfL/5GQBzV3wWlZhSlFinbWiJSCto/p24/cM6RXWl4mWKQD+5DCQwFeii8PH4eG+YdrBy0x/iD8ytHQYelNJWUMKJxL2GrUNialZMRJfcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TDymfTCZTo/ms0/4p7VbEMIg1/AAMShmhSBVQAO3fpc=; b=aUrJGbSl3TCgLnPkiCTNXpUGsKSQGTqCrp+4sW3/ZWd1MDSKj+Ij+IHf1CqJ3qnh1ow6p0plLXwQCGdRVbqCyKdZsLaIB7BfQSGfysoSCh8bQdWmS0WHGDxiFnLweBIqdFfglC9/I/ih3ULLP+LdRDfpbUQ02Nx6WHnO3Tm2C21XDkbNGEYoOlBQYSiJwUZbuXpAHCMuXiVLA4FpLuKVPxawhjwjKv/+Pjl3AH1hBmRg2q4UuX6VkDqoF88Vfr8x2h+U8sq6pfo2fh5BOidBdDDBWuPGPqF7dKHt/0m0ViLuO0317YInELpwftsEEDohR8/+4wMwXD0MvE5c3shKNQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TDymfTCZTo/ms0/4p7VbEMIg1/AAMShmhSBVQAO3fpc=; b=0FFjyHd+eK4nQpFhg9Nr6A0ETZ9r+aExcAE6roQW7gqpHwFjukYbmNmxknDXkrgMuSYRpqhJXhNcf6hi7/9Svyo6l822p7u9CBpHrHgvSiqbBsFSQ/dEaformK1qJJIRXE0x55k+rn7+khUr3OSPu5JZWixPwMCsYkxUuQk4XvEkUwdGuxum4bYmRP4rTQtjcS6UWZcNzx/FTd9TbBiHJ1Iickx9Kb/qeWwivbEOHtDXyHoj16DoZCpZFaH1eoJhC2ggV7s4BNIEese0sDmGwlAjkRKWRPMH7FKa4N7mIKtCGH/TD28ohZ2fJKYA6ltfoN7O041joK6Sor+gjMjw4Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 12 Jan 2023 09:11:19 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 03/17] xen/arm: implement node distance helpers for Arm Content-Language: en-US To: Wei Chen Cc: nd , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , "xen-devel@lists.xenproject.org" References: <20230110084930.1095203-1-wei.chen@arm.com> <20230110084930.1095203-4-wei.chen@arm.com> <9fd67aa2-0bd5-16a2-1e19-139504c2090f@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0135.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9520:EE_ X-MS-Office365-Filtering-Correlation-Id: 326844cb-b5b0-40b3-0d37-08daf4749756 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BlWd71viJKp60g7lcwzARRRS0dDb0H0UtlNEIpoob0Epywzn+J8YfxDcRfN3P65l5KmBF1NyrtCKs9TbAj7CbZSwVnKH0NRAjTiZv8DTDoMxKe77yHTw5E4Ns8xxDVkjVidGMJMf4HKF11iMNewMhsAf/qqgKhwQJnMPPJJGqVn+lay6eUaFNNmYvz7RH7hwJs020xNIQLwM9swoAGL27dJzfFiNciDyhOXZ4Y84UW/aiFj0e+kfZzJPwvGs31BDu8OzRzYT4eIOQGYA+EwgfGiBZUeZZnj2zzWqvGvE79xJ3P3tMe1qaiL1AsGW9AIpJcFQl+OY9Ow+7uFBoJDMPilEYVCEbt6Dk+Ct3taCfPeTZkHm+VIBxnu4Z3UvYtEyOHjnHcWWbRcyhnhR+f3JvJNCSQv3giK63tuwaaTDpls24P0EatbdkleqtVSY27x3YYMGIR0aTsokM84q0QX66H14VQKCKwZGUlF4WUhIdI66QkAkUh1Z40wGmL6sGI3zsvsnOHqabxhho+NgANptxzDA9+hpPbU6wduKeXhJGa2+1VA5COKCLbnuhdKD5bYO52WffJWX8WzaiYdNnsuYdG8BTHR62qf7K9DWmmtIaqZbKNYVp1/xuaHZRlxktKNEZ1UbPtaGvfBxIkug2WYySW/aeD+Hbtxd/vKVSOkDtGb8RAMRyZxDe7kucfvLOuXkmAzENCschvXgCtlOVwXbfPa7ier9mqPs4R0DDpU6iS4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(346002)(136003)(366004)(376002)(39860400002)(451199015)(186003)(6512007)(26005)(6666004)(6506007)(8936002)(53546011)(7416002)(478600001)(31686004)(6486002)(316002)(6916009)(2616005)(66946007)(66556008)(66476007)(4326008)(54906003)(8676002)(41300700001)(36756003)(83380400001)(5660300002)(2906002)(38100700002)(86362001)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eHJ6V1paSWNoYTg3SjRZbzdQclJlcXE5dXMvNlF2WitmL0dYR09GZHpIU0lq?= =?utf-8?B?WUlZRDNUY2FsSi9vZE5JNVdGRjRMZ1pSQURqNldjblArZWxZeWJCOXg4eEpN?= =?utf-8?B?WmZJV016MjhFLzN2M09LVlZaQ28wZFREVm5WSUg2U1NtWWkrbUNaZFkvcDc3?= =?utf-8?B?TXg0SW1xeWhScG1POGRjSTZkd2pZOWNIMTB1NWx5dW9iZXIxb0V6TzdwajVV?= =?utf-8?B?MzdqRHhyaTN6QXVhdC9taEdCZWtrVGFTdHJPNld0bnRsTWlLaWw4MFJKa2tX?= =?utf-8?B?eGFtLzJoNXRnTTRja0Z1RkQwZ01scms0amEvbFJDeDlnRERsazlNdGJ3eVpZ?= =?utf-8?B?blBnUnhtRlNrYVRJbGpxeHRodUVwWitRTHhjR0Vub2dZblYzSGFJdVJYZzdE?= =?utf-8?B?eFhHQjZhczFDUDZSVVMrd0duTnpXVmdVZzJHR3NHZmw4Qk1jcW93Z3dycEI5?= =?utf-8?B?aC9Mei9GNnY1RXM4aE90THJEZ01sS2tYUGlmZE5vR0pwWmlQZDlWa05VNzJF?= =?utf-8?B?OVc2TXpxNXJKNHZnd2RsZ1BYRzI2Z2Z6ZUM2cnlUbTNiSG5CUlRnajN4ZzBN?= =?utf-8?B?L0dYTGEyMWtra3ZtZDhiT0NsMlR6bWRJY3d4cGlSYWRsejB2aDVOZ0NKMVVF?= =?utf-8?B?Y3BkTGpESVo2QnJ6M3FpNlJNdHVVdnBGbXRNZHZnOVljc3NFTCtMd0Zzc2hT?= =?utf-8?B?VTF4Q3k4TzJWdkMzVjNxa1JQTmRicS8yNTZQc3dmUGhnc0g3aHJjRWlHcG1j?= =?utf-8?B?YW9wWnlVd0toa2hTRXhQRUZHRi9HUkVBMVU5Smpoc0FnazFReDRybUNSRmVR?= =?utf-8?B?UFdzOUV3UVp2L2VQZXg1d0lGK0huRWZyUkNyS0poVEY4K0F3Yk9Yay9MLzlG?= =?utf-8?B?Qk05VGVtd0NXd1k5RXNuWndlbnQ3RmVmb21aTVhHV01CWkdEUlRzOUI1MlFM?= =?utf-8?B?M3JlR2t3RHJRdWZ4SnAzeklaZTBZUFN2TWhET0hZUnViL3RUQnllb3hqTW1K?= =?utf-8?B?K05sZzNvVTkzK1N6eFQ0akZ0b0VhZ2ovcmFwc1lJUDcwbkE1QzlQeTR1U2FI?= =?utf-8?B?Skp2TEMvWllSMWxRRm4rQmxEeU5GWWFUTWlSekNnLytKeUNBWUFhWnhNWWZC?= =?utf-8?B?MjBGMkRJUEU4ME9vUTlyK09UTldKbHh5SVVYSXQrNzR0bThldHdNWWc4aCtl?= =?utf-8?B?SHYzcG1PWXV1czlDOWJXWk9jWHVlU2VtTGNuV1lFWkZjT09aU0YwZmd5Z0U1?= =?utf-8?B?LzNxTE00T2RFTmllNDFTclpVRWt0a1VQdnZjV2VRVDNtdkw0cUdEcmpZY2lu?= =?utf-8?B?QUpvM05keko0WVdKamhpbXJUMittaXl1dVVtTDVoVStNRlR1b2FSOWxzenBv?= =?utf-8?B?SEV4RER3WXdMM0hJTkZvOXJ3NmhxOFdVY3RGc2YzVGFqL29wWmRWNU03SS9r?= =?utf-8?B?Y2IrWHJER1RYYlRDVGNtOEg0a0Jkbmh0MXZ2RWlDeHY1UkduT2JxQldIelAv?= =?utf-8?B?cm1uL2x4OUl2UUJrUEJaZHFkWXFSejlFR1E5cTFSNlZzL1NCeGw5ZXcwNzR6?= =?utf-8?B?NktJazJ5TVd4cjBvczFPTXR6L2VqR3VHNnRuM3B3aWExdUVDU1F3K0RDd0NF?= =?utf-8?B?ajlhREVvVk92SmpMTjI4MDhSMU8xNjVsc21RUjlkWnlhMnoxaXM4akVJNGJG?= =?utf-8?B?b2EzVWNFSjNoaVF2MDQxc0w0VlQzWitVUlVWSXVUVklPbndsV1BhNHpHWWtr?= =?utf-8?B?NXdEaUhOZ0hQUUNTZWROVFMxd2JxQmxSMnpRS0JKTk0rb0hwSVdRbG1ra3lZ?= =?utf-8?B?ZzRLRHBnUlZsbVdLTzdjSHZ1RWVVUzMvK1lDMWJVOUhvQVhUTHF2U1l0YWxC?= =?utf-8?B?Q2s4V0djZVFaYXNtNlRyd2M4RHJ3ZUZxeE9yVzNHYkQ2WnpXZm1GelowQ01k?= =?utf-8?B?NkFwaHloZEZFSkRSS1FOWUFucXhJL2JMb3BPTWRBemhEdjdqd0hWYm52ckF0?= =?utf-8?B?aWtNSkdodGxYNHFEcG53UkZOTW5VTUM5cGhmNGRBaUpUU1hqb2FFQzgvZE1m?= =?utf-8?B?U3ZmL29YTjZlMTE4MHYyelI5ME9TbGE3MFJOMk10ZTQxbEg3WDZneG84VXFB?= =?utf-8?Q?dyZLX2KBkFM7fp6BAeQ1wdPL7?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 326844cb-b5b0-40b3-0d37-08daf4749756 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 08:11:22.0447 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4yxblY93uDvC1Vuqunfpf0AtgiBWpszZLilF1wOGppqFnIOxYq90AyQMxCYZT+a/cmhp9MhGzZgIhoAjZgF+Cg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9520 On 12.01.2023 07:31, Wei Chen wrote: >> -----Original Message----- >> From: Jan Beulich >> Sent: 2023年1月11日 0:47 >> >> On 10.01.2023 09:49, Wei Chen wrote: >>> --- a/xen/arch/arm/include/asm/numa.h >>> +++ b/xen/arch/arm/include/asm/numa.h >>> @@ -28,6 +28,20 @@ enum dt_numa_status { >>> DT_NUMA_OFF, >>> }; >>> >>> +/* >>> + * In ACPI spec, 0-9 are the reserved values for node distance, >>> + * 10 indicates local node distance, 20 indicates remote node >>> + * distance. Set node distance map in device tree will follow >>> + * the ACPI's definition. >>> + */ >>> +#define NUMA_DISTANCE_UDF_MIN 0 >>> +#define NUMA_DISTANCE_UDF_MAX 9 >>> +#define NUMA_LOCAL_DISTANCE 10 >>> +#define NUMA_REMOTE_DISTANCE 20 >> >> In the absence of a caller of numa_set_distance() it is entirely unclear >> whether this tying to ACPI used values is actually appropriate. >> > > From Kernel's NUMA device tree binding, it seems DT NUMA are reusing > ACPI used values for distances [1]. I can't find any mention of ACPI in that doc, so the example values used there matching ACPI's may also be coincidental. In no event can a Linux kernel doc serve as DT specification. If values are to match ACPI's, I expect a DT spec to actually say so. Jan From xen-devel-bounces@lists.xenproject.org Thu Jan 12 08:29:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 08:29:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475889.737770 (Exim 4.92) (envelope-from ) id 1pFsxk-0007TQ-75; Thu, 12 Jan 2023 08:29:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475889.737770; Thu, 12 Jan 2023 08:29:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFsxk-0007TJ-3y; Thu, 12 Jan 2023 08:29:28 +0000 Received: by outflank-mailman (input) for mailman id 475889; Thu, 12 Jan 2023 08:29:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFsxi-0007TD-MW for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 08:29:26 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2086.outbound.protection.outlook.com [40.107.21.86]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 376ae5b2-9253-11ed-b8d0-410ff93cb8f0; Thu, 12 Jan 2023 09:29:23 +0100 (CET) Received: from DB6PR1001CA0015.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:b7::25) by AS8PR08MB6504.eurprd08.prod.outlook.com (2603:10a6:20b:336::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.12; Thu, 12 Jan 2023 08:29:20 +0000 Received: from DBAEUR03FT043.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:b7:cafe::f3) by DB6PR1001CA0015.outlook.office365.com (2603:10a6:4:b7::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.13 via Frontend Transport; Thu, 12 Jan 2023 08:29:20 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT043.mail.protection.outlook.com (100.127.143.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.13 via Frontend Transport; Thu, 12 Jan 2023 08:29:19 +0000 Received: ("Tessian outbound 6e565e48ed4a:v132"); Thu, 12 Jan 2023 08:29:19 +0000 Received: from 55b07ef79176.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 91BA8309-165C-4137-B154-3A2EF281DCA1.1; Thu, 12 Jan 2023 08:29:12 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 55b07ef79176.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 12 Jan 2023 08:29:12 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by GV2PR08MB8750.eurprd08.prod.outlook.com (2603:10a6:150:b6::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Thu, 12 Jan 2023 08:29:06 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::72d6:6a74:b637:cc5b]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::72d6:6a74:b637:cc5b%3]) with mapi id 15.20.5986.018; Thu, 12 Jan 2023 08:29:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 376ae5b2-9253-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DL/iYYTLzQHhiT5NJsqQUflNwBq/XnQTi7AVoBheryk=; b=Oa/yaxVGAUB0Rj19ZnEEe+KIJVFwq+RaRRFQTGC3a/lvsJcNQ5aCiQGehDRh7mhntZixha5GnP4RJqMYL5UpIbhV15RyjU4EMkbk1b1VTwbS510Zeh7hZnm1kjzjehil0l3lpjwy/Ts6Z1e+5v3pkhJ2rF7/lF4K8+xdIO3h0BM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bmG8eWe4dlobd7eEWvDmTZd6ThgCekBpIr2vPOLvYVWkPTbQ87EmQTfEezkcRQiKS1L3/KDYqQkUw4TJeX3fBrkr/Rzm7lTLG2b90r0QsbM/JgHxhuldHxRjOsjr5NHhCbv3X2ZyZeR8Et2V/ac0TMKmmBSVWRQcQ7BkLZ54D7HxXdn34R1M/Sdp3EcLMQwDlTbGiNyxMiUNbWIDRXDdR10S//hbSQZsIJgmSI9hWqPPy57Vy8hjxuBMuET5/ISirZoQBSagMdTXe74nedqkFATMy5hDrSqBOn+HGdamuRXVrtvdidCaeHWBxGLmpC1w/0KYjBTsmEfr6xSy5GmRIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DL/iYYTLzQHhiT5NJsqQUflNwBq/XnQTi7AVoBheryk=; b=Cyzf6+iSsykWj/xpmqtOspoNxPEgVedyjRhrPJkIWY3gBQP6SnNDMufJiz1xjNylUFSXOGVwdS2JaJ64BHZuHAlcL7KR+mHBzsqMrNhYCBe+v3NKo5YCHaNv2x9VqbzhEfMMKoF2ueyrAs6qKfemzor/fl50qIVeA+2sPUjbNCnHFExijiJ/KtyXgAojXyUa5b1b8toWNkuP82+5q9deHlZgs9BsASBbNs4yvJ3fICJWm7c0ezdkERO0aOEKdc+LM+Bn7kd0J/DLVsLaa7FpOoOMvL7ydYIHQAx4cxZhmiruXtw3XUCNFX1GFlKHj/Qou7K3oYS8svFN/UKgnwjRTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DL/iYYTLzQHhiT5NJsqQUflNwBq/XnQTi7AVoBheryk=; b=Oa/yaxVGAUB0Rj19ZnEEe+KIJVFwq+RaRRFQTGC3a/lvsJcNQ5aCiQGehDRh7mhntZixha5GnP4RJqMYL5UpIbhV15RyjU4EMkbk1b1VTwbS510Zeh7hZnm1kjzjehil0l3lpjwy/Ts6Z1e+5v3pkhJ2rF7/lF4K8+xdIO3h0BM= From: Wei Chen To: Jan Beulich CC: nd , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v2 03/17] xen/arm: implement node distance helpers for Arm Thread-Topic: [PATCH v2 03/17] xen/arm: implement node distance helpers for Arm Thread-Index: AQHZJNEfrPi0xon1hUWBAoFjpzsCdK6X3MQAgAJ3JNCAAB1cgIAAAqfA Date: Thu, 12 Jan 2023 08:29:05 +0000 Message-ID: References: <20230110084930.1095203-1-wei.chen@arm.com> <20230110084930.1095203-4-wei.chen@arm.com> <9fd67aa2-0bd5-16a2-1e19-139504c2090f@suse.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: EC1657997C37974EB9B39B4D0E357F87.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAXPR08MB7420:EE_|GV2PR08MB8750:EE_|DBAEUR03FT043:EE_|AS8PR08MB6504:EE_ X-MS-Office365-Filtering-Correlation-Id: 25ee3c03-5407-423c-a805-08daf47719f0 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: nZAtoqf1S4HJ9o1Bo7u3yCtS59qUo6OjyhGbfiG6lTJBBqvHIUazKzmeFjc9NqqD9Y0ggtks/+sAkfiblwFZR7LTG5GXGZWMLQnzMrqIIIZGtOjcnhbZo6RFi6gRdJ9N6kc0P6rqdeAFRjmOJNBrPL/XsFxT/MQimaBo2xDf8FtMzaftF4fxj2XDnso4TIHZTIPJ+RA4wlowxv7flrdfuOZhjzhCAhbASmmhCatToXr9Cfo0Ad9OO0mWecjZ4OIytrqDAY5W9R58H9d6lAdGqF9MzmTmkIH2nAX5rskdF3zCaLBGCG9F6dhE/Izam/fLuiSNZ3qOF+Nva1VZMkW/VDxhTPZ2sJERgDD454r+cGGchPlw+yNZhqRqN38Rk1cDtfelah+8x18/bic+uPjiY5U7LH0tbilrVhPr451QfVLYUnaHtsnXZ18a/U7bjIIk6bSZ5mGHGgJirHZuV/asWWCSScQE0dwv9pLsIha/uJIdvehlCdMKt/R/lrj2psmlh9UsNUuzg7+9xFSaPtKu37HPUTld5QEqW39CIGQeIR8H4Z906mpWzqkz1v5pdVShicGsHy2qGbu+98sVoLbe4eYQWAZpJDRrYBi7gXIAgCZgERAyzdTmoBBiJWKXQqtsyD68/8BQX+Y2HN3lTHOIN2boxBMR/pcj8tIqkeS/8tMi9pwSsxNuz3/g/G7GnXy55APLa7fc0dZ32RB+9xO33almGhN1J9QPwgXv6hsxJtM= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(366004)(136003)(376002)(346002)(451199015)(38100700002)(122000001)(66476007)(66446008)(4326008)(64756008)(86362001)(54906003)(6916009)(66556008)(66946007)(76116006)(38070700005)(33656002)(8676002)(41300700001)(8936002)(55016003)(316002)(2906002)(5660300002)(52536014)(7696005)(83380400001)(186003)(966005)(53546011)(71200400001)(26005)(6506007)(478600001)(9686003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8750 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 25a5b978-5db1-47f6-3465-08daf47711a8 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: S+eI4lkpq/2RXdrnSGuzWUZ+Bfw8gbONIkYgezQeWC7O4NiKGTRweG8hJkmuF7wxhSUPEVyuKqXHaS4CuBFSh5mAlJOF3SS29yiBHVEHYnoXF5cjJVcz+nTeJrOEUm3C/7t1rmHwI8Br34MZkaY5kYjm+rqexoU76iTro+lpUBE0Fr1mqsr3lrwLYnj9X42kch7LhYSB+Cw6jjLcK0GNAqqU2fvBsC53VXlErL+Z6fhbuIzOjOHDi0HxkvNuhAVA7ezohDB0rQGzxQQy1895DlZzJMitDDKHwnsM+4+JeToL9tdgDV0DcmOzxWeuH8AwMSLHKICK/Cm9HoIZlD3xWWuHUX0cM1LzY6K4ll7fq6MJvDzp18W2oXPEQpv/LKEFa1rs7oNtvlXh+WzUM8NB5pahWt3Vqxs2nmpHuO8NXcbIdCO9zbquGwYsvVYub3ZCKfWKAH2ks6XRJRkhWvnW/k8w0z4n3D6dGuNiUhGP3kf188smr8Hl/tt90JDf/KkuChaz6KMMXF37OVqZ3EOhQzYhjkwpRySeec3LO2EbOySe/9nKTQMI4oXsukcctQlVXbW1sVDfStziUrEwFv6mVNyUL02j2dSPjJ/aEymmSNtFzceAhMcsmUoZNjyIs0cduzBQR1r7z3/Evvo6S9OCS80wPcrW7NHixEgpp/rInKlfVZvu0LUOJ51B9H7gZ/ssqegHEORmex+Rvx7t2aqdfdOBVR7byypriIICIwpMbUE= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(376002)(39860400002)(396003)(451199015)(46966006)(40470700004)(36840700001)(70586007)(6862004)(8936002)(70206006)(36860700001)(4326008)(52536014)(8676002)(82310400005)(81166007)(5660300002)(356005)(33656002)(86362001)(2906002)(316002)(40460700003)(54906003)(83380400001)(26005)(7696005)(41300700001)(336012)(47076005)(478600001)(82740400003)(186003)(40480700001)(53546011)(55016003)(966005)(9686003)(6506007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 08:29:19.9834 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 25ee3c03-5407-423c-a805-08daf47719f0 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6504 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU2VudDogMjAyM+W5tDHmnIgxMuaXpSAxNjoxMQ0K PiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+DQo+IENjOiBuZCA8bmRAYXJtLmNvbT47 IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz47IEp1bGllbg0KPiBH cmFsbCA8anVsaWVuQHhlbi5vcmc+OyBCZXJ0cmFuZCBNYXJxdWlzIDxCZXJ0cmFuZC5NYXJxdWlz QGFybS5jb20+Ow0KPiBWb2xvZHlteXIgQmFiY2h1ayA8Vm9sb2R5bXlyX0JhYmNodWtAZXBhbS5j b20+OyBBbmRyZXcgQ29vcGVyDQo+IDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPjsgR2Vvcmdl IER1bmxhcCA8Z2VvcmdlLmR1bmxhcEBjaXRyaXguY29tPjsgV2VpDQo+IExpdSA8d2xAeGVuLm9y Zz47IFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPjsgeGVuLQ0KPiBkZXZl bEBsaXN0cy54ZW5wcm9qZWN0Lm9yZw0KPiBTdWJqZWN0OiBSZTogW1BBVENIIHYyIDAzLzE3XSB4 ZW4vYXJtOiBpbXBsZW1lbnQgbm9kZSBkaXN0YW5jZSBoZWxwZXJzIGZvcg0KPiBBcm0NCj4gDQo+ IE9uIDEyLjAxLjIwMjMgMDc6MzEsIFdlaSBDaGVuIHdyb3RlOg0KPiA+PiAtLS0tLU9yaWdpbmFs IE1lc3NhZ2UtLS0tLQ0KPiA+PiBGcm9tOiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+ DQo+ID4+IFNlbnQ6IDIwMjPlubQx5pyIMTHml6UgMDo0Nw0KPiA+Pg0KPiA+PiBPbiAxMC4wMS4y MDIzIDA5OjQ5LCBXZWkgQ2hlbiB3cm90ZToNCj4gPj4+IC0tLSBhL3hlbi9hcmNoL2FybS9pbmNs dWRlL2FzbS9udW1hLmgNCj4gPj4+ICsrKyBiL3hlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9udW1h LmgNCj4gPj4+IEBAIC0yOCw2ICsyOCwyMCBAQCBlbnVtIGR0X251bWFfc3RhdHVzIHsNCj4gPj4+ ICAgICAgRFRfTlVNQV9PRkYsDQo+ID4+PiAgfTsNCj4gPj4+DQo+ID4+PiArLyoNCj4gPj4+ICsg KiBJbiBBQ1BJIHNwZWMsIDAtOSBhcmUgdGhlIHJlc2VydmVkIHZhbHVlcyBmb3Igbm9kZSBkaXN0 YW5jZSwNCj4gPj4+ICsgKiAxMCBpbmRpY2F0ZXMgbG9jYWwgbm9kZSBkaXN0YW5jZSwgMjAgaW5k aWNhdGVzIHJlbW90ZSBub2RlDQo+ID4+PiArICogZGlzdGFuY2UuIFNldCBub2RlIGRpc3RhbmNl IG1hcCBpbiBkZXZpY2UgdHJlZSB3aWxsIGZvbGxvdw0KPiA+Pj4gKyAqIHRoZSBBQ1BJJ3MgZGVm aW5pdGlvbi4NCj4gPj4+ICsgKi8NCj4gPj4+ICsjZGVmaW5lIE5VTUFfRElTVEFOQ0VfVURGX01J TiAgIDANCj4gPj4+ICsjZGVmaW5lIE5VTUFfRElTVEFOQ0VfVURGX01BWCAgIDkNCj4gPj4+ICsj ZGVmaW5lIE5VTUFfTE9DQUxfRElTVEFOQ0UgICAgIDEwDQo+ID4+PiArI2RlZmluZSBOVU1BX1JF TU9URV9ESVNUQU5DRSAgICAyMA0KPiA+Pg0KPiA+PiBJbiB0aGUgYWJzZW5jZSBvZiBhIGNhbGxl ciBvZiBudW1hX3NldF9kaXN0YW5jZSgpIGl0IGlzIGVudGlyZWx5DQo+IHVuY2xlYXINCj4gPj4g d2hldGhlciB0aGlzIHR5aW5nIHRvIEFDUEkgdXNlZCB2YWx1ZXMgaXMgYWN0dWFsbHkgYXBwcm9w cmlhdGUuDQo+ID4+DQo+ID4NCj4gPiBGcm9tIEtlcm5lbCdzIE5VTUEgZGV2aWNlIHRyZWUgYmlu ZGluZywgaXQgc2VlbXMgRFQgTlVNQSBhcmUgcmV1c2luZw0KPiA+IEFDUEkgdXNlZCB2YWx1ZXMg Zm9yIGRpc3RhbmNlcyBbMV0uDQo+IA0KPiBJIGNhbid0IGZpbmQgYW55IG1lbnRpb24gb2YgQUNQ SSBpbiB0aGF0IGRvYywgc28gdGhlIGV4YW1wbGUgdmFsdWVzIHVzZWQNCj4gdGhlcmUgbWF0Y2hp bmcgQUNQSSdzIG1heSBhbHNvIGJlIGNvaW5jaWRlbnRhbC4gSW4gbm8gZXZlbnQgY2FuIGEgTGlu dXgNCj4ga2VybmVsIGRvYyBzZXJ2ZSBhcyBEVCBzcGVjaWZpY2F0aW9uLiBJZiB2YWx1ZXMgYXJl IHRvIG1hdGNoIEFDUEkncywgSQ0KPiBleHBlY3QgYSBEVCBzcGVjIHRvIGFjdHVhbGx5IHNheSBz by4NCj4gDQoNClVuZm9ydHVuYXRlbHksIHRoZSBsYXRlc3QgZGV2aWNlIHRyZWUgc3BlYyBkb2Vz bid0IGhhdmUgYW55IE5VTUENCmRlc2NyaXB0aW9uIFsxXS4gQnV0IGlmIHdlIGRlZmluZSBkaWZm ZXJlbnQgdmFsdWVzIGZvciBEVCBOVU1BIGluIFhlbiwNCndlIG1heSBoYXZlIGFuIGluY29tcGF0 aWJsZSB3aXRoIExpbnV4IERULg0KDQpbMV0gaHR0cHM6Ly9naXRodWIuY29tL2RldmljZXRyZWUt b3JnL2RldmljZXRyZWUtc3BlY2lmaWNhdGlvbi9yZWxlYXNlcy9kb3dubG9hZC92MC40LXJjMS9k ZXZpY2V0cmVlLXNwZWNpZmljYXRpb24tdjAuNC1yYzEucGRmDQoNCkNoZWVycywNCldlaSBDaGVu DQoNCj4gSmFuDQo= From xen-devel-bounces@lists.xenproject.org Thu Jan 12 09:15:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 09:15:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475895.737781 (Exim 4.92) (envelope-from ) id 1pFtff-0004HH-Lm; Thu, 12 Jan 2023 09:14:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475895.737781; Thu, 12 Jan 2023 09:14:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFtff-0004HA-J8; Thu, 12 Jan 2023 09:14:51 +0000 Received: by outflank-mailman (input) for mailman id 475895; Thu, 12 Jan 2023 09:14:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFtfe-0004H4-6w for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 09:14:50 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2073.outbound.protection.outlook.com [40.107.21.73]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8e39a3dc-9259-11ed-b8d0-410ff93cb8f0; Thu, 12 Jan 2023 10:14:47 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBAPR04MB7382.eurprd04.prod.outlook.com (2603:10a6:10:1ab::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.19; Thu, 12 Jan 2023 09:14:44 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Thu, 12 Jan 2023 09:14:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8e39a3dc-9259-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XRsLghl/IFzYgH2nEzacVx6KLftGuSR1OxRR7td4dwmZf6aPqiMHn6iGcC9d/ls6yqjCzt8jy/K9RUqeClUS8CgtfLDVq6e1DHDbiJ8vmbbqbLxKD9ASDnMVNpe9EI8vrQFzZjMJ5qHj6iTFNrnW150/UzHT+tlJM6lsdE0XT1I1A9DRqn4PTBn13RP9OVQlpE4s0l5Aw9UXbTKw8o+4uZyVHCzx24MLmxK+L7xxA1PnJonsIt0hI4nq3ENSKNig4DyNJw7WmRbfKnlohDtaqQV5BTTVeU2XEl3dEyo3ntqls1CCgsG+f6lMuU9tpJJs0WzIqJ1NV6RDiotseuBDzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NrXq9sANmJGnfgim5bzEJCucEceEnyBbmFCH112mVlw=; b=KAgJ7K5nkN+HnnNbITGHrr+uR+Y+mbyVrnNGi/C2/B1OD/gda7th4c5YMDLDB6WKVkaNoEJNHWPrbiADv3Ord034MS8+3IHvSUctfAkOLsmKi4pZt8m6fKZT5H6ReRme5TjdW3fnRXw8hB42xVeCk+7a2aTzotyqHooccGNZhKqY4isxAhaCrnwyC0KCeRUT6dYR0m2c47AtZ11RnbR1gaXQ/TXmgDdhDOd1wKY1lLzsLvo1uP2f5pjfeB1p1DCUPTcTquGfqXnWW8d7s1NtXkbrsmCnXpL8BPsS+NUYVKWQJz47ODrsbp7RloK1l7oE2GKqI3RE52amhdKVHpCUXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NrXq9sANmJGnfgim5bzEJCucEceEnyBbmFCH112mVlw=; b=ryLa0WHYESd5FZ50y9A/EtXrXImIaL3jDhIAXGoxJxEjYb0VIUjPzGgulsCkSZttZWftcr9PZYsdMgOAp/yKspoVOw5JwKEbgjtrfPQHs2SYeNJpLLAGFznJpBeMCrjhAftsCdNiLaKAtXxZwpwmld/kc4EVkLhE0KjB1st1tZhSY0NQXZB3tlo28EXd7FdEx+P2zwfbFJ7kzFR/cVomVXyeMHCn7SvU3+61E1gVMwy6kdv3861+KtflHHbbOhhYFhTXfbGY130xmo9EBCq+iry5/DABuhuikPIW2SKS+pENwNWqmc4GOhjrlN7K6C+pd0TIcejdYdqkNuumE/PnRw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 12 Jan 2023 10:14:41 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [Multiple reverts] [RFC PATCH] build: include/compat: figure out which other compat headers are needed Content-Language: en-US From: Jan Beulich To: Andrew Cooper Cc: George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Anthony Perard , "xen-devel@lists.xenproject.org" References: <20230111181703.30991-1-anthony.perard@citrix.com> <5c7ffbe4-3c19-d748-9489-9a256faebb7a@citrix.com> <750ad2e8-a5be-d9c0-846e-41bb64c195fe@suse.com> In-Reply-To: <750ad2e8-a5be-d9c0-846e-41bb64c195fe@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0050.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBAPR04MB7382:EE_ X-MS-Office365-Filtering-Correlation-Id: 8f904e25-e11a-4909-6bc1-08daf47d7144 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9Waj5xBUZWvfirsEQF7pvdNrFtDu+opzeZ6Ikrr9EIklgUubgBpvOlOQP6aAK5vEwnJjEg3Pn0p69pjZK2fvXFP+abeVBDkYyk8OsZcvqAQrLpiVIarb6/e6L71Dudl5C8ff3Sc8tUpkNpOWdspUZPQd/wi9hZjAhLDQptToSnzE+n39CTAf3kCOdI2nRfzZH2jTrpXVC6eiiRKrTI/skDB7DdJxSkiymSLhA5VhdRlDqf3g3Z1V4qNq2CfgZxRbApiR7Hk+H5oFxGNyoGIzkb6UBaPro6NE8xIIKCQOW2wZPylYdGM/76fLXpjgRet3eN2GOfJVjqb9RxI5w7bL09ZGJG6WaVdjiGrYjKV68t2f4Xpeo0BYKQ8DH7lSzngzAR9Qkc43RLy46zR02EwcWmhzI//bbaoIXn6w1tmf2EdVG0Q2VJrM9vnbXPcCub5In0Fil6c0dVXLsBbcM9Zvxr/1E2z1lU6SzBgPYo+Aba1Q6hOJ0JeX1V3WK+JTCarmPEWM4Szzaow5tH0KcWfZPDsKeAHpVpXuN5QG90Qtex0u2HjKT4EiiVWXXntCrg8bxZETxHELcyrA2kmyRxilsvio60gmjmBBsK32nmbB+eoPZsQWQCZv30+6H3W6Vgiiq4KDaiSR0uxcgzWkDlJOHUfVr7aoNDmI0Y7Pnwz+/iKGA1Fjto0tR3cDq3KRA5b7LKqs1T4xW2rVjjP/awXhTpFR0sWYYdbAEqzrcrryNNfmYuL5HgWGjWhpQVMlvEohutKnJlHHqL/Jc6x6LV4mbw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(396003)(346002)(366004)(136003)(376002)(451199015)(53546011)(6486002)(478600001)(6506007)(6666004)(186003)(6512007)(26005)(66476007)(316002)(31686004)(966005)(6916009)(4326008)(66946007)(54906003)(8676002)(2616005)(66556008)(38100700002)(83380400001)(41300700001)(5660300002)(8936002)(31696002)(86362001)(36756003)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eHdhYXlkd21JNFEwdVlRaHl5YVV3ZURwUzF6b3FnNG5kSlNRVFJQUjF1VE1X?= =?utf-8?B?SzQ1b0ZOeXF4eEtFOFc0K3ZqbkFWcUIremFmZEM1THFuZng3S2RJOUR3Y3or?= =?utf-8?B?U29CTWNoUmZzemRWa0xKa2pQak9mZ3EzNEJhNzZXSXZMQndEUVBSOFl0NXNk?= =?utf-8?B?NG4xZXFDVE14dThpS0puRld4Q0hyYm12NUFaZEd5dGFwQTN5emtNbks4RFBj?= =?utf-8?B?Yis0bm5aSnNldnE5RjRqZ2dJdDVPY0pUcThySUNSSU1TdVFKbG44RnNIN1hC?= =?utf-8?B?enlVSkR3ZXlsZWRqZnBYZEdoN1RQV3RpZ3loR3labkoxUHJQdHZ3SVFTNHJQ?= =?utf-8?B?ZkZjRHk0aVNSUnBmUEtmeElYTXlTMFUrajhkd1JqQzdPSG9lVHdoUzlaU2k3?= =?utf-8?B?dGJlQ3RRMWhYSVp3cU9ud2ErajdOUGIwTENtazlTc21YRnB1bTMwemdveHlH?= =?utf-8?B?WGxqQWlLaHRuQjNaZzlzTGlHSTMrdU1hbjR3OFdUZXlxcTQycERIdy9IN0dF?= =?utf-8?B?QUxYMDN6TzBrc1lZbjRibjd6MlF0M21JQ1ppdnJHMXhoRnhLQWpBZTZ1d1Va?= =?utf-8?B?YmxQUEFXZytTcGxMNlVqQWM5NFM0UEE5aXdPQWZiTEtDOVZuNllzcVBIUDVE?= =?utf-8?B?dDVJMm1WQTlpUGRHUXBrQnhEQnRNVks2UFhlQ05QNGovNW9lbG1EL1hJLzlB?= =?utf-8?B?ejlJN3JXYnZLZTdFNlRacnBGRFI0dUxqckdzMzlWbUJib3cvQmEwTWFaVjdz?= =?utf-8?B?clVXMkpYVStpM0E1cSt2TEo2TjFVZFZiZ1dFbnE4UjJrM0lZNUtUeStxUnBM?= =?utf-8?B?amsvRDNrR1RFU0ozWHdKNHFEV1hOcEhOQkhEcVZhb0ZyNXVFKzlaRHE5aytk?= =?utf-8?B?WXR3a0hHSW4rb0NqQjRhM1RhMlVsdjY0dVBzd2EyNmRkbnI5cnZxNFlEWHZU?= =?utf-8?B?QVR5V256Szl5Z2N2TS9FTHhteWlzT2NGOURJU0R1bGNmVCtGQjdORGtYL3NV?= =?utf-8?B?YjZuV2RVVkdmZG12aDJ2Q0JUamp4WFAvNC9YNVh3dGFCN0lCejd5K0xKeElO?= =?utf-8?B?d056c2ZFT0VpR2RCUkJ2eUdTSFk4akRmSzRoMnFmeTdZbEkwL2tPZTlYUTk4?= =?utf-8?B?Z3VXQUVDWjFkSTVLeXRDdDFzMFlBak1FS1VMWklhRHlSOVEvSGdmcVgvYWx5?= =?utf-8?B?Y1RYbFdXdjB3bVVEb3BmMFBMUFJEWFR4THdVZThjZnQvTkhXczNic3BXS2RW?= =?utf-8?B?THNEb1pHOFQ0Y3hBUE1YU1Z4bHhBSzdrZjBacVZwUkxjQ0RmVVE2NStJb2I3?= =?utf-8?B?QkhqMHlwZFNYTFpiZ2dGeWk3SHlGblFsMmhMOXkvR3JwbzBaSjZyblZ1KzZI?= =?utf-8?B?S1VLWUZsa0VjaFlJSnpNSDlhVmMzSENKTUpaR0QrN0dxeTVzZElTdi9vY011?= =?utf-8?B?NDJTdXU3NDFYSmpzNW51SXNYNzZLT0Q3azB4aENKZG52cHNPUHo2b2hUN241?= =?utf-8?B?ckc2dU1qS1IyeERjbSs0bXVLdDJEUXJpNTJNbmQ3VTcrakdhUTEvcjZDSlF4?= =?utf-8?B?NkV6Vk5uTUpiS1gvTUNlSTVXa0hVQ0k2MEZON3ZuU0RVbnBQdWtKVlkyU01m?= =?utf-8?B?azBJYlJVUEUwdVgvdGRLempyNkt4REIxY0padVBqTkV3WVNTcFp2cWI0L0FJ?= =?utf-8?B?VjBHLzV1b2F5RVhMeVZmMmJPUnFoMFdJY29TK0ZnOTZyTUdrMVkyNjhucE5x?= =?utf-8?B?eFJ0MXUveWxKc2Zvc3lsZEtuQ05KcWNmTncrL05HVFJLYTZpbGFTNGpNYWcy?= =?utf-8?B?d3pLWFd0R3hWZVZGNlBMUDhYMVlTSGJXYmZ1OHQ4bklnRzh6aTBydEpOeSty?= =?utf-8?B?NjkxbHJwNXNqV3V4YUkvYmN1dlhPVDNBaEs5dXBDcjJQSEtoVTAzVW0rcVk0?= =?utf-8?B?bENmbnlUME9LMUthYzFuajYveGd2a0tUdmZOa3oxbk5tdmt1SGxiYXpzOWN4?= =?utf-8?B?TGNpRzJuNFNWaTdNZ29oc1FFaDdVbXZBTHpGR2hCdEh3aDVMdUV4cUIwN3p4?= =?utf-8?B?RjJ0a0ZIVGxaUEgraEhxZm1sVlZPUjFKcUNFZzRPU1BPOGkyQVpJTXlNbktR?= =?utf-8?Q?vP5Ew4SkaDw8qP2ctv5hO+64J?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8f904e25-e11a-4909-6bc1-08daf47d7144 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 09:14:43.7713 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QzuHKY2TJ7VSHLQINA6QOgZbuNKmc4Jml9UP7OhxsAIdpzxQFbxx2lOAD26gZKk24PgGI+arMNCY4q41zEFuRQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7382 On 12.01.2023 08:46, Jan Beulich wrote: > On 11.01.2023 23:29, Andrew Cooper wrote: >> For posterity, >> https://gitlab.com/xen-project/people/andyhhp/xen/-/jobs/3585379553 is >> the issue in question. >> >> In file included from arch/x86/hvm/hvm.c:82: >> ./include/compat/hvm/hvm_op.h:6:10: fatal error: ../trace.h: No such >> file or directory >>     6 | #include "../trace.h" >>       |          ^~~~~~~~~~~~ >> compilation terminated. >> make[4]: *** [Rules.mk:246: arch/x86/hvm/hvm.o] Error 1 >> make[3]: *** [Rules.mk:320: arch/x86/hvm] Error 2 >> make[3]: *** Waiting for unfinished jobs.... >> >> >> All public headers use "../" relative includes for traversing the >> public/ hierarchy.  This cannot feasibly change given our "copy this >> into your project" stance, but it means the compat headers have the same >> structure under compat/. >> >> This include is supposed to be including compat/trace.h but it was >> actually picking up x86's asm/trace.h, hence the build failure now that >> I've deleted the file. >> >> This demonstrates that trying to be clever with -iquote is a mistake.  >> Nothing good can possibly come of having the <> and "" include paths >> being different.  Therefore we must revert all uses of -iquote. > > I'm afraid I can't see the connection between use of -iquote and the bug > here. In fact I think the issue was caused by CFLAGS += -I$(srctree)/arch/x86/include/asm/mach-generic CFLAGS += -I$(srctree)/arch/x86/include/asm/mach-default which allowed the compiler when seeing "../trace.h" to pick up arch/x86/include/asm/trace.h. No -iquote in sight here; all that happens is that #include "..." fall back to using -I specified paths when the file could not be found by using ""-only paths. Jan From xen-devel-bounces@lists.xenproject.org Thu Jan 12 09:17:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 09:17:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475902.737791 (Exim 4.92) (envelope-from ) id 1pFtid-0004wY-6j; Thu, 12 Jan 2023 09:17:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475902.737791; Thu, 12 Jan 2023 09:17:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFtid-0004wR-46; Thu, 12 Jan 2023 09:17:55 +0000 Received: by outflank-mailman (input) for mailman id 475902; Thu, 12 Jan 2023 09:17:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFtib-0004wL-LD for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 09:17:53 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2086.outbound.protection.outlook.com [40.107.247.86]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fcf42ad4-9259-11ed-b8d0-410ff93cb8f0; Thu, 12 Jan 2023 10:17:51 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9572.eurprd04.prod.outlook.com (2603:10a6:102:24f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Thu, 12 Jan 2023 09:17:49 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Thu, 12 Jan 2023 09:17:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fcf42ad4-9259-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jy+oa6BwyNonTn+EQbtnnvjI+/E/m1RPpYTRYt6gFnixa5VQS/rs2yVL7hcMkWXT0lvkrEXZP+m9dUVlnhm2o7J5Z12fSjet91bdt2OI3309qBcIpzqPd3TXf03Z9tRA1nFCXfxOkaBNaJXDVgfwanx496eX6sCRZn+FovQb6bIM4s4VrFQqZ4HF+B7RhgcNVxE4C10CUw/TttAf8r+0Q8tYz0YLn9PK0kXGeiq0tOOijpMm6GnnlcEIuZ/G/nT3MvmM3cWQ5V3RnEEvRnICIjakbbGKhhq4xz0+qYml8oUaaffBD1zB7L5Xx1jK2V3yjC/nBkztfE+Jw7z5dSC5ZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rcCUI5uWmX3KBPnNjDCJtytod74+7velJJnLKEUL42Y=; b=DLfvGMCPDMAd8rRKJybtkvjpXNAHYZH5iztKw67/tktcHCLAy7swa8xV0B/Rrf22nznWZbtVZ+C2HCnCzBrSHozcCyEzAhdQzKu2igtKdG4dneuoBHLy4h0u3+/hMy34ruTU9kvlOlHOOTHXuky8VaanuUruaDgYcaUSZVqohuuuy57WvQuneTxh475/BenumxU8qtIS/JkCPWT6MqviJqUwKjam2XjRX60x3NKYz2YQIBse/SHgo8OWGuM4DaeyEyKE602BuQvmJBjR2eNzmtcAwXSX6OgDGcdpzdRIN3QRlUtuqnJkNf3FIBcVftJ3Ij61zja5QvG7URaBO29hZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rcCUI5uWmX3KBPnNjDCJtytod74+7velJJnLKEUL42Y=; b=BMyok6OSAjEc5Z5VUw24mYIL/Sn80If2h/URnC2DSMbEVgFVYu+j32C/qe6hzTL7+EMlXB7dr7HioGbrj9y7AgI25GOI0PacVlumrXxBUv1V+s60Gzo/Vj7L4LfpukCWhPClAbpcVfacY4b3vNoBFvvc4WFbuR7PR5dmC57ANYuJcJENn+QORzd6OtCL2ThvlwLvK3GxEwRa+HDfRz9/GKCgU8q8her3YROAXn9bq+nBPnMKENVFKr/7HKJk8KSJxIa8wBaKtVUbLf5sqlj+c64BgOnPwbsS3wW6gqQvW1npnR4oQkg+RjhZ9Z7HKVQMGxbLmAin8svlRtfRTurriA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <992a28e1-bfcd-97ef-b3d5-c7341846b3ad@suse.com> Date: Thu, 12 Jan 2023 10:17:47 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Anthony Perard From: Jan Beulich Subject: [PATCH] include/compat: produce stubs for headers not otherwise generated Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0114.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9d::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9572:EE_ X-MS-Office365-Filtering-Correlation-Id: 28c53f94-59c5-49db-e374-08daf47de018 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bkCjyLoWUYJ+f9HxL2Nmi7u8kGYnyjO1uljzf8vbM3AsRvYGnfGgTngF+PzHwFROLsaayFzBFZ7H9FhIQG73ofNmGrh567a1fP7C7DBbta4Mo50WlSssoKpnruLyww2lYGT86Wj4H+RMKtSgsPGs7QD2eBqoW1OX+s052atZL35EE85OMmpIiztxHuT6VqTF9/HAnUCy3b2dV4Ud4mSelZF4Lxqu8n21WD/46MrIHAcvOEY1+4E1HDctV+fpJj5ULycbCSWyIOfrhewKANIzRAyMsMKnQ6HrUmyCbx+OXFrnsLOwzuJY5BiF7+hRLQ6b2zuFvTIx372RIsy3BnWwhR9EOLzvYOQT1InXqd7/dXLC1V9Jib8VIzzyO4musjgPF93s0bV3FJxWwA6jPfFFJH4Z4aRBJ+PQGa1DT6wyND5GnTplrBLhj5kgEG8PXzSjDmgk5ziSnldhqOFzJTtmenB6Gsv4Vigi1tU3ahJomfqqif+33Mk7Xaba0nqSfUM95w+OLptDGDgwu4aBaFFIzqKvyvvpEenMGoZyI1QIIouDXdCZqXal244BtUAaOl+vejznOFUWfbMpYVXdrLEB7rruGmaWtp2QGJHB1z51rTAq77noU5eugAWDzAqwxnaPL0sMYvMQEm2PPLcVee2GSHRQGs1F3HTRwGCZi1y7PFOPMrWKU+hofgS6K6YJQ85AXjDYGky1X2xoSFKyD0FssUz4LQrLON3wCPdLHn70LuJEC8Qo9K3sc9PSQIMxej85I54ruALFnvQJVS4kkTagjw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(346002)(396003)(366004)(376002)(136003)(451199015)(2906002)(31696002)(38100700002)(66556008)(8676002)(86362001)(6916009)(8936002)(5660300002)(66946007)(4326008)(66476007)(26005)(41300700001)(6512007)(186003)(2616005)(316002)(6486002)(54906003)(478600001)(6506007)(36756003)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N2QwTXprcVYyN1FUZjNXcHVhbHdwbVJhTjZkUWdDR3o0OUVISVhtTWtib0Rr?= =?utf-8?B?M3FXeGpscGZDK3JTSE1VbGdCZEg5MnMyTjVYSEFSbGdaZ3QwQU9LbnpaMnhv?= =?utf-8?B?aGIxT2dFS0tyS1Z5NktKdnZZdFdTcG9BbVlqZDRlQkhONGVWdnUvVmZTY29P?= =?utf-8?B?WkdMYmpURXFYSCtHVjNCa1NERTRDTkllcFlPU1BqbzdXUDJPVm1CelFkdGN0?= =?utf-8?B?eDdEdElCQk4xOXIxNXlncTJtOVdDbUVScFArYUN1eFZEdU9SS3dIbm1ra0oy?= =?utf-8?B?Nk5McFZjS2Y2N01SU2JRL0lLdzkyQ2FxMW9LREhqT0VyYUlGb3ZqRnJ1Y245?= =?utf-8?B?NG9NQVd2b01CVHJHdGJaZEYvM1p0ZmdMMVgxKzh6aE5XZmdycWdiaWZ3U1ZO?= =?utf-8?B?a3FjWnk4OTFCUXhtalRORk1aTHZ0NVVCcG1wRlJNRVNSRlN5SUhObGxVY2lp?= =?utf-8?B?clN3Y1RmUHRXSFN6dmMrZ1krUm02a3RyYlNwMU1pbytqY2dOVURKVmtUenIr?= =?utf-8?B?YVBmUVJZb0EzSDN3aEwrNnZVSnBjVnQxS2VQODNqakwvbTV5NzJpVDcvZkpP?= =?utf-8?B?RGJtSkRvMUdrZEhKbzJya1YwNUs5aXVuQ0d5UFdxclFsVkhVVVRWUHV4enNN?= =?utf-8?B?bVBReHBlQk5OWHc4emlGWEppaVc5RXZJaExqL3FjZXplSU85aW9CcGgzWkxl?= =?utf-8?B?bTZpNFZjbXhCMXo2Q3BlQVJaakMwSGxkdkNpc2pDTUtmVmZDRzRKcTFUU2hy?= =?utf-8?B?MCszaVJEclpjMGJIV0NPbGptRDJjSkpSNjMwRnVvWnRlWC9RWThYK0M3bTNX?= =?utf-8?B?dHZHemZmY2lveTBWQlBwZS8wSEdRb25WaHFmMndRQWFsSGdSVzJlSHg3MzlR?= =?utf-8?B?eDRoZktDaTV1NmRlRGU3aE1qUUZiOTgySVJleWJ4NklqWE5xTnV4QVdrTHk4?= =?utf-8?B?NW9XVnR3RVNRZDZvTjNxZmQ3bmRwRnZRR3cxTzM2NU9KbWZZcERIZGpkOCtj?= =?utf-8?B?RDdaR295bEMwUWlZZ3pheWIvNk5aV1ZkaEFmUkFXVkNJemJ4U2p2d2hZSDhM?= =?utf-8?B?amo3Mm1FNldzL2YzUjlpOWo1YnNrekdGaDZsZ1BuQiszVFRMWnJTbjhLM28y?= =?utf-8?B?VjgyTS9CMHNGcEFKZ0RyeFJ5YVRXVE1HMWI1ZG1VUDdkaGxnenh3aHZuUi9u?= =?utf-8?B?czk4d1YrZU5vVTh6WW5Ic2R0bUxDVjZRVGc0U0N5aE5Hc2tHbnJ6NkZhc25U?= =?utf-8?B?U1JKS0lIb2pGMFZiMDdZbmdEZ2grOFZxN1hZUlc4VjArNmlWL2NFb1dhaGZ5?= =?utf-8?B?Y28zZk9KWmJFR09weDhqMWRrMmNEanZkRFJrSTFDMklzUUlNdHpGbFlpNHdt?= =?utf-8?B?U0p2Y05qNldZU2tNRFNUVTZLZFQzUHR5Sm9SdVptZDJkdHF6OVphMHQvOTJW?= =?utf-8?B?MFFQM1BOTEhKZGhRVWlRRGJJSDR6ZURELzU0S0NheXhKaXg2WENESXl6dTZN?= =?utf-8?B?dGhycjJSQnpJME84a2YzMVA5Y2QvY01VVG8wTWhYencySThMaWJpRFlpT2sx?= =?utf-8?B?UUpyV3RHYTl5R1VmTzZkd1Vxb0RYWmQvT2xuY1JEZGFMeTFqM3NaNGdqeGJz?= =?utf-8?B?UExNbks1MWlUeGtUUHllalVZK2xMczVtZDJaUUpUYUsxczlMcXdHbHpXSksr?= =?utf-8?B?MUQ2UzVERk52TFMxTUo4a28yaFBlaitOQXY4Z0RxR1cvelpnOStpekRxNFBZ?= =?utf-8?B?RHprd1ZMZlhxakpyZGs0dGlPcWNHWTJwZndxd3RQMVVpcXc0UTZSN1JJS0Nn?= =?utf-8?B?OG5sMDJtOEhqSXV3cUJZVmxoZzhZUytsN2dhYURvQm1FREVXSjNqeHYxNXVp?= =?utf-8?B?VEd5dUY2d3FxOEgzTitkY3g0bWkyQmdJeFd0V3BpV2ptSHF5WkdzV2FMWHBL?= =?utf-8?B?WVkzYU1VN3UraHpoemNBa1IrMXBzR2hRVU1tS2hscTZnaWQ2UEJibEE3T2FJ?= =?utf-8?B?RXpuSWgrQVFGcWFvR092N3FIM1ZvUm9WczZLa1VrQXFpRmQyLzloeERWM1RV?= =?utf-8?B?dElpMW1SQ1JPZG0rR29YMlQrbEtPUWkxUXV1YWc1M1V2bWUwazJ5d0lyN1hx?= =?utf-8?Q?h8UX6FKQmIz8HmqTvZs8lxhOt?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 28c53f94-59c5-49db-e374-08daf47de018 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 09:17:49.7288 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SJiCWsfZ2/oy5AibghUp4jYd+VCWACs5td18jZW/bdWggGlTGDeovqCJ6VmimR7NC7yUErZpcuoij/C0aF9GxA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9572 Public headers can include other public headers. Such interdependencies are retained in their compat counterparts. Since some compat headers are generated only in certain configurations, the referenced headers still need to exist. The lack thereof was observed with hvm/hvm_op.h needing trace.h, where generation of the latter depends on TRACEBUFFER=y. Make empty stubs in such cases (as generating the extra headers is relatively slow and hence better to avoid). Changes to .config and incrementally (re-)building is covered by the respective .*.cmd then no longer matching the command to be used, resulting in the necessary re-creation of the (possibly stub) header. Reported-by: Andrew Cooper Signed-off-by: Jan Beulich --- There may be differing views on which commit this actually fixes, hence I'd prefer to omit a Fixes: tag here. The issue was exposed by 4c5edd2449bc ("xen: Drop $ARCH/trace.h"). --- a/xen/include/Makefile +++ b/xen/include/Makefile @@ -34,6 +34,8 @@ headers-$(CONFIG_TRACEBUFFER) += compat/ headers-$(CONFIG_XENOPROF) += compat/xenoprof.h headers-$(CONFIG_XSM_FLASK) += compat/xsm/flask_op.h +headers-n := $(filter-out $(headers-y),$(headers-n) $(headers-)) + cppflags-y := -include public/xen-compat.h -DXEN_GENERATING_COMPAT_HEADERS cppflags-$(CONFIG_X86) += -m32 @@ -43,13 +45,16 @@ public-$(CONFIG_X86) := $(wildcard $(src public-$(CONFIG_ARM) := $(wildcard $(srcdir)/public/arch-arm/*.h $(srcdir)/public/arch-arm/*/*.h) .PHONY: all -all: $(addprefix $(obj)/,$(headers-y)) +all: $(addprefix $(obj)/,$(headers-y) $(headers-n)) quiet_cmd_compat_h = GEN $@ cmd_compat_h = \ $(PYTHON) $(srctree)/tools/compat-build-header.py <$< $(patsubst $(obj)/%,%,$@) >>$@.new; \ mv -f $@.new $@ +quiet_cmd_stub_h = GEN $@ +cmd_stub_h = echo '/* empty */' >$@ + quiet_cmd_compat_i = CPP $@ cmd_compat_i = $(CPP) $(filter-out -Wa$(comma)% -include %/include/xen/config.h,$(XEN_CFLAGS)) $(cppflags-y) -o $@ $< @@ -69,6 +74,13 @@ targets += $(headers-y) $(obj)/compat/%.h: $(obj)/compat/%.i $(srctree)/tools/compat-build-header.py FORCE $(call if_changed,compat_h) +# Placeholders may be needed in case files in $(headers-y) include files we +# don't otherwise generate. Real dependencies would need spelling out explicitly, +# for them to appear in $(headers-y) instead. +targets += $(headers-n) +$(addprefix $(obj)/,$(headers-n)): FORCE + $(call if_changed,stub_h) + .PRECIOUS: $(obj)/compat/%.i targets += $(patsubst %.h, %.i, $(headers-y)) $(obj)/compat/%.i: $(obj)/compat/%.c FORCE From xen-devel-bounces@lists.xenproject.org Thu Jan 12 09:27:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 09:27:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475908.737802 (Exim 4.92) (envelope-from ) id 1pFtsA-0006TL-5T; Thu, 12 Jan 2023 09:27:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475908.737802; Thu, 12 Jan 2023 09:27:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFtsA-0006TE-2y; Thu, 12 Jan 2023 09:27:46 +0000 Received: by outflank-mailman (input) for mailman id 475908; Thu, 12 Jan 2023 09:27:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFts8-0006T8-Pv for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 09:27:44 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5bac784e-925b-11ed-b8d0-410ff93cb8f0; Thu, 12 Jan 2023 10:27:41 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5bac784e-925b-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1673515661; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=U6/b6flkA/56yqLn16cctaKGuKYvZiCEN8j0e9zxTs0=; b=WBOGQibCVaMX2mvYt2+s6AmVEw/VOnKsGXT2rrQFHvTC3zcmoK5atbb0 fFieBSUfa67v/4LDqZRTsF01DMnCcW4LmHMj3Lt9ORq0iFwsgtj9iJEzN PlV2Pleh5sWcqxjV6RE0xJo7s7tTdAyAin3KlxGMN+jzam45VpsXKv8bO w=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 92692561 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:ED6DNaAPnDhObRVW/xTjw5YqxClBgxIJ4kV8jS/XYbTApGl00WQDn zQYXmGDOPjYYDfyKdwgaYXi/EkFvsCHn4RrQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nNHuCnYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtcpvlDs15K6p4GpB5ARnDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw/+hlIUJo0 9UhMTUPQS6S2u2H5r+eVbw57igjBJGD0II3v3hhyXfSDOo8QICFSKLPjTNa9G5u3IYUR6+YP pdHL2o0BPjDS0Qn1lM/AZQinOCulz/nfidRsl69rqsr+WnDigd21dABNfKEIILbH5gLxy50o ErP9DrnEi8QNOa99gKU6WCqp8GIoRnCDdd6+LqQqacx3Qz7KnYoIAISfUu2p7++kEHWc8JSL QkY9zQjqYA29Ve3VZ/tUhugunmGsxUAHd1KHIUS8xqRw6DZ5wKYAGksTTNbbtEi8sgsSlQC1 FWEgtfoDjxHq6CORDSW8bL8hTGvPSkYK0cSaClCShEKi+QPu6lq0EiJFIw6Vvfo0JulQlkc3 gxmsgA7iaczrugt/pyi+FLovSPxqanvQysqs1C/sn2e0it1Y4usZoqN4Ffd7OpdIIvxcmRtr EToiODFsrlQUMjleDilBbxUQer3v6rt3Cj02wYHInU3y9i6F5dPl6h06So2GkpmO91sldTBM B6K4lM5CHO+0RKXgU5Lj2CZUZ9CIUvIT46NuhXogj1mPPBMmPevpn0GWKJp9zmFfLIQua8+I 4yHVs2nEGwXD69qpBLvGbhGiuB2mHBjmj2DLXwe8/hA+ePADEN5tJ9faAfeBgzHxP7sTPrpH yZ3aJLRlkQ3vBzWaSjL648DRW3m3lBiba0aX/d/L7bZSiI/QTFJNhMk6e95E2CTt/gPx7igE 7DUchMw9WcTclWceVXaMCA7M+K/NXu9xFpiVRER0Z+T8yBLSe6SAG03LvPboZFPGDRf8MNJ IronPort-HdrOrdr: A9a23:8CNqCKjwWbA2GHwT0/PUpT4t8XBQXuAji2hC6mlwRA09TyX4ra yTdZEgviMc5wx/ZJhNo7690dC7MBXhHPxOgbX5TI3CYOCOggLBRuxfBODZsl7d8kPFh4pg/J YlX69iCMDhSXhW5PyKhzVQyuxQouVvJprY4Nvj8w== X-IronPort-AV: E=Sophos;i="5.96,319,1665460800"; d="scan'208";a="92692561" Date: Thu, 12 Jan 2023 09:27:34 +0000 From: Anthony PERARD To: Jan Beulich CC: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" Subject: Re: [Multiple reverts] [RFC PATCH] build: include/compat: figure out which other compat headers are needed Message-ID: References: <20230111181703.30991-1-anthony.perard@citrix.com> <5c7ffbe4-3c19-d748-9489-9a256faebb7a@citrix.com> <750ad2e8-a5be-d9c0-846e-41bb64c195fe@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <750ad2e8-a5be-d9c0-846e-41bb64c195fe@suse.com> On Thu, Jan 12, 2023 at 08:46:23AM +0100, Jan Beulich wrote: > On 11.01.2023 23:29, Andrew Cooper wrote: > > In file included from arch/x86/hvm/hvm.c:82: > > ./include/compat/hvm/hvm_op.h:6:10: fatal error: ../trace.h: No such > > file or directory > > 6 | #include "../trace.h" > > | ^~~~~~~~~~~~ > > compilation terminated. > > make[4]: *** [Rules.mk:246: arch/x86/hvm/hvm.o] Error 1 > > make[3]: *** [Rules.mk:320: arch/x86/hvm] Error 2 > > make[3]: *** Waiting for unfinished jobs.... > > > > > > All public headers use "../" relative includes for traversing the > > public/ hierarchy. This cannot feasibly change given our "copy this > > into your project" stance, but it means the compat headers have the same > > structure under compat/. > > > > This include is supposed to be including compat/trace.h but it was > > actually picking up x86's asm/trace.h, hence the build failure now that > > I've deleted the file. > > > > This demonstrates that trying to be clever with -iquote is a mistake. > > Nothing good can possibly come of having the <> and "" include paths > > being different. Therefore we must revert all uses of -iquote. > > I'm afraid I can't see the connection between use of -iquote and the bug > here. Me neither, -iquote isn't used on that object's command line. > > But, that isn't the only bug. > > > > The real hvm_op.h legitimately includes the real trace.h, therefore the > > compat hvm_op.h legitimately includes the compat trace.h too. But > > generation of compat trace.h was made asymmetric because of 2c8fabb223. > > > > In hindsight, that's a public ABI breakage. The current configuration > > of this build of the hypervisor has no legitimate bearing on the headers > > needing to be installed to /usr/include/xen. > > > > Or put another way, it is a breakage to require Xen to have > > CONFIG_COMPAT+CONFIG_TRACEBUFFER enabled in the build simply to get the > > public API headers generated properly. > > There are no public API headers which are generated. The compat headers > are generate solely for Xen's internal purposes (and hence there's also > no public ABI breakage). Since generation is slow, avoiding to generate > ones not needed during the build is helpful. If only we could do the generation faster: https://lore.kernel.org/xen-devel/20220614162248.40278-5-anthony.perard@citrix.com/ patch which takes care of the slower part of the generation (slower at least for some compat headers). Cheers, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Jan 12 09:32:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 09:32:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475914.737814 (Exim 4.92) (envelope-from ) id 1pFtwM-0007t2-MH; Thu, 12 Jan 2023 09:32:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475914.737814; Thu, 12 Jan 2023 09:32:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFtwM-0007sv-JU; Thu, 12 Jan 2023 09:32:06 +0000 Received: by outflank-mailman (input) for mailman id 475914; Thu, 12 Jan 2023 09:32:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFtwK-0007sp-N2 for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 09:32:04 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2073.outbound.protection.outlook.com [40.107.241.73]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f8d2a825-925b-11ed-91b6-6bf2151ebd3b; Thu, 12 Jan 2023 10:32:03 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8844.eurprd04.prod.outlook.com (2603:10a6:20b:40b::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Thu, 12 Jan 2023 09:32:00 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Thu, 12 Jan 2023 09:32:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f8d2a825-925b-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Osx8vA9Bp1r+tE6tz+0TdmGvg5XsdRLiLM9wbstZX6/CGJkv10ocZPySuEks4YnaxEpbTx06gOAK4zJZU5dDRNeWbv/oPb+5pXNsM/krSnsDwQNYc8SoWK6PuFwTvQRFDhBybTKMGns4zgEC/cF/mGEKMrlzHX54wewSvgQUHIrxhf4v5UmHtU0ZQ70gvL2rI2fi7axesvCvnDnjlSVGARUh4hgPMrEwuBILVXarO4/4BHvx1t6iNMpYcXv2icqAwhidALw0VEPxi9C1V+wljFmF/+mPC1nRt21kzis3nyrN7RE7VKLKwNOqJ+FcRsBfJ/ih+IJ97pP+s8SjmFZ0hQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a9pvGAc+QyvPB3mISkj/GXnby0SbnQtT1mzcmSy/Roo=; b=U5eCemof/9B3Df1+yB+bkhRbtam2OXSweaSmtraTj3suPmtkH/D9+eEgvBWXqxPpl64piVvaZiPgeEkMBXCgVQ4P91MPZnBRkuknsfG4PbvjbHfNj5bER78+BuIgNaGdCHHJGhSRp1kbu3Pff6dg2bpU+lWDZRZei7h+YF/7FekpSUxirlOjrYTj1P7/uGLV/0DUrjQjViL+NqhIOmO1hssgfxioR5mCAhw3bND7Mc5NIx7Ob+KuPOO9VABsw9YSsfe426C75rzYMSmS3ve8etdmZK3mM/7oAgpoF0606StzQvFVWliWXXkah0iUGU3VDMvnrtZhqykYS4TBN2S2Mg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a9pvGAc+QyvPB3mISkj/GXnby0SbnQtT1mzcmSy/Roo=; b=xtIWqTdFGU3XPw+lsFwpgzqmGEu9rCFFT5YA60NeNYzLKF94ayQ2TLYLiId99sz4jWciaXfyxxXnLr4wPAJjDjfkHB2+5o9jLH7wMH5q0ecIH32/H2An2DJjV3v3YajV0Zniu8w/ggji2uV7i2oK6KKdVlmvEGpHBAuBBWWzzRfdZbR6qmVdbfAjCWxG1GQW7s379fvMh9hlkNsVM6F/zHe437BrWPHwmjKy5/minAxmGekojzvAaw3Tsq9yceqNKdL+eER/ZXYc3FemmKGa0bRz1krDADp9qe0P7jPQqNfWLiN8c5sMxrmsqNKORlTvFOZImzEa3XKmlW+IRzmIWw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <50fd3ca1-c1ca-a21e-8211-ed1ce3353555@suse.com> Date: Thu, 12 Jan 2023 10:31:58 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 7/9] x86/shadow: reduce effort of hash calculation Content-Language: en-US To: Andrew Cooper Cc: Wei Liu , Roger Pau Monne , "Tim (Xen.org)" , George Dunlap , "xen-devel@lists.xenproject.org" References: <4785b34b-2672-e3a8-8096-df1365b6b7b8@suse.com> <28488645-1cf7-cb9b-ca03-f060f7947156@citrix.com> From: Jan Beulich In-Reply-To: <28488645-1cf7-cb9b-ca03-f060f7947156@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0146.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:98::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8844:EE_ X-MS-Office365-Filtering-Correlation-Id: 5a9a9789-1d0f-4309-3f66-08daf47fdafe X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: O/wwbJFK3v9k1U7JCriZLHB0BZxvkbTZmJymKB7nKfJ3EMTZXGyjPAZbzGgrA4ePmkDWI2CRlmNnwoClKoAa/7ps3GXQXfiEkj3moF5zRpy7oicGV+ctE18h3XE2gZgz5M4A8p5DBeLyBV3uLps3qXJV5tu9qNRDb9BmykBLwWeYTyIWJGlgkY/LtBbV5QLuQt0Uq+xQDerT0NjvCnYluS93/OyDRtTAHsdT9iE4cRtzrAVDnjcIKuN/b0+M5iqy0O+wBwQKGv8hHBZgcactFT4IiSpsSRg/LixYv3xgvvc9LARetdpkrZpntzTyKHleQMqOk0HXxNVLomD38ux0q/pZqiai0q42/Tfg8o6/RoZAQRdE7lMlPdEfAN84Sa5MvNIW4KH4iK+CR90d5VM+zpx1ZiqHGkUr0opt2JmPLg1tv3q75iBtSyq4PCipU++U4g6PpClk8SZ9PzJ6ZNklhqBzeus9S+1eTG2TnL4VduHu01h49FNCz3GzStYS7iTlcfQ/JZR4e87oVX61TF4yCMnbuKxTeYBtSV7Ki551MjUqiAbbSkIk7bzaAbGCyDPahzKfbXwpU6fEIoqu/oRQ75XjzgFNn0KCd5xuUQIDZGtvve4Kv8QSSOEzJIM29Bfgc1O/+/gi5h1TV3acUMn5lUsx4FVMJxRmrBkHHwJfF9FzuLYkMnMwoFR+kMvPq8pIoqC6QL63nP/rt0busSl69qUEkdmGHAOlHKCzDwCvuTI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(376002)(366004)(136003)(39860400002)(346002)(451199015)(36756003)(2906002)(5660300002)(8936002)(41300700001)(31696002)(66556008)(86362001)(66946007)(54906003)(38100700002)(31686004)(6506007)(8676002)(53546011)(6486002)(186003)(316002)(478600001)(26005)(4326008)(6512007)(2616005)(66476007)(6916009)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TnhhQk0yeC9CZDdVOEdhSzBrUUNwSTFuUG5YS3JsUE5BalFLcmdGMjFsMUZv?= =?utf-8?B?V0pWZ0RBNWpmbTBzNjhJVlAyUmxmV0Jwc1JKRGJydGQ1RTZGUDR5L2VySjVk?= =?utf-8?B?L1FtalNSclYwZEovUEhZcHhJRkw5NHNET21yVVFJWHJncTUyOTVYaHRsU2lr?= =?utf-8?B?Z0huTDlSVVJQNDg3cjl6dkUybXgrdXFjQTVKK3FtOWFjbmR6bUZGR1RWT1Rh?= =?utf-8?B?QWxzWFdFSmVrZ0tobHdieVVWQWlUZFgzNHk4dWFrUnBQUnc1NndTYWpoVXN3?= =?utf-8?B?Y3dmNStKY1VOSWNvcEdFNGR4Vm04OERBLzdtaUpqZ2RRU2poTzJKb2VIN0Qr?= =?utf-8?B?ZGRYRmxNNjRhWG1vRnlqZldZVURhWTBKMzdQKzJIWHd5OXVoRGRHTGpZMEtG?= =?utf-8?B?VU00c3BFMmh1UFdvYW5RcU9NS3UraVVlek1HYkE5cGt4OW9Nbm1VckxpZkI1?= =?utf-8?B?Sm82K2ZoZmQxMzRDMTgvbGJoMnZVT2FDV3pjU1RWd1Z3Sjhabm5lNTM3dlcx?= =?utf-8?B?VDVwNjlPemhObXg2ZVljNlRRU0tUeEVOeERGTkJSdHlLUWwraVVvRWQ4QWxo?= =?utf-8?B?MFBaY2tEMmg2YzMyS3VpYTA0S01DRzdzcTRibkFJbkQrVWh0Z3hHTHlGSnRI?= =?utf-8?B?bXFKQXNheHRjZWd3amd3RUU5NUxlNFh0cjNRMGJDSVR5cXJDUEJYaGVpWHEv?= =?utf-8?B?d2xZbE1VTVdnZ2Q3Z1pFMFJ3cWFIaFk2YUF1akdYU3JhM0VRaE1Mc1ltaU5J?= =?utf-8?B?UkJQazZEN2RNcWxQSjdkcHlCUGFBc2JCSDlJN1lwY0k1YmZkVU1Uc21xd25T?= =?utf-8?B?a1Vzdzk3b1FHQ1dCSzhId052M0g0cGJvUTlPck1DV2xqdVcreGRVdTdrK2ZG?= =?utf-8?B?SHp2eEpkVVNMS3hpWVlpSEJGWGxtZmRlSzM2OHJLeGljVVVOWi9FVkFlZDlD?= =?utf-8?B?SDF3RDdPZ2hueGNFZDJpSVRiQXg5R2R4VTVTMkZLeWg1R3V5QUpHZldLamh0?= =?utf-8?B?ZjBTZHdaUTJXNFlHbDFNMFNLY1FuU1RjTlRsVHVXUXk0K3AreTVsazdIMkU4?= =?utf-8?B?aXQ0N2dscXhKRFUrVXBaclJ2dnIyMDNLd1VNaGE2YWNBOW13aTV4aG5RakxO?= =?utf-8?B?ZjdUbUgyRmd5VUd2c1lNN3g2cTFibkIxbDZXWWhwSWs1SFBCVFhiMFc5c0dk?= =?utf-8?B?TmpKUC9PejRqS091aldvbmROT0RTN1BaSUtocTFoalBnemVLYlAwK1NibmtI?= =?utf-8?B?Sk1UUGRlYUc0ZW55L3lKdGh2bWs0ZkE5WVIxUUFVYkJtR2NYSVlkbXJka1Qr?= =?utf-8?B?MzZaUG5ubnRSTXJKVEpyNUtGR0JHNjZ5T3hjYVROZ0ZPOTNVOHVNR3ZwZ0U4?= =?utf-8?B?NVFZV2ZnY3hIY2NJZmcyMGhSTzFXTnI3NGdIelhNWk9VZ2UwWnhjaVZrbFZu?= =?utf-8?B?WWdOSHFpWHp3RmNUU2toRFY5YnBsdWVoTC9ZY3gvZEExRUxUdzhWVkc0UUor?= =?utf-8?B?TS9hRlJtVnpJLzZveEI5bUcyVW5LSXBxM2VlRnJqTDJjdVVRTndnT05idUNa?= =?utf-8?B?R0xiQmkxMUx0dW5GRGVCTlVDazEzcyt0OExEekNqbitPb0QrTUQ0M2laOGc2?= =?utf-8?B?U3BtT3FHUytHWkphN1daNmtMMFBQSWZ1TEc4ZjVhZFI5OWVnalZwQS9HZWV6?= =?utf-8?B?Zjk4SG56YXZGQW9CRFVjd3pNSnl6bHNhelJEd0YyNjVPMzc2RllTbjFLUXJL?= =?utf-8?B?d0xIZkEyTkozYjFQSUJpS3RUYW8yVEx5M1RTRURZTTJoV1VOTnlYRnc1SHFE?= =?utf-8?B?NEczc0t0aDFUcWNrVVJqaEZNVCttM1YyZzhXYkdBLzB4Y0lrN3lRdy80ZS9W?= =?utf-8?B?ZUozN2dvSWNlR1ZMcWNuK0piMXNpNVRqK0ErekVOTm44UzVuc2REbXhQLzNa?= =?utf-8?B?UHlTTkFDL25tWUZrMUQ3WkkxNTU4b2tOelhJMUltT1Q4cGtocC9la1FwNUdH?= =?utf-8?B?VjFxM1Rjd1JJZlgzYUJiRFBrRDExSHpTYTFmUldnWHVWcGdxQlVRVzZFajBD?= =?utf-8?B?d3pxQjZKaDRyRGkwN2dJWUVycWEyY3JBWElJVDFyNjdqOEVnR2wzNUVkVEVl?= =?utf-8?Q?8HYlddyd3xC7vjvmmxCEajNIu?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5a9a9789-1d0f-4309-3f66-08daf47fdafe X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 09:32:00.0184 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vpVy93hjgUXwJFNGQ+vGTHM1zU6pPlOzvZXLWjnrioqm3o8RUSpZ0iAj5paKlmMJom24CzP5NPuWK4/nV+Tf1Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8844 On 12.01.2023 01:02, Andrew Cooper wrote: > On 11/01/2023 1:56 pm, Jan Beulich wrote: >> The "n" input is a GFN/MFN value and hence bounded by the physical >> address bits in use on a system. The hash quality won't improve by also >> including the upper always-zero bits in the calculation. To keep things >> as compile-time-constant as they were before, use PADDR_BITS (not >> paddr_bits) for loop bounding. This reduces loop iterations from 8 to 5. >> >> While there also drop the unnecessary conversion to an array of unsigned >> char, moving the value off the stack altogether (at least with >> optimization enabled). > > I'm not sure this final bit in brackets is relevant.  It wouldn't be on > the stack without optimisations either, because ABI-wise, it will be in > %rsi. Without optimization whether an inline function is actually inlined is unclear. When it is, what register (or stack slot) an argument is in is simply unknown. When it is made an out-of-line function, a compiler may very well spill register arguments to the stack first thing, just to make all arguments (whatsoever, i.e. not just in this function) be consistently in memory. >> Signed-off-by: Jan Beulich > > Reviewed-by: Andrew Cooper Thanks. Jan From xen-devel-bounces@lists.xenproject.org Thu Jan 12 09:33:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 09:33:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475923.737830 (Exim 4.92) (envelope-from ) id 1pFty4-00005L-7Y; Thu, 12 Jan 2023 09:33:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475923.737830; Thu, 12 Jan 2023 09:33:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFty4-00005E-2V; Thu, 12 Jan 2023 09:33:52 +0000 Received: by outflank-mailman (input) for mailman id 475923; Thu, 12 Jan 2023 09:33:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFty3-00004z-AD; Thu, 12 Jan 2023 09:33:51 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFty3-0003Xf-7u; Thu, 12 Jan 2023 09:33:51 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFty2-0001K9-PI; Thu, 12 Jan 2023 09:33:50 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pFty2-0000pF-OS; Thu, 12 Jan 2023 09:33:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=E3RXL/6TrD11IsyiEocgKbqu+iTmyClO7DmWtePjqsY=; b=oz/HX5csncIMPV72EvRsurYRwD GHa7hJf6QrrxUH0LWjYSUCWClml1DDJnxWLkXbrhJNC65aW4cikNfAG0fEjhPbRRmh6uostrjEAFJ 61HiNznc3C5vuQlnu6fvQ28vD8NQ/ULti2xaTbhshzzai3s8lYp2y3+NBIX562xXSDFY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 175734: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-freebsd10-i386:guest-start/freebsd.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=fd42170b152b19ff12121f3b63674e882c087849 X-Osstest-Versions-That: xen=e66d450b6e0ffec635639df993ab43ce28b3383f From: osstest service owner Date: Thu, 12 Jan 2023 09:33:50 +0000 flight 175734 xen-unstable real [real] flight 175738 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/175734/ http://logs.test-lab.xenproject.org/osstest/logs/175738/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-freebsd10-i386 21 guest-start/freebsd.repeat fail pass in 175738-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 175726 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 175726 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175726 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175726 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 175726 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175726 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 175726 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 175726 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 175726 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 175726 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175726 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 175726 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen fd42170b152b19ff12121f3b63674e882c087849 baseline version: xen e66d450b6e0ffec635639df993ab43ce28b3383f Last test of basis 175726 2023-01-11 16:10:12 Z 0 days Testing same since 175734 2023-01-12 01:53:30 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alistair Francis Andrew Cooper Julien Grall jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git e66d450b6e..fd42170b15 fd42170b152b19ff12121f3b63674e882c087849 -> master From xen-devel-bounces@lists.xenproject.org Thu Jan 12 09:37:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 09:37:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475932.737840 (Exim 4.92) (envelope-from ) id 1pFu1i-0000oQ-Qa; Thu, 12 Jan 2023 09:37:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475932.737840; Thu, 12 Jan 2023 09:37:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFu1i-0000oJ-Nq; Thu, 12 Jan 2023 09:37:38 +0000 Received: by outflank-mailman (input) for mailman id 475932; Thu, 12 Jan 2023 09:37:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFu1h-0000oD-CY for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 09:37:37 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on2055.outbound.protection.outlook.com [40.107.14.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id be8e1c19-925c-11ed-b8d0-410ff93cb8f0; Thu, 12 Jan 2023 10:37:35 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU0PR04MB9669.eurprd04.prod.outlook.com (2603:10a6:10:316::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Thu, 12 Jan 2023 09:37:33 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Thu, 12 Jan 2023 09:37:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: be8e1c19-925c-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JzR31wFCldoDt6e3WBOr51kRz2ZInlq8C/vsEUyEmkgxDSleoq5cVK+fh0qLFMMwPQg/xz+f9AbWJNXRnsgUz0btrZ92sh/dEVZSLtvKCbT8o1F2xDV/LLszwTBeqq//sAofccfmTqYjthtB4pNTpaYSo3E71bnAQZpykhN88xGZ103sgTwUDdG82mJaX805lNpLJaM0IM1Zoey/3CFX0SdOWBbeJzVmcqFKQ43+ASZPJDG9BDkyQszFQvkBRasVzmHTU8Y3wG1yjeAQCdRPTDqHzxGhDKnWMtlgeoaCsRyBbi36oC5Csk2U60RhRdEtt1h17iKbtbhICK/LwztDYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+qval3siV5ZTKNWLhov1cDgk4NvpyHzDD1M+ttv7kF4=; b=gA7Gbjxf0pte2BFDicWtKQD9o6gAlgFet1bQWJhlvDTmICr2AXGaEQuBlr/168VGF7G/iasi8Wh6Nf5Od3Svty1YihnTW79xieCmAaZ9gQVaf7gAjKF1q3eV9l4y8Jva2JlMA9LB8O0dhcaWtvCIKWGxXOwudOqcXsZ+7S1jlhN7g6K18GXGhy5eb9ARXPKLnJEstXpH1DsuC3KZJVeRjq9z8IK8uQhFt7m0Gv+tFb7Snj5Z0CzHkwssF0rf+eS66hokUUaZVuG5gAbevUIPHPOorDth3G0ImtlN0iU3MzJyDxmL2hHxAv5CfY+CJYnyjwn+Z233vzf0R04O9iOX3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+qval3siV5ZTKNWLhov1cDgk4NvpyHzDD1M+ttv7kF4=; b=KSnrUmtf2TcXsM6WMWp2TZGsNlU+w5vjMbr+4jJ56Goj62w8qVEp33xTAtw0y1cU8kvQXsBeBZ0pmUD9lDlAcmbg3LNuxy7e0+H8pBadUqXp4Hlt6P8dsLQNR39/7nMPx4R9OZCvSSWT3Wghbur4WqzygTYKDuw/UGAuBVW5B4HrcK75zofGLUI5ghjjRV5kP9VLxjg1uvSyIGX3OWNYWdW1Uhhaai4oJwFOh49dl5n2DH9tlo7VpIpngdZ0RdrZeKOmEHRdRMPFHi4F9NuM2Wh+TAFYKdlMJwSBw0b1OhYLCUVqhFHd4Bv63v49bmdnx+V6TNQPqgk5L+8yxdgQZA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <958e4f6e-9a2d-850b-3663-40c777932e03@suse.com> Date: Thu, 12 Jan 2023 10:37:30 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 8/9] x86/shadow: call sh_detach_old_tables() directly Content-Language: en-US To: Andrew Cooper Cc: Wei Liu , Roger Pau Monne , "Tim (Xen.org)" , George Dunlap , "xen-devel@lists.xenproject.org" References: <8ed7a628-f64e-5512-efdb-4116a7b88a1d@suse.com> <722642fa-4eb0-930a-9755-f7780da65eec@citrix.com> From: Jan Beulich In-Reply-To: <722642fa-4eb0-930a-9755-f7780da65eec@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0119.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU0PR04MB9669:EE_ X-MS-Office365-Filtering-Correlation-Id: c49402e0-6ea5-4b96-c857-08daf480a176 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VOS00CKJnur2deSa2gXQRQFQEa0vFl1bHXnzo8rox60it/3KzoA1dCkJJWrzx+tMrKCp0fY18jDzijIPuCSclFnJe4XuaWsNbfoXT/Mv3NSo0z2SUA68O++xwpsJU6TxN+b3F+YuS7DWWa3jrSXerE+9vf4FV5L1nGzgrXvrltbZguFfRJPbbiF9VqcEhuVTRsCqNKW1UUSk0V/VUUx7cOxBWZpqlRfxWVT82wQ9dok+UCHH9l9eM7J13T8DsN1PyZjzA858AomaojsfHsoE60l9TS2Wx0CaoHGjohU7Z8Ay045TAAtQB6v9HvuTgRjDXcvvMvgdaK7fBE6SUsL6yW7++5FdN9VzjO+JyIcHZZo2MEll0OgE72bgkIjfgNxkDUeMFHYgCvctqlzS8qKB5gjJxnQPCDurCZzq1UGqxqFiCE/mbeFig2WlxY7ilogUPMMde3tnOf1iPLatn4v2bHxbXagG3m9FWxL8aKLEyumRj+iEN8+SGtAC6N1oH1O/UYLj0j/SaQm0/u/D5Vdw3eaTCCfv7fEJykp9hVtIO7RzEtY67cxXAlFI68LW+3EAotQVvscewX1vKtcycwM+4N8SDIqMuCUWegRV0E/LWsPcp/bfipMU2XW7MrawFwf5l+hK9LbwXxIG5tRl1ipnOGh/SLVrtuSdY45aPFwbTJMuHpB/wxBhmifg+p9xo6XJGuI+pJ/Po6RCsAlo1ldgKIKaIphliKVT9efr5U3oN0Q= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(136003)(346002)(396003)(376002)(39860400002)(451199015)(8676002)(66946007)(31686004)(41300700001)(2906002)(8936002)(36756003)(5660300002)(6916009)(66476007)(316002)(66556008)(6512007)(54906003)(478600001)(6486002)(53546011)(6506007)(186003)(26005)(4326008)(2616005)(31696002)(86362001)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N3ZDcnNHY011ajJjeHZWTXR1eXBVMSs1akpEVmZyZkE2aGdJWFFSZFNjbW5W?= =?utf-8?B?eVpLZmpyUWUra2JtQjJxZkZmVElIQVk5bzIyRXRMYXhzdFlicFVxTGt2MlU0?= =?utf-8?B?TU10Z2xLVHZXdlpLZDlTVkFGVGNFQjhRcnc0ZnJCYXU2N3BzNU1oNXFNYlor?= =?utf-8?B?RVdoVk0zMlhzZEVCRjJ6SklGWGYrMGNvcHc5aG5FRXFrbThIZ1lTQ0tkWHZ4?= =?utf-8?B?U0RJOVA1V0dDT2xEVGF4Kyt2QkIySjFyblpBbDRreUYxeS95V0xOTXZhLy9w?= =?utf-8?B?YXRPMU91ZDVNb1Z1WjgvNjB0aFRRRVNHdTdDbFZXUnRxRVRJYUJMVXNxR0pu?= =?utf-8?B?cU5UcmhNaUR3Vy9LRVBneUhRd0VWUldzVUwzMkFnS2p0cjBUc2Q5TmZHa0l0?= =?utf-8?B?NU9rbCtCNTdvalVVYTFJbE93OElkNnBxcTRxaHNndTZWeHYxa3FZVGlFRnF5?= =?utf-8?B?dTd5UTVOU2dyK1JBRWwyaWZWTkowY3pPMVZVY0l3MlAvZm9id1A2eGtmdEo1?= =?utf-8?B?WVk3aThkbVNXT2NnaGtvRHl5RThTekNDdXBmN2RCY3VSNXdvWmJWNWxXK2xy?= =?utf-8?B?K1NRelVNU09lRS9icmVVOU52bStIejdtTHlqbDRCak1WV0ZWdHgvS1ZqVFRE?= =?utf-8?B?L2VQMzRySFJVa3M5QTR0ekJvemdVbTlBZTdYZTg1VFo0QW50aFBjb05qZ0Rh?= =?utf-8?B?UVpJSDZ5TWxEWlZsdnlTTU9mZkxPcy9jQ2FaODU3dHhCOUczYm1mcEdpWG1F?= =?utf-8?B?TC9IWVh3T0k3ZHBYUHREV3BINWVFYWFmSjJsQ2o2bUJSRDhPVU5BZSs3OEVQ?= =?utf-8?B?SVlkODhUVG0xeWoyb3FOaDlBQ2ZPeVVpb3g1Kzl2Nm8rbWRxcDNWYzdaSVlo?= =?utf-8?B?SFhSUVZldWdkLzkvTU5LUkhBQUFGa2dQTGlRdE9BdmJPS0ZPaWpzYUs0eG04?= =?utf-8?B?aWtBckhHaWZHMUJydkRPSnhtdWs5cEU3WjE0a2hZOThPRmhrVi9TdWpOcFpR?= =?utf-8?B?UEZiQkV0NlhRY3JVd1dQYUVXL25INHJsVEUzZGVKaXUwNmlOalFPR3dZb21B?= =?utf-8?B?YW1MN1JQWEI0Nnl5VDB0OFVNSzB2Mmo0M015ZThKSURVbUVXTFdXemNwNU1P?= =?utf-8?B?ZDcrdG9hd2JPZFRueUlZbWZNb0VxdlFoMUZxY1BKNHBOaHMzam9KL1RuK1BE?= =?utf-8?B?T0ExT29Gd2VhMnMvYU9aRVVVdXZpVVlUUElwa2RhUFAvVDRyQmhBaVh2cVF5?= =?utf-8?B?V0Z3VDNkSlYrRG8yOWhiNmZad21xOVZGenpzLzBoelc4MFAycU9MTENDc2Zo?= =?utf-8?B?QSs5c2dET3pQWGZ2QjdiZGxPK3lkdldNMUVoNzRJeVVXMm9oWEJQSzFyZDdu?= =?utf-8?B?L3REYmFPRDJkMUNSNkpEdG1FUXFOK0ZVK0RMRnc0STQ5bVUwRk5WVmdNeDdl?= =?utf-8?B?cU1BZ0MvdWxSTjJZaXlDVmozUTNoSklYMk00YlBMenZPeVlNdDBjay8vUGxU?= =?utf-8?B?aXQzb0JBMVJjSDZWL2dndGRCOHloczhmcjlZOXRldzVHTFVOY1IvbWZlekJj?= =?utf-8?B?MmJ4ekhwUnFkQUQ3QmhEU2VrWEROUEhQUTlTemxBNStXYzhab2JBU1c3aVJU?= =?utf-8?B?S01tcXZJZTk2SnYxRndCc1RFajdkemZWVVQweFpvZnhSaUM1dHhJbTVOQzB0?= =?utf-8?B?bjJjVUtuWDVDTnBQQkl1MUlJUExwS1VDRGVobitpSFN4ZGwvdDdrb3UvODdj?= =?utf-8?B?Q1JmMWh3VWkxVmc5Wk5TZS9tRzZNTE11aDF5dmV1c3h4U01EbGhBRDlHSFFW?= =?utf-8?B?Rm93blJHTzNRNVJqdUg2WGVMS1Vmc0QzbHgxSkMrZUhaSTF6dkRkQ2ZQV09t?= =?utf-8?B?eTNNdVQyanJRNWpvNHc4ekVvajdTMXFoL2FCcERhMmlYU3Vna0pOTHdpdWtp?= =?utf-8?B?YzExazI0dk5PUGlMbStzRVBmUnEzZzJQL0ptZmd1MGNQSC8xNzl0V2VzNXp1?= =?utf-8?B?WXZKaTRhVzdBSmhCWGsxOWZVbHZ1a3Q5SE05M3g4NzNRKzQ2OTF0TFU3dnlt?= =?utf-8?B?c2NFdjNtZGZMWGZubytmcTllNjBmYWMwK1JPdzNqYnpZSFV1WXNSbFRvalVs?= =?utf-8?Q?bsGwVEWhCHgleRaqbwJEPsP8u?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c49402e0-6ea5-4b96-c857-08daf480a176 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 09:37:33.0597 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gt2Fk5dCX8UWvoUsfz24FV6A4/u+hJ2pplwAT8S/oN7zrZ9o1jAAHlIla/O3NQrSAytz1qoEZJ62nCL2V+1XfQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9669 On 12.01.2023 00:56, Andrew Cooper wrote: > On 11/01/2023 1:57 pm, Jan Beulich wrote: >> --- a/xen/arch/x86/mm/shadow/common.c >> +++ b/xen/arch/x86/mm/shadow/common.c >> @@ -2264,6 +2264,29 @@ void shadow_prepare_page_type_change(str >> shadow_remove_all_shadows(d, page_to_mfn(page)); >> } >> >> +/* >> + * Removes v->arch.paging.shadow.shadow_table[]. >> + * Does all appropriate management/bookkeeping/refcounting/etc... >> + */ >> +static void sh_detach_old_tables(struct vcpu *v) >> +{ >> + struct domain *d = v->domain; >> + unsigned int i; >> + >> + //// >> + //// vcpu->arch.paging.shadow.shadow_table[] >> + //// > > Honestly, I don't see what the point of this comment is at all.  I'd > suggest just dropping it as you move the function, which avoids the need > to debate over C++ comments. As said in the remark, this style of comments is used elsewhere as well, to indicate what data structure a certain piece of code in a function is updating. Earlier on the function here also played with vcpu->arch.paging.shadow.guest_vtable, at which point having such comments was certainly not entirely useless. > Preferably with this done, Acked-by: Andrew Cooper > Thanks. I guess I'll drop it then; should the function become more involved again, we could clearly resurrect comments in whatever shape is then deemed best. Jan From xen-devel-bounces@lists.xenproject.org Thu Jan 12 09:47:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 09:47:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475938.737851 (Exim 4.92) (envelope-from ) id 1pFuBE-0002Je-NP; Thu, 12 Jan 2023 09:47:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475938.737851; Thu, 12 Jan 2023 09:47:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFuBE-0002JX-Ke; Thu, 12 Jan 2023 09:47:28 +0000 Received: by outflank-mailman (input) for mailman id 475938; Thu, 12 Jan 2023 09:47:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFuBE-0002JR-2L for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 09:47:28 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2066.outbound.protection.outlook.com [40.107.6.66]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1ed35518-925e-11ed-b8d0-410ff93cb8f0; Thu, 12 Jan 2023 10:47:26 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB9354.eurprd04.prod.outlook.com (2603:10a6:10:36c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Thu, 12 Jan 2023 09:47:23 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Thu, 12 Jan 2023 09:47:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1ed35518-925e-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U3kU3/K17peqCx/MgJ7ZCFWAjEM+gleocgwPRMQS8WgxMZgR8WDXu+VGKxRQCJbqcmK7Zjzco3KcNGmN9vwpgsCiujqs6/wz1yMSYUoilw5Md6Ovi0UzPC9deIfWJUVD2eCzNjjUg0C8OBHtp5OnsOc2ITnhHCKWJ9MMsStbHNg7VyrVH8xp0yM6XXY0oxTpdQd3RxvZvV7rmne+8MiHykGlPP08Fcks7lWjIzFjIqoCzrr+SlHSANwFPDF4ZV+QO/2A/qekOHUWM7hQJXaiiIiBFgAnfzVSpzHOgKuw5qlBGDOxolJq7OUZb3mdU+YGn9vszEPE45j3tx5ni1PxrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a+eX77cSMdawL4nZwmXFSn5kJuDxSijDU8TSMLh4aOU=; b=Vj2T75Y6kJC8vFFoWvW1lPJX8fARo2Gwy46zGK7ECriCfIw+btZzog4YY1ar0dOuK+loyDnucw/7rc/SXieSdigHiXP6/AJ9SvBEKz07ff7anp9D1Iwx26VIgR7XUyDCGKdC7uenOafgYLvB6CjEpuv9kifpkA3wo219QTi/B+pHsZpNMXH41qBfYwxJ+rb0LJW0bRVwBq3FRsuLwsJZ+Q22Z5thoBLBs/F1+Ov5ZEklGz5sfpduQoFX6jZDnUC5uSEAJnoAIQqgGOJ5qEMu/LMR+5QCQZ83km4J9GXme/j27RX1FSPCryZ1Ic2ln1JWQZfh0fSeiOTbJUBFwBtpDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a+eX77cSMdawL4nZwmXFSn5kJuDxSijDU8TSMLh4aOU=; b=TSRRFsi7ywMB8QbrvVw9MTI78UT+01Rg+tAe1ceFaDK2KpoiQGqwqUfJzl7ApICnHWvpoWXsvVzDIKOiRnMDLPck1TfGBfFvBFBz49974a3JTw3pTCEsY0xIFoZyGtBW6547dJ93mHvU9KVtEZc8Eh4O+azT1J2mUcNbB0veh6Sxt0Z9lUXXf8JdLzLG0RjsZLhKesL//qr1DiACgek3z72yK4NdeF7AG0yDqljsb3DD3gcg5zH5jjWq6GFBpsH7TXiN7evLMVZh57+lWUIVZpIaC2b3hNBrPmrs/HX/s2Ejxg3uLXUuD8tiqMuYhYI/MRkkvq/iFdporpSQYP5qWA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 12 Jan 2023 10:47:22 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 9/9] x86/shadow: harden shadow_size() Content-Language: en-US To: Andrew Cooper Cc: Wei Liu , Roger Pau Monne , "Tim (Xen.org)" , George Dunlap , "xen-devel@lists.xenproject.org" References: <9bea51eb-4fbd-b061-52d7-c6c234d060a1@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0148.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:98::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB9354:EE_ X-MS-Office365-Filtering-Correlation-Id: 98776e95-58f4-4b2a-5320-08daf482018e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: i8U4sVuMCz19Juq6VjpHen1TNAHw/QDPgdKb0tVrFWL/fluvKV3plclQVSr1Oc/m2p1EZSfWnmFXuPJB+/i3docE1MyNB/m+FKAMI66BMFTWg/gzXjEHVt4hD6+FKlB4GglLHBgoB/l0C1ihJniUtL7PgxP6Y12Qt5RJCwv5bNPPK1HZFhap1CuLL90s8c7W6iOXsEqHwAviwSgFt+c9L7K3S5sHIoUenT5Ns4EB3uIz9hpOZf0o24Cjxdta98iUABgcFaM9p4canR7+TemKV2Ks22zXnFaSoVSdmDVlCLjZuqFPxPVA8CdrB7Sk+iG7aOTxFX3bQHQ22UTZwS9Vti3a+RI/1jblvFafbjDW/Vdn0GZ6dTh0UHRW9pS7ong+meUVc2Rp4Qzg7+Uwrp25RcWBm2Tk+eodqnMjEMxieZ5CVlA4GEAxVENft2H6tbjmEJiiSEcA9aL0dGShsfgIAOJMI3lFZJAPbDjeeeV6U6js6Ald0nIbdycJ9JieNDpvW/qVvIxShfkL0g4mqM68t94J2Gv4OT04f6hQSPmy8IlvDNomA7v9+euceZ49GdIaZlOwvmFlMg1pkEHSrkzJYUuuK6zACw2mR0Whxn+ZILTMbigyuI1lJGEGF25a1bVhJbS11UagkOF84ntNmKkiok2sK7zWRPuzfbBcp41AwXLA6r6juWz3GWn/uj5oxxM4x0M4pyVlghsOnvUi3r7efVXr7rbdxLVssy6AoOieiqM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(376002)(346002)(366004)(396003)(39860400002)(451199015)(8936002)(26005)(5660300002)(2906002)(41300700001)(66556008)(4326008)(316002)(8676002)(6916009)(66946007)(66476007)(54906003)(6512007)(38100700002)(2616005)(31686004)(86362001)(186003)(31696002)(83380400001)(53546011)(36756003)(6506007)(478600001)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U2F6dDZVbStpK1hhY2VoM0VubnFRTnZiNVpUNGhxM1BFcGxDSjZ1Njh4Y1Bu?= =?utf-8?B?eFBZZXZ4S0EwelhXWWVBc3hXaEtQQ3BwWWJyMUlJczVyZ3FvcktVbzkxUkJl?= =?utf-8?B?QzZhZWRZNWRER2FHb3pnZzU3RzlqWVIwS2NCbFRYUTE5ZWJYNjNBN043QUdD?= =?utf-8?B?ZWs2K21sNi9rZGFTSjRFVWc5SVZrTnJJdmFvQVZCMFVWR2ZuNDNlNlBNOHZT?= =?utf-8?B?bm9nUmZxdklscDVVa2sxd2FuUmlWZ3VaWTBiaFc3c0NtUS9oVnZKaUM4bWVG?= =?utf-8?B?djgzM1dSWHFHYTFOdVNmb2tBUDAxUXNrRGJQUGFzcncxdnV2Nk0vKzh6bnpG?= =?utf-8?B?V2tQODdIOEpQMzJsNmV5d210My8rcU9TOFhqLzl1Vzh1UnFxRjEwbS9TNTZB?= =?utf-8?B?dkpja3BxUDhUQ2lBVUFmMUVqNEdQM0RBbHVrMGxaeTNQdTlSZzFjTG5rTUtO?= =?utf-8?B?aGxiQytDQStqMGtSMWxDbThUbUJhQjdrczRmb2VBOW9FMnJ6bzFaQlRRRTl0?= =?utf-8?B?MGxVSFAyMFNYeFhzUEsrR0crVGJtTVVyY0pGcTl1dmM4a1luMmdYMEJKaW8v?= =?utf-8?B?RzEwYTFyNlppLzdpREtNcDNrSU5OWnF3VXhBSmRrc0YwT0d4MmdUT01na3Z1?= =?utf-8?B?czRaZ1JaSndieVJwdmdnenZDL0t3UGo3OTlGM0prcHhHdzBRVzN3ZnowSFVS?= =?utf-8?B?NHdDSVhaRTZyOUxDWXgzbDg2ZkNqdXArZm5nNXU1aFFUSGZyeWh3ZkdTUnZk?= =?utf-8?B?NmRUMEhRTFJMc3ZocHQxTnh0QTA0OXR2bGIrN3ZPcXo4WEowcXNZbHNmaU4w?= =?utf-8?B?Q280N05YRnUybVE0cDd2cXpvb3JJVzVpSHFoTHo0aHVFOExJZFNHSEtJUkx5?= =?utf-8?B?S1UxSEloc1RsOEdKR0dVeGJGYmdKSlBFYk1KNVg1SS9VamI3M2F6bzJKY1M5?= =?utf-8?B?ay92Y3NxK0VScWQxNUFMeGJwTittSVN4enlESFdTZ0FGZ2NjZ1dBUkFxMk01?= =?utf-8?B?YUJmZTZkeGNwTENHMGNXa3ZqYjM0NlM4YWRVcWxja1VBMm5kRjhxNWUrRHJB?= =?utf-8?B?R3FYcldZemhCdU1lazlvcmpwQUNZeDFhc2oxaVRGVEtlOUZhNDd5blpzeFVY?= =?utf-8?B?cGhpMDBkZEQ2NUR4Z2RuVHczUVZNRDdGZmwrUlJza2t1cWRMVkUyaGtEWERR?= =?utf-8?B?ZzY4Qmo1RFZSSWZpb0xiT2tkSVBNVXBtSGg3ZnJMUGJBWFhIS2xtZHp6ZFhx?= =?utf-8?B?ZlVSV0NiMm1vaEp4VS8wUHZ5S01XalEvYVRCUlJYb3pBUVRtaVpGUFNUc0o1?= =?utf-8?B?ZzNJMG55bHFYOFIvNGJucTNjTGJDaVJaMktJOXhMc1lCZlZmWTlBOUYwOG4v?= =?utf-8?B?UGpmaUhpOXMycUNBVitmbUYzSG1zY2tDa2VrOUpxNHVFOU43TS9EWGp1T25G?= =?utf-8?B?OGFtb21kSVFZeW80bG5yNjdLaU5SQ2hwUkpST21TWFNsTDQ1Nk4wVU54M29l?= =?utf-8?B?MUhWSVp5cFFkV2FoajJDZysrL0VhOXR0OExpR1gzRjdWSTFIRkEybGZDWXJr?= =?utf-8?B?cTNvdW0rNTk1SlEyYmg5YkVKSEtYVXJ3cGI2Wk92QmVDMU9tVnBCYm9vSktW?= =?utf-8?B?azgwVkJkcEJMeTNhS29EeVZGcXhTN0dNSUxxYUtEdnowZDJjazJkL1NlalhW?= =?utf-8?B?czVpcFpkYUpDRWdZUUxWb0hLWHFKYURCNVJ3bDY2UVh3MjFvVlIwblprbnox?= =?utf-8?B?ZjZJb2d0S3BkM0FWZ2xFOUlERmsrNFkySDJRcUxQNlpuM0pJMDhaMlpVRitT?= =?utf-8?B?dnRKNGt0Mk5UcXozVnRSd1V4V2E1NklaZHZTbEhGeWtpZFM3MndkVmsrWDBY?= =?utf-8?B?Tis2UHVacW51VlRseU9pRDdUV0E2VkJsaXVnTDl1eThjcU4yR0N5enpTa3Rp?= =?utf-8?B?SGNXUHo2MUdZU0o5UkNiN0gzZkdtaGV0cEJDNyt6R0JJMzZoQzZIU2c1S01J?= =?utf-8?B?MnVBazJtS21FL2R4eGdOK280N1pNQzlJK0RGeHRhVnNEN0d2SGxkcDRpc05Y?= =?utf-8?B?eW9BSC95MEppRy93ZmhMeFRQem1GdDgwT2xVNG51TG9QelV5U2toNVRvZ2dU?= =?utf-8?Q?WgD0piJ5M3FxOHWzDythdP6gY?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 98776e95-58f4-4b2a-5320-08daf482018e X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 09:47:23.6939 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jIKv8uldeje7ySxPXiz+QR02rgtYRQ5/lvNJZvGX/ykNUo8dSyJnXxrO0O+rRLiV6fmL8z9j3ThV15QrldkzLQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9354 On 12.01.2023 00:15, Andrew Cooper wrote: > On 11/01/2023 1:57 pm, Jan Beulich wrote: >> Make HVM=y release build behavior prone against array overrun, by >> (ab)using array_access_nospec(). This is in particular to guard against >> e.g. SH_type_unused making it here unintentionally. >> >> Signed-off-by: Jan Beulich >> --- >> v2: New. >> >> --- a/xen/arch/x86/mm/shadow/private.h >> +++ b/xen/arch/x86/mm/shadow/private.h >> @@ -27,6 +27,7 @@ >> // been included... >> #include >> #include >> +#include >> #include >> #include >> #include >> @@ -368,7 +369,7 @@ shadow_size(unsigned int shadow_type) >> { >> #ifdef CONFIG_HVM >> ASSERT(shadow_type < ARRAY_SIZE(sh_type_to_size)); >> - return sh_type_to_size[shadow_type]; >> + return array_access_nospec(sh_type_to_size, shadow_type); > > I don't think this is warranted. > > First, if the commit message were accurate, then it's a problem for all > arrays of size SH_type_unused, yet you've only adjusted a single instance. Because I think the risk is higher here than for other arrays. In other cases we have suitable build-time checks (HASH_CALLBACKS_CHECK() in particular) which would trip upon inappropriate use of one of the types which are aliased to SH_type_unused when !HVM. > Secondly, if it were reliably 16 then we could do the basically-free > "type &= 15;" modification.  (It appears my change to do this > automatically hasn't been taken yet.), but we'll end up with lfence > variation here. How could anything be "reliably 16"? Such enums can change at any time: They did when making HVM types conditional, and they will again when adding types needed for 5-level paging. > But the value isn't attacker controlled.  shadow_type always comes from > Xen's metadata about the guest, not the guest itself.  So I don't see > how this can conceivably be a speculative issue even in principle. I didn't say anything about there being a speculative issue here. It is for this very reason that I wrote "(ab)using". Jan From xen-devel-bounces@lists.xenproject.org Thu Jan 12 09:47:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 09:47:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475939.737862 (Exim 4.92) (envelope-from ) id 1pFuBL-0002aE-03; Thu, 12 Jan 2023 09:47:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475939.737862; Thu, 12 Jan 2023 09:47:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFuBK-0002a5-SQ; Thu, 12 Jan 2023 09:47:34 +0000 Received: by outflank-mailman (input) for mailman id 475939; Thu, 12 Jan 2023 09:47:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFuBJ-0002Z7-6h for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 09:47:33 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFuBE-0003vp-Gv; Thu, 12 Jan 2023 09:47:28 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.240]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pFuBE-0008Ef-92; Thu, 12 Jan 2023 09:47:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=Bs3VulGjSb/JK4kg4WXicdltLKKVB699Ov+/7rXfTI4=; b=Xxqt8VT0J7UimeZLqZEbSmXnYM TNpO7edn4KvvVQzxI9s5rLgvC+G5TJcY7O4JllikI7/kuFnvYgajSGD+osZd4RBsORqB+ZKaR7D+W KIsCOn+G/bddOGYsRezbGhaaHfaXACQyEs9ysf3kxFeMGlCfR5Pu9SCZlnCeFog0DmtU=; Message-ID: <71e806f4-8bd2-dd47-67b9-958bb9061c7b@xen.org> Date: Thu, 12 Jan 2023 09:47:25 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 03/17] xen/arm: implement node distance helpers for Arm Content-Language: en-US To: Jan Beulich , Wei Chen Cc: nd , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , "xen-devel@lists.xenproject.org" References: <20230110084930.1095203-1-wei.chen@arm.com> <20230110084930.1095203-4-wei.chen@arm.com> <9fd67aa2-0bd5-16a2-1e19-139504c2090f@suse.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, On 12/01/2023 08:11, Jan Beulich wrote: > On 12.01.2023 07:31, Wei Chen wrote: >>> -----Original Message----- >>> From: Jan Beulich >>> Sent: 2023年1月11日 0:47 >>> >>> On 10.01.2023 09:49, Wei Chen wrote: >>>> --- a/xen/arch/arm/include/asm/numa.h >>>> +++ b/xen/arch/arm/include/asm/numa.h >>>> @@ -28,6 +28,20 @@ enum dt_numa_status { >>>> DT_NUMA_OFF, >>>> }; >>>> >>>> +/* >>>> + * In ACPI spec, 0-9 are the reserved values for node distance, >>>> + * 10 indicates local node distance, 20 indicates remote node >>>> + * distance. Set node distance map in device tree will follow >>>> + * the ACPI's definition. Looking at the ACPI spec, I agree that the local node distance is defined to 10. But I couldn't find any mention of the value 20. How is NUMA_REMOTE_DISTANCE is meant to be used? Is this a default value? If so, maybe we should add "DEFAULT" in the name. >>>> + */ >>>> +#define NUMA_DISTANCE_UDF_MIN 0 >>>> +#define NUMA_DISTANCE_UDF_MAX 9 >>>> +#define NUMA_LOCAL_DISTANCE 10 >>>> +#define NUMA_REMOTE_DISTANCE 20 >>> >>> In the absence of a caller of numa_set_distance() it is entirely unclear >>> whether this tying to ACPI used values is actually appropriate. >>> >> >> From Kernel's NUMA device tree binding, it seems DT NUMA are reusing >> ACPI used values for distances [1]. > > I can't find any mention of ACPI in that doc, so the example values used > there matching ACPI's may also be coincidental. In no event can a Linux > kernel doc serve as DT specification. The directory Documentation/devicetree is the de-facto place where all the bindings are described. This is used by most (to not say all) users. I vaguely remember there were plan in the past to move the bindings out of the kernel. But it looks like this has not been done. Yet, they tend to be reviewed independently from the kernel. So, as Wei pointed, if we don't follow them then we will not be able to re-use Device-Tree shipped. > If values are to match ACPI's, I > expect a DT spec to actually say so. I don't think it is necessary to say that. Bindings are not meant to change and a developer can rely on the local distance value to not change with the current bindings. So IMHO, it is OK to assume that the local distance value is the same between ACPI and DT. That would definitely simplify the parsing and code. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Jan 12 10:04:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 10:04:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475950.737872 (Exim 4.92) (envelope-from ) id 1pFuRi-0005ME-9p; Thu, 12 Jan 2023 10:04:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475950.737872; Thu, 12 Jan 2023 10:04:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFuRi-0005M7-73; Thu, 12 Jan 2023 10:04:30 +0000 Received: by outflank-mailman (input) for mailman id 475950; Thu, 12 Jan 2023 10:04:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFuRg-0005M1-SY for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 10:04:28 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2084.outbound.protection.outlook.com [40.107.105.84]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7fb6baa2-9260-11ed-91b6-6bf2151ebd3b; Thu, 12 Jan 2023 11:04:27 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8296.eurprd04.prod.outlook.com (2603:10a6:20b:3f2::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.13; Thu, 12 Jan 2023 10:04:26 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Thu, 12 Jan 2023 10:04:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7fb6baa2-9260-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EqR63RmIp6gVTn3ktjENM1dhrnlCeFRojk6W10Q2TQkY/e6nwPHuQAHhQJZkCQvdCK+PDbEBNz0qUuyLFVaQaI9kL8tM+dwT/eQj4JPiZACp55eKz5sAbUJfmXso6+dVBb4cO3UlpddEdPU8wWImlXxx31q30no5iexlVgyyRiOvwLVafb+qBL8W9e/VjJrN08qI+MagvyqoonkX7NQMuGPuZAz3ii1TF45q9/zoNPhNvGPoA+bPtcnWbqJuS60da4zM94UfliwkCPuvYwm0Kilem3zw1dxoX2imNunf515RvL2SkijTXkArolJq0mHLUefoHZDrJVXbRxHM4MJn8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QgD9SrKU0oo0baPtu3i+s2mTRlx/++FDvuMpUVol4ro=; b=IewZvXYDF5GVWq3k8p0dQf3ysQdAvAjpC+S5Rpp9WG/oLBt7c0zT+tTM+dlVngd0Uk5bMRyaLWw2tA85vSWiDTc96YIbD0P1ARhIqkHxvbdVEFT+aVkBISqapKKV+XnQg0se63+Ap1E6AJHbB9KKgw64kdkyaeQkZtMLyq7mSE1aBkJqX8Fhu0iZQ7yTMoauuoVMZtdJy99Wup8eU7xzQoyIO8acllsXpFohCsxExiwXVxfGk3+EqjBq7cJk6pyRZt2qzeCiDbNRtrf8JMHTvZzxnCmzfob2Wx2X2P6AjmGCaaw8sTUQi4x3kuBlR4hhusKyYhnUs89VV8kQBqPhZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QgD9SrKU0oo0baPtu3i+s2mTRlx/++FDvuMpUVol4ro=; b=NyG91mPXeMRa/3rbFtcizpWc4T8SzeDp314aGHDEz333ZLKJqTwbrFRyyqM/UScQOVmFtk6bQzy0jhdKii57Or2lG4g8CYzvmB1sKHEO8r5MFCwpcUiAQpAYT9SJJlvBER48GRDoE12d9NqCrsger1XZZHIWQvlVW7duILiwBGjJ3/lr5KPhPSX0bpHIw6LI/qcZVpP3k5qBi8n+Z9VfgrysDFRdp3bCnqyibLeXSLid7HweU272menbr6dx8RnZKn+HIgRjeULApSr31Ky6/GNUT+k+vdugE4o3fJrSBQiZ1orcX3HIl8tYXkTYmv1QETJ6+1fe9RHQ3gSzcp0R3g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3729733d-fa73-5221-4922-3abe40ffbbb2@suse.com> Date: Thu, 12 Jan 2023 11:04:23 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [Multiple reverts] [RFC PATCH] build: include/compat: figure out which other compat headers are needed Content-Language: en-US To: Anthony PERARD Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <20230111181703.30991-1-anthony.perard@citrix.com> <5c7ffbe4-3c19-d748-9489-9a256faebb7a@citrix.com> <750ad2e8-a5be-d9c0-846e-41bb64c195fe@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0012.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8296:EE_ X-MS-Office365-Filtering-Correlation-Id: 002118a1-0164-4a99-e757-08daf48462bd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Tbwk2N+alil9JCgcU0nc4sex94QmAeLu0JdCyETp4X+L/NwZO9Vjv8u2k87CiMQgW2Kmz9C56S/BvtAaK0i8UQEmGKys+n714q9pv5dRrXYV6ITQzGZ4jT5377l80EVYRCV9UfpxEIo5wYEaYXXnqsmq2aje/qMGR/fsSI//HUIfCRHs9e34JNb5uTCnYzQpXd6ywHGSgvnAoNBz16jyEl3Y99HjqFMN6T+b6Lp/aUd61IT1ZveFjz3A/C1NBxih51e8f87h8t6pPJqMsmMU4JQ/qnLJyHDREz5LHOo7JdOJWEKUdg51Z3QLlzDg94FVc8AgncmUL2ZEIj9k6UMCFvT6JOSqAwQ4BSHxoyHVLVEdNSya7qpYOqn0H+8EFizOUpi5/zG6Vd0nvm5pV4WNltXlPQ6ozGbUvP2TjWrSjQlNYscgKgVMwO7uIEkK84ZwbZ8cvVRI5brxUNUO32ox30dgjc33YDRAus+2eTd9lvdXGtSnsj7ER52tq9ZhQC42zZKNtcXn0OsCinTvv+kAylBuFZ0/ihnPp6YqEJ3blDriHZVR4RHqrPmTccWtskezRvTQDyCuRRVg/RDKfJMOqMFn2LWfGqk7jlW43hLsa0nMJhkfR3GLI5jxzorGCfWQjVqLYXfxqbL7co3nMbdxdkuW8p1Mv6S3CTyyCBVbElgmeNuMigdWLMsB396EYnoSfqZdmlsatZBTAvHBWDwKbNS4tkJ16DIYmoKLBXAcVJbQtgjr1nBeB+RgqcZUjHL1g+bsUZjghUcenwsvnWCeiQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(396003)(366004)(39860400002)(346002)(136003)(451199015)(5660300002)(8936002)(41300700001)(38100700002)(36756003)(2906002)(31696002)(86362001)(478600001)(6486002)(31686004)(966005)(26005)(6512007)(186003)(6506007)(53546011)(8676002)(6916009)(4326008)(66556008)(66476007)(316002)(66946007)(2616005)(54906003)(6666004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MGFITmJoRk9nL1B6dS9DejBuWnhBdkRLSGNhTVBUQk9rRGdmSEMzellsWWNk?= =?utf-8?B?UTJ3eTlEd2ttQ1g0SW8zNVh4K1ZjVHZmcE0rQ2diMDBhdHpVbXZZczZPb0sy?= =?utf-8?B?eU9sRkt0SnUrMEsycVlXL2ZxK1FvTk5GQS9Ia0FXYnQ2TVN1VGdSY3M0TFcy?= =?utf-8?B?UzZmc2lkL3h4cmtMVysxd2kvK1F0NVJPZWZFREdOV210dTdVQ1JEVldvUHVP?= =?utf-8?B?NUNMa1Vwc1llbHRuRHpzU2I1akJjQ250MDc2VFdFRkJZYVlWN1RNY0lZUytY?= =?utf-8?B?eWFWUUEvZkVxb1RCWmZycGl4UElxZU1oNE1ISlNqaEMzVXZnWkRnYVRBd0Fk?= =?utf-8?B?R3JqRzhPSmMrS0w4UzlvT085TGx2UkZDQ3hBYUgvMm0yQy9qdXlBSlV2M2V5?= =?utf-8?B?M2dxdmxvbVlBeVFXc0doeGU3REsyRzZZSThNNmFxU3RseFZLa01aSXp1NFhn?= =?utf-8?B?TU5pb1htQjIydlZOWE43bkxVQkEvQTJRbzA0VnBCREx4blhJN1J2a0hiamdH?= =?utf-8?B?V0Z3TEV0RjJWTUpBQlVZK2I0OXllM2lQNW5UMUJFcXkrdnRzaTIyejloNEpS?= =?utf-8?B?YUdsUDdtVENWRzNNZHlvTjM1Smh1cFNZTGIzYy9SNkhtSVBkaldSeDZiQnoz?= =?utf-8?B?andXZjYza2JLTm8wUzJSakJEVzNkKzNpZ0tTQzM3dzE5UUFSMzRXRGZ2Z3Nv?= =?utf-8?B?aWpCclpQbG4vKzczNVY4ZFgzZUp4Qmc2RE1xbzZXMnp6aDNWUGp3VTQrMDl2?= =?utf-8?B?QUxFYzdtWUQrdnZ1QmkvU1VIcGFVMUc3bmNPSmpmRVczdWxMVWJmSzB0WDVz?= =?utf-8?B?Q3VTeXpGbFU2bFIraXJvSThXa0dQdWI3TGlxY04xTlpXYnEzK0ltU3RyVTRi?= =?utf-8?B?dGhCVmVSSnZHbGQycmdBaUx5V3Y4T0Y4ZFAveW5HS1g0NDdOZmtXWVpwdEV3?= =?utf-8?B?bklLdmtOd0loUFc0eVNpT3FwWTVaaVFHY1paM2lwdnNYZU00Tlc1bG84VHJv?= =?utf-8?B?QjlYTno1Y1FqTk81Qy9BVzMvSlAvbjhjQ1RkbnFVbUxKVEpXRFVKNTJjTEt3?= =?utf-8?B?TXJqMlZSdnQ4b2JkUVpEZEFBM0Y2VHNWZmdMVGplYUkrdi95Sk9lSWpPQW5q?= =?utf-8?B?aXliRmxyYTNORHJ6b2dsa2xNcWcwKytPUWZGNUFMaVJyb3I3ZkF4NGRoZ0pS?= =?utf-8?B?STBIMi9HNHVsNFl3ZEhHZ200ZCtZdG9seW01S3RldWFYZ29rR0JXWEdyblNs?= =?utf-8?B?bVRaUm9xNlRpUW41c0R1TzBZWlJ0TnVWdG1SN21icERQaXFoWGNLN2VPby9n?= =?utf-8?B?dDlURzZabGFFRmlSZWdHem85ekhHbUp2R1dvV0tmYkZab3RMUzhNdkVyOFBF?= =?utf-8?B?WHB2ZkdteWhVamdueDAzTk9BSVRuc3A3aTd6a0FaKzAyb1ErRllQZFdmQ1pp?= =?utf-8?B?cEVGNGdMa0NwS05USGRQNGhSaEdlZllQRktTemFDYXB2U2xTL1FYZ0tja0Qz?= =?utf-8?B?b2VqQldjY2FRYWphSW4vb3M0eklUU1NvakNQY0FhODJRYjFQZGxjVlR5TXkv?= =?utf-8?B?M29obSttU2gxWVBjQVpoN1IwRWlWN3BJbzJEUVU2WXNEVWY5SGFFT2kyUk9m?= =?utf-8?B?NHl2bXVhSkpScE9JMXFtRDh2RFptbi9CSUZabk1mV1JIdmRTUksxZ1lzRnVF?= =?utf-8?B?OFRVMmRyKzFWVzF3ZnVTSHJGZXVhZ2ZTZVd5d2p1VmpLT2tDVlEwK01BSHBG?= =?utf-8?B?ZVVpQVZVaHZWbzZjMlMvM3ZLTE9pNUdjalVQazhjWXZhWE9UczFDYkt2S1JR?= =?utf-8?B?eWNkbmdIRzNaNmIrNVo2dWFGTm94VEZrQmd1azQ2ZXd6TGJWUk1acVNaMW9j?= =?utf-8?B?dHpzSDdBUXFVRFRmZm93bFBzdCtFbVNmVmwrYmxYTGs2L3Y1KzY5ZDlkc2ZL?= =?utf-8?B?MXBUY3JLQysvVUplaWFkbGZSNlEvR0pxcGk4SzR0YkhtcW5MVlAwRUg0NWJT?= =?utf-8?B?KzNoUk9ic0pldW94ZFJQdkFPajZyQUpzL1lnS3lvcmRyeVVxbGtndXpLbFpn?= =?utf-8?B?MHdMMVhTeFlWVXJsVFlTeTN5eVBQRzNhRGZER0xnbEtvbFRkRHhaRjFLejZX?= =?utf-8?Q?4AewLeO8IzaLALO9uoRmkzUCg?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 002118a1-0164-4a99-e757-08daf48462bd X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 10:04:25.7694 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IpVnERO8BwG7337sIiKtRKywsjKC2FxdcC6hUdoRgRgvsoOA74/mPcMX1R2L0QS9RcTH3+nobZ+R3kWzKBafKQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8296 On 12.01.2023 10:27, Anthony PERARD wrote: > On Thu, Jan 12, 2023 at 08:46:23AM +0100, Jan Beulich wrote: >> On 11.01.2023 23:29, Andrew Cooper wrote: >>> The real hvm_op.h legitimately includes the real trace.h, therefore the >>> compat hvm_op.h legitimately includes the compat trace.h too.  But >>> generation of compat trace.h was made asymmetric because of 2c8fabb223. >>> >>> In hindsight, that's a public ABI breakage.  The current configuration >>> of this build of the hypervisor has no legitimate bearing on the headers >>> needing to be installed to /usr/include/xen. >>> >>> Or put another way, it is a breakage to require Xen to have >>> CONFIG_COMPAT+CONFIG_TRACEBUFFER enabled in the build simply to get the >>> public API headers generated properly. >> >> There are no public API headers which are generated. The compat headers >> are generate solely for Xen's internal purposes (and hence there's also >> no public ABI breakage). Since generation is slow, avoiding to generate >> ones not needed during the build is helpful. > > If only we could do the generation faster: > https://lore.kernel.org/xen-devel/20220614162248.40278-5-anthony.perard@citrix.com/ > patch which takes care of the slower part of the generation (slower > at least for some compat headers). Right, and I still have this in my folder waiting for a review (by someone knowing Perl better than e.g. I do). Maybe you want to put on the agenda of today's community call an item to see whether we can nominate someone with enough Perl knowledge? Jan From xen-devel-bounces@lists.xenproject.org Thu Jan 12 10:18:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 10:18:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475957.737884 (Exim 4.92) (envelope-from ) id 1pFufL-00072i-FN; Thu, 12 Jan 2023 10:18:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475957.737884; Thu, 12 Jan 2023 10:18:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFufL-00072b-CS; Thu, 12 Jan 2023 10:18:35 +0000 Received: by outflank-mailman (input) for mailman id 475957; Thu, 12 Jan 2023 10:18:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFufJ-00072V-HS for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 10:18:33 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 74c02d28-9262-11ed-91b6-6bf2151ebd3b; Thu, 12 Jan 2023 11:18:30 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 74c02d28-9262-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1673518710; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Fht+EqOzpwz5ylkFBu+NCRnrKL+oPCraZHKG17BnUUM=; b=WPJDil11KVitLgAqLuEb1avTWuJr42jUNFg5QMpV3hyJKijjqRF07NDR psLrg3eGP7BJuvT8mUs4HXoBrNMNS+0RGV4Bq1o6a3UK0trv6MK10q8JJ Esl8IZ33dIzZ5tAyG7RCUnl6ci/q+MSAm2O7hLYeo8BOuXfSu16G0T3aT w=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 94746319 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:lxnaMaDZ1mP2ghVW/xTjw5YqxClBgxIJ4kV8jS/XYbTApDgi1jAEx jBJUW2DOviNM2qmLd0ladzj/E4Pv8fWyNZlQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nNHuCnYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtcpvlDs15K6p4GpB5ARnDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw2/srBWFM9 8IjcDkDbj24pMbm0e6aRbw57igjBJGD0II3v3hhyXfSDOo8QICFSKLPjTNa9G5u3IYUR6+YP pdHL2o0BPjDS0Qn1lM/AZQinOCulz/nfidRsl69rqsr+WnDigd21dABNfKEJoPWG54Mzy50o EqW7jrEWE0mHeeOyCegy0iB3e/muT7CDdd6+LqQqacx3Qz7KnYoIB8LUVq2p9Gph0j4XMhQQ 2QP4TYnp6U28E2tT/H+Uge+rXrCuQQTM/JPF8Uq5QfLzbDbiy6bDGUZSj9KaPQ9qdQ7Azct0 zehj97vQDBirrCRYXac7auP6yO/PzAPKm0PbjNCShEKi+QPu6lq0EiJFIw6Vvfo0JulQlkc3 gxmsgAfmukXjcwJ6Z7j9F7HrgmPgsjYEi86s1C/sn2e0it1Y4usZoqN4Ffd7OpdIIvxcmRtr EToiODFsrlQUMjleDilBbxUQer3v6rt3Cj02wYHInU3y9i6F5dPl6h06So2GkpmO91sldTBM B6K4lM5CHO+0RKXgU5Lj2CZUZ9CIUvIT46NuhXogj1mPPBMmPevpn0GWKJp9zmFfLIQua8+I 4yHVs2nEGwXD69qpBLvGbhGiuB2mHBjmj2DLXwe8/hA+ePADEN5tJ9faAfeBgzHxP7sTPrpH yZ3aJLRlkQ3vBzWaSjL648DRW3m3lBiba0aX/d/L7bZSiI/QTFJNhMk6e95E2CTt/gPx7igE 7DUchMw9WcTclWceVXaMCA7M+K/NXu9xFpiVRER0Z+T8yBLSe6SAG03LfPboZFPGDRf8MNJ IronPort-HdrOrdr: A9a23:vtQgsKupwSSo291kJDBBN5Zc7skDcNV00zEX/kB9WHVpm62j5q aTdZEgviMc5wx/ZJhNo7690cq7MBDhHPxOgLX5VI3KNGOK1FdASrsSj7cKqAeBJ8SRzJ846Y 5QN4R4Fd3sHRxboK/BkW6F+g8bsby6zJw= X-IronPort-AV: E=Sophos;i="5.96,319,1665460800"; d="scan'208";a="94746319" Date: Thu, 12 Jan 2023 10:18:17 +0000 From: Anthony PERARD To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [PATCH] include/compat: produce stubs for headers not otherwise generated Message-ID: References: <992a28e1-bfcd-97ef-b3d5-c7341846b3ad@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <992a28e1-bfcd-97ef-b3d5-c7341846b3ad@suse.com> On Thu, Jan 12, 2023 at 10:17:47AM +0100, Jan Beulich wrote: > Public headers can include other public headers. Such interdependencies > are retained in their compat counterparts. Since some compat headers are > generated only in certain configurations, the referenced headers still > need to exist. The lack thereof was observed with hvm/hvm_op.h needing > trace.h, where generation of the latter depends on TRACEBUFFER=y. Make > empty stubs in such cases (as generating the extra headers is relatively > slow and hence better to avoid). Changes to .config and incrementally > (re-)building is covered by the respective .*.cmd then no longer > matching the command to be used, resulting in the necessary re-creation > of the (possibly stub) header. > > Reported-by: Andrew Cooper > Signed-off-by: Jan Beulich Reviewed-by: Anthony PERARD This patch also takes care of "removing" compat headers that are no longer needed due to change in .config, which is good to have (even if this only remove the content in it). Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Jan 12 10:31:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 10:31:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475963.737895 (Exim 4.92) (envelope-from ) id 1pFurn-0000y0-Jd; Thu, 12 Jan 2023 10:31:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475963.737895; Thu, 12 Jan 2023 10:31:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFurn-0000xt-Gb; Thu, 12 Jan 2023 10:31:27 +0000 Received: by outflank-mailman (input) for mailman id 475963; Thu, 12 Jan 2023 10:31:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFurm-0000xn-Qn for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 10:31:27 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 41303408-9264-11ed-b8d0-410ff93cb8f0; Thu, 12 Jan 2023 11:31:22 +0100 (CET) Received: from mail-mw2nam04lp2175.outbound.protection.outlook.com (HELO NAM04-MW2-obe.outbound.protection.outlook.com) ([104.47.73.175]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 12 Jan 2023 05:31:16 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SJ0PR03MB5583.namprd03.prod.outlook.com (2603:10b6:a03:28e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Thu, 12 Jan 2023 10:31:12 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5986.018; Thu, 12 Jan 2023 10:31:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 41303408-9264-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1673519482; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=fgzrP60jBfGrPQdP/DsLEQGZ1cWMKjUiLE91ksIgTHc=; b=JI4sHJFzIR5sWt75qRaNkAeGjZUPqPbXOsxx64t3S3JDlA344yxP2r3j AhJE6Jujd8/iChJidMuF4ICL0aQbMZV0SqL+ukdwEBe5AumMFMPjOePLM Q4VxxMwiEAsAZVe55xIlR7ML6XrwwDYB5uxXnANXPhCKrDaWBqhBh4D/c g=; X-IronPort-RemoteIP: 104.47.73.175 X-IronPort-MID: 91215629 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:Yl1OgarzlFnY5nJ8W73dSnufNq9eBmIpZBIvgKrLsJaIsI4StFCzt garIBmBaKmKNmSmfYpzYYvlox4Au57cn9VmTQQ6qCgxRi5Go5uZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpAFc+E0/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06W1wUmAWP6gR5weHziNNVfrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXADMmbkuGiL6R+riEe7J8rOU8D+36AbpK7xmMzRmBZRonabbqZv2WoPpnhnI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3j+OraYWIEjCJbZw9ckKwj 2TK5WnmRDodM8SS02Gt+XOwnO7f2yj8Xer+EZXpr6Qz3QPJlwT/DjUndmWCodOesneldNxxL EAm9XILsIMtoRnDot7VGkfQTGS/lhwWVsdUEuY6wBqQ0aeS6AGcbkAbShZRZdpgs9U5LRQ21 1qhj97vQzt1v9W9WX+bs7uZsz62ESwUNnMZIz8JSxMf5Nvuq511iQjAJuuPC4awh9zxXDTvm TaDqXBig61J1JFWkaKm4VrAnjSg4IDTSRI47RnWWWTj6R5lYImiZMqj7l2zAet8Ebt1h2Kp5 BAs8/VyJshVZX1RvERhmNkwIYw= IronPort-HdrOrdr: A9a23:nJmgaatOZBz9ZcLVw896ER3B7skDctV00zEX/kB9WHVpm6uj+/ xG/c516faQsl0ssR4b9+xoVJPgfZq/z+8X3WBhB9eftWDd0QPDQb2KhrGSoQEIdReOktJ15O NNdLV/Fc21LXUSt7ec3OBgKadE/OW6 X-IronPort-AV: E=Sophos;i="5.96,319,1665460800"; d="scan'208";a="91215629" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mNxOq3D+U3iDH941E8zovEiXM9wvX9hNhC+g/NGLvoPwRc3LNZX0vgwvE/KX/BlQVXKOp0IxOCZjAQk8slVoZEvepU3d5jp5cAOikEi2XgHhOax2pInFj3AxinFhcxGJtP8h9aWhIrPXqaH0SO/Z2Fl391fvD1Fyv19whmoGTiKKOCIUHQlrWU7As6YDCPOhcoZu4JWEMFaycauPIjw3m9Cy67k9EVFCe6tJEG2IEv2cRBS/HoX15NxkrXKr+sRwqs1DIqbKLE5GBe/mKGJk4gFGtyCu7JOjgQF0TnU7sPLxoe/+6vx7C4QJnWb9u5qUlfNeOzp7+C3Qt0jOF8KDhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fgzrP60jBfGrPQdP/DsLEQGZ1cWMKjUiLE91ksIgTHc=; b=DZNZViFJ4rS9YeMGjGfD6zO9QWZqPFvVQT6hEEVjCT8x+9m04mAY8gltzilZhID69Nldxo7QWtJgEXLKy431qL3uQ+XZdjF2RnM5gpnEdtsfB6NmfyF9N57zQ+sJQ2hVq9IdtC47SxDHPisq7o+2XixpbBT51bLBkIDV+kq0XhOWbZY69Zhajx+Xiftx+TN3zMZJDutFGFPAzz4lB61aG9UMFdQvp7uzk4WsWuD37PJd9Zn4K5d+pFR5iRL+kx36AHIZ8NPcOsNxCe6p9GCTPmTutJsSCE0NAQoyXzo8h0GHV12LaNOlDt5imAXTViQ33TCdrzHqWlvy+13eZ35hQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fgzrP60jBfGrPQdP/DsLEQGZ1cWMKjUiLE91ksIgTHc=; b=VWhPrww/PH1ilJQdK4Pqxn56W8yFFgctKvJNFVqws5ztJ6wI8YXNYLkU19W4vFOT7l2PfOw9xBeSYfZJPNvKpOSZ283HTq6AUeclkKeL06Fk/xeCAFgIbEFb5UAE4bSibLs4MB8PuUrJAugY6I80dEJp1fifGgjnDSUaYtJNitY= From: Andrew Cooper To: Jan Beulich CC: Wei Liu , Roger Pau Monne , "Tim (Xen.org)" , George Dunlap , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH v2 9/9] x86/shadow: harden shadow_size() Thread-Topic: [PATCH v2 9/9] x86/shadow: harden shadow_size() Thread-Index: AQHZJcS6xQlTtpJxX0O79yAhgOZJ+66Z2cOAgACwbwCAAAw+gA== Date: Thu, 12 Jan 2023 10:31:11 +0000 Message-ID: <71e7ba34-f1ea-16fd-ec01-bb2aa454270c@citrix.com> References: <9bea51eb-4fbd-b061-52d7-c6c234d060a1@suse.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|SJ0PR03MB5583:EE_ x-ms-office365-filtering-correlation-id: 6ae85160-01c9-475f-f99b-08daf4882017 x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1DdEIbxbTTfjaVOA/r16rzbzt6MYI1qHwQILOyXoT7yiqeKDoqOwfG4mKf45Ynhd7AhuHzeQjGng3i695QExpkz9OMBzuumEZ8GXZYZSW30VZwnZuphVeesXkWM6kcv6frsoBYmiXIZEHTIhDtUs53fpfohIcMw+Zt6xV+hXF9wPA7d+YTvrjOFZCMHOLg4HNtxyRPYdqE9ROOid4VPXUlo6boHl6SERNjeljNHUvobqRUPZhElvQ6jz1UNJ1iRycLi5IYviQORCbAN7giAU9p54BPWSh2WbDUgIuCxXCp1tw7+V0HA+XcBDtwUDE8Pc5R9B96bQ5Mv/XiISX+pGzx2HAeDSLGMo781gZ5UAEw7fvMxH5OConxeVjG7v5IO5YsQBqeQLGW5RuDUP/BrtOe6LW8AgpQUU8xATFcyXa3yJrK1keCQhe6guc0odzRjOJvc/LAKRGrul0eTohedBXy6ziqzjT6A2ovb3bRF//x2vxJ9DuvrWyosOVsQUhliAfUxN2x4nGTFYrOLjGNNf1sjHFdXGjCk5qNtr4c1UjVYzXD61GuEMkPFX9FyzdTrkREhPxNnPWmxx4EJSxaVN3NAiBFiiMzwf+dl+c8M2oniYquRQUvm1vUoH4fAYyPvOLVPTzyjmZaUey62Lm/HXGthcn9EB9050PLNPdRChWjP+97ZEoE7jLwu+gcUi00DfsfueDFOBklGrdOMd2dFoxTlmQ4BkSrl6y3pKDT4GLuamDoxnsCv+OfDiyZyElYL/z8ujY5WjwpfPUxQ1i6pgLg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(346002)(376002)(396003)(39860400002)(136003)(451199015)(2906002)(83380400001)(478600001)(66446008)(66476007)(64756008)(66556008)(5660300002)(66946007)(8936002)(53546011)(122000001)(26005)(36756003)(186003)(6916009)(6506007)(31686004)(6512007)(6486002)(2616005)(82960400001)(41300700001)(38100700002)(8676002)(54906003)(76116006)(86362001)(38070700005)(316002)(71200400001)(4326008)(91956017)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?bHlqay9LOElYMWgwcjdEM3FMSHVYY201OEpJODRqNEttWHFuRzRQNHVZZnFX?= =?utf-8?B?ODhTVVV2ZktPcGtPWWZiOU8wSTZmWmdDMHp6blBrS2srY0Rpem9SdjhyeDBO?= =?utf-8?B?ZUhMQnIzSG1tTjB5UldXU0VpVEl0R0tIZkJ4ZXRxam43c0piMHlzY3FGOHFm?= =?utf-8?B?RGY4MUlOSXdvd04yR0Z6L1VtZFBKVWRyMFpZNjFXZXltU0oxaEJnMWhJeWt5?= =?utf-8?B?Q21hOUVKcDlveUZMbTVoK0Z3MldURGNTUGtCVFNhU0d1ZVFwVUtFbEtmU1Iy?= =?utf-8?B?d3hrQ1dLQXdMdjZaakFscnZoUFBwS2lpVmJMSG56b25WbXEvMGFaUXV5QW9z?= =?utf-8?B?akdaM0phWWRERFdGaGVXMnE4Vlp5OWVyOUVXQVc0eG1QR3N0aE5qcDl3R0hV?= =?utf-8?B?REdhL2w2SFBFamM1dkU0VldBNkhZRktYTXRCRkVlcTQyUGFBenpYNmlqMnlw?= =?utf-8?B?SUhiNXo3TmEwS3ZvbGYxZWJjelNNWGVBcGd6WUxVZEFuMzlHckM4ajFBanhL?= =?utf-8?B?Q0tpaGEvVHY1bVN4Zm81MDlDRms5YUtjSTBNNEdEVUVwekxqZzBoblplSC93?= =?utf-8?B?MUpqUEpFY2MyL3g0MDBBSHd5MFJ3VGFHZlZyem8zbWZ4aEY5NmpQYWozTTgz?= =?utf-8?B?cldiYnJxRU5YaFJQd2FjNlVnWXBJbjRHYkU3WUwxa3l4UmNDZEQrb01pOHUw?= =?utf-8?B?VVNNcUlKZmJ4MlBNbHRVNFM5bmhyTzRpbUVYUzZoYjF1bnNuTDV2ZXdJbmRU?= =?utf-8?B?UUVBMVZuV3lFZUcxNHY3Vmhyb0J1OWRHanREMUtJaDlhcS95ZVNTenhsS1p2?= =?utf-8?B?ZUF3ckpMSXlobURrTFdhK2lTRnlwUkFRU3NrKyt4SXBJM3MrM2h5UGV6ZkRm?= =?utf-8?B?amFRU1BRdE5XeVdCSTQ0ZmJlLzVTUkhNT2hkOTZ6RUxqSCtiSXU0dmRkNWE3?= =?utf-8?B?RTJMSXlWTVVBMUh3RGdmNnQ3R1QwK0pFRjIzR2V0SFU1aXQwRDZDSVhVMGlF?= =?utf-8?B?b016NVpoTzYvMEVCWmJadU9nWk04Wmw0NWR6MkRPQTBZOWhBS0FwUXhZQkRX?= =?utf-8?B?SHFHS1k1djB4aTlhcGdFaTlSY3J2bUtWOFR5UFpnRk9Zc2hycjRHM3ZRK0Np?= =?utf-8?B?OUZCLzZpdGhiTGt2RXhWWFNYMW80TFBkeVdSZDRNV0xvZDZLVXI2N3FoaHRO?= =?utf-8?B?TDRpMnIyQktGQUhuTW55dkFIbENNMm5jUlZqQlNGakpML0kwL0NydEdDelN1?= =?utf-8?B?bjVSb0JxSEdqSjNaQjd4L2sxMjJGeVFiVXdmTGdmVHZWRWU5eW9RMW9FaTRV?= =?utf-8?B?bFhCZmpmOU1xK3FSV2M1WTUvWVpURDRQSWZJTzQ1eUFKV1ZzTFdJdlE1bTVX?= =?utf-8?B?N2ppZVR5WXI4NWtaREFMODJ5aDM1YS92MGErdUgwa1ozS3RnVmM5eDNiTzBM?= =?utf-8?B?Q1Q3em1Odnl0T1dhc1dPSVFwcGhoUkxwZVVPV1FKWGxwdmREWnA4RlNOSllM?= =?utf-8?B?VkhnbDYrTmNDNWk5SkFmWGxsaUJ2NUFHcHRyZUtWK0h2RVVkVi9ubk53dC9h?= =?utf-8?B?aUdDS0hwaEVFV3VFd0JXaUtQb01kL2puRDVuK1dNQzFNZzNGNUFGQmhHSzZp?= =?utf-8?B?eDlwWG1wa3RHejcvWXFHWVpGeThtbm1LeEptVjJiRjlSYXI1bXY1ZE5zN2dj?= =?utf-8?B?eFRZMEZaV2U0VTlWald6UXlrcjZ2aXdjSzlkOGJOb3dGQ3ZUQW9UdjVJMG1w?= =?utf-8?B?MnB6c1R6TVpkVWpNeUdVeDcyWTZpamtOejdhRTFGUms2ejc3bzMvMFNYRTJl?= =?utf-8?B?TTlJUmg4WnZOWjEzdDgzRWkxTk93VmJyQTUzUzU3Y01ZZFlqdkxwbHFzbkZo?= =?utf-8?B?SkJrd05abEVFVE9neEhCZDhQVUx6SElkNklFM09UNG15T2xIMjFTQ2xZdmNk?= =?utf-8?B?QmtWc2lDSjBqNkhYbitmWm15QWFCUEF6Z0l0NFk4dURMNW51bzRiQytOWGVt?= =?utf-8?B?bm9qa2ZuOExrdVUwcDFpVDVUWklQTFRmTUpubXBPTnk5aW4wS2piaVI1L0pu?= =?utf-8?B?a2t4VTBOZlFPY25uZUxxeSt1eWVQZEVCVmNmUVNiemM1YnArSnJMZ0ZrZ3lk?= =?utf-8?B?YUZSaGFWOUYycUlGeDZZNnphQjV6dzBjcEc1aW1lUmJsTUV3K3ZXUWxYdmg3?= =?utf-8?B?Ymc9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: PnGkO3gOH5CnaCCXwf9Uhla00rhxcIJfvnpH4gkKr7ltwTF3lgrOU/fZfr+0L6QfYGYfAkSdoSQLGXsc3il/MoXoVX/FbifNy6bASw3DJ9b0i7GxK7+/quq9YHQiqB8WMGCN85/TkxQmmfLZiuAi170zr/utOarq9FCZFUUW4ZMpD//maGniwTZAgyzAwNcIb7B0Ha4F3unztu2Ft8F/CYMC9J17MNgK/218RnYixecoyFIX5RJgY9irIdurEvehu0BNGGUmH6Zfc1WYc6TMkoHGkR1WC9wNGJELCVHzITGLyEgvpeLbtlqt1RD0gNIn+fbyTqtMNt5Sh5KbcWNETsx9Cbfvh+bybof+1AIvVZCWpyitsHLakqyjXcRd5GclbuJExoBl/XIdIUu/D/Q6rcT+Xha3RQ1El4qS66MYr8OBKbBN6NQANDVwPcZ37TC0CpsDe4ZqoE3N0wPapMyIoeRpRoHX2GubwtyRJMN+2REgKpLdN7B4JGq15T7irW67xbfOsIoPJDBNqHRcaEWnEV3EVwbxo5Vf3ZYa0q3YYvj4yvR9ayg7vaEoaQVNZv5/SrXY2TSKR1jsGSwG8fFG6ei23h9iiXrndQAj2DzcC6mBrbzydZJfdbJYgq9cddwyCA0gZvwIpGzBhIaJ7jGxT9smZwEoTyy+CDEdTTw1N06j4E8I9U7L2O6ixqT1e4LjoSNI+i6mwl7YuqvX2bnK6Yn73xjM0ptKH2UbCi3co9XNIVPuw7SA31gasGD9NOWzRKkKMmajMwaVr+lgBxHWuC2wUjA0Us3xyk1tIbcrEigbrVKGY1wpv3rkE3h30b7/3zae7yNX35MSx15el4/UIA== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6ae85160-01c9-475f-f99b-08daf4882017 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jan 2023 10:31:11.7362 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3rtaEAab+OuZHdVhCRTDSj7jTqESYBkzTjMzHXwBR79QrguMcGUeMNd0QBG0cYYfJJIGdndMtxMIFtP3ehhd9JxipQ3ymtDmCMgABEgzf7k= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5583 T24gMTIvMDEvMjAyMyA5OjQ3IGFtLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMTIuMDEuMjAy MyAwMDoxNSwgQW5kcmV3IENvb3BlciB3cm90ZToNCj4+IE9uIDExLzAxLzIwMjMgMTo1NyBwbSwg SmFuIEJldWxpY2ggd3JvdGU6DQo+Pj4gTWFrZSBIVk09eSByZWxlYXNlIGJ1aWxkIGJlaGF2aW9y IHByb25lIGFnYWluc3QgYXJyYXkgb3ZlcnJ1biwgYnkNCj4+PiAoYWIpdXNpbmcgYXJyYXlfYWNj ZXNzX25vc3BlYygpLiBUaGlzIGlzIGluIHBhcnRpY3VsYXIgdG8gZ3VhcmQgYWdhaW5zdA0KPj4+ IGUuZy4gU0hfdHlwZV91bnVzZWQgbWFraW5nIGl0IGhlcmUgdW5pbnRlbnRpb25hbGx5Lg0KPj4+ DQo+Pj4gU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPj4+ IC0tLQ0KPj4+IHYyOiBOZXcuDQo+Pj4NCj4+PiAtLS0gYS94ZW4vYXJjaC94ODYvbW0vc2hhZG93 L3ByaXZhdGUuaA0KPj4+ICsrKyBiL3hlbi9hcmNoL3g4Ni9tbS9zaGFkb3cvcHJpdmF0ZS5oDQo+ Pj4gQEAgLTI3LDYgKzI3LDcgQEANCj4+PiAgLy8gYmVlbiBpbmNsdWRlZC4uLg0KPj4+ICAjaW5j bHVkZSA8YXNtL3BhZ2UuaD4NCj4+PiAgI2luY2x1ZGUgPHhlbi9kb21haW5fcGFnZS5oPg0KPj4+ ICsjaW5jbHVkZSA8eGVuL25vc3BlYy5oPg0KPj4+ICAjaW5jbHVkZSA8YXNtL3g4Nl9lbXVsYXRl Lmg+DQo+Pj4gICNpbmNsdWRlIDxhc20vaHZtL3N1cHBvcnQuaD4NCj4+PiAgI2luY2x1ZGUgPGFz bS9hdG9taWMuaD4NCj4+PiBAQCAtMzY4LDcgKzM2OSw3IEBAIHNoYWRvd19zaXplKHVuc2lnbmVk IGludCBzaGFkb3dfdHlwZSkNCj4+PiAgew0KPj4+ICAjaWZkZWYgQ09ORklHX0hWTQ0KPj4+ICAg ICAgQVNTRVJUKHNoYWRvd190eXBlIDwgQVJSQVlfU0laRShzaF90eXBlX3RvX3NpemUpKTsNCj4+ PiAtICAgIHJldHVybiBzaF90eXBlX3RvX3NpemVbc2hhZG93X3R5cGVdOw0KPj4+ICsgICAgcmV0 dXJuIGFycmF5X2FjY2Vzc19ub3NwZWMoc2hfdHlwZV90b19zaXplLCBzaGFkb3dfdHlwZSk7DQo+ PiBJIGRvbid0IHRoaW5rIHRoaXMgaXMgd2FycmFudGVkLg0KPj4NCj4+IEZpcnN0LCBpZiB0aGUg Y29tbWl0IG1lc3NhZ2Ugd2VyZSBhY2N1cmF0ZSwgdGhlbiBpdCdzIGEgcHJvYmxlbSBmb3IgYWxs DQo+PiBhcnJheXMgb2Ygc2l6ZSBTSF90eXBlX3VudXNlZCwgeWV0IHlvdSd2ZSBvbmx5IGFkanVz dGVkIGEgc2luZ2xlIGluc3RhbmNlLg0KPiBCZWNhdXNlIEkgdGhpbmsgdGhlIHJpc2sgaXMgaGln aGVyIGhlcmUgdGhhbiBmb3Igb3RoZXIgYXJyYXlzLiBJbg0KPiBvdGhlciBjYXNlcyB3ZSBoYXZl IHN1aXRhYmxlIGJ1aWxkLXRpbWUgY2hlY2tzIChIQVNIX0NBTExCQUNLU19DSEVDSygpDQo+IGlu IHBhcnRpY3VsYXIpIHdoaWNoIHdvdWxkIHRyaXAgdXBvbiBpbmFwcHJvcHJpYXRlIHVzZSBvZiBv bmUgb2YgdGhlDQo+IHR5cGVzIHdoaWNoIGFyZSBhbGlhc2VkIHRvIFNIX3R5cGVfdW51c2VkIHdo ZW4gIUhWTS4NCj4NCj4+IFNlY29uZGx5LCBpZiBpdCB3ZXJlIHJlbGlhYmx5IDE2IHRoZW4gd2Ug Y291bGQgZG8gdGhlIGJhc2ljYWxseS1mcmVlDQo+PiAidHlwZSAmPSAxNTsiIG1vZGlmaWNhdGlv bi7CoCAoSXQgYXBwZWFycyBteSBjaGFuZ2UgdG8gZG8gdGhpcw0KPj4gYXV0b21hdGljYWxseSBo YXNuJ3QgYmVlbiB0YWtlbiB5ZXQuKSwgYnV0IHdlJ2xsIGVuZCB1cCB3aXRoIGxmZW5jZQ0KPj4g dmFyaWF0aW9uIGhlcmUuDQo+IEhvdyBjb3VsZCBhbnl0aGluZyBiZSAicmVsaWFibHkgMTYiPyBT dWNoIGVudW1zIGNhbiBjaGFuZ2UgYXQgYW55IHRpbWU6DQo+IFRoZXkgZGlkIHdoZW4gbWFraW5n IEhWTSB0eXBlcyBjb25kaXRpb25hbCwgYW5kIHRoZXkgd2lsbCBhZ2FpbiB3aGVuDQo+IGFkZGlu ZyB0eXBlcyBuZWVkZWQgZm9yIDUtbGV2ZWwgcGFnaW5nLg0KPg0KPj4gQnV0IHRoZSB2YWx1ZSBp c24ndCBhdHRhY2tlciBjb250cm9sbGVkLsKgIHNoYWRvd190eXBlIGFsd2F5cyBjb21lcyBmcm9t DQo+PiBYZW4ncyBtZXRhZGF0YSBhYm91dCB0aGUgZ3Vlc3QsIG5vdCB0aGUgZ3Vlc3QgaXRzZWxm LsKgIFNvIEkgZG9uJ3Qgc2VlDQo+PiBob3cgdGhpcyBjYW4gY29uY2VpdmFibHkgYmUgYSBzcGVj dWxhdGl2ZSBpc3N1ZSBldmVuIGluIHByaW5jaXBsZS4NCj4gSSBkaWRuJ3Qgc2F5IGFueXRoaW5n IGFib3V0IHRoZXJlIGJlaW5nIGEgc3BlY3VsYXRpdmUgaXNzdWUgaGVyZS4gSXQNCj4gaXMgZm9y IHRoaXMgdmVyeSByZWFzb24gdGhhdCBJIHdyb3RlICIoYWIpdXNpbmciLg0KDQpUaGVuIGl0IGlz IGVudGlyZWx5IHdyb25nIHRvIGJlIHVzaW5nIGEgbm9zcGVjIGFjY2Vzc29yLg0KDQpTcGVjdWxh dGlvbiBwcm9ibGVtcyBhcmUgc3VidGxlIGVub3VnaCwgd2l0aG91dCBmYWxzZSB1c2VzIG9mIHRo ZSBzYWZldHkNCmhlbHBlcnMuDQoNCklmIHlvdSB3YW50IHRvICJoYXJkZW4iIGFnYWluc3QgcnVu dGltZSBhcmNoaXRlY3R1cmFsIGVycm9ycywgeW91IHdhbnQNCnRvIHVwIHRoZSBBU1NFUlQoKSB0 byBhIEJVRygpLCB3aGljaCB3aWxsIGV4ZWN1dGUgZmFzdGVyIHRoYW4gc3RpY2tpbmcNCmFuIGhp ZGluZyBhbiBsZmVuY2UgaW4gaGVyZSwgYW5kIG5vdCBoaWRlIHdoYXQgaXMgb2J2aW91c2x5IGEg bWFqb3INCm1hbGZ1bmN0aW9uIGluIHRoZSBzaGFkb3cgcGFnZXRhYmxlIGxvZ2ljLg0KDQp+QW5k cmV3DQo= From xen-devel-bounces@lists.xenproject.org Thu Jan 12 10:43:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 10:43:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475969.737906 (Exim 4.92) (envelope-from ) id 1pFv34-0002VT-M9; Thu, 12 Jan 2023 10:43:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475969.737906; Thu, 12 Jan 2023 10:43:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFv34-0002VM-IY; Thu, 12 Jan 2023 10:43:06 +0000 Received: by outflank-mailman (input) for mailman id 475969; Thu, 12 Jan 2023 10:43:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFv33-0002VG-NL for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 10:43:06 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2064.outbound.protection.outlook.com [40.107.22.64]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e3a96eac-9265-11ed-b8d0-410ff93cb8f0; Thu, 12 Jan 2023 11:43:03 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBBPR04MB7930.eurprd04.prod.outlook.com (2603:10a6:10:1ea::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.13; Thu, 12 Jan 2023 10:43:00 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Thu, 12 Jan 2023 10:43:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e3a96eac-9265-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ed/8imk65PyNLgtUf+88xhSGQ6/PKjzxRMFENwEr/Ox4z5q8yhnOASG2F6speCxuHMAIDe8UNR/+pgo94zg6k0fXJ2K+L3fySISCbctpA4UwnwzZLyXYZ7igXPVAJ9r0vLgkJoFDclGR6EIXwH6I+d79pvQymeAsCngwEAGUXBYmBmHxH+tvDHVQCazEwI996H+Nn0ImBCTzCalRHftXEeWXmf0ADkH4gD+Q1AsXk46J2K8Eocnlz0XQQ+XxNMxbLMyPkmkKehByV4kTANPnHbPL9UA2P7yTW3s5bDcqnujFjVwvDtfKFqQZ//NF5ANxgPmF3xu4QBj8zXb54UssJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5L1kQiY5uTx4IWBhotb8+wwYea9jsU5PILmCT8+5Gzg=; b=Ram6RUzwRxY/FmX2AJvnutOH66FSDsGAHSD204VpNZIFzoyaTmHz5pugIaBcygVmxIwEXc9QZKM4m7nLGzjbz2SRk/d1Gsq5l0OTe+8WXNS7sxvY75hJ8ULjHg53tQH24ICdsXEHUkcq+XjwspE5KHpP64YX5cztmQ7gwCHL0J3q4A0fxwBXy731ATJ3fRL9Rsplqb+Lz7oyMYw04yaWWN+OuAJWVc1wUK5zUo7hfvl8dt6W7j6Rd0MFZlLmBfjpkqq6oETkKHzHDRi/c7yh+nY/5gJO8ZcQkAYmnDkvlrWAVBaCped9EAPrkVQnVsoLbw8NkMwhlkev9BW1m3et8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5L1kQiY5uTx4IWBhotb8+wwYea9jsU5PILmCT8+5Gzg=; b=H9M9jengHjLLdLorjfj0vq+ZKQTTYHYIxseaHGjkKm1wS1aGrpc00uxrgMQVDzjOhx7aJI6fQgm9UGctQve0efbTn55hl9IPAjy45cpoWivLHOCLN2GF+6yIB4JUc0N/K1AxPxUu1SzgPZw5rTlKeLLpdruhbuwzwxwy5jDkbQS0eYDK9Ox+SIBxb4LPCn6RtQO3vKNZr+qFF03SzshFNTYFVEiSfr7NPF8lR67MgB7Y5n+Vv+v7ywM8p+Nhito2ywX0nXNbmhSTEnQ77/ydSNQfA4CBP/bmGHq6HFgN1mcaf6uzOyyk+wM7ptsJwAuCRH9D7OLO0lBN7nWuD3UJAA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 12 Jan 2023 11:42:57 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 9/9] x86/shadow: harden shadow_size() Content-Language: en-US To: Andrew Cooper Cc: Wei Liu , Roger Pau Monne , "Tim (Xen.org)" , George Dunlap , "xen-devel@lists.xenproject.org" References: <9bea51eb-4fbd-b061-52d7-c6c234d060a1@suse.com> <71e7ba34-f1ea-16fd-ec01-bb2aa454270c@citrix.com> From: Jan Beulich In-Reply-To: <71e7ba34-f1ea-16fd-ec01-bb2aa454270c@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0125.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9d::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBBPR04MB7930:EE_ X-MS-Office365-Filtering-Correlation-Id: 7d5e894f-fbb9-4339-65a1-08daf489c5fd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Vs19dBtWdtSBobt4xBtJ4/TRiadBmO+SJCtR6lQn0NoXN7pRu3JTBwqXC19pfVHgtv0tyi0iVpali81bXKsjfsUbAHPD4V0TaMW+ZwDahonoOUF0q5Vfzyg/u51To4JX0771Ko40gARkkOLtOJEjAGooIPBueJDN/4EEavZwhJeksPAzOiULNgTct2MDG0C5BgzewPtiKl4tfbmrYYKtoJqX8ZVqlNZkcQgRtpYdHeudzyXLhXaH8E/oE2Ya2c4mTqHQhRdPlTw4GFq2xL6WkJN2WwXIFrYiDb3FwyLRt2oSA6pR10iGYHQAWqNP6alN/zdBLXZtukUIrSYOtuh2NN+okRMyfzSX6lKm9vMD4O941l+lMDbveVHeidxU45jWe4HoheLvIlF6sVQ1Sj33Jv6PPVxGtqZaxx0DVfiuYNvNSaYBLhczHi1IVjRukw+3lL5t0PV6drTVjx1TL4lfV9NEUQCKwIvtfNOTESUXrOZNdEyNGubJW7+Guvb5QLp6koDmZERpo8Ju/mz/fGyBKa/SHTnJ/Flx25ziAp9LnACTl0eer7z/ZwIFs0Xo5XmIv51In0skbGSqJEePtqtnUK3bbjM7R4wQDUrqBTq4aA6bMYe7My36U9SxCmeF91wQX1dvqUe5g4tVKdeIV2iyPfBa1mobCu2iuMhrSOwDp0AhZgAA2SMUZsmTh4++Eka4rUIV8M+tTE3o0YkFe0STNLf0wx3US2OCXoAT9ZHmXec= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(346002)(366004)(136003)(376002)(39860400002)(451199015)(41300700001)(6506007)(8936002)(5660300002)(31686004)(6666004)(2906002)(53546011)(83380400001)(4326008)(6916009)(8676002)(66946007)(66556008)(38100700002)(66476007)(316002)(54906003)(36756003)(478600001)(6486002)(2616005)(86362001)(186003)(31696002)(6512007)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dy9uM1VHTUR2c3lVbWNiY1lhTmtCMldLWUtmU3RIS3lFeVdsTUJLSmdSbDRu?= =?utf-8?B?cnBVYkxySmgrNVhFSXZZVU16MWxHcjJGUGNZZ1pmUEdUcDk1UnBTZVNLVkFX?= =?utf-8?B?SzBoWmUzVmZjZ1Q0MS96anBVRGZzQ0FSbVgzRElMaTFuRzJwNjJNemZwVk9v?= =?utf-8?B?ZUhOSDdOR0NpMVNMbFRGd3Z1VnZwSG1ubW44ZlN0cFF4ckFvMUdYeVVWeCtP?= =?utf-8?B?cnRuR21xUHZyakIvWVZhUk9hRDh6SHRoMnJ4dG43eEQ2T3ZwZGluWWpzRklP?= =?utf-8?B?OG1XSzdPL05MRGgzbVlNUlRUNm1LNDkyN0dTV1V6SDlnUzU4VEIvVXhST3Fk?= =?utf-8?B?bUdLd0NYV2ttK2l0dDdYc1ZRd084R3FiYlZ5S1U2aEpBTWpnQmYrQTlCVnkr?= =?utf-8?B?USsxenNDUFVhckdZN1NINTBnNlJmcTNYZ1ZtbHAweldrYU91cUZTOFV2cFBu?= =?utf-8?B?TFZVa1J4TmJsNUk2RGlSYTkrNHN6Y1ZlQ0JZYXQ3V3pJU1czUkllTHB2Vnhh?= =?utf-8?B?ZStjanBtcWRWU1RMRFRwQTk5QW80V21uUXNSQ2w2dWZ4R01MRUtaSk5xTkFu?= =?utf-8?B?ZnZBMVRIMG43YXZVNUoxOEJyUnNzU29WYmVDU1Y5dzgwWW9RcThWTzBZWWEz?= =?utf-8?B?ZUE5R2RKR1pFaWtrbm9yQVFZR3dPL3VBWVZ0Wkk1bThab2o5ZUNuTDI2a3Np?= =?utf-8?B?Sjhabk1aK1U5Wmh2Z0xPWUk1RklQMVZ2S2p2UjBjcVpnMU5Fa1BGVFB1VUtr?= =?utf-8?B?SmtGYzBFNmhBNUhiVWI4c3F2T3pJNmgvQUs0VGhVcGhHSHZZaHNHRkplK284?= =?utf-8?B?SkNGeUFya21DMkNqZHY0Y2xnaG45MVNZZHRmQzcxTG4wQlNLNUZhQUdSYWcy?= =?utf-8?B?Uk5JVkVqdUE5WVlQeEp3ZENhcnhkWnNmN1NNTzNnZUNUSDR1c3hLenZWVFZG?= =?utf-8?B?aUZSblNLM1FLbElIdDJmSU5TbVBRQ2VVL0xObDRDRW9NN3dGUFV1eUlJdDlt?= =?utf-8?B?aXVTeUY0RnRmT0FFK1N2V1piMlBaNk43WC96bTJnczV3UFdJcG9ZdTdKOXcx?= =?utf-8?B?dXhhR3VRV2VTeFRlcTBIMm5aek9KdUQ3aU55YlhKN0FIcDBJcHRUVHkzN3JN?= =?utf-8?B?ZnpSSUNVbUVGOEVUeGw3Q0tTMDkxYm5RVnpLRVBFUkJXMHB2OGg2MFczR2xH?= =?utf-8?B?andpdTh0MkxhT2NycThnSzRNbmd4QlJGejlyTTdZQUVYNWNTNmhCTEkrRE9N?= =?utf-8?B?MDMxdERnQXRsU0s5ZWp4dlYvL3E0TkNPQlcxV2phc3ZXNmlUblZwQy9oN012?= =?utf-8?B?NGtLT1hHbmtlV0FLeUs5V2hWVzViM2pCOGFYbVZmMUhHOEJrTG1PYURXVGhF?= =?utf-8?B?YjIwTDBVQmR6MC9Vd1NqaWhPNUt5UVN3WHJEcEQ1MXBya0toUWJ6dEc0OGtF?= =?utf-8?B?Y2M4VGcvd3pGYTBjN0lJVDVHMm1PVlB0M1krTVFwcWRybDlNNTZ0TURLNVlU?= =?utf-8?B?dHRIL0p5MjlrbHgvM3doSk9OSWEvNTBpaGtzeDhZQUxCTUR6YTEwSjFwQlht?= =?utf-8?B?RGlXSFV1aTNrNGFsOEFxNzNPK0pHOElNelg2WkFZRkpPcE5zNlV4M1ZBZ1NF?= =?utf-8?B?akFDK0pxd2MrMkNtaDd5NlVRY0JvaGpKRHNQSmx3M1dLcElqamtYMmU4N3Bw?= =?utf-8?B?V1lRaWNaNHdaS3dVYVZVVVNCWWRNNzJzS3JFcEpqbklLNlN5TzZYREJSVVJv?= =?utf-8?B?eG9CVlQxMG1YeUcvandjTlBpckZHTm8xSkVOckJsZlBCeTM5Z3V6NUthZzdP?= =?utf-8?B?SHFFcmZFakN1OW5tR044eHBmMisrcmZKMlVGNlovMks0REhHOTRVU0RFL2hD?= =?utf-8?B?SHUwdTVhaTRSVTBUTEQ2M3dXTEdUVmRJanczK1kvUnNYcGdIUFl6WUJNN1I0?= =?utf-8?B?ZFdxS3dEbG0xT2JzcitqVjdJQzNtU1pSZU9vRlAwcEdPRWczWjhicjJBZGR3?= =?utf-8?B?aFI0bnlzOHZSSnZuOW02R2xQbjdaR3hhbjdjWC9LSUJCcVppazE4dDcvcld1?= =?utf-8?B?dHNWd29FbnB1bWd5QTZLd1ZEbnN0OGRkZTErUmF6UjQ1bk9pNHdGTFZidnpv?= =?utf-8?Q?L9iGmIW6MJsvqczFr3QEsTcge?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7d5e894f-fbb9-4339-65a1-08daf489c5fd X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 10:42:59.7480 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QKH1B+LjzoOvQ+9yq1SSc4Hvd9q6obpIzDvvc9oxJYi9dCvVrBz5waTTRMkrfdaJ4PsWtlarKMIso5iuBC+yww== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7930 On 12.01.2023 11:31, Andrew Cooper wrote: > On 12/01/2023 9:47 am, Jan Beulich wrote: >> On 12.01.2023 00:15, Andrew Cooper wrote: >>> On 11/01/2023 1:57 pm, Jan Beulich wrote: >>>> Make HVM=y release build behavior prone against array overrun, by >>>> (ab)using array_access_nospec(). This is in particular to guard against >>>> e.g. SH_type_unused making it here unintentionally. >>>> >>>> Signed-off-by: Jan Beulich >>>> --- >>>> v2: New. >>>> >>>> --- a/xen/arch/x86/mm/shadow/private.h >>>> +++ b/xen/arch/x86/mm/shadow/private.h >>>> @@ -27,6 +27,7 @@ >>>> // been included... >>>> #include >>>> #include >>>> +#include >>>> #include >>>> #include >>>> #include >>>> @@ -368,7 +369,7 @@ shadow_size(unsigned int shadow_type) >>>> { >>>> #ifdef CONFIG_HVM >>>> ASSERT(shadow_type < ARRAY_SIZE(sh_type_to_size)); >>>> - return sh_type_to_size[shadow_type]; >>>> + return array_access_nospec(sh_type_to_size, shadow_type); >>> I don't think this is warranted. >>> >>> First, if the commit message were accurate, then it's a problem for all >>> arrays of size SH_type_unused, yet you've only adjusted a single instance. >> Because I think the risk is higher here than for other arrays. In >> other cases we have suitable build-time checks (HASH_CALLBACKS_CHECK() >> in particular) which would trip upon inappropriate use of one of the >> types which are aliased to SH_type_unused when !HVM. >> >>> Secondly, if it were reliably 16 then we could do the basically-free >>> "type &= 15;" modification.  (It appears my change to do this >>> automatically hasn't been taken yet.), but we'll end up with lfence >>> variation here. >> How could anything be "reliably 16"? Such enums can change at any time: >> They did when making HVM types conditional, and they will again when >> adding types needed for 5-level paging. >> >>> But the value isn't attacker controlled.  shadow_type always comes from >>> Xen's metadata about the guest, not the guest itself.  So I don't see >>> how this can conceivably be a speculative issue even in principle. >> I didn't say anything about there being a speculative issue here. It >> is for this very reason that I wrote "(ab)using". > > Then it is entirely wrong to be using a nospec accessor. > > Speculation problems are subtle enough, without false uses of the safety > helpers. > > If you want to "harden" against runtime architectural errors, you want > to up the ASSERT() to a BUG(), which will execute faster than sticking > an hiding an lfence in here, and not hide what is obviously a major > malfunction in the shadow pagetable logic. I should have commented on this earlier already: What lfence are you talking about? As to BUG() - the goal here specifically is to avoid a crash in release builds, by forcing the function to return zero (via having it use array slot zero for out of range indexes). Jan From xen-devel-bounces@lists.xenproject.org Thu Jan 12 10:46:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 10:46:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475976.737916 (Exim 4.92) (envelope-from ) id 1pFv6N-0003Dc-98; Thu, 12 Jan 2023 10:46:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475976.737916; Thu, 12 Jan 2023 10:46:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFv6N-0003DV-66; Thu, 12 Jan 2023 10:46:31 +0000 Received: by outflank-mailman (input) for mailman id 475976; Thu, 12 Jan 2023 10:46:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFv6L-0003DP-Rw for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 10:46:29 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on2071.outbound.protection.outlook.com [40.107.15.71]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5da34080-9266-11ed-b8d0-410ff93cb8f0; Thu, 12 Jan 2023 11:46:27 +0100 (CET) Received: from LO4P265CA0241.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:350::15) by PAXPR08MB7393.eurprd08.prod.outlook.com (2603:10a6:102:2bd::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Thu, 12 Jan 2023 10:46:19 +0000 Received: from AM7EUR03FT034.eop-EUR03.prod.protection.outlook.com (2603:10a6:600:350:cafe::f8) by LO4P265CA0241.outlook.office365.com (2603:10a6:600:350::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.13 via Frontend Transport; Thu, 12 Jan 2023 10:46:19 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT034.mail.protection.outlook.com (100.127.140.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Thu, 12 Jan 2023 10:46:18 +0000 Received: ("Tessian outbound 43b0faad5a68:v132"); Thu, 12 Jan 2023 10:46:18 +0000 Received: from c283985d8fa6.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E0702FA6-EF12-47B8-B412-95CD15ABFBC7.1; Thu, 12 Jan 2023 10:46:11 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c283985d8fa6.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 12 Jan 2023 10:46:11 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by PA4PR08MB7524.eurprd08.prod.outlook.com (2603:10a6:102:26d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Thu, 12 Jan 2023 10:46:04 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::b14f:1c13:afa:4eda]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::b14f:1c13:afa:4eda%3]) with mapi id 15.20.5986.018; Thu, 12 Jan 2023 10:46:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5da34080-9266-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RXkVS1Z8dOTT9hU+gAbGeKlrx/wJV4wLt/WInMX7XYY=; b=sisxAGioqjjSsVN1zcz+BJI1rAI+5uGKnIEtiHFI9A31/6fZhFVjmT9kX3boy7g5R3RjAwPqpzjhBILVzTE+vW338js3KGp5oYDDUMAf2FaDGmew+uyifJDKCHQedLM9mBw0F8nqrjxJWo2kpBe873vDAPBLj81ifAlbelmDL4Y= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: e9c38e77585c1013 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H97DUJEcXV4Iyr+exXCyZbxyAaRfOC80P3cboqaSgUHkaB644Tlp/nFxmqWpCx4uKgcRpXd8rS9y793+JA1qZJKlShGVHFxd8qkQ1nmBt+N4I4brzOpDYz7riKv8SPuSQ9ScnvrdnKdCKbWOTZgDpp6umWjCqyAdMOIau4ywi9/27myqm8UJbGjvCzStKb157d6F68zOOtxoo4EIl31YtkPpR1vIkTnwsyhwtIu2QMW+J/nIiBsN0YgBwMnABMWUbWvJ+UTbQrEmF290uZ42Kz6d1aDoUtKfRXYiUN0gmUKnEWU7iAyomfMXYmQ3tXMEZULkvgo06HYhtXftzxDO4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RXkVS1Z8dOTT9hU+gAbGeKlrx/wJV4wLt/WInMX7XYY=; b=dXbPLQNJCP2Bg1cMAtbpvgLYUjZdCRbg8CefUIaO1SUqUj0JCl2E6820UyeDOyQ1rhiY2yeRvuHZurmfC25c+D6z6S7LnRSgVlTT3WWlfpAe5S44gIk2rKfsB/EHndaATc5yXFx0cSDJyr2L8Ro28pal/+QtVmJnQtZqnCgpVe/0TYkeVctMAcPvnZgRW/0WoHGqo2i2bdfVPHKiZHMAbX8AkoBUuPp+ngDoRRsetVU5VKqUDlIQwCB1m1IGipS4T0sSuArjpQcIyAXYDGutsj2sUh9lJ2ln7o0Md6n62TARQ62exfra5VRzrB4WTfYEwYmNwP09HVrpgnVWd6mymQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RXkVS1Z8dOTT9hU+gAbGeKlrx/wJV4wLt/WInMX7XYY=; b=sisxAGioqjjSsVN1zcz+BJI1rAI+5uGKnIEtiHFI9A31/6fZhFVjmT9kX3boy7g5R3RjAwPqpzjhBILVzTE+vW338js3KGp5oYDDUMAf2FaDGmew+uyifJDKCHQedLM9mBw0F8nqrjxJWo2kpBe873vDAPBLj81ifAlbelmDL4Y= From: Luca Fancellu To: Julien Grall CC: Xen-devel , Wei Chen , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [RFC PATCH 1/8] xen/arm: enable SVE extension for Xen Thread-Topic: [RFC PATCH 1/8] xen/arm: enable SVE extension for Xen Thread-Index: AQHZJcp25sHFUmTjSUKVOX9zw5fwA66ZdWWAgAElHQA= Date: Thu, 12 Jan 2023 10:46:04 +0000 Message-ID: <85F9C725-816A-46EE-AD0C-2725AE13F14C@arm.com> References: <20230111143826.3224-1-luca.fancellu@arm.com> <20230111143826.3224-2-luca.fancellu@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.300.101.1.3) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|PA4PR08MB7524:EE_|AM7EUR03FT034:EE_|PAXPR08MB7393:EE_ X-MS-Office365-Filtering-Correlation-Id: fcb03640-3901-45ba-2c47-08daf48a3c94 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 2oUBsQEJOXv1uQ1zMVqWcpFVKPyRf3WrxrF1TK2tvc8IpgTmaONbfVpAce3TklaNQa762Z2icjGYWKSL1OUxcl53LawwxP9mdBut2dhmhO4kuADrWk2g+dl3hf65EH6niLvwzXAV0i+nXaYItvXoWHogsyKSEH97ba0n48EPteeN/RRaBUDtkxmRu98Vi6wBlUPrqggOP7SlXZ0ppbdpbl6V3EJ0iAYiwCtbU2gpS7SeQajgjZskYQHT+i+4CkTeD3fc7HxZS79uM0NahkFDFXV3+KmthVkrlloaS1xs/5ZY+CLT9HnLVlpplxxZDCHhV7p+nRk/hmOL4FpbI8HHSVokw4JI0dy7nK4VCZjQ2KAWUp4Mpc3ZiHTkKyNYSr54f5FGdHRDJjpSo2sTuBWfdfMa1cWpzl83ahTlfUXxNQnrW70ArNNsnpSLafWFjsnbux056vpk0VLpYcAueTPDFFCBPCbXS4rUidFdsROcx1OHmHpYkMh+AGsIrdavoUkRSvWmVBGz9EW0q4uoN8DS5aT4aZYmKzg5Cx1TTsq01GtwHR03q9w6hZwtRqTxj0R2QA9F2NmySmRgBtKrwoKu0khxrtvb7Z5e3F/9kj6chK13y+K3TRnW+QFHKnbbyYDAkAqHnGWPF2TuWbPnNhsY2VsrBfLIIsWsZasWdqQM6spBwestC+3H1gpQaXHFUQa5kf+mNn+Imx6/Ri1zt6wsR64Php4m3UYv33hzsUR4r1E= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(396003)(346002)(376002)(136003)(39860400002)(451199015)(53546011)(41300700001)(86362001)(6506007)(83380400001)(122000001)(38070700005)(6486002)(26005)(6512007)(8936002)(478600001)(186003)(38100700002)(66946007)(66446008)(91956017)(8676002)(71200400001)(4326008)(5660300002)(66556008)(33656002)(36756003)(64756008)(76116006)(66476007)(6916009)(2906002)(316002)(2616005)(54906003)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <2B2465419E64F24A980D173705DB6E7A@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB7524 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT034.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 8e11201b-7912-4b76-55cd-08daf48a3458 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: be72i6ouA6dmbyuf05p3Wo2iWJEy+oXW3Xd2JMbMWPYCShw6udXDBpiWkjJvKhibH/eWXXJHN1t2OLoqDYEPRi3NlVkYMhtoMmYDDsOyt8iqEZOCjD23dOgOJeS8fYJ5rgUGMvPvA/wEgetQL7/V+BhFukQG23LES/aAGCKr3S3siJfkJg2NmiNKgkqzHHJuPIx6dNpUVSkqXD2/yznvGnC9WxkJJSBSKTVhqA2GowlPUu6SUskrtGaOSKGYnMJc4Eg6yEOMemhzrJQuLn/YnYCTZlXpcfXiQjaMtxpIbh0BRGZhFRqtNh5k3f+DEdrOdlczHp/lPjfgH5JBj4bn/msU3jtliFygQ7rQxNlqYvv4x2y4MdErU12J1+JWpOhmjoUkKyg6QuCCkh3jQc+9wHuoO7yp5RjOXFA9FNphfA9dMT+uU+SCivRI1xQ1eTxOOJskQKm/sx8WlFxGCSAJfFuIxrXaC95QXybTYoj3s8+NPes2e2oGYRTES8rBDi0JuPNzwNHVWpDd8Cc5ii4ErvqWHQG0yjyuDReUsStqgX6y8XOU9PjlKmJrBlTnr5val7WqLCWwndyklv1uU0Vi+tCee7a86DXQiv3tXb1ZNoPfQgiMKaCqFNX7oYXTcbFCEYVm1paFnR8niNKemTKU+VPleQLXzAnq/GeQXtNXnmifdb08dHN1R79yHE0B2xwW0AsCDw0b8pV15sCkAg9ijw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(376002)(39860400002)(346002)(451199015)(46966006)(36840700001)(40470700004)(53546011)(26005)(86362001)(6512007)(40480700001)(186003)(83380400001)(4326008)(8676002)(33656002)(336012)(47076005)(6862004)(70206006)(70586007)(8936002)(36756003)(2616005)(40460700003)(81166007)(5660300002)(2906002)(478600001)(316002)(356005)(54906003)(41300700001)(82310400005)(6506007)(36860700001)(82740400003)(6486002)(107886003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 10:46:18.4729 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fcb03640-3901-45ba-2c47-08daf48a3c94 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT034.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7393 DQoNCj4gT24gMTEgSmFuIDIwMjMsIGF0IDE3OjE2LCBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4u b3JnPiB3cm90ZToNCj4gDQo+IEhpIEx1Y2EsDQo+IA0KPiBBcyB0aGlzIGlzIGFuIFJGQywgSSB3 aWxsIGJlIG1vc3RseSBtYWtpbmcgZ2VuZXJhbCBjb21tZW50cy4NCg0KSGkgSnVsaWVuLA0KDQpU aGFuayB5b3UuDQoNCj4gDQo+IE9uIDExLzAxLzIwMjMgMTQ6MzgsIEx1Y2EgRmFuY2VsbHUgd3Jv dGU6DQo+PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL2RvbWFpbi5jIGIveGVuL2FyY2gvYXJt L2RvbWFpbi5jDQo+PiBpbmRleCA5OTU3N2FkYjZjNjkuLjhlYTM4NDNlYThlOCAxMDA2NDQNCj4+ IC0tLSBhL3hlbi9hcmNoL2FybS9kb21haW4uYw0KPj4gKysrIGIveGVuL2FyY2gvYXJtL2RvbWFp bi5jDQo+PiBAQCAtMTgxLDYgKzE4MSw4IEBAIHN0YXRpYyB2b2lkIGN0eHRfc3dpdGNoX3RvKHN0 cnVjdCB2Y3B1ICpuKQ0KPj4gICAgICAvKiBWR0lDICovDQo+PiAgICAgIGdpY19yZXN0b3JlX3N0 YXRlKG4pOw0KPj4gICsgICAgV1JJVEVfU1lTUkVHKG4tPmFyY2guY3B0cl9lbDIsIENQVFJfRUwy KTsNCj4gDQo+IFNob3VsZG4ndCB0aGlzIG5lZWQgYW4gaXNiKCkgYWZ0ZXJ3YXJkcyBkbyBlbnN1 cmUgdGhhdCBhbnkgcHJldmlvdXNseSB0cmFwcGVkIHdpbGwgYmUgYWNjZXNzaWJsZT8NCg0KWWVz IHlvdSBhcmUgcmlnaHQsIHdvdWxkIGl0IGJlIG9rIGZvciB5b3UgaWYgSSBtb3ZlIHRoaXMgYmVm b3JlIGdpY19yZXN0b3JlX3N0YXRlIGJlY2F1c2UgaXQgaW5zaWRlDQpoYXMgYW4gaXNiKCk/IFRo aXMgdG8gbGltaXQgdGhlIGlzYigpIHVzYWdlLiBJIGNvdWxkIHB1dCBhbHNvIGEgY29tbWVudCB0 byBkb27igJl0IGZvcmdldCBpdC4NCg0KT3RoZXJ3aXNlIEkgd2lsbCBhZGQgdGhlIGJhcnJpZXIu DQoNCg0KPiANCj4gWy4uLl0NCj4gDQo+PiBAQCAtMTIyLDYgKzEzNyw3IEBAIF9faW5pdGNhbGwo dXBkYXRlX3NlcnJvcnNfY3B1X2NhcHMpOw0KPj4gICAgdm9pZCBpbml0X3RyYXBzKHZvaWQpDQo+ PiAgew0KPj4gKyAgICByZWdpc3Rlcl90IGNwdHJfYml0cyA9IGdldF9kZWZhdWx0X2NwdHJfZmxh Z3MoKTsNCj4+ICAgICAgLyoNCj4+ICAgICAgICogU2V0dXAgSHlwIHZlY3RvciBiYXNlLiBOb3Rl IHRoZXkgbWlnaHQgZ2V0IHVwZGF0ZWQgd2l0aCB0aGUNCj4+ICAgICAgICogYnJhbmNoIHByZWRp Y3RvciBoYXJkZW5pbmcuDQo+PiBAQCAtMTM1LDE3ICsxNTEsMTUgQEAgdm9pZCBpbml0X3RyYXBz KHZvaWQpDQo+PiAgICAgIC8qIFRyYXAgQ1AxNSBjMTUgdXNlZCBmb3IgaW1wbGVtZW50YXRpb24g ZGVmaW5lZCByZWdpc3RlcnMgKi8NCj4+ICAgICAgV1JJVEVfU1lTUkVHKEhTVFJfVCgxNSksIEhT VFJfRUwyKTsNCj4+ICAtICAgIC8qIFRyYXAgYWxsIGNvcHJvY2Vzc29yIHJlZ2lzdGVycyAoMC0x MykgZXhjZXB0IGNwMTAgYW5kDQo+PiAtICAgICAqIGNwMTEgZm9yIFZGUC4NCj4+IC0gICAgICoN Cj4+IC0gICAgICogLyFcIEFsbCBjb3Byb2Nlc3NvcnMgZXhjZXB0IGNwMTAgYW5kIGNwMTEgY2Fu bm90IGJlIHVzZWQgaW4gWGVuLg0KPj4gLSAgICAgKg0KPj4gLSAgICAgKiBPbiBBUk02NCB0aGUg VENQeCBiaXRzIHdoaWNoIHdlIHNldCBoZXJlICgwLi45LDEyLDEzKSBhcmUgYWxsDQo+PiAtICAg ICAqIFJFUzEsIGkuZS4gdGhleSB3b3VsZCB0cmFwIHdoZXRoZXIgd2UgZGlkIHRoaXMgd3JpdGUg b3Igbm90Lg0KPj4gKyNpZmRlZiBDT05GSUdfQVJNNjRfU1ZFDQo+PiArICAgIC8qDQo+PiArICAg ICAqIERvbid0IHRyYXAgU1ZFIG5vdywgWGVuIG1pZ2h0IG5lZWQgdG8gYWNjZXNzIFpDUiByZWcg aW4gY3B1ZmVhdHVyZSBjb2RlLA0KPj4gKyAgICAgKiB0cmFwcGluZyBhZ2FpbiBvciBub3Qgd2ls bCBiZSBoYW5kbGVkIG9uIHZjcHUgY3JlYXRpb24vc2NoZWR1bGluZyBsYXRlcg0KPj4gICAgICAg Ki8NCj4gDQo+IEluc3RlYWQgb2YgZW5hYmxlIGJ5IGRlZmF1bHQgYXQgYm9vdCwgY2FuIHdlIHRy eSB0byBlbmFibGUvZGlzYWJsZSBvbmx5IHdoZW4gdGhpcyBpcyBzdHJpY3RseSBuZWVkZWQ/DQoN ClllcyB3ZSBjb3VsZCB1bi10cmFwIGluc2lkZSBjb21wdXRlX21heF96Y3IoKSBqdXN0IGJlZm9y ZSBhY2Nlc3NpbmcgU1ZFIHJlc291cmNlcyBhbmQgdHJhcCBpdA0KYWdhaW4gd2hlbiBmaW5pc2hl ZC4gV291bGQgaXQgYmUgb2sgZm9yIHlvdSB0aGlzIGFwcHJvYWNoPw0KDQo+IA0KPj4gLSAgICBX UklURV9TWVNSRUcoKEhDUFRSX0NQX01BU0sgJiB+KEhDUFRSX0NQKDEwKSB8IEhDUFRSX0NQKDEx KSkpIHwNCj4+IC0gICAgICAgICAgICAgICAgIEhDUFRSX1RUQSB8IEhDUFRSX1RBTSwNCj4+IC0g ICAgICAgICAgICAgICAgIENQVFJfRUwyKTsNCj4+ICsgICAgY3B0cl9iaXRzICY9IH5IQ1BUUl9D UCg4KTsNCj4+ICsjZW5kaWYNCj4+ICsNCj4+ICsgICAgV1JJVEVfU1lTUkVHKGNwdHJfYml0cywg Q1BUUl9FTDIpOw0KPj4gICAgICAgIC8qDQo+PiAgICAgICAqIENvbmZpZ3VyZSBIQ1JfRUwyIHdp dGggdGhlIGJhcmUgbWluaW11bSB0byBydW4gWGVuIHVudGlsIGEgZ3Vlc3QNCj4gDQo+IENoZWVy cywNCj4gLS0gDQo+IEp1bGllbiBHcmFsbA0KDQo= From xen-devel-bounces@lists.xenproject.org Thu Jan 12 10:54:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 10:54:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475982.737927 (Exim 4.92) (envelope-from ) id 1pFvEF-0004hJ-32; Thu, 12 Jan 2023 10:54:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475982.737927; Thu, 12 Jan 2023 10:54:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFvEF-0004hC-0E; Thu, 12 Jan 2023 10:54:39 +0000 Received: by outflank-mailman (input) for mailman id 475982; Thu, 12 Jan 2023 10:54:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFvED-0004h4-KG for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 10:54:37 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2061.outbound.protection.outlook.com [40.107.6.61]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7fbd96b7-9267-11ed-b8d0-410ff93cb8f0; Thu, 12 Jan 2023 11:54:34 +0100 (CET) Received: from FR3P281CA0034.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::20) by DBBPR08MB6249.eurprd08.prod.outlook.com (2603:10a6:10:203::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Thu, 12 Jan 2023 10:54:32 +0000 Received: from VI1EUR03FT013.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:1c:cafe::61) by FR3P281CA0034.outlook.office365.com (2603:10a6:d10:1c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6023.6 via Frontend Transport; Thu, 12 Jan 2023 10:54:32 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT013.mail.protection.outlook.com (100.127.145.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.13 via Frontend Transport; Thu, 12 Jan 2023 10:54:31 +0000 Received: ("Tessian outbound 3ad958cd7492:v132"); Thu, 12 Jan 2023 10:54:31 +0000 Received: from a69b6cc4c072.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id BE37EF1C-B400-4D5C-8F7C-709C394F5BA7.1; Thu, 12 Jan 2023 10:54:22 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a69b6cc4c072.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 12 Jan 2023 10:54:22 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by DB9PR08MB9491.eurprd08.prod.outlook.com (2603:10a6:10:45a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.19; Thu, 12 Jan 2023 10:54:18 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::b14f:1c13:afa:4eda]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::b14f:1c13:afa:4eda%3]) with mapi id 15.20.5986.018; Thu, 12 Jan 2023 10:54:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7fbd96b7-9267-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1Usn1RNUaOnGhr71Cg3aFmCJpGX2mSsNaj4aK0MYhhM=; b=CGV/wc0m3GApAlBhpspll+ZM+rze3bFj4wGke56+VfjL2ZMiBpjE90S0jXqwubp5znssNQw8ugfo8upN3zJXx2RZttNqO2ycPgdC1rhjWP1hX4sQONIhvWKI+bosc3EuiT/yWayY8RwuR0ixtLB/p93ghYxPtLMhueiQVK5pPp4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: cf1a4a8dfa4e666b X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QyGaUG1/heBiTTP3HK3taZjLDpBpg8juZarHogzcyv2zAI0zvboxaPDg0QQFwm7eZkPlHB0RRTZ23DOqSov3QhLSbQR412Y3NXcNWNex+/+AfZhaEAXQBH0Mdp11ZOQzA8ZuVYQ/6vtkR0DOT1qQoUZecLQk4PXwGMPXAp6rEjc4zmcAjwfStpPIaJ3YD5H1/mcmBauB63hoTXypIfxPrzd/Iy244OVEXyuEcsIX7219Rw9K8WojnRwsSv/uh7HGfsUTKoQrdKAivazSvcl+hZ8MMuAL+ukQL8lmjggFtpWC6V25oEBNCRTZGWzKhfsTGPV0xWat5h/UVgrgXinW7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1Usn1RNUaOnGhr71Cg3aFmCJpGX2mSsNaj4aK0MYhhM=; b=EahDhZJnn8YqfF5TReKFJ6byGsf6jDHP/Ex/zhLmHg+7Xdrr241nZ25r48SJr2/pyH8BG1BGN11Yi/IO/HwCwfzQxDHaY05OBk0cfhPnFfm9Jdwa08cTDhhNgzkic3/GxFR4xo3IIs2PcQEKd/om6/JbxN+Ufwyl5otDfG54sDX7gIRDvgugI5jgaFOet/aGpmf6Ex2WkGxzCHcxNC7JwQX1VGGOLp/u6f6EQv4sCxXUpmySC3+Z6vHb5/SftzHzi+T9liXm03I5UWofqaC9QNaGnKl5kDmTsTUhJxKBiPTlBn9JxYY9ZtwueqUhMNLVx97Ho1oqo0y8Ib8Z6DZFPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1Usn1RNUaOnGhr71Cg3aFmCJpGX2mSsNaj4aK0MYhhM=; b=CGV/wc0m3GApAlBhpspll+ZM+rze3bFj4wGke56+VfjL2ZMiBpjE90S0jXqwubp5znssNQw8ugfo8upN3zJXx2RZttNqO2ycPgdC1rhjWP1hX4sQONIhvWKI+bosc3EuiT/yWayY8RwuR0ixtLB/p93ghYxPtLMhueiQVK5pPp4= From: Luca Fancellu To: Julien Grall CC: Xen-devel , Wei Chen , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: Re: [RFC PATCH 2/8] xen/arm: add sve_vl_bits field to domain Thread-Topic: [RFC PATCH 2/8] xen/arm: add sve_vl_bits field to domain Thread-Index: AQHZJcqDGP094PnLfE+ehr42WQkWI66ZeH+AgAEkTQA= Date: Thu, 12 Jan 2023 10:54:16 +0000 Message-ID: <9168CB2A-A1F1-43E0-9DAD-BB31AD3979E0@arm.com> References: <20230111143826.3224-1-luca.fancellu@arm.com> <20230111143826.3224-3-luca.fancellu@arm.com> <91b5c7db-ec9b-efa6-f5cf-dc5e8b176db6@xen.org> In-Reply-To: <91b5c7db-ec9b-efa6-f5cf-dc5e8b176db6@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.300.101.1.3) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|DB9PR08MB9491:EE_|VI1EUR03FT013:EE_|DBBPR08MB6249:EE_ X-MS-Office365-Filtering-Correlation-Id: c375eaf4-f9b3-44c5-6f08-08daf48b6274 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: iJ4KfzT0vmwP+dJ3H0HDZ37pYReY3hGwxT5qv/E169o5PzBzl6LTiVYCS6ckRxa+iLn5/SFePvjRkp+4LJeHuR8z33v/3Uc0a4aOzDHd+Q84Umv6joeF1mEny3HiElVRiV4UwrbZLCQUXoKDpC6ye4iajlqoM+gngeEFgcVHQB7Q4bWZOKTd6kn/CdU3PBt09tZ67WRrkeV1/I4cYsNJJQbsLXh0v7lQ7xtnd8ejsNJ/+e7pPV7pA6Hpd288o1nnENprS0083/z/KA7JgFAmfKQhxZxQrhISb4orkVOlLV/Gm+dbGox/ZM9QDmQHPLZr2WWuowHBCUQJE74AfwpWMi75fOuxihvCHnNA4Czxg8rP9VZWQlAvHyF1kYHlCpsINx+SnRIVIMWnToCan0jHbmJBP5NndLhDlhLSUnDCHKDvXiXyW2oDNgyAejOmGZmzU6zH10AjFph6BL5yHCaWstcQzh9wxq5ZZqJCOHyaFDI6LZb56j8LcZplm1vlktBnbhLyhl1BerbLoTwY71W/yifTDCivSFV3Rj2zQWRtJXhYhQOdDR0JjEwITqMX1ilYVE0t9woESbpcvvA+AY8Mv1vUEmQ//G/gEmnJhNEpvtIanqNcN1gf4oKtiio9uG5kGBLJNtvsk7NPL0/uPoKfmdPuFo/w1a7ObOxCJNbNA3me0JUo97m602RlOQC9ZXq9Cawi+NYMrgsYWnBMkhJ20LE550rPwxTrI8rwM9RArVc= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(136003)(346002)(376002)(366004)(451199015)(71200400001)(6486002)(2616005)(478600001)(38070700005)(83380400001)(316002)(186003)(6916009)(53546011)(6506007)(54906003)(26005)(6512007)(66476007)(86362001)(66556008)(64756008)(66446008)(41300700001)(8936002)(4326008)(91956017)(76116006)(66946007)(5660300002)(8676002)(2906002)(38100700002)(122000001)(36756003)(33656002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <6D9760FB910CB84997646CDE4B8EA403@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB9491 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 39757535-3d5c-48fa-2b8c-08daf48b5975 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3QyOy5Fd1ynDajFZbylxhAqDtGxEGi4P1Z1j1jY4WqpTKxhLLTMTxgUFqPyYeOOcREOz9pw+DgyrBw/8DpJZtyN99DnRo5l110DmN5jXKXEsgIMsq8JrPpHDoy9g7bZjApFYSYmAhXLzEVXt0Kf5xtW5eNIj0zQkPl7EZYm7o/6Vi5yLpNXmnuWF23Vw86gy20P9DPJseUfXtfZyBdC2pSJ+yNqASIs78qLnEY36x+6N1TAyvQ+2fl4PLcWE0bgr5seZXnbVGzTmDQGQCO5FuLVXGWIazmqZDfFcyFrKZAN9e38qPBZ0BwIxEWJk8ZVURkbQ/zQxK4XBuvq8ZQdzBUjO9XzVFtHXKyTAHKCOM/7xMXo8nMOWHwhzMaVYIOCbbTW+O5nOJ9JNi3LQiNsqNhYCsXbHXGZ8x1utiYx2y93gYHSkRLkmzQioaNaxRtb0FnysUsvmV8VVkTJZ2/24rPwpf1HuUbuKVW1pEi0YiM93qPlzHb+qxPNHqmaSQ+veh2lSgIapg67u8RO/biZ/khpeYP+ajaqUE9pVfT+j/LHfi+1XRckoDCXnX3ysMc/quSKnXqx74HRL0QqsFHgp4JpBdlAZRJvhfuW/xHWul85ts3rpGtLLcc4wm+q/A97w4w9nob5mTavY4VaKYiJ+r9pEAWb+4OVEnc48nH6/2sn7+Yj65A+rS2Ie+EQQF+Y7tZmzBRJafw8Mg2Ga0ZNslA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(396003)(346002)(376002)(451199015)(40470700004)(36840700001)(46966006)(8676002)(478600001)(70206006)(70586007)(336012)(2906002)(41300700001)(82310400005)(82740400003)(36756003)(4326008)(5660300002)(36860700001)(40460700003)(81166007)(83380400001)(6862004)(8936002)(6486002)(356005)(6512007)(26005)(6506007)(53546011)(33656002)(2616005)(54906003)(316002)(40480700001)(47076005)(86362001)(186003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 10:54:31.4213 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c375eaf4-f9b3-44c5-6f08-08daf48b6274 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6249 DQoNCj4gT24gMTEgSmFuIDIwMjMsIGF0IDE3OjI3LCBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4u b3JnPiB3cm90ZToNCj4gDQo+IEhpIEx1Y2EsDQo+IA0KPiBPbiAxMS8wMS8yMDIzIDE0OjM4LCBM dWNhIEZhbmNlbGx1IHdyb3RlOg0KPj4gQWRkIHN2ZV92bF9iaXRzIGZpZWxkIHRvIGFyY2hfZG9t YWluIGFuZCB4ZW5fYXJjaF9kb21haW5jb25maWcNCj4+IHN0cnVjdHVyZSwgdG8gYWxsb3cgdGhl IGRvbWFpbiB0byBoYXZlIGFuIGluZm9ybWF0aW9uIGFib3V0IHRoZQ0KPj4gU1ZFIGZlYXR1cmUg YW5kIHRoZSBudW1iZXIgb2YgU1ZFIHJlZ2lzdGVyIGJpdHMgdGhhdCBhcmUgYWxsb3dlZA0KPj4g Zm9yIHRoaXMgZG9tYWluLg0KPj4gVGhlIGZpZWxkIGlzIHVzZWQgYWxzbyB0byBhbGxvdyBvciBm b3JiaWQgYSBkb21haW4gdG8gdXNlIFNWRSwNCj4+IGJlY2F1c2UgYSB2YWx1ZSBlcXVhbCB0byB6 ZXJvIG1lYW5zIHRoZSBndWVzdCBpcyBub3QgYWxsb3dlZCB0bw0KPj4gdXNlIHRoZSBmZWF0dXJl Lg0KPj4gV2hlbiB0aGUgZ3Vlc3QgaXMgYWxsb3dlZCB0byB1c2UgU1ZFLCB0aGUgemNyX2VsMiBy ZWdpc3RlciBpcw0KPj4gdXBkYXRlZCBvbiBjb250ZXh0IHN3aXRjaCB0byByZXN0aWN0IHRoZSBk b21haW4gb24gdGhlIGFsbG93ZWQNCj4+IG51bWJlciBvZiBiaXRzIGNob3NlbiwgdGhpcyB2YWx1 ZSBpcyB0aGUgbWluaW11bSBhbW9uZyB0aGUgY2hvc2VuDQo+PiB2YWx1ZSBhbmQgdGhlIHBsYXRm b3JtIHN1cHBvcnRlZCB2YWx1ZS4NCj4+IFNpZ25lZC1vZmYtYnk6IEx1Y2EgRmFuY2VsbHUgPGx1 Y2EuZmFuY2VsbHVAYXJtLmNvbT4NCj4+IC0tLQ0KPj4gIHhlbi9hcmNoL2FybS9hcm02NC9zdmUu YyAgICAgICAgICAgICB8ICA5ICsrKysrKw0KPj4gIHhlbi9hcmNoL2FybS9kb21haW4uYyAgICAg ICAgICAgICAgICB8IDQ1ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysNCj4+ICB4ZW4vYXJj aC9hcm0vaW5jbHVkZS9hc20vYXJtNjQvc3ZlLmggfCAxMiArKysrKysrKw0KPj4gIHhlbi9hcmNo L2FybS9pbmNsdWRlL2FzbS9kb21haW4uaCAgICB8ICA2ICsrKysNCj4+ICB4ZW4vaW5jbHVkZS9w dWJsaWMvYXJjaC1hcm0uaCAgICAgICAgfCAgMiArKw0KPj4gIHhlbi9pbmNsdWRlL3B1YmxpYy9k b21jdGwuaCAgICAgICAgICB8ICAyICstDQo+PiAgNiBmaWxlcyBjaGFuZ2VkLCA3NSBpbnNlcnRp b25zKCspLCAxIGRlbGV0aW9uKC0pDQo+PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL2FybTY0 L3N2ZS5jIGIveGVuL2FyY2gvYXJtL2FybTY0L3N2ZS5jDQo+PiBpbmRleCAzMjYzODkyNzgyOTIu LmI3Njk1ODM0ZjRiYSAxMDA2NDQNCj4+IC0tLSBhL3hlbi9hcmNoL2FybS9hcm02NC9zdmUuYw0K Pj4gKysrIGIveGVuL2FyY2gvYXJtL2FybTY0L3N2ZS5jDQo+PiBAQCAtNiw2ICs2LDcgQEANCj4+ ICAgKi8NCj4+ICAgICNpbmNsdWRlIDx4ZW4vdHlwZXMuaD4NCj4+ICsjaW5jbHVkZSA8YXNtL2Nw dWZlYXR1cmUuaD4NCj4+ICAjaW5jbHVkZSA8YXNtL2FybTY0L3N2ZS5oPg0KPj4gICNpbmNsdWRl IDxhc20vYXJtNjQvc3lzcmVncy5oPg0KPj4gIEBAIC0zNiwzICszNywxMSBAQCByZWdpc3Rlcl90 IHZsX3RvX3pjcih1aW50MTZfdCB2bCkNCj4+ICB7DQo+PiAgICAgIHJldHVybiAoKHZsIC8gU1ZF X1ZMX01VTFRJUExFX1ZBTCkgLSAxVSkgJiBaQ1JfRUx4X0xFTl9NQVNLOw0KPj4gIH0NCj4+ICsN Cj4+ICsvKiBHZXQgdGhlIHN5c3RlbSBzYW5pdGl6ZWQgdmFsdWUgZm9yIFZMIGluIGJpdHMgKi8N Cj4+ICt1aW50MTZfdCBnZXRfc3lzX3ZsX2xlbih2b2lkKQ0KPj4gK3sNCj4+ICsgICAgLyogWkNS X0VMeCBsZW4gZmllbGQgaXMgKChsZW4rMSkgKiAxMjgpID0gdmVjdG9yIGJpdHMgbGVuZ3RoICov DQo+PiArICAgIHJldHVybiAoKHN5c3RlbV9jcHVpbmZvLnpjcjY0LmJpdHNbMF0gJiBaQ1JfRUx4 X0xFTl9NQVNLKSArIDFVKSAqDQo+PiArICAgICAgICAgICAgU1ZFX1ZMX01VTFRJUExFX1ZBTDsN Cj4+ICt9DQo+PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL2RvbWFpbi5jIGIveGVuL2FyY2gv YXJtL2RvbWFpbi5jDQo+PiBpbmRleCA4ZWEzODQzZWE4ZTguLjI3ZjM4NzI5MzAyYiAxMDA2NDQN Cj4+IC0tLSBhL3hlbi9hcmNoL2FybS9kb21haW4uYw0KPj4gKysrIGIveGVuL2FyY2gvYXJtL2Rv bWFpbi5jDQo+PiBAQCAtMTMsNiArMTMsNyBAQA0KPj4gICNpbmNsdWRlIDx4ZW4vd2FpdC5oPg0K Pj4gICAgI2luY2x1ZGUgPGFzbS9hbHRlcm5hdGl2ZS5oPg0KPj4gKyNpbmNsdWRlIDxhc20vYXJt NjQvc3ZlLmg+DQo+PiAgI2luY2x1ZGUgPGFzbS9jcHVlcnJhdGEuaD4NCj4+ICAjaW5jbHVkZSA8 YXNtL2NwdWZlYXR1cmUuaD4NCj4+ICAjaW5jbHVkZSA8YXNtL2N1cnJlbnQuaD4NCj4+IEBAIC0x ODMsNiArMTg0LDExIEBAIHN0YXRpYyB2b2lkIGN0eHRfc3dpdGNoX3RvKHN0cnVjdCB2Y3B1ICpu KQ0KPj4gICAgICAgIFdSSVRFX1NZU1JFRyhuLT5hcmNoLmNwdHJfZWwyLCBDUFRSX0VMMik7DQo+ PiAgKyNpZmRlZiBDT05GSUdfQVJNNjRfU1ZFDQo+PiArICAgIGlmICggaXNfc3ZlX2RvbWFpbihu LT5kb21haW4pICkNCj4+ICsgICAgICAgIFdSSVRFX1NZU1JFRyhuLT5hcmNoLnpjcl9lbDIsIFpD Ul9FTDIpOw0KPj4gKyNlbmRpZg0KPiANCj4gSSB3b3VsZCBhY3R1YWxseSBleHBlY3QgdGhhdCBp c19zdmVfZG9tYWluKCkgcmV0dXJucyBmYWxzZSB3aGVuIHRoZSBTVkUgaXMgbm90IGVuYWJsZWQu IFNvIGNhbiB3ZSBzaW1wbHkgcmVtb3ZlIHRoZSAjaWZkZWY/DQoNCkkgd2FzIHRyaWNrZWQgYnkg aXQgdG9vLCB0aGUgYXJtMzIgYnVpbGQgd2lsbCBmYWlsIGJlY2F1c2UgaXQgZG9lc27igJl0IGtu b3cgWkNSX0VMMg0KDQo+IA0KPj4gKw0KPj4gICAgICAvKiBWRlAgKi8NCj4+ICAgICAgdmZwX3Jl c3RvcmVfc3RhdGUobik7DQo+PiAgQEAgLTU1MSw2ICs1NTcsMTEgQEAgaW50IGFyY2hfdmNwdV9j cmVhdGUoc3RydWN0IHZjcHUgKnYpDQo+PiAgICAgIHYtPmFyY2gudm1waWRyID0gTVBJRFJfU01Q IHwgdmNwdWlkX3RvX3ZhZmZpbml0eSh2LT52Y3B1X2lkKTsNCj4+ICAgICAgICB2LT5hcmNoLmNw dHJfZWwyID0gZ2V0X2RlZmF1bHRfY3B0cl9mbGFncygpOw0KPj4gKyAgICBpZiAoIGlzX3N2ZV9k b21haW4odi0+ZG9tYWluKSApDQo+PiArICAgIHsNCj4+ICsgICAgICAgIHYtPmFyY2guY3B0cl9l bDIgJj0gfkhDUFRSX0NQKDgpOw0KPj4gKyAgICAgICAgdi0+YXJjaC56Y3JfZWwyID0gdmxfdG9f emNyKHYtPmRvbWFpbi0+YXJjaC5zdmVfdmxfYml0cyk7DQo+PiArICAgIH0NCj4+ICAgICAgICB2 LT5hcmNoLmhjcl9lbDIgPSBnZXRfZGVmYXVsdF9oY3JfZmxhZ3MoKTsNCj4+ICBAQCAtNTk1LDYg KzYwNiw3IEBAIGludCBhcmNoX3Nhbml0aXNlX2RvbWFpbl9jb25maWcoc3RydWN0IHhlbl9kb21j dGxfY3JlYXRlZG9tYWluICpjb25maWcpDQo+PiAgICAgIHVuc2lnbmVkIGludCBtYXhfdmNwdXM7 DQo+PiAgICAgIHVuc2lnbmVkIGludCBmbGFnc19yZXF1aXJlZCA9IChYRU5fRE9NQ1RMX0NERl9o dm0gfCBYRU5fRE9NQ1RMX0NERl9oYXApOw0KPj4gICAgICB1bnNpZ25lZCBpbnQgZmxhZ3Nfb3B0 aW9uYWwgPSAoWEVOX0RPTUNUTF9DREZfaW9tbXUgfCBYRU5fRE9NQ1RMX0NERl92cG11KTsNCj4+ ICsgICAgdW5zaWduZWQgaW50IHN2ZV92bF9iaXRzID0gY29uZmlnLT5hcmNoLnN2ZV92bF9iaXRz Ow0KPj4gICAgICAgIGlmICggKGNvbmZpZy0+ZmxhZ3MgJiB+ZmxhZ3Nfb3B0aW9uYWwpICE9IGZs YWdzX3JlcXVpcmVkICkNCj4+ICAgICAgew0KPj4gQEAgLTYwMyw2ICs2MTUsMzYgQEAgaW50IGFy Y2hfc2FuaXRpc2VfZG9tYWluX2NvbmZpZyhzdHJ1Y3QgeGVuX2RvbWN0bF9jcmVhdGVkb21haW4g KmNvbmZpZykNCj4+ICAgICAgICAgIHJldHVybiAtRUlOVkFMOw0KPj4gICAgICB9DQo+PiAgKyAg ICAvKiBDaGVjayBmZWF0dXJlIGZsYWdzICovDQo+PiArICAgIGlmICggc3ZlX3ZsX2JpdHMgPiAw ICkgew0KPj4gKyAgICAgICAgdW5zaWduZWQgaW50IHpjcl9tYXhfYml0czsNCj4+ICsNCj4+ICsg ICAgICAgIGlmICggIWNwdV9oYXNfc3ZlICkNCj4+ICsgICAgICAgIHsNCj4+ICsgICAgICAgICAg ICBkcHJpbnRrKFhFTkxPR19JTkZPLCAiU1ZFIGlzIHVuc3VwcG9ydGVkIG9uIHRoaXMgbWFjaGlu ZS5cbiIpOw0KPj4gKyAgICAgICAgICAgIHJldHVybiAtRUlOVkFMOw0KPj4gKyAgICAgICAgfQ0K Pj4gKyAgICAgICAgZWxzZSBpZiAoICFpc192bF92YWxpZChzdmVfdmxfYml0cykgKQ0KPj4gKyAg ICAgICAgew0KPj4gKyAgICAgICAgICAgIGRwcmludGsoWEVOTE9HX0lORk8sICJVbnN1cHBvcnRl ZCBTVkUgdmVjdG9yIGxlbmd0aCAoJXUpXG4iLA0KPj4gKyAgICAgICAgICAgICAgICAgICAgc3Zl X3ZsX2JpdHMpOw0KPj4gKyAgICAgICAgICAgIHJldHVybiAtRUlOVkFMOw0KPj4gKyAgICAgICAg fQ0KPj4gKyAgICAgICAgLyoNCj4+ICsgICAgICAgICAqIGdldF9zeXNfdmxfbGVuKCkgaXMgdGhl IGNvbW1vbiBzYWZlIHZhbHVlIGFtb25nIGFsbCBjcHVzLCBzbyBpZiB0aGUNCj4+ICsgICAgICAg ICAqIHZhbHVlIHNwZWNpZmllZCBieSB0aGUgdXNlciBpcyBhYm92ZSB0aGF0IHZhbHVlLCB1c2Ug dGhlIHNhZmUgdmFsdWUNCj4+ICsgICAgICAgICAqIGluc3RlYWQuDQo+PiArICAgICAgICAgKi8N Cj4+ICsgICAgICAgIHpjcl9tYXhfYml0cyA9IGdldF9zeXNfdmxfbGVuKCk7DQo+PiArICAgICAg ICBpZiAoIHN2ZV92bF9iaXRzID4gemNyX21heF9iaXRzICkNCj4+ICsgICAgICAgIHsNCj4+ICsg ICAgICAgICAgICBjb25maWctPmFyY2guc3ZlX3ZsX2JpdHMgPSB6Y3JfbWF4X2JpdHM7DQo+PiAr ICAgICAgICAgICAgZHByaW50ayhYRU5MT0dfSU5GTywNCj4+ICsgICAgICAgICAgICAgICAgICAg ICJTVkUgdmVjdG9yIGxlbmd0aCBsb3dlcmVkIHRvICV1LCBzYWZlIHZhbHVlIGFtb25nIENQVXNc biIsDQo+PiArICAgICAgICAgICAgICAgICAgICB6Y3JfbWF4X2JpdHMpOw0KPj4gKyAgICAgICAg fQ0KPiANCj4gSSBkb24ndCB0aGluayBYZW4gc2hvdWxkICJkb3duZ3JhZGUiIHRoZSB2YWx1ZS4g SW5zdGVhZCwgdGhpcyBzaG91bGQgYmUgdGhlIGRlY2lzaW9uIGZyb20gdGhlIHRvb2xzLiBTbyB3 ZSB3YW50IHRvIGZpbmQgYSBkaWZmZXJlbnQgd2F5IHRvIHJlcHJvZHVjZSB0aGUgdmFsdWUgKEFu ZHJldyBtYXkgaGF2ZSBzb21lIGlkZWFzIGhlcmUgYXMgaGUgd2FzIGxvb2tpbmcgYXQgaXQpLg0K DQpDYW4geW91IGV4cGxhaW4gdGhpcyBpbiBtb3JlIGRldGFpbHM/IEJ5IHRoZSB0b29scyB5b3Ug bWVhbiB4bD8gVGhpcyB3b3VsZCBiZSBvayBmb3IgRG9tVXMsIGJ1dCBob3cgdG8gZG8gaXQgZm9y IERvbTA/DQpJ4oCZbGwgd2FpdCBzdWdnZXN0aW9ucyBhbHNvIGZyb20gQW5kcmV3Lg0KDQo+IA0K Pj4gKyAgICB9DQo+PiArDQo+PiAgICAgIC8qIFRoZSBQMk0gdGFibGUgbXVzdCBhbHdheXMgYmUg c2hhcmVkIGJldHdlZW4gdGhlIENQVSBhbmQgdGhlIElPTU1VICovDQo+PiAgICAgIGlmICggY29u ZmlnLT5pb21tdV9vcHRzICYgWEVOX0RPTUNUTF9JT01NVV9ub19zaGFyZXB0ICkNCj4+ICAgICAg ew0KPj4gQEAgLTc0NSw2ICs3ODcsOSBAQCBpbnQgYXJjaF9kb21haW5fY3JlYXRlKHN0cnVjdCBk b21haW4gKmQsDQo+PiAgICAgIGlmICggKHJjID0gZG9tYWluX3ZwY2lfaW5pdChkKSkgIT0gMCAp DQo+PiAgICAgICAgICBnb3RvIGZhaWw7DQo+PiAgKyAgICAvKiBDb3B5IHN2ZV92bF9iaXRzIHRv IHRoZSBkb21haW4gY29uZmlndXJhdGlvbiAqLw0KPj4gKyAgICBkLT5hcmNoLnN2ZV92bF9iaXRz ID0gY29uZmlnLT5hcmNoLnN2ZV92bF9iaXRzOw0KPj4gKw0KPj4gICAgICByZXR1cm4gMDsNCj4+ ICAgIGZhaWw6DQo+PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL2luY2x1ZGUvYXNtL2FybTY0 L3N2ZS5oIGIveGVuL2FyY2gvYXJtL2luY2x1ZGUvYXNtL2FybTY0L3N2ZS5oDQo+PiBpbmRleCBi ZDU2ZTJmMjQyMzAuLmY0YTY2MGU0MDJjYSAxMDA2NDQNCj4+IC0tLSBhL3hlbi9hcmNoL2FybS9p bmNsdWRlL2FzbS9hcm02NC9zdmUuaA0KPj4gKysrIGIveGVuL2FyY2gvYXJtL2luY2x1ZGUvYXNt L2FybTY0L3N2ZS5oDQo+PiBAQCAtMTMsMTAgKzEzLDE3IEBADQo+PiAgLyogVmVjdG9yIGxlbmd0 aCBtdXN0IGJlIG11bHRpcGxlIG9mIDEyOCAqLw0KPj4gICNkZWZpbmUgU1ZFX1ZMX01VTFRJUExF X1ZBTCAoMTI4VSkNCj4+ICArc3RhdGljIGlubGluZSBib29sIGlzX3ZsX3ZhbGlkKHVpbnQxNl90 IHZsKQ0KPj4gK3sNCj4+ICsgICAgLyogU1ZFIHZlY3RvciBsZW5ndGggaXMgbXVsdGlwbGUgb2Yg MTI4IGFuZCBtYXhpbXVtIDIwNDggKi8NCj4+ICsgICAgcmV0dXJuICgodmwgJSBTVkVfVkxfTVVM VElQTEVfVkFMKSA9PSAwKSAmJiAodmwgPD0gU1ZFX1ZMX01BWF9CSVRTKTsNCj4+ICt9DQo+PiAr DQo+PiAgI2lmZGVmIENPTkZJR19BUk02NF9TVkUNCj4+ICAgIHJlZ2lzdGVyX3QgY29tcHV0ZV9t YXhfemNyKHZvaWQpOw0KPj4gIHJlZ2lzdGVyX3QgdmxfdG9femNyKHVpbnQxNl90IHZsKTsNCj4+ ICt1aW50MTZfdCBnZXRfc3lzX3ZsX2xlbih2b2lkKTsNCj4+ICAgICNlbHNlIC8qICFDT05GSUdf QVJNNjRfU1ZFICovDQo+PiAgQEAgLTMwLDYgKzM3LDExIEBAIHN0YXRpYyBpbmxpbmUgcmVnaXN0 ZXJfdCB2bF90b196Y3IodWludDE2X3QgdmwpDQo+PiAgICAgIHJldHVybiAwOw0KPj4gIH0NCj4+ ICArc3RhdGljIGlubGluZSB1aW50MTZfdCBnZXRfc3lzX3ZsX2xlbih2b2lkKQ0KPj4gK3sNCj4+ ICsgICAgcmV0dXJuIDA7DQo+PiArfQ0KPj4gKw0KPj4gICNlbmRpZg0KPj4gICAgI2VuZGlmIC8q IF9BUk1fQVJNNjRfU1ZFX0ggKi8NCj4+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vaW5jbHVk ZS9hc20vZG9tYWluLmggYi94ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vZG9tYWluLmgNCj4+IGlu ZGV4IDQyZWI1ZGYzMjBhNy4uZTQ3OTRhOWZkMmFiIDEwMDY0NA0KPj4gLS0tIGEveGVuL2FyY2gv YXJtL2luY2x1ZGUvYXNtL2RvbWFpbi5oDQo+PiArKysgYi94ZW4vYXJjaC9hcm0vaW5jbHVkZS9h c20vZG9tYWluLmgNCj4+IEBAIC0zMSw2ICszMSw4IEBAIGVudW0gZG9tYWluX3R5cGUgew0KPj4g ICAgI2RlZmluZSBpc19kb21haW5fZGlyZWN0X21hcHBlZChkKSAoKGQpLT5jZGYgJiBDREZfZGly ZWN0bWFwKQ0KPj4gICsjZGVmaW5lIGlzX3N2ZV9kb21haW4oZCkgKChkKS0+YXJjaC5zdmVfdmxf Yml0cyA+IDApDQo+PiArDQo+PiAgLyoNCj4+ICAgKiBJcyB0aGUgZG9tYWluIHVzaW5nIHRoZSBo b3N0IG1lbW9yeSBsYXlvdXQ/DQo+PiAgICoNCj4+IEBAIC0xMTQsNiArMTE2LDkgQEAgc3RydWN0 IGFyY2hfZG9tYWluDQo+PiAgICAgIHZvaWQgKnRlZTsNCj4+ICAjZW5kaWYNCj4+ICArICAgIC8q IG1heCBTVkUgdmVjdG9yIGxlbmd0aCBpbiBiaXRzICovDQo+PiArICAgIHVpbnQxNl90IHN2ZV92 bF9iaXRzOw0KPj4gKw0KPj4gIH0gIF9fY2FjaGVsaW5lX2FsaWduZWQ7DQo+PiAgICBzdHJ1Y3Qg YXJjaF92Y3B1DQo+PiBAQCAtMTkwLDYgKzE5NSw3IEBAIHN0cnVjdCBhcmNoX3ZjcHUNCj4+ICAg ICAgcmVnaXN0ZXJfdCB0cGlkcnJvX2VsMDsNCj4+ICAgICAgICAvKiBIWVAgY29uZmlndXJhdGlv biAqLw0KPj4gKyAgICByZWdpc3Rlcl90IHpjcl9lbDI7DQo+PiAgICAgIHJlZ2lzdGVyX3QgY3B0 cl9lbDI7DQo+PiAgICAgIHJlZ2lzdGVyX3QgaGNyX2VsMjsNCj4+ICAgICAgcmVnaXN0ZXJfdCBt ZGNyX2VsMjsNCj4+IGRpZmYgLS1naXQgYS94ZW4vaW5jbHVkZS9wdWJsaWMvYXJjaC1hcm0uaCBi L3hlbi9pbmNsdWRlL3B1YmxpYy9hcmNoLWFybS5oDQo+PiBpbmRleCAxNTI4Y2VkNTA5N2EuLmUx OGEwNzUxMDVmMCAxMDA2NDQNCj4+IC0tLSBhL3hlbi9pbmNsdWRlL3B1YmxpYy9hcmNoLWFybS5o DQo+PiArKysgYi94ZW4vaW5jbHVkZS9wdWJsaWMvYXJjaC1hcm0uaA0KPj4gQEAgLTMwNCw2ICsz MDQsOCBAQCBzdHJ1Y3QgeGVuX2FyY2hfZG9tYWluY29uZmlnIHsNCj4+ICAgICAgdWludDE2X3Qg dGVlX3R5cGU7DQo+PiAgICAgIC8qIElOICovDQo+PiAgICAgIHVpbnQzMl90IG5yX3NwaXM7DQo+ PiArICAgIC8qIElOICovDQo+PiArICAgIHVpbnQxNl90IHN2ZV92bF9iaXRzOw0KPiANCj4gUGxl YXNlIHNwZWxsIG91dCB0aGUgcGFkZGluZyBjbGVhcmx5IChldmVuIHRob3VnaCBJIGtub3cgdGhl cmUgaXMgb25lIGluIHRoaXMgc3RydWN0dXJlIHRoYXQgaXMgbm90IG1lbnRpb25lZCkuDQoNCk9r IEkgd2lsbA0KDQo+IA0KPj4gICAgICAvKg0KPj4gICAgICAgKiBPVVQNCj4+ICAgICAgICogQmFz ZWQgb24gdGhlIHByb3BlcnR5IGNsb2NrLWZyZXF1ZW5jeSBpbiB0aGUgRFQgdGltZXIgbm9kZS4N Cj4+IGRpZmYgLS1naXQgYS94ZW4vaW5jbHVkZS9wdWJsaWMvZG9tY3RsLmggYi94ZW4vaW5jbHVk ZS9wdWJsaWMvZG9tY3RsLmgNCj4+IGluZGV4IDUxYmUyOGMzZGU3Yy4uNjE2ZDdhMWMwNzBkIDEw MDY0NA0KPj4gLS0tIGEveGVuL2luY2x1ZGUvcHVibGljL2RvbWN0bC5oDQo+PiArKysgYi94ZW4v aW5jbHVkZS9wdWJsaWMvZG9tY3RsLmgNCj4+IEBAIC0yMSw3ICsyMSw3IEBADQo+PiAgI2luY2x1 ZGUgImh2bS9zYXZlLmgiDQo+PiAgI2luY2x1ZGUgIm1lbW9yeS5oIg0KPj4gIC0jZGVmaW5lIFhF Tl9ET01DVExfSU5URVJGQUNFX1ZFUlNJT04gMHgwMDAwMDAxNQ0KPj4gKyNkZWZpbmUgWEVOX0RP TUNUTF9JTlRFUkZBQ0VfVkVSU0lPTiAweDAwMDAwMDE2DQo+PiAgICAvKg0KPj4gICAqIE5CLiB4 ZW5fZG9tY3RsLmRvbWFpbiBpcyBhbiBJTi9PVVQgcGFyYW1ldGVyIGZvciB0aGlzIG9wZXJhdGlv bi4NCj4gDQo+IENoZWVycywNCj4gDQo+IC0tIA0KPiBKdWxpZW4gR3JhbGwNCg0KDQo= From xen-devel-bounces@lists.xenproject.org Thu Jan 12 11:02:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 11:02:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475989.737939 (Exim 4.92) (envelope-from ) id 1pFvMF-0006JL-0x; Thu, 12 Jan 2023 11:02:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475989.737939; Thu, 12 Jan 2023 11:02:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFvME-0006JE-UA; Thu, 12 Jan 2023 11:02:54 +0000 Received: by outflank-mailman (input) for mailman id 475989; Thu, 12 Jan 2023 11:02:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFvMD-0006Is-Jo for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 11:02:53 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a6d495ad-9268-11ed-b8d0-410ff93cb8f0; Thu, 12 Jan 2023 12:02:50 +0100 (CET) Received: from mail-mw2nam10lp2104.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.104]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 12 Jan 2023 06:02:39 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BLAPR03MB5553.namprd03.prod.outlook.com (2603:10b6:208:285::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.13; Thu, 12 Jan 2023 11:02:37 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5986.018; Thu, 12 Jan 2023 11:02:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a6d495ad-9268-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1673521370; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=N7VpTxKlYqQ0aWmh6KpZDMQyKIrC4HjhQ+OZJilveGY=; b=dEjqN8d/oqeyuCCxj62PxlSnqn8Dbb7fXahauVOMRVgcWs5LfaMbVpjV P4+r2Hwh5aY+4PUb/ELNVPgywdESbwLyqUY8QawIGFuzFsuR9opkOFRmD qpGK0CyVZXBMmLKn5GykkSCK4D3Tc1fzjHi2ZIgqj2pPkGyPaXYH+1P61 U=; X-IronPort-RemoteIP: 104.47.55.104 X-IronPort-MID: 91219673 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:p4bJha7JGU0zq0vwz1APxQxRtPLGchMFZxGqfqrLsTDasY5as4F+v mEdXjvVPPiLNGagKtgnOt6z8RlUvsPdnIdgQVRvqSpgHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraBYnoqLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+4pwehBtC5gZlPakS5geH/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m2 tIydWw3fiq/iu+yn5S7VrdDlJp9BZy+VG8fkikIITDxK98DGMiGZpqQoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6OkUooiOSF3Nn9I7RmQe18mEqCq 32A1GP+GhwAb/SUyCaf82LqjejK9c/+cNNLTuTpqKEx6LGV7lUCCEEkCWmlmKHnhxK9QNBWO VAW3AN7+MDe82TuFLERRSaQonSJoxodUNp4CPAh5UeGza+8ywSEAmkJSBZRZdpgs9U5LRQxz UOAld7tAT1psZWWRGib+7PSqim9UQAKKUcSaClCShEKi/HzrYd2gh/RQ9JLFK+uksazCTz22 yqNriU1m/MUl8Fj6kmg1VXOgjbpo4eTSAcwv13TRjj8tl8/Y5O5bYu171Sd9exHMIuSUliGu j4DhtSa6+cNS5qKkURhXdkwIV1g3N7dWBW0vLKlN8NJG+iFk5J7Qb1t3Q== IronPort-HdrOrdr: A9a23:LLJLMqu/1L3+4Jj9ZGaTCINZ7skDRNV00zEX/kB9WHVpm62j5r iTdZsgpHzJYVoqKRMdcLO7Sc+9qBHnhPpICOAqVN/OMGaHhILCFvAE0WKN+UyEJwTOssoY8Z 1PGpIVaeEZdDNB/L/HCIXTKada/PC3tJ6Tv6P/4h5WJm9XV50= X-IronPort-AV: E=Sophos;i="5.96,319,1665460800"; d="scan'208";a="91219673" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LI8H/4MEqXacB/CP5IjC0zkdF6K5S9kSUKKPYjlYMlB/Cigg4+mg9Q0aLDLOZBR6m583Z6UeeQYW3RXzvIPOhRS2FVLirb9NDb7c2MgwE+Or0L1QDKen9z9Lm7csiXEDi+YwgKWf9AF1JnppxP2h88wYHJkj82QN3p2CPkdf7J/L26Wbv4OObXjjoaR8PpsA3Pbexh1050qfhhSbsztQVbPvL5FFirYGPcv1k2n4jcSFnKyf8prjYCpGwrgufBjZpLOgLnvQfji4ZJjAV2eT7mvD9+n2wcDG1r+Ifqv0zSuReomxbkphisFA3lEDOHIGSwNxXD2E4W8sChgyQTT/CQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N7VpTxKlYqQ0aWmh6KpZDMQyKIrC4HjhQ+OZJilveGY=; b=WfI4SC7uUTPB2X8/c+KPGbz3LCO+oZNhDZ75RM/17ncz3yhfRIjCBUOQ8EJeZmhBPFHEumGzlde5Iod0DVc+ODSx6H3hCiqVT4j5sx9kawSBoE6OW4K6QndyQy4IH1uW7jEcJ6lO4nCbbQZifk0uobRBJT5nL80adGkqKxivfnZuuptNqlz54L6byKKXTJMqjMgbmbdwzwsMRNWM09o0VRau+OBrwkcQIr4yCgMCUTwaH6N8Q1ZwC4QibcTbsce7uXMt17hhd7vO6kKLAaxmNEkXXUaZx2y3+8I3P+WD44y4dEDmkRbHRae/wdLnrNUFpd93n7eWnUVA9dLHDQCpTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N7VpTxKlYqQ0aWmh6KpZDMQyKIrC4HjhQ+OZJilveGY=; b=xMKOMAKDsxaprX7HIlQkEox3wJfrMSYuRnnMugTiyoG8PeM9PSztREekI9cYGDhd9r4xtESyFyUBCcMTTwasfsiLCkiPGmaSnSIJbwBxBHfcl2N5Q3ODGmW7nBjYS297taFwks4WFyqPZOjcmKay/Se14RlRFunaVt+DkP0wNpk= From: Andrew Cooper To: Jan Beulich CC: George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Anthony Perard , "xen-devel@lists.xenproject.org" Subject: Re: [Multiple reverts] [RFC PATCH] build: include/compat: figure out which other compat headers are needed Thread-Topic: [Multiple reverts] [RFC PATCH] build: include/compat: figure out which other compat headers are needed Thread-Index: AQHZJloKRT09WL2lFUW3wxQFePvpLa6ang0A Date: Thu, 12 Jan 2023 11:02:37 +0000 Message-ID: References: <20230111181703.30991-1-anthony.perard@citrix.com> <5c7ffbe4-3c19-d748-9489-9a256faebb7a@citrix.com> <750ad2e8-a5be-d9c0-846e-41bb64c195fe@suse.com> In-Reply-To: <750ad2e8-a5be-d9c0-846e-41bb64c195fe@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|BLAPR03MB5553:EE_ x-ms-office365-filtering-correlation-id: 6210bfa3-1887-4512-033d-08daf48c83de x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: uMqQSMIiNfUyWy7g7rjhpxIfPtYHX72Cdar8GdfarQAZNZxuDSIAD2qg4P8GGZ1RWD2EUUxrikHGLu7Z8deW+5BbMwykQ+ze7ZtACQ39tphi/NU0kwH0hgCthcnB/+6Bt0BUudd1sI08rASaqpjlMcgFp4w+0WujeZG2NuAEmIg6huNPA0VKJxuAG3A1d/6Z2CiYNAjYpcKP/4IqCoJAPH0Yv4JVDYG2Nbz7IrSET8xGOjB5T546D3a9rei94kwGIFJHf/mHlse3E6LUpWX6Y74EXgH7/EZJ9TPceRKGEvzCIi0ozfVU3BZke/Vpojvwn5chZkcbC/5uk3bY1cjiKv1uYlHhaBH2hA+3LcfTTxIcSpbFHNHaGqQ0tY9BNgacHtKd5abqc/tzW5Jy9nEt3rHW3weiYZlMSGJrEwBzP+dSa2xtXLwhFsSe7bzmkMogPstihQfkMN1FuU97OhvFI26+TIwePCeZtSWjJq21BCMmlJP7uJGdOa4EuwXnX6+oUhrCxOIWwg0I76Zl9DQ3xkBIpMJ/GEvTQtl7czivSgy6fMLSxKfsLMyVoT62FfzLLb7nC+JNNIUjo73iTtzEcur4kDRMLGNAGJpot8eNcqpb2R21VRpZQkR68D1SNisz/jXOuM55SNw2pgx9WV90d68dHI0MVh7I7YHFnEOByFGzZ7+Ewvz+cq/lvm0KSH/LJM/t1TCD9b+aKcYRkR5TwyLBMo6ei55MtFxpSFyOFE4tHgOmOZGPPc0EUGP6zpXwJVzzJOqIjL/GFLlK1IPDwEM4G5Oeib3hnqaO/d4YQ6Q= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(366004)(136003)(376002)(39860400002)(451199015)(41300700001)(6506007)(8936002)(5660300002)(31686004)(2906002)(53546011)(83380400001)(66556008)(66946007)(66446008)(8676002)(91956017)(6916009)(71200400001)(76116006)(4326008)(36756003)(122000001)(38100700002)(82960400001)(38070700005)(316002)(66476007)(54906003)(478600001)(6486002)(64756008)(2616005)(86362001)(966005)(186003)(31696002)(6512007)(26005)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?cTNYN004RDFlSWUvTk9FdW5HY20wdkdCcXpDc0dqVnp0Z1Zad3U1b2xEV2dr?= =?utf-8?B?YXBjYTdjTW1WRWp5VkdhZEtPcGtpRU5XTjF1YWNyMFhteHlkdU1ZL2lObjE4?= =?utf-8?B?cFBZb3hscWR5OFRreUpINklYRFRIWVErbjhxMXlPLzgyRUE2VDN3b282K1hS?= =?utf-8?B?RWhMenZvc1FoRGdPdGVLWER0MmttUWtIUURjd096L29KSHZUSU5CVGdlekNy?= =?utf-8?B?WWhacVl6N1Y5OE9jbzFLaFRvTVhSK0I2ODB6MHQ2c3hhMnZhbjVVMDJyRmtI?= =?utf-8?B?bDVjN012YktMVlljQ0FWeDJYUUNuekFJNEN2a1FwT08vSlc2YnN0Q3doY1lZ?= =?utf-8?B?QXBaTUpaUXZnRlJJS1ViMWZZK1J2VHRLZlY4Y1ZvWVNTSFB5NEZ3K0FFek41?= =?utf-8?B?U0xFbTdrL0xBUDFPWU8vZ2ZvTTJGaGM0S042dXVOVnhPaW93N1RxSXJpNktu?= =?utf-8?B?blh3eHZTNTNObGFZUE13QUxNZEtZenZaaWQzZUFQNHlxTE1OVkZubHFUNTJy?= =?utf-8?B?YjF1UkdEU2J6WEc4dXBHck1pNGxUNC9BbGdDT0Q1S1llYVNxNmMwUngxRlho?= =?utf-8?B?SkhwRy9RMVRiWnVrZDN2aHg4TXhTM08yUGh3MTZjd1lHSkhWSDBlTWVFYjJp?= =?utf-8?B?UkFWZ1FxNXdKZ2RuazQzTE1PQnd1UWlZd3lIUUhrQllpNFoxWDBnSjFyQ3hj?= =?utf-8?B?Q1FlT1ZpckJ5dG1kUUJFNnN1MjZTQURVYjAxOHJ3YTYzOXNNdmtPc0N4ZmJn?= =?utf-8?B?emN5QUd1R0FZZHg0Mmk4Uk9xbXdycThtclE2a3dRUzZydVkvc0tyWGV5VW5N?= =?utf-8?B?WWMwK3QvbzZvcU1JUEo5bDFVNXNBVzB4eEE3cEptdEoyVU0veGRlaTRGQ3Ba?= =?utf-8?B?WnJnb3JSOWlpY0lzTFg3ZzZSMS9RZXJDUCtJeTJZaTZYZ3NqbEsrR0tnOGR1?= =?utf-8?B?U05jMjliM0RsOU5nYUpNTjJST1dZZ1RDTzlSdjVQUSs2dWpDMDRydzZjWmRF?= =?utf-8?B?bE52djJ5T2kzUXJiZkgwcEl5SWRjakNGLzlKQ1hQTExFd2VuQ1NwbmhGR2Mv?= =?utf-8?B?YWZ4WkI3WVg2UmZuRnErTUp0ZDN0Mnl4Yy9xNDlCRkVXckI0bmhyMEJTNEZ6?= =?utf-8?B?NllHR1JUcjlkNERSOSsvSjBHU2VxcGlPZVQ0RXVRd1dFVm83U2gydGQvNVFl?= =?utf-8?B?UzU5WTRiMTB6QldoTWhwNFBWNGVUdWhHb2RteTY5MWtlVEFwcGJ6YXZDR2cw?= =?utf-8?B?anQ1Ti9jdHFOOUtSUWE3dEU5NTQyRFpSRTFRbkZac0dLYldoSHBLMDdOc1Jv?= =?utf-8?B?V0RJc0toa0pPaVc0ZkFMVGZPaUo2UGxaNSthaHB1NFJtZ0RnWUtiWU0xaFVp?= =?utf-8?B?TEVVWlhrZEdLaFpTaWZta1hKOThYaHg4VG1WcjV1Y0FUL01kSStPVDVEN0JK?= =?utf-8?B?VnkweHhZamNGNGR0WlkvQ2xpcmhwdHUrcmpNSjN1S0E2QWNOMVErVWUyMW9u?= =?utf-8?B?c0lTN2IyTHNqTGlPWjRWMmRqeFdhaWVqTk52V1BvcXlqeEhpbERUaUVWdTFl?= =?utf-8?B?NmVicEc0c3hMbS8zNmkwbjZWQVRRZEZJcUEybzZUZkt0TEwyM0R5L2FmVTNM?= =?utf-8?B?OTIzZHY2a2Z4TzJXeUViaDU1bXNpQTRJSml3MDZwUWh1R3ZHZ3VYNnJMeWJl?= =?utf-8?B?K0tMbU1YTWV1TEdmL3VZQVhmMGNrcmkxZ3VpVTVoTFVrVTlVQXZLVTV1b29P?= =?utf-8?B?T3RCVDVaUEtvbXg4MHBvTTZnNUVHQ29OOGdQZDVrVitwSjRMeHBWS2ZkUVY3?= =?utf-8?B?bkdFRVJySVphM3VCWmhKdU9lamtBUWZOZXNQaStERFNWbnlKcVZXejVuUndH?= =?utf-8?B?MVhNUlZIOWJBUlBPZnVWanRDZlBpOW1vVU9JaUhhdGdlMVNzUEkwZTFMcXY2?= =?utf-8?B?RUpOYTVuR0E5ZUxOeko1ZnV5VG5ZNDg4UjB3WTRQdWdKV2Zrdms1TUErdTZO?= =?utf-8?B?S3ErUDBTWVl6TEdabnVHS3RNUHdJV21haUpYbVo3ZlZ5WG1WNFBwcWQwMEg5?= =?utf-8?B?a3JKbUdCalBnclV4MTBaaDhZd2pnaXVpMVF1Zm40NnA4bkVvM2QvT0hzWGNh?= =?utf-8?B?d1pBRWNRaTNhWHFmeWxoWTA2bFlmUEU1MG15OThVUHp6T2NweGdDbnYxQmQ2?= =?utf-8?B?eUE9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <4F1A9C49D02BBB4986E7DD1143835BF5@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: p7/yuN+OWZ7vkKh8XXOAexHuOY1vyRgOlAA8FADDi8u7LO46HfMaBd6YSGtBmNIfyVMOYcbpGl1qJfr2eCqLbqafvZT3dZKLZjDALl2xlCzkmKdVBOCWwf5T9Xq1LJQQXa8cisYFGpVNZqFqfoVMOfsMVhb0i/tSlmRI3zK8TrQ5ziWaUDijRiBlBt+uAifZ7i7BiPIL0hJMqMysyGrdEg2ApFiuC0lQvAKwPeiSptuWInJ6+KfsdlvLBzdozinUUszuXKb741SkpR9RoJWPRonxtQ5IqFwsnbUe4kl9bAVLLGTD1+OnYUycU/wnXSs//2ejhnx+Lzy4hl76qTWkCOh/ZjVuTC/4u67azAtUSjnzoA47f1B+stRcbflKt+0/rrPc3yrk1OK/B4cd4YQQuAM5ElU1OL8FJJj7iCRPNrd7SQvR/szJf/JlatP3QQ013VOfwgKPq+saLcJKnzN1gljM5WTVAhUl/YzhrQr2jEzJ/LP85VKVmAbOGl/EcHFj1spiTacz5x8qNF8vvyFr8UgSylL0LZyRUSAcJZ00G6jIxuMtyrtZpB/ziUBqLYssM1RxhKo/v0suH2XaxMVw2+YvO2RfnmF6JOL6fybmBN6KKBPavhTkrsSI9HTn7qKieKndT5A9erSPfsJPZ9mOL1afw+ieiPA/CE3IId8YX71GuUwebqDY684RonC8AaXOoToZb6whNjx977DbpSb1CCTIngyjcESK342PNNqYAkZ0KD6O28JyS3vkJ5Qh5U1td3po7FK1WZVvUyLaBKi6xJaT9EK5z3gaMgnQ4xWvnEPLBSvL/a5akSdr5B6MonU1mzD/+DwbAm6KDQipxdzi62Xqn1L8S/S4aZR61R79m78= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6210bfa3-1887-4512-033d-08daf48c83de X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jan 2023 11:02:37.0685 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rAPy7hQhndYq4hejh0nNAWyGJHLB2o7oGWP06B9RytE1TTB4EGNl7BpvF8ZqcYMXpGezQ69nonZ1mNosErMxNgCNa/raOWJsOnHtdvcwZRA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5553 T24gMTIvMDEvMjAyMyA3OjQ2IGFtLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMTEuMDEuMjAy MyAyMzoyOSwgQW5kcmV3IENvb3BlciB3cm90ZToNCj4+IEZvciBwb3N0ZXJpdHksDQo+PiBodHRw czovL2dpdGxhYi5jb20veGVuLXByb2plY3QvcGVvcGxlL2FuZHloaHAveGVuLy0vam9icy8zNTg1 Mzc5NTUzIGlzDQo+PiB0aGUgaXNzdWUgaW4gcXVlc3Rpb24uDQo+Pg0KPj4gSW4gZmlsZSBpbmNs dWRlZCBmcm9tIGFyY2gveDg2L2h2bS9odm0uYzo4MjoNCj4+IC4vaW5jbHVkZS9jb21wYXQvaHZt L2h2bV9vcC5oOjY6MTA6IGZhdGFsIGVycm9yOiAuLi90cmFjZS5oOiBObyBzdWNoDQo+PiBmaWxl IG9yIGRpcmVjdG9yeQ0KPj4gwqDCoMKgIDYgfCAjaW5jbHVkZSAiLi4vdHJhY2UuaCINCj4+IMKg wqDCoMKgwqAgfMKgwqDCoMKgwqDCoMKgwqDCoCBefn5+fn5+fn5+fn4NCj4+IGNvbXBpbGF0aW9u IHRlcm1pbmF0ZWQuDQo+PiBtYWtlWzRdOiAqKiogW1J1bGVzLm1rOjI0NjogYXJjaC94ODYvaHZt L2h2bS5vXSBFcnJvciAxDQo+PiBtYWtlWzNdOiAqKiogW1J1bGVzLm1rOjMyMDogYXJjaC94ODYv aHZtXSBFcnJvciAyDQo+PiBtYWtlWzNdOiAqKiogV2FpdGluZyBmb3IgdW5maW5pc2hlZCBqb2Jz Li4uLg0KPj4NCj4+DQo+PiBBbGwgcHVibGljIGhlYWRlcnMgdXNlICIuLi8iIHJlbGF0aXZlIGlu Y2x1ZGVzIGZvciB0cmF2ZXJzaW5nIHRoZQ0KPj4gcHVibGljLyBoaWVyYXJjaHkuwqAgVGhpcyBj YW5ub3QgZmVhc2libHkgY2hhbmdlIGdpdmVuIG91ciAiY29weSB0aGlzDQo+PiBpbnRvIHlvdXIg cHJvamVjdCIgc3RhbmNlLCBidXQgaXQgbWVhbnMgdGhlIGNvbXBhdCBoZWFkZXJzIGhhdmUgdGhl IHNhbWUNCj4+IHN0cnVjdHVyZSB1bmRlciBjb21wYXQvLg0KPj4NCj4+IFRoaXMgaW5jbHVkZSBp cyBzdXBwb3NlZCB0byBiZSBpbmNsdWRpbmcgY29tcGF0L3RyYWNlLmggYnV0IGl0IHdhcw0KPj4g YWN0dWFsbHkgcGlja2luZyB1cCB4ODYncyBhc20vdHJhY2UuaCwgaGVuY2UgdGhlIGJ1aWxkIGZh aWx1cmUgbm93IHRoYXQNCj4+IEkndmUgZGVsZXRlZCB0aGUgZmlsZS4NCj4+DQo+PiBUaGlzIGRl bW9uc3RyYXRlcyB0aGF0IHRyeWluZyB0byBiZSBjbGV2ZXIgd2l0aCAtaXF1b3RlIGlzIGEgbWlz dGFrZS7CoA0KPj4gTm90aGluZyBnb29kIGNhbiBwb3NzaWJseSBjb21lIG9mIGhhdmluZyB0aGUg PD4gYW5kICIiIGluY2x1ZGUgcGF0aHMNCj4+IGJlaW5nIGRpZmZlcmVudC7CoCBUaGVyZWZvcmUg d2UgbXVzdCByZXZlcnQgYWxsIHVzZXMgb2YgLWlxdW90ZS4NCj4gSSdtIGFmcmFpZCBJIGNhbid0 IHNlZSB0aGUgY29ubmVjdGlvbiBiZXR3ZWVuIHVzZSBvZiAtaXF1b3RlIGFuZCB0aGUgYnVnDQo+ IGhlcmUuDQoNClNvIEkgaGFkIGNvbmNsdWRlZCAod3JvbmdseSkgdGhhdCBpdCB3YXMgdG8gZG8g d2l0aCBhbiBhc3ltbWV0cnkgb2YNCmluY2x1ZGUgcGF0aHMsIGJ1dCBpdCdzIG5vdC7CoCA8Li4v JHg+IHdvdWxkIGJlaGF2ZSB0aGUgc2FtZSwgZXZlbiBpZiBpdA0KaXMgYSBiaXQgbW9yZSBvYnZp b3VzbHkgd3JvbmcuDQoNClRoZSBhY3R1YWwgcHJvYmxlbSBpcyB0aGUgdXNlIG9mIC4vIG9yIC4u LyBiZWNhdXNlLCBkZXNwaXRlIGhvdyB0aGV5DQpyZWFkLCB0aGV5IGFyZSBuZXZlciByZWxhdGl2 ZSB0byB0aGUgY3VycmVudCBmaWxlLsKgIFRoZSBjb250ZW50cyBiZXR3ZWVuDQp0aGUgIiIgb3Ig PD4gaXMgdHJlYXRlZCBhcyBhIHN0cmluZyBsaXRlcmFsIGFuZCBub3QgaW50ZXJwcmV0ZWQgYnkg Q1BQLg0KDQpTbyBmdXJ0aGVybW9yZSwgdGhlIHB1YmxpYyBoZWFkZXJzIGFyZSBidWdneSBpbiB0 aGVpciB1c2Ugb2YgLi4vIGJlY2F1c2UNCml0IGlzIGFuIGltcGxpY2l0IGRlcGVuZGVuY3kgb24g LUkvcGF0aC90by94ZW4vaGVhZGVycy9kaXIvIGJlaW5nDQplYXJsaWVyIG9uIHRoZSBpbmNsdWRl IHBhdGggdGhhbiBvdGhlciBkaXJzIHdpdGggdGhlc2UgZmFpcmx5IGdlbmVyaWMNCmFuZCBub3Qt eGVuLXByZWZpeGVkIGZpbGUgbmFtZXMuDQoNCkkgc3RpbGwgdGhpbmsgdGhhdCBpbmNsdWRlIHBh dGggYXN5bW1ldHJ5IGlzIGJhZCBpZGVhIGFuZCB3YW50cw0KcmV2ZXJ0aW5nLCBidXQgSSBhZ3Jl ZSBpdCdzIG5vdCB0aGUgc291cmNlIG9mIHRoaXMgYnVnLg0KDQo+PiBCdXQsIHRoYXQgaXNuJ3Qg dGhlIG9ubHkgYnVnLg0KPj4NCj4+IFRoZSByZWFsIGh2bV9vcC5oIGxlZ2l0aW1hdGVseSBpbmNs dWRlcyB0aGUgcmVhbCB0cmFjZS5oLCB0aGVyZWZvcmUgdGhlDQo+PiBjb21wYXQgaHZtX29wLmgg bGVnaXRpbWF0ZWx5IGluY2x1ZGVzIHRoZSBjb21wYXQgdHJhY2UuaCB0b28uwqAgQnV0DQo+PiBn ZW5lcmF0aW9uIG9mIGNvbXBhdCB0cmFjZS5oIHdhcyBtYWRlIGFzeW1tZXRyaWMgYmVjYXVzZSBv ZiAyYzhmYWJiMjIzLg0KPj4NCj4+IEluIGhpbmRzaWdodCwgdGhhdCdzIGEgcHVibGljIEFCSSBi cmVha2FnZS7CoCBUaGUgY3VycmVudCBjb25maWd1cmF0aW9uDQo+PiBvZiB0aGlzIGJ1aWxkIG9m IHRoZSBoeXBlcnZpc29yIGhhcyBubyBsZWdpdGltYXRlIGJlYXJpbmcgb24gdGhlIGhlYWRlcnMN Cj4+IG5lZWRpbmcgdG8gYmUgaW5zdGFsbGVkIHRvIC91c3IvaW5jbHVkZS94ZW4uDQo+Pg0KPj4g T3IgcHV0IGFub3RoZXIgd2F5LCBpdCBpcyBhIGJyZWFrYWdlIHRvIHJlcXVpcmUgWGVuIHRvIGhh dmUNCj4+IENPTkZJR19DT01QQVQrQ09ORklHX1RSQUNFQlVGRkVSIGVuYWJsZWQgaW4gdGhlIGJ1 aWxkIHNpbXBseSB0byBnZXQgdGhlDQo+PiBwdWJsaWMgQVBJIGhlYWRlcnMgZ2VuZXJhdGVkIHBy b3Blcmx5Lg0KPiBUaGVyZSBhcmUgbm8gcHVibGljIEFQSSBoZWFkZXJzIHdoaWNoIGFyZSBnZW5l cmF0ZWQuIFRoZSBjb21wYXQgaGVhZGVycw0KPiBhcmUgZ2VuZXJhdGUgc29sZWx5IGZvciBYZW4n cyBpbnRlcm5hbCBwdXJwb3NlcyAoYW5kIGhlbmNlIHRoZXJlJ3MgYWxzbw0KPiBubyBwdWJsaWMg QUJJIGJyZWFrYWdlKS4NCg0KV293LCBJIHJlYWxseSB3YXMgZGVjYWZmZWluYXRlZCB3aGVuIHdv cmtpbmcgb24gdGhpcy4uLg0KDQpZZWFoLCBpdCdzIG5vdCB0aGF0IGVpdGhlci4NCg0KfkFuZHJl dw0K From xen-devel-bounces@lists.xenproject.org Thu Jan 12 11:03:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 11:03:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.475995.737950 (Exim 4.92) (envelope-from ) id 1pFvN4-0006qP-AY; Thu, 12 Jan 2023 11:03:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 475995.737950; Thu, 12 Jan 2023 11:03:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFvN4-0006qI-71; Thu, 12 Jan 2023 11:03:46 +0000 Received: by outflank-mailman (input) for mailman id 475995; Thu, 12 Jan 2023 11:03:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFvN3-0006Is-5A for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 11:03:45 +0000 Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [2607:f8b0:4864:20::432]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c5ea41de-9268-11ed-b8d0-410ff93cb8f0; Thu, 12 Jan 2023 12:03:42 +0100 (CET) Received: by mail-pf1-x432.google.com with SMTP id 20so8111254pfu.13 for ; Thu, 12 Jan 2023 03:03:42 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c5ea41de-9268-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=YRMIxmrMjxFmZ7KhnuQyQ4LQN+JFHEuz988Y3hBKhAY=; b=AE2aKbGlog+nDLpzx6+73PFOKcFOlk7OrHENBBiyt8FPDfJtjJp9iazQfWNk1uJlM0 QhMv2+Ux9eLUuLYjgMZWUkvqrbE7es6WjuMPIEs60T4Ls+D9q0/MzjqYBaO5D/adYkBZ nLgcDr0VnC6f+kKHzeT+m/f66v9V7jsPZreL9Ref5zsYSVjUQMk+NCI/f3XlF9FD4h0p wOJxBBhwgklj8lzeQO0DR7laeFBaDePYrZfypE63u0O/Ijnim3Qg/vKTEBQfhWb/FDZ3 bh9hcjDTqiCPNZ6NKrduBHZtkSr3wrmKYWvOgX+Ta+5LYTfWRaUENMdezVR8C8dPh7E4 HGZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YRMIxmrMjxFmZ7KhnuQyQ4LQN+JFHEuz988Y3hBKhAY=; b=MWEzk3J0pR90zo8mkEotZveLo40WJB85ILbcUHVTlUWgZ+4SW8MbxFd7GoswKgW8UP G8vsDzhlq4SET6nLabvoI7pM6DH2KuwX/2h2nbq7sb8qA493hEbGAMY6npR7cEv/pi8+ gqWzbalSbgDTh2GGt3IITdzOPqkS7x2pnQm5YQuiYsPtqf5ihEvjEIcaEJBHxil24yge HMV7HTEdaxU5mWodBpNMkrW82HyBJE5MtPK0IpIg6gzG67ueePZ2lSBrILf8e5gRMQO+ UVWQVU/B/OXkSfuEH3L270i8MUL4aRKXtENEW6PrXg8SwA27zBSuGj4s1mGmx/zz79lp L7vw== X-Gm-Message-State: AFqh2kr8A6DC9LDR0c7I4GcW/fbwjCu1a9Yf1d+M3y6b1SRM65hNyL1N EPVUd6Sk2d8JmVz3ej7WwZ98x6fGGa67i9qntdHsVg== X-Google-Smtp-Source: AMrXdXu5V4bX22nwNZjWYHOvPbmvbmEPrM5ZbLD1wZubhZ6omG79rXH/n1MH1qTGUPIgVjvQP0rVQQGio1U3g6Ik/Ao= X-Received: by 2002:a63:e20b:0:b0:479:18a:8359 with SMTP id q11-20020a63e20b000000b00479018a8359mr4968225pgh.105.1673521421294; Thu, 12 Jan 2023 03:03:41 -0800 (PST) MIME-Version: 1.0 References: <20230110212947.34557-1-philmd@linaro.org> In-Reply-To: From: Peter Maydell Date: Thu, 12 Jan 2023 11:03:29 +0000 Message-ID: Subject: Re: [PATCH] bulk: Rename TARGET_FMT_plx -> HWADDR_FMT_plx To: BALATON Zoltan Cc: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , qemu-devel@nongnu.org, qemu-block@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org, Richard Henderson , =?UTF-8?B?QWxleCBCZW5uw6ll?= , ale@rev.ng, qemu-riscv@nongnu.org, xen-devel@lists.xenproject.org, Thomas Huth Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 10 Jan 2023 at 22:04, BALATON Zoltan wrote: > > On Tue, 10 Jan 2023, Philippe Mathieu-Daud=C3=A9 wrote: > > The 'hwaddr' type is defined in "exec/hwaddr.h" as: > > > > hwaddr is the type of a physical address > > (its size can be different from 'target_ulong'). > > > > All definitions use the 'HWADDR_' prefix, except TARGET_FMT_plx: > > > > $ fgrep define include/exec/hwaddr.h > > #define HWADDR_H > > #define HWADDR_BITS 64 > > #define HWADDR_MAX UINT64_MAX > > #define TARGET_FMT_plx "%016" PRIx64 > > ^^^^^^ > > #define HWADDR_PRId PRId64 > > #define HWADDR_PRIi PRIi64 > > #define HWADDR_PRIo PRIo64 > > #define HWADDR_PRIu PRIu64 > > #define HWADDR_PRIx PRIx64 > > Why are there both TARGET_FMT_plx and HWADDR_PRIx? Why not just use > HWADDR_PRIx instead? TARGET_FMT_plx is part of a family of defines for printing target_foo types; the rest are in cpu-defs.h. These all include the '%' character. This is more convenient to use, but it's also out-of-line with the C standard format macros like PRIx64. The HWADDR_* macros take the approach of aligning with how you use the C standard format macros. As usual in QEMU, where there are two different ways of doing things, it's probably because one of them is a lot older than the other and written by a different person. In theory it would be nice to apply some consistency here but it rarely seems worth the effort of the bulk code edit. thanks -- PMM From xen-devel-bounces@lists.xenproject.org Thu Jan 12 11:22:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 11:22:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476001.737961 (Exim 4.92) (envelope-from ) id 1pFvei-00010W-Ti; Thu, 12 Jan 2023 11:22:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476001.737961; Thu, 12 Jan 2023 11:22:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFvei-00010P-QI; Thu, 12 Jan 2023 11:22:00 +0000 Received: by outflank-mailman (input) for mailman id 476001; Thu, 12 Jan 2023 11:21:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFveh-00010J-Kt for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 11:21:59 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2051.outbound.protection.outlook.com [40.107.22.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 53828e1f-926b-11ed-91b6-6bf2151ebd3b; Thu, 12 Jan 2023 12:21:58 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8780.eurprd04.prod.outlook.com (2603:10a6:20b:40b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Thu, 12 Jan 2023 11:21:56 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Thu, 12 Jan 2023 11:21:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 53828e1f-926b-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aIzc44BPZjWDGItMctV5mLhr6+8J7s1YMwyB1U454FWL5hQdt/a8Yr1cQe08gS6VR3qyGL4b5sxb4Do/jGB86lF56sEF7LedZpdiGrOg3Ve9smncYQtNCIQ94+VSEDbkJNSuwCTnLzwKmsI3Luu7cBpwH7USFUMESLVpu0apLX7e2dQQFFHsQoYxHfsVwf6qg0Wu0VFIpkhUmg2G+5Vqbh1Q1QsjN1aFbq7MIWYmSEaC/n0kA9vp0XJugPWzjhiiYa2+aAUdTQH9uTsEZnpytyQXwrN2tD9I/+qw37f5Bi6I+H1QFzxnmNv9SCEAFldGWxlMhvKL00QZ0nOnkYzL9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ia2sbsa1r4vbw0b9jirnccNid+oPcdF6VmK/PXk2qcM=; b=UPjeHVUUehM0p27YdnRAP7+KKu6wXmKiUPuy4Tnz7cIL/EX9IkGhmTxKvv22oE93ep3RSVHrKNhoyZT55ec7dCuA/weHcHGFfRuN+xlswdGUZpgxcITbZ/0Ji2RxndApBYaOTfBCr3hIofS6pxZOiPN3msa8BgIvYxHZ8fjZExsAB+ZDZQivhJShZJasqmW8gPl7MkroQtnt+oQutxDimwvKh8qLIUSW1oO3dJilqHofTq9hKaQbluXs55n4i/LSk9+xsn+w+lWHB3kmP9VvffyQNIvmzr0Ir6tLH+yLTdEjneJ9jl/E5/xLHDkbh8aKkzvgbn1uZoXOdIe60bKbPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ia2sbsa1r4vbw0b9jirnccNid+oPcdF6VmK/PXk2qcM=; b=HSQgqFs2uS1Zx+LPtivBSJqlC1X0AF9jz/nf6vatNevpsp4XohxA4FepVBl4vHysUZeVnD/OibSqxOg5I78eRYjOM8olw6dq6PieqACoWHDWRxVZ2Em2Yow2jPc17YL7shPsrIMnwcWwRJSkSrnxR/+WY+i0Zlt2R+lzuD/Nzm1ef27w7thURcUdtvJ6KBcesJBav0PIScikisy3nHJ69MImJyJQ7CyYNLPvjjL3TccG2nw54OPEVJZ5ZDJNj6T0OSjcXEM0xtPpHMUxZFms+V2ovyjba9Aax6NHDmH4tRIZD5pKRjB8W7TCfTIVNPxta639/0u/XLIBaR/+sc76JQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 12 Jan 2023 12:21:54 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [Multiple reverts] [RFC PATCH] build: include/compat: figure out which other compat headers are needed Content-Language: en-US To: Andrew Cooper Cc: George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Anthony Perard , "xen-devel@lists.xenproject.org" References: <20230111181703.30991-1-anthony.perard@citrix.com> <5c7ffbe4-3c19-d748-9489-9a256faebb7a@citrix.com> <750ad2e8-a5be-d9c0-846e-41bb64c195fe@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0172.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8780:EE_ X-MS-Office365-Filtering-Correlation-Id: 5d6c5186-a8e0-4a0d-4c90-08daf48f369c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: W/ALIPkcwl+tyPK+ctEVA+CASAs/84mk1W7QZuk9bUKpBB+nFxApNwoHIDHTdDhcjL2DqdNsOVfwjyuWDRi4AcF+7EFJgOaUQonDJMxiXI4YooskuMl/XXwoadVVu3MYZw1qgec0gzNCKyGzKzesK4dfUnUHeHPbxxii2n67R8uCUZ04pN20uOgoMhS8msfb6BLPdxMUbL1kRooxpdfscvVqmbYQaNf4/czSs9ckJRShqW2kyQu8WziHpJLNnldPOViXZSEPpnaj7mKZvqD94Qu5tR+sfacV9SOIn07CYbene4WgRnHlbzPD2qEI+sD7c56o0Xundkbkbbun7KeU9V0EUphyTQYh4Ev/iPL7tkFE6kfihcPJuqpshGwZciYICMjqF2kSDRogJhZ1Rm9GLG/0t91Q3Swf/UTs9b5xrY67DuINFv93hEl4s76/u3/vrKClYUbUmnZt80urzzJDcb1bIGfD1CQRKVINcfMJzT+otIJGd/kSx1B/iHxry3Rkq4yQf2NR6tYSz4O2U/JBC7goQdboPao26aazDCU7G5CwBaCAa0PsFC+CoObXhGhG1QnH1Y8MJK1304ZOPlSgKx/aRAahq2rxAc0uTas9guSWXUlPBRH8yZ9b86zrlq19EL8PT0/9tOtFVehvwgdS52JpCB66b0tjBS8cNrMAPLI+gK3xWGvPOOy76jC56mDxOKR5JbJ0vIU22PH6FFYi2w3vMsfbVUliwKVobuV8+xCCS5MIse4cyb5U45LUna8F7Hf6hygGX3bLiLC1FnYIEQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(346002)(376002)(396003)(39860400002)(136003)(451199015)(2906002)(83380400001)(478600001)(66476007)(66556008)(5660300002)(66946007)(8936002)(53546011)(26005)(36756003)(186003)(6916009)(6506007)(31686004)(6512007)(6486002)(2616005)(41300700001)(38100700002)(8676002)(54906003)(86362001)(966005)(316002)(4326008)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UDdDQXFVaFNkbUx0dEJ6NGlvTko3TW1pVStxQ2NMZmF6ZEg5UjdGRXFsOENX?= =?utf-8?B?bW9uSE1YY2FHNXFCbm1BZm1aTkxvamRRamVRZXN1NEluMmo5a3c4amFWUEZ2?= =?utf-8?B?NllZb1lCRENtNWgzL0V0QkNDQmtmWFJPNkNlejlJK09oczQ5VUR4QzFnVFZN?= =?utf-8?B?WjhoWDk2OTJKS0xXV2pkRkt4ZU0zV0tBa1N6M2RVZmRTUVJaaHh2WGphYmxE?= =?utf-8?B?M1FsN2hwUEk0ZVN6TmtCc3J2M1FLT20rNXJ2VnNoczlPRzUxWXh3azh1dUxt?= =?utf-8?B?a3BPN2E0a0QvY0dNYzhqcFpKN2lPcXpkVWNYd3daa2NhaEwreU5rRGVmQU1w?= =?utf-8?B?OHNRdGVEeVdqZFRwd1Nib0s2OUVhUFpsTVhOQ3plaWVsR2lqb1cxNDV0MTMv?= =?utf-8?B?YWhEODlVamwzUVVJdEdFSThYOXN4eXYySnQ4N3RibDdKK2RBbWJnMzBqOE1G?= =?utf-8?B?VmtHZXU2V0NxWG5ndHFZRkpXdDlFNjJKUVpPYTE0dEJ4ckFEeURWRE1pLzBY?= =?utf-8?B?ODkxdnA2YWVwZ1RqaDFST1U5eWttZWo3RXpGNmJtNFBLUGFseWdmOU1Qcngy?= =?utf-8?B?NWEyWFlRMEZXbFpiYVUvQnBOeDgzSko1NmgwbG1mVUphOThpbjVocmlXUGVP?= =?utf-8?B?dWJLYlNJdnBEZ2VwK3JqNnBjR21MblZBTTJwYVA4Z2hLK3hGU2plQUVycHA0?= =?utf-8?B?MEJSa1d1VjBLSFFKNVhKRXdQY2oySGpsNUlha0VpYW8xdHFPY3N6dHVMQk82?= =?utf-8?B?SWtqSmdKSTNGZHM2OENjamVkbTI0eDQzUkV3RWFkcE1RcFR3b0h0K0hZOHdp?= =?utf-8?B?K0pSaSs4YVdmeXBrU1grNjRoZVIzRitFRFBEbWlFL2ZKaDluSXhIaXg5dS9M?= =?utf-8?B?RWt1bzFGbUN2Um9KQ01qSUlzS2RUby8ySnpRSmpFdlpjZHk3MjV5ZDU2QVBa?= =?utf-8?B?YTdYbDMxdUFUQW1QaStUVjZ6bUNDVGl1Tzg0VkFMbDNtcE5SZDBIaFduVktM?= =?utf-8?B?eWlBTHkvVm5vTDhvWEl2b0VjeXRoQUJWVmRIL29JM0dWR1N4V3JQWlcxeGVX?= =?utf-8?B?dnAwcjIxOEZRNVlUTndWdDBha2VwYXNBWjhIZHhxOWZHN013L2JORUFCRUwr?= =?utf-8?B?UFlCcis3M1VzbHFDaUtESnZmNEord0xVa0hiK0cyZ3VhK2RYa1Vab2lQT1or?= =?utf-8?B?eVdrZkx0aFl3aDYxZzJKT2ZNa2NEc2JoSEY4YUtlNHN3RzgzMk85U3BBdktX?= =?utf-8?B?V2tweFJDZWdwako3MnBWVGNrdVQ3R09yWUMxQXJkRFJzUFVoakJsV0doaFdl?= =?utf-8?B?NmlsM2FCTkxuajl6OHIzSGp0NFIwemxENzIxRmFvcldxZ01tdlVwcTdrR0dP?= =?utf-8?B?eFNpRHBmeDFoNmNkZXBVWmFIbmpiVm1jV3JPcGxwSk9nWkdNcjh3QU03LzRk?= =?utf-8?B?aW1BTUNDZVkrSHpiTEVLVzdGVi9zZXdWYXh1MFdPc0tYTlpHM0VqbDY4UXdJ?= =?utf-8?B?QmtUR2ljWTNYVHFHZnl4Q2crNVE4WEtZOE1wTlZBVHUrYm5IQlptTjUrSnFx?= =?utf-8?B?Z1RWRmM3QlMwYWFMdlpEa3pLMlRTNnJUOE5udnlLOEh4U3Z0b1dVTEp5cjZo?= =?utf-8?B?M0lQSks4ZTJha1ArRSsrdFhXaUROMVkxU3hUcEhybXl5QnIwaXpGRWlueW1q?= =?utf-8?B?eHNNcHNxVnk2VTdmdGlzY1J3N0M4ei9pRmxWTzhxV3Iyd29tL3FJVVMySDd3?= =?utf-8?B?dE1LL1d4WStYcVBYYXI4dElrK2xnRkx3R1BUS1JSZkZYTG1mNXdiaVNIam1y?= =?utf-8?B?RVlBQ1NYNitMY1JaOVZibG8xSkxiQkVhblhxK1cyemJXRDdGNG9iSmNHQ2dZ?= =?utf-8?B?RUxxQ0xyUXhDU0JpVVFwbnI1VTdXM1hEOE5UN3IwTDNST21ITm9vWHY4THdC?= =?utf-8?B?SGVmUjJlR1hCOXpkNC83WVlWQzVJbmx6RG13K3BUNVlCWGV6VW5CcnB4aW5R?= =?utf-8?B?UkZ2TGhUc2hCSFhlNTF0THFSWTFJYUNYd3VYQTdUVllFbVpzcU91Z3IzcGVD?= =?utf-8?B?MlR5YmRxOEFWY0VJeHpaVldoN2lSQXd6VUFVeFZXZVIweXJ5UlNYa0krRU52?= =?utf-8?Q?y0qHTzwg8NI/Qv/Pj7RfpKd0x?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5d6c5186-a8e0-4a0d-4c90-08daf48f369c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 11:21:56.1934 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ghDypdTZbnglhhC8S69x3+Pd31G/e+CHW7Myyc5k5+TFqSc6alyMUhltP8Y6YZ6ODp9wSX2xaWNHOvoT+2tx4w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8780 On 12.01.2023 12:02, Andrew Cooper wrote: > On 12/01/2023 7:46 am, Jan Beulich wrote: >> On 11.01.2023 23:29, Andrew Cooper wrote: >>> For posterity, >>> https://gitlab.com/xen-project/people/andyhhp/xen/-/jobs/3585379553 is >>> the issue in question. >>> >>> In file included from arch/x86/hvm/hvm.c:82: >>> ./include/compat/hvm/hvm_op.h:6:10: fatal error: ../trace.h: No such >>> file or directory >>>     6 | #include "../trace.h" >>>       |          ^~~~~~~~~~~~ >>> compilation terminated. >>> make[4]: *** [Rules.mk:246: arch/x86/hvm/hvm.o] Error 1 >>> make[3]: *** [Rules.mk:320: arch/x86/hvm] Error 2 >>> make[3]: *** Waiting for unfinished jobs.... >>> >>> >>> All public headers use "../" relative includes for traversing the >>> public/ hierarchy.  This cannot feasibly change given our "copy this >>> into your project" stance, but it means the compat headers have the same >>> structure under compat/. >>> >>> This include is supposed to be including compat/trace.h but it was >>> actually picking up x86's asm/trace.h, hence the build failure now that >>> I've deleted the file. >>> >>> This demonstrates that trying to be clever with -iquote is a mistake.  >>> Nothing good can possibly come of having the <> and "" include paths >>> being different.  Therefore we must revert all uses of -iquote. >> I'm afraid I can't see the connection between use of -iquote and the bug >> here. > > So I had concluded (wrongly) that it was to do with an asymmetry of > include paths, but it's not.  <../$x> would behave the same, even if it > is a bit more obviously wrong. > > The actual problem is the use of ./ or ../ because, despite how they > read, they are never relative to the current file.  The contents between > the "" or <> is treated as a string literal and not interpreted by CPP. First of all the C spec says nothing about how searching is performed. It's all implementation defined. Gcc documentation in turn is quite explicit: "By default, the preprocessor looks for header files included by the quote form of the directive #include "file" first relative to the directory of the current file, and then ..." This is behavior I know from all compilers I've ever worked with, so while not part of the C standard it is (hopefully) something we can rely upon (or specify as a requirement for people wanting to use the headers unmodified). So I agree using ../ inside angle backets would be bogus at best, but I think using such inside double quotes is sufficient generically okay. Hence ... > So furthermore, the public headers are buggy in their use of ../ because > it is an implicit dependency on -I/path/to/xen/headers/dir/ being > earlier on the include path than other dirs with these fairly generic > and not-xen-prefixed file names. ... I don't see any bugginess here. Jan From xen-devel-bounces@lists.xenproject.org Thu Jan 12 11:31:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 11:31:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476008.737971 (Exim 4.92) (envelope-from ) id 1pFvnj-0002c8-TP; Thu, 12 Jan 2023 11:31:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476008.737971; Thu, 12 Jan 2023 11:31:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFvnj-0002c1-Qg; Thu, 12 Jan 2023 11:31:19 +0000 Received: by outflank-mailman (input) for mailman id 476008; Thu, 12 Jan 2023 11:31:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFvni-0002bv-Ag for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 11:31:18 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on2083.outbound.protection.outlook.com [40.107.15.83]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a09b9092-926c-11ed-91b6-6bf2151ebd3b; Thu, 12 Jan 2023 12:31:17 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB6879.eurprd04.prod.outlook.com (2603:10a6:803:132::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.19; Thu, 12 Jan 2023 11:31:15 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Thu, 12 Jan 2023 11:31:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a09b9092-926c-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LZjvuQn+kyTQ9VHkz1bASGQ98kxRESvVFRsyTm5IdVYW1Ns/IHF6HJ0huUB7RmJXfcSktVW0eoVxpYt4qOWwp9gSAySjpyWdz6eqih+DEfFnCjT2rDpJ++WddyOuCeGjzzkvFJHBGrAM2vDUN/VhVcLg8lKAsEzD07BcOWw/y0rq1A8nTq2/URWy+PuP+LmicAiKYXEeZsxDqQwR0O7I2oeqfnL92JChgb+VLhnsJQ34KC6R5PASQ1t9Q0SQLatBYVcMAoRzGPwR0NWM2Izhczr2RFJe8luxYGkBG+Yqj2D9fSNpyWb5CDXer9iUTb1qFp3eIW+ipMWxp0Gji7SGfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QzJ8GnLtgQgzREvZeQzHoLZ4aqo9Q7Nx3aQJCiyMG5o=; b=Vd0Pk4gpqU4IQcjsv3JGdfKZBt+mvG06AE2xSN6xBwxI7VomPzynAzOWu/8P7plTcdTvcfMtr0UIFYj8sswKIoFs+piWwCLJ00HVEJTVA9jc64obySV53WgU/9djvRvIc+QES+Dt6tHJrjBc4L99GHBQ66mN1EEQPkE+L9dD8LTzrYs9L36Sw6sGjQKA8odKV+70RAcu4ipqZ+9BPn3gxOgLRC2RPSzL/vXB1t5yOLTFOoorz/uBoeoXEaySwVFxYmNCtCWw6fG8Pd6nQgq/6iWLKUvT57WMkyDRIjE1hO7rPLUJMi0MSJSsRcEIpVmv2PlL5wwObiJVGhaaI7oF2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QzJ8GnLtgQgzREvZeQzHoLZ4aqo9Q7Nx3aQJCiyMG5o=; b=WNmnQF9FZhx5ImVZR1r9DzZrxH2K7mgl9dK0O5ENooteDitRGOR4OBSJXukD6+cabDzK3uK/J9wP1tc/Dm+DeghHGj35hQdbW6GNzHYvPlDXdHcB/DQPVDIk8IYDRHeSwaFWAYwXILRMI+Xq37uTP5gQE+kfMHZrGQpIBF2yTwl+7GcpRrM7ypfxJdgWKGkvoD0+bdhm1cx4t4BoJbqi2JNDtDTbBkbpttB3sxHWmODVBd4FQua61L8p/Hq+Am198AAGkwwPxwWC7fNEt1wvcn1k+cq1boKjS98PmYZk+gGR00zk2pVK3GM60cS4H3ew7EIKriTs0aIDLbeK5oMgjA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 12 Jan 2023 12:31:11 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 3/8] x86/iommu: iommu_igfx, iommu_qinval and iommu_snoop are VT-d specific Content-Language: en-US To: Xenia Ragiadakou Cc: Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20230104084502.61734-1-burzalodowa@gmail.com> <20230104084502.61734-4-burzalodowa@gmail.com> From: Jan Beulich In-Reply-To: <20230104084502.61734-4-burzalodowa@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0076.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VI1PR04MB6879:EE_ X-MS-Office365-Filtering-Correlation-Id: f5fb5c42-3cb9-4f64-f9d9-08daf490839e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7WxWf3LLiyl6ZYtiVA/ZtiqVYz/mViB9MHBKfvVRIOdfLycXVFKEow7IF4y+vznppajpXQP5XxR1nKWJg9TgIg+dwKty6dFEPhG5bIUEmPJ7gKH1C64uPZEj86AwOfmoHwLETo5bKrRq3nvyFFt6Hvewz+H6Dd9WwFvkdA/q+if5L3FdTKlUtV234mEz5esbNroV6hGjst+uX5Llh3yli9Wp67gcZmb52syF4N8GcFfOz0wOFqEXtlCCqvwEbkGuamzC30dvwK95X+IVzFADp7eYhpiBg1RL+tf97YnOWv8Ik2rFspaxDIyxAyXwzerHrwkg9jPcdkTQ2GP3F+XREMWvl9zgAjdtnT5aayERiZfBPqzyHZIW3QdG/Pw0+s7VKndKzswNzjFv8wzCKgM17GGmnEibrsZuOtjZO14A84izQ7WXXY9qsLheP2GMrM++vrrcDxxcdHl1IkPSuIhsn7nKCyvuxFObGoJnInYGpqOHJ7pjBY967fA09daAuGBhAlbjePjQo59kPO4A+PPoqfAsmvlXTTnN+hpVcGzT4vuHtbF7WYZ8O7nhkgb5OloovC2S+6nVIssvdDDoqz4+VIbfTKcOK/sJc6vwR8bvQefRw9IlyQodVQwvIRgx/RMpHswNAQdUNrWPsKyIlkgEVV98+lDO+1Y1Wjqua0Z68J1GfxIZ17kQP7bjYJFAtm9JL5tHQPJ9Q9duSooWgzkIqL8pg6t+bZZ+w81F4ZHnhJM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(396003)(346002)(366004)(136003)(376002)(451199015)(53546011)(6486002)(478600001)(6506007)(6666004)(186003)(6512007)(26005)(66476007)(316002)(31686004)(6916009)(4326008)(66946007)(54906003)(8676002)(2616005)(66556008)(38100700002)(41300700001)(5660300002)(8936002)(31696002)(86362001)(36756003)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dzk1NkZwV3paclJUM3dXYUJIU2FnNmRxT0VvdjRkNks2VXVFNUFKeFJ4eEdU?= =?utf-8?B?RG5TRWEwdXhnNUpoYTdGQmxRNVU2dHBlU0Z1QkV4bk54cjhtc0ZlL2VJeHps?= =?utf-8?B?L0NIOHBQelJmcXBZSi9wY1lRS0NrZmU5eWlJQlJreGFEUWlWMTZxSVhWWUNl?= =?utf-8?B?RjNYZmRGSzBmb01yUGYwSHJkY3k5WEVmeS9rdnlITHljVTgzY29ZNnc2RkU4?= =?utf-8?B?c0pwUWEyR3Q3aG8weDNXYU1LVnl6akkxUHU4a1FHVzF5aWtaeWpqNW5QQ3JL?= =?utf-8?B?WkdYUVJjVmN5K29XUjVmdStRcW9LUVpJYWNtTGRpclZjbEhadDhlbndGUkpM?= =?utf-8?B?NllYK2UvZmQ3UU5PR3lySkdzamlTV3RoN2xRSHR6ZGlMNWlPZncrV0swYlU4?= =?utf-8?B?TzBnREhGeXg1aS9KNCtKU0d1dGlaQU9hU1hvMmpNbDNVMWhEa1lvcmhQVlBq?= =?utf-8?B?MTdTWnI1Mzc2N3BmbnlhM3lyOGJkbncwVmIrRFBrbDlIZlJNK2ZWWEJ0R1o1?= =?utf-8?B?YWtBeVdHcmZmQ3VvVkx6MHRJMGxYTGhZdWgvNHptYkVHMnV0eEh3ekhWZEZm?= =?utf-8?B?Wi9mWE5KUHlNZTFoZHpmZkp4ajczM09vVjUxb0xUNW1CQlgwd2E2bUVHOGRW?= =?utf-8?B?dnlSQ1JtUWZCd0ZwbVlWZnBUeWdDZnFuelg0TzF0R2FVUFZuQWlhaUo1cktR?= =?utf-8?B?VDFUUm42czMzVGxLSGNDVDZLTUk0U3JhOGJUR2UvcW5Ud3pqejMwdFZ3SytJ?= =?utf-8?B?NWRvKzVTcGs0TzFFN2hPYnpYSkRWWFhNSHNRSlZaU1Jlc1V3MDcyZlp3Z1JN?= =?utf-8?B?b3BqREtDbkQxTkVJOE9nbk5qK0lZSVR0TjVsNEgzN01NTkFqRm0wdllPTFFY?= =?utf-8?B?SWxqMjc1dGI3YTMycitEOFhhTExIUUpXbnUxZ1RnYlQzUjR4UnlSTlV4UTZX?= =?utf-8?B?WHhkQ0p4dXphNlpLU0JFWXhmTTkzOHBDQ013ODR2Sklsd1NuNjVWN204ZStK?= =?utf-8?B?OENvSFYwVmZJc0N0UG9iQmlXVG1ONHUzQ0pSUGY1cWNHRXNtTTlqWUNjQXdN?= =?utf-8?B?am1rU3daN2NJMitzbk0yZGlRKzVYcm5hbXp1WW9MSzN4K0NvWnRHdkh4NFc1?= =?utf-8?B?Ym5lb3g2K1FvWnc5RllsZlhteHNFU2ZETnRmZGNqWmZtNFFBbWRyTnZGOVQz?= =?utf-8?B?aFFFSkxUektWdGN0c1Q3REd6bkNVN3FQbEVHVlQxR1pvOGgyZ1FpR2twZTRy?= =?utf-8?B?aHlPaGRTY25yWWtVUGlTZ0pCQlRNK00vQVdmeEMwWU5xZGhRTFhGR1h0RDk1?= =?utf-8?B?ODlWSUR0bUg0cytaU1dBU1laOHRLVmhNdS9sK0FjSlZjQ0l5NDNvbGE4ZXJu?= =?utf-8?B?amRUUVRqL0prdUc2RUorWlREaXlhdFF0anZqbERFSTlnNVlMM0lKTHY2RWNT?= =?utf-8?B?VW1uMWNLS1Z4WU4vRUtIQ0pMVXIwcU9xZDB1QTRCbkxPLzNYU0VXdDk2Ulcz?= =?utf-8?B?OGtidnZxeDRzNUNLa203MEZWL0V2RUtGbjR4eURWeDdOV1JvcEx1dFZyRnU1?= =?utf-8?B?YjJXZHpVR3FHcEpvb21zUU5WZGdzUExld29mZG5URFlBdktVNnhnVW9senhx?= =?utf-8?B?VkRJa0xmakZYWjkrUnRzeDU3TUJjdlk0QmVLcGRQK0QrT0h0dnhHYytmeUUx?= =?utf-8?B?bnkrazF0VWZoT3JQWTRiMHhMeHM0bm9HbHR0QTV4UUk5ZTRVU2NSUzNhTW9Q?= =?utf-8?B?MFNrTWpWYmoxRDF2QkoydDh2UVpTSGVvQXk3WFR6a2IxQ0FxTkpTWE43dFFR?= =?utf-8?B?TlRxMnBVbnRLMDRMckVzRThwa1czWXhRSUI4akxTMWUvQnBOMnBSNkJLL29y?= =?utf-8?B?bkxJMmRVU0NNUnJybEgvcEdXVGlzQUhEU1JBalU4UUZxcHpaN0JIT0FicXFx?= =?utf-8?B?U2NQUnN4SExFUzQ0Umg2OFlqeFBZUko3d04wK1orWGVTeWxMVmhVOG83SUox?= =?utf-8?B?dGRwREFlT0gwVHdIQ1ljT2lFbDNKWDJOVzhEamxXVVl6cXJLdU9uWTg0TU9s?= =?utf-8?B?Tlk1dldNTENtS25tRzlBSWV3NEdPSGxOTWRjMTgzaXU3cUFDVlFwU2hnN3Nt?= =?utf-8?Q?RG3KOwTWv1NBgboFj9h0fouua?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f5fb5c42-3cb9-4f64-f9d9-08daf490839e X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 11:31:14.8767 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZoJSsRkGJ4Zsg6wkORHO95NRfcsh3O0IROMWEkD83765hF7/elG6s5h7ZuuAkWo2BMlBjivX9bLxelUi1uZEKg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6879 On 04.01.2023 09:44, Xenia Ragiadakou wrote: > --- a/xen/drivers/passthrough/iommu.c > +++ b/xen/drivers/passthrough/iommu.c > @@ -82,11 +82,13 @@ static int __init cf_check parse_iommu_param(const char *s) > else if ( ss == s + 23 && !strncmp(s, "quarantine=scratch-page", 23) ) > iommu_quarantine = IOMMU_quarantine_scratch_page; > #endif > -#ifdef CONFIG_X86 > +#ifdef CONFIG_INTEL_IOMMU > else if ( (val = parse_boolean("igfx", s, ss)) >= 0 ) > iommu_igfx = val; > else if ( (val = parse_boolean("qinval", s, ss)) >= 0 ) > iommu_qinval = val; > +#endif You want to use no_config_param() here as well then. > --- a/xen/include/xen/iommu.h > +++ b/xen/include/xen/iommu.h > @@ -74,9 +74,13 @@ extern enum __packed iommu_intremap { > iommu_intremap_restricted, > iommu_intremap_full, > } iommu_intremap; > -extern bool iommu_igfx, iommu_qinval, iommu_snoop; > #else > # define iommu_intremap false > +#endif > + > +#ifdef CONFIG_INTEL_IOMMU > +extern bool iommu_igfx, iommu_qinval, iommu_snoop; > +#else > # define iommu_snoop false > #endif Do these declarations really need touching? In patch 2 you didn't move amd_iommu_perdev_intremap's either. Jan From xen-devel-bounces@lists.xenproject.org Thu Jan 12 11:38:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 11:38:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476014.737982 (Exim 4.92) (envelope-from ) id 1pFvuA-0003J8-J2; Thu, 12 Jan 2023 11:37:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476014.737982; Thu, 12 Jan 2023 11:37:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFvuA-0003J1-GM; Thu, 12 Jan 2023 11:37:58 +0000 Received: by outflank-mailman (input) for mailman id 476014; Thu, 12 Jan 2023 11:37:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFvu9-0003Iv-A7 for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 11:37:57 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2075.outbound.protection.outlook.com [40.107.247.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8df43904-926d-11ed-b8d0-410ff93cb8f0; Thu, 12 Jan 2023 12:37:55 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8186.eurprd04.prod.outlook.com (2603:10a6:10:25f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Thu, 12 Jan 2023 11:37:53 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Thu, 12 Jan 2023 11:37:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8df43904-926d-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Bm2TzNmG86VyTb+YkVJHeWy7eZjV+fMTAt4aEfXTZ+/jCWWJAq5vZUrICDvPBNHyPCBK2C9OE+nTmKv3/1nAycAZrhwE6yGfuzRvMrvwlUMc0T0RiedEEKA1+M0A5s4YckAW1CyqePLBCh0y4nBxcoV757ovESQ+Tn60+KmcaPPFLqQz5XSlBIW+Fxi2hkPE3JyHA3seaHJTVSHXMuDD4jmudOWuVXD/pN02Ip0LqqkkhegHb/hVrsWoxoNSaVo0vYR+6D9A2VO6z4m5aARtqszWW8hNK844o7bSrc2YxyJQLUcH47Eb94VGmFEsJbu28j5xbDrRb3REFhedmEjEYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LFq1SuO2v0RB+u4AyJ9axFl5wmBeX6LwrzPowh4qFCw=; b=edGQJ2Ix2jOeUZDmKzyX1V5mHduawwr87FSehtRjuR3yykEch0q6N/YUDJvlyCsUtxFj9xQnYZBvPrjgWlrfOeGKaToXm75K2ZVI4xAoJ2NqmuoYvayC/nbx3DRCeXBjrex3xQkEdMEyhvnIXN69uV0+L3NkY8BdyWtLJU42c0fsQyq50cSb7us+GWW72465lWwQx+8OQMypVzptfrf2KBN4izhG2jHH6dyATBPCwAn88Q1I4kwzyC980NO23F3efBoD7JlRO5xHklRTxcpnoFO9mQ7qtRn5Rc6Vc2g538zAMTrKFtzF6NwzXNSiKKY4dVtvoDZXurWu/MLQxCw+Wg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LFq1SuO2v0RB+u4AyJ9axFl5wmBeX6LwrzPowh4qFCw=; b=2iIS3n1Jpy8713XJREnMS6DXyP/3Qt1l+wc/Zd6GQEjH3vOe96SYBeu+ZPlasdWYhTE1/Y9mO+711J6Jl/a0iSYF5jrD1A+eVTdtq7e0jhept9D0H/2B+CgPeYiCEpeG+VINVZhZInyadDS9H5NqxRijJyyKKZ8Xy/FtAiLyrPkGa3ew7bMNztfG2mKOaR0n5si5CN0fjVVaXeelo2cWmPi0/pLXHKGBd/NpRRCE35eY8v+tVZdAPgdjAOJIQgY7zX/3LVlHpkRqqd2ls+zQpHpVa5/qCVXgK1q4B+nyNuDwkvdsxRWWy/ejUwO4moc20xcm7cp3TPGpLYPKlPrIDA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 12 Jan 2023 12:37:51 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 4/8] x86/acpi: separate AMD-Vi and VT-d specific functions Content-Language: en-US To: Xenia Ragiadakou Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20230104084502.61734-1-burzalodowa@gmail.com> <20230104084502.61734-5-burzalodowa@gmail.com> From: Jan Beulich In-Reply-To: <20230104084502.61734-5-burzalodowa@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0135.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8186:EE_ X-MS-Office365-Filtering-Correlation-Id: a1a08cc4-2ac2-4f17-73a5-08daf4917121 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mbe29RhmPzt2j7O++JTtuamRvA4vrzmlpo/zpw5/FlI7EMWoVkGHb+8OqZ4hAvmu/twSTRWjbxzL8ioLxh+WcLsOn3mFjntZwuDmGqEvIeX4UmXHZf2HBQCKRj8917fhr8SH7fzKHAMcu00FHA9KmzbqBkcqqKnkfwABNGjtDbuD1fX6pMK7Ui0sU1cbYStRJp54HHotXqN4iKBqeoG7BzjHqWMn8eweneZ1l3ad82sRtducI6tVIC18vgO9zTibau39b0d1zLjoMtj9r0V74rBzkLpKPP/momp/oPVQn6BioPpCYNoDapASYngFe+yoHxF/Lw9nVYP2kzL/hwUpwPdoyD4XrxxIqZNvtQM3usVcTBlzYsCf+Ygz5av0zAcuZRGVn2l4AVv8FIW1KHI3DPllyRWqWSDJfepXQtX1Yx1CbLVGJ6mGRL4mQ/H1Z+xM9K3Tg2Xy0eeojzO2C5PpL8VWowyR9SyqSx/nBtfyoK64ymp3FMXJVl07yohuvMTp5DfBFJIKygu4/EefWGHrdAXnVCFnj+xr0L8Ln1CSMejcVRLzWP96NurJgmZcsozdPAd/aYq0SfAHSKA+Ba/qj0+AwgTwGUcQHbBSvX8NaWBQ7Z1w3sSV37kh6HulDnpaPvx2JKMeAOz/N7T1Rg/Pu1TDoXGwgTI89oXcGsxzDs3GNzMfDc9eT2zeGYzYCubdYlfnPgMQuzYRcMdBmE1aXq/nf7kKbrT2WYxnL6pNj3I= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(346002)(376002)(396003)(39860400002)(136003)(451199015)(2906002)(83380400001)(478600001)(66476007)(66556008)(5660300002)(66946007)(8936002)(53546011)(26005)(36756003)(186003)(6916009)(6506007)(31686004)(6512007)(6486002)(2616005)(41300700001)(38100700002)(8676002)(54906003)(86362001)(316002)(4326008)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c1pEUGUySUhNWXdrYWduYy9Nc0ZFaFVrVzFIK0FiV2xhZVF5cnZDcVhUZ1Fu?= =?utf-8?B?dkFLb1lOb3dWZTlXdTFINkZVeVNMbXBqYUxRRC80KzdBanBJSXBrYkpmWjdX?= =?utf-8?B?WlF4NTg0SkM5UDQ0UklSajFDMkdSSGhhQzVYMGpESFVObm1zMmhSbVNwc3F3?= =?utf-8?B?cVpOQk9mVzJzckVidENpci9hNll4WGN3L2hZL0lYazBSdUZUNWdYOEJjc3JP?= =?utf-8?B?RFdsT3dLRHJJL3YwZmpWRTFSOVRGRk0zZk5ia2xuNTVURXdDMnVkS3FoL0x1?= =?utf-8?B?WjAyQlRpL3FYdDlvdVpsRytsVGd0ZS9ZYnF2NUhSOWVlZHVDeGVCWnI2SGVP?= =?utf-8?B?MTd0bzhuTzNTUkRjQ2ZlN0dmeVY1UHAzc0NjS3BaaUl6TXZ3emNIVyt5WXRi?= =?utf-8?B?ejZMMXRWS0FHVzNaNk1OSHdGVzhRRUM3d0pLRGhMNU1ERjJuVFA5czhzanBS?= =?utf-8?B?RTV3V2hkeUxGQzU4UFI2WGVwRWh6VnBNdjdJeEowazdsK2NLQnNZSFpGaEhu?= =?utf-8?B?TXRLMTEreUNjVkgrR29mb2t2SEdtdVRQakwvZ01kekVHaHhtVXRCWDBEVGg4?= =?utf-8?B?SVJCQURsQ3N5MDExcU5oWEZqZ041YkViQWtXa2R3OXlTdTNqc0w5S2lKaFNh?= =?utf-8?B?aTdxNU01Nm1obTNqU0Z6TmtZV0JYQ2o1TjdBUzZNZytqbEY0ak1YSTJKNVNy?= =?utf-8?B?OU0wUEM0UlJ6dUxPVzhza3lKbDRKU1FKYjR2TDdXcXp2Z0c1My84TDBvTDhC?= =?utf-8?B?V0tYRDdxTk9KbUpYSU50WWY0VkVId2lRMHRYbzlmakZNWTNENnc2a2RLZWll?= =?utf-8?B?TEg4eGhXVzk5Wm1ENUxIeGo3dDlEYlczUGwvRjYzQkx5QXBZTlhFRDE0Tmlh?= =?utf-8?B?a1pQaUZpWHJoc0liMDNiN3FVekVIZEJ3a1FEUjVmUjluQlIyQTVqSk11V05X?= =?utf-8?B?cFJmZ3UxSUhsMnVEOVNCdEdIS21PSG0zaHdoK2xkSW11U2p1WHh0ekIwS0hH?= =?utf-8?B?cjh0TkpUazE5RERnZ1hXT2tJeGY5ZFN5VDZjVVdmSkRjdmh2QlR6aGU1QWNW?= =?utf-8?B?ZnpVM01ENjVvSm1EUmhveFExUmNPQncrYlgxd2dGS0FyOFphSjkwSWZYUzlD?= =?utf-8?B?bW1Pak5ZMUtzeGtNMUFMelJNbHVJMlk1YkJtSlZMd09oQmZycDN1ODN4TTdD?= =?utf-8?B?Z000K2E5KzJ0VGxKSHdLalNXWjRISWUzNSt4V2wvNFJmdHNoV3hFdWcwUkgx?= =?utf-8?B?ZTByUXF2Y3dFYjF1ZEptWWVmTjExV0NrV01aenFqc0RjMnN2cGQyRnllUkxZ?= =?utf-8?B?bHBOOVdkc0NwcnpmdjdxME9mOHg1R3RGbkREN2RHcUY3VDBWYmhTQXp0RStk?= =?utf-8?B?U09saFpZOE5PU210YURDWVVRZTZMYWxxV1ZRS29saC9VQVp0aFplOU4vSjZj?= =?utf-8?B?TEVRK3hnUXk0SXVkTGFRM0dMblpTSElmV0grSis4eDBTTi8yWDdBd1loTS9E?= =?utf-8?B?bkYxa0FwTWNvT1V5VjN1cmIwRWVEZldhanRKcUVNazkxMElUQkVna0FjYUZ3?= =?utf-8?B?NEErcXpPWXkyMHloRXVZRit2QjduUzJPY09rMytsV21mazJBSXFFanJNS0Zz?= =?utf-8?B?U25wVTUvdFNhZUFpSm5FWEZGb3pqaGVJcVFQZGR6OUszTWVBRzdMbkpoWDI2?= =?utf-8?B?aWQxeEttay9aZ2JzTkNJYkVXcys4alhobFRMRFFIQzZraGJlV1J0NFFZN2dz?= =?utf-8?B?OXlHNnRpL3BJZ0NyemNCU3VONG5Yejltd1BXblhZZ0ZwNkRLUWJWZXFvWW84?= =?utf-8?B?UGFLN2xFQzN4My9wVTk5bUJjNStEV21DRHF3SktmUm15MDRmaWlKU1BydWVE?= =?utf-8?B?M1Y4Z09ldDNPTUVyK1hBOVJiRDFhMUEzOXEraC8zczZ4ZHpNOUpUL3huYnRX?= =?utf-8?B?UW90dFpHQXFqRkxyUFNsSFBFeW84Zms1KzNsdmNIcXBXdlBZOXZ5bFQ3SGVt?= =?utf-8?B?cmtmZDlxdXV4dG1DTnhXL2YwNEo0Z0NpZTdia0E2cmxXQktMR2M0V0FYMjFS?= =?utf-8?B?T3RuRDlCbW9mYW9XYjBoOVF2UUZPQVpyejQyaDdVVGxLdnlOaDhMdUJxdmhU?= =?utf-8?Q?veqpPRF/ogqiaMzWarBhxV6/b?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a1a08cc4-2ac2-4f17-73a5-08daf4917121 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 11:37:53.3674 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wWOIxg5dTJgIQzsVyOyUtjLbU2auARFFDECXVdCuxW1pS5h0Kh88cyAYeF9wV//Wvx0w9N3MsGQRqqPXlBvh6Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8186 On 04.01.2023 09:44, Xenia Ragiadakou wrote: > The functions acpi_dmar_init() and acpi_dmar_zap/reinstate() are > VT-d specific while the function acpi_ivrs_init() is AMD-Vi specific. > To eliminate dead code, they need to be guarded under CONFIG_INTEL_IOMMU > and CONFIG_AMD_IOMMU, respectively. > > Instead of adding #ifdef guards around the function calls, implement them > as empty static inline functions. > > Take the opportunity to move the declarations of acpi_dmar_zap/reinstate() to > the arch specific header. > > No functional change intended. > > Signed-off-by: Xenia Ragiadakou While I'm not opposed to ack the change in this form, I have a question first: > --- a/xen/arch/x86/include/asm/acpi.h > +++ b/xen/arch/x86/include/asm/acpi.h > @@ -140,8 +140,22 @@ extern u32 pmtmr_ioport; > extern unsigned int pmtmr_width; > > void acpi_iommu_init(void); > + > +#ifdef CONFIG_INTEL_IOMMU > int acpi_dmar_init(void); > +void acpi_dmar_zap(void); > +void acpi_dmar_reinstate(void); > +#else > +static inline int acpi_dmar_init(void) { return -ENODEV; } > +static inline void acpi_dmar_zap(void) {} > +static inline void acpi_dmar_reinstate(void) {} > +#endif Leaving aside my request to drop that part of patch 3, you've kept declarations for VT-d in the common header there. Which I consider correct, knowing that VT-d was also used on IA-64 at the time. As a result I would suppose movement might better be done in the other direction here. > +#ifdef CONFIG_AMD_IOMMU > int acpi_ivrs_init(void); > +#else > +static inline int acpi_ivrs_init(void) { return -ENODEV; } > +#endif For AMD, otoh, without there being a 2nd architecture re-using their IOMMU, moving into the x86-specific header is certainly fine, no matter that there's a slim chance that this may need moving the other direction down the road. Jan From xen-devel-bounces@lists.xenproject.org Thu Jan 12 11:40:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 11:40:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476020.737994 (Exim 4.92) (envelope-from ) id 1pFvwC-0004RZ-1S; Thu, 12 Jan 2023 11:40:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476020.737994; Thu, 12 Jan 2023 11:40:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFvwB-0004R7-TC; Thu, 12 Jan 2023 11:40:03 +0000 Received: by outflank-mailman (input) for mailman id 476020; Thu, 12 Jan 2023 11:40:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFvwA-00048u-Dx; Thu, 12 Jan 2023 11:40:02 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFvwA-0006Pr-9Y; Thu, 12 Jan 2023 11:40:02 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFvw9-0005Ii-Ib; Thu, 12 Jan 2023 11:40:01 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pFvw9-0006Ov-I9; Thu, 12 Jan 2023 11:40:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=avweWqgI9AuhWW5Puu0N/9J/w6+LW8qnVQzpXlRS65I=; b=ELMq3lgE/PQnLO5vCwJY8JC44t N1e/pRH5krjszzXnzh4xQqDP//adozDlhe6lNaFDCe3QoESVEwNEGbgrQ2lGgAsf8fXOsVRwknJ0d aB0wY7e6Jf4NP6m1LLAfEvFFO2hlLDD4CsXZoeFykvxHbTOMZDa5kK+sl0BYJxZD8SZo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 175736: tolerable FAIL - PUSHED X-Osstest-Failures: libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: libvirt=12a3bee3899cdba8b637a7286f24ade1214b6420 X-Osstest-Versions-That: libvirt=a5738ab74c2ab449522ddf661808262fc92e28d7 From: osstest service owner Date: Thu, 12 Jan 2023 11:40:01 +0000 flight 175736 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/175736/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 175718 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail like 175718 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 175718 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 175718 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: libvirt 12a3bee3899cdba8b637a7286f24ade1214b6420 baseline version: libvirt a5738ab74c2ab449522ddf661808262fc92e28d7 Last test of basis 175718 2023-01-11 04:20:41 Z 1 days Testing same since 175736 2023-01-12 04:18:57 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Fedora Weblate Translation Jiri Denemark Weblate jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git a5738ab74c..12a3bee389 12a3bee3899cdba8b637a7286f24ade1214b6420 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Thu Jan 12 11:49:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 11:49:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476055.738023 (Exim 4.92) (envelope-from ) id 1pFw4w-0006XM-Ej; Thu, 12 Jan 2023 11:49:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476055.738023; Thu, 12 Jan 2023 11:49:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFw4w-0006XF-AB; Thu, 12 Jan 2023 11:49:06 +0000 Received: by outflank-mailman (input) for mailman id 476055; Thu, 12 Jan 2023 11:49:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFw4v-0006X7-12 for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 11:49:05 +0000 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [2a00:1450:4864:20::631]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1be0c42f-926f-11ed-b8d0-410ff93cb8f0; Thu, 12 Jan 2023 12:49:02 +0100 (CET) Received: by mail-ej1-x631.google.com with SMTP id u9so44174752ejo.0 for ; Thu, 12 Jan 2023 03:49:02 -0800 (PST) Received: from [192.168.1.93] (adsl-139.109.242.225.tellas.gr. [109.242.225.139]) by smtp.gmail.com with ESMTPSA id ky17-20020a170907779100b0084d3d6500b1sm5683416ejc.101.2023.01.12.03.49.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Jan 2023 03:49:01 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1be0c42f-926f-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yHN027+HQ+YTwz5jGusmp+H/3j6JCwBH17SmyR9HxS0=; b=joh2i586bruj09jicjFptGD3d2tNKQX3ELplLZB2ZSLCG65EqSuc7+2UrUy7DNjrJJ Rd0ogYNseRGIYlC+NwO7HNd7G88nlZ5yfcwNuSeb83o+V6ZD4FKEJp+bp3qoofJVbXO9 x6H/y+G36GVMbirjEfSrhpjQuwaHw6wy6QTYu2QIWG5vZTcydj1kqvH3a3RkKRAsH/PF rjUdqzJWRs64lX1rzAbJviLJBIbh/6+aMCF6qHLjfMUhQVXbEJEK/OBI8gCDDiAQcu69 +DXXUhMDfLC2cpI6F3eQkE4w1YRfiK82zzJ8p6ZFr0c75Da+lTYZd9Y0A4sTzNm1FBO9 GzQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yHN027+HQ+YTwz5jGusmp+H/3j6JCwBH17SmyR9HxS0=; b=FJdTzeypAfMJxJUgGIt40++CvLAnQZsAKnsD3z/bxHXA7FQkFgp9/GEnYN+vsOvKsU XJk0hkhkltSDrn/dQ3rCVlDUG3hFJtwsksvoIEUFUyX0HK35jubuLbXNR8dWWaxwGR3c J6BgCaTxesBMpb3+z0cDCENpOAyyXkII5eCKHQPvCP3ZGrQaSQWddPSOBdnliyfFNry3 207T2Mgt8ZQYdtLX3kYqnNe3LuDD2GoNtBbnWOHev5q1hCO3onE2fpl/Mc1CD2S6xx4t hyk9llsI77eOPsWU2CShFyhrd9o9pYwSU2WsSIdDsCb3TljqPkAAPdtk/7fbtonzUDt1 mlkQ== X-Gm-Message-State: AFqh2kpQ6b4qKI4j1kbQRpGa1Mu3yDsexnyWDMEiknNkPw9aGMfxI67T F8XJQfBgW+0hM2ctCD/DKWg= X-Google-Smtp-Source: AMrXdXsXi+a3DZ8lS0Bvkc3s3sbFvbp9G9Ee13eFDPEpFxGXD/rlR04WD1NhvqrIVT8frxb8qOB1RQ== X-Received: by 2002:a17:906:bc47:b0:78d:f455:3110 with SMTP id s7-20020a170906bc4700b0078df4553110mr58672489ejv.56.1673524142226; Thu, 12 Jan 2023 03:49:02 -0800 (PST) Message-ID: Date: Thu, 12 Jan 2023 13:49:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v2 3/8] x86/iommu: iommu_igfx, iommu_qinval and iommu_snoop are VT-d specific Content-Language: en-US To: Jan Beulich Cc: Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20230104084502.61734-1-burzalodowa@gmail.com> <20230104084502.61734-4-burzalodowa@gmail.com> From: Xenia Ragiadakou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/12/23 13:31, Jan Beulich wrote: > On 04.01.2023 09:44, Xenia Ragiadakou wrote: >> --- a/xen/drivers/passthrough/iommu.c >> +++ b/xen/drivers/passthrough/iommu.c >> @@ -82,11 +82,13 @@ static int __init cf_check parse_iommu_param(const char *s) >> else if ( ss == s + 23 && !strncmp(s, "quarantine=scratch-page", 23) ) >> iommu_quarantine = IOMMU_quarantine_scratch_page; >> #endif >> -#ifdef CONFIG_X86 >> +#ifdef CONFIG_INTEL_IOMMU >> else if ( (val = parse_boolean("igfx", s, ss)) >= 0 ) >> iommu_igfx = val; >> else if ( (val = parse_boolean("qinval", s, ss)) >= 0 ) >> iommu_qinval = val; >> +#endif > > You want to use no_config_param() here as well then. Yes. I will fix it. > >> --- a/xen/include/xen/iommu.h >> +++ b/xen/include/xen/iommu.h >> @@ -74,9 +74,13 @@ extern enum __packed iommu_intremap { >> iommu_intremap_restricted, >> iommu_intremap_full, >> } iommu_intremap; >> -extern bool iommu_igfx, iommu_qinval, iommu_snoop; >> #else >> # define iommu_intremap false >> +#endif >> + >> +#ifdef CONFIG_INTEL_IOMMU >> +extern bool iommu_igfx, iommu_qinval, iommu_snoop; >> +#else >> # define iommu_snoop false >> #endif > > Do these declarations really need touching? In patch 2 you didn't move > amd_iommu_perdev_intremap's either. Ok, I will revert this change (as I did in v2 of patch 2) since it is not needed. -- Xenia From xen-devel-bounces@lists.xenproject.org Thu Jan 12 11:53:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 11:53:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476061.738033 (Exim 4.92) (envelope-from ) id 1pFw8v-0007vk-VP; Thu, 12 Jan 2023 11:53:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476061.738033; Thu, 12 Jan 2023 11:53:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFw8v-0007vd-Qp; Thu, 12 Jan 2023 11:53:13 +0000 Received: by outflank-mailman (input) for mailman id 476061; Thu, 12 Jan 2023 11:53:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFw8t-0007vX-Ob for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 11:53:11 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on2089.outbound.protection.outlook.com [40.107.8.89]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id aee1dec5-926f-11ed-b8d0-410ff93cb8f0; Thu, 12 Jan 2023 12:53:09 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VE1PR04MB7440.eurprd04.prod.outlook.com (2603:10a6:800:1b2::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Thu, 12 Jan 2023 11:53:07 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Thu, 12 Jan 2023 11:53:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aee1dec5-926f-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=deUE0beiV6s4dBqSeL21H81a7whbJOZEWoq8W+HMOyhcq+8P9MUrGxebEfYrlHibPjCk83Flv5ZukozzSIUbsdHPbqebdcDiBj3qbXpAdSNrq9LbxB+KT3pLaEMToj3aTpJkFyCekcCZuxJvbzo4hV2dkFxz4aB0W9svF45HIH0RcvRWhRKbT8fO0iqdWU0UFEbjgaLXKw509ORdAaH68aXHdw3iE+xri4uHz+YJ1FXW5ZiQetXRjm3XQm1+13SSPGnAyBrRbRPRef0DPK3ZT3C+j0KcwLzf09OZuU6HOL7sVaEq/sS0j7M2/nr0VLwmKCsg23Lb8QTjyiSDcTTlBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KjdNKbn2xVptyjw2QC5CMi6NcNrZEWVWFKNRxHh4GR4=; b=QD7hAIlN2hp7ks+QVIERPtjRfhHAl9xP5aoVzYUFv+KG53jSaLIf+5/QeCb+eq+146YGtxZRZ4UZxiMhZ84X4fn9Fo+IeaiHJd65ahj4M+CvjKksRcLs4cza7QnmqDbjFWCxjpiwC2OoCEzS7RagdTDHJeHAa4ZampCEovgxwzZNxq8YUWnH3FlJr2Okbnm1N4SaANtYZaogb4B5z69x6442v3I33v78Fn7iNI0rKEOgvoB22rhfQVBgiqL1TGcF4ZDP/+qx1zBi4JV1r0rPHfx1tRXIBARbSfSjuKIedsEsSLwOapr36AOxABp9BqhU4yq0BdWT0NQ9R1IlMga8tg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KjdNKbn2xVptyjw2QC5CMi6NcNrZEWVWFKNRxHh4GR4=; b=MlVoGdGTKA+4Sep7XLk/lbmJnRhxQsfr4brPbO7st4vejpfOOCi4D9b01k04rTHG4krmjXMaN8O+uNHynZTppSKHNCeiUbNDCyP8hQ/bJrGmnPCA9r+WfKGrFxzewwH23s/wb6/RILIfHzkmU2+OGoHF5bo6xGuxMxh0gmZ502Bg43BHLlAneBPnAz0qE+mbOHrHTp6tY+MBw1yGWQYNKM0qFoKskLN1L0nnjmPQmfTbbfQ1JU4Dv/5tVJaZJ+s88NI9kKASFbWs8tcZKcpKTqGxK83iyMVUK8B05+Ixd+ftGRM+XCOXXbjDHG8/o4BO+jew+uWNl1Nl/jRGzsRZIA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 12 Jan 2023 12:53:04 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [RFC 5/7] x86/iommu: the code addressing CVE-2011-1898 is VT-d specific Content-Language: en-US To: Xenia Ragiadakou , Andrew Cooper Cc: Roger Pau Monne , Wei Liu , "xen-devel@lists.xenproject.org" References: <20221219063456.2017996-1-burzalodowa@gmail.com> <20221219063456.2017996-6-burzalodowa@gmail.com> <5a78ab9f-ce3a-a4f5-9768-725bd9f8a745@citrix.com> <13b1c5a5-35c3-a413-3458-ce39c7799a10@gmail.com> From: Jan Beulich In-Reply-To: <13b1c5a5-35c3-a413-3458-ce39c7799a10@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0210.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a5::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VE1PR04MB7440:EE_ X-MS-Office365-Filtering-Correlation-Id: cde16e8b-caa7-4064-9d4b-08daf4939182 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8NQtk6IyJZg3oh27fFPagSRJ8MIJU3NRAK2fqbJNtpyLt4PpCuooXD63b7dyDFEChI9AIMIY/ui3cotdlF5Ppnrlflvg7rJhYMbuosN/Yedh5JyQIDrlDSnyfUZgy0qaFZUucKyLQKwVCFxndGPxlwZDE0461UL+bvayvsJ2CphVImZDEx5ZeMh0NxkKuF90OHheL72gXZRWIw7iU0VBK3NV69awrFeMv7ppHomLyBNyGUphO7BqTT4BXt3Cddly9G6L6lmCtNfC/zrKsDeUG5/fKfW9eWWzSkW9ShqqDgZWoTYs9tjgSzlO/QczRfSFSSOX5GuhTMU/2FMrvWq1JcpKpOmRLXwcbwVMQI9BlWF0s0D+JX7ZHFcCXd6Ir8+2Vh2QIooiwgHtjRqFuUS8+F4mFHhDTBPdVWBy5mREeKYyikGRPEfPguay7oJT7k8CHfQeNvnlAB93idOs582QNxcT9GWytmROZhcoU/EAqzs3lmfTIABSbaj1nh8eXaEHAa+vQZVx8c124L9tFcA4Shcmepr2ouiF0vcdGvC94A25lFeGAuJgpnOriIg5CTmf8xVnYsmunmFldbPPMPpvefpe3CuDaxJ3EMRTFaSPXMzkan+rKm5i/8qpBY6mZ+z7/Ahin4wQBlQR+IE3n4FwnULYFmdv20I3xPuTuwNGgIBriEjjIfbk2ZwKR/d/OLFeq1naT3U3EQJ+EU640chubO4WVIV96QdJadkRpG9zNUs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(136003)(39860400002)(376002)(346002)(366004)(451199015)(26005)(186003)(36756003)(8936002)(53546011)(6512007)(31686004)(2616005)(6486002)(6506007)(478600001)(66946007)(66556008)(5660300002)(66476007)(316002)(4326008)(31696002)(41300700001)(38100700002)(110136005)(54906003)(86362001)(8676002)(83380400001)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YzNTaGxSQnRLbmtwcEw5YUJjYXlUUllzRE10V3dLNGlubTZ3NFRreUhyZmho?= =?utf-8?B?RStKSHFlc3hkMDVkazZlc1F6QnRPYWJKZzczcU1IOFMyeXloNFF0VXM2S0Vi?= =?utf-8?B?WTk3Z09CWXc4alJNcDZqMlJtczFzb1dNc3c5ZlkwMWdWRmF6YnprWDNsRlJF?= =?utf-8?B?NTFBeGZCeDl0QVBOcnZUMUZwL1dLZEFTWm9NOHI4TURnYTRBOTM4bHYwSkta?= =?utf-8?B?RmpKWVQxcTd6WkJxengyMTRmYyswRG1EVXZQVjFuTUdnZ3lpMk5SRWlBdVJW?= =?utf-8?B?b0dMK1NLTjVBQkNrcUFISGoxSW5JRS9QTFZWYWJBSmdMalM2Q20yVUlUeHRD?= =?utf-8?B?TXdsZ25HUHIzTTNCVHFHYS9VVUxPQit3WTdmekVobUxtTy9MaCs5ckFFTDN0?= =?utf-8?B?M3hOMkVSQVdodm5uWk5Vdmw1V3ZGQVB2T2lnczdoL0pTQUtoaG10VGxHS3VX?= =?utf-8?B?eXhjUGlUcUZMamlRU0pGaXdIVFYwNHA0NWl6NlVHRm9Xc0Z5UEhoN3R2WjYw?= =?utf-8?B?TmJjK1JmeDJnTnJmbGRhb2lTRTVnUnRHNDc0U1JhVU5nZG9jUFVTM0FHSmgz?= =?utf-8?B?TzIvcjd3U3lFRUs0YmhQTWxmYnVQZ0V2VzhxVk90dmFTSDZDOEd5NzVacjdG?= =?utf-8?B?S1RoZWQrSXRDcHVhdXYzZFIxRmdqRzQzYkhSclVlV2MzZlhjZ1ZFaEdSK045?= =?utf-8?B?bW9qZ1E2Q1c1VFh1eWlFUnhqS1Q1aWtBcEVBWWlaZExmb3p5cnBhNHAxeW9i?= =?utf-8?B?aTQ3R2ZPejBnK0lrVVdmV3FQTjZKZ2IyUS94ZXc2OFg2RVRvUWtpa3dCYnJm?= =?utf-8?B?NDVtUllLbkliN3ZpV2ZXYk1MVlIrR2lFNHgxN04rbkZrdnFISWhOTDdtZXVq?= =?utf-8?B?WlN2UGk5U3dpV1VnV2pOQ1ZoRmFSZFVpbnNNK0lmaExzSnl0cVVhZ2dGUi8y?= =?utf-8?B?SEJJL1dFMnZuTm9GOWlxN2pyQi90czhicGJ5SnpORnN5K2VJdzVtd3RlcGY3?= =?utf-8?B?MnpuQzZJenRMTjRLTHZjZ0doSmtDV0pid3FpYW5uS2FKcDZtd0t0TEh2eTZh?= =?utf-8?B?YTZ6czdYd2pTdTJMVm51U2dmL2ZoRUoxd2phRTR6VWU2SDJzbndlYXBoTzVD?= =?utf-8?B?ZVZuaitoT2lKb3I2SktrU3ZDcHluNXNxdERGZWtZdWR1V0RYN2paK253eXBr?= =?utf-8?B?dDlxbjdwK1FVTUc3NUdJc1R0YVZ6TTRoMDJoajhTK2Q3aHQwSFZnb2VvUzk0?= =?utf-8?B?eVFEQlc2VnZXcmRSSCsyQTR5dW5kKzVmY2IydjRRTXMvOGtIUkdHd3AwRW45?= =?utf-8?B?OUcwRDZoWTIwWTZkZ1FkdDhGNUVldExoMHV0cktBdG1kS3NDd0l6MHI2NWJ0?= =?utf-8?B?T0JzbkxvVXpEaUhMKzJtRERMb3VlOUY1d1NtWm1aM1N2dkRWUWZNU1NNSEwx?= =?utf-8?B?UGdGZS9RNjc1SkFGUVJzczhMZGJPVHFiQ2kvbWpiQ0dmZTFjcmlENEpPVEx1?= =?utf-8?B?cnJFOUNLSzluWUordEkwU0tnMFdIaGYyYzVObGZhczIzaFFES3RWVTZYT2ZV?= =?utf-8?B?RC9wTm84aC9xczdUQ2UzT3FqV0VXeDlPUVhOaEFGY0lGYjBkSi84NElQeVdm?= =?utf-8?B?VC8rMlhycmlsajNKUHgwMFAxTjdrbGI4ZkhwZ0NSZkNrVlc4Lyt6RUdXZjNi?= =?utf-8?B?NzJCWUd4SnBQSHR0RmpDSnBjNXUxdkVac0NEbVcrZFV0ZlNkWlNEbWRENDM0?= =?utf-8?B?UFZTTmFqV3J2T3dEbWlkS084c2NXN0t4b3dHS21Md1d6KzVFeXJpTmhVK2Qx?= =?utf-8?B?Z01aUWhabTdxeVY4em1aaHZwdTZKb1RXbXpoczdGVjJrTmJjT0ZUTU5lR2lv?= =?utf-8?B?K2JvQmkwOXBxdjgxeG1YbGpoa0lXTXRYSjhnSFhFdkhRQWozOTlrMllTWGYw?= =?utf-8?B?OEdBbENCb1ZqVitSQ0RpaU10c2ExZGhqM0s0Z0VPSFhtOUxHdXUvWXN1Y3BO?= =?utf-8?B?dEZFOU9ZMVZMWjR0bk1hNFRYK3p2OXdqbVdrYWlzR0hMODdIYnFLcDRDK29y?= =?utf-8?B?b1p1Y0FDcFRuRG5HcHUzWEdGNlVNWU5NdDhTelB3RlBsU2dIekY1bHFDelpO?= =?utf-8?Q?Av9/nSy5QKxildrD5lriwqZM2?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: cde16e8b-caa7-4064-9d4b-08daf4939182 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 11:53:06.6847 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ubN3oshNbdXO5GANCBV427504NqdoKSO9GXiIOLfsqWpW3MuoTDL7FKYQ1wQChDrdm1o4LNYLRd9WiTmwEWmKQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7440 On 21.12.2022 16:22, Xenia Ragiadakou wrote: > > On 12/20/22 13:09, Andrew Cooper wrote: >> On 19/12/2022 6:34 am, Xenia Ragiadakou wrote: >>> The variable untrusted_msi indicates whether the system is vulnerable to >>> CVE-2011-1898. This vulnerablity is VT-d specific. >>> Place the code that addresses the issue under CONFIG_INTEL_VTD. >>> >>> No functional change intended. >>> >>> Signed-off-by: Xenia Ragiadakou >> >> Actually, this variable is pretty bogus.  I think I'd like to delete it >> entirely. The important difference between Intel and AMD was that Intel initially supplied DMA-remap-only IOMMUs, while AMD had intremap from the beginning. Hence Intel hardware could be unsafe by default, whereas on AMD an admin would need to come and turn off intremap. Deleting the variable would be okay only if we declared Xen security-unsupported on inremap-less Intel hardware. Extending coverage to AMD wouldn't seem unreasonable to me, if we knew that there were people turning off intremap _and_ caring about this particular class of attack. With no-one having complained in over 10 years, perhaps there's no-one of this kind ... > Nevertheless, I don't think that it would be appropriate to be done as > part of this series. I agree, but I'll want to comment on v2 nevertheless, rather than simply ack-ing it. Jan From xen-devel-bounces@lists.xenproject.org Thu Jan 12 11:59:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 11:59:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476067.738044 (Exim 4.92) (envelope-from ) id 1pFwEo-0000EM-JH; Thu, 12 Jan 2023 11:59:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476067.738044; Thu, 12 Jan 2023 11:59:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFwEo-0000EF-GT; Thu, 12 Jan 2023 11:59:18 +0000 Received: by outflank-mailman (input) for mailman id 476067; Thu, 12 Jan 2023 11:59:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFwEn-0000E8-JV for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 11:59:17 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2062.outbound.protection.outlook.com [40.107.21.62]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 88028134-9270-11ed-b8d0-410ff93cb8f0; Thu, 12 Jan 2023 12:59:13 +0100 (CET) Received: from DB6PR0202CA0014.eurprd02.prod.outlook.com (2603:10a6:4:29::24) by VI1PR08MB5357.eurprd08.prod.outlook.com (2603:10a6:803:12e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Thu, 12 Jan 2023 11:59:10 +0000 Received: from DBAEUR03FT034.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:29:cafe::32) by DB6PR0202CA0014.outlook.office365.com (2603:10a6:4:29::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.13 via Frontend Transport; Thu, 12 Jan 2023 11:59:09 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT034.mail.protection.outlook.com (100.127.142.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.13 via Frontend Transport; Thu, 12 Jan 2023 11:59:09 +0000 Received: ("Tessian outbound 3ad958cd7492:v132"); Thu, 12 Jan 2023 11:59:09 +0000 Received: from 1ec22c67a624.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4F09958B-D486-4548-ABFF-F62E25853036.1; Thu, 12 Jan 2023 11:59:02 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1ec22c67a624.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 12 Jan 2023 11:59:02 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by PAWPR08MB9662.eurprd08.prod.outlook.com (2603:10a6:102:2e0::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Thu, 12 Jan 2023 11:58:59 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::b14f:1c13:afa:4eda]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::b14f:1c13:afa:4eda%3]) with mapi id 15.20.5986.018; Thu, 12 Jan 2023 11:58:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 88028134-9270-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b04EwoN0FW7LGyusLHilN8gQmZ/uqEa7Olpc5LoLThk=; b=xcRhboPg/QbZ/qTZiDwo3418jUvNCChBM7sUxlS3dsSxwZjm5X9uVX75cHQLEPt3nmObOfcBbQNn+2VrwSrlLxplgiLNngWMLbMspM3hqEZolZy6KUYNaWUsvcNSx56wSffTkXP2QGJwmgAvWm5YPJ8dsBbvi6qXaG5R00pFblQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 413c25dcfd4db4d7 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SFM3f6U2kaE7sTxEq03FHGCSeM6+aLbBQStIl6dC7jVpGkq5EWvMJ89GvHnMWnDixVb+Uqvr+a7877iY2kD2G9Xuf+viBTX7MVmGCfHsQ4ULurKh8DHxws2vOolb0fUU6QTwRsjfkPXhi63r4R/geIaXCnNkTL6dsOk4LGWhCzOI7p2oJ3wl2UWBpIbf628b240BJ/6qDF5hpJd3PYq91OPzhYw0Fy+gobDUtl9tFO+sqqojjyRII8Z6FRoGM1aOpucNG8zTKcbfQcjjmnMCET/zUVPOYcshyfGaKNLE2wiQm3RnoQw2ACVFYOUk0OqBDOuX/PQgkV6vm7u3zg2KpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b04EwoN0FW7LGyusLHilN8gQmZ/uqEa7Olpc5LoLThk=; b=ASCSPYcB/N2HLZD/UCfmWMZWgk+Y09BRJ7iZw0xJG18av38atFkaGXq87r0dQIVGtVBdTQ+s/cmnpvWg82Ulcx9Da7X71AWyOrsQ7NBO3LWyzZ4WQZibQESvEpZzICRm5wdS0ec6esQ9OuIFpqMWAetruuWxCa91xaJxGiAR0jsfJQPinMWgxAz3PvyyneAGhANhjc44uzKOSJPkVX+ganiALp7wUpH/wwQ4DMvCBwD/pVuN8opUy22cKxI9+5nFuEEx7Onu9521t8NnV2Yp7Mgv2rmuUO/94a18lZ57daan1xf5PyN7VVxV8lD22NZRZirN9fZTO2u1DWxLloMZBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b04EwoN0FW7LGyusLHilN8gQmZ/uqEa7Olpc5LoLThk=; b=xcRhboPg/QbZ/qTZiDwo3418jUvNCChBM7sUxlS3dsSxwZjm5X9uVX75cHQLEPt3nmObOfcBbQNn+2VrwSrlLxplgiLNngWMLbMspM3hqEZolZy6KUYNaWUsvcNSx56wSffTkXP2QGJwmgAvWm5YPJ8dsBbvi6qXaG5R00pFblQ= From: Luca Fancellu To: Julien Grall CC: Xen-devel , Wei Chen , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Anthony PERARD , Nick Rosbrook , Juergen Gross Subject: Re: [RFC PATCH 0/8] SVE feature for arm guests Thread-Topic: [RFC PATCH 0/8] SVE feature for arm guests Thread-Index: AQHZJcp9wvywjfWnlk+ZpWy3G+b6x66ZcImAgAE+VAA= Date: Thu, 12 Jan 2023 11:58:57 +0000 Message-ID: References: <20230111143826.3224-1-luca.fancellu@arm.com> <3e4ce6c0-9949-1312-f492-913b7dd2cf18@xen.org> In-Reply-To: <3e4ce6c0-9949-1312-f492-913b7dd2cf18@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.300.101.1.3) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|PAWPR08MB9662:EE_|DBAEUR03FT034:EE_|VI1PR08MB5357:EE_ X-MS-Office365-Filtering-Correlation-Id: 261e2b72-f7d9-420d-4aa6-08daf49469f6 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: hrfVuMOki6+0+okyFsiT4iWZzu+BE5c/pjKIkEeZ8A2LIZvbnbh9jQw4EEJdvv/JrXq0dEbtxnc74YrbiAOYRQeY2jMim9Gp6os6d+yeui9VpgBwc22ZbuOY0Emi2WkMwJMhcPJ9tc+gv+tK4FQ1UUg+pMNM2BSIgCQxNxjSLPqJvX/ih70ig51z2ZVDTMXvq5XBhv4FaaO5c3ernuHQxiDeIk2r63NYIXnHWxBLy/pYMPJkR+Q1BLbi6J7nGqiFYNjsHA8Z/9z27wv2jt8BwFvs+egshKkEkxlzw87IqGh8aqYtTn3P1s4XEHbkbpwiNbVoGb15Ff5n4xTTY0y2JJxbRpjVeVPOxggbRwMoHAe59ui3cAeD8pCKGxOMTpK/XkSM0wnMthKhnqWqT78xRkieXKgn1OpKgulA0peaPv5js46D4ghg71iQ/Zw5hlySlmtEObUnvB/y2TfjRiATTvl5jafdFY9Y6MqpaIsqwPjjU+yZLN6hL6v5o2YgANpC1ybBamHMlNI4sz+a7Lb0VQOqNRXiT1I8YnOtS0OVPuBDTNjg6P4fdmfwJ4Hm5mejZzupTa/9tRG5OsYFdzR8zzApKNS/NhCuE2jK6UUNKOe9xEgV4m2Sq/6K69dBAyMWxyVi8gQZFkEtTThnlkNrmAbukuCjjpVLpnPcVCur/X1wBbxa1qDoey/wvLyV4rKsWCm/Edi2uhrBqvn7fGtl0MQfhrwLg+oW9NycKIronI4= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(366004)(396003)(376002)(39860400002)(451199015)(36756003)(33656002)(38070700005)(5660300002)(86362001)(54906003)(6486002)(316002)(6506007)(71200400001)(6916009)(66446008)(7416002)(2906002)(478600001)(76116006)(64756008)(91956017)(66946007)(66476007)(8676002)(41300700001)(4326008)(8936002)(66556008)(53546011)(38100700002)(122000001)(6512007)(2616005)(26005)(186003)(83380400001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9662 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT034.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: bb99040d-916e-4f58-0ef3-08daf49462e4 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AePsOndc3Qcq5slBXYbvF9RAM0RktP7k0LCxG5fqKhMNhbHReC10ypZMFB070ZYIFKEAvq6gnfvTj6v98/s9nXJ7FuMjDvcd4M3EWqxYeDCKaFBuDZGi7Lg3R/E5a8pRZ5BsF66KMLO0QNgFWNSaekeGX+1xrVRB7PD9oYpQq9ajdXp9fz1V9X2GHyViy4BXEmSaEhYteS//4LtAp2GuaN9GmDaA2LyC8zF6tUhsYeVLCRuVNPc74yRXkK91JQM7mWPYOBgl5et0OwslJ3KoMEQQYfzPHttmjdwhhCJnYgNPje8sZw9/n7SWX87BES96scNNQSquk4Abl32OQoWjSgSPxqW94k8IjkVHwlQUw8vZg9vubx+CQ2vPvVl9VH4jvf1U4YZB0uIAZ6b7ofgqPkOQpOIraJpQ0Yf4Qsjf/W7TzrYOkBEMOAwZu/zETBTuP9ZYsWZpKtFt8us0mnIrgbg2vj6kpi5o9NKdTjhkSWhnssx9D0tDTEjJvyi1CBzotgwqm+UqufidpxCi+fZN9fZr0seQcXzgg+j0QLLwEAqlOY1K6E7Rd40qZ7K/YN4P0C7bSvZLqqKdlCNBpPSToybV6zhmBNJZrXh844hZXYCdnT5IYy/kEdGRH9or5hAzYVuns+fHdr2oGs/Lr8Af1FN17kG1/LbH5zt9hs5UvY0eDliDQVLoMVtMmahammcNd2bVQ/flVRCL1ONTp+T+Eg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(346002)(396003)(136003)(451199015)(36840700001)(40470700004)(46966006)(83380400001)(70586007)(70206006)(8936002)(6862004)(6506007)(4326008)(336012)(82740400003)(33656002)(40460700003)(36860700001)(47076005)(8676002)(53546011)(41300700001)(86362001)(82310400005)(478600001)(40480700001)(316002)(6512007)(6486002)(81166007)(2616005)(107886003)(2906002)(54906003)(26005)(5660300002)(36756003)(356005)(186003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 11:59:09.6432 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 261e2b72-f7d9-420d-4aa6-08daf49469f6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT034.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5357 > On 11 Jan 2023, at 16:59, Julien Grall wrote: >=20 > Hi Luca, >=20 > On 11/01/2023 14:38, Luca Fancellu wrote: >> This serie is introducing the possibility for Dom0 and DomU guests to us= e >> sve/sve2 instructions. >> SVE feature introduces new instruction and registers to improve performa= nces on >> floating point operations. >> The SVE feature is advertised using the ID_AA64PFR0_EL1 register, SVE fi= eld, and >> when available the ID_AA64ZFR0_EL1 register provides additional informat= ion >> about the implemented version and other SVE feature. >> New registers added by the SVE feature are Z0-Z31, P0-P15, FFR, ZCR_ELx. >> Z0-Z31 are scalable vector register whose size is implementation defined= and >> goes from 128 bits to maximum 2048, the term vector length will be used = to refer >> to this quantity. >> P0-P15 are predicate registers and the size is the vector length divided= by 8, >> same size is the FFR (First Fault Register). >> ZCR_ELx is a register that can control and restrict the maximum vector l= ength >> used by the exception level and all the lower exception levels, so f= or >> example EL3 can restrict the vector length usable by EL3,2,1,0. >> The platform has a maximum implemented vector length, so for every value >> written in ZCR register, if this value is above the implemented length, = then the >> lower value will be used. The RDVL instruction can be used to check what= vector >> length is the HW using after setting ZCR. >> For an SVE guest, the V0-V31 registers are part of the Z0-Z31, so there = is no >> need to save them separately, saving Z0-Z31 will save implicitly also V0= -V31. >> SVE usage can be trapped using a flag in CPTR_EL2, hence in this serie t= he >> register is added to the domain state, to be able to trap only the guest= s that >> are not allowed to use SVE. >> This serie is introducing a command line parameter to enable Dom0 to use= SVE and >> to set its maximum vector length that by default is 0 which means the gu= est is >> not allowed to use SVE. Values from 128 to 2048 mean the guest can use S= VE with >> the selected value used as maximum allowed vector length (which could be= lower >> if the implemented one is lower). >> For DomUs, an XL parameter with the same way of use is introduced and a = dom0less >> DTB binding is created. >> The context switch is the most critical part because there can be big re= gisters >> to be saved, in this serie an easy approach is used and the context is >> saved/restored every time for the guests that are allowed to use SVE. >=20 > This would be OK for an initial approach. But I would be worry to officia= lly support SVE because of the potential large impact on other users. >=20 > What's the long term plan? Hi Julien, For the future we can plan some work and decide together how to handle the = context switch, we might need some suggestions from you (arm maintainers) to design that pa= rt in the best way for functional and security perspective. For now we might flag the feature as unsupported, explaining in the Kconfig= help that switching between SVE and non-SVE guests, or between SVE guests, might add latency co= mpared to switching between non-SVE guests. What do you think? Cheers, Luca >=20 > Cheers, >=20 > --=20 > Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Jan 12 12:02:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 12:02:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476081.738055 (Exim 4.92) (envelope-from ) id 1pFwHT-0001qz-Eq; Thu, 12 Jan 2023 12:02:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476081.738055; Thu, 12 Jan 2023 12:02:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFwHT-0001qs-Ba; Thu, 12 Jan 2023 12:02:03 +0000 Received: by outflank-mailman (input) for mailman id 476081; Thu, 12 Jan 2023 12:02:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFwHS-0001qm-0w for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 12:02:02 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2052.outbound.protection.outlook.com [40.107.21.52]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ea233db1-9270-11ed-b8d0-410ff93cb8f0; Thu, 12 Jan 2023 13:01:59 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM7PR04MB6984.eurprd04.prod.outlook.com (2603:10a6:20b:de::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 12 Jan 2023 12:01:57 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Thu, 12 Jan 2023 12:01:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ea233db1-9270-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jUKktZSxN0XogMcel4W4RqwZNc8E5YPKahgi0z7g1bEpmrjViS7R80xY+uPVXCVFxJJuuIZBfOvzhZ89TeZxzLxxAjp7VPnlVNf3lAMgHhEq8nRuKEGhaiPfGTtGNH4JvhekXtPkpGZPapoMq2PjLveJiseAnNlhWg4Ht+t9EBEVG5S1bbLQMxUrBo8+8/b/i0KNlOMm54a/xJSCZESo9CJU50m98zgA6fgoQhhE3FnpBov6GydgE4c045e1rA020Ghkxw134dkOwY7mPmVBIrh6foQ0ghOarD9boiYArGTv9mxlXHDFgXBwRrRcJx9BLpTGQYatl1Lp0Vit79OiFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=z5xqAFELM6aeYRPpdl2iJ0uN5YRwxvbcSRYvU8IYJrA=; b=dy1RfBJUlMAii7gQ0y8Vet9+1T2XriaOj0PETE4ecuahZWWGb9uwe2NKe3z+GOTnIj0QVsgopIECC30/AMraaZz9UzPKmhz8PtdVf0xGv3Hkd2EInm2WUaxd+eDEx+jzmscmjDpcfdwUjSMz/Myf88gt4znLQLzW5MrsXF9JDaappILjkZnVfj7PS7MIYJ0VUK1ViWqIZ0TxhW/5wejIdQmhSoDQm8sgj3WS6uP8fpixggWDJWeqknvF4gbz4n9qb5y3dPZp7TDEjDC1ZsjCTV8UX3OOMFMqRHi+x90NQ9khMtQXgI2htxDIbyzmYsNHksGprSYT6/IpDtEByXC/XA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z5xqAFELM6aeYRPpdl2iJ0uN5YRwxvbcSRYvU8IYJrA=; b=guJ2ePpDvdZP3D8gJbIk+BCBais8+K7AlH4HcpzE00zNo9pYt+46e4ARKVNJ/0dD9xJU2rDZRVXuGvNBzBwVcxkJmaoqZ9Lspi7iLRdbnZ5fTaCPabwvtLRYBETJ/gUXWp+TeozXDFTcsOQWvKPnn7nVJWnzLOmAmZ0f+MLZiHh0ilH/L5Hc9t6eYilggO7CxRy0iyn7JrezKp8aHV6K408nRuz+9RIcZO3bT6r6PTRLgI/rmlp04YgDARcZKhGGREBFHpiEaU51apQF5lmv17LMVkdPvYNUW4XEqxfFY/lgPUv9W/7hw7s0gN3gyP4oa1WykaQUZ9xkBs0d2fG4Dg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 12 Jan 2023 13:01:54 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 5/8] x86/iommu: the code addressing CVE-2011-1898 is VT-d specific Content-Language: en-US To: Xenia Ragiadakou Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <20230104084502.61734-1-burzalodowa@gmail.com> <20230104084502.61734-6-burzalodowa@gmail.com> From: Jan Beulich In-Reply-To: <20230104084502.61734-6-burzalodowa@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0051.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:92::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM7PR04MB6984:EE_ X-MS-Office365-Filtering-Correlation-Id: f4ffbd98-65e0-41b3-d127-08daf494cd88 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: U+hqISi5J+Cp25EunYZUvPG2dnaD7nn/jQ9nBT+ssVXw7fRAQ8+0zNhVwGmCXKU900fwgze23lBs0LDBaA6tKmlIYoRCshAvjw1O/mZVE+IuDr+/qApRG25230AKEyuyHh9Iimlj2xXAr6nOPBM++HhMBVOesvAOe77K1Pm+bKTEKXvmIDmHdrlKCe0iKKANpcqDXLiQvB+n8C/MoDd1BQkIwh84SufUT1tKWlNyYW1qPg85sNUfpBYjqyguISO+VaXHy+DE7v20t2Wm6c8uTEJ8tL2U631VQe475dCCC2gInCfY+fMfqyGLuX6x9y55DUTUBY8Az2C/mYuxcvlnMvDfvt3FWbXO9yPCVJmeQkq4KDyO8uEneVenfnyJhi+JBvMvBFudAyi1Jx+kzbgTgeEC/2S5gInP8uGpCMvJwa8Fd+dAxhMmV5akRFS9rLBgW6aSLRhvClTdLtGA8cjRq06CG+uszmy0j5pNKa1afySVvxsrpnZ+cS0INRuVR4cTOKNNDWNcVWmXqa+GhOlNH2gsdTyFsx28ofLeiNmch3CA+xBqXYrkXbRl7yz/wk5fPrfSWbWA3R6orezENPg3YgnFLs1fDpk3hHludH22/k7vkcKxqjC1mnhIuHdFhysyJn3+2Bn6PXcORyDNkBiBjVLNtYuG1wGytGe3967mNukVAssoub8c/G4cBesxWPJVXTdg9kSGPGY+a3J5pOZgzo7JQ8GEsk7Q4zWdRUqJ+x4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(39860400002)(396003)(346002)(376002)(136003)(451199015)(8936002)(83380400001)(86362001)(31696002)(4326008)(38100700002)(8676002)(41300700001)(2906002)(5660300002)(66556008)(6916009)(186003)(2616005)(26005)(6486002)(6506007)(316002)(66946007)(66476007)(6512007)(478600001)(53546011)(54906003)(36756003)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bzBFa1FRS0VZdVF4V2M4TXhzSENmSnVnVGVUSlJmTWUwWkptODBSVUlhMVh2?= =?utf-8?B?WklXdWN1Y3VrZndrMFkrSW8xWGNhdVAxSTY4a3dJUHBNNG9ZSDNPRUxlV2JO?= =?utf-8?B?aFcrQjNVakJqY2pRbFZoejJHekN3S3o0RzZ1WlgyZG16QTJRbU42VDRLUEdo?= =?utf-8?B?MVNHTnA2Zy9KZ2NuQW1UdzA5bVI5NEdyWEN1dWlkUENKZ2VCR3JPSWU5SnBx?= =?utf-8?B?WmMvMlpBOXVIRmpYOWcwVlNrL0tlbmkyNW9wU3h1azdVM20zNGlmSE5SNm5s?= =?utf-8?B?U0JEcVpkUS8wUWRnVStqNVZvQ2NDTEwxSnNIaWtIVnkzODM0b09HMUxndUxP?= =?utf-8?B?QU8xZ09CcEZ1MVJUSjYzbG1YKzQ5UE4yMEpIVlZzSkV3RlRWVExCZExmZUNw?= =?utf-8?B?bEZCeURNNG5tcWpEdHNIdnl3RFZIRnk1RC8wTmxmeWxEUXc2Wm9MNk1YMVlR?= =?utf-8?B?dkV5MW95bTBSdGQzc2N4Z2xwcmQyZFo1ejEzU3FRMjVySUQ5cWFwYTFDamVW?= =?utf-8?B?Ti9HTk9paEtpTGpxQTJHd2lXQWE2SHlGSFJjMTB1SitYdUxmRXVRdzNKMHVh?= =?utf-8?B?QWpZUTU5WVZldENpSU44NndBdU55T256Um81Q2g5QWQyTFFTenphY0svOFdx?= =?utf-8?B?L0hoSktqRmU5YXJtQ2hyNEYrRE9tQTJmNjZpTUY5d2tIS1ZJL2hxTllCMlA3?= =?utf-8?B?VHhvd0ZGQTVBOEFCQXJaUkNHdkhuOWFxdC9wNEY1eW9GajFBdnFuUGNGSWJP?= =?utf-8?B?eitZSDF2dkFtY0xJa2JFMHFxMldUOEpvaVF6N215TTdJNDA2WitwOTc0eXhs?= =?utf-8?B?TitWU0MvUGNib0VaN3U0dUJKVzJSb3VjelZvK2k4NGwwd1pvWUdEL0NuVTVR?= =?utf-8?B?eURDcXIvOWcwMXUydlBDVW9YcFhPU0ZKM1I0Mkl0bDRlS2hwYUpMK1hPZmJP?= =?utf-8?B?R2ZQZktJNzd0SzZYZ3kxNXppdnN6RWJMamFyYXlEdG5TN1VNZTI5ZHFsdm1m?= =?utf-8?B?Qk5zL1A4UTAxdGZtbjV4ckdkVEs4REpPVGs1eEV3U291TWNRb0ZpRHhYbUds?= =?utf-8?B?WCtzMGs0eHRtamdVNWtxK1pWRlBZdXB6TTlBV3EzWUJvcVNSY0hoN2E1VnNv?= =?utf-8?B?VDVwTGNkTFNSckg2WU0xYmd2b0U5YnZDNG56VlpoVFBhQnlFUWYxc05JaGtC?= =?utf-8?B?SEpVRkZ4Qy9UZFVRT0trS2NxNFovaTZlZ0k1QjhjZDRJTjJVZnNUYUF2K0xE?= =?utf-8?B?U0V0U2JtMmtibVQ0dGxnM2Vqbytia01UTkx4TTg1bFFWYnFqd0lJYTAzZFdz?= =?utf-8?B?c2tpSDA2M01YcW00cFRXTnMwOXNPREtGM1NhWDRNQ2tSb21UNUFNN0I4MGFn?= =?utf-8?B?YldPY0pMd3FXamplYTl5VGxYWUM3K3hmSy9IUFI1UksyKzhnR3BjRndvTE9n?= =?utf-8?B?SXBGbVRUdDdJU1JIM21hbUJER1ZpbEFvVEZkZmhtM1k3ZEU0dDBhc0RXQmRa?= =?utf-8?B?cGlhODhJbWlpbWdkb3R6ckJSaGtSU2lFMC96bkdXMnVoeU5mblFtc2c1WFVJ?= =?utf-8?B?VmdNVlZJdlZTd3VQWFNhempsR1Z1UG56SE1wUHNjTXRrRnJZd0lkRVUycm9D?= =?utf-8?B?eWs3YjUxR08wZnV0azVzRGIzZmVIcXFKMEZUQThYQk5hOVQ5MzNvMVpuZ2ZJ?= =?utf-8?B?aVpCOVIzOWNGaUdzMElpYkJjN2JyTjVzM2pPNjdERVdMZlpVMk1Fd0hod0xN?= =?utf-8?B?RG5QRWEyM2RQT2tMU281eTlIdlk4L3FTSUJwVzQwUS9QaGl1WVVFUlNpUHUv?= =?utf-8?B?L3VSa2lCMS9HZ2RHMmQyUTZxenhVeUd0RUhxc3ZCeUFsaG1Da3RmS01zY0hu?= =?utf-8?B?OGlwN29tcVgvTlQ3MjFoNzVnbnorMGZCMFhwTTRnL21qUFUwcy9pN1RlTzF3?= =?utf-8?B?SXFuMEV4Tmw4bUtRdHJhL0ViMHA1bXlSeVZkTG1qZnNWclh3WlZKMlhuMDEr?= =?utf-8?B?dzlXckNDRHNhak5ERGYzL3BtV3AzYjFsakhwaGZqSlpRVmN5ZE4zYUdrdThM?= =?utf-8?B?SkhLSGRaUWM5SjAyWmR3eFQwK2JDK2FDNXRiSzBrRHBpRFJqM1MyUG1jQ1ho?= =?utf-8?Q?S13NW2pjbDg2/gS3KweGFJ/3V?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f4ffbd98-65e0-41b3-d127-08daf494cd88 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 12:01:56.8698 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: s9S6XlTnxkrM2Zly01ACsdu94QiTuNyeU7yzoX/vFRYeVVS+yMh6sGRhwVM2ZN3mV1MnInk/vDQiUMMPxkrBhQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6984 On 04.01.2023 09:44, Xenia Ragiadakou wrote: > The variable untrusted_msi indicates whether the system is vulnerable to > CVE-2011-1898. This vulnerablity is VT-d specific. As per the reply by Andrew to v1, this vulnerability is generic to intremap- incapable or intremap-disabled configurations. You want to say so. In turn I wonder whether instead of the changes you're making you wouldn't want to move the definition of the variable to xen/drivers/passthrough/x86/iommu.c. A useful further step might be to guard its definition (not necessarily its declaration; see replies to earlier patches) by CONFIG_PV instead (of course I understand that's largely orthogonal to your series here, yet it would fit easily with moving the definition). > --- a/xen/arch/x86/include/asm/iommu.h > +++ b/xen/arch/x86/include/asm/iommu.h > @@ -127,7 +127,9 @@ int iommu_identity_mapping(struct domain *d, p2m_access_t p2ma, > unsigned int flag); > void iommu_identity_map_teardown(struct domain *d); > > +#ifdef CONFIG_INTEL_IOMMU > extern bool untrusted_msi; > +#endif As per above / earlier comments I don't think this part is needed in any event. > --- a/xen/arch/x86/pv/hypercall.c > +++ b/xen/arch/x86/pv/hypercall.c > @@ -193,8 +193,10 @@ void pv_ring1_init_hypercall_page(void *p) > > void do_entry_int82(struct cpu_user_regs *regs) > { > +#ifdef CONFIG_INTEL_IOMMU > if ( unlikely(untrusted_msi) ) > check_for_unexpected_msi((uint8_t)regs->entry_vector); > +#endif > > _pv_hypercall(regs, true /* compat */); > } > diff --git a/xen/arch/x86/x86_64/entry.S b/xen/arch/x86/x86_64/entry.S > index ae01285181..8f2fb36770 100644 > --- a/xen/arch/x86/x86_64/entry.S > +++ b/xen/arch/x86/x86_64/entry.S > @@ -406,11 +406,13 @@ ENTRY(int80_direct_trap) > .Lint80_cr3_okay: > sti > > +#ifdef CONFIG_INTEL_IOMMU > cmpb $0,untrusted_msi(%rip) > UNLIKELY_START(ne, msi_check) > movl $0x80,%edi > call check_for_unexpected_msi > UNLIKELY_END(msi_check) > +#endif > > movq STACK_CPUINFO_FIELD(current_vcpu)(%rbx), %rbx > From xen-devel-bounces@lists.xenproject.org Thu Jan 12 12:08:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 12:08:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476088.738066 (Exim 4.92) (envelope-from ) id 1pFwNi-0002a8-4d; Thu, 12 Jan 2023 12:08:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476088.738066; Thu, 12 Jan 2023 12:08:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFwNi-0002a1-1m; Thu, 12 Jan 2023 12:08:30 +0000 Received: by outflank-mailman (input) for mailman id 476088; Thu, 12 Jan 2023 12:08:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFwNh-0002Zv-4F for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 12:08:29 +0000 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [2a00:1450:4864:20::62c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d12ba190-9271-11ed-b8d0-410ff93cb8f0; Thu, 12 Jan 2023 13:08:25 +0100 (CET) Received: by mail-ej1-x62c.google.com with SMTP id fy8so44115270ejc.13 for ; Thu, 12 Jan 2023 04:08:26 -0800 (PST) Received: from [192.168.1.93] (adsl-211.37.6.0.tellas.gr. [37.6.0.211]) by smtp.gmail.com with ESMTPSA id l10-20020a1709060cca00b0082ddfb47d06sm7427522ejh.148.2023.01.12.04.08.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Jan 2023 04:08:25 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d12ba190-9271-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=dQ/h6xcmzcLV5jX9O2I0F3PYbgosWBKyzY9vBX4euzQ=; b=kIQbBXRXu0p9rtejlpcD05ymGsIxcsAVrjkx9gRyyBS3RNJYy5/MsvoK9dqndUZmmm H6guLqKPcVlWcMuaxYytJ3X87wEx+zRZeWECG2asHYCcDC8FcIn5zYomB1BOxsrrZ/J4 sF/jedHBGGrgrngwTsShuU4XJAitsXsZcoZ4dAmUQP8ruy5tVrWAmlfCN5UJIJ4SU36F +pI2xmfzzXjF7Lo71pZ3pb8gt2sanGEY6kjSaZJ55/UJfKlwaE/7Ks+Q1c2RY7hAa3PK ssHbdSOn9M5Ymtkf835Gp2luUPW9GwdW/Md2qNuVGf/6SqveA8/yIU3bZQLfb3RWczIx Fuhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dQ/h6xcmzcLV5jX9O2I0F3PYbgosWBKyzY9vBX4euzQ=; b=1kxrURk1wsOfFgBCJu8/bGYJ9abcQHYoDo3f5v2hoL6RL0u7cBFTFZE24PxtyzDHtr vOF6ZuJR8LKQCP/L47iCfqKaXzYHYvTXyjuE6d4VY0435DXUo7cWe6bKvXEBawh4Iob/ U9IdumW9CUAUhAwMciE4wTen+Edoc6cuU/dSTKtmU3pR3wYoySa/PxaY4dzGsv3qV6aj 4rzHFdiqjweORQK1sKEgVQWVF7a/8YCUlqCeegx8wre01vN7rM9vRr2GnC6Q+1U0izsA 2QY2KodWpndSvQe9YRqPpcc6RcTmDfGZIAV0/rmva3clO3H8CXFUZgnncR6byCcHz6KG 6Wxg== X-Gm-Message-State: AFqh2kpTxgv1mK4kr/AC6vh+jxD42W6xnLbVLbx5Tu6wToIBJQoZD3Ak mEl4v8jLgdgBQ/s86IWwP8E= X-Google-Smtp-Source: AMrXdXu/Y+NMALFUqB45iP4PU654NuTeJLKkkMGbN6QCYNxiNZC+hDq4JkXolsbxopWeBm+xARE79w== X-Received: by 2002:a17:906:b0cd:b0:7ac:a2f5:cd0a with SMTP id bk13-20020a170906b0cd00b007aca2f5cd0amr61492535ejb.44.1673525306079; Thu, 12 Jan 2023 04:08:26 -0800 (PST) Message-ID: Date: Thu, 12 Jan 2023 14:08:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v2 4/8] x86/acpi: separate AMD-Vi and VT-d specific functions Content-Language: en-US To: Jan Beulich Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20230104084502.61734-1-burzalodowa@gmail.com> <20230104084502.61734-5-burzalodowa@gmail.com> From: Xenia Ragiadakou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/12/23 13:37, Jan Beulich wrote: > On 04.01.2023 09:44, Xenia Ragiadakou wrote: >> The functions acpi_dmar_init() and acpi_dmar_zap/reinstate() are >> VT-d specific while the function acpi_ivrs_init() is AMD-Vi specific. >> To eliminate dead code, they need to be guarded under CONFIG_INTEL_IOMMU >> and CONFIG_AMD_IOMMU, respectively. >> >> Instead of adding #ifdef guards around the function calls, implement them >> as empty static inline functions. >> >> Take the opportunity to move the declarations of acpi_dmar_zap/reinstate() to >> the arch specific header. >> >> No functional change intended. >> >> Signed-off-by: Xenia Ragiadakou > > While I'm not opposed to ack the change in this form, I have a question > first: > >> --- a/xen/arch/x86/include/asm/acpi.h >> +++ b/xen/arch/x86/include/asm/acpi.h >> @@ -140,8 +140,22 @@ extern u32 pmtmr_ioport; >> extern unsigned int pmtmr_width; >> >> void acpi_iommu_init(void); >> + >> +#ifdef CONFIG_INTEL_IOMMU >> int acpi_dmar_init(void); >> +void acpi_dmar_zap(void); >> +void acpi_dmar_reinstate(void); >> +#else >> +static inline int acpi_dmar_init(void) { return -ENODEV; } >> +static inline void acpi_dmar_zap(void) {} >> +static inline void acpi_dmar_reinstate(void) {} >> +#endif > > Leaving aside my request to drop that part of patch 3, you've kept > declarations for VT-d in the common header there. Which I consider > correct, knowing that VT-d was also used on IA-64 at the time. As > a result I would suppose movement might better be done in the other > direction here. I moved it to the x86-specific header because acpi_dmar_init() was declared there. I can move all of them to the common header. > >> +#ifdef CONFIG_AMD_IOMMU >> int acpi_ivrs_init(void); >> +#else >> +static inline int acpi_ivrs_init(void) { return -ENODEV; } >> +#endif > > For AMD, otoh, without there being a 2nd architecture re-using > their IOMMU, moving into the x86-specific header is certainly fine, > no matter that there's a slim chance that this may need moving the > other direction down the road. -- Xenia From xen-devel-bounces@lists.xenproject.org Thu Jan 12 12:16:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 12:16:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476094.738076 (Exim 4.92) (envelope-from ) id 1pFwVN-00047L-U2; Thu, 12 Jan 2023 12:16:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476094.738076; Thu, 12 Jan 2023 12:16:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFwVN-00047E-RP; Thu, 12 Jan 2023 12:16:25 +0000 Received: by outflank-mailman (input) for mailman id 476094; Thu, 12 Jan 2023 12:16:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFwVM-000478-KU for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 12:16:24 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2044.outbound.protection.outlook.com [40.107.249.44]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ec84784e-9272-11ed-b8d0-410ff93cb8f0; Thu, 12 Jan 2023 13:16:21 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU0PR04MB9659.eurprd04.prod.outlook.com (2603:10a6:10:320::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Thu, 12 Jan 2023 12:16:19 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Thu, 12 Jan 2023 12:16:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ec84784e-9272-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IkAkg+exqsZYredmu7r9MPmh5Agmrwzsp82aruLC1gTbp8r7spzqbK4XpDZdFWzsWV4Ped2caQmNK7BPJWzYgZv+3O4YgJcuoaoWpgo0/T1zU1OP9KE+Og0y+o4o5F+89heCd1vn3rkmnxI/HeU7x88jVrgWH1Ww0yLC8MmXsSsEbJHThmlN2ldWLG+HCzj2XOsDdVrfg5+JddEGsZW16eMaFuPjkjBt3UMO1JI3kxDa9014HP/4C2HmuWQE0w5GuWnkPlbGRAogWevVMJ3XYmvtxlRDDdU8vpYbEAzkFGY3WZDCPnbX5DAA9WKKnpggwhzw/S5/gueo9GoyEb/dIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HSg0cm17QE9NumIyyQ1sqXZmMUnNT4vIsgXAUlpWqfs=; b=HirPbeh2vphmZ3wP/1C52yHTBHiYneFvxAV5ldTxJs5qWsRwoCS1mB5He72ZgBfn9v2NFxVZrWasI+DoMA3XDSzwMPwKxq/lZ8LU26r3uT78XhkwVBYcMOR5RqE8SGaDuT9GWMZJyByfyvFopvhpXE3z9z/ehME3ES8Pw2BRUfmuCrRSSNgXl3KjcLpyrGA333GBFeduYFBChEqjZ+y8sZ5jCXcRHq1ENz3zwg9/7cZbVb+tFKlk+N38KmK5I6zerVzRnlQGWizkLJ3q6PVkdBN1uDEqel6Y8UCEnniUO/JzoBkKxKYowsu+6xnPPYM2CrXRI6hFdefXyfB8fcQ9qA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HSg0cm17QE9NumIyyQ1sqXZmMUnNT4vIsgXAUlpWqfs=; b=j0j7gJUTFycOqCXHhLmNtIv9MJoQ5dJxyUPHKrDW+er5ua5PRJ7ZJjQDObyeabN13SC69fNNqn+YI5WkdlFdJKzysnS3BkxvnzdmD5NQIfJ6T92As7AtekXFKhNrQ5RIUTb8bMyUcQSwv0jGuznEnSAHLHTd+S+sVg2QMcI/aR8O2v0mdJLOHIcIfuNnx3C85SBWmisjn8vNKTKFkFPg5D+JSbKIMhkvOl453TjQa5kuZjqK0Qn4hsmjgylR/IjoT05dXTVS6Si9pgIVoUPRCJdPpDjvUuz3mg5Xo5Tabx7ctV9VA36EobeB0bGyHpKeRkrNjdkwm2wkDSdGH20H0g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 12 Jan 2023 13:16:17 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 6/8] x86/iommu: call pi_update_irte through an hvm_function callback Content-Language: en-US To: Xenia Ragiadakou Cc: Jun Nakajima , Kevin Tian , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Paul Durrant , xen-devel@lists.xenproject.org References: <20230104084502.61734-1-burzalodowa@gmail.com> <20230104084502.61734-7-burzalodowa@gmail.com> From: Jan Beulich In-Reply-To: <20230104084502.61734-7-burzalodowa@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0009.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU0PR04MB9659:EE_ X-MS-Office365-Filtering-Correlation-Id: 6cde2bec-373a-45ea-b813-08daf496cfdc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0RZeA6thBoHURnKqXKYVVULV2zIJ5qmw5TNqhDKHbU+fP2F8XSv8BbK3rihRZqSJ3LFkhjzl5BeEHD6k7Ce7DS++cyOfNvn+ENWyupV8JemSlgVL2kcOIUunVeUOYJDfH0LfJgoveKf+AkUdgd0FkZ2jvh3RcjFw+0LVeUfuoiODkyPnvf1sXlXMttAQ5ncsegTfnYG6QMgYFIdNbQfw565f1ZZJAeqSM5iR71xraR67YnENSTuANaDhNqsc1xQJ2mGEe3Q9FFrj0cYRp/JQkGZMRh1ws4JCFeh5iKW5pkh1mQDZ4xgKXfrCxVUA6gKuPrp3Q8oQHXCehX3yWIdT3piPxgcMkFTInMFCkBA2fxPU7wvCRiddJ6qtQgo2QeL9QRvAFCwcX20LF9P94wfeKhls68JPhL0SUewjZ2C3EgkMJrS4TpcOF7qqZt9trn5i8UthWcw4f3eqV0FUA83ZzwOT25PuiZtdOXx59O3tLr2YQW+Rv5qBc2yHTN7j+aUV90womistuylluEQrWdI4/aG157AcBycVMom7iYgCvo5lM1udX84wSBSAi8Ex8CvwWD2EXqdlFgBPUWcO7dy8WGkIl0yeGskKJibrIYYfPIhIIpuERDugaJwcPhBfCeXuTM21ykLogndwC57l83NBEBZUnTtH/qHBRSJUgTns7rGxYo6Z/hNGFBCDIOnDYww/y77M3kn04Bkc2+aGQeCuR0akS9pVjSGjHbQUet4UR9g= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(136003)(39860400002)(396003)(376002)(346002)(451199015)(316002)(86362001)(6512007)(26005)(5660300002)(186003)(478600001)(6486002)(2616005)(41300700001)(31696002)(66556008)(4326008)(66946007)(54906003)(66476007)(6916009)(36756003)(8936002)(83380400001)(8676002)(53546011)(31686004)(6506007)(38100700002)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dmFKM3NlejhQZDk1cEROd0xnR29udlIzWWtpdVFCZjJZUG9kRndlS1FnUHhL?= =?utf-8?B?b3lMRW9PNnozM2NqS0ZURGFhTFRORVYrY0FIUXp3QmU3NmRPTTE5UWJxV3Fq?= =?utf-8?B?clBZN2QzOVg1akVBTlJDeDFGMW1aOHJCUFFONms0TmZRb0hoMEROR0xiSmNH?= =?utf-8?B?RFhNWENadjE1aGtHYXNCMlZRbEhDeVUrUGttQmovVVlvbVJBZHZVSWFVelhZ?= =?utf-8?B?OGhJdjh5NnRnd0ZQMCtWWVp0VmkxdTEyYyt0NE5HWkpTRG5QMFZzMHU0b2xW?= =?utf-8?B?YkxINGpFSTBCRUZWcWVGdVd3YUxxUVZXNk1lU3VoL3piQkpnUWhOdmdnUkdI?= =?utf-8?B?M21Oenp1WGhpSTNUN0JEczd0YkM0N1NXZm5wTWhuWXBKRkVvMkZ6YmVnQjlH?= =?utf-8?B?UnRQY0s2U3ExSEM4YnRDczhtU2drTFZORFRhLzVoRFdKdHFhS3c0Wk1tczcw?= =?utf-8?B?R25ZZ01KdnRnWmsrNnJnbGlFeTV2elN5VWhCcTkySXltaEtEZXZ6UE5uY3ll?= =?utf-8?B?QVJHQ3dkOXV3S0tPZks5WXBhQmRRQTRrUmgwYS82N0lobUNHanZrcG9iR3Vr?= =?utf-8?B?TWNzMVVkRGhtbnRxT2lTV1R1NGt3YUUxNVU3Z1dXTktmSWRrdlNFbmg4c3h2?= =?utf-8?B?VWoveW41TzIwNnlUa2sxWkJtMndKeU9SQTF1dzh4U2dMUm83bG9VMkdhUHhC?= =?utf-8?B?VnhxY3FOSlNTNnQ5OXc3eWM5dXZjVERRcTQ4eG5WUU5RbjlybWxYcFc4VTBW?= =?utf-8?B?RENHaEV3ZW40bzF2SFdtclVpcTUyYWt0ZlhsZXovYlozYldJYXpoVVFyZ2py?= =?utf-8?B?UldYdHl3aGs2a2tMNkl1bms0dFNndkJZNm5OY2U3cDY2VmZzcHpvVWVGMVBH?= =?utf-8?B?QXJLd2lWQk9GSng0bU5HQ2c4d3l6UjI4Y0VUaExvWEVoejh4bUdXMGpKSGQz?= =?utf-8?B?ajIzYTVCT2YzdjQwQnhTQnZ3dWdqeEtmc01iWG5FdDJZRzlCb2dOZElYcXFs?= =?utf-8?B?MVRQM3F6cyttUmNVRThUZjdKZmptNFMrSURPYUNiUFI3UVpKT21XRGZCWXVL?= =?utf-8?B?VThzRXBTTkYvQkhab0pGTHFMS20xYkxxL3dpZGo2SGtCano1MVQ3b0U1ejlF?= =?utf-8?B?ZlI0QnNRSUlZampVY3c4NkRMNmhidURqV3FnUE1PMTFMTEs1YmVJK1RsN0Yy?= =?utf-8?B?cVVhNXNxSGllSTVWL2NkUyt4UW9RVC82WWhUUENBRXhpR2h2OTR4ZjdwSW1O?= =?utf-8?B?ZkpFV0E3YTlWV0JzNVdvbFkwU004RGo4ekZlS2xrYlJJK2lINEdnM2R1bTRy?= =?utf-8?B?SDNWeWN3VjFpeTZpOUk0MGR1V2JyRUVreFVFVTVqaHViOHVJSEhGbHpEM2dn?= =?utf-8?B?TlVhektXbnpHcDA2RHh6Z3VIMHVNRXVlTHpUMnRXNUd0ZlE5b2dhUGIvaSt3?= =?utf-8?B?Ulh1aHNhZnB2QW9YZ0V2eTFERHU1V1o5Z2JhV3lCVnlNTzViT0djODFuVXkr?= =?utf-8?B?cklHNXNubEJLa1ZmcXQ1bWFMeUsybndlQWVVZzl0MjIxd2djREF0a2RvbGdV?= =?utf-8?B?cFJ6QmhmODFXNWMwVHhLOWFpVHQxc04wVnVidU5hekVXVWNxdlVGMGVkY0Jp?= =?utf-8?B?YTVZVXMzMWJxT1hId2ZZZytyREdvNXVvMXV5ajNlb3o1V2hReGhMRndvTVRw?= =?utf-8?B?SjBKRzRFSHo2R3lkMXByMHRrS3k4VHJ5ZTRFNzJMOVBET2txL0xsUXk4Y0Vk?= =?utf-8?B?K3ZrdHNPMWFjUWJVTVVqUG9najBnaDUxRzhJOTk3WkZtaXlUS3BxV0ttaUNT?= =?utf-8?B?MEc3SVI4ZXF1MC9qbHhPcmZpR3pMcGgzSndjcHFRdWJsbWtXTmhJL3dMalZk?= =?utf-8?B?ZCtNaDQ3SWh3bnoxODAxMDY3ZnV2VFpmTkoydWtCYUNURWllaEFzWTJHWGdN?= =?utf-8?B?TENpSWU2UEtWbTVoSENpMVIxT3FMRjBlYjd5SUZBSEJncWUzOEV2aU5HRkNI?= =?utf-8?B?OFdTK1hSTGRnbTRFdjEvLzNQMXhXeHhpczl4cVZQanlkVWFWbUxtUUc3akpV?= =?utf-8?B?UCs5QVhHV2tndUtjZkpDNkluRGNWcVJMbDhBclpRVWxCUTRPV2dkc1V1bjFS?= =?utf-8?Q?WnSkZBl8YblQzliYu+CHK9tu/?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6cde2bec-373a-45ea-b813-08daf496cfdc X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 12:16:19.7373 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YpvZqvyUfgbA4nU4k19Ba/WyBySfTzE93wrGahD0bxFKOwrypElLSMS7WxXdcs5T4EqBonv0Vh52zFCRWXifbA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9659 On 04.01.2023 09:45, Xenia Ragiadakou wrote: > --- a/xen/arch/x86/hvm/vmx/vmx.c > +++ b/xen/arch/x86/hvm/vmx/vmx.c > @@ -2143,6 +2143,14 @@ static bool cf_check vmx_test_pir(const struct vcpu *v, uint8_t vec) > return pi_test_pir(vec, &v->arch.hvm.vmx.pi_desc); > } > > +static int cf_check vmx_pi_update_irte(const struct vcpu *v, > + const struct pirq *pirq, uint8_t gvec) > +{ > + const struct pi_desc *pi_desc = v ? &v->arch.hvm.vmx.pi_desc : NULL; > + > + return pi_update_irte(pi_desc, pirq, gvec); > +} This being the only caller of pi_update_irte(), I don't see the point in having the extra wrapper. Adjust pi_update_irte() such that it can be used as the intended hook directly. Plus perhaps prefix it with vtd_. > @@ -2591,6 +2599,8 @@ static struct hvm_function_table __initdata_cf_clobber vmx_function_table = { > .tsc_scaling = { > .max_ratio = VMX_TSC_MULTIPLIER_MAX, > }, > + > + .pi_update_irte = vmx_pi_update_irte, You want to install this hook only when iommu_intpost (i.e. the only case when it can actually be called, and only when INTEL_IOMMU=y (avoiding the need for an inline stub of pi_update_irte() or whatever its final name is going to be. > @@ -250,6 +252,9 @@ struct hvm_function_table { > /* Architecture function to setup TSC scaling ratio */ > void (*setup)(struct vcpu *v); > } tsc_scaling; > + > + int (*pi_update_irte)(const struct vcpu *v, > + const struct pirq *pirq, uint8_t gvec); > }; Please can this be moved higher up, e.g. next to . > @@ -774,6 +779,16 @@ static inline void hvm_set_nonreg_state(struct vcpu *v, > alternative_vcall(hvm_funcs.set_nonreg_state, v, nrs); > } > > +static inline int hvm_pi_update_irte(const struct vcpu *v, > + const struct pirq *pirq, uint8_t gvec) > +{ > + if ( hvm_funcs.pi_update_irte ) > + return alternative_call(hvm_funcs.pi_update_irte, v, pirq, gvec); > + > + return -EOPNOTSUPP; I don't think the conditional is needed, at least not with the other suggested adjustments. Plus the way alternative patching works, a NULL hook will be converted to some equivalent of BUG() anyway, so ASSERT_UNREACHABLE() should also be unnecessary. > +} > + > + > #else /* CONFIG_HVM */ Please don't add double blank lines. > --- a/xen/arch/x86/include/asm/hvm/vmx/vmx.h > +++ b/xen/arch/x86/include/asm/hvm/vmx/vmx.h > @@ -146,6 +146,17 @@ static inline void pi_clear_sn(struct pi_desc *pi_desc) > clear_bit(POSTED_INTR_SN, &pi_desc->control); > } > > +#ifdef CONFIG_INTEL_IOMMU > +int pi_update_irte(const struct pi_desc *pi_desc, > + const struct pirq *pirq, const uint8_t gvec); > +#else > +static inline int pi_update_irte(const struct pi_desc *pi_desc, > + const struct pirq *pirq, const uint8_t gvec) > +{ > + return -EOPNOTSUPP; > +} > +#endif This still is a VT-d function, so I think its declaration would better remain in asm/iommu.h. Jan From xen-devel-bounces@lists.xenproject.org Thu Jan 12 12:22:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 12:22:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476101.738088 (Exim 4.92) (envelope-from ) id 1pFwbH-0005dU-MH; Thu, 12 Jan 2023 12:22:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476101.738088; Thu, 12 Jan 2023 12:22:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFwbH-0005dN-JH; Thu, 12 Jan 2023 12:22:31 +0000 Received: by outflank-mailman (input) for mailman id 476101; Thu, 12 Jan 2023 12:22:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFwbF-0005dH-Ob for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 12:22:29 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2045.outbound.protection.outlook.com [40.107.7.45]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c7439f99-9273-11ed-91b6-6bf2151ebd3b; Thu, 12 Jan 2023 13:22:28 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8242.eurprd04.prod.outlook.com (2603:10a6:20b:3ee::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.19; Thu, 12 Jan 2023 12:22:26 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Thu, 12 Jan 2023 12:22:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c7439f99-9273-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SSYaqlJZiJcbqW9ZYVHAlai7FWzSM0Hh0rcVqvyifVRNnVIgiJx1zJxq+DrTXHNsjJs16z0AfOyExobjaNL5i+TsWhMfQJ0zttLz+g1Go3tIDdrI/Y0XMDjfIq39z2sP4P4fztUQXyw40yUme/Dy2EdveHJtz3ABRKBhXMhkmMQz4uKr44Z9d/uroa/L6CNzusXcw7gMPY6491tadsp6qnQQ0YlhSEoawEX2NjwwG1zkMwkVORo5ufQToeya+Jk9IBmuTkMLgElgyNRCat8SBHHq8Js8nWs7DyNjuPu5UidlwI6M+A2qiQS27MgEqE+fgaVijtow4JPaLRsS2eeUxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jua8+qvyFxdva6AeLg6ip2uyjypLjH77n/jmxwE62sk=; b=ZyBq0oZLxxJdnrIYJewalSn7MMi5NZRt4PFTaQ3eYDr4CkDVBrU/GzbcwqRHaWHc4KqnHo7Cte78onWU92ihsGSUVQoJCz57Ie0t8XR9E5w/J3Uv2PRUQl2f9EzwifoNe5G7iF4dXlDoZekwNtjxFWh+GH2IPSl0Viu+4Y3GlOqNGeSE7COAtVFkTTwb2FQNtCDrtU7YfBQ4ANs9SE+moKkpiYKV1dz3RF06dcdJavI4stZ3ADZX3k1FqkULTPLAqZtdT/bZFx/q1Ay/XAzryh6tvFhyirOhchj0Br0lmI7HslEjcasrvZDvOkJS7Tz+9ODNK/1fJ+V/7UcK4V1Ojw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jua8+qvyFxdva6AeLg6ip2uyjypLjH77n/jmxwE62sk=; b=0zHSaJp2RHS+Tz5KX9Dy+8PzuJq48QRwrdV1rGQJ0LsY7uRg5Dz5qZ4hQa+95588Xc0kCv+d614RhIkuAYtJZQRxh4E01rbzSlQqWnvBOUjwUsH0zL7UCP+bJij8LpyTchnHu/pUsyS7iJmqSM/9gaTBrDER3Z0TUdR5+GbGT0C20BhAnWjnkDGUE4ksUBZOoTKnAwKgKrRvtVRX6q8z0E6zTeNyg5mEVbapc20Vc2uQqUozyD3be92X9hoGgfwpzd0SEBtRsXrsTtIqqAbZAAppN5dKQq841cYz9ktdUdzpneldZqqeGax4TnedAMS9uCtKnz+A6Cg2zoIna76Z/g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 12 Jan 2023 13:22:24 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 7/8] x86/dpci: move hvm_dpci_isairq_eoi() to generic HVM code Content-Language: en-US To: Xenia Ragiadakou Cc: Kevin Tian , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20230104084502.61734-1-burzalodowa@gmail.com> <20230104084502.61734-8-burzalodowa@gmail.com> From: Jan Beulich In-Reply-To: <20230104084502.61734-8-burzalodowa@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0131.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8242:EE_ X-MS-Office365-Filtering-Correlation-Id: 426fb9b6-27a0-4c27-1525-08daf497aa62 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CBa733W5D5Pe6zs8+X9ELfCcuYzknmQKX7uMOnqu+WCvig8sKAPyudu8eM77OlE23o4e6/+h/eDUDzCAmToJWnwIUKKsVkIgeG66INysko5GCIEa3Mq9XzEatk4QqcS3LMI2JRCbflbTzKbs/U2ebS8d4VenkvVmp9L5yuVUFi1g7gk95mwB48shWLa6cllgygcRmd5O28+ZWVX1o8HTE7yzMLSrNp9A5OeX8pT5Ynkwji1GrnUxpnIauqMnSupdgqdDNizUGn4VhyTqKlcR8bHiK0w7mWt1mL5enDyEV8nPWfPsscsgzvlYRlMA2mx4QyfXK2OqaigtGHZr6lEKf/p3J5gpzKvryuE4ZJqqFFHS8QluDT/VNLuJdkU88XmaxddhjVpIBshavLvpPiNxIzOjbPUT0HoM1x7YWE4PHxGZ/PFHiL9phjaQBiwgHLZ4F4IUP8Y7+77mP2WQcJ6LhN9QMjMg59MPd3nPMF+5WICC9hMgdQhxP55F7OejBVa7hAqhRJOn4aOoP46ToHMBofREnuWHLi/llR/ycto/TUIZe029v7SrR6rq4hgJczHBjsbskWUIEtgkJ6ijgKpIJg/m9fJ8zTNyt8FuhFMCXnLOwgLmj3njlYwCm9rSWXdKjSgZcN2hG0V86fKI9cpDYnAqqc04GEHnNl0TX1Kz9n/RETPlzrwKweaXzCWZ2QACQCy5dFAr23iVnnZcViI+0yUx6WEZB6TUQ38QrKDcolcjr78kJkQn4WFa5e4uj2Bn X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(366004)(376002)(346002)(39860400002)(396003)(451199015)(6512007)(186003)(31686004)(478600001)(26005)(66476007)(66946007)(53546011)(316002)(66556008)(54906003)(2616005)(6506007)(8676002)(6916009)(4326008)(6486002)(38100700002)(8936002)(5660300002)(41300700001)(86362001)(83380400001)(31696002)(36756003)(2906002)(41533002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bXk4a1pxYjZnSEtUV3RGcDNkS3NHMllIZ09UcGhTZzlGRGRkUzh4TlFpUEcx?= =?utf-8?B?d1BYd0Y5S2JMUmpjUEVkZTNhVEhmdGVyMm9ZWjhLMkNKVGhsQnNKaW1INEN4?= =?utf-8?B?RDBLbSs2UFUzRVdiNlVHcEdINDFDR2RJOUdmMUFhaFd0cWd5dVUwZXJ1UjU2?= =?utf-8?B?RUpLekpqR3g1MER0SFVaR0dHSnFnOWkybmJhbmVld29qZFpsL0x1OGZKMzRL?= =?utf-8?B?c0VLRFNUaDkzbFVKQlhIL0RHTkkzZG5NNndIYytRN2Y0Ukhid3l5bWVaeVVM?= =?utf-8?B?bW41NWdQUkpZdVVXaDF5emFCQS9sOGxFRmlxZ0IrNGdqZmMxTUU2OFl6bXVu?= =?utf-8?B?dzVIT1I2VWs1SXBTSHJxd0VIeWVCMjB2YUs4YklVMzQrQWVSMmlFQWNlenNY?= =?utf-8?B?YldDcHdLOGsyR2R3a2UxQnYwemhDc2NnVGppa29wWlBFcStwWk9KYlpLYmly?= =?utf-8?B?c0tCb3lmOHZZUkMyQkZNanpqWVVWbDdqUDB5am9Canh2WHBZVFFFMXUrT0ov?= =?utf-8?B?aE14SUUvTmRBem41T2JJblpIWTI2bVQ1WUFJYUs0UE5BL2cxWHVaNmFzSlJJ?= =?utf-8?B?QWx2SCtkWUUraDlkYnFNQU1ZUTlyZmJnOWxJbTJtV1h6Nk1sMXlScjJ1SGEv?= =?utf-8?B?Zitwbko0dk0vTVI4UWhwSkZ6SnJXZXEycG9weDNGeUlpcmJBdFBWZ1dtVWFo?= =?utf-8?B?NnNJQ1Q0OFdDMDEzbldveTY0UGkrVkNSaVI2T1RoQmw5RE1VdnpxSjhTVzg4?= =?utf-8?B?dTRuV2pyTFp6OHd5NFJNZlpucnZrcXNNV1gybFBFb3ZDQzJpdXk3cjMrRnFV?= =?utf-8?B?TlJrL24rK0U5MmpMdFJ6L2pscVZ5RWRyakNpbVRJSHBSZFVDNFlXZW1xMllq?= =?utf-8?B?V2kxSmV4cEQ3UWFnWStZek9SL1BDVjM2Y1o3TmJQU1grNFA3S1poUUZRWWV3?= =?utf-8?B?U0liUmZobEpOSUFrdjJyQTVnNGozNGw2OTNGTzYrdGxzcXQwL3VSRVNzcVAz?= =?utf-8?B?Y0tQQSs3WGRNb0p6K29aWEF1MFl6VlkwQS92UVVEVWJOYWVPSlNXN2VHTU5M?= =?utf-8?B?MzRjZmtPS2xmQStVWkpGeHd0MUM1T0xEc3hreGVGekFXQ1hJb0lRNkZzbGUw?= =?utf-8?B?dm5kNnV0SEFjeWF1VHQzQUtqL3JqVE91L3pzcG03K0JXMUhmdEVsTzUxeTVP?= =?utf-8?B?NVdaamZPTFl5Smx6NGtqQWpmTFBRNllaaTFRZ3RHM2NoN1BqZlhnenJQVVd1?= =?utf-8?B?Qk05RUVvUk5oVStiZHBOTmp3VHZhYVNlTjJqUU9vRkZaczY1VXo3dDFTWkd2?= =?utf-8?B?ejV0dFRXUFhzZ1BnR0RjZFdwS2tLNzdWRUxNK09jdTBEZk9YWEpyZUxIV2Vz?= =?utf-8?B?MG5EK3BlWEU1MFN1R1BtbVN5VFJ0Sk4wNzUzRjhNdnB0WmVReDh2NzZMNi9l?= =?utf-8?B?UEdYQkhyZDl6RkFBYUNXNWFtUEsxV0R5ejhiaEg3R3duOWZqS0hveFI3Vkll?= =?utf-8?B?ZzJEcU1CSzJwRUpOcmk3MXIzTTYwK3JFWFhvQzlBMm5PZ0ZGek82Zzhmb09S?= =?utf-8?B?WHlRdXRSdng3R1NZd3dJTHhwbHVLSlZVZldEQ0kxbEFYdlVxMlRVeXdiYTY1?= =?utf-8?B?ejlwd2tuOUNyaTJzYmJzZFVDZGp6ZldTL1VFMzUzNHV6dGFNSmcyclhJaE0z?= =?utf-8?B?Y2l3bVBxL0FBR0REMnFHSVVKaXZ2cXdYMFpyMHFsQTRtaXNvNGV2S01OMUVs?= =?utf-8?B?Z0tTSlQyMjFPZElPTE9hd1BNVTlhbTBsYVp6b3U1MUJRVXE2b1dESFFRMUZQ?= =?utf-8?B?YlUyY0p2R2psN3JhVTJ4TWNycUM0QlBWOTIyYXdOSFFodGlDRlo4SnNUU3Qx?= =?utf-8?B?VXBkNmNkVCt0UU5UL052REg5R1dsbzVBNVRsSUI3enp5Q0p5a0cvc1o1WFlo?= =?utf-8?B?SnlzcjhXQVlvT3BFM1RjNHNrNTRlN1Y0Z0pTU2NWKzkyTzFkTWpaTWp3Zk94?= =?utf-8?B?TWNVZTN6S0IzL1YwQ1ZYUlE5a2tjRnYvdWdTa3EveE1OY0gyT3RsUWVZdy9K?= =?utf-8?B?SzJrSW94aFlPZ2NBR0FmRlNQeGhjQlJ2R01kWGNVaG0ySUZmdG8zWmtvSVg2?= =?utf-8?Q?pXB0n38Jkkja/0j6ykedCBk9B?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 426fb9b6-27a0-4c27-1525-08daf497aa62 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 12:22:26.3546 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IKic1qhwsTsQ/qaT0BTl/JJGBK1iASHxF15qVMrgrURTe/Tug+Trx4T2EWOGsjZPkDtjK61suOwwV0BJxAwkoQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8242 On 04.01.2023 09:45, Xenia Ragiadakou wrote: > The function hvm_dpci_isairq_eoi() has no dependencies on VT-d driver code > and can be moved from xen/drivers/passthrough/vtd/x86/hvm.c to > xen/drivers/passthrough/x86/hvm.c, along with the corresponding copyrights. > > Remove the now empty xen/drivers/passthrough/vtd/x86/hvm.c. > > Since the funcion is used only in this file, declare it static. > > No functional change intended. > > Signed-off-by: Xenia Ragiadakou Reviewed-by: Jan Beulich with a couple of cosmetic suggestions since you're touching this code anyway: > @@ -924,6 +925,48 @@ static void hvm_gsi_eoi(struct domain *d, unsigned int gsi) > hvm_pirq_eoi(pirq); > } > > +static int cf_check _hvm_dpci_isairq_eoi( > + struct domain *d, struct hvm_pirq_dpci *pirq_dpci, void *arg) > +{ > + struct hvm_irq *hvm_irq = hvm_domain_irq(d); I think this could become pointer-to-const. > + unsigned int isairq = (long)arg; > + const struct dev_intx_gsi_link *digl; > + > + list_for_each_entry ( digl, &pirq_dpci->digl_list, list ) > + { > + unsigned int link = hvm_pci_intx_link(digl->device, digl->intx); > + > + if ( hvm_irq->pci_link.route[link] == isairq ) > + { > + hvm_pci_intx_deassert(d, digl->device, digl->intx); > + if ( --pirq_dpci->pending == 0 ) > + pirq_guest_eoi(dpci_pirq(pirq_dpci)); > + } > + } > + > + return 0; > +} > + > +static void hvm_dpci_isairq_eoi(struct domain *d, unsigned int isairq) > +{ > + struct hvm_irq_dpci *dpci = NULL; And this too. > + ASSERT(isairq < NR_ISAIRQS); > + if ( !is_iommu_enabled(d) ) A blank line between the above two would be nice. > + return; > + > + write_lock(&d->event_lock); > + > + dpci = domain_get_irq_dpci(d); > + > + if ( dpci && test_bit(isairq, dpci->isairq_map) ) > + { > + /* Multiple mirq may be mapped to one isa irq */ > + pt_pirq_iterate(d, _hvm_dpci_isairq_eoi, (void *)(long)isairq); > + } > + write_unlock(&d->event_lock); For symmetry with code above this could to with a blank line ahead of it. Jan From xen-devel-bounces@lists.xenproject.org Thu Jan 12 12:37:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 12:37:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476107.738099 (Exim 4.92) (envelope-from ) id 1pFwpT-0007K4-Vg; Thu, 12 Jan 2023 12:37:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476107.738099; Thu, 12 Jan 2023 12:37:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFwpT-0007Jx-SA; Thu, 12 Jan 2023 12:37:11 +0000 Received: by outflank-mailman (input) for mailman id 476107; Thu, 12 Jan 2023 12:37:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFwpS-0007Jr-Dr for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 12:37:10 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2046.outbound.protection.outlook.com [40.107.22.46]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d448a08a-9275-11ed-91b6-6bf2151ebd3b; Thu, 12 Jan 2023 13:37:09 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB7649.eurprd04.prod.outlook.com (2603:10a6:20b:2d8::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.12; Thu, 12 Jan 2023 12:37:07 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Thu, 12 Jan 2023 12:37:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d448a08a-9275-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XyVBY/W5EUfzWR936HNMzRbE942tx6bMwkYbmpsrKKboggy+vgzm5lQmS5x0pGnEKUDxzuSx70H4lNdypZz3ayJjZNre+/89F4KFBCnRGanA3C2Oo8X56WFLoCCHsKfb6zHRCcDF8fnkZNwuKhNYwSkjJ6IiESOSnEDbTR7dxkwickoyVivKrqUmH0a3Bo0LtUK9dTT+Ni3rR8RhOgtPdAKGgmTly5EteFwxD1WLKq/9tuZ5AZLssB6VCZNJcmb1U5Q976TdCkRJB1PeumMfq1nscg+VI07KK+/gGvS0FJmXf5VhYbSZvhtb/9ROhNSz4i+QAXXO5HwcSGZLJBgkwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LoZp68UQ9//guHuBEsj9AbqZ0JtSUVb8y30mnObDHNI=; b=RE6Htba0Wdxgz9BV6iznpu//oC2oNLXWcWBjFiDWDYYwBDbOYARzRYHFU9plV8H/Du4wNkLbiF6BeysCBJvmohwY9K2ULwouM5BZYZHRkbJs3EQK37vu4sMmVOObgLZHcjhLCWqdRfImzZ1eFk6cn+anzpZrD9qRzBTN1YwRHcgq4+m8HCYQU1WT9VlNx7F54jQnzfA/t0N4DHyHKnzazE6a/yb9kNAeyCxGjx8mQJ7QN/wiMW38VCgBtn183ktZ3YEWNeq7rsE7FEWiqd2ze7EMlecbHajdQej/hlZ4zIBztEfkmSDPyZxxEuQTWRQa9F6cQzxIDTKpMuuB46/LCQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LoZp68UQ9//guHuBEsj9AbqZ0JtSUVb8y30mnObDHNI=; b=AiaAxBxs52nvu8yUtA0kTM6LBfMiFxV6unVVOlYUpFIxh/4i+2bo0/fpF7Y1t1QU0W0H0FRgYWac61VRXMh8kVMvYB0xKEyf/or0ImInJIjVXy2Zp25+WKi2kSIUQiMlI4yZfYLuRvFD9VXTzHaddVWrfarejW19j/FnRXpFzAeJVnRIrK0icap0I5us2nY53bjdL1heRX3iHbfY+UNbW7wnI6TNA0sj1ecmAnjE8PtXj1ylgQxXcGXIVcRpUEOIxt8Q+iEIEO42qDWOwBgpzHDxJxP198nvwHUsHe3ybyO+lGGx+JU/qv2fPRRB07kvNDVD1KSdLicM1I01dGgx1w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6c5a4c07-e942-a683-8579-a0f9d5971c7b@suse.com> Date: Thu, 12 Jan 2023 13:37:05 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 6/8] x86/iommu: call pi_update_irte through an hvm_function callback Content-Language: en-US From: Jan Beulich To: Xenia Ragiadakou Cc: Jun Nakajima , Kevin Tian , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Paul Durrant , xen-devel@lists.xenproject.org References: <20230104084502.61734-1-burzalodowa@gmail.com> <20230104084502.61734-7-burzalodowa@gmail.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0128.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB7649:EE_ X-MS-Office365-Filtering-Correlation-Id: c3f5bd65-2411-4105-fb10-08daf499b78c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4HpCIIhqSni/g+SF9DfUs4aWHvX0VDLbxHaMprthr7zPbeMIraLwHKOWEUlD9Sl27HyDhhtM0asoW4FrsS+1TRQBi+oW0+S6fabJhchNlE57A5/vokBLxVs/9GjWCEkLfHVj0hUoqXv7L3J4erxGUY6ZHEL+PmLEJtEZQqPZseMvl0seJc/HVgHKm9WMICxES2nPQV0MpdiAaFipLmhuyQOvaRr/KwvfvhMA3Wh1sPsnS+zuf/BwxQkdGBooIOyAQM+azNga9ARZ57XGLEgzLc2p4Bzysq/bM650BYDP0+U1FDccRqOum6YApyKOnmJjjS1t49KzmdndbOO6dESgohDsnLIUjHnr/4e+qTNR8Ejef+LUQkRpVKS2cdDru3oViYDZ6fcQF1lzxCJICz+BdUlOl2NJLC3sro1sIO/UKU/KRiwZLt8MAZs9sd/gvNJU6xRymiRUzfknU+gupYt1iy76xpoS5BBVXlQjM1sniyYlPBWQERaNgT4UoXMiWs8P3JpoMm1w04gcC9EhJ/kLMDK7CKS+oIfx61tLNfrQxphewIh5pHwNIcJ1QZpFxj1OX3VUXt7g2nGIHUcZWnVVOJTTPV1F65t8cpr/NDVtpxHuCMnVKfZdxhGuQCM5KPUThawSOIbmETw1/AKlm0LdNqX0QVNuM158t8v3BzyyU3GWV4w6lelsuD+FDsctP2C5I9YDh+fAnviNl7qhnFYhCI4ELNlJrok7jPcAsXCc8Qc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(346002)(376002)(396003)(366004)(136003)(451199015)(83380400001)(316002)(2616005)(54906003)(41300700001)(26005)(5660300002)(8936002)(66476007)(66946007)(8676002)(66556008)(6916009)(4326008)(31686004)(2906002)(6512007)(6506007)(31696002)(86362001)(186003)(36756003)(38100700002)(478600001)(53546011)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TTY4bm44bTk0MTQ5bi82ZjRHOTdtMWN4QldGbnFJNXJ3bWdORDFTZGZHL0l2?= =?utf-8?B?NEFuckVGanFIR1hoZWlTamtlMm52RERrTkd5ajRaWXJJRUkwRjY4bWh2RTAz?= =?utf-8?B?THhCSklFdDdMNDBiSVlCZUFMVi9Mc1VLQklKNllmVFNZVXFvT3NwL2dNT010?= =?utf-8?B?cWJobU5QSzZ5ZmZVbm5CK3BKV2xXeFBlVWdUYWU0NGtqcE1YZmZHcmVtOElY?= =?utf-8?B?V2VQLzVLQ0pJRHdEWDFXRE4yOWxPNFkySmJUbjhFNG8zdlJxL2tGYWFXeFVL?= =?utf-8?B?VEExVFNiSkRpTEtQL1FtTzlUdjJ3ZlBuUjkrQm9JU3RwVEVUOUNYVjRYY25o?= =?utf-8?B?MGVuaDlXOXJ1YllCc2pXUTg1dGxDQXFTTlJDRU5pNkxtTjVta2paeG1ENGpP?= =?utf-8?B?Tkx6MzAyVWFMcHRLelVjZmhyYkQxQkVuNHJUZFh1dU5USkZYYllxRkpOanlm?= =?utf-8?B?TUE0UkJOUTIvR3Frc1k4c1JHV2o4Vjl6NGNqamZWbDM0Y3VpSFdKbDFDNGNU?= =?utf-8?B?Mzljc1E4cFJySW11bHlRUEUvVnIxWm5NeVFqUVI4WlYzSC9FL1JIYzlob2xY?= =?utf-8?B?Wlo5cjJZTGY1b3lOUUd3eUZTL1Q4ekliSENlS3BueUZNVS8yZ1dNQnBCZDdZ?= =?utf-8?B?MW42Y3oxdEhRV2p2eisySHg1OUNGWkRCL3ZUM1ZlclhLMExKRnZOVS9aSnZ3?= =?utf-8?B?VWRHQUpBTTYvVk9tRzU5WWt6U2FlVGdSdGJBTnRWemtBYW9RcExHMFdYVHYy?= =?utf-8?B?ZENydmh5Z3BEK0o1SUhPZk9CUEM2SVJzdWpsZWRkNURpSUxUT0ovTjQ3dGZa?= =?utf-8?B?Q0ZUTkFpZGJqY1RnTUt2dFlZWDVic2dwRFJ6L3huRmRkMWl6RlY0RUJCU3Yz?= =?utf-8?B?ZUpnOWE5NVRzc3hTWWFYQ0trdnVObHh6cUFUaU85aHRrOGY3UHIyeFVIWDEv?= =?utf-8?B?aGoyeFlRWlk3eGdWdEdJemZhbEhiMzlFQ2J4c0VEbEJaMHMrSWtrWmo2K1hT?= =?utf-8?B?d1RveUh3bWhyMkJJakdZYXdOYUpDdFJFL3pGOVJZTlZlUDdtU0J3aHFtbHQy?= =?utf-8?B?OGxWaFZ4VVFYN2FsUCtPMmRBRjZydlN0ZlJ0aWFlQTZPV2FJd0Zlb0VwMFFB?= =?utf-8?B?UVdjSzBONk5tU21sZHdXL1l0K25nNmdzUmp2aE9qTzVhTzV3dWE1YXU3c2d5?= =?utf-8?B?TVJnTXY2SUZUS2xVbkEwT1RBQ1RvSlhqUWdvUzdrMVBhaG1GQndFa0NWZmdN?= =?utf-8?B?RTd3Wnl0bGEyTHBTU0tnZzF4aXJ6Wi9KallKOUJFbTNsdk9yK0xRa2RTTzBp?= =?utf-8?B?RWNZTGg1Njg1RXZneUk1cFJqbi9NREFUMG9uc28zYkhNOGROVkVoaGdvcExR?= =?utf-8?B?UHVSd3htOFlwK0FMZzM1WVcya01saWhLWWNwUzBCNHViMThteTVLdFJuM2tF?= =?utf-8?B?OEpId1U5dHphOXRtaURBaUJCUTJxYTVxcy9Dd1oyeUo4S0oxeTRORG9Ra2o0?= =?utf-8?B?VHhZd3BNNEVRbmlsbXJ6RG9tZFZsZjFGTW1RL2pheTd2LzVUSmxha1NjL3Nw?= =?utf-8?B?eGUzSEFpUU8xbFZ2OTl3Mm5QejNqcjhwbWJnVTgzSkt0VHBoUGNDdjc3Vkw0?= =?utf-8?B?YVJxdzZXd3lzZThVUjA1SEg3V2xJSWpvdGwvQkY5UnNCeVMzZXNTSFl2Mk5z?= =?utf-8?B?eFF0UG1xL0JaaURYMWs0eEpLYTZHSzBKMDlLTEZaWWRhenBOOXFzTm8zdWlh?= =?utf-8?B?MlFneGZnb3RPcytNRmtqSmlzc2U0d0ZtdklFZDJKSFlxZjVUU1d2Zzk5SVNp?= =?utf-8?B?VjJ4MjRHZmZJMk5mbGdJMGlhZUdHTmN1Sm05bnV2UStUSmNiT3FEbGJwckVD?= =?utf-8?B?a1VhMWlwNUlCS1dPTXBvb3VnSTllOGJRYWdFRC9BTTlEVGlZaVYybXhQSTVH?= =?utf-8?B?cCtCQnR6Y2NCRzBaUUZTYmw2eFF0TWk4cisyQnNOYnprdmxBWUh1aHlTMDlO?= =?utf-8?B?by9nci9rZGRlTXUwWG9hV3NhZkh6aXhtSUd0YW56ZnA2UTA3Q2pjck1qalJE?= =?utf-8?B?Zy8rWXVweWpQQkZaT0xId1NyUk9CajR0UWVSbXNZNVNRU216L3drNmNBMjNp?= =?utf-8?Q?mhQITQcysULTHYhdQ7tDQ/abt?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c3f5bd65-2411-4105-fb10-08daf499b78c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 12:37:07.4708 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: S6MVq4JAluMvF28RoBxvkzc0KQuxvXPpDZkJdpbv5SFT0a0CGduoKQOrZOa9iddBjZtxZLeBkqB01zBOE91+kQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7649 On 12.01.2023 13:16, Jan Beulich wrote: > On 04.01.2023 09:45, Xenia Ragiadakou wrote: >> --- a/xen/arch/x86/hvm/vmx/vmx.c >> +++ b/xen/arch/x86/hvm/vmx/vmx.c >> @@ -2143,6 +2143,14 @@ static bool cf_check vmx_test_pir(const struct vcpu *v, uint8_t vec) >> return pi_test_pir(vec, &v->arch.hvm.vmx.pi_desc); >> } >> >> +static int cf_check vmx_pi_update_irte(const struct vcpu *v, >> + const struct pirq *pirq, uint8_t gvec) >> +{ >> + const struct pi_desc *pi_desc = v ? &v->arch.hvm.vmx.pi_desc : NULL; >> + >> + return pi_update_irte(pi_desc, pirq, gvec); >> +} > > This being the only caller of pi_update_irte(), I don't see the point in > having the extra wrapper. Adjust pi_update_irte() such that it can be > used as the intended hook directly. Plus perhaps prefix it with vtd_. Plus move it to vtd/x86/hvm.c (!HVM builds shouldn't need it), albeit I realize this could be done independent of your work. In principle the function shouldn't be VT-d specific (and could hence live in x86/hvm.c), as msi_msg_write_remap_rte() is already available as IOMMU hook anyway, provided struct pi_desc turns out compatible with what's going to be needed for AMD. Jan From xen-devel-bounces@lists.xenproject.org Thu Jan 12 12:38:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 12:38:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476113.738110 (Exim 4.92) (envelope-from ) id 1pFwr4-0007tM-9I; Thu, 12 Jan 2023 12:38:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476113.738110; Thu, 12 Jan 2023 12:38:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFwr4-0007tF-6W; Thu, 12 Jan 2023 12:38:50 +0000 Received: by outflank-mailman (input) for mailman id 476113; Thu, 12 Jan 2023 12:38:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFwr2-0007t9-Ut for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 12:38:48 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2077.outbound.protection.outlook.com [40.107.7.77]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0e22cb03-9276-11ed-b8d0-410ff93cb8f0; Thu, 12 Jan 2023 13:38:46 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7686.eurprd04.prod.outlook.com (2603:10a6:20b:290::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Thu, 12 Jan 2023 12:38:44 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Thu, 12 Jan 2023 12:38:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0e22cb03-9276-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NwYYy558c98kKk98O+VctJnG1a/FElC7VxN26+COLLHPvK+rj6dBwOPWoz+hVhkpHYRksOKSVt6gacEBICkqrrkwd/c/JK85wCuBkiR6j+PPcFGMfSgwyaOgBtu1YUZms5rjH/sKxt1Wd8y03EWpzAXVgMvmorfLwJ7ctuTHxWWIoRD6hFr/+ji3b+c85OdWGXNtp/NW65B2+VDJxIb1sob/qRa3+H0/7qrsOPp0iGu3QYKLp0ChGCHejgUTNGx3NJ0vqce0qpgOE7t7sWaigmdOnpsBSz6yaAiUOztG1jriivWAgDPRKWYzv5YK4MuinH/sDiUZdqcFh4KmmLJJPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vGTUujg26/aFOTeDzWoP7dUsYAG6NhFV+q1kSVgBxUY=; b=R6Qfg45Ro9N0ZDO6mZsymbSRSFhj9EJzecGoO/rmKQj3N46WG7zS8rDmX5HGQahgu/OZbLjZ7Lcc1ihfUClNGQ0ncsVTZefjDJi9f7XyYUoaOGwae6CQv7OYSavWHUmE/3PhUEvcHJW/JF36FgpACUxVUO5JIOkkCNOESbMav8eykQP0i4+8uCjD3dGiqN0ltoPvpq/+TnHshqDjL99ta48t1f4X+wyzeVJfa6zDUanLPS6rSgmZQBLb6m/7k+NYxNMWH0iXix9hePmyrJjc7oUMkagU11+MkoBv4XcKz+b+5fTzhhBEC+RCwdZKTu1X/3g+aLR9hMZDIO2AHgjhFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vGTUujg26/aFOTeDzWoP7dUsYAG6NhFV+q1kSVgBxUY=; b=269nBU0bpNIUlbXMysfetnF9UIAotVC6dWipK6HZxVfanykl5y7iRRSEoDxcZ/Zspz8E2BK3dTdaQKSGq+MRYTg+362C3wVBcSSogRfkMKXzOpqQCtfjLR+YgTupWHOR1/jjdjyBvudL0f9tZj+J+xUw3waDnfo4MhOH87H13T2xnTydUo5oC8n2V45TUutkzN1c5aqor1SGtym0YoHq7i8wDcRD4v6iPCy1ld+YtRprJCR5mj1LAU0LzLwVyh0cyTVdjRgxaCK2eaP1H8xfgeG2RkHNhJT/SIZd19UudbiZOZYoR8ryNRQ8GMN3N2lzgEG3XfOcvTe1CPLy3/Cy7Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <4770d744-ed33-4246-4ba3-8e1fe8877587@suse.com> Date: Thu, 12 Jan 2023 13:38:42 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 8/8] x86/iommu: make AMD-Vi and Intel VT-d support configurable Content-Language: en-US To: Xenia Ragiadakou Cc: Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20230104084502.61734-1-burzalodowa@gmail.com> <20230104084502.61734-9-burzalodowa@gmail.com> From: Jan Beulich In-Reply-To: <20230104084502.61734-9-burzalodowa@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0180.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB7686:EE_ X-MS-Office365-Filtering-Correlation-Id: 51ddaf7c-6ad3-4504-9b15-08daf499f147 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IDXfMyxWrBoxZY2dJt0zxnbBVwmqgKxvmb1xzNVT/KTbwQGzrg0slxnzd0C7j2O4T9FkAgeeZ6HFdLGh8k7DJCF5+UHQqbHe4C7D4SlG8ClkAC5XnCQtHfb/iXF3u5JogtAr/tuCPpRTn3jl4JsUaplmRHObaQkfK8TqLc1dwHHHl+JbdG5DSHwdxInoNqBHLztkVF4T+ViSG7YJvDBFNZP3dhQMo/IRGFqfuhyc6LdxcJ4AScAnrrQV44wHBi36V/9jXvCB+PzCVX7kxEHzGtN/VWGQKAib4ReTFLJLfDfDLT0BycIBjIcUos8awLCac+HXQfkEyYHMLBJ52x4ai5qseIBgYsj6eI8pGiP6I6bbywLQeUcJc3jBNUcN5W+JKRtdTiKeB+EGW7wiR9MdYIBuHa9PPVYYPzvwgj4wle2hPhdeUAmZGsgpgB+4wiRN1Pdjfr4i+kT4bwSXSq/ppEfLZUQ9dqQBvlhNotr/M1/ed6YQqUTnyTz4ODaJsc226xyBX1/5EIIuUhgeBHl070rUDXbdiI/OtKA48m0lXXQTnY4Dx7K21aoXPbdD22OD32bzRliLV2xGZtiABWLtX6r64LWB5qrVpfIhTFrMYcsrZxZ2XUyTX+pBxW65cbDKyRDSCEGl/F3eSaN6EVJXM+YH8Ta63fh8gVT9tD5dhtrD7mb+AryKoefIqgO4dyXUGLYI1rP+cV08zg2h7v3ZdltXPehcR0k3DqN44I+GNXM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(366004)(136003)(346002)(376002)(39860400002)(451199015)(8676002)(66946007)(31686004)(41300700001)(2906002)(8936002)(36756003)(5660300002)(4744005)(6916009)(66476007)(316002)(66556008)(6512007)(54906003)(478600001)(6486002)(53546011)(6506007)(186003)(26005)(4326008)(2616005)(31696002)(83380400001)(86362001)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NXBsSHhnU24rT0FncktKWVN0MzRSMDg4d1YwK1Z3Z0kyZjhrdExFYy9RZ3Zw?= =?utf-8?B?c3lKeDM1eE9EZjBIT3B6R2NyMklTczFLeU11eUtzSWJrRFd1bytKZHE3ZHEw?= =?utf-8?B?OVMvbUlRVHVGTmxwckE4Y0NadkVpMlQvK1NJRFdZcUwwdGtjQnFzZENSYkxm?= =?utf-8?B?U2JncDhXTWFjVlZ4K0RRT0dUOENMTHhqbWlqTkYxWjNMc1dWUkZCMTdjZlgz?= =?utf-8?B?UGlmdWUzWmxJS3QrMDNmWkNPVVA3Vk1lTE1IbmtpampLVU9YZW1PbG11My9x?= =?utf-8?B?bkE3dUN3N0syZEJXbUYwRzgzWlR2emdybEptSWErOGllS2hKR0pwNzhqQk45?= =?utf-8?B?dWU5VkZMK0NVQWhybEx0WlQxZjRnNVNHWkxjTldnMmY4bTdybFN4ZFU0SzE3?= =?utf-8?B?enRCcG9acHMyWW9oeFlEcGJyOVBuM0hsdXl5RURWeG9jUXNzN3dDT09iWmVm?= =?utf-8?B?dWxxanlLeFJGMHA2Si8wZjM1VnN5RXZJMVAvN1R0UlJOZHF5MXN5S214QTNS?= =?utf-8?B?NEJDVndUZy93Snd6djRteXA5TC8yRWtERU5kWXkvcE13V2dNU3I3ci9hRTJN?= =?utf-8?B?T3NlRjdSWmV4eVZFc2ZDYVl1TXFBbllmUU8rYjB4eFVXS3U2Q3luU3lzdjNt?= =?utf-8?B?WHJMc0xRRzNaTGF3eEtsM0JqQmlxTldudHZJRGZmYW5ncVdNbmtTM1BKam8x?= =?utf-8?B?STlONWU4TGFaMDUyZ0k1N3IzbGVjMkMrdTN3SCtDSWY3aUdhUDN2S0gwampP?= =?utf-8?B?NWE0ZldaVUdyTGVIS1o1eGJVanprM2hzcENBNE1aeW1SNTNpQVVxeHYyam9w?= =?utf-8?B?Yy9tMnFZd0NYL1pXT0p1VWErcGxRZU5ra0ZyeGZRdUxpTk4zV1lpWnZjZEgr?= =?utf-8?B?ZmlzcloyS29mcStCanBZelVzVVpDYzMzb2tjTVdBRjFWMmxiZHFLR1MrUUFr?= =?utf-8?B?em5Bb1pjNzZFblFDcXJqNUFvODdSanhFdklWTnNZdjBwSnhMSHBqczVlTm9t?= =?utf-8?B?a1BMdzFTZXc0MzJ0eXlld2hSOVFxN2dkRWMySVFKcVNOQVFUWk4rYWRiZ3Bu?= =?utf-8?B?S3hjZG5uUTZkUzE1eW9lSXp3MVVXcmh2M2w4MjJxYlBoTVNmMG4wNWEwdjMy?= =?utf-8?B?VzVzaEpqUnhVeTRsU3cwK1dwQ05WdVNLK1VhQVp2TXJwVjk0eCsxVVorbzFK?= =?utf-8?B?c3daK1NWa2I5dTFkRlR6UkxUNFgwcnkwbmh6QTRxYko4T1ZlUmZpTmVjUFNs?= =?utf-8?B?YVJoNENRY3c0czIxOU9DeE0wWHFOV0w3U0xJY05xNk5tMC9yRmV3ZXJtUFdo?= =?utf-8?B?eXNBK2dHajkxa1VBMWRiMmQyUmx6cExYNTRaS1pWeEk2UkFEN2hmUDRrUWRE?= =?utf-8?B?bUs0ZWhYMHB3WmtIRi9XTFV5TmhTdm9FSWRUQlJlWStrV2ZsZldKSU1yNDB2?= =?utf-8?B?R2drTkVNdzlucWlYOGhlbHUzb08yZ1UwekpwcHY1bTJvTUtibDVGTWFBbUFt?= =?utf-8?B?TG5sWXlNdDF4RzRWWForb3p2MlovSWNhRlRzdjBUZVVYSnBPQlNRNnZtQ2hl?= =?utf-8?B?YVBWZmJSRTNWZWhNWVdCUTQ4YWE3WlFNTEN0bndIMU9YZWk2bFBjZGdEL01Y?= =?utf-8?B?SUZtM2hrdWo0Z3JNc0hoZWRjV2xRcE5PMjNKc2FPQlNIbEgzenkwRTRXSk1I?= =?utf-8?B?QVFmejgrUCtncGxsRzVSZW1mK2lOd2x0QkNTWE9KU3pnb2N5NnYyelMvd09i?= =?utf-8?B?aGRCWk02M3g1c2xHTTFLTThxbnpVeUcrbG9RcmVkZHF2UFFCYTNQWld3aDNJ?= =?utf-8?B?K3ZlY2VzWGdTcldTZE01OFAvZjRXWUNmSHVydTZDVStxanYxSWtQRXBCN3Fs?= =?utf-8?B?RzRCaEF4ZkN3ZmJWV3BqdUpFU0FyZXNlWGM0eWMrbVh4cnZlRkw3dml1Tm9N?= =?utf-8?B?V21UL3NmZTVzbTdMTEdIbEZxZ3NLNHdEMEl4dE96SHYyUk1nSXpWT2RmUEtC?= =?utf-8?B?d0NuckRuY05CbDBKcUtTem10UExJWDR0RGg3REZBbDg4YU5vckJSTDFDSHor?= =?utf-8?B?NFdLbkZHYTdZOFJZUzJNNkFzQkxIeXA1VHZramZTRmxLS1pnQ01zbHpGbmZU?= =?utf-8?Q?n+md5GBcgZwydMUFjj/wNhJ8r?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 51ddaf7c-6ad3-4504-9b15-08daf499f147 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 12:38:44.6677 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /ks0kE073OVeUq8ffrRGwU97MACRqCSg5surG7N+37tgqSWQe2YeBIE6rz3H4ZpdE1KShfmUJiJK7hsC1WZr1w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7686 On 04.01.2023 09:45, Xenia Ragiadakou wrote: > Provide the user with configuration control over the IOMMU support by making > AMD_IOMMU and INTEL_IOMMU options user selectable and able to be turned off. > > However, there are cases where the IOMMU support is required, for instance for > a system with more than 254 CPUs. In order to prevent users from unknowingly > disabling it and ending up with a broken hypervisor, make the support user > selectable only if EXPERT is enabled. > > To preserve the current default configuration of an x86 system, both options > depend on X86 and default to Y. > > Signed-off-by: Xenia Ragiadakou Acked-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Thu Jan 12 12:40:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 12:40:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476120.738120 (Exim 4.92) (envelope-from ) id 1pFwsz-0000uR-OH; Thu, 12 Jan 2023 12:40:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476120.738120; Thu, 12 Jan 2023 12:40:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFwsz-0000uK-LT; Thu, 12 Jan 2023 12:40:49 +0000 Received: by outflank-mailman (input) for mailman id 476120; Thu, 12 Jan 2023 12:40:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFwsy-0000u9-Fj for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 12:40:48 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2088.outbound.protection.outlook.com [40.107.7.88]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 556ab6f9-9276-11ed-b8d0-410ff93cb8f0; Thu, 12 Jan 2023 13:40:45 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7686.eurprd04.prod.outlook.com (2603:10a6:20b:290::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Thu, 12 Jan 2023 12:40:45 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Thu, 12 Jan 2023 12:40:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 556ab6f9-9276-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N9vy4f6aVVyOv0raB1LK7GyUtZGZYVL8KuARyOmpMMZCiQ5ydEKE4an1zI+2ztS4N9RyFFaBhImORDP9+fHVamdVtOLYp/DH8opt7zLZYj+QzE1dO+fDBts6bja1zdV8X/+3QGgWVFiRQXxbwjxJA2sgQcgsHi5GktmXOqpIvYzEcrh0Y8Pjbw69/cM9uVZA8hBzwPW1X1GsCPO/sjCfrNageRuYEGOw+XWOMOKanP4V0TC1tOOvlHOR5o5xhF2MR5NaSI42y00ouxq4fYVu2t+ZJgbzhs4kkE+5/nEZMrxuMiKguhiLsB6qd0BZ81zSAYnV+TgPy+rG06abzQfX3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DWGd4cOKC7AWrDXtTKfwpBoWoOay9JCrx3MBYUZ5DJg=; b=UvaqhYY9oGmDiNKzq0qXCpD49EqRH3nnzZ7i54nm8gSZdloEO4/TLqoOIO9xUULYlCli7VFg4TYyg6P0N8OypIqxMYkHTQsjwWhl2wnVkQKoGf5K9wCFy3cFFd2DxJoNJnzniYLNod4Hm3rI7PlY8RppTIJMhsYwfPRLGMiNHdH73Jh0Ai3dCDRQ2SYgDaYrDYmij6YtPyCU+Dy2/gyT90cId1zorHUQ0li195YrCZqUicemGL6znMNyHQxv0NdIn/nn0sS7hSweBA/rhojdWrx2GfjO1Dt/JrNKwQ/gqzCv6NprxCBxwZwH6cjr9dXUGtUs/cMmk+L61gWi4x01uw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DWGd4cOKC7AWrDXtTKfwpBoWoOay9JCrx3MBYUZ5DJg=; b=KDaYXao1qlwsbNf4XG+XArbEaioH1t6cEGV3aEKjcix8YWN+hQndiEo0DIEudFiTFTK/WvWVTGqtpg2yHJnPH6XNApJ9K+/LOtmF7xnIfn2CqAB0qcKr70jRr+PsevItnitcrgYwlUpgpcXuxPxy27fzuhCOZPGIAylAfg+ilrLHgAzGibVwiOcO3R0D/t83GgoTkZ2IGQF3KLLNWvSj6dAKyHooIRpPrpeCgpN2qBpDAIv/2mp4pXMsdIJzoLxjQsT/xMP4lxFHRuW9u/8Vo1rlA56OAwmFm3yjeUnhV0QYExgWUQc1GIyeHzDmAcQyeYLUZgm+RrLNcqpXO3hnLA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 12 Jan 2023 13:40:42 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 4/8] x86/acpi: separate AMD-Vi and VT-d specific functions Content-Language: en-US To: Xenia Ragiadakou Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20230104084502.61734-1-burzalodowa@gmail.com> <20230104084502.61734-5-burzalodowa@gmail.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0135.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB7686:EE_ X-MS-Office365-Filtering-Correlation-Id: d3cc2a75-d9ea-406d-5b43-08daf49a396a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9+rhKCDEISSSMsh8JdkaGsIcmw/B7LnuXiP93Zy9GBfYtv9BiTYSmOVHWDkhixIAPCg/pLax4cPWUJxkXrt3Ipk8WJlRVbgDb1kRiNzMdqMg1adjJaZyRTtpZFgrPlXSRO/bC+jZxNiPBvw/ARn4TxQAa62IU7WheXDuFGG5WJC1dxUBZLXMRuglrW+MFj0jh0mLAZLLbRz2IQTX5WzphzhCu3/7zqyFqnazWZVR0kzNO6S040cDQI9LIBYOq92DAN6hxk19zyWmihi5pBFK4Qx7JfDfQg/tKBo2M/NbmI3jdCm+RTRKKwMxDPnOU0LYwIJV02kDJK/bTZWZf6q3es7jWfkrmnqsdyTT0Rc1CKvS+urPJSAC4+RDBcFxSVniEg5pDfBFWsnTrNc3J9kljrwXVpVyAmEkd6lGyHTDx9GuyT0Qp4ZBZ93p1d1M4eZQgraNlbsMEXf3enJmYTxx9mpTOF9/XHBcYDDlQO5Ezh2lg8uQkeysgdmCIoIcwKJAIMFkINPZAzyVJqlNWpX2ZI4SqS55vPBBKAJe2TmP3/D7HSQ2ZTFpNaYwcftLpTr6FrxRrysOLeoALKAgak2DEH/PF31De70vQkTmhvHAJKlmXS8Gt5I0SPxvPOhlb935TX9yDR4BhtknblqG+gUv76qfwzUqd3IfBYMHOw+XXC4u5uFUPpleaWsffaU66GYeULR5RueibvOT1uLhLwyylx7FmgwIFfudl5+BB0sc29I= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(366004)(136003)(346002)(376002)(39860400002)(451199015)(8676002)(66946007)(31686004)(41300700001)(2906002)(8936002)(36756003)(5660300002)(6916009)(66476007)(316002)(66556008)(6512007)(54906003)(478600001)(6666004)(6486002)(53546011)(6506007)(186003)(26005)(4326008)(2616005)(31696002)(83380400001)(86362001)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cC8xTmMza21WM0t3bzh3eXdPWHRmS0tiZjVpOHFKM3J5RlpDTWUrVWRYeGFN?= =?utf-8?B?SzJhUi83cWZieWVyVGVJZkcxTlhnYTA4Q0Z1aUd6aVRZUUFNV21CQnhWTGpk?= =?utf-8?B?RHUvRTlaT2RVOGVjUkxJckN6QnlkZ2hvZ0pmbWJtUCtKeWNuREFqTm1xZ21J?= =?utf-8?B?T2cyN0h1N0lIeGQ3UDZGZU1ZS1UvNk0vTWc1K2cxN2ZubE5HczVneWpmSFJU?= =?utf-8?B?dFdFNU1nVGJENzBiNkxwZmFaQ3NWdkc5YW9Bak1GMU1UVXFvYW10NFcyNWhm?= =?utf-8?B?M0lVQ1hmd2VNQ2MxZXY0Z0d5OWowcHdyc1FzSVhHc1o2MmZLRFpncnFjVmdY?= =?utf-8?B?TGhMQXQrQXU4Nkd6Wnp5amN5eDcxQTA2NFlLMnRQSWJ2eFl1ZFFnWm1DQU4w?= =?utf-8?B?eTNxR0Z1R2d1T2RtemFPcmRZVUhZSVB4M0cvSDF5eFVoUjhVOHlteDVWWFFQ?= =?utf-8?B?UldJNVI2MGxybE5GUkpQQ0k3ZkpueGd3c0YrS2ZYSkpISDBwZXFvaThpVVdk?= =?utf-8?B?VjlZczA2NGh5L1BrdHlEWVh4TUQ0a1greW5URmdVNnBFdnp5eGIwTGVSZ21R?= =?utf-8?B?YWdQYnViLzRZRldvN1JaWVZ0RnlWOTRqRzFSL2pXWXNVbjF6ekV2a1AyRFdD?= =?utf-8?B?WjVXMG9QTWtBbkkzU21idE5FVE4yUjQ4aldlU0hOTnovaDBrR3NxUWJXR21r?= =?utf-8?B?Sm0ySlAzWFVjU2hYbmNaaDFqdW5EdjlWa3FlanNWditreEZuRUVwajBsdmpF?= =?utf-8?B?VWRuRXRMQ1UrR0dOSjY3dEh6dVNiRWhuQmVGdjVrc3dWY3FRbDRXZENSZE90?= =?utf-8?B?RlR6MUhFRmxEVGdnWDc2MW1Lb29VdFJKNkt2aDZneVQ3RC9LK0s2WHBsb09a?= =?utf-8?B?bDd4NWl4MWwvYVRtR2JiL0JPdXE1Q3VnMlhBb2ZpZUJTdkxkbmp0TURpc0lI?= =?utf-8?B?RGVRNk9GMDNocDJpQjlPWkgzeXhQbjVacUdpODloaWx1Ym1adzF4c0RXcjJP?= =?utf-8?B?WUF3QnFCVWxyRUdDdTRTY2FXMFVGWWlzY1hGMjFVWlBJTytIV25BZjJ3RW5U?= =?utf-8?B?S3Z1dU1hbVVwc0RkTWZnS0NRUkdCMjllOWdWOExaTTJjdXRpdHpXbFpEb0NU?= =?utf-8?B?UFVqNUNsVjc2bGRLeGZ0dVBaL2h2akVvUGV1eU0rS2I0RUVKZXdhUjZvOTdm?= =?utf-8?B?QU9LaXFYT0dIU05vaUVjejFqMk5MYnpvK3RpbHYybWo3dFZWVEZYRXFMelM0?= =?utf-8?B?NGZGKzNEN0pJNHlwQnREbU9xbEZSQWFxbHR3VWt4aHp1WmQvMnUvTVR4c0pk?= =?utf-8?B?WnBDVk0xSUN5R0c5cWw0ZjVFNmp4K0pnWlNZQzBTbmsvVGRscjBIdVpoTm5x?= =?utf-8?B?MG1ONDNzSDFKMTFNNU5JUVViK3l6dmUyVmN5RlpsMENPcUMyaGZvaDFrTHI4?= =?utf-8?B?Uk9PZmdFUm5uZGhQckhVNGRwaUg5ZG5BSmp4R3hsOFFPN1lMUWlCbmZvdjFR?= =?utf-8?B?UkxDRi9iT2YyM1JicWRnaFVOSkNlVER6R3JibjhNK0RkQzBYcTFDWThxZkRm?= =?utf-8?B?YU1VOGVlY2Q2cVYrVC9BM1ZUZGxoSUtOUEVQN3RCYnpZcEdBVklhMjB0VE5G?= =?utf-8?B?RkM3RnFFQlhBZXpiMy8yaTRGenJSM1RVdWtWVVlYcXFJMnZLNHorU3R6MmJl?= =?utf-8?B?RU9pdnRrdlBUWWNFR2JoeHdGU0QwTzJ1UTZFMnpEcTBVd3cvTC9iR3hTdy9T?= =?utf-8?B?a2UvR09PMXF2OWNpd2p2THNQRk9Xdm9FN3BrVndCSmwvRHV4dGJUK1YrQ09w?= =?utf-8?B?dDh1RUlldzFicE1SZ29HdWF5ZG5SQVl5SEJWWlo4UW5KZDlXVmhVbko2eEV3?= =?utf-8?B?VjdQN21UOThReUJQVWF3Q00ybEFQbU5lZzM0cm10U2ZxTGtYS3hFSzB1NUV0?= =?utf-8?B?dmlzWTQyamxIVHNFVkhuQmJVRjNlWG1HTlpyTVpxUkNlbWwvNzR4cmUyYkV6?= =?utf-8?B?alNnRFVPODVtaWhXNDRlZ3JKejY4WDVWUFNFajRkb281VWxMTEJ3MTBXSjVM?= =?utf-8?B?UFNBcDdKcUlyYzRSa09OQWhwNlVPeUtzNWxScU1YKzVsNmN1STJ3YW5ST1pO?= =?utf-8?Q?EZFqjlBK6vohECuTV59ijXqJI?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d3cc2a75-d9ea-406d-5b43-08daf49a396a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 12:40:45.3008 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: y6xdcugRQpeOeK9Nlt5mxMQNlJBjlx4srd2Oe2YV1TQoUwaOdHMS4tGIuRfZ0fqtAa2HBrmAdd0wbGp2xTGuPw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7686 On 12.01.2023 13:08, Xenia Ragiadakou wrote: > On 1/12/23 13:37, Jan Beulich wrote: >> On 04.01.2023 09:44, Xenia Ragiadakou wrote: >>> --- a/xen/arch/x86/include/asm/acpi.h >>> +++ b/xen/arch/x86/include/asm/acpi.h >>> @@ -140,8 +140,22 @@ extern u32 pmtmr_ioport; >>> extern unsigned int pmtmr_width; >>> >>> void acpi_iommu_init(void); >>> + >>> +#ifdef CONFIG_INTEL_IOMMU >>> int acpi_dmar_init(void); >>> +void acpi_dmar_zap(void); >>> +void acpi_dmar_reinstate(void); >>> +#else >>> +static inline int acpi_dmar_init(void) { return -ENODEV; } >>> +static inline void acpi_dmar_zap(void) {} >>> +static inline void acpi_dmar_reinstate(void) {} >>> +#endif >> >> Leaving aside my request to drop that part of patch 3, you've kept >> declarations for VT-d in the common header there. Which I consider >> correct, knowing that VT-d was also used on IA-64 at the time. As >> a result I would suppose movement might better be done in the other >> direction here. > > I moved it to the x86-specific header because acpi_dmar_init() was > declared there. > I can move all of them to the common header. I would prefer you doing so, yes, of course unless others object. Jan From xen-devel-bounces@lists.xenproject.org Thu Jan 12 12:42:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 12:42:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476126.738132 (Exim 4.92) (envelope-from ) id 1pFwuE-0001Tq-2X; Thu, 12 Jan 2023 12:42:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476126.738132; Thu, 12 Jan 2023 12:42:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFwuD-0001Tj-Vr; Thu, 12 Jan 2023 12:42:05 +0000 Received: by outflank-mailman (input) for mailman id 476126; Thu, 12 Jan 2023 12:42:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFwuD-0001TW-6u for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 12:42:05 +0000 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [2a00:1450:4864:20::633]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 844231d1-9276-11ed-91b6-6bf2151ebd3b; Thu, 12 Jan 2023 13:42:04 +0100 (CET) Received: by mail-ej1-x633.google.com with SMTP id v6so1432346ejg.6 for ; Thu, 12 Jan 2023 04:42:04 -0800 (PST) Received: from [192.168.1.93] (adsl-211.37.6.0.tellas.gr. [37.6.0.211]) by smtp.gmail.com with ESMTPSA id lb25-20020a170907785900b007c00323cc23sm7412168ejc.27.2023.01.12.04.42.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Jan 2023 04:42:03 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 844231d1-9276-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=bzEU3EbHAD/6VGyAoPP7dH3w4Ub3KtjPw7ftvjmLQG8=; b=Z4PwmN8YlYegibwxRAtmfuNDbreknXyS0sAdpFuhAHazPjMQlAREdv9GT4fVQgkFid jfQ5eGtGS0eGFmI8Y5j8l6+waWhcO0xBd5+enJS9SefGd1vffTxZXriNkcBG7vC51vFK USsZ1jBcXOMT6AM9CsdDogh/S3djMsYZEpCrnTte77zAca30LZciGhyeh9tFCoF2cO7s 4vqYtrggs1rYju2CiOXDfpdA+ypP4zccj7CuwNL2XWeCEE8i30jaY851lkEWi1xoiU59 ZKtm5uN1veaShHkEljfKs7js5YYmd/l890BO7+dg1VPo4CZ7Tf3bkxhWh25QWX221XB1 4/fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bzEU3EbHAD/6VGyAoPP7dH3w4Ub3KtjPw7ftvjmLQG8=; b=0fWJlhWY3Nc4Gpg6FORYpDLiGhhxS9JE/dVp/VGjW0pJdwTY8qQ8YRO2hdqALD1VXy 05yt6PtV8Ju9u24Bk+hTkNSio7l7Q6H6vQkLOPEceiThxWin9QitZ5kuKKIi2cBx+iKW tHZngQYyLTjkor87WjVaoAZQWdqD404vIGoruWT+T5a2Y7R78GN85FPT86Kszte/qMOL QkYGMWcS9G4t1JpD/skR3sRYWqAp4ad5Pfo1uAydEX5dDmGmOQbx8X2yrdktuAPPdp/i PzbCkbt+oaoYMLQo6MJab5qLB8p9oOtkfgTsXcgXmlv3RzdieLiYUbbVSaNFaRFMEpAr d50g== X-Gm-Message-State: AFqh2koGynFlg2lFYSWt/y8iyib1kPl8ILp1Rsr8EaEGWhac6QQhdm32 VYOJxopIAURaE8Hck7uYhW4= X-Google-Smtp-Source: AMrXdXtw+Y4PHPVT8RHEy5KBfbeevUJNjxyjGcweIMGMhyHA8gbCWsTFuIqC9siCC8Kefq704EUoHQ== X-Received: by 2002:a17:906:39d8:b0:847:410:ecff with SMTP id i24-20020a17090639d800b008470410ecffmr58815369eje.16.1673527323793; Thu, 12 Jan 2023 04:42:03 -0800 (PST) Message-ID: <2f5699a7-83c0-68c8-3303-c77d443f3fe7@gmail.com> Date: Thu, 12 Jan 2023 14:42:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v2 5/8] x86/iommu: the code addressing CVE-2011-1898 is VT-d specific Content-Language: en-US To: Jan Beulich Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <20230104084502.61734-1-burzalodowa@gmail.com> <20230104084502.61734-6-burzalodowa@gmail.com> From: Xenia Ragiadakou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/12/23 14:01, Jan Beulich wrote: > On 04.01.2023 09:44, Xenia Ragiadakou wrote: >> The variable untrusted_msi indicates whether the system is vulnerable to >> CVE-2011-1898. This vulnerablity is VT-d specific. > > As per the reply by Andrew to v1, this vulnerability is generic to intremap- > incapable or intremap-disabled configurations. You want to say so. In turn > I wonder whether instead of the changes you're making you wouldn't want to > move the definition of the variable to xen/drivers/passthrough/x86/iommu.c. > A useful further step might be to guard its definition (not necessarily > its declaration; see replies to earlier patches) by CONFIG_PV instead (of > course I understand that's largely orthogonal to your series here, yet it > would fit easily with moving the definition). Sure I can do that. > >> --- a/xen/arch/x86/include/asm/iommu.h >> +++ b/xen/arch/x86/include/asm/iommu.h >> @@ -127,7 +127,9 @@ int iommu_identity_mapping(struct domain *d, p2m_access_t p2ma, >> unsigned int flag); >> void iommu_identity_map_teardown(struct domain *d); >> >> +#ifdef CONFIG_INTEL_IOMMU >> extern bool untrusted_msi; >> +#endif > > As per above / earlier comments I don't think this part is needed in any > event. > >> --- a/xen/arch/x86/pv/hypercall.c >> +++ b/xen/arch/x86/pv/hypercall.c >> @@ -193,8 +193,10 @@ void pv_ring1_init_hypercall_page(void *p) >> >> void do_entry_int82(struct cpu_user_regs *regs) >> { >> +#ifdef CONFIG_INTEL_IOMMU >> if ( unlikely(untrusted_msi) ) >> check_for_unexpected_msi((uint8_t)regs->entry_vector); >> +#endif >> >> _pv_hypercall(regs, true /* compat */); >> } >> diff --git a/xen/arch/x86/x86_64/entry.S b/xen/arch/x86/x86_64/entry.S >> index ae01285181..8f2fb36770 100644 >> --- a/xen/arch/x86/x86_64/entry.S >> +++ b/xen/arch/x86/x86_64/entry.S >> @@ -406,11 +406,13 @@ ENTRY(int80_direct_trap) >> .Lint80_cr3_okay: >> sti >> >> +#ifdef CONFIG_INTEL_IOMMU >> cmpb $0,untrusted_msi(%rip) >> UNLIKELY_START(ne, msi_check) >> movl $0x80,%edi >> call check_for_unexpected_msi >> UNLIKELY_END(msi_check) >> +#endif >> >> movq STACK_CPUINFO_FIELD(current_vcpu)(%rbx), %rbx >> > -- Xenia From xen-devel-bounces@lists.xenproject.org Thu Jan 12 12:48:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 12:48:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476132.738143 (Exim 4.92) (envelope-from ) id 1pFwzx-0002CM-Pd; Thu, 12 Jan 2023 12:48:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476132.738143; Thu, 12 Jan 2023 12:48:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFwzx-0002CF-L2; Thu, 12 Jan 2023 12:48:01 +0000 Received: by outflank-mailman (input) for mailman id 476132; Thu, 12 Jan 2023 12:47:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFwzv-0002C9-Sl for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 12:47:59 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2081.outbound.protection.outlook.com [40.107.20.81]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 579c3eaa-9277-11ed-91b6-6bf2151ebd3b; Thu, 12 Jan 2023 13:47:58 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB8PR04MB6940.eurprd04.prod.outlook.com (2603:10a6:10:11a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.19; Thu, 12 Jan 2023 12:47:57 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Thu, 12 Jan 2023 12:47:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 579c3eaa-9277-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XkXJKszHgtwScjrSDfu1kesMGdUZT17Z1KT5a404LKcOKJE7BUk5FtxtPckmWJbOSjErs44bmzOXiuVFCd6Qmfe+UUuFzC8TTfLxbUJfZxGWriK6Dys/c1bYNBfdTArwiIhHoSREEPTF30QBowpmBW4o/ZbdhVemufEOlra29UxW+zF+ijDIi1EwslRgMVDGcsv4U4cgUtP6Qw1zMIGXcJ+Mjlhk/RHMUQ09ez/WNZAUh425WRF3ObJMAb3CZYqYHJcfNbuNb5BkTqx4fSaJp1hU91RYB20v58sDSUFMZJvCVV3c1QMo+9jwK8D/TiQG9wvyzE3dR6VOoQCiPIQ86A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+5nq5y+s6CvaJEydMt/0aW9bpCFjZb/jW5gJ8rxtVn4=; b=Zpc83K78loaQ81jVqnhR3/txwi9hJ+sTdGZlkzAEZNzKsFIRHQQkMdXo4JwtoZNP4+Mw72GuU+7Ukq9ktxbyqv9PpEQ4n+AYgkj+d4AcgNst/QZxCQ0o9Uo9f1KHjdSyP8PAUewlJ0hgcRjVoOyRKeEEpMPHytmX3IPFO7Op5X3gXMxq4ZWHynJ112RY0Yy2Y1gZYZvp6KkU2BK6RdRSH18SVqFpgvvNm5hbiHVfGUnwKGENjasAtJg70CQmAgi5IxHG5SNQmVEJRjrUUmEl2m8Xo87rCHksyUcMPyU0mxcnYKAsYI3AMn1G/UceAllN9y8lei+ZNU784HuPUP98cw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+5nq5y+s6CvaJEydMt/0aW9bpCFjZb/jW5gJ8rxtVn4=; b=MC0W8ulI+5baRyVmOgIiHEmjiZyZ9YmjmP1KUkBExzDxHeiYOHWH+yBfgXGxm+JzRKQ29UqmQlhU2Ew+9XrUECZJgrAa3zBLVhH5HSGbm+ZPMaiHAsFSQt3HVt6+Nnw2+f1qYe4WMWoYAfRAbCHV/zUmeBwFaH5hpQ886sPpWhbk/W09vsM/L1c8TSwoxwfwvuyC1uiK49BGHN9Dgs2XoE4QDto8yoPH0nbxCBgJQoo3EhZITvfjllhidm6PohMWkJV3ejIFKNTnLFUbExLQr8mAo+KSr81FQgsJ9uOIQygaih4jPSJBtFAvRhSpl4dF8X1Mc73s8uPfPr0F/t+bBA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <27d830b1-a32b-1368-3c0e-e5de15da5000@suse.com> Date: Thu, 12 Jan 2023 13:47:53 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 1/8] x86/boot: Sanitise PKRU on boot Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230110171845.20542-1-andrew.cooper3@citrix.com> <20230110171845.20542-2-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20230110171845.20542-2-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0030.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB8PR04MB6940:EE_ X-MS-Office365-Filtering-Correlation-Id: a73ac689-367b-43e0-2b90-08daf49b3aa6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Nl9RnMG1iwqpukWCqXYM1+zj8qTYEug5ifEc+dVJF2WU+5EC0wnPuJ+FmGkX4SGyaQ6+yZwE6Pie8RPCt2Si61iwj+if/dixJZHK908Dd1W+eOVW81J/oTwOO7h1YJ+IBqBpuZcl8dcP/3e3AmFICnAPJFZczfeutciJz90HTO44wyHmXm4bNxy5+BjjzmJIJWxYHRk7Ako/8K+MxkDTbCDSS0WH4zxVQC6QrrPf1o4SMjxbNKODWT3kCm1LtE0wc0w/PJs20lbLZYEx6I69MEKYcsmOGUTbkzJhHPpXY0Wdm2A1yBGCp8IehEtz7NYYIG9e6cWW8fYkL3pBq2CPzExjacBRMC+0ODoLByNLdPzOqY7OPyTA0ytb14uGO0dfVpff9FBmLZokLlH+msEu1iOUiFhKT2FAC07j6vpctmkql8A0uSbr3BYt+As6LJlVmKJYMiS3t+4Y8tVzDF1ZLKDfRKNKbp6iEkJ9FoMQKiEgZp3PLyAblg8iPHH7fPIgXCZCHmUVnXrpzgMHxQpVixQLhMNHgaObTuNIvN2vtTbCt6K3zN/DsPjvFwnLXRegAVUpLtf+LjzWTXPeNJmFsKIIrRDRBE1Gz2l7QnuOsYyy3tXbHRIatoxN7TtM+cOZ19Hci+eAEE+Jmp0jVszd0SFdzy/N03R4GW3Nrg48zYOyhrfEKbOqnAxcvhPv46AN2EC9qgZQ/EEQZ3f1d2I2nAHGIQZ2EdPMLo1U2rTPdKg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(136003)(366004)(376002)(346002)(396003)(451199015)(53546011)(186003)(26005)(6512007)(6666004)(2906002)(6486002)(478600001)(6506007)(31686004)(66556008)(66476007)(66946007)(8676002)(316002)(2616005)(6916009)(4326008)(54906003)(41300700001)(36756003)(8936002)(86362001)(5660300002)(38100700002)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T05kQkN3cWd5cVd1RDlsQVQvaGdRMjRNOEFnL0lmbHFvMmthSTFNU1E4alRt?= =?utf-8?B?ZENNMnhKdVczWmV5NUtaZ1d1YjI3TWtPYzZKWi9yaG45eWIxYnVSWjQrR3Js?= =?utf-8?B?YmY1bnU0anY1VFlvNEhyY29XUVFBSzd0OHRUZ010ZEtnOUgySzBleG5yelhD?= =?utf-8?B?UDlyRTdLdXltb3hidWVUQnVPQ2llWDJ3U2ZXajdzU1lNaWZ4WG1NNURQTVVT?= =?utf-8?B?eXdMaklwdTdPYWZvZUNsZ1NZRHZxTVpJVC9tL2l2K3VxMU1MNElWQitxQU1I?= =?utf-8?B?dnVaZ0xwajFYa3VOeVJadVQ5cVBBTHZJWUJYdXcwTnJwUENMaDRyK0tkbXdK?= =?utf-8?B?WEtGbkltTDJsQkIvZ1VjWGFrcjJtUVlkTFdac0VSclRmVk5PaTBzV0x6SS82?= =?utf-8?B?cWtqVzA3UUNUdCs1TEJBVEI0UDRFWEMxVWRIcmZJTFozcWNXdGtLVG9ncllY?= =?utf-8?B?d1VPRGcrekJROElyUVFJRzJKd3ZEcll5bVNGRlVwSjNQYUxacGtqcjM5MVVv?= =?utf-8?B?M2xtTFNhckFwZDFxK2VucUZEQkFHTWJNS3BQbGxENGFNNW1UKzBjeVNBb1hQ?= =?utf-8?B?dTFUOTFDRUpubmhzamo0WU12bXNOWExaVy9OT084YVcrcUo1YngzOTJRS2Nq?= =?utf-8?B?bmdQZjVjQkx4dEt1S2lsUjhUU0ZLY2s5d3d4MkgwRTVQbHpKMytsMzNUSmgv?= =?utf-8?B?d3cwdjVaeHFrVW1NNEpWL25pMTY4OE1MRktUQUFVZkhZRldvQm1oL1U0R1hC?= =?utf-8?B?WmQrdElKQzBaSHRGbjI1RTN5eUFxRDUvaHZzaUpta1E0S1NaMUxIRHRYRVJW?= =?utf-8?B?U2xZVnRMR3ZOMGdUTWl0VDZOMkZ2TTB2aW9VVTJJWENJQXpBS1NHb2hrMGpM?= =?utf-8?B?QnZsdE03U0hUWXk2MkdtMmNSbEduUVVteW41cUl4bDg3TUxncnRNaFB2WTZC?= =?utf-8?B?RDBnRGNoeklkcmdxNWhQVVQzR0M4QUY3SGlTZk5VK0huQ0p3cmFsQ2FwSjBr?= =?utf-8?B?bWxETERuRjgzV1lVUmY5U0ZZR3dXeTJUNzVMQ1RkYUs1WjBhNDcrUHAva0xR?= =?utf-8?B?REdvelJRdDh6NnNtejk0NWZGcGEweHJZRHFNZk5GRXEvd2wwcHBTM1NBVTI4?= =?utf-8?B?cnpmMFhvUmtOaGhhYnd2dTd1ekY3M2pkTkswbStqMmRSSVZ1cWdJeWVUWVcz?= =?utf-8?B?U3Vrb1JDRHg1ZjlPTytpM3hndkNHaGZWWC9oL0VsdVFQb0JFdlhYalgwaWpr?= =?utf-8?B?cVJNdHZCYjB5QkpGWHBUTDJxNG9UNmY2ajJ3VEtDZDIwU2IxWjdJcTRaRVNN?= =?utf-8?B?SlhRRUptZWZXeTNOZVgxSVBSNmNob2NKUkQ2Y282RjN1ZGliL0Zkc3RIYlJ6?= =?utf-8?B?d1lrT200UFN2NkdNTk93WFZzdlh3dWl2MTRCaGNlRTF5d1g3MEo1TjVlR0xt?= =?utf-8?B?RjZkTVlyQ0dGSTkrZFUwZUtwUmV4UXpwTVRZOTVKbHpFRi9vQUNUVzZCTlpp?= =?utf-8?B?MGU0c3IrSUZ2azlFSWwwMGxhYzNJRXdpdEgxZW1QQ01hOC9yR0hYaHZHMFc0?= =?utf-8?B?eUFTV2NvU0U5RXdCVUtVK3lxWk8xeC9vZWxuK1VGOVBJMXRpUGxodEZyc014?= =?utf-8?B?WnQ0VXEwSkxpanVpc2FSbGxnT25VV3kxV1kyKzIxU25FTmduYzJRcStCRWN0?= =?utf-8?B?RHBKR2VBdTlvM1lXcUJWYTFOWkJ4QjVNR2xhejZORVhtTkFnREpOdDZ5L0RG?= =?utf-8?B?SmlXMGh6MHhvU3Q2OEduK1RLcU1YelZkUTNSNFVlVWJIMGEyRERhZHpCem1i?= =?utf-8?B?V3pPQXdubGwvSDZNVnJTUjM4S1BKVW1ELzYvTnlGbGRSQnZoS09QSDIrajFW?= =?utf-8?B?SHYvN01QaEEwNnc4Z0dpcVZmeElQV3Z5aFVMTWFKelpPWEtBWGdRNVJ0WCtD?= =?utf-8?B?TXRnN0IyNTBEZGJpL2R6Z2J6VmFBSy85OEdTUFdZU0gzeS9FSWNVdkFYYis1?= =?utf-8?B?dUVCb0luaU5NWmdpd2RhK0JkY1NndFJLdG9NNGxrZUZoakh6am1XbTgxQjI2?= =?utf-8?B?dDhZazBFTmVqMlBudjBiZE5EaHd3K3FROGVzdjZNT0hDd1NsTEdDYnh5R3JS?= =?utf-8?Q?elIyX32zyS9bS2AT7cuPH3P4s?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a73ac689-367b-43e0-2b90-08daf49b3aa6 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 12:47:56.8985 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gfXggpVTfweQlmHh47YLjNXDQJeTvFqfa3hvz4Vr0eNwEDZoixkX+EO06dzur1QYSUIOOeN5YYJMZvfxhTYIlg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6940 On 10.01.2023 18:18, Andrew Cooper wrote: > While the reset value of the register is 0, it might not be after kexec/etc. > If PKEY0.{WD,AD} have leaked in from an earlier context, construction of a PV > dom0 will explode. > > Sequencing wise, this must come after setting CR4.PKE, and before we touch any > user mappings. > > Signed-off-by: Andrew Cooper > --- > CC: Jan Beulich > CC: Roger Pau Monné > CC: Wei Liu > > For sequencing, it could also come after setting XCR0.PKRU too, but then we'd > need to construct an empty XSAVE area to XRSTOR from, and that would be even > more horrible to arrange. That would be ugly for other reasons as well, I think. > --- a/xen/arch/x86/cpu/common.c > +++ b/xen/arch/x86/cpu/common.c > @@ -936,6 +936,9 @@ void cpu_init(void) > write_debugreg(6, X86_DR6_DEFAULT); > write_debugreg(7, X86_DR7_DEFAULT); > > + if (cpu_has_pku) > + wrpkru(0); What about the BSP during S3 resume? Shouldn't we play safe there too, just in case? Jan From xen-devel-bounces@lists.xenproject.org Thu Jan 12 12:58:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 12:58:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476138.738153 (Exim 4.92) (envelope-from ) id 1pFx9q-0003n2-Kw; Thu, 12 Jan 2023 12:58:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476138.738153; Thu, 12 Jan 2023 12:58:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFx9q-0003mv-IH; Thu, 12 Jan 2023 12:58:14 +0000 Received: by outflank-mailman (input) for mailman id 476138; Thu, 12 Jan 2023 12:58:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFx9o-0003mp-Hv for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 12:58:12 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2085.outbound.protection.outlook.com [40.107.21.85]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c4736321-9278-11ed-91b6-6bf2151ebd3b; Thu, 12 Jan 2023 13:58:11 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8841.eurprd04.prod.outlook.com (2603:10a6:20b:408::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.19; Thu, 12 Jan 2023 12:58:08 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Thu, 12 Jan 2023 12:58:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c4736321-9278-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oFMYx3rn7wtE7mWuxpi/794htkqQyjJ0vlySlU2qcRTcQJ4FxyNljbMp0E8GS//SQ/y5JAReoJk72WmrjI60I+ZSxVZOPp4lWCns5H2rac63B/kWIENwIMhiU2ghWne59gp+1IpJYS0878JbKnLP6Ba6bXwnXCesCtznfyVd65j3Ufy57lqpiefwaUEGUxnG+Qbn9CL9FE6AdKh6QcCoS3SbwQVnsc1b5v/MK+CJdnbxLTsv/HiqdXZbpASNT7WrNI66qlJqYdoK34sL952pL4LYjkmssevxidDcTuIm4beN9qQJ2AwUywzM9a9QM1l+DtMs9G5i4LvDijWLZFezHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=D26GuqKYX6gPt9im9t3yBAAtCPZw3qa90PikQLoD9uQ=; b=H6U9yEeQFWjs+9MBoUe84yf70a98Q/oYuuEWdYR0HdzejNJVQYMJe+CRkyMJ8wOvEUohg99QRr1Mv0VOee61AhX1CRh12JANJ53FCDepBWkEcufXwwqda4//Q2GYrfDZd0oyGuMYv43Gd3+5vfRMIICY5MQInB0hJYWxrOm57yymKCteQUJT/e45ohmLBOwOiWJKAGU9uW64+6WKc//fAlvarSMuRYZGoq5CCELZNEH2akE9NboXzXbM9es+g+bKql3EZL+LfBw6uJ5Zv4C6La/vnsXN5Zfesr3O+w5gD/v2uGGSKRthjZMf/4VfhM+lZpsH0UlMB9s9pe+yzCDNfg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D26GuqKYX6gPt9im9t3yBAAtCPZw3qa90PikQLoD9uQ=; b=ryFLB0Bo1ntp1y1U565RyrjJ5IqHj/2mphcHaoBE2pd6s18ufHkqpZ22jmukQTi8nhxABb/QwpXOub2FnaOTFI+3k0WOC7oXGF9XDtqom5d1ba7I3f0JcxP47EB1SoW/FupB+6pM2xrkwk0PTxA9T7pLfLSi4YwO+YI33KfxvuuiRE+HFc6cOJmRxVx2QbqMmvcPzdWG5nvhLmcQtglpSUFHN1W2sxs/5QnUEzLxqcRbIxSLn5GDYRl7vTym+436CVDCqmgrHftUGq1VdVamDfVD+vROgsoiaeW+TXoaKhC1i7cV8Px6n1PNasmfEYSbOrzQ5Oya3PAXpX4kgNyA0A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <97d16968-57fa-0114-1a93-4d0d253b8172@suse.com> Date: Thu, 12 Jan 2023 13:58:05 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 4/8] x86: Initial support for WRMSRNS Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230110171845.20542-1-andrew.cooper3@citrix.com> <20230110171845.20542-5-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20230110171845.20542-5-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0006.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8841:EE_ X-MS-Office365-Filtering-Correlation-Id: bf3dde32-d52d-4efc-d948-08daf49ca6f0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PYwl/QHIzmTdQ/YuEuvYtyOi+bVzyWBcA81SFXmYdUuBdhbsPtBASTxY+oXCRGxaaOdx6QRN3AEX/iGoS3Shw+10ywdaJ1OE/YSlmFp7+ljqxCv6wuPi+X2/TNr5pYuaplhxDWYbPpzI6PdHEBZZ1zAV+j4yMtgb1EMtdx4BtKXf0Mg1UfuPWw79jKQksG+22opAVmdtT1TIkihOS17BedFfedTRl4YwjB3mffeSVi2jPLEpudfNSsEwt3wSa7fYHH5eMpXSKbwc0FTedk4Qr6ETIZC+m9sN4pLyzT87NKLjRNu/cjZ+MM9O9f7DZpoEePiXtXk7n7cJV4fMV0cOqzvoaSofdMS+bAfiN5tQ/bmLVEyS5hv4g4JpwhxcTjuRa8rHC5IuccHCLCKH4PgAZ4yolk3J5VPCzQqaTJ3Q1/PWgcFGJahd1tlg1IG2SzW6nn9pdJ/BPCZ3+jFnZnQiPpX0P56FION/8glCOJDE3SzQa9feC79OtRzQKC9xdzM8eTbtexUO2m117sBAz0sB2dqPJacy3SktBr4XqNkSJb1zGjAv2W2DUAG2D53D3z93nWBB0sDz59wYbT6TcHXGu2caI4DFvesAImVX3LjCHKMcEkqemXcpu8GPxYQoMDVhTDWTBUyZ367walNloyA7DnLVY3oLBaBcmCnoZpP1Tyeh7TNxowv0bwvoevEsfiqG7IB32PE1caS5luT9ufc70S8ayojeOtSf5joczeMOAKA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(39860400002)(396003)(366004)(136003)(376002)(451199015)(6512007)(186003)(31686004)(478600001)(26005)(66476007)(66946007)(53546011)(316002)(66556008)(6666004)(54906003)(2616005)(6506007)(8676002)(6916009)(4326008)(6486002)(38100700002)(8936002)(5660300002)(41300700001)(86362001)(83380400001)(31696002)(36756003)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MDlhYjBveEtBWE5BbDg5cC9GY2cxczVSSVUxU3RpMy8xNHNGalE2bW5naWRt?= =?utf-8?B?TVdZR1B2MTdHbzBxMkR5MVArU0RCeVZtVVVwc0NEWjZ1S2h1RnV1MS9BWU8v?= =?utf-8?B?clZNeHZvdXFSZis1TnJ4eWhkNWNVRVRzc0RZcHBVS1R2R1l4UXk1aTRtU2xF?= =?utf-8?B?Qzk0ZXcrQnVzY2tteTVheGhBQTlrUWhSVXpXODA4Um1WaHhpVDRJNk1GRmtV?= =?utf-8?B?V2dHdEhkc0QveHdJQm1nWGtjVk5UZmVMQWZkMnpZMlpPcW5sTFZsUUozb2kz?= =?utf-8?B?UjZ6OWlaOG0yZ3BablM5VWtuTy9wT0p2MUx1Z05XTUdPU1diR3FuNXYzajNa?= =?utf-8?B?WE5pZTdGRzI4bFY2eDZJdy9FQUVaUTNFcjdHVzY3VDNQeWM4QXFvYTNlYTFC?= =?utf-8?B?UlZQbDdpTHkxdVphWXRmVGFZRk5iRjd3dzFjTTRlTXBuUUY4OXpLL2YwaDBr?= =?utf-8?B?Y0wzbUpOUis2RWFnd0NIVi9YeCtJcnMwNlNUQUhNNWJLS25sMVNRM0dBL0Rq?= =?utf-8?B?T25vZ1BDMXlBalBNOUtoeUl0QWZoYTJuN1dXZDB3SHZnQ2NxVmkyTnVZeldl?= =?utf-8?B?dzZCQlN1ZlJGOXlrVG4vRnFmYTA2ejF0NVBzWEZQeVZiN2FQazFEaURxdmlO?= =?utf-8?B?VFlsczd0ZHVnSEM2aEJnNEEzOG9DRXBrVml2Zi9OZlVocjMrVFZyalFYd3c2?= =?utf-8?B?Yk5ZeTRYOU5scC8vQ01TL0g3Y3ZTbUNkZWhiUkxUajRxUm9vVFlhQ3B6VEhC?= =?utf-8?B?UUF2RFZ3Y2hzL0tGc3JWSjZtN0RkR3RITStac2tPUmQ2Wk54SWZncjllVXM5?= =?utf-8?B?bnZ5Wll3MkJUTjltaW51WUs1NXd5MEE3VnZuQkc5Q0RLeVBPV2licW84TEp3?= =?utf-8?B?MGFxYW9QMlcrVll3YmJWa1orTGFMV0hOWEQvb3VSUkhhZlZaUk4wS0QxMTRP?= =?utf-8?B?VHo5VFNZNzE5US9CYWFldG1sNVFaajVYZlZ0YjNXU1RYN0RZOE5jVCtsZDli?= =?utf-8?B?Y3cwNnlZaUFnUW5xYmJBUHB3MVEvVklhLzdmekNURll3K3l4RXBQVmRzNnpV?= =?utf-8?B?NFIrZW1OZWtlUEd4aytUYW4vdy9OcE0yRktjUlpxMWdVZmNCdURFSEFZTXZr?= =?utf-8?B?NGtFMFNUMFFaeHlWanh1cWwwVGMxWHczNzJOek96SFFiL3RwK2lQQW1BTWk2?= =?utf-8?B?cE02eWhvY0hvSUdCQWovc2hqaXM1WlF1Nk9UOHJOQ2J6S3g0aWYvTUpzWWph?= =?utf-8?B?c0ZZR2ZFV0RNSnZxWkY1bkZMQjlqNkI0eEE5Y2x5SG9CK1g4dEc2Q3pydEFK?= =?utf-8?B?N0NpMVZkWS9icFJVZTR5WDJuanJ1K205RVNoYzIzL0duV0JpUHE5SmpQMGFB?= =?utf-8?B?T1prR2NneUV6dVU3UnN5UTlYWktUei82Q05Vamp0ejNIaDhOVi9Da1p0ZGtF?= =?utf-8?B?Uktxc3YzaDJsRFIxY0RFY0RubjQwZCs4WGkwNC8zZDA0NXN4cnlYQlcyWFVk?= =?utf-8?B?ZXRjd0ZmNHo0NXp6UklEYUt3RUI1cEh5b1dCMWNraFdOV1ZYMFVDcFRsQ2NJ?= =?utf-8?B?Q1JkNWE5WktiOVBYRFNTMm4rMDJDWURCdFJzREI4dnpwQURJMHFtQ3pDbTFt?= =?utf-8?B?MmdvM25mbDl1dDRFaDlZVzBvMFBZT3JwRUlWdWxaOWVvKzB0d25CTFg0VmFn?= =?utf-8?B?SVlSTjEwSGxUOHpVSWpBNDdRdmJWR3NodXZxNnBQNHR0ajF1UHlLUys3cmhJ?= =?utf-8?B?ZXZVVEozOHhVMUQ0WG15VlY0YnFocFlrVTE4NGh6eTlMOXRjNFNkdkdLSXNH?= =?utf-8?B?c1l6WjlnTVlVWXk3eHQ3cUovc3lZc2V4dVAvNDdENzJyWG9Cc016dVppdm82?= =?utf-8?B?b1U0aFZCSnhib1RTNUUzMkVwbElEd0dWd21FQWFmZ3FuN1pmcXVSVTI0TGVJ?= =?utf-8?B?M0t3SlBCTU4wakFXcnU3bnFsSWwwUjY1QTRIclJGS0lRdWdEdUdZcm1pbkhs?= =?utf-8?B?dk5qaTdqSTRrN25LWCthM2NMZlFMZStJeW9HbEhsT2RnRjdxQndnaVJ5bi9X?= =?utf-8?B?OW5pMFhIMXc2SWhOMC81ek8wWjFDQjZEY01EMXBzbzF3dTIwc3VSaThOYmpH?= =?utf-8?Q?cN8EZRgs4tDEQNCDd6DhXXfSH?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: bf3dde32-d52d-4efc-d948-08daf49ca6f0 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 12:58:08.6254 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OizL/KZwFk0fTX27Bk3LG5sj7lWZ6O4wkAD/5M84DaafQRLShKDGaic/F+AZfKbrtFWswOmku5eqfeI7u7X55g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8841 On 10.01.2023 18:18, Andrew Cooper wrote: > WRMSR Non-Serialising is an optimisation intended for cases where an MSR needs > updating, but architectural serialising properties are not needed. > > In is anticipated that this will apply to most if not all MSRs modified on > context switch paths. > > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich This will allow me to drop half of what the respective emulator patch consists of, which I'm yet to post (but which in turn is sitting on top of many other already posted emulator patches). Comparing with that patch, one nit though: > --- a/tools/misc/xen-cpuid.c > +++ b/tools/misc/xen-cpuid.c > @@ -189,6 +189,7 @@ static const char *const str_7a1[32] = > > [10] = "fzrm", [11] = "fsrs", > [12] = "fsrcs", > + /* 18 */ [19] = "wrmsrns", > }; We commonly leave a blank line to indicate dis-contiguous entries. > --- a/xen/arch/x86/include/asm/msr.h > +++ b/xen/arch/x86/include/asm/msr.h > @@ -38,6 +38,18 @@ static inline void wrmsrl(unsigned int msr, __u64 val) > wrmsr(msr, lo, hi); > } > > +/* Non-serialising WRMSR, when available. Falls back to a serialising WRMSR. */ > +static inline void wrmsr_ns(uint32_t msr, uint32_t lo, uint32_t hi) > +{ > + /* > + * WRMSR is 2 bytes. WRMSRNS is 3 bytes. Pad WRMSR with a redundant CS > + * prefix to avoid a trailing NOP. > + */ > + alternative_input(".byte 0x2e; wrmsr", > + ".byte 0x0f,0x01,0xc6", X86_FEATURE_WRMSRNS, > + "c" (msr), "a" (lo), "d" (hi)); > +} No wrmsrl_ns() and/or wrmsr_ns_safe() variants right away? Do you have any indications towards a CS prefix being the least risky one to use here (or in general)? Recognizing that segment prefixes have gained alternative meaning in certain contexts, I would otherwise wonder whether an address or operand size prefix wouldn't be more suitable. Jan From xen-devel-bounces@lists.xenproject.org Thu Jan 12 13:11:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 13:11:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476145.738165 (Exim 4.92) (envelope-from ) id 1pFxMM-0006Nd-SU; Thu, 12 Jan 2023 13:11:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476145.738165; Thu, 12 Jan 2023 13:11:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFxMM-0006NW-Pg; Thu, 12 Jan 2023 13:11:10 +0000 Received: by outflank-mailman (input) for mailman id 476145; Thu, 12 Jan 2023 13:11:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFxML-0006NQ-SJ for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 13:11:09 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2046.outbound.protection.outlook.com [40.107.22.46]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8fd9a662-927a-11ed-b8d0-410ff93cb8f0; Thu, 12 Jan 2023 14:11:01 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU0PR04MB9322.eurprd04.prod.outlook.com (2603:10a6:10:355::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Thu, 12 Jan 2023 13:10:59 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Thu, 12 Jan 2023 13:10:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8fd9a662-927a-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DsEj8FBMnPzSm+X7RHzWq9Ui07w5qduz2StPOet9pvZeYATGdqrYqcdd2ajcDp/RN3zmRL7sRO91eu+RzgsJCeILCF9CDv1g7ohRxL3jC+V2X3LyYD5zWvGmoW3wN7AfCm0yp0QrDTft5Yx6fTHFMiUL4KREQYVU9G7Ilgc7sa8IGYDcpAqv6BXX+fiy9OEgObmaeXPN0nHsnHUn2CwVQqYASJzEFYJgzOoPZJcQJAGCxct2Uek4hVeNlTUkacS7dskik4bf3CVTknEEYDlWjXYlwdT7qvmnn5lj3+8GfV3PV5O6NTRR5aVfuv4pWGF57FcsABxJBFMOdkDiWTRAMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Y8pvCEsvK9DpiCgrrDOLt2avq5yLrFutttlavfM94sM=; b=ejICGx2iUpleIm22rl3I8wReweV4VPHxr8y7hbifV2jVNHYBKIiwRoWKGWdqnOHf7574Hv5lnydXtHSLSe0bYqYkb+P71Ae4tmHgbqiO1gQA+tvPO8WBrEBAi/Dw/f0yb+uZZCRxH+Hif4M/Zb72xFvZv17yRHEsr4fAV7GjBzVDe1kHtSuSdcQSrntebGcf8QDHIyMrtZLVm3sTq5Nnwk1aH/xGneb9nvByt91GtxBTrPjCGfsHh20AnDApDN3akjTB2XyNIuDjOoaHdlKxUrAWJk2zhYPvgvLjmB6w6cOROAfiDi93fQBq6145mcs39lgSFGLYkHdofngNSLldfg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y8pvCEsvK9DpiCgrrDOLt2avq5yLrFutttlavfM94sM=; b=LMegPTetlWDlGmug1H9BtNzMomCE9PVRL08RkmupY7y3BemrPLRiVPbPLWgXvdBweGuSS7kbsDySEUMbqhuZ9xEgB3EhK2rQN8JV7jFf2JQ243yHgeZxOGNtNqy/WTXLTgMoFu4BkmBGeSCCzbnc+MVMBI1cj5yYUiFxKsVtNou2mOTsi1lsVvd9ot0C3y02s1ERcizppBxA8b8ZIfRn4Sc03C//G1MClUJcVrRQnkt4KxEylFOMTgptJupkUIr6TX9JJDWViCARk4YUeP2bvArQAFFiHlhbUIisaYk9jVgcIh0IjXWLDiCSyhouy2vo2zywCgWnN4Mqq6mUJE3epA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 12 Jan 2023 14:10:57 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 5/8] x86/hvm: Context switch MSR_PKRS Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Kevin Tian , Xen-devel References: <20230110171845.20542-1-andrew.cooper3@citrix.com> <20230110171845.20542-6-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20230110171845.20542-6-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0054.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU0PR04MB9322:EE_ X-MS-Office365-Filtering-Correlation-Id: 32d6084f-7bd5-462b-cc0b-08daf49e72bb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YjNWOzP9YMJRrJDrbSyr4UiC1qbgX1Rh45W1uPLWzHm0zhwsADHJUzX1PwbDRCF1EujubJZZmEDeXVrIHD5dj4lro3xDb6bIsJonEXOKl90U3I0uz8p+bwXN8mSKBB6ddVipDozgynY3/nq05xix4jR8xpTDBoJPs0RzRqIPBZNMf6+EwVZe/LtBulo4Veua/tnXRyy72XypcMvg0PR2DGMtze5wsiJQdyOfzq0BHxZDQLDCPdAWXZJqKEymOPdZqyFccFDb+IKAiYtuSVTnyNxzV8BY7Q4b8g2ZR+9SJko88iEOgYlI5DcTXhxur8RIFjLWfm+hJDkvWBnDGu8Oivbt/KGk/BfMA+v8aCkF38T+IyiCnE9FGZ7iOEmxPpwIViOsxm+WiEmWXKfxzBxMlxPNlUzcKcbdt9HqxxksM3xwvf1/xEpkDH2+1JHOpekLoy2aiUWQT1SU8/Ds5ehjD4NKr4BiD4akDIcW6CF9UGmIcNMOggba52qPDVN5YncEqVswHq56bGB5fqyUO43zuwtmnGOMcW5TYBTOmx3TvjaqQQymjYO7dzB8wO2j/pbwIFMPIHGQC9TcL1+Wir8HjGu+g1HSH6UtgJbxLqpoKDtfMDPk9S/1t1DuQtVcPS7dYeOsDsKvLMBKY8k54C5trn5xhZZnqD42y5KWTCr8JFEB68QtaJFrsZcFdTiZ4MZlPQrF4L8oCfR+BXXvDLECWM8M6TL0rjKcKHIzViw4g3s= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(39860400002)(396003)(136003)(376002)(346002)(451199015)(53546011)(31686004)(2906002)(6506007)(6486002)(26005)(478600001)(6512007)(186003)(8676002)(83380400001)(2616005)(66946007)(36756003)(54906003)(316002)(66556008)(66476007)(6916009)(4326008)(41300700001)(38100700002)(31696002)(86362001)(8936002)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SlgvTTEzOEZxcHFXTnNhZU1qWmVCcXZmSFJzOWNsdmJhU2hzS1h2dzIzMEtO?= =?utf-8?B?OUEybXFLb2xBZTZ6ZzlhOGlSc2tnUXdOUEVtYnJYYTF3UTFmdWFNQlJxNXJW?= =?utf-8?B?UEIxd2dsWEZ6Vi9aaTFhR1lKUzhqaVdmSkZTT1A4SWZXazRHWndLU1FjdHVK?= =?utf-8?B?Wms5QVpJQjByWGdUZ0pPbW5pMC9KUzQrdVpEM2IrcURta1hOaDZ1TUVaL3Nq?= =?utf-8?B?YkJEanZ5OWhLdEVaeFdXTU9Wam9XSGtvTkdSMFFrVzlucVFzSEpXTnQrVUZN?= =?utf-8?B?Unl3R21qZTNYTWJXQit6QU9KVFh2eGhVeXV3K2hISnA0c2xZcG96ZTFneW5I?= =?utf-8?B?VVdRd0dvc0NPQUhkdUhXVkIyUyszVUpJQ0JZUzNZUlhaaDZUL3dBdnBGbGRL?= =?utf-8?B?SmFDbkJ5ZWtxL2F0YytFQXpCVG11WFVIRVpyK2ZUdjAzd1BhbXRqTkNJSHBp?= =?utf-8?B?U0tUTm8zRVpDZkNhdnZodmRTRkpuc0oySDV3WDhrVi9aMEFyUVNQOFBsUWp0?= =?utf-8?B?NnRmeldjUzB5MmJqVldjRG0vNnZzZmZjVnI5dWt3OVF6Wk5RencwYWdnL0Rm?= =?utf-8?B?ZlIvTHllblJsT0xTT1pyMFgrMW94YTF1TkFwMWtlMnNsNG4yK1c3cnFicldO?= =?utf-8?B?Z0JpSUpTNCtrQUhFNFptbmNxVXhuQ3pXVjlPN1MyUFB3RVBDUW4wQjVJc29j?= =?utf-8?B?WUxKVnJ4NjhXb1ZqcmxmNVE2U2RYdkpORjhvdHVsYllCVThWVW1OeUw5NVBX?= =?utf-8?B?U0lYZ0pmYUhxRW1yakUxeDRUb3FvTjYrOGt0aFpmZmZlV09md3J5eEduOVJk?= =?utf-8?B?K2dCdTFNcmVmNi9yVmRUNlZBYWhFNVFyNE1nOVpSblZhNitKU0xoc3gyUEZk?= =?utf-8?B?OG03ZERQQnZmdXNZbGFPbXIrN1JBSWNOQkhUQnBadVFncy9yQlpFV29Kcml2?= =?utf-8?B?SVJMWFlvQkttRDVlMVFBWVQwTnVQekpacnZOSnhBSjcveEhvOGhhQ0pyOUpj?= =?utf-8?B?MTNGcjB3c2Flb2VwMmNyK2R3TTh4S09IUVZtRjNoemZ3aXpoeTYwR2c4bzc1?= =?utf-8?B?NEVWOTZjaXlsLzFOM0NRVkhBdkJwdzNxSEtZeXJZL0Q5bTM4YWN0MENRL0p4?= =?utf-8?B?QWZkRk5oKzRkV1FyZ3NYeFlvMVhSTTJzYnM4cVpTYWY3Tk5ZcUpTQTdSdUVH?= =?utf-8?B?L2NoS0xUYU5oc2tLWStSOVc5ZGtmN1h6cS9RMFZIVnQzd3lRaHlBSnRHNll2?= =?utf-8?B?ZkdiQjV2anhWQnZGZ1RWYXc5QXVMQTd5TSs1OTFUQ3Y5Ky84MVB1Nll3QVhh?= =?utf-8?B?bmljdHhqOVRFaHJmWS90QUYyUDV5QUZJaWlmMHFrdzVmSkZ2RCtHY2dtNFIv?= =?utf-8?B?bG10RS9UNGpzZURoeUdEa2RrOUZUQ2ZIK1Q2d2Vqc1V1cUJOVnFZRnBJWWdw?= =?utf-8?B?cENLN2lLMi9YVEloWkV2cnQxaVZjNklDS054R1VucTM5T1RyanRMYm8rYmdy?= =?utf-8?B?a2ZUNzloV1h5UW5JN0cwR1lVRmtyT251anZ2N2pwck5zWHBpQ3gxUEVnaXcz?= =?utf-8?B?ekc1ZFBNeHRpeTJVRjVteCtLbUZ6eHV4TWFZNmRLU3pvdlY5bEpnRk0rZGFw?= =?utf-8?B?Z2hSNUtuMWwzbnFMYjFTY1J4Q0QvNGk0SnVDcnJ0bGZaSFoxOW9aMXJ3MVpC?= =?utf-8?B?VTlLTDhrbUoxbzNVWkRoU2Z4TExVaEZtVUQ5ME5jWEJpWWd1cmpXTCszMHVR?= =?utf-8?B?Sk9ubGV2SUI1L1FvZllRTHNUWno2ek9NWkZydHNmTXJmdzB2Nkk5K1FzbWVL?= =?utf-8?B?ZC9UMjVmb0ZOc1EyL3MyV2t4L0Y0NXFIWjk2aU5Fa2hpbkVGNjZWdHpLNitO?= =?utf-8?B?UWlZRkhmM3pzRFQ2NmdENkdNdDlMOEVWVHNPOGRzVm5DZk1zQVkvRThldS9t?= =?utf-8?B?ZDdiUnlhYzRhSVMxU3RnVEVnbTZQaTRPOTAzc3ZRK20yYXk0UFJMQVRad2ZZ?= =?utf-8?B?elo3NHF1RWpGRno0ODBpL21VeUt6RDRPQ28xaUxSRTZZQ1lJNEFXcVZjTVpx?= =?utf-8?B?Qit5WFJGcm5Qd1NJZWZVTk5PSkJUeFgrTFMxSGxHUUxjbStBYktnOXg5Wno2?= =?utf-8?Q?+O+wBWq2EsQQeHLbxD70lX/KJ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 32d6084f-7bd5-462b-cc0b-08daf49e72bb X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 13:10:59.4672 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Pi7mg7qTRKVFM+6T2EL1e/u7UxBwOkPFXZqO+7y2WsHZ9uWeG4hylSKW1ty9WAEqzemQIeHzCuwoD1+yDM/agA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9322 On 10.01.2023 18:18, Andrew Cooper wrote: > +static inline void wrpkrs(uint32_t pkrs) > +{ > + uint32_t *this_pkrs = &this_cpu(pkrs); > + > + if ( *this_pkrs != pkrs ) > + { > + *this_pkrs = pkrs; > + > + wrmsr_ns(MSR_PKRS, pkrs, 0); > + } > +} > + > +static inline void wrpkrs_and_cache(uint32_t pkrs) > +{ > + this_cpu(pkrs) = pkrs; > + wrmsr_ns(MSR_PKRS, pkrs, 0); > +} Just to confirm - there's no anticipation of uses of this in async contexts, i.e. there's no concern about the ordering of cache vs hardware writes? > --- a/xen/arch/x86/setup.c > +++ b/xen/arch/x86/setup.c > @@ -54,6 +54,7 @@ > #include > #include > #include > +#include > #include > > /* opt_nosmp: If true, secondary processors are ignored. */ > @@ -1804,6 +1805,9 @@ void __init noreturn __start_xen(unsigned long mbi_p) > if ( opt_invpcid && cpu_has_invpcid ) > use_invpcid = true; > > + if ( cpu_has_pks ) > + wrpkrs_and_cache(0); /* Must be before setting CR4.PKS */ Same question here as for PKRU wrt the BSP during S3 resume. Jan From xen-devel-bounces@lists.xenproject.org Thu Jan 12 13:26:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 13:26:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476151.738176 (Exim 4.92) (envelope-from ) id 1pFxbJ-0008AA-7U; Thu, 12 Jan 2023 13:26:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476151.738176; Thu, 12 Jan 2023 13:26:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFxbJ-0008A3-4j; Thu, 12 Jan 2023 13:26:37 +0000 Received: by outflank-mailman (input) for mailman id 476151; Thu, 12 Jan 2023 13:26:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFxbI-00089u-CK for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 13:26:36 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2084.outbound.protection.outlook.com [40.107.104.84]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bbeee11e-927c-11ed-91b6-6bf2151ebd3b; Thu, 12 Jan 2023 14:26:34 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8988.eurprd04.prod.outlook.com (2603:10a6:20b:40b::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.12; Thu, 12 Jan 2023 13:26:32 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Thu, 12 Jan 2023 13:26:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bbeee11e-927c-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PIxgZpukXDuuEhe/KP2JHX7ZArgrhbQ5xGGRtJ2Dk4bUEJIkAdusV5++PK4DeE0CwSfw0VTHh7JdwNBgzI768ZP7TTXniFAaUP3l5VianpM16VplY2Iy3uVSc3RnfftvzjTn+88I2UTALCgrj7ad6vK2U8gTjjP8gPBDLGStbZc1cTollKPs9rHjbymkbEwsstLoVKxDUKyYABxskZcDrwfzqLRAlxNr4RssXlKf71g9kxT60x8eCWju+TnSaIGNGu782b1g6NSSd7BeuXiFoCnhFCV097iMwoglmX1rWA2mDiDh7cbhHWaE87GkvHFxFGVm/8nPCunzWDdl6w3tcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hH7GRJMJLboLqQxfrRCU7JHmsgaKy1telQ3E6ETmio0=; b=g00V5ZNpwNG69VkcoIYGvUStRUXt0OvuIY46caJpHof0em34B4GfvR6VS7aMeSbd/aaGHJeRR5v1wExTVoSVkOC+yV1NiJs51lMOwofb/nLWnKb/NphLR0ZOi364j0QGffyMJvAJxwVo4ZBtdJqGJ9H2pt75wJwKyZ0rmIyvQLG4RnEUlETy8L1IR26a7mJXahX4Q+g7iMJq4dDKX0nQsAbkq7ohn2Yqd51FcPE6CGuPZycENcWBt2WL8/0fcYga/JzPxCBUBL1v/24SmbKYmQKEVwsb8TsX3XooxanGgZpv7nC40Hn8buvbZ0N2Vkr0sZgvOzonCtyOus0egr+G6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hH7GRJMJLboLqQxfrRCU7JHmsgaKy1telQ3E6ETmio0=; b=ADP+3Gi6h4pkTQbne3+Wdo56xlqncPdciOW7iNPGt8ab2ZoqCBiisHemY6WspMshPFrGY4mqFX5WWCVFCNvXPciGEbX2DXLCIvHKL4apAQQTJfmnYkXlstqJpcLklHkMOVO9BcPvS/8PL21z2RsDxyo2qAXKVrhNOY2bD89lpSeL1HEdKDH48TWb5wx42Le43BbryG6EwCcxsSKAg5A1SMzjiq/0qyz157wEhBRLwvvz2MzIAKrZZYo26Z8kz5quVZtoYoweUca3+9TN4dJjFEytw7McLJlZZAWWMOtuEfLpmg9Lqi8mWf7pxGS1y641mDgen5ubs1FpFJQTUNiIsw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 12 Jan 2023 14:26:30 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 6/8] x86/hvm: Enable guest access to MSR_PKRS Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Kevin Tian , Xen-devel References: <20230110171845.20542-1-andrew.cooper3@citrix.com> <20230110171845.20542-7-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20230110171845.20542-7-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0054.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:93::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8988:EE_ X-MS-Office365-Filtering-Correlation-Id: 59f23e35-1ada-4d3c-ed19-08daf4a09eeb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zAWqc9lnWdCTfSXrYR2lg4mlVBCZONCcIhmc3n6gRPmZk2LT9yXeJqLfsuebKqo25rTUnHQIxB53y8d99cXF6tVKAi1pM1z4nnYL9xEenZv3W3yKXGEyttnQ/qYMAiGJnWiF5UUVzC5dZ/i92Gt5kKR+JHa8XrOMz944c4/3G92JJ8DMVV3rkO0hi1SpC7eFUX9ijkuD0ftm5BSqOKponpb2KNvn2COxeD1IbR8DbTP4nZYdZB0lyGFNWRbUcMArIZtiwDofFM5hAoh0M5T7uMY2d7ZhlLNQD6vgj2kbG8QpnyUXnUVsvBedmK0oqM0gPEa/2nxz57bHYBa2k19ld7aNowBpVci9Dqw54BK7CsEdvsbXVjJjSH2olsfOWu+uah3Hqa9Dj/wObvuxTsM3pcZh32ixrKpJKfJFx94Rak3Q49wjnyomTmaEYw7cCDyOgEXTk8tJDJKC/mju8Qmd3wOjg3iZV2An4v/2bTkWRecKrdJX6Ip9zXTAaLU9/eG9A/RldMmLH7QNVL/MPOMMhTXgwLZx93HsMDvokFq7FEESJJvgvLbt49UGnycYENUni3mBE5nZ6+ng7kXGCMJlYJASabBsHTQNC5va3Y7Bwoq8ohvU6OG9Mqn10hE9jO04Wnd8rSXOM1sjk23yDqgWvU2unugTJD8VmdC+1OKjk+9g1q3gC9wZZXWzliOlXYbBD+9yKUktTxMD2OGB+G/ivYjwC2wK9JLZ10EHzKB9muY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(136003)(366004)(396003)(39860400002)(346002)(451199015)(8936002)(5660300002)(83380400001)(41300700001)(38100700002)(86362001)(36756003)(2906002)(31696002)(6486002)(478600001)(31686004)(26005)(186003)(6512007)(6506007)(8676002)(6916009)(4326008)(66476007)(66946007)(66556008)(316002)(53546011)(2616005)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VUI1WFVqa29qLzRlYVVXTDFmVk9nRy9qS2M1MGo4RkVLOFR6KzBIVGZuYmNU?= =?utf-8?B?bnQxWndpR1F6LzVnYVlQbHlvWjZhMUovY0sxSGd2WWI3Vkxmc21GV3pwMUpl?= =?utf-8?B?UG81VkRUdzdVbnl2a09QajFkT0w2Y2cvSng0dHVwNmNvQWJKK1pTZzJvK2hs?= =?utf-8?B?TDVRUHAxMUhKcWhPcXRHdW9SNUdKdjk5WkNuRE5PTDRjWXhBOEN3aHhyZjY4?= =?utf-8?B?TE1HRmZocFUzQ3JDSEZlYWYwdlhmUGZlemltM3RIcXZESmM0Z0Q1UjlzWS9u?= =?utf-8?B?RmczSkR6SjhGNUxHdE1IOXY0MDdWbUM4NkxsRi96NTZod1djZzRvNXZUY2Jw?= =?utf-8?B?RnlmQkYxN3NOd3FoK01XSjl1NmFEY3BXVUNUSEpKQ2czbUdHWFdpQnl2ZmRN?= =?utf-8?B?VXNJanNTYTVhS0F4WkZad3dBMXhDRFpURTk5WmRZbDhtMlJ4MDdoUGVpWGtO?= =?utf-8?B?a2JDamtWTm51am9HUmRVREZmZ3JwT3lhUk5FYTNxT2FzNzV3MjRLZHVER2pu?= =?utf-8?B?U3MzL3JRRVd4N0IyWG5HL0MvTFlGMzlMd1lJWWQzekZLcllIQzJLKzRUY0s2?= =?utf-8?B?OTBLaVgyOWg0SjBhRVEyK2ZnSWxSWmZFckZkUkFJVmpScUd1RGJWZmdCOUpC?= =?utf-8?B?anlKTTMrbk5ZSE1ZQ3FUV3Rxa29ubzQ2eDdnNTlUaHBwVHk5MG5hM1h3cHFz?= =?utf-8?B?czA1K0tPdVVXejlIQmJpVEVuVUtkNnpFMGhhVldldGEwcUNXR09wYnhiL0Uz?= =?utf-8?B?M1ZCOGtobDFlYno4dnNvL0FMSjk5NVBUMERCc1FDRHQ2b01jY2tDeEtPZlRp?= =?utf-8?B?SmpWVlY4d254SkI3L0J3dkpLNVpHblFHVzJ2d2tmKy9wUmlnZ2VpNVN5b1Fo?= =?utf-8?B?clJ4S2JBYTdZd21CMTJTYlpyYkNNR0FtSHhJZVRkSlJKblV4NjBKL0hrSUhR?= =?utf-8?B?L3FpclZETFdVNm9mWUNpV3N0a0kxUVBxS3g4cFVpYmNITFVkaXVDR1B0cnlT?= =?utf-8?B?bWdlcGVFdGVpK01CNUxROTMzYmN6QzM1NW1uY1l1ZlZvdHBucElBcGF3Mzdn?= =?utf-8?B?alNmR2s4eGJvUDdiWE92bWN3ZGxMakR3Y1JlQzBMcGpNVGRYL3ZUbWdRSXhh?= =?utf-8?B?UGdCOHJOMFF3SzA4OE54NlpIY1J6cUxhQ3Z0YUErRThUcGZmS3IxSE9qODIy?= =?utf-8?B?YzhnVTlHajVUNjBUZGhmbHEzTVFYNGN1eCtzaGhGSTllVGJLV0lWeUlqU1lR?= =?utf-8?B?SDc0TCtFRDVtYUVXNXFONDNjWk9uWkUwWWthTFRnSGRLR215Ris2NEs3QXIw?= =?utf-8?B?UTdES1ViOFFxUzhsVy9OcHR2d0gvZFo1MUIzdmVOOE1rT3hGY29ubTZsSXpZ?= =?utf-8?B?Z3ZRRjZ3N1lTdEtnL3NWSnJZdGJwZ0szcEZPVnR3NVNTdk5xWG5jZEFpWS9W?= =?utf-8?B?bTk2T1Z6OXJLTjQ3SVFnY0NvK3pzVGZubGduVEc1QkZFcDJ6TG05VGxEUnVv?= =?utf-8?B?SFRtTzRIbnRMVzd1eGc0OXFoSFlYZXhHdHZlTm11MlBqd0Izc0VmMXBwTWJi?= =?utf-8?B?WlFqaUkzdzFpa2NMMmhNM3lBdEQ4SUpsdTNvZ09sQWFiRFhFUCttLzhyWUhK?= =?utf-8?B?TUVvWTIveWtXSFB5RGJ6WVU4TXlGbU1KMk1ucTdTRzNKOStVNU5FNHZWN1lX?= =?utf-8?B?K3I4Rm1WOEVUemdFbnNmK1p5RFNIbXV3VC9GcmYzUXVKWnhZNmIyUDZabkM2?= =?utf-8?B?VEVNV0E2N3MzS3d0WG9OMHFETmx3WlN2SzdLZ003NUt0WFNqaExLaEIyWWdX?= =?utf-8?B?WUp2RWlEc3VCNmEzRHNQRk5zZk1SU3ZiQmxUaUVBTUh5dHhJMzQvZURzeFVR?= =?utf-8?B?TjB5NzNCR042M2tHZkV3eStjZ2xIT1pXUFNldjZmWElyQ1p2SFBmSVZDMjkx?= =?utf-8?B?UEEydFJuMkdjd0dkN2kwTll5b3NQREpjcnNqMkFXR1oyTlQyc3FjNnh5Q1ZW?= =?utf-8?B?OEF5NVJBOTdnaFh3ZnF3WWt0VTFKMmV5d2hjdXQ3NXFXQ0c3RWtYeEI0SmEx?= =?utf-8?B?ZmI0WXFTdHg1SHpnUlFNZFdjNDR0bFJOU2JWZkplVEc2bzJCNHZ3WEJEc1dX?= =?utf-8?Q?0x5aiYaq4tlYOh8IVTNljmkhN?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 59f23e35-1ada-4d3c-ed19-08daf4a09eeb X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 13:26:32.6271 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: i0CiWlnBcHvK/2ZpkbpERTqgOW/F8XJWihxCP9Au+m2zv/asqsQdLRloshM5ev2egCn3XNAtleapekkEXv8pNA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8988 On 10.01.2023 18:18, Andrew Cooper wrote: > @@ -2471,6 +2477,9 @@ static uint64_t cf_check vmx_get_reg(struct vcpu *v, unsigned int reg) > } > return val; > > + case MSR_PKRS: > + return (v == curr) ? rdpkrs() : msrs->pkrs; Nothing here or ... > @@ -2514,6 +2525,12 @@ static void cf_check vmx_set_reg(struct vcpu *v, unsigned int reg, uint64_t val) > domain_crash(d); > } > return; > + > + case MSR_PKRS: > + msrs->pkrs = val; > + if ( v == curr ) > + wrpkrs(val); > + return; ... here is VMX or (if we were to support it, just as a abstract consideration) HVM specific. Which makes me wonder why this needs handling in [gs]et_reg() in the first place. I guess I'm still not fully in sync with your longer term plans here ... The other thing I'd like to understand (and having an answer to this would have been better before re-applying my R-b to this re-based logic) is towards the lack of feature checks here. hvm_get_reg() can be called from other than guest_rdmsr(), for an example see arch_get_info_guest(). Jan From xen-devel-bounces@lists.xenproject.org Thu Jan 12 13:28:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 13:28:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476156.738187 (Exim 4.92) (envelope-from ) id 1pFxcj-0000Iq-I3; Thu, 12 Jan 2023 13:28:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476156.738187; Thu, 12 Jan 2023 13:28:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFxcj-0000Ij-F5; Thu, 12 Jan 2023 13:28:05 +0000 Received: by outflank-mailman (input) for mailman id 476156; Thu, 12 Jan 2023 13:28:04 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFxci-0000IQ-4c; Thu, 12 Jan 2023 13:28:04 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFxci-0000om-1K; Thu, 12 Jan 2023 13:28:04 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFxch-0003oJ-Fs; Thu, 12 Jan 2023 13:28:03 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pFxch-0007gQ-Ek; Thu, 12 Jan 2023 13:28:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=SwXz0FbOvNhOoAQ+5vWVqeZXEPq5SZ4ZLKYge5CJdto=; b=KGgfIj31HHXW8/q5U96WY6xfH6 0y0VXk+HNzQe1CUMdkDnEZO7QWfORlJC1L7XR1Z3/0J4yUvDBwzx20D4gXa0ufZGy+tJrDljXfb5W rF9eiC54YxjMUCo+bQ/wWPlJJsWhhtGYBExX1SdtK2RvGxRSxL2B4zqgbFuvzsEaAv/c=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 175735: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression qemu-mainline:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-i386-pair:xen-install/src_host:fail:heisenbug qemu-mainline:test-amd64-i386-pair:xen-install/dst_host:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=aa96ab7c9df59c615ca82b49c9062819e0a1c287 X-Osstest-Versions-That: qemuu=0ab12aa32462817f0a53fa6f6ce4baf664ef1713 From: osstest service owner Date: Thu, 12 Jan 2023 13:28:03 +0000 flight 175735 qemu-mainline real [real] flight 175742 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/175735/ http://logs.test-lab.xenproject.org/osstest/logs/175742/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 175623 test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail REGR. vs. 175623 Tests which are failing intermittently (not blocking): test-amd64-i386-pair 10 xen-install/src_host fail in 175742 pass in 175735 test-amd64-i386-pair 11 xen-install/dst_host fail pass in 175742-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 175623 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 175623 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175623 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175623 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 175623 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 175623 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175623 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175623 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu aa96ab7c9df59c615ca82b49c9062819e0a1c287 baseline version: qemuu 0ab12aa32462817f0a53fa6f6ce4baf664ef1713 Last test of basis 175623 2023-01-07 23:09:00 Z 4 days Failing since 175627 2023-01-08 14:40:14 Z 3 days 20 attempts Testing same since 175654 2023-01-09 18:08:58 Z 2 days 15 attempts ------------------------------------------------------------ People who touched revisions under test: Ard Biesheuvel Bernhard Beschow Christian Borntraeger Cindy Lu Dongli Zhang Eugenio Pérez Greg Kurz Guoyi Tu Hyman Huang(黄勇) Igor Mammedov Jason Wang Jonathan Cameron Kai Huang Laszlo Ersek Lei Xiang leixiang Liuxiangdong Longpeng Lubomir Rintel Marc-André Lureau Markus Armbruster Michael S. Tsirkin Nikita Ivanov Paolo Bonzini Peter Maydell Philippe Mathieu-Daudé Richard Henderson Thomas Huth Yanan Wang Yicong Yang Zeng Chi jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2556 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Jan 12 13:59:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 13:59:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476167.738200 (Exim 4.92) (envelope-from ) id 1pFy6c-000411-3J; Thu, 12 Jan 2023 13:58:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476167.738200; Thu, 12 Jan 2023 13:58:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFy6c-00040u-0c; Thu, 12 Jan 2023 13:58:58 +0000 Received: by outflank-mailman (input) for mailman id 476167; Thu, 12 Jan 2023 13:58:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFy6a-00040Y-QW for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 13:58:57 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3ded505e-9281-11ed-b8d0-410ff93cb8f0; Thu, 12 Jan 2023 14:58:52 +0100 (CET) Received: from mail-dm6nam11lp2171.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.171]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 12 Jan 2023 08:58:42 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BN8PR03MB5025.namprd03.prod.outlook.com (2603:10b6:408:dd::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.19; Thu, 12 Jan 2023 13:58:41 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5986.018; Thu, 12 Jan 2023 13:58:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3ded505e-9281-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1673531932; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=7y/UBF+/73haNmuu4jeuUM3NbyULZc1Ow6fxxc0jvlQ=; b=JOoaUGlLHIBYxZNNZdn6asoJHzwA33jgR2y/qUH1zB7ZZBIStRt0Y0wl aeEPcI14KVGuBE0PyY51rST3mO+A+dmQt7rk1kKyajcQCPLiPJC1Ik88a qQQ+zrpGo2gDeLAr91Hsp0BhctTck/abxSr2vVL7hY398QhkrvNbEqphX c=; X-IronPort-RemoteIP: 104.47.57.171 X-IronPort-MID: 91241997 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:F6R47aP8zWUuQebvrR2HlsFynXyQoLVcMsEvi/4bfWQNrUon3jRVy WtNUWmFaKqIZ2Lyeox1YIWz/B9VuMDXnINkQQto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQA+KmU4YoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9Suv3rRC9H5qyo42tB5wZmP5ingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0t4mCG1np PYAFCIQQBuHq6Hv5IKVdtA506zPLOGzVG8ekldJ6GiASNoDH9XESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+PVxujeKpOBy+OGF3N79U9qGX8hK2G2fo XrL5T/RCRAGLt2PjzGC9xpAg8eexHmnAdNDS9VU8NZQigev1Hc6CCcSbkOFnejmsGq7UfxQf hl8Fi0G6PJaGFaQZtv3UgC8oXWElgUBQNcWGOo/gCmSzoLE7gDfAXILJhZRZdpjuMIoSDgC0 l6Sg8ivFTFpqKeSS3+W6vGTtzzaBMQOBWoLZCtBQQ5b5dDm+dg3lkiWEY8lF7OphNroHz222 yqNsCU1m7QUi4gMyrm/+lfExTmro/AlUzII2+keZUr9hisRWWJvT9bABYTzhRqYELukcw== IronPort-HdrOrdr: A9a23:qIGhUKz1pVRtdp5GHM7MKrPw871zdoMgy1knxilNoHxuH/Bw8P re+MjztCWE7Qr5PUtLpTnuAsa9qB/nm6KdgrNhX4tKPjOHhILAFugLgbcKqweKJ8SUzJ8/6U 4PSclD4N2bNykBsS75ijPIburJw7O8gdyVbf+19QYLcenzAZsQlDuQDGygYytLrFkvP+tBKH KEjPA33wadRQ== X-IronPort-AV: E=Sophos;i="5.97,211,1669093200"; d="scan'208";a="91241997" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gyneM/E16kIodQQew1AbITyMCEB5ShL9Ub9MRJq86C8g76UVJ08xfBC0uw/VCkrwaIHg0e03EoJrmtAbzUGiwxgnoBkBlvDwej7hNPRoYBheloYDppjotmzFfMJ49v6QenTK+4MLHrFUlgR6gSIiv475nntFmVMhh2biwDQhbxBvKgFnOYNRlFqPIxaTvtn2bFYw/G1oyCh1Kx5Ot4vSh/pCSm1CmUXVA42h2c5liyl7vJRxcXnK8Iz6Srk0pEgMZilYuimS8h3dbqLu6BM46pWY8ZHGbFn7SHoh35cbQNjBawhIEDqjod5wo8S2Gdjp3KCuMYn5a3ofzwdGv/GsXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7y/UBF+/73haNmuu4jeuUM3NbyULZc1Ow6fxxc0jvlQ=; b=mQKOOCTiUhEDjJkLRKJLQMg56v5Pu+bpnHiOGS2K45kvHSP3gAFIpirC8en1mUTSJ6VFrQmwVDSnB9z3IWUhsCDYrXlyVAz/47fIcvqIYCyvTENyFldKylHHoIR4HY6vgOVL048R2cusxaFQW7iTNvxyaiydLjOhDKZNJVDvSnQzRRJ9Mm8k4YpoAmt5xAkVf9C+/EvEM2h57QtcS4rBEeFXtH/DrIUbo+S/EpJ3cLMC1vd4r4YGqCdv1FmqOFiCNgItMnZh1fE7aNVSIvw71bkG/a4TqB+rpnh1dlydDsTX5Y4zmBYA4y4vI7Wpf4uBmJdC8Nzv4FR8qJIA8VSnjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7y/UBF+/73haNmuu4jeuUM3NbyULZc1Ow6fxxc0jvlQ=; b=vmyyQQeRg/8dilEtmqyqVe1zmxR3avoXtz27AqcKDDakZ2ywUJDMT0IhA3GsqEzO72q1hJQrzqlidxcbTP6QNE2XE4wj67HbmSNv1T4V6mpW8iqXm2Tw/l6FhBqzh+0L9ldeGUxPyozor94j+JLgmzUph5RaPM/poUZ80/9cDtM= From: Andrew Cooper To: Jan Beulich CC: Roger Pau Monne , Wei Liu , Xen-devel Subject: Re: [PATCH v2 4/8] x86: Initial support for WRMSRNS Thread-Topic: [PATCH v2 4/8] x86: Initial support for WRMSRNS Thread-Index: AQHZJRefYU5gP8dknEybN3m0hZOPA66awNaAgAAQ7QA= Date: Thu, 12 Jan 2023 13:58:40 +0000 Message-ID: <2e568a8d-02d6-5761-8b55-c37a8de1be0e@citrix.com> References: <20230110171845.20542-1-andrew.cooper3@citrix.com> <20230110171845.20542-5-andrew.cooper3@citrix.com> <97d16968-57fa-0114-1a93-4d0d253b8172@suse.com> In-Reply-To: <97d16968-57fa-0114-1a93-4d0d253b8172@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|BN8PR03MB5025:EE_ x-ms-office365-filtering-correlation-id: d84b2e79-3fee-48de-1e5f-08daf4a51c64 x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: sJwdSiTxwobm9lzJHiumNbgNfWH6hDOni/WR7A4jLqJz1FJl8kMJ8JaFTBU0XNm1gx67TPjcFG6mcKNekTjMCORddMSPYWwZiDJC+BEAWj8RsLxWCbswqULCrPefKtN2jZXzIaHpfcR/W/ewEEz2b7ApNtNDDsGBiN2o1W0Khl7Bgy4OOLgCVgvW4YISxt//FQUGgTXb4cAF3gKVnhqsjQvyf43zDzPdJMv65o1OWtEtjsXJ9BAqCFW4hRG/GSH4q1OWaKH6LtyXnoSWURN2rmpi0O8GFPAsaWFBKz3MmjqSvMlpMdSJigGtdFwQM3eTEfghBgGfr+uXA7Y57XZ/BnsXrTvy8//tuX+RE+IefT2MA5H3mReC9jt0T7razaj+C4pl/Ht92HV3DviGCCsbODt1TbRVYJb6IExRRhIVG2ZTL6tLVvIHsXk+wa6SL1QG2ilFRVfFYCfjR4YxG5qy+fXYOKBxX7y1TYRW3EG1LtpYzEVCtVar0iORy74UQuBIl15/DjimqPObnw1aIZBkkoiruLIcg9D9QnnN1B2pbDN2j0vKWg0IDHdP3MiyCgeFp98z4RsEXBnKQ7ojD3Hq377Sm04IgaNKWMIauLsAQS2/hbJE1FjNdUw8Qoi5xqRvGeG52uM+onGYSpPW4JkEyTGb8rfLk1EQZ7FbJCXzPSDgutNG7+DYin7oU9MbLM2rVy2SQP7xTQBMMeFW76XeIys3HxIdyOMzYe3zDUka3zXU60305wz04UUYbxFxPJkNL0jRfOnb8/FeYYdIUrN4nw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(136003)(366004)(39860400002)(346002)(451199015)(8936002)(5660300002)(83380400001)(41300700001)(86362001)(38100700002)(82960400001)(122000001)(36756003)(38070700005)(2906002)(31696002)(478600001)(31686004)(26005)(186003)(6512007)(71200400001)(6506007)(6486002)(91956017)(8676002)(6916009)(64756008)(4326008)(76116006)(66476007)(66946007)(53546011)(316002)(66556008)(66446008)(2616005)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SHRNZzVvT0gwOHRrMURFOTMvaGlHNHlJbXJvRWVyVHBIOHlueHBJVUYySk9O?= =?utf-8?B?RWNwTS9vWW13dSsyMFVvZGZCYW5JVzBRVTdjRlVGakEwVWY4YXFPb3JDbkhS?= =?utf-8?B?UGVwdjhJelFmeUtqWS9xVmM2Z3pIS3Bzdnk1aWljUzQrWWdHVEt0QmtWc05s?= =?utf-8?B?ZGJzNmJMNmsxTFl6TzJJLzNrMUg0MjgweWxoaDA2b1NIeTA0OEVMMDlhejA3?= =?utf-8?B?eDBaRDFxWUV1bHFiMDFnQkIwWDZwSFhUbHNXNUZKM0p1UGhudWlhbmp0eERG?= =?utf-8?B?SVpkd0dIcjVEdHRYUXlGTTNUZ3NKNE1MVW9nS3p0TVNhNlN5V1pwZlg0VE9U?= =?utf-8?B?YS93Z2dkMHpUNUZ5ZTZSYmtqenl4WkFHdnRudUxTU3hsb0luVjhDRGZDa2M2?= =?utf-8?B?Sm1pOWowK0FrVk03aVFHZFBPblRLaGUrdmVDYXYxTXFRTWlVVWRGSnp0dmgx?= =?utf-8?B?cUovUjBZVURaZXYybDJEVEZvKzh5RU51WkFqWU52T3o5M3U3VUxTWGh5OE1z?= =?utf-8?B?cDAya0tMd3hPaWYrNm5CZVUwTlUyUG4xdFkrd1AyR2w2ank1cmx4aVpLeFdW?= =?utf-8?B?c29CRU8wZ0M3aW1yNUR0NW44TWczbjVUU0NqM1RSSEhuOGpxWmlWbDdxRmoz?= =?utf-8?B?MUQwYnc3UHh6ZWxXK2hLSzBzMWQ4MFZvWGlMeHVhVXdSbW5hbzBRckVrZi9q?= =?utf-8?B?RUtWanp1dVJLeDA0VThpUmJ2dit5UEp2RFhNaHFsOTl6UWJ2MjhOeWs5dWpw?= =?utf-8?B?MlhjdFVMNGgwcjVCelNpckVtUDdMNG1TNTQ4QmIxb2lTWndPK2xwVnhkS0tE?= =?utf-8?B?MmtORE51bHV5OUo1NlBPeDRkckpTb2w3ZVJiY1l0Q3duYk5SdjkxQ0lHSHRa?= =?utf-8?B?MmZ2Ly9JU0VLRVF0ZENjWTR5eGlubnVtOXlqRmx3Q2cyRTlaRmZiZWgxdnhp?= =?utf-8?B?Y21YeWJUMitCaDQrOHRPd0tXb1RNd0RXZ0ZWbkJXYkNtVkxWSFNhZ1JZMGJZ?= =?utf-8?B?bkpsMGl3ZzQyUU5rc2ozZjZkRWY4Mno0bUVYUnFWZmEvNFNrSlRjQ09JclEz?= =?utf-8?B?aDRUeUlBRXVQT1p1NmZ2aHNDOHV4dW9ZWmVHU2lRdzRYMjVkT2hBSGpwUlhu?= =?utf-8?B?dmw4bmJZSHpqL01TekwrbDVZTE4xWENmU1RjMTI4Uk1MY2ZCcVNLTGRaYUJk?= =?utf-8?B?RFk4b2ZBT2d4a2JWUnNNa3FGNFZpTmFLVVZBZ0dCd1p1QTJaZ3QxcWJBKzRp?= =?utf-8?B?ZE0xbVhxOFBWazZES053S2VSZG5kVHJYSGJJUXdOckRCSkZhR3FZRVltcytN?= =?utf-8?B?eGRTV1l3VmlYbnB0c1ArRnh3QTZwbWtCbGJuV2VjSWhzM1ZxZExLSVJ6dlk2?= =?utf-8?B?RUJ4Mm5FZk11V0pPM3RFUjB1QTVBQThpc1c4ZHlrMDBoeUZOY0s0eDNpWHpG?= =?utf-8?B?OElQbDhybGRpQy90SGlTb0hCa2tlNTlsTFkxME5TckpvQ1hCOUxRb0l5Ri92?= =?utf-8?B?a1MyYmNQN25SNXVIL2dVanZkYS84RzEvaWtiL2F0UmJBSjRIZ3VKK1VtemNX?= =?utf-8?B?aGtrYUVPTjBnMlVqeDZJM1M3OS9TR2hKUXlvN3JzcWlnSWZaQVhqTTBwWi9j?= =?utf-8?B?WnRBOEZIRCs3T0ZCaitmalBlaFVmZWFuREFZYm1wM2dZaEl1OUdTQS8zS2hk?= =?utf-8?B?cXhvM3JXYkRadWErZHZRaTg0Qi9SYzc0b1ZKdDRCNTYwTTRhbFhka0pQU2s0?= =?utf-8?B?cXRJRTBZQlJwSVZFZjYydEIvcVdubkFBemd6bVNuMGRLY1dsV29wSzUzaGcy?= =?utf-8?B?bWtGV2FidW81TVgvWnlKK1ByVHA2NTZScHE1ZE5vZG5VRDhEZUFWNFpQSVhF?= =?utf-8?B?Z1JmbjBuMWp4dDJnSUEvRm90Nm5wdStOVTl5Yko0TlZFNFhobnRLajZ2OXdX?= =?utf-8?B?N1Z2VXhveDltSUpUOGtXRjhvTk5mMFF5OTlmcFVoakFWNVRFREZaeEVpV0Jx?= =?utf-8?B?QWNXTERrb2FhWDFmTVpaTEtvT0puY1FXNzhYdmVCV0VPSkgrSHJJclhORVhC?= =?utf-8?B?Mng4QVBORnNWb3VEMXJsdzZ2azIxakVWc3hMSTllNjI5a3JpTGRRZzJyR1Fn?= =?utf-8?B?dk5FTEwxUVB0bUFLb2FveFoyN0RTcWkyaVRmdHRvNzRvbGJIZWtxcXZSWkNS?= =?utf-8?B?QkE9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: O2r9A88FXUoL9rckE2jDDLrn7EKAerBklpUssImVG2eh5XoD5/lCOyLUMFJPVkKUPKICGPfHotx5DRTj+qI9cuepu2HWe7EZTXRHvaw32i+yaEUbje9dthMagIHcKJe2+VF8sVN5dk3yRj45fSIm37b/tgHkmvatKMUf25bjvvKfa629EavvY17rZPoGprDM/plOiyDKl/qfV1gMPYTofqVM/qdKi7cIoX/ZGd/0wJc/GcKfFvi64+W31nqWNY1L221D57URg1oGALoHZ3oJeIZ/b8Sk0TTBKc3H+isYr2yX74t2e8u3+oxEZ6N6kMn6XknihB2vSSxK7MVXHdHeJ5X93G6h03CTwhQ9IvWw/LtoYVNhIaESxTvo/nUoQCcFPR/sogUE2+cT/GZkqNJ5g9LRQag7jnJr2j5hGC/E9am+WfWH/iT7EAAxU+3EKEq40+G5S+0CCLOBCaiz0mNW8YxTwF5Z0dIE+V3BZyDRzOt16WhJb1ztybrIvsCeqRbL4sD9XQCAZGbw+d5U/fqnmi7KHhYzWrpCPkP15BMPlJl1REfzRyJ5b4kyM3GzG4HtfP6hiYb3rUoAgZUK02bp7ZnRlPkYE3qR846luNJ/ApEIWkNZsrX/4Pjwln+L39159ONaSKeXZvDeMLO39qq+XcDYSyCQb6mf1Idj2Js1lxjcvWOiuWjAwZX/168SRmXjF2yPUHksH7H5HvPavA+JjYTqbjN5ddV5b6HSoS9Ers+/8z7XWdWxAnTtPhTJgmYGxx/elIXeeF4O4U77wyJDZg8Y7IlmNqTNkIjmF2Rz9bnLrqY9K75/s+CNXnfUWR3V X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d84b2e79-3fee-48de-1e5f-08daf4a51c64 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jan 2023 13:58:40.8982 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3o8hyJJPdi16K8unOx+q3sOII2IMmoUDtTU9/GFem9b91Ri1Nnxkd2Jw1JPhcgn57tyUTl5njAzFkanZr9oqNmGnxhkTHOqs8CJ9nUlJpuk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB5025 T24gMTIvMDEvMjAyMyAxMjo1OCBwbSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDEwLjAxLjIw MjMgMTg6MTgsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBXUk1TUiBOb24tU2VyaWFsaXNpbmcg aXMgYW4gb3B0aW1pc2F0aW9uIGludGVuZGVkIGZvciBjYXNlcyB3aGVyZSBhbiBNU1IgbmVlZHMN Cj4+IHVwZGF0aW5nLCBidXQgYXJjaGl0ZWN0dXJhbCBzZXJpYWxpc2luZyBwcm9wZXJ0aWVzIGFy ZSBub3QgbmVlZGVkLg0KPj4NCj4+IEluIGlzIGFudGljaXBhdGVkIHRoYXQgdGhpcyB3aWxsIGFw cGx5IHRvIG1vc3QgaWYgbm90IGFsbCBNU1JzIG1vZGlmaWVkIG9uDQo+PiBjb250ZXh0IHN3aXRj aCBwYXRocy4NCj4+DQo+PiBTaWduZWQtb2ZmLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29v cGVyM0BjaXRyaXguY29tPg0KPiBSZXZpZXdlZC1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1 c2UuY29tPg0KPg0KPiBUaGlzIHdpbGwgYWxsb3cgbWUgdG8gZHJvcCBoYWxmIG9mIHdoYXQgdGhl IHJlc3BlY3RpdmUgZW11bGF0b3IgcGF0Y2gNCj4gY29uc2lzdHMgb2YsIHdoaWNoIEknbSB5ZXQg dG8gcG9zdCAoYnV0IHdoaWNoIGluIHR1cm4gaXMgc2l0dGluZyBvbg0KPiB0b3Agb2YgbWFueSBv dGhlciBhbHJlYWR5IHBvc3RlZCBlbXVsYXRvciBwYXRjaGVzKS4gQ29tcGFyaW5nIHdpdGgNCj4g dGhhdCBwYXRjaCwgb25lIG5pdCB0aG91Z2g6DQoNCkkgZGlkIHdvbmRlciBpZiB5b3UgaGFkIHNv bWUgc3R1ZmYgcXVldWVkIHVwLsKgIEkgZG8gbmVlZCB0byBnZXQgYmFjayB0bw0KcmV2aWV3aW5n Lg0KDQo+DQo+PiAtLS0gYS90b29scy9taXNjL3hlbi1jcHVpZC5jDQo+PiArKysgYi90b29scy9t aXNjL3hlbi1jcHVpZC5jDQo+PiBAQCAtMTg5LDYgKzE4OSw3IEBAIHN0YXRpYyBjb25zdCBjaGFy ICpjb25zdCBzdHJfN2ExWzMyXSA9DQo+PiAgDQo+PiAgICAgIFsxMF0gPSAiZnpybSIsICAgICAg ICAgIFsxMV0gPSAiZnNycyIsDQo+PiAgICAgIFsxMl0gPSAiZnNyY3MiLA0KPj4gKyAgICAvKiAx OCAqLyAgICAgICAgICAgICAgICBbMTldID0gIndybXNybnMiLA0KPj4gIH07DQo+IFdlIGNvbW1v bmx5IGxlYXZlIGEgYmxhbmsgbGluZSB0byBpbmRpY2F0ZSBkaXMtY29udGlndW91cyBlbnRyaWVz Lg0KDQpPb3BzIHllcy7CoCBXaWxsIGZpeC4NCg0KPg0KPj4gLS0tIGEveGVuL2FyY2gveDg2L2lu Y2x1ZGUvYXNtL21zci5oDQo+PiArKysgYi94ZW4vYXJjaC94ODYvaW5jbHVkZS9hc20vbXNyLmgN Cj4+IEBAIC0zOCw2ICszOCwxOCBAQCBzdGF0aWMgaW5saW5lIHZvaWQgd3Jtc3JsKHVuc2lnbmVk IGludCBtc3IsIF9fdTY0IHZhbCkNCj4+ICAgICAgICAgIHdybXNyKG1zciwgbG8sIGhpKTsNCj4+ ICB9DQo+PiAgDQo+PiArLyogTm9uLXNlcmlhbGlzaW5nIFdSTVNSLCB3aGVuIGF2YWlsYWJsZS4g IEZhbGxzIGJhY2sgdG8gYSBzZXJpYWxpc2luZyBXUk1TUi4gKi8NCj4+ICtzdGF0aWMgaW5saW5l IHZvaWQgd3Jtc3JfbnModWludDMyX3QgbXNyLCB1aW50MzJfdCBsbywgdWludDMyX3QgaGkpDQo+ PiArew0KPj4gKyAgICAvKg0KPj4gKyAgICAgKiBXUk1TUiBpcyAyIGJ5dGVzLiAgV1JNU1JOUyBp cyAzIGJ5dGVzLiAgUGFkIFdSTVNSIHdpdGggYSByZWR1bmRhbnQgQ1MNCj4+ICsgICAgICogcHJl Zml4IHRvIGF2b2lkIGEgdHJhaWxpbmcgTk9QLg0KPj4gKyAgICAgKi8NCj4+ICsgICAgYWx0ZXJu YXRpdmVfaW5wdXQoIi5ieXRlIDB4MmU7IHdybXNyIiwNCj4+ICsgICAgICAgICAgICAgICAgICAg ICAgIi5ieXRlIDB4MGYsMHgwMSwweGM2IiwgWDg2X0ZFQVRVUkVfV1JNU1JOUywNCj4+ICsgICAg ICAgICAgICAgICAgICAgICAgImMiIChtc3IpLCAiYSIgKGxvKSwgImQiIChoaSkpOw0KPj4gK30N Cj4gTm8gd3Jtc3JsX25zKCkgYW5kL29yIHdybXNyX25zX3NhZmUoKSB2YXJpYW50cyByaWdodCBh d2F5Pw0KDQpJIHN0aWxsIGhhdmUgYSBicmFuY2ggY2xlYW5pbmcgdXAgTVNSIGhhbmRsaW5nLCB3 aGljaCBoYXMgYmVlbiBwZW5kaW5nDQpzaW5jZSB0aGUgTmFuamluZyBYZW5TdW1taXQsIHdoaWNo IG1ha2VzIHNvbWUgb2YgdGhvc2UgZGlzYXBwZWFyLg0KDQpCdXQgbm8gLSBJIHdhc24ndCBwbGFu bmluZyB0byBpbnRyb2R1Y2UgaGVscGVycyBhaGVhZCBvZiB0aGVtIGJlaW5nIG5lZWRlZC4NCg0K PiBEbyB5b3UgaGF2ZSBhbnkgaW5kaWNhdGlvbnMgdG93YXJkcyBhIENTIHByZWZpeCBiZWluZyB0 aGUgbGVhc3Qgcmlza3kNCj4gb25lIHRvIHVzZSBoZXJlIChvciBpbiBnZW5lcmFsKT8NCg0KWWVz Lg0KDQpSZW1lbWJlciBpdCdzIHRoZSBwcmVmaXggcmVjb21tZW5kZWQgZm9yLCBhbmQgdXNlZCBi eSwNCi1tYnJhbmNoZXMtd2l0aGluLTMyQi1ib3VuZGFyaWVzIHRvIHdvcmsgYXJvdW5kIHRoZSBT a3lsYWtlIGptcCBlcnJhdGEuDQoNCkFuZCBiYXNlZCBvbiB0aGlzIGp1c3RpZmljYXRpb24sIGl0 cyBhbHNvIHRoZSBwcmVmaXggd2UgdXNlIGZvciBwYWRkaW5nDQpvbiB2YXJpb3VzIGptcC9jYWxs J3MgZm9yIHJldHBvbGluZSBpbmxpbmluZyBwdXJwb3Nlcy4NCg0KfkFuZHJldw0K From xen-devel-bounces@lists.xenproject.org Thu Jan 12 14:01:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 14:01:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476173.738212 (Exim 4.92) (envelope-from ) id 1pFy99-0005Si-He; Thu, 12 Jan 2023 14:01:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476173.738212; Thu, 12 Jan 2023 14:01:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFy99-0005Sb-EB; Thu, 12 Jan 2023 14:01:35 +0000 Received: by outflank-mailman (input) for mailman id 476173; Thu, 12 Jan 2023 14:01:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFy97-0005ST-Ce for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 14:01:33 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2054.outbound.protection.outlook.com [40.107.249.54]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9e238e7c-9281-11ed-91b6-6bf2151ebd3b; Thu, 12 Jan 2023 15:01:32 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8537.eurprd04.prod.outlook.com (2603:10a6:20b:434::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.19; Thu, 12 Jan 2023 14:01:30 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Thu, 12 Jan 2023 14:01:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9e238e7c-9281-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j4TDR/EjdVzfF8gJg0EwKmIRx9k81maO44+S6RcKj1t3j2StYeyE1iT2Yvpk1kCyjW40YZEbUXfZ4hbbOppJUle9ZaBj2e6J7pTqKQtog0C0Qu1Ir+5xOzkwb7ChH9QPU2WprvITr1gdkUcgarlQT1PWQmOu92r/lAJFfIrpqSlhHScSPXGtYoGuQBnELh8gO46M1fAqV4eiLxBfeeUAlr+l5C1Xe//+HNzmd34ZRLEXbYEUf+AjB0sLMI8/BXfHLM+TjDTJB6yT3grUcfktouxnFrhrLYNukROYxNgm2CZ2EOLiE5WdiZZLFkVizWSMQVhw1i2D2gyKM6bl++KP/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fJjRH7h1ZjdWbrus5g79m3fp7lbTH6/IpDJ5Io/pxKM=; b=AWtY/kf6gOv0a8lqD+5AbBSayEOxxh9yffB+smNLJmYACkhhR8NE5RirPRTKN6Pgbij7tIyJnWHystLIskD+gtZWsfX+500csi+L+SJvIe/kd/esfX5+xmMgbnCvTV+GB95u/67WG4C3bgbx+ZW6Yx+BFcpD6/Pyy/YzOuTWs2XDTcNg7O62ZTVWFYOZKfAR/G5D4F2wojXX3RVay7ppRJhB5RAFqxTViPwtLVIigGN/Ubxq95r+T50vvfVEu8za5ILlnfGljY+Sdm+GgjDrolgdWKKtvsHDTb08NEfEdutDqgCXfvcCHQdyp+htQKj6dHblNcoWLHQ0pkircfpy2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fJjRH7h1ZjdWbrus5g79m3fp7lbTH6/IpDJ5Io/pxKM=; b=jbdShx4+n1bDwLTGX3IcqKaBTFI5zYaOMvghJo+3nxm+1GJTosbmWPLBycfjl+tgjddA+u/mjQn5KdsLnpU0LTDyU39NfCXSQkhtlt9tjpzNbih/PojPt7yb2olTApEggukO9TsfmzsFWXnlHBw5gv/Tf3taWHLXnlMDLdAYbFy3oyPVvFluQ4YpJtA9UtG6XnK3Rx4XXpEEs7X9BGS9HUEyi130A+EthdWOxoQRlTOrGy4vySpvoXJbRCXI32/wiDIRz/Bo4i6s8FihjJsQX61yHfXYkP5oNz/f3ljcrYuJLDxqS8xwU7AUJpLCEGHdqhIwmFOMABb0+fEI0mESIg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5a0a9e2a-c116-21b5-8081-db75fe4178d7@suse.com> Date: Thu, 12 Jan 2023 15:01:27 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Bertrand Marquis , Volodymyr Babchuk From: Jan Beulich Subject: [PATCH] include/types: move stdlib.h-kind types to common header Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0078.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8537:EE_ X-MS-Office365-Filtering-Correlation-Id: 174b2b5e-88b0-4110-edfd-08daf4a58132 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2Ix20JLXTC4lsH0nmgDqIrtyB3WuTv/6nuvTkNJn1AavHsz7DnII/YuzWCn1X3JAsDE+taojlV4kUnWBPCtkS3B4f8aPgXoTldp33Z1VRI51uMCaie69kp2iXyBwg9LTWSRFIzMCRUntZZrdXw+XDiMjfBrd17vStQKquITjCpIPY49xH5A8V2wfhUuRPeDzzQl+KAPEECCJzvtptdBi1+n6yk77TopEjkUoDdbzmCiuyaJaPSHzg3BYG+8g6QT6ktk0Q/qKWUyrYxMMht7+R+X984w4KDqtaRIiYJYXYpNyh3r8Zhdeig1pSImOQkK7uAXTOS7VZOaCBnA2wnhc1ApbvqXYdVUMhNCT+CJq+P93CvTk0Ms9MAQbV5VQiAHqQd1CeoB6RL8z2/DUI10xT+TpvJRhMErFghKR6uRd45/Y5G6VARihsl++youmO84XnvQ9QjRutquQWEC0/IHb5t3JsG2jyymwkbi7WRBp0YMMZVstmjhhplBeRhB1zAE9DXFPHpnXT7XLPKLMzJchC/G9A39S8xv8MG6HlXayVG95MRjcU3sTsLPfo6CSWtzvYqlo6HssGUUhNJzkbFgQRqfr9rvDDK/rzskn9wW2EqN3EHe9B2s4lndMEMp8Yi6GnIx2gp1v15cVwtT+rmGLK9X4fMpN+e9MIAySTSNEFPMKsVlaP2mDZi7cFd3p4lpMyvhxAnXYKOQZCqbRHvAZlk99m5AURS+bnRTRgCM3tUA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(376002)(136003)(366004)(39860400002)(346002)(451199015)(8936002)(5660300002)(41300700001)(86362001)(38100700002)(36756003)(2906002)(31696002)(6486002)(478600001)(31686004)(26005)(186003)(6512007)(6506007)(8676002)(6916009)(4326008)(66476007)(66946007)(316002)(66556008)(2616005)(54906003)(6666004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VU9zU2pWR0xqYlBoZEU2dS9XNDhDUWMyMjFHdEVPdjdybjhnYVdURDE1SXFu?= =?utf-8?B?amdreVAxWWFTMXovdjVoN1RnZjNxRWkrdkd2dGdpOGovdHNKdFJhdnVJa0xC?= =?utf-8?B?REZUaTFTbzNqT1pHZ2hheGxpSVBiMEh0T29sQ2c1KytQSDRlblF6Y0MzUXQx?= =?utf-8?B?VnI0blkwbTFXVDZxQkFCalVJcFJFenRuTXkzSEs2dXpDb3A4SXhBc25ZZEdU?= =?utf-8?B?ejRsNE5CeUtLNUJ2dXpyMWVib0V5cXZ1UlN6RlRFNFdXeE15N3ZTOFFEc2pV?= =?utf-8?B?MGpuZkdNVmpaeHlWQjRmVWdPTlgxamdxenF1SUt6bWtGZUVTcC9Sc3h1alZM?= =?utf-8?B?K21VeUJsNjA3a0M3K1lMVmF4NmJPVXowUGR4alhwRWhZaGlKVHFISkRDcFNr?= =?utf-8?B?VzE0OW9LN1B0MnJTSGRDTUhpdWN1ck5IU0lYSWtEeWwxUDB5QkQremFrUVN4?= =?utf-8?B?UU05Z3hFZnFNejZjenNIQnVvcDZxczBoQXN5amVUOEl5ajhaNytQVldicWF2?= =?utf-8?B?WXlVeXQ2cXg3R2NXTGNtVlFFYVNKQkdYSWtFazc2UzdreUdZZGdsS1JtaDFa?= =?utf-8?B?eVdxdmNwRzNtOUhiTktQMjBJdXErYnlLV0pVa0tPQjY1eFdaK29kWGhCMEh6?= =?utf-8?B?UkI4Rm5QNTRlQWdxMVZkM1MzQVBTTDcwVDdyQjdQUHlvRmxLN2VHMVNGcDli?= =?utf-8?B?amlEcG5qODJHdC9VYzk4VWx0aXI4dUd4U0FkT09XTWxSdkZQcVJqM3VOTUdB?= =?utf-8?B?WHFsM0VZNnEybzBobVV2eVM3OGxjejRWZkl4ODFhNC9Ta0I4S2R5VGpLek5j?= =?utf-8?B?bkc5dlY3MFBucUFlcnozbUN2aGIzMkxxOG5JRjdBM3c3L1doNnk5b1FjVjlV?= =?utf-8?B?UGlURko5cUlRRmliMEF6R3lpR09BQVB5MlVwR0R2L3ZGZU5MK0tvb1ErWEIx?= =?utf-8?B?Y1pBTStFa0FKUndjaUJNcnpoMlRqYmppSTVQY2ZhQWJlU28yUjlkNDhza3pI?= =?utf-8?B?VG1sWEd3MENCLzU5bCtGeEZkNEpOeTEzSHRYOTB6a1duQWVab2ZseE11SWJW?= =?utf-8?B?TGJWQ2Fpc2t0THh5bU10Z083ZEE3aXVnV3MvQkZ3a3ltWkk4YVdRNHgyYkwv?= =?utf-8?B?Y2FWNEFwYVlHNnVTUzhoVzU2YzNZakRDTmExMEpsWG5yY1k3MTRiUFFyV0Vm?= =?utf-8?B?TlRPUjIxTTFKYXByS29wZEw2ZkFaMW9pYkZ0ajgycXB0WGtDTjZLSThSOHJU?= =?utf-8?B?Zzk2K1NkYTdjTUE5MWtrMWpwVlE2T05mSUF0dWFJUUdHWEp4QUlMNFdjdUF1?= =?utf-8?B?ckVvdS9mLzVBRnRqMmIydkQ2RU1jVndHYUhXeXpyd21MOFErOC80RnNRanZu?= =?utf-8?B?YytWTThsYjVRU1dsTFZCZGhtSHcvS3ZiYkxRN0IwWVlITEkwQ2NVUnRQN3Rv?= =?utf-8?B?WjZMQzJBL3U4YTg1WnRPTFhTcEJudUtJTk53clB0L09DUUdyRmk5UHRxdTJU?= =?utf-8?B?MGFBNVNLTFZwUHFJTUlFNzNlOWtEdEVRc2d0STM4b3phelNuQ2tCM1dTekRa?= =?utf-8?B?NlVaMHh5Z1dnOTRQOVc0R3dTR1NwLzR2QUEzcTNROGFlajR5WUN3bGJhV0F6?= =?utf-8?B?QkxQSHlSWDA1MVQvanlCRy90dmU5aGFqaUVtcUh5M1ZreGFlNm9iMjQ4UWdl?= =?utf-8?B?VTU5L1VoaHRmZ1VOemsyRjViSWdUVS9rZlc4dkNJQ09JOXI3YkhtdlFhcUZW?= =?utf-8?B?NmhBd0cyVzRRTUloMjRvTE1NM1p0T2RzdVZ3SXQ5K1JGUHpiZ203TU16SjRG?= =?utf-8?B?MFdZSHpRUE9CLzMxeWRSUWlXbFViTmZKTDBDWGszUjUvdjNoTkh3ZCt6ZlBh?= =?utf-8?B?NThEcE5aQ3psK3o0UWN2bXdKa3ZNTzUwYVU3Zi9hN0VBdE5EUUYzUXhwYjdt?= =?utf-8?B?bEZFU0d1U0J0WDJQYTBpb2F2VllaYnZNNVpCRTJnaE1vUHg4VkVPeDYrMnBR?= =?utf-8?B?TVRZQXgzK0k3c3Z0SnFTM3g4MzFaRVgwUExMOUcra1FjVmFQTzJhVmhZMks4?= =?utf-8?B?cHZTWkhsellYajlOL0xtQzlSa2IxT0oyUHRnVStTM2RBWlowOVk4bUVyaW9C?= =?utf-8?Q?FDrOcCzhW4k2xl2MT6eaPuSok?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 174b2b5e-88b0-4110-edfd-08daf4a58132 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 14:01:30.2444 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KrjkouWn3IvIMEgsXaPcfIWdvk4FmrhV4OVeTScxXFSMoXCbN4Tg3h6PdmE6ZrYfgl+YowGg9GfO+CZ/O0/rPw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8537 size_t, ssize_t, and ptrdiff_t are all expected to be uniformly defined on any ports Xen might gain. In particular I hope new ports can rely on __SIZE_TYPE__ and __PTRDIFF_TYPE__ being made available by the compiler. Signed-off-by: Jan Beulich --- This is just to start with some hopefully uncontroversial low hanging fruit. --- a/xen/arch/arm/include/asm/types.h +++ b/xen/arch/arm/include/asm/types.h @@ -54,19 +54,6 @@ typedef u64 register_t; #define PRIregister "016lx" #endif -#if defined(__SIZE_TYPE__) -typedef __SIZE_TYPE__ size_t; -#else -typedef unsigned long size_t; -#endif -typedef signed long ssize_t; - -#if defined(__PTRDIFF_TYPE__) -typedef __PTRDIFF_TYPE__ ptrdiff_t; -#else -typedef signed long ptrdiff_t; -#endif - #endif /* __ASSEMBLY__ */ #endif /* __ARM_TYPES_H__ */ --- a/xen/arch/x86/include/asm/types.h +++ b/xen/arch/x86/include/asm/types.h @@ -32,19 +32,6 @@ typedef unsigned long paddr_t; #define INVALID_PADDR (~0UL) #define PRIpaddr "016lx" -#if defined(__SIZE_TYPE__) -typedef __SIZE_TYPE__ size_t; -#else -typedef unsigned long size_t; -#endif -typedef signed long ssize_t; - -#if defined(__PTRDIFF_TYPE__) -typedef __PTRDIFF_TYPE__ ptrdiff_t; -#else -typedef signed long ptrdiff_t; -#endif - #endif /* __ASSEMBLY__ */ #endif /* __X86_TYPES_H__ */ --- a/xen/include/xen/types.h +++ b/xen/include/xen/types.h @@ -5,6 +5,19 @@ #include +#if defined(__SIZE_TYPE__) +typedef __SIZE_TYPE__ size_t; +#else +typedef unsigned long size_t; +#endif +typedef signed long ssize_t; + +#if defined(__PTRDIFF_TYPE__) +typedef __PTRDIFF_TYPE__ ptrdiff_t; +#else +typedef signed long ptrdiff_t; +#endif + #define BITS_TO_LONGS(bits) \ (((bits)+BITS_PER_LONG-1)/BITS_PER_LONG) #define DECLARE_BITMAP(name,bits) \ From xen-devel-bounces@lists.xenproject.org Thu Jan 12 14:12:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 14:12:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476179.738223 (Exim 4.92) (envelope-from ) id 1pFyJe-00073O-Hz; Thu, 12 Jan 2023 14:12:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476179.738223; Thu, 12 Jan 2023 14:12:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFyJe-00073H-Ex; Thu, 12 Jan 2023 14:12:26 +0000 Received: by outflank-mailman (input) for mailman id 476179; Thu, 12 Jan 2023 14:12:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFyJd-000737-Oc; Thu, 12 Jan 2023 14:12:25 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFyJd-0001n0-MB; Thu, 12 Jan 2023 14:12:25 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFyJd-0005Ma-99; Thu, 12 Jan 2023 14:12:25 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pFyJd-0002Jc-8h; Thu, 12 Jan 2023 14:12:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=namEvxOZfSMy9Qw2UTPJQBrnqATYnSxvYuHP95LxpDQ=; b=f68pLMVRDgzvE6TARXVFtQZkOd CLJiKZiBtmevV9M9BtoBYGQFzd0Gm3pfhhvRPJ0r1JWHKTrAwWMwB42I+4XFuGLd1tO+OIdePVrGH SxCabVlk8nDbOAAxZj/vxhy4ZhM5BS2qwrM8UoF9eNvqhpOMrTgH934UEWIlPWZOMNS8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 175741: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=661489874e87c0f6e21ac298b039aab9379f6ee0 X-Osstest-Versions-That: xen=83d9679db057d5736c7b5a56db06bb6bb66c3914 From: osstest service owner Date: Thu, 12 Jan 2023 14:12:25 +0000 flight 175741 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/175741/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 661489874e87c0f6e21ac298b039aab9379f6ee0 baseline version: xen 83d9679db057d5736c7b5a56db06bb6bb66c3914 Last test of basis 175732 2023-01-12 00:00:28 Z 0 days Testing same since 175741 2023-01-12 11:01:58 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich Xenia Ragiadakou jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 83d9679db0..661489874e 661489874e87c0f6e21ac298b039aab9379f6ee0 -> smoke From xen-devel-bounces@lists.xenproject.org Thu Jan 12 14:16:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 14:16:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476188.738234 (Exim 4.92) (envelope-from ) id 1pFyNS-0007nq-61; Thu, 12 Jan 2023 14:16:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476188.738234; Thu, 12 Jan 2023 14:16:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFyNS-0007nj-2D; Thu, 12 Jan 2023 14:16:22 +0000 Received: by outflank-mailman (input) for mailman id 476188; Thu, 12 Jan 2023 14:16:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFyNQ-0007nd-Rs for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 14:16:20 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id adfb10cf-9283-11ed-91b6-6bf2151ebd3b; Thu, 12 Jan 2023 15:16:19 +0100 (CET) Received: from mail-mw2nam12lp2043.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.43]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 12 Jan 2023 09:16:16 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by MW4PR03MB6460.namprd03.prod.outlook.com (2603:10b6:303:123::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Thu, 12 Jan 2023 14:16:11 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5986.018; Thu, 12 Jan 2023 14:16:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: adfb10cf-9283-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1673532979; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=M4MLRHfiI+tlOzl0M5z8zfqWd7k4vE8XvdoGTLWQuxY=; b=cVdErYBqvZUkMNOOlHQ97ABmgLi+5ulgVnpqg2PLfLcUu7rG+DLnbli4 /T8E/bCnv6bhSNE4ET2lBNRowcxdAMKwNqoElJmp9GWJVBx2uu2emON7e Ei+he8edGhfeyyNjk29TE3YMYB08xk6jS5b43xanUS6lhJ6uB1q425U7G 0=; X-IronPort-RemoteIP: 104.47.66.43 X-IronPort-MID: 92355094 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:aA0EwaMaYTT0sazvrR2clsFynXyQoLVcMsEvi/4bfWQNrUp21GdVz DFNC2jUOPiJZjSjfd1xady2oxwD75LdmNMxTwto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQA+KmU4YoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9Suv3rRC9H5qyo42tB5wZmP5ingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0rlQXmZop N0RETtXTyqvv/yn3Y6wEtA506zPLOGzVG8ekldJ6GiDSNMZG9XESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+/RxvzO7IA9ZidABNPL8fNCQSNoTtUGfv m/cpEzyAw0ANczZwj2Amp6prr6Vxn6mANNOfFG+3tNQmwO/1DE6NDtIWRid8cCopHCeZvsKf iT4/QJr98De7neDTNPwQhm5q36spQMHVpxbFOhSwB6J4rrZ5UCeHGdsZj1Mdt0g8tM3TDoC1 1mVktevDjtq2JWFRHTY+rqKoDeaPSkOMXREdSICVREC4dTovMc0lB2nczp4OKu8j9mwHC6qx TmP9XI6n+9L0ZVN0Lin91fahT7qvoLOUgM++gTQWCSi8x99Y4mmIYev7DA38Mp9EWpQdXHZ1 FBspiRUxLpm4U2l/MBVfNgwIQ== IronPort-HdrOrdr: A9a23:e0/ES6Ffdxl9Ue9kpLqE2ceALOsnbusQ8zAXPhZKOHlom62j5r uTdZEgv3LJYVkqKRYdcLy7SdC9qBDnlKKdg7NhWYtKNTOO0ACVxedZnOjfKhLbak/DH4VmpM FdmsZFeaXN5JtB4voSIjPVLz/t+re6GWmT5dvj8w== X-IronPort-AV: E=Sophos;i="5.97,211,1669093200"; d="scan'208";a="92355094" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LkhyhHD8hMsvNpm4fqwp/gtEELQX0TyDa9GI4sGChI3BLfKuzj09EbHLXEuLvdpTp1mgXtccmewjvNzBNOsPvxFtzQcf4UMVu1fYy+BlDN4JGfn+ubhj5Ujcm37Cmv4iwEGVFsfP200EmRyy365ZBx3VN6BtUtt5oFqFCDZHKkVBANBDXXGtPt6zy4TvzKYuy+K9gxsoTa9QLGMpFWheYXkoz/sa+wlbsynpQci7vjWahYQaSMR4W/Ae9Zy1aJHUOCiHg8QFZdo26BI/wJpR3syZghmb9SlPjxBVIKDOCQAjXF7Z+Hn8FPj5LubRXSO+lYyl++Q3tyvB6ndlDZLddA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=M4MLRHfiI+tlOzl0M5z8zfqWd7k4vE8XvdoGTLWQuxY=; b=R4fimVzK47dFPO66/AisLIyJ+o34J7/6RRVnfOZ8I1S349TM1/RXdRjwRI+uen6YH9CXCpe+UQCC0iUQnmGe5vpb33GgJWfgmLWkfFllJ2ZwO4P/oYKhGLR7cRqpMuHI0FE0Mq9mstZKUnf3LPJqFIIvvCa8jwtmvKfYFxN2ue7T9UWGZy3pDCuVdWZwUhr4yoqNTp3RgplMTMZdSzUBk9q+U+MxJ/I6s0ewH3zxPJtgRSySXAuPtS06hTXSBr2dDz9/tKixrpTL3liIkDRQ9xnfNNQ6MBmZIMbejyj5bZsYQKPlMthNJaZYGVqK2qSI12LNuLGZ+xRGrmZ6NSGQ8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M4MLRHfiI+tlOzl0M5z8zfqWd7k4vE8XvdoGTLWQuxY=; b=Q1CshBj0F7v2MVXe/Ra3sY/Zl/54gItTGjMvd4fwtdegTGHyEek4rk+5OwVTn8PaYLnJL+vkbFiAcz2P9U4g3hPZapft6YPLNS5WVZZMUW0XHFdypNs6f3rRBc4PZTFqH0yV2ORcsE6rWWqS2y/2pTlkhTvR+/mwCZbqDYEq+wY= From: Andrew Cooper To: Jan Beulich CC: Roger Pau Monne , Wei Liu , Kevin Tian , Xen-devel Subject: Re: [PATCH v2 6/8] x86/hvm: Enable guest access to MSR_PKRS Thread-Topic: [PATCH v2 6/8] x86/hvm: Enable guest access to MSR_PKRS Thread-Index: AQHZJReeV/6Z/BfYW0W8YgpP3+cAB66ayMYAgAAN4oA= Date: Thu, 12 Jan 2023 14:16:11 +0000 Message-ID: References: <20230110171845.20542-1-andrew.cooper3@citrix.com> <20230110171845.20542-7-andrew.cooper3@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|MW4PR03MB6460:EE_ x-ms-office365-filtering-correlation-id: 10a3c5d1-979a-4679-b486-08daf4a78e9a x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: d/ltQULOJYSCIFxlzPN25XbqojMENpX2uON9xTaY1k/l7LXu7zOIBuJbXXQ6zopmu4LN3hDgPUlZE4DPqC9Vl9h3F+PLRLcAZMJOZQ/MHFYNNooo+zfmWgFovyMu4a4xYPoeo7u4mn8bdig3ElPBlGozpEvAQ650Ma48/8r5bK7Jny8q4ROFZNoWWtkCTDFRVnUcKRckbbCUBKXGAhf+Yu9YemqO90uTEVri+5VKC1Ud+XnxeSop6v3ngv0JuqMpVzNH8tJ1/UQAhyHr7gkNi1bTdoQl1H+smo+aW9eccoYRlntbBAOzy3dUJMuDY0bVm1muCz89moq5qO48Y8WCAH9VJ9bZBl7N7i14i6B3IWQxGtxVNcdMpY+oWu5rL6EPOT1veFNA55QFTjkoOUlgPVjKhbI34o5Y6jGikGV07HVmKaykdMLnxIoAtOX37OKSVdTiKE0nF5zfoJyoEn9SaCaHVyzbRw2dU8b6W/OSmEAR8OGT5LnRUbEc5NiipY+ow7U/fs21G83rq0zKwL38DVABsEzW6/ygsZ47I6MZOwdQ1BvdCVzoVCzeRKYp8GWsCd/4zUa635EmNRAhdWWkw/DGVbzH7pkXCSocz8hvXb782z8/yE6bY7UeBGGsf14xg2Wins7i19jLDrMyiW/ty0a4FVBFFOaJ3Pa7xBYk2vgDtwKARmYMsCdgNLzaH8meBDHVZc40+lWwjBoQ6vhvXDsG9TypOWUwTJq161NA8qz0rnlzlU9IZG5xaXV1XQ8HdEQqBfEz0TBRfDOTne90lw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(396003)(136003)(366004)(346002)(451199015)(31686004)(53546011)(2906002)(71200400001)(6506007)(6512007)(26005)(478600001)(186003)(2616005)(36756003)(64756008)(66476007)(66556008)(76116006)(66446008)(41300700001)(6916009)(4326008)(316002)(8676002)(66946007)(5660300002)(82960400001)(54906003)(122000001)(8936002)(38100700002)(83380400001)(6486002)(91956017)(86362001)(38070700005)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SjRuYjlRSktqdVdwV1VjcmJpOGRxczdSMmkvc3ZHSlRaQ1Z2S0VZbWlTQnB4?= =?utf-8?B?ZmpYV2p0YTQ1dGVNN0JxQ0dGamNtK3ZjUVRKN25Ec284K2RDZjZ5N3NWNktk?= =?utf-8?B?YTNwUW00d0JjdUtMTFArWDlSWmJueDdPYTlJR01qdlBNRjdDeVZVc2xod1B0?= =?utf-8?B?TElLYU1wMmlOT0ppdXVZSlRkd0tnTEwwNmFQaG1IQlExNnRIWGlFb0hNSVBi?= =?utf-8?B?dXpacjUvTGFweERjZnFaSUZUS2RBb2lpM3llNzJWWXhBTCs1c0ladmVqT24x?= =?utf-8?B?V0dyQ0dReWxNQzRURHNDTjVCMUlOdzVFNTI2N21rd3pnTUtYWndSNVRsMVJy?= =?utf-8?B?aWUrU1dsTmhuajJoQlRtMzJCQitWZGhmdllYNFd5WUQ5Yld1V01yMDJReG1O?= =?utf-8?B?SFdwSnBmTW5ZZ0RGdzhOODhicnpjZlo0UUdvSW8yTldqb1JvRkxYNnp5M0x2?= =?utf-8?B?a215VUxRTHRDY1J0RjdicEcyN2FzSHNjOWRqQm93VnlrcTg5UHNWU05Fd3J0?= =?utf-8?B?R1FYMmFCUFhibCtleUhqU2RzYmQwaVNRbnZDOUE1b2pLS3lLTEtjQlZrUlV2?= =?utf-8?B?YzIrRVhOak1RYzdRbldZVXVUV2JOTmNJVkVEYlBsTVllb3Z6MklOVmlPMjRk?= =?utf-8?B?SlRGQzZZOGJIVzgySW5GdTlPUjRHU0Nnc0ZyMGluTVZwWXhIeEpOZGZ6YW5s?= =?utf-8?B?OHNWK2ZWWG4yT3lDdFBQKy9wdzcvQ3IrVWtKMGF3Zm5WVmF2VW5LSnp5WlRM?= =?utf-8?B?RzVIMzc1RlM4eDkwaW9ma0VNdUpQWmZBdlhoRVVtRUMxOFFzbnBlNHI5QjhS?= =?utf-8?B?RHM2a3h0NkJTSmlTYjlZNFNBVWNHOUNuSWhsQ1VrdE9hakRGYXdyZmhYNGp3?= =?utf-8?B?bmx2MGJReGlldFZRTWJZbXY1REo4Z2JEbi9NTzBYajEvamVKSFhVUEl0U2d5?= =?utf-8?B?d3VJSjQ3QlQycFdRTVQ0U2FHWE9GRzMzb0hacnEvN0ZUVWEvaDlkWXlPV2Jw?= =?utf-8?B?VC9FVjYrTTk2VVVxQk1tZmR5dkg0NEFKL2lTQUp4R0JZTnFBNjZaa1F0VG9E?= =?utf-8?B?U3hnd2FYNUc4Q3plemhSYTYrSTRibXBnYnZvOERobFo4cG8xUGQ5QWdtUTBP?= =?utf-8?B?YUpuYkg0cHh5UXExdFkwQTNEZmFwQ3BuOUc1OVoycnNGcTBkYVBQY2ZWSmVH?= =?utf-8?B?aVNGZTIyZGlpRWFDU09MMUVrbmtEeEdTNDMrM3U2cXpkSXFEZ2h3dHNNaFQv?= =?utf-8?B?SEQxekR4alBWNTJKMVJldlU2S3RCTWhNUU1kd1Uyc1VPMldka0hrQ0JORzY1?= =?utf-8?B?Z3hwNEJVQjR6KysxZmQzTVVoVTVKVlRrdXIrVi9PYm0wMENmS1dsalRNSzlv?= =?utf-8?B?SDZyWGVQSm9PMnB2cDhmM0tMVlVFMXdNeFA3ZndtTzRoMFpFMnJlOFlDd3NE?= =?utf-8?B?VFVncGRoVDcvYUxVak43RGZyNXdvcnpHRXRKNmJ1ODlXbzEwcXpqdUtTbXhy?= =?utf-8?B?L3dHVVhKZVVPaW10QlEzK2VHQWZ4aEk5dGJ1N3ZtME9ZVzh4VW0vT2Jad1ll?= =?utf-8?B?eWUvMDdJd28xb0oydzQ2NjZHUHFyOVhvaThycWNuNjJERnVkVmF3bm9qRkts?= =?utf-8?B?dUZBdUNaUi9YRUJ3WG5CVXh3L1lTVDM2SjZBcWtFSDlmVWJDSVFTaXBBWjdz?= =?utf-8?B?ZURJNlBCQUhWZlhjYnpYc00zVlBBUGltLzhRME56R3ExZ3F2ZlcrWVVzSHU1?= =?utf-8?B?Q1FzSXVVNE1Hb2RXT1QrUHpDeXJWOGlsS0R3Rms0cnZWRk9acTlWK1F4dm5K?= =?utf-8?B?SWxJRWxqL1B4K1drVDRLTGZWSkNabG5PN2YyMVRBZ3hteWtROENjeWFBT2xL?= =?utf-8?B?c0RzOHVvM0dwcHcwUG9PdEVlMG9VSkdwRldwNFJWY0FPYUNsazZOY0dkRTZI?= =?utf-8?B?ZXEvTUFMUGJtd2RoNW9SMnN1bkhoQ0pScm5wanR6MjhkQVlwdmxqTjhFU0hJ?= =?utf-8?B?S1ZlVkZxK0ZBcW1SN1RFVlJWNUE0YWIvS0FEMGVacTUzVW0wQU5aVUFFVmxu?= =?utf-8?B?bFNQWm01VVdHQllxT1dVM0F0RlJEU0tmYThESGlicDRNTTg2ZTRlci9oM25p?= =?utf-8?B?WFFUV2sxL0RHTUwxK2psQzBTdHdzZ29DMGEwSlZ6UDFGU0lVS0NzODVqVzhW?= =?utf-8?B?a2c9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <5D3B55E9AB659345A5920CAE2C5408F6@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: +xO04Fjmt0auY74A9ABbxrEEAxVW+0cuJyKn5caME9E2LQqnLwgv3+2/KRj/wPbtcsjbdeo1GMVsLVXGMnLOq3hneKwXpPYovFFzZ5Hkz+yeOk6iNIHJnHpscvgIg1ApXg6qKV/p0QhHvjbaYrTgicqquY+tos5/SlGIlHDyNIvDm2AQKRO7ozAq5dMHLaZXb/PoiDEXZ/VRjA/7KDJIKWFduRFh27a1ksM9dmm019c63n7P/cT0QMrtbobamdRr6TbsaThHwU6NySKbcci26OMbbl92CxeNoQhpcd20EQAR85gzheMfvGTKQ6ysOi4llt36cM/HEkqcqcsqjtOJV8ciguWbwoi9ZTCzMhHv6hWJLsa4y1hYoxtc676tBS0pbhChktn3C35yrtWmSPrGNPEGHXRZVP2wQwMv3TpZH6jdnoFgWO34jYXHjCNxzv5oXtQQ5MP6shepeU0CpSBmOYvXKHDHkorI1scCva/bOfH0Xh5Uj8eNA7QMSKcT5DxaygCIIVaXF6iCsG8yEw/zzINvHPte6BdckJN4OxXXiuYfqAqHEaOuLA6aezyUhZXCM4tI6gMhJQmPxX9PWcc5KuYe0ASQEqlU9DcGfk1/6VIcSvtaLTdBZTTEKxOWOCd4RgI4r3ny5SLXQrjDJgY7PLEJqMxRwjWQ7YCB2LZHNiExIeAmmTejA1QcXlduWn8qP2+WPscxhsw3Jao2KeBC046aEBexeh6Os5EQ48fyEk+UD+Q3HC+C+YyH/zukEOfSkCQlxyx2aMgNkqQIOkKWV5zK8qNtaeSm//wx8j1z+FOtzV1Qa33qpiAcm28/35C4WRLCDxG3X865FVeIoKEppbtVSBpvKPKJUMkztg/HJzk= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 10a3c5d1-979a-4679-b486-08daf4a78e9a X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jan 2023 14:16:11.4940 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fJJKBldfN18K3jW9q44oCf9W7Nya5YvKdSHfa+mygMi02o3pRjrUWE0Hq7BWB8wpl8IqRq5/YkUcKSJclHR0wacT/eYOQV2Dn+dNNKzN+2k= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6460 T24gMTIvMDEvMjAyMyAxOjI2IHBtLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMTAuMDEuMjAy MyAxODoxOCwgQW5kcmV3IENvb3BlciB3cm90ZToNCj4+IEBAIC0yNDcxLDYgKzI0NzcsOSBAQCBz dGF0aWMgdWludDY0X3QgY2ZfY2hlY2sgdm14X2dldF9yZWcoc3RydWN0IHZjcHUgKnYsIHVuc2ln bmVkIGludCByZWcpDQo+PiAgICAgICAgICB9DQo+PiAgICAgICAgICByZXR1cm4gdmFsOw0KPj4g IA0KPj4gKyAgICBjYXNlIE1TUl9QS1JTOg0KPj4gKyAgICAgICAgcmV0dXJuICh2ID09IGN1cnIp ID8gcmRwa3JzKCkgOiBtc3JzLT5wa3JzOw0KPiBOb3RoaW5nIGhlcmUgb3IgLi4uDQo+DQo+PiBA QCAtMjUxNCw2ICsyNTI1LDEyIEBAIHN0YXRpYyB2b2lkIGNmX2NoZWNrIHZteF9zZXRfcmVnKHN0 cnVjdCB2Y3B1ICp2LCB1bnNpZ25lZCBpbnQgcmVnLCB1aW50NjRfdCB2YWwpDQo+PiAgICAgICAg ICAgICAgZG9tYWluX2NyYXNoKGQpOw0KPj4gICAgICAgICAgfQ0KPj4gICAgICAgICAgcmV0dXJu Ow0KPj4gKw0KPj4gKyAgICBjYXNlIE1TUl9QS1JTOg0KPj4gKyAgICAgICAgbXNycy0+cGtycyA9 IHZhbDsNCj4+ICsgICAgICAgIGlmICggdiA9PSBjdXJyICkNCj4+ICsgICAgICAgICAgICB3cnBr cnModmFsKTsNCj4+ICsgICAgICAgIHJldHVybjsNCj4gLi4uIGhlcmUgaXMgVk1YIG9yIChpZiB3 ZSB3ZXJlIHRvIHN1cHBvcnQgaXQsIGp1c3QgYXMgYSBhYnN0cmFjdA0KPiBjb25zaWRlcmF0aW9u KSBIVk0gc3BlY2lmaWMuIFdoaWNoIG1ha2VzIG1lIHdvbmRlciB3aHkgdGhpcyBuZWVkcw0KPiBo YW5kbGluZyBpbiBbZ3NdZXRfcmVnKCkgaW4gdGhlIGZpcnN0IHBsYWNlLiBJIGd1ZXNzIEknbSBz dGlsbCBub3QNCj4gZnVsbHkgaW4gc3luYyB3aXRoIHlvdXIgbG9uZ2VyIHRlcm0gcGxhbnMgaGVy ZSAuLi4NCg0KSWYgKHdoZW4pIEFNRCBpbXBsZW1lbnQgaXQsIHRoZSBBTUQgZm9ybSBuZWVkcyB3 aWxsIGJlIHZtY2ItPnBrcnMgYW5kDQpub3QgbXNycy0+cGtycywgYmVjYXVzZSBsaWtlIGFsbCBv dGhlciBwYWdpbmcgY29udHJvbHMsIHRoZXknbGwgYmUNCnN3YXBwZWQgYXV0b21hdGljYWxseSBi eSBWTVJVTi4NCg0KKEkgZG9uJ3Qga25vdyB0aGlzIGZvciBjZXJ0YWluLCBidXQgSSdtIGhhcHB5 IHRvIGJldCBvbiBpdCwgZ2l2ZW4gYQ0KZGVjYWRlIG9mIGNvbnNpc3RlbmN5IGluIHRoaXMgcmVn YXJkLikNCg0KPiBUaGUgb3RoZXIgdGhpbmcgSSdkIGxpa2UgdG8gdW5kZXJzdGFuZCAoYW5kIGhh dmluZyBhbiBhbnN3ZXIgdG8gdGhpcw0KPiB3b3VsZCBoYXZlIGJlZW4gYmV0dGVyIGJlZm9yZSBy ZS1hcHBseWluZyBteSBSLWIgdG8gdGhpcyByZS1iYXNlZA0KPiBsb2dpYykgaXMgdG93YXJkcyB0 aGUgbGFjayBvZiBmZWF0dXJlIGNoZWNrcyBoZXJlLiBodm1fZ2V0X3JlZygpDQo+IGNhbiBiZSBj YWxsZWQgZnJvbSBvdGhlciB0aGFuIGd1ZXN0X3JkbXNyKCksIGZvciBhbiBleGFtcGxlIHNlZQ0K PiBhcmNoX2dldF9pbmZvX2d1ZXN0KCkuDQoNClRoZSBwb2ludCBpcyB0byBzZXBhcmF0ZSBhdWRp dGluZyBsb2dpYyAod2FudHMgdG8gYmUgaW1wbGVtZW50ZWQgb25seQ0Kb25jZSkgZnJvbSBkYXRh IHNodWZmbGluZyBsb2dpYyAoaXMgdGhlIHZhbHVlIGluIGEgcmVnaXN0ZXIsIG9yIHRoZSBNU1IN Cmxpc3RzLCBvciBWTUNCL1ZNQ1Mgb3Igc3RydWN0IHZjcHUsIGV0YykuwqAgSXQgaXMgYWx3YXlz IHRoZSBjYWxsZXIncw0KcmVzcG9uc2liaWxpdHkgdG8gY29uZmlybSB0aGF0IFJFRyBleGlzdHMs IGFuZCB0aGF0IFZBTCBpcyBzdWl0YWJsZSBmb3IgUkVHLg0KDQphcmNoX2dldF9pbmZvX2d1ZXN0 KCkgcGFzc2VzIE1TUl9TSEFET1dfR1NfQkFTRSB3aGljaCBleGlzdHMNCnVuaWxhdGVyYWxseSAo YmVjYXVzZSB3ZSBkb24ndCB0ZWNobmljYWxseSBkbyAhTE0gY29ycmVjdGx5LikNCg0KDQpCdXQg dGhpcyBpcyBhbGwgZGlzY3Vzc2VkIGluIHRoZSBjb21tZW50IGJ5IHRoZSBmdW5jdGlvbiBwcm90 b3R5cGVzLsKgDQpJJ20gbm90IHN1cmUgaG93IHRvIG1ha2UgdGhhdCBhbnkgY2xlYXJlciB0aGFu IGl0IGFscmVhZHkgaXMuDQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Thu Jan 12 14:22:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 14:22:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476194.738245 (Exim 4.92) (envelope-from ) id 1pFyTS-0000pL-Qa; Thu, 12 Jan 2023 14:22:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476194.738245; Thu, 12 Jan 2023 14:22:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFyTS-0000pE-Ni; Thu, 12 Jan 2023 14:22:34 +0000 Received: by outflank-mailman (input) for mailman id 476194; Thu, 12 Jan 2023 14:22:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFyTR-0000p6-Im for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 14:22:33 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8b2b0e69-9284-11ed-b8d0-410ff93cb8f0; Thu, 12 Jan 2023 15:22:30 +0100 (CET) Received: from mail-sn1nam02lp2045.outbound.protection.outlook.com (HELO NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.57.45]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 12 Jan 2023 09:22:25 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SJ0PR03MB5760.namprd03.prod.outlook.com (2603:10b6:a03:2d3::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.13; Thu, 12 Jan 2023 14:22:23 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5986.018; Thu, 12 Jan 2023 14:22:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8b2b0e69-9284-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1673533351; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=+h3UbKkuU1lIVjdRVZZQkGmzfqawdmEoIuAEuNNsHCw=; b=c2K1VFzVI4+4HXXGsaQy+p3JtkLvmkfZQSfzLnWz01CmG1aL51hCdyLu SvNPGGQRE3tYBnB9Zj01aXqe2/8RGg038lx4LUeWe10wtn50c29qZMh6a 9nggArlXkmBPFJ+s466nK1udy0rVpe2AOIN373PsYJYpgCK3Ugb5W3R6w 0=; X-IronPort-RemoteIP: 104.47.57.45 X-IronPort-MID: 92356031 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:JWO30KLfGe5VUum/FE+RUJQlxSXFcZb7ZxGr2PjKsXjdYENS0GAOy WQWC2iHOq2IMWGnL9t3OYvg/U5Tvp/XyoBhHgVlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHv+kUrWs1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPcwP9TlK6q4mhA5wVkPaojUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5UIE538 eUVdAkcSSyhp+m0+vWLdspF05FLwMnDZOvzu1lG5BSBV7MdZ8mGRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dopTSOpOBy+OGF3N79U9qGX8hK2G2fo XrL5T/RCRAGLt2PjzGC9xpAg8eex3imBtpJTdVU8NY2g0CLm3ADNiQRalKfhKGWyUjudNlQf hl8Fi0G6PJaGFaQZtv3UgC8oXWElgUBQNcWGOo/gCmdx6yR7wuHC2wsSj9adMdgpMIwXSYt1 FKCg5XuHzMHmL+ITXOQ8J+EoDX0PjIaRUcZfjMNRwYB59jloakwgwjJQ9IlF7S65vXqHRngz jbMqzIx750ZgNQXzay98RbCiii1u5nSZgcv40PcWWfNxh1+YImpdom582/R5PxLLJuaZlSZt X1CkM+bhN3iFrmInS2JBf4LRbeg4q7fNCWG2QIyWZ486z6q5nivO5hK5y1zL1toNcBCfiL1Z EjUukVa45o70GaWUJKbqrmZU6wCpZUM3/y4PhwIRrKiuqRMSTI= IronPort-HdrOrdr: A9a23:DdH29KEoWAgCTQocpLqE0seALOsnbusQ8zAXPhZKOHtom6uj5q OTdZUgtSMc5wx7ZJhNo7q90cq7IE80l6Qb3WBLB8bHYOCOggLBEGgF1+bfKlbbdREWmNQw6U /OGZIObuEZoTJB/KTHCKjTKadE/OW6 X-IronPort-AV: E=Sophos;i="5.97,211,1669093200"; d="scan'208";a="92356031" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GTixSmmIGw9N/+iRhqPXbYL9s3wA/X/SLaqA3G5XkDyWz4FPR9lfCmWUlGp+L+eH/Trcc5pRfF/sAhtHvNYhN2iPxYZudq/0whopjALnJLUBUmcPVQy5GZ/7ONcU6GhKpbyXAdBKTUpse5YWSl0I7jhaPoeg/bHyBV+jDoO0bSz8GkpeS3lt4FnQwCM54gV7hXrg9F1bLbLuZXXhS2kau3j0Zc5rRYQZwCaUDXbuds35CJIap1C9usrASKBMf8kZVHZ9ho37rPsHxEodYNVQpO3EKKe1mNrY3Dl8KCQFIeKAD7Jbh4rSu6qUC8/2Nu37gu0nHtgVu7TOgELmvf42qA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+h3UbKkuU1lIVjdRVZZQkGmzfqawdmEoIuAEuNNsHCw=; b=I7XdOH/8c1qMCOptpC0csoqO+qc8xt33lYtpTXAjdE3WbCi8M3apokpxL1X5wK4231L/Jz5okiw7r4d0L7nDRIgjGo1TdWKhsTggiP/upD/GbARMMl+L70/IZnW8ZOs5H45uJaR+eyKudYenX1Wb1mOIzDZR6kuq4R7GZF19X1YqVUCo1N2Bqk+LKbFP2Z7cEC6yDs/wUNogiMHMiETwxVk9BPJhEr44ZTeizGrXpwer5YHVui1DYos2sriLq/4BP38bLzh9wCLRCyOuNKqApL+ErbF0IHxje0Ns1PeuqdhduK6W+pBbmSHOcPktwiZ9CProu0TNqnmxELCiX9QRTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+h3UbKkuU1lIVjdRVZZQkGmzfqawdmEoIuAEuNNsHCw=; b=BoKReGflrZvCpgEjrLeFMfXvrT59fdbwGQchSdNLtGXzs6kJXlrtUgz5o5KPQeUhkqmmdtR6HSq4QwGElE68rOs9V7JxuLZ4zlWBjUS8XaRFmkog4le1UVJ1BF9crpssIwU9h0UUBrKb0RrLC//ATNSyzas6CHA3Lopa3HmUZn0= From: Andrew Cooper To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Roger Pau Monne , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH] include/types: move stdlib.h-kind types to common header Thread-Topic: [PATCH] include/types: move stdlib.h-kind types to common header Thread-Index: AQHZJo5jBKk6QTlSGEGpBgNCxgedxK6a1XaA Date: Thu, 12 Jan 2023 14:22:23 +0000 Message-ID: References: <5a0a9e2a-c116-21b5-8081-db75fe4178d7@suse.com> In-Reply-To: <5a0a9e2a-c116-21b5-8081-db75fe4178d7@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|SJ0PR03MB5760:EE_ x-ms-office365-filtering-correlation-id: 58739a7c-21cc-4ff1-ab8b-08daf4a86c72 x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Ctu0V/6/qXaVilpijfRzUcCWIbUOAylU2DrwGAHhjWUkzSJTpxHDiUcF9fVy8IGU3EtUgahTS7BSsd3dIxSjG/JiU7BrRNcKXhojUSk8X4o1IYtNE29N9LC/lvGF2N7xwfHoSLKLfFNDT3P8wlmpcCYisxHeUy2zcKj7Kxl8KPwZwv1nTqiMv7vNzuDy8dntftsp/Tt1/5iVoO6sTtW1jQ9hHiWbtMbBwuiY5dFC379S/neYcRBsZDlUhrNb9zWs+ga2tNqBaghW/qAtDKUqZwF/wywik+ShdVTTOGS1dYB9ZSoFochQFRMUYfMFgmRA9WBAuGJ8q6GWPkxUiM9YmvY88OxJlGFpfOci9XIZG6+0KpwFMRjlKCyhQ16zr6Pu0m1uSJp5NQfYdLmrEE7P8biPzxqWhJTQp8WvijsBekX5B/BDdLQfOvWOrF0ZOy/Hd6q7LwGH/fFN533ZBxO0Qk9IegETLrloEuR1DE+ybVwXt4BhbKxAmrMkRWDG5k/h0Y6hqcU4oO3yVEs7Ajk4eRNjbdv0XYOyIjE8K/XBcsPEHKipXQFUYxutH1ax9Q5k3G6tsRV5KkeVMnzYSGMuA7dC0Oli2M5uzLcn/w4OfUOaJhMY5i53AaRIFj5hecDdJ3wdtz8iD09vjX/NY4BlUdZ8/9LPaRwdEVcdk7jakeuwlfzgmW7hKfDWCWRQ7RbVXgRVYD4/Efy1KV7y5ArarJYMyB9gGHxysNgvswXmzoDO7BfFNNu1VcimPrA/lFBboJuzH0E2fbYMyA2695tODw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(366004)(346002)(136003)(396003)(451199015)(82960400001)(38070700005)(6486002)(478600001)(41300700001)(6512007)(38100700002)(31696002)(71200400001)(86362001)(316002)(54906003)(110136005)(2616005)(91956017)(66556008)(66946007)(26005)(186003)(66476007)(76116006)(4326008)(36756003)(5660300002)(53546011)(6506007)(2906002)(31686004)(66446008)(64756008)(8676002)(8936002)(122000001)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?MTdIbjJGZDB4U0wzS2JMMzFaZUxUU1cxd3ZBNUpXUG9Yc3dkdXY5MnJDRnkx?= =?utf-8?B?dkJhaVVmUjk4NEYxUWFtcURBdmdGdU9hWmV2ZURWSmtJMTJ6SDE4blJrOW82?= =?utf-8?B?UGhoQmFDa2t3VkJEZGovNGhJenFMMTZKV2VPU1VFMkpqa3QyeHZuVHB3V2Nh?= =?utf-8?B?S3J3RC9TbHlVbi9TY2ZUam9DREF0UkFYekxPZytsYS9mRDNtTkJCVWNUUDk5?= =?utf-8?B?UXYvUStCOG5HRUZuMWxnbVJ3MEtQYit4TWtFdDF3a2tVM3ZnR3pLWkhBdnpR?= =?utf-8?B?YmZjR05wN0hOcHNGNzIrRWVOanlGcmlDRVNMeVRPRnc0dTBSb2JiRDEwZ1Js?= =?utf-8?B?NmxvSzRtNzZYK0MveVVDQlhRQ3hxdGZkVzNvYU5xeUIrUWZEN2ptT3k4cXBG?= =?utf-8?B?SWw4K0RieVFkMmpPWWpBMlNNQTRERmRWOFlXbHNhQnBCQXMxenpLMUwxalA2?= =?utf-8?B?VC82cHB6RDROSEJualpjZk5ncngrREhlaUFvTk1qQkxGQkwyRkI0RUowYklk?= =?utf-8?B?NUtsbTVwaTFxcEsySm5qd1pUMWZEREpTeFBTOVVaWmpBWGhWZUZ5YjZ4aWRi?= =?utf-8?B?Zm9ScUhML3JaOHdlN2pDTXZGYVc4d1VOV1ZiRWhGMFFQQmx1Vmh1VXpwYndp?= =?utf-8?B?SHdOVTFWL2UvR1hEOUt3MTJIYndwTktGMk5WSHA5K1lCRFpSemw0R1p4QWR1?= =?utf-8?B?TloxRUpiNGxUQlFOb2pGRUo4WFF5NUdZejJvL2pkV3kxZVlhTm5QUlVMbnN6?= =?utf-8?B?Q3FYWW9haTFSZ1M3QWljd0paNUhoWTlKQmJmR2RaZ3pXTkhFQXM2MjRjY1pV?= =?utf-8?B?M0hKZWVXcW41TkFSTDJPZXl5TERTMHVFam5sTXFrNHFOM3FUamZwN1ZmOFlY?= =?utf-8?B?SWRubUhYdTh0N1RCSW9wRUlPUTRoT01nZHplRW0rRjVnOEt0cGtVOFEwdU1j?= =?utf-8?B?eUFZTFJIKytyaW95dVFpQUlZeEpKL0hxTU1rVjFoeFQ2NmxET1AvK3dyVzZa?= =?utf-8?B?elpNcW1rZE9pTnBLNC96WnV5NVVHN2dibkczVS9wV0VRaVpMbGNFS2JDU0lt?= =?utf-8?B?SmlvVG1WWG1sbitOTkk2UWxaTlowNyt0YTVoMlBMWFJrbzRuc2x1dEtMVFVR?= =?utf-8?B?TUxsam9LbUMrbnFoQ0ZNaC9FRFNJV09rQzJNcWMzZWgrWUJ0RjBvTVdac0Y3?= =?utf-8?B?Zlc3RW9mS2srWWdxaTJnZzN4dGlCSVV0YUNnQVFQbFlpeEpjUUJJV0tSSUVX?= =?utf-8?B?SjA2VVo5QkdYRjVZenkyQkRIaUxZempJczdNU2grNkt4K1hUUElNZG56eTZX?= =?utf-8?B?bjVDS2hBbUdtL04yZnJPMkZ4VFBDREx0MG5IR3c2d3V3RDhMUFZRUFIyczlS?= =?utf-8?B?SVExWWxGVGFwS2JDKzlqZWFXWVc1YVJYMzBkN3RnaENzeFB0TVExTjl2UkZJ?= =?utf-8?B?RTZzdVR5dndQRzc2Wjhpa3l2bHM4c09Ybi8wdEZscHJJbkRKNEcwUExKREx3?= =?utf-8?B?Yk41ZnkxL2IvcFNtZ21pVWtEUDVOUjEyWWNFS2o1cmZaTndiYVRwSE9IdTdI?= =?utf-8?B?L0pQN1VDMXhXc1dVeFYzVDBTY2lNTUFRS0YzckhOWU5GVFNHMnFScnIzeHVn?= =?utf-8?B?a2J1T1lxdFlrS3hEWGlScndBYzcwZjNzMDV3Y0ZJSldGOEdRaWhna1NYck8x?= =?utf-8?B?b25pK1V3dldackhuaHFFWEcwbk1HTURzbmV0d2JrdUVHMFNGaDBqS3lzaHNN?= =?utf-8?B?R3dvMTJKL1hCSU4rYWhLR3gvYnlSODVKcUdoclNGaElRZFZ0Wi9mTWVIdE9L?= =?utf-8?B?N0RXM3lKZVdFN09jL3RFWEd6ODdaSkZ6UHY2elYrTTllSlB1dEdtVUtWRkQx?= =?utf-8?B?aFB0RktPNEVXeFFYc2JQZXBoZC9zdEF5VUphMzJhK1A2alBDUGVJdWNseHFq?= =?utf-8?B?U1ZGSHd6QjZ6OTdyT2t0WmdjRERlWXhydHFONjQ4UkJDQm01ekZma3EwVHd4?= =?utf-8?B?NTlIRis5VEhoQ1c4bUk3RDcwWGh2WmdJL2YwTjVpV2E3MldEbnc5czZMM2hB?= =?utf-8?B?N3IyWnl1VzJudjJCK3RjREg0UkNuVHJKUmhOS0hDNS9NbC8vK05FdndEQmk2?= =?utf-8?B?ZXFpOXBDQSs3ckxtV0oxdDB5WFNYYWR3NnF0SW51UzBJYTRFTjB2dFpEMzZE?= =?utf-8?B?bXc9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <5C2EF54913AB7A41AF27243F8AB6DF05@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: +gsU0egwR7YqovXveab2slRlomu1J7/5SL/RkGnGvJIahdbTmMv2QWlZRHqJczbnZfABapPQnO/Y5L0HiodKcWAT9uYSntZu88eMhkSaOQ9oFWcLIbRDsw8HIm0+VMamdsw63S/XlpcPwFeYLuQnn4BH7LDy3PhMUOPrcf+jPRWQLEuFGbAp6+DBI6xB1ixxWCtmS+nkkKB07HtaL2Gae4DgiykbxflE0qkb8G2uvW/63Uv+yaGkNl+tE9kQySE1qDVlfuzNvSMHLAPNttpPEruNw7035Oj5xRXtuYmPhmLawlnebsVZF2JaKOfDQ+hMsAICga+nKgPOBPCtFpeQbW5DyYL9Hf4L2I0wKXVu7L6tWIy9rk7+p2NUBsIioTcSAqPCQoK8btBEJWB9Gge0JRm2fHw4kj9WIo/rNvftySUetWxHxmkwysVCXuOiTk6TtK4gAEWqeXCoDG0m+o55ORQW5IpEGR08k7YshqUQ36QJQ42nF+x34dP3jgTlTXqOexz6Yi0OcwR9dNUgCpc8d41K3fKIy2cAvObiPGVZMQsNo0AzVVXMWCzW24o3UEcbvsKYOAlP4RMEmPQYI6UY6kVa/WkcDaGxZGzyMzF5uukCpAMom1JmsxHskSqKcrbsd11+2FIkB06dqdfU+NUr0fSBXHa0O6B3iTwj93dznzvspicZYcXfpMqAvpiWWs/Am8W6dFv3cms6zEAttEGD8Q7uCxk2YzwBns2yDs6msUnn23cU2FVry+l4jwqhf12SRXU+MEc2MWVoZaLnZQcqCL2b8w9Jf7RoWkV7pNip1euwflNNTgo4ejJmqjtqLPD8BDHnMjSnbhUx08F+NoK696VtvLnv38Ui4WpN2bLXVFsmFjqvKsa9Jq2Qv4y44VQ6yyoyAPbLMx/7gTueiNK6Lw== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 58739a7c-21cc-4ff1-ab8b-08daf4a86c72 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jan 2023 14:22:23.6858 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XjTFtefQ3YrRXUNTJrAm6P2AIyc4VZsat4m4Z3z2BQRxbwyorCrk4RUlRGFMXhXL30Yhu4KPKWng1l613fOgRfnZc36sVC2QYO3MjXV3hKU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5760 T24gMTIvMDEvMjAyMyAyOjAxIHBtLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gc2l6ZV90LCBzc2l6 ZV90LCBhbmQgcHRyZGlmZl90IGFyZSBhbGwgZXhwZWN0ZWQgdG8gYmUgdW5pZm9ybWx5IGRlZmlu ZWQNCj4gb24gYW55IHBvcnRzIFhlbiBtaWdodCBnYWluLiBJbiBwYXJ0aWN1bGFyIEkgaG9wZSBu ZXcgcG9ydHMgY2FuIHJlbHkgb24NCj4gX19TSVpFX1RZUEVfXyBhbmQgX19QVFJESUZGX1RZUEVf XyBiZWluZyBtYWRlIGF2YWlsYWJsZSBieSB0aGUgY29tcGlsZXIuDQo+DQo+IFNpZ25lZC1vZmYt Ynk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCg0KQWNrZWQtYnk6IEFuZHJldyBD b29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+DQoNClRoYW5reW91IGZvciBzdGFydGlu ZyB0aGlzLg0KDQo+IC0tLQ0KPiBUaGlzIGlzIGp1c3QgdG8gc3RhcnQgd2l0aCBzb21lIGhvcGVm dWxseSB1bmNvbnRyb3ZlcnNpYWwgbG93IGhhbmdpbmcgZnJ1aXQuDQoNCkhvd2V2ZXIsIEknZCBh ZHZvY2F0ZSBnb2luZyBvbmUgc3RlcCBmdXJ0aGVyIGFuZCBtYWtpbmcgcmVhbCBhDQp4ZW4vc3Rk ZGVmLmggaGVhZGVyIHRvIG1hdGNoIG91ciBleGlzdGluZyBzdGRib290IGFuZCBzdGRhcmcsIG5v dyB0aGF0DQp3ZSBoYXZlIGZ1bGx5IGRpdm9yY2VkIG91cnNlbHZlcyBmcm9tIHRoZSBjb21waWxl ci1wcm92aWRlZCBmcmVlc3RhbmRpbmcNCmhlYWRlcnMuDQoNClRoaXMgd2F5LCB0aGUgdHlwZSBh cmUgZGVjbGFyZWQgaW4gdGhlIHVzdWFsIHBsYWNlIGluIGEgQyBlbnZpcm9ubWVudC4NCg0KSSB3 YXMgdGhlbiBhbHNvIGdvaW5nIHRvIHVzZSB0aGlzIGFwcHJvYWNoIHRvIHN0YXJ0IGJyZWFraW5n IHVwDQp4ZW4vbGliLmggd2hpY2ggaXMgYSBkdW1waW5nIGdyb3VuZCBvZiBmYXIgdG9vIG11Y2gg c3R1ZmYuwqAgSW4NCnBhcnRpY3VsYXIsIHdoZW4gd2UgaGF2ZSBhIHN0ZGRlZi5oLCBJIHRoaW5r IGl0IGlzIGVudGlyZWx5IHJlYXNvbmFibGUNCnRvIG1vdmUgdGhpbmdzIGxpa2UgQVJSQVlfU0la RS9jb3VudF9hcmdzKCkvZXRjIGludG8gaXQsIGJlY2F1c2UgdGhleQ0KYXJlIGVudGlyZWx5IHN0 YW5kYXJkIGluIHRoZSBYZW4gY29kZWJhc2UuDQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Thu Jan 12 14:39:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 14:39:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476203.738265 (Exim 4.92) (envelope-from ) id 1pFyjp-0002kN-Vj; Thu, 12 Jan 2023 14:39:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476203.738265; Thu, 12 Jan 2023 14:39:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFyjp-0002jB-Q6; Thu, 12 Jan 2023 14:39:29 +0000 Received: by outflank-mailman (input) for mailman id 476203; Thu, 12 Jan 2023 14:39:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFyjo-0002av-Gj for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 14:39:28 +0000 Received: from casper.infradead.org (casper.infradead.org [2001:8b0:10b:1236::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e7f02495-9286-11ed-b8d0-410ff93cb8f0; Thu, 12 Jan 2023 15:39:23 +0100 (CET) Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFyjo-0057ze-0K; Thu, 12 Jan 2023 14:39:28 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id E5F5E300BE3; Thu, 12 Jan 2023 15:39:12 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 0) id BD2812CC8C6A4; Thu, 12 Jan 2023 15:39:12 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e7f02495-9286-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Type:MIME-Version:References: Subject:Cc:To:From:Date:Message-ID:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:In-Reply-To; bh=eW1eJS20PBPNIc/x7hkOEbhV5Z70C96GEP7VlPQr3GE=; b=aPU7lwsfmN0exgD06ro+v230ma inYN+4H37Om7tBqtVLzUL9CUNUKlfPza2KgcF/4PIvMJRSjjj182vbfZKCbWGWcbCIG45AgQgTeW2 fJfibscpsY63h5bZRqGsUf4OhsblkoP/Zw/BZA9PTJDZ2yDWPiuYKZy08myhK7w4NQ6zGvyAXLf0r M3tKHRiVoMc/WSOdEc6z2X8grpK42f1voLXiB5Pdc8Sqe2lHCgDtzs7he1s2s4NuaMwjujHi3zrRS ZFm27VOnMo7aZariMxE7kPw4B2ygcq5oEm7hLZK/tnd6ofcrPVD/UdjX1MVog7QR+UD+cBkfTdQE7 QKSVn4uQ==; Message-ID: <20230112143825.762830112@infradead.org> User-Agent: quilt/0.66 Date: Thu, 12 Jan 2023 15:31:45 +0100 From: Peter Zijlstra To: x86@kernel.org, Joan Bruguera Cc: linux-kernel@vger.kernel.org, peterz@infradead.org, Juergen Gross , "Rafael J. Wysocki" , xen-devel , Jan Beulich , Roger Pau Monne , Kees Cook , mark.rutland@arm.com Subject: [RFC][PATCH 4/6] x86/power: Sprinkle some noinstr References: <20230112143141.645645775@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Ensure no compiler instrumentation sneaks in while restoring the CPU state. Specifically we can't handle CALL/RET until GS is restored. Signed-off-by: Peter Zijlstra (Intel) --- arch/x86/power/cpu.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) --- a/arch/x86/power/cpu.c +++ b/arch/x86/power/cpu.c @@ -192,7 +192,7 @@ static void fix_processor_context(void) * The asm code that gets us here will have restored a usable GDT, although * it will be pointing to the wrong alias. */ -static void notrace __restore_processor_state(struct saved_context *ctxt) +static __always_inline void __restore_processor_state(struct saved_context *ctxt) { struct cpuinfo_x86 *c; @@ -235,6 +235,13 @@ static void notrace __restore_processor_ loadsegment(fs, __KERNEL_PERCPU); #endif + /* + * Definitely wrong, but at this point we should have at least enough + * to do CALL/RET (consider SKL callthunks) and this avoids having + * to deal with the noinstr explosion for now :/ + */ + instrumentation_begin(); + /* Restore the TSS, RO GDT, LDT, and usermode-relevant MSRs. */ fix_processor_context(); @@ -276,10 +283,12 @@ static void notrace __restore_processor_ * because some of the MSRs are "emulated" in microcode. */ msr_restore_context(ctxt); + + instrumentation_end(); } /* Needed by apm.c */ -void notrace restore_processor_state(void) +void noinstr restore_processor_state(void) { __restore_processor_state(&saved_context); } From xen-devel-bounces@lists.xenproject.org Thu Jan 12 14:39:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 14:39:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476206.738311 (Exim 4.92) (envelope-from ) id 1pFyjs-0003pV-Qb; Thu, 12 Jan 2023 14:39:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476206.738311; Thu, 12 Jan 2023 14:39:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFyjs-0003p8-Kk; Thu, 12 Jan 2023 14:39:32 +0000 Received: by outflank-mailman (input) for mailman id 476206; Thu, 12 Jan 2023 14:39:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFyjq-0002av-J2 for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 14:39:30 +0000 Received: from desiato.infradead.org (desiato.infradead.org [2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e82b8c26-9286-11ed-b8d0-410ff93cb8f0; Thu, 12 Jan 2023 15:39:25 +0100 (CET) Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1pFyjT-0040tJ-0q; Thu, 12 Jan 2023 14:39:07 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 6DA1B30067B; Thu, 12 Jan 2023 15:39:13 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 0) id C69932CC949B5; Thu, 12 Jan 2023 15:39:12 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e82b8c26-9286-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Type:MIME-Version:References: Subject:Cc:To:From:Date:Message-ID:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:In-Reply-To; bh=w9+PAdJk73UH2Fl3uPAAs4wgk5kyO76VlH+ufUk/PX4=; b=dGCr6CbAN+FGZxrxNRDZdAytzQ ohdZmJ2pWqhrruEFxAeISbBJzfYzIpqoJ3L/tRSUW3gBGjkO2s4tKa2W7ElzbOgRY0hRHRAMqDn7v I08YMwa446QJGSFX9BK9EJUds/SAXIdeHq/1QrE0yC9DLJmA54/yUU0pMsKnK/GKurujDhdUdMZgy 2+E0yvI3gp0qTRUUgSCZVL/zjtjL6j9B4gmAO+rUVP/3waaiBSWmCmPLQGQ2RCXfbx35gYfLuHUHj rMAwsTWq/CMa37B4ktxnJOl8GYiROHox2K2kVc6oMMpelLmGsftbM+7NBgYgsXqBejFVKGscqqsL5 Y+V/ZZZg==; Message-ID: <20230112143825.822328168@infradead.org> User-Agent: quilt/0.66 Date: Thu, 12 Jan 2023 15:31:46 +0100 From: Peter Zijlstra To: x86@kernel.org, Joan Bruguera Cc: linux-kernel@vger.kernel.org, peterz@infradead.org, Juergen Gross , "Rafael J. Wysocki" , xen-devel , Jan Beulich , Roger Pau Monne , Kees Cook , mark.rutland@arm.com Subject: [RFC][PATCH 5/6] PM / hibernate: Add minimal noinstr annotations References: <20230112143141.645645775@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 When resuming there must not be any code between swsusp_arch_suspend() and restore_processor_state() since the CPU state is ill defined at this point in time. Signed-off-by: Peter Zijlstra (Intel) --- kernel/power/hibernate.c | 30 +++++++++++++++++++++++++++--- 1 file changed, 27 insertions(+), 3 deletions(-) --- a/kernel/power/hibernate.c +++ b/kernel/power/hibernate.c @@ -280,6 +280,32 @@ __weak int arch_resume_nosmt(void) return 0; } +static noinstr int suspend_and_restore(void) +{ + int error; + + /* + * Strictly speaking swsusp_arch_suspend() should be noinstr too but it + * is typically written in asm, as such, assume it is good and shut up + * the validator. + */ + instrumentation_begin(); + error = swsusp_arch_suspend(); + instrumentation_end(); + + /* + * Architecture resume code 'returns' from the swsusp_arch_suspend() + * call and resumes execution here with some very dodgy machine state. + * + * Compiler instrumentation between these two calls (or in + * restore_processor_state() for that matter) will make life *very* + * interesting indeed. + */ + restore_processor_state(); + + return error; +} + /** * create_image - Create a hibernation image. * @platform_mode: Whether or not to use the platform driver. @@ -323,9 +349,7 @@ static int create_image(int platform_mod in_suspend = 1; save_processor_state(); trace_suspend_resume(TPS("machine_suspend"), PM_EVENT_HIBERNATE, true); - error = swsusp_arch_suspend(); - /* Restore control flow magically appears here */ - restore_processor_state(); + error = suspend_and_restore(); trace_suspend_resume(TPS("machine_suspend"), PM_EVENT_HIBERNATE, false); if (error) pr_err("Error %d creating image\n", error); From xen-devel-bounces@lists.xenproject.org Thu Jan 12 14:39:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 14:39:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476205.738298 (Exim 4.92) (envelope-from ) id 1pFyjr-0003UZ-H2; Thu, 12 Jan 2023 14:39:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476205.738298; Thu, 12 Jan 2023 14:39:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFyjr-0003T0-C2; Thu, 12 Jan 2023 14:39:31 +0000 Received: by outflank-mailman (input) for mailman id 476205; Thu, 12 Jan 2023 14:39:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFyjp-0002av-Ir for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 14:39:29 +0000 Received: from desiato.infradead.org (desiato.infradead.org [2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e7f83730-9286-11ed-b8d0-410ff93cb8f0; Thu, 12 Jan 2023 15:39:25 +0100 (CET) Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1pFyjS-0040tE-0z; Thu, 12 Jan 2023 14:39:06 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id EA5E2300C50; Thu, 12 Jan 2023 15:39:12 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 0) id B77922CC949A1; Thu, 12 Jan 2023 15:39:12 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e7f83730-9286-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Type:MIME-Version:References: Subject:Cc:To:From:Date:Message-ID:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:In-Reply-To; bh=+hVGbhW+kq8WeUTnRFVIQ4y6xF6mTUDTY1iojLvcO/Q=; b=VD2YCgkTmE2CQ4Y8uw29qiC2TE R80ib0ot/jJ/vDVx1nc81VA/UdFYRNG0RCJX9If+JwIwax/MdSzvs+229sqAm51rlqFP4ZtmBL6KE ZGwzJaeaNt97uYlCPg3WWmvJH6/Qc2TRui52REAxdkfvawrPGc1AlBYy8r3QDtkibYhajuP5B7DDl e4VUHACu7Phw+gAfdvDwUrseQHxbEogW6ZFrf4DGNzODQW73kd/B4Gn8iBVxRaIIdPZwruHvk8R/J U+pz1lXQCECLx95TWt3y1l8JrPMkbqVDOu1nEJOjWfQjLPnHBvOtaLz8Bxx4rBAruF+c4Yb+M8UAF +VcR5hIg==; Message-ID: <20230112143825.644480983@infradead.org> User-Agent: quilt/0.66 Date: Thu, 12 Jan 2023 15:31:43 +0100 From: Peter Zijlstra To: x86@kernel.org, Joan Bruguera Cc: linux-kernel@vger.kernel.org, peterz@infradead.org, Juergen Gross , "Rafael J. Wysocki" , xen-devel , Jan Beulich , Roger Pau Monne , Kees Cook , mark.rutland@arm.com Subject: [RFC][PATCH 2/6] x86/power: Inline write_cr[04]() References: <20230112143141.645645775@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Since we can't do CALL/RET until GS is restored and CR[04] pinning is of dubious value in this code path, simply write the stored values. Signed-off-by: Peter Zijlstra (Intel) --- arch/x86/power/cpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/arch/x86/power/cpu.c +++ b/arch/x86/power/cpu.c @@ -208,11 +208,11 @@ static void notrace __restore_processor_ #else /* CONFIG X86_64 */ native_wrmsrl(MSR_EFER, ctxt->efer); - native_write_cr4(ctxt->cr4); + asm volatile("mov %0,%%cr4": "+r" (ctxt->cr4) : : "memory"); #endif native_write_cr3(ctxt->cr3); native_write_cr2(ctxt->cr2); - native_write_cr0(ctxt->cr0); + asm volatile("mov %0,%%cr0": "+r" (ctxt->cr0) : : "memory"); /* Restore the IDT. */ native_load_idt(&ctxt->idt); From xen-devel-bounces@lists.xenproject.org Thu Jan 12 14:39:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 14:39:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476207.738322 (Exim 4.92) (envelope-from ) id 1pFyjw-0004Ac-4I; Thu, 12 Jan 2023 14:39:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476207.738322; Thu, 12 Jan 2023 14:39:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFyjv-0004AT-Vt; Thu, 12 Jan 2023 14:39:35 +0000 Received: by outflank-mailman (input) for mailman id 476207; Thu, 12 Jan 2023 14:39:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFyjv-0002av-69 for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 14:39:35 +0000 Received: from desiato.infradead.org (desiato.infradead.org [2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id eda5cb2e-9286-11ed-b8d0-410ff93cb8f0; Thu, 12 Jan 2023 15:39:33 +0100 (CET) Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1pFyjS-0040tF-12; Thu, 12 Jan 2023 14:39:06 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id E5EEE30084B; Thu, 12 Jan 2023 15:39:12 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 0) id B487C2CC8C6A5; Thu, 12 Jan 2023 15:39:12 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eda5cb2e-9286-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Type:MIME-Version:References: Subject:Cc:To:From:Date:Message-ID:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:In-Reply-To; bh=sHDPsq2uABjtfq0P5gTU9bTPKMFTr0x7rU8OwfasSIg=; b=LI9y8vBQdis0SSWa52KOS2vrQI DwEgo+snsApY9aPqeiehYRoGQAQPCfcXdVF/jnQvKmoDaZgOMjKpFPoGTQGrbyME7YpvvPqVAN8Au xhJ4YL/E4PAO+PAZBX22U4wBu1/QoMzS7R97C0oTdBAOCx8hnEzZ/GJ8x43Z2EedpvXr/NLaJ1WcW Xn4115CcVMUdvp59cZr83pNUcEW6riGQbkak/hhi3nIgdfg9mi2Jm6QWhhq8mm98rpvZdtPfTsVha Tn3o9kjumy/5q3a/JwjaPtKaLtr7A4nKrKiZq5C++dGVHnqAjuh5olHmuMnpLddjUizxu999OLs+z VmxWPwnQ==; Message-ID: <20230112143825.584639584@infradead.org> User-Agent: quilt/0.66 Date: Thu, 12 Jan 2023 15:31:42 +0100 From: Peter Zijlstra To: x86@kernel.org, Joan Bruguera Cc: linux-kernel@vger.kernel.org, peterz@infradead.org, Juergen Gross , "Rafael J. Wysocki" , xen-devel , Jan Beulich , Roger Pau Monne , Kees Cook , mark.rutland@arm.com Subject: [RFC][PATCH 1/6] x86/power: De-paravirt restore_processor_state() References: <20230112143141.645645775@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Since Xen PV doesn't use restore_processor_state(), and we're going to have to avoid CALL/RET until at least GS is restored, de-paravirt the easy bits. Signed-off-by: Peter Zijlstra (Intel) --- arch/x86/power/cpu.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) --- a/arch/x86/power/cpu.c +++ b/arch/x86/power/cpu.c @@ -197,25 +197,25 @@ static void notrace __restore_processor_ struct cpuinfo_x86 *c; if (ctxt->misc_enable_saved) - wrmsrl(MSR_IA32_MISC_ENABLE, ctxt->misc_enable); + native_wrmsrl(MSR_IA32_MISC_ENABLE, ctxt->misc_enable); /* * control registers */ /* cr4 was introduced in the Pentium CPU */ #ifdef CONFIG_X86_32 if (ctxt->cr4) - __write_cr4(ctxt->cr4); + native_write_cr4(ctxt->cr4); #else /* CONFIG X86_64 */ - wrmsrl(MSR_EFER, ctxt->efer); - __write_cr4(ctxt->cr4); + native_wrmsrl(MSR_EFER, ctxt->efer); + native_write_cr4(ctxt->cr4); #endif - write_cr3(ctxt->cr3); - write_cr2(ctxt->cr2); - write_cr0(ctxt->cr0); + native_write_cr3(ctxt->cr3); + native_write_cr2(ctxt->cr2); + native_write_cr0(ctxt->cr0); /* Restore the IDT. */ - load_idt(&ctxt->idt); + native_load_idt(&ctxt->idt); /* * Just in case the asm code got us here with the SS, DS, or ES @@ -230,7 +230,7 @@ static void notrace __restore_processor_ * handlers or in complicated helpers like load_gs_index(). */ #ifdef CONFIG_X86_64 - wrmsrl(MSR_GS_BASE, ctxt->kernelmode_gs_base); + native_wrmsrl(MSR_GS_BASE, ctxt->kernelmode_gs_base); #else loadsegment(fs, __KERNEL_PERCPU); #endif @@ -246,15 +246,15 @@ static void notrace __restore_processor_ loadsegment(ds, ctxt->es); loadsegment(es, ctxt->es); loadsegment(fs, ctxt->fs); - load_gs_index(ctxt->gs); + native_load_gs_index(ctxt->gs); /* * Restore FSBASE and GSBASE after restoring the selectors, since * restoring the selectors clobbers the bases. Keep in mind * that MSR_KERNEL_GS_BASE is horribly misnamed. */ - wrmsrl(MSR_FS_BASE, ctxt->fs_base); - wrmsrl(MSR_KERNEL_GS_BASE, ctxt->usermode_gs_base); + native_wrmsrl(MSR_FS_BASE, ctxt->fs_base); + native_wrmsrl(MSR_KERNEL_GS_BASE, ctxt->usermode_gs_base); #else loadsegment(gs, ctxt->gs); #endif From xen-devel-bounces@lists.xenproject.org Thu Jan 12 14:39:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 14:39:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476204.738276 (Exim 4.92) (envelope-from ) id 1pFyjq-0002rB-BK; Thu, 12 Jan 2023 14:39:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476204.738276; Thu, 12 Jan 2023 14:39:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFyjq-0002nW-2V; Thu, 12 Jan 2023 14:39:30 +0000 Received: by outflank-mailman (input) for mailman id 476204; Thu, 12 Jan 2023 14:39:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFyjo-0002av-UJ for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 14:39:28 +0000 Received: from casper.infradead.org (casper.infradead.org [2001:8b0:10b:1236::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e881a6da-9286-11ed-b8d0-410ff93cb8f0; Thu, 12 Jan 2023 15:39:24 +0100 (CET) Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFyjo-0057zn-9C; Thu, 12 Jan 2023 14:39:28 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 6E776300AFB; Thu, 12 Jan 2023 15:39:13 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 0) id CB2472CC949B7; Thu, 12 Jan 2023 15:39:12 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e881a6da-9286-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Type:MIME-Version:References: Subject:Cc:To:From:Date:Message-ID:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:In-Reply-To; bh=LNbZyqdS6MCOXN5DhvrakKEz6kKRrs7/+Ia2/9U4HAc=; b=G5AA9h/yH9+nJcJaV99Ad2Ey8F k5XWYtZamnH9v88AQNk//cUWHI313YsUcDWkBRHwsEnZ3YwO8uX31UVbbHNGiSckhXek4//+Wnz8l sFL6gBapz0F4s5kPWpNrhL2lnWrU7jUGCNGjtvEK9GN2wjN3Qp6ppjE4WmTl7v9s6AsO4FwK2CMiy BksgEqIsTHg+IvsVuWE/RCyauvJNvXu9ihIdqTkl7iNXaBSeD4jwxobQPOMLpk/dWsh0TlC086R3I 6S5sM/g0/l5h+kcMN6smqUUGVPcaJ0N69KsfH2p+TSKM/cDaDIhyRd6fHrKzfHFtn9N3WXaseHucg 0YtdygGg==; Message-ID: <20230112143825.881829388@infradead.org> User-Agent: quilt/0.66 Date: Thu, 12 Jan 2023 15:31:47 +0100 From: Peter Zijlstra To: x86@kernel.org, Joan Bruguera Cc: linux-kernel@vger.kernel.org, peterz@infradead.org, Juergen Gross , "Rafael J. Wysocki" , xen-devel , Jan Beulich , Roger Pau Monne , Kees Cook , mark.rutland@arm.com Subject: [RFC][PATCH 6/6] x86/power: Seal restore_processor_state() References: <20230112143141.645645775@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Disallow indirect branches to restore_processor_state(). Signed-off-by: Peter Zijlstra (Intel) --- arch/x86/include/asm/suspend_64.h | 4 ++++ arch/x86/power/cpu.c | 2 +- arch/x86/power/hibernate_asm_64.S | 4 ++++ include/linux/suspend.h | 4 ++++ 4 files changed, 13 insertions(+), 1 deletion(-) --- a/arch/x86/include/asm/suspend_64.h +++ b/arch/x86/include/asm/suspend_64.h @@ -9,6 +9,7 @@ #include #include +#include /* * Image of the saved processor state, used by the low level ACPI suspend to @@ -61,4 +62,7 @@ struct saved_context { extern char core_restore_code[]; extern char restore_registers[]; +#define restore_processor_state restore_processor_state +extern __noendbr void restore_processor_state(void); + #endif /* _ASM_X86_SUSPEND_64_H */ --- a/arch/x86/power/cpu.c +++ b/arch/x86/power/cpu.c @@ -288,7 +288,7 @@ static __always_inline void __restore_pr } /* Needed by apm.c */ -void noinstr restore_processor_state(void) +void __noendbr noinstr restore_processor_state(void) { __restore_processor_state(&saved_context); } --- a/arch/x86/power/hibernate_asm_64.S +++ b/arch/x86/power/hibernate_asm_64.S @@ -23,6 +23,10 @@ #include #include +.pushsection .discard.noendbr +.quad restore_processor_state +.popsection + /* code below belongs to the image kernel */ .align PAGE_SIZE SYM_FUNC_START(restore_registers) --- a/include/linux/suspend.h +++ b/include/linux/suspend.h @@ -9,6 +9,7 @@ #include #include #include +#include #ifdef CONFIG_VT extern void pm_set_vt_switch(int); @@ -483,7 +484,10 @@ extern struct mutex system_transition_mu #ifdef CONFIG_PM_SLEEP void save_processor_state(void); + +#ifndef restore_processor_state void restore_processor_state(void); +#endif /* kernel/power/main.c */ extern int register_pm_notifier(struct notifier_block *nb); From xen-devel-bounces@lists.xenproject.org Thu Jan 12 14:39:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 14:39:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476202.738262 (Exim 4.92) (envelope-from ) id 1pFyjp-0002el-LJ; Thu, 12 Jan 2023 14:39:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476202.738262; Thu, 12 Jan 2023 14:39:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFyjp-0002dz-GL; Thu, 12 Jan 2023 14:39:29 +0000 Received: by outflank-mailman (input) for mailman id 476202; Thu, 12 Jan 2023 14:39:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFyjm-0002av-PO for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 14:39:28 +0000 Received: from casper.infradead.org (casper.infradead.org [2001:8b0:10b:1236::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e7f3caf7-9286-11ed-b8d0-410ff93cb8f0; Thu, 12 Jan 2023 15:39:23 +0100 (CET) Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFyjn-0057zf-Vo; Thu, 12 Jan 2023 14:39:28 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id E8514300C22; Thu, 12 Jan 2023 15:39:12 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 0) id AF0012C539AAE; Thu, 12 Jan 2023 15:39:12 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e7f3caf7-9286-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Subject:Cc:To:From:Date:Message-ID: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:In-Reply-To:References; bh=dxKp4F/ZypynYhxVQrwpFBE7F8I1udIiZ+qCB0euLH8=; b=Qw76boxsic6bAdPZ+sbUQ2gqH+ toujE3QAL7Ysrb/kR6kbNWK8+/9lcxeR5snVxN72gLXv54orCAYheJOMSUJTxsIOq6nlVdd9M05yx xzAl7+DGS02CDXkNHHjeh7e9nMs5aY0qzl9lI/Ybug1C2cN+L9cUSAyH9scpEzK8O5SsQgYiCg6Y5 jAK6oY9jXCznsqioTj6bpA+gfUlBJJaabAP8t+fNLnSC0fudkg27IKcOz4kzbhxN1B+GtqFgHO05t iG2Tq/6Nx3QTZSzkBCmPsHHW89g1u9fdQigJA6ONkHFfsmbKlG6YcpbLdRrHDBiKoAXxjMOx3j3S3 79pDM38g==; Message-ID: <20230112143141.645645775@infradead.org> User-Agent: quilt/0.66 Date: Thu, 12 Jan 2023 15:31:41 +0100 From: Peter Zijlstra To: x86@kernel.org, Joan Bruguera Cc: linux-kernel@vger.kernel.org, peterz@infradead.org, Juergen Gross , "Rafael J. Wysocki" , xen-devel , Jan Beulich , Roger Pau Monne , Kees Cook , mark.rutland@arm.com Subject: [RFC][PATCH 0/6] x86: Fix suspend vs retbleed=stuff Hi, I'm thinking these few patches should do the trick -- but I've only compiled them and looked at the resulting asm output, I've not actually ran them. Joan, could you kindly test? The last (two) patches are optional fixes and should probably not go into /urgent. From xen-devel-bounces@lists.xenproject.org Thu Jan 12 14:39:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 14:39:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476201.738256 (Exim 4.92) (envelope-from ) id 1pFyjp-0002bN-D2; Thu, 12 Jan 2023 14:39:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476201.738256; Thu, 12 Jan 2023 14:39:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFyjp-0002bG-8O; Thu, 12 Jan 2023 14:39:29 +0000 Received: by outflank-mailman (input) for mailman id 476201; Thu, 12 Jan 2023 14:39:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFyjm-0002au-Sz for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 14:39:27 +0000 Received: from desiato.infradead.org (desiato.infradead.org [2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e8a2ca71-9286-11ed-91b6-6bf2151ebd3b; Thu, 12 Jan 2023 15:39:25 +0100 (CET) Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1pFyjS-0040tD-11; Thu, 12 Jan 2023 14:39:06 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id EC89A300C6F; Thu, 12 Jan 2023 15:39:12 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 0) id BAAF42CC8C6A1; Thu, 12 Jan 2023 15:39:12 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e8a2ca71-9286-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Type:MIME-Version:References: Subject:Cc:To:From:Date:Message-ID:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:In-Reply-To; bh=T4GElGxaw5tEx2Lk6kKh2cwaswlijZP7pkxV7zD03yo=; b=dWjbmZzwf1WthR8TZ23ii1la+e yq8CeiWkZUYxPcP3zDoAdsjLQyUEFEwNBnojffsrWtXWwvZrVG3BvxUWfoXFoIemIzZBR3dchks7+ 30N+pLzv0Pq6fFF2X2CREioQEU6u9ZSI0QUhXVxyjoBTLRnevuU+BOKb90OE9rtHZxNFKkdIcFvCY 0iBTtIbHpzJidWwd/VU+wg+DB3e1nBkUqzz+681wC9mH4sjUCyB8tmW0qAnc1AaOtsfRWMMqx6gco h5cNcMDHwQrxlAKs+W9Qc14+/gh6t51ElNBLBGLZWjnaQvksAwmhxVjKsZ7qqyNZZupTDL6qmnpHt IQaqbR8A==; Message-ID: <20230112143825.704223863@infradead.org> User-Agent: quilt/0.66 Date: Thu, 12 Jan 2023 15:31:44 +0100 From: Peter Zijlstra To: x86@kernel.org, Joan Bruguera Cc: linux-kernel@vger.kernel.org, peterz@infradead.org, Juergen Gross , "Rafael J. Wysocki" , xen-devel , Jan Beulich , Roger Pau Monne , Kees Cook , mark.rutland@arm.com Subject: [RFC][PATCH 3/6] x86/callthunk: No callthunk for restore_processor_state() References: <20230112143141.645645775@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 From: Joan Bruguera When resuming from suspend we don't have coherent CPU state, trying to do callthunks here isn't going to work. Specifically GS isn't set yet. Signed-off-by: Joan Bruguera Signed-off-by: Peter Zijlstra (Intel) Link: https://lkml.kernel.org/r/20230109040531.7888-1-joanbrugueram@gmail.com --- arch/x86/kernel/callthunks.c | 5 +++++ arch/x86/power/cpu.c | 3 +++ 2 files changed, 8 insertions(+) --- a/arch/x86/kernel/callthunks.c +++ b/arch/x86/kernel/callthunks.c @@ -7,6 +7,7 @@ #include #include #include +#include #include #include @@ -151,6 +152,10 @@ static bool skip_addr(void *dest) dest < (void*)hypercall_page + PAGE_SIZE) return true; #endif +#ifdef CONFIG_PM_SLEEP + if (dest == restore_processor_state) + return true; +#endif return false; } From xen-devel-bounces@lists.xenproject.org Thu Jan 12 14:56:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 14:56:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476257.738333 (Exim 4.92) (envelope-from ) id 1pFz0Y-0008To-Ok; Thu, 12 Jan 2023 14:56:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476257.738333; Thu, 12 Jan 2023 14:56:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFz0Y-0008Th-LE; Thu, 12 Jan 2023 14:56:46 +0000 Received: by outflank-mailman (input) for mailman id 476257; Thu, 12 Jan 2023 14:56:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFz0X-0008TX-AP; Thu, 12 Jan 2023 14:56:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFz0X-0002uC-88; Thu, 12 Jan 2023 14:56:45 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFz0W-0007Jk-T9; Thu, 12 Jan 2023 14:56:44 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pFz0W-0002Ga-SY; Thu, 12 Jan 2023 14:56:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=dno1s/MtE3UryhhZT0F6rt+55OZJnxvaD340+cMODaI=; b=CZb6/XM7d802a/yM20lm7sBrrd 7ozlB4ayivH15WJ67rRC0m23ck7QDHiG44MNKm0c/eOSQctBY/4/8OzQiDYqVgsbFYaDMIDsN4kK+ GYuH82mNvFQ1Wty/6mty7eJXw7JSvUM18qR9kST0ok2vAd/xa8SoY71Wsbi2v7uh4eqg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 175740: all pass - PUSHED X-Osstest-Versions-This: ovmf=e5ec3ba409b5baa9cf429cc25fdf3c8d1b8dcef0 X-Osstest-Versions-That: ovmf=fe405f08a09e9f2306c72aa23d8edfbcfaa23bff From: osstest service owner Date: Thu, 12 Jan 2023 14:56:44 +0000 flight 175740 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/175740/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf e5ec3ba409b5baa9cf429cc25fdf3c8d1b8dcef0 baseline version: ovmf fe405f08a09e9f2306c72aa23d8edfbcfaa23bff Last test of basis 175711 2023-01-10 21:40:39 Z 1 days Testing same since 175740 2023-01-12 10:40:46 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Gerd Hoffmann Laszlo Ersek jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git fe405f08a0..e5ec3ba409 e5ec3ba409b5baa9cf429cc25fdf3c8d1b8dcef0 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Thu Jan 12 15:04:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 15:04:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476265.738344 (Exim 4.92) (envelope-from ) id 1pFz8L-0001Ze-Im; Thu, 12 Jan 2023 15:04:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476265.738344; Thu, 12 Jan 2023 15:04:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFz8L-0001ZX-Fe; Thu, 12 Jan 2023 15:04:49 +0000 Received: by outflank-mailman (input) for mailman id 476265; Thu, 12 Jan 2023 15:04:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFz8J-0001ZR-Mc for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 15:04:47 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2089.outbound.protection.outlook.com [40.107.249.89]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 735551ab-928a-11ed-91b6-6bf2151ebd3b; Thu, 12 Jan 2023 16:04:46 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM7PR04MB7175.eurprd04.prod.outlook.com (2603:10a6:20b:111::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.19; Thu, 12 Jan 2023 15:04:44 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Thu, 12 Jan 2023 15:04:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 735551ab-928a-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KuldrY+qPLuZXonB87KKYRWXovbNal9Dwf3+kMZUVlxsHTiaV+wdkVsuzQCrof+NmNl/r/ECYLumwc14S8EkIIfcnF7vbib5Q+1aeFqje/WyE09e06t9vr+4GEy6lXhR/reDKHJYr35ti2dYRytaWWuQ7Fp6YqUHivNb5odtzBaWx7w6vGfCdfwLNHtgY/P+OT3qDrWO5alBtliYu+Oo7bEk8o3ah9adfPgThdj9N0QKBHmHrbUR+QA6EGn/Ab/udsMWC8txPBTC2GhiaFKXY339iwdmU0ui6UxkL2VX1YfSpAA8LlXVX0zLyT/BWH5+jkzXKjpIbGlgGa3jgNjmZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cON83jzL3+W5FDpvJD3UKo0qwkEWtPsnqG2BWdw41YE=; b=YumPUN26mEpJgNJYNPP2X12mQlJtgLIMU1hGWiUCw4Rgs9j1Qpuph4/eqG3a51wDelBt/2NFxjaROqDoFQY5loTtcYfmYUZFN0FREr+gq1pWkgnx5oeT5EPyYpUKrw6m3fR2da0hgD2F0S/OEAzZpqBMRDWWR59g//FcNnI1O3hRoIZAXZpBDYnjz1JoA9LGKdP3FnrA5IW+PIRqn0MwhBLtMzYyWwO690OUIofam5xj9KZt7t7SZRxU638eYcg+7hMN2kn39UtoiEOgO37EbJI79WLwfGPJzUi2Jzzk4KKByjofmRfwGz2bxwqvSk1cdSg6+qdXxNg6fxyH81Dz7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cON83jzL3+W5FDpvJD3UKo0qwkEWtPsnqG2BWdw41YE=; b=tF+sRzYy9XvM1IiHHIfDIqjUzXZvwZOZxvNEl7UkerhmLbXCBtnkjL7osJIe54uZl5Jtbyg5FNUlche9Y9lkXLMxnT2Le3udcmSHlcUMyA2OnadB1NonBVeZvvV6AABePg11ImuAqLKWQxFx8UVN5qIUvxbK+0+QAuaHOXWc3/dVwXN7CzHCVsw8jeZysv87GqZLOEOcQc4ERTJsg+Sy32H4oxRDzMX8+8epqKCBc6WqXfIk8GQg0GqCpFUuo/wyEDl0LwEyYBaCGhPCZc7uWsirLASXIbEBa9t9L5lOybN6e7HzvUj7m5aaDvQ1z/lTIK2j1F1+VthiMgvMKllhKg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9c757207-1f67-5cef-d314-e6959d5782da@suse.com> Date: Thu, 12 Jan 2023 16:04:42 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] include/types: move stdlib.h-kind types to common header Content-Language: en-US To: Andrew Cooper Cc: George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Roger Pau Monne , Bertrand Marquis , Volodymyr Babchuk , "xen-devel@lists.xenproject.org" References: <5a0a9e2a-c116-21b5-8081-db75fe4178d7@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0068.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9a::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM7PR04MB7175:EE_ X-MS-Office365-Filtering-Correlation-Id: 16e53b17-06c3-42b2-7e6b-08daf4ae5685 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XfUdTJyd1hwgFuo4WJHqDv1E8EGzsX52d5Q/AzHqIdUuYgyUVPKZlDa5I9XFV6YZEc36a/QBg7yniJuObbDvVMCTFoITVDxDB2dqn2dnfDeXKItfG6hOfXcGYe3wkn42YVyjkIQqq+DBjwyOhVfg+2YmXo1C2cYDtYKyAUWBRJ3yvQ7ve0AP/eEpJo+hM3xmFwdOEtNVDTvqtEHOh37W1ld+2Q9PEbRmkHnw70FgCOKbWk96KWmcGRA8H6geG1O3KGzBj5nlSim0/q43rIRgLYkRTTXMuYRFX9pCJk8KbPd1PbcQeTSE8UB4Lm4vjqqT0lXA9Wy6ZgzOP1ExlY0jQ+GDvFSgS1muGQm8eXxXV8e3p4axCLQNr4K2m2WoBSGubQ+5wdSPGWMWzPXg2yWf16jioFEvab9+7L3unFFQjpFr6vW93YcNiD3rsVxBrBY1DEbjFM/V2fTCkhiDZLCj0jJm8I5NDJwm9nCN8PvCTVuRI/KqzpcGCSWCpBUM7XIUfKk0vxCsi2tN9t8nINchjq6tksAy6EVCkqq7OVwUEhxAGKvocTMcwRxYe2ovLORhrQZVfA5yY0BmyE80HiTuDK8RrK788K1coStg8WaQX+LIDzzvMudf8uL8ObiT0TZzcSaNP21/4LfppLymOFqcGaTJLZaQpr3zv5gS84TszAufVSD4s056IGVA7/bqp5yxyYP7vTIXXyt+2RDMtXdtCNcc51UutU4DkKgOOHnJd0w= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(136003)(366004)(39860400002)(396003)(346002)(451199015)(6512007)(478600001)(186003)(6486002)(31686004)(26005)(66556008)(66476007)(66946007)(316002)(53546011)(54906003)(2616005)(6506007)(8676002)(6916009)(4326008)(38100700002)(8936002)(5660300002)(41300700001)(86362001)(31696002)(36756003)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZW1TMjZZMFFLbzFvOTJESDZzSGdmYUtweTB6Vjc3b0loN0wzOCtIQ0lkN1FX?= =?utf-8?B?c1lTbmVMQTJtTTMyQk9aTlRmd1RxbUZmazlMRmZQdURyR2R1MWdlV1FLeVh1?= =?utf-8?B?bytiMHRHeTRhdmRIdmhBamxTWm54T3lMd2Z6TEZkdWxqbWNkZ3FWTUJUSnU1?= =?utf-8?B?VGZUTG1ndDNDV1FpTWowVkI4NFpUS216UnV3a1lZblNhdDdIWVhtZzFBR2tL?= =?utf-8?B?dGkrZXI0UStwZXd4bXI5N1JPZ1lscU1NQXNDcXczeUFCRWdlM3IyeTNJT3Zx?= =?utf-8?B?UWNTU1hCb3g2dm45eEFHRTNMY1B4THlCZFhOMFljb0Rkckc2a1hkSk5BZ1Zr?= =?utf-8?B?Q2s5ZnJZZkFwZmg1c1czanJ0ajg1UGlVYXdMeTBqT1FlTE41dEZzMDFSMUc1?= =?utf-8?B?M1M0QlFBYm9HV3g0R1BpRkJMNXB2d1Y2NEJGaFdlM2ZPcTVuMnY0dmROOWxw?= =?utf-8?B?cTRGWU9xdjhRWmE4ekhOazRrcmszNTFEVVNaRFh6bTFuU0NZOXptQmgydWd6?= =?utf-8?B?OUJUUTFHY3lhWEhYWVpobG55cDg3SURaR0doU3ByMnliT0tuNllHTXpndTFE?= =?utf-8?B?aVBiNEtlME1DQ09zZ3JzR2UxaGZZdERzWnIzKzAyZTU5c0NJYlA0NDNJMDFw?= =?utf-8?B?ZWlNUnpWUW5TUnlyR2llUWNxR255OVpqSkZycytEY3BJUG9PMEM4UjErOFVh?= =?utf-8?B?UWlzb1NjRkhKb3FtVDdLY1I4dlVUWUg3YTBrVzZiME16cGxDQVdUcysvZzJm?= =?utf-8?B?a3dKU2h4dnIwOTF6cTBlbTJWeVNaVEVaQUcrVG5XS1piNHlEUTB5dVVaQkJI?= =?utf-8?B?YzhhYVhSN0lkY3RGcWRHWW9nVGhLY1BEdEp0c0c1ZVl1YjE1bW5LbVpVQ2lI?= =?utf-8?B?UzZsa1JxeEQ0Y0hianZzQ3NEcDJJUjhEQVphMW5UQWhQTWcza0xPM0RHOGFs?= =?utf-8?B?WEVoQXhMeEc4cHU2NCtzR0ZXZkQrUjlQclFUNG9MVkhHWEVucG4ySkgvK1hv?= =?utf-8?B?WW0wTHBndWVhaWdBbXVrU2FOdFJFRFpaUjd4MnZKMWdtb0R4VnIwejl6OE1N?= =?utf-8?B?TTAzcVZ5d2NIUTZwcE8xUWY3OTlHbnMvdXJ3ZlNDY0JGUzBpT3YzSXlGTTF6?= =?utf-8?B?bmJIQUt6VnlQcHkxU0NDYWo4a093Nmx5RE1zVlR3OXBFeEhlNnk5NnZLRGlh?= =?utf-8?B?MGtyaGtyWlB2UnFoZC9OamRJbGxKV1hoS1pxeEZzdmZhVmlsalphY2t3SmI4?= =?utf-8?B?NDhZQnhLR1IyNkU5NkJvbE1Fa1ZQeG1uNXJCcElqTUFoaWdhWm5RaXd3SlN6?= =?utf-8?B?RXpCU1UzQWliTGZxbDJPMFZVME9HK1V0RlJRRExuRnRjODUvNVlSa3h0azF6?= =?utf-8?B?SjFkZUt5d2dnSHdVY2F2T0RoVVZNYkZENGErcUw4aHFUSVMxN29MNUhVbk9S?= =?utf-8?B?NndIUGJYVTFPaUhHU1Z2aTcveGl6MFljN3RCcElLOUJYTGZjbWFacE4ybGgw?= =?utf-8?B?b2J6Z3NBU3J2dnhLcVdEVldHOU5XdWQ4Rkx1RGZ0WmdhVy9KVGh4c2xZdit3?= =?utf-8?B?Q2JsRUxDVTZoTHZkcnAyMnlkQitsNnllUUoxdCtsMnBUazBkTGZnUHgyQVdD?= =?utf-8?B?UXhMaXNvb3pDcUtHWXJOSUM0ZVBhZHVwdWlsUmh2VWk1ZklzZWh2SlZ3a1Ji?= =?utf-8?B?TWNMMDVmVzFRWk1iYzRUZGltdEFlV0txN09MUW9DazE1UW5nTThQbHhLN3B6?= =?utf-8?B?L3ljTExPbVF3U2tQdVZ2NHVwZHgzTDVCQ2tCaWxLWkZQRW8xYzRHMGhKQUsv?= =?utf-8?B?TUE0MTNVTWVjRVFZN1ZzWDNKcnFQNitXQ3QyODZPQU1wd2F0eFdjZ2tuV3Zl?= =?utf-8?B?QmdKckZ2ZlN3cEpSVmhPQXBsMVFoTUVmS0RxMEpxcTRYN2VyNCtBR05sQWpp?= =?utf-8?B?TDZGc0FTTXZNOU5FdzE3ZmczZ0lIdTFhOElPOUY5c05NOHhBYmpsTXpQcHR4?= =?utf-8?B?bEJGNGJGc0ljL2VkWHhWcDIvL3c1ZGRzblE5SWdIc3RjK1QzS1E3ZGZ5UDlU?= =?utf-8?B?SFZkczF6ZC84eVI2cjhyMENQU09tbEY5dWdsWStpRDI0WUd2SGV4TERJRXk0?= =?utf-8?Q?Mo9l8Y9iAXN2hbpljWmplcV0G?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 16e53b17-06c3-42b2-7e6b-08daf4ae5685 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 15:04:44.3797 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rat0xXX4wRDi3xtNtzCX4jO2rncDCwiffOZFJybCeGV8WgxD5ZeWAWFKAaUqm1x+ksAf4vi4WLORT/b3unQ3MA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7175 On 12.01.2023 15:22, Andrew Cooper wrote: > On 12/01/2023 2:01 pm, Jan Beulich wrote: >> size_t, ssize_t, and ptrdiff_t are all expected to be uniformly defined >> on any ports Xen might gain. In particular I hope new ports can rely on >> __SIZE_TYPE__ and __PTRDIFF_TYPE__ being made available by the compiler. >> >> Signed-off-by: Jan Beulich > > Acked-by: Andrew Cooper Thanks. >> --- >> This is just to start with some hopefully uncontroversial low hanging fruit. > > However, I'd advocate going one step further and making real a > xen/stddef.h header to match our existing stdboot and stdarg, now that > we have fully divorced ourselves from the compiler-provided freestanding > headers. Hmm, to be honest I'm not convinced. It'll be interesting to see what other maintainers think about such further moving away from Linux'es basic model. > This way, the type are declared in the usual place in a C environment. > > I was then also going to use this approach to start breaking up > xen/lib.h which is a dumping ground of far too much stuff.  In > particular, when we have a stddef.h, I think it is entirely reasonable > to move things like ARRAY_SIZE/count_args()/etc into it, because they > are entirely standard in the Xen codebase. Yet these aren't what people would expect to live there. If we introduce further std*.h, then I think these would better strictly conform to what the C standard expects to be put there. Jan From xen-devel-bounces@lists.xenproject.org Thu Jan 12 15:11:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 15:11:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476271.738355 (Exim 4.92) (envelope-from ) id 1pFzEf-00034T-8G; Thu, 12 Jan 2023 15:11:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476271.738355; Thu, 12 Jan 2023 15:11:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFzEf-00034M-5P; Thu, 12 Jan 2023 15:11:21 +0000 Received: by outflank-mailman (input) for mailman id 476271; Thu, 12 Jan 2023 15:11:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFzEd-00034G-Qq for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 15:11:19 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2045.outbound.protection.outlook.com [40.107.13.45]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5d58f2a5-928b-11ed-91b6-6bf2151ebd3b; Thu, 12 Jan 2023 16:11:18 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VE1PR04MB7407.eurprd04.prod.outlook.com (2603:10a6:800:1ab::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.13; Thu, 12 Jan 2023 15:11:15 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Thu, 12 Jan 2023 15:11:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5d58f2a5-928b-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bp0z1NsmVxnz3F9l+1K5a9hswCCRWph4PNgAi0cubC7sEx0FN2Sl9owKW6IKF14qgJZDMjJ8pnY3dKLVn4Pth2tU4BWAKTt7ozY1GFcvKiMIw2zeEtsxjxO9xdUjKRJSf6gcAUDNOY09ZHMaTUPjczg3HZUPD9jqfE4IwSA9ecYexpoakB7vAmRy0Zo3D94kKCIzXNf7NTaAYn5zt9cjQBzo+RIt2uh+TOgPuVCdVPhLMSv28EeKSFNNXjnLL2i/dbZAwW6AZnzxQ+MEsYXx+VMSNn7708vdOwCr/TP+pP9IwN0xSyd66hoP/HzJszAXD4TPFhsVQOSGxog9MohIbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s/iseJp9/k6CNN8jq1PHuSQPPN3JG/b5ahqOgQKVN0w=; b=EaoRJJsFgz6+nCJllJ3Iufrxrb6eDwDZBHIDBgC/HID25iEXO/YUd7yoDBBwuITVO2KP5f7BJVUddVzuJsoWuAmICmjtJfnkjFojHgZC+3J3OY0Fb17V4K8bsQXWj/vqoLHhCd/2QpiRxnzNZBdE87by1lTuzlMnWDgZiKJHZdCGl33cEzmlazYj1rd7aWNlSgpABS9ax9GP5gE1JJyQZG/uZWPtnGFDPtRgHF1ZvbXIjAzqch0CfKnS4eMBAFEVJiTrKkcVg4wOfyzs1kjZI/vnRNxTS0Xy6bvfBqggQ7l5v8fQxRusM38ILUSB9+/+4ecxohszrhWO6mGXPmsdfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s/iseJp9/k6CNN8jq1PHuSQPPN3JG/b5ahqOgQKVN0w=; b=iDy1uu6UppiEAsViEG57A7mItYWQTZ9PBZP0kVRc8CpJpGCBTE/lANEHY/iFXPZlnfaA8TvXrWoIdBEf1j+z5QJ8J26VwoT4u0x/SzsydSyMHGK7snL3pXS3eQmPL8L1yzbete3uGbAkU8/+3epT35FY7HpoWITrEQEIsqW/kK9KxN8qjuISwhU/tKLUxkE5Ug/MxSlcLlq6Q3xRYUi2zDzyIJYT+QxaS+SUi2IhqG/YzxuOYDkz5Nub+Wv4DZSVQabO6D99flPmHIQ7n83vUB4hPxB50YYhqTdby7TO7HHiB/9M2Wm4karFB4BAcTi5mOT8MtUhhQGzPvoxo9Q1Dw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <86519ac5-1f37-f3a9-f586-9c41f0ef66cc@suse.com> Date: Thu, 12 Jan 2023 16:11:13 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 4/8] x86: Initial support for WRMSRNS Content-Language: en-US To: Andrew Cooper Cc: Roger Pau Monne , Wei Liu , Xen-devel References: <20230110171845.20542-1-andrew.cooper3@citrix.com> <20230110171845.20542-5-andrew.cooper3@citrix.com> <97d16968-57fa-0114-1a93-4d0d253b8172@suse.com> <2e568a8d-02d6-5761-8b55-c37a8de1be0e@citrix.com> From: Jan Beulich In-Reply-To: <2e568a8d-02d6-5761-8b55-c37a8de1be0e@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM0PR10CA0072.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:15::25) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VE1PR04MB7407:EE_ X-MS-Office365-Filtering-Correlation-Id: 36098c67-ace9-4efd-7587-08daf4af3ff8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BzTzKzwUb/lEl/FKSiaS6PYSya7uHcK4pqt9uJvYlfLrWyhhmbsWxd2lY1kulaeHJ8Y1kAH44DdqXJrp2FiFQn47VGtcYeewhP6JbAgwO+ceEsZ2FaImhE40k8PyrpzgZYTl2f4Ceftg18Hb20mejcJcyF5LLldNyr1uFta8Mo0QzZQ/VoyQtjiXgWMyvofDZXkvzbI0QVzAsQqV8fhQJiOdIBs/dVM8hZjLho4Xz64XYq6F0UfcnVt+pxRfF0NgZhJxNCWrtD8BQU0umq18vqulpyKn1TcwvmTcCj3lrWetoDZcTl4b0u3aTtOkqgZRFCd+s8o7CJO1cfeFhozIJfjFCtqDuWtW+pxri6UUTRsvWkmWUiXKbhSLdAEEhryzctB4ztdID1WuoLS2GFf0EnOV2vF6RLPx69mkxidSmorwaJFyHOFP7xbxL2yEtMip6rnCbOYbdPtk8nDIO6rgE3pz/pBqcHxPlMD5k/BELHir0Htoyk9wyEbI/nQtDbLfMlUJzbhscglTbBx9JV6+9M0KkEoxD2JF6mwhFZNn6nyP6RqpPDoC+hBTR2clyX2Mpge/wP0AXPayhrJO6tVtGtjuMYeUN5ZNptH0jWVWPtBgFHEiFd4f1LYOLlx0qtglds/cvqqtTqk6yA3YGLKkQrUdRy280O2ONjaRUSY2nZ84sQkaUfTT23HvG/KaBg2k7O43UeGzcxLXJ2ThmKLjpvyeWcKMMgyG/jUMQAGV3uI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(376002)(39860400002)(346002)(136003)(396003)(451199015)(478600001)(6486002)(41300700001)(38100700002)(6512007)(86362001)(31696002)(316002)(54906003)(2616005)(66556008)(26005)(66946007)(186003)(66476007)(4326008)(36756003)(5660300002)(53546011)(6506007)(2906002)(31686004)(83380400001)(4744005)(6916009)(8676002)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TlBYdGdVL1E1ZjhiU0tqb2V6MHBzRHd0emRuT0Z0LzRWeW9iMjdUN3Y0R2VH?= =?utf-8?B?b3pSYWF6SlFyK20vYk1SdUJxYUVpdTRtU284M044ZE9VWWVpNS90Z3puaEMv?= =?utf-8?B?Ui9RK20wQjJFcEFwKzZqQkRBd21MaWhCUWUwb2IrdkNzUzRIdlFFVk5WZnRV?= =?utf-8?B?VUNseEJhck1QWWNpWll2c2UvWEFvWjFtVk1nSmhMaWdQNjZoN3dGQmlmdS85?= =?utf-8?B?U3IvcGxCMzVlMktNQ2FsUDBNRkZET2VPenR6WjhJdjdWTmNBVks2NFRTZzFE?= =?utf-8?B?Mk9pVWlUcmR5TWpxZzZ4VWI4eHlVNGQ4MmVUSi9yTzFxVjlZeFRSZWdFQW5p?= =?utf-8?B?RGd0QWpiSnd1Q2NieEtYRWNsTW5LVG84a1pGeWkzMEcrK0piUDZualhQakF5?= =?utf-8?B?WVIrNGFMUkROVk4yZWFJbjJoUENqZHBCQ1B5NlFWQUdQV2MrYkhHL00zb0tI?= =?utf-8?B?VnZZRlF5djE1dWh6NE80WHhoMWUzZ2hsUHFMT1R4SWIrMzV1SUM4blhFK1dE?= =?utf-8?B?elJCVHRjSnd3K3ZvSE1BcDhKQ3dmUE5zOEtHbWllUzZPd3BZU0kyYlQxM2lD?= =?utf-8?B?YmpJbVFMMTZPTE54aTYvRGt6aU9qdVJPZzlsM0Z1QVQ3VUdRTlk1S3NPc1lF?= =?utf-8?B?QW9KUWpGd3BqUE9BcGFkbTV3N1BzMVAwbXU1QzB6eGhocFdFaTNQckVsbTA2?= =?utf-8?B?eW5EQkMvUVNzMHdaNkl5aXU3b04zc2pWeEJMMmhVV2RhY3VONHpkU1lTMVhS?= =?utf-8?B?UE1iU1RIcDcwWmc3VTg4NlpjcWZVZTZtb3JOYTRJNzBWMFJBMVZWdUw4MlRx?= =?utf-8?B?cnRsZW1DK3BPWm1VSDBETGN4UC9nY1ZSSzBvZlVGd0Vaang2YU9aemp5aFox?= =?utf-8?B?Sk1MSkFMR1hmTVhGdUNkeDZ6N1VGNUtZWG92cjJPbXVwWkYrVkNIeEc3dzhY?= =?utf-8?B?WVRNT2htUFFQQ0pUenRBeEV6bm5DNnp1YXcwL3hOMG53L1phM1FiYkxPMzdk?= =?utf-8?B?N2t1cUF5UkJ3N2N2QWEvclBIaW9DODZ6azU5YnJZWFVJeFQzTERGQWJQUGpQ?= =?utf-8?B?ejFmTHl6bmVyaWE4b1Joa0pvK3NQeTlDZFhXNitEOTZaVm4rQ1JrOGF1R3RQ?= =?utf-8?B?M0d4RjZQSDhyYm9PU0lId2JMV1lkekdYQXNWVHU3cWZKNkZMcUdWNm94dWc4?= =?utf-8?B?ZWxHK3FMSTlIMVIwS0xyVDNkR0lUWm9EWkg2MExkTVNMa296VlJ1UWd5dkxO?= =?utf-8?B?bmlwbWhQYU9WNHo2ZGFybnpRS0UwbTRoWUpZdHZ1SUo3R2Y2aXFjUDNkaWdh?= =?utf-8?B?SlhMMC9zcjNGMG9MOElyc0lqbFpkaHhKbWxoV2d6dkFWREFweFc0V20yQ0E0?= =?utf-8?B?WWNZS3I3TW1CUm1tN1drdWZqSmgxeFVhMHI0UWZ6NTR3aFRDVCtMN0htK0hx?= =?utf-8?B?bG9iTEVKVFcwMDZHc0YxMVRuMFBRczZzTDJwMTA3d3NZYkNpdlcrUklHU1lN?= =?utf-8?B?dmcyRjRpSXdvSklkU1lxSEM1NzduanQ3d3lxMndJUkJIamNnVWZTYjd3bDkx?= =?utf-8?B?SkxsZ1ByemdQZnlKWkEvQ09yLy8zd1NscXZNSmVLWlhGMDdYQnBvQUgyK3M3?= =?utf-8?B?TlpHYVpuQUhBS0RlSkt6b2xwMUxPY2diTWc3NWtKb3JIcnN3N3JMWVEyT0Zz?= =?utf-8?B?SXdvK1RTUi9JcnprQkR5eFJGNWRGWUlXK2RPY3pqOG9wd2R4TWpGVklYYlpR?= =?utf-8?B?OVRWczhZUXd1dUFUMUtxNTQwZkowVE50TWR5amJCdjY3ZUc4ZjhPTXVQK2Jp?= =?utf-8?B?OFRnUytPRjBrWmpMVXJtZlZHMEx2UTBFNFBmRFNWaWVQYjNyOFJpN3VLaTgw?= =?utf-8?B?bUVwS3psR0hSV3VCck83dG5DNHRUS2VWbmQ5VzUzOEZoMEYrb2JxcEhMWFhL?= =?utf-8?B?bDhWbGN0dTZyemtEbUN3UTNrbWtZQ1FxS1Y2MnVuOTlOdVl0ajlJaHVNOEVN?= =?utf-8?B?SGlZMmlGdkFOaVpBRkw2SmVxN1czL0NlbGw3d21vZzQ5bzFUYkNxdEpsdERM?= =?utf-8?B?QkVWMDZRYjA0eDlITWVLQ3NHQldidWtoZGRYRXlQZXhKRDZrT0dnVThMTjB6?= =?utf-8?Q?otb1p2JdV72jL9SSEJz5o8zsY?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 36098c67-ace9-4efd-7587-08daf4af3ff8 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 15:11:15.7610 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Mark2qVHJWiUqsRBhXbosdB/otXq7Ac5iATBfQGSDH9eu9gPtQHM8IEccRKmKWI/qqwH+rzCOIY2SnlJZAHbOA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7407 On 12.01.2023 14:58, Andrew Cooper wrote: > On 12/01/2023 12:58 pm, Jan Beulich wrote: >> Do you have any indications towards a CS prefix being the least risky >> one to use here (or in general)? > > Yes. > > Remember it's the prefix recommended for, and used by, > -mbranches-within-32B-boundaries to work around the Skylake jmp errata. > > And based on this justification, its also the prefix we use for padding > on various jmp/call's for retpoline inlining purposes. While I'm okay with the reply, I'd like to point out that in those cases address or operand size prefix simply could not have been used, for the insns in question having explicit operands which would be affected. Which is unlike the case here. Jan From xen-devel-bounces@lists.xenproject.org Thu Jan 12 15:17:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 15:17:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476275.738366 (Exim 4.92) (envelope-from ) id 1pFzKC-0003ky-Sl; Thu, 12 Jan 2023 15:17:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476275.738366; Thu, 12 Jan 2023 15:17:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFzKC-0003kr-Pj; Thu, 12 Jan 2023 15:17:04 +0000 Received: by outflank-mailman (input) for mailman id 476275; Thu, 12 Jan 2023 15:17:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFzKA-0003kl-Tc for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 15:17:02 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2089.outbound.protection.outlook.com [40.107.22.89]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 29ceb453-928c-11ed-91b6-6bf2151ebd3b; Thu, 12 Jan 2023 16:17:01 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7752.eurprd04.prod.outlook.com (2603:10a6:20b:288::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Thu, 12 Jan 2023 15:17:00 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Thu, 12 Jan 2023 15:17:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 29ceb453-928c-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K6GMulc/9imHLAvIEFRdJHiQqCGubAwSQuruJXVbrI4SnJ2kHRndP17nqIfJVIrpXwlouhhIwiRyBdWUVSlatL+shbcPbeCbNHzrHlwlOkmfPGZtg6va2GidE8G6y8/lXbMRZEZdLZ/FrUoDBIYgpbUwlq3LnLBsYFVCLOKPpp+PTKbhvbFuC5D28y2jTn404l1GR7VvxjGN/e2xX6Ztf+cVmoJfSOaU5nFxJgwQj3IElX9eRiYm2rgiLsbPBfSBqQH32atgfCMbAiA9/xvzigVlxeYtsuQviCShv7YC1xTtmn46UZ6l7PCbfTpgUBM2M655YtvV7yAWB/wC+yay7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SkSZomSlQTVH2dS4wNry2udyFyEzoc56R83Z8NYcgRc=; b=WCt3S0F2fXvcx27oQvVQeZ80iW2B770cxgy6eNplXeFDh6VRZdNo8UvkRk/RuVy96RhtU1ikmPcTal83lWxyslcPA2b/WPp5Tcuz5tvESQcofgsKBrkZhTcR15QU/IFhHrAfiaVVbLv8yx1mLCoeTHdKNR/g9qYdbh12ktDhK4g9gxRbtCRgQIEAdyJV2FwjGzQ+7Cs3YY3GQ7kV5MbZfpV2bhQBml7VfTuNbHAkhlDiE8gmAJzsrYONEiouQhQ7L7E3EJ7BFDthGnZyGSz8yhcFU3fWTevQi/XpHrd4ZY9FbKpP4xhpMA7N9I8ZbLiQSrS18E5ZUcvSdWhhwZQ/nw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SkSZomSlQTVH2dS4wNry2udyFyEzoc56R83Z8NYcgRc=; b=ErypFlPdepOya6zA8kF1bQFbDunx9fjuBj02rPJWK/vqnIlCd+uG3SsKx1vzA5Y7b/vZ4bb1Ydkd3UAm3FfCZykBs51PLmRSsV52ddoybOUeinblCd4tjGdBhy5vEvkCnYq+5ccNU3LX4pJ1U7ItsJtDX1Kea+nq5fcdDnB/k4nXlYh73Pxvk/CbgVDagHaxb2t93T0khrv6zbdMWX93seFke61FKZsBOuUEAH/lSneBYpoy0WHVNKYUSicbgVCOtRsa3ZMsnR0BqZ9jmMXXySn600AmvlYGqfK6z9NE4CxbEWTl/zbdL034WNBg//kJXrNBOX0wT+s+MfBAMGe+/A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 12 Jan 2023 16:16:58 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 6/8] x86/hvm: Enable guest access to MSR_PKRS Content-Language: en-US To: Andrew Cooper Cc: Roger Pau Monne , Wei Liu , Kevin Tian , Xen-devel References: <20230110171845.20542-1-andrew.cooper3@citrix.com> <20230110171845.20542-7-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0080.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB7752:EE_ X-MS-Office365-Filtering-Correlation-Id: 289b5a13-5a7a-42ac-682e-08daf4b00d5c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XesXdIuaUVoPID95j7c80M+UI4oGKcDgQFvHhO64GYw7P7ZwcHwegw3bqzlvRz2/qjvpPfOeXGaU8pRlD8DvJOekUK9SFK4JIKZh2JvQB2OpQtTuGIvtCT1VaV4NiCqNJ4uhN+Y/JV7pqCGNiMl363o+XxzwQJ6ZrDIad/3sLAgTT2tkdIu7VdjBOvVCWDXahZ1Y4IirT3gR8lZnbsbfNxeA8nYQBTOZVo9BGXtZ5y9tF4q30hjRxfPhSiuovTEr2FxedTv+fB/BokeKU/WeWnDdzQBPwts7HU3FLfby3XbmbP4CfZ2HPnS1vE1Bo+WforkNyk/AIvBekCykkKrA/2KCPJ/LqbNu1hilkx58fmBUIcr8Pg1U0UN0RYrE7G2xdmiOvyFWJKOl9I0K5bQz2yqdvFW+lTplYdCCTlFE23ZGhzxQppe7yudMMVKgXr+gFEaTJRqARQJpP1OAxU06W8samFM6ZbgVgfprJ9pkFzPJuJabwqFzue62qLEOeFnWdU7VV98x4ekW0R6MaTQn2AIXdwn015NPbRts0E8KMFnKZzWiaMdEBj3exYpP0CMvxh+LzYAjuYejPOlVV9sUWfV1ic2puB4S7fU70i987HWO7JMV0npqdy/Tia9HurWK7bpYU/AMKl0XMIlaTsxIk02KM51mbHzfj76pN3MwSwyJp22sxEjqjOTmSUKQa8r43+VeSBSNTnyOD7As7AEoHNstxbIVrv9FrP18S947Ojk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(136003)(366004)(39860400002)(396003)(346002)(451199015)(6512007)(478600001)(186003)(31686004)(6486002)(26005)(316002)(66556008)(66476007)(66946007)(53546011)(54906003)(2616005)(6506007)(8676002)(6916009)(4326008)(38100700002)(8936002)(5660300002)(41300700001)(83380400001)(86362001)(31696002)(36756003)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YjJRQXZ2OEl6cEN2WEYxWTl5NFk3aHlESVlCeGZtQTFtZnFCTFJ3aG9wR21Z?= =?utf-8?B?KzlKZ0VEa3Q3cERjWlNzSC9qR3lXK1pnWEIyMDBmT29PdTZPOGpGSW9tN1ZM?= =?utf-8?B?N2c3bDNocENreEwyNlNVOUhYK0diY09VVDE3T2tEYUhrUlBKTnFheG5qa3Q3?= =?utf-8?B?dVNxbVZmaFdoTzgzRm9oNGlIbUROQzBUTHBUNlN5YXpnbGM1UUhXZVJwa2Vp?= =?utf-8?B?akd0dTZXRlVFUmg2eTRwRDNIRHQ5RjVHOUVKaW9Gc2RpZFFrWkJIendYV1Zy?= =?utf-8?B?VXh3Q1ZzdmUxZldqTHZ6UmFUWDk0aW9FM1RQOWpZNlJONGZlb3dCUGgyYVYv?= =?utf-8?B?SUV1a2piU050dXltWXdDMldsWDFQSEJ3TTVhQWRIWnlTZURZd1hPS0VLL2l2?= =?utf-8?B?bm5oRXFDWmVKM2NpcVBCaDBVQXlGNU1ZZ0E0MXFoNFpUTG5jVG1kbTg3WDFl?= =?utf-8?B?MkxZOGNEUnBTVUhMaGd1cUczVnBKV1ZMcjhIOHFXZk15RFJuVkRxT2lEeEY5?= =?utf-8?B?U2pYY2xOa25yd1BqZ2hqY05qYTgrNFR3RW1CaVZYaXFDc2JFM1FaVnd0UWRT?= =?utf-8?B?dW01a2tkMjJFM2NoL20xK280MDRoc1B4bHNGRFJvQko1MnBkMVF2c3lzR0xx?= =?utf-8?B?NVd3dzY2d0NEd2pLUVFiTEtWcTdsTzF4bW9JSU9xL252ZE5QYTZMdmwzMmRx?= =?utf-8?B?UkpqZmJrRmkwOEhKZ2JQekhXUE9NbjBhaW1ZcW94dU1hR2JBOGhIQk96Tjdi?= =?utf-8?B?Z200WFBSUUY1UG1YcFU3bG1lamxJYkNGSUZhL045SFpKbHdldnBxWlVwY1dL?= =?utf-8?B?Zk02VzdBRldOZEdZMEVTUS9QY1dVTGQ5YzFTRmlYQkdnZ0Z5RVdXWVRPV3A3?= =?utf-8?B?TUJ5M3N6M3JyUkxDQXZNeHF3d1dyYTJ6RU9MTEh1TG5DaFBpK1RaUXJvcXhy?= =?utf-8?B?UncrL3BrU0pCRUx4QU0yKzhtMEJiU1l4MEw4OWtPZmdQZDZGanlYZjVGeHNW?= =?utf-8?B?NEFBR081OHlRdm1JKzRjVXRJS2IvaFUrcWFXSlNYTlBMZHpGWWVQR0NqblR3?= =?utf-8?B?Rld1Z3lhajNQSTZ2SXNuUXhBdHVYYm5VYVRzc0M2NndvVHdsQngwdUVPdGJj?= =?utf-8?B?NVJzc000V21qMVFIY2J0RUsxTXd5RisxN2s4MHppQVdSRmNjeGVSdGlyNmJl?= =?utf-8?B?eisyUENFRWxrcnBBUGhFWTAycXRSNWdIRkN4cUtoVUp4dldZVDZlNm04b1RF?= =?utf-8?B?NVFhaERFZWJvS0hzNUlLNm8xZW1FOHFBSS9kUmdOMUYzdWd3c2dqUWkrek5o?= =?utf-8?B?T2ZzUVBsMTYvOG1VaENoa3dVdzJGSVpvRjhSRDh6U1BRbktuRUtmdU85OHF4?= =?utf-8?B?Y2hidmhjUEI2NUkrUXpKRlVtSFFlTk4ydWFRcEpsaGY3ZENxRHdrWGdScDhK?= =?utf-8?B?ZmRUTkZBMjNzQUxweUtBY0lCb1h5WHFlR2pmUmJhYkg1RDZ4RDQrVHQ5cTBL?= =?utf-8?B?YXloSTlWVE5TZzI4L3hYQUorcElXUURuMTE5Ui9IZlhIb2o3OTlxTk1TKzMv?= =?utf-8?B?cmw0YUZGdmRhVm14eDRocDZsVXAwRk00NWRnOE1KQXU0d3pNVmM3YUsvN3VO?= =?utf-8?B?R1JPc2NnUXVvRHdSd09maFlWUXhCQjAvY01XaUwyejlFZ2NFYVl6alUwZEN2?= =?utf-8?B?VHJVMmhUanljRTdnM3FiOFNtdmljTGp3MEpaWVZkL1NERitxVjI0ZVpMQktJ?= =?utf-8?B?V2V2b1pmMm84ajFWaWdCblc5eXhIemlOeFJEekx6aFFDZnRPOUEwOUFKa05C?= =?utf-8?B?cUwzMEJESk03TFd2Q00yNjY1WS9tZTZzUzhvVVVOaDB0TG9jMjEyWlpRYjg1?= =?utf-8?B?OGZ4VUo3c3dtL0x4c04zZ3Z0Y25tb1EycmpUb2ZjZUVLZzVULzJrNmZYako2?= =?utf-8?B?K0pBZ0trcUszZ1pwdDlla09Kd29OVi9OVzBUSzNuVnJSYW1JZk96OWZVbjNl?= =?utf-8?B?cGxBTzR1WURZYXR0V0dKZ2NBdzE5ZjlNWUQ3Q3VuTTVIL1dPekNwYlFISDk1?= =?utf-8?B?U0xSU3NmQVZFbzZPQ0lQeFhXbjl2Mjh3RUZUeFpSSTd5TzFjY0FScE8yVnVr?= =?utf-8?Q?fuRZWriSpLQ4FjPyIY06iu2Qb?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 289b5a13-5a7a-42ac-682e-08daf4b00d5c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 15:17:00.3490 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nI6nFM5Hip2RLath4XYehRJVREFJDiJHHJeVVJfcM+HLGckjr6DTYwtRRwa2XHCTFcPwJvHj13+QnkhLEU+Vhg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7752 On 12.01.2023 15:16, Andrew Cooper wrote: > On 12/01/2023 1:26 pm, Jan Beulich wrote: >> The other thing I'd like to understand (and having an answer to this >> would have been better before re-applying my R-b to this re-based >> logic) is towards the lack of feature checks here. hvm_get_reg() >> can be called from other than guest_rdmsr(), for an example see >> arch_get_info_guest(). > > The point is to separate auditing logic (wants to be implemented only > once) from data shuffling logic (is the value in a register, or the MSR > lists, or VMCB/VMCS or struct vcpu, etc).  It is always the caller's > responsibility to confirm that REG exists, and that VAL is suitable for REG. > > arch_get_info_guest() passes MSR_SHADOW_GS_BASE which exists > unilaterally (because we don't technically do !LM correctly.) > > > But this is all discussed in the comment by the function prototypes.  > I'm not sure how to make that any clearer than it already is. Okay, and I'm sorry for having looked at the definitions without finding any helpful comment, but not at the declarations. Certainly sufficient to confirm that my R-b can remain as you already had it. Jan From xen-devel-bounces@lists.xenproject.org Thu Jan 12 15:21:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 15:21:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476283.738377 (Exim 4.92) (envelope-from ) id 1pFzOb-0005E9-IL; Thu, 12 Jan 2023 15:21:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476283.738377; Thu, 12 Jan 2023 15:21:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFzOb-0005E2-Fe; Thu, 12 Jan 2023 15:21:37 +0000 Received: by outflank-mailman (input) for mailman id 476283; Thu, 12 Jan 2023 15:21:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFzOa-0005Dv-4b for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 15:21:36 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ccad159d-928c-11ed-91b6-6bf2151ebd3b; Thu, 12 Jan 2023 16:21:34 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4D54D40269; Thu, 12 Jan 2023 15:21:34 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E045513776; Thu, 12 Jan 2023 15:21:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 1KxjNX0lwGM6IwAAMHmgww (envelope-from ); Thu, 12 Jan 2023 15:21:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ccad159d-928c-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1673536894; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=2n0IdQPvR+Gxy3g7DvPKITwTHiT/5QBMjcXvwvG5gq8=; b=aBmyfXqLewedueE1l8HgnS8oOWeLEQsBebQ3+JmtzpZzl9WKiSECnoSe2djtAFYUFg2yN/ acxUR6stqti7Qe76GIxbS5WMojGnRTf19LbpN8XK+a9njRm4QPpWpJ8Z+aGoVqnwra2MEk bbQFMgCf9WV/aQ3RDAqPmCnv9Vf1osI= From: Juergen Gross To: linux-kernel@vger.kernel.org, x86@kernel.org, virtualization@lists.linux-foundation.org Cc: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , "Srivatsa S. Bhat (VMware)" , Alexey Makhalov , VMware PV-Drivers Reviewers , Boris Ostrovsky , xen-devel@lists.xenproject.org Subject: [PATCH] x86/paravirt: merge activate_mm and dup_mmap callbacks Date: Thu, 12 Jan 2023 16:21:32 +0100 Message-Id: <20230112152132.4399-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The two paravirt callbacks .mmu.activate_mm and .mmu.dup_mmap are sharing the same implementations in all cases: for Xen PV guests they are pinning the PGD of the new mm_struct, and for all other cases they are a NOP. So merge them to a common callback .mmu.enter_mmap (in contrast to the corresponding already existing .mmu.exit_mmap). As the first parameter of the old callbacks isn't used, drop it from the replacement one. Signed-off-by: Juergen Gross --- arch/x86/include/asm/mmu_context.h | 4 ++-- arch/x86/include/asm/paravirt.h | 14 +++----------- arch/x86/include/asm/paravirt_types.h | 7 ++----- arch/x86/kernel/paravirt.c | 3 +-- arch/x86/xen/mmu_pv.c | 12 ++---------- 5 files changed, 10 insertions(+), 30 deletions(-) diff --git a/arch/x86/include/asm/mmu_context.h b/arch/x86/include/asm/mmu_context.h index b8d40ddeab00..6a14b6c2165c 100644 --- a/arch/x86/include/asm/mmu_context.h +++ b/arch/x86/include/asm/mmu_context.h @@ -134,7 +134,7 @@ extern void switch_mm_irqs_off(struct mm_struct *prev, struct mm_struct *next, #define activate_mm(prev, next) \ do { \ - paravirt_activate_mm((prev), (next)); \ + paravirt_enter_mmap(next); \ switch_mm((prev), (next), NULL); \ } while (0); @@ -167,7 +167,7 @@ static inline void arch_dup_pkeys(struct mm_struct *oldmm, static inline int arch_dup_mmap(struct mm_struct *oldmm, struct mm_struct *mm) { arch_dup_pkeys(oldmm, mm); - paravirt_arch_dup_mmap(oldmm, mm); + paravirt_enter_mmap(mm); return ldt_dup_context(oldmm, mm); } diff --git a/arch/x86/include/asm/paravirt.h b/arch/x86/include/asm/paravirt.h index 73e9522db7c1..07bbdceaf35a 100644 --- a/arch/x86/include/asm/paravirt.h +++ b/arch/x86/include/asm/paravirt.h @@ -332,16 +332,9 @@ static inline void tss_update_io_bitmap(void) } #endif -static inline void paravirt_activate_mm(struct mm_struct *prev, - struct mm_struct *next) +static inline void paravirt_enter_mmap(struct mm_struct *next) { - PVOP_VCALL2(mmu.activate_mm, prev, next); -} - -static inline void paravirt_arch_dup_mmap(struct mm_struct *oldmm, - struct mm_struct *mm) -{ - PVOP_VCALL2(mmu.dup_mmap, oldmm, mm); + PVOP_VCALL1(mmu.enter_mmap, next); } static inline int paravirt_pgd_alloc(struct mm_struct *mm) @@ -787,8 +780,7 @@ extern void default_banner(void); #ifndef __ASSEMBLY__ #ifndef CONFIG_PARAVIRT_XXL -static inline void paravirt_arch_dup_mmap(struct mm_struct *oldmm, - struct mm_struct *mm) +static inline void paravirt_enter_mmap(struct mm_struct *mm) { } #endif diff --git a/arch/x86/include/asm/paravirt_types.h b/arch/x86/include/asm/paravirt_types.h index 8c1da419260f..71bf64b963df 100644 --- a/arch/x86/include/asm/paravirt_types.h +++ b/arch/x86/include/asm/paravirt_types.h @@ -164,11 +164,8 @@ struct pv_mmu_ops { unsigned long (*read_cr3)(void); void (*write_cr3)(unsigned long); - /* Hooks for intercepting the creation/use of an mm_struct. */ - void (*activate_mm)(struct mm_struct *prev, - struct mm_struct *next); - void (*dup_mmap)(struct mm_struct *oldmm, - struct mm_struct *mm); + /* Hook for intercepting the creation/use of an mm_struct. */ + void (*enter_mmap)(struct mm_struct *mm); /* Hooks for allocating and freeing a pagetable top-level */ int (*pgd_alloc)(struct mm_struct *mm); diff --git a/arch/x86/kernel/paravirt.c b/arch/x86/kernel/paravirt.c index 327757afb027..ff1109b9c6cd 100644 --- a/arch/x86/kernel/paravirt.c +++ b/arch/x86/kernel/paravirt.c @@ -352,8 +352,7 @@ struct paravirt_patch_template pv_ops = { .mmu.make_pte = PTE_IDENT, .mmu.make_pgd = PTE_IDENT, - .mmu.dup_mmap = paravirt_nop, - .mmu.activate_mm = paravirt_nop, + .mmu.enter_mmap = paravirt_nop, .mmu.lazy_mode = { .enter = paravirt_nop, diff --git a/arch/x86/xen/mmu_pv.c b/arch/x86/xen/mmu_pv.c index ee29fb558f2e..b3b8d289b9ab 100644 --- a/arch/x86/xen/mmu_pv.c +++ b/arch/x86/xen/mmu_pv.c @@ -885,14 +885,7 @@ void xen_mm_unpin_all(void) spin_unlock(&pgd_lock); } -static void xen_activate_mm(struct mm_struct *prev, struct mm_struct *next) -{ - spin_lock(&next->page_table_lock); - xen_pgd_pin(next); - spin_unlock(&next->page_table_lock); -} - -static void xen_dup_mmap(struct mm_struct *oldmm, struct mm_struct *mm) +static void xen_enter_mmap(struct mm_struct *mm) { spin_lock(&mm->page_table_lock); xen_pgd_pin(mm); @@ -2153,8 +2146,7 @@ static const typeof(pv_ops) xen_mmu_ops __initconst = { .make_p4d = PV_CALLEE_SAVE(xen_make_p4d), #endif - .activate_mm = xen_activate_mm, - .dup_mmap = xen_dup_mmap, + .enter_mmap = xen_enter_mmap, .exit_mmap = xen_exit_mmap, .lazy_mode = { -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Thu Jan 12 15:44:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 15:44:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476290.738388 (Exim 4.92) (envelope-from ) id 1pFzkA-0007pF-9g; Thu, 12 Jan 2023 15:43:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476290.738388; Thu, 12 Jan 2023 15:43:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFzkA-0007p8-6k; Thu, 12 Jan 2023 15:43:54 +0000 Received: by outflank-mailman (input) for mailman id 476290; Thu, 12 Jan 2023 15:43:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFzk8-0007p2-Io for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 15:43:52 +0000 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [2a00:1450:4864:20::62c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e922c277-928f-11ed-91b6-6bf2151ebd3b; Thu, 12 Jan 2023 16:43:51 +0100 (CET) Received: by mail-ej1-x62c.google.com with SMTP id tz12so45760565ejc.9 for ; Thu, 12 Jan 2023 07:43:50 -0800 (PST) Received: from [192.168.1.93] (adsl-67.109.242.138.tellas.gr. [109.242.138.67]) by smtp.gmail.com with ESMTPSA id j18-20020a17090623f200b007e57d6e3724sm7580527ejg.116.2023.01.12.07.43.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Jan 2023 07:43:49 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e922c277-928f-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=o9NtSevycsjj3do/s9tO6Gqq4uhlTyGcoWM/DnHLgUU=; b=UtVeQSyPLsjiHMFMnXBIya5S7d2ZSbJ4NG3qwCqILLfAbLbgJbHCXnNlpGz/OLTNFE Mdt51sr140T6cSpVFfZJif08HRem9DTkFZz0uGGm15GvANKgCAuUcJ8/jcgKy061VWfd 0vu2XI5VdDKlFaVzXNoKRsEaqnoIMZLnszhLhXPAe7eVsZHvublFqeEXbte8JsrfFcDP ZbH3EMFl4ZLdVfPwwsKJzvFZ6/xPjBScCGrDL5Y82q7PkYHAfO1lXfU92nfJEfQa9m4q BWxf4jOvhYctDEXiN83mrKb8ELT8ii0nxtwUOSw8JOTz6A0J89i5/H6pLNNCriX4spl7 qGEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=o9NtSevycsjj3do/s9tO6Gqq4uhlTyGcoWM/DnHLgUU=; b=YHJxKs8lucdE7ziG/t3amQ81VDWobbzpwroqoRObMOXhGLQEXs9AJCrb7jhSEBjV1u /gmBe3j59AJr96bUL5XqMZQpdW0PzOxI8r77rhRVAzBldCwYMyUV4pJ5frjw78QoC7fC zm1HKf0kBy4ui6TlMvwinBg917cVRvYC6MK65kgtC3DNgOaG5cITBtOx/ejpwiPqiAtb eVH8q8esfevw+j1DIXxkgzpScT6MKt7IbDjvUnRJM29YCTEK+TzxPrwExeLkxnz/9//Q ECQ99MKFcBv2subvsYY8Xci4WEnkMiKf5peOQtMuojgO/DNMyIyt1Qyq1sP80IxtcQ1y ilbw== X-Gm-Message-State: AFqh2krIPBxzLOkJSP/+CcXUY885jZSex9p6sPYHr5D/pG/lbYAV8dma rhl1Kf1NWK0FlCLKmIdQas4= X-Google-Smtp-Source: AMrXdXsPNYwUyi85rQM/lyEaj2aDJORIlGX5NvJehzCeNpnyEwkWbCwuzVeDx07ha8qnOcReK2Wb2Q== X-Received: by 2002:a17:907:2587:b0:7c0:ac4b:8b9 with SMTP id ad7-20020a170907258700b007c0ac4b08b9mr55048171ejc.14.1673538230393; Thu, 12 Jan 2023 07:43:50 -0800 (PST) Message-ID: <4bc3f2f6-9bf4-5810-89e3-526470e72d85@gmail.com> Date: Thu, 12 Jan 2023 17:43:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v2 3/8] x86/iommu: iommu_igfx, iommu_qinval and iommu_snoop are VT-d specific Content-Language: en-US From: Xenia Ragiadakou To: Jan Beulich Cc: Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20230104084502.61734-1-burzalodowa@gmail.com> <20230104084502.61734-4-burzalodowa@gmail.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 1/12/23 13:49, Xenia Ragiadakou wrote: > > On 1/12/23 13:31, Jan Beulich wrote: >> On 04.01.2023 09:44, Xenia Ragiadakou wrote: >>> --- a/xen/drivers/passthrough/iommu.c >>> +++ b/xen/drivers/passthrough/iommu.c >>> @@ -82,11 +82,13 @@ static int __init cf_check >>> parse_iommu_param(const char *s) >>>           else if ( ss == s + 23 && !strncmp(s, >>> "quarantine=scratch-page", 23) ) >>>               iommu_quarantine = IOMMU_quarantine_scratch_page; >>>   #endif >>> -#ifdef CONFIG_X86 >>> +#ifdef CONFIG_INTEL_IOMMU >>>           else if ( (val = parse_boolean("igfx", s, ss)) >= 0 ) >>>               iommu_igfx = val; >>>           else if ( (val = parse_boolean("qinval", s, ss)) >= 0 ) >>>               iommu_qinval = val; >>> +#endif >> >> You want to use no_config_param() here as well then. > > Yes. I will fix it. > >> >>> --- a/xen/include/xen/iommu.h >>> +++ b/xen/include/xen/iommu.h >>> @@ -74,9 +74,13 @@ extern enum __packed iommu_intremap { >>>      iommu_intremap_restricted, >>>      iommu_intremap_full, >>>   } iommu_intremap; >>> -extern bool iommu_igfx, iommu_qinval, iommu_snoop; >>>   #else >>>   # define iommu_intremap false >>> +#endif >>> + >>> +#ifdef CONFIG_INTEL_IOMMU >>> +extern bool iommu_igfx, iommu_qinval, iommu_snoop; >>> +#else >>>   # define iommu_snoop false >>>   #endif >> >> Do these declarations really need touching? In patch 2 you didn't move >> amd_iommu_perdev_intremap's either. > > Ok, I will revert this change (as I did in v2 of patch 2) since it is > not needed. Actually, my patch was altering the current behavior by defining iommu_snoop as false when !INTEL_IOMMU. IIUC, there is no control over snoop behavior when using the AMD iommu. Hence, iommu_snoop should evaluate to true for AMD iommu. However, when using the INTEL iommu the user can disable it via the "iommu" param, right? If that's the case then iommu_snoop needs to be moved from vtd/iommu.c to x86/iommu.c and iommu_snoop assignment via iommu param needs to be guarded by CONFIG_INTEL_IOMMU. -- Xenia From xen-devel-bounces@lists.xenproject.org Thu Jan 12 15:53:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 15:53:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476297.738399 (Exim 4.92) (envelope-from ) id 1pFztR-0000u4-6g; Thu, 12 Jan 2023 15:53:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476297.738399; Thu, 12 Jan 2023 15:53:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFztR-0000tx-3r; Thu, 12 Jan 2023 15:53:29 +0000 Received: by outflank-mailman (input) for mailman id 476297; Thu, 12 Jan 2023 15:53:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pFztP-0000tr-DH for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 15:53:27 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2043.outbound.protection.outlook.com [40.107.22.43]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3f604efb-9291-11ed-b8d0-410ff93cb8f0; Thu, 12 Jan 2023 16:53:25 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8993.eurprd04.prod.outlook.com (2603:10a6:20b:42c::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Thu, 12 Jan 2023 15:53:23 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Thu, 12 Jan 2023 15:53:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3f604efb-9291-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X6J/AS2PLPBwUq4wq972dHYGn7+UlZP2FN85NyweM+muJ4SMqgeYxMeOW/tCH10qRn1LaFULAN8K6m8eLSr6cjWeA2+vJSYSvvzWhD8uHFPAz3yHKH3Vw06CcMD5z9Lb4nv1gLVCjL/P+6WfwVOWto/q8vwmMO3SfYsCd3TCbp2O66bLrOVpbW7iqrc1eyFb6aji9afazJb5iPpC7KCbYH5cxyG9KloKvaTOh0Doz3raQi7OsZNbVGyn+SLdkjuLXexgtHb2dcpXQ3bwHKGuo716hraXCQo7N0vvlY6vUuNSsP30IAggesolhSVw/HeN8fhIHaT/1Tfzz2o2jVqwAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WYGRnZFO15xxiImwSL1q2e+5C4/uRRMhXSPe4Iw7tx4=; b=OFO+C+oWiTNVtEbSI+AaKfqxGbBLx3c4HPcr+uoFip3sa35vNr4F34CWnLztBlWTxQaikt40IASw3JRbaLHOH6f3YpcP/63wsK9bEGsjxIJ4Dvmnud+exj/SucOg/0z4jYBZQJ7q42203EPnmWEkRXom5jn0l6LIZxXSVA5YJHhOV9kBBCkVYw5X0MvxmWdizYLJCZgb4jA/F7OPPa5gtuLxhMVorgMYqE0vg3wXQzXVUwNuzaBysPJ8r0SfwDDt0htAaUPWZF9E7g/DpkebFBuD8isRuIhHY4WpFcnpo5c3gDEme4gqCz5v1e1kUVXKLCc9zRxgfSAejaMJia2Pdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WYGRnZFO15xxiImwSL1q2e+5C4/uRRMhXSPe4Iw7tx4=; b=eqhYaMDLTgXLytIsf9NvtLE2qGoj4Ksfju4ifIy9Ri4018dS84tS/SUziqegJuBpcNCEAXJVyTt7DUcAH3MKGlz3j6YQRsAZMXhHVyhlXYp3t5a6SNojzIV/cQwkqwbAJm2ZDX7/Br8WTg+k8smlLPNTbxSNe32yoBHzJIAxgkhz6wPDaGmiDL9rYcX9MCmAjDW8YQgkzzGFPabReVYexW/odzrMmpMbBxXrgy2uGQW69e/MupuWHs5SMp635GvEasMM5J886F3MdUYtVOOn1+5KuIYWXWPz/jYN1aDkzVJlKfjFbi3gLIHvMA1HVF0g+6uFaISZYUIKlCApBa4Cdw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 12 Jan 2023 16:53:21 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 3/8] x86/iommu: iommu_igfx, iommu_qinval and iommu_snoop are VT-d specific Content-Language: en-US To: Xenia Ragiadakou Cc: Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20230104084502.61734-1-burzalodowa@gmail.com> <20230104084502.61734-4-burzalodowa@gmail.com> <4bc3f2f6-9bf4-5810-89e3-526470e72d85@gmail.com> From: Jan Beulich In-Reply-To: <4bc3f2f6-9bf4-5810-89e3-526470e72d85@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0056.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8993:EE_ X-MS-Office365-Filtering-Correlation-Id: 7242b07d-0da3-436f-d364-08daf4b52279 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: J4SC/KYD/c1/mIAEiQkkqeiFmfmJeRHvj4j+v7gNU9YIujZzQIoVdcJmo0APqaAlKrVEUy7MtQljTDXitebD3RyRGsOp3EO90hOdGBTEzyxEhP/oxVv7ekYYZb/IWaUEFPMS3/PeGS9qsvcFIvxzZXwVVw+YSstcX8auKGMwkpXAlnNTpnR0Ww/ei3qXiTqabU9Q4PLhwYIFkzZdPkDREz52DkXsbr1yclDH/r4Y7JpTlCnbpoQH0yifiGpcOkiBPoK5AMgh+88sI/Q7XVsikMj/mi6gtZMRK0NMd0mf/UE2TC758ecQF4TRqYJ1NNBSx3pSsLk7oMWwpeS2+//ba5MS2T61c6Njq4TptZ/qPXEdfwJ+rTz26Hd50ZowQAhxQ48ekSbR27GdRtkeOWOhHfj9s0xk5j+wH/16odvQtCIxk+qW/FZEZeVAo5OVeP6cGmAZMsMAdMIWVe78f/YfEEyjyiNe1IB7GQYePHslfA9pKRue5nAZdDVqmT55RTkgp9mlK+WqOlV2Xe3eZtSUCxZCwORVZEvcVASlRAAUmdGU0a5vyMXfoLjwtbryOBNBr22o3gVOds7Aoel1fP3Hug7jjZkZwBYtiETWdbvVL0vfjOFH7lthIJdVJh7uZtPL31BtVu9gCW3y6WsXJ6Xrbgj22s3zOEM4au5Yq2r3ooYNNMIdJI/F6/NbB/feTmAF2tqM3ctFtsAqTCmHsa2xSaFpQ/CtauP6S6CR+EfwWcE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(366004)(39860400002)(396003)(376002)(136003)(451199015)(26005)(8936002)(5660300002)(2906002)(41300700001)(66556008)(4326008)(316002)(8676002)(6916009)(66946007)(66476007)(54906003)(6512007)(38100700002)(2616005)(31686004)(86362001)(186003)(31696002)(53546011)(36756003)(6506007)(478600001)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V3A4cTFwRldLTE5xVjBZRG9nS05IbkZPR2QyV2ZWV0NXdXZYdWg4d3Zibm42?= =?utf-8?B?UVdlTHVTeThvc2hRWFZ0aUZPY0VUNll2cFcrUXFZOU5NNjFzdXVRWGY2TFFK?= =?utf-8?B?UldkcnBWYUFNMk1oUWlpZmpZSlMrZndqMGlPK2RNK0FhTlhrU1l3d0V1dkVS?= =?utf-8?B?MzVVeW50UUUrTG5iZVpRN2ZaMTdIblJlSDVwbmNEYUVraG1qLy9FNFNWZFFq?= =?utf-8?B?TDdKSVNRTW9WeDd0dEhtQ0orU0hObWQrdVphT0dxRGdwV0dLRkptZE9DMWFm?= =?utf-8?B?TFRpeE9DWEQzUGptTHIyWW1aWWxGVnZySmVjUXA0SVlUOTcwR0lYelM2WEh6?= =?utf-8?B?Zk1aYTlXMjBaR050UW9ySkxpUmd1d1RlUThNaE0xTnNSQ2FKei9ZMFZyZ1Er?= =?utf-8?B?MmlBMmFFbFRPNHZ3OUFLZFV0VjRMYXl5U1VoWjFBdWp4b2dRVk5OMURDbWpS?= =?utf-8?B?cGlQdTZNL2JieWFaaXZkT1FFUTNiODZrU0kxKzZVc08zK1R0QlVyUGRPTWtO?= =?utf-8?B?RDdKdjRIZFJOcTFKellrQktPN1IxOHhsVXJJRStOcVgvRDhTT1hkTVNJNVNB?= =?utf-8?B?dW4yUjdhSlJwSXIvb2FHbGd1N24zQjd0MUdNc2E5T0NGc0pWN1JUR3ZTaFFZ?= =?utf-8?B?SUM4dGppZG9tNVBxOEVJQnVQRzNlTStzaWd5aFRBc0hINnFiVS9xVkdJRmkz?= =?utf-8?B?QzRDcUhDNWNpRU5mWnJnWEtjaXY3MDlIMFM2OWJaN2pVVVgyRVoxM1YrelQ0?= =?utf-8?B?d1VNMGg3akV5VkdXYS9HRzk4Q1F3Tm1ERFhtNVZvaVdkYWphb2pCVzZDdG8w?= =?utf-8?B?aThlQ3RvUHVDK01obDVvekFRYmE0NDE3WGlhRkt5NWNrSFZMMU5Tb00rbE82?= =?utf-8?B?OUNFWGt6bEF3WmNBMmg3c2Z2SDNUYTU0SkJMdTZBWThlT3RjUWZ0d0pYNmlH?= =?utf-8?B?UHlQblZYbXp1VFIvNkU5bmFxRzUyc21lbllkbDh4WXhKNUxaeGJvS1NjSG5G?= =?utf-8?B?WE9ZWWtJcUY3dHU1MlVnakRNM3JpRExYVTh4MjNWZWNZM0pOb2VreEc3OGxF?= =?utf-8?B?dGdMK0FsalJuWmdCcDY2NWNQWFcySlpBYTh1Z0Z0U1Nqc2FoVDM5QjR1Rzlz?= =?utf-8?B?MHp1aU16eUlZa3MveDVNc2Q4ZGlDL29PZGszVFliT1NxUU1pdGZ3bEtvSVUx?= =?utf-8?B?N25tYjZqWUd6eThxdFFxc2VMdXhIZ29uYnROSDVsNVY4aGFCSlFNME01cStK?= =?utf-8?B?V0J2SlY4WklFYkdWTjc5WXcxWFZiOVBtTUNBbW5VMkR6MXN4ZnNSV0RVUyt3?= =?utf-8?B?WElsWGFSc3lXTDdacEJRRW5FYVVWdlE4cjgvTk9LMDJMRDJMbEV3RzJPNmZ2?= =?utf-8?B?d0YwaGtibHRmL21XVmhHWGlNa2t4QW1nakova0VxUTljU2toRngwNFB4TGhZ?= =?utf-8?B?WnB5Q0h3YVVEYndvWTlaaS9MTjBWREFVa0k2RzlsZzBKRkJZMWtxaDdMV1Nm?= =?utf-8?B?RnBLWjZjb2o3TzI1Y3pOd3k4V0paUXoyUVovT3htMXQ1R3krVG5DUzRrNnBl?= =?utf-8?B?N21IcTlnaHF1ME1mbmJ2Z0xQRWtYbjRFVzcwcGVBYm5hRnFMTjZIcE9tVG9Y?= =?utf-8?B?Z05jdnRqSnl4MmdEeG4xWEJLTG43UUlkYTVTVStMamRFb3JEdTZzaU1ueGtM?= =?utf-8?B?aTM5Z2M0SEVrUlI1eEJqSWY4QTVBazhCazZLYW5ZVUZ1eXFXR3pweUsrS3hL?= =?utf-8?B?c1BtdVhCUlJianhOMkREb1BRZWVBM0pwdGR1bWRPdE1FR2I2aGJYTzViL01V?= =?utf-8?B?MzV1OTdaZVRNMUVkV3ZLOERkTWtMUlYzQnVTbWRRc0xnQjVQQ2lTeXhWMFIy?= =?utf-8?B?WE9VakFXUmxENmhsY1dETFpjZ0c5dm1NTTlhNzJtcHk0YU9ZMWQraCtrWGRG?= =?utf-8?B?dElhZVVHMVllM2l6ZC9QZUFBVkNHUlVoUTdmZFphNlJJaGpVYWZkNCtiNFk4?= =?utf-8?B?Z3V6eHE5MTNiTUJnVlJvaHhGMm0rc1lCWnJEWFVCNGw1ZXdqRkNkdXpxL2lv?= =?utf-8?B?YjZYb0NDbFJEWWI0OGNPekxjZitQNW9RL21JT21wTUlhS01UZGpnQldGNDBQ?= =?utf-8?Q?hXbYjrIOPhOAwSqdIyq1VubVD?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7242b07d-0da3-436f-d364-08daf4b52279 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 15:53:23.2576 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YqKt1XsMG3yvFoeCOdruwq1ducpltPF7XdSapkry09+VvcswZmG2I4SDXVAjTk24pyCeXcVTs4r7LpasS+M1gg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8993 On 12.01.2023 16:43, Xenia Ragiadakou wrote: > On 1/12/23 13:49, Xenia Ragiadakou wrote: >> On 1/12/23 13:31, Jan Beulich wrote: >>> On 04.01.2023 09:44, Xenia Ragiadakou wrote: >>>> --- a/xen/include/xen/iommu.h >>>> +++ b/xen/include/xen/iommu.h >>>> @@ -74,9 +74,13 @@ extern enum __packed iommu_intremap { >>>>      iommu_intremap_restricted, >>>>      iommu_intremap_full, >>>>   } iommu_intremap; >>>> -extern bool iommu_igfx, iommu_qinval, iommu_snoop; >>>>   #else >>>>   # define iommu_intremap false >>>> +#endif >>>> + >>>> +#ifdef CONFIG_INTEL_IOMMU >>>> +extern bool iommu_igfx, iommu_qinval, iommu_snoop; >>>> +#else >>>>   # define iommu_snoop false >>>>   #endif >>> >>> Do these declarations really need touching? In patch 2 you didn't move >>> amd_iommu_perdev_intremap's either. >> >> Ok, I will revert this change (as I did in v2 of patch 2) since it is >> not needed. > > Actually, my patch was altering the current behavior by defining > iommu_snoop as false when !INTEL_IOMMU. > > IIUC, there is no control over snoop behavior when using the AMD iommu. > Hence, iommu_snoop should evaluate to true for AMD iommu. > However, when using the INTEL iommu the user can disable it via the > "iommu" param, right? That's the intended behavior, yes, but right now we allow the option to also affect behavior on AMD - perhaps wrongly so, as there's one use outside of VT-x and VT-d code. But of course the option is documented to be there for VT-d only, so one can view it as user error if it's used on a non-VT-d system. > If that's the case then iommu_snoop needs to be moved from vtd/iommu.c > to x86/iommu.c and iommu_snoop assignment via iommu param needs to be > guarded by CONFIG_INTEL_IOMMU. Or #define to true when !INTEL_IOMMU and keep the variable where it is. Jan From xen-devel-bounces@lists.xenproject.org Thu Jan 12 16:52:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 16:52:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476326.738430 (Exim 4.92) (envelope-from ) id 1pG0o5-0000Wm-Si; Thu, 12 Jan 2023 16:52:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476326.738430; Thu, 12 Jan 2023 16:52:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG0o5-0000Wf-Pk; Thu, 12 Jan 2023 16:52:01 +0000 Received: by outflank-mailman (input) for mailman id 476326; Thu, 12 Jan 2023 16:52:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG0o4-0000WZ-Lo for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 16:52:00 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6c248aa2-9299-11ed-b8d0-410ff93cb8f0; Thu, 12 Jan 2023 17:51:57 +0100 (CET) Received: from mail-bn8nam11lp2169.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 12 Jan 2023 11:51:54 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DS0PR03MB7226.namprd03.prod.outlook.com (2603:10b6:8:124::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.13; Thu, 12 Jan 2023 16:51:51 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5986.018; Thu, 12 Jan 2023 16:51:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6c248aa2-9299-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1673542317; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=GmFi/8tIrTuLpufoIdU6VzhCivSlsrwgl0zjfNXw22A=; b=eLqsoPMquv32WOnG2vp+jeSdw77ntERzrNzqgQsl++n0g4D5U3Ipq628 neHRnO/lhejaG6L1C9DULEffX9D0wSHY24na79Glo1rk/9Uj/uOCUXesB cqkokP+MUqelnziiWUTlDWPD1/sRJ9BiLmlcfYlSQ8LuzJ5uio8nMgAQD I=; X-IronPort-RemoteIP: 104.47.58.169 X-IronPort-MID: 92386469 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:x1udWqkMkoXWRaVTuYQDV4ro5gy5J0RdPkR7XQ2eYbSJt1+Wr1Gzt xIeWmDUaKqOZWH0fNh3at++/U1Vv5DUn9Y1Twc5qyk9FSMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icf3grHmeIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7auaVA8w5ARkPqgS5QWGzRH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 c5fEStRMDysvvLsypSbafFI2fwTfda+aevzulk4pd3YJdAPZMmaBo/stZpf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkVw3iea8WDbWUoXiqcF9t0CUv G/ZuU/+BQkXLoe3wjuZ6HO8wOTImEsXXapDTuboqKI00TV/wEQCJTQzcgfj4sKgg1+/WfxzM mE1wgwh+P1aGEuDC4OVsweDiHyOswMYWtFQO/Yn8wzLwa3Riy6GAkAUQzgHb8Yp3Oc1SCIr0 BmVntrvLT1prLCRD3ma89+8vT60fCQYM2IGTSsFVhcepcnuppkpiRDCRcolF7S65uAZAhn1y jGO6SI417MaiJdS073hpA6WxTWxupLOUwg5oB3NWX6o5R94Y4jjYJG07V/c7rBLK4PxokS9g UXoUvO2tIgmZaxhXgTXKAnRNNlFP8q4DQA= IronPort-HdrOrdr: A9a23:BN6EqqNXqzyzT8BcTgWjsMiBIKoaSvp037BK7S1MoH1uA6mlfq WV9sjzuiWatN98Yh8dcLO7Scu9qBHnlaKdiLN5VduftWHd01dAR7sSjrcKrQeAJ8X/nNQtr5 uJccJFeaDN5Y4Rt7eH3OG6eexQv+Vu6MqT9IPjJ+8Gd3ATV0lnhT0JbTqzIwlNayRtI4E2L5 aY7tovnUvaRZxGBv7LYEXsRoL41qT2qK4= X-IronPort-AV: E=Sophos;i="5.97,211,1669093200"; d="scan'208";a="92386469" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b6lknO3R0S0CPZRGRNpqBK9JXyCGZAgRgUtkr0N/98AQ6FwFOwT5dGwrSMmcFlmyvV3RBxIbtcqDIZhinNQfjsjxO5/XUI7hCA4f5IdS9A0arg3yfGkDg8phTYFG8PuGDa+b0gPJVXgTI5Hqcxz2Vokn1RDxJP3M1jpqhkxYu1is0V/V/IQ9HmoZWRYdkCnJO167I5P1angXOV62m0ZrHhsSweoiU5ERcrKAP6N0YUVQDf44ndG813AvOB1GxMB54osei5vL6gaBFoIfFtpMJa93XCbMe3c1xEXALQKHD1+N+gFUNwgn1hFrzD+Wrl/1QBx4MxcrNdyxt6ZCrD3syw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GmFi/8tIrTuLpufoIdU6VzhCivSlsrwgl0zjfNXw22A=; b=NtkRN1Ch/LhFVf6ozWbaVMHDcV4J7M/Ll+prlUqPARlvw+Kbttpe7DZtaV3ZH1OuH2QDbiJ2H3jPoZHW96ZkP2ITpM28mVz0yuyOV4XpVQJM4678s2wp1dc3vMOhFliZCu/cslb0i3KZezAS2AaQbnLbwMS9eWO9PhMV5Rg6dAoIiuhxo6v/WY3K7flb0v2cdPz0iNMqetcR2MIm4BaIcmeeHpocJ7D+y8MBZLwboCzNVt9b+eIp7SIXxZ91QzORK/onkopQuY+C6Lj2ykmO8Shff5NfjO1EoAGp2sJVw7weTMqM5Mp1v3aHMybBx6ic8Iv1Mty1H5UBhmGicsHmOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GmFi/8tIrTuLpufoIdU6VzhCivSlsrwgl0zjfNXw22A=; b=Smbl9zC9Pks+qJFJTZrGsD2tl4JRcn3X2hV76LwrL6Mw8969Lw1hq450py5JE+s4vJUo6U3lp7Rnpz/8dwKR8Wb1YmZt5bCRYWKXq4qKeY8y39TzcjgAqIc7dlPqsiBvtAU2Sb8xCdjP0C9d6CeXBBa0mMrw94r7W/r1d3TOJ+s= From: Andrew Cooper To: Jan Beulich CC: Roger Pau Monne , Wei Liu , Kevin Tian , Xen-devel Subject: Re: [PATCH v2 5/8] x86/hvm: Context switch MSR_PKRS Thread-Topic: [PATCH v2 5/8] x86/hvm: Context switch MSR_PKRS Thread-Index: AQHZJRefeExwWeppzE65VXS63DgRAq6axG6AgAA9twA= Date: Thu, 12 Jan 2023 16:51:51 +0000 Message-ID: <3ac6a4d6-44db-d248-4440-6e71aa14ad93@citrix.com> References: <20230110171845.20542-1-andrew.cooper3@citrix.com> <20230110171845.20542-6-andrew.cooper3@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|DS0PR03MB7226:EE_ x-ms-office365-filtering-correlation-id: 1c4ba72c-4215-4673-a710-08daf4bd4daa x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: o6VQOUNFCRCLZQxUUIrgc/g5vrVEPoPRfRqwJv3uG/FoFxZ2RgaqrRdGVi4U4MRsoITL0N9Kf9qBI8Dmcs8d7P+D+ORCqF2EOzOymhedzfd920ZWvN2bszCc009b5XXQFqtUanCAl+qgNy8MMe/xhe9PJeS+QfZtPcJYfMkF1D9gASh33rZQ4XjJwfq9UAx4CO4PyD3rbVrYZy6WumbEU//uNSEJkUdiHBs87TiCWGX86FFuH7LMRvsvW1v53VtAkwz+i1VJd8uCdhbm5uk5DMSKxDjohGjo5tSbiPgEhQ9nbhFJoKglF3bfqt/GepCgwKE8kl7M3OXtIzf/RIeibJ8wjGOjGfrxRqs2irstJLPAZmqhFUdwBqUvjtdAF74rs1odvltalx5JZmweQefzIGpP33GDfYi6gOkSD9YNi6ZjV7l30Hyjonk+KAi4sN7NTJhsqUpZyxFGRvkvQipmDvLQEG457UP735sY4YYhA2wMJN69503ulaJIvSyJaO2GrjEaCaVVCOLPZfqaXHtTXQUG6+nRLSBtEQgIt3lgiJCj5SWKoI9xXaIGylqSZ5eISOa6WZiXkG5mIegbzKH4z8TaO1gsP0Szytw4vVJSbe9uQFYcZSBvqejUh4HVrIOrZ538uG5Y/99xWfFrFowY9jRrgcYtvBjU37MCUO3lBZ1zpwL2fJ1VFgfebApg2OtVeHU++LNjhBmSAIiRjtAKqzOX2sSe3gDM6gANfntK3+xePh015lXhLHmvqspZC9I3IwCXdWN7QgW2XD/kr7DWhQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(366004)(136003)(346002)(396003)(451199015)(6916009)(66476007)(76116006)(4326008)(64756008)(66446008)(66946007)(66556008)(8676002)(31696002)(8936002)(36756003)(41300700001)(5660300002)(478600001)(6486002)(83380400001)(26005)(186003)(6512007)(6506007)(91956017)(2616005)(53546011)(316002)(86362001)(54906003)(71200400001)(38070700005)(82960400001)(38100700002)(2906002)(122000001)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Q0pPRUJFQ2s2NGVLOHVYcW9USUJNWllWYnpPSE0yR2VjUzVOUHpuYnBCZVlJ?= =?utf-8?B?NEU0eWtNaFllZnJxaWlvRmZXcWl4NnRremNoZ0tiNWVOaytlRjYrYjRucGgv?= =?utf-8?B?dGlveWFqeFU1a1FKUnFwK3k4QXJEeFkxb0dEalFrRVgxVzVhbU80QXdUeXFv?= =?utf-8?B?WDdBUW5EK1FWcnIxR013Zm15N0dhMDZ0QytzN3puT3kyZkxzQWhPR3QzQnNn?= =?utf-8?B?VHZEeW04a3ZQOFY1SS80Mk1DYk5EdVN3SnNJT25jeHEzN0RJU0loRmYwZERa?= =?utf-8?B?US9qcDJ2WnlOZXZWTld5NUJTK1ZUSEJIRWhDNmFsOVFJa1dTa0lRSlNpdGow?= =?utf-8?B?cGFVbXBCMmtDWFJuS0VIMWVOVVJNUlN3NVZRdklhZ1gyNlFRWjF0cWJXSCt1?= =?utf-8?B?RFdEa0FiTVo5ZUpqMEM5QzNwdEJjQ083ZmY5NFJVN1ZFYktaK2xXZ2NoNE9S?= =?utf-8?B?empJZkVPMlJRdzlVWVEwMVBnb0s4UVVMV05IbEt3NjE0UktjR0VrYkNZWUZp?= =?utf-8?B?Wjd6NUYrOXFHUUhtbE5ZQ0hNQnc1NmZ2Uk8rM1ZkSWZOV2FnSzJESmRRNlUr?= =?utf-8?B?RHpoZjBmd2FuaW5MVXBobkxRemY5cVlCQ3Z1U29XcjFtY3hBelB5d1dubXNh?= =?utf-8?B?RHlDL1MyRjBEM1ZpSUd5YXlZNSs5eUR0eExOU1JveHFxc01Fbk8yaUdkK0Vr?= =?utf-8?B?MDUwelBuMlc2VWQxOGZVK3VTUUlxQS8wYzhBZ3o2c0VNbEh5SnBiMms3SVRt?= =?utf-8?B?ejh3T1Bpa0N2QVprSnJ0NEZ0UDlraytQZFJwYTdqbTNNZTJwcUN1ZHRWb0Er?= =?utf-8?B?RFZKTmw5aDdCdnpZRzJRak1lUTRsRHFSeEFBWWR3d2VFMTc5aldEQ0FZZVQv?= =?utf-8?B?c0l1QlcrYVJtQ1JkUWdMQ0FMci9YY0o5OS9oa3BtWDZQRnRiWXU4RnR3Zk8r?= =?utf-8?B?dlZPT056OEtlYWh2TWVMUHZkblZjUDljODVvQnk4aVBKNkoxbUZReU1rZkFP?= =?utf-8?B?eHZMWEoycy9PSnVWbHI0SlhZWUNUaVhhMkN3amZJeFlod3BsRVRBRjJ0N1FP?= =?utf-8?B?Mk5yNWpiWHJUU2pzK21qQ0F3QVFoTng3RkZUYjFwQnpPRlY4MEdMVmMxV0ta?= =?utf-8?B?Q0NudHoydER4bmRleGYyOUJzSzFpbm5TZmFiMEVkTkJoVnZBNDJRMWhZWlZD?= =?utf-8?B?aElJQUlQcUNzNVZBTlJ2Qm0xVmJ2alNaVjdLbjdndE1ZNndCZGw1ZHhDTEtB?= =?utf-8?B?TlRVdC8xUG13MEJMNEJkQk9DNzFvQnNPVUpDY2VHUzdIbEhkc3FVcmFHUm5u?= =?utf-8?B?RGk3eXY3eHBBOVF1LysvOEZXWFlWQk5YZ1JwRG84ZmIyeGxZc0d1aFNBTXhJ?= =?utf-8?B?Z3p0RlhDY0pvOE1JSWhxdWE4cnFjR1dweWtxYjFqMmFoWmpWNktEMGtKdS9R?= =?utf-8?B?UytjYXFiclFjaUt2THFzYUZBSjluYWZ1b2Z2SkM4Rkw4aGpmcDNzUHQydXFq?= =?utf-8?B?Y2xBQkRtNXBHbFkxSk1HQnBIRTRFNnNySGpPb0toUmlISGsra1dxOUlyaStN?= =?utf-8?B?YTVsaElMVkVJeWl4blgrV3EwMTlGL21udGdXdWtKdDM5ODlMZm1BdlY4ZnU4?= =?utf-8?B?Rm5Tdk0zWWN6ZzduMzZWaW5BMDU3VW1pTktQMTdmRkJZRDVuVVI5V0Q3QkZD?= =?utf-8?B?WUFDdVdBMUZFeThMOGFaSDRnWVpNZ29JU05PRXlxL21raytDbkQ4YllUVmt1?= =?utf-8?B?SHFXUGw2TUdpaFlSRWphblZTcWxjbnpNdXIwbEd2UnVSdXhiTFlzQ2NsR2s1?= =?utf-8?B?RGVLNmtseUNUR3dDYlVqTVozR2p3MzdiWVNWdVFQRU9CMENFVzBxRUtBcnlP?= =?utf-8?B?d0w0bjRYOS9UVXBLcXVHeVR3VkdRYkVTNWZkWFBTQjVIaVRSUTNNUUtIUDZs?= =?utf-8?B?WHNlSFZGRnkvNGxJOW9QM2ZOUmpJNVZIbTFRV3JLU2FoZ0VtNUlIOGt1dEFZ?= =?utf-8?B?ek00bmsvSjZZUHJvVXEvM1pPaWphMU02djI4RlQyc2NTZHNja1dtRGZpRU1o?= =?utf-8?B?L1dDMnEvL09tdFR3dVN5OHUrNHl1OTh2YzZaeis1NTBveTNnMGxYd1NYbjlP?= =?utf-8?B?dlhSelA2V0tZRFZMZytwdFF3TnpJWVhvTG03ZWFRWk5LLzFrTnh1djdRQnFn?= =?utf-8?B?TEE9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: jKN08GRVUHqjfRjuR597wb4oDyZjM55V0gBN1ff7oSGtq2fkX+rJyPAnU/JBZqcmo9FUMTkfOUTj4hKIWgrfDIUEUBzl8b2ymVvstAHzqFdmJT9hq5aNiY2gjROgOfFfdQ5lOtXMbVrFS8ogJkS04NIPSEADR65jZ5hikFwJtNCyA/UBH4ORv6WOeN/P69ALvyTpjMeeNZNZD40zFP5gFdkyE3wBg7wSOn9OVWn1pWbyEu2XEltAZWQl1AuYmU8AkFyLNky8FJs7thAtv/ljTkmiVwZQcxbNFhkgruIIBlJ3ny1ybLrgIrvF3g56m4VU1MVMeVh5tPa4uX8KPkJ9vpFPb4nJT68XkpfH2293tLPrq/NjKH/85mpncoyT+8ItrDhiX5Mu/YdITzoKf28J7QaUXYaDp7cHT3AX49/u/HPvt8tMT9OoT36jISyICbC1xl5KKytg8f9JsZF058LYMELWdljGS35RD8mky0vTNeQQP+D77+zuo4iJB/3Do5KlBuCtZ452INl2/HSQ46nxrkXWFLLZU3RLLyvcKUPCqDLHf9zFLFn5ODLKWjpfZIjxEFDqMzGiY5dSL44dZrbC1tjjXUasL+AOgPZFKFlAGV1peQdfOUU5dd4Y29B42cPyEotTOL/0yAs7khcdWPBXQcGQVa4+ozGEkbWfUNPvfLEcIIkZejoHEt6UC3Ct4hnMPX8WID2TLfLmZ7VWb4pz1U0EXgiglsbOels1bYQ5lJGsfKOo75Sr3+uMTjwUNucSqL1uyWVKdKiKJuTmwTKcFvMry/FpJRSu8ibf55QkV107Lof+Mpzle8LwWXxDcR8YBGmXzJ2fSlFHfpz37wRU5YEMXkZaERqut/oKsdWp8J4= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1c4ba72c-4215-4673-a710-08daf4bd4daa X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jan 2023 16:51:51.5059 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: suBcyvBShP+hk106jepOHOdKwKuh6rvOnv1/51pGvlWNawwWUhLsIjY+lMZfJ8QfTJfNTdpY8qPX9MA3Un+1vsthJWsHfSnu2vhcaBChTo8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR03MB7226 T24gMTIvMDEvMjAyMyAxOjEwIHBtLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gT24gMTAuMDEuMjAy MyAxODoxOCwgQW5kcmV3IENvb3BlciB3cm90ZToNCj4+ICtzdGF0aWMgaW5saW5lIHZvaWQgd3Jw a3JzKHVpbnQzMl90IHBrcnMpDQo+PiArew0KPj4gKyAgICB1aW50MzJfdCAqdGhpc19wa3JzID0g JnRoaXNfY3B1KHBrcnMpOw0KPj4gKw0KPj4gKyAgICBpZiAoICp0aGlzX3BrcnMgIT0gcGtycyAp DQo+PiArICAgIHsNCj4+ICsgICAgICAgICp0aGlzX3BrcnMgPSBwa3JzOw0KPj4gKw0KPj4gKyAg ICAgICAgd3Jtc3JfbnMoTVNSX1BLUlMsIHBrcnMsIDApOw0KPj4gKyAgICB9DQo+PiArfQ0KPj4g Kw0KPj4gK3N0YXRpYyBpbmxpbmUgdm9pZCB3cnBrcnNfYW5kX2NhY2hlKHVpbnQzMl90IHBrcnMp DQo+PiArew0KPj4gKyAgICB0aGlzX2NwdShwa3JzKSA9IHBrcnM7DQo+PiArICAgIHdybXNyX25z KE1TUl9QS1JTLCBwa3JzLCAwKTsNCj4+ICt9DQo+IEp1c3QgdG8gY29uZmlybSAtIHRoZXJlJ3Mg bm8gYW50aWNpcGF0aW9uIG9mIHVzZXMgb2YgdGhpcyBpbiBhc3luYw0KPiBjb250ZXh0cywgaS5l LiB0aGVyZSdzIG5vIGNvbmNlcm4gYWJvdXQgdGhlIG9yZGVyaW5nIG9mIGNhY2hlIHZzIGhhcmR3 YXJlDQo+IHdyaXRlcz8NCg0KTm8uwqAgVGhlIG9ubHkgdGhpbmcgbW9kaWZ5aW5nIE1TUl9QS1JT IGRvZXMgaXMgY2hhbmdlIGhvdyB0aGUgcGFnZXdhbGsNCndvcmtzIGZvciB0aGUgY3VycmVudCB0 aHJlYWQgKHNwZWNpZmljYWxseSwgdGhlIGRldGVybWluYXRpb24gb2YgQWNjZXNzDQpSaWdodHMp LsKgIFRoZWlyIGlzIG5vIHJlbGV2YW5jZSBvdXRzaWRlIG9mIHRoZSBjb3JlLCBlc3BlY2lhbGx5 IGZvcg0KWGVuJ3MgbG9jYWwgY29weSBvZiB0aGUgcmVnaXN0ZXIgdmFsdWUuDQoNCldoYXQgV1JN U1JOUyBkb2VzIGd1YXJhbnRlZSBpcyB0aGF0IG9sZGVyIGluc3RydWN0aW9ucyB3aWxsIGNvbXBs ZXRlDQpiZWZvcmUgdGhlIE1TUiBnZXRzIHVwZGF0ZWQsIGFuZCB0aGF0IHN1YnNlcXVlbnQgaW5z dHJ1Y3Rpb25zIHdvbid0DQpzdGFydCwgc28gV1JNU1JOUyBhY3RzICJhdG9taWNhbGx5IiB3aXRo IHJlc3BlY3QgdG8gaW5zdHJ1Y3Rpb24gb3JkZXIuDQoNCkFsc28gcmVtZW1iZXIgdGhhdCBub3Qg YWxsIFdSTVNScyBhcmUgc2VyaWFsaXNpbmcuwqAgZS5nLiB0aGUgWDJBUElDIE1TUnMNCmFyZSBl eHBsaWNpdGx5IG5vdCwgYW5kIHRoaXMgaXMgYW4gb3ZlcnNpZ2h0IGluIHByYWN0aWNlIGZvcg0K TVNSX1gyQVBJQ19JQ1IgYXQgbGVhc3QuDQoNCj4+IC0tLSBhL3hlbi9hcmNoL3g4Ni9zZXR1cC5j DQo+PiArKysgYi94ZW4vYXJjaC94ODYvc2V0dXAuYw0KPj4gQEAgLTU0LDYgKzU0LDcgQEANCj4+ ICAjaW5jbHVkZSA8YXNtL3NwZWNfY3RybC5oPg0KPj4gICNpbmNsdWRlIDxhc20vZ3Vlc3QuaD4N Cj4+ICAjaW5jbHVkZSA8YXNtL21pY3JvY29kZS5oPg0KPj4gKyNpbmNsdWRlIDxhc20vcHJvdC1r ZXkuaD4NCj4+ICAjaW5jbHVkZSA8YXNtL3B2L2RvbWFpbi5oPg0KPj4gIA0KPj4gIC8qIG9wdF9u b3NtcDogSWYgdHJ1ZSwgc2Vjb25kYXJ5IHByb2Nlc3NvcnMgYXJlIGlnbm9yZWQuICovDQo+PiBA QCAtMTgwNCw2ICsxODA1LDkgQEAgdm9pZCBfX2luaXQgbm9yZXR1cm4gX19zdGFydF94ZW4odW5z aWduZWQgbG9uZyBtYmlfcCkNCj4+ICAgICAgaWYgKCBvcHRfaW52cGNpZCAmJiBjcHVfaGFzX2lu dnBjaWQgKQ0KPj4gICAgICAgICAgdXNlX2ludnBjaWQgPSB0cnVlOw0KPj4gIA0KPj4gKyAgICBp ZiAoIGNwdV9oYXNfcGtzICkNCj4+ICsgICAgICAgIHdycGtyc19hbmRfY2FjaGUoMCk7IC8qIE11 c3QgYmUgYmVmb3JlIHNldHRpbmcgQ1I0LlBLUyAqLw0KPiBTYW1lIHF1ZXN0aW9uIGhlcmUgYXMg Zm9yIFBLUlUgd3J0IHRoZSBCU1AgZHVyaW5nIFMzIHJlc3VtZS4NCg0KSSBoYWQgcmVhc29uZWQg bm90LCBidXQgaXQgdHVybnMgb3V0IHRoYXQgSSdtIHdyb25nLg0KDQpJdCdzIGltcG9ydGFudCB0 byByZXNldCB0aGUgY2FjaGUgYmFjayB0byAwIGhlcmUuwqAgKEhhbmRsaW5nIFBLUlUgaXMNCmRp ZmZlcmVudCAtIEknbGwgZm9sbG93IHVwIG9uIHRoZSBvdGhlciBlbWFpbC4uKQ0KDQp+QW5kcmV3 DQo= From xen-devel-bounces@lists.xenproject.org Thu Jan 12 16:52:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 16:52:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476331.738441 (Exim 4.92) (envelope-from ) id 1pG0op-00012h-AH; Thu, 12 Jan 2023 16:52:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476331.738441; Thu, 12 Jan 2023 16:52:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG0op-00012a-77; Thu, 12 Jan 2023 16:52:47 +0000 Received: by outflank-mailman (input) for mailman id 476331; Thu, 12 Jan 2023 16:52:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG0oo-00012U-3y for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 16:52:46 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2051.outbound.protection.outlook.com [40.107.247.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8856c038-9299-11ed-b8d0-410ff93cb8f0; Thu, 12 Jan 2023 17:52:43 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VE1PR04MB7341.eurprd04.prod.outlook.com (2603:10a6:800:1a6::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.13; Thu, 12 Jan 2023 16:52:42 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Thu, 12 Jan 2023 16:52:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8856c038-9299-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OGI2V6B29Nomn7kpeBIuZQ6fUCJd5K38tLss5IEkkyzavQm4Nj4bR8S5Im6BnwFxCLIUa/3eJi2R8+5jCb5N6GgiNkHo3WIJPuJ6HbVkY/zfaPxlFK3QW6dU7Vu5pOiLMadwf+Rvg71vnnNTk2M2coUawo76gkudpROwCWtNlWkV45woj4z4uw9pKuET6PynJX5eb61SR0IBWlyksq014MY5kOSoFHkyLVXtxpsAIXp8AWypTV/d/qm0w4BFnlpDqOsMhs3EgUsn2LuL+xGQBJmTrFAhpfkrjArFpODOiGYXK5Q0Uk/aiUJqUNJptfsPmfvvGZzViN92LggFW+5e8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3OC2hKCRm5O4+uIq6PdR97qMCPjE2gjFQTP+5K44Pbs=; b=XZtIGJjbU+XV5lk8/atUraN69AwGDT+opTz3N5t4hUbL/iPK/oi5P9bdmi7pJtW96W/PvYfgQiFCNfTN1dV8lPeC6q8qKMg77jwcOy1z4qyPQ3X3xLGpK+sG59NknJWed5sS25hAOavH0LwVbImlRtxfR4zWfp9woOV3ham2y1xccLLa/w8Wm7CDM6vvEFYAm0o+aJmzbwRaETZkFh7/hDvJc1sYMh+0m/som90qTwBB2KI1b2rJTI5jb0M0VxFf4FpU1kGbfPlVKWiuSP9ZSbYTfVp5xVujzvCdNULNKYUU/daEDyOQjpggAReAz8MtRrQklxk9JL+1sIrzUm35/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3OC2hKCRm5O4+uIq6PdR97qMCPjE2gjFQTP+5K44Pbs=; b=TtYxYQ0UEOrfyJce82LpEgcPqNEnLdGUnaobsJj5do5mYkg2z800YuCCAgeN+vN5woMjceI+5MuJyEXqNKFZZYCpr/JEDfZn3hi1FrrO7WRV71ZDM/ke3Y2zs+cEPHpdTKu5NBtSyDWP2JN0yKoCnfY+dVa1nU6LPEWhLZIMXLSkve5krXtrOislr68og8uA7M+TJ80KfjHDnPwBm8jW7VMxZt7Wn7ePLb5bPMq0veqN1IVaCN4oMYhpbjNkQw5tWfQ72J8gJSulXfAuz8r+VDC4CB5XwtR3tVk8LT++X5dI7a6ISxDmGkxF/Pqo5rdITMnf8Ub6TR07cpOtTf7Qzg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 12 Jan 2023 17:52:40 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 From: Jan Beulich Subject: Proposal for consistent Kconfig usage by the hypervisor build system To: "xen-devel@lists.xenproject.org" Content-Language: en-US Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0068.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9a::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VE1PR04MB7341:EE_ X-MS-Office365-Filtering-Correlation-Id: 9201fa6a-66b8-4742-316f-08daf4bd6ba2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JlAhjOVvsrhesHo9s5tFhvTr0RhRLPPb5lt+GvKUYyE0LEWAtaHVI2E1gEH1way7fbZHmBPrCsMPFrLlUa5iDoalBA6O2hvhx+ZG6cUImi36xWtM775+h8RoTe9FMkf9bTaV5A7QauAuzskQGqhU+Log+Lf3P1r9n6/8KZVfFRRwM4wujhRbiRJYBCdykOs5Fle3U8tvwig5etD048gx4NIOcNB9IllNRdA6dulAOJ7z28aiW0zCQwatVntTTHhKZKSGYl0xFPicAWsd9uMlE3uQkjI8yRh2K+upXFwEVjUAVVZc3aajD7ITmXOB1dtDOLu0ANPgGqd3qnoXDQRm6W1sr5KT9FV1bYIjEB2/0O7RbRWDUh5oT6FfhHZ32NHs1uW6smrnTco9S5SQ4+XfjpzHbDuALwphLZ9aNcGeCAvXG3aVH/Sg+hEa3glUN5ugsV+DRbGTssB69zqYoPUHUdZnYQQrxHDfrhWG683gGiYpqPB+RQos/oOiGiEXxdZHw7m+6VEzRBIlP0VkshexjnohK73hDrgGgpML9Y2Z2uzSVRIMDAAOMN1m/DBGwI+kSpRk/zIQjXsm1LkwALdmLulGi+KbBkEXQUxxE/Zej9caRYudZOXgZMKejM8M0jvoyuNmvFE8ycvzdgz2Dsjpoyn5EejCS3Dun5ck/VcZ8nZbrRXpWdnzJmhzIptBycMQYgs9X3bCQlLoelru7kuTT97opBQhVvlG3G8SKk0zSE0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(366004)(396003)(346002)(39860400002)(136003)(451199015)(478600001)(6486002)(41300700001)(38100700002)(54906003)(31696002)(2616005)(316002)(26005)(186003)(66946007)(86362001)(66476007)(36756003)(66899015)(6506007)(6916009)(5660300002)(2906002)(31686004)(66556008)(4326008)(8676002)(6512007)(83380400001)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b3V5MklLb091dXlmMitKcTFlRkowUG1Iby9PV25YcHRaNTNvbVdQYWlpd1FX?= =?utf-8?B?NGNBUWpKV1E5OW0wNURKOUJvUXY5TUdSWTg1V0JBTE1sOXZ3cVVEV2xLcEs1?= =?utf-8?B?bEp3RDBSMERWdlhnRFJpeDJkMXAzeUdycWlPVFlLOGNLbUJZRXJLeitrbGJp?= =?utf-8?B?NHVNV3k4VDViQXBmV1g4SEpuT25Cbk9aMjNHWXE0NXRLOURDakFqZ25pMVIx?= =?utf-8?B?dlFEdHdjRkh3TGorWWUwUEhKelY0dThsUFJLRmc0UjdSNXo1ZFZIME1RQzF2?= =?utf-8?B?aEMyRFRwSEdPcUVTNTlqbFFnODJaZTJqdElJMzA1MWwyQWFWN1NwYkJqS2Na?= =?utf-8?B?NDNJYVZkMlV0VUZlaElxeWVOSWpENWd4UlJ0SFBNdG4zN0ZLR0RGVzlraFF4?= =?utf-8?B?czNjRk13M2pYaHZxd3dlTEJSWHBCU0VSQzlsT0ppZ3ZVZkVRYUFqeDNWRXN4?= =?utf-8?B?M09semIyWTdlYy9Pc2FMWEVuLzNtcUtiRXVGdmdLQ2tZd0cwNEZueHBncXhM?= =?utf-8?B?RGxwcFE5QTk0THQ2RmJxRDhFTitrdjhUTHE2cFQ2RFBnT2lDbGYvZ2dCN1Fm?= =?utf-8?B?ZjlwVUk1ZlZ2dlB6ZUd4NE1FSmJLT0ZZUTdVcFVOanZhMS9xWEZiS2hBWHVZ?= =?utf-8?B?a3RIQkZTWmtoSkphbWZteGJabkdZVlVPelNpTUJUTXpmL1JaYk1oYTJNR1A0?= =?utf-8?B?VlZJMU1wNHRlQnNzZ3A4SkNsRzMySVpqMWFzTjZEV2VOc0ZXWkw1cUV1WnNu?= =?utf-8?B?VWpsc0RWWnNhTTJaRkVESThHbzBtWGNkZGFjclRoT1FSK3pFNmRBOEczc3dn?= =?utf-8?B?Q2orZE82QnNWT255MHhCeDJCNysySkVuRVpoaE5KaEp2TTkvSlRtcHBWZjND?= =?utf-8?B?VU5pVHpSTEY4dXNJK2theitobGdyaVBqKys5Qm13YmQ4RG9sNC9nZEpZMXRs?= =?utf-8?B?SjRBUDNsYlZ5SGFGRFNIWjU3c2hBa1JyMXlDYkZESFhpY2IvWE1UM2pvcVNL?= =?utf-8?B?YnV4eGFXbllHZDlCcmhnaWl6NXpuMCtiWkNPOXQ1MnowVjJkNVZ3bEdhcCtp?= =?utf-8?B?MzFGRi9pMWdIVEdGL1hMNW1UemxHWnR0WFhLU3VJdWZnY1g3b1ZLbFZTWmZV?= =?utf-8?B?RENDQ0h1bkdVUW9wZGRoOHMvNFJqMHR0a1lXZXFNRlZ3dkpUb3dQWElJZXF2?= =?utf-8?B?TzFoR2pEMGJRL214ckZtU2hySWR0di9HejRSY3lRbm5vY0NDc2p5bmc3Q1Vw?= =?utf-8?B?djBoRnFQUm5WalRuaUE5a2VoZVFCU2Jycmc2SXE1WFFlNHJaK3hvSkVzUW5C?= =?utf-8?B?ejR2aXhNVFVtQWE4Um9qVmpiaDRLZ0VrYVB0ZUxORGJKRUtQT29xamMzdVJi?= =?utf-8?B?b081Y3czNWVNL3lnV1Z1TVlmWlV3VTJpZCtOSWRlSFZTRXJJTTZNRjJVd3dv?= =?utf-8?B?YXBFVkJralNaQkFqcjJmbXlXRk1PT0tjYXh5VEpzMlV3Y25YUGR0TEdLMm1L?= =?utf-8?B?V000aUpwVklzNFVURG9aczFuQmFiUVJhc3AzUDE4N0hKZWlXUExmU2hzNWEw?= =?utf-8?B?cVM0b1lBTngvNGN6VnIzVGtaZWYwejdhV1FhcWVySENQb2xBSTVPT2VybTll?= =?utf-8?B?T2hFekVqc0NCU3ZmSjBNTEhuSTJOYVdUbkswaVVpRDNjSjRRMks4V0Y0VXlH?= =?utf-8?B?UEZXRldxQ0gzd2VKaU9mVGthbUlqK2F0MTJxRkM5dXBTdktrSm1wK3hmekVT?= =?utf-8?B?M2pmOVFUd0RqMHNCWnBWL1pMVENHeDBibk5TSloxWlNNWkVzSWpqVmNvdkgw?= =?utf-8?B?YkxRUGF5aVc2S3BkbFQxVVJoaTJZemVRTmIvNFJNZDRWMUxqK0lKMU1UK3FQ?= =?utf-8?B?Sm4vMnNELzI1cWRuQWJDbVQvaDJ0eXJ2OWtqNXY5aWlYQlRZQy9GMmovc256?= =?utf-8?B?T3FLaytyVk03d1cxU3RkbzNEVm81dXhYMGFRbjJDSlp2c25nUkgxT2FJNThN?= =?utf-8?B?NlYzV1IvT3J5V0FCY2U0RzFHcFBPbC9vWHorSkh3S3lQMnBOMEF3TUdrNS9J?= =?utf-8?B?Q1BzQlhlU3Z1TExnb2QwZnc4dHJFenJ1WGh5MDgzRy9mdzZzQVpUVVErZU5W?= =?utf-8?Q?lDKm6rq0zUW3boZf4hicftxho?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9201fa6a-66b8-4742-316f-08daf4bd6ba2 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 16:52:41.9853 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pgnvxyyty6O414W2mBmEwMtGvnpMKwyg3hgwT2qUGmYuH57gF/Nb8vh1O3MeyIcykZOw9Zx2e+TSuOy3MSLcHQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7341 (re-sending with REST on Cc, as requested at the community call) At present we use a mix of Makefile and Kconfig driven capability checks for tool chain components involved in the building of the hypervisor. What approach is used where is in some part a result of the relatively late introduction of Kconfig into the build system, but in other places also simply a result of different taste of different contributors. Switching to a uniform model, however, has drawbacks as well: - A uniformly Makefile based model is not in line with Linux, where Kconfig is actually coming from (at least as far as we're concerned; there may be earlier origins). This model is also being disliked by some community members. - A uniformly Kconfig based model suffers from a weakness of Kconfig in that dependent options are silently turned off when dependencies aren't met. This has the undesirable effect that a carefully crafted .config may be silently converted to one with features turned off which were intended to be on. While this could be deemed expected behavior when a dependency is also an option which was selected by the person configuring the hypervisor, it certainly can be surprising when the dependency is an auto-detected tool chain capability. Furthermore there's no automatic re-running of kconfig if any part of the tool chain changed. (Despite knowing of this in principle, I've still been hit by this more than once in the past: If one rebuilds a tree which wasn't touched for a while, and if some time has already passed since the updating to the newer component, one may not immediately make the connection.) Therefore I'd like to propose that we use an intermediate model: Detected tool chain capabilities (and alike) may only be used to control optimization (i.e. including their use as dependencies for optimization controls) and to establish the defaults of options. They may not be used to control functionality, i.e. they may in particular not be specified as a dependency of an option controlling functionality. This way unless defaults were overridden things will build, and non-default settings will be honored (albeit potentially resulting in a build failure). For example config AS_VMX def_bool $(as-instr,vmcall) would be okay (as long as we have fallback code to deal with the case of too old an assembler; raising the baseline there is a separate topic), but instead of what we have currently config XEN_SHSTK bool "Supervisor Shadow Stacks" default HAS_AS_CET_SS would be the way to go. It was additionally suggested that, for a better user experience, unmet dependencies which are known to result in build failures (which at times may be hard to associate back with the original cause) would be re-checked by Makefile based logic, leading to an early build failure with a comprehensible error message. Personally I'd prefer this to be just warnings (first and foremost to avoid failing the build just because of a broken or stale check), but I can see that they might be overlooked when there's a lot of other output. In any event we may want to try to figure an approach which would make sufficiently sure that Makefile and Kconfig checks don't go out of sync. Jan From xen-devel-bounces@lists.xenproject.org Thu Jan 12 17:07:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 17:07:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476340.738451 (Exim 4.92) (envelope-from ) id 1pG13C-0002z7-HV; Thu, 12 Jan 2023 17:07:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476340.738451; Thu, 12 Jan 2023 17:07:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG13C-0002z0-El; Thu, 12 Jan 2023 17:07:38 +0000 Received: by outflank-mailman (input) for mailman id 476340; Thu, 12 Jan 2023 17:07:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG13B-0002yu-2q for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 17:07:37 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9a414363-929b-11ed-b8d0-410ff93cb8f0; Thu, 12 Jan 2023 18:07:33 +0100 (CET) Received: from mail-mw2nam04lp2173.outbound.protection.outlook.com (HELO NAM04-MW2-obe.outbound.protection.outlook.com) ([104.47.73.173]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 12 Jan 2023 12:07:32 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SA1PR03MB6530.namprd03.prod.outlook.com (2603:10b6:806:1c5::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Thu, 12 Jan 2023 17:07:26 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5986.018; Thu, 12 Jan 2023 17:07:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9a414363-929b-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1673543254; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=GsS+vEKyi7Jr/4YI9jEMDy8equIHYDeAWTzYCbpamrY=; b=XgXkhdYBuYsjNUbgtwTPoNV0x7c+Ak3PC0HNgfdjMTOrf1J8huBb3UDB Sqvo52ejpYZjmISPJux/MUSuzXpkHQA1SfEBkOPSnwmZgXY/bM/Kpqbn9 B2xhItYUXLASJLxQSXXFnM0t5pYkCITCDoQrlEbiwePIUeHvQUDwAiC27 I=; X-IronPort-RemoteIP: 104.47.73.173 X-IronPort-MID: 92390044 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:LJ7ZdqOt9IIbmpDvrR2HlsFynXyQoLVcMsEvi/4bfWQNrUp01DYHn zMXXWmDOv+IMGSketB2PYyyp0xSupbSxtVnSQto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQA+KmU4YoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9Suv3rRC9H5qyo42tB5wZmP5ingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0rgwKDtS9 9A6EykIcBqP1+OH5aiFV+Y506zPLOGzVG8ekldJ6GmFSNMZG9XESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+vFxujeIpOBy+OGF3N79U9qGX8hK2G2fo XrL5T/RCRAGLt2PjzGC9xpAg8eex3iqANpOSNVU8NZkuEeYm09NOiEnUFe1usuwuEfgVI5Af hl8Fi0G6PJaGFaQZtv3UgC8oXWElgUBQNcWGOo/gCmSzoLE7gDfAXILJhZRZdpjuMIoSDgC0 l6Sg8ivFTFpqKeSS3+W6vGTtzzaBMQOBWoLZCtBSBRf5dDm+N03lkiWEY0lF7OphNroHz222 yqNsCU1m7QUi4gMyrm/+lfExTmro/AlUzII2+keZUr9hisRWWJvT9XABYTzhRqYELukcw== IronPort-HdrOrdr: A9a23:DDkcS6uK3YRj40v6tAYBsn9w7skDstV00zEX/kB9WHVpm6yj+v xG/c5rsCMc7Qx6ZJhOo7+90cW7L080lqQFg7X5X43DYOCOggLBQL2KhbGI/9SKIVycygcy78 Zdm6gVMqyLMbB55/yKnTVRxbwbsaW6GKPDv5ag8590JzsaD52Jd21Ce36m+ksdfnggObMJUK Cyy+BgvDSadXEefq2AdwI4t7iqnaysqHr+CyR2fiIa1A== X-IronPort-AV: E=Sophos;i="5.97,211,1669093200"; d="scan'208";a="92390044" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a26L1f1qeZR/LgFNerpF3BvEYpEUmnXN1F+Jk1WYp4Sd7GZ1ySkATuu8Or67O9eGsGbdQjuyWxV8cAJebTYkx5dmxGihZdUgxoWVccwi7qhfbjX2/35AIF8y2m9BgV8p+5MheLr2bYuFa92TZuDdAJ8rwXEDllPQrKn1MU3CYqNoLqNtVuOEu+uqHYFRaOrMzgDgDTfYGg0MnBRCsEN9/436/9RVEqJAT6CPY1G6+Pnox0e6RVRmvbb85zxN7RC2bKMe1NAc2k34JobUe9Rv0Y7iyO1WWwo77vY96ZXMChEzjuSBhnCYTnlwOIDzEVfrq3twRny6LpnvvWEcAIMXEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GsS+vEKyi7Jr/4YI9jEMDy8equIHYDeAWTzYCbpamrY=; b=f/vQtnhDpeCfp0swOI/RDsDsNP7aEyu11Wkq1k1TL42xHIo0Mg0aBAuqRRTeLBXVi7eIhf1CEq0yJpkpy8C8bM1WbFYRlxMCHWBRRIQxcArHm0dlQoNrxnKJvaMql9TrIxsIE84h7NFu/GgoaOgecaLahf4xGaFO83Ylcv3cI8vRrEliMdS1EG2etp9wLmOUMiAEfVopjC9sxlbbraDQZphAaFkSOaguSoHZk5hhAQrkDjPrrdncc9+sm09EkPh7pdCX+2Pg1RcmOwqw7v0isSL+Z5CldCy0CCZhL16cUNaZ6Xw6RYpRhG9/scG9fN25QAqYGLi8x+8pN9GBiSXoew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GsS+vEKyi7Jr/4YI9jEMDy8equIHYDeAWTzYCbpamrY=; b=X8Fh5+TWYI4ux8pYEXQHwW/q0IkgWrqVqdPkczAFbSo/AEKkZwi95cf2qUQk1ISTLX6QzfjSakpszE3N9niZ/G+bbFdusKzqkCXYmq3y2dKszE5K+Nsy9sm9pde7Ry5521FlgIjLo7Uu7jA/fkEjRCz5csm87jhlD7OopHFuu2I= From: Andrew Cooper To: Jan Beulich CC: Roger Pau Monne , Wei Liu , Xen-devel Subject: Re: [PATCH v2 1/8] x86/boot: Sanitise PKRU on boot Thread-Topic: [PATCH v2 1/8] x86/boot: Sanitise PKRU on boot Thread-Index: AQHZJReg9aEubjLXpkqfuIdyn2CTs66avfyAgABIhQA= Date: Thu, 12 Jan 2023 17:07:26 +0000 Message-ID: References: <20230110171845.20542-1-andrew.cooper3@citrix.com> <20230110171845.20542-2-andrew.cooper3@citrix.com> <27d830b1-a32b-1368-3c0e-e5de15da5000@suse.com> In-Reply-To: <27d830b1-a32b-1368-3c0e-e5de15da5000@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|SA1PR03MB6530:EE_ x-ms-office365-filtering-correlation-id: 384042a8-bb77-4210-585c-08daf4bf7b1b x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3yhO0GWa3ARtbLqVOj9g/ft1D6eK7IoF060aQ1jFgqwUiwWJw6MiZkyi/iKtzB3Ax6WKQKhHFA5U1p7z5rijbNxuBiOu678emPkFzjDs7wE1srm+XLRCgRg35BgQuo3OEu6q2NzNRQ/4A1fzWzh+XTa7mLKmKdoRHnr14zQCH+8S9utdMBpo7QYGtBO591kfD/YL6wofqoSSfVioup1G+xo+UO27AJY/FzxKrNBfCPhL0KRUpUae1TqnXBmyT8plUmpUUUgfGya4Ex1j4wXuR/dR+vwhkyJ2b+j6wdyGFy9DetLiq9h7CWsx0UQZnMeBfGLw1D/TRKFWTyLgyofEIMWr9Rgis82uuolxeA+OM2vsCc1EU2pTTLFz/5ids43GktTdeeAQhrnJVopUQ5AjfrnVFt+n2ikdKLYq3ybC24gVo/PBi1zCBm0T3IO5THmmMRgsBm0KcU7FpLwi/TtDm/LzbAWhNzIu/V5c5qjaW+Y1Y+8hcx6WNHTrRn5aJCuIjC4KHzkvGoVU6VYjtLPUmMTZkTRD+DhoNQf7fXIHCrsgDbVdru7ZN2uJsAF0crwYE2Wq4S3fldn/aiwLaB8wbQrVOw6Eo93KHDNkgl3GEObVSTVfHwE9gM+yNFUU6D9djZWzZSGYEccvRysPJumFBcxVEB1uyKV800KlW3lheAixzALvS4UGEFW1iZo27Ikvzot2u1b5DMdwJFet2Dd2Hcmc4mt7k/JFXGK3EVA7HNTHNAvgPJ2lEO8UkZK/YEMnGDN0mSLci7cUZFdHEvfyAQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(366004)(376002)(136003)(396003)(451199015)(26005)(8936002)(71200400001)(5660300002)(2906002)(41300700001)(66446008)(66556008)(4326008)(8676002)(316002)(6916009)(76116006)(64756008)(66946007)(66476007)(91956017)(54906003)(38070700005)(6512007)(38100700002)(2616005)(122000001)(31686004)(86362001)(186003)(31696002)(53546011)(83380400001)(82960400001)(36756003)(6506007)(478600001)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?QlNDUE1VRmJTTnpmZS9mN2xyV3duRTRFc3pVTnVvNCt4b0ZnRjhoTDZZSW9F?= =?utf-8?B?SzhyekphNFc3YkZZYzNaa1pHY0MvNUh1OCtUV20xRXQ5WkdRVkgraFNvckht?= =?utf-8?B?aTIraE1VbjVXZmNlRmNQaXZXaTFYaWhra2FZRzFLMmFjWUlZL0JWUGNZaUlU?= =?utf-8?B?TFV4T0tHc2pZR0lhWUNnQzBrL1NRVmIweVdpT2JWZDdOSXdVNWpnRFJ4WkNL?= =?utf-8?B?YzBLNnNMY2pSclZuQzdVUzNaUVFQbHovOEp4WVBWVllwcDhWelNFR0NGSUxw?= =?utf-8?B?dDRNTTR1TU9TWiswRDlCUEpjN1hIRW5mcXJONklrTkRRRyt4YUNrWjJjSFRu?= =?utf-8?B?RktrRzdma253bHNiM0JaS1pFNGYzYUdKS1JMb3FIR3M3elpiMVRDNEJaNHMv?= =?utf-8?B?MWNCZnFsSGxaL2ozK2xBWHFRQVZsaWNzTmxzMDV6eGIwQ0RDaFJYa3Z5L01K?= =?utf-8?B?bU0weXhMT2YzcENJQmV0dUlXQ0YvNkJjNXVzZ013djNwSE5ORnd4YXpsZS95?= =?utf-8?B?NlkzdEtWdGFMaTFHeGJxOTRyVFVwQU1lOXE2OHp2ZnhBTmppQzRBVzN4QlVx?= =?utf-8?B?WjR3UG5UeFlhMmdmSUU1dk4xcnJhSUlSVGxQa3U4bndSdkhUSnhGZ1F6Vk9E?= =?utf-8?B?RHhpSFNZV1ZCMU1KazRvNlFPU0VLbllEQVFqU290VjA5VnJXeHJTZXJUK1Yr?= =?utf-8?B?SVJyKy9uVXUrNmg1TU9UNEpUN29ua3lxZlZMS3VLeW5BeTFPRWowWXVNUmZV?= =?utf-8?B?SXNma1QxakxtZkMrbjRISHg5Qlg1dHM1MmtjUCtDRHJBalZOWFk0RzhkbEcr?= =?utf-8?B?UHorcTBneFhsVHBmU3RZMnRkUjA1RzVqM2tWK2ViR2pkbUZSOWJrNVAyR2Nz?= =?utf-8?B?U0dRRlQxTlRrMTdLend1L2hDcnFTSGpndXJScm5ZQ3BTSGM4RXJOR2hmcmpE?= =?utf-8?B?Ry9qVEZhd1YrOTBDU0YraFY4c2xWaG9HRkpYWEx3d3B0bGFITTVZRnVsTmZr?= =?utf-8?B?c1FYRUc5K3BIT3RIVDA3RTFIODVvUE9ReFZmZHdzN1llOEVObytrMVRKdWtp?= =?utf-8?B?alNwUEl4Y3FndldkSW5OWThCanRqYkxEUkxZYVZsMmo4QVF3MXdFVCtYQmEv?= =?utf-8?B?K2I3VGcyeVB1L2tBbzJZMmR5MS95aWd1My9vU1VXYnZxYXBtQjZEMEcrK0pJ?= =?utf-8?B?VnVzYTVOMjhtNHZzaCttU2o3eUN3NkVnSmJSSXY3SU5nKzF6UHUrNEcxaHJH?= =?utf-8?B?dDZJbzNuTGJKNmpMclZndEgvK0tLdExkT1JjRlI1R3VJRjlyRFRvMldiWEFF?= =?utf-8?B?NHgrVlFIK3JuZzh4WXZEM1JlcmNON2o4SlJTaURMa05xOXZCdytNdWszUlJW?= =?utf-8?B?Y25QakNvSWxHODV4aUZWOGxSWmNhcHAxZWZJc0ltdWRET25iM2oxWG9nQTkz?= =?utf-8?B?dytnamRFWWQ3YVJHUU5heEE2YmhRb3RJcXdKeUw5SGJZR3JMSlRhcmUrdzJ6?= =?utf-8?B?dmIzSWZHOXdRVHU4UDRjYXVWR2JIYmF3RkExUVJQbzE2a1YwVlRURzJCZ2Fn?= =?utf-8?B?TDdyYnFKanE1V040M2EzTkF2alFMYXMvK2tGWDFDb1BPdmFtK084N2I2cWRB?= =?utf-8?B?WGovOVpLYzNSUUZ3L0U4akRHS1hyNkJ1ME1NT253cFF5L0pSemZybnNJV3E2?= =?utf-8?B?Q1gzSTM4REEwazNSTkdIRys1RDFkYzFobzlROWtUQjc3Wkt0NWliZE5ONXJ5?= =?utf-8?B?VktQM3JxUGtzSWw4dENzRUsyVUc1dmR1NFNTNVdPdnJSSjNCUzUwQS8wZ05z?= =?utf-8?B?b3hZUDBJQUFKOVp6VCt2VzhWVUxJZzFLT0ZSVTdVK2QxVEoyRzhKZkVnRzhp?= =?utf-8?B?aXg0Z3gyREpkd0J4azQ5YWs5NjZ4Z3I2RE9Lejg4S09Ed1dQYytFVnZJKzZk?= =?utf-8?B?QmQyUzVKd2dqK1pyQ3MvRXVIdUNacmRGOTVnQ3dyNzMzb09FTWErdEFSak5V?= =?utf-8?B?WFVVcnlJV0IvaGw4Y0RSQzFXZWgyemlNZjN4aWNJSVFKVUVkN1BDNnNHVy9x?= =?utf-8?B?aVZENjBGUG9VbjRDTmtiT2FLL0JxN2pCWk1NckJNYXlnUkRxY25OTWcwSVpM?= =?utf-8?B?OHN4UXRqckt3SWl3Y2NCTnlpeXZQajBCYy92TzJwb3liRHdieHVXWXFMQWlN?= =?utf-8?B?QlE9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <1725C87D6B4F0B4EB1EFA19C0AE04CAF@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: A9yg2KGlOMYw/JVKK6I9/yrSWmAlHb3vX+rKcH3U+s+iWObWDEw7/VWjlwXp8DEIizCDHV2KvneJkVzjcf4ZmeODuiPgegC7thjxX6vSe7aUkfU9YjO+rJZq98nZNQH7TMW7tmDmh4gaBLeSB6Gqv3uSd+9WO8Xe0uy6zSkfr3iA8jIssbCW73UvcWTq5RYlrzqwySeKlrvchUEVodnRIUII2begwYFVzzCyvUbUUke/ihiBI8tbkpExtsv8izJNWjJVJB4VTTp+RX0eEc+yHJI5QeSz8UVfnZemd3+d01MJbkE3apiUItic5q5x5/EU+hiSfbsZKSaV1WPTKKx+S/6Db9pe/cDSzXkb8nPCn/Oi7ul1dkYPmFrzqQGL+wqOM+TDOUtm53SF4ZR1Z9DBO1zRwnDhCDpXY3WlNpukL0WVdmO/51nzozgAoVsSymM5ViN9mrpnrPFLxk3YigkwdULgXNedEWjQSQafN7CVvLzZHBQ32/kD5v7vGRupUh1LYmyoJjXjU6O4nXXw3+8P00eMDx5+O6RA9Qd564DcnQeWhzFc0uNJL017rxpMDAN99zMdtc7cW4H21R+Q8Fw3HE3Qpeu/X24tO9rvz9GhzgNX7QhDqw7FM8Hp19SwZOHaGi9SS1P0ChrjiXVzzNalknonbLoGGUHb9jOx/C8R0c+YiSxDkz55HBaZn41fOigpFXeEIFG2pi9u/OFPMgkPCF1WfczpDkeMbvSVHdoFQ0lQtENvsqfsr6zym23xuyII7SHv4XbbvdhD7RPkYYbmi8atLNUgBgUP/gagSbeq8GubwnACqjmO3+8u5Kr3NyRM X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 384042a8-bb77-4210-585c-08daf4bf7b1b X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jan 2023 17:07:26.7198 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PMXvwRffPYagNf/An7YPzszloUCVf8Y8CJxNfXkBhqfzGeuzoGx4p5bsV66E/L9Lsl5/WGSjorOOdscIEjig8gds+GHvB8mQ0KXU1BUoqEw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6530 T24gMTIvMDEvMjAyMyAxMjo0NyBwbSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDEwLjAxLjIw MjMgMTg6MTgsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBXaGlsZSB0aGUgcmVzZXQgdmFsdWUg b2YgdGhlIHJlZ2lzdGVyIGlzIDAsIGl0IG1pZ2h0IG5vdCBiZSBhZnRlciBrZXhlYy9ldGMuDQo+ PiBJZiBQS0VZMC57V0QsQUR9IGhhdmUgbGVha2VkIGluIGZyb20gYW4gZWFybGllciBjb250ZXh0 LCBjb25zdHJ1Y3Rpb24gb2YgYSBQVg0KPj4gZG9tMCB3aWxsIGV4cGxvZGUuDQo+Pg0KPj4gU2Vx dWVuY2luZyB3aXNlLCB0aGlzIG11c3QgY29tZSBhZnRlciBzZXR0aW5nIENSNC5QS0UsIGFuZCBi ZWZvcmUgd2UgdG91Y2ggYW55DQo+PiB1c2VyIG1hcHBpbmdzLg0KPj4NCj4+IFNpZ25lZC1vZmYt Ynk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+DQo+PiAtLS0NCj4+ IENDOiBKYW4gQmV1bGljaCA8SkJldWxpY2hAc3VzZS5jb20+DQo+PiBDQzogUm9nZXIgUGF1IE1v bm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+DQo+PiBDQzogV2VpIExpdSA8d2xAeGVuLm9yZz4N Cj4+DQo+PiBGb3Igc2VxdWVuY2luZywgaXQgY291bGQgYWxzbyBjb21lIGFmdGVyIHNldHRpbmcg WENSMC5QS1JVIHRvbywgYnV0IHRoZW4gd2UnZA0KPj4gbmVlZCB0byBjb25zdHJ1Y3QgYW4gZW1w dHkgWFNBVkUgYXJlYSB0byBYUlNUT1IgZnJvbSwgYW5kIHRoYXQgd291bGQgYmUgZXZlbg0KPj4g bW9yZSBob3JyaWJsZSB0byBhcnJhbmdlLg0KPiBUaGF0IHdvdWxkIGJlIHVnbHkgZm9yIG90aGVy IHJlYXNvbnMgYXMgd2VsbCwgSSB0aGluay4NCg0KWWVhaCAtIEkgYWJzb2x1dGVseSBkb24ndCB3 YW50IHRvIGdvIGRvd24gdGhpcyByb3V0ZS4NCg0KPg0KPj4gLS0tIGEveGVuL2FyY2gveDg2L2Nw dS9jb21tb24uYw0KPj4gKysrIGIveGVuL2FyY2gveDg2L2NwdS9jb21tb24uYw0KPj4gQEAgLTkz Niw2ICs5MzYsOSBAQCB2b2lkIGNwdV9pbml0KHZvaWQpDQo+PiAgCXdyaXRlX2RlYnVncmVnKDYs IFg4Nl9EUjZfREVGQVVMVCk7DQo+PiAgCXdyaXRlX2RlYnVncmVnKDcsIFg4Nl9EUjdfREVGQVVM VCk7DQo+PiAgDQo+PiArCWlmIChjcHVfaGFzX3BrdSkNCj4+ICsJCXdycGtydSgwKTsNCj4gV2hh dCBhYm91dCB0aGUgQlNQIGR1cmluZyBTMyByZXN1bWU/IFNob3VsZG4ndCB3ZSBwbGF5IHNhZmUg dGhlcmUgdG9vLCBqdXN0DQo+IGluIGNhc2U/DQoNCk91dCBvZiBTMywgSSB0aGluayBpdCdzIHJl YXNvbmFibGUgdG8gcmVseSBvbiBwcm9wZXIgcmVzZXQgdmFsdWVzLCBhbmQNCmZvciBwa3J1LCBh bmQgYW55IGlzc3VlcyBvZiBpdCBiZWluZyAid3JvbmciIHNob3VsZCBiZSBmaXhlZCB3aGVuIHdl DQpyZWxvYWQgZDB2MCdzIFhTQVZFIHN0YXRlLg0KDQoNClRoYXQgc2FpZCwgSSdtIHdhbnRpbmcg dG8gdHJ5IGFuZCBtZXJnZSBwYXJ0cyBvZiB0aGUgYm9vdCBhbmQgUzMgcGF0aHMNCmJlY2F1c2Ug d2UncmUgZmluZGluZyBubyBlbmQgb2YgZXJyb3JzL292ZXJzaWdodHMsIG5vdCBsZWFzdCBiZWNh dXNlIHdlDQpoYXZlIG5vIGF1dG9tYXRlZCB0ZXN0aW5nIG9mIFMzIHN1c3BlbmQvcmVzdW1lLsKg IFNlcnZlcnMgdHlwaWNhbGx5IGRvbid0DQppbXBsZW1lbnQgaXQsIGFuZCBmaXhlcyBlaXRoZXIg Y29tZSBmcm9tIGNvZGUgaW5zcGVjdGlvbiwgb3IgUXViZXMNCm5vdGljaW5nICh3aGljaCBpcyBh YnNvbHV0ZWx5IGJldHRlciB0aGFuIG5vdGhpbmcsIGJ1dCBub3QgYSBncmVhdA0KcmVmbGVjdGlv biBvbiBYZW4pLg0KDQpCdXQgdG8gbWVyZ2UgdGhlc2UgdGhpbmdzLCBJIGZpcnN0IG5lZWQgdG8g ZmluaXNoIHRoZSB3b3JrIHRvIG1ha2UNCm1pY3JvY29kZSBsb2FkaW5nIHByb3Blcmx5IGVhcmx5 LCBhbmQgdGhlbiBmaXggdXAgc29tZSBvZiB0aGUgZmVhdHVyZQ0KZGV0ZWN0aW9uIHBhdGhzLCBh bmQgY2xlYW5seSBzZXBhcmF0ZSBmZWF0dXJlIGRldGVjdGlvbiBmcm9tIGFwcGx5aW5nDQp0aGUg Y2hvc2VuIGNvbmZpZ3VyYXRpb24sIGF0IHdoaWNoIHBvaW50IEkgaG9wZSB0aGUgbGF0dGVyIHBh cnQgd2lsbCBiZQ0KcmV1c2FibGUgb24gdGhlIFMzIHJlc3VtZSBwYXRoLg0KDQpJIGRvbid0IGV4 cGVjdCB0aGlzIHdvcmsgdG8gaGFwcGVuIGltbWluZW50bHkuLi4NCg0KfkFuZHJldw0K From xen-devel-bounces@lists.xenproject.org Thu Jan 12 18:15:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 18:15:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476347.738463 (Exim 4.92) (envelope-from ) id 1pG26g-0002Ik-Fx; Thu, 12 Jan 2023 18:15:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476347.738463; Thu, 12 Jan 2023 18:15:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG26g-0002Id-DF; Thu, 12 Jan 2023 18:15:18 +0000 Received: by outflank-mailman (input) for mailman id 476347; Thu, 12 Jan 2023 18:15:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG26e-0002IX-9I for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 18:15:16 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG26d-000845-4z; Thu, 12 Jan 2023 18:15:15 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.11.96]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pG26c-00013C-U6; Thu, 12 Jan 2023 18:15:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=0T6CmS7Lj1GKJYo6rIwFronkiooLLAtVG9BDyYYAS1E=; b=Y7UtwD7uT2UscZgSumLEQvRnSX Rri3vynsOQIGbRL3mH3YyYuSnXyQFINTykD2NkIG9YerZz8IIjjRR1zxeXW76hOwYQpRUxy40tnnH dMZQIaPGEpgvMGfWMJkpJy1YdbLfpws/+7AGOGioQ4hpw5em90p6vmvamOT68VaSGaU4=; Message-ID: Date: Thu, 12 Jan 2023 18:15:12 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] include/types: move stdlib.h-kind types to common header Content-Language: en-US To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Bertrand Marquis , Volodymyr Babchuk References: <5a0a9e2a-c116-21b5-8081-db75fe4178d7@suse.com> From: Julien Grall In-Reply-To: <5a0a9e2a-c116-21b5-8081-db75fe4178d7@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 12/01/2023 14:01, Jan Beulich wrote: > size_t, ssize_t, and ptrdiff_t are all expected to be uniformly defined > on any ports Xen might gain. In particular I hope new ports can rely on > __SIZE_TYPE__ and __PTRDIFF_TYPE__ being made available by the compiler. > > Signed-off-by: Jan Beulich Acked-by: Julien Grall I also don't have any strong opinion either way about continuing to use types.h or introduce stddef.h. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Jan 12 18:24:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 18:24:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476354.738474 (Exim 4.92) (envelope-from ) id 1pG2Fm-0003p4-H6; Thu, 12 Jan 2023 18:24:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476354.738474; Thu, 12 Jan 2023 18:24:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG2Fm-0003ox-Dv; Thu, 12 Jan 2023 18:24:42 +0000 Received: by outflank-mailman (input) for mailman id 476354; Thu, 12 Jan 2023 18:24:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG2Fl-0003oq-0j for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 18:24:41 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5e6d618e-92a6-11ed-91b6-6bf2151ebd3b; Thu, 12 Jan 2023 19:24:39 +0100 (CET) Received: from mail-bn8nam12lp2177.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.177]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 12 Jan 2023 13:24:30 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by PH0PR03MB6234.namprd03.prod.outlook.com (2603:10b6:510:ea::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Thu, 12 Jan 2023 18:24:27 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::c679:226f:52fa:4c19%6]) with mapi id 15.20.5986.018; Thu, 12 Jan 2023 18:24:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5e6d618e-92a6-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1673547879; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=Kv7SYk6PubM4TjXQAt73Phr45Sl1rUK9hEL18EWdA8M=; b=gU/hPu8G/A299bUS1O3Jj3UnFl7+fhFEIsBGJe90Od8rMG27z8G/wu3E P7TCczeO74GxJXaxvbgdNYqVCiyBotJfce8Dpem9OGZ2jaG7ek9RgfMDo DvgCdp5tV0IFMNlBjX+FPn58yavY3O43Hn0ijAYE+imas4iFmUWoepqVO Q=; X-IronPort-RemoteIP: 104.47.55.177 X-IronPort-MID: 91829565 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:Dazqlqnb+EbW3ZTylEGNevDo5gxEJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xIcDTyGb66KN2XyKI11O4iw9EIFvsTRmNc3TgNo+XgxESMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icf3grHmeIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7auaVA8w5ARkPqgS5QWGzRH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 fkDGCoKYkCMvLiNy723dO4vmsF7NuC+aevzulk4pd3YJdAPZMmZBo/stZpf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkVE3ieeyWDbWUoXiqcF9t0CUv G/ZuU/+BQkXLoe3wjuZ6HO8wOTImEsXXapDTe3ip6M03TV/wEQxJxAPSXmmoMKHl0yTA/1ZL xcd1ioX+P1aGEuDC4OVsweDiHSZpAwVX91cFPIzwA6Iw6vQpQ2eAwAsTDRMddgnv88eXiEx2 xmCmNaBLSRmrbm9WX+bsLCOoluaKSUTaGMPeyIAZQ8E+MX45pE+iArVSdRuG7Lzicf6cQwc2 BiPpSk6wr8V3cgC0vzh+Uid2m3z4J/UUgQy+wPbGHq/6R90b5KkYIru7kXH6fFHL8CSSVzpU GU4pvVyJdsmVfml/BFhis1UdF11z55p6AHhvGM= IronPort-HdrOrdr: A9a23:SzDMYqMu9MuIAcBcTgWjsMiBIKoaSvp037BK7S1MoH1uA6mlfq WV9sjzuiWatN98Yh8dcLO7Scu9qBHnlaKdiLN5VduftWHd01dAR7sSjrcKrQeAJ8X/nNQtr5 uJccJFeaDN5Y4Rt7eH3OG6eexQv+Vu6MqT9IPjJ+8Gd3ATV0lnhT0JbTqzIwlNayRtI4E2L5 aY7tovnUvaRZxGBv7LYEXsRoL41qT2qK4= X-IronPort-AV: E=Sophos;i="5.97,211,1669093200"; d="scan'208";a="91829565" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HlwwafbivKOmOpmlXKehDy7zDfPclirSjXA4yRz52Y4hA2tuZBzcaj94w14mGbI95y5iPxxiek/FlY0fzYtwWFn/6wzY3Q9Hw8890NXHd0MfCHFxC5nx7oM06QaMrCNM1ZC5U0dUF1U44jN4qJbKi/eyTU12UxQ+bMAV+CHNQqjDi54TD2t/XDJ7egOgT1Ncl0IdckXmd37OP5AcT/Rk4+5HPO+pQmAjLeHZ3S4vcoL1fWtjKRu7De18soKKB6Dmgx6vbYfeVzVj3U833WwfuiMlSMv1UsZafcosgTY9DZTrKrnDzduCG4W9U3FOhJkRlTHrpgKmiqSTPx0djstrKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Kv7SYk6PubM4TjXQAt73Phr45Sl1rUK9hEL18EWdA8M=; b=BIu9vqyGry3CbuvTv7zvsV3X1uu4ZXdzk6sFluufQ3jVYjm3Q1FTzEqDZF85ZpLeJKVzfNkresRz9OY0jJEYwbLaoBkhCb3UQGApdvQ9YHV/tx/ajYCNS8bHAGcd+/TtNH7t5YbKdji1vStngiF2Jy4pKpE3KlVnnsnQ8rgbh3nnWcUgkhMgdHeT4Ji0MC+SIY07WBcTpW00C2sN7XHytNNfoCFMry88DlD+WxEggd3uVyB+zROteGpJtoBWXUy8RBUXczznagUtTCSByFSDuVy4+k9QnBahHzKUGkAOekykbH7LbZuA0pcoEzScbH5lVpH/OFbSmLColXYfM9lKkw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Kv7SYk6PubM4TjXQAt73Phr45Sl1rUK9hEL18EWdA8M=; b=M3qEW9ktdFlxw5VFEO3IzE5VacXYSz9WQrgQ412ZLfJRiaNSd8pjQItM5/AnYQ34iKIHJQd8L4YrnTYH5arWn2fW1LCQ72IF2iO9NQfE6M00F+jz2oekIfRkUsQrBeyNawMokvwoBLR3L6xBKv8TRBrekclKNGMclEDbRqWFQUw= From: Andrew Cooper To: Xenia Ragiadakou , Jan Beulich CC: Paul Durrant , Roger Pau Monne , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH v2 3/8] x86/iommu: iommu_igfx, iommu_qinval and iommu_snoop are VT-d specific Thread-Topic: [PATCH v2 3/8] x86/iommu: iommu_igfx, iommu_qinval and iommu_snoop are VT-d specific Thread-Index: AQHZIBjlmMJMZF8p3USyswha31M+3K6asoyAgAAE+gCAAEGaAIAALOIA Date: Thu, 12 Jan 2023 18:24:26 +0000 Message-ID: <0e21b24e-d715-bd04-f98c-4cdd53f129ee@citrix.com> References: <20230104084502.61734-1-burzalodowa@gmail.com> <20230104084502.61734-4-burzalodowa@gmail.com> <4bc3f2f6-9bf4-5810-89e3-526470e72d85@gmail.com> In-Reply-To: <4bc3f2f6-9bf4-5810-89e3-526470e72d85@gmail.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|PH0PR03MB6234:EE_ x-ms-office365-filtering-correlation-id: d9b95448-ec16-4a02-e5d3-08daf4ca3d03 x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Zxi/nB4HTBWWVShbSDCVAETK6loLM2mPvVFcR69+aBwyq/1f9Hi7rRMpDtoOVa4DOlnVTfRjQpY0x8XyJLG4FCLCGyzxjg0j12MaxezFJ/Zye6uR/lL6gV3ztj4HxYBROiE+oVo/HlrS0Zzu2EDjCgL+NSk9w81ublIrROb/LiSvLNSEde0JM532fUbGwnt6WZ/tf76ZTEB1Bwm+2+u04h8HrZKWUEc02O3Y+jo5+W14GsXBHnv+fnuiCgEmedZ+kzscVS69uCVPilxcn7nAvOFavL3Ef+RlWa6AwJJP6utWt2p2mVu1AjoLWtLcUTUhRCssUTe2e5irO1/zjumyNi94hnYmEAFiLcY42CLXJOLnDk6EoW9XLr7zil7HCM+6GopPjU18YgQ8HetefOhvMETPRqC2w3bIjgcW1UEOez4P4kprtDW/N4iMB3t98F78HO4rlzu/lnSypIgnOJqo33S2+MS8JA4eJYuLFTzSdtAl60BQHNQMmBNpBeTCyVtxt5Y/Ivg5R8R6cxvepHrkpmTO8xKv3lSF2BE5Rb/EBvNM5WMNgFOzBSPjW3issnWizeeNsT+UC03nttLlpOjepOydTOqCmUW2/mnx5X4GuHL9SKPSX1/PCcvgVA88wFDi96iGMXdMaMGerPeOInA4UjcCp0gk9N5z94LKfm+RU9Lw0MHWsLXzX0NEfntKEscX/kwYhWAzBcaAl3BEfJHVWfyUSAwCtY/nmQYXgddBFxz0kuMtC1xaMpdkSReeigdJzLAwJBFZKp2/1q9uATNgkA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(136003)(376002)(39860400002)(346002)(396003)(451199015)(86362001)(316002)(71200400001)(6512007)(26005)(5660300002)(186003)(478600001)(6486002)(2616005)(91956017)(31696002)(41300700001)(64756008)(66556008)(66446008)(4326008)(54906003)(66476007)(66946007)(110136005)(76116006)(38070700005)(83380400001)(8936002)(36756003)(8676002)(53546011)(31686004)(6506007)(122000001)(82960400001)(38100700002)(2906002)(66899015)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NTZ2TWNTaFV1ZFBQUGFOYW1sRmZyY3ltMUJiNklYZjR6MUkvcWl4VHBGMHlq?= =?utf-8?B?anNFTTVpNVZyVmtiaUVheGZnT25vOTh6cFZLeFRpNkt6czZMdk5wTnNSNGtS?= =?utf-8?B?N1FwSlEwWEY3SitMamlRbnVtZ1lHL1E4L1Z4M2lhNXlQRFA0RU5NM2lTQUxm?= =?utf-8?B?dTVBVVNsVVRNaUxuZVZPdFlEQjZXOEs0K0RFajhBUWtPTTZ1Yk9xdndTbE95?= =?utf-8?B?ZUQzMjV2UzZOeS9PME4zMG1yTXdKcVVrNEFZQS9CdVA5NzJkcjFsY1lXc1I1?= =?utf-8?B?NC9NYm1iU3E1WXBzYldGUGVORDlTZ1VFblRaSlovRENJTHozbXNaK0RENXgy?= =?utf-8?B?V1FoNmF3c3dwdk1PcDMrT2Z3WWVLN2h2dlBlOTZieVMvSzlUaGJnWXJ3ZUZV?= =?utf-8?B?L1BjN1FQeGMxUDdxYWlUMzE1emxvL0MwdWx1dkhzUlVNdzdsY01YSytkcUFK?= =?utf-8?B?OHIvcE14R1lUMldULytUNmlJVTR2VE05OENiT2hDcENSblVnaWQyb3d3SS9s?= =?utf-8?B?WG92ay9kMGhQb1NEODhXSVcyVmJJVUQvQ2dTRzNMMEpCWkVzL2g3dHNzTkt0?= =?utf-8?B?WWVxT3kyUHN5UUtMbElTZXN0ejZpZkdqeGtFQ2l3WWcxMEd1c0JEVDRtQTc1?= =?utf-8?B?M1hFekNNcHI0MDFubGxoZmtzUWJwQWJuS1VROUIxbGxvWnJublU1c2xnN1Zl?= =?utf-8?B?MXdDRTg1aXA3a3BWeUxBNUE2ZjNBa25JcTc3bjNqNllmNlZ3VTRsbDdmMkJP?= =?utf-8?B?UUo3d085ZTlrdXdjeHoxM3pvWHVjL3Y0V09NdkpmWXhWcEdUR1lGL3hpNkh6?= =?utf-8?B?RkNYMTlEeXhYTWdreXBBakxTWm5HSXFobmdCUkRRL21xbjB3TTZBUmJ1d0Qv?= =?utf-8?B?dFo0SnpLNkZjVmMvN2pVaUVMbkNiN2R5S1R1dkdRd25zUS8zaWJvcjJrcENr?= =?utf-8?B?Q2VqemZzUDM4VXR0V25uWDdyd1FoU1ZHUktXaDlnb1QwSytHRVpjMUhpdHVD?= =?utf-8?B?MkV1QTMrN0hrcVNqMmkwbjV3R0x3TDk4RlBVM0hHQ0g2SGJZcnoxRkQyV01t?= =?utf-8?B?RXZ3OG1OYjZFMThTNDNIc1ZSQlJ1SXY3aEkzemh1SkZnT3F3K3BycHNZcW5n?= =?utf-8?B?NE9Eb0NYcFRMa0tMaWo3MGRrMGR3M0V1ZDgxUWtObEtLQWh0eGlFSndPM0lX?= =?utf-8?B?L20yT3NiU0s5OW9Mdi9MWGsvWVhXU2xkK21jMGRkU0lFc0lwek1nUW4waDFT?= =?utf-8?B?cGhwUWhsNDBtN1Z1U05iYlpHaEFqWmFKZEVPNndmV1JrYStwMDlDVWNxcElW?= =?utf-8?B?MGoxdHoyZVRmM0xRcXZtKzhySXpWMVVhM3Nxblh6SFVBd2gxcklxWG4wcWpu?= =?utf-8?B?UDVnNW5hcHdLMHZtQ1pJR2FYckdRcVZKSGVMQ3c5TE42RzBPN0Q1eHk4TWlo?= =?utf-8?B?WjBaSmV6cUdhUDlOL0hZTmRIdU5FeGwvcUw2UWFVL0RST2FpUE5idmVGbU1r?= =?utf-8?B?aXJSWkhPRExNTUlPcVdDNktCSTE3Y0xRTVdsdWdpZmZlMEFRQlZVSVNONjVq?= =?utf-8?B?di9kdHlQbS93M0xvcGlZUmF2dm9YVWNQNi96OHl3ZmZXRjVsaXA0KzhxQ1Ro?= =?utf-8?B?Nm5ra2dFNGJWTXdISFl4anc3VElKUDAycjMxUjY2Uko2elhNTVp2RUVzZkNH?= =?utf-8?B?blhTTE5mRmo5dm9uYWFTSW9PSTZjYUszOEIrV0lpOWJjTTVDVG9zcEM0eXJ3?= =?utf-8?B?STE2ZFlrdTB3ay9Xa2xFb3lGZ2FPck9FNDk0NjdhLzZodWtGenozbzRaaUtt?= =?utf-8?B?T3FnUlRLY3NrQkNRbklMbjlqMHRjSEdma09zY3JwajhJbmZ3cnRkMWlqdzRQ?= =?utf-8?B?TkFvY0JrdjZNeEQ1a2tyakllRDdtUkdCdnJpWlF3NmJzTjlKR0laM3ExMHlp?= =?utf-8?B?eXFtRjhZall3WHo3MUNjUG83V2dBMkJoWEMyaXM0SmV1UWNWUUtUNk9QUHhQ?= =?utf-8?B?cWdzdStaN0RJQTQyL244NEtLWHR5TGYza2psVmFMMlVwMFlBNWVUaStPM2g4?= =?utf-8?B?dGhJSUhZcmp2Umx5ZlIxVXJ4dFFPdUtWN25sOHJkdkpZYU9QdGIxQSt2VHZ0?= =?utf-8?B?blpOdkUzYTZLMzk1TGp4bEw0YkJwMU41VUlnWUx2TnBVVk9UdWthb29FZERF?= =?utf-8?B?VHc9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Ir5ybnVt3l4gcjLs/pW/HQqFd695Zb7scZCHlucEkymnyLiY9Qi42Uj2PWccIRA+twmGmBLaPuGH3uqmeNb5XEr/R/FAhx8wGPjN53qGAoDWBB6hL3M7kOu9/DvedbWtQp2qj6peb7Wyqn/Q0a2SldV+dRgH1Kb8BL5TomNxXDRlhJR64xPMyCcWUD8TxCeTs1kL+LV/7mwYHlq0MOCQ53PUCjIg6rmbayxdCUJ/PhAU+5rmu/SROvaFeQVOATOUe/pVOHltYAfcXx5mqStar4FSLbfNfhmiCrt4FaSs+DdFmnj+NnF0EAzXrT+f//f/94yFadrt/O5jz+c/XGXDnymeFwG9zXVUOtCjuwBuHpZZznPiJGDevXTije5ljh18I7lmm3JBfhI8eA+b8iDYBFf7rnsOobTa4MQHV7F/YpeWZuvFvIzUUanRaQj3LyMJ25EEwXEWlWf0HPlYd7Tg9oaHiNpoGONgegh5Nv+Bkprkh4IbAoqVVy2JWUY06uS1qbEsXD/AziBOJPAoycKw151vmC0ZczZHosCHNC533ilAuREaFVhmKin6nqVOxqHGUOqqvFYwG6OEHqnZbbqpDNsJZYuTHrk+7XzClw4gwxOcufLkA3M93R3UZqIRFFvvent1DlpUpknc1uliN+pQo0D6PNRY68m9rB3odnROoROeLdYgw4+WWKh7EU1rVVkBy+tnBh7G5PgtPQgAhTTS6UL5tAMqfCT6AWcaCM5FQi3YmjjTiTNpJYHt6K7Xtj/1zCcBc+Py9O5GahXUYDiBza8TqevftLyoY1PeA1I4p+au8SVm813dLh5Fbp0nCi1YJgcAB6CeZzOABiN5+aZOp/jcIsCIDy6+QlNVySgNFMI= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d9b95448-ec16-4a02-e5d3-08daf4ca3d03 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jan 2023 18:24:26.9958 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: iIhU7eViyC2bD5gub0WkCdn5OmW0tKYO47yGc+01FfjrpP7aMi7mXKHGgF1t+XWxD6EQOfybfW14hKqkW5s2AmPDHybV5ajN4JCAiiALdNg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6234 T24gMTIvMDEvMjAyMyAzOjQzIHBtLCBYZW5pYSBSYWdpYWRha291IHdyb3RlOg0KPg0KPiBPbiAx LzEyLzIzIDEzOjQ5LCBYZW5pYSBSYWdpYWRha291IHdyb3RlOg0KPj4NCj4+IE9uIDEvMTIvMjMg MTM6MzEsIEphbiBCZXVsaWNoIHdyb3RlOg0KPj4+IE9uIDA0LjAxLjIwMjMgMDk6NDQsIFhlbmlh IFJhZ2lhZGFrb3Ugd3JvdGU6DQo+Pj4NCj4+Pj4gLS0tIGEveGVuL2luY2x1ZGUveGVuL2lvbW11 LmgNCj4+Pj4gKysrIGIveGVuL2luY2x1ZGUveGVuL2lvbW11LmgNCj4+Pj4gQEAgLTc0LDkgKzc0 LDEzIEBAIGV4dGVybiBlbnVtIF9fcGFja2VkIGlvbW11X2ludHJlbWFwIHsNCj4+Pj4gwqDCoMKg wqAgaW9tbXVfaW50cmVtYXBfcmVzdHJpY3RlZCwNCj4+Pj4gwqDCoMKgwqAgaW9tbXVfaW50cmVt YXBfZnVsbCwNCj4+Pj4gwqAgfSBpb21tdV9pbnRyZW1hcDsNCj4+Pj4gLWV4dGVybiBib29sIGlv bW11X2lnZngsIGlvbW11X3FpbnZhbCwgaW9tbXVfc25vb3A7DQo+Pj4+IMKgICNlbHNlDQo+Pj4+ IMKgICMgZGVmaW5lIGlvbW11X2ludHJlbWFwIGZhbHNlDQo+Pj4+ICsjZW5kaWYNCj4+Pj4gKw0K Pj4+PiArI2lmZGVmIENPTkZJR19JTlRFTF9JT01NVQ0KPj4+PiArZXh0ZXJuIGJvb2wgaW9tbXVf aWdmeCwgaW9tbXVfcWludmFsLCBpb21tdV9zbm9vcDsNCj4+Pj4gKyNlbHNlDQo+Pj4+IMKgICMg ZGVmaW5lIGlvbW11X3Nub29wIGZhbHNlDQo+Pj4+IMKgICNlbmRpZg0KPj4+DQo+Pj4gRG8gdGhl c2UgZGVjbGFyYXRpb25zIHJlYWxseSBuZWVkIHRvdWNoaW5nPyBJbiBwYXRjaCAyIHlvdSBkaWRu J3QgbW92ZQ0KPj4+IGFtZF9pb21tdV9wZXJkZXZfaW50cmVtYXAncyBlaXRoZXIuDQo+Pg0KPj4g T2ssIEkgd2lsbCByZXZlcnQgdGhpcyBjaGFuZ2UgKGFzIEkgZGlkIGluIHYyIG9mIHBhdGNoIDIp IHNpbmNlIGl0IGlzDQo+PiBub3QgbmVlZGVkLg0KPg0KPiBBY3R1YWxseSwgbXkgcGF0Y2ggd2Fz IGFsdGVyaW5nIHRoZSBjdXJyZW50IGJlaGF2aW9yIGJ5IGRlZmluaW5nDQo+IGlvbW11X3Nub29w IGFzIGZhbHNlIHdoZW4gIUlOVEVMX0lPTU1VLg0KPg0KPiBJSVVDLCB0aGVyZSBpcyBubyBjb250 cm9sIG92ZXIgc25vb3AgYmVoYXZpb3Igd2hlbiB1c2luZyB0aGUgQU1EDQo+IGlvbW11LiBIZW5j ZSwgaW9tbXVfc25vb3Agc2hvdWxkIGV2YWx1YXRlIHRvIHRydWUgZm9yIEFNRCBpb21tdS4NCj4g SG93ZXZlciwgd2hlbiB1c2luZyB0aGUgSU5URUwgaW9tbXUgdGhlIHVzZXIgY2FuIGRpc2FibGUg aXQgdmlhIHRoZQ0KPiAiaW9tbXUiIHBhcmFtLCByaWdodD8NCj4NCj4gSWYgdGhhdCdzIHRoZSBj YXNlIHRoZW4gaW9tbXVfc25vb3AgbmVlZHMgdG8gYmUgbW92ZWQgZnJvbSB2dGQvaW9tbXUuYw0K PiB0byB4ODYvaW9tbXUuYyBhbmQgaW9tbXVfc25vb3AgYXNzaWdubWVudCB2aWEgaW9tbXUgcGFy YW0gbmVlZHMgdG8gYmUNCj4gZ3VhcmRlZCBieSBDT05GSUdfSU5URUxfSU9NTVUuDQo+DQoNClBy ZXR0eSBtdWNoIGV2ZXJ5dGhpbmcgWGVuIHRoaW5rcyBpdCBrbm93cyBhYm91dCBpb21tdV9zbm9v cCBpcyBicm9rZW4uDQoNCkFNRCBJT01NVXMgaGF2ZSBoYWQgdGhpcyBjYXBhYmlsaXR5IHNpbmNl IHRoZSBvdXRzZXQsIGJ1dCBpdCdzIHRoZSBGQw0KYml0IChGb3JjZSBDb2hlcmVudCkuwqAgT24g SW50ZWwsIHRoZSBjYXBhYmlsaXR5IGlzIG9wdGlvbmFsLCBhbmQNCnR5cGljYWxseSBkaWZmZXJz IGJldHdlZW4gSU9NTVVzIGluIHRoZSBzYW1lIHN5c3RlbS4NCg0KVHJlYXRpbmcgaW9tbXVfc25v b3AgYXMgYSBzaW5nbGUgZ2xvYmFsIGlzIGJ1Z2d5LCBiZWNhdXNlICh3aGVuDQphdmFpbGFibGUp IGl0J3MgYWx3YXlzIGEgcGVyLVNCREYgY29udHJvbC7CoCBJdCBpcyB1c2VkIHRvIHRha2UgYSBU TFAgYW5kDQpmb3JjZSBpdCB0byBiZSBjb2hlcmVudCBldmVuIHdoZW4gdGhlIGRldmljZSB3YXMg dHJ5aW5nIHRvIGlzc3VlIGENCm5vbi1jb2hlcmVudCBhY2Nlc3MuDQoNCkludGVsIHN5c3RlbXMg dHlwaWNhbGx5IGhhdmUgYSBkZWRpY2F0ZWQgSU9NTVUgZm9yIHRoZSBJR0QsIHdoaWNoIGFsd2F5 cw0KaXNzdWVzIGNvaGVyZW50IGFjY2Vzc2VzIChpdHMgbWVtb3J5IGFjY2VzcyBoYXBwZW5zIGFz IGFuIGFkanVuY3QgdG8gdGhlDQpMTEMsIG5vdCBhcyBzb21ldGhpbmcgdGhhdCBjb21tdW5pY2F0 ZXMgd2l0aCB0aGUgbWVtb3J5IGNvbnRyb2xsZXINCmRpcmVjdGx5KSwgc28gdGhlIElPTU1VIGRv ZXNuJ3Qgb2ZmZXIgc25vb3AgY29udHJvbCwgYW5kIFhlbiAibGV2ZWxzIg0KdGhpcyBkb3duIHRv ICJ0aGUgc3lzdGVtIGNhbid0IGRvIHNub29wIGNvbnRyb2wiLg0KDQoNClhlbiBpcyB2ZXJ5IGNv bmZ1c2VkIHdoZW4gaXQgY29tZXMgdG8gY2FjaGVhYmlsaXR5IGNvcnJlY3RuZXNzLsKgIEkgc3Rp bGwNCmhhdmUgYSBwaWxlIG9mIHBvc3QtWFNBLTQwMiB3b3JrIHBlbmRpbmcsIGFuZCBpdCBuZWVk cyB0byBzdGFydCB3aXRoDQpzcGxpdHRpbmcgWGVuJ3MgaWRlYSBvZiAiZG9tYWluIGNhbiB1c2Ug cmVkdWNlZCBjYWNoZWFiaWxpdHkiIGZyb20NCiJkb21haW4gaGFzIGEgZGV2aWNlIiwgYW5kIHdv cmsgaW5jcmVtZW50YWxseSBmcm9tIHRoZXJlLg0KDQpCdXQgaW4gdGVybXMgb2Ygc25vb3BfY29u dHJvbCwgaXQncyBzdHJpY3RseSBuZWNlc3NhcnkgZm9yIHRoZSBjYXNlcw0Kd2hlcmUgdGhlIGd1 ZXN0IGtlcm5lbCB0aGlua3MgaXQgaXMgdXNpbmcgcmVkdWNlZCBjYWNoZWFiaWxpdHksIGJ1dCBp dA0KaXNuJ3QgYmVjYXVzZSBvZiBzb21ldGhpbmcgdGhlIGh5cGVydmlzb3IgaGFzIGRvbmUuwqAg QnV0IGJleW9uZCB0aGF0LA0KZm9yY2luZyBzbm9vcCBiZWhpbmQgdGhlIGJhY2sgb2YgYSBndWVz dCB3aGljaCBpcyB1c2luZyByZWR1Y2VkDQpjYWNoZWFiaWxpdHkgaXMganVzdCBhIHdhc3RlIG9m IHBlcmZvcm1hbmNlLg0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Thu Jan 12 18:51:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 18:51:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476360.738485 (Exim 4.92) (envelope-from ) id 1pG2fS-0007HW-KS; Thu, 12 Jan 2023 18:51:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476360.738485; Thu, 12 Jan 2023 18:51:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG2fS-0007HP-FD; Thu, 12 Jan 2023 18:51:14 +0000 Received: by outflank-mailman (input) for mailman id 476360; Thu, 12 Jan 2023 18:51:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG2fR-0007H9-Gv; Thu, 12 Jan 2023 18:51:13 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG2fR-0000Z1-Ct; Thu, 12 Jan 2023 18:51:13 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG2fR-0001gl-1P; Thu, 12 Jan 2023 18:51:13 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pG2fR-0006qF-0w; Thu, 12 Jan 2023 18:51:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=omginXvNBLOzUs2ZsmhzlB+XKQAWMNz7i4pLjS0v7no=; b=Hl02TrQgCx5g226QD/rLHADuH6 S5RhCbq+oE/ejbzuzz1LhWUMB1wjENvXoOWPrIPAXMdA8ZxHRV0P45388eT1t16SDpAf0DYBbJvJ1 T8kpXhajjKnxNtFTTt0OOOF/g/ozkGStK1Oi7KKloLnreUyzTryRDQ6ix6ATPWImWIck=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 175747: all pass - PUSHED X-Osstest-Versions-This: ovmf=9d70d8f20d0feee1d232cbf86fc87147ce92c2cb X-Osstest-Versions-That: ovmf=e5ec3ba409b5baa9cf429cc25fdf3c8d1b8dcef0 From: osstest service owner Date: Thu, 12 Jan 2023 18:51:13 +0000 flight 175747 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/175747/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 9d70d8f20d0feee1d232cbf86fc87147ce92c2cb baseline version: ovmf e5ec3ba409b5baa9cf429cc25fdf3c8d1b8dcef0 Last test of basis 175740 2023-01-12 10:40:46 Z 0 days Testing same since 175747 2023-01-12 16:10:44 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Dionna Glaze Jiewen Yao Sophia Wolf jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git e5ec3ba409..9d70d8f20d 9d70d8f20d0feee1d232cbf86fc87147ce92c2cb -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Thu Jan 12 19:18:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 19:18:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476368.738496 (Exim 4.92) (envelope-from ) id 1pG365-0001if-P7; Thu, 12 Jan 2023 19:18:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476368.738496; Thu, 12 Jan 2023 19:18:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG365-0001iY-Lc; Thu, 12 Jan 2023 19:18:45 +0000 Received: by outflank-mailman (input) for mailman id 476368; Thu, 12 Jan 2023 19:18:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG363-0001iS-VO for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 19:18:44 +0000 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [2a00:1450:4864:20::630]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ebac9d24-92ad-11ed-b8d0-410ff93cb8f0; Thu, 12 Jan 2023 20:18:40 +0100 (CET) Received: by mail-ej1-x630.google.com with SMTP id vm8so47155552ejc.2 for ; Thu, 12 Jan 2023 11:18:40 -0800 (PST) Received: from [127.0.0.1] (dynamic-092-224-135-062.92.224.pool.telefonica.de. [92.224.135.62]) by smtp.gmail.com with ESMTPSA id b6-20020aa7d486000000b0048447efe3fcsm7496599edr.84.2023.01.12.11.18.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Jan 2023 11:18:39 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ebac9d24-92ad-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=znKsrcQI5eTxWw6koP5BmwfUjNK/TzPXrZHro2GI5WA=; b=Wl+jtIsFriABXsvXf6S4odSPfbDt4hEJ1RHb2+gg78+xqikxqT2QFN6fUVlX1YGsB/ 68iX7EMUXp7M0bFRIpJVRdi2t47OELjPLBINU8GPoNwSaFkQtPzloRXWZ5xfKW15dceu f+sdSnMC61oWlOVD4tCqBsqRrxU+zrGJvZONVIo+9BMG70Ev+WccXuSeZaCkJJ9hQAT3 gPE2LWi50yvQUGxEgY9G1hkYO19i4qd6KZiJgWcP5ZAW26fK1/UvJGBiQNuzl1j6sFnL 7rxwbMNyICpcg0CO4UYk+IeCVVf0sxcE4K30C3aCVpjOaALIVPm+7fOcII+oIqzSJv0/ 8vjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=znKsrcQI5eTxWw6koP5BmwfUjNK/TzPXrZHro2GI5WA=; b=MY4wu97sGqVmTGVeTJEp9DpUvsB1hIHP3NkN6aD2n0wFiVZ6EjtUZiuVgHciymo9dJ GYCFWHPtWzUXRhrXqgVTcFxk5StqqtBeP+XoEPe8YdGDV123kuLE+/xH+5PxK8zoHDsO OOwODM29kDEAjf/i2LbHEOWJYRe218aU8iftm4mMTWnUuoTRsDw//r2IUMVFSeN+Kgii WAEhyshEZPV4OtzaZWlnmsLt7QREpvXgw0tNcZbhixIIYtH1AsYEMIfJcbjB/cNjZksJ OwFfk+uGBJBM2K7FU74zyP5DQCKnytMtSTuDHXQjWNXKiiFhrqFZx/4Y/pFntc73306b ePfw== X-Gm-Message-State: AFqh2kpWzrHfJSXr1mY8f6P9YGexISw89mQwafPqxh1Gg0x5VWPrViX+ CQ/cNMzQ03vtWseHz4cMFFs= X-Google-Smtp-Source: AMrXdXv56uNTCYYXFq6lM/TortLCbgJXTPuzaeqNqvVDij57HiG55FXcZJQVWBmgtkxxMnqNNAZcRQ== X-Received: by 2002:a17:907:9a98:b0:7c1:d4c:f08c with SMTP id km24-20020a1709079a9800b007c10d4cf08cmr68854870ejc.4.1673551120068; Thu, 12 Jan 2023 11:18:40 -0800 (PST) Date: Thu, 12 Jan 2023 19:18:33 +0000 From: Bernhard Beschow To: Chuck Zmudzinski , "Michael S. Tsirkin" CC: qemu-devel@nongnu.org, Stefano Stabellini , Anthony Perard , Paul Durrant , Paolo Bonzini , Richard Henderson , Eduardo Habkost , Marcel Apfelbaum , xen-devel@lists.xenproject.org, =?ISO-8859-1?Q?Philippe_Mathieu-Daud=E9?= Subject: Re: [PATCH v8] xen/pt: reserve PCI slot 2 for Intel igd-passthru In-Reply-To: References: <20230110030331-mutt-send-email-mst@kernel.org> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Am 11=2E Januar 2023 15:40:24 UTC schrieb Chuck Zmudzinski : >On 1/10/23 3:16=E2=80=AFAM, Michael S=2E Tsirkin wrote: >> On Tue, Jan 10, 2023 at 02:08:34AM -0500, Chuck Zmudzinski wrote: >>> Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, >>> as noted in docs/igd-assign=2Etxt in the Qemu source code=2E >>>=20 >>> Currently, when the xl toolstack is used to configure a Xen HVM guest = with >>> Intel IGD passthrough to the guest with the Qemu upstream device model= , >>> a Qemu emulated PCI device will occupy slot 2 and the Intel IGD will o= ccupy >>> a different slot=2E This problem often prevents the guest from booting= =2E >>>=20 >>> The only available workaround is not good: Configure Xen HVM guests to= use >>> the old and no longer maintained Qemu traditional device model availab= le >>> from xenbits=2Exen=2Eorg which does reserve slot 2 for the Intel IGD= =2E >>>=20 >>> To implement this feature in the Qemu upstream device model for Xen HV= M >>> guests, introduce the following new functions, types, and macros: >>>=20 >>> * XEN_PT_DEVICE_CLASS declaration, based on the existing TYPE_XEN_PT_D= EVICE >>> * XEN_PT_DEVICE_GET_CLASS macro helper function for XEN_PT_DEVICE_CLAS= S >>> * typedef XenPTQdevRealize function pointer >>> * XEN_PCI_IGD_SLOT_MASK, the value of slot_reserved_mask to reserve sl= ot 2 >>> * xen_igd_reserve_slot and xen_igd_clear_slot functions >>>=20 >>> The new xen_igd_reserve_slot function uses the existing slot_reserved_= mask >>> member of PCIBus to reserve PCI slot 2 for Xen HVM guests configured u= sing >>> the xl toolstack with the gfx_passthru option enabled, which sets the >>> igd-passthru=3Don option to Qemu for the Xen HVM machine type=2E >>>=20 >>> The new xen_igd_reserve_slot function also needs to be implemented in >>> hw/xen/xen_pt_stub=2Ec to prevent FTBFS during the link stage for the = case >>> when Qemu is configured with --enable-xen and --disable-xen-pci-passth= rough, >>> in which case it does nothing=2E >>>=20 >>> The new xen_igd_clear_slot function overrides qdev->realize of the par= ent >>> PCI device class to enable the Intel IGD to occupy slot 2 on the PCI b= us >>> since slot 2 was reserved by xen_igd_reserve_slot when the PCI bus was >>> created in hw/i386/pc_piix=2Ec for the case when igd-passthru=3Don=2E >>>=20 >>> Move the call to xen_host_pci_device_get, and the associated error >>> handling, from xen_pt_realize to the new xen_igd_clear_slot function t= o >>> initialize the device class and vendor values which enables the checks= for >>> the Intel IGD to succeed=2E The verification that the host device is a= n >>> Intel IGD to be passed through is done by checking the domain, bus, sl= ot, >>> and function values as well as by checking that gfx_passthru is enable= d, >>> the device class is VGA, and the device vendor in Intel=2E >>>=20 >>> Signed-off-by: Chuck Zmudzinski >>> --- >>> Notes that might be helpful to reviewers of patched code in hw/xen: >>>=20 >>> The new functions and types are based on recommendations from Qemu doc= s: >>> https://qemu=2Ereadthedocs=2Eio/en/latest/devel/qom=2Ehtml >>>=20 >>> Notes that might be helpful to reviewers of patched code in hw/i386: >>>=20 >>> The small patch to hw/i386/pc_piix=2Ec is protected by CONFIG_XEN so i= t does >>> not affect builds that do not have CONFIG_XEN defined=2E >>>=20 >>> xen_igd_gfx_pt_enabled() in the patched hw/i386/pc_piix=2Ec file is an >>> existing function that is only true when Qemu is built with >>> xen-pci-passthrough enabled and the administrator has configured the X= en >>> HVM guest with Qemu's igd-passthru=3Don option=2E >>>=20 >>> v2: Remove From: tag at top of commit message >>>=20 >>> v3: Changed the test for the Intel IGD in xen_igd_clear_slot: >>>=20 >>> if (is_igd_vga_passthrough(&s->real_device) && >>> (s->real_device=2Evendor_id =3D=3D PCI_VENDOR_ID_INTEL)) { >>>=20 >>> is changed to >>>=20 >>> if (xen_igd_gfx_pt_enabled() && (s->hostaddr=2Eslot =3D=3D 2) >>> && (s->hostaddr=2Efunction =3D=3D 0)) { >>>=20 >>> I hoped that I could use the test in v2, since it matches the >>> other tests for the Intel IGD in Qemu and Xen, but those tests >>> do not work because the necessary data structures are not set with >>> their values yet=2E So instead use the test that the administrator >>> has enabled gfx_passthru and the device address on the host is >>> 02=2E0=2E This test does detect the Intel IGD correctly=2E >>>=20 >>> v4: Use brchuckz@aol=2Ecom instead of brchuckz@netscape=2Enet for the = author's >>> email address to match the address used by the same author in comm= its >>> be9c61da and c0e86b76 >>> =20 >>> Change variable for XEN_PT_DEVICE_CLASS: xptc changed to xpdc >>>=20 >>> v5: The patch of xen_pt=2Ec was re-worked to allow a more consistent t= est >>> for the Intel IGD that uses the same criteria as in other places= =2E >>> This involved moving the call to xen_host_pci_device_get from >>> xen_pt_realize to xen_igd_clear_slot and updating the checks for t= he >>> Intel IGD in xen_igd_clear_slot: >>> =20 >>> if (xen_igd_gfx_pt_enabled() && (s->hostaddr=2Eslot =3D=3D 2) >>> && (s->hostaddr=2Efunction =3D=3D 0)) { >>>=20 >>> is changed to >>>=20 >>> if (is_igd_vga_passthrough(&s->real_device) && >>> s->real_device=2Edomain =3D=3D 0 && s->real_device=2Ebus =3D= =3D 0 && >>> s->real_device=2Edev =3D=3D 2 && s->real_device=2Efunc =3D=3D = 0 && >>> s->real_device=2Evendor_id =3D=3D PCI_VENDOR_ID_INTEL) { >>>=20 >>> Added an explanation for the move of xen_host_pci_device_get from >>> xen_pt_realize to xen_igd_clear_slot to the commit message=2E >>>=20 >>> Rebase=2E >>>=20 >>> v6: Fix logging by removing these lines from the move from xen_pt_real= ize >>> to xen_igd_clear_slot that was done in v5: >>>=20 >>> XEN_PT_LOG(d, "Assigning real physical device %02x:%02x=2E%d" >>> " to devfn 0x%x\n", >>> s->hostaddr=2Ebus, s->hostaddr=2Eslot, s->hostaddr=2Efu= nction, >>> s->dev=2Edevfn); >>>=20 >>> This log needs to be in xen_pt_realize because s->dev=2Edevfn is n= ot >>> set yet in xen_igd_clear_slot=2E >>>=20 >>> v7: The v7 that was posted to the mailing list was incorrect=2E v8 is = what >>> v7 was intended to be=2E >>>=20 >>> v8: Inhibit out of context log message and needless processing by >>> adding 2 lines at the top of the new xen_igd_clear_slot function: >>>=20 >>> if (!(pci_bus->slot_reserved_mask & XEN_PCI_IGD_SLOT_MASK)) >>> return; >>>=20 >>> Rebase=2E This removed an unnecessary header file from xen_pt=2Eh= =20 >>>=20 >>> hw/i386/pc_piix=2Ec | 3 +++ >>> hw/xen/xen_pt=2Ec | 49 ++++++++++++++++++++++++++++++++++++-----= --- >>> hw/xen/xen_pt=2Eh | 16 +++++++++++++++ >>> hw/xen/xen_pt_stub=2Ec | 4 ++++ >>> 4 files changed, 63 insertions(+), 9 deletions(-) >>>=20 >>> diff --git a/hw/i386/pc_piix=2Ec b/hw/i386/pc_piix=2Ec >>> index b48047f50c=2E=2Ebc5efa4f59 100644 >>> --- a/hw/i386/pc_piix=2Ec >>> +++ b/hw/i386/pc_piix=2Ec >>> @@ -405,6 +405,9 @@ static void pc_xen_hvm_init(MachineState *machine) >>> } >>> =20 >>> pc_xen_hvm_init_pci(machine); >>> + if (xen_igd_gfx_pt_enabled()) { >>> + xen_igd_reserve_slot(pcms->bus); >>> + } >>> pci_create_simple(pcms->bus, -1, "xen-platform"); >>> } >>> #endif >>=20 >> I would even maybe go further and move the whole logic into >> xen_igd_reserve_slot=2E And I would even just name it >> xen_hvm_init_reserved_slots without worrying about the what >> or why at the pc level=2E At this point it will be up to Xen maintaine= rs=2E > >I see to do that would be to resolve the two pc_xen_hvm* >functions in pc_piix=2Ec that are guarded by CONFIG_XEN and >move them to an appropriate place such as xen-hvm=2Ec=2E > >That is along the lines of the work that Bernhard and Philippe >are doing, so I am Cc'ing them=2E My first inclination is just >to defer to them: I think eventually the little patch I propose >here to pc_piix=2Ec is eventually going to be moved out of pc_piix=2Ec >by Bernhard in a future patch=2E > >What they have been doing is very conservative, and I expect >if and when Bernhard gets here to resolve those functions, they >will do it in a way that keeps the dependency of the xenfv machine >type on the pc machine type and the pc_init1 function=2E > >What I would propose would be to break the dependency of xenfv >on the pc_init1 function=2E That is, I would propose having a >xenfv_init function in xen-hvm=2Ec, and the first version would >be the current version of pc_init1, so xenfv would still depend >on many i440fx type things, but with the change xen developers >would be free to tweak xenfv_init without affecting the users >of the pc machine type=2E > >Would that be a good idea? If I get posiive feedback for this >idea, I will put it on the table, probably initially as an RFC >patch=2E In various patches I've been decoupling 1/ PIIX3 from Xen and 2/ QEMU's Xe= n integration code from the PC machine=2E My idea is to confine all wiring = for a PIIX based PC machine using Xen in pc_piix=2Ec=2E The pc_xen_hvm* fun= ctions seem to do exactly that, so I'd leave them there, at least for now= =2E What I would like to avoid is for the Xen integration code to make assumpt= ions that an x86 or PC machine is always based on i440fx or PIIX3=2E I like Michael's idea of going one step further, both in terms of the appr= oach and the reasoning=2E Best regards, Bernhard >Also, thanks, Michael, for your other suggestions for this patch >about using macros for the devfn constants=2E > >Chuck > >>=20 >>> diff --git a/hw/xen/xen_pt=2Ec b/hw/xen/xen_pt=2Ec >>> index 0ec7e52183=2E=2Eeff38155ef 100644 >>> --- a/hw/xen/xen_pt=2Ec >>> +++ b/hw/xen/xen_pt=2Ec >>> @@ -780,15 +780,6 @@ static void xen_pt_realize(PCIDevice *d, Error **= errp) >>> s->hostaddr=2Ebus, s->hostaddr=2Eslot, s->hostaddr=2Ef= unction, >>> s->dev=2Edevfn); >>> =20 >>> - xen_host_pci_device_get(&s->real_device, >>> - s->hostaddr=2Edomain, s->hostaddr=2Ebus, >>> - s->hostaddr=2Eslot, s->hostaddr=2Efunctio= n, >>> - errp); >>> - if (*errp) { >>> - error_append_hint(errp, "Failed to \"open\" the real pci devi= ce"); >>> - return; >>> - } >>> - >>> s->is_virtfn =3D s->real_device=2Eis_virtfn; >>> if (s->is_virtfn) { >>> XEN_PT_LOG(d, "%04x:%02x:%02x=2E%d is a SR-IOV Virtual Functi= on\n", >>> @@ -950,11 +941,50 @@ static void xen_pci_passthrough_instance_init(Ob= ject *obj) >>> PCI_DEVICE(obj)->cap_present |=3D QEMU_PCI_CAP_EXPRESS; >>> } >>> =20 >>> +void xen_igd_reserve_slot(PCIBus *pci_bus) >>> +{ >>> + XEN_PT_LOG(0, "Reserving PCI slot 2 for IGD\n"); >>> + pci_bus->slot_reserved_mask |=3D XEN_PCI_IGD_SLOT_MASK; >>> +} >>> + >>> +static void xen_igd_clear_slot(DeviceState *qdev, Error **errp) >>> +{ >>> + ERRP_GUARD(); >>> + PCIDevice *pci_dev =3D (PCIDevice *)qdev; >>> + XenPCIPassthroughState *s =3D XEN_PT_DEVICE(pci_dev); >>> + XenPTDeviceClass *xpdc =3D XEN_PT_DEVICE_GET_CLASS(s); >>> + PCIBus *pci_bus =3D pci_get_bus(pci_dev); >>> + >>> + if (!(pci_bus->slot_reserved_mask & XEN_PCI_IGD_SLOT_MASK)) >>> + return; >>> + >>> + xen_host_pci_device_get(&s->real_device, >>> + s->hostaddr=2Edomain, s->hostaddr=2Ebus, >>> + s->hostaddr=2Eslot, s->hostaddr=2Efunctio= n, >>> + errp); >>> + if (*errp) { >>> + error_append_hint(errp, "Failed to \"open\" the real pci devi= ce"); >>> + return; >>> + } >>> + >>> + if (is_igd_vga_passthrough(&s->real_device) && >>> + s->real_device=2Edomain =3D=3D 0 && s->real_device=2Ebus =3D= =3D 0 && >>> + s->real_device=2Edev =3D=3D 2 && s->real_device=2Efunc =3D=3D= 0 && >>> + s->real_device=2Evendor_id =3D=3D PCI_VENDOR_ID_INTEL) { >>=20 >> how about macros for these? >>=20 >> #define XEN_PCI_IGD_DOMAIN 0 >> #define XEN_PCI_IGD_BUS 0 >> #define XEN_PCI_IGD_DEV 2 >> #define XEN_PCI_IGD_FN 0 >>=20 >>> + pci_bus->slot_reserved_mask &=3D ~XEN_PCI_IGD_SLOT_MASK; >>=20 >> If you are going to do this, you should set it back >> either after pci_qdev_realize or in unrealize, >> for symmetry=2E >>=20 >>> + XEN_PT_LOG(pci_dev, "Intel IGD found, using slot 2\n"); >>> + } >>=20 >>=20 >>> + xpdc->pci_qdev_realize(qdev, errp); >>> +} >>> + >>=20 >>=20 >>=20 >>> static void xen_pci_passthrough_class_init(ObjectClass *klass, void *= data) >>> { >>> DeviceClass *dc =3D DEVICE_CLASS(klass); >>> PCIDeviceClass *k =3D PCI_DEVICE_CLASS(klass); >>> =20 >>> + XenPTDeviceClass *xpdc =3D XEN_PT_DEVICE_CLASS(klass); >>> + xpdc->pci_qdev_realize =3D dc->realize; >>> + dc->realize =3D xen_igd_clear_slot; >>> k->realize =3D xen_pt_realize; >>> k->exit =3D xen_pt_unregister_device; >>> k->config_read =3D xen_pt_pci_read_config; >>> @@ -977,6 +1007,7 @@ static const TypeInfo xen_pci_passthrough_info = =3D { >>> =2Einstance_size =3D sizeof(XenPCIPassthroughState), >>> =2Einstance_finalize =3D xen_pci_passthrough_finalize, >>> =2Eclass_init =3D xen_pci_passthrough_class_init, >>> + =2Eclass_size =3D sizeof(XenPTDeviceClass), >>> =2Einstance_init =3D xen_pci_passthrough_instance_init, >>> =2Einterfaces =3D (InterfaceInfo[]) { >>> { INTERFACE_CONVENTIONAL_PCI_DEVICE }, >>> diff --git a/hw/xen/xen_pt=2Eh b/hw/xen/xen_pt=2Eh >>> index cf10fc7bbf=2E=2E8c25932b4b 100644 >>> --- a/hw/xen/xen_pt=2Eh >>> +++ b/hw/xen/xen_pt=2Eh >>> @@ -2,6 +2,7 @@ >>> #define XEN_PT_H >>> =20 >>> #include "hw/xen/xen_common=2Eh" >>> +#include "hw/pci/pci_bus=2Eh" >>> #include "xen-host-pci-device=2Eh" >>> #include "qom/object=2Eh" >>> =20 >>> @@ -40,7 +41,20 @@ typedef struct XenPTReg XenPTReg; >>> #define TYPE_XEN_PT_DEVICE "xen-pci-passthrough" >>> OBJECT_DECLARE_SIMPLE_TYPE(XenPCIPassthroughState, XEN_PT_DEVICE) >>> =20 >>> +#define XEN_PT_DEVICE_CLASS(klass) \ >>> + OBJECT_CLASS_CHECK(XenPTDeviceClass, klass, TYPE_XEN_PT_DEVICE) >>> +#define XEN_PT_DEVICE_GET_CLASS(obj) \ >>> + OBJECT_GET_CLASS(XenPTDeviceClass, obj, TYPE_XEN_PT_DEVICE) >>> + >>> +typedef void (*XenPTQdevRealize)(DeviceState *qdev, Error **errp); >>> + >>> +typedef struct XenPTDeviceClass { >>> + PCIDeviceClass parent_class; >>> + XenPTQdevRealize pci_qdev_realize; >>> +} XenPTDeviceClass; >>> + >>> uint32_t igd_read_opregion(XenPCIPassthroughState *s); >>> +void xen_igd_reserve_slot(PCIBus *pci_bus); >>> void igd_write_opregion(XenPCIPassthroughState *s, uint32_t val); >>> void xen_igd_passthrough_isa_bridge_create(XenPCIPassthroughState *s, >>> XenHostPCIDevice *dev); >>> @@ -75,6 +89,8 @@ typedef int (*xen_pt_conf_byte_read) >>> =20 >>> #define XEN_PCI_INTEL_OPREGION 0xfc >>> =20 >>> +#define XEN_PCI_IGD_SLOT_MASK 0x4UL /* Intel IGD slot_reserved_mask *= / >>> + >>=20 >> I think you want to calculate this based on dev fn: >>=20 >> #define XEN_PCI_IGD_SLOT_MASK \ >> (0x1 << PCI_SLOT(PCI_DEVFN(XEN_PCI_IGD_DEV, XEN_PCI_IGD_FN))) >>=20 >>=20 >>> typedef enum { >>> XEN_PT_GRP_TYPE_HARDWIRED =3D 0, /* 0 Hardwired reg group */ >>> XEN_PT_GRP_TYPE_EMU, /* emul reg group */ >>> diff --git a/hw/xen/xen_pt_stub=2Ec b/hw/xen/xen_pt_stub=2Ec >>> index 2d8cac8d54=2E=2E5c108446a8 100644 >>> --- a/hw/xen/xen_pt_stub=2Ec >>> +++ b/hw/xen/xen_pt_stub=2Ec >>> @@ -20,3 +20,7 @@ void xen_igd_gfx_pt_set(bool value, Error **errp) >>> error_setg(errp, "Xen PCI passthrough support not built in"); >>> } >>> } >>> + >>> +void xen_igd_reserve_slot(PCIBus *pci_bus) >>> +{ >>> +} >>> --=20 >>> 2=2E39=2E0 >>=20 > From xen-devel-bounces@lists.xenproject.org Thu Jan 12 19:34:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 19:34:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476375.738506 (Exim 4.92) (envelope-from ) id 1pG3Lb-0004C3-8m; Thu, 12 Jan 2023 19:34:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476375.738506; Thu, 12 Jan 2023 19:34:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG3Lb-0004Bw-6K; Thu, 12 Jan 2023 19:34:47 +0000 Received: by outflank-mailman (input) for mailman id 476375; Thu, 12 Jan 2023 19:34:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG3LZ-0004Bk-9q; Thu, 12 Jan 2023 19:34:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG3LZ-0001SG-8A; Thu, 12 Jan 2023 19:34:45 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG3LY-0002jp-P6; Thu, 12 Jan 2023 19:34:44 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pG3LY-0003w8-Od; Thu, 12 Jan 2023 19:34:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=mV6sAw3XdWSY1/DAS+mLgro4nYv7WoCXYYDUI8+7M2g=; b=wk09nOG9YRrAEUtICOJA7Xq3Dv Z4mjPQTG/UynZXBS+eHtrAzWGBlLD0Vs0ctAB8oPYvbLJ+1hD9c197SPe9M30LkmLt6KNVF2okHTJ /v07R6Vdn7eW+LEfmIeb64+SLxQsOntkpr39IbErZLnJBvGafWPY+DHvG70YTiUjApd4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 175746: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=6bec713f871f21c6254a5783c1e39867ea828256 X-Osstest-Versions-That: xen=661489874e87c0f6e21ac298b039aab9379f6ee0 From: osstest service owner Date: Thu, 12 Jan 2023 19:34:44 +0000 flight 175746 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/175746/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 6bec713f871f21c6254a5783c1e39867ea828256 baseline version: xen 661489874e87c0f6e21ac298b039aab9379f6ee0 Last test of basis 175741 2023-01-12 11:01:58 Z 0 days Testing same since 175746 2023-01-12 16:03:41 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 661489874e..6bec713f87 6bec713f871f21c6254a5783c1e39867ea828256 -> smoke From xen-devel-bounces@lists.xenproject.org Thu Jan 12 19:38:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 19:38:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476383.738517 (Exim 4.92) (envelope-from ) id 1pG3Os-0004t7-NQ; Thu, 12 Jan 2023 19:38:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476383.738517; Thu, 12 Jan 2023 19:38:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG3Os-0004t0-Kt; Thu, 12 Jan 2023 19:38:10 +0000 Received: by outflank-mailman (input) for mailman id 476383; Thu, 12 Jan 2023 19:38:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG3Or-0004su-7H for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 19:38:09 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG3Oq-0001WR-Oo; Thu, 12 Jan 2023 19:38:08 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.11.96]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pG3Oq-0004nL-G9; Thu, 12 Jan 2023 19:38:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=KUTTMef6bEj0+C46UuMyREIKXuTlXvdMNg+BvFhrPCU=; b=bjJay9eDf4n/vXfnbYXMWWgR12 GDcx5CWO2UwMagh1I15GwrvNPtEBcVgNUC68moDx9zjhRlS5JXAYjQ/lxqVchgDSeNm5Ql2FUCkdc zGb1HDiyFcW3Qge8zHnPtRBLQUw8Qhk10MmxkDXPTv5Dt5ZOjJVQ52ya7jJUb9IA0Ec4=; Message-ID: Date: Thu, 12 Jan 2023 19:38:06 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v3 08/18] xen/arm32: head: Introduce an helper to flush the TLBs Content-Language: en-US To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Luca.Fancellu@arm.com, Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20221212095523.52683-1-julien@xen.org> <20221212095523.52683-9-julien@xen.org> <95e9eff5-038d-923f-1afe-4f2d72bde5b3@amd.com> From: Julien Grall In-Reply-To: <95e9eff5-038d-923f-1afe-4f2d72bde5b3@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 14/12/2022 14:24, Michal Orzel wrote: > Hi Julien, Hi Michal, > On 12/12/2022 10:55, Julien Grall wrote: >> >> >> From: Julien Grall >> >> The sequence for flushing the TLBs is 4 instruction long and often >> requires an explanation how it works. >> >> So create an helper and use it in the boot code (switch_ttbr() is left > Here and in title: s/an helper/a helper/ Done. >> alone for now). > Could you explain why? So we need to decide how we expect switch_ttbr(). E.g. if Xen is relocated at a different, should the caller take care of the instruction/branch predictor flush? I have expanded to "switch_ttbr() is left alone until we decided the semantic of the call". >> >> Note that in secondary_switched, we were also flushing the instruction >> cache and branch predictor. Neither of them was necessary because: >> * We are only supporting IVIPT cache on arm32, so the instruction >> cache flush is only necessary when executable code is modified. >> None of the boot code is doing that. >> * The instruction cache is not invalidated and misprediction is not >> a problem at boot. >> >> Signed-off-by: Julien Grall > > Apart from that, the patch is good, so: > Reviewed-by: Michal Orzel Thanks! > >> >> --- >> Changes in v3: >> * Fix typo >> * Update the documentation >> * Rename the argument from tmp1 to tmp >> --- >> xen/arch/arm/arm32/head.S | 30 +++++++++++++++++------------- >> 1 file changed, 17 insertions(+), 13 deletions(-) >> >> diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S >> index 40c1d7502007..315abbbaebec 100644 >> --- a/xen/arch/arm/arm32/head.S >> +++ b/xen/arch/arm/arm32/head.S >> @@ -66,6 +66,20 @@ >> add \rb, \rb, r10 >> .endm >> >> +/* >> + * Flush local TLBs >> + * >> + * @tmp: Scratch register > As you are respinning a series anyway, could you add just one space after @tmp:? Ok. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Jan 12 19:45:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 19:45:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476389.738529 (Exim 4.92) (envelope-from ) id 1pG3VQ-0006La-Dx; Thu, 12 Jan 2023 19:44:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476389.738529; Thu, 12 Jan 2023 19:44:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG3VQ-0006LT-AO; Thu, 12 Jan 2023 19:44:56 +0000 Received: by outflank-mailman (input) for mailman id 476389; Thu, 12 Jan 2023 19:44:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG3VO-0006LL-R4 for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 19:44:55 +0000 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9446869d-92b1-11ed-b8d0-410ff93cb8f0; Thu, 12 Jan 2023 20:44:52 +0100 (CET) Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30CJfwql014771; Thu, 12 Jan 2023 19:44:15 GMT Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3n28ja9vst-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 12 Jan 2023 19:44:14 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 30CIeEQr016065; Thu, 12 Jan 2023 19:44:14 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2170.outbound.protection.outlook.com [104.47.59.170]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3n1k4r7q3f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 12 Jan 2023 19:44:14 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) by CY5PR10MB6237.namprd10.prod.outlook.com (2603:10b6:930:43::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.11; Thu, 12 Jan 2023 19:44:11 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::909f:fa34:2dac:11c5]) by BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::909f:fa34:2dac:11c5%7]) with mapi id 15.20.6002.013; Thu, 12 Jan 2023 19:44:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9446869d-92b1-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : to : cc : references : from : subject : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=xGKYOzY1zjzSPR3GmLBSaXMk6Gd0r79ktWHnTEP4/mk=; b=XzVjoQYCIalikTDTOI48gCcF2p0C+Wkg6Qst30TIS33pejKjk18qbEcQ6ixYjupOAbMP rgLz5mDNUoE6ZGqWTalfTFWmsGl/yVE39TgCwPWswORoMcMp+mxLoKrfSP0waMJnZVzV V5mw1KAXcL6vVJ7ERbwe/qqJV/WzzgORisBvxGXWNFje5YF2C+ClVJMCQqddwtW+li/1 QDyXkbZr0EYXVvfehGJSD0RIYtdKh7rxFUSAa7h1cWS/pQFaS3Y9+zReAyuufDRzEE9b 5JBuGzYeORvWD5MDGw23YUE4vHLz1fX7y6tVr79J4Kp2CLfdtT28mMprssqGVZu+yd4m rw== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M1NDhP4bXDhKGhul48hkMFLbeggOmEffBQvr1DV/0OxLcoeD8Je2Cg8C7ELiz9nJUtP1aBzZ1ER2mA7kuPvV2B+0xuTfNiVcnuaRZNcwJXHTFymbGrhCncZ1PHjnL0UfYqa+XWzdQfvmFcgqcPYWTPy4ChLtp52UmEifugn0C9gPibqPJlK2Wxn2tWXhYxn5mzgPMLcLoyu0ageX7y6bTmNb/fizSYw/ZTYOvv1SftoFVdF3gmy/lk2igW86GHvsN06xFiBMSFJoQYJ9BP6ssrjRQUMvwYrCR0/dQVV6OKGLr+V3ukDWYBN7DNnWowxCruXjq+goZK6Qv7xuZmzWmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xGKYOzY1zjzSPR3GmLBSaXMk6Gd0r79ktWHnTEP4/mk=; b=bWbCv8pYJRvbIGe7qqs3Slyl/hM8fq3Px18jtgNa/HktgEuctQOSeeN7Lp3pHUyObH32pbxyWGCb+y3UHyUvT7gD0FgvsFbZ+x5Oxi54/oXXp4hC71OkPlMG1QeFEuq91aQ0B/3dhr7FBxvDuRmbxTp/GqSHX71xXgWln2wYCuk/FwZI1RD76jIf3ON3wOkO0MrG51tJ6zTuPlfgxJDi8ucx6Lue7SZBDIGaYzm+eThQxhXGBXvkb4bmiCKAPDaTIlggxLZJccAW/DUW0PSwH+qaeXRi+7jHgaFP6PC7AIwdrSvybPfLxjlxhRXkeKwKkgucu4X2mmsPa31Ce+NUSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xGKYOzY1zjzSPR3GmLBSaXMk6Gd0r79ktWHnTEP4/mk=; b=UFaCyhemjL+SKJOPI6vQTgW1jPRbPQrT8JhaEXcFNW1YnO3P86jOw8F13icswJIm+C25qIEfoJGUBf3gOagD1esqX8cFCURMiNXtfU1Gg4259w9lemL0dHrJ9JJRoIVD6401Wjjo9zGfV8aGZWoCpKvGEfikyeNBHi/1rH8uV+Q= Message-ID: <12462e10-ae39-b198-b159-9c621eb5119d@oracle.com> Date: Thu, 12 Jan 2023 14:44:07 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Content-Language: en-US To: Juergen Gross , linux-kernel@vger.kernel.org, x86@kernel.org, virtualization@lists.linux-foundation.org Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , "Srivatsa S. Bhat (VMware)" , Alexey Makhalov , VMware PV-Drivers Reviewers , xen-devel@lists.xenproject.org References: <20230112152132.4399-1-jgross@suse.com> From: Boris Ostrovsky Subject: Re: [PATCH] x86/paravirt: merge activate_mm and dup_mmap callbacks In-Reply-To: <20230112152132.4399-1-jgross@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DM6PR12CA0020.namprd12.prod.outlook.com (2603:10b6:5:1c0::33) To BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BLAPR10MB5009:EE_|CY5PR10MB6237:EE_ X-MS-Office365-Filtering-Correlation-Id: 186789fb-8462-4973-fb0c-08daf4d560d3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wdM5lWrnOzt4XMfOjxg8+A9a8qBy4jWrSUpbLPpPFJQnFfYs0sBgAN5m8aq6B1pQpEEj8SQVQ6+eWpyVY310h0YKSI91MWQQFWlVQ6kHyMADiPU+kr2+ekZMkIzcESCdEiG7L7JU6HnkLNXCycsJbrPaXGi7OmCKBPAVZEDUDSOxM1tWnrkhcc6qs6Vb65RiNGR0hffl0neCmMbqWRjhRBQHY0wP3kDax6OQ21dkNot63yV4hhkiqmb/9VswGT1Sj1YquPrmEBvEGJS5x9X/Pk+J+C1bocxCcFhoLHayCT8TtTlx/69m/McFV/N0dju2tv80boc3Ruphw8Qb1Hj3nxXLjZnjFM1vl35cTVBtYEaqBZxSsgekOBwk6fCJn1i+zcMBaO1ZZqDLfvau/u3GiuqNovfhup9QSjLgbaxJlWdRd5JnKC1Nf+uINDOZNGi8BN4knrTR4COBWRLXLADr8WB1Y9HW27cqmTHL/zeSFUyqsCVM4qqgqrGvTG+7dvm3g/BizsOxvjt8iZxZiZRKcGxXPKtJSBDEUIjNo5bA0/JXYGuwtMZQMm26bsOB/UhCeyU6FUZSayi9zu4wOz25xFMrtoelBg++GW+Q/9qGl2c/kfeLZjbZzWnab3c4HIGnmN2pfXYGgYQia/hGMAber8DFFSrnOFjZfCMd+uvcb0isA3IVTgH0EmiZOrdTlVDPC2YrJUvSp1AceZIsXamyBpyMfT5SiuMN/+NPz9lbeec= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(376002)(396003)(136003)(346002)(39860400002)(451199015)(86362001)(36756003)(31686004)(83380400001)(4326008)(7416002)(66946007)(66476007)(66556008)(8936002)(8676002)(44832011)(5660300002)(4744005)(31696002)(38100700002)(2906002)(478600001)(6486002)(316002)(54906003)(6506007)(41300700001)(26005)(2616005)(53546011)(6512007)(186003)(6666004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Vm9FbTFnS1psU2R4YlVpbjlYektrOGRxT3VoeGdpSGl4bWlHanNmcmxpOUR3?= =?utf-8?B?Uk16ZUhJZlVaaENkRmtNayt2cFdZQUxyZS9CMnJkc2tGOUlQczdjZ3Q1UlJ4?= =?utf-8?B?OFhad1Y3WHFDN2J1bjY3SWlnMHBIM1hTTksvREJtcDJGOU5EeC9zejNWZ243?= =?utf-8?B?emxyODdNMjdyWVB6eWFUeTM5MjJzZjNrRFYzVDAwbVhHMzZjcVJPZkNPREg3?= =?utf-8?B?ekw1QWVwZk5EeitWS1FuWng2VUNTNnNUNnNvZlJUSGRpWDlqNWlFWjArbm9M?= =?utf-8?B?ZmcxbUVTaVNBTWtackJmcEdUdXZ3aW4rblg2ZmVjQ0x3cStsTkd1V09BVGNi?= =?utf-8?B?ZWNwREYvMVlEd1JGNkpFV3N3Rm4yV1V4YVFCb1l3VTNTTWx6eGRFMzAyUytB?= =?utf-8?B?UWVzZVh5ODdld2pHTXRLNTlYd0cxQ3JQSENjZHAxUFlqZ09iRGJCb0hKZ2VO?= =?utf-8?B?cVZBNzZHUnpBK21VRUpHVVZoV1FQNjNBb0N5dnRUblZpT2wrVWtqWFoxZk0w?= =?utf-8?B?QmdMT3hPQit5OFNwbFk3S1FDYlpyaTFIejEvUHR2SU12dlFybzdUOVZCRkYx?= =?utf-8?B?VDhTcEdISkFMWkF1Q2d1cnV4QVM4R3VISHlOYjJXcFZCSDJVaEpzbUU0Smxm?= =?utf-8?B?Vkppa0ZPZENuZncwcVp4NWo2Y094ZTZuTVhiSHhOV0NqQjBBVTF5RUpvTzRw?= =?utf-8?B?QTdkYlpPTE5UcmYyUGI1SXFEOURxaFVzRGJnbFJ2SWFiT0VGeFYyTTh5STVG?= =?utf-8?B?cVU5Tm5MT1p2TndBdEJCaWp6YnprZUJUdGx4WWJUcHdncDNtU09NY0RvREFm?= =?utf-8?B?RXVkeDBiQllIMmNTNlgvUDVZR1BHTlQzeHpzTFZHbmExK1VmdzBzWjczTXlp?= =?utf-8?B?TERvSFhXL1F6cXJBZmZTYzVxaXRxVk1TU2xaOHZxRGRqZkVTUVcyaUp5ejJT?= =?utf-8?B?emNJLzZwdzZsMEY5S2FpYVl6ZnI0VXluanJMZWVhNUFtMTlvcW1pdU1SVlJn?= =?utf-8?B?UXR4T0tmckMyNXdtQkZ2T0lYZ1VoSjNHME5wRllFU2F6N0lJZVIzcDBxSDls?= =?utf-8?B?WFRtYXNCejN2UkM0MWh2Tk9UbUcxUTkzUW1abWJvRE80V3paajBwdEdUUGoz?= =?utf-8?B?VHVuakx4Y2p2T0RENXh4N0pSMGZjNnNrWWM0NkhaMUVITXgrQXpSKzRYQUpO?= =?utf-8?B?TVZZMVVOSnJyZUtKWVdHNklXZTRKdDdPOWpNN3pJeWRJY0Jka3M2Y1daV1Ry?= =?utf-8?B?UDVyN2RPS1JWaFZ1Yi9XSlE5a01mUTlRNkpuU3k1VjFLKzNKZllTU3ZhTU8w?= =?utf-8?B?d2Y2MUN4ZWtQUElrMjdIanZUNE1BQWJGem9XVE0wb2IwV0sySkVtZ3U4Q2I4?= =?utf-8?B?S3dTMjVacnhvZnJRUER4VGN3UG1yQmdMQWllSG5VbDA2SGl4UFlsaEZGMi9T?= =?utf-8?B?V3JsOGRZa2VpOEk4QkVMRk9FREdEZzZQbzA5aTlWc2lmdzZ6M2plclNEUnE2?= =?utf-8?B?YkR6SkpPU3VHTUVqbllUd1JDWlVHS2hhSlpyQ1UxTWMrdW1VekQ0SFZvZmZz?= =?utf-8?B?R01UWlhETXFwNkhxd3pZNHBvOEtmTXA1Y3BZVGFOYUM2Y0NmQ0JCQ1ZnbHVW?= =?utf-8?B?NFRzbXVPQmZKZ1lFNDVEdU1pdDJnTVlVN0JEUEVFcm92RmtFODg1bEp3UGVU?= =?utf-8?B?bjVaYURJZGRSZHpyOWd6UkJpTU1jcEdqRExyRjk5OGFBTkppaUVaL1djYVZp?= =?utf-8?B?V1ZsME1GdlZkWis2eGh2a2grZ2JiZnhJWmN1bzcxZnB3Q0hNTW90aC9ReXBt?= =?utf-8?B?Y2NkRURtbXVGeTQ2WE54ZTkrdnJST3dRTHcrWktnZnBzaXYySHNKeFlzbFRh?= =?utf-8?B?MWwwUS9wZTdEMzF1TVB6dlZ3a1BVVDNEM1hId1dqckQxSVI2eDVjd2NmSytB?= =?utf-8?B?UkhWUzFWU1JybVRKMDBrK0orU3VyQTl0ZS9mcmk5a0dkTHZqRkNTMnh5SkJy?= =?utf-8?B?ZFNKNWEvTlpldTk1bXZPdVptaHpXM28rUVMzbUQwbjdGNWV5a3M2dmNueFhY?= =?utf-8?B?VktNSEdTZEZDck9iRVNTSVozWkFHbVp1TWdLQXNabEgyOWVkUklUQWpGaGJk?= =?utf-8?B?MEw1VzM1SDlaQWJGQUprcVhrZ1J1WEJmUWV3RXRmcXo0aUdjbE1qbWhuL1Jh?= =?utf-8?B?M2c9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?MW5mRExLaXZkUWJ4NjZaQ3BQTmk1RDZJMGhpN2hTM24wam5KcStZeXlIV1Qv?= =?utf-8?B?ZGY1cjlXL05UMlkzWGV6ejV3QW5ncUt5RmFTcGtVSndvU3UxQ0RKVkxObGhB?= =?utf-8?B?QWpPU2drdXk4T1ZmanhIdjhFSlRpdFRLNXk0NHJwSGJCbmV4aTltbTl0Z1JU?= =?utf-8?B?Qjk2VmhKbW51TDZtVzhZV2ovdDE4dThVVEdjWHJpaDdwUTlraXEydnJhWi9I?= =?utf-8?B?TVMvaUcveVNGbWE1NWdHZjJpcjVvbStOWUNlc29RaDgvZmE2aUQrdDZhWitn?= =?utf-8?B?enNjSXJUdVNvdG9FbkRLUndRc2lHejFDZXRveVZqMlAyQWdvQWlmcm1DV0xn?= =?utf-8?B?YU9iS0R6WitPYlhsajF6ZVNPWEt2ZThEblJaTzNVYXEzTTlySUZmNTlCeFlp?= =?utf-8?B?ZXozZlM4dWN0S2hTNXBOSFZPZkhZYUR2d3MxSHF4YzlaR3lDNVhyZTY0REh4?= =?utf-8?B?UDdLRURzWEhkb1VXMGJiMWlJNDNrZ0dLcDlWcjVXd1JuKy9JQUY3MEx2RTNX?= =?utf-8?B?NDg4SUVza3J4NVJqTjJSTkFvR3JSQjZsb3NVRkJRdTZlU2xXTUFnMHlQTi9K?= =?utf-8?B?b1lBSUxac0dwZ2NIYUxkNGg4TlNKVU4yMWRNYWIreVB6Q0VRYUdEUGJMd3Ji?= =?utf-8?B?b0phU1BULzNhYWRrRzZ5T2g2T1FpczdlUDJsOEEvTnBuRGxRU0tDeUpDVkxK?= =?utf-8?B?b1JHRHVxVHBoTi94Zit5U3dtbnBTeTlWbncrSXdLUjA2S0cyelJrNU1OUG1i?= =?utf-8?B?NHd6WU8yVVpud1JEQ2RWOWprdUFhVEk4ZSt3cjBHWk10WGNkaFgyNUVaLzVU?= =?utf-8?B?L2VFcGh0NlhPN0dRYUdud0FuaFNBKzhMclcxSjR1UDVmY3hzamh3VlI5TElM?= =?utf-8?B?c3MwT0t0VWd3QjZJbmNzNGdub09aamg2SVFiZGFHM1VhV3ljdnpvVjBwNzlS?= =?utf-8?B?SndkRndablZTR2JsRWdKUno0NHpSZ0hTN0c3S2d5YkIzTXljeUtHWHpFOGUr?= =?utf-8?B?VE9ZZjhETjhoZEVRdVk5RU1ZYWhzR1FFN2FNNTU0QVg0TmwzbGIzTjdaM0RX?= =?utf-8?B?MytXSnBrb1p3cVJ3ZFJ0STdkcXNYdmNzZmR0Umwxc1g0dW1rdzJMMy94Lzc5?= =?utf-8?B?a3A2NjJBSWN3dXlIVUZQQnNtYkI1aHNFck4xc2ppQkkyUC91RjJHR29hVFEw?= =?utf-8?B?MWJ5M2NXT09kUHB6dTFIUEp5d1VlMTBISE5nNFNvK3lPcU9GalBVczVxbndo?= =?utf-8?B?M1llTE52NmVRajN1REtaeDBaaEs3R3pPTnZ6ODlxVkIxajZ5Um5BUkJMVVVX?= =?utf-8?B?V1dPam1LaThJNTV0N2JaNEdiRzhHK2dMaHNVZDFYLzZoOGozSmc4K0lyL3Rw?= =?utf-8?B?OVJFMGNSbEdNU1hVQVhQdHBINVpLbTVyZjFIdGxOcUs4VkYrWFdSdnk2YTdz?= =?utf-8?B?ZmxJUUNScWZJclZJR2VpTTJKeVMybGRaMVZHS3dNdVU1TC9UbTJyVVg2MGZT?= =?utf-8?B?ckR1S1ZOb3lmZlpaRFpLd3dENlZkMGxOU2gxUTlmTFFkazhGcG4wQ25Ld3NM?= =?utf-8?Q?IXomv0c3CZbZ/pJHNOEIPrJtI=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 186789fb-8462-4973-fb0c-08daf4d560d3 X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 19:44:11.7156 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: D7u3H/736JcLjowuGrsXn1pd1Y+0fTfXZJlH7d7kRdDjgbNTLPdnxl8xrV5bF0KTT92bKAl2nQ5VEOT6LeyTR0AXrKD8jYSOE4OU4DK2AWs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR10MB6237 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2023-01-12_12,2023-01-12_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 adultscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 phishscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301120141 X-Proofpoint-ORIG-GUID: VD9Nbg3F-a_L5jYivbIFN7Xhc7-rzmbt X-Proofpoint-GUID: VD9Nbg3F-a_L5jYivbIFN7Xhc7-rzmbt On 1/12/23 10:21 AM, Juergen Gross wrote: > The two paravirt callbacks .mmu.activate_mm and .mmu.dup_mmap are > sharing the same implementations in all cases: for Xen PV guests they > are pinning the PGD of the new mm_struct, and for all other cases > they are a NOP. > > So merge them to a common callback .mmu.enter_mmap (in contrast to the > corresponding already existing .mmu.exit_mmap). > > As the first parameter of the old callbacks isn't used, drop it from > the replacement one. > > Signed-off-by: Juergen Gross Reviewed-by: Boris Ostrovsky From xen-devel-bounces@lists.xenproject.org Thu Jan 12 20:12:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 20:12:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476395.738540 (Exim 4.92) (envelope-from ) id 1pG3vi-0001ar-Hg; Thu, 12 Jan 2023 20:12:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476395.738540; Thu, 12 Jan 2023 20:12:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG3vi-0001ak-EQ; Thu, 12 Jan 2023 20:12:06 +0000 Received: by outflank-mailman (input) for mailman id 476395; Thu, 12 Jan 2023 20:12:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG3vh-0001ad-By for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 20:12:05 +0000 Received: from sonic304-25.consmr.mail.gq1.yahoo.com (sonic304-25.consmr.mail.gq1.yahoo.com [98.137.68.206]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5f49b8c3-92b5-11ed-b8d0-410ff93cb8f0; Thu, 12 Jan 2023 21:12:02 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.gq1.yahoo.com with HTTP; Thu, 12 Jan 2023 20:11:59 +0000 Received: by hermes--production-ne1-5648bd7666-66bz5 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 12a3adf0d72bdac2656bc55e49474b54; Thu, 12 Jan 2023 20:11:56 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5f49b8c3-92b5-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1673554319; bh=T8yzQ0y1veKEWTZ3A4UhAjryizsAbXysdPhGQ1/7fBo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=XaX03yQeRqrSdAIosaWnLf1z0ibVtHfPr1DuKua474PKkL0ej9tjXE0+PoFLHpLTzqdVgYZcLPt4NUwi6jf18f5ynqjzY+ZDRI+D7UZFX8Gs2ncgHdFSee+MOh+/3N2QdmH9Vz6nRMPib5lCM2W3+Wk7Dd9j4mvcZq3z2RnX6YXLHAvHiTi/Yc4AN7s8QoykXyNM91LMGMd+OL7hRsHvRgOJuX9NE5kGi3/xgmgr+bjgR9ANesR9uae7JRojyxcm/KZ0o5fcj0/xlrmZK4654ZAUtkAaAfVOjdW1uVvuTdjlRLVoSLc06FKbx8jHHS0z4ekKXj6wfjC6pzrICHNhNA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1673554319; bh=pNair6KKPFevlfPd/dWK4VuBrJExe70/lSZOL07NlzE=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=ZOReAxUX28BzVbN31laJFQBgRnbmxdXE5j7yXZiyugA8k6Fi3YlU6lQ2P7Z6ngNSoqlUgL0u5GVMHIx3mrwKg0AxIeYF37DffBEpv3paOY1VMwm0wvw5P0PclBC85rk128sLq4zizZWtPL9jZ75JSi0Tez50jBNFIyIoToJIWyJ817CCCT/imeX1o58u+1vjs8lFfANnmgxvkLMyMa5IawLymcJxvabYboR8GCnBwXydL/uVb65kvskC1XqU/rKjBWfKKkSXWbW7CmuweEfZASw3F01OdJYkMt+YmpOqz3YNGDwCgB4ISHnsUjOLfZ9UmHBdgTjjQcPerrTeFOjvUA== X-YMail-OSG: 6Opf7xgVM1nSwtAsFMugYzGfg803wrYoYYNliXjoiwKBo_ALdOl6Y7ez5G4nTHj 2CsZfuGmpSbEIDh5SDD8VkTogAYqW6eax_zbIjgqH5TpOclbYgr0lweVZdG.A6Q1WN6.HBB37U2D NEU4oDsiXZQxZvpm..0MflPm2WRNzA854jRok1HOk8Zswss9vDAiGL8ErrOLjDNRCgh_99OSA4Wk V6MPWPe_93ngABL52XlBveJVjGKJWqOiFB5V0qhsdtIFOsGV6WGZnuxi_qhboaykBT9d.6xtMC1p sw_Ekph8bMyEGEToDDlrQQZaxJJncZM5aQ1P.rFhtFS8MYl8dgbAlryxWzhsH_LIfhwuUqrLmG8f i5q09bG_If.Gp9FONlhcalgO1B19uvaAzamfYld_J4FNWarUeHEySB3qHWulEYV5R57kSTzdkt9K dNjPdNQ7r.BL._tND9wrvLx9wma_8L7D881h7GbgQnbCPN_ricAsO7JA.w83ot5oHyWtXcsRf8e9 AGvnLuFHo_o6agntTCdM9HeRb.840oAKFxqv2WCvmm44JhmIWIDa86KAUfA5lLZ1qBTN3WADIM2t S8TFpkKY3rvG9Xuz9tbovg4f0JxKYvMolR1sHwIeYxH1guRmklWyHWVouCu350_gcxAfodeLxswK ewrov0oDulU5bqfXN1KMhWwe1HM0gpUyAAuwQtJOdDPSdLkcE3_gKIWtNKLEaseevRTq0wBYYMNf DylsqFuI2ZQjR17oDir8YBs4j.DqVWXTWJm.l.oSqkvpCJwn6DgFYwNiVtIhOj1P_LrN8f8cSEN5 av32KFCfTcCtrsKsIjN38KOW0Yva4r9MV0GwXErrR6tkf_Q1D4x2mk1mRhLEDH5D2WMtQ3vOdc0v RHFgWJrEBWOa9CjgKSK0x8pqddrpod1iEIptYVhBTwP3z2pObEPw5.FC6SvhLaelopJwel7d0paR KbdRANZu1FmSZB2N5OA1EsOZFxwgxcpgyQeHgXymdCnpHnMpseYOxAre2gfrMgsex8uwPzBXxeVt X8uTpChvF25SjxWk0TfVHAgGl494EkLv4mO9DL4lp7x2JEPBZnblNifpqrl04CwpfCuJUAEMmiox st1G48U6T8K8DImPGIvRUfMWsRVXsqzJ_MSfjbx7VVmEmbivJcKVvQkPDzoar21Z5g..vGuU9fww YgPXY3rtKhylbPOCVRm52TvJiPNSgyuj7u42Utce5EsZbrdX3pJA5qwVMDNUzYplNuHUd_BQXQUy wmpkllkmBguStRevHrc3_qztkIJDgha35uzhsDqG0eQtKn59subMgaxFRw8ITvv9jf9F4gVa9UDq IjfVOU3317gKF6YSqYy70lXwsuI3CPrAKWGI0XvuwbXv9BK12Syz5SDPoF38Wgn1OexmHffQVBPu UPcMMt9ka2_nHHRyOya5DpStOCbXhFKMNjgT6YtZ7jqWkiiZO3LeLys3JKF9UafpJZHqkVgwKUQ6 cC_qxvA7_6qdi9ieq6cTl.MhxS3QKKFslLmM6s_tVSo4l5AjamtUec9RmWZaBCs.t34Rlv11pNSp VlJbyvXqa3NTOgZAba0rvumZfGrRG5Sw2Osw.9hIWLHvNfCbVrsPYba6ITOwvhHwn3Xmv3Hpdl4K WtZIedUB3NSdFI04O1Ao12ebLgm5JbnqVSu5iRCD7rEg.zc.oKqQ8Vqn.P2OalAARoxCCbtgXROe rpM.cskUOGB632N4_dDm6DNqWfCXSXigiyGOon6a41Zth.Cdv41hHCGPvxU8gN8eDtqXV11vcq2L 4Xm9wmndhp9jtmbTNgyZ84bKYm8.w97dAHrxgqmpWxvvhdXg3aAcw6l1OKhPa6HI2GxswdlvfGO8 Eou_JmquymjorBbOS90hnBEYDEOUWjAY4MsYC.JQZvdRcgifZyuFETo2A.VkqcICuT44rNNDQm7_ B286OPeVfe4GJqqqJX3JBkfN6jQ_Nir2EOHgZKnkZdSqkcNqpH.QbRl8hmLrwIMp7zR0ow5525Rw e1M9P6tRZuLa4NwmeKg2r.TkrxWSAmdF1Qk.ps1UlMhqyTcbiL.F8nRiG7WKqP5xqn6d4Zb7OoDv P1pMtqQD0iqsu_4nSlMbd7CcwBdSrvB91RtYYTco.JjPt3GhyKuc9JgK9AbUonWgze7diQP4FMVT WWsI9UrGnvkOj61dpNHSO6XmBTy.EqlaBWEir3JN2_.EGyOgG_u2Trhy3w.MvGSVwKSTmg3MvjuV 6u6Bkiyh7byMf.vcgMFMx3lM- X-Sonic-MF: Message-ID: <9f63e7a6-e434-64b4-f082-7f5a0ab8d5bf@aol.com> Date: Thu, 12 Jan 2023 15:11:54 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v8] xen/pt: reserve PCI slot 2 for Intel igd-passthru To: Bernhard Beschow , "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org, Stefano Stabellini , Anthony Perard , Paul Durrant , Paolo Bonzini , Richard Henderson , Eduardo Habkost , Marcel Apfelbaum , xen-devel@lists.xenproject.org, =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= References: <20230110030331-mutt-send-email-mst@kernel.org> Content-Language: en-US From: Chuck Zmudzinski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.21062 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 16390 On 1/12/23 2:18 PM, Bernhard Beschow wrote: > > > Am 11. Januar 2023 15:40:24 UTC schrieb Chuck Zmudzinski : >>On 1/10/23 3:16 AM, Michael S. Tsirkin wrote: >>> On Tue, Jan 10, 2023 at 02:08:34AM -0500, Chuck Zmudzinski wrote: >>>> Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, >>>> as noted in docs/igd-assign.txt in the Qemu source code. >>>> >>>> Currently, when the xl toolstack is used to configure a Xen HVM guest with >>>> Intel IGD passthrough to the guest with the Qemu upstream device model, >>>> a Qemu emulated PCI device will occupy slot 2 and the Intel IGD will occupy >>>> a different slot. This problem often prevents the guest from booting. >>>> >>>> The only available workaround is not good: Configure Xen HVM guests to use >>>> the old and no longer maintained Qemu traditional device model available >>>> from xenbits.xen.org which does reserve slot 2 for the Intel IGD. >>>> >>>> To implement this feature in the Qemu upstream device model for Xen HVM >>>> guests, introduce the following new functions, types, and macros: >>>> >>>> * XEN_PT_DEVICE_CLASS declaration, based on the existing TYPE_XEN_PT_DEVICE >>>> * XEN_PT_DEVICE_GET_CLASS macro helper function for XEN_PT_DEVICE_CLASS >>>> * typedef XenPTQdevRealize function pointer >>>> * XEN_PCI_IGD_SLOT_MASK, the value of slot_reserved_mask to reserve slot 2 >>>> * xen_igd_reserve_slot and xen_igd_clear_slot functions >>>> >>>> The new xen_igd_reserve_slot function uses the existing slot_reserved_mask >>>> member of PCIBus to reserve PCI slot 2 for Xen HVM guests configured using >>>> the xl toolstack with the gfx_passthru option enabled, which sets the >>>> igd-passthru=on option to Qemu for the Xen HVM machine type. >>>> >>>> The new xen_igd_reserve_slot function also needs to be implemented in >>>> hw/xen/xen_pt_stub.c to prevent FTBFS during the link stage for the case >>>> when Qemu is configured with --enable-xen and --disable-xen-pci-passthrough, >>>> in which case it does nothing. >>>> >>>> The new xen_igd_clear_slot function overrides qdev->realize of the parent >>>> PCI device class to enable the Intel IGD to occupy slot 2 on the PCI bus >>>> since slot 2 was reserved by xen_igd_reserve_slot when the PCI bus was >>>> created in hw/i386/pc_piix.c for the case when igd-passthru=on. >>>> >>>> Move the call to xen_host_pci_device_get, and the associated error >>>> handling, from xen_pt_realize to the new xen_igd_clear_slot function to >>>> initialize the device class and vendor values which enables the checks for >>>> the Intel IGD to succeed. The verification that the host device is an >>>> Intel IGD to be passed through is done by checking the domain, bus, slot, >>>> and function values as well as by checking that gfx_passthru is enabled, >>>> the device class is VGA, and the device vendor in Intel. >>>> >>>> Signed-off-by: Chuck Zmudzinski >>>> --- >>>> Notes that might be helpful to reviewers of patched code in hw/xen: >>>> >>>> The new functions and types are based on recommendations from Qemu docs: >>>> https://qemu.readthedocs.io/en/latest/devel/qom.html >>>> >>>> Notes that might be helpful to reviewers of patched code in hw/i386: >>>> >>>> The small patch to hw/i386/pc_piix.c is protected by CONFIG_XEN so it does >>>> not affect builds that do not have CONFIG_XEN defined. >>>> >>>> xen_igd_gfx_pt_enabled() in the patched hw/i386/pc_piix.c file is an >>>> existing function that is only true when Qemu is built with >>>> xen-pci-passthrough enabled and the administrator has configured the Xen >>>> HVM guest with Qemu's igd-passthru=on option. >>>> >>>> v2: Remove From: tag at top of commit message >>>> >>>> v3: Changed the test for the Intel IGD in xen_igd_clear_slot: >>>> >>>> if (is_igd_vga_passthrough(&s->real_device) && >>>> (s->real_device.vendor_id == PCI_VENDOR_ID_INTEL)) { >>>> >>>> is changed to >>>> >>>> if (xen_igd_gfx_pt_enabled() && (s->hostaddr.slot == 2) >>>> && (s->hostaddr.function == 0)) { >>>> >>>> I hoped that I could use the test in v2, since it matches the >>>> other tests for the Intel IGD in Qemu and Xen, but those tests >>>> do not work because the necessary data structures are not set with >>>> their values yet. So instead use the test that the administrator >>>> has enabled gfx_passthru and the device address on the host is >>>> 02.0. This test does detect the Intel IGD correctly. >>>> >>>> v4: Use brchuckz@aol.com instead of brchuckz@netscape.net for the author's >>>> email address to match the address used by the same author in commits >>>> be9c61da and c0e86b76 >>>> >>>> Change variable for XEN_PT_DEVICE_CLASS: xptc changed to xpdc >>>> >>>> v5: The patch of xen_pt.c was re-worked to allow a more consistent test >>>> for the Intel IGD that uses the same criteria as in other places. >>>> This involved moving the call to xen_host_pci_device_get from >>>> xen_pt_realize to xen_igd_clear_slot and updating the checks for the >>>> Intel IGD in xen_igd_clear_slot: >>>> >>>> if (xen_igd_gfx_pt_enabled() && (s->hostaddr.slot == 2) >>>> && (s->hostaddr.function == 0)) { >>>> >>>> is changed to >>>> >>>> if (is_igd_vga_passthrough(&s->real_device) && >>>> s->real_device.domain == 0 && s->real_device.bus == 0 && >>>> s->real_device.dev == 2 && s->real_device.func == 0 && >>>> s->real_device.vendor_id == PCI_VENDOR_ID_INTEL) { >>>> >>>> Added an explanation for the move of xen_host_pci_device_get from >>>> xen_pt_realize to xen_igd_clear_slot to the commit message. >>>> >>>> Rebase. >>>> >>>> v6: Fix logging by removing these lines from the move from xen_pt_realize >>>> to xen_igd_clear_slot that was done in v5: >>>> >>>> XEN_PT_LOG(d, "Assigning real physical device %02x:%02x.%d" >>>> " to devfn 0x%x\n", >>>> s->hostaddr.bus, s->hostaddr.slot, s->hostaddr.function, >>>> s->dev.devfn); >>>> >>>> This log needs to be in xen_pt_realize because s->dev.devfn is not >>>> set yet in xen_igd_clear_slot. >>>> >>>> v7: The v7 that was posted to the mailing list was incorrect. v8 is what >>>> v7 was intended to be. >>>> >>>> v8: Inhibit out of context log message and needless processing by >>>> adding 2 lines at the top of the new xen_igd_clear_slot function: >>>> >>>> if (!(pci_bus->slot_reserved_mask & XEN_PCI_IGD_SLOT_MASK)) >>>> return; >>>> >>>> Rebase. This removed an unnecessary header file from xen_pt.h >>>> >>>> hw/i386/pc_piix.c | 3 +++ >>>> hw/xen/xen_pt.c | 49 ++++++++++++++++++++++++++++++++++++-------- >>>> hw/xen/xen_pt.h | 16 +++++++++++++++ >>>> hw/xen/xen_pt_stub.c | 4 ++++ >>>> 4 files changed, 63 insertions(+), 9 deletions(-) >>>> >>>> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c >>>> index b48047f50c..bc5efa4f59 100644 >>>> --- a/hw/i386/pc_piix.c >>>> +++ b/hw/i386/pc_piix.c >>>> @@ -405,6 +405,9 @@ static void pc_xen_hvm_init(MachineState *machine) >>>> } >>>> >>>> pc_xen_hvm_init_pci(machine); >>>> + if (xen_igd_gfx_pt_enabled()) { >>>> + xen_igd_reserve_slot(pcms->bus); >>>> + } >>>> pci_create_simple(pcms->bus, -1, "xen-platform"); >>>> } >>>> #endif >>> >>> I would even maybe go further and move the whole logic into >>> xen_igd_reserve_slot. And I would even just name it >>> xen_hvm_init_reserved_slots without worrying about the what >>> or why at the pc level. At this point it will be up to Xen maintainers. >> >>I see to do that would be to resolve the two pc_xen_hvm* >>functions in pc_piix.c that are guarded by CONFIG_XEN and >>move them to an appropriate place such as xen-hvm.c. >> >>That is along the lines of the work that Bernhard and Philippe >>are doing, so I am Cc'ing them. My first inclination is just >>to defer to them: I think eventually the little patch I propose >>here to pc_piix.c is eventually going to be moved out of pc_piix.c >>by Bernhard in a future patch. >> >>What they have been doing is very conservative, and I expect >>if and when Bernhard gets here to resolve those functions, they >>will do it in a way that keeps the dependency of the xenfv machine >>type on the pc machine type and the pc_init1 function. >> >>What I would propose would be to break the dependency of xenfv >>on the pc_init1 function. That is, I would propose having a >>xenfv_init function in xen-hvm.c, and the first version would >>be the current version of pc_init1, so xenfv would still depend >>on many i440fx type things, but with the change xen developers >>would be free to tweak xenfv_init without affecting the users >>of the pc machine type. >> >>Would that be a good idea? If I get posiive feedback for this >>idea, I will put it on the table, probably initially as an RFC >>patch. > > In various patches I've been decoupling 1/ PIIX3 from Xen and 2/ QEMU's Xen integration code from the PC machine. My idea is to confine all wiring for a PIIX based PC machine using Xen in pc_piix.c. The pc_xen_hvm* functions seem to do exactly that, so I'd leave them there, at least for now. > > What I would like to avoid is for the Xen integration code to make assumptions that an x86 or PC machine is always based on i440fx or PIIX3. I think what you are saying is that if I try to move the logic of my patch to xen-hvm.c, as Michael suggests, I should not move or copy any piix3 code to the Xen integration code, but access it via an appropriate qom interface to the code in pc_piix.c and only move Xen specific things to the Xen integration code such as the content of my patch. I can try to do that for a v9 of my patch. It might take me a little while (I am not a professional coder), so I will just leave v8 of my patch as is for now until I have a patch ready to move it out of pc_piix.c the qom way. Thanks, Chuck > > I like Michael's idea of going one step further, both in terms of the approach and the reasoning. > > Best regards, > Bernhard > >>Also, thanks, Michael, for your other suggestions for this patch >>about using macros for the devfn constants. >> >>Chuck >> >>> >>>> diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c >>>> index 0ec7e52183..eff38155ef 100644 >>>> --- a/hw/xen/xen_pt.c >>>> +++ b/hw/xen/xen_pt.c >>>> @@ -780,15 +780,6 @@ static void xen_pt_realize(PCIDevice *d, Error **errp) >>>> s->hostaddr.bus, s->hostaddr.slot, s->hostaddr.function, >>>> s->dev.devfn); >>>> >>>> - xen_host_pci_device_get(&s->real_device, >>>> - s->hostaddr.domain, s->hostaddr.bus, >>>> - s->hostaddr.slot, s->hostaddr.function, >>>> - errp); >>>> - if (*errp) { >>>> - error_append_hint(errp, "Failed to \"open\" the real pci device"); >>>> - return; >>>> - } >>>> - >>>> s->is_virtfn = s->real_device.is_virtfn; >>>> if (s->is_virtfn) { >>>> XEN_PT_LOG(d, "%04x:%02x:%02x.%d is a SR-IOV Virtual Function\n", >>>> @@ -950,11 +941,50 @@ static void xen_pci_passthrough_instance_init(Object *obj) >>>> PCI_DEVICE(obj)->cap_present |= QEMU_PCI_CAP_EXPRESS; >>>> } >>>> >>>> +void xen_igd_reserve_slot(PCIBus *pci_bus) >>>> +{ >>>> + XEN_PT_LOG(0, "Reserving PCI slot 2 for IGD\n"); >>>> + pci_bus->slot_reserved_mask |= XEN_PCI_IGD_SLOT_MASK; >>>> +} >>>> + >>>> +static void xen_igd_clear_slot(DeviceState *qdev, Error **errp) >>>> +{ >>>> + ERRP_GUARD(); >>>> + PCIDevice *pci_dev = (PCIDevice *)qdev; >>>> + XenPCIPassthroughState *s = XEN_PT_DEVICE(pci_dev); >>>> + XenPTDeviceClass *xpdc = XEN_PT_DEVICE_GET_CLASS(s); >>>> + PCIBus *pci_bus = pci_get_bus(pci_dev); >>>> + >>>> + if (!(pci_bus->slot_reserved_mask & XEN_PCI_IGD_SLOT_MASK)) >>>> + return; >>>> + >>>> + xen_host_pci_device_get(&s->real_device, >>>> + s->hostaddr.domain, s->hostaddr.bus, >>>> + s->hostaddr.slot, s->hostaddr.function, >>>> + errp); >>>> + if (*errp) { >>>> + error_append_hint(errp, "Failed to \"open\" the real pci device"); >>>> + return; >>>> + } >>>> + >>>> + if (is_igd_vga_passthrough(&s->real_device) && >>>> + s->real_device.domain == 0 && s->real_device.bus == 0 && >>>> + s->real_device.dev == 2 && s->real_device.func == 0 && >>>> + s->real_device.vendor_id == PCI_VENDOR_ID_INTEL) { >>> >>> how about macros for these? >>> >>> #define XEN_PCI_IGD_DOMAIN 0 >>> #define XEN_PCI_IGD_BUS 0 >>> #define XEN_PCI_IGD_DEV 2 >>> #define XEN_PCI_IGD_FN 0 >>> >>>> + pci_bus->slot_reserved_mask &= ~XEN_PCI_IGD_SLOT_MASK; >>> >>> If you are going to do this, you should set it back >>> either after pci_qdev_realize or in unrealize, >>> for symmetry. >>> >>>> + XEN_PT_LOG(pci_dev, "Intel IGD found, using slot 2\n"); >>>> + } >>> >>> >>>> + xpdc->pci_qdev_realize(qdev, errp); >>>> +} >>>> + >>> >>> >>> >>>> static void xen_pci_passthrough_class_init(ObjectClass *klass, void *data) >>>> { >>>> DeviceClass *dc = DEVICE_CLASS(klass); >>>> PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); >>>> >>>> + XenPTDeviceClass *xpdc = XEN_PT_DEVICE_CLASS(klass); >>>> + xpdc->pci_qdev_realize = dc->realize; >>>> + dc->realize = xen_igd_clear_slot; >>>> k->realize = xen_pt_realize; >>>> k->exit = xen_pt_unregister_device; >>>> k->config_read = xen_pt_pci_read_config; >>>> @@ -977,6 +1007,7 @@ static const TypeInfo xen_pci_passthrough_info = { >>>> .instance_size = sizeof(XenPCIPassthroughState), >>>> .instance_finalize = xen_pci_passthrough_finalize, >>>> .class_init = xen_pci_passthrough_class_init, >>>> + .class_size = sizeof(XenPTDeviceClass), >>>> .instance_init = xen_pci_passthrough_instance_init, >>>> .interfaces = (InterfaceInfo[]) { >>>> { INTERFACE_CONVENTIONAL_PCI_DEVICE }, >>>> diff --git a/hw/xen/xen_pt.h b/hw/xen/xen_pt.h >>>> index cf10fc7bbf..8c25932b4b 100644 >>>> --- a/hw/xen/xen_pt.h >>>> +++ b/hw/xen/xen_pt.h >>>> @@ -2,6 +2,7 @@ >>>> #define XEN_PT_H >>>> >>>> #include "hw/xen/xen_common.h" >>>> +#include "hw/pci/pci_bus.h" >>>> #include "xen-host-pci-device.h" >>>> #include "qom/object.h" >>>> >>>> @@ -40,7 +41,20 @@ typedef struct XenPTReg XenPTReg; >>>> #define TYPE_XEN_PT_DEVICE "xen-pci-passthrough" >>>> OBJECT_DECLARE_SIMPLE_TYPE(XenPCIPassthroughState, XEN_PT_DEVICE) >>>> >>>> +#define XEN_PT_DEVICE_CLASS(klass) \ >>>> + OBJECT_CLASS_CHECK(XenPTDeviceClass, klass, TYPE_XEN_PT_DEVICE) >>>> +#define XEN_PT_DEVICE_GET_CLASS(obj) \ >>>> + OBJECT_GET_CLASS(XenPTDeviceClass, obj, TYPE_XEN_PT_DEVICE) >>>> + >>>> +typedef void (*XenPTQdevRealize)(DeviceState *qdev, Error **errp); >>>> + >>>> +typedef struct XenPTDeviceClass { >>>> + PCIDeviceClass parent_class; >>>> + XenPTQdevRealize pci_qdev_realize; >>>> +} XenPTDeviceClass; >>>> + >>>> uint32_t igd_read_opregion(XenPCIPassthroughState *s); >>>> +void xen_igd_reserve_slot(PCIBus *pci_bus); >>>> void igd_write_opregion(XenPCIPassthroughState *s, uint32_t val); >>>> void xen_igd_passthrough_isa_bridge_create(XenPCIPassthroughState *s, >>>> XenHostPCIDevice *dev); >>>> @@ -75,6 +89,8 @@ typedef int (*xen_pt_conf_byte_read) >>>> >>>> #define XEN_PCI_INTEL_OPREGION 0xfc >>>> >>>> +#define XEN_PCI_IGD_SLOT_MASK 0x4UL /* Intel IGD slot_reserved_mask */ >>>> + >>> >>> I think you want to calculate this based on dev fn: >>> >>> #define XEN_PCI_IGD_SLOT_MASK \ >>> (0x1 << PCI_SLOT(PCI_DEVFN(XEN_PCI_IGD_DEV, XEN_PCI_IGD_FN))) >>> >>> >>>> typedef enum { >>>> XEN_PT_GRP_TYPE_HARDWIRED = 0, /* 0 Hardwired reg group */ >>>> XEN_PT_GRP_TYPE_EMU, /* emul reg group */ >>>> diff --git a/hw/xen/xen_pt_stub.c b/hw/xen/xen_pt_stub.c >>>> index 2d8cac8d54..5c108446a8 100644 >>>> --- a/hw/xen/xen_pt_stub.c >>>> +++ b/hw/xen/xen_pt_stub.c >>>> @@ -20,3 +20,7 @@ void xen_igd_gfx_pt_set(bool value, Error **errp) >>>> error_setg(errp, "Xen PCI passthrough support not built in"); >>>> } >>>> } >>>> + >>>> +void xen_igd_reserve_slot(PCIBus *pci_bus) >>>> +{ >>>> +} >>>> -- >>>> 2.39.0 >>> >> From xen-devel-bounces@lists.xenproject.org Thu Jan 12 20:48:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 20:48:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476402.738551 (Exim 4.92) (envelope-from ) id 1pG4Ui-0005HH-Dt; Thu, 12 Jan 2023 20:48:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476402.738551; Thu, 12 Jan 2023 20:48:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG4Ui-0005HA-9g; Thu, 12 Jan 2023 20:48:16 +0000 Received: by outflank-mailman (input) for mailman id 476402; Thu, 12 Jan 2023 20:48:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG4Uh-0005H0-B5; Thu, 12 Jan 2023 20:48:15 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG4Uh-0003Wi-8e; Thu, 12 Jan 2023 20:48:15 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG4Ug-0004i9-QR; Thu, 12 Jan 2023 20:48:14 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pG4Ug-00014H-Pz; Thu, 12 Jan 2023 20:48:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=MHWVvIxNwm4T7vL/zFZ2YhuRE1CieVrj3SqKG2tYnF8=; b=2HsRYFgeRrLf2olxwrEInUTSPW OpCBKpHpts/wdM+tZ+ZNq+0+iucTCm4AeenQzDscGDC8h+WAo4VCS9J8iRDNt5jPdyUC0S2b4PYta VQBYX+9kPFSESOjD8J30CtSrVR7YplTp7BQEhGuM70aDIVKZ8WWr48FE7aCULHF8Rcao=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 175737: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=e8f60cd7db24f94f2dbed6bec30dd16a68fc0828 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Thu, 12 Jan 2023 20:48:14 +0000 flight 175737 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/175737/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 173462 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 173462 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-examine 8 reboot fail REGR. vs. 173462 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-examine 8 reboot fail REGR. vs. 173462 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 173462 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 173462 test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass version targeted for testing: linux e8f60cd7db24f94f2dbed6bec30dd16a68fc0828 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 97 days Failing since 173470 2022-10-08 06:21:34 Z 96 days 203 attempts Testing same since 175737 2023-01-12 07:08:51 Z 0 days 1 attempts ------------------------------------------------------------ 3320 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine fail test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 506287 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Jan 12 21:51:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 21:51:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476410.738562 (Exim 4.92) (envelope-from ) id 1pG5Tp-0004bw-1V; Thu, 12 Jan 2023 21:51:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476410.738562; Thu, 12 Jan 2023 21:51:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG5To-0004bp-UX; Thu, 12 Jan 2023 21:51:24 +0000 Received: by outflank-mailman (input) for mailman id 476410; Thu, 12 Jan 2023 21:51:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG5Tn-0004bj-6w for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 21:51:23 +0000 Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [2607:f8b0:4864:20::634]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3e934cf7-92c3-11ed-b8d0-410ff93cb8f0; Thu, 12 Jan 2023 22:51:19 +0100 (CET) Received: by mail-pl1-x634.google.com with SMTP id p24so21526718plw.11 for ; Thu, 12 Jan 2023 13:51:19 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id im22-20020a170902bb1600b0018bc4493005sm12607234plb.269.2023.01.12.13.51.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jan 2023 13:51:17 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3e934cf7-92c3-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=CWezmmHa6oj6qJtMomh+1hZZGWqGQrSyq0C7qN1MANE=; b=NrhE8GeB0gPtUpLJmL0nObCWCBwo04pER0QWC7YeN486f0tyfa3g3S7BtDUHlIbXFW zwrs+/K+DcCOmOq9CHZZri2ktplzmFfjR3ymQ4DGsJ6K3GoZmmlnw6aXM90nHdEUvKT6 K3lDHI2HhmuViAyN/43XcHXcUD0CiNOTpAm0o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CWezmmHa6oj6qJtMomh+1hZZGWqGQrSyq0C7qN1MANE=; b=vkivjw+NIDq0yduZIFqA+Mjhb7co8dPMtWQU3A8zhU78+O4FqITOwhE4twm6t0dkjt +s0TFRPMUPO/Z1/e6i9PtxPHVyE4aKoLZNxOv38zpCy2UbzvGu+yovXSevdqIgsW4T4P KfUZJLSOnxySu1frhgK8fOBBLF1jAwhSkjhtKh+JITwrQeXjwfqKPYGebAY5iTvGl5ma OhAlDUKJJUSUEsPhTKU2g7RhmxfRxHXBr8EiiDnqm9EdeRWM75cY9tW2ej51mdxmSTrf xnVYGv1ztN6yiaWyfEtEdR9t3XgnkhMyZkXOGmimUsmz+S1CDUAV78KaSgLYYU7dtmlr 6Hyg== X-Gm-Message-State: AFqh2kqkLwe+NkSymyEogo68IcKeVzQvx0ArTnTKxQwAoD0IoIu8CDcP x+4+mmjTGhHKqxrrtjqrJb1urQ== X-Google-Smtp-Source: AMrXdXvH368zgSN+CqWpi3idJyL7uyuYLfW6YfP3XhLcEJ233wBi4Eh2ch09l2nZrresK14l3RKZWQ== X-Received: by 2002:a17:902:ba82:b0:189:86f0:70a2 with SMTP id k2-20020a170902ba8200b0018986f070a2mr37242231pls.43.1673560277885; Thu, 12 Jan 2023 13:51:17 -0800 (PST) Date: Thu, 12 Jan 2023 13:51:16 -0800 From: Kees Cook To: Peter Zijlstra Cc: x86@kernel.org, Joan Bruguera , linux-kernel@vger.kernel.org, Juergen Gross , "Rafael J. Wysocki" , xen-devel , Jan Beulich , Roger Pau Monne , mark.rutland@arm.com Subject: Re: [RFC][PATCH 2/6] x86/power: Inline write_cr[04]() Message-ID: <202301121351.B0CE02B@keescook> References: <20230112143141.645645775@infradead.org> <20230112143825.644480983@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230112143825.644480983@infradead.org> On Thu, Jan 12, 2023 at 03:31:43PM +0100, Peter Zijlstra wrote: > Since we can't do CALL/RET until GS is restored and CR[04] pinning is > of dubious value in this code path, simply write the stored values. > > Signed-off-by: Peter Zijlstra (Intel) Reviewed-by: Kees Cook -- Kees Cook From xen-devel-bounces@lists.xenproject.org Thu Jan 12 22:04:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 22:04:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476416.738572 (Exim 4.92) (envelope-from ) id 1pG5g2-0006HN-5h; Thu, 12 Jan 2023 22:04:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476416.738572; Thu, 12 Jan 2023 22:04:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG5g2-0006HG-2r; Thu, 12 Jan 2023 22:04:02 +0000 Received: by outflank-mailman (input) for mailman id 476416; Thu, 12 Jan 2023 22:04:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG5fz-0006Gr-V4 for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 22:04:00 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG5fz-0005CO-Eg; Thu, 12 Jan 2023 22:03:59 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pG5fz-00023U-7x; Thu, 12 Jan 2023 22:03:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=XuCioJJ2tqNj9WXBy6FbHR37qa0/LlKycYs7DN0nRMs=; b=uaBmPeFTamDNWUYJOXCJOXIaDJ ZPhUzzYH9X/oDERKm64upgGtRN2mZq39P2YCktEFiB+K+CFWKdI1BBQPACDabzTbqYmQQV5OBpjTM l+/Jdax6jMyMrfNwPMG0SmeYQeryp/lrUuN84fLc8QGs3cCRCNGVYy60d5affXUe741A=; Message-ID: <05007c7e-50ad-829e-21e2-6e26a7b01f96@xen.org> Date: Thu, 12 Jan 2023 22:03:57 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, michal.orzel@amd.com, Luca.Fancellu@arm.com, Julien Grall , Bertrand Marquis , Volodymyr Babchuk References: <20221212095523.52683-1-julien@xen.org> <20221212095523.52683-16-julien@xen.org> From: Julien Grall Subject: Re: [PATCH v3 15/18] xen/arm64: mm: Introduce helpers to prepare/enable/disable the identity mapping In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 13/12/2022 01:41, Stefano Stabellini wrote: >> diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h >> index fdbf68aadcaa..e7a80fecec14 100644 >> --- a/xen/arch/arm/include/asm/setup.h >> +++ b/xen/arch/arm/include/asm/setup.h >> @@ -168,6 +168,17 @@ int map_range_to_domain(const struct dt_device_node *dev, >> >> extern const char __ro_after_init_start[], __ro_after_init_end[]; >> >> +extern DEFINE_BOOT_PAGE_TABLE(boot_pgtable); >> + >> +#ifdef CONFIG_ARM_64 >> +extern DEFINE_BOOT_PAGE_TABLE(boot_first_id); >> +#endif >> +extern DEFINE_BOOT_PAGE_TABLE(boot_second_id); >> +extern DEFINE_BOOT_PAGE_TABLE(boot_third_id); > > This is more a matter of taste but I would either: > - define extern all BOOT_PAGE_TABLEs here both ARM64 and ARM32 with > #ifdefs A grep of BOOT_PAGE_TABLE shows that they are all defined in setup.h. > - or define all the ARM64 only BOOT_PAGE_TABLE in arm64/mm.h and all the > ARM32 only BOOT_PAGE_TABLE in arm32/mm.h > > Right now we have a mix, as we have boot_first_id with a #ifdef here > and we have xen_pgtable in arm64/mm.h We are talking about two distinct set of page-tables. One is used at runtime (i.e. xen_pgtable) and the other are for boot/smp-bring up. So adding the boot_* in setup.h is correct. As I wrote earlier, setup.h would need a split. But this is not something I really want to handle here... > > Also we are missing boot_second and boot_third. We might as well be > consistent and declare them all? My plan is really to kill boot_second and boot_third. So I don't really want to export them right now (even temporarily). In any case, I don't think such change belongs in this patch (it is already complex enough). >> +/* Find where Xen will be residing at runtime and return an PT entry */ >> +lpae_t pte_of_xenaddr(vaddr_t); >> + >> #endif >> /* >> * Local variables: >> diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c >> index 0cf7ad4f0e8c..39e0d9e03c9c 100644 >> --- a/xen/arch/arm/mm.c >> +++ b/xen/arch/arm/mm.c >> @@ -93,7 +93,7 @@ DEFINE_BOOT_PAGE_TABLE(boot_third); >> >> #ifdef CONFIG_ARM_64 >> #define HYP_PT_ROOT_LEVEL 0 >> -static DEFINE_PAGE_TABLE(xen_pgtable); >> +DEFINE_PAGE_TABLE(xen_pgtable); >> static DEFINE_PAGE_TABLE(xen_first); >> #define THIS_CPU_PGTABLE xen_pgtable >> #else >> @@ -388,7 +388,7 @@ void flush_page_to_ram(unsigned long mfn, bool sync_icache) >> invalidate_icache(); >> } >> >> -static inline lpae_t pte_of_xenaddr(vaddr_t va) >> +lpae_t pte_of_xenaddr(vaddr_t va) >> { >> paddr_t ma = va + phys_offset; >> >> @@ -495,6 +495,8 @@ void __init setup_pagetables(unsigned long boot_phys_offset) >> >> phys_offset = boot_phys_offset; >> >> + arch_setup_page_tables(); >> + >> #ifdef CONFIG_ARM_64 >> pte = pte_of_xenaddr((uintptr_t)xen_first); >> pte.pt.table = 1; >> -- >> 2.38.1 >> Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Jan 12 22:55:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 22:55:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476422.738584 (Exim 4.92) (envelope-from ) id 1pG6Tx-0003Xw-ST; Thu, 12 Jan 2023 22:55:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476422.738584; Thu, 12 Jan 2023 22:55:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG6Tx-0003Xp-Pe; Thu, 12 Jan 2023 22:55:37 +0000 Received: by outflank-mailman (input) for mailman id 476422; Thu, 12 Jan 2023 22:55:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG6Tv-0003Xj-M0 for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 22:55:36 +0000 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [2a00:1450:4864:20::62c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 37696762-92cc-11ed-b8d0-410ff93cb8f0; Thu, 12 Jan 2023 23:55:32 +0100 (CET) Received: by mail-ej1-x62c.google.com with SMTP id tz12so48365592ejc.9 for ; Thu, 12 Jan 2023 14:55:32 -0800 (PST) Received: from [127.0.0.1] (dynamic-092-224-135-062.92.224.pool.telefonica.de. [92.224.135.62]) by smtp.gmail.com with ESMTPSA id g9-20020a17090604c900b0085ca279966esm2907135eja.119.2023.01.12.14.55.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Jan 2023 14:55:30 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 37696762-92cc-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=gcBQah7LIkYMj8F1zQ+LBzI0aneJEGKZfwDsIYdF1Lo=; b=UsUA5pX1vdg/jHwhIuedEWTeDhL4HsuHBBxu2MOy/ZZHOi6httqHVC1dV6chqa6yKG ehfVJkeA8NYLyVsGzaKZ6T+zHH7kHSIwxcrxhlBnt2PCBhWpmmBjZIQVtjv+T3Y1dL/q C2U/PX9JJvmjQBmbydRokghip8jXsSGZ3/bGYCHJatLzLmodRBENxhbraHZwQN5+B3Jp X0F3VrP4WBAToQQ5Cyt1LdMYJ03U4df9my9EXoYKHUTjwtwBvMZhKtpsv4EZmF/VCBBm L8PV1CKze1Uc7U9q43f9N03S88VreZhU4PXtdv1j9p8bDtIBrB/zZx6rlobAv+RdOnmV ak6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gcBQah7LIkYMj8F1zQ+LBzI0aneJEGKZfwDsIYdF1Lo=; b=uflLX5ZiFrJRTii/8+3SjqSTdFeBYyMDQ7X2b/j8Sr3nLGDtOdrDbZMn6E7uS3yZdb kkIXBlOO7s+G3Z0w1hXlj38JcNygA+ojJIlU1EmKchxy4xEBnEkAwx7GCNTzGhUDLlsn DjYwgoFsDLGOngqp9T6uo2FP6cflkqzOhtPFzonq/F9Heea+dW+CW7EQ1kWlk85ACCs8 vWwGkzljfvlV5QoVmF8PV54w2p97UV2EHOxmZ1gISk/s9sRc/ZxF1ZhLdW0LoVWUoAHQ 6NjMvVF4XZ1GlA7KtypJXBRnN606ijIk9rjMD14uLs+6qZ1MwO5Ulm6JKXWcjHoBchb/ W1lA== X-Gm-Message-State: AFqh2kotrHDaT/FGAnFp64CqRssEql83YMCJsXHBCbsKELgOzapposYF JVIShI37MclBdeOejnStsjU= X-Google-Smtp-Source: AMrXdXslORGdXnAT5Qh+ZwtZAi1hOcSbTOS/be198kJia8qVDipsp9tC7Yv3brA25lVSSsq4szwbvg== X-Received: by 2002:a17:906:2dd9:b0:861:7cb0:ec64 with SMTP id h25-20020a1709062dd900b008617cb0ec64mr5950513eji.67.1673564131426; Thu, 12 Jan 2023 14:55:31 -0800 (PST) Date: Thu, 12 Jan 2023 22:55:25 +0000 From: Bernhard Beschow To: Chuck Zmudzinski , "Michael S. Tsirkin" CC: qemu-devel@nongnu.org, Stefano Stabellini , Anthony Perard , Paul Durrant , Paolo Bonzini , Richard Henderson , Eduardo Habkost , Marcel Apfelbaum , xen-devel@lists.xenproject.org, =?ISO-8859-1?Q?Philippe_Mathieu-Daud=E9?= Subject: Re: [PATCH v8] xen/pt: reserve PCI slot 2 for Intel igd-passthru In-Reply-To: <9f63e7a6-e434-64b4-f082-7f5a0ab8d5bf@aol.com> References: <20230110030331-mutt-send-email-mst@kernel.org> <9f63e7a6-e434-64b4-f082-7f5a0ab8d5bf@aol.com> Message-ID: <7208A064-2A25-4DBB-BF19-6797E96AB00C@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Am 12=2E Januar 2023 20:11:54 UTC schrieb Chuck Zmudzinski : >On 1/12/23 2:18=E2=80=AFPM, Bernhard Beschow wrote: >>=20 >>=20 >> Am 11=2E Januar 2023 15:40:24 UTC schrieb Chuck Zmudzinski : >>>On 1/10/23 3:16=E2=80=AFAM, Michael S=2E Tsirkin wrote: >>>> On Tue, Jan 10, 2023 at 02:08:34AM -0500, Chuck Zmudzinski wrote: >>>>> Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus= , >>>>> as noted in docs/igd-assign=2Etxt in the Qemu source code=2E >>>>>=20 >>>>> Currently, when the xl toolstack is used to configure a Xen HVM gues= t with >>>>> Intel IGD passthrough to the guest with the Qemu upstream device mod= el, >>>>> a Qemu emulated PCI device will occupy slot 2 and the Intel IGD will= occupy >>>>> a different slot=2E This problem often prevents the guest from booti= ng=2E >>>>>=20 >>>>> The only available workaround is not good: Configure Xen HVM guests = to use >>>>> the old and no longer maintained Qemu traditional device model avail= able >>>>> from xenbits=2Exen=2Eorg which does reserve slot 2 for the Intel IGD= =2E >>>>>=20 >>>>> To implement this feature in the Qemu upstream device model for Xen = HVM >>>>> guests, introduce the following new functions, types, and macros: >>>>>=20 >>>>> * XEN_PT_DEVICE_CLASS declaration, based on the existing TYPE_XEN_PT= _DEVICE >>>>> * XEN_PT_DEVICE_GET_CLASS macro helper function for XEN_PT_DEVICE_CL= ASS >>>>> * typedef XenPTQdevRealize function pointer >>>>> * XEN_PCI_IGD_SLOT_MASK, the value of slot_reserved_mask to reserve = slot 2 >>>>> * xen_igd_reserve_slot and xen_igd_clear_slot functions >>>>>=20 >>>>> The new xen_igd_reserve_slot function uses the existing slot_reserve= d_mask >>>>> member of PCIBus to reserve PCI slot 2 for Xen HVM guests configured= using >>>>> the xl toolstack with the gfx_passthru option enabled, which sets th= e >>>>> igd-passthru=3Don option to Qemu for the Xen HVM machine type=2E >>>>>=20 >>>>> The new xen_igd_reserve_slot function also needs to be implemented i= n >>>>> hw/xen/xen_pt_stub=2Ec to prevent FTBFS during the link stage for th= e case >>>>> when Qemu is configured with --enable-xen and --disable-xen-pci-pass= through, >>>>> in which case it does nothing=2E >>>>>=20 >>>>> The new xen_igd_clear_slot function overrides qdev->realize of the p= arent >>>>> PCI device class to enable the Intel IGD to occupy slot 2 on the PCI= bus >>>>> since slot 2 was reserved by xen_igd_reserve_slot when the PCI bus w= as >>>>> created in hw/i386/pc_piix=2Ec for the case when igd-passthru=3Don= =2E >>>>>=20 >>>>> Move the call to xen_host_pci_device_get, and the associated error >>>>> handling, from xen_pt_realize to the new xen_igd_clear_slot function= to >>>>> initialize the device class and vendor values which enables the chec= ks for >>>>> the Intel IGD to succeed=2E The verification that the host device is= an >>>>> Intel IGD to be passed through is done by checking the domain, bus, = slot, >>>>> and function values as well as by checking that gfx_passthru is enab= led, >>>>> the device class is VGA, and the device vendor in Intel=2E >>>>>=20 >>>>> Signed-off-by: Chuck Zmudzinski >>>>> --- >>>>> Notes that might be helpful to reviewers of patched code in hw/xen: >>>>>=20 >>>>> The new functions and types are based on recommendations from Qemu d= ocs: >>>>> https://qemu=2Ereadthedocs=2Eio/en/latest/devel/qom=2Ehtml >>>>>=20 >>>>> Notes that might be helpful to reviewers of patched code in hw/i386: >>>>>=20 >>>>> The small patch to hw/i386/pc_piix=2Ec is protected by CONFIG_XEN so= it does >>>>> not affect builds that do not have CONFIG_XEN defined=2E >>>>>=20 >>>>> xen_igd_gfx_pt_enabled() in the patched hw/i386/pc_piix=2Ec file is = an >>>>> existing function that is only true when Qemu is built with >>>>> xen-pci-passthrough enabled and the administrator has configured the= Xen >>>>> HVM guest with Qemu's igd-passthru=3Don option=2E >>>>>=20 >>>>> v2: Remove From: tag at top of commit message >>>>>=20 >>>>> v3: Changed the test for the Intel IGD in xen_igd_clear_slot: >>>>>=20 >>>>> if (is_igd_vga_passthrough(&s->real_device) && >>>>> (s->real_device=2Evendor_id =3D=3D PCI_VENDOR_ID_INTEL)) { >>>>>=20 >>>>> is changed to >>>>>=20 >>>>> if (xen_igd_gfx_pt_enabled() && (s->hostaddr=2Eslot =3D=3D 2) >>>>> && (s->hostaddr=2Efunction =3D=3D 0)) { >>>>>=20 >>>>> I hoped that I could use the test in v2, since it matches the >>>>> other tests for the Intel IGD in Qemu and Xen, but those tests >>>>> do not work because the necessary data structures are not set wi= th >>>>> their values yet=2E So instead use the test that the administrat= or >>>>> has enabled gfx_passthru and the device address on the host is >>>>> 02=2E0=2E This test does detect the Intel IGD correctly=2E >>>>>=20 >>>>> v4: Use brchuckz@aol=2Ecom instead of brchuckz@netscape=2Enet for th= e author's >>>>> email address to match the address used by the same author in co= mmits >>>>> be9c61da and c0e86b76 >>>>> =20 >>>>> Change variable for XEN_PT_DEVICE_CLASS: xptc changed to xpdc >>>>>=20 >>>>> v5: The patch of xen_pt=2Ec was re-worked to allow a more consistent= test >>>>> for the Intel IGD that uses the same criteria as in other places= =2E >>>>> This involved moving the call to xen_host_pci_device_get from >>>>> xen_pt_realize to xen_igd_clear_slot and updating the checks for= the >>>>> Intel IGD in xen_igd_clear_slot: >>>>> =20 >>>>> if (xen_igd_gfx_pt_enabled() && (s->hostaddr=2Eslot =3D=3D 2) >>>>> && (s->hostaddr=2Efunction =3D=3D 0)) { >>>>>=20 >>>>> is changed to >>>>>=20 >>>>> if (is_igd_vga_passthrough(&s->real_device) && >>>>> s->real_device=2Edomain =3D=3D 0 && s->real_device=2Ebus =3D= =3D 0 && >>>>> s->real_device=2Edev =3D=3D 2 && s->real_device=2Efunc =3D= =3D 0 && >>>>> s->real_device=2Evendor_id =3D=3D PCI_VENDOR_ID_INTEL) { >>>>>=20 >>>>> Added an explanation for the move of xen_host_pci_device_get fro= m >>>>> xen_pt_realize to xen_igd_clear_slot to the commit message=2E >>>>>=20 >>>>> Rebase=2E >>>>>=20 >>>>> v6: Fix logging by removing these lines from the move from xen_pt_re= alize >>>>> to xen_igd_clear_slot that was done in v5: >>>>>=20 >>>>> XEN_PT_LOG(d, "Assigning real physical device %02x:%02x=2E%d" >>>>> " to devfn 0x%x\n", >>>>> s->hostaddr=2Ebus, s->hostaddr=2Eslot, s->hostaddr=2E= function, >>>>> s->dev=2Edevfn); >>>>>=20 >>>>> This log needs to be in xen_pt_realize because s->dev=2Edevfn is= not >>>>> set yet in xen_igd_clear_slot=2E >>>>>=20 >>>>> v7: The v7 that was posted to the mailing list was incorrect=2E v8 i= s what >>>>> v7 was intended to be=2E >>>>>=20 >>>>> v8: Inhibit out of context log message and needless processing by >>>>> adding 2 lines at the top of the new xen_igd_clear_slot function= : >>>>>=20 >>>>> if (!(pci_bus->slot_reserved_mask & XEN_PCI_IGD_SLOT_MASK)) >>>>> return; >>>>>=20 >>>>> Rebase=2E This removed an unnecessary header file from xen_pt=2E= h=20 >>>>>=20 >>>>> hw/i386/pc_piix=2Ec | 3 +++ >>>>> hw/xen/xen_pt=2Ec | 49 ++++++++++++++++++++++++++++++++++++---= ----- >>>>> hw/xen/xen_pt=2Eh | 16 +++++++++++++++ >>>>> hw/xen/xen_pt_stub=2Ec | 4 ++++ >>>>> 4 files changed, 63 insertions(+), 9 deletions(-) >>>>>=20 >>>>> diff --git a/hw/i386/pc_piix=2Ec b/hw/i386/pc_piix=2Ec >>>>> index b48047f50c=2E=2Ebc5efa4f59 100644 >>>>> --- a/hw/i386/pc_piix=2Ec >>>>> +++ b/hw/i386/pc_piix=2Ec >>>>> @@ -405,6 +405,9 @@ static void pc_xen_hvm_init(MachineState *machin= e) >>>>> } >>>>> =20 >>>>> pc_xen_hvm_init_pci(machine); >>>>> + if (xen_igd_gfx_pt_enabled()) { >>>>> + xen_igd_reserve_slot(pcms->bus); >>>>> + } >>>>> pci_create_simple(pcms->bus, -1, "xen-platform"); >>>>> } >>>>> #endif >>>>=20 >>>> I would even maybe go further and move the whole logic into >>>> xen_igd_reserve_slot=2E And I would even just name it >>>> xen_hvm_init_reserved_slots without worrying about the what >>>> or why at the pc level=2E At this point it will be up to Xen maintai= ners=2E >>> >>>I see to do that would be to resolve the two pc_xen_hvm* >>>functions in pc_piix=2Ec that are guarded by CONFIG_XEN and >>>move them to an appropriate place such as xen-hvm=2Ec=2E >>> >>>That is along the lines of the work that Bernhard and Philippe >>>are doing, so I am Cc'ing them=2E My first inclination is just >>>to defer to them: I think eventually the little patch I propose >>>here to pc_piix=2Ec is eventually going to be moved out of pc_piix=2Ec >>>by Bernhard in a future patch=2E >>> >>>What they have been doing is very conservative, and I expect >>>if and when Bernhard gets here to resolve those functions, they >>>will do it in a way that keeps the dependency of the xenfv machine >>>type on the pc machine type and the pc_init1 function=2E >>> >>>What I would propose would be to break the dependency of xenfv >>>on the pc_init1 function=2E That is, I would propose having a >>>xenfv_init function in xen-hvm=2Ec, and the first version would >>>be the current version of pc_init1, so xenfv would still depend >>>on many i440fx type things, but with the change xen developers >>>would be free to tweak xenfv_init without affecting the users >>>of the pc machine type=2E >>> >>>Would that be a good idea? If I get posiive feedback for this >>>idea, I will put it on the table, probably initially as an RFC >>>patch=2E >>=20 >> In various patches I've been decoupling 1/ PIIX3 from Xen and 2/ QEMU's= Xen integration code from the PC machine=2E My idea is to confine all wiri= ng for a PIIX based PC machine using Xen in pc_piix=2Ec=2E The pc_xen_hvm* = functions seem to do exactly that, so I'd leave them there, at least for no= w=2E >>=20 >> What I would like to avoid is for the Xen integration code to make assu= mptions that an x86 or PC machine is always based on i440fx or PIIX3=2E > >I think what you are saying is that if I try to move the logic of my patc= h to xen-hvm=2Ec, as Michael suggests, I should not move or copy any piix3 = code to the Xen integration code, but access it via an appropriate qom inte= rface to the code in pc_piix=2Ec and only move Xen specific things to the X= en integration code such as the content of my patch=2E I can try to do that= for a v9 of my patch=2E It might take me a little while (I am not a profes= sional coder), so I will just leave v8 of my patch as is for now until I ha= ve a patch ready to move it out of pc_piix=2Ec the qom way=2E I think the change Michael suggests is very minimalistic: Move the if cond= ition around xen_igd_reserve_slot() into the function itself and always cal= l it there unconditionally -- basically turning three lines into one=2E Sin= ce xen_igd_reserve_slot() seems very problem specific, Michael further sugg= ests to rename it to something more general=2E All in all no big changes re= quired=2E Best regards, Bernhard > >Thanks, > >Chuck > >>=20 >> I like Michael's idea of going one step further, both in terms of the a= pproach and the reasoning=2E >>=20 >> Best regards, >> Bernhard >>=20 >>>Also, thanks, Michael, for your other suggestions for this patch >>>about using macros for the devfn constants=2E >>> >>>Chuck >>> >>>>=20 >>>>> diff --git a/hw/xen/xen_pt=2Ec b/hw/xen/xen_pt=2Ec >>>>> index 0ec7e52183=2E=2Eeff38155ef 100644 >>>>> --- a/hw/xen/xen_pt=2Ec >>>>> +++ b/hw/xen/xen_pt=2Ec >>>>> @@ -780,15 +780,6 @@ static void xen_pt_realize(PCIDevice *d, Error = **errp) >>>>> s->hostaddr=2Ebus, s->hostaddr=2Eslot, s->hostaddr= =2Efunction, >>>>> s->dev=2Edevfn); >>>>> =20 >>>>> - xen_host_pci_device_get(&s->real_device, >>>>> - s->hostaddr=2Edomain, s->hostaddr=2Ebus= , >>>>> - s->hostaddr=2Eslot, s->hostaddr=2Efunct= ion, >>>>> - errp); >>>>> - if (*errp) { >>>>> - error_append_hint(errp, "Failed to \"open\" the real pci de= vice"); >>>>> - return; >>>>> - } >>>>> - >>>>> s->is_virtfn =3D s->real_device=2Eis_virtfn; >>>>> if (s->is_virtfn) { >>>>> XEN_PT_LOG(d, "%04x:%02x:%02x=2E%d is a SR-IOV Virtual Func= tion\n", >>>>> @@ -950,11 +941,50 @@ static void xen_pci_passthrough_instance_init(= Object *obj) >>>>> PCI_DEVICE(obj)->cap_present |=3D QEMU_PCI_CAP_EXPRESS; >>>>> } >>>>> =20 >>>>> +void xen_igd_reserve_slot(PCIBus *pci_bus) >>>>> +{ >>>>> + XEN_PT_LOG(0, "Reserving PCI slot 2 for IGD\n"); >>>>> + pci_bus->slot_reserved_mask |=3D XEN_PCI_IGD_SLOT_MASK; >>>>> +} >>>>> + >>>>> +static void xen_igd_clear_slot(DeviceState *qdev, Error **errp) >>>>> +{ >>>>> + ERRP_GUARD(); >>>>> + PCIDevice *pci_dev =3D (PCIDevice *)qdev; >>>>> + XenPCIPassthroughState *s =3D XEN_PT_DEVICE(pci_dev); >>>>> + XenPTDeviceClass *xpdc =3D XEN_PT_DEVICE_GET_CLASS(s); >>>>> + PCIBus *pci_bus =3D pci_get_bus(pci_dev); >>>>> + >>>>> + if (!(pci_bus->slot_reserved_mask & XEN_PCI_IGD_SLOT_MASK)) >>>>> + return; >>>>> + >>>>> + xen_host_pci_device_get(&s->real_device, >>>>> + s->hostaddr=2Edomain, s->hostaddr=2Ebus= , >>>>> + s->hostaddr=2Eslot, s->hostaddr=2Efunct= ion, >>>>> + errp); >>>>> + if (*errp) { >>>>> + error_append_hint(errp, "Failed to \"open\" the real pci de= vice"); >>>>> + return; >>>>> + } >>>>> + >>>>> + if (is_igd_vga_passthrough(&s->real_device) && >>>>> + s->real_device=2Edomain =3D=3D 0 && s->real_device=2Ebus = =3D=3D 0 && >>>>> + s->real_device=2Edev =3D=3D 2 && s->real_device=2Efunc =3D= =3D 0 && >>>>> + s->real_device=2Evendor_id =3D=3D PCI_VENDOR_ID_INTEL) { >>>>=20 >>>> how about macros for these? >>>>=20 >>>> #define XEN_PCI_IGD_DOMAIN 0 >>>> #define XEN_PCI_IGD_BUS 0 >>>> #define XEN_PCI_IGD_DEV 2 >>>> #define XEN_PCI_IGD_FN 0 >>>>=20 >>>>> + pci_bus->slot_reserved_mask &=3D ~XEN_PCI_IGD_SLOT_MASK; >>>>=20 >>>> If you are going to do this, you should set it back >>>> either after pci_qdev_realize or in unrealize, >>>> for symmetry=2E >>>>=20 >>>>> + XEN_PT_LOG(pci_dev, "Intel IGD found, using slot 2\n"); >>>>> + } >>>>=20 >>>>=20 >>>>> + xpdc->pci_qdev_realize(qdev, errp); >>>>> +} >>>>> + >>>>=20 >>>>=20 >>>>=20 >>>>> static void xen_pci_passthrough_class_init(ObjectClass *klass, void= *data) >>>>> { >>>>> DeviceClass *dc =3D DEVICE_CLASS(klass); >>>>> PCIDeviceClass *k =3D PCI_DEVICE_CLASS(klass); >>>>> =20 >>>>> + XenPTDeviceClass *xpdc =3D XEN_PT_DEVICE_CLASS(klass); >>>>> + xpdc->pci_qdev_realize =3D dc->realize; >>>>> + dc->realize =3D xen_igd_clear_slot; >>>>> k->realize =3D xen_pt_realize; >>>>> k->exit =3D xen_pt_unregister_device; >>>>> k->config_read =3D xen_pt_pci_read_config; >>>>> @@ -977,6 +1007,7 @@ static const TypeInfo xen_pci_passthrough_info = =3D { >>>>> =2Einstance_size =3D sizeof(XenPCIPassthroughState), >>>>> =2Einstance_finalize =3D xen_pci_passthrough_finalize, >>>>> =2Eclass_init =3D xen_pci_passthrough_class_init, >>>>> + =2Eclass_size =3D sizeof(XenPTDeviceClass), >>>>> =2Einstance_init =3D xen_pci_passthrough_instance_init, >>>>> =2Einterfaces =3D (InterfaceInfo[]) { >>>>> { INTERFACE_CONVENTIONAL_PCI_DEVICE }, >>>>> diff --git a/hw/xen/xen_pt=2Eh b/hw/xen/xen_pt=2Eh >>>>> index cf10fc7bbf=2E=2E8c25932b4b 100644 >>>>> --- a/hw/xen/xen_pt=2Eh >>>>> +++ b/hw/xen/xen_pt=2Eh >>>>> @@ -2,6 +2,7 @@ >>>>> #define XEN_PT_H >>>>> =20 >>>>> #include "hw/xen/xen_common=2Eh" >>>>> +#include "hw/pci/pci_bus=2Eh" >>>>> #include "xen-host-pci-device=2Eh" >>>>> #include "qom/object=2Eh" >>>>> =20 >>>>> @@ -40,7 +41,20 @@ typedef struct XenPTReg XenPTReg; >>>>> #define TYPE_XEN_PT_DEVICE "xen-pci-passthrough" >>>>> OBJECT_DECLARE_SIMPLE_TYPE(XenPCIPassthroughState, XEN_PT_DEVICE) >>>>> =20 >>>>> +#define XEN_PT_DEVICE_CLASS(klass) \ >>>>> + OBJECT_CLASS_CHECK(XenPTDeviceClass, klass, TYPE_XEN_PT_DEVICE) >>>>> +#define XEN_PT_DEVICE_GET_CLASS(obj) \ >>>>> + OBJECT_GET_CLASS(XenPTDeviceClass, obj, TYPE_XEN_PT_DEVICE) >>>>> + >>>>> +typedef void (*XenPTQdevRealize)(DeviceState *qdev, Error **errp); >>>>> + >>>>> +typedef struct XenPTDeviceClass { >>>>> + PCIDeviceClass parent_class; >>>>> + XenPTQdevRealize pci_qdev_realize; >>>>> +} XenPTDeviceClass; >>>>> + >>>>> uint32_t igd_read_opregion(XenPCIPassthroughState *s); >>>>> +void xen_igd_reserve_slot(PCIBus *pci_bus); >>>>> void igd_write_opregion(XenPCIPassthroughState *s, uint32_t val); >>>>> void xen_igd_passthrough_isa_bridge_create(XenPCIPassthroughState *= s, >>>>> XenHostPCIDevice *dev); >>>>> @@ -75,6 +89,8 @@ typedef int (*xen_pt_conf_byte_read) >>>>> =20 >>>>> #define XEN_PCI_INTEL_OPREGION 0xfc >>>>> =20 >>>>> +#define XEN_PCI_IGD_SLOT_MASK 0x4UL /* Intel IGD slot_reserved_mask= */ >>>>> + >>>>=20 >>>> I think you want to calculate this based on dev fn: >>>>=20 >>>> #define XEN_PCI_IGD_SLOT_MASK \ >>>> (0x1 << PCI_SLOT(PCI_DEVFN(XEN_PCI_IGD_DEV, XEN_PCI_IGD_FN))) >>>>=20 >>>>=20 >>>>> typedef enum { >>>>> XEN_PT_GRP_TYPE_HARDWIRED =3D 0, /* 0 Hardwired reg group */ >>>>> XEN_PT_GRP_TYPE_EMU, /* emul reg group */ >>>>> diff --git a/hw/xen/xen_pt_stub=2Ec b/hw/xen/xen_pt_stub=2Ec >>>>> index 2d8cac8d54=2E=2E5c108446a8 100644 >>>>> --- a/hw/xen/xen_pt_stub=2Ec >>>>> +++ b/hw/xen/xen_pt_stub=2Ec >>>>> @@ -20,3 +20,7 @@ void xen_igd_gfx_pt_set(bool value, Error **errp) >>>>> error_setg(errp, "Xen PCI passthrough support not built in"= ); >>>>> } >>>>> } >>>>> + >>>>> +void xen_igd_reserve_slot(PCIBus *pci_bus) >>>>> +{ >>>>> +} >>>>> --=20 >>>>> 2=2E39=2E0 >>>>=20 >>> > From xen-devel-bounces@lists.xenproject.org Thu Jan 12 23:04:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 23:04:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476429.738594 (Exim 4.92) (envelope-from ) id 1pG6c9-00058n-RY; Thu, 12 Jan 2023 23:04:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476429.738594; Thu, 12 Jan 2023 23:04:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG6c9-00058g-OX; Thu, 12 Jan 2023 23:04:05 +0000 Received: by outflank-mailman (input) for mailman id 476429; Thu, 12 Jan 2023 23:04:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG6c8-00058Y-TQ for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 23:04:05 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 675469a2-92cd-11ed-b8d0-410ff93cb8f0; Fri, 13 Jan 2023 00:04:02 +0100 (CET) Received: from mail-yw1-f199.google.com (mail-yw1-f199.google.com [209.85.128.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-582-wsG88cUzO5Oio2CBEv4omw-1; Thu, 12 Jan 2023 18:03:43 -0500 Received: by mail-yw1-f199.google.com with SMTP id 00721157ae682-4c57d19de6fso183191337b3.20 for ; Thu, 12 Jan 2023 15:03:43 -0800 (PST) Received: from redhat.com ([185.199.103.82]) by smtp.gmail.com with ESMTPSA id d7-20020a67c107000000b003cea834049dsm1901988vsj.29.2023.01.12.15.03.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jan 2023 15:03:41 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 675469a2-92cd-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673564641; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qXbpa0euBExBaTO/Ebm60JXaGA3mQo8UBGk1nDl0J48=; b=W8IkQLb1Bz7lPbZe1L7G4LAGXN4PHVZWYQQCOUxSEerNhm8RnOkupTn8T16msFbiHVCGNc xYbLlZGJDDzlNUBwwEM3W728ZtjT88lzeeN5sOtMv1UIb6Ao3qo7ZZz7RTFSqhvm7kNw5u wu3vV5spJkr5loqv+SxjNs1Dn8apfmw= X-MC-Unique: wsG88cUzO5Oio2CBEv4omw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qXbpa0euBExBaTO/Ebm60JXaGA3mQo8UBGk1nDl0J48=; b=6g+8o2XkqpMABxfuHRDWCd9OZriLXWb6pQKjP0qIiEwUzQ5J94oyq7gt4C5gD3qJAO bnR1uAS+jUgNCphQHjW0TuyAB1eEFn9OG1P75cUec0kdQd3P1IcxdgYYEgno9ri2Vsu/ ZQwfzkK1Nho319e+3KQ2bm8wrm3mF37zroKcdF50Z6Pmv3dUhgq6XUPU/gJwM4+z57xy ik7v7U5Mouzqi67KavUiEz24AUjdlFiE2T0MzDgNfbxeNkPIS0LpE6ug/16JO1W3KxFe zHWKMkEMqKa53B5Kicr/l1fGCUOK/LTfAx6Q59GZGZxt/fW07kIsroqZsKjUWPKWupvs WkJw== X-Gm-Message-State: AFqh2kqvUsI0r8E6W0vodpehb5FTX8qWp0xILhSgwR/u5/jxx1bSsP7f apEvw+KC3+QrWUz5+P+CcyJqvtwJ/tuowN2AEvU67eB+I7e/m8V6Wstr+HZK3rgqRQzPFyeaEzW GfY1FGiIKxEP0ikyhsFdZiRihi6Q= X-Received: by 2002:a25:3485:0:b0:7b2:2c34:7bfa with SMTP id b127-20020a253485000000b007b22c347bfamr30601131yba.13.1673564622821; Thu, 12 Jan 2023 15:03:42 -0800 (PST) X-Google-Smtp-Source: AMrXdXve5xvOCSmtbGUXXlUsTJO6xAn094jfDpk6/0I1/Sq4yrg4uvAhGWuFoy1TISz3ntSn2UKEsg== X-Received: by 2002:a25:3485:0:b0:7b2:2c34:7bfa with SMTP id b127-20020a253485000000b007b22c347bfamr30601107yba.13.1673564622570; Thu, 12 Jan 2023 15:03:42 -0800 (PST) Date: Thu, 12 Jan 2023 18:03:34 -0500 From: "Michael S. Tsirkin" To: Bernhard Beschow Cc: Chuck Zmudzinski , qemu-devel@nongnu.org, Stefano Stabellini , Anthony Perard , Paul Durrant , Paolo Bonzini , Richard Henderson , Eduardo Habkost , Marcel Apfelbaum , xen-devel@lists.xenproject.org, Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Subject: Re: [PATCH v8] xen/pt: reserve PCI slot 2 for Intel igd-passthru Message-ID: <20230112180314-mutt-send-email-mst@kernel.org> References: <20230110030331-mutt-send-email-mst@kernel.org> <9f63e7a6-e434-64b4-f082-7f5a0ab8d5bf@aol.com> <7208A064-2A25-4DBB-BF19-6797E96AB00C@gmail.com> MIME-Version: 1.0 In-Reply-To: <7208A064-2A25-4DBB-BF19-6797E96AB00C@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jan 12, 2023 at 10:55:25PM +0000, Bernhard Beschow wrote: > I think the change Michael suggests is very minimalistic: Move the if > condition around xen_igd_reserve_slot() into the function itself and > always call it there unconditionally -- basically turning three lines > into one. Since xen_igd_reserve_slot() seems very problem specific, > Michael further suggests to rename it to something more general. All > in all no big changes required. yes, exactly. -- MST From xen-devel-bounces@lists.xenproject.org Thu Jan 12 23:15:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 23:15:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476435.738606 (Exim 4.92) (envelope-from ) id 1pG6n4-0006qy-Sd; Thu, 12 Jan 2023 23:15:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476435.738606; Thu, 12 Jan 2023 23:15:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG6n4-0006qr-OZ; Thu, 12 Jan 2023 23:15:22 +0000 Received: by outflank-mailman (input) for mailman id 476435; Thu, 12 Jan 2023 23:15:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG6n3-0006qk-A5 for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 23:15:21 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG6n1-0006p9-HO; Thu, 12 Jan 2023 23:15:19 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pG6n1-0004vi-Bz; Thu, 12 Jan 2023 23:15:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=3Ea7sP/H+lnt603ST7qDMg96sbEvXpor6wScK3E8HfM=; b=0MJpSJ68kUriEXolQ0yKoLyDoL oSWjBY6EdErzGtI5Ik09NevLveiFlVN5vDMJq+luvxb7cFEHLTfqFsA0y8Mrl0iTFVzIwox8QxL9L cIgUb9pLIjVIDk0KOAIwAMsA9U4Io2809iykIeDZgjFM4Ug2W2W2J2e+xm6+y8WKZQbM=; Message-ID: Date: Thu, 12 Jan 2023 23:15:17 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 To: Jan Beulich Cc: Hongyan Xia , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org, Julien Grall References: <20221216114853.8227-1-julien@xen.org> <20221216114853.8227-6-julien@xen.org> <965e3faa-472d-9a79-83ca-fef57cda81c5@xen.org> From: Julien Grall Subject: Re: [PATCH 05/22] x86/srat: vmap the pages for acpi_slit In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 04/01/2023 10:23, Jan Beulich wrote: > On 23.12.2022 12:31, Julien Grall wrote: >> On 20/12/2022 15:30, Jan Beulich wrote: >>> On 16.12.2022 12:48, Julien Grall wrote: >>>> From: Hongyan Xia >>>> >>>> This avoids the assumption that boot pages are in the direct map. >>>> >>>> Signed-off-by: Hongyan Xia >>>> Signed-off-by: Julien Grall >>> >>> Reviewed-by: Jan Beulich >>> >>> However, ... >>> >>>> --- a/xen/arch/x86/srat.c >>>> +++ b/xen/arch/x86/srat.c >>>> @@ -139,7 +139,8 @@ void __init acpi_numa_slit_init(struct acpi_table_slit *slit) >>>> return; >>>> } >>>> mfn = alloc_boot_pages(PFN_UP(slit->header.length), 1); >>>> - acpi_slit = mfn_to_virt(mfn_x(mfn)); >>>> + acpi_slit = vmap_contig_pages(mfn, PFN_UP(slit->header.length)); >>> >>> ... with the increased use of vmap space the VA range used will need >>> growing. And that's perhaps better done ahead of time than late. >> >> I will have a look to increase the vmap(). >> >>> >>>> + BUG_ON(!acpi_slit); >>> >>> Similarly relevant for the earlier patch: It would be nice if boot >>> failure for optional things like NUMA data could be avoided. >> >> If you can't map (or allocate the memory), then you are probably in a >> very bad situation because both should really not fail at boot. >> >> So I think this is correct to crash early because the admin will be able >> to look what went wrong. Otherwise, it may be missed in the noise. > > Well, I certainly can see one taking this view. However, at least in > principle allocation (or mapping) may fail _because_ of NUMA issues. Right. I read this as the user will likely want to add "numa=off" on the command line. > At which point it would be better to boot with NUMA support turned off I have to disagree with "better" here. This may work for a user with a handful of hosts. But for large scale setup, you will really want a failure early rather than having a host booting with an expected feature disabled (the NUMA issues may be a broken HW). It is better to fail and then ask the user to specify "numa=off". At least the person made a conscientious decision to turn off the feature. I am curious to hear the opinion from the others. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Jan 12 23:20:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 Jan 2023 23:20:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476441.738616 (Exim 4.92) (envelope-from ) id 1pG6ri-0008HJ-Ca; Thu, 12 Jan 2023 23:20:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476441.738616; Thu, 12 Jan 2023 23:20:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG6ri-0008HC-A2; Thu, 12 Jan 2023 23:20:10 +0000 Received: by outflank-mailman (input) for mailman id 476441; Thu, 12 Jan 2023 23:20:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG6rg-0008H2-TD for xen-devel@lists.xenproject.org; Thu, 12 Jan 2023 23:20:08 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG6rf-00073n-C4; Thu, 12 Jan 2023 23:20:07 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pG6rf-000511-60; Thu, 12 Jan 2023 23:20:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=09NX0mt3JsdJrsXz9Xp/CqgrNkZN7cALRFZmr8cvHbU=; b=dfHLfXzVTw9Xc9AZB/pLAPih1T jgo9eg5gifsYxaE9aasLrYqObg/81s9If+MTJPC+C5+Y1b7fz954jwuP74wDNVHz4FjmyXBsR1BXf Qmkt7Vwx9kBaA7rsM11pWHsLbxoWWwwn6FKbmtDREXmvRF/2ZCty47QvKzCQ0hgt0ops=; Message-ID: Date: Thu, 12 Jan 2023 23:20:05 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 06/22] x86: map/unmap pages in restore_all_guests To: Jan Beulich Cc: Hongyan Xia , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Julien Grall , xen-devel@lists.xenproject.org References: <20221216114853.8227-1-julien@xen.org> <20221216114853.8227-7-julien@xen.org> <478e04bc-6ff7-de01-dfb9-55d579228152@suse.com> <01584e11-36ca-7836-85ad-bba9351af46e@suse.com> From: Julien Grall In-Reply-To: <01584e11-36ca-7836-85ad-bba9351af46e@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 04/01/2023 10:27, Jan Beulich wrote: > On 23.12.2022 13:22, Julien Grall wrote: >> Hi, >> >> On 22/12/2022 11:12, Jan Beulich wrote: >>> On 16.12.2022 12:48, Julien Grall wrote: >>>> --- a/xen/arch/x86/x86_64/entry.S >>>> +++ b/xen/arch/x86/x86_64/entry.S >>>> @@ -165,7 +165,24 @@ restore_all_guest: >>>> and %rsi, %rdi >>>> and %r9, %rsi >>>> add %rcx, %rdi >>>> - add %rcx, %rsi >>>> + >>>> + /* >>>> + * Without a direct map, we have to map first before copying. We only >>>> + * need to map the guest root table but not the per-CPU root_pgt, >>>> + * because the latter is still a xenheap page. >>>> + */ >>>> + pushq %r9 >>>> + pushq %rdx >>>> + pushq %rax >>>> + pushq %rdi >>>> + mov %rsi, %rdi >>>> + shr $PAGE_SHIFT, %rdi >>>> + callq map_domain_page >>>> + mov %rax, %rsi >>>> + popq %rdi >>>> + /* Stash the pointer for unmapping later. */ >>>> + pushq %rax >>>> + >>>> mov $ROOT_PAGETABLE_FIRST_XEN_SLOT, %ecx >>>> mov root_table_offset(SH_LINEAR_PT_VIRT_START)*8(%rsi), %r8 >>>> mov %r8, root_table_offset(SH_LINEAR_PT_VIRT_START)*8(%rdi) >>>> @@ -177,6 +194,14 @@ restore_all_guest: >>>> sub $(ROOT_PAGETABLE_FIRST_XEN_SLOT - \ >>>> ROOT_PAGETABLE_LAST_XEN_SLOT - 1) * 8, %rdi >>>> rep movsq >>>> + >>>> + /* Unmap the page. */ >>>> + popq %rdi >>>> + callq unmap_domain_page >>>> + popq %rax >>>> + popq %rdx >>>> + popq %r9 >>> >>> While the PUSH/POP are part of what I dislike here, I think this wants >>> doing differently: Establish a mapping when putting in place a new guest >>> page table, and use the pointer here. This could be a new per-domain >>> mapping, to limit its visibility. >> >> I have looked at a per-domain approach and this looks way more complex >> than the few concise lines here (not mentioning the extra amount of >> memory). > > Yes, I do understand that would be a more intrusive change. I could be persuaded to look at a more intrusive change if there are a good reason to do it. To me, at the moment, it mostly seem a matter of taste. So what would we gain from a perdomain mapping? > >> So I am not convinced this is worth the effort here. >> >> I don't have an other approach in mind. So are you disliking this >> approach to the point this will be nacked? > > I guess I wouldn't nack it, but I also wouldn't provide an ack. > I'm curious > what Andrew or Roger think here... Unfortunately Roger is on parental leaves for the next couple of months. It would be good to make some progress before hand. Andrew, what do you think? -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Jan 13 00:45:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 00:45:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476447.738628 (Exim 4.92) (envelope-from ) id 1pG8Bx-0000i4-9u; Fri, 13 Jan 2023 00:45:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476447.738628; Fri, 13 Jan 2023 00:45:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG8Bx-0000hx-6H; Fri, 13 Jan 2023 00:45:09 +0000 Received: by outflank-mailman (input) for mailman id 476447; Fri, 13 Jan 2023 00:45:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG8Bv-0000hn-7D; Fri, 13 Jan 2023 00:45:07 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG8Bv-00018w-47; Fri, 13 Jan 2023 00:45:07 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG8Bu-0001rK-LU; Fri, 13 Jan 2023 00:45:06 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pG8Bu-0005i5-L1; Fri, 13 Jan 2023 00:45:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Ylj5uHL3wfZLgCDl6litaVJEVZ5nRVoL6tsb8N63YQU=; b=6bBnj/VsFCFXEHSHoJlkM17+k8 unG5RsxRcqDvuaEQ8KuFpTZQNsa+aqhJmBemdG4d6O02fJxmCiEa6I7pNQIbXt9EtJOY6Qz+8+b3i of/y/F5vfzrLP+H9iZO4N3QCFCbjGOkDABeTO0cmiXiRc5DbPvyhPPf+bLpfMS4Lv9yM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 175743: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug qemu-mainline:test-amd64-i386-pair:xen-install/dst_host:fail:heisenbug qemu-mainline:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-i386-pair:xen-install/src_host:fail:heisenbug qemu-mainline:test-armhf-armhf-xl-rtds:xen-boot:fail:heisenbug qemu-mainline:test-armhf-armhf-xl-multivcpu:debian-install:fail:heisenbug qemu-mainline:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:heisenbug qemu-mainline:test-armhf-armhf-libvirt-raw:debian-di-install:fail:heisenbug qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=aa96ab7c9df59c615ca82b49c9062819e0a1c287 X-Osstest-Versions-That: qemuu=0ab12aa32462817f0a53fa6f6ce4baf664ef1713 From: osstest service owner Date: Fri, 13 Jan 2023 00:45:06 +0000 flight 175743 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/175743/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail in 175735 pass in 175743 test-amd64-i386-pair 11 xen-install/dst_host fail in 175735 pass in 175743 test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail in 175735 pass in 175743 test-amd64-i386-pair 10 xen-install/src_host fail pass in 175735 test-armhf-armhf-xl-rtds 8 xen-boot fail pass in 175735 test-armhf-armhf-xl-multivcpu 12 debian-install fail pass in 175735 test-armhf-armhf-libvirt-qcow2 12 debian-di-install fail pass in 175735 test-armhf-armhf-libvirt-raw 12 debian-di-install fail pass in 175735 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail in 175735 like 175623 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail in 175735 like 175623 test-armhf-armhf-xl-rtds 15 migrate-support-check fail in 175735 never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail in 175735 never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail in 175735 never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail in 175735 never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail in 175735 never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail in 175735 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 175623 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 175623 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175623 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175623 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175623 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175623 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu aa96ab7c9df59c615ca82b49c9062819e0a1c287 baseline version: qemuu 0ab12aa32462817f0a53fa6f6ce4baf664ef1713 Last test of basis 175623 2023-01-07 23:09:00 Z 5 days Failing since 175627 2023-01-08 14:40:14 Z 4 days 21 attempts Testing same since 175654 2023-01-09 18:08:58 Z 3 days 16 attempts ------------------------------------------------------------ People who touched revisions under test: Ard Biesheuvel Bernhard Beschow Christian Borntraeger Cindy Lu Dongli Zhang Eugenio Pérez Greg Kurz Guoyi Tu Hyman Huang(黄勇) Igor Mammedov Jason Wang Jonathan Cameron Kai Huang Laszlo Ersek Lei Xiang leixiang Liuxiangdong Longpeng Lubomir Rintel Marc-André Lureau Markus Armbruster Michael S. Tsirkin Nikita Ivanov Paolo Bonzini Peter Maydell Philippe Mathieu-Daudé Richard Henderson Thomas Huth Yanan Wang Yicong Yang Zeng Chi jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw fail test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 0ab12aa324..aa96ab7c9d aa96ab7c9df59c615ca82b49c9062819e0a1c287 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Fri Jan 13 00:48:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 00:48:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476456.738639 (Exim 4.92) (envelope-from ) id 1pG8F6-0001Sw-Vf; Fri, 13 Jan 2023 00:48:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476456.738639; Fri, 13 Jan 2023 00:48:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG8F6-0001Sp-RE; Fri, 13 Jan 2023 00:48:24 +0000 Received: by outflank-mailman (input) for mailman id 476456; Fri, 13 Jan 2023 00:48:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG8F5-0001Sj-R7 for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 00:48:23 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fa01f384-92db-11ed-b8d0-410ff93cb8f0; Fri, 13 Jan 2023 01:48:21 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0FB8B621EA; Fri, 13 Jan 2023 00:48:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 74801C433F0; Fri, 13 Jan 2023 00:48:19 +0000 (UTC) Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 62452C395D4; Fri, 13 Jan 2023 00:48:19 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fa01f384-92db-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673570899; bh=FU5yKit5p//SKeorja80X9Jb/gpyvO/lOFikrwDWQv4=; h=Subject:From:In-Reply-To:References:Date:To:Cc:From; b=FY5CGGvJ4n5TmKgXhzDzTXmr5RzlbCLO6snnSa02rVHLm1bmG0ruq6HbDlpch9vo0 Hz+km26bAq6gzSeAx2QrOvrYp9UnaLUX62WUBoUWmTFmXXidQcjHH5rIYT2sAwDCBR xEP2m4WiGtmcaY9VoH2/GH+74OUI6nC0GBY3YT3SexRfeA0H1wxrcXVvzY0wPwYUA7 Hl/w+6OPPrnRalGiSUitC9owv4Pdq2qdXzXAyGPgC8LJ1C58OVAnAmeBkXxNQgXvTJ /GtMByWvbUZ05liYY4Z2srBJZfD3/BIf80E37LHgvX4aG7XQyveOUOBWbIdwuJaYGh DA8E/DMq6FnHw== Subject: Re: [GIT PULL] xen: branch for v6.2-rc4 From: pr-tracker-bot@kernel.org In-Reply-To: <20230111122501.21815-1-jgross@suse.com> References: <20230111122501.21815-1-jgross@suse.com> X-PR-Tracked-List-Id: Xen developer discussion X-PR-Tracked-Message-Id: <20230111122501.21815-1-jgross@suse.com> X-PR-Tracked-Remote: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-6.2-rc4-tag X-PR-Tracked-Commit-Id: f57034cedeb6e00256313a2a6ee67f974d709b0b X-PR-Merge-Tree: torvalds/linux.git X-PR-Merge-Refname: refs/heads/master X-PR-Merge-Commit-Id: bad8c4a850eaf386df681d951e3afc06bf1c7cf8 Message-Id: <167357089939.28490.16784668804617629143.pr-tracker-bot@kernel.org> Date: Fri, 13 Jan 2023 00:48:19 +0000 To: Juergen Gross Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, sstabellini@kernel.org The pull request you sent on Wed, 11 Jan 2023 13:25:01 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-6.2-rc4-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/bad8c4a850eaf386df681d951e3afc06bf1c7cf8 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html From xen-devel-bounces@lists.xenproject.org Fri Jan 13 02:19:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 02:19:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476464.738650 (Exim 4.92) (envelope-from ) id 1pG9f5-0001cu-Ju; Fri, 13 Jan 2023 02:19:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476464.738650; Fri, 13 Jan 2023 02:19:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG9f5-0001cm-F3; Fri, 13 Jan 2023 02:19:19 +0000 Received: by outflank-mailman (input) for mailman id 476464; Fri, 13 Jan 2023 02:19:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG9f4-0001cc-9E; Fri, 13 Jan 2023 02:19:18 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG9f4-0002Zs-6I; Fri, 13 Jan 2023 02:19:18 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG9f3-0003uW-S8; Fri, 13 Jan 2023 02:19:17 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pG9f3-0004Nm-Rg; Fri, 13 Jan 2023 02:19:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=9G/KpU8ZPBrAx9W0B1V/z+p7xoWczZbnBtCAvEXuwZc=; b=YdG4T2JxmU2IMnin4Vcz+pk3EB 3+wjccst8ZgKhdPXyUWxjbLKXI75HtK5KlwQke0J2gjsszcXHbhSmXIfg513NxfBAuD28EnyFQsqz nZwWRGqH6nYxOigizAHBs5K/w3ptakLa9n1lg0xHod5mSiuGHZymkxEo4pqc1b7eLPis=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 175748: trouble: broken/pass X-Osstest-Failures: xen-unstable-smoke:test-armhf-armhf-xl::broken:regression xen-unstable-smoke:test-armhf-armhf-xl:host-install(5):broken:regression xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=3edca52ce736297d7fcf293860cd94ef62638052 X-Osstest-Versions-That: xen=6bec713f871f21c6254a5783c1e39867ea828256 From: osstest service owner Date: Fri, 13 Jan 2023 02:19:17 +0000 flight 175748 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/175748/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl broken test-armhf-armhf-xl 5 host-install(5) broken REGR. vs. 175746 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass version targeted for testing: xen 3edca52ce736297d7fcf293860cd94ef62638052 baseline version: xen 6bec713f871f21c6254a5783c1e39867ea828256 Last test of basis 175746 2023-01-12 16:03:41 Z 0 days Testing same since 175748 2023-01-12 20:01:56 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Julien Grall jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl broken test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-armhf-armhf-xl broken broken-step test-armhf-armhf-xl host-install(5) Not pushing. ------------------------------------------------------------ commit 3edca52ce736297d7fcf293860cd94ef62638052 Author: Andrew Cooper Date: Mon Jan 9 10:58:31 2023 +0000 x86/vmx: Support for CPUs without model-specific LBR Ice Lake (server at least) has both architectural LBR and model-specific LBR. Sapphire Rapids does not have model-specific LBR at all. I.e. On SPR and later, model_specific_lbr will always be NULL, so we must make changes to avoid reliably hitting the domain_crash(). The Arch LBR spec states that CPUs without model-specific LBR implement MSR_DBG_CTL.LBR by discarding writes and always returning 0. Do this for any CPU for which we lack model-specific LBR information. Adjust the now-stale comment, now that the Arch LBR spec has created a way to signal "no model specific LBR" to guests. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich Reviewed-by: Kevin Tian commit e94af0d58f86c3a914b9cbbf4d9ed3d43b974771 Author: Andrew Cooper Date: Mon Jan 9 11:42:22 2023 +0000 x86/vmx: Calculate model-specific LBRs once at start of day There is no point repeating this calculation at runtime, especially as it is in the fallback path of the WRSMR/RDMSR handlers. Move the infrastructure higher in vmx.c to avoid forward declarations, renaming last_branch_msr_get() to get_model_specific_lbr() to highlight that these are model-specific only. No practical change. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich Reviewed-by: Kevin Tian commit e6ee01ad24b6a1c3b922579964deebb119a90a48 Author: Andrew Cooper Date: Tue Jan 3 15:08:56 2023 +0000 xen/version: Drop compat/kernel.c kernel.c is mostly in an #ifndef COMPAT guard, because compat/kernel.c re-includes kernel.c to recompile xen_version() in a compat form. However, the xen_version hypercall is almost guest-ABI-agnostic; only XENVER_platform_parameters has a compat split. Handle this locally, and do away with the re-include entirely. Also drop the CHECK_TYPE()'s between types that are simply char-arrays in their native and compat form. In particular, this removed the final instances of obfuscation via the DO() macro. No functional change. Also saves 2k of of .text in the x86 build. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich commit 73f0696dc1d31a987563184ce1d01cbf5d12d6ab Author: Andrew Cooper Date: Tue Dec 20 15:51:07 2022 +0000 public/version: Change xen_feature_info to have a fixed size This is technically an ABI change, but Xen doesn't operate in any environment where "unsigned int" is different to uint32_t, so switch to the explicit form. This avoids the need to derive (identical) compat logic for handling the subop. Signed-off-by: Andrew Cooper Acked-by: Julien Grall (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Fri Jan 13 02:25:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 02:25:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476472.738661 (Exim 4.92) (envelope-from ) id 1pG9kz-00039S-94; Fri, 13 Jan 2023 02:25:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476472.738661; Fri, 13 Jan 2023 02:25:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG9kz-00039L-6K; Fri, 13 Jan 2023 02:25:25 +0000 Received: by outflank-mailman (input) for mailman id 476472; Fri, 13 Jan 2023 02:25:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG9kx-00039B-V9; Fri, 13 Jan 2023 02:25:23 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG9kx-0002hr-Oh; Fri, 13 Jan 2023 02:25:23 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pG9kx-000427-Ae; Fri, 13 Jan 2023 02:25:23 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pG9kx-0006y2-A9; Fri, 13 Jan 2023 02:25:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=bSGeAMgCbPZiIB84nhVLIQTCIrFZ99E+lv+woF4if0g=; b=vuFOjzl61HRyFSf4j0KFoYFqS3 Xst+DIlBJuiOZofEK5Gny5oMkU0spwX7M5jzs45teU6LdI75cn9uGyj19xWsViWdWtFg4NC96jORe TpIEfGtcm1SQbhAlyfYiAenSnWv0t/MbeVOMiZiwWZ+BWqRLVgjyV+b0tJlfl6YHxMAA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 175739: regressions - trouble: broken/fail/pass X-Osstest-Failures: xen-unstable:test-armhf-armhf-xl-multivcpu::broken:regression xen-unstable:test-armhf-armhf-xl-multivcpu:host-install(5):broken:regression xen-unstable:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression xen-unstable:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=83d9679db057d5736c7b5a56db06bb6bb66c3914 X-Osstest-Versions-That: xen=fd42170b152b19ff12121f3b63674e882c087849 From: osstest service owner Date: Fri, 13 Jan 2023 02:25:23 +0000 flight 175739 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/175739/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-multivcpu broken test-armhf-armhf-xl-multivcpu 5 host-install(5) broken REGR. vs. 175734 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 175734 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 175734 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 175734 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 175734 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175734 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175734 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 175734 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175734 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 175734 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 175734 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 175734 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 175734 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175734 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 175734 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen 83d9679db057d5736c7b5a56db06bb6bb66c3914 baseline version: xen fd42170b152b19ff12121f3b63674e882c087849 Last test of basis 175734 2023-01-12 01:53:30 Z 1 days Testing same since 175739 2023-01-12 09:38:44 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Oleksii Kurochko jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu broken test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-armhf-armhf-xl-multivcpu broken broken-step test-armhf-armhf-xl-multivcpu host-install(5) Not pushing. ------------------------------------------------------------ commit 83d9679db057d5736c7b5a56db06bb6bb66c3914 Author: Oleksii Kurochko Date: Tue Jan 10 17:17:56 2023 +0200 xen/riscv: introduce stack stuff The patch introduces and sets up a stack in order to go to C environment Signed-off-by: Oleksii Kurochko Reviewed-by: Alistair Francis Reviewed-by: Andrew Cooper (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Fri Jan 13 02:57:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 02:57:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476481.738671 (Exim 4.92) (envelope-from ) id 1pGAGJ-0006u6-Tl; Fri, 13 Jan 2023 02:57:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476481.738671; Fri, 13 Jan 2023 02:57:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGAGJ-0006tz-Qx; Fri, 13 Jan 2023 02:57:47 +0000 Received: by outflank-mailman (input) for mailman id 476481; Fri, 13 Jan 2023 02:57:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGAGI-0006tt-Gq for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 02:57:46 +0000 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0c470ef4-92ee-11ed-91b6-6bf2151ebd3b; Fri, 13 Jan 2023 03:57:44 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 0E4895C0126; Thu, 12 Jan 2023 21:57:42 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 12 Jan 2023 21:57:42 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 12 Jan 2023 21:57:40 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0c470ef4-92ee-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to; s=fm2; t=1673578662; x=1673665062; bh=rlS+RQUHqs IC3xC0I9xDTjyCMxue/C52cDH/kXBJLMA=; b=C+ElV/kndUUGybHtXj6FDOybbi 8tkS4VoLc7k2v08A4l6p9OeozmKpI6dqtnmYQNx3xdALBt0Q6aCa5aYXqLiNo1e+ mc8jq5mmRvDg/jJ3LiAG3G/3VK72sd1kjwl4nRALrQN7mo/hmKXkuzVdIIMPN8j4 AaB28hv+kvaAo66eHtAn8LKAMLchSlx9dkpewe/ySeX3Su8BVqIEoUKrriJZGNwS 3tZJHpgn4L2xICKg1koNqRMJBJWxtH31K0+xvr9k1zAnNaVH5+MNK1AKaEmB6B0r sz8R4GJU3ZXijqD9dNTxcuAO6ERBmPtD0+9S2Rj4NiHbOI3/ycOi3lweybhg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:message-id:mime-version :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1673578662; x= 1673665062; bh=rlS+RQUHqsIC3xC0I9xDTjyCMxue/C52cDH/kXBJLMA=; b=l tIjns746EPB75MWgq7jph9EOTuXM1Zp1v0RYKgtNcgV+hr8gjo3W3lzDexiyUZ48 ukO8fEyplAh2Hhf/EIcMQN0FUVAWn7kXrbyephnLZsoPC8Gyl/E1b9qoSKPxhxNF cVTYo4a4ETi0PBELGfJW09zKTxeB8MnLdgdthwE5eJkP7pwmEOYOyLr8/QcFzd53 mUVr+vvEFFh09pChiXR6C8KwqvJcr27KmlLcqVCb5UWeuZkIGwjhq105b0y7LQ6Q 7P0u3dBPJqbW4rG3tXQoU417up4XUGBHdT1tHaOkSavKBxsXQYK8WjDu8Dm8KIYT EpHCqh62p/1Od+CaO1AfA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrleejgdehgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfggtggusehgtderredttdejnecuhfhrohhmpeforghrvghkucfo rghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvhhish hisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpedttedtlefg leetfeejjefftefhjeffheeiheevvddvkedukefguedvudffleefieenucffohhmrghinh epkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehm rghilhhfrhhomhepmhgrrhhmrghrvghksehinhhvihhsihgslhgvthhhihhnghhslhgrsg drtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Fri, 13 Jan 2023 03:57:37 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: xen-devel , Juergen Gross Cc: regressions@lists.linux.dev Subject: S3 under Xen regression between 6.1.1 and 6.1.3 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5xaRNTg0gQ8/F2e0" Content-Disposition: inline --5xaRNTg0gQ8/F2e0 Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Fri, 13 Jan 2023 03:57:37 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: xen-devel , Juergen Gross Cc: regressions@lists.linux.dev Subject: S3 under Xen regression between 6.1.1 and 6.1.3 Hi, 6.1.3 as PV dom0 crashes when attempting to suspend. 6.1.1 works. The crash: [ 348.284004] PM: suspend entry (deep) [ 348.289532] Filesystems sync: 0.005 seconds [ 348.291545] Freezing user space processes ... (elapsed 0.000 seconds= ) done. [ 348.292457] OOM killer disabled. [ 348.292462] Freezing remaining freezable tasks ... (elapsed 0.104 se= conds) done. [ 348.396612] printk: Suspending console(s) (use no_console_suspend to= debug) [ 348.749228] PM: suspend devices took 0.352 seconds [ 348.769713] ACPI: EC: interrupt blocked [ 348.816077] BUG: kernel NULL pointer dereference, address: 000000000= 000001c [ 348.816080] #PF: supervisor read access in kernel mode [ 348.816081] #PF: error_code(0x0000) - not-present page [ 348.816083] PGD 0 P4D 0=20 [ 348.816086] Oops: 0000 [#1] PREEMPT SMP NOPTI [ 348.816089] CPU: 0 PID: 6764 Comm: systemd-sleep Not tainted 6.1.3-1= =2Efc32.qubes.x86_64 #1 [ 348.816092] Hardware name: Star Labs StarBook/StarBook, BIOS 8.01 07= /03/2022 [ 348.816093] RIP: e030:acpi_get_wakeup_address+0xc/0x20 [ 348.816100] Code: 44 00 00 48 8b 05 04 a3 82 02 c3 cc cc cc cc cc cc= cc cc cc cc cc cc cc cc cc cc cc cc cc 0f 1f 44 00 00 48 8b 05 fc 9d 82 02= <8b> 40 1c c3 cc cc cc cc 66 66 2e 0f 1f 84 00 00 00 00 00 90 0f 1f [ 348.816103] RSP: e02b:ffffc90042537d08 EFLAGS: 00010246 [ 348.816105] RAX: 0000000000000000 RBX: 0000000000000003 RCX: 20c49ba= 5e353f7cf [ 348.816106] RDX: 000000000000cd19 RSI: 000000000002ee9a RDI: 002a051= ed42d7694 [ 348.816108] RBP: 0000000000000003 R08: ffffc90042537ca0 R09: fffffff= f82c5e468 [ 348.816110] R10: 0000000000007ff0 R11: 0000000000000000 R12: 0000000= 000000000 [ 348.816111] R13: fffffffffffffff2 R14: ffff88812206e6c0 R15: ffff888= 12206e6e0 [ 348.816121] FS: 00007cb49b01eb80(0000) GS:ffff888189400000(0000) kn= lGS:0000000000000000 [ 348.816123] CS: e030 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 348.816124] CR2: 000000000000001c CR3: 000000012231a000 CR4: 0000000= 000050660 [ 348.816131] Call Trace: [ 348.816133] [ 348.816134] acpi_pm_prepare+0x1a/0x50 [ 348.816141] suspend_enter+0x94/0x360 [ 348.816146] suspend_devices_and_enter+0x198/0x2b0 [ 348.816150] enter_state+0x18d/0x1f5 [ 348.816155] pm_suspend.cold+0x20/0x6b [ 348.816159] state_store+0x27/0x60 [ 348.816163] kernfs_fop_write_iter+0x125/0x1c0 [ 348.816169] new_sync_write+0x105/0x190 [ 348.816176] vfs_write+0x211/0x2a0 [ 348.816180] ksys_write+0x67/0xe0 [ 348.816183] do_syscall_64+0x59/0x90 [ 348.816188] ? do_syscall_64+0x69/0x90 [ 348.816192] ? exc_page_fault+0x76/0x170 [ 348.816195] entry_SYSCALL_64_after_hwframe+0x63/0xcd [ 348.816200] RIP: 0033:0x7cb49c1412f7 [ 348.816203] Code: 0d 00 f7 d8 64 89 02 48 c7 c0 ff ff ff ff eb b7 0f= 1f 00 f3 0f 1e fa 64 8b 04 25 18 00 00 00 85 c0 75 10 b8 01 00 00 00 0f 05= <48> 3d 00 f0 ff ff 77 51 c3 48 83 ec 28 48 89 54 24 18 48 89 74 24 [ 348.816204] RSP: 002b:00007ffc125f63f8 EFLAGS: 00000246 ORIG_RAX: 00= 00000000000001 [ 348.816206] RAX: ffffffffffffffda RBX: 0000000000000004 RCX: 00007cb= 49c1412f7 [ 348.816208] RDX: 0000000000000004 RSI: 00007ffc125f64e0 RDI: 0000000= 000000004 [ 348.816209] RBP: 00007ffc125f64e0 R08: 00005c83d772bca0 R09: 0000000= 00000000d [ 348.816210] R10: 00005c83d7727eb0 R11: 0000000000000246 R12: 0000000= 000000004 [ 348.816211] R13: 00005c83d77272d0 R14: 0000000000000004 R15: 00007cb= 49c213700 [ 348.816213] [ 348.816214] Modules linked in: loop vfat fat snd_hda_codec_hdmi snd_= sof_pci_intel_tgl snd_sof_intel_hda_common soundwire_intel soundwire_generi= c_allocation soundwire_cadence snd_sof_intel_hda snd_sof_pci snd_sof_xtensa= _dsp snd_sof snd_sof_utils snd_soc_hdac_hda snd_hda_ext_core snd_soc_acpi_i= ntel_match snd_soc_acpi soundwire_bus snd_hda_codec_realtek snd_hda_codec_g= eneric ledtrig_audio snd_soc_core snd_compress ac97_bus snd_pcm_dmaengine s= nd_hda_intel snd_intel_dspcfg snd_intel_sdw_acpi iTCO_wdt intel_pmc_bxt ee1= 004 iTCO_vendor_support intel_rapl_msr snd_hda_codec snd_hda_core snd_hwdep= snd_seq snd_seq_device iwlwifi snd_pcm pcspkr joydev processor_thermal_dev= ice_pci_legacy processor_thermal_device snd_timer snd cfg80211 processor_th= ermal_rfim i2c_i801 processor_thermal_mbox i2c_smbus idma64 rfkill processo= r_thermal_rapl soundcore intel_rapl_common int340x_thermal_zone intel_soc_d= ts_iosf igen6_edac intel_hid intel_pmc_core intel_scu_pltdrv sparse_keymap = fuse xenfs ip_tables dm_thin_pool ic#2 Part1 [ 348.816259] dm_persistent_data dm_bio_prison dm_crypt i915 crct10di= f_pclmul crc32_pclmul crc32c_intel polyval_clmulni polyval_generic drm_budd= y nvme video wmi drm_display_helper nvme_core xhci_pci xhci_pci_renesas gha= sh_clmulni_intel hid_multitouch sha512_ssse3 serio_raw nvme_common cec xhci= _hcd ttm i2c_hid_acpi i2c_hid pinctrl_tigerlake xen_acpi_processor xen_priv= cmd xen_pciback xen_blkback xen_gntalloc xen_gntdev xen_evtchn uinput [ 348.816281] CR2: 000000000000001c [ 348.816283] ---[ end trace 0000000000000000 ]--- [ 348.867991] RIP: e030:acpi_get_wakeup_address+0xc/0x20 [ 348.867996] Code: 44 00 00 48 8b 05 04 a3 82 02 c3 cc cc cc cc cc cc= cc cc cc cc cc cc cc cc cc cc cc cc cc 0f 1f 44 00 00 48 8b 05 fc 9d 82 02= <8b> 40 1c c3 cc cc cc cc 66 66 2e 0f 1f 84 00 00 00 00 00 90 0f 1f [ 348.867998] RSP: e02b:ffffc90042537d08 EFLAGS: 00010246 [ 348.867999] RAX: 0000000000000000 RBX: 0000000000000003 RCX: 20c49ba= 5e353f7cf [ 348.868000] RDX: 000000000000cd19 RSI: 000000000002ee9a RDI: 002a051= ed42d7694 [ 348.868001] RBP: 0000000000000003 R08: ffffc90042537ca0 R09: fffffff= f82c5e468 [ 348.868001] R10: 0000000000007ff0 R11: 0000000000000000 R12: 0000000= 000000000 [ 348.868002] R13: fffffffffffffff2 R14: ffff88812206e6c0 R15: ffff888= 12206e6e0 [ 348.868008] FS: 00007cb49b01eb80(0000) GS:ffff888189400000(0000) kn= lGS:0000000000000000 [ 348.868009] CS: e030 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 348.868009] CR2: 000000000000001c CR3: 000000012231a000 CR4: 0000000= 000050660 [ 348.868014] Kernel panic - not syncing: Fatal exception [ 348.868031] Kernel Offset: disabled Looking at git log between those two versions, and the acpi_get_wakeup_address() function, I suspect it's this change (but I have _not_ tested it): commit b1898793777fe10a31c160bb8bc385d6eea640c6 Author: Juergen Gross Date: Wed Nov 23 12:45:23 2022 +0100 x86/boot: Skip realmode init code when running as Xen PV guest =20 [ Upstream commit f1e525009493cbd569e7c8dd7d58157855f8658d ] =20 When running as a Xen PV guest there is no need for setting up the realmode trampoline, as realmode isn't supported in this environment. =20 Trying to setup the trampoline has been proven to be problematic in some cases, especially when trying to debug early boot problems with Xen requiring to keep the EFI boot-services memory mapped (some firmware variants seem to claim basically all memory below 1Mb for boot services). =20 Introduce new x86_platform_ops operations for that purpose, which can be set to a NOP by the Xen PV specific kernel boot code. =20 [ bp: s/call_init_real_mode/do_init_real_mode/ ] =20 Fixes: 084ee1c641a0 ("x86, realmode: Relocator for realmode code") Suggested-by: H. Peter Anvin Signed-off-by: Juergen Gross Signed-off-by: Borislav Petkov Link: https://lore.kernel.org/r/20221123114523.3467-1-jgross@suse.com Signed-off-by: Sasha Levin # regzbot introduced v6.1.1..v6.1.3 --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --5xaRNTg0gQ8/F2e0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmPAyKIACgkQ24/THMrX 1yxjsQf/W72vRWCEJuBqXmvxNSIdKZyzkRUf51j+IiWDY8g3j4abHSBvgzVe4trM 6KKhKa6yk3ThfRKe/vnHLx3932/DIi43vJEmSSOb26/De4ncspyUPK7IHgZsKaRd hbUzf4b3XSNfaiQYVGABDScMf4+7715T2TfKtTPKMM1SYYMqY9Rgz1wszcnhsd02 TkSfdV1Hx6SvdrYdoNDjYuRhTp+u5gwcTl2G265NPqADE3IT62/GabkvSoPTfZ4w jdoYhdmeBJwrx6g0M/gaiGTBHKPRn+I5RsFqYem13Cx5Vhk1BLBaBulCTo2faxWk Rz+Yki0pER8kY09DKiibjifxxdDlQA== =i4hv -----END PGP SIGNATURE----- --5xaRNTg0gQ8/F2e0-- From xen-devel-bounces@lists.xenproject.org Fri Jan 13 04:14:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 04:14:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476489.738683 (Exim 4.92) (envelope-from ) id 1pGBSi-0006g2-Hp; Fri, 13 Jan 2023 04:14:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476489.738683; Fri, 13 Jan 2023 04:14:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGBSi-0006fv-DU; Fri, 13 Jan 2023 04:14:40 +0000 Received: by outflank-mailman (input) for mailman id 476489; Fri, 13 Jan 2023 04:14:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGBSg-0006fn-Ee for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 04:14:39 +0000 Received: from sonic305-19.consmr.mail.gq1.yahoo.com (sonic305-19.consmr.mail.gq1.yahoo.com [98.137.64.82]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c7fbf237-92f8-11ed-b8d0-410ff93cb8f0; Fri, 13 Jan 2023 05:14:34 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic305.consmr.mail.gq1.yahoo.com with HTTP; Fri, 13 Jan 2023 04:14:31 +0000 Received: by hermes--production-ne1-5648bd7666-x5zv9 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 90236039d2e62b2abb2e002068f6b7b4; Fri, 13 Jan 2023 04:14:28 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c7fbf237-92f8-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1673583271; bh=4hASBuEGunDT4zjWth2rvDl2Y4xCmYLJ9R5aycKiqec=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=tONNFQpBv6sDKV/ugSmglztfJJL0yYEkcO0dJcg4BFyP/xJY9NduoRr9Hn34HBoWNnbJbxJvJzsaT6waPYcUHbDFwd1ZqYfdcmQ6HuhbyE4g3Xm1iHjCIf6WzXznonLD6A9PGVBKs7eeYc+jNpRFAEeeqSIU/k6/2+2q/YsGs4RhTx8BPvanyUxqNehnaVvxLPPrlRe02kbt2hYGGB7R0a9+je1pij9eoX8PZoFZ+HkqocB0tB6zUmLq+xMyjHDOH8LxETQC0GSLUhnjYfP5hjbbyf4hqNUrc6zjsMHSSJUPnbVN16BOFi0MA58igCZAuxIe+WvoWscyxoAy1o/8Yw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1673583271; bh=Tv4gbSx1lQwSkmBRYj+8e9bM3qtZfTwV2DimFH6eZWy=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=UlFlx8AdCnY9gXRLo+jltAqKbwiOFsksnU2zXen6M1DCZ686j8CIDK8hck9ltidKZVXRkLIH4zGWTR4mYF92gq7HDcHKyFpJ80W52RZBv1LaXOUbGMdF3m0O5UfaXcsa9ZQL94s23cxFeyY6jCv+qViH2gFbhjuR7/ThJ03xm0iFvYM8BWqqAA8lOQrZvn6rKqekMGenaixoYQsJtctmguxtibHEnvP/kUf7xkermgFlWLR5sno3IFSDQibYgmdjXYxIFZ4yU0PcqiAzJhTV4p3f6+1arbzi7LUQJJ5l/PN6AqyeIaBsDUdmuTTR/LtiGG8yrgTaNt7J1R1OAolE3w== X-YMail-OSG: ttEldBMVM1nVeFTo_.eAWkkRTsqhuLa7Om2EKLB_l73WR5n3MGc_a9YbOHmGONy E3DkD0H0flRzYy.Sy60BO21eGNYMrQHhiEnxxx7jq8t5kWnX20Sa.WOYI4dzYitvZxqWFfN2tgVu ivgRIYummAvragH44oo5jFD.5BRQM4pbHrw.yJmMv_2dkCO_zUjVwwEwSQcBpRVbrCbsLRnaGJQx R6d3jnETZBF1n40M2oHkz7rZbr2IGLNyHUlWxGkTWGU4QccvzSQLzqqCCWQgEXavfuMUMnispzMP 63knsXk7zhPiFETn9RAHqLzpFpB93hQ.6vJQRwRaMTNjC8_J4SBbo5lHWXwflLidB.yaLT.FLuGg TOyCQO.LedKHqqDjsIVIH285OdngrmYwUm06RIwv2m9.KocCCJMlZzTunS_rniJ_A6yWRD7QkRcI 4XPxWY3wdIzUvEVXvJn6b7EJdBktenWWUBzjYtBkNFZkGrTTPdMsBH4Yds9csE0ZjAQy5MG3V.nN YYz4angnODQTV4aIQAVXKKsE0647PWOEwSZoUUUkgVz3e_QIEavRV2NTB62r9VDLcABa6EhPddrD jC11GJxHiLxuYkUqeqgYr8E9QI494gTd1iLPNl48NZ0TrQIIGzko_z.evZYCXZgbv0nv8JxnMKhX s0AFYuS5Q1U_xDAnCuinEBk9t2bNIEAjpg9t3FeJnEBGx6SCftNAS2jAaivTCYTs8aCMWu79QXeI sm8gfsKrxuD6dRXcmuWFI46B4qOUN_WZhe7KvUtFnN2R_rkfkDCdg4JKlYVvBDBvuKBd9PVUntUK EZeeGL77Wu7mm4pVg8BgaKlX88M2ONVCjIRO0i8I4qOVcmsQNMzWHB.B4P3a3N57krzpVLfNLi3n bVg_OX6B4yH0sAMj_sX2rr3ncAKOAYukSLaqpVuzYz0fTXovWfFbrmn7dHxXlCP5ge0cXk7_lbV9 ubU6GPYOGB8NhwOK27gusL7TmKBH2ijhefApbiQuh_T9833DcGRqTyIUG78UrYw9Y.k1AnZZ2n9Z LL299tV.os4jWgEpaPA8edPh2yyOaVIUWebUY2rUaKtVbTe6ki9Wtq8jTJ8Yz2gd9x40c8YqqshG B6dNeM3HQ6bKxd4tEpOthYSFtrvCb2gNknTtetkTkP_5CDjsajXDZO244f22TRrtOVSw3j2Zbm5F m53nFDGhay9HVeAY2N.kUobffp0hH4OYL2oyd7.t72JkOix73iW5Wd8CZT9dLLHk1hpxv0gD7vgE We8K_k7zNtkNAE3DhCXp4dySJXaVwlufbdQf4smHnbnVWDP2.b6rZg8Tibl.LJFqgalLKBkDSjEe mSi0ic5ugnz_P9VGPDkZkuha4OitXVDoXjLHykZe6RQccZswk17EilxjeYkkzM7g_X5c_GO1l9iw gZ4f6CbN8pstqhst94cnWmxp6zJvNdC_TzyRE_Zps71EZArFniuCxz0Y5p6nAP933AQT7CMti.7x mVFpH1j0Ug4BkW4j96vN48_6o9jSapVZ0TkTC4fKqSN62JuSrsRQwRpDk6aLVhymuIOWbgoU7v3q ZacOVwjoyfJKr7zbuFTmDNNzlII_IVQ.4DF5cLNCc.CI5uj6Z6ZylLNkBUCO1JaAQbtggJjJ7e2W Y1r.FeSK20kCmC3b7qhVeAJlpN43o.IJfwYr8eV_ZnT3mt6b.QdoB28_jxpnJbAfA4X3SQRp6qln kcOL_FaPXk5v2caniSZEVaJT4TmiHhE8MfEDR.fCAjIj6CK7flzKgctdU8KCV4kC7G5Y4X9IJcLT rIhM9XJUi4XKkC0xAldVbz3oNXeZekQgqLS1HjTX9JfaqDn1ZaCr9c1V_rA0UQlRstf8.Vc3GwDL CDb9wtYqmvEDJs9k4_6.yHlFoz.D0g54u3bddkhahRDhyefIGUjcVq8tQnb2nj6ewDJ.6diY2jvR UP74pcW28nUPp.VveXif76.s.ud56DUw1tv5jvI.75wGbTIGbx4QeX0RDiCd8R.HP1P6IFppe7GW sD1.hR7LMdRHxyw_DviAqJaJMSGPjMn079JtlpVhd3i6XjmF5WbZOpqTSF975TXHSeRldBnIacC1 0J0zl_d1weRGnWBOPOd_vGWLb8y0qRMneHURuhrHChlpapeFpL4dbnb6WR6suMFGvPPft09FLp6O LQ71q1lFRb5Rhd5Lrx1fb_NAxJ1rD.YO5Fm.jWvNxoIheGobmEqjIQwRPND.VF0_6M1TZoqgtgfw Jbm9Hbo7t2SHMDfH0jzV8Iw-- X-Sonic-MF: Message-ID: <128d8ee2-8ee9-0a76-10de-af4c1b364179@aol.com> Date: Thu, 12 Jan 2023 23:14:26 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v8] xen/pt: reserve PCI slot 2 for Intel igd-passthru Content-Language: en-US To: "Michael S. Tsirkin" , Bernhard Beschow Cc: qemu-devel@nongnu.org, Stefano Stabellini , Anthony Perard , Paul Durrant , Paolo Bonzini , Richard Henderson , Eduardo Habkost , Marcel Apfelbaum , xen-devel@lists.xenproject.org, =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= References: <20230110030331-mutt-send-email-mst@kernel.org> <9f63e7a6-e434-64b4-f082-7f5a0ab8d5bf@aol.com> <7208A064-2A25-4DBB-BF19-6797E96AB00C@gmail.com> <20230112180314-mutt-send-email-mst@kernel.org> From: Chuck Zmudzinski In-Reply-To: <20230112180314-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.21062 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 605 On 1/12/23 6:03 PM, Michael S. Tsirkin wrote: > On Thu, Jan 12, 2023 at 10:55:25PM +0000, Bernhard Beschow wrote: >> I think the change Michael suggests is very minimalistic: Move the if >> condition around xen_igd_reserve_slot() into the function itself and >> always call it there unconditionally -- basically turning three lines >> into one. Since xen_igd_reserve_slot() seems very problem specific, >> Michael further suggests to rename it to something more general. All >> in all no big changes required. > > yes, exactly. > OK, got it. I can do that along with the other suggestions. Thanks. From xen-devel-bounces@lists.xenproject.org Fri Jan 13 05:29:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 05:29:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476496.738705 (Exim 4.92) (envelope-from ) id 1pGCdQ-00067l-7H; Fri, 13 Jan 2023 05:29:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476496.738705; Fri, 13 Jan 2023 05:29:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCdQ-00067e-4F; Fri, 13 Jan 2023 05:29:48 +0000 Received: by outflank-mailman (input) for mailman id 476496; Fri, 13 Jan 2023 05:29:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCdP-0005sP-37 for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 05:29:47 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 494582fe-9303-11ed-b8d0-410ff93cb8f0; Fri, 13 Jan 2023 06:29:44 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0128613D5; Thu, 12 Jan 2023 21:30:26 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 791993F587; Thu, 12 Jan 2023 21:29:41 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 494582fe-9303-11ed-b8d0-410ff93cb8f0 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Julien Grall Subject: [PATCH v2 01/40] xen/arm: remove xen_phys_start and xenheap_phys_end from config.h Date: Fri, 13 Jan 2023 13:28:34 +0800 Message-Id: <20230113052914.3845596-2-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230113052914.3845596-1-Penny.Zheng@arm.com> References: <20230113052914.3845596-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Wei Chen These two variables are stale variables, they only have declarations in config.h, they don't have any definition and no any code is using these two variables. So in this patch, we remove them from config.h. Signed-off-by: Wei Chen Acked-by: Julien Grall --- v1 -> v2: 1. Add Ab. --- xen/arch/arm/include/asm/config.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/xen/arch/arm/include/asm/config.h b/xen/arch/arm/include/asm/config.h index 0fefed1b8a..25a625ff08 100644 --- a/xen/arch/arm/include/asm/config.h +++ b/xen/arch/arm/include/asm/config.h @@ -172,8 +172,6 @@ #define STACK_SIZE (PAGE_SIZE << STACK_ORDER) #ifndef __ASSEMBLY__ -extern unsigned long xen_phys_start; -extern unsigned long xenheap_phys_end; extern unsigned long frametable_virt_end; #endif -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 13 05:29:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 05:29:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476495.738693 (Exim 4.92) (envelope-from ) id 1pGCdO-0005sX-Qf; Fri, 13 Jan 2023 05:29:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476495.738693; Fri, 13 Jan 2023 05:29:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCdO-0005sQ-O2; Fri, 13 Jan 2023 05:29:46 +0000 Received: by outflank-mailman (input) for mailman id 476495; Fri, 13 Jan 2023 05:29:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCdM-0005sJ-Vj for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 05:29:45 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 47aff3bf-9303-11ed-91b6-6bf2151ebd3b; Fri, 13 Jan 2023 06:29:42 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 21D57FEC; Thu, 12 Jan 2023 21:30:23 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 570693F587; Thu, 12 Jan 2023 21:29:37 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 47aff3bf-9303-11ed-91b6-6bf2151ebd3b From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v2 00/41] xen/arm: Add Armv8-R64 MPU support to Xen - Part#1 Date: Fri, 13 Jan 2023 13:28:33 +0800 Message-Id: <20230113052914.3845596-1-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The Armv8-R architecture profile was designed to support use cases that have a high sensitivity to deterministic execution. (e.g. Fuel Injection, Brake control, Drive trains, Motor control etc) Arm announced Armv8-R in 2013, it is the latest generation Arm architecture targeted at the Real-time profile. It introduces virtualization at the highest security level while retaining the Protected Memory System Architecture (PMSA) based on a Memory Protection Unit (MPU). In 2020, Arm announced Cortex-R82, which is the first Arm 64-bit Cortex-R processor based on Armv8-R64. The latest Armv8-R64 document can be found [1]. And the features of Armv8-R64 architecture: - An exception model that is compatible with the Armv8-A model - Virtualization with support for guest operating systems - PMSA virtualization using MPUs In EL2. - Adds support for the 64-bit A64 instruction set. - Supports up to 48-bit physical addressing. - Supports three Exception Levels (ELs) - Secure EL2 - The Highest Privilege - Secure EL1 - RichOS (MMU) or RTOS (MPU) - Secure EL0 - Application Workloads - Supports only a single Security state - Secure. - MPU in EL1 & EL2 is configurable, MMU in EL1 is configurable. These patch series are implementing the Armv8-R64 MPU support for Xen, which are based on the discussion of "Proposal for Porting Xen to Armv8-R64 - DraftC" [2]. We will implement the Armv8-R64 and MPU support in three stages: 1. Boot Xen itself to idle thread, do not create any guests on it. 2. Support to boot MPU and MMU domains on Armv8-R64 Xen. 3. SMP and other advanced features of Xen support on Armv8-R64. As we have not implemented guest support in part#1 series of MPU support, Xen can not create any guest in boot time. So in this patch serie, we provide an extra DNM-commit in the last for users to test Xen boot to idle on MPU system. We will split these patches to several parts, this series is the part#1, v1 is in [3], the full PoC can be found in [4]. More software for Armv8-R64 can be found in [5]; [1] https://developer.arm.com/documentation/ddi0600/latest [2] https://lists.xenproject.org/archives/html/xen-devel/2022-05/msg00643.html [3] https://lists.xenproject.org/archives/html/xen-devel/2022-11/msg00289.html [4] https://gitlab.com/xen-project/people/weic/xen/-/tree/integration/mpu_v2 [5] https://armv8r64-refstack.docs.arm.com/en/v5.0/ Penny Zheng (28): xen/mpu: build up start-of-day Xen MPU memory region map xen/mpu: introduce helpers for MPU enablement xen/mpu: introduce unified function setup_early_uart to map early UART xen/arm64: head: Jump to the runtime mapping in enable_mm() xen/arm: introduce setup_mm_mappings xen/mpu: plump virt/maddr/mfn convertion in MPU system xen/mpu: introduce helper access_protection_region xen/mpu: populate a new region in Xen MPU mapping table xen/mpu: plump early_fdt_map in MPU systems xen/arm: move MMU-specific setup_mm to setup_mmu.c xen/mpu: implement MPU version of setup_mm in setup_mpu.c xen/mpu: initialize frametable in MPU system xen/mpu: introduce "mpu,xxx-memory-section" xen/mpu: map MPU guest memory section before static memory initialization xen/mpu: destroy an existing entry in Xen MPU memory mapping table xen/mpu: map device memory resource in MPU system xen/mpu: map boot module section in MPU system xen/mpu: introduce mpu_memory_section_contains for address range check xen/mpu: disable VMAP sub-system for MPU systems xen/mpu: disable FIXMAP in MPU system xen/mpu: implement MPU version of ioremap_xxx xen/mpu: free init memory in MPU system xen/mpu: destroy boot modules and early FDT mapping in MPU system xen/mpu: Use secure hypervisor timer for AArch64v8R xen/mpu: move MMU specific P2M code to p2m_mmu.c xen/mpu: implement setup_virt_paging for MPU system xen/mpu: re-order xen_mpumap in arch_init_finialize xen/mpu: add Kconfig option to enable Armv8-R AArch64 support Wei Chen (13): xen/arm: remove xen_phys_start and xenheap_phys_end from config.h xen/arm: make ARM_EFI selectable for Arm64 xen/arm: adjust Xen TLB helpers for Armv8-R64 PMSA xen/arm: add an option to define Xen start address for Armv8-R xen/arm64: prepare for moving MMU related code from head.S xen/arm64: move MMU related code from head.S to head_mmu.S xen/arm64: add .text.idmap for Xen identity map sections xen/arm: use PA == VA for EARLY_UART_VIRTUAL_ADDRESS on Armv-8R xen/arm: decouple copy_from_paddr with FIXMAP xen/arm: split MMU and MPU config files from config.h xen/arm: move MMU-specific memory management code to mm_mmu.c/mm_mmu.h xen/arm: check mapping status and attributes for MPU copy_from_paddr xen/mpu: make Xen boot to idle on MPU systems(DNM) xen/arch/arm/Kconfig | 44 +- xen/arch/arm/Makefile | 17 +- xen/arch/arm/arm64/Makefile | 5 + xen/arch/arm/arm64/head.S | 466 +---- xen/arch/arm/arm64/head_mmu.S | 399 ++++ xen/arch/arm/arm64/head_mpu.S | 394 ++++ xen/arch/arm/bootfdt.c | 13 +- xen/arch/arm/domain_build.c | 4 + xen/arch/arm/include/asm/alternative.h | 15 + xen/arch/arm/include/asm/arm64/flushtlb.h | 25 + xen/arch/arm/include/asm/arm64/macros.h | 51 + xen/arch/arm/include/asm/arm64/mpu.h | 174 ++ xen/arch/arm/include/asm/arm64/sysregs.h | 77 + xen/arch/arm/include/asm/config.h | 105 +- xen/arch/arm/include/asm/config_mmu.h | 112 + xen/arch/arm/include/asm/config_mpu.h | 25 + xen/arch/arm/include/asm/cpregs.h | 4 +- xen/arch/arm/include/asm/cpuerrata.h | 12 + xen/arch/arm/include/asm/cpufeature.h | 7 + xen/arch/arm/include/asm/early_printk.h | 13 + xen/arch/arm/include/asm/fixmap.h | 28 +- xen/arch/arm/include/asm/flushtlb.h | 22 + xen/arch/arm/include/asm/mm.h | 78 +- xen/arch/arm/include/asm/mm_mmu.h | 77 + xen/arch/arm/include/asm/mm_mpu.h | 54 + xen/arch/arm/include/asm/p2m.h | 27 +- xen/arch/arm/include/asm/p2m_mmu.h | 28 + xen/arch/arm/include/asm/processor.h | 13 + xen/arch/arm/include/asm/setup.h | 39 + xen/arch/arm/kernel.c | 31 +- xen/arch/arm/mm.c | 1340 +----------- xen/arch/arm/mm_mmu.c | 1376 +++++++++++++ xen/arch/arm/mm_mpu.c | 1056 ++++++++++ xen/arch/arm/p2m.c | 2282 +-------------------- xen/arch/arm/p2m_mmu.c | 2257 ++++++++++++++++++++ xen/arch/arm/p2m_mpu.c | 274 +++ xen/arch/arm/platforms/Kconfig | 16 +- xen/arch/arm/setup.c | 394 +--- xen/arch/arm/setup_mmu.c | 391 ++++ xen/arch/arm/setup_mpu.c | 208 ++ xen/arch/arm/time.c | 14 +- xen/arch/arm/traps.c | 2 + xen/arch/arm/xen.lds.S | 10 +- xen/arch/x86/Kconfig | 1 + xen/common/Kconfig | 6 + xen/common/Makefile | 2 +- xen/include/xen/vmap.h | 93 +- 47 files changed, 7500 insertions(+), 4581 deletions(-) create mode 100644 xen/arch/arm/arm64/head_mmu.S create mode 100644 xen/arch/arm/arm64/head_mpu.S create mode 100644 xen/arch/arm/include/asm/arm64/mpu.h create mode 100644 xen/arch/arm/include/asm/config_mmu.h create mode 100644 xen/arch/arm/include/asm/config_mpu.h create mode 100644 xen/arch/arm/include/asm/mm_mmu.h create mode 100644 xen/arch/arm/include/asm/mm_mpu.h create mode 100644 xen/arch/arm/include/asm/p2m_mmu.h create mode 100644 xen/arch/arm/mm_mmu.c create mode 100644 xen/arch/arm/mm_mpu.c create mode 100644 xen/arch/arm/p2m_mmu.c create mode 100644 xen/arch/arm/p2m_mpu.c create mode 100644 xen/arch/arm/setup_mmu.c create mode 100644 xen/arch/arm/setup_mpu.c -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 13 05:29:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 05:29:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476497.738716 (Exim 4.92) (envelope-from ) id 1pGCdS-0006NI-ES; Fri, 13 Jan 2023 05:29:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476497.738716; Fri, 13 Jan 2023 05:29:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCdS-0006N9-Ar; Fri, 13 Jan 2023 05:29:50 +0000 Received: by outflank-mailman (input) for mailman id 476497; Fri, 13 Jan 2023 05:29:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCdR-0005sP-38 for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 05:29:49 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 4ac93ded-9303-11ed-b8d0-410ff93cb8f0; Fri, 13 Jan 2023 06:29:47 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 90E26FEC; Thu, 12 Jan 2023 21:30:28 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 5D0063F587; Thu, 12 Jan 2023 21:29:44 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4ac93ded-9303-11ed-b8d0-410ff93cb8f0 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v2 02/40] xen/arm: make ARM_EFI selectable for Arm64 Date: Fri, 13 Jan 2023 13:28:35 +0800 Message-Id: <20230113052914.3845596-3-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230113052914.3845596-1-Penny.Zheng@arm.com> References: <20230113052914.3845596-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Wei Chen Currently, ARM_EFI will mandatorily selected by Arm64. Even if the user knows for sure that their images will not start in the EFI environment, they can't disable the EFI support for Arm64. This means there will be about 3K lines unused code in their images. So in this patch, we make ARM_EFI selectable for Arm64, and based on that, we can use CONFIG_ARM_EFI to gate the EFI specific code in head.S for those images that will not be booted in EFI environment. Signed-off-by: Wei Chen --- v1 -> v2: 1. New patch --- xen/arch/arm/Kconfig | 10 ++++++++-- xen/arch/arm/arm64/head.S | 15 +++++++++++++-- 2 files changed, 21 insertions(+), 4 deletions(-) diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index 239d3aed3c..ace7178c9a 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -7,7 +7,6 @@ config ARM_64 def_bool y depends on !ARM_32 select 64BIT - select ARM_EFI select HAS_FAST_MULTIPLY config ARM @@ -37,7 +36,14 @@ config ACPI an alternative to device tree on ARM64. config ARM_EFI - bool + bool "UEFI boot service support" + depends on ARM_64 + default y + help + This option provides support for boot services through + UEFI firmware. A UEFI stub is provided to allow Xen to + be booted as an EFI application. This is only useful for + Xen that may run on systems that have UEFI firmware. config GICV3 bool "GICv3 driver" diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S index ad014716db..93f9b0b9d5 100644 --- a/xen/arch/arm/arm64/head.S +++ b/xen/arch/arm/arm64/head.S @@ -22,8 +22,11 @@ #include #include + +#ifdef CONFIG_ARM_EFI #include #include +#endif #define PT_PT 0xf7f /* nG=1 AF=1 SH=11 AP=01 NS=1 ATTR=111 T=1 P=1 */ #define PT_MEM 0xf7d /* nG=1 AF=1 SH=11 AP=01 NS=1 ATTR=111 T=0 P=1 */ @@ -172,8 +175,10 @@ efi_head: .byte 0x52 .byte 0x4d .byte 0x64 - .long pe_header - efi_head /* Offset to the PE header. */ - +#ifndef CONFIG_ARM_EFI + .long 0 /* 0 means no PE header. */ +#else + .long pe_header - efi_head /* Offset to the PE header. */ /* * Add the PE/COFF header to the file. The address of this header * is at offset 0x3c in the file, and is part of Linux "Image" @@ -279,6 +284,8 @@ section_table: .short 0 /* NumberOfLineNumbers (0 for executables) */ .long 0xe0500020 /* Characteristics (section flags) */ .align 5 +#endif /* CONFIG_ARM_EFI */ + real_start: /* BSS should be zeroed when booting without EFI */ mov x26, #0 /* x26 := skip_zero_bss */ @@ -913,6 +920,8 @@ putn: ret ENTRY(lookup_processor_type) mov x0, #0 ret + +#ifdef CONFIG_ARM_EFI /* * Function to transition from EFI loader in C, to Xen entry point. * void noreturn efi_xen_start(void *fdt_ptr, uint32_t fdt_size); @@ -971,6 +980,8 @@ ENTRY(efi_xen_start) b real_start_efi ENDPROC(efi_xen_start) +#endif /* CONFIG_ARM_EFI */ + /* * Local variables: * mode: ASM -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 13 05:29:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 05:29:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476498.738727 (Exim 4.92) (envelope-from ) id 1pGCdV-0006fl-Nn; Fri, 13 Jan 2023 05:29:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476498.738727; Fri, 13 Jan 2023 05:29:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCdV-0006fc-J4; Fri, 13 Jan 2023 05:29:53 +0000 Received: by outflank-mailman (input) for mailman id 476498; Fri, 13 Jan 2023 05:29:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCdT-0005sP-Sg for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 05:29:51 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 4c66a87e-9303-11ed-b8d0-410ff93cb8f0; Fri, 13 Jan 2023 06:29:49 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2C4AD13D5; Thu, 12 Jan 2023 21:30:31 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id EC0E93F587; Thu, 12 Jan 2023 21:29:46 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4c66a87e-9303-11ed-b8d0-410ff93cb8f0 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v2 03/40] xen/arm: adjust Xen TLB helpers for Armv8-R64 PMSA Date: Fri, 13 Jan 2023 13:28:36 +0800 Message-Id: <20230113052914.3845596-4-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230113052914.3845596-1-Penny.Zheng@arm.com> References: <20230113052914.3845596-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Wei Chen >From Arm ARM Supplement of Armv8-R AArch64 (DDI 0600A) [1], section D1.6.2 TLB maintenance instructions, we know that Armv8-R AArch64 permits an implementation to cache stage 1 VMSAv8-64 and stage 2 PMSAv8-64 attributes as a common entry for the Secure EL1&0 translation regime. But for Xen itself, it's running with stage 1 PMSAv8-64 on Armv8-R AArch64. The EL2 MPU updates for stage 1 PMSAv8-64 will not be cached in TLB entries. So we don't need any TLB invalidation for Xen itself in EL2. So in this patch, we use empty macros to stub Xen TLB helpers for MPU system (PMSA), but still keep the Guest TLB helpers. Because when a guest running in EL1 with VMSAv8-64 (MMU), guest TLB invalidation is still needed. But we need some policy to distinguish MPU and MMU guest, this will be done in guest support of Armv8-R AArch64 later. [1] https://developer.arm.com/documentation/ddi0600/ac Signed-off-by: Wei Chen --- v1 -> v2: 1. No change. --- xen/arch/arm/include/asm/arm64/flushtlb.h | 25 +++++++++++++++++++++++ xen/arch/arm/include/asm/flushtlb.h | 22 ++++++++++++++++++++ 2 files changed, 47 insertions(+) diff --git a/xen/arch/arm/include/asm/arm64/flushtlb.h b/xen/arch/arm/include/asm/arm64/flushtlb.h index 7c54315187..fe445f6831 100644 --- a/xen/arch/arm/include/asm/arm64/flushtlb.h +++ b/xen/arch/arm/include/asm/arm64/flushtlb.h @@ -51,6 +51,8 @@ TLB_HELPER(flush_all_guests_tlb_local, alle1); /* Flush innershareable TLBs, all VMIDs, non-hypervisor mode */ TLB_HELPER(flush_all_guests_tlb, alle1is); +#ifndef CONFIG_HAS_MPU + /* Flush all hypervisor mappings from the TLB of the local processor. */ TLB_HELPER(flush_xen_tlb_local, alle2); @@ -66,6 +68,29 @@ static inline void __flush_xen_tlb_one(vaddr_t va) asm volatile("tlbi vae2is, %0;" : : "r" (va>>PAGE_SHIFT) : "memory"); } +#else + +/* + * When Xen is running with stage 1 PMSAv8-64 on MPU systems. The EL2 MPU + * updates for stage1 PMSAv8-64 will not be cached in TLB entries. So we + * don't need any TLB invalidation for Xen itself in EL2. See Arm ARM + * Supplement of Armv8-R AArch64 (DDI 0600A), section D1.6.2 TLB maintenance + * instructions for more details. + */ +static inline void flush_xen_tlb_local(void) +{ +} + +static inline void __flush_xen_tlb_one_local(vaddr_t va) +{ +} + +static inline void __flush_xen_tlb_one(vaddr_t va) +{ +} + +#endif /* CONFIG_HAS_MPU */ + #endif /* __ASM_ARM_ARM64_FLUSHTLB_H__ */ /* * Local variables: diff --git a/xen/arch/arm/include/asm/flushtlb.h b/xen/arch/arm/include/asm/flushtlb.h index 125a141975..4b8bf65281 100644 --- a/xen/arch/arm/include/asm/flushtlb.h +++ b/xen/arch/arm/include/asm/flushtlb.h @@ -28,6 +28,7 @@ static inline void page_set_tlbflush_timestamp(struct page_info *page) /* Flush specified CPUs' TLBs */ void arch_flush_tlb_mask(const cpumask_t *mask); +#ifndef CONFIG_HAS_MPU /* * Flush a range of VA's hypervisor mappings from the TLB of the local * processor. @@ -66,6 +67,27 @@ static inline void flush_xen_tlb_range_va(vaddr_t va, isb(); } +#else + +/* + * When Xen is running with stage 1 PMSAv8-64 on MPU systems. The EL2 MPU + * updates for stage1 PMSAv8-64 will not be cached in TLB entries. So we + * don't need any TLB invalidation for Xen itself in EL2. See Arm ARM + * Supplement of Armv8-R AArch64 (DDI 0600A), section D1.6.2 TLB maintenance + * instructions for more details. + */ +static inline void flush_xen_tlb_range_va_local(vaddr_t va, + unsigned long size) +{ +} + +static inline void flush_xen_tlb_range_va(vaddr_t va, + unsigned long size) +{ +} + +#endif /* CONFIG_HAS_MPU */ + #endif /* __ASM_ARM_FLUSHTLB_H__ */ /* * Local variables: -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 13 05:29:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 05:29:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476499.738738 (Exim 4.92) (envelope-from ) id 1pGCdZ-0006zY-1g; Fri, 13 Jan 2023 05:29:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476499.738738; Fri, 13 Jan 2023 05:29:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCdY-0006zP-Sq; Fri, 13 Jan 2023 05:29:56 +0000 Received: by outflank-mailman (input) for mailman id 476499; Fri, 13 Jan 2023 05:29:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCdW-0005sP-M0 for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 05:29:54 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 4e16b03c-9303-11ed-b8d0-410ff93cb8f0; Fri, 13 Jan 2023 06:29:52 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 07767FEC; Thu, 12 Jan 2023 21:30:34 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 884413F587; Thu, 12 Jan 2023 21:29:49 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4e16b03c-9303-11ed-b8d0-410ff93cb8f0 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , "Jiamei . Xie" Subject: [PATCH v2 04/40] xen/arm: add an option to define Xen start address for Armv8-R Date: Fri, 13 Jan 2023 13:28:37 +0800 Message-Id: <20230113052914.3845596-5-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230113052914.3845596-1-Penny.Zheng@arm.com> References: <20230113052914.3845596-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Wei Chen On Armv8-A, Xen has a fixed virtual start address (link address too) for all Armv8-A platforms. In an MMU based system, Xen can map its loaded address to this virtual start address. So, on Armv8-A platforms, the Xen start address does not need to be configurable. But on Armv8-R platforms, there is no MMU to map loaded address to a fixed virtual address and different platforms will have very different address space layout. So Xen cannot use a fixed physical address on MPU based system and need to have it configurable. In this patch we introduce one Kconfig option for users to define the default Xen start address for Armv8-R. Users can enter the address in config time, or select the tailored platform config file from arch/arm/configs. And as we introduced Armv8-R platforms to Xen, that means the existed Arm64 platforms should not be listed in Armv8-R platform list, so we add !ARM_V8R dependency for these platforms. Signed-off-by: Wei Chen Signed-off-by: Jiamei.Xie --- v1 -> v2: 1. Remove the platform header fvp_baser.h. 2. Remove the default start address for fvp_baser64. 3. Remove the description of default address from commit log. 4. Change HAS_MPU to ARM_V8R for Xen start address dependency. No matter Arm-v8r board has MPU or not, it always need to specify the start address. --- xen/arch/arm/Kconfig | 8 ++++++++ xen/arch/arm/platforms/Kconfig | 16 +++++++++++++--- 2 files changed, 21 insertions(+), 3 deletions(-) diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index ace7178c9a..c6b6b612d1 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -145,6 +145,14 @@ config TEE This option enables generic TEE mediators support. It allows guests to access real TEE via one of TEE mediators implemented in XEN. +config XEN_START_ADDRESS + hex "Xen start address: keep default to use platform defined address" + default 0 + depends on ARM_V8R + help + This option allows to set the customized address at which Xen will be + linked on MPU systems. This address must be aligned to a page size. + source "arch/arm/tee/Kconfig" config STATIC_SHM diff --git a/xen/arch/arm/platforms/Kconfig b/xen/arch/arm/platforms/Kconfig index c93a6b2756..0904793a0b 100644 --- a/xen/arch/arm/platforms/Kconfig +++ b/xen/arch/arm/platforms/Kconfig @@ -1,6 +1,7 @@ choice prompt "Platform Support" default ALL_PLAT + default FVP_BASER if ARM_V8R ---help--- Choose which hardware platform to enable in Xen. @@ -8,13 +9,14 @@ choice config ALL_PLAT bool "All Platforms" + depends on !ARM_V8R ---help--- Enable support for all available hardware platforms. It doesn't automatically select any of the related drivers. config QEMU bool "QEMU aarch virt machine support" - depends on ARM_64 + depends on ARM_64 && !ARM_V8R select GICV3 select HAS_PL011 ---help--- @@ -23,7 +25,7 @@ config QEMU config RCAR3 bool "Renesas RCar3 support" - depends on ARM_64 + depends on ARM_64 && !ARM_V8R select HAS_SCIF select IPMMU_VMSA ---help--- @@ -31,14 +33,22 @@ config RCAR3 config MPSOC bool "Xilinx Ultrascale+ MPSoC support" - depends on ARM_64 + depends on ARM_64 && !ARM_V8R select HAS_CADENCE_UART select ARM_SMMU ---help--- Enable all the required drivers for Xilinx Ultrascale+ MPSoC +config FVP_BASER + bool "Fixed Virtual Platform BaseR support" + depends on ARM_V8R + help + Enable platform specific configurations for Fixed Virtual + Platform BaseR + config NO_PLAT bool "No Platforms" + depends on !ARM_V8R ---help--- Do not enable specific support for any platform. -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 13 05:29:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 05:29:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476500.738743 (Exim 4.92) (envelope-from ) id 1pGCdZ-00073w-E4; Fri, 13 Jan 2023 05:29:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476500.738743; Fri, 13 Jan 2023 05:29:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCdZ-00073n-8b; Fri, 13 Jan 2023 05:29:57 +0000 Received: by outflank-mailman (input) for mailman id 476500; Fri, 13 Jan 2023 05:29:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCdY-0005sJ-3x for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 05:29:56 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 4fa41a76-9303-11ed-91b6-6bf2151ebd3b; Fri, 13 Jan 2023 06:29:55 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 97960FEC; Thu, 12 Jan 2023 21:30:36 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 631913F587; Thu, 12 Jan 2023 21:29:52 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4fa41a76-9303-11ed-91b6-6bf2151ebd3b From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v2 05/40] xen/arm64: prepare for moving MMU related code from head.S Date: Fri, 13 Jan 2023 13:28:38 +0800 Message-Id: <20230113052914.3845596-6-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230113052914.3845596-1-Penny.Zheng@arm.com> References: <20230113052914.3845596-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Wei Chen We want to reuse head.S for MPU systems, but there are some code implemented for MMU systems only. We will move such code to another MMU specific file. But before that, we will do some preparations in this patch to make them easier for reviewing: 1. Fix the indentations of code comments. 2. Export some symbols that will be accessed out of file scope. Signed-off-by: Wei Chen --- v1 -> v2: 1. New patch. --- xen/arch/arm/arm64/head.S | 40 +++++++++++++++++++-------------------- 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S index 93f9b0b9d5..b2214bc5e3 100644 --- a/xen/arch/arm/arm64/head.S +++ b/xen/arch/arm/arm64/head.S @@ -136,22 +136,22 @@ add \xb, \xb, x20 .endm - .section .text.header, "ax", %progbits - /*.aarch64*/ +.section .text.header, "ax", %progbits +/*.aarch64*/ - /* - * Kernel startup entry point. - * --------------------------- - * - * The requirements are: - * MMU = off, D-cache = off, I-cache = on or off, - * x0 = physical address to the FDT blob. - * - * This must be the very first address in the loaded image. - * It should be linked at XEN_VIRT_START, and loaded at any - * 4K-aligned address. All of text+data+bss must fit in 2MB, - * or the initial pagetable code below will need adjustment. - */ +/* + * Kernel startup entry point. + * --------------------------- + * + * The requirements are: + * MMU = off, D-cache = off, I-cache = on or off, + * x0 = physical address to the FDT blob. + * + * This must be the very first address in the loaded image. + * It should be linked at XEN_VIRT_START, and loaded at any + * 4K-aligned address. All of text+data+bss must fit in 2MB, + * or the initial pagetable code below will need adjustment. + */ GLOBAL(start) /* @@ -586,7 +586,7 @@ ENDPROC(cpu_init) * * Clobbers x0 - x4 */ -create_page_tables: +ENTRY(create_page_tables) /* Prepare the page-tables for mapping Xen */ ldr x0, =XEN_VIRT_START create_table_entry boot_pgtable, boot_first, x0, 0, x1, x2, x3 @@ -680,7 +680,7 @@ ENDPROC(create_page_tables) * * Clobbers x0 - x3 */ -enable_mmu: +ENTRY(enable_mmu) PRINT("- Turning on paging -\r\n") /* @@ -714,7 +714,7 @@ ENDPROC(enable_mmu) * * Clobbers x0 - x1 */ -remove_identity_mapping: +ENTRY(remove_identity_mapping) /* * Find the zeroeth slot used. Remove the entry from zeroeth * table if the slot is not XEN_ZEROETH_SLOT. @@ -775,7 +775,7 @@ ENDPROC(remove_identity_mapping) * * Clobbers x0 - x3 */ -setup_fixmap: +ENTRY(setup_fixmap) #ifdef CONFIG_EARLY_PRINTK /* Add UART to the fixmap table */ ldr x0, =EARLY_UART_VIRTUAL_ADDRESS @@ -871,7 +871,7 @@ ENDPROC(init_uart) * x0: Nul-terminated string to print. * x23: Early UART base address * Clobbers x0-x1 */ -puts: +ENTRY(puts) early_uart_ready x23, 1 ldrb w1, [x0], #1 /* Load next char */ cbz w1, 1f /* Exit on nul */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 13 05:30:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 05:30:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476505.738759 (Exim 4.92) (envelope-from ) id 1pGCde-0007sg-NM; Fri, 13 Jan 2023 05:30:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476505.738759; Fri, 13 Jan 2023 05:30:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCde-0007s4-Im; Fri, 13 Jan 2023 05:30:02 +0000 Received: by outflank-mailman (input) for mailman id 476505; Fri, 13 Jan 2023 05:30:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCdd-0005sJ-FF for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 05:30:01 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 517a1b38-9303-11ed-91b6-6bf2151ebd3b; Fri, 13 Jan 2023 06:29:58 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B35B1FEC; Thu, 12 Jan 2023 21:30:39 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id F37C33F587; Thu, 12 Jan 2023 21:29:54 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 517a1b38-9303-11ed-91b6-6bf2151ebd3b From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Henry Wang Subject: [PATCH v2 06/40] xen/arm64: move MMU related code from head.S to head_mmu.S Date: Fri, 13 Jan 2023 13:28:39 +0800 Message-Id: <20230113052914.3845596-7-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230113052914.3845596-1-Penny.Zheng@arm.com> References: <20230113052914.3845596-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Wei Chen There are lots of MMU specific code in head.S. This code will not be used in MPU systems. If we use #ifdef to gate them, the code will become messy and hard to maintain. So we move MMU related code to head_mmu.S, and keep common code still in head.S. And some assembly macros that will be shared by MMU and MPU later, we move them to macros.h. Signed-off-by: Wei Chen Signed-off-by: Henry Wang --- v1 -> v2: 1. Move macros to macros.h 2. Remove the indention modification 3. Duplicate "fail" instead of exporting it. --- xen/arch/arm/arm64/Makefile | 3 + xen/arch/arm/arm64/head.S | 383 ------------------------ xen/arch/arm/arm64/head_mmu.S | 372 +++++++++++++++++++++++ xen/arch/arm/include/asm/arm64/macros.h | 51 ++++ 4 files changed, 426 insertions(+), 383 deletions(-) create mode 100644 xen/arch/arm/arm64/head_mmu.S diff --git a/xen/arch/arm/arm64/Makefile b/xen/arch/arm/arm64/Makefile index 6d507da0d4..22da2f54b5 100644 --- a/xen/arch/arm/arm64/Makefile +++ b/xen/arch/arm/arm64/Makefile @@ -8,6 +8,9 @@ obj-y += domctl.o obj-y += domain.o obj-y += entry.o obj-y += head.o +ifneq ($(CONFIG_HAS_MPU),y) +obj-y += head_mmu.o +endif obj-y += insn.o obj-$(CONFIG_LIVEPATCH) += livepatch.o obj-y += smc.o diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S index b2214bc5e3..5cfa47279b 100644 --- a/xen/arch/arm/arm64/head.S +++ b/xen/arch/arm/arm64/head.S @@ -28,17 +28,6 @@ #include #endif -#define PT_PT 0xf7f /* nG=1 AF=1 SH=11 AP=01 NS=1 ATTR=111 T=1 P=1 */ -#define PT_MEM 0xf7d /* nG=1 AF=1 SH=11 AP=01 NS=1 ATTR=111 T=0 P=1 */ -#define PT_MEM_L3 0xf7f /* nG=1 AF=1 SH=11 AP=01 NS=1 ATTR=111 T=1 P=1 */ -#define PT_DEV 0xe71 /* nG=1 AF=1 SH=10 AP=01 NS=1 ATTR=100 T=0 P=1 */ -#define PT_DEV_L3 0xe73 /* nG=1 AF=1 SH=10 AP=01 NS=1 ATTR=100 T=1 P=1 */ - -/* Convenience defines to get slot used by Xen mapping. */ -#define XEN_ZEROETH_SLOT zeroeth_table_offset(XEN_VIRT_START) -#define XEN_FIRST_SLOT first_table_offset(XEN_VIRT_START) -#define XEN_SECOND_SLOT second_table_offset(XEN_VIRT_START) - #define __HEAD_FLAG_PAGE_SIZE ((PAGE_SHIFT - 10) / 2) #define __HEAD_FLAG_PHYS_BASE 1 @@ -85,57 +74,6 @@ * x30 - lr */ -#ifdef CONFIG_EARLY_PRINTK -/* - * Macro to print a string to the UART, if there is one. - * - * Clobbers x0 - x3 - */ -#define PRINT(_s) \ - mov x3, lr ; \ - adr x0, 98f ; \ - bl puts ; \ - mov lr, x3 ; \ - RODATA_STR(98, _s) - -/* - * Macro to print the value of register \xb - * - * Clobbers x0 - x4 - */ -.macro print_reg xb - mov x0, \xb - mov x4, lr - bl putn - mov lr, x4 -.endm - -#else /* CONFIG_EARLY_PRINTK */ -#define PRINT(s) - -.macro print_reg xb -.endm - -#endif /* !CONFIG_EARLY_PRINTK */ - -/* - * Pseudo-op for PC relative adr , where is - * within the range +/- 4GB of the PC. - * - * @dst: destination register (64 bit wide) - * @sym: name of the symbol - */ -.macro adr_l, dst, sym - adrp \dst, \sym - add \dst, \dst, :lo12:\sym -.endm - -/* Load the physical address of a symbol into xb */ -.macro load_paddr xb, sym - ldr \xb, =\sym - add \xb, \xb, x20 -.endm - .section .text.header, "ax", %progbits /*.aarch64*/ @@ -500,296 +438,6 @@ cpu_init: ret ENDPROC(cpu_init) -/* - * Macro to find the slot number at a given page-table level - * - * slot: slot computed - * virt: virtual address - * lvl: page-table level - */ -.macro get_table_slot, slot, virt, lvl - ubfx \slot, \virt, #XEN_PT_LEVEL_SHIFT(\lvl), #XEN_PT_LPAE_SHIFT -.endm - -/* - * Macro to create a page table entry in \ptbl to \tbl - * - * ptbl: table symbol where the entry will be created - * tbl: table symbol to point to - * virt: virtual address - * lvl: page-table level - * tmp1: scratch register - * tmp2: scratch register - * tmp3: scratch register - * - * Preserves \virt - * Clobbers \tmp1, \tmp2, \tmp3 - * - * Also use x20 for the phys offset. - * - * Note that all parameters using registers should be distinct. - */ -.macro create_table_entry, ptbl, tbl, virt, lvl, tmp1, tmp2, tmp3 - get_table_slot \tmp1, \virt, \lvl /* \tmp1 := slot in \tlb */ - - load_paddr \tmp2, \tbl - mov \tmp3, #PT_PT /* \tmp3 := right for linear PT */ - orr \tmp3, \tmp3, \tmp2 /* + \tlb paddr */ - - adr_l \tmp2, \ptbl - - str \tmp3, [\tmp2, \tmp1, lsl #3] -.endm - -/* - * Macro to create a mapping entry in \tbl to \phys. Only mapping in 3rd - * level table (i.e page granularity) is supported. - * - * ptbl: table symbol where the entry will be created - * virt: virtual address - * phys: physical address (should be page aligned) - * tmp1: scratch register - * tmp2: scratch register - * tmp3: scratch register - * type: mapping type. If not specified it will be normal memory (PT_MEM_L3) - * - * Preserves \virt, \phys - * Clobbers \tmp1, \tmp2, \tmp3 - * - * Note that all parameters using registers should be distinct. - */ -.macro create_mapping_entry, ptbl, virt, phys, tmp1, tmp2, tmp3, type=PT_MEM_L3 - and \tmp3, \phys, #THIRD_MASK /* \tmp3 := PAGE_ALIGNED(phys) */ - - get_table_slot \tmp1, \virt, 3 /* \tmp1 := slot in \tlb */ - - mov \tmp2, #\type /* \tmp2 := right for section PT */ - orr \tmp2, \tmp2, \tmp3 /* + PAGE_ALIGNED(phys) */ - - adr_l \tmp3, \ptbl - - str \tmp2, [\tmp3, \tmp1, lsl #3] -.endm - -/* - * Rebuild the boot pagetable's first-level entries. The structure - * is described in mm.c. - * - * After the CPU enables paging it will add the fixmap mapping - * to these page tables, however this may clash with the 1:1 - * mapping. So each CPU must rebuild the page tables here with - * the 1:1 in place. - * - * Inputs: - * x19: paddr(start) - * x20: phys offset - * - * Clobbers x0 - x4 - */ -ENTRY(create_page_tables) - /* Prepare the page-tables for mapping Xen */ - ldr x0, =XEN_VIRT_START - create_table_entry boot_pgtable, boot_first, x0, 0, x1, x2, x3 - create_table_entry boot_first, boot_second, x0, 1, x1, x2, x3 - create_table_entry boot_second, boot_third, x0, 2, x1, x2, x3 - - /* Map Xen */ - adr_l x4, boot_third - - lsr x2, x19, #THIRD_SHIFT /* Base address for 4K mapping */ - lsl x2, x2, #THIRD_SHIFT - mov x3, #PT_MEM_L3 /* x2 := Section map */ - orr x2, x2, x3 - - /* ... map of vaddr(start) in boot_third */ - mov x1, xzr -1: str x2, [x4, x1] /* Map vaddr(start) */ - add x2, x2, #PAGE_SIZE /* Next page */ - add x1, x1, #8 /* Next slot */ - cmp x1, #(XEN_PT_LPAE_ENTRIES<<3) /* 512 entries per page */ - b.lt 1b - - /* - * If Xen is loaded at exactly XEN_VIRT_START then we don't - * need an additional 1:1 mapping, the virtual mapping will - * suffice. - */ - cmp x19, #XEN_VIRT_START - bne 1f - ret -1: - /* - * Setup the 1:1 mapping so we can turn the MMU on. Note that - * only the first page of Xen will be part of the 1:1 mapping. - */ - - /* - * Find the zeroeth slot used. If the slot is not - * XEN_ZEROETH_SLOT, then the 1:1 mapping will use its own set of - * page-tables from the first level. - */ - get_table_slot x0, x19, 0 /* x0 := zeroeth slot */ - cmp x0, #XEN_ZEROETH_SLOT - beq 1f - create_table_entry boot_pgtable, boot_first_id, x19, 0, x0, x1, x2 - b link_from_first_id - -1: - /* - * Find the first slot used. If the slot is not XEN_FIRST_SLOT, - * then the 1:1 mapping will use its own set of page-tables from - * the second level. - */ - get_table_slot x0, x19, 1 /* x0 := first slot */ - cmp x0, #XEN_FIRST_SLOT - beq 1f - create_table_entry boot_first, boot_second_id, x19, 1, x0, x1, x2 - b link_from_second_id - -1: - /* - * Find the second slot used. If the slot is XEN_SECOND_SLOT, then the - * 1:1 mapping will use its own set of page-tables from the - * third level. For slot XEN_SECOND_SLOT, Xen is not yet able to handle - * it. - */ - get_table_slot x0, x19, 2 /* x0 := second slot */ - cmp x0, #XEN_SECOND_SLOT - beq virtphys_clash - create_table_entry boot_second, boot_third_id, x19, 2, x0, x1, x2 - b link_from_third_id - -link_from_first_id: - create_table_entry boot_first_id, boot_second_id, x19, 1, x0, x1, x2 -link_from_second_id: - create_table_entry boot_second_id, boot_third_id, x19, 2, x0, x1, x2 -link_from_third_id: - create_mapping_entry boot_third_id, x19, x19, x0, x1, x2 - ret - -virtphys_clash: - /* Identity map clashes with boot_third, which we cannot handle yet */ - PRINT("- Unable to build boot page tables - virt and phys addresses clash. -\r\n") - b fail -ENDPROC(create_page_tables) - -/* - * Turn on the Data Cache and the MMU. The function will return on the 1:1 - * mapping. In other word, the caller is responsible to switch to the runtime - * mapping. - * - * Clobbers x0 - x3 - */ -ENTRY(enable_mmu) - PRINT("- Turning on paging -\r\n") - - /* - * The state of the TLBs is unknown before turning on the MMU. - * Flush them to avoid stale one. - */ - tlbi alle2 /* Flush hypervisor TLBs */ - dsb nsh - - /* Write Xen's PT's paddr into TTBR0_EL2 */ - load_paddr x0, boot_pgtable - msr TTBR0_EL2, x0 - isb - - mrs x0, SCTLR_EL2 - orr x0, x0, #SCTLR_Axx_ELx_M /* Enable MMU */ - orr x0, x0, #SCTLR_Axx_ELx_C /* Enable D-cache */ - dsb sy /* Flush PTE writes and finish reads */ - msr SCTLR_EL2, x0 /* now paging is enabled */ - isb /* Now, flush the icache */ - ret -ENDPROC(enable_mmu) - -/* - * Remove the 1:1 map from the page-tables. It is not easy to keep track - * where the 1:1 map was mapped, so we will look for the top-level entry - * exclusive to the 1:1 map and remove it. - * - * Inputs: - * x19: paddr(start) - * - * Clobbers x0 - x1 - */ -ENTRY(remove_identity_mapping) - /* - * Find the zeroeth slot used. Remove the entry from zeroeth - * table if the slot is not XEN_ZEROETH_SLOT. - */ - get_table_slot x1, x19, 0 /* x1 := zeroeth slot */ - cmp x1, #XEN_ZEROETH_SLOT - beq 1f - /* It is not in slot XEN_ZEROETH_SLOT, remove the entry. */ - ldr x0, =boot_pgtable /* x0 := root table */ - str xzr, [x0, x1, lsl #3] - b identity_mapping_removed - -1: - /* - * Find the first slot used. Remove the entry for the first - * table if the slot is not XEN_FIRST_SLOT. - */ - get_table_slot x1, x19, 1 /* x1 := first slot */ - cmp x1, #XEN_FIRST_SLOT - beq 1f - /* It is not in slot XEN_FIRST_SLOT, remove the entry. */ - ldr x0, =boot_first /* x0 := first table */ - str xzr, [x0, x1, lsl #3] - b identity_mapping_removed - -1: - /* - * Find the second slot used. Remove the entry for the first - * table if the slot is not XEN_SECOND_SLOT. - */ - get_table_slot x1, x19, 2 /* x1 := second slot */ - cmp x1, #XEN_SECOND_SLOT - beq identity_mapping_removed - /* It is not in slot 1, remove the entry */ - ldr x0, =boot_second /* x0 := second table */ - str xzr, [x0, x1, lsl #3] - -identity_mapping_removed: - /* See asm/arm64/flushtlb.h for the explanation of the sequence. */ - dsb nshst - tlbi alle2 - dsb nsh - isb - - ret -ENDPROC(remove_identity_mapping) - -/* - * Map the UART in the fixmap (when earlyprintk is used) and hook the - * fixmap table in the page tables. - * - * The fixmap cannot be mapped in create_page_tables because it may - * clash with the 1:1 mapping. - * - * Inputs: - * x20: Physical offset - * x23: Early UART base physical address - * - * Clobbers x0 - x3 - */ -ENTRY(setup_fixmap) -#ifdef CONFIG_EARLY_PRINTK - /* Add UART to the fixmap table */ - ldr x0, =EARLY_UART_VIRTUAL_ADDRESS - create_mapping_entry xen_fixmap, x0, x23, x1, x2, x3, type=PT_DEV_L3 -#endif - /* Map fixmap into boot_second */ - ldr x0, =FIXMAP_ADDR(0) - create_table_entry boot_second, xen_fixmap, x0, 2, x1, x2, x3 - /* Ensure any page table updates made above have occurred. */ - dsb nshst - - ret -ENDPROC(setup_fixmap) - /* * Setup the initial stack and jump to the C world * @@ -818,37 +466,6 @@ fail: PRINT("- Boot failed -\r\n") b 1b ENDPROC(fail) -GLOBAL(_end_boot) - -/* - * Switch TTBR - * - * x0 ttbr - * - * TODO: This code does not comply with break-before-make. - */ -ENTRY(switch_ttbr) - dsb sy /* Ensure the flushes happen before - * continuing */ - isb /* Ensure synchronization with previous - * changes to text */ - tlbi alle2 /* Flush hypervisor TLB */ - ic iallu /* Flush I-cache */ - dsb sy /* Ensure completion of TLB flush */ - isb - - msr TTBR0_EL2, x0 - - isb /* Ensure synchronization with previous - * changes to text */ - tlbi alle2 /* Flush hypervisor TLB */ - ic iallu /* Flush I-cache */ - dsb sy /* Ensure completion of TLB flush */ - isb - - ret -ENDPROC(switch_ttbr) - #ifdef CONFIG_EARLY_PRINTK /* * Initialize the UART. Should only be called on the boot CPU. diff --git a/xen/arch/arm/arm64/head_mmu.S b/xen/arch/arm/arm64/head_mmu.S new file mode 100644 index 0000000000..e2c8f07140 --- /dev/null +++ b/xen/arch/arm/arm64/head_mmu.S @@ -0,0 +1,372 @@ +/* + * xen/arch/arm/head_mmu.S + * + * Start-of-day code for an ARMv8-A. + * + * Ian Campbell + * Copyright (c) 2012 Citrix Systems. + * + * Based on ARMv7-A head.S by + * Tim Deegan + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include +#include + +#define PT_PT 0xf7f /* nG=1 AF=1 SH=11 AP=01 NS=1 ATTR=111 T=1 P=1 */ +#define PT_MEM 0xf7d /* nG=1 AF=1 SH=11 AP=01 NS=1 ATTR=111 T=0 P=1 */ +#define PT_MEM_L3 0xf7f /* nG=1 AF=1 SH=11 AP=01 NS=1 ATTR=111 T=1 P=1 */ +#define PT_DEV 0xe71 /* nG=1 AF=1 SH=10 AP=01 NS=1 ATTR=100 T=0 P=1 */ +#define PT_DEV_L3 0xe73 /* nG=1 AF=1 SH=10 AP=01 NS=1 ATTR=100 T=1 P=1 */ + +/* Convenience defines to get slot used by Xen mapping. */ +#define XEN_ZEROETH_SLOT zeroeth_table_offset(XEN_VIRT_START) +#define XEN_FIRST_SLOT first_table_offset(XEN_VIRT_START) +#define XEN_SECOND_SLOT second_table_offset(XEN_VIRT_START) + +/* + * Macro to find the slot number at a given page-table level + * + * slot: slot computed + * virt: virtual address + * lvl: page-table level + */ +.macro get_table_slot, slot, virt, lvl + ubfx \slot, \virt, #XEN_PT_LEVEL_SHIFT(\lvl), #XEN_PT_LPAE_SHIFT +.endm + +/* + * Macro to create a page table entry in \ptbl to \tbl + * + * ptbl: table symbol where the entry will be created + * tbl: table symbol to point to + * virt: virtual address + * lvl: page-table level + * tmp1: scratch register + * tmp2: scratch register + * tmp3: scratch register + * + * Preserves \virt + * Clobbers \tmp1, \tmp2, \tmp3 + * + * Also use x20 for the phys offset. + * + * Note that all parameters using registers should be distinct. + */ +.macro create_table_entry, ptbl, tbl, virt, lvl, tmp1, tmp2, tmp3 + get_table_slot \tmp1, \virt, \lvl /* \tmp1 := slot in \tlb */ + + load_paddr \tmp2, \tbl + mov \tmp3, #PT_PT /* \tmp3 := right for linear PT */ + orr \tmp3, \tmp3, \tmp2 /* + \tlb paddr */ + + adr_l \tmp2, \ptbl + + str \tmp3, [\tmp2, \tmp1, lsl #3] +.endm + +/* + * Macro to create a mapping entry in \tbl to \phys. Only mapping in 3rd + * level table (i.e page granularity) is supported. + * + * ptbl: table symbol where the entry will be created + * virt: virtual address + * phys: physical address (should be page aligned) + * tmp1: scratch register + * tmp2: scratch register + * tmp3: scratch register + * type: mapping type. If not specified it will be normal memory (PT_MEM_L3) + * + * Preserves \virt, \phys + * Clobbers \tmp1, \tmp2, \tmp3 + * + * Note that all parameters using registers should be distinct. + */ +.macro create_mapping_entry, ptbl, virt, phys, tmp1, tmp2, tmp3, type=PT_MEM_L3 + and \tmp3, \phys, #THIRD_MASK /* \tmp3 := PAGE_ALIGNED(phys) */ + + get_table_slot \tmp1, \virt, 3 /* \tmp1 := slot in \tlb */ + + mov \tmp2, #\type /* \tmp2 := right for section PT */ + orr \tmp2, \tmp2, \tmp3 /* + PAGE_ALIGNED(phys) */ + + adr_l \tmp3, \ptbl + + str \tmp2, [\tmp3, \tmp1, lsl #3] +.endm + +.section .text.header, "ax", %progbits +/*.aarch64*/ + +/* + * Rebuild the boot pagetable's first-level entries. The structure + * is described in mm.c. + * + * After the CPU enables paging it will add the fixmap mapping + * to these page tables, however this may clash with the 1:1 + * mapping. So each CPU must rebuild the page tables here with + * the 1:1 in place. + * + * Inputs: + * x19: paddr(start) + * x20: phys offset + * + * Clobbers x0 - x4 + */ +ENTRY(create_page_tables) + /* Prepare the page-tables for mapping Xen */ + ldr x0, =XEN_VIRT_START + create_table_entry boot_pgtable, boot_first, x0, 0, x1, x2, x3 + create_table_entry boot_first, boot_second, x0, 1, x1, x2, x3 + create_table_entry boot_second, boot_third, x0, 2, x1, x2, x3 + + /* Map Xen */ + adr_l x4, boot_third + + lsr x2, x19, #THIRD_SHIFT /* Base address for 4K mapping */ + lsl x2, x2, #THIRD_SHIFT + mov x3, #PT_MEM_L3 /* x2 := Section map */ + orr x2, x2, x3 + + /* ... map of vaddr(start) in boot_third */ + mov x1, xzr +1: str x2, [x4, x1] /* Map vaddr(start) */ + add x2, x2, #PAGE_SIZE /* Next page */ + add x1, x1, #8 /* Next slot */ + cmp x1, #(XEN_PT_LPAE_ENTRIES<<3) /* 512 entries per page */ + b.lt 1b + + /* + * If Xen is loaded at exactly XEN_VIRT_START then we don't + * need an additional 1:1 mapping, the virtual mapping will + * suffice. + */ + cmp x19, #XEN_VIRT_START + bne 1f + ret +1: + /* + * Setup the 1:1 mapping so we can turn the MMU on. Note that + * only the first page of Xen will be part of the 1:1 mapping. + */ + + /* + * Find the zeroeth slot used. If the slot is not + * XEN_ZEROETH_SLOT, then the 1:1 mapping will use its own set of + * page-tables from the first level. + */ + get_table_slot x0, x19, 0 /* x0 := zeroeth slot */ + cmp x0, #XEN_ZEROETH_SLOT + beq 1f + create_table_entry boot_pgtable, boot_first_id, x19, 0, x0, x1, x2 + b link_from_first_id + +1: + /* + * Find the first slot used. If the slot is not XEN_FIRST_SLOT, + * then the 1:1 mapping will use its own set of page-tables from + * the second level. + */ + get_table_slot x0, x19, 1 /* x0 := first slot */ + cmp x0, #XEN_FIRST_SLOT + beq 1f + create_table_entry boot_first, boot_second_id, x19, 1, x0, x1, x2 + b link_from_second_id + +1: + /* + * Find the second slot used. If the slot is XEN_SECOND_SLOT, then the + * 1:1 mapping will use its own set of page-tables from the + * third level. For slot XEN_SECOND_SLOT, Xen is not yet able to handle + * it. + */ + get_table_slot x0, x19, 2 /* x0 := second slot */ + cmp x0, #XEN_SECOND_SLOT + beq virtphys_clash + create_table_entry boot_second, boot_third_id, x19, 2, x0, x1, x2 + b link_from_third_id + +link_from_first_id: + create_table_entry boot_first_id, boot_second_id, x19, 1, x0, x1, x2 +link_from_second_id: + create_table_entry boot_second_id, boot_third_id, x19, 2, x0, x1, x2 +link_from_third_id: + create_mapping_entry boot_third_id, x19, x19, x0, x1, x2 + ret + +virtphys_clash: + /* Identity map clashes with boot_third, which we cannot handle yet */ + PRINT("- Unable to build boot page tables - virt and phys addresses clash. -\r\n") + b fail +ENDPROC(create_page_tables) + +/* + * Turn on the Data Cache and the MMU. The function will return on the 1:1 + * mapping. In other word, the caller is responsible to switch to the runtime + * mapping. + * + * Clobbers x0 - x3 + */ +ENTRY(enable_mmu) + PRINT("- Turning on paging -\r\n") + + /* + * The state of the TLBs is unknown before turning on the MMU. + * Flush them to avoid stale one. + */ + tlbi alle2 /* Flush hypervisor TLBs */ + dsb nsh + + /* Write Xen's PT's paddr into TTBR0_EL2 */ + load_paddr x0, boot_pgtable + msr TTBR0_EL2, x0 + isb + + mrs x0, SCTLR_EL2 + orr x0, x0, #SCTLR_Axx_ELx_M /* Enable MMU */ + orr x0, x0, #SCTLR_Axx_ELx_C /* Enable D-cache */ + dsb sy /* Flush PTE writes and finish reads */ + msr SCTLR_EL2, x0 /* now paging is enabled */ + isb /* Now, flush the icache */ + ret +ENDPROC(enable_mmu) + +/* + * Remove the 1:1 map from the page-tables. It is not easy to keep track + * where the 1:1 map was mapped, so we will look for the top-level entry + * exclusive to the 1:1 map and remove it. + * + * Inputs: + * x19: paddr(start) + * + * Clobbers x0 - x1 + */ +ENTRY(remove_identity_mapping) + /* + * Find the zeroeth slot used. Remove the entry from zeroeth + * table if the slot is not XEN_ZEROETH_SLOT. + */ + get_table_slot x1, x19, 0 /* x1 := zeroeth slot */ + cmp x1, #XEN_ZEROETH_SLOT + beq 1f + /* It is not in slot XEN_ZEROETH_SLOT, remove the entry. */ + ldr x0, =boot_pgtable /* x0 := root table */ + str xzr, [x0, x1, lsl #3] + b identity_mapping_removed + +1: + /* + * Find the first slot used. Remove the entry for the first + * table if the slot is not XEN_FIRST_SLOT. + */ + get_table_slot x1, x19, 1 /* x1 := first slot */ + cmp x1, #XEN_FIRST_SLOT + beq 1f + /* It is not in slot XEN_FIRST_SLOT, remove the entry. */ + ldr x0, =boot_first /* x0 := first table */ + str xzr, [x0, x1, lsl #3] + b identity_mapping_removed + +1: + /* + * Find the second slot used. Remove the entry for the first + * table if the slot is not XEN_SECOND_SLOT. + */ + get_table_slot x1, x19, 2 /* x1 := second slot */ + cmp x1, #XEN_SECOND_SLOT + beq identity_mapping_removed + /* It is not in slot 1, remove the entry */ + ldr x0, =boot_second /* x0 := second table */ + str xzr, [x0, x1, lsl #3] + +identity_mapping_removed: + /* See asm/arm64/flushtlb.h for the explanation of the sequence. */ + dsb nshst + tlbi alle2 + dsb nsh + isb + + ret +ENDPROC(remove_identity_mapping) + +/* + * Map the UART in the fixmap (when earlyprintk is used) and hook the + * fixmap table in the page tables. + * + * The fixmap cannot be mapped in create_page_tables because it may + * clash with the 1:1 mapping. + * + * Inputs: + * x20: Physical offset + * x23: Early UART base physical address + * + * Clobbers x0 - x3 + */ +ENTRY(setup_fixmap) +#ifdef CONFIG_EARLY_PRINTK + /* Add UART to the fixmap table */ + ldr x0, =EARLY_UART_VIRTUAL_ADDRESS + create_mapping_entry xen_fixmap, x0, x23, x1, x2, x3, type=PT_DEV_L3 +#endif + /* Map fixmap into boot_second */ + ldr x0, =FIXMAP_ADDR(0) + create_table_entry boot_second, xen_fixmap, x0, 2, x1, x2, x3 + /* Ensure any page table updates made above have occurred. */ + dsb nshst + + ret +ENDPROC(setup_fixmap) + +/* Fail-stop */ +fail: PRINT("- Boot failed -\r\n") +1: wfe + b 1b +ENDPROC(fail) + +GLOBAL(_end_boot) + +/* + * Switch TTBR + * + * x0 ttbr + * + * TODO: This code does not comply with break-before-make. + */ +ENTRY(switch_ttbr) + dsb sy /* Ensure the flushes happen before + * continuing */ + isb /* Ensure synchronization with previous + * changes to text */ + tlbi alle2 /* Flush hypervisor TLB */ + ic iallu /* Flush I-cache */ + dsb sy /* Ensure completion of TLB flush */ + isb + + msr TTBR0_EL2, x0 + + isb /* Ensure synchronization with previous + * changes to text */ + tlbi alle2 /* Flush hypervisor TLB */ + ic iallu /* Flush I-cache */ + dsb sy /* Ensure completion of TLB flush */ + isb + + ret +ENDPROC(switch_ttbr) + +/* + * Local variables: + * mode: ASM + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/arm/include/asm/arm64/macros.h b/xen/arch/arm/include/asm/arm64/macros.h index 140e223b4c..f28c124e66 100644 --- a/xen/arch/arm/include/asm/arm64/macros.h +++ b/xen/arch/arm/include/asm/arm64/macros.h @@ -32,6 +32,57 @@ hint #22 .endm +#ifdef CONFIG_EARLY_PRINTK +/* + * Macro to print a string to the UART, if there is one. + * + * Clobbers x0 - x3 + */ +#define PRINT(_s) \ + mov x3, lr ; \ + adr x0, 98f ; \ + bl puts ; \ + mov lr, x3 ; \ + RODATA_STR(98, _s) + +/* + * Macro to print the value of register \xb + * + * Clobbers x0 - x4 + */ +.macro print_reg xb + mov x0, \xb + mov x4, lr + bl putn + mov lr, x4 +.endm + +#else /* CONFIG_EARLY_PRINTK */ +#define PRINT(s) + +.macro print_reg xb +.endm + +#endif /* !CONFIG_EARLY_PRINTK */ + +/* + * Pseudo-op for PC relative adr , where is + * within the range +/- 4GB of the PC. + * + * @dst: destination register (64 bit wide) + * @sym: name of the symbol + */ +.macro adr_l, dst, sym + adrp \dst, \sym + add \dst, \dst, :lo12:\sym +.endm + +/* Load the physical address of a symbol into xb */ +.macro load_paddr xb, sym + ldr \xb, =\sym + add \xb, \xb, x20 +.endm + /* * Register aliases. */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 13 05:30:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 05:30:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476506.738771 (Exim 4.92) (envelope-from ) id 1pGCdg-0008If-Kx; Fri, 13 Jan 2023 05:30:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476506.738771; Fri, 13 Jan 2023 05:30:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCdg-0008IK-6N; Fri, 13 Jan 2023 05:30:04 +0000 Received: by outflank-mailman (input) for mailman id 476506; Fri, 13 Jan 2023 05:30:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCde-0005sP-Ki for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 05:30:02 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 52eff47f-9303-11ed-b8d0-410ff93cb8f0; Fri, 13 Jan 2023 06:30:00 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4DA8413D5; Thu, 12 Jan 2023 21:30:42 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 194803F587; Thu, 12 Jan 2023 21:29:57 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 52eff47f-9303-11ed-b8d0-410ff93cb8f0 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v2 07/40] xen/arm64: add .text.idmap for Xen identity map sections Date: Fri, 13 Jan 2023 13:28:40 +0800 Message-Id: <20230113052914.3845596-8-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230113052914.3845596-1-Penny.Zheng@arm.com> References: <20230113052914.3845596-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Wei Chen Only the first 4KB of Xen image will be mapped as identity (PA == VA). At the moment, Xen guarantees this by having everything that needs to be used in the identity mapping in head.S before _end_boot and checking at link time if this fits in 4KB. In previous patch, we have moved the MMU code outside of head.S. Although we have added .text.header to the new file to guarantee all identity map code still in the first 4KB. However, the order of these two files on this 4KB depends on the build tools. Currently, we use the build tools to process the order of objs in the Makefile to ensure that head.S must be at the top. But if you change to another build tools, it may not be the same result. In this patch we introduce .text.idmap to head_mmu.S, and add this section after .text.header. to ensure code of head_mmu.S after the code of header.S. After this, we will still include some code that does not belong to identity map before _end_boot. Because we have moved _end_boot to head_mmu.S. That means all code in head.S will be included before _end_boot. In this patch, we also added .text flag in the place of original _end_boot in head.S. All the code after .text in head.S will not be included in identity map section. Signed-off-by: Wei Chen --- v1 -> v2: 1. New patch. --- xen/arch/arm/arm64/head.S | 6 ++++++ xen/arch/arm/arm64/head_mmu.S | 2 +- xen/arch/arm/xen.lds.S | 1 + 3 files changed, 8 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S index 5cfa47279b..782bd1f94c 100644 --- a/xen/arch/arm/arm64/head.S +++ b/xen/arch/arm/arm64/head.S @@ -466,6 +466,12 @@ fail: PRINT("- Boot failed -\r\n") b 1b ENDPROC(fail) +/* + * For the code that do not need in indentity map section, + * we put them back to normal .text section + */ +.section .text, "ax", %progbits + #ifdef CONFIG_EARLY_PRINTK /* * Initialize the UART. Should only be called on the boot CPU. diff --git a/xen/arch/arm/arm64/head_mmu.S b/xen/arch/arm/arm64/head_mmu.S index e2c8f07140..6ff13c751c 100644 --- a/xen/arch/arm/arm64/head_mmu.S +++ b/xen/arch/arm/arm64/head_mmu.S @@ -105,7 +105,7 @@ str \tmp2, [\tmp3, \tmp1, lsl #3] .endm -.section .text.header, "ax", %progbits +.section .text.idmap, "ax", %progbits /*.aarch64*/ /* diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S index 92c2984052..bc45ea2c65 100644 --- a/xen/arch/arm/xen.lds.S +++ b/xen/arch/arm/xen.lds.S @@ -33,6 +33,7 @@ SECTIONS .text : { _stext = .; /* Text section */ *(.text.header) + *(.text.idmap) *(.text.cold) *(.text.unlikely .text.*_unlikely .text.unlikely.*) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 13 05:30:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 05:30:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476508.738780 (Exim 4.92) (envelope-from ) id 1pGCdh-0000Gs-SS; Fri, 13 Jan 2023 05:30:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476508.738780; Fri, 13 Jan 2023 05:30:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCdh-0000FT-Nc; Fri, 13 Jan 2023 05:30:05 +0000 Received: by outflank-mailman (input) for mailman id 476508; Fri, 13 Jan 2023 05:30:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCdg-0005sJ-74 for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 05:30:04 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 54999a60-9303-11ed-91b6-6bf2151ebd3b; Fri, 13 Jan 2023 06:30:03 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E6A64FEC; Thu, 12 Jan 2023 21:30:44 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id A95933F587; Thu, 12 Jan 2023 21:30:00 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 54999a60-9303-11ed-91b6-6bf2151ebd3b From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v2 08/40] xen/arm: use PA == VA for EARLY_UART_VIRTUAL_ADDRESS on Armv-8R Date: Fri, 13 Jan 2023 13:28:41 +0800 Message-Id: <20230113052914.3845596-9-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230113052914.3845596-1-Penny.Zheng@arm.com> References: <20230113052914.3845596-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Wei Chen There is no VMSA support on Armv8-R AArch64, so we can not map early UART to FIXMAP_CONSOLE. Instead, we use PA == VA to define EARLY_UART_VIRTUAL_ADDRESS on Armv8-R AArch64. Signed-off-by: Wei Chen --- 1. New patch --- xen/arch/arm/include/asm/early_printk.h | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/xen/arch/arm/include/asm/early_printk.h b/xen/arch/arm/include/asm/early_printk.h index c5149b2976..44a230853f 100644 --- a/xen/arch/arm/include/asm/early_printk.h +++ b/xen/arch/arm/include/asm/early_printk.h @@ -15,10 +15,22 @@ #ifdef CONFIG_EARLY_PRINTK +#ifdef CONFIG_ARM_V8R + +/* + * For Armv-8r, there is not VMSA support in EL2, so we use VA == PA + * for EARLY_UART_VIRTUAL_ADDRESS. + */ +#define EARLY_UART_VIRTUAL_ADDRESS CONFIG_EARLY_UART_BASE_ADDRESS + +#else + /* need to add the uart address offset in page to the fixmap address */ #define EARLY_UART_VIRTUAL_ADDRESS \ (FIXMAP_ADDR(FIXMAP_CONSOLE) + (CONFIG_EARLY_UART_BASE_ADDRESS & ~PAGE_MASK)) +#endif /* CONFIG_ARM_V8R */ + #endif /* !CONFIG_EARLY_PRINTK */ #endif -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 13 05:30:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 05:30:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476511.738794 (Exim 4.92) (envelope-from ) id 1pGCdk-0000wu-97; Fri, 13 Jan 2023 05:30:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476511.738794; Fri, 13 Jan 2023 05:30:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCdk-0000w2-2b; Fri, 13 Jan 2023 05:30:08 +0000 Received: by outflank-mailman (input) for mailman id 476511; Fri, 13 Jan 2023 05:30:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCdi-0005sJ-MC for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 05:30:06 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 5610a0b4-9303-11ed-91b6-6bf2151ebd3b; Fri, 13 Jan 2023 06:30:05 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 835E5FEC; Thu, 12 Jan 2023 21:30:47 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 4E56A3F587; Thu, 12 Jan 2023 21:30:03 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5610a0b4-9303-11ed-91b6-6bf2151ebd3b From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v2 09/40] xen/arm: decouple copy_from_paddr with FIXMAP Date: Fri, 13 Jan 2023 13:28:42 +0800 Message-Id: <20230113052914.3845596-10-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230113052914.3845596-1-Penny.Zheng@arm.com> References: <20230113052914.3845596-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Wei Chen copy_from_paddr will map a page to Xen's FIXMAP_MISC area for temporary access. But for those systems do not support VMSA, they can not implement set_fixmap/clear_fixmap, that means they can't always use the same virtual address for source address. In this case, we introduce to helpers to decouple copy_from_paddr with set_fixmap/clear_fixmap. map_page_to_xen_misc can always return the same virtual address as before for VMSA systems. It also can return different address for non-VMSA systems. Signed-off-by: Wei Chen --- v1 -> v2: 1. New patch --- xen/arch/arm/include/asm/setup.h | 4 ++++ xen/arch/arm/kernel.c | 13 +++++++------ xen/arch/arm/mm.c | 12 ++++++++++++ 3 files changed, 23 insertions(+), 6 deletions(-) diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index a926f30a2b..4f39a1aa0a 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -119,6 +119,10 @@ extern struct bootinfo bootinfo; extern domid_t max_init_domid; +/* Map a page to misc area */ +void *map_page_to_xen_misc(mfn_t mfn, unsigned int attributes); +/* Unmap the page from misc area */ +void unmap_page_from_xen_misc(void); void copy_from_paddr(void *dst, paddr_t paddr, unsigned long len); size_t estimate_efi_size(unsigned int mem_nr_banks); diff --git a/xen/arch/arm/kernel.c b/xen/arch/arm/kernel.c index 23b840ea9e..0475d8fae7 100644 --- a/xen/arch/arm/kernel.c +++ b/xen/arch/arm/kernel.c @@ -49,18 +49,19 @@ struct minimal_dtb_header { */ void __init copy_from_paddr(void *dst, paddr_t paddr, unsigned long len) { - void *src = (void *)FIXMAP_ADDR(FIXMAP_MISC); - - while (len) { + while ( len ) + { + void *src; unsigned long l, s; - s = paddr & (PAGE_SIZE-1); + s = paddr & (PAGE_SIZE - 1); l = min(PAGE_SIZE - s, len); - set_fixmap(FIXMAP_MISC, maddr_to_mfn(paddr), PAGE_HYPERVISOR_WC); + src = map_page_to_xen_misc(maddr_to_mfn(paddr), PAGE_HYPERVISOR_WC); + ASSERT(src != NULL); memcpy(dst, src + s, l); clean_dcache_va_range(dst, l); - clear_fixmap(FIXMAP_MISC); + unmap_page_from_xen_misc(); paddr += l; dst += l; diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index 0fc6f2992d..8f15814c5e 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -355,6 +355,18 @@ void clear_fixmap(unsigned int map) BUG_ON(res != 0); } +void *map_page_to_xen_misc(mfn_t mfn, unsigned int attributes) +{ + set_fixmap(FIXMAP_MISC, mfn, attributes); + + return fix_to_virt(FIXMAP_MISC); +} + +void unmap_page_from_xen_misc(void) +{ + clear_fixmap(FIXMAP_MISC); +} + void flush_page_to_ram(unsigned long mfn, bool sync_icache) { void *v = map_domain_page(_mfn(mfn)); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 13 05:30:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 05:30:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476520.738804 (Exim 4.92) (envelope-from ) id 1pGCdr-000263-JA; Fri, 13 Jan 2023 05:30:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476520.738804; Fri, 13 Jan 2023 05:30:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCdr-00025i-E3; Fri, 13 Jan 2023 05:30:15 +0000 Received: by outflank-mailman (input) for mailman id 476520; Fri, 13 Jan 2023 05:30:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCdo-0005sJ-WF for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 05:30:13 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 59547816-9303-11ed-91b6-6bf2151ebd3b; Fri, 13 Jan 2023 06:30:11 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EECB0FEC; Thu, 12 Jan 2023 21:30:52 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 7B4CD3F587; Thu, 12 Jan 2023 21:30:08 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 59547816-9303-11ed-91b6-6bf2151ebd3b From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v2 11/40] xen/mpu: build up start-of-day Xen MPU memory region map Date: Fri, 13 Jan 2023 13:28:44 +0800 Message-Id: <20230113052914.3845596-12-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230113052914.3845596-1-Penny.Zheng@arm.com> References: <20230113052914.3845596-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Penny Zheng The start-of-day Xen MPU memory region layout shall be like as follows: xen_mpumap[0] : Xen text xen_mpumap[1] : Xen read-only data xen_mpumap[2] : Xen read-only after init data xen_mpumap[3] : Xen read-write data xen_mpumap[4] : Xen BSS ...... xen_mpumap[max_xen_mpumap - 2]: Xen init data xen_mpumap[max_xen_mpumap - 1]: Xen init text max_xen_mpumap refers to the number of regions supported by the EL2 MPU. The layout shall be compliant with what we describe in xen.lds.S, or the codes need adjustment. As MMU system and MPU system have different functions to create the boot MMU/MPU memory management data, instead of introducing extra #ifdef in main code flow, we introduce a neutral name prepare_early_mappings for both, and also to replace create_page_tables for MMU. Signed-off-by: Penny Zheng Signed-off-by: Wei Chen --- xen/arch/arm/arm64/Makefile | 2 + xen/arch/arm/arm64/head.S | 17 +- xen/arch/arm/arm64/head_mmu.S | 4 +- xen/arch/arm/arm64/head_mpu.S | 323 +++++++++++++++++++++++ xen/arch/arm/include/asm/arm64/mpu.h | 63 +++++ xen/arch/arm/include/asm/arm64/sysregs.h | 49 ++++ xen/arch/arm/mm_mpu.c | 48 ++++ xen/arch/arm/xen.lds.S | 4 + 8 files changed, 502 insertions(+), 8 deletions(-) create mode 100644 xen/arch/arm/arm64/head_mpu.S create mode 100644 xen/arch/arm/include/asm/arm64/mpu.h create mode 100644 xen/arch/arm/mm_mpu.c diff --git a/xen/arch/arm/arm64/Makefile b/xen/arch/arm/arm64/Makefile index 22da2f54b5..438c9737ad 100644 --- a/xen/arch/arm/arm64/Makefile +++ b/xen/arch/arm/arm64/Makefile @@ -10,6 +10,8 @@ obj-y += entry.o obj-y += head.o ifneq ($(CONFIG_HAS_MPU),y) obj-y += head_mmu.o +else +obj-y += head_mpu.o endif obj-y += insn.o obj-$(CONFIG_LIVEPATCH) += livepatch.o diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S index 782bd1f94c..145e3d53dc 100644 --- a/xen/arch/arm/arm64/head.S +++ b/xen/arch/arm/arm64/head.S @@ -68,9 +68,9 @@ * x24 - * x25 - * x26 - skip_zero_bss (boot cpu only) - * x27 - - * x28 - - * x29 - + * x27 - region selector (mpu only) + * x28 - prbar (mpu only) + * x29 - prlar (mpu only) * x30 - lr */ @@ -82,7 +82,7 @@ * --------------------------- * * The requirements are: - * MMU = off, D-cache = off, I-cache = on or off, + * MMU/MPU = off, D-cache = off, I-cache = on or off, * x0 = physical address to the FDT blob. * * This must be the very first address in the loaded image. @@ -252,7 +252,12 @@ real_start_efi: bl check_cpu_mode bl cpu_init - bl create_page_tables + + /* + * Create boot memory management data, pagetable for MMU systems + * and memory regions for MPU systems. + */ + bl prepare_early_mappings bl enable_mmu /* We are still in the 1:1 mapping. Jump to the runtime Virtual Address. */ @@ -310,7 +315,7 @@ GLOBAL(init_secondary) #endif bl check_cpu_mode bl cpu_init - bl create_page_tables + bl prepare_early_mappings bl enable_mmu /* We are still in the 1:1 mapping. Jump to the runtime Virtual Address. */ diff --git a/xen/arch/arm/arm64/head_mmu.S b/xen/arch/arm/arm64/head_mmu.S index 6ff13c751c..2346f755df 100644 --- a/xen/arch/arm/arm64/head_mmu.S +++ b/xen/arch/arm/arm64/head_mmu.S @@ -123,7 +123,7 @@ * * Clobbers x0 - x4 */ -ENTRY(create_page_tables) +ENTRY(prepare_early_mappings) /* Prepare the page-tables for mapping Xen */ ldr x0, =XEN_VIRT_START create_table_entry boot_pgtable, boot_first, x0, 0, x1, x2, x3 @@ -208,7 +208,7 @@ virtphys_clash: /* Identity map clashes with boot_third, which we cannot handle yet */ PRINT("- Unable to build boot page tables - virt and phys addresses clash. -\r\n") b fail -ENDPROC(create_page_tables) +ENDPROC(prepare_early_mappings) /* * Turn on the Data Cache and the MMU. The function will return on the 1:1 diff --git a/xen/arch/arm/arm64/head_mpu.S b/xen/arch/arm/arm64/head_mpu.S new file mode 100644 index 0000000000..0b97ce4646 --- /dev/null +++ b/xen/arch/arm/arm64/head_mpu.S @@ -0,0 +1,323 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * Start-of-day code for an Armv8-R AArch64 MPU system. + */ + +#include +#include +#include + +/* + * One entry in Xen MPU memory region mapping table(xen_mpumap) is a structure + * of pr_t, which is 16-bytes size, so the entry offset is the order of 4. + */ +#define MPU_ENTRY_SHIFT 0x4 + +#define REGION_SEL_MASK 0xf + +#define REGION_TEXT_PRBAR 0x38 /* SH=11 AP=10 XN=00 */ +#define REGION_RO_PRBAR 0x3A /* SH=11 AP=10 XN=10 */ +#define REGION_DATA_PRBAR 0x32 /* SH=11 AP=00 XN=10 */ + +#define REGION_NORMAL_PRLAR 0x0f /* NS=0 ATTR=111 EN=1 */ + +/* + * Macro to round up the section address to be PAGE_SIZE aligned + * Each section(e.g. .text, .data, etc) in xen.lds.S is page-aligned, + * which is usually guarded with ". = ALIGN(PAGE_SIZE)" in the head, + * or in the end + */ +.macro roundup_section, xb + add \xb, \xb, #(PAGE_SIZE-1) + and \xb, \xb, #PAGE_MASK +.endm + +/* + * Macro to create a new MPU memory region entry, which is a structure + * of pr_t, in \prmap. + * + * Inputs: + * prmap: mpu memory region map table symbol + * sel: region selector + * prbar: preserve value for PRBAR_EL2 + * prlar preserve value for PRLAR_EL2 + * + * Clobbers \tmp1, \tmp2 + * + */ +.macro create_mpu_entry prmap, sel, prbar, prlar, tmp1, tmp2 + mov \tmp2, \sel + lsl \tmp2, \tmp2, #MPU_ENTRY_SHIFT + adr_l \tmp1, \prmap + /* Write the first 8 bytes(prbar_t) of pr_t */ + str \prbar, [\tmp1, \tmp2] + + add \tmp2, \tmp2, #8 + /* Write the last 8 bytes(prlar_t) of pr_t */ + str \prlar, [\tmp1, \tmp2] +.endm + +/* + * Macro to store the maximum number of regions supported by the EL2 MPU + * in max_xen_mpumap, which is identified by MPUIR_EL2. + * + * Outputs: + * nr_regions: preserve the maximum number of regions supported by the EL2 MPU + * + * Clobbers \tmp1 + * + */ +.macro read_max_el2_regions, nr_regions, tmp1 + load_paddr \tmp1, max_xen_mpumap + mrs \nr_regions, MPUIR_EL2 + isb + str \nr_regions, [\tmp1] +.endm + +/* + * Macro to prepare and set a MPU memory region + * + * Inputs: + * base: base address symbol (should be page-aligned) + * limit: limit address symbol + * sel: region selector + * prbar: store computed PRBAR_EL2 value + * prlar: store computed PRLAR_EL2 value + * attr_prbar: PRBAR_EL2-related memory attributes. If not specified it will be REGION_DATA_PRBAR + * attr_prlar: PRLAR_EL2-related memory attributes. If not specified it will be REGION_NORMAL_PRLAR + * + * Clobber \tmp1 + * + */ +.macro prepare_xen_region, base, limit, sel, prbar, prlar, tmp1, attr_prbar=REGION_DATA_PRBAR, attr_prlar=REGION_NORMAL_PRLAR + /* Prepare value for PRBAR_EL2 reg and preserve it in \prbar.*/ + load_paddr \prbar, \base + and \prbar, \prbar, #MPU_REGION_MASK + mov \tmp1, #\attr_prbar + orr \prbar, \prbar, \tmp1 + + /* Prepare value for PRLAR_EL2 reg and preserve it in \prlar.*/ + load_paddr \prlar, \limit + /* Round up limit address to be PAGE_SIZE aligned */ + roundup_section \prlar + /* Limit address should be inclusive */ + sub \prlar, \prlar, #1 + and \prlar, \prlar, #MPU_REGION_MASK + mov \tmp1, #\attr_prlar + orr \prlar, \prlar, \tmp1 + + mov x27, \sel + mov x28, \prbar + mov x29, \prlar + /* + * x27, x28, x29 are special registers designed as + * inputs for function write_pr + */ + bl write_pr +.endm + +.section .text.idmap, "ax", %progbits + +/* + * ENTRY to configure a EL2 MPU memory region + * ARMv8-R AArch64 at most supports 255 MPU protection regions. + * See section G1.3.18 of the reference manual for ARMv8-R AArch64, + * PRBAR_EL2 and PRLAR_EL2 provides access to the EL2 MPU region + * determined by the value of 'n' and PRSELR_EL2.REGION as + * PRSELR_EL2.REGION<7:4>:n.(n = 0, 1, 2, ... , 15) + * For example to access regions from 16 to 31 (0b10000 to 0b11111): + * - Set PRSELR_EL2 to 0b1xxxx + * - Region 16 configuration is accessible through PRBAR0_EL2 and PRLAR0_EL2 + * - Region 17 configuration is accessible through PRBAR1_EL2 and PRLAR1_EL2 + * - Region 18 configuration is accessible through PRBAR2_EL2 and PRLAR2_EL2 + * - ... + * - Region 31 configuration is accessible through PRBAR15_EL2 and PRLAR15_EL2 + * + * Inputs: + * x27: region selector + * x28: preserve value for PRBAR_EL2 + * x29: preserve value for PRLAR_EL2 + * + */ +ENTRY(write_pr) + msr PRSELR_EL2, x27 + dsb sy + and x27, x27, #REGION_SEL_MASK + cmp x27, #0 + bne 1f + msr PRBAR0_EL2, x28 + msr PRLAR0_EL2, x29 + b out +1: + cmp x27, #1 + bne 2f + msr PRBAR1_EL2, x28 + msr PRLAR1_EL2, x29 + b out +2: + cmp x27, #2 + bne 3f + msr PRBAR2_EL2, x28 + msr PRLAR2_EL2, x29 + b out +3: + cmp x27, #3 + bne 4f + msr PRBAR3_EL2, x28 + msr PRLAR3_EL2, x29 + b out +4: + cmp x27, #4 + bne 5f + msr PRBAR4_EL2, x28 + msr PRLAR4_EL2, x29 + b out +5: + cmp x27, #5 + bne 6f + msr PRBAR5_EL2, x28 + msr PRLAR5_EL2, x29 + b out +6: + cmp x27, #6 + bne 7f + msr PRBAR6_EL2, x28 + msr PRLAR6_EL2, x29 + b out +7: + cmp x27, #7 + bne 8f + msr PRBAR7_EL2, x28 + msr PRLAR7_EL2, x29 + b out +8: + cmp x27, #8 + bne 9f + msr PRBAR8_EL2, x28 + msr PRLAR8_EL2, x29 + b out +9: + cmp x27, #9 + bne 10f + msr PRBAR9_EL2, x28 + msr PRLAR9_EL2, x29 + b out +10: + cmp x27, #10 + bne 11f + msr PRBAR10_EL2, x28 + msr PRLAR10_EL2, x29 + b out +11: + cmp x27, #11 + bne 12f + msr PRBAR11_EL2, x28 + msr PRLAR11_EL2, x29 + b out +12: + cmp x27, #12 + bne 13f + msr PRBAR12_EL2, x28 + msr PRLAR12_EL2, x29 + b out +13: + cmp x27, #13 + bne 14f + msr PRBAR13_EL2, x28 + msr PRLAR13_EL2, x29 + b out +14: + cmp x27, #14 + bne 15f + msr PRBAR14_EL2, x28 + msr PRLAR14_EL2, x29 + b out +15: + msr PRBAR15_EL2, x28 + msr PRLAR15_EL2, x29 +out: + isb + ret +ENDPROC(write_pr) + +/* + * Static start-of-day Xen EL2 MPU memory region layout. + * + * xen_mpumap[0] : Xen text + * xen_mpumap[1] : Xen read-only data + * xen_mpumap[2] : Xen read-only after init data + * xen_mpumap[3] : Xen read-write data + * xen_mpumap[4] : Xen BSS + * ...... + * xen_mpumap[max_xen_mpumap - 2]: Xen init data + * xen_mpumap[max_xen_mpumap - 1]: Xen init text + * + * Clobbers x0 - x6 + * + * It shall be compliant with what describes in xen.lds.S, or the below + * codes need adjustment. + * It shall also follow the rules of putting fixed MPU memory region in + * the front, and the others in the rear, which, here, mainly refers to + * boot-only region, like Xen init text region. + */ +ENTRY(prepare_early_mappings) + /* stack LR as write_pr will be called later like nested function */ + mov x6, lr + + /* x0: region sel */ + mov x0, xzr + /* Xen text section. */ + prepare_xen_region _stext, _etext, x0, x1, x2, x3, attr_prbar=REGION_TEXT_PRBAR + create_mpu_entry xen_mpumap, x0, x1, x2, x3, x4 + + add x0, x0, #1 + /* Xen read-only data section. */ + prepare_xen_region _srodata, _erodata, x0, x1, x2, x3, attr_prbar=REGION_RO_PRBAR + create_mpu_entry xen_mpumap, x0, x1, x2, x3, x4 + + add x0, x0, #1 + /* Xen read-only after init data section. */ + prepare_xen_region __ro_after_init_start, __ro_after_init_end, x0, x1, x2, x3 + create_mpu_entry xen_mpumap, x0, x1, x2, x3, x4 + + add x0, x0, #1 + /* Xen read-write data section. */ + prepare_xen_region __data_begin, __init_begin, x0, x1, x2, x3 + create_mpu_entry xen_mpumap, x0, x1, x2, x3, x4 + + read_max_el2_regions x5, x3 /* x5: max_mpumap */ + sub x5, x5, #1 + /* Xen init text section. */ + prepare_xen_region _sinittext, _einittext, x5, x1, x2, x3, attr_prbar=REGION_TEXT_PRBAR + create_mpu_entry xen_mpumap, x5, x1, x2, x3, x4 + + sub x5, x5, #1 + /* Xen init data section. */ + prepare_xen_region __init_data_begin, __init_end, x5, x1, x2, x3 + create_mpu_entry xen_mpumap, x5, x1, x2, x3, x4 + + add x0, x0, #1 + /* Xen BSS section. */ + prepare_xen_region __bss_start, __bss_end, x0, x1, x2, x3 + create_mpu_entry xen_mpumap, x0, x1, x2, x3, x4 + + /* Update next_fixed_region_idx and next_transient_region_idx */ + load_paddr x3, next_fixed_region_idx + add x0, x0, #1 + str x0, [x3] + load_paddr x4, next_transient_region_idx + sub x5, x5, #1 + str x5, [x4] + + mov lr, x6 + ret +ENDPROC(prepare_early_mappings) + +GLOBAL(_end_boot) + +/* + * Local variables: + * mode: ASM + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/arm/include/asm/arm64/mpu.h b/xen/arch/arm/include/asm/arm64/mpu.h new file mode 100644 index 0000000000..c945dd53db --- /dev/null +++ b/xen/arch/arm/include/asm/arm64/mpu.h @@ -0,0 +1,63 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * mpu.h: Arm Memory Protection Region definitions. + */ + +#ifndef __ARM64_MPU_H__ +#define __ARM64_MPU_H__ + +#define MPU_REGION_SHIFT 6 +#define MPU_REGION_ALIGN (_AC(1, UL) << MPU_REGION_SHIFT) +#define MPU_REGION_MASK (~(MPU_REGION_ALIGN - 1)) + +/* + * MPUIR_EL2.Region identifies the number of regions supported by the EL2 MPU. + * It is a 8-bit field, so 255 MPU memory regions at most. + */ +#define ARM_MAX_MPU_MEMORY_REGIONS 255 + +#ifndef __ASSEMBLY__ + +/* Protection Region Base Address Register */ +typedef union { + struct __packed { + unsigned long xn:2; /* Execute-Never */ + unsigned long ap:2; /* Acess Permission */ + unsigned long sh:2; /* Sharebility */ + unsigned long base:42; /* Base Address */ + unsigned long pad:16; + } reg; + uint64_t bits; +} prbar_t; + +/* Protection Region Limit Address Register */ +typedef union { + struct __packed { + unsigned long en:1; /* Region enable */ + unsigned long ai:3; /* Memory Attribute Index */ + unsigned long ns:1; /* Not-Secure */ + unsigned long res:1; /* Reserved 0 by hardware */ + unsigned long limit:42; /* Limit Address */ + unsigned long pad:16; + } reg; + uint64_t bits; +} prlar_t; + +/* MPU Protection Region */ +typedef struct { + prbar_t prbar; + prlar_t prlar; +} pr_t; + +#endif /* __ASSEMBLY__ */ + +#endif /* __ARM64_MPU_H__ */ + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/arm/include/asm/arm64/sysregs.h b/xen/arch/arm/include/asm/arm64/sysregs.h index 4638999514..aca9bca5b1 100644 --- a/xen/arch/arm/include/asm/arm64/sysregs.h +++ b/xen/arch/arm/include/asm/arm64/sysregs.h @@ -458,6 +458,55 @@ #define ZCR_ELx_LEN_SIZE 9 #define ZCR_ELx_LEN_MASK 0x1ff +/* System registers for Armv8-R AArch64 */ +#ifdef CONFIG_HAS_MPU + +/* EL2 MPU Protection Region Base Address Register encode */ +#define PRBAR_EL2 S3_4_C6_C8_0 +#define PRBAR0_EL2 S3_4_C6_C8_0 +#define PRBAR1_EL2 S3_4_C6_C8_4 +#define PRBAR2_EL2 S3_4_C6_C9_0 +#define PRBAR3_EL2 S3_4_C6_C9_4 +#define PRBAR4_EL2 S3_4_C6_C10_0 +#define PRBAR5_EL2 S3_4_C6_C10_4 +#define PRBAR6_EL2 S3_4_C6_C11_0 +#define PRBAR7_EL2 S3_4_C6_C11_4 +#define PRBAR8_EL2 S3_4_C6_C12_0 +#define PRBAR9_EL2 S3_4_C6_C12_4 +#define PRBAR10_EL2 S3_4_C6_C13_0 +#define PRBAR11_EL2 S3_4_C6_C13_4 +#define PRBAR12_EL2 S3_4_C6_C14_0 +#define PRBAR13_EL2 S3_4_C6_C14_4 +#define PRBAR14_EL2 S3_4_C6_C15_0 +#define PRBAR15_EL2 S3_4_C6_C15_4 + +/* EL2 MPU Protection Region Limit Address Register encode */ +#define PRLAR_EL2 S3_4_C6_C8_1 +#define PRLAR0_EL2 S3_4_C6_C8_1 +#define PRLAR1_EL2 S3_4_C6_C8_5 +#define PRLAR2_EL2 S3_4_C6_C9_1 +#define PRLAR3_EL2 S3_4_C6_C9_5 +#define PRLAR4_EL2 S3_4_C6_C10_1 +#define PRLAR5_EL2 S3_4_C6_C10_5 +#define PRLAR6_EL2 S3_4_C6_C11_1 +#define PRLAR7_EL2 S3_4_C6_C11_5 +#define PRLAR8_EL2 S3_4_C6_C12_1 +#define PRLAR9_EL2 S3_4_C6_C12_5 +#define PRLAR10_EL2 S3_4_C6_C13_1 +#define PRLAR11_EL2 S3_4_C6_C13_5 +#define PRLAR12_EL2 S3_4_C6_C14_1 +#define PRLAR13_EL2 S3_4_C6_C14_5 +#define PRLAR14_EL2 S3_4_C6_C15_1 +#define PRLAR15_EL2 S3_4_C6_C15_5 + +/* MPU Protection Region Selection Register encode */ +#define PRSELR_EL2 S3_4_C6_C2_1 + +/* MPU Type registers encode */ +#define MPUIR_EL2 S3_4_C0_C0_4 + +#endif + /* Access to system registers */ #define WRITE_SYSREG64(v, name) do { \ diff --git a/xen/arch/arm/mm_mpu.c b/xen/arch/arm/mm_mpu.c new file mode 100644 index 0000000000..43e9a1be4d --- /dev/null +++ b/xen/arch/arm/mm_mpu.c @@ -0,0 +1,48 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * xen/arch/arm/mm_mpu.c + * + * MPU based memory managment code for Armv8-R AArch64. + * + * Copyright (C) 2022 Arm Ltd. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program. If not, see . + */ + +#include +#include +#include + +/* Xen MPU memory region mapping table. */ +pr_t __aligned(PAGE_SIZE) __section(".data.page_aligned") + xen_mpumap[ARM_MAX_MPU_MEMORY_REGIONS]; + +/* Index into MPU memory region map for fixed regions, ascending from zero. */ +uint64_t __ro_after_init next_fixed_region_idx; +/* + * Index into MPU memory region map for transient regions, like boot-only + * region, which descends from max_xen_mpumap. + */ +uint64_t __ro_after_init next_transient_region_idx; + +/* Maximum number of supported MPU memory regions by the EL2 MPU. */ +uint64_t __ro_after_init max_xen_mpumap; + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S index bc45ea2c65..79965a3c17 100644 --- a/xen/arch/arm/xen.lds.S +++ b/xen/arch/arm/xen.lds.S @@ -91,6 +91,8 @@ SECTIONS __ro_after_init_end = .; } : text + . = ALIGN(PAGE_SIZE); + __data_begin = .; .data.read_mostly : { /* Exception table */ __start___ex_table = .; @@ -157,7 +159,9 @@ SECTIONS *(.altinstr_replacement) } :text . = ALIGN(PAGE_SIZE); + .init.data : { + __init_data_begin = .; /* Init data */ *(.init.rodata) *(.init.rodata.*) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 13 05:35:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 05:35:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476538.738820 (Exim 4.92) (envelope-from ) id 1pGCie-0004cF-Ij; Fri, 13 Jan 2023 05:35:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476538.738820; Fri, 13 Jan 2023 05:35:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCie-0004bk-Cw; Fri, 13 Jan 2023 05:35:12 +0000 Received: by outflank-mailman (input) for mailman id 476538; Fri, 13 Jan 2023 05:35:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCe7-0005sJ-A3 for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 05:30:31 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 649eb9cb-9303-11ed-91b6-6bf2151ebd3b; Fri, 13 Jan 2023 06:30:30 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D6F2813D5; Thu, 12 Jan 2023 21:31:11 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 246403F587; Thu, 12 Jan 2023 21:30:26 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 649eb9cb-9303-11ed-91b6-6bf2151ebd3b From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v2 17/40] xen/mpu: plump virt/maddr/mfn convertion in MPU system Date: Fri, 13 Jan 2023 13:28:50 +0800 Message-Id: <20230113052914.3845596-18-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230113052914.3845596-1-Penny.Zheng@arm.com> References: <20230113052914.3845596-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit virt_to_maddr and maddr_to_virt are used widely in Xen code. So even there is no VMSA in MPU system, we keep the interface name to stay the same code flow. We move the existing virt/maddr convertion from mm.h to mm_mmu.h. And the MPU version of virt/maddr convertion is simple, returning the input address as the output. We should overide virt_to_mfn/mfn_to_virt in source file mm_mpu.c the same way in mm_mmu.c. Signed-off-by: Penny Zheng Signed-off-by: Wei Chen --- xen/arch/arm/include/asm/mm.h | 26 -------------------------- xen/arch/arm/include/asm/mm_mmu.h | 26 ++++++++++++++++++++++++++ xen/arch/arm/include/asm/mm_mpu.h | 13 +++++++++++++ xen/arch/arm/mm_mpu.c | 6 ++++++ 4 files changed, 45 insertions(+), 26 deletions(-) diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h index 9b4c07d965..e29158028a 100644 --- a/xen/arch/arm/include/asm/mm.h +++ b/xen/arch/arm/include/asm/mm.h @@ -250,32 +250,6 @@ static inline void __iomem *ioremap_wc(paddr_t start, size_t len) /* Page-align address and convert to frame number format */ #define paddr_to_pfn_aligned(paddr) paddr_to_pfn(PAGE_ALIGN(paddr)) -static inline paddr_t __virt_to_maddr(vaddr_t va) -{ - uint64_t par = va_to_par(va); - return (par & PADDR_MASK & PAGE_MASK) | (va & ~PAGE_MASK); -} -#define virt_to_maddr(va) __virt_to_maddr((vaddr_t)(va)) - -#ifdef CONFIG_ARM_32 -static inline void *maddr_to_virt(paddr_t ma) -{ - ASSERT(is_xen_heap_mfn(maddr_to_mfn(ma))); - ma -= mfn_to_maddr(directmap_mfn_start); - return (void *)(unsigned long) ma + XENHEAP_VIRT_START; -} -#else -static inline void *maddr_to_virt(paddr_t ma) -{ - ASSERT((mfn_to_pdx(maddr_to_mfn(ma)) - directmap_base_pdx) < - (DIRECTMAP_SIZE >> PAGE_SHIFT)); - return (void *)(XENHEAP_VIRT_START - - (directmap_base_pdx << PAGE_SHIFT) + - ((ma & ma_va_bottom_mask) | - ((ma & ma_top_mask) >> pfn_pdx_hole_shift))); -} -#endif - /* * Translate a guest virtual address to a machine address. * Return the fault information if the translation has failed else 0. diff --git a/xen/arch/arm/include/asm/mm_mmu.h b/xen/arch/arm/include/asm/mm_mmu.h index a5e63d8af8..6d7e5ddde7 100644 --- a/xen/arch/arm/include/asm/mm_mmu.h +++ b/xen/arch/arm/include/asm/mm_mmu.h @@ -23,6 +23,32 @@ extern uint64_t init_ttbr; extern void setup_directmap_mappings(unsigned long base_mfn, unsigned long nr_mfns); +static inline paddr_t __virt_to_maddr(vaddr_t va) +{ + uint64_t par = va_to_par(va); + return (par & PADDR_MASK & PAGE_MASK) | (va & ~PAGE_MASK); +} +#define virt_to_maddr(va) __virt_to_maddr((vaddr_t)(va)) + +#ifdef CONFIG_ARM_32 +static inline void *maddr_to_virt(paddr_t ma) +{ + ASSERT(is_xen_heap_mfn(maddr_to_mfn(ma))); + ma -= mfn_to_maddr(directmap_mfn_start); + return (void *)(unsigned long) ma + XENHEAP_VIRT_START; +} +#else +static inline void *maddr_to_virt(paddr_t ma) +{ + ASSERT((mfn_to_pdx(maddr_to_mfn(ma)) - directmap_base_pdx) < + (DIRECTMAP_SIZE >> PAGE_SHIFT)); + return (void *)(XENHEAP_VIRT_START - + (directmap_base_pdx << PAGE_SHIFT) + + ((ma & ma_va_bottom_mask) | + ((ma & ma_top_mask) >> pfn_pdx_hole_shift))); +} +#endif + #endif /* __ARCH_ARM_MM_MMU__ */ /* diff --git a/xen/arch/arm/include/asm/mm_mpu.h b/xen/arch/arm/include/asm/mm_mpu.h index 1f3cff7743..3a4b07f187 100644 --- a/xen/arch/arm/include/asm/mm_mpu.h +++ b/xen/arch/arm/include/asm/mm_mpu.h @@ -4,6 +4,19 @@ #define setup_mm_mappings(boot_phys_offset) ((void)(boot_phys_offset)) +static inline paddr_t __virt_to_maddr(vaddr_t va) +{ + /* In MPU system, VA == PA. */ + return (paddr_t)va; +} +#define virt_to_maddr(va) __virt_to_maddr((vaddr_t)(va)) + +static inline void *maddr_to_virt(paddr_t ma) +{ + /* In MPU system, VA == PA. */ + return (void *)ma; +} + #endif /* __ARCH_ARM_MM_MPU__ */ /* diff --git a/xen/arch/arm/mm_mpu.c b/xen/arch/arm/mm_mpu.c index 87a12042cc..c9e17ab6da 100644 --- a/xen/arch/arm/mm_mpu.c +++ b/xen/arch/arm/mm_mpu.c @@ -29,6 +29,12 @@ pr_t __aligned(PAGE_SIZE) __section(".data.page_aligned") xen_mpumap[ARM_MAX_MPU_MEMORY_REGIONS]; +/* Override macros from asm/page.h to make them work with mfn_t */ +#undef virt_to_mfn +#define virt_to_mfn(va) _mfn(__virt_to_mfn(va)) +#undef mfn_to_virt +#define mfn_to_virt(mfn) __mfn_to_virt(mfn_x(mfn)) + /* Index into MPU memory region map for fixed regions, ascending from zero. */ uint64_t __ro_after_init next_fixed_region_idx; /* -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 13 05:35:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 05:35:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476541.738852 (Exim 4.92) (envelope-from ) id 1pGCig-0005Km-PZ; Fri, 13 Jan 2023 05:35:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476541.738852; Fri, 13 Jan 2023 05:35:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCig-0005Iy-Ie; Fri, 13 Jan 2023 05:35:14 +0000 Received: by outflank-mailman (input) for mailman id 476541; Fri, 13 Jan 2023 05:35:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCeG-0005sJ-O8 for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 05:30:40 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 6a214224-9303-11ed-91b6-6bf2151ebd3b; Fri, 13 Jan 2023 06:30:39 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3131213D5; Thu, 12 Jan 2023 21:31:21 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 7319F3F587; Thu, 12 Jan 2023 21:30:36 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6a214224-9303-11ed-91b6-6bf2151ebd3b From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v2 20/40] xen/mpu: plump early_fdt_map in MPU systems Date: Fri, 13 Jan 2023 13:28:53 +0800 Message-Id: <20230113052914.3845596-21-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230113052914.3845596-1-Penny.Zheng@arm.com> References: <20230113052914.3845596-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In MPU system, device tree binary can be packed with Xen image through CONFIG_DTB_FILE, or provided by bootloader through x0. In MPU system, each section in xen.lds.S is PAGE_SIZE aligned. So in order to not overlap with the previous BSS section, dtb section should be made page-aligned too. We add . = ALIGN(PAGE_SIZE); in the head of dtb section to make it happen. In this commit, we map early FDT with a transient MPU memory region at rear with REGION_HYPERVISOR_BOOT. Signed-off-by: Penny Zheng Signed-off-by: Wei Chen --- xen/arch/arm/include/asm/arm64/mpu.h | 5 +++ xen/arch/arm/mm_mpu.c | 63 +++++++++++++++++++++++++--- xen/arch/arm/xen.lds.S | 5 ++- 3 files changed, 67 insertions(+), 6 deletions(-) diff --git a/xen/arch/arm/include/asm/arm64/mpu.h b/xen/arch/arm/include/asm/arm64/mpu.h index fcde6ad0db..b85e420a90 100644 --- a/xen/arch/arm/include/asm/arm64/mpu.h +++ b/xen/arch/arm/include/asm/arm64/mpu.h @@ -45,18 +45,22 @@ * [3:4] Execute Never * [5:6] Access Permission * [7] Region Present + * [8] Boot-only Region */ #define _REGION_AI_BIT 0 #define _REGION_XN_BIT 3 #define _REGION_AP_BIT 5 #define _REGION_PRESENT_BIT 7 +#define _REGION_BOOTONLY_BIT 8 #define _REGION_XN (2U << _REGION_XN_BIT) #define _REGION_RO (2U << _REGION_AP_BIT) #define _REGION_PRESENT (1U << _REGION_PRESENT_BIT) +#define _REGION_BOOTONLY (1U << _REGION_BOOTONLY_BIT) #define REGION_AI_MASK(x) (((x) >> _REGION_AI_BIT) & 0x7U) #define REGION_XN_MASK(x) (((x) >> _REGION_XN_BIT) & 0x3U) #define REGION_AP_MASK(x) (((x) >> _REGION_AP_BIT) & 0x3U) #define REGION_RO_MASK(x) (((x) >> _REGION_AP_BIT) & 0x2U) +#define REGION_BOOTONLY_MASK(x) (((x) >> _REGION_BOOTONLY_BIT) & 0x1U) /* * _REGION_NORMAL is convenience define. It is not meant to be used @@ -68,6 +72,7 @@ #define REGION_HYPERVISOR_RO (_REGION_NORMAL|_REGION_XN|_REGION_RO) #define REGION_HYPERVISOR REGION_HYPERVISOR_RW +#define REGION_HYPERVISOR_BOOT (REGION_HYPERVISOR_RW|_REGION_BOOTONLY) #define INVALID_REGION (~0UL) diff --git a/xen/arch/arm/mm_mpu.c b/xen/arch/arm/mm_mpu.c index 08720a7c19..b34dbf4515 100644 --- a/xen/arch/arm/mm_mpu.c +++ b/xen/arch/arm/mm_mpu.c @@ -20,11 +20,16 @@ */ #include +#include #include #include +#include +#include #include #include +#include #include +#include #ifdef NDEBUG static inline void @@ -62,6 +67,8 @@ uint64_t __ro_after_init max_xen_mpumap; static DEFINE_SPINLOCK(xen_mpumap_lock); +static paddr_t dtb_paddr; + /* Write a MPU protection region */ #define WRITE_PROTECTION_REGION(sel, pr, prbar_el2, prlar_el2) ({ \ uint64_t _sel = sel; \ @@ -403,7 +410,16 @@ static int xen_mpumap_update_entry(paddr_t base, paddr_t limit, /* During boot time, the default index is next_fixed_region_idx. */ if ( system_state <= SYS_STATE_active ) - idx = next_fixed_region_idx; + { + /* + * If it is a boot-only region (i.e. region for early FDT), + * it shall be added from the tail for late init re-organizing + */ + if ( REGION_BOOTONLY_MASK(flags) ) + idx = next_transient_region_idx; + else + idx = next_fixed_region_idx; + } xen_mpumap[idx] = pr_of_xenaddr(base, limit - 1, REGION_AI_MASK(flags)); /* Set permission */ @@ -465,14 +481,51 @@ int map_pages_to_xen(unsigned long virt, mfn_to_maddr(mfn_add(mfn, nr_mfns)), flags); } -/* TODO: Implementation on the first usage */ -void dump_hyp_walk(vaddr_t addr) +void * __init early_fdt_map(paddr_t fdt_paddr) { + void *fdt_virt; + uint32_t size; + + /* + * Check whether the physical FDT address is set and meets the minimum + * alignment requirement. Since we are relying on MIN_FDT_ALIGN to be at + * least 8 bytes so that we always access the magic and size fields + * of the FDT header after mapping the first chunk, double check if + * that is indeed the case. + */ + BUILD_BUG_ON(MIN_FDT_ALIGN < 8); + if ( !fdt_paddr || fdt_paddr % MIN_FDT_ALIGN ) + return NULL; + + dtb_paddr = fdt_paddr; + /* + * In MPU system, device tree binary can be packed with Xen image + * through CONFIG_DTB_FILE, or provided by bootloader through x0. + * Map FDT with a transient MPU memory region of MAX_FDT_SIZE. + * After that, we can do some magic check. + */ + if ( map_pages_to_xen(round_pgdown(fdt_paddr), + maddr_to_mfn(round_pgdown(fdt_paddr)), + round_pgup(MAX_FDT_SIZE) >> PAGE_SHIFT, + REGION_HYPERVISOR_BOOT) ) + panic("Unable to map the device-tree.\n"); + + /* VA == PA */ + fdt_virt = maddr_to_virt(fdt_paddr); + + if ( fdt_magic(fdt_virt) != FDT_MAGIC ) + return NULL; + + size = fdt_totalsize(fdt_virt); + if ( size > MAX_FDT_SIZE ) + return NULL; + + return fdt_virt; } -void * __init early_fdt_map(paddr_t fdt_paddr) +/* TODO: Implementation on the first usage */ +void dump_hyp_walk(vaddr_t addr) { - return NULL; } void __init remove_early_mappings(void) diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S index 79965a3c17..0565e22a1f 100644 --- a/xen/arch/arm/xen.lds.S +++ b/xen/arch/arm/xen.lds.S @@ -218,7 +218,10 @@ SECTIONS _end = . ; /* Section for the device tree blob (if any). */ - .dtb : { *(.dtb) } :text + .dtb : { + . = ALIGN(PAGE_SIZE); + *(.dtb) + } :text DWARF2_DEBUG_SECTIONS -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 13 05:35:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 05:35:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476539.738826 (Exim 4.92) (envelope-from ) id 1pGCie-0004kC-Rt; Fri, 13 Jan 2023 05:35:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476539.738826; Fri, 13 Jan 2023 05:35:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCie-0004hh-Mb; Fri, 13 Jan 2023 05:35:12 +0000 Received: by outflank-mailman (input) for mailman id 476539; Fri, 13 Jan 2023 05:35:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCe7-0005sP-2P for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 05:30:31 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 62be1f31-9303-11ed-b8d0-410ff93cb8f0; Fri, 13 Jan 2023 06:30:27 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BCB2013D5; Thu, 12 Jan 2023 21:31:08 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 0A5563F587; Thu, 12 Jan 2023 21:30:23 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 62be1f31-9303-11ed-b8d0-410ff93cb8f0 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v2 16/40] xen/arm: introduce setup_mm_mappings Date: Fri, 13 Jan 2023 13:28:49 +0800 Message-Id: <20230113052914.3845596-17-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230113052914.3845596-1-Penny.Zheng@arm.com> References: <20230113052914.3845596-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Function setup_pagetables is responsible for boot-time pagetable setup in MMU system. But in MPU system, we have already built up start-of-day Xen MPU memory region mapping at the very beginning in assembly. So in order to keep only one codeflow in arm/setup.c, setup_mm_mappings , with a more generic name, is introduced and act as an empty stub in MPU system. Signed-off-by: Penny Zheng Signed-off-by: Wei Chen --- xen/arch/arm/include/asm/mm.h | 2 ++ xen/arch/arm/include/asm/mm_mpu.h | 16 ++++++++++++++++ xen/arch/arm/setup.c | 2 +- 3 files changed, 19 insertions(+), 1 deletion(-) create mode 100644 xen/arch/arm/include/asm/mm_mpu.h diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h index 1b9fdb6ff5..9b4c07d965 100644 --- a/xen/arch/arm/include/asm/mm.h +++ b/xen/arch/arm/include/asm/mm.h @@ -243,6 +243,8 @@ static inline void __iomem *ioremap_wc(paddr_t start, size_t len) #ifndef CONFIG_HAS_MPU #include +#else +#include #endif /* Page-align address and convert to frame number format */ diff --git a/xen/arch/arm/include/asm/mm_mpu.h b/xen/arch/arm/include/asm/mm_mpu.h new file mode 100644 index 0000000000..1f3cff7743 --- /dev/null +++ b/xen/arch/arm/include/asm/mm_mpu.h @@ -0,0 +1,16 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +#ifndef __ARCH_ARM_MM_MPU__ +#define __ARCH_ARM_MM_MPU__ + +#define setup_mm_mappings(boot_phys_offset) ((void)(boot_phys_offset)) + +#endif /* __ARCH_ARM_MM_MPU__ */ + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 1f26f67b90..d7d200179c 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -1003,7 +1003,7 @@ void __init start_xen(unsigned long boot_phys_offset, /* Initialize traps early allow us to get backtrace when an error occurred */ init_traps(); - setup_pagetables(boot_phys_offset); + setup_mm_mappings(boot_phys_offset); smp_clear_cpu_maps(); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 13 05:35:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 05:35:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476537.738814 (Exim 4.92) (envelope-from ) id 1pGCie-0004Xv-8Y; Fri, 13 Jan 2023 05:35:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476537.738814; Fri, 13 Jan 2023 05:35:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCie-0004Xo-4p; Fri, 13 Jan 2023 05:35:12 +0000 Received: by outflank-mailman (input) for mailman id 476537; Fri, 13 Jan 2023 05:35:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCe6-0005sP-22 for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 05:30:30 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 60f1f780-9303-11ed-b8d0-410ff93cb8f0; Fri, 13 Jan 2023 06:30:24 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A2B5AFEC; Thu, 12 Jan 2023 21:31:05 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id A4D773F587; Thu, 12 Jan 2023 21:30:20 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 60f1f780-9303-11ed-b8d0-410ff93cb8f0 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v2 15/40] xen/arm: move MMU-specific memory management code to mm_mmu.c/mm_mmu.h Date: Fri, 13 Jan 2023 13:28:48 +0800 Message-Id: <20230113052914.3845596-16-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230113052914.3845596-1-Penny.Zheng@arm.com> References: <20230113052914.3845596-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Wei Chen To make the code readable and maintainable, we move MMU-specific memory management code from mm.c to mm_mmu.c and move MMU-specific definitions from mm.h to mm_mmu.h. Later we will create mm_mpu.h and mm_mpu.c for MPU-specific memory management code. This will avoid lots of #ifdef in memory management code and header files. Signed-off-by: Wei Chen Signed-off-by: Penny Zheng --- xen/arch/arm/Makefile | 5 + xen/arch/arm/include/asm/mm.h | 19 +- xen/arch/arm/include/asm/mm_mmu.h | 35 + xen/arch/arm/mm.c | 1352 +--------------------------- xen/arch/arm/mm_mmu.c | 1376 +++++++++++++++++++++++++++++ xen/arch/arm/mm_mpu.c | 67 ++ 6 files changed, 1488 insertions(+), 1366 deletions(-) create mode 100644 xen/arch/arm/include/asm/mm_mmu.h create mode 100644 xen/arch/arm/mm_mmu.c diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile index 4d076b278b..21188b207f 100644 --- a/xen/arch/arm/Makefile +++ b/xen/arch/arm/Makefile @@ -37,6 +37,11 @@ obj-y += kernel.init.o obj-$(CONFIG_LIVEPATCH) += livepatch.o obj-y += mem_access.o obj-y += mm.o +ifneq ($(CONFIG_HAS_MPU), y) +obj-y += mm_mmu.o +else +obj-y += mm_mpu.o +endif obj-y += monitor.o obj-y += p2m.o obj-y += percpu.o diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h index 68adcac9fa..1b9fdb6ff5 100644 --- a/xen/arch/arm/include/asm/mm.h +++ b/xen/arch/arm/include/asm/mm.h @@ -154,13 +154,6 @@ struct page_info #define _PGC_need_scrub _PGC_allocated #define PGC_need_scrub PGC_allocated -extern mfn_t directmap_mfn_start, directmap_mfn_end; -extern vaddr_t directmap_virt_end; -#ifdef CONFIG_ARM_64 -extern vaddr_t directmap_virt_start; -extern unsigned long directmap_base_pdx; -#endif - #ifdef CONFIG_ARM_32 #define is_xen_heap_page(page) is_xen_heap_mfn(page_to_mfn(page)) #define is_xen_heap_mfn(mfn) ({ \ @@ -192,8 +185,6 @@ extern unsigned long total_pages; #define PDX_GROUP_SHIFT SECOND_SHIFT -/* Boot-time pagetable setup */ -extern void setup_pagetables(unsigned long boot_phys_offset); /* Map FDT in boot pagetable */ extern void *early_fdt_map(paddr_t fdt_paddr); /* Remove early mappings */ @@ -203,12 +194,6 @@ extern void remove_early_mappings(void); extern int init_secondary_pagetables(int cpu); /* Switch secondary CPUS to its own pagetables and finalise MMU setup */ extern void mmu_init_secondary_cpu(void); -/* - * For Arm32, set up the direct-mapped xenheap: up to 1GB of contiguous, - * always-mapped memory. Base must be 32MB aligned and size a multiple of 32MB. - * For Arm64, map the region in the directmap area. - */ -extern void setup_directmap_mappings(unsigned long base_mfn, unsigned long nr_mfns); /* Map a frame table to cover physical addresses ps through pe */ extern void setup_frametable_mappings(paddr_t ps, paddr_t pe); /* map a physical range in virtual memory */ @@ -256,6 +241,10 @@ static inline void __iomem *ioremap_wc(paddr_t start, size_t len) #define vmap_to_mfn(va) maddr_to_mfn(virt_to_maddr((vaddr_t)va)) #define vmap_to_page(va) mfn_to_page(vmap_to_mfn(va)) +#ifndef CONFIG_HAS_MPU +#include +#endif + /* Page-align address and convert to frame number format */ #define paddr_to_pfn_aligned(paddr) paddr_to_pfn(PAGE_ALIGN(paddr)) diff --git a/xen/arch/arm/include/asm/mm_mmu.h b/xen/arch/arm/include/asm/mm_mmu.h new file mode 100644 index 0000000000..a5e63d8af8 --- /dev/null +++ b/xen/arch/arm/include/asm/mm_mmu.h @@ -0,0 +1,35 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +#ifndef __ARCH_ARM_MM_MMU__ +#define __ARCH_ARM_MM_MMU__ + +extern mfn_t directmap_mfn_start, directmap_mfn_end; +extern vaddr_t directmap_virt_end; +#ifdef CONFIG_ARM_64 +extern vaddr_t directmap_virt_start; +extern unsigned long directmap_base_pdx; +#endif + +/* Boot-time pagetable setup */ +extern void setup_pagetables(unsigned long boot_phys_offset); +#define setup_mm_mappings(boot_phys_offset) setup_pagetables(boot_phys_offset) + +/* Non-boot CPUs use this to find the correct pagetables. */ +extern uint64_t init_ttbr; +/* + * For Arm32, set up the direct-mapped xenheap: up to 1GB of contiguous, + * always-mapped memory. Base must be 32MB aligned and size a multiple of 32MB. + * For Arm64, map the region in the directmap area. + */ +extern void setup_directmap_mappings(unsigned long base_mfn, + unsigned long nr_mfns); + +#endif /* __ARCH_ARM_MM_MMU__ */ + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index 8f15814c5e..e1ce2a62dc 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -2,371 +2,24 @@ /* * xen/arch/arm/mm.c * - * MMU code for an ARMv7-A with virt extensions. + * Memory management common code for MMU and MPU system. * * Tim Deegan * Copyright (c) 2011 Citrix Systems. */ #include -#include #include -#include -#include -#include -#include -#include -#include #include -#include #include -#include #include -#include -#include - -#include - -/* Override macros from asm/page.h to make them work with mfn_t */ -#undef virt_to_mfn -#define virt_to_mfn(va) _mfn(__virt_to_mfn(va)) -#undef mfn_to_virt -#define mfn_to_virt(mfn) __mfn_to_virt(mfn_x(mfn)) - -#ifdef NDEBUG -static inline void -__attribute__ ((__format__ (__printf__, 1, 2))) -mm_printk(const char *fmt, ...) {} -#else -#define mm_printk(fmt, args...) \ - do \ - { \ - dprintk(XENLOG_ERR, fmt, ## args); \ - WARN(); \ - } while (0) -#endif - -/* Static start-of-day pagetables that we use before the allocators - * are up. These are used by all CPUs during bringup before switching - * to the CPUs own pagetables. - * - * These pagetables have a very simple structure. They include: - * - 2MB worth of 4K mappings of xen at XEN_VIRT_START, boot_first and - * boot_second are used to populate the tables down to boot_third - * which contains the actual mapping. - * - a 1:1 mapping of xen at its current physical address. This uses a - * section mapping at whichever of boot_{pgtable,first,second} - * covers that physical address. - * - * For the boot CPU these mappings point to the address where Xen was - * loaded by the bootloader. For secondary CPUs they point to the - * relocated copy of Xen for the benefit of secondary CPUs. - * - * In addition to the above for the boot CPU the device-tree is - * initially mapped in the boot misc slot. This mapping is not present - * for secondary CPUs. - * - * Finally, if EARLY_PRINTK is enabled then xen_fixmap will be mapped - * by the CPU once it has moved off the 1:1 mapping. - */ -DEFINE_BOOT_PAGE_TABLE(boot_pgtable); -#ifdef CONFIG_ARM_64 -DEFINE_BOOT_PAGE_TABLE(boot_first); -DEFINE_BOOT_PAGE_TABLE(boot_first_id); -#endif -DEFINE_BOOT_PAGE_TABLE(boot_second_id); -DEFINE_BOOT_PAGE_TABLE(boot_third_id); -DEFINE_BOOT_PAGE_TABLE(boot_second); -DEFINE_BOOT_PAGE_TABLE(boot_third); - -/* Main runtime page tables */ - -/* - * For arm32 xen_pgtable are per-PCPU and are allocated before - * bringing up each CPU. For arm64 xen_pgtable is common to all PCPUs. - * - * xen_second, xen_fixmap and xen_xenmap are always shared between all - * PCPUs. - */ - -#ifdef CONFIG_ARM_64 -#define HYP_PT_ROOT_LEVEL 0 -static DEFINE_PAGE_TABLE(xen_pgtable); -static DEFINE_PAGE_TABLE(xen_first); -#define THIS_CPU_PGTABLE xen_pgtable -#else -#define HYP_PT_ROOT_LEVEL 1 -/* Per-CPU pagetable pages */ -/* xen_pgtable == root of the trie (zeroeth level on 64-bit, first on 32-bit) */ -DEFINE_PER_CPU(lpae_t *, xen_pgtable); -#define THIS_CPU_PGTABLE this_cpu(xen_pgtable) -/* Root of the trie for cpu0, other CPU's PTs are dynamically allocated */ -static DEFINE_PAGE_TABLE(cpu0_pgtable); -#endif - -/* Common pagetable leaves */ -/* Second level page table used to cover Xen virtual address space */ -static DEFINE_PAGE_TABLE(xen_second); -/* Third level page table used for fixmap */ -DEFINE_BOOT_PAGE_TABLE(xen_fixmap); -/* - * Third level page table used to map Xen itself with the XN bit set - * as appropriate. - */ -static DEFINE_PAGE_TABLE(xen_xenmap); - -/* Non-boot CPUs use this to find the correct pagetables. */ -uint64_t init_ttbr; - -static paddr_t phys_offset; - -/* Limits of the Xen heap */ -mfn_t directmap_mfn_start __read_mostly = INVALID_MFN_INITIALIZER; -mfn_t directmap_mfn_end __read_mostly; -vaddr_t directmap_virt_end __read_mostly; -#ifdef CONFIG_ARM_64 -vaddr_t directmap_virt_start __read_mostly; -unsigned long directmap_base_pdx __read_mostly; -#endif - unsigned long frametable_base_pdx __read_mostly; -unsigned long frametable_virt_end __read_mostly; unsigned long max_page; unsigned long total_pages; -extern char __init_begin[], __init_end[]; - -/* Checking VA memory layout alignment. */ -static void __init __maybe_unused build_assertions(void) -{ - /* 2MB aligned regions */ - BUILD_BUG_ON(XEN_VIRT_START & ~SECOND_MASK); - BUILD_BUG_ON(FIXMAP_ADDR(0) & ~SECOND_MASK); - /* 1GB aligned regions */ -#ifdef CONFIG_ARM_32 - BUILD_BUG_ON(XENHEAP_VIRT_START & ~FIRST_MASK); -#else - BUILD_BUG_ON(DIRECTMAP_VIRT_START & ~FIRST_MASK); -#endif - /* Page table structure constraints */ -#ifdef CONFIG_ARM_64 - BUILD_BUG_ON(zeroeth_table_offset(XEN_VIRT_START)); -#endif - BUILD_BUG_ON(first_table_offset(XEN_VIRT_START)); -#ifdef CONFIG_ARCH_MAP_DOMAIN_PAGE - BUILD_BUG_ON(DOMHEAP_VIRT_START & ~FIRST_MASK); -#endif - /* - * The boot code expects the regions XEN_VIRT_START, FIXMAP_ADDR(0), - * BOOT_FDT_VIRT_START to use the same 0th (arm64 only) and 1st - * slot in the page tables. - */ -#define CHECK_SAME_SLOT(level, virt1, virt2) \ - BUILD_BUG_ON(level##_table_offset(virt1) != level##_table_offset(virt2)) - -#ifdef CONFIG_ARM_64 - CHECK_SAME_SLOT(zeroeth, XEN_VIRT_START, FIXMAP_ADDR(0)); - CHECK_SAME_SLOT(zeroeth, XEN_VIRT_START, BOOT_FDT_VIRT_START); -#endif - CHECK_SAME_SLOT(first, XEN_VIRT_START, FIXMAP_ADDR(0)); - CHECK_SAME_SLOT(first, XEN_VIRT_START, BOOT_FDT_VIRT_START); - -#undef CHECK_SAME_SLOT -} - -static lpae_t *xen_map_table(mfn_t mfn) -{ - /* - * During early boot, map_domain_page() may be unusable. Use the - * PMAP to map temporarily a page-table. - */ - if ( system_state == SYS_STATE_early_boot ) - return pmap_map(mfn); - - return map_domain_page(mfn); -} - -static void xen_unmap_table(const lpae_t *table) -{ - /* - * During early boot, xen_map_table() will not use map_domain_page() - * but the PMAP. - */ - if ( system_state == SYS_STATE_early_boot ) - pmap_unmap(table); - else - unmap_domain_page(table); -} - -void dump_pt_walk(paddr_t ttbr, paddr_t addr, - unsigned int root_level, - unsigned int nr_root_tables) -{ - static const char *level_strs[4] = { "0TH", "1ST", "2ND", "3RD" }; - const mfn_t root_mfn = maddr_to_mfn(ttbr); - const unsigned int offsets[4] = { - zeroeth_table_offset(addr), - first_table_offset(addr), - second_table_offset(addr), - third_table_offset(addr) - }; - lpae_t pte, *mapping; - unsigned int level, root_table; - -#ifdef CONFIG_ARM_32 - BUG_ON(root_level < 1); -#endif - BUG_ON(root_level > 3); - - if ( nr_root_tables > 1 ) - { - /* - * Concatenated root-level tables. The table number will be - * the offset at the previous level. It is not possible to - * concatenate a level-0 root. - */ - BUG_ON(root_level == 0); - root_table = offsets[root_level - 1]; - printk("Using concatenated root table %u\n", root_table); - if ( root_table >= nr_root_tables ) - { - printk("Invalid root table offset\n"); - return; - } - } - else - root_table = 0; - - mapping = xen_map_table(mfn_add(root_mfn, root_table)); - - for ( level = root_level; ; level++ ) - { - if ( offsets[level] > XEN_PT_LPAE_ENTRIES ) - break; - - pte = mapping[offsets[level]]; - - printk("%s[0x%03x] = 0x%"PRIpaddr"\n", - level_strs[level], offsets[level], pte.bits); - - if ( level == 3 || !pte.walk.valid || !pte.walk.table ) - break; - - /* For next iteration */ - xen_unmap_table(mapping); - mapping = xen_map_table(lpae_get_mfn(pte)); - } - - xen_unmap_table(mapping); -} - -void dump_hyp_walk(vaddr_t addr) -{ - uint64_t ttbr = READ_SYSREG64(TTBR0_EL2); - - printk("Walking Hypervisor VA 0x%"PRIvaddr" " - "on CPU%d via TTBR 0x%016"PRIx64"\n", - addr, smp_processor_id(), ttbr); - - dump_pt_walk(ttbr, addr, HYP_PT_ROOT_LEVEL, 1); -} - -lpae_t mfn_to_xen_entry(mfn_t mfn, unsigned int attr) -{ - lpae_t e = (lpae_t) { - .pt = { - .valid = 1, /* Mappings are present */ - .table = 0, /* Set to 1 for links and 4k maps */ - .ai = attr, - .ns = 1, /* Hyp mode is in the non-secure world */ - .up = 1, /* See below */ - .ro = 0, /* Assume read-write */ - .af = 1, /* No need for access tracking */ - .ng = 1, /* Makes TLB flushes easier */ - .contig = 0, /* Assume non-contiguous */ - .xn = 1, /* No need to execute outside .text */ - .avail = 0, /* Reference count for domheap mapping */ - }}; - /* - * For EL2 stage-1 page table, up (aka AP[1]) is RES1 as the translation - * regime applies to only one exception level (see D4.4.4 and G4.6.1 - * in ARM DDI 0487B.a). If this changes, remember to update the - * hard-coded values in head.S too. - */ - - switch ( attr ) - { - case MT_NORMAL_NC: - /* - * ARM ARM: Overlaying the shareability attribute (DDI - * 0406C.b B3-1376 to 1377) - * - * A memory region with a resultant memory type attribute of Normal, - * and a resultant cacheability attribute of Inner Non-cacheable, - * Outer Non-cacheable, must have a resultant shareability attribute - * of Outer Shareable, otherwise shareability is UNPREDICTABLE. - * - * On ARMv8 sharability is ignored and explicitly treated as Outer - * Shareable for Normal Inner Non_cacheable, Outer Non-cacheable. - */ - e.pt.sh = LPAE_SH_OUTER; - break; - case MT_DEVICE_nGnRnE: - case MT_DEVICE_nGnRE: - /* - * Shareability is ignored for non-Normal memory, Outer is as - * good as anything. - * - * On ARMv8 sharability is ignored and explicitly treated as Outer - * Shareable for any device memory type. - */ - e.pt.sh = LPAE_SH_OUTER; - break; - default: - e.pt.sh = LPAE_SH_INNER; /* Xen mappings are SMP coherent */ - break; - } - - ASSERT(!(mfn_to_maddr(mfn) & ~PADDR_MASK)); - - lpae_set_mfn(e, mfn); - - return e; -} - -/* Map a 4k page in a fixmap entry */ -void set_fixmap(unsigned int map, mfn_t mfn, unsigned int flags) -{ - int res; - - res = map_pages_to_xen(FIXMAP_ADDR(map), mfn, 1, flags); - BUG_ON(res != 0); -} - -/* Remove a mapping from a fixmap entry */ -void clear_fixmap(unsigned int map) -{ - int res; - - res = destroy_xen_mappings(FIXMAP_ADDR(map), FIXMAP_ADDR(map) + PAGE_SIZE); - BUG_ON(res != 0); -} - -void *map_page_to_xen_misc(mfn_t mfn, unsigned int attributes) -{ - set_fixmap(FIXMAP_MISC, mfn, attributes); - - return fix_to_virt(FIXMAP_MISC); -} - -void unmap_page_from_xen_misc(void) -{ - clear_fixmap(FIXMAP_MISC); -} - void flush_page_to_ram(unsigned long mfn, bool sync_icache) { void *v = map_domain_page(_mfn(mfn)); @@ -386,878 +39,6 @@ void flush_page_to_ram(unsigned long mfn, bool sync_icache) invalidate_icache(); } -static inline lpae_t pte_of_xenaddr(vaddr_t va) -{ - paddr_t ma = va + phys_offset; - - return mfn_to_xen_entry(maddr_to_mfn(ma), MT_NORMAL); -} - -void * __init early_fdt_map(paddr_t fdt_paddr) -{ - /* We are using 2MB superpage for mapping the FDT */ - paddr_t base_paddr = fdt_paddr & SECOND_MASK; - paddr_t offset; - void *fdt_virt; - uint32_t size; - int rc; - - /* - * Check whether the physical FDT address is set and meets the minimum - * alignment requirement. Since we are relying on MIN_FDT_ALIGN to be at - * least 8 bytes so that we always access the magic and size fields - * of the FDT header after mapping the first chunk, double check if - * that is indeed the case. - */ - BUILD_BUG_ON(MIN_FDT_ALIGN < 8); - if ( !fdt_paddr || fdt_paddr % MIN_FDT_ALIGN ) - return NULL; - - /* The FDT is mapped using 2MB superpage */ - BUILD_BUG_ON(BOOT_FDT_VIRT_START % SZ_2M); - - rc = map_pages_to_xen(BOOT_FDT_VIRT_START, maddr_to_mfn(base_paddr), - SZ_2M >> PAGE_SHIFT, - PAGE_HYPERVISOR_RO | _PAGE_BLOCK); - if ( rc ) - panic("Unable to map the device-tree.\n"); - - - offset = fdt_paddr % SECOND_SIZE; - fdt_virt = (void *)BOOT_FDT_VIRT_START + offset; - - if ( fdt_magic(fdt_virt) != FDT_MAGIC ) - return NULL; - - size = fdt_totalsize(fdt_virt); - if ( size > MAX_FDT_SIZE ) - return NULL; - - if ( (offset + size) > SZ_2M ) - { - rc = map_pages_to_xen(BOOT_FDT_VIRT_START + SZ_2M, - maddr_to_mfn(base_paddr + SZ_2M), - SZ_2M >> PAGE_SHIFT, - PAGE_HYPERVISOR_RO | _PAGE_BLOCK); - if ( rc ) - panic("Unable to map the device-tree\n"); - } - - return fdt_virt; -} - -void __init remove_early_mappings(void) -{ - int rc; - - /* destroy the _PAGE_BLOCK mapping */ - rc = modify_xen_mappings(BOOT_FDT_VIRT_START, - BOOT_FDT_VIRT_START + BOOT_FDT_VIRT_SIZE, - _PAGE_BLOCK); - BUG_ON(rc); -} - -/* - * After boot, Xen page-tables should not contain mapping that are both - * Writable and eXecutables. - * - * This should be called on each CPU to enforce the policy. - */ -static void xen_pt_enforce_wnx(void) -{ - WRITE_SYSREG(READ_SYSREG(SCTLR_EL2) | SCTLR_Axx_ELx_WXN, SCTLR_EL2); - /* - * The TLBs may cache SCTLR_EL2.WXN. So ensure it is synchronized - * before flushing the TLBs. - */ - isb(); - flush_xen_tlb_local(); -} - -extern void switch_ttbr(uint64_t ttbr); - -/* Clear a translation table and clean & invalidate the cache */ -static void clear_table(void *table) -{ - clear_page(table); - clean_and_invalidate_dcache_va_range(table, PAGE_SIZE); -} - -/* Boot-time pagetable setup. - * Changes here may need matching changes in head.S */ -void __init setup_pagetables(unsigned long boot_phys_offset) -{ - uint64_t ttbr; - lpae_t pte, *p; - int i; - - phys_offset = boot_phys_offset; - -#ifdef CONFIG_ARM_64 - p = (void *) xen_pgtable; - p[0] = pte_of_xenaddr((uintptr_t)xen_first); - p[0].pt.table = 1; - p[0].pt.xn = 0; - p = (void *) xen_first; -#else - p = (void *) cpu0_pgtable; -#endif - - /* Map xen second level page-table */ - p[0] = pte_of_xenaddr((uintptr_t)(xen_second)); - p[0].pt.table = 1; - p[0].pt.xn = 0; - - /* Break up the Xen mapping into 4k pages and protect them separately. */ - for ( i = 0; i < XEN_PT_LPAE_ENTRIES; i++ ) - { - vaddr_t va = XEN_VIRT_START + (i << PAGE_SHIFT); - - if ( !is_kernel(va) ) - break; - pte = pte_of_xenaddr(va); - pte.pt.table = 1; /* 4k mappings always have this bit set */ - if ( is_kernel_text(va) || is_kernel_inittext(va) ) - { - pte.pt.xn = 0; - pte.pt.ro = 1; - } - if ( is_kernel_rodata(va) ) - pte.pt.ro = 1; - xen_xenmap[i] = pte; - } - - /* Initialise xen second level entries ... */ - /* ... Xen's text etc */ - - pte = pte_of_xenaddr((vaddr_t)xen_xenmap); - pte.pt.table = 1; - xen_second[second_table_offset(XEN_VIRT_START)] = pte; - - /* ... Fixmap */ - pte = pte_of_xenaddr((vaddr_t)xen_fixmap); - pte.pt.table = 1; - xen_second[second_table_offset(FIXMAP_ADDR(0))] = pte; - -#ifdef CONFIG_ARM_64 - ttbr = (uintptr_t) xen_pgtable + phys_offset; -#else - ttbr = (uintptr_t) cpu0_pgtable + phys_offset; -#endif - - switch_ttbr(ttbr); - - xen_pt_enforce_wnx(); - -#ifdef CONFIG_ARM_32 - per_cpu(xen_pgtable, 0) = cpu0_pgtable; -#endif -} - -static void clear_boot_pagetables(void) -{ - /* - * Clear the copy of the boot pagetables. Each secondary CPU - * rebuilds these itself (see head.S). - */ - clear_table(boot_pgtable); -#ifdef CONFIG_ARM_64 - clear_table(boot_first); - clear_table(boot_first_id); -#endif - clear_table(boot_second); - clear_table(boot_third); -} - -#ifdef CONFIG_ARM_64 -int init_secondary_pagetables(int cpu) -{ - clear_boot_pagetables(); - - /* Set init_ttbr for this CPU coming up. All CPus share a single setof - * pagetables, but rewrite it each time for consistency with 32 bit. */ - init_ttbr = (uintptr_t) xen_pgtable + phys_offset; - clean_dcache(init_ttbr); - return 0; -} -#else -int init_secondary_pagetables(int cpu) -{ - lpae_t *first; - - first = alloc_xenheap_page(); /* root == first level on 32-bit 3-level trie */ - - if ( !first ) - { - printk("CPU%u: Unable to allocate the first page-table\n", cpu); - return -ENOMEM; - } - - /* Initialise root pagetable from root of boot tables */ - memcpy(first, cpu0_pgtable, PAGE_SIZE); - per_cpu(xen_pgtable, cpu) = first; - - if ( !init_domheap_mappings(cpu) ) - { - printk("CPU%u: Unable to prepare the domheap page-tables\n", cpu); - per_cpu(xen_pgtable, cpu) = NULL; - free_xenheap_page(first); - return -ENOMEM; - } - - clear_boot_pagetables(); - - /* Set init_ttbr for this CPU coming up */ - init_ttbr = __pa(first); - clean_dcache(init_ttbr); - - return 0; -} -#endif - -/* MMU setup for secondary CPUS (which already have paging enabled) */ -void mmu_init_secondary_cpu(void) -{ - xen_pt_enforce_wnx(); -} - -#ifdef CONFIG_ARM_32 -/* - * Set up the direct-mapped xenheap: - * up to 1GB of contiguous, always-mapped memory. - */ -void __init setup_directmap_mappings(unsigned long base_mfn, - unsigned long nr_mfns) -{ - int rc; - - rc = map_pages_to_xen(XENHEAP_VIRT_START, _mfn(base_mfn), nr_mfns, - PAGE_HYPERVISOR_RW | _PAGE_BLOCK); - if ( rc ) - panic("Unable to setup the directmap mappings.\n"); - - /* Record where the directmap is, for translation routines. */ - directmap_virt_end = XENHEAP_VIRT_START + nr_mfns * PAGE_SIZE; -} -#else /* CONFIG_ARM_64 */ -/* Map the region in the directmap area. */ -void __init setup_directmap_mappings(unsigned long base_mfn, - unsigned long nr_mfns) -{ - int rc; - - /* First call sets the directmap physical and virtual offset. */ - if ( mfn_eq(directmap_mfn_start, INVALID_MFN) ) - { - unsigned long mfn_gb = base_mfn & ~((FIRST_SIZE >> PAGE_SHIFT) - 1); - - directmap_mfn_start = _mfn(base_mfn); - directmap_base_pdx = mfn_to_pdx(_mfn(base_mfn)); - /* - * The base address may not be aligned to the first level - * size (e.g. 1GB when using 4KB pages). This would prevent - * superpage mappings for all the regions because the virtual - * address and machine address should both be suitably aligned. - * - * Prevent that by offsetting the start of the directmap virtual - * address. - */ - directmap_virt_start = DIRECTMAP_VIRT_START + - (base_mfn - mfn_gb) * PAGE_SIZE; - } - - if ( base_mfn < mfn_x(directmap_mfn_start) ) - panic("cannot add directmap mapping at %lx below heap start %lx\n", - base_mfn, mfn_x(directmap_mfn_start)); - - rc = map_pages_to_xen((vaddr_t)__mfn_to_virt(base_mfn), - _mfn(base_mfn), nr_mfns, - PAGE_HYPERVISOR_RW | _PAGE_BLOCK); - if ( rc ) - panic("Unable to setup the directmap mappings.\n"); -} -#endif - -/* Map a frame table to cover physical addresses ps through pe */ -void __init setup_frametable_mappings(paddr_t ps, paddr_t pe) -{ - unsigned long nr_pdxs = mfn_to_pdx(mfn_add(maddr_to_mfn(pe), -1)) - - mfn_to_pdx(maddr_to_mfn(ps)) + 1; - unsigned long frametable_size = nr_pdxs * sizeof(struct page_info); - mfn_t base_mfn; - const unsigned long mapping_size = frametable_size < MB(32) ? MB(2) : MB(32); - int rc; - - frametable_base_pdx = mfn_to_pdx(maddr_to_mfn(ps)); - /* Round up to 2M or 32M boundary, as appropriate. */ - frametable_size = ROUNDUP(frametable_size, mapping_size); - base_mfn = alloc_boot_pages(frametable_size >> PAGE_SHIFT, 32<<(20-12)); - - rc = map_pages_to_xen(FRAMETABLE_VIRT_START, base_mfn, - frametable_size >> PAGE_SHIFT, - PAGE_HYPERVISOR_RW | _PAGE_BLOCK); - if ( rc ) - panic("Unable to setup the frametable mappings.\n"); - - memset(&frame_table[0], 0, nr_pdxs * sizeof(struct page_info)); - memset(&frame_table[nr_pdxs], -1, - frametable_size - (nr_pdxs * sizeof(struct page_info))); - - frametable_virt_end = FRAMETABLE_VIRT_START + (nr_pdxs * sizeof(struct page_info)); -} - -void *__init arch_vmap_virt_end(void) -{ - return (void *)(VMAP_VIRT_START + VMAP_VIRT_SIZE); -} - -/* - * This function should only be used to remap device address ranges - * TODO: add a check to verify this assumption - */ -void *ioremap_attr(paddr_t pa, size_t len, unsigned int attributes) -{ - mfn_t mfn = _mfn(PFN_DOWN(pa)); - unsigned int offs = pa & (PAGE_SIZE - 1); - unsigned int nr = PFN_UP(offs + len); - void *ptr = __vmap(&mfn, nr, 1, 1, attributes, VMAP_DEFAULT); - - if ( ptr == NULL ) - return NULL; - - return ptr + offs; -} - -void *ioremap(paddr_t pa, size_t len) -{ - return ioremap_attr(pa, len, PAGE_HYPERVISOR_NOCACHE); -} - -static int create_xen_table(lpae_t *entry) -{ - mfn_t mfn; - void *p; - lpae_t pte; - - if ( system_state != SYS_STATE_early_boot ) - { - struct page_info *pg = alloc_domheap_page(NULL, 0); - - if ( pg == NULL ) - return -ENOMEM; - - mfn = page_to_mfn(pg); - } - else - mfn = alloc_boot_pages(1, 1); - - p = xen_map_table(mfn); - clear_page(p); - xen_unmap_table(p); - - pte = mfn_to_xen_entry(mfn, MT_NORMAL); - pte.pt.table = 1; - write_pte(entry, pte); - - return 0; -} - -#define XEN_TABLE_MAP_FAILED 0 -#define XEN_TABLE_SUPER_PAGE 1 -#define XEN_TABLE_NORMAL_PAGE 2 - -/* - * Take the currently mapped table, find the corresponding entry, - * and map the next table, if available. - * - * The read_only parameters indicates whether intermediate tables should - * be allocated when not present. - * - * Return values: - * XEN_TABLE_MAP_FAILED: Either read_only was set and the entry - * was empty, or allocating a new page failed. - * XEN_TABLE_NORMAL_PAGE: next level mapped normally - * XEN_TABLE_SUPER_PAGE: The next entry points to a superpage. - */ -static int xen_pt_next_level(bool read_only, unsigned int level, - lpae_t **table, unsigned int offset) -{ - lpae_t *entry; - int ret; - mfn_t mfn; - - entry = *table + offset; - - if ( !lpae_is_valid(*entry) ) - { - if ( read_only ) - return XEN_TABLE_MAP_FAILED; - - ret = create_xen_table(entry); - if ( ret ) - return XEN_TABLE_MAP_FAILED; - } - - /* The function xen_pt_next_level is never called at the 3rd level */ - if ( lpae_is_mapping(*entry, level) ) - return XEN_TABLE_SUPER_PAGE; - - mfn = lpae_get_mfn(*entry); - - xen_unmap_table(*table); - *table = xen_map_table(mfn); - - return XEN_TABLE_NORMAL_PAGE; -} - -/* Sanity check of the entry */ -static bool xen_pt_check_entry(lpae_t entry, mfn_t mfn, unsigned int level, - unsigned int flags) -{ - /* Sanity check when modifying an entry. */ - if ( (flags & _PAGE_PRESENT) && mfn_eq(mfn, INVALID_MFN) ) - { - /* We don't allow modifying an invalid entry. */ - if ( !lpae_is_valid(entry) ) - { - mm_printk("Modifying invalid entry is not allowed.\n"); - return false; - } - - /* We don't allow modifying a table entry */ - if ( !lpae_is_mapping(entry, level) ) - { - mm_printk("Modifying a table entry is not allowed.\n"); - return false; - } - - /* We don't allow changing memory attributes. */ - if ( entry.pt.ai != PAGE_AI_MASK(flags) ) - { - mm_printk("Modifying memory attributes is not allowed (0x%x -> 0x%x).\n", - entry.pt.ai, PAGE_AI_MASK(flags)); - return false; - } - - /* We don't allow modifying entry with contiguous bit set. */ - if ( entry.pt.contig ) - { - mm_printk("Modifying entry with contiguous bit set is not allowed.\n"); - return false; - } - } - /* Sanity check when inserting a mapping */ - else if ( flags & _PAGE_PRESENT ) - { - /* We should be here with a valid MFN. */ - ASSERT(!mfn_eq(mfn, INVALID_MFN)); - - /* - * We don't allow replacing any valid entry. - * - * Note that the function xen_pt_update() relies on this - * assumption and will skip the TLB flush. The function will need - * to be updated if the check is relaxed. - */ - if ( lpae_is_valid(entry) ) - { - if ( lpae_is_mapping(entry, level) ) - mm_printk("Changing MFN for a valid entry is not allowed (%#"PRI_mfn" -> %#"PRI_mfn").\n", - mfn_x(lpae_get_mfn(entry)), mfn_x(mfn)); - else - mm_printk("Trying to replace a table with a mapping.\n"); - return false; - } - } - /* Sanity check when removing a mapping. */ - else if ( (flags & (_PAGE_PRESENT|_PAGE_POPULATE)) == 0 ) - { - /* We should be here with an invalid MFN. */ - ASSERT(mfn_eq(mfn, INVALID_MFN)); - - /* We don't allow removing a table */ - if ( lpae_is_table(entry, level) ) - { - mm_printk("Removing a table is not allowed.\n"); - return false; - } - - /* We don't allow removing a mapping with contiguous bit set. */ - if ( entry.pt.contig ) - { - mm_printk("Removing entry with contiguous bit set is not allowed.\n"); - return false; - } - } - /* Sanity check when populating the page-table. No check so far. */ - else - { - ASSERT(flags & _PAGE_POPULATE); - /* We should be here with an invalid MFN */ - ASSERT(mfn_eq(mfn, INVALID_MFN)); - } - - return true; -} - -/* Update an entry at the level @target. */ -static int xen_pt_update_entry(mfn_t root, unsigned long virt, - mfn_t mfn, unsigned int target, - unsigned int flags) -{ - int rc; - unsigned int level; - lpae_t *table; - /* - * The intermediate page tables are read-only when the MFN is not valid - * and we are not populating page table. - * This means we either modify permissions or remove an entry. - */ - bool read_only = mfn_eq(mfn, INVALID_MFN) && !(flags & _PAGE_POPULATE); - lpae_t pte, *entry; - - /* convenience aliases */ - DECLARE_OFFSETS(offsets, (paddr_t)virt); - - /* _PAGE_POPULATE and _PAGE_PRESENT should never be set together. */ - ASSERT((flags & (_PAGE_POPULATE|_PAGE_PRESENT)) != (_PAGE_POPULATE|_PAGE_PRESENT)); - - table = xen_map_table(root); - for ( level = HYP_PT_ROOT_LEVEL; level < target; level++ ) - { - rc = xen_pt_next_level(read_only, level, &table, offsets[level]); - if ( rc == XEN_TABLE_MAP_FAILED ) - { - /* - * We are here because xen_pt_next_level has failed to map - * the intermediate page table (e.g the table does not exist - * and the pt is read-only). It is a valid case when - * removing a mapping as it may not exist in the page table. - * In this case, just ignore it. - */ - if ( flags & (_PAGE_PRESENT|_PAGE_POPULATE) ) - { - mm_printk("%s: Unable to map level %u\n", __func__, level); - rc = -ENOENT; - goto out; - } - else - { - rc = 0; - goto out; - } - } - else if ( rc != XEN_TABLE_NORMAL_PAGE ) - break; - } - - if ( level != target ) - { - mm_printk("%s: Shattering superpage is not supported\n", __func__); - rc = -EOPNOTSUPP; - goto out; - } - - entry = table + offsets[level]; - - rc = -EINVAL; - if ( !xen_pt_check_entry(*entry, mfn, level, flags) ) - goto out; - - /* If we are only populating page-table, then we are done. */ - rc = 0; - if ( flags & _PAGE_POPULATE ) - goto out; - - /* We are removing the page */ - if ( !(flags & _PAGE_PRESENT) ) - memset(&pte, 0x00, sizeof(pte)); - else - { - /* We are inserting a mapping => Create new pte. */ - if ( !mfn_eq(mfn, INVALID_MFN) ) - { - pte = mfn_to_xen_entry(mfn, PAGE_AI_MASK(flags)); - - /* - * First and second level pages set pte.pt.table = 0, but - * third level entries set pte.pt.table = 1. - */ - pte.pt.table = (level == 3); - } - else /* We are updating the permission => Copy the current pte. */ - pte = *entry; - - /* Set permission */ - pte.pt.ro = PAGE_RO_MASK(flags); - pte.pt.xn = PAGE_XN_MASK(flags); - /* Set contiguous bit */ - pte.pt.contig = !!(flags & _PAGE_CONTIG); - } - - write_pte(entry, pte); - - rc = 0; - -out: - xen_unmap_table(table); - - return rc; -} - -/* Return the level where mapping should be done */ -static int xen_pt_mapping_level(unsigned long vfn, mfn_t mfn, unsigned long nr, - unsigned int flags) -{ - unsigned int level; - unsigned long mask; - - /* - * Don't take into account the MFN when removing mapping (i.e - * MFN_INVALID) to calculate the correct target order. - * - * Per the Arm Arm, `vfn` and `mfn` must be both superpage aligned. - * They are or-ed together and then checked against the size of - * each level. - * - * `left` is not included and checked separately to allow - * superpage mapping even if it is not properly aligned (the - * user may have asked to map 2MB + 4k). - */ - mask = !mfn_eq(mfn, INVALID_MFN) ? mfn_x(mfn) : 0; - mask |= vfn; - - /* - * Always use level 3 mapping unless the caller request block - * mapping. - */ - if ( likely(!(flags & _PAGE_BLOCK)) ) - level = 3; - else if ( !(mask & (BIT(FIRST_ORDER, UL) - 1)) && - (nr >= BIT(FIRST_ORDER, UL)) ) - level = 1; - else if ( !(mask & (BIT(SECOND_ORDER, UL) - 1)) && - (nr >= BIT(SECOND_ORDER, UL)) ) - level = 2; - else - level = 3; - - return level; -} - -#define XEN_PT_4K_NR_CONTIG 16 - -/* - * Check whether the contiguous bit can be set. Return the number of - * contiguous entry allowed. If not allowed, return 1. - */ -static unsigned int xen_pt_check_contig(unsigned long vfn, mfn_t mfn, - unsigned int level, unsigned long left, - unsigned int flags) -{ - unsigned long nr_contig; - - /* - * Allow the contiguous bit to set when the caller requests block - * mapping. - */ - if ( !(flags & _PAGE_BLOCK) ) - return 1; - - /* - * We don't allow to remove mapping with the contiguous bit set. - * So shortcut the logic and directly return 1. - */ - if ( mfn_eq(mfn, INVALID_MFN) ) - return 1; - - /* - * The number of contiguous entries varies depending on the page - * granularity used. The logic below assumes 4KB. - */ - BUILD_BUG_ON(PAGE_SIZE != SZ_4K); - - /* - * In order to enable the contiguous bit, we should have enough entries - * to map left and both the virtual and physical address should be - * aligned to the size of 16 translation tables entries. - */ - nr_contig = BIT(XEN_PT_LEVEL_ORDER(level), UL) * XEN_PT_4K_NR_CONTIG; - - if ( (left < nr_contig) || ((mfn_x(mfn) | vfn) & (nr_contig - 1)) ) - return 1; - - return XEN_PT_4K_NR_CONTIG; -} - -static DEFINE_SPINLOCK(xen_pt_lock); - -static int xen_pt_update(unsigned long virt, - mfn_t mfn, - /* const on purpose as it is used for TLB flush */ - const unsigned long nr_mfns, - unsigned int flags) -{ - int rc = 0; - unsigned long vfn = virt >> PAGE_SHIFT; - unsigned long left = nr_mfns; - - /* - * For arm32, page-tables are different on each CPUs. Yet, they share - * some common mappings. It is assumed that only common mappings - * will be modified with this function. - * - * XXX: Add a check. - */ - const mfn_t root = maddr_to_mfn(READ_SYSREG64(TTBR0_EL2)); - - /* - * The hardware was configured to forbid mapping both writeable and - * executable. - * When modifying/creating mapping (i.e _PAGE_PRESENT is set), - * prevent any update if this happen. - */ - if ( (flags & _PAGE_PRESENT) && !PAGE_RO_MASK(flags) && - !PAGE_XN_MASK(flags) ) - { - mm_printk("Mappings should not be both Writeable and Executable.\n"); - return -EINVAL; - } - - if ( flags & _PAGE_CONTIG ) - { - mm_printk("_PAGE_CONTIG is an internal only flag.\n"); - return -EINVAL; - } - - if ( !IS_ALIGNED(virt, PAGE_SIZE) ) - { - mm_printk("The virtual address is not aligned to the page-size.\n"); - return -EINVAL; - } - - spin_lock(&xen_pt_lock); - - while ( left ) - { - unsigned int order, level, nr_contig, new_flags; - - level = xen_pt_mapping_level(vfn, mfn, left, flags); - order = XEN_PT_LEVEL_ORDER(level); - - ASSERT(left >= BIT(order, UL)); - - /* - * Check if we can set the contiguous mapping and update the - * flags accordingly. - */ - nr_contig = xen_pt_check_contig(vfn, mfn, level, left, flags); - new_flags = flags | ((nr_contig > 1) ? _PAGE_CONTIG : 0); - - for ( ; nr_contig > 0; nr_contig-- ) - { - rc = xen_pt_update_entry(root, vfn << PAGE_SHIFT, mfn, level, - new_flags); - if ( rc ) - break; - - vfn += 1U << order; - if ( !mfn_eq(mfn, INVALID_MFN) ) - mfn = mfn_add(mfn, 1U << order); - - left -= (1U << order); - } - - if ( rc ) - break; - } - - /* - * The TLBs flush can be safely skipped when a mapping is inserted - * as we don't allow mapping replacement (see xen_pt_check_entry()). - * - * For all the other cases, the TLBs will be flushed unconditionally - * even if the mapping has failed. This is because we may have - * partially modified the PT. This will prevent any unexpected - * behavior afterwards. - */ - if ( !((flags & _PAGE_PRESENT) && !mfn_eq(mfn, INVALID_MFN)) ) - flush_xen_tlb_range_va(virt, PAGE_SIZE * nr_mfns); - - spin_unlock(&xen_pt_lock); - - return rc; -} - -int map_pages_to_xen(unsigned long virt, - mfn_t mfn, - unsigned long nr_mfns, - unsigned int flags) -{ - return xen_pt_update(virt, mfn, nr_mfns, flags); -} - -int populate_pt_range(unsigned long virt, unsigned long nr_mfns) -{ - return xen_pt_update(virt, INVALID_MFN, nr_mfns, _PAGE_POPULATE); -} - -int destroy_xen_mappings(unsigned long s, unsigned long e) -{ - ASSERT(IS_ALIGNED(s, PAGE_SIZE)); - ASSERT(IS_ALIGNED(e, PAGE_SIZE)); - ASSERT(s <= e); - return xen_pt_update(s, INVALID_MFN, (e - s) >> PAGE_SHIFT, 0); -} - -int modify_xen_mappings(unsigned long s, unsigned long e, unsigned int flags) -{ - ASSERT(IS_ALIGNED(s, PAGE_SIZE)); - ASSERT(IS_ALIGNED(e, PAGE_SIZE)); - ASSERT(s <= e); - return xen_pt_update(s, INVALID_MFN, (e - s) >> PAGE_SHIFT, flags); -} - -/* Release all __init and __initdata ranges to be reused */ -void free_init_memory(void) -{ - paddr_t pa = virt_to_maddr(__init_begin); - unsigned long len = __init_end - __init_begin; - uint32_t insn; - unsigned int i, nr = len / sizeof(insn); - uint32_t *p; - int rc; - - rc = modify_xen_mappings((unsigned long)__init_begin, - (unsigned long)__init_end, PAGE_HYPERVISOR_RW); - if ( rc ) - panic("Unable to map RW the init section (rc = %d)\n", rc); - - /* - * From now on, init will not be used for execution anymore, - * so nuke the instruction cache to remove entries related to init. - */ - invalidate_icache_local(); - -#ifdef CONFIG_ARM_32 - /* udf instruction i.e (see A8.8.247 in ARM DDI 0406C.c) */ - insn = 0xe7f000f0; -#else - insn = AARCH64_BREAK_FAULT; -#endif - p = (uint32_t *)__init_begin; - for ( i = 0; i < nr; i++ ) - *(p + i) = insn; - - rc = destroy_xen_mappings((unsigned long)__init_begin, - (unsigned long)__init_end); - if ( rc ) - panic("Unable to remove the init section (rc = %d)\n", rc); - - init_domheap_pages(pa, pa + len); - printk("Freed %ldkB init memory.\n", (long)(__init_end-__init_begin)>>10); -} - void arch_dump_shared_mem_info(void) { } @@ -1319,137 +100,6 @@ void share_xen_page_with_guest(struct page_info *page, struct domain *d, spin_unlock(&d->page_alloc_lock); } -int xenmem_add_to_physmap_one( - struct domain *d, - unsigned int space, - union add_to_physmap_extra extra, - unsigned long idx, - gfn_t gfn) -{ - mfn_t mfn = INVALID_MFN; - int rc; - p2m_type_t t; - struct page_info *page = NULL; - - switch ( space ) - { - case XENMAPSPACE_grant_table: - rc = gnttab_map_frame(d, idx, gfn, &mfn); - if ( rc ) - return rc; - - /* Need to take care of the reference obtained in gnttab_map_frame(). */ - page = mfn_to_page(mfn); - t = p2m_ram_rw; - - break; - case XENMAPSPACE_shared_info: - if ( idx != 0 ) - return -EINVAL; - - mfn = virt_to_mfn(d->shared_info); - t = p2m_ram_rw; - - break; - case XENMAPSPACE_gmfn_foreign: - { - struct domain *od; - p2m_type_t p2mt; - - od = get_pg_owner(extra.foreign_domid); - if ( od == NULL ) - return -ESRCH; - - if ( od == d ) - { - put_pg_owner(od); - return -EINVAL; - } - - rc = xsm_map_gmfn_foreign(XSM_TARGET, d, od); - if ( rc ) - { - put_pg_owner(od); - return rc; - } - - /* Take reference to the foreign domain page. - * Reference will be released in XENMEM_remove_from_physmap */ - page = get_page_from_gfn(od, idx, &p2mt, P2M_ALLOC); - if ( !page ) - { - put_pg_owner(od); - return -EINVAL; - } - - if ( p2m_is_ram(p2mt) ) - t = (p2mt == p2m_ram_rw) ? p2m_map_foreign_rw : p2m_map_foreign_ro; - else - { - put_page(page); - put_pg_owner(od); - return -EINVAL; - } - - mfn = page_to_mfn(page); - - put_pg_owner(od); - break; - } - case XENMAPSPACE_dev_mmio: - rc = map_dev_mmio_page(d, gfn, _mfn(idx)); - return rc; - - default: - return -ENOSYS; - } - - /* - * Map at new location. Here we need to map xenheap RAM page differently - * because we need to store the valid GFN and make sure that nothing was - * mapped before (the stored GFN is invalid). And these actions need to be - * performed with the P2M lock held. The guest_physmap_add_entry() is just - * a wrapper on top of p2m_set_entry(). - */ - if ( !p2m_is_ram(t) || !is_xen_heap_mfn(mfn) ) - rc = guest_physmap_add_entry(d, gfn, mfn, 0, t); - else - { - struct p2m_domain *p2m = p2m_get_hostp2m(d); - - p2m_write_lock(p2m); - if ( gfn_eq(page_get_xenheap_gfn(mfn_to_page(mfn)), INVALID_GFN) ) - { - rc = p2m_set_entry(p2m, gfn, 1, mfn, t, p2m->default_access); - if ( !rc ) - page_set_xenheap_gfn(mfn_to_page(mfn), gfn); - } - else - /* - * Mandate the caller to first unmap the page before mapping it - * again. This is to prevent Xen creating an unwanted hole in - * the P2M. For instance, this could happen if the firmware stole - * a RAM address for mapping the shared_info page into but forgot - * to unmap it afterwards. - */ - rc = -EBUSY; - p2m_write_unlock(p2m); - } - - /* - * For XENMAPSPACE_gmfn_foreign if we failed to add the mapping, we need - * to drop the reference we took earlier. In all other cases we need to - * drop any reference we took earlier (perhaps indirectly). - */ - if ( space == XENMAPSPACE_gmfn_foreign ? rc : page != NULL ) - { - ASSERT(page != NULL); - put_page(page); - } - - return rc; -} - long arch_memory_op(int op, XEN_GUEST_HANDLE_PARAM(void) arg) { switch ( op ) diff --git a/xen/arch/arm/mm_mmu.c b/xen/arch/arm/mm_mmu.c new file mode 100644 index 0000000000..72b4909766 --- /dev/null +++ b/xen/arch/arm/mm_mmu.c @@ -0,0 +1,1376 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* + * xen/arch/arm/mm.c + * + * MMU code for an ARMv7-A with virt extensions. + * + * Tim Deegan + * Copyright (c) 2011 Citrix Systems. + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include + +#include +#include + +#include + +/* Override macros from asm/page.h to make them work with mfn_t */ +#undef virt_to_mfn +#define virt_to_mfn(va) _mfn(__virt_to_mfn(va)) +#undef mfn_to_virt +#define mfn_to_virt(mfn) __mfn_to_virt(mfn_x(mfn)) + +#ifdef NDEBUG +static inline void +__attribute__ ((__format__ (__printf__, 1, 2))) +mm_printk(const char *fmt, ...) {} +#else +#define mm_printk(fmt, args...) \ + do \ + { \ + dprintk(XENLOG_ERR, fmt, ## args); \ + WARN(); \ + } while (0) +#endif + +/* Static start-of-day pagetables that we use before the allocators + * are up. These are used by all CPUs during bringup before switching + * to the CPUs own pagetables. + * + * These pagetables have a very simple structure. They include: + * - 2MB worth of 4K mappings of xen at XEN_VIRT_START, boot_first and + * boot_second are used to populate the tables down to boot_third + * which contains the actual mapping. + * - a 1:1 mapping of xen at its current physical address. This uses a + * section mapping at whichever of boot_{pgtable,first,second} + * covers that physical address. + * + * For the boot CPU these mappings point to the address where Xen was + * loaded by the bootloader. For secondary CPUs they point to the + * relocated copy of Xen for the benefit of secondary CPUs. + * + * In addition to the above for the boot CPU the device-tree is + * initially mapped in the boot misc slot. This mapping is not present + * for secondary CPUs. + * + * Finally, if EARLY_PRINTK is enabled then xen_fixmap will be mapped + * by the CPU once it has moved off the 1:1 mapping. + */ +DEFINE_BOOT_PAGE_TABLE(boot_pgtable); +#ifdef CONFIG_ARM_64 +DEFINE_BOOT_PAGE_TABLE(boot_first); +DEFINE_BOOT_PAGE_TABLE(boot_first_id); +#endif +DEFINE_BOOT_PAGE_TABLE(boot_second_id); +DEFINE_BOOT_PAGE_TABLE(boot_third_id); +DEFINE_BOOT_PAGE_TABLE(boot_second); +DEFINE_BOOT_PAGE_TABLE(boot_third); + +/* Main runtime page tables */ + +/* + * For arm32 xen_pgtable are per-PCPU and are allocated before + * bringing up each CPU. For arm64 xen_pgtable is common to all PCPUs. + * + * xen_second, xen_fixmap and xen_xenmap are always shared between all + * PCPUs. + */ + +#ifdef CONFIG_ARM_64 +#define HYP_PT_ROOT_LEVEL 0 +static DEFINE_PAGE_TABLE(xen_pgtable); +static DEFINE_PAGE_TABLE(xen_first); +#define THIS_CPU_PGTABLE xen_pgtable +#else +#define HYP_PT_ROOT_LEVEL 1 +/* Per-CPU pagetable pages */ +/* xen_pgtable == root of the trie (zeroeth level on 64-bit, first on 32-bit) */ +DEFINE_PER_CPU(lpae_t *, xen_pgtable); +#define THIS_CPU_PGTABLE this_cpu(xen_pgtable) +/* Root of the trie for cpu0, other CPU's PTs are dynamically allocated */ +static DEFINE_PAGE_TABLE(cpu0_pgtable); +#endif + +/* Common pagetable leaves */ +/* Second level page table used to cover Xen virtual address space */ +static DEFINE_PAGE_TABLE(xen_second); +/* Third level page table used for fixmap */ +DEFINE_BOOT_PAGE_TABLE(xen_fixmap); +/* + * Third level page table used to map Xen itself with the XN bit set + * as appropriate. + */ +static DEFINE_PAGE_TABLE(xen_xenmap); + +/* Non-boot CPUs use this to find the correct pagetables. */ +uint64_t init_ttbr; + +static paddr_t phys_offset; + +/* Limits of the Xen heap */ +mfn_t directmap_mfn_start __read_mostly = INVALID_MFN_INITIALIZER; +mfn_t directmap_mfn_end __read_mostly; +vaddr_t directmap_virt_end __read_mostly; +#ifdef CONFIG_ARM_64 +vaddr_t directmap_virt_start __read_mostly; +unsigned long directmap_base_pdx __read_mostly; +#endif + +unsigned long frametable_virt_end __read_mostly; + +extern char __init_begin[], __init_end[]; + +/* Checking VA memory layout alignment. */ +static void __init __maybe_unused build_assertions(void) +{ + /* 2MB aligned regions */ + BUILD_BUG_ON(XEN_VIRT_START & ~SECOND_MASK); + BUILD_BUG_ON(FIXMAP_ADDR(0) & ~SECOND_MASK); + /* 1GB aligned regions */ +#ifdef CONFIG_ARM_32 + BUILD_BUG_ON(XENHEAP_VIRT_START & ~FIRST_MASK); +#else + BUILD_BUG_ON(DIRECTMAP_VIRT_START & ~FIRST_MASK); +#endif + /* Page table structure constraints */ +#ifdef CONFIG_ARM_64 + BUILD_BUG_ON(zeroeth_table_offset(XEN_VIRT_START)); +#endif + BUILD_BUG_ON(first_table_offset(XEN_VIRT_START)); +#ifdef CONFIG_ARCH_MAP_DOMAIN_PAGE + BUILD_BUG_ON(DOMHEAP_VIRT_START & ~FIRST_MASK); +#endif + /* + * The boot code expects the regions XEN_VIRT_START, FIXMAP_ADDR(0), + * BOOT_FDT_VIRT_START to use the same 0th (arm64 only) and 1st + * slot in the page tables. + */ +#define CHECK_SAME_SLOT(level, virt1, virt2) \ + BUILD_BUG_ON(level##_table_offset(virt1) != level##_table_offset(virt2)) + +#ifdef CONFIG_ARM_64 + CHECK_SAME_SLOT(zeroeth, XEN_VIRT_START, FIXMAP_ADDR(0)); + CHECK_SAME_SLOT(zeroeth, XEN_VIRT_START, BOOT_FDT_VIRT_START); +#endif + CHECK_SAME_SLOT(first, XEN_VIRT_START, FIXMAP_ADDR(0)); + CHECK_SAME_SLOT(first, XEN_VIRT_START, BOOT_FDT_VIRT_START); + +#undef CHECK_SAME_SLOT +} + +static lpae_t *xen_map_table(mfn_t mfn) +{ + /* + * During early boot, map_domain_page() may be unusable. Use the + * PMAP to map temporarily a page-table. + */ + if ( system_state == SYS_STATE_early_boot ) + return pmap_map(mfn); + + return map_domain_page(mfn); +} + +static void xen_unmap_table(const lpae_t *table) +{ + /* + * During early boot, xen_map_table() will not use map_domain_page() + * but the PMAP. + */ + if ( system_state == SYS_STATE_early_boot ) + pmap_unmap(table); + else + unmap_domain_page(table); +} + +void dump_pt_walk(paddr_t ttbr, paddr_t addr, + unsigned int root_level, + unsigned int nr_root_tables) +{ + static const char *level_strs[4] = { "0TH", "1ST", "2ND", "3RD" }; + const mfn_t root_mfn = maddr_to_mfn(ttbr); + const unsigned int offsets[4] = { + zeroeth_table_offset(addr), + first_table_offset(addr), + second_table_offset(addr), + third_table_offset(addr) + }; + lpae_t pte, *mapping; + unsigned int level, root_table; + +#ifdef CONFIG_ARM_32 + BUG_ON(root_level < 1); +#endif + BUG_ON(root_level > 3); + + if ( nr_root_tables > 1 ) + { + /* + * Concatenated root-level tables. The table number will be + * the offset at the previous level. It is not possible to + * concatenate a level-0 root. + */ + BUG_ON(root_level == 0); + root_table = offsets[root_level - 1]; + printk("Using concatenated root table %u\n", root_table); + if ( root_table >= nr_root_tables ) + { + printk("Invalid root table offset\n"); + return; + } + } + else + root_table = 0; + + mapping = xen_map_table(mfn_add(root_mfn, root_table)); + + for ( level = root_level; ; level++ ) + { + if ( offsets[level] > XEN_PT_LPAE_ENTRIES ) + break; + + pte = mapping[offsets[level]]; + + printk("%s[0x%03x] = 0x%"PRIpaddr"\n", + level_strs[level], offsets[level], pte.bits); + + if ( level == 3 || !pte.walk.valid || !pte.walk.table ) + break; + + /* For next iteration */ + xen_unmap_table(mapping); + mapping = xen_map_table(lpae_get_mfn(pte)); + } + + xen_unmap_table(mapping); +} + +void dump_hyp_walk(vaddr_t addr) +{ + uint64_t ttbr = READ_SYSREG64(TTBR0_EL2); + + printk("Walking Hypervisor VA 0x%"PRIvaddr" " + "on CPU%d via TTBR 0x%016"PRIx64"\n", + addr, smp_processor_id(), ttbr); + + dump_pt_walk(ttbr, addr, HYP_PT_ROOT_LEVEL, 1); +} + +lpae_t mfn_to_xen_entry(mfn_t mfn, unsigned int attr) +{ + lpae_t e = (lpae_t) { + .pt = { + .valid = 1, /* Mappings are present */ + .table = 0, /* Set to 1 for links and 4k maps */ + .ai = attr, + .ns = 1, /* Hyp mode is in the non-secure world */ + .up = 1, /* See below */ + .ro = 0, /* Assume read-write */ + .af = 1, /* No need for access tracking */ + .ng = 1, /* Makes TLB flushes easier */ + .contig = 0, /* Assume non-contiguous */ + .xn = 1, /* No need to execute outside .text */ + .avail = 0, /* Reference count for domheap mapping */ + }}; + /* + * For EL2 stage-1 page table, up (aka AP[1]) is RES1 as the translation + * regime applies to only one exception level (see D4.4.4 and G4.6.1 + * in ARM DDI 0487B.a). If this changes, remember to update the + * hard-coded values in head.S too. + */ + + switch ( attr ) + { + case MT_NORMAL_NC: + /* + * ARM ARM: Overlaying the shareability attribute (DDI + * 0406C.b B3-1376 to 1377) + * + * A memory region with a resultant memory type attribute of Normal, + * and a resultant cacheability attribute of Inner Non-cacheable, + * Outer Non-cacheable, must have a resultant shareability attribute + * of Outer Shareable, otherwise shareability is UNPREDICTABLE. + * + * On ARMv8 sharability is ignored and explicitly treated as Outer + * Shareable for Normal Inner Non_cacheable, Outer Non-cacheable. + */ + e.pt.sh = LPAE_SH_OUTER; + break; + case MT_DEVICE_nGnRnE: + case MT_DEVICE_nGnRE: + /* + * Shareability is ignored for non-Normal memory, Outer is as + * good as anything. + * + * On ARMv8 sharability is ignored and explicitly treated as Outer + * Shareable for any device memory type. + */ + e.pt.sh = LPAE_SH_OUTER; + break; + default: + e.pt.sh = LPAE_SH_INNER; /* Xen mappings are SMP coherent */ + break; + } + + ASSERT(!(mfn_to_maddr(mfn) & ~PADDR_MASK)); + + lpae_set_mfn(e, mfn); + + return e; +} + +/* Map a 4k page in a fixmap entry */ +void set_fixmap(unsigned int map, mfn_t mfn, unsigned int flags) +{ + int res; + + res = map_pages_to_xen(FIXMAP_ADDR(map), mfn, 1, flags); + BUG_ON(res != 0); +} + +/* Remove a mapping from a fixmap entry */ +void clear_fixmap(unsigned int map) +{ + int res; + + res = destroy_xen_mappings(FIXMAP_ADDR(map), FIXMAP_ADDR(map) + PAGE_SIZE); + BUG_ON(res != 0); +} + +void *map_page_to_xen_misc(mfn_t mfn, unsigned int attributes) +{ + set_fixmap(FIXMAP_MISC, mfn, attributes); + + return fix_to_virt(FIXMAP_MISC); +} + +void unmap_page_from_xen_misc(void) +{ + clear_fixmap(FIXMAP_MISC); +} + +static inline lpae_t pte_of_xenaddr(vaddr_t va) +{ + paddr_t ma = va + phys_offset; + + return mfn_to_xen_entry(maddr_to_mfn(ma), MT_NORMAL); +} + +void * __init early_fdt_map(paddr_t fdt_paddr) +{ + /* We are using 2MB superpage for mapping the FDT */ + paddr_t base_paddr = fdt_paddr & SECOND_MASK; + paddr_t offset; + void *fdt_virt; + uint32_t size; + int rc; + + /* + * Check whether the physical FDT address is set and meets the minimum + * alignment requirement. Since we are relying on MIN_FDT_ALIGN to be at + * least 8 bytes so that we always access the magic and size fields + * of the FDT header after mapping the first chunk, double check if + * that is indeed the case. + */ + BUILD_BUG_ON(MIN_FDT_ALIGN < 8); + if ( !fdt_paddr || fdt_paddr % MIN_FDT_ALIGN ) + return NULL; + + /* The FDT is mapped using 2MB superpage */ + BUILD_BUG_ON(BOOT_FDT_VIRT_START % SZ_2M); + + rc = map_pages_to_xen(BOOT_FDT_VIRT_START, maddr_to_mfn(base_paddr), + SZ_2M >> PAGE_SHIFT, + PAGE_HYPERVISOR_RO | _PAGE_BLOCK); + if ( rc ) + panic("Unable to map the device-tree.\n"); + + + offset = fdt_paddr % SECOND_SIZE; + fdt_virt = (void *)BOOT_FDT_VIRT_START + offset; + + if ( fdt_magic(fdt_virt) != FDT_MAGIC ) + return NULL; + + size = fdt_totalsize(fdt_virt); + if ( size > MAX_FDT_SIZE ) + return NULL; + + if ( (offset + size) > SZ_2M ) + { + rc = map_pages_to_xen(BOOT_FDT_VIRT_START + SZ_2M, + maddr_to_mfn(base_paddr + SZ_2M), + SZ_2M >> PAGE_SHIFT, + PAGE_HYPERVISOR_RO | _PAGE_BLOCK); + if ( rc ) + panic("Unable to map the device-tree\n"); + } + + return fdt_virt; +} + +void __init remove_early_mappings(void) +{ + int rc; + + /* destroy the _PAGE_BLOCK mapping */ + rc = modify_xen_mappings(BOOT_FDT_VIRT_START, + BOOT_FDT_VIRT_START + BOOT_FDT_VIRT_SIZE, + _PAGE_BLOCK); + BUG_ON(rc); +} + +/* + * After boot, Xen page-tables should not contain mapping that are both + * Writable and eXecutables. + * + * This should be called on each CPU to enforce the policy. + */ +static void xen_pt_enforce_wnx(void) +{ + WRITE_SYSREG(READ_SYSREG(SCTLR_EL2) | SCTLR_Axx_ELx_WXN, SCTLR_EL2); + /* + * The TLBs may cache SCTLR_EL2.WXN. So ensure it is synchronized + * before flushing the TLBs. + */ + isb(); + flush_xen_tlb_local(); +} + +extern void switch_ttbr(uint64_t ttbr); + +/* Clear a translation table and clean & invalidate the cache */ +static void clear_table(void *table) +{ + clear_page(table); + clean_and_invalidate_dcache_va_range(table, PAGE_SIZE); +} + +/* Boot-time pagetable setup. + * Changes here may need matching changes in head.S */ +void __init setup_pagetables(unsigned long boot_phys_offset) +{ + uint64_t ttbr; + lpae_t pte, *p; + int i; + + phys_offset = boot_phys_offset; + +#ifdef CONFIG_ARM_64 + p = (void *) xen_pgtable; + p[0] = pte_of_xenaddr((uintptr_t)xen_first); + p[0].pt.table = 1; + p[0].pt.xn = 0; + p = (void *) xen_first; +#else + p = (void *) cpu0_pgtable; +#endif + + /* Map xen second level page-table */ + p[0] = pte_of_xenaddr((uintptr_t)(xen_second)); + p[0].pt.table = 1; + p[0].pt.xn = 0; + + /* Break up the Xen mapping into 4k pages and protect them separately. */ + for ( i = 0; i < XEN_PT_LPAE_ENTRIES; i++ ) + { + vaddr_t va = XEN_VIRT_START + (i << PAGE_SHIFT); + + if ( !is_kernel(va) ) + break; + pte = pte_of_xenaddr(va); + pte.pt.table = 1; /* 4k mappings always have this bit set */ + if ( is_kernel_text(va) || is_kernel_inittext(va) ) + { + pte.pt.xn = 0; + pte.pt.ro = 1; + } + if ( is_kernel_rodata(va) ) + pte.pt.ro = 1; + xen_xenmap[i] = pte; + } + + /* Initialise xen second level entries ... */ + /* ... Xen's text etc */ + + pte = pte_of_xenaddr((vaddr_t)xen_xenmap); + pte.pt.table = 1; + xen_second[second_table_offset(XEN_VIRT_START)] = pte; + + /* ... Fixmap */ + pte = pte_of_xenaddr((vaddr_t)xen_fixmap); + pte.pt.table = 1; + xen_second[second_table_offset(FIXMAP_ADDR(0))] = pte; + +#ifdef CONFIG_ARM_64 + ttbr = (uintptr_t) xen_pgtable + phys_offset; +#else + ttbr = (uintptr_t) cpu0_pgtable + phys_offset; +#endif + + switch_ttbr(ttbr); + + xen_pt_enforce_wnx(); + +#ifdef CONFIG_ARM_32 + per_cpu(xen_pgtable, 0) = cpu0_pgtable; +#endif +} + +static void clear_boot_pagetables(void) +{ + /* + * Clear the copy of the boot pagetables. Each secondary CPU + * rebuilds these itself (see head.S). + */ + clear_table(boot_pgtable); +#ifdef CONFIG_ARM_64 + clear_table(boot_first); + clear_table(boot_first_id); +#endif + clear_table(boot_second); + clear_table(boot_third); +} + +#ifdef CONFIG_ARM_64 +int init_secondary_pagetables(int cpu) +{ + clear_boot_pagetables(); + + /* Set init_ttbr for this CPU coming up. All CPus share a single setof + * pagetables, but rewrite it each time for consistency with 32 bit. */ + init_ttbr = (uintptr_t) xen_pgtable + phys_offset; + clean_dcache(init_ttbr); + return 0; +} +#else +int init_secondary_pagetables(int cpu) +{ + lpae_t *first; + + first = alloc_xenheap_page(); /* root == first level on 32-bit 3-level trie */ + + if ( !first ) + { + printk("CPU%u: Unable to allocate the first page-table\n", cpu); + return -ENOMEM; + } + + /* Initialise root pagetable from root of boot tables */ + memcpy(first, cpu0_pgtable, PAGE_SIZE); + per_cpu(xen_pgtable, cpu) = first; + + if ( !init_domheap_mappings(cpu) ) + { + printk("CPU%u: Unable to prepare the domheap page-tables\n", cpu); + per_cpu(xen_pgtable, cpu) = NULL; + free_xenheap_page(first); + return -ENOMEM; + } + + clear_boot_pagetables(); + + /* Set init_ttbr for this CPU coming up */ + init_ttbr = __pa(first); + clean_dcache(init_ttbr); + + return 0; +} +#endif + +/* MMU setup for secondary CPUS (which already have paging enabled) */ +void mmu_init_secondary_cpu(void) +{ + xen_pt_enforce_wnx(); +} + +#ifdef CONFIG_ARM_32 +/* + * Set up the direct-mapped xenheap: + * up to 1GB of contiguous, always-mapped memory. + */ +void __init setup_directmap_mappings(unsigned long base_mfn, + unsigned long nr_mfns) +{ + int rc; + + rc = map_pages_to_xen(XENHEAP_VIRT_START, _mfn(base_mfn), nr_mfns, + PAGE_HYPERVISOR_RW | _PAGE_BLOCK); + if ( rc ) + panic("Unable to setup the directmap mappings.\n"); + + /* Record where the directmap is, for translation routines. */ + directmap_virt_end = XENHEAP_VIRT_START + nr_mfns * PAGE_SIZE; +} +#else /* CONFIG_ARM_64 */ +/* Map the region in the directmap area. */ +void __init setup_directmap_mappings(unsigned long base_mfn, + unsigned long nr_mfns) +{ + int rc; + + /* First call sets the directmap physical and virtual offset. */ + if ( mfn_eq(directmap_mfn_start, INVALID_MFN) ) + { + unsigned long mfn_gb = base_mfn & ~((FIRST_SIZE >> PAGE_SHIFT) - 1); + + directmap_mfn_start = _mfn(base_mfn); + directmap_base_pdx = mfn_to_pdx(_mfn(base_mfn)); + /* + * The base address may not be aligned to the first level + * size (e.g. 1GB when using 4KB pages). This would prevent + * superpage mappings for all the regions because the virtual + * address and machine address should both be suitably aligned. + * + * Prevent that by offsetting the start of the directmap virtual + * address. + */ + directmap_virt_start = DIRECTMAP_VIRT_START + + (base_mfn - mfn_gb) * PAGE_SIZE; + } + + if ( base_mfn < mfn_x(directmap_mfn_start) ) + panic("cannot add directmap mapping at %lx below heap start %lx\n", + base_mfn, mfn_x(directmap_mfn_start)); + + rc = map_pages_to_xen((vaddr_t)__mfn_to_virt(base_mfn), + _mfn(base_mfn), nr_mfns, + PAGE_HYPERVISOR_RW | _PAGE_BLOCK); + if ( rc ) + panic("Unable to setup the directmap mappings.\n"); +} +#endif + +/* Map a frame table to cover physical addresses ps through pe */ +void __init setup_frametable_mappings(paddr_t ps, paddr_t pe) +{ + unsigned long nr_pdxs = mfn_to_pdx(mfn_add(maddr_to_mfn(pe), -1)) - + mfn_to_pdx(maddr_to_mfn(ps)) + 1; + unsigned long frametable_size = nr_pdxs * sizeof(struct page_info); + mfn_t base_mfn; + const unsigned long mapping_size = frametable_size < MB(32) ? MB(2) : MB(32); + int rc; + + frametable_base_pdx = mfn_to_pdx(maddr_to_mfn(ps)); + /* Round up to 2M or 32M boundary, as appropriate. */ + frametable_size = ROUNDUP(frametable_size, mapping_size); + base_mfn = alloc_boot_pages(frametable_size >> PAGE_SHIFT, 32<<(20-12)); + + rc = map_pages_to_xen(FRAMETABLE_VIRT_START, base_mfn, + frametable_size >> PAGE_SHIFT, + PAGE_HYPERVISOR_RW | _PAGE_BLOCK); + if ( rc ) + panic("Unable to setup the frametable mappings.\n"); + + memset(&frame_table[0], 0, nr_pdxs * sizeof(struct page_info)); + memset(&frame_table[nr_pdxs], -1, + frametable_size - (nr_pdxs * sizeof(struct page_info))); + + frametable_virt_end = FRAMETABLE_VIRT_START + (nr_pdxs * sizeof(struct page_info)); +} + +void *__init arch_vmap_virt_end(void) +{ + return (void *)(VMAP_VIRT_START + VMAP_VIRT_SIZE); +} + +/* + * This function should only be used to remap device address ranges + * TODO: add a check to verify this assumption + */ +void *ioremap_attr(paddr_t pa, size_t len, unsigned int attributes) +{ + mfn_t mfn = _mfn(PFN_DOWN(pa)); + unsigned int offs = pa & (PAGE_SIZE - 1); + unsigned int nr = PFN_UP(offs + len); + void *ptr = __vmap(&mfn, nr, 1, 1, attributes, VMAP_DEFAULT); + + if ( ptr == NULL ) + return NULL; + + return ptr + offs; +} + +void *ioremap(paddr_t pa, size_t len) +{ + return ioremap_attr(pa, len, PAGE_HYPERVISOR_NOCACHE); +} + +static int create_xen_table(lpae_t *entry) +{ + mfn_t mfn; + void *p; + lpae_t pte; + + if ( system_state != SYS_STATE_early_boot ) + { + struct page_info *pg = alloc_domheap_page(NULL, 0); + + if ( pg == NULL ) + return -ENOMEM; + + mfn = page_to_mfn(pg); + } + else + mfn = alloc_boot_pages(1, 1); + + p = xen_map_table(mfn); + clear_page(p); + xen_unmap_table(p); + + pte = mfn_to_xen_entry(mfn, MT_NORMAL); + pte.pt.table = 1; + write_pte(entry, pte); + + return 0; +} + +#define XEN_TABLE_MAP_FAILED 0 +#define XEN_TABLE_SUPER_PAGE 1 +#define XEN_TABLE_NORMAL_PAGE 2 + +/* + * Take the currently mapped table, find the corresponding entry, + * and map the next table, if available. + * + * The read_only parameters indicates whether intermediate tables should + * be allocated when not present. + * + * Return values: + * XEN_TABLE_MAP_FAILED: Either read_only was set and the entry + * was empty, or allocating a new page failed. + * XEN_TABLE_NORMAL_PAGE: next level mapped normally + * XEN_TABLE_SUPER_PAGE: The next entry points to a superpage. + */ +static int xen_pt_next_level(bool read_only, unsigned int level, + lpae_t **table, unsigned int offset) +{ + lpae_t *entry; + int ret; + mfn_t mfn; + + entry = *table + offset; + + if ( !lpae_is_valid(*entry) ) + { + if ( read_only ) + return XEN_TABLE_MAP_FAILED; + + ret = create_xen_table(entry); + if ( ret ) + return XEN_TABLE_MAP_FAILED; + } + + /* The function xen_pt_next_level is never called at the 3rd level */ + if ( lpae_is_mapping(*entry, level) ) + return XEN_TABLE_SUPER_PAGE; + + mfn = lpae_get_mfn(*entry); + + xen_unmap_table(*table); + *table = xen_map_table(mfn); + + return XEN_TABLE_NORMAL_PAGE; +} + +/* Sanity check of the entry */ +static bool xen_pt_check_entry(lpae_t entry, mfn_t mfn, unsigned int level, + unsigned int flags) +{ + /* Sanity check when modifying an entry. */ + if ( (flags & _PAGE_PRESENT) && mfn_eq(mfn, INVALID_MFN) ) + { + /* We don't allow modifying an invalid entry. */ + if ( !lpae_is_valid(entry) ) + { + mm_printk("Modifying invalid entry is not allowed.\n"); + return false; + } + + /* We don't allow modifying a table entry */ + if ( !lpae_is_mapping(entry, level) ) + { + mm_printk("Modifying a table entry is not allowed.\n"); + return false; + } + + /* We don't allow changing memory attributes. */ + if ( entry.pt.ai != PAGE_AI_MASK(flags) ) + { + mm_printk("Modifying memory attributes is not allowed (0x%x -> 0x%x).\n", + entry.pt.ai, PAGE_AI_MASK(flags)); + return false; + } + + /* We don't allow modifying entry with contiguous bit set. */ + if ( entry.pt.contig ) + { + mm_printk("Modifying entry with contiguous bit set is not allowed.\n"); + return false; + } + } + /* Sanity check when inserting a mapping */ + else if ( flags & _PAGE_PRESENT ) + { + /* We should be here with a valid MFN. */ + ASSERT(!mfn_eq(mfn, INVALID_MFN)); + + /* + * We don't allow replacing any valid entry. + * + * Note that the function xen_pt_update() relies on this + * assumption and will skip the TLB flush. The function will need + * to be updated if the check is relaxed. + */ + if ( lpae_is_valid(entry) ) + { + if ( lpae_is_mapping(entry, level) ) + mm_printk("Changing MFN for a valid entry is not allowed (%#"PRI_mfn" -> %#"PRI_mfn").\n", + mfn_x(lpae_get_mfn(entry)), mfn_x(mfn)); + else + mm_printk("Trying to replace a table with a mapping.\n"); + return false; + } + } + /* Sanity check when removing a mapping. */ + else if ( (flags & (_PAGE_PRESENT|_PAGE_POPULATE)) == 0 ) + { + /* We should be here with an invalid MFN. */ + ASSERT(mfn_eq(mfn, INVALID_MFN)); + + /* We don't allow removing a table */ + if ( lpae_is_table(entry, level) ) + { + mm_printk("Removing a table is not allowed.\n"); + return false; + } + + /* We don't allow removing a mapping with contiguous bit set. */ + if ( entry.pt.contig ) + { + mm_printk("Removing entry with contiguous bit set is not allowed.\n"); + return false; + } + } + /* Sanity check when populating the page-table. No check so far. */ + else + { + ASSERT(flags & _PAGE_POPULATE); + /* We should be here with an invalid MFN */ + ASSERT(mfn_eq(mfn, INVALID_MFN)); + } + + return true; +} + +/* Update an entry at the level @target. */ +static int xen_pt_update_entry(mfn_t root, unsigned long virt, + mfn_t mfn, unsigned int target, + unsigned int flags) +{ + int rc; + unsigned int level; + lpae_t *table; + /* + * The intermediate page tables are read-only when the MFN is not valid + * and we are not populating page table. + * This means we either modify permissions or remove an entry. + */ + bool read_only = mfn_eq(mfn, INVALID_MFN) && !(flags & _PAGE_POPULATE); + lpae_t pte, *entry; + + /* convenience aliases */ + DECLARE_OFFSETS(offsets, (paddr_t)virt); + + /* _PAGE_POPULATE and _PAGE_PRESENT should never be set together. */ + ASSERT((flags & (_PAGE_POPULATE|_PAGE_PRESENT)) != (_PAGE_POPULATE|_PAGE_PRESENT)); + + table = xen_map_table(root); + for ( level = HYP_PT_ROOT_LEVEL; level < target; level++ ) + { + rc = xen_pt_next_level(read_only, level, &table, offsets[level]); + if ( rc == XEN_TABLE_MAP_FAILED ) + { + /* + * We are here because xen_pt_next_level has failed to map + * the intermediate page table (e.g the table does not exist + * and the pt is read-only). It is a valid case when + * removing a mapping as it may not exist in the page table. + * In this case, just ignore it. + */ + if ( flags & (_PAGE_PRESENT|_PAGE_POPULATE) ) + { + mm_printk("%s: Unable to map level %u\n", __func__, level); + rc = -ENOENT; + goto out; + } + else + { + rc = 0; + goto out; + } + } + else if ( rc != XEN_TABLE_NORMAL_PAGE ) + break; + } + + if ( level != target ) + { + mm_printk("%s: Shattering superpage is not supported\n", __func__); + rc = -EOPNOTSUPP; + goto out; + } + + entry = table + offsets[level]; + + rc = -EINVAL; + if ( !xen_pt_check_entry(*entry, mfn, level, flags) ) + goto out; + + /* If we are only populating page-table, then we are done. */ + rc = 0; + if ( flags & _PAGE_POPULATE ) + goto out; + + /* We are removing the page */ + if ( !(flags & _PAGE_PRESENT) ) + memset(&pte, 0x00, sizeof(pte)); + else + { + /* We are inserting a mapping => Create new pte. */ + if ( !mfn_eq(mfn, INVALID_MFN) ) + { + pte = mfn_to_xen_entry(mfn, PAGE_AI_MASK(flags)); + + /* + * First and second level pages set pte.pt.table = 0, but + * third level entries set pte.pt.table = 1. + */ + pte.pt.table = (level == 3); + } + else /* We are updating the permission => Copy the current pte. */ + pte = *entry; + + /* Set permission */ + pte.pt.ro = PAGE_RO_MASK(flags); + pte.pt.xn = PAGE_XN_MASK(flags); + /* Set contiguous bit */ + pte.pt.contig = !!(flags & _PAGE_CONTIG); + } + + write_pte(entry, pte); + + rc = 0; + +out: + xen_unmap_table(table); + + return rc; +} + +/* Return the level where mapping should be done */ +static int xen_pt_mapping_level(unsigned long vfn, mfn_t mfn, unsigned long nr, + unsigned int flags) +{ + unsigned int level; + unsigned long mask; + + /* + * Don't take into account the MFN when removing mapping (i.e + * MFN_INVALID) to calculate the correct target order. + * + * Per the Arm Arm, `vfn` and `mfn` must be both superpage aligned. + * They are or-ed together and then checked against the size of + * each level. + * + * `left` is not included and checked separately to allow + * superpage mapping even if it is not properly aligned (the + * user may have asked to map 2MB + 4k). + */ + mask = !mfn_eq(mfn, INVALID_MFN) ? mfn_x(mfn) : 0; + mask |= vfn; + + /* + * Always use level 3 mapping unless the caller request block + * mapping. + */ + if ( likely(!(flags & _PAGE_BLOCK)) ) + level = 3; + else if ( !(mask & (BIT(FIRST_ORDER, UL) - 1)) && + (nr >= BIT(FIRST_ORDER, UL)) ) + level = 1; + else if ( !(mask & (BIT(SECOND_ORDER, UL) - 1)) && + (nr >= BIT(SECOND_ORDER, UL)) ) + level = 2; + else + level = 3; + + return level; +} + +#define XEN_PT_4K_NR_CONTIG 16 + +/* + * Check whether the contiguous bit can be set. Return the number of + * contiguous entry allowed. If not allowed, return 1. + */ +static unsigned int xen_pt_check_contig(unsigned long vfn, mfn_t mfn, + unsigned int level, unsigned long left, + unsigned int flags) +{ + unsigned long nr_contig; + + /* + * Allow the contiguous bit to set when the caller requests block + * mapping. + */ + if ( !(flags & _PAGE_BLOCK) ) + return 1; + + /* + * We don't allow to remove mapping with the contiguous bit set. + * So shortcut the logic and directly return 1. + */ + if ( mfn_eq(mfn, INVALID_MFN) ) + return 1; + + /* + * The number of contiguous entries varies depending on the page + * granularity used. The logic below assumes 4KB. + */ + BUILD_BUG_ON(PAGE_SIZE != SZ_4K); + + /* + * In order to enable the contiguous bit, we should have enough entries + * to map left and both the virtual and physical address should be + * aligned to the size of 16 translation tables entries. + */ + nr_contig = BIT(XEN_PT_LEVEL_ORDER(level), UL) * XEN_PT_4K_NR_CONTIG; + + if ( (left < nr_contig) || ((mfn_x(mfn) | vfn) & (nr_contig - 1)) ) + return 1; + + return XEN_PT_4K_NR_CONTIG; +} + +static DEFINE_SPINLOCK(xen_pt_lock); + +static int xen_pt_update(unsigned long virt, + mfn_t mfn, + /* const on purpose as it is used for TLB flush */ + const unsigned long nr_mfns, + unsigned int flags) +{ + int rc = 0; + unsigned long vfn = virt >> PAGE_SHIFT; + unsigned long left = nr_mfns; + + /* + * For arm32, page-tables are different on each CPUs. Yet, they share + * some common mappings. It is assumed that only common mappings + * will be modified with this function. + * + * XXX: Add a check. + */ + const mfn_t root = maddr_to_mfn(READ_SYSREG64(TTBR0_EL2)); + + /* + * The hardware was configured to forbid mapping both writeable and + * executable. + * When modifying/creating mapping (i.e _PAGE_PRESENT is set), + * prevent any update if this happen. + */ + if ( (flags & _PAGE_PRESENT) && !PAGE_RO_MASK(flags) && + !PAGE_XN_MASK(flags) ) + { + mm_printk("Mappings should not be both Writeable and Executable.\n"); + return -EINVAL; + } + + if ( flags & _PAGE_CONTIG ) + { + mm_printk("_PAGE_CONTIG is an internal only flag.\n"); + return -EINVAL; + } + + if ( !IS_ALIGNED(virt, PAGE_SIZE) ) + { + mm_printk("The virtual address is not aligned to the page-size.\n"); + return -EINVAL; + } + + spin_lock(&xen_pt_lock); + + while ( left ) + { + unsigned int order, level, nr_contig, new_flags; + + level = xen_pt_mapping_level(vfn, mfn, left, flags); + order = XEN_PT_LEVEL_ORDER(level); + + ASSERT(left >= BIT(order, UL)); + + /* + * Check if we can set the contiguous mapping and update the + * flags accordingly. + */ + nr_contig = xen_pt_check_contig(vfn, mfn, level, left, flags); + new_flags = flags | ((nr_contig > 1) ? _PAGE_CONTIG : 0); + + for ( ; nr_contig > 0; nr_contig-- ) + { + rc = xen_pt_update_entry(root, vfn << PAGE_SHIFT, mfn, level, + new_flags); + if ( rc ) + break; + + vfn += 1U << order; + if ( !mfn_eq(mfn, INVALID_MFN) ) + mfn = mfn_add(mfn, 1U << order); + + left -= (1U << order); + } + + if ( rc ) + break; + } + + /* + * The TLBs flush can be safely skipped when a mapping is inserted + * as we don't allow mapping replacement (see xen_pt_check_entry()). + * + * For all the other cases, the TLBs will be flushed unconditionally + * even if the mapping has failed. This is because we may have + * partially modified the PT. This will prevent any unexpected + * behavior afterwards. + */ + if ( !((flags & _PAGE_PRESENT) && !mfn_eq(mfn, INVALID_MFN)) ) + flush_xen_tlb_range_va(virt, PAGE_SIZE * nr_mfns); + + spin_unlock(&xen_pt_lock); + + return rc; +} + +int map_pages_to_xen(unsigned long virt, + mfn_t mfn, + unsigned long nr_mfns, + unsigned int flags) +{ + return xen_pt_update(virt, mfn, nr_mfns, flags); +} + +int populate_pt_range(unsigned long virt, unsigned long nr_mfns) +{ + return xen_pt_update(virt, INVALID_MFN, nr_mfns, _PAGE_POPULATE); +} + +int destroy_xen_mappings(unsigned long s, unsigned long e) +{ + ASSERT(IS_ALIGNED(s, PAGE_SIZE)); + ASSERT(IS_ALIGNED(e, PAGE_SIZE)); + ASSERT(s <= e); + return xen_pt_update(s, INVALID_MFN, (e - s) >> PAGE_SHIFT, 0); +} + +int modify_xen_mappings(unsigned long s, unsigned long e, unsigned int flags) +{ + ASSERT(IS_ALIGNED(s, PAGE_SIZE)); + ASSERT(IS_ALIGNED(e, PAGE_SIZE)); + ASSERT(s <= e); + return xen_pt_update(s, INVALID_MFN, (e - s) >> PAGE_SHIFT, flags); +} + +/* Release all __init and __initdata ranges to be reused */ +void free_init_memory(void) +{ + paddr_t pa = virt_to_maddr(__init_begin); + unsigned long len = __init_end - __init_begin; + uint32_t insn; + unsigned int i, nr = len / sizeof(insn); + uint32_t *p; + int rc; + + rc = modify_xen_mappings((unsigned long)__init_begin, + (unsigned long)__init_end, PAGE_HYPERVISOR_RW); + if ( rc ) + panic("Unable to map RW the init section (rc = %d)\n", rc); + + /* + * From now on, init will not be used for execution anymore, + * so nuke the instruction cache to remove entries related to init. + */ + invalidate_icache_local(); + +#ifdef CONFIG_ARM_32 + /* udf instruction i.e (see A8.8.247 in ARM DDI 0406C.c) */ + insn = 0xe7f000f0; +#else + insn = AARCH64_BREAK_FAULT; +#endif + p = (uint32_t *)__init_begin; + for ( i = 0; i < nr; i++ ) + *(p + i) = insn; + + rc = destroy_xen_mappings((unsigned long)__init_begin, + (unsigned long)__init_end); + if ( rc ) + panic("Unable to remove the init section (rc = %d)\n", rc); + + init_domheap_pages(pa, pa + len); + printk("Freed %ldkB init memory.\n", (long)(__init_end-__init_begin)>>10); +} + +int xenmem_add_to_physmap_one( + struct domain *d, + unsigned int space, + union add_to_physmap_extra extra, + unsigned long idx, + gfn_t gfn) +{ + mfn_t mfn = INVALID_MFN; + int rc; + p2m_type_t t; + struct page_info *page = NULL; + + switch ( space ) + { + case XENMAPSPACE_grant_table: + rc = gnttab_map_frame(d, idx, gfn, &mfn); + if ( rc ) + return rc; + + /* Need to take care of the reference obtained in gnttab_map_frame(). */ + page = mfn_to_page(mfn); + t = p2m_ram_rw; + + break; + case XENMAPSPACE_shared_info: + if ( idx != 0 ) + return -EINVAL; + + mfn = virt_to_mfn(d->shared_info); + t = p2m_ram_rw; + + break; + case XENMAPSPACE_gmfn_foreign: + { + struct domain *od; + p2m_type_t p2mt; + + od = get_pg_owner(extra.foreign_domid); + if ( od == NULL ) + return -ESRCH; + + if ( od == d ) + { + put_pg_owner(od); + return -EINVAL; + } + + rc = xsm_map_gmfn_foreign(XSM_TARGET, d, od); + if ( rc ) + { + put_pg_owner(od); + return rc; + } + + /* Take reference to the foreign domain page. + * Reference will be released in XENMEM_remove_from_physmap */ + page = get_page_from_gfn(od, idx, &p2mt, P2M_ALLOC); + if ( !page ) + { + put_pg_owner(od); + return -EINVAL; + } + + if ( p2m_is_ram(p2mt) ) + t = (p2mt == p2m_ram_rw) ? p2m_map_foreign_rw : p2m_map_foreign_ro; + else + { + put_page(page); + put_pg_owner(od); + return -EINVAL; + } + + mfn = page_to_mfn(page); + + put_pg_owner(od); + break; + } + case XENMAPSPACE_dev_mmio: + rc = map_dev_mmio_page(d, gfn, _mfn(idx)); + return rc; + + default: + return -ENOSYS; + } + + /* + * Map at new location. Here we need to map xenheap RAM page differently + * because we need to store the valid GFN and make sure that nothing was + * mapped before (the stored GFN is invalid). And these actions need to be + * performed with the P2M lock held. The guest_physmap_add_entry() is just + * a wrapper on top of p2m_set_entry(). + */ + if ( !p2m_is_ram(t) || !is_xen_heap_mfn(mfn) ) + rc = guest_physmap_add_entry(d, gfn, mfn, 0, t); + else + { + struct p2m_domain *p2m = p2m_get_hostp2m(d); + + p2m_write_lock(p2m); + if ( gfn_eq(page_get_xenheap_gfn(mfn_to_page(mfn)), INVALID_GFN) ) + { + rc = p2m_set_entry(p2m, gfn, 1, mfn, t, p2m->default_access); + if ( !rc ) + page_set_xenheap_gfn(mfn_to_page(mfn), gfn); + } + else + /* + * Mandate the caller to first unmap the page before mapping it + * again. This is to prevent Xen creating an unwanted hole in + * the P2M. For instance, this could happen if the firmware stole + * a RAM address for mapping the shared_info page into but forgot + * to unmap it afterwards. + */ + rc = -EBUSY; + p2m_write_unlock(p2m); + } + + /* + * For XENMAPSPACE_gmfn_foreign if we failed to add the mapping, we need + * to drop the reference we took earlier. In all other cases we need to + * drop any reference we took earlier (perhaps indirectly). + */ + if ( space == XENMAPSPACE_gmfn_foreign ? rc : page != NULL ) + { + ASSERT(page != NULL); + put_page(page); + } + + return rc; +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/arm/mm_mpu.c b/xen/arch/arm/mm_mpu.c index 43e9a1be4d..87a12042cc 100644 --- a/xen/arch/arm/mm_mpu.c +++ b/xen/arch/arm/mm_mpu.c @@ -20,8 +20,10 @@ */ #include +#include #include #include +#include /* Xen MPU memory region mapping table. */ pr_t __aligned(PAGE_SIZE) __section(".data.page_aligned") @@ -38,6 +40,71 @@ uint64_t __ro_after_init next_transient_region_idx; /* Maximum number of supported MPU memory regions by the EL2 MPU. */ uint64_t __ro_after_init max_xen_mpumap; +/* TODO: Implementation on the first usage */ +void dump_hyp_walk(vaddr_t addr) +{ +} + +void * __init early_fdt_map(paddr_t fdt_paddr) +{ + return NULL; +} + +void __init remove_early_mappings(void) +{ +} + +int init_secondary_pagetables(int cpu) +{ + return -ENOSYS; +} + +void mmu_init_secondary_cpu(void) +{ +} + +void *ioremap_attr(paddr_t pa, size_t len, unsigned int attributes) +{ + return NULL; +} + +void *ioremap(paddr_t pa, size_t len) +{ + return NULL; +} + +int map_pages_to_xen(unsigned long virt, + mfn_t mfn, + unsigned long nr_mfns, + unsigned int flags) +{ + return -ENOSYS; +} + +int destroy_xen_mappings(unsigned long s, unsigned long e) +{ + return -ENOSYS; +} + +int modify_xen_mappings(unsigned long s, unsigned long e, unsigned int flags) +{ + return -ENOSYS; +} + +void free_init_memory(void) +{ +} + +int xenmem_add_to_physmap_one( + struct domain *d, + unsigned int space, + union add_to_physmap_extra extra, + unsigned long idx, + gfn_t gfn) +{ + return -ENOSYS; +} + /* * Local variables: * mode: C -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 13 05:35:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 05:35:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476540.738847 (Exim 4.92) (envelope-from ) id 1pGCig-0005G1-EZ; Fri, 13 Jan 2023 05:35:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476540.738847; Fri, 13 Jan 2023 05:35:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCig-0005ET-84; Fri, 13 Jan 2023 05:35:14 +0000 Received: by outflank-mailman (input) for mailman id 476540; Fri, 13 Jan 2023 05:35:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCf8-0005sP-Hv for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 05:31:34 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 89986dc7-9303-11ed-b8d0-410ff93cb8f0; Fri, 13 Jan 2023 06:31:32 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0DDCEFEC; Thu, 12 Jan 2023 21:32:14 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 4FAFA3F587; Thu, 12 Jan 2023 21:31:29 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 89986dc7-9303-11ed-b8d0-410ff93cb8f0 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v2 36/40] xen/mpu: Use secure hypervisor timer for AArch64v8R Date: Fri, 13 Jan 2023 13:29:09 +0800 Message-Id: <20230113052914.3845596-37-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230113052914.3845596-1-Penny.Zheng@arm.com> References: <20230113052914.3845596-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit As AArch64v8R only has one secure state, we have to use secure EL2 hypervisor timer for Xen in secure EL2. In this patch, we introduce a Kconfig option ARM_SECURE_STATE. With this new Kconfig option, we can re-define the timer's system register name in different secure state, but keep the timer code flow unchanged. Signed-off-by: Penny Zheng Signed-off-by: Wei Chen --- xen/arch/arm/Kconfig | 7 +++++++ xen/arch/arm/include/asm/arm64/sysregs.h | 21 ++++++++++++++++++++- xen/arch/arm/include/asm/cpregs.h | 4 ++-- xen/arch/arm/time.c | 14 +++++++------- 4 files changed, 36 insertions(+), 10 deletions(-) diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index 91491341c4..ee942a33bc 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -47,6 +47,13 @@ config ARM_EFI be booted as an EFI application. This is only useful for Xen that may run on systems that have UEFI firmware. +config ARM_SECURE_STATE + bool "Xen will run in Arm Secure State" + depends on ARM_V8R + help + In this state, a Processing Element (PE) can access the secure + physical address space, and the secure copy of banked registers. + config GICV3 bool "GICv3 driver" depends on !NEW_VGIC diff --git a/xen/arch/arm/include/asm/arm64/sysregs.h b/xen/arch/arm/include/asm/arm64/sysregs.h index c46daf6f69..9546e8e3d0 100644 --- a/xen/arch/arm/include/asm/arm64/sysregs.h +++ b/xen/arch/arm/include/asm/arm64/sysregs.h @@ -458,7 +458,6 @@ #define ZCR_ELx_LEN_SIZE 9 #define ZCR_ELx_LEN_MASK 0x1ff -/* System registers for Armv8-R AArch64 */ #ifdef CONFIG_HAS_MPU /* EL2 MPU Protection Region Base Address Register encode */ @@ -510,6 +509,26 @@ #endif +#ifdef CONFIG_ARM_SECURE_STATE +/* + * The Armv8-R AArch64 architecture always executes code in Secure + * state with EL2 as the highest Exception. + * + * Hypervisor timer registers for Secure EL2. + */ +#define CNTHPS_TVAL_EL2 S3_4_C14_C5_0 +#define CNTHPS_CTL_EL2 S3_4_C14_C5_1 +#define CNTHPS_CVAL_EL2 S3_4_C14_C5_2 +#define CNTHPx_TVAL_EL2 CNTHPS_TVAL_EL2 +#define CNTHPx_CTL_EL2 CNTHPS_CTL_EL2 +#define CNTHPx_CVAL_EL2 CNTHPS_CVAL_EL2 +#else +/* Hypervisor timer registers for Non-Secure EL2. */ +#define CNTHPx_TVAL_EL2 CNTHP_TVAL_EL2 +#define CNTHPx_CTL_EL2 CNTHP_CTL_EL2 +#define CNTHPx_CVAL_EL2 CNTHP_CVAL_EL2 +#endif /* CONFIG_ARM_SECURE_STATE */ + /* Access to system registers */ #define WRITE_SYSREG64(v, name) do { \ diff --git a/xen/arch/arm/include/asm/cpregs.h b/xen/arch/arm/include/asm/cpregs.h index 6b083de204..a704677fbc 100644 --- a/xen/arch/arm/include/asm/cpregs.h +++ b/xen/arch/arm/include/asm/cpregs.h @@ -374,8 +374,8 @@ #define CLIDR_EL1 CLIDR #define CNTFRQ_EL0 CNTFRQ #define CNTHCTL_EL2 CNTHCTL -#define CNTHP_CTL_EL2 CNTHP_CTL -#define CNTHP_CVAL_EL2 CNTHP_CVAL +#define CNTHPx_CTL_EL2 CNTHP_CTL +#define CNTHPx_CVAL_EL2 CNTHP_CVAL #define CNTKCTL_EL1 CNTKCTL #define CNTPCT_EL0 CNTPCT #define CNTP_CTL_EL0 CNTP_CTL diff --git a/xen/arch/arm/time.c b/xen/arch/arm/time.c index 433d7be909..3bba733b83 100644 --- a/xen/arch/arm/time.c +++ b/xen/arch/arm/time.c @@ -196,13 +196,13 @@ int reprogram_timer(s_time_t timeout) if ( timeout == 0 ) { - WRITE_SYSREG(0, CNTHP_CTL_EL2); + WRITE_SYSREG(0, CNTHPx_CTL_EL2); return 1; } deadline = ns_to_ticks(timeout) + boot_count; - WRITE_SYSREG64(deadline, CNTHP_CVAL_EL2); - WRITE_SYSREG(CNTx_CTL_ENABLE, CNTHP_CTL_EL2); + WRITE_SYSREG64(deadline, CNTHPx_CVAL_EL2); + WRITE_SYSREG(CNTx_CTL_ENABLE, CNTHPx_CTL_EL2); isb(); /* No need to check for timers in the past; the Generic Timer fires @@ -213,7 +213,7 @@ int reprogram_timer(s_time_t timeout) /* Handle the firing timer */ static void htimer_interrupt(int irq, void *dev_id, struct cpu_user_regs *regs) { - if ( unlikely(!(READ_SYSREG(CNTHP_CTL_EL2) & CNTx_CTL_PENDING)) ) + if ( unlikely(!(READ_SYSREG(CNTHPx_CTL_EL2) & CNTx_CTL_PENDING)) ) return; perfc_incr(hyp_timer_irqs); @@ -222,7 +222,7 @@ static void htimer_interrupt(int irq, void *dev_id, struct cpu_user_regs *regs) raise_softirq(TIMER_SOFTIRQ); /* Disable the timer to avoid more interrupts */ - WRITE_SYSREG(0, CNTHP_CTL_EL2); + WRITE_SYSREG(0, CNTHPx_CTL_EL2); } static void vtimer_interrupt(int irq, void *dev_id, struct cpu_user_regs *regs) @@ -281,7 +281,7 @@ void init_timer_interrupt(void) /* Do not let the VMs program the physical timer, only read the physical counter */ WRITE_SYSREG(CNTHCTL_EL2_EL1PCTEN, CNTHCTL_EL2); WRITE_SYSREG(0, CNTP_CTL_EL0); /* Physical timer disabled */ - WRITE_SYSREG(0, CNTHP_CTL_EL2); /* Hypervisor's timer disabled */ + WRITE_SYSREG(0, CNTHPx_CTL_EL2); /* Hypervisor's timer disabled */ isb(); request_irq(timer_irq[TIMER_HYP_PPI], 0, htimer_interrupt, @@ -301,7 +301,7 @@ void init_timer_interrupt(void) static void deinit_timer_interrupt(void) { WRITE_SYSREG(0, CNTP_CTL_EL0); /* Disable physical timer */ - WRITE_SYSREG(0, CNTHP_CTL_EL2); /* Disable hypervisor's timer */ + WRITE_SYSREG(0, CNTHPx_CTL_EL2); /* Disable hypervisor's timer */ isb(); release_irq(timer_irq[TIMER_HYP_PPI], NULL); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 13 05:35:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 05:35:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476542.738870 (Exim 4.92) (envelope-from ) id 1pGCip-00068n-4N; Fri, 13 Jan 2023 05:35:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476542.738870; Fri, 13 Jan 2023 05:35:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCio-00068S-Vu; Fri, 13 Jan 2023 05:35:22 +0000 Received: by outflank-mailman (input) for mailman id 476542; Fri, 13 Jan 2023 05:35:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCfJ-0005sJ-L5 for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 05:31:45 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 91180261-9303-11ed-91b6-6bf2151ebd3b; Fri, 13 Jan 2023 06:31:44 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8100DFEC; Thu, 12 Jan 2023 21:32:26 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 04C333F587; Thu, 12 Jan 2023 21:31:41 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 91180261-9303-11ed-91b6-6bf2151ebd3b From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v2 40/40] xen/mpu: add Kconfig option to enable Armv8-R AArch64 support Date: Fri, 13 Jan 2023 13:29:13 +0800 Message-Id: <20230113052914.3845596-41-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230113052914.3845596-1-Penny.Zheng@arm.com> References: <20230113052914.3845596-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Introduce a Kconfig option to enable Armv8-R64 architecture support. STATIC_MEMORY and HAS_MPU will be selected by ARM_V8R by default, because Armv8-R64 only has PMSAv8-64 on secure-EL2 and only supports statically configured system. Signed-off-by: Wei Chen --- xen/arch/arm/Kconfig | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index ee942a33bc..dc93b805a6 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -9,6 +9,15 @@ config ARM_64 select 64BIT select HAS_FAST_MULTIPLY +config ARM_V8R + bool "ARMv8-R AArch64 architecture support (UNSUPPORTED)" if UNSUPPORTED + default n + select STATIC_MEMORY + depends on ARM_64 + help + This option enables Armv8-R profile for Arm64. Enabling this option + results in selecting MPU. + config ARM def_bool y select HAS_ALTERNATIVE if !ARM_V8R @@ -68,6 +77,10 @@ config HAS_ITS bool "GICv3 ITS MSI controller support (UNSUPPORTED)" if UNSUPPORTED depends on GICV3 && !NEW_VGIC && !ARM_32 +config HAS_MPU + bool "Protected Memory System Architecture" + depends on ARM_V8R + config HVM def_bool y -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 13 05:35:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 05:35:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476566.738881 (Exim 4.92) (envelope-from ) id 1pGCj4-0007NV-Mn; Fri, 13 Jan 2023 05:35:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476566.738881; Fri, 13 Jan 2023 05:35:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCj4-0007NN-Ii; Fri, 13 Jan 2023 05:35:38 +0000 Received: by outflank-mailman (input) for mailman id 476566; Fri, 13 Jan 2023 05:35:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCeO-0005sP-7n for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 05:30:48 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 6dd4dc0f-9303-11ed-b8d0-410ff93cb8f0; Fri, 13 Jan 2023 06:30:45 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7405113D5; Thu, 12 Jan 2023 21:31:27 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id A74C73F587; Thu, 12 Jan 2023 21:30:42 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6dd4dc0f-9303-11ed-b8d0-410ff93cb8f0 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v2 22/40] xen/mpu: implement MPU version of setup_mm in setup_mpu.c Date: Fri, 13 Jan 2023 13:28:55 +0800 Message-Id: <20230113052914.3845596-23-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230113052914.3845596-1-Penny.Zheng@arm.com> References: <20230113052914.3845596-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In MPU system, system RAM shall be statically partitioned into different functionality section in Device Tree at the very beginning, including static xenheap, guest memory section, boot-module section, etc. So using a virtual contigious memory region to do direct-mapping for the whole system RAM is not applicable in MPU system. Function setup_static_mappings is introduced to set up MPU memory region mapping section by section based on static configuration in Device Tree. And this commit is only responsible for static xenheap mapping, which is implemented in setup_staticheap_mappings. All the other static memory section mapping will be introduced later. Signed-off-by: Penny Zheng Signed-off-by: Wei Chen --- xen/arch/arm/Makefile | 2 + xen/arch/arm/include/asm/mm_mpu.h | 5 +++ xen/arch/arm/mm_mpu.c | 41 ++++++++++++++++++ xen/arch/arm/setup_mpu.c | 70 +++++++++++++++++++++++++++++++ 4 files changed, 118 insertions(+) create mode 100644 xen/arch/arm/setup_mpu.c diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile index adeb17b7ab..23dfbc3333 100644 --- a/xen/arch/arm/Makefile +++ b/xen/arch/arm/Makefile @@ -53,6 +53,8 @@ obj-y += psci.o obj-y += setup.o ifneq ($(CONFIG_HAS_MPU), y) obj-y += setup_mmu.o +else +obj-y += setup_mpu.o endif obj-y += shutdown.o obj-y += smp.o diff --git a/xen/arch/arm/include/asm/mm_mpu.h b/xen/arch/arm/include/asm/mm_mpu.h index 3a4b07f187..fe6a828a50 100644 --- a/xen/arch/arm/include/asm/mm_mpu.h +++ b/xen/arch/arm/include/asm/mm_mpu.h @@ -3,6 +3,11 @@ #define __ARCH_ARM_MM_MPU__ #define setup_mm_mappings(boot_phys_offset) ((void)(boot_phys_offset)) +/* + * Function setup_static_mappings() sets up MPU memory region mapping + * section by section based on static configuration in Device Tree. + */ +extern void setup_static_mappings(void); static inline paddr_t __virt_to_maddr(vaddr_t va) { diff --git a/xen/arch/arm/mm_mpu.c b/xen/arch/arm/mm_mpu.c index b34dbf4515..f057ee26df 100644 --- a/xen/arch/arm/mm_mpu.c +++ b/xen/arch/arm/mm_mpu.c @@ -523,6 +523,47 @@ void * __init early_fdt_map(paddr_t fdt_paddr) return fdt_virt; } +/* + * Heap must be statically configured in Device Tree through + * "xen,static-heap" in MPU system. + */ +static void __init setup_staticheap_mappings(void) +{ + unsigned int bank = 0; + + for ( ; bank < bootinfo.reserved_mem.nr_banks; bank++ ) + { + if ( bootinfo.reserved_mem.bank[bank].type == MEMBANK_STATIC_HEAP ) + { + paddr_t bank_start = round_pgup( + bootinfo.reserved_mem.bank[bank].start); + paddr_t bank_size = round_pgdown( + bootinfo.reserved_mem.bank[bank].size); + + /* Map static heap with fixed MPU memory region */ + + if ( map_pages_to_xen(bank_start, maddr_to_mfn(bank_start), + bank_size >> PAGE_SHIFT, + REGION_HYPERVISOR) ) + panic("mpu: failed to map static heap\n"); + } + } +} + +/* + * System RAM is statically partitioned into different functionality + * section in Device Tree, including static xenheap, guest memory + * section, boot-module section, etc. + * Function setup_static_mappings sets up MPU memory region mapping + * section by section. + */ +void __init setup_static_mappings(void) +{ + setup_staticheap_mappings(); + + /* TODO: guest memory section, device memory section, boot-module section, etc */ +} + /* TODO: Implementation on the first usage */ void dump_hyp_walk(vaddr_t addr) { diff --git a/xen/arch/arm/setup_mpu.c b/xen/arch/arm/setup_mpu.c new file mode 100644 index 0000000000..ca0d8237d5 --- /dev/null +++ b/xen/arch/arm/setup_mpu.c @@ -0,0 +1,70 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * xen/arch/arm/setup_mpu.c + * + * Early bringup code for an Armv8-R with virt extensions. + * + * Copyright (C) 2022 Arm Ltd. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program. If not, see . + */ + +#include +#include +#include +#include +#include +#include + +void __init setup_mm(void) +{ + paddr_t ram_start = ~0, ram_end = 0, ram_size = 0; + unsigned int bank; + + if ( !bootinfo.mem.nr_banks ) + panic("No memory bank\n"); + + init_pdx(); + + populate_boot_allocator(); + + total_pages = 0; + for ( bank = 0 ; bank < bootinfo.mem.nr_banks; bank++ ) + { + paddr_t bank_start = round_pgup(bootinfo.mem.bank[bank].start); + paddr_t bank_size = bootinfo.mem.bank[bank].size; + paddr_t bank_end = round_pgdown(bank_start + bank_size); + + ram_size = ram_size + bank_size; + ram_start = min(ram_start, bank_start); + ram_end = max(ram_end, bank_end); + } + + setup_static_mappings(); + + total_pages += ram_size >> PAGE_SHIFT; + max_page = PFN_DOWN(ram_end); + + setup_frametable_mappings(ram_start, ram_end); + + init_staticmem_pages(); +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 13 05:35:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 05:35:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476570.738892 (Exim 4.92) (envelope-from ) id 1pGCj6-0007gU-0Y; Fri, 13 Jan 2023 05:35:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476570.738892; Fri, 13 Jan 2023 05:35:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCj5-0007g1-SF; Fri, 13 Jan 2023 05:35:39 +0000 Received: by outflank-mailman (input) for mailman id 476570; Fri, 13 Jan 2023 05:35:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCfD-0005sJ-FV for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 05:31:40 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 8ba636c7-9303-11ed-91b6-6bf2151ebd3b; Fri, 13 Jan 2023 06:31:35 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6987DFEC; Thu, 12 Jan 2023 21:32:17 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 6B5C43F587; Thu, 12 Jan 2023 21:31:32 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8ba636c7-9303-11ed-91b6-6bf2151ebd3b From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v2 37/40] xen/mpu: move MMU specific P2M code to p2m_mmu.c Date: Fri, 13 Jan 2023 13:29:10 +0800 Message-Id: <20230113052914.3845596-38-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230113052914.3845596-1-Penny.Zheng@arm.com> References: <20230113052914.3845596-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Current P2M implementation is designed for MMU system. Only a few codes can be shared by MPU system, like P2M pool, IPA, etc We move the MMU-specific codes into p2m_mmu.c, and place stub functions in p2m_mpu.c which wait for implementing on the first usage. And we keep generic codes in p2m.c We also move MMU-specific definitions to p2m_mmu.h, like P2M_ROOT_LEVEL and function p2m_tlb_flush_sync. Signed-off-by: Penny Zheng Signed-off-by: Wei Chen --- xen/arch/arm/Makefile | 5 + xen/arch/arm/include/asm/p2m.h | 17 +- xen/arch/arm/include/asm/p2m_mmu.h | 28 + xen/arch/arm/p2m.c | 2276 +-------------------------- xen/arch/arm/p2m_mmu.c | 2295 ++++++++++++++++++++++++++++ xen/arch/arm/p2m_mpu.c | 191 +++ 6 files changed, 2528 insertions(+), 2284 deletions(-) create mode 100644 xen/arch/arm/include/asm/p2m_mmu.h create mode 100644 xen/arch/arm/p2m_mmu.c create mode 100644 xen/arch/arm/p2m_mpu.c diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile index c949661590..ea650db52b 100644 --- a/xen/arch/arm/Makefile +++ b/xen/arch/arm/Makefile @@ -44,6 +44,11 @@ obj-y += mm_mpu.o endif obj-y += monitor.o obj-y += p2m.o +ifneq ($(CONFIG_HAS_MPU), y) +obj-y += p2m_mmu.o +else +obj-y += p2m_mpu.o +endif obj-y += percpu.o obj-y += platform.o obj-y += platform_hypercall.o diff --git a/xen/arch/arm/include/asm/p2m.h b/xen/arch/arm/include/asm/p2m.h index 91df922e1c..a430aca232 100644 --- a/xen/arch/arm/include/asm/p2m.h +++ b/xen/arch/arm/include/asm/p2m.h @@ -14,17 +14,6 @@ /* Holds the bit size of IPAs in p2m tables. */ extern unsigned int p2m_ipa_bits; -#ifdef CONFIG_ARM_64 -extern unsigned int p2m_root_order; -extern unsigned int p2m_root_level; -#define P2M_ROOT_ORDER p2m_root_order -#define P2M_ROOT_LEVEL p2m_root_level -#else -/* First level P2M is always 2 consecutive pages */ -#define P2M_ROOT_ORDER 1 -#define P2M_ROOT_LEVEL 1 -#endif - struct domain; extern void memory_type_changed(struct domain *); @@ -162,6 +151,10 @@ typedef enum { #endif #include +#ifndef CONFIG_HAS_MPU +#include +#endif + static inline bool arch_acquire_resource_check(struct domain *d) { /* @@ -252,8 +245,6 @@ static inline int p2m_is_write_locked(struct p2m_domain *p2m) return rw_is_write_locked(&p2m->lock); } -void p2m_tlb_flush_sync(struct p2m_domain *p2m); - /* Look up the MFN corresponding to a domain's GFN. */ mfn_t p2m_lookup(struct domain *d, gfn_t gfn, p2m_type_t *t); diff --git a/xen/arch/arm/include/asm/p2m_mmu.h b/xen/arch/arm/include/asm/p2m_mmu.h new file mode 100644 index 0000000000..a0f2440336 --- /dev/null +++ b/xen/arch/arm/include/asm/p2m_mmu.h @@ -0,0 +1,28 @@ +#ifndef _XEN_P2M_MMU_H +#define _XEN_P2M_MMU_H + +#ifdef CONFIG_ARM_64 +extern unsigned int p2m_root_order; +extern unsigned int p2m_root_level; +#define P2M_ROOT_ORDER p2m_root_order +#define P2M_ROOT_LEVEL p2m_root_level +#else +/* First level P2M is always 2 consecutive pages */ +#define P2M_ROOT_ORDER 1 +#define P2M_ROOT_LEVEL 1 +#endif + +struct p2m_domain; + +void p2m_tlb_flush_sync(struct p2m_domain *p2m); + +#endif /* _XEN_P2M_MMU_H */ + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c index 948f199d84..42f51051e0 100644 --- a/xen/arch/arm/p2m.c +++ b/xen/arch/arm/p2m.c @@ -1,36 +1,9 @@ /* SPDX-License-Identifier: GPL-2.0 */ -#include -#include -#include -#include #include #include -#include -#include #include -#include -#include #include -#include - -#define MAX_VMID_8_BIT (1UL << 8) -#define MAX_VMID_16_BIT (1UL << 16) - -#define INVALID_VMID 0 /* VMID 0 is reserved */ - -#ifdef CONFIG_ARM_64 -unsigned int __read_mostly p2m_root_order; -unsigned int __read_mostly p2m_root_level; -static unsigned int __read_mostly max_vmid = MAX_VMID_8_BIT; -/* VMID is by default 8 bit width on AArch64 */ -#define MAX_VMID max_vmid -#else -/* VMID is always 8 bit width on AArch32 */ -#define MAX_VMID MAX_VMID_8_BIT -#endif - -#define P2M_ROOT_PAGES (1<arch.paging.lock); - pg = page_list_remove_head(&d->arch.paging.p2m_freelist); - spin_unlock(&d->arch.paging.lock); - } - - return pg; -} - -static void p2m_free_page(struct domain *d, struct page_info *pg) -{ - if ( is_hardware_domain(d) ) - free_domheap_page(pg); - else - { - spin_lock(&d->arch.paging.lock); - page_list_add_tail(pg, &d->arch.paging.p2m_freelist); - spin_unlock(&d->arch.paging.lock); - } -} - /* Return the size of the pool, in bytes. */ int arch_get_paging_mempool_size(struct domain *d, uint64_t *size) { @@ -186,441 +115,10 @@ int p2m_teardown_allocation(struct domain *d) return ret; } -/* Unlock the flush and do a P2M TLB flush if necessary */ -void p2m_write_unlock(struct p2m_domain *p2m) -{ - /* - * The final flush is done with the P2M write lock taken to avoid - * someone else modifying the P2M wbefore the TLB invalidation has - * completed. - */ - p2m_tlb_flush_sync(p2m); - - write_unlock(&p2m->lock); -} - -void p2m_dump_info(struct domain *d) -{ - struct p2m_domain *p2m = p2m_get_hostp2m(d); - - p2m_read_lock(p2m); - printk("p2m mappings for domain %d (vmid %d):\n", - d->domain_id, p2m->vmid); - BUG_ON(p2m->stats.mappings[0] || p2m->stats.shattered[0]); - printk(" 1G mappings: %ld (shattered %ld)\n", - p2m->stats.mappings[1], p2m->stats.shattered[1]); - printk(" 2M mappings: %ld (shattered %ld)\n", - p2m->stats.mappings[2], p2m->stats.shattered[2]); - printk(" 4K mappings: %ld\n", p2m->stats.mappings[3]); - p2m_read_unlock(p2m); -} - void memory_type_changed(struct domain *d) { } -void dump_p2m_lookup(struct domain *d, paddr_t addr) -{ - struct p2m_domain *p2m = p2m_get_hostp2m(d); - - printk("dom%d IPA 0x%"PRIpaddr"\n", d->domain_id, addr); - - printk("P2M @ %p mfn:%#"PRI_mfn"\n", - p2m->root, mfn_x(page_to_mfn(p2m->root))); - - dump_pt_walk(page_to_maddr(p2m->root), addr, - P2M_ROOT_LEVEL, P2M_ROOT_PAGES); -} - -/* - * p2m_save_state and p2m_restore_state work in pair to workaround - * ARM64_WORKAROUND_AT_SPECULATE. p2m_save_state will set-up VTTBR to - * point to the empty page-tables to stop allocating TLB entries. - */ -void p2m_save_state(struct vcpu *p) -{ - p->arch.sctlr = READ_SYSREG(SCTLR_EL1); - - if ( cpus_have_const_cap(ARM64_WORKAROUND_AT_SPECULATE) ) - { - WRITE_SYSREG64(generate_vttbr(INVALID_VMID, empty_root_mfn), VTTBR_EL2); - /* - * Ensure VTTBR_EL2 is correctly synchronized so we can restore - * the next vCPU context without worrying about AT instruction - * speculation. - */ - isb(); - } -} - -void p2m_restore_state(struct vcpu *n) -{ - struct p2m_domain *p2m = p2m_get_hostp2m(n->domain); - uint8_t *last_vcpu_ran; - - if ( is_idle_vcpu(n) ) - return; - - WRITE_SYSREG(n->arch.sctlr, SCTLR_EL1); - WRITE_SYSREG(n->arch.hcr_el2, HCR_EL2); - - /* - * ARM64_WORKAROUND_AT_SPECULATE: VTTBR_EL2 should be restored after all - * registers associated to EL1/EL0 translations regime have been - * synchronized. - */ - asm volatile(ALTERNATIVE("nop", "isb", ARM64_WORKAROUND_AT_SPECULATE)); - WRITE_SYSREG64(p2m->vttbr, VTTBR_EL2); - - last_vcpu_ran = &p2m->last_vcpu_ran[smp_processor_id()]; - - /* - * While we are restoring an out-of-context translation regime - * we still need to ensure: - * - VTTBR_EL2 is synchronized before flushing the TLBs - * - All registers for EL1 are synchronized before executing an AT - * instructions targeting S1/S2. - */ - isb(); - - /* - * Flush local TLB for the domain to prevent wrong TLB translation - * when running multiple vCPU of the same domain on a single pCPU. - */ - if ( *last_vcpu_ran != INVALID_VCPU_ID && *last_vcpu_ran != n->vcpu_id ) - flush_guest_tlb_local(); - - *last_vcpu_ran = n->vcpu_id; -} - -/* - * Force a synchronous P2M TLB flush. - * - * Must be called with the p2m lock held. - */ -static void p2m_force_tlb_flush_sync(struct p2m_domain *p2m) -{ - unsigned long flags = 0; - uint64_t ovttbr; - - ASSERT(p2m_is_write_locked(p2m)); - - /* - * ARM only provides an instruction to flush TLBs for the current - * VMID. So switch to the VTTBR of a given P2M if different. - */ - ovttbr = READ_SYSREG64(VTTBR_EL2); - if ( ovttbr != p2m->vttbr ) - { - uint64_t vttbr; - - local_irq_save(flags); - - /* - * ARM64_WORKAROUND_AT_SPECULATE: We need to stop AT to allocate - * TLBs entries because the context is partially modified. We - * only need the VMID for flushing the TLBs, so we can generate - * a new VTTBR with the VMID to flush and the empty root table. - */ - if ( !cpus_have_const_cap(ARM64_WORKAROUND_AT_SPECULATE) ) - vttbr = p2m->vttbr; - else - vttbr = generate_vttbr(p2m->vmid, empty_root_mfn); - - WRITE_SYSREG64(vttbr, VTTBR_EL2); - - /* Ensure VTTBR_EL2 is synchronized before flushing the TLBs */ - isb(); - } - - flush_guest_tlb(); - - if ( ovttbr != READ_SYSREG64(VTTBR_EL2) ) - { - WRITE_SYSREG64(ovttbr, VTTBR_EL2); - /* Ensure VTTBR_EL2 is back in place before continuing. */ - isb(); - local_irq_restore(flags); - } - - p2m->need_flush = false; -} - -void p2m_tlb_flush_sync(struct p2m_domain *p2m) -{ - if ( p2m->need_flush ) - p2m_force_tlb_flush_sync(p2m); -} - -/* - * Find and map the root page table. The caller is responsible for - * unmapping the table. - * - * The function will return NULL if the offset of the root table is - * invalid. - */ -static lpae_t *p2m_get_root_pointer(struct p2m_domain *p2m, - gfn_t gfn) -{ - unsigned long root_table; - - /* - * While the root table index is the offset from the previous level, - * we can't use (P2M_ROOT_LEVEL - 1) because the root level might be - * 0. Yet we still want to check if all the unused bits are zeroed. - */ - root_table = gfn_x(gfn) >> (XEN_PT_LEVEL_ORDER(P2M_ROOT_LEVEL) + - XEN_PT_LPAE_SHIFT); - if ( root_table >= P2M_ROOT_PAGES ) - return NULL; - - return __map_domain_page(p2m->root + root_table); -} - -/* - * Lookup the MFN corresponding to a domain's GFN. - * Lookup mem access in the ratrix tree. - * The entries associated to the GFN is considered valid. - */ -static p2m_access_t p2m_mem_access_radix_get(struct p2m_domain *p2m, gfn_t gfn) -{ - void *ptr; - - if ( !p2m->mem_access_enabled ) - return p2m->default_access; - - ptr = radix_tree_lookup(&p2m->mem_access_settings, gfn_x(gfn)); - if ( !ptr ) - return p2m_access_rwx; - else - return radix_tree_ptr_to_int(ptr); -} - -/* - * In the case of the P2M, the valid bit is used for other purpose. Use - * the type to check whether an entry is valid. - */ -static inline bool p2m_is_valid(lpae_t pte) -{ - return pte.p2m.type != p2m_invalid; -} - -/* - * lpae_is_* helpers don't check whether the valid bit is set in the - * PTE. Provide our own overlay to check the valid bit. - */ -static inline bool p2m_is_mapping(lpae_t pte, unsigned int level) -{ - return p2m_is_valid(pte) && lpae_is_mapping(pte, level); -} - -static inline bool p2m_is_superpage(lpae_t pte, unsigned int level) -{ - return p2m_is_valid(pte) && lpae_is_superpage(pte, level); -} - -#define GUEST_TABLE_MAP_FAILED 0 -#define GUEST_TABLE_SUPER_PAGE 1 -#define GUEST_TABLE_NORMAL_PAGE 2 - -static int p2m_create_table(struct p2m_domain *p2m, lpae_t *entry); - -/* - * Take the currently mapped table, find the corresponding GFN entry, - * and map the next table, if available. The previous table will be - * unmapped if the next level was mapped (e.g GUEST_TABLE_NORMAL_PAGE - * returned). - * - * The read_only parameters indicates whether intermediate tables should - * be allocated when not present. - * - * Return values: - * GUEST_TABLE_MAP_FAILED: Either read_only was set and the entry - * was empty, or allocating a new page failed. - * GUEST_TABLE_NORMAL_PAGE: next level mapped normally - * GUEST_TABLE_SUPER_PAGE: The next entry points to a superpage. - */ -static int p2m_next_level(struct p2m_domain *p2m, bool read_only, - unsigned int level, lpae_t **table, - unsigned int offset) -{ - lpae_t *entry; - int ret; - mfn_t mfn; - - entry = *table + offset; - - if ( !p2m_is_valid(*entry) ) - { - if ( read_only ) - return GUEST_TABLE_MAP_FAILED; - - ret = p2m_create_table(p2m, entry); - if ( ret ) - return GUEST_TABLE_MAP_FAILED; - } - - /* The function p2m_next_level is never called at the 3rd level */ - ASSERT(level < 3); - if ( p2m_is_mapping(*entry, level) ) - return GUEST_TABLE_SUPER_PAGE; - - mfn = lpae_get_mfn(*entry); - - unmap_domain_page(*table); - *table = map_domain_page(mfn); - - return GUEST_TABLE_NORMAL_PAGE; -} - -/* - * Get the details of a given gfn. - * - * If the entry is present, the associated MFN will be returned and the - * access and type filled up. The page_order will correspond to the - * order of the mapping in the page table (i.e it could be a superpage). - * - * If the entry is not present, INVALID_MFN will be returned and the - * page_order will be set according to the order of the invalid range. - * - * valid will contain the value of bit[0] (e.g valid bit) of the - * entry. - */ -mfn_t p2m_get_entry(struct p2m_domain *p2m, gfn_t gfn, - p2m_type_t *t, p2m_access_t *a, - unsigned int *page_order, - bool *valid) -{ - paddr_t addr = gfn_to_gaddr(gfn); - unsigned int level = 0; - lpae_t entry, *table; - int rc; - mfn_t mfn = INVALID_MFN; - p2m_type_t _t; - DECLARE_OFFSETS(offsets, addr); - - ASSERT(p2m_is_locked(p2m)); - BUILD_BUG_ON(THIRD_MASK != PAGE_MASK); - - /* Allow t to be NULL */ - t = t ?: &_t; - - *t = p2m_invalid; - - if ( valid ) - *valid = false; - - /* XXX: Check if the mapping is lower than the mapped gfn */ - - /* This gfn is higher than the highest the p2m map currently holds */ - if ( gfn_x(gfn) > gfn_x(p2m->max_mapped_gfn) ) - { - for ( level = P2M_ROOT_LEVEL; level < 3; level++ ) - if ( (gfn_x(gfn) & (XEN_PT_LEVEL_MASK(level) >> PAGE_SHIFT)) > - gfn_x(p2m->max_mapped_gfn) ) - break; - - goto out; - } - - table = p2m_get_root_pointer(p2m, gfn); - - /* - * the table should always be non-NULL because the gfn is below - * p2m->max_mapped_gfn and the root table pages are always present. - */ - if ( !table ) - { - ASSERT_UNREACHABLE(); - level = P2M_ROOT_LEVEL; - goto out; - } - - for ( level = P2M_ROOT_LEVEL; level < 3; level++ ) - { - rc = p2m_next_level(p2m, true, level, &table, offsets[level]); - if ( rc == GUEST_TABLE_MAP_FAILED ) - goto out_unmap; - else if ( rc != GUEST_TABLE_NORMAL_PAGE ) - break; - } - - entry = table[offsets[level]]; - - if ( p2m_is_valid(entry) ) - { - *t = entry.p2m.type; - - if ( a ) - *a = p2m_mem_access_radix_get(p2m, gfn); - - mfn = lpae_get_mfn(entry); - /* - * The entry may point to a superpage. Find the MFN associated - * to the GFN. - */ - mfn = mfn_add(mfn, - gfn_x(gfn) & ((1UL << XEN_PT_LEVEL_ORDER(level)) - 1)); - - if ( valid ) - *valid = lpae_is_valid(entry); - } - -out_unmap: - unmap_domain_page(table); - -out: - if ( page_order ) - *page_order = XEN_PT_LEVEL_ORDER(level); - - return mfn; -} - -mfn_t p2m_lookup(struct domain *d, gfn_t gfn, p2m_type_t *t) -{ - mfn_t mfn; - struct p2m_domain *p2m = p2m_get_hostp2m(d); - - p2m_read_lock(p2m); - mfn = p2m_get_entry(p2m, gfn, t, NULL, NULL, NULL); - p2m_read_unlock(p2m); - - return mfn; -} - -struct page_info *p2m_get_page_from_gfn(struct domain *d, gfn_t gfn, - p2m_type_t *t) -{ - struct page_info *page; - p2m_type_t p2mt; - mfn_t mfn = p2m_lookup(d, gfn, &p2mt); - - if ( t ) - *t = p2mt; - - if ( !p2m_is_any_ram(p2mt) ) - return NULL; - - if ( !mfn_valid(mfn) ) - return NULL; - - page = mfn_to_page(mfn); - - /* - * get_page won't work on foreign mapping because the page doesn't - * belong to the current domain. - */ - if ( p2m_is_foreign(p2mt) ) - { - struct domain *fdom = page_get_owner_and_reference(page); - ASSERT(fdom != NULL); - ASSERT(fdom != d); - return page; - } - - return get_page(page, d) ? page : NULL; -} - int guest_physmap_mark_populate_on_demand(struct domain *d, unsigned long gfn, unsigned int order) @@ -634,1780 +132,16 @@ unsigned long p2m_pod_decrease_reservation(struct domain *d, gfn_t gfn, return 0; } -static void p2m_set_permission(lpae_t *e, p2m_type_t t, p2m_access_t a) -{ - /* First apply type permissions */ - switch ( t ) - { - case p2m_ram_rw: - e->p2m.xn = 0; - e->p2m.write = 1; - break; - - case p2m_ram_ro: - e->p2m.xn = 0; - e->p2m.write = 0; - break; - - case p2m_iommu_map_rw: - case p2m_map_foreign_rw: - case p2m_grant_map_rw: - case p2m_mmio_direct_dev: - case p2m_mmio_direct_nc: - case p2m_mmio_direct_c: - e->p2m.xn = 1; - e->p2m.write = 1; - break; - - case p2m_iommu_map_ro: - case p2m_map_foreign_ro: - case p2m_grant_map_ro: - case p2m_invalid: - e->p2m.xn = 1; - e->p2m.write = 0; - break; - - case p2m_max_real_type: - BUG(); - break; - } - - /* Then restrict with access permissions */ - switch ( a ) - { - case p2m_access_rwx: - break; - case p2m_access_wx: - e->p2m.read = 0; - break; - case p2m_access_rw: - e->p2m.xn = 1; - break; - case p2m_access_w: - e->p2m.read = 0; - e->p2m.xn = 1; - break; - case p2m_access_rx: - case p2m_access_rx2rw: - e->p2m.write = 0; - break; - case p2m_access_x: - e->p2m.write = 0; - e->p2m.read = 0; - break; - case p2m_access_r: - e->p2m.write = 0; - e->p2m.xn = 1; - break; - case p2m_access_n: - case p2m_access_n2rwx: - e->p2m.read = e->p2m.write = 0; - e->p2m.xn = 1; - break; - } -} - -static lpae_t mfn_to_p2m_entry(mfn_t mfn, p2m_type_t t, p2m_access_t a) -{ - /* - * sh, xn and write bit will be defined in the following switches - * based on mattr and t. - */ - lpae_t e = (lpae_t) { - .p2m.af = 1, - .p2m.read = 1, - .p2m.table = 1, - .p2m.valid = 1, - .p2m.type = t, - }; - - BUILD_BUG_ON(p2m_max_real_type > (1 << 4)); - - switch ( t ) - { - case p2m_mmio_direct_dev: - e.p2m.mattr = MATTR_DEV; - e.p2m.sh = LPAE_SH_OUTER; - break; - - case p2m_mmio_direct_c: - e.p2m.mattr = MATTR_MEM; - e.p2m.sh = LPAE_SH_OUTER; - break; - - /* - * ARM ARM: Overlaying the shareability attribute (DDI - * 0406C.b B3-1376 to 1377) - * - * A memory region with a resultant memory type attribute of Normal, - * and a resultant cacheability attribute of Inner Non-cacheable, - * Outer Non-cacheable, must have a resultant shareability attribute - * of Outer Shareable, otherwise shareability is UNPREDICTABLE. - * - * On ARMv8 shareability is ignored and explicitly treated as Outer - * Shareable for Normal Inner Non_cacheable, Outer Non-cacheable. - * See the note for table D4-40, in page 1788 of the ARM DDI 0487A.j. - */ - case p2m_mmio_direct_nc: - e.p2m.mattr = MATTR_MEM_NC; - e.p2m.sh = LPAE_SH_OUTER; - break; - - default: - e.p2m.mattr = MATTR_MEM; - e.p2m.sh = LPAE_SH_INNER; - } - - p2m_set_permission(&e, t, a); - - ASSERT(!(mfn_to_maddr(mfn) & ~PADDR_MASK)); - - lpae_set_mfn(e, mfn); - - return e; -} - -/* Generate table entry with correct attributes. */ -static lpae_t page_to_p2m_table(struct page_info *page) +void __init p2m_restrict_ipa_bits(unsigned int ipa_bits) { /* - * The access value does not matter because the hardware will ignore - * the permission fields for table entry. - * - * We use p2m_ram_rw so the entry has a valid type. This is important - * for p2m_is_valid() to return valid on table entries. + * Calculate the minimum of the maximum IPA bits that any external entity + * can support. */ - return mfn_to_p2m_entry(page_to_mfn(page), p2m_ram_rw, p2m_access_rwx); -} - -static inline void p2m_write_pte(lpae_t *p, lpae_t pte, bool clean_pte) -{ - write_pte(p, pte); - if ( clean_pte ) - clean_dcache(*p); -} - -static inline void p2m_remove_pte(lpae_t *p, bool clean_pte) -{ - lpae_t pte; - - memset(&pte, 0x00, sizeof(pte)); - p2m_write_pte(p, pte, clean_pte); -} - -/* Allocate a new page table page and hook it in via the given entry. */ -static int p2m_create_table(struct p2m_domain *p2m, lpae_t *entry) -{ - struct page_info *page; - lpae_t *p; - - ASSERT(!p2m_is_valid(*entry)); - - page = p2m_alloc_page(p2m->domain); - if ( page == NULL ) - return -ENOMEM; - - page_list_add(page, &p2m->pages); - - p = __map_domain_page(page); - clear_page(p); - - if ( p2m->clean_pte ) - clean_dcache_va_range(p, PAGE_SIZE); - - unmap_domain_page(p); - - p2m_write_pte(entry, page_to_p2m_table(page), p2m->clean_pte); - - return 0; -} - -static int p2m_mem_access_radix_set(struct p2m_domain *p2m, gfn_t gfn, - p2m_access_t a) -{ - int rc; - - if ( !p2m->mem_access_enabled ) - return 0; - - if ( p2m_access_rwx == a ) - { - radix_tree_delete(&p2m->mem_access_settings, gfn_x(gfn)); - return 0; - } - - rc = radix_tree_insert(&p2m->mem_access_settings, gfn_x(gfn), - radix_tree_int_to_ptr(a)); - if ( rc == -EEXIST ) - { - /* If a setting already exists, change it to the new one */ - radix_tree_replace_slot( - radix_tree_lookup_slot( - &p2m->mem_access_settings, gfn_x(gfn)), - radix_tree_int_to_ptr(a)); - rc = 0; - } - - return rc; + if ( ipa_bits < p2m_ipa_bits ) + p2m_ipa_bits = ipa_bits; } -/* - * Put any references on the single 4K page referenced by pte. - * TODO: Handle superpages, for now we only take special references for leaf - * pages (specifically foreign ones, which can't be super mapped today). - */ -static void p2m_put_l3_page(const lpae_t pte) -{ - mfn_t mfn = lpae_get_mfn(pte); - - ASSERT(p2m_is_valid(pte)); - - /* - * TODO: Handle other p2m types - * - * It's safe to do the put_page here because page_alloc will - * flush the TLBs if the page is reallocated before the end of - * this loop. - */ - if ( p2m_is_foreign(pte.p2m.type) ) - { - ASSERT(mfn_valid(mfn)); - put_page(mfn_to_page(mfn)); - } - /* Detect the xenheap page and mark the stored GFN as invalid. */ - else if ( p2m_is_ram(pte.p2m.type) && is_xen_heap_mfn(mfn) ) - page_set_xenheap_gfn(mfn_to_page(mfn), INVALID_GFN); -} - -/* Free lpae sub-tree behind an entry */ -static void p2m_free_entry(struct p2m_domain *p2m, - lpae_t entry, unsigned int level) -{ - unsigned int i; - lpae_t *table; - mfn_t mfn; - struct page_info *pg; - - /* Nothing to do if the entry is invalid. */ - if ( !p2m_is_valid(entry) ) - return; - - if ( p2m_is_superpage(entry, level) || (level == 3) ) - { -#ifdef CONFIG_IOREQ_SERVER - /* - * If this gets called then either the entry was replaced by an entry - * with a different base (valid case) or the shattering of a superpage - * has failed (error case). - * So, at worst, the spurious mapcache invalidation might be sent. - */ - if ( p2m_is_ram(entry.p2m.type) && - domain_has_ioreq_server(p2m->domain) ) - ioreq_request_mapcache_invalidate(p2m->domain); -#endif - - p2m->stats.mappings[level]--; - /* Nothing to do if the entry is a super-page. */ - if ( level == 3 ) - p2m_put_l3_page(entry); - return; - } - - table = map_domain_page(lpae_get_mfn(entry)); - for ( i = 0; i < XEN_PT_LPAE_ENTRIES; i++ ) - p2m_free_entry(p2m, *(table + i), level + 1); - - unmap_domain_page(table); - - /* - * Make sure all the references in the TLB have been removed before - * freing the intermediate page table. - * XXX: Should we defer the free of the page table to avoid the - * flush? - */ - p2m_tlb_flush_sync(p2m); - - mfn = lpae_get_mfn(entry); - ASSERT(mfn_valid(mfn)); - - pg = mfn_to_page(mfn); - - page_list_del(pg, &p2m->pages); - p2m_free_page(p2m->domain, pg); -} - -static bool p2m_split_superpage(struct p2m_domain *p2m, lpae_t *entry, - unsigned int level, unsigned int target, - const unsigned int *offsets) -{ - struct page_info *page; - unsigned int i; - lpae_t pte, *table; - bool rv = true; - - /* Convenience aliases */ - mfn_t mfn = lpae_get_mfn(*entry); - unsigned int next_level = level + 1; - unsigned int level_order = XEN_PT_LEVEL_ORDER(next_level); - - /* - * This should only be called with target != level and the entry is - * a superpage. - */ - ASSERT(level < target); - ASSERT(p2m_is_superpage(*entry, level)); - - page = p2m_alloc_page(p2m->domain); - if ( !page ) - return false; - - page_list_add(page, &p2m->pages); - table = __map_domain_page(page); - - /* - * We are either splitting a first level 1G page into 512 second level - * 2M pages, or a second level 2M page into 512 third level 4K pages. - */ - for ( i = 0; i < XEN_PT_LPAE_ENTRIES; i++ ) - { - lpae_t *new_entry = table + i; - - /* - * Use the content of the superpage entry and override - * the necessary fields. So the correct permission are kept. - */ - pte = *entry; - lpae_set_mfn(pte, mfn_add(mfn, i << level_order)); - - /* - * First and second level pages set p2m.table = 0, but third - * level entries set p2m.table = 1. - */ - pte.p2m.table = (next_level == 3); - - write_pte(new_entry, pte); - } - - /* Update stats */ - p2m->stats.shattered[level]++; - p2m->stats.mappings[level]--; - p2m->stats.mappings[next_level] += XEN_PT_LPAE_ENTRIES; - - /* - * Shatter superpage in the page to the level we want to make the - * changes. - * This is done outside the loop to avoid checking the offset to - * know whether the entry should be shattered for every entry. - */ - if ( next_level != target ) - rv = p2m_split_superpage(p2m, table + offsets[next_level], - level + 1, target, offsets); - - if ( p2m->clean_pte ) - clean_dcache_va_range(table, PAGE_SIZE); - - unmap_domain_page(table); - - /* - * Even if we failed, we should install the newly allocated LPAE - * entry. The caller will be in charge to free the sub-tree. - */ - p2m_write_pte(entry, page_to_p2m_table(page), p2m->clean_pte); - - return rv; -} - -/* - * Insert an entry in the p2m. This should be called with a mapping - * equal to a page/superpage (4K, 2M, 1G). - */ -static int __p2m_set_entry(struct p2m_domain *p2m, - gfn_t sgfn, - unsigned int page_order, - mfn_t smfn, - p2m_type_t t, - p2m_access_t a) -{ - unsigned int level = 0; - unsigned int target = 3 - (page_order / XEN_PT_LPAE_SHIFT); - lpae_t *entry, *table, orig_pte; - int rc; - /* A mapping is removed if the MFN is invalid. */ - bool removing_mapping = mfn_eq(smfn, INVALID_MFN); - DECLARE_OFFSETS(offsets, gfn_to_gaddr(sgfn)); - - ASSERT(p2m_is_write_locked(p2m)); - - /* - * Check if the level target is valid: we only support - * 4K - 2M - 1G mapping. - */ - ASSERT(target > 0 && target <= 3); - - table = p2m_get_root_pointer(p2m, sgfn); - if ( !table ) - return -EINVAL; - - for ( level = P2M_ROOT_LEVEL; level < target; level++ ) - { - /* - * Don't try to allocate intermediate page table if the mapping - * is about to be removed. - */ - rc = p2m_next_level(p2m, removing_mapping, - level, &table, offsets[level]); - if ( rc == GUEST_TABLE_MAP_FAILED ) - { - /* - * We are here because p2m_next_level has failed to map - * the intermediate page table (e.g the table does not exist - * and they p2m tree is read-only). It is a valid case - * when removing a mapping as it may not exist in the - * page table. In this case, just ignore it. - */ - rc = removing_mapping ? 0 : -ENOENT; - goto out; - } - else if ( rc != GUEST_TABLE_NORMAL_PAGE ) - break; - } - - entry = table + offsets[level]; - - /* - * If we are here with level < target, we must be at a leaf node, - * and we need to break up the superpage. - */ - if ( level < target ) - { - /* We need to split the original page. */ - lpae_t split_pte = *entry; - - ASSERT(p2m_is_superpage(*entry, level)); - - if ( !p2m_split_superpage(p2m, &split_pte, level, target, offsets) ) - { - /* - * The current super-page is still in-place, so re-increment - * the stats. - */ - p2m->stats.mappings[level]++; - - /* Free the allocated sub-tree */ - p2m_free_entry(p2m, split_pte, level); - - rc = -ENOMEM; - goto out; - } - - /* - * Follow the break-before-sequence to update the entry. - * For more details see (D4.7.1 in ARM DDI 0487A.j). - */ - p2m_remove_pte(entry, p2m->clean_pte); - p2m_force_tlb_flush_sync(p2m); - - p2m_write_pte(entry, split_pte, p2m->clean_pte); - - /* then move to the level we want to make real changes */ - for ( ; level < target; level++ ) - { - rc = p2m_next_level(p2m, true, level, &table, offsets[level]); - - /* - * The entry should be found and either be a table - * or a superpage if level 3 is not targeted - */ - ASSERT(rc == GUEST_TABLE_NORMAL_PAGE || - (rc == GUEST_TABLE_SUPER_PAGE && target < 3)); - } - - entry = table + offsets[level]; - } - - /* - * We should always be there with the correct level because - * all the intermediate tables have been installed if necessary. - */ - ASSERT(level == target); - - orig_pte = *entry; - - /* - * The radix-tree can only work on 4KB. This is only used when - * memaccess is enabled and during shutdown. - */ - ASSERT(!p2m->mem_access_enabled || page_order == 0 || - p2m->domain->is_dying); - /* - * The access type should always be p2m_access_rwx when the mapping - * is removed. - */ - ASSERT(!mfn_eq(INVALID_MFN, smfn) || (a == p2m_access_rwx)); - /* - * Update the mem access permission before update the P2M. So we - * don't have to revert the mapping if it has failed. - */ - rc = p2m_mem_access_radix_set(p2m, sgfn, a); - if ( rc ) - goto out; - - /* - * Always remove the entry in order to follow the break-before-make - * sequence when updating the translation table (D4.7.1 in ARM DDI - * 0487A.j). - */ - if ( lpae_is_valid(orig_pte) || removing_mapping ) - p2m_remove_pte(entry, p2m->clean_pte); - - if ( removing_mapping ) - /* Flush can be deferred if the entry is removed */ - p2m->need_flush |= !!lpae_is_valid(orig_pte); - else - { - lpae_t pte = mfn_to_p2m_entry(smfn, t, a); - - if ( level < 3 ) - pte.p2m.table = 0; /* Superpage entry */ - - /* - * It is necessary to flush the TLB before writing the new entry - * to keep coherency when the previous entry was valid. - * - * Although, it could be defered when only the permissions are - * changed (e.g in case of memaccess). - */ - if ( lpae_is_valid(orig_pte) ) - { - if ( likely(!p2m->mem_access_enabled) || - P2M_CLEAR_PERM(pte) != P2M_CLEAR_PERM(orig_pte) ) - p2m_force_tlb_flush_sync(p2m); - else - p2m->need_flush = true; - } - else if ( !p2m_is_valid(orig_pte) ) /* new mapping */ - p2m->stats.mappings[level]++; - - p2m_write_pte(entry, pte, p2m->clean_pte); - - p2m->max_mapped_gfn = gfn_max(p2m->max_mapped_gfn, - gfn_add(sgfn, (1UL << page_order) - 1)); - p2m->lowest_mapped_gfn = gfn_min(p2m->lowest_mapped_gfn, sgfn); - } - - if ( is_iommu_enabled(p2m->domain) && - (lpae_is_valid(orig_pte) || lpae_is_valid(*entry)) ) - { - unsigned int flush_flags = 0; - - if ( lpae_is_valid(orig_pte) ) - flush_flags |= IOMMU_FLUSHF_modified; - if ( lpae_is_valid(*entry) ) - flush_flags |= IOMMU_FLUSHF_added; - - rc = iommu_iotlb_flush(p2m->domain, _dfn(gfn_x(sgfn)), - 1UL << page_order, flush_flags); - } - else - rc = 0; - - /* - * Free the entry only if the original pte was valid and the base - * is different (to avoid freeing when permission is changed). - */ - if ( p2m_is_valid(orig_pte) && - !mfn_eq(lpae_get_mfn(*entry), lpae_get_mfn(orig_pte)) ) - p2m_free_entry(p2m, orig_pte, level); - -out: - unmap_domain_page(table); - - return rc; -} - -int p2m_set_entry(struct p2m_domain *p2m, - gfn_t sgfn, - unsigned long nr, - mfn_t smfn, - p2m_type_t t, - p2m_access_t a) -{ - int rc = 0; - - /* - * Any reference taken by the P2M mappings (e.g. foreign mapping) will - * be dropped in relinquish_p2m_mapping(). As the P2M will still - * be accessible after, we need to prevent mapping to be added when the - * domain is dying. - */ - if ( unlikely(p2m->domain->is_dying) ) - return -ENOMEM; - - while ( nr ) - { - unsigned long mask; - unsigned long order; - - /* - * Don't take into account the MFN when removing mapping (i.e - * MFN_INVALID) to calculate the correct target order. - * - * XXX: Support superpage mappings if nr is not aligned to a - * superpage size. - */ - mask = !mfn_eq(smfn, INVALID_MFN) ? mfn_x(smfn) : 0; - mask |= gfn_x(sgfn) | nr; - - /* Always map 4k by 4k when memaccess is enabled */ - if ( unlikely(p2m->mem_access_enabled) ) - order = THIRD_ORDER; - else if ( !(mask & ((1UL << FIRST_ORDER) - 1)) ) - order = FIRST_ORDER; - else if ( !(mask & ((1UL << SECOND_ORDER) - 1)) ) - order = SECOND_ORDER; - else - order = THIRD_ORDER; - - rc = __p2m_set_entry(p2m, sgfn, order, smfn, t, a); - if ( rc ) - break; - - sgfn = gfn_add(sgfn, (1 << order)); - if ( !mfn_eq(smfn, INVALID_MFN) ) - smfn = mfn_add(smfn, (1 << order)); - - nr -= (1 << order); - } - - return rc; -} - -/* Invalidate all entries in the table. The p2m should be write locked. */ -static void p2m_invalidate_table(struct p2m_domain *p2m, mfn_t mfn) -{ - lpae_t *table; - unsigned int i; - - ASSERT(p2m_is_write_locked(p2m)); - - table = map_domain_page(mfn); - - for ( i = 0; i < XEN_PT_LPAE_ENTRIES; i++ ) - { - lpae_t pte = table[i]; - - /* - * Writing an entry can be expensive because it may involve - * cleaning the cache. So avoid updating the entry if the valid - * bit is already cleared. - */ - if ( !pte.p2m.valid ) - continue; - - pte.p2m.valid = 0; - - p2m_write_pte(&table[i], pte, p2m->clean_pte); - } - - unmap_domain_page(table); - - p2m->need_flush = true; -} - -/* - * Invalidate all entries in the root page-tables. This is - * useful to get fault on entry and do an action. - * - * p2m_invalid_root() should not be called when the P2M is shared with - * the IOMMU because it will cause IOMMU fault. - */ -void p2m_invalidate_root(struct p2m_domain *p2m) -{ - unsigned int i; - - ASSERT(!iommu_use_hap_pt(p2m->domain)); - - p2m_write_lock(p2m); - - for ( i = 0; i < P2M_ROOT_LEVEL; i++ ) - p2m_invalidate_table(p2m, page_to_mfn(p2m->root + i)); - - p2m_write_unlock(p2m); -} - -/* - * Resolve any translation fault due to change in the p2m. This - * includes break-before-make and valid bit cleared. - */ -bool p2m_resolve_translation_fault(struct domain *d, gfn_t gfn) -{ - struct p2m_domain *p2m = p2m_get_hostp2m(d); - unsigned int level = 0; - bool resolved = false; - lpae_t entry, *table; - - /* Convenience aliases */ - DECLARE_OFFSETS(offsets, gfn_to_gaddr(gfn)); - - p2m_write_lock(p2m); - - /* This gfn is higher than the highest the p2m map currently holds */ - if ( gfn_x(gfn) > gfn_x(p2m->max_mapped_gfn) ) - goto out; - - table = p2m_get_root_pointer(p2m, gfn); - /* - * The table should always be non-NULL because the gfn is below - * p2m->max_mapped_gfn and the root table pages are always present. - */ - if ( !table ) - { - ASSERT_UNREACHABLE(); - goto out; - } - - /* - * Go down the page-tables until an entry has the valid bit unset or - * a block/page entry has been hit. - */ - for ( level = P2M_ROOT_LEVEL; level <= 3; level++ ) - { - int rc; - - entry = table[offsets[level]]; - - if ( level == 3 ) - break; - - /* Stop as soon as we hit an entry with the valid bit unset. */ - if ( !lpae_is_valid(entry) ) - break; - - rc = p2m_next_level(p2m, true, level, &table, offsets[level]); - if ( rc == GUEST_TABLE_MAP_FAILED ) - goto out_unmap; - else if ( rc != GUEST_TABLE_NORMAL_PAGE ) - break; - } - - /* - * If the valid bit of the entry is set, it means someone was playing with - * the Stage-2 page table. Nothing to do and mark the fault as resolved. - */ - if ( lpae_is_valid(entry) ) - { - resolved = true; - goto out_unmap; - } - - /* - * The valid bit is unset. If the entry is still not valid then the fault - * cannot be resolved, exit and report it. - */ - if ( !p2m_is_valid(entry) ) - goto out_unmap; - - /* - * Now we have an entry with valid bit unset, but still valid from - * the P2M point of view. - * - * If an entry is pointing to a table, each entry of the table will - * have there valid bit cleared. This allows a function to clear the - * full p2m with just a couple of write. The valid bit will then be - * propagated on the fault. - * If an entry is pointing to a block/page, no work to do for now. - */ - if ( lpae_is_table(entry, level) ) - p2m_invalidate_table(p2m, lpae_get_mfn(entry)); - - /* - * Now that the work on the entry is done, set the valid bit to prevent - * another fault on that entry. - */ - resolved = true; - entry.p2m.valid = 1; - - p2m_write_pte(table + offsets[level], entry, p2m->clean_pte); - - /* - * No need to flush the TLBs as the modified entry had the valid bit - * unset. - */ - -out_unmap: - unmap_domain_page(table); - -out: - p2m_write_unlock(p2m); - - return resolved; -} - -int p2m_insert_mapping(struct domain *d, gfn_t start_gfn, unsigned long nr, - mfn_t mfn, p2m_type_t t) -{ - struct p2m_domain *p2m = p2m_get_hostp2m(d); - int rc; - - p2m_write_lock(p2m); - rc = p2m_set_entry(p2m, start_gfn, nr, mfn, t, p2m->default_access); - p2m_write_unlock(p2m); - - return rc; -} - -static inline int p2m_remove_mapping(struct domain *d, - gfn_t start_gfn, - unsigned long nr, - mfn_t mfn) -{ - struct p2m_domain *p2m = p2m_get_hostp2m(d); - unsigned long i; - int rc; - - p2m_write_lock(p2m); - /* - * Before removing the GFN - MFN mapping for any RAM pages make sure - * that there is no difference between what is already mapped and what - * is requested to be unmapped. - * If they don't match bail out early. For instance, this could happen - * if two CPUs are requesting to unmap the same P2M entry concurrently. - */ - for ( i = 0; i < nr; ) - { - unsigned int cur_order; - p2m_type_t t; - mfn_t mfn_return = p2m_get_entry(p2m, gfn_add(start_gfn, i), &t, NULL, - &cur_order, NULL); - - if ( p2m_is_any_ram(t) && - (!mfn_valid(mfn) || !mfn_eq(mfn_add(mfn, i), mfn_return)) ) - { - rc = -EILSEQ; - goto out; - } - - i += (1UL << cur_order) - - ((gfn_x(start_gfn) + i) & ((1UL << cur_order) - 1)); - } - - rc = p2m_set_entry(p2m, start_gfn, nr, INVALID_MFN, - p2m_invalid, p2m_access_rwx); - -out: - p2m_write_unlock(p2m); - - return rc; -} - -int map_regions_p2mt(struct domain *d, - gfn_t gfn, - unsigned long nr, - mfn_t mfn, - p2m_type_t p2mt) -{ - return p2m_insert_mapping(d, gfn, nr, mfn, p2mt); -} - -int unmap_regions_p2mt(struct domain *d, - gfn_t gfn, - unsigned long nr, - mfn_t mfn) -{ - return p2m_remove_mapping(d, gfn, nr, mfn); -} - -int map_mmio_regions(struct domain *d, - gfn_t start_gfn, - unsigned long nr, - mfn_t mfn) -{ - return p2m_insert_mapping(d, start_gfn, nr, mfn, p2m_mmio_direct_dev); -} - -int unmap_mmio_regions(struct domain *d, - gfn_t start_gfn, - unsigned long nr, - mfn_t mfn) -{ - return p2m_remove_mapping(d, start_gfn, nr, mfn); -} - -int map_dev_mmio_page(struct domain *d, gfn_t gfn, mfn_t mfn) -{ - int res; - - if ( !iomem_access_permitted(d, mfn_x(mfn), mfn_x(mfn)) ) - return 0; - - res = p2m_insert_mapping(d, gfn, 1, mfn, p2m_mmio_direct_c); - if ( res < 0 ) - { - printk(XENLOG_G_ERR "Unable to map MFN %#"PRI_mfn" in %pd\n", - mfn_x(mfn), d); - return res; - } - - return 0; -} - -int guest_physmap_add_entry(struct domain *d, - gfn_t gfn, - mfn_t mfn, - unsigned long page_order, - p2m_type_t t) -{ - return p2m_insert_mapping(d, gfn, (1 << page_order), mfn, t); -} - -int guest_physmap_remove_page(struct domain *d, gfn_t gfn, mfn_t mfn, - unsigned int page_order) -{ - return p2m_remove_mapping(d, gfn, (1 << page_order), mfn); -} - -int set_foreign_p2m_entry(struct domain *d, const struct domain *fd, - unsigned long gfn, mfn_t mfn) -{ - struct page_info *page = mfn_to_page(mfn); - int rc; - - ASSERT(arch_acquire_resource_check(d)); - - if ( !get_page(page, fd) ) - return -EINVAL; - - /* - * It is valid to always use p2m_map_foreign_rw here as if this gets - * called then d != fd. A case when d == fd would be rejected by - * rcu_lock_remote_domain_by_id() earlier. Put a respective ASSERT() - * to catch incorrect usage in future. - */ - ASSERT(d != fd); - - rc = guest_physmap_add_entry(d, _gfn(gfn), mfn, 0, p2m_map_foreign_rw); - if ( rc ) - put_page(page); - - return rc; -} - -static struct page_info *p2m_allocate_root(void) -{ - struct page_info *page; - unsigned int i; - - page = alloc_domheap_pages(NULL, P2M_ROOT_ORDER, 0); - if ( page == NULL ) - return NULL; - - /* Clear both first level pages */ - for ( i = 0; i < P2M_ROOT_PAGES; i++ ) - clear_and_clean_page(page + i); - - return page; -} - -static int p2m_alloc_table(struct domain *d) -{ - struct p2m_domain *p2m = p2m_get_hostp2m(d); - - p2m->root = p2m_allocate_root(); - if ( !p2m->root ) - return -ENOMEM; - - p2m->vttbr = generate_vttbr(p2m->vmid, page_to_mfn(p2m->root)); - - /* - * Make sure that all TLBs corresponding to the new VMID are flushed - * before using it - */ - p2m_write_lock(p2m); - p2m_force_tlb_flush_sync(p2m); - p2m_write_unlock(p2m); - - return 0; -} - - -static spinlock_t vmid_alloc_lock = SPIN_LOCK_UNLOCKED; - -/* - * VTTBR_EL2 VMID field is 8 or 16 bits. AArch64 may support 16-bit VMID. - * Using a bitmap here limits us to 256 or 65536 (for AArch64) concurrent - * domains. The bitmap space will be allocated dynamically based on - * whether 8 or 16 bit VMIDs are supported. - */ -static unsigned long *vmid_mask; - -static void p2m_vmid_allocator_init(void) -{ - /* - * allocate space for vmid_mask based on MAX_VMID - */ - vmid_mask = xzalloc_array(unsigned long, BITS_TO_LONGS(MAX_VMID)); - - if ( !vmid_mask ) - panic("Could not allocate VMID bitmap space\n"); - - set_bit(INVALID_VMID, vmid_mask); -} - -static int p2m_alloc_vmid(struct domain *d) -{ - struct p2m_domain *p2m = p2m_get_hostp2m(d); - - int rc, nr; - - spin_lock(&vmid_alloc_lock); - - nr = find_first_zero_bit(vmid_mask, MAX_VMID); - - ASSERT(nr != INVALID_VMID); - - if ( nr == MAX_VMID ) - { - rc = -EBUSY; - printk(XENLOG_ERR "p2m.c: dom%d: VMID pool exhausted\n", d->domain_id); - goto out; - } - - set_bit(nr, vmid_mask); - - p2m->vmid = nr; - - rc = 0; - -out: - spin_unlock(&vmid_alloc_lock); - return rc; -} - -static void p2m_free_vmid(struct domain *d) -{ - struct p2m_domain *p2m = p2m_get_hostp2m(d); - spin_lock(&vmid_alloc_lock); - if ( p2m->vmid != INVALID_VMID ) - clear_bit(p2m->vmid, vmid_mask); - - spin_unlock(&vmid_alloc_lock); -} - -int p2m_teardown(struct domain *d, bool allow_preemption) -{ - struct p2m_domain *p2m = p2m_get_hostp2m(d); - unsigned long count = 0; - struct page_info *pg; - unsigned int i; - int rc = 0; - - if ( page_list_empty(&p2m->pages) ) - return 0; - - p2m_write_lock(p2m); - - /* - * We are about to free the intermediate page-tables, so clear the - * root to prevent any walk to use them. - */ - for ( i = 0; i < P2M_ROOT_PAGES; i++ ) - clear_and_clean_page(p2m->root + i); - - /* - * The domain will not be scheduled anymore, so in theory we should - * not need to flush the TLBs. Do it for safety purpose. - * - * Note that all the devices have already been de-assigned. So we don't - * need to flush the IOMMU TLB here. - */ - p2m_force_tlb_flush_sync(p2m); - - while ( (pg = page_list_remove_head(&p2m->pages)) ) - { - p2m_free_page(p2m->domain, pg); - count++; - /* Arbitrarily preempt every 512 iterations */ - if ( allow_preemption && !(count % 512) && hypercall_preempt_check() ) - { - rc = -ERESTART; - break; - } - } - - p2m_write_unlock(p2m); - - return rc; -} - -void p2m_final_teardown(struct domain *d) -{ - struct p2m_domain *p2m = p2m_get_hostp2m(d); - - /* p2m not actually initialized */ - if ( !p2m->domain ) - return; - - /* - * No need to call relinquish_p2m_mapping() here because - * p2m_final_teardown() is called either after domain_relinquish_resources() - * where relinquish_p2m_mapping() has been called, or from failure path of - * domain_create()/arch_domain_create() where mappings that require - * p2m_put_l3_page() should never be created. For the latter case, also see - * comment on top of the p2m_set_entry() for more info. - */ - - BUG_ON(p2m_teardown(d, false)); - ASSERT(page_list_empty(&p2m->pages)); - - while ( p2m_teardown_allocation(d) == -ERESTART ) - continue; /* No preemption support here */ - ASSERT(page_list_empty(&d->arch.paging.p2m_freelist)); - - if ( p2m->root ) - free_domheap_pages(p2m->root, P2M_ROOT_ORDER); - - p2m->root = NULL; - - p2m_free_vmid(d); - - radix_tree_destroy(&p2m->mem_access_settings, NULL); - - p2m->domain = NULL; -} - -int p2m_init(struct domain *d) -{ - struct p2m_domain *p2m = p2m_get_hostp2m(d); - int rc; - unsigned int cpu; - - rwlock_init(&p2m->lock); - spin_lock_init(&d->arch.paging.lock); - INIT_PAGE_LIST_HEAD(&p2m->pages); - INIT_PAGE_LIST_HEAD(&d->arch.paging.p2m_freelist); - - p2m->vmid = INVALID_VMID; - p2m->max_mapped_gfn = _gfn(0); - p2m->lowest_mapped_gfn = _gfn(ULONG_MAX); - - p2m->default_access = p2m_access_rwx; - p2m->mem_access_enabled = false; - radix_tree_init(&p2m->mem_access_settings); - - /* - * Some IOMMUs don't support coherent PT walk. When the p2m is - * shared with the CPU, Xen has to make sure that the PT changes have - * reached the memory - */ - p2m->clean_pte = is_iommu_enabled(d) && - !iommu_has_feature(d, IOMMU_FEAT_COHERENT_WALK); - - /* - * Make sure that the type chosen to is able to store the an vCPU ID - * between 0 and the maximum of virtual CPUS supported as long as - * the INVALID_VCPU_ID. - */ - BUILD_BUG_ON((1 << (sizeof(p2m->last_vcpu_ran[0]) * 8)) < MAX_VIRT_CPUS); - BUILD_BUG_ON((1 << (sizeof(p2m->last_vcpu_ran[0])* 8)) < INVALID_VCPU_ID); - - for_each_possible_cpu(cpu) - p2m->last_vcpu_ran[cpu] = INVALID_VCPU_ID; - - /* - * "Trivial" initialisation is now complete. Set the backpointer so - * p2m_teardown() and friends know to do something. - */ - p2m->domain = d; - - rc = p2m_alloc_vmid(d); - if ( rc ) - return rc; - - rc = p2m_alloc_table(d); - if ( rc ) - return rc; - - /* - * Hardware using GICv2 needs to create a P2M mapping of 8KB GICv2 area - * when the domain is created. Considering the worst case for page - * tables and keep a buffer, populate 16 pages to the P2M pages pool here. - * For GICv3, the above-mentioned P2M mapping is not necessary, but since - * the allocated 16 pages here would not be lost, hence populate these - * pages unconditionally. - */ - spin_lock(&d->arch.paging.lock); - rc = p2m_set_allocation(d, 16, NULL); - spin_unlock(&d->arch.paging.lock); - if ( rc ) - return rc; - - return 0; -} - -/* - * The function will go through the p2m and remove page reference when it - * is required. The mapping will be removed from the p2m. - * - * XXX: See whether the mapping can be left intact in the p2m. - */ -int relinquish_p2m_mapping(struct domain *d) -{ - struct p2m_domain *p2m = p2m_get_hostp2m(d); - unsigned long count = 0; - p2m_type_t t; - int rc = 0; - unsigned int order; - gfn_t start, end; - - BUG_ON(!d->is_dying); - /* No mappings can be added in the P2M after the P2M lock is released. */ - p2m_write_lock(p2m); - - start = p2m->lowest_mapped_gfn; - end = gfn_add(p2m->max_mapped_gfn, 1); - - for ( ; gfn_x(start) < gfn_x(end); - start = gfn_next_boundary(start, order) ) - { - mfn_t mfn = p2m_get_entry(p2m, start, &t, NULL, &order, NULL); - - count++; - /* - * Arbitrarily preempt every 512 iterations. - */ - if ( !(count % 512) && hypercall_preempt_check() ) - { - rc = -ERESTART; - break; - } - - /* - * p2m_set_entry will take care of removing reference on page - * when it is necessary and removing the mapping in the p2m. - */ - if ( !mfn_eq(mfn, INVALID_MFN) ) - { - /* - * For valid mapping, the start will always be aligned as - * entry will be removed whilst relinquishing. - */ - rc = __p2m_set_entry(p2m, start, order, INVALID_MFN, - p2m_invalid, p2m_access_rwx); - if ( unlikely(rc) ) - { - printk(XENLOG_G_ERR "Unable to remove mapping gfn=%#"PRI_gfn" order=%u from the p2m of domain %d\n", gfn_x(start), order, d->domain_id); - break; - } - } - } - - /* - * Update lowest_mapped_gfn so on the next call we still start where - * we stopped. - */ - p2m->lowest_mapped_gfn = start; - - p2m_write_unlock(p2m); - - return rc; -} - -int p2m_cache_flush_range(struct domain *d, gfn_t *pstart, gfn_t end) -{ - struct p2m_domain *p2m = p2m_get_hostp2m(d); - gfn_t next_block_gfn; - gfn_t start = *pstart; - mfn_t mfn = INVALID_MFN; - p2m_type_t t; - unsigned int order; - int rc = 0; - /* Counter for preemption */ - unsigned short count = 0; - - /* - * The operation cache flush will invalidate the RAM assigned to the - * guest in a given range. It will not modify the page table and - * flushing the cache whilst the page is used by another CPU is - * fine. So using read-lock is fine here. - */ - p2m_read_lock(p2m); - - start = gfn_max(start, p2m->lowest_mapped_gfn); - end = gfn_min(end, gfn_add(p2m->max_mapped_gfn, 1)); - - next_block_gfn = start; - - while ( gfn_x(start) < gfn_x(end) ) - { - /* - * Cleaning the cache for the P2M may take a long time. So we - * need to be able to preempt. We will arbitrarily preempt every - * time count reach 512 or above. - * - * The count will be incremented by: - * - 1 on region skipped - * - 10 for each page requiring a flush - */ - if ( count >= 512 ) - { - if ( softirq_pending(smp_processor_id()) ) - { - rc = -ERESTART; - break; - } - count = 0; - } - - /* - * We want to flush page by page as: - * - it may not be possible to map the full block (can be up to 1GB) - * in Xen memory - * - we may want to do fine grain preemption as flushing multiple - * page in one go may take a long time - * - * As p2m_get_entry is able to return the size of the mapping - * in the p2m, it is pointless to execute it for each page. - * - * We can optimize it by tracking the gfn of the next - * block. So we will only call p2m_get_entry for each block (can - * be up to 1GB). - */ - if ( gfn_eq(start, next_block_gfn) ) - { - bool valid; - - mfn = p2m_get_entry(p2m, start, &t, NULL, &order, &valid); - next_block_gfn = gfn_next_boundary(start, order); - - if ( mfn_eq(mfn, INVALID_MFN) || !p2m_is_any_ram(t) || !valid ) - { - count++; - start = next_block_gfn; - continue; - } - } - - count += 10; - - flush_page_to_ram(mfn_x(mfn), false); - - start = gfn_add(start, 1); - mfn = mfn_add(mfn, 1); - } - - if ( rc != -ERESTART ) - invalidate_icache(); - - p2m_read_unlock(p2m); - - *pstart = start; - - return rc; -} - -/* - * Clean & invalidate RAM associated to the guest vCPU. - * - * The function can only work with the current vCPU and should be called - * with IRQ enabled as the vCPU could get preempted. - */ -void p2m_flush_vm(struct vcpu *v) -{ - struct p2m_domain *p2m = p2m_get_hostp2m(v->domain); - int rc; - gfn_t start = _gfn(0); - - ASSERT(v == current); - ASSERT(local_irq_is_enabled()); - ASSERT(v->arch.need_flush_to_ram); - - do - { - rc = p2m_cache_flush_range(v->domain, &start, _gfn(ULONG_MAX)); - if ( rc == -ERESTART ) - do_softirq(); - } while ( rc == -ERESTART ); - - if ( rc != 0 ) - gprintk(XENLOG_WARNING, - "P2M has not been correctly cleaned (rc = %d)\n", - rc); - - /* - * Invalidate the p2m to track which page was modified by the guest - * between call of p2m_flush_vm(). - */ - p2m_invalidate_root(p2m); - - v->arch.need_flush_to_ram = false; -} - -/* - * See note at ARMv7 ARM B1.14.4 (DDI 0406C.c) (TL;DR: S/W ops are not - * easily virtualized). - * - * Main problems: - * - S/W ops are local to a CPU (not broadcast) - * - We have line migration behind our back (speculation) - * - System caches don't support S/W at all (damn!) - * - * In the face of the above, the best we can do is to try and convert - * S/W ops to VA ops. Because the guest is not allowed to infer the S/W - * to PA mapping, it can only use S/W to nuke the whole cache, which is - * rather a good thing for us. - * - * Also, it is only used when turning caches on/off ("The expected - * usage of the cache maintenance instructions that operate by set/way - * is associated with the powerdown and powerup of caches, if this is - * required by the implementation."). - * - * We use the following policy: - * - If we trap a S/W operation, we enabled VM trapping to detect - * caches being turned on/off, and do a full clean. - * - * - We flush the caches on both caches being turned on and off. - * - * - Once the caches are enabled, we stop trapping VM ops. - */ -void p2m_set_way_flush(struct vcpu *v, struct cpu_user_regs *regs, - const union hsr hsr) -{ - /* This function can only work with the current vCPU. */ - ASSERT(v == current); - - if ( iommu_use_hap_pt(current->domain) ) - { - gprintk(XENLOG_ERR, - "The cache should be flushed by VA rather than by set/way.\n"); - inject_undef_exception(regs, hsr); - return; - } - - if ( !(v->arch.hcr_el2 & HCR_TVM) ) - { - v->arch.need_flush_to_ram = true; - vcpu_hcr_set_flags(v, HCR_TVM); - } -} - -void p2m_toggle_cache(struct vcpu *v, bool was_enabled) -{ - bool now_enabled = vcpu_has_cache_enabled(v); - - /* This function can only work with the current vCPU. */ - ASSERT(v == current); - - /* - * If switching the MMU+caches on, need to invalidate the caches. - * If switching it off, need to clean the caches. - * Clean + invalidate does the trick always. - */ - if ( was_enabled != now_enabled ) - v->arch.need_flush_to_ram = true; - - /* Caches are now on, stop trapping VM ops (until a S/W op) */ - if ( now_enabled ) - vcpu_hcr_clear_flags(v, HCR_TVM); -} - -mfn_t gfn_to_mfn(struct domain *d, gfn_t gfn) -{ - return p2m_lookup(d, gfn, NULL); -} - -struct page_info *get_page_from_gva(struct vcpu *v, vaddr_t va, - unsigned long flags) -{ - struct domain *d = v->domain; - struct p2m_domain *p2m = p2m_get_hostp2m(d); - struct page_info *page = NULL; - paddr_t maddr = 0; - uint64_t par; - mfn_t mfn; - p2m_type_t t; - - /* - * XXX: To support a different vCPU, we would need to load the - * VTTBR_EL2, TTBR0_EL1, TTBR1_EL1 and SCTLR_EL1 - */ - if ( v != current ) - return NULL; - - /* - * The lock is here to protect us against the break-before-make - * sequence used when updating the entry. - */ - p2m_read_lock(p2m); - par = gvirt_to_maddr(va, &maddr, flags); - p2m_read_unlock(p2m); - - /* - * gvirt_to_maddr may fail if the entry does not have the valid bit - * set. Fallback to the second method: - * 1) Translate the VA to IPA using software lookup -> Stage-1 page-table - * may not be accessible because the stage-2 entries may have valid - * bit unset. - * 2) Software lookup of the MFN - * - * Note that when memaccess is enabled, we instead call directly - * p2m_mem_access_check_and_get_page(...). Because the function is a - * a variant of the methods described above, it will be able to - * handle entries with valid bit unset. - * - * TODO: Integrate more nicely memaccess with the rest of the - * function. - * TODO: Use the fault error in PAR_EL1 to avoid pointless - * translation. - */ - if ( par ) - { - paddr_t ipa; - unsigned int s1_perms; - - /* - * When memaccess is enabled, the translation GVA to MADDR may - * have failed because of a permission fault. - */ - if ( p2m->mem_access_enabled ) - return p2m_mem_access_check_and_get_page(va, flags, v); - - /* - * The software stage-1 table walk can still fail, e.g, if the - * GVA is not mapped. - */ - if ( !guest_walk_tables(v, va, &ipa, &s1_perms) ) - { - dprintk(XENLOG_G_DEBUG, - "%pv: Failed to walk page-table va %#"PRIvaddr"\n", v, va); - return NULL; - } - - mfn = p2m_lookup(d, gaddr_to_gfn(ipa), &t); - if ( mfn_eq(INVALID_MFN, mfn) || !p2m_is_ram(t) ) - return NULL; - - /* - * Check permission that are assumed by the caller. For instance - * in case of guestcopy, the caller assumes that the translated - * page can be accessed with the requested permissions. If this - * is not the case, we should fail. - * - * Please note that we do not check for the GV2M_EXEC - * permission. This is fine because the hardware-based translation - * instruction does not test for execute permissions. - */ - if ( (flags & GV2M_WRITE) && !(s1_perms & GV2M_WRITE) ) - return NULL; - - if ( (flags & GV2M_WRITE) && t != p2m_ram_rw ) - return NULL; - } - else - mfn = maddr_to_mfn(maddr); - - if ( !mfn_valid(mfn) ) - { - dprintk(XENLOG_G_DEBUG, "%pv: Invalid MFN %#"PRI_mfn"\n", - v, mfn_x(mfn)); - return NULL; - } - - page = mfn_to_page(mfn); - ASSERT(page); - - if ( unlikely(!get_page(page, d)) ) - { - dprintk(XENLOG_G_DEBUG, "%pv: Failing to acquire the MFN %#"PRI_mfn"\n", - v, mfn_x(maddr_to_mfn(maddr))); - return NULL; - } - - return page; -} - -void __init p2m_restrict_ipa_bits(unsigned int ipa_bits) -{ - /* - * Calculate the minimum of the maximum IPA bits that any external entity - * can support. - */ - if ( ipa_bits < p2m_ipa_bits ) - p2m_ipa_bits = ipa_bits; -} - -/* VTCR value to be configured by all CPUs. Set only once by the boot CPU */ -static register_t __read_mostly vtcr; - -static void setup_virt_paging_one(void *data) -{ - WRITE_SYSREG(vtcr, VTCR_EL2); - - /* - * ARM64_WORKAROUND_AT_SPECULATE: We want to keep the TLBs free from - * entries related to EL1/EL0 translation regime until a guest vCPU - * is running. For that, we need to set-up VTTBR to point to an empty - * page-table and turn on stage-2 translation. The TLB entries - * associated with EL1/EL0 translation regime will also be flushed in case - * an AT instruction was speculated before hand. - */ - if ( cpus_have_cap(ARM64_WORKAROUND_AT_SPECULATE) ) - { - WRITE_SYSREG64(generate_vttbr(INVALID_VMID, empty_root_mfn), VTTBR_EL2); - WRITE_SYSREG(READ_SYSREG(HCR_EL2) | HCR_VM, HCR_EL2); - isb(); - - flush_all_guests_tlb_local(); - } -} - -void __init setup_virt_paging(void) -{ - /* Setup Stage 2 address translation */ - register_t val = VTCR_RES1|VTCR_SH0_IS|VTCR_ORGN0_WBWA|VTCR_IRGN0_WBWA; - -#ifdef CONFIG_ARM_32 - if ( p2m_ipa_bits < 40 ) - panic("P2M: Not able to support %u-bit IPA at the moment\n", - p2m_ipa_bits); - - printk("P2M: 40-bit IPA\n"); - p2m_ipa_bits = 40; - val |= VTCR_T0SZ(0x18); /* 40 bit IPA */ - val |= VTCR_SL0(0x1); /* P2M starts at first level */ -#else /* CONFIG_ARM_64 */ - static const struct { - unsigned int pabits; /* Physical Address Size */ - unsigned int t0sz; /* Desired T0SZ, minimum in comment */ - unsigned int root_order; /* Page order of the root of the p2m */ - unsigned int sl0; /* Desired SL0, maximum in comment */ - } pa_range_info[] __initconst = { - /* T0SZ minimum and SL0 maximum from ARM DDI 0487H.a Table D5-6 */ - /* PA size, t0sz(min), root-order, sl0(max) */ - [0] = { 32, 32/*32*/, 0, 1 }, - [1] = { 36, 28/*28*/, 0, 1 }, - [2] = { 40, 24/*24*/, 1, 1 }, - [3] = { 42, 22/*22*/, 3, 1 }, - [4] = { 44, 20/*20*/, 0, 2 }, - [5] = { 48, 16/*16*/, 0, 2 }, - [6] = { 52, 12/*12*/, 4, 2 }, - [7] = { 0 } /* Invalid */ - }; - - unsigned int i; - unsigned int pa_range = 0x10; /* Larger than any possible value */ - - /* - * Restrict "p2m_ipa_bits" if needed. As P2M table is always configured - * with IPA bits == PA bits, compare against "pabits". - */ - if ( pa_range_info[system_cpuinfo.mm64.pa_range].pabits < p2m_ipa_bits ) - p2m_ipa_bits = pa_range_info[system_cpuinfo.mm64.pa_range].pabits; - - /* - * cpu info sanitization made sure we support 16bits VMID only if all - * cores are supporting it. - */ - if ( system_cpuinfo.mm64.vmid_bits == MM64_VMID_16_BITS_SUPPORT ) - max_vmid = MAX_VMID_16_BIT; - - /* Choose suitable "pa_range" according to the resulted "p2m_ipa_bits". */ - for ( i = 0; i < ARRAY_SIZE(pa_range_info); i++ ) - { - if ( p2m_ipa_bits == pa_range_info[i].pabits ) - { - pa_range = i; - break; - } - } - - /* pa_range is 4 bits but we don't support all modes */ - if ( pa_range >= ARRAY_SIZE(pa_range_info) || !pa_range_info[pa_range].pabits ) - panic("Unknown encoding of ID_AA64MMFR0_EL1.PARange %x\n", pa_range); - - val |= VTCR_PS(pa_range); - val |= VTCR_TG0_4K; - - /* Set the VS bit only if 16 bit VMID is supported. */ - if ( MAX_VMID == MAX_VMID_16_BIT ) - val |= VTCR_VS; - val |= VTCR_SL0(pa_range_info[pa_range].sl0); - val |= VTCR_T0SZ(pa_range_info[pa_range].t0sz); - - p2m_root_order = pa_range_info[pa_range].root_order; - p2m_root_level = 2 - pa_range_info[pa_range].sl0; - p2m_ipa_bits = 64 - pa_range_info[pa_range].t0sz; - - printk("P2M: %d-bit IPA with %d-bit PA and %d-bit VMID\n", - p2m_ipa_bits, - pa_range_info[pa_range].pabits, - ( MAX_VMID == MAX_VMID_16_BIT ) ? 16 : 8); -#endif - printk("P2M: %d levels with order-%d root, VTCR 0x%"PRIregister"\n", - 4 - P2M_ROOT_LEVEL, P2M_ROOT_ORDER, val); - - p2m_vmid_allocator_init(); - - /* It is not allowed to concatenate a level zero root */ - BUG_ON( P2M_ROOT_LEVEL == 0 && P2M_ROOT_ORDER > 0 ); - vtcr = val; - - /* - * ARM64_WORKAROUND_AT_SPECULATE requires to allocate root table - * with all entries zeroed. - */ - if ( cpus_have_cap(ARM64_WORKAROUND_AT_SPECULATE) ) - { - struct page_info *root; - - root = p2m_allocate_root(); - if ( !root ) - panic("Unable to allocate root table for ARM64_WORKAROUND_AT_SPECULATE\n"); - - empty_root_mfn = page_to_mfn(root); - } - - setup_virt_paging_one(NULL); - smp_call_function(setup_virt_paging_one, NULL, 1); -} - -static int cpu_virt_paging_callback(struct notifier_block *nfb, - unsigned long action, - void *hcpu) -{ - switch ( action ) - { - case CPU_STARTING: - ASSERT(system_state != SYS_STATE_boot); - setup_virt_paging_one(NULL); - break; - default: - break; - } - - return NOTIFY_DONE; -} - -static struct notifier_block cpu_virt_paging_nfb = { - .notifier_call = cpu_virt_paging_callback, -}; - -static int __init cpu_virt_paging_init(void) -{ - register_cpu_notifier(&cpu_virt_paging_nfb); - - return 0; -} -/* - * Initialization of the notifier has to be done at init rather than presmp_init - * phase because: the registered notifier is used to setup virtual paging for - * non-boot CPUs after the initial virtual paging for all CPUs is already setup, - * i.e. when a non-boot CPU is hotplugged after the system has booted. In other - * words, the notifier should be registered after the virtual paging is - * initially setup (setup_virt_paging() is called from start_xen()). This is - * required because vtcr config value has to be set before a notifier can fire. - */ -__initcall(cpu_virt_paging_init); - /* * Local variables: * mode: C diff --git a/xen/arch/arm/p2m_mmu.c b/xen/arch/arm/p2m_mmu.c new file mode 100644 index 0000000000..88a9d8f392 --- /dev/null +++ b/xen/arch/arm/p2m_mmu.c @@ -0,0 +1,2295 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#include +#include +#include +#include +#include +#include +#include + +#include +#include +#include +#include +#include +#include + +#define MAX_VMID_8_BIT (1UL << 8) +#define MAX_VMID_16_BIT (1UL << 16) + +#define INVALID_VMID 0 /* VMID 0 is reserved */ + +#ifdef CONFIG_ARM_64 +static unsigned int __read_mostly max_vmid = MAX_VMID_8_BIT; +/* VMID is by default 8 bit width on AArch64 */ +#define MAX_VMID max_vmid +#else +/* VMID is always 8 bit width on AArch32 */ +#define MAX_VMID MAX_VMID_8_BIT +#endif + +#ifdef CONFIG_ARM_64 +unsigned int __read_mostly p2m_root_order; +unsigned int __read_mostly p2m_root_level; +#endif + +#define P2M_ROOT_PAGES (1<arch.paging.lock); + /* + * For hardware domain, there should be no limit in the number of pages that + * can be allocated, so that the kernel may take advantage of the extended + * regions. Hence, allocate p2m pages for hardware domains from heap. + */ + if ( is_hardware_domain(d) ) + { + pg = alloc_domheap_page(NULL, 0); + if ( pg == NULL ) + { + printk(XENLOG_G_ERR "Failed to allocate P2M pages for hwdom.\n"); + spin_unlock(&d->arch.paging.lock); + return NULL; + } + } + else + { + pg = page_list_remove_head(&d->arch.paging.p2m_freelist); + if ( unlikely(!pg) ) + { + spin_unlock(&d->arch.paging.lock); + return NULL; + } + d->arch.paging.p2m_total_pages--; + } + spin_unlock(&d->arch.paging.lock); + + return pg; +} + +static void p2m_free_page(struct domain *d, struct page_info *pg) +{ + spin_lock(&d->arch.paging.lock); + if ( is_hardware_domain(d) ) + free_domheap_page(pg); + else + { + d->arch.paging.p2m_total_pages++; + page_list_add_tail(pg, &d->arch.paging.p2m_freelist); + } + spin_unlock(&d->arch.paging.lock); +} + +/* Unlock the flush and do a P2M TLB flush if necessary */ +void p2m_write_unlock(struct p2m_domain *p2m) +{ + /* + * The final flush is done with the P2M write lock taken to avoid + * someone else modifying the P2M wbefore the TLB invalidation has + * completed. + */ + p2m_tlb_flush_sync(p2m); + + write_unlock(&p2m->lock); +} + +void p2m_dump_info(struct domain *d) +{ + struct p2m_domain *p2m = p2m_get_hostp2m(d); + + p2m_read_lock(p2m); + printk("p2m mappings for domain %d (vmid %d):\n", + d->domain_id, p2m->vmid); + BUG_ON(p2m->stats.mappings[0] || p2m->stats.shattered[0]); + printk(" 1G mappings: %ld (shattered %ld)\n", + p2m->stats.mappings[1], p2m->stats.shattered[1]); + printk(" 2M mappings: %ld (shattered %ld)\n", + p2m->stats.mappings[2], p2m->stats.shattered[2]); + printk(" 4K mappings: %ld\n", p2m->stats.mappings[3]); + p2m_read_unlock(p2m); +} + +void dump_p2m_lookup(struct domain *d, paddr_t addr) +{ + struct p2m_domain *p2m = p2m_get_hostp2m(d); + + printk("dom%d IPA 0x%"PRIpaddr"\n", d->domain_id, addr); + + printk("P2M @ %p mfn:%#"PRI_mfn"\n", + p2m->root, mfn_x(page_to_mfn(p2m->root))); + + dump_pt_walk(page_to_maddr(p2m->root), addr, + P2M_ROOT_LEVEL, P2M_ROOT_PAGES); +} + +/* + * p2m_save_state and p2m_restore_state work in pair to workaround + * ARM64_WORKAROUND_AT_SPECULATE. p2m_save_state will set-up VTTBR to + * point to the empty page-tables to stop allocating TLB entries. + */ +void p2m_save_state(struct vcpu *p) +{ + p->arch.sctlr = READ_SYSREG(SCTLR_EL1); + + if ( cpus_have_const_cap(ARM64_WORKAROUND_AT_SPECULATE) ) + { + WRITE_SYSREG64(generate_vttbr(INVALID_VMID, empty_root_mfn), VTTBR_EL2); + /* + * Ensure VTTBR_EL2 is correctly synchronized so we can restore + * the next vCPU context without worrying about AT instruction + * speculation. + */ + isb(); + } +} + +void p2m_restore_state(struct vcpu *n) +{ + struct p2m_domain *p2m = p2m_get_hostp2m(n->domain); + uint8_t *last_vcpu_ran; + + if ( is_idle_vcpu(n) ) + return; + + WRITE_SYSREG(n->arch.sctlr, SCTLR_EL1); + WRITE_SYSREG(n->arch.hcr_el2, HCR_EL2); + + /* + * ARM64_WORKAROUND_AT_SPECULATE: VTTBR_EL2 should be restored after all + * registers associated to EL1/EL0 translations regime have been + * synchronized. + */ + asm volatile(ALTERNATIVE("nop", "isb", ARM64_WORKAROUND_AT_SPECULATE)); + WRITE_SYSREG64(p2m->vttbr, VTTBR_EL2); + + last_vcpu_ran = &p2m->last_vcpu_ran[smp_processor_id()]; + + /* + * While we are restoring an out-of-context translation regime + * we still need to ensure: + * - VTTBR_EL2 is synchronized before flushing the TLBs + * - All registers for EL1 are synchronized before executing an AT + * instructions targeting S1/S2. + */ + isb(); + + /* + * Flush local TLB for the domain to prevent wrong TLB translation + * when running multiple vCPU of the same domain on a single pCPU. + */ + if ( *last_vcpu_ran != INVALID_VCPU_ID && *last_vcpu_ran != n->vcpu_id ) + flush_guest_tlb_local(); + + *last_vcpu_ran = n->vcpu_id; +} + +/* + * Force a synchronous P2M TLB flush. + * + * Must be called with the p2m lock held. + */ +static void p2m_force_tlb_flush_sync(struct p2m_domain *p2m) +{ + unsigned long flags = 0; + uint64_t ovttbr; + + ASSERT(p2m_is_write_locked(p2m)); + + /* + * ARM only provides an instruction to flush TLBs for the current + * VMID. So switch to the VTTBR of a given P2M if different. + */ + ovttbr = READ_SYSREG64(VTTBR_EL2); + if ( ovttbr != p2m->vttbr ) + { + uint64_t vttbr; + + local_irq_save(flags); + + /* + * ARM64_WORKAROUND_AT_SPECULATE: We need to stop AT to allocate + * TLBs entries because the context is partially modified. We + * only need the VMID for flushing the TLBs, so we can generate + * a new VTTBR with the VMID to flush and the empty root table. + */ + if ( !cpus_have_const_cap(ARM64_WORKAROUND_AT_SPECULATE) ) + vttbr = p2m->vttbr; + else + vttbr = generate_vttbr(p2m->vmid, empty_root_mfn); + + WRITE_SYSREG64(vttbr, VTTBR_EL2); + + /* Ensure VTTBR_EL2 is synchronized before flushing the TLBs */ + isb(); + } + + flush_guest_tlb(); + + if ( ovttbr != READ_SYSREG64(VTTBR_EL2) ) + { + WRITE_SYSREG64(ovttbr, VTTBR_EL2); + /* Ensure VTTBR_EL2 is back in place before continuing. */ + isb(); + local_irq_restore(flags); + } + + p2m->need_flush = false; +} + +void p2m_tlb_flush_sync(struct p2m_domain *p2m) +{ + if ( p2m->need_flush ) + p2m_force_tlb_flush_sync(p2m); +} + +/* + * Find and map the root page table. The caller is responsible for + * unmapping the table. + * + * The function will return NULL if the offset of the root table is + * invalid. + */ +static lpae_t *p2m_get_root_pointer(struct p2m_domain *p2m, + gfn_t gfn) +{ + unsigned long root_table; + + /* + * While the root table index is the offset from the previous level, + * we can't use (P2M_ROOT_LEVEL - 1) because the root level might be + * 0. Yet we still want to check if all the unused bits are zeroed. + */ + root_table = gfn_x(gfn) >> (XEN_PT_LEVEL_ORDER(P2M_ROOT_LEVEL) + + XEN_PT_LPAE_SHIFT); + if ( root_table >= P2M_ROOT_PAGES ) + return NULL; + + return __map_domain_page(p2m->root + root_table); +} + +/* + * Lookup the MFN corresponding to a domain's GFN. + * Lookup mem access in the ratrix tree. + * The entries associated to the GFN is considered valid. + */ +static p2m_access_t p2m_mem_access_radix_get(struct p2m_domain *p2m, gfn_t gfn) +{ + void *ptr; + + if ( !p2m->mem_access_enabled ) + return p2m->default_access; + + ptr = radix_tree_lookup(&p2m->mem_access_settings, gfn_x(gfn)); + if ( !ptr ) + return p2m_access_rwx; + else + return radix_tree_ptr_to_int(ptr); +} + +/* + * In the case of the P2M, the valid bit is used for other purpose. Use + * the type to check whether an entry is valid. + */ +static inline bool p2m_is_valid(lpae_t pte) +{ + return pte.p2m.type != p2m_invalid; +} + +/* + * lpae_is_* helpers don't check whether the valid bit is set in the + * PTE. Provide our own overlay to check the valid bit. + */ +static inline bool p2m_is_mapping(lpae_t pte, unsigned int level) +{ + return p2m_is_valid(pte) && lpae_is_mapping(pte, level); +} + +static inline bool p2m_is_superpage(lpae_t pte, unsigned int level) +{ + return p2m_is_valid(pte) && lpae_is_superpage(pte, level); +} + +#define GUEST_TABLE_MAP_FAILED 0 +#define GUEST_TABLE_SUPER_PAGE 1 +#define GUEST_TABLE_NORMAL_PAGE 2 + +static int p2m_create_table(struct p2m_domain *p2m, lpae_t *entry); + +/* + * Take the currently mapped table, find the corresponding GFN entry, + * and map the next table, if available. The previous table will be + * unmapped if the next level was mapped (e.g GUEST_TABLE_NORMAL_PAGE + * returned). + * + * The read_only parameters indicates whether intermediate tables should + * be allocated when not present. + * + * Return values: + * GUEST_TABLE_MAP_FAILED: Either read_only was set and the entry + * was empty, or allocating a new page failed. + * GUEST_TABLE_NORMAL_PAGE: next level mapped normally + * GUEST_TABLE_SUPER_PAGE: The next entry points to a superpage. + */ +static int p2m_next_level(struct p2m_domain *p2m, bool read_only, + unsigned int level, lpae_t **table, + unsigned int offset) +{ + lpae_t *entry; + int ret; + mfn_t mfn; + + entry = *table + offset; + + if ( !p2m_is_valid(*entry) ) + { + if ( read_only ) + return GUEST_TABLE_MAP_FAILED; + + ret = p2m_create_table(p2m, entry); + if ( ret ) + return GUEST_TABLE_MAP_FAILED; + } + + /* The function p2m_next_level is never called at the 3rd level */ + ASSERT(level < 3); + if ( p2m_is_mapping(*entry, level) ) + return GUEST_TABLE_SUPER_PAGE; + + mfn = lpae_get_mfn(*entry); + + unmap_domain_page(*table); + *table = map_domain_page(mfn); + + return GUEST_TABLE_NORMAL_PAGE; +} + +/* + * Get the details of a given gfn. + * + * If the entry is present, the associated MFN will be returned and the + * access and type filled up. The page_order will correspond to the + * order of the mapping in the page table (i.e it could be a superpage). + * + * If the entry is not present, INVALID_MFN will be returned and the + * page_order will be set according to the order of the invalid range. + * + * valid will contain the value of bit[0] (e.g valid bit) of the + * entry. + */ +mfn_t p2m_get_entry(struct p2m_domain *p2m, gfn_t gfn, + p2m_type_t *t, p2m_access_t *a, + unsigned int *page_order, + bool *valid) +{ + paddr_t addr = gfn_to_gaddr(gfn); + unsigned int level = 0; + lpae_t entry, *table; + int rc; + mfn_t mfn = INVALID_MFN; + p2m_type_t _t; + DECLARE_OFFSETS(offsets, addr); + + ASSERT(p2m_is_locked(p2m)); + BUILD_BUG_ON(THIRD_MASK != PAGE_MASK); + + /* Allow t to be NULL */ + t = t ?: &_t; + + *t = p2m_invalid; + + if ( valid ) + *valid = false; + + /* XXX: Check if the mapping is lower than the mapped gfn */ + + /* This gfn is higher than the highest the p2m map currently holds */ + if ( gfn_x(gfn) > gfn_x(p2m->max_mapped_gfn) ) + { + for ( level = P2M_ROOT_LEVEL; level < 3; level++ ) + if ( (gfn_x(gfn) & (XEN_PT_LEVEL_MASK(level) >> PAGE_SHIFT)) > + gfn_x(p2m->max_mapped_gfn) ) + break; + + goto out; + } + + table = p2m_get_root_pointer(p2m, gfn); + + /* + * the table should always be non-NULL because the gfn is below + * p2m->max_mapped_gfn and the root table pages are always present. + */ + if ( !table ) + { + ASSERT_UNREACHABLE(); + level = P2M_ROOT_LEVEL; + goto out; + } + + for ( level = P2M_ROOT_LEVEL; level < 3; level++ ) + { + rc = p2m_next_level(p2m, true, level, &table, offsets[level]); + if ( rc == GUEST_TABLE_MAP_FAILED ) + goto out_unmap; + else if ( rc != GUEST_TABLE_NORMAL_PAGE ) + break; + } + + entry = table[offsets[level]]; + + if ( p2m_is_valid(entry) ) + { + *t = entry.p2m.type; + + if ( a ) + *a = p2m_mem_access_radix_get(p2m, gfn); + + mfn = lpae_get_mfn(entry); + /* + * The entry may point to a superpage. Find the MFN associated + * to the GFN. + */ + mfn = mfn_add(mfn, + gfn_x(gfn) & ((1UL << XEN_PT_LEVEL_ORDER(level)) - 1)); + + if ( valid ) + *valid = lpae_is_valid(entry); + } + +out_unmap: + unmap_domain_page(table); + +out: + if ( page_order ) + *page_order = XEN_PT_LEVEL_ORDER(level); + + return mfn; +} + +mfn_t p2m_lookup(struct domain *d, gfn_t gfn, p2m_type_t *t) +{ + mfn_t mfn; + struct p2m_domain *p2m = p2m_get_hostp2m(d); + + p2m_read_lock(p2m); + mfn = p2m_get_entry(p2m, gfn, t, NULL, NULL, NULL); + p2m_read_unlock(p2m); + + return mfn; +} + +struct page_info *p2m_get_page_from_gfn(struct domain *d, gfn_t gfn, + p2m_type_t *t) +{ + struct page_info *page; + p2m_type_t p2mt; + mfn_t mfn = p2m_lookup(d, gfn, &p2mt); + + if ( t ) + *t = p2mt; + + if ( !p2m_is_any_ram(p2mt) ) + return NULL; + + if ( !mfn_valid(mfn) ) + return NULL; + + page = mfn_to_page(mfn); + + /* + * get_page won't work on foreign mapping because the page doesn't + * belong to the current domain. + */ + if ( p2m_is_foreign(p2mt) ) + { + struct domain *fdom = page_get_owner_and_reference(page); + ASSERT(fdom != NULL); + ASSERT(fdom != d); + return page; + } + + return get_page(page, d) ? page : NULL; +} + +static void p2m_set_permission(lpae_t *e, p2m_type_t t, p2m_access_t a) +{ + /* First apply type permissions */ + switch ( t ) + { + case p2m_ram_rw: + e->p2m.xn = 0; + e->p2m.write = 1; + break; + + case p2m_ram_ro: + e->p2m.xn = 0; + e->p2m.write = 0; + break; + + case p2m_iommu_map_rw: + case p2m_map_foreign_rw: + case p2m_grant_map_rw: + case p2m_mmio_direct_dev: + case p2m_mmio_direct_nc: + case p2m_mmio_direct_c: + e->p2m.xn = 1; + e->p2m.write = 1; + break; + + case p2m_iommu_map_ro: + case p2m_map_foreign_ro: + case p2m_grant_map_ro: + case p2m_invalid: + e->p2m.xn = 1; + e->p2m.write = 0; + break; + + case p2m_max_real_type: + BUG(); + break; + } + + /* Then restrict with access permissions */ + switch ( a ) + { + case p2m_access_rwx: + break; + case p2m_access_wx: + e->p2m.read = 0; + break; + case p2m_access_rw: + e->p2m.xn = 1; + break; + case p2m_access_w: + e->p2m.read = 0; + e->p2m.xn = 1; + break; + case p2m_access_rx: + case p2m_access_rx2rw: + e->p2m.write = 0; + break; + case p2m_access_x: + e->p2m.write = 0; + e->p2m.read = 0; + break; + case p2m_access_r: + e->p2m.write = 0; + e->p2m.xn = 1; + break; + case p2m_access_n: + case p2m_access_n2rwx: + e->p2m.read = e->p2m.write = 0; + e->p2m.xn = 1; + break; + } +} + +static lpae_t mfn_to_p2m_entry(mfn_t mfn, p2m_type_t t, p2m_access_t a) +{ + /* + * sh, xn and write bit will be defined in the following switches + * based on mattr and t. + */ + lpae_t e = (lpae_t) { + .p2m.af = 1, + .p2m.read = 1, + .p2m.table = 1, + .p2m.valid = 1, + .p2m.type = t, + }; + + BUILD_BUG_ON(p2m_max_real_type > (1 << 4)); + + switch ( t ) + { + case p2m_mmio_direct_dev: + e.p2m.mattr = MATTR_DEV; + e.p2m.sh = LPAE_SH_OUTER; + break; + + case p2m_mmio_direct_c: + e.p2m.mattr = MATTR_MEM; + e.p2m.sh = LPAE_SH_OUTER; + break; + + /* + * ARM ARM: Overlaying the shareability attribute (DDI + * 0406C.b B3-1376 to 1377) + * + * A memory region with a resultant memory type attribute of Normal, + * and a resultant cacheability attribute of Inner Non-cacheable, + * Outer Non-cacheable, must have a resultant shareability attribute + * of Outer Shareable, otherwise shareability is UNPREDICTABLE. + * + * On ARMv8 shareability is ignored and explicitly treated as Outer + * Shareable for Normal Inner Non_cacheable, Outer Non-cacheable. + * See the note for table D4-40, in page 1788 of the ARM DDI 0487A.j. + */ + case p2m_mmio_direct_nc: + e.p2m.mattr = MATTR_MEM_NC; + e.p2m.sh = LPAE_SH_OUTER; + break; + + default: + e.p2m.mattr = MATTR_MEM; + e.p2m.sh = LPAE_SH_INNER; + } + + p2m_set_permission(&e, t, a); + + ASSERT(!(mfn_to_maddr(mfn) & ~PADDR_MASK)); + + lpae_set_mfn(e, mfn); + + return e; +} + +/* Generate table entry with correct attributes. */ +static lpae_t page_to_p2m_table(struct page_info *page) +{ + /* + * The access value does not matter because the hardware will ignore + * the permission fields for table entry. + * + * We use p2m_ram_rw so the entry has a valid type. This is important + * for p2m_is_valid() to return valid on table entries. + */ + return mfn_to_p2m_entry(page_to_mfn(page), p2m_ram_rw, p2m_access_rwx); +} + +static inline void p2m_write_pte(lpae_t *p, lpae_t pte, bool clean_pte) +{ + write_pte(p, pte); + if ( clean_pte ) + clean_dcache(*p); +} + +static inline void p2m_remove_pte(lpae_t *p, bool clean_pte) +{ + lpae_t pte; + + memset(&pte, 0x00, sizeof(pte)); + p2m_write_pte(p, pte, clean_pte); +} + +/* Allocate a new page table page and hook it in via the given entry. */ +static int p2m_create_table(struct p2m_domain *p2m, lpae_t *entry) +{ + struct page_info *page; + lpae_t *p; + + ASSERT(!p2m_is_valid(*entry)); + + page = p2m_alloc_page(p2m->domain); + if ( page == NULL ) + return -ENOMEM; + + page_list_add(page, &p2m->pages); + + p = __map_domain_page(page); + clear_page(p); + + if ( p2m->clean_pte ) + clean_dcache_va_range(p, PAGE_SIZE); + + unmap_domain_page(p); + + p2m_write_pte(entry, page_to_p2m_table(page), p2m->clean_pte); + + return 0; +} + +static int p2m_mem_access_radix_set(struct p2m_domain *p2m, gfn_t gfn, + p2m_access_t a) +{ + int rc; + + if ( !p2m->mem_access_enabled ) + return 0; + + if ( p2m_access_rwx == a ) + { + radix_tree_delete(&p2m->mem_access_settings, gfn_x(gfn)); + return 0; + } + + rc = radix_tree_insert(&p2m->mem_access_settings, gfn_x(gfn), + radix_tree_int_to_ptr(a)); + if ( rc == -EEXIST ) + { + /* If a setting already exists, change it to the new one */ + radix_tree_replace_slot( + radix_tree_lookup_slot( + &p2m->mem_access_settings, gfn_x(gfn)), + radix_tree_int_to_ptr(a)); + rc = 0; + } + + return rc; +} + +/* + * Put any references on the single 4K page referenced by pte. + * TODO: Handle superpages, for now we only take special references for leaf + * pages (specifically foreign ones, which can't be super mapped today). + */ +static void p2m_put_l3_page(const lpae_t pte) +{ + mfn_t mfn = lpae_get_mfn(pte); + + ASSERT(p2m_is_valid(pte)); + + /* + * TODO: Handle other p2m types + * + * It's safe to do the put_page here because page_alloc will + * flush the TLBs if the page is reallocated before the end of + * this loop. + */ + if ( p2m_is_foreign(pte.p2m.type) ) + { + ASSERT(mfn_valid(mfn)); + put_page(mfn_to_page(mfn)); + } + /* Detect the xenheap page and mark the stored GFN as invalid. */ + else if ( p2m_is_ram(pte.p2m.type) && is_xen_heap_mfn(mfn) ) + page_set_xenheap_gfn(mfn_to_page(mfn), INVALID_GFN); +} + +/* Free lpae sub-tree behind an entry */ +static void p2m_free_entry(struct p2m_domain *p2m, + lpae_t entry, unsigned int level) +{ + unsigned int i; + lpae_t *table; + mfn_t mfn; + struct page_info *pg; + + /* Nothing to do if the entry is invalid. */ + if ( !p2m_is_valid(entry) ) + return; + + if ( p2m_is_superpage(entry, level) || (level == 3) ) + { +#ifdef CONFIG_IOREQ_SERVER + /* + * If this gets called then either the entry was replaced by an entry + * with a different base (valid case) or the shattering of a superpage + * has failed (error case). + * So, at worst, the spurious mapcache invalidation might be sent. + */ + if ( p2m_is_ram(entry.p2m.type) && + domain_has_ioreq_server(p2m->domain) ) + ioreq_request_mapcache_invalidate(p2m->domain); +#endif + + p2m->stats.mappings[level]--; + /* Nothing to do if the entry is a super-page. */ + if ( level == 3 ) + p2m_put_l3_page(entry); + return; + } + + table = map_domain_page(lpae_get_mfn(entry)); + for ( i = 0; i < XEN_PT_LPAE_ENTRIES; i++ ) + p2m_free_entry(p2m, *(table + i), level + 1); + + unmap_domain_page(table); + + /* + * Make sure all the references in the TLB have been removed before + * freing the intermediate page table. + * XXX: Should we defer the free of the page table to avoid the + * flush? + */ + p2m_tlb_flush_sync(p2m); + + mfn = lpae_get_mfn(entry); + ASSERT(mfn_valid(mfn)); + + pg = mfn_to_page(mfn); + + page_list_del(pg, &p2m->pages); + p2m_free_page(p2m->domain, pg); +} + +static bool p2m_split_superpage(struct p2m_domain *p2m, lpae_t *entry, + unsigned int level, unsigned int target, + const unsigned int *offsets) +{ + struct page_info *page; + unsigned int i; + lpae_t pte, *table; + bool rv = true; + + /* Convenience aliases */ + mfn_t mfn = lpae_get_mfn(*entry); + unsigned int next_level = level + 1; + unsigned int level_order = XEN_PT_LEVEL_ORDER(next_level); + + /* + * This should only be called with target != level and the entry is + * a superpage. + */ + ASSERT(level < target); + ASSERT(p2m_is_superpage(*entry, level)); + + page = p2m_alloc_page(p2m->domain); + if ( !page ) + return false; + + page_list_add(page, &p2m->pages); + table = __map_domain_page(page); + + /* + * We are either splitting a first level 1G page into 512 second level + * 2M pages, or a second level 2M page into 512 third level 4K pages. + */ + for ( i = 0; i < XEN_PT_LPAE_ENTRIES; i++ ) + { + lpae_t *new_entry = table + i; + + /* + * Use the content of the superpage entry and override + * the necessary fields. So the correct permission are kept. + */ + pte = *entry; + lpae_set_mfn(pte, mfn_add(mfn, i << level_order)); + + /* + * First and second level pages set p2m.table = 0, but third + * level entries set p2m.table = 1. + */ + pte.p2m.table = (next_level == 3); + + write_pte(new_entry, pte); + } + + /* Update stats */ + p2m->stats.shattered[level]++; + p2m->stats.mappings[level]--; + p2m->stats.mappings[next_level] += XEN_PT_LPAE_ENTRIES; + + /* + * Shatter superpage in the page to the level we want to make the + * changes. + * This is done outside the loop to avoid checking the offset to + * know whether the entry should be shattered for every entry. + */ + if ( next_level != target ) + rv = p2m_split_superpage(p2m, table + offsets[next_level], + level + 1, target, offsets); + + if ( p2m->clean_pte ) + clean_dcache_va_range(table, PAGE_SIZE); + + unmap_domain_page(table); + + /* + * Even if we failed, we should install the newly allocated LPAE + * entry. The caller will be in charge to free the sub-tree. + */ + p2m_write_pte(entry, page_to_p2m_table(page), p2m->clean_pte); + + return rv; +} + +/* + * Insert an entry in the p2m. This should be called with a mapping + * equal to a page/superpage (4K, 2M, 1G). + */ +static int __p2m_set_entry(struct p2m_domain *p2m, + gfn_t sgfn, + unsigned int page_order, + mfn_t smfn, + p2m_type_t t, + p2m_access_t a) +{ + unsigned int level = 0; + unsigned int target = 3 - (page_order / XEN_PT_LPAE_SHIFT); + lpae_t *entry, *table, orig_pte; + int rc; + /* A mapping is removed if the MFN is invalid. */ + bool removing_mapping = mfn_eq(smfn, INVALID_MFN); + DECLARE_OFFSETS(offsets, gfn_to_gaddr(sgfn)); + + ASSERT(p2m_is_write_locked(p2m)); + + /* + * Check if the level target is valid: we only support + * 4K - 2M - 1G mapping. + */ + ASSERT(target > 0 && target <= 3); + + table = p2m_get_root_pointer(p2m, sgfn); + if ( !table ) + return -EINVAL; + + for ( level = P2M_ROOT_LEVEL; level < target; level++ ) + { + /* + * Don't try to allocate intermediate page table if the mapping + * is about to be removed. + */ + rc = p2m_next_level(p2m, removing_mapping, + level, &table, offsets[level]); + if ( rc == GUEST_TABLE_MAP_FAILED ) + { + /* + * We are here because p2m_next_level has failed to map + * the intermediate page table (e.g the table does not exist + * and they p2m tree is read-only). It is a valid case + * when removing a mapping as it may not exist in the + * page table. In this case, just ignore it. + */ + rc = removing_mapping ? 0 : -ENOENT; + goto out; + } + else if ( rc != GUEST_TABLE_NORMAL_PAGE ) + break; + } + + entry = table + offsets[level]; + + /* + * If we are here with level < target, we must be at a leaf node, + * and we need to break up the superpage. + */ + if ( level < target ) + { + /* We need to split the original page. */ + lpae_t split_pte = *entry; + + ASSERT(p2m_is_superpage(*entry, level)); + + if ( !p2m_split_superpage(p2m, &split_pte, level, target, offsets) ) + { + /* + * The current super-page is still in-place, so re-increment + * the stats. + */ + p2m->stats.mappings[level]++; + + /* Free the allocated sub-tree */ + p2m_free_entry(p2m, split_pte, level); + + rc = -ENOMEM; + goto out; + } + + /* + * Follow the break-before-sequence to update the entry. + * For more details see (D4.7.1 in ARM DDI 0487A.j). + */ + p2m_remove_pte(entry, p2m->clean_pte); + p2m_force_tlb_flush_sync(p2m); + + p2m_write_pte(entry, split_pte, p2m->clean_pte); + + /* then move to the level we want to make real changes */ + for ( ; level < target; level++ ) + { + rc = p2m_next_level(p2m, true, level, &table, offsets[level]); + + /* + * The entry should be found and either be a table + * or a superpage if level 3 is not targeted + */ + ASSERT(rc == GUEST_TABLE_NORMAL_PAGE || + (rc == GUEST_TABLE_SUPER_PAGE && target < 3)); + } + + entry = table + offsets[level]; + } + + /* + * We should always be there with the correct level because + * all the intermediate tables have been installed if necessary. + */ + ASSERT(level == target); + + orig_pte = *entry; + + /* + * The radix-tree can only work on 4KB. This is only used when + * memaccess is enabled and during shutdown. + */ + ASSERT(!p2m->mem_access_enabled || page_order == 0 || + p2m->domain->is_dying); + /* + * The access type should always be p2m_access_rwx when the mapping + * is removed. + */ + ASSERT(!mfn_eq(INVALID_MFN, smfn) || (a == p2m_access_rwx)); + /* + * Update the mem access permission before update the P2M. So we + * don't have to revert the mapping if it has failed. + */ + rc = p2m_mem_access_radix_set(p2m, sgfn, a); + if ( rc ) + goto out; + + /* + * Always remove the entry in order to follow the break-before-make + * sequence when updating the translation table (D4.7.1 in ARM DDI + * 0487A.j). + */ + if ( lpae_is_valid(orig_pte) || removing_mapping ) + p2m_remove_pte(entry, p2m->clean_pte); + + if ( removing_mapping ) + /* Flush can be deferred if the entry is removed */ + p2m->need_flush |= !!lpae_is_valid(orig_pte); + else + { + lpae_t pte = mfn_to_p2m_entry(smfn, t, a); + + if ( level < 3 ) + pte.p2m.table = 0; /* Superpage entry */ + + /* + * It is necessary to flush the TLB before writing the new entry + * to keep coherency when the previous entry was valid. + * + * Although, it could be defered when only the permissions are + * changed (e.g in case of memaccess). + */ + if ( lpae_is_valid(orig_pte) ) + { + if ( likely(!p2m->mem_access_enabled) || + P2M_CLEAR_PERM(pte) != P2M_CLEAR_PERM(orig_pte) ) + p2m_force_tlb_flush_sync(p2m); + else + p2m->need_flush = true; + } + else if ( !p2m_is_valid(orig_pte) ) /* new mapping */ + p2m->stats.mappings[level]++; + + p2m_write_pte(entry, pte, p2m->clean_pte); + + p2m->max_mapped_gfn = gfn_max(p2m->max_mapped_gfn, + gfn_add(sgfn, (1UL << page_order) - 1)); + p2m->lowest_mapped_gfn = gfn_min(p2m->lowest_mapped_gfn, sgfn); + } + + if ( is_iommu_enabled(p2m->domain) && + (lpae_is_valid(orig_pte) || lpae_is_valid(*entry)) ) + { + unsigned int flush_flags = 0; + + if ( lpae_is_valid(orig_pte) ) + flush_flags |= IOMMU_FLUSHF_modified; + if ( lpae_is_valid(*entry) ) + flush_flags |= IOMMU_FLUSHF_added; + + rc = iommu_iotlb_flush(p2m->domain, _dfn(gfn_x(sgfn)), + 1UL << page_order, flush_flags); + } + else + rc = 0; + + /* + * Free the entry only if the original pte was valid and the base + * is different (to avoid freeing when permission is changed). + */ + if ( p2m_is_valid(orig_pte) && + !mfn_eq(lpae_get_mfn(*entry), lpae_get_mfn(orig_pte)) ) + p2m_free_entry(p2m, orig_pte, level); + +out: + unmap_domain_page(table); + + return rc; +} + +int p2m_set_entry(struct p2m_domain *p2m, + gfn_t sgfn, + unsigned long nr, + mfn_t smfn, + p2m_type_t t, + p2m_access_t a) +{ + int rc = 0; + + /* + * Any reference taken by the P2M mappings (e.g. foreign mapping) will + * be dropped in relinquish_p2m_mapping(). As the P2M will still + * be accessible after, we need to prevent mapping to be added when the + * domain is dying. + */ + if ( unlikely(p2m->domain->is_dying) ) + return -ENOMEM; + + while ( nr ) + { + unsigned long mask; + unsigned long order; + + /* + * Don't take into account the MFN when removing mapping (i.e + * MFN_INVALID) to calculate the correct target order. + * + * XXX: Support superpage mappings if nr is not aligned to a + * superpage size. + */ + mask = !mfn_eq(smfn, INVALID_MFN) ? mfn_x(smfn) : 0; + mask |= gfn_x(sgfn) | nr; + + /* Always map 4k by 4k when memaccess is enabled */ + if ( unlikely(p2m->mem_access_enabled) ) + order = THIRD_ORDER; + else if ( !(mask & ((1UL << FIRST_ORDER) - 1)) ) + order = FIRST_ORDER; + else if ( !(mask & ((1UL << SECOND_ORDER) - 1)) ) + order = SECOND_ORDER; + else + order = THIRD_ORDER; + + rc = __p2m_set_entry(p2m, sgfn, order, smfn, t, a); + if ( rc ) + break; + + sgfn = gfn_add(sgfn, (1 << order)); + if ( !mfn_eq(smfn, INVALID_MFN) ) + smfn = mfn_add(smfn, (1 << order)); + + nr -= (1 << order); + } + + return rc; +} + +/* Invalidate all entries in the table. The p2m should be write locked. */ +static void p2m_invalidate_table(struct p2m_domain *p2m, mfn_t mfn) +{ + lpae_t *table; + unsigned int i; + + ASSERT(p2m_is_write_locked(p2m)); + + table = map_domain_page(mfn); + + for ( i = 0; i < XEN_PT_LPAE_ENTRIES; i++ ) + { + lpae_t pte = table[i]; + + /* + * Writing an entry can be expensive because it may involve + * cleaning the cache. So avoid updating the entry if the valid + * bit is already cleared. + */ + if ( !pte.p2m.valid ) + continue; + + pte.p2m.valid = 0; + + p2m_write_pte(&table[i], pte, p2m->clean_pte); + } + + unmap_domain_page(table); + + p2m->need_flush = true; +} + +/* + * Invalidate all entries in the root page-tables. This is + * useful to get fault on entry and do an action. + * + * p2m_invalid_root() should not be called when the P2M is shared with + * the IOMMU because it will cause IOMMU fault. + */ +void p2m_invalidate_root(struct p2m_domain *p2m) +{ + unsigned int i; + + ASSERT(!iommu_use_hap_pt(p2m->domain)); + + p2m_write_lock(p2m); + + for ( i = 0; i < P2M_ROOT_LEVEL; i++ ) + p2m_invalidate_table(p2m, page_to_mfn(p2m->root + i)); + + p2m_write_unlock(p2m); +} + +/* + * Resolve any translation fault due to change in the p2m. This + * includes break-before-make and valid bit cleared. + */ +bool p2m_resolve_translation_fault(struct domain *d, gfn_t gfn) +{ + struct p2m_domain *p2m = p2m_get_hostp2m(d); + unsigned int level = 0; + bool resolved = false; + lpae_t entry, *table; + + /* Convenience aliases */ + DECLARE_OFFSETS(offsets, gfn_to_gaddr(gfn)); + + p2m_write_lock(p2m); + + /* This gfn is higher than the highest the p2m map currently holds */ + if ( gfn_x(gfn) > gfn_x(p2m->max_mapped_gfn) ) + goto out; + + table = p2m_get_root_pointer(p2m, gfn); + /* + * The table should always be non-NULL because the gfn is below + * p2m->max_mapped_gfn and the root table pages are always present. + */ + if ( !table ) + { + ASSERT_UNREACHABLE(); + goto out; + } + + /* + * Go down the page-tables until an entry has the valid bit unset or + * a block/page entry has been hit. + */ + for ( level = P2M_ROOT_LEVEL; level <= 3; level++ ) + { + int rc; + + entry = table[offsets[level]]; + + if ( level == 3 ) + break; + + /* Stop as soon as we hit an entry with the valid bit unset. */ + if ( !lpae_is_valid(entry) ) + break; + + rc = p2m_next_level(p2m, true, level, &table, offsets[level]); + if ( rc == GUEST_TABLE_MAP_FAILED ) + goto out_unmap; + else if ( rc != GUEST_TABLE_NORMAL_PAGE ) + break; + } + + /* + * If the valid bit of the entry is set, it means someone was playing with + * the Stage-2 page table. Nothing to do and mark the fault as resolved. + */ + if ( lpae_is_valid(entry) ) + { + resolved = true; + goto out_unmap; + } + + /* + * The valid bit is unset. If the entry is still not valid then the fault + * cannot be resolved, exit and report it. + */ + if ( !p2m_is_valid(entry) ) + goto out_unmap; + + /* + * Now we have an entry with valid bit unset, but still valid from + * the P2M point of view. + * + * If an entry is pointing to a table, each entry of the table will + * have there valid bit cleared. This allows a function to clear the + * full p2m with just a couple of write. The valid bit will then be + * propagated on the fault. + * If an entry is pointing to a block/page, no work to do for now. + */ + if ( lpae_is_table(entry, level) ) + p2m_invalidate_table(p2m, lpae_get_mfn(entry)); + + /* + * Now that the work on the entry is done, set the valid bit to prevent + * another fault on that entry. + */ + resolved = true; + entry.p2m.valid = 1; + + p2m_write_pte(table + offsets[level], entry, p2m->clean_pte); + + /* + * No need to flush the TLBs as the modified entry had the valid bit + * unset. + */ + +out_unmap: + unmap_domain_page(table); + +out: + p2m_write_unlock(p2m); + + return resolved; +} + +int p2m_insert_mapping(struct domain *d, gfn_t start_gfn, unsigned long nr, + mfn_t mfn, p2m_type_t t) +{ + struct p2m_domain *p2m = p2m_get_hostp2m(d); + int rc; + + p2m_write_lock(p2m); + rc = p2m_set_entry(p2m, start_gfn, nr, mfn, t, p2m->default_access); + p2m_write_unlock(p2m); + + return rc; +} + +static inline int p2m_remove_mapping(struct domain *d, + gfn_t start_gfn, + unsigned long nr, + mfn_t mfn) +{ + struct p2m_domain *p2m = p2m_get_hostp2m(d); + unsigned long i; + int rc; + + p2m_write_lock(p2m); + /* + * Before removing the GFN - MFN mapping for any RAM pages make sure + * that there is no difference between what is already mapped and what + * is requested to be unmapped. + * If they don't match bail out early. For instance, this could happen + * if two CPUs are requesting to unmap the same P2M entry concurrently. + */ + for ( i = 0; i < nr; ) + { + unsigned int cur_order; + p2m_type_t t; + mfn_t mfn_return = p2m_get_entry(p2m, gfn_add(start_gfn, i), &t, NULL, + &cur_order, NULL); + + if ( p2m_is_any_ram(t) && + (!mfn_valid(mfn) || !mfn_eq(mfn_add(mfn, i), mfn_return)) ) + { + rc = -EILSEQ; + goto out; + } + + i += (1UL << cur_order) - + ((gfn_x(start_gfn) + i) & ((1UL << cur_order) - 1)); + } + + rc = p2m_set_entry(p2m, start_gfn, nr, INVALID_MFN, + p2m_invalid, p2m_access_rwx); + +out: + p2m_write_unlock(p2m); + + return rc; +} + +int map_regions_p2mt(struct domain *d, + gfn_t gfn, + unsigned long nr, + mfn_t mfn, + p2m_type_t p2mt) +{ + return p2m_insert_mapping(d, gfn, nr, mfn, p2mt); +} + +int unmap_regions_p2mt(struct domain *d, + gfn_t gfn, + unsigned long nr, + mfn_t mfn) +{ + return p2m_remove_mapping(d, gfn, nr, mfn); +} + +int map_mmio_regions(struct domain *d, + gfn_t start_gfn, + unsigned long nr, + mfn_t mfn) +{ + return p2m_insert_mapping(d, start_gfn, nr, mfn, p2m_mmio_direct_dev); +} + +int unmap_mmio_regions(struct domain *d, + gfn_t start_gfn, + unsigned long nr, + mfn_t mfn) +{ + return p2m_remove_mapping(d, start_gfn, nr, mfn); +} + +int map_dev_mmio_page(struct domain *d, gfn_t gfn, mfn_t mfn) +{ + int res; + + if ( !iomem_access_permitted(d, mfn_x(mfn), mfn_x(mfn)) ) + return 0; + + res = p2m_insert_mapping(d, gfn, 1, mfn, p2m_mmio_direct_c); + if ( res < 0 ) + { + printk(XENLOG_G_ERR "Unable to map MFN %#"PRI_mfn" in %pd\n", + mfn_x(mfn), d); + return res; + } + + return 0; +} + +int guest_physmap_add_entry(struct domain *d, + gfn_t gfn, + mfn_t mfn, + unsigned long page_order, + p2m_type_t t) +{ + return p2m_insert_mapping(d, gfn, (1 << page_order), mfn, t); +} + +int guest_physmap_remove_page(struct domain *d, gfn_t gfn, mfn_t mfn, + unsigned int page_order) +{ + return p2m_remove_mapping(d, gfn, (1 << page_order), mfn); +} + +int set_foreign_p2m_entry(struct domain *d, const struct domain *fd, + unsigned long gfn, mfn_t mfn) +{ + struct page_info *page = mfn_to_page(mfn); + int rc; + + ASSERT(arch_acquire_resource_check(d)); + + if ( !get_page(page, fd) ) + return -EINVAL; + + /* + * It is valid to always use p2m_map_foreign_rw here as if this gets + * called then d != fd. A case when d == fd would be rejected by + * rcu_lock_remote_domain_by_id() earlier. Put a respective ASSERT() + * to catch incorrect usage in future. + */ + ASSERT(d != fd); + + rc = guest_physmap_add_entry(d, _gfn(gfn), mfn, 0, p2m_map_foreign_rw); + if ( rc ) + put_page(page); + + return rc; +} + +static struct page_info *p2m_allocate_root(void) +{ + struct page_info *page; + unsigned int i; + + page = alloc_domheap_pages(NULL, P2M_ROOT_ORDER, 0); + if ( page == NULL ) + return NULL; + + /* Clear both first level pages */ + for ( i = 0; i < P2M_ROOT_PAGES; i++ ) + clear_and_clean_page(page + i); + + return page; +} + +static int p2m_alloc_table(struct domain *d) +{ + struct p2m_domain *p2m = p2m_get_hostp2m(d); + + p2m->root = p2m_allocate_root(); + if ( !p2m->root ) + return -ENOMEM; + + p2m->vttbr = generate_vttbr(p2m->vmid, page_to_mfn(p2m->root)); + + /* + * Make sure that all TLBs corresponding to the new VMID are flushed + * before using it + */ + p2m_write_lock(p2m); + p2m_force_tlb_flush_sync(p2m); + p2m_write_unlock(p2m); + + return 0; +} + + +static spinlock_t vmid_alloc_lock = SPIN_LOCK_UNLOCKED; + +/* + * VTTBR_EL2 VMID field is 8 or 16 bits. AArch64 may support 16-bit VMID. + * Using a bitmap here limits us to 256 or 65536 (for AArch64) concurrent + * domains. The bitmap space will be allocated dynamically based on + * whether 8 or 16 bit VMIDs are supported. + */ +static unsigned long *vmid_mask; + +static void p2m_vmid_allocator_init(void) +{ + /* + * allocate space for vmid_mask based on MAX_VMID + */ + vmid_mask = xzalloc_array(unsigned long, BITS_TO_LONGS(MAX_VMID)); + + if ( !vmid_mask ) + panic("Could not allocate VMID bitmap space\n"); + + set_bit(INVALID_VMID, vmid_mask); +} + +static int p2m_alloc_vmid(struct domain *d) +{ + struct p2m_domain *p2m = p2m_get_hostp2m(d); + + int rc, nr; + + spin_lock(&vmid_alloc_lock); + + nr = find_first_zero_bit(vmid_mask, MAX_VMID); + + ASSERT(nr != INVALID_VMID); + + if ( nr == MAX_VMID ) + { + rc = -EBUSY; + printk(XENLOG_ERR "p2m.c: dom%d: VMID pool exhausted\n", d->domain_id); + goto out; + } + + set_bit(nr, vmid_mask); + + p2m->vmid = nr; + + rc = 0; + +out: + spin_unlock(&vmid_alloc_lock); + return rc; +} + +static void p2m_free_vmid(struct domain *d) +{ + struct p2m_domain *p2m = p2m_get_hostp2m(d); + spin_lock(&vmid_alloc_lock); + if ( p2m->vmid != INVALID_VMID ) + clear_bit(p2m->vmid, vmid_mask); + + spin_unlock(&vmid_alloc_lock); +} + +int p2m_teardown(struct domain *d, bool allow_preemption) +{ + struct p2m_domain *p2m = p2m_get_hostp2m(d); + unsigned long count = 0; + struct page_info *pg; + unsigned int i; + int rc = 0; + + if ( page_list_empty(&p2m->pages) ) + return 0; + + p2m_write_lock(p2m); + + /* + * We are about to free the intermediate page-tables, so clear the + * root to prevent any walk to use them. + */ + for ( i = 0; i < P2M_ROOT_PAGES; i++ ) + clear_and_clean_page(p2m->root + i); + + /* + * The domain will not be scheduled anymore, so in theory we should + * not need to flush the TLBs. Do it for safety purpose. + * + * Note that all the devices have already been de-assigned. So we don't + * need to flush the IOMMU TLB here. + */ + p2m_force_tlb_flush_sync(p2m); + + while ( (pg = page_list_remove_head(&p2m->pages)) ) + { + p2m_free_page(p2m->domain, pg); + count++; + /* Arbitrarily preempt every 512 iterations */ + if ( allow_preemption && !(count % 512) && hypercall_preempt_check() ) + { + rc = -ERESTART; + break; + } + } + + p2m_write_unlock(p2m); + + return rc; +} + +void p2m_final_teardown(struct domain *d) +{ + struct p2m_domain *p2m = p2m_get_hostp2m(d); + + /* p2m not actually initialized */ + if ( !p2m->domain ) + return; + + /* + * No need to call relinquish_p2m_mapping() here because + * p2m_final_teardown() is called either after domain_relinquish_resources() + * where relinquish_p2m_mapping() has been called, or from failure path of + * domain_create()/arch_domain_create() where mappings that require + * p2m_put_l3_page() should never be created. For the latter case, also see + * comment on top of the p2m_set_entry() for more info. + */ + + BUG_ON(p2m_teardown(d, false)); + ASSERT(page_list_empty(&p2m->pages)); + + while ( p2m_teardown_allocation(d) == -ERESTART ) + continue; /* No preemption support here */ + ASSERT(page_list_empty(&d->arch.paging.p2m_freelist)); + + if ( p2m->root ) + free_domheap_pages(p2m->root, P2M_ROOT_ORDER); + + p2m->root = NULL; + + p2m_free_vmid(d); + + radix_tree_destroy(&p2m->mem_access_settings, NULL); + + p2m->domain = NULL; +} + +int p2m_init(struct domain *d) +{ + struct p2m_domain *p2m = p2m_get_hostp2m(d); + int rc; + unsigned int cpu; + + rwlock_init(&p2m->lock); + spin_lock_init(&d->arch.paging.lock); + INIT_PAGE_LIST_HEAD(&p2m->pages); + INIT_PAGE_LIST_HEAD(&d->arch.paging.p2m_freelist); + + p2m->vmid = INVALID_VMID; + p2m->max_mapped_gfn = _gfn(0); + p2m->lowest_mapped_gfn = _gfn(ULONG_MAX); + + p2m->default_access = p2m_access_rwx; + p2m->mem_access_enabled = false; + radix_tree_init(&p2m->mem_access_settings); + + /* + * Some IOMMUs don't support coherent PT walk. When the p2m is + * shared with the CPU, Xen has to make sure that the PT changes have + * reached the memory + */ + p2m->clean_pte = is_iommu_enabled(d) && + !iommu_has_feature(d, IOMMU_FEAT_COHERENT_WALK); + + /* + * Make sure that the type chosen to is able to store the an vCPU ID + * between 0 and the maximum of virtual CPUS supported as long as + * the INVALID_VCPU_ID. + */ + BUILD_BUG_ON((1 << (sizeof(p2m->last_vcpu_ran[0]) * 8)) < MAX_VIRT_CPUS); + BUILD_BUG_ON((1 << (sizeof(p2m->last_vcpu_ran[0])* 8)) < INVALID_VCPU_ID); + + for_each_possible_cpu(cpu) + p2m->last_vcpu_ran[cpu] = INVALID_VCPU_ID; + + /* + * "Trivial" initialisation is now complete. Set the backpointer so + * p2m_teardown() and friends know to do something. + */ + p2m->domain = d; + + rc = p2m_alloc_vmid(d); + if ( rc ) + return rc; + + rc = p2m_alloc_table(d); + if ( rc ) + return rc; + + /* + * Hardware using GICv2 needs to create a P2M mapping of 8KB GICv2 area + * when the domain is created. Considering the worst case for page + * tables and keep a buffer, populate 16 pages to the P2M pages pool here. + * For GICv3, the above-mentioned P2M mapping is not necessary, but since + * the allocated 16 pages here would not be lost, hence populate these + * pages unconditionally. + */ + spin_lock(&d->arch.paging.lock); + rc = p2m_set_allocation(d, 16, NULL); + spin_unlock(&d->arch.paging.lock); + if ( rc ) + return rc; + + return 0; +} + +/* + * The function will go through the p2m and remove page reference when it + * is required. The mapping will be removed from the p2m. + * + * XXX: See whether the mapping can be left intact in the p2m. + */ +int relinquish_p2m_mapping(struct domain *d) +{ + struct p2m_domain *p2m = p2m_get_hostp2m(d); + unsigned long count = 0; + p2m_type_t t; + int rc = 0; + unsigned int order; + gfn_t start, end; + + BUG_ON(!d->is_dying); + /* No mappings can be added in the P2M after the P2M lock is released. */ + p2m_write_lock(p2m); + + start = p2m->lowest_mapped_gfn; + end = gfn_add(p2m->max_mapped_gfn, 1); + + for ( ; gfn_x(start) < gfn_x(end); + start = gfn_next_boundary(start, order) ) + { + mfn_t mfn = p2m_get_entry(p2m, start, &t, NULL, &order, NULL); + + count++; + /* + * Arbitrarily preempt every 512 iterations. + */ + if ( !(count % 512) && hypercall_preempt_check() ) + { + rc = -ERESTART; + break; + } + + /* + * p2m_set_entry will take care of removing reference on page + * when it is necessary and removing the mapping in the p2m. + */ + if ( !mfn_eq(mfn, INVALID_MFN) ) + { + /* + * For valid mapping, the start will always be aligned as + * entry will be removed whilst relinquishing. + */ + rc = __p2m_set_entry(p2m, start, order, INVALID_MFN, + p2m_invalid, p2m_access_rwx); + if ( unlikely(rc) ) + { + printk(XENLOG_G_ERR "Unable to remove mapping gfn=%#"PRI_gfn" order=%u from the p2m of domain %d\n", gfn_x(start), order, d->domain_id); + break; + } + } + } + + /* + * Update lowest_mapped_gfn so on the next call we still start where + * we stopped. + */ + p2m->lowest_mapped_gfn = start; + + p2m_write_unlock(p2m); + + return rc; +} + +int p2m_cache_flush_range(struct domain *d, gfn_t *pstart, gfn_t end) +{ + struct p2m_domain *p2m = p2m_get_hostp2m(d); + gfn_t next_block_gfn; + gfn_t start = *pstart; + mfn_t mfn = INVALID_MFN; + p2m_type_t t; + unsigned int order; + int rc = 0; + /* Counter for preemption */ + unsigned short count = 0; + + /* + * The operation cache flush will invalidate the RAM assigned to the + * guest in a given range. It will not modify the page table and + * flushing the cache whilst the page is used by another CPU is + * fine. So using read-lock is fine here. + */ + p2m_read_lock(p2m); + + start = gfn_max(start, p2m->lowest_mapped_gfn); + end = gfn_min(end, gfn_add(p2m->max_mapped_gfn, 1)); + + next_block_gfn = start; + + while ( gfn_x(start) < gfn_x(end) ) + { + /* + * Cleaning the cache for the P2M may take a long time. So we + * need to be able to preempt. We will arbitrarily preempt every + * time count reach 512 or above. + * + * The count will be incremented by: + * - 1 on region skipped + * - 10 for each page requiring a flush + */ + if ( count >= 512 ) + { + if ( softirq_pending(smp_processor_id()) ) + { + rc = -ERESTART; + break; + } + count = 0; + } + + /* + * We want to flush page by page as: + * - it may not be possible to map the full block (can be up to 1GB) + * in Xen memory + * - we may want to do fine grain preemption as flushing multiple + * page in one go may take a long time + * + * As p2m_get_entry is able to return the size of the mapping + * in the p2m, it is pointless to execute it for each page. + * + * We can optimize it by tracking the gfn of the next + * block. So we will only call p2m_get_entry for each block (can + * be up to 1GB). + */ + if ( gfn_eq(start, next_block_gfn) ) + { + bool valid; + + mfn = p2m_get_entry(p2m, start, &t, NULL, &order, &valid); + next_block_gfn = gfn_next_boundary(start, order); + + if ( mfn_eq(mfn, INVALID_MFN) || !p2m_is_any_ram(t) || !valid ) + { + count++; + start = next_block_gfn; + continue; + } + } + + count += 10; + + flush_page_to_ram(mfn_x(mfn), false); + + start = gfn_add(start, 1); + mfn = mfn_add(mfn, 1); + } + + if ( rc != -ERESTART ) + invalidate_icache(); + + p2m_read_unlock(p2m); + + *pstart = start; + + return rc; +} + +/* + * Clean & invalidate RAM associated to the guest vCPU. + * + * The function can only work with the current vCPU and should be called + * with IRQ enabled as the vCPU could get preempted. + */ +void p2m_flush_vm(struct vcpu *v) +{ + struct p2m_domain *p2m = p2m_get_hostp2m(v->domain); + int rc; + gfn_t start = _gfn(0); + + ASSERT(v == current); + ASSERT(local_irq_is_enabled()); + ASSERT(v->arch.need_flush_to_ram); + + do + { + rc = p2m_cache_flush_range(v->domain, &start, _gfn(ULONG_MAX)); + if ( rc == -ERESTART ) + do_softirq(); + } while ( rc == -ERESTART ); + + if ( rc != 0 ) + gprintk(XENLOG_WARNING, + "P2M has not been correctly cleaned (rc = %d)\n", + rc); + + /* + * Invalidate the p2m to track which page was modified by the guest + * between call of p2m_flush_vm(). + */ + p2m_invalidate_root(p2m); + + v->arch.need_flush_to_ram = false; +} + +/* + * See note at ARMv7 ARM B1.14.4 (DDI 0406C.c) (TL;DR: S/W ops are not + * easily virtualized). + * + * Main problems: + * - S/W ops are local to a CPU (not broadcast) + * - We have line migration behind our back (speculation) + * - System caches don't support S/W at all (damn!) + * + * In the face of the above, the best we can do is to try and convert + * S/W ops to VA ops. Because the guest is not allowed to infer the S/W + * to PA mapping, it can only use S/W to nuke the whole cache, which is + * rather a good thing for us. + * + * Also, it is only used when turning caches on/off ("The expected + * usage of the cache maintenance instructions that operate by set/way + * is associated with the powerdown and powerup of caches, if this is + * required by the implementation."). + * + * We use the following policy: + * - If we trap a S/W operation, we enabled VM trapping to detect + * caches being turned on/off, and do a full clean. + * + * - We flush the caches on both caches being turned on and off. + * + * - Once the caches are enabled, we stop trapping VM ops. + */ +void p2m_set_way_flush(struct vcpu *v, struct cpu_user_regs *regs, + const union hsr hsr) +{ + /* This function can only work with the current vCPU. */ + ASSERT(v == current); + + if ( iommu_use_hap_pt(current->domain) ) + { + gprintk(XENLOG_ERR, + "The cache should be flushed by VA rather than by set/way.\n"); + inject_undef_exception(regs, hsr); + return; + } + + if ( !(v->arch.hcr_el2 & HCR_TVM) ) + { + v->arch.need_flush_to_ram = true; + vcpu_hcr_set_flags(v, HCR_TVM); + } +} + +void p2m_toggle_cache(struct vcpu *v, bool was_enabled) +{ + bool now_enabled = vcpu_has_cache_enabled(v); + + /* This function can only work with the current vCPU. */ + ASSERT(v == current); + + /* + * If switching the MMU+caches on, need to invalidate the caches. + * If switching it off, need to clean the caches. + * Clean + invalidate does the trick always. + */ + if ( was_enabled != now_enabled ) + v->arch.need_flush_to_ram = true; + + /* Caches are now on, stop trapping VM ops (until a S/W op) */ + if ( now_enabled ) + vcpu_hcr_clear_flags(v, HCR_TVM); +} + +mfn_t gfn_to_mfn(struct domain *d, gfn_t gfn) +{ + return p2m_lookup(d, gfn, NULL); +} + +struct page_info *get_page_from_gva(struct vcpu *v, vaddr_t va, + unsigned long flags) +{ + struct domain *d = v->domain; + struct p2m_domain *p2m = p2m_get_hostp2m(d); + struct page_info *page = NULL; + paddr_t maddr = 0; + uint64_t par; + mfn_t mfn; + p2m_type_t t; + + /* + * XXX: To support a different vCPU, we would need to load the + * VTTBR_EL2, TTBR0_EL1, TTBR1_EL1 and SCTLR_EL1 + */ + if ( v != current ) + return NULL; + + /* + * The lock is here to protect us against the break-before-make + * sequence used when updating the entry. + */ + p2m_read_lock(p2m); + par = gvirt_to_maddr(va, &maddr, flags); + p2m_read_unlock(p2m); + + /* + * gvirt_to_maddr may fail if the entry does not have the valid bit + * set. Fallback to the second method: + * 1) Translate the VA to IPA using software lookup -> Stage-1 page-table + * may not be accessible because the stage-2 entries may have valid + * bit unset. + * 2) Software lookup of the MFN + * + * Note that when memaccess is enabled, we instead call directly + * p2m_mem_access_check_and_get_page(...). Because the function is a + * a variant of the methods described above, it will be able to + * handle entries with valid bit unset. + * + * TODO: Integrate more nicely memaccess with the rest of the + * function. + * TODO: Use the fault error in PAR_EL1 to avoid pointless + * translation. + */ + if ( par ) + { + paddr_t ipa; + unsigned int s1_perms; + + /* + * When memaccess is enabled, the translation GVA to MADDR may + * have failed because of a permission fault. + */ + if ( p2m->mem_access_enabled ) + return p2m_mem_access_check_and_get_page(va, flags, v); + + /* + * The software stage-1 table walk can still fail, e.g, if the + * GVA is not mapped. + */ + if ( !guest_walk_tables(v, va, &ipa, &s1_perms) ) + { + dprintk(XENLOG_G_DEBUG, + "%pv: Failed to walk page-table va %#"PRIvaddr"\n", v, va); + return NULL; + } + + mfn = p2m_lookup(d, gaddr_to_gfn(ipa), &t); + if ( mfn_eq(INVALID_MFN, mfn) || !p2m_is_ram(t) ) + return NULL; + + /* + * Check permission that are assumed by the caller. For instance + * in case of guestcopy, the caller assumes that the translated + * page can be accessed with the requested permissions. If this + * is not the case, we should fail. + * + * Please note that we do not check for the GV2M_EXEC + * permission. This is fine because the hardware-based translation + * instruction does not test for execute permissions. + */ + if ( (flags & GV2M_WRITE) && !(s1_perms & GV2M_WRITE) ) + return NULL; + + if ( (flags & GV2M_WRITE) && t != p2m_ram_rw ) + return NULL; + } + else + mfn = maddr_to_mfn(maddr); + + if ( !mfn_valid(mfn) ) + { + dprintk(XENLOG_G_DEBUG, "%pv: Invalid MFN %#"PRI_mfn"\n", + v, mfn_x(mfn)); + return NULL; + } + + page = mfn_to_page(mfn); + ASSERT(page); + + if ( unlikely(!get_page(page, d)) ) + { + dprintk(XENLOG_G_DEBUG, "%pv: Failing to acquire the MFN %#"PRI_mfn"\n", + v, mfn_x(maddr_to_mfn(maddr))); + return NULL; + } + + return page; +} + +/* VTCR value to be configured by all CPUs. Set only once by the boot CPU */ +static register_t __read_mostly vtcr; + +static void setup_virt_paging_one(void *data) +{ + WRITE_SYSREG(vtcr, VTCR_EL2); + + /* + * ARM64_WORKAROUND_AT_SPECULATE: We want to keep the TLBs free from + * entries related to EL1/EL0 translation regime until a guest vCPU + * is running. For that, we need to set-up VTTBR to point to an empty + * page-table and turn on stage-2 translation. The TLB entries + * associated with EL1/EL0 translation regime will also be flushed in case + * an AT instruction was speculated before hand. + */ + if ( cpus_have_cap(ARM64_WORKAROUND_AT_SPECULATE) ) + { + WRITE_SYSREG64(generate_vttbr(INVALID_VMID, empty_root_mfn), VTTBR_EL2); + WRITE_SYSREG(READ_SYSREG(HCR_EL2) | HCR_VM, HCR_EL2); + isb(); + + flush_all_guests_tlb_local(); + } +} + +void __init setup_virt_paging(void) +{ + /* Setup Stage 2 address translation */ + register_t val = VTCR_RES1|VTCR_SH0_IS|VTCR_ORGN0_WBWA|VTCR_IRGN0_WBWA; + +#ifdef CONFIG_ARM_32 + if ( p2m_ipa_bits < 40 ) + panic("P2M: Not able to support %u-bit IPA at the moment\n", + p2m_ipa_bits); + + printk("P2M: 40-bit IPA\n"); + p2m_ipa_bits = 40; + val |= VTCR_T0SZ(0x18); /* 40 bit IPA */ + val |= VTCR_SL0(0x1); /* P2M starts at first level */ +#else /* CONFIG_ARM_64 */ + const struct { + unsigned int pabits; /* Physical Address Size */ + unsigned int t0sz; /* Desired T0SZ, minimum in comment */ + unsigned int root_order; /* Page order of the root of the p2m */ + unsigned int sl0; /* Desired SL0, maximum in comment */ + } pa_range_info[] = { + /* T0SZ minimum and SL0 maximum from ARM DDI 0487H.a Table D5-6 */ + /* PA size, t0sz(min), root-order, sl0(max) */ + [0] = { 32, 32/*32*/, 0, 1 }, + [1] = { 36, 28/*28*/, 0, 1 }, + [2] = { 40, 24/*24*/, 1, 1 }, + [3] = { 42, 22/*22*/, 3, 1 }, + [4] = { 44, 20/*20*/, 0, 2 }, + [5] = { 48, 16/*16*/, 0, 2 }, + [6] = { 52, 12/*12*/, 4, 2 }, + [7] = { 0 } /* Invalid */ + }; + + unsigned int i; + unsigned int pa_range = 0x10; /* Larger than any possible value */ + + /* + * Restrict "p2m_ipa_bits" if needed. As P2M table is always configured + * with IPA bits == PA bits, compare against "pabits". + */ + if ( pa_range_info[system_cpuinfo.mm64.pa_range].pabits < p2m_ipa_bits ) + p2m_ipa_bits = pa_range_info[system_cpuinfo.mm64.pa_range].pabits; + + /* + * cpu info sanitization made sure we support 16bits VMID only if all + * cores are supporting it. + */ + if ( system_cpuinfo.mm64.vmid_bits == MM64_VMID_16_BITS_SUPPORT ) + max_vmid = MAX_VMID_16_BIT; + + /* Choose suitable "pa_range" according to the resulted "p2m_ipa_bits". */ + for ( i = 0; i < ARRAY_SIZE(pa_range_info); i++ ) + { + if ( p2m_ipa_bits == pa_range_info[i].pabits ) + { + pa_range = i; + break; + } + } + + /* pa_range is 4 bits but we don't support all modes */ + if ( pa_range >= ARRAY_SIZE(pa_range_info) || !pa_range_info[pa_range].pabits ) + panic("Unknown encoding of ID_AA64MMFR0_EL1.PARange %x\n", pa_range); + + val |= VTCR_PS(pa_range); + val |= VTCR_TG0_4K; + + /* Set the VS bit only if 16 bit VMID is supported. */ + if ( MAX_VMID == MAX_VMID_16_BIT ) + val |= VTCR_VS; + val |= VTCR_SL0(pa_range_info[pa_range].sl0); + val |= VTCR_T0SZ(pa_range_info[pa_range].t0sz); + + p2m_root_order = pa_range_info[pa_range].root_order; + p2m_root_level = 2 - pa_range_info[pa_range].sl0; + p2m_ipa_bits = 64 - pa_range_info[pa_range].t0sz; + + printk("P2M: %d-bit IPA with %d-bit PA and %d-bit VMID\n", + p2m_ipa_bits, + pa_range_info[pa_range].pabits, + ( MAX_VMID == MAX_VMID_16_BIT ) ? 16 : 8); +#endif + printk("P2M: %d levels with order-%d root, VTCR 0x%"PRIregister"\n", + 4 - P2M_ROOT_LEVEL, P2M_ROOT_ORDER, val); + + p2m_vmid_allocator_init(); + + /* It is not allowed to concatenate a level zero root */ + BUG_ON( P2M_ROOT_LEVEL == 0 && P2M_ROOT_ORDER > 0 ); + vtcr = val; + + /* + * ARM64_WORKAROUND_AT_SPECULATE requires to allocate root table + * with all entries zeroed. + */ + if ( cpus_have_cap(ARM64_WORKAROUND_AT_SPECULATE) ) + { + struct page_info *root; + + root = p2m_allocate_root(); + if ( !root ) + panic("Unable to allocate root table for ARM64_WORKAROUND_AT_SPECULATE\n"); + + empty_root_mfn = page_to_mfn(root); + } + + setup_virt_paging_one(NULL); + smp_call_function(setup_virt_paging_one, NULL, 1); +} + +static int cpu_virt_paging_callback(struct notifier_block *nfb, + unsigned long action, + void *hcpu) +{ + switch ( action ) + { + case CPU_STARTING: + ASSERT(system_state != SYS_STATE_boot); + setup_virt_paging_one(NULL); + break; + default: + break; + } + + return NOTIFY_DONE; +} + +static struct notifier_block cpu_virt_paging_nfb = { + .notifier_call = cpu_virt_paging_callback, +}; + +static int __init cpu_virt_paging_init(void) +{ + register_cpu_notifier(&cpu_virt_paging_nfb); + + return 0; +} +/* + * Initialization of the notifier has to be done at init rather than presmp_init + * phase because: the registered notifier is used to setup virtual paging for + * non-boot CPUs after the initial virtual paging for all CPUs is already setup, + * i.e. when a non-boot CPU is hotplugged after the system has booted. In other + * words, the notifier should be registered after the virtual paging is + * initially setup (setup_virt_paging() is called from start_xen()). This is + * required because vtcr config value has to be set before a notifier can fire. + */ +__initcall(cpu_virt_paging_init); + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/arm/p2m_mpu.c b/xen/arch/arm/p2m_mpu.c new file mode 100644 index 0000000000..0a95d58111 --- /dev/null +++ b/xen/arch/arm/p2m_mpu.c @@ -0,0 +1,191 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#include +#include +#include + +#include + +/* TODO: Implement on the first usage */ +void p2m_write_unlock(struct p2m_domain *p2m) +{ +} + +void p2m_dump_info(struct domain *d) +{ +} + +void dump_p2m_lookup(struct domain *d, paddr_t addr) +{ +} + +void p2m_save_state(struct vcpu *p) +{ +} + +void p2m_restore_state(struct vcpu *n) +{ +} + +mfn_t p2m_get_entry(struct p2m_domain *p2m, gfn_t gfn, + p2m_type_t *t, p2m_access_t *a, + unsigned int *page_order, + bool *valid) +{ + return INVALID_MFN; +} + +mfn_t p2m_lookup(struct domain *d, gfn_t gfn, p2m_type_t *t) +{ + return INVALID_MFN; +} + +struct page_info *p2m_get_page_from_gfn(struct domain *d, gfn_t gfn, + p2m_type_t *t) +{ + return NULL; +} + +int p2m_set_entry(struct p2m_domain *p2m, + gfn_t sgfn, + unsigned long nr, + mfn_t smfn, + p2m_type_t t, + p2m_access_t a) +{ + return -ENOSYS; +} + +void p2m_invalidate_root(struct p2m_domain *p2m) +{ +} + +bool p2m_resolve_translation_fault(struct domain *d, gfn_t gfn) +{ + return false; +} + +int p2m_insert_mapping(struct domain *d, gfn_t start_gfn, unsigned long nr, + mfn_t mfn, p2m_type_t t) +{ + return -ENOSYS; +} + +int map_regions_p2mt(struct domain *d, + gfn_t gfn, + unsigned long nr, + mfn_t mfn, + p2m_type_t p2mt) +{ + return -ENOSYS; +} + +int unmap_regions_p2mt(struct domain *d, + gfn_t gfn, + unsigned long nr, + mfn_t mfn) +{ + return -ENOSYS; +} + +int map_mmio_regions(struct domain *d, + gfn_t start_gfn, + unsigned long nr, + mfn_t mfn) +{ + return -ENOSYS; +} + +int unmap_mmio_regions(struct domain *d, + gfn_t start_gfn, + unsigned long nr, + mfn_t mfn) +{ + return -ENOSYS; +} + +int map_dev_mmio_page(struct domain *d, gfn_t gfn, mfn_t mfn) +{ + return -ENOSYS; +} + +int guest_physmap_add_entry(struct domain *d, + gfn_t gfn, + mfn_t mfn, + unsigned long page_order, + p2m_type_t t) +{ + return -ENOSYS; +} + +int guest_physmap_remove_page(struct domain *d, gfn_t gfn, mfn_t mfn, + unsigned int page_order) +{ + return -ENOSYS; +} + +int set_foreign_p2m_entry(struct domain *d, const struct domain *fd, + unsigned long gfn, mfn_t mfn) +{ + return -ENOSYS; +} + +int p2m_teardown(struct domain *d, bool allow_preemption) +{ + return -ENOSYS; +} + +void p2m_final_teardown(struct domain *d) +{ +} + +int p2m_init(struct domain *d) +{ + return -ENOSYS; +} + +int relinquish_p2m_mapping(struct domain *d) +{ + return -ENOSYS; +} + +int p2m_cache_flush_range(struct domain *d, gfn_t *pstart, gfn_t end) +{ + return -ENOSYS; +} + +void p2m_flush_vm(struct vcpu *v) +{ +} + +void p2m_set_way_flush(struct vcpu *v, struct cpu_user_regs *regs, + const union hsr hsr) +{ +} + +void p2m_toggle_cache(struct vcpu *v, bool was_enabled) +{ +} + +mfn_t gfn_to_mfn(struct domain *d, gfn_t gfn) +{ + return INVALID_MFN; +} + +struct page_info *get_page_from_gva(struct vcpu *v, vaddr_t va, + unsigned long flags) +{ + return NULL; +} + +void __init setup_virt_paging(void) +{ +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 13 05:35:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 05:35:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476571.738898 (Exim 4.92) (envelope-from ) id 1pGCj6-0007qE-LD; Fri, 13 Jan 2023 05:35:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476571.738898; Fri, 13 Jan 2023 05:35:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCj6-0007no-FC; Fri, 13 Jan 2023 05:35:40 +0000 Received: by outflank-mailman (input) for mailman id 476571; Fri, 13 Jan 2023 05:35:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCec-0005sJ-EQ for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 05:31:02 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 772af550-9303-11ed-91b6-6bf2151ebd3b; Fri, 13 Jan 2023 06:31:01 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 00DCFFEC; Thu, 12 Jan 2023 21:31:43 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 42AD23F587; Thu, 12 Jan 2023 21:30:58 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 772af550-9303-11ed-91b6-6bf2151ebd3b From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v2 27/40] xen/mpu: map device memory resource in MPU system Date: Fri, 13 Jan 2023 13:29:00 +0800 Message-Id: <20230113052914.3845596-28-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230113052914.3845596-1-Penny.Zheng@arm.com> References: <20230113052914.3845596-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In MPU system, we could not afford mapping a new MPU memory region with each new device, it will exhaust limited MPU memory regions very quickly. So we introduce `mpu,device-memory-section` for users to statically configure the whole system device memory with the least number of memory regions in Device Tree. This section shall cover all devices that will be used in Xen, like `UART`, `GIC`, etc. Before we map `mpu,device-memory-section` with device memory attributes and permissions(REGION_HYPRVISOR_NOCACHE), we shall destroy the mapping for early UART which got set up in assembly boot-time, to avoid MPU memory region overlapping. Signed-off-by: Penny Zheng Signed-off-by: Wei Chen --- xen/arch/arm/include/asm/arm64/mpu.h | 6 ++++-- xen/arch/arm/include/asm/setup.h | 1 + xen/arch/arm/mm_mpu.c | 14 +++++++++++++- xen/arch/arm/setup_mpu.c | 5 +++++ 4 files changed, 23 insertions(+), 3 deletions(-) diff --git a/xen/arch/arm/include/asm/arm64/mpu.h b/xen/arch/arm/include/asm/arm64/mpu.h index c1dea1c8e9..8e8679bc82 100644 --- a/xen/arch/arm/include/asm/arm64/mpu.h +++ b/xen/arch/arm/include/asm/arm64/mpu.h @@ -69,10 +69,11 @@ #define REGION_TRANSIENT_MASK(x) (((x) >> _REGION_TRANSIENT_BIT) & 0x3U) /* - * _REGION_NORMAL is convenience define. It is not meant to be used - * outside of this header. + * _REGION_NORMAL and _REGION_DEVICE are convenience defines. They are not + * meant to be used outside of this header. */ #define _REGION_NORMAL (MT_NORMAL|_REGION_PRESENT) +#define _REGION_DEVICE (_REGION_XN|_REGION_PRESENT) #define REGION_HYPERVISOR_RW (_REGION_NORMAL|_REGION_XN) #define REGION_HYPERVISOR_RO (_REGION_NORMAL|_REGION_XN|_REGION_RO) @@ -80,6 +81,7 @@ #define REGION_HYPERVISOR REGION_HYPERVISOR_RW #define REGION_HYPERVISOR_BOOT (REGION_HYPERVISOR_RW|_REGION_BOOTONLY) #define REGION_HYPERVISOR_SWITCH (REGION_HYPERVISOR_RW|_REGION_SWITCH) +#define REGION_HYPERVISOR_NOCACHE (_REGION_DEVICE|MT_DEVICE_nGnRE|_REGION_SWITCH) #define INVALID_REGION (~0UL) diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index 3581f8f990..b7a2225c25 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -194,6 +194,7 @@ struct init_info /* Index of MPU memory section */ enum mpu_section_info { MSINFO_GUEST, + MSINFO_DEVICE, MSINFO_MAX }; diff --git a/xen/arch/arm/mm_mpu.c b/xen/arch/arm/mm_mpu.c index 3a0d110b13..1566ba60af 100644 --- a/xen/arch/arm/mm_mpu.c +++ b/xen/arch/arm/mm_mpu.c @@ -73,6 +73,7 @@ struct page_info *frame_table; static const unsigned int mpu_section_mattr[MSINFO_MAX] = { REGION_HYPERVISOR_SWITCH, + REGION_HYPERVISOR_NOCACHE, }; /* Write a MPU protection region */ @@ -673,8 +674,19 @@ void __init setup_static_mappings(void) setup_staticheap_mappings(); for ( uint8_t i = MSINFO_GUEST; i < MSINFO_MAX; i++ ) + { +#ifdef CONFIG_EARLY_PRINTK + if ( i == MSINFO_DEVICE ) + /* + * Destroy early UART mapping before mapping device memory section. + * WARNING：console will be inaccessible temporarily. + */ + destroy_xen_mappings(CONFIG_EARLY_UART_BASE_ADDRESS, + CONFIG_EARLY_UART_BASE_ADDRESS + EARLY_UART_SIZE); +#endif map_mpu_memory_section_on_boot(i, mpu_section_mattr[i]); - /* TODO: device memory section, boot-module section, etc */ + } + /* TODO: boot-module section, etc */ } /* Map a frame table to cover physical addresses ps through pe */ diff --git a/xen/arch/arm/setup_mpu.c b/xen/arch/arm/setup_mpu.c index 09a38a34a4..ec05542f68 100644 --- a/xen/arch/arm/setup_mpu.c +++ b/xen/arch/arm/setup_mpu.c @@ -29,6 +29,7 @@ const char *mpu_section_info_str[MSINFO_MAX] = { "mpu,guest-memory-section", + "mpu,device-memory-section", }; /* @@ -47,6 +48,10 @@ struct mpuinfo __initdata mpuinfo; * through "xen,static-mem" property in MPU system. "mpu,guest-memory-section" * limits the scattering of "xen,static-mem", as users could not define * a "xen,static-mem" outside "mpu,guest-memory-section". + * + * "mpu,device-memory-section": this section draws the device memory layout + * with the least number of memory regions for all devices in system that will + * be used in Xen, like `UART`, `GIC`, etc. */ static int __init process_mpu_memory_section(const void *fdt, int node, const char *name, void *data, -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 13 05:35:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 05:35:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476579.738914 (Exim 4.92) (envelope-from ) id 1pGCjF-0000Gf-0s; Fri, 13 Jan 2023 05:35:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476579.738914; Fri, 13 Jan 2023 05:35:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCjE-0000GW-Rv; Fri, 13 Jan 2023 05:35:48 +0000 Received: by outflank-mailman (input) for mailman id 476579; Fri, 13 Jan 2023 05:35:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCev-0005sJ-GW for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 05:31:21 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 8277fd1c-9303-11ed-91b6-6bf2151ebd3b; Fri, 13 Jan 2023 06:31:20 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D92BBFEC; Thu, 12 Jan 2023 21:32:01 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 1F50D3F587; Thu, 12 Jan 2023 21:31:15 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8277fd1c-9303-11ed-91b6-6bf2151ebd3b From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Penny Zheng Subject: [PATCH v2 32/40] xen/mpu: implement MPU version of ioremap_xxx Date: Fri, 13 Jan 2023 13:29:05 +0800 Message-Id: <20230113052914.3845596-33-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230113052914.3845596-1-Penny.Zheng@arm.com> References: <20230113052914.3845596-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Function ioremap_xxx is normally being used to remap device address ranges in MMU system during device driver initialization. However, in MPU system, virtual translation is not supported and device memory layout is statically configured in Device Tree, and being mapped at very early stage. So here we only add a check to verify this assumption. But for tolerating a few cases where the function is called to map for temporary copy and paste, like ioremap_wc in kernel image loading, the region attribute mismatch will be treated as warning than error. Signed-off-by: Penny Zheng Signed-off-by: Wei Chen --- xen/arch/arm/include/asm/arm64/mpu.h | 1 + xen/arch/arm/include/asm/mm.h | 16 ++++- xen/arch/arm/include/asm/mm_mpu.h | 2 + xen/arch/arm/mm_mpu.c | 88 ++++++++++++++++++++++++---- xen/include/xen/vmap.h | 12 ++++ 5 files changed, 106 insertions(+), 13 deletions(-) diff --git a/xen/arch/arm/include/asm/arm64/mpu.h b/xen/arch/arm/include/asm/arm64/mpu.h index 8e8679bc82..b4e50a9a0e 100644 --- a/xen/arch/arm/include/asm/arm64/mpu.h +++ b/xen/arch/arm/include/asm/arm64/mpu.h @@ -82,6 +82,7 @@ #define REGION_HYPERVISOR_BOOT (REGION_HYPERVISOR_RW|_REGION_BOOTONLY) #define REGION_HYPERVISOR_SWITCH (REGION_HYPERVISOR_RW|_REGION_SWITCH) #define REGION_HYPERVISOR_NOCACHE (_REGION_DEVICE|MT_DEVICE_nGnRE|_REGION_SWITCH) +#define REGION_HYPERVISOR_WC (_REGION_DEVICE|MT_NORMAL_NC) #define INVALID_REGION (~0UL) diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h index 7969ec9f98..fa44cfc50d 100644 --- a/xen/arch/arm/include/asm/mm.h +++ b/xen/arch/arm/include/asm/mm.h @@ -14,6 +14,10 @@ # error "unknown ARM variant" #endif +#if defined(CONFIG_HAS_MPU) +# include +#endif + /* Align Xen to a 2 MiB boundary. */ #define XEN_PADDR_ALIGN (1 << 21) @@ -198,19 +202,25 @@ extern void setup_frametable_mappings(paddr_t ps, paddr_t pe); /* map a physical range in virtual memory */ void __iomem *ioremap_attr(paddr_t start, size_t len, unsigned int attributes); +#ifndef CONFIG_HAS_MPU +#define DEFINE_ATTRIBUTE(var) (PAGE_##var) +#else +#define DEFINE_ATTRIBUTE(var) (REGION_##var) +#endif + static inline void __iomem *ioremap_nocache(paddr_t start, size_t len) { - return ioremap_attr(start, len, PAGE_HYPERVISOR_NOCACHE); + return ioremap_attr(start, len, DEFINE_ATTRIBUTE(HYPERVISOR_NOCACHE)); } static inline void __iomem *ioremap_cache(paddr_t start, size_t len) { - return ioremap_attr(start, len, PAGE_HYPERVISOR); + return ioremap_attr(start, len, DEFINE_ATTRIBUTE(HYPERVISOR)); } static inline void __iomem *ioremap_wc(paddr_t start, size_t len) { - return ioremap_attr(start, len, PAGE_HYPERVISOR_WC); + return ioremap_attr(start, len, DEFINE_ATTRIBUTE(HYPERVISOR_WC)); } /* XXX -- account for base */ diff --git a/xen/arch/arm/include/asm/mm_mpu.h b/xen/arch/arm/include/asm/mm_mpu.h index eebd5b5d35..5aa61c43b6 100644 --- a/xen/arch/arm/include/asm/mm_mpu.h +++ b/xen/arch/arm/include/asm/mm_mpu.h @@ -2,6 +2,8 @@ #ifndef __ARCH_ARM_MM_MPU__ #define __ARCH_ARM_MM_MPU__ +#include + #define setup_mm_mappings(boot_phys_offset) ((void)(boot_phys_offset)) /* * Function setup_static_mappings() sets up MPU memory region mapping diff --git a/xen/arch/arm/mm_mpu.c b/xen/arch/arm/mm_mpu.c index ea64aa38e4..7b54c87acf 100644 --- a/xen/arch/arm/mm_mpu.c +++ b/xen/arch/arm/mm_mpu.c @@ -712,32 +712,100 @@ void __init setup_frametable_mappings(paddr_t ps, paddr_t pe) frametable_size - (nr_pdxs * sizeof(struct page_info))); } -/* TODO: Implementation on the first usage */ -void dump_hyp_walk(vaddr_t addr) +static bool region_attribute_match(pr_t *region, unsigned int attributes) { + if ( region->prbar.reg.ap != REGION_AP_MASK(attributes) ) + { + printk(XENLOG_ERR "region permission is not matched (0x%x -> 0x%x)\n", + region->prbar.reg.ap, REGION_AP_MASK(attributes)); + return false; + } + + if ( region->prbar.reg.xn != REGION_XN_MASK(attributes) ) + { + printk(XENLOG_ERR "region execution permission is not matched (0x%x -> 0x%x)\n", + region->prbar.reg.xn, REGION_XN_MASK(attributes)); + return false; + } + + if ( region->prlar.reg.ai != REGION_AI_MASK(attributes) ) + { + printk(XENLOG_ERR "region memory attributes is not matched (0x%x -> 0x%x)\n", + region->prlar.reg.ai, REGION_AI_MASK(attributes)); + return false; + } + + return true; } -void __init remove_early_mappings(void) +static bool check_region_and_attributes(paddr_t pa, size_t len, + unsigned int attributes, + const char *prefix) +{ + pr_t *region; + int rc; + uint64_t idx; + + rc = mpumap_contain_region(xen_mpumap, max_xen_mpumap, pa, pa + len - 1, + &idx); + if ( rc != MPUMAP_REGION_FOUND && rc != MPUMAP_REGION_INCLUSIVE ) + { + region_printk("%s: range 0x%"PRIpaddr" - 0x%"PRIpaddr" has not been properly mapped\n", + prefix, pa, pa + len - 1); + return false; + } + + region = &xen_mpumap[idx]; + /* + * For tolerating a few cases where the function is called to remap for + * temporary copy and paste, like ioremap_wc in kernel image loading, the + * permission mismatch will be treated as warning than error. + */ + if ( !region_attribute_match(region, attributes) ) + printk(XENLOG_WARNING + "mpu: %s: range 0x%"PRIpaddr" - 0x%"PRIpaddr" attributes mismatched\n", + prefix, pa, pa + len - 1); + + return true; +} + +/* + * This function is normally being used to remap device address ranges + * in MMU system. + * However, in MPU system, virtual translation is not supported and + * device memory is statically configured in FDT, while being mapped at very + * early stage. + * So here we only add a check to verify this assumption. + */ +void *ioremap_attr(paddr_t pa, size_t len, unsigned int attributes) { + if ( !check_region_and_attributes(pa, len, attributes, "ioremap") ) + return NULL; + + return maddr_to_virt(pa); } -int init_secondary_pagetables(int cpu) +void *ioremap(paddr_t pa, size_t len) { - return -ENOSYS; + return ioremap_attr(pa, len, REGION_HYPERVISOR_NOCACHE); } -void mmu_init_secondary_cpu(void) +/* TODO: Implementation on the first usage */ +void dump_hyp_walk(vaddr_t addr) { } -void *ioremap_attr(paddr_t pa, size_t len, unsigned int attributes) +void __init remove_early_mappings(void) { - return NULL; } -void *ioremap(paddr_t pa, size_t len) +int init_secondary_pagetables(int cpu) +{ + return -ENOSYS; +} + +void mmu_init_secondary_cpu(void) { - return NULL; } int modify_xen_mappings(unsigned long s, unsigned long e, unsigned int flags) diff --git a/xen/include/xen/vmap.h b/xen/include/xen/vmap.h index 2e3ae0ca6a..fc56d02fc8 100644 --- a/xen/include/xen/vmap.h +++ b/xen/include/xen/vmap.h @@ -89,15 +89,27 @@ static inline void vfree(void *va) ASSERT_UNREACHABLE(); } +#ifdef CONFIG_HAS_MPU +void __iomem *ioremap(paddr_t, size_t); +#else void __iomem *ioremap(paddr_t, size_t) { ASSERT_UNREACHABLE(); return NULL; } +#endif static inline void iounmap(void __iomem *va) { +#ifdef CONFIG_HAS_MPU + /* + * iounmap and ioremap are a couple, and as ioremap is only doing + * checking in MPU system, we do nothing and just return in iounmap + */ + return; +#else ASSERT_UNREACHABLE(); +#endif } static inline void *arch_vmap_virt_end(void) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 13 05:35:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 05:35:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476581.738925 (Exim 4.92) (envelope-from ) id 1pGCjH-0000gx-AW; Fri, 13 Jan 2023 05:35:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476581.738925; Fri, 13 Jan 2023 05:35:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCjH-0000go-73; Fri, 13 Jan 2023 05:35:51 +0000 Received: by outflank-mailman (input) for mailman id 476581; Fri, 13 Jan 2023 05:35:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCeE-0005sJ-1z for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 05:30:38 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 68527d9e-9303-11ed-91b6-6bf2151ebd3b; Fri, 13 Jan 2023 06:30:36 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 17767FEC; Thu, 12 Jan 2023 21:31:18 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 58DCA3F587; Thu, 12 Jan 2023 21:30:33 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 68527d9e-9303-11ed-91b6-6bf2151ebd3b From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v2 19/40] xen/mpu: populate a new region in Xen MPU mapping table Date: Fri, 13 Jan 2023 13:28:52 +0800 Message-Id: <20230113052914.3845596-20-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230113052914.3845596-1-Penny.Zheng@arm.com> References: <20230113052914.3845596-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The new helper xen_mpumap_update() is responsible for updating an entry in Xen MPU memory mapping table, including creating a new entry, updating or destroying an existing one. This commit only talks about populating a new entry in Xen MPU mapping table( xen_mpumap). Others will be introduced in the following commits. In xen_mpumap_update_entry(), firstly, we shall check if requested address range [base, limit) is not mapped. Then we use pr_of_xenaddr() to build up the structure of MPU memory region(pr_t). In the last, we set memory attribute and permission based on variable @flags. To summarize all region attributes in one variable @flags, layout of the flags is elaborated as follows: [0:2] Memory attribute Index [3:4] Execute Never [5:6] Access Permission [7] Region Present Also, we provide a set of definitions(REGION_HYPERVISOR_RW, etc) that combine the memory attribute and permission for common combinations. Signed-off-by: Penny Zheng Signed-off-by: Wei Chen --- xen/arch/arm/include/asm/arm64/mpu.h | 72 +++++++ xen/arch/arm/mm_mpu.c | 276 ++++++++++++++++++++++++++- 2 files changed, 340 insertions(+), 8 deletions(-) diff --git a/xen/arch/arm/include/asm/arm64/mpu.h b/xen/arch/arm/include/asm/arm64/mpu.h index c945dd53db..fcde6ad0db 100644 --- a/xen/arch/arm/include/asm/arm64/mpu.h +++ b/xen/arch/arm/include/asm/arm64/mpu.h @@ -16,6 +16,61 @@ */ #define ARM_MAX_MPU_MEMORY_REGIONS 255 +/* Access permission attributes. */ +/* Read/Write at EL2, No Access at EL1/EL0. */ +#define AP_RW_EL2 0x0 +/* Read/Write at EL2/EL1/EL0 all levels. */ +#define AP_RW_ALL 0x1 +/* Read-only at EL2, No Access at EL1/EL0. */ +#define AP_RO_EL2 0x2 +/* Read-only at EL2/EL1/EL0 all levels. */ +#define AP_RO_ALL 0x3 + +/* + * Excute never. + * Stage 1 EL2 translation regime. + * XN[1] determines whether execution of the instruction fetched from the MPU + * memory region is permitted. + * Stage 2 EL1/EL0 translation regime. + * XN[0] determines whether execution of the instruction fetched from the MPU + * memory region is permitted. + */ +#define XN_DISABLED 0x0 +#define XN_P2M_ENABLED 0x1 +#define XN_ENABLED 0x2 + +/* + * Layout of the flags used for updating Xen MPU region attributes + * [0:2] Memory attribute Index + * [3:4] Execute Never + * [5:6] Access Permission + * [7] Region Present + */ +#define _REGION_AI_BIT 0 +#define _REGION_XN_BIT 3 +#define _REGION_AP_BIT 5 +#define _REGION_PRESENT_BIT 7 +#define _REGION_XN (2U << _REGION_XN_BIT) +#define _REGION_RO (2U << _REGION_AP_BIT) +#define _REGION_PRESENT (1U << _REGION_PRESENT_BIT) +#define REGION_AI_MASK(x) (((x) >> _REGION_AI_BIT) & 0x7U) +#define REGION_XN_MASK(x) (((x) >> _REGION_XN_BIT) & 0x3U) +#define REGION_AP_MASK(x) (((x) >> _REGION_AP_BIT) & 0x3U) +#define REGION_RO_MASK(x) (((x) >> _REGION_AP_BIT) & 0x2U) + +/* + * _REGION_NORMAL is convenience define. It is not meant to be used + * outside of this header. + */ +#define _REGION_NORMAL (MT_NORMAL|_REGION_PRESENT) + +#define REGION_HYPERVISOR_RW (_REGION_NORMAL|_REGION_XN) +#define REGION_HYPERVISOR_RO (_REGION_NORMAL|_REGION_XN|_REGION_RO) + +#define REGION_HYPERVISOR REGION_HYPERVISOR_RW + +#define INVALID_REGION (~0UL) + #ifndef __ASSEMBLY__ /* Protection Region Base Address Register */ @@ -49,6 +104,23 @@ typedef struct { prlar_t prlar; } pr_t; +/* Access to set base address of MPU protection region(pr_t). */ +#define pr_set_base(pr, paddr) ({ \ + pr_t *_pr = pr; \ + _pr->prbar.reg.base = (paddr >> MPU_REGION_SHIFT); \ +}) + +/* Access to set limit address of MPU protection region(pr_t). */ +#define pr_set_limit(pr, paddr) ({ \ + pr_t *_pr = pr; \ + _pr->prlar.reg.limit = (paddr >> MPU_REGION_SHIFT); \ +}) + +#define region_is_valid(pr) ({ \ + pr_t *_pr = pr; \ + _pr->prlar.reg.en; \ +}) + #endif /* __ASSEMBLY__ */ #endif /* __ARM64_MPU_H__ */ diff --git a/xen/arch/arm/mm_mpu.c b/xen/arch/arm/mm_mpu.c index f2b494449c..08720a7c19 100644 --- a/xen/arch/arm/mm_mpu.c +++ b/xen/arch/arm/mm_mpu.c @@ -22,9 +22,23 @@ #include #include #include +#include #include #include +#ifdef NDEBUG +static inline void +__attribute__ ((__format__ (__printf__, 1, 2))) +region_printk(const char *fmt, ...) {} +#else +#define region_printk(fmt, args...) \ + do \ + { \ + dprintk(XENLOG_ERR, fmt, ## args); \ + WARN(); \ + } while (0) +#endif + /* Xen MPU memory region mapping table. */ pr_t __aligned(PAGE_SIZE) __section(".data.page_aligned") xen_mpumap[ARM_MAX_MPU_MEMORY_REGIONS]; @@ -46,6 +60,8 @@ uint64_t __ro_after_init next_transient_region_idx; /* Maximum number of supported MPU memory regions by the EL2 MPU. */ uint64_t __ro_after_init max_xen_mpumap; +static DEFINE_SPINLOCK(xen_mpumap_lock); + /* Write a MPU protection region */ #define WRITE_PROTECTION_REGION(sel, pr, prbar_el2, prlar_el2) ({ \ uint64_t _sel = sel; \ @@ -73,6 +89,28 @@ uint64_t __ro_after_init max_xen_mpumap; _pr; \ }) +/* + * In boot-time, fixed MPU regions(e.g. Xen text section) are added + * at the front, indexed by next_fixed_region_idx, the others like + * boot-only regions(e.g. early FDT) should be added at the rear, + * indexed by next_transient_region_idx. + * With more and more MPU regions added-in, when the two indexes + * meet and pass with each other, we would run out of the whole + * EL2 MPU memory regions. + */ +static bool __init xen_boot_mpu_regions_is_full(void) +{ + return next_transient_region_idx < next_fixed_region_idx; +} + +static void __init update_boot_xen_mpumap_idx(uint64_t idx) +{ + if ( idx == next_transient_region_idx ) + next_transient_region_idx--; + else + next_fixed_region_idx++; +} + /* * Access MPU protection region, including both read/write operations. * Armv8-R AArch64 at most supports 255 MPU protection regions. @@ -197,6 +235,236 @@ static void access_protection_region(bool read, pr_t *pr_read, } } +/* + * Standard entry for building up the structure of MPU memory region(pr_t). + * It is equivalent to mfn_to_xen_entry in MMU system. + * base and limit both refer to inclusive address. + */ +static inline pr_t pr_of_xenaddr(paddr_t base, paddr_t limit, unsigned attr) +{ + prbar_t prbar; + prlar_t prlar; + pr_t region; + + /* Build up value for PRBAR_EL2. */ + prbar = (prbar_t) { + .reg = { + .ap = AP_RW_EL2, /* Read/Write at EL2, no access at EL1/EL0. */ + .xn = XN_ENABLED, /* No need to execute outside .text */ + }}; + + switch ( attr ) + { + case MT_NORMAL_NC: + /* + * ARM ARM: Overlaying the shareability attribute (DDI + * 0406C.b B3-1376 to 1377) + * + * A memory region with a resultant memory type attribute of normal, + * and a resultant cacheability attribute of Inner non-cacheable, + * outer non-cacheable, must have a resultant shareability attribute + * of outer shareable, otherwise shareability is UNPREDICTABLE. + * + * On ARMv8 sharability is ignored and explicitly treated as outer + * shareable for normal inner non-cacheable, outer non-cacheable. + */ + prbar.reg.sh = LPAE_SH_OUTER; + break; + case MT_DEVICE_nGnRnE: + case MT_DEVICE_nGnRE: + /* + * Shareability is ignored for non-normal memory, Outer is as + * good as anything. + * + * On ARMv8 sharability is ignored and explicitly treated as outer + * shareable for any device memory type. + */ + prbar.reg.sh = LPAE_SH_OUTER; + break; + default: + /* Xen mappings are SMP coherent */ + prbar.reg.sh = LPAE_SH_INNER; + break; + } + + /* Build up value for PRLAR_EL2. */ + prlar = (prlar_t) { + .reg = { + .ns = 0, /* Hyp mode is in secure world */ + .ai = attr, + .en = 1, /* Region enabled */ + }}; + + /* Build up MPU memory region. */ + region = (pr_t) { + .prbar = prbar, + .prlar = prlar, + }; + + /* Set base address and limit address. */ + pr_set_base(®ion, base); + pr_set_limit(®ion, limit); + + return region; +} + +#define MPUMAP_REGION_FAILED 0 +#define MPUMAP_REGION_FOUND 1 +#define MPUMAP_REGION_INCLUSIVE 2 +#define MPUMAP_REGION_OVERLAP 3 + +/* + * Check whether memory range [base, limit] is mapped in MPU memory + * region table \mpu. Only address range is considered, memory attributes + * and permission are not considered here. + * If we find the match, the associated index will be filled up. + * If the entry is not present, INVALID_REGION will be set in \index + * + * Make sure that parameter \base and \limit are both referring + * inclusive addresss + * + * Return values: + * MPUMAP_REGION_FAILED: no mapping and no overmapping + * MPUMAP_REGION_FOUND: find an exact match in address + * MPUMAP_REGION_INCLUSIVE: find an inclusive match in address + * MPUMAP_REGION_OVERLAP: overlap with the existing mapping + */ +static int mpumap_contain_region(pr_t *mpu, uint64_t nr_regions, + paddr_t base, paddr_t limit, uint64_t *index) +{ + uint64_t i = 0; + uint64_t _index = INVALID_REGION; + + /* Allow index to be NULL */ + index = index ?: &_index; + + for ( ; i < nr_regions; i++ ) + { + paddr_t iter_base = pr_get_base(&mpu[i]); + paddr_t iter_limit = pr_get_limit(&mpu[i]); + + /* Found an exact valid match */ + if ( (iter_base == base) && (iter_limit == limit) && + region_is_valid(&mpu[i]) ) + { + *index = i; + return MPUMAP_REGION_FOUND; + } + + /* No overlapping */ + if ( (iter_limit < base) || (iter_base > limit) ) + continue; + /* Inclusive and valid */ + else if ( (base >= iter_base) && (limit <= iter_limit) && + region_is_valid(&mpu[i]) ) + { + *index = i; + return MPUMAP_REGION_INCLUSIVE; + } + else + { + region_printk("Range 0x%"PRIpaddr" - 0x%"PRIpaddr" overlaps with the existing region 0x%"PRIpaddr" - 0x%"PRIpaddr"\n", + base, limit, iter_base, iter_limit); + return MPUMAP_REGION_OVERLAP; + } + } + + return MPUMAP_REGION_FAILED; +} + +/* + * Update an entry at the index @idx. + * @base: base address + * @limit: limit address(exclusive) + * @flags: region attributes, should be the combination of REGION_HYPERVISOR_xx + */ +static int xen_mpumap_update_entry(paddr_t base, paddr_t limit, + unsigned int flags) +{ + uint64_t idx; + int rc; + + rc = mpumap_contain_region(xen_mpumap, max_xen_mpumap, base, limit - 1, + &idx); + if ( rc == MPUMAP_REGION_OVERLAP ) + return -EINVAL; + + /* We are inserting a mapping => Create new region. */ + if ( flags & _REGION_PRESENT ) + { + if ( rc != MPUMAP_REGION_FAILED ) + return -EINVAL; + + if ( xen_boot_mpu_regions_is_full() ) + { + region_printk("There is no room left in EL2 MPU memory region mapping\n"); + return -ENOMEM; + } + + /* During boot time, the default index is next_fixed_region_idx. */ + if ( system_state <= SYS_STATE_active ) + idx = next_fixed_region_idx; + + xen_mpumap[idx] = pr_of_xenaddr(base, limit - 1, REGION_AI_MASK(flags)); + /* Set permission */ + xen_mpumap[idx].prbar.reg.ap = REGION_AP_MASK(flags); + xen_mpumap[idx].prbar.reg.xn = REGION_XN_MASK(flags); + + /* Update and enable the region */ + access_protection_region(false, NULL, (const pr_t*)(&xen_mpumap[idx]), + idx); + + if ( system_state <= SYS_STATE_active ) + update_boot_xen_mpumap_idx(idx); + } + + return 0; +} + +static int xen_mpumap_update(paddr_t base, paddr_t limit, unsigned int flags) +{ + int rc; + + /* + * The hardware was configured to forbid mapping both writeable and + * executable. + * When modifying/creating mapping (i.e _REGION_PRESENT is set), + * prevent any update if this happen. + */ + if ( (flags & _REGION_PRESENT) && !REGION_RO_MASK(flags) && + !REGION_XN_MASK(flags) ) + { + region_printk("Mappings should not be both Writeable and Executable.\n"); + return -EINVAL; + } + + if ( !IS_ALIGNED(base, PAGE_SIZE) || !IS_ALIGNED(limit, PAGE_SIZE) ) + { + region_printk("base address 0x%"PRIpaddr", or limit address 0x%"PRIpaddr" is not page aligned.\n", + base, limit); + return -EINVAL; + } + + spin_lock(&xen_mpumap_lock); + + rc = xen_mpumap_update_entry(base, limit, flags); + + spin_unlock(&xen_mpumap_lock); + + return rc; +} + +int map_pages_to_xen(unsigned long virt, + mfn_t mfn, + unsigned long nr_mfns, + unsigned int flags) +{ + ASSERT(virt == mfn_to_maddr(mfn)); + + return xen_mpumap_update(mfn_to_maddr(mfn), + mfn_to_maddr(mfn_add(mfn, nr_mfns)), flags); +} + /* TODO: Implementation on the first usage */ void dump_hyp_walk(vaddr_t addr) { @@ -230,14 +498,6 @@ void *ioremap(paddr_t pa, size_t len) return NULL; } -int map_pages_to_xen(unsigned long virt, - mfn_t mfn, - unsigned long nr_mfns, - unsigned int flags) -{ - return -ENOSYS; -} - int destroy_xen_mappings(unsigned long s, unsigned long e) { return -ENOSYS; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 13 05:35:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 05:35:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476583.738936 (Exim 4.92) (envelope-from ) id 1pGCjI-00012a-TB; Fri, 13 Jan 2023 05:35:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476583.738936; Fri, 13 Jan 2023 05:35:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCjI-00011m-Mm; Fri, 13 Jan 2023 05:35:52 +0000 Received: by outflank-mailman (input) for mailman id 476583; Fri, 13 Jan 2023 05:35:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCdo-0005sP-8g for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 05:30:12 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 5795f1c1-9303-11ed-b8d0-410ff93cb8f0; Fri, 13 Jan 2023 06:30:08 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1F580FEC; Thu, 12 Jan 2023 21:30:50 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id DF3163F587; Thu, 12 Jan 2023 21:30:05 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5795f1c1-9303-11ed-b8d0-410ff93cb8f0 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v2 10/40] xen/arm: split MMU and MPU config files from config.h Date: Fri, 13 Jan 2023 13:28:43 +0800 Message-Id: <20230113052914.3845596-11-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230113052914.3845596-1-Penny.Zheng@arm.com> References: <20230113052914.3845596-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Wei Chen Xen defines some global configuration macros for Arm in config.h. We still want to use it for Armv8-R systems, but there are some address related macros that are defined for MMU systems. These macros will not be used by MPU systems, Adding ifdefery with CONFIG_HAS_MPU to gate these macros will result in a messy and hard-to-read/maintain code. So we keep some common definitions still in config.h, but move virtual address related definitions to a new file - config_mmu.h. And use a new file config_mpu.h to store definitions for MPU systems. To avoid spreading #ifdef everywhere, we keep the same definition names for MPU systems, like XEN_VIRT_START and HYPERVISOR_VIRT_START, but the definition contents are MPU specific. Signed-off-by: Wei Chen --- v1 -> v2: 1. Remove duplicated FIXMAP definitions from config_mmu.h --- xen/arch/arm/include/asm/config.h | 103 +++-------------------- xen/arch/arm/include/asm/config_mmu.h | 112 ++++++++++++++++++++++++++ xen/arch/arm/include/asm/config_mpu.h | 25 ++++++ 3 files changed, 147 insertions(+), 93 deletions(-) create mode 100644 xen/arch/arm/include/asm/config_mmu.h create mode 100644 xen/arch/arm/include/asm/config_mpu.h diff --git a/xen/arch/arm/include/asm/config.h b/xen/arch/arm/include/asm/config.h index 25a625ff08..86d8142959 100644 --- a/xen/arch/arm/include/asm/config.h +++ b/xen/arch/arm/include/asm/config.h @@ -48,6 +48,12 @@ #define INVALID_VCPU_ID MAX_VIRT_CPUS +/* Used for calculating PDX */ +#ifdef CONFIG_ARM_64 +#define FRAMETABLE_SIZE GB(32) +#define FRAMETABLE_NR (FRAMETABLE_SIZE / sizeof(*frame_table)) +#endif + #define __LINUX_ARM_ARCH__ 7 #define CONFIG_AEABI @@ -71,99 +77,10 @@ #include #include -/* - * Common ARM32 and ARM64 layout: - * 0 - 2M Unmapped - * 2M - 4M Xen text, data, bss - * 4M - 6M Fixmap: special-purpose 4K mapping slots - * 6M - 10M Early boot mapping of FDT - * 10M - 12M Livepatch vmap (if compiled in) - * - * ARM32 layout: - * 0 - 12M - * - * 32M - 128M Frametable: 24 bytes per page for 16GB of RAM - * 256M - 1G VMAP: ioremap and early_ioremap use this virtual address - * space - * - * 1G - 2G Xenheap: always-mapped memory - * 2G - 4G Domheap: on-demand-mapped - * - * ARM64 layout: - * 0x0000000000000000 - 0x0000007fffffffff (512GB, L0 slot [0]) - * 0 - 12M - * - * 1G - 2G VMAP: ioremap and early_ioremap - * - * 32G - 64G Frametable: 24 bytes per page for 5.3TB of RAM - * - * 0x0000008000000000 - 0x00007fffffffffff (127.5TB, L0 slots [1..255]) - * Unused - * - * 0x0000800000000000 - 0x000084ffffffffff (5TB, L0 slots [256..265]) - * 1:1 mapping of RAM - * - * 0x0000850000000000 - 0x0000ffffffffffff (123TB, L0 slots [266..511]) - * Unused - */ - -#define XEN_VIRT_START _AT(vaddr_t,0x00200000) -#define FIXMAP_ADDR(n) (_AT(vaddr_t,0x00400000) + (n) * PAGE_SIZE) - -#define BOOT_FDT_VIRT_START _AT(vaddr_t,0x00600000) -#define BOOT_FDT_VIRT_SIZE _AT(vaddr_t, MB(4)) - -#ifdef CONFIG_LIVEPATCH -#define LIVEPATCH_VMAP_START _AT(vaddr_t,0x00a00000) -#define LIVEPATCH_VMAP_SIZE _AT(vaddr_t, MB(2)) -#endif - -#define HYPERVISOR_VIRT_START XEN_VIRT_START - -#ifdef CONFIG_ARM_32 - -#define CONFIG_SEPARATE_XENHEAP 1 - -#define FRAMETABLE_VIRT_START _AT(vaddr_t,0x02000000) -#define FRAMETABLE_SIZE MB(128-32) -#define FRAMETABLE_NR (FRAMETABLE_SIZE / sizeof(*frame_table)) -#define FRAMETABLE_VIRT_END (FRAMETABLE_VIRT_START + FRAMETABLE_SIZE - 1) - -#define VMAP_VIRT_START _AT(vaddr_t,0x10000000) -#define VMAP_VIRT_SIZE _AT(vaddr_t, GB(1) - MB(256)) - -#define XENHEAP_VIRT_START _AT(vaddr_t,0x40000000) -#define XENHEAP_VIRT_SIZE _AT(vaddr_t, GB(1)) - -#define DOMHEAP_VIRT_START _AT(vaddr_t,0x80000000) -#define DOMHEAP_VIRT_SIZE _AT(vaddr_t, GB(2)) - -#define DOMHEAP_ENTRIES 1024 /* 1024 2MB mapping slots */ - -/* Number of domheap pagetable pages required at the second level (2MB mappings) */ -#define DOMHEAP_SECOND_PAGES (DOMHEAP_VIRT_SIZE >> FIRST_SHIFT) - -#else /* ARM_64 */ - -#define SLOT0_ENTRY_BITS 39 -#define SLOT0(slot) (_AT(vaddr_t,slot) << SLOT0_ENTRY_BITS) -#define SLOT0_ENTRY_SIZE SLOT0(1) - -#define VMAP_VIRT_START GB(1) -#define VMAP_VIRT_SIZE GB(1) - -#define FRAMETABLE_VIRT_START GB(32) -#define FRAMETABLE_SIZE GB(32) -#define FRAMETABLE_NR (FRAMETABLE_SIZE / sizeof(*frame_table)) - -#define DIRECTMAP_VIRT_START SLOT0(256) -#define DIRECTMAP_SIZE (SLOT0_ENTRY_SIZE * (265-256)) -#define DIRECTMAP_VIRT_END (DIRECTMAP_VIRT_START + DIRECTMAP_SIZE - 1) - -#define XENHEAP_VIRT_START directmap_virt_start - -#define HYPERVISOR_VIRT_END DIRECTMAP_VIRT_END - +#ifdef CONFIG_HAS_MPU +#include +#else +#include #endif #define NR_hypercalls 64 diff --git a/xen/arch/arm/include/asm/config_mmu.h b/xen/arch/arm/include/asm/config_mmu.h new file mode 100644 index 0000000000..c12ff25cf4 --- /dev/null +++ b/xen/arch/arm/include/asm/config_mmu.h @@ -0,0 +1,112 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/****************************************************************************** + * config_mmu.h + * + * A Linux-style configuration list, only can be included by config.h + */ + +#ifndef __ARM_CONFIG_MMU_H__ +#define __ARM_CONFIG_MMU_H__ + +/* + * Common ARM32 and ARM64 layout: + * 0 - 2M Unmapped + * 2M - 4M Xen text, data, bss + * 4M - 6M Fixmap: special-purpose 4K mapping slots + * 6M - 10M Early boot mapping of FDT + * 10M - 12M Livepatch vmap (if compiled in) + * + * ARM32 layout: + * 0 - 12M + * + * 32M - 128M Frametable: 24 bytes per page for 16GB of RAM + * 256M - 1G VMAP: ioremap and early_ioremap use this virtual address + * space + * + * 1G - 2G Xenheap: always-mapped memory + * 2G - 4G Domheap: on-demand-mapped + * + * ARM64 layout: + * 0x0000000000000000 - 0x0000007fffffffff (512GB, L0 slot [0]) + * 0 - 12M + * + * 1G - 2G VMAP: ioremap and early_ioremap + * + * 32G - 64G Frametable: 24 bytes per page for 5.3TB of RAM + * + * 0x0000008000000000 - 0x00007fffffffffff (127.5TB, L0 slots [1..255]) + * Unused + * + * 0x0000800000000000 - 0x000084ffffffffff (5TB, L0 slots [256..265]) + * 1:1 mapping of RAM + * + * 0x0000850000000000 - 0x0000ffffffffffff (123TB, L0 slots [266..511]) + * Unused + */ + +#define XEN_VIRT_START _AT(vaddr_t,0x00200000) +#define FIXMAP_ADDR(n) (_AT(vaddr_t,0x00400000) + (n) * PAGE_SIZE) + +#define BOOT_FDT_VIRT_START _AT(vaddr_t,0x00600000) +#define BOOT_FDT_VIRT_SIZE _AT(vaddr_t, MB(4)) + +#ifdef CONFIG_LIVEPATCH +#define LIVEPATCH_VMAP_START _AT(vaddr_t,0x00a00000) +#define LIVEPATCH_VMAP_SIZE _AT(vaddr_t, MB(2)) +#endif + +#define HYPERVISOR_VIRT_START XEN_VIRT_START + +#ifdef CONFIG_ARM_32 + +#define CONFIG_SEPARATE_XENHEAP 1 + +#define FRAMETABLE_VIRT_START _AT(vaddr_t,0x02000000) +#define FRAMETABLE_SIZE MB(128-32) +#define FRAMETABLE_NR (FRAMETABLE_SIZE / sizeof(*frame_table)) +#define FRAMETABLE_VIRT_END (FRAMETABLE_VIRT_START + FRAMETABLE_SIZE - 1) + +#define VMAP_VIRT_START _AT(vaddr_t,0x10000000) +#define VMAP_VIRT_SIZE _AT(vaddr_t, GB(1) - MB(256)) + +#define XENHEAP_VIRT_START _AT(vaddr_t,0x40000000) +#define XENHEAP_VIRT_SIZE _AT(vaddr_t, GB(1)) + +#define DOMHEAP_VIRT_START _AT(vaddr_t,0x80000000) +#define DOMHEAP_VIRT_SIZE _AT(vaddr_t, GB(2)) + +#define DOMHEAP_ENTRIES 1024 /* 1024 2MB mapping slots */ + +/* Number of domheap pagetable pages required at the second level (2MB mappings) */ +#define DOMHEAP_SECOND_PAGES (DOMHEAP_VIRT_SIZE >> FIRST_SHIFT) + +#else /* ARM_64 */ + +#define SLOT0_ENTRY_BITS 39 +#define SLOT0(slot) (_AT(vaddr_t,slot) << SLOT0_ENTRY_BITS) +#define SLOT0_ENTRY_SIZE SLOT0(1) + +#define VMAP_VIRT_START GB(1) +#define VMAP_VIRT_SIZE GB(1) + +#define FRAMETABLE_VIRT_START GB(32) + +#define DIRECTMAP_VIRT_START SLOT0(256) +#define DIRECTMAP_SIZE (SLOT0_ENTRY_SIZE * (265-256)) +#define DIRECTMAP_VIRT_END (DIRECTMAP_VIRT_START + DIRECTMAP_SIZE - 1) + +#define XENHEAP_VIRT_START directmap_virt_start + +#define HYPERVISOR_VIRT_END DIRECTMAP_VIRT_END + +#endif + +#endif /* __ARM_CONFIG_MMU_H__ */ +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/arm/include/asm/config_mpu.h b/xen/arch/arm/include/asm/config_mpu.h new file mode 100644 index 0000000000..6b52b11ef7 --- /dev/null +++ b/xen/arch/arm/include/asm/config_mpu.h @@ -0,0 +1,25 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * config_mpu.h: A Linux-style configuration list for Arm MPU systems, + * only can be included by config.h + */ + +#ifndef __ARM_CONFIG_MPU_H__ +#define __ARM_CONFIG_MPU_H__ + +#define XEN_START_ADDRESS CONFIG_XEN_START_ADDRESS + +/* + * All MPU platforms need to provide a XEN_START_ADDRESS for linker. This + * address indicates where Xen image will be loaded and run from. This + * address must be aligned to a PAGE_SIZE. + */ +#if (XEN_START_ADDRESS % PAGE_SIZE) != 0 +#error "XEN_START_ADDRESS must be aligned to PAGE_SIZE" +#endif + +#define XEN_VIRT_START _AT(paddr_t, XEN_START_ADDRESS) + +#define HYPERVISOR_VIRT_START XEN_VIRT_START + +#endif /* __ARM_CONFIG_MPU_H__ */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 13 05:35:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 05:35:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476586.738946 (Exim 4.92) (envelope-from ) id 1pGCjK-0001Lw-4C; Fri, 13 Jan 2023 05:35:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476586.738946; Fri, 13 Jan 2023 05:35:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCjK-0001L5-0a; Fri, 13 Jan 2023 05:35:54 +0000 Received: by outflank-mailman (input) for mailman id 476586; Fri, 13 Jan 2023 05:35:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCdw-0005sP-Sc for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 05:30:21 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 5d0f1015-9303-11ed-b8d0-410ff93cb8f0; Fri, 13 Jan 2023 06:30:17 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2E44AFEC; Thu, 12 Jan 2023 21:30:59 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 705B83F587; Thu, 12 Jan 2023 21:30:14 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5d0f1015-9303-11ed-b8d0-410ff93cb8f0 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v2 13/40] xen/mpu: introduce unified function setup_early_uart to map early UART Date: Fri, 13 Jan 2023 13:28:46 +0800 Message-Id: <20230113052914.3845596-14-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230113052914.3845596-1-Penny.Zheng@arm.com> References: <20230113052914.3845596-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In MMU system, we map the UART in the fixmap (when earlyprintk is used). However in MPU system, we map the UART with a transient MPU memory region. So we introduce a new unified function setup_early_uart to replace the previous setup_fixmap. Signed-off-by: Penny Zheng Signed-off-by: Wei Chen --- xen/arch/arm/arm64/head.S | 2 +- xen/arch/arm/arm64/head_mmu.S | 4 +- xen/arch/arm/arm64/head_mpu.S | 52 +++++++++++++++++++++++++ xen/arch/arm/include/asm/early_printk.h | 1 + 4 files changed, 56 insertions(+), 3 deletions(-) diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S index 7f3f973468..a92883319d 100644 --- a/xen/arch/arm/arm64/head.S +++ b/xen/arch/arm/arm64/head.S @@ -272,7 +272,7 @@ primary_switched: * afterwards. */ bl remove_identity_mapping - bl setup_fixmap + bl setup_early_uart #ifdef CONFIG_EARLY_PRINTK /* Use a virtual address to access the UART. */ ldr x23, =EARLY_UART_VIRTUAL_ADDRESS diff --git a/xen/arch/arm/arm64/head_mmu.S b/xen/arch/arm/arm64/head_mmu.S index b59c40495f..a19b7c873d 100644 --- a/xen/arch/arm/arm64/head_mmu.S +++ b/xen/arch/arm/arm64/head_mmu.S @@ -312,7 +312,7 @@ ENDPROC(remove_identity_mapping) * * Clobbers x0 - x3 */ -ENTRY(setup_fixmap) +ENTRY(setup_early_uart) #ifdef CONFIG_EARLY_PRINTK /* Add UART to the fixmap table */ ldr x0, =EARLY_UART_VIRTUAL_ADDRESS @@ -325,7 +325,7 @@ ENTRY(setup_fixmap) dsb nshst ret -ENDPROC(setup_fixmap) +ENDPROC(setup_early_uart) /* Fail-stop */ fail: PRINT("- Boot failed -\r\n") diff --git a/xen/arch/arm/arm64/head_mpu.S b/xen/arch/arm/arm64/head_mpu.S index e2ac69b0cc..72d1e0863d 100644 --- a/xen/arch/arm/arm64/head_mpu.S +++ b/xen/arch/arm/arm64/head_mpu.S @@ -18,8 +18,10 @@ #define REGION_TEXT_PRBAR 0x38 /* SH=11 AP=10 XN=00 */ #define REGION_RO_PRBAR 0x3A /* SH=11 AP=10 XN=10 */ #define REGION_DATA_PRBAR 0x32 /* SH=11 AP=00 XN=10 */ +#define REGION_DEVICE_PRBAR 0x22 /* SH=10 AP=00 XN=10 */ #define REGION_NORMAL_PRLAR 0x0f /* NS=0 ATTR=111 EN=1 */ +#define REGION_DEVICE_PRLAR 0x09 /* NS=0 ATTR=100 EN=1 */ /* * Macro to round up the section address to be PAGE_SIZE aligned @@ -334,6 +336,56 @@ ENTRY(enable_mm) ret ENDPROC(enable_mm) +/* + * Map the early UART with a new transient MPU memory region. + * + * x27: region selector + * x28: prbar + * x29: prlar + * + * Clobbers x0 - x4 + * + */ +ENTRY(setup_early_uart) +#ifdef CONFIG_EARLY_PRINTK + /* stack LR as write_pr will be called later like nested function */ + mov x3, lr + + /* + * MPU region for early UART is a transient region, since it will be + * replaced by specific device memory layout when FDT gets parsed. + */ + load_paddr x0, next_transient_region_idx + ldr x4, [x0] + + ldr x28, =CONFIG_EARLY_UART_BASE_ADDRESS + and x28, x28, #MPU_REGION_MASK + mov x1, #REGION_DEVICE_PRBAR + orr x28, x28, x1 + + ldr x29, =(CONFIG_EARLY_UART_BASE_ADDRESS + EARLY_UART_SIZE) + roundup_section x29 + /* Limit address is inclusive */ + sub x29, x29, #1 + and x29, x29, #MPU_REGION_MASK + mov x2, #REGION_DEVICE_PRLAR + orr x29, x29, x2 + + mov x27, x4 + bl write_pr + + /* Create a new entry in xen_mpumap for early UART */ + create_mpu_entry xen_mpumap, x4, x28, x29, x1, x2 + + /* Update next_transient_region_idx */ + sub x4, x4, #1 + str x4, [x0] + + mov lr, x3 + ret +#endif +ENDPROC(setup_early_uart) + /* * Local variables: * mode: ASM diff --git a/xen/arch/arm/include/asm/early_printk.h b/xen/arch/arm/include/asm/early_printk.h index 44a230853f..d87623e6d5 100644 --- a/xen/arch/arm/include/asm/early_printk.h +++ b/xen/arch/arm/include/asm/early_printk.h @@ -22,6 +22,7 @@ * for EARLY_UART_VIRTUAL_ADDRESS. */ #define EARLY_UART_VIRTUAL_ADDRESS CONFIG_EARLY_UART_BASE_ADDRESS +#define EARLY_UART_SIZE 0x1000 #else -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 13 05:35:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 05:35:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476589.738958 (Exim 4.92) (envelope-from ) id 1pGCjM-0001nx-IH; Fri, 13 Jan 2023 05:35:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476589.738958; Fri, 13 Jan 2023 05:35:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCjM-0001nk-CM; Fri, 13 Jan 2023 05:35:56 +0000 Received: by outflank-mailman (input) for mailman id 476589; Fri, 13 Jan 2023 05:35:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCf2-0005sP-AO for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 05:31:28 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 85e3d938-9303-11ed-b8d0-410ff93cb8f0; Fri, 13 Jan 2023 06:31:26 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CE16FFEC; Thu, 12 Jan 2023 21:32:07 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 1BACD3F587; Thu, 12 Jan 2023 21:31:22 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 85e3d938-9303-11ed-b8d0-410ff93cb8f0 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v2 34/40] xen/mpu: free init memory in MPU system Date: Fri, 13 Jan 2023 13:29:07 +0800 Message-Id: <20230113052914.3845596-35-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230113052914.3845596-1-Penny.Zheng@arm.com> References: <20230113052914.3845596-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This commit implements free_init_memory in MPU system, trying to keep the same strategy with MMU system. In order to inserting BRK instruction into init code section, which aims to provok a fault on purpose, we should change init code section permission to RW at first. Function modify_xen_mappings is introduced to modify permission of the existing valid MPU memory region. Then we nuke the instruction cache to remove entries related to init text. At last, we destroy these two MPU memory regions referring init text and init data using destroy_xen_mappings. Signed-off-by: Penny Zheng Signed-off-by: Wei Chen --- xen/arch/arm/mm_mpu.c | 85 ++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 83 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm/mm_mpu.c b/xen/arch/arm/mm_mpu.c index 0b720004ee..de0c7d919a 100644 --- a/xen/arch/arm/mm_mpu.c +++ b/xen/arch/arm/mm_mpu.c @@ -20,6 +20,7 @@ */ #include +#include #include #include #include @@ -77,6 +78,8 @@ static const unsigned int mpu_section_mattr[MSINFO_MAX] = { REGION_HYPERVISOR_BOOT, }; +extern char __init_data_begin[], __init_end[]; + /* Write a MPU protection region */ #define WRITE_PROTECTION_REGION(sel, pr, prbar_el2, prlar_el2) ({ \ uint64_t _sel = sel; \ @@ -443,8 +446,41 @@ static int xen_mpumap_update_entry(paddr_t base, paddr_t limit, if ( rc == MPUMAP_REGION_OVERLAP ) return -EINVAL; + /* We are updating the permission. */ + if ( (flags & _REGION_PRESENT) && (rc == MPUMAP_REGION_FOUND || + rc == MPUMAP_REGION_INCLUSIVE) ) + { + + /* + * Currently, we only support modifying a *WHOLE* MPU memory region, + * part-region modification is not supported, as in worst case, it will + * lead to three fragments in result after modification. + * part-region modification will be introduced only when actual usage + * come + */ + if ( rc == MPUMAP_REGION_INCLUSIVE ) + { + region_printk("mpu: part-region modification is not supported\n"); + return -EINVAL; + } + + /* We don't allow changing memory attributes. */ + if (xen_mpumap[idx].prlar.reg.ai != REGION_AI_MASK(flags) ) + { + region_printk("Modifying memory attributes is not allowed (0x%x -> 0x%x).\n", + xen_mpumap[idx].prlar.reg.ai, REGION_AI_MASK(flags)); + return -EINVAL; + } + + /* Set new permission */ + xen_mpumap[idx].prbar.reg.ap = REGION_AP_MASK(flags); + xen_mpumap[idx].prbar.reg.xn = REGION_XN_MASK(flags); + + access_protection_region(false, NULL, (const pr_t*)(&xen_mpumap[idx]), + idx); + } /* We are inserting a mapping => Create new region. */ - if ( flags & _REGION_PRESENT ) + else if ( flags & _REGION_PRESENT ) { if ( rc != MPUMAP_REGION_FAILED ) return -EINVAL; @@ -831,11 +867,56 @@ void mmu_init_secondary_cpu(void) int modify_xen_mappings(unsigned long s, unsigned long e, unsigned int flags) { - return -ENOSYS; + ASSERT(IS_ALIGNED(s, PAGE_SIZE)); + ASSERT(IS_ALIGNED(e, PAGE_SIZE)); + ASSERT(s <= e); + return xen_mpumap_update(s, e, flags); } void free_init_memory(void) { + /* Kernel init text section. */ + paddr_t init_text = virt_to_maddr(_sinittext); + paddr_t init_text_end = round_pgup(virt_to_maddr(_einittext)); + /* Kernel init data. */ + paddr_t init_data = virt_to_maddr(__init_data_begin); + paddr_t init_data_end = round_pgup(virt_to_maddr(__init_end)); + unsigned long init_section[4] = {(unsigned long)init_text, + (unsigned long)init_text_end, + (unsigned long)init_data, + (unsigned long)init_data_end}; + unsigned int nr_init = 2; + uint32_t insn = AARCH64_BREAK_FAULT; + unsigned int i = 0, j = 0; + + /* Change kernel init text section to RW. */ + modify_xen_mappings((unsigned long)init_text, + (unsigned long)init_text_end, REGION_HYPERVISOR_RW); + + /* + * From now on, init will not be used for execution anymore, + * so nuke the instruction cache to remove entries related to init. + */ + invalidate_icache_local(); + + /* Destroy two MPU memory regions referring init text and init data. */ + for ( ; i < nr_init; i++ ) + { + uint32_t *p; + unsigned int nr; + int rc; + + i = 2 * i; + p = (uint32_t *)init_section[i]; + nr = (init_section[i + 1] - init_section[i]) / sizeof(uint32_t); + + for ( ; j < nr ; j++ ) + *(p + j) = insn; + + rc = destroy_xen_mappings(init_section[i], init_section[i + 1]); + if ( rc < 0 ) + panic("Unable to remove the init section (rc = %d)\n", rc); + } } int xenmem_add_to_physmap_one( -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 13 05:36:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 05:36:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476601.738969 (Exim 4.92) (envelope-from ) id 1pGCjW-0002wE-TN; Fri, 13 Jan 2023 05:36:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476601.738969; Fri, 13 Jan 2023 05:36:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCjW-0002w3-Ny; Fri, 13 Jan 2023 05:36:06 +0000 Received: by outflank-mailman (input) for mailman id 476601; Fri, 13 Jan 2023 05:36:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCeQ-0005sJ-1W for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 05:30:50 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 6fbbe079-9303-11ed-91b6-6bf2151ebd3b; Fri, 13 Jan 2023 06:30:48 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8DBB513D5; Thu, 12 Jan 2023 21:31:30 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id CFA2A3F587; Thu, 12 Jan 2023 21:30:45 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6fbbe079-9303-11ed-91b6-6bf2151ebd3b From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v2 23/40] xen/mpu: initialize frametable in MPU system Date: Fri, 13 Jan 2023 13:28:56 +0800 Message-Id: <20230113052914.3845596-24-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230113052914.3845596-1-Penny.Zheng@arm.com> References: <20230113052914.3845596-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Xen is using page as the smallest granularity for memory managment. And we want to follow the same concept in MPU system. That is, structure page_info and the frametable which is used for storing and managing page_info is also required in MPU system. In MPU system, since there is no virtual address translation (VA == PA), we can not use a fixed VA address(FRAMETABLE_VIRT_START) to map frametable like MMU system does. Instead, we define a variable "struct page_info *frame_table" as frametable pointer, and ask boot allocator to allocate memory for frametable. As frametable is successfully initialized, the convertion between machine frame number/machine address/"virtual address" and page-info structure is ready too, like mfn_to_page/maddr_to_page/virt_to_page, etc Signed-off-by: Penny Zheng Signed-off-by: Wei Chen --- xen/arch/arm/include/asm/mm.h | 15 --------------- xen/arch/arm/include/asm/mm_mmu.h | 16 ++++++++++++++++ xen/arch/arm/include/asm/mm_mpu.h | 17 +++++++++++++++++ xen/arch/arm/mm_mpu.c | 25 +++++++++++++++++++++++++ 4 files changed, 58 insertions(+), 15 deletions(-) diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h index e29158028a..7969ec9f98 100644 --- a/xen/arch/arm/include/asm/mm.h +++ b/xen/arch/arm/include/asm/mm.h @@ -176,7 +176,6 @@ struct page_info #define maddr_get_owner(ma) (page_get_owner(maddr_to_page((ma)))) -#define frame_table ((struct page_info *)FRAMETABLE_VIRT_START) /* PDX of the first page in the frame table. */ extern unsigned long frametable_base_pdx; @@ -280,20 +279,6 @@ static inline uint64_t gvirt_to_maddr(vaddr_t va, paddr_t *pa, #define virt_to_mfn(va) __virt_to_mfn(va) #define mfn_to_virt(mfn) __mfn_to_virt(mfn) -/* Convert between Xen-heap virtual addresses and page-info structures. */ -static inline struct page_info *virt_to_page(const void *v) -{ - unsigned long va = (unsigned long)v; - unsigned long pdx; - - ASSERT(va >= XENHEAP_VIRT_START); - ASSERT(va < directmap_virt_end); - - pdx = (va - XENHEAP_VIRT_START) >> PAGE_SHIFT; - pdx += mfn_to_pdx(directmap_mfn_start); - return frame_table + pdx - frametable_base_pdx; -} - static inline void *page_to_virt(const struct page_info *pg) { return mfn_to_virt(mfn_x(page_to_mfn(pg))); diff --git a/xen/arch/arm/include/asm/mm_mmu.h b/xen/arch/arm/include/asm/mm_mmu.h index 6d7e5ddde7..bc1b04c4c7 100644 --- a/xen/arch/arm/include/asm/mm_mmu.h +++ b/xen/arch/arm/include/asm/mm_mmu.h @@ -23,6 +23,8 @@ extern uint64_t init_ttbr; extern void setup_directmap_mappings(unsigned long base_mfn, unsigned long nr_mfns); +#define frame_table ((struct page_info *)FRAMETABLE_VIRT_START) + static inline paddr_t __virt_to_maddr(vaddr_t va) { uint64_t par = va_to_par(va); @@ -49,6 +51,20 @@ static inline void *maddr_to_virt(paddr_t ma) } #endif +/* Convert between Xen-heap virtual addresses and page-info structures. */ +static inline struct page_info *virt_to_page(const void *v) +{ + unsigned long va = (unsigned long)v; + unsigned long pdx; + + ASSERT(va >= XENHEAP_VIRT_START); + ASSERT(va < directmap_virt_end); + + pdx = (va - XENHEAP_VIRT_START) >> PAGE_SHIFT; + pdx += mfn_to_pdx(directmap_mfn_start); + return frame_table + pdx - frametable_base_pdx; +} + #endif /* __ARCH_ARM_MM_MMU__ */ /* diff --git a/xen/arch/arm/include/asm/mm_mpu.h b/xen/arch/arm/include/asm/mm_mpu.h index fe6a828a50..eebd5b5d35 100644 --- a/xen/arch/arm/include/asm/mm_mpu.h +++ b/xen/arch/arm/include/asm/mm_mpu.h @@ -9,6 +9,8 @@ */ extern void setup_static_mappings(void); +extern struct page_info *frame_table; + static inline paddr_t __virt_to_maddr(vaddr_t va) { /* In MPU system, VA == PA. */ @@ -22,6 +24,21 @@ static inline void *maddr_to_virt(paddr_t ma) return (void *)ma; } +/* Convert between virtual address to page-info structure. */ +static inline struct page_info *virt_to_page(const void *v) +{ + unsigned long va = (unsigned long)v; + unsigned long pdx; + + /* + * In MPU system, VA == PA, virt_to_maddr() outputs the + * exact input address. + */ + pdx = mfn_to_pdx(maddr_to_mfn(virt_to_maddr(va))); + + return frame_table + pdx - frametable_base_pdx; +} + #endif /* __ARCH_ARM_MM_MPU__ */ /* diff --git a/xen/arch/arm/mm_mpu.c b/xen/arch/arm/mm_mpu.c index f057ee26df..7b282be4fb 100644 --- a/xen/arch/arm/mm_mpu.c +++ b/xen/arch/arm/mm_mpu.c @@ -69,6 +69,8 @@ static DEFINE_SPINLOCK(xen_mpumap_lock); static paddr_t dtb_paddr; +struct page_info *frame_table; + /* Write a MPU protection region */ #define WRITE_PROTECTION_REGION(sel, pr, prbar_el2, prlar_el2) ({ \ uint64_t _sel = sel; \ @@ -564,6 +566,29 @@ void __init setup_static_mappings(void) /* TODO: guest memory section, device memory section, boot-module section, etc */ } +/* Map a frame table to cover physical addresses ps through pe */ +void __init setup_frametable_mappings(paddr_t ps, paddr_t pe) +{ + mfn_t base_mfn; + unsigned long nr_pdxs = mfn_to_pdx(mfn_add(maddr_to_mfn(pe), -1)) - + mfn_to_pdx(maddr_to_mfn(ps)) + 1; + unsigned long frametable_size = nr_pdxs * sizeof(struct page_info); + + frametable_base_pdx = mfn_to_pdx(maddr_to_mfn(ps)); + frametable_size = ROUNDUP(frametable_size, PAGE_SIZE); + /* + * Since VA == PA in MPU and we've already setup Xenheap mapping + * in setup_staticheap_mappings(), we could easily deduce the + * "virtual address" of frame table. + */ + base_mfn = alloc_boot_pages(frametable_size >> PAGE_SHIFT, 1); + frame_table = (struct page_info*)mfn_to_virt(base_mfn); + + memset(&frame_table[0], 0, nr_pdxs * sizeof(struct page_info)); + memset(&frame_table[nr_pdxs], -1, + frametable_size - (nr_pdxs * sizeof(struct page_info))); +} + /* TODO: Implementation on the first usage */ void dump_hyp_walk(vaddr_t addr) { -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 13 05:36:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 05:36:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476605.738979 (Exim 4.92) (envelope-from ) id 1pGCjZ-0003Nc-Cv; Fri, 13 Jan 2023 05:36:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476605.738979; Fri, 13 Jan 2023 05:36:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCjZ-0003N8-8e; Fri, 13 Jan 2023 05:36:09 +0000 Received: by outflank-mailman (input) for mailman id 476605; Fri, 13 Jan 2023 05:36:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCeZ-0005sJ-DT for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 05:30:59 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 754da6db-9303-11ed-91b6-6bf2151ebd3b; Fri, 13 Jan 2023 06:30:58 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DB5B413D5; Thu, 12 Jan 2023 21:31:39 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 2914E3F587; Thu, 12 Jan 2023 21:30:54 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 754da6db-9303-11ed-91b6-6bf2151ebd3b From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v2 26/40] xen/mpu: destroy an existing entry in Xen MPU memory mapping table Date: Fri, 13 Jan 2023 13:28:59 +0800 Message-Id: <20230113052914.3845596-27-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230113052914.3845596-1-Penny.Zheng@arm.com> References: <20230113052914.3845596-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This commit expands xen_mpumap_update/xen_mpumap_update_entry to include destroying an existing entry. We define a new helper "control_xen_mpumap_region_from_index" to enable/disable the MPU region based on index. If region is within [0, 31], we could quickly disable the MPU region through PRENR_EL2 which provides direct access to the PRLAR_EL2.EN bits of EL2 MPU regions. Signed-off-by: Penny Zheng Signed-off-by: Wei Chen --- xen/arch/arm/include/asm/arm64/mpu.h | 20 ++++++ xen/arch/arm/include/asm/arm64/sysregs.h | 3 + xen/arch/arm/mm_mpu.c | 77 ++++++++++++++++++++++-- 3 files changed, 95 insertions(+), 5 deletions(-) diff --git a/xen/arch/arm/include/asm/arm64/mpu.h b/xen/arch/arm/include/asm/arm64/mpu.h index 0044bbf05d..c1dea1c8e9 100644 --- a/xen/arch/arm/include/asm/arm64/mpu.h +++ b/xen/arch/arm/include/asm/arm64/mpu.h @@ -16,6 +16,8 @@ */ #define ARM_MAX_MPU_MEMORY_REGIONS 255 +#define MPU_PRENR_BITS 32 + /* Access permission attributes. */ /* Read/Write at EL2, No Access at EL1/EL0. */ #define AP_RW_EL2 0x0 @@ -132,6 +134,24 @@ typedef struct { _pr->prlar.reg.en; \ }) +/* + * Access to get base address of MPU protection region(pr_t). + * The base address shall be zero extended. + */ +#define pr_get_base(pr) ({ \ + pr_t *_pr = pr; \ + (uint64_t)_pr->prbar.reg.base << MPU_REGION_SHIFT; \ +}) + +/* + * Access to get limit address of MPU protection region(pr_t). + * The limit address shall be concatenated with 0x3f. + */ +#define pr_get_limit(pr) ({ \ + pr_t *_pr = pr; \ + (uint64_t)((_pr->prlar.reg.limit << MPU_REGION_SHIFT) | 0x3f); \ +}) + #endif /* __ASSEMBLY__ */ #endif /* __ARM64_MPU_H__ */ diff --git a/xen/arch/arm/include/asm/arm64/sysregs.h b/xen/arch/arm/include/asm/arm64/sysregs.h index aca9bca5b1..c46daf6f69 100644 --- a/xen/arch/arm/include/asm/arm64/sysregs.h +++ b/xen/arch/arm/include/asm/arm64/sysregs.h @@ -505,6 +505,9 @@ /* MPU Type registers encode */ #define MPUIR_EL2 S3_4_C0_C0_4 +/* MPU Protection Region Enable Register encode */ +#define PRENR_EL2 S3_4_C6_C1_1 + #endif /* Access to system registers */ diff --git a/xen/arch/arm/mm_mpu.c b/xen/arch/arm/mm_mpu.c index d2e19e836c..3a0d110b13 100644 --- a/xen/arch/arm/mm_mpu.c +++ b/xen/arch/arm/mm_mpu.c @@ -385,6 +385,45 @@ static int mpumap_contain_region(pr_t *mpu, uint64_t nr_regions, return MPUMAP_REGION_FAILED; } +/* Disable or enable EL2 MPU memory region at index #index */ +static void control_mpu_region_from_index(uint64_t index, bool enable) +{ + pr_t region; + + access_protection_region(true, ®ion, NULL, index); + if ( (region_is_valid(®ion) && enable) || + (!region_is_valid(®ion) && !enable) ) + { + printk(XENLOG_WARNING + "mpu: MPU memory region[%lu] is already %s\n", index, + enable ? "enabled" : "disabled"); + return; + } + + /* + * ARM64v8R provides PRENR_EL2 to have direct access to the + * PRLAR_EL2.EN bits of EL2 MPU regions from 0 to 31. + */ + if ( index < MPU_PRENR_BITS ) + { + uint64_t orig, after; + + orig = READ_SYSREG(PRENR_EL2); + if ( enable ) + /* Set respective bit */ + after = orig | (1UL << index); + else + /* Clear respective bit */ + after = orig & (~(1UL << index)); + WRITE_SYSREG(after, PRENR_EL2); + } + else + { + region.prlar.reg.en = enable ? 1 : 0; + access_protection_region(false, NULL, (const pr_t*)®ion, index); + } +} + /* * Update an entry at the index @idx. * @base: base address @@ -449,6 +488,30 @@ static int xen_mpumap_update_entry(paddr_t base, paddr_t limit, if ( system_state <= SYS_STATE_active ) update_boot_xen_mpumap_idx(idx); } + else + { + /* + * Currently, we only support destroying a *WHOLE* MPU memory region, + * part-region removing is not supported, as in worst case, it will + * lead to two fragments in result after destroying. + * part-region removing will be introduced only when actual usage + * comes. + */ + if ( rc == MPUMAP_REGION_INCLUSIVE ) + { + region_printk("mpu: part-region removing is not supported\n"); + return -EINVAL; + } + + /* We are removing the region */ + if ( rc != MPUMAP_REGION_FOUND ) + return -EINVAL; + + control_mpu_region_from_index(idx, false); + + /* Clear the according MPU memory region entry.*/ + memset(&xen_mpumap[idx], 0, sizeof(pr_t)); + } return 0; } @@ -589,6 +652,15 @@ static void __init map_mpu_memory_section_on_boot(enum mpu_section_info type, } } +int destroy_xen_mappings(unsigned long s, unsigned long e) +{ + ASSERT(IS_ALIGNED(s, PAGE_SIZE)); + ASSERT(IS_ALIGNED(e, PAGE_SIZE)); + ASSERT(s <= e); + + return xen_mpumap_update(s, e, 0); +} + /* * System RAM is statically partitioned into different functionality * section in Device Tree, including static xenheap, guest memory @@ -656,11 +728,6 @@ void *ioremap(paddr_t pa, size_t len) return NULL; } -int destroy_xen_mappings(unsigned long s, unsigned long e) -{ - return -ENOSYS; -} - int modify_xen_mappings(unsigned long s, unsigned long e, unsigned int flags) { return -ENOSYS; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 13 05:36:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 05:36:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476606.738986 (Exim 4.92) (envelope-from ) id 1pGCjZ-0003RQ-O8; Fri, 13 Jan 2023 05:36:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476606.738986; Fri, 13 Jan 2023 05:36:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCjZ-0003Qh-He; Fri, 13 Jan 2023 05:36:09 +0000 Received: by outflank-mailman (input) for mailman id 476606; Fri, 13 Jan 2023 05:36:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCe1-0005sJ-HA for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 05:30:25 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 5ee55659-9303-11ed-91b6-6bf2151ebd3b; Fri, 13 Jan 2023 06:30:20 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 48308FEC; Thu, 12 Jan 2023 21:31:02 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 8A0113F587; Thu, 12 Jan 2023 21:30:17 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5ee55659-9303-11ed-91b6-6bf2151ebd3b From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v2 14/40] xen/arm64: head: Jump to the runtime mapping in enable_mm() Date: Fri, 13 Jan 2023 13:28:47 +0800 Message-Id: <20230113052914.3845596-15-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230113052914.3845596-1-Penny.Zheng@arm.com> References: <20230113052914.3845596-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit At the moment, on MMU system, enable_mm() will return to an address in the 1:1 mapping, then each path is responsible to switch to virtual runtime mapping. Then remove_identity_mapping() is called to remove all 1:1 mapping. Since remove_identity_mapping() is not necessary on MPU system, and we also avoid creating empty function for MPU system, trying to keep only one codeflow in arm64/head.S, we move path switch and remove_identity_mapping() in enable_mm() on MMU system. Signed-off-by: Penny Zheng Signed-off-by: Wei Chen --- xen/arch/arm/arm64/head.S | 28 +++++++++++++--------------- xen/arch/arm/arm64/head_mmu.S | 33 ++++++++++++++++++++++++++++++--- 2 files changed, 43 insertions(+), 18 deletions(-) diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S index a92883319d..6358305f03 100644 --- a/xen/arch/arm/arm64/head.S +++ b/xen/arch/arm/arm64/head.S @@ -258,20 +258,15 @@ real_start_efi: * and memory regions for MPU systems. */ bl prepare_early_mappings + /* + * Address in the runtime mapping to jump to after the + * MMU/MPU is enabled + */ + ldr lr, =primary_switched /* Turn on MMU or MPU */ - bl enable_mm + b enable_mm - /* We are still in the 1:1 mapping. Jump to the runtime Virtual Address. */ - ldr x0, =primary_switched - br x0 primary_switched: - /* - * The 1:1 map may clash with other parts of the Xen virtual memory - * layout. As it is not used anymore, remove it completely to - * avoid having to worry about replacing existing mapping - * afterwards. - */ - bl remove_identity_mapping bl setup_early_uart #ifdef CONFIG_EARLY_PRINTK /* Use a virtual address to access the UART. */ @@ -317,11 +312,14 @@ GLOBAL(init_secondary) bl check_cpu_mode bl cpu_init bl prepare_early_mappings - bl enable_mm - /* We are still in the 1:1 mapping. Jump to the runtime Virtual Address. */ - ldr x0, =secondary_switched - br x0 + /* + * Address in the runtime mapping to jump to after the + * MMU/MPU is enabled + */ + ldr lr, =secondary_switched + b enable_mm + secondary_switched: /* * Non-boot CPUs need to move on to the proper pagetables, which were diff --git a/xen/arch/arm/arm64/head_mmu.S b/xen/arch/arm/arm64/head_mmu.S index a19b7c873d..c9e83bbe2d 100644 --- a/xen/arch/arm/arm64/head_mmu.S +++ b/xen/arch/arm/arm64/head_mmu.S @@ -211,9 +211,11 @@ virtphys_clash: ENDPROC(prepare_early_mappings) /* - * Turn on the Data Cache and the MMU. The function will return on the 1:1 - * mapping. In other word, the caller is responsible to switch to the runtime - * mapping. + * Turn on the Data Cache and the MMU. The function will return + * to the virtual address provided in LR (e.g. the runtime mapping). + * + * Inputs: + * lr(x30): Virtual address to return to * * Clobbers x0 - x3 */ @@ -238,6 +240,31 @@ ENTRY(enable_mm) dsb sy /* Flush PTE writes and finish reads */ msr SCTLR_EL2, x0 /* now paging is enabled */ isb /* Now, flush the icache */ + + /* + * The MMU is turned on and we are in the 1:1 mapping. Switch + * to the runtime mapping. + */ + ldr x0, =1f + br x0 +1: + /* + * The 1:1 map may clash with other parts of the Xen virtual memory + * layout. As it is not used anymore, remove it completely to + * avoid having to worry about replacing existing mapping + * afterwards. + * + * On return this will jump to the virtual address requested by + * the caller + */ + b remove_identity_mapping + + /* + * Here might not be reached, as "ret" in remove_identity_mapping + * will use the return address in LR in advance. But keep ret here + * might be more safe if "ret" in remove_identity_mapping is removed + * in future. + */ ret ENDPROC(enable_mm) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 13 05:36:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 05:36:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476608.739002 (Exim 4.92) (envelope-from ) id 1pGCjc-00047g-6P; Fri, 13 Jan 2023 05:36:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476608.739002; Fri, 13 Jan 2023 05:36:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCjc-00047Q-0Z; Fri, 13 Jan 2023 05:36:12 +0000 Received: by outflank-mailman (input) for mailman id 476608; Fri, 13 Jan 2023 05:36:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCeC-0005sP-4U for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 05:30:36 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 66628c11-9303-11ed-b8d0-410ff93cb8f0; Fri, 13 Jan 2023 06:30:33 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F12CCFEC; Thu, 12 Jan 2023 21:31:14 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 3E9B43F587; Thu, 12 Jan 2023 21:30:29 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 66628c11-9303-11ed-b8d0-410ff93cb8f0 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v2 18/40] xen/mpu: introduce helper access_protection_region Date: Fri, 13 Jan 2023 13:28:51 +0800 Message-Id: <20230113052914.3845596-19-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230113052914.3845596-1-Penny.Zheng@arm.com> References: <20230113052914.3845596-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Each EL2 MPU protection region could be configured using PRBAR_EL2 and PRLAR_EL2. This commit introduces a new helper access_protection_region() to access EL2 MPU protection region, including both read/write operations. As explained in section G1.3.18 of the reference manual for AArch64v8R, a set of system register PRBAR_EL2 and PRLAR_EL2 provide access to the EL2 MPU region which is determined by the value of 'n' and PRSELR_EL2.REGION as PRSELR_EL2.REGION<7:4>:n.(n = 0, 1, 2, ... , 15) For example to access regions from 16 to 31: - Set PRSELR_EL2 to 0b1xxxx - Region 16 configuration is accessible through PRBAR0_EL2 and PRLAR0_EL2 - Region 17 configuration is accessible through PRBAR1_EL2 and PRLAR1_EL2 - Region 18 configuration is accessible through PRBAR2_EL2 and PRLAR2_EL2 - ... - Region 31 configuration is accessible through PRBAR15_EL2 and PRLAR15_EL2 Signed-off-by: Penny Zheng Signed-off-by: Wei Chen --- xen/arch/arm/mm_mpu.c | 151 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 151 insertions(+) diff --git a/xen/arch/arm/mm_mpu.c b/xen/arch/arm/mm_mpu.c index c9e17ab6da..f2b494449c 100644 --- a/xen/arch/arm/mm_mpu.c +++ b/xen/arch/arm/mm_mpu.c @@ -46,6 +46,157 @@ uint64_t __ro_after_init next_transient_region_idx; /* Maximum number of supported MPU memory regions by the EL2 MPU. */ uint64_t __ro_after_init max_xen_mpumap; +/* Write a MPU protection region */ +#define WRITE_PROTECTION_REGION(sel, pr, prbar_el2, prlar_el2) ({ \ + uint64_t _sel = sel; \ + const pr_t *_pr = pr; \ + asm volatile( \ + "msr "__stringify(PRSELR_EL2)", %0;" /* Selects the region */ \ + "dsb sy;" \ + "msr "__stringify(prbar_el2)", %1;" /* Write PRBAR_EL2 */ \ + "msr "__stringify(prlar_el2)", %2;" /* Write PRLAR_EL2 */ \ + "dsb sy;" \ + : : "r" (_sel), "r" (_pr->prbar.bits), "r" (_pr->prlar.bits)); \ +}) + +/* Read a MPU protection region */ +#define READ_PROTECTION_REGION(sel, prbar_el2, prlar_el2) ({ \ + uint64_t _sel = sel; \ + pr_t _pr; \ + asm volatile( \ + "msr "__stringify(PRSELR_EL2)", %2;" /* Selects the region */ \ + "dsb sy;" \ + "mrs %0, "__stringify(prbar_el2)";" /* Read PRBAR_EL2 */ \ + "mrs %1, "__stringify(prlar_el2)";" /* Read PRLAR_EL2 */ \ + "dsb sy;" \ + : "=r" (_pr.prbar.bits), "=r" (_pr.prlar.bits) : "r" (_sel)); \ + _pr; \ +}) + +/* + * Access MPU protection region, including both read/write operations. + * Armv8-R AArch64 at most supports 255 MPU protection regions. + * See section G1.3.18 of the reference manual for Armv8-R AArch64, + * PRBAR_EL2 and PRLAR_EL2 provide access to the EL2 MPU region + * determined by the value of 'n' and PRSELR_EL2.REGION as + * PRSELR_EL2.REGION<7:4>:n(n = 0, 1, 2, ... , 15) + * For example to access regions from 16 to 31 (0b10000 to 0b11111): + * - Set PRSELR_EL2 to 0b1xxxx + * - Region 16 configuration is accessible through PRBAR0_ELx and PRLAR0_ELx + * - Region 17 configuration is accessible through PRBAR1_ELx and PRLAR1_ELx + * - Region 18 configuration is accessible through PRBAR2_ELx and PRLAR2_ELx + * - ... + * - Region 31 configuration is accessible through PRBAR15_ELx and PRLAR15_ELx + * + * @read: if it is read operation. + * @pr_read: mpu protection region returned by read op. + * @pr_write: const mpu protection region passed through write op. + * @sel: mpu protection region selector + */ +static void access_protection_region(bool read, pr_t *pr_read, + const pr_t *pr_write, uint64_t sel) +{ + switch ( sel & 0xf ) + { + case 0: + if ( read ) + *pr_read = READ_PROTECTION_REGION(sel, PRBAR0_EL2, PRLAR0_EL2); + else + WRITE_PROTECTION_REGION(sel, pr_write, PRBAR0_EL2, PRLAR0_EL2); + break; + case 1: + if ( read ) + *pr_read = READ_PROTECTION_REGION(sel, PRBAR1_EL2, PRLAR1_EL2); + else + WRITE_PROTECTION_REGION(sel, pr_write, PRBAR1_EL2, PRLAR1_EL2); + break; + case 2: + if ( read ) + *pr_read = READ_PROTECTION_REGION(sel, PRBAR2_EL2, PRLAR2_EL2); + else + WRITE_PROTECTION_REGION(sel, pr_write, PRBAR2_EL2, PRLAR2_EL2); + break; + case 3: + if ( read ) + *pr_read = READ_PROTECTION_REGION(sel, PRBAR3_EL2, PRLAR3_EL2); + else + WRITE_PROTECTION_REGION(sel, pr_write, PRBAR3_EL2, PRLAR3_EL2); + break; + case 4: + if ( read ) + *pr_read = READ_PROTECTION_REGION(sel, PRBAR4_EL2, PRLAR4_EL2); + else + WRITE_PROTECTION_REGION(sel, pr_write, PRBAR4_EL2, PRLAR4_EL2); + break; + case 5: + if ( read ) + *pr_read = READ_PROTECTION_REGION(sel, PRBAR5_EL2, PRLAR5_EL2); + else + WRITE_PROTECTION_REGION(sel, pr_write, PRBAR5_EL2, PRLAR5_EL2); + break; + case 6: + if ( read ) + *pr_read = READ_PROTECTION_REGION(sel, PRBAR6_EL2, PRLAR6_EL2); + else + WRITE_PROTECTION_REGION(sel, pr_write, PRBAR6_EL2, PRLAR6_EL2); + break; + case 7: + if ( read ) + *pr_read = READ_PROTECTION_REGION(sel, PRBAR7_EL2, PRLAR7_EL2); + else + WRITE_PROTECTION_REGION(sel, pr_write, PRBAR7_EL2, PRLAR7_EL2); + break; + case 8: + if ( read ) + *pr_read = READ_PROTECTION_REGION(sel, PRBAR8_EL2, PRLAR8_EL2); + else + WRITE_PROTECTION_REGION(sel, pr_write, PRBAR8_EL2, PRLAR8_EL2); + break; + case 9: + if ( read ) + *pr_read = READ_PROTECTION_REGION(sel, PRBAR9_EL2, PRLAR9_EL2); + else + WRITE_PROTECTION_REGION(sel, pr_write, PRBAR9_EL2, PRLAR9_EL2); + break; + case 10: + if ( read ) + *pr_read = READ_PROTECTION_REGION(sel, PRBAR10_EL2, PRLAR10_EL2); + else + WRITE_PROTECTION_REGION(sel, pr_write, PRBAR10_EL2, PRLAR10_EL2); + break; + case 11: + if ( read ) + *pr_read = READ_PROTECTION_REGION(sel, PRBAR11_EL2, PRLAR11_EL2); + else + WRITE_PROTECTION_REGION(sel, pr_write, PRBAR11_EL2, PRLAR11_EL2); + break; + case 12: + if ( read ) + *pr_read = READ_PROTECTION_REGION(sel, PRBAR12_EL2, PRLAR12_EL2); + else + WRITE_PROTECTION_REGION(sel, pr_write, PRBAR12_EL2, PRLAR12_EL2); + break; + case 13: + if ( read ) + *pr_read = READ_PROTECTION_REGION(sel, PRBAR13_EL2, PRLAR13_EL2); + else + WRITE_PROTECTION_REGION(sel, pr_write, PRBAR13_EL2, PRLAR13_EL2); + break; + case 14: + if ( read ) + *pr_read = READ_PROTECTION_REGION(sel, PRBAR14_EL2, PRLAR14_EL2); + else + WRITE_PROTECTION_REGION(sel, pr_write, PRBAR14_EL2, PRLAR14_EL2); + break; + case 15: + if ( read ) + *pr_read = READ_PROTECTION_REGION(sel, PRBAR15_EL2, PRLAR15_EL2); + else + WRITE_PROTECTION_REGION(sel, pr_write, PRBAR15_EL2, PRLAR15_EL2); + break; + } +} + /* TODO: Implementation on the first usage */ void dump_hyp_walk(vaddr_t addr) { -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 13 05:36:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 05:36:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476613.739013 (Exim 4.92) (envelope-from ) id 1pGCjf-0004gG-JU; Fri, 13 Jan 2023 05:36:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476613.739013; Fri, 13 Jan 2023 05:36:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCjf-0004fj-DW; Fri, 13 Jan 2023 05:36:15 +0000 Received: by outflank-mailman (input) for mailman id 476613; Fri, 13 Jan 2023 05:36:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCfF-0005sP-7Y for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 05:31:41 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 8d74ef45-9303-11ed-b8d0-410ff93cb8f0; Fri, 13 Jan 2023 06:31:38 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 838A813D5; Thu, 12 Jan 2023 21:32:20 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id C55C63F587; Thu, 12 Jan 2023 21:31:35 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8d74ef45-9303-11ed-b8d0-410ff93cb8f0 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v2 38/40] xen/mpu: implement setup_virt_paging for MPU system Date: Fri, 13 Jan 2023 13:29:11 +0800 Message-Id: <20230113052914.3845596-39-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230113052914.3845596-1-Penny.Zheng@arm.com> References: <20230113052914.3845596-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit For MMU system setup_virt_paging is used to configure stage 2 address translation, like IPA bits, VMID bits, etc. And this function is also doing the VMID allocator initializtion for later VM creation. Except for IPA bits and VMID bits, the setup_virt_paging function in MPU system should be also responsible for determining the default EL1/EL0 translation regime. ARMv8-R AArch64 could have the following memory translation regime: - PMSAv8-64 at both EL1/EL0 and EL2 - PMSAv8-64 or VMSAv8-64 at EL1/EL0 and PMSAv8-64 at EL2 The default value will be VMSAv8-64, unless the platform could not support, which could be checked against MSA_frac bit in Memory Model Feature Register 0( ID_AA64MMFR0_EL1) Signed-off-by: Penny Zheng Signed-off-by: Wei Chen --- xen/arch/arm/include/asm/arm64/sysregs.h | 6 ++ xen/arch/arm/include/asm/cpufeature.h | 7 ++ xen/arch/arm/include/asm/p2m.h | 18 +++++ xen/arch/arm/include/asm/processor.h | 13 ++++ xen/arch/arm/p2m.c | 28 ++++++++ xen/arch/arm/p2m_mmu.c | 38 ---------- xen/arch/arm/p2m_mpu.c | 91 ++++++++++++++++++++++-- 7 files changed, 159 insertions(+), 42 deletions(-) diff --git a/xen/arch/arm/include/asm/arm64/sysregs.h b/xen/arch/arm/include/asm/arm64/sysregs.h index 9546e8e3d0..7d4f959dae 100644 --- a/xen/arch/arm/include/asm/arm64/sysregs.h +++ b/xen/arch/arm/include/asm/arm64/sysregs.h @@ -507,6 +507,12 @@ /* MPU Protection Region Enable Register encode */ #define PRENR_EL2 S3_4_C6_C1_1 +/* Virtualization Secure Translation Control Register */ +#define VSTCR_EL2 S3_4_C2_C6_2 +#define VSTCR_EL2_RES1_SHIFT 31 +#define VSTCR_EL2_SA_SHIFT 30 +#define VSTCR_EL2_SC_SHIFT 20 + #endif #ifdef CONFIG_ARM_SECURE_STATE diff --git a/xen/arch/arm/include/asm/cpufeature.h b/xen/arch/arm/include/asm/cpufeature.h index c62cf6293f..513e5b9918 100644 --- a/xen/arch/arm/include/asm/cpufeature.h +++ b/xen/arch/arm/include/asm/cpufeature.h @@ -244,6 +244,12 @@ struct cpuinfo_arm { unsigned long tgranule_16K:4; unsigned long tgranule_64K:4; unsigned long tgranule_4K:4; +#ifdef CONFIG_ARM_V8R + unsigned long __res:16; + unsigned long msa:4; + unsigned long msa_frac:4; + unsigned long __res0:8; +#else unsigned long tgranule_16k_2:4; unsigned long tgranule_64k_2:4; unsigned long tgranule_4k_2:4; @@ -251,6 +257,7 @@ struct cpuinfo_arm { unsigned long __res0:8; unsigned long fgt:4; unsigned long ecv:4; +#endif /* MMFR1 */ unsigned long hafdbs:4; diff --git a/xen/arch/arm/include/asm/p2m.h b/xen/arch/arm/include/asm/p2m.h index a430aca232..cd28a9091a 100644 --- a/xen/arch/arm/include/asm/p2m.h +++ b/xen/arch/arm/include/asm/p2m.h @@ -14,9 +14,27 @@ /* Holds the bit size of IPAs in p2m tables. */ extern unsigned int p2m_ipa_bits; +#define MAX_VMID_8_BIT (1UL << 8) +#define MAX_VMID_16_BIT (1UL << 16) + +#define INVALID_VMID 0 /* VMID 0 is reserved */ + +#ifdef CONFIG_ARM_64 +extern unsigned int max_vmid; +/* VMID is by default 8 bit width on AArch64 */ +#define MAX_VMID max_vmid +#else +/* VMID is always 8 bit width on AArch32 */ +#define MAX_VMID MAX_VMID_8_BIT +#endif + +extern spinlock_t vmid_alloc_lock; +extern unsigned long *vmid_mask; + struct domain; extern void memory_type_changed(struct domain *); +extern void p2m_vmid_allocator_init(void); /* Per-p2m-table state */ struct p2m_domain { diff --git a/xen/arch/arm/include/asm/processor.h b/xen/arch/arm/include/asm/processor.h index 1dd81d7d52..d866421d88 100644 --- a/xen/arch/arm/include/asm/processor.h +++ b/xen/arch/arm/include/asm/processor.h @@ -388,6 +388,12 @@ #define VTCR_RES1 (_AC(1,UL)<<31) +#ifdef CONFIG_ARM_V8R +#define VTCR_MSA_VMSA (_AC(0x1,UL)<<31) +#define VTCR_MSA_PMSA ~(_AC(0x1,UL)<<31) +#define NSA_SEL2 ~(_AC(0x1,UL)<<30) +#endif + /* HCPTR Hyp. Coprocessor Trap Register */ #define HCPTR_TAM ((_AC(1,U)<<30)) #define HCPTR_TTA ((_AC(1,U)<<20)) /* Trap trace registers */ @@ -447,6 +453,13 @@ #define MM64_VMID_16_BITS_SUPPORT 0x2 #endif +#ifdef CONFIG_ARM_V8R +#define MM64_MSA_PMSA_SUPPORT 0xf +#define MM64_MSA_FRAC_NONE_SUPPORT 0x0 +#define MM64_MSA_FRAC_PMSA_SUPPORT 0x1 +#define MM64_MSA_FRAC_VMSA_SUPPORT 0x2 +#endif + #ifndef __ASSEMBLY__ extern register_t __cpu_logical_map[]; diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c index 42f51051e0..0d0063aa2e 100644 --- a/xen/arch/arm/p2m.c +++ b/xen/arch/arm/p2m.c @@ -4,6 +4,21 @@ #include #include +#include + +#ifdef CONFIG_ARM_64 +unsigned int __read_mostly max_vmid = MAX_VMID_8_BIT; +#endif + +spinlock_t vmid_alloc_lock = SPIN_LOCK_UNLOCKED; + +/* + * VTTBR_EL2 VMID field is 8 or 16 bits. AArch64 may support 16-bit VMID. + * Using a bitmap here limits us to 256 or 65536 (for AArch64) concurrent + * domains. The bitmap space will be allocated dynamically based on + * whether 8 or 16 bit VMIDs are supported. + */ +unsigned long *vmid_mask; /* * Set to the maximum configured support for IPA bits, so the number of IPA bits can be @@ -142,6 +157,19 @@ void __init p2m_restrict_ipa_bits(unsigned int ipa_bits) p2m_ipa_bits = ipa_bits; } +void p2m_vmid_allocator_init(void) +{ + /* + * allocate space for vmid_mask based on MAX_VMID + */ + vmid_mask = xzalloc_array(unsigned long, BITS_TO_LONGS(MAX_VMID)); + + if ( !vmid_mask ) + panic("Could not allocate VMID bitmap space\n"); + + set_bit(INVALID_VMID, vmid_mask); +} + /* * Local variables: * mode: C diff --git a/xen/arch/arm/p2m_mmu.c b/xen/arch/arm/p2m_mmu.c index 88a9d8f392..7e1afd0bb3 100644 --- a/xen/arch/arm/p2m_mmu.c +++ b/xen/arch/arm/p2m_mmu.c @@ -14,20 +14,6 @@ #include #include -#define MAX_VMID_8_BIT (1UL << 8) -#define MAX_VMID_16_BIT (1UL << 16) - -#define INVALID_VMID 0 /* VMID 0 is reserved */ - -#ifdef CONFIG_ARM_64 -static unsigned int __read_mostly max_vmid = MAX_VMID_8_BIT; -/* VMID is by default 8 bit width on AArch64 */ -#define MAX_VMID max_vmid -#else -/* VMID is always 8 bit width on AArch32 */ -#define MAX_VMID MAX_VMID_8_BIT -#endif - #ifdef CONFIG_ARM_64 unsigned int __read_mostly p2m_root_order; unsigned int __read_mostly p2m_root_level; @@ -1516,30 +1502,6 @@ static int p2m_alloc_table(struct domain *d) return 0; } - -static spinlock_t vmid_alloc_lock = SPIN_LOCK_UNLOCKED; - -/* - * VTTBR_EL2 VMID field is 8 or 16 bits. AArch64 may support 16-bit VMID. - * Using a bitmap here limits us to 256 or 65536 (for AArch64) concurrent - * domains. The bitmap space will be allocated dynamically based on - * whether 8 or 16 bit VMIDs are supported. - */ -static unsigned long *vmid_mask; - -static void p2m_vmid_allocator_init(void) -{ - /* - * allocate space for vmid_mask based on MAX_VMID - */ - vmid_mask = xzalloc_array(unsigned long, BITS_TO_LONGS(MAX_VMID)); - - if ( !vmid_mask ) - panic("Could not allocate VMID bitmap space\n"); - - set_bit(INVALID_VMID, vmid_mask); -} - static int p2m_alloc_vmid(struct domain *d) { struct p2m_domain *p2m = p2m_get_hostp2m(d); diff --git a/xen/arch/arm/p2m_mpu.c b/xen/arch/arm/p2m_mpu.c index 0a95d58111..77b4bc9221 100644 --- a/xen/arch/arm/p2m_mpu.c +++ b/xen/arch/arm/p2m_mpu.c @@ -2,8 +2,95 @@ #include #include #include +#include #include +#include +#include + +void __init setup_virt_paging(void) +{ + uint64_t val = 0; + bool p2m_vmsa = true; + + /* PA size */ + const unsigned int pa_range_info[] = { 32, 36, 40, 42, 44, 48, 52, 0, /* Invalid */ }; + + /* + * Restrict "p2m_ipa_bits" if needed. As P2M table is always configured + * with IPA bits == PA bits, compare against "pabits". + */ + if ( pa_range_info[system_cpuinfo.mm64.pa_range] < p2m_ipa_bits ) + p2m_ipa_bits = pa_range_info[system_cpuinfo.mm64.pa_range]; + + /* In ARMV8R, hypervisor in secure EL2. */ + val &= NSA_SEL2; + + /* + * ARMv8-R AArch64 could have the following memory system + * configurations: + * - PMSAv8-64 at EL1 and EL2 + * - PMSAv8-64 or VMSAv8-64 at EL1 and PMSAv8-64 at EL2 + * + * In ARMv8-R, the only permitted value is + * 0b1111(MM64_MSA_PMSA_SUPPORT). + */ + if ( system_cpuinfo.mm64.msa == MM64_MSA_PMSA_SUPPORT ) + { + if ( system_cpuinfo.mm64.msa_frac == MM64_MSA_FRAC_NONE_SUPPORT ) + goto fault; + + if ( system_cpuinfo.mm64.msa_frac != MM64_MSA_FRAC_VMSA_SUPPORT ) + { + p2m_vmsa = false; + warning_add("Be aware of that there is no support for VMSAv8-64 at EL1 on this platform.\n"); + } + } + else + goto fault; + + /* + * If the platform supports both PMSAv8-64 or VMSAv8-64 at EL1, + * then it's VTCR_EL2.MSA that determines the EL1 memory system + * architecture. + * Normally, we set the initial VTCR_EL2.MSA value VMSAv8-64 support, + * unless this platform only supports PMSAv8-64. + */ + if ( !p2m_vmsa ) + val &= VTCR_MSA_PMSA; + else + val |= VTCR_MSA_VMSA; + + /* + * cpuinfo sanitization makes sure we support 16bits VMID only if + * all cores are supporting it. + */ + if ( system_cpuinfo.mm64.vmid_bits == MM64_VMID_16_BITS_SUPPORT ) + max_vmid = MAX_VMID_16_BIT; + + /* Set the VS bit only if 16 bit VMID is supported. */ + if ( MAX_VMID == MAX_VMID_16_BIT ) + val |= VTCR_VS; + + p2m_vmid_allocator_init(); + + WRITE_SYSREG(val, VTCR_EL2); + + /* + * All stage 2 translations for the Secure PA space access the + * Secure PA space, so we keep SA bit as 0. + * + * Stage 2 NS configuration is checked against stage 1 NS configuration + * in EL1&0 translation regime for the given address, and generate a + * fault if they are different. So we set SC bit as 1. + */ + WRITE_SYSREG(1 << VSTCR_EL2_RES1_SHIFT | 1 << VSTCR_EL2_SC_SHIFT, VTCR_EL2); + + return; + +fault: + panic("Hardware with no PMSAv8-64 support in any translation regime.\n"); +} /* TODO: Implement on the first usage */ void p2m_write_unlock(struct p2m_domain *p2m) @@ -177,10 +264,6 @@ struct page_info *get_page_from_gva(struct vcpu *v, vaddr_t va, return NULL; } -void __init setup_virt_paging(void) -{ -} - /* * Local variables: * mode: C -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 13 05:36:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 05:36:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476616.739019 (Exim 4.92) (envelope-from ) id 1pGCjg-0004rw-Bw; Fri, 13 Jan 2023 05:36:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476616.739019; Fri, 13 Jan 2023 05:36:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCjg-0004pb-5Y; Fri, 13 Jan 2023 05:36:16 +0000 Received: by outflank-mailman (input) for mailman id 476616; Fri, 13 Jan 2023 05:36:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCer-0005sP-Th for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 05:31:17 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 7fe06f02-9303-11ed-b8d0-410ff93cb8f0; Fri, 13 Jan 2023 06:31:16 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B7A0CFEC; Thu, 12 Jan 2023 21:31:57 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id F18763F587; Thu, 12 Jan 2023 21:31:11 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7fe06f02-9303-11ed-b8d0-410ff93cb8f0 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Penny Zheng Subject: [PATCH v2 31/40] xen/mpu: disable FIXMAP in MPU system Date: Fri, 13 Jan 2023 13:29:04 +0800 Message-Id: <20230113052914.3845596-32-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230113052914.3845596-1-Penny.Zheng@arm.com> References: <20230113052914.3845596-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit FIXMAP in MMU system is used to do special-purpose 4K mapping, like mapping early UART, temporarily mapping source codes for copy and paste (copy_from_paddr), ect. As there is no VMSA in MPU system, we do not support FIXMAP in MPU system. We deine !CONFIG_HAS_FIXMAP to provide empty stubbers for MPU system Signed-off-by: Penny Zheng Signed-off-by: Wei Chen --- xen/arch/arm/Kconfig | 3 ++- xen/arch/arm/include/asm/fixmap.h | 28 +++++++++++++++++++++++++--- xen/common/Kconfig | 3 +++ 3 files changed, 30 insertions(+), 4 deletions(-) diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index 9230c8b885..91491341c4 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -13,9 +13,10 @@ config ARM def_bool y select HAS_ALTERNATIVE if !ARM_V8R select HAS_DEVICE_TREE + select HAS_FIXMAP if !ARM_V8R select HAS_PASSTHROUGH select HAS_PDX - select HAS_PMAP + select HAS_PMAP if !ARM_V8R select IOMMU_FORCE_PT_SHARE select HAS_VMAP if !ARM_V8R diff --git a/xen/arch/arm/include/asm/fixmap.h b/xen/arch/arm/include/asm/fixmap.h index d0c9a52c8c..f0f4eb57ac 100644 --- a/xen/arch/arm/include/asm/fixmap.h +++ b/xen/arch/arm/include/asm/fixmap.h @@ -4,9 +4,6 @@ #ifndef __ASM_FIXMAP_H #define __ASM_FIXMAP_H -#include -#include - /* Fixmap slots */ #define FIXMAP_CONSOLE 0 /* The primary UART */ #define FIXMAP_MISC 1 /* Ephemeral mappings of hardware */ @@ -22,6 +19,11 @@ #ifndef __ASSEMBLY__ +#ifdef CONFIG_HAS_FIXMAP + +#include +#include + /* * Direct access to xen_fixmap[] should only happen when {set, * clear}_fixmap() is unusable (e.g. where we would end up to @@ -43,6 +45,26 @@ static inline unsigned int virt_to_fix(vaddr_t vaddr) return ((vaddr - FIXADDR_START) >> PAGE_SHIFT); } +#else /* !CONFIG_HAS_FIXMAP */ + +static inline void set_fixmap(unsigned int map, mfn_t mfn, + unsigned int attributes) +{ + ASSERT_UNREACHABLE(); +} + +static inline void clear_fixmap(unsigned int map) +{ + ASSERT_UNREACHABLE(); +} + +static inline unsigned int virt_to_fix(vaddr_t vaddr) +{ + ASSERT_UNREACHABLE(); + return -EINVAL; +} +#endif /* !CONFIG_HAS_FIXMAP */ + #endif /* __ASSEMBLY__ */ #endif /* __ASM_FIXMAP_H */ diff --git a/xen/common/Kconfig b/xen/common/Kconfig index ba16366a4b..680dc6f59c 100644 --- a/xen/common/Kconfig +++ b/xen/common/Kconfig @@ -43,6 +43,9 @@ config HAS_EX_TABLE config HAS_FAST_MULTIPLY bool +config HAS_FIXMAP + bool + config HAS_IOPORTS bool -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 13 05:36:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 05:36:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476619.739031 (Exim 4.92) (envelope-from ) id 1pGCji-0005Ez-06; Fri, 13 Jan 2023 05:36:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476619.739031; Fri, 13 Jan 2023 05:36:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCjh-0005Dn-O5; Fri, 13 Jan 2023 05:36:17 +0000 Received: by outflank-mailman (input) for mailman id 476619; Fri, 13 Jan 2023 05:36:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCez-0005sP-21 for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 05:31:25 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 8417391e-9303-11ed-b8d0-410ff93cb8f0; Fri, 13 Jan 2023 06:31:23 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B3E5C13D5; Thu, 12 Jan 2023 21:32:04 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 40C9B3F587; Thu, 12 Jan 2023 21:31:20 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8417391e-9303-11ed-b8d0-410ff93cb8f0 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v2 33/40] xen/arm: check mapping status and attributes for MPU copy_from_paddr Date: Fri, 13 Jan 2023 13:29:06 +0800 Message-Id: <20230113052914.3845596-34-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230113052914.3845596-1-Penny.Zheng@arm.com> References: <20230113052914.3845596-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Wei Chen We introduce map_page_to_xen_misc/unmap_page_to_xen_misc to temporarily map a page in Xen misc field to gain access, however, in MPU system, all resource is statically configured in Device Tree and already mapped at very early boot stage. When enabling map_page_to_xen_misc for copy_from_paddr in MPU system, we need to check whether a given paddr is properly mapped. Signed-off-by: Wei Chen Signed-off-by: Penny Zheng --- xen/arch/arm/kernel.c | 2 +- xen/arch/arm/mm_mpu.c | 21 +++++++++++++++++++++ 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/kernel.c b/xen/arch/arm/kernel.c index ee7144ec13..ce2b3347d7 100644 --- a/xen/arch/arm/kernel.c +++ b/xen/arch/arm/kernel.c @@ -57,7 +57,7 @@ void __init copy_from_paddr(void *dst, paddr_t paddr, unsigned long len) s = paddr & (PAGE_SIZE - 1); l = min(PAGE_SIZE - s, len); - src = map_page_to_xen_misc(maddr_to_mfn(paddr), PAGE_HYPERVISOR_WC); + src = map_page_to_xen_misc(maddr_to_mfn(paddr), DEFINE_ATTRIBUTE(HYPERVISOR_WC)); ASSERT(src != NULL); memcpy(dst, src + s, l); clean_dcache_va_range(dst, l); diff --git a/xen/arch/arm/mm_mpu.c b/xen/arch/arm/mm_mpu.c index 7b54c87acf..0b720004ee 100644 --- a/xen/arch/arm/mm_mpu.c +++ b/xen/arch/arm/mm_mpu.c @@ -790,6 +790,27 @@ void *ioremap(paddr_t pa, size_t len) return ioremap_attr(pa, len, REGION_HYPERVISOR_NOCACHE); } +/* + * In MPU system, due to limited MPU memory regions, all resource is statically + * configured in Device Tree and mapped at very early stage, dynamic temporary + * page mapping is not allowed. + * So in map_page_to_xen_misc, we need to check if page is already properly + * mapped with #attributes. + */ +void *map_page_to_xen_misc(mfn_t mfn, unsigned int attributes) +{ + paddr_t pa = mfn_to_maddr(mfn); + + if ( !check_region_and_attributes(pa, PAGE_SIZE, attributes, "map_to_misc") ) + return NULL; + + return maddr_to_virt(pa); +} + +void unmap_page_from_xen_misc(void) +{ +} + /* TODO: Implementation on the first usage */ void dump_hyp_walk(vaddr_t addr) { -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 13 05:36:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 05:36:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476620.739037 (Exim 4.92) (envelope-from ) id 1pGCjj-0005JM-0U; Fri, 13 Jan 2023 05:36:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476620.739037; Fri, 13 Jan 2023 05:36:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCji-0005HE-7S; Fri, 13 Jan 2023 05:36:18 +0000 Received: by outflank-mailman (input) for mailman id 476620; Fri, 13 Jan 2023 05:36:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCej-0005sP-Nm for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 05:31:09 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 7ad5d262-9303-11ed-b8d0-410ff93cb8f0; Fri, 13 Jan 2023 06:31:07 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 34C54FEC; Thu, 12 Jan 2023 21:31:49 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 7676F3F587; Thu, 12 Jan 2023 21:31:04 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7ad5d262-9303-11ed-b8d0-410ff93cb8f0 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v2 29/40] xen/mpu: introduce mpu_memory_section_contains for address range check Date: Fri, 13 Jan 2023 13:29:02 +0800 Message-Id: <20230113052914.3845596-30-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230113052914.3845596-1-Penny.Zheng@arm.com> References: <20230113052914.3845596-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit We have already introduced "mpu,xxx-memory-section" to limit system/domain configuration, so we shall add check to verfify user's configuration. We shall check if any guest boot module is within the boot module section, including kernel module(BOOTMOD_KERNEL), device tree passthrough module(BOOTMOD_GUEST_DTB), and ramdisk module(BOOTMOD_RAMDISK). We also shall check if any guest RAM through "xen,static-mem" is within the guest memory section. Function mpu_memory_section_contains is introduced to do above check. Signed-off-by: Penny Zheng Signed-off-by: Wei Chen --- xen/arch/arm/domain_build.c | 4 ++++ xen/arch/arm/include/asm/setup.h | 2 ++ xen/arch/arm/kernel.c | 18 ++++++++++++++++++ xen/arch/arm/setup_mpu.c | 22 ++++++++++++++++++++++ 4 files changed, 46 insertions(+) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 829cea8de8..f48a3f679f 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -546,6 +546,10 @@ static mfn_t __init acquire_static_memory_bank(struct domain *d, d, *psize); return INVALID_MFN; } +#ifdef CONFIG_HAS_MPU + if ( !mpu_memory_section_contains(*pbase, *pbase + *psize, MSINFO_GUEST) ) + return INVALID_MFN; +#endif smfn = maddr_to_mfn(*pbase); res = acquire_domstatic_pages(d, smfn, PFN_DOWN(*psize), 0); diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index 61f24b5848..d4c1336597 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -209,6 +209,8 @@ extern struct mpuinfo mpuinfo; extern int process_mpuinfo(const void *fdt, int node, uint32_t address_cells, uint32_t size_cells); +extern bool mpu_memory_section_contains(paddr_t s, paddr_t e, + enum mpu_section_info type); #endif /* CONFIG_HAS_MPU */ #endif diff --git a/xen/arch/arm/kernel.c b/xen/arch/arm/kernel.c index 0475d8fae7..ee7144ec13 100644 --- a/xen/arch/arm/kernel.c +++ b/xen/arch/arm/kernel.c @@ -467,6 +467,12 @@ int __init kernel_probe(struct kernel_info *info, mod = boot_module_find_by_addr_and_kind( BOOTMOD_KERNEL, kernel_addr); info->kernel_bootmodule = mod; +#ifdef CONFIG_HAS_MPU + if ( !mpu_memory_section_contains(mod->start, + mod->start + mod->size, + MSINFO_BOOTMODULE) ) + return -EINVAL; +#endif } else if ( dt_device_is_compatible(node, "multiboot,ramdisk") ) { @@ -477,6 +483,12 @@ int __init kernel_probe(struct kernel_info *info, dt_get_range(&val, node, &initrd_addr, &size); info->initrd_bootmodule = boot_module_find_by_addr_and_kind( BOOTMOD_RAMDISK, initrd_addr); +#ifdef CONFIG_HAS_MPU + if ( !mpu_memory_section_contains(mod->start, + mod->start + mod->size, + MSINFO_BOOTMODULE) ) + return -EINVAL; +#endif } else if ( dt_device_is_compatible(node, "multiboot,device-tree") ) { @@ -489,6 +501,12 @@ int __init kernel_probe(struct kernel_info *info, dt_get_range(&val, node, &dtb_addr, &size); info->dtb_bootmodule = boot_module_find_by_addr_and_kind( BOOTMOD_GUEST_DTB, dtb_addr); +#ifdef CONFIG_HAS_MPU + if ( !mpu_memory_section_contains(mod->start, + mod->start + mod->size, + MSINFO_BOOTMODULE) ) + return -EINVAL; +#endif } else continue; diff --git a/xen/arch/arm/setup_mpu.c b/xen/arch/arm/setup_mpu.c index 160934bf86..f7d74ea604 100644 --- a/xen/arch/arm/setup_mpu.c +++ b/xen/arch/arm/setup_mpu.c @@ -130,6 +130,28 @@ void __init setup_mm(void) init_staticmem_pages(); } +bool __init mpu_memory_section_contains(paddr_t s, paddr_t e, + enum mpu_section_info type) +{ + unsigned int i = 0; + + for ( ; i < mpuinfo.sections[type].nr_banks; i++ ) + { + paddr_t section_start = mpuinfo.sections[type].bank[i].start; + paddr_t section_size = mpuinfo.sections[type].bank[i].size; + paddr_t section_end = section_start + section_size; + + /* range inclusive */ + if ( s >= section_start && e <= section_end ) + return true; + } + + printk(XENLOG_ERR + "mpu: invalid range configuration 0x%"PRIpaddr" - 0x%"PRIpaddr", and it shall be within %s\n", + s, e, mpu_section_info_str[i]); + return false; +} + /* * Local variables: * mode: C -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 13 05:36:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 05:36:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476623.739042 (Exim 4.92) (envelope-from ) id 1pGCjj-0005S6-Gb; Fri, 13 Jan 2023 05:36:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476623.739042; Fri, 13 Jan 2023 05:36:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCji-0005OI-QJ; Fri, 13 Jan 2023 05:36:18 +0000 Received: by outflank-mailman (input) for mailman id 476623; Fri, 13 Jan 2023 05:36:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCfI-0005sP-BQ for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 05:31:44 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 8f4ed25c-9303-11ed-b8d0-410ff93cb8f0; Fri, 13 Jan 2023 06:31:41 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9D68D13D5; Thu, 12 Jan 2023 21:32:23 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id DF3EB3F587; Thu, 12 Jan 2023 21:31:38 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8f4ed25c-9303-11ed-b8d0-410ff93cb8f0 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v2 39/40] xen/mpu: re-order xen_mpumap in arch_init_finialize Date: Fri, 13 Jan 2023 13:29:12 +0800 Message-Id: <20230113052914.3845596-40-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230113052914.3845596-1-Penny.Zheng@arm.com> References: <20230113052914.3845596-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In function init_done, we have finished the booting and we do the final clean-up working, including marking the section .data.ro_after_init read-only, free init text and init data section, etc. In MPU system, other than above operations, we also need to re-order Xen MPU memory region mapping table(xen_mpumap). In xen_mpumap, we have two type MPU memory region: fixed memory region and switching memory region. Fixed memory region are referring to the regions which won't change since birth, like Xen .text section, while switching region(i.e. device memory) are regions that gets switched out when idle vcpu leaving hypervisor mode, and gets switched in when idle vcpu entering hypervisor mode. They were added at tail during the boot stage. To save the trouble of hunting down each switching region in time-sensitive context switch, we re-order xen_mpumap to keep fixed regions still in the front, and switching ones in the heels of them. We define a MPU memory region mapping table(sw_mpumap) to store all switching regions. After disabling them at its original position, we re-enable them at re-ordering position. Signed-off-by: Penny Zheng --- xen/arch/arm/include/asm/arm64/mpu.h | 5 ++ xen/arch/arm/include/asm/mm_mpu.h | 1 + xen/arch/arm/include/asm/setup.h | 2 + xen/arch/arm/mm_mpu.c | 110 +++++++++++++++++++++++++++ xen/arch/arm/setup.c | 13 +--- xen/arch/arm/setup_mmu.c | 16 ++++ xen/arch/arm/setup_mpu.c | 20 +++++ 7 files changed, 155 insertions(+), 12 deletions(-) diff --git a/xen/arch/arm/include/asm/arm64/mpu.h b/xen/arch/arm/include/asm/arm64/mpu.h index b4e50a9a0e..e058f36435 100644 --- a/xen/arch/arm/include/asm/arm64/mpu.h +++ b/xen/arch/arm/include/asm/arm64/mpu.h @@ -155,6 +155,11 @@ typedef struct { (uint64_t)((_pr->prlar.reg.limit << MPU_REGION_SHIFT) | 0x3f); \ }) +#define region_needs_switching_on_ctxt(pr) ({ \ + pr_t *_pr = pr; \ + _pr->prlar.reg.sw; \ +}) + #endif /* __ASSEMBLY__ */ #endif /* __ARM64_MPU_H__ */ diff --git a/xen/arch/arm/include/asm/mm_mpu.h b/xen/arch/arm/include/asm/mm_mpu.h index 5aa61c43b6..f8f54eb901 100644 --- a/xen/arch/arm/include/asm/mm_mpu.h +++ b/xen/arch/arm/include/asm/mm_mpu.h @@ -10,6 +10,7 @@ * section by section based on static configuration in Device Tree. */ extern void setup_static_mappings(void); +extern int reorder_xen_mpumap(void); extern struct page_info *frame_table; diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index d4c1336597..39cd95553d 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -182,6 +182,8 @@ int map_range_to_domain(const struct dt_device_node *dev, extern const char __ro_after_init_start[], __ro_after_init_end[]; +extern void arch_init_finialize(void); + struct init_info { /* Pointer to the stack, used by head.S when entering in C */ diff --git a/xen/arch/arm/mm_mpu.c b/xen/arch/arm/mm_mpu.c index 118bb11d1a..434ed872c1 100644 --- a/xen/arch/arm/mm_mpu.c +++ b/xen/arch/arm/mm_mpu.c @@ -80,6 +80,25 @@ static const unsigned int mpu_section_mattr[MSINFO_MAX] = { extern char __init_data_begin[], __init_end[]; +/* + * MPU memory mapping table records regions that needs switching in/out + * during vcpu context switch + */ +static pr_t *sw_mpumap; +static uint64_t nr_sw_mpumap; + +/* + * After reordering, nr_xen_mpumap records number of regions for Xen fixed + * memory mapping + */ +static uint64_t nr_xen_mpumap; + +/* + * After reordering, nr_cpu_mpumap records number of EL2 valid + * MPU memory regions + */ +static uint64_t nr_cpu_mpumap; + /* Write a MPU protection region */ #define WRITE_PROTECTION_REGION(sel, pr, prbar_el2, prlar_el2) ({ \ uint64_t _sel = sel; \ @@ -847,6 +866,97 @@ void unmap_page_from_xen_misc(void) { } +void dump_hyp_mapping(void) +{ + uint64_t i = 0; + pr_t region; + + for ( i = 0; i < nr_cpu_mpumap; i++ ) + { + access_protection_region(true, ®ion, NULL, i); + printk(XENLOG_INFO + "MPU memory region [%lu]: 0x%"PRIpaddr" - 0x%"PRIpaddr".\n", + i, pr_get_base(®ion), pr_get_limit(®ion)); + } +} + +/* Standard entry to dynamically allocate MPU memory region mapping table. */ +static pr_t *alloc_mpumap(void) +{ + pr_t *map; + + /* + * A MPU memory region structure(pr_t) takes 16 bytes, even with maximum + * supported MPU protection regions in EL2, 255, MPU table at most takes up + * less than 4KB(PAGE_SIZE). + */ + map = alloc_xenheap_pages(0, 0); + if ( map == NULL ) + return NULL; + + clear_page(map); + return map; +} + +/* + * Switching region(i.e. device memory) are regions that gets switched out + * when idle vcpu leaving hypervisor mode, and gets switched in when idle vcpu + * entering hypervisor mode. They're added at tail during the boot stage. + * To save the trouble of hunting down each switching region in time-sensitive + * context switch, we re-order xen_mpumap to keep fixed regions still in the + * front, and switching ones in the heels of them. + */ +int reorder_xen_mpumap(void) +{ + uint64_t i; + + sw_mpumap = alloc_mpumap(); + if ( !sw_mpumap ) + return -ENOMEM; + + /* Record the switching regions in sw_mpumap. */ + for ( i = next_transient_region_idx - 1; i < max_xen_mpumap; i++ ) + { + pr_t *region; + + region = &xen_mpumap[i]; + if ( region_is_valid(region) && region_needs_switching_on_ctxt(region) ) + { + sw_mpumap[nr_sw_mpumap++] = xen_mpumap[i]; + + /* + * Disable it temporarily for later enabling it in the + * new reordered position + * WARNING: since device memory section, as switching region, + * will get disabled temporarily, console will become inaccessible + * in a short time. + */ + control_mpu_region_from_index(i, false); + memset(&xen_mpumap[i], 0, sizeof(pr_t)); + } + } + + /* Put switching regions after fixed regions */ + i = 0; + nr_cpu_mpumap = nr_xen_mpumap = next_fixed_region_idx; + do + { + access_protection_region(false, NULL, + (const pr_t*)(&sw_mpumap[i]), + nr_cpu_mpumap); + nr_cpu_mpumap++; + } while ( ++i < nr_sw_mpumap ); + + /* + * Now, xen_mpumap becomes a tight mapping, with fixed region at front and + * switching ones after fixed ones. + */ + printk(XENLOG_INFO "Xen EL2 MPU memory region mapping after re-order.\n"); + dump_hyp_mapping(); + + return 0; +} + /* TODO: Implementation on the first usage */ void dump_hyp_walk(vaddr_t addr) { diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 49ba998f68..b21fc4b8e2 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -61,23 +61,12 @@ domid_t __read_mostly max_init_domid; static __used void init_done(void) { - int rc; - /* Must be done past setting system_state. */ unregister_init_virtual_region(); free_init_memory(); - /* - * We have finished booting. Mark the section .data.ro_after_init - * read-only. - */ - rc = modify_xen_mappings((unsigned long)&__ro_after_init_start, - (unsigned long)&__ro_after_init_end, - PAGE_HYPERVISOR_RO); - if ( rc ) - panic("Unable to mark the .data.ro_after_init section read-only (rc = %d)\n", - rc); + arch_init_finialize(); startup_cpu_idle_loop(); } diff --git a/xen/arch/arm/setup_mmu.c b/xen/arch/arm/setup_mmu.c index 611a60633e..5b7a5de086 100644 --- a/xen/arch/arm/setup_mmu.c +++ b/xen/arch/arm/setup_mmu.c @@ -365,6 +365,22 @@ void __init discard_initial_modules(void) remove_early_mappings(); } +void arch_init_finialize(void) +{ + int rc; + + /* + * We have finished booting. Mark the section .data.ro_after_init + * read-only. + */ + rc = modify_xen_mappings((unsigned long)&__ro_after_init_start, + (unsigned long)&__ro_after_init_end, + PAGE_HYPERVISOR_RO); + if ( rc ) + panic("Unable to mark the .data.ro_after_init section read-only (rc = %d)\n", + rc); +} + /* * Local variables: * mode: C diff --git a/xen/arch/arm/setup_mpu.c b/xen/arch/arm/setup_mpu.c index f47f1f39ee..b510780cde 100644 --- a/xen/arch/arm/setup_mpu.c +++ b/xen/arch/arm/setup_mpu.c @@ -178,6 +178,26 @@ void __init discard_initial_modules(void) remove_early_mappings(); } +void arch_init_finialize(void) +{ + int rc; + + /* + * We have finished booting. Mark the section .data.ro_after_init + * read-only. + */ + rc = modify_xen_mappings((unsigned long)&__ro_after_init_start, + (unsigned long)&__ro_after_init_end, + REGION_HYPERVISOR_RO); + if ( rc ) + panic("mpu: Unable to mark the .data.ro_after_init section read-only (rc = %d)\n", + rc); + + rc = reorder_xen_mpumap(); + if ( rc ) + panic("mpu: Failed to reorder Xen MPU memory mapping (rc = %d)\n", rc); +} + /* * Local variables: * mode: C -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 13 05:36:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 05:36:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476626.739053 (Exim 4.92) (envelope-from ) id 1pGCjl-0005wq-Fa; Fri, 13 Jan 2023 05:36:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476626.739053; Fri, 13 Jan 2023 05:36:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCjk-0005sH-Q6; Fri, 13 Jan 2023 05:36:20 +0000 Received: by outflank-mailman (input) for mailman id 476626; Fri, 13 Jan 2023 05:36:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCeK-0005sJ-LY for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 05:30:44 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 6c024867-9303-11ed-91b6-6bf2151ebd3b; Fri, 13 Jan 2023 06:30:42 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4BB60FEC; Thu, 12 Jan 2023 21:31:24 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 8D3473F587; Thu, 12 Jan 2023 21:30:39 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6c024867-9303-11ed-91b6-6bf2151ebd3b From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v2 21/40] xen/arm: move MMU-specific setup_mm to setup_mmu.c Date: Fri, 13 Jan 2023 13:28:54 +0800 Message-Id: <20230113052914.3845596-22-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230113052914.3845596-1-Penny.Zheng@arm.com> References: <20230113052914.3845596-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit setup_mm is used for Xen to setup memory management subsystem, like boot allocator, direct-mapping, xenheap, frametable and static memory pages. We could inherit some components seamlessly in MPU system like boot allocator, whilst we need to implement some components differently in MPU, like xenheap, and some components could not be applied in MPU system, like direct-mapping. In the commit, we move setup_mm and its related functions and variables to setup_mmu.c in preparation of implementing MPU version of setup_mm later in future commits Signed-off-by: Penny Zheng Signed-off-by: Wei Chen --- xen/arch/arm/Makefile | 3 + xen/arch/arm/include/asm/setup.h | 5 + xen/arch/arm/setup.c | 326 +--------------------------- xen/arch/arm/setup_mmu.c | 350 +++++++++++++++++++++++++++++++ 4 files changed, 362 insertions(+), 322 deletions(-) create mode 100644 xen/arch/arm/setup_mmu.c diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile index 21188b207f..adeb17b7ab 100644 --- a/xen/arch/arm/Makefile +++ b/xen/arch/arm/Makefile @@ -51,6 +51,9 @@ obj-y += physdev.o obj-y += processor.o obj-y += psci.o obj-y += setup.o +ifneq ($(CONFIG_HAS_MPU), y) +obj-y += setup_mmu.o +endif obj-y += shutdown.o obj-y += smp.o obj-y += smpboot.o diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index 4f39a1aa0a..8f353b67f8 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -158,6 +158,11 @@ struct bootcmdline *boot_cmdline_find_by_kind(bootmodule_kind kind); struct bootcmdline * boot_cmdline_find_by_name(const char *name); const char *boot_module_kind_as_string(bootmodule_kind kind); +extern void init_pdx(void); +extern void init_staticmem_pages(void); +extern void populate_boot_allocator(void); +extern void setup_mm(void); + extern uint32_t hyp_traps_vector[]; void init_traps(void); diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index d7d200179c..3ebf9e9a5c 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -2,7 +2,7 @@ /* * xen/arch/arm/setup.c * - * Early bringup code for an ARMv7-A with virt extensions. + * Early bringup code for an ARMv7-A/ARM64v8R with virt extensions. * * Tim Deegan * Copyright (c) 2011 Citrix Systems. @@ -57,11 +57,6 @@ struct cpuinfo_arm __read_mostly system_cpuinfo; bool __read_mostly acpi_disabled; #endif -#ifdef CONFIG_ARM_32 -static unsigned long opt_xenheap_megabytes __initdata; -integer_param("xenheap_megabytes", opt_xenheap_megabytes); -#endif - domid_t __read_mostly max_init_domid; static __used void init_done(void) @@ -455,138 +450,6 @@ static void * __init relocate_fdt(paddr_t dtb_paddr, size_t dtb_size) return fdt; } -#ifdef CONFIG_ARM_32 -/* - * Returns the end address of the highest region in the range s..e - * with required size and alignment that does not conflict with the - * modules from first_mod to nr_modules. - * - * For non-recursive callers first_mod should normally be 0 (all - * modules and Xen itself) or 1 (all modules but not Xen). - */ -static paddr_t __init consider_modules(paddr_t s, paddr_t e, - uint32_t size, paddr_t align, - int first_mod) -{ - const struct bootmodules *mi = &bootinfo.modules; - int i; - int nr; - - s = (s+align-1) & ~(align-1); - e = e & ~(align-1); - - if ( s > e || e - s < size ) - return 0; - - /* First check the boot modules */ - for ( i = first_mod; i < mi->nr_mods; i++ ) - { - paddr_t mod_s = mi->module[i].start; - paddr_t mod_e = mod_s + mi->module[i].size; - - if ( s < mod_e && mod_s < e ) - { - mod_e = consider_modules(mod_e, e, size, align, i+1); - if ( mod_e ) - return mod_e; - - return consider_modules(s, mod_s, size, align, i+1); - } - } - - /* Now check any fdt reserved areas. */ - - nr = fdt_num_mem_rsv(device_tree_flattened); - - for ( ; i < mi->nr_mods + nr; i++ ) - { - paddr_t mod_s, mod_e; - - if ( fdt_get_mem_rsv(device_tree_flattened, - i - mi->nr_mods, - &mod_s, &mod_e ) < 0 ) - /* If we can't read it, pretend it doesn't exist... */ - continue; - - /* fdt_get_mem_rsv returns length */ - mod_e += mod_s; - - if ( s < mod_e && mod_s < e ) - { - mod_e = consider_modules(mod_e, e, size, align, i+1); - if ( mod_e ) - return mod_e; - - return consider_modules(s, mod_s, size, align, i+1); - } - } - - /* - * i is the current bootmodule we are evaluating, across all - * possible kinds of bootmodules. - * - * When retrieving the corresponding reserved-memory addresses, we - * need to index the bootinfo.reserved_mem bank starting from 0, and - * only counting the reserved-memory modules. Hence, we need to use - * i - nr. - */ - nr += mi->nr_mods; - for ( ; i - nr < bootinfo.reserved_mem.nr_banks; i++ ) - { - paddr_t r_s = bootinfo.reserved_mem.bank[i - nr].start; - paddr_t r_e = r_s + bootinfo.reserved_mem.bank[i - nr].size; - - if ( s < r_e && r_s < e ) - { - r_e = consider_modules(r_e, e, size, align, i + 1); - if ( r_e ) - return r_e; - - return consider_modules(s, r_s, size, align, i + 1); - } - } - return e; -} - -/* - * Find a contiguous region that fits in the static heap region with - * required size and alignment, and return the end address of the region - * if found otherwise 0. - */ -static paddr_t __init fit_xenheap_in_static_heap(uint32_t size, paddr_t align) -{ - unsigned int i; - paddr_t end = 0, aligned_start, aligned_end; - paddr_t bank_start, bank_size, bank_end; - - for ( i = 0 ; i < bootinfo.reserved_mem.nr_banks; i++ ) - { - if ( bootinfo.reserved_mem.bank[i].type != MEMBANK_STATIC_HEAP ) - continue; - - bank_start = bootinfo.reserved_mem.bank[i].start; - bank_size = bootinfo.reserved_mem.bank[i].size; - bank_end = bank_start + bank_size; - - if ( bank_size < size ) - continue; - - aligned_end = bank_end & ~(align - 1); - aligned_start = (aligned_end - size) & ~(align - 1); - - if ( aligned_start > bank_start ) - /* - * Allocate the xenheap as high as possible to keep low-memory - * available (assuming the admin supplied region below 4GB) - * for other use (e.g. domain memory allocation). - */ - end = max(end, aligned_end); - } - - return end; -} -#endif - /* * Return the end of the non-module region starting at s. In other * words return s the start of the next modules after s. @@ -621,7 +484,7 @@ static paddr_t __init next_module(paddr_t s, paddr_t *end) return lowest; } -static void __init init_pdx(void) +void __init init_pdx(void) { paddr_t bank_start, bank_size, bank_end; @@ -666,7 +529,7 @@ static void __init init_pdx(void) } /* Static memory initialization */ -static void __init init_staticmem_pages(void) +void __init init_staticmem_pages(void) { #ifdef CONFIG_STATIC_MEMORY unsigned int bank; @@ -700,7 +563,7 @@ static void __init init_staticmem_pages(void) * allocator with the corresponding regions only, but with Xenheap excluded * on arm32. */ -static void __init populate_boot_allocator(void) +void __init populate_boot_allocator(void) { unsigned int i; const struct meminfo *banks = &bootinfo.mem; @@ -769,187 +632,6 @@ static void __init populate_boot_allocator(void) } } -#ifdef CONFIG_ARM_32 -static void __init setup_mm(void) -{ - paddr_t ram_start, ram_end, ram_size, e, bank_start, bank_end, bank_size; - paddr_t static_heap_end = 0, static_heap_size = 0; - unsigned long heap_pages, xenheap_pages, domheap_pages; - unsigned int i; - const uint32_t ctr = READ_CP32(CTR); - - if ( !bootinfo.mem.nr_banks ) - panic("No memory bank\n"); - - /* We only supports instruction caches implementing the IVIPT extension. */ - if ( ((ctr >> CTR_L1IP_SHIFT) & CTR_L1IP_MASK) == ICACHE_POLICY_AIVIVT ) - panic("AIVIVT instruction cache not supported\n"); - - init_pdx(); - - ram_start = bootinfo.mem.bank[0].start; - ram_size = bootinfo.mem.bank[0].size; - ram_end = ram_start + ram_size; - - for ( i = 1; i < bootinfo.mem.nr_banks; i++ ) - { - bank_start = bootinfo.mem.bank[i].start; - bank_size = bootinfo.mem.bank[i].size; - bank_end = bank_start + bank_size; - - ram_size = ram_size + bank_size; - ram_start = min(ram_start,bank_start); - ram_end = max(ram_end,bank_end); - } - - total_pages = ram_size >> PAGE_SHIFT; - - if ( bootinfo.static_heap ) - { - for ( i = 0 ; i < bootinfo.reserved_mem.nr_banks; i++ ) - { - if ( bootinfo.reserved_mem.bank[i].type != MEMBANK_STATIC_HEAP ) - continue; - - bank_start = bootinfo.reserved_mem.bank[i].start; - bank_size = bootinfo.reserved_mem.bank[i].size; - bank_end = bank_start + bank_size; - - static_heap_size += bank_size; - static_heap_end = max(static_heap_end, bank_end); - } - - heap_pages = static_heap_size >> PAGE_SHIFT; - } - else - heap_pages = total_pages; - - /* - * If the user has not requested otherwise via the command line - * then locate the xenheap using these constraints: - * - * - must be contiguous - * - must be 32 MiB aligned - * - must not include Xen itself or the boot modules - * - must be at most 1GB or 1/32 the total RAM in the system (or static - heap if enabled) if less - * - must be at least 32M - * - * We try to allocate the largest xenheap possible within these - * constraints. - */ - if ( opt_xenheap_megabytes ) - xenheap_pages = opt_xenheap_megabytes << (20-PAGE_SHIFT); - else - { - xenheap_pages = (heap_pages/32 + 0x1fffUL) & ~0x1fffUL; - xenheap_pages = max(xenheap_pages, 32UL<<(20-PAGE_SHIFT)); - xenheap_pages = min(xenheap_pages, 1UL<<(30-PAGE_SHIFT)); - } - - do - { - e = bootinfo.static_heap ? - fit_xenheap_in_static_heap(pfn_to_paddr(xenheap_pages), MB(32)) : - consider_modules(ram_start, ram_end, - pfn_to_paddr(xenheap_pages), - 32<<20, 0); - if ( e ) - break; - - xenheap_pages >>= 1; - } while ( !opt_xenheap_megabytes && xenheap_pages > 32<<(20-PAGE_SHIFT) ); - - if ( ! e ) - panic("Not enough space for xenheap\n"); - - domheap_pages = heap_pages - xenheap_pages; - - printk("Xen heap: %"PRIpaddr"-%"PRIpaddr" (%lu pages%s)\n", - e - (pfn_to_paddr(xenheap_pages)), e, xenheap_pages, - opt_xenheap_megabytes ? ", from command-line" : ""); - printk("Dom heap: %lu pages\n", domheap_pages); - - /* - * We need some memory to allocate the page-tables used for the - * directmap mappings. So populate the boot allocator first. - * - * This requires us to set directmap_mfn_{start, end} first so the - * direct-mapped Xenheap region can be avoided. - */ - directmap_mfn_start = _mfn((e >> PAGE_SHIFT) - xenheap_pages); - directmap_mfn_end = mfn_add(directmap_mfn_start, xenheap_pages); - - populate_boot_allocator(); - - setup_directmap_mappings(mfn_x(directmap_mfn_start), xenheap_pages); - - /* Frame table covers all of RAM region, including holes */ - setup_frametable_mappings(ram_start, ram_end); - max_page = PFN_DOWN(ram_end); - - /* - * The allocators may need to use map_domain_page() (such as for - * scrubbing pages). So we need to prepare the domheap area first. - */ - if ( !init_domheap_mappings(smp_processor_id()) ) - panic("CPU%u: Unable to prepare the domheap page-tables\n", - smp_processor_id()); - - /* Add xenheap memory that was not already added to the boot allocator. */ - init_xenheap_pages(mfn_to_maddr(directmap_mfn_start), - mfn_to_maddr(directmap_mfn_end)); - - init_staticmem_pages(); -} -#else /* CONFIG_ARM_64 */ -static void __init setup_mm(void) -{ - const struct meminfo *banks = &bootinfo.mem; - paddr_t ram_start = INVALID_PADDR; - paddr_t ram_end = 0; - paddr_t ram_size = 0; - unsigned int i; - - init_pdx(); - - /* - * We need some memory to allocate the page-tables used for the directmap - * mappings. But some regions may contain memory already allocated - * for other uses (e.g. modules, reserved-memory...). - * - * For simplicity, add all the free regions in the boot allocator. - */ - populate_boot_allocator(); - - total_pages = 0; - - for ( i = 0; i < banks->nr_banks; i++ ) - { - const struct membank *bank = &banks->bank[i]; - paddr_t bank_end = bank->start + bank->size; - - ram_size = ram_size + bank->size; - ram_start = min(ram_start, bank->start); - ram_end = max(ram_end, bank_end); - - setup_directmap_mappings(PFN_DOWN(bank->start), - PFN_DOWN(bank->size)); - } - - total_pages += ram_size >> PAGE_SHIFT; - - directmap_virt_end = XENHEAP_VIRT_START + ram_end - ram_start; - directmap_mfn_start = maddr_to_mfn(ram_start); - directmap_mfn_end = maddr_to_mfn(ram_end); - - setup_frametable_mappings(ram_start, ram_end); - max_page = PFN_DOWN(ram_end); - - init_staticmem_pages(); -} -#endif - static bool __init is_dom0less_mode(void) { struct bootmodules *mods = &bootinfo.modules; diff --git a/xen/arch/arm/setup_mmu.c b/xen/arch/arm/setup_mmu.c new file mode 100644 index 0000000000..7e5d87f8bd --- /dev/null +++ b/xen/arch/arm/setup_mmu.c @@ -0,0 +1,350 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * xen/arch/arm/setup_mmu.c + * + * Early bringup code for an ARMv7-A with virt extensions. + * + * Tim Deegan + * Copyright (c) 2011 Citrix Systems. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include +#include +#include +#include +#include +#include +#include + +#ifdef CONFIG_ARM_32 +static unsigned long opt_xenheap_megabytes __initdata; +integer_param("xenheap_megabytes", opt_xenheap_megabytes); + +/* + * Returns the end address of the highest region in the range s..e + * with required size and alignment that does not conflict with the + * modules from first_mod to nr_modules. + * + * For non-recursive callers first_mod should normally be 0 (all + * modules and Xen itself) or 1 (all modules but not Xen). + */ +static paddr_t __init consider_modules(paddr_t s, paddr_t e, + uint32_t size, paddr_t align, + int first_mod) +{ + const struct bootmodules *mi = &bootinfo.modules; + int i; + int nr; + + s = (s+align-1) & ~(align-1); + e = e & ~(align-1); + + if ( s > e || e - s < size ) + return 0; + + /* First check the boot modules */ + for ( i = first_mod; i < mi->nr_mods; i++ ) + { + paddr_t mod_s = mi->module[i].start; + paddr_t mod_e = mod_s + mi->module[i].size; + + if ( s < mod_e && mod_s < e ) + { + mod_e = consider_modules(mod_e, e, size, align, i+1); + if ( mod_e ) + return mod_e; + + return consider_modules(s, mod_s, size, align, i+1); + } + } + + /* Now check any fdt reserved areas. */ + + nr = fdt_num_mem_rsv(device_tree_flattened); + + for ( ; i < mi->nr_mods + nr; i++ ) + { + paddr_t mod_s, mod_e; + + if ( fdt_get_mem_rsv(device_tree_flattened, + i - mi->nr_mods, + &mod_s, &mod_e ) < 0 ) + /* If we can't read it, pretend it doesn't exist... */ + continue; + + /* fdt_get_mem_rsv returns length */ + mod_e += mod_s; + + if ( s < mod_e && mod_s < e ) + { + mod_e = consider_modules(mod_e, e, size, align, i+1); + if ( mod_e ) + return mod_e; + + return consider_modules(s, mod_s, size, align, i+1); + } + } + + /* + * i is the current bootmodule we are evaluating, across all + * possible kinds of bootmodules. + * + * When retrieving the corresponding reserved-memory addresses, we + * need to index the bootinfo.reserved_mem bank starting from 0, and + * only counting the reserved-memory modules. Hence, we need to use + * i - nr. + */ + nr += mi->nr_mods; + for ( ; i - nr < bootinfo.reserved_mem.nr_banks; i++ ) + { + paddr_t r_s = bootinfo.reserved_mem.bank[i - nr].start; + paddr_t r_e = r_s + bootinfo.reserved_mem.bank[i - nr].size; + + if ( s < r_e && r_s < e ) + { + r_e = consider_modules(r_e, e, size, align, i + 1); + if ( r_e ) + return r_e; + + return consider_modules(s, r_s, size, align, i + 1); + } + } + return e; +} + +/* + * Find a contiguous region that fits in the static heap region with + * required size and alignment, and return the end address of the region + * if found otherwise 0. + */ +static paddr_t __init fit_xenheap_in_static_heap(uint32_t size, paddr_t align) +{ + unsigned int i; + paddr_t end = 0, aligned_start, aligned_end; + paddr_t bank_start, bank_size, bank_end; + + for ( i = 0 ; i < bootinfo.reserved_mem.nr_banks; i++ ) + { + if ( bootinfo.reserved_mem.bank[i].type != MEMBANK_STATIC_HEAP ) + continue; + + bank_start = bootinfo.reserved_mem.bank[i].start; + bank_size = bootinfo.reserved_mem.bank[i].size; + bank_end = bank_start + bank_size; + + if ( bank_size < size ) + continue; + + aligned_end = bank_end & ~(align - 1); + aligned_start = (aligned_end - size) & ~(align - 1); + + if ( aligned_start > bank_start ) + /* + * Allocate the xenheap as high as possible to keep low-memory + * available (assuming the admin supplied region below 4GB) + * for other use (e.g. domain memory allocation). + */ + end = max(end, aligned_end); + } + + return end; +} + +void __init setup_mm(void) +{ + paddr_t ram_start, ram_end, ram_size, e, bank_start, bank_end, bank_size; + paddr_t static_heap_end = 0, static_heap_size = 0; + unsigned long heap_pages, xenheap_pages, domheap_pages; + unsigned int i; + const uint32_t ctr = READ_CP32(CTR); + + if ( !bootinfo.mem.nr_banks ) + panic("No memory bank\n"); + + /* We only supports instruction caches implementing the IVIPT extension. */ + if ( ((ctr >> CTR_L1IP_SHIFT) & CTR_L1IP_MASK) == ICACHE_POLICY_AIVIVT ) + panic("AIVIVT instruction cache not supported\n"); + + init_pdx(); + + ram_start = bootinfo.mem.bank[0].start; + ram_size = bootinfo.mem.bank[0].size; + ram_end = ram_start + ram_size; + + for ( i = 1; i < bootinfo.mem.nr_banks; i++ ) + { + bank_start = bootinfo.mem.bank[i].start; + bank_size = bootinfo.mem.bank[i].size; + bank_end = bank_start + bank_size; + + ram_size = ram_size + bank_size; + ram_start = min(ram_start,bank_start); + ram_end = max(ram_end,bank_end); + } + + total_pages = ram_size >> PAGE_SHIFT; + + if ( bootinfo.static_heap ) + { + for ( i = 0 ; i < bootinfo.reserved_mem.nr_banks; i++ ) + { + if ( bootinfo.reserved_mem.bank[i].type != MEMBANK_STATIC_HEAP ) + continue; + + bank_start = bootinfo.reserved_mem.bank[i].start; + bank_size = bootinfo.reserved_mem.bank[i].size; + bank_end = bank_start + bank_size; + + static_heap_size += bank_size; + static_heap_end = max(static_heap_end, bank_end); + } + + heap_pages = static_heap_size >> PAGE_SHIFT; + } + else + heap_pages = total_pages; + + /* + * If the user has not requested otherwise via the command line + * then locate the xenheap using these constraints: + * + * - must be contiguous + * - must be 32 MiB aligned + * - must not include Xen itself or the boot modules + * - must be at most 1GB or 1/32 the total RAM in the system (or static + heap if enabled) if less + * - must be at least 32M + * + * We try to allocate the largest xenheap possible within these + * constraints. + */ + if ( opt_xenheap_megabytes ) + xenheap_pages = opt_xenheap_megabytes << (20-PAGE_SHIFT); + else + { + xenheap_pages = (heap_pages/32 + 0x1fffUL) & ~0x1fffUL; + xenheap_pages = max(xenheap_pages, 32UL<<(20-PAGE_SHIFT)); + xenheap_pages = min(xenheap_pages, 1UL<<(30-PAGE_SHIFT)); + } + + do + { + e = bootinfo.static_heap ? + fit_xenheap_in_static_heap(pfn_to_paddr(xenheap_pages), MB(32)) : + consider_modules(ram_start, ram_end, + pfn_to_paddr(xenheap_pages), + 32<<20, 0); + if ( e ) + break; + + xenheap_pages >>= 1; + } while ( !opt_xenheap_megabytes && xenheap_pages > 32<<(20-PAGE_SHIFT) ); + + if ( ! e ) + panic("Not enough space for xenheap\n"); + + domheap_pages = heap_pages - xenheap_pages; + + printk("Xen heap: %"PRIpaddr"-%"PRIpaddr" (%lu pages%s)\n", + e - (pfn_to_paddr(xenheap_pages)), e, xenheap_pages, + opt_xenheap_megabytes ? ", from command-line" : ""); + printk("Dom heap: %lu pages\n", domheap_pages); + + /* + * We need some memory to allocate the page-tables used for the + * directmap mappings. So populate the boot allocator first. + * + * This requires us to set directmap_mfn_{start, end} first so the + * direct-mapped Xenheap region can be avoided. + */ + directmap_mfn_start = _mfn((e >> PAGE_SHIFT) - xenheap_pages); + directmap_mfn_end = mfn_add(directmap_mfn_start, xenheap_pages); + + populate_boot_allocator(); + + setup_directmap_mappings(mfn_x(directmap_mfn_start), xenheap_pages); + + /* Frame table covers all of RAM region, including holes */ + setup_frametable_mappings(ram_start, ram_end); + max_page = PFN_DOWN(ram_end); + + /* + * The allocators may need to use map_domain_page() (such as for + * scrubbing pages). So we need to prepare the domheap area first. + */ + if ( !init_domheap_mappings(smp_processor_id()) ) + panic("CPU%u: Unable to prepare the domheap page-tables\n", + smp_processor_id()); + + /* Add xenheap memory that was not already added to the boot allocator. */ + init_xenheap_pages(mfn_to_maddr(directmap_mfn_start), + mfn_to_maddr(directmap_mfn_end)); + + init_staticmem_pages(); +} +#else /* CONFIG_ARM_64 */ +void __init setup_mm(void) +{ + const struct meminfo *banks = &bootinfo.mem; + paddr_t ram_start = INVALID_PADDR; + paddr_t ram_end = 0; + paddr_t ram_size = 0; + unsigned int i; + + init_pdx(); + + /* + * We need some memory to allocate the page-tables used for the directmap + * mappings. But some regions may contain memory already allocated + * for other uses (e.g. modules, reserved-memory...). + * + * For simplicity, add all the free regions in the boot allocator. + */ + populate_boot_allocator(); + + total_pages = 0; + + for ( i = 0; i < banks->nr_banks; i++ ) + { + const struct membank *bank = &banks->bank[i]; + paddr_t bank_end = bank->start + bank->size; + + ram_size = ram_size + bank->size; + ram_start = min(ram_start, bank->start); + ram_end = max(ram_end, bank_end); + + setup_directmap_mappings(PFN_DOWN(bank->start), + PFN_DOWN(bank->size)); + } + + total_pages += ram_size >> PAGE_SHIFT; + + directmap_virt_end = XENHEAP_VIRT_START + ram_end - ram_start; + directmap_mfn_start = maddr_to_mfn(ram_start); + directmap_mfn_end = maddr_to_mfn(ram_end); + + setup_frametable_mappings(ram_start, ram_end); + max_page = PFN_DOWN(ram_end); + + init_staticmem_pages(); +} +#endif + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 13 05:36:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 05:36:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476632.739078 (Exim 4.92) (envelope-from ) id 1pGCjp-000782-IB; Fri, 13 Jan 2023 05:36:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476632.739078; Fri, 13 Jan 2023 05:36:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCjp-00076b-A9; Fri, 13 Jan 2023 05:36:25 +0000 Received: by outflank-mailman (input) for mailman id 476632; Fri, 13 Jan 2023 05:36:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCds-0005sP-RV for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 05:30:16 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 5b2e49e9-9303-11ed-b8d0-410ff93cb8f0; Fri, 13 Jan 2023 06:30:14 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 149F913D5; Thu, 12 Jan 2023 21:30:56 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 5679A3F587; Thu, 12 Jan 2023 21:30:11 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5b2e49e9-9303-11ed-b8d0-410ff93cb8f0 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v2 12/40] xen/mpu: introduce helpers for MPU enablement Date: Fri, 13 Jan 2023 13:28:45 +0800 Message-Id: <20230113052914.3845596-13-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230113052914.3845596-1-Penny.Zheng@arm.com> References: <20230113052914.3845596-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit We need a new helper for Xen to enable MPU in boot-time. The new helper is semantically consistent with the original enable_mmu. If the Background region is enabled, then the MPU uses the default memory map as the Background region for generating the memory attributes when MPU is disabled. Since the default memory map of the Armv8-R AArch64 architecture is IMPLEMENTATION DEFINED, we always turn off the Background region. In this patch, we also introduce a neutral name enable_mm for Xen to enable MMU/MPU. This can help us to keep one code flow in head.S Signed-off-by: Penny Zheng Signed-off-by: Wei Chen --- xen/arch/arm/arm64/head.S | 5 +++-- xen/arch/arm/arm64/head_mmu.S | 4 ++-- xen/arch/arm/arm64/head_mpu.S | 19 +++++++++++++++++++ 3 files changed, 24 insertions(+), 4 deletions(-) diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S index 145e3d53dc..7f3f973468 100644 --- a/xen/arch/arm/arm64/head.S +++ b/xen/arch/arm/arm64/head.S @@ -258,7 +258,8 @@ real_start_efi: * and memory regions for MPU systems. */ bl prepare_early_mappings - bl enable_mmu + /* Turn on MMU or MPU */ + bl enable_mm /* We are still in the 1:1 mapping. Jump to the runtime Virtual Address. */ ldr x0, =primary_switched @@ -316,7 +317,7 @@ GLOBAL(init_secondary) bl check_cpu_mode bl cpu_init bl prepare_early_mappings - bl enable_mmu + bl enable_mm /* We are still in the 1:1 mapping. Jump to the runtime Virtual Address. */ ldr x0, =secondary_switched diff --git a/xen/arch/arm/arm64/head_mmu.S b/xen/arch/arm/arm64/head_mmu.S index 2346f755df..b59c40495f 100644 --- a/xen/arch/arm/arm64/head_mmu.S +++ b/xen/arch/arm/arm64/head_mmu.S @@ -217,7 +217,7 @@ ENDPROC(prepare_early_mappings) * * Clobbers x0 - x3 */ -ENTRY(enable_mmu) +ENTRY(enable_mm) PRINT("- Turning on paging -\r\n") /* @@ -239,7 +239,7 @@ ENTRY(enable_mmu) msr SCTLR_EL2, x0 /* now paging is enabled */ isb /* Now, flush the icache */ ret -ENDPROC(enable_mmu) +ENDPROC(enable_mm) /* * Remove the 1:1 map from the page-tables. It is not easy to keep track diff --git a/xen/arch/arm/arm64/head_mpu.S b/xen/arch/arm/arm64/head_mpu.S index 0b97ce4646..e2ac69b0cc 100644 --- a/xen/arch/arm/arm64/head_mpu.S +++ b/xen/arch/arm/arm64/head_mpu.S @@ -315,6 +315,25 @@ ENDPROC(prepare_early_mappings) GLOBAL(_end_boot) +/* + * Enable EL2 MPU and data cache + * If the Background region is enabled, then the MPU uses the default memory + * map as the Background region for generating the memory + * attributes when MPU is disabled. + * Since the default memory map of the Armv8-R AArch64 architecture is + * IMPLEMENTATION DEFINED, we intend to turn off the Background region here. + */ +ENTRY(enable_mm) + mrs x0, SCTLR_EL2 + orr x0, x0, #SCTLR_Axx_ELx_M /* Enable MPU */ + orr x0, x0, #SCTLR_Axx_ELx_C /* Enable D-cache */ + orr x0, x0, #SCTLR_Axx_ELx_WXN /* Enable WXN */ + dsb sy + msr SCTLR_EL2, x0 + isb + ret +ENDPROC(enable_mm) + /* * Local variables: * mode: ASM -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 13 05:36:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 05:36:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476633.739083 (Exim 4.92) (envelope-from ) id 1pGCjq-0007Ix-FE; Fri, 13 Jan 2023 05:36:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476633.739083; Fri, 13 Jan 2023 05:36:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCjq-0007Gx-5P; Fri, 13 Jan 2023 05:36:26 +0000 Received: by outflank-mailman (input) for mailman id 476633; Fri, 13 Jan 2023 05:36:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCen-0005sJ-3P for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 05:31:13 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 7d730806-9303-11ed-91b6-6bf2151ebd3b; Fri, 13 Jan 2023 06:31:12 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 95A01FEC; Thu, 12 Jan 2023 21:31:53 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 90BF33F587; Thu, 12 Jan 2023 21:31:07 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7d730806-9303-11ed-91b6-6bf2151ebd3b From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Penny Zheng Subject: [PATCH v2 30/40] xen/mpu: disable VMAP sub-system for MPU systems Date: Fri, 13 Jan 2023 13:29:03 +0800 Message-Id: <20230113052914.3845596-31-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230113052914.3845596-1-Penny.Zheng@arm.com> References: <20230113052914.3845596-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit VMAP in MMU system, is used to remap a range of normal memory or device memory to another virtual address with new attributes for specific purpose, like ALTERNATIVE feature. Since there is no virtual address translation support in MPU system, we can not support VMAP in MPU system. So in this patch, we disable VMAP for MPU systems, and some features depending on VMAP also need to be disabled at the same time, Like ALTERNATIVE, CPU ERRATA. Signed-off-by: Penny Zheng Signed-off-by: Wei Chen --- xen/arch/arm/Kconfig | 3 +- xen/arch/arm/Makefile | 2 +- xen/arch/arm/include/asm/alternative.h | 15 +++++ xen/arch/arm/include/asm/cpuerrata.h | 12 ++++ xen/arch/arm/setup.c | 7 +++ xen/arch/x86/Kconfig | 1 + xen/common/Kconfig | 3 + xen/common/Makefile | 2 +- xen/include/xen/vmap.h | 81 ++++++++++++++++++++++++-- 9 files changed, 119 insertions(+), 7 deletions(-) diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index c6b6b612d1..9230c8b885 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -11,12 +11,13 @@ config ARM_64 config ARM def_bool y - select HAS_ALTERNATIVE + select HAS_ALTERNATIVE if !ARM_V8R select HAS_DEVICE_TREE select HAS_PASSTHROUGH select HAS_PDX select HAS_PMAP select IOMMU_FORCE_PT_SHARE + select HAS_VMAP if !ARM_V8R config ARCH_DEFCONFIG string diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile index 23dfbc3333..c949661590 100644 --- a/xen/arch/arm/Makefile +++ b/xen/arch/arm/Makefile @@ -10,7 +10,7 @@ obj-$(CONFIG_HAS_VPCI) += vpci.o obj-$(CONFIG_HAS_ALTERNATIVE) += alternative.o obj-y += bootfdt.init.o -obj-y += cpuerrata.o +obj-$(CONFIG_HAS_ALTERNATIVE) += cpuerrata.o obj-y += cpufeature.o obj-y += decode.o obj-y += device.o diff --git a/xen/arch/arm/include/asm/alternative.h b/xen/arch/arm/include/asm/alternative.h index 1eb4b60fbb..bc23d1d34f 100644 --- a/xen/arch/arm/include/asm/alternative.h +++ b/xen/arch/arm/include/asm/alternative.h @@ -8,6 +8,7 @@ #ifndef __ASSEMBLY__ +#include #include #include @@ -28,8 +29,22 @@ typedef void (*alternative_cb_t)(const struct alt_instr *alt, const uint32_t *origptr, uint32_t *updptr, int nr_inst); +#ifdef CONFIG_HAS_ALTERNATIVE void apply_alternatives_all(void); int apply_alternatives(const struct alt_instr *start, const struct alt_instr *end); +#else +static inline void apply_alternatives_all(void) +{ + ASSERT_UNREACHABLE(); +} + +static inline int apply_alternatives(const struct alt_instr *start, + const struct alt_instr *end) +{ + ASSERT_UNREACHABLE(); + return -EINVAL; +} +#endif /* !CONFIG_HAS_ALTERNATIVE */ #define ALTINSTR_ENTRY(feature, cb) \ " .word 661b - .\n" /* label */ \ diff --git a/xen/arch/arm/include/asm/cpuerrata.h b/xen/arch/arm/include/asm/cpuerrata.h index 8d7e7b9375..5d97f33763 100644 --- a/xen/arch/arm/include/asm/cpuerrata.h +++ b/xen/arch/arm/include/asm/cpuerrata.h @@ -4,8 +4,20 @@ #include #include +#ifdef CONFIG_HAS_ALTERNATIVE void check_local_cpu_errata(void); void enable_errata_workarounds(void); +#else +static inline void check_local_cpu_errata(void) +{ + ASSERT_UNREACHABLE(); +} + +static inline void enable_errata_workarounds(void) +{ + ASSERT_UNREACHABLE(); +} +#endif /* !CONFIG_HAS_ALTERNATIVE */ #define CHECK_WORKAROUND_HELPER(erratum, feature, arch) \ static inline bool check_workaround_##erratum(void) \ diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 3ebf9e9a5c..0eac33e68c 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -721,7 +721,9 @@ void __init start_xen(unsigned long boot_phys_offset, */ system_state = SYS_STATE_boot; +#ifdef CONFIG_HAS_VMAP vm_init(); +#endif if ( acpi_disabled ) { @@ -753,11 +755,13 @@ void __init start_xen(unsigned long boot_phys_offset, nr_cpu_ids = smp_get_max_cpus(); printk(XENLOG_INFO "SMP: Allowing %u CPUs\n", nr_cpu_ids); +#ifdef CONFIG_HAS_ALTERNATIVE /* * Some errata relies on SMCCC version which is detected by psci_init() * (called from smp_init_cpus()). */ check_local_cpu_errata(); +#endif check_local_cpu_features(); @@ -824,12 +828,15 @@ void __init start_xen(unsigned long boot_phys_offset, do_initcalls(); + +#ifdef CONFIG_HAS_ALTERNATIVE /* * It needs to be called after do_initcalls to be able to use * stop_machine (tasklets initialized via an initcall). */ apply_alternatives_all(); enable_errata_workarounds(); +#endif enable_cpu_features(); /* Create initial domain 0. */ diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig index 6a7825f4ba..7f072cc603 100644 --- a/xen/arch/x86/Kconfig +++ b/xen/arch/x86/Kconfig @@ -28,6 +28,7 @@ config X86 select HAS_UBSAN select HAS_VPCI if HVM select NEEDS_LIBELF + select HAS_VMAP config ARCH_DEFCONFIG string diff --git a/xen/common/Kconfig b/xen/common/Kconfig index f1ea3199c8..ba16366a4b 100644 --- a/xen/common/Kconfig +++ b/xen/common/Kconfig @@ -61,6 +61,9 @@ config HAS_SCHED_GRANULARITY config HAS_UBSAN bool +config HAS_VMAP + bool + config MEM_ACCESS_ALWAYS_ON bool diff --git a/xen/common/Makefile b/xen/common/Makefile index 9a3a12b12d..9d991effb2 100644 --- a/xen/common/Makefile +++ b/xen/common/Makefile @@ -50,7 +50,7 @@ obj-$(CONFIG_TRACEBUFFER) += trace.o obj-y += version.o obj-y += virtual_region.o obj-y += vm_event.o -obj-y += vmap.o +obj-$(CONFIG_HAS_VMAP) += vmap.o obj-y += vsprintf.o obj-y += wait.o obj-bin-y += warning.init.o diff --git a/xen/include/xen/vmap.h b/xen/include/xen/vmap.h index b0f7632e89..2e3ae0ca6a 100644 --- a/xen/include/xen/vmap.h +++ b/xen/include/xen/vmap.h @@ -1,15 +1,17 @@ -#if !defined(__XEN_VMAP_H__) && defined(VMAP_VIRT_START) +#if !defined(__XEN_VMAP_H__) && (defined(VMAP_VIRT_START) || !defined(CONFIG_HAS_VMAP)) #define __XEN_VMAP_H__ -#include -#include - enum vmap_region { VMAP_DEFAULT, VMAP_XEN, VMAP_REGION_NR, }; +#ifdef CONFIG_HAS_VMAP + +#include +#include + void vm_init_type(enum vmap_region type, void *start, void *end); void *__vmap(const mfn_t *mfn, unsigned int granularity, unsigned int nr, @@ -38,4 +40,75 @@ static inline void vm_init(void) vm_init_type(VMAP_DEFAULT, (void *)VMAP_VIRT_START, arch_vmap_virt_end()); } +#else /* !CONFIG_HAS_VMAP */ + +static inline void vm_init_type(enum vmap_region type, void *start, void *end) +{ + ASSERT_UNREACHABLE(); +} + +static inline void *__vmap(const mfn_t *mfn, unsigned int granularity, + unsigned int nr, unsigned int align, + unsigned int flags, enum vmap_region type) +{ + ASSERT_UNREACHABLE(); + return NULL; +} + +static inline void *vmap(const mfn_t *mfn, unsigned int nr) +{ + ASSERT_UNREACHABLE(); + return NULL; +} + +static inline void vunmap(const void *va) +{ + ASSERT_UNREACHABLE(); +} + +static inline void *vmalloc(size_t size) +{ + ASSERT_UNREACHABLE(); + return NULL; +} + +static inline void *vmalloc_xen(size_t size) +{ + ASSERT_UNREACHABLE(); + return NULL; +} + +static inline void *vzalloc(size_t size) +{ + ASSERT_UNREACHABLE(); + return NULL; +} + +static inline void vfree(void *va) +{ + ASSERT_UNREACHABLE(); +} + +void __iomem *ioremap(paddr_t, size_t) +{ + ASSERT_UNREACHABLE(); + return NULL; +} + +static inline void iounmap(void __iomem *va) +{ + ASSERT_UNREACHABLE(); +} + +static inline void *arch_vmap_virt_end(void) +{ + ASSERT_UNREACHABLE(); + return NULL; +} + +static inline void vm_init(void) +{ + ASSERT_UNREACHABLE(); +} +#endif /* !CONFIG_HAS_VMAP */ #endif /* __XEN_VMAP_H__ */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 13 05:36:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 05:36:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476634.739087 (Exim 4.92) (envelope-from ) id 1pGCjr-0007T3-IN; Fri, 13 Jan 2023 05:36:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476634.739087; Fri, 13 Jan 2023 05:36:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCjr-0007Ow-35; Fri, 13 Jan 2023 05:36:27 +0000 Received: by outflank-mailman (input) for mailman id 476634; Fri, 13 Jan 2023 05:36:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCfN-0005sP-8M for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 05:31:49 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 9291ca8e-9303-11ed-b8d0-410ff93cb8f0; Fri, 13 Jan 2023 06:31:47 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1CA57FEC; Thu, 12 Jan 2023 21:32:29 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id DCB763F587; Thu, 12 Jan 2023 21:31:44 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9291ca8e-9303-11ed-b8d0-410ff93cb8f0 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH] xen/mpu: make Xen boot to idle on MPU systems(DNM) Date: Fri, 13 Jan 2023 13:29:14 +0800 Message-Id: <20230113052914.3845596-42-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230113052914.3845596-1-Penny.Zheng@arm.com> References: <20230113052914.3845596-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Wei Chen As we have not implmented guest support in part#1 series of MPU support, Xen can not create any guest in boot time. So in this patch we make Xen boot to idle on MPU system for reviewer to test part#1 series. THIS PATCH IS ONLY FOR TESTING, NOT FOR REVIEWING. Signed-off-by: Wei Chen --- xen/arch/arm/mm_mpu.c | 3 +++ xen/arch/arm/setup.c | 21 ++++++++++++--------- xen/arch/arm/traps.c | 2 ++ 3 files changed, 17 insertions(+), 9 deletions(-) diff --git a/xen/arch/arm/mm_mpu.c b/xen/arch/arm/mm_mpu.c index 434ed872c1..73d5779ab4 100644 --- a/xen/arch/arm/mm_mpu.c +++ b/xen/arch/arm/mm_mpu.c @@ -32,6 +32,9 @@ #include #include +/* Non-boot CPUs use this to find the correct pagetables. */ +uint64_t init_ttbr; + #ifdef NDEBUG static inline void __attribute__ ((__format__ (__printf__, 1, 2))) diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index b21fc4b8e2..d04ad8f838 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -803,16 +803,19 @@ void __init start_xen(unsigned long boot_phys_offset, #endif enable_cpu_features(); - /* Create initial domain 0. */ - if ( !is_dom0less_mode() ) - create_dom0(); - else - printk(XENLOG_INFO "Xen dom0less mode detected\n"); - - if ( acpi_disabled ) + if ( !IS_ENABLED(CONFIG_ARM_V8R) ) { - create_domUs(); - alloc_static_evtchn(); + /* Create initial domain 0. */ + if ( !is_dom0less_mode() ) + create_dom0(); + else + printk(XENLOG_INFO "Xen dom0less mode detected\n"); + + if ( acpi_disabled ) + { + create_domUs(); + alloc_static_evtchn(); + } } /* diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c index 061c92acbd..2444f7f6d8 100644 --- a/xen/arch/arm/traps.c +++ b/xen/arch/arm/traps.c @@ -963,7 +963,9 @@ void vcpu_show_registers(const struct vcpu *v) ctxt.ifsr32_el2 = v->arch.ifsr; #endif +#ifndef CONFIG_HAS_MPU ctxt.vttbr_el2 = v->domain->arch.p2m.vttbr; +#endif _show_registers(&v->arch.cpu_info->guest_cpu_user_regs, &ctxt, 1, v); } -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 13 05:36:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 05:36:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476636.739098 (Exim 4.92) (envelope-from ) id 1pGCjt-0007mA-R9; Fri, 13 Jan 2023 05:36:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476636.739098; Fri, 13 Jan 2023 05:36:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCjs-0007iT-Ml; Fri, 13 Jan 2023 05:36:28 +0000 Received: by outflank-mailman (input) for mailman id 476636; Fri, 13 Jan 2023 05:36:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCf5-0005sP-Dh for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 05:31:31 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 87c8b44c-9303-11ed-b8d0-410ff93cb8f0; Fri, 13 Jan 2023 06:31:29 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E7EFAFEC; Thu, 12 Jan 2023 21:32:10 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 35CBE3F587; Thu, 12 Jan 2023 21:31:25 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 87c8b44c-9303-11ed-b8d0-410ff93cb8f0 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v2 35/40] xen/mpu: destroy boot modules and early FDT mapping in MPU system Date: Fri, 13 Jan 2023 13:29:08 +0800 Message-Id: <20230113052914.3845596-36-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230113052914.3845596-1-Penny.Zheng@arm.com> References: <20230113052914.3845596-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In MMU system, we will free all memory as boot modules, like kernel initramfs module, into heap, and it is not applicable in MPU system. Heap must be statically configured in Device tree, so it should not change. In MPU system, we destory MPU memory regions of boot modules. In MPU version of remove_early_mappings, we destroy MPU memory region of early FDT mapping. Signed-off-by: Penny Zheng Signed-off-by: Wei Chen --- xen/arch/arm/mm_mpu.c | 4 ++++ xen/arch/arm/setup.c | 25 ------------------------- xen/arch/arm/setup_mmu.c | 25 +++++++++++++++++++++++++ xen/arch/arm/setup_mpu.c | 26 ++++++++++++++++++++++++++ 4 files changed, 55 insertions(+), 25 deletions(-) diff --git a/xen/arch/arm/mm_mpu.c b/xen/arch/arm/mm_mpu.c index de0c7d919a..118bb11d1a 100644 --- a/xen/arch/arm/mm_mpu.c +++ b/xen/arch/arm/mm_mpu.c @@ -854,6 +854,10 @@ void dump_hyp_walk(vaddr_t addr) void __init remove_early_mappings(void) { + /* Earlier, early FDT is mapped with MAX_FDT_SIZE in early_fdt_map */ + if ( destroy_xen_mappings(round_pgdown(dtb_paddr), + round_pgup(dtb_paddr + MAX_FDT_SIZE)) ) + panic("Unable to destroy early Device-Tree mapping.\n"); } int init_secondary_pagetables(int cpu) diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 0eac33e68c..49ba998f68 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -412,31 +412,6 @@ const char * __init boot_module_kind_as_string(bootmodule_kind kind) } } -void __init discard_initial_modules(void) -{ - struct bootmodules *mi = &bootinfo.modules; - int i; - - for ( i = 0; i < mi->nr_mods; i++ ) - { - paddr_t s = mi->module[i].start; - paddr_t e = s + PAGE_ALIGN(mi->module[i].size); - - if ( mi->module[i].kind == BOOTMOD_XEN ) - continue; - - if ( !mfn_valid(maddr_to_mfn(s)) || - !mfn_valid(maddr_to_mfn(e)) ) - continue; - - fw_unreserved_regions(s, e, init_domheap_pages, 0); - } - - mi->nr_mods = 0; - - remove_early_mappings(); -} - /* Relocate the FDT in Xen heap */ static void * __init relocate_fdt(paddr_t dtb_paddr, size_t dtb_size) { diff --git a/xen/arch/arm/setup_mmu.c b/xen/arch/arm/setup_mmu.c index 7e5d87f8bd..611a60633e 100644 --- a/xen/arch/arm/setup_mmu.c +++ b/xen/arch/arm/setup_mmu.c @@ -340,6 +340,31 @@ void __init setup_mm(void) } #endif +void __init discard_initial_modules(void) +{ + struct bootmodules *mi = &bootinfo.modules; + int i; + + for ( i = 0; i < mi->nr_mods; i++ ) + { + paddr_t s = mi->module[i].start; + paddr_t e = s + PAGE_ALIGN(mi->module[i].size); + + if ( mi->module[i].kind == BOOTMOD_XEN ) + continue; + + if ( !mfn_valid(maddr_to_mfn(s)) || + !mfn_valid(maddr_to_mfn(e)) ) + continue; + + fw_unreserved_regions(s, e, init_domheap_pages, 0); + } + + mi->nr_mods = 0; + + remove_early_mappings(); +} + /* * Local variables: * mode: C diff --git a/xen/arch/arm/setup_mpu.c b/xen/arch/arm/setup_mpu.c index f7d74ea604..f47f1f39ee 100644 --- a/xen/arch/arm/setup_mpu.c +++ b/xen/arch/arm/setup_mpu.c @@ -152,6 +152,32 @@ bool __init mpu_memory_section_contains(paddr_t s, paddr_t e, return false; } +void __init discard_initial_modules(void) +{ + unsigned int i = 0; + + /* + * Xenheap in MPU system must be statically configured in FDT in MPU + * system, so its base address and size couldn't change and it could not + * accept freed memory from boot modules. + * Disable MPU memory region of boot module section, since it will be in + * no use after boot. + */ + for ( ; i < mpuinfo.sections[MSINFO_BOOTMODULE].nr_banks; i++ ) + { + paddr_t start = mpuinfo.sections[MSINFO_BOOTMODULE].bank[i].start; + paddr_t size = mpuinfo.sections[MSINFO_BOOTMODULE].bank[i].size; + int rc; + + rc = destroy_xen_mappings(start, start + size); + if ( rc ) + panic("mpu: Unable to destroy boot module section 0x%"PRIpaddr"- 0x%"PRIpaddr"\n", + start, start + size); + } + + remove_early_mappings(); +} + /* * Local variables: * mode: C -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 13 05:36:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 05:36:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476642.739116 (Exim 4.92) (envelope-from ) id 1pGCjy-0000ed-83; Fri, 13 Jan 2023 05:36:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476642.739116; Fri, 13 Jan 2023 05:36:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCjy-0000dE-2Q; Fri, 13 Jan 2023 05:36:34 +0000 Received: by outflank-mailman (input) for mailman id 476642; Fri, 13 Jan 2023 05:36:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCeX-0005sP-BN for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 05:30:57 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 73673be4-9303-11ed-b8d0-410ff93cb8f0; Fri, 13 Jan 2023 06:30:55 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C178BFEC; Thu, 12 Jan 2023 21:31:36 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 0F3863F587; Thu, 12 Jan 2023 21:30:51 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 73673be4-9303-11ed-b8d0-410ff93cb8f0 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v2 25/40] xen/mpu: map MPU guest memory section before static memory initialization Date: Fri, 13 Jan 2023 13:28:58 +0800 Message-Id: <20230113052914.3845596-26-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230113052914.3845596-1-Penny.Zheng@arm.com> References: <20230113052914.3845596-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Previous commit introduces a new device tree property "mpu,guest-memory-section" to define MPU guest memory section, which will mitigate the scattering of statically-configured guest RAM. We only need to set up MPU memory region mapping for MPU guest memory section to have access to all guest RAM. And this should happen before static memory initialization(init_staticmem_pages()) MPU memory region for MPU guest memory secction gets switched out when idle vcpu leaving, to avoid region overlapping if the vcpu enters into guest mode later. On the contrary, it gets switched in when idle vcpu entering. We introduce a bit in region "region.prlar.sw"(struct pr_t region) to indicate this kind of feature. Signed-off-by: Penny Zheng Signed-off-by: Wei Chen --- xen/arch/arm/include/asm/arm64/mpu.h | 14 ++++++--- xen/arch/arm/mm_mpu.c | 47 +++++++++++++++++++++++++--- 2 files changed, 53 insertions(+), 8 deletions(-) diff --git a/xen/arch/arm/include/asm/arm64/mpu.h b/xen/arch/arm/include/asm/arm64/mpu.h index b85e420a90..0044bbf05d 100644 --- a/xen/arch/arm/include/asm/arm64/mpu.h +++ b/xen/arch/arm/include/asm/arm64/mpu.h @@ -45,22 +45,26 @@ * [3:4] Execute Never * [5:6] Access Permission * [7] Region Present - * [8] Boot-only Region + * [8:9] 0b00: Fixed Region; 0b01: Boot-only Region; + * 0b10: Region needs switching out/in during vcpu context switch; */ #define _REGION_AI_BIT 0 #define _REGION_XN_BIT 3 #define _REGION_AP_BIT 5 #define _REGION_PRESENT_BIT 7 -#define _REGION_BOOTONLY_BIT 8 +#define _REGION_TRANSIENT_BIT 8 #define _REGION_XN (2U << _REGION_XN_BIT) #define _REGION_RO (2U << _REGION_AP_BIT) #define _REGION_PRESENT (1U << _REGION_PRESENT_BIT) -#define _REGION_BOOTONLY (1U << _REGION_BOOTONLY_BIT) +#define _REGION_BOOTONLY (1U << _REGION_TRANSIENT_BIT) +#define _REGION_SWITCH (2U << _REGION_TRANSIENT_BIT) #define REGION_AI_MASK(x) (((x) >> _REGION_AI_BIT) & 0x7U) #define REGION_XN_MASK(x) (((x) >> _REGION_XN_BIT) & 0x3U) #define REGION_AP_MASK(x) (((x) >> _REGION_AP_BIT) & 0x3U) #define REGION_RO_MASK(x) (((x) >> _REGION_AP_BIT) & 0x2U) #define REGION_BOOTONLY_MASK(x) (((x) >> _REGION_BOOTONLY_BIT) & 0x1U) +#define REGION_SWITCH_MASK(x) (((x) >> _REGION_TRANSIENT_BIT) & 0x2U) +#define REGION_TRANSIENT_MASK(x) (((x) >> _REGION_TRANSIENT_BIT) & 0x3U) /* * _REGION_NORMAL is convenience define. It is not meant to be used @@ -73,6 +77,7 @@ #define REGION_HYPERVISOR REGION_HYPERVISOR_RW #define REGION_HYPERVISOR_BOOT (REGION_HYPERVISOR_RW|_REGION_BOOTONLY) +#define REGION_HYPERVISOR_SWITCH (REGION_HYPERVISOR_RW|_REGION_SWITCH) #define INVALID_REGION (~0UL) @@ -98,7 +103,8 @@ typedef union { unsigned long ns:1; /* Not-Secure */ unsigned long res:1; /* Reserved 0 by hardware */ unsigned long limit:42; /* Limit Address */ - unsigned long pad:16; + unsigned long pad:15; + unsigned long sw:1; /* Region gets switched out/in during vcpu context switch? */ } reg; uint64_t bits; } prlar_t; diff --git a/xen/arch/arm/mm_mpu.c b/xen/arch/arm/mm_mpu.c index 7b282be4fb..d2e19e836c 100644 --- a/xen/arch/arm/mm_mpu.c +++ b/xen/arch/arm/mm_mpu.c @@ -71,6 +71,10 @@ static paddr_t dtb_paddr; struct page_info *frame_table; +static const unsigned int mpu_section_mattr[MSINFO_MAX] = { + REGION_HYPERVISOR_SWITCH, +}; + /* Write a MPU protection region */ #define WRITE_PROTECTION_REGION(sel, pr, prbar_el2, prlar_el2) ({ \ uint64_t _sel = sel; \ @@ -414,10 +418,13 @@ static int xen_mpumap_update_entry(paddr_t base, paddr_t limit, if ( system_state <= SYS_STATE_active ) { /* - * If it is a boot-only region (i.e. region for early FDT), - * it shall be added from the tail for late init re-organizing + * If it is a transient region, including boot-only region + * (i.e. region for early FDT), and region which needs switching + * in/out during vcpu context switch(i.e. region for guest memory + * section), it shall be added from the tail for late init + * re-organizing */ - if ( REGION_BOOTONLY_MASK(flags) ) + if ( REGION_TRANSIENT_MASK(flags) ) idx = next_transient_region_idx; else idx = next_fixed_region_idx; @@ -427,6 +434,13 @@ static int xen_mpumap_update_entry(paddr_t base, paddr_t limit, /* Set permission */ xen_mpumap[idx].prbar.reg.ap = REGION_AP_MASK(flags); xen_mpumap[idx].prbar.reg.xn = REGION_XN_MASK(flags); + /* + * Bit sw indicates that region gets switched out when idle vcpu + * leaving hypervisor mode, and region gets switched in when idle vcpu + * entering hypervisor mode. + */ + if ( REGION_SWITCH_MASK(flags) ) + xen_mpumap[idx].prlar.reg.sw = 1; /* Update and enable the region */ access_protection_region(false, NULL, (const pr_t*)(&xen_mpumap[idx]), @@ -552,6 +566,29 @@ static void __init setup_staticheap_mappings(void) } } +static void __init map_mpu_memory_section_on_boot(enum mpu_section_info type, + unsigned int flags) +{ + unsigned int i = 0; + + for ( ; i < mpuinfo.sections[type].nr_banks; i++ ) + { + paddr_t start = round_pgup( + mpuinfo.sections[type].bank[i].start); + paddr_t size = round_pgdown(mpuinfo.sections[type].bank[i].size); + + /* + * Map MPU memory section with transient MPU memory region, + * as they are either boot-only, or will be switched out/in + * during vcpu context switch(i.e. guest memory section). + */ + if ( map_pages_to_xen(start, maddr_to_mfn(start), size >> PAGE_SHIFT, + flags) ) + panic("mpu: failed to map MPU memory section %s\n", + mpu_section_info_str[type]); + } +} + /* * System RAM is statically partitioned into different functionality * section in Device Tree, including static xenheap, guest memory @@ -563,7 +600,9 @@ void __init setup_static_mappings(void) { setup_staticheap_mappings(); - /* TODO: guest memory section, device memory section, boot-module section, etc */ + for ( uint8_t i = MSINFO_GUEST; i < MSINFO_MAX; i++ ) + map_mpu_memory_section_on_boot(i, mpu_section_mattr[i]); + /* TODO: device memory section, boot-module section, etc */ } /* Map a frame table to cover physical addresses ps through pe */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 13 05:36:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 05:36:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476650.739133 (Exim 4.92) (envelope-from ) id 1pGCk2-0001aL-3K; Fri, 13 Jan 2023 05:36:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476650.739133; Fri, 13 Jan 2023 05:36:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCk1-0001YR-Ub; Fri, 13 Jan 2023 05:36:37 +0000 Received: by outflank-mailman (input) for mailman id 476650; Fri, 13 Jan 2023 05:36:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCeT-0005sJ-63 for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 05:30:53 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 71a1f7f5-9303-11ed-91b6-6bf2151ebd3b; Fri, 13 Jan 2023 06:30:52 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A77B5FEC; Thu, 12 Jan 2023 21:31:33 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id E97423F587; Thu, 12 Jan 2023 21:30:48 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 71a1f7f5-9303-11ed-91b6-6bf2151ebd3b From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v2 24/40] xen/mpu: introduce "mpu,xxx-memory-section" Date: Fri, 13 Jan 2023 13:28:57 +0800 Message-Id: <20230113052914.3845596-25-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230113052914.3845596-1-Penny.Zheng@arm.com> References: <20230113052914.3845596-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In MPU system, all kinds of resources, including system resource and domain resource must be statically configured in Device Tree, i.e, guest RAM must be statically allocated through "xen,static-mem" property under domain node. However, due to limited MPU protection regions and a wide variety of resource, we could easily exhaust all MPU protection regions very quickly. So we want to introduce a set of new property, "#mpu,xxx-memory-section" to mitigate the impact. Each property limits the available host address range of one kind of system/domain resource. This commit also introduces "#mpu,guest-memory-section" as an example, for limiting the scattering of static memory as guest RAM. Guest RAM shall be not only statically configured through "xen,static-mem" property in MPU system, but also shall be defined inside outside "mpu,guest-memory-section". Signed-off-by: Penny Zheng Signed-off-by: Wei Chen --- xen/arch/arm/bootfdt.c | 13 ++++--- xen/arch/arm/include/asm/setup.h | 24 +++++++++++++ xen/arch/arm/setup_mpu.c | 58 ++++++++++++++++++++++++++++++++ 3 files changed, 91 insertions(+), 4 deletions(-) diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c index 0085c28d74..d7a5dd0ede 100644 --- a/xen/arch/arm/bootfdt.c +++ b/xen/arch/arm/bootfdt.c @@ -59,10 +59,10 @@ void __init device_tree_get_reg(const __be32 **cell, u32 address_cells, *size = dt_next_cell(size_cells, cell); } -static int __init device_tree_get_meminfo(const void *fdt, int node, - const char *prop_name, - u32 address_cells, u32 size_cells, - void *data, enum membank_type type) +int __init device_tree_get_meminfo(const void *fdt, int node, + const char *prop_name, + u32 address_cells, u32 size_cells, + void *data, enum membank_type type) { const struct fdt_property *prop; unsigned int i, banks; @@ -315,6 +315,11 @@ static int __init process_chosen_node(const void *fdt, int node, bootinfo.static_heap = true; } +#ifdef CONFIG_HAS_MPU + if ( process_mpuinfo(fdt, node, address_cells, size_cells) ) + return -EINVAL; +#endif + printk("Checking for initrd in /chosen\n"); prop = fdt_get_property(fdt, node, "linux,initrd-start", &len); diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index 8f353b67f8..3581f8f990 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -172,6 +172,11 @@ void device_tree_get_reg(const __be32 **cell, u32 address_cells, u32 device_tree_get_u32(const void *fdt, int node, const char *prop_name, u32 dflt); +int device_tree_get_meminfo(const void *fdt, int node, + const char *prop_name, + u32 address_cells, u32 size_cells, + void *data, enum membank_type type); + int map_range_to_domain(const struct dt_device_node *dev, u64 addr, u64 len, void *data); @@ -185,6 +190,25 @@ struct init_info unsigned int cpuid; }; +#ifdef CONFIG_HAS_MPU +/* Index of MPU memory section */ +enum mpu_section_info { + MSINFO_GUEST, + MSINFO_MAX +}; + +extern const char *mpu_section_info_str[MSINFO_MAX]; + +struct mpuinfo { + struct meminfo sections[MSINFO_MAX]; +}; + +extern struct mpuinfo mpuinfo; + +extern int process_mpuinfo(const void *fdt, int node, uint32_t address_cells, + uint32_t size_cells); +#endif /* CONFIG_HAS_MPU */ + #endif /* * Local variables: diff --git a/xen/arch/arm/setup_mpu.c b/xen/arch/arm/setup_mpu.c index ca0d8237d5..09a38a34a4 100644 --- a/xen/arch/arm/setup_mpu.c +++ b/xen/arch/arm/setup_mpu.c @@ -20,12 +20,70 @@ */ #include +#include #include #include #include #include #include +const char *mpu_section_info_str[MSINFO_MAX] = { + "mpu,guest-memory-section", +}; + +/* + * mpuinfo stores mpu memory section info, which is configured under + * "mpu,xxx-memory-section" in Device Tree. + */ +struct mpuinfo __initdata mpuinfo; + +/* + * Due to limited MPU protection regions and a wide variety of resource, + * "#mpu,xxx-memory-section" is introduced to mitigate the impact. + * Each property limits the available host address range of one kind of + * system/domain resource. + * + * "mpu,guest-memory-section": guest RAM must be statically allocated + * through "xen,static-mem" property in MPU system. "mpu,guest-memory-section" + * limits the scattering of "xen,static-mem", as users could not define + * a "xen,static-mem" outside "mpu,guest-memory-section". + */ +static int __init process_mpu_memory_section(const void *fdt, int node, + const char *name, void *data, + uint32_t address_cells, + uint32_t size_cells) +{ + if ( !fdt_get_property(fdt, node, name, NULL) ) + return -EINVAL; + + return device_tree_get_meminfo(fdt, node, name, address_cells, size_cells, + data, MEMBANK_DEFAULT); +} + +int __init process_mpuinfo(const void *fdt, int node, + uint32_t address_cells, uint32_t size_cells) +{ + uint8_t idx = 0; + const char *prop_name; + + for ( ; idx < MSINFO_MAX; idx++ ) + { + prop_name = mpu_section_info_str[idx]; + + printk("Checking for %s in /chosen\n", prop_name); + + if ( process_mpu_memory_section(fdt, node, prop_name, + &mpuinfo.sections[idx], + address_cells, size_cells) ) + { + printk(XENLOG_ERR "fdt: failed to process %s\n", prop_name); + return -EINVAL; + } + } + + return 0; +} + void __init setup_mm(void) { paddr_t ram_start = ~0, ram_end = 0, ram_size = 0; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 13 05:36:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 05:36:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476652.739139 (Exim 4.92) (envelope-from ) id 1pGCk2-0001if-T2; Fri, 13 Jan 2023 05:36:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476652.739139; Fri, 13 Jan 2023 05:36:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCk2-0001gS-Ip; Fri, 13 Jan 2023 05:36:38 +0000 Received: by outflank-mailman (input) for mailman id 476652; Fri, 13 Jan 2023 05:36:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGCeg-0005sP-Hr for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 05:31:06 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 78f4a527-9303-11ed-b8d0-410ff93cb8f0; Fri, 13 Jan 2023 06:31:04 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1B20FFEC; Thu, 12 Jan 2023 21:31:46 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 5C9923F587; Thu, 12 Jan 2023 21:31:01 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 78f4a527-9303-11ed-b8d0-410ff93cb8f0 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v2 28/40] xen/mpu: map boot module section in MPU system Date: Fri, 13 Jan 2023 13:29:01 +0800 Message-Id: <20230113052914.3845596-29-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230113052914.3845596-1-Penny.Zheng@arm.com> References: <20230113052914.3845596-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In MPU system, we could not afford mapping a new MPU memory region with each new guest boot module, it will exhaust limited MPU memory regions very quickly. So we introduce `mpu,boot-module-section` for users to statically configure one big memory section or very few memory sections for all guests' boot mudules. Users shall make sure that any guest boot module defined in Device Tree is within the section, including kernel module(BOOTMOD_KERNEL), device tree passthrough module(BOOTMOD_GUEST_DTB), and ramdisk module(BOOTMOD_RAMDISK). Signed-off-by: Penny Zheng Signed-off-by: Wei Chen --- xen/arch/arm/include/asm/setup.h | 1 + xen/arch/arm/mm_mpu.c | 2 +- xen/arch/arm/setup_mpu.c | 7 +++++++ 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index b7a2225c25..61f24b5848 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -195,6 +195,7 @@ struct init_info enum mpu_section_info { MSINFO_GUEST, MSINFO_DEVICE, + MSINFO_BOOTMODULE, MSINFO_MAX }; diff --git a/xen/arch/arm/mm_mpu.c b/xen/arch/arm/mm_mpu.c index 1566ba60af..ea64aa38e4 100644 --- a/xen/arch/arm/mm_mpu.c +++ b/xen/arch/arm/mm_mpu.c @@ -74,6 +74,7 @@ struct page_info *frame_table; static const unsigned int mpu_section_mattr[MSINFO_MAX] = { REGION_HYPERVISOR_SWITCH, REGION_HYPERVISOR_NOCACHE, + REGION_HYPERVISOR_BOOT, }; /* Write a MPU protection region */ @@ -686,7 +687,6 @@ void __init setup_static_mappings(void) #endif map_mpu_memory_section_on_boot(i, mpu_section_mattr[i]); } - /* TODO: boot-module section, etc */ } /* Map a frame table to cover physical addresses ps through pe */ diff --git a/xen/arch/arm/setup_mpu.c b/xen/arch/arm/setup_mpu.c index ec05542f68..160934bf86 100644 --- a/xen/arch/arm/setup_mpu.c +++ b/xen/arch/arm/setup_mpu.c @@ -30,6 +30,7 @@ const char *mpu_section_info_str[MSINFO_MAX] = { "mpu,guest-memory-section", "mpu,device-memory-section", + "mpu,boot-module-section", }; /* @@ -52,6 +53,12 @@ struct mpuinfo __initdata mpuinfo; * "mpu,device-memory-section": this section draws the device memory layout * with the least number of memory regions for all devices in system that will * be used in Xen, like `UART`, `GIC`, etc. + * + * "mpu,boot-module-section": this property uses one big memory section or + * very few memory sections to describe all guests' boot mudules. Users shall + * make sure that any guest boot module defined in Device Tree is within + * the section, including kernel module(BOOTMOD_KERNEL), device tree + * passthrough module(BOOTMOD_GUEST_DTB), and ramdisk module(BOOTMOD_RAMDISK). */ static int __init process_mpu_memory_section(const void *fdt, int node, const char *name, void *data, -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jan 13 07:30:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 07:30:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476800.739156 (Exim 4.92) (envelope-from ) id 1pGEW6-0000g7-1m; Fri, 13 Jan 2023 07:30:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476800.739156; Fri, 13 Jan 2023 07:30:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGEW5-0000g0-VG; Fri, 13 Jan 2023 07:30:21 +0000 Received: by outflank-mailman (input) for mailman id 476800; Fri, 13 Jan 2023 07:30:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGEW4-0000fs-6f for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 07:30:20 +0000 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [2a00:1450:4864:20::635]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1fb243a0-9314-11ed-b8d0-410ff93cb8f0; Fri, 13 Jan 2023 08:30:17 +0100 (CET) Received: by mail-ej1-x635.google.com with SMTP id az20so31211390ejc.1 for ; Thu, 12 Jan 2023 23:30:16 -0800 (PST) Received: from [192.168.1.93] (adsl-67.109.242.138.tellas.gr. [109.242.138.67]) by smtp.gmail.com with ESMTPSA id 15-20020a170906310f00b00738795e7d9bsm8137799ejx.2.2023.01.12.23.30.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Jan 2023 23:30:15 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1fb243a0-9314-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Dn+bnoVvZ/UNa2MNEKNx9JDAsWdqmdui9lxIIlE1MoI=; b=ERYoLubf+XYSFgtjTsuNsN78yVI5OR7hy9Rhy5f9SNbUS9RrwMSxadHxbg+IcEbT6f Qttx/TIVC3u3ubL1hLSd3Dc593o+ZN+xxx+ETmd4j0I8/zZdV5HF5qbLQo3EOzAgmgEb cKrc6cJaW17xvKf5jhhwfJTo+lyG+wJzAlq4ZHIcBSNYsmSHLFetzZJy60UEpw3HWjtw nJiZ5iHg7TFlXUBcPvZPlPJP4Esu3k9NHBc7wN94cb6gh9P0L4sk5FY6aWfoZHuHu+nZ ouC1ndJdJ7wOSrJ+F/0975aBxDjGnWOab89RyIHB/jpoLAQS3qi15EfkYvfxtdqEIq7a cHOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Dn+bnoVvZ/UNa2MNEKNx9JDAsWdqmdui9lxIIlE1MoI=; b=LX4M5TWCAwDhjdv9fSsc2sppQsX7Vu5uXjSxzEk1YlnPNOxlTLrrsdclCEn1yAPfJm E2vgZWdET9zG6SvvUPSOaKaJEeKSoPMNSkJlkPWacGRDyyQgQQyVdoXJjIJn4LBqgY77 lGjk6eFMRP8ItthS8FUJ/D2MVGuwiJzuC/pY2/lIrh1Su1liYCHqnMo9X2uR8I8px23o OEeKvitvmfDT+I7DcA6TALDZBHnRM/aL2wWFTHlvVHu4vqbb+ydmaeRJTG636fZmdXEU zpvN/blKRBN9/yx1A707b/i7oSjvNljTSveNMHYVG+Rb9Z41QzH0vo7vvGAa0WwhwhBo q3zQ== X-Gm-Message-State: AFqh2kpFaGx5Yb06N/w/0UPCmPcu4wTYRU9GhjHIY2DdcVOkEa/ztsR4 mnbPgnaAfYYkY4GB82RFNsk= X-Google-Smtp-Source: AMrXdXurQr12GQ4mPcB+mw5MYVR4QBl1VK3fQ0CGEhbv0alr4vZjdHUQ0FdJw+2Od22YIV7/yowTDA== X-Received: by 2002:a17:906:6a05:b0:7c1:28a7:f7a0 with SMTP id qw5-20020a1709066a0500b007c128a7f7a0mr98645100ejc.31.1673595015958; Thu, 12 Jan 2023 23:30:15 -0800 (PST) Message-ID: <04e5b744-bb61-b3d1-7d60-97bb710f7584@gmail.com> Date: Fri, 13 Jan 2023 09:30:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v2 6/8] x86/iommu: call pi_update_irte through an hvm_function callback Content-Language: en-US To: Jan Beulich Cc: Jun Nakajima , Kevin Tian , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Paul Durrant , xen-devel@lists.xenproject.org References: <20230104084502.61734-1-burzalodowa@gmail.com> <20230104084502.61734-7-burzalodowa@gmail.com> From: Xenia Ragiadakou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/12/23 14:16, Jan Beulich wrote: > On 04.01.2023 09:45, Xenia Ragiadakou wrote: >> --- a/xen/arch/x86/hvm/vmx/vmx.c >> +++ b/xen/arch/x86/hvm/vmx/vmx.c >> @@ -2143,6 +2143,14 @@ static bool cf_check vmx_test_pir(const struct vcpu *v, uint8_t vec) >> return pi_test_pir(vec, &v->arch.hvm.vmx.pi_desc); >> } >> >> +static int cf_check vmx_pi_update_irte(const struct vcpu *v, >> + const struct pirq *pirq, uint8_t gvec) >> +{ >> + const struct pi_desc *pi_desc = v ? &v->arch.hvm.vmx.pi_desc : NULL; >> + >> + return pi_update_irte(pi_desc, pirq, gvec); >> +} > > This being the only caller of pi_update_irte(), I don't see the point in > having the extra wrapper. Adjust pi_update_irte() such that it can be > used as the intended hook directly. Plus perhaps prefix it with vtd_. Ok I will remove the extra wrapper. > >> @@ -2591,6 +2599,8 @@ static struct hvm_function_table __initdata_cf_clobber vmx_function_table = { >> .tsc_scaling = { >> .max_ratio = VMX_TSC_MULTIPLIER_MAX, >> }, >> + >> + .pi_update_irte = vmx_pi_update_irte, > > You want to install this hook only when iommu_intpost (i.e. the only case > when it can actually be called, and only when INTEL_IOMMU=y (avoiding the > need for an inline stub of pi_update_irte() or whatever its final name is > going to be. Ok will do. > >> @@ -250,6 +252,9 @@ struct hvm_function_table { >> /* Architecture function to setup TSC scaling ratio */ >> void (*setup)(struct vcpu *v); >> } tsc_scaling; >> + >> + int (*pi_update_irte)(const struct vcpu *v, >> + const struct pirq *pirq, uint8_t gvec); >> }; > > Please can this be moved higher up, e.g. next to . Right after handle_eoi would be ok? or higher up? > >> @@ -774,6 +779,16 @@ static inline void hvm_set_nonreg_state(struct vcpu *v, >> alternative_vcall(hvm_funcs.set_nonreg_state, v, nrs); >> } >> >> +static inline int hvm_pi_update_irte(const struct vcpu *v, >> + const struct pirq *pirq, uint8_t gvec) >> +{ >> + if ( hvm_funcs.pi_update_irte ) >> + return alternative_call(hvm_funcs.pi_update_irte, v, pirq, gvec); >> + >> + return -EOPNOTSUPP; > > I don't think the conditional is needed, at least not with the other > suggested adjustments. Plus the way alternative patching works, a NULL > hook will be converted to some equivalent of BUG() anyway, so > ASSERT_UNREACHABLE() should also be unnecessary. Ok will remove it. > >> +} >> + >> + >> #else /* CONFIG_HVM */ > > Please don't add double blank lines. Ok will fix. > >> --- a/xen/arch/x86/include/asm/hvm/vmx/vmx.h >> +++ b/xen/arch/x86/include/asm/hvm/vmx/vmx.h >> @@ -146,6 +146,17 @@ static inline void pi_clear_sn(struct pi_desc *pi_desc) >> clear_bit(POSTED_INTR_SN, &pi_desc->control); >> } >> >> +#ifdef CONFIG_INTEL_IOMMU >> +int pi_update_irte(const struct pi_desc *pi_desc, >> + const struct pirq *pirq, const uint8_t gvec); >> +#else >> +static inline int pi_update_irte(const struct pi_desc *pi_desc, >> + const struct pirq *pirq, const uint8_t gvec) >> +{ >> + return -EOPNOTSUPP; >> +} >> +#endif > > This still is a VT-d function, so I think its declaration would better > remain in asm/iommu.h. > > Jan -- Xenia From xen-devel-bounces@lists.xenproject.org Fri Jan 13 07:45:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 07:45:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476808.739167 (Exim 4.92) (envelope-from ) id 1pGEkK-0002IZ-C3; Fri, 13 Jan 2023 07:45:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476808.739167; Fri, 13 Jan 2023 07:45:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGEkK-0002IS-98; Fri, 13 Jan 2023 07:45:04 +0000 Received: by outflank-mailman (input) for mailman id 476808; Fri, 13 Jan 2023 07:45:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGEkI-0002IK-CK for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 07:45:02 +0000 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [2a00:1450:4864:20::534]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2f6a43a6-9316-11ed-91b6-6bf2151ebd3b; Fri, 13 Jan 2023 08:45:01 +0100 (CET) Received: by mail-ed1-x534.google.com with SMTP id z11so30101520ede.1 for ; Thu, 12 Jan 2023 23:45:01 -0800 (PST) Received: from [192.168.1.93] (adsl-67.109.242.138.tellas.gr. [109.242.138.67]) by smtp.gmail.com with ESMTPSA id ew7-20020a056402538700b0049b58744f93sm1498910edb.81.2023.01.12.23.44.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Jan 2023 23:45:00 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2f6a43a6-9316-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=JsGO+7TGWvFuZLMUYRp7Wdn3kI5JHbZiEPOnzCuFKAA=; b=e7+23y1+z7Eka7I4AFEjEWQN+gzh0v5BS8ZlEZjTf/hCAPe7mhvu3EujcQSwpnlUiS T231oXDgjfZ8R3GkQQyPSw6FN6PzSu1RyJ9tWU4l+fWrk979mCn64dSW/Z/qp4BHbY66 krWSikRkmDAhK++cONo5thNJLDORD64Te7ZKJLda1jroqo6BcCW52qJkCyr8h+ErBa5u ID2mHj3dXUPWvnBsPDr8ZRWm3SnjITOiCmd3yPNY/3o8yC7O2gyTxMAxcvNpXFimEGN8 CmjXzaX9Idoh5TpcLTCYk7OhDpzP2mO8dpNqEWjMmzwGUwXWTQvc5U0jftZpzCOV3Eym WtbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JsGO+7TGWvFuZLMUYRp7Wdn3kI5JHbZiEPOnzCuFKAA=; b=tcksvOYNHMO6TEsZ/4/p0cM191xXKTAfahkLTtuKz6R4eLJ0b7P7qve6QN7CZkrHJc 2LgNCP7d6lwlWS/nDz/Dvtk37ly7Agr5o+623lip1OvusQ4TU7mBKI2rx7s27pauBsQq On+bLJoHjmmj5ncFb0CT2ZTieveXzOu6GvP/tLEXvl5e8ZY3m9VSuq58zEccDNjP7zmD dOGEb6b7jHgnRBqKeePMyISxx4BTqkd6H+h48sb8Rwwt0odzwnMSUYUk0+BwGsn6iQjS IiuYHnsSWJdWa92fAnR/naZW4V/CmIWEPq9OIEuaP6N+/fssYSq47fmzTWuha48ppN7W F8Dg== X-Gm-Message-State: AFqh2krEtIUWcWX9I5Y524mREzn5nvbr/6NB0A02FGHxOQGbIZigaOfz i+zAJwNfZXTbWQBencA/D+I= X-Google-Smtp-Source: AMrXdXv4kOKjqyHRZKSZO51hVTmb/pAlGTR4NvvYIuzi2SgJz/H8LFjwKZ/tn3y+mxEJwPuxNMDjwQ== X-Received: by 2002:a05:6402:e9b:b0:479:8313:3008 with SMTP id h27-20020a0564020e9b00b0047983133008mr59127596eda.0.1673595900901; Thu, 12 Jan 2023 23:45:00 -0800 (PST) Message-ID: Date: Fri, 13 Jan 2023 09:44:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v2 6/8] x86/iommu: call pi_update_irte through an hvm_function callback Content-Language: en-US To: Jan Beulich Cc: Jun Nakajima , Kevin Tian , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Paul Durrant , xen-devel@lists.xenproject.org References: <20230104084502.61734-1-burzalodowa@gmail.com> <20230104084502.61734-7-burzalodowa@gmail.com> <6c5a4c07-e942-a683-8579-a0f9d5971c7b@suse.com> From: Xenia Ragiadakou In-Reply-To: <6c5a4c07-e942-a683-8579-a0f9d5971c7b@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/12/23 14:37, Jan Beulich wrote: > On 12.01.2023 13:16, Jan Beulich wrote: >> On 04.01.2023 09:45, Xenia Ragiadakou wrote: >>> --- a/xen/arch/x86/hvm/vmx/vmx.c >>> +++ b/xen/arch/x86/hvm/vmx/vmx.c >>> @@ -2143,6 +2143,14 @@ static bool cf_check vmx_test_pir(const struct vcpu *v, uint8_t vec) >>> return pi_test_pir(vec, &v->arch.hvm.vmx.pi_desc); >>> } >>> >>> +static int cf_check vmx_pi_update_irte(const struct vcpu *v, >>> + const struct pirq *pirq, uint8_t gvec) >>> +{ >>> + const struct pi_desc *pi_desc = v ? &v->arch.hvm.vmx.pi_desc : NULL; >>> + >>> + return pi_update_irte(pi_desc, pirq, gvec); >>> +} >> >> This being the only caller of pi_update_irte(), I don't see the point in >> having the extra wrapper. Adjust pi_update_irte() such that it can be >> used as the intended hook directly. Plus perhaps prefix it with vtd_. > > Plus move it to vtd/x86/hvm.c (!HVM builds shouldn't need it), albeit I > realize this could be done independent of your work. In principle the > function shouldn't be VT-d specific (and could hence live in x86/hvm.c), > as msi_msg_write_remap_rte() is already available as IOMMU hook anyway, > provided struct pi_desc turns out compatible with what's going to be > needed for AMD. Since the posted interrupt descriptor is vmx specific while msi_msg_write_remap_rte is iommu specific, can I propose the following: - Keep the name as is (i.e vmx_pi_update_irte) and keep its definition in xen/arch/x86/hvm/vmx/vmx.c - Open code pi_update_irte() inside the body of vmx_pi_update_irte() but replace intel-specific msi_msg_write_remap_rte() with generic iommu_update_ire_from_msi(). Does this approach make sense? -- Xenia From xen-devel-bounces@lists.xenproject.org Fri Jan 13 07:47:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 07:47:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476806.739178 (Exim 4.92) (envelope-from ) id 1pGEmu-0002tM-SU; Fri, 13 Jan 2023 07:47:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476806.739178; Fri, 13 Jan 2023 07:47:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGEmu-0002tF-NT; Fri, 13 Jan 2023 07:47:44 +0000 Received: by outflank-mailman (input) for mailman id 476806; Fri, 13 Jan 2023 07:39:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGEf9-0001P9-DM for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 07:39:43 +0000 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [2a00:1450:4864:20::329]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 706c3330-9315-11ed-91b6-6bf2151ebd3b; Fri, 13 Jan 2023 08:39:41 +0100 (CET) Received: by mail-wm1-x329.google.com with SMTP id bg13-20020a05600c3c8d00b003d9712b29d2so18166471wmb.2 for ; Thu, 12 Jan 2023 23:39:40 -0800 (PST) Received: from solpc.. (67.pool90-171-92.dynamic.orange.es. [90.171.92.67]) by smtp.gmail.com with ESMTPSA id h19-20020a05600c351300b003d9a86a13bfsm26207681wmq.28.2023.01.12.23.39.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jan 2023 23:39:39 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 706c3330-9315-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3M4PJa8bRUQ4Sc+Wzz/wLpc5Oc/26l8w9l+YmujHJ60=; b=P1LDNQgqNtOTOXUgMU4kngFnoQqhy9Oq7QtZJYVR4R8y3LYth3y7NREJn0SEQjzIpt Y9vIhsduHpDGCLyv9tAMdFmQ4j/dh5+D1JbS+VYHbQaThnd4MoacI8qcpGg/4l1gOW2/ lQrabY4P5iQTl0yf1gv9Y2/MwMldp7MEwXewivv1y4ZenzLvn0tSTfIwYpnphHcVWJ9o LgTArCu7JAcefSAtZYvgnHmnLGcJRBDBWePUwVhXgAQZ0yfJ9mjGeoNyp8CQcP2qCdqL NQ/rs73ktpBLscWTNQE4C8ddF4lzEPDW27yBO0IKttw+AhYeje1S34W4z4dieZeoD7PI saKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3M4PJa8bRUQ4Sc+Wzz/wLpc5Oc/26l8w9l+YmujHJ60=; b=J3KptU6qbcXUxcVzzQY50SLyC+dvTptdi35cmyGSLqo+z2wfg94aaxFZl9G/cclAvh 5yZfRfEEWAYsPiDFPfnzMA3F5Zd/ld0X1gStAipWrSVV950BkQrrB8k8F1C2+j3sATTZ +B4tfie7KIH7rFBDdu+0Y7mvYc7QQJJhTQDMEVktU6nwyF6R44DMsjcKScpstsumEKo+ 6A/WrCnAreUo7F6soJJ9htDcQgO4UIYpj/IuDJDE9ZmBGRsIfktzceEmGZZdQAZpi9wh L3VMpTxJj2R/3fL+Yj5QUgAaCXs4tTLd2JY+VaScS92SFGXE8OGmdXJNnvQkiF6oSzlN /u5Q== X-Gm-Message-State: AFqh2kpgieYZAeBiWgYVImTuXdRT8TkKyVQISRvwO1BG/iUO4CeUkfaQ Dtzq2hVgvpcDvWJWYwhp0G8= X-Google-Smtp-Source: AMrXdXs3tLo1GHegPJMdV9HWu8qZmoNTQpGBWl1/Ydv1V8mjdLCceMWAUbQlN+gWfV6Ebj/DmKEHOw== X-Received: by 2002:a05:600c:500e:b0:3cf:88c3:d008 with SMTP id n14-20020a05600c500e00b003cf88c3d008mr61730943wmr.28.1673595580235; Thu, 12 Jan 2023 23:39:40 -0800 (PST) From: Joan Bruguera To: Peter Zijlstra Cc: linux-kernel@vger.kernel.org, Juergen Gross , "Rafael J. Wysocki" , xen-devel , Jan Beulich , Roger Pau Monne , Kees Cook , mark.rutland@arm.com, x86@kernel.org Subject: Re: [RFC][PATCH 0/6] x86: Fix suspend vs retbleed=stuff Date: Fri, 13 Jan 2023 07:39:38 +0000 Message-Id: <20230113073938.1066227-1-joanbrugueram@gmail.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230112143141.645645775@infradead.org> References: <20230112143141.645645775@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Peter, I tried your patches on both QEMU and my two (real) computers where s2ram with `retbleed=stuff` was failing and they wake up fine now. However, I think some minor reviews are needed: (1) I got a build error due to a symbol conflict between the `restore_registers` in `arch/x86/include/asm/suspend_64.h` and the one in `drivers/gpu/drm/amd/display/dc/gpio/hw_gpio.c`. (I fixed by renaming the one in `hw_gpio.c`, but it's worth an `allmodconfig` just in case there's something else) (2) Tracing with QEMU I still see two `sarq $5, %gs:0x1337B33F` before `%gs` is restored. Those correspond to the calls from `secondary_startup_64` in `arch/x86/kernel/head_64.S` to `verify_cpu` and `sev_verify_cbit`. Those don't cause a crash but look suspicious, are they correct? (There are also some `sarq`s in the call to `early_setup_idt` from `secondary_startup_64`, but `%gs` is restored immediately before) I attach an annotated QEMU log for those if it is useful. Regards, - Joan QEMU wakeup log: # 32-bit code ellided. Next line calls `secondary_startup_64` from `startup_64` 0x0009a0d0: ff 25 2a 2f 00 00 jmpq *0x2f2a(%rip) # Next line is `call verify_cpu` from `secondary_startup_64` 0xffffffff9a800070: e8 f1 00 00 00 callq 0xffffffff9a800166 # This next `sarq` does not have the correct GS set? # RAX=0000000080050033 RBX=0000000000000800 RCX=00000000c0000080 RDX=0000000000000000 # RSI=0000000000000000 RDI=0000000000000001 RBP=0000000000000000 RSP=000000000009e018 # R8 =0000000000000000 R9 =0000000000000000 R10=0000000000000000 R11=0000000000000000 # R12=0000000000000000 R13=0000000000000000 R14=0000000000000000 R15=0000000000000000 # RIP=ffffffff9a800166 RFL=00200097 [--S-APC] CPL=0 II=0 A20=1 SMM=0 HLT=0 # ES =0018 0000000000000000 ffffffff 00cf9300 DPL=0 DS [-WA] # CS =0010 0000000000000000 ffffffff 00af9b00 DPL=0 CS64 [-RA] # SS =0018 0000000000000000 ffffffff 00cf9300 DPL=0 DS [-WA] # DS =0018 0000000000000000 ffffffff 00cf9300 DPL=0 DS [-WA] # FS =0018 0000000000000000 ffffffff 00cf9300 DPL=0 DS [-WA] # GS =0018 0000000000000000 ffffffff 00cf9300 DPL=0 DS [-WA] # LDT=0000 0000000000000000 0000ffff 00008200 DPL=0 LDT # TR =0000 0000000000000000 0000ffff 00008b00 DPL=0 TSS64-busy # GDT= 0000000000098030 0000001f # IDT= 0000000000000000 00000000 # CR0=80050033 CR2=0000000000000000 CR3=000000000009c000 CR4=000006b0 # DR0=0000000000000000 DR1=0000000000000000 DR2=0000000000000000 DR3=0000000000000000 # DR6=00000000ffff0ff0 DR7=0000000000000400 # CCS=0000000000000095 CCD=fffffffffffff6ff CCO=EFLAGS # EFER=0000000000000d01 0xffffffff9a800166: 65 48 c1 3c 25 90 29 03 sarq $5, %gs:0x32990 0xffffffff9a80016e: 00 05 0xffffffff9a800170: 66 0f 1f 00 nopw (%rax) 0xffffffff9a800174: 9c pushfq 0xffffffff9a800175: 6a 00 pushq $0 0xffffffff9a800177: 9d popfq 0xffffffff9a800178: b8 00 00 00 00 movl $0, %eax 0xffffffff9a80017d: 0f a2 cpuid 0xffffffff9a80017f: 83 f8 01 cmpl $1, %eax 0xffffffff9a800182: 0f 82 d2 00 00 00 jb 0xffffffff9a80025a 0xffffffff9a800188: 66 31 ff xorw %di, %di 0xffffffff9a80018b: 81 fb 41 75 74 68 cmpl $0x68747541, %ebx 0xffffffff9a800191: 75 16 jne 0xffffffff9a8001a9 0xffffffff9a800193: 81 fa 65 6e 74 69 cmpl $0x69746e65, %edx 0xffffffff9a800199: 75 0e jne 0xffffffff9a8001a9 0xffffffff9a80019b: 81 f9 63 41 4d 44 cmpl $0x444d4163, %ecx 0xffffffff9a8001a1: 75 06 jne 0xffffffff9a8001a9 0xffffffff9a8001a3: 66 bf 01 00 movw $1, %di 0xffffffff9a8001a7: eb 4d jmp 0xffffffff9a8001f6 0xffffffff9a8001f6: b8 01 00 00 00 movl $1, %eax 0xffffffff9a8001fb: 0f a2 cpuid 0xffffffff9a8001fd: 81 e2 61 81 00 07 andl $0x7008161, %edx 0xffffffff9a800203: 81 f2 61 81 00 07 xorl $0x7008161, %edx 0xffffffff9a800209: 75 4f jne 0xffffffff9a80025a 0xffffffff9a80020b: b8 00 00 00 80 movl $0x80000000, %eax 0xffffffff9a800210: 0f a2 cpuid 0xffffffff9a800212: 3d 01 00 00 80 cmpl $0x80000001, %eax 0xffffffff9a800217: 72 41 jb 0xffffffff9a80025a 0xffffffff9a800219: b8 01 00 00 80 movl $0x80000001, %eax 0xffffffff9a80021e: 0f a2 cpuid 0xffffffff9a800220: 81 e2 00 00 00 20 andl $0x20000000, %edx 0xffffffff9a800226: 81 f2 00 00 00 20 xorl $0x20000000, %edx 0xffffffff9a80022c: 75 2c jne 0xffffffff9a80025a 0xffffffff9a80022e: b8 01 00 00 00 movl $1, %eax 0xffffffff9a800233: 0f a2 cpuid 0xffffffff9a800235: 81 e2 00 00 00 06 andl $0x6000000, %edx 0xffffffff9a80023b: 81 fa 00 00 00 06 cmpl $0x6000000, %edx 0xffffffff9a800241: 74 22 je 0xffffffff9a800265 0xffffffff9a800265: 9d popfq 0xffffffff9a800266: 31 c0 xorl %eax, %eax 0xffffffff9a800268: e9 23 24 d4 00 jmp 0xffffffff9b542690 0xffffffff9b542690: f3 0f 1e fa endbr64 0xffffffff9b542694: 65 48 c1 24 25 90 29 03 shlq $5, %gs:0x32990 0xffffffff9b54269c: 00 05 0xffffffff9b54269e: 74 02 je 0xffffffff9b5426a2 0xffffffff9b5426a2: e8 01 00 00 00 callq 0xffffffff9b5426a8 0xffffffff9b5426a8: e8 01 00 00 00 callq 0xffffffff9b5426ae 0xffffffff9b5426ae: e8 01 00 00 00 callq 0xffffffff9b5426b4 0xffffffff9b5426b4: e8 01 00 00 00 callq 0xffffffff9b5426ba 0xffffffff9b5426ba: e8 01 00 00 00 callq 0xffffffff9b5426c0 0xffffffff9b5426c0: e8 01 00 00 00 callq 0xffffffff9b5426c6 0xffffffff9b5426c6: e8 01 00 00 00 callq 0xffffffff9b5426cc 0xffffffff9b5426cc: e8 01 00 00 00 callq 0xffffffff9b5426d2 0xffffffff9b5426d2: e8 01 00 00 00 callq 0xffffffff9b5426d8 0xffffffff9b5426d8: e8 01 00 00 00 callq 0xffffffff9b5426de 0xffffffff9b5426de: e8 01 00 00 00 callq 0xffffffff9b5426e4 0xffffffff9b5426e4: e8 01 00 00 00 callq 0xffffffff9b5426ea 0xffffffff9b5426ea: e8 01 00 00 00 callq 0xffffffff9b5426f0 0xffffffff9b5426f0: e8 01 00 00 00 callq 0xffffffff9b5426f6 0xffffffff9b5426f6: e8 01 00 00 00 callq 0xffffffff9b5426fc 0xffffffff9b5426fc: e8 01 00 00 00 callq 0xffffffff9b542702 0xffffffff9b542702: 48 81 c4 80 00 00 00 addq $0x80, %rsp 0xffffffff9b542709: 65 48 c7 04 25 90 29 03 movq $-1, %gs:0x32990 0xffffffff9b542711: 00 ff ff ff ff # Returns from `verify_cpu` 0xffffffff9b542716: c3 retq 0xffffffff9a800075: 48 8b 04 25 38 2e 64 9c movq 0xffffffff9c642e38, %rax 0xffffffff9a80007d: 48 05 00 00 61 1c addq $0x1c610000, %rax 0xffffffff9a800083: 0f 20 e1 movq %cr4, %rcx 0xffffffff9a800086: 83 e1 40 andl $0x40, %ecx 0xffffffff9a800089: 81 c9 a0 00 00 00 orl $0xa0, %ecx 0xffffffff9a80008f: f7 05 87 bf 6c 01 01 00 testl $1, 0x16cbf87(%rip) 0xffffffff9a800097: 00 00 0xffffffff9a800099: 74 06 je 0xffffffff9a8000a1 0xffffffff9a8000a1: 0f 22 e1 movq %rcx, %cr4 0xffffffff9a8000a4: 48 03 05 65 9f e1 01 addq 0x1e19f65(%rip), %rax 0xffffffff9a8000ab: 56 pushq %rsi 0xffffffff9a8000ac: 48 89 c7 movq %rax, %rdi # Next line is `call sev_verify_cbit` from `secondary_startup_64` 0xffffffff9a8000af: e8 c2 01 00 00 callq 0xffffffff9a800276 # This next `sarq` does not have the correct GS set? # RAX=0000000002e10000 RBX=0000000000000800 RCX=00000000000000a0 RDX=0000000006000000 # RSI=0000000000000000 RDI=0000000002e10000 RBP=0000000000000000 RSP=000000000009e018 # R8 =0000000000000000 R9 =0000000000000000 R10=0000000000000000 R11=0000000000000000 # R12=0000000000000000 R13=0000000000000000 R14=0000000000000000 R15=0000000000000000 # RIP=ffffffff9a8000af RFL=00200007 [-----PC] CPL=0 II=0 A20=1 SMM=0 HLT=0 # ES =0018 0000000000000000 ffffffff 00cf9300 DPL=0 DS [-WA] # CS =0010 0000000000000000 ffffffff 00af9b00 DPL=0 CS64 [-RA] # SS =0018 0000000000000000 ffffffff 00cf9300 DPL=0 DS [-WA] # DS =0018 0000000000000000 ffffffff 00cf9300 DPL=0 DS [-WA] # FS =0018 0000000000000000 ffffffff 00cf9300 DPL=0 DS [-WA] # GS =0018 0000000000000000 ffffffff 00cf9300 DPL=0 DS [-WA] # LDT=0000 0000000000000000 0000ffff 00008200 DPL=0 LDT # TR =0000 0000000000000000 0000ffff 00008b00 DPL=0 TSS64-busy # GDT= 0000000000098030 0000001f # IDT= 0000000000000000 00000000 # CR0=80050033 CR2=0000000000000000 CR3=000000000009c000 CR4=000000a0 # DR0=0000000000000000 DR1=0000000000000000 DR2=0000000000000000 DR3=0000000000000000 # DR6=00000000ffff0ff0 DR7=0000000000000400 # CCS=ffffffffe6800000 CCD=0000000002e10000 CCO=ADDQ # EFER=0000000000000d01 0xffffffff9a800276: 65 48 c1 3c 25 90 29 03 sarq $5, %gs:0x32990 0xffffffff9a80027e: 00 05 0xffffffff9a800280: 66 0f 1f 00 nopw (%rax) 0xffffffff9a800284: 48 8b 35 ad 2b e4 01 movq 0x1e42bad(%rip), %rsi 0xffffffff9a80028b: 48 85 f6 testq %rsi, %rsi 0xffffffff9a80028e: 74 4b je 0xffffffff9a8002db 0xffffffff9a8002db: 48 89 f8 movq %rdi, %rax 0xffffffff9a8002de: e9 ad 23 d4 00 jmp 0xffffffff9b542690 0xffffffff9b542690: f3 0f 1e fa endbr64 0xffffffff9b542694: 65 48 c1 24 25 90 29 03 shlq $5, %gs:0x32990 0xffffffff9b54269c: 00 05 0xffffffff9b54269e: 74 02 je 0xffffffff9b5426a2 # Returns from `sev_verify_cbit` 0xffffffff9b5426a0: c3 retq 0xffffffff9a8000b4: 5e popq %rsi 0xffffffff9a8000b5: 0f 22 d8 movq %rax, %cr3 0xffffffff9a8000b8: 0f 20 e1 movq %cr4, %rcx 0xffffffff9a8000bb: 48 89 c8 movq %rcx, %rax 0xffffffff9a8000be: 48 81 f1 80 00 00 00 xorq $0x80, %rcx 0xffffffff9a8000c5: 0f 22 e1 movq %rcx, %cr4 0xffffffff9a8000c8: 0f 22 e0 movq %rax, %cr4 0xffffffff9a8000cb: 48 c7 c0 d4 00 80 9a movq $-0x657fff2c, %rax 0xffffffff9a8000d2: ff e0 jmpq *%rax 0xffffffff9a8000d4: 0f 01 15 25 9f e1 01 lgdtq 0x1e19f25(%rip) 0xffffffff9a8000db: 31 c0 xorl %eax, %eax 0xffffffff9a8000dd: 8e d8 movl %eax, %ds 0xffffffff9a8000df: 8e d0 movl %eax, %ss 0xffffffff9a8000e1: 8e c0 movl %eax, %es 0xffffffff9a8000e3: 8e e0 movl %eax, %fs 0xffffffff9a8000e5: 8e e8 movl %eax, %gs 0xffffffff9a8000e7: b9 01 01 00 c0 movl $0xc0000101, %ecx 0xffffffff9a8000ec: 8b 05 36 e5 fa 01 movl 0x1fae536(%rip), %eax 0xffffffff9a8000f2: 8b 15 34 e5 fa 01 movl 0x1fae534(%rip), %edx # Restores GS in `secondary_startup_64` 0xffffffff9a8000f8: 0f 30 wrmsr # Processor state after is: # RAX=00000000c7a00000 RBX=0000000000000800 RCX=00000000c0000101 RDX=00000000ffff97b9 # RSI=0000000000000000 RDI=0000000002e10000 RBP=0000000000000000 RSP=000000000009e020 # R8 =0000000000000000 R9 =0000000000000000 R10=0000000000000000 R11=0000000000000000 # R12=0000000000000000 R13=0000000000000000 R14=0000000000000000 R15=0000000000000000 # RIP=ffffffff9a8000fa RFL=00200046 [---Z-P-] CPL=0 II=0 A20=1 SMM=0 HLT=0 # ES =0000 0000000000000000 00000000 00000000 # CS =0010 0000000000000000 ffffffff 00af9b00 DPL=0 CS64 [-RA] # SS =0000 0000000000000000 00000000 00000000 # DS =0000 0000000000000000 00000000 00000000 # FS =0000 0000000000000000 00000000 00000000 # GS =0000 ffff97b9c7a00000 00000000 00000000 # LDT=0000 0000000000000000 0000ffff 00008200 DPL=0 LDT # TR =0000 0000000000000000 0000ffff 00008b00 DPL=0 TSS64-busy # GDT= ffff97b9c7a0b000 0000007f # IDT= 0000000000000000 00000000 # CR0=80050033 CR2=0000000000000000 CR3=0000000002e10000 CR4=000000a0 # DR0=0000000000000000 DR1=0000000000000000 DR2=0000000000000000 DR3=0000000000000000 # DR6=00000000ffff0ff0 DR7=0000000000000400 # CCS=0000000000000081 CCD=0000000000000020 CCO=CLR # EFER=0000000000000d01 0xffffffff9a8000fa: 48 8b 25 37 e5 fa 01 movq 0x1fae537(%rip), %rsp 0xffffffff9a800101: 56 pushq %rsi # Next line is `call early_setup_idt` from `secondary_startup_64` 0xffffffff9a800102: e8 9f 0f 00 00 callq 0xffffffff9a8010a6 0xffffffff9a8010a6: 65 48 c1 3c 25 90 29 03 sarq $5, %gs:0x32990 0xffffffff9a8010ae: 00 05 0xffffffff9a8010b0: 66 0f 1f 00 nopw (%rax) 0xffffffff9a8010b4: e8 2d af 08 00 callq 0xffffffff9a88bfe6 0xffffffff9a88bfe6: 65 48 c1 3c 25 90 29 03 sarq $5, %gs:0x32990 0xffffffff9a88bfee: 00 05 0xffffffff9a88bff0: 66 0f 1f 00 nopw (%rax) 0xffffffff9a88bff4: bf 03 00 00 00 movl $3, %edi 0xffffffff9a88bff9: e8 18 68 f7 ff callq 0xffffffff9a802816 0xffffffff9a802816: 65 48 c1 3c 25 90 29 03 sarq $5, %gs:0x32990 0xffffffff9a80281e: 00 05 0xffffffff9a802820: f3 0f 1e fa endbr64 0xffffffff9a802824: 8b 15 3e 98 6c 01 movl 0x16c983e(%rip), %edx # ... more stuff inside `early_setup_idt` ellided 0xffffffff9a800107: 5e popq %rsi 0xffffffff9a800108: b8 01 00 00 80 movl $0x80000001, %eax 0xffffffff9a80010d: 0f a2 cpuid 0xffffffff9a80010f: 89 d7 movl %edx, %edi 0xffffffff9a800111: b9 80 00 00 c0 movl $0xc0000080, %ecx 0xffffffff9a800116: 0f 32 rdmsr 0xffffffff9a800118: 89 c2 movl %eax, %edx 0xffffffff9a80011a: 0f ba e8 00 btsl $0, %eax 0xffffffff9a80011e: 0f ba e7 14 btl $0x14, %edi 0xffffffff9a800122: 73 0d jae 0xffffffff9a800131 0xffffffff9a800124: 0f ba e8 0b btsl $0xb, %eax 0xffffffff9a800128: 48 0f ba 2d 8f 9f e1 01 btsq $0x3f, 0x1e19f8f(%rip) 0xffffffff9a800130: 3f 0xffffffff9a800131: 39 d0 cmpl %edx, %eax 0xffffffff9a800133: 74 04 je 0xffffffff9a800139 0xffffffff9a800139: b8 33 00 05 80 movl $0x80050033, %eax 0xffffffff9a80013e: 0f 22 c0 movq %rax, %cr0 0xffffffff9a800141: 6a 00 pushq $0 0xffffffff9a800143: 9d popfq 0xffffffff9a800144: 48 89 f7 movq %rsi, %rdi 0xffffffff9a800147: 68 5a 01 80 9a pushq $-0x657ffea6 0xffffffff9a80014c: 31 ed xorl %ebp, %ebp 0xffffffff9a80014e: 48 8b 05 cb e4 fa 01 movq 0x1fae4cb(%rip), %rax 0xffffffff9a800155: 6a 10 pushq $0x10 0xffffffff9a800157: 50 pushq %rax 0xffffffff9a800158: 48 cb lretq 0xffffffff9a86db70: f3 0f 1e fa endbr64 # START wakeup_long64 0xffffffff9a86db74: 48 8b 04 25 90 0a 63 9c movq 0xffffffff9c630a90, %rax 0xffffffff9a86db7c: 48 ba f0 de bc 9a 78 56 movabsq $0x123456789abcdef0, %rdx 0xffffffff9a86db84: 34 12 0xffffffff9a86db86: 48 39 d0 cmpq %rdx, %rax 0xffffffff9a86db89: 74 0c je 0xffffffff9a86db97 0xffffffff9a86db97: 66 b8 18 00 movw $0x18, %ax 0xffffffff9a86db9b: 8e d0 movl %eax, %ss 0xffffffff9a86db9d: 8e d8 movl %eax, %ds 0xffffffff9a86db9f: 8e c0 movl %eax, %es 0xffffffff9a86dba1: 8e e0 movl %eax, %fs # This clears GS again 0xffffffff9a86dba3: 8e e8 movl %eax, %gs # Processor state after is: # RAX=123456789abc0018 RBX=0000000000000000 RCX=00000000c0000080 RDX=123456789abcdef0 # RSI=0000000000000000 RDI=0000000000000000 RBP=0000000000000000 RSP=ffffffff9cff3fd8 # R8 =0000000000000000 R9 =0000000000000000 R10=0000000000000000 R11=0000000000000000 # R12=0000000000000000 R13=0000000000000000 R14=0000000000000000 R15=0000000000000000 # RIP=ffffffff9a86dba5 RFL=00000046 [---Z-P-] CPL=0 II=0 A20=1 SMM=0 HLT=0 # ES =0018 0000000000000000 ffffffff 00cf9300 DPL=0 DS [-WA] # CS =0010 0000000000000000 ffffffff 00af9b00 DPL=0 CS64 [-RA] # SS =0018 0000000000000000 ffffffff 00cf9300 DPL=0 DS [-WA] # DS =0018 0000000000000000 ffffffff 00cf9300 DPL=0 DS [-WA] # FS =0018 0000000000000000 ffffffff 00cf9300 DPL=0 DS [-WA] # GS =0018 0000000000000000 ffffffff 00cf9300 DPL=0 DS [-WA] # LDT=0000 0000000000000000 0000ffff 00008200 DPL=0 LDT # TR =0000 0000000000000000 0000ffff 00008b00 DPL=0 TSS64-busy # GDT= ffff97b9c7a0b000 0000007f # IDT= ffffffff9c604000 000001ff # CR0=80050033 CR2=0000000000000000 CR3=0000000002e10000 CR4=000000a0 # DR0=0000000000000000 DR1=0000000000000000 DR2=0000000000000000 DR3=0000000000000000 # DR6=00000000ffff0ff0 DR7=0000000000000400 # CCS=0000000000000044 CCD=0000000000000000 CCO=EFLAGS # EFER=0000000000000d01 0xffffffff9a86dba5: 48 8b 24 25 88 0a 63 9c movq 0xffffffff9c630a88, %rsp 0xffffffff9a86dbad: 48 8b 1c 25 78 0a 63 9c movq 0xffffffff9c630a78, %rbx 0xffffffff9a86dbb5: 48 8b 3c 25 70 0a 63 9c movq 0xffffffff9c630a70, %rdi 0xffffffff9a86dbbd: 48 8b 34 25 68 0a 63 9c movq 0xffffffff9c630a68, %rsi 0xffffffff9a86dbc5: 48 8b 2c 25 60 0a 63 9c movq 0xffffffff9c630a60, %rbp 0xffffffff9a86dbcd: 48 8b 04 25 80 0a 63 9c movq 0xffffffff9c630a80, %rax 0xffffffff9a86dbd5: ff e0 jmpq *%rax # START `.Lresume_point` in `do_suspend_lowlevel` 0xffffffff9a86dc90: 48 c7 c0 e0 53 0e 9d movq $-0x62f1ac20, %rax 0xffffffff9a86dc97: 48 8b 98 e0 00 00 00 movq 0xe0(%rax), %rbx 0xffffffff9a86dc9e: 0f 22 e3 movq %rbx, %cr4 0xffffffff9a86dca1: 48 8b 98 d8 00 00 00 movq 0xd8(%rax), %rbx 0xffffffff9a86dca8: 0f 22 db movq %rbx, %cr3 0xffffffff9a86dcab: 48 8b 98 d0 00 00 00 movq 0xd0(%rax), %rbx 0xffffffff9a86dcb2: 0f 22 d3 movq %rbx, %cr2 0xffffffff9a86dcb5: 48 8b 98 c8 00 00 00 movq 0xc8(%rax), %rbx 0xffffffff9a86dcbc: 0f 22 c3 movq %rbx, %cr0 0xffffffff9a86dcbf: ff b0 90 00 00 00 pushq 0x90(%rax) 0xffffffff9a86dcc5: 9d popfq 0xffffffff9a86dcc6: 48 8b a0 98 00 00 00 movq 0x98(%rax), %rsp 0xffffffff9a86dccd: 48 8b 68 20 movq 0x20(%rax), %rbp 0xffffffff9a86dcd1: 48 8b 70 68 movq 0x68(%rax), %rsi 0xffffffff9a86dcd5: 48 8b 78 70 movq 0x70(%rax), %rdi 0xffffffff9a86dcd9: 48 8b 58 28 movq 0x28(%rax), %rbx 0xffffffff9a86dcdd: 48 8b 48 58 movq 0x58(%rax), %rcx 0xffffffff9a86dce1: 48 8b 50 60 movq 0x60(%rax), %rdx 0xffffffff9a86dce5: 4c 8b 40 48 movq 0x48(%rax), %r8 0xffffffff9a86dce9: 4c 8b 48 40 movq 0x40(%rax), %r9 0xffffffff9a86dced: 4c 8b 50 38 movq 0x38(%rax), %r10 0xffffffff9a86dcf1: 4c 8b 58 30 movq 0x30(%rax), %r11 0xffffffff9a86dcf5: 4c 8b 60 18 movq 0x18(%rax), %r12 0xffffffff9a86dcf9: 4c 8b 68 10 movq 0x10(%rax), %r13 0xffffffff9a86dcfd: 4c 8b 70 08 movq 8(%rax), %r14 0xffffffff9a86dd01: 4c 8b 38 movq (%rax), %r15 0xffffffff9a86dd04: 31 c0 xorl %eax, %eax 0xffffffff9a86dd06: 48 83 c4 08 addq $8, %rsp # Jumps to `restore_processor_state` 0xffffffff9a86dd0a: e9 31 ed cb 00 jmp 0xffffffff9b52ca40 0xffffffff9b52ca40: 55 pushq %rbp 0xffffffff9b52ca41: 48 89 e5 movq %rsp, %rbp 0xffffffff9b52ca44: 41 57 pushq %r15 0xffffffff9b52ca46: 41 56 pushq %r14 0xffffffff9b52ca48: 41 55 pushq %r13 0xffffffff9b52ca4a: 41 54 pushq %r12 0xffffffff9b52ca4c: 53 pushq %rbx 0xffffffff9b52ca4d: 48 83 ec 20 subq $0x20, %rsp 0xffffffff9b52ca51: 80 3d c4 8a bb 01 00 cmpb $0, 0x1bb8ac4(%rip) 0xffffffff9b52ca58: 74 15 je 0xffffffff9b52ca6f 0xffffffff9b52ca5a: 48 8b 05 67 8a bb 01 movq 0x1bb8a67(%rip), %rax 0xffffffff9b52ca61: b9 a0 01 00 00 movl $0x1a0, %ecx 0xffffffff9b52ca66: 48 89 c2 movq %rax, %rdx 0xffffffff9b52ca69: 48 c1 ea 20 shrq $0x20, %rdx 0xffffffff9b52ca6d: 0f 30 wrmsr 0xffffffff9b52ca6f: 48 8b 05 6a 8a bb 01 movq 0x1bb8a6a(%rip), %rax 0xffffffff9b52ca76: b9 80 00 00 c0 movl $0xc0000080, %ecx 0xffffffff9b52ca7b: 48 89 c2 movq %rax, %rdx 0xffffffff9b52ca7e: 48 c1 ea 20 shrq $0x20, %rdx 0xffffffff9b52ca82: 0f 30 wrmsr 0xffffffff9b52ca84: 48 8b 05 35 8a bb 01 movq 0x1bb8a35(%rip), %rax 0xffffffff9b52ca8b: 0f 22 e0 movq %rax, %cr4 0xffffffff9b52ca8e: 48 89 05 2b 8a bb 01 movq %rax, 0x1bb8a2b(%rip) 0xffffffff9b52ca95: 48 8b 05 1c 8a bb 01 movq 0x1bb8a1c(%rip), %rax 0xffffffff9b52ca9c: 0f 22 d8 movq %rax, %cr3 0xffffffff9b52ca9f: 48 8b 05 0a 8a bb 01 movq 0x1bb8a0a(%rip), %rax 0xffffffff9b52caa6: 0f 22 d0 movq %rax, %cr2 0xffffffff9b52caa9: 48 8b 05 f8 89 bb 01 movq 0x1bb89f8(%rip), %rax 0xffffffff9b52cab0: 0f 22 c0 movq %rax, %cr0 0xffffffff9b52cab3: 48 89 05 ee 89 bb 01 movq %rax, 0x1bb89ee(%rip) 0xffffffff9b52caba: 0f 01 1d 35 8a bb 01 lidtq 0x1bb8a35(%rip) 0xffffffff9b52cac1: b8 18 00 00 00 movl $0x18, %eax 0xffffffff9b52cac6: 8e d0 movl %eax, %ss 0xffffffff9b52cac8: b8 2b 00 00 00 movl $0x2b, %eax 0xffffffff9b52cacd: 89 c2 movl %eax, %edx 0xffffffff9b52cacf: 8e da movl %edx, %ds 0xffffffff9b52cad1: 8e c0 movl %eax, %es 0xffffffff9b52cad3: 48 8b 05 b6 89 bb 01 movq 0x1bb89b6(%rip), %rax 0xffffffff9b52cada: b9 01 01 00 c0 movl $0xc0000101, %ecx 0xffffffff9b52cadf: 48 89 c2 movq %rax, %rdx 0xffffffff9b52cae2: 48 c1 ea 20 shrq $0x20, %rdx # Restores GS inside `__restore_processor_state`. Processor state after is: # RAX=ffff97b9c7a00000 RBX=ffff97b9c5b6be00 RCX=00000000c0000101 RDX=00000000ffff97b9 # RSI=ffffffffd43c95f9 RDI=0000000000000004 RBP=ffffad4e8062fca0 RSP=ffffad4e8062fc58 # R8 =0000000000000004 R9 =0000000021bee048 R10=00000000aaaaaaab R11=0000000000000005 # R12=0000000000000000 R13=0000000000000000 R14=0000000000000004 R15=ffff97b9c5929020 # RIP=ffffffff9b52cae8 RFL=00000003 [------C] CPL=0 II=0 A20=1 SMM=0 HLT=0 # ES =002b 0000000000000000 ffffffff 00cff300 DPL=3 DS [-WA] # CS =0010 0000000000000000 ffffffff 00af9b00 DPL=0 CS64 [-RA] # SS =0018 0000000000000000 ffffffff 00cf9300 DPL=0 DS [-WA] # DS =002b 0000000000000000 ffffffff 00cff300 DPL=3 DS [-WA] # FS =0018 0000000000000000 ffffffff 00cf9300 DPL=0 DS [-WA] # GS =0018 ffff97b9c7a00000 ffffffff 00cf9300 DPL=0 DS [-WA] # LDT=0000 0000000000000000 0000ffff 00008200 DPL=0 LDT # TR =0000 0000000000000000 0000ffff 00008b00 DPL=0 TSS64-busy # GDT= ffff97b9c7a0b000 0000007f # IDT= fffffe0000000000 00000fff # CR0=80050033 CR2=000000000049304a CR3=0000000005b58000 CR4=000006f0 # DR0=0000000000000000 DR1=0000000000000000 DR2=0000000000000000 DR3=0000000000000000 # DR6=00000000ffff0ff0 DR7=0000000000000400 # CCS=00000001ffff2f73 CCD=00000000ffff97b9 CCO=SARQ # EFER=0000000000000d01 0xffffffff9b52cae6: 0f 30 wrmsr From xen-devel-bounces@lists.xenproject.org Fri Jan 13 08:08:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 08:08:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476823.739189 (Exim 4.92) (envelope-from ) id 1pGF7A-00061T-20; Fri, 13 Jan 2023 08:08:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476823.739189; Fri, 13 Jan 2023 08:08:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGF79-00061M-V3; Fri, 13 Jan 2023 08:08:39 +0000 Received: by outflank-mailman (input) for mailman id 476823; Fri, 13 Jan 2023 08:08:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGF78-00061G-NB for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 08:08:38 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7add2999-9319-11ed-91b6-6bf2151ebd3b; Fri, 13 Jan 2023 09:08:37 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E56295F986; Fri, 13 Jan 2023 08:08:35 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C182E13913; Fri, 13 Jan 2023 08:08:35 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 7oPDLYMRwWNaSwAAMHmgww (envelope-from ); Fri, 13 Jan 2023 08:08:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7add2999-9319-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1673597315; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=m4sELtLR4erGC6Nt+c21AO/Z8JBEn7P+96bMsRdB8wQ=; b=CJ8UhLWnNyD8jGmtMk023GJAiIicP6C8Z5knrrklLdTD9RU1kAOi5K01zM0Kwotiv1EC7h RgUXeE1OlbvVzL+1ymvzbzCSMmvn5cyNT1v7PXuYfcw9lsFMiCMeKSWqBExVL/1WR0oZsY mrtsmsCQayAtWrVoAfjMi1p9ACM9tWI= Message-ID: Date: Fri, 13 Jan 2023 09:08:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , xen-devel Cc: regressions@lists.linux.dev References: From: Juergen Gross Subject: Re: S3 under Xen regression between 6.1.1 and 6.1.3 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------78E4ABhTHO0B4lG8jyzNTay2" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------78E4ABhTHO0B4lG8jyzNTay2 Content-Type: multipart/mixed; boundary="------------LaTlo7JDqFZbSkQGkk2AzUwV"; protected-headers="v1" From: Juergen Gross To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , xen-devel Cc: regressions@lists.linux.dev Message-ID: Subject: Re: S3 under Xen regression between 6.1.1 and 6.1.3 References: In-Reply-To: --------------LaTlo7JDqFZbSkQGkk2AzUwV Content-Type: multipart/mixed; boundary="------------JTCEnxmZjr8uUX0QsykuUQXk" --------------JTCEnxmZjr8uUX0QsykuUQXk Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTMuMDEuMjMgMDM6NTcsIE1hcmVrIE1hcmN6eWtvd3NraS1Hw7NyZWNraSB3cm90ZToN Cj4gSGksDQo+IA0KPiA2LjEuMyBhcyBQViBkb20wIGNyYXNoZXMgd2hlbiBhdHRlbXB0aW5n IHRvIHN1c3BlbmQuIDYuMS4xIHdvcmtzLiBUaGUNCj4gY3Jhc2g6DQo+IA0KPiAgICAgIFsg IDM0OC4yODQwMDRdIFBNOiBzdXNwZW5kIGVudHJ5IChkZWVwKQ0KPiAgICAgIFsgIDM0OC4y ODk1MzJdIEZpbGVzeXN0ZW1zIHN5bmM6IDAuMDA1IHNlY29uZHMNCj4gICAgICBbICAzNDgu MjkxNTQ1XSBGcmVlemluZyB1c2VyIHNwYWNlIHByb2Nlc3NlcyAuLi4gKGVsYXBzZWQgMC4w MDAgc2Vjb25kcykgZG9uZS4NCj4gICAgICBbICAzNDguMjkyNDU3XSBPT00ga2lsbGVyIGRp c2FibGVkLg0KPiAgICAgIFsgIDM0OC4yOTI0NjJdIEZyZWV6aW5nIHJlbWFpbmluZyBmcmVl emFibGUgdGFza3MgLi4uIChlbGFwc2VkIDAuMTA0IHNlY29uZHMpIGRvbmUuDQo+ICAgICAg WyAgMzQ4LjM5NjYxMl0gcHJpbnRrOiBTdXNwZW5kaW5nIGNvbnNvbGUocykgKHVzZSBub19j b25zb2xlX3N1c3BlbmQgdG8gZGVidWcpDQo+ICAgICAgWyAgMzQ4Ljc0OTIyOF0gUE06IHN1 c3BlbmQgZGV2aWNlcyB0b29rIDAuMzUyIHNlY29uZHMNCj4gICAgICBbICAzNDguNzY5NzEz XSBBQ1BJOiBFQzogaW50ZXJydXB0IGJsb2NrZWQNCj4gICAgICBbICAzNDguODE2MDc3XSBC VUc6IGtlcm5lbCBOVUxMIHBvaW50ZXIgZGVyZWZlcmVuY2UsIGFkZHJlc3M6IDAwMDAwMDAw MDAwMDAwMWMNCj4gICAgICBbICAzNDguODE2MDgwXSAjUEY6IHN1cGVydmlzb3IgcmVhZCBh Y2Nlc3MgaW4ga2VybmVsIG1vZGUNCj4gICAgICBbICAzNDguODE2MDgxXSAjUEY6IGVycm9y X2NvZGUoMHgwMDAwKSAtIG5vdC1wcmVzZW50IHBhZ2UNCj4gICAgICBbICAzNDguODE2MDgz XSBQR0QgMCBQNEQgMA0KPiAgICAgIFsgIDM0OC44MTYwODZdIE9vcHM6IDAwMDAgWyMxXSBQ UkVFTVBUIFNNUCBOT1BUSQ0KPiAgICAgIFsgIDM0OC44MTYwODldIENQVTogMCBQSUQ6IDY3 NjQgQ29tbTogc3lzdGVtZC1zbGVlcCBOb3QgdGFpbnRlZCA2LjEuMy0xLmZjMzIucXViZXMu eDg2XzY0ICMxDQo+ICAgICAgWyAgMzQ4LjgxNjA5Ml0gSGFyZHdhcmUgbmFtZTogU3RhciBM YWJzIFN0YXJCb29rL1N0YXJCb29rLCBCSU9TIDguMDEgMDcvMDMvMjAyMg0KPiAgICAgIFsg IDM0OC44MTYwOTNdIFJJUDogZTAzMDphY3BpX2dldF93YWtldXBfYWRkcmVzcysweGMvMHgy MA0KPiAgICAgIFsgIDM0OC44MTYxMDBdIENvZGU6IDQ0IDAwIDAwIDQ4IDhiIDA1IDA0IGEz IDgyIDAyIGMzIGNjIGNjIGNjIGNjIGNjIGNjIGNjIGNjIGNjIGNjIGNjIGNjIGNjIGNjIGNj IGNjIGNjIGNjIGNjIDBmIDFmIDQ0IDAwIDAwIDQ4IDhiIDA1IGZjIDlkIDgyIDAyIDw4Yj4g NDAgMWMgYzMgY2MgY2MgY2MgY2MgNjYgNjYgMmUgMGYgMWYgODQgMDAgMDAgMDAgMDAgMDAg OTAgMGYgMWYNCj4gICAgICBbICAzNDguODE2MTAzXSBSU1A6IGUwMmI6ZmZmZmM5MDA0MjUz N2QwOCBFRkxBR1M6IDAwMDEwMjQ2DQo+ICAgICAgWyAgMzQ4LjgxNjEwNV0gUkFYOiAwMDAw MDAwMDAwMDAwMDAwIFJCWDogMDAwMDAwMDAwMDAwMDAwMyBSQ1g6IDIwYzQ5YmE1ZTM1M2Y3 Y2YNCj4gICAgICBbICAzNDguODE2MTA2XSBSRFg6IDAwMDAwMDAwMDAwMGNkMTkgUlNJOiAw MDAwMDAwMDAwMDJlZTlhIFJESTogMDAyYTA1MWVkNDJkNzY5NA0KPiAgICAgIFsgIDM0OC44 MTYxMDhdIFJCUDogMDAwMDAwMDAwMDAwMDAwMyBSMDg6IGZmZmZjOTAwNDI1MzdjYTAgUjA5 OiBmZmZmZmZmZjgyYzVlNDY4DQo+ICAgICAgWyAgMzQ4LjgxNjExMF0gUjEwOiAwMDAwMDAw MDAwMDA3ZmYwIFIxMTogMDAwMDAwMDAwMDAwMDAwMCBSMTI6IDAwMDAwMDAwMDAwMDAwMDAN Cj4gICAgICBbICAzNDguODE2MTExXSBSMTM6IGZmZmZmZmZmZmZmZmZmZjIgUjE0OiBmZmZm ODg4MTIyMDZlNmMwIFIxNTogZmZmZjg4ODEyMjA2ZTZlMA0KPiAgICAgIFsgIDM0OC44MTYx MjFdIEZTOiAgMDAwMDdjYjQ5YjAxZWI4MCgwMDAwKSBHUzpmZmZmODg4MTg5NDAwMDAwKDAw MDApIGtubEdTOjAwMDAwMDAwMDAwMDAwMDANCj4gICAgICBbICAzNDguODE2MTIzXSBDUzog IGUwMzAgRFM6IDAwMDAgRVM6IDAwMDAgQ1IwOiAwMDAwMDAwMDgwMDUwMDMzDQo+ICAgICAg WyAgMzQ4LjgxNjEyNF0gQ1IyOiAwMDAwMDAwMDAwMDAwMDFjIENSMzogMDAwMDAwMDEyMjMx YTAwMCBDUjQ6IDAwMDAwMDAwMDAwNTA2NjANCj4gICAgICBbICAzNDguODE2MTMxXSBDYWxs IFRyYWNlOg0KPiAgICAgIFsgIDM0OC44MTYxMzNdICA8VEFTSz4NCj4gICAgICBbICAzNDgu ODE2MTM0XSAgYWNwaV9wbV9wcmVwYXJlKzB4MWEvMHg1MA0KPiAgICAgIFsgIDM0OC44MTYx NDFdICBzdXNwZW5kX2VudGVyKzB4OTQvMHgzNjANCj4gICAgICBbICAzNDguODE2MTQ2XSAg c3VzcGVuZF9kZXZpY2VzX2FuZF9lbnRlcisweDE5OC8weDJiMA0KPiAgICAgIFsgIDM0OC44 MTYxNTBdICBlbnRlcl9zdGF0ZSsweDE4ZC8weDFmNQ0KPiAgICAgIFsgIDM0OC44MTYxNTVd ICBwbV9zdXNwZW5kLmNvbGQrMHgyMC8weDZiDQo+ICAgICAgWyAgMzQ4LjgxNjE1OV0gIHN0 YXRlX3N0b3JlKzB4MjcvMHg2MA0KPiAgICAgIFsgIDM0OC44MTYxNjNdICBrZXJuZnNfZm9w X3dyaXRlX2l0ZXIrMHgxMjUvMHgxYzANCj4gICAgICBbICAzNDguODE2MTY5XSAgbmV3X3N5 bmNfd3JpdGUrMHgxMDUvMHgxOTANCj4gICAgICBbICAzNDguODE2MTc2XSAgdmZzX3dyaXRl KzB4MjExLzB4MmEwDQo+ICAgICAgWyAgMzQ4LjgxNjE4MF0gIGtzeXNfd3JpdGUrMHg2Ny8w eGUwDQo+ICAgICAgWyAgMzQ4LjgxNjE4M10gIGRvX3N5c2NhbGxfNjQrMHg1OS8weDkwDQo+ ICAgICAgWyAgMzQ4LjgxNjE4OF0gID8gZG9fc3lzY2FsbF82NCsweDY5LzB4OTANCj4gICAg ICBbICAzNDguODE2MTkyXSAgPyBleGNfcGFnZV9mYXVsdCsweDc2LzB4MTcwDQo+ICAgICAg WyAgMzQ4LjgxNjE5NV0gIGVudHJ5X1NZU0NBTExfNjRfYWZ0ZXJfaHdmcmFtZSsweDYzLzB4 Y2QNCj4gICAgICBbICAzNDguODE2MjAwXSBSSVA6IDAwMzM6MHg3Y2I0OWMxNDEyZjcNCj4g ICAgICBbICAzNDguODE2MjAzXSBDb2RlOiAwZCAwMCBmNyBkOCA2NCA4OSAwMiA0OCBjNyBj MCBmZiBmZiBmZiBmZiBlYiBiNyAwZiAxZiAwMCBmMyAwZiAxZSBmYSA2NCA4YiAwNCAyNSAx OCAwMCAwMCAwMCA4NSBjMCA3NSAxMCBiOCAwMSAwMCAwMCAwMCAwZiAwNSA8NDg+IDNkIDAw IGYwIGZmIGZmIDc3IDUxIGMzIDQ4IDgzIGVjIDI4IDQ4IDg5IDU0IDI0IDE4IDQ4IDg5IDc0 IDI0DQo+ICAgICAgWyAgMzQ4LjgxNjIwNF0gUlNQOiAwMDJiOjAwMDA3ZmZjMTI1ZjYzZjgg RUZMQUdTOiAwMDAwMDI0NiBPUklHX1JBWDogMDAwMDAwMDAwMDAwMDAwMQ0KPiAgICAgIFsg IDM0OC44MTYyMDZdIFJBWDogZmZmZmZmZmZmZmZmZmZkYSBSQlg6IDAwMDAwMDAwMDAwMDAw MDQgUkNYOiAwMDAwN2NiNDljMTQxMmY3DQo+ICAgICAgWyAgMzQ4LjgxNjIwOF0gUkRYOiAw MDAwMDAwMDAwMDAwMDA0IFJTSTogMDAwMDdmZmMxMjVmNjRlMCBSREk6IDAwMDAwMDAwMDAw MDAwMDQNCj4gICAgICBbICAzNDguODE2MjA5XSBSQlA6IDAwMDA3ZmZjMTI1ZjY0ZTAgUjA4 OiAwMDAwNWM4M2Q3NzJiY2EwIFIwOTogMDAwMDAwMDAwMDAwMDAwZA0KPiAgICAgIFsgIDM0 OC44MTYyMTBdIFIxMDogMDAwMDVjODNkNzcyN2ViMCBSMTE6IDAwMDAwMDAwMDAwMDAyNDYg UjEyOiAwMDAwMDAwMDAwMDAwMDA0DQo+ICAgICAgWyAgMzQ4LjgxNjIxMV0gUjEzOiAwMDAw NWM4M2Q3NzI3MmQwIFIxNDogMDAwMDAwMDAwMDAwMDAwNCBSMTU6IDAwMDA3Y2I0OWMyMTM3 MDANCj4gICAgICBbICAzNDguODE2MjEzXSAgPC9UQVNLPg0KPiAgICAgIFsgIDM0OC44MTYy MTRdIE1vZHVsZXMgbGlua2VkIGluOiBsb29wIHZmYXQgZmF0IHNuZF9oZGFfY29kZWNfaGRt aSBzbmRfc29mX3BjaV9pbnRlbF90Z2wgc25kX3NvZl9pbnRlbF9oZGFfY29tbW9uIHNvdW5k d2lyZV9pbnRlbCBzb3VuZHdpcmVfZ2VuZXJpY19hbGxvY2F0aW9uIHNvdW5kd2lyZV9jYWRl bmNlIHNuZF9zb2ZfaW50ZWxfaGRhIHNuZF9zb2ZfcGNpIHNuZF9zb2ZfeHRlbnNhX2RzcCBz bmRfc29mIHNuZF9zb2ZfdXRpbHMgc25kX3NvY19oZGFjX2hkYSBzbmRfaGRhX2V4dF9jb3Jl IHNuZF9zb2NfYWNwaV9pbnRlbF9tYXRjaCBzbmRfc29jX2FjcGkgc291bmR3aXJlX2J1cyBz bmRfaGRhX2NvZGVjX3JlYWx0ZWsgc25kX2hkYV9jb2RlY19nZW5lcmljIGxlZHRyaWdfYXVk aW8gc25kX3NvY19jb3JlIHNuZF9jb21wcmVzcyBhYzk3X2J1cyBzbmRfcGNtX2RtYWVuZ2lu ZSBzbmRfaGRhX2ludGVsIHNuZF9pbnRlbF9kc3BjZmcgc25kX2ludGVsX3Nkd19hY3BpIGlU Q09fd2R0IGludGVsX3BtY19ieHQgZWUxMDA0IGlUQ09fdmVuZG9yX3N1cHBvcnQgaW50ZWxf cmFwbF9tc3Igc25kX2hkYV9jb2RlYyBzbmRfaGRhX2NvcmUgc25kX2h3ZGVwIHNuZF9zZXEg c25kX3NlcV9kZXZpY2UgaXdsd2lmaSBzbmRfcGNtIHBjc3BrciBqb3lkZXYgcHJvY2Vzc29y X3RoZXJtYWxfZGV2aWNlX3BjaV9sZWdhY3kgcHJvY2Vzc29yX3RoZXJtYWxfZGV2aWNlIHNu ZF90aW1lciBzbmQgY2ZnODAyMTEgcHJvY2Vzc29yX3RoZXJtYWxfcmZpbSBpMmNfaTgwMSBw cm9jZXNzb3JfdGhlcm1hbF9tYm94IGkyY19zbWJ1cyBpZG1hNjQgcmZraWxsIHByb2Nlc3Nv cl90aGVybWFsX3JhcGwgc291bmRjb3JlIGludGVsX3JhcGxfY29tbW9uIGludDM0MHhfdGhl cm1hbF96b25lIGludGVsX3NvY19kdHNfaW9zZiBpZ2VuNl9lZGFjIGludGVsX2hpZCBpbnRl bF9wbWNfY29yZSBpbnRlbF9zY3VfcGx0ZHJ2IHNwYXJzZV9rZXltYXAgZnVzZSB4ZW5mcyBp cF90YWJsZXMgZG1fdGhpbl9wb29sDQo+ICAgICAgaWMjMiBQYXJ0MQ0KPiAgICAgIFsgIDM0 OC44MTYyNTldICBkbV9wZXJzaXN0ZW50X2RhdGEgZG1fYmlvX3ByaXNvbiBkbV9jcnlwdCBp OTE1IGNyY3QxMGRpZl9wY2xtdWwgY3JjMzJfcGNsbXVsIGNyYzMyY19pbnRlbCBwb2x5dmFs X2NsbXVsbmkgcG9seXZhbF9nZW5lcmljIGRybV9idWRkeSBudm1lIHZpZGVvIHdtaSBkcm1f ZGlzcGxheV9oZWxwZXIgbnZtZV9jb3JlIHhoY2lfcGNpIHhoY2lfcGNpX3JlbmVzYXMgZ2hh c2hfY2xtdWxuaV9pbnRlbCBoaWRfbXVsdGl0b3VjaCBzaGE1MTJfc3NzZTMgc2VyaW9fcmF3 IG52bWVfY29tbW9uIGNlYyB4aGNpX2hjZCB0dG0gaTJjX2hpZF9hY3BpIGkyY19oaWQgcGlu Y3RybF90aWdlcmxha2UgeGVuX2FjcGlfcHJvY2Vzc29yIHhlbl9wcml2Y21kIHhlbl9wY2li YWNrIHhlbl9ibGtiYWNrIHhlbl9nbnRhbGxvYyB4ZW5fZ250ZGV2IHhlbl9ldnRjaG4gdWlu cHV0DQo+ICAgICAgWyAgMzQ4LjgxNjI4MV0gQ1IyOiAwMDAwMDAwMDAwMDAwMDFjDQo+ICAg ICAgWyAgMzQ4LjgxNjI4M10gLS0tWyBlbmQgdHJhY2UgMDAwMDAwMDAwMDAwMDAwMCBdLS0t DQo+ICAgICAgWyAgMzQ4Ljg2Nzk5MV0gUklQOiBlMDMwOmFjcGlfZ2V0X3dha2V1cF9hZGRy ZXNzKzB4Yy8weDIwDQo+ICAgICAgWyAgMzQ4Ljg2Nzk5Nl0gQ29kZTogNDQgMDAgMDAgNDgg OGIgMDUgMDQgYTMgODIgMDIgYzMgY2MgY2MgY2MgY2MgY2MgY2MgY2MgY2MgY2MgY2MgY2Mg Y2MgY2MgY2MgY2MgY2MgY2MgY2MgY2MgMGYgMWYgNDQgMDAgMDAgNDggOGIgMDUgZmMgOWQg ODIgMDIgPDhiPiA0MCAxYyBjMyBjYyBjYyBjYyBjYyA2NiA2NiAyZSAwZiAxZiA4NCAwMCAw MCAwMCAwMCAwMCA5MCAwZiAxZg0KPiAgICAgIFsgIDM0OC44Njc5OThdIFJTUDogZTAyYjpm ZmZmYzkwMDQyNTM3ZDA4IEVGTEFHUzogMDAwMTAyNDYNCj4gICAgICBbICAzNDguODY3OTk5 XSBSQVg6IDAwMDAwMDAwMDAwMDAwMDAgUkJYOiAwMDAwMDAwMDAwMDAwMDAzIFJDWDogMjBj NDliYTVlMzUzZjdjZg0KPiAgICAgIFsgIDM0OC44NjgwMDBdIFJEWDogMDAwMDAwMDAwMDAw Y2QxOSBSU0k6IDAwMDAwMDAwMDAwMmVlOWEgUkRJOiAwMDJhMDUxZWQ0MmQ3Njk0DQo+ICAg ICAgWyAgMzQ4Ljg2ODAwMV0gUkJQOiAwMDAwMDAwMDAwMDAwMDAzIFIwODogZmZmZmM5MDA0 MjUzN2NhMCBSMDk6IGZmZmZmZmZmODJjNWU0NjgNCj4gICAgICBbICAzNDguODY4MDAxXSBS MTA6IDAwMDAwMDAwMDAwMDdmZjAgUjExOiAwMDAwMDAwMDAwMDAwMDAwIFIxMjogMDAwMDAw MDAwMDAwMDAwMA0KPiAgICAgIFsgIDM0OC44NjgwMDJdIFIxMzogZmZmZmZmZmZmZmZmZmZm MiBSMTQ6IGZmZmY4ODgxMjIwNmU2YzAgUjE1OiBmZmZmODg4MTIyMDZlNmUwDQo+ICAgICAg WyAgMzQ4Ljg2ODAwOF0gRlM6ICAwMDAwN2NiNDliMDFlYjgwKDAwMDApIEdTOmZmZmY4ODgx ODk0MDAwMDAoMDAwMCkga25sR1M6MDAwMDAwMDAwMDAwMDAwMA0KPiAgICAgIFsgIDM0OC44 NjgwMDldIENTOiAgZTAzMCBEUzogMDAwMCBFUzogMDAwMCBDUjA6IDAwMDAwMDAwODAwNTAw MzMNCj4gICAgICBbICAzNDguODY4MDA5XSBDUjI6IDAwMDAwMDAwMDAwMDAwMWMgQ1IzOiAw MDAwMDAwMTIyMzFhMDAwIENSNDogMDAwMDAwMDAwMDA1MDY2MA0KPiAgICAgIFsgIDM0OC44 NjgwMTRdIEtlcm5lbCBwYW5pYyAtIG5vdCBzeW5jaW5nOiBGYXRhbCBleGNlcHRpb24NCj4g ICAgICBbICAzNDguODY4MDMxXSBLZXJuZWwgT2Zmc2V0OiBkaXNhYmxlZA0KPiANCj4gTG9v a2luZyBhdCBnaXQgbG9nIGJldHdlZW4gdGhvc2UgdHdvIHZlcnNpb25zLCBhbmQgdGhlDQo+ IGFjcGlfZ2V0X3dha2V1cF9hZGRyZXNzKCkgZnVuY3Rpb24sIEkgc3VzcGVjdCBpdCdzIHRo aXMgY2hhbmdlIChidXQgSQ0KPiBoYXZlIF9ub3RfIHRlc3RlZCBpdCk6DQo+IA0KPiBjb21t aXQgYjE4OTg3OTM3NzdmZTEwYTMxYzE2MGJiOGJjMzg1ZDZlZWE2NDBjNg0KPiBBdXRob3I6 IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4NCj4gRGF0ZTogICBXZWQgTm92IDIz IDEyOjQ1OjIzIDIwMjIgKzAxMDANCj4gDQo+ICAgICAgeDg2L2Jvb3Q6IFNraXAgcmVhbG1v ZGUgaW5pdCBjb2RlIHdoZW4gcnVubmluZyBhcyBYZW4gUFYgZ3Vlc3QNCj4gICAgICANCj4g ICAgICBbIFVwc3RyZWFtIGNvbW1pdCBmMWU1MjUwMDk0OTNjYmQ1NjllN2M4ZGQ3ZDU4MTU3 ODU1Zjg2NThkIF0NCg0KWWVzLCB5b3UgYXJlIHJpZ2h0Lg0KDQpDb3VsZCB5b3UgcGxlYXNl IHRlc3QgdGhlIGF0dGFjaGVkIHBhdGNoPyBJdCBpcyBmb3IgdXBzdHJlYW0sIGJ1dCBJIHRo aW5rIGl0DQpzaG91bGQgYXBwbHkgdG8gNi4xLjMsIHRvby4NCg0KDQpKdWVyZ2VuDQoNCg0K --------------JTCEnxmZjr8uUX0QsykuUQXk Content-Type: text/x-patch; charset=UTF-8; name="0001-x86-acpi-fix-suspend-with-Xen.patch" Content-Disposition: attachment; filename="0001-x86-acpi-fix-suspend-with-Xen.patch" Content-Transfer-Encoding: base64 RnJvbSA0MDgzM2I2NzAxMDI2YTM3MjQzYmRhOTBiYmQwNTNjNTg5NjM4NDRkIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+ ClRvOiB4ODZAa2VybmVsLm9yZwpUbzogbGludXgta2VybmVsQHZnZXIua2VybmVsLm9yZwpU bzogbGludXgtcG1Admdlci5rZXJuZWwub3JnCkNjOiBUaG9tYXMgR2xlaXhuZXIgPHRnbHhA bGludXRyb25peC5kZT4KQ2M6IEluZ28gTW9sbmFyIDxtaW5nb0ByZWRoYXQuY29tPgpDYzog Qm9yaXNsYXYgUGV0a292IDxicEBhbGllbjguZGU+CkNjOiBEYXZlIEhhbnNlbiA8ZGF2ZS5o YW5zZW5AbGludXguaW50ZWwuY29tPgpDYzogIkguIFBldGVyIEFudmluIiA8aHBhQHp5dG9y LmNvbT4KQ2M6ICJSYWZhZWwgSi4gV3lzb2NraSIgPHJhZmFlbEBrZXJuZWwub3JnPgpDYzog TGVuIEJyb3duIDxsZW4uYnJvd25AaW50ZWwuY29tPgpDYzogUGF2ZWwgTWFjaGVrIDxwYXZl bEB1Y3cuY3o+CkNjOiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+CkNjOiBTdGVm YW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+CkNjOiBPbGVrc2FuZHIg VHlzaGNoZW5rbyA8b2xla3NhbmRyX3R5c2hjaGVua29AZXBhbS5jb20+CkNjOiB4ZW4tZGV2 ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKRGF0ZTogRnJpLCAxMyBKYW4gMjAyMyAwODozNzo0 NSArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIHg4Ni9hY3BpOiBmaXggc3VzcGVuZCB3aXRoIFhl bgpNSU1FLVZlcnNpb246IDEuMApDb250ZW50LVR5cGU6IHRleHQvcGxhaW47IGNoYXJzZXQ9 VVRGLTgKQ29udGVudC1UcmFuc2Zlci1FbmNvZGluZzogOGJpdAoKQ29tbWl0IGYxZTUyNTAw OTQ5MyAoIng4Ni9ib290OiBTa2lwIHJlYWxtb2RlIGluaXQgY29kZSB3aGVuIHJ1bm5pbmcg YXMKWGVuIFBWIGd1ZXN0IikgbWlzc2VkIG9uZSBjb2RlIHBhdGggYWNjZXNzaW5nIHJlYWxf bW9kZV9oZWFkZXIsIGxlYWRpbmcKdG8gZGVyZWZlcmVuY2luZyBOVUxMIHdoZW4gc3VzcGVu ZGluZyB0aGUgc3lzdGVtIHVuZGVyIFhlbjoKCiAgICBbICAzNDguMjg0MDA0XSBQTTogc3Vz cGVuZCBlbnRyeSAoZGVlcCkKICAgIFsgIDM0OC4yODk1MzJdIEZpbGVzeXN0ZW1zIHN5bmM6 IDAuMDA1IHNlY29uZHMKICAgIFsgIDM0OC4yOTE1NDVdIEZyZWV6aW5nIHVzZXIgc3BhY2Ug cHJvY2Vzc2VzIC4uLiAoZWxhcHNlZCAwLjAwMCBzZWNvbmRzKSBkb25lLgogICAgWyAgMzQ4 LjI5MjQ1N10gT09NIGtpbGxlciBkaXNhYmxlZC4KICAgIFsgIDM0OC4yOTI0NjJdIEZyZWV6 aW5nIHJlbWFpbmluZyBmcmVlemFibGUgdGFza3MgLi4uIChlbGFwc2VkIDAuMTA0IHNlY29u ZHMpIGRvbmUuCiAgICBbICAzNDguMzk2NjEyXSBwcmludGs6IFN1c3BlbmRpbmcgY29uc29s ZShzKSAodXNlIG5vX2NvbnNvbGVfc3VzcGVuZCB0byBkZWJ1ZykKICAgIFsgIDM0OC43NDky MjhdIFBNOiBzdXNwZW5kIGRldmljZXMgdG9vayAwLjM1MiBzZWNvbmRzCiAgICBbICAzNDgu NzY5NzEzXSBBQ1BJOiBFQzogaW50ZXJydXB0IGJsb2NrZWQKICAgIFsgIDM0OC44MTYwNzdd IEJVRzoga2VybmVsIE5VTEwgcG9pbnRlciBkZXJlZmVyZW5jZSwgYWRkcmVzczogMDAwMDAw MDAwMDAwMDAxYwogICAgWyAgMzQ4LjgxNjA4MF0gI1BGOiBzdXBlcnZpc29yIHJlYWQgYWNj ZXNzIGluIGtlcm5lbCBtb2RlCiAgICBbICAzNDguODE2MDgxXSAjUEY6IGVycm9yX2NvZGUo MHgwMDAwKSAtIG5vdC1wcmVzZW50IHBhZ2UKICAgIFsgIDM0OC44MTYwODNdIFBHRCAwIFA0 RCAwCiAgICBbICAzNDguODE2MDg2XSBPb3BzOiAwMDAwIFsjMV0gUFJFRU1QVCBTTVAgTk9Q VEkKICAgIFsgIDM0OC44MTYwODldIENQVTogMCBQSUQ6IDY3NjQgQ29tbTogc3lzdGVtZC1z bGVlcCBOb3QgdGFpbnRlZCA2LjEuMy0xLmZjMzIucXViZXMueDg2XzY0ICMxCiAgICBbICAz NDguODE2MDkyXSBIYXJkd2FyZSBuYW1lOiBTdGFyIExhYnMgU3RhckJvb2svU3RhckJvb2ss IEJJT1MgOC4wMSAwNy8wMy8yMDIyCiAgICBbICAzNDguODE2MDkzXSBSSVA6IGUwMzA6YWNw aV9nZXRfd2FrZXVwX2FkZHJlc3MrMHhjLzB4MjAKCkZpeCB0aGF0IGJ5IGFkZGluZyBhbiBp bmRpcmVjdGlvbiBmb3IgYWNwaV9nZXRfd2FrZXVwX2FkZHJlc3MoKSB3aGljaApYZW4gUFYg ZG9tMCBjYW4gdXNlIHRvIHJldHVybiBhIGR1bW15IG5vbi16ZXJvIHdha2V1cCBhZGRyZXNz ICh0aGlzCmFkZHJlc3Mgd29uJ3QgZXZlciBiZSB1c2VkLCBhcyB0aGUgcmVhbCBzdXNwZW5k IGhhbmRsaW5nIGlzIGRvbmUgYnkgdGhlCmh5cGVydmlzb3IpLgoKRml4ZXM6IGYxZTUyNTAw OTQ5MyAoIng4Ni9ib290OiBTa2lwIHJlYWxtb2RlIGluaXQgY29kZSB3aGVuIHJ1bm5pbmcg YXMgWGVuIFBWIGd1ZXN0IikKUmVwb3J0ZWQtYnk6IE1hcmVrIE1hcmN6eWtvd3NraS1Hw7Ny ZWNraSA8bWFybWFyZWtAaW52aXNpYmxldGhpbmdzbGFiLmNvbT4KU2lnbmVkLW9mZi1ieTog SnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPgotLS0KIGFyY2gveDg2L2luY2x1ZGUv YXNtL2FjcGkuaCAgfCAyICstCiBhcmNoL3g4Ni9rZXJuZWwvYWNwaS9zbGVlcC5jIHwgMyAr Ky0KIGluY2x1ZGUveGVuL2FjcGkuaCAgICAgICAgICAgfCA5ICsrKysrKysrKwogMyBmaWxl cyBjaGFuZ2VkLCAxMiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdp dCBhL2FyY2gveDg2L2luY2x1ZGUvYXNtL2FjcGkuaCBiL2FyY2gveDg2L2luY2x1ZGUvYXNt L2FjcGkuaAppbmRleCA2NTA2NGQ5ZjdmYTYuLjEzNzI1OWZmOGYwMyAxMDA2NDQKLS0tIGEv YXJjaC94ODYvaW5jbHVkZS9hc20vYWNwaS5oCisrKyBiL2FyY2gveDg2L2luY2x1ZGUvYXNt L2FjcGkuaApAQCAtNjEsNyArNjEsNyBAQCBzdGF0aWMgaW5saW5lIHZvaWQgYWNwaV9kaXNh YmxlX3BjaSh2b2lkKQogZXh0ZXJuIGludCAoKmFjcGlfc3VzcGVuZF9sb3dsZXZlbCkodm9p ZCk7CiAKIC8qIFBoeXNpY2FsIGFkZHJlc3MgdG8gcmVzdW1lIGFmdGVyIHdha2V1cCAqLwot dW5zaWduZWQgbG9uZyBhY3BpX2dldF93YWtldXBfYWRkcmVzcyh2b2lkKTsKK2V4dGVybiB1 bnNpZ25lZCBsb25nICgqYWNwaV9nZXRfd2FrZXVwX2FkZHJlc3MpKHZvaWQpOwogCiAvKgog ICogQ2hlY2sgaWYgdGhlIENQVSBjYW4gaGFuZGxlIEMyIGFuZCBkZWVwZXIKZGlmZiAtLWdp dCBhL2FyY2gveDg2L2tlcm5lbC9hY3BpL3NsZWVwLmMgYi9hcmNoL3g4Ni9rZXJuZWwvYWNw aS9zbGVlcC5jCmluZGV4IDNiN2Y0Y2RiZjJlMC4uMWEzY2Q1ZTI0Y2QwIDEwMDY0NAotLS0g YS9hcmNoL3g4Ni9rZXJuZWwvYWNwaS9zbGVlcC5jCisrKyBiL2FyY2gveDg2L2tlcm5lbC9h Y3BpL3NsZWVwLmMKQEAgLTMzLDEwICszMywxMSBAQCBzdGF0aWMgY2hhciB0ZW1wX3N0YWNr WzQwOTZdOwogICogUmV0dXJucyB0aGUgcGh5c2ljYWwgYWRkcmVzcyB3aGVyZSB0aGUga2Vy bmVsIHNob3VsZCBiZSByZXN1bWVkIGFmdGVyIHRoZQogICogc3lzdGVtIGF3YWtlcyBmcm9t IFMzLCBlLmcuIGZvciBwcm9ncmFtbWluZyBpbnRvIHRoZSBmaXJtd2FyZSB3YWtpbmcgdmVj dG9yLgogICovCi11bnNpZ25lZCBsb25nIGFjcGlfZ2V0X3dha2V1cF9hZGRyZXNzKHZvaWQp CitzdGF0aWMgdW5zaWduZWQgbG9uZyB4ODZfYWNwaV9nZXRfd2FrZXVwX2FkZHJlc3Modm9p ZCkKIHsKIAlyZXR1cm4gKCh1bnNpZ25lZCBsb25nKShyZWFsX21vZGVfaGVhZGVyLT53YWtl dXBfc3RhcnQpKTsKIH0KK3Vuc2lnbmVkIGxvbmcgKCphY3BpX2dldF93YWtldXBfYWRkcmVz cykodm9pZCkgPSB4ODZfYWNwaV9nZXRfd2FrZXVwX2FkZHJlc3M7CiAKIC8qKgogICogeDg2 X2FjcGlfZW50ZXJfc2xlZXBfc3RhdGUgLSBlbnRlciBzbGVlcCBzdGF0ZQpkaWZmIC0tZ2l0 IGEvaW5jbHVkZS94ZW4vYWNwaS5oIGIvaW5jbHVkZS94ZW4vYWNwaS5oCmluZGV4IGIxZTEx ODYzMTQ0ZC4uN2UxZTVkYmZiNzdjIDEwMDY0NAotLS0gYS9pbmNsdWRlL3hlbi9hY3BpLmgK KysrIGIvaW5jbHVkZS94ZW4vYWNwaS5oCkBAIC01Niw2ICs1NiwxMiBAQCBzdGF0aWMgaW5s aW5lIGludCB4ZW5fYWNwaV9zdXNwZW5kX2xvd2xldmVsKHZvaWQpCiAJcmV0dXJuIDA7CiB9 CiAKK3N0YXRpYyBpbmxpbmUgdW5zaWduZWQgbG9uZyB4ZW5fYWNwaV9nZXRfd2FrZXVwX2Fk ZHJlc3Modm9pZCkKK3sKKwkvKiBKdXN0IHJldHVybiBhIGR1bW15IG5vbi16ZXJvIHZhbHVl LCBpdCB3aWxsIG5ldmVyIGJlIHVzZWQuICovCisJcmV0dXJuIDE7Cit9CisKIHN0YXRpYyBp bmxpbmUgdm9pZCB4ZW5fYWNwaV9zbGVlcF9yZWdpc3Rlcih2b2lkKQogewogCWlmICh4ZW5f aW5pdGlhbF9kb21haW4oKSkgewpAQCAtNjUsNiArNzEsOSBAQCBzdGF0aWMgaW5saW5lIHZv aWQgeGVuX2FjcGlfc2xlZXBfcmVnaXN0ZXIodm9pZCkKIAkJCSZ4ZW5fYWNwaV9ub3RpZnlf aHlwZXJ2aXNvcl9leHRlbmRlZF9zbGVlcCk7CiAKIAkJYWNwaV9zdXNwZW5kX2xvd2xldmVs ID0geGVuX2FjcGlfc3VzcGVuZF9sb3dsZXZlbDsKKyNpZmRlZiBDT05GSUdfQUNQSV9TTEVF UAorCQlhY3BpX2dldF93YWtldXBfYWRkcmVzcyA9IHhlbl9hY3BpX2dldF93YWtldXBfYWRk cmVzczsKKyNlbmRpZgogCX0KIH0KICNlbHNlCi0tIAoyLjM1LjMKCg== --------------JTCEnxmZjr8uUX0QsykuUQXk Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------JTCEnxmZjr8uUX0QsykuUQXk-- --------------LaTlo7JDqFZbSkQGkk2AzUwV-- --------------78E4ABhTHO0B4lG8jyzNTay2 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPBEYMFAwAAAAAACgkQsN6d1ii/Ey/1 igf9FogeEHwsEjMohtO440DwmpQMGvUnv4pOEMrtP6NkUzx7UuOD//OrqK54yAPU4/assRZWBqB2 Er6qVknG6D4n5TEJ79znvPedLcmsQtxuRC2BRZBUpIDYxaf1lpc23mvPEsur5BQNvBVR18i3ERb+ GCI11aRyqVXcdk4/TMHKrrlB73TEw3ZbD2dSa9+9E3P3M4nuR89jVvgGR/tawSg6gcWXjJcP4WkA toQByX0NloIqCMydj+lgnAwPxrWoMwDDsGWb6ntcNBiURbjH0JLcPyxE+LoweLUUdWlviRB4CJ0k Vk1D9e+Q0VtE2+8AArEunaErMPsRYpVb+AYIC3TClQ== =4rhg -----END PGP SIGNATURE----- --------------78E4ABhTHO0B4lG8jyzNTay2-- From xen-devel-bounces@lists.xenproject.org Fri Jan 13 08:10:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 08:10:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476829.739200 (Exim 4.92) (envelope-from ) id 1pGF8m-0007MN-Cl; Fri, 13 Jan 2023 08:10:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476829.739200; Fri, 13 Jan 2023 08:10:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGF8m-0007MG-9S; Fri, 13 Jan 2023 08:10:20 +0000 Received: by outflank-mailman (input) for mailman id 476829; Fri, 13 Jan 2023 08:10:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGF8k-0007M6-GO for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 08:10:18 +0000 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [2a00:1450:4864:20::62c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b70e21f8-9319-11ed-91b6-6bf2151ebd3b; Fri, 13 Jan 2023 09:10:17 +0100 (CET) Received: by mail-ej1-x62c.google.com with SMTP id vm8so50474685ejc.2 for ; Fri, 13 Jan 2023 00:10:17 -0800 (PST) Received: from [192.168.1.93] (adsl-139.109.242.225.tellas.gr. [109.242.225.139]) by smtp.gmail.com with ESMTPSA id g2-20020a170906538200b0085c3f08081esm3431892ejo.13.2023.01.13.00.10.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Jan 2023 00:10:16 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b70e21f8-9319-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jLVRvKluyxNeRdZUwXoZTpFf6e3KVsHC6MuFrshYUQ0=; b=G6jZ6mSMyAArHIk9Tdtxxg+YG704AD1UGfK5U0JGphQYJM76y2WwU8nc5m4BspUsF6 97+f6kArUNV7v1pKh9SIbqSCE6oOxtWgqO0ZXtRbDnpTdu21IHdv2TJ6or/UszF/YmnK JFaK7tkm0D6FJbsBlNPdf/ct+7He99JsXXgewxt29E8na7m4XGTC1CpWI5dkGWR6XewO JFfM6hK4EBCTFEpqahq30L23PEMbEggmft19pd33MWLWSKtQH/bAsXilz5knCkib6o5R RyMkeo0YICUPx/JRwwcHGRWhBWEuIL0S9zP14JNOGEU+Kt6rpZjhqb3gKzJ3FDdMRDtr Gv/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jLVRvKluyxNeRdZUwXoZTpFf6e3KVsHC6MuFrshYUQ0=; b=P/sbUcdV08FVME/8/pr9f2m5V7JEOQvYJdGaIQ6X9CtgBuofkYbtQ/DME6odKKD8KL qkxvjUUfoN/IhMUYYbPia5y1flar+fspP7EcC6zeO0kDUVvsDLjfmBaJsvsU1Zwxm2S1 ESufJihYwZRTMiL0uNTZzeVtFPf42xz+nYdtDhb1VIzviPDoHcIwOlD0E8Kf3HENO8XX s690L1Zp8o4PM7vm/9XwAEKSyQRQPc+VyifRIEqpsPWRHpFQR88YQ5pwX/N/d7t3bYw8 KZaejpKYivtnqATG94g2HEthcvfeNe2hQUn/0zkUhhVK2sRXXdg8nh6V34MD75s2nQt0 +ioA== X-Gm-Message-State: AFqh2kqS1glJTg1JQ+292TrfqFN9OllFUchpgRsnoY94AHKnMGRHg2na 0Rp7qVqi4w50+evE1bpPmqA= X-Google-Smtp-Source: AMrXdXttuK5yqRd+vPPA3pxoKjyWE0YytZTEfIF+frYYOQiH1tDMfrHNDZrJ2I7iiGeJEqMlqzLwYQ== X-Received: by 2002:a17:906:86cc:b0:869:3b49:35c2 with SMTP id j12-20020a17090686cc00b008693b4935c2mr2134775ejy.61.1673597417044; Fri, 13 Jan 2023 00:10:17 -0800 (PST) Message-ID: Date: Fri, 13 Jan 2023 10:10:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v2 3/8] x86/iommu: iommu_igfx, iommu_qinval and iommu_snoop are VT-d specific Content-Language: en-US To: Jan Beulich Cc: Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20230104084502.61734-1-burzalodowa@gmail.com> <20230104084502.61734-4-burzalodowa@gmail.com> <4bc3f2f6-9bf4-5810-89e3-526470e72d85@gmail.com> From: Xenia Ragiadakou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 1/12/23 17:53, Jan Beulich wrote: > On 12.01.2023 16:43, Xenia Ragiadakou wrote: >> On 1/12/23 13:49, Xenia Ragiadakou wrote: >>> On 1/12/23 13:31, Jan Beulich wrote: >>>> On 04.01.2023 09:44, Xenia Ragiadakou wrote: >>>>> --- a/xen/include/xen/iommu.h >>>>> +++ b/xen/include/xen/iommu.h >>>>> @@ -74,9 +74,13 @@ extern enum __packed iommu_intremap { >>>>>      iommu_intremap_restricted, >>>>>      iommu_intremap_full, >>>>>   } iommu_intremap; >>>>> -extern bool iommu_igfx, iommu_qinval, iommu_snoop; >>>>>   #else >>>>>   # define iommu_intremap false >>>>> +#endif >>>>> + >>>>> +#ifdef CONFIG_INTEL_IOMMU >>>>> +extern bool iommu_igfx, iommu_qinval, iommu_snoop; >>>>> +#else >>>>>   # define iommu_snoop false >>>>>   #endif >>>> >>>> Do these declarations really need touching? In patch 2 you didn't move >>>> amd_iommu_perdev_intremap's either. >>> >>> Ok, I will revert this change (as I did in v2 of patch 2) since it is >>> not needed. >> >> Actually, my patch was altering the current behavior by defining >> iommu_snoop as false when !INTEL_IOMMU. >> >> IIUC, there is no control over snoop behavior when using the AMD iommu. >> Hence, iommu_snoop should evaluate to true for AMD iommu. >> However, when using the INTEL iommu the user can disable it via the >> "iommu" param, right? > > That's the intended behavior, yes, but right now we allow the option > to also affect behavior on AMD - perhaps wrongly so, as there's one > use outside of VT-x and VT-d code. But of course the option is > documented to be there for VT-d only, so one can view it as user > error if it's used on a non-VT-d system. > >> If that's the case then iommu_snoop needs to be moved from vtd/iommu.c >> to x86/iommu.c and iommu_snoop assignment via iommu param needs to be >> guarded by CONFIG_INTEL_IOMMU. > > Or #define to true when !INTEL_IOMMU and keep the variable where it > is. Given the current implementation, if defined to true, it will be true even when !iommu_enabled. -- Xenia From xen-devel-bounces@lists.xenproject.org Fri Jan 13 08:14:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 08:14:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476835.739210 (Exim 4.92) (envelope-from ) id 1pGFCQ-0007zk-W1; Fri, 13 Jan 2023 08:14:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476835.739210; Fri, 13 Jan 2023 08:14:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGFCQ-0007zd-TN; Fri, 13 Jan 2023 08:14:06 +0000 Received: by outflank-mailman (input) for mailman id 476835; Fri, 13 Jan 2023 08:14:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGFCP-0007zX-Lu for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 08:14:05 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3d6ee2ea-931a-11ed-b8d0-410ff93cb8f0; Fri, 13 Jan 2023 09:14:03 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C6444601CA; Fri, 13 Jan 2023 08:14:02 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7BAEF13918; Fri, 13 Jan 2023 08:14:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ChC1HMoSwWMcTgAAMHmgww (envelope-from ); Fri, 13 Jan 2023 08:14:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3d6ee2ea-931a-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1673597642; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=C3+MDGHRrGYRh8vwODotk/nPLYTNxff0308LBuGGZfg=; b=RYIeljUuSxnit3GLJZrTuqeePPe+Chmf7EKuF1QvSH4wKzgNSdpOW7xncMxFj3H2HfYNKa 5poSrglahhvOdssZhZkmGzR0+Ws2msk3QdJgYfWyPLmhairkZf/z5e7xmVG1XnR1RpqyJe lCFA3RzlYyosLPIn9sjefy0mAL0ZK9E= Message-ID: <457cc617-0cd2-fef8-c095-925c3c56c597@suse.com> Date: Fri, 13 Jan 2023 09:14:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [RFC][PATCH 1/6] x86/power: De-paravirt restore_processor_state() Content-Language: en-US To: Peter Zijlstra , x86@kernel.org, Joan Bruguera Cc: linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , xen-devel , Jan Beulich , Roger Pau Monne , Kees Cook , mark.rutland@arm.com References: <20230112143141.645645775@infradead.org> <20230112143825.584639584@infradead.org> From: Juergen Gross In-Reply-To: <20230112143825.584639584@infradead.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------o7qDRswZ9yx5PFp5BINIokek" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------o7qDRswZ9yx5PFp5BINIokek Content-Type: multipart/mixed; boundary="------------0d4qDtsPpoGsM03O4Be40BeT"; protected-headers="v1" From: Juergen Gross To: Peter Zijlstra , x86@kernel.org, Joan Bruguera Cc: linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , xen-devel , Jan Beulich , Roger Pau Monne , Kees Cook , mark.rutland@arm.com Message-ID: <457cc617-0cd2-fef8-c095-925c3c56c597@suse.com> Subject: Re: [RFC][PATCH 1/6] x86/power: De-paravirt restore_processor_state() References: <20230112143141.645645775@infradead.org> <20230112143825.584639584@infradead.org> In-Reply-To: <20230112143825.584639584@infradead.org> --------------0d4qDtsPpoGsM03O4Be40BeT Content-Type: multipart/mixed; boundary="------------9ofMRWg0rFZOPtEySebYEw6A" --------------9ofMRWg0rFZOPtEySebYEw6A Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTIuMDEuMjMgMTU6MzEsIFBldGVyIFppamxzdHJhIHdyb3RlOg0KPiBTaW5jZSBYZW4g UFYgZG9lc24ndCB1c2UgcmVzdG9yZV9wcm9jZXNzb3Jfc3RhdGUoKSwgYW5kIHdlJ3JlIGdv aW5nIHRvDQo+IGhhdmUgdG8gYXZvaWQgQ0FMTC9SRVQgdW50aWwgYXQgbGVhc3QgR1MgaXMg cmVzdG9yZWQsIGRlLXBhcmF2aXJ0IHRoZQ0KPiBlYXN5IGJpdHMuDQo+IA0KPiBTaWduZWQt b2ZmLWJ5OiBQZXRlciBaaWpsc3RyYSAoSW50ZWwpIDxwZXRlcnpAaW5mcmFkZWFkLm9yZz4N Cg0KUmV2aWV3ZWQtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4NCg0Kd2l0 aCBvbmUgcmVtYXJrOiBzYXZlX3Byb2Nlc3Nvcl9zdGF0ZSgpIGNvdWxkIGJlIGNoYW5nZWQg dGhlIHNhbWUgd2F5Lg0KDQoNCkp1ZXJnZW4NCg0K --------------9ofMRWg0rFZOPtEySebYEw6A Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------9ofMRWg0rFZOPtEySebYEw6A-- --------------0d4qDtsPpoGsM03O4Be40BeT-- --------------o7qDRswZ9yx5PFp5BINIokek Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPBEsoFAwAAAAAACgkQsN6d1ii/Ey8d Rwf/Y2IUCHkCou1Aa3zROg6KibgZdzhOt1vQuoErqYeXj8fSaUY98kFKD0CfwxdJJuAGZDmLu2GW iInBABAIMwcuFzkJRbLUEht152ECE85BhIrmLK1fw3uy2jdakIsq7H2u+xVGqWTiJla7JS4/eN+5 aHUEz6vj6YqUZ53+DZXeJsfZbRj0FsHclUwXmTuhpem9RDkKxYjcPu8VmYmKRVCSlocDfWEF2ydR XKJY+aX0OX0ZY2Mk9TWa5F37VsDDdN+tTm2wyupl7hElNpnZ4N6zTVdxebCrwB77DhLOqD6g2mhi TUYad6ydXxJLgdef+mTEO3gelc1AjWn/WI3BvHq/Cg== =53mK -----END PGP SIGNATURE----- --------------o7qDRswZ9yx5PFp5BINIokek-- From xen-devel-bounces@lists.xenproject.org Fri Jan 13 08:39:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 08:39:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476841.739222 (Exim 4.92) (envelope-from ) id 1pGFb0-00023n-20; Fri, 13 Jan 2023 08:39:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476841.739222; Fri, 13 Jan 2023 08:39:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGFaz-00023g-Ux; Fri, 13 Jan 2023 08:39:29 +0000 Received: by outflank-mailman (input) for mailman id 476841; Fri, 13 Jan 2023 08:39:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGFay-00023a-Pf for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 08:39:28 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2049.outbound.protection.outlook.com [40.107.20.49]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ca1072bd-931d-11ed-91b6-6bf2151ebd3b; Fri, 13 Jan 2023 09:39:27 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7719.eurprd04.prod.outlook.com (2603:10a6:20b:29a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.12; Fri, 13 Jan 2023 08:39:25 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Fri, 13 Jan 2023 08:39:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ca1072bd-931d-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kr0Dy+a3QHf6kFJmMHkBA8xASRoY249CXrOGs6EIjnI7RBd6RrlDQp5KLWdoMwxMvZW8+knvFYk/qz5bm83h/XHp8o5B270AkuWfiDaW63VHLemxy7HpgAZRFsBTlNOQb6V5fg6ZT1kONM4TZHlCaU0HXUP2UXvl6izTqCefnzU3Obv/Mg/HMnR91RN+rFkObKgKNdCygwX6puoL5xsmNmKjNF2kS8CftwhaO62u2+CaenRugectNVOYnZzZlTB17iMqmxA4ZrrM0BUIlYvo29yTrzSd+MiC9/u16Dtfruo1joZAuAwFL1vK86zC9NrxhkImLf0wbgViVDMp/83L4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n8StdBSUm+VmJk5Ih9218PPvQ1Hl08H3FHmwUGtF2OA=; b=g7xthdexPrAklO2dOerTqdZBDc/nGS5deAcSMuj3E1+wFp3zWaSJLbxGqeBt5UDz4Eo80OfoLhsoLHevG4b4kptw/rHKy1euAO9Pm7V8ABmLFJiofRKrNxjY7XF/dyZyAAYED2SW8FuMY4oZvclTtN/gxrkxSB3eU9fTUEWsKRE0p92GbVsLeNqAQPyWJo17ygtoszi7OqeyagQuhNf8tfs/6KY+TRl6B7au+YLVRXV8veXSuszlaHL8j4YIRzh+yy3aAbctJcxuQ0xKtu3GXLjXrvK9AW20DlRJvAemmS2YxF5PD9O5sDP5ohQ3hWUXG1X9eg/b0J6r8KRs5NxXAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n8StdBSUm+VmJk5Ih9218PPvQ1Hl08H3FHmwUGtF2OA=; b=ZWkgLSESwbRP5OmN2ov9qC4roB8RI9r3tHyLg3HQ6ISsxePFcWlgNcB4RtoC/RXxBzJF4J8DfPG3E9l/d4X7eJtsln6DdHsEe4Yhb1+0W+wDIDrQFhc/0NpTwRuraK5EoDxExyX2flatU3T5Qaah14ozwURXAoSi45aTI65rPERj0n3rj2PEhScS6RCTqgLGSwhsFiw96XHcHXDzQbSF0yfIla/or8qx37OuzIzujfhh8r89m5kmP8F7uKCWk7sJV8EotO2MT/8tFHVA9MZ2ySfTzaQmOg2mQELgM2nZvlbt2561OFmVCodFfy5VzUhNVaCD6T7w5eB3uwyliCNyhg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <43cd6b65-0131-47a8-ce45-cc5d7ea25685@suse.com> Date: Fri, 13 Jan 2023 09:39:23 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 3/8] x86/iommu: iommu_igfx, iommu_qinval and iommu_snoop are VT-d specific Content-Language: en-US To: Xenia Ragiadakou Cc: Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20230104084502.61734-1-burzalodowa@gmail.com> <20230104084502.61734-4-burzalodowa@gmail.com> <4bc3f2f6-9bf4-5810-89e3-526470e72d85@gmail.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0031.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB7719:EE_ X-MS-Office365-Filtering-Correlation-Id: 9e8c41f6-5d8e-495b-0d36-08daf541ad57 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5Rz71uC2uDcZrUdKuX2LHId3A0XZoXmOy7f/Jg5GonmPr9lY/FL7uMoGfP/gX0nRaTtSoG9Z3bjASUr7LRBSrW76BLuJdEPIeQwm4su0Q09Hz/a+qeyeJSvM5IfoTo0V1J5ECCx8R/JqAjzj5zMoT17BExwERuco93z14YNBMd2xyUak1piujDYO9alOb5A6tXcZxOWIZvk7cqWomIHWWKV1o3laxGbp6sjfHRyL82EYZqMDTPPJDUG4uFXoQ84LzfXZqqRVpFhpl6hF9OfJUJM6lrHFJAJu36jaLIqarJWwr3JEQ8ROgLrqVYimkyL6Nex8fWrWgXWF11tJVg6kksXY3XbTBNiitclqPBulrDVOAfl+++Svt1SobAfwJ/aI6Q/Bsaf0Cxae4t7zSmstOmOqOagFXeSLhW2I2WVpiZI8qk6Bkj2316vyW8QW5RBcgu5A4GMh3xyzczR2dPqtq/56VtvjTTIG5NcZJe3G7SYue1yjNd3E54P1HjZPqAc+1DeVH5aFsNFBY1r2jeTuxT64cfWWkdcDsPC5RyI7Eqsoc0mqGMPkSNjJzMaa1gxNiShMUPfa+8rrAkFYvVssE4PPt0WTL8CRAn93n/YILtadVhTdJMqZOaqVESxW+xViiVqKqBjyRejAZTVThRmC4KYp0RDC8JA5dFurbh0B1F2OkZmHQZ1ZDjlgyLjYy87Fwiijx4bLHlav26gEqvUVU92fQaM9at+ANIPJYg5vByk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(346002)(39860400002)(376002)(396003)(366004)(451199015)(41300700001)(66556008)(31686004)(8676002)(6916009)(66476007)(66946007)(4326008)(5660300002)(54906003)(8936002)(316002)(2906002)(86362001)(38100700002)(6486002)(36756003)(478600001)(186003)(26005)(31696002)(6506007)(53546011)(2616005)(6512007)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U0VnMHFQK3ZwN21aVkxodTgySm1QSXRpVWRNT2dEWDR4QXFWUVdSZ1J1THFw?= =?utf-8?B?aVNiVkxsblAxUndwM2pWQTB2aVJ1dmZkbFF0Z3E3d1kxWmRrTjZISGhpV01B?= =?utf-8?B?VEhuSDU4ZmlMWC92K0lJcjRDZTJ3VVhCNEZBNlJXd0VPemQ2Rk9TYTZjQzJW?= =?utf-8?B?Ri82YkwyVER1MHd6dnhQYS9FYUdWTlVvbWVUUkdpampyNkJWVjg3Y3o4bFpv?= =?utf-8?B?aHptZ1B3Tk1zMWl3Y1RCcFhpcnJtMHJEb2lKNDRJbnlBQ1F4ZDFldUszWVY5?= =?utf-8?B?c2N5c3RrSnlEQ3d0RE1VRnRPdnFYN1JLa2JTYURocmQxUmxDY1RZc3VJS3Q4?= =?utf-8?B?RStML2N3ekVwM3N2WVk3YUNZQTc2UDFaVnB6MEpPK0tlYlVQQWk1VlRPVVFn?= =?utf-8?B?V05qK3lrdWxqKzArMUxORUdpVVJuTUxVRW5tLzZJMERSeFhpTi96ZDE4bk4r?= =?utf-8?B?YXdEZ21INk9hS0R0NDdDM2NBVGFGeWFJMjgrYXpRL0hYYmkya0Nxb1BXY0c0?= =?utf-8?B?eWd3V1RvQ3A3Q1JkOTBrN0hVeTkzRGdtaTlXMzlCcDVqYWQwQjZwTGtlc29s?= =?utf-8?B?Sld0cTYrSXlQM3FKbGVqWCtuc3Z2Q1Zhbmg4cjdDSWVqNElaTlpBdHhGNE1r?= =?utf-8?B?T0tOZ2JiNUF0MWk4ZkFFTTJ0ZE45dVROMGxraWV0SXJXd1F5ZXJJR1AyZGRN?= =?utf-8?B?S3o4V2NBdEVNbjRremVkVk4rYXN6N3I4SnNPdXRBam9zOVRHcDhHZ1BOZDls?= =?utf-8?B?TXZsOG5qMlRpalRzTjlCdjNWa3VhYWRTLzhyNXhTazRYS0lzck1wcTNhNVla?= =?utf-8?B?WnB6Wm1tSXVRcWpSbFQzaHN4UU96b2Q3bVZDS1NlSE82cVRmUVdtMWhOdFZR?= =?utf-8?B?STREL3FUaXRBT0l5OHZ2RlpmTlM4MUVNWnprdWFLL01MV2VMNTc2Mk5Mb3Ir?= =?utf-8?B?UmpTOFFRZmZ0ckJJcWgyL014VTh2bUdVZ1ZkdVBRZ0lMRWl5QlhTRGtYeWZ1?= =?utf-8?B?bFZ3ckQ3TFQwei9aaVQ0VHZpVFU4NVZvZkgvNUFvVEVvS1hmdGcrdVIwUEhr?= =?utf-8?B?YW9Bd3ZzOHFtRS9jRkJFeW8vcmpGdWVxRnd0UjF2dmNFVWxCNUhFbGpRcTNT?= =?utf-8?B?ck0wdGthR2ovM3dNNGR2SzdhdXVubVpEK0ZGZFFkTkl3MFpvOE9QbDUrcVAv?= =?utf-8?B?RDFMbDdiclZKMWdEZXQyT3FxWG5jdDVibTRRYW1sZkVnZytrbXAraDRiUkRo?= =?utf-8?B?dmcwNXhoWThnTXBJM3gyakhkNml3ZmhCR2d1bXFyanZrSHR6dFRoWFp1aTBq?= =?utf-8?B?Sk9QbXNFd0U5Vml5eDNyZFJlWUdiNi9FTUYwZEJVRUdiOEpMakZ3U0puL21N?= =?utf-8?B?WE0yREtUL0dCcnRtNzd5N1hNemQrcllCZCt6MHlQOENxYTlQbWRjTDEyTjlK?= =?utf-8?B?VC9mOEVZUFNZdXZnaHByZHBzRnNIOHBzZ3k2OUF1SVY5TjB4SldTOG9UOVF6?= =?utf-8?B?b3pYdVJUd0F5QzBiSG9HNHo0aFZZVGIzYWdHbkZ6YzhYV0lJdWhlSDExWWdY?= =?utf-8?B?NUg1ZWxzekxMUVVta01XQmg2alh2Q3J1c2VYby9hM2dOV1lSTXdOcElXcnRU?= =?utf-8?B?OHV1NkZZOGwzU2hBcFh2djkzeXplb3B1eXdpQWtZOFV1N0Vxak01ak94MVNr?= =?utf-8?B?UXZvS21HRmcwL0J6NkZVNm1CSFR3QUlWWFFURmdSRXdwMjVmY2NEcGlpNFR6?= =?utf-8?B?WkFwRXdKQ2Y4blljMndJNGRuVFpSSEMydDFmZmFRVzFELzNpVlFYcFA2T3lD?= =?utf-8?B?enZwV01wWTVSYWlld2NvdW5DQkZSSkRPK0tQejhJZW9OZ3hDOFU2c1VJd0dG?= =?utf-8?B?MTVTZ1hVbjJUTkI0T0xQY1EvSDgzL21PVTRaQldIRExIQXhsVTVNRFc4SUhw?= =?utf-8?B?NktRV0JoUXV1TUtDemZ3TlluSjZ0UXk2dEdTNXF3Smt6VGkwSXVFZklNL2Zq?= =?utf-8?B?SDZXajA3ZWJnZ1NXSHoyZldOSURnNTdzbXVWeSttdCtqQjBJa1Y3K1YwZWE2?= =?utf-8?B?RVpQVTFYbjA1SVlrUlR2YjUxT3FLL1U3SytiWGRPbkV3M1pKUkpHUHVjQkxk?= =?utf-8?Q?kfBGiBu2HGu8q+kgS995o2Wtc?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9e8c41f6-5d8e-495b-0d36-08daf541ad57 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2023 08:39:25.7439 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: j0EP1tPacHCCeFYa9IiXQbOqT6aLfPpVrSjBk3iY3jLlBeprJaABBYnAzJkQvPDLMBHZuwKlSV9w6yrO00YFdQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7719 On 13.01.2023 09:10, Xenia Ragiadakou wrote: > > On 1/12/23 17:53, Jan Beulich wrote: >> On 12.01.2023 16:43, Xenia Ragiadakou wrote: >>> On 1/12/23 13:49, Xenia Ragiadakou wrote: >>>> On 1/12/23 13:31, Jan Beulich wrote: >>>>> On 04.01.2023 09:44, Xenia Ragiadakou wrote: >>>>>> --- a/xen/include/xen/iommu.h >>>>>> +++ b/xen/include/xen/iommu.h >>>>>> @@ -74,9 +74,13 @@ extern enum __packed iommu_intremap { >>>>>>      iommu_intremap_restricted, >>>>>>      iommu_intremap_full, >>>>>>   } iommu_intremap; >>>>>> -extern bool iommu_igfx, iommu_qinval, iommu_snoop; >>>>>>   #else >>>>>>   # define iommu_intremap false >>>>>> +#endif >>>>>> + >>>>>> +#ifdef CONFIG_INTEL_IOMMU >>>>>> +extern bool iommu_igfx, iommu_qinval, iommu_snoop; >>>>>> +#else >>>>>>   # define iommu_snoop false >>>>>>   #endif >>>>> >>>>> Do these declarations really need touching? In patch 2 you didn't move >>>>> amd_iommu_perdev_intremap's either. >>>> >>>> Ok, I will revert this change (as I did in v2 of patch 2) since it is >>>> not needed. >>> >>> Actually, my patch was altering the current behavior by defining >>> iommu_snoop as false when !INTEL_IOMMU. >>> >>> IIUC, there is no control over snoop behavior when using the AMD iommu. >>> Hence, iommu_snoop should evaluate to true for AMD iommu. >>> However, when using the INTEL iommu the user can disable it via the >>> "iommu" param, right? >> >> That's the intended behavior, yes, but right now we allow the option >> to also affect behavior on AMD - perhaps wrongly so, as there's one >> use outside of VT-x and VT-d code. But of course the option is >> documented to be there for VT-d only, so one can view it as user >> error if it's used on a non-VT-d system. >> >>> If that's the case then iommu_snoop needs to be moved from vtd/iommu.c >>> to x86/iommu.c and iommu_snoop assignment via iommu param needs to be >>> guarded by CONFIG_INTEL_IOMMU. >> >> Or #define to true when !INTEL_IOMMU and keep the variable where it >> is. > > Given the current implementation, if defined to true, it will be true > even when !iommu_enabled. Which is supposed to be benign; I'm about to send a patch to actually make it benign in shadow code as well (which is the one place where I notice it isn't right now). Jan From xen-devel-bounces@lists.xenproject.org Fri Jan 13 08:41:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 08:41:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476847.739233 (Exim 4.92) (envelope-from ) id 1pGFdG-0003PA-FB; Fri, 13 Jan 2023 08:41:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476847.739233; Fri, 13 Jan 2023 08:41:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGFdG-0003P3-B3; Fri, 13 Jan 2023 08:41:50 +0000 Received: by outflank-mailman (input) for mailman id 476847; Fri, 13 Jan 2023 08:41:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGFdF-0003Ov-0p for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 08:41:49 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2051.outbound.protection.outlook.com [40.107.241.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1cd22357-931e-11ed-b8d0-410ff93cb8f0; Fri, 13 Jan 2023 09:41:46 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8965.eurprd04.prod.outlook.com (2603:10a6:10:2e0::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.12; Fri, 13 Jan 2023 08:41:43 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Fri, 13 Jan 2023 08:41:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1cd22357-931e-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eBzUvhJ/cTh5erRbmioa7r3g3z58OW4XuRMnKQIsqydkLnUnJY0ZRZfg9n9P73CfNLOIqKenAW/Fgwns2kBYi/loHwnVxbFkRmhkQzlEgkbUvg+rSpfvonNJzAAMUjnJERRE/Y/uaA6IdXuQnBx6WMKGSMryfvOvQvh3r1cZPGoMM4uWel7REc8wgsaxMHieDZ0OePZCMAKNMFhiCgG+DvbsNIPoGLD/AxvyPo9ti34XPHf6LPTVbs6tB3xSmKXZYi1STOYjHm1kMRA6yuY4VzUELdoYSuNJ1/OyI+XptFcdfTWzY3kAsIL2IPKtUZo7c1QOwF3eenJcDhCRw3cmrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F9UyZXk1/Uh5BjNg7NaKvy6tFD19k2rx/NbURI4rtbI=; b=d5WA9enZNoY1hrGVcRU46kk5NXXVqRattLUdqWknT2vob8Ko2/KAOkNyLKwDZ3dNiXQ+YdZy/61UtPW2FmZ9cg1lpGEnL9Mp5L7+UXL6oS0oInyDSFmbc6AEy2JlYar1O2qvrBgc2W801EWCLwc2HwncpZHX77/2i55I93vZSMjQT71RHKoH8gZ1WoDXzsJR3OD1qwj8mSUJ4XBqM+PhdxAKJ8ap0buK78JzybI9b7ALyRBV3SZj7sEXiyLKmK+flVKE6c1Sr8yupSggNgfZHkXKYNLE/XP7VFECKi9ZpJFaXccfDGd5aQ9ihFg51TQhfs+pGYpNDJ9GBLKSOrfusw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F9UyZXk1/Uh5BjNg7NaKvy6tFD19k2rx/NbURI4rtbI=; b=R58EMZvqB51j2bzU7qz1WqSsraeyR+f/CyuHoPNnZFf1y2ZgAFHJSYF3+1FlWZbDJQROwWFiyO4pyLDrP+KSWdpk09CT1kKCOoLlliR0ymBSlBdjcdoNrobpRxIXuQqxXlgdH3fbrBtlGmDfdn8AqzhMJrfhAkBVsk6y/eivqDX3Pq1NY2JwAh28FMMBPWGBo5uJpIaAQYjX+mQ4futIv3xk4sZR8wywmpTyNSzJ3q6qPBPrmg399z3ZsCLxU9gn/h2+WTBW6zfh1e2lYiWcfPF2LXLC4T0mAZB0Efl2QH+RUgPYvi3RfjMgLgrAB0RIME09E/xwAqJj90+bk0hCVg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <749f6412-ff36-c5bf-8b5d-c866aa47cc39@suse.com> Date: Fri, 13 Jan 2023 09:41:40 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 3/8] x86/iommu: iommu_igfx, iommu_qinval and iommu_snoop are VT-d specific Content-Language: en-US To: Andrew Cooper Cc: Paul Durrant , Roger Pau Monne , "xen-devel@lists.xenproject.org" , Xenia Ragiadakou References: <20230104084502.61734-1-burzalodowa@gmail.com> <20230104084502.61734-4-burzalodowa@gmail.com> <4bc3f2f6-9bf4-5810-89e3-526470e72d85@gmail.com> <0e21b24e-d715-bd04-f98c-4cdd53f129ee@citrix.com> From: Jan Beulich In-Reply-To: <0e21b24e-d715-bd04-f98c-4cdd53f129ee@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0041.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:92::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8965:EE_ X-MS-Office365-Filtering-Correlation-Id: 00d6305a-a99d-4686-faf0-08daf541fed0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QZC6sUcKlP1TdNfPrC4+mhzy1tJllYARZaL/46RH5W/z5eSPqvbZvNoICam3NSDF5ZckmK1X1cAm45aR0+2MVJOMtdion4JB5AtjwG2K19QtAiI1v0kyCs8qEY3xZ0960AT5iN7Q7JjP2DaP2nKUb42sXJrtlPYMigPSSrEmvvk4R+gtqANC2p30+ZjSbqrPGTlKAO9ILF29BWbz81iMXsZcKOEEBO9zanaoBTtY3JKM1W7H4MHwIAYzsLHq4G43if0SS2LbT7GpSalmVTXIEMS92TwWRQ8wGgt6JNVccF2Z+az4u9+wmdRJ/lWE+t/Y7LeECx0K6RJpzZsG9a0Ld3nV4qy9qHtIBvXVmCQJb18WkJgX4ygBjcw6pxntfdUn0uDD1rK6eOWRvd2Zgyfmeqk36VuuQHfmFOK5AxjEtMmeC/KO0s0Z31C4vIpB50L/xBowI5S8T7O0It35EiHHPSm5rT7yua0L2jkKem210kQbghEu3G3c5+nJvgSYqo+k9S/VGfF9ENFSsYzPjof4GkatNye6Z1enckSkc+igY6FhqthzdCmqMRryBZtwSXh/DlcHqGWVI2UfKpwoDHlUtiBcZOejtCRUwSKLBHRy/O7QeyHygGVcML999hY2EAc7QZzvwpCDVIgbRu+mHdsA5HrmdEgkfdiLhbyoGbTUpgjEqbeWsg8IJiGdnQXGvbl1BJSLc1yo84nEBU08b0jfw1KRwzhL1QRL5CId29vVRZo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(376002)(396003)(366004)(136003)(39860400002)(451199015)(83380400001)(38100700002)(86362001)(54906003)(31696002)(6916009)(66946007)(66556008)(4326008)(8676002)(41300700001)(316002)(66476007)(8936002)(2906002)(186003)(6512007)(66899015)(26005)(2616005)(6486002)(5660300002)(478600001)(53546011)(6506007)(31686004)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MHJIMEhXQm1RUmlFcDVaWmJxMDljblVCUXBja2RhVXNDZWpxQjB5SmNjdUlh?= =?utf-8?B?aGVaRmROWUhYVFB5Z2FLckJsK3JySmRBNnliVEpaT01vblRMNGZwWU5oRjA3?= =?utf-8?B?bGdiQ1lJTzZNVHB2YnJyZlEzd01DbGlGbXVkNWJFV2F2NjNVU0pvOVV2bUk3?= =?utf-8?B?RmxQdWpDVGwyQUE5NDZTbEljd1dyMjZuNGtWWkRTYUF3UXZNWEZUMit5b1NM?= =?utf-8?B?ZjgvemNXQUcvY2kwWkI1UTAvV3RQSWJHcFBUdFJneGJwZFByWlVNYmdVblBv?= =?utf-8?B?bHpWeEtIVDFIRHZLanhPNzlkTDhzZmxpTUUrWWdsS0hXUzg5ckNMVzFmWXk5?= =?utf-8?B?aW1VZy9OeENZVkFKeXJub1hsYk1ETlJOcFdsN1ZaUkJXazhDZEd6TGhFVXVn?= =?utf-8?B?ZnZXT3FVaFdGbEh0T280eG9qbTJIWUwwVEdKMHhzMERkVHV2RDVUaHZnd2NF?= =?utf-8?B?MHlxeFNJWjVORnR0WU5adkkxMVBPTVQ4NGhjSWFRU3c0YkFoSUZJT1BWSTBO?= =?utf-8?B?dnk1RGxUTzV3L2hFcWJ6NDlnanNwN1F1QjduWW5qbERIV2tWZFFOc3d3OWh1?= =?utf-8?B?dC9WTVQ2RHlBTWF1TWN4K2NKU1pDUHVuaE8zNmYvYWlJY1dEeFpyYkNnWnFN?= =?utf-8?B?eGZMcUZhcEI5VTRmMWlqVXovS1FmeGN0Vk0xTDlvZzkvN0ZzUGxlcFphQ251?= =?utf-8?B?elBUYk1wOXhHeHR4aHB4dlp4NTlKNUlVeWp3dWpjeERYb3lRdGt4ZmZvbXcr?= =?utf-8?B?emVYM282dzlyK0JRZytjRUwyVFowTzQzSDluYmxrNWZDY2srMmF6R3FTSnZR?= =?utf-8?B?dlNKTUhOYVhVaENVajl4TWdlUm83OU5QMjRnVGVkdkpZVndUM3lMY1lGRFY2?= =?utf-8?B?bjI4L1V2elUwYWpIbkZMMklEcUJFK3YyT2NQUk5FRThOODZkdUlZaXNPeXlE?= =?utf-8?B?RWVsL2lwY2o3N3pEdWxTQStSOU1laWNsdmJ0WWJtelo3bi9GM3A4MnkrUFJj?= =?utf-8?B?Q2tTWnYzZ1l3VUxzSTRURm5pc1JCTHVHRGZFcjZoZDVQRjM0cldxWTJHejht?= =?utf-8?B?cnVVRE5zdlkyS2tPeVNEOU5TMnBZSGtXWXVnOGw4MTM1cWdtcWR3eElsakJy?= =?utf-8?B?UU0wQUhBelNEM0lXcEFQLzdmQ29BNXRtVXJYRmwxaENWa2o4dWlFRVRTNEow?= =?utf-8?B?bnpLcTZHWU8zZTlDVkViSGI2YkZocGRhY3NsTElpRTNKMmpYNXl1dlBOYW0r?= =?utf-8?B?aFV4TTAwSkJPRVEyWGYyTTlscFVRRUIvaDM1ZlZuYXlhM1BGN2RLZVdPYzNO?= =?utf-8?B?SkpRSnBqMXlSNDBKRFVZdTlCVitkYWpyKzNEZ2ZHQS9mcmZzUEZWT3hFQ1Rp?= =?utf-8?B?ZnQ4ZUUwbHM0QnBJYjhkT0UrbzgzNWFHNXZpa0dicnA3YXByNzRZejNUZHI4?= =?utf-8?B?K1ZyTERqQi9mR0xyNWVGczRRMmtHcFNmVWtXZXdLSmJ4SzRNaG5BTlE4TEdT?= =?utf-8?B?MUw1OWkyWjJpcjV3ZUZHbEV1dTlyQTNnYitsVGFWazA4SnpJa3RuTHBVbUdX?= =?utf-8?B?bE9YNHdvY0YwdUZJaWJqSjd1MzRibVl2aGJrdzNKaEk5N1FsL0hjc1pINXpQ?= =?utf-8?B?UklEV3ZDTDVKYzlYNy8wZ0NEenEzM0VYeXBETUhrRFFPd1R0U3o4amI1cHov?= =?utf-8?B?eTEzcTZVcnRyQjVacThuYXpnQlowTmhCRTVJTnJsNGFKVjBBMGYya3JDemxU?= =?utf-8?B?UjVHR0Q5bFdQNndsUlRvZjlTeDJBanhhd2Y1cTFoRUhqeVhmMkd4b0htdFBs?= =?utf-8?B?aDlxdTBveStaZ25mbVZrMUlRMFhISDNzOUNGSDNnRmNsY05GUGJnM1V5SzdW?= =?utf-8?B?S056RDZEME00aFNlLzl2bnV0MGZzYTQ0ODV3OE5uQ2k3Um1jMi9DcC9KMmhP?= =?utf-8?B?SzhMdVgrZmdzT1hPTWtmYndSa0R0TzhZa3FDd0VIS0ZxSCtsRTJ2WWZnSmZR?= =?utf-8?B?dm5tT2tGNFZZVVJtU2VFcUZBaURyOURxcFY0aDlGYStqRU5sZXh6ZWJWcU1L?= =?utf-8?B?UjdMWjkzdFJNaGdaV1NibXVKY2VYczV1VkNFenorZnh2OExZZFIwSW5OQjht?= =?utf-8?Q?e3JmLD22F0VF4ZqtVPi4k6x39?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 00d6305a-a99d-4686-faf0-08daf541fed0 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2023 08:41:42.5634 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Qq3ZskQWbN+tgZLeTuxmJjkZBMprfMGzMcLHJE4VH/izqAVckF1fHWgxUplVGxhqOerYZ8Z4ckd51PJRvCKhVQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8965 On 12.01.2023 19:24, Andrew Cooper wrote: > On 12/01/2023 3:43 pm, Xenia Ragiadakou wrote: >> >> On 1/12/23 13:49, Xenia Ragiadakou wrote: >>> >>> On 1/12/23 13:31, Jan Beulich wrote: >>>> On 04.01.2023 09:44, Xenia Ragiadakou wrote: >>>> >>>>> --- a/xen/include/xen/iommu.h >>>>> +++ b/xen/include/xen/iommu.h >>>>> @@ -74,9 +74,13 @@ extern enum __packed iommu_intremap { >>>>>      iommu_intremap_restricted, >>>>>      iommu_intremap_full, >>>>>   } iommu_intremap; >>>>> -extern bool iommu_igfx, iommu_qinval, iommu_snoop; >>>>>   #else >>>>>   # define iommu_intremap false >>>>> +#endif >>>>> + >>>>> +#ifdef CONFIG_INTEL_IOMMU >>>>> +extern bool iommu_igfx, iommu_qinval, iommu_snoop; >>>>> +#else >>>>>   # define iommu_snoop false >>>>>   #endif >>>> >>>> Do these declarations really need touching? In patch 2 you didn't move >>>> amd_iommu_perdev_intremap's either. >>> >>> Ok, I will revert this change (as I did in v2 of patch 2) since it is >>> not needed. >> >> Actually, my patch was altering the current behavior by defining >> iommu_snoop as false when !INTEL_IOMMU. >> >> IIUC, there is no control over snoop behavior when using the AMD >> iommu. Hence, iommu_snoop should evaluate to true for AMD iommu. >> However, when using the INTEL iommu the user can disable it via the >> "iommu" param, right? >> >> If that's the case then iommu_snoop needs to be moved from vtd/iommu.c >> to x86/iommu.c and iommu_snoop assignment via iommu param needs to be >> guarded by CONFIG_INTEL_IOMMU. >> > > Pretty much everything Xen thinks it knows about iommu_snoop is broken. > > AMD IOMMUs have had this capability since the outset, but it's the FC > bit (Force Coherent).  On Intel, the capability is optional, and > typically differs between IOMMUs in the same system. > > Treating iommu_snoop as a single global is buggy, because (when > available) it's always a per-SBDF control.  It is used to take a TLP and > force it to be coherent even when the device was trying to issue a > non-coherent access. > > Intel systems typically have a dedicated IOMMU for the IGD, which always > issues coherent accesses (its memory access happens as an adjunct to the > LLC, not as something that communicates with the memory controller > directly), so the IOMMU doesn't offer snoop control, and Xen "levels" > this down to "the system can't do snoop control". > > > Xen is very confused when it comes to cacheability correctness.  I still > have a pile of post-XSA-402 work pending, and it needs to start with > splitting Xen's idea of "domain can use reduced cacheability" from > "domain has a device", and work incrementally from there. > > But in terms of snoop_control, it's strictly necessary for the cases > where the guest kernel thinks it is using reduced cacheability, but it > isn't because of something the hypervisor has done.  But beyond that, > forcing snoop behind the back of a guest which is using reduced > cacheability is just a waste of performance. I guess I agree with most/all you say, but that's all orthogonal to Xenia's work (and also to the patch I'm about to send to address the one issue that I've spotted while reviewing Xenia's patch). Jan From xen-devel-bounces@lists.xenproject.org Fri Jan 13 08:45:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 08:45:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476854.739244 (Exim 4.92) (envelope-from ) id 1pGFgK-00045U-1m; Fri, 13 Jan 2023 08:45:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476854.739244; Fri, 13 Jan 2023 08:45:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGFgJ-00045N-Tt; Fri, 13 Jan 2023 08:44:59 +0000 Received: by outflank-mailman (input) for mailman id 476854; Fri, 13 Jan 2023 08:44:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGFgI-00045G-0J for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 08:44:58 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGFgH-0004I7-UF for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 08:44:57 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=[192.168.6.109]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pGFgH-0001QZ-Nd; Fri, 13 Jan 2023 08:44:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=HsJwZ7pf4f8CxnJAVrHz8BvApRU4m43BBJa5/+ChXho=; b=lLzRmEz8JXaRvjXkhw6KmPjIWK rjsFHVX3ZutcXkFD7SL1WNnqOvq5k3r1m67uINZEjrzi1X/DezVbPC7FzGdUz5hGakvg82n9ujZC4 xxUzsD7v/i5oCa54NjQ9G7ENrPf3rMyCnh8f4+xiunBMowIxU0ZlYJUb3FUouRg5lJBk=; Message-ID: Date: Fri, 13 Jan 2023 08:44:54 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [RFC PATCH 0/8] SVE feature for arm guests Content-Language: en-US To: Luca Fancellu Cc: Xen-devel , Wei Chen , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Anthony PERARD , Nick Rosbrook , Juergen Gross References: <20230111143826.3224-1-luca.fancellu@arm.com> <3e4ce6c0-9949-1312-f492-913b7dd2cf18@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Luca, On 12/01/2023 11:58, Luca Fancellu wrote: >> On 11 Jan 2023, at 16:59, Julien Grall wrote: >> On 11/01/2023 14:38, Luca Fancellu wrote: >>> This serie is introducing the possibility for Dom0 and DomU guests to use >>> sve/sve2 instructions. >>> SVE feature introduces new instruction and registers to improve performances on >>> floating point operations. >>> The SVE feature is advertised using the ID_AA64PFR0_EL1 register, SVE field, and >>> when available the ID_AA64ZFR0_EL1 register provides additional information >>> about the implemented version and other SVE feature. >>> New registers added by the SVE feature are Z0-Z31, P0-P15, FFR, ZCR_ELx. >>> Z0-Z31 are scalable vector register whose size is implementation defined and >>> goes from 128 bits to maximum 2048, the term vector length will be used to refer >>> to this quantity. >>> P0-P15 are predicate registers and the size is the vector length divided by 8, >>> same size is the FFR (First Fault Register). >>> ZCR_ELx is a register that can control and restrict the maximum vector length >>> used by the exception level and all the lower exception levels, so for >>> example EL3 can restrict the vector length usable by EL3,2,1,0. >>> The platform has a maximum implemented vector length, so for every value >>> written in ZCR register, if this value is above the implemented length, then the >>> lower value will be used. The RDVL instruction can be used to check what vector >>> length is the HW using after setting ZCR. >>> For an SVE guest, the V0-V31 registers are part of the Z0-Z31, so there is no >>> need to save them separately, saving Z0-Z31 will save implicitly also V0-V31. >>> SVE usage can be trapped using a flag in CPTR_EL2, hence in this serie the >>> register is added to the domain state, to be able to trap only the guests that >>> are not allowed to use SVE. >>> This serie is introducing a command line parameter to enable Dom0 to use SVE and >>> to set its maximum vector length that by default is 0 which means the guest is >>> not allowed to use SVE. Values from 128 to 2048 mean the guest can use SVE with >>> the selected value used as maximum allowed vector length (which could be lower >>> if the implemented one is lower). >>> For DomUs, an XL parameter with the same way of use is introduced and a dom0less >>> DTB binding is created. >>> The context switch is the most critical part because there can be big registers >>> to be saved, in this serie an easy approach is used and the context is >>> saved/restored every time for the guests that are allowed to use SVE. >> >> This would be OK for an initial approach. But I would be worry to officially support SVE because of the potential large impact on other users. >> >> What's the long term plan? > > Hi Julien, > > For the future we can plan some work and decide together how to handle the context switch, > we might need some suggestions from you (arm maintainers) to design that part in the best > way for functional and security perspective. I think SVE will need to be lazily saved/restored. So on context switch, we would tell that the context belongs to the a previous domain. The first time after the current domain tries to access SVE, then we would load it. > > For now we might flag the feature as unsupported, explaining in the Kconfig help that switching > between SVE and non-SVE guests, or between SVE guests, might add latency compared to > switching between non-SVE guests. I am OK with that. I actually like the idea to spell it out because that helps us to remember what are the gaps in the code :). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Jan 13 08:46:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 08:46:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476859.739255 (Exim 4.92) (envelope-from ) id 1pGFiD-0004fI-Ds; Fri, 13 Jan 2023 08:46:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476859.739255; Fri, 13 Jan 2023 08:46:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGFiD-0004fB-Ad; Fri, 13 Jan 2023 08:46:57 +0000 Received: by outflank-mailman (input) for mailman id 476859; Fri, 13 Jan 2023 08:46:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGFiC-0004f5-J8 for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 08:46:56 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2044.outbound.protection.outlook.com [40.107.6.44]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d48bd93b-931e-11ed-b8d0-410ff93cb8f0; Fri, 13 Jan 2023 09:46:54 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8732.eurprd04.prod.outlook.com (2603:10a6:20b:43f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.12; Fri, 13 Jan 2023 08:46:52 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Fri, 13 Jan 2023 08:46:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d48bd93b-931e-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M5KazfsCpkdnLqwmSttL21y74VyXhANyKi2w57+kFiW8GXGxhNu06lWzg/5sKp3eG4WEPW8yYjz3JVPgJH3SJ9FcOUWnlUA/CIsVYFYvcZ6MflUGAZLkAPsPttpW8/D7irEhnaYIfcmx4FeW3IqhVQF6YUAZzcA7mM6lvHgItnt/alZPge/uiEWpuOPGWW3f+3BkZW1l2QhohCCTYzR/c1ex1cllxceJlO+qCq2A4NMieogu1/mRjrTF2NsbPdgFWmZ8GD2IupkdxUwbiceKiIsBVHB+Y8I2AiOGUmG1tslcKwcBYq0bDiiS7nVi1XcXJXWM3Q0FCbcF43VPNqF6YQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XKEfNKB9Lh4zFo/AYJGrhFntaz82rAreSJv0LvWBp9E=; b=mXak62sMKO3q09vk72pg2YRjRqq2X7P/pGHHffPMjkoy5n8BWGc/KfdcHSrUBF7buyVm0q7duKcWNtuq98BPPuCa6nJdrhX6wBQG8+dXXKZKrvy+u9jxEMNV2CK4+Ua8ZyYleTdqIEqN5omQNs5YQKRtQx5B/Gwqy4YQQYJWPYeEz4gCFrQ/Xty0uAPfSkbUMGpcSyIeQVjMwtfyht1o6e+qncgRwbZg2+IsdjhYLH2Zt5+DMShM4BbNJHeyhPcwy6Ad2g8yxDLx8GhQr0f+UbVTtBiFCNfgWVe7eLmb3EGxLaSdyDM+S7CH81eryomJfcY71w+asLkLk//vGp1p9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XKEfNKB9Lh4zFo/AYJGrhFntaz82rAreSJv0LvWBp9E=; b=SmbvCNm5UQqbcvgCyFxMxI1NxbYLVFQbSCpdeCWgv1KLFwOa1g5b3SCOrUwbRq7cyeb1r323TzN2uJURQRGUCTxyTNPiGP9ysOSNczjmAvZhaBzQ70R7JjKffRWVcKfnH8VXDfO4qV8ZDiGHnmMVssfzp3+iqxl26Qv0QojWMM13SJnpzdJXShTjyq2ywhY4mfCvfvCwLjcRy4zoGc2tN3VvcPHNdCN1YaoypGsW3xrqEEFqqZFb9z0xaSFzPFM3KHQhtM55lfsW71NkXFAfMRwp4IOdP+llZNrINRLj63u+LcTSy8ObiLDBenJP3VEwRewPSEQZwCL2ccOgbDkgig== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <01756703-efc8-e342-295c-a40a286ad5f1@suse.com> Date: Fri, 13 Jan 2023 09:46:49 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Tim Deegan , Xenia Ragiadakou , George Dunlap From: Jan Beulich Subject: [PATCH 0/2] x86/shadow: MMIO treatment Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0168.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8732:EE_ X-MS-Office365-Filtering-Correlation-Id: cbde5a5a-d873-459e-3b7f-08daf542b794 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IngCBRJIEc6w4OzZNRBanczn9nLd4ebrZLIsn8uWJf0aXEKipFckRoTwRELu3n2KylxCeAvDA9HtnOP+Mh0mZcmPkAwU2nvs1XOegwBbKuIuG+L1P10nrGgV53fFL7qkwH21Q9NIffS/syz4dZwRcQCvLEbenOcfqwPMLgqByG1nfa8e4jNzVtpz7SbVy1IJnsV2AsAlzqk0mS2kfB22xRUKQiUg0moW748+OENhMJH16reAp+k+d1DhM2ASmzH7q+BJCf/QezbGcigqO6wLT2Wd1NnIFKKrtW5zRe0H8Y9r+VuEl4Gwr2bAsNsTRZF7XlArNtQz5MyF2ju3O/nVnwe45qtLdS+LXR9BbBPC/fU6qMxPNbiy8ktsG+ohhueJDr59qAgERclmmyJ6n++Syz8xokmnrWSzPHAFUa1R4myZGxQ7scqFzkf4XDt0Q4K+T5sJpx48uETVDNlsbOlSJPYK8LA28+or0KTI9zHKs4Kpm5zxJwBvz/0finzPaALMibnmXQbIrMl20a9xDYejn3BjvxAPa5yMMqQ6geZWsQDAxJfMmtICiRxpD1194l3IRUVdE1QDMRfALLdskQEGtCD/erFJvBNd49X11Hu3uPrfuq1ImFRNWggYWv7d0KMuj1SldnXKISIiM1a1FipvezB9lD935tkxlbR3c+JxqiKJdST3OGzmjvcNK1bAXGnP3E3+anI8hydaCwKf1rE42aF4e3vq5EYFekWdOJVc7yY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(346002)(136003)(39860400002)(396003)(366004)(451199015)(6506007)(36756003)(6666004)(26005)(186003)(6512007)(6486002)(478600001)(38100700002)(31696002)(86362001)(83380400001)(2616005)(558084003)(8936002)(5660300002)(31686004)(2906002)(66946007)(66556008)(316002)(4326008)(66476007)(8676002)(6916009)(54906003)(41300700001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MzJ1NVFEdmNyR1ZIRTNUcGFlcm1UQTJ5bU50U0FhNGtZR3M3VzhPUTE3d1hp?= =?utf-8?B?eEtYRHMrNGtWeVdxYWFTZ09GV21TL0NnVGZKTkdOaUxxY1JVb3did0VqNHhE?= =?utf-8?B?UFFFc2FZak1HKy96c3ZrSTVtVGtnaFFlWEdRS2dldEhqM1Z3dVdyek5vdUZu?= =?utf-8?B?elppbEJjaDg4T1U0bWJlZjVsc3UzQmtlWTNXTDlXUEtzcTZ1Ty91RkhOakRi?= =?utf-8?B?a2RBeDBvb3FvUXB2cExaY3NuQ3M3K1hQckRyeW05MXBmVURLamZNUzNpOFR1?= =?utf-8?B?akJGR2pQd1V0R09sQ1FCU3F5bkV6c2NUcUZWbDlZYzBQY0Q3b2w3cWtJb0RW?= =?utf-8?B?ZGNHY3laM2JRekk5T3hQWit0ZTh1aHNobVJzUVpvaGdVMlNPODRHMEtBMWRK?= =?utf-8?B?UGdFSklZU2RscVc5NjFLVXZVeHo0YUZ1RFVnUlgxMXhvZkV4cEdOQW9IdFV5?= =?utf-8?B?cnZRczdnMk1aanBrWVREZ0c2UDR1eThkRHZVbGUyMDJMTmMvMW9CRmVQVG5a?= =?utf-8?B?U1dSY1BCSVA5dGNiNGR2cDFTamdVYnloeklHOHp4Q3Nqelp5aVBCalU1ZUxG?= =?utf-8?B?ZFpGNnRvSWg4bTMzdDVsUHNNZlZlb0l3U01xeXVDL1NDSTkyZ3dpdVJNaFNR?= =?utf-8?B?NGRXYms1TGpkOTNHd3hMZU5YUDdwVmhmZXBWOUsraG5WVC9NcUJLUVhhQW15?= =?utf-8?B?c3B3dTJVb1N2VElqLy96RC9Ed2pjT3grc2dncTdMdC90U2kzQ3ZubEFiWUhK?= =?utf-8?B?VFUraW1WUmVNWjVwU0dCcEJjOEdad2xTRHh5R1YzRTFUWHhSeCtkS0ZyRC9q?= =?utf-8?B?TXErcElUa0ZkeU5SamhwWDFmMkJObFhab2gzT21IUTFrdUc4NnZKUUVidFJ4?= =?utf-8?B?dDg0aVhESHR4a3Jac2lvbVlYWVdLOXp2V2RjTjVPRWhpVFpBTzRLWW11MkIz?= =?utf-8?B?N0dHM3QxSEc1bXl5eEtXTUZYMHVlZ0JUUVh3bFV1bmMxaGJhNzdvS3lONVZZ?= =?utf-8?B?MXNieXh5YjBjTEVnWGtac1gxSHFzTnJXZVRwRGFzVmtIVU5KYlZ6dXRETUZw?= =?utf-8?B?U2c3UXBZYXZZelp3VFlIV01vRDZZK243dlJnYWh0MjBQNlQ3TGtZUmZQNzlM?= =?utf-8?B?TjA1Q1doTmNkbVYydmdjUzhsdWI0RTc5OVNrQmJVZFFOeGdrWGdQMzlkYzBZ?= =?utf-8?B?cjZEU0pwSnBlZllUNEZHb2ErODNoTjRMRzBLUFBWVU8rQ2ZiazY3UnBCVDNK?= =?utf-8?B?OFJheEY1R0Y5bzhWUjZSNldpUVNuWFV2YlFOSHpJc2p6bVUzRVdOd29ydW1K?= =?utf-8?B?ZENWRVdxUTlGbkVoOFpZUVFONmpCN3QxcmQ0QzNqT0FIdEROaXJvc1VDSk0z?= =?utf-8?B?bUJobzlWVmx0MGtDUDNtMkpkQk01bi83bExqSXlicVhJS3pkNG92LzVLQmpz?= =?utf-8?B?bFcrZXlFUWQyZkRleUpiZmN2OG9tRmlJUkxOYi93WXZmV054UGdTNVRKTG9D?= =?utf-8?B?VU5SdUF3QkVPZDc4blRTb09XUFI2NGRSSGtvT1JxekpDdXFGRDJXMHdncEQ2?= =?utf-8?B?RlFtaWw3UFE0ZWgyYjR4QW1iNWxqWFZ3SVJtMndsOE16VDNtWEJhZ01raHVT?= =?utf-8?B?c3FSYlFzQ29RKys2emJNWnBjYmZXbUd6NXRlMHNFZjF0bk0xRXJxVWxBbmNk?= =?utf-8?B?SlB5WWx4aWttODZrWjE2ZGRSdENkNmlTWlg4VW5iVk5TVGtvYjBORnhKbkdQ?= =?utf-8?B?cVJuaXdJdnZEVXJxemdneFNhU2RCa2Q5cjR6a3dFeS9GOG1pMjY4R2hWdmtz?= =?utf-8?B?Zm8xdCt5UFJtRFhMRE1HR1RIUzAzcmdhYUs2ZGJPVDhyTHBoNkxFOWlxc01K?= =?utf-8?B?VVBVWHZZcGlWZTVzN2F1WFN1a05UY0FYdWNoNHFyRnZpL3Nja1hJQWNadXpQ?= =?utf-8?B?dTNvbkxYYVA2b25jSGNpUm01UEVzYTZhaTdtVVV0bDBjcUZCbjIwcWtCYldr?= =?utf-8?B?SVhmOERRMk5ZK2lJdUsrelBYRGExMHd0TFdZa3oyblNvUTAxMjFmNTRkS2lO?= =?utf-8?B?c2t4V05Id1pNSlNmL09KZ2pWSGl6K0JqWEV5RU5JWmdHVmo4UExjak12Tjg5?= =?utf-8?Q?SaIt4ohV4MReMS6CzdTYUT+ev?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: cbde5a5a-d873-459e-3b7f-08daf542b794 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2023 08:46:52.4188 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uSmwboFMXHaNrPVg1SMJtQEu0jT+W8ASINZIxdexdfr/gdL/+hcV2FEf5O72CpQ+u3XcETDfP3gMejChGdi3Kw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8732 While reviewing Xenia's change to iommu_snoop placement, I've spotted a shortcoming in _sh_propagate(), fixing of which made me notice (again) a 2nd kind of issue. 1: sanitize iommu_snoop usage 2: further correct MMIO handling in _sh_propagate() Jan From xen-devel-bounces@lists.xenproject.org Fri Jan 13 08:47:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 08:47:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476866.739265 (Exim 4.92) (envelope-from ) id 1pGFj1-0005CT-NC; Fri, 13 Jan 2023 08:47:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476866.739265; Fri, 13 Jan 2023 08:47:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGFj1-0005CM-KS; Fri, 13 Jan 2023 08:47:47 +0000 Received: by outflank-mailman (input) for mailman id 476866; Fri, 13 Jan 2023 08:47:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGFj0-00056k-3C for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 08:47:46 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2058.outbound.protection.outlook.com [40.107.6.58]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f2a8557c-931e-11ed-91b6-6bf2151ebd3b; Fri, 13 Jan 2023 09:47:45 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PR3PR04MB7433.eurprd04.prod.outlook.com (2603:10a6:102:86::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.19; Fri, 13 Jan 2023 08:47:43 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Fri, 13 Jan 2023 08:47:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f2a8557c-931e-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iRmT0ij8gAtOOt4rCEN/vyCQ7Aso5MV0XWank3L9GX8Pm9kdJRjqWx/qqSwvB8d/eNZnZDKpwQFamjhtOleQnz5PVlKfPIbNUt21UtVhKO2ThDlXjEK14uZfOXkOfizcNQ0ZyVj3GUtEq40jNJTdH3FA5Rc3kV0QBoSYM15K72gT81P1NIdMMGRyeysQj99x6ND9ykfmv7FZMsja/efWtUwRHwodik/2u734w1ZHBoFS6ll2lJgdyMac1t0cRSZFtUlmDOn+6/aEOTMvvpZbG55dfOt3Uyc3ahHsVSCzXBYpBl6/CVAsTW2Cm/Mdab15awaPbnJasv9VsEdSJBeSlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PIN7bYME3B1gixZ9fvJuwYJvOqsQq3RxKGZEx+HCKzM=; b=CCxguQIoxLhGj1nARBQ3OCJP9W45jvd85jKIXF7a2E6VS4X4lCQ0XYef5nieJIz1osyMAWuZJsulp3drkrt+4LPjlRCesLTlgf9rdbCdx8mDf8HcaWhj3tHy8co6UiBin3eg0ZFEe1SklInxp1TU1+B0sd7dFKFW6lMIveKs7k6MfTpan7laquOBC/AG0jlnSXLRvAXYrpCXLUreXYHFAqcgddHOVfEz6XHrtRG2NxNYQbDO2w9gWDtF/TiozCswnK2NKUDftiti50iKehtCfeILBd0zYYiSXOeL4zHcJTYJT1M2zI4UGrjM17xguo2CTQ9LugHUAUfkG+dvP03/RQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PIN7bYME3B1gixZ9fvJuwYJvOqsQq3RxKGZEx+HCKzM=; b=5jFDtqWuYfKhs9AEiFfHSZzeg1IMGMKLgqtSorQ6bBlBPqwynqVIFdG3KUrx/wrEuxuPUkPgDzte1DN4CDuicNYasVjmo5WneaZo+gIaKt+EWJa+KfTWAptHhmCK8XaCF4cITchiihyyk5tpEUElofQ87CyclBIXxwOrsb83lhBH1ZE03BU8VMxq5xsr9ALGaVEraOTG2Km+0O7r7ZZS+IPV3yzZ7TpcfQP6jgpNYXFPH20VU/LnQPLMpA6uwQQukyF3BIEtA0gimAtNwZZ/zstNgFXqZAUVuEwTdG2obkMDUKPs9VB8Fml5byY9NmApLz/pD58IVHMfbMubEzBlAw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 13 Jan 2023 09:47:40 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: [PATCH 1/2] x86/shadow: sanitize iommu_snoop usage Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Tim Deegan , Xenia Ragiadakou , George Dunlap References: <01756703-efc8-e342-295c-a40a286ad5f1@suse.com> In-Reply-To: <01756703-efc8-e342-295c-a40a286ad5f1@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0175.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PR3PR04MB7433:EE_ X-MS-Office365-Filtering-Correlation-Id: c8992c1a-1ff5-48e3-afb4-08daf542d54b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uPegB6XImAJuvmJpNRvfuo3EQ8pI8B1Yz4N6b5aBhPvl3m6NePkT3E+5ZJgz9mxDUqDvspc4sXNvMz+S3nWfJO3EJRm5rG6cpUXq28xS34tZXkZZ9NMPhVPpLPDdMQI7gKK3xyrV98EbrsZRTAcAlo/9ZoTZTt/N7Fa/CQG/jCvifm+RzpDFcq7A/ebzG6LTKiXZvHr/OFyRAR3mq2ooeSy1PDX8oJfLnwq/t0iEknFIhpwGC342jWrSlvmDbSvxuz3QKTMToMMNe93mIKi8mc2V0QSQvGYRQwa4337713lSRNlgX1U+MwKFhE5pikuu0skIkIkW/HYbOcMied8vYzpAQQr+j10mkGxpc1hA3bjRfJLHjt0iFli8Klrypc4J+HZVjavYvQb6m+W2j1o0F4aTzcWzbPgxwJeZF9+IbfwXhq/77Rwfs5rql4SdRE3s2culqMSQLjWr9LwLo8qFVHibRQBKOJk2yJpqATXICRXlsrevKpzaezpElq1yzja0wmd7iYUXXQOJz259KeocV2y3UpFeWmprdb/5QyiuQbAUYc6iDIW9dWpbXwggsK0k/WCguMT3lfyUZXdiXF0+tDF+rZPHGhJifJRDlcTf+ADm4L3ZdnlLTB6KIZSFu3e81Gu8e9t+izt+E0mlxR4jA6iifqQ0jOX/DiaPXW3MII8W/tnn42ZPs/eGHjJJ7n5tyoSJz40cITFouPSnexK7cAKe+dL+lz1prx+b1RjUxRcCfDq7R5N58+VceNNBeIGFvaSg8zJZIpJGifUpEORYPw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(136003)(376002)(396003)(366004)(346002)(451199015)(6512007)(6486002)(966005)(478600001)(6506007)(31686004)(186003)(26005)(66946007)(66476007)(316002)(66556008)(54906003)(2616005)(6916009)(4326008)(8676002)(86362001)(38100700002)(8936002)(5660300002)(41300700001)(83380400001)(31696002)(36756003)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dDVuczl0cWM0VUJrUHlVVnY1bk5rZVU0Q2ppZGY3VHN2RlNOUkhBRVhMM1Ev?= =?utf-8?B?TkQ4UDNyNC8venVNOWJYUWR2TGY2aWVpaTFnNmJadkcyaTgwcjdpOGlOQWx4?= =?utf-8?B?eFBRUExBWExwQjRwaU5RRXF1VU9OWURDcHFTYm9pcFFFa1NjYUNLcVBGT1di?= =?utf-8?B?bUZYZVRwbUlqMjRrZmJVcWtHRDNrd1ZlTFhzVHo1UEtmVTVmT3Ftb2xqMXZn?= =?utf-8?B?bkQxNUp4ZmZUKzBpTVFoVDEvSVJIcDFtMmtLV2Foc3J6d1JDS0ZJaHl3OW9m?= =?utf-8?B?MGYrS3lPbmdranZxZWNTVExCN2hJbWc5SWdjUi9XL0IvNmozLzU0dDZpbWNn?= =?utf-8?B?UXRuYW4zSnBaazFaUVc4QmVDWk8yTWJxQTlmbWloTUIwMEowcnIvR1JOZURQ?= =?utf-8?B?d3V3Q3ZDMkZVTGVodzRuRGNFNitwclZQMXdRL3l2K3Y1V3ErTmUxMWcvd2Jt?= =?utf-8?B?UE5iYUtLOG05bmxRbTFZZk5Id0JaWk10cHo1bXIvYVpQOUdZT3VVdUZxWGtX?= =?utf-8?B?SzZ1dHBQK3NOSEMrVEJMV2xFUkpnY0kza3ZXWWdaSmRrRXZ2bDEwVzBrRStt?= =?utf-8?B?MzBRNUljL2FlR0cyd1VlK1hnbTUrSHZJNGpvZk1LVythc1ppOXl2dEtwTVN6?= =?utf-8?B?N2pkY29mdGdCVDhLUTJTTnR3UGEya0tNZWRwcWp5WFBYcHNGeXRaWXBJdFNU?= =?utf-8?B?cXY5V2NjM2hXWVRrNlpWYzNLdmV1ZVlYcjkwM05TNlBRdlQ4WXVEZXhhZGNv?= =?utf-8?B?OWhsaDhFNGwzaE1CNExzTFNCaEJ0UVZlMmpZcDA4QzdOSFBXVU5YbHliSFdH?= =?utf-8?B?anNRbTV5ek1TM0ZYRnhENkM0YU14c2dXRHQ3cEVyWGo2d3J6QlhEQm5Makcx?= =?utf-8?B?UU1wVVZ3RWZDWVBUbzBYYnRudlFhTzVTMktyTFhyUWowb21haXhGbG1yUEUy?= =?utf-8?B?OWE4K2Z5M1ZIeDBwSnkrQ0pnaUduWTF5RERYcUJmRW1OSmtaZlZ5M20wRjY0?= =?utf-8?B?cmp5RStSK1dDRU5OanowQi9nYisyd29WL1JYSjlvcC9TLzdBZGowazlXWWFX?= =?utf-8?B?NHZ1NEkveXlJT3gzbVovTElDdGdxY3VHT2NGcytLdGZ4Qk1VbHc0UCsrMnFl?= =?utf-8?B?Z0FPeEJpS1QyRUdLZ3Y5eU0yZ1VuYkh6TWNZSWozU0F1dGw1cWgxeVpQSXo1?= =?utf-8?B?NjFhc3UzRHNML3JkNFFzRXplcDFNakloWG5OR0dYbDhWTjNnQ0psaXN5cEt5?= =?utf-8?B?OUloM1lGalpHWXc3NTlDYm5IallYYjB6UjNpSGdBN3g0NXF3VWN2RlowV1ha?= =?utf-8?B?Y0M5eUNmSzIrM0hzWEtVblRsbTZyVkRwMXZ5SjB1b29JcGxiL290bG9nQmxQ?= =?utf-8?B?b0VyZkJxYUdZbDFua1JuYWVvZWkwZTVoVUxsblVKSlQ5YnMyaTJFSkh2TmVn?= =?utf-8?B?RWtiVzI4ZzNHamdXL2xKcVIzcE9SMEtIcG5GQ2Fkb0taMEdHZFAwVU9pTWJX?= =?utf-8?B?RStjazM5STdUVTFxQWdWSXpuRGZobGRjaC9NaldnMGNWQXlXdm9QZnk2SFBS?= =?utf-8?B?RXRXODNQSHZvZU4rRWNORWFzY0tvUXRrZU0xcEdKNHRldFhTL1paVVBiVXRy?= =?utf-8?B?aFZTT2lNQzJUNmRCNnJRN3lOQkxxdjlHUzduTFR6dm8yNE1yZU1Ea0NPVm9z?= =?utf-8?B?NHVaSVUrdmc2UW5Jb1NYSHUrUll5TzBFUmVLY0NZL1UwQkc1amxuUzVaclNO?= =?utf-8?B?Ym9NR2JXc3VyTHFCK3BLRmJKdHA2ZDB1d05UTUd1MEJ0TllSOStFQnhZY3kx?= =?utf-8?B?VjVsYXRvK0d3a2w0Vi84QmVvbFQrSDErK3pyeGc1dE9YcHBDSzVuV1dHQjdY?= =?utf-8?B?STYwTCtoOFAzN2YyMUw0M0orOE1IRkdqOUQwYy9neEtWaTRsbEJMYm9XeTJE?= =?utf-8?B?WXFhTmdrQS9vVDZqUmFLbGV6eXozcmFNSnBqcEMyOGZ1TWZzSVhrOTdKUlFU?= =?utf-8?B?UjVYTVB0K25iSFpmMlZGSVJxV2dDUjdnQkRWOFRQOUMreWUrTWxyQjZNS3dw?= =?utf-8?B?VDFOVlRkOCtISmhqekQwWGZVUjAwVUE2dGh0ZWFQdzNvRFV1YVhDbmc2eTNr?= =?utf-8?Q?wJmVqrocJuCNf/Uzy2tQGlrMh?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c8992c1a-1ff5-48e3-afb4-08daf542d54b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2023 08:47:42.2906 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4LmJ6pT6TAxMypz69GVfbm4OWgd+10mmUco7RWBX1ljKZzMqSn+8XB3y32EGXqNMUBvoM8UqPvCHwfoO8D2GVQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7433 First of all the variable is meaningful only when an IOMMU is in use for a guest. Qualify the check accordingly, like done elsewhere. Furthermore the controlling command line option is supposed to take effect on VT-d only. Since command line parsing happens before we know whether we're going to use VT-d, force the variable back to set when instead running with AMD IOMMU(s). Signed-off-by: Jan Beulich --- I was first considering to add the extra check to the outermost enclosing if(), but I guess that would break the (questionable) case of assigning MMIO ranges directly by address. The way it's done now also better fits the existing checks, in particular the ones in p2m-ept.c. Note that the #ifndef is put there in anticipation of iommu_snoop becoming a #define when !IOMMU_INTEL (see https://lists.xen.org/archives/html/xen-devel/2023-01/msg00103.html and replies). In _sh_propagate() I'm further puzzled: The iomem_access_permitted() certainly suggests very bad things could happen if it returned false (i.e. in the implicit "else" case). The assumption looks to be that no bad "target_mfn" can make it there. But overall things might end up looking more sane (and being cheaper) when simply using "mmio_mfn" instead. --- a/xen/arch/x86/mm/shadow/multi.c +++ b/xen/arch/x86/mm/shadow/multi.c @@ -571,7 +571,7 @@ _sh_propagate(struct vcpu *v, gfn_to_paddr(target_gfn), mfn_to_maddr(target_mfn), X86_MT_UC); - else if ( iommu_snoop ) + else if ( is_iommu_enabled(d) && iommu_snoop ) sflags |= pat_type_2_pte_flags(X86_MT_WB); else sflags |= get_pat_flags(v, --- a/xen/drivers/passthrough/x86/iommu.c +++ b/xen/drivers/passthrough/x86/iommu.c @@ -56,6 +56,13 @@ void __init acpi_iommu_init(void) if ( !acpi_disabled ) { ret = acpi_dmar_init(); + +#ifndef iommu_snoop + /* A command line override for snoop control affects VT-d only. */ + if ( ret ) + iommu_snoop = true; +#endif + if ( ret == -ENODEV ) ret = acpi_ivrs_init(); } From xen-devel-bounces@lists.xenproject.org Fri Jan 13 08:48:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 08:48:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476870.739277 (Exim 4.92) (envelope-from ) id 1pGFja-0005jy-02; Fri, 13 Jan 2023 08:48:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476870.739277; Fri, 13 Jan 2023 08:48:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGFjZ-0005jr-SW; Fri, 13 Jan 2023 08:48:21 +0000 Received: by outflank-mailman (input) for mailman id 476870; Fri, 13 Jan 2023 08:48:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGFjY-00056k-KH for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 08:48:20 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2072.outbound.protection.outlook.com [40.107.6.72]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 07466450-931f-11ed-91b6-6bf2151ebd3b; Fri, 13 Jan 2023 09:48:19 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PR3PR04MB7433.eurprd04.prod.outlook.com (2603:10a6:102:86::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.19; Fri, 13 Jan 2023 08:48:18 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Fri, 13 Jan 2023 08:48:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 07466450-931f-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Mar/jKBke6h4QjhUVgZt3oODFDBI5NYhVJ3TDpb5JhxVcLCKC3rkAxBnephlL8G2RJqqtreyJDgWvWPJkF8JW6foWKwS7PvV+EPgNCt+1eBmQTXhVviwO5RrYVDDAjNK5JXGm/KfYmp4nxAz069sWbeMtY0dYS/Z/4UrC/KJgOMZuLiS5Qo6GjxaQUTn29vIgc9H2sZ8jDDR+Wv6fLrPvqi0RflyYDZlwajIcFkd2iTpTNmt5cozMc15MixvZsWCUO7wE/4/2oZFULtj+SMV8HIdcMcfClRxnpohM3bEbniavHIoNAjkWhU6394O6UJ7fFzrxUaacJEwfCGWJRL67g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B1oV9eOFNOGvXVgiJ+rg0AtuPcAmRh13n0oNq2fBO88=; b=gzlbZV3WLme3h01AW50G8U8F+xefSLtdQ0MLEzqpSS6rFMPnzUpnNkpaJqP+YTTt8AOYfe5pEHWRRdMCQoe4xhphKSq769vaxAjYpxAOMhWz+xN0YMyY5e6yxPA18qbsBiiv6X+s+dqKbBtzAkHtvw48M6cWzTZhBgb1z76hXxwvAsWfo12ab4+lU22/kqr+cGCBczBY48zJeaMjroAAvYsP2dQ0zB7rSrhlwfksyLdxYRprW9DlLuBCWlnVEYyaDuJm7Qs0yWRGE8wR0MGLFgKIGOCvPNmDDUmixQlNz37dw9GDa/jrJsx25AENhYFractcly3jOK7ixZDCQwvzaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B1oV9eOFNOGvXVgiJ+rg0AtuPcAmRh13n0oNq2fBO88=; b=3W2Z/aB4738ZIiFLrC+Lkq8UnoXohflxiXnf/9Kzs+xl2kgcHicAbpA7Z08Ogi97CrmvnyZnUeG0VYBZYghmC3s/a0cZbMKOaYiUzfQgi40QuQ7/pKXVXO93DE+f4g1I6InKLYxU2Ra73ZOr3GWFA2r1vFN/C59WzSmSkjbZfEE/aMhO2aSXKPNe/BbZ5Zgb91e4JOi34CfzAuYjaBCg/V2lxAd2CEFz0zIYyPXOinU92q7bUARkqdjZYjfEhfCVIibUGqfw1eUlvxzeF81904YW5h7a5asZesB1PyKaWu3RPwZJ7E/XY4JJNkY9j2gLDdSVddGKcIDzBdJ+bTd2hg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 13 Jan 2023 09:48:16 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: [PATCH 2/2] x86/shadow: further correct MMIO handling in _sh_propagate() Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Tim Deegan , Xenia Ragiadakou , George Dunlap References: <01756703-efc8-e342-295c-a40a286ad5f1@suse.com> In-Reply-To: <01756703-efc8-e342-295c-a40a286ad5f1@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0173.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PR3PR04MB7433:EE_ X-MS-Office365-Filtering-Correlation-Id: fe3e9317-3c9a-4a0d-ce56-08daf542eace X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: saK4/T8AEIKCh/un8TMOqDgGA3IE30R6OLJ2/fyewo4eYzAKZsCKg/X3O3ehKyrsSGjSpg3zc6pZVPw57HQ/+jRtkKOM3uujBERXrG2Nu7knC+BZyqLXUdyEtm9KeKvopT8G0ebtcezKrYZNg9WwS/M6c27BvEc/+3S9251d8diBAIaKI4EQK534DDbiauhYNiaayw8mVCSGcA8V3gRzOPvqP3ebW4X57edHFMsThNLymmKjqr0vIQDMC15uq6Tn4NdF250gDRCUeAoxyd5nmTpOwN51qNksm0H34wsgTGoWIVuz7oyyuW4yukrii7vrwa0C09/rHVC1ZhKjl1XknrNYDzn8cpTk0IEQ5GE5n+gvOr4Hvv5WBK6lKy+8XA/sH7W02ZNy6AWBUzqudqC5lk7ibY7WN+4MN/Ap5AfuFrhVn/NLQ3CNH+0rThqoNWfYEYRBa/6zBgeu6fF18WnxoXc0awV2Qj473wfIy3qPsaFzv/ysWlBvnzvwh06wSo3Tsn977/xCQPCQR12BrqFV5K4V54J0ESpda8mCJjkerCftH9HBPTfIxNxlBlX94MmuqkK1wFuBz6mUZILb8IzzrPYE6ceDC98DKjuhRYgsJIAJLvBMVHVhPSpmWR8guE6BpZGZM8UUhYHgf3dQcnEV2eyBmyJwwS0jasJZRyRSJC0g97cmGiikTmk1gsqjoQJFFKPREtqrmc/uOHlzIZwjqbHt9yPQUL+zqiF3ZB/253g= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(136003)(376002)(396003)(366004)(346002)(451199015)(6512007)(6486002)(478600001)(6506007)(31686004)(186003)(26005)(66946007)(66476007)(316002)(66556008)(54906003)(2616005)(6916009)(4326008)(8676002)(86362001)(38100700002)(8936002)(5660300002)(41300700001)(31696002)(36756003)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Vk91dENoZWZLQUdMdjQvUE0yVGhRN3JXUkNlbTMvL05HMml4VDN3bkkwRC9D?= =?utf-8?B?MTZ6UGxHa29ENXpqODV0b0pNK2QxcU9BZHVHS1B3aDVuRTU2S1VzeDAxRVVl?= =?utf-8?B?QnZDMWhpVlVQWVpuY2pQR2Rqc1J3akVnUjAvM0h0WC9USHZvK041REU2WWE3?= =?utf-8?B?QVUvb3VxQ25uUXJOU1BRNno0RjRkSlFlV2VjSDdpb09zNDJ1WEdBMFl1LzFt?= =?utf-8?B?TlUralFqWXpvOFUwNmxlenF3M2ViWDNuc3Blek9STExWeXR0Ym1vdGFMeDRK?= =?utf-8?B?OFhGbXpUTVNvWXRvNE40Sk1Wb1FENDRJUDZvTWE3S0IxblV0MDNOREExWW5H?= =?utf-8?B?VTF6T2t3YzdrVmVocGtWQjVqbmliakZnaUlhU0QvZExPSUx0K29MM0haaVNx?= =?utf-8?B?NzlDUHRJd2RQUkdSWTR5WmptSWM1d1RYSGFwM253UDFJL2poSW83Ui81L1BP?= =?utf-8?B?TnVBOThwcUpHbHRXb1FrcEJUa2xaMnZTVmdmMHIrT2lhV0hkNXYzYTRrcHhk?= =?utf-8?B?MWhqYVhwU2xOanpGMk5tU1FzRHZQOUhDM1ZyT2U2UG0xRWNtNVd0T2NEQkd6?= =?utf-8?B?TWtJMlo2TU1WZkJEandlSitaS3FQZlVDZU5uZEJMWjA5ZGFZUlNtMWc4WW1x?= =?utf-8?B?VXF4VEN6K2o5VDBZT1lGM0p1MDRvQTh4SFkrMmNyenBhdXZoaktremY0bU1H?= =?utf-8?B?Tld2MWVxK3daN2V1UEo1ZWlxS2o3N05wcjdSYkJPVko4K3hlU2RZWVdkTjlk?= =?utf-8?B?RGVWbnlUdjdxUGsrMXNGdmJtQnk4TnNmQTdIS0ttTnFlVVcxNEJSNzRzZTdx?= =?utf-8?B?Y0dTeENnRW85VkZYaWw0Sk85VUFlUGZoR0lISnkrakhMeXczTE1SSFJXcytk?= =?utf-8?B?NEdiMUNEY0czeE5YRzdJTmgwNlpaWFppdTRDU2psK0hpdlp4aTAxV09nWk9x?= =?utf-8?B?dXhBYkpwUDhQM2laVEJhOW1ITjE0SENaTHZranljZUN5SU9Jbnl6SlNlUExv?= =?utf-8?B?Vy9RdjdRNnozRTJGcjlON2dVdGRSMWd0Y0JkQ3IrUC9IMlEzWmxaM3NoUWxq?= =?utf-8?B?WVBkTXgyMng2dDRDcU5pNWdDbzJVczRrNWJZNHNjRlpSbFFJU3duUjBXN3k1?= =?utf-8?B?V1BIOHkzZGRQdEk2YXB0MWlNaHBpUFdhM2JVNjByVmdVZU9LMmNGUWRXSmFt?= =?utf-8?B?cmJ1WEdXcW50a1V0Y0tOZXBwZGdXS3p2UlM1WEZjUG1EVTlsK3ZiZyt4b1o1?= =?utf-8?B?ZktxdkdXS0pTckJXRjFNNUZ0OVdrbUhtZ0VoNytKcExFdml2ZmdSUmVMdlMz?= =?utf-8?B?VUJIRTJrYStDVlNSbGVaYzQvSDc1U2h4c3NNRDQwREFFbnQyQTkwdFZMZVM2?= =?utf-8?B?c2J4U1JmblZPamxHU0p3VUtRRkhtTE9vMjJXaHZzKzg0VFhDRndzczAySDl1?= =?utf-8?B?aDcya21XeGx2Nk9XeHlZZitrdU5yN2xJM3FKRkViQVVRamJsQ0dPVGtJZkRa?= =?utf-8?B?NFNyZ0txOCtYRFgvL2taaXRYQmZab2U5UGkyaTd2dmF6RVh3VjBEOURHdEFE?= =?utf-8?B?cGRMWW1mTjBTNE40MUFzTXNKRXN4YWxwRE9DenhjSlhJUEdaRFVGYVlqeDhK?= =?utf-8?B?eDRmK1VybHlLMkJIV1ZQVnBBZlBySHhCVjFWbjg3Y2hRZXZ5cjZML21FQTI4?= =?utf-8?B?d2p5WTNaL0cvTmVLMlNpemdIektkT1IvWlNLN1BpYnEvUWZUYkM3MnBYTWJo?= =?utf-8?B?NjRmdkVZc1FBOWVmMzJoODZjRE51RGRCTXlsQ2dyLzBocHp1SytVR29sS1lh?= =?utf-8?B?cm1ENjhCVGFOQnZ6aVMxUXRqZFBHcElJTnRLeVB1VnVXSmE3VjBEWUlvbDUv?= =?utf-8?B?b0owcWFQVEdqdU9ERXdJcFVuODFWQ0FRVmkvdkVQbjg3aDRIL0pSMGJidGxz?= =?utf-8?B?TEFVQktTWTYvTEJlWk1hUVg1UWJUTEYrcWpzNWJUL0NaeTZZc2FGejZ4ZDhC?= =?utf-8?B?NVJJbjRHcXg4V1lPTVUwbnJjL2FkM2VBWlJ0MS9jL0QvWXJFMUd3aDRjNHQ2?= =?utf-8?B?ZFJ4bVY0UjZTVFRXdzFSWUgzNW5Mai9LaXhZZFlqL0xzUmk0LzcyeVA5RFZT?= =?utf-8?Q?jJF0ACAW+4B46P4ooWwUllsUl?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: fe3e9317-3c9a-4a0d-ce56-08daf542eace X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2023 08:48:18.4758 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fkqqHkz2MxGF8jzFGQoHNK5PjZErFw/5B8+9hOXU9ts6/D0A/rweT187O1WYlsc7U4S7K76VY1dSF39JA+VkWA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7433 While c61a6f74f80e ("x86: enforce consistent cachability of MMIO mappings") correctly converted one !mfn_valid() check there, two others were wrongly left untouched: Both cachability control and log-dirty tracking ought to be uniformly handled/excluded for all (non-)MMIO ranges, not just ones qualifiable by mfn_valid(). Signed-off-by: Jan Beulich --- Note that this is orthogonal to there looking to be plans to undo other aspects of said commit (XSA-154). --- a/xen/arch/x86/mm/shadow/multi.c +++ b/xen/arch/x86/mm/shadow/multi.c @@ -543,8 +543,7 @@ _sh_propagate(struct vcpu *v, * caching attributes in the shadows to match what was asked for. */ if ( (level == 1) && is_hvm_domain(d) && - (!mfn_valid(target_mfn) || - !is_special_page(mfn_to_page(target_mfn))) ) + (mmio_mfn || !is_special_page(mfn_to_page(target_mfn))) ) { int type; @@ -655,8 +654,7 @@ _sh_propagate(struct vcpu *v, * (We handle log-dirty entirely inside the shadow code, without using the * p2m_ram_logdirty p2m type: only HAP uses that.) */ - if ( level == 1 && unlikely(shadow_mode_log_dirty(d)) && - mfn_valid(target_mfn) ) + if ( level == 1 && unlikely(shadow_mode_log_dirty(d)) && !mmio_mfn ) { if ( ft & FETCH_TYPE_WRITE ) paging_mark_dirty(d, target_mfn); From xen-devel-bounces@lists.xenproject.org Fri Jan 13 08:53:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 08:53:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476879.739288 (Exim 4.92) (envelope-from ) id 1pGFoY-0007JA-Ke; Fri, 13 Jan 2023 08:53:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476879.739288; Fri, 13 Jan 2023 08:53:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGFoY-0007J3-HY; Fri, 13 Jan 2023 08:53:30 +0000 Received: by outflank-mailman (input) for mailman id 476879; Fri, 13 Jan 2023 08:53:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGFoW-0007Ix-S9 for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 08:53:28 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGFoV-0004ch-Mc; Fri, 13 Jan 2023 08:53:27 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=[192.168.6.109]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pGFoV-0001bx-G3; Fri, 13 Jan 2023 08:53:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=k1Ov1U07Jan8onZaC2heWsBWIE6+/OP85zbh62hF1ls=; b=lDeVwjScMCd9XObMN3xEBg6HJH jzoxu93uw8Tv3/0IdvL6QxNnVgpoBPc2LP4Ij4AiyShM5bVxfKNEiEebkaTsgTBHPkfek5hakCTJb Q5Q2xbdlpd2HhvDI4hfcZeQIYb5jHRiJhNlfAd+2Mjmjbe2OR/RZI/BWQU9baDJE1EkU=; Message-ID: <0d736370-5dd9-637d-c6d2-74dfb7e4209e@xen.org> Date: Fri, 13 Jan 2023 08:53:25 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [RFC PATCH 1/8] xen/arm: enable SVE extension for Xen Content-Language: en-US To: Luca Fancellu Cc: Xen-devel , Wei Chen , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20230111143826.3224-1-luca.fancellu@arm.com> <20230111143826.3224-2-luca.fancellu@arm.com> <85F9C725-816A-46EE-AD0C-2725AE13F14C@arm.com> From: Julien Grall In-Reply-To: <85F9C725-816A-46EE-AD0C-2725AE13F14C@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Luca, On 12/01/2023 10:46, Luca Fancellu wrote: > > >> On 11 Jan 2023, at 17:16, Julien Grall wrote: >> >> Hi Luca, >> >> As this is an RFC, I will be mostly making general comments. > > Hi Julien, > > Thank you. > >> >> On 11/01/2023 14:38, Luca Fancellu wrote: >>> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c >>> index 99577adb6c69..8ea3843ea8e8 100644 >>> --- a/xen/arch/arm/domain.c >>> +++ b/xen/arch/arm/domain.c >>> @@ -181,6 +181,8 @@ static void ctxt_switch_to(struct vcpu *n) >>> /* VGIC */ >>> gic_restore_state(n); >>> + WRITE_SYSREG(n->arch.cptr_el2, CPTR_EL2); >> >> Shouldn't this need an isb() afterwards do ensure that any previously trapped will be accessible? > > Yes you are right, would it be ok for you if I move this before gic_restore_state because it inside > has an isb()? This to limit the isb() usage. I could put also a comment to don’t forget it. I would rather prefer if we don't rely on gic_restore_state() to have an isb() because this could change in the future (although unlikely). Looking at the context switch code, I think we can move the call to restore the floating register towards the end of the helper and use one of the existing isb() for our purpose. >>> @@ -122,6 +137,7 @@ __initcall(update_serrors_cpu_caps); >>> void init_traps(void) >>> { >>> + register_t cptr_bits = get_default_cptr_flags(); >>> /* >>> * Setup Hyp vector base. Note they might get updated with the >>> * branch predictor hardening. >>> @@ -135,17 +151,15 @@ void init_traps(void) >>> /* Trap CP15 c15 used for implementation defined registers */ >>> WRITE_SYSREG(HSTR_T(15), HSTR_EL2); >>> - /* Trap all coprocessor registers (0-13) except cp10 and >>> - * cp11 for VFP. >>> - * >>> - * /!\ All coprocessors except cp10 and cp11 cannot be used in Xen. >>> - * >>> - * On ARM64 the TCPx bits which we set here (0..9,12,13) are all >>> - * RES1, i.e. they would trap whether we did this write or not. >>> +#ifdef CONFIG_ARM64_SVE >>> + /* >>> + * Don't trap SVE now, Xen might need to access ZCR reg in cpufeature code, >>> + * trapping again or not will be handled on vcpu creation/scheduling later >>> */ >> >> Instead of enable by default at boot, can we try to enable/disable only when this is strictly needed? > > Yes we could un-trap inside compute_max_zcr() just before accessing SVE resources and trap it > again when finished. Would it be ok for you this approach? Yes. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Jan 13 08:55:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 08:55:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476885.739299 (Exim 4.92) (envelope-from ) id 1pGFq0-0007qv-VA; Fri, 13 Jan 2023 08:55:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476885.739299; Fri, 13 Jan 2023 08:55:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGFq0-0007qo-RQ; Fri, 13 Jan 2023 08:55:00 +0000 Received: by outflank-mailman (input) for mailman id 476885; Fri, 13 Jan 2023 08:54:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGFpy-0007qi-N7 for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 08:54:58 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2073.outbound.protection.outlook.com [40.107.21.73]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f44c7f60-931f-11ed-91b6-6bf2151ebd3b; Fri, 13 Jan 2023 09:54:57 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PR3PR04MB7433.eurprd04.prod.outlook.com (2603:10a6:102:86::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.19; Fri, 13 Jan 2023 08:54:55 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Fri, 13 Jan 2023 08:54:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f44c7f60-931f-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=APgihOLz7d2BIjBiXdfJtdCFov3B2rnJnRuQrud99qxbMhWqdaOGwPSshb4V0PFTc4c75kxXJp7TuhbxAbG3W5mm+jBLp+j/ia8I4oFUPYcypkrVrJgVHILyDndUfPax0D5SN4XxJimxUxW/aJo5X2RkTnVhiLEF+hscu+Iq7r8Fr3q5LKeMCBc7uM1ttofjV9ZoMJ7DqU33znxxbwe9xd9RBca2sJCOfeLXnqXuulace/LzP8MGyfOHAFXGOfPi5HLyFFhs7YgY6S4ErnDhoHeWEtoYY5agZU4oBRWiB0OZLwBFXIGOSzNCL+BzTzNxB5MeZygfUSBtlXzpEZDJHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BWrPUVjoqMFh0FM2rL79u3+EH1x10mLK40Rea1zlylE=; b=f9sd+ew0uC7MtfozG3aW+8z1rPgIbAqEbK+jqs+kO6lpUhaMjV4RMcQj0VIFHgNfUavJwDxBgGHZNOcPqFXitX/vT4obPTGtWvYNrl1ucrrv8yuUCmca8Su+4jw+Fq+QgG9gv4C5S4NYCG2GoqbcBdGXHx0vrExTJ6KYeZ1iyTPAAnQaTzBoxYndLoRCh2jOFgkq9+NN1tNJUUDV8xPLfgtqN7fE3SCdee2m3Rwq7mugtmJEtw3eWcnSrrc1tjr0ojkRV7Q2z97t6mqWFSnO7ccS+O8I/cZq1brfDogKv6tkbHSWqXls5JEVtoSDEw2BEA54lyp4HRX7WuEZ97F6Uw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BWrPUVjoqMFh0FM2rL79u3+EH1x10mLK40Rea1zlylE=; b=qglbwcK3FHKx3xYvsxL7LAHo46gjAqIarjqaKBbPUhmGz13HtxedBrw5ELzMWzG8vFQaQdi5MYzkR19RJWsyQbaUculie8NgniHlmDl0wboCt7lKjpVSOhBRb27K2GSCANlPAU+E9sfKwm/Q+z3Hmg3qJeNFeXUKOWxY8Z88UrJTIKSD9sjNfOOLQcqU1zul0k1PS5N7WegUvwd+XbBxghoKs/w3dapYs7rO6yZncwZn7jfQOjNRlsE2L2wXtPqskJlRZwy7zptmLOOxxJvz5YqtjZD0OQgU16IN+QWpIXqDeGF9Ph1gRkl+rhuxjeLej5h7y/87OhBxQja8ToZetw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 13 Jan 2023 09:54:53 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 00/41] xen/arm: Add Armv8-R64 MPU support to Xen - Part#1 Content-Language: en-US To: Penny Zheng Cc: wei.chen@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20230113052914.3845596-1-Penny.Zheng@arm.com> From: Jan Beulich In-Reply-To: <20230113052914.3845596-1-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0001.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PR3PR04MB7433:EE_ X-MS-Office365-Filtering-Correlation-Id: 2bd909e6-1c63-4322-7a26-08daf543d760 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EG5TDp0nGvN6kBFgl/AUcIqUxsgyQiorzee3O8wornYL4CDFaKxzs6CjFO0evfiI8UKY/rqDksiGNxd04PypI7zug91fboqUXPPNpOomHsx7MkjtOoMz2QHA/XNvFk84RMVX/onpZoHf+Jm2A3kC0tkHDUMyhlHful/Llpgd10bTg+Q+YOSi1LEs7KrL5TIKVgzikQFhYKLTVVE9vIuQ1HG2EQLO29V7T4EGhGp2SdgFDic14OxAj4syHdAVkqSvVsqvLYI8PwWWDbIkJh8pJxFW9u6yWiKX3JvNSE6wFrvL/v+dutYc856l8GGWD4WcWbLpEBLvHo0WrPR5ju+4eVjlZshqSFpKRCOHOUxlFhbGT3FflHUkShpSQJb74QMhKjA/WYDlsyyClbWjyjhPGECOfp7e0UMsSr7wP6NXq8YOgrn+4LreConxxlLpjsXohCDUDMvYQMlabc8wFSrwHBB7bvvLHc2xJlr7YA6+8hSwzjJySzW2PwTIOIe8tTzQqhhl7B2zVSQRIBkVziHXnog0sNIwz3MED65qyUwD+ZZNWfhaWEGqGu7VCfMoCh05hvMnxBc+xmXtS3s8OnonNacq2Tb0xh1rn/0O9mZHjuksxI8SmO4mci1DwuA6baVptbbYBvmn4eFM8y0cD1nDrZ8Bzh3GqK0+BbJDtZmv4vGIjO8wqoYm8nHVgpF1DzJAvN4OadCdUSFBkLaSFiv02Oj/x20uZteK03uVDKlWY1gmioP9XkLAaabixGWFXsQQ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(136003)(376002)(396003)(366004)(346002)(451199015)(6512007)(6486002)(478600001)(6506007)(31686004)(186003)(26005)(66946007)(66476007)(316002)(66556008)(54906003)(2616005)(6916009)(4326008)(8676002)(53546011)(86362001)(38100700002)(8936002)(7416002)(5660300002)(41300700001)(4744005)(31696002)(36756003)(2906002)(17413003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SUY2ODl2Y1p5aXRrWUhRZ0wyMm9QZEpSbGx0bVFWQ3Z3RFdIWjZxYzVSZDVY?= =?utf-8?B?NnMzTjFXNElWYTBYeXd2Nkl5SE54cmlSVDllSWhKR0dMZFlqY0NZYkxiK3Zo?= =?utf-8?B?MWE1cWlDN29DK3JrZzVBQzMvY3lWaTFEQ3ltbmVkUHExUEpzR3FtRmdwMEJh?= =?utf-8?B?V0RlczN5RStQd1ZYSGN6L2JBYkMrU2pUQnBTQTRCaGtKQk1mem1yeEo2RmVy?= =?utf-8?B?WlF2MUxMM2dGTTBpaDIxUklwcEcyRzVhS3ppTUFmTmxwT3JjaUQ3VUZodEty?= =?utf-8?B?OGhRMUZmYnYwZHBGaE41RGFTRjFIakFuc3JGUkVSMTNNaUx4YkNadndmYTNF?= =?utf-8?B?N0prUmZTUEFPRVR4SEJRK0lYdEdTaTJxZmlxeUp4WXlxYm9JYTkrVk9VOTRE?= =?utf-8?B?RDR1STRFSHcrR2hHT0tma2I4YzlyZU1zaGxWSkpPczdzQXNvN3k0S2s5UzN2?= =?utf-8?B?bENGRlJJWXp6dWVZREFDMy9pa3VPSlUyb0NVRXJ2dkY0Z2dRQmVBYVNCNHE4?= =?utf-8?B?VW12QlFnK0VaMHlGMUlDRnhmZWhNdWRTUEJFa3NRaVUxWWxBbkQwTTRxbTht?= =?utf-8?B?ZjMvc3RYWTd1SG9UVENiWkt0TTNiM1pUVy9peWh2d3QxVlVlRkd3c0VSTUdL?= =?utf-8?B?QTRXb2xHTTErNE1UOElTdjM4clN0ckNUWmxSUXk3bTJCYXhoeVVXelVta1pD?= =?utf-8?B?QkNheEU1dG90LzAvdnhKTmpGbHRiTkZ2WEVySlVHNys5Z1lVdk00K3FiWFRD?= =?utf-8?B?SDdyNFVkd01LdjVQVnp2RG5CbUdvQXEyVWhkV2p3cEZ2c3VmeklsT1RjY0o0?= =?utf-8?B?bm9vcndUSFQ1MnRGYU43YWdmcStIeXRYWXZaUHppa0t1QXBibDFLNlQ2R2xG?= =?utf-8?B?Y2NvWmM1YUM1VnkrK2ZyVEJpMVZtYzIrM3l0bUE2VE9yZy9icUdhZ0VhS3pa?= =?utf-8?B?NVhxVUZQajNHL1Q2V05uaWtEc25kZTVOM1J5clU0bm9LMEQ2QTJyY3RyOG9x?= =?utf-8?B?WElRaUdBZFZwZkVyUkljeGI1Yk5sMHFLQXhmZEdiZHYzWE1CdXdtTHN1UDZW?= =?utf-8?B?RmZOWFNYbDNKcVdGRHdoSWRjQVFObjZmNHp1WDZhOTNueC8yQlBHSmtTYXVy?= =?utf-8?B?czFIaENXN2dwY3kvMWszSXczYnh5VjFzajhtU0Y1TW1KL1FtRGRWLzdhSVhm?= =?utf-8?B?Nnd6V3piMWx0NTJMSC9RZFA3UjlhT1QzbFl3WjF2NGVKYjduVERTQW5QN25F?= =?utf-8?B?eXdNaXJVUkNFdzM0QnRzd2t5OXJVekwvOUJyN2h4ZWFJSU1ZWTJ3bTlJVUJX?= =?utf-8?B?dXJLaDdqQ0ZlZGkyQ0xpSXh0WXJ1ZVVZYVpzNFA1ZzZnNUhEb0JEeklBc3dN?= =?utf-8?B?Z2VTZ1JlOUZqZnZ3bnY5WnlpeHJ4WUFUWFRnNFdXV1dOd1NIdGVFZVQ1akxS?= =?utf-8?B?WGdBYUlmT0JVWFArZy92b3lYZW9jOXhvREorcmg4Z0p0WXRkMkhOR2Z5RDZv?= =?utf-8?B?cWZPb1RyODRJMC9MQzZNbGovQ1dpenJtUTRHcGd2a0wrUWlBaHJMRmV4dEFB?= =?utf-8?B?S1hpTnlrTVY2blRoTUZBV0lZMHZWVk93dVgyM1A1R3JTbTAwSEorS0MrTmhQ?= =?utf-8?B?RDFpKzZjM216Z2xuOUozQVFvd1A3MlZlZUFOallBRVBHUm0rdFNJUlo4eGhp?= =?utf-8?B?OTBrdlFEVmVxLzNNWVVBSUM5YXdVaTlTSEVXa2MxUWJkdGJ5RW9DTTBtdE5W?= =?utf-8?B?WXNHTTZjR0F5bTg5OFozNWJMOGFNZGI1QXRaNXl2M3hhMGd1dWt4V3Vnc0FY?= =?utf-8?B?blNSQ1V3MTZONTNlZU56bTE0VDBmNHpzdFlMSEFFZWlhQVZjQmtGVk9xem8x?= =?utf-8?B?SDdXK3JZeUx5VWZyM3hWL2ZzRkdEVjRsWDExbDFVaG43bHJvVElETVRNak1P?= =?utf-8?B?Y09Na0NKbUJnbFVxUDlxRU1PNnNocG1oWTBwUHNwTzkzOTdQc2tIOXlyaDk2?= =?utf-8?B?eW84cDJxbm5yWEIvTTJ2Ry9odklBMGhkR3NkNDVOcDkwQ2ZkL216Vlp2TkRH?= =?utf-8?B?NWZrc01oa1EvamF0bkdsUFl3YUprZ3pGSWttY1dzeWpOOFduenM1SWR0bzNR?= =?utf-8?Q?YMmjp7GfLUKnTCXaHwKU+iMn3?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2bd909e6-1c63-4322-7a26-08daf543d760 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2023 08:54:55.2790 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kY7JCtVU3qfWQf4FjUFczKz7JBWIiZCcJZYxYolg5QU6C97pnDCh0JSdij5eQlEn/+Cw2XFn1DuB5DuMFmAKHQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7433 On 13.01.2023 06:28, Penny Zheng wrote: > xen/arch/x86/Kconfig | 1 + > xen/common/Kconfig | 6 + > xen/common/Makefile | 2 +- > xen/include/xen/vmap.h | 93 +- I would like to take a look at these non-Arm changes, but I view it as not very reasonable to wade through 40 patches just to find those changes. The titles don't look to help in that either. For such pretty large series, could you please help non-Arm folks by pointing out in some way where the non-Arm changes actually are? Thanks, Jan From xen-devel-bounces@lists.xenproject.org Fri Jan 13 09:04:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 09:04:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476891.739310 (Exim 4.92) (envelope-from ) id 1pGFz2-0000xe-Qk; Fri, 13 Jan 2023 09:04:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476891.739310; Fri, 13 Jan 2023 09:04:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGFz2-0000xX-Ns; Fri, 13 Jan 2023 09:04:20 +0000 Received: by outflank-mailman (input) for mailman id 476891; Fri, 13 Jan 2023 09:04:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGFz1-0000xR-Vr for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 09:04:19 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2052.outbound.protection.outlook.com [40.107.247.52]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 42864f57-9321-11ed-b8d0-410ff93cb8f0; Fri, 13 Jan 2023 10:04:17 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM7PR04MB6902.eurprd04.prod.outlook.com (2603:10a6:20b:107::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.13; Fri, 13 Jan 2023 09:04:16 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Fri, 13 Jan 2023 09:04:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 42864f57-9321-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R3Z99oOIQvg+/iWYUa00yVVIpSEWpgjmm+TB0v8EqQKCUpVZSIjFu2dGBcitcJpPG9+lX+4OUh2I338OhFQfP0aooxGgOIVuEIN6q8z5yWCMsCQ08CE0HlA94PGp8+MBElJIEDi1OvCrH+3zS8hTnARAgcgFxv3bFX2z+bti2M/b8esTXO5uWoOLK7nb0hwEM/Bw76s7xTHeQYhGga8Gq81ryfVhq3HlPD7VlQCoutY54HbP5d4Wcms3FTph/elB5KxWa2nzf+0ZPT3OlpAtJw87jBNw2JC1QJdxT7Dan1ElCctXGhGs/sKHQdG5kvi+Idg0TYd9WlWU2n9qk5ymig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ikpCPRyBnn2PQBXs6zphf8ZMYfTSU9wBgd0hKfIBIVE=; b=miLAhXV4kWJ/uqD6Z5WrDDBjm7u/AN+zogL5m4M+g2G1jpNo7at8v8LAe8Y+VqpAQskEPsz4p0MC3AeJGlj1HPDEXi4BEjcgtKpSmxhN60QMFHpHaQ9W8gr7stPgOKyeB4C6hpLYMxX5fDyI11HaaM19axeJZ7Iwefc3o8Y/QR1WNUHGPMiUvBEG9hmCXMCulwfZ2blPAOslWIdzx27irc12+E96U1vFXe2r1dt3C7ZT++qEyHvQKFw9ROuSIu8vOlBjBnNXq9h3W5SyRjJjP3tIA5Bh/sAR3zmJUA4ma/gJWNaRckzjyoVueSXYIOMyDoSzwuE8bgVWOuIPORWPuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ikpCPRyBnn2PQBXs6zphf8ZMYfTSU9wBgd0hKfIBIVE=; b=yzwomtxAUiCecr9YolNHIKyXR6YVJ7eUZIQVeDT41/QTD1VefZmnJrXs4p1iX2knX4TbRrUfEFYYzTUpM8JwUDSfJxxrRDicB0QCabUnbIUt1gTBgoHYoow1zqiKIBGFi8z8WqIrc9RA4JSzMP8XlEBczBV7f5hBjU4lPkidyGzPKK3hrDe8JLgcruJca9jyWM0UHTUpLDw1d+q59Zoa0Y+ljsqikOqCgZat4JKUUMfP0IynuS8OQyN8o7LjFBFxy3ZJgmfIXgzSt8PgS58IcSFGyzNprDW5j54g1LbYp/HqAnzv33A133mz7RpUGZQomWRbLQM+3IheagoS/wNElA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <635fb465-9350-70b0-3c99-cbb87bea58d1@suse.com> Date: Fri, 13 Jan 2023 10:04:13 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 1/8] x86/boot: Sanitise PKRU on boot Content-Language: en-US To: Andrew Cooper Cc: Roger Pau Monne , Wei Liu , Xen-devel References: <20230110171845.20542-1-andrew.cooper3@citrix.com> <20230110171845.20542-2-andrew.cooper3@citrix.com> <27d830b1-a32b-1368-3c0e-e5de15da5000@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0161.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM7PR04MB6902:EE_ X-MS-Office365-Filtering-Correlation-Id: 938a1971-08e9-4977-3102-08daf545256e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: faTv1E6/ZC/DhrOwgDxA8a+p3o0XloAW4CeaD8pGxpd4Cx6lYVErYH+1HAEqfFob/aaizSC55486zkXnwS2tD7niqdqfDbYcfiLxv1XLp6QIriHfm9Rzr1coQLewVGOeRhUA1blW1UM8rUU7rMj6EnZ6vG4Y90oRIRtNI1jmJB0dey/oFx4lvs6AFNjka7xwuE2D26sdLy/L9O6UhrJQr+eIY+sxA8dgEBzj9jT74vBphggCLTIuhliadQpvxSA4wExZHUJtRPg136WwG+LD+/ynUaA8AIJhKbRiorxVKbrDWJj6ZUb5MwqA7p6om+h+sG0L5RY2jJEkzD3PRp5P37BhazVsMFj+52lsSvQW6NvBcrJj8P7cIpnd8rricEp7Nf1qFgxvhKoAuh+d/Kfjm15XJO03vBSsoOUwi2Xl6dv8rl9zcgqvG3LUSXw0fQuno/91C249vpct9fwSol4folUilC7A2MAk5TbGJKnXgy1N9h2VToEdjfoDym6TJu6S5Q4oXSrOV4veoBSHgAfNVSAdbxDO/M3pNsv2aL7uPY3aXgoDnx6qTOmSHl89UwIUPWV2JGYhu1QZLRhF3dL6uSil0KukrvsCjpveRFYAsIZRHEB6k61qgMH5ep/UPHosRZ2o8nFFh8t9VBErMBi8JJ8vFXEvF99k1WrZelksCaf5bqQ4fJb5+n3F2lj9GsFJROd6HHoqI1dWVEUvNlZCFgExr2H9ymgMWppy2ljUbtc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(396003)(376002)(366004)(346002)(136003)(451199015)(86362001)(31696002)(54906003)(2616005)(316002)(31686004)(6486002)(8676002)(6916009)(66946007)(66476007)(66556008)(478600001)(26005)(186003)(6512007)(53546011)(6666004)(6506007)(36756003)(38100700002)(41300700001)(4326008)(4744005)(8936002)(2906002)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UGlpeXZKaW5rS2VZNktnY29nYlB5TExjRjhZWFVsODAwdkVHbFUvVDFsS1hj?= =?utf-8?B?Rmw1UGIybHcwR1crY0p4cWw2Smx0a1FzWUpndTRIa21nbXFDbGN4K0FHbUFB?= =?utf-8?B?QWo5MGtQYXIrdHVFMXV0ODNINGk3bUJySmZHR2pmQVVBZExacDdWRVJwN3RO?= =?utf-8?B?UmNBRThwczY2Z2NjV240QjNDVUxHS0o4MkF1UGxKMTh2M1Bjamt5R1Q1MCtJ?= =?utf-8?B?TjdRWm1pU1dYYW12MXIxUGVWay9BSFp1dGRIQ0VtVmRPM1p0TmU1MS9ZbW5l?= =?utf-8?B?dU9MbS9sdC9za0lCbzZJU0M3QkpwWE13cmpGRzN6azkrSnJYQjdoWCtiZ2dt?= =?utf-8?B?b29rWFNBcUhoM2Y3S0twbjhZMkFLVkN0MDY0UWEwU0lPRTA0WjEwREhsRlZr?= =?utf-8?B?MXFMcDFpU09hUWtDQU5iSGxtay9IQXJtYUwzQTJrNmViSXQrVnlmUzlSOXp5?= =?utf-8?B?L0Q0RHNkRE4wNWp6K09Ua0czZUxxNzN0SE83VFY4NFBDak44bC9ZeERmUzZO?= =?utf-8?B?MHVLajFVdUhWZzBkZWt0ZlJ2d1h2N08vUUdZQVRlcFJFa2Q3WHF3MkNVZm5h?= =?utf-8?B?bFg5cy8vQ2RKUEp6WE5Yb1BKUVNHbVJPY3kyWUZBRGJrd25ZZ0NONXRTVUpS?= =?utf-8?B?VEdxSjR0VVlNZ0RDT0NHemJ2QkR5dmVjMzRKRFJXS2VxUXVGRXhURDNNazFQ?= =?utf-8?B?dTJ5NGhSbDBXWnAzaVRjS1lWWk9LbWZnL1d6MkVYTVZBNllBZE10V1E1cGsv?= =?utf-8?B?cFE3TkNoRUxSRkkyRlU4R0Q0d09qNXpFTFl0eVVTR0VqdDFrVDFlaGl2QUtY?= =?utf-8?B?d3RuZWJlSS9Wb0RJSkFtcFNaWFBkSTRqbjRIeXYrdHdBYnoyYTE4SlhQMURn?= =?utf-8?B?bmVQU1g4K3UwUjFTd21FSkRVV0c3VG5tYVo5ZzlXdTUwVE9KclBycmtXY053?= =?utf-8?B?VVNKYllCSDZ2N1dIVytrbzVqRFlMb3hZL1B5TEJZeDNvaHlSWGJXTnBvTmxC?= =?utf-8?B?NGZyblM1OFdKcGp5UFVIcndualBja1NuNmYzM1Yxc09EaTlJTWRmdmRhMHM2?= =?utf-8?B?bUVkek5FRlNyd3RiZlZLMnBIUnRDWUxESmM0cVdnU00yRmhHd2hQbmpNU2U5?= =?utf-8?B?UHJjZG90a0RsK2pOdGlQTFVrNVlYd1huKzdQUmVoaDdoNzdQdmFFZ3JRaVdN?= =?utf-8?B?UmxOczVVRWVOR2ZBb1hLcDJSdXRMbHZaY28vbUNJU3phT3VrTkFWL2RNeXNj?= =?utf-8?B?MjdXVVdkVHFPY1dQU1U1cWs5dFoxSjVkZzRGSXB5UjVUekpWTS9PaHp6WnVs?= =?utf-8?B?b1RvU082cFkrYkY0MkxnY0gvcHhWUFhVaWthVERFWVpXRWlrQUMrMCt5UTBm?= =?utf-8?B?T0k2QVFUYllNc0FZS0VtM2RWc1YzRnllZmo3UTNoZWhNbi9ockY2bGZhekxF?= =?utf-8?B?UXdYM29ITlFYbW5ockxVSDU1eHNNOVN2ZFVPUGRBMUZReVdBdU4wYlFxbElB?= =?utf-8?B?ZUUxM1hkdFJnTEdrdHpCNzJwYUU5c0ZwM05ZWXpoeFlzZmErTG9YdXdFZTBN?= =?utf-8?B?K2NLRXBEOGRST0s5YWNjRDEwR3VEL2Viam5jMmF6ZlNvc3BpNzNxNHA2TFlM?= =?utf-8?B?eFEvSEVaNzhPeFVVSURiS0ptOFpscEFEeUE4QzFJU0VIR0xvVFg2d20reXhx?= =?utf-8?B?d00yM2JkRXVCQ3dTR3pvb1lkVjJUWXQzSlBXQnp5THdWMHpvelE5dmNkUXVa?= =?utf-8?B?QzVkUTZsRUpCdmd0TG9kWTZvL3A2VXFDbk5GUXAzL0xyMFZKUUFhbVdLMjI5?= =?utf-8?B?MlQ2Z1pzb2VHUDlqVW8zN1BVTkprbWQwVGdZa09RRFZTNkF6b3RjbnZYbjla?= =?utf-8?B?NHRYTlhmVXk0QkhkUCtPdHhPRGE4c3hxNWxHcVNNT3UxeTJJWTlzcWpyZjI0?= =?utf-8?B?ZzJJSkk0Q3ZVNUx5aTROYVAxeWp1UHRjd1V5ZVI1QnVGWFpwL3dlK3phNXpO?= =?utf-8?B?STlTeDVyWWhQeDZYWkU3UCt3ZFlyNVI2dGFENVUwcjQyQ1FqN0FndXliYVY4?= =?utf-8?B?Mm1qZ3BkTEZxZEZsSjJGZmQ2RHdCMWtsYkdyTldTa21wWHZlQ3gyOUppSDVy?= =?utf-8?Q?NOAIAF2n90Z7iX1L3rNdMw3uN?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 938a1971-08e9-4977-3102-08daf545256e X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2023 09:04:15.9779 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Wdfp9WTkKFcaZPyjRTrOBkFpx0kVavrIoglAWsSONpPEn88RD2/z7TN/ENDaiIw/4qFGiy9o2Sod4GILdYthFQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6902 On 12.01.2023 18:07, Andrew Cooper wrote: > On 12/01/2023 12:47 pm, Jan Beulich wrote: >> On 10.01.2023 18:18, Andrew Cooper wrote: >>> --- a/xen/arch/x86/cpu/common.c >>> +++ b/xen/arch/x86/cpu/common.c >>> @@ -936,6 +936,9 @@ void cpu_init(void) >>> write_debugreg(6, X86_DR6_DEFAULT); >>> write_debugreg(7, X86_DR7_DEFAULT); >>> >>> + if (cpu_has_pku) >>> + wrpkru(0); >> What about the BSP during S3 resume? Shouldn't we play safe there too, just >> in case? > > Out of S3, I think it's reasonable to rely on proper reset values, and > for pkru, and any issues of it being "wrong" should be fixed when we > reload d0v0's XSAVE state. Fair enough: Reviewed-by: Jan Beulich Jan From xen-devel-bounces@lists.xenproject.org Fri Jan 13 09:06:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 09:06:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476897.739321 (Exim 4.92) (envelope-from ) id 1pGG1M-0001X9-6i; Fri, 13 Jan 2023 09:06:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476897.739321; Fri, 13 Jan 2023 09:06:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGG1M-0001X2-3l; Fri, 13 Jan 2023 09:06:44 +0000 Received: by outflank-mailman (input) for mailman id 476897; Fri, 13 Jan 2023 09:06:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGG1K-0001Ww-TR for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 09:06:42 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGG1J-0004u8-L5; Fri, 13 Jan 2023 09:06:41 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=[192.168.6.109]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pGG1J-0002Po-EF; Fri, 13 Jan 2023 09:06:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=fWx2t2vjKMyHxD03g44wYPIrZcah6J8RTFBmmy80OyA=; b=Wd8DAAT3pfpZVu1BJCIPCD/ESu ammoZJQUlsAKLmvYxBOriIVM16PPEDKdlKjM+Iiq8DFawrfGW6+dglWbu7bz1OtpsrUTzLc2rWWL+ mSlVg6gIDo/PyG8eAlwjR1pha5T++rNalfwiyTXIE0BrCVbfmKCxSM0FlQoEyiSIG9Bk=; Message-ID: <096b4129-ace6-01b6-85c1-b153d3bc4ada@xen.org> Date: Fri, 13 Jan 2023 09:06:38 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [RFC PATCH 2/8] xen/arm: add sve_vl_bits field to domain Content-Language: en-US To: Luca Fancellu Cc: Xen-devel , Wei Chen , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu References: <20230111143826.3224-1-luca.fancellu@arm.com> <20230111143826.3224-3-luca.fancellu@arm.com> <91b5c7db-ec9b-efa6-f5cf-dc5e8b176db6@xen.org> <9168CB2A-A1F1-43E0-9DAD-BB31AD3979E0@arm.com> From: Julien Grall In-Reply-To: <9168CB2A-A1F1-43E0-9DAD-BB31AD3979E0@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Luca, On 12/01/2023 10:54, Luca Fancellu wrote: >> On 11 Jan 2023, at 17:27, Julien Grall wrote: >> >> Hi Luca, >> >> On 11/01/2023 14:38, Luca Fancellu wrote: >>> Add sve_vl_bits field to arch_domain and xen_arch_domainconfig >>> structure, to allow the domain to have an information about the >>> SVE feature and the number of SVE register bits that are allowed >>> for this domain. >>> The field is used also to allow or forbid a domain to use SVE, >>> because a value equal to zero means the guest is not allowed to >>> use the feature. >>> When the guest is allowed to use SVE, the zcr_el2 register is >>> updated on context switch to restict the domain on the allowed >>> number of bits chosen, this value is the minimum among the chosen >>> value and the platform supported value. >>> Signed-off-by: Luca Fancellu >>> --- >>> xen/arch/arm/arm64/sve.c | 9 ++++++ >>> xen/arch/arm/domain.c | 45 ++++++++++++++++++++++++++++ >>> xen/arch/arm/include/asm/arm64/sve.h | 12 ++++++++ >>> xen/arch/arm/include/asm/domain.h | 6 ++++ >>> xen/include/public/arch-arm.h | 2 ++ >>> xen/include/public/domctl.h | 2 +- >>> 6 files changed, 75 insertions(+), 1 deletion(-) >>> diff --git a/xen/arch/arm/arm64/sve.c b/xen/arch/arm/arm64/sve.c >>> index 326389278292..b7695834f4ba 100644 >>> --- a/xen/arch/arm/arm64/sve.c >>> +++ b/xen/arch/arm/arm64/sve.c >>> @@ -6,6 +6,7 @@ >>> */ >>> #include >>> +#include >>> #include >>> #include >>> @@ -36,3 +37,11 @@ register_t vl_to_zcr(uint16_t vl) >>> { >>> return ((vl / SVE_VL_MULTIPLE_VAL) - 1U) & ZCR_ELx_LEN_MASK; >>> } >>> + >>> +/* Get the system sanitized value for VL in bits */ >>> +uint16_t get_sys_vl_len(void) >>> +{ >>> + /* ZCR_ELx len field is ((len+1) * 128) = vector bits length */ >>> + return ((system_cpuinfo.zcr64.bits[0] & ZCR_ELx_LEN_MASK) + 1U) * >>> + SVE_VL_MULTIPLE_VAL; >>> +} >>> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c >>> index 8ea3843ea8e8..27f38729302b 100644 >>> --- a/xen/arch/arm/domain.c >>> +++ b/xen/arch/arm/domain.c >>> @@ -13,6 +13,7 @@ >>> #include >>> #include >>> +#include >>> #include >>> #include >>> #include >>> @@ -183,6 +184,11 @@ static void ctxt_switch_to(struct vcpu *n) >>> WRITE_SYSREG(n->arch.cptr_el2, CPTR_EL2); >>> +#ifdef CONFIG_ARM64_SVE >>> + if ( is_sve_domain(n->domain) ) >>> + WRITE_SYSREG(n->arch.zcr_el2, ZCR_EL2); >>> +#endif >> >> I would actually expect that is_sve_domain() returns false when the SVE is not enabled. So can we simply remove the #ifdef? > > I was tricked by it too, the arm32 build will fail because it doesn’t know ZCR_EL2 Ok. In which case, I think we should move the call to sve_restore_state(). > >> >>> + >>> /* VFP */ >>> vfp_restore_state(n); >>> @@ -551,6 +557,11 @@ int arch_vcpu_create(struct vcpu *v) >>> v->arch.vmpidr = MPIDR_SMP | vcpuid_to_vaffinity(v->vcpu_id); >>> v->arch.cptr_el2 = get_default_cptr_flags(); >>> + if ( is_sve_domain(v->domain) ) >>> + { >>> + v->arch.cptr_el2 &= ~HCPTR_CP(8); >>> + v->arch.zcr_el2 = vl_to_zcr(v->domain->arch.sve_vl_bits); >>> + } >>> v->arch.hcr_el2 = get_default_hcr_flags(); >>> @@ -595,6 +606,7 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config) >>> unsigned int max_vcpus; >>> unsigned int flags_required = (XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap); >>> unsigned int flags_optional = (XEN_DOMCTL_CDF_iommu | XEN_DOMCTL_CDF_vpmu); >>> + unsigned int sve_vl_bits = config->arch.sve_vl_bits; >>> if ( (config->flags & ~flags_optional) != flags_required ) >>> { >>> @@ -603,6 +615,36 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config) >>> return -EINVAL; >>> } >>> + /* Check feature flags */ >>> + if ( sve_vl_bits > 0 ) { >>> + unsigned int zcr_max_bits; >>> + >>> + if ( !cpu_has_sve ) >>> + { >>> + dprintk(XENLOG_INFO, "SVE is unsupported on this machine.\n"); >>> + return -EINVAL; >>> + } >>> + else if ( !is_vl_valid(sve_vl_bits) ) >>> + { >>> + dprintk(XENLOG_INFO, "Unsupported SVE vector length (%u)\n", >>> + sve_vl_bits); >>> + return -EINVAL; >>> + } >>> + /* >>> + * get_sys_vl_len() is the common safe value among all cpus, so if the >>> + * value specified by the user is above that value, use the safe value >>> + * instead. >>> + */ >>> + zcr_max_bits = get_sys_vl_len(); >>> + if ( sve_vl_bits > zcr_max_bits ) >>> + { >>> + config->arch.sve_vl_bits = zcr_max_bits; >>> + dprintk(XENLOG_INFO, >>> + "SVE vector length lowered to %u, safe value among CPUs\n", >>> + zcr_max_bits); >>> + } >> >> I don't think Xen should "downgrade" the value. Instead, this should be the decision from the tools. So we want to find a different way to reproduce the value (Andrew may have some ideas here as he was looking at it). > > Can you explain this in more details? I would extend XEN_SYSCTL_physinfo to return the maximum SVE vecto length supported by the Hardware. Libxl would then read the value and compare to what the user requested. This would then be up to the toolstack to decide what to do. > By the tools you mean xl? I think libxl should do strict checking. If we also want to reduce what the user requested, then this part should be in xl. > This would be ok for DomUs, but how to do it for Dom0? Then we should fail to create dom0 and say the vector-length requested is not supported. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Jan 13 09:10:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 09:10:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476904.739332 (Exim 4.92) (envelope-from ) id 1pGG5G-00030p-SB; Fri, 13 Jan 2023 09:10:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476904.739332; Fri, 13 Jan 2023 09:10:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGG5G-00030i-Na; Fri, 13 Jan 2023 09:10:46 +0000 Received: by outflank-mailman (input) for mailman id 476904; Fri, 13 Jan 2023 09:10:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGG5F-00030a-G0 for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 09:10:45 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2086.outbound.protection.outlook.com [40.107.241.86]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 28b545e1-9322-11ed-91b6-6bf2151ebd3b; Fri, 13 Jan 2023 10:10:44 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB7982.eurprd04.prod.outlook.com (2603:10a6:102:c4::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.19; Fri, 13 Jan 2023 09:10:42 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Fri, 13 Jan 2023 09:10:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 28b545e1-9322-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jKLQI6nQJU9ELfeMLlKuGkgHq0aOumlQKZ/SVt+oVi+Jg6iGTrk5xjHpmeyX0kMkqVR0S9cl1TRqhWhoTAY3SHI3wofe4k+wr+7wkso1qBdIKkju5Q9d2Cm88OqU31AipNSvqvbnmwuz5/tSzHD70onqEg/g2/QVm7WKo266pzYLMua0Hx286SSq6EiUe028jYX3W4y0swlzQsMRLy/LzYHa86+OBZ/HSBD3pC3l4hwDn0DcWQ2G0ZZIVC+RAtgWDl0rqF9LLEinqrEbvjFjPeBbTsqJ9ZqIgTgaPhIL/nNki8O8cAff+4nzu6BhtAvHyH6wzT2et8BJSA2X5gemzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mEpZ5SzWvp8KWJ5Cil7cQwtmvjg2LQtZa/sb2AiU7zQ=; b=NhD8RoYuxXj7DsFGRgqC+AVuLkEQxYfHxbDWY4uJFuNLsEHSTWjbaPx9RBpK4cgej7HMwFFVqOvkHBPDY7kBRGxtZXKD9A0njaj3tdJSiKZX05ubTdGtv4Yn5H4DHzb/nbzl00Aq8nl67kD0SR0uI3oSrSLukTQ1pgoyAv1PWur0WD3Rh0SM4byLosCPHQ5M47N5m5BRSSC+q65ZJoNamcLAkJRwrgXtPrz2vqQMZOHk9yNqFupxSP0nvZ9J9LZq0EzliE8N0igdmIE0epNpX9UQhVINTAuj+j1gLYcFLR1B6ZMbWWzgB6f32tMONCWHgrZq6p92E/s2V105y1I1Gw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mEpZ5SzWvp8KWJ5Cil7cQwtmvjg2LQtZa/sb2AiU7zQ=; b=Wy5liNjL5lg9ONxR46u6ajEaXY8UsR1z7nEiFEobovRznBMx8jZp45NFAr3TjnZ0jGu8tZr2R9nlVOBfcSniayW+05VgyuH6BgSJXiMUQtFf5unYtqq7sc8SkOawMy6/rziACO3CkEWcPNJn1HM49SgG70ANso/PgUJWV9HUh1qbS19OKH1mtOqTsJxjAoPtxPs5whcVr7YxjZs9RDm5UcfXKs3w/j71QyOZzbgJoXMvW/VaLLtqjyFqKISLdNeGZSNVwsngf6mS+Zcqrg1QpE4dSoy/lbhSNkDP2tYs/BU05G/EIwdRpa+ENXHDDjL3F5EKXklYAOGzYH0Ncx1UwA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <07b71b77-6979-6bc6-508f-4041a978392c@suse.com> Date: Fri, 13 Jan 2023 10:10:39 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 6/8] x86/iommu: call pi_update_irte through an hvm_function callback Content-Language: en-US To: Xenia Ragiadakou Cc: Jun Nakajima , Kevin Tian , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Paul Durrant , xen-devel@lists.xenproject.org References: <20230104084502.61734-1-burzalodowa@gmail.com> <20230104084502.61734-7-burzalodowa@gmail.com> <04e5b744-bb61-b3d1-7d60-97bb710f7584@gmail.com> From: Jan Beulich In-Reply-To: <04e5b744-bb61-b3d1-7d60-97bb710f7584@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0078.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9a::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB7982:EE_ X-MS-Office365-Filtering-Correlation-Id: 07d6bbbe-8dea-4fa1-2872-08daf5460b63 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NBPRFLb6ofUDjoYuIW6maiX3pd8nuVu7dTQc3dnWXXMLAPT8PNSlOT8htcNGYDoMN1lTg5wlkjFoxOkWfLhOsMMXRDGSfGGoOtjE0q5M7e/D8UNAAff/HNu0cUfWs90Mzy74KxVlgb+43CwRLUPNfT4dxXIvldowy9wxGs+ncceOQ9QvbqS5HLBX8IfLDyLTYsAc0TW8KciB+/ZLzQqOKEP+jXXWGsTHs3EW9bVZTIJEGk9brZeRxmiHrud/13VcxBf+v/Ne6comDBgP3nUHRL0nMSW+BOWMyPGPyVyqEl99LoATnseH5JrybwUFf5436TYi27rmTn3f/MTXfyscit/ObGD2ocYUQKdNIWqveS8nPvjLdmJhCtO7U9EbKldHj4Lvy8swrbZrPYaMMF1Xu5PL55sOp+LjsSXhTnH2rquj5F2qD2nYRk2Dxh70zVu0CO14uN+9J48fkaaKsnOKVVq4ZW4KsXSuuEPhslVX9lKI69FaHYTiPcVMkRZKrUsOFasl9Y70dWNcrjpnIyckHS4G+9WrBx90q8L/x99480HSVr1s9y/0K5Dtapa684UHc03gA1+/BiyU7n0sFSZwX0f49mArBVhvQ/y2FEVDDaqnnr+BYy0ZY9gBL9+tfmbNajf3O1Vp/8g31DDI7UaI0PtXOEvEFmoMLy/5UYCUwwz1/HIbbozwmMwj8S+c8iCeyOg1tVh+ZeW4bp8xOJsFTp6rswwCKNR1bJJvlj62A5Y= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(366004)(346002)(376002)(136003)(39860400002)(451199015)(5660300002)(4744005)(316002)(36756003)(54906003)(2906002)(2616005)(38100700002)(83380400001)(6486002)(26005)(86362001)(31696002)(53546011)(6506007)(6512007)(186003)(478600001)(66476007)(66946007)(66556008)(31686004)(8936002)(4326008)(6916009)(8676002)(41300700001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UHNXSVVsd2kzNUFsSDlpN0hhaG5zQW5LcTdkbnZzMDhXcWV3QkpWVHBYVGxv?= =?utf-8?B?N2Nxc0J5ckdIK1BGaWJYY1g2S1NPKzV5UlZUTzFnSHpyaG92czZ1MlB0cEtt?= =?utf-8?B?QXNsbHpQUWVDeGxVVFZIazR5alpSSVBjUnB6eVFYQlViUmVXcmNXeFBCcVh1?= =?utf-8?B?RnFiS0pnMjBGUERKZDYwSlV3bWdQS3lFYW80LzdxODJpVmlWc3ZUbHA1OUtC?= =?utf-8?B?RWtPZDdLeTRXRUhOTlF2THdSSStvdTVGRTRaLy9ybU5JQTRGODdQQ2xJOGFz?= =?utf-8?B?T0x4MVk0MDFQeXBROGpYNVd1MFgvd1RUUW1hUVRYSzZ6aUZQeVdCdjZ4S3VW?= =?utf-8?B?YjFqZHRXcml6ZmN6ZGladnV0WVVvQUJCaTkyRis0ZllOUlNCbHhvb2c0bzho?= =?utf-8?B?SVU1aEphcUk3UGtLTWZNS1B1N3NmK2lCWWY3ejBjczFVYkxnRUhZTHArVlFx?= =?utf-8?B?aC8rTitLbTlSV1FFYWV6QzBXNklHZ2N5ekxpVWpFYWk5dEZENVEyVU1KVFpw?= =?utf-8?B?bytlQ2dPWWFxT3dhcFh4aWMzYTZrb2lZWWpMbWdYTTVsK0ptMEx3QS9uMXpP?= =?utf-8?B?cGhnRWY2OFVra2JQQmlyOWQ2NTZMNUwyREFYMit2OXBtZ01idFgyNkFLNm44?= =?utf-8?B?ZHlZQ0wrUFY2bitlUDJzbzAwZStsV0xQQnhYS1NXRy92aEJCSVl0TWFEUEk5?= =?utf-8?B?ejZiaG1UMnZXUzUySlNsWUFWbFlYbSs0a2tjVHF1d01wWENJRWR0WjEyQjJa?= =?utf-8?B?cnR3OW00VnpyZSs4QnVvekpuVDVacFFhRTFvRXFBWDE2NW9tN3VxUHpNWFNr?= =?utf-8?B?L3I4RGwzd3lBcnZrZnQ3Yk9vbURib0w5L2RhcS90bG9xc3IwVHkrTDdDQ1M2?= =?utf-8?B?ZklnOUdkK3ArNWRkaDd0MHpaRGtCMXlMK0JFWGVpTDlQWTdEUGdmeitNSUY5?= =?utf-8?B?ZHZzcDhHLzF6L1dqZWRPelh4Z3BJem90OXlTclJ1OXhCNzhIWEFNckc2bWNu?= =?utf-8?B?bVQ5SUtxc3Y4N0plUXZ5bWlZTGF3OTFKL2tVTzB6eHNxcVNqeWhkUmxEMGFF?= =?utf-8?B?YWFuenFyOHRaWVhvSjhqUVJrcDR6Ymk1K0FnTVpTeFBXUVpOZVRFZkNoRzdS?= =?utf-8?B?VW1MaHZPdlZsKyswSE5MaFhoY1FEcTBlNVFHMm5QeGtlVll0TzNYZElQRFhr?= =?utf-8?B?WFRRbTEwejA5QlFhaUxyblAwRG9oWnlFdTF1RGROZjlVejdSRE9Tb0dDc3ow?= =?utf-8?B?bmdvak9Ta29rQ2E2TEgyZHdmS2FRa3VzUlBMWjZDTEgxT3RLSkxML1dMakZX?= =?utf-8?B?NEZYSEVrVTdobGRpcW1qdmFLTEtGUDErckN0SXFNc1BRUUlPWXF0dHpzWEdS?= =?utf-8?B?ei9NS1BRamtmalZURFRUMVU0aWU3eWVxSkNaZ28zYUJBUnpNVDhwcHpKVVhJ?= =?utf-8?B?ZHpGOHorTXF1TkRLeGxuYVlCU0tvWC9QTlJobjFhcWNjNFlmUnltbVRhblRp?= =?utf-8?B?VER4OTdpYlBUdVowSVlQWmpubGZ6WVB3NmNKYmtBV0dvVWhnVW5ZSTd0Smsz?= =?utf-8?B?eFZXSTQ5V2lxdGNPcGovTUQzK3BNK1Z6djJGbWNYdWduTkVYZXUzWXlUSjRN?= =?utf-8?B?UnRTSjlYNElqVnlycExTbnZpaDkwejliWEdDckxYZGh3SHdyRUw5N3huLzhB?= =?utf-8?B?d2FMOXVzNGIvTGs5SnRYdkgya2JhbkRmR2tBbkJXQzBucVltSzh1Y2RWMlRy?= =?utf-8?B?T21vMGdNcTlBSy9Rc0JYUVlvTkhPQzl1RlNlQlRaZnlwcFBnSlBDaHo0aUNz?= =?utf-8?B?YTdyWVQ0MDJHb0tHOHhlbGJMSEl1R1o0UzhzZWdFSUU1MnM5Y3hWUExJKzlj?= =?utf-8?B?RDREOTFMWGQzeE9Fak8zUjJPK01vdDMvTE9rSXZjS1RmN3Y0UWErQUo0b0gy?= =?utf-8?B?VUlQVzBPRkgzdkJGL3RPbS8xUXFreW4wMnZ1MVkwZ2E1RDhGWmhYSUM1bWZU?= =?utf-8?B?VW5pZlA3a09HaE4rZWdMc1B4U3JBcHlLaVZBUTg2bFhkTVBLbEZ1U0VyT0Rm?= =?utf-8?B?VWtJVWozSDRJcHlLUno5T2pQWHloZHRJcUNXUTZmeGI5TTVqZFZ0SVhtcUJt?= =?utf-8?Q?TOPOwJM0VO4NMoKqc42tzuRqh?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 07d6bbbe-8dea-4fa1-2872-08daf5460b63 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2023 09:10:41.5628 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xIjdgTy8ky4RU2G2clgdBkr6ewoSUORa9M6BcZi/BwpMD6d39bq3nje03QXDiO+KMhRr8IXkB8/ADoXuSg4dWA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7982 On 13.01.2023 08:30, Xenia Ragiadakou wrote: > On 1/12/23 14:16, Jan Beulich wrote: >> On 04.01.2023 09:45, Xenia Ragiadakou wrote: >>> @@ -250,6 +252,9 @@ struct hvm_function_table { >>> /* Architecture function to setup TSC scaling ratio */ >>> void (*setup)(struct vcpu *v); >>> } tsc_scaling; >>> + >>> + int (*pi_update_irte)(const struct vcpu *v, >>> + const struct pirq *pirq, uint8_t gvec); >>> }; >> >> Please can this be moved higher up, e.g. next to . > > Right after handle_eoi would be ok? Yes. I'm sorry for sending out the earlier mail without completing the sentence. Jan From xen-devel-bounces@lists.xenproject.org Fri Jan 13 09:13:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 09:13:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476910.739342 (Exim 4.92) (envelope-from ) id 1pGG7Z-0003ZT-6C; Fri, 13 Jan 2023 09:13:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476910.739342; Fri, 13 Jan 2023 09:13:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGG7Z-0003ZM-3Z; Fri, 13 Jan 2023 09:13:09 +0000 Received: by outflank-mailman (input) for mailman id 476910; Fri, 13 Jan 2023 09:13:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGG7X-0003Z0-Ev for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 09:13:07 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2080.outbound.protection.outlook.com [40.107.22.80]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7d889a5a-9322-11ed-91b6-6bf2151ebd3b; Fri, 13 Jan 2023 10:13:06 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8743.eurprd04.prod.outlook.com (2603:10a6:10:2e1::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.19; Fri, 13 Jan 2023 09:13:03 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Fri, 13 Jan 2023 09:13:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7d889a5a-9322-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PQkOv7g1o2Zy40OpLBtVVK06i2rZOkRXp46QkgrUVOFkE4dMOzFnSO8/LZnMan+mM7FUasG67Pl2k1Ct0FNtSRHcD4aI8FToaKhJjtPGK7xCdrorF1wib3oxg2ce8pHQ9KvuPV6+BedS/oT59LJorYo88xC3nRPO91hg0pvsMRmodu8apCSi5C0jDElw4XGQ48L5nyTQno1Uwe7vsI+aXsp4zftdV62uGhs+k0WwlAxj4y+JJ+ZTGhWxyupv6ICqbTqA8RKmYJcM932kUXHVDdPSuFOUvW4E6GVtor2zgyXBkdxJUEDXZSrNKoZH6+0E0eyvTsG0axV1Qhr/KNbB4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UqMdE8TRkZlwe7RW6FFwmS0gNI30pCf2CvesE5gndbc=; b=EpNjBIpiaHcmp02V5NpvW4AJdg0+UvBc54leTRsNvC2ijt9D/6f11dTnNPX7aoChTiOIVh7JkrbTpLRq3Zz7l7fKAFot7BKVHlD7U/0dhXGuIXqMpSH72VM6YP51g7+i1k3H/cj1sl+xzrYq32B9l2ZHt3Mum/Tnl0xO0iGdXpG2550uatbzwqDKaaPDql1224xqDPkJ7NRvbh5b6QM2bjzYf3BKbpB2o3JIH5D/Smb3Mr4moGihwD9FNbtk9/I9ty+xisQfWxkUqfxOpAA5lc2NbFiaX1lm1pXT8GxZuRKUYIAJSTogzPCvTGFf6PS8KCDy1OONxPQ5agYBsz6Zmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UqMdE8TRkZlwe7RW6FFwmS0gNI30pCf2CvesE5gndbc=; b=C1pWcBHviAzQxhhQWHuRancXfrzEh2SWBXSgsD86XdSiJWcbvPiJNl3V+korMFDBe5nz9E0kfl8gNSuePg9cMg9GMb8IPXbFMrqE8GQo7JI4PCdgO5vCSdzVlKAkaXoVmqMheBExgIo3zcFhkfchcYNRGnl+rIe+HdTxC6XIHkCSX7cxII412Ockh6FNBwi4EhIqMLgoiH4JF8QxdAbxLoxpOmGacd7+X9tWur8T5utfd6R4Qi0ScDqQeapgJM6GwmELcazBCEHF6xjDxQqFBRQMlbLt4SAhiJIdyvnSwO5ywiqd4YBNAK8LxTLJjEFLP7HRU8bIROxoGcpm0S0w8g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <4144bf32-1eaf-b85c-7a0a-b734d6267a77@suse.com> Date: Fri, 13 Jan 2023 10:13:01 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 6/8] x86/iommu: call pi_update_irte through an hvm_function callback Content-Language: en-US To: Xenia Ragiadakou Cc: Jun Nakajima , Kevin Tian , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Paul Durrant , xen-devel@lists.xenproject.org References: <20230104084502.61734-1-burzalodowa@gmail.com> <20230104084502.61734-7-burzalodowa@gmail.com> <6c5a4c07-e942-a683-8579-a0f9d5971c7b@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0128.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8743:EE_ X-MS-Office365-Filtering-Correlation-Id: fca0c8c2-de8a-4587-6b42-08daf546600c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5fgGFoiQ3X1Ora452ZqyVYXWd2e39IsHaQhkbbMSkoOVQhmVtnSdjvQlHXRn7gFIRN01YNUiTOHVA5UB4TP6OTnaeeIa5Gl93XlIG6TrN6rLQefuETv5s+f7DXvQlED4Snxaa+k+xOCb7GqX9M1qB2jH1rIObURDOZjYkppsgavwqMEr5jflro8PWyEMt3dJ2LsXAqUsj4Z5JIEjUVasnRs0Yk5S2MHVTsW7RuYG2hrcv96QV/BSm7lcunRPnWMZUYA9BGGyq6d/lUZAuHScsHq9uBXQ+LhgYyvW9lBye4KMMUhMLFnidB4BCAkZrp9kP5ytzFGi+t5qSxzbKcaTRMrSzVxS2ys/sacOd0pdfMdQbKfL2K+wI3WsmJWF+6ixzSknYfeLD6L+reUUhJagp8vIPFWdW3drrwe7ZQ1WBvdvQT0rxChAXiN4z0XStZ1lMJopzFqoxTdAeEkWLAmNcS9ZBodi9TmP/MpMKz2Z1/PQR53tFT3+8MEpuxkAM8ATr2xjO6j9gh3DmSCAFokCFSS4TzM07jJ/zjscvGck8q2RWCkdaL/qQFjDPnQex2kDSYZZ1gm4LG/XOUd6T9IwPAqZn+1yAj7lH57qM+GnGTQfMwJC8koo5owb9wkK4E5FOTQpVwKCzuIvKBVAi7WSChpZgugdIP4t28DBuV2Uh6VewQz34uAmzZVc/o6TM3XBrplWwaful/006tfIs+Vxo4yr6tgYv3OYL55rX+T69xE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(366004)(346002)(376002)(136003)(39860400002)(451199015)(5660300002)(316002)(36756003)(54906003)(2906002)(2616005)(38100700002)(83380400001)(6486002)(26005)(86362001)(31696002)(53546011)(6506007)(6512007)(186003)(478600001)(66476007)(66946007)(66556008)(31686004)(8936002)(4326008)(6916009)(8676002)(41300700001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RWk1WU1qdEh2V3pSZ25DQm51Vkd0SXhOUHFYYTdYM05Idm9nWnliMmNkakxh?= =?utf-8?B?bDU2U2Q3QURlNU1vOGNRQ3hkS09CVE5Ld2E2SHBaUVAzejZmNnEvREUvNDBW?= =?utf-8?B?dlRYZTJVZkMzZUtJY1JGM1plVVp2Ri9ySjdKeGNOMGNZcHlydVdVWkNabnJy?= =?utf-8?B?ZTdEaVJvQ0lSVm10ZEQ2Kzl4aTJuK2EyeERZNUlhSFg3UGtaQXRmWWVFSTNy?= =?utf-8?B?VCtsWDF5cFkxc3djc0lpeVl4dkZibEV5cUQ5TWE1am5RcnUwcmNVM3RIN21Y?= =?utf-8?B?VGdpeFZ6UVdwUTNkTjlVdHMyOE9iN3NiZS8xeTdDTWhiam1HRTJtZ2JrcWI1?= =?utf-8?B?cTU3RlZsaDdFcE01ZDkzdnZUZjNnNWwwNUxyOUYrdmFDZTRNZEZuendwNS9v?= =?utf-8?B?ZHFLR3VwdHRQdmdCbzJRalZnWXh3UDdkM3phNG1ZZHN4V2tSaER2VUd2dlJK?= =?utf-8?B?ZzRDWDZoT1k3SldJTXN1YTBPY0l4U2FsSEl0ZkdvcElBbThrYlZqaUxZbnY4?= =?utf-8?B?M3FBcXpaV0VTSWxkNGJVeTU4SmppS3gyUGkzMU90NG9MM0xYQ1FPNGZkeUxa?= =?utf-8?B?d3hFTHNEcUVPVG5GNmpSdlZ2UlBqbFZMNmhLc0o0RjNpaGlTeHFmS29aVzRP?= =?utf-8?B?cHhZMmpPTHlYc01GTDFtSWFxUGUwKzJ6Z0lmaDl5TTlpNUppV1A3b05LcGds?= =?utf-8?B?a04rQU5QVjFLVmM5MkJZUUxPZlM5LzhCczA5QkpHZE5BcldMWEZzdzEvVS8y?= =?utf-8?B?aldwcHo3ZzcrR0ZiSE1haS9hOEdseDhOTldCWlZQNVZnSm83TWJvZFMrM2M5?= =?utf-8?B?dTBxemdHb1hJMXB0UFNXclZZcDRMT0hmZFpKNVRtcFJsUXdacllUdTFLMkU3?= =?utf-8?B?RzZtZmNKMXdsR3Y2ZDBwVkhGS2svT3B3UFBRcnVqajkzd0VmamtCeXRoWUNS?= =?utf-8?B?SXlhN2VKVXUrdjA2WE91YlE1YXhwTVlpRWltY3U3NWlROFJQRkN5OUZHc3JV?= =?utf-8?B?QktVSzlUck03WXBPVHZTMGFMREozQ1k2aHNub2hUSnFOSklhVmhoUjhVUlhT?= =?utf-8?B?ZDEzYTh1ZS9YenNSOVhmeTExek91Z3lpcGREbFZhQUQvSDBHYmt1L3g1Njhy?= =?utf-8?B?ZW9PT3lWRjA0ZFhqTEtOK1p1WDY1OVlBZHFXYkNBcHEzRE53R3d1K1pESzgy?= =?utf-8?B?WEszcmlDdnZ1ZnZrb3kvcTZaVDYrWjhUV2dmcHdtcklxdlhHZHMvLzMwSzJZ?= =?utf-8?B?U1hZK0tjV05MTU40OWNIbkI5b1RpakNOQzdIWktBVzlTRExvaDlueTR5Nk1B?= =?utf-8?B?UTZwTkZzcGJ1YTFjNTArTWxCNHhLRFZPczJZTTh0SWJ1TnRkN3V1dVJDemdV?= =?utf-8?B?OS9RNjBINm5rZlYxaC9EckJSZ0p6azYrK04rWDB4L0tQYjFiaHVJbkFHaGlu?= =?utf-8?B?cXJUZVRJTE4wbmNSNkFLZHFueHFrZlliSGlJY1NGMXkxaHIyYnQzOWM1TFVm?= =?utf-8?B?amZXSW93bTg4c1BYdkJ6QmR4UkFtYUtHOENSc1NnYngwVEJMaHZ5T25taWk1?= =?utf-8?B?T2xJTTJrRVluaGpIWEVPVXV6b2I1alkwS05lSitrR0VHUmMzUWR6WldFNmlI?= =?utf-8?B?c0U5dWZJNmpMeTYxdkRmMGFZbHRzcHllOE14MzJHT1d1OWFGMjVXOWhDU2Jm?= =?utf-8?B?ZHZWT0MxKzFpeWdJL05vQ0p0OS8yM1hmMHVGTisvbTNhZ0xUdThsRitlcWVW?= =?utf-8?B?THd1cGpkSGJ4dWpibWdvTFNqMXZ0Uk12WS9GOVZHUkJqa3E3OEdqU2I0Vk9j?= =?utf-8?B?bXZEeVhTcjV5VHFNZHBnL3lqUXJvNlRQY0x4Q3NVY3hPV0hYYjhsYVFVeTBq?= =?utf-8?B?RW5nNzlrL2lLRklDV29CTWdESHFEeWdkZHJhbnA1MjNURVJ2MGFiMXVhSnVi?= =?utf-8?B?U0hVSlIxaGNQVk9TSUtwSW1aN1AvaHZld01ubWU0eDM2V29IZmJFUGF1M0dU?= =?utf-8?B?U0pNTEFOalhqbTZLVlpTaWcwMnpHbTY5aElXSTI3TnVsNlJzTFZGZGdReEVQ?= =?utf-8?B?SlZEVEYzSXl3L3JOUnZ4T24rdVJYb0x6SHdCQjQrS0M5dTlwVkFEVUVaTE5Q?= =?utf-8?Q?Y77805CaiRJQ8wC25rThL+l0x?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: fca0c8c2-de8a-4587-6b42-08daf546600c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2023 09:13:03.6007 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BRjpHAZr4ok9SOz3sC30aCuMc2lZgKlM26DnkFHy46/KdJ0lXkNF432kxb8dmtPewJVAg97sAvVPVASp8iX1Xw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8743 On 13.01.2023 08:44, Xenia Ragiadakou wrote: > > On 1/12/23 14:37, Jan Beulich wrote: >> On 12.01.2023 13:16, Jan Beulich wrote: >>> On 04.01.2023 09:45, Xenia Ragiadakou wrote: >>>> --- a/xen/arch/x86/hvm/vmx/vmx.c >>>> +++ b/xen/arch/x86/hvm/vmx/vmx.c >>>> @@ -2143,6 +2143,14 @@ static bool cf_check vmx_test_pir(const struct vcpu *v, uint8_t vec) >>>> return pi_test_pir(vec, &v->arch.hvm.vmx.pi_desc); >>>> } >>>> >>>> +static int cf_check vmx_pi_update_irte(const struct vcpu *v, >>>> + const struct pirq *pirq, uint8_t gvec) >>>> +{ >>>> + const struct pi_desc *pi_desc = v ? &v->arch.hvm.vmx.pi_desc : NULL; >>>> + >>>> + return pi_update_irte(pi_desc, pirq, gvec); >>>> +} >>> >>> This being the only caller of pi_update_irte(), I don't see the point in >>> having the extra wrapper. Adjust pi_update_irte() such that it can be >>> used as the intended hook directly. Plus perhaps prefix it with vtd_. >> >> Plus move it to vtd/x86/hvm.c (!HVM builds shouldn't need it), albeit I >> realize this could be done independent of your work. In principle the >> function shouldn't be VT-d specific (and could hence live in x86/hvm.c), >> as msi_msg_write_remap_rte() is already available as IOMMU hook anyway, >> provided struct pi_desc turns out compatible with what's going to be >> needed for AMD. > > Since the posted interrupt descriptor is vmx specific while > msi_msg_write_remap_rte is iommu specific, can I propose the following: > > - Keep the name as is (i.e vmx_pi_update_irte) and keep its definition > in xen/arch/x86/hvm/vmx/vmx.c > > - Open code pi_update_irte() inside the body of vmx_pi_update_irte() but > replace intel-specific msi_msg_write_remap_rte() with generic > iommu_update_ire_from_msi(). > > Does this approach make sense? Why not - decouples one place of the assumed "CPU vendor" == "IOMMU vendor". Jan From xen-devel-bounces@lists.xenproject.org Fri Jan 13 09:16:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 09:16:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476916.739353 (Exim 4.92) (envelope-from ) id 1pGGAQ-0004Bz-KC; Fri, 13 Jan 2023 09:16:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476916.739353; Fri, 13 Jan 2023 09:16:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGGAQ-0004Bs-HT; Fri, 13 Jan 2023 09:16:06 +0000 Received: by outflank-mailman (input) for mailman id 476916; Fri, 13 Jan 2023 09:16:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGGAP-0004Bk-Ia for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 09:16:05 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2079.outbound.protection.outlook.com [40.107.22.79]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e7a2b533-9322-11ed-91b6-6bf2151ebd3b; Fri, 13 Jan 2023 10:16:04 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB7982.eurprd04.prod.outlook.com (2603:10a6:102:c4::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.19; Fri, 13 Jan 2023 09:16:03 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Fri, 13 Jan 2023 09:16:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e7a2b533-9322-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cz36W0dh2FXosdtxqdAa92ZDiP4Oyr9Uac0ps+Bir/G9QyZJgakmOt9e6lJbEZ1IobKm4vxLF+RXVTAWNZyXT63uV4Mtv2nQDsuiA0wehzObnbGGFU6WMCQ2SekHjr3q7BIaHICAa9Au5yU+qdKKAc+L+7vviIHHSvrHif/vmrtOs8vsNZL8cdFrti/JWRtAIYoylR5WDdepvXt3t6z7RKmOisMThsQ8UmPRLn6O9bmMhk93gPFA8NaY1UuiZMApNlCqSBenn82aUc1Wya55ks10VtZM1To2IU0cpKu3Egcr2dtkDhwFmZ/vhECfPO+4RRyVuWP24uqGhBbCK7bDvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H/EGN5qboOgBGC012glyK/C4KBiGb90uJnhpWogn/v8=; b=Z/SqRmTfgsHqsREqawPqCdRgZafk98IoWDFVJeHOKPKnPKGHGS3+7dYhIG5O1yfzESLDZYh3DXuA7dzJOY1fmc+NV3cLQM+d21gnDyylYk0QykHk+I7LZiuEV3I4RWmzRgqhGSNeT+91pgrbYSwNNlYfEUCeq8fepbxisM8E8HRktQtzEUuu9faCOZR9CEh9eaj7RwXcfLau/WJ7eOmIgaMfLDJelT+sawnPEd2YErgVfP27Kf6wjbpmGC0bT7lsffmLjVOcuhxsUNJJQRCGnAWrjDVAdXgLWge7LG9ULdbtLSvECqSYhTnSGA/LDfrbm3g+IXx31g/+2MI58aAflQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H/EGN5qboOgBGC012glyK/C4KBiGb90uJnhpWogn/v8=; b=F35NrIeC6MkYr1JyXwHRdc35hUgz/BtKqWEBdolVOMK6g2U0Y0u7SNBKjZxdPL9lLnv2qiFBwcmef3595DDnS2jFPD/3j78RjA/cK0dDPZC5BqdzrdjvYKX3GLiYtu08ZhhiD57wVpqYH0SKjHl+pxCfd0n6CEAT/tU/z4/4mbs4DxnPDnUzD7F1TeZRosrsrqFRaLVsuC4ql/0LluJJPTrUrRc10tYyakeTUYGJOYMhzY07EXlieiibXL72USoFE4eB87gKEDfInnPslzpgJheqdIuw71xSUQu4LibxNfErdxb8A9JhtCLZCBFDWQRwxyrf9ZjASa2EZ2KIOttVlA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <386a58bc-6d16-475e-ffd5-a3340adbe4b3@suse.com> Date: Fri, 13 Jan 2023 10:16:00 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 05/22] x86/srat: vmap the pages for acpi_slit Content-Language: en-US To: Julien Grall Cc: Hongyan Xia , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org, Julien Grall References: <20221216114853.8227-1-julien@xen.org> <20221216114853.8227-6-julien@xen.org> <965e3faa-472d-9a79-83ca-fef57cda81c5@xen.org> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0137.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB7982:EE_ X-MS-Office365-Filtering-Correlation-Id: 80f1fb61-c02d-4e89-af96-08daf546cac0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UeUBtcNlWfkssLfoj6C5bGLXdUo1rTl7S1Sn3kjXIOt/H2LQ+Wu9T60UWMggk5KgQYL/iSR3TxKhOq+oPPGIUpC2sIClRexlSFgyP+PreYubhdofjnugU9dQENb+dvxuMWdPTjg2y8HBzehA3opmcyFoOG+iAsxgxYCHIqexw6tEEt3HZ7rXoMuHflzD/IwCCGohgIfdmodot4vCJ8mVuHufVTwrP3nk2gz4TccC/wIa6E311H3FG8l8HnGSAlTIJo08WSaRVokYsyyAHbZ8WpqmhOSrfWmm2aZ9eyWpU3DcXYI8gFaU5owRv0SvBUSXbCJ2RXc9wpVv67RHR/orUZWuM/Nc2OzW/i99qfPXJzEQY/z1rkfr9UqujztIWlYCrWqWDrx70cB1co9L9ZbMHgX521UP765m5hKtRJtDfGwMuoro9cvUDdW0+MlBZgntLaUeiR3ImUC0hmi5NdkUt+uVrje3Nbd3I6TuL/o2EaAHCdF5ZstZCb+b0bU7XLrQGi7BY57GBZOF6wxatkwQ+NsdRLlVVjAkjHnezp1hoMdhGgYGzAsWiuwIMJA52qJv5g/lBuQ72bKNh5U/9MIK3H4Cx+CKqq78pBURPm2KWNnjbcP9Fw0ai/uSetsJvry5bGMDE65MORih6LnG9YS6Fc9PjVBVGWFLLuHL6WhnfxrXRi/VePI11iGkeBR+0nhNM9vY5lMfzhRiFJZvofmTbHQyqjXJMFV+GfkQTU7j8qs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(376002)(346002)(136003)(366004)(396003)(451199015)(66556008)(66476007)(66946007)(31686004)(6916009)(41300700001)(8676002)(8936002)(4326008)(36756003)(2906002)(54906003)(316002)(2616005)(5660300002)(26005)(86362001)(31696002)(6486002)(186003)(6512007)(478600001)(53546011)(6506007)(38100700002)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bngyTE1NTHdPc2pDcXR2bk1CYlBtcjRFb3hHOVN0VlROWUhtcFVZZHBnK3J6?= =?utf-8?B?QSt5alFMa0k2MjJyaXZtSWRENkNXNTRUQlg0V1I3UEhJZHJZRHY5U3g4L0Ji?= =?utf-8?B?ZzR1S2x3NjE4a2tEdEs3enQ3NEhVaVZYaUM4TXB4cjNvWDRaUTRpSXZTUFAz?= =?utf-8?B?RzdNd0RDYmtmWkZJMGtkZzd0ZWJJL0dYaEt5VHpjcFBHUUF3b01URU96TTBR?= =?utf-8?B?ei80cHFHUmhPOWRNZXRKbUhhUTZCN2dYZVNhNExTTkdjNzNuMFdRaU42Yk4r?= =?utf-8?B?TzVRdHkwZkQxa09Ud05lRmVwbUdCS2JiWlpZTnRRcUUramRQZ284dnNRTVEy?= =?utf-8?B?OE5YRTZMZGNIdE1LNVFSM3ZSd0JRV0d6SXp3aC9xQnYzVVc0QkVnUXpuMVNo?= =?utf-8?B?cmpxc2dTUjljWU9ubzFWK2VxT0RWeUFXWGNIWDA2Zm9wQklTSnh1SXBEbHB6?= =?utf-8?B?WXd0SmkraHdSQ3BObTRTY1lmUjdneThHczR0RlliSDBnZG9ydW5zS0tmam5W?= =?utf-8?B?TWJKU2gwWVg3cnJ1eGwyWTBjbkNvMjR4RnZUTzdpRmQ2dWN4L1dTclp5eXRi?= =?utf-8?B?TllDMTFJZEFHc0hmWEFhNlo3VHJnaW9pOUpIMjc1YzRXMTVneGVmcDAzaHRL?= =?utf-8?B?NkhwRW5qek55ZGZ5WDZzb1hpeVp6bkdKOG1xTitwMUo2WE4vdEtwTDNzM0lS?= =?utf-8?B?Z1lIQnhVc2tmZHZMUytBay9QMjhzNW1oeWdoelZlb3l3SytwWVBzOTNMelZQ?= =?utf-8?B?UGRic2pWcythSk0vSUxJOEZqY1lGMjdsNndUVk5KV293ZXp3Y3o3ejkrVEZr?= =?utf-8?B?UjY5aURGTit3U0VuMFdZSnMreEoxTzZWZ2c4YjZXSENCY3NXbEYvZCtteVpO?= =?utf-8?B?T2wrMUM0MXFXaGpHSXd0NXlTcytqQTh2L3QzTVpIZnZiNGJ4MjVmSWpTTkYr?= =?utf-8?B?NzVRVkVQWEhlZ3N6MlAyUDA0VlNxWmo2aWxxeG9Xem1NeGdtczU4cW43a3FY?= =?utf-8?B?Nlk4c0h0UGY4UzhIaHlIbjNuYjBkUEtyc1hTTHUvZlBWM0VzaGZEeVRSSlRB?= =?utf-8?B?NmtkcUJpV1c4YzVoTVdLV2FDb3pvU0VZUFVMMUREcnJmNldaNWxnSkR0K3Nu?= =?utf-8?B?WERJMVNBVXZJRTVVOTF1K2Jmd1VrdldHRDNPaHU5endxOWxlYmJQektTNHk0?= =?utf-8?B?SzdVUXlycElpL3FGMTBXQUd0cGMvbDNPYnQ2OXNZUUROUHVFQ01TTWJnOW1O?= =?utf-8?B?RGU3cndRc2VXcWxZQmhJV0xTUlN5TExwbzJqTUxJQTRhNEwxVjNuTGtTWjZ3?= =?utf-8?B?cFRGK1ExakRTRkYrcVp1b1BSN2FkSXFyZTV6bUQxa2djVHcxaW9NdkZtUnFv?= =?utf-8?B?cVVoT3hzOFZDNHdZdWNXcGdXb1VTT1Q4M0RkQ0tPekhwZTA5K0l6cnA4Yldw?= =?utf-8?B?M3RnS2t0ckMvM24zQzUxVG9sSXBWOGFxU1JjOVJZWUpVMlJwby9BV2tSZGtt?= =?utf-8?B?SjBxbmkwTWx6WlpXOHBGL3FoUUdPVVRBejI1bXI1dWU4bmZLcm5iYXlZajVj?= =?utf-8?B?VEdiZTZpUlhlLzcxYVJ4S2RvMmhsOEtlQzRzcXE2TVdOM2dSNXRuRUMyT1Q3?= =?utf-8?B?akh1TzBOVng1OGNIRjY4dDJMSXFURXY4cTV6UFFIVzJrS3R2T3Jja2FYeHFk?= =?utf-8?B?SWUyWmlmMnhaTFBDUkdKNlA2ZWh5WHBialhCRnF6T2dsdllOTXNQR0sxcFk2?= =?utf-8?B?aHVkZzhMaVBSNTM3bXlEMEZKMTNqN3cvSjBNMWFqUWJxTjZ6QnJaOXpCSzdP?= =?utf-8?B?WDBrTDlTK09KSmI2WHFyVGY2MS82QU9wQ3F0a1Q1UGVia0N2cnBPZnM0YVJT?= =?utf-8?B?RWxTbWt0WWhvNWU5KzlNWUtNa1BWME1tdTBpOUNFOXBGb2ZiZUFBNE9IUWdz?= =?utf-8?B?Z2VrdHZzeC9IZ2Vtb2pkbHNwUWFJWllFOG1nOFBsWGpQUG5OY0E2UDREMXlP?= =?utf-8?B?ditVdUN6SlEzVkRxRjF0dHgvUHFhUVNFVmwyU3lsVnkwM3YvMVdZRSsvMENw?= =?utf-8?B?OHl3bmNkYnJkUk9jdHBOMHlnbHZtRGp6SnRVWUZXYXVkVlVWWUppRWtETEc1?= =?utf-8?Q?01AzF+B99tBrc9fbi2574pE5D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 80f1fb61-c02d-4e89-af96-08daf546cac0 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2023 09:16:02.9799 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sGZX8WnNxv2RMUv7dCtdwCYNxaJXgAzDXqFC1TDi5QBfAkHdi6XaYCu4V68N/6Mslownwlaq23MhCf+hLO6yqg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7982 On 13.01.2023 00:15, Julien Grall wrote: > Hi, > > On 04/01/2023 10:23, Jan Beulich wrote: >> On 23.12.2022 12:31, Julien Grall wrote: >>> On 20/12/2022 15:30, Jan Beulich wrote: >>>> On 16.12.2022 12:48, Julien Grall wrote: >>>>> From: Hongyan Xia >>>>> >>>>> This avoids the assumption that boot pages are in the direct map. >>>>> >>>>> Signed-off-by: Hongyan Xia >>>>> Signed-off-by: Julien Grall >>>> >>>> Reviewed-by: Jan Beulich >>>> >>>> However, ... >>>> >>>>> --- a/xen/arch/x86/srat.c >>>>> +++ b/xen/arch/x86/srat.c >>>>> @@ -139,7 +139,8 @@ void __init acpi_numa_slit_init(struct acpi_table_slit *slit) >>>>> return; >>>>> } >>>>> mfn = alloc_boot_pages(PFN_UP(slit->header.length), 1); >>>>> - acpi_slit = mfn_to_virt(mfn_x(mfn)); >>>>> + acpi_slit = vmap_contig_pages(mfn, PFN_UP(slit->header.length)); >>>> >>>> ... with the increased use of vmap space the VA range used will need >>>> growing. And that's perhaps better done ahead of time than late. >>> >>> I will have a look to increase the vmap(). >>> >>>> >>>>> + BUG_ON(!acpi_slit); >>>> >>>> Similarly relevant for the earlier patch: It would be nice if boot >>>> failure for optional things like NUMA data could be avoided. >>> >>> If you can't map (or allocate the memory), then you are probably in a >>> very bad situation because both should really not fail at boot. >>> >>> So I think this is correct to crash early because the admin will be able >>> to look what went wrong. Otherwise, it may be missed in the noise. >> >> Well, I certainly can see one taking this view. However, at least in >> principle allocation (or mapping) may fail _because_ of NUMA issues. > > Right. I read this as the user will likely want to add "numa=off" on the > command line. > >> At which point it would be better to boot with NUMA support turned off > I have to disagree with "better" here. This may work for a user with a > handful of hosts. But for large scale setup, you will really want a > failure early rather than having a host booting with an expected feature > disabled (the NUMA issues may be a broken HW). > > It is better to fail and then ask the user to specify "numa=off". At > least the person made a conscientious decision to turn off the feature. Yet how would the observing admin make the connection from the BUG_ON() that triggered and the need to add "numa=off" to the command line, without knowing Xen internals? > I am curious to hear the opinion from the others. So am I. Jan From xen-devel-bounces@lists.xenproject.org Fri Jan 13 09:16:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 09:16:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476923.739365 (Exim 4.92) (envelope-from ) id 1pGGAw-0004mN-1z; Fri, 13 Jan 2023 09:16:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476923.739365; Fri, 13 Jan 2023 09:16:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGGAv-0004mF-TZ; Fri, 13 Jan 2023 09:16:37 +0000 Received: by outflank-mailman (input) for mailman id 476923; Fri, 13 Jan 2023 09:16:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGGAu-0004m8-OZ for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 09:16:36 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGGAq-0005Fu-Bm; Fri, 13 Jan 2023 09:16:32 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=[192.168.6.109]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pGGAq-0002uK-4q; Fri, 13 Jan 2023 09:16:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=ZGKf6fIGE2gy8ttV8y3ZORWY2suqBf57lLpjVK0Yhlc=; b=1zhs7qSpXsZ/RpAQu/u7YXdOtb gokDF5itbiwal6sAKol24GAZEPZJMRO/Awap2HuWGdKFIUe9IeBcDfuekGvwVdUfbtgRk92Wrmy0K kOcUYpPGwELNmPfTs52oZjw0p7dwqRYCVpx/FwFehrgF6Y6rgpj6Utkk94J+iHpbZzH0=; Message-ID: <3e3b8ada-3fb0-2bbf-e6a2-1aea712132e1@xen.org> Date: Fri, 13 Jan 2023 09:16:29 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 00/41] xen/arm: Add Armv8-R64 MPU support to Xen - Part#1 Content-Language: en-US To: Jan Beulich , Penny Zheng Cc: wei.chen@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20230113052914.3845596-1-Penny.Zheng@arm.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 13/01/2023 08:54, Jan Beulich wrote: > On 13.01.2023 06:28, Penny Zheng wrote: >> xen/arch/x86/Kconfig | 1 + >> xen/common/Kconfig | 6 + >> xen/common/Makefile | 2 +- >> xen/include/xen/vmap.h | 93 +- > > I would like to take a look at these non-Arm changes, but I view it as not > very reasonable to wade through 40 patches just to find those changes. Right, but that's the purpose of the different CC list on each patch. AFAICT, Penny respected that and you should have been CC to the three patches (#30, #31, #32) touching common/x86 code. > The > titles don't look to help in that either. For such pretty large series, > could you please help non-Arm folks by pointing out in some way where the > non-Arm changes actually are? See above. I am not entirely sure what else you are requested here. Do you want Penny to be explicit and list the patch modified in the cover letter? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Jan 13 09:17:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 09:17:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476929.739375 (Exim 4.92) (envelope-from ) id 1pGGBh-0005L2-9h; Fri, 13 Jan 2023 09:17:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476929.739375; Fri, 13 Jan 2023 09:17:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGGBh-0005Kv-75; Fri, 13 Jan 2023 09:17:25 +0000 Received: by outflank-mailman (input) for mailman id 476929; Fri, 13 Jan 2023 09:17:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGGBg-0005Kf-6J for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 09:17:24 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGGBe-0005Gz-L1; Fri, 13 Jan 2023 09:17:22 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=[192.168.6.109]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pGGBe-0002v5-Ea; Fri, 13 Jan 2023 09:17:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=wgdQi0ayQyWcdd8JT7eyCXgDG7VV2ZJGqmkz8o6Fxb4=; b=PL6Iu2N/o8wWMB+b+i+ifYyeqw vorf4vhns6+Q94F5tmkmAXiIALuyp444GSdHOhjKaRP3vD5hCRwauphtEhUhcV4vXAOjNYvd1M9E2 tkjqzCV6K2gAEA9nevejoxQWXhHyghakYQHaVj/JJ9XZ0iWnXKxMfKjpe58IlzyFDis8=; Message-ID: <85d1bc6b-dda6-c65e-a13b-78ea4baa943f@xen.org> Date: Fri, 13 Jan 2023 09:17:20 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 05/22] x86/srat: vmap the pages for acpi_slit Content-Language: en-US To: Jan Beulich Cc: Hongyan Xia , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org, Julien Grall References: <20221216114853.8227-1-julien@xen.org> <20221216114853.8227-6-julien@xen.org> <965e3faa-472d-9a79-83ca-fef57cda81c5@xen.org> <386a58bc-6d16-475e-ffd5-a3340adbe4b3@suse.com> From: Julien Grall In-Reply-To: <386a58bc-6d16-475e-ffd5-a3340adbe4b3@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 13/01/2023 09:16, Jan Beulich wrote: > On 13.01.2023 00:15, Julien Grall wrote: >> Hi, >> >> On 04/01/2023 10:23, Jan Beulich wrote: >>> On 23.12.2022 12:31, Julien Grall wrote: >>>> On 20/12/2022 15:30, Jan Beulich wrote: >>>>> On 16.12.2022 12:48, Julien Grall wrote: >>>>>> From: Hongyan Xia >>>>>> >>>>>> This avoids the assumption that boot pages are in the direct map. >>>>>> >>>>>> Signed-off-by: Hongyan Xia >>>>>> Signed-off-by: Julien Grall >>>>> >>>>> Reviewed-by: Jan Beulich >>>>> >>>>> However, ... >>>>> >>>>>> --- a/xen/arch/x86/srat.c >>>>>> +++ b/xen/arch/x86/srat.c >>>>>> @@ -139,7 +139,8 @@ void __init acpi_numa_slit_init(struct acpi_table_slit *slit) >>>>>> return; >>>>>> } >>>>>> mfn = alloc_boot_pages(PFN_UP(slit->header.length), 1); >>>>>> - acpi_slit = mfn_to_virt(mfn_x(mfn)); >>>>>> + acpi_slit = vmap_contig_pages(mfn, PFN_UP(slit->header.length)); >>>>> >>>>> ... with the increased use of vmap space the VA range used will need >>>>> growing. And that's perhaps better done ahead of time than late. >>>> >>>> I will have a look to increase the vmap(). >>>> >>>>> >>>>>> + BUG_ON(!acpi_slit); >>>>> >>>>> Similarly relevant for the earlier patch: It would be nice if boot >>>>> failure for optional things like NUMA data could be avoided. >>>> >>>> If you can't map (or allocate the memory), then you are probably in a >>>> very bad situation because both should really not fail at boot. >>>> >>>> So I think this is correct to crash early because the admin will be able >>>> to look what went wrong. Otherwise, it may be missed in the noise. >>> >>> Well, I certainly can see one taking this view. However, at least in >>> principle allocation (or mapping) may fail _because_ of NUMA issues. >> >> Right. I read this as the user will likely want to add "numa=off" on the >> command line. >> >>> At which point it would be better to boot with NUMA support turned off >> I have to disagree with "better" here. This may work for a user with a >> handful of hosts. But for large scale setup, you will really want a >> failure early rather than having a host booting with an expected feature >> disabled (the NUMA issues may be a broken HW). >> >> It is better to fail and then ask the user to specify "numa=off". At >> least the person made a conscientious decision to turn off the feature. > > Yet how would the observing admin make the connection from the BUG_ON() > that triggered and the need to add "numa=off" to the command line, > without knowing Xen internals? I am happy to switch to a panic() that suggests to turn off NUMA. > >> I am curious to hear the opinion from the others. > > So am I. > > Jan -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Jan 13 09:18:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 09:18:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476935.739387 (Exim 4.92) (envelope-from ) id 1pGGCH-0005t3-Hs; Fri, 13 Jan 2023 09:18:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476935.739387; Fri, 13 Jan 2023 09:18:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGGCH-0005sw-Eo; Fri, 13 Jan 2023 09:18:01 +0000 Received: by outflank-mailman (input) for mailman id 476935; Fri, 13 Jan 2023 09:18:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGGCE-0005mi-Hm for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 09:18:00 +0000 Received: from casper.infradead.org (casper.infradead.org [2001:8b0:10b:1236::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2a6a04bd-9323-11ed-91b6-6bf2151ebd3b; Fri, 13 Jan 2023 10:17:57 +0100 (CET) Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pGGCF-005xMC-Ns; Fri, 13 Jan 2023 09:17:59 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 518FB300094; Fri, 13 Jan 2023 10:17:46 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 088172013A2A1; Fri, 13 Jan 2023 10:17:46 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2a6a04bd-9323-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=0yGEeUtjPEYmvw01tTdJaP6xQOH4LDHoqrSGg4IbmmE=; b=b7GY0Fs4Kh53b766Ze4bZu1Jc3 sQKmwNr2hglGmJZJeqnF5joOSCDOx/qOi5bgtrJcB8WFpuJ7T/vyAl8+mvecgBYhnxnO8kMgyVhNN v6eGdd6cwqv6aDki48ixTT8FYF5Bo9vWzEsufvVsogSfgELN6F63++l4Tzd22nVG8g1l0pwBPKGUZ A3lGv9kjETaf0T7YYyxcnZmF0zSy4O/IuXY3ykZGulJhVGuYa7iuM6gad8wGL8NJpmfLyHe10Qn53 L4tqvf37g6tcW6x7srF1FtAQdXPdGN10AJOJwjFgzHtEJBO5WP16pPTYtGMQSPOZNqUmxfdGlxZpV w393kA+A==; Date: Fri, 13 Jan 2023 10:17:45 +0100 From: Peter Zijlstra To: Joan Bruguera Cc: linux-kernel@vger.kernel.org, Juergen Gross , "Rafael J. Wysocki" , xen-devel , Jan Beulich , Roger Pau Monne , Kees Cook , mark.rutland@arm.com, x86@kernel.org Subject: Re: [RFC][PATCH 0/6] x86: Fix suspend vs retbleed=stuff Message-ID: References: <20230112143141.645645775@infradead.org> <20230113073938.1066227-1-joanbrugueram@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230113073938.1066227-1-joanbrugueram@gmail.com> On Fri, Jan 13, 2023 at 07:39:38AM +0000, Joan Bruguera wrote: > Hi Peter, > > I tried your patches on both QEMU and my two (real) computers where > s2ram with `retbleed=stuff` was failing and they wake up fine now. Yay \o/ > However, I think some minor reviews are needed: > > (1) I got a build error due to a symbol conflict between the > `restore_registers` in `arch/x86/include/asm/suspend_64.h` and the > one in `drivers/gpu/drm/amd/display/dc/gpio/hw_gpio.c`. > > (I fixed by renaming the one in `hw_gpio.c`, but it's worth > an `allmodconfig` just in case there's something else) Urgh, must be my .config for not spotting that, will fix! > (2) Tracing with QEMU I still see two `sarq $5, %gs:0x1337B33F` before > `%gs` is restored. Those correspond to the calls from > `secondary_startup_64` in `arch/x86/kernel/head_64.S` to > `verify_cpu` and `sev_verify_cbit`. > Those don't cause a crash but look suspicious, are they correct? > > (There are also some `sarq`s in the call to `early_setup_idt` from > `secondary_startup_64`, but `%gs` is restored immediately before) OK, I'll have a look, thanks! From xen-devel-bounces@lists.xenproject.org Fri Jan 13 09:22:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 09:22:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476943.739397 (Exim 4.92) (envelope-from ) id 1pGGH1-0007O3-4b; Fri, 13 Jan 2023 09:22:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476943.739397; Fri, 13 Jan 2023 09:22:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGGH1-0007Nw-1t; Fri, 13 Jan 2023 09:22:55 +0000 Received: by outflank-mailman (input) for mailman id 476943; Fri, 13 Jan 2023 09:22:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGGH0-0007Nq-64 for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 09:22:54 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on2040.outbound.protection.outlook.com [40.107.8.40]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id da6e05ff-9323-11ed-b8d0-410ff93cb8f0; Fri, 13 Jan 2023 10:22:52 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM8PR04MB7826.eurprd04.prod.outlook.com (2603:10a6:20b:234::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.19; Fri, 13 Jan 2023 09:22:49 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Fri, 13 Jan 2023 09:22:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: da6e05ff-9323-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fKNvTp7e5dVmVgOUTTvVrKoRus+Sx6Tb37yxoEJIcOEudNqDPF0x8w7GLIJ6YsG//L0MZaGUKkDTBp8bmH1NzSNkzbCHvfqXZCqo7bQPmFlA1P5LzYiWcf1kwOCqcH+pPKPGHCZar0WxMRf226igflCuKakmo3yzHLm42FGCvEmzJjLn4DlaJLvWIamzQE8QYHioAXmBTsMukXao220U5kSkLIO4f/zTXQRJeFy3VD/tkzQnm83IoSMBo0Z6wF7whEYjTSHgnMPMdCg1QQ3hiJeRS+SyO35Q5RWWNjIDpfhNdKT8ifpWnYcDir+pMSuXyFfKEaMwazPHCgUtRk9IJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wDB8wfV51oHCbqMgc/qPmfMU7RxBN/N8M94+yck2TJs=; b=ZZ5fGDpDL5dkl6QoIpnJB/bcVgdGLXaNMukJnMb57BB87xUibpPuGn3mkeDfJfX/rGoC/GCBSMvV7ICmMI1wgOVnMZIe7PAX/7BhG8LyqWMUx8amA7KofPmqvQ4elxS+NDC7MiJFQlp9N5MUTvpcnu7ZVXhoSOFz/nHLjCTHffzBQwXf8JQ1GnDg3TxsmEz9ikD5wUVWd2nInruyIvHpn+c2G79+UXrQuTJMllJES8ln/8PIuHl/4xACAuInEx1TahLXLvZRMH5maaXhxqtSyRxMUmxVMojLPZMWUVkio7nnuo/BBMj6yYvgNM8YJ+Or2lY/OGUHTn0h36pRVvQfTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wDB8wfV51oHCbqMgc/qPmfMU7RxBN/N8M94+yck2TJs=; b=RL3TP5H2LHuLcc/CTGCGRVVtTM5gT/lqpW7eK7/Ot2804Iw0BI2HlE9C9PJ2lTS6Fa9xSE96l7PsHDhDdABZ1XwXncDkUmrn2SEYM9NwwrUeHPS4itjVO9VIOnZ6WfOKNzmBqXcpHDN/YVpvMi364lKGEWzHonvTMINWSV1Ud5tcIduKMiJ2wXfhNlH8+CPU3UHoHaFX42EAga14Eu4dNL1j/yMSuz/ceS+wThgg5ZzuN03J/0MIe5cp/Air1IsuxAQ4clbBIJlnSE7IzR2nENRVijymexzWkVvN10FpQtqP9UlfNumigWEi6ibqzfqAOVoR4hx06Df3rr64FZMlVA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 13 Jan 2023 10:22:47 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 06/22] x86: map/unmap pages in restore_all_guests Content-Language: en-US To: Julien Grall Cc: Hongyan Xia , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Julien Grall , xen-devel@lists.xenproject.org References: <20221216114853.8227-1-julien@xen.org> <20221216114853.8227-7-julien@xen.org> <478e04bc-6ff7-de01-dfb9-55d579228152@suse.com> <01584e11-36ca-7836-85ad-bba9351af46e@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0006.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM8PR04MB7826:EE_ X-MS-Office365-Filtering-Correlation-Id: babb946d-7a03-42bf-fd93-08daf547bd4c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RhYmXyd6BpMDp8vW9RKyo7ik18Gh2BEpCOWpzls/Jr+APNCZaYVhEUL4vCoUjGuurn+dp2UG/U6N7ZaHwxZtplXda13y+/rJdjgtekF0suJ4vfaAX0jUhDhjITjSC33CNdORQZ8W6HEWqGFIlMo4tOZBqZSS3XxDV4yx5P46F757ig2wju3roibB3TXjj/z5b4djln2ROj2ku7LABngi0WLZz2ERw0onWInftz4kw7hjbPTl6zFK4fgLZFciwdldit+5rO5Rg2AIhYUKSpy+GXM5H8/Z8qgI1mjoDSLE/oYvNj6fX8DUsLKZTfh2m8+16FqFf26kW1FEV+tZvR1EJzVpZL8fGzTiktQEm0+FB0lP3+n3FL4YjSmkUlkc3wGc+O+/xjFrcbox1XwZFPEpfAeci3EbL16oYNZ/nXSHqn26keo0AXAue4oD1MwrbtfHX+3dX5/yHiZhZ0AcfEqF0TMTor3IScg6Esr9AAK6dIN6GZk7/yu4sdtaAc0kBh422eDPGmuQ5hbo8gmSsNjn2kQCOyg71uY3mxI4RF7oVgFCiR0xIFfB+mCasZGPD/HvDE2oMTYS9ABLpCdzJ5Hdix0o1d37FvlFzN1f9JSXUO2RyfSieqqmY5JeaWRExnvF8t9Djh7LlDo261bg4ofs/XbAA1qKnRCDxa2GtNZ/5DeWgWN9ItW09pBFDL/NBCLFeS/4UBb4kPAfekYNTc0azvFz2WORdZLv5vJ3ye3/v2Y= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(366004)(376002)(136003)(396003)(346002)(451199015)(53546011)(66476007)(8676002)(66946007)(66556008)(6486002)(478600001)(26005)(6512007)(186003)(6506007)(4326008)(6916009)(83380400001)(41300700001)(5660300002)(8936002)(2906002)(38100700002)(36756003)(31696002)(2616005)(54906003)(316002)(31686004)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ckJtZHJGVmxOVTc3ekExOEp2cTZnZEwvdTFTazRjKzJTZklmR3FXU0krTUpr?= =?utf-8?B?THdaMDdOQnF3ZnNOaXNNbEpTeDhGRDJWQ1gvcVFNZWNEUkNtZWJ5aUNFSUsy?= =?utf-8?B?NUZ2cXI2TlZnMVFuYkhPbGJ6TkdMWjZjRFdFUFJUa3lMZGRTY3hSTll0M1dF?= =?utf-8?B?TDBmTlBXK2IvbVVZM0Z2aWpCL0RlTVV3bWlSczlCc0pDZEtubGNncmNhN1lD?= =?utf-8?B?dW9qdEdNeFRpQTBnaHExZ1hRSGtWRnRmNE1aRnprRjRBV3lzVEtTeHd3UzFn?= =?utf-8?B?dlJyVitzZ3NGL1oxbldmNVBoV05uTVdETnZMTUpMTWx1L2VNdGJ3Q2xVcjBy?= =?utf-8?B?NXRxL0NBSFVySzFiMDFPUjRtTXl6RFFodXhkeTd2eHM0TWN3L1liNzk4MTBJ?= =?utf-8?B?clJkZXJKaXVYb3BIUzhJZ2diUXdwY255S2VhenNSNndkUTc1MUdkTzJ4NEYw?= =?utf-8?B?UlJnYjNyOGJwR0FNejBVSStxTCt0Sy95Ung3WktubVF5bHY2cUsyVXE3Yk5x?= =?utf-8?B?OG5mbmlLK2kwNE8xeTlMS2FGSkYwTnlBODY3a09JV01PWGd4TUE2akNlTFdE?= =?utf-8?B?ZlQ5UjBRVTZoUS82ams4WG51SDdTQUNJb2piMjJXNS9kbzNEbGJJeU9BNGtx?= =?utf-8?B?STJiNFZpUnBKb0FQRVREdnk2ZWVCeXR5cnhKa3RMY0owNnpIbVVSRGNWS1Vn?= =?utf-8?B?dXJjQVNXL1pFK1ZTMDJVeWVjRjNjRHBNK1RPRDNPbDNKZFB2bzdXN3lMYnlH?= =?utf-8?B?TG85cTFVYlNsUE1FS2djV2Y3dW1kQUtIUi90cWZpVWRxZW5sL3B3WmZJTXlj?= =?utf-8?B?Q2dRYUwwYzJZRm1FNGJzMTAvTitkRE5UUitNVkRIUHQrdzF2ZGVjYldXWFVQ?= =?utf-8?B?dGg1Ymo2VnI3Zm9rczIvTExReklPdHJWekF6cFEwVHFnNHZlM1dKa3JoNjNm?= =?utf-8?B?Y1hWZlZSTW1raldjVDJ1Y1k3WDRWUEI5b0xXVndJZEY3NEpLb3ZtaVRCa3dw?= =?utf-8?B?Ukg1cCtuS0cyVXZLRUhFU1BDT3hDSVd0Y3ExbDV0MzRvc1BISU9DcWdOeFlu?= =?utf-8?B?YTJWTjlKVjdhaFpaY2F0NGtNZ0hEd0tlRytoTFpiTURPWDdkWUdFdThtWWVO?= =?utf-8?B?Z1ZjNHYrbkZ4ZlM2dVdyZnlmaXBEOG01ZWR5VWxXUjY1RFRhNFZ6d0R0R3po?= =?utf-8?B?anBDbldKdnJGbFpsNkc1UlVUV2VNUXpxS1FjMjJVMnk0NjJNSUcxd2k5UC9B?= =?utf-8?B?eUcwSlBJSXQ3M0pPR3E3MnB6bmc4S2NzT3hMYi8xUzdjcVBVZXB2RDIza2xF?= =?utf-8?B?Sk1FK2pUMDJ3Q3BubmZLcVlnUWJ3ZStna1RFbFFRN0hWdE84SWdHMjZrMzdZ?= =?utf-8?B?Z000bEJ3d212S3NUUlNNb2Z6aVd6aEpKblhseTJFTUxBeG44S2ZLRm52UFdZ?= =?utf-8?B?VG1jMmVWUXNUV1dLemJUMHR2ci9Cc2wwRnVqRUVxOHZPTU90azlWWi8rSk0w?= =?utf-8?B?UEthdjgyLzFRUVQ2UVB2MG9QUHF0cGhtVWI2T3d0VmZSYTJmZ3orSEdGc0Zp?= =?utf-8?B?eHBBNmlaejJLK056NVMzM21FYWtWOHpLanNSNm91QUhyTTNuSlJ3aG9NZGNn?= =?utf-8?B?bmNzcTRIczZqTkFKVnpEcnl0ck9jbnlHN3BxS2R6T0hycXVjYkVMTHNFWE5t?= =?utf-8?B?eUtlVEJmaExxNXBMZENhbGVYSHplbysvOUJPZDFzZmppYlhGTndCWlMrRWpL?= =?utf-8?B?NmdVbGpBMUNJOXUwVkRZTjJWc0hldGRIcklKR09zSWxFcy80UjBCWWVSZk9i?= =?utf-8?B?bGtWZnNneERIVFBuSlVjSGpLQTZoT0Y3TG1lZkRyYStoUXFvUzFUWnh0ZkVT?= =?utf-8?B?VWNEcWJvNjd2cDRvdlNZMnVHSlAxem1uejNzTlIrcTkvN3A2ZlYrVHZKUU9Q?= =?utf-8?B?Mld3VEZpemxnbU1iajlHUlA3ZWFhOGd1Z1JxOUQ3Z042UlBNV05xUnRSSDBm?= =?utf-8?B?ZVdoenkyMFdKSmorcHNmMjFCMHNkd2dxcUI3STFCaXIzZ1I0WklyYnNqdUFZ?= =?utf-8?B?UUY0a3NzNUFiVDZyQVMyODJlUyt5NTVjRk9oTWFEaVdpYUp5SUFlYVZVQ3ll?= =?utf-8?Q?eK1pnC6yvjFXx6+5fenXDRIoQ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: babb946d-7a03-42bf-fd93-08daf547bd4c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2023 09:22:49.5643 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pgipjtgocTbwMMNNGZGKU2LxI4JUZdRr93ZVsIVeoxFa2JOWMoOOA26Lpf0/5HakLhy/Aj0bM0zmn1Gcbth8HQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7826 On 13.01.2023 00:20, Julien Grall wrote: > On 04/01/2023 10:27, Jan Beulich wrote: >> On 23.12.2022 13:22, Julien Grall wrote: >>> On 22/12/2022 11:12, Jan Beulich wrote: >>>> On 16.12.2022 12:48, Julien Grall wrote: >>>>> --- a/xen/arch/x86/x86_64/entry.S >>>>> +++ b/xen/arch/x86/x86_64/entry.S >>>>> @@ -165,7 +165,24 @@ restore_all_guest: >>>>> and %rsi, %rdi >>>>> and %r9, %rsi >>>>> add %rcx, %rdi >>>>> - add %rcx, %rsi >>>>> + >>>>> + /* >>>>> + * Without a direct map, we have to map first before copying. We only >>>>> + * need to map the guest root table but not the per-CPU root_pgt, >>>>> + * because the latter is still a xenheap page. >>>>> + */ >>>>> + pushq %r9 >>>>> + pushq %rdx >>>>> + pushq %rax >>>>> + pushq %rdi >>>>> + mov %rsi, %rdi >>>>> + shr $PAGE_SHIFT, %rdi >>>>> + callq map_domain_page >>>>> + mov %rax, %rsi >>>>> + popq %rdi >>>>> + /* Stash the pointer for unmapping later. */ >>>>> + pushq %rax >>>>> + >>>>> mov $ROOT_PAGETABLE_FIRST_XEN_SLOT, %ecx >>>>> mov root_table_offset(SH_LINEAR_PT_VIRT_START)*8(%rsi), %r8 >>>>> mov %r8, root_table_offset(SH_LINEAR_PT_VIRT_START)*8(%rdi) >>>>> @@ -177,6 +194,14 @@ restore_all_guest: >>>>> sub $(ROOT_PAGETABLE_FIRST_XEN_SLOT - \ >>>>> ROOT_PAGETABLE_LAST_XEN_SLOT - 1) * 8, %rdi >>>>> rep movsq >>>>> + >>>>> + /* Unmap the page. */ >>>>> + popq %rdi >>>>> + callq unmap_domain_page >>>>> + popq %rax >>>>> + popq %rdx >>>>> + popq %r9 >>>> >>>> While the PUSH/POP are part of what I dislike here, I think this wants >>>> doing differently: Establish a mapping when putting in place a new guest >>>> page table, and use the pointer here. This could be a new per-domain >>>> mapping, to limit its visibility. >>> >>> I have looked at a per-domain approach and this looks way more complex >>> than the few concise lines here (not mentioning the extra amount of >>> memory). >> >> Yes, I do understand that would be a more intrusive change. > > I could be persuaded to look at a more intrusive change if there are a > good reason to do it. To me, at the moment, it mostly seem a matter of > taste. > > So what would we gain from a perdomain mapping? Rather than mapping/unmapping once per hypervisor entry/exit, we'd map just once per context switch. Plus we'd save ugly/fragile assembly code (apart from the push/pop I also dislike C functions being called from assembly which aren't really meant to be called this way: While these two may indeed be unlikely to ever change, any such change comes with the risk of the assembly callers being missed - the compiler won't tell you that e.g. argument types/count don't match parameters anymore). Jan From xen-devel-bounces@lists.xenproject.org Fri Jan 13 09:29:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 09:29:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476949.739409 (Exim 4.92) (envelope-from ) id 1pGGMt-00082c-QS; Fri, 13 Jan 2023 09:28:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476949.739409; Fri, 13 Jan 2023 09:28:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGGMt-00082V-N2; Fri, 13 Jan 2023 09:28:59 +0000 Received: by outflank-mailman (input) for mailman id 476949; Fri, 13 Jan 2023 09:28:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGGMs-00082P-92 for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 09:28:58 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2052.outbound.protection.outlook.com [40.107.6.52]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b41db013-9324-11ed-91b6-6bf2151ebd3b; Fri, 13 Jan 2023 10:28:57 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB7155.eurprd04.prod.outlook.com (2603:10a6:208:194::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.12; Fri, 13 Jan 2023 09:28:55 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Fri, 13 Jan 2023 09:28:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b41db013-9324-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MRPDa3ISoGiwOFJlO2rccatHZIPXoOGTfiWkUfSiaK6x3IQDmF7W/l3xUzN+zCbRAdwmLVEEZl1VcNxvzHEYFJzCDEMBhkfFaWY3R6Je74cuq0vRAite3NmD6VDrJMG4ieIgLp819/9BMCfNfDA8CmJuTDvygejHa1VlHOTYGBU54Y+5hxO4veHdfXeYv6XMlsObqrYXlmV+HBcCcg5sLFkFWrUV40Tt2qTlyz5S8KhPEO7RiTc/M/izWSvjNTU8RIQHUKXOctTQ6lfk+JvsQDS1YCQ46zGl12KBf7yIoLruhVC2lP2QvYaD4r3PNSxW1G0Wo3jjlffENt5EshWxkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r8/yZwUvgzKW7WO3dXhJMiOlt47lC9rB4MQQYCZDUdA=; b=WSCqyVsqdDBDjDW/fYWFR/dcIMs+oDIhwsJuDaaAnOXu7QF87aXhEoHz8GcQtgdt24MlhztUuvjTRsVTmO6R5MKLdTEdkOvKVfDxG+0PNwiT1oAiwjc1DjQ9Vu5VN7JL3isbb1hfp4yeaUig/G02CKABvnr80zjT628Rge7m+h0FhCPZbVKQwazqo3NwNMCQdu1cM3iGqJhq6wXjorThZ81722HQBVQ5q//RBCrOkzdwiLKnbVyE+x+maQIpxZsy3xuAa3WvgaWMZE1VoOw1oB9vLupVNGfoXGYrb1ricFWuNAo4xXR8pkjfevkIzc7TP49CqAQtVKZg7jiwEmobug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r8/yZwUvgzKW7WO3dXhJMiOlt47lC9rB4MQQYCZDUdA=; b=XghSvrbwy5ceTFljK2C4vlLwXziGG9MZtbHdQdqzyn7mpFMdUiKJK6mWsDhWUMjGUap+mkp2B59Rh9qcRjYM9qRXXLrappMpTJPgkBmchwER/wiqeHeZaPahl9PehpwSEkItUKSHEkGnF73Rz9pgXF9oEq6rUVjkBqCa1cvi9P8+fu628bt9CQ/E4OZVbbqVtRFg0L/wTDevd/S28hQGbkTfleagyYMsqpSMJo65MTi7aaLctaMVd2Ew6DZyZvF4IEhoeeEskcvdHowdXbSsOKvSPpNGMXvAjNcToS8ij2R8ydBCT7von44na5JfdtAfpGsAz1ntRaEJGXiG/+r5Fw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 13 Jan 2023 10:28:53 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 00/41] xen/arm: Add Armv8-R64 MPU support to Xen - Part#1 Content-Language: en-US To: Julien Grall Cc: wei.chen@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org, Penny Zheng References: <20230113052914.3845596-1-Penny.Zheng@arm.com> <3e3b8ada-3fb0-2bbf-e6a2-1aea712132e1@xen.org> From: Jan Beulich In-Reply-To: <3e3b8ada-3fb0-2bbf-e6a2-1aea712132e1@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0143.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM0PR04MB7155:EE_ X-MS-Office365-Filtering-Correlation-Id: 943e3125-c8c7-4fb3-898b-08daf548975d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: w3Yd9RZMILvvuQE98swOi1TeSwHTo8jzM3M/7RGqK1SrO0kCThPcrEBkBqRsQc02k7TjfpYFd1h7IdSG05jSucmDdQ+h0h9+auntaUQaCCwvTE1AJUhu2malysSeePEs/8f7qLCRiwk6RcdsmT9zshIZcvYuWCwYeOIo8Wh5FKePs166DvMScUcxyI3EF+en5Fv9+Tzdt+crKUP2RtTmGchdrFWG1MEt7/Pvz3ond2K2xFh0CsymxJfQMPrSi6JAPjNQfwY/TiFVgg1PShwDEwZgn/+s/o52ja7ipghINV4i4vJ+/RJ7sAO533kiSD4mqhe58N+iELw4kH/Q5B0rfqftB1mpLmbKngO+yYAVx3IPwZoxdHbs3daRIpVrkEfWEmeRAfGYRZbPFA89C9dlhL1LfWs153UzrIX7B30B0d0BZgUkYxDj/aXShLk8X1K/P61d2Hbwjf4zKPmGGZdFEPw8iKTk3CZTcPpoZIH34Od9CaygGUSLkteBF9GXCa1REzgs76XQwNO03UVjLD4hecR9cGSKJddgW3gI/ky33BvN94B/ajTArLVj7YQtVWmwbFFnZ0nEAS6f6jXHZ9lNMsJv7I5hD9PzfJXTdkibhfjuvvOiSiqpNEvhDSNlEQhgimhK9yb+dpSFOOQfcEDdn/jdhBrOkSzOjsi2TpX0PSvXPz9YgbGe1AOkxN9+I0yj6w2cXILVJ8mM4w9VKNrZZkX0go5N/J4CXFFYxepLRntANKvSSWiUVRlwYgbk0K8B X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(39860400002)(366004)(396003)(376002)(136003)(451199015)(31686004)(26005)(6486002)(478600001)(54906003)(53546011)(6512007)(186003)(316002)(2616005)(8936002)(8676002)(4326008)(6916009)(66946007)(66556008)(66476007)(41300700001)(6506007)(83380400001)(2906002)(5660300002)(7416002)(31696002)(38100700002)(86362001)(36756003)(17413003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cmp2ZUlHcWJZRDZTZnQxaGM2ZEtsdDhENzBzNHpGWFdBSFgrYUlPUHJNU09t?= =?utf-8?B?dEp5amlGZGY3aG9iZzk1THhydHFrN1F6elR4L2dRQWVTSnVtaHl1cnozUDQ1?= =?utf-8?B?dkl6OFpGRDlTdzJKMkpvajcwR2FNRnpQSjRxaVcwc1V5Z1JtR3lLaDAvRFlG?= =?utf-8?B?VVhyMHNabWtPQlZrVDFlcG1zVVpEUGlWcU8vUlNGbFRyU3V5M2VDK1pxajVD?= =?utf-8?B?R2ZVNTk3b1NCTk5iUWJhN0ZoejJHazhJSnpZdnE5V1RLUE1nbmNQMThXMXdF?= =?utf-8?B?MUUwaUhrVGhONDFva0toRlVaM0cxRnNPTDRoZFU2MFVxMHR2SUtmOWJML1VD?= =?utf-8?B?ZmphUjlnVTNJby8xU2Q4a1dUaFBlVVZWRVRQTHVCL1BTUjdqM1pXTHgraVQr?= =?utf-8?B?SjdYYk10UWEvY004OVd3d1lVZVAyUjhMbElyVGlhT1lHSEREV09vTjNGWStZ?= =?utf-8?B?KzgybVJ1RTd6eGk5enpQUmYwTGF1TzRtVVdpeGdmUVNrNGVMV3B4U295Ry9M?= =?utf-8?B?dDVXbkEvbkJMRHBpeTJNR3ZJWnBLaGliS3ZmM2Y4QnlYZkt6WmVRYXhkSTgx?= =?utf-8?B?L2RNTTZRNFZlcGJydHA4T1pqRDJGd3ljNUl6TFFPMXVSNGlxd0NiZXVtZzNN?= =?utf-8?B?eElwZFJ6Y0RMVEZpVXRocUZiME9TM2p4Q1IxMU94V3RwSGVJWDJyRFJIMUZT?= =?utf-8?B?ci95ajJFWkI4cWJpeWhPcFg3aHpua1RiL2drQzFwYWxDQXJ1UythdFpkenV4?= =?utf-8?B?NUY3WVBkRVh3Vzd5dVRGMHNqTGwzYnJSUHZOOXozZGU0VTIxYzhQeEJ0OVov?= =?utf-8?B?SmRhS2NCWkFheTQ2MHRISStxYkJTZGlXQVhzcWtESjJneU1JZDVrVmRTSWZq?= =?utf-8?B?ZzAvZUdiLzVjcVVqRkJMdjlJa3IreFh3ZjJmM04zZFh4cXFXczlNbFRYL2ow?= =?utf-8?B?RXNjOFptQ0VReHYvaTBLLzhxL1IyNjBtdHE3VWE2b3BmOGlCRW5EUkJzSzk1?= =?utf-8?B?czBaeUF0SjJWd0xMZnZkSzhPenRwcDNzbk1LSWxNSG12bEpCbXp2QkQyQkk2?= =?utf-8?B?RkpMbTNGNVYwRzBCdThmZ0FIanAxQWZiYjhkREpEbXRJQnFCd0ZoWmhVZ1V5?= =?utf-8?B?d3docHRpdWdldDlleWYrUFNiMENyaHFNWHdxYUd1Zkh6Z2ROQ1pSNGtFeVI0?= =?utf-8?B?SnhZRWVPN1prM1k0UkNkaUlXbkNrejJFV3Iwa25QMDlNeU5NYjh1OEpHL2th?= =?utf-8?B?SkJuZWlmWUpaZ1Y2ZkFYNDl4VWZJY3ZBK2gwSVZ1em5Ga2E3eGx0Q1l4MDc0?= =?utf-8?B?Z0s5dm1HbWNvSElienV4VXhaKzU4QzZLeEg4dEhUcnJNU1lkY0VaVk1rR2F3?= =?utf-8?B?MVcvS1AzNFkvU0ZaS1VUaFQrM2hxRHpVSjZ5NEEzeGVqeXlvQjJmd29hSThW?= =?utf-8?B?QVVtK1RjRzRDUFhnbHpnY1BCSndxSWNGR3JYYUpkeitNYjFCRmpzRTE4c0VO?= =?utf-8?B?NWRaRG9IVm5qMUpjSXdCcHFRS3N2aEV6Q0Q1OGpTdEtsalVWK05hMytHTEpN?= =?utf-8?B?OUJNWENMNENhaS9XblpxT3dRSDU3L0NzL1NGOGFpNHRtY3ZsUTVEUjdGWlg0?= =?utf-8?B?UTVPMWljdGQ1Rk9XdDVLMno1UFY4LzZXQmV5RWcvLzREdWpDMVdnRTZ0WjNR?= =?utf-8?B?aFlGamprWDJqWDd0WmovQ2FqYVk3bWZTaG56azVudEFtdkhwK25FQWlETk9n?= =?utf-8?B?SXdtY01SQkJXRHg5L1ltRjZwTnVwSUxxMlNFWnUxMzlWMW5PZng3enlSR2RX?= =?utf-8?B?Q2l2VDN5WDR4RjNYTktSbDBDMlRwUG1NK2JQd252aFFKanpzcmxmQUp5Mzhu?= =?utf-8?B?VnBzRlJKN1RmWXhHWlVuTXNLR25XMDUzN3p4SlFlU0lwQkdlM3M5WGU0T3RW?= =?utf-8?B?aEZLK1hFODlHRm1qUUVmQmZ0SzlxL09qSHR2cjRCQ2ZmTzR0amQycEExT3pi?= =?utf-8?B?aVFGN25GT1hsNVk4WkRJclIvbko1UE1ielZaTmhtYlVYV0QyeUYrUUNSQVl1?= =?utf-8?B?VG1oMzJQVjRRMjYxVWdsVmFteGxnRFlsY0VLbzY3R0hYb1owbTRRSjVkRGhr?= =?utf-8?Q?uXyMZear+2BwLfdsLWgUabwKk?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 943e3125-c8c7-4fb3-898b-08daf548975d X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2023 09:28:55.3849 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pN3GRhbfAMkYSp84rKi/iFne+zbFApvDDAIU7U5oY/XvTnxVPG0vc7ns88U8ror8W/CM2aO9ZLk9viAM4Pknaw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7155 On 13.01.2023 10:16, Julien Grall wrote: > On 13/01/2023 08:54, Jan Beulich wrote: >> On 13.01.2023 06:28, Penny Zheng wrote: >>> xen/arch/x86/Kconfig | 1 + >>> xen/common/Kconfig | 6 + >>> xen/common/Makefile | 2 +- >>> xen/include/xen/vmap.h | 93 +- >> >> I would like to take a look at these non-Arm changes, but I view it as not >> very reasonable to wade through 40 patches just to find those changes. > > Right, but that's the purpose of the different CC list on each patch. > AFAICT, Penny respected that and you should have been CC to the three > patches (#30, #31, #32) touching common/x86 code. Right, but I have no way to immediately see which patches I have been Cc-ed on. Unlike you (iiuc) I'm subscribed to the list, and hence mails all look the same whether or not I'm CC-ed. Then again I only now realize that there are ways to filter what I've got - I'm sorry for not having thought of this earlier. >> The >> titles don't look to help in that either. For such pretty large series, >> could you please help non-Arm folks by pointing out in some way where the >> non-Arm changes actually are? > > See above. I am not entirely sure what else you are requested here. Do > you want Penny to be explicit and list the patch modified in the cover > letter? For a large series mostly touching Arm code, calling out the "outliers" (when patch titles don't make this clear) could certainly help. It's not like I'm asking to do such everywhere. Jan From xen-devel-bounces@lists.xenproject.org Fri Jan 13 09:33:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 09:33:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476956.739420 (Exim 4.92) (envelope-from ) id 1pGGR4-00013q-F5; Fri, 13 Jan 2023 09:33:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476956.739420; Fri, 13 Jan 2023 09:33:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGGR4-00013j-BC; Fri, 13 Jan 2023 09:33:18 +0000 Received: by outflank-mailman (input) for mailman id 476956; Fri, 13 Jan 2023 09:33:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGGR3-00013d-1h for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 09:33:17 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4def6a57-9325-11ed-91b6-6bf2151ebd3b; Fri, 13 Jan 2023 10:33:15 +0100 (CET) Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-144-PhUiYbgXPaKVDQegHcb74Q-1; Fri, 13 Jan 2023 04:33:13 -0500 Received: by mail-ej1-f71.google.com with SMTP id sd1-20020a1709076e0100b00810be49e7afso14985849ejc.22 for ; Fri, 13 Jan 2023 01:33:13 -0800 (PST) Received: from imammedo.users.ipa.redhat.com (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id a17-20020a170906369100b007c0f2c4cdffsm8257387ejc.44.2023.01.13.01.33.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jan 2023 01:33:11 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4def6a57-9325-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673602394; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EGmXSGcryLyMwWBJBAGRPqNc83FeWcTOUw9/1eaT3RA=; b=fnz3gJuqJqcOzEh4EGw3XDs0F+yCs2Hg+zkDZpnGQlO9Rin9cXyIdONpZ46JgJ9KecAIpw SOrb1V0YncpCtxHbsK5wtKQKhzRQUB/jkW9QAmqU9yea9QqBU7z44yRfPImc4/heXETYMU 9k/eSkDRSz0lBoEyv5Dpt/KQ6NduaTE= X-MC-Unique: PhUiYbgXPaKVDQegHcb74Q-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EGmXSGcryLyMwWBJBAGRPqNc83FeWcTOUw9/1eaT3RA=; b=yJIrt3mBMcYRxDTT+v6KVW5WLROf6CBHPLfAs310hZ9lxEMyhHk55NJlLEPf3G8DZt reIy2devi7mxN3D66fiSeYaibDTCLkQKqB2e+Qnnxrx6sx25b5CnyssJygc4V/dgvtgF n9+k2AuNbUXjHBOyefwaEXueaT25H0DswN1x6/WVMrgjnNrJZQWbEEuGcPM0V0PeC8YD abI86OvcPRbjh9eWItsyvTB5vFpzEFXWteePmg0jYtMiyEgnlbopxMNk5cLjPzkHLDHO IFqhPKblVV2yso7uez3giVr3Z//V5LdVbvXSZnGeUDnzmYX9qZ3KmxeK8k3Ye/u+KiPo viAw== X-Gm-Message-State: AFqh2krAORvoTMaFNeEOnbHDhbokJeR8Zb/2zR5Ro+XhuuRXdvB64+vd ThEtDjuJz5NWokmixD6FZ9CmM8125eUxpjR33SkFjl/0Bths72q1MDQaVWnvaPBXQxRRuKIWKLg DLeQruwkx/szoHbwJ9jtM0F1apiw= X-Received: by 2002:a17:906:6d14:b0:7c1:765:9cfc with SMTP id m20-20020a1709066d1400b007c107659cfcmr2434449ejr.34.1673602392309; Fri, 13 Jan 2023 01:33:12 -0800 (PST) X-Google-Smtp-Source: AMrXdXvMyiZunNV7hT53Eb0xO5saoqrfpCr+V6WcY8sAbjY0cHEl4y6/dAWivhbcVBq6Aq75LiToFA== X-Received: by 2002:a17:906:6d14:b0:7c1:765:9cfc with SMTP id m20-20020a1709066d1400b007c107659cfcmr2434437ejr.34.1673602392137; Fri, 13 Jan 2023 01:33:12 -0800 (PST) Date: Fri, 13 Jan 2023 10:33:10 +0100 From: Igor Mammedov To: Chuck Zmudzinski Cc: "Michael S. Tsirkin" , Bernhard Beschow , qemu-devel@nongnu.org, Stefano Stabellini , Anthony Perard , Paul Durrant , Paolo Bonzini , Richard Henderson , Eduardo Habkost , Marcel Apfelbaum , xen-devel@lists.xenproject.org, Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= Subject: Re: [PATCH v8] xen/pt: reserve PCI slot 2 for Intel igd-passthru Message-ID: <20230113103310.3da703ab@imammedo.users.ipa.redhat.com> In-Reply-To: <128d8ee2-8ee9-0a76-10de-af4c1b364179@aol.com> References: <20230110030331-mutt-send-email-mst@kernel.org> <9f63e7a6-e434-64b4-f082-7f5a0ab8d5bf@aol.com> <7208A064-2A25-4DBB-BF19-6797E96AB00C@gmail.com> <20230112180314-mutt-send-email-mst@kernel.org> <128d8ee2-8ee9-0a76-10de-af4c1b364179@aol.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.36; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thu, 12 Jan 2023 23:14:26 -0500 Chuck Zmudzinski wrote: > On 1/12/23 6:03=E2=80=AFPM, Michael S. Tsirkin wrote: > > On Thu, Jan 12, 2023 at 10:55:25PM +0000, Bernhard Beschow wrote: =20 > >> I think the change Michael suggests is very minimalistic: Move the if > >> condition around xen_igd_reserve_slot() into the function itself and > >> always call it there unconditionally -- basically turning three lines > >> into one. Since xen_igd_reserve_slot() seems very problem specific, > >> Michael further suggests to rename it to something more general. All > >> in all no big changes required. =20 > >=20 > > yes, exactly. > > =20 >=20 > OK, got it. I can do that along with the other suggestions. have you considered instead of reservation, putting a slot check in device = model and if it's intel igd being passed through, fail at realize time if it can= 't take required slot (with a error directing user to fix command line)? That could be less complicated than dealing with slot reservations at the c= ost of being less convenient. >=20 > Thanks. >=20 From xen-devel-bounces@lists.xenproject.org Fri Jan 13 09:34:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 09:34:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476962.739430 (Exim 4.92) (envelope-from ) id 1pGGSY-0001dD-Oc; Fri, 13 Jan 2023 09:34:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476962.739430; Fri, 13 Jan 2023 09:34:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGGSY-0001d6-Lb; Fri, 13 Jan 2023 09:34:50 +0000 Received: by outflank-mailman (input) for mailman id 476962; Fri, 13 Jan 2023 09:34:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGGSW-0001d0-Q7 for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 09:34:48 +0000 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [2a00:1450:4864:20::635]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 852c210c-9325-11ed-91b6-6bf2151ebd3b; Fri, 13 Jan 2023 10:34:47 +0100 (CET) Received: by mail-ej1-x635.google.com with SMTP id fy8so50835968ejc.13 for ; Fri, 13 Jan 2023 01:34:47 -0800 (PST) Received: from [192.168.1.93] (adsl-67.109.242.138.tellas.gr. [109.242.138.67]) by smtp.gmail.com with ESMTPSA id ov38-20020a170906fc2600b0084d4733c428sm5870772ejb.88.2023.01.13.01.34.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Jan 2023 01:34:46 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 852c210c-9325-11ed-91b6-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+agMQNymtgBfMwDGibkZkEB7lupOmqeMBhkfaRI7Ro4=; b=e1QOtJbRjfxEFvoY4KnO0q5mrF5qA8udxXmHK2i8t9M4dOP0LQX7VK9l9xdcOf0fD+ skKyYdLFKuBzEcYJ4nwliNX+YIGT+LmbBaKlYu5whuxlUdjLT5tegqpuNJfvjtTG7hPx XnO+2FzRnLrwCVksWo58A47lFAQPjYXCi1JCOX4GmWioztMFFa38Px0R1XS6pEccGURu 86PlEDwotJc+lZi8Wm8GpafiWb0GaSPHCV435FPE/k0mdQIF2raCo12KZgEB9x2gsF+i xZLYrdB9C2bThrBg4O+LbvLjE7Z46MBeMfypcDVfO74hCGE02r2oim1o5AdBNNQ5JaIK P0Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+agMQNymtgBfMwDGibkZkEB7lupOmqeMBhkfaRI7Ro4=; b=pp0r0zQpW/fuJx3sDdrln0oBQDtue3g+evXMxH6qM/LZTCMfpRurc+BT4yd7cZvO4v D58lRaNuNp+Kp3rKVz7ghBAK+9doZ7yZcwbbGoEAoD/7bEkt79eTh+7OjfYEnpE6JkQ/ AOjeFGtIIzEB4rBPybgB5marrGt+HVEm4IgPLQCfVLbR6KSksc7RZrPjUJxfykbAmlg7 ASXNedozR7Gv6RwNOF/QvpPJ8qN99yQa+hCcbHCiNsOJQCB/7OeBTkB6c/WOqEeHuKGd bDIM1Y0J+Zal8xBjseV3V6K09GVfX9S6YkZ4isxSToy7Y7ONDsP6SYNvl08uLWkPEfTl Ykqg== X-Gm-Message-State: AFqh2krX6nom1NMqjywaWoTLuDLVK7vydmtsCzh5jKePkjCTUqqw5hVx 65jauFMuWoDrqoF1IAHmt+A= X-Google-Smtp-Source: AMrXdXuOjo1cGolaL56+vHwOmKnnQ9tDwGxUhDqTHAdUMJEPNBcM18KjiJpXT20G0tmUFgXtdPF9BQ== X-Received: by 2002:a17:907:a705:b0:7bd:ece7:ae66 with SMTP id vw5-20020a170907a70500b007bdece7ae66mr74161558ejc.34.1673602487151; Fri, 13 Jan 2023 01:34:47 -0800 (PST) Message-ID: <6596d648-6400-7907-bc21-8074dc244247@gmail.com> Date: Fri, 13 Jan 2023 11:34:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 1/2] x86/shadow: sanitize iommu_snoop usage Content-Language: en-US To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Tim Deegan , George Dunlap References: <01756703-efc8-e342-295c-a40a286ad5f1@suse.com> From: Xenia Ragiadakou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/13/23 10:47, Jan Beulich wrote: > First of all the variable is meaningful only when an IOMMU is in use for > a guest. Qualify the check accordingly, like done elsewhere. Furthermore > the controlling command line option is supposed to take effect on VT-d > only. Since command line parsing happens before we know whether we're > going to use VT-d, force the variable back to set when instead running > with AMD IOMMU(s). > > Signed-off-by: Jan Beulich > --- > I was first considering to add the extra check to the outermost > enclosing if(), but I guess that would break the (questionable) case of > assigning MMIO ranges directly by address. The way it's done now also > better fits the existing checks, in particular the ones in p2m-ept.c. > > Note that the #ifndef is put there in anticipation of iommu_snoop > becoming a #define when !IOMMU_INTEL (see > https://lists.xen.org/archives/html/xen-devel/2023-01/msg00103.html > and replies). > > In _sh_propagate() I'm further puzzled: The iomem_access_permitted() > certainly suggests very bad things could happen if it returned false > (i.e. in the implicit "else" case). The assumption looks to be that no > bad "target_mfn" can make it there. But overall things might end up > looking more sane (and being cheaper) when simply using "mmio_mfn" > instead. > > --- a/xen/arch/x86/mm/shadow/multi.c > +++ b/xen/arch/x86/mm/shadow/multi.c > @@ -571,7 +571,7 @@ _sh_propagate(struct vcpu *v, > gfn_to_paddr(target_gfn), > mfn_to_maddr(target_mfn), > X86_MT_UC); > - else if ( iommu_snoop ) > + else if ( is_iommu_enabled(d) && iommu_snoop ) > sflags |= pat_type_2_pte_flags(X86_MT_WB); > else > sflags |= get_pat_flags(v, > --- a/xen/drivers/passthrough/x86/iommu.c > +++ b/xen/drivers/passthrough/x86/iommu.c > @@ -56,6 +56,13 @@ void __init acpi_iommu_init(void) > if ( !acpi_disabled ) > { > ret = acpi_dmar_init(); > + > +#ifndef iommu_snoop > + /* A command line override for snoop control affects VT-d only. */ > + if ( ret ) > + iommu_snoop = true; > +#endif > + Why here iommu_snoop is forced when iommu is not enabled? This change is confusing because later on, in iommu_setup, iommu_snoop will be set to false in the case of !iommu_enabled. > if ( ret == -ENODEV ) > ret = acpi_ivrs_init(); > } > -- Xenia From xen-devel-bounces@lists.xenproject.org Fri Jan 13 09:40:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 09:40:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476968.739442 (Exim 4.92) (envelope-from ) id 1pGGXU-0002HG-AU; Fri, 13 Jan 2023 09:39:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476968.739442; Fri, 13 Jan 2023 09:39:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGGXU-0002H9-7W; Fri, 13 Jan 2023 09:39:56 +0000 Received: by outflank-mailman (input) for mailman id 476968; Fri, 13 Jan 2023 09:39:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGGXS-0002H3-Ak for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 09:39:54 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2068.outbound.protection.outlook.com [40.107.22.68]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3a84e663-9326-11ed-b8d0-410ff93cb8f0; Fri, 13 Jan 2023 10:39:52 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB6836.eurprd04.prod.outlook.com (2603:10a6:208:187::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Fri, 13 Jan 2023 09:39:50 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Fri, 13 Jan 2023 09:39:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3a84e663-9326-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y8VLkJpbQS5VMt4rLubAdEWvi8g2Q8uTMdKyQM6UiFi4t9wO83JUowhX145in+cXWfSek1snOzvCGJi0tgMRqaJajlOQZLj0jcjynbVgZm1e+dtTE/GtlT2UHndqiinB+bqtQdezd8Dc1QznUsUvEPdCrvsdNWU1mLY7ZteqAmDTQmLkD5rJIuRemHBSza8/ExEzZz2OazmiCOKoufp1QjaWP6Niz0U6lqpjeXppMNYsddSIiSKf/fajz4aVadIYUuTDy3Ouf6SvCnL1Yp1c2wXXXLhTqbXQeYwERYfZpcaD8st25oecp/9p6ncpQsNLFI754OIRwjmfqeN8tHK3sw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0PvwRsuGbDTMrLZH4ThkVMgO5KX/PDF4NeJItln5ucw=; b=TkDkZWfRnGk4ncp5zGaIfZEgivl/XS3FyxTc8EWwfydlSgDS1XGKLUTEcOEY7aH6YaCV7LpH+xTd7ACitY9ClkrFVN8naqJi2aGO4KMfVxlGFmvqBRD19blH2dGsqIcypmSevalarhf/VAx9i2y0J4zuT5SG7hWTznLMHpy78LNF4czCRSnXbDPReVkRsnTmcOfxHEYHszrLjfnLhyn2H3SnkoxDIUkSg5wMSw0GxuTuGIF3i1uVOHyL+piJ1u24pDLdWPMK0MhVWl43bffESMwFGl/Usxl3kYAvhzBV0mc58R+lt4w8GoFwSYkH2wzOYQwgfUwWY5dT76byJEdsxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0PvwRsuGbDTMrLZH4ThkVMgO5KX/PDF4NeJItln5ucw=; b=O7vLUuSIFbMCUQm6CKj6SrpF/p4OYbnnlYgKbPha3xZU0vw8muyK4l1BbpV+0+RvJHWWVq/9dx6fo5hp7zM1MkNkGl1JtHz63jRhN0MfMAcrjYjO4mWN1qsRLrvC+9Y64zGq0Mx4lWJYuPeigXy8wfO5VAftU5lVPaUh676qruZ1yroKwTeq8vDwc3pyjDd1kWjyLNhiKbYD3g4debn8Dsx5Sad9ZR9PFzZpGP7IStD+k8NbEthIamgwF2v+fTkW3UFU5yFBqXKh3SAiw/9i8saJD0dxA4EG2zB0M869HC3t/kzzEkI3OMr2GMSrn9PQcbq4Pw2I+CVkJ7iBH4Xh3w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <07e1099b-8ef8-d28d-f46d-561ec27cab02@suse.com> Date: Fri, 13 Jan 2023 10:39:48 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 30/40] xen/mpu: disable VMAP sub-system for MPU systems Content-Language: en-US To: Penny Zheng Cc: wei.chen@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20230113052914.3845596-1-Penny.Zheng@arm.com> <20230113052914.3845596-31-Penny.Zheng@arm.com> From: Jan Beulich In-Reply-To: <20230113052914.3845596-31-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0138.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9e::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM0PR04MB6836:EE_ X-MS-Office365-Filtering-Correlation-Id: 19b8f678-3657-42b9-90c6-08daf54a1dce X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QVaQOVkS+ZCqDJ20XBfdhWTSjWCZKId51T2mVxZ0XGJfxVZ0paSTLwe1rKmuI3+xKSz4WTqGQiC+R8EP8c1f2IgIOniE9IdnkhHZAAL11+DaEeKWcAcWex+UVuI2OJ2YFU1+9d8o2tOu3GJy75ZuBIkvY/T/iuxrPHDw3KA1adJ4UFqhanT1ghJ+JOOItE37+ErTjDQD0JpPbaL58oMwh8VKBKkUfDnwMFOcL9w2T/6shNC/0vDB3Fnb0mHp3MbkVISHTVcdVDLIyfS1YeIfON3yBXfOigc6rjl5GQ+qxn+j77XJ4S8u4jdZLJPYyDJCP9YEkVrwq7fXb2ORz3hp/4awqkEVti5Y36kJe7MAXUmLe2a214NNDjEzuMWP4LXGBhi5FPA/ICeVzRNbSnGJ5usP4Y4EfetGZOnlG897eKGgweTiKUNFuWRCT5mS+nTS/GyXwlbZleRGOPF/HUI8JRvDxp3pjF2J76AV4xMuWEomD5dxMU2VN9rFJhX7YZ1upcsYd+zbqjeBjVy1bUjXltkg9jkJyiiMOowXiXw2KVoOEhGs3PyWWwhIiEs6xAAABFgrpdFiMvDfZIdkZU+rsB5v2FcwTJ8VswYVDcAqPhosp8UYJeAZSvkI3auQP3v7/CTI6alwIT6QAae9antItGyFqXEWYZDnS7bfzK2N+R+cjDZ+6wX+pE7MVvcB83q7J8qqHV4ODA8qtudXXWYSCX1+7fCVvW9QUH4EJA7DXmA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(346002)(39860400002)(366004)(136003)(396003)(451199015)(26005)(2616005)(83380400001)(86362001)(38100700002)(36756003)(31696002)(31686004)(66556008)(54906003)(6916009)(2906002)(8936002)(4326008)(8676002)(5660300002)(7416002)(53546011)(66476007)(66946007)(316002)(6512007)(478600001)(41300700001)(6486002)(186003)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YlpnVEx3SHFuYWZNcFBSejJsSyszcUxkRmZwbENubEJLYytHek5yVDkzb3pR?= =?utf-8?B?Qk5WU0p3cmFkUElkelR1T1g2SW95NzhybTR5YitvMEpCR1o1MmZnR3NnMUQ2?= =?utf-8?B?ZkVTRXl3dWtKNG53RlBNeGRubHV6bWlvd3g4U1JHV0ZDZjU5V0JHelpTenRU?= =?utf-8?B?b21MSEdpWXhvMm5DVFVCd2VBRkt2U0taQXpCRHRQUk9wK0FCbHdSSFB2WXh2?= =?utf-8?B?Y3cwSjFqTTZkenlXV3BRdjlVMVhMQ2xmbzRRZ25QRWlIaDh1bnUwbFNobG1x?= =?utf-8?B?dEZDcWxjM1FwcUNpTUd2c0pLUitpenZwTDVHVnFWUjJPRUk3UHVsOWZ6eUto?= =?utf-8?B?ODFVYTFQOTZmazJrN1VuOFVES3ZGQlUra0UrdHJ2VitnTzZKclRBc1IxOC83?= =?utf-8?B?MVI1U2c2OWw2cGR6QVBuRy9nSG5uV0Z4NjZST3pwMTVYQ1pFUWQ2Ri9lMXFv?= =?utf-8?B?aXgyQ2pKNDUvWGxXMWxXZ1VoTXNUY0JSdlAxZDBJY2UyVVpiOUVPTVBQVGJn?= =?utf-8?B?bkYxZ1pDenpCVERjc25EVm9qUlVyU0Iwem1sdHNMTURyRVdWd3M5SE83d0ZK?= =?utf-8?B?SDVyUnRuNkRubjgvMVdEczNrZitkUUJqT3FiL2sxbldrc29aTHpmRi9yeWlR?= =?utf-8?B?c0hLbm1hMTk4dE4wekw2OUxjeWxMcEJvR2VSZlpjY1pHNDFhT0dPdlZnVmYx?= =?utf-8?B?RjdRVHltVC9vanNTdmFGTzRSNzhLYXFleU40WEttS0t3VGY4dWZwQVhOV2xN?= =?utf-8?B?WGIwcFljQVFpb2o4b0FmaElGMW1zb3YrVmZNemluZXZST0hhZ2xVbUdITUs1?= =?utf-8?B?WWlLYlNXcnV5ZzNpOHA2NVZudXJGY3JFd05obXpaZUVFbG9yV1dldWJCNEdp?= =?utf-8?B?SW1ORE1nZHUzVnVtR2lEZkdseTRiTGlRWDVSTUpvWk91aForaTRyVHhma2lD?= =?utf-8?B?VjhtTW42Ymo0WlR1Yzl1ZTVFOG9RRjBxZ3B5Yk9NOWwzN3B2WjJydGR1N29n?= =?utf-8?B?RUlBRFhVakliaXZyam5MWTJoc0dOcW9NY05YeWsvUW9oNDVaQUFaV3M0MTFV?= =?utf-8?B?a2pkT1gzVERSOXQ2Wi9GWFRBYmZ1ZlJTZWp1Rmg2TDJxeFlVaFdiZVgrVFAx?= =?utf-8?B?WjBoQXFWQllxcmszbUx4QVRGYm9McUpOektQZTJBK3BtWGM0NERvQzd1U0dj?= =?utf-8?B?RU0yb2dkK1lBZjk3bjRNdUsrcVE5OU9JSE1YamJEUXFuUC9pSXpFTG9yU2wv?= =?utf-8?B?S0pDU3FiOStyZ3F6WE9kM3NxZ0JaWnNKUU1OL2Y5d0V1VWN3S2daVXpWK1dS?= =?utf-8?B?VFNlYnhCQXA1MFdFU0xLZHF6VDU4ME4vemRQS29ZN2MybXl3OWRhKy9kVmZ6?= =?utf-8?B?dGVTSUVPUDgxY2R1b05OcEFNYjM0dE16N01sYVVLdWVqcEJZelNwKyt6ekZx?= =?utf-8?B?MjJUNitGT1E2UStaK282V1VTZHlVejlabHVJb2dhRnFlU2dxQ2phMzJZS0ow?= =?utf-8?B?VmVHa0U2T0x4Q3hMbDB3S2x6MVFuVlYxS2hIYnNPckh6TWJBemt6NCt4RXZi?= =?utf-8?B?aG5DbFM2WHlUS3F4RFlQcTZPQlAxVGUxaWYvbHZ3c2oyb3ZmYXZuaTBoOWw1?= =?utf-8?B?NVZRaU5XcFl4dkJreVhCRmd0NXgzQWV3NTB2cHQyeHgrUnQ5Tk5mS0JUbUhn?= =?utf-8?B?L04ydzdsNG1ldkNpZ2pZbkFHYzhmaFc2MVowazlFSG5SY2NjL3ZIV1BjZFdv?= =?utf-8?B?aENuMlI3YWd5VnNmUm5KSXFqNjBhR0R3NllhbnFzQVp0T0N1R3FLMGZnUDg1?= =?utf-8?B?U0p4QkpjZ1BOQjlJblpmWUVJeFhua3lSSHZZSWp2MzVtU2NHOEQvKzV6VXNl?= =?utf-8?B?QllabGdZN2M3czB5V3E5eTd0VHFLdklOdTJBOHh2UktMRXF5Wmhmd1ZOeDVw?= =?utf-8?B?R1F5aWMybFBMaThlWmF3d1VpUHlNWEF3ek90bHdkZTAwNUYrSEtGN3ZiV2Qr?= =?utf-8?B?dlp4Y2IzOXNNTEVJMnhQa0tzeG9HWHhPM3l1TGVtL3FxWVBhRVgzWmJIVkFz?= =?utf-8?B?UWlxdkcyYTl6V0l3VVhPeU55dXV2Qm1BdXc1Q3hOQVNTLzRIUTZpSTBxdVdG?= =?utf-8?Q?KAfW7SFvVd2bbDDBLtidBe1Jb?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 19b8f678-3657-42b9-90c6-08daf54a1dce X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2023 09:39:50.4683 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eKIfxsw6I/3a6tjRrPFxexoLZ6sfwMRc6fxanfBt2aDpJhR2QbhCCizFWcqAcv/i6Gjczh8JZTbtXEMD79yLdg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6836 On 13.01.2023 06:29, Penny Zheng wrote: > VMAP in MMU system, is used to remap a range of normal memory > or device memory to another virtual address with new attributes > for specific purpose, like ALTERNATIVE feature. Since there is > no virtual address translation support in MPU system, we can > not support VMAP in MPU system. > > So in this patch, we disable VMAP for MPU systems, and some > features depending on VMAP also need to be disabled at the same > time, Like ALTERNATIVE, CPU ERRATA. > > Signed-off-by: Penny Zheng > Signed-off-by: Wei Chen > --- > xen/arch/arm/Kconfig | 3 +- > xen/arch/arm/Makefile | 2 +- > xen/arch/arm/include/asm/alternative.h | 15 +++++ > xen/arch/arm/include/asm/cpuerrata.h | 12 ++++ > xen/arch/arm/setup.c | 7 +++ > xen/arch/x86/Kconfig | 1 + > xen/common/Kconfig | 3 + > xen/common/Makefile | 2 +- > xen/include/xen/vmap.h | 81 ++++++++++++++++++++++++-- > 9 files changed, 119 insertions(+), 7 deletions(-) > > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig > index c6b6b612d1..9230c8b885 100644 > --- a/xen/arch/arm/Kconfig > +++ b/xen/arch/arm/Kconfig > @@ -11,12 +11,13 @@ config ARM_64 > > config ARM > def_bool y > - select HAS_ALTERNATIVE > + select HAS_ALTERNATIVE if !ARM_V8R Judging from the connection you make in the description, I think this wants to be "if HAS_VMAP". > select HAS_DEVICE_TREE > select HAS_PASSTHROUGH > select HAS_PDX > select HAS_PMAP > select IOMMU_FORCE_PT_SHARE > + select HAS_VMAP if !ARM_V8R I think entries here are intended to be sorted alphabetically. > --- a/xen/arch/x86/Kconfig > +++ b/xen/arch/x86/Kconfig > @@ -28,6 +28,7 @@ config X86 > select HAS_UBSAN > select HAS_VPCI if HVM > select NEEDS_LIBELF > + select HAS_VMAP Here they are certainly meant to be. > --- a/xen/include/xen/vmap.h > +++ b/xen/include/xen/vmap.h > @@ -1,15 +1,17 @@ > -#if !defined(__XEN_VMAP_H__) && defined(VMAP_VIRT_START) > +#if !defined(__XEN_VMAP_H__) && (defined(VMAP_VIRT_START) || !defined(CONFIG_HAS_VMAP)) > #define __XEN_VMAP_H__ > > -#include > -#include > - > enum vmap_region { > VMAP_DEFAULT, > VMAP_XEN, > VMAP_REGION_NR, > }; > > +#ifdef CONFIG_HAS_VMAP > + > +#include > +#include > + > void vm_init_type(enum vmap_region type, void *start, void *end); > > void *__vmap(const mfn_t *mfn, unsigned int granularity, unsigned int nr, > @@ -38,4 +40,75 @@ static inline void vm_init(void) > vm_init_type(VMAP_DEFAULT, (void *)VMAP_VIRT_START, arch_vmap_virt_end()); > } > > +#else /* !CONFIG_HAS_VMAP */ > + > +static inline void vm_init_type(enum vmap_region type, void *start, void *end) > +{ > + ASSERT_UNREACHABLE(); > +} Do you really need this and all other inline stubs? Imo the goal ought to be to have as few of them as possible: The one above won't be referenced if you further make LIVEPATCH depend on HAS_VMAP (which I think you need to do anyway), and the only other call to the function is visible in context above (i.e. won't be used either when !HAS_VMAP). In other cases merely having a declaration (but no definition) may be sufficient, as the compiler may be able to eliminate calls. Jan From xen-devel-bounces@lists.xenproject.org Fri Jan 13 09:42:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 09:42:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476974.739453 (Exim 4.92) (envelope-from ) id 1pGGa2-0003d9-PM; Fri, 13 Jan 2023 09:42:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476974.739453; Fri, 13 Jan 2023 09:42:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGGa2-0003d2-MU; Fri, 13 Jan 2023 09:42:34 +0000 Received: by outflank-mailman (input) for mailman id 476974; Fri, 13 Jan 2023 09:42:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGGa1-0003cr-Sc for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 09:42:33 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2073.outbound.protection.outlook.com [40.107.21.73]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 99c56c86-9326-11ed-91b6-6bf2151ebd3b; Fri, 13 Jan 2023 10:42:32 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBAPR04MB7272.eurprd04.prod.outlook.com (2603:10a6:10:1ad::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Fri, 13 Jan 2023 09:42:29 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Fri, 13 Jan 2023 09:42:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 99c56c86-9326-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ds3NeXKz9VXUsFz17yg0jYGOkPVskcl59FynZkvcZ/fQVTISzOd9weUUMCRJoq6TT7AqCubz2GvhEcEPbCIpZVFxjAQCdjMd7auuLgHEZ6PGqBzOA8fid6rZ4RKMAiULSQMuOHbxOl8zhTTOMTWdSJ9sMe7kSUTZzxReGhv18ExCkCXjzl45PKiDQHMGcajVcyypuwEokqFvVO+3Xe8r9XDHl48ntfFT+N0D5uPpck/HpwAjQLyGH1KAS+qhEh4XG2K7n5m+sUjLAczZHniX6bPFWUUs/sMX7zdobutfyz3kYDQgWDwx3vUhPyEYliB9HxBaulB3dNia8I6FUYjazQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=i8PbSMIbGKpH21HZ7bfJ+tO2egH7QQ3j4iBGi/uT6tA=; b=Hhz1rXZu9gMkL6NAfYskxS8LfCUslshOme8dIAN05NKqP7sxye7r3poTHl8Ubdnq0SEdnxVuSG9tNl78vhUZ3E0qbhZ7d16QNCXPMj5A6ReTkZz1ZmXeCmeHiPKTjUNbOE5HyZIb1fPwSTzXRdICbCFKEjHTrlHp2cWIilkH8wV9ELwPN+vO9DNYhp2+5sNRSldZi+vhKORZHWtsF1ArjTdwMDJIYR7QUYZYt7wk12GttxZznaifuQoalwFgxefasQNuV9sEc0U3Cq8aRwIA4PMyNrAAnAR+7zCqNgHZYjFKoNmPQHVy70TiJiKQ3upKBa+V7UClLvbgYcF1LgMPOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=i8PbSMIbGKpH21HZ7bfJ+tO2egH7QQ3j4iBGi/uT6tA=; b=x/JKzk3klIY40TPK27HEaxfLiu8OLw7hyMMf/BPe9WNgk0r6xS42z+v9SblUGdbPMToPCE50qG3Zo2iZdB8tL9bLzZdDl5A3vZP+wJZckSS1FItBk7kGnYdDd52D0NrxAajCN3p2Axaokm8kvRueldP3yeKBLPM9BeNqOMvu1amGA3PI3W7Lg5FedGuyHWobOTroojoqQkivyxO4BHc4zCU6DEs9nT9cAnmFkqZVcEpGLC0wBBEOFC7BpsHohoi+6AIbekQRatQDDhATF/LAYCDwlkMXgsZxE+ej9EBnpg327VAOmW/3VsxuDhtUFofBozVvUwb+oCsZ7x0bknf/Ow== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 13 Jan 2023 10:42:26 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 31/40] xen/mpu: disable FIXMAP in MPU system Content-Language: en-US To: Penny Zheng Cc: wei.chen@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , xen-devel@lists.xenproject.org References: <20230113052914.3845596-1-Penny.Zheng@arm.com> <20230113052914.3845596-32-Penny.Zheng@arm.com> From: Jan Beulich In-Reply-To: <20230113052914.3845596-32-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0168.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBAPR04MB7272:EE_ X-MS-Office365-Filtering-Correlation-Id: b100b8f3-aa81-481b-5ee9-08daf54a7c2e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EsD0qNZIVB6rMLtcWYlsQbwx3wTqMOjPQKEWJqCSCad25t4YaGMMR/Io7kohbFuYMJ21OT16gX38HDKO8PJkpxGT4hEEUG5LBJCF9TSEzF4LPQGcCj3wvHZGdfe5AMq8Y0wHPJYGdd6CzSgyPWG6RyOXa8XCBNyVDA7BDW+Med4413bDWsUH+/gBiQvHqhftxiJhVtbxGFRwOW04ws1UaKiVZ0jaBEW8mN5/yPl6rvYvlUoFaxvPObB/OstsO88CxTdIjHGFsckHVU4+mTLe/E60unN6vCem8ER/vDbXtPIDVGFch8onrphqM2o98OKR2wbPHeRE9JXGoNbLgml5+zC1G5FwNgLX04W8WSJZ+9sVHCyMHlSdhOcyZWQglJwE1poWQ3KvhdFMofmt3Wm0hcdmvzPRVqe3dfxivnnvUeuX008HoZ3PhdlwUEXbLxxnINT+pf1ytIgPeKn2ONM+upsGO2uyLLG16ACBKoYJE5BxiiI8HKGOpFcwQdKdobN+/aZjRmKUMVWZacTt7E6kIKQ1FlU1EhvpDy0u+4FW3NoAGAiGrVpbN4tuVb9x3UNvsUyP/8nbgPvEBRSwup/M1LMsPMUw0TxEg2ASHkb6qg0V8w9PcJ5bX7FGwHmPrF/F9ereGaENvHXYhm838A+L0CW6y8+HYpEEVQPtwMsxL5LW9FqYZ/2MceIwRFiOQkf35lxe9ERQmvPXeaHXsjPc36Gk7bUU3utkqySEYZqPBw4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(346002)(136003)(396003)(39860400002)(376002)(451199015)(31686004)(66556008)(4744005)(2906002)(7416002)(5660300002)(36756003)(66476007)(2616005)(8676002)(316002)(4326008)(54906003)(53546011)(41300700001)(6486002)(478600001)(8936002)(6506007)(26005)(6512007)(186003)(6916009)(31696002)(66946007)(86362001)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eDFhVGRBbkw0UkRDdHN4SFlQSytwbG9Cam9EQ2NnYmkyNDU3UmxRZUtBSXNi?= =?utf-8?B?WC9NbHBLSWZpMmVjZkk2MXJNQlpCOWtNYWs5ZEcwZWY2dy9zMC9XZWt3MWhB?= =?utf-8?B?U2JhM2p4ZGxKeHpubFRzRFJBeklMTzkrUG84U3Q4TzZKeGdSK0loUFJ0cWRV?= =?utf-8?B?ZkVZR2hzZFR5WHhiK2RScWlXWjBiTVVyb2FaWndXN1JCUDd3RE96RWZ1OEhR?= =?utf-8?B?M29zRW56TW5nYkFCazFScy9rTWNMQ1VpQWRRYlZzL0x6RjlHSUlkVXRUV3Jv?= =?utf-8?B?cW0xQ3BtVGJYSFpvSndQZU5ZQjdLZGxTcGFpbjZFdEUvMG9kTFNJMDNuOEow?= =?utf-8?B?NnMzTlIzTm5JUmJVY3lnVnFMYllQRFZQOTkvZTJtVFlrVkt1d0ppUHlqYzdV?= =?utf-8?B?cTEwQ1hlUmlSYThXRk53WmVwb0haUTNqYm8vRFhmYVdKemxDRXk0MG96MGdl?= =?utf-8?B?eUhPVHBEM0QxOU9pSFl0d0FtQkg3M2t1bndHTGtjNzN6Y2hXMnluejRyRmJm?= =?utf-8?B?Mzk3VlROTE9ZS0pvcEF3bG52QTljMFVvNjVqNFdnSkRCNkwwZzc5U0pCMk9n?= =?utf-8?B?SGxvS09OU2xDSE5sY25nRlMzdDAwZVBTSEtCRlB2dEd3TEk1eXc4c0swWlNE?= =?utf-8?B?dXJiM0lEU21TSUFKT3VuUWRpWFViaHFzNVoydzBUY3g2bkYva2JnODA1Q0hx?= =?utf-8?B?dzFoWXRhdVFmSkRNbUhXL25lWGJpNWJ1V2RVSkFnK2Qyb1QzYXdvNHBUaXk1?= =?utf-8?B?Nnp5WGhINmF2b2VSSk5JNGIxWUlDcVBBZGErUXIrR0RoUG15V0U2SkxBV0xD?= =?utf-8?B?SFhlUm9MUWhCYldOTmlzT1dhMzI4TnV0c2tlR1Zhb1MrTXU5V21mK0lJVGxT?= =?utf-8?B?UmJuZERvUnV3SERLZGJ1S2JrbUpJcU1xcHVNUExUT3hiMFhWSkpDbk9XcVVi?= =?utf-8?B?QjRPc3gzVmtuVWUxTURpWU96NGtld1k4eDI4Wm9tS21qMTd3b3FzcGlIcGxC?= =?utf-8?B?YXRBVnAyclZiN0NxbURDcnBvYVdxNE9HU1dHYnphZGQxbjZkUTRUM0xXdHB2?= =?utf-8?B?dEtVa2g4dEJxeXVKMmRreEt1Q295ZEtJMWxyMmdvOHROcVVJSXNwTlk2TWpa?= =?utf-8?B?NDFHMEVNZHRzdVBNNjIrZ3QvTmovMzlEaWZEZjFVUmlmRGF2UDlnb1ZFRmEv?= =?utf-8?B?YURTQnpaMk1Sd0QxanJMOTBnRVAvZ0lqbWRFbGFHWjBLOGhTa2ovYVN3NTdE?= =?utf-8?B?Znlvc0tham5mOTNWaWRSRXNXSVRsWUNPR2JxamY1YW9oaXhvMVF6blhuemkr?= =?utf-8?B?SVhhMVRZTzMrNlhNOThGYnNxMjFOQUVGcmpScm1Ec1B3SEtyKzFhYjNoeTB3?= =?utf-8?B?dUk1RTBQLzNKWnFvWG9Td1hJZHZaMHFvcTF6b3QzUGpjMkFkKzRTUTF3bFZD?= =?utf-8?B?b2owMkk3VGVyOFh1VGxtZ2oyTEJkMW1xWS9VT1VjdWRacktlSURTVG1sQklp?= =?utf-8?B?dWhQQTVUeGRHcDgrOFdnam1ER0oxWWYxZXRSZStncUpzOFBROXo0NitRd2dD?= =?utf-8?B?YlZocFU4RXpXL2YveEszZEtaaFh0UnhnSFlCWUZYYUI5TU9WU3hIZmdOV3ow?= =?utf-8?B?bElLUm84enR3cVZZa2ZmNzNKK05hbkIzWldKY016SVN2eGk1RldXRGU5M3RG?= =?utf-8?B?RWNUM1dvUkZPaW1udUlNckU2bytweHFEUEM3Mk1QTVMyem12RXdEZ2Fmczdm?= =?utf-8?B?bEU5bUNRb01LS3RBVTdsd2RWQ25LVnVRL3kwTXkyOFl6RDJEK0JUL1pESXVY?= =?utf-8?B?S0dHTTBqYUFmUG1VSjk0SHc5b0lPRDZxSFZKUGNuM2VQL2FPOXZydFNXcUNQ?= =?utf-8?B?dHFvb2htdVFIY2VNYThhQ3F5QTVVN0FvaW1kY2kvci9xakVhY1plOW55Zkc0?= =?utf-8?B?alFxOXVrMlVPdUNFY2N5c3VtNFpNYXFPNTBqRERoa2JFYU4yUGhwWThqNm9s?= =?utf-8?B?T01LNGhWQ1U5SUY5Z1pCMExxMUNwMHBDSUdObWR1bUhXNHlvTUxLK1ZEWDlF?= =?utf-8?B?R3hsVXZSaTZPaThOMlh5S0p2ZXNEbWNOT09DN3pGZ2twTENwOE5scjhZZzYz?= =?utf-8?Q?wO3gIF1hHz7ZsgHpqXtYRQSae?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b100b8f3-aa81-481b-5ee9-08daf54a7c2e X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2023 09:42:28.8332 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LFQWpp2RuXYxMZ7p7SnCnVuiT2rJJQH548bP67xT5kmkgHCdcDTqJWa2EXIEZ5AENua5FiVm00A4LPrMUrB1lA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7272 On 13.01.2023 06:29, Penny Zheng wrote: > --- a/xen/common/Kconfig > +++ b/xen/common/Kconfig > @@ -43,6 +43,9 @@ config HAS_EX_TABLE > config HAS_FAST_MULTIPLY > bool > > +config HAS_FIXMAP > + bool I think it'll end up misleading if this option is not selected by x86 as well. So imo you either add that, or you move the option to an Arm- specific Kconfig. Jan From xen-devel-bounces@lists.xenproject.org Fri Jan 13 09:49:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 09:49:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.476993.739480 (Exim 4.92) (envelope-from ) id 1pGGh3-00058z-1H; Fri, 13 Jan 2023 09:49:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 476993.739480; Fri, 13 Jan 2023 09:49:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGGh2-00058s-Um; Fri, 13 Jan 2023 09:49:48 +0000 Received: by outflank-mailman (input) for mailman id 476993; Fri, 13 Jan 2023 09:49:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGGh1-0004qT-La for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 09:49:47 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2070.outbound.protection.outlook.com [40.107.20.70]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9cdee9b5-9327-11ed-91b6-6bf2151ebd3b; Fri, 13 Jan 2023 10:49:46 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PR3PR04MB7434.eurprd04.prod.outlook.com (2603:10a6:102:8e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.12; Fri, 13 Jan 2023 09:49:45 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Fri, 13 Jan 2023 09:49:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9cdee9b5-9327-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bgxfBpqWOlP7kPPgJyxsSfXZXgMyDmwOoY4x+DXAEo9Yrcy/S8wzhxB5h+rOxyD1MFh3itQKmmWFhl0IP/XQLJk/OQhidZTrdXeTSMpvLBKGYpoP79MKLuHdplVaZvGu3kD+iZeymPPDvtk1sxKyu0CM2Ckdo6v4RjU4OMMb7Zt25UB+pwWxN/qd6ucvHmou1EJsTsMfvXDEXq0lXAQtQdi2W/Z33SeSoFKYdezqroPdmxdXk/3aM8FqA6+i+f/yamaJECVqDStgrF8in2mqz6sl50kmS9gT1wVTlBVTABUY//ysCd28tR9bZVj0RPdR3MrPp5L8UIIBF0fuoh0D/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IwfXkk+qTKlGw8HTM4dD2ubDPmrKmk+UOqeFoGLmFVA=; b=C//Lg72e+J5H3FG2EDqGFDj/waRKP26RP5+Qt+yvCW0kflovTA5pYHwfzIL+ta3jlf8zIiBBkI4ljlIETMFkpFjYieA5PzGp4oCIMRmqEykA1nGos8Z61PzDgOz44L8VVeApOa4KeD1exKdGFdE6H1VRECZDG6Jxf6iYUiNcKZQ1XkpfxGLsltz3HfBCKBhxFhd89n6yTaGUtEfqkLL2L1/zyXiF+SXqFcPwPKDggCrrrOAYKZMhLSLoYuUMNH25z3vOUxxQs3h4OwTYcjkHGUz5tiU4kBzNorksLSmy55C8SvFt4Gzss/PwpIyroTCFNJK8UaHoBkgRp9MDkJaxPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IwfXkk+qTKlGw8HTM4dD2ubDPmrKmk+UOqeFoGLmFVA=; b=ZoVk5v9/mCr7WNW31SsmZeInSOS9+rk/t5k6P+cPWFnM6pmsqBdQAiBfWag0RD1WHqMr4CsU/8JTq/+3XkCLUzIO6y5b0HJS+CzaPh3kNlJw6ycYhGKOEwmYgfByJ7GYTvW8j87cNTM52MByhyD5lgbWVTiRvwnIYF58igjvmDNQx2x2aWipgn6iAsFGG5B9vgoxcSw1khe/DVsO2LYWYxJwLvh+wCvSP0USVMOfZqVlmtkyY6/Rd4Hz163JQUjllNllCCYbFWwf/w0Z9Mn8qkqte46xKRyQtdhL2nCAoOjC94k13CxKj3nR3O0bt32mAPKiUaa23tRDzYhnijzPRA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <0cdb6601-c549-fd0f-18f1-6106ed3a7e2a@suse.com> Date: Fri, 13 Jan 2023 10:49:42 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 32/40] xen/mpu: implement MPU version of ioremap_xxx Content-Language: en-US To: Penny Zheng Cc: wei.chen@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , xen-devel@lists.xenproject.org References: <20230113052914.3845596-1-Penny.Zheng@arm.com> <20230113052914.3845596-33-Penny.Zheng@arm.com> From: Jan Beulich In-Reply-To: <20230113052914.3845596-33-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0002.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PR3PR04MB7434:EE_ X-MS-Office365-Filtering-Correlation-Id: 5d0d35a3-d2e8-46f5-27eb-08daf54b801b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3nkoPJUkXXf5PjA7gi4guV7U/khgvyJ13fsufRpY/OxfRPewHLC3h5WstCeK5NfbDnkyRXxj4/agdrhk1bM8zVjHolrd3mkRkVtayPf13wK7JA8vAhIG8rlucHjTHqhotcCzDi8I+s8j1QKp2ciL9nZTPkPuzYJdR18QnlTLuSmxuHOnoluydiKOxshajp19V/YQTXGpNNYQcTqDmNEl7oN48oUak7KNBYqswS6KT0LQcCNFtY+TVfJYiuLGbIWlHx4oUrFFSDRAlVcTtRWY5iKcPKD3xvsVbFix+lGyHc3oL8QT26LG9MJeK9uT56eWf6v9c6QeuXQLobX/kxf5+t2upE48Fftl1d4ehP4oMbcx6gwlpcKjalVPkdo6oZiLrxdU0qBaMo2VDOPBRqUnTcJ3goC7H2IZaoRPbojYS6VCgDc9i3QTpxt4Xd1T24mRJylU8VBEzOo//sJ3cnvI/vIIcyqoOJvBi+6HcenVXlW807DLttSEhjVgs3odsFEc/DAXYxZ/4IU9KJ6R4JCsHn5ExLwyeKs9vfRs1yCGukv9Jg1ICumVnPMSKKxlI8h/JlazB3XZAqR/fKh/8SuokE5Q+il5W/A5+61ZUmt7kKJ1mKIZec4uwyLcW+UMoteXyqzWlkKJbPvutZ5v1HlHSj4u6J5m1HjBmc8T/IpEkqVIuRg8soncYGluD/1iVtHVxUqKMsle0oFQhFt056TBZ4nXQU8E7089gk0ACTzO2UM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(366004)(136003)(396003)(346002)(376002)(451199015)(83380400001)(31696002)(38100700002)(86362001)(2906002)(4744005)(41300700001)(7416002)(5660300002)(8936002)(53546011)(478600001)(6506007)(6666004)(2616005)(186003)(26005)(6512007)(6486002)(316002)(8676002)(6916009)(4326008)(66476007)(66946007)(66556008)(54906003)(36756003)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R0Qzc28xTXVtV2RMb0ZGcDBnNFVaKzB0VUFWbUtDaWhBTmc0OTBkYmN4Vmo4?= =?utf-8?B?MHorbEJ0Y3B3QllvVFRmZnRVRjUrSEZZa0x2RjVDcDk4VVBtZ29DWjZ6T0sz?= =?utf-8?B?QzhsQzNNVFQ1L1Z0MjlsYWdIaEZvVnNTSFR1L0t5NGdZVFVXZUYvdWVMdytx?= =?utf-8?B?U3NDdG02ZHVjRzQvamM2Q0xZWWNMaVpXdllHcVEwN1VEMDdrVVF3TURvUGZr?= =?utf-8?B?QlRpd1VCb3RXc0xOM2IrL3Nmb1RzYVZLYmQyWWxnZTJQZDFkbXpRbGZ2ZUM5?= =?utf-8?B?ZjFjazR0dkVaaVdUTWpoS2ZTK09keW40RzhaZCtoUmFLYWp4eHJOa1pRWkZ1?= =?utf-8?B?d0ZqbUlJUThPV0pJRDc2azdUdkdJRDA5MFZaN1hlR1ZjV2dRQzUxZnBGL2Ir?= =?utf-8?B?bENmWThneHFhMmliMXYxYVFOblI2c29yMUFQVml4T3lDSktqWWE3S1FSZFIx?= =?utf-8?B?RGFITmk0djQ4L0NyK3hTZEpjMkp5cmFBUkhQWUdnRURTSXJacEY5YzRWU2Mx?= =?utf-8?B?dVBidGp0Vzh0UVdVQzJTZzZwWklhOFY1SHpxZDBoNEROSjE5Y2w1bGd3c3lB?= =?utf-8?B?VlJ1NVBnblhzajl1Q0pORmsvWjQzUkVwRzM2eWJEYlY2QTFoOWRCQXNKVzNC?= =?utf-8?B?UXJ6MmRiRjFWODVESDFWOE1LY2hNM2RhR0RhZ0dJbCtlK1kzRitWVUR1V3dJ?= =?utf-8?B?cjNJWGc4MHkveFlMRHNmSEFsS200RW5KOUtlRGRUeERmMHNHTnk0NGswRHJp?= =?utf-8?B?VXpMdHBNSXU1Zk1GbXQwQzhCTVhoR3hyYTlVazc2VHZKZXdwWXdqNFR4SDhk?= =?utf-8?B?WkJFSkFuM3JpSlpmRE40Rk5TRnBXZlFib01LQU5NeVBZM2wyUlNXMVRPalN5?= =?utf-8?B?U2tra0JjVjVpOUFaT3U5SkVvc3VVMS9lRC9LZDFzTTN2dmg0WEV0c0FzaCtF?= =?utf-8?B?UVNhbEl1QUxQWG1jUFJoL0liWFJVd2laZnM4UjdyMEpNYXlYSlVsVjRCais5?= =?utf-8?B?Q2hoeTMvTkFFZjFtSXBkNlg5TWdJeVlUZ3pES0pqZmNKREVDblZ6SkI3M2ZI?= =?utf-8?B?MXZlcXFrdGs0WmRaZzlPUlUrUzM1aVJTUFNWc3lYUlVrTUtvaVlLdXEyTlZo?= =?utf-8?B?aGFBSWJhQi82TWlTZTJrWW1WUnM4ekRaODFUL0xhU3BkbEg3dzJMb1lmYWJx?= =?utf-8?B?MXE1cW9uSFY5UWpranVNeEFnWGtSVm40SHNBYldyUXU5cXd6Z2h6Ynp6bFVm?= =?utf-8?B?aHdtV2hTM1E2a2J1Y21ESDEvb0wybVJXT3ZRVjN1ZEFBaHp5VFhLbEFkWUtq?= =?utf-8?B?aE9hczU3VmJ2UXlZalROSXBYZDV2WVQxdTF0OXMrdWdTZjJ1WWZQdmlOcG1x?= =?utf-8?B?SjY4NTVaRlM2WU4ySTdqV0MxMWNNYjBzTksrc2RCd1NwZjFBc0ZxRmQrbFcw?= =?utf-8?B?UUowTkp4SktCR2k3TTd2OU1wUlJueVIwbVorWkcvTzdYcUl0Q2VZRzA1eG5X?= =?utf-8?B?UWszRVZPTUpLV00xK0RaZWlVeEhXVVRPM2lIUnJremNoNHpSMFBrVW5Hc2hv?= =?utf-8?B?UDhZYWxiTTd6U1dvbGdkWkpBOWc4dGJqdnZHOWdwMWdBdDYyUDYvTVFKL2g1?= =?utf-8?B?dXptWjJCcjRsNlVXaFhFb2tkUXVoOUd1QmpvbW1MMU1FdlEyN2hYdDVFbG1R?= =?utf-8?B?OWJtTWJmalBXSkxGbWVUVzZ4c2RYLzVIOGJ2OER1dUhPc1dOcTlobDVPOHZS?= =?utf-8?B?K1FJQjJMNEs1c2lvNFp0ZXNXQzJtTXF4U084K3ZZUnlhVGdHaTRyb2QwQlV6?= =?utf-8?B?M24zd2svZTJPVkpqa0c1bEJCZEVSaXdkK1BTTTkrU0xicTRPWk45TzdoYUZO?= =?utf-8?B?cHlITGk1NEhVT0NiMmM4K1VGZUlYY0YzaU9pQnJOOHE1VmtvM3ZzK0phbmVp?= =?utf-8?B?dTdWWUp3c2pvOFJZN2dDb1Y4V2xMdGYzR09Fb1dORnJjbWxDc0hlUnUxQmNm?= =?utf-8?B?WkxnZzFIc3Z1NytGMFN5Qlp5Y3RUcmZZanNZTEd4T2YwZjdVd2tpTGlSVEpw?= =?utf-8?B?V1FQNnRUVnlqbWp1VlU1bmZhSVdmR2xDY050ZXNaYUMrdEw3VkprRmlkdzIy?= =?utf-8?Q?SUwkLQEeRunlca6aiFdRPFvQ0?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5d0d35a3-d2e8-46f5-27eb-08daf54b801b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2023 09:49:44.8993 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5yHrG4A4uoawHSxEboqGwFhc+Z0R03KRDWNJTuinvsNGBkBNu/c0AIbk0hasBc8++pSueaT13hZuVPi15HJ2Tg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7434 On 13.01.2023 06:29, Penny Zheng wrote: > --- a/xen/include/xen/vmap.h > +++ b/xen/include/xen/vmap.h > @@ -89,15 +89,27 @@ static inline void vfree(void *va) > ASSERT_UNREACHABLE(); > } > > +#ifdef CONFIG_HAS_MPU > +void __iomem *ioremap(paddr_t, size_t); > +#else > void __iomem *ioremap(paddr_t, size_t) > { > ASSERT_UNREACHABLE(); > return NULL; > } > +#endif If, as per the comment on the earlier patch, a mere declaration isn't sufficient, the earlier patch will need to make the stub static inline. I'm actually surprised you didn't see a build failure from it not being so. At the point here I then actually question why the stub function isn't being dropped here again (assuming it needs putting in place at all earlier on). Furthermore, once you want a declaration for the function here as well, I think it would be better to consolidate both declarations: It's awkward to have to remember to update two instances, in case any changes are necessary. Jan From xen-devel-bounces@lists.xenproject.org Fri Jan 13 09:53:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 09:53:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.477007.739491 (Exim 4.92) (envelope-from ) id 1pGGkR-0006kR-JG; Fri, 13 Jan 2023 09:53:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 477007.739491; Fri, 13 Jan 2023 09:53:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGGkR-0006kK-GM; Fri, 13 Jan 2023 09:53:19 +0000 Received: by outflank-mailman (input) for mailman id 477007; Fri, 13 Jan 2023 09:53:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGGkQ-0006jP-HQ for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 09:53:18 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGGkP-00069C-VS; Fri, 13 Jan 2023 09:53:17 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=[192.168.6.109]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pGGkP-0004RR-Li; Fri, 13 Jan 2023 09:53:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=8pfgQl2mn9F5L7jLw/qzo0IU8snzgpXloGwCpRa8eD8=; b=eNLFxcc0Wfhq3218pS9vIwq92j vCKHOfVXK3bMTlZT49GjoBO9p9dOXn/2d6FbwQ7OAuDQTIXJbg4SigZ96eV5FqoUN1AGV2e4XArSz StiWxX0cp8jabo/+KYleOTlgESLtltw0RUeSoi0cS4xqN7xAR3mu3SaWcsIunCXpKZzs=; Message-ID: <009d00d8-4ba9-167d-271f-0dde655415fa@xen.org> Date: Fri, 13 Jan 2023 09:53:16 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 10/19] tools/xenstore: change per-domain node accounting interface Content-Language: en-US To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20221213160045.28170-1-jgross@suse.com> <20221213160045.28170-11-jgross@suse.com> <05871696-1638-82d0-8d55-9088b4bb9a18@suse.com> <7ba1b191-ef89-1e0d-0e1b-0b24159a9eb9@suse.com> From: Julien Grall In-Reply-To: <7ba1b191-ef89-1e0d-0e1b-0b24159a9eb9@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Juergen, On 12/01/2023 05:49, Juergen Gross wrote: > On 11.01.23 18:48, Julien Grall wrote: >> Hi Juergen, >> >> On 11/01/2023 08:59, Juergen Gross wrote: >>>> ... to make sure domain_nbentry_add() is not returning a negative >>>> value. Then it would not work. >>>> >>>> A good example imagine you have a transaction removing nodes from >>>> tree but not adding any. Then the "ret" would be negative. >>>> >>>> Meanwhile the nodes are also removed outside of the transaction. So >>>> the sum of "d->nbentry + ret" would be negative resulting to a >>>> failure here. >>> >>> Thanks for catching this. >>> >>> I think the correct way to handle this is to return max(d->nbentry + >>> ret, 0) in >>> domain_nbentry_add(). The value might be imprecise, but always >= 0 >>> and never >>> wrong outside of a transaction collision. >> >> I am bit confused with your proposal. If the return value is >> imprecise, then what's the point of returning max(...) instead of >> simply 0? > > Please have a look at the use case especially in domain_nbentry(). > Returning > always 0 would clearly break quota checks. I am a bit concerned that we would have a code checking the quota based on an imprecise value. At the moment, I don't have a better suggestion. But we should at least document in the code when we think the value is imprecise and explain why bypassing the quota check is OK (IOW who will check it?). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Jan 13 09:54:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 09:54:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.477012.739502 (Exim 4.92) (envelope-from ) id 1pGGlA-0007Ho-SW; Fri, 13 Jan 2023 09:54:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 477012.739502; Fri, 13 Jan 2023 09:54:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGGlA-0007Hh-Pl; Fri, 13 Jan 2023 09:54:04 +0000 Received: by outflank-mailman (input) for mailman id 477012; Fri, 13 Jan 2023 09:54:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGGl9-0007DD-UR for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 09:54:04 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2044.outbound.protection.outlook.com [40.107.13.44]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 35b4ebe3-9328-11ed-91b6-6bf2151ebd3b; Fri, 13 Jan 2023 10:54:03 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU0PR04MB9250.eurprd04.prod.outlook.com (2603:10a6:10:351::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Fri, 13 Jan 2023 09:54:01 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Fri, 13 Jan 2023 09:54:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 35b4ebe3-9328-11ed-91b6-6bf2151ebd3b ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BVdoENX27JL4Mrz/aOpEKhUxpM7RQ1IVOUK01w2nrtcFGoEeqcm2uLWjXvAQIoyLSqIJ4TnRuBqsCqjmPY1FDPvBuAHQcO1UnG4KPtlH6iqWbzrRo2edR6F6Hqw/Y7eQ3jg6WqasqsR8WPHHfIHSoXJrmjbQOCCWdOvGgsfhjOFLqKf79mtvvjT3TeXW8arAHdqKo5A0W36na+Kks9SMQW/p+nvoJ+hQtggF/JvRxHxTAlGWXEe1KSHSZxC22EtyETotV19fIGMfxbF5CmKVgHdJSn5uULIBo8mln2YSIEqhCYPU6duU7eTrqHlwVFRM2iGKCHNt0Qos0Ggh3B9W/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FJyyx2XM3spic2azCfq9ReCKuK7+wPLVqDPl28tL3ao=; b=KhXemElA0fHyYlcJXXXohF0HgaE4gI/Og9+2ELYeqzqV8mSaKZ6sMLWWF/bmSCFaUJ5viVqe0lsgfwoSon9dmTeyRqmesrMvv9OeiQCV6uJRpZwCsUEo46GIdJY7FtBDO1q1CCf0ID+VA0FleswS9JNGiFtvUijYvGRLSKbCrp+QBnf1ob93ikDT/JOths+/Y+soRIc19UIrsol/cPxqeBZ/e9WP4BzGTc3j3rp3SXRCaB0pVRaC9z15Zz2KWiOm4zPS0OI0Rvh8BDdSDL5+v1zTKBtMd7o2SaDoxWt/VmZSTvBWJOmHcjSqwLQ1plavdr0sPhC/dWBNzmrHgNxmaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FJyyx2XM3spic2azCfq9ReCKuK7+wPLVqDPl28tL3ao=; b=RjmVNvc7KkHQt5OQnNRyKs6QXrOJ3Eyk9uqfBCZwfV+zPxRGXgMkN8D7Roy9owbRjImzNdlDa2aYmhJxbCHb/72ad5xOeEDKrA09GZWKc8y6uxzI85YZNufImCHE0R/9JYATww/8GhSLSml6UjkRTrSAPxfiZnTuQYSEKZvEp+e/SAdHIkLHaMmnFggCgoNa6545ZVymo7J7vKUrlkzoTGJtBVej9RXnY1tYy18a5hRrOT1bSKTViKey6QeNL6Z1XGZGqrgFHUhDoHvpLe490Z/X8EuigUH8AKfopvKin6zf6TB5llFt4f8VI5PPWv3uTqfff4sbR2AJa0p3GAnVuw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <88e3ec77-587a-ae68-a634-fed1fa917cd7@suse.com> Date: Fri, 13 Jan 2023 10:53:58 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 1/2] x86/shadow: sanitize iommu_snoop usage Content-Language: en-US To: Xenia Ragiadakou Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Tim Deegan , George Dunlap , "xen-devel@lists.xenproject.org" References: <01756703-efc8-e342-295c-a40a286ad5f1@suse.com> <6596d648-6400-7907-bc21-8074dc244247@gmail.com> From: Jan Beulich In-Reply-To: <6596d648-6400-7907-bc21-8074dc244247@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0039.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU0PR04MB9250:EE_ X-MS-Office365-Filtering-Correlation-Id: d456853b-779b-4734-1e83-08daf54c185e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /ZrCWPwd0hPwJIRSkBxu2uXJbu6oXfxO1SKN3TQYTpSAGWEe9ywGxhLO0NaKZma7DgyIjYcBCSkKuhB7GfuAxr0feczrW5abwicHY8IG5FaoG3nwaMh0DMaufCz0XinAh1+f19SJPEvu7dh6laXgSi5nxXNgvSyrcY+RzeqFEAmcwZHKhlSQOTDguZQxVIn4FQSYPBvQC5nMcpamAIrHgcJny0RySE3YHGQRsLaZJFEfK5Mgyo2D59rrNyT1ONDZ5+g1GympHDlYmwHzcKgcaQLEoAAP1r4KDyRKed4uxz5A2bzpp8l62a3TFK/YPdRldH+DQnL7LZv6VMpmkd9VkvKQuFINo5l9vsBzmSjKg4B6m+lxO6UC1Y1hZYrqIpZGrEo1iaj0JR6Ers5opwLewhqPjztwe32S2d+bvItTgHgd7zP09te6dXywkmV39vJKwm4Eun51dLrg3bb77S1SyJu6NHFAw+fSkAgx4ymc2lyXAZ6HR7WCJhKx+JQp0ttLz+5COh3zgo536nveHr8e1hyIuWSgkdoeVqNOacxvEWeaeTtOUDdYcBLFPDia5QlzQua856Wr1XSsmpijN6Fv2WrMcAx/IdG0EjAvNlK3L61gTEI5/R2xU0oq8HVhZVhZB6evnScfywn1kBCqPLs6pMXCCeKRn7rwn/zNjV8LQ+sjG2jD4NfGoO+vVCHPMLT6voWjruAM53980iwmEKXIEOs9Q0vyBtgxfe5fHnlWj9QY837CBy//PHndZ3TRce39SdAEfwuNJukw8GT5fz87HA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(396003)(376002)(366004)(136003)(346002)(451199015)(53546011)(2906002)(6506007)(966005)(6486002)(478600001)(26005)(6512007)(186003)(31686004)(54906003)(36756003)(4326008)(6916009)(316002)(66946007)(66476007)(2616005)(8676002)(66556008)(41300700001)(5660300002)(83380400001)(38100700002)(8936002)(86362001)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OS9hNThWMHplek14VUlzK1N2Tzg2REtKZ2Z3TUR2ZVh3N2ZHU0wxVWFSVjEv?= =?utf-8?B?YkRwdkhzcS9SMWFKNmh5VHNPd3JOMGQ0djRISmUwL1ZhUjAvQ25mcjBNeHlU?= =?utf-8?B?THYxRVJqTkV0amdNU0JuVDVXbm5FanMvYVhQaUpiaHpObzhLYkVZNWFjVUlR?= =?utf-8?B?WW1qQjdGa0tsS3hwL0JtRzVPV1prUDdTdTU2L01EenBJSFY5K1JCZ0tzTUI3?= =?utf-8?B?SElhM1ZHaFlBQ0kzUkZuUUM5bFBOMkhoTGcwM2ZSS2szTG5KZGJLL2xjWmFO?= =?utf-8?B?SUtGdjg1NzF6dlZUNmJCSk9VNFNDM1lWUzFOZlNtaDdDUktGWG5yTFNrVEYw?= =?utf-8?B?aFR2R29uT0dWaERHUC9IYnBHcWYvTTIySzVhVzBhcnpTMHQ4QkRVcENyekFM?= =?utf-8?B?Nk10LzJrNk5Jc0JzMmVpSmYyZnlYK2x6SUUyamk2UlJUMWl1THpPamsvRjFB?= =?utf-8?B?RFBWbVIxeUt4MDc4UGN5Q1c3K3o3bTVRNi9GZ0VlODBiakJnY2N0SSttaEgy?= =?utf-8?B?djNIcHZ3L2haWS9ZT05JQTRIamlRdFBuOEV1UjZPUGV2cWdyUTdCMEhXMENi?= =?utf-8?B?bmlkejFJMzk2b0xZN0JhelBVcDg0ZG4yemcrTzJ6aStkTC9CYWRhWFZVVzBN?= =?utf-8?B?MEZTNFUyTEVkL29VNGdDUkZkbnZ2Ty9NcXZYbjhta2dsV1VoVTJVR1Q3aHJM?= =?utf-8?B?bzUzeXU4VTRMSkxvYlkxZE9nL2hkSW1DU2c4aFlzc1QrNGYwYWJ2aVBHcFVC?= =?utf-8?B?MTFPNmxoV3lBcWhoODM0YlRROGhRbFU1OHZaUDRWL2xyMTlVa0t1ai9KVExK?= =?utf-8?B?Y3hqdkg3WHA5bkU4aWxtS283cERGbHhmUUJmcmF3TzZoSnI3dytJajlmMDZn?= =?utf-8?B?d2hCM0JxQ1grQyszcERjNHcyUk5qaWQ4dXJwZUZBWHpxRFBtQlZHc0gwb0Y4?= =?utf-8?B?bmZoSHdscHo5OU1Lb09XQm9oWVhDdEgwWmVQcENFcDRyUEl0U0xvaXpHSkd6?= =?utf-8?B?c3dUenhOS3VIUFdmTHdhNXEvV1l2UUREbU9MVVNaNDZDd09yZms1ZnlCUUIy?= =?utf-8?B?Z1lCNnMzQ2FJMGRmd2FoTGhqMU8wSndwYmZsNlJuZVVJS2N4SFZBZU1VaCtm?= =?utf-8?B?WGlVWkNTNEttQzdFZ0srVURrS3g2YU5iZ3pHNmM5K1E0WXBienZxRGYyZzNF?= =?utf-8?B?OFo2bUdZZEU5dW1jRXZXTnlmSkdjU0xPOGhaTWlURm16Y1NhN1BVcFkwaURP?= =?utf-8?B?dmd2bmc5QTNpQWxVUndlSGVhTHBsRUpCR09zZDNzSWRSRWZaOWtXUlJQb29K?= =?utf-8?B?WSt2SCtmeCtaVlNZY01iUVRobkQ1bFdic1BOTzNqTEs1SHBxY3RzM1h4amZq?= =?utf-8?B?Y0RuWHNmY0ExME1vcDJIb2JiRHFYL0J4TWFZQmNmTGN0UGl0aHk0UFY2cUg2?= =?utf-8?B?UjEwZkFCeWxRM3d6eHJRL21FQ3c2NUZlZnJrNTFlSjlpL2NkS2diNkVxWjB3?= =?utf-8?B?cnA1NjZKZ0Z4K0YyL2hTV0dYNVFpclhCdVdpdmo3cVRVRjg5Y0ZlNU1HRno1?= =?utf-8?B?TWVVNjJBek0ycEFqYzhYbGlybjB3cmRBUjhaSU9QbnNORWFXUGFuUWIvUC9o?= =?utf-8?B?WWZBQkdEaXhPT21RenhCeHcrREg3dWFXWEV4MnNUY0tRSUpjOTZhc0pDaWxF?= =?utf-8?B?WG00N1E4Um1vNXM0YWFHN0xLalp1OHU3R2J2MUVWNXNYbEt1c3BRT3VYRk5Z?= =?utf-8?B?dDgwdkJOMzgxWEJiZUFzT3VkQlgwWDBJWjY3Qy9KVmRTRVkvSzlHc2tsSzZ4?= =?utf-8?B?RFMrcmRKbmJ2SEZSOTFFTG95ajdtWWQwd3kxMSs3MTEyMjBKeDc2WTczMC9B?= =?utf-8?B?dzlDYVBBKytkbUVuSmovbWt0R1Y0dENCUm1pS3JzaUVYR0g2V1B2N3Uxb0Ex?= =?utf-8?B?dEpZRjl2UU91bnZFQTJaa29XMjViSGhoenR4Q2dadTE3THdyYWVhZDExVlZt?= =?utf-8?B?VjZmV2ZZM2c0UXNMNzRZNGkzNXZCcVpwQ1M4dWE1WnkrQzJYMmQzTnpVV0xG?= =?utf-8?B?TE1mYWtuZncwQkZobmZ3Mmt2cWpYNTdyRHpCd0xyVjN1YUFOVFBNcDNCSGI3?= =?utf-8?Q?dG+QeccbWhy5v0EDFVsTDtUyk?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d456853b-779b-4734-1e83-08daf54c185e X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2023 09:54:00.4143 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 208b2rHInIfjXRQjYl5zDRsdes5SvlWPvMvGwPHqZ1+Z3vbhbCG9ey+czWV7a46bQ//Ra19oR3XgJ0gi3Fc0Pw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9250 On 13.01.2023 10:34, Xenia Ragiadakou wrote: > > On 1/13/23 10:47, Jan Beulich wrote: >> First of all the variable is meaningful only when an IOMMU is in use for >> a guest. Qualify the check accordingly, like done elsewhere. Furthermore >> the controlling command line option is supposed to take effect on VT-d >> only. Since command line parsing happens before we know whether we're >> going to use VT-d, force the variable back to set when instead running >> with AMD IOMMU(s). >> >> Signed-off-by: Jan Beulich >> --- >> I was first considering to add the extra check to the outermost >> enclosing if(), but I guess that would break the (questionable) case of >> assigning MMIO ranges directly by address. The way it's done now also >> better fits the existing checks, in particular the ones in p2m-ept.c. >> >> Note that the #ifndef is put there in anticipation of iommu_snoop >> becoming a #define when !IOMMU_INTEL (see >> https://lists.xen.org/archives/html/xen-devel/2023-01/msg00103.html >> and replies). >> >> In _sh_propagate() I'm further puzzled: The iomem_access_permitted() >> certainly suggests very bad things could happen if it returned false >> (i.e. in the implicit "else" case). The assumption looks to be that no >> bad "target_mfn" can make it there. But overall things might end up >> looking more sane (and being cheaper) when simply using "mmio_mfn" >> instead. >> >> --- a/xen/arch/x86/mm/shadow/multi.c >> +++ b/xen/arch/x86/mm/shadow/multi.c >> @@ -571,7 +571,7 @@ _sh_propagate(struct vcpu *v, >> gfn_to_paddr(target_gfn), >> mfn_to_maddr(target_mfn), >> X86_MT_UC); >> - else if ( iommu_snoop ) >> + else if ( is_iommu_enabled(d) && iommu_snoop ) >> sflags |= pat_type_2_pte_flags(X86_MT_WB); >> else >> sflags |= get_pat_flags(v, >> --- a/xen/drivers/passthrough/x86/iommu.c >> +++ b/xen/drivers/passthrough/x86/iommu.c >> @@ -56,6 +56,13 @@ void __init acpi_iommu_init(void) >> if ( !acpi_disabled ) >> { >> ret = acpi_dmar_init(); >> + >> +#ifndef iommu_snoop >> + /* A command line override for snoop control affects VT-d only. */ >> + if ( ret ) >> + iommu_snoop = true; >> +#endif >> + > > Why here iommu_snoop is forced when iommu is not enabled? > This change is confusing because later on, in iommu_setup, iommu_snoop > will be set to false in the case of !iommu_enabled. Counter question: Why is it being set to false there? I see no reason at all. On the same basis as here, I'd actually expect it to be set back to true in such a case. Which, however, would be a benign change now that all uses of the variable are properly qualified. Which in turn is why I thought I'd leave that other place alone. Jan From xen-devel-bounces@lists.xenproject.org Fri Jan 13 09:57:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 09:57:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.477021.739514 (Exim 4.92) (envelope-from ) id 1pGGop-0007xI-Di; Fri, 13 Jan 2023 09:57:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 477021.739514; Fri, 13 Jan 2023 09:57:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGGop-0007xB-8w; Fri, 13 Jan 2023 09:57:51 +0000 Received: by outflank-mailman (input) for mailman id 477021; Fri, 13 Jan 2023 09:57:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGGoo-0007x5-3T for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 09:57:50 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bbbdf79a-9328-11ed-b8d0-410ff93cb8f0; Fri, 13 Jan 2023 10:57:48 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id AF21E253AF; Fri, 13 Jan 2023 09:57:46 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8E96013913; Fri, 13 Jan 2023 09:57:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id t5SKIRorwWPaBgAAMHmgww (envelope-from ); Fri, 13 Jan 2023 09:57:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bbbdf79a-9328-11ed-b8d0-410ff93cb8f0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1673603866; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=boXpsw2LAjhiHUbAzcspld7diNzrPJHZXzIePBCgJ4s=; b=VnaRTYVKUW9q/wnKbVGV6jaSlnvYjmVclpbsy3kxXTMXb843dEqtyiuOgkBeGhAIPnD71l y1bh7SZhYOhMv/wfxg9bMSVMT79Y+fe63P9CwYIcIwxnWtotp3LXNsdmg6C5T2SKAptu8p bsq/pl3DTF+H2rgmkMZgbbCSixaOKXA= Message-ID: Date: Fri, 13 Jan 2023 10:57:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 10/19] tools/xenstore: change per-domain node accounting interface Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20221213160045.28170-1-jgross@suse.com> <20221213160045.28170-11-jgross@suse.com> <05871696-1638-82d0-8d55-9088b4bb9a18@suse.com> <7ba1b191-ef89-1e0d-0e1b-0b24159a9eb9@suse.com> <009d00d8-4ba9-167d-271f-0dde655415fa@xen.org> From: Juergen Gross In-Reply-To: <009d00d8-4ba9-167d-271f-0dde655415fa@xen.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------Uyeak0oqpO00idGXm6iMd0du" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------Uyeak0oqpO00idGXm6iMd0du Content-Type: multipart/mixed; boundary="------------5Mf4DjpLiz3hlP5CwQzejHyR"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD Message-ID: Subject: Re: [PATCH v2 10/19] tools/xenstore: change per-domain node accounting interface References: <20221213160045.28170-1-jgross@suse.com> <20221213160045.28170-11-jgross@suse.com> <05871696-1638-82d0-8d55-9088b4bb9a18@suse.com> <7ba1b191-ef89-1e0d-0e1b-0b24159a9eb9@suse.com> <009d00d8-4ba9-167d-271f-0dde655415fa@xen.org> In-Reply-To: <009d00d8-4ba9-167d-271f-0dde655415fa@xen.org> --------------5Mf4DjpLiz3hlP5CwQzejHyR Content-Type: multipart/mixed; boundary="------------AwP04EUSeiwXsn7hEGlUf8M0" --------------AwP04EUSeiwXsn7hEGlUf8M0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTMuMDEuMjMgMTA6NTMsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGkgSnVlcmdlbiwN Cj4gDQo+IE9uIDEyLzAxLzIwMjMgMDU6NDksIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBP biAxMS4wMS4yMyAxODo0OCwgSnVsaWVuIEdyYWxsIHdyb3RlOg0KPj4+IEhpIEp1ZXJnZW4s DQo+Pj4NCj4+PiBPbiAxMS8wMS8yMDIzIDA4OjU5LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0K Pj4+Pj4gLi4uIHRvIG1ha2Ugc3VyZSBkb21haW5fbmJlbnRyeV9hZGQoKSBpcyBub3QgcmV0 dXJuaW5nIGEgbmVnYXRpdmUgdmFsdWUuIA0KPj4+Pj4gVGhlbiBpdCB3b3VsZCBub3Qgd29y ay4NCj4+Pj4+DQo+Pj4+PiBBIGdvb2QgZXhhbXBsZSBpbWFnaW5lIHlvdSBoYXZlIGEgdHJh bnNhY3Rpb24gcmVtb3Zpbmcgbm9kZXMgZnJvbSB0cmVlIGJ1dCANCj4+Pj4+IG5vdCBhZGRp bmcgYW55LiBUaGVuIHRoZSAicmV0IiB3b3VsZCBiZSBuZWdhdGl2ZS4NCj4+Pj4+DQo+Pj4+ PiBNZWFud2hpbGUgdGhlIG5vZGVzIGFyZSBhbHNvIHJlbW92ZWQgb3V0c2lkZSBvZiB0aGUg dHJhbnNhY3Rpb24uIFNvIHRoZSBzdW0gDQo+Pj4+PiBvZiAiZC0+bmJlbnRyeSArIHJldCIg d291bGQgYmUgbmVnYXRpdmUgcmVzdWx0aW5nIHRvIGEgZmFpbHVyZSBoZXJlLg0KPj4+Pg0K Pj4+PiBUaGFua3MgZm9yIGNhdGNoaW5nIHRoaXMuDQo+Pj4+DQo+Pj4+IEkgdGhpbmsgdGhl IGNvcnJlY3Qgd2F5IHRvIGhhbmRsZSB0aGlzIGlzIHRvIHJldHVybiBtYXgoZC0+bmJlbnRy eSArIHJldCwgMCkgaW4NCj4+Pj4gZG9tYWluX25iZW50cnlfYWRkKCkuIFRoZSB2YWx1ZSBt aWdodCBiZSBpbXByZWNpc2UsIGJ1dCBhbHdheXMgPj0gMCBhbmQgbmV2ZXINCj4+Pj4gd3Jv bmcgb3V0c2lkZSBvZiBhIHRyYW5zYWN0aW9uIGNvbGxpc2lvbi4NCj4+Pg0KPj4+IEkgYW0g Yml0IGNvbmZ1c2VkIHdpdGggeW91ciBwcm9wb3NhbC4gSWYgdGhlIHJldHVybiB2YWx1ZSBp cyBpbXByZWNpc2UsIHRoZW4gDQo+Pj4gd2hhdCdzIHRoZSBwb2ludCBvZiByZXR1cm5pbmcg bWF4KC4uLikgaW5zdGVhZCBvZiBzaW1wbHkgMD8NCj4+DQo+PiBQbGVhc2UgaGF2ZSBhIGxv b2sgYXQgdGhlIHVzZSBjYXNlIGVzcGVjaWFsbHkgaW4gZG9tYWluX25iZW50cnkoKS4gUmV0 dXJuaW5nDQo+PiBhbHdheXMgMCB3b3VsZCBjbGVhcmx5IGJyZWFrIHF1b3RhIGNoZWNrcy4N Cj4gDQo+IEkgYW0gYSBiaXQgY29uY2VybmVkIHRoYXQgd2Ugd291bGQgaGF2ZSBhIGNvZGUg Y2hlY2tpbmcgdGhlIHF1b3RhIGJhc2VkIG9uIGFuIA0KPiBpbXByZWNpc2UgdmFsdWUuDQo+ IA0KPiBBdCB0aGUgbW9tZW50LCBJIGRvbid0IGhhdmUgYSBiZXR0ZXIgc3VnZ2VzdGlvbi4g QnV0IHdlIHNob3VsZCBhdCBsZWFzdCBkb2N1bWVudCANCj4gaW4gdGhlIGNvZGUgd2hlbiB3 ZSB0aGluayB0aGUgdmFsdWUgaXMgaW1wcmVjaXNlIGFuZCBleHBsYWluIHdoeSBieXBhc3Np bmcgdGhlIA0KPiBxdW90YSBjaGVjayBpcyBPSyAoSU9XIHdobyB3aWxsIGNoZWNrIGl0Pyku DQoNClRoZSBpbXByZWNpc2UgdmFsdWUgd2lsbCBuZXZlciBiZSB0b28gbG93LCBpdCBjYW4g b25seSBiZSB0b28gaGlnaCAoaS5lLiAwDQppbnN0ZWFkIG9mIG5lZ2F0aXZlKSwgYW5kIHRo YXQgd2lsbCBvbmx5IGhhcHBlbiBpbiBhIHRyYW5zYWN0aW9uIHdoaWNoIGNhbid0DQpzdWNj ZWVkLg0KDQpBZGRpbmcgYSBjb21tZW50IGlzIGdvb2QgaWRlYSwgdGhvdWdoLg0KDQoNCkp1 ZXJnZW4NCg0K --------------AwP04EUSeiwXsn7hEGlUf8M0 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------AwP04EUSeiwXsn7hEGlUf8M0-- --------------5Mf4DjpLiz3hlP5CwQzejHyR-- --------------Uyeak0oqpO00idGXm6iMd0du Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPBKxoFAwAAAAAACgkQsN6d1ii/Ey8D 3gf+M3w+cEW9DbgNQ1jyjEnPNnUyObjc9ANE4P7zjDWq0LU7tNeKt1SoDjIj+SCKCD7bXTT6JuC3 PGVHcfPn1EXal8ud7Ej4FANsyo4UplNU1XnlPkVBfTsG2jRSBVb2I0liJy0aX23I1BkRG6TqIn/l C79CprcxtysJuuLxxfdB3WQ2G6owdzvm7NxgJcAjFN4wYCIv5TxSnIaihTQu1npsRyZLzAT7Ta+v 9gSTNtInkzSvNR5F11SvsvW3JyywFWUvnA4kZxXGY1BJG2GZ54t8gmv3ZEUs+5OguYmE0PIx1RJQ W3tYgC0DnH0ydOv9m9Ze5yDBYkgYBd6f/7sSvGL4Vg== =5b36 -----END PGP SIGNATURE----- --------------Uyeak0oqpO00idGXm6iMd0du-- From xen-devel-bounces@lists.xenproject.org Fri Jan 13 10:04:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 10:04:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.477027.739524 (Exim 4.92) (envelope-from ) id 1pGGvP-00016p-6F; Fri, 13 Jan 2023 10:04:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 477027.739524; Fri, 13 Jan 2023 10:04:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGGvP-00016i-3C; Fri, 13 Jan 2023 10:04:39 +0000 Received: by outflank-mailman (input) for mailman id 477027; Fri, 13 Jan 2023 10:04:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGGvN-00016c-SW for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 10:04:37 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGGvM-0006SL-SQ; Fri, 13 Jan 2023 10:04:36 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=[192.168.6.109]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pGGvM-00054W-Mx; Fri, 13 Jan 2023 10:04:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:To:Subject:MIME-Version:Date:Message-ID; bh=fFSIUkU5lnR2R24I4ISYYt/AWncFbL5EYvZaBl/MsR4=; b=GlfOTophUu0noKodOkVFXrA/80 L6sje1gSAyJcEmKvxJMXAi7KQwIgH5lpnKrZsGI79sWgT2wRgfEhtAb2247cm+MNvrElDxnjywY4s XxcQ09R8ZkuYnRr1lkp/u64PMnDuqeZlMtuEzVPkTpOrOtMYJSJ7XO40RzgCCjo5Ykt4=; Message-ID: Date: Fri, 13 Jan 2023 10:04:35 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2] xen/arm: Add 0x prefix when printing memory size in construct_domU Content-Language: en-US To: Michal Orzel , Andrew Cooper , Ayan Kumar Halder , "xen-devel@lists.xenproject.org" References: <20230103102519.26224-1-michal.orzel@amd.com> <1264e5cc-1960-95d3-5ecb-d6f23d194aa4@xen.org> <29460d07-cd43-7415-7125-6ed01f3c2920@amd.com> <35d590fb-4b96-70dd-a60b-1c8d7cc8f2d6@citrix.com> <383485e0-37ac-9b0c-f0c5-18e50cf7905b@amd.com> From: Julien Grall In-Reply-To: <383485e0-37ac-9b0c-f0c5-18e50cf7905b@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Michal, On 06/01/2023 10:41, Michal Orzel wrote: > > > On 05/01/2023 13:15, Andrew Cooper wrote: >> >> >> On 05/01/2023 11:19 am, Julien Grall wrote: >>> On 05/01/2023 09:59, Ayan Kumar Halder wrote: >>>> Hi Julien, >>> >>> Hi, >>> >>>> I have a clarification. >>>> >>>> On 05/01/2023 09:26, Julien Grall wrote: >>>>> CAUTION: This message has originated from an External Source. Please >>>>> use proper judgment and caution when opening attachments, clicking >>>>> links, or responding to this email. >>>>> >>>>> >>>>> Hi Stefano, >>>>> >>>>> On 04/01/2023 23:47, Stefano Stabellini wrote: >>>>>> On Tue, 3 Jan 2023, Michal Orzel wrote: >>>>>>> Printing memory size in hex without 0x prefix can be misleading, so >>>>>>> add it. Also, take the opportunity to adhere to 80 chars line length >>>>>>> limit by moving the printk arguments to the next line. >>>>>>> >>>>>>> Signed-off-by: Michal Orzel >>>>>>> --- >>>>>>> Changes in v2: >>>>>>> - was: "Print memory size in decimal in construct_domU" >>>>>>> - stick to hex but add a 0x prefix >>>>>>> - adhere to 80 chars line length limit >>>>>> >>>>>> Honestly I prefer decimal but also hex is fine. >>>>> >>>>> decimal is perfect for very small values, but as we print the amount in >>>>> KB it will become a big mess. Here some examples (decimal first, then >>>>> hexadecimal): >>>>> >>>>> 512MB: 524288 vs 0x80000 >>>>> 555MB: 568320 vs 0x8ac00 >>>>> 1GB: 1048576 vs 0x100000 >>>>> 512GB: 536870912 vs 0x20000000 >>>>> 1TB: 1073741824 vs 0x40000000 >>>>> >>>>> For power of two values, you might be able to find your way with >>>>> decimal. It is more difficult for non power of two unless you have a >>>>> calculator in hand. >>>>> >>>>> The other option I suggested in v1 is to print the amount in KB/GB/MB. >>>>> Would that be better? >>>>> >>>>> That said, to be honest, I am not entirely sure why we are actually >>>>> printing in KB. It would seems strange that someone would create a >>>>> guest >>>>> with memory not aligned to 1MB. >>>> >>>> For RTOS (Zephyr and FreeRTOS), it should be possible for guests to >>>> have memory less than 1 MB, isn't it ? >>> >>> Yes. So does XTF. But most of the users are likely going allocate at >>> least 1MB (or even 2MB to reduce the TLB pressure). >>> >>> So it would be better to print the value in a way that is more >>> meaningful for the majority of the users. >>> >>>>> So I would consider to check the size is 1MB-aligned and then print the >>> >>> I will retract my suggestion to check the size. There are technically >>> no restriction to run a guest with a size not aligned to 1MB. >>> Although, it would still seem strange. >> >> I have a need to extend tools/tests/tsx with a VM that is a single 4k >> page. Something which can execute CPUID in the context of a VM and >> cross-check the results with what the "toolstack" (test) tried to configure. >> >> Xen is buggy if it cannot operate a VM which looks like that, and a >> bonus of explicitly testing like this is that it helps to remove >> inappropriate checks. > I can see we are all settled that it is fully ok to boot guests with memory size less than 1MB. > The 'memory' dt parameter for dom0less domUs requires being specified in KB and this is the > smallest common multiple so it makes the process of cross-checking easier. Stefano is ok with > either decimal or hex, Julien wanted hex (hence my v2), I'm more towards printing in hex as well. > Let's not forget that this patch aims to fix a misleading print that was missing 0x and can cause > someone to take it as a decimal value. I have committed it with my acked-by. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Jan 13 10:06:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 10:06:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.477033.739535 (Exim 4.92) (envelope-from ) id 1pGGxX-0001fx-GT; Fri, 13 Jan 2023 10:06:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 477033.739535; Fri, 13 Jan 2023 10:06:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGGxX-0001fq-Dq; Fri, 13 Jan 2023 10:06:51 +0000 Received: by outflank-mailman (input) for mailman id 477033; Fri, 13 Jan 2023 10:06:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGGxV-0001fk-JM for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 10:06:49 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGGxV-0006VY-Bn; Fri, 13 Jan 2023 10:06:49 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=[192.168.6.109]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pGGxV-0005BZ-4w; Fri, 13 Jan 2023 10:06:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=JRxBYx/YUF4D8/wWQVmasMas3TMqyWh4Aj5kGQ8fr9c=; b=PhpK+vTCsmVqOtK0ROww7AANIl HWejeFyADa4MPIGyWncWmpkO++2DyectF3k1S2gI1TUrnGc6hb9Aj28edxJtP82LzCN9xBpynhAjk CLee0SoLX1YK7f5Zt+tzrV/poxLyF4wwTQDuPfPe/ZfUlTuOqlD4vtBCp+Ro6jxzpYIo=; Message-ID: <2e8a80d6-b45d-f852-1e54-7c6e0ae4f2fd@xen.org> Date: Fri, 13 Jan 2023 10:06:47 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 01/40] xen/arm: remove xen_phys_start and xenheap_phys_end from config.h Content-Language: en-US To: Penny Zheng , xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Julien Grall References: <20230113052914.3845596-1-Penny.Zheng@arm.com> <20230113052914.3845596-2-Penny.Zheng@arm.com> From: Julien Grall In-Reply-To: <20230113052914.3845596-2-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Penny, On 13/01/2023 05:28, Penny Zheng wrote: > From: Wei Chen > > These two variables are stale variables, they only have declarations > in config.h, they don't have any definition and no any code is using > these two variables. So in this patch, we remove them from config.h. > > Signed-off-by: Wei Chen > Acked-by: Julien Grall I was going to commit this patch, however this technically needs your signed-off-by as the sender of this new version. If you confirm your signed-off-by, then I can commit without a resending. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Jan 13 10:10:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 10:10:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.477040.739546 (Exim 4.92) (envelope-from ) id 1pGH1S-00036q-WB; Fri, 13 Jan 2023 10:10:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 477040.739546; Fri, 13 Jan 2023 10:10:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGH1S-00036j-TQ; Fri, 13 Jan 2023 10:10:54 +0000 Received: by outflank-mailman (input) for mailman id 477040; Fri, 13 Jan 2023 10:10:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGH1S-00036d-1Z for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 10:10:54 +0000 Received: from EUR03-VI1-obe.outbound.protection.outlook.com (mail-vi1eur03on2055.outbound.protection.outlook.com [40.107.103.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8f0faa43-932a-11ed-b8d0-410ff93cb8f0; Fri, 13 Jan 2023 11:10:52 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB9523.eurprd04.prod.outlook.com (2603:10a6:10:2f6::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.12; Fri, 13 Jan 2023 10:10:49 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.012; Fri, 13 Jan 2023 10:10:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8f0faa43-932a-11ed-b8d0-410ff93cb8f0 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eMtW6vDs5RTymkdjl8yDRs/w/O7LDNjYjK/8jBtnfwGbIs9zoJk1WV4NiFlFoR2Q+c4iPcmbfwRHTgm9mwTH3kugk9AFkgC6IaA8Edakh15oRMEWeg9DTV7JYOxqiXEqXL3iSgFE0xb0cQe3NMPKCkn+7P+5F8WNbfQHtZNcal+2yVVdWDP30+sLwNsa17dFMecmEGoztTfA2x7BMgw5lxEmgW6gbUle9xv0wNgcAxKLyPPDYMKDYpZlPgE5qcvENUnVHtqOPfcMC+YqW0qgXFNBWn8Q90AnTqvba5Q/RE4D997BbNcQjdvhVexzlh+M+434qe0Lf94pQwwsvHscTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZPle0OiTX6gcbg4/T+rGFfpPHXHPkX+AcLreLlEi0Iw=; b=DazdDQubrR+lzhX4V/R2ar1hxtwQW3SraFL+3gTzyiFZq5yz+vdmj0+JbWNGe3PYBmYw5JgbzHxQMObN18pYZjbwb4HKF9TuNGqb0uVM88r98qHRX2wMVX+2i8M3NEgI8fPuuCI4IEFxcaTAKSj0PLW6FXBwTVwTTJQtTPFRzar44minLR5K5MvHPeHTZWi1sXslP6i8m5FpuGSeW2D58GZPEZYxKZyL8eyMi6oYqHj/PzyttRFTajAvNbfQJKJT7Oi9+7FIAl0GJUMlgsc81ewJYLcEsN4tvaGTDX2Huoja6YPbdCgf0CVlSVP2KwBeHnt9xwWMAeBS/xzRgZKviQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZPle0OiTX6gcbg4/T+rGFfpPHXHPkX+AcLreLlEi0Iw=; b=FGwisb5M5++3i0C3B+y4c3ac18+K686+uoigFmNx/3sWLGLCZqj+tXpj3Kq+/nOcu/7hnyJbyzwI1fB/Ls/0AMu2mAAANTUQVzpHk/H6KBvCUv39i7E/hp3l9pswBZkXnu9zuihBUHsDP98UxMgJXl9CjGQiBCajgwO5bv4C1z4z3o9Ngr99z8VgrqZe8q3eSgbzBLFtv0j/ccAHEj1s+yUaetONNMKymH2B88vJ1O46l3WtEQ73c2h+sD6y1aTMc87JsglRTDp0Ix5z0FIONaPW+lyeB2CPOhett0O1i5kAlZ+YNetjmb1a64/x40pE3Y8Z2gQfwQcIQnTfPiD41Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 13 Jan 2023 11:10:47 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 31/40] xen/mpu: disable FIXMAP in MPU system Content-Language: en-US To: Penny Zheng Cc: wei.chen@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , xen-devel@lists.xenproject.org References: <20230113052914.3845596-1-Penny.Zheng@arm.com> <20230113052914.3845596-32-Penny.Zheng@arm.com> From: Jan Beulich In-Reply-To: <20230113052914.3845596-32-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0172.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB9523:EE_ X-MS-Office365-Filtering-Correlation-Id: 2f45cc95-6b3d-471a-47d5-08daf54e71e1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gMbOHL7TicYcwr4/9Xh6Y84e0aSoUPmqzDw1tYWt6iTAARK9qWi5NfSN4S0VU7myEaQOqbkVm48KjCBcmqjZOS21nU/CfOYdytUbAA7UeU9XB4X20yBxiMM7nFN3Ione8sSZFV7Ds9NkbsgSEoJws/2iY8UrDri5MBZ4r5NnJVdiTTU7457Q0K8NsPYb4gNR0oe7efyJVW/6T8ra98SZQco6Sgb2nKSNxOTx94Gmo1uKGbqxaqJDl76p1XZqgsunOTs6V0LcyhbgfsiuH1inFMwXyZTdvDBTPoiYQQpPSkkaKtAAT9HwsRmYQ6RcHYMZ0sda3DChc3Rf8qijBFUSjIHcZY8Ay+oZu8dSOmloq5wPsti7XP6cia1dd+8HJ79y9lFicmODEdmfXIDFpgDGwO+4emYAcwFWeK/YO5Ki65dWraeOpY6Z3neMIWt4pZUpmtMDamAdrDAadRjrP8uM4xXQ+tic6zBYIvFWZcqhD2+oInkA/1XgsJMXpzMdNBxBwNFTy4v/l5HYKw5HTjDVY+SfauP1uNuKuS8bm9fNFpUS9Z0R6/7qXShHKxMobrOTWks/xYGmIB0mzD9YRrOYXtd8gmpJVJnI+pRuK6viz1YO94SS9ZQX5LqUvPCWAw5HpyKwjeTomA6+cL8QoHj07HrrGqmvg8E5KVXfZjUrdsx7l6Ls3xIsH8KvDkEHK5OALP8nsVqGuVatc1CyEFWrDwHu2jVGd87uhN2tO+hE7uo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(396003)(136003)(346002)(376002)(39860400002)(451199015)(38100700002)(31696002)(8936002)(8676002)(6916009)(86362001)(5660300002)(7416002)(4744005)(66476007)(2906002)(4326008)(66556008)(66946007)(54906003)(41300700001)(6512007)(6506007)(26005)(2616005)(53546011)(186003)(316002)(478600001)(6486002)(31686004)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SmFnTlg1emtrdFo0L0ZuUkZXbnNHSVg4STV0Si94V2tHQkRvYUUwWHl5amhH?= =?utf-8?B?dGRqMFdKUExMZy94cWo3VittcEJtOTU4L0FRVFZFY051Nm4ydVNpRkVOeGlY?= =?utf-8?B?MytYeWtmUzErczBGTVhJT3U5NUVZblBiVmFkNWRSeGJpSkIrQ3ZDcjZJYmd5?= =?utf-8?B?RDVsczZPT1lqdno0V0d4NEk5TjM2cUVFU3BiVFNoMEFTR0hlTWtya3J0SVhM?= =?utf-8?B?emVCbkNXQ3dyUE9VL0g2Q1FqM2NFRWtxQ04ya29SMXpDTVlnd1FGa0hxSllh?= =?utf-8?B?K2V5djRRd3FuWmNlNDR0UDNEb1RVZ3ovdkM3ZDRiaUNSeHNXMEE5b1J5OXpw?= =?utf-8?B?ZGlwWWZMTE5aZWcrdFkzR1RHUTJGYTdYNVdzeUNHdGZjcTZaOExLKzU5M29G?= =?utf-8?B?cUpZTTdqOXRQZ1ljdUp5YUt0bERTQ0lEZkNjSWFlL2UwZEZiL1hTZmZQWUZS?= =?utf-8?B?aTArdUVEOGZYQWFndmFqSGJCSytCTkRJYWt5VzhSc1Z5SVpnMnNwTDVPeVFs?= =?utf-8?B?UGgrOXVlY2RGdVdWZ25VZS9FaWhtR3VhTUlYcDhiNDFkWmxHNHFkdGNPQy9h?= =?utf-8?B?TmdCK1lkVVlkaml1dFRObzlIR0tvU2JlTElSeGk3UlF5UnlPYUF4TDYyY1lE?= =?utf-8?B?bElVWG9UM3RmRzlqS3JuWlJzK3dBeEJyaVAyKzFjYmM1VDNSdUpDSmJmMGFE?= =?utf-8?B?TkpBUGRkdjFQQXJwY3VFbTFzNVV3YTgyMmwwVmdOMDBPYUd0amh2QzVEVzZK?= =?utf-8?B?cGxzbCtVNHN3MFFxSDhlUWlTLzhHN2YxVGFBS1NValhkTUptNUN0S1RsTFlC?= =?utf-8?B?ZmkwT3AxY0NLVzY5eGxhMWxycFpFWW5JTkRxblFRaThkbEZCeW9zNkFpM2Z1?= =?utf-8?B?Zm1HMnZlWDZNOHBOSnIvQzRXeDFqeHZjTzNVSDdPSkdiK1U0YTlqaTJLMTZS?= =?utf-8?B?aVNPQTZISFN2RmNyK0UzWkRtcGtwQ3BjdExaOUZiSU41blBBWkl1bkpaMmU2?= =?utf-8?B?UVZIM2t6NHFmWitQeVpCbU9RNWt1YzdyNWtjdVI2QThoeHd4K01qNmJNUU0y?= =?utf-8?B?MGtEeTJqRTh3NFl3aXFsYjR0YWwrZnpoc0YwdFVMU3pOb1ZsMDZNVzJFQUdw?= =?utf-8?B?aWFVcnZ3RmQ3RnJoMkdCWFFrbFU1TFJTS01ETXhmUTYrcEpaWlhQeWxwL0dW?= =?utf-8?B?aUNLZFY3N016MkViT3dsakhpZU5BUVJuZENnMGI3eEtQLzNOcEl4OC9NNzNE?= =?utf-8?B?Y3VBMlVnRmZlekVJVzVQRjVJZ2VrcXZsN05wdmZmV0RRTHphSlhJMHNSZjR4?= =?utf-8?B?RzVvWEZVTzBHMDQ0TVVZTHJxakR5UFJOTEZncmlLWHFHV1VkZHRIMC9HWk50?= =?utf-8?B?aGthUVpSQisxa0dEVWxyQnkraDlhelBhM1NoeTNTNjNOWmJQWm1PeEJyWFB0?= =?utf-8?B?bEJFZU5oaTNnUmE5NnM2NUF0NE4rZk9PNVg4MzhpZGhYNW05QXRmajFpdXo2?= =?utf-8?B?WjY1bEREeDdiTlpabWdFZUMwVGhHbVhoYkZFNFYrQkljUzBrdnZCWFhsSCtN?= =?utf-8?B?NzVPSDh2V3JPWVlNME9MV1ZRMnljNXNNUXhOcFQ3T2dwNUppdlk0aWNHc0hC?= =?utf-8?B?WDFjMnZtM1J1Q0NQMVQzaWdyVU5yaEU4YXBQVGZqMmhsSUhMNGY5Q04rMVc3?= =?utf-8?B?bysvZEVSbzJ0WGVtMUdPRnpielIwNzFvOWdSUU5rWU5jUnJSc2xJempuZjZr?= =?utf-8?B?VWJ6UW56emZZR3E1KzhSYkVocm9zdFhVUEd4RVYreUNVS01aaENLaTlLRmlZ?= =?utf-8?B?V2JQaDZlTGVBZTZucllTQXViV1RldFJwa04zK2tjY0NqNU1ham96dW9hbHZE?= =?utf-8?B?QVBkWW1raFMvRUp0cExZaGFWcU5zMUtCUFpDY2VTREZRbWZuU2ZXb1EvdXpa?= =?utf-8?B?OWh2UXR6SXJMS3R5QnMzZSsxUHAvTHJxZ3hpdHBhbkNaV0lUTEpGZFRDVzE4?= =?utf-8?B?YUJxZHlCek9UWTV3MnFyMmIxVTRmQW9xd2FOWFV6ODBYdVRtVndBSFhVcWpm?= =?utf-8?B?ckdMTFIzeTRZQWxrMVZ1UEdsWnR4ZUE4UVJWRDF3RkxoK01sM3dadWNISDlE?= =?utf-8?Q?Y5QW6xGqxqdvwag+flvrsn4wN?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2f45cc95-6b3d-471a-47d5-08daf54e71e1 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2023 10:10:49.4752 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OPv/YZ7bspYYllCF3RshEbZ6MgP4v8giNMbkCjsWvbw9JJdCezUiHg4oSBN2M7rvZUzCndKRF1Zvktk9lgI6fA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB9523 On 13.01.2023 06:29, Penny Zheng wrote: > --- a/xen/arch/arm/Kconfig > +++ b/xen/arch/arm/Kconfig > @@ -13,9 +13,10 @@ config ARM > def_bool y > select HAS_ALTERNATIVE if !ARM_V8R > select HAS_DEVICE_TREE > + select HAS_FIXMAP if !ARM_V8R > select HAS_PASSTHROUGH > select HAS_PDX > - select HAS_PMAP > + select HAS_PMAP if !ARM_V8R > select IOMMU_FORCE_PT_SHARE > select HAS_VMAP if !ARM_V8R Thinking about it - wouldn't it make sense to fold HAS_VMAP and HAS_FIXMAP into a single HAS_MMU? Jan From xen-devel-bounces@lists.xenproject.org Fri Jan 13 10:11:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 Jan 2023 10:11:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.477046.739558 (Exim 4.92) (envelope-from ) id 1pGH2D-0003dF-8k; Fri, 13 Jan 2023 10:11:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 477046.739558; Fri, 13 Jan 2023 10:11:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGH2D-0003d8-5g; Fri, 13 Jan 2023 10:11:41 +0000 Received: by outflank-mailman (input) for mailman id 477046; Fri, 13 Jan 2023 10:11:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGH2B-0003cv-Ru for xen-devel@lists.xenproject.org; Fri, 13 Jan 2023 10:11:39 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pGH2B-0006cb-JC; Fri, 13 Jan 2023 10:11:39 +0000 Received: from 54-240-197-224.amazon.com ([54.240.197.224] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pGH2B-0005Ty-9h; Fri, 13 Jan 2023 10:11:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:MIME-Version: Message-Id:Date:Subject:Cc:To:From; bh=YhEWC1pOoPWCZQofIj01JkZYD5T1f8EmgftS4PFxN4U=; b=IdGznh+1OpnY911Q3qV2fbnAWB BjRFMzM5QKLzmKw+6LaC0/nSDU7ojHmaMCf81sRwo5hGpBHGSAjPuLo9wpkwy1tZ7iz8da/jz9yvY ed03tMMQjqjtqVH32dxKb6Xm6E8qShEXnyT338hOf2PctssDe2fmA9ktj2jo6Vlq8vU8=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: Luca.Fancellu@arm.com, Julien Grall , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v4 00/14] xen/arm: Don't switch TTBR while the MMU is on Date: Fri, 13 Jan 2023 10:11:22 +0000 Message-Id: <20230113101136.479-1-julien@xen.org> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Julien Grall Hi all, Currently, Xen on Arm will switch TTBR whilst the MMU is on. This is similar to replacing existing mappings with new ones. So we need to follow a break-before-make sequence. When switching the TTBR, we need to temporarily disable the MMU before updating the TTBR. This means the page-tables must contain an identity mapping. The current memory layout is not very flexible and has an higher chance to clash with the identity mapping. On Arm64, we have plenty of unused virtual address space Therefore, we can simply reshuffle the layout to leave the first part of the virtual address space empty. On Arm32, the virtual address space is already quite full. Even if we find space, it would be necessary to have a dynamic layout. So a different approach will be necessary. The chosen one is to have a temporary mapping that will be used to jumped from the ID mapping to the runtime mapping (or vice versa). The temporary mapping will be overlapping with the domheap area as it should not be used when switching on/off the MMU. The Arm32 part is not yet addressed and will be handled in a follow-up series. After this series, most of Xen page-table code should be compliant with the Arm Arm. The last two issues I am aware of are: - domheap: Mappings are replaced without using the Break-Before-Make approach. - The cache is not cleaned/invalidated when updating the page-tables with Data cache off (like during early boot). The long term plan is to get rid of boot_* page tables and then directly use the runtime pages. This means for coloring, we will need to build the pages in the relocated Xen rather than the current Xen. For convience, I pushed a branch with everything applied: https://xenbits.xen.org/git-http/people/julieng/xen-unstable.git branch boot-pt-rework-v4 Cheers, Julien Grall (14): xen/arm64: flushtlb: Reduce scope of barrier for local TLB flush xen/arm64: flushtlb: Implement the TLBI repeat workaround for TLB flush by VA xen/arm32: flushtlb: Reduce scope of barrier for local TLB flush xen/arm: flushtlb: Reduce scope of barrier for the TLB range flush xen/arm: Clean-up the memory layout xen/arm32: head: Replace "ldr rX, =